alphaZero implementation ideas and passing state to rl_agent

First of all, thanks for making this framework open source.
I’m investigating the possibility of making a (simplified) alphaZero implementation using openspiel, and I was looking for some implementation ideas, especially since you already mention this in the contributors guide.
Please note: I am not sure if I will have the time to make the code up to openspiel standards. Also I might not very closely follow the alphazero pseudo-code. Thus, I am uncertain sure whether this effort will eventually result in a pull request. I still think some pointers would be very helpful, since others might be going to work on similar algorithms.
Implementation wise, it seems most logical to me to create an rl_agent implementation called alphaZero. When taking a step however; the agent will perform a MCTS. To do this, a complete game state will have to be reconstructed. The easiest way to do this would be to pass the current environment state as an argument to the step() function of the rl_agent and then creating a game with this state internally in the rl_agent. This feels  hacky to me: instead of using the time_step argument, which was seemingly designed to provide all available information to the agent, you are feeding it extra with the full game state (of course, in a perfect information game this would be available already anyways).
What would be your perspective on this topic?
Of course, any other design advice on the implementation would be very welcome as well.
tl;dr: How to do state reconstruction in rl_agent? Do you have design advice on the implementation of an alphaZero-like algorithm?

Thanks for your interest! You're right that the AlphaZero algorithm doesn't conform to the rl_agent API, since it makes use of a simulator for the game. It would be more natural to implement an AlphaZero actor as a bot (see python/bots or spiel_bots.h) with a separate learning process.
Since you mention perfect information, it might be worth pointing out that the AlphaZero algorithm is only designed for games of perfect information - it won't learn low-exploitability stochastic policies, and it doesn't have memory.
Happy to discuss further!

Thanks!
I just wanted to point out a few links, in case you may not be aware of them. There is the https://github.com/leela-zero/leela-zero project which reproduced the AlphaZero results on Go (One of their challenges was to find the compute power to generate enough games, and they crowd-sourced it, pretty impressive).
For a smaller scale, simpler version, I do not looked at them, but a rapid search showed there are already a few tutorials/implementations out there:
https://github.com/suragnair/alpha-zero-general (it happens I could speak with one of the authors. Even though it is named AlphaZero, it is an AlphaGo implementation, for a course university project.)
https://towardsdatascience.com/alphazero-implementation-and-tutorial-f4324d65fdfc
https://towardsdatascience.com/from-scratch-implementation-of-alphazero-for-connect4-f73d4554002a (pytorch only I think)
So I imagine that depending on you goal (learning more about AlphaZero, implementing it from scratch, getting something that works on small games, including it in OpenSpiel), the process can be different, but this may be helpful if you are looking to learn more about it. (If an implementation is derived from any of outside project, we must take care that the licence allow us to get a modified version in).

Sorry I'm late replying on this, thanks for your interest.
I think ideally what we'd like is a very simple implementation -- maybe enough to validate it on Connect Four, by reproducing the work showcased in this series of blog posts: https://medium.com/@sleepsonthefloor/azfour-a-connect-four-webapp-powered-by-the-alphazero-algorithm-d0c82d6f3ae9
That said, it's a rather large undertaking -- at least a course project's worth of work. I think a first cut done all in python with absolutely no bells and whistles would be fine (just enough to convince ourselves that it is indeed correct). We could, e.g., optimize this by dropping down to C++ for the search + inference later. It's also nice if the reference implementation is very bare, because we would want it to be a stepping stone to build and learn from.
This is why I like the idea of just following exactly what was done in the blog post above, because (hopefully) the hyperparameters and architecture could be copied and there should be no time lost to not being sure whether it's the wrong set of hyper-parameters versus whether there is a bug or not.
All this said: it doesn't have to be one person that does everything! Feel free to start building the scaffolding, and either we will help or guide building on top of it. Maybe we could even start that scaffolding (which would be similar to the pseudo-code in the paper) and encourage a team effort where people fill out the bits and pieces.
I should mention: an implementation of AlphaZero is the top-requested feature (I have at least 4 requests for it so far), so it would be really great if we discussed a plan to make this happen. We could also try to get some feedback from the AlphaZero team as well.

@danielwillemsen I just noticed you have separate implementation of AlphaZero for Connect Four that you're already working on(!).
Briefly looking through the code, it's very similar to the "basic"/"vanilla" AlphaZero that I was anticipating having in OpenSpiel.
How well is it working? Were you aware of the blog posts I linked about?
From what I can tell, it would not be too difficult to take what you have and bring it into OpenSpiel, though I admit I took a very quick look. What do you think?

@danielwillemsen: I wanted to also tackle this project, and saw that you've started. What is your status? Do you still plan to integrate your work into OpenSpiel?

Hi, thanks for your interest!
My implementation is currently still on a separate repository. In short, the implementation works with openspiel and I have been using it myself quite a bit.

It can be used for different games in openspiel, I have tested it for connect-four and breakthrough (6x6).
It uses pytorch (and currently a resnet architecture is implemented)
It plays multiple games in parallel, with the possibility of using multiple GPU's. Although it does not reach a very high GPU utilization (my python MCTS implementation is fairly slow).

The main downside is that the parallelization has made the code quite a bit more complicated and messy. In general, the whole code quality is poor.
I am still hoping to find some time to create a clean and stripped down version of it, which I would still like to integrate into openspiel. Realistically, I won't be able to finish this on my own for another month or two at least, as I am currently focused on my research, but I could find some time to work on it.
If you would be interested in working on this together, I can put a minimalistic version without all the parallelization in an openspiel fork, and we could work from there? Let me know what you think, and feel free to ask for any more information.
Cheers!

Thanks for giving me such a detailed update! One option I'm considering is focusing on the Swift implementation. I think that an Alpha Zero port would be a great showcase for Swift for TensorFlows virtues (eg. being able to write an efficient MCTS implementation directly in Swift). But would be more than happy to also help out on the Python version, and ensure the two implementations are consistent.

@sbodenstein if you run into issues or would like help debugging something with a S4TF implementation, please don't hesitate to reach out! :-)

@sbodenstein and I are planning on spending this coming week on this, we will report back here soon!

An update from me: I should have a working Python AlphaZero implementation in the next few days that integrates cleanly into OpenSpiel and maximally reuses existing functionality (eg MCTSBot).

A quick update from me: I have an MCTS implementation in Swift. It is not yet tested, however. Will try to finish this off before Christmas, and at least sketch out how we can extend it to support AlphaZero.

Just an update on my side: have gotten back to this today after the holidays, and have an AlphaZero implementation mostly ready (https://github.com/Aule-AI/open_spiel/tree/python_alpha_zero). Will make a PR and start a design discussion in the next day or two.

We have recently merged the PR by @sbodenstein here:
https://github.com/deepmind/open_spiel/pull/134
So I will close this now, but more contributions are still very welcome! Thanks for your interest in OpenSpiel.


luci-app-openvpn - git-19.296.26319-ca781af-1

Good morning.
I'm running:
OpenWrt 18.06.4 r7808-ef686b7292 / LuCI openwrt-18.06 branch (git-19.170.32094-4d6d8bc)
on a tp-link WD8970 v1.
Yesterday I figured out there was an update of the openvpn package and I upgrade it.
Since then, anytime I try to edit one of the openvpn profile I'm redirect to a page with only this message:

Failed to execute cbi dispatcher target for entry '/admin/services/openvpn/basic/custom_config'.
The called action terminated with an exception:
/usr/lib/lua/luci/model/cbi/openvpn-basic.lua:37: attempt to index global 'fs' (a nil value)
stack traceback:
/usr/lib/lua/luci/model/cbi/openvpn-basic.lua:37: in function 'func'
/usr/lib/lua/luci/cbi.lua:66: in function 'load'
/usr/lib/lua/luci/dispatcher.lua:841: in function </usr/lib/lua/luci/dispatcher.lua:835>

As I've been playing a lot with the configs I thought I mess up the system so at teh end I performed a total reset flashing with serial and tftp. As soon as I installed the package I received the same msg
At this point I think the problem is beyond me messing up ahahaha
If more info are required please let me know
cheers
mauro

Hello,
This is related with https://github.com/openwrt/luci/commit/ca781af2f8052d2469d3e6f533208c9e6e9648d4.
I requested https://github.com/openwrt/luci/issues/3163
But there were some additional stuff build around

Thanks for the feedback. That was my mistake when cherry-pick didn't pay attention that fs wasn't imported with reqrire. With the other branches this was already changed.
Since I don't have a device with the firmware openwrt-18.06, can someone please change the following change manually in the source and check if that works?
Replace the following line in /usr/lib/lua/luci/model/cbi/openvpn-basic.lua
local has_ipv6 = fs.access("/proc/net/ipv6_route")

with
local has_ipv6 = nixio.fs.access("/proc/net/ipv6_route")

If so, I would check it in.

Made a quick check by coping the file to a router with master branch.
And as discribed by @gipsea it does not work.
After the change it works again.
I did a push to openwrt-18.06 with the changes.
See https://github.com/openwrt/luci/commit/fbefeed9731ba4dc5c2269bc9ffc29d7541bb30d
@gipsea Thanks again for reporting good job


systemd: enable debug info

Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[x] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

How big are these?

/nix/store/wg3h2lw2gj4fwgdib16wndn21rlphgc7-systemd-254.6-debug	 35.4M

I think this change broke 32-bit build of systemd on staging:
$  nix build --no-link -f. pkgsi686Linux.systemd -L
...
systemd> Error: failed to link 'src/core/bpf/restrict_fs/restrict-fs.bpf.unstripped.o': Invalid argument (22)

The failure happens because separateDebugInfo has an effect of passing -ggdb -Wa,--compress-debug-sections. both gcc (systemd's executables) and clang -target bpf (BTF programs) are built against these flags.
And bpftool rejects created debug sections due to alignment mismatch (probably between compressed and uncompressed alignments data?).
I rpoposed a tiny patch to improve error message around bpftool as<EMAIL_ADDRESS>I'm not sure where the exact bug is. I would say we should never pass -Wa,--compress-debug-sections to clang -target bpf until bpftool support around it is sorted.

Can we revert this? This seems like something that only needs to be enabled by the few who need it, and that creates problems in other cases.

Yes, let's revert this for now. It can always be reenabled after tested with some less common architectures, but there's no need to keep them broken until separateDebugInfo = yes on them is figured out.

I didn't say we couldn't, but writing that code takes more time, while the revert is quick.
I pushed a revert at https://github.com/NixOS/nixpkgs/pull/272947, happy to review another commit that introduces debuginfo for known-working platforms afterwards, but no need to keep staging broken until someone does do that.

Proposed the knob to disable debug section compression and re-enable split debug data for systemd: https://github.com/NixOS/nixpkgs/pull/273096

I didn't say we couldn't, but writing that code takes more time, while the revert is quick.

How long does it take to conservatively write separateDebugInfo = stdenv.hostPlatform.isx86_64 || stdenv.hostPlatform.isAarch64? We don't need to be exhaustive at first, but we could stay at near 100% coverage with no more effort than a revert.

I meant to say, I did not have access to a beefy aarch64 builder, so I couldn't say for sure that PR does not also regress aarch64-linux. The report was about 32bit only, but maybe aarch64 was broken too, who knows? I figured the revert was easier, unbreaking staging, while this can be refined without too much of a rush.


Support substitution of the text from the context in answers

Here is an example:

      q_RENOVATE_ROOM "Which rooms were renovated?",
      :help_text => "Probe: Any others? Select all that apply.",
      :pick => :any,
      :data_export_identifier=>"EIGHTEEN_MTH_MOTHER_RENOVATE_ROOM.RENOVATE_ROOM"
      a_1 "Kitchen"
      a_2 "Living room"
      a_3 "Hall/landing"
      a_4 "{{C_FNAME}}’s bedroom"

The pull request for this feature is #264


Exclusive context policy ensures EnsoContext.get returns compilation constant

Pull Request Description
Fixes #6809 by giving up on any attempt to share Node among multiple Context via sharing a single Engine.
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:

[ ] All code follows the
Java,
All code has been tested:

[ ] Benchmark results are sane
[ ] Another benchmark results are sane
[ ] SharedContextTest is passing

There is a discussion about ContextReference at GraalVM slack. Technically ContextReference shall return a compilation constant, but it didn't so far. Using EXCLUSIVE context policy turn EnsoContext.get into compilation constant - that might also speed up our benchmarks.

SharedEngineTest fails on the CI trying to download an edition. Probably an Engine configuration problem.

DebuggingEnsoTest asserts - fixed in d1b5913e49d3a6785689b95bec88c7ad21d66be7

The first Benchmark results were not good, but the second benchmark results are sane. Running 3rd benchmark results to confirm the result.


Compiler warning in drivers/i2c/i2c_gpio.c when CONFIG_I2C_GPIO=y

Describe the bug
I've got Compiler warning in drivers/i2c/i2c_gpio.c when CONFIG_I2C_GPIO=y
<ws-path>/zephyr/drivers/i2c/i2c_gpio.c:144:54: warning: passing argument 3 of 'i2c_bitbang_init' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]

using nRF52832
using si7210 sensor with I2C GPIO driver.

To Reproduce
Add this overlay:
/ {
	gpio_i2c0 {
		compatible = "gpio-i2c";
		status = "okay";
		clock-frequency = <I2C_BITRATE_STANDARD>;
		sda-gpios = <&gpio0 18 (GPIO_OPEN_DRAIN)>;
		scl-gpios = <&gpio0 17 (GPIO_OPEN_DRAIN)>;
		label = "GPIO_I2C_0";
		#address-cells = <1>;
		#size-cells = <0>;

		si7210:si7210@30 {
			compatible = "silabs,si7210";
			reg = <0x30>;
			label = "Magnetic proximity sensor";
			status = "okay";
		};
	};
};

and this Kconfig's:
CONFIG_I2C=y
CONFIG_I2C_GPIO=y
CONFIG_SENSOR=y
CONFIG_PM_DEVICE=y
CONFIG_SI7210=y

Import .overlay snippets mentioned above and enable Kconfig flags mentioned above.
Also, I have all warnings enabled in my app build.
Expected behavior
The warning should not occur.
Impact
The impact is the clutter of the build. Also, the kernel shouldn't have any warnings in my opinion.
Logs and console output
Here is the last snippet of the build log:
-- Zephyr version: 3.2.99 (<ws-path>/zephyr), build: v3.2.99-ncs2
[163/251] Building C object zephyr/drivers/i2c/CMakeFiles/drivers__i2c.dir/i2c_gpio.c.obj
<ws-path>/zephyr/drivers/i2c/i2c_gpio.c: In function 'i2c_gpio_init':
<ws-path>/zephyr/drivers/i2c/i2c_gpio.c:144:54: warning: passing argument 3 of 'i2c_bitbang_init' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
  144 |         i2c_bitbang_init(&context->bitbang, &io_fns, config);
      |                                                      ^~~~~~
In file included from <ws-path>/zephyr/drivers/i2c/i2c_gpio.c:38:
<ws-path>/zephyr/drivers/i2c/i2c_bitbang.h:43:64: note: expected 'void *' but argument is of type 'const struct i2c_gpio_config *'
   43 |                         const struct i2c_bitbang_io *io, void *io_context);
      |                                                          ~~~~~~^~~~~~~~~~
[241/251] Linking C executable zephyr\zephyr_pre0.elf

[245/251] Linking C executable zephyr\zephyr_pre1.elf

[251/251] Linking C executable zephyr\zephyr.elf
Memory region         Used Size  Region Size  %age Used
           FLASH:      189680 B       512 KB     36.18%
             RAM:       35257 B        64 KB     53.80%
        IDT_LIST:          0 GB         2 KB      0.00%

Environment (please complete the following information):

OS: Windows 10
Zephyr SDK
Zephyr version v3.2.99-ncs2

Please keep the title brief and do not put warning/error output in the title. Describe what the issue instead.

This was fixed by https://github.com/zephyrproject-rtos/zephyr/commit/aced3bb2ac1e2e69a35f74edb723a08f57f33aab. Thanks for reporting!
cc @gmarull


Education service limits incorrect? 400000 requests per 20 seconds, 35000 requests per 10 seconds

This section here:
https://docs.microsoft.com/en-us/graph/throttling#education-service-limits
States: 400000 requests per 20 seconds  35000 requests per 10 seconds
This seems very high compared to other APIs and I am getting HTTP 429 rate limited way below this figure.
Is there an issue with the auto generation of these documents? For example were these both intentional increases to the figures:
https://github.com/microsoftgraph/microsoft-graph-docs/commit/e8edc1010fb2496f9f3c09f36085702738d97f32#diff-753c5ef5e83cee56bf0bbeccc5e82f3c3fd89009108e01f89d1ef9eed3abb595
https://github.com/microsoftgraph/microsoft-graph-docs/commit/bbcbcc09be36618b13179a029c6d027588918c9b

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 8df32e5f-8ccb-0c93-28d9-02392f9c7256
Version Independent ID: 4aadd084-fb61-e89b-f63f-3b71622636b7
Content: Microsoft Graph throttling guidance - Microsoft Graph
Content Source: concepts/throttling.md
Product: non-product-specific
Technology: microsoft-graph
GitHub Login: @davidmu1
Microsoft Alias: MSGraphDocsVteam

Closing as this seems to be fixed. Thanks.


[build-presets] Test SwiftSyntax and related projects in CI

Re-enable testing of SwiftSyntax and downstream projects in CI testing.
This was first enabled in https://github.com/apple/swift/pull/27855, then reverted in https://github.com/apple/swift/pull/28159 and https://github.com/apple/swift/pull/28169 because the corresponding bots did not check out the SwiftSyntax or stress tester repositories. Re-enable it once the bots check out these repos.

@swift-ci Please smoke test


Enable dry-running addon sync

@jim-minter @pweil- adds dry run for addons. I don't feel strong on how outputing the resources works (stdout vs generating all files in a directory even though I guess we want to latter for convenience). I am going to merge this for now since I need it for debugging.

:+1:


Update CouchDB from 3.1.2 to 3.2.2 version

Impact of the new feature
WMCore in general
Is your feature request related to a problem? Please describe.
CouchDB 3.2.2 fixes a critical vulnerability security, in addition to bringing in tons of enhancements and bug fixes.
Now that we are running CouchDB 3.1.2, there is no incompatibility of the database file format. This update will also give us an opportunity to actually build a vanilla CouchDB, dropping all the CMS custom patches completely.
Describe the solution you'd like
It might be too much to ask in a single GH issue, but here we go. Expected deliverables with this issue are:

update the cmsdist couchdb spec file to version 3.2.2:

CMS specific patches should be dropped
erlang version might remain the same, but we could try updating it to <IP_ADDRESS>

update the deployment repository

note that we need to fetch a new copy of the default.ini file for couchdb/wmagentpy3/tier0
note that many configuration attributes were moved from couch_httpd_auth to chttpd_auth
other configuration attributes have moved from httpd to chttpd as well.

ensure Jenkins are happy with the new CouchDB version
release a new WMAgent docker image, once CouchDB 3.2.2 is available within our software stack.

Bonus: not to forget, we should also add a couchdb/max_dbs_open=300 option to our local.ini file
Describe alternatives you've considered
We could skip it for central services in favor of a CouchDB As a Service, but it turns out WMAgents will still need this latest version, so we can make this update for everything within the WM.
Additional context
See https://github.com/dmwm/WMCore/issues/8853 for the latest developments on this topic.
See release notes at: https://docs.couchdb.org/en/stable/whatsnew/3.2.html

Here are the relevant PRs:
https://github.com/cms-sw/cmsdist/pull/8001
and
https://github.com/dmwm/deployment/pull/1169
which has been tested with a new build of WMAgent.
I ran the set of DMWM workflows, including workflow priority updates and force-completion and everything went fine. In the end, this final update is looking easier than what I expected (for once!).

CouchDB 3.2.2 has been deployed in testbed and it seems to be working fine, after a few tweaks to its configuration and a fix for running couchapps.
Relevant PRs are linked above, but I paste them here as well:
https://github.com/cms-sw/cmsdist/pull/8001
deployment:
https://github.com/dmwm/deployment/pull/1173
https://github.com/dmwm/deployment/pull/1176
I think this can now be closed out.


Pause and Continue Trainning

Everything works like a charm. The only problem i have though is that i do not know how to properly stop and continue training from a point. Tried a couple of times and i had to start from scratch.
hypergan train [folder] -s 32x32x3 -f png -b 32 --config [name] --sampler static_batch --sample_every 5 --save_samples
Do i have to make a custom config? Thanks in advance, VK
ps: No hands on experience sorry if this something i should know. And the same dataset with unsupervised learning.

It seem that it saves the model after the ~10000 samples so then it continues from there. Thanks.


Outdated documentation

Azure Dev Spaces is currently deprecated, Bridge to Kubernetes should be used instead: https://docs.microsoft.com/en-us/visualstudio/containers/bridge-to-kubernetes?view=vs-2019

The deploy-all script currently fails with unknown flag --purge and --name. This is probably because it is expecting Helm 2 instead of the now recommended Helm3.

Why using a script to deploy all these helm charts when they can be grouped in an outer helm chart that can be deployed atomically. We shouldn't point users to run scripts to deploy a set of helm charts.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 861b238d-38e3-d054-9360-414da87f9b5c
Version Independent ID: d2f38f79-a9d7-55dd-984f-2dab5f2219b8
Content: Deploying eShopOnContainers to Azure
Content Source: docs/architecture/cloud-native/deploy-eshoponcontainers-azure.md
Product: dotnet-architecture
Technology: cloud-native
GitHub Login: @nishanil
Microsoft Alias: nanil

Hi @lolodi, thank you for your feedback.

Yes, we are in process of evaluating Bridge to Kubernetes to incorporate that in the reference application eShopOnContainers. Once it's done we will update the app and the eBooks.
We have updated the reference application to use Helm 3 already. Here is the wiki page for more details.
The reason deploy-all script is used to deploy the reference application eShopOnContainers, is because to control different parameters (for e.g sslSupport, externalDns, aksName, aksRg  etc..) along with deployment in different environments in both local and AKS with different available options.

I realized I had checkout master instead of dev. If dev is the go-to branch master should be removed to avoid confusion.
I understand this is the case, but wouldn't it be better to make the script modify a value.yaml file and let helm do an atomic deployment of the whole app? This way if something goes bad, rollback becomes easier and we would show the user the proper way of doing helm deployments.

--Extra point--
4. I noticed that all the services hardcode their ports in the code, this is an antipattern in a scenario in which the user wants to run the services both locally and remotely (e.g. with Bridge To Kubernetes). The port should be defined using the ASPNETCORE_URLS env variable. This way, if it is not set when running locally it defaults to 5000 (and avoids possible conflicts on port 80) and it can be set in the Dockerfile to run on port 80 when deployed.

Hi @lolodi, thank you for your feedback.

master branch contains the previous LTS release branch where dev always contains the latest changes. Similarly, when we would update the eShopOnContainers app to .NET 5.0, all the changes will happen in the dev branch and the previous changes would be merged to master for future reference.
I see, we could explore that too. Would you like to submit a PR to eShopOnContainers repo ?
Each service-related configuration has been kept in the docker-compose file, which primary overrides the value in appsettings.json for each service. These configurations are also passed into the docker container as environment variables for each service to use in it's code. For e.g : if you notice the webmvc related configuration in the docker-compose.override.yml file,  you would see required service-specific configuration are passed as environment variables which further overrides the value in appsettings.json setting and used in the code like class BasketService : IBasketService

We are also in process of exploring tye with eShopOnContainers, for more details you can refer issue #1387

Given the effort to get rid of "master" branches, I believe this would be a good opportunity to rename master into "stable", "legacy" or "LTS". This way the semantic is clearer and we don't confuse users.

Not sure I have enough cycles to take care of this. I'll let you know if things changes, but it's something that should be done.

For this one my point was more about the fact that in code the default port is set to 80 e.g.: https://github.com/dotnet-architecture/eShopOnContainers/blob/9dec3b16e826d91e64f2c33a4c5ae043bf0e9a98/src/Services/Basket/Basket.API/Program.cs#L111
in the [appsettings.json](https://github.com/dotnet-architecture/eShopOnContainers/blob/dev/src/Services/Basket/Basket.API/appsettings.json ) there is no port info and therefore the execution falls back on port 80, value set in the code.
I agree that, when the service is deployed containerized, the ports should be set in the Dockerfile, but we should have a port different from 80 when running them locally uncontainerized and we should not set that port in code, but using the proper ASPNET ways as described above.
Having a non standard port (!=5000) defined in the code brakes the tooling that looks for the ASPNETCORE_URLS env variable to figure out what port the service is going to use when running locally.


Py AE Fish Turbine Cannot Undo

Mod source
Factorio Mod Portal
Operating system

=Windows 10

What kind of issue is this?

[ ] Compatibility
[ ] Locale (names, descriptions, unknown keys)
[ ] Graphical
[ ] Crash
[ ] Progression
[ ] Balance
[ ] Pypostprocessing failure
[X] Other

What is the problem?
When building a 'multiblade "fish" turbine' via hand or bots and undoing the action, the building stays put.
Steps to reproduce

Build 'multiblade "fish" turbine'
Place the 'multiblade "fish" turbine' on a valid spot on the map
Press Undo or "Ctrl + z"

Additional context
Expected result: The 'multiblade "fish" turbine' is marked for deconstruction and eventually removed.
Actual result: The 'multiblade "fish" turbine' stays put.
Log file
No response

might be the case with airspace entity. after mod update there's no way removing that entity,

fixed sometime between then and now


extend transform_to or define a new transform algo

It seems that transform_to cannot take a constant input range, a non constant one and transform the second in place using the first.
Tell me if I am wrong.
I wanted to write a += operator for a polynomial class, and I want to do it without duplicating the this datas.
Here is an example of what I meant, what works and what I wish, on a simplified "pipo" class
The pipo_dont_work just doesnot work because of the const & in +=
The pipo_wished does not work because it does not exist yet
The pipo_eve works but duplicates a vector
The pipo_std works but is perhaps not vectorized as using std::transform
#include <eve/module/core.hpp>
#include <eve/algo/transform.hpp>
#include <eve/wide.hpp>
#include <iostream>
#include <vector>

// struct pipo_dont_work{
//   pipo_dont_work(std::vector<float> const & v) :data(v){};

// this do not work because v is const & so the zip cannot be modified
// however it is not good to duplicate v.data to make it work as in the next example
//   auto operator+= (pipo_dont_work const & v){
//     auto addit = [](auto p) {
//       get<0>(p) += get<1>(p);
//       return p;
//     };
//     eve::algo::transform_inplace(eve::algo::views::zip(data, v.data), addit);
//     return *this;
//   }

//   std::vector<float> data;
// };

struct pipo_eve{
  pipo_eve(std::vector<float> const & v) :data(v){};
  auto operator+= (pipo_eve const & v){
    std::vector<float> mv(v.data); //I don't want to duplicate data like that
    auto addit = [](auto p) {
      get<0>(p) += get<1>(p);
      return p;
    };
    eve::algo::transform_inplace(eve::algo::views::zip(data, mv), addit); //cant put v.data instead of mv because constantness of v
    return *this;
  }
  std::vector<float> data;
};

struct pipo_std{
  pipo_std(std::vector<float> const & v) :data(v){};
  auto operator+= (pipo_std const & v) {
    //no  duplicate data here
    auto addit = [](auto a, auto b) {
      return a += b;
    };
    // std::transform syntax  allows to have in place modifications
    std::transform(data.begin(), data.end(), v.data.begin(), data.begin(), addit);
    return *this;
  }
  std::vector<float> data;
};

// struct pipo_wished{
//   pipo_wished(std::vector<float> const & v) :data(v){};
//   auto operator+= (pipo_wished const & v) {
//     //no  duplicate data here
//     auto addit = [](auto a, auto b) {
//       return a += b;
//     };
//     // std allows to have in place modifications, I think we need something like that
//     std::transform(data, v.data, data, addit); // const &,  const &,  & (input input output)
//     return *this;
//   }
//   std::vector<float> data;
// };

int main()
{
  std::vector<float> vv {1,  2, -3, 0, 4};
  std::vector<float> ww {5,  21, -2, 0, 4};
  {
    pipo_eve v(vv);
    pipo_eve w(ww);
    v +=  w;
    for(size_t i=0; i < v.data.size(); ++i)    std::cout << v.data[i] << std::endl;
    return 0;
  }
  {
    pipo_std v(vv);
    pipo_std w(ww);
    v +=  w;
    for(size_t i=0; i < v.data.size(); ++i)   std::cout << v.data[i] << std::endl;
    return 0;
  }
}

Did I missed something ?

Sorry, I am confused with this example
Here is an example with const working: https://godbolt.org/z/Mbaz437Yj
Can you modify it to get a small example of what you want that does not work?

    eve::algo::transform_inplace(eve::algo::views::zip(data, mv), addit); //cant put v.data instead of mv because constantness of v

Yes. transform inplace writes the whole thing. That's the idea.

Ah, hmm, hmm.
Do you want to read A and read modify B?

Here is a comparison: https://godbolt.org/z/Kcjxx975h
At the bottom - how'd I write it by hand
At the top - how you can do it now with transform.
There is a difference. I don't know what it is but there shouldn't be.
Some sort of transform_with maybe?
Does something like this make sense for inclusive scan? - probably not.
zip_extra view? That gives you more stuff on read but strips things on write?
Ideas welcome.

the example is clear : I have a class containing a vector as member and I wand to write an operator +=.
Here is a still more simple case, can you write a transform_to or transform_inplace cersion ?
The output is
5
3
0
///////////////////////////////////////////////////////////////////////////////////////////////////////////
#include
#include
struct pipo{
pipo(std::array < float, 3> const & v) :data(v){};
auto operator+= (pipo const & v) {
// please write with transform or transform_to the equivalent to the manual loop
// without duplicating v
for(int i=0; i < 3; ++i) { data[i] += v.data[i];  }
return *this;
}
std::array<float, 3> data;
};
int main()
{
std::array<float,3>  v{1.0f,2.0f,3.0f};
std::array<float,3>  w{4.0f,1.0f,-3.0f};
pipo pv(v),pw(w);
pv+=pw;
for(size_t i=0;i<3;++i)
std::cout<< pv.data[i] <<std::endl;
return 0;
};
//////////////////////////////////////////////////////////////////////////////////////////////////////

ok I had not seen your answers I try asap

thank you very much, it works.
My mistake seems to have though that the lambda had to return the same type as its entry.

thanks again my things seem to work fine : I learned something.

I still think there probably should be something better

Isn't it because zip loses the non-const qualifier?
C++23 zip range had a similar issue and they fixed it by doing the wrong thing: making tuple const assignable
maybe we should look at making zip more non-const friendly?

No, it's not. It's because transform inplace writes the whole value


Version conditional: make_valid

Following up on #116
MakeValid is available since GEOS 3.8.0

Thanks for the review, I updated the PR.


schedulers: add sanity check for random-merge

What problem does this PR solve?
Fix https://github.com/pingcap/pd/issues/2210
What is changed and how it works?

port merge checks from mergeChecker to random-merge-scheduler
minor refactor: remove mergeChecker.ruleManager and get it from cluster

Check List
Tests

Unit test

Related changes

Need to cherry-pick to the release branch

/merge

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@251e1e9). Click here to learn what that means.
The diff coverage is 82.14%.

@@            Coverage Diff            @@
##             master    #2212   +/-   ##
=========================================
  Coverage          ?   75.98%
=========================================
  Files             ?      196
  Lines             ?    21132
  Branches          ?        0
=========================================
  Hits              ?    16057
  Misses            ?     3893
  Partials          ?     1182

Impacted Files
Coverage Δ

server/schedule/checker_controller.go
76.66% <100%> (ø)

pkg/mock/mockcluster/mockcluster.go
90.9% <100%> (ø)

server/schedulers/random_merge.go
64.17% <63.63%> (ø)

server/schedule/checker/merge_checker.go
71.76% <92.85%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 251e1e9...52b5fac. Read the comment docs.


Ask to update the task parameters when moving it from one project/board to another

When moving or duplicating a task from one board to another, it might make sense to prompt the user to specify the new:

Category
Column
Swimlane (bug #972)

It's now available in master, see http://kanboard.net/documentation/duplicate-move-tasks
Let me know if you found any bugs.

Seems to work, woohoo!
A small UX suggestion I can offer, but not a big deal and it's up to you: it might be nice to have a "reminder" of what the previous values were besides each field. For example, you could have
Category
[ combobox ]   (previously: foobar)

With the "previously" text in gray so it doesn't stand out too much. Or maybe do that as a tooltip on the combobox itself (so it only appears when the mouse goes over it, instead of being shown directly on the page). Otherwise you need to have multiple tabs open to know what were the previous parameters if you want to match them.

In addition to this UX nitpick above, found a possible perf bug: #1041

I added the previous/current value.


FPS drops right after injection

Hello,
after I inject Osiris my fps ingame drop under 60 instantly. I used Osiris several times and had no issue, but now that happens.
I already looked trough some issues here, unfortunately nothing helped. If any of you know a fix, I would appreciate it a lot if you could drop 'em in this issue thread.
Edit: After I unhook it I have my 240+ fps again

Been having the same. I get around 300 fps before, but after injecting I get 120.

Clone the latest version of Osiris and enable AVX2 technology if your processor supports it.

Clone the latest version of Osiris and enable AVX2 technology if your processor supports it.

Doesn't work


Reenable disabled tests post VSCode refresh

I'm going to use this PR to reenabled tests post VSCode merge.  I may reach out to individual area owners to help investigate test failures in their areas.

This is related to this issue https://github.com/microsoft/azuredatastudio/issues/20885.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
321 unchanged lines in 6 files lost coverage.
Overall coverage increased (+4.5%) to 41.957%

Files with Coverage Reduction
New Missed Lines
%

src/sql/platform/connection/common/connectionConfig.ts
7
92.67%

src/sql/workbench/services/connection/browser/connectionDialogService.ts
28
76.67%

src/sql/workbench/services/objectExplorer/browser/serverTreeActionProvider.ts
28
5.3%

src/sql/base/browser/ui/table/treeGrid.ts
47
0.64%

src/sql/workbench/contrib/executionPlan/browser/azdataGraphView.ts
102
7.59%

src/sql/workbench/services/connection/browser/connectionManagementService.ts
109
71.0%

Totals

Change from base Build<PHONE_NUMBER>:
4.5%

Covered Lines:
28856

Relevant Lines:
63878

💛  - Coveralls

I'll turn back on the extension unit tests with this PR and handle the smoke/integration tests in another PR.


Remove clx & Fix cuml

This PR includes the following changes:

removes the clx submodule
fixes the cuml SHA, which was messed up from our recent force push

xref: https://github.com/rapidsai/docker/pull/535


Deprecating NoSuchGatewayClass status reason

What type of PR is this?
/kind cleanup
/kind deprecation
What this PR does / why we need it:
This deprecates the NoSuchGatewayClass status reason. Although this was a useful concept, it was never clear who would actually set it. Although we could develop an official controller that watched Gateways and GatewayClasses and set this status, I don't think anyone has the capacity to maintain that. Alternatively, we could rely on every Gateway controller to write this status, but that could result in some fairly ugly race conditions.
I initially proposed a new condition to replace this, but I don't think that's necessary. After discussing this with @jpeach, it seemed like the existing ListenerConditionResolvedRefs and NotReconciled conditions were sufficient here.
Does this PR introduce a user-facing change?:
The NoSuchGatewayClass status reason has been deprecated.

/cc @jpeach @hbagdi

+1 to this PR. I didn't add an lgtm so that another reviewer can review before we merge.

After discussing this with @jpeach, it seemed like the existing ListenerConditionResolvedRefs and NotReconciled conditions were sufficient here.

NoSuchGatewayClass was useful when you wanted to report status for the entire Gateway and not a specific listener. I think there is value in having a condition that is representative of status of the entire Gateway rather than all listeners reporting as "NotReconciled".

Yeah, I agree that it's very useful to have simple, easy-to-understand Conditions for critical errors (of which NoSuchGatewayClass) is one. Having that Condition means that, if you typo the GatewayClass, then you can clearly see why all the listeners are "NotReconciled".
/lgtm though.

/lgtm

@robscott I'm interpreting the comments from @hbagdi and @youngnick as being supportive of not deprecating this?

I'm okay with deprecating this Reason, I think there should be a separate, negative-polarity "NoGatewayClass" Condition.

I'm okay with deprecating this Reason, I think there should be a separate, negative-polarity "NoGatewayClass" Condition.

I think the fundamental issue that @robscott is trying to address is what actor could ever set that condition?

🤦 Yes, of course, that doesn't make any sense, thanks.
For Contour, since a Contour deployment must be 1:1 with a Gateway, we've experimented with setting a named Gateway directly rather than a GatewayClass (since that gets around having to handle the various dynamic discovery error cases like two matching Gateways, Gateway priority etc. But I think we're moving away from that idea now.)


Improve performance of discovering tests

It's still pretty slow, but this is definitely better. Rather than using the TestMessageVisitor, we implement our own message sink. The visitor dispatches in a pretty inefficient way.

Oops.. Cyrus submitted something very similar.


URLs should be clickable

All URLs should be links. Or be given a named link. E.g. pkgs.org on Linux installation instructions

@tapaswenipathak I think we should use this:
https://myst-parser.readthedocs.io/en/latest/syntax/optional.html#linkify
And probably some other markdown extensions

I don't understand - what is the advantage of using linkify?

I think just that you don't need to do url

@greengypsy can we close this?


typescript: add json and protobuf encoding support to validate script

validate script now supports protobuf and json encodings (similar to ws-protocol).

👍
We still need to actually document what encoding means for mcap - right now this validates against a spec that doesn't exist :D


Bring the profile's window upfront, without creating a tab

Extension
https://www.raycast.com/frouo/google-chrome-profiles
Description
It would be useful to switch between profiles, using quicklinks, without creating a new tab.
Who will benefit from this feature?
No response
Anything else?
No response

I was about to write an extension of my own for this purpose, found your extension, was happy that I won't need to do this but looks like I have to select a url/empty tab/bookmark every time and it's a bit tedious. I'll look for what else can be done and update my findings in this thread.

@onurcagan Thank you, I hope you will find a way and could contribute to this extension.
Creating a new window every time you switch profile back and forth is a no go for me.


Make sure frontend code doesn't need to depend on anchor

Is your feature request related to a problem? Please describe.
When building the frontend of a BOLT application the users ends up having to have the whole of anchor as a direct dependency to parse the IDLs of the components/systems
Describe the solution you'd like
Ideally we would provide a way to automatically serialize/deserialize data without having the user need to import direct anchor APIs

Hi @GabrielePicco, @crypto-vincent.
Rather than creating the custom serialize/deserialize, I would suggest to re-export the @coral-xyz/anchor from our @magicblock-labs/bolt-sdk because, their we have already installed it.
In that way we does not need frontend to again add  @coral-xyz/anchor, just add @magicblock-labs/bolt-sdk and consume all API's.
Example
Re-export example

// Import necessary modules from @coral-xyz/anchor
import * as anchor from "@coral-xyz/anchor";
export { anchor };

// Optionally, export specific components from @coral-xyz/anchor if needed
export {
  Provider,
  Program,
  Wallet,
  web3,
  workspace,
  BN, // If you want to re-export BN from anchor
} from "@coral-xyz/anchor";

Consuming through our SDK

import { anchor } from "@magicblock-labs/bolt-sdk";

// Use anchor's APIs
const provider = new anchor.Provider(...);
const program = new anchor.Program(...);

Let me know if you like the solution, I can make this changes


"Network is unreachable" bug with Jellyfin integration

I have setup a meshnet and pointed my jellyfin container to use it, see config below. The problem I have is that when I go to my browser to load my-nord-vpn-dns.nord on port 8096, nothing loads. The meshnet logs show that it is up and running fine, however the Jellyfin logs are giving back this SocketException. Any idea if I am missing something?
[14:00:22] [ERR] [30] Emby.Dlna.Main.DlnaEntryPoint: Error sending socket message from ************* to *************
System.Net.Sockets.SocketException (101): Network is unreachable

meshnet:
    image: ghcr.io/mattstechinfo/meshnet:latest
    restart: unless-stopped
    cap_add:
      - NET_ADMIN
      - NET_RAW
    environment:
      - PUID=1000
      - PGID=1000
      - NORDVPN_TOKEN=*************
      - NORDVPN_ALLOW_PEER_ROUTING=*************
      - NORDVPN_ALLOW_PEER_LOCAL=*************
    hostname: meshnet   # Make sure hostname is set! Without it, every restart will add a new peer to your Meshnet.
    ports:
      - 8096:8096
      - 7359:7359/udp

jellyfin:
    image: lscr.io/linuxserver/jellyfin
    container_name: jellyfin
    environment:
      - PUID=1000
      - PGID=1000
    volumes:
      - ~/docker-services/jellyfin/config:/config
    restart: 'unless-stopped'
    network_mode: service:meshnet

I changed the jellyfin image to ghcr.io/linuxserver/jellyfin and it worked!


Replace Maven with Gradle

Please take a look at the comment, I'll merge now since it is not incorrect but we should revisit.

@mgodave did you want to merge this or should I?

Sorry. I thought I did. You can do it.
On Wed, May 6, 2015, 14:12 Tobias Bieniek<EMAIL_ADDRESS>wrote:

@mgodave https://github.com/mgodave did you want to merge this or
should I?
—
Reply to this email directly or view it on GitHub
https://github.com/mgodave/esl-client/pull/5#issuecomment-99591673.


rename fetch_driver_msgs to fetch_msgs

I'm about to add additional packages to this repo

I think this is actually correct -- but the test complains because renaming the repo also requires it be moved, and the diff can't handle that.

@dirk-thomas thanks for catching that, I had looked at the travis log but missed that, just rebased this into a single commit, should make it through testing momentarily


Crash on linux with wayland and external monitor

Ebitengine Version
6eb0271f83cb94340d5789344a1bfa22b06e8c54
Operating System

[ ] Windows
[ ] macOS
[X] Linux
[ ] FreeBSD
[ ] OpenBSD
[ ] Android
[ ] iOS
[ ] Nintendo Switch
[ ] PlayStation 5
[ ] Xbox
[ ] Web Browsers

Go Version (go version)
go version go1.23.1 linux/amd64
What steps will reproduce the problem?

run any example
turn off monitor
turn monitor back on

What is the expected result?
everything should be as it was before turning monitor off
What happens instead?
X Error of failed request:  BadRRCrtc (invalid Crtc parameter)
  Major opcode of failed request:  140 (RANDR)
  Minor opcode of failed request:  20 (RRGetCrtcInfo)
  Crtc id in failed request: 0x56e
  Serial number of failed request:  1855
  Current serial number in output stream:  1855
exit status 1

Anything else you feel useful to add?
I use gnome-shell on Wayland, this is why I suppose that ebiten uses xwaylandbridge. Why does it need xorg?

ref: https://github.com/glfw/glfw/issues/1147

I think ebiten uses glfw on linux.
I have glfw v3.3 header in /usr/include/GLFW (idk what header ebiten uses)

first v3.3 was released in 2019 and the above issue was fixed in 2017, so I think this is a iplementation bug somewhere here (?)

Ebitengine dropped Wayland support from GLFW.

Ebitengine dropped Wayland support from GLFW.

So what deos it use for linux-wayland now? maybe I can share some more info?

IIUC an X emulation layer works.

interessting, on examples/fullscreen it panics with
[fullscreen (0) ]$ go run .
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x48 pc=0x6d0c86]

goroutine 1 [running, locked to thread]:
github.com/hajimehoshi/ebiten/v2/internal/ui.(*Monitor).DeviceScaleFactor(...)
	/home/me/git/ebiten/internal/ui/monitor_glfw.go:45
github.com/hajimehoshi/ebiten/v2/internal/ui.(*UserInterface).registerWindowFramebufferSizeCallback.func1(0xc00017a608?, 0x280, 0x205)
	/home/me/git/ebiten/internal/ui/ui_glfw.go:968 +0x86
github.com/hajimehoshi/ebiten/v2/internal/glfw.goFramebufferSizeCB(0xc0000061c0?, 0x280, 0x205)
	/home/me/git/ebiten/internal/glfw/window_unix.go:147 +0x45
github.com/hajimehoshi/ebiten/v2/internal/glfw._Cfunc_glfwPollEvents()
	_cgo_gotypes.go:1004 +0x3f
github.com/hajimehoshi/ebiten/v2/internal/glfw.PollEvents()
	/home/me/git/ebiten/internal/glfw/window_unix.go:952 +0xf
github.com/hajimehoshi/ebiten/v2/internal/ui.(*UserInterface).update(0xc00017a608)
	/home/me/git/ebiten/internal/ui/ui_glfw.go:1377 +0x127
github.com/hajimehoshi/ebiten/v2/internal/ui.(*UserInterface).updateGame.func1()
	/home/me/git/ebiten/internal/ui/ui_glfw.go:1471 +0x45
github.com/hajimehoshi/ebiten/v2/internal/thread.(*OSThread).Loop.func1({0xc0001cc300?, 0x80?}, 0x20?)
	/home/me/git/ebiten/internal/thread/thread.go:67 +0x4f
github.com/hajimehoshi/ebiten/v2/internal/thread.(*OSThread).Loop(0xc00021ab00, {0x9632f8, 0xc0009cac30})
	/home/me/git/ebiten/internal/thread/thread.go:68 +0x79
github.com/hajimehoshi/ebiten/v2/internal/ui.(*UserInterface).runMultiThread(0xc00017a608, {0x9654e0, 0xc0000d2380}, 0xc000384dc0)
	/home/me/git/ebiten/internal/ui/run.go:75 +0x322
github.com/hajimehoshi/ebiten/v2/internal/ui.(*UserInterface).Run(0x961518?, {0x9654e0?, 0xc0000d2380?}, 0x3?)
	/home/me/git/ebiten/internal/ui/run.go:33 +0x30
github.com/hajimehoshi/ebiten/v2.RunGameWithOptions({0x961518, 0xc0009b71f8}, 0x0)
	/home/me/git/ebiten/run.go:345 +0x208
github.com/hajimehoshi/ebiten/v2.RunGame(...)
	/home/me/git/ebiten/run.go:236
main.main()
	/home/me/git/ebiten/examples/fullscreen/main.go:117 +0x56
exit status 2

so it uses glfw on wayland.


Feat/user keybinds config externalized

Hi @ajayd-san,
I have shifted keybindings to the config file which can help in the issue #38, I have no idea how BubbleTea works. I can work on the keybindings page but I need some knowledge on BubbleTea(which I am currently working on)
I have tested the code and wrote one test case config in the config.test.go file.
Please let me know what you think about the PR

Hey,
Thanks for the pr!
I'm over-encumbered with schoolwork right now, but I'll have a look at this when I find time.
Thanks

Take your time @ajayd-san, I am just excited to contribute for this.


remove unused imports

Update user guide

Rearrange commands in a more logical order.

Add: add i/ISSUE_STATEMENT s/SOLUTION_LINK1 s/SOLUTION_LINK2 [r/REMARK] [t/TAG]…
Edit : edit INDEX [i/ISSUE_STATEMENT] [s/SOLUTION_LINK1] [s/SOLUTION_LINK2]
Refactor Tag: refactor [OLDTAG] [NEWTAG]
List : list
Search : search KEYWORD [MORE_KEYWORDS]
Select : select INDEX
Delete : delete INDEX
Clear : clear
Undo : undo
Redo : redo
History : history
Highlight : highlight
Exit : exit
Help : help

Add incoming version number behind feature if haven't completed yet.

Display incomplete features after complete features


Add GraphicsMatcher for embedded images

We already use something similar in the appendix-specific code. Also adds
EXTRACT and GPOTABLE matchers for preambles, and explicitly ignores FTNT and
PRTPAGE tags
Should resolve eregs/notice-and-comment#16

Coverage increased (+0.01%) to 91.215% when pulling 24775f4bd6ec56a7d254c6dda8fba1522d2c07a6 on cmc333333:16-better-matchers into b5d5df04447b5105a1dd74a474b8d977ba259af4 on 18F:master.


[BUG] qasm3_to_qir: "Variable c3 is not an array", despite c3 being an array.

Environment

qBraid-QIR version: 0.2.3
Python version: 3.11.5
Operating system: Linux c5ce507e9ef3 <IP_ADDRESS>-microsoft-standard-WSL2

What happened?
The following Qiskit circuit is converted to qasm3 using qiskit.qasm3.
qubits = QuantumRegister(1)
clbits = ClassicalRegister(1)
circuit = QuantumCircuit(qubits, clbits)
(q0,) = qubits
(c0,) = clbits

circuit.h(q0)
circuit.measure(q0, c0)
with circuit.switch(c0) as case:
    with case(0):
        circuit.x(q0)
    with case(1):
        circuit.z(q0)
circuit.measure(q0, c0)

This yields the following QASM3:
OPENQASM 3.0;
include "stdgates.inc";
bit[1] c3;
int switch_dummy;
qubit[1] q3;
h q3[0];
c3[0] = measure q3[0];
switch_dummy = c3[0];
switch (switch_dummy) {
  case 0 {
    x q3[0];
  }
  case 1 {
    z q3[0];
  }
}
c3[0] = measure q3[0];

I get the following error message: qbraid_qir.qasm3.exceptions.Qasm3ConversionError: Indexing error. Variable c3 is not an array and Error at line 8, column 18 in QASM file.
I.e. the indexing c3[0] seems to fail.
Suggestions (Optional)
No response

Hi @Sola85 , thanks for raising an issue!
Since, internally, we are handling c3[0] = measure q3[0]; as classical assignment statements we see this kind of error message.c3 is technically not an array (because it is a bit type scalar variable with 1 bit length), the classical assignment handler raises an error. Whenever we have indexing on the lhs, our semantic analyser expects that the variable is of type array.
Also, we are not correctly handling the syntax c3[0] = measure q3[0]; in our pyqasm.unroll function. It makes sense to convert this statement to a QuantumMeasurementStatement instead of a ClassicalAssignment before appending to the unrollet AST.

@TheGupta2012 Based on your evaluation, would it make sense to transfer this issue to the pyqasm repo?


[Docbug][Removedparenthesis][1837836]

Removed parenthesis.

Docs Build status updates of commit f1565bb:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/get-started/first-app-blazor.md
:white_check_mark:Succeeded
View

msteams-platform/get-started/first-app-bot.md
:white_check_mark:Succeeded
View

msteams-platform/get-started/first-app-react.md
:white_check_mark:Succeeded
View

msteams-platform/get-started/first-message-extension.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 3b352bc:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/get-started/first-app-blazor.md
:white_check_mark:Succeeded
View

msteams-platform/get-started/first-app-bot.md
:white_check_mark:Succeeded
View

msteams-platform/get-started/first-app-react.md
:white_check_mark:Succeeded
View

msteams-platform/get-started/first-message-extension.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 400c790:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error-PullRequestMergeConflict] Cannot sync git repo to specified state. Please make sure the pull request is mergeable.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit e795958:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/get-started/first-app-blazor.md
:white_check_mark:Succeeded
View

msteams-platform/get-started/first-app-react.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Deprecate forAll with Gens

@rickynils @dwijnand
Sorry if this gets confusing pretty quickly. This is one option for the first change to ScalaCheck to deprecate the forAll Gen functions, but leave the behaviour. Is it what you had in mind?
EDIT: This is based on the original disabling of Shrinking on #440

Thanks @ashawley, sorry some of that was a little sloppy.

@ashawley do you have merge and release permissions? I'm wondering if I should weigh in on the changes you're suggesting or not.

I don't, but hopefully you'd weigh in regardless.

I don't support deprecating shrinking with an explicit generator.  I'd rather see it fixed, but in the absence of a fix, @charleso has made a valid argument that it should be disabled by default.  My concern of not providing an opt-in for shrinking via forAllShrink has been taken in to consideration here.  There's no reason not to move forward with deprecation.
Thanks for doing this!

Concerning Rickard's original question in #440:

The question is now if we should release a version with unchanged behavior and deprecated methods before actually making this change.

This deprecation warning forforAll is likely going to be pretty disruptive for users of ScalaCheck 1.x:

New users are going to write their first property test using forAll with a generator and be confused by the warning.
Users could follow the advice of the deprecation message, "use forAllShrink instead", but that is misleading.  The consensus is to not use shrinking, since the default for forAll will become equivalent to forAllNoShrink.  The suggestion of forAllShrink is intended for migrating tests of existing users.
Alternatively, users could avoid the warning by using forAlllNoShrink, but that's unfortunate because in the next ScalaCheck release (1.16.x, 2.0?) the semantics for forAll will become the same as forAllNoShrink.
Projects with fatal warnings enabled, will need to research how to modify their sbt build and disable fatal warnings in their test suites.
All instances where forAll uses an explicit generator in the documentation could be updated to use forAllNoShrink, however, like (2) that's a moving target, since the plan is to make forAll have shrinking disabled.

We could try to either massage the deprecation message or jam in more information.  Any suggestions to the wording are welcome, but it has diminishing returns.
I'd wager there needs to be a comprehensive release notes about this.
The release that subsequently removes shrinking should follow closely behind the release that does deprecation.  That would avoid confusing new users from the deprecation warning.

Hi @ashawley
Thanks for taking the time to review this PR. My sincere apologies for doing this but I'm going to close the PR. It was originally as a Proof Of Concept and to help communicate one of the options for "fixing" (for some definition) for `forAll (as part of #440 ).
I wont deny it, ScalaCheck is in a tough spot. There is an extremely commonly used function that is behaving in an (arguably) unexpected fashion. By changing the semantics are we breaking compatibility?
Honestly I don't think the there is a Right Answer. I just know that personally I'm going to feel extremely responsible if we merge this PR and, as you 100% correctly point out, "New users are going to write their first property test using forAll with a generator and be confused by the warning.".
I'm more than happy if @rickynils, yourself, or another maintainer want to re-open and merge this PR, but I don't want to be seen as the person who was responsible for 1000 deprecation warnings for (in my opinion) a behaviour they didn't realise they were getting.
I still think that #440 is the right approach in this situation. Let's just change the behaviour. The worst that can happen is that users get slightly more unhelpful failure cases, but that are true positives. The alternatives are:

They get false positives in the form of confusing errors by leaving broken shrinking
They have to refactor all their code to remove deprecation warnings for code that should otherwise by just fine.

I'm really not trying to push you to merge/support #440, I suspect you won't and I'm not trying to have that argument again. I'm just not comfortable with #444 (this PR) and don't want to have my name associated with potentially pissing off lots of people "fixing" something.
Thanks again though, I really mean that, and sorry for dragging out a PR I wasn't really comfortable with in the first place.

Ok, we can resurrect the branch if we need to.   I actually agree that there probably isn't much advantage to this approach of deprecating.  It's probably better to just migrate over in #444.  We still have a lot of the same issues with #444, but it will be less confusing than pushing a release with deprecation warnings.

I'm wondering what y'all would think about making shrink/noshrink a boolean parameter. Is there an easy way to turn shrinking on and off? Like if I have a test suite and I want to turn shrinking on and off for the whole suite. For instance, perhaps I'm still working on the instance of Shrink for my type and want to turn it on or off in a simple way.
I'm convincing myself this isn't a good idea, since forAllShrink would take a Shrink parameter, whereas forAllNoShrink would not. And so the method with the boolean parameter would still require you to have an instance of Shrink. So what I'm thinking of is maybe best if any shrink switch is turned on by default.


Spacing before ? and : etc. is not respected no more with 7.12

topic: ~debut repeat []

t: ^keep()
  Est-ce une question ?
  Une affirmation : bla bla.

7.111 output:
Est-ce une question ? Une affirmation : bla bla.
(which is ok and compliant with the French rules)
7.12 output:
Est-ce une question? Une affirmation: bla bla.
(which is not good)

Is there a chance to have this point taken for the next release? We are stuck on 7.111 because of this single point.

has already been handled for next release, if your command line parameter is language=french

Just tested on 7.2, with the same code. The issue is still here.

I don't really understand:
            else if (stricmp(language, "french") &&  (c == ':' || c == ';' || c == '!' || c == '?')) {; }

the code should have been !stricmp
On Mon, Feb 13, 2017 at 3:58 AM, Ludan Stoecklé<EMAIL_ADDRESS>wrote:

I don't really understand:
        else if (stricmp(language, "french") &&  (c == ':' || c == ';' || c == '!' || c == '?')) {; }

—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/bwilcox-1234/ChatScript/issues/53#issuecomment-279367809,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABJzVFu-A1mlT8iWzVbb34bRCNd39ODIks5rcEWCgaJpZM4LwvBx
.

--
CEO of Brillig Understanding Inc.  (Natural Language applications)
brilligunderstanding.com
805-547-1109

Sure. But I also think that the condition should be on "*word" and not on "c".
I have tested the following code:
else if (!stricmp(language, "french") &&  (*word == ':' || *word == ';' || *word == '!' || *word == '?')) {;}

seems to work in both english and french on a very basic bot.
What's your opinion?
Do you want me to create a pull request or something like that?

You are correct. I have modified my code to do that for next release. You dont need to do a pull request.


erc721-with-balance

gm!
It doesn't seem like there is a strategy available for ERC721s without the token balance weighting (1 holder, 1 vote). I followed the lead on erc20-with-balance to create this one.
Cheers!
Changes proposed in this pull request:

Add the erc721-with-balance strategy

Hey @zhoug0 Thanks for the PR, we are aware of this, we are trying to find ways to rename existing strategies, till then erc20-with-balance should work for erc721 too 😄

Hey @zhoug0 Thanks for the PR, we are aware of this, we are trying to find ways to rename existing strategies, till then erc20-with-balance should work for erc721 too 😄

Sounds good, thanks @ChaituVR !


Dreamscreen integration - Installation Steps for Noob to Home-Assistant

Hello Gregory,
I fell on your projects after I learned today that Dreamscreen closed down their online store and who knows how long the IOS app will be supported and working.
I am looking for a way to control the device through other means and this project appears like it would do a lot of what the IOS app would do and it also looks like you have other projects that works with the dreamscreen.
I am brand new to the home assistant platform and have a pi 3 running Hass.io
Could you share the proper steps to install your Dreamscreen custom component?

Even if its a bit late, the Readme should provide enough informations.
Add the Repo as a submodule or clone it to custom_components/dreamscreen
Restart HA with configuration.yaml adjustments
Now there should be your dream screen at hassio.local/dev-state. You can Change modes and sources at hassio.local/dev-service

Closing due to inactivity.
Readme should contain enough informations now.


Speed up OAI harvesting

set the last harvested time to retrieve only updates from the OAI provider
optional -recent to specify the number of days to look back for updates

#236 is fixed

#234 is fixed


Add mkdocs-material docs gen and include CI docs (review)

Hi @shukra-in-spirit @vancanhuit , I've raised this PR for review on:

Documentation structure
Quickstart content
CI pages structure
CI content for gitleaks, pre-commit, mkdocs-material and golangci-lint

The documentation on publish will look similar to:
https://haani-niyaz.github.io/golang-template-repository/
Closes #21 and #28.
Required actions:

[ ] Proof read content
[ ] Enable gh-pages in template repo settings as mentioned in #21
[ ] Add Sonarqube CI docs
[ ] Reconcile with #23

@AlvinKuruvilla, there was an urgency to finish this piece of work so I've stepped in. Happy to discuss with you if required.

since this is related to docs.
shall we use https://opencollective.com/vale to do a copy check?
https://github.com/errata-ai/vale-action - seems helpful in GitHub actions context

since this is related to docs. shall we use https://opencollective.com/vale to do a copy check? https://github.com/errata-ai/vale-action - seems helpful in GitHub actions context

This definitely looks interesting. We should have a story to explore it :)
For the purpose of this MR though, a more technical documentation review is required to validate if the information is helpful for repo owners to get started.

@shukra-in-spirit  thanks for merging this. Just checking if gh-pages was setup in the repo as per:
https://github.com/rog-golang-buddies/golang-template-repository/issues/21#issuecomment-1171874696
The site is URL is retuning a 404 atm.

Hey, I updated it.


Microsoft PowerToys: Windows 10 - Feature Suggestions

[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 06e00ed6-a50f-1bf1-af7b-81879cb0338e
Version Independent ID: 7209e902-f8ec-2f25-a0e5-d557e6e18687
Content: Microsoft PowerToys
Content Source: hub/powertoys/index.md
Product: dev-environment
Technology: powertoys
GitHub Login: @mattwojo
Microsoft Alias: mattwoj

While this page has a section "Contribute to Power Toys" it focuses on how to write a contribution with, unless I am missing something, no actual way to submit a suggestion.
So here I am.
Windows 10 has no ability to configure a camera's settings so that these settings then default into video applications, specifically MS Teams (Which states they do not manage the camera, only use the windows camera), but also Zoom and Skype.  I am not suggesting anything radical, just basic crop, zoom and rotate functionality for conferencing.  There are plenty of $30+ solutions with color, blur, backgrounds, titles, etc.  I am advocating for very simple features to frame a better picture.
Use Case 1:  HD webcams do not enhance a typical video conference, indeed they add more superfluous background content to the left and right sides.
Solution 1 - Crop the sides
Solution 2 - Rotate and zoom for portrait
Use Case 2: Internal Webcams (laptops and all in ones) are not always optimally pointed at the user, and may be considered fixed due to the devices screen angle.  It may not be able to optimally feature the user (ie off center).  The ability to crop would offer some improvement to the users picture.
This could be implemented as either an override to standard sttings or as a virtual cam.  I think an override would be best, eliminating the need for a user to select the virtual camera in a given application, and thus making it "just work".

Hi @Ranger-Z -- Love this feature suggestions for PowerToys. This isn't quite the right place for it though as this repo is specific focused on feedback related to documentaiton updates or improvements. Please file your suggestion in the PowerToys product repo where the developers who build these features will see it, here's the link: https://github.com/microsoft/PowerToys/issues/new/choose

I did a quick search in the existing issues and didn't find that anyone has already requested it (though I may have missed it if you want to search again). Closing this, but please let me know if you need any help getting this request filed in the other repo.


[Feature Request] Clear button on date and date range picker

Is your feature request related to a problem? Please describe.
I think isn't a problem but would be really useful to have a clear button to clean the selected date or date range.
Describe the solution you'd like
As a user i expect to have a button to clean the date selected

I would add a prop in the Date and Date range picker with the name for example -> clearable that allows to show an icon like in the Autocomplete component and clear the current Date or Date range selected.

Example of clear button.

On Clicking the button the component will look like

Describe alternatives you've considered
An alternative solution is using the startContent prop, adding a Button to clear the current Date or DateRange Selected
I know is not the best and beautiful solution but works meanwhile we wait for this feature.
const DateFilter = () => {
  const [dateRange, setDateRange] = useState<any>(null);

  return <>
      <DateRangePicker
      value={dateRange}
      onChange={setDateRange}
      startContent={
          <Button variant='light' onClick={() => setDateRange(null)} isIconOnly>
              <XMarkIcon className="w-5 h-5 text-gray-500"/> // < - Your Custom Icon to clear date
          </Button>
      } />
  </>
}

https://github.com/nextui-org/nextui/assets/58609880/68ea1dc8-cfbc-490a-be8f-e6c72a3aabed
Screenshots or Videos
No response

Is there a workaround to achieve the same using the Dropdown component? Doesn't seem support endContent or startContent neither on [Dropdown](https://nextui.org/docs/components/dropdown#dropdown-props) nor [DropdownTrigger](https://nextui.org/docs/components/dropdown#dropdowntrigger-props) components

this would be very useful

@DanielReyes03  here's a work around,
you could try re-rendering the component when the formik state changes

  const maxDate = useMemo(() => today(getLocalTimeZone()).add({ days: 1 }), [])

  const Dates = useCallback(
    () => (
        <DatePicker
          label="From"
          name="from"
          maxValue={maxDate}
          showMonthAndYearPickers
          value={formik.values.from}
          onChange={vl => formik.setFieldValue("from", vl)}
          endContent={
            <Button
              className="flex-1"
              onClick={() => {
                setSelectedFilters([])
                formik.resetForm({
                  values: {
                    from: undefined,
                  },
                })
              }}
            >
              Clear
            </Button>
          }
        />
     ),
    [formik, maxDate],
  )

@kabundege Thanks for the alternative solution. I will consider it in my next projects.
¡Happy Coding!


Permissions make no sense

We use fluentd_user and fluentd_group to set permissions when using file and template. However, we don't feed those to upstart so it runs fluentd as root. This effectively means that fluentd_user and fluentd_group don't mean anything to fluentd and don't limit fluentd's access.
We need to figure out if we want to add those to upstart or remove them entirely to enforce root/root, which is what we currently effectively do.

fixed by 63b9b4f7a7429ef6282231535c6210a404fe2735


Add a "reset with these keys" button on key write screen

Show "Failure to write. Reset card?" message if key write not successful.
The "reset with these keys" button takes you to the reset screen with the current write keys pre-loaded

nice - and then any detection of part programmed card state can be kept in the wipe function


net message from ghost connection

Describe the bug
image explains everything
Versions
v4.19.7
Screenshots and Error Logs

Can I get the entire output please? Or at least don't cut off the warning you're reporting about.

Warning: Received net message from ghost connection W3 (expected W10)

this happends a lot since your rewrite

What caused disconnection in the first place?


stellar-core v11 updates

Update to stellar-core 11 commands and always set NODE_IS_VALIDATOR=true.

Do you still need those changes @bartekn ? I don't understand why you're forcing the node to be a validator

I don't understand why you're forcing the node to be a validator

It didn't work for me in the past without it, however I don't remember the error I was getting. I just tested it again and it works. Closing in favour of #133.


pkg_resources: filter entries before parsing them

_by_version_descending is quite heavy as it tries to parse versioning and
sort ALL files listed. This is one of the heaviest method.
Actually, there might not be any need to parse those file names it there will
be ignored in the loop just after, so let filter them before sorting.
On my system, this brings down the loading of time of pkg_resources by 20%:
$ python -m timeit -n 5 -r 3 -c 'import pkg_resources; reload(pkg_resources)'
5 loops, best of 3: 1.11 sec per loop
$ python -m timeit -n 5 -r 3 -c 'import pkg_resources; reload(pkg_resources)'
5 loops, best of 3: 889 msec per loop

Pull-request updated, HEAD is now cb989a2e666b5a68f00faf8905f71407792d27ad

Thanks for this. I was going to accept this change, but then I went to extract the of_interest function and realized that the 'only' parameter has to be included. This fact makes all of this code quite complicated. I'm not even quite sure what 'only' is for. Blaming the code, I find it's very old (c721485).
I think I want to mull over this one a bit more before rolling it in because it does add complication to the already complicated code, adds redundant operations, and it's not clear to me if the benefit outweighs the cost.

I feel you @jaraco. Run cProfile and you'll see how heavy the parsing is. I've 400 packages installed on my system, so the time pkg_resources lose trying to parse things it does not want in the end has a real cost. That being said, if you have a better way to refactor this, I'm all for it.
The branch is in conflict for now, I'll update it.

Pull-request updated, HEAD is now<PHONE_NUMBER>fa6d8a6f7bf4c3008409f91958570a

@jd Please have a look at the latest commit (referenced above). I believe it accomplishes the same thing you were after.

@jaraco looks great, thanks for taking care!


Not able to connect to RobotStudio with VS 2017

When trying to connect with RobotStudio using arm.Connect(); fails with:
System.IO.FileNotFoundException
HResult=0x80070002
Message=Could not load file or assembly 'ABB.Robotics.Controllers.PC, Version=6.5.7392.129, Culture=neutral, PublicKeyToken=null'. The system cannot find the file specified.
Source=Machina
StackTrace:
at Machina.Drivers.Communication.RobotStudioManager.LoadController(Int32 controllerID)
at Machina.Drivers.Communication.RobotStudioManager.Connect(Int32 deviceId)
at Machina.Drivers.DriverABB.ConnectToDevice(Int32 deviceId)
at Machina.Control.ConnectToDevice(Int32 robotId)
at testMachinaApp.Program.Main(String[] args) in C:...\testMachinaApp\Program.cs:line 20
This is with VS 2017, using framework .NET Core 2.1. With VS 2015 and .NET framework 4.6.1, there is no issue.

Hi @mjkoehle! Sorry to hear.
Are you using Machina v0.6.2 or which version? Have you checked if ABB.Robotics.Controllers.PC.dll is being copied to the folder from which Machina.dll is being loaded in your program?

Thanks for reporting @mjkoehle.
Seems like there is a compatibility issue, will look into it.
However, we are trying to move away from external dependencies in the future. Maybe the way to go in the future is to simply not rely on any other library...

Hi Nono,
I've spoken with Jose Luis about this. I believe I tried 6.1 and 6.3 of the
distributions. I made sure  ABB.Robotics.Controllers.PC.dll was in the same
folder as  Machina.dll. I also tried referencing
ABB.Robotics.Controllers.PC.dll directly. I'm running on VS 2015 now, but
if you'd like me to check something, I can go back to 2017.
m
MichaelKoehleArt.com
On Wed, Jun 27, 2018 at 8:05 PM, Nono Martínez Alonso <
<EMAIL_ADDRESS>wrote:

Hi @mjkoehle https://github.com/mjkoehle! Sorry to hear.
Are you using Machina v0.6.2 or which version? Have you checked if
ABB.Robotics.Controllers.PC.dll is being copied to the folder from which
Machina.dll is being loaded in your program?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/RobotExMachina/Machina/issues/6#issuecomment-400896245,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AYMq6uaZANi4JPUzEVpDitaO6UWJHRGzks5uBEfngaJpZM4U6V46
.

I think the issue is clear here - ABB's dlls are not supported in .net core - have you used the .net core checker to see if the assemblies are supposed to work?
https://docs.microsoft.com/en-us/dotnet/standard/analyzers/portability-analyzer


Use placeholder expression in thrust::find

LGTM -- builds and tests pass locally. Running CI under 28459137.

@mfrancis95 Thanks for the patches! Could you merge #1169, #1171, and #1172 (and any similar additional updates) into one PR? It'll make it much easier on our internal testing/integration processes if these are all done in a single commit.

I appreciate the effort in simplifying the codebase with these placeholders. The placeholder implementations are more complex than the simpler functors they replace. We should do some due diligence and check that these changes don't significantly increase compilation times.
Also, if it turns out that these changes make the old functors obsolete, they should be eliminated with these changes.

Good points, @jaredhoberock. I'll run my build-time benchmarks on these once they're are squashed down to a single PR/commit and report back.


Remove reference in doc of the now obsolete ConvertAllUnits

Reported by kdavies4 on 29 Jan 2013 22:03 UTC
The documentation of Modelica.Blocks.Math.UnitConversions mentions ConvertAllUnits as if it still exists, but it was removed according to the version 3.0 release notes.  This patch simply removes that reference from the documentation.

Migrated-From: https://trac.modelica.org/Modelica/ticket/976

Comment by otter on 28 Mar 2013 11:15 UTC
Fixed in e5f80f203f2bab8ac3b4ab1062411c512b379023 by removing the obsolete documentation paragraph from Blocks.Math.UnitConversions as suggested in the patch.

Modified by dietmarw on 28 Mar 2013 13:50 UTC


icedcoffeescript?

good idea, i'll add it in a few days

added. (brunch/iced-coffee-script-brunch) will be available with new plugin api


Getting marked with error when my code looks correct

Challenge Waypoint: Nest an Anchor Element within a Paragraph has an issue.
User Agent is: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_1) AppleWebKit/601.2.7 (KHTML, like Gecko) Version/9.0.1 Safari/601.2.7.
Please describe how to reproduce this issue, and include links to screenshots if possible.
I am getting marked with red cross for Your p element should have the text "View more " (with a space after it). - it looks fine to me
My code:
<link href="http://fonts.googleapis.com/css?family=Lobster" rel="stylesheet" type="text/css">

CatPhotoApp

cat photos

Kitty ipsum dolor sit amet, shed everywhere shed everywhere stretching attack your ankles chase the red dot, hairball run catnip eat the grass sniff.

Purr jump eat the grass rip the couch scratched sunbathe, shed everywhere rip the couch sleep in the sink fluffy fur catnip scratched.

View more cat photos

Humm, yeah, I thought I'd fixed that.  You'll note that the instructions say:

Now nest your existing a element within a new p element so that the surrounding paragraph . . .

That implies that the anchor tag should stay where it is, relative to the rest of the text, IE: just under the
 tag.
I will add that to the description to reduce this confusion.

To be clear:  Move your new
 under the
.

Got it - i just needed to surround the existing a element with a p instead of adding another one.
thanks


Submarine 555. [WEB] Connect workbench with database for param

What is this PR for?
1.Connect workbench with database for param.
2.Fix div style of charts , parameter , metric and output page.
3.Improve output page.
What type of PR is it?
[Feature]
Todos
What is the Jira issue?
https://issues.apache.org/jira/browse/SUBMARINE-555
How should this be tested?
https://travis-ci.org/github/kobe860219/submarine/builds/707306832
Screenshots (if appropriate)

Questions:

Does the licenses files need update? No
Is there breaking changes for older versions? No
Does this needs documentation? No

@pingsutw  @kevin85421 @liuxunorg @lleohao  Please help me review this pr , thanks a lot :))

@kobe860219 Thank you contribution this feature.
There are 2 problems that need to be fixed.

Please change PR title Submarine 555. xxx... to SUBMARINE-555. xxx...
You need to understand the file format of markdown, The list in the PR content needs to be empty.

What is this PR for?
1.Connect workbench with database for param.
2.Fix div style of charts , parameter , metric and output page.
3.Improve output page.

What is this PR for?
1. Connect workbench with database for param.
2. Fix div style of charts , parameter , metric and output page.
3. Improve output page.


Update goldens and roll engine to ecbb2b28d48a3854aba846da38053cf381cced25

ecbb2b28d Call drawPaint instead of drawPath if there's clip (flutter/engine#5937)
597a50849 Roll src/third_party/skia cdfa16d086b8..4c3b63e289c5 (9 commits) (flutter/engine#5936)
715b64ee3 Roll src/third_party/skia 1400d38e0863..cdfa16d086b8 (10 commits) (flutter/engine#5934)
ffbafc852 Flush all embedded Android views on hot restart. (flutter/engine#5929)
9fe6a573e Roll src/third_party/skia 578ef2847b72..1400d38e0863 (7 commits) (flutter/engine#5933)
3b66f20d9 Don't drop MotionEvents with unknown tool type. (flutter/engine#5931)
391ac2f95 Roll src/third_party/skia 64cc576b1fa7..578ef2847b72 (20 commits) (flutter/engine#5930)
Goldens:
64b7a3a Add updated golden files
cb1fa8a Update golden files of PhysicalModel and PhysicalShape
3baed8d Add a goldens package for the embedded Android views integration test.

nit: I missed that this is a goldens roll as well, maybe include in the PR title roll engine and goldens?
nit2: add a git rev-list for the goldens roll as well to the description

@amirh Done, thanks!

This roll caused major performance regressions.

@Hixie yes, it should be fixed by https://github.com/flutter/engine/pull/5952 . I'll discuss the tests with you tomorrow.


New solution isn't updated

Somehow for problems that were already submitted to Github by Leethub before, when I redo them, the new solutions are not pushed to Github anymore.
I have tried to reload Leetcode after each submission but still didn't get it working.
I.e.:
I have just submitted a new solution to this problem:

But the last solution on Github was still the one that I submitted on Dec 7:

thanks for bringing it up. Turns out the only thing being updated was your readme (see your commits), and not the actual code. This is because the sequence of XHR requests had an incorrect logical filter, causing this issue.
I've fixed it now, and submitted to Chrome Webstore.
So, expect this fix to take another 24hrs-ish before you can see it being reflected on LeetHub.

@trungnguyencs could you confirm if this fixed it for you? (reload the extension, make sure it's v.1.1)
thanks for using leethub :D

Even though this issue is closed, I am still getting the same issue, where new submissions on Leetcode are not reflected in the GitHub repo. I have tried reloading Leetcode and also browsing to other questions and then coming back to this one. The Github repo has the very first submission on Leetcode.

Here is the history of commits on my Github repo

can u change ur code (perhaps add a space/newline somewhere) on leetcode.com and resubmit it then?

I'm experiencing the same problem even though my second submission has completely different code

Yep, started using this plugin today and came searching to report the same issue!
Can confirm I have two different code snippets, one iterative and one recursive solution, the plugin doesn't pickup the latest submission!

I've still struggled with this issue. I submitted changed code but still doesn't work.

The browser I was using was brave as well, I tried whitelisting leetcode through the browser's adblocker and a widget I had (uBlock) and it worked like a charm after that

Leethub not syncing the geeksforgeeks codes on GitHub while Leetcode  codes are updating in repo .please help to solve this issue

@QasimWani Leethub not syncing the geeksforgeeks codes on GitHub

Leethub nit syncing the Leetcode codes on Github. Can you help me with that ?

@QasimWani Leethub is not syncing leetcode on Github. I have removed adBlocker as well for leetcode.

leetcode has updated its interface and after updation the extension is not working.

Leethub is no longer syncing to GitHub after leetcode updated their interface

I have a same problem. I am using brave browser, and my code/solution can not be pushed to my GitHub.

Not working for me either, any alternative?

Not working for me either, any alternative?

Yes, Change the leetcode to use old version.

Leethub not working. no new uploads

Leethub still not working even after resetting Leetcode to an older Version.
Why it shows in the description regarding GFG code also able to push to Git, that is not even updated in Extension UI or anywhere

WHY LEETHUB IS NOT WORKING AND COMMITING TO MY GITHUB

Leethub not Working >>

Leethub is not working on Chrome, Mac OS M1

Leethub not working!! I have removed it and again added in my browser and then setup with my github repository but still it not working. What to do?

It wasn't just about me. I'm having the same problem. I'm using M1 and Chrome.

Leethub not working. no new uploads

It wasn't just about me. I'm having the same problem. I'm using M1 and Chrome.

I solved this problem by going back to  old version of LeetCode.

It wasn't just about me. I'm having the same problem. I'm using M1 and Chrome.

I solved this problem by going back to old version of LeetCode.

How you back to the older version?

I solved this problem by going back to the older version of leetcode

I went back to the previous version -> could successfully commit to github the problem-> but again the same issue has been raised!

I'm unable to upload my solutions to my GitHub repository. please help!

leethub not working, please help, no submissions working

For anyone that it isn't working for. When you are done with your code on leetcode:

Click on your profile picture icon.
Click on "Revert to old version".
Your code will persist onto the old version.
Click "Submit".
You're done! It should work!

You can always go back to the newer version once you're done with the submission. Hope this helps!


Non

This is a basic workflow to help you get started with Actions
name: CI
Controls when the action will run. Triggers the workflow on push or pull request
events but only for the master branch
on:
push:
branches: [ master ]
pull_request:
branches: [ master ]
A workflow run is made up of one or more jobs that can run sequentially or in parallel
jobs:
This workflow contains a single job called "build"
build:
# The type of runner that the job will run on
runs-on: ubuntu-latest
# Steps represent a sequence of tasks that will be executed as part of the job
steps:

Steps represent a sequence of tasks that will be executed as part of the job
steps:


print elapsed time in user friendly format instead of seconds on cli

This is not a bug but just a small user experience improvement.
When we get the status of execution using the st2 cli time is mentioned in seconds it would be nice to print time in a user-friendly format.

ex: running (339s elapsed), could be: running (5m39s elapsed)
I'll try to make a pr with the changes if its okay.

Yeah, makes better sense for CLI representation.

@winem thanks a lot for the pr. This is definitely better than just the number of seconds, that said while we are at this I think it would be a nice idea to having it something like 5d6h7m8s.

Hi @Sheshagiri, I updated the PR and the elapsed time will be presented as requested. Guess it's the right thing to do when we're talking about a more user friendly format and my priority on "less code" was not the right one in this case. :)

is this open ? i am new to opensource and would like this to be my first contribution if its possible !!!


Add GitBlamePR

Project URL
https://github.com/maoyama/GitBlamePR
Category

git

Description

Mac app that shows pull request last modified each line of a file.
Checklist

[x] Edit applications.json instead of README.md.
[x] Only one project/change is in this pull request
[x] Screenshots(s) added if any
[x] Has a commit from less than 2 years ago
[x] Has a clear README in English

@maoyama Thank you!


Feature Request: Remove Menu Bar Animation

Yabai currently implements removing the animation from spaces, would it also be possible to remove the animation when showing the menubar when it is hidden?

Another animation I would love to be removed is when moving a window to fullscreen.

Not something I will be spending time on, sorry.


Documentation Update: How to use with webpack loaders?

Is it possible to integrate this within a webpack build?
The ts-loader / awesome-typescript-loader support custom compilers, but this setting is explained nowhere.
If it is possible can you please document how to do it?

Thanks for your reply. I was hoping it would support the same core API with an ability to add the ast manipulations.
I've already tried working with the transformation API, but its very cumbersome. E.g. I've managed to rename method declarations, but how to rename the calls of the same methods eludes me.
Are you using the transformation API as an entry point for your library or do you go a different path? It would be awesome if this library could be hooked into the transformation process.

An idea which was wondering around my mind for some time, and could be
relevant now: Would a functional API be possible for this module? Could we
have something like a ts-simple-api/fp which just gives you helper
functions?
On Tue, Aug 21, 2018, 10:04 couchcrew-thomas<EMAIL_ADDRESS>wrote:

Thanks for your reply. I was hoping it would support the same core API
with an ability to add the ast manipulations.
I've already tried working with the transformation API, but its very
cumbersome. E.g. I've managed to rename method declarations, but how to
rename the calls of the same methods eludes me.
Are you using the transformation API as an entry point for your library or
do you go a different path? It would be awesome if this library could be
hooked into the transformation process.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/dsherret/ts-simple-ast/issues/396#issuecomment-414587555,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AHTnkeAE6Ulp4APXh28h4OR9F5BEgU1yks5uS78ngaJpZM4WD9XB
.

I don't believe the transformation api has the language service/symbols available so it would be difficult to figure out how to rename everything at that point.
No, I'm not using the transformation API anywhere in the library.
@lazarljubenovic I think using and developing on something like https://github.com/ajafff/tsutils would be more appropriate for that?
Anyway, closing this issue. The way that this library is currently structured makes it difficult to integrate with something like webpack. What could be done is instead of using the typescript compiler to emit, this project could be used. For example:
const project = new Project({ tsConfigFilePath: "tsconfig.json" });

// ...do all your manipulations here without saving...

// ...optionally check diagnostics...

// emit
project.emit();


CloudEvent should only allow [^a-z|0-9$] for extension names

Per the spec's naming conventions, attribute names should be all lower case, with nothing but a-z and 0-9 in the name. This module currently does not enforce that.

Is the "-" also allowed.  reading the spec,  it doesn't look like it.  If that is the case, then we will need to update the examples

It is not allowed. Only alphanumeric characters.

CloudEvents attribute names MUST consist of lower-case letters ('a' to 'z') or digits ('0' to '9') from the ASCII character set. Attribute names SHOULD be descriptive and terse and SHOULD NOT exceed 20 characters in length.

https://github.com/cloudevents/spec/blob/master/spec.md#attribute-naming-convention

Should we make this a semver-major change then?

Should we make this a semver-major change then?

Yes - we will have a semver major release as soon as the typescript version lands, so it should land with that.