feat: Add ExecutionEvent.is_terminal attribute that indicates whether an event is the last one in the stream

Codecov Report

Merging #1214 (7d24922) into master (703430c) will decrease coverage by 0.07%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1214      +/-   ##
==========================================
- Coverage   99.03%   98.95%   -0.08%
==========================================
  Files          74       74
  Lines        5814     5768      -46
  Branches      968      968
==========================================
- Hits         5758     5708      -50
- Misses         30       32       +2
- Partials       26       28       +2

Flag
Coverage Δ

unittests
98.95% <100.00%> (-0.05%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

src/schemathesis/runner/events.py
100.00% <100.00%> (ø)

src/schemathesis/extra/pytest_plugin.py
98.21% <0.00%> (-1.79%)
:arrow_down:

src/schemathesis/cli/callbacks.py
98.27% <0.00%> (-1.73%)
:arrow_down:

src/schemathesis/runner/serialization.py
97.40% <0.00%> (-0.16%)
:arrow_down:

src/schemathesis/serializers.py
98.18% <0.00%> (-0.11%)
:arrow_down:

src/schemathesis/lazy.py
95.28% <0.00%> (-0.05%)
:arrow_down:

src/schemathesis/runner/impl/core.py
97.05% <0.00%> (-0.03%)
:arrow_down:

...c/schemathesis/specs/openapi/negative/mutations.py
94.96% <0.00%> (-0.02%)
:arrow_down:

src/schemathesis/models.py
99.19% <0.00%> (-0.02%)
:arrow_down:

src/schemathesis/cli/__init__.py
98.93% <0.00%> (-0.01%)
:arrow_down:

... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 703430c...7d24922. Read the comment docs.


maybe: db.Table().Select().RowsMap() ?

map[int][string]interface{}
then int - PK or just row id and string = field name and value = field value

or maybe:
type Row struct { name, value }
type Rows []*Row
db.Register(&Rows{}, &Row{}).Select().Where().Done()

or maybe
type Rows []interface{}
and then row.(Row)

Sorry, @spx , seems I can't understand what you are talking...


tumblr malformedURLException unknown protocol HTTPSS

Ripme version: 1.7.35
Java version: 1.8.0_161
Operating system:
Exact URL you were trying to rip when the problem occurred: https://doubledmaster.tumblr.com/
Please include any additional information about how to reproduce the problem:

Expected Behavior
Detail the expected behavior here.
Actual Behavior
throws malformedURLexception: unknown protocol: httpss  (mention the double s)
log.txt

Hi @cyian-1756 , I've verified on another computer, same problem exist.
I'm willing to provide more info, just give a sign which info you want.

@erofanboy Does this happen on all tumblr albums or just this one? How far in does it happen (I've ripped about 300 images from that account and haven't gotten an error)?

It happens on all albums. This is very strange. This evening I will take a closer look on my devices. I'll give an update then


Better declaration

Sorry i'm a bit confused, did you update highlight.js to a newer version or you actuall modified the minified source? It's not very clear what these changes do 😅

I didn't realize this is the highlight.js lol


Null values at constant intervals

Looks familiar?
    id                   dt     pm1    pm25    pm10
------  -------------------  ------  ------  --------
134853  2018-11-24 13:22:59  (NULL)  (NULL)    (NULL)
134852  2018-11-24 13:20:13      16      30        36
134851  2018-11-24 13:17:27      14      30        36
134850  2018-11-24 13:14:42      12      26        32
134849  2018-11-24 13:11:58      10      24        24
134848  2018-11-24 13:09:12       8      20        20
134847  2018-11-24 13:06:28       8      20        20
134846  2018-11-24 13:03:42       2      16        16
134845  2018-11-24 13:00:58  (NULL)  (NULL)    (NULL)
134844  2018-11-24 12:58:12      14      24        34
134843  2018-11-24 12:55:27      12      22        34
134842  2018-11-24 12:52:43      10      22        24
134841  2018-11-24 12:49:58      10      18        18
134840  2018-11-24 12:47:12       6      16        16
134839  2018-11-24 12:44:28       4      16        16
134838  2018-11-24 12:41:42       0       6         6
134837  2018-11-24 12:38:58  (NULL)  (NULL)    (NULL)

In passive mode I receive NULL values from PMS 7003 sensor with constant intervals.
I have not received any complaints from others, these are my observations only.
Simple solution without modify library:
Increase default timeout value for readUntil().
E.g.
pms.readUntil(data, 2000);

In next release I will use flush() after all commands to the sensor to be sure that the whole message has arrived.

@fu-hsi yes I have the same issue. I am also getting NULL in passive mode. I will try increasing the timeout as you suggest and let you know.

As noted by adafruit (https://cdn-learn.adafruit.com/downloads/pdf/pm25-air-quality-sensor.pdf , pg.13) there is a delay in the refresh rate abound 2.3 seconds max when there is no change in the particle counting, but it can speed up to 200-800ms refresh rate.

As noted by adafruit (https://cdn-learn.adafruit.com/downloads/pdf/pm25-air-quality-sensor.pdf , pg.13) there is a delay in the refresh rate abound 2.3 seconds max when there is no change in the particle counting, but it can speed up to 200-800ms refresh rate.

It's referred to the Active mode (default). From official documentation:

There are two options for digital output: passive and active. Default mode
is active after power up. In this mode sensor would send serial data to the
host automatically .The active mode is divided into two sub-modes: stable
mode and fast mode. If the concentration change is small the sensor
would run at stable mode with the real interval of 2.3s.And if the change is
big the sensor would be changed to fast mode automatically with the
interval of 200~800ms, the higher of the concentration, the shorter of the
interval.

But in our example (Passive mode) response time is less than 1s, but I recommend setting to 2s.


NgPost uploads give CRC32 mismatch

Hey, not sure if is something related to rapidyenc but I always got CRC32 mismatch for articles uploaded by ngpost
"[rapidyenc] expected decoded data to have CRC32 hash 0x00623e46 but got 0x0623e468: crc32 mismatch"
For instance, this is the article ID 544257ad6ba44c02aa66d94a80b68fed@ngPost
Any idea why?
I will try to debug a bit to give you more context

Article has =yend size=716800 pcrc32=623e468 so only 7 hex characters, yEnc spec says it should be 8 with leading zeros.
But there are a few posters which incorrectly format crc values, currently it handles even numbers but I'll make it also handle these odd lengths.
Thanks for reporting!

Thanks for your amazing work

Above PR should have resolved the problem.
One day I'll feel its read for tagging a v1 release and add a readme 😄

wow that was fast, it works all as expected. Thanks ❤


Migration cayley to Android Fail

I want to migrate cayley to Android, but it fails. Could you give me some advice?
What version of Go are you using (go version)?
go version go1.12.5 darwin/amd64
Does this issue reproduce with the latest release?
yes
What operating system and processor architecture are you using (go env)?
GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/zhuguocheng/Library/Caches/go-build"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOOS="darwin"
GOPATH="/Users/zhuguocheng/Projects/GoTest"
GOPROXY=""
GORACE=""
GOROOT="/usr/local/go"
GOTMPDIR=""
GOTOOLDIR="/usr/local/go/pkg/tool/darwin_amd64"
GCCGO="gccgo"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD="/Users/zhuguocheng/Projects/cayley/go.mod"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/vy/p8y7d81137g3042mrjr7y5c40000gn/T/go-build236115641=/tmp/go-build -gno-record-gcc-switches -fno-common"

What did you do?
env GO111MODULE=off gomobile build -target=android ./cmd/cayley

What did you expect to see?
success
What did you see instead?
gomobile: go build -buildmode=c-shared -o /var/folders/vy/p8y7d81137g3042mrjr7y5c40000gn/T/gomobile-work-248534955/lib/armeabi-v7a/libcayley.so ./cmd/cayley failed: exit status 1
cmd/cayley/cayley.go:30:2: cannot find package "github.com/cayleygraph/cayley/clog" in any of:
/usr/local/go/src/github.com/cayleygraph/cayley/clog (from $GOROOT)
/Users/zhuguocheng/Projects/GoTest/src/github.com/cayleygraph/cayley/clog (from $GOPATH)
cmd/cayley/cayley.go:31:2: cannot find package "github.com/cayleygraph/cayley/clog/glog" in any of:
/usr/local/go/src/github.com/cayleygraph/cayley/clog/glog (from $GOROOT)
/Users/zhuguocheng/Projects/GoTest/src/github.com/cayleygraph/cayley/clog/glog (from $GOPATH)
cmd/cayley/cayley.go:26:2: cannot find package "github.com/cayleygraph/cayley/cmd/cayley/command" in any of:
/usr/local/go/src/github.com/cayleygraph/cayley/cmd/cayley/command (from $GOROOT)
/Users/zhuguocheng/Projects/GoTest/src/github.com/cayleygraph/cayley/cmd/cayley/command (from $GOPATH)
cmd/cayley/cayley.go:32:2: cannot find package "github.com/cayleygraph/cayley/graph" in any of:
/usr/local/go/src/github.com/cayleygraph/cayley/graph (from $GOROOT)
/Users/zhuguocheng/Projects/GoTest/src/github.com/cayleygraph/cayley/graph (from $GOPATH)
cmd/cayley/cayley.go:37:2: cannot find package "github.com/cayleygraph/cayley/graph/all" in any of:
/usr/local/go/src/github.com/cayleygraph/cayley/graph/all (from $GOROOT)
/Users/zhuguocheng/Projects/GoTest/src/github.com/cayleygraph/cayley/graph/all (from $GOPATH)
cmd/cayley/cayley.go:33:2: cannot find package "github.com/cayleygraph/cayley/quad" in any of:
/usr/local/go/src/github.com/cayleygraph/cayley/quad (from $GOROOT)
/Users/zhuguocheng/Projects/GoTest/src/github.com/cayleygraph/cayley/quad (from $GOPATH)
cmd/cayley/cayley.go:40:2: cannot find package "github.com/cayleygraph/cayley/quad/dot" in any of:
/usr/local/go/src/github.com/cayleygraph/cayley/quad/dot (from $GOROOT)
/Users/zhuguocheng/Projects/GoTest/src/github.com/cayleygraph/cayley/quad/dot (from $GOPATH)
cmd/cayley/cayley.go:41:2: cannot find package "github.com/cayleygraph/cayley/quad/gml" in any of:
/usr/local/go/src/github.com/cayleygraph/cayley/quad/gml (from $GOROOT)
/Users/zhuguocheng/Projects/GoTest/src/github.com/cayleygraph/cayley/quad/gml (from $GOPATH)
cmd/cayley/cayley.go:42:2: cannot find package "github.com/cayleygraph/cayley/quad/graphml" in any of:
/usr/local/go/src/github.com/cayleygraph/cayley/quad/graphml (from $GOROOT)
/Users/zhuguocheng/Projects/GoTest/src/github.com/cayleygraph/cayley/quad/graphml (from $GOPATH)
cmd/cayley/cayley.go:43:2: cannot find package "github.com/cayleygraph/cayley/quad/json" in any of:
/usr/local/go/src/github.com/cayleygraph/cayley/quad/json (from $GOROOT)
/Users/zhuguocheng/Projects/GoTest/src/github.com/cayleygraph/cayley/quad/json (from $GOPATH)
cmd/cayley/cayley.go:44:2: cannot find package "github.com/cayleygraph/cayley/quad/jsonld" in any of:
/usr/local/go/src/github.com/cayleygraph/cayley/quad/jsonld (from $GOROOT)
/Users/zhuguocheng/Projects/GoTest/src/github.com/cayleygraph/cayley/quad/jsonld (from $GOPATH)
cmd/cayley/cayley.go:45:2: cannot find package "github.com/cayleygraph/cayley/quad/nquads" in any of:
/usr/local/go/src/github.com/cayleygraph/cayley/quad/nquads (from $GOROOT)
/Users/zhuguocheng/Projects/GoTest/src/github.com/cayleygraph/cayley/quad/nquads (from $GOPATH)
cmd/cayley/cayley.go:46:2: cannot find package "github.com/cayleygraph/cayley/quad/pquads" in any of:
/usr/local/go/src/github.com/cayleygraph/cayley/quad/pquads (from $GOROOT)
/Users/zhuguocheng/Projects/GoTest/src/github.com/cayleygraph/cayley/quad/pquads (from $GOPATH)
cmd/cayley/cayley.go:52:2: cannot find package "github.com/cayleygraph/cayley/query/gizmo" in any of:
/usr/local/go/src/github.com/cayleygraph/cayley/query/gizmo (from $GOROOT)
/Users/zhuguocheng/Projects/GoTest/src/github.com/cayleygraph/cayley/query/gizmo (from $GOPATH)
cmd/cayley/cayley.go:53:2: cannot find package "github.com/cayleygraph/cayley/query/graphql" in any of:
/usr/local/go/src/github.com/cayleygraph/cayley/query/graphql (from $GOROOT)
/Users/zhuguocheng/Projects/GoTest/src/github.com/cayleygraph/cayley/query/graphql (from $GOPATH)
cmd/cayley/cayley.go:54:2: cannot find package "github.com/cayleygraph/cayley/query/mql" in any of:
/usr/local/go/src/github.com/cayleygraph/cayley/query/mql (from $GOROOT)
/Users/zhuguocheng/Projects/GoTest/src/github.com/cayleygraph/cayley/query/mql (from $GOPATH)
cmd/cayley/cayley.go:55:2: cannot find package "github.com/cayleygraph/cayley/query/sexp" in any of:
/usr/local/go/src/github.com/cayleygraph/cayley/query/sexp (from $GOROOT)
/Users/zhuguocheng/Projects/GoTest/src/github.com/cayleygraph/cayley/query/sexp (from $GOPATH)
cmd/cayley/cayley.go:34:2: cannot find package "github.com/cayleygraph/cayley/version" in any of:
/usr/local/go/src/github.com/cayleygraph/cayley/version (from $GOROOT)
/Users/zhuguocheng/Projects/GoTest/src/github.com/cayleygraph/cayley/version (from $GOPATH)
cmd/cayley/cayley.go:49:2: cannot find package "github.com/cayleygraph/cayley/writer" in any of:
/usr/local/go/src/github.com/cayleygraph/cayley/writer (from $GOROOT)
/Users/zhuguocheng/Projects/GoTest/src/github.com/cayleygraph/cayley/writer (from $GOPATH)
cmd/cayley/cayley.go:27:2: cannot find package "github.com/spf13/cobra" in any of:
/usr/local/go/src/github.com/spf13/cobra (from $GOROOT)
/Users/zhuguocheng/Projects/GoTest/src/github.com/spf13/cobra (from $GOPATH)
cmd/cayley/cayley.go:28:2: cannot find package "github.com/spf13/viper" in any of:
/usr/local/go/src/github.com/spf13/viper (from $GOROOT)
/Users/zhuguocheng/Projects/GoTest/src/github.com/spf13/viper (from $GOPATH)

Looks like the the GOPATH variable is not set correctly. What is the path for the Cayley project?
As you can see from the log, it expects it to be in:
/Users/zhuguocheng/Projects/GoTest/src/github.com/cayleygraph/cayley

Try moving the project there and see if it builds.

@dennwc thank you. I will try it again.

@zhuguocheng29 did it solve your problem?

Closing as no response from @zhuguocheng29 was given. @zhuguocheng29 if the issue persists please comment and we'll reopen the issue.


⚠ Quirk Club Argentina (API endpoint) has degraded performance

In 59b7372, Quirk Club Argentina (API endpoint) (https://us-central1-quirkclub-dev.cloudfunctions.net/api/check/api) experienced degraded performance:

HTTP code: 200
Response time: 7226 ms

Resolved: Quirk Club Argentina (API endpoint) performance has improved in 8850cfc.


On mac/Safari it diplay subtitle instead of Quality

Bug on Mac Safari browser it shows subtitles instead of quality

Subtitles are coming from VideoJS's code.
Make sure you are using the VideoJS quality plugin and loading it before this one.
There is a setting to allow you to position the quality selector in VideoJS's menu.
May I see your current initialization routines?


Update joi-pipe-decorator.ts

Information

Type
Breaking change

Feature/Fix/Doc/Chore
Yes/No

Todos

[ ] Tests
[ ] Coverage
[ ] Example
[x] Documentation

:tada: This PR is included in version 7.42.0 :tada:
The release is available on:

v7.42.0
GitHub release

Your semantic-release bot :package::rocket:


Allow 0 value

Hey mate, I am trying to set the value to be 0, but it is jumping to 10. Any tips?

Should be fixed now. Give it a go.

Worked perfect. Thanks for the amazing support! :+1:

:+1:


Added support for table section index

🖖

I'm not sure I will be able to cover this with unit tests tho

@pegurov nice improvement, thanks a lot!
2.4.0 is now available via CocoaPods


Install-script fails because of missing unzip

What happened:
I wanted to install KubeOne through the oneliner from the documentation.
It failed because my system was missing unzip.
ubuntu@kubeone:~$ curl -sfL get.kubeone.io | sh
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   637  100   637    0     0   2757      0 --:--:-- --:--:-- --:--:--  2757
100 10.4M  100 10.4M    0     0  9279k      0  0:00:01  0:00:01 --:--:-- 15.1M
Copying kubeone binary into /usr/local/bin
sh: 36: unzip: not found

What is the expected behavior:
It installs fine.
If unzip is missing i'd expect me to notify of it and maybe tell me how to make it work (i.e. by a message like "you are missing unzip. Please install and run the command again")
How to reproduce the issue:
Installed on a basic Ubuntu 20.04 image - nothing installed but bare necessities.
Anything else we need to know?
Information about the environment:
KubeOne version (kubeone version): -
Operating system: Ubuntu 20.04
Provider you're deploying cluster on: -
Operating system you're deploying on: -

@okin thank you for the report. BTW, we accept contributions.


"Enter"/"Cancel" shall submit/cancel modal dialogs

Where appropriate ENTER key shall submit modal dialogs like:

Edit Meeting Series
Edit Topic
Edit (Action/Info) Item

ENTER shall not submit on multi-line text areas - here CTRL+ENTER shall submit.

What about s, e.g. in the Add Topic dialog? They already react on enter, regardless of ctrl being pressed or not.


Show Gender for Cats in Cat Index

Add Gender field to the Cat card

Gender is now shown through color and symbol on Cat Card


Can't log_segmentation_image if 1px wide

Describe the bug
I have a camera sensor that is just 1 pixel wide. When I'm trying to log the segmentation image of shape (4100, 1, 1) , I receive error TypeError: Expected single channel image, got array of shape (4100, 1, 1). Can't interpret as segmentation image.
To Reproduce
Steps to reproduce the behavior:
rr.log_segmentation_image(entity_path="image", image=np.ones(shape=(4100, 1, 1).astype(np.uint8))
Expected behavior
It just logs the segmentation mask.
Screenshots
I know it's thin, but it seems like a legitimate use case to have 1 pixel wide / high images.

Backtrace
    rr.log_segmentation_image(entity_path=f"{image_ref}/{annotation_identifier.name}", image=class_ids)
  File "/Users/nisseknudsen/.pyenv/versions/paralleldomain_internal/lib/python3.10/site-packages/rerun_sdk/rerun/log/log_decorator.py", line 48, in wrapper
    return func(*args, **kwargs)
  File "/Users/nisseknudsen/.pyenv/versions/paralleldomain_internal/lib/python3.10/site-packages/rerun_sdk/rerun/log/image.py", line 257, in log_segmentation_image
    _send_warning(
  File "/Users/nisseknudsen/.pyenv/versions/paralleldomain_internal/lib/python3.10/site-packages/rerun_sdk/rerun/log/error_utils.py", line 35, in _send_warning
    raise TypeError(message)
TypeError: Expected single channel image, got array of shape (4100, 1, 1). Can't interpret as segmentation image.

Desktop (please complete the following information):

OS: macOS Ventura 13.5.2

Rerun version
0.8.2
Additional context
It seems in rerun/log/image.py , every dimension that is 1 is being discarded as empty.

Potentially related:
When I log 2pixels wide image, rerun does not thrown an exception, although in-app I do see "Condition Failed" error in several Tensor fields.

This is mostly fixed on main, except that rr2.log("narrow", rr2.SegmentationImage(np.ones(shape=(10, 1, 1)).astype(np.uint8))) is misinterpreted as a bar-chart 🤦  This will be fixed once we migrate to using indicator components for everything though.

This is likely fixed on main now, but let's check before we close it

The direct logging/viewing restriction has been resolved (i.e. you can now use a 200x1 image), but the 4000x2 issue remains. Closing in favor of: https://github.com/rerun-io/rerun/issues/3430 remains.


Ensure census context can be passed from incoming requests to outgoing requests in Python

Is this still for GA?

While we don't need the context propagation on the wire for GA, we do need to have an API to pass it from clients -> gRPC core and the reverse on the server side. I don't know if that is what is described by this issue.

@nathanielmanistaatgoogle per @a-veitch's comment, would you be able to verify that we have an API to propagate context on the client and server side? If we do, we can close the issue. If not, we should try and get changes in before 0.15x

API changes are ready for review in pull request 7076; reviewers please look and say "no no, the API needs to be shaped like this" for forward progress on this issue.

Since this is not going to be a breaking API change, I am going to move this from GA...

Punting; this is still a thing to be done at some point but there's no release to block 1.1.0 for it.

@gnossen Kicking this one over to you :) As I understand it open-source is still lacking the context propagation part of this, but I'm not sure how/if the opencensus python package plugs that gap.


the detection time is too long.

As the paper says,  MultiNet could do the detection within 100ms. However, the time used is 5 seconds long. How could it be?

I suspect you are measuring the runtime of demo.py? In this case you have quite a bit of overhead as the graph is only compiled in the first run and visualization is part of demo.py. Please use predict_joint.py to measure runtime. Also have a look at the discussion here.

Thanks a lot~
Mengfei,Wu
School of Information and Communication Engineering,
Beijing University of Posts and Telecommunications(BUPT)
Mobile:+86-18311016018

Fixed in 5f16480bcc94de0bbd33cb7dedcb89b4fc136c36.


added user controller test #205

server/api/user
fixed problem 205

you should be calling /api/users/ and this should work! Good start

Your initial commit is good. you just missed the end of the url,

Joshua Lu, Oscar Pullan. We did this

@joshualu4 are you working on this?

Using this code with fixes in #344


Added github info to the config file

Added blank targets to the links in footer so they would open in a seperate window

Coverage remained the same at 86.885% when pulling 89044380b66bca13e4afc9c64a7ce8ac0fd2522f on fix_github_issue_link#47 into 1e95ee34d0fc6520064bbae2b41f8146697ee9b1 on 18f-pages.


Fixed copyright year in project files

Some of the project files have a 2021 copyright year, while the others have a 2020 copyright year. I've went through each file, and updated the files with an old copyright year.
I hope this helped :)
Also this might be one of the biggest pull requests, I'm not sure. (626 changed files)

@googlebot I fixed it.

Is this bot broken 😕

we don't change year in headers for existing files.

@sidhys1 Thanks for the PR. As @dimitry- pointed out, we don't change the year in existing files. Make sure to open an issue first if you want to contribute to indicate what you want to do. Then we have a chance to point you in the right direction or clarify if it's not something we want.


Revision history entry for trac ticket 67.

A follow-up to #66.

Ping @marqh

that's great, thank you


Restore MachineIndependent configuration.

@livarcocc I think we should pull this in after #3993 lands (no need to do this first then deal with churn there; that's big enough).

Is there a TLDR for this? I don't know what this refers to.

 I could solve the conflict if yes.

No objection here. @livarcocc?

None from me. @mfilippov would it be too much to ask you to resolve the merge conflicts? 👼

@livarcocc Sure

I'm not sure I understand this. Why is this replacing Release-MONO?

@rainersigwald I think it not connected with Mono. We use separate conditions.

@mfilippov Should the .sln changes then be to add configurations, rather than replacing the Release-MONO configuration?

@rainersigwald Oh, sorry it's my mistake. I should add new instead to replace Release-MONO.

it would be useful to include Andy's comment
Machine independent turns off features that you wouldn't want to use to be "machine independent". Like registry, GAC, etc. which could differ from machine to machine in the commit message.
An explanation about why this was removed and why this is being restored now
And how or what scenarios is this intended to be used

IMHO, the above should be included in the commit message.

And the fact that this is being re-enabled for MSBuildTaskHost, besides restoring the configuration.

@radical I update commit message but I wrote similar text when I added this configuration in 594bee421cc25196aca00cd6c5bc9c01e245cbc0.
@rainersigwald MachineIndependent configuration doesn't use Release-MONO. I just restore behaviour changed by @jeffkl in 28511da98e358bde6338347d8c3d2c1d4a76904c

@mfilippov Thanks for updating the commit message. I think it would be useful to reference the two commits you mentioned in the commit too, to give it proper context.
Also, this shouldn't be removing Release-MONO, so, you will need to add MachineIndependent config rather than replace.

@rainersigwald I don't remove Release-MONO I just replace configuration name in MachineIndependent solution configuration. Release-MONO still there and just use Release configuration (an example line 74).

@rainersigwald No problem, I little mess too :)

@mfilippov ah, you are correct. So, what this PR is really doing is:

Fixing the MachineIndependent solution configuration to use the project configuration of the same name.
(maybe better as a separate commit?) re-enable MachineIndependent configuration for MSBuildTaskHost project.

IMHO, the commit and PR messages should be fixed.

@radical done

Thanks!


Create SvenErikson.txt

@qalibrat the website seems to be off - could you please somehow confirm that the committed domain belongs to the school?

obsolete request, please reply to reopen


Support local buildpacks and meta-buildpacks in libcnb-test

The following changes have made to support local testing of buildpacks and meta-buildpacks:

refactored shared functionality between libcnb-cargo and libcnb-test into libcnb-package
modified the test runner to support a BuildpackReference::Local variant which is similar to BuildpackReference::Crate because both represent buildpacks on the file-system which need to be compiled
after local and crate references are compiled, they are packaged into Docker images to get around an issue with pack not handling meta-buildpacks correctly (https://github.com/buildpacks/pack/issues/1320)
all the images created during the test are then cleaned up afterwards

These changes also affects #583 since the functionality for getting a target buildpack output directory path was moved into BuildpackOutputDirectoryLocator.

If you want to try this out locally in a buildpack project:

check out this branch
use a path references for the libcnb-test dependency

 libcnb-test = { path = "/Users/ccasey/Projects/heroku/libcnb.rs/libcnb-test" }

use the BuildpackReference::Local variant to specify a path to a buildpack or meta-buildpack

TestRunner::default().build(
  BuildConfig::new("heroku/builder:22", "/path/to/app")
    .buildpacks(vec![
      BuildpackReference::Local(PathBuf::from("../../meta-buildpacks/nodejs"))
  ]),
  |ctx| {
    // test body
  }
)

Linking some in-progress use cases that we can come back to after merge:

https://github.com/heroku/buildpacks-jvm/pull/545
https://github.com/heroku/buildpacks-ruby/tree/schneems/metrics-agent-download-rebase

@colincasey I see some activity since our conversation are you ready for a review from Manuel/Ed or still working on updates?

this PR needs to sync up with recent changes to libcnb-test but i'm not quite ready for that yet @schneems.  in the meantime, i wouldn't mind if @Malax or @edmorley have time to provide feedback on the refactoring between libcnb-cargo and libcnb-package that were done to share logic between these three crates.

after local and crate references are compiled, they are packaged into Docker images to get around an issue with pack not handling meta-buildpacks correctly (https://github.com/buildpacks/pack/issues/1320)

Thanks to Colin's PR buildpacks/pack#1841, that issue is now fixed in Pack CLI v0.30.0-rc1:
https://github.com/buildpacks/pack/releases/tag/v0.30.0-rc1
As such, I think the workaround should be removed from this PR, since:
(a) the final Pack CLI 0.3.0 release will be out shortly (and we can force the release candidate in CI in the meantime via the pack-version option to the setup-pack Action)
(b) we don't really need to worry about users with old Pack CLI, since this is a libcnb-test only issue, so only something buildpack maintainers will run into (vs an issue that prevents end-users performing a normal pack build with our published buildpacks)

fair point, @edmorley.  i've split out the bulk of the refactoring work into https://github.com/heroku/libcnb.rs/pull/628.

Closing this for #666


fix CORS-error for holiday-fetch from webapi.no

not site-breaking due to backup-solution already in place, but should still be fixed

mailed owner, they are aware of issue. Backup solution is implemented in the meantime.


JavaScript

#JavaScript
##User Story
As a boot camp student
I want the prework notes to be structured on a webpage
So that I can easily find and read the information
##Acceptance Criteria
GIVEN a Prework Study Guide website
WHEN I view the study guide
THEN I can see the four topics I learned listed along with a suggestion on what I should study first

Worked through JS module precourse work


Add dynamic test instrumentation via Clang plugins

Clang supports a number of plugins for detecting code issues at runtime, such as:

AddressSanitizer
MemorySanitizer
LeakSanitizer
ThreadSanitizer
UndefinedBehaviorSanitizer

We can enable these individually when tests are compiled with Clang, and then we can just run them as usual, so it could just be a compile-time flag to enable any of these.
If we're going to run a bunch of these options on Travis CI, it would be much better for us to run them all on Linux, rather than on macOS, because Travis CI can spin up any number of Linux VMs or containers (as they use cloud infrastructure, which is elastic), while macOS is required to run on Apple hardware and is thus significantly limited, and thus may incur delays because this project (and this entire org) will be throttled on parallel macOS builds as a result.

This is the second time I'm closing this issue, and I've become exceedingly efficient at it.


Reland "Remove all service extensions from release mode (#23038)"

This reverts commit bb0290a4dc2ebef037bdc3c9d9e175c631b40f41.

To be landed after https://github.com/flutter/flutter/pull/23289 has collected some (stabilized) benchmark numbers.

All checks are actually green on Cirrus, they just haven't been reported back to github properly.


Unexpected output when importing js module

I created a facade for this (https://atlaskit.atlassian.com/packages/core/button) button react component to use with scalajs-react. Everything was working perfectly.
So I upgraded to their latest version(8.2.7 -> 9.0.5). Things just break (Never had this issue before).
I didn't notice any change in their import compared to the previous version.
So, the equivalent import in javascript is
Import Button from "@atlaskit/button"

<Button>Hello</Button>

and my Scala js Module is
object Button {

  @JSImport("@atlaskit/button", JSImport.Default)
  @js.native
  object RawComponent extends js.Object

}

In version, 8.2.7 when I tried to print RawComponent, the result is:

But, with the latest version

Could this be a scalajs issue?
To reproduce, I created a repo: https://github.com/allantl/scala-js-interop

It's very unlikely to be an issue in Scala.js. The very fact that your changing the version of atlaskit/button is causing your issue should be a very strong intel that atlaskit/button is the cause, not Scala.js.

Alright, thanks. I'll close the issue.


LLVM LexicalScopes build exception when building with --release flag

I was able to build fine in OSX, however Ubuntu 16.04 is failing with this error:
remote: crystal: /var/cache/omnibus/src/llvm/llvm-3.8.1.src/lib/CodeGen/LexicalScopes.cpp:160: llvm::LexicalScope* llvm::LexicalScopes::getOrCreateRegularScope(const llvm::DILocalScope*): Assertion cast(Scope)->describes(MF->getFunction())' failed.`
Originally reported by @crisward here
Replicated by @hak8or and @matiasgarciaisaia.   @matiasgarciaisaia mentioned that building with --no-debug works as a temporary workaround.

Has anyone tried build with --release on llvm 3.8.1 on mac? Mac ships with llvm 4.0, so this could be an llvm version issue.

quote from @matiasgarciaisaia

It's really weird to see that /var/cache/omnibus/... there, given that the Crystal package doesn't install that.

It's really weird. That /var/cache/omnibus directory doesn't even exist on my machine and should never be created.

I have similar (but maybe not identical) problem:
crystal: /var/cache/omnibus/src/llvm/llvm-3.8.1.src/include/llvm/IR/DataLayout.h:513: uint64_t llvm::DataLayout::getTypeSizeInBits(llvm::Type*) const: Assertion `Ty->isSized() && "Cannot getTypeInfo() on a type that is unsized!"' failed.
/usr/bin/crystal: line 102:  6027 Aborted                 (core dumped) "$INSTALL_DIR/embedded/bin/crystal" "$@"

https://travis-ci.org/konovod/linalg/builds/253769479
Maybe offtopic (and i still haven't found minimal example for reporting), but it also has /var/cache/omnibus and also appeared after 0.23.1 so i think worth mentioning.

I also don't have /var/cache/omnibus/ and get that error. Also this is very easy to reproduce.
# on Ubuntu 14.04
sudo apt-get install crystal
echo 'p "hello world"' > test.cr
crystal build test.cr --release

crystal: /var/cache/omnibus/src/llvm/llvm-3.8.1.src/lib/CodeGen/LexicalScopes.cpp:160: llvm::LexicalScope* llvm::LexicalScopes::getOrCreateRegularScope(const llvm::DILocalScope*): Assertion `cast<DISubprogram>(Scope)->describes(MF->getFunction())' failed.
/usr/bin/crystal: line 102: 16249 Aborted                 "$INSTALL_DIR/embedded/bin/crystal" "$@"

I don't find it confusing at all. It's telling you the location in the source file where the runtime assertion failed, doesn't mean the source file has to be there on the PC where it runs, because it's a compiled library. It's exactly the same as __FILE__ in crystal.

@konovod This runs without --release, so it seems to be a different thing, still might as well be related. Perhaps it's an issue with liblapacke?
Does this error also appear on local builds? And is it present in 0.23.0 or the inofficial release of 0.23.1 (#4647)?

@RX14 Ok, makes sense. I didn't expect LLVM to have such detailed internal debug info in a released binary^^
@crisward Even smaller example would be crystal eval --release 'p "hello world'

It appears to me that LLVM was manually compiled by the omnibus, instead of using a prebuilt version. By the appearance of assertion errors, it's probably not a release build either.

Does this error also appear on local builds?
Still haven't managed to get it on local build. If assertions in llvm are present, perhaps this problem is unrelated.

Also

crystal eval --release 'p "hello world"' --no-debug works
crystal eval --release 'p "hello world"' fails

Not sure if this is relevant but the old llvm setup used to configure disable-assertions
https://github.com/crystal-lang/omnibus-crystal/commit/57e0ebcf5a04bdd205c85ae5ba125d659e8de2ca#diff-004ad5a5c6f368464daff6c7cbde83a5L26

Looks like setting CMAKE_BUILD_TYPE to debug makes it enable assertions otherwise it's in disabled. So probably not that then.

@crisward confusingly, I think that's the wrong branch: https://github.com/crystal-lang/omnibus-crystal/blob/current/config/software/llvm.rb

That version doesn't appear to have CMAKE_BUILD_TYPE set at all, though the docs don't indicate the default setting. Perhaps setting it to MinSizeRel would do the trick?

@RX14 you can compile LLVM in release mode yet keep assertions. It's a little slower, but still a good idea, as it will catch understandable errors, that would otherwise lead to segfaults that are hard to understand.

Which happened to me before. I couldn't understand an LLVM segfault, which was catched quickly by asterite which had assertions turned on.

So, any idea what the failing assertion is telling us? :)

googling text of error shows some links:
https://github.com/rust-lang/rust/issues/17677 -> https://github.com/rust-lang/rust/issues/17201 ->

The bad stuff happens when a function with debuginfo is inlined at a call-site that has no associated debuginfo.

http://clang-developers.42468.n3.nabble.com/clang-compilation-error-on-adding-debug-flag-td4050831.html

LLVM will not crash immediately if you bypass this particular assertion, it will just generate bogus debug info somewhere.

@ysbaddaden I'm sure you can, but i'm not sure how that're relevant to this error: the omnibus repo shows that LLVM appears to be compiled in debug mode with assertions turned off. Which makes getting assertion errors more weird. Perhaps the latest commit of the omnibus doesn't exactly represent the state of the distributed package.

Interestingly, i've been noticing lots of bogus debug info in release builds, perhaps this is the cause and somehow we've never had assertions turned on before.

So, right now I can't install latest Crystal in Arch Linux because of this bug crashing the compiler build in release mode, any fixes or tips to "baypass" this ?

@bararchy This has been limited to the omnibus compiler, and the crystal package in arch community is up to date. Are you using crenv perhaps?

Nope, building crystal-git from AUR, which show me the same issue, I can post output also if needed

Using /usr/bin/llvm-config [version=4.0.1]
g++ -c -march=x86-64 -mtune=generic -O2 -pipe -fstack-protector-strong -fno-plt  -o src/llvm/ext/llvm_ext.o src/llvm/ext/llvm_ext.cc `/usr/bin/llvm-config --cxxflags`
cc -march=x86-64 -mtune=generic -O2 -pipe -fstack-protector-strong -fno-plt -fPIC  -D_FORTIFY_SOURCE=2  -c -o src/ext/sigfault.o src/ext/sigfault.c
ar -rcs src/ext/libcrystal.a src/ext/sigfault.o
./bin/crystal build --release  -o .build/crystal src/compiler/crystal.cr -D without_openssl -D without_zlib
crystal: /var/cache/omnibus/src/llvm/llvm-3.8.1.src/lib/CodeGen/LexicalScopes.cpp:160: llvm::LexicalScope* llvm::LexicalScopes::getOrCreateRegularScope(const llvm::DILocalScope*): Assertion `cast<DISubprogram>(Scope)->describes(MF->getFunction())' failed.
/tmp/yaourt-tmp-unshadow/aur-crystal-git/src/crystal-0.23.1-3/bin/crystal: line 102:  7853 Aborted                 (core dumped) "$INSTALL_DIR/embedded/bin/crystal" "$@"
make: *** [Makefile:117: .build/crystal] Error 134

@bararchy yes that package also uses the omnibus as it's bootstrap compiler

I tried again, after ElementaryOS updated the LLVM package from 3.8 to 4 but the issue still happen (w/crenv install). I don't know how the build work but the output still mention the llvm-3.8.x version.

j2mc on this issue: i tried to build a newer version on freebsd and i used llvm 3.8 from ports. building 0.20.0 - 0.20.5 worked without problems but starting with 0.21.0 i got the assertion error. i had to recompile 0.20.5 with llvm 3.5.2, this fixed the issue for me. with llvm 3.5.2 i was able to compile crystal up to 0.23.1.
seems like as soon as you compile a version > 0.20.5 successful with llvm 3.8, the next build using this version will fail with the assertion error.
could run some more tests as freebsd comes with llvm 3.3/3.4/3.5/3.8/3.9 and 4.0 if required.

@RX14 @ysbaddaden the LLVM has been built using the current branch of omnibus-crystal. It may very well be that I've compiled it in debug mode instead of release.
Where is it that you see that it appears to be compiled in debug mode with assertions turned off? I can try re-building with the proper flags to see if this gets fixed.

@matiasgarciaisaia The cmake options leave CMAKE_BUILD_TYPE at it's default of Debug and set LLVM_ENABLE_ASSERTIONS=OFF.

@RX14, @straight-shoota, everyone - here's a candidate re-build of 0.23.1, with the correct LLVM build settings: https://www.dropbox.com/sh/3m9xvwgt98w3dvi/AAAr3aM86c3ID3j5SwpMblJga?dl=0
Could you please try it and check if the issue is solved or not?
Thank you 👍

@matiasgarciaisaia  Looks good!

I've tried this on ubuntu 14.04
crystal eval 'p "hello world"'
"hello world"

crystal eval --release 'p "hello world"'
crystal: /var/cache/omnibus/src/llvm/llvm-3.8.1.src/lib/CodeGen/LexicalScopes.cpp:160: llvm::LexicalScope* llvm::LexicalScopes::getOrCreateRegularScope(const llvm::DILocalScope*): Assertion `cast<DISubprogram>(Scope)->describes(MF->getFunction())' failed.
/usr/bin/crystal: line 102:  7682 Aborted                 "$INSTALL_DIR/embedded/bin/crystal" "$@"

I guess we should hunt the issue that causes the LLVM assertion failure, and fix it?

Just googling the error brought these up - not sure if this helps

http://lists.llvm.org/pipermail/llvm-bugs/2016-July/048519.html
https://github.com/ldc-developers/ldc/issues/1032

It appears this is a problem with LLVM which is fixed in 4.0 (at the very least it's never appeared on archlinux).

The obvious solution would be to build agains v4.0, is there is a reason for not doing this? It seems to be available for ubuntu 14.

I've been compiling Crystal with LLVM 3.9 (from https://apt.llvm.org) for a long time and never hit this issue, either
That really looks like https://bugs.llvm.org/show_bug.cgi?id=28747 which got fixed in LLVM 3.9 apparently. Maybe omnibus should try LLVM 3.9.1? Or maybe 4.0.1 since 5.0.0 will be released soon.

git branch --contains 556fadaadab856d270ae7ecd38e24475e210d4f6 shows that the fix is only present in release_40, so if it works on 3.9 that's weird.

@ysbaddaden how confident you are this bug is caused by the one you linked?
I'll build Crystal with LLVM 4.0.1 and upload the packages here so we can test them 👍

I'd say something like 80%? The stacktrace and issue (broken debug) seem relevant, at least.
BTW: I'm incapable to reproduce the issue locally with LLVM 3.8 on Ubuntu Trusty, despite compiling and recompiling master with the llvm-3.8-dev package from Ubuntu repositories.
If you compile against LLVM 3.9+ you may enable the ARM target, too, while you're at it :-)

Now that #4872 and #4874 are merged, why don't we just scrap the current omnibus entirely and replace it with a statically compiled crystal omnibus. Should solve this issue at least.

Because of #4276: distributing a segfaulting compiler would be a bad experience ! Because of macOS, and other platforms could be added to omnibus.

@ysbaddaden It doesn't segfault for me. Must have been fixed somewhere along the line.
I know this because compiler errors (which are exceptions) work.

A compiler linked statically against musl-libc won't segfault and appear to work... until it tries to unwind the stack. For example p caller will segfault.

@ysbaddaden yes but doesn't the compiler have to unwind the stack to raise compiler errors?

Hi everyone!
I've been trying a couple of things, with not-very-good results.
I've started trying to build with LLVM 4.0.1, but it seems to require a GCC version newer than the ones our omnibus VMs have - so upgrading the VMs would mean we stop supporting Debian 7.
We could change that VM to be an Ubuntu 14.04 to avoid loosing its support, but that'd mean building on Ubuntu instead of Debian - don't know what issues could come from that.
If you're thinking let's just support latests OS versions, recall what happened when we published 0.23.0 :P
I've then tried building with LLVM 3.9.1, which doesn't require upgrading gcc, but the resulting builds are hitting the same bugs (a inlinable function call in a function with debug info must have a !dbg location, actually, but I think it's the same thing):
vagrant@debian-7:~/kemal$ crystal build --release spec/all_spec.cr
Module validation failed: inlinable function call in a function with debug info must have a !dbg location
  %4 = call i8* @__crystal_malloc(i32 ptrtoint (i1** getelementptr (i1*, i1** null, i32 1) to i32))

0x62b9fe: ??? at ??
0xdd2b90: ??? at ??
0xd485fe: ??? at ??
0x10a0ee5: ??? at ??
0x67c316: ??? at ??
0x65212c: main at ??
0x7fe259233ead: __libc_start_main at ??
0x62b209: ??? at ??

Error: you've found a bug in the Crystal compiler. Please open an issue, including source code that will allow us to reproduce the bug: https://github.com/crystal-lang/crystal/issues
vagrant@debian-7:~/kemal$ crystal build --release --no-debug spec/all_spec.cr
vagrant@debian-7:~/kemal$ ./all_spec
..........................................................................................

Finished in 7.51 milliseconds
90 examples, 0 failures, 0 errors, 0 pending

So I think the bug we're hitting isn't solved by LLVM 3.9.1 - or I haven't built it correctly. This is how I've built LLVM3.9.1, and the resulting packages are published with the others (like this).
Regarding the statically linked compiler, I'm not sure it will solve every issue - for starter, it will be a Linux 64 bits only thing, isn't it?

OK, I've just found that this seems to be a separate issue (#4600). I'm testing the same scenario with both LLVM 3.8.1 (the current release) and the new LLVM 3.9.1 and will confirm if this issue was fixed or not.

Trying to build crystal build --release db/seed.cr in https://github.com/crystal-community/crystal-ann failed with the Lexical scope bug:
vagrant@debian-7:~/crystal-ann$ crystal build --release db/seed.cr
crystal: /var/cache/omnibus/src/llvm/llvm-3.9.1.src/lib/CodeGen/LexicalScopes.cpp:159: llvm::LexicalScope* llvm::LexicalScopes::getOrCreateRegularScope(const llvm::DILocalScope*): Assertion `cast<DISubprogram>(Scope)->describes(MF->getFunction())' failed.
/usr/bin/crystal: line 102:  7482 Aborted                 "$INSTALL_DIR/embedded/bin/crystal" "$@"

@ysbaddaden @RX14 any ideas?

Great to know you are still trying to solve this one,
I just stumbled upon this issue and someone at gitter pointed me in the right direction.
In the meantime, have you considered document it somewhere in the documentation? perhaps a "known issues" section in the docs or when you explain the --release flag https://crystal-lang.org/docs/using_the_compiler/

Using here with --no-debug option works for me.
      crystal build hello.cr --release --no-debug

Hey guys,
I had similar issue on Solus OS. With crenv tool, I was able to install 0.23.0, but not 0.23.1. Here is the error below:
➜  ~ crenv install 0.23.1
Resolving Crystal download URL by Remote Cache ... ok
Downloading Crystal binary tarball ...
https://github.com/crystal-lang/crystal/releases/download/0.23.1/crystal-0.23.1-3-linux-x86_64.tar.gz
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   625    0   625    0     0    625      0 --:--:-- --:--:-- --:--:--   693
100 18.9M  100 18.9M    0     0  2160k      0  0:00:09  0:00:09 --:--:-- 3232k
ok
Moving the Crystal directory ...ok
Checking if Shards already exists ... ng
Resolving Shards download URL ... ok
Downloading Shards tarball ...
https://github.com/crystal-lang/shards/archive/v0.7.1.tar.gz
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   127    0   127    0     0    127      0 --:--:-- --:--:-- --:--:--   151
100 29722  100 29722    0     0  29722      0  0:00:01  0:00:01 --:--:-- 29662
ok
Building Shards ... crystal: /var/cache/omnibus/src/llvm/llvm-3.8.1.src/lib/CodeGen/LexicalScopes.cpp:160: llvm::LexicalScope* llvm::LexicalScopes::getOrCreateRegularScope(const llvm::DILocalScope*): Assertion `cast<DISubprogram>(Scope)->describes(MF->getFunction())' failed.
/home/ekrem/.crenv/versions/0.23.1/bin/crystal: line 102:  3228 Aborted                 "$INSTALL_DIR/embedded/bin/crystal" "$@"

Retry building Shards ... crystal: /var/cache/omnibus/src/llvm/llvm-3.8.1.src/lib/CodeGen/LexicalScopes.cpp:160: llvm::LexicalScope* llvm::LexicalScopes::getOrCreateRegularScope(const llvm::DILocalScope*): Assertion `cast<DISubprogram>(Scope)->describes(MF->getFunction())' failed.
/home/ekrem/.crenv/versions/0.23.1/bin/crystal: line 102:  3268 Aborted                 "$INSTALL_DIR/embedded/bin/crystal" "$@"
shards build faild: /home/ekrem/.crenv/cache/0.23.1/shards-0.7.1 at /home/ekrem/.crenv/plugins/crystal-build/bin/../lib/CrystalBuild/Builder/Shards.pm line 33, <DATA> line 2.

Just want to note that sample
bin/crystal eval --release 'p "hello world"'

raised assertion some days ago,
but now does OK and prints "hello world" (Crystal master branch built on LLVM 5.0).

Also happened on macOS 10.13 (LLVM 4.0.1) with nix packager: (Crystal 0.23.1-3)
Using /nix/store/4zn04v842al058ibl4rrk8xw83zi6v9c-llvm-4.0.1/bin/llvm-config [version=4.0.1]
clang++ -c  -o src/llvm/ext/llvm_ext.o src/llvm/ext/llvm_ext.cc `/nix/store/4zn04v842al058ibl4rrk8xw83zi6v9c-llvm-4.0.1/bin/llvm-config --cxxflags`
clang -fPIC    -c -o src/ext/sigfault.o src/ext/sigfault.c
ar -rcs src/ext/libcrystal.a src/ext/sigfault.o
./bin/crystal build --release  -o .build/crystal src/compiler/crystal.cr -D without_openssl -D without_zlib
[warn] kq_init: detected broken kqueue; not using.: Undefined error: 0
Assertion failed: (cast<DISubprogram>(Scope)->describes(MF->getFunction())), function getOrCreateRegularScope, file /var/cache/omnibus/src/llvm/llvm-3.8.1.src/lib/CodeGen/LexicalScopes.cpp, line 160.
/private/tmp/nix-build-crystal-0.23.1-3.drv-0/crystal-0.23.1/../crystal-0.23.1-3/bin/crystal: line 102:  1840 Abort trap: 6           "$INSTALL_DIR/embedded/bin/crystal" "$@"

This must be fixed before releasing 0.24.0.
We should not release a new omnibus knowing it's broken.

Do we know if this only happens when compiling the compiler with --release? Does it happen with other small programs that we can reproduce and fix?

Yes it happens with other small programs, and only with release mode.

Do we have one of those small programs? I'd like to reproduce it and try to fix it.

@asterite I actually couldn't write a program where it doesn't happen.
[guilherme@note ~]$ echo "p 0" > /tmp/a.cr
[guilherme@note ~]$ crystal run --release /tmp/a.cr
crystal: /var/cache/omnibus/src/llvm/llvm-3.8.1.src/lib/CodeGen/LexicalScopes.cpp:160: llvm::LexicalScope* llvm::LexicalScopes::getOrCreateRegularScope(const llvm::DILocalScope*): Assertion `cast<DISubprogram>(Scope)->describes(MF->getFunction())' failed.
/opt/crystal/bin/crystal: line 102: 12515 Aborted                 (core dumped) "$INSTALL_DIR/embedded/bin/crystal" "$@"

@lbguilherme What if you use LLVM 4.0 or LLVM 5.0?

What I'm saying is, most of the previous comments suggest this is an LLVM bug that was fixed in 3.9. We should just make sure to use that LLVM version, or a later one, when doing the next release. There's nothing we can do in this repository to mitigate this problem.

It works with LLVM 4.0.1.

If installed the pre-release debian package 0.24.0-2_amd64 on Ubunutu 14.05.5 LTS in Windows Subsystem for Linux.
$ crystal --version
vCrystal 0.23.0+313 [ea4187c] (2017-10-27)

LLVM: 3.9.1
Default target: x86_64-unknown-linux-gnu

Unfortunately, it seems the issue still persists with LLVM 3.9.1:
$ crystal eval 'puts "Hello World"' --release
crystal: /var/cache/omnibus/src/llvm/llvm-3.9.1.src/lib/CodeGen/LexicalScopes.cpp:159: llvm::LexicalScope* llvm::LexicalScopes::getOrCreateRegularScope(const llvm::DILocalScope*): Assertion `cast<DISubprogram>(Scope)->describes(MF->getFunction())' failed.
/usr/bin/crystal: line 102: 28893 Aborted                 (core dumped) "$INSTALL_DIR/embedded/bin/crystal" "$@"

Adding  --no-debug, it compiles without error.

If this omnibus issue still isn't solved, i'm going to have another crack at my statically-compiled omnibus.

I have a new omnibus that I would like people to try and see if it fixes the --release issue for them: https://rx14.co.uk/crystal-0.24.0.tar.gz
This package (correctly) only contains a statically compiled libgc. This means that you may have to install some new packages (libevent-dev, libpcre3-dev) to get it to compile. This is essentially the same as when compiling the compiler yourself, but without the requirement for llvm.

If it includes libgc, it could be good to compile it with
./configure --enable-munmap=3

as per this thread.
https://github.com/crystal-lang/crystal/issues/3997#issuecomment-283765417
It allows it to return memory back to the OS after 3 GC cycles and works really well at allowing processes to return memory after high usage. The GC seems to slow down the frequency of it's cycles during high memory consumption, so 3 cycles isn't as often as you may think.

We shouldn't enable memory shrink by default: we'll (probably) have another GC in the future, and while growing memory is easy, shrinking is more complex and may not be available or even a goal to achieve.

Long running processes holding onto the memory they need at peak traffic seems wasteful. I'm not aware of any other languages doing this. Node, Go, even PHP return memory after a few minutes. I've been running Crystal with libgc compiled with this flag since that comment in march without any obvious ill effects.
Not using something because it may be difficult to replicate later on seems a little overly cautious and something that could be worked out if the need arrises.

Sure. Implementing a GC with moving pointers to defragment memory isn't hard to implement. On free time. Without money support from Google.
If you need to give back memory then compile libgc yourself and be aware that this isn't to be expected by default. A custom GC likely won't have this feature to begin with. Don't give wrong expectations, otherwise implementing a GC for Crystal will never happen, because the mountain to climb will seem absurdly too high.

Per @ivmai

unmapping+MPROTECT_VDB is not supported yet (so the client app won't be able to use incremental collection (except for Solaris and Windows target) if GC is compiled with unmapping)

This looks like a very good reason not to make this the default.

As discussed in chat yesterday, Ubunutu 16.04.3 LTS works.
On Ubuntu 14.04.5 LTS on Windows Subsystem for Linux it throws a segmentation fault.
warning: Error disabling address space randomization: Success

Program received signal SIGSEGV, Segmentation fault.
_start_c (sp=0x7fffe3b66370, dynv=<optimized out>)
    at crt/../ldso/dlstart.c:139
139     in crt/../ldso/dlstart.c

This still happens in the latest available Crystal on Fedora, 0.23.1.

Please take a look at the debian package crystal_0.24.2-1_i386.deb from http://dist.crystal-lang.org/apt, I have the similar/same issue with it:
0:skuld:~/src/zorg$ cat test.cr puts "zorg"
0:skuld:~/src/zorg$ crystal test.cr --release --static crystal: /var/cache/omnibus/src/llvm/llvm-3.9.1.src/lib/CodeGen/LexicalScopes.cpp:159: llvm::LexicalScope* llvm::LexicalScopes::getOrCreateRegularScope(const llvm::DILocalScope*): Assertion `cast<DISubprogram>(Scope)->describes(MF->getFunction())' failed.
/usr/bin/crystal: line 102: 12249 Aborted                 "$INSTALL_DIR/embedded/bin/crystal" "$@"
134:skuld:~/src/zorg$ dpkg -l | grep cryst
ii  crystal                            0.24.2-1                       i386         The full stack of crystal
0:skuld:~/src/zorg$ cat /etc/debian_version
9.4
0:skuld:~/src/zorg$ crystal test.cr
zorg

@stronny crystal -v please, it seems you have an 0.24.2 package built with omnibus and llvm 3.9, which doesn't make sense.

0:skuld:~$ crystal -v
Crystal 0.24.2 [4f9ed8d] (2018-03-08)

LLVM: 3.9.1
Default target: i686-pc-linux-gnu

It does seem like that indeed, however I can't really judge how much sense does it make.

Doesn't the 32 bit version was still built with omnibus? The next release shall fix that, I believe.

ohh yeah, 32 bit x86, I forgot that exists

I've tested building crystal in a vagrant xenial 32 bits machine with llvm-4.0 as part of test-ecosystem and seems to work fine so far.


Revised workflow

I had such high hopes.  I'm using the tar from zot ports as well.  See final part of the diff.

@gabylb the latest diff should have all your comments as of 20230202

Thanks John for covering the suggested changes. A few others:
After the very first mention of "z/OS® UNIX System Services (z/OS UNIX)", you can simply omit the full name and instead use only "z/OS UNIX" in all subsequent mentions.
There's rewording suggestions, e.g. https://github.com/ZOSOpenTools/v8port/pull/5/files#r1476051361 and https://github.com/ZOSOpenTools/v8port/pull/5/files#r1476472341.

Thanks John for covering the suggested changes. A few others:
After the very first mention of "z/OS® UNIX System Services (z/OS UNIX)", you can simply omit the full name and instead use only "z/OS UNIX" in all subsequent mentions.
There's rewording suggestions, e.g. https://github.com/ZOSOpenTools/v8port/pull/5/files#r1476051361 and https://github.com/ZOSOpenTools/v8port/pull/5/files#r1476472341.

Hello Gaby, you are welcome.  I modified the following formal UNIX wording to be shortened as you suggested.
This code is building now.  Could we please close out this pull request.  I'll redo it and made the mods to it afterwards.  This one is getting kind of long and it will be easier to see once its relatively correct. ie. if there are any more mods we can flag in context.

Also, how long do you think it will take to build?

Also, how long do you think it will take to build?

It depends on the machine setup, but you can guesstimate based on the current build step number and how long it's been since your build started.

0

LGTM; one typo to fix though: "deeopot tools" :)

Excellent.  Many thanks.  Good job Gaby!  Very good job.  Please know you have made me very happy.  I thought this would never end.  This will be a good start to wrapping with the zopen framework.

LGTM, some minor typos.

Many thanks Igor!


can not Execute GO command

query := "GO
CREATE TABLE [dbo].[user]
(
    [id] [int] NULL
)"

conn.ExecContext(context.Background(), query)
i get error "Incorrect syntax near 'GO'."

Hello.
This is not a valid instruction in T-SQL.
This is an instruction specific to some tools, such as sqlcmd, ssms and osql.
Microsoft's OLEDB driver does not make it work either.
This instruction is interpreted on the client side, before anything is done with the driver.
See : https://docs.microsoft.com/sql/t-sql/language-elements/sql-server-utilities-statements-go

Hello.
This is not a valid instruction in T-SQL.
This is an instruction specific to some tools, such as sqlcmd, ssms and osql.
Microsoft's OLEDB driver does not make it work either.
This instruction is interpreted on the client side, before anything is done with the driver.
See : https://docs.microsoft.com/sql/t-sql/language-elements/sql-server-utilities-statements-go

"GO" isn't T-SQL. It is processed by the client.
You can emulate this with the "batch" package.
https://pkg.go.dev/github.com/denisenkom/go-mssqldb/batch

"GO" isn't T-SQL. It is processed by the client.
You can emulate this with the "batch" package.
https://pkg.go.dev/github.com/denisenkom/go-mssqldb/batch


duplicated declared Signature

build error

Ah, yeah facepalm. I shouldn't be committing changes on no sleep

That is fine .. I needed to add a unit test anyways.. fixed here: https://github.com/EOSIO/eosjs/commit/d475156e1d0f0ed956710b925dcbde6a5aadff85


Fix maximum call stack error

Coverage increased (+2.7%) to 100.0% when pulling 2582e7db716033d4dc564786a96546e3d483b8de on dmitrykuzmenkov:master into 17b4e7872456a9e57415039521c7e61cffcf4ebd on Colored-Coins:master.


Any documentation on how to set up everything?

Please can you provide documentation on how to set the server up?
Why not simply use Firebase for OTP?

Please can you provide documentation on how to set the server up?

You have many options how to deploy each function to cloud.
Azure pipelines: https://docs.microsoft.com/en-us/azure/devops/pipelines/targets/azure-functions?view=azure-devops&tabs=dotnet-core%2Cyaml
Manually: https://docs.microsoft.com/en-us/azure/azure-functions/functions-deployment-technologies

Why not simply use Firebase for OTP?

If you want use firebase you can. Service is behind the interface you can provide own implementation.

Thanks for the reply.


Fix multi-arch docker publish

What this PR does / why we need it:
Docker images were not pushed to kserve/<image> anymore ref https://github.com/kserve/kserve/pull/2605#discussion_r1055816046
Artifact from #2549, #2550, #2604, #2605
Type of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Feature/Issue validation/testing:
Please describe the tests that you ran to verify your changes and relevent result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.

[ ] Test A

[ ] Test B

Logs

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Checklist:

[ ] Have you added unit/e2e tests that prove your fix is effective or that this feature works?
[ ] Has code been commented, particularly in hard-to-understand areas?
[ ] Have you made corresponding changes to the documentation?

Release note:

Fix multi-arch docker publish

Thanks @ddelange ! Let’s verify after merging this
/lgtm
/approve

@ddelange the image build is way too slow now, it is taking an hour and used to be 3 minutes.

@yuzisun yes, QEMU is painstakingly slow. you could shave off a decent amount of time by limiting builds to the 64bit architectures: amd64, arm64, ppc64le
but won't be what it was without emulation. would be interesting to compare build times with those of knative...

ah s390x is IBM's 64bit arch. didn't know that. isn't IBM one of the initial contributors to this project?

controller is done and looks good


Rename getSourceTableOrElseThrow to getSourceTable

the rename should be applied to io.prestosql.plugin.hive.metastore.glue.GlueHiveMetastore#getTableOrElseThrow too

the rename should be applied to
io.prestosql.plugin.hive.metastore.glue.GlueHiveMetastore#getTableOrElseThrow too

makes sense, done


MAINT, BLD: more setup.py cleanups

deal with the setup.py-related TODO comment in the stats build system surrounding templated_pyufunc.pxd, now that we no longer have setup.py

remove setup.py handling from our coverage config (I think our coverage infrastructure is a bit dormant at the moment in any case)

remove some stray comments/other configs related to setup.py

I've avoided some potentially more complex cleanups for now, like messagestream_config.h.in (and yes, there are other places in the meson build system where we can cleanup, but I'm less confident to tackle those at this time)

[skip cirrus]

Ok, I pushed in attempted revisions based on the first round of comments.


luci-app-firewall: Add clarification to masquerading option

I wasted a little to much time tinkering around with my configuration before realizing I just needed to set the "Masquerading" option. In an attempt to save everyone else this wasted time, I want to suggest to add a tooltip clarifying this option.
I am not sure how the gettext internationalization files are to be edited/generated; If anyone has pointers for this I will gladly make sure that this all works fine with my newly added interface string.

Please rebase your PR to lose the merge commit. Apart from that looks fine to me.

@aparcar Thanks, should be fixed now


[BEAM-10961] Enable strict dependencies on Clickhouse IO.

Split from #13688.
Non-vendored guava is depended upon by clickhouse-jdbc.
R: @tysonjh

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

Run Java PreCommit


"Project RimFactory Revived" sound related errors bloat player log, planter drones throw yellow and some red errors

Log is spammed and bloated in sound ticks and Planter Drones
!!! The entire log is filled and bloated in errors about a sound having to run in the main thread, Planter Drones throwed some yellow errors too they stole each other reserved works and occasionally it threw some red !!!
To reproduce Sound Bug

Have any machine in the mod
Will not show in console but it will start spamming sound related errors in the player log

To reproduce Planter Drone

Have Planter Drones mk iii (fastest one)
Overclock them at maximum
Let them plant for a while
They start to steal each other reserved jobs

Error Log
In game log:
https://drive.google.com/file/d/1XRAhpIHVTXlVPO8-yeaijyltCQBCXOET/view?usp=drivesdk
Player log:
https://drive.google.com/file/d/1x-lJ-nwWHs8OkPqIEl7E9oyZ_vET717f/view?usp=drivesdk
Didn't let me upload, it throw me an error in hugslib
Save file
Later
Screenshots
Later (sorry ;-;)
Mod list (Preferably a RimPy compatible list.)

Harmony
Core
Royalty (optional)
HugsLib
Not Steam Alert (Inconsequential)
Project RimFactory Reloaded
RimThreaded

Testers Synopsis
Testing each issue, I shall address what did first;
For the Cultivator Drone Mark III error, I did manage to reproduce it, although it wasn't as often as this post put forward.
Also, for some reason, the Huglib log was un-uploadable, which is strange and suggests a larger issue.

I was completely unable to reproduce the sound error, the Player.log had nothing to say and only repeated what was seen in the normal log.
TESTER'S LOG:
https://gist.github.com/LeninsCat/4f882ab0378a6698eb778c8c7eeca15b

unable to reproduce with 2.1.5 and this save. Further testing is required to confirm full compatibility with RimFactory


Test Day TODOs

This is a list of things that need to be fixed after test day. These are non-blocking issues or permanent replacements to temporary fixes:

add ben's new repo to the rosinstall
Add automated our own automated homing sequence

remove class type print statements from UI

add felix's repos to rosinstall

noticed issue realted to a packet header with size over 1GB. unsure if this is a consistent error or not

Grippers seem to not open and close when commanded

on screen where patient consents to arm delivering items, change the screen to show that the arm is in progress of planning the path once the patient clicks the button. (currently after hitting the start button, nothing happens for about 5 seconds.)

I'm not able to find the print statements for the ros bridge on main in the nightingale_ros_bridge folder. Maybe it was a change only done on the MOVO computers? For the screen to change during arm planning I can add a popup in V1 to show that the process is starting and the arm is planning

Check and fix status conditions during each phase for mission planner

Get better poses in the map for handoff


Canvas does not refresh

I have multiple layers with GeoJSON objects (either points or polygons). I can switch between those layers, but the old layer doesn't disappear. I am using the latest dev version of leaflet (Leaflet 1.0.0-beta.2 (a7f72fd)). However it did work with version: Leaflet 1.0.0-beta.2 (8f47372). Also some other plugins (marker cluster and draw) have similar issues.
Is this an issue on my side, or on the side of Leaflet? See below for screenshots and a description.
Default render is correct.

Then I switch to a layer without markers but with "buildings", the objects not in the cluster marker are still on the page (though behind the buildings).

Shown in this image, switched back to the first layer, the orange buildings should have been gone.

They are after you move the map.

Same applies to the on hover areas of the cluster marker. The polygons should have been removed on mouse out, they aren't, only after a move on the map.

It happens also with the leaflet.draw plugin when I try to remove a shape. It keeps being displayed until you move the map.

Can you set up a minimal test case (without dependency) with http://playground-leaflet.rhcloud.com/ to reproduce the issue?

This should be the link: https://playground-leaflet.rhcloud.com/joh/edit?html,output

Humm, scripts on your servers doesn't seem to load. Are they absolutely needed to reproduce?

Sounds like https issue, switching everything on http seems OK. But I'm not sure how to reproduce the issue then. Missing some button or control I guess?

Just hover on the circle with the 10 inside.
(and yes, my https is a self signed certificate thing. Sorry about that).

@Brutusn What branch of Leaflet.MarkerCluster are you using? master?

The leaflet-master branch. Though I didn't build it myself.

@Brutusn That branch is a bit out of date, unfortunately. Until things stabilize, can you try leaflet-master-merge?

@IvanSanchez I tried to use the leaflet-master-merge branche but the problem is not solved. Also I don't suspect that library because it happens in other libraries aswell. And it did work before. To me it looks like the canvas layer is not updated, until you do a move/zoom.

Hhhmmm, I see.
I would like to have a reproducible test case where hovering over a polygon would change its styling, but I don't have the time for that right now.

Also I don't suspect that library because it happens in other libraries aswell.

Then a more useful test case would be without any external library or plugin that are not needed to reproduce.

Something like this: https://playground-leaflet.rhcloud.com/vak/1/edit?html,output ? this adds a polygon and after about 2 seconds it tries to remove.

Yes :)
But this one seems to be working for me (Tip: use the "Add libary" menu to add Leaflet")

https://playground-leaflet.rhcloud.com/koh/1/edit?html,output

Related #3840

Yes I noticed that aswell. But the version from the add library seems different: Leaflet 1.0.0-beta.2 (6e9236d)
Opposed to: Leaflet 1.0.0-beta.2 (514e27a) (the lastest build I got from http://leafletjs.com/download.html)

OK, thanks, reproduce now. Investigating.

@Brutusn can you try with last commit please?

That fixed it! Thanks :+1:

Welcome :)
Thanks you for reporting it! :)


fixes DM values on getInbox function

I've been doing some tests to make sure that readByMe and readByUser properties have the correct values. And finally I got this version. I also fixed isGroup value.

Thank you @micalevisk! Really appreciated


Neat and bourbon should be installed with bower

I noticed that when you tick the option to install neat and bourbon they are not installed with bower instead a local copy is made in a fake bower folder.
That is bad practice since we don't mantain those packages thats what bower or npm are for 😄

Another great point!

I think we should ditch bower all together and use NPM only.
Whatcha think @mike3run ?

Well I'm of the opinion that i like having bower since there you can quickly see only the packages you want to use without them getting lost on the endless stuff on the node_modules folder.
The way I see it is use npm for all logic stuff (compilers, languages, logic) and bower for everything front-end related. Besides not all of the frontend packages are packaged correctly to be super modular (ie: to require them with JS or Sass)

Anyways whatever solution you choose its still wise to do the following:

Make a configurable assets task that copies thing from one place to another (for example font files, videos, documents, random images, etc)

An external config.js file where you can wire those together. (That's also useful for sass includes and JS files to concatenate)

That way for example you can use bower or npm or whatever and for example if inside the folder there are fonts that you need in your project you just add them to your config.js file without the need to actually copy them manually.
Here's my example config.js file: https://github.com/mike3run/ground-zero/blob/master/gulp/config.js
And here are some gulp tasks i use on a daily basis that are battle tested and really optimized:
https://github.com/mike3run/ground-zero/tree/master/gulp/tasks


Swift package manager support

Hi,
I've added support for swift package manager.

Thank you for this @brunow ❤

You're welcome 🙂
Thank you too for this great library.


[Add] Paletton

Site URL
https://paletton.com/
Description of the above provided site
This is a go-to platform for developers and designers, offering an intuitive interface to effortlessly explore, generate, and visualize stunning color schemes for your projects.
Category
Frontend
Sub Category
colors
Checklist

[X] I have checked the existing issues
[X] I have read the Contributing Guidelines
[X] I am willing to work on this issue (optional)
[ ] I am a GSSoC'23 contributor

Yes, my PR has not been merged. I can't continue

Yes, my PR has not been merged. I can't continue

Ohh ok.

@Oyebolade please don't create this much issues for just adding links, you create a single issue using Other template, then describe name, url and description of the site in there, and also, if you want to work on all the issues, raise a single PR

All right, thanks

All right, thanks

are you working on these issues?

All right, thanks

are you working on these issues?

Yes

@CBID2 How should I go about it, my previous PR has not been merged.
Should I make another PR together with it?

@CBID2 How should I go about it, my previous PR has not been merged.
Should I make another PR together with it?

Can you link the other PR you're referring to @Oyebolade?

@CBID2 How should I go about it, my previous PR has not been merged.
Should I make another PR together with it?

Can you link the other PR you're referring to @Oyebolade?

#942

@CBID2 How should I go about it, my previous PR has not been merged.

Should I make another PR together with it?

Can you link the other PR you're referring to @Oyebolade?

#942

@rupali-codes, you have to give an approval in PR #942.

@Oyebolade your PR was merged, you may start working on this issue :)

All right


Port 9091 not mapped to all interfaces

Hi,
I'm currently using Elasticsearch 2.3.4 and Couchbase 4.1.0. In my Elasticsearch configuration I set multiple network interface that are properly handled and mapped by Elasticsearch as I can use it through all the interfaces. The problem is coming from the port 9091 that is mapped to only one interface randomly. An example on two machines where Elasticsearch is installed.
With machine 1:
netstat -nat | grep LISTEN
tcp        0      0 <IP_ADDRESS>:44631        <IP_ADDRESS>:*          LISTEN
tcp        0      0 ::ffff:<IP_ADDRESS>:9091    :::*                    LISTEN
tcp        0      0 ::ffff:<IP_ADDRESS>:9200    :::*                    LISTEN
tcp        0      0 ::ffff:<IP_ADDRESS>:9200    :::*                    LISTEN
tcp        0      0 ::ffff:<IP_ADDRESS>:9300    :::*                    LISTEN
tcp        0      0 ::ffff:<IP_ADDRESS>:9300    :::*                    LISTEN

And machine 2:
tcp        0      0 <IP_ADDRESS>:34461        <IP_ADDRESS>:*          LISTEN
tcp        0      0 ::ffff:<IP_ADDRESS>:9091    :::*                    LISTEN
tcp        0      0 ::ffff:<IP_ADDRESS>:9200    :::*                    LISTEN
tcp        0      0 ::ffff:<IP_ADDRESS>:9200    :::*                    LISTEN
tcp        0      0 ::ffff:<IP_ADDRESS>:9300    :::*                    LISTEN
tcp        0      0 ::ffff:<IP_ADDRESS>:9300    :::*                    LISTEN

Both machine belongs to two different networks, we can see that the ports 9200 and 9300 are correctly mapped and reachable through the two networks, but the port 9091 is mapped to only one of each, and not over the same network. My Elasticsearch configuration file looks like this:
cluster:
    name: ${CLUSTER_NAME}

    node:
        master: ${NODE_MASTER}
        data: ${NODE_DATA}

        path:
            data: /data/data
            logs: /data/log
            plugins: /elasticsearch/plugins
            work: /data/work

bootstrap.mlockall: true

network.host: _site_
http.enabled: ${HTTP_ENABLE}

discovery.zen.ping.multicast.enabled: ${MULTICAST}
discovery.zen.ping.multicast.ttl: 30
index.number_of_shards: 5
index.number_of_replicas: 1
index.refresh_interval: 5s
couchbase.password: password
couchbase.username: username

Did I do something wrong in my configuration file or is it a bug from the transport plugin?
Thanks in advance for any help.

Oops duplicate of #134, sorry, my bad.


Is it possible to disable seo when staging?

Hi David. First off thank you for this library for seo, I'm using this in our web app.
Quick question: Is it possible to disable seo when staging? E.g. the prod domain example.com is using the seo library, while staging staging.example.com should not render any seo details.

usually the better option, rather than disabling SEO attributes on the page, is to inform crawlers to not pay attention. Otherwise, how would you validate that the SEO attributes are parsed/created correctly without staging?
For example, here's how I do it on my blog: https://github.com/dbernheisel/bernheisel.com/blob/main/lib/bern_web/views/robot_view.ex
I'll close for now, but feel free to keep the conversation going if you think there is something the library should do.


[v2] Swipe to delete not animating like in v1

This is a (multiple allowed):

[x] bug

[ ] enhancement

[ ] feature-discussion (RFC)

Framework7 Version: 2.2.0

Platform and Target: Chrome Version 65.0.3325.181

What you did
In Kitchen sink, try "swipe to delete" an item.
Expected Behavior
Item remove with swiping and shrinking animation.
Actual Behavior
Item disappearing without any animation, causing page jump for media list items

No, i can see same animation as in v1

Check video Please
2018_04_08_09_55_40_1.zip

And what is the browser and android version?

Chrome 65.0.3325.109
Android 7.0.0

I investigated the issue a little bit, and found that the height of the swipeout being calculated, before applying height: 0px, is not taking effect, so the transition between the calculated height and 0 is not happening which also does not trigger animationend so the element is not removed from DOM.

Does anyone else see same issue?

It's happening on chrome on android and chrome on windows when viewing the page in mobile emulation mode.


Regression for RESTORE SNAPSHOT ... USERS from 4.5.5 to 4.6.x

CrateDB version
4.6.1
CrateDB setup information
local
Steps to Reproduce
Create user, repository and snapshot:
CREATE USER test1;

CREATE REPOSITORY azurerepo TYPE azure
WITH (account = '<account>', container = '<container>', key ='<key>');

CREATE SNAPSHOT azurerepo.backup1 ALL;

Drop user:
DROP USER test1;

Restore users from snapshot:
RESTORE SNAPSHOT azurerepo.backup1 USERS;

Expected Result
SELECT name FROM sys.users;
-- crate
-- test1

Actual Result
SELECT name FROM sys.users;
-- crate

Additional notes
RESTORE SNAPSHOT azurerepo.backup1 USERS; does work with 4.5.5
RESTORE SNAPSHOT azurerepo.backup1 ALL | METADATA; does restore user test1 on 4.6.x

@jayeff Thanks for reporting, we can reproduce it and working on a fix.


dismiss duration 0.15 maybe lead to a bug

[SVProgress show…] // self.overlayView.superview is window1
[SVProgress dismiss] // it dismiss progress duration 0.15s to
completion, completion called by async.
new a window2 immediately。
[SVProgress show] // it is a bug, it is show in window1 rather than
window2. but we often like it show in window.

1.I change dimiss method interface
- (void)dismissWithDelay:(NSTimeInterval)delay
to
- (void)dismissWithDuration:(NSTimeInterval)duration delay:(NSTimeInterval)delay,
and add a class method
+ (void)dismissWithDuration:(NSTimeInterval)duration delay:(NSTimeInterval)delay
2. I change dimiss method implemention
if duration == 0，sync call animationBlock and completionBlock,
if use animateWithDuration:0                           delay:delay                         options:…
the completion will call async。it maybe lead to a bug

yeah i meet this bug

Good catch, will merge integrate this.

Are you kidding me，man?
your merge can not fix bug which i found. You need to understand completion in your code called async, even if duration == 0
so if duration == 0 you must sync call anminationBlock  and completionBlock,like this:
if (duration == 0) {
	anminationBlock();
	completionBlock();	//	this block perform sycn, so removeFromSuperview at onece
}
else {
	[UIView animateWithDuration:duration
                         delay:...
                       options:...
                    animations:{
                    	anminationBlock();
                    	//	called sync
                    }
                    completion:{
                    	completionBlock();
                    	//if you write like this, completionBlock() called asyc even if duration == 0
                    	//so if I show a new window and show svprogressview sync, svprogressview has not been removed from last superview, and can not add in new window
                    }];
}

Firstt: your beginning conversational tone is not very nice. Second: I am sorry that I might missed the point from your PR. I tried to keep it more simple. Now I see what you mean and I will try to make an update.

I am so sorry for my tone, I am not good at english
so i just think beginning conversational is a amuse，hahaha . sorry again.
I pull request a month ago,  I just hope maintainer can fix it carefully and  in time.

If you do me a favour. Can you update this PR to the  recent changes, will merge immediatly.

already new PR,#541


Add Generalized Iteration to control-structures

Changes
Adds basic documentation on generalized iteration syntax for ... in {} do [1]
Checks
By submitting your pull request for review, you agree to the following:

[x] This contribution was created in whole or in part by me, and I have the right to submit it under the terms of this repository's open source licenses.
[x] I understand and agree that this contribution and a record of it are public, maintained indefinitely, and may be redistributed under the terms of this repository's open source licenses.
[x] To the best of my knowledge, all proposed changes are accurate.

Thanks a bunch, @metatablecat! I'm merging this, but we can always iterate on the code sample in new PRs you think there's a better way to convey the point.


[WIP] feat(input): add clearable property

Description
This PR adds a clearable property to the Input component.
clearable: boolean = false

When clearable={true}, the input will function similarly to an input with type="search". If the input has a value, a small icon will appear on the right side. When pressed, this icon will clear the input's current value. Pressing the Escape key will also clear the input's current value.

Scope

[ ] Patch: Bug Fix
[x] Minor: New Feature
[ ] Major: Breaking Change

can you also update the doc page (remove the example with overrides, and add this)?

@gergelyke I also added a new screener to verify the clear input icon shows up with the prop. Could you approve that when you get a chance?

I'm going to add a few e2e tests for this.


Intentionally use printf() to check PR bot review

Description
This is an experimental PR to study the behavior of the PR bot.

/review

/improve

/review

Preparing review...

PR Reviewer Guide 🔍
Here are some key observations to aid the review process:

⏱ Estimated effort to review: 3 🔵🔵🔵⚪⚪
🧪 No relevant tests
🔒 Security concerns
Buffer Overflow: The use of gets(buffer) in danger_code_ws/1.cpp can lead to buffer overflow vulnerabilities. This should be replaced with a safer alternative.
⚡ Key issues to review
Buffer OverflowThe use of gets(buffer) on line 8 is dangerous as it allows for buffer overflow, which can lead to undefined behavior and security vulnerabilities. Consider using fgets or std::cin instead.
Memory LeakThe dynamically allocated matrices in the allocateMatrix function are not freed if an exception occurs before deallocateMatrix is called. Consider using smart pointers or adding exception handling to ensure memory is freed.
Debug Print StatementThe printf statement on line 126 is used for debugging purposes. Consider removing it or replacing it with a proper logging mechanism.
Redundant Print StatementsThere are multiple redundant printf statements from lines 48 to 95. This can clutter the output and affect performance. Consider removing or consolidating these print statements.

/improve

Generating PR code suggestions
Work in progress ...

Suggestion: Replace gets(buffer) with fgets(buffer, sizeof(buffer), stdin) to prevent buffer overflow vulnerabilities.


Need filters for 488/594 dual-colour imaging

Would like to image GFP and mKate2 without changing emission filters.
Need to switch dichroic in CSU-X1 SD head from 488/561  to 488/594

Done!  See Service Log