Localization.EnsureInitialized() should not throw DxaItemNotFoundException

When calling Localization.EnsureInitialized() while the _System\Publish Settings page of that publication is not published should not throw an DxaItemNotFoundException.
The Localization objects of not-publised sites can appear in the Localization.SiteLocalizations of other publications. Hence it is not unexpected if the _System\Publish Settings is not available and Localization should not throw an exception.
Maybe when the _System\Publish Settings page is not published this publication should not be listed in the Localization.SiteLocalizations at all.

I would expect the Localization.EnsureInitialized method to throw an exception when the Localization cannot be initialized (because the underlying Publication is not published); I don't like silently ignoring error conditions (it tends to lead to unclear errors/exception later in the process).
However, it seems to me this "issue" is related to your work-around for another issue: https://github.com/sdl/dxa-web-application-dotnet/issues/45
Do you think this issue is still relevant if that other issue would be fixed?

This issue is releated to #45 in the sense that #45 has a try-catch block as a workaround for this exception.
Comment https://github.com/sdl/dxa-web-application-dotnet/issues/45#issuecomment-286169679 is descibing a workaournd to load all localizations. It calls Localization.EnsureInitialized() which might throw this exception.
This issue (#48) will still be relevant when #45 is resolved because there can be other logic which calls Localization.EnsureInitialized().

Maybe the real issue is that the Localization object exists in the first place. I agree that something should happen when `Localization.EnsureInitialized()' cannot load the Localization, but it is is unexpected when a publication's settings page is not published?
If DXA would load all Localization.SiteLocalizations and remove the SiteLocalizations which cannot be loaded then it would not be an issue, and Localization.EnsureInitialized() can thow the error indeed.

I agree with the idea to suppress Localization for Publications which are not published from Localization.SiteLocalizations  and still letting Localization.EnsureInitialized throw an exception in case it cannot be initialized (this is really be an exceptional, unrecoverable error condition).  Would you agree with closing this issue and keeping #48 open, then?

yes, agree 👍


[Feature] OAP BanyanDB Storage module

Search before asking

[X] I had searched in the issues and found no similar feature requirement.

Description
This tracks the progression of BanyanDB storage module:

[ ] TableInstaller, schema registration
[ ] MetricsQuery
[ ] Record, Segment and Trace Query
[ ] Log
[ ] Event
[ ] NoStream
[ ] Management, UI Template
[ ] AggregationQuery
[ ] Alarm and Alarm Record
[ ] Batch
[ ] BrowserLogQuery
[ ] EBPF
[ ] History deletion （Rely on TTL of BanyanDB)
[ ] NetworkAddressAlias
[ ] Profile
[ ] TopN
[ ] Topology

Use case
No response
Related issues
No response
Are you willing to submit a PR?

[ ] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

@dmsolr @lujiajing1126 Would you please fill the above checklist?

@dmsolr @lujiajing1126 Would you please fill the above checklist?

Sure


search for NOT author

Code of Conduct

[X] I have read and agree to the GitHub Docs project's Code of Conduct

What article on docs.github.com is affected?
https://docs.github.com/en/search-github/searching-on-github/searching-issues-and-pull-requests#search-by-author
What part(s) of the article would you like to see updated?
I was specifically trying to find out how to search pull requests for everything NOT from a specific author. I didn't find anything in this article already (or an existing issue) with the tip to add the dash before the qualifier. I don't think it warrants its own section of the article, just maybe a single example, like in the Search by author section, showing how to do the logical NOT search.
Additional information
Here's a specific example for context (but I don't really want to include in the doc 😄 )
https://github.com/MicrosoftDocs/windows-itpro-docs/pulls?q=is%3Aopen+is%3Apr+-author%3Araju2529+
(that author has a lot of PRs, several hundred in the past few week, so trying to filter those out of the search results)

@aczechowski Thank you for opening an issue and linking it to your PR! ✨


Hide Unsupported Game Versions

as the name suggests, would it not be possible to just use the java runtime that the launcher started with for minecraft and if the java version is incompatible with say java 8 classes then should the game versions not be hidden behind a toggle where you would need to specify or allow to download a copy of java 17(specifically for x64 computers)?

would it not be possible to just use the java runtime that the launcher started with for minecraft

not necessarily

if the java version is incompatible with say java 8 classes then should the game versions not be hidden behind a toggle where you would need to specify or allow to download a copy of java 17

that's not really necessary because the launcher will already download the appropriate java runtime from Mojang as necessary. There's also not really a way to tell the version of the java runtime if it is specified explicitly in the profile settings, so the launcher can't actually determine class file version compatibility. It only knows what java version should be downloaded for a specific version of the game.

then why not use that information to limit the supplied options for unsupported Operating systems? Windows xp for example never supported java 17 so it would be safe to hide all minecraft versions that rely on java 17 or above in windows xp.

You know that instead of just saying random things you can actually back up your point and prove it, find a Java 17 version that works with Windows XP service pack 3, I dare you. If you can't, then stop spouting nonsense. As far as anyone here is concerned there is no such thing as a version of java 17 or Java 21 for that matter that supports Windows XP service pack 3 x86.

This feature would introduce an annoying maintenance burden which simply is not worth the effort.

then stop spouting nonsense

https://github.com/olauncher/olauncher/issues/82#issuecomment-2147404325


Middleware: Redeploy undeployed archive: Status remains Disabled

When redeploying undeployed archive file on EAP7 server, it still shows deployment as Disabled.

Upload some WAR archive into MiQ to be deployed on EAP7 server. After deployment it shows status Enabled.
Undeploy archive. It will show status as Disabled.
Redeploy archive. Wait for some time, refresh provider... Archive status is still Disabled. But in fact archive is deployed successfully in EAP7 side, available and has success logs.

@abonas

@miq-bot add_label providers/hawkular
@miq-bot assign @ammendonca

@miq-bot add_label bug

@hhovsepy can you please check if the successful deployment/redeployment event is shown (or not) on the Timeline where all events show?

From Timelines, as an Application Event Group, I can see only event for the initial deployment. Which is:
"EAP7
Event Type: hawkular_deployment.ok
Event Source: HAWKULAR
Provider: hayk-hawkular-services.bc.jonqe.lab.eng.bos.redhat.com
Message: Performed [Deploy] on a [Application] given by Inventory path [/t;hawkular/f;98d3b462-0b16-4c75-b682-714465ec2685/r;EAP7~~]
Middleware Resource: EAP7
Date Time: 07/18/16 11:13:06 UTC"
The undeployment/redeployment events are not shown.

@hhovsepy thanks for the investigation.
@ammendonca please check this. thank you

I have been investigating this and it seems there are separate issues:

Once a deployment is removed, the agent fails to check it's availability/state and it doesn't get updated (so, if it was Enabled it will keep being reported as Enabled, if it was Disabled it will remain Disabled).

Doing a redeploy on a removed deployment, actually redeploys it (there are logs in the console registering the web context, the app opens in the browser) but it is not visible in the deployments (tried via JBoss CLI. Also this explains why the agent can't monitor it and update it's state).

I am working on adding remaining operations (stop deployment, start deployment) and will further investigate on the behaviors , but the deployment missing even in the CLI looks like a WF bug to me.

@ammendonca thanks for the thorough check.
so it sounds like this is :

a bug that should be reported on the agent (and not miq) for removing a deployment without updating the state.
an additional bug in WF regarding redeploy of a removed deployment not showing up
cc @pilhuhn
@hhovsepy please see those findings above, I suggest opening relevant bugs to relevant projects/components and closing this one as this is not manageiq provider specific implementation issue.

i would like to discuss how we handle bugs like this .... i will set up a quick etherpad and call ...

Further investigation on a vanilla wildfly (ie, without hawkular) shows that the same issue isn't present, undeploying & redeploying via the CLI. After that tested the same process, via CLI, in a Hawkular server and everything looked fine. This hints that the issue should be in the way the ruby-client/command-gateway perform the operations.

On 19 Jul 2016, at 16:57, Alexandre Mendonça wrote:

Further investigation on a vanilla wildfly (ie, without hawkular)
shows that the same issue isn't present, undeploying & redeploying via
the CLI. After that tested the same process, via CLI, in a Hawkular
server and everything looked fine. This hints that the issue should be
in the way the ruby-client/command-gateway perform the operations.

Can you do one more test:
undeploy and/or redeploy from within MiQ on the managed Wildfly.
Wait until you see in WF console that something happened
Then go to the provider and press the refresh button.
Then after a bit of waiting, go back to the deployments and see if
the status changed.

For WFLY10 as well, it keeps showing Disabled after enabling and refreshing (~10 mins wait).

I am looking at this. I can see at least one occasion in the agent that needs fixing.

@pilhuhn I see this error in server logs after Undeploy:  https://issues.jboss.org/browse/HAWKULAR-970
But after server restart it is gone, and deployment is unavailable.

@hhovsepy can you confirm this is fixed in current master and close the issue if it is ? Thanks.

@ammendonca verified, issue is fixed.
Now it works correctly with enable/disable operations.
Undeploy removes archive.


Unable to generate VS solution file with scons

Godot version
master
System information
Windows 10, VS2022
Issue description
Unable to generate VS2022 solution file with scons.
Steps to reproduce
Followed the official guide
C:\open_source\godot>scons p=windows vsproj=yes dev_build=yes
scons: Reading SConscript files ...
Auto-detected 24 CPU cores available for build parallelism. Using 23 cores by default. You can override it with the -j argument.
Found MSVC version 14.3, arch x86_64
Building for platform "windows", architecture "x86_64", target "editor".
NOTE: Developer build, with debug optimization level and debug symbols (unless overridden).
TypeError: can only concatenate deque (not "list") to deque:
  File "C:\open_source\godot\SConstruct", line 927:
    methods.generate_vs_project(env, GetOption("num_jobs"), env["vsproj_name"])
  File "C:\open_source\godot\methods.py", line 859:
    module_configs = ModuleConfigs()
  File "C:\open_source\godot\methods.py", line 763:
    self.add_mode()  # default
  File "C:\open_source\godot\methods.py", line 786:
    self.arg_dict["cppdefines"] += ModuleConfigs.for_every_variant(env["CPPDEFINES"] + defines)

Minimal reproduction project
N/A

Duplicate of https://github.com/godotengine/godot/issues/74725/

The fix worked. Thanks!

Either the usage of SCons 4.4 needs to be specified in the documentation, i.e. here: https://docs.godotengine.org/en/stable/contributing/development/compiling/compiling_for_windows.html#setting-up-scons or methods.py needs patching. I got it to work by casting defines to a deque.

@geekrelief Are you saying that the fix from https://github.com/godotengine/godot/pull/75309 is not working for you?


[FEAT] Auth, Login, create account with username and password

new login and accounts based authentication

introducing session based auth for browsers and and jwt bearer access-tokens for api
backwards compatible with, ?usr get params and x-api-key

notes

there should be a road to drop support for the old authentications style or some kind of new version without that.
user.id is encoded inside the bearer token

todo

[x] remove usr from nodemanagment
[x] fix 3 failing tests

looking like good stuff here @dni
can we haz Nostr login? or maybe later.....  :D

This PR uses fastapi_login which is a 3rd party library.
At the same time fastap.security offers the same functionality.
I believe we need a good reason for bringing in a new library instead of using the standard one.

There should be a field in settings: lnbits_allowed_auth_methods=. Possible values:

user_id (default, what it is now. Necessary for backwards compability)
email (email and password)
nostr (NIP-07, browser extension recommended)
google (supported by OAuth2)
twitter (supported by OAuth2)
...

Eg:
# lnbits_allowed_auth_methods=user_id
# lnbits_allowed_auth_methods=email
lnbits_allowed_auth_methods=email,nostr,twitter

This PR uses fastapi_login which is a 3rd party library. At the same time fastap.security offers the same functionality.
I believe we need a good reason for bringing in a new library instead of using the standard one.

fast api login uses fastapi security under the hood. Its just more convenient.
Just like using sqlalchemy can be considered more convenient than using psycopg2 directly.

There should be a field in settings: lnbits_allowed_auth_methods=. Possible values:
* `user_id` (default, what it is now. Necessary for backwards compability)

* `email` (email and password)

* `nostr` (NIP-07, browser extension recommended)

* `google` (supported by OAuth2)

* `twitter` (supported by OAuth2)

* ...

Eg:
# lnbits_allowed_auth_methods=user_id
# lnbits_allowed_auth_methods=email
lnbits_allowed_auth_methods=email,nostr,twitter

its a good idea, but it exceeds the scope of this pr.
this pr is meant to get rid of the ?usr inside url.  we can build upon this PR further down the line.

fast api login uses fastapi security under the hood. Its just more convenient - but I dont know about the exact differences, Just like using sqlalchemy can be considered more convenient than using psycopg2 directly.

Ok, but any 3rd party library has some risk&disadvantages compared with the base framework, some examples:

it will not be maintained after a while
fewer people know how to use it
it does not allow access to some low-level APIs
footprint (an extra installed library)
maintenance (extra lib to upgrade)
...

I'm not saying A or B is better, but if A is the built-in default and we go with B then we need some good reasons to do so.

its a good idea, but it exceeds the scope of this pr.
this pr is meant to get rid of the ?usr inside url. we can build upon this PR further down the line.

it is important to maintain backwards compatibility, some people will not want to switch to email+pass login right away
other users might want to ditch immediately user_id only auth and only use email+pass, they need to specify this somehow
I agree that nostr, google, twitter can come with a second PR

its a good idea, but it exceeds the scope of this pr.
this pr is meant to get rid of the ?usr inside url. we can build upon this PR further down the line.

it is important to maintain backwards compatibility, some people will not want to switch to email+pass login right away
other users might want to ditch immediately user_id only auth and only use email+pass, they need to specify this somehow
I agree that nostr, google, twitter can come with a second PR

Agreed, should be transitional. I also hate the idea of being the only lightning wallet you have to log in to, have discussed with DNI and session token will last forever unless user uses log out

I am also strongly against ditching regular key authentication completely. LNbits makes it easy to build on, and that should continue. With nodes and the like using key authentication, its not something we need ditch.
We have spoken about being able to optionally turn off key authentication.

If new users are not allowed (see https://github.com/lnbits/lnbits/pull/2017/) then the Sign Up flow should not be allowed (UI and API checks)

Will be deprecated in favor of https://github.com/lnbits/lnbits/pull/2092


wish: changelog

Please include a Changelog or use the Github Releases feature not include a human-friendly list of changes in each release.
Thanks.

Done


solved issue regarding local_settings.py file not found

Related Issue

Error about local_settings.py not found during initial setup of project

Closes: #5
Describe the changes you've made

Added steps in README.md of how to setup local_settings.py file for local system and to ignore it in .gitignore
moved relevant settings.py settings to local_settings.py file like secret_key, database configuration, email host configurations

Checklist:

[x] My code follows the style guidelines of this project.
[x] I have performed a self-review of my own code.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] I have made corresponding changes to the documentation.
[x] My changes generate no new warnings.

Maintainers please add the gssoc21 tag to issue #5. It will help me to progress in gssoc21.

I've mentioned how to create local_settings.py file while setting up the project before makemigrations. And have copy pasted these secret_key, database config, email config in readme.me. so the one who will setup might follow it properly.
And if local_settings.py is included and not put in .gitignore then that will have no impact of creating another local_settings.py differently.

Hey @patilkrunal, let's wait on out project admin's review on this. Till then, can you solve the merge conflicts? Thanks! 😄

resolved.
Also local_settings.py was put inorder to have private information on localmachine itself and not in public. so it will be better to include local_settings.py file.


DoltHub.Dolt version 1.4.0

[ ] Have you signed the Contributor License Agreement?
[ ] Have you checked that there aren't other open pull requests for the same manifest update/change?
[ ] This PR only modifies one (1) manifest
[ ] Have you validated your manifest locally with winget validate --manifest <path>?
[ ] Have you tested your manifest locally with winget install --manifest <path>?
[ ] Does your manifest conform to the 1.4 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: codeflow:open?pullrequest=https://github.com/microsoft/winget-pkgs/pull/109580&drop=dogfoodAlpha

Close with reason: Stale pull request;


eliminate IAppStructs.SyncProjectors() and .AsyncProjectors()

Motivation
Now, in current architecture
IAppStructs.SyncProjectors() and .AsyncProjectors() just read according projectors from underlying AppConfigType

Problem (warm): not used anymore

Technical design
eliminate

wrong way. Need to get projectors from IAppStructs, otherwise need to provide stateful projectors to IAppPartiions etc.


Custom parser function

To handle the possibility of the image route been a path or a url the new parser uses an enum Image to keep that information and avoid repeated type parsing.
Closes: #46
Signed-off-by: Rafael Garcia Ruiz<EMAIL_ADDRESS>

This has been adapted and added as a commit on top of #41


Game crash

mods used: untoggle-sprint with optifine, optifabric, fabric api, minecracft version 1.20.1
here are logs hopefully they help.
how to recreate this crash?

Use mods mentioned above
launch game

Hello! This is a very well made report, thank you, the logs were helpful.
Optifine / Optifabric are known to break compatibility with other mods. The issue in question is caused by the technical way that I change the button Spring: Hold to Spring: Untoggle in the Minecraft settings (see Modrinth gallery).
Unfortunately I do not see a way to solve this on my side without undesired side effects. But since that feature is not essential to the mod's functionality, I made a build of it for you that just doesn't try to change that. You can download it in this GitHub Release in this repository. Make sure you have sprint set to Sprint: Hold to enable the mod.
Closing this as not planned because of aforementioned reasons.

Hello. Optifine / Optifabric is known to break compatibility between mods, and now including Untoggle sprint. There is nothing I can do, and I recommend not using Optifine / Optifabric if possible.


Seed all random number generators

@AngusL points out that Marian is non-deterministic which makes regression tests hard (paging @afaji).  Moreover https://github.com/amunmt/marian/blob/13ee36be159386f93259c3c6c8bfd80db5f52fff/src/training/config.cpp#L154 is misleading because it says "for all random number generators".
https://github.com/amunmt/marian/blob/9ce67850b80b0be5fb3d2a51c645b45ac170786d/src/data/batch_generator.h#L111 should change from the deprecated two-argument `random_shuffle' to the three-argument seeded version.
https://github.com/amunmt/marian/blob/13ee36be159386f93259c3c6c8bfd80db5f52fff/src/data/corpus.cpp#L44 does seed.

Yes, that's a bug. Should use the seed everywhere.

#53


How to pause Scanning in continious mode ?

Hello,
I'm working with the 1.5.4 version as per the xamarin component store and the question i have is related to the issue here
https://github.com/Redth/ZXing.Net.Mobile/issues/225
The scenario I am trying to resolve is for the user to be able to scan a barcode and the once the scan has occured ask the user for input in regards to a qty. The use case being that the user wishes to scan 25 or so identical items all have the same barcode, but instead of doing 25 scans, do one scan and enter the qty 25 into some form of input panel.
I have implemented a custom overlay whereby i have a number pad for the user to enter a qty. This should be acivated when the scan has fired.
In the issue logged above, the behaviour whereby the scanner stopped or paused after scanning seems to be what I want as the current behaviour is to exit scanning mode completely in the single scan mode or to continue scanning in the continuous mode.
I would like to be able to pause scanning, ask for qty, ( deal with it in code ) then restart scanning.
The only option scan.cancel does not seem to to this
Is this available in any format ( e.g 2)
also will the latest build implement seamlessly over the top of 1.5.4 ??
All the best
Bruce

I'm not sure if pause scanning is available, you could implement it in your project though.

Oh If only I was that clever !!
:-)

Are you trying to display the inout panel on the camera view or close the camera view when single item is scanned, then open the input panel, and re-open the panel when user is done entering the the quantity..

Hello.
The requirement is /was for after every scan the user should be able to enter the scanned qty or accept the default of 1.
My first attempt was to use a custom overlay to which I had added a jumped made up of buttons and a label to display the qty.
I was hoping to use continuous scanning mode as that would avoid the scan function from being topped when a barcode  was read. The idea was to use a the delegate to ask the user from th qty and the to confirm it with an ok or cancel button.
I wanted to pause the scanning in case the scanner updated the scanned Resilt be reading a new barcode when the user was entering the data. A pause function seemed to be a good idea.
In the end however I resorted to putting the Numpad into a separate view and using a alert dialog in modal form which I presented when a normal scan was selected.

So if you were to use the individual ZXingScannerView classes directly they already had a concept of PauseAnalysis and ResumeAnalysis which when you pause analysis, it means the camera feed keeps running however the code won't try and find a barcode in the feed while paused.
I've just added this concept to MobileBarcodeScanner as well.

Great news.
Having the option on the scanner is what was needed..
B...
On 13 Jan 2016, at 17:26, Jonathan Dick<EMAIL_ADDRESS>wrote:
So if you were to use the individual ZXingScannerView classes directly they already had a concept of PauseAnalysis and ResumeAnalysis which when you pause analysis, it means the camera feed keeps running however the code won't try and find a barcode in the feed while paused.
I've just added this concept to MobileBarcodeScanner as well.
—
Reply to this email directly or view it on GitHub.


Cycle matrix

Hello Nils,
Love OSM tools it got me out of a spot of bother recently.
I'm having a small problem now though trying to create a matrix for cycling or walking ODs. The error I receive is
" 400 (Parameter 'sources/destinations=100' is out of range. Maximum possible value is 25.)"
No such problems using the same ODs for driving.
Any solutions?
many thanks
D

Yep, that's a rate limit thing, see here:
https://openrouteservice.org/ratelimits/
It was due to the fact, that those profiles were not using any speedup algorithm until very recently. However, that's fixed by now. I'll let the devs know to increase the number of possible input:
https://github.com/GIScience/openrouteservice/issues/225


Fastify example doesn't work

Fastify example doesn't work. I was unable to find a reason but it doesn't work at all, also you don't have a fastify dependency in a package.json.

You are correct, it should have fastify in the package.json.
Except that, what is the error that you get?


Add null check to MP Server.Builder.config() (#5363)

Add null check to MP Server.Builder.config()

Improve the NullPointerException assertion test

This fix is for https://github.com/helidon-io/helidon/issues/5370


[manila-csi-plugin] Unable to resize volumes with CSI-NFS-driver and manila-CSI-plugin

/kind feature
What happened:
I'm unable to resize an NFS volume created with ManilaCSI and CSI-NFS-driver
Warning  ExternalExpanding      10s                    volume_expand Ignoring the PVC: didn't find a plugin capable of expanding the  olume; waiting for an external controller to process this PVC.
What you expected to happen:
Volume gets expanded
How to reproduce it:
Create a pvc and a storage class with the code below.
---
apiVersion: storage.k8s.io/v1
kind: StorageClass
metadata:
  name: manila-csi-autogrow
parameters:
  csi.storage.k8s.io/node-publish-secret-name: csi-manila-secrets
  csi.storage.k8s.io/node-publish-secret-namespace: manila-csi
  csi.storage.k8s.io/node-stage-secret-name: csi-manila-secrets
  csi.storage.k8s.io/node-stage-secret-namespace: manila-csi
  csi.storage.k8s.io/provisioner-secret-name: csi-manila-secrets
  csi.storage.k8s.io/provisioner-secret-namespace: manila-csi
  type: default_share_type
  appendShareMetadata: "{\"autogrow\": \"80\"}"
allowVolumeExpansion: True
provisioner: nfs.manila.csi.openstack.org
reclaimPolicy: Delete
volumeBindingMode: Immediate

---
apiVersion: v1
kind: PersistentVolumeClaim
metadata:
  name: manila-csi-autogrow
  namespace: manila-csi
spec:
  accessModes:
    - ReadWriteMany
  resources:
    requests:
      storage: 1Gi
  storageClassName: manila-csi-autogrow

Then try to expand the pvc with:
kubectl patch pvc manila-csi-autogrow -p '{"spec":{"resources":{"requests":{"storage":"2Gi"}}}}'

Anything else we need to know?:
As per some of the resolved issues in this repo (https://github.com/kubernetes/cloud-provider-openstack/pull/1579) I assume this should be possible but I've also seen that the supported NFS CSI driver (https://github.com/kubernetes-csi/csi-driver-nfs) does not support volume expansion. I couldn't find any other CSI-NFS-driver to use. What am I missing?
Environment:
openstack-manila-csi: 1.22.0
OpenStack version: 3.18.0
K8s cluster version 1.18.5
CSI-NFS-driver: chart version 3.0.0 - https://github.com/kubernetes-csi/csi-driver-nfs/tree/master/charts
Many thanks in advance

Hi, the nfs node plugin isn't involved in the expansion - it looks like the request never got to manila-csi controller plugin; Is your external resizer set up correctly?
/cc @gman0 for more thoughts

Thanks for your answer @gouthampacha I assumed manila-csi talked to csi-nfs-driver to actually tell OpenStack to change the size of the volume. I'll check the configuration ASAP and will let you know.

Hi again @gouthampacha,
Can I please suggest to have a look into the error log here please? It is a related issue I submitted to the external resizer repo. That error shows external-resizer does not found resizing capabilities in the csi-nfs-driver used
Also, here are the settings for the NFS resizer container:
`- args:

--csi-address=$(ADDRESS)
--handle-volume-inuse-error=false
env:
name: ADDRESS
value: unix:///var/lib/kubelet/plugins/nfs.manila.csi.openstack.org/csi-controllerplugin.sock
image: k8s.gcr.io/sig-storage/csi-resizer:v1.2.0
imagePullPolicy: IfNotPresent
name: nfs-resizer
resources: {}
terminationMessagePath: /dev/termination-log
terminationMessagePolicy: File
volumeMounts:
mountPath: /var/lib/kubelet/plugins/nfs.manila.csi.openstack.org
name: nfs-plugin-dir
 As per the [documentation](https://github.com/kubernetes-csi/external-resizer), csi-address is the path to the CSI driver socket inside the pod that the external-resizer container will use to issue CSI operations (/run/csi/socket is used by default).

Based on that, shouldn't it be /var/lib/kubelet/plugins/csi-nfsplugin/csi-controllerplugin.sock instead of /var/lib/kubelet/plugins/nfs.manila.csi.openstack.org/csi-controllerplugin.sock but that doesn't work either.
I've updated the image for nfs-resizer to 1.3.0 but still I couldn't make it work

Some extra nodes in case they help
I1117 14:48:37.664147       1 main.go:93] Version : v1.3.0                                                                                I1117 14:48:37.664276       1 feature_gate.go:245] feature gates: &{map[]}                                                                                I1117 14:48:37.667344       1 connection.go:154] Connecting to unix:///var/lib/kubelet/plugins/nfs.manila.csi.openstack.org/csi-controllerplugin.sock                                                                                I1117 14:48:37.670077       1 common.go:111] Probing CSI driver for readiness                                                                                I1117 14:48:37.670105       1 connection.go:183] GRPC call: /csi.v1.Identity/Probe                                                                                I1117 14:48:37.670112       1 connection.go:184] GRPC request: {}                                                                                I1117 14:48:37.676826       1 connection.go:186] GRPC response: {"ready":{"value":true}}                                                                                I1117 14:48:37.676970       1 connection.go:187] GRPC error: <nil>                                                                                I1117 14:48:37.676989       1 connection.go:183] GRPC call: /csi.v1.Identity/GetPluginInfo                                                                                I1117 14:48:37.676993       1 connection.go:184] GRPC request: {}                                                                                I1117 14:48:37.677522       1 connection.go:186] GRPC response: {"name":"nfs.manila.csi.openstack.org","vendor_version":"0.9.0@latest"}                                                                                I1117 14:48:37.677628       1 connection.go:187] GRPC error: <nil>                                                                                I1117 14:48:37.677646       1 main.go:141] CSI driver name: "nfs.manila.csi.openstack.org"                                                                                I1117 14:48:37.677658       1 connection.go:183] GRPC call: /csi.v1.Identity/GetPluginCapabilities                                                                                I1117 14:48:37.677662       1 connection.go:184] GRPC request: {}                                                                                I1117 14:48:37.678443       1 connection.go:186] GRPC response: {"capabilities":[{"Type":{"Service":{"type":1}}}]}                                                                                I1117 14:48:37.678561       1 connection.go:187] GRPC error: <nil>                                                                                I1117 14:48:37.678573       1 connection.go:183] GRPC call: /csi.v1.Controller/ControllerGetCapabilities                                                                                I1117 14:48:37.678577       1 connection.go:184] GRPC request: {}                                                                                I1117 14:48:37.679209       1 connection.go:186] GRPC response: {"capabilities":[{"Type":{"Rpc":{"type":1}}},{"Type":{"Rpc":{"type":5}}}]}                                                                                I1117 14:48:37.679307       1 connection.go:187] GRPC error: <nil>                                                                                I1117 14:48:37.679318       1 connection.go:183] GRPC call: /csi.v1.Node/NodeGetCapabilities                                                                                I1117 14:48:37.679322       1 connection.go:184] GRPC request: {}                                                                                I1117 14:48:37.680081       1 connection.go:186] GRPC response: {"capabilities":[{"Type":{"Rpc":{"type":2}}},{"Type":{"Rpc":{"type":5}}},{"Type":{"Rpc":{}}}]}                                                                                I1117 14:48:37.680204       1 connection.go:187] GRPC error: <nil>                                                                                F1117 14:48:37.680218       1 main.go:161] CSI driver neither supports controller resize nor node resize

Hi @JPRbrs.

Like @gouthampacha said, csi-nfs isn't involved at all. Resizer must be pointed to manila-csi's socket, i.e. /var/lib/kubelet/plugins/nfs.manila.csi.openstack.org/csi-controllerplugin.sock.
Please make sure you're actually using manila-csi 1.22. Output from external-resizer suggests you're not: {"name":"nfs.manila.csi.openstack.org","vendor_version":"0.9.0@latest"}. It seems you're on the latest tag and not v1.22.*. I've just tried to deploy manila-csi with latest, and it breaks like you've described. See https://hub.docker.com/r/k8scloudprovider/manila-csi-plugin/tags for available tags.

In fact I'm not even sure where this latest tag is coming from. It's not built from master branch, that's for sure, otherwise this would work. @lingxiankong @ramineni do you know?

@gman0 Its CPO version , https://github.com/kubernetes/cloud-provider-openstack/blob/master/pkg/csi/manila/driver.go#L61 . It gets set here I suppose, https://github.com/kubernetes/cloud-provider-openstack/blob/master/Makefile#L35 .

. I've just tried to deploy manila-csi with latest, and it breaks like you've described

How did u deploy with latest? u meant with latest tag? so is the issue reproducible?

@ramineni what I meant to ask is if you know what branch is used to build images tagged latest? It doesn't seem to be master.

Bumping manila-csi-plugin container to v1.22.0 prevents the pod from crashing but trying to resize with
kubectl patch pvc manila-csi-nfs -p '{"spec":{"resources":{"requests":{"storage":"2Gi"}}}}'

throws this error:
  Warning  VolumeResizeFailed     5s (x4 over 8s)       external-resizer nfs.manila.csi.openstack.org                                                                         resize volume "pvc-94e9d569-3b66-431e-9bbc-3fb26f8f891f" by resiz
er "nfs.manila.csi.openstack.org" failed: rpc error: code = InvalidArgument desc = volume expand secrets cannot be nil or empty

I'll keep looking into it...

@JPRbrs you need to reference the controller expand secret in your storage class.
See the docs here https://kubernetes-csi.github.io/docs/secrets-and-credentials-storage-class.html

csi.storage.k8s.io/controller-expand-secret-name: csi-manila-secrets
csi.storage.k8s.io/controller-expand-secret-namespace: manila-csi type: default_share_type

@ramineni what I meant to ask is if you know what branch is used to build images tagged latest? It doesn't seem to be master.

It should be master ideally. /cc @lingxiankong

@JPRbrs you need to reference the controller expand secret in your storage class.
See the docs here https://kubernetes-csi.github.io/docs/secrets-and-credentials-storage-class.html

I wasn't aware of those secrets!! Many thanks @gman0 that worked brilliantly!!

@ramineni what I meant to ask is if you know what branch is used to build images tagged latest? It doesn't seem to be master.

It should be master ideally. /cc @lingxiankong

@gman0 when version is latest , it pulls from here https://hub.docker.com/r/k8scloudprovider/manila-csi-plugin/tags , which we peridically push from master branch . If its not working from master branch , then its an issue

/reopen
to check if its working with latest as well

@ramineni well as @JPRbrs just demonstrated, it's not working in latest. It seems it's built from something else otherwise @JPRbrs wouldn't run into this problem. Maybe we open a new ticket for this? This one is solved.

@gman0 Im ok to open new ticket for this . It is built from MASTER branch. You could also locally test it , by building locally pulling latest code and tag it to latest.

Let's continue the discussion in https://github.com/kubernetes/cloud-provider-openstack/issues/1702.
/close


Add virtual host for https on port 443

Similar to default virtual host config in puppet-aem-resources https://github.com/shinesolutions/puppet-aem-resources/blob/master/templates/httpd.conf.epp#L25, helloworld should also support https.
The idea is that https should still work after deploying helloworld app.

Done. Included in 0.10.1 .


[BUG]: Error handling not good in node.go:nodeProbe() and other similar functions

Bug Description
In nodeProbe the call to goscaleio.DrvCfgQueryGUID() can fail for a number of reasons. The error check does not log the actual error and not all code paths in DrvCfgQueryGUID() log errors for serviceability. We have had a number of issue that have proven to be tedious to troubleshoot without seeing the errors from the lower layers. Improvements are needed to make the code more serviceable.
Logs
error: time="2024-04-16T17:13:52Z" level=fatal msg="grpc failed" error="rpc error: code = FailedPrecondition desc = unable to get SDC GUID via config or automatically"
Screenshots
No response
Additional Environment Information
No response
Steps to Reproduce
Reach out to me. Will update this once I get more info.
Expected Behavior
Show the actual error so that the issue can be better understood.
CSM Driver(s)
csi-powerflex 2.10. The problem exists in main.
Installation Type
Helm, not really sure. Contact me for details.
Container Storage Modules Enabled
No response
Container Orchestrator
minikube
Operating System
Linux

Hi @donatwork,
Is the request asking to precisely replicate the error message retrieved from https://github.com/dell/csi-powerflex/blob/7775ff900314e03cdec5a861d7b79dd42f9bc3e8/service/node.go#L472 and update the code at https://github.com/dell/csi-powerflex/blob/7775ff900314e03cdec5a861d7b79dd42f9bc3e8/service/node.go#L475 to:
if err != nil {
    return status.Errorf(codes.FailedPrecondition,
        "unable to get SDC GUID via config or automatically: %s", err)
}

Best regards,
Adarsh

Yes, the request is to evaluate the code throughout the driver and check for cases where errors lower down are not propagated to the higher layers in order to improve serviceability. I mentioned only one place as I was investigating an issue. There may be many other places where this problem exists.

Yes, the request is to evaluate the code throughout the driver and check for cases where errors lower down are not propagated to the higher layers in order to improve serviceability. I mentioned only one place as I was investigating an issue. There may be many other places where this problem exists.

Sure, thanks for bringing this to our attention.

/sync


fix: implement the same word boundary search as the like query

Description
Fixes #1037

[x] I have read and understand the CONTRIBUTING.md document in this repository

Type of change

[x] Bug fix (non-breaking change which fixes an issue)

Checklist:

[ ] I have added tests that prove my fix is effective or that my feature works
[ ] Existing test suite passes locally with my changes
[ ] I have made corresponding changes to the documentation

I've refactored the regex into a separate file in the src/utilities folder. Let me know if this is the correct location.
I'll try and take a stab at the e2e testing as well.

@DanRibbens I've add the e2e test for word boundary search (and search in general).
While doing so I noticed a few issues that I've also fixed:

When the collection doesn't have a useAsTitle the default id field is used. The sanitizeFormattedValue then just does a normal like search, no word boundaries. I've implemented a similar check. As a relationship can be isMulti you could theoretically mix one id and one other field in the same react-select. In this case I've opted to go with word boundary search in case one of the relationships has a useAsTitle. I figured being able to partially match an id would not be a use-case often encountered.
The docs on react-select specify null is a valid value for filterOption but that just leads to the search not working at all. I've changed it to undefined which does result in the expected functionality

Let me know if there's anything you'd like to see changed.

Thanks @wezzle, everything looks great! We'll get it out soon in the next release.


powa-archivist-REL_4_1_4 make command fails on Postgres 16.3

I'm trying to compile powa-archivist 4.1.4 and create powa extension on Postgres 16x database.
However the make command fails as below:
[postgres@server1 powa-archivist-REL_4_1_4]$ make
gcc -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Werror=vla -Wendif-labels -Wmissing-format-attribute -Wimplicit-fallthrough=3 -Wcast-function-type -Wshadow=compatible-local -Wformat-security -fno-strict-aliasing -fwrapv -fexcess-precision=standard -Wno-format-truncation -Wno-stringop-truncation -O2 -fPIC -fvisibility=hidden -I. -I./ -I/pgbin/pgpoc1d/16.x/include/postgresql/server -I/pgbin/pgpoc1d/16.x/include/postgresql/internal  -D_GNU_SOURCE -I/usr/include/libxml2   -c -o powa.o powa.c
powa.c: In function ‘compute_powa_frequency’:
powa.c:126:21: error: ‘instr_time’ {aka ‘struct instr_time’} has no member named ‘tv_sec’
time_powa_frequency.tv_sec = local_frequency / 1000; /* Seconds */
^
powa.c:127:21: error: ‘instr_time’ {aka ‘struct instr_time’} has no member named ‘tv_usec’
time_powa_frequency.tv_usec = 0;
^
make: *** [: powa.o] Error 1
I did not face this issue on any of the 12 or 14 Postgres version database clusters.
I have a remote setup with powa-archivist 4.1.4 installed on the Repository database server.
I currently monitor all 12 and 14 version DB servers.
We are starting to upgrade to 16 version.
Thanks
Hari

Hi,
Yes, this is because of a breaking change in pg16, for which the compatibility was added in commit d91b272568b212cdefbcd9f493dd932b370fa558.  This is only available for powa-archivist 4.2.x and above.
We don't maintain multiple powa major versions, so if you want to use pg16 or above you will have to update to 4.2 (or maybe 5.0 once we release it depending on your timing needs).
Note that updating the powa version shouldn't be that much of a problem, especially on a remote setup.  This can be done entirely dynamically without any db downtime, all you need to do is to install the new packages everywhere and then run an ALTER EXTENSION powa UPDATE on all the powa databases, and then restart powa-web with the new version.
For new "branch` version (e.g. 4.x.x to 5.x.x), we usually don't provide an upgrade path as there are just too many changes, but the update can still be done dynamically without any db downtime.  The difference is that you have to drop and create the powa extension everywhere.  If loosing the history is a problem, you can just install the new powa version in a new database and keep the old one around (with a dedicated powa-web pointing to it) until you reached the retention period.  At that point you can simply drop the old powa databases.


HomeAssistantType is a deprecated alias

Testing HA core 2024.5.b0 produces this error:
HomeAssistantType was used from watchman, this is a deprecated alias which will be removed in HA Core 2025.5. Use homeassistant.core.HomeAssistant instead, please report it to the author of the 'watchman' custom integration

Dears,
any idea when this will be released?
BR
Sven

+1 for a release.
thx

This repo seems to be stale. However, there is a new fork that has fixed this and released a beta: https://github.com/andreasbrett/thewatchman

@ondras12345  thx for the hint
Tried the 0.6.2 beta0 and it fixed the issue for me.
thx a lot.
Also @andreasbrett :-)

Should be fixed in 0.6.2


feat: build AMIs using Github Actions

What kind of change does this PR introduce?
Bug fix, feature, docs update, ...
What is the current behavior?
Please link any relevant issues here.
What is the new behavior?
Feel free to include screenshots if it includes visual changes.
Additional context
Add any other context or screenshots.

fails on walg build now

Suggested changes via this PR. We can build an internal image from scratch with just one set of ansible_arguments. Will just be dependent on this PR coming in first.

fails on walg build now

Resolved by the same PR above


About the pretrained model

Hi, thank you for your great work!
But I found I can't download the pretrained model with the link provided in the project, which directed me to a 404 page.

Thanks for your interest. The pretrained model will be released soon after checking the reproducibility.

You can also train the model by yourself using the existing version.

Got it, thank you!


[Bug]: History and Cookie File not working

Is there an existing issue for this?

[X] I have searched the existing issues and checked the recent builds/commits

What happened?
If I try to set the history or cookie file I get this. With older Versions i had no problem.
Steps to reproduce the problem
.
What should have happened?
.
Version where the problem happens
.
What Python version are you running this with?
3.10
What is your operating system ?
Linux
Command Line Arguments
python EdgeGPT.py --cookie-file /mnt/homeshare/edgegpt/9931

Console logs
Initializing...
Enter `alt+enter` or `escape+enter` to send a message
Traceback (most recent call last):
  File "/home/pi/test/EdgeGPT/src/EdgeGPT.py", line 391, in <module>
    main()
  File "/home/pi/test/EdgeGPT/src/EdgeGPT.py", line 387, in main
    asyncio.run(async_main(args))
  File "/usr/lib/python3.10/asyncio/runners.py", line 44, in run
    return loop.run_until_complete(main)
  File "/usr/lib/python3.10/asyncio/base_events.py", line 646, in run_until_complete
    return future.result()
  File "/home/pi/test/EdgeGPT/src/EdgeGPT.py", line 222, in async_main
    cookies = json.loads(Path.open(args.cookie_file, encoding="utf-8").read())
  File "/usr/lib/python3.10/pathlib.py", line 1119, in open
    return self._accessor.open(self, mode, buffering, encoding, errors,
AttributeError: 'str' object has no attribute '_accessor'

Additional information
No response

It failed to read the file. Cannot replicate with --cookie-file ./cookies.json

I tried it now this way:
python -m EdgeGPT.EdgeGPT --cookie-file ./cookies.json
But get the same accessor Error again. Cookie file is definetely in place.

ChatGPT figured it out

The same error with 0.10.1
If I start EdgeGPT without any options it's working.  But with any options not.


Do you have a plan to make this libary work inside a browser ?

Is your feature request related to a problem? Please describe.
No.
Describe the solution you'd like
I want to use this library in my React app, but an error cased by fast-glob says glob path is valid only in NodeJS.
I would be happy if I can have api for browser.
Describe alternatives you've considered
I can't come up with other idea.

Sorry, I have submitted on the half. I'll put more information.

Hello and thank you for your interest in this project. I am not quite sure what you are trying to do. Especially what do you mean by "an api for browser". Do you try to webpack the project and run it inside the browser? This is an interesting idea, I've also had in mind doing quite some time ago, but never really got around actually testing.
If you could share a bit more insight about what you are trying to do and maybe an example configuration or setup that would help!

I am also interested in this. For I want to build Mermaid.js alike library for both browser and Node.js. And I am considering parsing with peg.js or nearley.js. Your project is a good try.

In the browser, __dirname is not defined, maybe consider extracting the parseFile separately

I am really not sure how to proceed with this. Since the original author is no longer responding I am going to close this.


add support for string base import for document_models

Hi. Sorry for the delay.
I didn't forget about this PR. Will review it soon.

Merged.
Thank you @Mohamed-Kaizen


BSO Dwarven Blessing

Currently the dwarven blessing only accepts prayer potions as a form of charging for the boost it provides.
Adding super restores, which also provide prayer points, would make sense to also as add an option for charging.

Suggestion moved to discord: https://discord.com/channels/342983479501389826/1032668754561224734/1197652714197360721


Added uid/cid logic to measurement protocol

Using list comprehension, added a logic to accept both cid/uid to measurement protocol hits.
Also added acceptance for custom metrics, and simplified the code, instead of using lambda.

@googlebot I signed it!


Exercise 1 fails to verify

Running node v0.10.30 on Windows 7
Installed express.
Installed expressworks.
Wrote the simple program

var express = require('express')
var app = express()

app.get('/', function(req, res) {
  res.write('Hello World!')
  res.end()
})
app.listen(process.argv[2])

And when I run:
expressworks verify myprog.js
it fails with the following message
events.js:72
        throw er; // Unhandled 'error' event
              ^
Error: connect ECONNREFUSED
    at errnoException (net.js:904:11)
    at Object.afterConnect [as oncomplete] (net.js:895:19)

*. Ran the same program with a hardcoded 3000 port and invoking localhost:3000 worked from the browser and showed the "Hello World!".

@ardooe
me, too :)
$ ls
node_modules  program.js

I had the same issue as @amahfouz (I opened the above nodeschool ticket before I found this one and realized the source of the issue). Increasing the timeout resolved it for me as well, although since I'm running a pretty slow setup (under vagrant on an old MacBook), I had to set it to 4500 -- anything less timed out. :(
I also noticed that the recent refactoring from setup.js to exercise.js changed the timeout value from 1500 back to 500 -- although even 1500 would have been too short in my case.

For some reason it worked with me when I removed the ; after each script.
For example, instead of doing


OpenOCD: Fix stack alignment for cortex-m targets

Hi @masayuki2009 since you submitted NuttX support on OpenOCD some years ago, could you please review/approve: https://review.openocd.org/c/openocd/+/8180 ?

Hi @masayuki2009 since you submitted NuttX support on OpenOCD some years ago, could you please review/approve: https://review.openocd.org/c/openocd/+/8180 ?

@acassis
I added my comments to the gerrit.


Question: How to resize Kali GUI window

Is your feature request related to a problem? Please describe.
is there an option to resize the kali GUI window. I use it on a tripple monitor Setup in a Hyper-V VM an dneed to use kali for some tasks but the bar is stretching across all screens. is there an config file somewhere where i can resize it so it is  a smaller window ?

Yes there should be a way to change the size using the xlaunch utility: C:\Program Files\VcXsrv\xlaunch.exe
I am looking into it.

stale


Could not create TensorFlow Graph: Not found: ~/graphs/inception/tensorflow_inception_graph.pb

Environment info
Operating System: Ubuntu 14.04
URL: https://github.com/tensorflow/tensorflow/tree/master/tensorflow/contrib/makefile#building-on-linux
I'm following the "Building on Linux", however all commands run fine, but when I've run this following command
tensorflow/contrib/makefile/gen/bin/benchmark \  --graph=~/graphs/inception/tensorflow_inception_graph.pb
Output on terminal is as following:
I tensorflow/tools/benchmark/benchmark_model.cc:202] Graph: [~/graphs/inception/tensorflow_inception_graph.pb]  I tensorflow/tools/benchmark/benchmark_model.cc:203] Input layer: [input:0]  I tensorflow/tools/benchmark/benchmark_model.cc:204] Input shape: [1,224,224,3]  I tensorflow/tools/benchmark/benchmark_model.cc:205] Input type: [float]  I tensorflow/tools/benchmark/benchmark_model.cc:206] Output layer: [output:0]  I tensorflow/tools/benchmark/benchmark_model.cc:207] Num runs: [50]  I tensorflow/tools/benchmark/benchmark_model.cc:208] Inter-run delay (seconds): [-1.0]  I tensorflow/tools/benchmark/benchmark_model.cc:209] Num threads: [-1]  I tensorflow/tools/benchmark/benchmark_model.cc:210] Benchmark name: []  I tensorflow/tools/benchmark/benchmark_model.cc:211] Output prefix: []  I tensorflow/tools/benchmark/benchmark_model.cc:212] Show sizes: [0]  I tensorflow/tools/benchmark/benchmark_model.cc:51] Loading TensorFlow.  I tensorflow/tools/benchmark/benchmark_model.cc:58] Got config, 0 devices  E tensorflow/tools/benchmark/benchmark_model.cc:64] Could not create TensorFlow Graph: Not found: ~/graphs/inception/tensorflow_inception_graph.pb
Why at last TensorFlow Graph is not created or found at ~/graphs/inception/tensorflow_inception_graph.pb even that file is there.

Hello,
You have to download the graph and label files as a zip file from (here)[https://storage.googleapis.com/download.tensorflow.org/models/inception5h.zip] and extract the contents to ~/graphs/inception/ folder since you are using the --graph flag as --graph=~/graphs/inception/tensorflow_inception_graph.pb.

Try to do an ls -l  ~/graphs/inception/tensorflow_inception_graph.pb to see if the file is indeed there.
If so and the error still persists, try to expand "~" to the absolute path when launching the program.
Feel free to reopen if there's still issues.

@concretevitamin I've tried ls -l ~/graphs/inception/tensorflow_inception_graph.pb and found it there
-rw-r----- 1 tushar tushar 53884595 Nov 18  2015 /home/tushar/graphs/inception/tensorflow_inception_graph.pb
even I can see that file via clicking on that same folder path, but error is same.

@concretevitamin I've found it working when I've copy that graph folder to the same level at tensorflow's folder. But it was not working when my tensorflow folder on Desktop and graph folder on my home folder, idk why? but by the way now it's work!

@tusharsoni08 thanks! works for me.


Webhook doc question

Hello,
I was waiting for the webhook support PR before upgrading to version 1.3.x.
Now that the PR was merged I just want to verify that it is indeed supported since in the doc it is still stated

Note! The Coralogix terraform registry has now been updated to v1.3.x. The new version contains many breaking changes and does not support webhooks. It should be configured by following the instructions below.

So just wanted to verify it's just a doc that needs a bit of update and not something else I'm missing.
Thanks

Hey @alonz.
This is a mistake in the doc.
You can find more info about webhooks here -webhook.md
Thanks for the feedback.

We updated the docs, so I'm closing this issue.


[Refactor] improved ExerciseResource

Checklist

[x] I tested all changes and all related features with different users (student, tutor, editor, instructor, admin) on the test server https://artemistest.ase.in.tum.de.
[x] Server: I followed the coding and design guidelines.
[x] Server: I added @PreAuthorize and check the course groups for all new REST Calls (security)
[x] Server: I implemented the changes with a good performance and prevented too many database calls
[x] Server: I documented the Java code using JavaDoc style.

Motivation and Context

Description

applied new guidelines for Endpoints to ExerciseResource
Steps for Testing

YOU NEED ADMIN TO TEST ALL ENDPOINTS IN THIS CLASS!

open the list of exercises for a Course
open the assessment dashboard of any course, then the exercise assessment dashboard of any type, check the breadcrumbs
look at the upcoming exercises of all courses (admin needed)
reset an exercise (by deleting all its participations, try to do it with a programming exercise)
cleanup a programming exercise (delete all build plans)
toggle the second correction round for a programming exercise

Review Progress

Code Review

[x] Review 1
[x] Review 2

Manual Tests

[x] Test 1
[x] Test 2

Test Coverage

ExerciseResource: 94%

This PR has too many merge conflicts as of now and does not add enough value so that fixing those conflicts is efficient.


temporarily disable AuthHeader tests to stop build breaks, #533

First step in #533...

approved... just waiting on build


New Application Create Error - Cannot find module "./app.module"

Runtime Error
Cannot find module "./app.module"
Stack
Error: Cannot find module "./app.module"
at Object. (http://localhost:8100/build/main.js:41254:7)
at webpack_require (http://localhost:8100/build/main.js:20:30)
at http://localhost:8100/build/main.js:66:18
at http://localhost:8100/build/main.js:69:10
Ionic Framework: 2.1.0
Ionic Native: 2.4.1
Ionic App Scripts: 1.1.3
Angular Core: 2.2.1
Angular Compiler CLI: 2.2.1
Node: 6.9.4
OS Platform: Linux 3.10
Navigator Platform: Linux x86_64
User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/56.0.2924.87 Safari/537.36

Hello! While we appreciate you opening an issue with us i am going to close this issue and ask that you open a new one that has the issue template filled out please. Thanks for using Ionic!


batch update

Hope to add bulk updates.

Hi @shaobingme ,
Actually, I have been working on bulk insert and update operations recent times. I hope it will be completed as soon as possible.
Thanks your feedback.

Still expecting the function on bulk insert and update.


feat(#157): Started lidar mapping

Description
Map the lidar points to the front RGB image, to get the depth (distance) of segments later.
Fixes #157
Time invested
Tim Dreier: 8h (so far)
Type of change
Please delete options that are not relevant.

New feature (non-breaking change which adds functionality)

Does this PR introduce a breaking change?
No.
Most important changes
That it's possible to get the depth of any segment in a image.
Checklist:

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works (might be obsolete with CI later on)
[ ] New and existing unit tests pass locally with my changes (might be obsolete with CI later on)

Additional effort to implement Buffer node and debugging: 5 hours

The most important thing in this PR is the fork of lidar-camera (https://github.com/timdreier/lidar-camera). Since we hadn't enough time we couldn't fix all errors regarding this node.
What works: We get a PointCloud filtered by the viewport of the according camera:

The points should have the color they have in the camera image, what obviously doesn't work.
Furthermore, the node creates a depth map. Sadly, the depth map is missing some points. This could be improved by optimizing the LIDAR-Parameters to send more LIDAR points in the Viewport of the Camera. The current output is like this:

Furthermore, this PR contains a buffer node, which basically just overrides Depth-Values in the Depthmap if they are greater than a threshold (5000 in this example). The hoped to get a more consistent image by doing so. However, this could cause some problems because the depthmap may contain old values.
would be interesting to test the state things in future work!


Freeze ranges, output to custom directory, accept freeze configuration

A very rough draft that adds some functionalities to the project:

Support providing a path to a config or using user instead of the default full.
Support freezing ranges.
Open the last created page in macOS using open (this needs some refactoring)

BTW, I love freeze

Thanks for the PR! The current implementation of the :Freeze user command already supports using a range, is the advantage just that we can use Lua directly instead of relying on the user command?
As for passing a custom config, I am all for that but then it should not default to the ~/.config/freeze as this will already get picked up by freeze.  If using a custom config, I believe we should pass this as an option and only modify the execution if the option exists.
While I personally do like the addition of using a timestamp for naming files, we might want to consider refactoring this to be configurable by the user in opts rather than requiring it.
Lastly, what formatter was used when making these changes? I would like to standardize some of that for contributions.

Thanks for the PR! The current implementation of the :Freeze user command already supports using a range, is the advantage just that we can use Lua directly instead of relying on the user command?

 The first time I tested it, it didn't work for me, but I removed my code and re-tested it, and it does. So I must have done something wrong the first time I used it and got misled.

As for passing a custom config, I am all for that but then it should not default to the ~/.config/freeze as this will already get picked up by freeze. If using a custom config, I believe we should pass this as an option and only modify the execution if the option exists.

The path ~/.config/freeze is the default path to the dir where the screenshots will be stored. I changed it so that its default value is . instead.
Regarding the default config, I can't get it to use my user config by default. I might need to do something differently here though.

While I personally do like the addition of using a timestamp for naming files, we might want to consider refactoring this to be configurable by the user in opts rather than requiring it.

I've refactor this so that the dir, and output (previously prefix) are optional. Moreover, the output can work as a kind of template, where {timestamp}, {filename}, {start_line}, and {end_line} will be substituted at freeze-time.
This is my current configuration for the plugin:
local home = os.getenv("HOME")

return {
  {
    dir = "~/.config/nvim/lua/user/freeze",
    opts = {
      dir = home .. "/.config/freeze",
      config = "user",
      output = "freeze-{filename}-{start_line}_{end_line}-{timestamp}.png",
      open = true,
    },
  },
}

Oh, and for the linter I'm using stylua through conform.nvim.

I agree with both changes.
Done!


Estimate Gas

This PR implements a much cleaner and DRY way to incorporate our most common integration flow for a new chain. This does result in a change of the EVMClient interface, adding the below methods to it.
NewTx(
  fromPrivateKey *ecdsa.PrivateKey,
  nonce uint64,
  to common.Address,
  value *big.Int,
  gasEstimations GasEstimations,
) (*types.Transaction, error)
EstimateGas(callMsg ethereum.CallMsg) (GasEstimations, error)

These enable us to easily write new gas estimation methods, along with switching between Dynamic and Legacy transaction types, a common integration request.

Codecov Report

Merging #621 (fb28fee) into main (91b9d33) will increase coverage by 33.05%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           main     #621       +/-   ##
=========================================
+ Coverage      0   33.05%   +33.05%
=========================================
  Files         0        6        +6
  Lines         0      357      +357
=========================================
+ Hits          0      118      +118
- Misses        0      229      +229
- Partials      0       10       +10

see 6 files with indirect coverage changes


Functionality to write ORSO dataset from combination of several runs

Currently the Orso provider looks for the NormalizedIofQ from the workflow and produces an ORSO dataset from that.
But often we want to put several curves in one ORSO file, either stitched curves or individual curves stacked in the ORSO file.
Some things are not clear and will have to be figured out:

Does ORSO already have support for listing several reflectometry curves in the same file?
How is the metadata from different runs combined?
How is the Q-resolution from different runs combined?

It's possible that we will have to do a simple version for now and revisit this when we know more.

Let's start with putting multiple non-stitched angles measured on the same sample into one ORSO file
Some clarifications:

ORSO support for multiple datasets in a single file: https://www.reflectometry.org/advanced_and_expert_level/file_format#multiple-data-sets-1
MetadataThere are no strict indications on how to treat the metadata in the case of multiple datasets so there is flexibility. Let's start by having most information in the main header such as the identifier of each one of the multiple reduced reflectivity curves contained in the file and what they are (e.g. what sample rotation was used for each one in the case of measurements at different angles). This parameter can then be repeated as a single line header above the 4 columns of each dataset for readability
Resolution resolution is reported for each individual curve. The main reason for keeping the datasets separate is the different q resolution of the datasets in the overlapping regions which should not be combined

There is actually an explanation for how to encode metadata:

overwrite meta data
Below the separator line, metadata might be added. These overwrite the metadata supplied in > the initial main header (i.e. data set 2 does not know anything about the changes made for data set 1 but keeps any values from data set 0 (the header) which is not overwritten.

And note the example below this block that shows how multiple input files might be combined.

Thanks, I should read the links I post. In addition, there should be in the main header a short section that lists all the multiple measurements present in the dataset. Currently the main header has:
data_files:           raw data from sample
- file:           file name or identifier doi
Since these are then overwritten by the specific metadata above each dataset the main header should contain a list of identifiers of all the files present in the file.


Add PK Chunking support (Sforce-Enable-PKChunking)

This PR adds support for PK Chunking (sending the Sforce-Enable-PKChunking header) for bulk queries. Three years ago there was a similar PR which right now seems to much out of sync with the master branch to merge. Note this PR was not based on the previous PR but created from scratch.
The main changes are in the load on the bulk prototype. It works by allowing to pass an optional options-object as parameter to the query function. The two additional options that can be passed:

options.pkChunking Sets the Sforce-Enable-PKChunking to true when options.chunkSize is not passed.
options.chunkSize Sets the Sforce-Enable-PKChunking  with a chunkSize.

If you set options.chunkSize options.pkChunking is automatically set to true; they are separate options to allow for using pkChunking with the default chunk size.
In the load function we detect based on the job options if we are dealing with a chunked or a normal batch. If pkCunking is active we wait for the initial batch to get updated to state NotProcessed. Once the initial batch is NotProcessed we will retrieve the chunked batches (using job.list) and poll each batch (chunk) separately. Once all chunks in the job are completed the initial batch emits a response event which then ensures the job is cleaned up and the results are returned.
The chunks can subsequently be retrieved and made lazy using the lazy-loading feature of the mulitstream package. This prevents the streams from closing before they are even read.

closing this now that v1 is deprecated.
we suggest to use bulk v2 as it has handles pkchunking automatically, see: https://github.com/jsforce/jsforce/discussions/1433#discussioncomment-10063833


Can't find FUNCTION_NAME

I just switch mac from ubuntu, sublime with ctags on ubuntu worked very well
but on mac, I suffer a lot
I got every thing set (I think), and run "CTags: Rebuld Tags", and then generate .tags and .tags_sorted_by_file successfully.  but when I try to Navigate to Definition in  golang-code by shift + control + . I got this : Can't find **
there is some detail when I set ctags:
on shell:
$ ctags
ctags: No files specified. Try "ctags --help".
$ which ctags
/usr/local/bin/ctags

key setting in CTags.sublime-settings
 "command": "/usr/local/bin/ctags",

In golang, I want to jump to loadCachedState, sublime report "Can't find loadCachedState"
when I try to jump to JSON, it Do show something, but none was I want. I am sure there is a method named JSON
manager.loadCachedState()
.
.
.
return lu.JSON(M{"repliers": repliers})

there are all CTags.sublime-settings:
// Place your settings in the file "User/CTags.sublime-settings", which
// overrides the settings in here.
{
    // Enable debugging.
    //
    // When enabled, this will result in debug output being printed to the
    // console. This can be useful for debugging issues.
    "debug": false,

    // Enable auto-complete.
    //
    // When enabled, this turns on a basic "auto-complete" feature, similar to
    // a very rudimentary "Intellisense(TM)". This is useful for providing
    // better suggestions than stock Sublime Text could provide.
    "autocomplete": false,

    // Path to ctags executable.
    //
    // Alter this value if your ctags command is not in the PATH, or if using
    // a different version of ctags to that in the path (i.e. for OSX).
    //
    // NOTE: You *should not* place entire commands here. These commands are
    // built automatically using the values below. For example, this is OK:
    //
    //     "command": "/usr/bin/ctags"
    //
    // This, on the other hand, won't work!
    //
    //     "command": "ctags -R -f .tags --exclude=some/path"
    //
    "command": "/usr/local/bin/ctags",

    // Enable recursive searching of directories when building tag files.
    //
    // When enabled, this is equivalent to `-R` parameter. Set to true to
    // enable recursive search of directories when generating tag files.
    "recursive" : true,

    // Default read/write location of the tags file.
    //
    // This is equivalent to the `-f [FILENAME]` parameter. There is likely no
    // reason to change this unless you have a large number of existing tags
    // files you'd like to use that already have a different name. In this
    // case perhaps consider using the 'extra_tag_files' setting instead.
    "tag_file" : ".tags",

    // Additional tag files names to search.
    //
    // These are searched in addition to the file name given in 'tag_file'
    "extra_tag_files": [".gemtags", "tags"],

    // Additional options to pass to ctags.
    //
    // Any addition options you may wish to pass to the ctags executable. For
    // example:
    //
    //     ["--exclude=some/path", "--exclude=some/other/path", ...]
    "opts" : [],

    // Tag "kind"s to ignore.
    //
    // A ctags tagfile describes a number of different "kind"s, described in
    // tag FORMAT file found here:
    //
    //     http://ctags.sourceforge.net/FORMAT
    //
    // These can be filtered (i.e. ignored). For example - 'import' statements
    // should be ignored in Python. These are of kind "i", e.g.
    //
    //     "type":"^i$"
    //
    "filters": {
        "source.python": {"type":"^i$"}
    },

    // Definition "kind"s to ignore.
    //
    // This is very similar to the 'filters' option. However, this only
    // applies to the process that is used to find a definition. All filters
    // placed here will be used when the plugin is searching for a definition
    // in the file.
    "definition_filters": {
        "source.php": {"type":"^v$"}
    },

    // Enable the ctags menu in the context menus.
    "show_context_menus": true,

    // Paths to additional tag files to include in tag search.
    //
    // This is a list of items in the following format:
    //
    //     [["language", "platform"], "path"]
    //
    "extra_tag_paths": [
        [["source.python", "windows"], "C:\\Python27\\Lib\\tags"]
    ],

    // Enable highlighting of selected symbol.
    //
    // When enabled, searched symbols will be highlighted when found. This
    // can be irritating in some instances, e.g. when in Vintage mode. In
    // these cases, setting this to false will disable this highlighting.
    "select_searched_symbol": true,

    // Set to false to not open an error dialog while tags are building
    "display_rebuilding_message": true,

    // Rank Manager language syntax regex and character sets
    //
    // Ex: Python 'and' ignore exp --> '\sand\s' - it must have whitespace
    // around it so it is not part of real name: gates.Nand.evaluate()
    "language_syntax": {
        "splitters" : [".", "::", "->"],
        "source.js": {
            "member_exp": {
                "chars": "[A-Za-z0-9_$]",
                "splitters": ["\\."],
                "open": ["\\{", "\\[", "\\("],
                "close": ["\\}", "\\]" , "\\)"], //close[i] must match open[i]
                "ignore": ["&", "\\|", "\\?", ":", "\\!", "'", "=", "\""],
                "stop": ["\\s", ","],
                "this": ["this", "me", "self", "that"]
            },
            "reference_types": {
                "__symbol__(\\.call|\\.apply){0,1}\\s*?\\(": ["f", "fa"],
                "\\.fire\\s*?\\(\\s*?\\[\\'\"]__symbol__\\[\\'\"\\]": [
                    "eventHandler"
                ]
            }
        },
        "source.python": {
            //python settings inherit JavaScript, with some overrides
            "inherit": "source.js",
            "member_exp": {
                "ignore": ["\\sand\\s", "\\sor\\s", "\\snot\\s", ":", "\\!",
                           "'", "=", "\""],
                "this" : ["self"]
            }
        },
        "source.java": {
            "inherit": "source.js",
            "member_exp": {
                "this" : ["this"]
            }
        },
        "source.go": {
            "inherit": "source.js",
            "member_exp": {
                "this" : ["this"]
            }
        },
        "source.cs": {
            "inherit": "source.js",
            "member_exp": {
                "this" : ["this"]
            }
        }
    },

    // Scope Filters
    //
    // Tags file may optionally contain tagfield for the scope of the tag. For
    // example:
    //
    //   item  .\fileHelper.js   420;"   vp  lineno:420  scope:420:19-422:9
    //
    // The re is used to extract 'scope:/beginLine:beginCol-endLine:endCol/'
    //
    // Different tags generators may generate this non-standard field in
    // different formats
    "scope_re": "(\\d.*?):(\\d.*?)-(\\d.*?):(\\d.*?)"
}


Taxon concepts

includes 'taxonomy details' tab on taxa/show which includes informations managed by taxon frameworks and taxon framework relationships. Only admins can CRUD these at the moment

@kueda, @pleary gave this a once over but if you could give it a final sign off that would be great. Otherwise ready to merge


Issue forms

Doubtful if this works, let's see.
here it is. told about the issue, right? I think the first thing in the form has to be markdown.

Last 3 commits were in Gitpod, so that's why they weren't verified. That helped me realise the issues. The problem was that foolish me put atttributes: rather than attributes:. A misclick.


Create multi-extension template

As an extension developer, I want to create multiple extensions together and run them in Platform.Bible together in order to develop quickly and efficiently as well as to organize my code.
As a core developer, I want to create multiple extensions together and run them in Platform.Bible together in order to have one repository for the Paratext.Bible extensions where all my changes show up together for efficiency and organization.
We may be able to use merging subtrees to create a multi-extension template. We could have one repo that is a multi-extension template that has webpack config and such to support running multiple copies of the single extension template inside its src folder or something. There would be a bunch of extra config files in each extension folder that aren't typically used, but it would probably help merging to work more smoothly. And you could probably run each extension individually this way, too, which would be a benefit in some cases like if we made some sample extension repo that had a ton of little extensions in it.

https://discord.com/channels/1064938364597436416/1145779806684852285

This sounds more like submodules than subtrees, but I guess we'll see how it looks when someone investigates.

PRs:
Added multi-extension template based on paranext-core/extensions by tjcouch-sil · Pull Request #1 · paranext/paranext-multi-extension-template
Prep for use in multi-extension-template by tjcouch-sil · Pull Request #55 · paranext/paranext-extension-template

PRs implementing the template:
https://github.com/paranext/paranext-core/pull/693
https://github.com/paranext/paratext-bible-extensions/pull/1

Testing Steps:
Cloned the repo from https://github.com/paranext/paranext-multi-extension-template

Created 2 extensions using the steps in the ReadMe.
Added 1 stand alone extension created from Paranext-extension-template.
Confirmed that all 3 Extensions displayed web-views without any errors.
Confirmed that all extensions are started at same time , so the data provider created in 1 extension is used in another without any errors.
Confirmed that 'npm run package' is building all individual extensions in release folder.


Patch "No available addresses" CNI Plugin Issue

This commit upgrades the Azure CNI Plugin to patch a bug where the
plugin fails to free IPs when a pod is cleaned up. This will fix the
issue we are seeing with clusters running out of IPs, despite having far
fewer pods running than IPs available.
Ref: PLAT-672

LGTM, thanks


Announcing nav info when user enter ep and removing F3 shortcut to show/hide tooltip.

Navigation info announcement when user enter graph
Issue: #20778
This is pattern is very commonly used in vscode to let users know important key shortcut. I am adding the navigation information to the graph so it gets announced whenever the focus enters an execution plan.

Vscode example:

<textarea class="xterm-helper-textarea" aria-label="Terminal 2, powershell
Use Ctrl+UpArrow and Ctrl+DownArrow to navigate the terminal buffer" aria-multiline="false" autocorrect="off" autocapitalize="off" spellcheck="false" tabindex="0" style="left: 115.2px; top: 180px; width: 7.2px; height: 18px; line-height: 18px; z-index: -5;"></textarea>

Allowing users to expand/collapse button
Tooltips shown only when enter is pressed on the node. Hover based tooltips are disabled by default. This also
addressing the issue #20765. Now tooltips are only announced if the user clicks or press enter on the focused node.

Demo:

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 5 (0.0%)  changed or added relevant lines in 2 files are covered.
4 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.008%) to 41.928%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/sql/workbench/contrib/executionPlan/browser/executionPlanView.ts
0
2
0.0%

src/sql/workbench/contrib/executionPlan/browser/azdataGraphView.ts
0
3
0.0%

Files with Coverage Reduction
New Missed Lines
%

extensions/notebook/src/common/ports.ts
4
74.14%

Totals

Change from base Build<PHONE_NUMBER>:
-0.008%

Covered Lines:
28861

Relevant Lines:
63931

💛  - Coveralls


Format security note with proper highlighting

The information about security of ssh keys might benefit from standing out more. Thus included it in a caution shortcode. Formatting is now more aligned with the style guide.
Preview: https://deploy-preview-9942--kubernetes-io-master-staging.netlify.com/docs/concepts/configuration/secret/

@tvshc BTW, please check the build preview to verify that the page is rendering correctly. For example, the caution tag was not closed properly, so it looked like this:

I fixed it, so it should be ok now.

/lgtm
/approve


Add @throws annotation to send function in PendingMail and Mailer class

Fixes issue #43158.

Heya, thanks but these methods don't directly throw this exception. We only add throw annotations to methods that directly throw an exception.


Rename stringArray to strings in usage

Same reasoning as in #132.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Tree widget: Missing tooltips

Some elements seem to be missing tooltips, e.g. in the below capture "2D" and "3D" header buttons, node checkbox and expander don't show one.

https://github.com/iTwin/iTwinUI/discussions/2237


I can add a reference to a component without closing the tag - causes it to load twice.

I can make a reference to a component that I create in another component as follows:
`<app-tasklist></app-tasklist>`

However, if i do not close the tag......
`<app-tasklist><app-tasklist>`

The component is actually loaded twice if the component tag is not closed. The compiler should realise that this is a typo and give a warning. At the moment (for someone who has tried to get started with NG2 a couple of times in BETA to have a feel around), it just feels like the issue is with import statements, or a bug in the compiler and is frustrating.

If you feel it is a bug, create a plunker reproduction and post it at angular/angular. This repo is only for documentation issues.
Thanks.

My mistake @Foxandxss, sorry about that ;)


[cmake] Prevent linker errors by linking libswiftAST into SwiftBasicTests since libswiftBasic can include contents from libswiftAST.

I hit this in https://github.com/apple/swift/pull/72476. I put the declaration that hit this in a header, but as I thought about it... there was no real harm in just fixing the issue and preventing future breakage.

@swift-ci smoke test

LGTM.


Remove unused BaseSshUriProperties

I believe this class was added by mistake in merge commit 7e901a1d4f951c829a6a27a0b3618218fbf3417e. It is unused and appears to be mostly a duplicate of SshUri.

Codecov Report

Merging #777 into master will increase coverage by 0.84%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #777      +/-   ##
==========================================
+ Coverage   74.85%   75.69%   +0.84%
==========================================
  Files          82       81       -1
  Lines        2700     2670      -30
  Branches      382      382
==========================================
  Hits         2021     2021
+ Misses        519      489      -30
  Partials      160      160

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7412ec7...c86fc8f. Read the comment docs.

Hum I am unsure where that class is coming from @dsyer any ideas?

I guess Tommy is probably right (left over from a messy merge).

Thanks @dsyer.  @shakuzen can you update your branch with the latest from master and then I will merge this.  Thanks!

@ryanjbaxter Done


Issues with ESM

Jodit Version:  4.0.0-beta.89
Browser:  all
OS:  all
Is React App: False
Code: See https://github.com/julianpoemp/jodit-ts-import-bug/blob/main/src/app/app.component.ts . You can clone the repository and call npm start to run local web server.
Expected behavior:
Jodit Editor generated by ESM build should have the same functionality like that one from the other builds (e.g. es2021). For example if I set two buttons "bold" and "underline" I expect Jodit to show the buttons with icons.
Actual behavior:

For both editors the exact same configurations were set. As you can see there are three visible points missing:

Missing icons.
Missing status bar.
Missing placeholder.

Hello @xdan,
thank you for your response. I was able to inject the "stat" and "placeholder" plugins so these features are working now. Only one further question: Do Angular/react users need to import autobind-decorator? I didn't import it to my example app and Jodit still works:
import {Component, OnInit} from '@angular/core';
import {Config} from 'jodit/esm/config';
import "jodit/esm/plugins/stat/stat.js"
import "jodit/esm/plugins/placeholder/placeholder.js"
import {Jodit} from 'jodit';

@Component({
  selector: 'app-root',
  templateUrl: './app.component.html',
  styleUrls: ['./app.component.scss'],
})
export class AppComponent implements OnInit {
  ngOnInit(){
    Jodit.make('#editor', {
      width: 600,
      height: 400,
      buttons: ["bold", "underline"],
      textIcons: false
    } as Config);
  }
}

Because autobind-decorator is the only non-dev dependency and it comes with Jodit https://github.com/xdan/jodit/blob/main/package.json#L50
I've added "stat" and "placeholder" to the basic list so you don't have to include them yourself.

Still issue with v4 beta 98. I debugged it and found out, that somehow the ESM JS files from affected plugins like "bold" or "underline" are not injected. For example "bold": a breakpoint here: https://github.com/xdan/jodit/blob/f9fd995ce1d1a4febf649acc4ed0c5a158a2933e/src/plugins/bold/bold.ts#L113 does not trigger. If I do the same with "font" (which icon is visible) the breakpoint triggers. So I think bold.js is not imported correctly.
Further more it seems that Jodit can't set the icon because the name is empty ("") in makeIcon from https://github.com/xdan/jodit/blob/f9fd995ce1d1a4febf649acc4ed0c5a158a2933e/src/core/ui/icon.ts#L79
For now I debugged the ESM build itself. Perhaps I find time to dive in this repository.

the issue with missing icons for "bold" and "underline" still exists in beta 105. Perhaps there is a missing "bold" item in array here:
https://github.com/xdan/jodit/blob/73f06b6fd7888e8e9d7736e0a034a5311e247b15/tools/utils/resolve-alias-imports.ts#L59
I would have tested it myself but I didn't get an environment running that allows me to test the newly built esm version.

Hi @xdan, it works, thank you!


some phone show error：Module wifiwizard2.WifiWizard2 does not exist.

Prerequisites
Check all boxes if you have done the following:

[x] Checked that your issue isn't already filed: https://github.com/tripflex/wifiwizard2/issues
[x] Make sure you fill out the Issue Type below

Issue type
Select all that apply

[x] Bug
[ ] Enhancement
[ ] Task
[ ] Question
[ ] Other

Description
i have 5 phones，only one show error：
[INFO:CONSOLE(57)] "Uncaught SyntaxError: Block-scoped declarations (let, const, function, class) not yet supported outside strict mode", source: file:///android_asset/www/plugins/wifiwizard2/www/WifiWizard2.js (57)
I/chromium: [INFO:CONSOLE(1461)] "Uncaught Error: Module wifiwizard2.WifiWizard2 does not exist.", source: file:///android_asset/www/cordova.js (1461)
Versions
android 5.1
ionic 3

I am seeing this in android version 4.4.4 (Samsung Galaxy tablet).

Looks like it's due to this line: https://github.com/tripflex/WifiWizard2/blob/master/www/WifiWizard2.js#L56
I've forked this project and I'm currently resolving as many issues as I can - I'll let you both know once this is fixed in my fork.
(of course, I'll be submitting pull requests for everything I fix)

Hey @jack828,
Check this project: https://github.com/arsenal942/Cordova-Network-Manager
@arsenal942 accepts fast pull reqeuest

Thanks @kalicki, I'll check it out.

Dohhh!!!


iOS Autofill "hide my email" does not work

Steps to reproduce

Use provided sample code (or build a simple app with a TextField)
Run app
Tap on text field
Tap on "Hide My Email"
Create a new "Hide My Email" address (or use the existing)

Expected results
I expect the TextField to be filled with the created / selected email address.
Actual results
The TextField stays empty.
Code sample
Code sample
import 'package:flutter/cupertino.dart';
import 'package:flutter/material.dart';

void main() {
  runApp(const MyApp());
}

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    return const MaterialApp(
      title: 'Test',
      home: DetailPage(),
    );
  }
}

class DetailPage extends StatefulWidget {
  const DetailPage({super.key});

  @override
  State<DetailPage> createState() => _DetailPageState();
}

class _DetailPageState extends State<DetailPage> {
  final TextEditingController _emailController = TextEditingController();

  @override
  void dispose() {
    _emailController.dispose();
    super.dispose();
  }

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      body: SafeArea(
        child: Form(
          child: CupertinoFormSection.insetGrouped(
            header: const Text('EMAIL'),
            children: [
              CupertinoTextFormFieldRow(
                controller: _emailController,
                prefix: Icon(CupertinoIcons.mail,
                    color: CupertinoColors.label.resolveFrom(context)),
                keyboardType: TextInputType.emailAddress,
                autofillHints: const [AutofillHints.email],
              )
            ],
          ),
        ),
      ),
    );
  }
}

Flutter Doctor output
Doctor output
[✓] Flutter (Channel stable, 3.24.0, on macOS 15.0.1 24A348 darwin-arm64, locale de-DE)
    • Flutter version 3.24.0 on channel stable at /Users/dirkmika/projects/SDKs/Flutter/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 80c2e84975 (3 months ago), 2024-07-30 23:06:49 +0700
    • Engine revision b8800d88be
    • Dart version 3.5.0
    • DevTools version 2.37.2

[!] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
    • Android SDK at /Users/dirkmika/Library/Android/sdk
    ✗ cmdline-tools component is missing
      Run `path/to/sdkmanager --install "cmdline-tools;latest"`
      See https://developer.android.com/studio/command-line for more details.
    ✗ Android license status unknown.
      Run `flutter doctor --android-licenses` to accept the SDK licenses.
      See https://flutter.dev/to/macos-android-setup for more details.

[✓] Xcode - develop for iOS and macOS (Xcode 16.0)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 16A242d
    • CocoaPods version 1.15.2

[✗] Chrome - develop for the web (Cannot find Chrome executable at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome)
    ! Cannot find Chrome. Try setting CHROME_EXECUTABLE to a Chrome executable.

[✓] Android Studio (version 2023.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.7+0-17.0.7b1000.6-10550314)

[✓] VS Code (version 1.94.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.98.0

[✓] Connected device (3 available)
    • Mein 13 Pro (mobile)            • 00008110-000A34300C62801E • ios          • iOS 18.0.1 22A3370
    • macOS (desktop)                 • macos                     • darwin-arm64 • macOS 15.0.1 24A348 darwin-arm64
    • Mac Designed for iPad (desktop) • mac-designed-for-ipad     • darwin       • macOS 15.0.1 24A348 darwin-arm64

[✓] Network resources
    • All expected network resources are available.

! Doctor found issues in 2 categories.

Hi @just-doit
Unfortunately, I don't have a device that subscribe to iCloud+ to have Hide My Email feature. From my understanding, the anonymous/generated account is not auto-filled when you tap again on the fields, correct?
Can you please check this behavior on iOS native TextField?

Normally, you tap on “Hide My Email” and a sheet opens, which in my case shows that I have already generated an address for the app.
I then tap on “Continue” so that the sheet disappears again. The email address should then be inserted into the text field.
In addition to the fact that no text appears in the text field, it is also noticeable that the text field no longer has focus (the cursor has disappeared), but the keyboard is still open.
It seems the text field looses focus as soon as "Hide My Email" is selected.
See attached video:
https://github.com/user-attachments/assets/b9434c48-9a78-4c10-9517-a271deb2aafe

Thank you for the demo video. But I'm confused since you mentioned it's on a native TextField and I see the issue also appeared, right?

Sorry, I think I misunderstood you.
I thought it was about the two flutter classes CupertinoTextFormFieldRow vs TextField.
The source code says CupertinoTextFormFieldRow while for the video I used a TextField.
But you probably mean a SwiftUI TextField.
I have tested this with the following code and it works as expected:
import SwiftUI

struct ContentView: View {
    @State var text: String = ""

    var body: some View {
        TextField("EMail", text: $text)
            .textContentType(.emailAddress)
    }
}

https://github.com/user-attachments/assets/61e261b0-7742-4a60-b3d3-1b1311747fe3

Thanks for confirming this. That makes sense now. Labeling this for further investigation.