Improve error reporting for bad local_repo

Previously, a confusing error occurred remotely if the local_repo was
too big. Instead, validate the size locally and raise a meaningful
exception.
Fixes #74

Current coverage is 77.01% (diff: 20.00%)

Merging #75 into master will decrease coverage by 0.28%

@@             master        #75   diff @@
==========================================
  Files            33         33
  Lines          1013       1018     +5
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
+ Hits            783        784     +1
- Misses          230        234     +4
  Partials          0          0

Powered by Codecov. Last update 2f75095...225e053

Since codecov is complaining, there's probably a relatively simple way to test this using two test cases:

Break out the validation code into its own function (i.e., PrepareUploadDirTask._check_size(file)). Generate a dummy "zip file" full of zeros that is exactly _ZOOKEEPER_NODE_DATA_SIZE_LIMIT in size, and run it through the PrepareUploadDirTask._check_size() code. Should succeed.

Do the same with a "zip file" full of zeros that is exactly _ZOOKEEPER_NODE_DATA_SIZE_LIMIT + 1 in size. Should raise exception.

Added a test. Codecov is happy now.

@shinfan @michaelbausor Adding some extra folks to this review in case @bjwatson needs to take ownership of this PR while I am OOO.

LGTM


drivers: flash: nrf_qspi_nor: refine alignment requirements

It's not sufficient that the read size be a multiple of four bytes;
the destination address for the read must also be properly aligned.
Relates to #24122

Possibly one for a separate PR, but would it make sense to check the return code of nrfx_qspi_read before qspi_wait_for_completion?
https://github.com/NordicPlayground/fw-nrfconnect-zephyr/blob/e23d8ac48dd0e5890559d618c048132dd4b0a697/drivers/flash/nrf_qspi_nor.c#L507-L510
nrfx_qspi_read returns NRFX_ERROR_INVALID_ADDR in the case the address isn't valid. I also wonder what the behaviour would be if the read returned NRFX_ERROR_BUSY - I guess that could also result in the read getting stuck waiting for completion?

Hi @pabigot, IMO the flash read API should not put any limits on input address and read size or on output address. Only the flash write should do this.

nrfx_qspi_read returns NRFX_ERROR_INVALID_ADDR in the case the address isn't valid. I also wonder what the behaviour would be if the read returned NRFX_ERROR_BUSY - I guess that could also result in the read getting stuck waiting for completion?

Yes, that's probably the underlying cause of the behavior you see.  It's a pervasive error throughout this driver.  @kamlaz do you want to fix this or should I?

Hi @pabigot, IMO the flash read API should not put any limits on input address and read size or on output address. Only the flash write should do this.

The existing API documents potential read alignment requirements for offset and size, and does not document any alignment requirements for write.  I would expect both to be the same, and to include  buffer alignment requirements.

Closing this as not the right fix: the real problem is #24144, and the misalignment that revealed it is fixed by #24146.


explore testing with ember-mocha

so far successfully testing mocha, chai and sinon on the ember-mocha branch, need to set up chai-sinon and chai-as-promised

ported all to mocha


Ansible user in hosts files

Make sure we have the same ansible user in hosts files.

proposed steps , to be discussed

ssh as unprivileged user
then in the playbook use become: True for tasks that require elevated permissions like installing. Maybe also add become_user: root to help being explicit about what user you're becoming.
add --ask-become-pass to ansible-playbook command line for playbooks that require root permissions

We will work on  "add --ask-become-pass to ansible-playbook command line for playbooks that require root permissions" but not on the other two. We will leave them for when there is time for it.


grafana: 6.3.2 -> 6.3.3

Motivation for this change
Patch release with bug fixes.
Things done
Updated meta.homepage to use the correct url.

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS (x86_64-linux & aarch64-linux)
[ ] macOS
[ ] other Linux distributions

[x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Notify maintainers
cc @

@GrahamcOfBorg test grafana

backported in 6c1ff5ad9e4d356a1cf96dc36719a5866c0aaa50


Blank ids when parsing style in SSR

emotion version: 5.1.0
react version: 15.6.1

Relevant code.
import { extractCritical } from "emotion/server"
const { html, ids, css } = extractCritical(<App />)

assert.deepEqual(ids, []) // true

What you did:
SSR rendering follows docs
What happened:
blank ids

Reproduction:
Problem description:
Suggested solution:
As I can see in snapshot test of server.js, ids is blank too https://github.com/tkh44/emotion/blob/633cf73e4fbdf266ae5e614289faf5abe16a66bf/test/snapshots/server.test.js.snap#L26

Closed by #89.

@thangngoc89 released in 5.1.1
Thanks @mitchellhamilton


[BUG] CN nodes can not release query_pool Fragment memory

Steps to reproduce the behavior (Required)

Use Stream Load to write data until the disk is full
Drop table（clear disk）
recreate table
query_pool holds the timeout Fragment and does not release the memory
There is also a Prometheus exporter in my cluster that has been grabbing indicators and will query the tables under the information_schema database.

 Looking at the code from the log, it is confirmed that the cancel method in the plan_fragment_executor class is being executed. What I currently suspect is that [result_mgr()->cancel(_runtime_state->fragment_instance_id())](https://github.com/StarRocks/starrocks/blob/3.3.2/be/src/runtime/plan_fragment_executor.cpp#L403) has not completed the cleanup action.
I tried to capture the thread stack to take a look, but no exception was found, because cancel_worker sleeps for 1 second after each cleanup, and the captured thread stack is in sleep
Expected behavior (Required)
query_pool release Fragment memory when timeout
Real behavior (Required)
cancel worker always try to clean Fragment memory, but does not works well
StarRocks version (Required)

3.3.2
I have added a function built into the CN code in the current version, but this function is not currently used so it should not cause this problem.

Please see the attachment for the pstack of the CN node.
cn00.txt


OHIF-20: Study List Header

Description
Create a component with basic structure of header
Specs requested

Developed screenshot

Missing pieces to be coded in other PR

OHIF Logo (and text) svgs
Settings config actions (dropdown and modals)

I've noticed that the cog Icon for settings is a little cut-off:

Its slice box in Zeplin seems to be wrong. Just to keep in mind that we're gonna need to update that -- asking Dan to update the icon.

@dannyrb
Approved by Rodrigao.
Cna you take a look Danny?


Increasing max_features performance

I realized that setting max_features parameter does not change the running time, which I would expect it faster since we directly say the maximum number of features. I checked the code and saw that we return the number of features after calculated the total number of features.
In this case, I think new_features should be calculated according to max_features parameters, so we do not have to wait for the entire calculation.
https://github.com/Featuretools/featuretools/blob/68db36108a5deffaaed267668d5ac90291ec2b84/featuretools/synthesis/deep_feature_synthesis.py#L269

You are right that we still generate all the feature definitions. However, setting max_features will reduce the number of feature definitions returned by DFS resulting in fewer actual feature calculations to happen. The bottleneck is usually the calculation of the actual feature values, not the feature definitions, so this a helpful parameter to decrease overall runtime.

Closing this for now.  If anyone is able to share a specific use case where the slowdown is significant, we'd love to look into it more.


Passing Arguments to libtor

I have found a way of passing a bridge to the tor client; however, I still need more customization. I did that by setting a .torrc file in /data/user/0/com.<app>/cache/sifir_sdk/tor. I see that tor starts with
libtor: Starting tor with args: [
12-23 14:24:20.129 30063 30341 D sifir-rs-sdk:     "tor",
12-23 14:24:20.129 30063 30341 D sifir-rs-sdk:     "DataDirectory",
12-23 14:24:20.129 30063 30341 D sifir-rs-sdk:     "/data/user/0/com.test10/cache/sifir_sdk/tor/data",
12-23 14:24:20.129 30063 30341 D sifir-rs-sdk:     "CacheDirectory",
12-23 14:24:20.129 30063 30341 D sifir-rs-sdk:     "/data/user/0/com.test10/cache/sifir_sdk/tor/cache",
12-23 14:24:20.129 30063 30341 D sifir-rs-sdk:     "SocksPort",
12-23 14:24:20.129 30063 30341 D sifir-rs-sdk:     "44209",
12-23 14:24:20.129 30063 30341 D sifir-rs-sdk:     "ControlPort",
12-23 14:24:20.129 30063 30341 D sifir-rs-sdk:     "auto",
12-23 14:24:20.129 30063 30341 D sifir-rs-sdk:     "CookieAuthentication",
12-23 14:24:20.129 30063 30341 D sifir-rs-sdk:     "1",
12-23 14:24:20.129 30063 30341 D sifir-rs-sdk:     "ControlPortWriteToFile",
12-23 14:24:20.129 30063 30341 D sifir-rs-sdk:     "/data/user/0/com.test10/cache/sifir_sdk/tor/ctl.info",
12-23 14:24:20.129 30063 30341 D sifir-rs-sdk:     "ControlPortFileGroupReadable",
12-23 14:24:20.129 30063 30341 D sifir-rs-sdk:     "1",
12-23 14:24:20.129 30063 30341 D sifir-rs-sdk:     "TruncateLogFile",
12-23 14:24:20.129 30063 30341 D sifir-rs-sdk:     "1",
12-23 14:24:20.129 30063 30341 D sifir-rs-sdk:     "Log",
12-23 14:24:20.129 30063 30341 D sifir-rs-sdk:     "info file /data/user/0/com.test10/cache/sifir_sdk/tor/logs/sifir_tor_log.info",
12-23 14:24:20.129 30063 30341 D sifir-rs-sdk:     "Log",
12-23 14:24:20.129 30063 30341 D sifir-rs-sdk:     "err file /data/user/0/com.test10/cache/sifir_sdk/tor/logs/sifir_tor_log.err",
12-23 14:24:20.129 30063 30341 D sifir-rs-sdk: ]

However, I do not know the API for passing custom arguments. Knowing how to do that would be really helpful.
Thanks for your attention.

Hey @Oct4Pie , that's actually a nice feature to have.
So would the ability to pass a .torrc file to the module be good enough ? Or do you need to pass specific arguments to libtor ?
Right now initialization arguments (TorServiceParam) are limited to what is needed to get it going, but can be augmented.
Let me know

Thanks for your response, @gabidi. I think both would be great. I think a .torrc file would be cleaner for setting multiple configurations. I only could get .torrc to work on android because iOS does not support environment variables.


deselect selected item

Steps to reproduce

Select any item(s)
Try to delect it to have all items in overview lvl

Expected behavior

If I click on a selected element I would expect it to be deselected

Is this still an important feature for the paper release?

No. I've marked this as post-submission.

This is standard behaviour in Excel and other tools and therefore keep it as it is now.


Update snapshots to only compare against the elements and not the bloated objects

Summary
Update snapshots to only compare against the elements and not the bloated objects by calling wrapper.getElement() when saving/comparing snapshots.  This makes the snapshots more readable and comparable by seeing the elements we truly care.
Ticket Link
none

@saturninoabril can you create a ticket for this one please

Ticket created - https://mattermost.atlassian.net/browse/MM-12258

@saturninoabril Can you fix the conflicts? Lets get this merged soon so we can change existing PR test cases to this format


Why isn't there a resend email confirmation?

I've copied the above tutorial exactly, using a brand new app. I got all the way to "Register, Confirm Email and Reset Password" and "Test Password Rest". Everything worked one single time. Sent the confirmation email one single time. I cleared the database of the identity user to start all the way over by using a new database entirely and scaffolding out the identity migrations again. Since then, no emails will send out. I step through code and everything hits and executes. I created a console application and the SendGrid API key works, that app is sending out any emails to the same address. But I can't further test the real app without clearing the database as I have a bunch of my email accounts that are "awaiting response" from the confirm email and the site provides no way to resend a confirmation. I can't password reset or I get no email from trying the password reset.
Why isn't there a resend email confirmation?
I was using Visual Studio Code to do all of this. Decided to load up in Visual Studio and registered one more new email address I had to test. The page came up stating that this app doesn't have an email service to click here to confirm, which is the page that comes up before registering an email service. Yet it does have the email service, stepping through startup shows all configuration secrets pulled, email service added, yet it's not picked up in the pipeline. Launch the app using Visual Studio Code and I get an entirely different result. The email service is picked up as registered.
So Idk what I'm trying to explain here is that this process seems very faulty, very hit or miss, very unstable. Possibly even slightly unfinished in that a user can't resend confirmation emails which is odd.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: fe1bea60-d173-f6d2-3559-b147699e295a
Version Independent ID: 98e7aacb-2a01-d581-9b03-bfef2893163e
Content: Account confirmation and password recovery in ASP.NET Core
Content Source: aspnetcore/security/authentication/accconfirm.md
Product: aspnet-core
Technology: aspnetcore-security
GitHub Login: @Rick-Anderson
Microsoft Alias: riande

@Rick-Anderson Just to update. I've used multiple mail accounts. Specifically multiple Hotmail accounts. So far Hotmail will only receive email once from SendGrid.
Also there's a new issue. I'm using Azure Key Vault now to get authentication and since then it looks like services.Configure<AuthMessageSenderOptions>(Configuration); presents all null values. Would you have a suggestion what I could do or if/where I should make a new thread about this?

@DanJ210  I've seen the problem with hotmail and some Yahoo and Gmail accounts. Most of my test GMAIL accounts work fine.

where I should make a new thread about this?

Try StackOverflow and post the link here

@Rick-Anderson it’s only hotmail accounts for me. Gmail receives each time.
Would I also post about the startup configuration which is in the documentation tutorial above? It works just seems to stop working when using the key vault which you’re recommended to use in production on azure.
Is this something stack can answer? Or would I need dotnet core to look into if they support key vault?

Just stay you're using the startup configuration which is in the documentation tutorial

Alright will do, thank you for the work and direction @Rick-Anderson


Icon for Voronoi diagram effect

Made by myself using free software.
It doesn't need to be the final one, but I thought it would be good to have some depiction of the effect at least.
As for the licensing, I don't know what license to use. I'm certainly happy to give the icon away, but I think it would have to be explained in the README file? I guess that the project's MIT license applies to its own home-grown icons automatically, just like it does in the case of code files, but I would have to confirm that.

Looks fine to me 👍
For the licensing question, I think the MIT license would apply by default unless otherwise specified, e.g. as in Pinta.Resources/icons/hicolor/scalable/readme.md where many icons come from third-party icon sets. I think the About dialog also lists such cases

I see. I added some clarification (that some icons come from 'Pinta contributors') in the readme file and the 'about' dialog. Also, in the last commit I added file with the list of such icons. If that works licensing-wise, I'd say this PR is ready

That looks fine to me 👍


Dynamic group auth cannot share a field with an index

Before opening, please confirm:

[x] I have installed the latest version of the Amplify CLI (see above), and confirmed that the issue still persists.
[X] I have searched for duplicate or closed issues.
[X] I have read the guide for submitting bug reports.
[X] I have done my best to include a minimal, self-contained set of instructions for consistently reproducing the issue.
[X] I have removed any sensitive information from my code snippets and submission.

How did you install the Amplify CLI?
npm i -g @aws-amplify/cli
If applicable, what version of Node.js are you using?
14.19.1
Amplify CLI Version
7.6.26
What operating system are you using?
Windows 11
Did you make any manual changes to the cloud resources managed by Amplify? Please describe the changes made.
No manual changes as far as I know.
Amplify Categories
api
Amplify Commands
codegen, publish, push
Describe the bug
Given a simple tenant/user authorization based workflow with AWS Cognito, consider the following schema:
type Todo
@model
@auth(rules: [{allow: groups, groupsField: "tenant", operations: [create, read, update, delete]}])
{
  id: ID!
  tenant: ID! @index(name: "todosByTenant", sortKeyFields: ["title"], queryField: "todosByTenant")
  title: String!
  body: String!
}

Both amplify api gql-compile and amplify codegen work fine. A subsequent amplify push also works. The Todo table gets created with the proper secondary index. However, when querying the todosByTenant index, authorization forever fails. This is what my query looks like:
query GetTodos {
  todosByTenant(tenant: "my-tenant") {
    items {
      id
    }
  }
}

The query errors out with the following response message: "Not Authorized to access todosByTenant on type ModelTodoConnection". I have found that a workaround is to write the schema like this:
type Todo
@model
@auth(rules: [{allow: groups, groupsField: "tenant", operations: [create, read, update, delete]}])
{
  id: ID!
  tenant: ID!
  tenantName: String! @index(name: "todosByTenant", sortKeyFields: ["name"], queryField: "todosByTenant")
  title: String!
  body: String!
}

Only when the schema is written like this does the same query above return the Todos associated with my tenant. This was not an issue with GraphQL Transformer V1. The issue also occurs if the groupsField for the @auth directive is the primary key of the table. Is this behavior expected? In case you're wondering, the reason we don't just use the listTodos query is because, if the table is large enough with sparse tenants, we may have to paginate through multiple empty responses in order to get at least one item back from the table.
Expected behavior
Querying by the todosByTenant index in the first schema example shown in the bug description does not cause an unauthorized error. It should return the todos associated with that tenant.
Reproduction steps

Start a new Amplify project.
Add some basic Cognito auth to said project.
Create a GraphQL API for the project.
Place the first example schema in the bug description into your schema.
Push all changes to the cloud.
Attempt to query by the todosByTenant index.

GraphQL schema(s)
type Todo
@model
@auth(rules: [{allow: groups, groupsField: "tenant", operations: [create, read, update, delete]}])
{
  id: ID!
  tenant: ID! @index(name: "todosByTenant", sortKeyFields: ["title"], queryField: "todosByTenant")
  title: String!
  body: String!
}

Log output
Not Authorized to access todosByTenant on type ModelTodoConnection

Additional information
Each Cognito user has a custom field called custom:tenant which specifies what tenant to which the user pertains. With this, we also have a pre token generation lambda function integrated into Cognito which will place this tenant and the user's role into the cognito groups portion of the access token. The payload of the JWT token that is passed along to Appsync calls is decoded like so (with some redactions):
{
  "cognito:groups": [
    "my-tenant",
    "Admin"
  ],
  "username": "my-username",
  "exp":<PHONE_NUMBER>,
  // ...other JWT token fields
}

I can confirm that this issue persists with Amplify 8.0.1.
This also seems to be a workaround (although it's an obvious security risk since it allows any signed-in user to read the data)
  @auth(
    rules: [
      { allow: private, operations: [read] }
      {
        allow: groups
        groupsField: "tenant"
        operations: [create, update, delete]
      }
    ]
  ) {

This is a serious bug since having an index on a tenant ID field that's also used for @auth rules seems like a very common use case.

Hello @ChapterSevenSeeds, Thank you for reaching out. Apologies for the delay in a response. I was able to replicate the error in my Amplify application and confirmed the workaround as well. But I noticed that the sortKeyFields uses name field which is a unknown property. I modified the query to use title as sortKeyFields and deployed the API.
I tested the API for Mutation and list queries as well and observed the todosByTenant throws Not Authorized to access todosByTenant on type ModelTodoConnection error.
Marking this as bug.

Just wanted to jump in here and confirm that I have faced this too. It took a while to debug but the only difference was that one of my dynamic groups grouFields was referencing @primaryKey and the other referencing an indexed value.
My solution was to create a duplicate index-free field that the group value is copied into with a lambda trigger and this is what is referenced for dynamic grouping.
Was very frustrating, but ultimately figured it out by looking at the VTL which was way more complicated than the ones not referencing an index.


Properly Detect Hashlib Algorithms Available [Python3]

Describe what you expected to happen.

All algorithms available to actually be pulled

If possible, include a minimal, complete, and verifiable example to help us identify the issue. This also helps check that the issue is not with your own code.

https://github.com/pallets/werkzeug/blob/master/werkzeug/security.py#L36 currently uses
algos = getattr(hashlib, 'algorithms', None)

which is None
This should instead be change to:
algos = getattr(hashlib, 'algorithms_available', None)

as verified in https://docs.python.org/3/library/hashlib.html#hashlib.algorithms_available

Describe what actually happened. Include the full traceback if there was an exception.

algos = getattr(hashlib, 'algorithms', None)
print(type(algos))
<class 'NoneType'>

List your Python and Werkzeug versions. If possible, check if this issue is already fixed in the repository.

Python version: Python 3.5.3 (default, Jan 19 2017, 14:11:04) [GCC 6.3.0 20170118] on linux
Wekzeug version: 0.13
Thank you!

#1226 has been created for this.

Close it via https://github.com/pallets/werkzeug/pull/1282


Extend SimpleOptimizer to Support Equi-Join Queries

Our current query planner is hardcoded by @jarulraj  to generate plans for the only join query in TPC-C:
https://github.com/cmu-db/peloton/blob/master/src/optimizer/simple_optimizer.cpp#L627
You can see what this particular query looks like here:
https://github.com/oltpbenchmark/oltpbench/blob/master/src/com/oltpbenchmark/benchmarks/tpcc/procedures/StockLevel.java#L38
We want to extend code this to be able to work with any two table equi-join query. We are going to ignore computing an optimal join order for now and just get the predicates correct. The basic idea is that you are going to look for equality predicates where one of the operands is from one table and the other operand is from another table:
SELECT * FROM A JOIN B ON A.id = B.id
SELECT * FROM A, B WHERE A.id = B.id

You can just default to use the hash-join operator.

Got the issue, not working on it

Got the issue, now working on it

I'm assuming that you meant that you are "now" working on it. You two guys should work together on this. Feel free to talk with @malin1993ml on your ideas on how to fix this.

Yeah sorry that was a typo... I've been trying to get a general idea of the system and that optimizer part for the past day. I'll reach out to Lin as soon as I feel prepared with knowledge about that part. Probably later tomorrow. Thanks!

You should work with @iwantcombo on this first task. The two of you should look at it together.

Got it, I'll reach out to him. Thanks!

Let's meet up sometime.

Not sure where folks are with addressing this issue but it might be a good idea to clean up the SELECT case statement while tackling this issue, it is a bit long (300+ lines of code) with multiple if-then-else statements spanning the case. It hurts the readability of the code.

I think this issue can be closed now. Both optimizer and LLVM supports this type of join

@luochenUmich Thanks!


Add functionality to download all playlists of a user

[I did a search on web and issue but found nothing. If it's duplicated, feel free to help me close it]
youtube-dl is very good at downloading videos, but I really want to see a feature that it downloads all the playlists' information of a user.
Say a user has ten playlists, I want an action to download the playlists along with its corresponding information and save them as json or some other format. In this way, I can do other manipulations of the videos downloaded (like link them to different folders each for a playlist).
Like the following or even more info about the videos:
{
"screenjunkies":{
"PLFWHlH4koGZDABLg4i81lswPJPHqLdKj7":[
"https://www.youtube.com/watch?v=jSkVUBvpQIQ&index=1&list=PLFWHlH4koGZDABLg4i81lswPJPHqLdKj7",
"https://www.youtube.com/watch?v=DCvFUE6dNnA&index=2&list=PLFWHlH4koGZDABLg4i81lswPJPHqLdKj7",
...
]
}
}

Sorry, took another look and found one similar.


Performance of "Hash File with SHA-256" with very large files (out of memory)

When trying to obtain a hash on a very large file (e.g. 1.5 GB), LabVIEW aborts execution with an out of memory error. This is because "Hash File with SHA-256" first loads the entire file into memory, converts the string data into a bytes array, and then calculates the hash by iterating over the bytes array. This approach uses a lot of memory for large files.  In such cases, it is preferred to have the hashing algorithm take a stream input or iterate over the file itself.
Note that LabVIEW's built-in MD5 hash (shown below) works by iterating over the file in chunks.

Compare this with how "Hash File with SHA-256" reads the entire file into memory, up front.

Latest version reads the file in in adjustable sized blocks and calculates on the resulting stream of chunks thus avoiding running out of memory. Unfortunately it's not yet working for large files - probably some issue with 32bit/64bit integers
university_of_leeds_lib_sha256-<IP_ADDRESS>.vip.zip

Eventually tracked down an issue with Preallocated BufferRead from Binary File node when using buffers bigger than 1Mb. Basically if you use a buffer bigger than 1Mb you must not try and read past the end of the file otherwise you lose the last buffer. Buffers<=1Mb don't havew a problem with reading past the end of the file.
There's a new release with attached SHA256 package.

Thanks!
On Sat, Apr 11, 2020 at 8:54 AM Gavin Burnell<EMAIL_ADDRESS>wrote:

Closed #2 https://github.com/gb119/LabVIEW-Bits/issues/2.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/gb119/LabVIEW-Bits/issues/2#event-3224201084, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAC5D6CITN7Y6DR6OCNJ76LRMCHEBANCNFSM4LPRDIIQ
.

--
Jim Sent from my mobile.


As rule binding could be null, we need to make sure to check that before checking for errors/warning

…fore checking for any error/warnings.

✅ No public API change.


Set up initial package

Related to cal-itp/benefits#141 and cal-itp/eligibility-server#38
This PR sets up a Python package that contains code extracted from cal-itp/benefits and cal-itp/eligibility-server.
Work done

Added pyproject.toml and setup.cfg to make it installable as a package using pip
Copied eligibility/api.py from benefits

Made necessary changes to method signatures, and removed internal dependency on Django models

Copied functions from verify.py from eligibility-server

Made necessary changes to method signatures

Left implementations untouched

Looks great!
One thing: You should make a GitHub Issue for just this part of the implementation so we can track it on the Benefits project board.


Highlight Imminent Decay

I suggested this a week and a half ago in a comment in a separate issue, but since then the area I help control has increased by several dozen portals so I need this plugin now since I simply don't have the xm to recharge everything.
Basically the idea is to highlight with red every portal that has at least one resonator equal to or under 15% (i.e. will decay completely within 24 hours), highlight with orange portals with at least one resonator at or below 30%, and highlight with yellow portals with at least one resonator at or below 45%. This would be a significantly different function than the highlight portals that need recharge highlighter.

This plug is implemented and this issue can probably be marked closed.


Update pci-req10.md

Changed "etc." to "and so on" under 10.1, 10.2, 10.5, 10.6, 10.6.1,
Changed the typo "syncronization" to "synchronization" instead, under 10.4, 10.4.1, 10.4.2, and 10.4.3.
Added "the"

@EdPrice-MSFT,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/compliance/pci-req10.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Update access_control to OpenSSL 1.1.1 HMAC API

This updates the cryptoMessageDigestGet implementation for OpenSSL 1.1.1 and removes the unused outLen parameter.

Waiting to rebase this on #11466.

The HAVE_HMAC_CTX_NEW define can't be removed yet because the s3_auth plugin also uses it. After that plugin is updated it can be removed.

We may actually want to keep outlen. Although HMAC() is available on OpenSSL 3.x, we will want to use EVP_Q_mac() instead to use LIBCTX.

HMAC() uses the default OSSL_LIB_CTX. Use EVP_Q_mac(3) instead if a library context is required.

And EVP_Q_mac receives outsize.
unsigned char *EVP_Q_mac(OSSL_LIB_CTX *libctx, const char *name, const char *propq,
                         const char *subalg, const OSSL_PARAM *params,
                         const void *key, size_t keylen,
                         const unsigned char *data, size_t datalen,
                         unsigned char *out, size_t outsize, size_t *outlen);

Good foresight. Thanks for pointing this out, @maskit. I won't take this out of draft until I've put the parameter back.


fix thumbnails too small in case of long list

Add a minimum height for thumbnail list, as the user can select an image in case of a long list of studies (adding a minimum height to interact)
discussed at #2798  (made a cleaner PR with the current v3 stable branch). (#2798 can be closed)
Probably also @sedghi for review

alerdy solved


Fix spree routes

Issue: https://github.com/solidusio/solidus_auth_devise/issues/100
This PR brings the solution mentioned on that issue

@tvdeyen done, I removed the unnecessary changes, let me know if need any other change


Plan docs

Is there an example of how these might be displayed? Or is this just for forge work?

You can run strings in the canary module to see the pages it generates or run it with --format json to see raw data.

CLA signed by all contributors.


href javascript dunc

on clicking of href, i have, href="javascript:showDocs();",  is not working as on clicking the link, as it just change jstree-clicked.
Kindly Assist.

It is all in the docs - the section is called interacting with the tree. You have to use the changed.jstree event.

Hi Vakata,
Thanks for help, this function call worked, but getting issue in getting value of id of li, though methodcall showDocs(this).
Kindly Help

Again - read the docs on the changed.jstree event available on jstree.com


tests: workaround for the nsswitch and sysusers race condition

fixes https://github.com/coreos/fleet/issues/1441
workarounds https://github.com/coreos/bugs/issues/1161
Don't merge this PR. We will just wait until https://github.com/coreos/init/pull/192 is merged.

yet another bug found.
===========================================================
Functional test summary
===========================================================
# TOTAL: 17
# PASS: 16
# FAIL: 1

but semaphoreci marked build as passed.

Exit code fixed by this PR https://github.com/coreos/fleet/pull/1482


Chromium does not start with grsec

Issue description
I just read through #17460 and feel like we have gone through this before but when I start chromium using a grsec kernel, I get the following:
[6050:6050:1118/222352:FATAL:setuid_sandbox_host.cc(157)] The SUID sandbox helper binary was found, but is not configured correctly. Rather than run without sandboxing I'm aborting now. You need to make sure that /nix/store/a1i5ri2lpj0cbx5jv81mn8l79q4vbbsm-chromium-54.0.2840.100-sandbox/bin/__chromium-suid-sandbox is owned by root and has mode 4755.
#0 0x000c1b36801e <unknown>
#1 0x000c1b37fe9e <unknown>
#2 0x000c1c4e6e46 <unknown>
#3 0x000c19ffc885 <unknown>
#4 0x000c19ffb844 <unknown>
#5 0x000c19ffbe2e <unknown>
#6 0x000c19ca5e05 <unknown>
#7 0x000c19ca9841 <unknown>
#8 0x000c19ca1294 <unknown>
#9 0x000c1af7c53d <unknown>
#10 0x000c1af7b811 <unknown>
#11 0x000c19a7e10a <unknown>
#12 0x0355ca9c02e0 __libc_start_main
#13 0x000c19a7dfaa <unknown>

[1]    6050 abort      chromium

Note that the chmod is 555
ls -la  /nix/store/a1i5ri2lpj0cbx5jv81mn8l79q4vbbsm-chromium-54.0.2840.100-sandbox/bin/__chromium-suid-sandbox
-r-xr-xr-x 4 root root 22752 Dec 31  1969 /nix/store/a1i5ri2lpj0cbx5jv81mn8l79q4vbbsm-chromium-54.0.2840.100-sandbox/bin/__chromium-suid-sandbox

Steps to reproduce

Run grsec kernel, grsec module enabled
nix-env -i chromium
chromium

Technical details

System: 17.03.git.775a729 (Gorilla)
Nix version: nix-env (Nix) 1.11.4
Nixpkgs version: "17.03pre95730.ba73dbb"

/cc @joachifm @obadz

The suid helper in the store doesn't work. See https://nixos.org/nixos/manual/index.html#sec-grsec-issues

That was indeed it. Thank you!


v=spf1 must have a space. Proper handling of a and mx modifier

Proper handling of a and mx modifiers to cover cases like this :a a:gnu.org a:google.com/24
Discard CNAME form lookups
printip adds CDIR net mask
Search for "v=spv1 " ( with space) at the beginning of the record for RFC compliance.

Nice, thanks! One thing, can we please either keep the indent at 2 spaces or change it everywhere to what is in contributed function getamx?
Very good and I am glad someone is looking at it!
Thanks!

Should be with the 2 spaces.

@jcbf see https://github.com/jsarenik/spf-tools/tree/jasan/jcbf and pull to your PR if you like it. Thanks!

Or maybe it's too much turn-around so if you don't reply I will merge it from the https://github.com/jsarenik/spf-tools/tree/jasan/jcbf (which includes you as the first commit author).

Ah, you were quick - and I did not read the replies, sorry :-)


HAWQ-259. YARN mode resource manager gets YARN cluster report once be…

The GRM cluster report is triggered only when there is at least one segment registered through FTS heart-beat.
To handle the case, no segment is started in YARN mode, guc hawq_rm_nocluster_timeout is introduced, if when resource manager has waited for the possible segment registeration more than hawq_rm_nocluster_timeout seconds, the resource requests are rejected due to no enough available segment.

looks good to me

The fix looks good. +1


[WIP] feat: support npm11

fixes #1245

demo data: https://github.com/CycloneDX/cyclonedx-node-npm/actions/runs/12481816358


Add revision support for tweaks

As stated in the README, this project is no longer maintained and has been retired. Because of this, I am archiving this repository and closing all issues and pull requests. Thanks very much for your support and contributions!


[feature request]provide OTA and Auto upgrade model for static pod

What would you like to be added:
As we discussed in proposal: https://github.com/openyurtio/openyurt/pull/1065, make a issue to track this work.
Why is this needed:
please reference the proposal link: detail info
others
/kind feature

/assign @xavier-hou


[Bug]: Favicon logo is designed in wrong shape 🪲

Description

The OS-CODE favicon have been designed in a wrong shape, so that the browser title bar not looks good.
The entire OS-CODE site only uses the logo as rounded, but the logo is not rounded in shape it's square in shape by default.
So i manually edited the Logo and cropped it's corners and converted its square shape to rounded shape.
After converting the logo shape we can use it anywhere on the website without any problem

Expected Behavior

The Favicon should be in round in shape to match the site's theme

Show us the trouble with screenshots

BEFORE

AFTER

Which browsers are affected?
Firefox
Which OS are affected?
linux
Enter the version of your web browser
114.54
Device?
Desktop
Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSoC'23 contributor
[X] I want to work on this issue

Hey there @Vaishnavi-Patil2211, @akshathar-navada 👋🏻
Please make sure to assign this issue to me and merge the above linked PR ☝🏻
Thank you!


Added class and decorator to warn users if plan is not iterated over

Adds a decorator to be used on plans that warns users if the yield from statement is not used
Motivation and Context
Fixes #1632
How Has This Been Tested?
Tested locally using the example described in the issue

Can also add tests to this PR (or a separate one) and apply the decorator to built in plans if that is the intention

Might as well do it all in one go unless you think there is enough work to be done in the decoration that you want to split it up.

We can imagine use cases for this decorator beyond just ensuring iteration. For example, providing a nice repr. This and other possibilities (which I'm not necessarily still in favor of...) were discussed back in 2019. To pave the way for broader uses cases for this decorator, let's give it a more generic name.
Per discussion, there was rough consensus to rename the class to Plan and decorator to @plan. @danielballan, @callumforrester, @coretl, @abbiemery in favor; @tacaswell willing to go with it. :-D

For example, the bluesky user wants to learn what plans are available (such as apstools.utils.listplans()).  This decorator could be used to make that discovery process much easier and better informed.  The current assumption is far too general:
        if inspect.isgeneratorfunction(obj):  # TODO: bluesky.isplan(obj)

Sorry I wasn't able to attend the discussion. But I changed the class to Plan and decorator to @plan. If someone wants to take a look at it

bluesky/utils/__init__.py is approaching 2,000 lines with dozens of classes and functions at the module level.  Does anyone else believe it is time to refactor this file into its component modules?  Good fodder for the Hackathon.


Add [M3 MPNST] to [modelSystemName]

List the new value
Value: M3 MPNST
Provide definition and source for the new value
This is a cell line. Need to ask whether there's a more accurate name/reference.

resolved in  #179


Description of Model

Wonderful work!
I have one question when I look into your readme.
The difference of durian between fastspeech is its autoregressive structure, which lets durian can generate better wav. It use previous output as input of current step. However, in the picture of baseline model, it is different from description of paper.

Besides, I think it is important to generate r steps of mel spectrogram at once (refer paper of tacotron), which is also difficulty when implementing durian. I hope you can implement this part.
Thank you!

Yeah, you're right. My baseline model doesn't take into account any info about previous steps. So, that's why it is baseline :) However, for paper-based version, which is also implemented here and also reported in README, self-conditioning decoder is provided - I wrote it in key differences for "vanilla version". I've done baseline just for testing. I guess I just need to remove it to not make others got confused. What about several steps generation at one time - yes, it is a good idea and I think it can be easily added to current implementation in the near future, I will mark it.


[Yam] Add an error detection and update test cases

The original test case _1 does not exist anymore.

Thanks.

Looks like http://mymedia.yam.com/m/3599430 died as well.

According to a Yahoo Answer post (in Chinese), the error message indicates that the video does not exist anymore. Videos may be deleted by the original user, or be deleted by site administrators periodically if any violation against copyrights found. The conclusion is, test cases require frequent update. It's not practical, and just let it go...


Create Pact Test for Officer Search Page

Business Context:
We badly need end-to-end tests to die, but we can't feel secure in eliminating them until we have tests that achieve similar coverage. To that end we are writing pact tests that will allow us to establish a contract between the client and the server and run integration tests against said contract.
As a developer who hates the flakiness of e2e tests
I want to be able to replace e2e tests with pact tests
So that the pipeline can pass consistently
In Scope

Load the Officer Search Page
Search by Name
Search by District
Select an Officer
Add necessary state handlers to pass server tests

Out of Scope

Pages that are not the officer search page

Open Questions

Acceptance Criteria

Scenario:
Given
When
Then

Scenario:
Given
When
Then

Mockups
Checklist (should be reviewed before grooming as the BA or Pair are writing the card—NOT reviewed for the first time at grooming)

Discuss the technical implementation of this card.
Discuss how this feature would be included in or affect the Audit Log.
In respect to security, what could go wrong? Brainstorm threats using STRIDE model, especially if this card introduces a new technical architecture or design pattern. (TIMEBOX: 7 mins) https://docs.google.com/document/d/18AFl1d3SRieI4d_8R3GyEazqQOycLNDHGN_vOYIHuiE/edit#heading=h.aio9zb5j63wl
Ensure any open questions have been resolved with stakeholders.
Determine if documentation should be referenced or created.
Ensure to include all necessary mockups to this card.
Discuss what success/failure user feedback messages would be present, if any occur (front end/back end).
Discuss why this feature would not be implemented behind a toggle / what would happen if this card was partially done while a release branch was being cut.
If this card is part of a sequence of cards, discuss if this card should be blocked until the testing of previous  cards in the sequence have been finished.
Have we added edge cases as ACs that we're considered from a QA perspective
Does this card overlap with any entities outlined in API Housekeeping?

Notes:

Watch the timing, you may need to add extra awaits so that all interactions happen


popup menu flickers

The completion window flickers seriously, is there any way to alleviate it?

What command are you trying to complete?
If this is related to file completion, and you have thousands of files then it is explainable. Vim redraws the popup window when you update it through async search.

If I were to guess you are seeing screen flicker in commands (:) but not while searching (/). If so, it is an artifact of wildmenu completion. I don't notice flicker usually as I have a fast computer, but I can see if I observe carefully. It is possible to eliminate flicker completely by replacing wildmenu/pmenu popup with newer popup_create(). I'll put this on my todo list. You are the first one who raised this issue.

If I were to guess you are seeing screen flicker in commands (:) but not while searching (/).

you are right. flicker occurs in : not /.
/ works fine, no flicker.

I could not muster enough motivation to do this enhancement (since it does not bother me). I also have a small kid and finding time is not easy. I am closing this since there is not point keeping this open.

I truly understand you and also appreciate your contributions to the Vim plugin community. If anyone wishes to solve this issue, this plugin might be useful.


clean up mixed tab and spaces

Signed-off-by: Long Dai<EMAIL_ADDRESS>Description
Covert tab to 2 spaces in all all files mixed tab and spaces.
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #[issue number]
Checklist
Please make sure you've  completed the relevant tasks for this PR, out of the following list:

[ ] Code compiles correctly
[ ] Created/updated tests
[ ] Unit tests passing
[ ] End-to-end tests passing
[ ] Extended the documentation / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]
[ ] Specification has been updated / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]
[ ] Provided sample for the feature / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]

@artursouza updated.

@mukundansundar seems codes back by mistake, sorry.


enhance add metrics to show thread cpu usage

Proposed changes
Add a metric thread_cpu_total to show cpu usage by each thread.
Before, when a instance costs too much CPU, we do not know which task cosumes it.
Now, we can check the metrics.
User can query thread pool usage by the following promql

For example, check the cpu usage of CumuCompaction thread pool

run performance

run buildall


License is missing

Hello Remy!
Would you mind adding a license to this repository? Otherwise it’s impossible to use this repo in other projects. MIT license or something similar would be awesome.
Thanks!

I would love to see if I could get open-ephys/plugin-GUI to build in cmake with the help of this module, however I would need to know how the code is licensed first.
The templates seem to be covered under the "JUCE 5 End-Use License Agreement", but what about the code you wrote and published here?

juce-cmake is now licensed under the MIT.


skeleton package.json for npm

Basic beginning of package.json.
Anything further will probably require some re-structuring (like using devDependencies to track things like uglifyjs, instead of a sub-module, and bin to track js cli utils)

Basic beginning of package.json.
Anything further will probably require some re-structuring (like using devDependencies to track things like uglifyjs, instead of a sub-module, and bin to track js cli utils)

can you pls check this out, Thank you!!
https://vuuzletvph.com/heads-up-vuco-bounty-programs-are-coming-your-way/


Show certificate fingerprint

If you have multiple certificates with the same hostname and issuer, it
becomes a little difficult to tell which one is which, especially if
they have issue dates that are close.
Fortunately, we do in fact extract the certificate fingerprint in API,
which can be used to easily tell two certificates apart. This change
adds a truncated fingerprint (7 characters, which is what git uses for
truncated fingerprints too - it's not like we're relying on this for
security, just convenience), which is shown on the certificates list
page and the selector.
I also updated the list page to explain why some certs have no issuer
(they're self-signed), and to fallback to issuerCommonName if
issuerOrganization is missing (the former is guaranteed to be present if
the cert was signed by a CA, the latter is not).
I did have to make the certificate name a little more succinct (remove
some labels), or Chrome wouldn't always show the fingerprint if the
option label was too large in the cert picker.
--
Some screenshots:

cc @fancyremarker @sandersonet @gib

👍


Remove duplicate whiespace from item titles when displaying in list/head

Fixes https://github.com/newsboat/newsboat/issues/1227.
This only removes duplicate spaces when displaying titles.
It might make sense to remove duplicate whitespaces on a lower level (e.g. in getters like title()/get_title() or even when retrieving titles in Cache) but I'm not sure it is a good idea.

Coverage remained the same at 57.312% when pulling faf9436cd9bea30c49de71e7986407838f6e495a on dennisschagt:feature/consolidate-title-whitespace into e4f28127f6126a82bc2bd5a3025c46858b4af9d1 on newsboat:master.

There's definitely a reason to do it at a lower level: filters. If filters see multiple spaces where views only show one, the filters might not work and it'll be very confusing to the user. I think Cache is a bit too low, though; let's do it in the RssItem then?
Thanks for taking care of this, by the way. I keep getting distracted lately and haven't even finished the PRs I myself submitted :(

Sure, I expect to have time later this week.


Fix ios splash screen, icon and add CSP suppport for youtube, wordpress

Hi,
Attached contained few changes that should address our splash screen and ios icon issues for your perusal. Have also added a support for youtube and wordpress in our CSP though thaven't tested. Would test tomorrow when after you deploy. Should there be any issue with regard to this , please do let me know .

Changes Unknown when pulling b37d25811edf49cc0019653928ff4845730a1b68 on nuruddeensalihu:nuru/fix_splash_ios into ** on binary-com:master**.


feat: better template support

Addresses issues left over in #202, especially that templates in the parent component are applied with child values.
Scenarios:

[x] Parent template, child value
[x] Parent template, child template, child value
[x] Parent template, parent value child template (not sure if even possible, failing test is included)

cc @joshukraine, @moltar, @conceptdeluxe

@manniL Thanks for working on this! 🙂

Working on multi nested child with templates to make sure it works perfectly

Well, at the moment it supports only one child with template, it's fine and more children should not happen in usage. Will see if people need this.

Works like a charm :)
Thank you so much! 👍 💯

Hey @manniL can I get a use case example of this? Because currently the documentation seems to reflect the older version of how to use this.

@Sylk Please check the tests for it for now. Don't have an example ready yet ☺

@Sylk I've created the example from the tests
https://codesandbox.io/s/038mp9vkov
As you see, App.vue has an og:title set ("Test title") and also a template for it ( template: chunk =>  `${chunk} - My page).
The child component HelloWorld.vue has just a title set ("An important title!"). But the title (from HelloWorld) applied to the template (from App.vue) will be shown


how to disable resize window?

Bit late but i was looking for the same thing.
How i solved it in my case was by adding "Gui, -Resize" after the neutron.Gui, just like a normal Gui.
You will still have the cursors of resizing, but you can't actually resize.

Right now, neutron.Gui("-Resize") is the recommended way. This will leave the sizing cursors but will disable resizing. Full resizing disable support is planned for the next release.

Solved, thanks @G33kDude


[async, latest] Fixes #300

Closing issues
It closes #300

Hmm seems like I may have to update every package's export map

seems like I may have to update every package's export map

@jaredLunde, all packages probably have the same issue. I've only changed in my PR the ones I know are affected by issue #300

Our team is also waiting for this fix. Can you please add it for the resize-observer package as well (we're seeing the problem with this one on our end)

Our team is also waiting for this fix. Can you please add it for the resize-observer package as well (we're seeing the problem with this one on our end)

@aszmyd  were you able to find a fix for this issue? Please let me know as our team is also facing this issue.

Our team is also waiting for this fix. Can you please add it for the resize-observer package as well (we're seeing the problem with this one on our end)

@aszmyd were you able to find a fix for this issue? Please let me know as our team is also facing this issue.

Regrettably, we've halted our Jest at v27 due to this issue and plan to upgrade once there are improvements in this area.


Add user data

This PR introduces two updates related to the PUT and DELETE methods for adding and removing user data.
For adding user data, the process involves three stages. First, it checks if the provided path exists. Then, it iterates through the path, crawling metadata for each data. Finally, the metadata is ingested into both Solr and Mongo using a multithreaded task. A validator for Mongo is also in place to ensure data adheres to a pre-defined schema, consistent with Solr.
The delete is straightforward, retrieving the relevant facets and deleting them from both Solr and Mongo without multithreading.
Next steps include 1. developing a new Mongo backend for the metadata crawler and 2. updating the Mongo serrvice of Docker Compose freva-rest playbook in Freva deployment.
This PR also includes minor changes such as adding a job to check for pre-release tags and switching the Dockerfile to Miniconda for easier installation of netCDF and HDF libraries for harvesting data and metadata.
 1. changing the branch in dev-env/config to main. 2. remove letter v from the created image in build_job ci
Closes #32

Thanks @antarcticrainforest for the constructive reviews,
all request changes have been reflected and the pre-released version has been already operational on freva dev system.
if it's possible plz take a test on ur own machine or ur local env on levante for a random dataset to see the logs. cause I'm not totally happy about the logs so far.
how the cli and python syntax look like:
pip install git+https://github.com/FREVA-CLINT/freva-nextgen.git@add-user-data#subdirectory=freva-client
token=$(freva-client auth -u <k-number> --host freva.dkrz.de | jq -r .access_token)
freva-client databrowser user-data add \
    --path /a/dataset/path/on/ur/machine/or/levante/ \
    --facet project=cordex \
    --facet experiment=rcp85 \
    --facet model=mpi-m-mpi-esm-lr-clmcom-cclm4-8-17-v1 \
    --facet variable=tas \
    --host freva.dkrz.de \
    --access-token $token

and then delete:
freva-client databrowser user-data delete \
    --search-key project=cordex \
    --search-key experiment=rcp85 \
    --search-key model=mpi-m-mpi-esm-lr-clmcom-cclm4-8-17-v1 \
    --search-key variable=tas \
    --host freva.dkrz.de \
    --access-token $token

or alternatively on pytohn, syntax looks like:
from freva-client import databrowser, authentication
token = authentication(k-number)
db = databrowser(host="freva.dkrz.de")
xarray_dataset = "/path/to/file.nc"
db.userdata("add", userdata_items=[xarray_dataset, "/path/tp/file2.nc"],metadat={})
db.userdata("delete")

how to find it on freva-dev instance:
https://www.freva.dkrz.de/databrowser/?flavour=user&user=k-number
but restful api endpoints now doesn't look pretty much applicable as initial point of user-data crawling! cuase it works as a bridge between client and server to transfer metadata from client to server

@antarcticrainforest thanks for the second round. The update is now ready for review again.
The main change from the user’s perspective is the Python syntax update, enabling users to specify the host and fail_on_error parameters directly in the userdata method. On the other hand, wildcard paths are now supported for crawling.
from freva-client import databrowser, authentication
import xarray as xr
token = authentication(k-number, host="freva.dkrz.de")
file_path = "/path/to/file.nc"
xarray_dataset = xarray.open_dataset("file_path")
databrowser.userdata("add", userdata_items=[xarray_dataset, "/path/tp/file2.nc"], metadat={}, host="freva.dkrz.de", fail_on_error=True)
databrowser.userdata("delete", host="freva.dkrz.de", fail_on_error=True)

@antarcticrainforest i resolved all change reqs. Logs are still don't look satisfying to me ...

@antarcticrainforest now logs look better and we have a stage to validate Solr before post ...


re-infer (refresh) mapped parameters

TypeScript Version:  3.7.0-dev

Search Terms:
TypeScript's intellisense seems to go out of sync when using mapped types on parameters.
Code
import {F} from 'ts-toolbelt'

declare function pipe<Fns extends F.Function[]>(...args: F.Piper<Fns>): F.Pipe<Fns>

pipe(
    () => ({a: 1, b: '2'}),
    (prev) => prev // no intellisense - `any`
)

pipe(
    () => ({a: 1, b: '2'}),
    (prev: string) => prev // has error, works
)

This has the disadvantage of having to re-specify the type that is already known (prev), but could be infered by the mapped type. In my case, this is blocking me from providing generic pipe & compose for ramda.
Expected behavior:
Intellisense should pick the mapped type up

Please provide an isolated repro; we can't work with samples that import types from other libraries.


Add message relayer batch

Add message relayer batch
L1MultiMessageRelayer.sol is moved to packages/contracts/contracts/L1/messsaging, so we don't have to tackle the abi in message relayers.

Codecov Report

Merging #21 (3d5a75d) into develop (93dd99f) will increase coverage by 16.62%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           develop      #21       +/-   ##
============================================
+ Coverage    73.98%   90.60%   +16.62%
============================================
  Files           64       32       -32
  Lines         2164     1086     -1078
  Branches       304      150      -154
============================================
- Hits          1601      984      -617
+ Misses         563      102      -461

Flag
Coverage Δ

batch-submitter
?

contracts
90.60% <ø> (-0.68%)
:arrow_down:

core-utils
?

data-transport-layer
?

message-relayer
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...s/contracts/L1/messaging/L1MultiMessageRelayer.sol
0.00% <ø> (ø)

packages/core-utils/src/common/misc.ts

.../l1-ingestion/handlers/sequencer-batch-appended.ts

.../src/services/l2-ingestion/handlers/transaction.ts

packages/message-relayer/hardhat.config.ts

...ackages/batch-submitter/src/utils/tx-submission.ts

...ices/l1-ingestion/handlers/state-batch-appended.ts

packages/batch-submitter/src/utils/index.ts

packages/data-transport-layer/src/utils/eth-tx.ts

packages/core-utils/src/coders/sequencer-batch.ts

... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93dd99f...3d5a75d. Read the comment docs.


Cannot boot Ubuntu 16.10 Server VM on virtlet

I'm trying to run my own VM on Kubernetes using Virtlet and everything is green and the "Running" status is reported:

But then I can't find a way to connect to the VM. Neither virsh console nor ssh seems to be working. Both methods work for cirros image, though.
What did I try
I've created a new QCOW2 and installed Ubuntu Server 16.10 on it. Inside Ubuntu I've enabled ssh server and ttyS0. Then I run it on virtlet and try to connect like this:
$ kubectl exec -it virtlet-9l1fz -n kube-system -- /bin/bash -c "virsh list"
Id    Name                           State
----------------------------------------------------
 1     aa65799e-59f4-4cd6-6943-672f1b02c5fa-cirros-vm running
 11    cefc0eda-f400-4c45-5599-7abdb748e122-miha-ubuntu-server running

$ kubectl exec -it virtlet-9l1fz -n kube-system -- /bin/bash -c "virsh console 11"
Connected to domain cefc0eda-f400-4c45-5599-7abdb748e122-miha-ubuntu-server
Escape character is ^]
# nothing happens when I press keys

But I cannot access the VM from anywhere. If I dump libvirt XML and run it on my host, changing nothing but qcow2 image path and removing <emulator>/vmwrapper</emulator>, everything works:
<virtlet>$ virsh dumpxml 11 >./ubuntu_server_dump.xml
<host>   $ virsh create ./ubuntu_server_dump.xml --console
# the login prompt appears as expected

Any idea on how to debug/fix this? The QCOW2 image that I'm trying to run is available here with credentials ubuntu | pass. I'm really lost on this one since it feels like everything should be working with no problems.

Alternatively, do you perhaps own an image that runs well on virtlet (and has apt-get available) that you could share?

Sorry for not responding earlier.
This can be connected with two things:

ubuntu image is not prepared to have console on serial port (quite normal)
it's prepared to configure itself using cloud init metadata server - which we don't support yet right now.

We have a plan to support at last cloud init config drive to eliminate/reduce later issue. Also we have planned research on how to support vnc console, so this should solve no-output which is a part of second issue.
I'll also test mentioned image by myself, probably tomorrow morning.

Thank you for fixing this. I am now able to run ubuntu server and connect to it using virsh console.
I am not able to ssh yet, but I think it's not an issue with Virtlet but with networking configuration in guest OS. Closing the issue.

Ah, I just managed to SSH as well - it was a problem with guest OS indeed. Adding this comment just for a future reference:
I had to update /etc/network/interfaces so that it contains:
allow-hotplug ens6
iface ens6 inet dhcp

and then run:
$ sudo ifup ens6


fix for new version

This seem to fix problems with new obsidian version. mb I broke something though, not sure.
the scrollbar fix is kind of hacky, might be better to properly fix it with z-index in the future

Actually I'm wrong because this way the title doesn't scroll with the doc


Implement pattern matcher library & tests

This is ported from moby/patternmatcher but cleaned up and with a bunch of dead logic removed.
test/pattern_matcher_test.py ...................                                                                                [100%]

=============================================================== 19 passed in 0.05s ================================================================

I've reviewed this as well, so go all out. Comments, tests, and type annotations are also written by me.

This could also go in mount_utils but maybe better to cordon off the semi-generated code 😄.

Amazing; thanks for this. Made a ticket to track using this in the Image API.

@ekzhang are we good to merge here?


Advanced networking is not displayed and does not work

@hamza-usmani @nieubank ### Steps to reproduce
I installed the WSA and I don't have this option. Other than that my ip address is behind NAT. How do I get a network bridge?

1 - my current ip address
2 - ip address of the virtual machine
✔ Expected Behavior
I expect the Android ip address to be in my windows subnet. Or at least it will be the same.
Bridge.
❌ Actual Behavior
NAT
Other Software
No response
Please specify the version of Windows Subsystem for Android
2301.40000.4.0

Hi,
Thanks for reaching out, this behaviour is not expected. We will investigate and get back to you.

Hi,
Can you specify which version of Windows 11 are you using? Can you update to the latest version and try this?

@bansalsushant No I can't update Windows. It's installing some software that nobody knows about. I cannot risk the stability and security of the operating system.

Unfortunately, advanced networking functionality is only supported on Windows 11 22H2(22621+).

Ok. Then you make it just for yourself.

I have the same issue. i have installed Windows 11 23H2 build 22631.3007 and my WSA version is 2311.40000.5.0.

same here... installed WSA, i cant make use of devices in my local network  via wsa.. and it does not have na option for advanced networking options...

Advanced networking was superceded by the Local Network Access feature which is located on the Advanced Settings > Experimental features section.

@jaholme This feature is available on Windows 10 21H1 build 19043???

@jaholme but does it work though ? I have it turned on but still can't get to connect with local devices on the same network

Network settings so basic feature. Why only work in win 11.


Issue with tutorials/forest-cover-loss-estimation/index.md

Dear GEE-community,
In the GEE Community tutorial "Forest Cover and Loss Estimation" -> "Subsequent tree cover", it says:
"You can estimate the tree cover after the loss by subtracting the loss from the previous tree cover."
When I look at globalforestwatch.org/map, under the "Caution" section on the "Tree cover loss 2001-2020" information tab, it says:
"Due to variation in research methodology and date of content, tree cover, loss, and gain data sets cannot be compared accurately against each other. Accordingly, "net" loss cannot be calculated by subtracting figures for tree cover gain from tree cover loss, and current (post-2000) tree cover cannot be determined by subtracting figures for annual tree cover loss from year 2000 tree cover."
To me, these are two contradictory statements on one type of analysis. Or am I missing something here? Is it "estimate" and " be determined" that separates the two statements?
Kind regards,
Johan

Johan, thanks for flagging the issue (and moving the info here 😃) . I'll look more closely and propose some ways to resolve it by the end of the week.

Dear Justin,
Just wanted to check-in on the progress of this issue? :)
Thanks,
Johan

@jdbcode, thanks for tagging and suggesting good options!
As you said, this tutorial is meant to provide tools to conduct the analysis and the datasets should be any that's most suited. In reality, when the government conducts this type of analyses, they typically have a wall-to-wall national tree cover map (For more information and examples, please see FREL submissions by countries). Many of them still use the Hansen datasets to varying degree, but when they do, they correct bias with statistical sampling. What I mean by saying all this is that the proper analyses for the subject matter takes a lot more than what the tutorial provides, which is to show how to incorporate the tree loss in estimating the administratively defined 'forest' cover by coding.
I think that it's a good idea to add the acknowledgement (option 3). I'd also add a few sentences when we are introducing the datasets.
In the subsection starting with 'Tree cover', it says:

Currently, Google Earth Engine has several tree cover datasets in the catalogue, including the Global Forest Change (GFC) (year 2000) and GLCF: Landsat Tree Cover Continuous Fields (2000, 2005, and 2010). Here, we use the Global Forest Change dataset.

Instead the above, what do you think about saying something like:

We need a tree cover map to start this analysis. It is important to select a tree cover map that is appropriate for the purpose and scope of your research. In this tutorial, we select one from the Google Earth Engine catalogue, which currently has several tree cover datasets in the catalogue, including the Global Forest Change (GFC) (year 2000) and GLCF: Landsat Tree Cover Continuous Fields (2000, 2005, and 2010). Here, we use the Global Forest Change dataset*.
*"We acknowledge that https://github.com/google/earthengine-community/issues/490#issue-1177277759; the dataset is used to demonstrate analyses and introduce Earth Engine concepts"

Thanks so much for your help!

This all sounds great, Keiko, thanks!
I'm just about to be off on vacation for a week, so will need to make the change after I return.
I'll run the pull request by you.

@gino-m please review #765


feat: changesets docs

WHY are these changes introduced?
Fixes [ENG-6345]
WHAT is this pull request doing?
Adds changesets docs to CONTRIBUTING.md

Thanks for correcting the grammar @alexcasche , should be all good now!


Add date range field

I don't think I want to place the onerous of choosing a date library to the user. So I moved the loading of date library into boxel-ui addon and scope it there. Otherwise, we have arbitrary code in host about ember-power-calendar that needs to be loaded there.
https://github.com/cardstack/boxel/pull/1794/commits/a0ff9caaee48569cbd9cc7d23811f7ea0429790d

The component looks good when displaying in Boxel UI, but in actual implementation, it somehow looks crowded - possibly due to the lack of padding on the datepicker container, font size, etc.
We can consider to tweak the styling after that

I realise I need a feature to close the modal for users who have no intent of adding a date AFTER they have opened the calendar. I am will add a button called "Cancel". So the pattern should be quite natural, if the modal is closed, the date is updated BUT if Cancelled, the date is not

I realise I need a feature to close the modal for users who have no intent of adding a date AFTER they have opened the calendar. I am will add a button called "Cancel". So the pattern should be quite natural, if the modal is closed, the date is updated BUT if Cancelled, the date is not

I change my mind about this
there shud be a

save button: commits instance and selected date display and close calendar
reset button: commits instance to null and selected date display and don't close calendar
click outside: doesn't commit instance and selected date display of last commited and close calendar

@burieberry I think I want to add some design enhancements to the calendar ie

make the dropdown smaller
make the row highlights rather than vertical
investigate usage of types in registerLibrary

If you review this, I'll merge this in first, otherwise, I'll add those features tomorrow

Most recent design is here @burieberry

@lucaslyl has a lot of changes so I just left dueDate and dateStarted in so he can handle them


Add ability to configure transpilation and bundling with experimentalCompileTest

This adds the experimentalCompileTest option to .fusionrc.js. It remains
undocumented as of now. We will first test in a prerelease to make sure
it fits our needs. Once we are ready to release it outside of experimental
mode, we will add documentation.

It seems to me that if we add this, we might want to deprecate experimentalCompile and then throw an error if both experimentalCompile and experimentalCompileTest are both supplied. These are two knobs that kind of control the same thing.


Autofill design review feedback

Task/Issue URL: https://app.asana.com/0/488551667048375/1204135679490431/f
Description
Address comments raised in design review
Steps to test this PR
Feature 1

[ ]
[ ]

UI changes

Before
After

!(Upload before screenshot)
(Upload after screenshot)

Current dependencies on/for this PR:

develop

PR #2926   👈

PR #2927

This comment was auto-generated by Graphite.


[FLINK-2507]Rename the function tansformAndEmit

I think the function name "tansformAndEmit" in ' org.apache.flink.stormcompatibility.wrappers.AbstractStormCollector' is a wrong spelling, it should be "transformAndEmit" is more better.

Why the permissions of file are changed from 644 to 755? Other changes seems good.

@chiwanpark Thank you very much. I submit code in linux and modify the permissions Incorrectly.I will submit again,.

Will merge this...


Set search path for check commands

https://jira.mesosphere.com/browse/DCOS_OSS-1321
DC/OS PR: https://github.com/dcos/dcos/pull/1752

Ready for review!


Add support to collect OpenShift cluster topology and node config

This commit:

Adds an openshift-cluster-topology role which needs to be run on
the jump host which has the kube config.
Adds an openshift-common role which needs to be run on the nodes
belonging to the core cluster.

@jtaleric @aakarshg PTAL.

@chaitanyaenr so, reading around ansible, I wonder if we could use query_json instead of using jq?
So, we would load the oc command output, use from_json, then query? I haven't tried this myself, figured I would see if you are interested in looking.

@jtaleric sure, will take a look at it and update the PR.

@jtaleric Thanks for the suggestion, I have updated the PR to use json_query instead of jq to get the pod count. PTAL.

Thanks for the review @jtaleric @aakarshg.


Editor never stops waiting for formatting

The formatter never returned for a particular file, and editor continued to wait for it to exit. We might want to put in a time-out and at least ask the user whether they want to continue waiting or kill the process.

This issue has been moved to dart-lang/eclipse3#51.


Verbose provisioning

Description
The provision call of the provision library is a blocking call giving no further in-between status. In case of strange behavior, it will be great to have a way of retrieving the internal logs of the command to be used as verbose logs. Maybe improve the interface to attach a log stream to the stdout of the client in case verbose logging is wanted.

Reasons
Often the provisioning call just executes giving no details on whats happening and even on the cloud provider side nothing is happening. So having a verbose mode indicating that a terraform-provider gets downloaded will help to understand whats going on.

Attachments

This was solved in https://github.com/kyma-project/hydroform/issues/252


Accept number as a vText node

Since the intent seems to be to emulate Hyperscript as a DSL, it could be useful to mimic the library's autoconversion behaviour for primitives.
Here is the vanilla Hyperscript implementation: https://github.com/dominictarr/hyperscript/blob/master/index.js#L37
I would definitely vote in favour of keeping the two implementations consistent. This way legacy Hyperscript code can be ported cleanly to use virtual-hyperscript implementation.

Just for the record, I agree that implicit type coercion is bad, but this could still keep underlying implementation (VDom) tight, but making the glue (Hyperscript DSL) loose.

@unframework sorry what do you propose, exactly?

I was just presenting a counter-argument to the "implicit type coercion is the devil" reply.

I disagree this should be merged. Implicit type conversion should not happen at this layer. If you want to create a text node with numbers, simply pass it as a string before it gets there.

Type coercion here would be great. The alternative is to blow up with a very difficult to diagnose error message for something that shouldn't matter.

This has now been accepted and landed.
There was a lot of ask for this feature so we've added it.


Meaning of "profile" and "temperature"

Hi IF-AI,
thanks for your nodes, they work great for me.
I am curious what the profile and temperature parameters do, can you please explain?
Thank you for your kindness!

Hi, Thank you. The profile soon to be named (assistant) is kind of a system prompt or template for the LLM to control it's behaviour.  I am working to improve this node and making it into something that can be an assistant for your workflows in comfy for a wide range of scenarios. Still a long way to go.  But the idea is to steer the model to be more specific to your use case. The profiles are json files so you can create your own assistants.
The Temperature is a parameter to control how creative and coherent you want your response, if the responses are too wild you can lower this number normally it goes from 0 - 2 a number closer to zero like 0.2  will give a very strict and repetitive output 0.5-0.7 is a good number to get creativity and avoid repetitiveness you can go over one like 1.2 but depends on the models some have different thresholds and can make the response incoherent to your request. This numbers are base on LLama models but even a finetune can skew the numbers so you have to play a little to find the best settings.

Great explanation, thanks! You might consider adding this information to the Usage instructions where people are more likely to find it than buried here in Issues.

I am preparing some updates and will make a better docs for the nodes soon after the update. Since things are like in a WIP phase atm. Thanks for the suggestion

I added a help Instructions guide Note in the latest workflow


No Package for 0.7.0 yet

Previous releases had an gitlist-x.y.z.tar.gz archive attached, the most recent release as of now has not.
Please add a package to the release, esp b/c the RCE fix.
(I know you can use ant build-package and I already upgraded this way, but I think that's not the way everyone should need to go.)
Thank you!

Those waiting may download the package I built myself from my website: gitlist-0.7.0.tar.gz (GPG signature).

@p3x-robot Did you know you can contribute to this repository instead of asking to move to your fork?
I kindly ask you to stop spamming this repository with links to the fork. Please contribute your changes instead, if they are properly licensed.


Latest devtools 6.0.2 not listed in chrome web store - still 6.0.0 installed

Version
6.0.2
Reproduction link
chrome.google.com
Steps to reproduce
The latest vue devtools 6.0.2 is not listed in the chrome web store, which still shows 6.0.0 https://chrome.google.com/webstore/detail/vuejs-devtools/nhdogjmejiglipccpnnnanhbledajbpd
My Chrome browser installed 6.0.0 and won't go above that.
On the other hand, Firefox installs 6.0.2, as expected.
What is expected?
Latest devtools 6.0.2 should be listed and installed in the browser.
What is actually happening?
An older version is installed 6.0.0.

Google takes forever to validate extension updates. Chrome will always lag behind Firefox release.

@Akryum Not sure that's the issue. It looks more like the chrome web store publishes the previous version as soon as you push the latest one. Now it published 6.0.2 on the exact same day when the latest 6.0.5 was released on github. Anyway...

That's the issue. I know, I'm the one uploading the versions to the Chrome Web Store :sweat_smile:


Redundant lean installs

Bootstrap results in redundant lean versions being installed.  The vscode extension runs elan-init.ps1 -y leanprover/lean4:nightly and when the user next does lake init foo, lake installs leanprover--lean4---nightly-2021-12-13 even though the default toolchain has an identical version as shown below:
>c:\users\clovett\.elan\toolchains\leanprover--lean4---nightly\bin\lean --version
Lean (version 4.0.0-nightly-2021-12-13, commit 3a6cc774241b, Release)

>c:\users\clovett\.elan\toolchains\leanprover--lean4---nightly-2021-12-13\bin\lean --version
Lean (version 4.0.0-nightly-2021-12-13, commit 3a6cc774241b, Release)

@lovettchris Very true. However, this is entirely due to elan, It has nothing to do with Lake. You should raise this issue over at leanprover/elan instead.

@lovettchris  Ah, having looked over your comment in the linked issue, I see where your confusion it coming from. When Lake creates a new package it pins the package to its specific version of Lean (i.e, nightly-2021-12-13 in this example) -- not its general toolchain (i.e., nightly) --by writing that version to lean-toolchain. This is the desired behavior -- packages should be pinned to a specific version of Lean and not a distro to make builds easily reproducible.
However, because of the way elan works,  when a Lean tool is then run in that folder, elan downloads that specific toolchain (if it is not already installed) instead of currently using the distro (even though the versions match). I do not know why this decision was made, you can probably ask @Kha,  but I would suspect it makes toolchain management easier.


Break up views.py to multiple files

Views.py

admin.py
notifications.py
events.py
accounts.py

Completed w/ https://github.com/porowns/krypted-auth/commit/c188a573f9c5acadf762525c8f17df1a83228d47


Drawing graph for debugging purpose

Hi. I know your library since a few hours, and did not dig in the code yet, but I am very happy with the results I already get.
I face a problem with my code which generates a "multiple outgoing edges with same upstream label None; a split filter is probably required" error. If I understand well, there is an error in the generated DAG.
I rewrote my example in a more linear manner to get a minimal erroneous example to show, but it works well.
Hence my question:
Is there a tool to generate a representation to debug the built graph?
In a project I made, I found it both easy and extremely useful to have a function to generate a graphviz script. If you do not already have a tool like that, it would be a nice addition and the graphviz way has low cost (just have to get the list of all possible nodes, and write a few textual lines to describe the inputs & outputs mainly).

It was effectively a one letter typo in the name of an input which happens to become the same one as another input, hence the error. It took me a bit more than half an hour to find where it was, whereas with the graphical representation of the dag, it would have been very obvious and less demanding.
I tried to display the command line version of the graph with compile, but it obviously lead to the same ValueError as the run command, so a tool such as the one I suggested would be awesome.

I partially answer to myself: listed in ffmpeg-python documentation page (but without explanation) and used in "Assemble video from sequence of frames" example, there is view method (stream and module) which allow to display a graph if graphviz module if installed.
However, it seems to work on a stream and this one must be valid for the call to succeed, thus it is not usable for debugging.

I might not be really awoken the other day, as the view method works even with the bad graph, thus can be used to debug. Actually, there were a compile just before which was the actual line which failed.
The documentation still lacks explanations.


Algos failed to extract future information.

I played the "mutiple stock trading" version, use A2C model.

I trimmed the assets into 2 stocks and indicators into 2.

config.NAS_100_TICKER = ["AAPL",'TSLA']
config.TECHNICAL_INDICATORS_LIST = ["close_30_sma", "rsi_30"]

I replaced the indicators with the furture prices. In this way, I am leaking the future info to the algo, allow it to learn.
For the risk indicator, I keep vix.  Vix may or may not be ralated to above 2 stocks.
I also removed open/high/low price to reduce the state space.

processed['close_30_sma'] = processed['close'].shift(-10)
processed['rsi_30'] = processed['close'].shift(-20)
processed = processed[['date', 'close', 'tic', 'close_30_sma', 'rsi_30', 'vix']]

During the trade period from '2020-07-01' to '2021-10-31', AAPL rose about 60% and TSLA rose more than 200%.
I expect the algo will find the future info and achieve a return between 60% and 200%.

The result is quite dispointing. The algo cannot extract future info effectively.  The return is less than 40%. It did not discover the future info.

I keep "TSLA" only to see if it works in sigle stock.
It also failed because it did not avoid the max drawdown, which is almost the max drawdown of TSLA during this period.
Through the algo does not allow selling short, it can hold 0 stock to dodge the falling period.

The cause of this problem happens in two conditions:

when holding no shares but action is sell,  _sell_stock() returns sell_number as 0, then reward will be zero.
when balance is not enough to buy, _buy_stock() returns 0, then reward will be zero.
above two condition caused algos to stick to boundiers. It will keep buying or selling.
To change, we can assign a negative reward to these conditions.


WIP: Add client apis for accessing datamodel state

~Will request review when its ready.~
Now ready for review.
This PR includes:

What the client-side apis for both instance management and the instance protocol look like as well as the data model and how they get used, complete with tests and example code.
A fully functional instance management API on both client and server (using serde in the short term for convenience)
Stubs for the DID authentication scheme

There is a lot that still isn't implemented. In particular, the client crate needs a tokio task to build up RemoteChanges as well as send over the network the LocalChanges, and we need to implement the application of these changes to the main data model in the flush() method. More importantly, the server doesn't actually implement almost anything in the instance protocol, its all stubbed out right now. This means that all the state that is local to the client won't get sent to other players.

Approving, had @mweatherley glance over it, and because no one else reviewed :P


Support both TCP and UDP at the same time

TCP:443 UDP:1194
Please add option

Duplicate https://github.com/Angristan/OpenVPN-install/issues/28


[type:fix] fix issue 5033.

Fixes #5033  temporary

Make sure that:

[ ] You have read the contribution guidelines.
[ ] You submit test cases (unit or integration tests) that back your changes.
[ ] Your local test passed ./mvnw clean install -Dmaven.javadoc.skip=true.

Codecov Report

Merging #5110 (f093dae) into master (11cd02a) will decrease coverage by 0.11%.
Report is 2 commits behind head on master.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #5110      +/-   ##
============================================
- Coverage     61.83%   61.73%   -0.11%
+ Complexity     8496     8486      -10
============================================
  Files          1227     1227
  Lines         36964    36953      -11
  Branches       3514     3511       -3
============================================
- Hits          22858    22814      -44
- Misses        12144    12178      +34
+ Partials       1962     1961       -1

see 34 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Show available stock in part BOM table instead of stock

Fixes #2795

@rkalman thanks for submitting a patch for this, however there are a few subtleties here with how the API is handled.
The existing available_stock function (for the Part model) is not very "efficient" when it comes to performing database queries. It's "fine" for running against a single Part instance, but once you are performing a large lookup of data (e.g. an entire BOM) then referencing this available_stock parameter quickly becomes expensive.
Your approach of adding an 'available_stock' field to the API serializer is good one, the data just needs to be calculated and annotated as part of the initial database query.
I will submit a new PR which addresses this and tag you in it, it might be easier to see what I mean by showing rather than telling!
Addressing DB query efficiency has been a big learning curve for me, and it gets pretty complicated :)

For example here's how we calculate the "on_order" quantity in the API serializer context.

Note that it is different from how we calculate it for an individual Part instance:

Also, if we are making changes to the API the version number in InvenTree/version.py needs to be bumped, in addition to a description of what has been added :)

Yes, I really do not know the code in deep details as you see, a thank you for guiding me to the right direction!
However if the available stock calculation is expensive, then it can raise a bigger problem.
On many places the stock quantity is displayed only (like in the box table here, but also in the sales orders, in the quick search menu, ...) but basically it does not tell too much for the user when he uses the allocation system...
In my opinion all of this places should show the available quantity.

"Expensive" is relative :)
In simple terms the difference between the two approaches are:
@rkalman method

Retrieve multiple parts from the database in a single large query
Iterate through each part (one at a time) and call the available_stock method
Each call to available_stock requires multiple small database queries
For "N" part objects, you are now performing "1 + N" database hits (this is the expensive part!)

@SchrodingersGat method

Pre-annotate the database query to also fetch allocation data for related stock items
Retrieve multiple parts from the database in a single query (with annotations performed as part of the SQL query)
Done!
A single database hit is much cheaper, even if the query itself is a lot more complicated

Check out the implementation here: https://github.com/inventree/InvenTree/pull/2797
Once this change is merged in, please merge master into your branch, and use the "unallocated_stock" quantity (now available in the API) in the BOM table. Then push those commits back here!
If you have found other places where the "available" quantity should be used (rather than the "total") then that would be best done as a separate PR :)

Query annotation is performed as below:

Ok, thank you!
However the available quantity has one flaw, could you take a look on this: https://github.com/inventree/InvenTree/issues/2741#issuecomment-1084436693

@rkalman ok, that PR has been merged in now, which makes the field "unallocated_stock" available via the API.
Please merge the master branch into yours, and push the changes back to here :)

Ok, I'm stuck a little bit. I see your changes in PartSerializer, however this BOM table uses the PartBriefSerializer.
So I don't know how to use that new "unallocated_stock" field, because it seems to me it is only available in the PartSerializer, and not int the Part model itself, which is used by the PartBriefSerializer...

@rkalman fair point - I would suggest that as you need access to this extra information in the BomItem API, then change the BomItemSerializer class to use the PartSerializer rather than PartBriefSerializer:

yes, that was I have done, but where to call the static method partserializer.annotate_queryset?

Ah, ok on closer inspection, this is very interesting. I'm stumped - I am not sure how to annotate a queryset against related fields for the part_detail information - or if it is even possible.
Another interesting point is that you have helped me to understand at least part of why the BOM API is slow.
Adding the stock field to the PartBriefSerializer is causing the "1 + N" query problem (described above) and post-calculating the available stock for each part separately.
I think that probably what we need here is a custom approach for serializing BOM items, with available quantities annotated to the BomItem serializer itself.
This would also let us do some other useful things, like adding calculated fields such as "substitute_stock" which takes into account substitute parts.
I'll have to mull over this one for a little bit, it's going to be reasonably complex to implement this properly.. I'll get back to you :)

@rkalman I have a work in progress to solve this, which adds both the "available_stock" and "available_substitute_stock" data to the BomItem API.
However I am stuck trying to add "available_variant_stock" due to the difficulty (maybe impossibility) of annotating stock items for all possible variants of parts, which exist as a tree structure and is hard to query as a flattened structure.
Please check out #2806 and let me know what you think so far.

I think the original idea to show the available stock instead of total stock in the BOM table is fulfilled nicely, it is much more relevant. As you know I am really new in python&django so unfortunately I cannot improve this any further.

@rkalman fair point, it is an improvement at least - I'll merge in for now and consider the other improvements later.


just another edit

the domain 00zasdf.pw does not exist anymore
also add faketaxi1.com to the list

faketaxi1.com has been added.
A check for all domains is needed to make sure they are still registered. I will do this later and update the list.


Data loss while using the app (the fragment disappears after double screen rotation)

When I perform these sequences of events, the fragment disappears after double screen rotation:

Open the app
Tap in About
A screen similar to this will appear:

Before rotation:

Force the pause from the activity and then return to the activity (double screen rotation). Note that the About fragment disappears.

The expected behavior is the return to the state of the previous image.
However, the About fragment disappears.
After rotation:

Note:

The pause from activity(1) can be performed in several ways. We suggest using a double screen rotation (starts in portrait, goes to landscape, and back to portrait) with this function previously enabled in the smartphone.
Double screen rotation: It is executed twice to reach a state that should be exactly the same as the screen before if no data loss occurred.
A data loss problem occurs when data is accidentally deleted or state variables are accidentally assigned with default or initial values.

Device:

Device: Moto G30 with OS: Android 11
Version: 2.10
Device language: English

https://developer.android.com/guide/components/activities/activity-lifecycle

Thanks for the report of this issue! I will fix it in next version :)

Thanks

The issue was fixed in 234dd27, will be included in the next release.


Some lists have missing titles, seasons or episodes

Bug report
Your Environment

Netflix add-on version: 1.6.0
Operating system version/name: LibreElec 9.2.6
Device model:  Raspberry Pi 4

Used Operating system:

[ ] Android
[ ] iOS
[ ] Linux
[ ] OSX
[X] Raspberry-Pi
[ ] Windows

Describe the bug

A lot of titles are missing from the add-on library
Expected behavior

All shows should be present in the add-on as that of the browser version
Actual behavior

Not all shows are present for example (But not th eonly missing title)the Anime library, only 16 are present on the add-on, yet 114 present on the browser.
Steps to reproduce the behavior

Navigate to TV show genres
Select Anime
Only 16 are present

Possible fix

Debug log

The debug log can be found here:
https://paste.kodi.tv/edarapeden
Additional context or screenshots (if appropriate)
Other information

Screenshots

I can confirm this issue
Various folders are showing missing titles or not showing titles at all

I can confirm this issue
Various folders are showing missing titles or not showing titles at all

the add-on have no control over the data sent by the website,
may be due to a temporary malfunctioning of the website
you can try do clear cache memory/disc from expert settings
wrong results can be happen also if:
-you use VPN/Proxies, are not supported by addon
-you use profiles with different languages

the add-on have no control over the data sent by the website,
may be due to a temporary malfunctioning of the website
you can try do clear cache memory/disc from expert settings
wrong results can be happen also if:
-you use VPN/Proxies, are not supported by addon
-you use profiles with different languages

the add-on have no control over the data sent by the website,
may be due to a temporary malfunctioning of the website
you can try do clear cache memory/disc from expert settings
wrong results can be happen also if:
-you use VPN/Proxies, are not supported by addon
-you use profiles with different languages

English is the default I use.
I understand you dont support VPN and not asking for support on it, but I did try it with and without vpn (I know which shows should and shouldn't be present when VPN is on or off.) yet this didn't effect the anime list. I shall completely remove the vpn add-on and retry the clear cache under yours.

the add-on have no control over the data sent by the website,
may be due to a temporary malfunctioning of the website
you can try do clear cache memory/disc from expert settings
wrong results can be happen also if:
-you use VPN/Proxies, are not supported by addon
-you use profiles with different languages

English is the default I use.
I understand you dont support VPN and not asking for support on it, but I did try it with and without vpn (I know which shows should and shouldn't be present when VPN is on or off.) yet this didn't effect the anime list. I shall completely remove the vpn add-on and retry the clear cache under yours.

So uninstalling the VPN addon(vpn manager for openVPN) 'fixed' the issue, I guess I am stuck with the content my country has while using my media box.

So uninstalling the VPN addon(vpn manager for openVPN) 'fixed' the issue, I guess I am stuck with the content my country has while using my media box.

I'm using the latest Matrix Version on the very latest build of Libreelec.
I've have cleaned the cache/disk on the expert settings.
This issue persists.
This is a new install of Libreelec.
I have the latest Leia addon running on OSMC (Vero 4K) and it doesn't seem to be affected with a possible Network problem.
Ir seems to be affecting only the Matrix addon.

I'm using the latest Matrix Version on the very latest build of Libreelec.
I've have cleaned the cache/disk on the expert settings.
This issue persists.
This is a new install of Libreelec.
I have the latest Leia addon running on OSMC (Vero 4K) and it doesn't seem to be affected with a possible Network problem.
Ir seems to be affecting only the Matrix addon.

Have a look on this log
http://ix.io/2Nf1

Have a look on this log
http://ix.io/2Nf1