arm64: Initial implementation of CONFIG_BUILD_KERNEL

Summary
arm64: Initial implementation of CONFIG_BUILD_KERNEL
This is the initial version for kernel mode build on the arm64 platform.
It works much in the same way as the risc-v implementation so any
highlights can be read from there.
Features that have been tested working:

Creating address environments
Loading init (nsh) from elf file
Booting to nsh
Starting other processes from nsh
ostest runs to completion

Features that are not tested / do not work:

SHM / shared memory support
Kernel memory mapping (MM_KMAP)
fork/vfork

An example qemu target is provided as a separate patch:
tools/configure.sh qemu-armv8a:knsh
Impact
Add kernel mode for arm64, no impact on flat mode operation
Testing
qemu-armv8a:knsh

Hi @xiaoxiang781216 seems like CI is frozen! 2h and it didn't even pass the initial 4 checks:

./cxxtest_main.cxx:31:10: fatal error: fstream: No such file or directory
I think this is due to a missing C++ library, not sure why my build passes locally but CI fails. I think I'll just disable cxxtest.
Error: fpu.c:55:8: error: #warning "FPU test not built; Only available in the flat build (CONFIG_BUILD_FLAT)" [-Werror=cpp]
   55 | #      warning "FPU test not built; Only available in the flat build (CONFIG_BUILD_FLAT)"
      |        ^~~~~~~
cc1: all warnings being treated as errors

This I'm not sure how to fix; ostest builds the FPU test for BUILD_KERNEL and BUILD_PROTECTED and then gives this warning about how the test does not support either one. I never understood why as the obvious solution is to not build FPU test if !BUILD_FLAT. As arm64 has -Werror enabled, it blocks CI from passing.
Would it be OK to simply remove FPU test from the build if !BUILD_FLAT ?

./cxxtest_main.cxx:31:10: fatal error: fstream: No such file or directory I think this is due to a missing C++ library, not sure why my build passes locally but CI fails. I think I'll just disable cxxtest.
Error: fpu.c:55:8: error: #warning "FPU test not built; Only available in the flat build (CONFIG_BUILD_FLAT)" [-Werror=cpp]
   55 | #      warning "FPU test not built; Only available in the flat build (CONFIG_BUILD_FLAT)"
      |        ^~~~~~~
cc1: all warnings being treated as errors

This I'm not sure how to fix; ostest builds the FPU test for BUILD_KERNEL and BUILD_PROTECTED and then gives this warning about how the test does not support either one. I never understood why as the obvious solution is to not build FPU test if !BUILD_FLAT. As arm64 has -Werror enabled, it blocks CI from passing.
Would it be OK to simply remove FPU test from the build if !BUILD_FLAT ?
Or maybe just use this: https://github.com/apache/nuttx-apps/blame/c4d97cd8f8ad48ef5c68c75a271152cb681460d9/testing/ostest/Kconfig#L83-L85

Yes, I think the warning is unnecessary and boring.

The cache issues and build issues should now be fixed @acassis


Use functional options pattern for initialising NodeServer

Based on https://github.com/warm-metal/csi-driver-image/pull/71#discussion_r1399270506
Other refs around this pattern:

https://golang.cafe/blog/golang-functional-options-pattern.html

TODO

[ ] identify places where such pattern can be used in the code
[ ] make changes in such places
[ ] create a PR
[ ] get it reviewed and merged
[ ] DONE

@mugdha-adhav Please add one of the labels mentioned here - https://github.com/warm-metal/csi-driver-image/blob/master/docs/automation.md#maintenance
Maybe help-wanted


Add hook to let an app 'burrow in' the viewer

The idea is to let developers use the viewer as a good-enough custom app to distribute to others. So that if an app calls 'burrow()' for example, it will be saved/stored somewhere and will be opened directly when the viewer is opened, so it looks a bit like it is a stand-alone cordova app built in the usual way.
Perhaps adding some kind of triple-tap menu or swipe motion that let the user bypass the app and get back to the regular viewer mode.
This could use/reuse the work done on the android client cache branch.

A related idea is to add bookmarks to the Viewer, to make it a browser for IoT apps.

Yes, that's also a good idea. But I think a subset of the functionality would make people very happy since they probably are looking for something that works just like just one, compiled actual app, but without the appstore hassles.

:+1:


Proteomics data (Evidence)

@MichaelaEBI commented on Tue Mar 06 2018
Proteomics data has been suggested several times for inclusion in the Open Targets platform. ProteomicsDB and MaxQB have been suggested as data sources.

[ ] Assess PRIDE, ProteomicsDB and MaxQB as potential data sources - what is the overlap between these repositories?
[ ] Are there other mass spec experiment repositories?
[ ] Extract, transform and load data
[ ] API and front end changes

We're expecting PRIDE to eventually provide data through ExpressionAtlas. We'll keep an eye on it


Move bugs over from ARPA repo

@mhuang-usdr is this actually done? I only see one ARPA-related issue in GOST repo, but there are 40 open issues in arpa-reporter.

Not yet - we have it scheduled for Tuesday. I had closed to clear clutter since we had time scheduled already, but to your point, will re-open :)


Added jazzy documentation

#3

Codecov Report

Merging #5 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master       #5   +/-   ##
=======================================
  Coverage   83.33%   83.33%
=======================================
  Files           1        1
  Lines          24       24
=======================================
  Hits           20       20
  Misses          4        4

Flag
Coverage Δ

#SwiftyBind
83.33% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14c1b82...05ca619. Read the comment docs.


Add sample code to DefaultTextStyleTransition

Description
DefaultTextStyleTransition didn't have sample code, so I added it.
Reference: https://api.flutter.dev/flutter/widgets/DefaultTextStyleTransition-class.html
Related Issues
N/A
Tests
N/A. Only the doc changed.
Checklist
Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

[x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
[x] I signed the [CLA].
[x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
[x] I read the [Tree Hygiene] wiki page, which explains my responsibilities.
[x] I updated/added relevant documentation (doc comments with ///).
[x] All existing and new tests are passing.
[x] The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
[x] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Did any tests fail when you ran them? Please read [Handling breaking changes].

[x] No, no existing tests failed, so this is not a breaking change.

Hi @ny927 would you like to update this PR?

@Piinks I updated my branch. Thank you for letting me know.


feat!: make import.meta.hot.send async

Description
The error that happened inside send method of ModuleRunnerTransport was not able to handle.
This PR fixes that by awaiting on the send method. This requires the import.meta.send to be also awaited (thus a breaking change). This await was not required because in Vite 5 we only used WS and WS's send is sync. In #18362, I made the ModuleRunnerTransport to allow async send just because I thought there may be a place that require async and didn't find any breaking change by doing so.
Alternative way to solve this is #18751.

/ecosystem-ci run

closing as #18753 was merged


Split passphrase prompt text into multiple strings.

Typically this will be a message describing the reason for the prompt
and an 'instruction' describing the what to enter.
For entering new passphrases there are separate 'newInstruction'
and 'repeatInstruction' prompts for the entry with confirmation,
the 'instruction' prompt in reserved for entering an existing
passphrase in the event the prompt is for changing a passphrase.

LGTM

Tested on device and works nicely, although with longer application and collection names, the (automatically opened) VKB sometimes overlaps over some of the label text (especially the second label is sometimes obscured).  I don't think this is a problem which should prevent this from being merged, however, but we might look at improving the UX somehow in the future.


Where to discuss version 1.2

Goal: Responding to problems where games can not continue

Retry at load error
Development of a standard plugin for options

Update the PluginManager or develop a core plugin.

as they suggested for the core plugin the idea got shotdown as I proposed tools for the peoples to use them.


SAMZA-2334: SSPGrouperProxy should check if job is stateful, not if host-affinity is enabled.

The current SSPGrouperProxy provides the capability for input partition counts to expand or contract by a multiple of the previous count. This is only need by stateful jobs. Currently the check for stateful jobs is to see if host-affinity is enabled. However, that is the wrong check because host-affinity does not imply a job is stateful.
The fix here is to check to see if the job has any local state stores rather than checking if host-affinity is enabled. The other part of the fix is to allow disabling the SSPGrouperProxy in the situation where the job cannot expand or contract the input partitions by an appropriate factor.
@prateekm @shanthoosh @dxichen

Closed to figure out the failing test.


njit(cache=True) is not idempotent  (with generators?)

I'm seeing that njit(cache=True) produces exceptions on its second run, where it succeeded in the first. It's not idempotent.
Run scratch.py. Success. Run again, long error.
The error goes away with this change:
#@numba.njit(nogil=True, cache=True)
@numba.njit(nogil=True, cache=False)
def posToRegion(x, y, w, h, size):...

(Run twice to be sure)
Possibly, calling a generator from numba causes the problem. I couldn't trigger the problem when calling the posToRegionPixelIndexes generator directly from python.
#File: scratch.py
import numpy as np
from scratch_b import *

import numba

w, h = 1920, 1080
apositions = np.array([[419, 848],
                       [419, 848],
                       [421, 851],
                       [621, 884]], dtype=np.int32)

@numba.njit(nogil=True, cache=False)
def _nearbyMatches(apos,
                   w, h,
                   ):
    for jpixIndex_ in posToRegionPixelIndexes(apos[0, 0], apos[0, 1], w, h):
        return

# No problem
# print(list(posToRegionPixelIndexes(apositions[0, 0], apositions[0, 1], w, h)))

print("_nearbyMatches")
# Fails
_nearbyMatches(apositions, 1920, 1080)
print("_nearbyMatches...")

#file: scratch_b.py
import numba

@numba.njit(nogil=True, cache=True)
def posToRegion(x, y, w, h, size):
    x0, x1 = x - size, x + size + 1
    y0, y1 = y - size, y + size + 1
    if x0 < 0: x0 = 0
    if y0 < 0: y0 = 0
    if x1 > w: x1 = w
    if y1 > h: y1 = h
    return (x0, x1), (y0, y1)

@numba.njit(nogil=True, cache=True)
def posToRegionPixelIndexes(x, y, w, h, size=2):
    (x0, x1), (y0, y1) = posToRegion(x, y, w, h, size)
    nrows, ncols = y1 - y0, x1 - x0
    rowstart = y0 * w + x0
    for _ in range(nrows):
        i = rowstart
        for _ in range(ncols):
            yield i
            i += 1
        rowstart += w

Numba: 0.56.4
Python 10
Traceback (most recent call last):
  File "/home/sir/venv/p310_opencv/lib/python3.10/site-packages/numba/core/errors.py", line 823, in new_error_context
    yield
  File "/home/sir/venv/p310_opencv/lib/python3.10/site-packages/numba/core/lowering.py", line 265, in lower_block
    self.lower_inst(inst)
  File "/home/sir/venv/p310_opencv/lib/python3.10/site-packages/numba/core/lowering.py", line 439, in lower_inst
    val = self.lower_assign(ty, inst)
  File "/home/sir/venv/p310_opencv/lib/python3.10/site-packages/numba/core/lowering.py", line 626, in lower_assign
    return self.lower_expr(ty, value)
  File "/home/sir/venv/p310_opencv/lib/python3.10/site-packages/numba/core/lowering.py", line 1186, in lower_expr
    res = impl(self.builder, (castval,))
  File "/home/sir/venv/p310_opencv/lib/python3.10/site-packages/numba/core/base.py", line 1190, in __call__
    res = self._imp(self._context, builder, self._sig, args, loc=loc)
  File "/home/sir/venv/p310_opencv/lib/python3.10/site-packages/numba/core/base.py", line 1220, in wrapper
    return fn(*args, **kwargs)
  File "/home/sir/venv/p310_opencv/lib/python3.10/site-packages/numba/core/imputils.py", line 336, in wrapper
    func(context, builder, sig, args,
  File "/home/sir/venv/p310_opencv/lib/python3.10/site-packages/numba/cpython/iterators.py", line 128, in iternext_zip
    impl = context.get_generator_impl(genty)
  File "/home/sir/venv/p310_opencv/lib/python3.10/site-packages/numba/core/base.py", line 571, in get_generator_impl
    res = self._generators[genty][1]
KeyError: int64 generator(func=<function posToRegionPixelIndexes at 0x7faae1f49120>, args=(int32, int32, int64, int64, omitted(default=2)), has_finalizer=True)

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/home/sir/venv/p310_opencv/lib/python3.10/site-packages/numba/core/dispatcher.py", line 487, in _compile_for_args
    raise e
  File "/home/sir/venv/p310_opencv/lib/python3.10/site-packages/numba/core/dispatcher.py", line 420, in _compile_for_args
    return_val = self.compile(tuple(argtypes))
  File "/home/sir/venv/p310_opencv/lib/python3.10/site-packages/numba/core/dispatcher.py", line 965, in compile
    cres = self._compiler.compile(args, return_type)
  File "/home/sir/venv/p310_opencv/lib/python3.10/site-packages/numba/core/dispatcher.py", line 125, in compile
    status, retval = self._compile_cached(args, return_type)
  File "/home/sir/venv/p310_opencv/lib/python3.10/site-packages/numba/core/dispatcher.py", line 139, in _compile_cached
    retval = self._compile_core(args, return_type)
  File "/home/sir/venv/p310_opencv/lib/python3.10/site-packages/numba/core/dispatcher.py", line 152, in _compile_core
    cres = compiler.compile_extra(self.targetdescr.typing_context,
  File "/home/sir/venv/p310_opencv/lib/python3.10/site-packages/numba/core/compiler.py", line 716, in compile_extra
    return pipeline.compile_extra(func)
  File "/home/sir/venv/p310_opencv/lib/python3.10/site-packages/numba/core/compiler.py", line 452, in compile_extra
    return self._compile_bytecode()
  File "/home/sir/venv/p310_opencv/lib/python3.10/site-packages/numba/core/compiler.py", line 520, in _compile_bytecode
    return self._compile_core()
  File "/home/sir/venv/p310_opencv/lib/python3.10/site-packages/numba/core/compiler.py", line 499, in _compile_core
    raise e
  File "/home/sir/venv/p310_opencv/lib/python3.10/site-packages/numba/core/compiler.py", line 486, in _compile_core
    pm.run(self.state)
  File "/home/sir/venv/p310_opencv/lib/python3.10/site-packages/numba/core/compiler_machinery.py", line 368, in run
    raise patched_exception
  File "/home/sir/venv/p310_opencv/lib/python3.10/site-packages/numba/core/compiler_machinery.py", line 356, in run
    self._runPass(idx, pass_inst, state)
  File "/home/sir/venv/p310_opencv/lib/python3.10/site-packages/numba/core/compiler_lock.py", line 35, in _acquire_compile_lock
    return func(*args, **kwargs)
  File "/home/sir/venv/p310_opencv/lib/python3.10/site-packages/numba/core/compiler_machinery.py", line 311, in _runPass
    mutated |= check(pss.run_pass, internal_state)
  File "/home/sir/venv/p310_opencv/lib/python3.10/site-packages/numba/core/compiler_machinery.py", line 273, in check
    mangled = func(compiler_state)
  File "/home/sir/venv/p310_opencv/lib/python3.10/site-packages/numba/core/typed_passes.py", line 394, in run_pass
    lower.lower()
  File "/home/sir/venv/p310_opencv/lib/python3.10/site-packages/numba/core/lowering.py", line 168, in lower
    self.lower_normal_function(self.fndesc)
  File "/home/sir/venv/p310_opencv/lib/python3.10/site-packages/numba/core/lowering.py", line 222, in lower_normal_function
    entry_block_tail = self.lower_function_body()
  File "/home/sir/venv/p310_opencv/lib/python3.10/site-packages/numba/core/lowering.py", line 251, in lower_function_body
    self.lower_block(block)
  File "/home/sir/venv/p310_opencv/lib/python3.10/site-packages/numba/core/lowering.py", line 263, in lower_block
    with new_error_context('lowering "{inst}" at {loc}', inst=inst,
  File "/usr/lib/python3.10/contextlib.py", line 153, in __exit__
    self.gen.throw(typ, value, traceback)
  File "/home/sir/venv/p310_opencv/lib/python3.10/site-packages/numba/core/errors.py", line 837, in new_error_context
    raise newerr.with_traceback(tb)
numba.core.errors.LoweringError: Failed in nopython mode pipeline (step: native lowering)
int64 generator(func=<function posToRegionPixelIndexes at 0x7faae1f49120>, args=(int32, int32, int64, int64, omitted(default=2)), has_finalizer=True)

File "scratch.py", line 16:
def _nearbyMatches(apos,
    <source elided>
                   ):
    for jpixIndex_ in posToRegionPixelIndexes(apos[0, 0], apos[0, 1], w, h):
    ^

During: lowering "$24for_iter.1 = iternext(value=$phi24.0)" at .../scratch.py (16)
Exception ignored in: <module 'threading' from '/usr/lib/python3.10/threading.py'>
Traceback (most recent call last):
  File "/usr/lib/python3.10/threading.py", line 1567, in _shutdown
    lock.acquire()
KeyboardInterrupt:

Thanks for the report and a nice reproducer - I can reproduce the issue.
As the Numba maintainers are out for the holidays this will be triaged during the triage meeting of 10th January 2023.

Actual fix might take a long time given the lack of resources, so stop gap might be to:

document that generators don't support caching; or,
disable caching on generators.


DEC-466 Open Seadragon Rotated images off center on retina displays.

What & why:
Update OpenSeadragon to 2.0.0.
Add window.devicePixelRatio setting to 1 to fix rotation mis-calculation on retina displays.

:+1:

:+1: Can that line be shortened? Since Jon gave the thumbs up, I can't argue with that but I don't feel qualified to judge the react code itself


Timeout in state 'timeout'

Sometimes, when database is slow and number of requests is big psql_connection is crushing because of message 'timeout' got in state 'timeout'. Is it a valid behaviour? I am using poolboy to store connections in gen_server and pgaql timeout is lesser than gen_servers timeout.

If you are using poolboy before 1.5.1 there is a bug which always times out when the pool is already fully used, you should look there first.


Strange Problem...Massive Ocelot Spawn?

Okay....i have tried again to play with my Moondew Vallay Pack (little bit self updatet because of owner not active anymore) and have strange issues with ocelots..
When i come to a jungle like biome...or an sacred spring biome too...massive amounts of ocelots are spawning.
Have tried out now several hours whats can cause this bug....have made a new instance in twitch...only with rtg...biomes o plenty, jouneymap and jei ( i would try the same world generation because i thought its maybe one of this mods...)...all okay in the sacred springs....only 2 ocelots or so...
then i have added harvest festival....bäämmmm 50 ocelots or so...
i dont know whats wrong...but the bug must be something to do with harvest festival...i dont know if its old...or no
maybe anyone else have seen this?
The Problem does not appear in the latest 05 Version... in the last two Versions from 0.6 it does. Dont know what is with Versions before...have only testet the 05er and the two last 06er

Was resolved after conversation on Discord.


Move state endpoint to beacon namespace

The /eth/v2/debug/beacon/states/{state_id} endpoint is widely used by regular users and as such should probably not be present in the debug namespace. I think the original reason for putting it there was the large size of the response, but currently requesting all validators from /eth/v1/beacon/states/head/validators results in an even larger response.
This PR:

creates a new /eth/v1/beacon/states/{state_id} endpoint (the debug version is v2, but since we are moving it to a new namespace, in my opinion versioning should start anew)
deprecates the debug endpoint

Uh, this was merged a bit quickly without time for feedback, but the condition we've discussed in the past for having the state endpoint in the official part of the api was to limit it to SSZ only - I think that change should be made, ie it's not feasible to create an expectation that client open up providing JSON for the state, which soon will reach GB sizes.

There was also discussion of fixing the flags encoding for json which is irregular with respect to its underlying intent.

sorry @rkapka can you re-open a pull request for this to allow discussion to happen? I've reverted it from master after out of band discussions.


API should tell clients how many requests they have left

For example, add headers like Retry-After, RateLimit-Remaining and RateLimit-Limit

Done. Will go live with v2.2.3


AshPostgres.polymorphic?/1 is undefined

Describe the bug
It seems that for some reason AshAdmin is dependent on AshPostgres
To Reproduce
Set up a minimal project with ets data layer
Expected behavior
AshAdmin should work on any datalayer
** Runtime

Elixir version 1.13.4
Erlang version 25 [erts-13.0.3]
OS macOS 12.3.1
Ash version 1.53.3
AshAdmin version 0.5.2

Ah, interesting. So what I suspect is happening here is that you are on a newer version of ash_postgres than of ash_admin.
  if Code.ensure_compiled(AshPostgres) do
    def polymorphic?(resource) do
      AshPostgres.DataLayer.Info.polymorphic?(resource)
    end
  else
    def polymorphic?(_), do: false
  end

This may be something that needs to be released, could you try ensuring you're on the latest hex dependency for ash_admin (especially if you are using ash_postgres 1.0.0-rc), and also try main of ash_admin?

I wasn't using ash_postgres until I've got the error.
But adding it fixed the problem

Same problem on
{:ash, "~> 2.0.0-rc.0"},
{:ash_admin, "~> 0.6.0-rc.0"},

ohhhh. Yeah okay I have a fix :)

Could you try the main branch?

Now it does not compile, tells that admin in my api is undefined
  admin do
    show? true
  end

and I've got really long list of warnings:
Compiling 17 files (.ex)
warning: Spark.DocIndex.__using__/1 defined in application :spark is used by the current application but the current application does not depend on :spark. To fix this, you must do one of:

  1. If :spark is part of Erlang/Elixir, you must include it under :extra_applications inside "def application" in your mix.exs

  2. If :spark is a dependency, make sure it is listed under "def deps" in your mix.exs

  3. In case you don't want to add a requirement to :spark, you may optionally skip this warning by adding [xref: [exclude: [Spark.DocIndex]]] to your "def project" in mix.exs

  lib/doc_index.ex:4: AshPhoenix.DocIndex

warning: Spark.DocIndex.behaviour_info/1 defined in application :spark is used by the current application but the current application does not depend on :spark. To fix this, you must do one of:

  1. If :spark is part of Erlang/Elixir, you must include it under :extra_applications inside "def application" in your mix.exs

  2. If :spark is a dependency, make sure it is listed under "def deps" in your mix.exs

  3. In case you don't want to add a requirement to :spark, you may optionally skip this warning by adding [xref: [exclude: [Spark.DocIndex]]] to your "def project" in mix.exs

  lib/doc_index.ex:1: AshPhoenix.DocIndex.__info__/1

warning: Spark.DocIndex.to_name/1 defined in application :spark is used by the current application but the current application does not depend on :spark. To fix this, you must do one of:

  1. If :spark is part of Erlang/Elixir, you must include it under :extra_applications inside "def application" in your mix.exs

  2. If :spark is a dependency, make sure it is listed under "def deps" in your mix.exs

  3. In case you don't want to add a requirement to :spark, you may optionally skip this warning by adding [xref: [exclude: [Spark.DocIndex]]] to your "def project" in mix.exs

  lib/doc_index.ex:4: AshPhoenix.DocIndex

warning: Spark.DocIndex.to_path/1 defined in application :spark is used by the current application but the current application does not depend on :spark. To fix this, you must do one of:

  1. If :spark is part of Erlang/Elixir, you must include it under :extra_applications inside "def application" in your mix.exs

  2. If :spark is a dependency, make sure it is listed under "def deps" in your mix.exs

  3. In case you don't want to add a requirement to :spark, you may optionally skip this warning by adding [xref: [exclude: [Spark.DocIndex]]] to your "def project" in mix.exs

  lib/doc_index.ex:4: AshPhoenix.DocIndex

warning: Spark.OptionsHelpers.docs/1 defined in application :spark is used by the current application but the current application does not depend on :spark. To fix this, you must do one of:

  1. If :spark is part of Erlang/Elixir, you must include it under :extra_applications inside "def application" in your mix.exs

  2. If :spark is a dependency, make sure it is listed under "def deps" in your mix.exs

  3. In case you don't want to add a requirement to :spark, you may optionally skip this warning by adding [xref: [exclude: [Spark.OptionsHelpers]]] to your "def project" in mix.exs

Invalid call found at 15 locations:
  lib/ash_phoenix/filter_form/filter_form.ex:54: AshPhoenix.FilterForm
  lib/ash_phoenix/filter_form/filter_form.ex:522: AshPhoenix.FilterForm
  lib/ash_phoenix/filter_form/filter_form.ex:684: AshPhoenix.FilterForm
  lib/ash_phoenix/form/form.ex:394: AshPhoenix.Form
  lib/ash_phoenix/form/form.ex:407: AshPhoenix.Form
  lib/ash_phoenix/form/form.ex:481: AshPhoenix.Form
  lib/ash_phoenix/form/form.ex:563: AshPhoenix.Form
  lib/ash_phoenix/form/form.ex:645: AshPhoenix.Form
  lib/ash_phoenix/form/form.ex:656: AshPhoenix.Form
  lib/ash_phoenix/form/form.ex:798: AshPhoenix.Form
  lib/ash_phoenix/form/form.ex:1324: AshPhoenix.Form
  lib/ash_phoenix/form/form.ex:1701: AshPhoenix.Form
  lib/ash_phoenix/form/form.ex:2132: AshPhoenix.Form
  lib/ash_phoenix/form/form.ex:2181: AshPhoenix.Form
  lib/ash_phoenix/plug/subdomain_plug.ex:29: AshPhoenix.SubdomainPlug

warning: Spark.OptionsHelpers.validate!/2 defined in application :spark is used by the current application but the current application does not depend on :spark. To fix this, you must do one of:

  1. If :spark is part of Erlang/Elixir, you must include it under :extra_applications inside "def application" in your mix.exs

  2. If :spark is a dependency, make sure it is listed under "def deps" in your mix.exs

  3. In case you don't want to add a requirement to :spark, you may optionally skip this warning by adding [xref: [exclude: [Spark.OptionsHelpers]]] to your "def project" in mix.exs

Invalid call found at 9 locations:
  lib/ash_phoenix/filter_form/filter_form.ex:57: AshPhoenix.FilterForm.new/2
  lib/ash_phoenix/filter_form/filter_form.ex:525: AshPhoenix.FilterForm.add_predicate/5
  lib/ash_phoenix/filter_form/filter_form.ex:687: AshPhoenix.FilterForm.add_group/2
  lib/ash_phoenix/form/auto.ex:85: AshPhoenix.Form.Auto.auto/3
  lib/ash_phoenix/form/form.ex:353: AshPhoenix.Form.validate_opts_with_extra_keys/2
  lib/ash_phoenix/form/form.ex:1537: AshPhoenix.Form.update_form/4
  lib/ash_phoenix/form/form.ex:2136: AshPhoenix.Form.add_form/3
  lib/ash_phoenix/form/form.ex:2184: AshPhoenix.Form.remove_form/3
  lib/ash_phoenix/plug/subdomain_plug.ex:61: AshPhoenix.SubdomainPlug.init/1

warning: Ash.Filter.get_function/3 is undefined or private. Did you mean:

      * get_function/2

Invalid call found at 2 locations:
  lib/ash_phoenix/filter_form/filter_form.ex:239: AshPhoenix.FilterForm.do_to_filter_expression/2
  lib/ash_phoenix/filter_form/filter_form.ex:638: AshPhoenix.FilterForm.predicate_errors/2

warning: Ash.Api.Info.resource/2 is undefined (module Ash.Api.Info is not available or is yet to be defined)
  lib/ash_phoenix/form/form.ex:1362: AshPhoenix.Form.submit/2

Generated ash_phoenix app
==> ash_admin
Compiling 29 files (.ex)
warning: Spark.Dsl.Extension.__using__/1 defined in application :spark is used by the current application but the current application does not depend on :spark. To fix this, you must do one of:

  1. If :spark is part of Erlang/Elixir, you must include it under :extra_applications inside "def application" in your mix.exs

  2. If :spark is a dependency, make sure it is listed under "def deps" in your mix.exs

  3. In case you don't want to add a requirement to :spark, you may optionally skip this warning by adding [xref: [exclude: [Spark.Dsl.Extension]]] to your "def project" in mix.exs

Invalid call found at 2 locations:
  lib/ash_admin/api.ex:31: AshAdmin.Api
  lib/ash_admin/resource/resource.ex:84: AshAdmin.Resource

warning: Spark.Dsl.Extension.behaviour_info/1 defined in application :spark is used by the current application but the current application does not depend on :spark. To fix this, you must do one of:

  1. If :spark is part of Erlang/Elixir, you must include it under :extra_applications inside "def application" in your mix.exs

  2. If :spark is a dependency, make sure it is listed under "def deps" in your mix.exs

  3. In case you don't want to add a requirement to :spark, you may optionally skip this warning by adding [xref: [exclude: [Spark.Dsl.Extension]]] to your "def project" in mix.exs

Invalid call found at 2 locations:
  lib/ash_admin/api.ex:1: AshAdmin.Api.__info__/1
  lib/ash_admin/resource/resource.ex:1: AshAdmin.Resource.__info__/1

warning: Spark.Dsl.Extension.build/3 defined in application :spark is used by the current application but the current application does not depend on :spark. To fix this, you must do one of:

  1. If :spark is part of Erlang/Elixir, you must include it under :extra_applications inside "def application" in your mix.exs

  2. If :spark is a dependency, make sure it is listed under "def deps" in your mix.exs

  3. In case you don't want to add a requirement to :spark, you may optionally skip this warning by adding [xref: [exclude: [Spark.Dsl.Extension]]] to your "def project" in mix.exs

Invalid call found at 2 locations:
  lib/ash_admin/api.ex:31: AshAdmin.Api
  lib/ash_admin/resource/resource.ex:84: AshAdmin.Resource

warning: Spark.Dsl.Extension.build_section/5 defined in application :spark is used by the current application but the current application does not depend on :spark. To fix this, you must do one of:

  1. If :spark is part of Erlang/Elixir, you must include it under :extra_applications inside "def application" in your mix.exs

  2. If :spark is a dependency, make sure it is listed under "def deps" in your mix.exs

  3. In case you don't want to add a requirement to :spark, you may optionally skip this warning by adding [xref: [exclude: [Spark.Dsl.Extension]]] to your "def project" in mix.exs

Invalid call found at 2 locations:
  lib/ash_admin/api.ex:31: AshAdmin.Api
  lib/ash_admin/resource/resource.ex:84: AshAdmin.Resource

warning: Spark.Dsl.Extension.do_build_section/5 defined in application :spark is used by the current application but the current application does not depend on :spark. To fix this, you must do one of:

  1. If :spark is part of Erlang/Elixir, you must include it under :extra_applications inside "def application" in your mix.exs

  2. If :spark is a dependency, make sure it is listed under "def deps" in your mix.exs

  3. In case you don't want to add a requirement to :spark, you may optionally skip this warning by adding [xref: [exclude: [Spark.Dsl.Extension]]] to your "def project" in mix.exs

Invalid call found at 2 locations:
  lib/ash_admin/api.ex:31: AshAdmin.Api
  lib/ash_admin/resource/resource.ex:84: AshAdmin.Resource

warning: Spark.Dsl.Extension.doc/1 defined in application :spark is used by the current application but the current application does not depend on :spark. To fix this, you must do one of:

  1. If :spark is part of Erlang/Elixir, you must include it under :extra_applications inside "def application" in your mix.exs

  2. If :spark is a dependency, make sure it is listed under "def deps" in your mix.exs

  3. In case you don't want to add a requirement to :spark, you may optionally skip this warning by adding [xref: [exclude: [Spark.Dsl.Extension]]] to your "def project" in mix.exs

Invalid call found at 2 locations:
  lib/ash_admin/api.ex:41: AshAdmin.Api
  lib/ash_admin/resource/resource.ex:96: AshAdmin.Resource

warning: Spark.Dsl.Extension.doc_entity/1 defined in application :spark is used by the current application but the current application does not depend on :spark. To fix this, you must do one of:

  1. If :spark is part of Erlang/Elixir, you must include it under :extra_applications inside "def application" in your mix.exs

  2. If :spark is a dependency, make sure it is listed under "def deps" in your mix.exs

  3. In case you don't want to add a requirement to :spark, you may optionally skip this warning by adding [xref: [exclude: [Spark.Dsl.Extension]]] to your "def project" in mix.exs

Invalid call found at 2 locations:
  lib/ash_admin/api.ex:31: AshAdmin.Api.set_docs/1
  lib/ash_admin/resource/resource.ex:84: AshAdmin.Resource.set_docs/1

warning: Spark.Dsl.Extension.doc_index/1 defined in application :spark is used by the current application but the current application does not depend on :spark. To fix this, you must do one of:

  1. If :spark is part of Erlang/Elixir, you must include it under :extra_applications inside "def application" in your mix.exs

  2. If :spark is a dependency, make sure it is listed under "def deps" in your mix.exs

  3. In case you don't want to add a requirement to :spark, you may optionally skip this warning by adding [xref: [exclude: [Spark.Dsl.Extension]]] to your "def project" in mix.exs

Invalid call found at 2 locations:
  lib/ash_admin/api.ex:37: AshAdmin.Api
  lib/ash_admin/resource/resource.ex:92: AshAdmin.Resource

warning: Spark.Dsl.Extension.doc_section/1 defined in application :spark is used by the current application but the current application does not depend on :spark. To fix this, you must do one of:

  1. If :spark is part of Erlang/Elixir, you must include it under :extra_applications inside "def application" in your mix.exs

  2. If :spark is a dependency, make sure it is listed under "def deps" in your mix.exs

  3. In case you don't want to add a requirement to :spark, you may optionally skip this warning by adding [xref: [exclude: [Spark.Dsl.Extension]]] to your "def project" in mix.exs

Invalid call found at 2 locations:
  lib/ash_admin/api.ex:31: AshAdmin.Api.set_docs/1
  lib/ash_admin/resource/resource.ex:84: AshAdmin.Resource.set_docs/1

warning: Spark.Dsl.Extension.get_entities/2 defined in application :spark is used by the current application but the current application does not depend on :spark. To fix this, you must do one of:

  1. If :spark is part of Erlang/Elixir, you must include it under :extra_applications inside "def application" in your mix.exs

  2. If :spark is a dependency, make sure it is listed under "def deps" in your mix.exs

  3. In case you don't want to add a requirement to :spark, you may optionally skip this warning by adding [xref: [exclude: [Spark.Dsl.Extension]]] to your "def project" in mix.exs

  lib/ash_admin/resource/resource.ex:171: AshAdmin.Resource.fields/1

warning: Spark.Dsl.Extension.get_opt/5 defined in application :spark is used by the current application but the current application does not depend on :spark. To fix this, you must do one of:

  1. If :spark is part of Erlang/Elixir, you must include it under :extra_applications inside "def application" in your mix.exs

  2. If :spark is a dependency, make sure it is listed under "def deps" in your mix.exs

  3. In case you don't want to add a requirement to :spark, you may optionally skip this warning by adding [xref: [exclude: [Spark.Dsl.Extension]]] to your "def project" in mix.exs

Invalid call found at 16 locations:
  lib/ash_admin/api.ex:45: AshAdmin.Api.name/1
  lib/ash_admin/api.ex:49: AshAdmin.Api.show?/1
  lib/ash_admin/api.ex:53: AshAdmin.Api.default_resource_page/1
  lib/ash_admin/api.ex:57: AshAdmin.Api.resource_group_labels/1
  lib/ash_admin/resource/resource.ex:111: AshAdmin.Resource.polymorphic_tables/2
  lib/ash_admin/resource/resource.ex:117: AshAdmin.Resource.relationship_display_fields/1
  lib/ash_admin/resource/resource.ex:121: AshAdmin.Resource.table_columns/1
  lib/ash_admin/resource/resource.ex:125: AshAdmin.Resource.format_fields/1
  lib/ash_admin/resource/resource.ex:129: AshAdmin.Resource.name/1
  lib/ash_admin/resource/resource.ex:136: AshAdmin.Resource.resource_group/1
  lib/ash_admin/resource/resource.ex:140: AshAdmin.Resource.actor?/1
  lib/ash_admin/resource/resource.ex:144: AshAdmin.Resource.read_actions/1
  lib/ash_admin/resource/resource.ex:148: AshAdmin.Resource.create_actions/1
  lib/ash_admin/resource/resource.ex:152: AshAdmin.Resource.update_actions/1
  lib/ash_admin/resource/resource.ex:156: AshAdmin.Resource.destroy_actions/1
  lib/ash_admin/resource/resource.ex:160: AshAdmin.Resource.show_action/1

warning: Spark.Dsl.Transformer.__using__/1 defined in application :spark is used by the current application but the current application does not depend on :spark. To fix this, you must do one of:

  1. If :spark is part of Erlang/Elixir, you must include it under :extra_applications inside "def application" in your mix.exs

  2. If :spark is a dependency, make sure it is listed under "def deps" in your mix.exs

  3. In case you don't want to add a requirement to :spark, you may optionally skip this warning by adding [xref: [exclude: [Spark.Dsl.Transformer]]] to your "def project" in mix.exs

  lib/ash_admin/resource/transformers/validate_table_columns.ex:3: AshAdmin.Resource.Transformers.ValidateTableColumns

warning: Spark.Dsl.Transformer.behaviour_info/1 defined in application :spark is used by the current application but the current application does not depend on :spark. To fix this, you must do one of:

  1. If :spark is part of Erlang/Elixir, you must include it under :extra_applications inside "def application" in your mix.exs

  2. If :spark is a dependency, make sure it is listed under "def deps" in your mix.exs

  3. In case you don't want to add a requirement to :spark, you may optionally skip this warning by adding [xref: [exclude: [Spark.Dsl.Transformer]]] to your "def project" in mix.exs

  lib/ash_admin/resource/transformers/validate_table_columns.ex:1: AshAdmin.Resource.Transformers.ValidateTableColumns.__info__/1

warning: Spark.Dsl.Transformer.get_entities/2 defined in application :spark is used by the current application but the current application does not depend on :spark. To fix this, you must do one of:

  1. If :spark is part of Erlang/Elixir, you must include it under :extra_applications inside "def application" in your mix.exs

  2. If :spark is a dependency, make sure it is listed under "def deps" in your mix.exs

  3. In case you don't want to add a requirement to :spark, you may optionally skip this warning by adding [xref: [exclude: [Spark.Dsl.Transformer]]] to your "def project" in mix.exs

Invalid call found at 2 locations:
  lib/ash_admin/resource/transformers/validate_table_columns.ex:9: AshAdmin.Resource.Transformers.ValidateTableColumns.transform/1
  lib/ash_admin/resource/transformers/validate_table_columns.ex:15: AshAdmin.Resource.Transformers.ValidateTableColumns.transform/1

warning: Spark.Dsl.Transformer.get_option/3 defined in application :spark is used by the current application but the current application does not depend on :spark. To fix this, you must do one of:

  1. If :spark is part of Erlang/Elixir, you must include it under :extra_applications inside "def application" in your mix.exs

  2. If :spark is a dependency, make sure it is listed under "def deps" in your mix.exs

  3. In case you don't want to add a requirement to :spark, you may optionally skip this warning by adding [xref: [exclude: [Spark.Dsl.Transformer]]] to your "def project" in mix.exs

  lib/ash_admin/resource/transformers/validate_table_columns.ex:22: AshAdmin.Resource.Transformers.ValidateTableColumns.transform/1

warning: Ash.Api.Info.resources/1 is undefined (module Ash.Api.Info is not available or is yet to be defined)
  lib/ash_admin/actor_plug.ex:88: AshAdmin.ActorPlug.actor_from_session/2

warning: Ash.Api.Info.resources/1 is undefined (module Ash.Api.Info is not available or is yet to be defined)
  lib/ash_admin/resource/resource.ex:184: AshAdmin.Resource.find_polymorphic_tables/2

warning: AshPostgres.DataLayer.Info.polymorphic?/1 is undefined (module AshPostgres.DataLayer.Info is not available or is yet to be defined)
  lib/ash_admin/resource/resource.ex:102: AshAdmin.Resource.polymorphic?/1

warning: Ash.Api.Info.resources/1 is undefined (module Ash.Api.Info is not available or is yet to be defined)
Invalid call found at 2 locations:
  lib/ash_admin/pages/page_live.ex:106: AshAdmin.PageLive.actor_resources/1
  lib/ash_admin/pages/page_live.ex:130: AshAdmin.PageLive.assign_resource/2

warning: Ash.Api.Info.resources/1 is undefined (module Ash.Api.Info is not available or is yet to be defined)
Invalid call found at 2 locations:
  lib/ash_admin/components/top_nav.ex:144: AshAdmin.Components.TopNav.dropdown_groups/3
  lib/ash_admin/components/top_nav.ex:177: AshAdmin.Components.TopNav.show_tenant_form?/1

PS just noticed that not all of them related to ash_admin

Something strange is definitely going on here... Have you used extensions: [AshAdmin.Api] in your API? I think there are newer release candidates for each project, can you make sure you are on those for ash and ash_postgres?

Have you used extensions: [AshAdmin.Api] in your API?

I did

I think there are newer release candidates for each project, can you make sure you are on those for ash and ash_postgres?

Perhaps that happened bcs I overridden ash version

It might be simplest to try a pass at using everything from main. That isn't the ideal solution for the long term, but would let me determine if there is something I need to fix remaining, or if it is just a matter of getting new release candidates shipped for everything and using those. We're in our last bit of flux before 2.0 comes out :)

We can definitely do that (its a bit more complicated than moving polymorphic?, its more like adding required_data_layer_context or something along those lines). Will need changes in both ash and ash_postgres.
With that said, which problem still persists in main? It saying that admin does not exist? or it still calling polymorphic?

Polymorphic problem, admin absence seems to be result of version mismatch.
Versions:
{:ash, github: "ash-project/ash", override: true},
{:ash_admin, github: "ash-project/ash_admin"},

and what version is ash_admin?

Sorry to be a pain 😢 Its unrealistic that I'll fix the generalized issue of polymorphic? being called here, so the only short term answer is to fix that problem.

Ah, wow, I can't read.

Have you made sure to do mix deps.update ash ash_admin to pull the latest main and get my new changes to ash_admin?

Have you made sure to do mix deps.update ash ash_admin to pull the latest main and get my new changes to ash_admin?

I did now, and still the same results.
BTW you can use apply to get rid of the warning
warning: AshPostgres.DataLayer.Info.polymorphic?/1 is undefined (module AshPostgres.DataLayer.Info is not available or is yet to be defined)
  lib/ash_admin/resource/resource.ex:102: AshAdmin.Resource.polymorphic?/1

and what version is ash_admin?

My mix.lock:
"ash": {:git, "https://github.com/ash-project/ash.git", "9ddc2aeb0dfabdea89ad81669249be2bbb70eafb", []},
  "ash_admin": {:git, "https://github.com/ash-project/ash_admin.git", "8d841c597a33168a9ee1841f0c7338fd7192fd8d", []},

That warning looks like its different from your original error (its now pointing at AshPostgres.DataLayer.Info.polymorphic? instead of AshPostgres.polymorphic?. I'm confused how you could be getting into that code block without that function being defined. Perhaps a mix deps.clean ash_postgres or something along those lines? Or force recompiling the dependencies? mix deps.compile ash ash_admin --force?

Yep, the undefined function is AshPostgres.DataLayer.Info.polymorphic?/1 now, and cleaning or recompiling does not help.

🤔 Going to get something running w/o postgres here shortly and figure out what is going on

Okay, so what I've done is simply determined wether or not any "polymorphic_tables" have been configured for a given resource, without checking if its polymorphic before hand. Its not perfect, but its a simple way around the issue for now that should clean things up.

Please reopen if the issue persists after trying out main in some way. Thanks for reporting the issue!


Feature-SBTest

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Describe the solution you'd like
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

Excellent - so Tasks are draft and Issues are real?


MIDI clock slave mode: fix timing and note-off behavior

play() will reset both frame and pulse counts to 0, for alignment
stop() will silence
tap() will update immediately upon play(), not on the next frame

@unthingable I notice the Clock.untap function (untouched in your PR) resets the count to 1 where I'd expect it to be reset to 0. This means the counter starts at 1 when MIDI clock signal stops. Don't think it matters much, but do you think this is on purpose?

@unthingable I looked up the MIDI specification about the MIDI clock, and the change seems to implement how start and stop was intended:
"The master needs to be able to start the slave precisely when the master starts. The master does this by sending a MIDI Start message. The MIDI Start message alerts the slave that, upon receipt of the very next MIDI Clock message, the slave should start the playback of its sequence." (midi.teragonaudio.com/tech/midispec/seq.htm)
I think the if (pulse.count == 0) { client.run() } in Clock.tap() implements this requirement, correct?
Also, the PR implements the following rule:
"If a slave receives MIDI Start or MIDI Continue messages while it’s in play, it should ignore those messages. Likewise, if it receives MIDI Stop messages while stopped, it ignores those. "
I ran a first test of this branch with TidalCycles and Orca seems to respond nicely. I'll play around with it a little bit more (mayble also with Ableton) to see if clock sync has become as predictable as I expect it to be now.
Thanks!

@unthingable When I use MIDI start and stop messages, beat syncing indeed seems to work nicely. However, when I use space to pause and resume Orca, the beat starts at the moment I pressed space. So, it forgets its alignment with the original MIDI start message that intentionally reset the counter to 0.
Since Clock.tap() keeps running while Orca is paused at the moment MIDI clock messages are coming in, we should probably treat manual pause/resume with space differently. For instance by leaving the counter running in the background while Orca is paused. For this, we should separate the handing of start and stop MIDI messages and manual pause/resume toggling.
What do you think?

@njanssen thank you for the thorough read and for for digging up the standards.

I notice the Clock.untap function (untouched in your PR) resets the count to 1

Oops, I missed that one. Here play() resets the count so whatever untap() did with that wouldn't be noticeable. Also, it seems untap() is called only when clock stops arriving, in which case we're done slaving altogether.
I don't fully understand the intent behind original pulse.count math: untap sets it to 1, tap increments it again and only then checks for 0 mod 6 and increments the frame. So if frames are incremented every 6th pulse starting at 0, and beats happen every X frames, and pulse count is never reset, and when play() is triggered the pulse count is most likely not a multiple of 6, then it's really hard to get a beat in sync with master — it's going to be off by some undetermined number of pulses.

The MIDI Start message alerts the slave that, upon receipt of the very next MIDI Clock message

That is an interesting detail!
🤔 Sounds like play() should be setting pulse.count to 5 instead of 0 (and definitely not 1). This could explain the 40ms delay I'm seeing. Will need to play around with it a little more.

Also, the PR implements the following rule: "If a slave receives MIDI Start or MIDI Continue messages while it’s in play, it should ignore those messages...

I believe that was already implemented, play and stop check isPaused before doing anything.

@unthingable When I use MIDI start and stop messages, beat syncing indeed seems to work nicely.

👍

However, when I use space to pause and resume Orca, the beat starts at the moment I pressed space. So, it forgets its alignment with the original MIDI start message that intentionally reset the counter to 0. ... we should probably treat manual pause/resume with space differently. For instance by leaving the counter running

Nice catch, I ignored that use case and focused on starting and stopping Orca from clock master, primarily because this is nontrivial to solve. But if we were to solve it...
The problem is not only we'd have to count pulses in the background, we also need to count phantom frames. Otherwise, for example, let's say Orca was stopped on pulse 4 and started on pulse 8, so we didn't advance the frame that would have happened on pulse 6. Next frame advance will happen on pulse 12 — in alignment with pulse count but we're now 1 frame behind the clock and our beats are out of alignment.
So, a possible solution: we count pulses and frames in the background, and then once Orca is unpaused, the next frame update sets the frame number to what it would have been as if Orca was playing all this time. It will be almost like we muted Orca, but with weirdness: clock-based things (D, C, etc.) will be in sync with the background clock, others (I, E/W/S/N, etc.) will not. I can try adding this, my guess you probably won't want to use space for pausing because your composition won't come back the same.
The other solution is to not pause Orca when slaved :) No harm in having both available.

@njanssen I did it! And it's more useful than I pessimistically predicted :-D
In summary:

Stopped Orca stays in sync with MIDI master
Stopping master stops Orca, notes off
Starting master starts Orca (if stopped)
Playing Orca re-syncs on MIDI clock PLAY

I'm a tiny bit unsure about that last one, it is going beyond the MIDI standard and further reinforces the assumption that master always sends START on the beat. Then again, I'm looking at my Novation Circuit, it always assumes that and it ignores START when playing, I wish it didn't (but it does handle SPP, achieving the same goal and a little more).
I can't shake the feeling that this is a little too janky, but maybe that's ok. A more standard-friendly way would be to synchronize to SPP instead of clock START, but I don't remember TidalCycles sending SPP, does it?

I did it! And it's more useful than I pessimistically predicted :-D

Nice! I tried it out, and the only issue I ran into was timing offsets which I could solve by setting MIDI latency in SuperCollider or by using nudge in TidalCycles. As soon as things were lined up, I could get a steady beat sync on (1) manual pause/resume in the Orca UI with space and (2) starting/stopping MIDI clock.

I don't remember TidalCycles sending SPP, does it?

No, TidalCycles doesn't keep track of time in terms of seconds, has its own internal cycle count. The standard way of controlling midi clock is with start messages (i.e. send a start command at the beginning of a cycle), see also https://tidalcycles.org/index.php/MIDI_Clock
Thanks for working on this PR, I'm going to merge it in 👍

Yay!

only issue I ran into was timing offsets which I could solve by setting MIDI latency in SuperCollider

Yeah, I played with different initial pulse count values to see if it would help line up with the beat without additional latency at the source and it didn't, it was always off by some other much larger amount. The current solution produces best results.
My naive assumption is that my pulse math is correct and there is some inherent latency somewhere in the chain (in my case, Bitwig sending clock -> IAC transmitting clock -> Electron reacting to MIDI -> Electron emitting MIDI -> IAC transmitting event -> Bitwig reacting to event), this wouldn't be surprising. The good news is the latency seems consistent, I'm getting repeatable solid sync with a 40ms offset.


Add policy documentation

In registry 2.6 we are adding more policies to the configuration. We need documentation recipes mentioning how to setup and decide on these policies. Also need further explanation on the use of the policies and meaning to the registry users.

Do we agree that the relevant option are these policies: https://github.com/docker/distribution/blob/607ae5d128a82f280e8c7f453d5fb30c535bda17/configuration/configuration.go#L221 ?


work_in_progress.md not up2date with shared folders

shared folders came with tp4 and are already part of the documentation, so that part in here needs updates:
Virtualization-Documentation / virtualization / windowscontainers / about / work_in_progress.md

`All non-C:/ drives are visible in containers
All non-C:/ drives available to the container host are automatically mapped into new running Windows Containers.
At this point in time there is no way to selectively map folders into a container, as an interim work around drives are mapped automatically.
*Work Around: *
We're working on it. In the future there will be folder sharing.
`

Thanks for the catch - I will get the docs updated.

https://msdn.microsoft.com/en-us/virtualization/windowscontainers/about/work_in_progress

only curious: why does that edit not occur in github history? Or did I miss it?

We have a private and public repo which are kept in sync, however there is a delay in this sync action. The history will eventually merge up. The published docs themselves are built from the private repo.

thank you for explaining!


WIP: CNV-23418: unsupported escape hatch mechanism custom HS/KV vms

Suport the new HostedCluster/NodePool annotation
"hypershift.openshift.io/kubevirt-vm-jsonpatch", to modify the KubeVirt VM template using jsonpatch string.

What this PR does / why we need it:
Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #
Checklist

[ ] Subject and description added to both, commit and PR.
[ ] Relevant issues have been referenced.
[ ] This change includes docs.
[ ] This change includes unit tests.

/hold
WIP

/unhold


fix(stats): Move CSS classes definition to widget from component

We can now easily spot in default.css which widget are not yet
BEMified (yeah, that's a verb now).

Moved the BEM definition to widget instead of component
Updated the tests
This widget is using the headerFooter decorator, I updated the docs
The initial root class was added twice because we already used it in the default template. I removed the wrapping div in the template.

BREAKING CHANGE: cssClasses.root now applies to the main root
element (above header and footer) and no longer to the template
wrapper. To style the template wrapper, use cssClasses.body

ready for merge?

Commit message has same text than https://github.com/algolia/instantsearch.js/pull/291, is that ok?

Same text? I see that for this PR:

And that for the other one:

Seems ok to me.

Yes I get it's just the "We can now easily spot in default.css which widget are not yet
BEMified (yeah, that's a verb now)." that is in both PR and commits

Oh yes, sorry it should not be here. I locally rebased in the wrong order and got some commit message merged.

No big deal :)


selected file can not be opend with a double click, only on the context Menue, with selecting open with.

Hey, I'm using Files 0.21.0. Its a very cool tool, thanks.
Sinc the last update I have the impression, that you can not open a fiel on double-Clicking on it. YOu have to go the contextmenu an select ther "open with-..."

@icsholderegger Can you check if the "open items with a single click" setting is one?

I have same bug but only when I have it sorted by type or size.

This code seems to cause bug.
DefaultQuery can't work because it's always overwritten(?) with null property (or just adding null causes problems) from sortEntry.PropertyName

Files/Interacts/Interaction.cs

QueryOptions queryOptions = new QueryOptions(CommonFileQuery.DefaultQuery, null);

// (...)

var sortOption = AppSettings.DirectorySortOption;

switch (sortOption)
{
	case Enums.SortOption.Name:
		sortEntry.PropertyName = "System.ItemNameDisplay";
		queryOptions.SortOrder.Clear();
		break;

	case Enums.SortOption.DateModified:
		sortEntry.PropertyName = "System.DateModified";
		queryOptions.SortOrder.Clear();
		break;

	case Enums.SortOption.Size:
		//Unfortunately this is unsupported | Remarks: https://docs.microsoft.com/en-us/uwp/api/windows.storage.search.queryoptions.sortorder?view=winrt-19041

		//sortEntry.PropertyName = "System.TotalFileSize";
		//queryOptions.SortOrder.Clear();
		break;

	case Enums.SortOption.FileType:
		//Unfortunately this is unsupported | Remarks: https://docs.microsoft.com/en-us/uwp/api/windows.storage.search.queryoptions.sortorder?view=winrt-19041

		//sortEntry.PropertyName = "System.FileExtension";
		//queryOptions.SortOrder.Clear();
		break;

	default:
		//keep the default one in SortOrder IList
		break;
}

//Basically we tell to the launched app to follow how we sorted the files in the directory.
queryOptions.SortOrder.Add(sortEntry);


Refactor names of the auth related internal functions

Purpose
$subject
Check List

[x] Read the Contributing Guide
[ ] Updated Change Log
[ ] Checked Tooling Support (#)
[ ] Added necessary tests

[ ] Unit Tests
[ ] Spec Conformance Tests
[ ] Integration Tests
[ ] Ballerina By Example Tests

[ ] Increased Test Coverage
[ ] Added necessary documentation

[ ] API documentation
[ ] Module documentation in Module.md files
[ ] Ballerina By Examples

Codecov Report

Merging #22562 into ballerina-1.2.x will not change coverage by %.
The diff coverage is n/a.

@@               Coverage Diff                @@
##           ballerina-1.2.x   #22562   +/-   ##
================================================
  Coverage            14.59%   14.59%
================================================
  Files                   51       51
  Lines                 1411     1411
  Branches               219      219
================================================
  Hits                   206      206
  Misses                1189     1189
  Partials                16       16

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2611534...07ba4ba. Read the comment docs.


Want to have files in root

Hi,
I currently have a lot of files, which are normally meant to be in the ROOT directory of the project, inside the static directory. Now I literally have no idea, how to get these files to be in the ROOT directory, when the project is going to get builded.
Any1 got a solution for me?

Fixed it myself by adding a directory root/, copying the files over there and extending webpack.prod.conf.js copytask with this:
    new CopyWebpackPlugin([
      {
        from: path.resolve(__dirname, '../static'),
        to: config.build.assetsSubDirectory,
        ignore: ['.*']
      },
      {
        from: path.resolve(__dirname, '../root'),
        to: config.build.assetsRoot,
        ignore: ['.*']
      }
    ])

For me the above solution from @visualcookie didn't work, getting this error:

Module build failed (from ./node_modules/babel-loader/lib/index.js):
Error: [BABEL] /Users/pear/projects/gekko-develop/web/vue/src/main.js: .apply is not a valid Plugin property

instead I had to move the CopyWebpackPlugin config into a new file vue.config.js like so:
const CopyWebpackPlugin = require('copy-webpack-plugin');

module.exports = {
  configureWebpack: {
    plugins: [
      new CopyWebpackPlugin([
        {
          from: '../baseUIconfig.js',
          to: 'public/UIconfig.js'
        }
      ])
    ]
  }
}

See these docs: https://cli.vuejs.org/guide/webpack.html#simple-configuration

@askmike Extending the existing CopyWebpackPlugin with
{
    from: path.resolve(__dirname, '../root'),
    to: config.build.assetsRoot
}

worked for me.
new CopyWebpackPlugin([
        {
            from: path.resolve(__dirname, '../static'),
            to: config.build.assetsSubDirectory,
            ignore: ['.*']
        },
        {
            from: path.resolve(__dirname, '../root'),
            to: config.build.assetsRoot
        }
]),

VueJS ^2.5.2


Handle zero and negative numbers

It didn't previously handle 0 and negative numbers.  Note that -123 would previously have been interpreted as an identifier.  Hopefully this isn't a thing that's actually used anywhere.

I don't understand this stuff all too well yet. I will have look through the lib to get an understanding.


[Snyk] Security upgrade nginx from latest to 1.22

This PR was automatically created by Snyk using the credentials of a real user.Keeping your Docker base image up-to-date means you’ll benefit from security fixes in the latest version of your chosen image.
Changes included in this PR

staging/https-nginx/Dockerfile

We recommend upgrading to nginx:1.22, as this image has only 88 known vulnerabilities. To do this, merge this pull request, then verify your application still works as expected.
Some of the most important vulnerabilities in your base image include:

Severity
Priority Score / 1000
Issue
Exploit Maturity

514
Integer Overflow or Wraparound SNYK-DEBIAN11-LIBXML2-2806812
No Known Exploit

500
SQL Injection SNYK-DEBIAN11-OPENLDAP-2808413
No Known Exploit

500
OS Command Injection SNYK-DEBIAN11-OPENSSL-2807596
No Known Exploit

500
Out-of-bounds Read SNYK-DEBIAN11-PCRE2-2808697
No Known Exploit

500
Out-of-bounds Read SNYK-DEBIAN11-PCRE2-2808704
No Known Exploit

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
🛠 Adjust project settings

Learn how to fix vulnerabilities with free interactive lessons:
🦉 Learn about vulnerability in an interactive lesson of Snyk Learn.

Checkmarx AST – Scan Summary & Details – ef070de2-dbec-4944-9111-7902354da679
New Issues

Severity
Issue
File / Package
Scan Engine

HIGH
Missing User Instruction
/staging/https-nginx/Dockerfile: 15
CxKICS

MEDIUM
Apt Get Install Pin Version Not Defined
/staging/https-nginx/Dockerfile: 24
CxKICS

LOW
Healthcheck Instruction Missing
/staging/https-nginx/Dockerfile: 15
CxKICS

Fixed Issues

Severity
Issue
File / Package
Scan Engine

HIGH
Missing User Instruction
/staging/https-nginx/Dockerfile: 15
CxKICS

MEDIUM
Apt Get Install Pin Version Not Defined
/staging/https-nginx/Dockerfile: 24
CxKICS

MEDIUM
Image Version Not Explicit
/staging/https-nginx/Dockerfile: 15
CxKICS

LOW
Healthcheck Instruction Missing
/staging/https-nginx/Dockerfile: 15
CxKICS


3D-Touch submission action issue

When setting 3D-Touch submission action to "Peek Content" it defaults to haptic touch(long press) and opens the Submission Menu. This behavior does not happen on other options for 3D-Touch submission action.

Hello, are you seeing this behavior on Images and Gifs from the main submission page?

Yes. The behavior occurs on the main submission page as well as any subreddit pages. My phone is an iPhone Xs Max on iOS 13.5

I'm not sure why this is the default behavior, but it seems "Peek Content" does work, but it is enabled only for the frame of the preview in the LinkCellView. In my opinion it would make more sense to remove the condition for checking if the menu interaction was within the preview frame so the area of activation of every "3D-Touch submission action" is the same.


Allow starting a SSM session manually from a SSM websocket URL and token

Hello!
Thanks for this great project. This PR adds a method to allow starting a session from a raw websocket URL. This turned out to be useful for me in several cases (especially when using undocumented APIs) so it would be great to make it available!

Thank you for taking the time to make this enhancement!  Glad you find this project useful

Will this work correctly? Open() calls startSession() which calls StartSessionFromDataChannelURL() - but before that, it does the following setup. Is this code not necessary?
https://github.com/mmmorris1975/ssm-session-client/blob/527e43b961c9d49d739230b99d6d7665e2626192/datachannel/data_channel.go#L54-L58

Not sure to be honest - I did use the code of this PR several times (in non-production code) and it worked fine.


Node Express Hello World

Don't merge me yet.  I just discovered that it isn't killing the server properly.  At least it isn't locally.


Support for Bearer token in the header for OAuth2

In OAuth2, I am not able to get the Bearer token set in the header automatically. How do I get it working?

I'm not familiar with Bearer token, and it seems this part is more precisely defined in 3.0 spec (https://github.com/OAI/OpenAPI-Specification/pull/807).
Right now OAuth2 supports in pyswagger is users need to provide the final token (to pyswagger.Security) after finishing the OAuth2 flow.
I'll spend some time to investigate Bearer token and changes in OpenAPI 3.0 to see how we can make it work in current implementation of pyswagger.

Hi @mission-liao What you mentioned is what I am trying to do to hack this out. But I believe we should support this in pyswagger natively. As you mentioned looks like it is part of v 3.0 spec. But, I guess it is simple enough to be added even now. What do you think?

I think yes, I can add those defined in 3.0 to current implementation of pyswagger, since they'll be supported later.

Thanks, I need this too

@erikpotterbsx  I'll work on this project to give a new release this weekend, your request would be included. Any update would be updated in this comment.

Here is my proposal:

a new function would be added to pyswagger.Security to prefix 'bearer ' automatically.
when that function is used, a flag would be added to the pyswagger.Security to indicate that object can't be used with OpenAPI 3.0 (service supports Open API 3.0 should use new schema to declare this part)

prefer to postpone this issue, because there is little thing we can do at this moment:

we can provide a special method (or a dedicated class) for users to specifically set a Bearer token, however, it's not a big imporvement for usage because users can still set a Bearer token by prefixing the token with "Bearer " by themselves.

Thanks for the patience @mission-liao. I think we can live with this for now while support for 3.0 is being implemented.


Remove the mysql jar from the jdbc connector

Fixes #6656
Motivation:
Remove the mysql jar from the jdbc connector

/pulsarbot run-failure-checks

@zymap when you removed mysql from jdbc connector, do you need to fix the integration test?

Let me take a look.

/pulsarbot run-failure-checks

@sijie @zymap  the pull request #6835 removed the MySQL connector.

Since #6835 already removed MySQL, close this issue now.


SSO over Gitlab with RBAC: Groups not fetched

Summary
I have successfully configured SSO over Gitlab. On Gitlab there is no scope groups. However, according to the docs they are part of the openid  scope:

The claims sub, sub_legacy, email and email_verified are included in the ID token, all other claims are available from the /oauth/userinfo endpoint used by OIDC clients.

Looking at the profile page in Argo, Argo seems to fail to fetch email, email_verified and groups. The latter is especially annoying because I can't configure RBAC roles based on it.
I'm not sure this is a bug or enhancement. If I understand the Gitlab doc correctly, this is common OIDC behaviour. But I could not say...
Diagnostics
What Kubernetes provider are you using?
GKE
What version of Argo Workflows are you running?
3.0.1

Message from the maintainers:
Impacted by this bug? Give it a 👍. We prioritise the issues with the most 👍.

Because groups is not part of the OIDC standard, they are disabled by default. You must enable them in the config map:
https://github.com/argoproj/argo-workflows/blob/master/docs/workflow-controller-configmap.yaml#L288

If I do that, Gitlab returns an error (malformed scopes) during auth.

Hey, I'm running into the same issue, is there any workaround to figure out gitlab groups?

Hi @domderen
We have an argoCD DEX server that does SSO over Gitlab. For argo-workflows we ended up configuring SSO over that dex server instead of going directly to Gitlab. So the chain now is argo-workflows => argoCD DEX => Gitlab.

Hey @mruoss,
Thanks for your comment! I was hoping to avoid installing ArgoCD at the moment, as I don't have a need for it for the time being, but I guess it might be easier solution for now. Or I can just set up a DEX server. Anyways, thanks for the suggestion.

In my opinion this ticket was closed prematurely (what do you think, @alexec?) But yeah, maybe you can get it working with a DEX server. For, us argoCD was already in place.


Thread-safe CorpusReader

I'm using a custom subclassed CorpusReader to feed documents to the Word2Vec model in gensim.  Because the reader isn't threadsafe, it breaks.  I can write my own simple reader for my files, but it would be nice if I could just use nltk.  Based on the comments above iterate_from it looks like some locking could be added to make the reader thread-safe.   What exactly what I need to acquire a lock on to make iterate_from safe?
-- Eric

Any thoughts on this?


Proposal: Limiting context when using implicit iterators

Given the following context:
{
	name: 'Hello World',
	list: [
		{ data: '123', name: 'one' }
		{ data: 'abc' }
	]
}

The following:
{{#list}}
	{{data}} - {{#name}}{{name}}{{/name}}
{{/list}}

Will output something like:
	123 - one
	abc - Hello World

It might be nice if you could syntactically limit the context to the current iteration
{{#list}}
	{{.data}} - {{#.name}}{{.name}}{{/.name}}
{{/list}}

To get:
	123 - one
	abc -

The use case I have is printing out html sytlesheet include fragments: the optional title attribute is missing, and it's finding the page title attribute up the context stack.
{{#stylesheets}}
	<link rel="stylesheet" href="{{href}}" type="text/css" {{#title}}title="{{title}}" {{/title}}charset="utf-8">
{{/stylesheets}}
....
<h1>{{title}}</h1>

/cc @cjerdonek (Is there a better way to subscribe to an issue?)

There's a link to enable notifications just below the comment form :)

This proposal was later duplicated in #52. It has a pull request in #92. Please continue discussion about the proposal over there, or discuss stack masking in general in #154.


Weird behavior when switching to/from VT when using scaled output

 Issue by DonOregano
Wednesday Apr 12, 2017 at 19:48 GMT
Originally opened as https://github.com/Cloudef/wlc/issues/251

This is an issue that I tried to report to the Sway project, but they pointed me here. Below is the verbatim error report I made there, but since this is a different project I am not sure whether my information is complete. Please don't bite my head off :-). I will try to provide any info that you require.
Using Arch on a T470s with 2560x1440 display with scaling set to 2.
If I launch a Terminator terminal it is scaled correctly and the fonts look nice and crisp.
 If I then switch to and from VT it still looks the same, but if I launch a new one it will use fonts that are double in size.
It appears to me that somehow the scaling is applied twice.
(I am using gdm to launch sway, don't know if that makes a difference. I can try this without gdm tonight to see if it makes a difference).

 Comment by Pamelloes
Saturday Apr 29, 2017 at 06:01 GMT

I can confirm having this exact same behavior. Perhaps it is related to the issue I reported at #261. I will try to investigate further in the near future.

 Comment by DonOregano
Wednesday Apr 12, 2017 at 19:51 GMT

FYI I tried it without gdm, and I still get the same behaviour.


Finetuning yi-34b on a 4090 stops after a few hundred steps

First, thank you for this great piece of software!
I'm trying to finetune yi-34b on a single rtx 4090 on a training set of ~50k examples. It does work when I only do a few hundred steps, but when I try to train a full epoch, it will just stop and hang after a while. I suspect this is because the set just fits into memory and maybe starts to go over, although I'm not getting any out of memory errors.
Is low memory the probable reason why this happens? If so, is there any way to save an additional 10% or so so that this might actually work?

@lambadalambda :) Hm It's entirely possibly some of ur examples might have been way too long, causing OOM. With NVIDIA's latest driver updates, OOM on the GPU will get redirected to your system RAM, causing it to hang, but not crash. So it definitely is running, just its getting offloaded to ur system RAM.
Ways to fix this:

Do checkpointing of ur runs. Ie checkpoint every 100 steps. See https://github.com/unslothai/unsloth/wiki for more info.
Reduce LoRA rank
Use paged_adamw_8bit instead of adamw_8bit
Hopefully you've been using unsloth/yi-34b-bnb-4bit which is a prequantized version and this can save you 2GB of GPU memory fragmentation.
Reduce max_seq_length

Wow, thanks for the advice! I'll try it out! I didn't notice the prequantized version of yi. Do you think you could also upload a version of yi-34b-chat? Or is there a way I can do it myself?

@lambadalambda unsloth/yi-34b-chat-bnb-4bit :)

@lambadalambda Oh you can pass fix_tokenizer = False ie:
model, tokenizer = FastLanguageModel.from_pretrained(
        model_name = "unsloth/yi-34b-chat-bnb-4bit",
        max_seq_length = max_seq_length,
        dtype = dtype,
        load_in_4bit = load_in_4bit,
        fix_tokenizer = False,
)

@lambadalambda Oh forgot if you have any other questions, we're more responsive on our Discord channel: https://discord.gg/u54VK8m8tk :)


Refactor Proof Preparation: Define ZkVmProver Trait, Remove ProverOptions, and Consolidate Tests

Description

Define a new ZkVmProver trait and implement it for different types of proof we prepare.
Remove ProverOptions
Move tests from provers/sp1/tests to provers/tests which can be used by both Risc0 and SP1.

Type of Change

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature/Enhancement (non-breaking change which adds functionality or enhances an existing one)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation update
[X] Refactor
[X] New or updated tests

Checklist

[ ] I have performed a self-review of my code.
[ ] I have commented my code where necessary.
[ ] I have updated the documentation if needed.
[ ] My changes do not introduce new warnings.
[ ] I have added tests that prove my changes are effective or that my feature works.
[ ] New and existing tests pass with my changes.

Related Issues

Oops, the conflicts are my fault because we needed to remove once and for all our reth fork from all Cargo.locks (not the top-level one only).
If you need help rebasing let me know...

Oops, the conflicts are my fault because we needed to remove once and for all our reth fork from all Cargo.locks (not the top-level one only). If you need help rebasing let me know...

No worries. I have rebased and pushed again.


[FEATURE] adding image inline to GitHub username when searching user

Description
Show the user image inline with username inside the search component
Screenshots

Additional information
No response

@Aladdin4u Hey is this issue approved ? if yes than are you looking forward to work on it ? if no than would really like to work on it ! can you assign it to me ?

You can work it @KlausMikhaelson

Hi! We had images before but it ended up maxing out the GitHub api which is why we removed them. Unless we can find a way to not hit the rate limit then unfortunately we can’t show images on the small name chips.

The new version of the project has images 👍


Issues using sdk in next js server actions

A user reported

so i was using cohere ai latest version in next js server actions - latest version - nvm 20 and 21.  I kept getting regular cohere errors about fetch missing.  The call would fail due to this- but not everytime.  Eventually i pnpm node fetch and included it as global at the top of the action to make it stop - hasnt shown up since.
I tried node 20 and 21 - didnt make a difference

They will follow up with a snippet + sdk version

node -v  v20.11.0 or node v21.5.0
"next": "^14.0.4",
"react": "18.2.0",
In server action with "use server"
const rerank = await Cohere.rerank({
documents: result.map((doc) => ({ text: doc.chunk })),
query: query,
model: "rerank-multilingual-v2.0",
topN: 5,
});
Although it would not error every time, it would error with regularity that it could not find fetch.
Eventually i pnpm i node-fetch   "node-fetch": "^3.3.2",
And added the following top of that file -
import fetch from "node-fetch";
(global as any).fetch = fetch;
Never saw the error again.
Didn´t seem like it was the same issue with the embed.  I do not import it in that file.
queryEmbedding = await Cohere.embed({
texts: [query],
model: "embed-multilingual-v3.0",
inputType: "search_query",
});

Hey, thanks for these details! Glad you found a fix. One thing I would mention is that there is a small risk this fix might affect other libraries in case you see weird behaviour from them any time.
Please could you try updating your sdk to the latest version<EMAIL_ADDRESS>Our vendor did some fixes to the fetch implementation since that version which I think will fix your use case cc @dsinghvi
https://github.com/cohere-ai/cohere-typescript/compare/7.6.2...main#diff-44db24fb92214331d3845e557c568eef257639cffaea46901778da833209ef3a

@dsinghvi flagged to me that the improvements here https://github.com/fern-api/fern/pull/2989 will also improve fetch robustness and we will release these updates too shortly

Correct on it not being an optimal fix - just the fastest way to get it to "it seems to be working" state on dev.
Updated the package and removed that node-fetch stuff - no errors yet - so looks fixed!


Added proxyPaths option to package.json

This allows text/html requests to be passed to the proxy.

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at<EMAIL_ADDRESS>Thanks!

Can you please explain the use case in more detail? How common do you anticipate this use case to be in other projects?

@gaearon, my primary use case is to support oAuth authentication during development, which requires passing html requests to the proxied server to handle the callback requests.
I'm also using it to proxy the GraphiQL in-browser IDE, but that's a secondary concern.

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

Can you imagine any way of handling this without introducing more configuration? This was meant as a simple one-off option, not a config format with a bunch of special cases.

I discussed with a colleague (@jimmyhmiller) and neither of us came up with a config-free solution. I'll continue to consider opportunities to simplify and am certainly fine maintaining a fork. I'll close this -- thanks!

👍 We can revisit if there is a popular demand for this.

I just ran into this same issue.  I'm OAuth-ing by sending the user to my api's /api/auth endpoint.  I was following the proxy instructions in the README but could not figure out why my requests were not being proxied.  After digging through past PRs, I found #282, which states that requests with text/html in the accept header will not be proxied.
At the very least, it would be good to add the following to the README section on proxy (taken from @trabianmatt's README update in this PR):

By default, the development server will only attempt to send requests without a text/html accept header to the proxy.

Even better would be to accept this PR!  If you do not want to add multiple options to the root level of package.json, you could merge the two properties as follows:
"proxy": {
  "host": "http://localhost:3001",
  "paths": [
    "^/api"
  ]
}

Thanks!

In the meantime PR to the docs is welcome 😉

Is there anything special about oauth requests that would allow us to infer one without adding configuration option? Is there any heuristic we could use that would work with a guarantee? Like some URL parameters? (I don’t know anything about oauth so bear with me here.)

Hey @gaearon I can't think of any heuristic, but to help elucidate the issue @trabianmatt and I ran into, here's a diagram that shows a common flow using React, an API, and a 3rd party OAuth provider. (diagram from this page. Credit to @lynndylanhurley and the redux-auth project.)

The 2nd step in the flow is where the proxy as implemented now is not working.
p.s. thanks for your work on create-react-app. it has made learning react easy and clean.


the reader doesn't read some unicode books

i have sample book written in Amharic, but the reader is not reading the book content

@kiyos12 is it possible for you to provide ebook?

change the extension to epub i change it to zip because github doesn't support epub file

github doesn't support epub file to be uploaded can i have your email please

https://pan.baidu.com/s/1gfnyP4f
the reader is not reading this book content .

@kiyos88 send it on<EMAIL_ADDRESS>

@kiyos88 please send it on<EMAIL_ADDRESS>

I changed "OEBPS" to "OPS" in the file :FolioPageFragment.java, AppUtil.java, it is worked now. My book's directory is different from the sample.

@compass00 yes, epub2 books can have such formats.. We've fixed this and will be included in 0.2 release soon..

@mahavir-jain  thank you finally i fix it by @compass00 's answer

fixed in 0.2.0


docker build fails

Hi,
I'm trying to build the image using the command docker build -t docker-osticket . but the process fails with the following error
running: make
/bin/sh /tmp/pear/temp/pear-build-defaultuserfmhGik/apcu-5.1.8/libtool --mode=compile cc -D_GNU_SOURCE -DZEND_ENABLE_STATIC_TSRMLS_CACHE=1 -I. -I/tmp/pear/temp/apcu -DPHP_ATOM_INC -I/tmp/pear/temp/pear-build-defaultuserfmhGik/apcu-5.1.8/include -I/tmp/pear/temp/pear-build-defaultuserfmhGik/apcu-5.1.8/main -I/tmp/pear/temp/apcu -I/usr/local/include/php -I/usr/local/include/php/main -I/usr/local/include/php/TSRM -I/usr/local/include/php/Zend -I/usr/local/include/php/ext -I/usr/local/include/php/ext/date/lib  -DHAVE_CONFIG_H  -g -O2   -c /tmp/pear/temp/apcu/apc.c -o apc.lo
mkdir .libs
cc -D_GNU_SOURCE -DZEND_ENABLE_STATIC_TSRMLS_CACHE=1 -I. -I/tmp/pear/temp/apcu -DPHP_ATOM_INC -I/tmp/pear/temp/pear-build-defaultuserfmhGik/apcu-5.1.8/include -I/tmp/pear/temp/pear-build-defaultuserfmhGik/apcu-5.1.8/main -I/tmp/pear/temp/apcu -I/usr/local/include/php -I/usr/local/include/php/main -I/usr/local/include/php/TSRM -I/usr/local/include/php/Zend -I/usr/local/include/php/ext -I/usr/local/include/php/ext/date/lib -DHAVE_CONFIG_H -g -O2 -c /tmp/pear/temp/apcu/apc.c  -fPIC -DPIC -o .libs/apc.o
In file included from /tmp/pear/temp/apcu/apc.c:40:0:
/usr/local/include/php/ext/pcre/php_pcre.h:29:18: fatal error: pcre.h: No such file or directory
compilation terminated.
Makefile:196: recipe for target 'apc.lo' failed
make: *** [apc.lo] Error 1
ERROR: `make' failed
The command '/bin/sh -c apk add --update     wget     unzip     msmtp     ca-certificates     supervisor     nginx     libpng     c-client     openldap     libintl     libxml2     icu     openssl &&     apk add imap-dev libpng-dev curl-dev openldap-dev gettext-dev libxml2-dev icu-dev autoconf g++ make &&     docker-php-ext-install gd curl ldap mysqli sockets gettext mbstring xml intl opcache &&     docker-php-ext-configure imap --with-imap-ssl &&     docker-php-ext-install imap &&     pecl install apcu && docker-php-ext-enable apcu &&     apk del imap-dev libpng-dev curl-dev openldap-dev gettext-dev libxml2-dev icu-dev autoconf g++ make &&     rm -rf /var/cache/apk/*' returned a non-zero code: 1
Do you have any hints of how I can solve this problem? Thanks

There was an upstream change in php:7.0-fpm-alpine that had stopped this building as the pcre-dev package was removed. This has now been added back and the build should be working again.


Use single buffer for all clients with shared data

With this PR all clients now write into a single buffer and share some of the serialized data.
ReplicationBuffer now a dummy buffer that passed to each messages. Messages now responsible for writing and track ranges of data written into ReplicationBuffer instead of the actual data.
This makes serialization code much more straightforward, should be faster when multiple clients are connected and unlocks the use of varints for sizes in messages.

It is confusing to have a central slice-tracker

It's not central, I was going to put slice tracker inside InitMessage and UpdateMessage. So each slice-tracker will be specific to client, only buffer will be central.

Benchmark results:
     Running benches/replication.rs (target/release/deps/replication-ba04dc43ee672d52)
entities send           time:   [77.081 µs 77.235 µs 77.365 µs]
                        change: [+15.650% +16.366% +16.852%] (p = 0.00 < 0.05)
                        Performance has regressed.

entities receive        time:   [140.82 µs 141.04 µs 141.31 µs]
                        change: [-0.5333% -0.3516% -0.1534%] (p = 0.00 < 0.05)
                        Change within noise threshold.

entities update send    time:   [90.333 µs 93.892 µs 96.553 µs]
                        change: [+13.564% +16.536% +19.526%] (p = 0.00 < 0.05)
                        Performance has regressed.
Found 1 outliers among 20 measurements (5.00%)
  1 (5.00%) low mild

entities update receive time:   [70.454 µs 70.759 µs 71.081 µs]
                        change: [+3.2025% +4.5302% +6.0711%] (p = 0.00 < 0.05)
                        Performance has regressed.
Found 1 outliers among 20 measurements (5.00%)
  1 (5.00%) high severe

Codecov Report
Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (60baa75) 90.61% compared to head (e472db3) 90.05%.

Files
Patch %
Lines

src/server/replication_messages.rs
92.12%
10 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #149      +/-   ##
==========================================
- Coverage   90.61%   90.05%   -0.56%
==========================================
  Files          20       20
  Lines        1161     1146      -15
==========================================
- Hits         1052     1032      -20
- Misses        109      114       +5

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

After varints:
entities send           time:   [69.063 µs 69.721 µs 70.485 µs]
                        change: [+3.2498% +4.1747% +5.1418%] (p = 0.00 < 0.05)
                        Performance has regressed.

entities receive        time:   [132.00 µs 132.25 µs 132.57 µs]
                        change: [-6.8810% -6.5598% -6.2269%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 1 outliers among 20 measurements (5.00%)
  1 (5.00%) high severe

entities update send    time:   [67.578 µs 69.020 µs 70.256 µs]
                        change: [-14.944% -12.756% -10.650%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 2 outliers among 20 measurements (10.00%)
  1 (5.00%) high mild
  1 (5.00%) high severe

entities update receive time:   [67.826 µs 68.117 µs 68.483 µs]
                        change: [-5.8478% -4.9335% -4.1420%] (p = 0.00 < 0.05)
                        Performance has improved.

Actually, no, most of the time it's slower:
init send, 1 client(s)  time:   [76.535 µs 76.703 µs 76.848 µs]
                        change: [+9.6742% +10.122% +10.604%] (p = 0.00 < 0.05)
                        Performance has regressed.
Found 1 outliers among 20 measurements (5.00%)
  1 (5.00%) high severe

update send, 1 client(s)
                        time:   [82.311 µs 83.316 µs 84.513 µs]
                        change: [+10.852% +13.293% +15.746%] (p = 0.00 < 0.05)
                        Performance has regressed.
Found 1 outliers among 20 measurements (5.00%)
  1 (5.00%) high mild

init send, 20 client(s) time:   [1.1780 ms 1.1802 ms 1.1820 ms]
                        change: [+3.9227% +4.2244% +4.4952%] (p = 0.00 < 0.05)
                        Performance has regressed.

update send, 20 client(s)
                        time:   [1.3662 ms 1.3750 ms 1.3849 ms]
                        change: [-2.2404% -0.3686% +1.6293%] (p = 0.71 > 0.05)
                        No change in performance detected.
Found 1 outliers among 20 measurements (5.00%)
  1 (5.00%) high mild

init receive            time:   [147.59 µs 147.71 µs 147.86 µs]
                        change: [-3.1692% -2.9269% -2.6581%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 2 outliers among 20 measurements (10.00%)
  2 (10.00%) high severe

update receive          time:   [78.870 µs 79.163 µs 79.654 µs]
                        change: [+2.3648% +3.4842% +4.7774%] (p = 0.00 < 0.05)
                        Performance has regressed.
Found 1 outliers among 20 measurements (5.00%)
  1 (5.00%) high mild

Results just jump a bit.

Here are results compared to the current master with relatively small string inside DummyComponent:
init send, 1 client(s)  time:   [178.13 µs 178.30 µs 178.45 µs]
                        change: [+26.106% +26.806% +27.336%] (p = 0.00 < 0.05)
                        Performance has regressed.
Found 2 outliers among 20 measurements (10.00%)
  1 (5.00%) high mild
  1 (5.00%) high severe

update send, 1 client(s)
                        time:   [309.22 µs 321.65 µs 329.19 µs]
                        change: [+23.171% +32.833% +43.182%] (p = 0.00 < 0.05)
                        Performance has regressed.

init send, 20 client(s) time:   [3.0613 ms 3.0636 ms 3.0664 ms]
                        change: [+12.910% +13.271% +13.709%] (p = 0.00 < 0.05)
                        Performance has regressed.
Found 3 outliers among 20 measurements (15.00%)
  3 (15.00%) high severe

update send, 20 client(s)
                        time:   [4.9629 ms 5.2265 ms 5.3863 ms]
                        change: [+12.751% +20.484% +28.984%] (p = 0.00 < 0.05)
                        Performance has regressed.

init receive            time:   [225.18 µs 225.84 µs 226.62 µs]
                        change: [-4.4025% -4.1821% -3.9500%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 2 outliers among 20 measurements (10.00%)
  2 (10.00%) high mild

update receive          time:   [208.59 µs 212.43 µs 214.46 µs]
                        change: [-5.2401% -0.0073% +4.8292%] (p = 1.00 > 0.05)
                        No change in performance detected.

This approach turns out to be slower, turning it into a refactoring as a new PR: #158.


changed namespace for ns

Signed-off-by: Mikhail Avramenko<EMAIL_ADDRESS>Issue
https://github.com/networkservicemesh/sdk-k8s/issues/252

Please resolve conflicts.

@denis-tingaikin  ok, done

@denis-tingaikin resolved conflicts


any extenion faield

Issue Type: Bug
i donot install any extension from market place
VS Code version: Code 1.37.0 (036a6b1d3ac84e5ca96a17a44e63a87971f8fcc8, 2019-08-08T02:33:50.993Z)
OS version: Windows_NT x64 10.0.17763

See #78783 for info about how others have tracked this down to a DNS issue.


StopContainer is racy

StopContainer is racy in that if the process dies in between when the check happens and when the signal is sent, the function will error out.
https://github.com/kubernetes-incubator/cri-o/blob/1a25658eba1f34527209e379a14bd83531dcef3f/oci/oci.go#L675-L692
I ran into this issue with OpenShift 3.9, resulting in:
error killing pod: failed to "KillPodSandbox" for "d929a4a0-3424-11e8-be3b-005056823990" with KillPodSandboxError: "rpc error: code = Unknown desc = failed to stop infra container k8s_POD_router-1-deploy_default_d929a4a0-3424-11e8-be3b-005056823990_0 in pod sandbox f0ea226c83fa61d7bf7dbe06cb62e532b12e966380b417894a19edbf682f5694: failed to stop container f0ea226c83fa61d7bf7dbe06cb62e532b12e966380b417894a19edbf682f5694, `/usr/bin/runc kill f0ea226c83fa61d7bf7dbe06cb62e532b12e966380b417894a19edbf682f5694 TERM` failed: exit status 1"

With the cri-o logs showing:
Mar 30 10:26:39 fll2aosi01dev crio[6207]: container_linux.go:393: signaling init process caused "os: process already finished"

Steps to reproduce the issue:

Have a container exit
Try to stop the pod at the same time it exits
Retry over and over until you hit the race condition

Describe the results you received:
success
Describe the results you expected:
failed to stop container f0ea226c83fa61d7bf7dbe06cb62e532b12e966380b417894a19edbf682f5694, `/usr/bin/runc kill f0ea226c83fa61d7bf7dbe06cb62e532b12e966380b417894a19edbf682f5694 TERM` failed: exit status 1

Additional information you deem important (e.g. issue happens only occasionally):
Output of crio --version:
crio version 1.9.10

Additional environment details (AWS, VirtualBox, physical, etc.):
openshift v3.9.0-alpha.4+881f1dd-440
kubernetes v1.9.1+a0ce1bc657
etcd 3.2.8

I'll add sync around this

Actually, I think it's just worth checking if the process is still around before sending the signal

Actually, I think it's just worth checking if the process is still around before sending the signal

That's what the code is already doing. The problem is that between the check, and sending the signal, the process disappears.
I think the only way to solve this is going to be to re-check after sending the signal to see if it's still there, and if it's not, pretend that there was no error and return success.

@phemmer https://github.com/kubernetes-incubator/cri-o/pull/1478


Patch Checker Framework classpath to accomodate for annotations from :qual in astubs

Closing the PR, Tainting Checker is better suited here (#911)


Incorrect test "Use the + operator to build myStr" is actually testing against "ourStr" not "myStr"

Challenge Name
Concatenating Strings with Plus Operator
Issue Description
My complete answer (after refactoring out unused code and comments), is:
var myStr = "This is the start. " + "This is the end.";

Which triggers a fail for the test:
Use the + operator to build myStr

Interestingly, adding back in the example code and commenting it out:
// var ourStr = "I come first. " + "I come second.";

Will result in the same test passing, while removing the "+" from that commented out example, i.e.:
// var ourStr = "I come first. "  "I come second.";

will fail.
So the test:
Use the + operator to build myStr

Looks like it's actually testing against the example ourStr and  not against the camper's myStr.

@metasean thanks for the issue. However, that particular test checks for the number of + signs. Within the editor, it mentions to Only change code below this line. Changing the lines above it will create unintended consequences. So the test isn't actually testing against the example outStr. Although inconvenient, this isn't a bug per se so I'll be closing this issue.
If you get stuck with a challenge or have any initial questions, please first ask questions to the Help Room. Happy coding!


Add dns wildcarding

This PR is an attempt at implementing DNS wildcard support. The use case in mind is for those of us who wish to use nebula's DNS in conjunction with virtual hosts.
At the moment, say we have a server my-server.nebula, it is not possible to use virtual hosts to have, for example multiple apps served at app-1.my-server.nebula, app-2.my-server.nebula etc.
This initial (naive) implementation can be enabled with the new config options as seen below.
# ...
lighthouse:
  # ...
  dns:
    # ...
    wildcard: true
    wildcard_limit: 5 # recursion limit used when searching for a matching host

This config is global and doesn't support per-host or per-group enabling. I welcome discussion on the proposed feature and its implementation as-is as well as commentary around the desired configuration of the feature.
Relevant slack discussion: https://nebulaoss.slack.com/archives/CRWJJM52B/p1639478617050700

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Can you update examples/config.yml with the new config options? (They can be commented out by default)

Very excited for this feature!


Update azuredeploy.json

Checklist

[ ] The title of the PR is clear and informative
[ ] If applicable, the changes made in the PR have proper test coverage
[ ] Issues addressed by the PR are mentioned in the description followed by Fixes.

Description

Fixes

@Laasya-07 thanks for the PR. can you help understand the change ?


Please invite me to the Infraform Community

Name
James Kano
Additional Context
Please invite me your git repo

Invitation sent to join the GitHub Organization. Welcome to Infraform 🎉Please check your mail to accept the invitation sent by GitHub! 🤖About usInfraform is a remarkable open-source solution tailored for serverless platforms, aimed at empowering creators to craft their infrastructure solutions. 💻 We're thrilled to welcome you into our vibrant community! ✨ We eagerly anticipate your valuable contributions! 🤓 Don't forget to explore our community on Github and connect with us on LinkedIn 💜 Feel free to spread the word about our community to like-minded individuals interested in development, DevOps, technology, and collaborative contributions. 👉💜👈