Card component

What's this PR do?
Adds a custom Card component instead of using the one provided by react-material, which had some styling that caused scrollbars to not be clickable.  This custom one has only the bare minimum styling.  The shadow on the edge of the custom card may be less pronounced because the react-material library was using a bunch of elements to generate its shadow.
What are the important parts of the code?
src/components/card.js has the definition of the custom Card component, it is then swapped out in
src/components/overlay.js and src/components/sidebar.js.  Changes were also made to src/components/projects-button.js because we no longer have postition: relative on the card component to contain it (again, because we only want the minimum styles).
How should this be tested by the reviewer?

Create files in the sidebar until they exceed the boundaries.  Verify that you can grab and drag the scrollbar (this is a bit difficult on OSX).
Create projects (in the project view) until they exceed the boundaries.  Verify that you can grab and drag the scrollbar (this is a bit difficult on OSX).
Verify the visual look of the sidebar and modals look similar to the old implementation.
Verify all modals still behave properly.

Is any other information necessary to understand this?
Everything should be outlined above.
What are the relevant tickets? (Please add closes, refs, etc)
Fixes #277
Fixes #290
Screenshots (if appropriate)
Very hard to capture this on OSX :disappointed:

@PropGit can you please test this branch on Windows?  I believe the issue is fixed because I can now grab the scrollbar on OSX but I want to cover all the bases.

This change introduced a visual bug with the download progress bar.  I have pushed a new commit that fixes it.

@phated - Yes, I will test it in Windows and report.

@phated - I tested it and, yes, it is fixed now in Windows too.


Explain how to connect to the server with the CLI running in a container

Closes #13269

@karesti looks good to me.

@theashiot  I reported all the changes

@pruivo issue added and commit message updated

Thanks @karesti
@andyuk1986 @theashiot can I get a green light to merge this?

@pruivo Anna gave her green light a while ago and I reported all the changes

merged! thanks @karesti !


Dashboard refresh problem

When editing a user record. Updating the enrollee name and case ID was not reflected in the Dashboard view and did not reflect in the sort order. See attached for apparent example.
BugReport1.pdf

This did eventually refresh after several minutes. I am the only one testing the system right now, so I assume it is a not a DB/system load issue.


added test when we set the full path

Codecov Report

Merging #332 (50b273f) into main (dc5b5a1) will increase coverage by 0.37%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main     #332      +/-   ##
============================================
+ Coverage     93.77%   94.15%   +0.37%
  Complexity      491      491
============================================
  Files            60       60
  Lines          1334     1334
============================================
+ Hits           1251     1256       +5
+ Misses           83       78       -5

Impacted Files
Coverage Δ

src/Analyzer/ClassDescription.php
100.00% <0.00%> (+2.94%)
:arrow_up:

src/Analyzer/ClassDescriptionBuilder.php
100.00% <0.00%> (+4.28%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Update index.html

Well changed to a better one.
Let's go !!!!

Well i thought something was missing this is it.


Relative url support in OAuthFlow Object

Describe the bug
Relative URLs are not allowed in the authorizationUrl field of the OAuth Flow Object.
Expected behavior
The specification indicates that

Relative References in URLs
Unless specified otherwise, all properties that are URLs MAY be relative references as defined by RFC3986. Relative references are resolved using the URLs defined in the Server Object as a Base URI.

The authorization URL to be used for this flow. This MUST be in the form of a URL.

As there is nothing special about this URL, I guess this field (and others) should be allowed to use relative paths.
What do you think about it ?

Hi and welcome,
You're right, this needs to be addressed. Unfortunately, as first thought, this can lead to skip url validation on URL fields as I can't concat it directly to server URL description because of potential parameter variables. Maybe as URI only? I'll digg into it to see if it is enough jsut after the current work I'm on.
Thanks for the report.

Hi,
can you confirm the fix in latest 0.8-SNAPSHOT?
FYI, this fix has been extended to other models too (license, contact, ...).

Hi,
can you confirm the fix in latest 0.8-SNAPSHOT?
FYI, this fix has been extended to other models too (license, contact, ...).

Hello,
The fix is working perfectly in my case, thank you very much ! 👍


Respect default_options for HTTP::Chainable#request and HTTP::Chainable#build_request

Currently, if default_options are set, they are respected for methods such as #via or #timeout but not with a simple request.
Let me know if this would make sense, or if the current implementation is intentional!
cc @zanker HI ZANKER :)

Removed some options from .travis.yml
See error log: https://travis-ci.org/httprb/http/jobs/472558089

👋


max value of y-axis calculates too high

In the datasets I am using, the current max value is 13, the y-axis scales in steps of 5 to a max of 20, whereas I would like it to scale to 15 only.
I cannot set a hard coded y-axis, as the max value might change to any value.
I am using this code:
var barChartData = {
labels : ["P8", "G36", "MP2A1", "MG3 S1", "AG36", "P8 S1", "G36 S1", "GP S2"],
datasets : [
{
label: "Gesamtvorrat",
fillColor : "rgba(79,129,189,1)",
strokeColor : "rgba(79,129,189,0.8)",
highlightFill: "rgba(79,129,189,0.75)",
highlightStroke: "rgba(79,129,189,1)",
data : [7, 8, 8, 10, 13, 8, 1, 5]
},
{
label: "Arbeitsvorrat",
fillColor : "rgba(192,80,77,1)",
strokeColor : "rgba(192,80,77,0.8)",
highlightFill: "rgba(192,80,77,0.75)",
highlightStroke: "rgba(192,80,77,1)",
data : [2, 6, 3, 8, 10, 3, 0, 3]
},
{
label: "4 Wochen Sicht",
fillColor : "rgba(155,187,89,1)",
strokeColor : "rgba(155,187,89,0.8)",
highlightFill : "rgba(155,187,89,0.75)",
highlightStroke : "rgba(155,187,89,1)",
data : [2, 7, 3, 8, 2, 8, 7, 3]
}
],
multiTooltipTemplate: "<%= datasetLabel %> - <%= value %>",
legendTemplate : "<ul class="<%=name.toLowerCase()%>-legend"><% for (var i=0; i<datasets.length; i++){%><span style="background-color:<%=datasets[i].strokeColor%>"><%if(datasets[i].label){%><%=datasets[i].label%><%}%><%}%>"
}
window.onload = function(){
var ctx = document.getElementById("canvas1").getContext("2d");
window.myBar = new Chart(ctx).Bar(barChartData, {
responsive : true,
barValueSpacing : 20,
barDatasetSpacing : 0,
scaleFontFamily: "'Helvetica Neue', 'Helvetica', 'Arial', 'sans-serif'",
// Number - Scale label font size in pixels
scaleFontSize: 14,
// String - Scale label font weight style
scaleFontStyle: "bold"
});
document.getElementById('js-legend').innerHTML = myBar.generateLegend();
}
Attached is a screenshot.

A quick advice or fix (even if dirty) would be appreciated, as this occured in productive environment.

Hello, today I am closing all issues that are only affecting version 1 of Chart.js as WONTFIX.
If this issue does affect version 2 as well, I apologize for the error. Please create a test case against Chart.js 2 using on of the below websites and we will be happy to reopen the issue and update its classification:

http://jsbin.com/
http://jsfiddle.net/
http://codepen.io/pen/
Premade template: http://codepen.io/pen?template=JXVYzq


Question: avoiding gRPC errors with Cypress

Hello, glad to find this library!  I spent about a couple days trying to figure out why I couldn't get my cypress tests to run.  I opened an issue on the Cypress repo (https://github.com/cypress-io/cypress/issues/3570), but ultimately ended up trying TestCafe which is having it's own issues getting gitlabCI running correctly.  Honestly, I preferred the sensibilities of Cypress and want to try again.
Can you help with this issue?  It appears that your library is mostly for manually calling into Firebase/Firestore within the test.  I would like my tests to be purely concerned with clicking and expecting the interface to change.  Just like the real app, there is no manually POSTing or GETing during the tests.  Do you have examples like that?
To clarify, it would be a test like:

Cypress selects a button and clicks it.
App code makes a GET request to firestore, and returns data that the app uses to populate a list.
Cypress verifies the contents of the list.

@bpkennedy How does this relate to Fireadmin? Did you mean to post this on cypress-firebase?

Ah, yes I did - my apologies.

Well you can do both - the two things you are describing are often referred to as the following
"seeding" - is adding/removing data from the database to prime it for a test that verifies the UI displays data correctly
"verifying" - checking the database to make sure the UI correctly updated based on clicks
It is common to have a test that mixes the two where you seed the database with something like a fake project, click a few buttons in the UI, maybe "delete project", then you verify that the delete action removes the data from the database.
It is taking a "round trip" or end-to-end approach since you are actually letting the UI write to the database and load data from the database that is placed there for tests.

Ah, I see, thank you.  I see you have called the firebase initializeapp() in the cypress commands.js and then in your app you only initialize it if it doesn't already exist.  Is this because otherwise Cypress will throw gRPC errors during the Electron runtime?  (This is what I was running into when I first set it up).

@bpkennedy Well sort of - the instance is only initialized if it doesn't already exist because during the tests it is initialized and passed to the window. This works since Cypress shares a window with where the app is running.
The issues are seeing are common when trying to run certain node-modules within the Cypress environment since it is a browser (can be Electron like you mentioned). firebase-admin is one of those libraries since it uses gRPC. More is covered on this in the why section of cypress-firebase.
If you are interested in starting with an app with this already setup, you may want to checkout generator-react-firebase. It has the option to include Cypress tests when creating your project - it will also include the stuff you need to run your tests in Gitlab.
Going to close this for now, but feel free to reach out over gitter.


JGRP-2470 JBDC_PING can face a split-brain issue when restarting a co…

…ordinator node
Revert "https://issues.jboss.org/browse/JGRP-2199"
This reverts commit 215cdb68d043e4426bc9f4dcba826c0f7977f87a.
Purging cluster data is certainly not the responsibility of the old coordinator as this is racy and can cause singleton clusters.  While this resolves https://issues.redhat.com/browse/JGRP-2470 the question remains what's the issue/fix for https://issues.redhat.com/browse/JGRP-2199 for which this was originally put it suggested as workaround.

Fixed this


generation fails with current poetry and python 3.12

I got an error about being unable to uninstall marshmallow, saying pip was not found.
Worked around the issue by running pipx install pip

which was the configuration that you used?

OS: Ubuntu 20.04
Python: 3.12.3
 npx create-llama
✔ What is your project named? … my-app
✔ Which template would you like to use? › Agentic RAG (single agent)
✔ Which framework would you like to use? › FastAPI (Python)
✔ Would you like to generate a NextJS frontend for your FastAPI (Python) backend? … No / Yes
✔ Would you like to set up observability? › No
✔ Please provide your OpenAI API key (leave blank to skip): …
✔ Which data source would you like to use? › Use an example PDF (you can add your own data files later)
✔ Would you like to add another data source? › No
✔ Would you like to use LlamaParse (improved parser for RAG - requires API key)? … no / yes
✔ Would you like to use a vector database? › No, just store the data in the file system
✔ Would you like to build an agent using tools? If so, select the tools here, otherwise just press enter ›
✔ How would you like to proceed? › Generate code and install dependencies (~2 min)
Creating a new LlamaIndex app in /home/kehan/scratch/my-app.

Initializing Python project with template: streaming

No tools selected - use optimized context chat engine

Adding additional dependencies
Adding tools dependencies

Added docx2txt, llama-index-agent-openai to pyproject.toml

Installing python dependencies using poetry. This may take a while...
Creating virtualenv app-efD1G0ND-py3.12 in /home/kehan/.cache/pypoetry/virtualenvs

However I have just uninstalled pip via pipx and generated a new project and it's now worked. I had also run a system update so maybe that resolved it.


replace tut by mdoc (issue with prism.md)

Locally, I have this weird error:
error: Error while emitting prism.md
assertion failed:
  Trying to access the this of another class: tree.symbol = class Session$App16, class symbol = <$anon: monocle.PPrism> compilation unit: prism.md
     while compiling: prism.md
        during phase: jvm
     library version: version 2.13.1
    compiler version: version 2.13.1
...
last tree to typer: TypeTree(class TPrintColors)
       tree position: line 194 of prism.md
            tree tpe: pprint.TPrintColors
              symbol: case class TPrintColors in package pprint
   symbol definition: case class TPrintColors extends Product with Serializable (a ClassSymbol)
      symbol package: pprint
       symbol owners: class TPrintColors
           call site: <$anon: Function1> in package repl in package repl

Not sure why GenIso caused this weird error. I remove mdoc for that piece of code and it works.


crashes because incompatible mod patches NetNode.RenderInstance

@raethegit 4 hours ago
Of course. Murphy's Law kicked in and I couldn't "deliberately" get the game to actually crash with both mods activated, but I managed to get a log of Hide Crossings disabled, where everything runs smooth (but doesn't look as good/desired) and one with Hide Crossings enabled, where unpausing after load changes the button but the simulation doesn't start running. Also, most UI stuff didn't work like changing lane arrows in TMPE or bulldozing anything.
Log w/out Hide Crossings [ufile.io]
Log with Hide Crossings [ufile.io]
raethegit 5 hours ago
So, for now i deduce this said incompatibility exists and seems to be only triggered by certain circumstances like either OS, installed assets, mods, or even the hardware, or any combination of that... which will probably and hopefully be revealed by the output log.
raethegit 5 hours ago
@Albeo I don't have Bonjour on my Linux machine
I never got any indications that Hide Crosswalks or Remove Need For Pipes was actually in any way related to those crashes, they both work(ed) just fine and as expected. I just very frequently got those ominous crashes to desktop right after loading or unpausing a game so I did some random search on the workshop to see if there might be known issues for some of the installed mods, assets, etc, and that is when I came across Duplicate Assembly Scanner which described the exact behaviour and the possible reason for that.
For verification, I have now temporarily unsubscribed from Hide Crosswalks, as it is "only" for cosmetics and doesn't influence functionality. Now the game runs much more stable and is way more responsive additionally to being playable much faster after loading. To not distort the result I deliberately changed nothing else than unsubscribing from HC.
I'll try to resubscribe so I can get a fresh output log later.
aubergine18 6 hours ago
@raethegit Share your output_log.txt so we can see what actual error is.
Albreo 7 hours ago
@LemonsterOG I second this.
@raethegit Try to get rid of Bonjour if you have one on your computer. I'm trying to confirm if it's related to my crash.
LemonsterOG 8 hours ago
@raethegit -- I use both this mod and Remove Need for Pipes without issue. You must have some other mod(s) conflicting.
raethegit 8 hours ago
I have experienced "instant crashes" a lot lately and just now found the Duplicate Assembly Scanner in the workshop, so i gave it a shot. Turns out this mod and Remove Need For Pipes are conflicting as they use the same method from different Harmony versions (yours v2.0.0, Remove Need For Pipes v1.2.0) which is said to be a very probable cause of those crashes.
Just wanted to give a heads up on this as both mods add a lot of value to gameplay for me, and did the same over at the Remove Need For Pipes mod.
Still want to leave a big thanks for your work! :)
player-1.log
player-2.log

I did not manage to reproduce the problem using remove need for pipeline and HideTMPECrosswalks mods.
This catched my attention:

@raethegit Duplicate Assembly Scanner in the workshop, so i gave it a shot. Turns out this mod and Remove Need For Pipes are conflicting as they use the same method from different Harmony versions (yours v2.0.0, Remove Need For Pipes v1.2.0) which is said to be a very probable cause of those crashes.

From theoutput log we I see NetNode.RenderInstance is having format exception only when unpatching which is what I would expect to get because of https://github.com/boformer/NetworkSkins2/blob/master/README.md

  at Harmony.PatchFunctions.UpdateWrapper (System.Reflection.MethodBase original, Harmony.PatchInfo patchInfo, System.String instanceID) [0x00000] in <filename unknown>:0
  at Harmony.PatchProcessor.Unpatch (System.Reflection.MethodInfo patch) [0x00000] in <filename unknown>:0
  at Harmony.HarmonyInstance.Unpatch (System.Reflection.MethodBase original, System.Reflection.MethodInfo patch) [0x00000] in <filename unknown>:0
  at Harmony.HarmonyInstance+<>c__DisplayClass11_1.<UnpatchAll>b__3 (Harmony.Patch patchInfo) [0x00000] in <filename unknown>:0
  at Harmony.CollectionExtensions.Do[Patch] (IEnumerable`1 sequence, System.Action`1 action) [0x00000] in <filename unknown>:0
  at Harmony.CollectionExtensions.DoIf[Patch] (IEnumerable`1 sequence, System.Func`2 condition, System.Action`1 action) [0x00000] in <filename unknown>:0
  at Harmony.HarmonyInstance.UnpatchAll (System.String harmonyID) [0x00000] in <filename unknown>:0
  at AchieveIt.ModInfo.OnDisabled () [0x00000] in <filename unknown>:0
  at (wrapper managed-to-native) System.Reflection.MonoMethod:InternalInvoke (object,object[],System.Exception&)
  at System.Reflection.MonoMethod.Invoke (System.Object obj, BindingFlags invokeAttr, System.Reflection.Binder binder, System.Object[] parameters, System.Globalization.CultureInfo culture) [0x00000] in <filename unknown>:0
Rethrow as TargetInvocationException: Exception has been thrown by the target of an invocation.
  at System.Reflection.MonoMethod.Invoke (System.Object obj, BindingFlags invokeAttr, System.Reflection.Binder binder, System.Object[] parameters, System.Globalization.CultureInfo culture) [0x00000] in <filename unknown>:0
  at System.Reflection.MethodBase.Invoke (System.Object obj, System.Object[] parameters) [0x00000] in <filename unknown>:0
  at ColossalFramework.Plugins.PluginManager+PluginInfo.Unload () [0x00000] in <filename unknown>:0
UnityEngine.DebugLogHandler:Internal_LogException(Exception, Object)
UnityEngine.DebugLogHandler:LogException(Exception, Object)
UnityEngine.Logger:LogException(Exception, Object)
UnityEngine.Debug:LogException(Exception)
ColossalFramework.Plugins.PluginInfo:Unload()
ColossalFramework.Plugins.PluginManager:OnDestroy()

(Filename:  Line: -1)```

I did not get this exception when I tried it my self.

Turns out this mod and Remove Need For Pipes are conflicting as they use the same method from different Harmony versions (yours v2.0.0, Remove Need For Pipes v1.2.0)

Remove Need For Pipes does not patch NetNode.RenderInstance so that is not a problem.

@raethegit I need you to help me hunt down this bug. I am unable to reproduce it. Can you please:

[ ] Subscribe to all the mods required to reproduce the crash. then give me the smallest city that can reproduce the crash. If you get this crash in an empty city then give me an empty city. Make sure that you can still reproduce the crash. drop the file here or in steam or something.
[ ] Please tell me when do you exactly see the crash? is it intermittent? can you reliably reproduce it?
[ ] Try to reproduce minimum test case. Try to unsubscribe from remove need for pipe mod to see if that would fix the problem (highly unlikely). then try to remove the rest of your mods until you manage to find the mod that is incompatible with mine. use binary search (see footnote *)

*use binary search. testing mods one by one is time consuming. try disable half of your mods and then perform the test. if you didn't see the crash then the incompatible mod most be in the other half. keep disabling half of your mods until you find the incompatible mod.


/usr/share/elasticsearch/xpack directory exists in the 6.3 image

Docker image used: docker.elastic.co/elasticsearch/elasticsearch:6.3.0

Operating System: Mac OSX 10.13.5 (17F77)

docker info output: docker_info.txt

docker inspect NAME|ID output: docker_inspect.txt

Steps to reproduce

Log in to the running container (e.g. docker exec -it <name> /bin/bash)
Browse to /usr/share/elasticsearch/bin
Note the presence not only of the relocated commands (such as elasticsearch-certgen etc) but also the x-pack directory, which contains those same utilities (sans their new elasticsearch- prefix).

Bug Description
Expected behavior: the x-pack directory no longer exists in the Elasticsearch 6.3.0 image.
Issue: the x-pack directory does exist in the /usr/share/elasticsearch/bin directory in the Elasticsearch 6.3.0 image.

IMO this is for backwards compatibility. The components in the x-pack folder print a warning to switch to the ones in the base folder:
# /usr/share/elasticsearch/bin/x-pack/certgen
/usr/share/elasticsearch/bin/x-pack/certgen is deprecated, use /usr/share/elasticsearch/bin/elasticsearch-certgen

From the top of my head you get exactly the same setup with the DEB packages. Or is there another issue with this x-pack folder being present that I'm overlooking?

Hey @xeraa, I don't believe you're missing anything. I used an rpm install as the baseline on CentOS 7.4, which no longer includes that folder, so I wanted to bring it up as potentially unnecessary duplication if it was just an oversight. If it's useful for backwards compatibility it totally makes sense to keep it around and this can be closed out.

@xeraa and @danleerunk -- the certgen script just walks up a directory using dirname.
This works if you call certgen with its full path, "/usr/share/elasticsearch/bin/x-pack/certgen" as walking up a directory brings us to, "/usr/share/elasticsearch/bin" where elasticsearch-certgen is appended.
The issue is if you change directory into the x-pack dir, this causes the script to look for elasticsearch-certgen in the x-pack dir:
[root@e09d9cdec68f x-pack]# ./certgen
./certgen is deprecated, use ./elasticsearch-certgen
./certgen: line 13: ./elasticsearch-certgen: No such file or directory

It looks like in this case dirname certgen $0 returns "." which then gets elasticsearch-certgen added to it  which results in ./elasticsearch-certgen and prints the error above breaking backwards compatiblity.

Ah, that is indeed an issue. But IMO not limited to the Docker images, so I've opened elastic/elasticsearch/issues/31785.
Guess we can close this one here in the meantime. Not sure if this will be fixed of if the deprecated certgen will just be removed.


Concat layer pos and neg contribs calculation fix

Unit test for merge layer happened to have both layers of the same dimensions, and so missed this issue (also I don't think theano throws an error unless you are specifically calculating contributions w.r.t. the merge layer, and the bug doesn't affect any results unless the merge layer is immediately followed by a nonlinearity, since it basically just messed up the positive/negative split at the merge layer which is only relevant when the layer is followed by a nonlinearity)

Can this affect results for others in the lab who use some other type of
architecture. If so just announce bug fix to the lab.
Anshul
On Jun 9, 2017 9:31 AM, "Av Shrikumar"<EMAIL_ADDRESS>wrote:

Unit test for merge layer happened to have both layers of the same
dimensions, and so missed this issue (also I don't think theano throws an
error unless you are specifically calculating contributions w.r.t. the
merge layer, and the bug doesn't affect any results unless the merge layer
is immediately followed by a nonlinearity, since it basically just messed
up the positive/negative split at the merge layer which is only relevant
when the layer is followed by a nonlinearity)
You can view, comment on, or merge this pull request online at:
https://github.com/kundajelab/deeplift/pull/27
Commit Summary

Concat layer pos and neg contribs calculation fix

File Changes

M deeplift.egg-info/PKG-INFO
https://github.com/kundajelab/deeplift/pull/27/files#diff-0 (2)
M deeplift/blobs/core.py
https://github.com/kundajelab/deeplift/pull/27/files#diff-1 (5)
M setup.py
https://github.com/kundajelab/deeplift/pull/27/files#diff-2 (2)

Patch Links:

https://github.com/kundajelab/deeplift/pull/27.patch
https://github.com/kundajelab/deeplift/pull/27.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/kundajelab/deeplift/pull/27, or mute the thread
https://github.com/notifications/unsubscribe-auth/AAI7EWnoEd1hfsyaRc3kOvkp_1Dritg0ks5sCXNbgaJpZM4N1k1B
.

I don't think anyone puts a nonlinearity immediately after the merge layer, but this bugfix is mostly relevant for tensorflow branch (about to push that) where the contribution function fails to compile altogether.


Improve image stages

As discussed in #506, this change re-uses intermediate stages for apt update, apt install and box64 install, and subsequent clean-up.
The docker image size stays the same, but the build is faster as the operations mentioned above are re-used for all images.

Looks nice, thanks


Chore: Connector Update

Update to Connector wrapper and scenarios to bring it in line with the version used in benchmarks. Previously, other agents and targets were marked with binary variables. This has been replaced with integers, so that agents can be distinguished from each other and matched to their corresponding target. Also, rewards and discounts are shared between agents, as this gave the best performance.

Thank you for this @SimonDuToit! Something that would be really nice is if we could add the vector obs versions of cleaner and connector in Mava as well.

Thank you for this @SimonDuToit! Something that would be really nice is if we could add the vector obs versions of cleaner and connector in Mava as well.

Can we do this in a separate PR though?


SD-2.1

Very excellent job, if you migrate him to 50-step SD-2-1, can you work well?

Thanks for your interest! If you set the model to sd-turbo, you would be using the distilled 1-step version of the SD2.1 model, and as you might observe, it works quite well, and is also very fast to optimize (the whole 50 step optimization process can be done in <30 seconds).
If you would replace this with the 50 step SD2.1 model, the optimization process would be much longer (~5 minutes per sample), and the results might be worse because of exploding/vanishing gradients. You could have a look at this codebase (https://github.com/salesforce/DOODL) and applying our reward models (HPSv2.1, ImageReward, PickScore) there instead of just the CLIP objective should provide improvements to the DOODL results (however, will need ~40GB VRAM and a few minutes of optimization).

Thanks for your interest! If you set the model to sd-turbo, you would be using the distilled 1-step version of the SD2.1 model, and as you might observe, it works quite well, and is also very fast to optimize (the whole 50 step optimization process can be done in <30 seconds). If you would replace this with the 50 step SD2.1 model, the optimization process would be much longer (~5 minutes per sample), and the results might be worse because of exploding/vanishing gradients. You could have a look at this codebase (https://github.com/salesforce/DOODL) and applying our reward models (HPSv2.1, ImageReward, PickScore) there instead of just the CLIP objective should provide improvements to the DOODL results (however, will need ~40GB VRAM and a few minutes of optimization).

Thank you very much for your insight. In the experiment, we found that the noise regularization appeared -INF, and then we changed the precision to float32, and got a gradient of more than -600, and the generated image has a large area of light spots. We can keep changing the learning rate without changing the spot. We think there might be a problem with the noise regularization, and we'd rather hear from you.

This is quite surprising. Are you facing these issues with one-step models (e.g. SD-Turbo, SDXL-Turbo)? The regularization objective is mostly just to ensure that the norm stays around the original value (128), but otherwise should not play a huge role (you should be able to get decent results even without it with disable_reg). Could you share some more details about the exact setting/command that you  used where you had these issues? @lucaeyring might also be able to help you here.


Update and rename lurk-yakima.toml to lurk.toml

Corrected some info, and added details.

@DeniceZ Can you take a look at this pull request?  It conflicts with your changes on the Airtable.

@jpeg07 Can you fix the conflicts?

Thanks @tbenbow - I was traveling over the weekend, so I couldn't get to it.


octavia loadbalancer check is overly sensitive; k8s LBs will always trigger alert

In a Charmed Kubernetes environment deployed on Openstack, loadbalancers are not created with health monitoring [0]. While the Provisioning Status for new K8s LBs is Active, the lack of health monitoring causes the Operating Status to be Offline. Therefore, all K8s LBs will trigger the alert for the octavia_loadbalancers check. To deal with this today, we pretty  much just add all K8s LBs to the ignore list. However, this is not sustainable, especially when the K8s cluster is heavily used and leads to a lot of noisy alerts if K8s LBs are being constantly created/deleted.
I'm not sure on the best way to address this problem, but here are some ideas of implementation:

implement smarter checking. check to see if health monitors exist before alerting
more extensive ignore logic. perhaps based on regex of names of LBs (as openstack integrator has a set naming scheme
add an option to ignore Operating Status in Loadbalancer checks.

[0] LP#1853668

Imported from Launchpad using lp2gh.

date created: 2021-03-18T14:19:43Z

owner: zzehring

assignee: None

the launchpad url

(by peppepetra)
Also charm alerts for all lbs with operating status != "ONLINE" while
"DRAINING", "NO_MONITOR" should be considered ok as well


Investigate Dapr bot failures on pull request labelling

Expected Behavior
Dapr bot should work when PRs are labelled, same way as it works when issues are labelled.
Actual Behavior
It throws an error with PR labeling. Examples:

https://github.com/dapr/components-contrib/actions/runs/3570292159/jobs/6001130766
https://github.com/dapr/components-contrib/actions/runs/3570222569/jobs/6000993804
https://github.com/dapr/components-contrib/actions/runs/3569661221/jobs/5999831951
Steps to Reproduce the Problem
Add a label to a PR.
Release Note

RELEASE NOTE: FIX Dapr bot authorization with PR labeling

/keep-alive

/keep-alive

@shubham1172 can we remove the trigger from the PRs after all? This workflow doesn't have access to the necessary credentials.


Update dartdoc to 8.2.0

Primarily introducing support for better surfacing extensions on types (changelog).

Superseded by https://github.com/flutter/flutter/commit/34457fe1f586398eadb886efa3ba109c6da883a9


Fix CI build

move tests to root and fix invocation
add python 3.8 to tested envs
temporarily mark the lint errors as non-fatal to see if the tests pass

I fixed the linter errors, and some stuff I found.
Let me incorporate the changes myself to avoid rebasing. Dont' worry, tomorrow I will start following good practices when it comes to PRing and merging.
Today I'm just putting out fires, but from tomorrow-on I will start making PRs for my own code too.

Thank you very much. I really appreciate that you help me.


Gdal builds, but no instructions for how to link it are given

GDAL builds, but no instructions on how to link are provided
When you build gdal on linux (or windows) you are not given any further instructions on how to use it or link with it.  Considering that gdal links with quite a few different libraries, it's difficult to know which ones to link with and how.  Some of them are static libraries inside of the vcpkg installed directory.
Considering that I need to build this and link against this library on both windows and linux in the upcoming weeks, I'd be happy to work on this. I'm not really sure where to start though.  gdal isn't CMake based, but it does seem to provide some amount of pkg-config information. What is the usual process for ports that are not cmake based?
Environment

OS: Linux
Compiler: g++/clang

To Reproduce
Steps to reproduce the behavior:

./vcpkg install gdal
See lack of build instructions

Expected behavior
A clear and concise description of how to link with gdal.
Failure logs
➜ ./vcpkg install gdal
Warning: Different source is available for vcpkg (2019.8.27 -> 2019.6.26). Use .\bootstrap-vcpkg.bat to update.
The following packages will be built and installed:
    gdal[core]:x64-linux
  * sqlite3[core]:x64-linux
Additional packages (*) will be modified to complete this operation.
Starting package 1/2: sqlite3:x64-linux
Building package sqlite3[core]:x64-linux...
-- Downloading https://sqlite.org/2019/sqlite-amalgamation-3280000.zip...
-- Extracting source /home/lakin/software/vcpkg/downloads/sqlite-amalgamation-3280000.zip
-- Using source at /home/lakin/software/vcpkg/buildtrees/sqlite3/src/3280000-19670be87f
-- Configuring x64-linux-dbg
-- Configuring x64-linux-rel
-- Building x64-linux-dbg
-- Building x64-linux-rel
-- Performing post-build validation
-- Performing post-build validation done
Building package sqlite3[core]:x64-linux... done
Installing package sqlite3[core]:x64-linux...
Installing package sqlite3[core]:x64-linux... done
Elapsed time for package sqlite3:x64-linux: 40.37 s
Starting package 2/2: gdal:x64-linux
Building package gdal[core]:x64-linux...
Warning: abi keys are missing values:
    libwebp
    libxml2

-- Using cached /home/lakin/software/vcpkg/downloads/gdal241.zip
-- Extracting source /home/lakin/software/vcpkg/downloads/gdal241.zip
-- Applying patch /home/lakin/software/vcpkg/ports/gdal/0001-Fix-debug-crt-flags.patch
-- Applying patch /home/lakin/software/vcpkg/ports/gdal/0002-Fix-static-build.patch
-- Applying patch /home/lakin/software/vcpkg/ports/gdal/0003-Fix-std-fabs.patch
-- Extracting source /home/lakin/software/vcpkg/downloads/gdal241.zip
-- Applying patch /home/lakin/software/vcpkg/ports/gdal/0001-Fix-debug-crt-flags.patch
-- Applying patch /home/lakin/software/vcpkg/ports/gdal/0002-Fix-static-build.patch
-- Applying patch /home/lakin/software/vcpkg/ports/gdal/0003-Fix-std-fabs.patch
-- Configuring x64-linux-rel
-- Building x64-linux-rel
-- Installing x64-linux-rel
-- Installing x64-linux-rel done
-- Configuring x64-linux-dbg
-- Building x64-linux-dbg
-- Installing x64-linux-dbg
-- Installing x64-linux-dbg done
-- Performing post-build validation
-- Performing post-build validation done
Building package gdal[core]:x64-linux... done
Installing package gdal[core]:x64-linux...
Installing package gdal[core]:x64-linux... done
Elapsed time for package gdal:x64-linux: 1.111 h

Total elapsed time: 1.122 h

Additional context
None.

Hi @lakinwecker
There's a FindGDAL module shipped with CMake, which will define target GDAL::GDAL.
find_package(GDAL REQUIRED)
target_link_libraries(mytarget PRIVATE GDAL::GDAL)

Thanks for that. Should this package print that out at the end of the installation process?
I'm still running in to some linking issues after including the above, but I will file those as a separate issue once I have confirmed it's not something wrong with my environment.

In addition, in order to get this to link, I have to add:
find_package(OpenSSL REQUIRED)
set(LIBRARIES ${LIBRARIES} OpenSSL::SSL OpenSSL::Crypto)

Without this, I get:
/usr/bin/ld: /home/lakin/software/vcpkg/installed/x64-linux/lib/libcurl.a(openssl.c.o): undefined reference to symbol 'SSL_write@@OPENSSL_1_1_0'
/usr/bin/ld: /usr/lib/libssl.so.1.1: error adding symbols: DSO missing from command line
```

Because it tries to link to my local crypto library.

Are you using the most recent version of our curl port? I could have sworn I fixed that issue...

AFAIK, I am. I pulled from master today and updated everything. Is there some output I can provide to prove it?

No I believe you. It just means I missed something.

Well, I'm happy to test stuff. Feel free to ping me if you want me to test out any PRs, etc.

@lakinwecker How I can find GDAL_INCLUDE_DIRS and GDAL_LIBRARIES variables without using FindGDAL module in CMAKE? I want to manually link this library to my build command line

Currently the usage file was provided for gdal, you can use it as following.
The package GDAL provides CMake targets:

    find_package(GDAL REQUIRED)
    target_include_directories(main PRIVATE ${GDAL_INCLUDE_DIRS})
    target_link_libraries(main PRIVATE ${GDAL_LIBRARIES})

For Linux, gdal is completely broken, #9068. I'm working on it, but there is no point in relying on pkgconfig or cmake files as long as there is no control about dependencies from the system used when building port gdal.


Use asttokens less to account for nodes that don't get position information

Hopefully this will fix #893

No, _start is a custom attribute I added at the beginning of the function. I've changed to a function to avoid confusion.

Wups, yeah ok makes sense.

Thanks!


Unicode character appeared as HTML entity

In this tweet https://twitter.com/#!/xeBuz/status/154298953389703168
the character ♥ appeared as ♥ in the timeline.

Web based clients seem to support it, but there is no pattern to unescape the HTML entity.
This will be fixed to add one line at output :tweet proc.
I'm not sure this can produce some side-effect or not.
text = CGI.unescape_html(text)


Makefile root priviledges

Would it be possible to remove sudo calls from Makefile and let people execute the script as sudo? This would solve issue eg. in Minibian where the sudo is not present.

Frankly I don't remember why I did it the way I did.
I have no objection in principle to removing sudo from the script (Arch doesn't have sudo by default either).
Unless I discover a reason not to I will make the change the next time I make a release.  I'm not sure when that will be.

Changed in V37.


Fix headings underline color in dark mode

H1, H2 headings underline color is not so bright in dark mode, fixed it.
Fixes # (issue)
Type of change

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation update

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation (including CHANGELOG updates)
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules
[ ] I have checked my code and corrected any misspellings

Hi - can you pls point me in the direction of an example of this for me to check? I had a quick look for a h1 or h2 with underline and couldn't see any...

Sorry for the confusion, I fixed the border/divider line for storybook pages in dark mode,


Param type error

https://github.com/walkor/workerman/blob/7370cfc9c09f58ab5f4e9593d23ac6069930a570/Worker.php#L1556
$worker_id type should be string not int because of function spl_object_hash returning string.
https://www.php.net/manual/en/function.spl-object-hash

Fixed and thanks.


[Go] Support Array Diff

Describe the enhancement requested
Similar to the CPP implementation of Array Diff (Python docs: https://arrow.apache.org/docs/python/generated/pyarrow.Array.html#pyarrow.Array.diff) it would be good to have the same in Go. As far as I can tell, there is an array.Equal in Go right now, but not array.Diff.
Like its CPP counterpart, given two string arrays ["one", "two", "three"] and ["two", None, "two-and-a-half", "three"] it would output a string like this:
@@ -0, +0 @@
-"one"
@@ -2, +1 @@
+null
+"two-and-a-half"

Component(s)
Go

I am happy to submit a PR for this.
Currently I', thinking it would go into a diff.go file inside go/arrow/array. The function signature would be array.Diff(left, right arrow.Array) (string, error). An error would be returned if two arrays of different types are passed in, for example. (This is also not handled in the CPP version right now (see https://github.com/apache/arrow/blob/ddd0a337174e57cdc80b1ee30dc7e787acfc09f6/cpp/src/arrow/array/diff.cc#L113-L123)

I have broken the implementation into two parts:

https://github.com/apache/arrow/pull/34806 for adding a Diff function that returns an edit script
https://github.com/apache/arrow/pull/34827 for adding a DiffString function that returns the edit script formatted using Unified Diff format (this is still in progress, opened in draft for now)


No module named '_cuda_backend'

Hello, i try to use NerfStudio as you mentioned, but rise the error like:
│ /workspace/nerf-studio-local/zipnerf-pytorch/extensions/backend.py:93 in _get_backend_name       │
│                                                                                │
│    90 │   │   │   backend_name = __import__('_cuda_backend')                                     │
│    91 │   │   except ImportError:                                                                │
│    92 │   │   │   # TODO:self.compile()                                                          │
│ ❱  93 │   │   │   backend_name = __import__('_cuda_backend')                                     │
│    94 │   │                                                                                │
│    95 │   │   return backend_name                                                                │

ModuleNotFoundError: No module named '_cuda_backend'
  In call to configurable 'Model' (<class 'internal.models.Model'>)

Then i try to pip install ./extensions/cuda, rise the error:
Processing ./extensions/cuda
  Preparing metadata (setup.py) ... done
Building wheels for collected packages: cuda_backend
  Building wheel for cuda_backend (setup.py) ... error
  error: subprocess-exited-with-error

  × python setup.py bdist_wheel did not run successfully.
  │ exit code: 1
  ╰─> [25 lines of output]
      running bdist_wheel
      running build
      running build_ext
      /home/user/.local/lib/python3.10/site-packages/torch/utils/cpp_extension.py:424: UserWarning: There are no x86_64-linux-gnu-g++ version bounds defined for CUDA version 11.8
        warnings.warn(f'There are no {compiler_name} version bounds defined for CUDA version {cuda_str_version}')
      building '_cuda_backend' extension
      creating /workspace/nerf-studio-local/zipnerf-pytorch/extensions/cuda/build
      creating /workspace/nerf-studio-local/zipnerf-pytorch/extensions/cuda/build/temp.linux-x86_64-cpython-310
      creating /workspace/nerf-studio-local/zipnerf-pytorch/extensions/cuda/build/temp.linux-x86_64-cpython-310/workspace
      creating /workspace/nerf-studio-local/zipnerf-pytorch/extensions/cuda/build/temp.linux-x86_64-cpython-310/workspace/nerf-studio-local
      creating /workspace/nerf-studio-local/zipnerf-pytorch/extensions/cuda/build/temp.linux-x86_64-cpython-310/workspace/nerf-studio-local/zipnerf-pytorch
      creating /workspace/nerf-studio-local/zipnerf-pytorch/extensions/cuda/build/temp.linux-x86_64-cpython-310/workspace/nerf-studio-local/zipnerf-pytorch/extensions
      creating /workspace/nerf-studio-local/zipnerf-pytorch/extensions/cuda/build/temp.linux-x86_64-cpython-310/workspace/nerf-studio-local/zipnerf-pytorch/extensions/cuda
      creating /workspace/nerf-studio-local/zipnerf-pytorch/extensions/cuda/build/temp.linux-x86_64-cpython-310/workspace/nerf-studio-local/zipnerf-pytorch/extensions/cuda/src
      Emitting ninja build file /workspace/nerf-studio-local/zipnerf-pytorch/extensions/cuda/build/temp.linux-x86_64-cpython-310/build.ninja...
      Compiling objects...
      Allowing ninja to set a default number of workers... (overridable by setting the environment variable MAX_JOBS=N)
      1.10.1
      creating build/lib.linux-x86_64-cpython-310
      x86_64-linux-gnu-g++ -shared -Wl,-O1 -Wl,-Bsymbolic-functions -Wl,-Bsymbolic-functions -g -fwrapv -O2 /workspace/nerf-studio-local/zipnerf-pytorch/extensions/cuda/build/temp.linux-x86_64-cpython-310/workspace/nerf-studio-local/zipnerf-pytorch/extensions/cuda/src/bindings.o /workspace/nerf-studio-local/zipnerf-pytorch/extensions/cuda/build/temp.linux-x86_64-cpython-310/workspace/nerf-studio-local/zipnerf-pytorch/extensions/cuda/src/gridencoder.o /workspace/nerf-studio-local/zipnerf-pytorch/extensions/cuda/build/temp.linux-x86_64-cpython-310/workspace/nerf-studio-local/zipnerf-pytorch/extensions/cuda/src/pdf.o -L/home/user/.local/lib/python3.10/site-packages/torch/lib -L/usr/local/cuda/lib64 -L/usr/lib/x86_64-linux-gnu -lc10 -ltorch -ltorch_cpu -ltorch_python -lcudart -lc10_cuda -ltorch_cuda -o build/lib.linux-x86_64-cpython-310/_cuda_backend.cpython-310-x86_64-linux-gnu.so
      /usr/bin/ld: cannot find /workspace/nerf-studio-local/zipnerf-pytorch/extensions/cuda/build/temp.linux-x86_64-cpython-310/workspace/nerf-studio-local/zipnerf-pytorch/extensions/cuda/src/bindings.o: No such file or directory
      /usr/bin/ld: cannot find /workspace/nerf-studio-local/zipnerf-pytorch/extensions/cuda/build/temp.linux-x86_64-cpython-310/workspace/nerf-studio-local/zipnerf-pytorch/extensions/cuda/src/gridencoder.o: No such file or directory
      /usr/bin/ld: cannot find /workspace/nerf-studio-local/zipnerf-pytorch/extensions/cuda/build/temp.linux-x86_64-cpython-310/workspace/nerf-studio-local/zipnerf-pytorch/extensions/cuda/src/pdf.o: No such file or directory
      collect2: error: ld returned 1 exit status
      error: command '/usr/bin/x86_64-linux-gnu-g++' failed with exit code 1
      [end of output]

  note: This error originates from a subprocess, and is likely not a problem with pip.
  ERROR: Failed building wheel for cuda_backend
  Running setup.py clean for cuda_backend
Failed to build cuda_backend
ERROR: Could not build wheels for cuda_backend, which is required to install pyproject.toml-based projects

My nerfstudio version is docker image1.0.2

I solved this by uninstall ninja.

Was stuck on this for a while. Thanks

I am still getting the following error after pip uninstall ninja:
        895 |     attn_output_weights = AT_DISPATCH_FLOATING_TYPES(
            |                           ^~~~~~~~~~~~~~~~~~~~~~~~~~
      error: command '/usr/bin/gcc' failed with exit code 1
      [end of output]

  note: This error originates from a subprocess, and is likely not a problem with pip.
  ERROR: Failed building wheel for cuda_backend
  Running setup.py clean for cuda_backend
Failed to build cuda_backend
ERROR: Could not build wheels for cuda_backend, which is required to install pyproject.toml-based projects

any idea? Thanks!

Since I was using Windows, I solved this problem by basically checking if visual studio is properly installed with latest version and made sure that the MSVC path is set in environment variables. Also check your gcc version and install new versions if it helps.

Can I know what CUDA version and gcc version I should use? Btw I'm on unbuntu. Thanks!

CUDA 11.8
gcc 11.4

Thanks!


Implement ability to show text in the system tray/menu bar

Use case: apps like MeetingBar show text instead of a system tray icon.

I'd love the ability to do this with Tauri:

Show text instead of the system tray icon, and be able to update it during runtime.
Show text next to the system tray icon.

However, I'm not sure if this is even possible in other operating systems. With that in mind, maybe it doesn't fit Tauri's philosophy to add a feature that will only work on macos!

On windows they are called deskbands, they don't live in the system tray exactly but rather next to it. Anyway, they are rarely used and might be tricky to implement.

I would be greatly interested in setting text for the systray on macos, I've been looking in the rust community a crate for the system tray, with this one https://github.com/olback/tray-item-rs/blob/master/src/api/macos/mod.rs, you can set a title (and for linux it just set it as the id and for windows set the tooltip) - just wanted to point out how it's implemented there

(and for linux it just set it as the id and for windows set the tooltip)

'Tooltips" on Windows and "Id" on Linux is not the same as showing text instead of the icon.
Windows and Linux, don't need to have this feature anyway, it can be macOS only.

I totally agree with your statement, they are not equivalent of showing text - was just stating what another crate is doing, alongside a possible macos implementation of showing text in the system tray/menu bar (they are using setTitle_(title) on the status item at https://github.com/olback/tray-item-rs/blob/master/src/api/macos/mod.rs#L131).
Let me come up with a PR for setting the title.

Wondering if this is possible for Linux also. I'd want it for my WIP app. From searching the webs I can't really figure out whether it's possible or not. My best attempt was this search:
https://github.com/search?q=repo%3AAyatanaIndicators%2Flibayatana-appindicator label&type=code

Unfortunately, not possible, at least with the old libappindicator (which we still use on Some distros) as for the newer app indicator libayatana-appindicator, there is virtually no good documentation available.

I managed to build a PoC using libayatana and GTK:
gtk::init().unwrap();

let mut indicator = AppIndicator::new("some-name", "");
indicator.set_status(AppIndicatorStatus::Active);
indicator.set_label(" This will display next to the icon", "");

let icon_path = Path::new(env!("CARGO_MANIFEST_DIR")).join("icons");
indicator.set_icon_theme_path(icon_path.to_str().unwrap());
indicator.set_icon_full("icon", "icon");

So it's possible!

this is now being implemented in https://github.com/tauri-apps/tray-icon/pull/11, it will not be implemented in tao

Just a heads up, I am testing on KDE and the text is not showing, so after some digging in the source code of libappindicator I found the label documentation.

A label that can be shown next to the string in the application
indicator.  The label will not be shown unless there is an icon
as well.  The label is useful for numerical and other frequently
updated information.  In general, it shouldn't be shown unless a
user requests it as it can take up a significant amount of space
on the user's panel.  This may not be shown in all visualizations.


new destination added #4

title: Kudremukha, chikamagalur Karnataka
description: Issue no: #4

thanks for merging the PR. Can you please add hacktoberfest-accepted label ?


save on commitment calculations when inserting multiple intermediate branch nodes

The recursive algorithm has the problem that, in a differential insertion context, a recursive insertion requires the creation of a commitment that needs to be updated immediately. This is costly and should be avoided.

Redundant with #270, closing


db schema

could you provide the table's schema? thanks

The schema is created automatically by the EF before a first query is executed against the database. You just point to an empty, existing database. I've modified the readme to reflect that. Also, added the Database.SetInitializer to the global.asax to make it even more explicit.
After you run the demo and any query is executed against the database (e.g. you create the user or try to login), the required tables (three at the moment) are created.

I got it , thank you so much
please close the issue  :)


Data sources?

Please define "trustworthy and reliable source" in the readme, and clarify what the sources are for your data.
What counts as a confirmed working title?
Is this project meant for Proton, Wine, Native titles?

It is simply intended to show which games work on Linux,

Anti-Cheat's for games

I would define a trustworthy and reliable source as a source where one or multiple of the following conditions are met:

Someone that is part of development team or studio of the game has confirmed something in regard to the Anti-Cheat

It is required that you can verify for yourself that the person quoted from this source is who he claims to be

Multiple people that all describe the same symptoms of the anti-cheat working (i.e. a ProtonDB listing, where recent reports all seem to indicate that the game is working)

Preferably includes the required steps to reproduce the described behavior
There are game logs that suggest the game is doing something specific when it detects Linux (i.e. PSO2 explicitly allows Linux currently)

A link to the game which works out of the box (can also be a ProtonDB listing)

A note to the ProtonDB Listings:
It would be greatly preferred when there are indications that suggest that the game explicitly changed something regarding their anti-cheat - e.g. addition of the required EAC files for linux (if applicable please also provide a steamdb link then as well as a protondb listing which shows that the game does indeed function after said changes have been done)

Is this project meant for Proton, Wine, Native titles?

All of the them.

What counts as a confirmed working title?

You can read up on the definitions on the website by expanding "Legend"


Releases with CI-built binaries

It'd be really nice if this repo included releases with usable binaries.
Would there be any interest in a PR to set up a Github Actions workflow that uses goreleaser to build and publish release artifacts when a semver tag is pushed?
I would propose configuring it to publish a "plain" binary as well as a deb, targeting at least amd64 to start. (The configuration to add other targets is trivial.)

In general I would be in favor of this if it provides value. I'm not very familiar with goreleaser. Are there other examples of google projects on github that I can reference to get familiar with the tool?

I'm not familiar with the project in particular, but searching just within Google projects on Github, https://github.com/google/go-containerregistry is using goreleaser. (Looks like that project is still using Travis for some stuff instead of going all-in on GitHub actions, however.)
Goreleaser is a replacement for makefile+docker building that provides a standard solution for:
• Building artifacts (optionally in a matrix of different architectures, operating systems, go versions, etc...)
• Uploading the artifacts as a github release
• Uploading a sibling artifact with the sha256's of the other artifacts
• Automatically collecting commit subjects to give the release notes
It's preferable to use it from within GitHub actions because GitHub takes care of providing a GITHUB_TOKEN environment secret that goreleaser (or whatever else) can use to upload the release artifacts that grants access only to the repository the action is run in.
The upside of artifacts in general would be that it becomes possible for me (and countless other users) to have our startup scripts/packer scripts/etc include just a couple lines to install a ready-to-use artifact that's hosted by GitHub, instead of having to either maintain our own CI building this or script in a "go install" on systems that have no business having a go installation.


Generated object contains more than the defaults

After running this code:
var jsonSchemaDefaults = require("json-schema-defaults")

var schema = {
    type: "object",
    properties: {
        host: {
            type: "string",
            default: "localhost"
        },
        port: {
            type: "number",
            default: 9000
        },
        dbLogging: {
            type: "object",
            properties: {
                url: {
                    type: "string"
                },
                username: {
                    type: "string"
                },
                password: {
                    type: "string"
                },
            },
            required: ["url"]
        }
    },
    required: ["host", "port"]
};

var result = jsonSchemaDefaults(schema);

The value of result is
{
    host: "localhost",
    port: 9000,
    dbLogging: {}
}

I did not expect the empty dbLogging object in the result. This is problematic for 2 reasons. I planned to merge result with a json configuration file and do something like this:
if (result.dbLogging) {
   // log to db
}

This will not work since result.dbLogging will always be true.
The other problem is that result will fail validation against the schema since dbLogging.url is required.
So what I would like is for properties that have no defaults to not be included in the object created by json-schema-defaults. Alternatively you could add an option to make it behave like that.
Runkit for my code example: https://runkit.com/58bbfdff9ac6080014e54cb7/58bbfdff9ac6080014e54cb8

I think it's better to include empty objects and arrays when the field is in required list.
Also, inside arrays it should check minItems setting to pre-generate this number of defaults (for example minItems empty objects). Right now it would create one empty object inside array always.
I can PR these changes if you agree.

IIRC we added empty object because it there was null in an array, like [null]. If you have time to tackle this into a PR and cover these different cases, I'll be happy to review it!

Although it might've been just that creating the object seemed easier implementation-wise, and we haven't considered all consequences.


memeify shows up on edit page but doesn't do anything

Go to edit a claim in your channel. Memeify button shows up, but is inoperable.

Good catch!

Do we want to offer a choice between editing this claim and publishing new from existing image?


YoloV7 Training Colab Error: AttributeError: module 'numpy' has no attribute 'int'`

Attempted to run the YoloV7 training colab without any modification:
https://colab.research.google.com/github/luxonis/depthai-ml-training/blob/master/colab-notebooks/YoloV7_training.ipynb#scrollTo=Z7rEpSboRibz
The first error occurred after running
!python train.py --epochs 2 --workers 8 --device 0 --batch-size 32 --data data/voc.yaml --img 640 640 --cfg cfg/training/yolov7_voc-tiny.yaml --weights 'yolov7-tiny.pt' --hyp data/hyp.scratch.tiny.yaml

/usr/local/lib/python3.8/dist-packages/torch/functional.py:504: UserWarning: torch.meshgrid: in an upcoming release, it will be required to pass the indexing argument. (Triggered internally at ../aten/src/ATen/native/TensorShape.cpp:3190.)
  return _VF.meshgrid(tensors, **kwargs)  # type: ignore[attr-defined]
Model Summary: 263 layers, 6066402 parameters, 6066402 gradients, 13.3 GFLOPS

Transferred 330/344 items from yolov7-tiny.pt
Scaled weight_decay = 0.0005
Optimizer groups: 58 .bias, 58 conv.weight, 61 other
train: Scanning 'VOCdevkit/voc_07_12/labels/train.cache' images and labels... 16551 found, 0 missing, 0 empty, 0 corrupted: 100% 16551/16551 [00:00<?, ?it/s]
Traceback (most recent call last):
  File "train.py", line 616, in <module>
    train(hyp, opt, device, tb_writer)
  File "train.py", line 245, in train
    dataloader, dataset = create_dataloader(train_path, imgsz, batch_size, gs, opt,
  File "/content/yolov7/utils/datasets.py", line 69, in create_dataloader
    dataset = LoadImagesAndLabels(path, imgsz, batch_size,
  File "/content/yolov7/utils/datasets.py", line 418, in __init__
    bi = np.floor(np.arange(n) / batch_size).astype(np.int)  # batch index
  File "/usr/local/lib/python3.8/dist-packages/numpy/__init__.py", line 284, in __getattr__
    raise AttributeError("module {!r} has no attribute "
AttributeError: module 'numpy' has no attribute 'int'

Your help would be much appreciated!
Happy new year and holidays!

curl api.roboflow.com

I had to edit the install string in several areas to account for the changing dependencies.
This was for the YOLOv6n training Colab page but it may help you.
I had to specify numpy==1.23.1.
My full updated install string is (currently ;) ):
!pip install -U -q torch==1.13.0 torchvision>=0.9.0 protobuf==3.19.5 numpy==1.23.1 opencv-python>=4.1.2 PyYAML>=5.3.1 scipy>=1.4.1 tqdm>=4.41.0 addict>=2.4.0 tensorboard==2.9.0 pycocotools>=2.0 onnx>=1.10.0 onnx-simplifier>=0.3.6 thop

I had to edit the install string in several areas to account for the changing dependencies.
This was for the YOLOv6n training Colab page but it may help you.
I had to specify numpy==1.23.1.
My full updated install string is (currently ;) ):
!pip install -U -q torch==1.13.0 torchvision>=0.9.0 protobuf==3.19.5 numpy==1.23.1 opencv-python>=4.1.2 PyYAML>=5.3.1 scipy>=1.4.1 tqdm>=4.41.0 addict>=2.4.0 tensorboard==2.9.0 pycocotools>=2.0 onnx>=1.10.0 onnx-simplifier>=0.3.6 thop

It works thank you very much Deon!


Add Parallels to MacOS image

Tool name
Parallels + Parallels SDK
Tool license
Paid.  We can supply our own paid license when our builds begin
Add or update?

[X] Add
[ ] Update

Desired version
latest Parallels (currently 18.0.0-53049)
latest ParallelsVirtualizationSDK (currently 17.1.4-51567)
Approximate size
43 + 324 = 367MB (.dmg files)
Brief description of tool
https://download.parallels.com/desktop/v18/18.0.0-53049/ParallelsDesktop-18.0.0-53049.dmg
https://download.parallels.com/desktop/v17/17.1.4-51567/ParallelsVirtualizationSDK-17.1.4-51567-mac.dmg
Parallels is a virtualization framework for MacOS.  We produce some VM images using Packer and Parallels is one of the flavors.  On MacOS 10.15 we can install Parallels in our setup script and it works fine.  On MacOS 11 and newer the kernel extension requires a reboot so it cannot be installed during the build.  We need it baked into the agent image with the kernel extension already loaded.
We can happily supply our own license at runtime using prlsrvctl install-license --key $PARALLELS_LICENSE_KEY.  We just need the kernel extension loaded ahead of time.
URL for tool's homepage
https://www.parallels.com/
Provide a basic test case to validate the tool's functionality.
prlctl --version
open -a 'Parallels Desktop'

Platforms where you need the tool

[X] Azure DevOps
[ ] GitHub Actions

Virtual environments where you need the tool

[ ] Ubuntu 18.04
[ ] Ubuntu 20.04
[ ] Ubuntu 22.04
[ ] macOS 10.15
[ ] macOS 11
[X] macOS 12
[ ] Windows Server 2019
[ ] Windows Server 2022

Can this tool be installed during the build?
brew install --cask parallels
brew install --cask parallels-virtualization-sdk

(A reboot is needed afterwards)

Tool installation time in runtime
30 seconds maybe
Are you willing to submit a PR?
Yes

Hello @dmachaj.
We have decided not to add Parallels software on macos images due to license policy and maintenance complexity. If we see  a lot of requests from customers to add it we will reopen the thread.

@al-cheb I have been communicating with Parallels support.  One option is simply to get the kernel extension approved without otherwise installing Parallels.  That would avoid the license policy concern.
The approach would be:

Install Parallels
Approve the Parallels Kernel Extension
Reboot
Uninstall Parallels

The only remainder in the image would be the kernel record that the Parallels extension is approved.  Workloads that require Parallels can then install the same version of Parallels and the kernel extension will already be approved with no reboot required.  That would unblock us.

@al-cheb For context: The Parallels VMs that we produce get nearly a million downloads per year.
This is a high priority item for us and we would greatly appreciate any assistance that we can get to close on this.

@dmachaj, Do you have a code snippet that we can use to validate a pipeline except the installation step?

Could you please elaborate on the question?  I don't think I fully understand.  Are you looking for a pipeline that would test if Parallels is registered properly?  Or one that would use it?  If the latter please send me an email and I can point you to our MacOS build pipeline that uses Parallels.

@dmachaj,  Are you looking for a pipeline that would test if Parallels is registered properly? - Yep, I am looking for the steps how we can validate it.

@dmachaj, the new macos-12 image has been deployed.


README incorrectly claims deploy-pages needs a gzipped tarball

As previously mentioned here:

I was struggling with why deploy-pages was rejecting my artifact, and it turns out it is because I was following the README and gzip-compressing my tarball. Removing that step resolved the issue. [...] Deploy-pages expects a zip containing an uncompressed tar.

Please update the misleading README. It should not mention "gzip", and it should note that upload-artifact, used internally, creates a zip for you.

I think it says if you do not choose to use upload-artifact.
While choosing to use this action as part of your approach to deploying to GitHub Pages is technically optional, we highly recommend it since it takes care of producing (mostly) valid artifacts.

However, if you do not choose to use this action but still want to deploy to Pages using an Actions workflow, then you must upload an Actions artifact that meets the following criteria:

...


[CT-2074] [Bug] Error message for exposures gives incorrect node type for TargetNotFound

Is this a new bug in dbt-core?

[X] I believe this is a new bug in dbt-core
[X] I have searched the existing issues, and I could not find an existing issue for this bug

Current Behavior
Assume I have the following exposure:
version: 2

exposures:

  - name: weekly_metrics
    label: Some Label
    type: dashboard
    maturity: high
    url: https://bi.tool/dashboards/1
    description: >
      Did someone say "exponential growth"?

    depends_on:
      - ref('fact_orders')
      - ref('dim_customers')
      - metric('testing')

    owner:
      name: Callum McData
      email<EMAIL_ADDRESS>
But I the node metric('testing') does not actually exist in my project. If this is the case, I get the following error message when trying to compile:

Compilation Error
Exposure 'exposure.dbt_metrics_integration_tests.weekly_metrics' (models/materialized_models/exposures.yml) depends on a source named 'testing' which was not found

This is incorrect because we can clearly see that this is a metric and not a source. When trying out the same functionality with a model node, I get the correct type displayed in the error message. IE:

depends on a node 'testing' which was not found

Expected Behavior
I would expect that the CompilationError returned by dbt core would identify the correct target node type. However, for the life of me I cannot figure out where this is coming from. I am fairly certain the error message is arising from TargetNotFoundError but I was unable to find the path that routed into there with this issue.
Steps To Reproduce

Create an exposure that is referencing a metric that doesn't exist

Relevant log output
Shown in earlier messages

Environment
- OS: MacOS
- Python: 3.10
- dbt: 1.4.1

Which database adapter are you using with dbt?
postgres
Additional Context
No response

@callum-mcdata Thanks for opening! I think this is a one-liner:
https://github.com/dbt-labs/dbt-core/blob/311a57a21e61955904202bdb469c2077202e9073/core/dbt/parser/manifest.py#L1260-L1271
target_kind should be "metric", not "source"!

@jtcohen6 yep - that's the smoking bullet right there! Tested it out on my local and it resolved the issue. Fixed via PR #6934


fix(CX-2429): Artwork Detail Page | Insights tab is displayed even when Insights are not available

The type of this PR is: Bugfix

This PR resolves CX-2429
Description

When Market insights, Auctions Results and Comparable Works are not available - show only ABOUT tab
In other cases show both tabs
In addition corrected bottom paddings of about and insights components
PR Checklist (tick all before merging)

[x] I have included screenshots or videos to illustrate my changes, or I have not changed anything that impacts the UI.
[x] I have tested my changes on iOS and Android.
[x] I have added tests/stories for my changes, or my changes don't require testing/stories, or I have included a link to a separate Jira ticket covering the tests.
[x] I have added a feature flag, or my changes don't require a feature flag. (How do I add one?)
[x] I have documented any follow-up work that this PR will require, or it does not require any.
[x] I have added an app state migration, or my changes do not require one. (What are migrations?)
[x] I have added a changelog entry below or my changes do not require one.

Before
After

https://user-images.githubusercontent.com/36167539/159500339-227da0ad-0b3f-4e01-94f3-cf10db2253f1.mp4
https://user-images.githubusercontent.com/36167539/159500017-2803586a-19c7-4951-9cba-1b6f87a03de0.mp4

To the reviewers 👀

[ ] I would like at least one of the reviewers to run this PR on the simulator or device.

Changelog updates
Changelog updates

Cross-platform user-facing changes

Hide Insights tab in the Artwork page when Market insights, Auctions Results and Comparable Works are not available - daria

iOS user-facing changes

Android user-facing changes

Dev changes

Thanks @MounirDhahri  for your help 🚀


[T3A3][F09-A4]Peh Xian Bin, Eugene

Ready for review
Input and Expected test case adapted from Bernard Tan Ke Xuan

Good job! Keep trying!


Fix overrun in README

The README includes an example that allocates a single byte
buffer an sprintf's to that. This might work due to a quirk
with aligning to 8-byte boundaries but "%02x " is always
going to be 2 characters + 2 hex + 1 space + nul (7 characters)
which is a little dicey.
snprintf makes this safer because snprintf accounts for the
buffer length.

Thanks for your contribution, this is a very nice revision.


Why no CSS?

Is there a way to make it preview the whole project, not just the html files?

It works perfectly fine with css files. Can you outline the steps needed to reproduce your problem?

It's a simple standard html/css/js project. Html files are linked to their css files normally. As of yet, only html shows, as if their  tags weren't there. Could it be the usage of Bootstrap? I am using two css sources: Bootstrap and a second css file.

@101is5 I can't reproduce the issue. Can you let me know what code you use to trigger the issue?


k8s modular upgrade design doc

Issue #, if available:
Description of changes:
Testing (if applicable):
Documentation added/planned (if applicable):
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/approve


[FEATURE] Adaptive length of different parts of blockId

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Search before asking

[X] I have searched in the issues and found no similar issues.

Describe the feature
I found some problems about BlockID in production env.

Due to too much iterations, some apps' (like XGBoost training using Spark) taskAttempt ID is large, which means the fixed length of 21 is not enough.
Due to above problem, I increase the TASK_ATTEMPT_ID_MAX_LENGTH to 23 and decrease the MAX_SEQUENCE_NO to 6. Pity, I found some apps will fail due to the exceeding the  MAX_SEQUENCE_NO range.

Under the hood of BLOCKID construction
BlockID will be created by 3 parts, including partitionId, taskAttemptId and sequenceNumber. If using the fixed length for every part, it's hard to be adapt with different applications.
So why not using the adaptive length of different parts of blockId? As we know, the partition number has been determinated before writing. That means we could adjust the rest 2 parts' length according to the partition number dynamically.
BTW, another solution is to decrease the MAX partitionID length, the default value of 24 is too large.
Motivation
No response
Describe the solution
No response
Additional context
No response
Are you willing to submit PR?

[X] Yes I am willing to submit a PR!

If we  increase TASK_ATTEMPT_ID_MAX_LENGTH, it will cause more GC.

If we increase TASK_ATTEMPT_ID_MAX_LENGTH, it will cause more GC.

why

If we increase TASK_ATTEMPT_ID_MAX_LENGTH, it will cause more GC.

why

Because the implement of Roaringbitmap. If we increase the length of TASK_ATTEMPT_ID_MAX_LENGTH, it will occupy more memory.

Sorry, I can’t get your thought. Could you help give a link of roaringbitmap about this?

You can see https://arxiv.org/pdf/1402.6407.pdf .

You can see https://arxiv.org/pdf/1402.6407.pdf .

Thanks. Let me take a look later.
And for this problem, how about decreasing partitionMaxLen to 20 by default, and the reduced length is given to seqNo?

You can see https://arxiv.org/pdf/1402.6407.pdf .

Thanks. Let me take a look later.
And for this problem, how about decreasing partitionMaxLen to 20 by default, and the reduced length is given to seqNo?

Maybe, we should have more discussion about this problem.

BTW, if we could make this length as a client side config, this will more flexible. WDYT? @jerqi .

Make sense.

@awdavidson
In PR #749, @advancedxy propose a new possibility to solving this. refer https://github.com/apache/incubator-uniffle/pull/749#issuecomment-1486540366
But for my thought, it sounds good to me. But in the current codebase, the taskAttemptId must be a real value, some code will retrieve this from this blockId and do some validation. I'm not sure whether removing this part or optimize.

What’s the feasibility of using a combination of the stageId and taskId? What else can be done?

I'm not sure what do you mean.  Could you help describe more?

@awdavidson
In PR #749, @advancedxy propose a new possibility to solving this. refer #749 (comment)
But for my thought, it sounds good to me. But in the current codebase, the taskAttemptId must be a real value, some code will retrieve this from this blockId and do some validation. I'm not sure whether removing this part or optimize.

What’s the feasibility of using a combination of the stageId and taskId? What else can be done?

I'm not sure what do you mean. Could you help describe more?

@zuston Thank you for the reply, yes I did notice that proposal and I agree with comments such as
Also, I'm more concerned about the compatibility issues. To make the length of fields in block ids adaptive itself is appealing,
it's just that we really have to think it through and make sure it wouldn't break things.

In my opinion exposing this to the end user introduces risk and makes the assumption they know what they are doing. It would be ideal to have a implementation that just works without the end user needing to worry.
Sure, so firstly, I mean the taskId index. Currently taskId increments across the life of the application and represents the total number of tasks, which for uniffle has an upper limit.
Can't support taskAttemptId[3786263], the max value should be 2097151

taskId index is reset in each stage as the index relates to only the task set of the stage. Using a combination of the stageId and taskId index would help increase the upper limit especially for applications running iterative algorithms, rather than have [1, ..., 20] you would have [1_1, .. , 1_10, 2_1, .. , 2_10]. The blockId would be made up of something like: long partitionId, long stageId, long taskIdIndex, long atomicInt

@awdavidson
In PR #749, @advancedxy propose a new possibility to solving this. refer #749 (comment)
But for my thought, it sounds good to me. But in the current codebase, the taskAttemptId must be a real value, some code will retrieve this from this blockId and do some validation. I'm not sure whether removing this part or optimize.

What’s the feasibility of using a combination of the stageId and taskId? What else can be done?

I'm not sure what do you mean. Could you help describe more?

@zuston Thank you for the reply, yes I did notice that proposal and I agree with comments such as
Also, I'm more concerned about the compatibility issues. To make the length of fields in block ids adaptive itself is appealing,
it's just that we really have to think it through and make sure it wouldn't break things.

In my opinion exposing this to the end user introduces risk and makes the assumption they know what they are doing. It would be ideal to have a implementation that just works without the end user needing to worry.
Sure, so firstly, I mean the taskId index. Currently taskId increments across the life of the application and represents the total number of tasks, which for uniffle has an upper limit.
Can't support taskAttemptId[3786263], the max value should be 2097151

taskId index is reset in each stage as the index relates to only the task set of the stage. Using a combination of the stageId and taskId index would help increase the upper limit especially for applications running iterative algorithms, rather than have [1, ..., 20] you would have [1_1, .. , 1_10, 2_1, .. , 2_10]. The blockId would be made up of something like: long partitionId, long stageId, long taskIdIndex, long atomicInt

task id is not identical in one stage. There could be duplicate tasks due to task retry or task speculation. We rely that info to deduplicate shuffle data in the shuffle read part.

A combination of task id and attempt number would be unique within a stage? Obviously you can have stage retries so I guess that would have to be taken into consideration.
Or uniffle should shuffle taskAttemptId to Long.MAX_VALUE?

@advancedxy  any more thoughts on this?

Is this BlockID opaque to the RSS, or does the RSS extract and use the partitionId, taskAttemptId and sequenceNumber of a BlockID?

Can you point me to the code, I could not find that.

Given partitionId is 32 bit and taskAttemptId even 64 bit, there is always a chance that the BlockID overflows, no matter how we balance the different parts. Can you elaborate a bit on the design decision taken to have BlockID contain those parts, and in favour of what benefits you sacrifice large number of partitions or tasks.
I am happy to work out alternatives and contribute, but a bit of background knowledge is needed here. Maybe comments in on Github is not the best format to elaborate on this issue. Happy to chat elsewhere.

Given partitionId is 32 bit and taskAttemptId even 64 bit, there is always a chance that the BlockID overflows, no matter how we balance the different parts. Can you elaborate a bit on the design decision taken to have BlockID contain those parts, and in favour of what benefits you sacrifice large number of partitions or tasks.
I am happy to work out alternatives and contribute, but a bit of background knowledge is needed here. Maybe comments in on Github is not the best format to elaborate on this issue. Happy to chat elsewhere.

OK.  We have a slack channel or we can use a google meeting to communicate online.

Hey @EnricoMi Do you want to optimize this part? I prefer the length config could be held in the client firstly. After that, we could do more optimization about this.
Because the current server and client will access this conf at the same time and supposed that it will not changed. This is not proper.

I found some apps will fail due to the exceeding the  MAX_SEQUENCE_NO range

@zuston which Spark version were you using?

I also encountered the problem of block id overflow.
The block id is used to verify whether the accurate block set is obtained. I think we can get the sequence id from shuffle server. It will be almost impossible for overflow to occur.
But task id, task attempt id and partition id should be moved from block id.

Here is a suggestion to make the bit lengths configurable: #1528
Here is a suggestion to effectively make those ids not overflow any more (for Spark): #1512

Fix #1529 has been merged into master. That should mitigate the task attempt id overflow for Spark3.


processing Hyperfine scans

I have some images from Hyperfine, which I'd like to process to get "super resolution" scans. I actually have 3 T1-weighted and 3 T2-weighted scans, i.e. I do have high-resolution (well, 1.5mm) in each plane.
I tried your pretrained model on each pair of scans (it doesn't seem that you support using multiple images of a single modality).

T1 ax and T2 ax
T1 cor and T2 cor
T1 sag and T2 sag

The output is quite different for each pair of scans (and none of the outputs really matches the reference HR T1-MPRAGE that I have). So I'm coming to you for advice to move forward.
I know that your model requires the FSE sequence for T1 and T2. Here is what I have:

for T1, T1_Gray_White_Contrast_(DL)
for T2, T2-Weighted_FSE_(DL)
So, perhaps I have the wrong sequence for the T1 scan.
Could I retrain the model? I looked at the tutorials (5 and 6) but couldn't quite see what knobs to turn.

Are your models brain-specific? From the training images in the data folder I would assume so. I am interested in getting super resolution for the whole head, i.e. also scalp, skull and CSF. Would I need to retrain the models with my own whole head images?
Finally -- is there an easy way to combine several scans of the same modality?

Hello,
the plain SynthSR doesn't handle multi-modality cases. For this reason, we trained another model only dedicated to Hyperfine scans, with stricter requirements:

it is for the "standard" Hyperfine T1 and T2 acquisitions (FSE sequence) at 1.5x1.5x5mm axial resolution (so don't use it with coronal or sagittal scans).
If there is motion between the T1 and T2 scans, the T2 needs to be pre-registered to the space of the T1 (see README file for more explanations).

This model is supposed to handle whole brain scans, so it should work in your case. And I don't understand what you mean by "is there an easy way to combine several scans of the same modality?". You can super-resolve several scans at the same time by putting them in the same folder and calling synthsr on this folder.
Hope this helps,
Benjamin

Hi Benjamin,

it is for the "standard" Hyperfine T1 and T2 acquisitions (FSE sequence) at 1.5x1.5x5mm axial resolution (so don't use it with coronal or sagittal scans).

thank you, I missed the axial constraint.

And I don't understand what you mean by "is there an easy way to combine several scans of the same modality?" You can super-resolve several scans at the same time by putting them in the same folder and calling synthsr on this folder.

What I saw is that if there are multiple images in a folder, they are resolved one by one (and in the case of two folders with T1 and T2, they are resolved pair by pair, in order). So say I had two axial T1s from Hyperfine, I'd need to average them myself first before running these models.
If I wanted to retrain the model on e.g. the coronal or sagittal scans, could I do that? Thank you!

sorry for the (very) late answer.

So say I had two axial T1s from Hyperfine, I'd need to average them myself first before running these models.
Correct.

If I wanted to retrain the model on e.g. the coronal or sagittal scans, could I do that?
Yes, sure. You'll need a bunch of training segmentation maps (with labels for cerebral and extra-cerebral structures), and probably a segmentation network.


Samples only change by clicking on them, not via selection model.

I used the arrow up and down keys to activate different samples and noticed that nothing happens. It seems like you are listening to mouse clicks and not to selection model events of the left-hand side ListView.

Yes, that's correct. Sidebar doesn't support keyboard navigation for the moment.

Fixed with https://github.com/mkpaz/atlantafx/commit/978577dc6a9a785e72241e3d8b3d9a48c2fab6a1


implement the Go debugger

First time implementing this; let me know if I missed something!
closes #852

Will be spending today manually testing this PR on AKS. Will report back with my findings.

Okay. I got as far as spawning the debug process but was blocked via listen tcp <IP_ADDRESS>:10000: bind: address already in use. I'm assuming that port is owned by the kubernetes extension's own debug process.

By "that port is owned by the Kubernetes extension's own debug process" do you mean the port that VS Code uses to attach to the Extension Development Host for debugging extension development?  I don't think that's 10000 - it is a Node process, and looks like it used to use 9229 by default but now uses a random one (https://github.com/microsoft/vscode/issues/85328).

do you mean the port that VS Code uses to attach to the Extension Development Host for debugging extension development?

Yes. I'll see if I can re-test this today

Here's the output from my debugging console when testing this out:

couldn't start listener: listen tcp <IP_ADDRESS>:10000: bind: address already in use
Process exiting with code: 1

I'm assuming the listener in this case would be delve?

Found the source: https://github.com/Azure/vscode-kubernetes-tools/blob/a677ed7be5091a15cddcfad6f09262f5a9875a34/src/debug/debugSession.ts#L407-L410

Oh! I think I see why... So kubectl port-forward is port-forwarding to port 10000. Delve is attempting to start a debug session on that same port... Of course that would explain why the debug session won't run. :headsmack:
I'll see what I can do to attach the right configuration for this.

Figured it out. By default, the Go debugger runs in "local" mode when using the "attach" request. I had to switch that over to the "remote" mode to ensure it would attach to the delve server instead of trying to start a new one.

When can we expect this to be released?
Is it planned for the next release (1.4.0)?


Introduce AST nodes for PatternMatchClass arguments

Summary
This PR introduces two new AST nodes to improve the representation of PatternMatchClass. As a reminder, PatternMatchClass looks like this:
case Point2D(0, 0, x=1, y=2):
  ...

Historically, this was represented as a vector of patterns (for the 0, 0 portion) and parallel vectors of keyword names (for x and y) and values (for 1 and 2). This introduces a bunch of challenges for the formatter, but importantly, it's also really different from how we represent similar nodes, like arguments (func(0, 0, x=1, y=2)) or parameters (def func(x, y)).
So, firstly, we now use a single node (PatternArguments) for the entire parenthesized region, making it much more consistent with our other nodes. So, above, PatternArguments would be (0, 0, x=1, y=2).
Secondly, we now have a PatternKeyword node for x=1 and y=2. This is much more similar to the how Keyword is represented within Arguments for call expressions.
Closes https://github.com/astral-sh/ruff/issues/6866.
Closes https://github.com/astral-sh/ruff/issues/6880.

Adding these AST nodes does require a bunch of boilerplate, but I think it's worth it for the improved representation.


push config for cisco 8000e

This pull adds push config for cisco devices. It also remove bgp config from default config for 8000e since these type of config needs to be loaded by tests when is needed.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

35 of 41 (85.37%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.2%) to 64.887%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

topo/node/cisco/cisco.go
35
41
85.37%

Totals

Change from base Build<PHONE_NUMBER>:
0.2%

Covered Lines:
3439

Relevant Lines:
5300

💛  - Coveralls

/gcbrun

/gcbrun


Issue #15 Add support to edit the prompt after analysing it

Description:
Add support to edit the processed prompt. There are two ways to solve this problem :

Either there should be an option to edit the prompt on the same page like shown below

Or when we click 'Back to input' button then the prompt should be visible as it is (as shown below)

Tasks:

[ ] Add support to save the prompt to edit it
[ ] When the user clicks 'Back to input' then the prompt should be saved there and it should be editable.

Technical Requirements:

Tailwind CSS
React JS

Acceptance Criteria:

Prompt should be editable after we are done with 'Analyse Text'

Hey can u assign the task to me

@divyesh-mali can I work on it?

@MadhurSaluja I have assigned you this task keep me updated on the progress

@Siddheshuncodes Hi I started working on it, can you pls provide more detailed how to get to the part where it has to be fixed if you know the file need to be fixed, and if you can provide me with API key required to test it.


Unable to connect to Postgres using provided credentials

I am trying to migrate an existing project that uses Sequelize over to SST. I'm getting timeouts while connecting to the database created by SST.
I'm following these guides as starting point:
https://sst.dev/docs/component/aws/postgres
https://sst.dev/docs/start/aws/drizzle

The VPC configured for the function does not have NAT enabled. Enable NAT by configuring "nat" on the "sst.aws.Vpc" component.

First of all, I am seeing this error 👆 if I create a Vpc component and include it on a Cron component. I'm not sure if I need to set the vpc property on each component or if just using link is enough. The guides show it being done both ways. I do NOT see this error if I only include vpc on the Nextjs component.
For now, I am using link on both and I am including vpc on Nextjs but not on Cron. Regardless, both show timeout error when connecting to database.

ConnectionError [SequelizeConnectionError]: connect ETIMEDOUT <IP_ADDRESS>:5432

I am seeing this error 👆 when attempting to connect to the database during runtime. Here is the SST config and Sequelize connection code. What am I missing?
sst.config.ts
export default $config({
  app(input) {
    return {
      name: "xxxxxxx",
      removal: input?.stage === "production" ? "retain" : "remove",
      home: "aws",
    };
  },
  async run() {
    const vpc = new sst.aws.Vpc('MyVpc');

    const database = new sst.aws.Postgres('MyDatabase', { vpc });

    const bucket = new sst.aws.Bucket("MyBucket", {
      public: true,
    });

    const email = new sst.aws.Email('MyEmail', {
      sender<EMAIL_ADDRESS>    });

    new sst.aws.Cron("CronMonitorCheck", {
      job: {
        handler: "src/server/index.check",
        link: [bucket, database, email],
      },
      schedule: "rate(5 minutes)",
    });

    const nextjs = new sst.aws.Nextjs("MyWeb", {
      environment: {
        NEXT_PUBLIC_BUCKET_DOMAIN: bucket.domain,
      },
      link: [bucket, database],
      vpc,
    });

    return {
      bucket_name: bucket.name,
      web_url: nextjs.url,
      database_username: database.username,
      database_password: database.password,
      database_host: database.host,
      database_port: database.port,
      database_database: database.database,
      database_clusterarn: database.clusterArn,
      database_clusterid: database.clusterID,
      database_secretarn: database.secretArn,
      database_urn: database.urn,
      email: email.sender,
    };
  },
});

src/server/index.ts
const sequelize = new Sequelize({
    host: Resource.MyDatabase.host,
    port: Resource.MyDatabase.port,
    database: Resource.MyDatabase.database,
    username: Resource.MyDatabase.username,
    password: Resource.MyDatabase.password,
    dialect: 'postgres',
    dialectOptions: {
      ssl: true,
    },
});

you need to set the nat property on the Vpc component if you are going to use it with lambda functions - it's a requirementare you running into this error in dev mode? or when deployed?

This is all happening in dev mode. I did also try setting the nat property. There is a mismatch between the allowed value in typescript and what it says in the docs. Should it be "gateway" or "managed"?

I tried setting it to "managed" and adding the vpc prop:
const vpc = new sst.aws.Vpc('MyVpc', { nat: 'managed' });

const database = new sst.aws.Postgres('MyDatabase', { vpc });

new sst.aws.Cron("CronMonitorCheck", {
  job: {
    handler: "src/server/index.check",
    link: [bucket, database, email],
    vpc
  },
  schedule: "rate(5 minutes)",
});

...

Now I'm running into this issue. I was not having this issue when I tried previously:
|  Error       CronMonitorCheck sst:aws:Cron → CronMonitorCheckHandlerFunction aws:lambda:Function
|  updating urn:pulumi:oscararmstrong::policy-tracker::sst:aws:Cron$sst:aws:Function$aws:lambda/function:Function::CronMonitorCheckHandlerFunction: 1 e
rror occurred:
|
|  InsufficientRolePermissions: The function's execution role doesn't have permission to perform this operation.

in dev mode your code is running locally so it won't be able to connect to rds that way.  i suggest looking closely at the examples/aws-rds example we have - we specifically avoid needing to put our functions in a vpc by using the data api

if you need to use sequelize which maybe does not support data api you will need to do much more advanced setup in dev mode where you create a tunnel to your database - or run the database locally and conditionally connect to italso conditionally set your lambda in a vpc only in non-dev mode

Okay, that makes sense. I will take the second approach and use a local postgres during development for now. Thank you.


Enable aphrodite-add-style-variable-name rule in eslint-plugin-khan demo project

Summary:
Now that the eslint-plugin-khan package is released with the new aphrodite-add-style-variable-name rule, we can update the demo project to test that the rule works as expected
Issue: FEI-5952
Test plan:
Linting error

Run yarn lint in packages/eslint-plugin-khan/demo
Notice there is an error for the aphrodite-add-style-variable-name rule

Hints in vs code

Open packages/eslint-plugin-khan/demo in vs code
Open the foo.tsx file
Notice the linting error on the variable name when using addStyle

I noticed the error message could be improved, I'll land that update first and release that before setting this for review! https://github.com/Khan/wonder-stuff/pull/1096


Do not strip suffices from host local-engine

When debugging a host --local-engine the tool should not try to strip host architecture suffices (as it does when passed ios_debug_unopt => host_debug_unopt), instead trust the value is correct and use unmodified.
Fixes https://github.com/flutter/flutter/issues/112679
Pre-launch Checklist

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[x] I signed the CLA.
[x] I listed at least one issue that this PR fixes in the description above.
[x] I updated/added relevant documentation (doc comments with ///).
[x] I added new tests to check the change I am making, or this PR is test-exempt.
[x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@zanderso @jonahwilliams @cbracken can you think of unintended consequences of doing this?


added default database to InfluxDBClient query method

Avoid having to specify the database at each query

@nemesisdesign I think we should do this in the functions calling query instead, because there are queries that dont require a database argument (like get_list_series).
For example, I do it here

ok, 1 OT question, is _query dead code from the old version, or is it planned to be implemented or what is it for?

@nemesisdesign
Its dead code. We should remove it. Do you want to open an PR or should I do it?


Add reference to ExpressionToCode

ExpressionToCode generates valid, readable C# from an Expression Tree, which is particularly useful in unit testing assertions.

Thanks.


[1.9.4] rftoolsdimensions dimlet workbench and liquid absorber issue

When I am trying to create the spefic liquid dimlet such as lava. Workbench does not seems combine the basic dimlets to lava liquid dimlet. It issue happens with all the costume liquid dimlets.
Eample: To create a lava dimelet : The following base dimlet required: base dimlet part, circuit rarity 5,advanced energy module, advanced memory unit, liquid controller and liquid absorber with lava. Once we provdided all the basic parts we shall be getting the "lava liquid dimlet". Attaching the screenshot.
2nd issue:Liquid absorber: This is only teseted with Rocket fuel from Ender IO
When we place the rocket fuel beside the liquid absorber, it get absorbe but NBT data infuse stuck at value 0 and absorbering is stuck at value 1. You can place as many bukets of rocket fuel but NBT values does not change. I am not this is caused by Forge code or  RFdimension code.
Adding: NBT value in absorber of infuse liquid is stuck at 0. The value is not chaning.
Forge Version: <IP_ADDRESS>4
Rf tools: 1.9.4-4.50
RF dimesions:1.9.4-4.23beta40

Was the lava liquid absorber filled to 100%? i.e. how much lava did you give it?
Note that the liquid has to go below the absorber

Yes liquid absorber was filled to 100%. As per the config it is 128 buket:
Made a vidoe of absorbing the lava and rocket fuel. Lava get absorbe properly to 100 as per tool tip but after the mining the liquid absorber block, it changes its tool tip.
For rocket fuel, fuel block get absorbe but tool tip is not updating. after mining rocket fuel liquid absorber, it changes it nbt data to air. Then liquid absorber does not absorb any rocket fuel more.
Youtube video link:https://www.youtube.com/watch?v=vi3C6_G16AI

I cannot reproduce this... Weird

I will see if i can create the new world and try to reproduce this bug again. May be this issue occurred because of porting the saved world from 1.8 to 19.4. I will keep you posted. Sorry for late response

Fixed next release


Remember React Table page size

Close #552

@jSylvestre I think this could do with going into a util or service file.  Then you'd just import the tableUtil.ts or whatever and do getPageSize() which would encapsulate all the logic.  I don't like having to put the key value in several different places, the same code is too repeated

@srkirkland Better? Is the proj file change ok?