Huge WARN logs regarding "CheckpointTs is greater than ResolvedTs" seen when resume redo changefeed

What did you do?

Create CDC changefeed with redo log on
Pause changefeed and run workload for 2 hours
Resume changefeed

What did you expect to see?
There should be not too much logs
What did you see instead?
Lots of WARN logs about "schedulerv3: resolved ts should not less than checkpoint ts" and "schedulerv3: CheckpointTs is greater than ResolvedTs"

Versions of the cluster
bash-5.1# /cdc version
Release Version: v6.5.5-20231109-c8eed98
Git Commit Hash: c8eed98f03df1a9fa032018d14acacd697eda0bc
Git Branch: heads/refs/tags/v6.5.5-20231109-c8eed98
UTC Build Time: 2023-11-09 09:24:38
Go Version: go version go1.19.12 linux/amd64
Failpoint Build: false

/severity moderate

/assign @sdojjy

Fixed by https://github.com/pingcap/tiflow/pull/10740


First attempt at cloud-nuking ECS clusters

Goal of the PR and the task:
To update the cloud-nuke to delete ECS clusters with "older-than" filtering.
How this PR will be updated:
This PR is a draft PR at this stage. Please add any comments related to the goal and plans/tasks below as you wish - any feedback is welcome.
First attempt at nuking ecs-clusters:

[x] create empty ecs-cluster with created_at tag
[x] make sure I can tag and retireve tags for ecs cluster
[x] select the ecs cluster and if tag is present ~-> nuke~
[x] get all ECS clusters with tag first_seen, or otherwise set it
[x] nuke all ECS clusters (from input list of ECS cluster ARNs)

2nd stage - if timestamp provided is before tag (as timestamp value) or after:

[x] add timestamp to first_seen tag
[x] update methods to interpret timestamp
[x] update filtering based on tag to be able to extract older than input timestamp ECS clusters

Tasks:

[ ]To re-read & update as makes sense [x] README initial state of change and additional functionality
[x] Add ecs_cluster.go
[x] Write tests for ecs_cluster.go
[x] add a type def for clusters

Hey @ina-stoyanova,
I was playing around with this locally and ran into an error:
INFO[2020-10-07T16:39:30-04:00] The following resource types will be nuked:
INFO[2020-10-07T16:39:30-04:00] - ecscluster
INFO[2020-10-07T16:39:33-04:00] Retrieving active AWS resources in [us-east-1]
INFO[2020-10-07T16:39:33-04:00] Checking region [1/1]: us-east-1
tagKey: cloud-nuke-first-seen
tag.Key: cloud-nuke-first-seen
ERRO[2020-10-07T16:39:33-04:00] Error tagging the ECS cluster with ARN arn:aws:ecs:us-east-1:675304494746:cluster/zack-test-cluster
ERRO[2020-10-07T16:39:33-04:00] Error getting the `first_seen` tag for ECS cluster with ARN arn:aws:ecs:us-east-1:675304494746:cluster/zack-test-cluster
ERRO[2020-10-07T16:39:33-04:00] *time.ParseError parsing time "2020-10-07 20:13:29.422211915 +0000 UTC" as "2006-01-02T15:04:05Z07:00": cannot parse " 20:13:29.422211915 +0000 UTC" as "T"
/home/zachary/Gruntwork/cloud-nuke/aws/ecs_cluster.go:129 (0xd042e0)
	getClusterTag: return firstSeenTime, errors.WithStackTrace(err)
/home/zachary/Gruntwork/cloud-nuke/aws/ecs_cluster.go:51 (0xd03481)
	getAllEcsClustersOlderThan: firstSeenTime, err := getClusterTag(awsSession, clusterArn, firstSeenTagKey)
/home/zachary/Gruntwork/cloud-nuke/aws/aws.go:351 (0xcfb47f)
	GetAllResources: ecsClusterArns, err := getAllEcsClustersOlderThan(session, region, excludeAfter)
/home/zachary/Gruntwork/cloud-nuke/commands/cli.go:221 (0xd164e6)
	awsNuke: account, err := aws.GetAllResources(targetRegions, *excludeAfter, resourceTypes, configObj)
/home/zachary/go/pkg/mod/github.com/gruntwork-io/gruntwork-cli@v0.1.2/errors/errors.go:93 (0xa7a4de)
	WithPanicHandling.func1: return action(context)
/home/zachary/go/pkg/mod/github.com/urfave/cli@v1.20.0/app.go:490 (0xa6aac8)
	HandleAction: return a(context)
/home/zachary/go/pkg/mod/github.com/urfave/cli@v1.20.0/command.go:210 (0xa6bcd8)
	Command.Run: err = HandleAction(c.Action, context)
/home/zachary/go/pkg/mod/github.com/urfave/cli@v1.20.0/app.go:255 (0xa68d51)
	(*App).Run: return c.Run(context)
/home/zachary/go/pkg/mod/github.com/gruntwork-io/gruntwork-cli@v0.1.2/entrypoint/entrypoint.go:21 (0xd18ac8)
	RunApp: err := app.Run(os.Args)
/home/zachary/Gruntwork/cloud-nuke/main.go:13 (0xd18cb7)
	main: entrypoint.RunApp(app)
/usr/local/go/src/runtime/proc.go:203 (0x436aa2)
	main: fn()
/usr/local/go/src/runtime/asm_amd64.s:1373 (0x464141)
	goexit: BYTE	$0x90	// NOP
  error="parsing time \"2020-10-07 20:13:29.422211915 +0000 UTC\" as \"2006-01-02T15:04:05Z07:00\": cannot parse \" 20:13:29.422211915 +0000 UTC\" as \"T\""

Looks like a time parsing / formatting issue.

Ah interesting - I hit that issue too, just under different circumstances (when I was writing the tests).
I’m curious to see if I can replicate your issue.
The problem for me before was that the RFC3339 format did not understand these +0000 UTC at the end.
The solution I found earlier (also got my tests passing for this issue) was to set the tag as “RFC3339” too & then parse it explicitly in that format too:
time.Parse(time.RFC3339, aws.StringValue(tag.Value))  to retrieve the tag value
time...Format(time.RFC3339) to set the tag in the tests


The accuracy of CoEx

Hello,  as for the comparison result of CoEx, its accuracy is 2.02% (kitti15 d1_all) and the running time is 0.027s (2080ti).

The result of CoEx is from the published paper, Correlate-and-Excite: Real-Time Stereo Matching via Guided Cost Volume Excitation. The inference time is tested on our device.


Improved Spanish translation

Changes made to help spanish-speaking users to understand better the instructions.

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] None of my changes are plagiarized from another source without proper attribution.
[x] My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.
Closes #XXXXX

@GabrielCaballero Thank you for  creating this PR.  However, since it was created, the underlying document has changed.  Can you please review and resolve the current merge conflicts?  It could be the changes to the underlying document are so significant that your changes are no longer relevant.  If the latter is the case, it might be easier to just close this PR and create a new PR with any changes you still feel are important to make.
If you need any assistance or have questions about resolving the merge conflicts, please reply back or contact someone in the Contributors Room on Gitter.
Thank you.

We are restructuring a lot of the code and learning resources referenced in your pull request, so for now I am going to go ahead and close this pull request. Thanks again for opening this pull request and for contributing to the community.


remove web extension kind

Hi, this is developer from VS Code. As we are rolling out web extensions we are trying to fine tune and simplify the concepts around web extensions. As a result, we are no longer supporting web as an extension kind to identify as a web extension. Instead we infer it from other properties - See https://github.com/microsoft/vscode-docs/blob/vnext/api/extension-guides/web-extensions.md#web-extension-enablement for more details. With latest vsce, it will validate extension kind for appropriate values which are ui, workspace.
Since this extension has web extension kind, this PR removes it. Please follow https://github.com/microsoft/vscode-docs/blob/vnext/api/extension-guides/web-extensions.md guide to enable your extension as web extension

Hi @sandy081, thanks for the info!  I'll release the updated extension soon!


Fix reloading the environment if there is an error

This adds a new error field to the environment. This is now checked against when attempting to delete the environment as if there is an error the handler is never set to initialized.
Note that the property has only been added to SubprocessHandler as the BlueskyHandler ABC is likely to be removed.
Fixes #512.

I have only added the error property to the subprocess handler (and not the ABC).

Looking at the test failures now it seems the handler implementation is variable, perhaps I should just add to the ABC.


Improve architectures in OS::has_feature and make them work on MSVC

This needs testing! I have not yet tested if this works as expected.
Based on this MSDN article, we need to check for _M_IX86, _M_X64, _M_ARM, and _M_ARM64 to detect x86 and ARM on MSVC. This should make the x86_64, x86, arm64, and arm OS features work on MSVC.
I modified the logic a bit so that x86_32 and arm32 are for the 32-bit versions specifically, and x86 and arm will return true for both the 32-bit and 64-bit versions. I also added WebAssembly (wasm, wasm32, wasm64) to the list of architectures, based on the defines here. For these reasons, this PR is also an enhancement.
We should also backport some of these changes to 3.x (except leave "x86" and "arm" as they are for backwards compatibility for any 3.x projects using those to detect 32-bit versions of the architectures).

The #if conditions seem to work for MSVC (VS2022) x86, both 32 and 64 bit.  ✔
But when I run the example, I get a new error I hadn't noticed before, at object.cpp:1771
ERR_FAIL_COND(_instance_bindings != nullptr);

The instance bindings are first created at object.cpp:1794 while calling Node::get_viewport from Example::return_something_const.  Then shortly after, within Viewport::___binding_create_callback, it hits Wrapped::_postinitialize and tries to set the instance bindings again.
My suspicion is that this is unrelated, but this is far beyond my current understanding, since I just started looking at Godot code yesterday.  I'll see if I can investigate further tomorrow.

Thanks!


Add LSTM-CycleGAN primitive for time series anomaly detection

resolve #200
Add prototype of LSTM-CycleGAN and corresponding error-calculation primitives.
This GAN architecture allows to encode and decode a time-series signal.
For the error calculation a combination of the reconstruction error and the score from the critic network is used.
Since the model is still under development, the primitives are located in the candidates folder.

Hi @AlexanderGeiger Thanks for the contribution!
Before we merge it, would you mind adding an issue to associate this PR to?
Please briefly describe there what this primitive is about and how it is implemented. Nothing fancy, just 2 lines that helps someone that reads the issue know what the primitive would be used for.

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@5308c73). Click here to learn what that means.
The diff coverage is 22.85%.

@@            Coverage Diff            @@
##             master     #199   +/-   ##
=========================================
  Coverage          ?   38.28%
=========================================
  Files             ?       26
  Lines             ?     1520
  Branches          ?        0
=========================================
  Hits              ?      582
  Misses            ?      938
  Partials          ?        0

Impacted Files
Coverage Δ

mlprimitives/adapters/keras.py
44.44% <14.28%> (ø)

mlprimitives/candidates/timeseries/cyclegan.py
23.6% <23.6%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5308c73...fd2fee4. Read the comment docs.

Good job @AlexanderGeiger! This looks much better now!


Rework Ensemble for Indexes

Allows indexes to be in both the input AND output space for a TargetEvaluation for a model within an Ensemble Model configuration.
Previously this would falsely create a Picard iteration trigger, as the index is in both the output and input space.
Now, if an input variable depends on an index, the index is never included as an output variable.

The real change is in Dummy.py at 282, the rest is just increasing readability as I worked towards finding that spot, plus a new regression test.

@AaronEpiney @PaulTalbot-INL

First pass through comments committed.  Some consideration requested.

Once the tests pass, this PR can be accepted

PR can be accepted... Tests pass except the two machines that are currently on holding...


null array indexing in coverage/ctracer/tracer.c

This issue was found by running UndefinedBehaviourSanitizer in our internal builds at Google: coverage/ctracer/tracer.c's CTracer_handle_return() is sometimes called in situations where self->pdata_stack->stack is NULL after the call to CTracer_set_pdata_stack(), but CTracer_handle_return() still tries to index the stack to set self->pcur_entry. As far as I can tell self->pdata_stack->depth is always -1 in that case, meaning the NULL array gets indexed with a non-0 index (that would also be out of bounds). I can't tell if this is intentional or not (i.e. whether the resulting value of self->pcur_entry actually matters.)
Here's a diff to reproduce the error without ubsan:
--- a/coverage/ctracer/tracer.c
+++ b/coverage/ctracer/tracer.c
@@ -722,6 +722,11 @@ CTracer_handle_return(CTracer *self, PyFrameObject *frame)
     if (CTracer_set_pdata_stack(self) < 0) {
         goto error;
     }
+    if (self->pdata_stack->stack == NULL) {
+        fprintf(stderr, "stack = NULL, depth = %d\n",
+                self->pdata_stack->depth);
+        abort();
+    }
     self->pcur_entry = &self->pdata_stack->stack[self->pdata_stack->depth];

     if (self->pdata_stack->depth >= 0) {

I reproduced the issue by applying @Yhg1s' patch top of the current head (28d22a3e9f4bd72c87f18c9a4952e642fef6ce3f), except for the abort() call. Running tests results in:

$ python3 -m tox -e py311
[...]
================================================================== short test summary info ===================================================================
FAILED tests/test_concurrency.py::ConcurrencyTest::test_greenlet_simple_code - AssertionError: assert 'stack = NULL, depth = -1\nstack = NULL, depth = -1\nstack = NULL, depth = -1\n499500\n' == '499500\n'
FAILED tests/test_concurrency.py::ConcurrencyTest::test_threads_simple_code - AssertionError: assert 'stack = NULL, depth = -1\n499500\n' == '499500\n'
FAILED tests/test_concurrency.py::ConcurrencyTest::test_threads - AssertionError: assert 'stack = NULL, depth = -1\n499500\n' == '499500\n'
FAILED tests/test_concurrency.py::ConcurrencyTest::test_gevent_simple_code - AssertionError: assert 'stack = NULL, depth = -1\nstack = NULL, depth = -1\nstack = NULL, depth = -1\n499500\n' == '499500\n'
FAILED tests/test_concurrency.py::ConcurrencyTest::test_greenlet - AssertionError: assert 'stack = NULL, depth = -1\nstack = NULL, depth = -1\nstack = NULL, depth = -1\nhello world\n42\n' == 'hello world\n42\n'
FAILED tests/test_concurrency.py::ConcurrencyTest::test_gevent - AssertionError: assert 'stack = NULL, depth = -1\nstack = NULL, depth = -1\nstack = NULL, depth = -1\n499500\n' == '499500\n'
FAILED tests/test_concurrency.py::ConcurrencyTest::test_eventlet_simple_code - AssertionError: assert 'stack = NULL, depth = -1\nstack = NULL, depth = -1\nstack = NULL, depth = -1\n499500\n' == '499500\n'
FAILED tests/test_concurrency.py::ConcurrencyTest::test_eventlet - AssertionError: assert 'stack = NULL, depth = -1\nstack = NULL, depth = -1\nstack = NULL, depth = -1\n499500\n' == '499500\n'
[...]
72 failed, 1326 passed, 13 skipped in 45.86s

This is now released as part of coverage 7.6.2.


FR: Join Lines removing bullets points

say I want to merge two lines:
- one point
- second point

here, the result would be:
- one point- second point

A much more elegant result, however, would be to remove the preceding -:
- one point second point

I'm a bit hesitant about this one as it starts to diverge from the code editor behaviour I'm trying to emulate. If it becomes a feature, might be better to have it as a configurable option so users aren't surprised with a missing dash.

Tracked here: https://github.com/timhor/obsidian-editor-shortcuts/projects/1#card-75480854


Fix always scroll to top issue on IE 7

When the container is "window" and event is "scroll", will cause window to scroll back to top on IE 7.
The reason is
// settings.container = window
// settings.event = "scroll"
$(settings.container).trigger(settings.event);

works as the below code on IE 7:
``window.scrollTo(0, 0);```
Also, I cached window object to improve performance.

Note to self, short scoping the window variable: http://jsperf.com/short-scope

Do you still experience the IE7 bug also with latest jQuery? To me it looks like it was fixed in 1.7.
http://bugs.jquery.com/ticket/6170

Maybe latest jQuery fixed this issue, but for some frameworks, e.g. Drupal 6, you can't simply update jQuery to latest one, that's why I fix this issue, and this issue is easy to fix :-)
About the performance of copying window, on my Chrome 16.0.912.75 on Mac OS X 10.7.2, it's faster than don't copy.
In fact, I was just wanna pull request for the IE 7 issue, not the performance or something else :/
Coz I'm customizing it to fit our Drupal project.
Just Forget about it.

That is interesting. I just tested Chrome 16.0.912.75 on Mac OS X 10.7.2 and I get around 4600 ops / second when copying and 7200 ops / second when caching.
Anyway, what version of jQuery Drupal 6 is using?

Drupal 6 is using 1.2.6 for core library (WTF?!), with a third-part module, can be upgraded to 1.3.2.
In the past, I tried to upgrade to 1.5.2 (or lower), and lots of core features were broken.
Although I can load latest jQuery with $.noConflict() and initialize lazyload with it.

The issue affects even jQuery 1.7 as far as I can tell. Try scrolling to the bottom of http://www.ea.com/ and executing jQuery(window).trigger('scroll'), which is what happens in this plugin's resize listener by default. That call scrolls the page to the top.

Example: scroll to the bottom of your project page, http://www.appelsiini.net/projects/lazyload, and then resize the window. It scrolls to the top.

Actually project page has 1.6. Demo pages have 1.7.
http://www.appelsiini.net/projects/lazyload/enabled_fadein.html
But since many people are still using 1.6 and older I might consider including Chris' workaround for Chrome.

I noticed the 1.6/1.7 difference right after I wrote my comments. The workaround doesn't seem ideal, calling $window.scrollTo with the current coordinates.


Pin flask-babel to 0.9

As sage notebook is incompatible with 0.11

Fixed in https://github.com/conda-forge/sagenb-feedstock/pull/2


TE-4.1 base_leader_election_test.go  persistence_type=PRESERVE

Hi,
With recent change in TE-4.1 base_leader_election_test.go , persistence_type is set to PRESERVE while establishing gRIBI client connection.  Any successive test case run fails as RIB-programmed already.
First time Test case returned PASS and second time same TC failed. Please refer the snippet below.
Is it possible to change persistence_type to DELETE for this Test case,  the earlier Test case indeed had  persistence_type=DELETE

base_leader_election_test.go:278: Starting   GRIBI connection for dut: <IP_ADDRESS>
base_leader_election_test.go:278:
*** Fetching gRIBI client for <IP_ADDRESS>...

base_leader_election_test.go:202: an IPv4Entry for <IP_ADDRESS>/24   pointing to ATE port-3 via gRIBI-B
gribi.go:180: results did not contain a result of value <0 (0   nsec): AFTOperation { ID: 0, Details: <Type: Add NH Index: 1>, Status:   RIB_PROGRAMMED }>
got:
<1650897162269570518 (0 nsec):   SessionParameterResult: OK ()>
<1650897162269570518 (0 nsec): ElectionID: 12>
<1650897162269570518 (0 nsec): AFTOperation { ID: 1,   Details: <Type: Add NH Index: 1>, Status: FAILED }>
panic.go:642: Closing GRIBI connection for dut: <IP_ADDRESS>
panic.go:642: Closing GRIBI connection for dut: <IP_ADDRESS>
---   FAIL: TestElectionIDChange (114.65s)
FAIL |
  |
Thanks,
Abdul Zubaidhar .A

@xw-g can you respond for us?

Thanks @azubaidhar for reporting the issue.  I feel like PRESERVE actually exposed the device gRIBI server issue here. The device should report back RIB_PROGRAMMED if the NH is already there, right?

@mojiiba can we change your gribi helper to not use PRESERVE by default? Tests should generally work without persisting their entries.

I just remembered that election ID is not going to be reset between tests (we have a way to do that internally between test run, but not in the open source). #147

Thanks @liulk. Not using PRESERVE by default sounds good to me.
@azubaidhar I think this test case should pass even with PRESERVE, so probably you still want to debug why your DUT failed.

Thanks Xiao.
Test case passes in first run and we see problem in successive run of same TC.
The script does the below in sequence.

Client-A connects with Election Id 10
Client-B connects with Election Id 11 and does program a prefix P , this is checked with OCST and traffic is sent out.
Client-A (still with election ID 10), tries to program same prefix P  and entry to be ignored (due to lower election ID).
Client-A session modified with Election ID 12 and tries to program prefix P, this time it succeeds due to higher election ID, this is checked with OCST and traffic.

When script runs for the first time, it returns PASS ;  only subsequent runs return FAIL as DUT already has a gRIBI session with higher election-ID from Client-A.
When same test case rerun for the second time , the script fails at step 2 as gRIBI from client-B which has Election ID 11 fails as DUT already has PRESERVE session with client-A from previous run (step 4).
If DELETE is used, session goes away once test case gets executed and will not impact any successive test case runs.
Thanks,
Abdul Zubaidhar .A
From: Xiao Wang @.>
Date: Friday, 29 April 2022 at 10:11 PM
To: openconfig/featureprofiles @.>
Cc: Abdul Zubaidhar Abdulla @.>, Mention @.>
Subject: Re: [openconfig/featureprofiles] TE-4.1 base_leader_election_test.go persistence_type=PRESERVE (Issue #152)
[External Email. Be cautious of content]
Thanks @liulkhttps://urldefense.com/v3/__https:/github.com/liulk__;!!NEt6yMaO-gk!TLBLf8cj1Kqos2vj1IuVEqNBBuor65vpAPDxjKDY9wxE6cWC3ChpZZvg-26gKupJ11s$. Not using PRESERVE by default sounds good to me.
@azubaidharhttps://urldefense.com/v3/__https:/github.com/azubaidhar__;!!NEt6yMaO-gk!TLBLf8cj1Kqos2vj1IuVEqNBBuor65vpAPDxjKDY9wxE6cWC3ChpZZvg-26gvFNOjGM$ I think this test case should pass even with PRESERVE, so probably you still want to debug why your DUT failed.
—
Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https:/github.com/openconfig/featureprofiles/issues/152*issuecomment-1113514534__;Iw!!NEt6yMaO-gk!TLBLf8cj1Kqos2vj1IuVEqNBBuor65vpAPDxjKDY9wxE6cWC3ChpZZvg-26gvSDLz70$, or unsubscribehttps://urldefense.com/v3/__https:/github.com/notifications/unsubscribe-auth/AYQGC7Z7Q5DNGWHNG3RMHRDVHQGMTANCNFSM5UMRHROQ__;!!NEt6yMaO-gk!TLBLf8cj1Kqos2vj1IuVEqNBBuor65vpAPDxjKDY9wxE6cWC3ChpZZvg-26gjOHxhYE$.
You are receiving this because you were mentioned.Message ID: @.***>
Juniper Business Use Only

@azubaidhar  test case assumes that the last known election id on the gribi server  is less than 10. When you run the first time, the last know election  id is less than 10, so the clientB can take a master role and successfully adds entries. In the second run, the last known election id is 12, so there is no way (according to gribi protocol) the client-B to be master with sending election id 11 that  cause the test case to fail which is expected unless you reset the election id on the gribi server side before running tests.
We are discussing  this issue here: https://github.com/openconfig/featureprofiles/issues/147

@azubaidhar do you want to try @mojiiba 's BecomeLeader and then maybe improve the test case by filing a PR? Thanks.


Add TNB Blog

This one is already being worked on by Ivan Danilov

closing as blog no longer needed


example with capture: SSL, 3D #42

Coverage remained the same at 94.066% when pulling 90e4be3ca5422c68686c707bcb3e1bc1f56bdbd2 on reka:capture-example into 25fe12bf50ed65cff93c2072deca57ac4187d025 on wirecard:42-redesign.

Coverage remained the same at 94.066% when pulling 90e4be3ca5422c68686c707bcb3e1bc1f56bdbd2 on reka:capture-example into 25fe12bf50ed65cff93c2072deca57ac4187d025 on wirecard:42-redesign.


Add a list of coding challenge websites

Practice makes perfect.
These are coding challenge websites for practice, particularly included: TopCoder, Coderbyte, Project Euler, HackerRank and LeetCode.

Hi @Jenn-y
Thanks for being here. You did a great job but please close  tag like that  at the end of every description of a resources you provided and also add corresponding emoji(tag).
I hope it helps.
Have a great day!


Fix __defmt_default_panic being garbage collected by linker

This PR modifies the defmt linker script to stop LLD of garbage collecting the panic default implementation. This PR targets main, after it gets merged the PR will be backported to a defmt-0.3.8 release branch and a release with just this change will be published.
Fixes #862.

Blocked on #871 because that one fixes the snapshot tests


'src/routes/student/(authed_user)/+layout.svelte' is way to complicated

This should be simplified. It is just a top bar.
Right now it is difficult to make any changes to the file/bar because it of this complexity. This is not how it should be.
The changing contetn should be defined where it is relevant. Not in this overall file through looking at url parameters. This is hacking the Svelte framework. We must work with the framework, not against it.

We should avoid hacky solutions like this.

href={(path.slice(-1) !== '/') ? path + '_overview' : path.slice(0, -1) + '_overview'}


[SEDONA-269] Add data source for writing raster files

Did you read the Contributor Guide?

Yes, I have read Contributor Rules and Contributor Development Guide

Is this PR related to a JIRA ticket?

Yes, the URL of the associated JIRA ticket is https://issues.apache.org/jira/browse/SEDONA-269. The PR name follows the format [SEDONA-269] my subject.

What changes were proposed in this PR?

Add a new built-in data source called raster designed for writing rasters
This raster data source takes 2 options

rasterType: this can be any supported raster types. Currently, we support geotiff and arcgrid
optional pathField which indicates each raster file name. If not given, it will use UUID as the name of each raster
Raster name is an quite important field as many libraries need raster file names for additional information.

Move raster logics from io to io.raster.

The future plan of Sedona raster data sources:

We will deprecate the current Sedona built-in geotiff data source in 1.4.1 (around 1 month from now) as it is not convenient for our upcoming raster operations and completely remove it in 1.5.0 (I guess around 4 months from now). To make this happen, a few other PRs that bridge Array[Double] and RasterUDT must be made. My idea is to completely get rid of Array[Double] and migrate Array[Double] based RS functions to RasterUDT environment. But let's see.
With this PR in place,  we will start to use binaryFile data source and RS_FromXXX for reading rasters and raster data source for writing rasters. This gives us much more flexibility and introduces opportunities for brining a flurry of new raster functions.

How was this patch tested?
Added new unit tests.
Did this PR include necessary documentation updates?

Yes, I am adding a new API. I am using the current SNAPSHOT version number in since vX.Y.Z format.

@umartin Hi Martin, the design of this PR is slightly different from your initial proposal in https://issues.apache.org/jira/browse/SEDONA-269 . This design does not need RS_AsXXX functions. It directly takes RasterUDT and generates raster images. Do you see any potential risk here?

Hi, I would prefer a plain binary data source and separate RS_AsXXX functions.
There are several benefits to separating the raster formats and the data source

The raster formats are useful for transferring rasters between different systems. For example I could use RS_AsXXX and write the raster to PostGIS, parquet or kafka for further processing outside Sedona and Spark. That means we would need the RS_AsXXX functions anyway.
Different formats requires different parameters. Since ArcGrid is single layered we might want a parameter to select which layer to convert in a multi layer raster. With GeoTIFF we might have parameters for compression level and compression codec. Doing conversion and binary file writing in the data source will lead to a messy API when there are many formats with wildly different parameters.
The data source API in Spark is constantly evolving. We might want to minimize the exposure to the API by keeping the data source simple.
We can create Flink bindings for the RS_AsXXX functions as well.

@umartin Thank you for the great suggestion. I will make changes accordingly and add RS_AsXXX as well.
@gregleleu Thank you for your help! Please wait for now. I will make some changes based on Martin's comment, then you can add new functions to Sedona R :-)


[xen on cubietruck @talex5] VGA/HDMI crashes on booting

The VGA/HDMI display working normally on booting U-boot and after "Starting kernel" it crashes and only I can see the output through uhart connection with cubietruck and I need to see the output on VGA/HDMI.
anyone can help please ?

That's a new one on me!
Can you provide any more info on what you mean by "it crashes"?
I would guess it's a kernel config build option-- did you change any from those in the repo?

I think I made something wrong with steps 2 and 4 here https://github.com/talex5/xen-arm-builder
can you please tell me the steps to do it ?

anyone can help me building the linux kernel right to avoid that crashing output ?
@mor1 @talex5

Sorry for taking so long - missed this! If you cloned from talex5 repo, then it seems that's a considerable way (77 commits?) behind this one. I reworked the process in this repo to use Docker so as to encapsulate the external deps, which hopefully simplifies the process a bit.
I'll close this issue as it's not actually relevant to the current state of the repo, but do reopen it if you try with the current HEAD of this repo and still experience the same problems.


Add jsDelivr hits badge

Hey, I noticed that clipboard.js is the 34th most popular project on jsDelivr (congrats! :tada:), so I thought you might like this badge.

Hey @LukasDrgon,
Wow, I didn't know that we had so much downloads coming from JSDelivr, that's awesome!
I like the badge very much, but I'm trying to keep the readme as clean as possible.
Thanks for taking the time to open this pull request!


Secondary repos are missing licenses

Need to add license headers and a top-level license files to all the secondary repositories that aren't forks from somewhere else:
net-tools
ci-*
Also, why does meta-zephyr-sdk have an MIT license?

Also, why does meta-zephyr-sdk have an MIT license?

this is the yocto/openembedded license AFAIK.

added licenses where applicable.


Engine: get rid of warning, and make most of them fatal

This PR fixes all OCaml warnings across the engine/lib dune "package" (don't know whether that's the proper wording in the dune ecosystem).
This PR also makes warning fatal, so that I don't do this kind of PR in the future

Yes, sorry, I actually pushed an extra unrelated commit on that branch.
Will make another PR for that one.

I'm still getting the same error

I think that's due to the base library being updated by your Opam.
Now the other PR is merged in that one, things should compile fine. Can you try again? @franziskuskiefer


Adding information about resolving a merge conflict

Adding information about resolving a merge conflict
🐞 Problem
I was trying to add myself in the contributor list by following the steps, however, when I tried to make a pull request, it said I have a merge conflict, which I was not expecting. So I think it would be a good idea to include this in the exercise so that future contributors don't get confused by it and know how to resolve it, I suppose.
🎯 Goal
It is a very simple change, but it would make a difference to a beginner contributor like myself to be aware of a merge conflict taking place and have information in order to resolve it.
💡 Possible solutions
After a simple google search, I was able to resolve the merge conflict by following these steps , so possibly adding this link or rewriting the steps in the documentation might be useful.
📋  Steps to solve the problem
I am not sure what to write under this section, sorry. However, I would like to point out that I really enjoyed adding myself to the contributor list and it was a very thorough and well thought off activity, so thank you! 😄

Hey @Roshanjossey
Your reasons do make a lot of sense, thanks a lot for explaining it 😄
I guess I'll close this issue now.


Controller godocs

Issue: https://github.com/rancher/rancher/issues/41703

Problem

Add and update Rancher controllers to have detailed godoc descriptions. Huge undertaking and will be chunked out into separate PRs; I'd like review on this first one.
Team 2 controllers

agentupgrade
aks
statscontroller

Team 1 / Neo controllers (we need review on from Team 1)

auth v1 management, prtb, crtb, user and token

Note: In future PRs, I'll only be adding godocs for Rancher controllers that fall under the responsibility of team 2. This includes the CAPR, management node driver, management agent, management user, and v2 prov controllers. @pgonin I believe the Highlander team should create a separate GH issue for adding godocs to the Hosted provider (AKS, EKS, and GKE) controllers. Reach out to me with any questions.
Solution

Testing

Engineering Testing
Manual Testing

Automated Testing

Test types added/modified:

Unit
Integration (Go Framework)
Integration (v2prov Framework)
Validation (Go Framework)
Other - Explain: EXPLAIN
None
REMOVE NOT APPLICABLE BULLET POINTS ABOVE

If "None" - Reason: EXPLAIN THE REASON

If "None" - GH Issue/PR: LINK TO GH ISSUE/PR TO ADD TESTS

Summary: TODO
QA Testing Considerations

Regressions Considerations

TODO
Existing / newly added automated tests that provide evidence there are no regressions:

TODO

Waiting on @JonCrowther re-review and approval to merge!

Out of curiosity, is there going to be any kind of linter added to CI going forward? Specifically for things like line length which I noticed you've updated. Ideally no one should have to make this huge effort again in the future.

Out of curiosity, is there going to be any kind of linter added to CI going forward? Specifically for things like line length which I noticed you've updated. Ideally no one should have to make this huge effort again in the future.

Just wanted to call out that it is specifically possible within golangci-lint to configure it such that specific set of rules are only run on net new code changes. We would still have to run the original as well, but we could become much more aggressive with linting moving forward.


wiki: CodeReviewComments change: defer placement

I was looking for a code review comment about defer about how it's clearer when the defer is closer to the impacted resources/actions than when put at the end of the function. The relevant part of Effective Go is here:

Second, it means that the close sits near the open, which is much clearer than placing it at the end of the function.

This is of course, in Effective Go, but is less link-able than the CodeReviewComments.

Hi @pselle - The wiki page clearly says

You can view this as a supplement to Effective Go.

I don't think it is good to duplicate information in two places.

However, it is referenceable:

This page collects common comments made during reviews of Go code, so that a single detailed explanation can be referred to by shorthands.

Unlike Effective Go, and that's why I said "less link-able than the CodeReviewComments." It can be useful to have information in two place in different forms.

@andybons @dmitshur

How is https://golang.org/doc/effective_go.html#defer less “linkable” than CodeReviewComments?

@andybons That's a link to "defer and what it does" versus "where is the best place to put defer when writing Go code". If you all disagree, it's fine to close, but I leaned towards saying something versus saying nothing.

@pselle is the proposal to add a "Defer" section that has this information?

@andybons It could be that ... reading the style of the page, it seems like there are some general links like that, like this one for comments: https://github.com/golang/go/wiki/CodeReviewComments#doc-comments
I was thinking something more like a maxim, like:
Defer near the open
When using defer, such as closing a file you've opened, locate the defer call close to the open, because it makes it less likely you'll leave something un-tidied-up. See https://golang.org/doc/effective_go.html#defer for more information on defer.
But that heading could say "Defer" as well, sure.
I didn't lead with wording because I feel like the "open" part doesn't encompass the generalized use cases for defer, although thinking of close/open is helpful for memory in my opinion.

It's not clear to me that this is a "common" code review comment. Does this happen often in reviews?

What qualifies something as common? I'm not sure how to answer the question. I ran into a scenario where it would have been useful, and so I proposed.

What Andy is trying to get at is, how often have you seen this happen in reviews. If it is once or twice, it is probably a one-off case. If you have seen it more than three times, then probably it happens more often. This is a common practice where we try to get additional data points from real world usage and base our decisions on it.

At the top of the wiki page it says “This page collects common comments made during reviews of Go code”
So I’m trying to ascertain whether this is a common comment. Do people have issues with this often?
@bcmills as one data point, is this a common mistake you see when doing reviews at Google?

as one data point, is this a common mistake you see when doing reviews at Google?

In reviews I've done, defer placement of this sort has come up only very rarely — only in the context of panic-safe code, but most code isn't (and doesn't need to be) panic-safe to begin with.
Most of the issues I've seen with 'defer' are due to incorrect sequencing of operations rather than placement style: for example, writing a defer statement in a for loop body that should only be scoped to the body (rather than the containing function, as it is actually scoped), or eagerly evaluating arguments that ought to be evaluated lazily (by wrapping the call in a func() { […] }()).

@pselle we appreciate the suggestion but it’s likely that we won’t add this as there doesn’t seem to be compelling evidence that this is common enough to live in CodeReviewComments. I’ll leave open for another week as a last call for objections/new data.
Thanks

Thanks for considering! I understand the decision.


Update badges in README.md

Add NPM and Discord logos. Label Discord badge as "Discord". Set Discord badge Color to 5865F2, Discord's official "Blurple" color.

Who maintains brew svgo package and how it works? Does it need node.js?

Here.
https://formulae.brew.sh/formula/svgo#default
This says it needs node 22.3.0.

Hmm, seems like the bottle is there for 7 years. Seems like updated automatically, probably from the github release.

I'm not seeing the benefit to this. It just adds bloat to the README with information no one is asking for, and most of it is readily available at the links we do have.
UX extends to project documentation and the README too, and imo this offers a worse experience for people learning about the project. For example, scattering around icons and colors everywhere with meaningless stats doesn't help anyone. It's just distracting from more important information we actually do want to convey to the user.


atlauncher: <IP_ADDRESS> -> <IP_ADDRESS>, refactor

Description of changes
Changelog:
### Fixes
- Creating pack not resetting modloader when switched back to none
- Issue with file downloads for non third party enabled files on CurseForge not working
- Issue adding a second account [#865]

### Misc
- Remove old FTB pack installing code

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

On Mon Feb 5, 2024 at 9:06 PM NZDT, Priyanshu Tripathi wrote:

@GetPsyched commented on this pull request.

@@ -56,4 +69,4 @@ stdenv.mkDerivation (finalAttrs: {
platforms = platforms.all;
sourceProvenance = [ sourceTypes.binaryBytecode ];
};
-})
+}

There's no need of finalAttrs anymore/yet, so this won't be required.

Using finalAttrs makes overriding more effective in many cases, it's
good practice to use it whenever possible in place of rec.

Fair enough. In that case I think you should keep the icon and .desktop
file set up as they were previously, for simplicity's sake. No need to
add extra sources if you don't have to.

Result of nixpkgs-review pr 286380 run on x86_64-linux 1

1 package built:

atlauncher

I've marked this PR as a draft since the issue of srcs being hard to be overridden as mentioned by @Scrumplex. However, after spending a significant amount of time with the normal syntax for srcs, I haven't been able to figure out how to access a specific source within the package itself. The docs for lists doesn't have anything about accessing a specific index in a list either.

The docs for lists doesn't have anything about accessing a specific index in a list either.

Try builtins.elemAt

Thanks, that works. But is there an alternative for src = builtins.elemAt srcs 1;? This just feels weird.
I'm guessing sourceRoot but not sure how to use it here.

Closing this since it's not as necessary + I've gotten this package to work with gradle2nix here, once I figure out how to port that to nixpkgs, I'll raise a PR for it.


Invalidation of graph value via jsonGraphEnvelope isn't returned to client

see this stack overflow question
Returning pathSets with invalidation metadata from a route successfully adds invalidation paths to response:
{
  path: ['folderList', 'length'],
  invalidated: true
}

However, returning a jsonGraphEnvelope from the route drops the invalidation paths from the response:
{
  jsonGraph: {...}
  paths: [...],
  invalidated: [['folderList', 'length']]
};

Yep, looks like a bug.

We will look into this. In the meantime please use path value pairs to unblock.


how to deploy in docker ?

I deploy in docker on base JDK8 docker images, but APP start fail with error:
/lib64/libstdc++.so.6: version `GLIBCXX_3.4.21' not found (required by /root/.djl.ai/pytorch/1.9.1-cpu-linux-x86_64/libc10.so)

Looks like your container's GLIBC version is too low. This is due to the docker base system version is too low. If you are planning to use an older system like CentOS7, you should use https://docs.djl.ai/engines/pytorch/pytorch-engine/index.html#for-pre-cxx11-build this instead

That's great !
I update sys to ubuntu 18, it works well .
thank you !


Fix mypy typing errors in pytorch_lightning/trainer/trainer.py

What does this PR do?
Part of https://github.com/Lightning-AI/lightning/issues/13445.
Fix typing errors in pytorch_lightning/trainer/trainer.py
Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

[x] Was this discussed/approved via a GitHub issue? (not for typos and docs)
[x] Did you read the contributor guideline, Pull Request section?
[x] Did you make sure your PR does only one thing, instead of bundling different changes together?
[x] Did you make sure to update the documentation with your changes? (if necessary)
[x] Did you write any new necessary tests? (not for typos and docs)
[x] Did you verify new and existing tests pass locally with your changes?
[x] Did you list all the breaking changes introduced by this pull request?
[x] Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

[x] Is this pull request ready for review? (if not, please submit in draft mode)
[x] Check that all items from Before submitting are resolved
[x] Make sure the title is self-explanatory and the description concisely explains the PR
[ ] Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?
Make sure you had fun coding 🙃

@BongYang, great work; mind checking the collisions? :rabbit:

@BongYang, great work; mind checking the collisions? 🐰

@Borda Done
but there is import error for get_len
how can I solve this?

Hi @BongYang, the issue was with circular imports. I took the liberty to resolve the import errors for you :zap:


Web Component: Feature card - image appears to be shrunk on mobile view

Detailed description
On iPhone & Android phones
Issue: Feature card - image appears to be shrunk on mobile view
Additional information

@RobertaJHahn this has already been fixed, closing.


Switch is missing focus frame

When using keyboard-navigation, the Switch is missing its focus frame when in focus.

Withdrawn as focus frame needs to be changed due to mismatch with Figma #1433


Input names aren't surfaced as env variables in batch files

As we saw, this no longer seems to work. e.g. with
{
  "bindings": [
    {
      "type": "blobTrigger",
      "name": "original",
      "direction": "in",
      "path": "images-original/{name}"
    },
    {
      "type": "blob",
      "name": "resized",
      "direction": "out",
      "path": "images-resized/{name}"
    }
  ]
}

and
echo %original%

original is empty.

Yeah, I looked into this and know what is going on. Currently trigger input is accessed via stdin, not env. That doesn't work for scenarios like this. I think what I'm going to do is remove the stdin pattern and make all inputs/outputs file based, which is more consistent anyways.

I see. That's why %original% is not set, but %resized% is.
Moving away from stdin/stdout pattern might make sense.
For http, is the stdin pattern already gone? I see current template (which works) just has:
echo Please pass a name on the query string > %res%

Is 'res' a file in that case?

I guess then the pattern for http is to use >> for append, e.g.
echo First line >> %res%
echo Second line >> %res%

This already seems to work well, and I like it.

This has been fixed.


Add new model annotation schema and pages, remove legacy (redo complex annotations)

This meant to encompass the removal of the legacy complex annotation pages and the addition of the new model annotation pages. A lot of work has been done since that first attempt and not much can be saved.
@cmungall has already added a new model_annotation.config.yaml file, @hdietze will take care of the loading bits (and mercifully take ComplexAnnotationDocumentLoader out of its misery).

We left a few, for possible future extensions
These should all have a standard closure quad

affects
affected_by
during
subfunction
substrate

The initial Makefile and schema changes, along with necessary changes in the OWLTools loader (work and feedback to @hdietze) have been completed. We now need to:

Finish the redo of complex_annotations as model_annotations
Coordinate the update of tomodachi in a non-disruptive way.

Number two is now completed, number one is done for all but the visualizations.
Also, we'll have to come back and change some of the URLs once the meeting is over--there is a little bit there to point at noctua-dev temporarily.

Link on landing page is not correct, still points to old. I can fix.

@cmungall , I manually linked it with a commit comment, but be careful with the links: you got the wrong repo and I don't think there really a way to undo it without messing with a whole chain of trees; this will show up again as tagged when the noctua repo reaches 226.

Rolled out.

oops sorry


Move content out of _include/*.html

Ideally content should be in markdown files and layout and templating in html.
Right now too much content is held in _include/*.html files.

#368 is part of this.

I think this is mainly about index.html, but any other html files needs changes?

It affects a couple of pages but we go step by step.

In my opinion the issue is solved. There is some content left in *.html pages but IMO this does not justify to worry about this and keep the issue open.


BUG: I can not use Model Check functions

Description of the bug :
I can not use Model Check functions like GetNotConnectedMembers or GetIdenticalNodes. Maybe I use them badly because I have an issue on Python when I use it (see the atteched screenshots).
Please free to contact me if you have any solution or a beggining of a solution or to know more about the problem.
Have a nice day,

Hi @IcareIbnFirnas,
sadly functions from ModelCheck.py are not released in RFEM, yet.

Hello thansk for the answer,
When do you think it will be available in RFEM6 ?
Kind regards,


Fix CBS Vpack to handle WebView2

MUX.winmd now references CoreWebView2 types. For the nuget package, this is handled by having the MUX nuget package having a dependency on the WebView2 nuget package.
However, this broke the CBS Vpack which needs to remerge the winmd against OS publics so that it can be consumed by razzle components. To fix this, we need to include the WebView2 winmd as part of the reference winmds when we do the remerge.

/azp run

/azp run


Kinetic devel

Please create new kinetic-devel branch for this PR.
Changes proposed in this pull request:

Changes for ubuntu 16.04 build/ ros kinetic
Adds librealsense wrapper to simplify build procedure.
Tested. Depth/ ir and rgb working without any kernel modification or patching.

Thanks for submitting. We're discussing internally how to proceed and will get back to you.

@mkhansen-intel Great, let me know if you need anything from me.  I left a lot of boiler plate in there assuming you guys would replace the maintainer etc. with your own info. I think having the librealsense wrapper makes it easier to get people up an running quickly and really becomes more reasonable in kinetic where you don't have to go through all of the kernel patching and custom config to get it running on your system.

Hey guys,
having librealsense released with the ROS ecosystem probably makes sense until it is stable enough to be included with distributions like debian directly.
However, this should follow the ROS REP for that: http://wiki.ros.org/bloom/Tutorials/ReleaseThirdParty
So :-1: on this request.
Given that both intel-ros/realsense and IntelRealSense/librealsense are official Intel projects it might be possible to take the very easy road to add a package.xml file to the librealsense project. (see REP)

@v4hn, agree

@v4hn Maybe I'm missing something, but I don't see how to test the package.xml file I created for the librealsense in a prerelease environment.
http://wiki.ros.org/bloom/Tutorials/PrereleaseTest
Or in general, how to test in prelease if the package has never been release before.

See http://answers.ros.org/question/201954/prerelease-tests-with-bloom-on-first-release/ .
Pre-release tests are not that helpful for new packages because there are no dependent packages to test.
I would simply build it locally as part of an install workspace and see if everything installed correctly.

In progress...

Currently working to release librealsense as a ROS package.
Once it is available, we will enable the package dependency and release realsense_camera as a ROS package.
Closing this PR as it will not be merged.


post new entry when the pushed entry has no EditURL

resolve #47

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 53 (0.0%)  changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-1.5%) to 26.725%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

broker.go
0
1
0.0%

config.go
0
15
0.0%

main.go
0
37
0.0%

Totals

Change from base Build<PHONE_NUMBER>:
-1.5%

Covered Lines:
182

Relevant Lines:
681

💛  - Coveralls


Update Review Offer Slack message format

From Chris and Chad (PREreview):

Can we amend “A new request has come in for a PREreview of 10.1101/2<IP_ADDRESS>2762 by Josiah Carberry on bioRxiv” to something like, “A new request from [requester’s name] has come in for a PREreview of [doi] on [server[.?”

Changes included in release https://github.com/seanwiseman/coar-notify-micro-inbox-slack-relay/releases/tag/v0.0.2 .


solves the Android pixel bug

@emilsjolander hi,
this PR solves the following common and probable layout pixel scenario:
the older code is presented for reference:
view.measure(
    View.MeasureSpec.makeMeasureSpec(
        Math.round(node.getLayoutWidth()),
        View.MeasureSpec.EXACTLY),
    View.MeasureSpec.makeMeasureSpec(
        Math.round(node.getLayoutHeight()),
        View.MeasureSpec.EXACTLY));
view.layout(
    Math.round(xOffset + node.getLayoutX()),
    Math.round(yOffset + node.getLayoutY()),
    Math.round(xOffset + node.getLayoutX() + node.getLayoutWidth()),
    Math.round(yOffset + node.getLayoutY() + node.getLayoutHeight()));

suppose now the following:

xOffset + node.getLayoutX() = 2.2
node.getLayoutWidth() = 0.4 ==> Math.round(node.getLayoutWidth()) = 0
Math.round(xOffset + node.getLayoutX() + node.getLayoutWidth()) = Math.round(2.2 + 0.4) = 3

this induces, the following measurements:
view.measure(
    View.MeasureSpec.makeMeasureSpec(
        0,
        View.MeasureSpec.EXACTLY),
    View.MeasureSpec.makeMeasureSpec(
        Math.round(node.getLayoutHeight()),
        View.MeasureSpec.EXACTLY));
view.layout(
    2,
    Math.round(yOffset + node.getLayoutY()),
    3,
    Math.round(yOffset + node.getLayoutY() + node.getLayoutHeight()));

the width measurement of the view is 0, while the layout is (3 - 2 = 1).
my proposed solution is to measure the view the way it is now, but when layouting
I use the #getMeasuredWidth/Height() methods, this will stop this problem
from happening.
I also want to note that this bug happens with high probability.

@HendrixString Can you add a test case for this change ? So that its easier to catch the regression.

hi @priteshrnandgaonkar
I did some research about unit testing this.
Testing it will require adding more dependencies and
tasks to invoke them. If we choose native tests, then we
can only use connected devices tests which will force testing
it on a connected device. I have no idea if the architects of Yoga
would like that.
not using native test frameworks, will introduce a test framework
like http://robolectric.org/, which can mock
the entire android.jar but I don't
believe that the architects will want to depend on that solution.
all and all, I came to a conclusion, that laying out a testing strategy,
that is beyond the regular/standard JUnit stack testing is probably
not my decision to make as I have no clear vision of how you want Yoga
to look like.
any thoughts ?

Thanks for the PR. I am importing this PR for internal review.


fix(material-experimental/mdc-progress-bar): account for breaking changes in latest canary

Updates the repo to the latest MDC canary version and accounts for the breaking changes introduced in https://github.com/material-components/material-components-web/commit/98b843417ef6c0a10460532a37df389b0c7e936f.

@crisbeto Looks like there is a pixel deviation in a BrowserStack test.

Fixed.

This appears to have broken tests internally - be aware that many of our MDC components are no longer merge safe since we are beginning to use them in other apps


Code Sign error when using tns run ios --emulator

Hello,
I recently been unable to run my app using ios emulator
$ tns run ios --emulator

=== BUILD TARGET Pods OF PROJECT Pods WITH CONFIGURATION Debug ===

Check dependencies

=== BUILD TARGET demo OF PROJECT demo WITH CONFIGURATION Debug ===

Check dependencies
Code Sign error: No matching provisioning profiles found: No provisioning profiles with a valid signing identity (i.e. certificate and private key pair) matching the bundle identifier “org.nativescript.demo” were found.

** BUILD FAILED **

The following build commands failed:
        Check dependencies
(1 failure)
Command xcodebuild failed with exit code 65

Any clue why I would receive this error?  I shouldn't need to sign my code with the emulator, right?
Thanks!

Tried running from xcode, I see this:
ld: warning: directory not found for option '-F/Projects/demo/platforms/ios/../../lib/iOS'
ld: framework not found Pods
clang: error: linker command failed with exit code 1 (use -v to see invocation)

Hi @dapriett,
We have seen issues where xcodebuild under Xcode 7.2 fails to codesign simulator builds which it shouldn't try to do in the first place. You can either downgrade to Xcode 7.1, or use the Xcode GUI. However, if you're using CocoaPods, be sure to open the Xcode workspace rather than the project under platforms/ios.

Thanks - downgrading to Xcode 7.1 worked.

@fealebenpae this issue probably should remain open as it isn't solved.    Since both 7.2 & 7.3 (Beta) have this same issue "we" as a community may need to figure out how to solve this without downgrading...
One thing that appears to be common that I've seen is this issue only appears when adding a cocoapod.

@NathanaelA at the runtime level there is only ever so much we can do to influence the build - I would suggest posting this on the CLI repo as it's the CLI that drives both Xcode and CocoaPods.

Ah, you are correct, for some reason I though I was on the cli repo.  Sorry about that.   Too many repo screens open.  :grinning:

@dapriett there is a fix for this now; see #1428 I meant to tag you in issue #1428 but forgot to; so I'll post a comment here.  :grinning:

Awesome, thanks @NathanaelA!


GasEstimate for deploy

Fixes #9

:tada: This PR is included in version 1.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Denial of Service if FormCfgPtr pointer not set correctly

if the FormCfgPtr is not set correctly as described here https://doc.micrium.com/display/httpdoc/Parameters+Configuration, no memory is allocated for multipart content handling which can lead to a crash and a denial of service. Easiest fix is to make sure that this pointer is set correctly

Fixed https://github.com/weston-embedded/uC-HTTP/issues/6


Support multiple bluetooth MACs

And if wifi is not working (for example an open wifi with a captive portal) but Bluetooth is, it will disable wifi (release the wlan0 IP) until Bluetooth goes away (most likely after you get home and kill the hotspot manually).  If it doesn't have to do that, it gracefully turns off Bluetooth when it gets a working wifi IP.

I like that, bit more elegant, and makes sense putting that in the oref0-online. I'll have to test it later

This set up works well for me

Humm. This didn't work for me!

Do you have regular Bluetooth working already? Looks from your message in Gitter that you didn't properly install Bluetooth.

Worked for me today with no issue so :+1:

I think I misunderstood the install instructions. From the conversations in Gitter I didn't think a btmac entry was required in the setup process. I reran it specifying a MAC address and it installed okay. bluetoothctl ran correctly.

I'm having a bit of problem with this.  When I disconnect our cable modem from the home network (simulating a "captive network") the rig recognizes this at switches over to hotspot via Bluetooth, but from there it never establishes a connection to the internet.  Here's the error message I'm seeing in the network log.  Any ideas?
Starting oref0-online.
At Sat Feb  4 07:18:02 CST 2017 my local IP is: <IP_ADDRESS>
At Sat Feb  4 07:18:02 CST 2017 my public IP is:
Error, cycling networking
Stopping networking (via systemctl): networking.service.
Starting networking (via systemctl): networking.service.
and getting new wlan0 IP
At Sat Feb  4 07:18:34 CST 2017 my public IP is:
At Sat Feb  4 07:18:49 CST 2017 my public IP is:
Error, connecting BT to 64:A3:CB:38:7D:18, getting bnep0 IP and releasing wifi $
At Sat Feb  4 07:19:08 CST 2017 my public IP is: Finished oref0-online.

Does it work when walking away from wifi? Have you tried the latest dev with https://github.com/openaps/oref0/pull/376 ?

It does work when leaving wifi coverage.   Switches seamlessly, which is nice.  I'll try the latest dev and see if that fixes the problem.  Thanks


Using cronHistory collection in application

Firstly, thanks for such a brilliant package.
I want to use the cronHistory collection in my application but i believe its not currently possible due to the package not exporting the collection (api.export).
Is this correct or am i missing something?
Can this be added?
Thanks,
Luke

Unfortunatelly the SyncedCron object is only available on server. Is there any way how to read the history on the client?

@michalvalasek you could publish the collection yourself.

Hi. I am also trying to access the SyncedCron._collection - when I do a server side log on
console.log(SyncedCron._collection.findOne());

I am getting a fine result. Unfortunatly when I do
console.log(SyncedCron._collection.find());

I get
I20150610-10:25:28.711(2)? { _mongo:
I20150610-10:25:28.711(2)?    { _observeMultiplexers: {},
I20150610-10:25:28.712(2)?      _onFailoverHook: { nextCallbackId: 0, callbacks: {} },
I20150610-10:25:28.712(2)?      db:
I20150610-10:25:28.712(2)?       { domain: null,
I20150610-10:25:28.712(2)?         _events: {},
I20150610-10:25:28.712(2)?         _maxListeners: 10,
I20150610-10:25:28.713(2)?         databaseName: 'meteor',
I20150610-10:25:28.713(2)?         serverConfig: [Object],
I20150610-10:25:28.713(2)?         options: [Object],
I20150610-10:25:28.713(2)?         _applicationClosed: false,
I20150610-10:25:28.714(2)?         slaveOk: false,
I20150610-10:25:28.714(2)?         bufferMaxEntries: -1,
I20150610-10:25:28.714(2)?         native_parser: false,
I20150610-10:25:28.714(2)?         bsonLib: [Object],
I20150610-10:25:28.714(2)?         bson: [Object],
I20150610-10:25:28.715(2)?         bson_deserializer: [Object],
I20150610-10:25:28.715(2)?         bson_serializer: [Object],
I20150610-10:25:28.715(2)?         _state: 'connected',
I20150610-10:25:28.715(2)?         pkFactory: [Object],
I20150610-10:25:28.715(2)?         forceServerObjectId: false,
I20150610-10:25:28.715(2)?         safe: false,
I20150610-10:25:28.716(2)?         notReplied: {},
I20150610-10:25:28.716(2)?         isInitializing: true,
I20150610-10:25:28.716(2)?         openCalled: true,
I20150610-10:25:28.716(2)?         commands: [],
I20150610-10:25:28.717(2)?         logger: [Object],
I20150610-10:25:28.717(2)?         tag:<PHONE_NUMBER>262,
I20150610-10:25:28.717(2)?         eventHandlers: [Object],
I20150610-10:25:28.718(2)?         serializeFunctions: false,
I20150610-10:25:28.718(2)?         raw: false,
I20150610-10:25:28.718(2)?         recordQueryStats: false,
I20150610-10:25:28.718(2)?         retryMiliSeconds: 1000,
I20150610-10:25:28.718(2)?         numberOfRetries: 60,
I20150610-10:25:28.718(2)?         readPreference: [Object] },
I20150610-10:25:28.718(2)?      _primary: '<IP_ADDRESS>:3001',
I20150610-10:25:28.719(2)?      _oplogHandle:
I20150610-10:25:28.719(2)?       { _oplogUrl: 'mongodb://<IP_ADDRESS>:3001/local',
I20150610-10:25:28.719(2)?         _dbName: 'meteor',
I20150610-10:25:28.720(2)?         _oplogLastEntryConnection: [Object],
I20150610-10:25:28.720(2)?         _oplogTailConnection: [Object],
I20150610-10:25:28.720(2)?         _stopped: false,
I20150610-10:25:28.720(2)?         _tailHandle: [Object],
I20150610-10:25:28.721(2)?         _readyFuture: [Object],
I20150610-10:25:28.721(2)?         _crossbar: [Object],
I20150610-10:25:28.721(2)?         _baseOplogSelector: [Object],
I20150610-10:25:28.721(2)?         _catchingUpFutures: [],
I20150610-10:25:28.721(2)?         _lastProcessedTS: [Object],
I20150610-10:25:28.722(2)?         _onSkippedEntriesHook: [Object],
I20150610-10:25:28.722(2)?         _entryQueue: [Object],
I20150610-10:25:28.723(2)?         _workerActive: false },
I20150610-10:25:28.723(2)?      _docFetcher: { _mongoConnection: [Circular], _callbacksForCacheKey: {} } },
I20150610-10:25:28.723(2)?   _cursorDescription:
I20150610-10:25:28.723(2)?    { collectionName: 'cronHistory',
I20150610-10:25:28.723(2)?      selector: {},
I20150610-10:25:28.724(2)?      options: { transform: null } },
I20150610-10:25:28.724(2)?   _synchronousCursor: null }

How can I access the collection on server or in the lib folder to publish it to the client?

Hi - sorry for the noob question - but how would you publish the collection?
I already tried:
On the server:
Meteor.publish('cronHistory', function() {;
	return SyncedCron._collection.find();
});

Iron Router:
Router.route('/', {
  name: 'standorte',
  waitOn: function () {
    return Meteor.subscribe('cronHistory');
  }
});

Template.js on client
Template.sites.helpers({
	croneData: function() {
		console.log(SyncedCron._collection.findOne())
		return SyncedCron._collection.findOne();
	}
});

Browser Console says:
Exception in template helper: ReferenceError: SyncedCron is not defined

On the client you need to have somewhere:
CronHistory = new Mongo.Collection('cronHistory');

Your template should look like:
Template.sites.helpers({
    croneData: function() {
        return CronHistory.findOne();
    }
});

Thank you it worked! Could you explain why this works when I set the new Mongo.Collection only client-side but when it's set in the lib Folder it crashes:
Error: A method named '/cronHistory/insert' is already defined

Does that mean the collection is already available on the server but has to be defined on the client as well? Hope that doesn't bother you - just want to understand Meteor better.
Thank you and by the way - great package!

No worries. The error you're seeing is because the synced-cron package has already defined the collection on the server.

I see - thank you for the explanation.

This keeps being a problem if you want to use something like tabular for showing jobs. Because tabular tables must be defined in common code (as it makes filtering and other ops in server) and there's no way to acces cronHistory collection there, is there?
Thanks!

How do you fix this error? I have added<EMAIL_ADDRESS>to my package.js.
Error: A method named '/cronHistory/insert' is already defined

@zol I followed your suggestions on using the SyncedCron collection on the client side, but I had no success with it. I want to to use the collection inside an React component.
Server
Meteor.publish("cronHistory", function(){     return SyncedCron._collection.find(); });
Client
CronHistory = new Mongo.Collection("cronHistory");

export default class CronHistoryTable extends Component {

    constructor() {
        super();
        const subscription = Meteor.subscribe('cronHistory');
        this.state = {
            ready: subscription.ready(),
            subscription: subscription
        };
    }

    componentWillMount(){
    }

    componentWillUnmount() {
        this.state.subscription.stop();
    }

    cronHistory(){
        console.log(CronHistory.find());
        return CronHistory.find().fetch();
    }

    render() {
        return (

                        Name
                        Started at
                        Finished at
                        Result

                    {this.cronHistory().map((history) => {
                        <CronHistorySingle key={history._id} history={history}/>
                    })}

        )
    }
}

MeteorToys is displaying a DB with the right data in it. But when i log the CronHistory Cursor in cronHistory() on the client side, every value says undefined.Anyone have suggestion why this is the case?


Separate modules / scripts from Grunt jobs

The problem is the management of modules and support of Gruntfile files, which end up generating conflicts over time when added new features to it.
For this it would be interesting to use a manager to dynamically load the configuration scripts of the grunt modules, leaving in Gruntfile.js only the specific tasks. With this would give to have:
+- Gruntfile.js
+- grunt-tasks/
|    +- clean.js
|    +- connect.js
|    +- sass.js
|    +- ....

When there was change in any of these configurations, would be isolated.
An NPM module that does this is: load-grunt-config.  What do you think?

We haven't really had a problem with conflicts in Grunfile.js.


Avoid sync fs.realpathSync calls in reducers. Fixes #204.

@cfollet @KeitIG this LGTM :+1:

Let's go, thanks for your work.


[CARBONDATA-2163][CARBONDATA-2164] Remove spark dependency in core and processing module

The assembly JAR of store-sdk module should be small, but currently it includes spark JAR because carbon-core, carbon-processing, carbon-hadoop modules depends on spark.
This PR removes spark dependency in carbon-core and carbon-processing module

[X] Any interfaces changed?
No
[X] Any backward compatibility impacted?
No
[X] Document update required?
No
[X] Testing done
No logic is modified, rerun all test suites
[X] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
NA

Build Failed  with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/3707/

Build Failed with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/2467/

SDV Build Fail , Please check CI http://<IP_ADDRESS>:8080/job/ApacheSDVTests/3510/

Build Failed  with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/3709/

Build Failed with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/2469/

SDV Build Fail , Please check CI http://<IP_ADDRESS>:8080/job/ApacheSDVTests/3512/

Build Failed  with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/3711/

SDV Build Fail , Please check CI http://<IP_ADDRESS>:8080/job/ApacheSDVTests/3513/

Build Failed with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/2471/

retest this please

SDV Build Fail , Please check CI http://<IP_ADDRESS>:8080/job/ApacheSDVTests/3514/

Build Failed with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/2473/

Build Failed  with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/3714/

Build Failed  with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/3740/

SDV Build Fail , Please check CI http://<IP_ADDRESS>:8080/job/ApacheSDVTests/3539/

Build Failed with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/2500/

Build Failed  with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/4068/

Build Failed with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/2822/

SDV Build Fail , Please check CI http://<IP_ADDRESS>:8080/job/ApacheSDVTests/3762/


Is there a way to limit the radius circle?

Hi, is there a way to limit the radius of the circle. Let say minimum radius = 1000 meters and maximum radius = 5000 meters and the circle radius should not exceed the maximum limit and should not less than minimum limit.

Did you solve? I was able to do a workaround...


Send alert notification to python

Please advice me, I want to send data terminal from notification mt4/mt5 go to python.

Hi @santi2fx,
You would need to customize the MQL server EA to achieve this functionality:
https://github.com/darwinex/dwx-zeromq-connector/blob/master/v2.0.1/mql4/DWX_ZeroMQ_Server_v2.0.1_RC8.mq4
We don't plan on adding terminal notifications at the present time, but if you develop a working patch for notifications, please do feel free to submit a Pull Request and we'll be more than happy to review and commit.
All the best!


Some questions about understanding the paper

Hi, Thanks for your great work ! ! !
I want to ask that,

I didn't fully understand the design of your cross view loss. As far as I understand, you extract features from six panoramic images and decode them as Gaussian parameters, then do unprojection through the masked images, followed by splatting. Then you calculate the loss between the rendering images and the original images, right? My questions are: How is the scale ensured in this process? And when calculating the loss, is it based on the original images or the masked images? Are images from adjacent time frames used?

Are Stage 1 and Stage 2 related? Does Stage 1 only train the 6D pose network and the 2D encoder? Then, according to my understanding, the entire process could also be completed through Stage 2 alone, as the task of Stage 1 is unrelated to Occupancy Estimation.
Looking forward to your reply with sincere anticipation.

Hi,

the scale is learned from the 2D feature map, the loss is based on the masked image, we still did not use the adjacent time frames.
yes, the stage 1 is only for the training 6D pose network, which is then being used for the stage 2.

Thank u for your answer ! !
I have another question: Are the depth scales of the panoramic views all supervised only by the RGB images rendered from adjacent views? Is there anything else designed for this? Because it feels like such supervision would be very weak.

Yes, the small overlap region is sufficient to provide the scale information for the training. We do not have other design.


Correctness fixes for stage2

Correctness fixes to allow the bootloader to work on bochs and kvm.
closes #327

Thanks a lot!


Added generation summary

Modify generation script to summarise output when concluding.
For example:
Generation completed successfully!

Output summary:
- Critical: 2 issues
- Warning: 52 issues

See output file (output/log.txt) for details.

@jordangriffiths01 Do you have any ideas for other information we could add to this?


CAD-763 adapt configuration for LiveView

Issue

configuration adaptations:

comment out the default log output to 'stdout'
set output mode to LiveView

launch the TUI with script: ./scripts/mainnet.sh
(add --stack-nix or other options)

This PR does not result in breaking changes to upstream dependencies.

Checklist

[x] This PR contains all the work required to resolve the linked issue.

[x] The work contained has sufficient documentation to describe what it does and how to do it.

[ ] The work has sufficient tests and/or testing.

[ ] I have committed clear and descriptive commits. Be considerate as somebody else will have to read these.

[x] I have added the appropriate labels to this PR.

bors r+


docs: convert quick start guides into e2e tests

Fixes #1564
Checklist:
Remove the checklist to signal you've completed it. Enable auto-merge if the PR is ready to merge.

[ ] If the pull request requires a cryptography review (e.g. cryptographic algorithm implementations) I have added the 'crypto' tag.
[ ] I have reviewed my diff in github, line by line and removed unexpected formatting changes, testing logs, or commented-out code.
[ ] Every change is related to the PR description.
[ ] I have linked this pull request to relevant issues (if any exist).

@PhilWindle I just added the checks.


hidden transaction data

Hello,  I'd like to know if the transaction amount can be hidden in the online EOS smart contract. Do you plan to develop hidden transaction data later? Our application wants to hide the transaction amount. Our solution is to use homomorphic addition in smart contracts. But when the seck256k1 library can not be directly referenced in the contracts, can you solve the problem?

This is not a feature we currently support. This also would be change eos side, so if desired a feature request can be filed there.


Re-label 'Custom Metrics' tab to 'Custom Metrics Endpoints' in Workload view

What kind of request is this (question/bug/enhancement/feature request):
Enhancement
Steps to reproduce (least amount of steps as possible):
Re-label 'Custom Metrics' tab to 'Custom Metrics Endpoints' in the View/Edit Workload view, to make it explicitly clear this is only for configuring the custom endpoint(s) to scrape, and does not display any metrics themselves unlike under the 'Workload Metrics' tab.
Environment information

Rancher v2.2.8

Available in latest-2.3.

This is validated in v2.3-head with UI index latest-2.3

enable the project monitoring
deploy/edit a workload
see the section Custom Metrics Endpoints under the advanced options


Create command for users to submit custom regex pattern for security scan

As a user, I want to be able to have SeCureLi scan for custom patterns specific for my security concerns
AC

Add a new item to .secureli.yaml called custom_scan_patterns that is an empty list
Create a new command called add_custom_scan_pattern (name suggestions?) Expand Update command to include pattern additions
Command accepts a flag --new_pattern which can be added multiple times, each flag accepts a string
User input is checked and must be a regex pattern. if it pass the check, it is saved in config as an item in custom_scan_patterns
a. If it fails, present error message to user
When the pre-commit scan runs, in addition to default security checks, and the items check by work completed in #435 also check for all patterns in custom_scan_patterns
Add documentation - Readme

Notes

Rather than creating this as a new command, we could make it a prompt as a part of init and/or update

Completed development and unit tests for steps 1-4, work in linked branch feature/secureli-460-custom-regex. Steps 5-6 must still be completed.


How to train the mm_proj and the LLM part with lora of Qwen2-VL

Reminder

[X] I have read the README and searched the existing issues.

System Info
Have installed all the requirements for Qwen2-vl
Reproduction
train_mm_proj_only:True
Hello, I want to train the vision adapter and the LLM part with lora. Do I set the train_mm_proj_only as True like this:
model
model_name_or_path: Qwen/Qwen2-VL-72B-Instruct
method
stage: sft
do_train: true
finetuning_type: lora
lora_target: all
dataset
dataset: mllm_demo,identity  # video: mllm_video_demo
template: qwen2_vl
cutoff_len: 8900
max_samples: 1000
overwrite_cache: true
preprocessing_num_workers: 16
output
output_dir: saves/qwen2_vl-7b/lora/sft
logging_steps: 10
save_steps: 500
plot_loss: true
overwrite_output_dir: true
train
per_device_train_batch_size: 1
gradient_accumulation_steps: 16
learning_rate: 1.0e-4
num_train_epochs: 1.0
lr_scheduler_type: cosine
warmup_ratio: 0.05
bf16: true
ddp_timeout: 180000000
visual_inputs: true
deepspeed: examples/deepspeed/ds_z3_config.json
train_mm_proj_only:True
lora
lora_alpha: 512
lora_dropout: 0.1
lora_rank: 256
eval
val_size: 0.1
per_device_eval_batch_size: 1
eval_strategy: steps
eval_steps: 500
Expected behavior
No response
Others
No response

Im glad this is being reopened (original #5553) because I'm also having the same issue with 8 x 80GB A100s (640GB total) and Qwen2-VL-72B using both LoRA (should take ~180GB) and QLoRA (8-bit) (should take ~100GB). They both OOM, which is unexpected given that it's only a 72B model.

same issue with Qwen/Qwen2-VL-2B-Instruct, only a 2B model using qlora 4bit. When I tried with fsdp, it stucked there.

same issue (even the 7B required 4 A100 GPUs)
I'm only having this problem when fine tuning qwen2-vl

4* 80 G A100 works for me when training Qwen2-VL-72B with lora. I set cutoff_len=4096 in my exp. And the number of my dataset is about 6.6w.
As the issue you mentioned  [https://github.com/hiyouga/LLaMA-Factory/issues/5553]. I try to do full sft of Qwen2-VL-72B, it takes 16 * 80G A100 to train just a few test examples data but for the 6.6w data it will occur OOM so if need to train all of the 6.6w data,maybe it will take 32 * 80G A100.
So maybe your cutofflen and datasets is much larger than mine which will cause OOM

Any update about the 72B-Qwen2-vl lora or qlora training?

do not use train_mm_proj_only, you can add additional_target: merger to training yaml instead


Add owncloud photo on scan command

This should be a separate command, because the ownphotos scan also downloads images to librephotos. I don't think most people are aware of that.

Sorry for the late reply!
I think this should be added as an extra argument, like we did with the full scan command.

I would be happy to implement it as an extra argument. It is the last missing puzzle piece to my picture workflow so I would really like to see that happen soon. Since #247 seems to be a bigger issue and this one here is so small and could be easily refactored at any time, I think it would be really nice to move forward here and not to wait.
@tomamplius, since you already started this, would you like to finish it or would it be alright for you if I would do that?

@npsqm I think we waited long enough. You can implement it 👍

Awesome, thanks @derneuere. I will create a new PR in the next days :)

Superseded by #402


Fix bug in MapGetTileWorld and refactor

After analyzing the code, I have identified an issue with the MapGetTileWorld function where passing a negative x or y in the range of (-TILE_SIZE, 0) would return the first tile in the map instead of EMPTY. To address this issue, I have made a modification to the function where I immediately return EMPTY if x or y is negative. This not only fixes the problem but also simplifies the second condition on line 324, resulting in more efficient code.
Furthermore, upon reviewing the code, I noticed that the shift operator (>>) and TILE_SHIFT were being used unnecessarily for every call to MapGetTile. Given that this logic is already used inside of MapGetTileWorld, I replaced all instances of MapGetTile with MapGetTileWorld and removed the unnecessary shifting-related code. Consequently, the TILE_SHIFT variable was no longer required, allowing me to remove it and further streamline the code.

@raysan5

@hellworld111 thanks for the review! Actually I haven't touched this code in many years, probably now I would write it in a completely different way.


Add support for graphene based coins like STEEM and BTS

Hello,
Great work indeed. I appreciate the hard work done by you. I am looking for similar tip bot with STEEM coins since steem has large userbase on discord. I can help with the configuration of steem nodes and address creation. Might create a PR if you agree.
PS : did you know you can be rewarded by utopian.io for your open source work with STEEM ? Check out https://www.utopian.io and https://steemit.com/@utopian-io.
You can create a steem account for as low as $2.50 at https://www.swapsteem.online

Not in the scope of this project, closing.


Make dots other punctuation optional in fromString

DateTime.fromString is very picky about parsing. A month name has to exactly match what Luxon expects:
DateTime.fromString('févr.', 'MMM', { locale: 'fr'}).isValid //=> true
DateTime.fromString('Févr.', 'MMM', { locale: 'fr'}).isValid //=> true
DateTime.fromString('fevr.', 'MMM', { locale: 'fr'}).isValid //=> false
DateTime.fromString('févr', 'MMM', { locale: 'fr'}).isValid //=> false

I'm not sure how to desensitize the accents (or if that is even desirable), but I think the dots ought to be optional. Should be easy enough to inject ? into the regexes before trying them.

The fix for dots is in d1c67b15e750e855f728f757bbded319ca73e780. Going to ignore other punctuation and accent stuff for now.


[Bug Report] Date picker in table header with render-header

Element UI version
2.4.1
OS/Browsers version
Windows 7 / Chrome Version 67.0.3396.99 (Build officiel) (64 bits)
Vue version
2.5.16
Reproduction Link
https://jsfiddle.net/49z1rjbg/39
Steps to reproduce

click on date-picker range
Select a date range

What is Expected?
It should print the range values (min/max) into the input field of date picker
What is actually happening?
Date picker field remains empty after date selection. But if I open the date picker once again it set it with the previously selected values. How to bind with the input field?

@VinceBassman you need bind value to DatePicker. https://jsfiddle.net/zhiyang/49z1rjbg/44/


Support animations with timing functions

Currently, all animations are Spring animations, can support Easing animations as well.

How about adding in Animatable
  /**
   Animation force (default value should be CAMediaTimingFunction(name: kCAMediaTimingFunctionEaseInEaseOut))
   */
  var timingFunction: CAMediaTimingFunction { get set }

and to Animatable classes something like that
  @IBInspectable open var _timingFunction: String = kCAMediaTimingFunctionEaseInEaseOut {
    didSet {
      timingFunction = CAMediaTimingFunction(name: _timingFunction)
    }
  }
  open var timingFunction: CAMediaTimingFunction = CAMediaTimingFunction(name: kCAMediaTimingFunctionEaseInEaseOut)

Instead of CAMediaTimingFunction we can have our own type TimingFunctionType enum or class which provide a CAMediaTimingFunction
So we can parse the string for custom CAMediaTimingFunction types
Wrapping allow providing also multiple CAMediaTimingFunction for animation which requires multiples ones

@phimage Thanks for posting your idea. This is a useful feature. In one of my app, I slide a panel up and down. And I should use easeInEaseOut instead of Spring because using Spring will have a gap at the bottom (when bouncing) for a short period.
timingFunction property
I like your idea to have inspectable property timingFunction 👍. As you said, we may have our enum like TimingFunctionType. I can see two benefits of it.
Firstly, we can support more timing functions than linear, easeIn, easeOut, easeInEaseOut or  easeOutEaseIn. We can have pre-defined timing functions like EaseOutQubic (CAMediaTimingFunction(controlPoints: 0.215, 0.61, 0.355, 1)).
Secondly, we can translate them into Core Animation or UIView Animation, In IBAnimatable, some of our animation uses Core Animation, and some use  UIView Animation. In Core Animation, we use CAMediaTimingFunction. In UIView Animation, we use UIViewAnimationOptions. We need to provide a single enum and translate it into different timing function for Core Animation or UIView Animation.
Default value for timingFunction
For the default value for timingFunction, we may not able to set the default value to kCAMediaTimingFunctionEaseInEaseOut. Because timing function animation and Spring animation are conflicted each other. It means if we use timing function, we can't use Spring. iOS 10 introduced UIViewPropertyAnimator, we may be able to use both together but not at the same time. Therefore, we may treat timingFunction as a flag. If the user sets the animationType and timingFunction, then we use timing function to control the animation. If the user sets the animationType but not timingFunction, then we use damping, velocity and force for Spring animation as the current implementation.
timingFunction animation in code.
Adding timingFunction property is a great approach for support animation with timing function in Interface Builder. But we still need to provide nice programmatical API for using it in code. I don't know the exact solution yet, we may need to add new overload methods for Animatable.animate() and AnimationPromise.then(). We may need to spend some time to find the solution.
I think this is a great feature and do you think we should set it as the theme for release 5? Once we have it, we ship version 5.
@tbaranes can you also have a look at @phimage 's proposal?
@lastMove if you have time, can you have a look and provide some advice on timingFunction animation in code? It will be a great extension for your promise-like animation API.

I will make the first move today
Create the feature branch and the enum
Have already done the code yesterday, need some tests
I will add #12 to where I have questions

branch feature/timingfunction
https://github.com/IBAnimatable/IBAnimatable/tree/feature/timingfunction
https://github.com/IBAnimatable/IBAnimatable/compare/feature/timingfunction?expand=1
See all  #12 in code for the question and work to do
Currently default value for animation is not well managed. There is a none case but I think about putting nil instead, depending on IBAnimatable philosophy. If none, when animating, default value must be used (not implemented)

@phimage great start 👍 Do you think we can create a PR like [WIP] Support timing function for animation? then we can make comments on the PR.
I think in IBAnimatable we use none for enums and nil for String value which maps to none case like MaskType and AnimationType.
If timingFunctionType is none, should we use the Spring animation as what we have already? If it is .default then use default timing?

PR #456 has been created
I will not have time this weekend to do more


Wind Speed Inaccurate

Afternoon all!
After the headache of Yahoo messing around with Oauth, everything 'appears' to be back to normal, except with one odd issue. My wind speed is incorrect, like very incorrect.
For example, today it's returning 28.97, while the actual Yahoo weather website is showing 11.
Is any one else getting this? It's complete feasable i'm cocking something up though ;)
Site for reference is https://midgr.uk
On a side note, love the script. Any chance of moving to the Dark Sky API... it's much more accurate (well, for me!).

I am having the same wind speed issue. I wonder if it is pushing the wind "gust" speed and not average speed? Either way, it isn't accurate when compared to Yahoo weather website.


Jenkins: v4.0.0 pipeline updates

fix for first issue in #255 : Newman report will now be published to jenkins even if zap tests fail
fix git badges to point to v4.0.0 pipeline
updated to use depl image in integ test stage

retest this please


Auto-paste address

If an address is in the clipboard, automatically paste it when user clicks on the address textbox.

Feature added in 0.1.4