Makes required extensions composer.json required.

ext-readline, ext-pcntl and ext-posix should be marked required rather than suggested as boris requires them.

I actually had to lock the Boris version to 1.0.8 to update an older site on a live server that doesn't have readline installed. The site depends on Laravel 4.2 which depends on Boris, but obviously I never plan to use Boris on the live server.
This can probably be blamed on Laravel for putting Boris in its require block instead of suggesting it, but I guess it's something to note.

Th

The best solution is likely for Laravel to cut a patch release that moves boris to "suggested".

Taylor refused to do that before. I even suggested putting the dependency in laravel/laravel so it still worked out of the box. L4.2 is not supported anymore anyway.

FWIW, I ended up changing my deploy script to run composer install --ignore-platform-reqs on the server - that works fine, but means you have to manually ensure that required extensions are actually available. I feel I can do this rather safely for Laravel 4 legacy (lol) apps.
@GrahamCampbell You could've just as easily moved it from require to suggest, and display a friendly error message when trying to artisan boris without the package being installed. Saying you "ditched" Boris in this context makes it sound like it's this package which has a flaw, when it really is Laravel.

@anlutro I wanted this even before the 4.2.0 release, but taylor was really against it. Laravel 4.2 is closed for anything but security fixes, so this will never be changed. People need to upgrade to L5 if they don't want boris.

What's done is done. I'm just saying that when you write "that's why Laravel 5 ditched Boris" in this context, you're making it out to be Boris's fault that Laravel installations are screwing up due to this change. The same thing happened when there were problems with Whoops a year or so ago - Laravel had a bug in its integration with Whoops (the error reporting package), but the Laravel maintainers insisted on shifting blame towards Whoops. I think it's unfortunate for Laravel's public relations and a bit disrespectful towards package maintainers.
I personally don't want to upgrade to Laravel 5 and I'm more than fine with Boris, I just want to get security updates from other packages. Adding --ignore-platform-reqs to the composer install command in my deploy script does that for me.

@anlutro That wasn't what I meant. I meant, we're ditching it because we need to support windows, that's all. :) Regarding the --ignore-platform-reqs, yeh, that's a good idea, and one I've recommended before, but we don't want to recommend it officially, because then we'll get people using it to hack around the mcrypt dependency or something.


Watch with partner

Summary by Sourcery
Add functionality to manage and display partners watching TV shows together, including UI updates to show active partners and toggle their participation.
New Features:

Introduce the ability to track which partners are watching a TV show together by adding a 'with' field to the watching records.

Enhancements:

Enhance the TV show list element to display active partners watching the show and allow toggling partners using a switch field.

@sourcery-ai review

https://github.com/sourcery-ai review

@sourcery-ai review


Reactivating CLRVersion in $PSVersionTable

Summary of the new feature / enhancement
It would be nice, if you reactivate the CLRVersion of the Windows Powershell in the new Powershell.
Proposed technical implementation details (optional)
$PSVersionTable.CLRVersion = [System.Runtime.InteropServices.RuntimeInformation]::FrameworkDescription -split '\s' | select -Last 1
$PSVersionTable.OSArchitecture = [System.Runtime.InteropServices.RuntimeInformation]::OSArchitecture
$PSVersiontable

See also:

#19121


Polymer Deprecated - Does this impact Horizon card?

I was reading that Polymer is deprecated in HA and support for it is scheduled to be removed. I noticed some references to Polymer in the .js file. Will this impact the Horizon card?

Horizon card uses Lit. I guess the "Polymer" references are simply because of copyrights (Lit is related to Polymer). Horizon card is not impacted.


Fix the tracking of immature coinbase deposits

#567 uncovered that we were actually not tracking coinbase deposits correctly. In fact we would most likely miss them all in any real situation. This is because we would filter out immature coinbase deposits from the result of listsinceblock and not consider them newly received coins. But they would be confirmed, and as the chain moves forward we'd not scan this range anymore even once they've become mature.
This PR fixes it by the simplest possible manner: record immature coinbase deposits as unconfirmed and only mark them as confirmed once they've become mature. This is a bit clumsy, but should be fine for the number of users that would receive payouts from coinbase transactions (ie most likely 0). Also, we don't accurately update coinbase coins on reorg. This is unnecessary as it'd be very unlikely that a mature coinbase would become immature and if there is a 100 blocks reorg that would invalidate it altogether we'd have bigger problems.
Fixes #567.
Still as draft as i want to go over this one more time before asking for review, as this if pretty intricate and touches core parts of our codebase.

I'd like to this in master rather earlier than later. I think i'll have another pass at reviewing tomorrow and merge it if i don't find anything.
@edouardparis please do still review it, it's pretty critical that we get this right.

self-ACK 097d5e71c19c0c5fc53d1e91087d91edfdd218f3. Didn't have the chance to re-review it but getting it in is best at this time. Edouard will still have a look post-merge.


Issues with Bing Web Search API

I get a 'Bing Web Search API Key is not valid' message, even after entering the key.

I can see here that the endpoint URL differs from the one I was provided in the Azure dev portal.
My endpoint is showing up as 'https://api.bing.microsoft.com/' if that's any help.

Will investigate the difference between these two endpoints.

Thank you!
Maybe there's something else I am doing incorrectly. Everything apart from the web search part is working perfectly.


Misc updates for LDAP API authentication

Although the docs say that creation of the salt-api user can be avoided by setting SALT_API_USER="" this doesn't currently work.
The code uses:
https://github.com/cdalvaro/docker-salt-master/blob/44c73c718b652b94b180c9214acdb9c8417e04b1/assets/runtime/env-defaults.sh#L11
However this doesn't distinguish between unset and null, so always sets SALT_API_USER=salt_api
This PR uses an alternative method of parameter expansion to test if $SALT_API_USER is undefined instead of null before setting a default value, resulting in:
> unset SALT_API_USER
> source runtime/env-defaults.sh
> echo $SALT_API_USER
salt_api
>
> SALT_API_USER=""
> source runtime/env-defaults.sh
> echo $SALT_API_USER

This then means that:
https://github.com/cdalvaro/docker-salt-master/blob/44c73c718b652b94b180c9214acdb9c8417e04b1/assets/runtime/functions.sh#L472
Will test false and skip user creation.

Hi @mrichar1, thank you for opening this issue!
I see your point, but as long as SALT_API_ENABLED is set to anything other than true, the line you mentioned should never be executed:
https://github.com/cdalvaro/docker-salt-master/blob/44c73c718b652b94b180c9214acdb9c8417e04b1/assets/runtime/functions.sh#L470-L472
I’d like to better understand your issue. Are you simply expecting to see the SALT_API_USER environment variable empty when SALT_API_ENABLED=false, or have you encountered a specific failure?

Hi,
I'm trying to enable the API but then not create a local salt_api user as I'm planning on using LDAP for auth. So I'm setting:
SALT_API_ENABLED="True"
SALT_API_USER=""

However when I start the container it errors with:
[ERROR] - SALT_API_USER_PASS env variable must be set to create 'salt_api' user.

OK, great!
So, I’d like to slightly change the purpose of the PR, if possible, and shift it more towards adding support for LDAP.
To achieve this, I’m going to ask you to:

Get your modified image working with LDAP.
Add documentation to the README with an example of how to configure salt-api with LDAP (focused only on the salt part; no need to provide details on setting up an LDAP server). I’ll handle the translation into Spanish.
Add a test to verify that when the environment variable is set to empty, it doesn't default to a value inside the container.

Feel free to ask me for help with anything you need!

Yes I'm more than happy to work through the whole process and report back at the end. Will let you know how I get on!

I've added a couple more commits to get LDAP authentication working:

Add some build and run-time deps to the Docker image.
Document the steps to doing LDAP auth (with a simple example).

I'll come back again and have a look at writing a test for the empty SALT_API_USER soon.
Let me know if you have any comments or would like any changes made (especially if there's anything in the docs which isn't clear or needs more/less detail...)

That's the requested changes made and the PR rebased to remove the old commits. New changes are as follows:

install.sh: Add build deps and runtime deps for python-ldap, and install via pip
Test that container starts with SALT_API_USER="" (needed some changes to tests/lib/common.h to check the container exit code, and clean up exited containers).

The previous commits to allow empty SALT_API_USER and the documentation updates are unchanged.

Would you be willing to create an integration test, salt-api-ldap.sh, using a test container, for example with osixia/docker-openldap?
It’s totally fine if it’s too much; I can add it later.

Two more things:

Update all references to revision _3 pointing to revision _4. For example, inside the Dockerfile:

https://github.com/cdalvaro/docker-salt-master/blob/44c73c718b652b94b180c9214acdb9c8417e04b1/Dockerfile#L8
Other entries are: README.md (EN), README.md (ES), and bug_report.md

Update CHANGELOG.md adding and entry for this new version. Something like:

**3007.1_4**

- Add support for LDAP ([#267](https://github.com/cdalvaro/docker-salt-master/pull/267))

I'm happy to have a look at an integration test - though it might be better putting in a fresh PR as it might take a bit longer and need more discussion (e.g. applying test functions like start_container_and_wait and cleanup to 3rd party docker containers etc).

I'm happy to have a look at an integration test - though it might be better putting in a fresh PR as it might take a bit longer and need more discussion (e.g. applying test functions like start_container_and_wait and cleanup to 3rd party docker containers etc).

OK! It seems right!

Two more things:

Update all references to revision _3 pointing to revision _4. For example, inside the Dockerfile:

https://github.com/cdalvaro/docker-salt-master/blob/44c73c718b652b94b180c9214acdb9c8417e04b1/Dockerfile#L8
Other entries are: docs/*/README.md and bug_report.md.

Update CHANGELOG.md adding and entry for this new version. Something like:

**3007.1_4**

- Add support for LDAP ([#267](https://github.com/cdalvaro/docker-salt-master/pull/267))

Hi @mrichar1, just a reminder. As soon as you make these changes I'll approve the PR.

That's the version info updated everywhere :+1:

Thank you very much, @mrichar1! Great contribution! 🚀


Automator: update proxy@master in istio/istio@master

Generated by Automator - 2023-10-20T17:19:12+00:00

@istio-testing: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-distroless_istio
5d2aa3295a1eccc3f1d139c0e973cb23617d40eb
link
true
/test integ-distroless

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Date issue occurring again - Cannot pass in a date earlier than one week ago

Hi Nora Jones,
The version on GitHub should be working fine. There was a problem with the version numbering on PyPI so the latest changes were not present there and could not be seen when installing with pip install twitterscraper. However, the version number has been updated and it should be working fine now when installed from PyPi.
Can you also check it?

Hi Taspinar,
I actually copied the code directly from github. It worked great momentarily, but now I'm having the same issue as before with the dates where it will not go back further than a week. It's as if some sort of notification occurred that enabled Twitter to know I was trying to go back further than a week.
Thanks,
Nora
On Jul 24, 2016, at 7:23 AM, taspinar <notifications<EMAIL_ADDRESS>wrote:
Hi Nora Jones,
The version on GitHub should be working fine. There was a problem with the version numbering on PyPI so the latest changes were not present there and could not be seen when installing with pip install twitterscraper. However, the version number has been updated and it should be working fine now when installed from PyPi.
Can you also check it?

You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/taspinar/twitterscraper/issues/2#issuecomment-234771850, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AOJu8lczotRUxEAtRWcDkPPbp6HbgoMmks5qY0sXgaJpZM4JTZMh.

No 503 error is returned this time either, it simply runs for a millisecond and then, stops. Like I was saying, the changes worked momentarily, and then all of a sudden stopped - it is bizarre.

Hi norajones,
Can you try to use a random (fake) User-Agent to see if this solves your problem?
(first install fake_useragent with pip install fake_useragent)
on the top of the page:
from fake_useragent import UserAgent ua = UserAgent()
and on line 85:
headers = ua.random

Hi Taspinar,
Looks like this is causing other issues,
generic exception: Traceback (most recent call last):
  File "twitter-scraper.py", line 92, in scrape_tweets
    response = requests.get(url, headers=headers)
  File "/Library/Python/2.7/site-packages/requests/api.py", line 71, in get
    return request('get', url, params=params, **kwargs)
  File "/Library/Python/2.7/site-packages/requests/api.py", line 57, in request
    return session.request(method=method, url=url, **kwargs)
  File "/Library/Python/2.7/site-packages/requests/sessions.py", line 461, in request
    prep = self.prepare_request(req)
  File "/Library/Python/2.7/site-packages/requests/sessions.py", line 394, in prepare_request
    hooks=merge_hooks(request.hooks, self.hooks),
  File "/Library/Python/2.7/site-packages/requests/models.py", line 296, in prepare
    self.prepare_headers(headers)
  File "/Library/Python/2.7/site-packages/requests/models.py", line 407, in prepare_headers
    self.headers = CaseInsensitiveDict((to_native_string(name), value) for name, value in headers.items())

AttributeError: 'unicode' object has no attribute 'items'
I've been able to reproduce both issues on separate machines as well.

Yes, of course the parameters passed on to requests should be hashable. :)
try : headers = {'User-Agent': ua.random}

thanks for your help! One more error I'm getting after this runs for a bit...
  File "count-old-words-current.py", line 98, in scrape_tweets
    response_json = response.json()
  File "/Library/Python/2.7/site-packages/requests/models.py", line 812, in json
    return complexjson.loads(self.text, **kwargs)
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/json/__init__.py", line 338, in loads
    return _default_decoder.decode(s)
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/json/decoder.py", line 366, in decode
    obj, end = self.raw_decode(s, idx=_w(s, 0).end())
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/json/decoder.py", line 384, in raw_decode
    raise ValueError("No JSON object could be decoded")
ValueError: No JSON object could be decoded

Is this a result of Twitter potentially blocking?

I have seen something similar last night. Most probably ua.random is returning mobile User-Agent strings, resulting in Twitter returning a mobile web-page (which has a different structure). You can see this behaviour by printing the URL: print response.url.
Unfortunately fake-useragent does not provide the option to select non-mobile user agent strings only.
Try the following :
headers_list = [ua.ie, ua.msi, ua['Internet Explorer'], ua.opera, ua.chrome, ua.google, ua['google chrome'], ua.firefox, ua.ff]
import random
headers = {'User-Agent': random.choice(headers_list) }

Hm, I'm thinking, to insert a statement that allows for the program to continue if it does hit a mobile web-page.

Any other ideas? @taspinar

There is something strange with the Requests package resulting in the mobile URL (even though the User-Agent is not mobile). As far as I have seen, this is not the case for urllib2.
Can you check if the newest version works without any problems?

Just checked the new version, not getting the same errors, but now getting 404s back at a certain point in scraping.
From: taspinar
Reply-To: taspinar/twitterscraper
Date: Thursday, July 28, 2016 at 7:02 PM
To: taspinar/twitterscraper
Cc: Nora Jones, Author
Subject: Re: [taspinar/twitterscraper] Date issue occurring again - Cannot pass in a date earlier than one week ago (#2)
There is something strange with the Requests package resulting in the mobile URL (even though the User-Agent is not mobile). As far as I have seen, this is not the case for urllib2.
Can you check if the newest version works without any problems?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/taspinar/twitterscraper/issues/2#issuecomment-236050673, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AOJu8tj9mhXdirU2K7CTQaPduF38nCmrks5qaTUbgaJpZM4JTZMh.

Hi Norajones,
removed internet explorer from the list of headers containing User-Agent information. The response to internet explorer (like the mobile user-agent strings) was so different that the regular dom-elements can not be used to retrieve the tweets.


ENH: Jones and Faddy Skew-T distribution

Reference issue
Closes https://github.com/scipy/scipy/issues/18947
What does this implement/fix?
This PR implements Jones and Faddy's skewed extension of the t distribution. This distribution is useful when describing data which is both heavy tailed and skewed.

Thanks for the PR @JWTownhill !

:) Thanks for your comments and suggested changes.

Typically, new distributions have to be proposed on the mailing list first. The distribution seems to me important enough though due to the number of citations and the PR is already there, so I had a first look.

Aha, thank you, I have now tried to send something around on the mailing list. I wasn't aware it existed before - I had been following this guide in the first instance: https://docs.scipy.org/doc/scipy/dev/contributor/adding_new.html#adding-a-new-statistics-distribution

The most important thing is probably the name of the distribution. I would opt for skewt, if there are no other popupar skewed generalizations of the central t distribution.

I'm not confident this is the most popular skewed generalised t distribution, but I find it easier to use than this multivariate version by Azzalini which has 1.1k citations for the paper. In the Jones and Faddy 2003 paper they discuss a couple of other skewed t distributions which exist (including the Azzalini one).
It seemed safer to opt for jf_skew_t rather than calling the Jones and Faddy version simply skewt which implies it is the 'default' version.

Another point to consider: could you add a _logpdf function?

Perhaps I could! What is the advantage of it though? Do you think a better job can be done than the default behaviour of taking the log of the pdf? It's not obvious to me.
Thanks again for your comments, I will look through your suggested changes.

Thanks for the PR @JWTownhill !

:) Thanks for your comments and suggested changes.

Typically, new distributions have to be proposed on the mailing list first. The distribution seems to me important enough though due to the number of citations and the PR is already there, so I had a first look.

Aha, thank you, I have now tried to send something around on the mailing list. I wasn't aware it existed before - I had been following this guide in the first instance: https://docs.scipy.org/doc/scipy/dev/contributor/adding_new.html#adding-a-new-statistics-distribution

The most important thing is probably the name of the distribution. I would opt for skewt, if there are no other popupar skewed generalizations of the central t distribution.

I'm not confident this is the most popular skewed generalised t distribution, but I find it easier to use than this multivariate version by Azzalini which has 1.1k citations for the paper. In the Jones and Faddy 2003 paper they discuss a couple of other skewed t distributions which exist (including the Azzalini one).
It seemed safer to opt for jf_skew_t rather than calling the Jones and Faddy version simply skewt which implies it is the 'default' version.

Ok, that sounds convincing to me.

Another point to consider: could you add a _logpdf function?

Perhaps I could! What is the advantage of it though? Do you think a better job can be done than the default behaviour of taking the log of the pdf? It's not obvious to me.

Taking the logarithm of the beta function avoids intermediate overflow:
from mpmath import mp
import numpy as np
from scipy import special as sc

def _pdf(x, a, b):
    c = 2 ** (a + b - 1) * sc.beta(a, b) * np.sqrt(a + b)
    d1 = (1 + x / np.sqrt(a + b + x ** 2)) ** (a + 0.5)
    d2 = (1 - x / np.sqrt(a + b + x ** 2)) ** (b + 0.5)
    return d1 * d2 / c

def _logpdf(x, a, b):
    c = np.log(2) * (a + b - 1) + sc.betaln(a, b) + 0.5 * np.log(a + b)
    d1 = np.log1p(x / np.sqrt(a + b + x ** 2)) * (a + 0.5)
    d2 = np.log1p(-x / np.sqrt(a + b + x ** 2)) * (b + 0.5)
    return d1 + d2 - c

def pdf_mpmath(x, a, b):
    x = mp.mpf(x)
    a = mp.mpf(a)
    b = mp.mpf(b)

    c = 2 ** (a + b - mp.one) * mp.beta(a, b) * mp.sqrt(a + b)
    d1 = (mp.one + x / np.sqrt(a + b + x ** 2)) ** (a + 0.5)
    d2 = (mp.one - x / np.sqrt(a + b + x ** 2)) ** (b + 0.5)
    return float(d1 * d2 / c)

mp.dps = 500

x, a, b = 10, 1e3, 2e3

np.exp(_logpdf(x, a, b)), pdf_mpmath(x, a, b) # this works
>> (3.667440225059364e-175, 3.667440225071735e-175)

_pdf(x, a, b) # this fails with
      1 def _pdf(x, a, b):
----> 2     c = 2 ** (a + b - 1) * sc.beta(a, b) * np.sqrt(a + b)
      3     d1 = (1 + x / np.sqrt(a + b + x ** 2)) ** (a + 0.5)
      4     d2 = (1 - x / np.sqrt(a + b + x ** 2)) ** (b + 0.5)

OverflowError: (34, 'Result too large')

Admittedly, these are extreme parameter values but at some point there will be users testing out extreme parameter ranges. Often, doing intermediate calculations in logspace avoids such problems in statistical routines. If possible, let's try to avoid such issues from the beginning.
This is also another PR where #17697 would come in handy for the survival and inverse survival functions but that one should not hold this up.

Another point to consider: could you add a _logpdf function?

I think it's fine to leave _logpdf for a follow-up. Technically a more accurate way to handle the intermediate overflow here would be to use the Lanczos approximation which is available in special as a private function. This could be left to the far future though if we ever decide we need that level of accuracy.

Please could someone let me know the correct workflow to merge the PR once it gets approved? Most of the time I would squash my commits so they become just one commit and rebase my branch before merging it, but I'm not sure how things are usually done for SciPy. Thanks

Please could someone let me know the correct workflow to merge the PR once it gets approved? Most of the time I would squash my commits so they become just one commit and rebase my branch before merging it, but I'm not sure how things are usually done for SciPy. Thanks

This will be taken care of by a maintainer, no need to worry about that on your end.

I'm seeing a relevant test failure. There are a lot of tests failing for unrelated reasons that made this easier to miss.
FAILED stats/tests/test_fit.py::test_cont_fit[MM-jf_skew_t-arg48] - ValueError: Method of moments
encountered a non-finite distribution moment and cannot continue. Consider trying method='MLE'.

In stats/tests/test_fit.py you need to add jf_skew_t to mm_failing_fits here:
https://github.com/scipy/scipy/blob/65635dd55dca0962ab1e3260500b84306fc6500c/scipy/stats/tests/test_fit.py#L58-L68
after that everything should be good to go.

In stats/tests/test_fit.py you need to add jf_skew_t to mm_failing_fits here:

Thank you, I had missed this because I'd been running only the default 'fast' tests locally. Now added to the list.

Sorry, before this goes in someone needs to look over the docs as well. @dschmitz89, do you have bandwidth?

@JWTownhill, before I approve the workflows, can you push another commit which contains [skip cirrus] [skip actions] in the message. This will skip CI jobs which aren't relevant for a doc only change. You can do something like
git commit --allow-empty -m "EMPTY: [skip cirrus] [skip actions]"


Re-advertise topic if the ros client has changed

If the ros client of a topic instance changes in Grasshopper, for example, if a new ROS connect component is connected to it, it needs to detect the instance is not the same and re-start the advertise operation before publishing.
This was found by @kunaalchadha and we tested the fix on his machine.
What type of change is this?

[x] Bug fix in a backwards-compatible manner.
[ ] New feature in a backwards-compatible manner.
[ ] Breaking change: bug fix or new feature that involve incompatible API changes.
[ ] Other (e.g. doc update, configuration, etc)

Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

[x] I added a line to the CHANGELOG.rst file in the Unreleased section under the most fitting heading (e.g. Added, Changed, Removed).
[x] I ran all tests on my computer and it's all green (i.e. invoke test).
[x] I ran lint on my computer and there are no errors (i.e. invoke lint).
[ ] I added new functions/classes and made them available on a second-level import, e.g. compas_fab.robots.CollisionMesh.
[ ] I have added tests that prove my fix is effective or that my feature works.
[ ] I have added necessary documentation (if appropriate)

LGTM


copr: non-null rpn_fn by default

What problem does this PR solve?
Problem Summary:
non-null is now by default for rpn_fn macro. If needs manually handle None case, we should add nullable in attributes.
What is changed and how it works?
Proposal: RFC: Using chunk format in coprocessor framework
Related Issue: #7724
What's Changed:

non-null by default, add nullable attribute in rpn_fn
All functions are refactored to be nullable, except for some arithmetic ones.
In expr_eval.rs tests, we modified a cast function to be non-nullable.

Check List
Tests

Unit test

@TennyZhuang @breeswish PTAL~ Thanks


What voice chat mods are supported?

I checked Plasmo Voice and nothing seems to be happening with it.
What mods are supported and how to use this feature? Can I have an example?

There aren't any right now.
CPM has an API (in 0.4.0) for registering voice.
https://github.com/tom5454/CustomPlayerModels/wiki/API-documentation#voice-animation
Voice chat mods have to implement compatibility.


jaeger-collector dropping spans & traces

Requirement - what kind of business use case are you trying to solve?
Using jaeger-collector to store spans & traces in kafka, and then jaeger-ingester to store in cassandra.
Problem - what in Jaeger blocks you from solving the requirement?
I'm running at least 6 jaeger-collector instances and after a seemingly random amount of time (in this case 7~ hours) they start dropping what seems like the majority of spans and traces.
I'm not seeing anything in the logs that indicate an issue producing/communicating to kafka, in fact it looks like all logging stops on all my pods.
I've configured the collectors with these settings
collector:
    Image:       jaegertracing/jaeger-collector:1.9.0
    Ports:       14267/TCP, 14268/TCP, 9411/TCP
    Args:
      --collector.port=14267
      --collector.http-port=14268
      --collector.zipkin.http-port=9411
      --kafka.brokers=kafka-0.broker:9092,kafka-1.broker:9092,kafka-2.broker:9092
      --kafka.encoding=protobuf
      --kafka.topic=traces

This is what our prometheus metrics look like when the problem is happening. The spans were dropping until I restarted all the jaeger-collector pods, then ~7 hours later we see the problem again and it resolves again when I restart the pods.

There should be metrics from Kafka writer, I would check if you started getting write errors or latency.

This is what the two graphs look like next to eachother.

old issue, haven't come up in 5yrs, closing


http://element-cn.eleme.io   is null page!!!

Element UI version
2.3.8
OS/Browsers version
window
Vue version
2.5.17-beta.0
Reproduction Link
https://jsfiddle.net/mmx38qxw/
Steps to reproduce
The document page is null page.
http://element.eleme.io/#/zh-CN
http://element.eleme.io/#/zh-CN/component/
What is Expected?
The document page is null
What is actually happening?
The document page  is null

+1

reading plain text version 😢  https://github.com/ElemeFE/element/blob/dev/examples/docs/en-US/table.md

+1

+1

+10086

+2k

+1

是不是和阮一峰一样，被攻击了？

+1

No, we're not under attack. There's a problem during DNS lookup.

We're aware that this affects almost everybody, so please don't +1 here.
The team's working on it.

https://element.eleme.io and http://element-cn.eleme.io are back online.


Test connection show "Connection refused" when connection toggle is disconected.

Server selection is grayed out when talking with a server.
Test server doesn't try to connect when connection toggle is off.
Could not connect:

Connection refused: connect

Try leaving at blockstream, and go to screen where you have bottom right toggle button, then disable it and then enable it and see if it connects.
I notices inconsistency with Test server functionality.

I notices inconsistency with Test server functionality.

Yes - recently fixed a bug where the previous server details weren't cleared after a failed test.

Ok awesome.
On Sat, 6 Mar 2021, 14:45 craigraw<EMAIL_ADDRESS>wrote:

I notices inconsistency with Test server functionality.
Yes - recently fixed a bug where the previous server details weren't
cleared after a failed test.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/sparrowwallet/sparrow/issues/70#issuecomment-791944515,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AILPGMEBIUS2K2WPDP5DHMDTCIWWXANCNFSM4YWCI6HQ
.


WIP Greg/ci/add circle

NOTE Waiting to test the linting, but github api issues are blocking circle from being able to run a test on a new branch.
Summary of changes
Changes introduced in this pull request:

Took inspiration (a fair bit) from libra
Adds Circleci
Does not remove github actions

Reference issue to close (if applicable)

Closes #440
Other information and links

I suggest rolling this out slowly, not making circle builds mandatory yet, let a few prs go through to iron out any potential bugs before migrating.

@priom I agree
One thing I've done is actually use a cache on the cargo builds so that we don't need to re-build everything


Segmentation fault after issuing kedro install

Description
I was following this tutorial to create a new project using Kedro, however I get a Segmentation fault error after I run kedro install.
Context
My goal was to follow the tutorial and create an example project to explore Kedro's functionalities.
Steps to Reproduce
Here's what I did exactly:

pip3 install kedro
mkdir kedro_example_project && cd kedro_example_project
kedro new, following the instructions. The project's root directory is kedro-tutorial
virtualenv -p /usr/bin/python3 .venv
source .venv/bin/activate, thus activating the virtual environment
cd kedro-tutorial
kedro install

Expected Result
Project dependencies are correctly installed
Actual Result
Project dependencies claimed to be correctly installed (Successfully installed ...), but then pip outputs an additional line of text: Segmentation fault. If I try to run pip freeze from within the virtual environment, I notice that such dependencies were not installed
Your Environment
Include as many relevant details about the environment in which you experienced the bug:

Kedro version used (pip show kedro or kedro -V): 0.15.4
Python version used (python3 -V): 3.6.8
Operating system and version: KDE Neon 5.17 (based on Ubuntu 18.04)

could you please include the full output, also could you please run "kedro info" and include the full output of that as well

@tolomea I've just edited my post

That looks weird. And it's likely to be caused by some specific setup on your machine, low memory or even corrupted memory.
Can you please enable core dumps (something like that) and re-run the failing part? it will generate a dump file, which might give a clue what causes it.

@anferico any luck following @Flid 's recommendation?

@lorenabalan Actually I solved the problem by installing Kedro within a virtual environment, which, as I realized later, was the approach that you suggest in the tutorial.
I guess the problem was due to conflicts between Python packages installed via apt and those installed via pip

Glad to hear it's working now! I'll go ahead and close this issue in that case. :)


Matrix output is broken

fastaai db_query runs smoothly on a formatted database. However, it breaks upon usage of matrix output
fastaai db_query --query ./FastAAI/database/bac_proteidb --target ./FastAAI/database/bac_proteidb --threads 14 --verbose --output FastAAI_matrix --output_style matrix
Performing an all vs. all query on ./FastAAI/database/bac_proteidb
Perusing database metadata
Calculating AAI
Completion |##################################################|  100.00% ( 548 of 548 ) at 25/05/2023 14:44:00
Finalizing results.
Completion |#################                                 |   35.71% ( 5 of 14 ) at 25/05/2023 14:44:00
Traceback (most recent call last):
File "/home/filipe/.local/bin/fastaai", line 8, in
sys.exit(main())
File "/home/filipe/.local/lib/python3.10/site-packages/fastaai/fastaai.py", line 4613, in main
db_query(query, target, verbose, output, threads, do_stdev, style, in_mem, store)
File "/home/filipe/.local/lib/python3.10/site-packages/fastaai/fastaai.py", line 3399, in db_query
mdb.run()
File "/home/filipe/.local/lib/python3.10/site-packages/fastaai/fastaai.py", line 3335, in run
self.db_on_disk()
File "/home/filipe/.local/lib/python3.10/site-packages/fastaai/fastaai.py", line 3265, in db_on_disk
self.write_mat_from_files(result_files, tempdir_path)
File "/home/filipe/.local/lib/python3.10/site-packages/fastaai/fastaai.py", line 3288, in write_mat_from_files
fh = open(f, "r")
FileNotFoundError: [Errno 2] No such file or directory: '/tmp/tmpgi3knqay/partial_results_group_7.txt'
The matrix file is produced with only a small part of the accessions. Any idea how to fix this?

In case anyone wants this, this script converts the raw output to a phylip formatted matrix
import os
import re

# Specify the directory path where the text files are located
directory = "/path/to_result_folder/"

# Create a dictionary to store the genome names and AAI values
genome_aai_dict = {}

# List all files in the directory and sort them
files = sorted(os.listdir(directory))

# Iterate through each file
for file_name in files:
    # Check if the file is a text file
    if file_name.endswith(".txt"):
        file_path = os.path.join(directory, file_name)
        genome_name = os.path.splitext(file_name)[0]

        # Open the file for reading
        with open(file_path, "r") as file:
            # Read the lines in the file
            lines = file.readlines()

            # Extract the AAI value from the last column of each line
            aai_values = [re.sub(r'[><%]', '', line.strip().split("\t")[-1]) for line in lines[1:]]

            # Add the genome name and AAI values to the dictionary
            genome_aai_dict[genome_name] = aai_values

        print("Processed:", file_name)

# Create a new file to store the joined output
output_file_path = os.path.join(directory, "joined_output.phylip")
with open(output_file_path, "w") as output_file:
    # Write the total number of files as the first line
    output_file.write(str(len(files)) + "\n")

    # Iterate through the sorted genome names
    for genome_name in sorted(genome_aai_dict.keys()):
        # Get the corresponding AAI values from the dictionary
        aai_values = genome_aai_dict[genome_name]

        # Create a new line for each genome with the AAI values joined together
        joined_line = genome_name + "\t" + "\t".join(aai_values) + "\n"
        output_file.write(joined_line)

print("Joined output file created:", output_file_path)

I believe we have exactly the same problem,thanks~

Actually, the problem appears to be related with how the multithreading process allocate the chunks it generates. If you use the default threads  (no multithreading) it works...
Or you can parse the results of the tsv with another script, which should be way faster


Adding files for homework-3

Outputs:

Always add proper commit messages
Follow this message syntax <branch_name> : "Commit message (a bit descriptive)">
And if too many commits are there then squash them


Extend support for Raspberry Pi 5: PWM and SPI

Should be implemented using the Linux Kernel APIs.
Integrate in the GpioD plugin added in 2.5.0?

https://docs.kernel.org/driver-api/pwm.html
https://www.kernel.org/doc/html/v4.14/driver-api/spi.html

I need SPI support on Pi5 to drive an SSD1306 OLED. I ended up on this ticket when I saw Pi4J doesn't support it yet. I don't have the time to fully integrate a solution, but I did come up with a quick implementation using JNA for the native bindings that demonstrates how to talk to the Linux SPI device. I don't think it would be hard for someone to do the actual integration into Pi4J.
I assume you'd want to rewrite the JNA calls into pure JNI to match the existing pattern, but JNA can save you a good bit of custom native code. The existing LinuxFS class gives you most of what you need, but you'll have to add an ioctl call that can pass a structure and all the JNI magic to read/write the structure.
Thanks for making this library available. Hopefully this helps speed the SPI implementation for Pi5.
JnaSpiPi5.zip

Hi @mpilone
Thanks, that does look easier. Maybe you could put it in a pull request? I don't know JNA, and would really appreciate that a lot! I would then check the code and try and test it with other SPI devices.

I have not looked into that zip that was provided.
Early summer I spent sometime researching the kernel API.  The documentation for the new 6.x kernel is terrible.   After a bit of time I decided to use ioctl.   I coded up the library portion and tested I could control a neopixel LED string using ioctl.  I am in the process of debugging the new provider code I wrote so a normal testcase can use the provider and control the neopixel.
My intent with the provider is support the same interfaces and Config as the existing pigpio-spi provider.  So a user could simply change the provider used and their existing code would function. But, there are flags bits specific to pigpio provider and no longer applicable to Pi5.
I wasn't sure if the ioctl usage would be rejected as we wanted to move to the APIs.   I used JNA to connect to the 'C' library.   I created needed declarations to use JNA for the structures used by ioctl.
I have some questions to answer as far as the JNA path. Our practice of creating our own version of the kernel library code is needed as we support multiple ways for the .so to be located.  This JNA usage requires more code be duplicated.  For the moment to test I set the JNA path explicitly in the java code, I want to research setting it when we first determine where the library is located.
The code needs synchronization added, complete decoding flags config values and setting the ioctl based upon those, complete the functions
I will push this code so we have something else to use in this SPI conversation

I created a PR for my implementation. As the PR says, it introduces a dependency on JNA and I only tested the write operations for use with an OLED. Use it how you like. If you keep the JNA approach, you could do the same with gpiod and remove the custom C JNI code. Just load libgpiod.so and let JNA handle the bindings dynamically.

#391    PR involving ioctl/JNA   Intend is, between mpilone and this we  likely have much of the SPI support for Pi5

@dariuszzbyrad @eitch @FDelporte SPI.  I want to select which spi approach to complete. The PR offered by milipone uses system library. The PR i began I implemented my own library thinking it provides more isolation from changes and deprecation by the kernel.   But my approach creates a much larger code base to support. Mine also has increased JNA code although comments in milipone code implies more jna is needed in his code.  I can see that milipone also needs more investigation of using the config attributes.     Both of these use jna and not the new APIs available in later java versions.    So your thoughts. Do i do what appears to be a smaller code base to complete spi now and we refactor (rewrite) it later using new APIs or do a more elaborate implementation now and think we stay with that long term ?My thoughts is the smaller implementation so it will be an easier decision to throw it away and rewrite for the new API

@taartspi Regarding JNA vs the new FFI API in the JDK, I'd recommend using JNA for now and potentially rewriting it in the future. I have a few platforms that don't have a v21 JVM available yet and the new FFI API only became final in v21+. Obviously there's a tradeoff of pulling in the JNA dependency vs the new JVM standard API, but you might not want to tie SPI support to JVM v21+ at this point.
As for the implementation approach, I'll let you all talk that out. My approach doesn't involve much code, but as you said, I'm not sure it is complete as I only needed write support on SPI 0.0. You can see in the PR thread that someone was attempting to test it and I made a couple small fixes but there hasn't been an update for a few days.
Thanks for following up on this. -mike

From my perspective, consciously taking on technical debt is acceptable, especially when it aligns with the project's immediate goals. Implementing SPI support in a simplified version now seems like a practical choice, as it enables faster progress with adding support for SPI in Pi5

As discussed in https://github.com/Pi4J/pi4j-v2/discussions/409, we want to bump Pi4J to Java 21 so it can evolve further to the next LTS 25 and use the Foreign Memory API. This would bring Pi4J to V3.X.Y.
That being said, it would indeed be great if we still could have a good-and-small implementation in Pi4J V2.7.X.

I will pull down Mike’s implementation to test and to see if more is required to let present users easily move to it.  As his is a smaller code base it is more attractive for 2.7 as less code usually means easier maintenance.

I thought i'd ask ChatGPT what it says about SPI, and it came up with simply reading and writing to spidev. Since y'all are busy trying out things, i thought i'd post this here, and see if it works, as i didn't myself yet have time to try it out:
public class SpidevExample {

    private static final Path SPIDEV_PATH = Path.of("/dev/spidev0.0"); // Change to your SPI device

    public static void main(String[] args) {
        byte[] txBuffer = {0x01, 0x02, 0x03}; // Example data to send
        byte[] rxBuffer = new byte[txBuffer.length];

        try (var spiFile = Files.newByteChannel(SPIDEV_PATH,
                StandardOpenOption.READ, StandardOpenOption.WRITE)) {
            // Send and receive data
            spiFile.write(java.nio.ByteBuffer.wrap(txBuffer));
            java.nio.ByteBuffer rxBufferWrapper = java.nio.ByteBuffer.wrap(rxBuffer);
            spiFile.read(rxBufferWrapper);

            // Print received data
            System.out.println("Received Data:");
            for (byte b : rxBuffer) {
                System.out.printf("0x%02X ", b);
            }
            System.out.println();
        } catch (IOException e) {
            System.err.println("SPI communication failed: " + e.getMessage());
            e.printStackTrace();
        }
    }
}

It seems to easy to be true, but who knows? =)


[Select] Make the first item be selectable by default on type+hit Enter action

[x] I have searched the issues of this repository and believe that this is not a duplicate.

Expected Behavior
When start typing set the highlighted index in the dropdown to the first item and make it selectable on when Enter is pressed.
Current Behavior
While typing and having the dropdown opened with list of items hitting Enter doesn't do anything unless you arrowDown into the dropdown first

can we close this @tajo ?


chore: update to pybind11 to v2.11.1

The only seemingly relevant change was introduced in v2.11.0:

py::initialize_interpreter() using PyConfig_InitPythonConfig() instead of PyConfig_InitIsolatedConfig(), to obtain complete sys.path. #4473

This should address python virtual environment resolution issues on linux systems.
Changes

Update vendored pybind11 version to v2.11.1 (see release notes).

Testing this locally on macOS, this does not seem to solve the issues outlined in #441 and #628.


intoto: add fuzzer

Signed-off-by: AdamKorcz<EMAIL_ADDRESS>
Summary

Adds a fuzzer for CreateProposedEntry of the intoto type.
Release Note

Documentation

Codecov Report

Merging #1225 (9d7b28a) into main (d0f9242) will decrease coverage by 22.21%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             main    #1225       +/-   ##
===========================================
- Coverage   64.26%   42.04%   -22.22%
===========================================
  Files          82       74        -8
  Lines        7628     7209      -419
===========================================
- Hits         4902     3031     -1871
- Misses       2098     3870     +1772
+ Partials      628      308      -320

Flag
Coverage Δ

e2etests
?

unittests
42.04% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

 Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Animation of item prevent the geckolib animation

I use geckolib to build a gun,and everything is well when i right click air it can perform fire animation.But when i try to put the NBT to save the ammo count, i found that once you put tag,the fire animation will perform with a drop(which i think it's NBT's problem)How can I prevent that?Sorry for my poor Enghlish.

Join the Geckolib discord, and provide your code


README mentions tests but there are none.

The README.md file mentions tests in a utp_test subdirectory, but there is no such directory and no tests.
I bisected the history and found out the sub-directory was deleted in dc149387f without the README being updated.
As a matter of interest, why were the tests removed in the first place? There also seems to have been a Python binding (a pyutp sub-directory) which has also been removed. Why in the name of all that is Pythonic? :)

Is there any update regarding this question? I would also like to understand why there aren't any tests anymore.


Add logdrivers to /info

This is required for swarmkit to be able to filter based on log driver.

daemon/logger/factory.go:38:1: exported function ListDrivers should have comment or be unexported

Adding pluginv2 drivers to docker info is not necessary. Swarmkit should query docker plugin ls and look for type LogDriver for scheduling decisions. This is how its done for volumes and networks.

@anusha-ragunathan V2 drivers are not registered in the logger package, only with the plugingetter. So /info only ends up returning built-ins and v1.

LGTM

I moved this to 17.06. I assume it's not making 17.05, right ?

Yep

@cpuguy83 looks like this needs an update to the swagger file?

and API changelog

Oups. Should probably teach Gordon how to detect those :sweat_smile: :angel:


Not installable via pip (PyPi)

This is the error received when attempting to install via Pip
https://gist.github.com/mekhami/d8d2a7e774fe704d7daa
Thanks for your help.

The MANIFEST.in file is empty, which causes the VERSION file not to be included.  Please update the file and make sure all relevant files are included in the source distribution and release a new version.

I've added VERSION and README to the MANIFEST.in file

Alright please let me know when the updated version is published to PyPi.

@mekhami I'll push it up in ~ an hour! Thanks @gxela for the change.

Thanks for the quick action, folks. In case you're interested, I built this tool using your package:
https://github.com/mekhami/Sow

Actually @gxela it looks like you're the package owner. I can't upload :)

I've fixed this issue, it is now at version 1.0.3, Pypi doesn't allow to reupload the file so i had to upload it as a new version

pip install python-harvest


Some questions about inference.py

Hi, thank you for sharing your work!  I have some confusion about it.

As shown in Eq.(17) in the paper，delta_bar[n] should be equal to (delta_cond[n])* delta[n] / delta[n-1]. However, the code shows that `delta_bar[n] = (delta_cond[n])* delta[n-1]/ delta[n]'.
The code shows that audio = noisy_audio (line 148), but according to Eq. (10),   audio = alpha_cum[-1]**0.5 * noisy_signal + delta[-1] * torch.randn_like(noisy_signal).

Hope to obtain your answer, thank you!

Hi @JinY97, thank you for your interest in CDiffuSE and your comment!

The code shows that audio = noisy_audio (line 148), but according to Eq. (10), audio = alpha_cum[-1]**0.5 * noisy_signal + delta[-1] * torch.randn_like(noisy_signal).

This implementation follows the practical technique in  A Study on Speech Enhancement Based on Diffusion Probabilistic Model to start with the noisy speech signal. Also, since the alpha_cum[-1] is close to 1 and delta[-1] is close to 0, the starting signal (and the results) is similar to the ones in Eq. (10).

As shown in Eq.(17) in the paper，delta_bar[n] should be equal to (delta_cond[n])* delta[n] / delta[n-1]. However, the code shows that `delta_bar[n] = (delta_cond[n])* delta[n-1]/ delta[n]'.

I found this would be a typo in the paper, delta_bar[n] should be equal to (delta_cond[n])* delta[n-1]/ delta[n]. I will further update this in the Arxiv paper. Thanks for pointing this out!


Hide comments option

All the current features are good except it's missing an option to remove comments

actually this option exists as can be seen on this screenshot.

Yep


Cannot view output to stderr in Debug Console for Python.

VSCode Version: Code 1.5.3 (5be4091987a98e3870d89d630eb87be6d9bafd27, 2016-09-22T08:40:08.699Z)
OS Version: Linux x64 4.4.0-38-generic

Seems like this function is not provided or hard to find the option to enable it.
This is crucial to debugging Python using C++ tools like Caffe.

@DonJayamanne I believe this might be on your side?


How i can use the styles generated in my custom componentes?

i'm trayna use the colors in my componenets but don't know how i do it.

Which styles are you talking about?
Are you using shadcn/ui in your project?

just found a way. and i'ma talking about these for example:

i'ma using like this in the code:

and yes i'm using shadcn components but i have build my own components.

yes exactly just use the variables 🙌
enjoy man

thx


CU2001.SendToAzureML suddenly lost [External] tag

Hi team.
In the codeunit 2001 "Azure ML Connector" the function SendToAzureML suddenly lost [External] tag.
Maybe I missed something.
But earlier you (and me also) used this function to send requests to Azure ML.
What should we use now?

The [External] tag was indeed removed on purpose, as the function isn't safe to be called like that from extensions. However, it should have been replaced with a safe alternative, which doesn't seem to have happened! I will follow up immediately and make sure we roll out a safe function for you to call asap. Sorry about the inconvenience!

@JesperSchulz  My demo for the Directions EMEA is broken because of that :)
I solved it partly by making my app internal, but better suggest an alternative. Cos I will show how to make custom predictions, will be not very cool to show something which is not relevant

@dkatson We've got the fix ready. The SendToAzureML has been made external again. Only difference is, that the boolean parameter TrackUsage has been removed. So your code will be very valid - only adjustment will be to remove the parameter from the call... Hope the "app as internal" hack doesn't ruin too much of your demo.
We will try to backport the change for uptake in update 20 (November release). Sorry again about the inconvenience!
On a different note: I wish I could attend your session! Sounds VERY interesting. Unfortunately I'm not going to Directions EMEA this year and hence won't be able see the show. Too bad the session wasn't at Directions NA. Hope to get a chance to see it at a different occasion!

@JesperSchulz thanks! What image should i use to update my sandbox? microsoft/bcsandbox or bcinsider.azurecr.io/bcsandbox-master?
Re Directions NA. Actually I was invited as a speaker, but due to VISA period of waiting, had to cancel my session. Hope, that next year the Directions NA committee will invite me once again.
Sadly that you will not attend Directions EMEA. Maybe you will  attend NavTechDays? I also will hold a session there.

Both should do! The change just went into master and the backporting job will finish in a couple of hours (if all goes well). The change should hence very soon be in both images. You may have to wait a day or two - I'm not sure how long exactly it takes for our changes to propagate out to our Docker images...
Unfortunately, I don't think I'll be going to TechDay's this year either - for the first time in a couple of years. I'll just have to get a resumé from one of my colleagues ;-)


Update the README file

Description of feature
Update the README

[ ] Write the usage instructions
[ ] instructions for the required databases (if any)
[ ] instructions for the required containers (if any)
[ ] Create a flowchart on draw.io and connect the editable link to this issue for group development
[ ] Update the contributors

Note: This issue should not be closed. This is an ongoing issue that will required to be updated after every hackathon session

|
|

Workflow - seqqc/annotation
QC - list and describe modules for each sub-workflow and highlight one or two key parameters e.g., --assembler {skesa | spades | ...}
| - raw-reads-qc
| - taxonomy-qc
| - Assembly-qc
| - Assembly
Annotation
| - gene-prediction
| - amr
| - phage
| - plasmid
| - CRISPR
| - Pan-genome analysis

Modes - Illumina/ nanopore
QC
| - raw-reads-qc-nanopore  ; list and describe
| - Assembly-nanopore

|
|

Input -
This would include, data formats, sample sheets (links to examples), and an example figure of input data directory structure.
|
|
Figure -
Flowchart (we can use the current version for now). Update it later
|
|
Command line -
Example minimal command for running seqqc and annotation workflows with Illumina/nanopore modes where applicable
|
|
Future work / Continuous development
In addition to adding features to the current structure, List down 1/2 sub-workflows coming later in the year. e.g., variant analysis, and phylogenetic analysis.


Switch to JUnit version 5 for unit tests #4955

migrate unit tests in sdk/storage/*

Can one of the admins verify this patch?

@srnagar could you please merge this one?


OpenID Authentication

This code introduces the ability to configure OpenID as an authentication method similar to the current Google option.
The method uses passport openid-client strategy which requires session support. For session support initially, express-session was used. Although this works for initial deployment, looking into moving to connect-mongo.
The documentation is within the .env.example
Type of change
Please delete options that are not relevant.

[x] New feature (non-breaking change which adds functionality)
[x] Documentation update

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration:

Tested using Azure AD
Azure AD

Sign in to the Azure Portal
Search for and select Azure Active Directory
Select App registrations > New registration
Enter a display Name
Choose Web
Enter https://fqdn/oauth/openid/callback
Select Overview
Note of the Application (client) ID and Directory (tenant) ID
Select Authentication
Check Access tokens and ID tokens
Select Certificates & Secrets
Create a secret and note the value

Edit .env to include variables
OPENID_CLIENT_ID=From Note Above
OPENID_CLIENT_SECRET=From Note Above
OPENID_ISSUER=https://login.microsoftonline.com/(tenant id)/v2.0/
OPENID_SESSION_SECRET=Random String
OPENID_SCOPE=openid profile email
OPENID_CALLBACK_URL=/oauth/openid/callback
Test Configuration:

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules

@bsu3338 thanks for this. be advised, I rebased your branch so it's up to date with the main branch.

Going back to clean some things up and will request once it is a little cleaner

Going back to clean some things up and will request once it is a little cleaner

Take your time and thanks for working on this! It's definitely a need as it was just requested in #489

Going back to clean some things up and will request once it is a little cleaner

Yea, just to reiterate what Danny said. Its definitely a valuable contribution, so thanks for working on it.


sending/receiving notification email

Will be done in the this sprint:

send notification to specific user
receive notification to specific user

@DavidCohen55 : Define assignee & milestone

indeed...

@zvili @yossigil
I'm sorry that I didn't do this before, I thought that I already assigned myself.
and about the milestone I didn't knew the date for this, for now it will be to the end of the semester until there will be a better milestone

The milestone for the end of the semester is "Sprint 2"

@zvili the milestone was 4.7.17 because this issue isn't intent to be for this sprint, but to another sprint in the future

After discussions with @DavidCohen55 , we decided to leave "notification to all users which their parking slot will be expired" to the next sprint, because the logic of managing parking slots isn't ready yet, and we don't have enough time.

This issue was moved to TechnionYP5777/SmartParking#14

migrated to SmartParking project


[21.02] luci-app-attendedsysupgrade: support revision checks

SNAPSHOTS are not real releases and therefore the app always offers an
upgrade, even if running the latest build. To prevent that all SNAPSHOTS
now check for the running revision and if a newer one is available.
Also do a bunch of refactoring based on JavaScript I learned over the
last week.
Signed-off-by: Paul Spooren<EMAIL_ADDRESS>(cherry picked from commit f799d550b6389baee5b388eefe638ba9a690f4c5)

Oops, duplicate of https://github.com/openwrt/luci/pull/5360


Add workflow for release SNAPSHOT to sonatype OSS repository

@harawata Could you set environment variable for deploy sonatype OSS repository?

CI_DEPLOY_USERNAME
CI_DEPLOY_PASSWORD

It seems to be working.
https://oss.sonatype.org/content/repositories/snapshots/org/mybatis/spring/native/mybatis-spring-native-core/0.1.0-SNAPSHOT/

@harawata Thanks for your working!!


Make Oscar agnostic of thumbnailing solution

Oscar really shouldn't care how thumbnails are generated. It leads to trouble when integrating e.g. django CMS as they use easy-thumbnails. There's also solutions like thumbor and resrc.it better suited for handling thumbnails when using remote storages like S3.
I'm imagining a backend-agnostic oscar_thumb template tag that is easy to customise.
As far as I'm aware, the only advanced usage of the thumbnail tag is crop=centre for the gallery thumbs, which surely could be made to work somehow.
Questions remaining:

[ ] Should we drop Sorl as a required dependency? That means PIL wouldn't get installed by default, which makes the final environment lighter. But it probably doesn't provide for a good out-of-the-box experience.

@uKev Can I contact you about your djangoCMS - Oscar integration experience? If so, how?

Please do<EMAIL_ADDRESS>On Apr 22, 2015 1:37 PM, "C Reimers"<EMAIL_ADDRESS>wrote:

@uKev https://github.com/uKev Can I contact you about your djangoCMS -
Oscar integration experience? If so, how?
—
Reply to this email directly or view it on GitHub
https://github.com/django-oscar/django-oscar/issues/1408#issuecomment-95145706
.

Pinging @JostCrow because he's working on this. \o/

Looks like @JostCrow already did some implementation, but not sure if that was finished. Looking forward to see it!

Sorry for the late response. It has been a little bit busy.
I am still working on a good solution. I have indeed started on creating a solution. Feel free to give any feedback if you have some.

Any updates on this issue?, I recently had trouble because my project was already using easy_thumbnails

:+1:

I've looked over @JostCrow implementation and I think it's not a good idea to duplicate the templates. Give that there are quite a few. I was thinking a template tag that returns the thumbnail of the image and wraps both libraries and any future that wants to be used.
Allowing for a setting that will specify the THUMBNAIL_FUNCTION to be called and create and return the thumb of the image.
I will start working in this direction and I'm open to suggestions.

@Bogh any update on this? Have you seen this issue? https://github.com/mariocesar/sorl-thumbnail/issues/480

I started working on this here https://github.com/liip-forks/django-oscar/tree/agnostic-thumbnails

@sephii great job on thumbnails refactoring. Would you create a PR so we can review? Thanks!

Also, in terms of this issue it needs to rework signal receiver for thumbnails cleanup, which is also tight to sorl-thumbnails now.

Me and @samitnuk took time to revise it again and came up with next conclusions:

If we aim to make it really agnostic, we'd not provide any default thumbnail backend set by default, so that users can make a choice by themselves, even though we'd provide ready-made backends for sorl and easy-thumbnails. In this case there won't be unnecessary dependency if users decide to implement thumbnail backend by themselves or integrate something other that two listed above backends. Hence, sorl won't be in the INSTALLED_APPS by default.
We can use the same approach as uses django-haystack or Celery for pluggable backends

Install Oscar within the Sorl within the next command - pip install django-oscar[sorl] or let user install manually.
Implement backends as modules and enable only if related package imports works fine.

Your thoughts @django-oscar/developers ?

We have finally finished this functionality within the PR #2621 and it will be delivered within the Oscar 2.0.


app crash: new error "Uncaught ReferenceError: extensions is not defined"

chrome: Version 41.0.2272.12 dev (64-bit)
Bob's Linux terminal error from Chrome
[3371:3371:0204/173815:ERROR:CONSOLE(1)] "Uncaught ReferenceError: extensions is not defined", source:  (1)
Fontconfig error: Cannot load default config file
[3371:3371:0204/174532:ERROR:proxy_api.cc(145)] Cannot determine proxy mode.
[3371:3371:0204/174532:ERROR:preference_api.cc(613)] Internal error: Stored value for preference 'proxy' cannot be converted properly.

I think the main error here is

[3371:3371:0204/173815:ERROR:CONSOLE(1)] "Uncaught ReferenceError: extensions is not defined", source: (1)

This looks like a javascript problem somewhere in our code, trying to use a variable named extensions.  Unfortunately, none of the Chrome consoles appeared to show a corresponding error.

alice windows side


Warning needed when processing networks

Generating networks from only one sample causes the program to throw an error.
Need:
Design pop up explaining that the other two networks cannot be generated - rather than a default error in the terminal.

@Jmegan042 did you ever address this?

I have created an error message to let users know the network could not be generated.


Automatically switch selectors based on active-trading period

Automatically switch selectors based on the active trading period.

Pre-Market selector: "#quote-header-info > div.Pos\(r\) > div.D\(ib\) > p > span"

Post-Market selector: "#quote-header-info > div.Pos\(r\) > div > p > span"

Standard-Market selector: #quote-header-info > div.Pos\(r\) > div > div > span"

Crypto selector (24/7): "#quote-header-info > div.D\(ib\) > div > div > span"

Completed


Add semantic analysis (cycle detection, syntax error etc) to CornerParser

this was resolved by #14


bug: Maps and marker clicks on iOS 9

Type: bug
Platform: ios 9 native hybrid app
Hello,
I am directly copying/pasting a post from ionic forum (http://bit.ly/1G94nkr) as it perfectly describes the issue:

After updating my device to iOS 9, I am having problems with detecting marker click events on maps, which was working perfectly when my device was on iOS 8. The clicks are detected at first, but after some events are performed, clicks no longer fire.

I have tried both Google Maps and Leaflet. While I have not yet found a fully deterministic path to reproducing precisely at what point do the marker clicks no longer fire, I have noticed some patterns:

On Google Maps, the first 4-6 clicks are detected, and none thereafter.
On Leaflet, all clicks are detected in the first instance of the map view. When moving into another view and back into the map view, the clicks no longer fire. Usually 2 or 3 iterations of cycling out and in of the map view is needed before the clicks stop firing. Double clicks and other events are unaffected.
The map is always wrapped with data-tap-disabled="true".

Is anyone else having similar problems?

Here is another post describing the issue (http://bit.ly/1LgshYe) with a codepen available (http://codepen.io/ionic/pen/uzngt).

Hmm, are you adding data-tap-disabled="true" to the map?

Hi @mhartington, thanks for your answer.
Yes, I confirm that we are using data-tap-disabled="true" as indicated in ionic's doc.
The app works perfectly on iOS 8 and Android. Described issue occurs only on iOS 9 devices.
Please note that we are using telerik WKWebview plugin (http://bit.ly/1L8R8PU) to activate WKWebview.

We have upgraded it to its latest version but it does not solve the issue.
We also tried to remove it and use UIWebview with angular-ios9-uiwebview.patch.js but it does not solve this issue.
Thus, this plugin does not seem to cause the issue.

Finally, in addition to previous's message codepen, we have created a cordova sample app with an index.html file (http://bit.ly/1Pqvh9D) without angular and without ionic dependencies. It loads a simple GMap with some markers and displays alert when click events are triggered. In this case, issue does not occur.

I can confirm this error. It is very strange, because it works for the first clicks.
But after some random time, it stops working.

Hi, had the same problem using a leaflet-map. I found out that the error is caused by ionics 'isElementTapDisabled()' function. Its somehow gets stuck in the while loop.
I've replaced it with a small jQuery function and now everything seems to work well.
isElementTapDisabled: function(ele) {

    if (ele && ele.nodeType === 1) {
      var element = ele;

      if ($(element).parents('[data-tap-disabled]').length) {
        return true;
      }
     /*
      while (element) {
        if ((element.dataset ? element.dataset.tapDisabled : element.getAttribute('data-tap-disabled')) == 'true') {

          return true;
        }
        element = element.parentElement;
      }*/
    }
    return false;
  },

I also have the same issue. I tried the above fix by Ernst and it is working.

Hi there,
be careful with $parents()'s method from jQuery. It indeed solves the not responding markers/map issue but also breaks the scrollView (at least in my case).
I tried to dig deep around this issue last days. As mentioned by @devilop3rz, the while loop inside isElementTapDisabled is buggy on iOS9.
Problem occurs more precisely with the if condition. Indeed, after few interactions, for a reason I can't understand, the if block is not executed anymore even if its condition is evaluated to true (when data-tap-disabledattribute is detected)...

Moreover, $parents() method does not pass tests as it does not detect if data-tap-disabled attribute is present on the touched element.

I've had the same issue using and finally solved it by refactoring the if statement in the 'isElementTapDisabled' function.
if( element.getAttribute('data-tap-disabled') == 'true' || element.dataset.tapDisabled == 'true' ) {

Here's the full 'isElementTapDisabled' function:
  isElementTapDisabled: function(ele) {
    if(ele && ele.nodeType === 1) {
      var element = ele;
      while(element) {
        if( element.getAttribute('data-tap-disabled') == 'true' || element.dataset.tapDisabled == 'true' ) {
          return true;
        }
        element = element.parentElement;
      }
    }
    return false;
  },

If you're curious, here's what the original if statement was:
if( (element.dataset ? element.dataset.tapDisabled : element.getAttribute('data-tap-disabled')) == 'true' ) {

For your info, we have deployed patch #4538 on our production app and are not experiencing anymore this bug.
@mhartington can you please review eitheir PR #4538 or @mcasaje changes ?

@mcasaje It works for me, Thanks!

Can you see if the recently merged PR #4589 fixes this for you? Going to close since I believe this is a duplicate solved by that.

@mlynch.
Sure will check and let you know.

Hey this still didn't work for me on Ionic 1.2.1, so I used the patch by mcasaje and it fixed the problem for me on iOS 9.

@shamid Thanks for giving feedback on this. I did not have time yet to upgrade and check on my own if ionic 1.2.1 fixed the issue.
@mlynch Can you please review @mcasaje solution or PR #4538 and add one of them to the project ?
Thanks in advance.

@mcasaje It works for me too, Thanks!

@mlynch I can confirm PR #4589 did not fix the issue, but @mcasaje change did
can you reopen the issue?
Thanks

same problem here, on ios 9.2
with leaflet 0.7.7 and angular-leaflet-directive + ionic 1.2.4
@mcasaje patch works for me

same problem on ios 9.3
@mcasaje patch works for me
isElementTapDisabled: function(ele) {     if(ele && ele.nodeType === 1) {       var element = ele;       while(element) {         if( element.getAttribute('data-tap-disabled') == 'true' || element.dataset.tapDisabled == 'true' ) {           return true;         }         element = element.parentElement;       }     }     return false;   },

Same with me as well... the fix provided @mcasaje works fine for me as well...
Will this be available in next ionic build?

The provided fix works for me as well. This issue needs to be reopened and the provided fix should be used as the patch.

Same problem for me:

iOS 9.3.1
Telerik cordova WKWebView Polyfill Plugin 0.6.9
leaflet 0.7.7
angular-leaflet-directive 0.10.0
ionic 1.3.0

@mcasaje fix works like a charm, thank you so much!

Hi all,
sounds like this has been finally fixed for the next release ! See commit 88b37772.
Have a good day.

Hi,
Anybody knows if this fix is already available also in the MeteorJS ionic package? (https://atmospherejs.com/driftyco/ionic).
I'm experiencing this issue there, and I'm not able to update to a newer version of the package.

I still have the same issue.... the tap on the map's markers sometimes works, sometimes not.
In my app I have multiple maps (in different views). It seems that when I show another map, the tap stops working. I have this error just with cordova-plugin-wkwebview-engine, before it worked.
Unfortunately I really need the wkwebview otherwise map performance are very poor.
I should have everything up-to-date
$ ionic lib
Local Ionic version: 1.3.1  (/Users/danielefani/Sites/epoi/eppoi_app/www/lib/ionic/version.json)
Latest Ionic version: 1.3.1  (released 2016-05-12)
 * Local version up to date

$ionic info

Your system information:

Cordova CLI: 6.2.0
Gulp version:  CLI version 3.9.1
Gulp local:   Local version 3.9.1
Ionic Framework Version: 1.3.1
Ionic CLI Version: 1.7.15
Ionic App Lib Version: 0.7.2
ios-deploy version: 1.8.6
ios-sim version: 5.0.8
OS: Mac OS X El Capitan
Node Version: v5.5.0
Xcode version: Xcode 7.3 Build version 7D175

$ cordova --version
6.2.0


Dependabot could not fetch go module as organization name of the go modules changed

Is there an existing issue for this?

[X] I have searched the existing issues

Package ecosystem
gomod
Package manager version
No response
Language version
1.17
Manifest location and content before the Dependabot update
module github.com/org1/mainpkg

go 1.17

require (
	github.com/org2/pkg1 v0.0.1
	github.com/org1/pkg2 v0.0.1
	github.com/org1/pkg3 v0.0.1
)

dependabot.yml content
version: 2

updates:
  - package-ecosystem: gomod
    directory: /

    schedule:
      interval: daily

    allow:
      - dependency-name: "github.com/org1/*"
      - dependency-name: "github.com/org2/*"

Updated dependency
Dependabot should update pkg1 and pkg2 from 0.0.1 to 0.0.2, but that is not happening.
module github.com/org1/mainpkg

go 1.17

require (
	github.com/org1/pkg2 v0.0.2
	github.com/org1/pkg3 v0.0.2
)

What you expected to see, versus what you actually saw
We updated the organization name of pkg1 from org1 to org2 in github, but are still using github.com/org1/pkg1 as the module name.
Dependabot should update pkg1 from 0.0.1 to 0.0.2, but that is not happening.
Instead it's giving 404 error in
404 https://github.com:443/org1/pkg1
But doing go get github.com/org1/pkg2 works and is able to fetch the module.
These are all private modules so the names are replaced.
Native package manager behavior
go get github.com/org1/pkg2
This works and is able to update pkg2 even though the org name is changed from org1 to org2.
Images of the diff or a link to the PR, issue, or logs
proxy | 2023/12/15 13:58:42 [039] GET https://proxy.golang.org:443/github.com/org1/pkg1/@v/list
proxy | 2023/12/15 13:58:43 [039] 404 https://proxy.golang.org:443/github.com/org1/pkg1/@v/list
proxy | 2023/12/15 13:58:43 [041] GET https://github.com:443/org1/pkg1/info/refs?service=git-upload-pack
proxy | 2023/12/15 13:58:43 [041] * authenticating git server request (host: github.com)
proxy | 2023/12/15 13:58:44 [041] 404 https://github.com:443/org1/pkg1/info/refs?service=git-upload-pack
proxy | 2023/12/15 13:58:44 [041] * auth'd git request returned 404, retrying without auth
proxy | 2023/12/15 13:58:44 [041] * de-auth'd request returned 401, replacing response
proxy | 2023/12/15 13:58:44 [043] GET https://github.com:443/org1/pkg1
proxy | 2023/12/15 13:58:44 [043] * authenticating git server request (host: github.com)
proxy | 2023/12/15 13:58:44 [043] 404 https://github.com:443/org1/pkg1
proxy | 2023/12/15 13:58:44 [043] * auth'd git request returned 404, retrying without auth
proxy | 2023/12/15 13:58:44 [043] * de-auth'd request returned 404, ignoring response
proxy | 2023/12/15 13:58:44 [045] GET https://proxy.golang.org:443/github.com/org1/pkg1/@v/list
proxy | 2023/12/15 13:58:44 [045] 404 https://proxy.golang.org:443/github.com/org1/pkg1/@v/list
proxy | 2023/12/15 13:58:44 [047] GET https://github.com:443/org1/pkg1/info/refs?service=git-upload-pack
proxy | 2023/12/15 13:58:44 [047] * authenticating git server request (host: github.com)
proxy | 2023/12/15 13:58:44 [047] 404 https://github.com:443/org1/pkg1/info/refs?service=git-upload-pack
proxy | 2023/12/15 13:58:44 [047] * auth'd git request returned 404, retrying without auth
proxy | 2023/12/15 13:58:44 [047] * de-auth'd request returned 401, replacing response
proxy | 2023/12/15 13:58:44 [049] GET https://github.com:443/org1/pkg1
proxy | 2023/12/15 13:58:44 [049] * authenticating git server request (host: github.com)
proxy | 2023/12/15 13:58:44 [049] 404 https://github.com:443/org1/pkg1
proxy | 2023/12/15 13:58:44 [049] * auth'd git request returned 404, retrying without auth
proxy | 2023/12/15 13:58:45 [049] * de-auth'd request returned 404, ignoring response
updater | 2023/12/15 13:58:45 INFO <job_762772350> Handled error whilst updating github.com/org1/pkg1: git_dependencies_not_reachable {:"dependency-urls"=>["github.com/org1/pkg1"]}

Smallest manifest that reproduces the issue
No response

I recommend updating references to use org2 as it seems someone could create an org with the name of your previous org:

After changing your organization's name, your old organization name becomes available for someone else to claim.

https://docs.github.com/en/organizations/managing-organization-settings/renaming-an-organization#what-happens-when-i-change-my-organizations-name
Dependabot also runs go list -m -versions -json github.com/org1/pkg1 to get the list of available versions. It looks like that might be the command that is failing.
But based on the potential name-squatting/dependency confusion attack mentioned above I don't think we want to support this use-case.


pkgs/tools/networking/openfortivpn-webview: added openfortivpn-webview 1.2.0

Description of changes
first contribution: added openfortivpn-webview package.

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

@aos appreciate the feedback for a first-time contributor. sorry for the delay too, just life happened. hope this PR is in a better state now!

@aos , thanks again for the feedback, highly appreciated. let me know if there is anything else!

@aos , I am a bit confused. the quick start to adding a package specifically asks for package.nix. also, there is no mention of all-packages.nix for adding a new package, and the new package builds fine as is. see the output below. recent PR's also seem to point in the same direction (e.g. https://github.com/NixOS/nixpkgs/pull/319908). are you sure your latest change requests are really supposed to be there?
leon@tokachi:~/code/nixpkgs$ nix-build -A openfortivpn-webview
/nix/store/9d0ssvxi5ins6as1c1x5r81pkcgp8b5l-openfortivpn-webview-1.2.0
leon@tokachi:~/code/nixpkgs$ nix build .#openfortivpn-webview
leon@tokachi:~/code/nixpkgs$ ls -l result
lrwxrwxrwx. 1 leon leon 70 Jun 15 23:08 result -> /nix/store/9d0ssvxi5ins6as1c1x5r81pkcgp8b5l-openfortivpn-webview-1.2.0
leon@tokachi:~/code/nixpkgs$ ./result/bin/openfortivpn-webview --help
openfortivpn-webview [command]

Commands:
  openfortivpn-webview [host:port]  Connect to the given host

Options:
  --version         Show version number                                [boolean]
  --realm           The authentication realm.                           [string]
  --url             The already built SAML URL. This takes precedence over
                    [host:port].                                        [string]
  --url-regex       A regex to detect the URL that needs to be visited before
                    printing SVPNCOOKIE.
                                      [string] [default: "/sslvpn/portal\.html"]
  --keep-open       Do not close the browser automatically.
  --proxy-server    HTTP Proxy in the format hostname:port.             [string]
  --extra-ca-certs  Path to a file with extra certificates. The file should
                    consist of one or more trusted certificates in PEM format.
                                                                        [string]
  --trusted-cert    The fingerprint of a certificate to always trust, even if
                    invalid. The details of invalid certificates, fingerprint
                    included, will be dumped in the console.            [string]
  --help            Show help                                          [boolean]

if there is anything else that needs to be done to unblock this, let me know

@lriesebos I would advertise this PR here: https://discourse.nixos.org/t/prs-already-reviewed/2617 or https://discourse.nixos.org/t/prs-ready-for-review-december/1711

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-already-reviewed/2617/1865

@SuperSandro2000 I think I addressed your last concerns. let me know if there is anything else I can do!

@ofborg build openfortivpn-webview


Fixing incorrect Gc9A01 references in code doc

Description
Fixing incorrect Gc9A01 references in code doc
Motivation and Context
Fixing incorrect Gc9A01 references in code doc
Types of changes

[X] Documentation (changes or updates in the documentation, has no impact on code or features)

Checklist:

[X] I have updated the documentation accordingly (the changes require an update on the docs in this repo).

@dotnet-policy-service agree


⚠ Elibs has degraded performance

In 68447df, Elibs (https://elibs.unmer.ac.id) experienced degraded performance:

HTTP code: 200
Response time: 6328 ms

Resolved: Elibs performance has improved in 550a26f.


added ptc output option

This is a minor feature addition to allow get_pt_pk2d() to return the ptc it initialized.
@damonge : do you remember why this was its own function which takes a ptc rather than a method of the ptc itself? Was it so that the user never needs to worry about the ptc if they don't want to?

Pull Request Test Coverage Report for Build 4632

4 of 6 (66.67%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.06%) to 96.279%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

pyccl/nl_pt/power.py
4
6
66.67%

Totals

Change from base Build 4630:
-0.06%

Covered Lines:
2924

Relevant Lines:
3037

💛  - Coveralls

@damonge : any thoughts on this?

@jablazek any update on this?

@c-d-leonard, not yet. but thanks for the poke.

@damonge @c-d-leonard : this should be ready for the next round of review. I think we are waiting for the swap to github action to test the build and coverage?

yes, but this shouldn't affect how we write the tests

@jablazek I meant to say, if you can check that the new tests run, then I'd say we can still merge even if travis doesn't work.

@jablazek it seems there are still flake8 issues

thanks. should be fixed.

@damonge , we good?


note_offset and octave_offset "sticks" when changing patches

When playing a patch that has, for example, octave_offset=1 to drop the sound one octave, and then switching to any other patch that does NOT have an octave_offset (which is most patches), the one octave drop keeps being active.
It's only when playing a patch that has octave_offset=0 (or restart the plugin) that things go back to normal.
The same goes for note_offset.

Maybe check but I remember sforzando had some weird behavior with this.

No idea, but I just checked the same files with Sforzando, and it doesn't have the sticking problem now.

Even if Sforzando did exhibit this behaviour, (which apparently it doesn't) it feels more like a bug to me.


reset pointer to prevent memory corruption

The code in path_resolver.c that replaces forward slashes with
backslashes on Windows did not work. It modified a chunk of
memory immediately following the memory it was meant to update.
This was leading to crashes on Windows in the Node.js test
suite ~1-2% of the time. This commit resets the pointer to the
correct location for the calculations.
Side note: this logic was broken and the slashes weren't actually
being updated, but the tests were still passing on Windows. This
logic might not really be needed after all?
Node.js stress test (4,000 runs spread across 4 windows machines): https://ci.nodejs.org/view/Stress/job/node-stress-single-test/73/ ✔
Also resolves: https://github.com/nodejs/node/pull/33403

This is related to host paths only. WASM, AFAIK, should only be dealing in Unix style paths, and the paths here shouldn't be exposed to WASM at any point.

@addaleax do you have any preference on landing this as is vs. removing the path translation?

I'm going to land this as is since the problem seems to be resolved. If it ends up causing any problems in the future it's easy enough to remove.


Create main.yml

This work is licensed under a Creative Commons Public Domain Mark 1.0 License.

git checkout master
git merge --no-ff Tek-God-patch-1
git push origin master

From ce637c4453fe81222b7e16ed33997ad3843ee67b Mon Sep 17 00:00:00 2001
From: Tek-God<EMAIL_ADDRESS>Date: Fri, 26 Jun 2020 01:48:17 -0700
Subject: [PATCH] Create main.yml

.github/workflows/main.yml | 33 +++++++++++++++++++++++++++++++++
1 file changed, 33 insertions(+)
create mode 100644 .github/workflows/main.yml
diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
new file mode 100644
index 0000000..d6783e2
--- /dev/null
+++ b/.github/workflows/main.yml
@@ -0,0 +1,33 @@
+# This is a basic workflow to help you get started with Actions
+
+name: CI
+
+# Controls when the action will run. Triggers the workflow on push or pull request
+# events but only for the master branch
+on:

push:
branches: [ master ]
pull_request:
branches: [ master ]

+# A workflow run is made up of one or more jobs that can run sequentially or in parallel
+jobs:

This workflow contains a single job called "build"

build:

The type of runner that the job will run on

runs-on: ubuntu-latest

Steps represent a sequence of tasks that will be executed as part of the job

steps:

Checks-out your repository under $GITHUB_WORKSPACE, so your job can access it

uses: actions/checkout@v2

Runs a single command using the runners shell

name: Run a one-line script

 run: echo Hello, world!

Runs a set of commands using the runners shell

name: Run a multi-line script

 run: |

   echo Add other actions to build,

   echo test, and deploy your project.

[ ]


Fix wrong message in exact validator + remove extraneous quotes

LGTM... Apparently I don't have write access @njbotkin


MAoT Lowest points near locations, received errors 000875, 000581, and warning error 000950

Tested this with AGOL's Terrain elevation dataset and some local point data. However I'm getting an error message when I run it...
Executing: LowestPointsNearLocations imp "5 Kilometers" Terrain C:\Workspace\Test\TestForErikReid\aTarget.gdb\mfLPNL0002
Start Time: Mon Feb 23 10:23:00 2015
Executing (Buffer): Buffer imp C:\Workspace\Test\TestForErikReid\scratch.gdb\locBuffer "5 Kilometers" FULL ROUND NONE # PLANAR
Start Time: Mon Feb 23 10:23:01 2015
Succeeded at Mon Feb 23 10:23:01 2015 (Elapsed Time: 0.51 seconds)
Executing (Minimum Bounding Geometry): MinimumBoundingGeometry C:\Workspace\Test\TestForErikReid\scratch.gdb\locBuffer C:\Workspace\Test\TestForErikReid\scratch.gdb\bufferMBG RECTANGLE_BY_AREA NONE # NO_MBG_FIELDS
Start Time: Mon Feb 23 10:23:01 2015
Succeeded at Mon Feb 23 10:23:01 2015 (Elapsed Time: 0.23 seconds)
Executing (Extract by Mask): ExtractByMask Terrain C:\Workspace\Test\TestForErikReid\scratch.gdb\locBuffer "C:\Users\matt2542\Documents\Users\erik0000\Desktop\Workspace\Geospatial Data\scratch.gdb\bufferExtract"
Start Time: Mon Feb 23 10:23:01 2015
ERROR 000875: Output raster: C:\Users\matt2542\Documents\Users\erik0000\Desktop\Workspace\Geospatial Data\scratch.gdb\bufferExtract's workspace is an invalid output workspace.
ERROR 000581: Invalid parameters.
Failed to execute (Extract by Mask).
Failed at Mon Feb 23 10:23:02 2015 (Elapsed Time: 0.19 seconds)
Failed to execute (LowestPointsNearLocations).
Failed at Mon Feb 23 10:23:02 2015 (Elapsed Time: 1.73 seconds)

The path its complaining about is C:\Users\matt2542\Documents\Users\erik0000\Desktop\Workspace\Geospatial Data\scratch.gdb\bufferExtract and obviously doesn't exist. If I look at the model I can see that the output from Extract By Mask is not set to a scratch path as it should be.

Somehow it's mangling a couple of paths to make something that doesn't exist. If I change the path to the temp data to in_memory it works just fine...
Executing: LowestPointsNearLocations imp "5 Kilometers" Terrain C:\Workspace\Test\TestForErikReid\aTarget.gdb\mfLPNL0003
Start Time: Mon Feb 23 10:28:55 2015
Executing (Buffer): Buffer imp C:\Workspace\Test\TestForErikReid\scratch.gdb\locBuffer "5 Kilometers" FULL ROUND NONE # PLANAR
...
...
Dropping XCoord from C:\Workspace\Test\TestForErikReid\aTarget.gdb\mfLPNL0003...
Dropping YCoord from C:\Workspace\Test\TestForErikReid\aTarget.gdb\mfLPNL0003...
Dropping Z from C:\Workspace\Test\TestForErikReid\aTarget.gdb\mfLPNL0003...
Succeeded at Mon Feb 23 10:30:21 2015 (Elapsed Time: 0.18 seconds)
Succeeded at Mon Feb 23 10:30:22 2015 (Elapsed Time: 1 minutes 27 seconds)

I will update the repo with my changes to the model.


Add a DeFi guide

Adding a guide about DeFi, #32
Feeld free to adapt it or let met know what to change. I tried to include some developer resources but there's probably much more (-:

This is great! Thanks for writing another guide @JanetMo :100:
Left a few comments on some of the resources. I'm not too familiar in DeFi myself that I'm not sure what resources are still up to date and relevant. But otherwise, this seems great. Happy to merge :)

You're very welcome, thanks for checking 👍
I adapted the indirect links and removed the outdated ones. (-:


ContentRouteMatched event + config env values

Coverage increased (+1.2%) to 55.519% when pulling 02827ab0e8dc427a60aac9fc2b795676a5a83ce5 on gzero_config_env_values into 936107b375fa4850f12257c4367907ffba799aca on master.


Update Readme

Update name in the install helm command

[X] README.md updated with any new values or changes

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

Hi @ArthurFritz, thanks for fixing it 👍


Overloaded test methods result in InvalidOperationException

Description
We were migrating an existing project.json based xunit test project to MSBuild. One of the test classes had a overloaded method - one as a Fact with no arguments and the other a Theory with InlineData. Once migrated, the test runner fails while running one of the overloaded method.
Steps to reproduce

What steps can reproduce the defect?

<Project Sdk="Microsoft.NET.Sdk">
  <PropertyGroup>
    <OutputType>Exe</OutputType>
    <TargetFramework>netcoreapp1.0</TargetFramework>
  </PropertyGroup>
  <ItemGroup>
    <PackageReference Include="Microsoft.NET.Test.Sdk" Version="15.0.0-*" />
    <PackageReference Include="xunit.runner.visualstudio" Version="2.2.0-*" />
    <PackageReference Include="xunit" Version="2.2.0-*" />
  </ItemGroup>
</Project>

using Xunit;

namespace ConsoleApp
{
    public class Test
    {
        [Fact]
        public void TestMethod()
        {
            Assert.True(true);
        }

        [Theory]
        [InlineData(true)]
        public void TestMethod(bool value)
        {
            Assert.True(value);
        }
    }
}

Expected behavior
Overloaded tests work
Actual behavior
Starting test execution, please wait...
Error Message:
Failed   ConsoleApp.Test.TestMethod(???: True)
 System.InvalidOperationException : The test method expected 0 parameter values, but 1 parameter value was provided.

Passed   ConsoleApp.Test.TestMethod

Total tests: 2. Passed: 1. Failed: 1. Skipped: 0.

Environment

Please share additional details about the test environment.
dotnet --info:

.NET Command Line Tools (1.0.0-rc3-004522)

Product Information:
 Version:            1.0.0-rc3-004522
 Commit SHA-1 hash:  4e0b465093

Runtime Environment:
 OS Name:     Windows
 OS Version:  10.0.14393
 OS Platform: Windows
 RID:         win10-x64

Appears to be a known limitation in xunit adapter. See https://github.com/xunit/xunit/issues/1042.

Did this work in project.json world because the xunit there wasn't using the visual studio runner?

@NTaylorMullen - yeah both overloads were working with project.json.

This is xunit issue: https://github.com/xunit/xunit/issues/1042

I'm shocked; how did this work in project.json land? It used xunit as well.


Problems with win-sshfs after windows 10 creators update

Technical data
WinSshFS

[x] stable
[x] prerelease
[ ] custom build
Version: <IP_ADDRESS>
Version: <IP_ADDRESS>

Dokan driver

[x] stable
[x] prerelease
[ ] custom build
Version: Dokany 2-Beta
Version: Dokany 1.0.5
Version: Dokany 1.0.3

Enviroment

Windows version: <10> (Creators Update/Edition)
Architecture:

Support

Usage: personal
Your personal priority to solve this issue:
med

Hello
I have recently got my PC upgraded to the new Windows 10 Creators Edition/Update. After this update i can no longer get Win sshfs to work.
When the program mounts a drive it disconnects after about 20 seconds. This happens both with mounting virtual drive aswell as picking a drive letter for the mount point on windows.
I have an exact same setup on windows 10 without the creators edition/update which works perfectly. Been messing arround with different version for some hours now, with no luck. Is this a compatibility issue?
Feature update for the new windows 10 update.
https://www.howtogeek.com/306610/whats-new-in-windows-10s-fall-creators-update/
/Mads

I have found another program winfsp + sshfs-win which works for me. It is not as simple as the win-sshfs gui but it is good enough for me for now.
I will probably try and install win-sshfs again later to check if a future version works for me.

Have you tried using the latest dokany 1.0.5? There was some issue with the new Windows update.


Resources without models?

I've been looking at a problem with the Swagger import, but I don't think it's unique to this. The Resource model requires a Model, presumably returned by a http 200 response on a GET (in most cases). Do you think it is a reasonable use case to not require the Model if all the Resource operations return http 204 (unit)? I know you hate booleans, but imagine an endpoint that toggles a value. The operations might be something like this:
GET: 204 (true), 404 (false) - gets the boolean value
PUT: 204 (success), 400 (error) - sets the boolean to true
DELETE: 204 (success), 400 (error) - sets the boolean to false
All actions and responses on this endpoint can be encapsulated using HTTP verbs and response codes - no Model required. What do you think of this? I can take a stab at sprinkling Options in the relevant places, but don't have a good sense of what might break down internally through the entire project structure.

Yeah - I've run into the same a few times. The core difference is the mindset shift between exposing resources as part of rest vs. allowing arbitrary API.
I don't think it would be too hard to model some kind of magic "there is no resource" - and can see this as useful esp when coming from a swagger definition
A current workaround
hack.txt
is to create an 'empty' model and map that as the resource - e.g. just create a model that you don't use.

I'm going to put this aside for now. This would imply that Resource.type and Resource.plural both become Options - which leaves no required fields in the Resource model. There are a bunch of places where a unique reference to the Resource is required, and with no guarantee that any property would be set, it's not obvious how to identify a "name" for the Resource. Also, the UI would become polluted (something like a mix of Model names and URL paths in the sidebar). So without a clear vision of how to deal with this in the UI, it seems best to not mess with the existing format.

Example document demonstrating the use case attached
test.txt

General concern that it feels weird to have a model w/ no fields... plan to discuss w/ ryan on next cell


Fix mappings related to MathHelper.atan2

This can probably be applied to the 23w18a branch as is.
MathHelper#COSINE_TABLE is renamed to COSINE_OF_ARCSINE_TABLE to better reflect its value. SMALLEST_FRACTION_FREE_DOUBLE is renamed to ROUNDER_256THS, but I’m open to better names on that.
This PR also maps two constants and adds javadocs for atan2 and fields related to its implementation.

Will merge to 1.20 branch first.