Extension maturity checklist

While we now have explicit extensions security postures, there is no systematic way to govern how extensions are promoted from untrusted to trusted, i.e. when they are considered robust to downstream or upstream; we generally rely on Envoy maintainer intuition and burn time. We should probably have a checklist providing guidelines on how this can be done in a consistent way.
Some ideas:

Does the extension have fuzz coverage? If it's only receiving fuzzing courtesy of the generic listener/network/HTTP filter fuzzers, does it have a dedicated fuzzer for any parts of the code that would benefit?
Does the extension have unbounded internal buffering? Does it participate in flow control via watermarking as needed?
Does the extension have at least one deployment with live untrusted traffic for a period of time, N months?
Does the extension rely on dependencies that meet our extension maturity model?
Is the extension reasonable to audit by Envoy security team for obvious scary things, e.g. memcpy, does it have gnarly parsing code, etc?
Does the extension have active CODEOWNERS who are willing to vouch for the robustness of the extension?
Is the extension absent a low coverage exception?

Thoughts on any others? CC @envoyproxy/security-team

This sounds like a great initial list to me. Should we codify this somewhere in the repo and iterate?

extension reasonable to audit by Envoy security team for obvious scary things, e.g. memcpy

I, naively, wonder how much of this type of audits could be codified in linters instead of relying solely on the eyes of the sec team.

Does the extension have fuzz coverage? If it's only receiving fuzzing courtesy of the generic listener/network/HTTP filter fuzzers, does it have a dedicated fuzzer for any parts of the code that would benefit?

On that note, I'm working on a local refactor for the generic HTTP filters, so that the class framework only takes in a filter and then encodes/decodes the HTTP message, without any mock construction unless you specify it. I want to make the interface the library exposes easier for single-fuzz targets to adopt and extend. I'll be following the refactor with a dedicated ext_authz target.

@junr03 yes, good point, some of this should just be code format or CodeQL checks, but other parts are more subjective, e.g. "is this a scary parser?".


Another 'Remove obj files'

Looks like I forgot some.
BTW, what about EBOOT.PBP files ?

I think you can remove the EBOOT.PBP files and actually any file which can be regenerated from the source.


Implement recovering mechanism from network interruption

I tried to import tweets from twitter-archive.zip to my pleroma instance, but my network accidentally went down for a few seconds during posting tweets process. Then, I re-ran pleroma-bot, however, it didn't resume its process properly.
My twitter-archive has more than 20k tweets, so it will take very long time to post them all. It would be great if pleroma-bot has a feature recovering from network interruption or stop/resume mechanism for long running process.

First run

$ pleroma-bot
ℹ 2023-01-21 13:30:24,684 - pleroma_bot - INFO - config path: /home/ynakao/test/pleroma-bot/pleroma_2/config.yml
ℹ 2023-01-21 13:30:24,684 - pleroma_bot - INFO - tweets temp folder: /home/ynakao/test/pleroma-bot/pleroma_2/tweets
ℹ 2023-01-21 13:30:24,686 - pleroma_bot - INFO - ======================================
ℹ 2023-01-21 13:30:24,686 - pleroma_bot - INFO - Processing user:       pleromatest
ℹ 2023-01-21 13:30:24,686 - pleroma_bot - INFO - It seems like pleroma-bot is running for the first time for this Twitter user: nakaoyuji
ℹ 2023-01-21 13:30:28,977 - pleroma_bot - INFO - How far back should we retrieve tweets from the Twitter account?
ℹ 2023-01-21 13:30:28,977 - pleroma_bot - INFO -
Enter a date (YYYY-MM-DD):
[Leave it empty to retrieve *ALL* tweets or enter 'continue'
if you want the bot to execute as normal (checking date of
last post in the Fediverse account)]

⚠ 2023-01-21 13:30:30,690 - pleroma_bot - WARNING - Raising max_tweets to the maximum allowed value (_utils.py:599)
ℹ 2023-01-21 13:30:40,262 - pleroma_bot - INFO - tweets gathered:        23497
Processing tweets... : 100%|█████████████████████████████████████████████████████████████| 23497/23497 [09:48<00:00, 39.96it/s]
ℹ 2023-01-21 13:40:28,401 - pleroma_bot - INFO - tweets to post:         23497
Posting tweets... :   8%|█████                                                       | 1988/23497 [1:15:24<13:26:19,  2.25s/it]Warning: Zero outputs support gamma adjustment.
Posting tweets... :   9%|█████▏                                                      | 2039/23497 [1:17:25<19:09:19,  3.21s/it]✖ 2023-01-21 14:58:25,964 - pleroma_bot - ERROR - Exception occurred for user, skipping... (cli.py:717)
Traceback (most recent call last):
  File "/usr/lib/python3.10/site-packages/urllib3/connectionpool.py", line 703, in urlopen
    httplib_response = self._make_request(
  File "/usr/lib/python3.10/site-packages/urllib3/connectionpool.py", line 386, in _make_request
    self._validate_conn(conn)
  File "/usr/lib/python3.10/site-packages/urllib3/connectionpool.py", line 1042, in _validate_conn
    conn.connect()
  File "/usr/lib/python3.10/site-packages/urllib3/connection.py", line 414, in connect
    self.sock = ssl_wrap_socket(
  File "/usr/lib/python3.10/site-packages/urllib3/util/ssl_.py", line 449, in ssl_wrap_socket
    ssl_sock = _ssl_wrap_socket_impl(
  File "/usr/lib/python3.10/site-packages/urllib3/util/ssl_.py", line 493, in _ssl_wrap_socket_impl
    return ssl_context.wrap_socket(sock, server_hostname=server_hostname)
  File "/usr/lib/python3.10/ssl.py", line 513, in wrap_socket
    return self.sslsocket_class._create(
  File "/usr/lib/python3.10/ssl.py", line 1071, in _create
    self.do_handshake()
  File "/usr/lib/python3.10/ssl.py", line 1342, in do_handshake
    self._sslobj.do_handshake()
ssl.SSLZeroReturnError: TLS/SSL connection has been closed (EOF) (_ssl.c:997)

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/lib/python3.10/site-packages/requests/adapters.py", line 489, in send
    resp = conn.urlopen(
  File "/usr/lib/python3.10/site-packages/urllib3/connectionpool.py", line 787, in urlopen
    retries = retries.increment(
  File "/usr/lib/python3.10/site-packages/urllib3/util/retry.py", line 592, in increment
    raise MaxRetryError(_pool, url, error or ResponseError(cause))
urllib3.exceptions.MaxRetryError: HTTPSConnectionPool(host='pleroma.yujinakao.com', port=443): Max retries exceeded with url: /api/v1/statuses (Caused by SSLError(SSLZeroReturnError(6, 'TLS/SSL connection has been closed (EOF) (_ssl.c:997)')))

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/lib/python3.10/site-packages/pleroma_bot/cli.py", line 684, in main
    post_id = user.post(
  File "/usr/lib/python3.10/site-packages/pleroma_bot/_utils.py", line 783, in post
    post_id = self.post_pleroma(tweet, poll, sensitive, media, cw=cw)
  File "/usr/lib/python3.10/site-packages/pleroma_bot/_pleroma.py", line 363, in post_pleroma
    response = pleroma_api_request(
  File "/usr/lib/python3.10/site-packages/pleroma_bot/_pleroma.py", line 29, in pleroma_api_request
    response = requests.request(
  File "/usr/lib/python3.10/site-packages/requests/api.py", line 59, in request
    return session.request(method=method, url=url, **kwargs)
  File "/usr/lib/python3.10/site-packages/requests/sessions.py", line 587, in request
    resp = self.send(prep, **send_kwargs)
  File "/usr/lib/python3.10/site-packages/requests/sessions.py", line 701, in send
    r = adapter.send(request, **kwargs)
  File "/usr/lib/python3.10/site-packages/requests/adapters.py", line 563, in send
    raise SSLError(e, request=request)
requests.exceptions.SSLError: HTTPSConnectionPool(host='pleroma.yujinakao.com', port=443): Max retries exceeded with url: /api/v1/statuses (Caused by SSLError(SSLZeroReturnError(6, 'TLS/SSL connection has been closed (EOF) (_ssl.c:997)')))
Posting tweets... :   9%|█████▏                                                      | 2039/23497 [1:17:57<13:40:23,  2.29s/it]

Second run

$ pleroma-bot
ℹ 2023-01-21 15:02:38,043 - pleroma_bot - INFO - config path: /home/ynakao/test/pleroma-bot/pleroma_2/config.yml
ℹ 2023-01-21 15:02:38,043 - pleroma_bot - INFO - tweets temp folder: /home/ynakao/test/pleroma-bot/pleroma_2/tweets
ℹ 2023-01-21 15:02:38,045 - pleroma_bot - INFO - ======================================
ℹ 2023-01-21 15:02:38,045 - pleroma_bot - INFO - Processing user:       pleromatest
✖ 2023-01-21 15:02:53,366 - pleroma_bot - ERROR - Exception occurred for user, skipping... (cli.py:717)
Traceback (most recent call last):
  File "/usr/lib/python3.10/site-packages/pleroma_bot/cli.py", line 705, in main
    user.check_pinned(posted)
  File "/usr/lib/python3.10/site-packages/pleroma_bot/_utils.py", line 340, in check_pinned
    ).format(str(self.pinned_tweet_id)))
AttributeError: 'User' object has no attribute 'pinned_tweet_id'

config.yml

pleroma_base_url: https://pleroma.yujinakao.com
users:
- twitter_username: nakaoyuji
  pleroma_username: pleromatest
  pleroma_token: xxxxx
  archive: /path/to/twitter-archive.zip

version info
pleroma-bot: v1.2.0 installed from AUR
Pleroma: v2.5.0

Had similar (not using archives), try the version in #113 it helped reduce the timeouts for me

I agree, this would be very useful.
But the way I see it shouldn't apply only to network errors, instead it should be a feature to resume a failed run, no matter the reason.
Perhaps we can dump partial progress to disk during execution and then check at the beginning of a new run if there's partial data we can continue off of.


docs: typo and formatting mistakes fixes

Closes https://github.com/loco-rs/loco/issues/501

Thanks!


Add slack and stackoverflow icon to footer in docs

For some reason the change is not displaying in RTD

@freddyaboulton I am fairly certain this will work. Both Featuretools and Woodwork use this same exact code and it renders properly in the footer:

https://woodwork.alteryx.com/en/latest/
https://featuretools.alteryx.com/en/latest/

Looks good except that the stack overflow icon does not render:

@freddyaboulton solved:
https://github.com/alteryx/evalml/pull/3528/commits/d1a2cbecfc01a26e99658b2183138a3d1a5a7a12

Works now


[FLINK-5090] [network] Add metrics for details about inbound/outbound network queues

These metrics are optimised go go through the channels only once in order to
gather all metrics, i.e. min, max, avg and sum. Whenever a request to either
of those is made, all metrics are refreshed and cached. Requests to the other
metrics will be served from the cache. However, each value will be served only
once from the cache and a second call to retrieve the minimum, for example,
will refresh the cache for all values.
This setup may at first be a bit strange but ensures that the statistics belong
together logically and originate from a common point in time. This is not
necessarily the point in time the metric was requested though.

The metrics documentation must be update to contain the new metrics.

Right, that was missing indeed. I also found some bugs and useful extensions / inconsistencies that I fixed.

I'm wondering: is it actually useful to be able to enable/disable detailed metric stats via taskmanager.net.detailed-metrics or can we enable them always since they do not incur any overhead unless used anyways?

@zentol can you have a look again?

ok, sorry, these slipped through...
please note however, that the not-null checks in #3610 become obsolete with this PR

Will try merging this now.

Did @StephanEwen provide the initial implementation, or why is the first commit by him?

yes, that's exactly why


Add Availability Rules

Resolves https://github.com/markfisher/sk8s/issues/39 and https://github.com/markfisher/sk8s/issues/26

@dturanski can you please rebase this on the current master?

Closing- creating a new PR to merge with master


Placebo Mod spams my Console with WARN messages

Im using the mods from Tekxit 3 and some others.
Check out Latest.log and search for "placebo" . You will see it soon spamming with WARNING and a lot of Info.
I hope you can "fix" this or write some lines so i can manually turn this off in the config.
This would be very useful.
And this is my first problem post ever, for the info.
latest.log
debug.log

I'm sorry to bother, but are you certain there's no way to turn that warning off? It makes it very difficult to share my server logs with anyone because it insists on telling me that there's a "Potentially Dangerous alternative prefix rsgauges for name rustic/trapdorswitch_rustic2, expected placebo. This could be a intended override, but in most cases indicates a broken mod."
It does that for what seems to be every single item in the pack. And because my log files are so bloated, they're sometimes too big for pastebin/hastebin. Not to mention it makes it much harder to find legitimate issues hidden among the spam.

https://www.curseforge.com/minecraft/mc-mods/stuff-a-sock-in-it

Thank you for the quick response! :) Unfortunately, I haven't had any luck with that mod, nor Console Filter. Either they don't work during startup, or I'm doing the config incorrectly. I asked both mod authors for help but never heard back.
Have you got it working, by any chance?

I've never bothered to use any mod to filter logs as I am generally looking for a specific thing when I open them, and message filters are really not that useful.


add maximum minimum ops

LGTM

@piiswrong .ok remove mask

could you do a rebase (git rebase -i HEAD~10) and squash the superfluous commits?

@piiswrong  ok

merged. Thanks!


SSL/TLS certificate authentication, is it supported?

Hi,
Does this plugin support certificate-based client authentication? If so, how to use this feature or any plans to implement this?

It's supported, please read the home page of this project.

Thanks. This works.


something with the constructors parameter passing.

Performing hot reload...
Syncing files to device Android SDK built for x86...
Reloaded 1 of 469 libraries in 651ms.
════════ Exception caught by widgets library ═══════════════════════════════════════════════════════
The following assertion was thrown building MyApp(dirty, state: _MyAppState#d8d99):
A non-null String must be provided to a Text widget.
'package:flutter/src/widgets/text.dart':
Failed assertion: line 269 pos 10: 'data != null'
Either the assertion indicates an error in the framework itself, or we should provide substantially more information in this error message to help you determine and fix the underlying cause.
In either case, please report this assertion by filing a bug on GitHub:
https://github.com/flutter/flutter/issues/new?template=BUG.md
User-created ancestor of the error-causing widget was:
MaterialApp file:///C:/Users/ERROR/Desktop/Practice/alert_test/lib/main.dart:5:23
When the exception was thrown, this was the stack:
#2      new Text (package:flutter/src/widgets/text.dart:269:10)
#3      _MyAppState.build (package:alert_test/main.dart:47:25)
#4      StatefulElement.build (package:flutter/src/widgets/framework.dart:4047:27)
#5      ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:3941:15)
#6      Element.rebuild (package:flutter/src/widgets/framework.dart:3738:5)

Please ask questions like this on stackoverflow as we can't give individual support here.
The error message is pretty clear, you passed a null value to the data parameter of Text


Lua Error on NPC  Mouseover in Ardenweald

Message: Interface\AddOns\HelpMePlay\Mouseover.lua:153: attempt to index field '?' (a nil value)
Time: Sun May  1 11:57:12 2022
Count: 26
Stack: Interface\AddOns\HelpMePlay\Mouseover.lua:153: attempt to index field '?' (a nil value)
[string "=[C]"]: ?
[string "@Interface\AddOns\HelpMePlay\Mouseover.lua"]:153: in function <Interface\AddOns\HelpMePlay\Mouseover.lua:117>

Locals:

NPC: Lady of the Falls https://www.wowhead.com/npc=158345/lady-of-the-falls
PS: this happened more the once for different NPCs, but I forgot to record those details.
EDIT: HMP version 1.0.9

@eivl Please upgrade. I shifted the project from CurseForge to Wago. 1.0.9 is roughly 3 months old.
If you still have the problem on 1.1.6a, please come back and let me know. If I don't hear from you, or the issue doesn't persist, we'll close this issue.

i did not catch that, the issue is gone with the latest version 1.1.6a
I have installed the Wago app and will have it update the addon for me. :D


Compiler
Version information
675aafb
Additional context
No response

I was thinking to take an initial look, but I don't have pixels now...

This is probably a case where having a --iree-print-compilation-statistics would be enough to spot the problem without actually running anything. The flag should show information about the dispatches created, the ops per dispatch, if the ops were mapped to ukernels or not, if the ops were vectorized or note, the tile sizes used, etc., etc., etc.
I think I'll create an issue for that.

that seems like a really hard flag to implement - can you get this from existing sources we have instead? --iree-hal-dump-executable-sources-to= and co should have what you need, combined with grep you can find whether ukernels were used, etc

pass statistics would be the other route and is built-in to mlir - the ukernel conversion pass, for example, can have statistics for how many replacements it made

+1 to using pass statistics, possibly with grep or a helper script to summarize the output. There are some grep recipes here: https://github.com/openxla/iree/issues/6161#issuecomment-912635307
Some other PRs to reference:

https://github.com/openxla/iree/pull/7535
https://github.com/openxla/iree/pull/3702

I haven't thought much about the implementation. I've been using --iree-hal-dump-executable-sources-to, which has been super helpful, but only when I already knew what I was looking for. I think that + grep are not powerful enough. Sometimes I have to generate a profile and copy it to a spreadsheet and process the data there with filters, etc. Not very efficient, unfortunately.
LLVM has some pass report mechanism (from the top of my mind, rpass-something flags?) that dumps useful information about what happens during the compilation. Apple built a tool on top of it to process and summarize that information, map it to the source code, etc. Really powerful. ICC has also a good performance report along these lines. I don't think we have the resources to do something that awesome but I think we need some improvements here.
I think @qcolombet was interested in exploring this area. He may have more context about the Apple's work and LLVM side of things.
(sorry, I just realized I'm kind of hijacking the thread. Perhaps we should move this to another issue/thread?)

Just tried the first model with ukernels disabled but data tiling enabled and it's a lot faster:

name
threads
Default flags latency (ms)
DT latency (ms)
DT+UK latency (ms)

BERT_BASE_BF16_JAX_I32_SEQLEN8
1
69.1
23.5
3963.0

Here is the trace: https://storage.googleapis.com/iree-shared-files/mariewhite/profiles/bert_bf16.tracy

I can get the answer from looking at the graph myself later, but maybe you know the answer out of hand: are the matmul element types in this model bf16 * bf16 -> bf16 (so the accumulator is bf16) or bf16 * bf16 -> f32 (so the accumulator is f32) ?
I hadn't bothered to add a microkernel case for bf16 * bf16 -> bf16 because I thought that the narrow mantissa would prevent bf16 from being a useful accumulator type, but I can easily tweak the existing bf16 * bf16 -> f32 to also support that.

Just checked the IR, confirmed: while the model has a mix of bf16 and f32, the matmuls seem to be bf16 * bf16 -> bf16.
...
    %248 = stablehlo.dot_general %245, %5, contracting_dims = [2] x [0], precision = [DEFAULT, DEFAULT] : (tensor<1x8x768xbf16>, tensor<768x768xbf16>) -> tensor<1x8x768xbf16>
...
    %252 = stablehlo.dot_general %245, %7, contracting_dims = [2] x [0], precision = [DEFAULT, DEFAULT] : (tensor<1x8x768xbf16>, tensor<768x768xbf16>) -> tensor<1x8x768xbf16>
...
    %256 = stablehlo.dot_general %245, %9, contracting_dims = [2] x [0], precision = [DEFAULT, DEFAULT] : (tensor<1x8x768xbf16>, tensor<768x768xbf16>) -> tensor<1x8x768xbf16>

So this would currently cause the microkernel to fall back to slow generic code. I'll fix that to avoid causing benchmarking friction, but again, unless this comes from a real user who already knows that this is sufficiently accurate, I suspect that bf16 accumulation is going to suffer from the narrow mantissa.

https://github.com/openxla/iree/pull/15543 should fix this!

Note @mariecwhite @dcaballe : earlier draft versions of #15543 had debug logic left in that was preventing the optimized tile function from being selected. That's fixed now, but if you tested earlier and got no performance impact, that would have been the reason.

Trying to understand the situation... If the optimized function is not selected, what happens then? Are we trying to generate code for this using the selected tile sizes or are we selecting some other ukernel?

When the arch specific tile function selection returns nullptr, as it was
doing in my leftover debug helper code, that causes fallback to a slow
generic tile function. So that was not broken, just slow like before.
Anyway, that's fixed now.
Le ven. 10 nov. 2023 17 h 05, Diego Caballero @.***> a
écrit :

Trying to understand the situation... If the optimized function is not
selected, what happens then? Are we trying to generate code for this using
the selected tile sizes or are we selecting some other ukernel?
—
Reply to this email directly, view it on GitHub
https://github.com/openxla/iree/issues/15504#issuecomment-1806499361,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAATNLYPYKIPBBJICY45C6TYD2QLXAVCNFSM6AAAAAA7EBANPOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMBWGQ4TSMZWGE
.
You are receiving this because you were assigned.Message ID:
@.***>

When the arch specific tile function selection returns nullptr, as it was
doing in my leftover debug helper code, that causes fallback to a slow
generic tile function. So that was not broken, just slow like before.
Anyway, that's fixed now.

Thanks for clarifying. I'm still not sure I'm getting the full picture so let follow up with another question: beyond this bug, why are we invoking a generic but slow ukernel when a good one hasn't been found instead of just falling back to non-ukernel code generation? Is there a reason not to do that?

@dcaballe
This is a really good question! I can answer why things are the way they currently are, and why I can't see any low-hanging fruit from here. But that doesn't mean that the question isn't valid or that there isn't potentially some high-hanging fruit.
The one-line answer is that when at compile time (codegen) we would need to decide to fall back to non-ukernel, we don't have yet any information about the ukernel's internal logic, so we don't know if it's going to be a fast code path or a slow generic fallback.
There is no very easy way to fix that in a way that is 100% robust. There are different trade-offs here between "100% robust, but complex to implement" and "Has false negatives, but is lighter implementation". There are 2 possible points on the spectrum of compromises here:

In order to guarantee eliminating discrepancy between compile-time logic ("should we fall back to non-ukernel") and ukernel implementation logic ("should I fall back to a slow generic tile function"), we would need the code implementing that logic to be shared among both sides. It's not impossible to do - technically, the compiler itself could link to some ukernel code. And actually, now that I think about it, the logic that is relevant here is already isolated into separate "*_entry_point.c" files that are compiled as generic C files, not with the architecture-specific CPU feature flags that we add to the actual tile function implementations. Concretely, it's not impossible to imagine the compiler linking to https://github.com/openxla/iree/blob/main/runtime/src/iree/builtins/ukernel/arch/x86_64/mmt4d_x86_64_entry_point.c.
An imperfect but easier way to catch this is to maintain only a grid of ukernel x element_types x CPU architecture (the latter being coarse-grained e.g. just "x86_64" not going into specific CPU features). This would be simple enough to fit in a declarative way in the https://github.com/openxla/iree/blob/main/runtime/src/iree/builtins/ukernel/exported_bits.h header file that is the one piece of code that we are already today sharing between the compiler and the ukernels. It wouldn't catch fine-grained things such as "on x86_64, we support bf16 * bf16 -> bf16 only if the +avx512bf16 feature is present. But it would have caught the simpler thing that was at stake here, which was that we didn't have any t bf16 * bf16 -> bf16  at all, and it would still have caught it if it were on a per-arch basis (e.g. x86_64 vs arm64).

https://github.com/openxla/iree/pull/15543 has been merged finally :-) @mariecwhite can you retry and hopefully confirm it fixed this?

Thanks for clarifying, Benoit. This is one of the things I would like to discuss for the UK enablement

#15543 has been merged finally :-) @mariecwhite can you retry and hopefully confirm it fixed this?

This is fixed. Thank you!


Setting up Betrayal

I'm trying to set up betrayal UI and I have gotten to the point where I have to make it recognize the different board members..
It says I have to right-click and omni-key, but every time I press the Omni-key it closes everything and opens my inventory
I tried going into input setup to see what was going on, and i noticed that when I launch your autohotkey script, instead of being bound as 'middle mouse' it is now instead bound as 'Control+C'.
Any solution? :S

Is your inventory bound to the c-key? If so, you have to go to the "hotkeys" section of the script's settings menu and read the help tooltips near the top.
You can reset the omni-key by clicking into the hotkey-field and pressing backspace or the DEL-key.

I made it work, thank you :)..
Only thing i can't seem to get working yet though, is the pictures of the desired members over each "place".  will they come when i have all the names of all the different members or am I missing something ?

Do you mean this?

These pictures will be placed wherever a member has teal highlighting:

Holding the omni-key while the syndicate board is open will show this prio-view


Property to provide a list of @SuppressWarnings values

We have pretty strict maven POMs that include PMD and checkstyle. I am struggling to get those code checkers to play well with generated code (don't tell me to use /target/generated* please!).
Can we have a feature that will drop in A @SuppressWarnings annotation in the generated code? Something like:
PMD,checkstyle

You can use custom annotator

@mattbishop Are you using the latest version of jsonschema2pojo?
We have reinstated the @Generated annotation, and most static code analysis tools will ignore types that have this annotation.
If this doesn't help, I think it should be quite easy to write a custom annotator for this, as @eirnym mentioned. If you can share your code to GitHub I expect others might find it useful.

When I looked into PMD and @Generated, their philosophy is to fix the generator to pass the project's PMD rules! In my situation, this is a large, crufty Enterprise App where I don't have control over the code-checking rules, because their QA folks really want these rules to be followed. Fair enough.
I'm not sure how to get my own @SuppressWarnings handler into the plugin's class path without creating a new module to produce it? See "Enterprise App" above for my restrictions.
Another way to do this is to comment out the plugin in Maven after generation and add the @SuppressWarnings manually. Not great round-tripping, but it's what I am doing now.

It's common to keep generated sources and files that are under source control separately. In fact it's rare to generate files into a source directory that you are including in PMD runs.
Yes you would have to add a new annotator as a module. So this option is off the table too?
Is there anything that PMD is highlighting that you think we should change in the generated sources?


Issue 64

fixes #64
fixes #65
fixes #66
fixes #67

Closing due to inactivity. Feel free to reopen, but keep code in separate PRs where possible to make things easier to review.


Can not run setup.py with gcc 7?

Hi,
I got error when running the below command with gcc 7
python3 setup.py bdist_wheel
Anyone has same problem?

Would you care to share the error, please?
Thank you
Thomas

I solved it by installing and running with gcc 5.


Off topic, but please reply.

Can you provide a link to your plugin's discord server?

Sorry but I've deleted the AdvanceDeaths discord server.
My main focus nowadays is Server Hosting. (XenoHosts)
You can see more about XenoHosts here.
XenoHosts Discord Server:
https://XenoHosts.com/discord


Bug: Default transitions does not work in release builds with R8

Due to https://github.com/KaustubhPatange/navigator/blob/master/navigator-compose/navigator-compose/src/main/java/com/kpstv/navigation/compose/ComposeNavigator.kt#L139 the default transitions do not work in release build.
Harcoding a string key correctly fix the issue.

Did you try adding
-keep public class * extends com.kpstv.navigation.compose.NavigatorTransition
I was certainly sure this could be an issue so I guess I have to rather update the docs about the proguard rules or add it to consumer proguard.

That rule would keep also an unused transition for no benefits

I think serving a default proguard rule would be better rather than you explicitly specifying a new string for the transition (doesn't make that sense). I think won't add much overhead since the code is a library code. If it makes sense you can also check almost entire androidx components are excluded by proguard even if they don't require that (lol).

could tweak something with keep names

For unused transition, I think it can be only done from the client-side since the library doesn't know which transition you are using so it makes sense for you to specify them manually.

Rules are now very fine tuned even more if you do not use appcompat / material (that's the only ones keeping more because of the invocation by reflection to replace default components) + R8 is smarter than ever.

I think won't add much overhead since the code is a library code.
Every code that a library add that is not used and is left in final APK is increased dex size, oat compile time, disk space and is bad when you multiply by dozens of library.

For unused transition, I think it can be only done from the client-side since the library doesn't know which transition you are using so it makes sense for you to specify them manually.

No that the opposite, a library should not keep anything that is not used explicitly by the consumer when possible. That's why you need to fine tune the rules if you decide to embed them. Imagine that when using ExoPlayer for Music Player I add to embed 2Mb of dex of the video player part that I do not use. It's better to not embed too large rules that are very hard to revert than leaving the app devs properly configure them.
If you add -keep public class * extends com.kpstv.navigation.compose.NavigatorTransition then every transition is forced to be kept and app needs to know all of them to add some assumenosideeffects that's very bad and should not be, in that case add a note and let app consumers do the proper rules.
Depending on how things are used you need to use -keepnames and eventually -keepclassmembernames for the key thing.
See https://www.guardsquare.com/manual/configuration/usage

R8 is smarter than ever

Yeah, it is smarter thanks to AGP which automatically generate those proguard-optimized.txt during compile time since it has a whole project analysis & can know what APIs are not used by
Also, there is one thing you need to know even if you are not the default transition from the client they are still registered by the library here so R8 will never remove them which means default transition will always stay in the code even though you are not using any.
Considering this I think a consumer proguard rule could be used here instead of manually overriding key.

Again IMO, a better way would be that the default one could be overridden and not embed in the final APK.
Those are small for the moment it's still best practice, and what if you add more later, and what if any library offers new complex optional ones that will be forced by side effect of that consumer proguard rule.
A very targeted keepname may be acceptable even if far from perfect but a simple keep all that expand is IMO again a NO GO.
Rules needs to be as small as possible there's many many documentation about best practice and bad library behaviors.
Fixing your rules on the client side will be a nightmare.

Now I'm thinking, the reflection-based runtime approach may not be worth it instead (since R8 with full mode doesn't even respect the name from the bytecode) it would be good that the user needs to specify the key manually.
Although I cannot add functionality to remove the default transitions since it is used by the library internally for the various purposes (eg here). I can certainly make it explicit to specify a key for custom transition.
This change does not require any proguard optimization. Also, if I have to support any additional transition then it would in a separate add-on library (also applies to this #12 pull request for adding support to animated content transition).

Forgot to link the issue during the commit, but your requested change is applied & released as 0.1-alpha23 (will be soon indexed by maven for use).

Thanks.


Add NotAll and NotAny values to RequirementType enum

Add NotAll and NotAny values to RequirementType enum and update methods accepting RequirementType as a parameter to handle the options as follows:
NotAll - Enabled if not all the specified features are enabled (any are disabled).
NotAny - Enabled if not any of the specified features are enabled (none are enabled).
The FeatureTagHelper can be then be updated to use this instead of negate. It can also then be used in other places.

Added the NotAny and NotAll requirement types and marked the Negate property of FeatureTagHelper as obsolete and to be removed in an upcoming major release.

Released as part of v1.3.0.


feat: added support to remote files

Sound.js now checks if is RelativePath using also http and https
RNSoundModule now uses setAudioStreamType(AudioManager.STREAM_MUSIC)
to stream music
Exception now are handled differently

#134

Any chance this gets merged soon ?

@matthieugayon Let me know if it works for you, and if so we should merge it.

Ok I'll try to get back to you asap on that, most probably tomorrow

@TheGhoul21 can I ask, do you know what kind of caching would be happening here? Would Android be caching the data at all, or redownloading for each new mediaPlayer?
The reason I'm asking: I want to build "code push" feature for my app's sounds, so that I can add or update sounds without needing to push a new version to the app store. I'm working on a game, so it would be amazing if I could immediately push new levels + images + sounds.
So I was just wondering if it would be easy to add some cache controls. If not, I can just handle the requests myself and play the sounds from a local directory.

+1 for this getting merged, it's the missing link for react native audio playing

This is actually great timing. As I mentioned, I've been setting up CodePush, and switching to React Native's asset manager. So I just realized that I actually do need this, because now I get a URL during development:

"http://<IP_ADDRESS>:8081/assets/src/lib/sounds/alert.mp3?platform=android&hash=442aeb48612c0aed468b12f4e2ca01bc"

It also might be good to add "React Native Static Resources" to the feature matrix in the README, maybe with a link to that page.

I just replaced react-native-sound with TheGhoul21/react-native-sound in my cross platform app and can confirm that that Android load from network works identical to iOS.  It should probably be in the readme somewhere that the syntax to load from network is
var audio = new Sound(networkURL, null, (error) => {});

@SteffeyDev Thanks for the confirmation. I've merged it now. Great job @TheGhoul21


Generated git config does not populate user's email

Expected Behavior
contents of git/config:
[core]
repositoryformatversion = 0
filemode = false
bare = false
logallrefupdates = true
symlinks = false
ignorecase = true
[user]
email =<EMAIL_ADDRESS>name = JenniferDwinall
[remote "origin"]
fetch = +refs/heads/:refs/remotes/origin/
url =XXX
Actual Behavior
contents of git/config:
[core]
repositoryformatversion = 0
filemode = false
bare = false
logallrefupdates = true
symlinks = false
ignorecase = true
[user]
email =
name = JenniferDwinall
[remote "origin"]
fetch = +refs/heads/:refs/remotes/origin/
url =XXX
Reproduction Steps
Click "Setup Git Sync"
Click "Authenticate with GitHub"
Paste the GitHub UI from the browser and "click sync"
Click "close"
In terminal, cd to
/Users/XXX/Library/Application Support/Insomnia/version-control/git
In the latest generated directory, open git/config.  You will see the email is not populated there.
Is there an existing issue for this?

[X] I have searched the issue tracker for this problem.

Additional Information
Version: Insomnia 2023.2.2
Build date: 5/17/2023
OS: Darwin arm64 22.3.0
Electron: 22.0.0
Node: 16.17.1
V8: <IP_ADDRESS>-electron.0
Architecture: arm64
Insomnia Version
2023.2.2
What operating system are you using?
macOS
Operating System Version
Darwin FDG-GPD9QGYJQ7 22.3.0 Darwin Kernel Version 22.3.0: Mon Jan 30 20:38:37 PST 2023; root:xnu-8792.81.3~2/RELEASE_ARM64_T6000 arm64
Installation method
download from insomnia.rest
Last Known Working Insomnia version
No response

I also tried setting up Git Sync using an authentication token on github. The git config file is populated correctly there.
I created a Personal access tokens (classic), selected every scope checkbox but it did not work.  I would get 403 & 401 error codes when I tried to create a branch and push it up to origin.


Update to bootstrap 4

Bootstrap recently released beta 3 and is slated to release 4.0.0 in a few weeks without any breaking changes between the two. Now that the bootstrap 4 API is stable it would be helpful to have this package updated.

With the release of Meteor 3.0 it would be nice if this package would support BS5


fix: return promise directly from register call

This could be good change but it requires us to return non void type from method.

Closing as outdated. Feel free to create new one.


Consider adding a changelog

Hi! Thank you for this crate. I was going to update it in our dependency tree and wanted to check what the changes were. But I'm not able to find a changelog.  But having a human readable changelog is really nice. A changelog can outline caveats to not miss and other things that might not be obvious from reading just the code diff. So this is just a friendly request to have one added :)
https://keepachangelog.com/en/1.0.0/

Sure, no problem. :)
As I see this crate turning slowly into a leaner and leaner polyfill, I'm not going to bother with retro-changelog-ing to the dawn of time, or putting any sort of system in place, but it wouldn't hurt to document the major changes

Awesome! Thank you :sparkles:
Slightly related side note: May I ask why you release (what looks like) strictly additive changes as breaking releases? Between 0.6.5 and 0.7.0 you only added a macro, yet it was released as breaking (leftmost non-zero version bumped).

I don't think this matters this much for a crate with so little changes.
Since getting that CVE, I started thinking about impacting users a s little as possible, so if I can't see anyone benefiting from an update being auto-applied without Cargo.toml being changed, I'd opt to bump the minor instead of the patch.
i.e if it's not a bug fix I won't touch the patch anymore.

Which CVE? 😮 I don't see anything submitted to rustsec

https://www.cvedetails.com/cve/CVE-2019-15553/

Oh. This really should be reported to https://rustsec.org/. I'm not aware of any way to automatically check for CVEs in CI in the database you linked to, but rustsec has cargo audit


Dead link in README.md

https://expfactory.github.oi/expfactory/contribute#contribute-a-survey

URL typo.


OSS cluster inventory

Describe the solution you'd like
Create an OSS cluster inventory plugin which may (or may not) run by default in Sonobuoy. It would provide a means to get good high-level data about what makes up the cluster.
To some extent this information is in the sonobuoy queries but there are other things which may not be or may be hard to parse for users.

Have a POC for this and just needs tweaks really. A pretty small plugin so we'd like to lead with something more meaningful for a new Sonobuoy plugin. Still going to be something we do eventually I'm sure.

Closing.  This plugin has been implemented here - https://github.com/vmware-tanzu/sonobuoy-plugins/tree/master/cluster-inventory


Helm catalog can not be disabled

Rancher versions:
rancher/server or rancher/rancher: v2.0.8
rancher/agent or rancher/rancher-agent: v2.0.8
Infrastructure Stack versions:
healthcheck:
ipsec:
network-services:
scheduler:
kubernetes (if applicable): v1.11.1
Docker version: (docker version,docker info preferred)
17.3.2
Operating system and kernel: (cat /etc/os-release, uname -r preferred)
rancheros v1.0.4
Type/provider of hosts: (VirtualBox/Bare-metal/AWS/GCE/DO)
Proxmox 5.2
Setup details: (single node rancher vs. HA rancher, internal DB vs. external DB)
HA rancher from Helm Chart
Environment Template: (Cattle/Kubernetes/Swarm/Mesos)
Kubernetes
Steps to Reproduce:

Go to Global->Catalog and disable Helm Stable catalog, leave Library enabled
go to a project of any cluster and launch a new app from catalog

Results:

helm charts are still displayed in the catalog

This is should be fixed as part of rancher/rancher/issues/14322 PR (https://github.com/rancher/rancher/pull/17596).
The bug is triggered by disabling a catalog while it is updating.
We now have checks in place if the catalog is removed to stop the update process, and also find templates with are not associated with a catalog and remove them on startup.

To test this change it is best to start with Rancher server v2.1.6:

Enable the Helm catalog, while it is updating disable the catalog - repeat a few times
Verify on the catalog apps page the existence of available Helm templates even though the catalog is disabled

Upgrade to Rancher master:

CatalogTemplates and CatalogTemplateVersions not associated with a catalog will be automatically removed
Verify on the catalog apps page that Helm templates are no longer available
Enable the Helm catalog, while it is updating disable the catalog - repeat a few times
Verify on the catalog apps page that no Helm templates are available

rancher/rancher:master 2/25

Reproduced original issue
Enabled helm stable catalog, disabled while updating, enabled, disabled while updating
There were no catalog apps from the Helm repository left over


Non-strict comparison of a number to true (1 == true)

I was goofing around with JS weirdness today, and I found this behaviour, which took me some time to explain to myself. Maybe it could be included in the file?
It started off with the basic type coercion, which worked as expected:
1 == true
// true
0 == false
// true

My initial assumption was that the value is cast to Boolean. For this simple example, that assumption would hold
Boolean(1)
// true
Boolean(0)
// false

But it broke when trying the following:
1.1 == true
// false

Given my original assumption, I was a bit confused because I know Boolean(1.1) -> true.
But the true explanation to the first snippet is:
Number(true)
// 1
Number(false)
// 0

Meaning that true/false is cast to and compared as Number.

Boolean(1.1)
// true

Hum... interesting.

@markogresak could you open a PR?

Added with an explanation. Will be published soon.


[PLUGIN REQUEST] zellij-nav.nvim

Field
Description

Plugin
zellij-nav

Homepage
https://github.com/swaits/zellij-nav.nvim

Nixpkgs
false

Extra Information
The current zellij navigation plugin in Nixvim, zellij.nvim, is archived, and the creator suggests migrating to a different plugin. zellij-nav.nvim seems to be a suitable substitute.
PR to add zellij-nav.nvim to nixpkgs is in the works.

Thanks for your work upstream! That's now merged into master and will make its way to nixos-unstable shortly.
Without implying we expect you to, are you planning to tackle the nixvim PR too?

That was my thought, yes. Only seems right that I contribute to this great project which has given me so much!


Kafka scaler for multiple topics

I would like to be able to defined Kafka trigger for multiple topics.
Use-Case
Kafka consumer application can subscribe to multiple topics and process data from them.
Kafka trigger will process offset lags of a list of topics and lagThreshold will be based on an aggregation of all the lags.
Specification
triggers:
metadata:
topics:
- topic1
- topic2
...

We, internally within our company, are using keda for various scalers it provides with kafka scaler being one of them. This is a perfectly valid use case where a workload can consume events from multiple topics (eg: events sequestered based on priorities p0, p1, p2 etc). The current kafka scaler spec is modeled to work with only 1 topic and adding multiple kafka scaler triggers to scaled object wouldn't because of two reasons:

The triggers are evaluated independently, so providing separate triggers when the workload is processing events from all of them together is unintuitive. Further the user can't be expected to provide a cumulative lag_threshold for all the topics across many kafka triggers is also not reasonable.
The replica count for each trigger is capped at the number of partitions and the final target replicas will be max(trigger1, trigger2 ...) and not an aggregate of all of the resulting replica counts per trigger which is what it should be.

So the scaler spec should look like this :
- type: kafka
    metadata:
      bootstrapServers: localhost:9092
      consumerGroup: my-group
      eventSources:
      - topic: test-topic-1
        lagThreshold: "50"
     -  topic: test-topic-2
        lagThreshold: "50"

I am willing to contribute to this feature once we discuss the validity of this feature and the solution.

I can see the need for multiple kafka topics per ScaledObject. I am more inclined to implement this be specifing multiple scalers/triggers per ScaledObject rather than modifing existing Kafka scaler. We would like to support this for upcoming KEDA v2.
Multiple scalers support: https://github.com/kedacore/keda/issues/733
For the replica count, you can see this proposal: https://github.com/kedacore/keda/issues/373

I agree with @bharathguvvala spec proposal. This will eliminate configuration redundancy and hence reduce configuration mistakes. So the full spec including the authentication will look like this:
- type: kafka
    metadata:
      bootstrapServers: localhost:9092
      consumerGroup: my-group
      eventSources:
      - topic: test-topic-1
        lagThreshold: "50"
      - topic: test-topic-2
        lagThreshold: "50"
    authenticationRef:
      name: keda-trigger-auth-kafka-credential

I agree with the need for this. In my case I may need up to 20-30 topics (maybe even more) to monitor and scale deployments. As long as I don't need to create 20-30 scaled objects and can create one - that would be very helpful.

have we tried anything to address the issue?

You can define multiple triggers per ScaledObject.

nvm, I think https://keda.sh/docs/2.7/scalers/apache-kafka/ there is some example here

This will work:
....
triggers:

type: kafka
metadata:
bootstrapServers: localhost:9092
consumerGroup: my-group
topic: test-topic-1
lagThreshold: '1'
type: kafka
metadata:
bootstrapServers: localhost:9092
consumerGroup: my-group
topic: test-topic-2
lagThreshold: '1'
....
....

This will work:
....
  triggers:
  - type: kafka
    metadata:
      bootstrapServers: localhost:9092
      consumerGroup: my-group
      topic: test-topic-1
      lagThreshold: '1'
  - type: kafka
    metadata:
      bootstrapServers: localhost:9092
      consumerGroup: my-group
      topic: test-topic-2
      lagThreshold: '1'
 ....
....

This does not seems to be working on v2.10. I get below error:
Error from server (the workload 'recorder-consumer' of type 'apps/v1.Deployment' is already managed by the ScaledObject 'scaler-dev'): error when creating "k8s/dev": admission webhook "vscaledobject.kb.io" denied the request: the workload 'recorder-consumer' of type 'apps/v1.Deployment' is already managed by the ScaledObject 'scaler-dev'

@pyjads are you sure you defined the triggers on the same ScaledObject?


MINOR: Bump system test version from 2.2.0 to 2.2.1

More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.
Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

This PR is blocked by #6597 -- will run system tests after merged and this PR is rebased (opened this PR early for tracking purpose).
\cc @hachikuji @rhauch Do we need to update anything for core or connect?

@mjsax it looks like you didn't update the vagrant file.

Updated vagrant file.

Triggered system tests: https://jenkins.confluent.io/job/system-test-kafka-branch-builder/2739/

Java11 passed. Java8 build not available any longer. System test passed.
Retest this please.
Call for review @guozhangwang @bbejeck @vvcephei @ableegoldman @cadonna

Rebased this to resolve merge conflicts.
Retriggered system tests: https://jenkins.confluent.io/job/system-test-kafka-branch-builder/2795/
Call for review @guozhangwang @bbejeck

system test failed due to environmental issues, kicked off another one https://jenkins.confluent.io/job/system-test-kafka-branch-builder/2796/

java 11 scala 2.13 failed with
org.apache.kafka.connect.integration.ConnectWorkerIntegrationTest.testAddAndRemoveWorker
org.apache.kafka.connect.integration.ExampleConnectIntegrationTest.testSourceConnector

java 8, java 11 scala 2.12 passed
retest this please

All 3 builds failed -- test result are not available any longer.
Retest this please.

Rebased to latest trunk (hope this makes the test more stable). Also triggered system tests: minor-add-221-to-system-tests

All three runs failed -- results are not available any longer. Retest this please.

Java 11/2.12 time out Java 11 Scala/2.13  and Java 8 passed
retest this please

Previous system test results are not available any longer. Retriggered: https://jenkins.confluent.io/job/system-test-kafka-branch-builder/2844/
Java 8 passed. Retest this please.

Jenkins passed. System test failed (forgot to delete one line in a setup script for system test...)

Retriggered system tests: https://jenkins.confluent.io/job/system-test-kafka-branch-builder/2845/

System test failed for test including 0.10.1 and 0.10.0 versions. I believe it because of the issue fixe via https://github.com/apache/kafka/pull/7118/
Rebased to get the fix into this PR. Retriggeres system tests: https://jenkins.confluent.io/job/system-test-kafka-branch-builder/2846/

Unrelated system test failures for test kafkatest.tests.client.quota_test.QuotaTest.test_quota with error Jmx tool took too long to start.
Re-triggered: https://jenkins.confluent.io/job/system-test-kafka-branch-builder/2851/

@ijuma Seems like QuotaTest is broken atm. Can we merge this PR without getting a green system test build? Or do we need to wait for a fix for QuotaTest ?

Java 11 / 2.12 passed. Test results for others not available any longer. I would just merge as-is if there are no objections.


Opening other dialogs than the ones stuck on the side

If we open more dialogs than the ones in the list of buttons_expand, let them open next to the side bar, not inside the side bar.

fixed in the above


NC | NSFS | Versioning | Suspended Mode | Optimization of System Calls

Explain the changes

Find the cases where we can use fewer system calls, for example:

unlink instead of safe_unlink: safe_unlink under the hood is rename, stat, and in case of error also link (in fs_napi.cpp see SafeUnlink).
rename instead of safe_move: safe_move under the hood is safe_link and safe_unlink (in native_fs_utils.js see safe_move.

The cases that were changed:

In _move_to_dest_version with suspended mode with latest version null - no need for safe_unlink, in any way the last version will be saved as a null version, therefore we will use unlink (decided to use unlink_ignore_enoent in case of concurrent calls that might lead to unlink in one process (before added the new version) and then context switch to a second process that also tries to unlink the same null version).
In _move_to_dest_version with suspended mode with latest version null - no need for safe_move, rename should be enough,  in any way the last version will be saved as a null version, and rename is atomic (will end up with either the old or the new version and nothing else).
In _delete_latest_version with suspended mode and the version id is null - no need for safe_unlink using unlink instead (as mentioned in point 1).
In _delete_null_version_from_versions_directory we want to remove the null version from .versions/ directory, no need for safe_unlink and use unlink instead (as mentioned in point 1). Since we didn't use the safe_unlink and this function is only used in suspended mode we could remove additional code lines that were related to the arguments of safe_unlink.

Issues:

This was a gap mentioned in suspended mode PRs, for example in #7311 in this comment.

Testing Instructions:
Unit tests:

Please run: sudo NC_CORETEST=true node ./node_modules/mocha/bin/mocha ./src/test/unit_tests/test_bucketspace_versioning.js

Note: These changes have not been tested on a GPFS machine yet.

[ ] Doc added/updated
[ ] Tests added

I am closing this PR due to changes in priorities.
The current thought is to add these changes with bucket cache changes (to avoid one process with suspended mode while the bucket configuration changed to Enabled and, a second process operates on the bucket and during its operation).


docs(azure): fixed the privilege escalation policy.

the deleted part did not work as azure only allows 1x wildcard (*) and as it would only check "any" role the removal has no other negative impact

Should this also get a note that operators can only activate this policy after they've set up all the permissions for the SPNs?


not working under debian 10

Hello,
I tryid this app and it was awesome under ubuntu 18.04. I also installed it under debian 10( with gnome 3) . The installation went without error message. The app isntalled, whenever I click on it, it is starting. According to the terminal the strechly is already running, but it is not showing up in the upper bar of the the desktop as it did under ubuntu. What shall I do?

Hi @nor500 , do you have the same desktop environments in ubuntu and debian? It might be missing some package under debian.
I have Debian Sid with XFCE. I also have these packages installed: libappindicator1, libappindicator3

I have debian 10 with gnome 3. I checked those libappindicator1, it exist. However the other package is missing: E: Unable to locate package libappindicator3 How can I install that?

I have found that, the correct name: libappindicator3-1. Though stretchly is not working.

@nor500 not sure ;/ I do not use Gnome so not sure how to proceed
do you have any other electron-based app that also have tray icon? do they work? I know for example skype is electron based nowadays

Sorry. In the meantime it started working. Great software. Congratulation! I have one suggestion for you  if you can can put the remaining time always visible on the tray it would be even better.

Thanks :)
Stretchly has a tray tooltip, but unfortunatelly it's not working under Linux.
It used to work, but not anymore :/ bug in electron


Restaurants-Self-Order - Week - 2

📝 Weekly Report For TNB Projects
Basic Details
🧪 Name of the Project: Restaurants-Self-Order
📅 Report Date: [02-26-2021]
📜 Team Work Report
✅ Accomplishments this week

We have done a full team meeting, and discussed on the staff portal functionalities and some design enhancements
The work on item modal has started

🚩 Goals for next week

Will host the Staff portal FE on Heroku and integrate with BE
Continue work on Staff portal
Continue work on Mobile app design

🔭 Long term goals

Finish both Staff portal and vendor portal FE & BE
Finish the mobile app customer view & vendor view

❗❓ Concerns
i really need the extra resource "Architect/Senior developer" because, with the current backend structure that we have, we might encounter some issues in the coming modals, which might lead to re-work again.
👨💻👩💻 Team Members Contribution Details
yaya-BL: 550dc478995e24cd3760a7cded7fb1208156d044ecf9aac89907594f70c42f75

We on-boarded a QA guy to write us some documentations and do some analysis, but he didn't continue with us
Wrote some requirements for the staff portal, but still not done
Discussed with some people to fill the Architect/Senior position, with no hope
Follow up with teammates on the progress

SazidAhmed with dhakal0kushal: 8c09ddf540339b6abc98382f4b21bc217172b7cd99dfe1663605d39a20d4111b

Recoded the item related models with the final requirements
Api has been created for shop, branch registration from Staff portal
Category, menu, menuCategory, Item Category model have been coded
access permission has been implemented for menu and category
CORS for Api has been enabled
Api of Country list has been done for partner registration
Menu has been linked with category
Customization Group has been added for Item add_ones
In models Image fields have been updated with URLField
https://github.com/Restaurants-Self-Order/Backend

emlex007 : bd354b73bb6000f1e9d88fcaa057505ddfdca5c9db2b9dd46e23a939a8dba11c

All previous corrections
Menu Tab redesign
All Restaurant and cafe Page
Inside Menu Page
View cart page
Cart  summary page
https://www.figma.com/file/edsNhzpjFn09dtO5AYQ5L8/food_new_version?node-id=0%3A1

skybrandevs : 8abae8ce57524c2507baad612e969314febb3794d242c41c588ccad1e5acc334

All previous corrections
Notifications page
Notifications details view
Faq page
Faq detail view
Menu Tab redesign
Notification page top bar illustration
https://www.figma.com/file/edsNhzpjFn09dtO5AYQ5L8/food_new_version?node-id=0%3A1

femoxmed : be43c9bc1fcf409b9e5cee45ffaaa528669d371aaa863857e0f77835ffdf920f

Template has been cleaned it up for use
Login Page and Sign Up page has implemented
Auth Guard for Admin Pages has been implemented
Application list has been done
Partners List is done
Create partners view is done
https://github.com/Restaurants-Self-Order/Staff-portal

approved


Question regarding license_expression_parser behavior

src/spdx_tools/spdx/parser/jsonlikedict/license_expression_parser.py uses License().parse(expr) directly, rather than get_spdx_licensing().parse(expr) as used in parser/tagvalue/parser.py.  The difference results in a different LicenseSymbol for GPl-2.0, e.g.
>>> from license_expression import Licensing
>>> Licensing().parse('GPL-2.0')
LicenseSymbol('GPL-2.0', is_exception=False)

>>> from license_expression import get_spdx_licensing
>>> get_spdx_licensing().parse('GPL-2.0')
LicenseSymbol('GPL-2.0-only', aliases=('GPL-2.0', 'GPL 2.0', 'LicenseRef-GPL-2.0'), is_exception=False)
>>>

As you can see, GPL-2.0-only is the official name, and GPL-2.0 is an alias.  However, when parsing directly with Licensing(), we get a GPL-2.0 node, rather than a GPL-2.0-only node.  This causes problem later in validation, when GPL-2.0 comes back as an invalid symbol, e.g.
2024-06-18 16:28:31,476:WARNING:root: Unrecognized license reference: GPL-2.0. license_expression must only use IDs from the license list or extracted licensing info, but is: GPL-2.0
2024-06-18 16:28:31,476:WARNING:root: ValidationContext(spdx_id=None, parent_id='SPDXRef-base-files-Package-base-files', element_type=<SpdxElementType.LICENSE_EXPRESSION: 1>, full_element=LicenseSymbol('GPL-2.0', is_exception=False))

I'm wondering if this is expected behavior (and you do not with to allow aliases), or if this is a bug.  Should I filter my json file in advance to switch to GPL-2.0-only ?  Certainly GPL-2.0 should not be listed in the extracted_licensing_info section (as that would require changing it to LicenseRef-GPL-2.0 or similar), right?

This is just one example.  Validating spdx json files generated from OpenEmbedded project yields numerous errors where aliases were used for licensing, versus the "official" node license text.  In addition to GPL-2.0, there is GPL-3.0 and LGPL-2.1+.  Again, this results in incorrect validation errors.
>>> from license_expression import get_spdx_licensing
>>> get_spdx_licensing().parse('LGPL-2.1+')
LicenseSymbol('LGPL-2.1-or-later', aliases=('LGPL-2.1+',), is_exception=False)
>>> get_spdx_licensing().parse('GPL-3.0')
LicenseSymbol('GPL-3.0-only', aliases=('GPL-3.0', 'LicenseRef-gpl-3.0'), is_exception=False)
>>>

>>> from license_expression import Licensing
>>> Licensing().parse('LGPL-2.1+')
LicenseSymbol('LGPL-2.1+', is_exception=False)
>>> Licensing().parse('GPL-3.0')
LicenseSymbol('GPL-3.0', is_exception=False)
>>>

2024-06-20 11:33:51,315:WARNING:root: Unrecognized license reference: LGPL-2.1+. license_expression must only use IDs from the license list or extracted licensing info, but is: LGPL-2.1+

I'm wondering if this is expected behavior (and you do not with to allow aliases), or if this is a bug.

I'm curious too. My own naive thought is that it would be nice if the validation processing accepted aliases :) That seems reasonable and consistent with the purpose of using aliases. But perhaps that creates bug or corner cases that I am not aware of?


Required runtime dependency 'recompose' not listed in dependencies

Describe the bug
You get a runtime error that recompose/compose cannot be resolved.
To Reproduce
Steps to reproduce the behavior:

Install minimal setup: CRA and RA, then install this module
npm start

Environment (please complete the following information):

OS: MacOS
Browser N/A - error is in webpack
Version 1.0.0

Fixed runtime dependency issue with recompose due to [BC Break] removal of its dependency in react-admin >=3.8.0 with release 1.0.2. Closing this issue.
cc: @cubabit


Intrinsic  parameter results on kitti

Hello I am working on reproducing learning intrinsic parameters. However I get  the following intrinsic parameters when training on the KITTI dataset.
What fy is much smaller than fx. What could be the problem?
[[240.6517,   0.0000, 202.4231,   0.0000],
[  0.0000,  83.6410,  66.7789,   0.0000],
[  0.0000,   0.0000,   1.0000,   0.0000],
[  0.0000,   0.0000,   0.0000,   1.0000]],

@bolianchen

have you solved this problem?


Revert "add verify prod and refactor terraform check/deploy (#197)"

This reverts commit 8de460401902bbd879b3f0bdab6550820d1630b7.

Error: Can't find 'action.yml', 'action.yaml' or 'Dockerfile' under '/home/runner/work/app/app/.github/workflows/.terraform.yaml'. Did you forget to run actions/checkout before running your local action?

cc @cpanato

sorry for the delay


How to use --url-arg

Hi everybody,
I saw about this project and it's really cool, but I have a little question about the url argument ( --url-arg) option
How to use it? I don't understand, can any of you give me an example?
I plan to use it to run several commands, for example if I enter the url http://localhost:7681/?run=script1. Then bash script1 will be executed, and so on.
Thank you in advance

https://github.com/tsl0922/ttyd/issues/171#issuecomment-594311238

Thank you for the answer, now I can execute script1 if I use http://localhost:7681/?arg=script1
I have another question, what if I want to change ?arg to something else?
For example, I want to change it to ?run
So it would be http://localhost:7681/?run=script1


Iterate image handling

https://trello.com/c/8D48qG5D/280-minor-iterations-for-lead-image-workflow
This makes several changes to the way we deal with images:

Adding more specs to cover API interactions (cfee9ae, b431d4e, eeac1be, b594223, ddf2655, ec015e8, 1f7f806)
Invert the contextual redirect behaviour to use a more explicit 'wizard' param (66291c4)
Change the edit metadata button to "Save details" (in edit context) (66291c4)
List the lead image first in the list of images (81e980c)

Part of the aim here is to separate the handling of generic images and lead images, which made the individual endpoints simpler and also helped me to understand where we had coverage issues. It also supports a future refactoring to separate the code for generic image handling.

@kevindew I think I've addressed your specific comments. I'm not sure what to do about the API down specs - each has a custom behaviour and therefore it's own unique pattern of setup and UI checks. Could you clarify what you mean by 'granular', as I think that would imply having even more of them? For me the API down cases are just another route through the workflow, so I feel OK about testing them as features. Perhaps we could add a pain card to sort this out - one suggestion could be to merge groups of specs as multiple scenarios, so they can all change together.

@benthorner cool thanks.
Re granular, I was thinking on tests like this: https://github.com/alphagov/content-publisher/blob/9d6c187869e3aa7f79ff916d3ceb8c84de003d84/spec/features/editing_images/edit_image_crop_publishing_api_down_spec.rb we could start later in the flow (like directly at the crop point) to maybe be testing more specifically just the api down flow. But thinking this through it wouldn't actually remove much from the test. I'm probably just caught up on the lines of code each one is.
Multiple scenarios could be good for error cases when there's a high percentage of steps duplicated


Whats the best way to render this content on the template?

So, sorry for open an issue on this simple question.
Right now im using this model:
content = SanitizedProseEditorField()

And i render in django template like this:
{{obj.content | safe}}

Is this the right way to display the content?
Thank in advance.

Yes, that's the way I do when rendering the content in a template.


docs: add a SECURITY.md file

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#10  👈
#9
#8
#7
#6
next

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @AliSajid and the rest of your teammates on  Graphite

Merge activity

Nov 9, 3:49 PM EST: A user started a stack merge that includes this pull request via Graphite.


Determine VT-x support on Darwin and Win platforms

On Darwin, machdep.cpu.features from sysctl -a output should contain VMX string
On Windows we need to query CPUID and look for vmx code as well

Use cpuid command. EAX should be 1. ECX & 0x05 should not be 0.

Done for osx.


sanitize media filenames

Fixes WB-NNNN
Fixes #NNNN
Description
What does the PR do?
Testing
How was this PR tested?
Checklist

Name PR "[WB-NNNN][WB-MMMM] Add support for..." similar to entries in CHANGELOG.md
Include reference to internal ticket "Fixes WB-NNNN" (and github issue "Fixes #NNNN" if applicable)

Obsoleted by 0514f2d37aa9d33ff8f1084b546376f41fc95086


STT0051:  Code Cleanup for Improved Maintainability and Performance

Description
The task involves performing a thorough cleanup of the codebase to enhance readability, maintainability, and overall performance. This process will include organizing the code structure, removing unused and redundant code, simplifying complex functions, and ensuring that the code follows best practices for readability and performance.
The repo thats need cleaning are:

stt split audio
stt combine dataset
stt-wav2vec2

Completion Criteria

Organized Directory Structure: Files and directories should be logically organized and follow a consistent naming convention.
Removal of Unused Code: All unused imports, variables, functions, and classes should be identified and removed.
Refactored Code: Complex functions should be broken down into simpler, more manageable pieces, with redundant code eliminated.
Improved Readability: Variable, function, and class names should be meaningful and self-explanatory. Comments and documentation should be clear and helpful, focusing on the "why" behind the code.
Code Review: The cleaned-up code should be peer-reviewed to ensure it meets all criteria and follows best practices.

Implementation

Backup and Preparation:
Ensure the current codebase is backed up using version control (e.g., Git).
Define the scope of the cleanup and identify key areas to focus on.

Organize Code:
Review the directory structure and reorganize files into logical groups.
Rename files and directories for consistency.

Remove Unused Code:
Use static analysis tools like vulture to identify and remove unused code.
Remove unnecessary imports with tools like isort.

Refactor and Simplify:
Break down large functions into smaller, single-responsibility functions.
Eliminate redundant code by creating helper functions or utility classes.

Improve Readability:
Ensure consistent formatting using tools like black.
Rename variables and functions to be more descriptive.
Add or update comments and documentation, focusing on explaining complex logic.

Optimize Performance:
Profile the code using tools like cProfile.
Optimize loops and data structures for better performance.

Test and Validate:
Run all existing tests to ensure functionality is maintained.
Write new tests to cover any refactored code.
Integrate the code with a continuous integration tool to automate testing.

Code Review and Finalization:
Submit the cleaned-up code for peer review.
Address any feedback and make final adjustments.
Commit and push the changes to the version control system.

Subtask

[ ] Clean the Split Audio Repo

Backup and Preparation:

[x] Ensure the current code is committed to the main branch.
[x] Create a new branch (e.g., cleanup/split-audio) for cleanup work.

Organize Code:

[x] Review the directory structure for logic and consistency.
[x] Move utility functions to a utils directory, if not already done.
[x] Rename files and directories for consistency.

Remove Unused Code:

[x] Use vulture or similar tools to identify unused functions, classes, and imports.
[x] Remove identified unused code after verifying its redundancy.
[x] Clean up unused imports using isort and format them for consistency.

Refactor and Simplify:

[x] Break down any complex functions into smaller, modular functions.
[ ] Identify and remove any redundant or duplicate code by consolidating similar functionality into shared functions.

Improve Readability:

[ ] Use black to ensure code formatting consistency.
[ ] Rename variables and functions to be more descriptive and self-explanatory.
[ ] Add comments to explain the purpose and functionality of complex code blocks.
[ ] Update the README and any existing documentation to reflect the cleaned-up code.

Optimize Performance:

[ ] Profile the code using cProfile or similar tools to identify performance bottlenecks.
[ ] Optimize any identified inefficient loops or data structures.

Test and Validate:

[ ] Run existing tests to verify that the refactored code still works as expected.
[ ] Write new unit tests for any newly refactored or added code.
[ ] Ensure all tests pass before proceeding.

Code Review and Finalization:

[ ] Submit the cleanup branch for peer review.
[ ] Address any feedback received during the review process.
[ ] Once approved, merge the cleanup branch into the main branch.

[ ] Clean the STT Combine Dataset Repo

Backup and Preparation:

[ ] Ensure all changes are committed and create a backup branch.
[ ] Start a new branch (e.g., cleanup/combine-datasets).

Organize Code:

[ ] Reorganize directories to logically group related files.
[ ] Move dataset combination logic into a dedicated datasets or combiner module, if appropriate.
[ ] Standardize naming conventions across files and directories.

Remove Unused Code:

[ ] Use vulture to identify and remove dead code.
[ ] Clean up any remaining unnecessary imports using isort.

Refactor and Simplify:

[ ] Decompose large functions, particularly those handling dataset merging, into smaller, more manageable pieces.
[ ] Consolidate repeated code into helper functions or utility classes.

Improve Readability:

[ ] Ensure consistent formatting using black.
[ ] Rename ambiguous variables and functions.
[ ] Add detailed comments, especially around the logic for combining datasets.
[ ] Update README and other documentation to reflect changes.

Optimize Performance:

[ ] Use cProfile to identify performance issues.
[ ] Optimize dataset processing and merging steps.

Test and Validate:

[ ] Run and validate existing tests.
[ ] Write tests for refactored functions, particularly for different dataset merging scenarios.
[ ] Validate dataset output integrity after cleanup.

Code Review and Finalization:

[ ] Submit the cleanup branch for review.
[ ] Address review feedback and finalize the cleanup.
[ ] Merge changes into the main branch.

[ ] Clean the Wav2Vec2 Repo

Backup and Preparation:

[ ] Commit all existing changes and create a backup branch.
[ ] Start a new cleanup branch (e.g., cleanup/wav2vec2).

Organize Code:

[ ] Review and reorganize the directory structure, separating training, evaluation, and utility scripts.
[ ] Standardize file and directory names for clarity.

Remove Unused Code:

[ ] Run vulture to detect and remove unused code.
[ ] Clean up imports using isort.

Refactor and Simplify:

[ ] Break down complex training and evaluation scripts into more modular components.
[ ] Consolidate common code, like data loading and preprocessing, into reusable functions.

Improve Readability:

[ ] Format code consistently using black.
[ ] Rename variables, functions, and classes for clarity.
[ ] Add detailed comments, especially around training and evaluation logic.
[ ] Update README, training instructions, and documentation to reflect refactored code.

Optimize Performance:

[ ] Use cProfile to identify bottlenecks in the training pipeline.
[ ] Optimize data loading, model training loops, and evaluation processes.

Test and Validate:

[ ] Run existing tests and training scripts to ensure they work correctly.
[ ] Add tests for any newly refactored functions.
[ ] Verify that model training and evaluation outputs are consistent with previous results.

Code Review and Finalization:

[ ] Submit the cleanup branch for review.
[ ] Implement any suggested changes from the review.
[ ] Merge the cleaned-up branch into the main branch.

conversion on notebook to python file

Final Directory Structure:


Add number shards by node

Description
https://github.com/Aiven-Open/prometheus-exporter-plugin-for-opensearch/issues/189
Following the issue opened by arob1n, I made some modifications to the source code to add the metric that gives the number of shard per node. I've named the metric nodes_shards_number.

[x] All my commits include DCO.DCO stands for Developer Certificate of Origin and it is your declaration that your contribution is correctly attributed and licensed. Please read more about how to attach DCO to your commits here (spoiler alert: in most cases it is as simple as using -s option when doing git commit).Please be aware that commits without DCO will cause failure of PR CI workflow and can not be merged.

Hi @lukas-vlcek,
Thank you for your response. I really appreciate your feedback and guidance.
I wanted to mention that I am relatively new to Elasticsearch and development in general, so I may not have a deep understanding of all the intricacies yet. However, I am eager to learn and improve.
Regarding the corrections I plan to make, I based my implementation on the API GET /_cat/shards, which provides the different states(types) of a shard:
(Default) State of the shard. Returned values are:

**INITIALIZING**: The shard is recovering from a peer shard or gateway.
**RELOCATING**: The shard is relocating.
**STARTED**: The shard has started.
**UNASSIGNED**: The shard is not assigned to any node.

I will follow your example for the cluster and implement the same approach for each node.
However, I have a question regarding the inclusion of the "unassigned" state. As far as I understand, a shard in the "unassigned" state is not assigned to any node, unlike the cluster level where there can be unassigned shards. Therefore, I am unsure about the need to include the "unassigned" state for each node, as nodes do not typically contain shards with the "unassigned" state.
If you could provide further clarification on why I should include the "unassigned" state for each node, I would greatly appreciate it.
Thank you once again for your support.
Best regards, Rajae

Would you consider exposing the currently configured cluster.max_shards_per_node?
This would allow for a dead simple alert when you're nearing the limit and not require an update to your monitoring if you change the max_shards_per_node.
Other than parsing the metric, it should be almost free to store in any vector database as it's essentially static.

@Baarsgaard Makes sense!

"nodes do not typically contain shard the unassigned state"
Is the exact reason I would include unassigned shards as well, simply because it's atypical and I would therefore like it exposed.

Any status on this, I would love to be able to have per node shard monitoring / tracking as I move away from ElasticSearch

Okey, let's make some progress with this over the next week. 💪

Any movement on this, this is a key monitoring feature we are currently missing.

I unfortunately an unable to assist with Java coding and it looks like @Rajaeelfarsi might be a little busy at the moment and unable to complete this PR. Is anyone able to pick up where he left off ? This feature will be key to some more robust monitoring

Would it be possible to accept as is and maybe open feature request for other missing metrics ?
IMHO this interesting contrib should not be blocked because it did not fulfil all new idea which appear


Updates for Java 11 enablement

Added configurations for migrating the service to java 11
-Updated build script.
-Updated unit test annotation.
-Updated system requirements in README.
Signed-off-by: Darshini Parikh<EMAIL_ADDRESS>

Duplicate Pull request


GET /curated

All items has the same publication_date no mater how many items are loaded.

Sorry I missed this issue. Turns out that value is hardcoded currently :) So for now the value is useless and can be ignored. I will create an internal task to fix it.

Thanks.

Date should be correct now.


Swapchain refactoring.

Use common initialization for vk/dx/headless swapchain.
Use common cleanup for vk/dx/headless swapchain.
Add ability to run a seperate framebuffer on top of a real swapchain.
Add ability to move imgui render to seperate command buffer.

Mark as draft since I'm still need to verified XR builds.

This is not the right direction to evolve the swapchain design. We need to move towards a path that make sit easier to evolve XR and non-XR independently. There is also a bunch of changes to idioms that are common to swapchains in general that make it confusing. It seems like the majority of these concepts belong in an app layer that sits over BigWheels.
The swapchain implementations need to keep simple without being convoluted by mixing app level idioms.

This is not the right direction to evolve the swapchain design. We need to move towards a path that make sit easier to evolve XR and non-XR independently. There is also a bunch of changes to idioms that are common to swapchains in general that make it confusing. It seems like the majority of these concepts belong in an app layer that sits over BigWheels.
The swapchain implementations need to keep simple without being convoluted by mixing app level idioms.

So making app not directly using swapchain? (e.g. https://github.com/hysw/bigwheels/commit/3931f6c8dbd7a3a002b3a062c9663127f50293dd ) Otherwise I don't see a way to insert command after present call.

This is not the right direction to evolve the swapchain design. We need to move towards a path that make sit easier to evolve XR and non-XR independently. There is also a bunch of changes to idioms that are common to swapchains in general that make it confusing. It seems like the majority of these concepts belong in an app layer that sits over BigWheels.
The swapchain implementations need to keep simple without being convoluted by mixing app level idioms.

So making app not directly using swapchain? (e.g. hysw@3931f6c ) Otherwise I don't see a way to insert command after present call.

You can keep all of that at an app layer above BigWheels and customize the swapchain implementation by derivation. I don't want the swapchain interface in BW to deviate away from the APIs.

Rebased and only kept whatever is still relevent, so marked comments as resolved as they no longer applies.


setExtensionView: not compatible with Autolayout

I'd love to use TLYShyNavBar, but it doesn't seem to support extension views when auto layout is enabled. TLYShyViewController.updateYOffset is using self.view.center = ... to move the view which very quickly gets overridden by the auto layout engine. Another project mentioned on your project page, https://github.com/andreamazz/AMScrollingNavbar, seems to have a solution for this using [self followScrollView:self.scrollView usingTopConstraint:self.topLayoutConstraint];. Would it be possible to add a similar solution to this project?

Thanks for your feedback @jhurliman, and sorry for the late reply.
I'd really love to keep this project as simple as possible, while making sure that the few features it provides actually work properly.
I'd really suggest using custom collection view layouts or similar for any setup that is more complicated than the current one.
I'll keep this issue open for future reference, and for possible solutions that may come up without increasing the complexity.

Any fixes yet?

I really need a solution. :o)

@Mazyod i'm running into similar issue. i have buttons in the tool bar and now i can't click those buttons since it's using autolayout

also voting for a similar solution, even just a selector i.e updateYOffset: so that I can update my own constraints.
i.e I have a subview which I do not wish to hide like the extension view, but still wish to lock to the bottom of the navigation bar.

I'll try to look into this

This is still an issue in latest version. Any update on when Autolayout will be supported?

@Errortype520 really sorry about that, I haven't looked into this yet. I'll give it higher priority and try to get to it sooner, but can't promise any dates atm.

Hi, @Mazyod
First of all, thanks for and awesome idea for implementing such kind of things.
I've managed to throw in autolayout in your project and it works well, the only problem i have is properly calculating offset for multiple extension views. If you are interested in my method or willing to help me out, please PM me so we can discuss this.
Thanks.
Here is my implementation.
Hide Nav Bar Delegate.zip

@DmitrijMaz Hey, sure I am interesting in assisting you in coming with a solution, but it's really difficult to collaborate with zip files. How about forking the repo, making changes, and I'll chip in over there?

Any updates? I've got the same issue. After profiling I found that constraint-updating was hogging the main thread.

+1 same issue with autolayout

I also need autolayout support. But even without autolayout, how do you resize extension view's width?? Running your example project and rotating the view controller just leaves the extension view with the portrait width.

@Mazyod any updates about autolayout support? Is it project active and supported yet? There are so many open issues and old code...

@markst I have similar problem. Not sure, is it still actual for you, but just in case, you can look at my PR for such functionality https://github.com/telly/TLYShyNavBar/pull/163


Remove disabled shapes from physics 2D calculations

Disabling a shape removes it from physics calculations. Enabling a shape adds it back to the physics calculations.
This speeds up the physics system (tested with example project from #17099 ) and prevents disabled shapes from being detected by raycasts ( see #17015 ).
Fixes #17015 and speeds up #17099

Cherry-picked for 3.0.7.


[subset] unittest & .notdef advance width fix

@behdad looks good?

Thanks Miguel!
I like the way you organised the unit tests for the subset module. I don't know the cffLib very well, but by looking at the test output you seem to achieve what you intended (i.e. keeping the width of .notdef when stripping its outline).
So the patch looks good to me.

:thumbsup:
Yeah, the CFF  table is tricky. For example, this line may suggest that the glyph has no advance width as there's no value preceding endchar, but that's because the glyph's advance width matches defaultWidthX so the value is omitted.

Thanks Miguel!


test using phpunit-v9

tests are failing

Closing as this should be fixed by merging 1.x from #350 into master: #360


Large SQL files skipped without error on supabase db reset

Bug report
Describe the bug
My database should contain geographical data for Sweden. This data is inserted using 327 INSERT statements and the SQL file takes up ~4MB. When I attempt to run this file (using supabase db reset) as part of either my migrations (supabase/migrations/*.sql) or my initial seed (supabase/seed.sql)  some data is skipped over and the reset operation is reported as a success.
To Reproduce
Steps to reproduce the behavior, please provide code snippets or a repository:

Place the provided SQL file in supabase/migrations/
Run supabase db reset
Go to studio -> locations table

Expected behavior

locations table should contain 327 records - the full SQL file should be executed.

Screenshots
In this case, the actual count was 206 records:

System information

Host OS: Ubuntu 20.04.4 LTS (focal) (64-bit)
Devcontainer OS: Debian 11 (bullseye)
Docker (Running on host): 20.10.17, build 100c701
Version of supabase cli (running in devcontainer): 1.4.8

CONTAINER ID   IMAGE                                                   COMMAND                  CREATED             STATUS                       PORTS                                                                                NAMES
0c91c366d071   public.ecr.aws/t3w2s2c9/studio:v0.1.0                   "docker-entrypoint.s…"   About an hour ago   Up About an hour             <IP_ADDRESS>:54323->3000/tcp, :::54323->3000/tcp                                                                                supabase_studio_portal
ed3f8ddddef6   public.ecr.aws/t3w2s2c9/postgres-meta:v0.45.0           "docker-entrypoint.s…"   About an hour ago   Up About an hour             8080/tcp                                                                                supabase_pg_meta_portal
0c37d35fc865   public.ecr.aws/t3w2s2c9/pgadmin-schema-diff:cli-0.0.5   "sleep infinity"         About an hour ago   Up About an hour                                                                                supabase_differ_portal
122778e9a4e2   public.ecr.aws/t3w2s2c9/storage-api:v0.20.1             "docker-entrypoint.s…"   About an hour ago   Up 12 minutes                5000/tcp                                                                                supabase_storage_portal
ac4cede65018   public.ecr.aws/t3w2s2c9/postgrest:v<IP_ADDRESS>20717       "/bin/postgrest"         About an hour ago   Up About an hour             3000/tcp                                                                                supabase_rest_portal
5aa101a262b9   public.ecr.aws/t3w2s2c9/realtime:v0.22.7                "./prod/rel/realtime…"   About an hour ago   Up About an hour                                                                                supabase_realtime_portal
f39c4983b1a6   public.ecr.aws/t3w2s2c9/inbucket:3.0.3                  "/start-inbucket.sh …"   About an hour ago   Up About an hour (healthy)   <IP_ADDRESS>:54326->1100/tcp, :::54326->1100/tcp, <IP_ADDRESS>:54325->2500/tcp, :::54325->2500/tcp, <IP_ADDRESS>:54324->9000/tcp, :::54324->9000/tcp   supabase_inbucket_portal
eb7abd449c05   public.ecr.aws/t3w2s2c9/gotrue:v2.15.3                  "gotrue"                 About an hour ago   Up About an hour                                                                                supabase_auth_portal
b89c961806e0   public.ecr.aws/t3w2s2c9/kong:2.8.1                      "sh -c 'cat <<'EOF' …"   About an hour ago   Up About an hour (healthy)   8001/tcp, 8443-8444/tcp, <IP_ADDRESS>:54321->8000/tcp, :::54321->8000/tcp                                                                    supabase_kong_portal
3dd717f7c160   public.ecr.aws/t3w2s2c9/postgres:<IP_ADDRESS>              "docker-entrypoint.s…"   About an hour ago   Up 12 minutes (healthy)      <IP_ADDRESS>:54322->5432/tcp, :::54322->5432/tcp                                                                                supabase_db_portal
a29675cb4712   vsc-portal-6c69f167f61ae88009bdb1b8b95be08c-uid         "/bin/sh -c 'echo Co…"   About an hour ago   Up About an hour                                                                                optimistic_matsumoto

Additional info

When using a single file for all INSERTs, I'm consistently getting 206 records inserted.
When I split the INSERT statements into multiple files, the number of inserted records changes.
By using one file per INSERT, I am able to have all 327 records inserted (though this is a very messy workaround).

Debugging this right now. First find of significance:
parser.Split(sql) returns 210 results here (4 create/etc. + 327 inserts expected):
https://github.com/supabase/cli/blob/5dd3234bcaebb8dee3e04efeed52985dd48996b5/internal/db/diff/migra.go#L131

And the issue appears to be that scanner.Err() is not checked here:
https://github.com/supabase/cli/blob/5dd3234bcaebb8dee3e04efeed52985dd48996b5/internal/utils/parser/token.go#L70-L79
By adding a print to the end:
for scanner.Scan() {
  token := scanner.Text()
    stats = append(stats, token)
}
fmt.Println(scanner.Err())
return stats

I get the following output:
$ cd ./cli && go build && cd ../ && ./cli/cli db reset
Resetting database...
Initialising schema...
Applying migration<PHONE_NUMBER>4143_locations.sql...
bufio.Scanner: token too long
210
bufio.Scanner: token too long
Seeding data...
<nil>
Activating branch...
Finished supabase db reset on branch main.

Following up from documentation:

Programs that need more control over error handling or large tokens, or must run sequential scans on a reader, should use bufio.Reader instead.

https://pkg.go.dev/bufio#Scanner


GHC redundant constraints

As discussed on gitter
there are more warnings (flags) than included in -Wall.
See also GHC webpage
See also this reddit issue
One such warning (flag) is -Wredundant-constraints.

[x] behave (src\Subst.hs)
[x] valexpr (src\Id.hs, src\FreeMonoidX.hs, test\FreeMonoidXSpec.hs)

ValExpr solved in #693

Behave solved in #699


fix(storage): skip TSM files with block read errors

When we find a bad TSM file during compaction, propagate the error up and move
the bad file aside. The engine will disregard the file so the next compaction
will not hit the same error.
Backport of https://github.com/influxdata/influxdb/pull/15885

@dgnorton does this need a separate ticket too?

@tmgordeeva here’s the back port issue https://github.com/influxdata/influxdb/issues/15814


Should [tabplayer~] compensate for sample rate difference?

I had assumed that [tabplayer~] operating with a rate factor = 1 would play at the sound file's normal speed, regardless of the system's sample rate.
But I was just testing with a 44.1 kHz file, and my built-in soundcard can only run 48 kHz. The file was audibly slightly fast (high).
[cyclone/play~] behaves this way... which is understandable because it's based on Pd arrays, which don't retain the sample rate as a property. Even though Max/MSP [play~] does automatically handle sample rate, the use of Pd arrays makes it impossible for [cyclone/play~].
But [else/sample~] does know the sample rate. [tabplayer~] seems to be ignoring that property...? Is that the expected behavior?

Hi, I can try to fix this for both cyclone and else, but it does seem challenging for cyclone... and I didn't know of this issue (we should at least document the different behaviour from MAX)

BTW I have a cyclone-based workaround at http://github.com/jamshark70/hjh-abs ([monofile] with [sf-play~], or [stereofile] with [sf-play2~]).

Having a look at the object, I see this

So I guess I thought about this and this is how I resolved things. Isn't it good enough?


Alfsteel mana cost misleading

There is very little telling you that the alfsteel cost is 2 mana pools. This cost me 1.8 mana pools because the items despawned. FIX THIS NOW.
How:
Change the default 1x scale to .5x scale on that page, showing that the terasteel is 1/4th the cost of alfsteel
Change "much more mana" to "4x as much mana"
add a second bar to each page on that section, showing the terrasteel to only have half of one bar, whereas alfsteel fills up both bars.
The fact I had to find this out by wasting 1.8 pools of mana means you really should have had other botania players look at it, and watched them try to figure it out. I'm sure many of them would have tried to make alfsteel with only 1 mana pool, especially since you gated the gaia fights behind alfsteel, pushing it from "around the time you'd fight gaia" to strictly "before you fight gaia". If anything I have said is untrue, especially if it fixes addresses the main issue at hand, please find a way to slap the people who amalgamated the Direwolf 20 modpack, as that is where I encountered this.

This is a duplicate of #28. If you want to contribute to the issue, please comment there.

FIX THIS NOW.

 So it is my decision what I fix and what not. And I don't like people who come here and tell me in a rude way that I have to fix something because clearly I don't have to fix something.
So please mind your language and write something like I'd appreciate if you could fix this. Thanks

How:
...

As said above, its my decision what I do with the mod. You can make suggestions and/or requests. So it would be better if you wrote my suggestions for this problem would be.

you really should have had other botania players look at it, and watched them try to figure it out. I'm sure many of them would have tried to make alfsteel with only 1 mana pool

I have watched many videos about this mod that are available on youtube and I know that it has been a little bit unclear. But all I have seen is that people hav tried to make their first alfsteel with two pools and then could not instantly create the second. So they did not lose any mana. And even if they did: It is a game and you should be thankful that people create mods for you to play with instead of telling the mod authors what they have to do.
Also I want to point out that in the latest version it is pretty clear, what the mana cost are:

It clearly reads 0.25x Zoom when hovered.


Remove duplicate maven version

It's defined in the parent POM already via https://github.com/assertj/assertj/blob/55356a5254e9a50881301bbfaaa32f1a23d1dc2d/assertj-parent/pom.xml#L236-L238

Thanks, @Bananeweizen. Good catch!


add slides for PEARC22 conference

@Xiangs18 i have added the slides including the PDF copy the links shouldn't change hopefully but if we want to make any last minute changes we should do it by Friday at latest.

I take that back so uploading new document to drive will update the link. I had a correction on the date its July 11th and not 10th.

Hi @shahzebsiddiqui, I fixed some typos and formatting in slide 7 and 17. Also, I left a comment on slide 8. Other slides look okay to me.