Caret is not visible at the first position when a text field is scrollable horizontally

Steps to Reproduce

Platform: Web + Canvaskit renderer

Execute flutter run on the code sample
Focus the text field
Put caret at the very first position

Expected results: Caret is visible
Actual results: Caret is not visible at the beginning of a scrollable text field
https://user-images.githubusercontent.com/13119003/146353983-340f477f-4371-4bc1-accd-6adc06c7a3e6.mp4

Code sample

import 'package:flutter/material.dart';

void main() {
  runApp(MyApp());
}

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      home: Scaffold(
        body: MyWidget(),
      ),
    );
  }
}

class MyWidget extends StatefulWidget {
  @override
  State<MyWidget> createState() => _MyWidgetState();
}

class _MyWidgetState extends State<MyWidget> {
  final _controller = TextEditingController(text: "Some very long text");

  @override
  void dispose() {
    super.dispose();
    this._controller.dispose();
  }

  @override
  Widget build(BuildContext context) {
    return Center(
      child: SizedBox(
        width: 80,
        child: TextField(controller: this._controller),
      ),
    );
  }
}

Logs

[✓] Flutter (Channel stable, 2.8.0, on macOS 12.0.1 21A559 darwin-x64, locale en-GB)
    • Flutter version 2.8.0 at /Users/krasnov/sdk/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision cf44000065 (8 days ago), 2021-12-08 14:06:50 -0800
    • Engine revision 40a99c5951
    • Dart version 2.15.0

[!] Android toolchain - develop for Android devices (Android SDK version 30.0.0)
    • Android SDK at /Users/krasnov/Library/Android/sdk
    ✗ cmdline-tools component is missing
      Run `path/to/sdkmanager --install "cmdline-tools;latest"`
      See https://developer.android.com/studio/command-line for more details.
    ✗ Android license status unknown.
      Run `flutter doctor --android-licenses` to accept the SDK licenses.
      See https://flutter.dev/docs/get-started/install/macos#android-setup for more details.

[✓] Xcode - develop for iOS and macOS (Xcode 13.2)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • CocoaPods version 1.11.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2020.3)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.10+0-b96-7281165)

[✓] VS Code (version 1.56.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.22.0

[✓] Connected device (2 available)
    • macOS (desktop) • macos  • darwin-x64     • macOS 12.0.1 21A559 darwin-x64
    • Chrome (web)    • chrome • web-javascript • Google Chrome 96.0.4664.110

! Doctor found issues in 1 category.

Hi @vs-krasnov, Thanks for filing the issue. I am able to reproduce the issue. When moving the cursor to the beginning either the cursor width is getting thin or the cursor is getting off the textfield (still visible). This only happens when the text is longer than the text field width (text gets scrollable). As I can see in other native mac applications the cursor is supposed to have a constant width.
https://user-images.githubusercontent.com/31410839/146383460-d5cc1380-c3e8-48a2-b166-4d6337cf7601.mov

code sample
import 'package:flutter/material.dart';

void main() {
  runApp(MyApp());
}

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      home: Scaffold(
        body: MyWidget(),
      ),
    );
  }
}

class MyWidget extends StatefulWidget {
  @override
  State<MyWidget> createState() => _MyWidgetState();
}

class _MyWidgetState extends State<MyWidget> {
  final _controller = TextEditingController(text: "Some very long text");

  @override
  void dispose() {
_controller.dispose();
    super.dispose();
  }

  @override
  Widget build(BuildContext context) {
    return Center(
      child: Column(
        mainAxisAlignment: MainAxisAlignment.center,
        children: [
          SizedBox(
            width: 80,
            child: TextField(controller: this._controller),
          ),
            const SizedBox(
              width: 80,
              child: TextField()),
        ],
      ),
    );
  }
}

flutter doctor -v
[✓] Flutter (Channel master, 2.9.0-1.0.pre.93, on macOS 12.0.1 21A559 darwin-arm, locale en-GB)
    • Flutter version 2.9.0-1.0.pre.93 at /Users/mahesh/Documents/flutter_master
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 1be7f1ea56 (35 hours ago), 2021-12-14 22:14:07 -0500
    • Engine revision e444009bf4
    • Dart version 2.16.0 (build 2.16.0-109.0.dev)
    • DevTools version 2.9.1

[✓] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
    • Android SDK at /Users/mahesh/Library/Android/sdk
    • Platform android-31, build-tools 31.0.0
    • ANDROID_HOME = /Users/mahesh/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.8+10-b944.6916264)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 13.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • CocoaPods version 1.10.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.8+10-b944.6916264)

[✓] IntelliJ IDEA Community Edition (version 2021.2.1)
    • IntelliJ at /Applications/IntelliJ IDEA CE.app
    • Flutter plugin version 60.1.4
    • Dart plugin version 212.5080.8

[✓] VS Code (version 1.61.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.29.0

[✓] Connected device (3 available)
    • Redmi K20 Pro (mobile) • <IP_ADDRESS>:5555 • android-arm64  • Android 11 (API 30)
    • macOS (desktop)        • macos            • darwin-arm64   • macOS 12.0.1 21A559 darwin-arm
    • Chrome (web)           • chrome           • web-javascript • Google Chrome 96.0.4664.110

• No issues found!

[✓] Flutter (Channel stable, 2.8.0, on macOS 12.0.1 21A559 darwin-arm, locale en-GB)
    • Flutter version 2.8.0 at /Users/mahesh/Documents/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision cf44000065 (8 days ago), 2021-12-08 14:06:50 -0800
    • Engine revision 40a99c5951
    • Dart version 2.15.0

[✓] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
    • Android SDK at /Users/mahesh/Library/Android/sdk
    • Platform android-31, build-tools 31.0.0
    • ANDROID_HOME = /Users/mahesh/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.8+10-b944.6916264)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 13.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • CocoaPods version 1.10.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.8+10-b944.6916264)

[✓] IntelliJ IDEA Community Edition (version 2021.2.1)
    • IntelliJ at /Applications/IntelliJ IDEA CE.app
    • Flutter plugin version 60.1.4
    • Dart plugin version 212.5080.8

[✓] VS Code (version 1.61.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.29.0

[✓] Connected device (3 available)
    • Redmi K20 Pro (mobile) • <IP_ADDRESS>:5555 • android-arm64  • Android 11 (API 30)
    • macOS (desktop)        • macos            • darwin-arm64   • macOS 12.0.1 21A559 darwin-arm
    • Chrome (web)           • chrome           • web-javascript • Google Chrome 96.0.4664.110

• No issues found!

cc: @justinmc

cc: @justinmc

Thanks for checking it out!
Wanna add a web-related tag since it occurs there too (as we can see from my post)?


Notification refactors - Ready for review

Issue
Not tracked, but this coincidentally addresses the bug in:
https://github.com/CDCgov/prime-central/issues/80
About
Lots of small things:

notifications are no longer in redux. This cleans out a lot of code
using React Toastify
see behavior below

1. Notifications are global and survive page changes.

2. Clicking on a notification closes it (otherwise it closes in 4 seconds on its own)

3. Only one notification can be displayed at a time. New notifications force out the existing ones (if there are any)

Actually, i'm not sure if this is complete.
Since notifications are now a top-level thing in redux, adding a notification on another page would simply grab the existing notification and render that. It might need to be keyed by page

Hmm, i think this is a sub-optimal design. Perhaps notifications shouldn't go in redux
In general, a user action should trigger a notification. Ie: adding/removing from a queue -> show notification.
Right now, if a component renders while a notification is in redux, the notification shows, even if the user didn't make an action on the page.

Probably going to try out: https://fkhadra.github.io/react-toastify/introduction instead of rolling our own.

It works! I think this solution is much better, but I'm having trouble doing the merge conflicts. Maybe after a nap it'll work

@benwarfield-usds i think i managed to merge in your aoe work without breaking things, but there were a lot of conflicts. Mind doing a once over to make sure it works as expected?
The only issue I'm seeing is the "Submit Anyway" button needs to be clicked twice to actually do the submission, but that is a problem on main too so it could be fixed in another PR.

Yeah, more precisely the dialog box needs to be clicked to give it focus, then the button to actually activate it. Were all of this code not both urgently needed for user testing and on the bubble for rewriting, I would have spent some time trying to fix that, but it seemed like the wrong investment last night.

I like the interactions! All the behaviors you listed out look good. Only thing I'm seeing is that I had added a green outline around the entire alert, to help it stand out more (light green on light gray blends in a bit). Looks like that CSS got eliminated along w/ my css animation.  Should be outline: 2px solid #00a91c;

@hmyers-cms
Nice catch. I fixed it, but the outline pixels aren't quite perfect. Probably good enough for now:

The notification library i used had its own out-of-the-box animations, so I used one of them. I liked yours better though, but didn't go into creating a custom one. If you feel it necessary, you can create custom ones:
https://fkhadra.github.io/react-toastify/custom-transition/

I'm going to go ahead and merge this before there are more conflicts.


skip the cases when MCO was customized installation

Signed-off-by: hchenxa<EMAIL_ADDRESS>

/assign @clyang82

/retest

/lgtm


[now-cli] Use bundled yarn to run yarn bin and skip if npx is used

Use bundled yarn to run yarn bin
Skip yarn bin if npx is used

Let's change this to:

if npm, npx <command>
if yarn, yarn <command>
fallback: <command>


more riscv tests (lb & lbu)

I can't comment on the tests, more interested in where you got them from and whether you had to modify them

I did change the tests in this PR to use direct data references instead of unsafe offsets, which is an assumption we make in the linker.

I think the point of using official RISCV tests is that they must run as is, so we can be considered a valid RISCV implementation.
Without your changes the tests can't run?

That's where we diverge, I'm not sure that's our goal, more so than just testing the opcodes. We could aim at doing that in the future.
If I use the original tests they dont work, because our linker is too simple, and @chriseth wanted to keep it like this for now.


[UPDATE GUIDE] Update Electrum server (versioning)

What
Updating Electrum server  guide to v0.10.0
Why
New version available (release notes)
How

Review/update guide.
Included additional section for upgrading to bookworm (so that cargo source is updated as required)

Scope

[ ] significant change to core configuration
[ ] independent bonus guide
[x] simple bug fix

Fixes #1305
Test & maintenance
Tested by upgrading.
Note to reviewers: Please take extra care during this review and provide any feedback necessary, particularly around the upgrade from debian 11 (bullseye) to 12 (bookworm).
Update identified via GitLurker https://www.gitlurker.info/

@luksocculta and @keyser-soeze I would really appreciate your feedback/review of the proposed updates. If you have any suggestions/comments or you feel that I've missed anything critical please let me know. I based these updates in large part on your discussion for issue #1305, thanks for that.
In regards to the ots breaking I did test this on my side and found that ots worked as normal after the upgrades so I've left that out of the guide. If you feel strongly about adding this please make a proposal for code changes.
Finally, I did run into a minor issue with regards to the system overview breaking for both RTL and the Block Explorer. I will investigate these later this evening, it looks like RTL is working fine so for some reason it just isn't pulling through correctly to the overview. The Block Explorer is having some other issues so I'll dive into that one first.

During my upgrade there wasn't need to manually install 'libnginx-mod-stream'. It upgraded automatically.
And you can add info about do not overwriting existing settings. If you overwrite for example 'sshd' settings you can be cut out from ssh connection and you will be forced to connecting external monitor to your Raspberry and it could be problematic.

Thanks, will make sure to highlight the issues with sshd and take a look at removing the libnginx-mod-stream bit too if it is non-essential.
Just working on getting my block explorer online, it seems to be having issues with connecting to the node. Not liking the old cookie authentication for some reason.

@kristapsk  @twofaktor what's your thoughts on the debian upgrade part? last time I checked, RaspiOS image is still based on Debian 11.

@kristapsk @twofaktor what's your thoughts on the debian upgrade part? last time I checked, RaspiOS image is still based on Debian 11.

I don't use Raspbian myself, my RaspiBolt is running on different hardware with Ubuntu 20.04 LTS (focal). We should avoid adding stuff that depends on a specific Debian versions if possible.

I don't use Raspbian myself, my RaspiBolt is running on different hardware with Ubuntu 20.04 LTS (focal). We should avoid adding stuff that depends on a specific Debian versions if possible.

So we should postpone electrs v0.10.0 update until RaspiOS has officially upgraded the base OS?

I don't use Raspbian myself, my RaspiBolt is running on different hardware with Ubuntu 20.04 LTS (focal). We should avoid adding stuff that depends on a specific Debian versions if possible.

So we should postpone electrs v0.10.0 update until RaspiOS has officially upgraded the base OS?

Did grep through while guide, there is another place that updates /etc/apt.sources.list (actually /etc/apt/sources.list.d/..., that is a better way) and are specific tor Debian version and that is privacy guide. So, if this is added here, that needs to be changed too.

@kristapsk @twofaktor what's your thoughts on the debian upgrade part? last time I checked, RaspiOS image is still based on Debian 11.

I use Dynamic Linking and Rustup instead of Static linking and cargo using apt, on MiniBolt (Ubuntu Server 22.4). Also, I install librocksdb from the source to get v7.8.3. I think this is the best solution also to the current RaspiBolt (Debian 11)
Ref: https://v2.minibolt.info/bonus-guides/bitcoin/electrs

This PR could continue now, when we update: https://github.com/raspibolt/raspibolt/issues/1382

I used these instructions to update to Debian 12 and they worked OK. I added the command sudo apt autoremove which may have contributed to the following applications breaking during the install:
-bitcoin explorer
-joinmarket
-OTS
To fix these things, I ended up reinstalling python and OTS with
sudo apt-get install python3 python3-dev python3-pip python3-setuptools python3-wheel
sudo pip3 install opentimestamps-clinet --break-system-prackages
Then I reinstalled joinmarket per the bonus guide Installation instructions, which went fine.
Bitcoin explorer had stopped working due to an nginx issue that was fixed by running:
sudo apt install libnginx-mod-stream
Not certain which of the above issues were caused by the PR instructions vs adding sudo apt autoremove but figured it was worth sharing this experience here.
Thank you!

I used these instructions to update to Debian 12 and they worked OK. I added the command sudo apt autoremove which may have contributed to the following applications breaking during the install: -bitcoin explorer -joinmarket -OTS
To fix these things, I ended up reinstalling python and OTS with sudo apt-get install python3 python3-dev python3-pip python3-setuptools python3-wheel sudo pip3 install opentimestamps-clinet --break-system-prackages
Then I reinstalled joinmarket per the bonus guide Installation instructions, which went fine.
Bitcoin explorer had stopped working due to an nginx issue that was fixed by running: sudo apt install libnginx-mod-stream
Not certain which of the above issues were caused by the PR instructions vs adding sudo apt autoremove but figured it was worth sharing this experience here.
Thank you!

Could you please share how did you upgrade to debian 12? simply change the repo and run apt update && apt upgrade then apt dist-upgrade?


Fix a C++ comment in the refcount.h

Although in a false-conditional code section gcc-4.8.4 flagged this with
a C90 warning :-(
include/internal/refcount.h:108:7: error: C++ style comments are not allowed in ISO C90 [-Werror]
// under Windows CE we still have old-style Interlocked* functions

1.1.1 only?

  No idea why.

Ok then.  Most probably, it got fixed on the fly in master, so went unnoticed...

Merged.  Thanks!


Fixed issue with npm run foreman

This was not working on windows either via cmd or via a cmder bash window.
This fix simply adds an node in front of the statement.

Added this fix to another PR here: https://github.com/OpenBankingUK/reference-mock-server/pull/78


is number bool value

checkers.is_numeric(True) return True
This is bug because the value is bool,
may i make a PR for this subject?

Thanks, but this is actually not a bug, as in Python the bool type technically is a numeric type that inherits from int, such that True == 1 and False == 0.
In Python 2.x you can reassign the identity of True or False to something non-numeric, but that will still be evaluated appropriately in the checker. In Python 3+ they are instead language keywords which cannot be reassigned, so they are always numeric.
Here are links to the Python PEPs and standard library documentation associated with booleans:
https://docs.python.org/2.3/whatsnew/section-bool.html
https://www.python.org/dev/peps/pep-0285/
https://docs.python.org/3/library/stdtypes.html
And here’s a link to a very thorough explanation on StackOverflow: https://stackoverflow.com/questions/2764017/is-false-0-and-true-1-in-python-an-implementation-detail-or-is-it-guarante


Convert from CtOption to VerificationOutput

Previously the CtOption type was used as the return value for
Verifier::verify(). This resulted in the inability to access the value
used during the verification. Now a VerificationOutput output value
which provides access to the verification value(s).

Motivation

Current dependencies on/for this PR:

main

PR #83

PR #84

PR #85

PR #86

PR #87   👈

This comment was auto-generated by Graphite.


Make generic parameter requirements more flexible for custom derive

Currently generic parameter requirement affect the algebraic trait and all it's super traits.
Most simple way of fixing this would be to allow different where clauses for subtraits, but this would be cumbersome.

Could this be fixed by parsing same alga trait as were implementing right now from where clause and then stepping the dependency hierarchy up when implementing traits? Is there use cases where this would break down?


Storage STG 88

API change check
APIView has identified API level changes in this PR and created following API reviews.
Azure.Storage.Blobs


Add NumericalDimension

Is your feature request related to a problem? Please describe.
We should have a NumericalDimension, which is identical to a Measure, but can be differentiated in encoding specs. This would allow us to properly filter out numerical dimensions that are not measures in particular fields and enable us to potentially create new fields to improve new app (e.g. numeric range filter).
Additional context
See this thread.

isNumerical is already available trough:
scaleType is in {IntervalScale,RatioScale}
@bprusinowski it's important keep those two concepts apart

qudt:scaleType which indicate the {nominal,ordinal,interval,ratio} scaleType. the latter who indicate what call numerical.
rdf:type which flag {Key,Measure}Dimensions or can be absent i.e. to indicate "none of them"

based upon these concepts it becomes clear that i.e. a non-measure (rdf:type not set to MeasureDimension) with ratio scaleType shall not be treated as a Key nor a MeasureDimension.
NB: As you noticed this generic logic equally applies to the LFI cubes for the standardError Dimension and more cases to come... you can think of any meta information loosely

precision, validity or usefulness of a measurement (i.e. cloud cover on satellite images, dirt in a probe, )
reference values (i.e. reference area, reference population) which could be used as (a) a criteria to filter bigger or smaller entities or even (b) a divisor to resolve to measure per area, measure per population, etc.
... more cases to join

So it definitely makes a lot of sense to have such dimensions with whatever kind of non-measure meta information available. Apart from the standardError the filter case is the most obvious.
cc @l00mi @ptbrowne

Hi @Rdataflow,
thank you for clarifying the differences! This issue was meant as a purely technical improvement, which won't affect the mappings done in the cuber creator. We treat some concepts as "dimension types" to make it easier to use within the application; so there is e.g. a TemporalDimension, which is created based on the "Time description" data kind set on a dimension in the cube creator.
Right now we have to retrieve "isNumerical" property for each dimension: even GeoCoordinates or GeoShapes dimensions, which can't be numerical, as they contain sets of coordinates and names of the regions.
If we introduced a NumericalDimension (which is not a MeasureDimension and may or may not be a KeyDimension) it would be more efficient and easier to maintain some of the option fields that could only be used with such dimensions (potentially, as we don't have any of such at the moment).
I hope that our intentions are clearer now :)


Azure Key Vault .NET Quickstart tenantId and subscriptionId variables are unused

In the Azure Key Vault .NET Quickstart, the variables tenantId and subscriptionId are set from environment variables. It seems that these are leftovers from https://github.com/Azure-Samples/key-vault-dotnet-core-quickstart/commit/12cc86d8506357cfc0c6c53fab66e8f771cb5da5 , as they were used before this commit but were not removed when the sample code was updated.
The article mentions that these are used for authentication, but it seems now that they are unnecessary for the use-case shown. This would require an update to both the example code and the article.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: bc43d849-5b06-7185-0c9e-aaf240363aca
Version Independent ID: 385f4dfe-326a-9e63-80ce-3c71903edf3c
Content: Quickstart -  Azure Key Vault client library for .NET
Content Source: articles/key-vault/quick-create-net.md
Service: key-vault
GitHub Login: @msmbaldwin
Microsoft Alias: mbaldwin

@Chris-Johnston Thank you for pointing that out. We will ave this checked and update the content authors as necessary.


Document how to run openstack-cloud-controller-manager with hack/local-up-cluster.sh

From @dims on January 19, 2018 2:21
There is support for EXTERNAL_CLOUD_PROVIDER=true when you also add CLOUD_PROVIDER and CLOUD_CONFIG for local-up-cluster.sh, we should document how one can easily build a test/dev environment using local-up-cluster.sh
Copied from original issue: dims/openstack-cloud-controller-manager#34

please see:

https://github.com/kubernetes/kubernetes/pull/58549
https://github.com/kubernetes/kubernetes/pull/58543

see https://github.com/kubernetes/kubernetes/pull/59280

oh, the local-up-cluster should be running inside a VM started by OpenStack (to be able to pick up the metadata from either the config drive or the metadata service)

@hogepodge can you please try this out?

with latest k/k master, set the following env vars and then run sudo -E PATH=$PATH ./hack/local-up-cluster.sh (PATH should have etcd binaries)
export EXTERNAL_CLOUD_PROVIDER_BINARY=/home/dims/go/src/git.openstack.org/openstack/openstack-cloud-controller-manager/openstack-cloud-controller-manager
export EXTERNAL_CLOUD_PROVIDER=true
export CLOUD_PROVIDER=openstack
export CLOUD_CONFIG=/etc/kubernetes/cloud-config

Checking it out today.

I'm able to start up a localcluster on Centos with the directions provided. I don't need to use sudo since I have docker enabled for my user, and after the latest updates in place I've changed the location of the cloud provider binary. I'll write up my notes into a gist.

@dims https://github.com/kubernetes/cloud-provider-openstack/pull/67

There's a bunch more stuff we need to line up for this to work - https://github.com/theopenlab/openlab-zuul-jobs/blob/master/playbooks/cloud-provider-openstack-acceptance-test-e2e-conformance/run.yaml#L75


CTHUB - Current Status column in Schedule B query showing 'Fuel Supplier Status' instead of 'Submitted'

Describe the task
Revise the SQL query for the Schedule B question to display the 'Submitted' status in the 'Current Status' column for submitted reports. Currently, the status displayed is 'Fuel Supplier Status'.
Purpose
Aligns with labels shown in the UI and business logic.
Acceptance Criteria

[ ] first
[ ] second
[ ] third

Additional context

Add any other context about the task here.
Or here

Hey team! Please add your planning poker estimate with Zenhub @AlexZorkin @jig-patel @prv-proton


create a page for the workspace example contract

Currently in first draft state. I put down the basics, but there are a couple questions and areas I'd love some input from others on:

Where in the "recommended reading" order should this fit? I placed it at the end for now, but it feels like it's more foundational than that?
What is the "practical application" of this workspace technique? I put down a couple (probably wrong) bullet points, but would love some help expanding the list and/or describing the use-cases more fully/better. (@leighmcculloch)

Refs: #518

Something went wrong with PR preview build please check

Preview is available here:http://developers-pr706.previews.kube001.services.stellar-ops.com

Hi @leighmcculloch! Are you able to review this PR?

Preview is available here:http://developers-pr706.previews.kube001.services.stellar-ops.com

Preview is available here:http://developers-pr706.previews.kube001.services.stellar-ops.com

Preview is available here:http://developers-pr706.previews.kube001.services.stellar-ops.com


Prettier Formatting

Pull Request
Description
I added prettier to the code base to help keep formatting consistent. I also added a workflow to make a workflow auto run and commit this formatting to all PRs and pushes to main.
The only relevant files to review are:
.prettierignore
.prettierrc.json
.github/workflows/prettier.yml
Closes #40
Type of change

[ ] Bug fix (change which fixes an issue)
[x] Enhancement (change which alters existing functionality)
[ ] New feature (change which adds new functionality)
[ ] This change requires a wiki/documentation update

How Has This Been Tested?
It passes the unit tests 🤷
Checklist

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my code
[x] I have commented my code, particularly in hard-to-understand areas
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] Any dependent changes have been merged and published in downstream modules

Try to checkoff as much as possible if not everything!

I think we should update the readme and describe how you can run the prettier workflow. There than that, LGTM!

I think we should update the readme and describe how you can run the prettier workflow. There than that, LGTM!

Added a short paragraph about it in #41.


Testing nuget feeds out of sync

✔ Expected result
Go to managed NuGet packaged and see no need to consolidate
❌ Actual result
Need consolidation

I was also "messing" with the NuGet packages a few days ago. Indeed there were about 5 or 8 consolidations and about 25 updates.
Did you also see the message "deprecated" for a couple of Microsoft packages?

I was also "messing" with the NuGet packages a few days ago. Indeed there were about 5 or 8 consolidations and about 25 updates.
Did you also see the message "deprecated" for a couple of Microsoft packages?

There is an issue to migrate to the new analyzers

There is an issue to migrate to the new analyzers


Feature request: flow types incorporating operation name and associated variables

It would be great to have the following types generated for flow:
type getUserRequest = {
 operationName: 'getUser',
 variables: getUserQueryVariables
}

type updateUserRequest = {
 operationName: 'updateUser',
 variables: updateUserMutationVariables
}

type graphqlRequests = getUserRequest | updateUserRequest

With these types it will be possible to be completely type safe making requests. Right now if using the flow types one has to double check the operation name exists and is spelled correctly.

The input variables was/is supported by the flow target, but appears to have been dropped in the flow-modern target. Instead, only input types (rather than arguments) are generated in the flow modern one. I've created https://github.com/apollographql/apollo-codegen/issues/321 about that specific issue.
Including operationName seems like a good idea. Something like that could help avoid typos mismatching the variable types and the actual operation being used.


IxToggle checked attribute value ignored by component

What happened?
I noticed that checked attribute of IxToggle component completely ignores any value assigned to it, except for when the element  loads for the first time.
That means, that if we for example have a stateful boolean variable of which the value is determined by a successful or failed API request, we are not able to set the checked attribute accordingly.
In the provided code, you can see the simplest way to reproduce this issue, meaning giving an explicit false value to the checked attribute. As you will notice the value is completely ignored (except for when the component loads initially).
What type of frontend frameware are you seeing the problem on?
React
Which version of iX do you use?
v1.4.1
Code to produce this issue.
import { IxToggle } from "@siemens/ix-react";
// ...
<IxToggle checked={false}/>

Can you please provide more detailed tested it with the following code:
https://stackblitz.com/edit/angular-uqxzsw?file=src/toggle.tsx
async function APICall(v: boolean) {
  return new Promise<boolean>((r) => setTimeout(() => r(!v), 2000));
}

export default () => {
  const [toggle, setToggle] = useState(false);

  useEffect(() => {
    makeSomeApiCall();
  }, [setToggle]);

  const makeSomeApiCall = async () => {
    const result = await APICall(toggle);
    setToggle(result);
  };

  return (
    <>
      <IxButton onClick={makeSomeApiCall}>Toggle (timeout 2s)</IxButton>
      <IxToggle checked={toggle} />
    </>
  );
};

I think there is still a controlling issue of the component's state.
Yes @danielleroux your example shows that you can change the state dynamically. But at the same time the component still ignores the checked prop if you click on the toggle. In the example app, after the initial timeout the state gets changed to checked = true, but clicking on the toggle changes its internal state to a different value.
Basically what I am saying is: Given the code
<IxToggle checked={true} />

The toggle state should not change by clicking on it. As long as checked = true the toggle should stay checked. The iX Checkbox component behaves this way, but not the IxToggle component. This applies to iX version 1.x.x and 2.x.x.

@danielleroux @CptGeo do you agree on reopening this issue because of my aforementioned comment? If not I will need to open a new issue.

@robert-wettstaedt @CptGeo We will have another look at this.


model output problem

I trained a ludwig model to do some classification. my labels are strings such as 'cat','dog'. when I use my ludwig model to predict the label of my testing set, I found that Ludwig model output integers such as '0','1','2'instead of my string label. I suppose my model's output is the same type of the labels of my training data set, not number. I can't map my string label to ludwig model's integer label.
Is there anyway I can make my ludwig model's output in a right way?

@Kantshun check out the train_set_metadata file in the model/ folder. For each output feature,
you'll see the idx2str, which is the mapping between the 0/1/2.. to their category names.
This is a simple change and we'll prioritize accordingly. Thanks for creating the issue.

Ludwig should provide the output as strings, if it does not do it it means there's a problem. Can you please provide a fully reproducible example? With model definition and data sample or sythetic data?


spurious error:  failed call to cuInit: UNKNOWN ERROR

ubuntu 18.04, CUDA 10.1, TF 2.1, python 3.6.5
on a machine without a GPU, the following code emits "error:  failed call to cuInit: UNKNOWN ERROR".  of course that should fail!  you shouldn't have even tried.  printing that requires extra logic when parsing log files to check whether jobs succeeded.
Python 3.6.5 (default, Apr  1 2018, 05:46:30)
[GCC 7.3.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import tensorflow as tf
2020-03-18 08:16:50.221103: W tensorflow/stream_executor/platform/default/dso_loader.cc:55] Could not load dynamic library 'libnvinfer.so.6'; dlerror: libnvinfer.so.6: cannot open shared object file: No such file or directory; LD_LIBRARY_PATH: /usr/local/cuda/lib64:/.singularity.d/libs
2020-03-18 08:16:50.221260: W tensorflow/stream_executor/platform/default/dso_loader.cc:55] Could not load dynamic library 'libnvinfer_plugin.so.6'; dlerror: libnvinfer_plugin.so.6: cannot open shared object file: No such file or directory; LD_LIBRARY_PATH: /usr/local/cuda/lib64:/.singularity.d/libs
2020-03-18 08:16:50.221275: W tensorflow/compiler/tf2tensorrt/utils/py_utils.cc:30] Cannot dlopen some TensorRT libraries. If you would like to use Nvidia GPU with TensorRT, please make sure the missing libraries mentioned above are installed properly.
>>> msg = tf.constant('Hello, TensorFlow!')
2020-03-18 08:16:55.455153: W tensorflow/stream_executor/platform/default/dso_loader.cc:55] Could not load dynamic library 'libcuda.so.1'; dlerror: libcuda.so.1: cannot open shared object file: No such file or directory; LD_LIBRARY_PATH: /usr/local/cuda/lib64:/.singularity.d/libs
2020-03-18 08:16:55.455184: E tensorflow/stream_executor/cuda/cuda_driver.cc:351] failed call to cuInit: UNKNOWN ERROR (303)
2020-03-18 08:16:55.455223: I tensorflow/stream_executor/cuda/cuda_diagnostics.cc:156] kernel driver does not appear to be running on this host (h10u02.int.janelia.org): /proc/driver/nvidia/version does not exist
2020-03-18 08:16:55.455545: I tensorflow/core/platform/cpu_feature_guard.cc:142] Your CPU supports instructions that this TensorFlow binary was not compiled to use: AVX2 FMA
2020-03-18 08:16:55.468119: I tensorflow/core/platform/profile_utils/cpu_utils.cc:94] CPU Frequency:<PHONE_NUMBER> Hz
2020-03-18 08:16:55.469505: I tensorflow/compiler/xla/service/service.cc:168] XLA service 0x49b71e0 initialized for platform Host (this does not guarantee that XLA will be used). Devices:
2020-03-18 08:16:55.469532: I tensorflow/compiler/xla/service/service.cc:176]   StreamExecutor device (0): Host, Default Version

Having a similar issue when I try running Jupyter notebook on GPU using jupyter/tensorflow-notebook Docker image from Dockerhub. It seems like CUDA fails to load so Jupyter notebook ends up running without GPU acceleration.
[I 18:36:11.117 NotebookApp] Kernel started: ef831313-da54-458c-9ce2-e854e67bec73
2020-03-18 18:36:14.799904: I tensorflow/stream_executor/platform/default/dso_loader.cc:44] Successfully opened dynamic library libnvinfer.so.6
2020-03-18 18:36:14.801346: I tensorflow/stream_executor/platform/default/dso_loader.cc:44] Successfully opened dynamic library libnvinfer_plugin.so.6
2020-03-18 18:36:16.140605: I tensorflow/stream_executor/platform/default/dso_loader.cc:44] Successfully opened dynamic library libcuda.so.1
2020-03-18 18:36:16.148127: E tensorflow/stream_executor/cuda/cuda_driver.cc:351] failed call to cuInit: CUDA_ERROR_UNKNOWN: unknown error
2020-03-18 18:36:16.148180: I tensorflow/stream_executor/cuda/cuda_diagnostics.cc:169] retrieving CUDA diagnostic information for host: jupyter-gpu-9f69d4848-lfx4b
2020-03-18 18:36:16.148193: I tensorflow/stream_executor/cuda/cuda_diagnostics.cc:176] hostname: aimp-jupyter-gpu-9f69d4848-lfx4b
2020-03-18 18:36:16.148331: I tensorflow/stream_executor/cuda/cuda_diagnostics.cc:200] libcuda reported version is: 418.40.4
2020-03-18 18:36:16.148378: I tensorflow/stream_executor/cuda/cuda_diagnostics.cc:204] kernel reported version is: 418.40.4
2020-03-18 18:36:16.148390: I tensorflow/stream_executor/cuda/cuda_diagnostics.cc:310] kernel version seems to match DSO: 418.40.4
2020-03-18 18:36:16.148896: I tensorflow/core/platform/cpu_feature_guard.cc:142] Your CPU supports instructions that this TensorFlow binary was not compiled to use: AVX2 FMA
2020-03-18 18:36:16.155651: I tensorflow/core/platform/profile_utils/cpu_utils.cc:94] CPU Frequency:<PHONE_NUMBER> Hz
2020-03-18 18:36:16.156455: I tensorflow/compiler/xla/service/service.cc:168] XLA service 0x556699f800e0 initialized for platform Host (this does not guarantee that XLA will be used). Devices:
2020-03-18 18:36:16.156486: I tensorflow/compiler/xla/service/service.cc:176]   StreamExecutor device (0): Host, Default Version

Here is the Dockerfile I use:
FROM jupyter/tensorflow-notebook

USER root

RUN apt-get update && apt-get install -y gnupg2 &&\
	wget https://developer.download.nvidia.com/compute/cuda/repos/ubuntu1804/x86_64/cuda-repo-ubuntu1804_10.1.243-1_amd64.deb &&\
	apt-key adv --fetch-keys https://developer.download.nvidia.com/compute/cuda/repos/ubuntu1804/x86_64/7fa2af80.pub &&\
	dpkg -i cuda-repo-ubuntu1804_10.1.243-1_amd64.deb &&\
	rm -f cuda-repo-ubuntu1804_10.1.243-1_amd64.deb &&\
	apt-get update &&\
	wget http://developer.download.nvidia.com/compute/machine-learning/repos/ubuntu1804/x86_64/nvidia-machine-learning-repo-ubuntu1804_1.0.0-1_amd64.deb &&\
	apt install ./nvidia-machine-learning-repo-ubuntu1804_1.0.0-1_amd64.deb &&\
	rm -f nvidia-machine-learning-repo-ubuntu1804_1.0.0-1_amd64.deb &&\
	apt-get update &&\
	apt-get install -y --no-install-recommends \
		cuda-10-1 \
		libcudnn7=<IP_ADDRESS>-1+cuda10.1  \
		libcudnn7-dev=<IP_ADDRESS>-1+cuda10.1 &&\
	apt-get install -y --no-install-recommends \
		libnvinfer6=6.0.1-1+cuda10.1 \
		libnvinfer-dev=6.0.1-1+cuda10.1 \
		libnvinfer-plugin6=6.0.1-1+cuda10.1 &&\
	jupyter serverextension enable --py jupyterlab --sys-prefix &&\
 	pip install jupyter-tensorboard==0.2.0 certifi==2019.11.28 &&\
 	jupyter tensorboard enable

@bjarthur
Could you check this issue which is similar to your issue. If those solutions doesn't work, could you uninstall and reinstall CUDA and cuDNN? Please let us know how it progresses. Also, try to uninstall and reinstall tensorflow-gpu and try following the instructions from TensorFlow website. Thanks!

@stevancvetkovic this is not a similar issue to yours!  please don't hijack this issue.  i am trying to run tensorflow on a machine without a GPU.  and so no, @ravikyram , that issue you refer me to is also not relevant as that concerns using tensorflow with a GPU.
not all machine learning problems, even neural network ones, are big enough to need a GPU.  mine is just as fast with CPU alone.  tensorflow 2 now just has one installation procedure irrespective of whether you use a GPU or not (pip install tensorflow).  this differs from TF 1 where there were two (pip install tensorflow-gpu or pip install tensorflow).
my complaint here is that TF2 emits an error message when running on a machine without a GPU that says it tried to initialize the CUDA libraries.  before doing that it should check to see if there is a GPU in the first place.  throwing errors like that when in fact there is not one and the code continues to run fine makes parsing log files to see that everything is okay more complicated.   seems like an easy fix to me to change TF to first check if a GPU exists before trying to initialize CUDA.  thanks!

@ravikyram Is anyone already working on a fix for this? I can work on it if you could point me in the correct direction as to where to look in the codebase.

Can we suppress that error when running on CPU. This is pure noise.
2020-03-18 08:16:55.455184: E tensorflow/stream_executor/cuda/cuda_driver.cc:351] failed call to cuInit: UNKNOWN ERROR (303)

Our applications are very stable, and we setup notifications to our phones whenever there is an error, but this stupid tensorflow error blows up our phones on every deployment. Extremely annoying. Please be a good python citizen and only log errors.. when there is an error!

Can we suppress that error when running on CPU. This is pure noise. The app is working as expected without any problem. I can't see any reason why it would deserve an error. A warning maybe, but not an error.
2020-03-18 08:16:55.455184: E tensorflow/stream_executor/cuda/cuda_driver.cc:351] failed call to cuInit: UNKNOWN ERROR (303)

I have the same problem with pytest with -s flag on CPU. This error is going to create problem cause it is parsed an an error. /cc @seanpmorgan

I've a stub PR at https://github.com/tensorflow/tensorflow/pull/39956

@bjarthur As a workaround solution TF2 still publishes a tensorflow-cpu which should omit this attempt of dynamic kernel loading and is a significantly smaller package:
https://pypi.org/project/tensorflow-cpu/#history


[Update] [Open Path] Peek url in safari

Description

Web pages can be quickly previewed in Safari (by installing the shortcut Peek Url and selecting Peek in Safari in Settings)

Screencast

Checklist

[x] I read the extension guidelines
[x] I read the documentation about publishing
[x] I ran npm run build and tested this distribution build in Raycast
[x] I checked that files in the assets folder are used by the extension itself
[x] I checked that assets used by the README are placed outside of the metadata folder

Just after testing this it works first time, second time it pops the add shortcut dialog, I didn't change any settings, can we avoid that?

Can you confirm that you have a shortcut command called Peek Url in your Shortcuts? If not, you need to follow the pop-up instructions to install it.
You can see all the shortcuts by typing shortcuts list in the terminal, make sure it contains the Peek Url

I'm not sure what caused it, doesn't happen now - I only hear two beeps while running it, is that something from Raycast and do you hear the same?

This is a bug in the Raycast API, I've raised an issue about it before, this issue doesn't affect the extension use.
System will emit a NSBeep sound when getSelectedText() report error. #1497


Fix AttributeError with num_processes>1 but no ddp_cpu

What does this PR do?
See the following issue:
Fixes #4356
Before submitting

[x] Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
[x] Did you read the contributor guideline, Pull Request section?
[x] Did you make sure your PR does only one thing, instead of bundling different changes together? Otherwise, we ask you to create a separate PR for every change.
[n/a] Did you make sure to update the documentation with your changes?
[x] Did you write any new necessary tests?
[x] Did you verify new and existing tests pass locally with your changes?
[n/a] If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

[ ] Is this pull request ready for review? (if not, please submit in draft mode)

Closing because of https://github.com/PyTorchLightning/pytorch-lightning/issues/4356#issuecomment-719106455


suppress clang undefined behavior sanitizer in Channel constructor

Similar to #779...
Addresses https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=24021
If an input file contains a channel with an invalid PixelType, clang will generate an Invalid-enum-value warning. The proper behavior is to carry the invalid value, so it will be preserved on file write. This could potentially happen with "legal" files if the PixelType enum were ever extended in the future, in which case old versions of the library should read the new files.
Suppressing the warning in this one case is preferable to disabling all undefined behavior by the sanitizer, because other instances of undefined behavior may be legitimate bugs.
Signed-off-by: Cary Phillips<EMAIL_ADDRESS>

If this idiom is going to pop up a lot, is it worth defining once
#ifdef __clang__
#    define OPENEXR_NO_SANITIZE(x) __attribute__((no_sanitize (x)))
#else
#    define OPENEXR_NO_SANITIZE(x)
#endif

and then just use the macro more compactly at the individual places where it's needed? And also have a way to add other compilers as needed, with a change in only one place?

I agree with Larry, although I think perhaps it's clearer to not suppress the information that this is sanitizer, for clang; especially since gcc and clang kinda sorta share attributes but not completely. I think hoping for something that generalizes across msvc as well might be futile? Does anyone know for sure?
Jamming on Larry's proposal, but de-generalizing, I suggest:
#ifdef __clang__
#    define OPENEXR_CLANG_NO_UBI __attribute__((no_sanitize ("undefined")))
#else
#    define OPENEXR_CLANG_NO_UBI __attribute__((no_sanitize ("undefined")))
#endif

I'd recommend waiting to see if it does, in fact, occur often, it's not
clear that it will. As is, there's no misunderstanding what's going on. I'm
not a big fan of these sorts of macros, because it's completely opaque what
it's actually doing, so you have to go look at the declaration to see. It's
not even clear which header the declaration should go in. If someday we
want to suppress warnings with gcc, it's easy enough to generalize it then.
On Tue, Jul 14, 2020 at 11:15 AM Nick Porcino<EMAIL_ADDRESS>wrote:

I agree with Larry, although I think perhaps it's clearer to not suppress
the information that this is sanitizer, for clang; especially since gcc and
clang kinda sorta share attributes but not completely. I think hoping
for something that generalizes across msvc as well might be futile? Does
anyone know for sure?
Jamming on Larry's proposal, but de-generalizing, I suggest:
#ifdef clang
define OPENEXR_CLANG_NO_UBI attribute((no_sanitize ("undefined")))
#else
define OPENEXR_CLANG_NO_UBI attribute((no_sanitize ("undefined")))
#endif
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/AcademySoftwareFoundation/openexr/pull/780#issuecomment-658333480,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AFC3DGOJI25EERYJCJQOOWTR3SOCNANCNFSM4OZAIINQ
.

--
Cary Phillips | R&D Supervisor | ILM | San Francisco

What's the consensus here, any objections to foregoing the macro until it becomes clear there's a more common need?

I meant to cross-reference this to #785, which modifies invalid PixelType attributes to address the same issue. Files that have an invalid PixelType in any part cannot currently be opened (the sanityCheck method called from the constructor throws an exception) so there's no reason to try to preserve unknown enum values. Also, I think it is dangerous to cast 32 bit signed ints to enums, so maybe the sanitizer did catch something important.
I think we may need to review each case separately and decide if/how to fix, so maybe we don't need the macro yet.

Either way, this PR is not the right solution for the case at hand, so closing it.


Use commit_sha input that is currently ignored

Hi
Thanks for making this, I've been looking for an action that could do this for a while.
One issue though, the commit_sha input is ignored, it will always tag the latest commit
This is untested, but better than just an issue I guess
Thanks

@Intrepidd Thanks a lot for bringing this to my attention! I indeed forgot something there. I will do some testing and merge it with the main branch.

@Intrepidd Very clean code. I did a quick test using the local GitHub action runner and it seems to work. Thanks a lot for your contribution.

Fabulous, thanks !

@Intrepidd You patch has been released under version https://github.com/rickstaa/action-create-tag/releases/tag/v1.1.2


Forget password

The user cannot reinstate his/her password when forgotten

As a follow-up task we should also enable users to change their own passwords. See #29.


Update the project to use docker compose

Changes added:

Use docker compose to run multiple containers
Introduce MariaDB as the DB
Update the docker file to use standard php-fpm image from docker hub.
Setup a folder structure so customers can use it to run their own images in production.
Image does not build with the site installed anymore.
Startup file will run drush installation if AUTO_INSTALL_PORTAL environment variable is set to true.

Site is available at http://localhost:8080

@danistrebel Thanks a lot for the review. Appreciate you taking the time to test and provide feedback.


Dropbox Upload Error

Just did a run through of trying to import a board to clubhouse. I got the error Error occurred uploading file to dropbox continuing... Error in call to API function "files/upload": The given OAuth 2 access token is malformed.
When I created the dropbox app I chose the regular API, not business API. Also the token I set was the key not the app secret for dropbox.

Nevermind I missed the token down below in dropbox.


Es6 module for secure expressjs endpoints?

Hi There,
Are there any ES6 packages I can use to secure expressjs endpoints. I'm just starting out with express and would like to stop CRSF attacks on my endpoints? I'm using node 6.2 & Express 4.13.3.
I see that there is csurf.
Not really sure which is the best to use with es6 / babel?
I'm new to express.
Thanks in advance

Check out https://github.com/helmetjs/helmet.
In future, please post general queries at https://gitter.im/expressjs/express. This repository is specifically for issues related to the website http://expressjs.com/.


Allow the passing of arrays with both functions and strings to the permission system

Copied from Slack:
Feature request for the permission system: Allow viewableBy, editableBy and insertableBy to take arrays of functions as well as arrays of group names
I have a pretty common use-case where I want certain fields to be accessible by the owner of the document, and by moderators
But right now there is no elegant way to make that happen
I can either make it accessible by moderators, by passing ['moderators']
Or I can make it accessible by the owners, by passing Users.owns
But I can't do both, i.e. this doesn't work: [Users.owns, 'moderators']

Did the code for permissions change since the opencrud update ? If it did not, I could work on this, since it is useful to me too (I have the same use case as @Discordius) but I have not updated yet and won't before a couple of months

It did change a bit so I'd recommend working on the latest devel branch if you want to submit a PR for that.

Alrigth, I'll work on my older version first (1.9) and will do it after with the most recent version

Actually I don't see what changed on the way we treat viewableBy, editableBy, insertableBy, to me the functions Users.canViewField, Users.canEditFields, Users.canInsertFields did not change ? Am I missing something?
If I'm not missing anything, i have made this that seems to work with v1.9.1 :
Users.canViewField = function (user, field, document) {
  if (field.viewableBy) {
    if (typeof field.viewableBy === 'function') {
      // if viewableBy is a function, execute it with user and document passed. it must return a boolean
      return field.viewableBy(user, document);
    } else if (typeof field.viewableBy === 'string') {
      // if viewableBy is just a string, we assume it's the name of a group and pass it to isMemberOf
      return Users.isMemberOf(user, field.viewableBy);
    } else if (Array.isArray(field.viewableBy) && field.viewableBy.length > 0) {
      // if viewableBy is an array, we do a recursion on every item and return true if one of the items return true
      // this also makes it possible to use nested arrays, such as ['admins', ['group1', function1, [function2, 'group2'], function3]]
      return field.viewableBy.reduce((accumulator, currentValue)=> accumulator || Users.canViewField(user, currentValue, document));
    }
  }
  return false;
};

It uses recursion to treat arrays. Any feedback is welcome!
The functions for edit and insert will be the same
Just FYI, the current function is:
Users.canViewField = function (user, field, document) {
  if (field.viewableBy) {
    return typeof field.viewableBy === 'function' ? field.viewableBy(user, document) : Users.isMemberOf(user, field.viewableBy)
  }
  return false;
};

Ok, so in order to handle the new API I must also take care of a possible field.canRead in my function above, right ?
( In the code I did not find anything else than the simple-schema extension config about these, are they handled already or is it still a WIP?)

You're right it's still a WIP. For some reason I thought (hoped?) I had already done it…

And yeah I think you can just do something like
const canRead = field.canRead || field.viewableBy;
if (canRead) ...

Just make sure you leave this comment whenever you're adding backward compatibility:
// OpenCRUD backwards compatibility

Sure, will do. PR coming soon

Actually, while i'm working on this code, maybe update the name of the functions according to the new OpenCRUD names?
Here's what I think might be the best:

Field name
Function name

viewableBy
Users.canViewField

canRead
Users.canReadField

insertableBy
Users.canInsertField

canCreate
Users.canCreateField

editableBy
Users.canEditField

canUpdate
Users.canUpdateField

obviously we keep backwards compatibility for the old names

Correct me if I'm wrong but I think those functions would mostly be used by Vulcan itself internally? I don't think they're documented? If so we don't need to preserve backwards compatibility I think.

You're right, I don't think they're documented. Still, they're easily available to anyone who would look in the code and reuse it in their own code.
If we don't keep it backwards compatible, we can just say we changed the name in the release notes to warn anyone who might be using this.

Yes I think for those a warning in the release notes is sufficient.

I've been seeing unexpected behavior on my system, and when I use this code in permissions.js, it seems to work:
 Users.canReadField = function ( user, field, document) {    const canRead = field.canRead || field.viewableBy; //OpenCRUD backwards compatibility    if (canRead) {      if (typeof canRead === 'function') {        // if canRead is a function, execute it with user and document passed. it must return a boolean        return canRead(user, document);      } else if (typeof canRead === 'string') {        if (canRead == 'guests') {          return true;        }        // if canRead is just a string, we assume it's the name of a group and pass it to isMemberOf        return Users.isMemberOf(user, canRead);      } else if (Array.isArray(canRead) && canRead.length > 0) {        // if canRead is an array, we do a recursion on every item and return true if one of the items return true        // this also makes it possible to use nested arrays, such as ['admins', ['group1', function1, [function2, 'group2'], function3]]        const reducer = (accumulator, currentValue) => accumulator || Users.canReadField(user, {canRead: currentValue}, document);        return canRead.reduce(reducer, false);      }    }    return false;  };
The changes:
1 String comparison to 'guests' means fields marked 'guests', ['guests'], ['guests', 'members'] and ['members'] can now all be read by members.
2 The accumulator was returning a string so arrays aren't being handled correctly. I added an initialValue of false and made the middle argument of the recursion call to be an object with key canRead.


new @types/googlemaps version generates error:

Hello,
After their latest update of @types/googlemaps (5th of October, 2020), I get these 2 errors when I build my Angular10 project for production:
ERROR in node_modules/@agm/core/lib/services/google-maps-api-wrapper.d.ts:51:41 - error TS2314: Generic type 'MapHandlerMap' requires 1 type argument(s).
51     subscribeToMapEvent(eventName: N): Observable<google.maps.MapHandlerMap[N]>;
node_modules/@agm/core/lib/services/google-maps-api-wrapper.d.ts:51:94 - error TS2314: Generic type 'MapHandlerMap' requires 1 type argument(s).
51     subscribeToMapEvent(eventName: N): Observable<google.maps.MapHandlerMap[N]>;
Everything was working fine 2 days ago, with a prior version of @types/googlemaps
Thank you

That version of  @types/googlemaps did you use to solve this ?

I haven't solved it, still waiting either for

@agm/core to fix the compilation issue, caused by the new version of @types/googlemaps
@types/googlemaps to add a backward compatible implementation of MapHandlerMap

Since @agm/core is set to use the "@types/googlemaps": "^3.39.8" version, there's little one could do ...

I managed to. Set not ^3.39.12 but  3.39.12

I'm using this library in the context of a CI/CD pipeline, the library is automatically installed when building the project, you cannot change anything ...

3.39.12
took me an entire day to figure that out npm install<EMAIL_ADDRESS>--save-dev

Yes, I did the same, added to my package.json and earlier version of this library, now the production build works !
Thanks @mcr-ksh @jimmykane !

Duplicate of #1892

@Foreverdie the other is closed. So then it's not a dupie

I have the versions fixed to an old version because of this,
is not fixed yet right?

I have the versions fixed to an old version because of this,
is not fixed yet right?

Latest still had this error.

Please disable the freaking stale bot.
On Sat, 19 Jun 2021, 02:49 stale[bot], @.***> wrote:

Closed #1898
https://github.com/SebastianM/angular-google-maps/issues/1898.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/SebastianM/angular-google-maps/issues/1898#event-4911907012,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAJVX45WVCXXECQVVFH64XDTTPLR3ANCNFSM4SHF76SA
.

https://github.com/SebastianM/angular-google-maps/issues/1926#issuecomment-865898799

I've tried to move to @types/google.maps, but it brings out a lot of other errors in my angular 12 build.
https://developers.google.com/maps/documentation/javascript/using-typescript

3.39.12
took me an entire day to figure that out npm install<EMAIL_ADDRESS>--save-dev

omg its working


Update PPP skeleton, fix image format

Added headings to PPP
Changed image format from jpg to png

Closes #17

Codecov Report
Base: 72.15% // Head: 72.15% // No change to project coverage :thumbsup:

Coverage data is based on head (fa3cb6d) compared to base (99aa554).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##             master      #29   +/-   ##
=========================================
  Coverage     72.15%   72.15%
  Complexity      399      399
=========================================
  Files            70       70
  Lines          1232     1232
  Branches        125      125
=========================================
  Hits            889      889
  Misses          311      311
  Partials         32       32

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Error message enhancement: Multijvm tests with Agent turned off

Problem 1: Wrong Error
In JavaTestRunner.java, there's an error that reads:
System.out.println("Only non-multijvm tests are supported with Agent turned off");

Link.
However, the if statement that must fail in order to produce this error is:
if (testExecutionType.equals("multijvm") && withAgent.equals("off")) {

Link.
@Mesbah-Alam - Could you please review this? These seem to contradict each other. Either Multijvm tests can run with the agent turned off, or they cannot, surely?
Problem 2: Unused keyword
On line 608 the string "&!robot" is appended to the "keyword" variable.
The keyword/s have already been added to fileContent for RUNTIME, so this keyword will never be used.
@Mesbah-Alam - Can you verify this? Perhaps we should move that logic further up?

The code in question is a carryover from SVT-contributed code of long ago (so carries with it need for cleanup and maintenance, technical debt).  The creation of JavaTestUtil was a first cut at removing this layer all-together, for now see some cleanup in #4750

Thanks Shelley! :)


Update Spark to 2.4.0

This updates the Spark dependency to 2.4.0.
Changes include:

Remove ORC support that uses a now-private Spark API (BufferHolder)
Use Spark filters instead of expressions, which are no longer used in the v2 API

This fixes #94.

FYI @omalley: Spark 2.4 broke ORC support, so we either need to fix it or remove it from Spark in the master branch. What would you prefer to do?

@charleso, we want to support multiple versions of Spark at the same time, but right now the API that we're using to integrate is evolving rapidly. It just doesn't make sense right now to support them all. Eventually, we will either use reflection or have versioned Spark modules.

@rdblue Thanks for that, exactly what I wanted to know. 👍

Closing this. The new one is https://github.com/apache/incubator-iceberg/pull/30.


Fetch and hard reset master branch instead of pulling

This PR addresses #36.

Looks good to me!
As a side note, not all Github repos use master as their default branch. I wonder if we could use the Github API (or some other means) to determine the branch to use.

@hermanschaaf Related discussion: https://github.com/golang/go/issues/9032


Conditionally exported variable set in editor runtime but not exported runtime

Godot version
4.0.3
System information
Windows 11
Issue description
When conditionally exporting a variable using _get_property_list, the variable is set in the editor runtime but not in the exported runtime.
While debugging, you may have to close the scene and re-open it to prevent false positives.
Steps to reproduce

Download the minimal repro
Open the project and press run project
You will see "Passed!" rendered in a window because the test passes
Now export the project (I exported to windows) and run it
You will see "Failed" because the test has failed

Minimal reproduction project
dynamic-export-bug.zip

I have a project that completely breaks when I export it, in a variety of ways. It seems like every node with an @exported node variable just... fails to load, somehow. Removing all the @export node variables fixes it.

@NotDaze are you using _get_property_list too?

It looks like actual_trigger_node is not set until _ready, that means it won't be available as a property until after loaded, properties of nodes are loaded before _ready is fired so you can't depend on setting things there

I am not using _get_property_list, I'm just using @exported nodes which breaks in exported versions. Removing all @exported nodes fixed it. I can't figure out how to reproduce it outside of my specific project, though, so I haven't made my own issue yet.

@NotDaze then this isn't really the same bug I'd say, as this bug is specifically about _get_property_list

@AThousandShips thank you for your feedback and clarifying the lifecycle. Sadly during the _init phase the node is not available so get_node will fail.

I don't think it makes much sense to have them be conditional in this way though

If you know another way, I'm very interested to know any ideas you have.
To clarify my use case, I'm building a library of nodes and considering Godot has its own conditional options in various places, I would like to have the same intuitive experiences for my users as Godot has given me.


Add logic to remove guest membership from logins having mapped user

Description
Add logic to remove guest membership from logins having mapped user
Task: BABEL-5438
Signed-off-by: Rishabh Tanwar<EMAIL_ADDRESS>Test Scenarios Covered

Use case based -

Boundary conditions -

Arbitrary inputs -

Negative test cases -

Minor version upgrade tests -

Major version upgrade tests -

Performance tests -

Tooling impact -

Client tests -

Check List

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is under the terms of the Apache 2.0 and PostgreSQL licenses, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>9
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 73.68%

Totals

Change from base Build<PHONE_NUMBER>2:
0.0%

Covered Lines:
43085

Relevant Lines:
58476

💛  - Coveralls


macos: "failed to set thread exception port" in forked process

Hello,
Avid Wasmtime users in our Nginx embedding, we are facing an assertion failure when running it with Wasmtime on macos (x86 and arm64):
thread '<unnamed>' panicked at 'assertion failed: `(left == right)`
  left: `268435466`,
 right: `0`: failed to set thread exception port', crates/runtime/src/traphandlers/macos.rs:474:9

This assertion systematically fails with Wasmtime 8.0.1 (and probably earlier) to 11.0.1 when Nginx is configured with daemon on (which ends here in Nginx forking into a background process). It seems it occurs in our call to wasmtime_linker_instantiate after having initialized an engine and a single store.
Not forking the master process (daemon off) seems to be working fine, even in forked worker processes (managed by the master process in foreground); instances are created and behave as expected in the Nginx worker processes.
The assertion failure specifically occurs once the master process has forked itself into a background process with daemon on.
In summary:

Works with daemon off: master process (foreground) -> wasmtime_linker_instantiate (temporary instance) -> fork() -> worker processes -> wasmtime_linker_instantiate (worker instances processing requests).
Fails with daemon on: master process (foreground) -> fork() (background daemon) -> wasmtime_linker_instantiate (temporary instance) -> assertion failure, no instance created, and no chance to fork() into worker processes.

In the past we used to have a CI/CD pipeline with macos targets and Wasmtime used to work fine; but this CI/CD pipeline was taken down, and this bit us in the last few days. It seems like older macos work on Wasmtime has something to do with it, but I know nothing of the macos system interface...
So far the root cause of this assertion failure has eluded us; probably state that aren't being carried over to the forked process or something like this. Could someone shed some light on what may be at cause here?
Thanks!

@casimiro has a good example and complete stacktrace of the assertion in #6788.
One thing we have tried to mitigate this is to destroy the engine before forking, in the hope that it would remove all secondary state, so that the forked process could call engine_new again and start from a clean slate. Alas, it does not make the assertion pass either.

The error code is MACH_SEND_INVALID_RIGHT (the message body specified a port right which the caller didn't possess).
Wasmtime allocates a Mach port name (WASMTIME_PORT), for receiving exceptions from the kernel, upon the very first construction of an Engine.
The assertion failure is from the per-thread initialization that occurs to setup the thread exception port from threads that are running wasm code.
Without a fork, this works because all threads in a process see the same Mach port namespace. However, Mach port namespaces aren't inherited in a child process.
So I suspect we're going to run into an issue whenever an Engine is created prior to a fork(); I'm not sure exactly what our policy is on supporting fork as there's lots of complex, OS-specific initialization in the engine, but this code is clearly not intended to be fork-aware.
Note that there is a compile-time feature (posix-signals-on-macos) which will forego the Mach exception ports integration in favor of traditional signal handlers; it might be worth seeing if you can build the Wasmtime C API with this feature flag and see if it helps with this issue.

I am not aware of a reason we couldn't "uninstall" the trap handlers or reset otherwise global state upon the destruction of the last Engine (i.e. to restore things the way they were prior to the construction of the first Engine).
I think it simply hasn't been a priority for us to do so as generally the majority use pattern for Wasmtime thus far has been to create a single Engine for the process and forego fork in favor of event queues.

the majority use pattern for Wasmtime thus far has been to create a single Engine for the process and forego fork in favor of event queues.

Note that all Nginx is doing is forking into a background process which isn't so uncommon, I suspect more embeddings of Wasmtime might run into this issue in the long run.

Is there a call to create the engine from within the initial process when the feature to fork the daemon is on?
If not, I can't really explain why that particular feature would be tripping things up if all it is doing is immediately forking.

Is there a call to create the engine from within the initial process when the feature to fork the daemon is on?

Yes there is or else we would have moved it already. We must open an engine and validate the .wasm bytecode being loaded before the fork() in order to potentially exit() if it is invalid. If we wait until after the fork() to do so, it is too late to ask Nginx to not start (i.e. go into background & fork() into worker processes).

I see, thank you for the clarification.
I suspect even in the daemon off case, we've initialized the per-thread exception port successfully as it's before the fork() of the worker process, but the worker probably inherited the fact it was initialized so doesn't attempt to do so again; thus I would expect trap handling to be broken if the wasm traps in the worker process.

For the posix-signals-on-macos feature, I find some error like:
cargo build --release -p wasmtime-c-api --lib --features posix-signals-on-macos
error: none of the selected packages contains these features: posix-signals-on-macos

And it can pass without wasmtime-c-api:
cargo build --release --lib --features posix-signals-on-macos
It seems the wasmtime-c-api  package does not have this feature. Is it a bug?

Yeah, it appears to be missing from the wasmtime-c-api crate, just needs to forward the feature to the wasmtime crate:
crates/c-api/Cargo.toml:
[features]
...
posix-signals-on-macos = ["wasmtime/posix-signals-on-macos"]

If you don't want to modify the source --features wasmtime/posix-signals-on-macos may also work.

Thanks all for the tips;
With macOS x86, traps are properly handled with posix-signals-on-macos, but on macOS ARM64, we get this exception on a trap with Wasmtime v11.0.1:
thread '<unnamed>' panicked at 'misaligned pointer dereference: address must be a multiple of 0x10 but is 0x105327c18', crates/runtime/src/traphandlers/unix.rs:217:22
stack backtrace:
   0: rust_begin_unwind
             at /rustc/8ede3aae28fe6e4d52b38157d7bfe0d3bceef225/library/std/src/panicking.rs:593:5
   1: core::panicking::panic_fmt
             at /rustc/8ede3aae28fe6e4d52b38157d7bfe0d3bceef225/library/core/src/panicking.rs:67:14
   2: core::panicking::panic_misaligned_pointer_dereference
             at /rustc/8ede3aae28fe6e4d52b38157d7bfe0d3bceef225/library/core/src/panicking.rs:174:5
   3: wasmtime_runtime::traphandlers::unix::get_pc_and_fp
             at ./work/runtimes/libwasmtime/repos/wasmtime/crates/runtime/src/traphandlers/unix.rs:217:22
   4: wasmtime_runtime::traphandlers::unix::trap_handler::{{closure}}
             at ./work/runtimes/libwasmtime/repos/wasmtime/crates/runtime/src/traphandlers/unix.rs:94:24
   5: wasmtime_runtime::traphandlers::tls::with
             at ./work/runtimes/libwasmtime/repos/wasmtime/crates/runtime/src/traphandlers.rs:747:18
   6: wasmtime_runtime::traphandlers::unix::trap_handler
             at ./work/runtimes/libwasmtime/repos/wasmtime/crates/runtime/src/traphandlers/unix.rs:79:19
   7: __platform_memmove

This seems to be coming from Wasmtime's interaction with the libc binding...

That's a bug! I've posted a temporary fix for that at https://github.com/bytecodealliance/wasmtime/pull/6793

Oops didn't mean to close this

I investigated this a bit recently and I'm not actually certain that we'll want to fix this. I think that the best solution here might be to recommend that macOS users who want to leverage fork should use signals via the Cargo feature rather than the default mach ports. If this is common then one option we could support is to make this a runtime configuration option instead of a compile-time configuration option too.
Otherwise though the issues on macOS that I found difficult to handle are:

Trap handling can't be Engine-local because the process's exception ports are, well, process-global.
It's technically possible to shut down the ports/handler thread when Engines all go away, but that IMO is kind of spooky action-at-a-distance where you have to be certain that no Engine is in existence which you may not necessarily always have control over (although I realize it's reasonable for this use case)
One option is to use pthread_atfork, but the problem with that is that it's unclear if all forks are intended for this sort of use case where the process continues to live of if it's something ephemeral such as a fork-then-exec combo.

I suppose that can all be mostly summarized as I think the only possibly-feasible thing to do here is to shut everything down when an Engine is destroyed, but I'm not personally all that comfortable doing that as it doesn't align with other platforms and I'm also not certain how robust we can make it.
Otherwise though @thibaultcha I'd ask you if having a custom build is difficult for y'all? If so we can move the signals-vs-ports to a runtime option instead. Additionally one other mitigation we could implement is to use pthread_atfork to force any wasm execution in the child to panic immediately rather than continue in a broken state, effectively having a more precise way of warning developers that "hey ports aren't compatible with fork please use this other thing to use signals instead"

Ok sounds good! Not too much work but no worries I've done some initial bits in https://github.com/bytecodealliance/wasmtime/pull/6807 now. If you'd like though some help in implementing a corresponding option in the C API would be appreciated!
As for the long term you should be good. Unix signals are unlikely to be as battle-tested as Mach ports because they're off-by-default for macOS, but they're turn on-by-default for Linux for example which means they're not completely untested. Y'all aren't the first to want to use signals instead of mach ports as well so it's something that I'd at least personally like to see continued support for in Wasmtime. Basically that's to say that, yes, you may run into future issues. I think we'll be interested in fixing them promptly, though, if they arise.

I think everything is now handled here with a combo of what I mentioned above:

There's a runtime configuration option for mach ports vs signals
We use pthread_atfork to fail-fast in child processes trying to do wasm things

I'm going to close this now but @thibaultcha if there's anything else please comment here!


Issue 12: Uplifted Sysmon Logging Policies

Identified within https://github.com/atc-project/atc-data/issues/12 and originally raised by an ATC Slack user.
Changes:

Removed references to legacy parameters.  There are no more instances of -n.
Reviewed all atc-data Sysmon logging policies (LPs) and aligned them to newer Sysmon descriptions.
Reviewed all atc-data Sysmon logging policies (LPs) for spelling and formatting.

Hello @pjabes! Sorry for the late reply, I have no idea how I could miss your PR... Found it today while going through contributions. Thank you very much for your help! Well done!


Multi-layer S4 code release

I want to use deep S4, but the only multi-layer S4 that has been released is the simpler version, which lacks the recurrent mode. Can you share the S4 code with multiple layers?

That file is a minimal implementation intended to help with understanding the model. The real implementation is in the same folder, see the README there https://github.com/HazyResearch/state-spaces/tree/main/src/models/s4

As far as I understand the code, there is only a single layer in the full implementation, right?

Yes, just as in all deep learning models, you have to construct a backbone that uses layers of your choice such as convolutions, attention, or S4. You can look at any CNN or Transformer architecture to learn how to do this.
In this codebase, you can find examples of how to construct such a deep model here or here.


Add Accessibility

Add Accessibility features to the HTML.

With HTML5 many accesibility issues has been replaced with descriptive and structural tags, solving problems to recognize titles, figures, embeds, etc.
May I work on it?

@jhia absolutely!
Just quick notes, not sure if any of this impacts what you'll need to work on:

Header is going to just be a simple Site title + Navigation between index.html and about.html (doesn't exist yet)
Will be adding the faction icons to each label to help indicate which is which for newer players
I also haven't gotten to styling the page much yet, so if there's anything I need to know for when I start adding css, let me know!
This issue was going to be broken down into a few smaller issues, so don't feel like you have to hit every possible point 😸

Thanks!


improved currency exchange box and added dark mode feature

Related Issue
Fixed #210
Description :
Added dark mode support for currency exchange dialog box. Also improved its appearance like adding arrow instead of the word "swap".
Screenshots :
Before :

After :

Please review my PR and add appropriate labels.

Related Issue Fixed #210
Description : Added dark mode support for currency exchange dialog box. Also improved its appearance like adding arrow instead of the word "swap".
Screenshots : Before :

After :

Please review my PR and add appropriate labels.

Fix it bro

@vanshchauhan21 someone deleted all the files related to currency converter. So the conflict cannot be resolved. I am closing this PR.


Release 2.1.1

Would be awesome if you could release a minor version containing this commit: https://github.com/lyft/mapper/commit/4f74320f9cef98fb98c7c8fcad6d45f8b293c337 (Make transformations throw MissingFieldErrors)
Cheers!

Since this is a breaking change this will have to be a more major version number bump, which is why I've been putting it off. I was hoping to merge my ks/compile-time branch and then cut this major release. Let me see if that's feasible to do ASAP, otherwise I'll bite the bullet and we'll have to bump it twice.

I've put a PR up for the other changes I wanted to make in to this major release here: https://github.com/lyft/mapper/pull/59

I've just tagged version 3.0.0 and pushed it to CocoaPods. This should be an easy migration but it did have some breaking changes, see the CHANGELOG for details, or feel free to open an issue with any questions. Thanks!

Thanks!


Hash encoder requires CUDA v11.3

So Nice to share the code.
I tried to follow the author's instructions to install CUDA = v11.3, and then followed a series of environment installations. But I encountered an error:
“
from .backend import _backend
File "/ai4hh/ai4h/mawen/Project/SAX-NeRF-master/src/encoder/hashencoder/backend.py", line 18, in
_backend = load(name='_hash_encoder',
File "/home/wenma/anaconda3/envs/sax_nerf/lib/python3.9/site-packages/torch/utils/cpp_extension.py", line 1144, in load return _jit_compile(
File "/home/wenma/anaconda3/envs/sax_nerf/lib/python3.9/site-packages/torch/utils/cpp_extension.py", line 1357, in _jit_compile
_write_ninja_file_and_build_library(
File "/home/wenma/anaconda3/envs/sax_nerf/lib/python3.9/site-packages/torch/utils/cpp_extension.py", line 1469, in _write_ninja_file_and_build_library
_run_ninja_build(
File "/home/wenma/anaconda3/envs/sax_nerf/lib/python3.9/site-packages/torch/utils/cpp_extension.py", line 1756, in _run_ninja_build
raise RuntimeError(message) from e
RuntimeError: Error building extension '_hash_encoder': [1/3] /usr/bin/nvcc
nvcc fatal   : Unsupported gpu architecture 'compute_86'
ninja: build stopped: subcommand failed.
”
And
ninja --version = 1.11.1.git.kitware.jobserver-1
gcc & g++ version = 9.4.0
nvcc: 11.3
Who can save this child...

When I change the backend.py extra_cuda_cflags=[
'-O1',
'-arch=sm_70',
'-U__CUDA_NO_HALF_OPERATORS__', '-U__CUDA_NO_HALF_CONVERSIONS__', '-U__CUDA_NO_HALF2_OPERATORS__' # undefine flags, necessary!
],
It also has the same error.
If I change the '-arch=sm_70' to '-arch=sm_75/80/85'
It will show this:
"
nvcc fatal   : Value 'sm_80' is not defined for option 'gpu-architecture'
ninja: build stopped: subcommand failed.
"

The error you encountered, "nvcc fatal: Unsupported gpu architecture 'compute_86'," indicates that the NVIDIA CUDA Compiler (nvcc) does not support the GPU architecture specified for compilation, which in this case is 'compute_86'. This issue can arise if you're using a CUDA toolkit version that does not support the specific compute capability of your GPU.
Please determine the compute capability of your GPU and check if it aligns with the CUDA version installed
If you find our repo useful, please help us star it. Thanks.

The final solution to this problem is Ninja version = 1.10.0.
I have tried 1.12 and 1.8 before and the problem still exists.
Today I tried version 1.10.0/1.10.2 and it was solved successfully.

Hi, really happy to see that you have fixed the problem. Good luck :)


Single-Page Web App Router - Hash URLs

Specific Demand
Thanks for all the amazing work on Dioxus! I am interested in using the library to create web apps, in particular SPA, however I'm running into issues with the router updating urls. As I understand it, the router currently tracks its state/URL internally, however on browser window refresh this internal state/URL is wiped and the user returns to the home page.
I may be missing it, but is there currently any way to update the browser url when using the router in a SPA?
Implement Suggestion
One way to use URLs for SPA is to use hash urls (ie: https://website.com/#/homepage/2). If this is implemented into the router, I think it would help really complete the functionality for web. I unfortunately don't have the know-how yet to take on such a task myself; I'm still a bit of a fledgling rustacean.
Thanks for your consideration!

The router should update the url of the current page if the web feature is enabled. If the web feature is not enabled, it will default to a in-memory history.
I believe #637 adds a hash history provider in addition to the normal URL history currently supported

How can one enable hash histories? I can't seem to figure it out...

How can one enable hash histories? I can't seem to figure it out...

Hash histories are currently not supported. To enable normal URL histories, you can enable the web feature on the router

@Demonthos The web feature is enabled by default on dioxus-router, according to this:
❯ cargo add dioxus-router
    Updating crates.io index
      Adding dioxus-router v0.3.0 to dependencies.
             Features:
             + gloo-events
             + js-sys
             + query
             + serde
             + serde_urlencoded
             + wasm-bindgen
             + web
             + web-sys
             - wasm_test
❯

However, after upgrading to Dioxus 0.3 and now using the (externalized) dioxus-router, I see that:

"deep links" such as http://localhost:8080/signin are not working anymore: the result is always the homepage.

The routing is working fine, though: clicking on a link points correctly to the corresponding page.

The URL doesn't get updated.

As reference and reproducible case, please find here the whole example.
Thanks!

@Demonthos The web feature seems to be enabled by default on dioxus-router, according to this:
❯ cargo add dioxus-router
    Updating crates.io index
      Adding dioxus-router v0.3.0 to dependencies.
             Features:
             + gloo-events
             + js-sys
             + query
             + serde
             + serde_urlencoded
             + wasm-bindgen
             + web
             + web-sys
             - wasm_test
❯

The only default feature for the router is the query feature. It would be great if we could include this as a default feature for web targets, but there is no separate target for applications that target wasm on the server, so the feature would have no way of telling between the two.
I'm not entirely sure what happened with the command you listed. I did notice that if you run:
cargo add dioxus-router --features web
cargo add dioxus-router

The second command lists the web feature as enabled.

However, after upgrading to Dioxus 0.3 and now using the (externalized) dioxus-router, I see that:

Directly hitting specific routes - such as http://localhost:8080/signin - is not working anymore.

The result is always the homepage.
However, the routing is working fine: clicking on a link points correctly to the corresponding page.
Even the "fallback 404 page" (set according to this doesn't seem to work.

The URL doesn't get updated while navigating through the different paths.

As reference and reproducible case, please find here the whole example.
Shall I create a distinct issue for this?
Thanks!

Cloning the repo and adding the web feature explicitly to the cargo.toml in the frontend package seemed to fix these issues for me, but if it remains an issue feel free to open a new issue

@Demonthos  Lovely! :partying_face:   Really appreciate the quick feedback! :pray:
I can confirm it's all working as expected (both routes reflected in the URL and directly accessible, plus the not found page delivered on unknown paths).


Replace kleisli with dry-monads (closes #80)

After releasing dry-monads we are now able to replace kleisli gem.

I think it can be merge into master before 0.8 is released. Does anyone have concerns about it?
/cc @timriley @AMHOL

Looks good to me @flash-gordon

Looks good, thanks!


Hide values outside of min & max in LineChartData

When data is more or less than the applied min and max values, the lines overflow out of the designated area of the graph.
I have tried wrapping the chart in a clipRRect and it did remove all overflow. However some axes labels were being cut and the touch tool tip was being cut or not shown at all.

Hi,
Did you try to set clipData in the LineChartData?


Archived snap of week 1

https://github.com/rapidsai /notebooks-extended/advanced/examples/Dask_with_cuDF_and_XGBoost.ipynb
https://github.com/rapidsai /notebooks-extended/advanced/examples/Dash_with_cuDF_and_XGBoost_from_Disk.ipynb
https://github.com/rapidsai/notebooks-contrib/blob/master/intermediate_notebooks/examples/One_Hot_Encoding.ipynb
https://github.com/rapidsai/notebooks-contrib/blob/master/intermediate_notebooks/examples/PCA_Demo_Full.ipynb
https://github.com/rapidsai/notebooks-contrib/blob/master/intermediate_notebooks/examples/DBSCAN_Demo_Full.ipynb

addressed in #192


Revert "Feature/ksponspeech"

Reverts speechbrain/speechbrain#2510

As discussed privately, this PR has the be reverted as not deeply testes.


wrong colors in carbon-90 theme

There're some discrepancies between some design resources. The correct gray 90 is #262626 not #282828. And the correct Red 50 is #fa4d56. The combination passes accessibility.

Related to https://github.com/IBM/kui/issues/3096


Added steps for install istio with helm charts.

Jenkins job istio.github.io/presubmit passed

We also need to ensure istio non-auth and auth configuration is exposed via chart, and even perhaps istio add-ons.

OK, will re-visit this once https://github.com/kubernetes/charts/issues/1909 got fixed.

closing this for now - we'll reopen once it's ready/working

https://github.com/kubernetes/charts/issues/1909 is now merged @linsun @ldemailly @rshriram
There is also a PR bumping istio to 0.2.7 https://github.com/kubernetes/charts/pull/2392

Jenkins job istio.github.io/presubmit passed

Jenkins job istio.github.io/presubmit passed

We need to hear from a core contributor about their experience using helm before we send users to helm for 0.2 in this first release

@ldemailly I will try to contact some core contributor to have a try

@andraxylia volunteered to try

@linsun @rshriram @ldemailly any of you who is interested to try this? Both myself and @lachie83 are willing to help, we can even show you a walkthrough case.

me, i'll try this tmr. :)

Jenkins job istio.github.io/presubmit passed

sorry I had thought this is very easy, but I'm getting this error:
Lins-MacBook-Pro:Downloads linsun$ helm repo add incubator http://storage.googleapis.com/kubernetes-charts-incubator
"incubator" has been added to your repositories
Lins-MacBook-Pro:Downloads linsun$ helm install --name istio incubator/istio --namespace istio-system
Error: file "incubator/istio" not found

@gyliu513 @lachie83 ^^

@linsun I was always test as follows:

Check out kubernetes/charts code.
Go to charts/ folder.
helm install incubator/istio

This works well, will check what is wrong with adding a repo, not sure if it is related to https://github.com/kubernetes/charts/tree/master/incubator/istio#installing-the-chart , the istio install now requires two steps, cc @lachie83

hmm, I had thought the istio helm chart is already published to the incubator repo thus I can just install it from the repo.  I think that is an easier step than git clone all charts.  Waiting for input from @lachie83

@linsun this is due to the current helm chart version format being identified as a prerelease under semverv2. You need to run an install with the following flag --devel. This flag allows installation of prereleased versions More details in the following ticket about potentially changing the chart version

Here is the related issue - https://github.com/kubernetes/helm/issues/3009

@lachie83 - It seems odd to run it with the flag --devel now that istio 0.2.7 is announced as the 0.2 release.   It is just a better user experience as no one would expect that --devel flag now.

@linsun totally agree. Once we determine the best path forward we can address

Do we still want this PR?

Users do seem to want it, but there are some issues with the helm chart that would first need to be fixed before we document it as an endorsed way to install Istio. Here is one I noticed: https://github.com/kubernetes/charts/issues/2508

there is also https://github.com/istio/istio/pull/2030 now

@sbezverk I was just taking a look at this PR, and thought you may want to document in the Istio website how to use the istio repo based helm charts.

@sdake Once I got everything working, I will definitely post helm deployment document.

Thanks @sbezverk , please let me know when your PR is ready.


TESTS branch

Added tests for the pybrid.data file.  All functions are currently covered for initial simple tests

LGTM


Automate PyPI package updates

Given that I don't maintain this anymore and the package is under my name, we should automate the process for whenever a new release is cut, we should build and upload a new package to the PyPI repository from the master branch.
Steps to do this:

Add PyPI API Token
Use python setup.py sdist bdist_wheel to build the latest version
Use Twine to upload the latest version using the API token

For testing, we should test this using TestPyPI first for PRs and then swap this out for the release event for uploading to the real thing.

As an alternative follow-up, might be worth exploring how to decentralize it but this is a good first step.

Going to start work on this today, hopefully 0.0.10 will be the first to be published this way.
Then I can start working my way down the issue log.

Going to start work on this today, hopefully 0.0.10 will be the first to be published this way.
Then I can start working my way down the issue log.

@iheanyi I've pushed the workflow setup needed for automatic builds pushed to TestPyPI with the commands for PyPI included but commented out.
That is about all I can do from my end, tokens and such need to be generated (I can do it for PyPI but not Github)
If you think its worth reconfiguring the build system and project files for the repo to be PEP 517/518 compliant (pyproject.tml) and use setup.cfg let me know, I'm not familiar with the new system but I can't imagine its hard to work out.

@iheanyi I've pushed the workflow setup needed for automatic builds pushed to TestPyPI with the commands for PyPI included but commented out.
That is about all I can do from my end, tokens and such need to be generated (I can do it for PyPI but not Github)
If you think its worth reconfiguring the build system and project files for the repo to be PEP 517/518 compliant (pyproject.tml) and use setup.cfg let me know, I'm not familiar with the new system but I can't imagine its hard to work out.

@Evolution0 Oh snap, I got you on this week hopefully, thanks for getting started on it. I'm also going to look into changing the permissions and seeing if you can get the permissions to manage secrets, if that's cool?

@Evolution0 Oh snap, I got you on this week hopefully, thanks for getting started on it. I'm also going to look into changing the permissions and seeing if you can get the permissions to manage secrets, if that's cool?

Yeah that will be fine.

Yeah that will be fine.

@Evolution0 I've added the token in there, but the build step is failing.
/opt/hostedtoolcache/Python/3.9.1/x64/bin/python: No module named build

@Evolution0 I've added the token in there, but the build step is failing.
/opt/hostedtoolcache/Python/3.9.1/x64/bin/python: No module named build

@iheanyi The build looks like its successful according to the log but it doesn't push to TestPyPI because of:
Warning:  It looks like you are trying to use an API token to authenticate in the package index and your token value does not start with "pypi-" as it typically should. This may cause an authentication error. Please verify that you have copied your token properly if such an error occurs.

@iheanyi The build looks like its successful according to the log but it doesn't push to TestPyPI because of:
Warning:  It looks like you are trying to use an API token to authenticate in the package index and your token value does not start with "pypi-" as it typically should. This may cause an authentication error. Please verify that you have copied your token properly if such an error occurs.

TestPyPI builds are going through just fine now on each push after some minor tweaking (also updated the workflow)
I wouldn't go so far as to add a release workflow quite yet, id like to figure out requests-cache to be able to add a testing step to check for regressions/bugs and such (as testing against Bandcamp itself live could put us in a youtube-dl situation) before the actual publish step.
Honestly I should probably start pushing to a dev branch and set the workflow to publish that one to the test server instead, that way there is a clear division between release build and test build and users will still have access to test builds via TestPyPI.
Kind of put it off for a year.. sorry about that. Hopefully I can make some headway into simplifying the code and breaking it up into manageable pieces like I originally intended + adding more documentation so that other people have an easier time working on it. Takes a while to get back into the right mindset to work on it after so long, sometimes its like I didn't even write the code I'm looking at.