tesseract: 3.05.00 -> 4.1.1

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/tesseract-ocr/tesseract/releases.
meta.description for tesseract is: "OCR engine"
meta.homepage for tesseract is: "https://github.com/tesseract-ocr/tesseract"
meta.changelog for tesseract is: ""
Updates performed

Version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS

The tests defined in passthru.tests, if any, passed

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

found 4.1.1 with grep in /nix/store/p3dz2hrvbz92hkpxgdv7fcriv8f92ghc-tesseract-4.1.1

directory tree listing: https://gist.github.com/d63d299e2aa1073adbbeef6ab3f01693

du listing: https://gist.github.com/a4fb6ec61e33771c35845607eab3d968

Rebuild report (if merged into master) (click to expand)

60 total rebuild path(s)

17 package rebuild(s)

17 x86_64-linux rebuild(s)
16 i686-linux rebuild(s)
11 x86_64-darwin rebuild(s)
16 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
ccextractor
gImageReader
gscan2pdf
invoice2data
paperless
pdfsandwich
python37Packages.pytesseract
python37Packages.tesserocr
python38Packages.pytesseract
python38Packages.tesserocr
python39Packages.pytesseract
python39Packages.tesserocr
qt-box-editor
ripgrep-all
tesseract
tesseract3
vobsub2srt

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/p3dz2hrvbz92hkpxgdv7fcriv8f92ghc-tesseract-4.1.1 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A tesseract https://github.com/r-ryantm/nixpkgs/archive/53b1a3efc4b20f727b73d17fc317278d6f0cb488.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/p3dz2hrvbz92hkpxgdv7fcriv8f92ghc-tesseract-4.1.1
ls -la /nix/store/p3dz2hrvbz92hkpxgdv7fcriv8f92ghc-tesseract-4.1.1/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review 1

5 packages failed to build:

gscan2pdf
python37Packages.tesserocr
python38Packages.tesserocr
python39Packages.tesserocr
vobsub2srt

10 packages built:

ccextractor
gImageReader
paperless
pdfsandwich
python37Packages.pytesseract
python38Packages.pytesseract
python39Packages.pytesseract
qt-box-editor
ripgrep-all
tesseract

Maintainer pings
cc @viric @erikarvstedt for testing.

This is the fourth copy of the same faulty PR, the other being:
#77908
#78533
#105089
@ryantm, could you look into this?

@ryantm did you fix nixpkgs-update?

@Mic92 no not yet. Here is the issue tracking this https://github.com/ryantm/nixpkgs-update/issues/126

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/tesseract-ocr/tesseract/releases.
meta.description for tesseract is: "OCR engine"
meta.homepage for tesseract is: "https://github.com/tesseract-ocr/tesseract"
meta.changelog for tesseract is: ""
Updates performed

Version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 5.2.0 with grep in /nix/store/846ssi0ggyx7araxy3baa1y8dxdk4wkq-tesseract-5.2.0
found 5.2.0 in filename of file in /nix/store/846ssi0ggyx7araxy3baa1y8dxdk4wkq-tesseract-5.2.0

Rebuild report (if merged into master) (click to expand)

25 total rebuild path(s)

25 package rebuild(s)

First fifty rebuilds by attrpath
arcanPackages.all-wrapped
arcanPackages.arcan
arcanPackages.arcan-wrapped
arcanPackages.durden-wrapped
arcanPackages.pipeworld-wrapped
arcanPackages.prio-wrapped
arcanPackages.xarcan
gImageReader
gnome-frog
gscan2pdf
invoice2data
pdfsandwich
perl532Packages.ImageOCRTesseract
perl534Packages.ImageOCRTesseract
python310Packages.pytesseract
python310Packages.tesserocr
python310Packages.videocr
python39Packages.pytesseract
python39Packages.tesserocr
python39Packages.videocr
qt-box-editor
ripgrep-all
tesseract
tesseract3
vobsub2srt

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/846ssi0ggyx7araxy3baa1y8dxdk4wkq-tesseract-5.2.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A tesseract https://github.com/r-ryantm/nixpkgs/archive/21af626d2ff3794d5699b3decc0c6db326b773b3.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/846ssi0ggyx7araxy3baa1y8dxdk4wkq-tesseract-5.2.0
ls -la /nix/store/846ssi0ggyx7araxy3baa1y8dxdk4wkq-tesseract-5.2.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

5 packages failed to build:

gscan2pdf
python310Packages.tesserocr
python39Packages.tesserocr
qt-box-editor
vobsub2srt

18 packages built:

arcanPackages.all-wrapped
arcanPackages.arcan
arcanPackages.arcan-wrapped
arcanPackages.durden-wrapped
arcanPackages.pipeworld-wrapped
arcanPackages.prio-wrapped
arcanPackages.xarcan
gImageReader
gnome-frog
pdfsandwich
perl532Packages.ImageOCRTesseract
perl534Packages.ImageOCRTesseract
python310Packages.pytesseract
python310Packages.videocr
python39Packages.pytesseract
python39Packages.videocr
ripgrep-all
tesseract

Maintainer pings
cc @viric @erikarvstedt for testing.

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/tesseract-ocr/tesseract/releases.
meta.description for tesseract is: "OCR engine"
meta.homepage for tesseract is: "https://github.com/tesseract-ocr/tesseract"
meta.changelog for tesseract is: ""
Updates performed

Version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 5.3.0 with grep in /nix/store/7a41a29f6ic60llv1ixn3ggmh11dg6xx-tesseract-5.3.0
found 5.3.0 in filename of file in /nix/store/7a41a29f6ic60llv1ixn3ggmh11dg6xx-tesseract-5.3.0

Rebuild report (if merged into master) (click to expand)

28 total rebuild path(s)

28 package rebuild(s)

First fifty rebuilds by attrpath
arcanPackages.all-wrapped
arcanPackages.arcan
arcanPackages.arcan-wrapped
arcanPackages.cat9-wrapped
arcanPackages.durden-wrapped
arcanPackages.pipeworld-wrapped
arcanPackages.prio-wrapped
arcanPackages.xarcan
gImageReader
gnome-frog
gscan2pdf
invoice2data
manga-cli
pdfsandwich
perl534Packages.ImageOCRTesseract
perl536Packages.ImageOCRTesseract
python310Packages.pytesseract
python310Packages.tesserocr
python310Packages.videocr
python39Packages.pytesseract
python39Packages.tesserocr
python39Packages.videocr
qt-box-editor
ripgrep-all
tesseract
tesseract3
vobsub2srt
zathura

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/7a41a29f6ic60llv1ixn3ggmh11dg6xx-tesseract-5.3.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A tesseract https://github.com/r-ryantm/nixpkgs/archive/c6442ec5c20888c570d5321ef8d47530d9b5c35e.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/7a41a29f6ic60llv1ixn3ggmh11dg6xx-tesseract-5.3.0
ls -la /nix/store/7a41a29f6ic60llv1ixn3ggmh11dg6xx-tesseract-5.3.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

5 packages failed to build:

gscan2pdf
python310Packages.tesserocr
python39Packages.tesserocr
qt-box-editor
vobsub2srt

21 packages built:

arcanPackages.all-wrapped
arcanPackages.arcan
arcanPackages.arcan-wrapped
arcanPackages.cat9-wrapped
arcanPackages.durden-wrapped
arcanPackages.pipeworld-wrapped
arcanPackages.prio-wrapped
arcanPackages.xarcan
gImageReader
gnome-frog
manga-cli
pdfsandwich
perl534Packages.ImageOCRTesseract
perl536Packages.ImageOCRTesseract
python310Packages.pytesseract
python310Packages.videocr
python39Packages.pytesseract
python39Packages.videocr
ripgrep-all
tesseract
zathura

Maintainer pings
cc @viric @erikarvstedt for testing.


Update issue templates

Oooh Rafael you're awesome, switching to that open link button option!! Thank you 😊


Support options.url in the Connection constructor

This allows for connecting to urls like rethinkdb://host:port/path
The port is optional, defaulting to 28015.

Force pushed with a few changes:

Updated lib/pool.js to store options.url in this.options.connection
Updated Pool#getAddress to use options.url if defined
Added Connection#getAddress for logging

I think I'll close this for now, as the path option of net.connect isn't what I thought it was? Not really sure what's required to support connecting to a host with a pathname.

Any progress?


Huge performance decrease by quantization

I use the code from PR https://github.com/apache/incubator-mxnet/pull/13715, and I got a huge performance decrease by doing quantization on my model. I tested on Windows 10 with CUDA 10 and cudnn7 on Titan X (Pascal), using pre-release build from pip mxnet-cu100.
Alought by this issue https://github.com/apache/incubator-mxnet/issues/10897, it claimed that INT8 quantization can save GPU memory during usage, I got almose 2x more VRAM usage by quantization.
Do we excepted that INT8 quantization is super slow and use more memory on GPU?
And I may assume that UINT8 quantization is not yet supported since the UINT8 quantizated parameters is signed integer.
So, do we have any plan for improving INT8 quantization in the near future?

@Dickjc123

FYI,  https://github.com/apache/incubator-mxnet/blob/master/example/quantization/README.md

@pengzhao-intel
Form your link

Performance is expected to decrease with GPU, however the memory footprint of a quantized model is smaller.

But in my case, it double the GPU memory usage. I don't think it can be considered as "smaller".

I couldn't find any information about why GPU memory usage increased.

@ThomasDelteil do you have some data to show the memory changes of INT8 flow?
@reminisce to comment your question.

@mxnet-label-bot add [Operator, Performance]

@mxnet-label-bot add [Quantization]

https://github.com/apache/incubator-mxnet/pull/9552#issuecomment-390523747
Since there is no plan till now, closing this issue.
Welcome to file PR to fix related issues.


Update recover broker-info.subm file proposal

Few design changes were made while implementing the proposal. This PR changes the proposal description to match the implementations made.
Epic: https://github.com/submariner-io/enhancements/issues/143

To make this PR easier to review, here are the changes:
diff --git a/subctl/issue-89-reconstructing-broker-info.md b/subctl/issue-89-reconstructing-broker-info.md
index cec0879..11ee963 100644
--- a/subctl/issue-89-reconstructing-broker-info.md
+++ b/subctl/issue-89-reconstructing-broker-info.md
@@ -1,4 +1,4 @@
-# Recover broker-info.subm file from the running Broker
+# Recover broker-info.subm file from the running Submariner

 Related Issue:
 [Option for recovering the broker-info.subm file from a running broker cluster](https://github.com/submariner-io/enhancements/issues/143)
@@ -12,19 +12,16 @@ This proposal describes a way to recover the `broker-info.subm` file from the ru

 ## Proposal

-A new `subctl` command will be added that would fetch needed data from the broker and write it to `broker-info.subm` file. The file
-would be Base64 encoded.
+A new `subctl` command will be added that would fetch needed data from the broker and Submariner and write it to `broker-info.subm` file.
+The file would be Base64 encoded.

 ## Design details

 * subctl command name: `recover-brokerinfo`
 * Flags for the command:
-  * `brokerconfig` to specify kubeconfig of the cluster in which Broker is installed
-  * `brokernamespace` to specify the namespace in which broker is installed
-  * `ipsec-psk-from` to specify the file to read PSK secret from
   * All flags that `restConfigProducer` provides
     * `kubeconfig` to specify kubeconfig of the cluster in which Submariner is installed
-* Data to be fetched from running broker:
+* Data to be fetched from running broker or Submariner:
   * Broker URL
   * Client token
   * IPSec PSK
@@ -32,31 +29,18 @@ would be Base64 encoded.
   * whether service discovery component is installed
   * default custom domains

-The last three information will be retrieved from the broker `Spec`, Broker URL from the user provided broker kubeconfig, client token
-from the Broker admin service account `submariner-k8s-broker-admin` and IPSec PSK with the following logic:
-
-```mermaid
-flowchart TD
-  A{Submariner config provided via `--kubeconfig` flag?} -- Yes ---> D
-  A -- No ---> B
-  B[Broker kubeconfig provided via `--brokerconfig` flag] ---> C{Broker cluster has Submariner installed?}
-  C -- Yes ---> D[Get PSK secret from submariner.Spec]
-  C -- No ---> E{"Any cluster joined to Broker (Figure out from the endpoints)?"}
-  E -- Yes ---> F[Exit]
-  E -- No ---> G{PSK file specified via `--ipsec-psk-from` flag?}
-  G -- Yes ---> H[Use secret from the file]
-  G -- No --> I[Generate new secret]
-```
-
-If Submariner is not installed in the cluster specified by the `--kubeconfig` flag, end the execution and throw an error. This addresses
-the scenario where there is a cluster with Submariner in the environment but an incorrect config was provided via the flag. In such
-scenario, if the execution is not stopped, a different/new PSK secret would be populated which would break the environment.
+The last three information will be retrieved from the broker `Spec`, client token from the Broker admin service account
+`submariner-k8s-broker-admin` and Broker URL and IPSec PSK from Submariner `Spec`.
+
+If Submariner is not installed in the cluster specified by the `--kubeconfig` flag, end the execution and throw an error. The logic
+first checks if Broker is installed on the same cluster as Submariner. If not, Broker cluster will be accessed from the Submariner cluster
+via the Broker URL.

 ### Usage

-The new command can be used as follows (assuming Submariner is installed in cluster2:
+The new command can be used as follows (assuming Submariner is installed in cluster2):

-`subctl recover-brokerinfo --brokerconfig output/kubeconfigs/kind-config-cluster1 --kubeconfig output/kubeconfigs/kind-config-cluster2`
+`subctl recover-brokerinfo --kubeconfig output/kubeconfigs/kind-config-cluster2`

 ### Alternatives


[DOC] Proposal: list capabilities of individual estimators in their documentation

Describe the issue linked to the documentation
When browsing the available estimators (classifiers, clusterers, ...) in the aeon documentation or using IntelliSense, I cannot directly see which estimator supports which input types (the source code is of limited use because of class inheritance etc.).
Suggest a potential alternative/fix
Aeon already stores the capabilities of individual estimators as tags in machine-readable form (see below), and we can list estimators based on their tags using the registry (e.g., with registry.all_estimators(filter_tags={"capability:unequal_length": True})).
https://github.com/aeon-toolkit/aeon/blob/620caa54d29481c9c85b06799354e65b9dd28464/aeon/base/_base_collection.py#L30-L37
and
https://github.com/aeon-toolkit/aeon/blob/620caa54d29481c9c85b06799354e65b9dd28464/aeon/base/_base_series.py#L57-L62
Can we use the tags to display the estimator's capabilities also in the documentation?

It's a good idea, it would be easy to make a single page displaying them in a table, more complex to embed in docstrings (i.e. I don't know how to:)

We could just list them in the docstring, i.e. insert manually?

Sure. That would help me as well.

There could be a way to add the tags to the automatic API generation for the webpage, but I don't imagine this is simple. When it comes to adding it to the source docstring, I'm afraid that may have to be manual.
What sounds the easiest from our end, would be to bring back the estimator overview page (but useful). Would having a searchable table which displays the tags be helpful for your usage at all @CodeLionX? Obviously not the best solution, and we didnt really see a point in keeping the previous iterarion.


HasBadge and heroicon bugfix

resolves two issues that were present (for me, at least) in a fresh install of Filament:

'HasBadge' trait seems not to exist. Default Filament Tab component simply has a badge method, which was copied in here and references to 'HasBadge' were removed
item blade view file referenced a heroicon that does not appear to exist. Modified to a similar icon that exists within the bladeicons pack

thank you for the PR :) will release it now

hey @soWizardly
can you share what version of filament are you using?
the Filament\Support\Concerns\HasBadge dose exist in the last version, we are bring it back with #7


Idea about merge of this repo and community repo

Hi, I'm contributor of https://github.com/terraform-yacloud-modules/terraform-yandex-kubernetes, module which is used by many companies. Don't you want to merge these repos and develop community module togther?

@kvendingoldo Hi! You can pull code from my repository. I don`t have time. Sorry.


[Feature Request] Change voting system

Is your feature request related to a problem? Please describe.
So I have multiple playlists set up and auto playlists setup, I've noticed when people want to skip the auto playlist song they require votes and if someone puts on songs and then goes afk or leaves and someone else wants to skip it they can't without votes so they end up just killing the bot and using another one which makes having this point irrelevant
Describe the solution you'd like
My discord server personally does not like the voting system and has disabled it on all previous bots I would like to be able to remove the option for voting and just make it so that there's no DJ role or any of that nonsense
Describe the basic flow/steps of using this feature
How this feature would be used:

Set something VoteSkipEnabled = true/flase
Run some command 'hey Alexa voteskip off/on yes/no'

Additional context
We have called our bot Alexa and use the prefixes Alexa and hey Alexa for the meme so that's why I said that above
Have you confirmed that this idea is not already described here?
https://github.com/jagrosh/MusicBot/projects/1
Yes I can find it anyone right now we're just using another bot to look for someone using the skip command and then adding votes or just force skipping

For the record, you can set the DJ role to @ everyone, and then anyone can forceskip (and use all the DJ commands). This might be a reasonable alternative until more voting options are available.

Can have any voting system just having number of user vote and skip. That not using the user ration in the channel. Just enough rote can skip. Or can let us to change the skip ratio
Skip ratio 0.2

A setskip command has been implemented (https://github.com/jagrosh/MusicBot/commit/c4de816c7cb98ba36ef969018f61d6372239b5e6) and comes with the next release, version 0.3.6. This command allows you to set the percentage of people wanting to skip the song. In your case, you can do setskip 0 to allow anyone to skip the track immediately.


Enable JDK_REPO, JDK_BRANCH as variables of test job template

Current test job template doesn't take JDK_REPO, JDK_BRANCH as variables, which means test jobs can only be created with JDK_REPO, JDK_BRANCH as default empty string. Enabling them as variables gives user the flexibility of creating jobs with user defined value as default value. Hence jobs can be triggered by inputting parameters as less as possible.

Same for VENDOR_TEST_REPOS, VENDOR_TEST_BRANCHS, VENDOR_TEST_DIRS


deepseek chat_format template

Is your feature request related to a problem? Please describe.
Request for a deepseek chat_format template
Additional context
Deepseek prompt template found here:
https://huggingface.co/TheBloke/deepseek-coder-6.7B-instruct-GGUF
You are an AI programming assistant, utilizing the Deepseek Coder model, developed by Deepseek Company, and you only answer questions related to computer science. For politically sensitive questions, security and privacy issues, and other non-computer science questions, you will refuse to answer.
### Instruction:
{prompt}
### Response:

Perhaps the chat_format templates should be stored in a configuration file.
In this way, users can edit the .conf to adapt to any model without changing the code.

@mjwweb I have added --chat-format to the llama.cpp/examples/server/api_like_OAI.py(not llama.cpp-python) --> my repo
You can edit chat-format.toml to add your template.
For deepseek-coder-instruct, maybe like this:
[deepseek-coder-instruct]
prefix = "You are an AI programming assistant.\n"
system = ""
user = "### Instruction:{content}\n"
assistant = "### Response:{content}\n"
suffix = "### Response:"

then run:
./server -m model.gguf and
python api_like_OAI.py --chat-format deepseek-coder-instruct
I haven't tested this template myself, but it should be easy to adjust to make it work.


[bug] csproj property being modified incorrectly

Not sure if this is related to #34 or was an existing issue. Also not sure if multiple properties are affected or this one is an edge case.
The empty <OutputPath></OutputPath> property is being changed to <OutputPathh/> with an extra 'h', and another 'h' is added each time the update button is used. (Even if on the latest version and nothing is actually updating).
This example csproj file with a diff after doing an update: (with additional entries for testing)
<Project Sdk="Microsoft.NET.Sdk">

  <PropertyGroup>
    <TargetFramework>netstandard2.0</TargetFramework>
    <DebugType>embedded</DebugType>
    <Version>1.0.0</Version>
  </PropertyGroup>

  <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|AnyCPU'">
    <DocumentationFile>.\Project.xml</DocumentationFile>
-    <OutputPath></OutputPath>
+    <OutputPathh/>
  </PropertyGroup>

  <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release|AnyCPU'">
    <DocumentationFile>.\Project.xml</DocumentationFile>
-    <OutputPath/>
+    <OutputPathh/>
  </PropertyGroup>

  <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release|AnyCPU'">
    <DocumentationFile>.\Project.xml</DocumentationFile>
-    <OutputPathhhhhh/>
+    <OutputPathhhhhhh/>
  </PropertyGroup>

  <ItemGroup>
    <PackageReference Include="Dapper" Version="2.0.123" />
    <PackageReference Include="MySql.Data" Version="8.0.31" />
    <PackageReference Include="Npgsql" Version="6.0.7" />
    <PackageReference Include="System.Configuration.ConfigurationManager" Version="6.0.1" />
    <PackageReference Include="System.Data.SqlClient" Version="4.8.4" />
  </ItemGroup>

  <Target Name="PrepublishScript" BeforeTargets="PrepareForPublish">
    <ItemGroup>
      <DocFile Include="bin\$(Configuration)\$(TargetFramework)\*.xml" />
    </ItemGroup>
    <Copy SourceFiles="@(DocFile)" DestinationFolder="$(PublishDir)" SkipUnchangedFiles="false" />
  </Target>

</Project>

@Anderezekial
thank you for reporting, i fixed it.


Documentation Improvements

Made a few improvements to the spelling and grammar across different areas of the documentation.

This PR fixes issue #667  (among others.)


Color wheel no longer misbehaves in a flexbox -- fixes issue #48

Simple one-liner change that ended two hours of debugging. Typo or intentional design?

@tkanarsky hey, great job!
display: flex

Is default in react-native no?
Check the link please -> https://reactnative.dev/docs/layout-props#display
I haven't test it, but I am suppose you could just remove line with
flex: 1


[BEAM-10208] add cross-language KafkaIO integration test

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

R: @chamikaramj

Please also run "Run Python 2 PostCommit" and "Run Python 3.7 PostCommit"

CC: @robertwb

Retest this please

Run Python 3.7 PostCommit

Run Python 2 PostCommit

Are failures unrelated ?

I don't think they are related to the change. Java Precommit failure is unrelated because this PR only has Python changes and I can confirm that newly added test passed in both py2 and py37 postcommits.

Run Java PreCommit

Run Python 2 PostCommit

Run Python 3.7 PostCommit

Run Java PreCommit

LGTM. Thanks.


Problem: dynpgext extensions competing for GUCs

Suppose two dynpgext extensions try to define the same GUC custom variables (common when you have multiple versions of the same extension eagerly preloaded by omni_ext). In that case, one will win the race, but others will fail to acquire the insertion of such variable and thus won't be able to obverse changes to the variable. They will also fail with an error if they attempt to define such a variable.
Proposed solution 1: let the loader provide GUC variable storage
The loader (such as omni_ext) should provide an API that would allow looking up an allocation for a variable in the centralized dictionary (handle->lookup_guc_TYPE(const char *name) returningTYPE * or something like this).
This way, the initializer in the extension can check if it is present and define a variable only if it isn't. Others should get the pointer to where the variable's value is and use it when necessary.
This is further complicated by the fact that the loader may be loading an extension at runtime, which means it is being called from a different process. This may mean that the dictionary may need to reside in shared memory, and the insertion may need to be guarded by locks (though not a big problem as this doesn't happen often)
Another additional complication here is string values: I don't know if there's technically a limit to variable name length, and there's no limit to a string value. Would these need to be allocated in shared memory as well?
Proposed solution 2: don't eagerly preload extensions and eliminate the distinction between runtime and startup time initialization.
This changes how shared memory and lock acquisition would happen, so while interesting, it has to be thought through.

Solved in omni.


Emulator does not clear the state - v4.14.0

I have been trying to debug an authenticated skill and I have two different logins to test it out. How ever, it looks like the emulator picks up the credentials I logged in previously without prompting me to authenticate. I have tried clearing the state multiple times. I have noticed the same behavior with v4.13.X as well. I use the mac version. Any leads would be appreciated, thanks!

Let me attempt a repro on my Mac and update the thread with my findings. Also, when you state that you have tried clearing the state multiple times, you used the File > Clear state menu option? Can you try using Fiddler to capture the network traffic while attempting to sign in and attach the trace here?


Remove welcome mail code

What about the table emails and library/EngineBlock/Mail/Mailer.php?

@thijskh There is still debug mail functionality and request access mail functionality. If those can go as well, a lot more could be cleaned up. The latter is disabled at the moment if I recall correctly (due to previous XSS attack vector), the former I'm not sure when it's used.
As an aside, searching for mail helps with identification of where it's used :wink:

@thijskh There is still debug mail functionality and request access mail functionality. If those can go as
well, a lot more could be cleaned up. The latter is disabled at the moment if I recall correctly (due to
previous XSS attack vector), the former I'm not sure when it's used.

Those (and only those) need to stay. Fixing the latter one is on the backlog.
However, I think both of those do not use the code I mentioned in my previous comment.

Something for @nicwortel to check then 😄

@thijskh you are right, the EngineBlock_Mail_Mailer is indeed no longer being used, so I have removed it.
It looks like the emails table is already removed in patch-0020.sql.


privileges: Add NoNewPrivileges in the api

We were defaulting the NoNewPrivileges flag to true.
Instead parse this from the payload and then pass it to libcontainer.
Signed-off-by: Archana Shinde<EMAIL_ADDRESS>

LGTM


Include Devise test helpers

Hello,
I am trying to include the Devise Test helpers so I can login programmatically.
I have added the following code in app_commands/scenarios/my_scenario.rb
require 'factory_bot'
include Devise::Test::IntegrationHelpers
user = FactoryBot.create(:user, :test_user)
sign_in user

The user is generated fine, but it fails with an error:
unexpected error while processing request: undefined method `setup' for CypressDev::CommandExecutor:Class
	/Users/eamon/.rvm/gems/ruby-2.5.5/gems/cypress-on-rails-1.3.0/lib/cypress_dev/command_executor.rb:9:in `eval'
	/Users/eamon/.rvm/gems/ruby-2.5.5/gems/devise-4.6.1/lib/devise/test/integration_helpers.rb:23:in `class_eval'
	/Users/eamon/.rvm/gems/ruby-2.5.5/gems/devise-4.6.1/lib/devise/test/integration_helpers.rb:23:in `included'

It seems to be because it is not within a class, which I don't have in this case, and even trying to wrap it in one doesn't work .
Has anyone been able to get this to work?
Many thanks
Eamon

hmmmm, unfortunately you not able to use Devise::Test::IntegrationHelpers as you don't have access to the request, cookies or sessions object which is something that i should add at some point.
As a work around here is what I currently use to login in user.
in routes.rb
Rails.application.routes.draw do
  # ...... you other routs
  unless Rails.env.production?
    scope path: "/__cypress__", controller: 'cypress' do
      post "forceLogin", action: 'force_login'
    end
  end
end

app/controllers/cypress_controller.rb
class CypressController < ApplicationController
  skip_before_action :verify_authenticity_token

  def force_login
    if params[:email].present?
      user = User.find_by!(email: params.require(:email))
    else
      user = User.first!
    end
    sign_in(user)
    redirect_to URI.parse(params.require(:redirect_to)).path
  end
end

in cypress/support/on-rails.js
Cypress.Commands.add("forceLogin", (details) => {
  if(!details)
    details = {}

  if(!details.redirect_to)
    details.redirect_to = '/'

  cy.visit("__cypress__/forceLogin",
    { method: "POST", body: { email: details.email, redirect_to: details.path }  })
});

examples of usage in cypress specs
cy.forceLogin()
cy.forceLogin({redirect_to: '/profile'})
cy.forceLogin({email<EMAIL_ADDRESS>
Let me know if this helps you

Thank you, I will give it a try and let you know

I added this as our first doc file:
https://github.com/shakacode/cypress-on-rails/blob/master/docs/authentication.md

If I want to login to a rails app that uses devise using cy.request(), is this the only method? I've successfully been able to login via the web form and then access protected views, but not with cy.request. I followed the recipe on Cypress for using cy.request() and can see that the session_id is set. However, when I attempt to access a protected page, I am redirected to the login page. I am assuming that there is something I don't understand about Devise/Warden that prevents this from working without using the above work-around.

@alexsligar if you could post example of how your test looks or an example repo of the problem, that could possible help us figure out what is wrong. Unfortunately not able to deduce what the issue could be from the information you have given.

I am using a Cypress command:
Cypress.Commands.add("login", () => {
    return cy.request({
        method: 'POST',
        url: '/d/users/sign_in',
        form: true,
        body: {
            'user["email"]'<EMAIL_ADDRESS>            'user["password"]': "Test@123"
        }
    })
})

Then in my test, I run something like this:
    beforeEach(() => {
        cy.app('clean')
        cy.login()
    })

    afterEach(() => {
        cy.app('finish_clean')
    })

    it('name should be required', function() {
        cy.appScenario('building')
        cy.visit('/buildings/1/edit')
    })

It successfully calls cy.login() and I can test that the session_id cookie is set. However, it gets redirected to the login page whenever I attempt to visit /building/1/edit. If I instead write the following for my login command, I am not redirected and can access /building/1/edit:
Cypress.Commands.add("login", () => {
    cy.visit('/')
<EMAIL_ADDRESS>    cy.get('[name="user[password]"').type('Test@123')
    cy.get('#login_button').click()
})

Also, I was able to use the forceLogin() command suggested above and not get redirected. However, I was hoping to avoid adding this into the code base and use cy.request() to login via Devise.

@alexsligar I see, the most likely issue is rails wanting the "authenticity_token". In the cypress controller above you will see skip_before_action :verify_authenticity_token
You can set failOnStatusCode to "true" on cypress requests, which will fail the cypress test if the request does not return a success status.
Cypress.Commands.add("login", () => {
    return cy.request({
        method: 'POST',
        url: '/d/users/sign_in',
        form: true,
        failOnStatusCode: true,
        body: {
            'user["email"]'<EMAIL_ADDRESS>            'user["password"]': "Test@123"
        }
    })
})

@grantspeelman interestingly, it does not fail. This command returns a 200 status and the _session_id cookie is set. However, it still 302 redirects to /d/users/sign_in upon visiting another page. I can even check for the presence of the _session_id cookie prior to attempting to visit another page and I see it is set.

@alexsligar from my understanding you always get a session cookie any time you interact with rails, even when you are not logged in. Hmmm, I am not sure to be honest. Why is there a d in your url?
    cy.request({
      method: 'POST',
      url: '/accounts/sign_in',
      form: true,
      failOnStatusCode: true,
      body: {
        'account["email"]'<EMAIL_ADDRESS>        'account["password"]': "Pass1234"
      }
    })

Doing the above against our codebase gives a 422 response, which is related to the authenticity_token.

@grantspeelman interestingly, it does not fail. This command returns a 200 status and the _session_id cookie is set. However, it still 302 redirects to /d/users/sign_in upon visiting another page. I can even check for the presence of the _session_id cookie prior to attempting to visit another page and I see it is set.

Also experiencing this. @alexsligar, did you ever figure this out?

@grantspeelman are you sure the login is successful? You can log the flash in an after_action filter to check if the login is working:
after_action do
  puts flash.to_json
end

What I've found is that you're not sending the body correctly. 'user["email"]' --> 'user[email]'
Using this command with a Rails + Devise app I'm able to login and visit other pages:
Cypress.Commands.add("login", user => {
  return cy.request({
    method: 'POST',
    url: "/users/sign_in",
    form: true,
    failOnStatusCode: true,
    body: {
      'user[email]': user.email,
      'user[password]': "password"
    }
  });
});

good spot on the quotes inside the body params :+1:

@grantspeelman ;) I guess that this way should go into the docs. Less code and it's the recommended way for Cypress:
https://docs.cypress.io/guides/getting-started/testing-your-app.html#Bypassing-your-UI
cc @justin808


Tapi.yang:1: warning: RFC 6087: 4.1: no module name prefix string used

This has been fixed with the newer versions of Eagle Uml2Yang tooling (in the baseline since Mar 2017 timeframe)


Scheduled Events on VM Property

MSFT employees can try out our new experience at OpenAPI Hub  - one location for using our validation tools and finding your workflow.

Changelog
Please ensure to add changelog with this PR by answering the following questions.

What's the purpose of the update?

[ ] new service onboarding
[x] new API version
[ ] update existing version for new feature
[ ] update existing version to fix swagger quality issue in s360
[ ] Other, please clarify

When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
If it's an update to existing version,  please select SDKs of specific language and CLIs that require refresh after swagger is published.

[ ] SDK of .NET (need service team to ensure code readiness)
[ ] SDK of Python
[ ] SDK of Java
[ ] SDK of Js
[ ] SDK of Go
[ ] PowerShell
[ ] CLI
[ ] Terraform
[ ] No, no need to refresh for updates in this PR

Contribution checklist:

[ ] I commit to follow the Breaking Change Policy of "no breaking changes"
[ ] I have reviewed the documentation for the workflow.
[ ] Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist

[ ] Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

Adding new API(s)
Adding a new API version
Adding a new service

[ ] Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

[ ] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.

[ ] Removing API(s) in stable version
[ ] Removing properties in stable version
[ ] Removing API version(s) in stable version
[ ] Updating API in stable or public preview version with Breaking Change Validation errors
[ ] Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.

hi @ArcturusZhang could you pls confirm impact to GO SDK? thanks

This PR cann impossibly introduce breaking changes to Go SDK. Some of the reported breaking changes are accumulated from previous PRs, but one of the breaking changes deserves noticing: the package 2021-03-01 was removed.
I assume this comes from the base branch - it is not up-to-date with the master. Previously we released compute/2021-03-01 package with cloud services 2021-03-01 and compute 2020-12-01.
Therefore I assume we could ignore this breaking change alarm. But it would be nice if you could update the base branch up-to-date with master branch @shpa-microsoft @Sandido

@ArcturusZhang merged the latest and now it should not have breaking changes pertaining to base branch. Thanks.

@Sandido Please re-review. The SDK Failure is in creating nuget package - unrelated to my changes it seems

/azp run

/azp run

Thank you @shpa-microsoft , now the changes are very clear - only a new property is added therefore breaking changes are all accumulated.

/azp run

The breaking changes for python are accumulated from previous PRs.

hi @shpa-microsoft @Sandido let me know when the PR ready to merge.

hi @shpa-microsoft @Sandido let me know when the PR ready to merge.

ping again @shpa-microsoft @Sandido

ping again...

/azp run


InputListItem with Switch, Slider and Label layout broken on small screens

OpenUI5 version:
1.42.3
Browser/version (+device/version):
iOS 10, Google Chrome (with Device selection)
Any other tested browsers/devices(OK/FAIL):
none
URL (minimal example if possible):
none
User/password (if required and possible - do not post any confidential information here):
none
Steps to reproduce the problem:

The following layout is broken for the switch, slider and label.

When run on a bigger screen the layout looks like this:

The fragment to generate the layout looks like this:
`<core:FragmentDefinition xmlns="sap.m"
xmlns:core="sap.ui.core" xmlns:commons="sap.ui.commons">

		<Panel expandable="true" expanded="false" headerText="Einstellungen"
			width="auto" class="sapUiResponsiveMargin" id="switchPanel">
			<content>
				<List visible="false" id="switchList"

					items="{
		path: 'switches>/switchStatuses'
	}">
					<items>
						<InputListItem label="{switches>name}" description="{switches>name}"
							icon="sap-icon://lightbulb" iconDensityAware="false" iconInset="false">
							<Switch state="{switches>switchState}" change="handleSwitchChange" />
						</InputListItem>
					</items>
					<headerToolbar>
						<Toolbar>
							<Title text="Schalter" level="H2" />
							<ToolbarSpacer />

						</Toolbar>
					</headerToolbar>

				</List>
				<List visible="false" id="windowBlinds"

					items="{
		path: 'windowBlinds>/windowBlinds'
	}">
					<items>
						<InputListItem label="{windowBlinds>name}"
							description="{windowBlinds>name}" icon="sap-icon://lightbulb"
							iconDensityAware="false" iconInset="false">

							<Slider min="0" max="99" value="{windowBlinds>currentValue}"
								width="100px" change="handleBlindChange" />
							currentValue}">
						</InputListItem>
					</items>
					<headerToolbar>
						<Toolbar>
							<Title text="Rolläden" level="H2" />
							<ToolbarSpacer />

						</Toolbar>
					</headerToolbar>
				</List>

				<List visible="false" id="lights" items="{
		path: 'lights>/'
	}">
					<items>
						<InputListItem label="{lights>name}" description="{lights>name}"
							icon="sap-icon://lightbulb" iconDensityAware="false" iconInset="false">

							<Switch state="{= ${lights>brightnessLevel}>0}" change="handleLightSwitchChange" />
							<Slider min="0" max="99" value="{lights>brightnessLevel}"
								width="100px" change="handleLightChange" />
							brightnessLevel}">
						</InputListItem>
					</items>

					<headerToolbar>
						<Toolbar>
							<Title text="Licht" level="H2" />
							<ToolbarSpacer />

						</Toolbar>
					</headerToolbar>
				</List>

				<List visible="false" id="thermostats"

					items="{
		path: 'thermostats>/switchStatuses'
	}">
					<items>
						<InputListItem label="{thermostats>name}"
							description="{thermostats>name}" icon="sap-icon://lightbulb"
							iconDensityAware="false" iconInset="false">
							latestStatus}">
							<Slider min="16" max="28" step="0.5"
								value="{thermostats>latestStatus}" width="100px"
								change="handleThermostatChange" progress="true"
								showHandleTooltip="true" />
						</InputListItem>
					</items>
					<headerToolbar>
						<Toolbar>
							<Title text="Thermostat" level="H2" />
							<ToolbarSpacer />

						</Toolbar>
					</headerToolbar>
				</List>

			</content>
		</Panel>

		<Panel expandable="true" expanded="false" headerText="Historic Data"
			width="auto" class="sapUiResponsiveMargin" expand="expandHistoricData">
			<content>

				<core:HTML
					content="<div id='chart'>
<svg style='height:300px; width:100%;'></svg>

"></core:HTML>

	</content>
	<beginButton>
		<Button text="Schliessen" press="dialogClose" />
	</beginButton>
</Dialog>

</core:FragmentDefinition>`
It also seems to be a bit dependend on the word wrapping of the item label "Esstisch".
What is the expected result?
One idea what should happen is, that the button should be above the slider and the whole row should be adjusted in height.
What happens instead?
Layout is broken, elements overlap other rows.
Any other information? (attach screenshot if possible)
see above

Hi Christoph,
I tried to reproduce the issue (including within dialog context), but still the problem does not show.
Just a Button on jsbin.com
It looks like there are further conditions that I could not see in the code fragment you provided. Is there a direct link to a setup that can be inspected? Or would you edit the jbin sample above to show the problem?
Thanks,
Diana

JS Bin sample link: https://jsbin.com/dupogetepe/edit?html,output

Hi Diana,
the example code on JSBIN shows for me the same issue, if I switch to the Device Mode of Chrome:

and then to an Iphone 5 with 320x568px.
Kind Regards,
Christoph

Hi Christoph,
I see that indeed this happens when you switch to the Device Mode of Chrome (and device is Iphone 5 with 320x568px). Upon refresh the layout is OK again.
The Chrome browser does not display anymore a warning to refresh the browser when you switch between device and desktop mode, but looks like that was the actual problem. (Because the wrong layout does not occur when you load the sample https://jsbin.com/dupogetepe/edit?output while Device Mode with Iphone 5 with 320x568px is already enabled).
I also tested on a real iPhone5s device and the problem does not occur there as well.

Therefore, do we agree to consider this as false positive :-) ?
Best Regards,
Diana

This is an actual screenshot from my iPhone 5c:

As far as I see it, the Label in your screenshot is not shortened (no ...). That seems to trigger the layout issue.
Shorter Label = no issue, longer label = issue.
So I currently do not agree with the false positive. ;-)
Kind Regards,
Christoph

Hi Christoph,
This is correct. I opened an internal ticket for this issue (#1680262262 for internal reference).
Thanks,
Diana


Rm unused type

Replace Types.Transaction with Types.Transfer
The old compress API is unused now

Got an offline approval from @vaibhavchellani


Local storage setting and rendering

GIVEN a weather dashboard with form inputs
WHEN I click on a city in the search history
THEN I am again presented with current and future conditions for that city

completed


Some mod interaction causing an NPE on room load.

wbfw109 Aug 31 @ 9:59am
https://pastebin.com/GpHk2Jqr
In ascension 20 and Act 1 when I enter the "monster" room, sometimes the error occurs and it force to exit game.

Another instance https://steamcommunity.com/app/646570/workshop/

Fixed in 718e9c66


Release SelectPanel accessibility improvements as a draft component

SelectPanel introduced breaking behavioural changes in v35.8.0 and that caused issues for consumers. So we decided to rollback these changes (see the PR for ref) and release SelectPanel accessibility improvements as a draft component.
cc @siddharthkp @hectahertz @bolonio

What were the breaking changes? I remember @hectahertz making the prop title optional to avoid breaking changes.

Hi @bolonio 👋🏼 it was more like a breaking behavioural  changes as in introducing save and cancel buttons yet we received some feedback from memex team regarding some issues around it. Please see this issue for more.
This is why we decided to move the SelectPanel changes to a draft component and by doing that, we wouldn't be blocking our consumers while we are addressing the reported issues. Please let us know if you still have any concerns. 🙏🏼

Hi!

What is the process for addressing breaking behavioral changes that were introduced to be accessible?

To make sure folks we don't block folks from getting fixes and features in new releases, the process is to clone that component and import it from a different path, and keep both in the library in a non breaking way:
// current component used on production:
import { SelectPanel } from '@primer/react'

// new accessible  component meant to replace current component:
import { SelectPanel } from '@primer/react/drafts'

We don't want to default to a less-accessible experience.

That's the bug/feature with this approach. Each instance of the current SelectPanel can be moved to the new SelectPanel one at a time, making sure it works and is accessible, while also keep up to date with other updates.
Unfortunately, for a some time, new instances of SelectPanel might accidentally be built on the old one, because that's the default. We solve this by adding a note on the docs to use the new version from drafts, but folks don't always look at the docs before creating a component.
In the next major version, we "promote" the new accessible Select panel to be the default, while still keeping the old version for teams that have not invested the time to upgrade.
// accessible SelectPanel, now the default
import { SelectPanel } from '@primer/react'

// old component still available under deprecated
import { SelectPanel } from '@primer/react/deprecated'

Thank you @siddharthkp ! I appreciate the clear process here.
When it comes to evaluating the feature changes that are causing the "draft" state, what is the process?

Hi everyone, I would like to give some context here about those "breaking behavioral changes that we introduced to the SelectPanel to be accessible".
We, @hectahertz and I, did the Primer React SelectPanel - A11y engineering review with the help of our accessibility consultant @jscholes, and there are a couple of things related with those "behavioral changes" I would like to clarify.

Before these changes, SelectPanel would call onSelectedChange every time the user would select or deselect an item.
The UX will change with the recommended layout, as there is a pair of Save and Cancel buttons. SelectPanel should call onSelectedChange only after the user performs a save, and discard the modifications altogether if the user cancels or closes the SelectPanel.
We strongly discourage the addition of more granular callbacks, so we can keep the control of the pre-saving state local to the component. This approach also keeps the API virtually the same, so upgrades to the new version should be mostly straightforward.

Source: https://github.com/github/primer/issues/1021

The elements of the list within the SelectPanel act like checkboxes, both for single and multi selection. Checkboxes don't perform actions when checked, they just keep the selection until the save button is clicked.
Someone said in this comment in the memex / primer weekly sync, "this will change how users have to use this selector only in Memex (currently), which will be a frustrating user experience.".
We are aware that there are several places in dotcom where we have behaviours that we don't recommend, even if they could be frustrating for non-disabled users, but the component/feature/functionality would not be accessible.
I'm not against "promoting" the new accessible Select panel to be the default, while still keeping the old version for teams that have not invested the time to upgrade. But at the very end, every team will have to implement accessible components to have an accessible platform, and that would request some behavioral changes, since some of the current ones don't match with some of the principles of web accessibility.
As usual, we are always open for discussion, feel free to contact us in slack in #accessibility or attend our Accessibility Office Hours. We recommend you to book a slot in the session you're attending. You can do that searching for that day's session using this search link and adding yourself.

Hi everyone,
Sorry my wording on the ticket description was misleading.
The main reason we need to revert the SelectPanel changes is due to our promise not introducing any breaking changes in the minor releases. (Also following Semver) However, mistakenly, we released SelectPanel changes with a minor release so we need to take this back to unblock folks and follow Semver standards. The rest is as Sid mentioned, we will release the SelectPanel with all the improvements in the next major release. Please see our list for the next major v36.x
Thank you for your understanding 🙏🏼 And as always, please let us know if you have any concerns.

@broccolinisoup - This makes total sense. Thank you for clarifying, and let us know if you need the Accessibility Team to support.

Thank you!! @inkblotty

Thanks @broccolinisoup for the explanation :) As @inkblotty said and repeating myself:

As usual, we are always open for discussion, feel free to contact us in slack in #accessibility or attend our Accessibility Office Hours. We recommend you to book a slot in the session you're attending. You can do that searching for that day's session using this search link and adding yourself.

Thanks everyone. Pinging @hectahertz here as a reminder when he's back from being out so we can chat about where this should sit in the priority queue.

I'll leave here a link to a related discussion in the following issue:

https://github.com/primer/react/issues/2281

Keeping this issue open until we release the remediations in the next major release

@siddharthkp is this issue still relevant to the select panel work or not so much anymore?


turn of write/edit functionality

Is it possible to turn off all edit functionality and keep only read/select functionality

@mg03 currently no... are you talking about UI on/off setting or in config.json or somewhere else?

seem like a good practice for you, @Tom2277?


Respect JVM http proxy settings when using Feign.

Closes #226

rerun unit tests please

rerun unit tests please

LGTM, this is good. I think @iyanuobidele had a use case similar to this.


Remove dead branch from TestHTTPS.test_ca_dir_verified

Resolves #1164.

So the @onlyPy279OrNewer decorator should be removed?

Codecov Report

Merging #1190 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #1190   +/-   ##
======================================
  Coverage     100%    100%
======================================
  Files          21      21
  Lines        1975    1975
======================================
  Hits         1975    1975

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c82139e...7f72e96. Read the comment docs.

This is a tricky situation. Basically, the branch is dead in the sense that the ability to specify a CA directory does not exist prior to 2.7.9, so the whole test cannot run without that feature backported. While it's possible that a distro has backported the feature, I personally doubt it.

I think what @alexwlchan is pointing out is this else branch is unreachable, no matter the python branch, due to the decorator. This test is only executed on Python 2.7.9+.

@nateprewitt That's not entirely accurate: it's possible that downstream repackagers are doing something wacky. But as I said, I doubt it. :wink:

Rebased against master, and I’ve amended the commit message to make it clearer why I think this code is dead.


Can CustomHeadRender be used to set id ?

Can customHeadRender be used to set a column's id attribute? Would be helpful if there were some examples similar to customBodyRender examples in the README.
Very new to Node, React, and mui-datatables ... while I'm aware the project doesn't currently support individual column widths, I'm trying to set a column's id attribute and then use the respective value to style/set the column width. Issue #92 'how to set column width' suggested using nth-child() selector in the styling, but that does not work in my case because i have hidden columns that can be toggled on/off, and so the nth-child position can change as the user show/hides columns.
Expected Behavior
Set a column's id attribute
Current Behavior
Columns do not have the option to set id

try this:
const myTheme = createMuiTheme({     overrides: {         MUIDataTable: {             responsiveScroll: {                 maxHeight: 'none',             },         },         MuiTableCell: {             root: {                 padding: '5px 20px 5px 10px' // <---             },         },         MuiTableRow: {             footer: {                 height: 40             }         },         MuiTablePagination: {             toolbar: {                 height: 40,                 minHeight: 40             }         },         MUIDataTableBodyCell: {}     }, });

@KamilKafara could you explain how your code helps with the id value? did you mean to insert a comment or explanation at the // <--- ?


Github Enterprise Server Does Not Support Kubernetes and Helm Files

Hello,
I am trying to use Dependabot to update Docker image references in Kubernetes Deployment manifests as well as Helm values files. This works like a charm with repositories created under my private github.com but fails at my company that uses GitHub Enterprise Server 3.7.5. I am using a setup that is identical to my own private repositories which consists of a dummy Kubernetes Deployment manifest as well as a dummy Helm values.yaml at root level. The dependabot.yml is configured as follows:
version: 2
updates:
  - package-ecosystem: "docker"
    directory: "/"
    schedule:
      interval: "weekly"

Now, it complains about a Dockerfile being missing:

Well, this is not wrong but this is not a problem in my github.com repo. If I add a Dockerfile, it won't complain anymore but will only update image references in said Dockerfile and completely ignores the Kubernetes manifest as well as the values file.
It seems to somehow use a Dependabot version that does not provide Kubernetes and Helm file support (yet). Naturally, I contacted my system administrators and they triple-checked every setting and they look correctly. GitHub Connect is also enabled to ensure access to the latest actions. So, why does the behaviour of our GHES Dependabot differs so much from the one used in my private cloud account? Additionally am unable to find out which exact Dependabot Core version is used under the hood. How/where to get this information?
We are using runner version 2.296.2.

Hei @imRentable!
This is more of a customer support question, than an issue with the dependabot-core open source library, so you will get better answers by going through support and the support team will be better equipped to help you.
I think getting a newer version of dependabot-action on your server may help with this. You can do that using actions-sync. But again, if you need help with any of this, please contact support and they'll be happy to get you up and running :smile:

@deivid-rodriguez Thank you, will do.


Use SSHJ implementation by default to support ed25519 keys

System information:

Operating system (distribution) and version – doesn't matter (in my case, latest macOS)
DBeaver version ersion <IP_ADDRESS>203060510)
Additional extensions

Connection specification:

Database name and version Postgres, doesn't matter
Driver name Postgres driver (default one)
Do you use tunnels or proxies (SSH, SOCKS, etc)?  SSH port forwarding – it works well but only with RSA or .pem keys. If I use ed25519, it fails

Describe the problem you're observing:
invalid privatekey: [B@3e17e4ee – see screenshot:

Steps to reproduce, if exist:
Straightforward – just use an ed25519 key
Include any warning/errors/backtraces from the logs

N/A
Additional info
https://mkyong.com/java/jsch-invalid-privatekey-exception/ and https://github.com/dbeaver/dbeaver/search?q=JSch&type= tell that the problem is most likely in the lib JSch that doesn't support ed25519. At the same time, this format is becoming more and more popular, and our (Database Lab) users start to complain about the inability to work with Postgres thin clones from DBeavier when SSH port forwarding is a requirement. Please fix it.

Hello, @NikolayS! Have you tried to switch to another ssh library used to establish connection tunnel? It can be done in Advanced settings:

@E1izabeth thanks! It works well (however, without you, I wouldn't go there – so the problem will remain for the majority of users)

Maybe SSHJ could become the default?

Done.


[WIP]Include riscv v0p10 header when building C910V with T-Head toolchain

from a comment by zejianzhang1982 on closed issue #4029

Apparently the presence of this header depends on the version of the T-head toolchain, or possibly even the Linux kernel version on the build host. Trying to clarify this...


Migration guide/ adapted README for 'css' prop removal

Our project build just broke because the css property is no longer supported as of v6.0.0 recently released (commit 2667fa6 to be specific).
The README still mentions 'css (string|object)' under properties, can this please be updated to reflect the current supported properties and would it be possible to provide a migration guide for how to keep using the css property?
I am trying to fix our code now but it is not clear to me what one should do to keep using the css property as before, which dependencies are needed, which configuration changes etc...
Thanks!

Thanks, the v6 beta releases included the css prop because styled-components hadn't released support for it when I started migrating this library to the rebassjs org. To enable support for the prop, you'll need to use the babel plugin from either styled-components or emotion. This is an example of a userland feature that went upstream, so hopefully it doesn't break your build once you have the babel plugin set up. From the Rebass docs: https://rebassjs.org/props#css-prop (scroll down, link is broken) and docs from styled-components: https://www.styled-components.com/docs/api#css-prop

The css prop is back in https://rebassjs.org/reflexbox without the need for Babel configuration


Else path not taken

Hello
I ran into a weird issue: when I have the following setup,
if(!array.length) {
  return null;
}

return doSomething();

It reported that else path is not taken:

I am testing the else part too, by asserting doSomething is called. I refactored the code to the following:
if(!array.length) {
  return null;
} else {
  return doSomething();
}

which ended up with following report:

Once again I refactored the code:
let returnValue;

if(!array.length) {
  returnValue = null;
} else {
  returnValue = doSomething();
}

return returnValue;

which resulted in 100% coverage. Can I please know what is wrong with first or second code pattern? why would it say that the else path was not taken, even though there are 'hits' on those lines of code? is this a bug or by design? Though I can somewhat digest the first one, I would say the second one is a real bug!
(I have cut many things inside the braces in the images to simplify stuff, the code given is the (pseudo)real one)

Same thing happens in nyc which IIRC uses the same core.


error: Optional(Starscream.HTTPUpgradeError.notAnUpgrade(403))

Trying to connect to a protoo WebSocket server and receiving error: Optional(Starscream.HTTPUpgradeError.notAnUpgrade(403)).
My code.
var request = URLRequest(url: URL(string: wsUri)!)
request.setValue("chat,superchat,chatmessage", forHTTPHeaderField: "Sec-WebSocket-Protocol")
    // Allow self-signed certificates
    // Load certificates and public keys into an app bundle, use the builtin pinner and TrustKit.
    let pinner = FoundationSecurity(allowSelfSigned: true) // don't validate SSL certificates
    self.socket = WebSocket.init(request: request, certPinner: pinner)
    // Handle socket delegate methods on the global thread (semaphor will lock if not set to global..)
    self.socket!.callbackQueue = DispatchQueue.global()
    self.socket!.delegate = self
    self.socket!.connect()

The socket is trying to connect but the event viabilityChanged fired with value true and error mentioned logged in the console output, any help to fix this?
The server is printing protoo-server:WARN:WebSocketServer _onRequest() | invalid/missing Sec-WebSocket-Protocol

This was a server custom Sec-WebSocket-Protocol requirements


Added mouse wheel handling for Forms.UWP

This is for #449. I tried to implement it as easys as possible. I couldn't test it. Didn't get, how to do this.
An alternative would be to use djgtrams suggestions here. He uses Effects to get the wheel events.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: charlenni sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

source/SkiaSharp.Views.Forms/SkiaSharp.Views.Forms.Shared/SKTouchEventArgs.cs
:white_check_mark:Succeeded

source/SkiaSharp.Views.Forms/SkiaSharp.Views.Forms.UWP/SKTouchHandler.cs
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

This is good, thanks. I will review and merge.

I just have a question for Android... I believe that they support mouse... somehow... I did a quick google and saw this: https://stackoverflow.com/questions/11024809/how-can-my-view-respond-to-a-mousewheel
Has anyone ever used a mouse on an Android powered device? Do they even make Android tablets still? Anyway, if anyone has some device that supports mouse and knows something, feel free to comment :)

I am going to merge. If anyone comes up with an Android with a mouse, I'll add that implementation to Android's code.

OPS Build status updates of commit 80bf244:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

source/SkiaSharp.Views.Forms/SkiaSharp.Views.Forms.Shared/SKTouchEventArgs.cs
:white_check_mark:Succeeded

source/SkiaSharp.Views.Forms/SkiaSharp.Views.Forms.UWP/SKTouchHandler.cs
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Are New Minecraft 1.16+ work with this?

moved to https://github.com/PrismarineJS/pocket-minecraft-protocol/issues/34


System.ObjectDisposedException: Cannot access a disposed object. Object name: 'Session'.

recently, this error frequencly occured and led to `Process finished with exit code -532,462,766..
Unhandled exception. System.ObjectDisposedException: Cannot access a disposed object.
Object name: 'Session'.
   at YesSql.Session.CheckDisposed()
   at YesSql.Services.DefaultQuery.Query`1.FirstOrDefaultImpl()
   at OrchardCore.Users.Services.UserStore.FindByNameAsync(String normalizedUserName, CancellationToken cancellationToken)
   at Microsoft.AspNetCore.Identity.UserManager`1.FindByNameAsync(String userName)
   at My.Module.User.Controllers.UserSpaceController.QueryUser(String username) in K:\My.Module.User\Controllers\UserSpaceController.cs:lin
e 47

related code
        protected async void QueryUser(string username)
        {
            var user = await _userManager.FindByNameAsync(username) ;

        }

what is possible to cause this error?

maybe sometime the username is null.


Redesign Monthly Plan Confirmation Page

This PR redesigns the monthly-plan-confirmation page based on the figma design.
Screenshot
Desktop

Mobile

@znarf I think the error and processing state of this page needs a better design too. The current doesn't look good enough I think.

@flickz Could you rebase, fix the conflicts and carefully check?

Codecov Report

Merging #213 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #213   +/-   ##
=======================================
  Coverage   50.22%   50.22%
=======================================
  Files          14       14
  Lines         227      227
  Branches       41       41
=======================================
  Hits          114      114
  Misses         91       91
  Partials       22       22

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 920fa60...825b50a. Read the comment docs.


First window.setTimeout on the page returns 0

It appears that the first window.setTimeout call on a jsdom page returns 0 instead of 1. This breaks code like if (timeoutID) { window.clearTimeout(timeoutID); }. Specification says "[return value is] a user-agent-defined integer that is greater than zero" (W3), "The returned timeoutID is a numeric, non-zero value" (MDN).
If I'm not mistaken, this line has the bug, it should be ++latestTimerId instead of latestTimerId++ (or latestTimerId should start from 1).

Nice! Pull requests (with tests) welcome.


using get mapping, explicit on GET

Coverage remained the same at 94.082% when pulling c35330fe3427756ab92af0992d526de9943039cf on get-mapping into b0049e0f534217faf31f119beced61075e5cc0f7 on master.


CI: Add trivy support

Add trivy scan to the CI

coverage: 34.878%. remained the same
when pulling ac1e44fc8a4c7452e2458793242f5ad28f774dec on add-trivy
into 36a2dd6dbd8f5f693a214ae396e0541b2384361f on main.


Is it possible to query a local working copy of the ontology?

I haven't totally deciphered the Makefile, but I'm guessing queries are directed at a web server somewhere?  In any event, my local changes to the ontology file aren't returned by queries.  Is there a way to query the local turtle file?

No, I'm afraid not, because we want information from the closure of the Turtle file that is computed by the server.
It would be possible to precompute and store it, but that's not done now.
Doing make server should give you a running server and make the queries go through.
I don't have any great ideas about how to ensure that the container server is started up when needed; if you do, please let me know. (e.g., the container server might be remote, so we can't just always start it up when we load the container API)


Configure method behavior for derived state is not well documented

The behavior of configure method for derived state (i.e., the state defined in yaml file with other state as base) was not well documented and unclear (at least to me)
By adding a print statement and trying it, I understood as follows. The configure method is called repeatedly with passing the configuration of each state to the parameters of the configure method in order from the basic state to the derived state.
If this understanding is correct, it would be helpful if it were clearly stated somewhere in the following lines or tutorials.
https://github.com/jrl-umi3218/mc_rtc/blob/4609530431e5177e503ae7ea7d5d011d0dd06ebe/include/mc_control/fsm/State.h#L126-L131
I have one more question. When transitioning to the same state, is a new instance of the state created? That is, is the destructor of the old state instance called, and are the members of the new state instance initialized?

If this understanding is correct, it would be helpful if it were clearly stated somewhere in the following lines or tutorials.

It is correct. I am going to elaborate a little here on why this is like this and how it could be changed.
This documentation states that:

configure is used to configure the state; one important feature to consider and understand with the FSM implementation is that new states can be created by specifying a different configuration of an existing state. This function will thus be called multiple times;

And the doxygen does say:

This might be called multiple times.

But clearly, the doc should be clarified and maybe the default behavior should be changed.
The original intention behind this behavior could be used to circumvent the limitations/rules of mc_rtc::Configuration::load(const mc_rtc::Configuration &). For example this could allow to extend a list rather than overwriting it.
However in practice:

I don't think anybody is actually doing that (and actually doing it might be misleading because people have some expectation of what the YAML composition will do)
this leads to badly written configure function (e.g. always expecting all the data to be available)
or this leads to a lot of superfluous work in the configure method (setting some parameters multiple times)

My personal go to implementation is:
void MyState::configure(const mc_rtc::Configuration & config)
{
  config_.load(config);
}

void MyState::start(mc_control::fsm::Controller & ctl)
{
  // Use config_ from here
}

So I can see two ways to evolve it in the future:

Make this the default implementation of configure; we lose no flexibility but the vast majority of users won't need to bother with implementing configure anymore
Forego the configure function all together (we keep the function around but it is not called inside mc_rtc) and just load the successive configuration in the state loader then provide this final configuration to the state; we lose the flexibility (that's not super useful) but state loading will be greatly simplified

I have one more question. When transitioning to the same state, is a new instance of the state created? That is, is the destructor of the old state instance called, and are the members of the new state instance initialized?

Yes. The FSM executor always does this regardless of the previous state. When a state ::start is called it's always a clean slate.

@gergondet Thank you for the answer.

My personal go to implementation is:

Thanks. After I understand this behavior, I've just done completely same thing just before seeing your comments ;)
(You can also see previous hotfix in the removed lines.)
https://github.com/mmurooka/Motion6DoF/commit/34fa4c196d55e381b26e814769ba0a4317b65ac1

This documentation states that:

So I just missed it, but it was already in the Tutorial. But it is a little difficult to understand the current behavior from this description alone.

However in practice:
I don't think anybody is actually doing that (and actually doing it might be misleading because people have some expectation of what the YAML composition will do)
this leads to badly written configure function (e.g. always expecting all the data to be available)
or this leads to a lot of superfluous work in the configure method (setting some parameters multiple times)

I agree :+1:


[Broker] Fix call sync method in async rest api for internalGetBacklogSizeByMessageId

Motivation
Avoid call sync method in async rest API for PersistentTopicsBase#internalGetBacklogSizeByMessageId.
Modifications

Use async instead of sync method.

Does this pull request potentially affect one of the following parts:
If yes was chosen, please highlight the changes

Dependencies (does it add or upgrade a dependency): (no)
The public API: (no)
The schema: (no)
The default values of configurations: (no)
The wire protocol: (no)
The rest endpoints: (no)
The admin cli options: (no)
Anything that affects deployment: (no)

Documentation
Need to update docs?

[x] no-need-doc

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks


WIP Skip the failing test.

Let's see if this can make k8s integration test green first.
https://github.com/istio/istio/issues/12480

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: incfly
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: ozevren
If they are not already assigned, you can assign the PR to them by writing /assign @ozevren in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

tests/integration2/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/hold wait-for-test-status

@incfly: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests-cni.sh
7d9e62b557f99ba47191eb8a60b55d5839c48117
link
/test e2e-simpleTests-cni

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@incfly: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests-cni.sh
7d9e62b557f99ba47191eb8a60b55d5839c48117
link
/test e2e-simpleTests-cni

prow/istio-integ-k8s-tests.sh
7d9e62b557f99ba47191eb8a60b55d5839c48117
link
/test istio-integ-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

The k8s-integration test now fails at mixer, also due to istio deployment fail :)
I think it's due to the first test suite needs to wait the istio-system level component a bit longer, and the rest tests will benefit from previous waiting automatically and then pass...
We should increase the time to wait for istio-system. Will send a PR, closing this one.

@incfly: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests-cni.sh
7d9e62b557f99ba47191eb8a60b55d5839c48117
link
/test e2e-simpleTests-cni

prow/istio-integ-k8s-tests.sh
7d9e62b557f99ba47191eb8a60b55d5839c48117
link
/test istio-integ-k8s-tests

prow/istio-pilot-multicluster-e2e.sh
7d9e62b557f99ba47191eb8a60b55d5839c48117
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


docs/.vitepress >> custom base path & root

Hello.
Project Structure

The documentation is created using VitePress and is located in the /docs folder.
The project documentation will be published at https://demo.com/my-demo-folder/
In other words, the path is built relative to the '/my-demo-folder/' folder.
Config docs/.vitepress/config.mts
import {defineConfig} from 'vitepress'
import { whyframe } from '@whyframe/core'
import { whyframeVue } from '@whyframe/vue'

export default defineConfig({
  base: '/my-demo-folder/',
  vite: {
    plugins: [
      whyframe({
        defaultSrc: '/my-demo-folder/frames/default'
      }),
      whyframeVue({
        include: /\.(?:vue|md)$/
      })
    ]
  }
})

With this configuration, there is an issue

If you build the project and view it, everything works

The essence of the problem is in this code

With this approach, it will work

I'm sorry, but I can't do it in the near future

Ok. I add PR #35


Some SVG images not importing

SVGs in <svg> tags aren't being imported.
Example:
See Login button icon and navbar arrows on https://onfido.com/kyc/

Ah interesting, looks like that's because the SVG contents are in shadow dom. Will take a look into supporting shadow dom shortly

I also found a bug from that URL where the text formatting is all screwed up by including html whitespace when it shouldn't, fixing that now as well :)


Use atom's new scoring algorithm for git-plus:menu

A while ago Atom introduced a new, much improved sorting algorithm for its Command Palette and other menus by switching to fuzzaldrin-plus, and recently made it the default.
I wish the Git Plus Menu (Cmd+Shift+H) used the same algorithm so, for example, entering S into the menu's search field would show Show, Status, Stage etc. on top instead of Tags and Push. This would make it more usable and in-line with the current Atom defaults.

:+1:


Put libjsoncpp error in README

Is it worth putting a link to the libjsoncpp error on the 'Known Issues' wiki page in the readme?
I am almost on the verge of getting off the mailing list because every other issue is the same!

To be honest, I don't think it won't change anything if we did put it there. It already refers to the wiki, and SUPPORT.md should show before creating a new issue which also suggests looking at the wiki. People just can't be arsed to read any of it.


How to install it manually? Base models?

Environment

OS: Windows 8.1
Python Version: 3.9.8
Hardware: Acer Aspire Notebook / Intel

Issue Description:
Hello, i tried exe install and bat install, but failed. These are steps i found at docs.applio.org. Done step 1 but in step 2 which base models to download? (in .exe i took DiscardVirtualMemory error, in .bat i took Admin Privilages error) thx by now

Clone the repository
git clone https://github.com/IAHispano/Applio-RVC-Fork
Download base models
https://huggingface.co/lj1995/VoiceConversionWebUI/tree/main
In the installation script you can check where you should place each file/folder:
pretrained_v0, pretrained_v2, uvr5_pack, uvr5_weights, ffprobe.exe, ffmpeg.exe, hubert_base.pt and rmvpe.pt
Install dependencies (Python 3.9.8):
pip install -r ../assets/requirements/requirements.txt

Failed step one too.... Any advices how to install it? i need tts :(


fix regonline links

great fix, so it turn out that the bottom when used in that way doesn't work

Ok I just spotted an issue, you need to do this fix on the pug page

since that html page is autogenerated on build


React-hot-redux-firebase  - ChatX single chat room

For the job interview, i had to make a chat in react-redux-firebase.
I fork your project to start with a functional basis.
I create an account on Firebase to get my personal database.
And on your project, i create a new view room, which make send a message and read all message of others users.
And on your project, I create a new view "room", which allows to send messages and to read all the messages of other users.
It's a single chat room.
Thank's you for your job.

Close


[Suggestion] Be able to use command blocks for very long NBT data when doing isometric renders

Hello! Using this mod and it is very awesome so far.
However, I have ran into some issues where I am trying to create a render of an entity or item with lots of NBT tags and the chat bar does not like it due to the character limit. I was hoping if there was a way to be able to use a command block to execute the very long command.

Closing this as I found a mod which allows an extended character limit for chat.


Add CDNJS version badge in readme

This will add the badge to show its version on CDNJS and also link to its page on CDNJS!

@shawnbot , you're welcome


Force Vocals Event

Describe your problem here.
I’m trying to make an event that forces the vocals to play so that voice lines can play even if you just missed. However, for some reason, I still can’t hear the voice line after missing, even though I set the same exact property that the game does.
The code:
function onEvent(name, value1, value2)
	if name == 'Force Vocals' then
		setProperty('vocals.volume', 1);
	end
end

Are you modding a build from source or with Lua?
Lua
What is your build target?
Windows x64
Did you edit anything in this build? If so, mention or summarize your changes.
No.

on update function

local fv = false

function onEvent(name, value1, value2)
	if name == 'Force Vocals' then
		fv = true
	end
end

function onUpdate(elapsed)
     if fv then
          setProperty('vocals.volume', 1);
     end

use noteMiss(), you don't need or want this running every frame

This is what worked for me:
local forceVocals = false;
function onEvent(name, value1, value2)
	if name == 'Force Vocals' then
		forceVocals = true
	end
end

function onBeatHit()
	if forceVocals == true then
		setProperty('vocals.volume', 1);
		forceVocals = false;
	end
end

I had to set forceVocals back to false after so that it would only stay once.

That still triggers unnecessarily

I want it to trigger at the moment (or soon after), not on the next miss, because what if the player didn't miss and it triggers way later? This is good enough for me.


Fix the dashboard UI issues

Fixes:

https://github.com/nearprotocol/near-explorer/issues/33
https://github.com/nearprotocol/near-explorer/issues/32

Feel free to squash and merge the commit.


Edit section header and TOC to have built-in

#Change Table of Contents and Section Header
We don't want to refer to old gadgets as "legacy" so we are changing the verbiage to "built-in"
How to use
We need to test the staging website to make sure the links in the TOC still work and that the word "legacy" is replaced by "built-in"
Testing done
I tested on StackEdit and it works there, but I need to test on the staging website once it's automatically created.

@mauriciovasquezbernal please feel free to review and merge at your convenience.


vulkaninfo: Make -j= work

The help text indicates that -j= should work, but was never implemented when the code was refactored.
Partially solves #840

CI Vulkan-Tools build queued with queue ID 26863.

CI Vulkan-Tools build # 1096 running.

CI Vulkan-Tools build # 1096 passed.

I went ahead and cherry picked it onto the sdk-1.3.261 branch. Small fix but its good to have it in.


Small fix: Validate input formatter

Validate input formatter. Only the input variable should be present

invalidated by this PR


Request for additional parameters for a higher precision on somatic variant callsets

There has been a need to identify case-specific variants especially in the context of tumor/normal pairs so I'm glad to see a tool filling in this need. Thank you!
I want to highlight something that I came across while testing your tool. I ran savana on hg002 and hg001 pacbio whole-genome sequencing data with hg002 labeled as tumor and hg001 labeled as normal for testing purposes (minimum read support = 3 and minimum mapping quality = 20). I found a case that might help savana potentially improve its somatic variant calling performance. Savana reports no read support for chr16:46390833 deletion in hg001 even though there is one read supporting the deletion (see savana vcf row below). This read also has a mapping quality of 60. I suspect the performance of the tool will depend on the coverage of the control sample.
chr16	46390833	ID_384_1	c	c[chr16:46390991[	.	PASS	SVTYPE=BND;MATEID=ID_384_2;NORMAL_SUPPORT=0;TUMOUR_SUPPORT=29;SVLEN=158;BP_NOTATION=+-;ORIGINATING_CLUSTER=a3e06949c29c44b297520e8f76cc7a0a;END_CLUSTER=97a07de2c66d4bacbafe8f7188e15a2b;ORIGIN_STARTS_STD_DEV=8.94;ORIGIN_MAPQ_MEAN=52.9;ORIGIN_EVENT_SIZE_STD_DEV=8.95;ORIGIN_EVENT_SIZE_MEDIAN=158;ORIGIN_EVENT_SIZE_MEAN=159.66;END_STARTS_STD_DEV=0.36;END_MAPQ_MEAN=52.9;END_EVENT_SIZE_STD_DEV=8.95;END_EVENT_SIZE_MEDIAN=158;END_EVENT_SIZE_MEAN=159.66;TUMOUR_DP=71,72;NORMAL_DP=2,1	GT	0/1

For a more stringent somatic variant identification, would it be possible for savana to take another set of parameters for normal samples? For example, I want to supply a less stringent number of supporting reads (e.g. 1) and a lower mapping quality (e.g. 5) for normal samples to increase sensitivity on variant detection for normal samples, coupled with a more stringent number of supporting reads (e.g. 7) and a higher mapping quality (e.g. 20) for tumor samples. I think this will help to improve the precision of your somatic variant detection. Thanks!

Hi there, apologies for the delay in getting back to you.
Yes, as @yashcrux mentions, I would recommend using the Classify by Parameter File section in the README to set custom thresholds which work best for your use case.


Switch back to Valhalla, and add OpenTripPlanner

I just found this: https://github.com/graphhopper/graphhopper/issues/1743 and seems like this might not be a priority for the graphhopper team. I know OTP supports transit shapes. I was also not as impressed with Graphhopper for bicycle routing as I have been with Valhalla.

I'm going to plan on adding OTP first, then switching out GraphHopper for Valhalla if and only if OTP doesn't fit our needs by itself. It's capable of all routing modes I care to support. I fully expect to eventually decide that adding Valhalla back is necessary, but OTP should be okay for at least a little while.

Implemented in #20


Translate storage/volume-snapshot-classes.md in Korean.

This is a Feature Request
What would you like to be added
Translate storage/volume-snapshot-classes.md in Korean.
Why is this needed
The following files are not translated into Korean.

[ ] /en/docs/concepts/sstorage/volume-snapshot-classes.md

Comments
Page to update: https://kubernetes.io/docs/concepts/storage/volume-snapshot-classes/
I am translating this document.
The translated document will be submitted to dev-1.17-ko.4 or dev-1.17-ko.5 branch.
/language ko

/assign

/close


For example I can install in every python module pytest-cov and redefine in command line %pytest macro to perform coverage test for all modules even if exact module source tree has no single test unit.
This opens gates to test all modules in env of other modules version used in whole distribution.
With that I have higher chance to deliver whole set of modules in consistent state.
And again .. tox very often have testing is performed in exact versions of other modules which are not used at all in whole distribution. Using ox as well in many cases means downloading well archives from pypi and I'm trying to develop  build procedures which will be possible to use on the system which is cut off from access to the public network,
Such thing like above is not possible to have with tox ..

Reason for that as I'm trying to test all python modules using pytest.

In other words, you are rudely refusing to use a package the way the authors want you to.  I don't want to deal with this.  If you make a PR that makes the tests run with just pytest, I will review it. I am not going to do that work.

In other words, you are rudely refusing to use a package the way the authors want you to. I don't want to deal with this. If you make a PR that makes the tests run with just pytest, I will review it. I am not going to do that work.

Please try to have look on that from another angle:

distribution A packages python module X and it builds it in env of modules from A
test suite passes because it tests module A in env of modules downloaded as .whl archives from pypi
actual module X installed in env of modules from distribution A is failing.

Possible? 🤔
Issue is that pip and pypi provides only versions of modules served on pypi.
Q: what happens when someone will spot serious issue and it will be no around module maintainer which can as ONLY person which can push new version to pypi?
SPOF/kaput/disaster .. isn't it ?
If you will look again on my spec file you can find that I'm using not sdist file from pypi but tar ball autogenerated from VSC tag. With that I have 100% guarantee that I'll be able to add single line in spec file like
Patch:    %{VCS}/commit/<hash>.patch#/%{name}-this-is-very-important-censored-fix.patch

and push new package to build.
Fedora already started following the same path.
And here is stat how often I'm using VCS patches only in case of python modules
[tkloczko@pers-jacek SPECS]$ ls -1 python-*|wc -l; grep Patch:.*%{VCS} python-* |wc -l
1134
601

Here how often I'm already using VCS tar balls in case of python modules packages.
[tkloczko@pers-jacek SPECS]$ ls -1 python-*|wc -l; grep Source:.*%{VCS} -l python-* |wc -l
1134
1062

pip and pypi NEVER been designed to handle very quick fixes.
In such conditions use OS level package manager like rpm/dpkg/Solaris IPS/SySV pkg/BSD* PM/Whatever-Elese is ONLY option. isn't it?
Sadly we are living in not perfect world in which we are dealing with OBLY not-enough-testes-software.
In such world time and overall COST of fixing issue is really critical.
In other words I'm not refusing anything. I'm trying to assemble distribution which will have many design assumption about which so far no one have been even thinking,
Those assumptions makes broader/huge sense which at the same time completely NOT relevant to every package source tree maintainer .. at all, and there is no here contradiction. Isn't it?
With full respect .. if someone will accept those conditions it is not matter of refusing something .. really.
Look .. I'm already IT eng with almost 3 decades long carrier and as almost last decade I've spent working as contractor I saw so many strange/fricking/bizarre cases that for me accepting those assumptions is result of that experience.
After so long time I've started things on "what needs to be done to be able at least avoid some of those bad cases? 🤔".
And going back to 'coverage` failing units using pytest.
As those units fails are result of using a bit different methodology, and are not exposing actual module code issues for me those fails are fine (at least for now).
I understand that out goals may look as orthogonal however at least it would be good to cooperate on those fields pn which we are playing using the same bits .. only this and nothing more 😃
If you would agree that I would be able at least under this ticket drop time to time some updates for now it would be great.
Maybe if I would be able to fix other more important thing with other packages I'll try to prepare some PR which would allow test coverage without checking this module testing procedure I promise that I'll create such PR.
Sorry for such long comment .. EOT (if you will not have any other comments).

Please stop commenting on closed issues.


Iox #208 additional functionality for cxx string

@FerdinandSpitzschnueffler General question, are there test planned for the new API functions like concatenate()?

@FerdinandSpitzschnueffler General question, are there additional tests planned for the new API functions like concatenate()?

Ok i was looking not good enough into the PR, tests are there.

On line 194 in string.inl:
It seems that the check for strSize = 0 is missing which could cause trouble in the memset call. Maybe you can add a check for it too.

On line 194 in string.inl:
It seems that the check for strSize = 0 is missing which could cause trouble in the memset call. Maybe you can add a check for it too.

Size 0 is ok, but the passed pointer could be a nullptr and that's a problem. I'll add a check.


Add proxy support for http operations

[ ] pip
[ ] wget
[ ] yum
[ ] git

Yum doesn't support proxy via command line

Git doesn't support proxy via command line

wget module does not support proxy (https://bitbucket.org/techtonik/python-wget/issues/9/proxy-support)

Pip supports it via command line, and already implemented

We maybe able to use set the env variable on the subprocess for http_proxy on linux and HTTPS_PROXY on windows