bug:  ion-checkbox is blank only appear if checked (Only Tablet )

Bug Report
Ionic version:

[x] 4.x
Current behavior:
ion-checkbox is blank only appear if checked (only in Tablet )
Android Version 6.0.1
SM-T705M
800 x 1280

Expected behavior:
ion-checkbox box must appear checked or not checked

Steps to reproduce:

Create a ion-item with a checkbox at start with a label
Related code:

<ion-item href="https://ionicframework.com/docs/">
<ion-checkbox slot="start" ></ion-checkbox>
<ion-label>Ionic Documentation</ion-label>
</ion-item>

Other information:
Android Version 6.0.1
SM-T705M
800 x 1280

Ionic info:

Ionic:

   Ionic CLI                     : 5.4.1 (C:\Users\xxxx
![Screenshot_2019-10-08-10-43-24](https://user-images.githubusercontent.com/3900919/66401471-96d0d200-e9b9-11e9-974d-fd1daf5ac2a5.png)
\AppData\Roaming\npm\node_modules\ionic)
   Ionic Framework               : @ionic/angular 4.10.1
   @angular-devkit/build-angular : 0.801.3
   @angular-devkit/schematics    : 8.1.3
   @angular/cli                  : 8.1.3
   @ionic/angular-toolkit        : 2.0.0

Cordova:

   Cordova CLI       : 9.0.0<EMAIL_ADDRESS>   Cordova Platforms : android 8.1.0
   Cordova Plugins   : cordova-plugin-ionic-keyboard 2.2.0, cordova-plugin-ionic-webview 4.1.2, (and 4 other plugins)

Utility:

   cordova-res : 0.6.0
   native-run  : 0.2.8

System:

   NodeJS : v10.16.0 (C:\Program Files\nodejs\node.exe)
   npm    : 6.10.2
   OS     : Windows 10

Same here... it is somehow related to the Android System WebView version. We recognized this behavior on Android 6.0.1, WebView Version >= 75 (74.0.3729.157 is not affected by this problem).
Ionic:

   ionic (Ionic CLI)             : 4.12.0 (C:\xxx\v10.14.1\node_modules\ionic)
   Ionic Framework               : @ionic/angular 4.0.2
   @angular-devkit/build-angular : 0.11.4
   @angular-devkit/schematics    : 7.3.6
   @angular/cli                  : 7.1.4
   @ionic/angular-toolkit        : 1.2.3

Cordova:

   cordova (Cordova CLI) : 8.1.2<EMAIL_ADDRESS>   Cordova Platforms     : android 7.1.4
   Cordova Plugins       : cordova-plugin-ionic-keyboard 2.1.3, cordova-plugin-ionic-webview 3.1.1, (and 9 other plugins)

System:

   NodeJS : v10.14.1 (C:\Program Files\nodejs\node.exe)
   npm    : 6.4.1
   OS     : Windows 10

At our app not only the unchecked Checkboxes are invisible but the ion-card elements have a grey background - see screenshot (don't mind the black rectangles).

@Cerik2005 : Doing some research I found that comment which seems like a fix for exactly this issue: https://github.com/ionic-team/ionic/pull/19602#issuecomment-545546892
I had no time yet to check it, but maybe it will help you?!

Thanks for the issue. Is this still an issue with the latest version of Ionic Framework? If so, please provide a repo with the code required to reproduce this issue.


[Tabs] Custom variant cause prop types warning

Duplicates

[X] I have searched the existing issues

Latest version

[X] I have tested the latest version

Current behavior 😯
When I'm defining a custom variant for Tabs component in the theme, I'm getting a prop types warning:
Warning: Failed prop type: Invalid prop `variant` of value `lined` supplied to `ForwardRef(Tabs)`, expected one of ["fullWidth","scrollable","standard"].

This does not happen in other components that I've created custom variants for (example: Button).
Expected behavior 🤔
Since it is possible to define new variants in the theme, it should not warn about new variants values.
Steps to reproduce 🕹
Steps:

Override the Tabs components in the theme with a custom variant

    MuiTabs: {
      variants: [
        {
          props: { variant: "lined" },
          style: {
            // some styling
          },
        },
      ],
    }

Render the Tabs component with the custom variant

<Tabs variant="lined"><Tab ...><Tab ...></Tabs>

Warning will appear in the console

Context 🔦
I am trying to create a custom variant for the Tabs component, and the warning in the console causes tests to fail since we fail on every console warning / error.
Your environment 🌎
System:
OS: macOS 11.4
Binaries:
Node: 16.13.0 - /usr/local/bin/node
Yarn: 1.22.17 - /usr/local/bin/yarn
npm: 8.5.0 - /usr/local/bin/npm
Browsers:
Chrome: 99.0.4844.83
Edge: 99.0.1150.39
Firefox: 98.0.1
Safari: 14.1.1
npmPackages:
@emotion/react:  11.7.1
@emotion/styled:  11.6.0
@mui/base:  5.0.0-alpha.61
@mui/icons-material:  5.2.5
@mui/lab:  5.0.0-alpha.61
@mui/material:  5.2.5
@mui/private-theming:  5.4.2
@mui/styled-engine:  5.4.2
@mui/styles:  5.2.3
@mui/system:  5.4.3
@mui/types:  7.1.2
@mui/utils:  5.4.2
@mui/x-data-grid:  5.2.1
@types/react:  17.0.39
react:  17.0.2
react-dom:  17.0.2
typescript:  3.9.10

I think Tabs does not support a custom variant yet. It is a bit different from Button because Tab's variant is logic + styling where as Button's variant is all about styling.
If you'd like to change only the styles of the Tabs, please consider styled API or via theming API. More details about "How to customize"

Hi @siriwatknp , thanks for the reply, but I fail to see where the variant contains logic in Tabs (looked at the source code, the only thing I see is that the variant is used to set the fullWidth prop on the child).
Personally, I really dislike the styled option, I do all the styling in a theme and define custom variants where required, and it worked great until this one :)
I can solve it with className, and using the class as a selector in the theme, but it kinda breaks the DX of using variants all around.
If this variant issue is really an issue, and it cannot be used for some components, I think it should be stated in the documentation in that case.

Faced with the same problem. And I believe that this is we (developers) should decide how to use a custom variant - the framework should provide us with the opportunity to add it. As Button's variant. And what happens next - completely depends on the developer who added it.

Getting the same issue with icon buttons.

Guys any workarounds?


Added the current date to the changedMonth event

Just added the generated date with the new month to the changedMonth event, that way we can get the month  and year actually navigating.
Signed-off-by: Javis Perez<EMAIL_ADDRESS>

Coverage remained the same at 99.659% when pulling ee5c886d57195c4d86d41f8fe992cfc16d47d48c on javisperez:master into 0f9cf8d68e1b648c4c05edf95887e3198208af6a on charliekassel:master.


grep: no paths given when pipe input is provided but falsy

Node version (or tell us if you're using electron or some other framework):
C:\Users\ohnob\repos\shelljs-grep-empty-pipe>node --version
v6.4.0

ShellJS version (the most recent version/Github branch you see the bug on):
9bc498e51257c8f8ff2d1a551c2800ad9204e8da
Operating system:
C:\Users\ohnob\repos\shelljs-grep-empty-pipe>VER

Microsoft Windows [Version 10.0.14959]

But because I can see this from reading src/grep.js:38@9bc498e51, I’m quite certain this bug is platform agnostic.
Description of the bug:
The shell.grep command, unlike POSIX grep(1), treats a pipe which provides the empty string as input as a special case. It should recognize that a pipe is provided and process it like usual.
Example ShellJS command to reproduce the error:
C:\Users\ohnob\repos\shelljs-grep-empty-pipe>ECHO.|.\node_modules\.bin\shx grep asdf
grep: no paths given

shell.ShellString('').grep(/asdf/);

I can provide a testcase but am incapable of thinking up a fix as this really has to do with shelljs architecture. Here is the testcase which demonstrates the issue:
// Handles detecting empty input.
result = shell.ShellString('').grep(/asdf/);
assert.equal(shell.error(), null);
assert.equal(result, '');

Yes, that's a great test case for this.
You're absolutely correct, it has to do with how our pipes are designed. The API just returns a string value, empty or otherwise, which is set here.
Here are some possible solutions for this:

Add an API called hasPipe() which returns a boolean. True means the function is on the right-hand side of a pipe. This requires refactoring our internal commands.
Change the API to return null if there is no pipe and treat empty strings as valid input to pipes. This also requires specific null checks in the code.

The internal refactors aren't so much of a problem, but this function will be exposed in our plugin API, so it's important that we get something that's intuitive to use. Any community feedback would be much appreciated.

I haven’t written any plugins, so I can’t speak for the community. But from the standpoint of the least breaking change that maybe could be implemented now, hasPipe() sounds promising. It won’t break any plugins that unconditionally access properties on the value returned by common.readFromPipe(). Commands can be updated one by one to support checking hasPipe() instead of checking if the pipe value is truthy as users of those plugins encounter this gotcha. And the documentation for command writing could be updated to recommend checking for that.

Another possibility is to throw an exception if there is no piped input. Hmmm... not sure what the correct behavior should be.
Either way, I'm going to triage this for the 0.8.0 release, since it'll change the behavior of some of the commands.

If we’re allowed to make breaking changes, I would definitely go for a property/function to test for the presence of piped data (hasPipe) and throwing an exception when trying to readFromPipe() if there is nothing. This would make it harder for people to write plugins wrong in the first place and also “help” them update existing code to the new API. (And at the same time I’d like pipes to be promoted to be streams instead of strings so that they can behave more like real pipes and readFromPipe() to be moved from common to a commandContext object passed to the command implementation because the current API basically uses globals which makes it harder to understand IMO. I should probably open more issues if I find time later ;-)).

I should probably open more issues if I find time later ;-))

Helpful issues are always appreciated. Streaming might be hard to support without breaking compatibility with previous versions of ShellJS, but I'm definitely interested in the idea.

I've just hit this issue, while piping a find into a grep:
var newer = exec("find /path1 /path2 -newer myfile").grep("-v", "wrk")
In this pipe I fully expect the find() to return no values for my use case (I'm porting this over from a bash script into shelljs).
The following quick-and-dirty workaround appears to get me around the issue; I simply echo after the find (which causes \n to be printed to stdout, thus the output string is no longer falsey). (NB Depending on how you're using your output it may cause other issues)
var newer = exec("(find /path1 /path2 -newer myfile; echo '')").grep("-v", "wrk")

I'll see if I can actually write up a fix for this during the week

Bumping to v0.9 milestone


Update to RHOCP 3.9 on AWS ref arch

What does this PR do?
Cosmetic fixes to match awscli
Updated sshkey/keypair name
Removed some unnecesary cruft
Remove tag from dhcp options
How should this be manually tested?
See RHOCP 3.9 on AWS reference architecture
Is there a relevant Issue open for this?
Who would you like to review this?
@cooktheryan

@mazzystr so many deleted files
:+1:


the overall directory structure of the project

Hello, sorry to bother you. Can you explain the overall directory structure of the project, I am confused about where the dataset is placed.

We follow the framework of basicsr, you can put dataset in any location according to your needs, just need to modify the root of your dataset in yaml(dataroot_gt，dataroot_lq).

Thank you for answering.I have another question.Can you upload the dataset you used, I found that the dataset (GOPRO) structure used in the project is very different from the original dataset.

You need to change the naming format of GOPRO dataset from 000000.png to 000xxx.png.


build(images) : building and publishing of images

Its not verified if the github action does work, we need to merge to verify working

Please use same go version in all files


More different Emojis

Discussed in https://github.com/inovex/scrumlr.io/discussions/3890

Originally posted by SelinaBuff February 20, 2024
One person wished more and different Emojis/Reactions.
https://www.npmjs.com/package/emoji-picker-react

for frontend, we might be able to use the emoji picker that is already implemented for this

another TODO: discuss changing skin color state to be a column stored in user db

I think this requires some more refinement. The emoji picker we have in the project now used for inline emojis, i.e. updated when typing text. For this task, we'd require a new emoji picker. I would actually prefer implementing our own since we basically have a the required parts for this, and we can apply our own design there.
Furthermore it should be defined how the new reaction bar should behave like. Is the last emoji replaced by the ➕ icon? Are the last used emojis saved in the bar? Or can the bar be changed to include whatever emojis you like in the settings, which also could be persisted?

I was under the impression we could leverage an existing emoji picker and simply tweak the CSS if needed. My initial thought was for it to behave similarly to Slack’s emoji picker. In our case, clicking the "+" would open a dialog displaying all available emojis, but these wouldn’t impact our preset ones – for instance, the order wouldn’t change.

Alright, if we can find an existing component which allows for the flexibility to change it to our needs, then sure.
We can definitely do it like Slack, maybe we can allow customization to some degree in some future update though.


Fix the CI

dropping very old puppet versions
making rubocop happy

The CI will be probably still red because of puppetlint warnings

Fixes for puppetlinter will follow in a separate PR


Add the IBM Cloud provider plugin to the Gemfile

The IBM Cloud provider (https://github.com/ManageIQ/manageiq-providers-ibm_cloud) adds support for the IBM Cloud Power Virtual Servers service (docs)
https://github.com/ManageIQ/manageiq/issues/20195

The ibm_cloud::power_virtual_servers::metrics_collector_worker container image name is too long so the container_common spec is failing, working on fixing it


Responsive to Client device to specific boot.ts

Would SpaService support for boot.mobile.ts and boot.desktop.ts by responsing to specific access device? Im developing ASP.NET Core Responsiveness and maybe thinking it would be possible to integrate this library together.

If you want to present different UIs depending on whether the client device is a desktop or mobile browser, that's more of a job for CSS (or potentially, your React/Angular/KO/etc view templates or  even some logic in your client-side component code). I don't think people would really want to have completely separate boot scripts depending on the client device (that would imply having completely separate client-side apps, which is hugely unnecessary). So I'll close this and suggest people use CSS/template/component code to vary the UX by device type.


Add NewRuntimeFromRuntimeConfig libpod API

Hey, please see this PR as part of a proposal in how to use libpod within cri-o.
The commit introduces a new libpod API function to be able to initialize the runtime from a non-file-based configuration. Projects like CRI-O will now have the possibility to reuse their existing config within libpod.
My plan would be to add a *libpod.Runtime to the CRI-O server, to directly use it for operations like pulling images. This is the completely other way around approach than migrating from the lowest possible level like libpod/libpod/storage.go. WDYT?
/cc @mrunalp @rhatdan @vrothberg
Relates to #2791

Hi @saschagrunert, thanks for kicking off a discussion.
At the very moment, I would object attempts increasing the coupling between libpod and cri-o. Note, this is only my take, and others might think differently.
The reason why I object is that libpod is still subject to changes, just a c/storage and c/image, buildah (and cri-o). This leads to (very) frequent issues when updating the dependencies. I think that go modules will help in the sense that it automates many previously manual tasks. It also forces us to think about how the different libraries and repos play together. However, at the moment, it is already challenging enough to keep all of the projects in sync, so a coupling of cri-o on libpod on that level does not seem maintainable to me.
Before performing any changes, I would like to formalize the requirements from cri-o on libpod. What does cri-o need? Do the APIs (and semantics) actually fit the needs? Once that's done, we can come up with roadmap and sync on that. Once the roadmap is there, we need to find solutions for testing, CI, and how we do release engineering? Will CRI-O only vendor stable versions of libpod? How can we test PRs from c/image, storage, buildah and libpod (with potentially incompatible API changes etc.)?
In other words. IMHO we would run into serious maintenance issues if we would couple the projects on that level now. We should first collect the requirements, then come up with a roadmap, and before performing the changes, make sure that a) all automation is in place and b) that there is a clear policy for what needs to be vendored when and which order and priority.

My initial thought was to use the existing configuration API to translate (take the CRI-O config fields, pass them all in individually via WithStorageConfig() and etc), but I'm not really opposed to this.
The complexity is mostly going to be ensuring identical behavior in places where the options enforce defaults - for example, when configuring storage, we automatically adjust the Libpod static directory based on the configured storage root, and to maintain compatability with Podman we'd need to make certain this behavior is maintained by default on the CRI-O side.

Thanks for the detailed explanations!

Before performing any changes, I would like to formalize the requirements from cri-o on libpod.

I would love to see a roadmap for CRI-O and for the containers/* ecosystem, I definitely support this point.

@vrothberg 100% agree that we need to nail down requirements for the move to CRI-O. This is going to be a major effort, almost amounting to a wholesale rewrite (we can do parts of the migration incrementally, moving, say, containers, then images, then pods), but for each stage, we have to start using all the Libpod APIs at once - we can't just move half the container functions over, and leave the other half on the CRI-O legacy APIs. That's going to be very painful, especially to get the E2E tests passing (and ensure performance stays comparable).
On the API side, we have three big concerns, I think.

Exec. Podman exec calls straight out to the OCI runtime, without involving Conmon. We need Conmon changes to make this change (and, coincidentally, I believe it's also hindering @jwhonce now).
Pods. The Pods API isn't where it needs to be to support CRI-O yet. We're missing a lot of the optimizations around infra containers they can do. CRI-O infra containers all share storage, for example - no mount/unmount for each, makes things a fair bit faster.
Rootless. This isn't really a concern that our APIs are lacking for CRI-O, but more of a stability one. The rootless APIs are changing frequently, and are not centralized in Libpod.

Okay, sounds good. I will close this since I guess this PR is now obsolete.
Is there any way how to support the pre-planning phase?

Is there any way how to support the pre-planning phase?

Starting to collect the requirements would be a huge step in the right direction.
For instance, CRI-O seems to implement some kind of CIDR matching when pulling. Please don't nail me to it, I never took the time to study this code in detail. However, I am not actually sure if it would make sense to call a libpod API for pulling and pushing. Parts of the consideration could be test coverage, deduplication of code, flexibility to add specific features to meet specific requirements etc.
But as @mheon pointed out, the lower level APIs for managing PODs and containers are likely to be the tricky parts.

Is there any way how to support the pre-planning phase?

Starting to collect the requirements would be a huge step in the right direction.

I share your opinion and would like to support there. :+1: Usually I would go for declaring this topic as EPIC, define the basic acceptance criteria and collect the requirements. I don't want to clash with your processes so I have to ask further: Do you already have a planning board (like GitHub project) which provides an overview about ongoing topics in the view of containers/*, cri-o, and so on? I guess this would be the right place for this here, right?

Usually I would go for declaring this topic as EPIC, define the basic acceptance criteria and collect the requirements. I don't want to clash with your processes so I have to ask further: Do you already have a planning board (like GitHub project) which provides an overview about ongoing topics in the view of containers/*, cri-o, and so on? I guess this would be the right place for this here, right?

We don't really have a board spanning over all containers/* projects. GitHub issues and cross-referencing them has worked out so far.
For collecting requirements, I created a Google doc (https://docs.google.com/document/d/1GKub_NvdGCo7veR8XXf5w3PaEpIwzU6TnTMKNDcErEA/edit?usp=sharing) and gave you edit rights. The document is public and interested parties can ping me anytime, if they want to contribute.

@mrunalp @umohnani8 @giuseppe @haircommander @rhatdan FYI ^^^

@saschagrunert, btw, if you have questions about libpod internals, feel welcome to join #podman on freenode.

For collecting requirements, I created a Google doc (https://docs.google.com/document/d/1GKub_NvdGCo7veR8XXf5w3PaEpIwzU6TnTMKNDcErEA/edit?usp=sharing) and gave you edit rights. The document is public and interested parties can ping me anytime, if they want to contribute.

Yeah thanks, that's a good place to start. :+1:

@saschagrunert, btw, if you have questions about libpod internals, feel welcome to join #podman on freenode.

That's nice, thank you! :)


Cleanup flags prior to 2.0 release

There's various old/deprecated flags we should get rid of (e.g. old alertmanagers flag). This issue is to remind us to do it.

   -version false
   -config.file "prometheus.yml"
   -alertmanager.notification-queue-capacity 10000
   -alertmanager.timeout 10s
   -log.format "\"logger:stderr\""
   -log.level "\"info\""
   -query.max-concurrency 20
   -query.staleness-delta 5m0s
   -query.timeout 2m0s
   -storage.local.engine "persisted"     <<< remove?
   -storage.local.path "data"                 <<< mv storage.tsdb.path
   -storage.tsdb.max-block-duration 0s
   -storage.tsdb.min-block-duration 2h0m0s
   -storage.tsdb.no-lockfile false
   -storage.tsdb.retention 360h0m0s
   -web.console.libraries "console_libraries"
   -web.console.templates "consoles"
   -web.enable-remote-shutdown false
   -web.external-url
   -web.listen-address ":9090"
   -web.max-connections 512
   -web.read-timeout 30s
   -web.route-prefix
   -web.telemetry-path "/metrics"         <<< drop this?
   -web.user-assets

overwriting the /metrics path seems pointless. We don't allow randomly rewriting anything else, so what's the reason to do it here? The route prefix allows for all practical cases I assume.

overwriting the /metrics path seems pointless.

Many of our exporters permit it, for reasons that aren't really clear to me.

-query.staleness-delta 5m0s

Pretty sure this isn't used in 2.0.

So should we ditch /metrics flag for 2.0?
Staleness delta is still used in plenty of cases as our window for how far we look back for instant queries mostly. Even with staleness solved, this needs to be specified somehow. But is the name still apropriate.

So should we ditch /metrics flag for 2.0?

I'd be in favour, however we'd need to get consensus on removing it from all the other components too.

Staleness delta is still used in plenty of cases as our window for how far we look back for instant queries mostly.

We don't use the flag value in 2.0, we use the constant StalenessDelta.

We do have a constant value of 5mins, but it can be updated via the flag
here
https://github.com/prometheus/prometheus/blob/dev-2.0/cmd/prometheus/config.go#L159-L163
Should we keep it configurable?
On Thu, Jun 15, 2017 at 2:42 PM Brian Brazil<EMAIL_ADDRESS>wrote:

So should we ditch /metrics flag for 2.0?
I'd be in favour, however we'd need to get consensus on removing it from
all the other components too.
Staleness delta is still used in plenty of cases as our window for how far
we look back for instant queries mostly.
We don't use the flag value in 2.0, we use the constant StalenessDelta.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/prometheus/prometheus/issues/2634#issuecomment-308675455,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AHA3HzWHDNkpe4CRmJxi3zjWwTKUqYMhks5sEPWWgaJpZM4NAIIL
.

I'd be in favour, however we'd need to get consensus on removing it from all the other components too.

@SuperQ @grobie @discordianfish you are dealing a lot with exporters doing this. Opinions?

Yes, we should remove /metrics flag from our components.  I don't see a need to provide an override for this in our own code.  The only use case is for reverse proxies, but these can be adjusted by users.

I've never changed the metrics path of an exporter. To be honest it's
mostly cargo cult that I included the flag in all exporters I wrote. I
wonder if we should reach out to prometheus-users and check whether anyone
has a good argument to keep them.
On Thu, Jun 15, 2017 at 11:43 AM Ben Kochie<EMAIL_ADDRESS>wrote:

Yes, we should remove /metrics flag from our components. I don't see a
need to provide an override for this in our own code. The only use case is
for reverse proxies, but these can be adjusted by users.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/prometheus/prometheus/issues/2634#issuecomment-308683083,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAANaGOhWeHf7cQvJgwKK3HG9KYyA3feks5sEPzbgaJpZM4NAIIL
.

From the requests I've seen it seems to be users trying to be consistent with some of their applications that use a (single) non-standard path.

This is done.


earthly is missing some compile time flags

Describe the bug

earthly --verrsion prints some information that misses the actual version
earhly +$target can't do anything as it doesn't know what buildkit image to use

Expected behavior

The version is properly printed
earthly knows the default image

Additional context
earthly/earthly#1025
Notify maintainers
@Mdsp9070
@kalbasit
Metadata
$ nix-shell -p nix-info --run "nix-info -m" -I nixpkgs=channel:nixos-unstable
 - system: `0`
 - host os: `Linux 5.4.119, NixOS, 20.09.20210530.eae0cab (Nightingale)`
 - multi-user?: `no`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.4pre20210531_e8f585b`
 - channels(root): `""`
 - channels(aroemer): `"nixpkgs-20.09.4025.dc326c78a93"`
 - channels(nmelzer): `""`
 - nixpkgs: `0`

Maintainer information:
# a list of nixpkgs attributes affected by the problem
attribute:
- earthly

trying to add them now :)

Do you mind mentioning me in the PR? Sadly GitHub doesn't notify me about mentions of my tickets :(

okay i will when i make it


[BUG] Unable to add Authenticate Sender Account

What is the bug?
When I try to add the AUTHENTICATE SENDER ACCOUNT, the password command is giving me an error about the configuration path of Opensearch configuration.
How can one reproduce the bug?
Steps to reproduce the behavior:

Run those commands:

./bin/opensearch-keystore add plugins.alerting.destination.email.<sender_name>.username
./bin/opensearch-keystore add plugins.alerting.destination.email.<sender_name>.password

The error will prompt when you run them.

What is the expected behavior?
This should work when we entered the second command to add the Keystore but I´m facing this error.
What is your host/environment?

OS: Linux
Version Centos 7

Do you have any screenshots?

What is the bug? When I try to add the AUTHENTICATE SENDER ACCOUNT, the password command is giving me an error about the configuration path of Opensearch configuration.
How can one reproduce the bug? Steps to reproduce the behavior:

Run those commands:

./bin/opensearch-keystore add plugins.alerting.destination.email.<sender_name>.username
./bin/opensearch-keystore add plugins.alerting.destination.email.<sender_name>.password

The error will prompt when you run them.

What is the expected behavior? This should work when we entered the second command to add the Keystore but I´m facing this error.
What is your host/environment?

OS: Linux
Version Centos 7

Do you have any screenshots?


Create MCQA for topic Default Import Export

Please create an MCQA to be added as question number 42.
The multiple choice question should be on the topic "Default Import Export". The difficulty level should be "Easy/Medium/Hard"
Tasks:

[ ] add your code to 042 folder under code
[ ] add your question to 42 in README.md file

Explanation:

export { sum as default } or export default sum function(){}

hello @kirandash ,i want to contribute on MCQA 42 question and i have a better understanding export ,so please approve me to contribute on this topic.

Thanks @naitikraj12935  🙏 for showing your interest! I have now assigned the task to you.
If you need any help, you can comment here or reach me on discord at:
discord.gg/62VR3MMCVm
And if you like this project, please do show your support by leaving a star ⭐ for more visibility

Is my pull request visible to you
On Sun, 28 May 2023, 17:30 Kiran Dash, @.***> wrote:

Assigned #40
https://github.com/bgwebagency/who-wants-to-be-a-javascriptaire/issues/40
to @naitikraj12935 https://github.com/naitikraj12935.
—
Reply to this email directly, view it on GitHub
https://github.com/bgwebagency/who-wants-to-be-a-javascriptaire/issues/40#event-9361875736,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A3QBO7R6ILQ2OJHZTEGB6ULXIM46FANCNFSM6AAAAAAYAUPDNU
.
You are receiving this because you were assigned.Message ID:
<bgwebagency/who-wants-to-be-a-javascriptaire/issue/40/issue_event/9361875736
@github.com>

Is my pull request visible to you
…
On Sun, 28 May 2023, 17:30 Kiran Dash, @.***> wrote: Assigned #40 <#40> to @naitikraj12935 https://github.com/naitikraj12935. — Reply to this email directly, view it on GitHub <#40 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/A3QBO7R6ILQ2OJHZTEGB6ULXIM46FANCNFSM6AAAAAAYAUPDNU . You are receiving this because you were assigned.Message ID: <bgwebagency/who-wants-to-be-a-javascriptaire/issue/40/issue_event/9361875736 @github.com>

will review shortly

Thanks for your contribution @naitikraj12935
appreciate your effort

It was my pleasure!
Please assign me another task
On Sun, 4 Jun 2023, 20:36 Kiran Dash, @.***> wrote:

Thanks for your contribution @naitikraj12935
https://github.com/naitikraj12935
appreciate your effort
—
Reply to this email directly, view it on GitHub
https://github.com/bgwebagency/who-wants-to-be-a-javascriptaire/issues/40#issuecomment-1575603523,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A3QBO7RGXYTNGL4QFUVID3TXJSP5ZANCNFSM6AAAAAAYAUPDNU
.
You are receiving this because you were mentioned.Message ID:
@.***
com>


Optimize performance of sending messages with thousands of soft-deactivated users

On chat.zulip.org right now, we have about 2300 users subscribed to some of our larger streams (which has a fairly lower-power Digital Ocean machine with 8GB of RAM for everything, including database, memcached, and application servers).
When sending a message to one of these streams, the backend can take 500ms to process sending a message (compared with 50-100ms for a private message with 1 recipient). On a more powerful server, these numbers might be half that, which is still significant.  More importantly, these numbers grow linearly, so with 20K inactive users on a stream, things would start to get quite large.
Because of local echo, these numbers are not a huge problem (in that in most communities, it's rare to be sending rapid-fire to thousands of people), but I think it should be possible with some careful profiling to make this considerably faster.  Huge progress was already made in #5194 with our soft-deactivation system; review that if you're curious.
Profiling would be helpful, but I believe the next major thing that we need to do in order to optimize performance here is to stop fetching UserProject objects from the database for the soft-deactivated subscribers to a stream (or ).
There's 2 natural problems to work on here:

do_send_messages calls get_recipient_user_profiles, which fetches a UserProfile object for every subscriber to the stream in the message['active_recipients'] object (an expensive operation if there are thousands of them!).  In theory, we could just fetch those subscribers who are either not long-term idle or mentioned.  In do_send_messages, that active_recipientsobject  is only used for a few things before the point where we checklong_term_idlein the code today (and thus could presumably start filtering).  The main place it is used is being passed torender_markdown, which turn just uses the user IDs to check for whether the message contains any alert_words`.  So I think we could experiment with the following flow:

First, just fetch all the alert_words for users who are subscribed to the stream.  This should be a really fast database query since everything has indexes, and will have a small data set in the reply, since most users don't have any alert_words at all.  That should be enough to get render_markdown_path to finish.

Then, we fetch from the database just those subscribers who are either (A) not long-term idle or (B) appear in mentioned_user_ids or user_ids_with_alert_words and populate the new message['active_recipients'] from that.

This will probably involve some somewhat messy refactoring, and does carry an extra round-trip to the database, but I think would have an overall pretty positive effect on performance of sending to a stream, since we'd only ever interact with the UserProfile objects for those subscribers that we'll later write a row to the database for anyway (and just have to deal with the alert_words for the rest).

We also fetch (from a memcached cache) every active user in the realm at the start of every markdown operation.  The problem here is that zerver/lib/bugdown/__init__py, our markdown processor, expects to be passed a data set containing all the active users in the realm.  The reason bugdown expects that is the way we timeouts in Bugdown means that doing database queries from within bugdown (e.g. to look up a user that was mentioned) can end up leaking database connections (if I recall correctly?  It was a long time ago I last looked at this) and thus doesn't work.

I think probably the next step before we implement either of these is to do some speedy profiling to just see how much perf impact these two changes could have.  E.g. for problem 1, if we just modify get_recipient_user_profiles to only fetch the non-soft-deactivated users (breaking alert words for the rest), how much time does that save?
And for problem 2, if we just break mentions by using an empty dict, how much time does that save (both with say, 2000 soft-deactivated users)?
Once we have that data, we can prioritize the work on solving those two problems correctly (in the way I describe).

See #6441, which saves us from creating UserProfile objects.  I also merged a change to UserMessage.flags_list(), which was consuming like 20% of the time for large streams due to its underlying implementation of creating tons of tiny objects.

I opened #6479 for the new bottleneck on this codepath, which is markdown rendering.  Closing this.  There are also some interesting comments on #6441 for some small follow-ups.


Internal Server Error When Sending Predict Requests to Vertex AI Endpoint with Mixtrail 8x7b instruct Model

Issue Description
When sending prediction requests to a Vertex AI endpoint using the Mistral model, I encounter an InternalServerError with details hinting at resource constraints or async execution issues, specifically mentioning OutOfMemoryError and errors in async_llm_engine.py, model_runner.py, and mixtral.py.
Expected Behavior
The model should process the provided prompt and return a generated response without internal server errors.
Actual Behavior
Requests to the model via the Vertex AI endpoint result in an _InactiveRpcError and a 500 Internal Server Error, indicating potential memory allocation or async execution failures.
In fact for a "small" request under around 100 token the model respond but over 100 token there is this error.
Steps to Reproduce

Deploy the Mistral model to Vertex AI following the steps in this notebook.
Configure the endpoint with the specified parameters.
Send a prediction request to the endpoint with a detailed prompt.
Observe the returned internal server error.

Specifications

Model Version:  Mixtral-8x7B-Instruct-v0.1
Platform: Colab Enterprise in vertex ai

Logs and Error Messages
The error logs indicate issues such as OutOfMemoryError and failures in async execution paths within the model's implementation.
vllm.engine.async_llm_engine.AsyncEngineDeadError: Task finished unexpectedly. This should never happen! Please open an issue on Github. See stack trace above for the actual cause.
Above this logs there is this one :
"message": "torch.cuda.OutOfMemoryError: CUDA out of memory. Tried to allocate 20.00 MiB. GPU 5 has a total capacty of 21.96 GiB of which 14.88 MiB is free. Including non-PyTorch memory, this process has 0 bytes memory in use. Of the allocated memory 19.00 GiB is allocated by PyTorch, and 115.52 MiB is reserved by PyTorch but unallocated. If reserved but unallocated memory is large try setting max_split_size_mb to avoid fragmentation.  See documentation for Memory Management and PYTORCH_CUDA_ALLOC_CONF"
Maybe it's a memory issue but im following the exact notebook specification with this config and with a context windows of max_model_len = 4096 as specified:
# Sets 8 L4s to deploy Mixtral 8x7B. machine_type = "g2-standard-96" accelerator_type = "NVIDIA_L4" accelerator_count = 8
Additional Context
This issue appears to be related to how the model processes large inputs or manages resources during execution.

@kathyyu-google can you please help or refer to someone? Thanks

Thank you @MangoHiller for bring this to our attention. We were able to reproduce your error with long prompts, which led to high memory usage. We found that the error could be avoided by decreasing the model server argument --gpu-memory-utilization to 0.85. This argument is defined in the function deploy_model_vllm and originally set to 0.9.
Marking this issue as closed. Please feel free to reopen if there are further comments or prediction errors. Thank you again!


Small bug fixes and improvements

A plethora of small improvements. This will fix #69, fix #71, fix #73, fix #82.
Nothing much to report other than:

The reading issue was coming from losing track of which_sectors_good when re-reading the file
I'm saving the scattered_light_sectors as a comma separated string to make fits happy but I convert it back to a list when I re-read it

Also just added a commit with those many dels that we discussed


Optimise html_escape

This PR replaces escape_html's implementation with an optimised version to make it faster and more memory efficient

Super nice!!! I left a Q


r.uri does not contain request arguments

Thanks for that mitigation scripts, which I like!
However, when called with GET http://localhost/test?${vulnerable}, ${r.uri} evaluates to /test in cve.js#L15.
When replaced with ${r.rawVariables.request_uri}, the malicious parameters are taken into account, which I'd prefer.
Best Regards

That is totally right! Sorry missed that! Thanks for submitting this.


Missing runtime dependency on setuptools

from pkg_resources import resource_stream in parsers/ebml/core.py makes the package depend on setuptools, which is currently not reflected in the package metadata

https://setuptools.pypa.io/en/latest/pkg_resources.html
Use of pkg_resources is deprecated


Simplify the specification of asynchronous / external requests.

For now any external / asynchronous request must be channeled through a - preferable - serializable value type that needs to implement the interface IRequest<ResultType> and there must be a service registered, that reacts on the value and computes it ResultType.
To be able to specify custom requests with the ivrs in the same source file and without explicitly registering a service with the IVR runtime, I think that it would be great to support a new interface that can specify the async method that should be run in the service context.
In addition to that, it should be possible to specify multiple async functions for each case in a DU so that they are guaranteed to be executed mutually exclusive in the same synchronization group.

works so far, completely experimental though, and there are no tests....


allow quit early optimization even when there is positive probability to keep a higher-scoring change

Currently, we have a brittle criteria for quitting early when evaluating constraints: the total score of violations evaluated so far exceeds the total score of the current best design. This rule only works when we use the default probability_of_keeping_change function that has probability 0 to keep a change that is worse.
probability_of_keeping_change takes as input delta, the difference between the new design's score and the current best design's score, i.e., if the best has score 10 and the current one is worse, with score 13, then delta = 3. probability_of_keeping_change then outputs the probability to keep the change.
The following could allow us to use other probability_of_keeping_change functions and still get the benefit of the optimization. We can "invert" probability_of_keeping_change by doing the following. Prior to the next iteration, we compute a score threshold that we would be willing to keep. For example, if probability_of_keeping_change(delta) = 1/2^delta, then Pr[keep score 10] = 1, Pr[keep score 11] = 1/2, Pr[keep score 12] = 1/4, Pr[keep score 13] = 1/8, etc.
I'm not sure exactly how to efficiently sample a score threshold from the appropriate distributed, given only black-box access to probability_of_keeping_change.
But if we could do this, then we'd put all the randomness at the start of the iteration, before evaluating any constraints. Then the check we do generalizes to comparing to this sampled threshold, rather than the score of the best design so far.
The typical case, where probability_of_keeping_change is very unlikely to keep any change that is "much worse" would be that the sampled threshold would be only very slightly above the best score so far, so would be almost equivalent to what we are currently doing, while allowing occasional changes to be kept even if they are worse.

If we had the inverse of the CDF for probability_of_keeping_change, then inverse transform sampling is the way to go. But not sure of an efficient way to compute the inverse of the CDF given only the PDF (which is essentially what probability_of_keeping_change is).


Links with data-method attribute submit wrapping form instead of their URL

Given I have a link with data-method="post" within a <form>, when I click it, it submits the current form instead of requesting the target URL with the appropriate HTTP method:
<?php
$form = ActiveForm::begin() ?>

    <?= $form->field($model, 'label')->textArea() ?>

    <?= Html::a(
            'I should redirect to another url',
            Url::toRoute(['somewhere/else']),
            ['data-method' => 'post']
        ) ?>

<?php ActiveForm::end(); ?>

but when
 $form = ActiveForm::begin([
    'id'                     => 'login-form',
    'enableAjaxValidation'   => true,
    'enableClientValidation' => false,
    'validateOnBlur'         => false,
    'validateOnType'         => false,
    'validateOnChange'       => false,
])
...
Html::a('Register As an Author',['/user/registration/register'],[
                    'data-method'=>'post'
            ])

still tries to validate surrounding form instead of sending post request to the give url

please open a new issue, this is over a year old


[Task] Identify performance bottle necks

Profile the application and talk to users to identify performance bottle necks and workout a plan to address them.

Could be related:
https://github.com/appsmithorg/appsmith/issues/8639
https://github.com/appsmithorg/appsmith/issues/3530


chore(onyx-467): clean up alerts related feature flags

This PR resolves ONYX-467
Description
Clean up old feature flags that are marked as release in Echo:

AREnableAlertsFiltersArtistSeriesFiltering
AREnableArtistSeriesSuggestion
AREnableAlertDetailsInput
AREnableAlertsSuggestedFilters
AREnableAlertsFilters

PR Checklist

[x] I have tested my changes on iOS and Android.
[x] I hid my changes behind a feature flag, or they don't need one.
[x] I have included screenshots or videos, or I have not changed the UI.
[x] I have added tests, or my changes don't require any.
[x] I added an app state migration, or my changes do not require one.
[x] I have documented any follow-up work that this PR will require, or it does not require any.
[x] I have added a changelog entry below, or my changes do not require one.

To the reviewers 👀

[x] I would like at least one of the reviewers to run this PR on the simulator or device.

Changelog updates
Changelog updates

Cross-platform user-facing changes

iOS user-facing changes

Android user-facing changes

Dev changes

chore: clean up alerts related feature flags - @nickskalkin

Need help with something? Have a look at our docs, or get in touch with us.

This PR contains the following changes:

Dev changes (chore: clean up alerts related feature flags - @nickskalkin)

  Generated by :no_entry_sign: dangerJS against a99db4431ca112114dd25b850871da787f0d6d14


maybe gatling-grpc should support response pass

example:
first grpc interface return {"num": 123, "name": "thinkerou"}, and second grpc interface will use before num result.

not sure if I understand. tell me more plz

In http load test, we could write the following code:
val uploadTest = http.baseURL("http://upload.test.com")

val scn = scenario("test").feed(userinfo)
  .exec(http("test1")
    .post("/rest/n/upload/atlas/key?mod=x")
    .check(jsonPath("$.key").saveAs("currentKey"))
  )
  .exec( session => {
    session.set("currentKey", session("currentKey").as[String])
  })
  .exec(http("test2")
    .post("/rest/n/upload/atlas/photo?mod=am")
    .queryParam("index","0")
    .queryParam("key", "${currentKey}")
    ...
)

yeah looks good, if you send merge request for that I will be happy :)

OK, I will retry to impl it.

About the issue, I want to use object or global var to save var, but it's not ok.
details https://stackoverflow.com/questions/51406320/why-can-not-set-variable-value-on-gatling-with-scala @macchiatow can you help me see? thanks a lot!


Bundle conveyor components into a single install

User Stories

[ ] As a system administrator I want a single install script for the Kibana plugin, ingest API, and Node-RED so that I can test or deploy in the most simple manner.
[x] As a Potential user I want a single command install to test the entire stack of ES, Conveyor, Kibana, and Node-RED so that I can test without hassle.

@milutz I think we are as far as we're taking this right?


Resolve Sales Dashboard issue rendering orgs with non CB plans

Is the source of truth for non cb plan is Django DB?

Yeah I think that's fine


Module with 1 cmdlet is not processed correctly

Exception is thrown in Update-Progress function:

Exception: Attempted to divide by zero. --> Attempted to divide by zero.

It happens, because $totalCommands is not defined.
$totalCommands = $commandsHelp.Count

Simple fix:
$totalCommands = $commandsHelp.Count
if (!$totalCommands)
{
    $totalCommands = 1
}

Happy to accept a PR.


⚠ Bofrost.at has degraded performance

In f0d38fc, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1363 ms

Resolved: Bofrost.at performance has improved in 34f3254.


Deprecate ShowCopNames over DisplayCopNames

RuboCop supports DisplayCopNames option now. Having unsupported ShowCopNames
option in the RuboCop config seemed to cause issues for our users.

Is the effect of this that GitHub comments will include the cop name?

Yes, users can opt-in to see what cop is commenting for ease of configuring it.

Are we tracking the use so we can reach out to users?
:+1:

Yep. We can reach out to them, or if there's no use, then safely kill it.

Merged via d8268987de0214b081b601a2c6104c8501f50e8c.


Use of NLog variables in internalLogFile setting

Is there any way I could specify a variable in the  attributes?
I know you cannot use layout variables, but it would be wonderful to be able to write in the .config something like:
internalLogFile="c:/logs/Nlog.${processname}.log"
BTW: the issue has been mentioned in StackOverflow
http://stackoverflow.com/questions/9428724/nlog-internal-log-not-working-with-asp-net-mvc

As answered at Stackoverflow this isn't possible.
Also it would be strange if this could work, the internal logfile should be as stable as possible (a so no fancy features). Also I think thank the internal log should only be used in rare cases.

What is about environment variables?

Right now it's just a plain string. So also no environment variables.

I know. That was rather a feature request ;)

@Niklas-Peter Why would you need it? We think that the internal logger should be as simple as possible.

It is hard to choose a fixed path. Most appropriate folders are in
different locations depending on the Windows version, but share the same
environment variable name.

But it's only needed in rare cases?
For other cases, just use the FileTarget?

Probably you are right.
You should evaluate, how much effort and instability such an
implementation requires and then balance pros and cons.
I think it will require just a few commands, but, of course, these few
can fail, too.

Yes, that's the case. And then we should write an internal-internal-logger ;)
If there is a really great benefit to implement, we will add it as feature request.


HTML Tag Not Closed

Somewhere in the code, a HTML tag is not closed which causes the  tag to appear as text.

Fixed! Thanks for letting me know :)


[Telemetry] Inject env identifying KubeRay.

Signed-off-by: Dmitri Gekhtman<EMAIL_ADDRESS>

Why are these changes needed?

This change has the KubeRay operator inject an env var identifying a Ray container as having been deployed using KubeRay.
The purpose is to refine Ray usage stats collected by Ray's telemetry service (https://docs.ray.io/en/latest/cluster/usage-stats.html).
See https://github.com/ray-project/ray/pull/28490
Related issue number

Checks

[ ] I've made sure the tests are passing.
Testing Strategy

[ ] Unit tests
[ ] Manual tests
[ ] This PR is not tested :(

I'll add an e2e test for this in the Ray CI.


Change Relocate to Launched and Pickup to Found a Box

change form labels and any labels that refer to relocate/pick up to be relocate/found a box

/cib change relocate to launched pickup to found a box

Branch 109-change-relocate-to-launched-pickup-to-found-a-box created!


1.20.4 player kick on pager.show() with message 'Packet play/90 (class _ 2748) was larger than I expected'

I am using the ProtocolSidebar 6.2.5 Snapshot to create a pager that updates every x seconds. MC 1.20.4 has unfortunately broken something. A player kick occurs with no further stack trace or text in either the server console or minecraft client log.

I've singled the issue out to somewhere in the class where I show the pager, probably on the pager.show() statement.
As soon as this code is reached, the corresponding player is kicked (haven't tested with multiple players) with the following message.
For further invenstigation, this is the method where I call pager.show().
The following simplified method gets called every x seconds, or on plugin start. (for full class - here)
public void refreshLeaderboard() {
        Set<Player> players = PlayerUtils.getPlayersInWorld(plugin.getConfig().getString("world"));

        List<String> enabled = plugin.getConfig().getStringList("enabled-slides");

        ArrayList<Sidebar<Component>> enabledSidebars = new ArrayList<>();

        Component titleComponent = LanguageConfig.lang.get("SCOREBOARD_MAIN_TITLE");

        Sidebar<Component> personalStatsSidebar = ProtocolSidebar.newAdventureSidebar(titleComponent, plugin);
                    enabledSidebars.add(personalStatsSidebar);

        long period = plugin.getConfig().getInt("scoreboard-period") * 20L;
        SidebarPager<Component> pager = new SidebarPager<>(
                enabledSidebars, period, plugin);

        for (Player player : players){
            pager.show(player); // **Probably cause of kick**
            if (!(plugin.getConfig().getBoolean("scoreboard-enabled"))){
                pager.hide(player);
            }
        }

        new BukkitRunnable() {
            @Override
            public void run() {
                if (plugin.getConfig().getBoolean("scoreboard-enabled")){
                    refreshLeaderboard();
                }
                pager.destroy();
            }
        }.runTaskLater(plugin, period * 2);
    }

Using latest experimental paper build 1.20.4 Build #326

same issue here and i dont use pager, only the basic thing like https://github.com/CatCoderr/ProtocolSidebar?tab=readme-ov-file#basic-usage

In version 1.20.4, there are significant changes in the Score and Objective packets. I recommend using the latest supported version, 1.20.2, with ViaVersion. I will add support for versions 1.20.3 and later in due time.

In version 1.20.4, there are significant changes in the Score and Objective packets. I recommend using the latest supported version, 1.20.2, with ViaVersion. I will add support for versions 1.20.3 and later in due time.

ETA?

@CatCoderr is there any news on this issue?

🙏🙏🙏


package-upgrade-all no longer prints messages while upgrading

Probably due to a change in emacs-async?

This is now invalid because I use straight.el.


getSignaturesForAddress response order is inconsistent (when the given address has more than one signature in the same block)

Problem
The following getSignaturesForAddress payload gives inconsistent results.
{
    "jsonrpc": "2.0",
    "id": "my_local_env",
    "method": "getSignaturesForAddress",
    "params": [
      "HbNGeafGRKsXXTcBMCuRoBQpz6bmJ8UyLikuAjc1LCRW",
      {
        "limit": 2,
        "encoding": "jsonParsed"
      }
    ]
  }

Account : HbNGeafGRKsXXTcBMCuRoBQpz6bmJ8UyLikuAjc1LCRW
Tx signature 1 : 2DQpqgd4oS4iAevswo1wXXJvCaCJm6BPjynYUEPmR79SQgJR3mPJqhgYbRZ4NqMMZT9VxZhQcpiMqrv5jEkjiicm
Tx signature 2 :
vLcnRYGwvt6Mwiq9rGzN6syNFW9aiUPnZN2bqEaFMBA2XxnWAD6q2SPSRqSkgsuo67GjJATs9YR2LN5UjFgTFHt

Proposed Solution
This looks like a bug since transaction ordering should be the same. And can lead to incorrect information when extra fields like before, until are used.

Multiple pre-existing issues on this topic, eg https://github.com/solana-labs/solana/issues/22456
Fixed in v1.18


Add PR template for all the repos.

Hey @Souvikns can I work on this issue?

Hey, @MukulKolpe sure go ahead 👍🏻.

Hey, @MukulKolpe sure go ahead 👍🏻.

Hi, I would like to work on this issue.
Also, it would be great if could you could tell me where to add the PR template in repos and if there is a specific template for it.

Hey, @someshium you can check this PR made by @MukulKolpe, thanks to him we successfully added a PR template in this repo, We are having 3 more repos that we will be having this same PR template. You can go to https://github.com/klifu and open a PR on any other repos.


TextInput ignores dynamic textAlign with secureTextEntry

[x] Review the documentation: https://facebook.github.io/react-native
[x] Search for existing issues: https://github.com/facebook/react-native/issues
[ ] Use the latest React Native release: https://github.com/facebook/react-native/releases

Environment
React Native Environment Info:
System:
OS: macOS Sierra 10.12.6
CPU: x64 Intel(R) Core(TM) i5-5257U CPU @ 2.70GHz
Memory: 108.94 MB / 8.00 GB
Shell: 3.2.57 - /bin/bash
Binaries:
Node: 10.14.2 - /usr/local/bin/node
npm: 6.5.0 - /usr/local/bin/npm
SDKs:
iOS SDK:
Platforms: iOS 11.2, macOS 10.13, tvOS 11.2, watchOS 4.2
IDEs:
Xcode: 9.2/9C40b - /usr/bin/xcodebuild
npmPackages:
react: 16.5.0 => 16.5.0
react-native: 0.57.1 => 0.57.1
npmGlobalPackages:
react-native-git-upgrade: 0.2.7
Description
Reproduce only for ios TextInput with secureTextEntry.
This problem is like this: https://github.com/facebook/react-native/issues/12160.
On focus, text align should be in center with highlight border in bottom.
On blur, text align should be in left position. But the text remains in center.
For android it's work perfectly.
If add key like this:
key={shouldCenter${this.state.focused}}
focus on input work only after second press, see in Demo
Reproducible Demo
https://snack.expo.io/H1ZOFpRGN
import * as React from 'react';
import { Text, View, StyleSheet, TextInput } from 'react-native';

export default class App extends React.Component {
  constructor(props) {
      super(props);
      this.state = {
          focused: false,
          text: '',
      };
  }

  render() {
    const shouldCenter = this.state.focused;
    return (
      <View style={styles.container}>
        <Text>{`center: ${shouldCenter}`}</Text>
        <TextInput
          value={this.state.text}
          style={[
            styles.inputDefault,
            shouldCenter
              ? styles.inputFocused
              : styles.inputBlured
          ]}
          onFocus={() => this.setState({ focused: true })}
          onBlur={() => this.setState({ focused: false })}
          onChangeText={text => this.setState({ text })}
          secureTextEntry
        />
      </View>
    );
  }
}

const styles = StyleSheet.create({
    container: {
      flex: 1,
      justifyContent: 'center',
      backgroundColor: '#ecf0f1',
      padding: 8,
    },
    inputDefault: {
        color: '#000',
        fontSize: 16,
        borderBottomWidth: 1,
        width: '100%',
    },
    inputFocused: {
        textAlign: 'center',
        borderBottomColor: '#F86C30',
    },
    inputBlured: {
        textAlign: 'left',
        borderBottomColor: '#a3a3a3',
    },
});

I think this may be fixed by: #23524


Publish master as 0.8.1

Until you publish version 0.9.0 can you publish master fixes as 0.8.1?

Sure, let me take a look at the changes...

Done:

https://github.com/scrogson/oauth2/releases/tag/v0.8.1
https://hex.pm/packages/oauth2/0.8.1


runtime(svelte): basic svelte ftplugin file

Hello!
I'm a neovim user, and I was missing commenting support for svelte, so here we are :)
It's my first contributing, so I've used https://github.com/vim/vim/pull/14802 as an inspiration, let me know if I missed anything.

Any thoughts @towry?


CAMERA STREAM FAILED TO START

Hello,
I am just trying to run the sample code of hellozed.py but my system is not detecting the camera
There is no issues with import of pyzed but I could not stream the camera.
Any help would be appreciated

Hi @kshamaramesh,
The first tutorial is only printing your camera serial number in the terminal, you are not supposed to see the camera stream.
If that is indeed the case, there is nothing wrong with your camera and you can test other tutorials or samples.
Otherwise, you can try to open ZED_Explorer tool to see if your camera is detected or not by your system

Thanks for the feedback!
It is working with the ZED_Explorer.
But next I tried to run the code of Image capture code example..
I ended up in NO GPU COMPATIBLE
My Graphics card is NVIDIA  GeFORCE GTX 680
CUDA Version 11.0
ZED SDK is 3.4.3 the latest version
Please do let me know what could do I need to install the different version of SDK.
Thanks in advance


Review Lambert API

Some concerns were raised months ago in the mailing list about the solution pairs, as well as the prograde/retrograde nature of the solutions.
When I implemented the Izzo algorithm I used a generator, and that makes me think that I was probably misunderstanding the paper. This affected how the API is used.
https://github.com/poliastro/poliastro/blob/333a2f77f5c4fa1c652bcdd9bea72ce42531b566/src/poliastro/core/iod.py#L235-L241
We should review this in depth and answer this message on the mailing list, even if months have passed:
https://groups.io/g/poliastro-dev/message/118

I am finally able to properly answer original question raised by Irina Kovalenko and also introduce some ideas about how we could improve the current Lambert's API and associate routines.
Amount of solutions
Even if considering non-degenerate, degenerate and multi-revolutions ones, the solution to the Lambert's problem is an elliptic orbit most of the times. Of course, multi-revolution solutions will be for sure elliptic kind, as the orbit needs to be closed.
Under certain combinations of time of flight and transfer angle, it is possible to find two elliptical orbits as the solution to the transfer. The following figure from the open paper Optimal Two-Impulse Rendezvous Using Multiple-Revolution Lambert Solutions (DOI: 10.2514/2.5014) provides a very illustrative figure:

Notice that there exist a short and long paths for prograde transfer but also another short and long arcs for retrograte motion, making thus a total of 4 possible transfer arcs. The final orbit is selected by imposing the sense of motion and selecting the short or long arc.
State of the current Lambert API
At the moment, only two Lambert solvers are available within poliastro: vallado and izzo. Although both address the same problem, they require different parameters:
https://github.com/poliastro/poliastro/blob/3c1d0eb8382075a8e7a191cd84acf34748c2d649/src/poliastro/core/iod.py#L11
Vallado provides the short boolean parameter but notice when compared to previous figure, this parameter actually controls the prograde or retrograde orbit selection! The algorithm from the original book (the one implemented in poliastro) is a simplified version from the original one in Celestrak  and only retrieves two of the possible 4 transfer arcs. The full routine is properly coded within in official link, which reminds me about https://github.com/poliastro/poliastro/pull/895.

https://github.com/poliastro/poliastro/blob/3c1d0eb8382075a8e7a191cd84acf34748c2d649/src/poliastro/core/iod.py#L164
Regarding Izzo's algorithm, both short and long transfers are properly computed. However, the algorithm lacks of prograde/retrograde selection parameter. We could easily implement this feature, it only requires adding a change of sign, see pykep implementation.
Suggestions and possible solutions

We might consider adding explicit parameters solver(short=True, prograde=True) for better filtering and making more explicit the amount of solutions returned by each of the algorithms. Main drawback is that we would loose the ability to return all kind of solutions at the same time within core functions if implemented in this API level, but I is kind of strange to require all of them at the same time... :thinking:

A million thanks for this thorough review @jorgepiloto! Some more extra ideas:

I imagine that prograde orbits are preferred over retrograde orbits in most cases. For short vs long, I am not that sure. In any case, I agree that short=True and prograde=True are good defaults. I am not worried about "losing the ability to return all kind of solutions at the same time" from the core API.
...Unless returning all kind of solutions at the same time is faster. I say this because, if we add short and prograde parameters, we might have to repeat some intermediate computations.
And finally: can we turn the generators (yielding the solutions) into normal functions? I think this would simplify their usage a lot.

In response to @astrojuanlu,

I imagine that prograde orbits are preferred over retrograde orbits in most cases. For short vs long, I am not that sure.

The "short" or "long" paths are referred by some authors as "low" or "high" paths, so they are not misunderstood with the prograde and retrograde transfers. These parameters can only be selected when there are two solutions to the problem, that is only for M>=1 revolutions. The "low" paths correspond to negative values of "x" (independent variable), while "high" paths are linked to positive "x" values. Hence, it should be easy to filter out the final solution to the problem. I think that usually the low path is the one selected, as both the "low" and "high" solutions lead to an elliptical orbit (remember, multirevolutions => closed paths => ellipses).

And finally: can we turn the generators (yielding the solutions) into normal functions? I think this would simplify their usage a lot.

By using the following keywords, prograde=True and low_path=True, the lambert routines do not longer require a generator and thus, they return a unique solution to the problem.

@jorgepiloto  @astrojuanlu Glad to see this up and running  again. I recall the confusion we had when dealing with retrograde vs prograde and short vs long (very bad choice of param names, I might add).
I agree with jorges idea here; and I suppose we would need to refactor both izzo and vallado? I also beleive both the orbital paths are necessary along with their direction of motion(prograde, retrograde). I've already put-in a lot of work in my PR.If anybody feels like continuing that, feel free. If I have time, I'll do it myself, currently the numerical values don't match with MATLAB answer.

@jorgepiloto solved this in jorgepiloto/lamberthub#7 🎉 He's a bit short on time these days, but if anyone else wants to see the changes that were needed, feel free to open a pull request here 👍🏽

Closing this! 🥳


[zsdl] fixup SDL_GetWindowDisplayMode return type

Doesn't actually seem to matter. But better safe than sorry!

Good catch!


Draft concept for injecting ros2_control hardware system

This PR is inspired by the discussion on #52 about further factoring out ros2_control here.
Instead of creating extra ros2_control packages for the real robot, Gazebo, Ignition, FakeSystem and so on, I'm suggesting here to inject the <hardware> dependency in a consumer package from a top-level .urdf.xacro that uses the flatter call structure under development here.
In ur_macro.xacro as it exists now, many of the numerous parameters required find their way into the conditional ROS 2 Control hardware definition, for example here for the real robot.
In this PR I tried to keep the conditional switching behavior in ur.urdf.xacro, so I define several optional <hardware> blocks there and pass them in to the xacro:ur_ros2_control macro as the block parameter ros2_control_hardware.
However, I imagine that this responsibility falling to consumer packages that use the ur_description macros instead, which would remove a lot of the necessary parameters from ur_description.
I made a simple example for ur_simulation_gazebo on my fork here.
A similar thing could be done inside ur_robot_driver, with a ur_real_robot.urdf.xacro, and maybe ur_description by itself would allow optionally instantiating a mock_system/GenericSystem.
I opened this PR to illustrate my suggestion, but it currently mixes in some work to pass through joint dynamics properties to fix broken joints in Gazebo Classic
Happy to split that out later if this approach is of interest.

Reverted the joint dynamics changes to make this clearer.

Maybe this doesn't make sense in the big picture beyond refactoring the package as suggested when use cases outside of what ur_description currently supports are considered.
It would mean that ur_description or a ur_ros2_control package wouldn't need to conditionally switch hardware, but possibly that only really supports ur_simulation_gazebo, ur_simulation_ignition, ur_robot_driver and mock hardware, and it'd be easier for users who know what they're doing with ros2_control to specify everything completely in their own package.


Cannot load pickle file when containing instance of custom class

I cannot load a pickle file when containing instance of custom class. The error message is:
ModuleNotFoundError: No module named 'imgres'
(imgres is the module)
A remark, the module (at least the class) is loaded because I can create an instance of this class (this works
I use

Python 3.7.4
Windows 10

I zipped everything into the attached file
AZ12_FuncPickleProblem.zip
Essential folders and files in the zip

TerminalOutput.txt contains the terminal output with the error message.
other: folder containing script to create pickle file and example of loading it

imgres.py contains my class ImgRes
dump_pickle_file.py create pickle file
myimgres.pkl pickle file
load_pickle_file.py test loading pickle file myimgres.pkl (astonishingly there is no need for import of module, it only have to be present)

azurefunc: folder of azure function project

myimgres.pkl pickle file to be read
HttpTriggerTest: folder with function named HttpTriggerTest

__init__.py source, error in myimgresread = pickle.load(f)
imgres.py module

What am I doing wrong?  How can I solve this problem? It would be great if anybody could help!

Additinal note
In the zip the TerminalOutput.txt contains the terminal output with the error message.

Hi @HoLue,
According to the documents here, seems like your other folder should be place within the project shared_code and we recommend using from __app__.shared_code import my_first_helper_function to import your own module.

Thank you, but it did not work. First my new directory tree:
----azurefunc
----HttpTriggerTest
init.py
----shared_code
imgres.py
I tried the two following trials:

Trial:
I tried in init.py
from __app__.shared_code import imgres
(I also changed ir = ImgRes() into ir = imgres.ImgRes() which worked.)
The result on the request:
31.03.2020 05:00:16] Executed 'Functions.HttpTriggerTest' (Failed, Id=aa442def-48db-4309-8b79-50d896e9665d) [31.03.2020 05:00:16] System.Private.CoreLib: Exception while executing function: Functions.HttpTriggerTest. System.Private.CoreLib: Result: Failure Exception: ModuleNotFoundError: No module named 'imgres' Stack:   File "C:\Users\hl\AppData\Roaming\nvm\v12.12.0\node_modules\azure-functions-core-tools\bin\workers\python\3.7/WINDOWS/X64\azure_functions_worker\dispatcher.py", line 315, in _handle__invocation_request  self.__run_sync_func, invocation_id, fi.func, args) File "C:\Programme_Tools\Python\Python3_7_4_64bit\lib\concurrent\futures\thread.py", line 57, in run  result = self.fn(*self.args, **self.kwargs) File "C:\Users\hl\AppData\Roaming\nvm\v12.12.0\node_modules\azure-functions-core-tools\bin\workers\python\3.7/WINDOWS/X64\azure_functions_worker\dispatcher.py", line 434, in __run_sync_func  return func(**params) File "D:\Di\Z_InfosTestTry\Z_Programmier\Azure\AZ12_FuncPickleProblem\azurefunc\HttpTriggerTest\__init__.py", line 33, in main  myimgresread = pickle.load(f) .

Trial:
I tried in init.py
from __app__.shared_code.imgres import ImgRes
The result on the request:
[31.03.2020 05:04:05] Executed 'Functions.HttpTriggerTest' (Failed, Id=0a7695ff-020e-4410-8ffb-adc99c5a9b43) [31.03.2020 05:04:05] System.Private.CoreLib: Exception while executing function: Functions.HttpTriggerTest. System.Private.CoreLib: Result: Failure Exception: ModuleNotFoundError: No module named 'imgres' Stack:   File "C:\Users\hl\AppData\Roaming\nvm\v12.12.0\node_modules\azure-functions-core-tools\bin\workers\python\3.7/WINDOWS/X64\azure_functions_worker\dispatcher.py", line 315, in _handle__invocation_request  self.__run_sync_func, invocation_id, fi.func, args) File "C:\Programme_Tools\Python\Python3_7_4_64bit\lib\concurrent\futures\thread.py", line 57, in run  result = self.fn(*self.args, **self.kwargs) File "C:\Users\hl\AppData\Roaming\nvm\v12.12.0\node_modules\azure-functions-core-tools\bin\workers\python\3.7/WINDOWS/X64\azure_functions_worker\dispatcher.py", line 434, in __run_sync_func  return func(**params) File "D:\Di\Z_InfosTestTry\Z_Programmier\Azure\AZ12_FuncPickleProblem\azurefunc\HttpTriggerTest\__init__.py", line 33, in main  myimgresread = pickle.load(f) .

Ah, thanks for explanation and the sample code.
I think the main issue here is in the pickle module source code, shared_code/dump_pickle_file.py, the line
from imgres import ImgRes

triggers the Exception since imgres is not found in the scope of HttpTriggerTest_init_.py. Since we wrap the customer's code in an __app__ namespace.
Let me investigate more on this and reach back to you later.

May I try to clarify something.

The whole folder other is just for creating the pickle file and showing the unpacking of the pickle file. This folder has nothing to do with the Azure function (HttpTrigger) itself.

In the Azure function (HttpTrigger) before using pickle the class ImgRes is alrady used ir = ImgRes() - and at least there occurs no error.

Hi @HoLue,
Sorry for making you wait so long, please see the following code that should work in your scenario.
import logging

import azure.functions as func

import os
import sys
import pickle

# [Fix] Create a wrapper for importing imgres
from .imgres import *
from . import imgres

# [Fix] Register imgres into system modules
sys.modules['imgres'] = imgres

def main(req: func.HttpRequest) -> func.HttpResponse:
    logging.info('Python HTTP trigger function processed a request.')

    ir = imgres.ImgRes()
    ir.error = 'this works'
    logging.info('Can create instance of ImgRes - so module seems to be available, test: ' + ir.error)

    fn = os.path.join(os.path.dirname(__file__), 'myimgres.pkl')
    if os.path.exists(fn):
        logging.info('File ' + fn + ' does exist')
        with open(fn, 'rb') as f:
            logging.info('Reading pickle file...')
            myimgresread = pickle.load(f)
            # Terminal output after error here save in 'TerminalOutput.txt'
        logging.info('Pickle file read!')
        # show
        logging.info(myimgresread.img_fn)
        logging.info(myimgresread.error)
        # Output:
        # myfilename
        # no error
    else:
        logging.info('File does not exist')

    return func.HttpResponse(f"Success!")

Basically, the issue you're facing is not Azure Functions specific. The pickle serializer will also record the module import path in the .pkl file. The reason why it keeps throwing Module Not Found error during unpickling is because the imgres is never registered in the system modules.
There's a comprehensive solution for this kind of issue from the stack overflow.
Unpickling python objects with a changed module path
If there's any more question, feel free to reopen the thread. Thanks for your patience.

Thanks!!


suitable?

Hi,
I'm playing around with minuteman and am blown away by the performance!
However, I'm wondering if minuteman would be a good solution for places where there could be a possibility of anonymous and/or duplicate events..
perhaps I could use a fixed user_id namespace for anonymous visitors?
Also, I was not able to actually inspect the data using minuteman.
I get
#<Minuteman::Day:0x007fe9ea324fc0 @key="minuteman_login:successful_2014-02-08">
but cannot inspect it further.
I tried to print today_events where today_events = analytics.day("login:successful", Time.now.utc)

You should check the current master to see if suits your needs


Add Kafka Connect Sink dashboard

Adding Kafka Connect Sink Dashboard

LGTM, i think it make sense to have in the connect dashboard what would help to diagnose connect stuff.
We should backport this in https://github.com/confluentinc/jmx-monitoring-stacks as well.


When a user adds more stake to a bond that already has that users stake, their stake should be represented by a different color in the bond progress indicator

Build:

Design:
https://www.figma.com/file/aAzKHh4cA6OT2t7WFv2BQ7fB/Reporting-and-Disputing?node-id=558%3A6486

should add post launch


Vote for updating pool contract

The new update contract was successfully submitted in the ERG/XAU testnet pool. The next step is to test it #241


Update dependencies

Update yarn.lock file

Only need to update yarn.lock file when updating a minor or major dependency version.


download buttons look odd on Spartan and skinny IE

See . If IE is made fatter, the buttons don’t overlap. But it seems Spartan always wants to render the buttons on top of each other regardless of how fat I make its window.

These are running on Windows 10 Technical Preview build 10130.

Weird. I wonder if there is an update to Bootstrap to fix this? We are
on v2.1.1.
Do newer versions fix it?
On Thu, Jun 4, 2015 at 1:28 PM, Nathan Phillip Brink <
<EMAIL_ADDRESS>wrote:

These are running on Windows 10 Technical Preview build 10130.
—
Reply to this email directly or view it on GitHub
https://github.com/shanselman/SmallestDotNet/issues/50#issuecomment-109038974
.

--
Scott Hanselman
Donate to fight diabetes: http://hnsl.mn/fightdiabetes

I have reproduced the "Skinny IE" effect on Win 8 (also in Chrome).
I'm not really a web guy - don't know if upgrading bootstrap will fix.

I tried plopping bootstrap-3.3.4’s bootstrap.min.css on top of the existing bootstrap.min.css and removing the bootstrap-responsive.min.css. I’ve never used bootstrap before. I do not see this sort of problem on bootstrap’s examples, though I only took a gander at a few. I assume this is some custom styling that is at fault. The skinny IE version looks like it’s trying to lay them out vertically, which makes sense for a skinny layout. Just it doesn’t know that the buttons are as tall as they actually are or something…

And skinny chrome also gets the same thing. So there’s some issue specific to how these buttons are laid out. Mozilla doesn’t want to break the buttons up into multiple lines. Sounds like a responsive design failure ;-).


The process exit before sending event to sentry

I don't see any events on my sentry dashboard.
My AppModule looks like follow (after 2 seconds when app started it generated a test exception):

Dashboard still empty:

But I think I have found a cause.
When I go to compiled code, and then comment line with process.exit(1); (https://github.com/ntegral/nestjs-sentry/blob/master/dist/services/sentry.service.js#L52) (on src code: https://github.com/ntegral/nestjs-sentry/blob/master/lib/services/sentry.service.ts#L35)
it started working. I saw event on dashboard:

I have one conclusion, process was closed too fast, without waiting for succeed emitting event.
Any other idea?

Look this tip please: https://docs.sentry.io/platforms/node/configuration/draining/

Please let me know if you have additional questions

Please let me know if you have additional questions

@ntegral Would love to see how to implement it using Nest.js. I am aware of the documentation, but unsure how the actual implementation in Nest.js looks like. Currently we've had:
import { Injectable, Logger, OnApplicationShutdown, OnModuleDestroy } from '@nestjs/common';
import * as Sentry from '@sentry/node';

@Injectable()
export class AppService implements OnApplicationShutdown, OnModuleDestroy {
  onModuleDestroy() {
    // eslint-disable-next-line @typescript-eslint/no-floating-promises
    Sentry.close(2000).then(() => {
      process.exit();
    });
  }

  onApplicationShutdown(signal: string) {
    Logger.log(`Application is shutting down! Signal: ${signal}`); // e.g. "SIGINT"
  }
}

But does that suffice? E.g. provide enough time for app to properly shutdown and drain correctly?


Resetoffset controller

Subtask of #588 to create the shared ResetOffset Controller framework.
Proposed Changes

Create a reusable Controller for the ResetOffset CRD which is flexible enough to support different ResetOffset.Spec.Ref types, as well as custom topic/group naming conventions within a specific Ref type.
Implementation is incomplete in that it is not yet stopping / starting ConsumerGroups.  To manually test this with the distributed KafkaChannel implementation you can simple scale the Dispatcher replicas between 1 and 0 as needed.
Enhanced the lifecycle states to include concepts of "initiated" and "completed" as well tracking the status of the "Ref mapping" (turning the Spec.Ref KReference into a Kafka TopicName / ConsumerGroup ID).

Release Note
Release Notes will be provided near the end of the ResetOffset feature development.
Docs
Documentation will be provided near the end of the ResetOffset feature development.
Dev Note
To add this new Controller to an existing deployment would look like the following (taken from dev testing against the distributed KafkaChannel)...
// Create A Subscription RefMapper Factory With Custom Topic/Group Naming
subscriptionRefMapperFactory := refmappers.NewSubscriptionRefMapperFactory(controllerutil.TopicNameMapper, controllerutil.GroupIdMapper)

// Create A ResetOffset ControllerConstructor Factory With Custom Subscription Ref Mapping
resetOffsetControllerConstructor := resetoffset.NewControllerFactory(subscriptionRefMapperFactory)

// Create The SharedMain Instance With The Various Controllers
sharedmain.MainWithContext(ctx, constants.ControllerComponentName, kafkachannel.NewController, resetOffsetControllerConstructor)

...where the above is creating a "Subscription" mapper with custom TopicName / GroupId mappers.  Both layers of abstraction are need to support the desired use cases.  If someone (kafka-broker) wanted to support Triggers instead of Subscriptions then they would implement a new "Trigger" mapper.  The "distributed" and "consolidated" KafkaChannel implementations both want to use the Subscription mapper but with different TopicName / GroupId mappers.
/hold

/assign

/assign

/test pull-knative-sandbox-eventing-kafka-upgrade-tests

I find the reconcileOffsets a bit hard to read... but generally OK w/ this PR.
Perhaps any comments from @aliok ?

I finally have time to review this PR. Give me some time please.

I think the PR is good. I didn't get the drainPartitionOffsetManagerErrors part but I saw the discussion above and I don't have something to help.
LGTM

/test pull-knative-sandbox-eventing-kafka-integration-test-channel-consolidated

I find the reconcileOffsets a bit hard to read... but generally OK w/ this PR.

No one liked the implementation in offsets.go so I made another attempt at it.  I think it is better (decomposed a bit) but do keep in mind that "some" of the prior and current complexity is inherently due to the Sarama library itself.  Specifically we need to do things in the following order which just complicates the implementation...

Create Sarama Client / OffsetManager / PartitionOffsetManagers
Calculate Old/New Offsets
MarkOffset() or ResetOffset()
Commit
AsyncClose PartitionOffsetManagers
Close OffsetManager
Drain PartitionOffsetManagers.Errors() channel
Close the Sarama Client

appreciate any reviews!    You can (should) focus on just the offsets.go file and it's probably easier to just open and review that file by itself instead of looking at the Github Diff ; )


use release 20240207 of the ubuntu minimal cloud image

Switch to an older release of the ubuntu minimal cloud image, because the most recent version (20240222) introduced a bug that prevents the base image from building.

Posting this here to keep track: https://github.com/canonical/cloud-init/issues/4945  We should undo this once the cloud-init bug has been fixed and made it's way to the ubuntu image.

@marvin71 @FreakyPenguin fyi the latest cloud images have the fix


feat(fiatconnect): Add KYC checking when selecting quotes

Description
For ACT-381. Implements the logic coming off of the "Call GET /KYC on IHL" node in this flowchart. In simpler terms, this PR handles all the KYC logic required when selecting a quote on the Select Provider screen.
New KycStatus/KycLanding screens (they're the same):

Other changes
Adds some functionality to make FC-authenticated calls to IHL, turns on support for KYC in quotes.
Tested
These changes are unit tested and were tested out in the app by mocking out calls to IHL. A full e2e test, actually calling IHL is not currently possible since IHL does not have all the necessary endpoints yet.
How others should test
Does this need to be tested by QA in the next release cycle? If so please give a brief explanation of how to test these changes.
Related issues

Fixes ACT-381

Backwards compatibility
Brief explanation of why these changes are/are not backwards compatible.

Hey @MuckT as discussed in weekly meet ,we are skipping this PR
Thanks!


Fix exception cause logging in QueryResultPusher

QueryResultPusher started clipping exception causes since #14004  was merged
https://github.com/apache/druid/commit/cfd07a95b7d592a333ca51597e9bbdd68e18a88a#diff-8af2383f47d5423babf455ad7ec503ea8196e88b8b664e1d1e179163a9931f9bR211

org.apache.druid.error.DruidException: null
	at org.apache.druid.error.DruidException$DruidExceptionBuilder.build(DruidException.java:454) ~[druid-processing-2023.08.0-iap.jar:2023.08.0-iap]
	at org.apache.druid.error.DruidException$DruidExceptionBuilder.build(DruidException.java:444) ~[druid-processing-2023.08.0-iap.jar:2023.08.0-iap]
	at org.apache.druid.error.QueryExceptionCompat.makeException(QueryExceptionCompat.java:50) ~[druid-processing-2023.08.0-iap.jar:2023.08.0-iap]
	at org.apache.druid.error.DruidException.fromFailure(DruidException.java:154) ~[druid-processing-2023.08.0-iap.jar:2023.08.0-iap]
	at org.apache.druid.server.QueryResultPusher.handleQueryException(QueryResultPusher.java:211) ~[druid-server-2023.08.0-iap.jar:2023.08.0-iap]
	at org.apache.druid.server.QueryResultPusher.push(QueryResultPusher.java:177) ~[druid-server-2023.08.0-iap.jar:2023.08.0-iap]
	at org.apache.druid.server.QueryResource.doPost(QueryResource.java:218) ~[druid-server-2023.08.0-iap.jar:2023.08.0-iap]
	at jdk.internal.reflect.GeneratedMethodAccessor207.invoke(Unknown Source) ~[?:?]
	at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:?]
	at java.lang.reflect.Method.invoke(Method.java:566) ~[?:?]
	at com.sun.jersey.spi.container.JavaMethodInvokerFactory$1.invoke(JavaMethodInvokerFactory.java:60) ~[jersey-server-1.19.4.jar:1.19.4]
	at com.sun.jersey.server.impl.model.method.dispatch.AbstractResourceMethodDispatchProvider$ResponseOutInvoker._dispatch(AbstractResourceMethodDispatchProvider.java:205) ~[jersey-server-1.19.4.jar:1.19.4]
	at com.sun.jersey.server.impl.model.method.dispatch.ResourceJavaMethodDispatcher.dispatch(ResourceJavaMethodDispatcher.java:75) ~[jersey-server-1.19.4.jar:1.19.4]
	at com.sun.jersey.server.impl.uri.rules.HttpMethodRule.accept(HttpMethodRule.java:302) ~[jersey-server-1.19.4.jar:1.19.4]
	at com.sun.jersey.server.impl.uri.rules.ResourceClassRule.accept(ResourceClassRule.java:108) ~[jersey-server-1.19.4.jar:1.19.4]
	at com.sun.jersey.server.impl.uri.rules.RightHandPathRule.accept(RightHandPathRule.java:147) ~[jersey-server-1.19.4.jar:1.19.4]
	at

The QueryCompat stuff is a compatibility layer with the way that the old QueryException worked and an attempt to map it onto DruidException.
QueryExceptions are/were exceptions that are serialized across the wire, deserialized in the brokers and then converted back into exceptions.  IIRC, they don't include the stack traces because the historical-side stacktrace doesn't make sense on the broker.
The correct approach to fix odd exception reporting here is to go to the source of the exception and turn it into a meaningful DruidException which will cause the higher stacks to use the DruidException handling code instead.

Also, the ResultPusher classes are tested "through" QueryResourceTest and SqlQueryResourceTest respectively.  QueryResultPusher is an abstract class that's just trying to make the logic of the Resources similar, but the thing that actually matters is that the Resources are operating according to the API contract.  Anyway, switching around to trying to test through one of those tests will perhaps make it easier.

That said, I just double checked and adding the cause shouldn't actually change anything with wire serialization.  So that should be fine and having it log-able is good.  Let me provide some comments on the tests.

I've also done a manual before/after check - to see if this fully fixes that the Exception is not clipped out from the historical logs - and that's fixed with this patch (no more ducks eating exceptions) :D

The changes are good, the CI failures are due to some flakiness in the ITs. We re-triggered them multiple times but were unsuccessful in getting them passed. Merging on the basis that the build was green on a commit earlier, the newer commits are either changes to UTs which wouldn't affect the IT flow or master merges

thank you @rohangarg for the review and merging these changes!


Add Gradle Tasks

Name of the extension you are adding
Gradle Tasks
https://marketplace.visualstudio.com/items?itemName=richardwillis.vscode-gradle
Why do you think this extension is awesome?
It's a missing feature of VS Code. No other Gradle related extension provides the ability to list and run tasks.

Make sure that:

[x] Screenshot/GIF included (to demonstrate the plugin functionality)

[x] ToC updated

Build is failing due to some dead urls:
Issues :-(
> Links
  1. [L0486] 302 https://github.com/benc-uk/armview-vscode/raw/master/assets/readme/screen1.png  → https://raw.githubusercontent.com/benc-uk/armview-vscode/master/assets/readme/screen1.png
  2. [L0512] 404 https://raw.githubusercontent.com/oreporan/color-tabs-vscode/master/docs/example_gif.gif
  3. [L0987] 404 https://github.com/flagello/Essence

It's OK, though that many changes are upsetting. We can fix that later, merged.