improve docs for adding/updating casks/formula

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same change?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests for your changes? Here's an example.
[ ] Have you successfully run brew style with your changes locally?
[ ] Have you successfully run brew typecheck with your changes locally?
[ ] Have you successfully run brew tests with your changes locally?

I've generally found that there is a lot of confusion/repetition/occasional conflicts in the Homebrew documentation that can make it ambiguous and sometimes confusing for new contributors. The duplication/spread of information also likely makes it harder for maintainers to ensure it is kept up to date.
This is my first pass attempt at cleaning up/unifying some of the Formula / Cask docs for Adding/Updating/etc.
My intent with this PR was primarily to align the Formula / Cask sections in docs/Adding-Software-to-Homebrew.md so they follow roughly the same flow/language/etc; and secondarily to move some of the 'extra' information that was under the 'Casks' section either further down into the 'Additional Cask Details and Examples' section, or into docs/How-To-Open-a-Homebrew-Pull-Request.md.
I also updated some outdated references to --new-formula / --new-cask as per:

https://github.com/Homebrew/brew/pull/16297
https://github.com/Homebrew/homebrew-cask/pull/161724
etc

If this brew install --local work lands before this PR, then we should make further changes to the HOMEBREW_NO_INSTALL_FROM_API=1 parts in these docs:

https://github.com/Homebrew/brew/issues/16325

There is no doubt further cleanup that could be done to the docs in general (eg. moving more of the Cask specifics into the Cask Cookbook, further reducing duplication, etc), but unless it's strictly related to the changes being made here, I'd like to suggest that those changes get made in future PRs (as I am wary of the potential for scope creep / getting busy / etc and these improvements never landing)
These are also tangentially related to improving usability/guiding users:

https://github.com/Homebrew/brew/issues/16334
https://github.com/Homebrew/brew/issues/16342

Thanks for looking at this @0xdevalias - I will endeavour to have a more thorough read through in the next 24 hours

RE: https://github.com/Homebrew/brew/pull/16327#pullrequestreview-1779490805_

Thanks for the PR @0xdevalias! This is a step in the right direction but a heads-up this may take a few rounds of review to get it just right. Apologies where I've critiqued the existing documentation rather than your changes; it's hard to see and keep track of exactly what is from where (thanks git) but, either way, the documentation will be much better once this is merged.

@MikeMcQuaid No worries :) I expected a change like this would take some time in review; but it will ultimately make my (and others) lives easier; which is why I chose to do it.

I also wanted to note explicitly: I had asked you to adjust your tone previously and it seems from this PR that you have taken that feedback on board and very much improved. Thanks you for that: it's both noticed and appreciated ❤

@MikeMcQuaid On one level, I appreciate this acknowledgement; though on another, it feels disingenuine to accept it without sharing my truth alongside doing so.
It's off-topic of this PR, so I will put it in an expadandable; and I wanted to note up front that I share this with genuine good intent, in the hopes that like my efforts on the documentation in this PR, my feedback below will improve Homebrew for everyone. I don't have any particular desire to have a deep back and forth about it, and ultimately whether you take the feedback on board or not is beyond the scope of my control. It's provided from my perspective, and may not be representative of 'the whole', nor of 'objective truth'; take what works and leave the rest; there will be no ill will on my side either way.

Feedback
I want to start by saying that based on our past interactions, and the feeling that that left with me, I spent a lot of time umming and ah'ing as to whether I would even be able to share this without it being blown out of proportion, and potentially this whole PR closed and discarded in 'retaliation'. That may seem overblown, or not match your perspective of the situation; but that is the genuine feeling I was left with after our last interactions, and that 'trauma' (for lack of a better word) continues to exist now. This PR demonstrates there is no issue communicating in more general cases, particularly about the code/docs/etc, but my fear is that direct feedback will be received 'poorly', based on those recent interactions. I hope I am proved wrong.
--
RE: my originally expressing frustration in a suboptimal way (Ref); yes, I potentially could have found a way to communicate it better; but that doesn't change the core of the issue I was attempting to communicate; which was the genuine friction and frustration with how some things are done in Homebrew; and how that dampens my desire to contribute due to it feeling like it is made harder than it needs to be.
I understand why you jumped in and commented as you did (Ref), but I also want to say that in doing so, it sort of had an 'escalating' effect on things. One way that that interaction would have been improved, from my perspective, could have been opening with "I can see that you are frustrated by the Homebrew's processes here, but...", and even if you then sent the rest of your comment as it was written, it would have come across far better.
From my perception, after that comment, you jumped across to another unrelated issue I had open, and (again, from my perspective), appeared to close it (Ref) without fully addressing the most up to date point of improving the docs (Ref). I tried to communicate that (Ref), which you appeared then seemed to read a 'tone' in my messages that I wasn't intending to exist (Ref). The conversation then further de-railed as (from my perspective) I tried to explain my intent and rectify what appeared to be a misunderstanding/miscommunication (Ref), and ask you to consider the possibility that there was a misunderstanding.
Your first reply (Ref) to that seemed somewhat productive; but also seemed to double down on essentially (as I perceived it) "i am important, you are not", "my feelings are important, yours are not", "there is zero change I could have misperceived something, so it's your problem to try and fix it", etc. Regardless of how I felt about those concepts (as I perceived them to exist), I know that ultimately me disagreeing won't change things if the other party is unwilling to engage about them, so I changed tacts to trying to avoid 'triggering' your perception of 'bad tone' in my writing.
I did that by using a method I have used effectively in the past, 'translating' my normal way of writing through ChatGPT to reduce the chance of someone misinterpreting it (as text is a poor form of conveying the richer nuances of communication). (Ref) I chose to explicitly mention the fact I did that as context, as I believe open and transparent communication is important, and with the hopes that in doing so you would see that I was trying to make an effort to adjust my style in a way that you would be able to receive it better, even if I disagreed with your reasoning. I then used that method to take my 'raw' replies, 'translate' them into a style that hopefully would be interpreted better and then checked/reviewed/reiterated/tweaked the output to ensure it conveyed the truth of what I wanted to say. The feedback there was given in the same form as this feedback here is (with the same intent/caveats/etc I described in the intro of this comment); and with the genuine desire to improve the Homebrew experience for everyone. I stand by that feedback as much now as I did then.
My attempt to adapt and improve my style to reduce miscommunications seemed to have the opposite effect; and your next/last reply (Ref) seemed to miss the genuine attempt I was making, and somewhat amusingly, seeming to hold a double standard to how you were interpreting/responding to me, without (from my perception) applying those same standards to how you were responding. You appeared to take my attempt to reduce the miscommunication as some kind of 'negative'/attack'/similar; and then took essentially (what comes across as, from my perception) a 'dictator' / 'schoolyard bully' approach of locking the 2 issues, and threatening to ban me if I attempt to use ChatGPT as a communication aid in future. (Ref).
Throughout the process (with the exception of my first inarticulate signal of frustration), I was attempting to identify what appeared to be cases of miscommunication, try and understand and communicate where they appeared to be, and attempt to provide relevant context that I hoped would resolve the miscommunication. Even before using ChatGPT to translate my writing style, I changed it to be more explicit and articulate (including pointing out where it may have been my own perception, and not an objective reality, etc), in the hopes that that would reduce the miscommunications. That is also the style I have taken in writing this feedback here today. (Which is written by my own hand, and not 'translated' through ChatGPT).
This is a mini tweet thread I wrote shortly after that (Ref), in which I attempted to briefly (3 short tweets) summarise the issues of written communication, neurodiverse brains, empathy, and aides; in the space of diversity / inclusivity, and not discriminating against/punishing people for using aides, or who don't perfectly conform to your desired style.
Separately, while I don't know the specifics of the individual situations, and I don't generally base my opinions on 'hearsay' / 'gossip' / etc; after those interactions I did stumble upon a few cases where others seemed to have disagreements/miscommunications/etc with you in the past; and who seemed to feel that they were also unfairly dismissed in a 'heavy handed' way. I share this here only to highlight that there is a possibility that my feedback isn't just representative of only my own single perspective. I may be wrong in believing that; those other peoples stories may be completely different, or they may have been entirely in the wrong; and if that is the truth of it, then that's fine, and you can disregard this point.
I'm not asking for an apology; as I personally put very little value in (potentially empty) words like 'sorry'. What I find more important is people being open to receiving feedback, genuinely listening to it, genuinely reflecting on it, and when appropriate, acknowledging the mistakes/miscommunications/etc and taking action to improve that for future. That is the spirit that this feedback is shared in, and the hope that I have for it; but ultimately, whether you read/reflect/potentially change is outside of my control, and I accept that. I also accept that my feedback may entirely be my own perceptions that aren't matched by others, or by an objective view of things; and I also accept that possibility.
Anyway, now that I have articulated that and shared my truth; back to the PR in general.

@MikeMcQuaid No worries :) I expected a change like this would take some time in review; but it will ultimately make my (and others) lives easier; which is why I chose to do it.

@0xdevalias Glad to hear it!
On the feedback section: I'm happy to discuss more of it privately if there's a better forum for that (e.g. email) but am a bit cagey about putting some personal details that may be illuminating on the public internet. One bit I do want to touch on:

others seemed to have disagreements/miscommunications/etc with you in the past; and who seemed to feel that they were also unfairly dismissed in a 'heavy handed' way
...
I'm not asking for an apology; as I personally put very little value in (potentially empty) words like 'sorry'. What I find more important is people being open to receiving feedback, genuinely listening to it, genuinely reflecting on it, and when appropriate, acknowledging the mistakes/miscommunications/etc and taking action to improve that for future.

Regardless: I am sorry that my communication was non-ideal and that it negatively affected you. This was not my intention and I'm glad we've been able to get to a better place in this PR.
I think we're mostly aligned/agreed here. Where we do differ is that I put a lot of value in words like "sorry" or "I apologise" and am willing to cut people a lot more slack when they seem to be trying to communicate an apology. In our previous interactions: it did not seem to me that you were trying to apologise or had taken my feedback on board and if I had perceived that it would have gone pretty differently.
I may well have been completely wrong there, sorry if so, but acting at the volume and with the number of bad actors (to be clear: you are not one) that Homebrew does/has for over a decade has made me lean on pattern-matching instead of being able to give each situation the nuance it ideally would receive in a perfect world.

On the feedback section: I'm happy to discuss more of it privately if there's a better forum for that (e.g. email) but am a bit cagey about putting some personal details that may be illuminating on the public internet.

@MikeMcQuaid nods Understandable. Happy for you to email me on my git commit address.

Regardless: I am sorry that my communication was non-ideal and that it negatively affected you. This was not my intention and I'm glad we've been able to get to a better place in this PR.

@MikeMcQuaid Agreed.

I think we're mostly aligned/agreed here. Where we do differ is that I put a lot of value in words like "sorry" or "I apologise" and am willing to cut people a lot more slack when they seem to be trying to communicate an apology. In our previous interactions: it did not seem to me that you were trying to apologise or had taken my feedback on board and if I had perceived that it would have gone pretty differently.

@MikeMcQuaid Fair enough, and understandable. I guess that was what I was trying to get across in some of my original comments as well, that it can be useful and important to take a step back sometimes, and consider alternate viewpoints/possibilities from our default; lest it lead to misunderstandings and miscommunications that were otherwise avoidable.
Also sometimes knowing when to just walk away from the keyboard/take a breath when things feel too stressful/emotions feel high; as otherwise that can lead to reactions/interpretations made from a place other than our highest/best mind.

I may well have been completely wrong there, sorry if so, but acting at the volume and with the number of bad actors (to be clear: you are not one) that Homebrew does/has for over a decade has made me lean on pattern-matching instead of being able to give each situation the nuance it ideally would receive in a perfect world.

@MikeMcQuaid nods, again, I can totally understand why that would be the case. I don't really have a 'good solution'; but hopefully you're able to find a middle ground between the black/white of those extremes, where you're not spending unnecessary time/energy on 'bad actors'; but that also allows you to not push away the good potentials by jumping to a conclusion too quickly.

Just to be very explicit about where we are at: I appreciate this PR here but I am definitely having to spend too much time/energy right now trying to convince you to argue less, give me less life/open source maintenance advice and seek clarification without needing to critique my communication many of the times.

@MikeMcQuaid For continuity, bundled this here (Ref) so as not to fragment/have either of us need to spend more time on it than needed.

Will reconsider these changes post-block. For more context, see here: https://github.com/Homebrew/brew/issues/16342#issuecomment-1859205297


readme image resizing

Coverage remained the same at 87.907% when pulling 6f2433b0696bab5589b48b4c0d7904b246ffcb84 on abigail-4 into bffa8b3c5b3a7bfa62e4c74c91c562985064b2b9 on master.


Additional backup dialog

Description
An additional second backup dialog to confirm that user does not want a backup after account creation.
Steps to Reproduce

create a new account
in dlg "account creation successful" select to not make a backup

Expected Result
New additional pop up "are you really sure".
Actual Result
No second pop up.
Versions

1.1.27
Mainnet

Verified on CCD testnet app 1.2.31.


Pipeline node comments are not embedded in generated DAGs for custom components

Describe the issue
It appears that https://github.com/elyra-ai/elyra/pull/2396 does not generate a doc string for custom operators in the Apache Airflow/KFP DAG.
Pipeline:

Generated Airflow DAG:

To Reproduce
Steps to reproduce the behavior:

Create an Airflow  pipeline
Add any custom operator to the pipeline
Attach a comment node  to the operator
Save the pipeline
Export the pipeline and review the generated DAG
Repeat the steps for a KFP pipeline

Expected behavior
The DAG contains a doc string for each attached comment.
Deployment information
Describe what you've deployed and how:

Elyra version: 3.6/rc0

@yuhuishi-convect would you perhaps be interested in contributing this?


Test_parseTCPStats fails on s390x

What did you do?
Run go test
What did you expect to see?
All tests pass.
What did you see instead? Under which circumstances?
When running tests on s390x, the following test fails:
=== RUN   Test_parseTCPStats
    tcpstat_linux_test.go:80: want tcpstat number of bytes in tx queue 42, got 704643072
    tcpstat_linux_test.go:83: want tcpstat number of bytes in rx queue 22, got 369098752
--- FAIL: Test_parseTCPStats (0.00s)

This is due to a wrong assumption about the endianness of s390x in the test:
func Test_parseTCPStats(t *testing.T) {
    encode := func(m InetDiagMsg) []byte {
        var buf bytes.Buffer
        err := binary.Write(&buf, binary.LittleEndian, m)
        if err != nil {
            panic(err)
        }
        return buf.Bytes()
    }
...

Most, but not all modern CPUs are little-endian.
s390x is big-endian.
System information
Linux 5.19.x
Prometheus version
prometheus, version 2.39.1 (branch: HEAD, revision: dcd6af9e0d56165c6f5c64ebbc1fae798d24933a)
  build user:       root@273d60c69592
  build date:       20221007-15:57:09
  go version:       go1.19.2
  platform:         linux/s390x

Prometheus configuration file
n/a

Alertmanager version
n/a

Alertmanager configuration file
n/a

Logs
n/a

Sorry, opened in wrong project. Disregard.


Markdown button classnames can overlap with user-based classnames

We got a report from one of our users that Markdown buttons are broken.

The original issue https://github.com/Megabit/Blazorise/issues/4060

Basically, it seems that the class names that are used by this library can overlap with Bootstrap or with any other user classes. They are too generic with names table, bold, italic, etc.
I have tried to change them dynamically after the MDE instance is created with the following code:
const easyMDE = new EasyMDE(mdeOptions);

if (easyMDE.options.toolbar) {
    for (let index = 0; index < easyMDE.options.toolbar.length; ++index) {
        const element = easyMDE.options.toolbar[index];

        if (element && element.name && !element.name.startsWith("mde-")) {
            element.name = "mde-" + element.name;
        }
    }
}

and it kinda works but not 100%. From what I can observe, the .toolbar is a global object, and any change to it changes all of the instances. If there are 5 editors on a page, a race condition happens, and one or two editors are rendered without the previously added "mde-" prefix.

My question is.

How can I override MDE classnames? Is it even possible to do?
Can MDE come with predefined classnames that include a prefix? Eg. table becomes mde-table

This was brought up before in https://github.com/Ionaru/easy-markdown-editor/pull/465, but I am hesitant to make this change in the current (v2) version.
Technically the class names aren't part of the public API and therefor shouldn't be breaking change, but they are very much a public part of the rendered element. I'm afraid it will break a lot of custom styling from users.

Can it be optional? I can think of two way

Add new boolean option prefixToClasses. And if true it will add mde-(or anything else). By default it can be false.
Add a new field to the toolbar button/element object, eg.

{
    name: "heading",
--    buttonClassName: "mde-heading",
    action: EasyMDE.toggleHeadingSmaller,
    className: "fa fa-header",
    title: "Headers",
}

Both ways are opt-in and not breaking changes.

Good ideas! I think prefixToClasses will be easier to implement.

I'm having this issue as well. Bootstrap4 apparently has a class name conflict and set's 100% width on any elements with class="table". Implementing prefixToClasses seems like a good fix.

The toolbarButtonClassPrefix is now available in the @next version, this should resolve the conflict with Bootstrap.

@Ionaru Thank you. Can you tell me where is the next release expected to be released?

2.18.0 has now been released :)


Display a minimum of X chars

Split issue: https://github.com/alexandersimoes/d3plus/issues/421#issuecomment-184007551
Displaying a single digit (or char) looks bad.
There should be a minimum of displayed chars after which font is reduced or text is removed. Not sure what that minimum might be, but I would say 3 (could have it configurable).

I believe this is also related to #444. Please confirm.

This also looks to be fixed in the latest release.


Implement Admin Domain Allows API

Mastodon's Admin Domain Allows API allows an admin to configure which domains are allowed to federate. The goal of this task is to implement the following endpoints of this API in BigBone:

List all allowed domains
Get a single allowed domain
Allow a domain to federate
Delete an allowed domain

The Admin Domain Allows API as it is documented by Mastodon can be found here:
https://docs.joinmastodon.org/methods/admin/domain_allows/
Tip: A lot of other endpoints similar to this have already been implemented. In order to get an idea how to implement this, I suggest that you study the code upfront. Start with one of the *Methods.kt files.
Please consult the following documents to make sure your contribution meets our projects criteria:

Code of Conduct
Code Contribution Guidelines

It probably makes sense to wait for #333 to be reviewed and merged. I have made some decisions there that will likely influence the style of this issue here as well, such as:

admin package

Assign me this issue, please


Create VideoEncoder failed

Hi,
I encountered this error I'm using RtmpDisplay:

Device:
Samsung Galaxy J8
Android version: 9
Thank you!

Can you tell me prepareVideo params?
Also if you can share an example code to reproduce the case.

Hi @pedroSG94,
prepareVideo params i used:

Thank you!

Sorry for late response.
I was testing it but I can't reproduce your error.
According with internet that error is related with other app using that encoder or resolution not supported.
https://stackoverflow.com/questions/44764833/mediacodec-codecexception-in-samsung-galaxy-note-4


LockFileMaintenance Documentation

The Renovate documentation website shows the lockFileMaintenance option being enabled by default, yes the configuration in renovate is disabled by default.
Furthermore, it's disabled in renovate-config

Thanks, it's definitely disabled by default (way too much confusion from users when it was enabled automatically). I have fixed the website doc in https://github.com/renovateapp/renovate/commit/6506b39222ac794829345e14743f84ca85e076b4

Thank you @rarkins! I'm sorry I couldn't find the website documentation. 😢 Now I know.

It’s not intuitively located but works for now!


Improved color delta calculations

I improved the color delta calculations by including the duration of the transition. Now you can lower the value to 32 and get smooth transitions in between color shifts. Anything lower than 32 causes the keyboard to stay at a solid color.

Nice catch.
I'll test this out and merge it sometime this week.


Main.css version not updating

Discussed in https://github.com/orgs/bootscore/discussions/876

Originally posted by jamessilverstripe November 18, 2024
I've recently started using the latest version of Bootscore and have encountered an issue I've not had with previous versions. The main.css file is compiling and updating correctly but the version number in the head is set to "?ver=6.0.0". If I change the ver number or remove it completely, the correct styles load. I have turned off my cache, tried deleting main.css, have tried dev mode in wp config but nothing is working. Please help 🙏

Hm, that's strange. Tested it on parent- and child-theme and main.css version works as expected with added new version on each compile with year/month/day/time main.css?ver=202411181417?
Do you have a link to your site? Versioning of enqueued main.css happens here:
Bootscore
https://github.com/bootscore/bootscore/blob/4e37a62324f616850d53a5998d25a57743cd9d64/inc/enqueue.php#L21
https://github.com/bootscore/bootscore/blob/4e37a62324f616850d53a5998d25a57743cd9d64/inc/enqueue.php#L27-L30
Bootscore Child
https://github.com/bootscore/bootscore-child/blob/0037462f407ae6694290a2f17e3ff2c5f2edde93/functions.php#L20-L22
  // Compiled main.css
  $modified_bootscoreChildCss = date('YmdHi', filemtime(get_stylesheet_directory() . '/assets/css/main.css'));
  wp_enqueue_style('main', get_stylesheet_directory_uri() . '/assets/css/main.css', array('parent-style'), $modified_bootscoreChildCss);

Haven't received any feedback here and can't reproduce the issue, so I'm closing the issue now.


CRM457-2168: Clamby not updating

Description of change
We have been trying to update ClamAV's virus definitions nightly by running Clamby.update in our Ruby code. However this silently fails because  under the hood it's callingfreshclam locally, and freshclam isn't installed locally. There appears to be no way to trigger freshclam remotely from within the Ruby runtime.
So instead I'm adding.a series of cron-triggered Github actions that each trigger freshclam via kubectl exec. It appears as though each clamav pod in a namespace has its own set of virus definitions, so I think we need to call it on each pod. So I'm spacing out these 5 calls (1 dev, 2 uat, 2 prod) over 20 minutes to minimise risk of throttling.
In the longer term we may consider pulling a new clamav image for the pods each day but TBH I don't know how to do that so 🤷
Link to relevant ticket

FYI  - Supposedly there will be movement within weeks to start using Secure Document Storage utilities shared across LAA services. Part of Secure Document Storage will have it's own ClamAV service that handles definition updates etc that will be shared between services and that supposedly will be ready earlier - so it's actually quite likely we will be able to remove our Clam AV pods and use what Secure Document Storage provides in the actual near future.


Need Style for Marker image

The <image> from RN have bugs while updating the markes. We need something more "native" from the Map module.
P.S. Things like control the Size.
Best Regards

https://github.com/airbnb/react-native-maps/issues/100
 <View style={styles.map}>
     {this.state.markers.map(marker => (
         <Image source={{uri: marker.image}} />
     ))}
     <MapView>
         {this.state.markers.map(marker => (
             <MapView.Marker
                 key={marker.id}
                 coordinate={marker.latlng}>
                 <Image source={{uri: marker.image}} style={{width: 42, height: 42}} />
             </MapView.Marker>
         ))}
     </MapView>
 </View>

Currently you can put Image component as children of Marker to add custom style.
However, you may run into this bug https://github.com/airbnb/react-native-maps/issues/100

+1

Why do you need to change marker image size?
Could you be more specific on what exactly do you want to style? You know, that it's worth to fix Image bugs than to reimplement React for native image component, with all the limitations the standard marker layout has.

@christopherdro I think we can close it as it's old and out of scope of the library, nor in the roadmap or refers to bugs in other libs.

If you say to me that has another kind of solution better or replaceable I close it myself. Because I think this is necessary. The costumization option.

Why do you need to change marker image size?
I had tested at the time a map that I did in RN with this lib. And it featured distinct sizes in different simulators. And different smartphones. Some he burst and the others size he looked normal. So if you have anything that can keep the ratio of the marker would be great. Proportion is important.

@MichelDiz

Yes, there is a solution and it's obvious and documented: just use ReactNative view within the Marker. If you have problems with RNImage elements these are this element's issues. You may find workarounds like prefetch image in this repo.
As far as I understand your problem, different sizes are due to the pixel depth of each phone. You have to use different dpi images (@2x, @3x on iOS, and mdpi, hdpi, xhdpi... in Android), as on different phones the same image will look different: https://facebook.github.io/react-native/docs/images.html

So, you can't set image width in native marker. The image is used as is and that is documented native behavior.

@alvelig as we cannot set the image width or height in the native marker, do I need to simply recreate the image at the different pixel densities for the @2x and @3x images? For example, save the image at 480 DPI for @3x, and at 320 DPI for the @2x versions?
I am trying to clarify this as I have tested the @3x image structure (as referenced here) which does select the @3x image correctly on my LG Nexus 5, but displays it at full size (300 x 300) rather than the intended 100 x 100 as there are obviosuly no size dimensions set on the native marker.
Recreating the image at the correct DPI for the @2x and @3x appears to work. Please see the screenshot below.

@SKempin Check naming and pixels. It should work. You can try to check it in android emulators to see if this is device specific (it happens).
Naming should be according to this specs (see @4x for android): https://developer.android.com/images/screens_support/devices-density_2x.png

@alvelig This doesn't work without a style attribute, which obviously cannot be appleid to the native marker.
Creating images at the relevant DPI's does work (as illustrated above) it seems, but simply creating the same image three times larger results in it displaying three times larger (as in the blue square on the example).

If you have a square image files like this:
image.png (100x100)
<EMAIL_ADDRESS>(200x200)
<EMAIL_ADDRESS>(300x300)
<EMAIL_ADDRESS>(400x400)

it MUST give you 100x100 picture on hdpi, xdpi, xxdpi and xxxdpi devices accordingly.
If it doesn't, please make a test project to reproduce your problem and mention models and resolutions you've tried.

@alvelig This does not happen. I am using an LG Nexus 5 (real device). Unfortunately I don't have time to create a test project currently, but I experience the same issues with standard Image component in RN. If the width and height dimensions are not specified then the image displays at full size - so<EMAIL_ADDRESS>(400x400) would display at 400 x 400, instead of the intended 100 x 100. The only way to ensure it would display correct is to set the width and height on the image's style attribute.

So, first that's a react-native issue, not react-native-maps one.
Second, I recently used the same technique for my project to have a complex marker with an image and it works perfectly. I bet that if you take time and make a simple project with one marker (it should take 15 minutes or so), I'll find a problem in your code. :)
And third, also test it on the emulator with corresponding resolution to see that it works (or doesn't and there .

@alvelig I will attempt to make a project tomorrow and share with you, thanks.
Was the image a child of the marker or the prop of the marker in your project? Thanks

prop:
import markerImg from '../../images/marker.png';
import androidMarkerImg from '../../images/marker-android.png';

/***
Size | name
5275 marker-android.png
17851<EMAIL_ADDRESS>21757<EMAIL_ADDRESS>30902<EMAIL_ADDRESS>5885 marker.png
12293<EMAIL_ADDRESS>21757<EMAIL_ADDRESS>***/

<Marker
      identifier={`${shop.id}`}
      coordinate={{
        latitude: shop.location.lat,
        longitude: shop.location.lng
      }}
      image={Platform.OS === 'ios' ? markerImg : androidMarkerImg}
      onPress={goToShop(dispatch, shop.id)}
    >
<View style={{ height: 100, width: 100, alignItems: 'center', justifyContent: 'center'  }}>
  <Text>{shop.name}</Text>
</View>
</Marker>

I had to make 7 images (3 ios and 4 android) to fit this marker, because of differences in ios and android. But that was because of the complexity of the marker that's why I had to use image, otherwise I would have done it with views.

@alvelig I've now created the demo repo and I'm still getting the same results on my LG Nexus 5.
As you can see in the screenshot, the @3x image is correctly being chosen but it is displaying at 300 x 300, since the native marker cannot have a style attribute applied to make it display at 100 x 100. I have also manually inserted the 100 x 100 sized marker for comparison.
I haven't been able to test on any emulators as of yet.
Thanks and I look forward to seeing what results you get.

@SKempin it doesn't let me open it :) Please, can you check permissions for the project?

@alvelig Please try again now - https://github.com/SKempin/markers-demo
Thanks

Add this marker:
<MapView.Marker
              key={3}
              title={"@3x image"}
              coordinate={{ latitude: 51.509, longitude: -0.15 }}
            >
            <View style={{
              borderWidth: 5,
              borderColor: 'green',
              backgroundColor: 'white',
              height: 100,
              width: 100 }}>
              <Text>I'm a 100x100 box</Text>
            </View>
          </MapView.Marker>

See:

Analyse :)
See that your 100x100 image is 4 times smaller and the 400x400 on xxxhdpi is 100x100 (nearly). That is the effect I'm talking about. If you have a single image without @2x, @3x and @4x it will be 4 times smaller in xxxhdpi.
P.S. I'm not happy that the images are not exact as the box. But that's how they appear somehow on Android.

@SKempin Glad to help.
The original size should be pixel equal to @1x (hdpi)
@2x should be twice big each side - to fit 2x density (xhdpi)
@3x should be triple big each side compared to @1x  - to fit 3x density (xxhdpi)
@4x - 4 times larger then...

@alvelig thanks for your helpful responses. Isn't @1x for mdpi, @1.5x for hdpi, and so on? Or is PixelRatio something different? Here is reference to PixelRatio:
https://facebook.github.io/react-native/docs/pixelratio

The whole numbers (@1x, @2x, @3x, @4x)How would we represent the decimal densities like an image for @1.5x, @3.5x? I am guessing we can't just store an image like<EMAIL_ADDRESS>


Extract history from Scrapy repository

Per https://github.com/scrapy/scrapy/pull/1007#issuecomment-95977344 we want to retain commit messages, dates and authors of selectors history as developed in Scrapy repo

I pushed the changes extracted by the following script to master branch (still under review)
git filter-branch -f --prune-empty \
  --index-filter "git ls-files | grep -Eve '(selector|xpath)' | xargs git rm --cached"

tmpfile=$(mktemp -t splitgit.XXXXX)
trap "rm $tmpfile" EXIT
cat >$tmpfile <<!
#!/usr/bin/env ruby
old_parents = gets.chomp.gsub("-p ", " ")
new_parents = old_parents.empty? ? [] : \`git show-branch --independent #{old_parents}\`.split
puts new_parents.map{|p| "-p " + p}.join(" ")
!
chmod 755 $tmpfile
git filter-branch -f --prune-empty --parent-filter $tmpfile HEAD

Only rest moving file around and preparing a proper python packaging for selectors once we decide the name.

This is in master branch now.


Discuss usage of new_moon_numbers.r

As part of preparing to turn this repo into a package we need to understand how new_moon_numbers.r is being used and potentially convert it to a function.
Is this basically a helper script that is used to periodically update the moon_dates.csv table in PortalData?

Yeah, I believe it just adds rows to moon_dates.csv. So I think we should move it to DataCleaningScripts. It's just one of those scripts really used only by us. I don't think we need it for anything in Data Summaries.

Sounds good to me. As far as I'm concerned you can go ahead and move it at your leisure.

I'll go ahead and move it, I've been meaning to do some work making it more robust anyway


StoragePool.startService repeatedly sets storage pool properties

Replaced by https://clusterhq.atlassian.net/browse/FLOC-635
Because we don't have any code that runs exactly at pool creation time, we have no good place to put one-off configuration tasks like "set the readonly property".  So we're doing that every time we start a StoragePool now, in flocker/volume/filesystems/zfs.py.
It would be simpler and better if we could do these things just once.

We are moving our development planning to JIRA. This issue is now being tracked at https://clusterhq.atlassian.net/browse/FLOC-635. You are welcome to file additional issues in GitHub if that's easier for you.


CORS form response, it is not necessary include the UUID

Type of issue

[ ] Bug report
[x] Feature request
[ ] Support request

Uploader type

[x] Traditional
[ ] S3
[ ] Azure

Feature request details
CORS DOCS Handling iframe CORS upload requests server-side
and the valid JSON portion must include the UUID of the associated file.
why?
In other cases uuid is not necessary, but it's need the UUID when CORS in the form response JSON.
form.upload.handler.js#L114
var fileId = getFileIdForIframeName(iframeName),
      response = handler._parseJsonResponse(message),
      uuid = response.uuid, // here
      onloadCallback;

I think it is not necessary~

It is necessary

@rnicholus it‘s for security？

https://github.com/FineUploader/fine-uploader/blob/develop/client/js/upload-handler/form.upload.handler.js#L88
uuid  is already statemented


During train Style_ Encoder's style_img using an image or the corresponding. npy file of Mel's spectrogram

During train Style_ Encoder's style_img using an image or the corresponding. npy file of Mel's spectrogram.I found that make_ mel_ Style.py saves. npy files, while the data used for training is obtained from images

Close due to inactivity.


update to CPU clock speeds as per: https://cloud.google.com/compute/d…

…ocs/cpu-platforms
Awesome tool, thanks for putting it together, I have a PR here to adjust CPU clock speeds for some platforms, see: https://cloud.google.com/compute/docs/cpu-platforms

Thank you very much.


pg_config.h: NetBSD support

This is the same as pganalyze/pg_query_go#72 except one level higher.
NetBSD has strchrnul too but with a slightly different prototype. Without this change, there is a compiler error for a conflicting declaration.

Can someone merge this, because I cannot :)

Can someone merge this, because I cannot :)

Looks like there was a seemingly random build failure - will merge after thats resolved (hopefully on a re-run, that I started just now).


Combine query_as!() with runtime statements

Say we have a select statement:
SELECT * FROM users
ORDER BY id

Now we'd like to change it so ORDER BY can accept any column (not just id), but we know that it can't be done via prepared statements.
Given that limit, is it possible to combine sqlx::query_as!() for compile-time verifiable part with statement generated in runtime? Like so:
let column = "age";

// Ensures schema compliance in compile-time.
let mut users = sqlx::query_as!(User, "SELECT * FROM users ");

// Allows to modify statement in runtime.
users.push(format!(" ORDER BY {column}"));

// Now sorted by age.
let users = users.fetch(&pool).await;

There's existing discussion in #1488 and #1491


Check claims (email) before creating a new cookie, without asp. core identity store using asp net core social login

I'm working on my hobby project where I'have implemented social login via Google.
now I want to prevent this so that only certain user can sign in into the app, As I found that there is no way to restrict this on google OAuth side, So I have added a table to store the email and role.
if the email address is not found in that table I want to prevent a user from signing.
services
           .AddAuthentication(options =>
           {
               options.DefaultScheme = CookieAuthenticationDefaults.AuthenticationScheme;
           })
           .AddCookie()
           .AddGoogle(googleOption =>
           {

               googleOption.ClientId = Configuration["Authentication:Google:ClientID"]; ;
               googleOption.ClientSecret = Configuration["Authentication:Google:ClientSecret"];
               googleOption.Events.OnRemoteFailure = (context) =>
               {
                   context.HandleResponse();
                   return context.Response.WriteAsync("<script>window.close();</script>");
               };
               googleOption.Events = new Microsoft.AspNetCore.Authentication.OAuth.OAuthEvents
               {
                   OnTicketReceived = async ctx =>
                   {
                       string emailAddress = ctx.Principal.
                                               FindFirstValue("http://schemas.xmlsoap.org/ws/2005/05/identity/claims/emailaddress");
                       var db = ctx.HttpContext.RequestServices.GetRequiredService<DbContext>();
                       var roles = await db.EmailRoles.Where(c => c.Email == emailAddress).ToListAsync();
                       if (roles.Count > 1)
                       {
                           var claims = new List<Claim>();
                           foreach (var item in roles)
                           {
                               claims.Add(new Claim(ClaimTypes.Role, item.Role));
                           }
                           var appIdentity = new ClaimsIdentity(claims);
                           ctx.Principal.AddIdentity(appIdentity);
                       }
                   }
               };
           });

https://stackoverflow.com/questions/56729072/check-claims-email-before-creating-a-new-cookie-without-asp-core-identity-st
Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d2229fc6-f8c8-952e-e567-b1d5a463055a
Version Independent ID: b18a015b-914d-f014-f711-120d208904d9
Content: Use cookie authentication without ASP.NET Core Identity
Content Source: aspnetcore/security/authentication/cookie.md
Product: aspnet-core
Technology: aspnetcore-security
GitHub Login: @Rick-Anderson
Microsoft Alias: riande

Hello! Thanks for contacting us. This sounds like a general question about using ASP.NET Core. While we try to look at and respond to all issues, for questions like this we recommend posting to a community support group like Stack Overflow with the asp.net-core tag like you have.

Answer https://stackoverflow.com/a/56748954/5678666


Issue 578: Find schema version by fingerprint of schema text.

Adds a new REST endpoint to find a schema version by the fingerprint of
the schema text.

@joaopedroantonio Thanks for showing interest in the project. May I know the circumstances that you are trying to address with this PR?

@raju-saravanan Sure, I can give you some context. At DefinedCrowd we're improving our event sourcing infrastructure and as part of that initiative we want to add Schema Registry to store our schema definitions.
For critical services, we want to register new schema versions at deploy time and publish messages without having to contact the Schema Registry in runtime. To accomplish this, instead of using the schema version id in the message, we can use the schema text fingerprint.
This has a couple downsides, the increase in the message size and the (remote) possibility of having a hash collision but it's a trade off we're willing to make for increased resiliency and easier scaling in critical parts of our architecture.

@joaopedroantonio So will you be exposing new ser des protocol in SerDesProtocolHandlerRegistry to use fingerprint to serialize and deserialze message ? We may have a scenario where we have two schema version with same fingerprint esp when two schemas are canonically same but have different default values for certain fields in the schema, in that case with the current implementation - which picks up a first schema from the result set - deserailized message might not be the one a use expects. We can resolve this by sorting the results set and pick up with schema version with latest timestamp. Will you be ok with this ?  @satishd  and @michaelandrepearce can you guys share your opinions on this ?

@raju-saravanan I wasn't thinking about implementing a new protocol, as we'll be using the Schema Registry in our scope solely to store and manage the schemas. My suggestion is that we keep this PR simply for exposing the REST endpoint and I'll create a new one to implement the new Protocol. What you think?
Regarding the scenario of having two schema version with the same fingerprint, I agree with returning the latest schema version rather than the first or we could even make this endpoint return all of them. I'm find with both options. What you think?

@joaopedroantonio:
I have answered your question below:

Let's come back to implementing a new protocol if somebody else in the community needs it.
For two schemas with the same fingerprint let's return the schema version with the latest timestamp.

I have couple of more questions,

Are you planning on exposing this API on schema registry client ?
Can you test a write a test case for the API you have exposed ?

@joaopedroantonio:
I have answered your question below:

Let's come back to implementing a new protocol if somebody else in the community needs it.
For two schemas with the same fingerprint let's return the schema version with the latest timestamp.

I have couple of more questions,

Just to be clear, you will not be using schema registry during serialization and deserialization of messages. The API is only for your reference/debugging purpose to see what is the corresponding schema version for a given fingerprint.
Exactly, we'll handle serialization/deserizalization on our side (at least for now).
Are you planning on exposing this API on schema registry client ?
Wasn't planning to but I'll take a look into it and might end up implementing it for the sake of fun. I'll keep it on a separate PR though.
Can you test a write a test case for the API you have exposed ?
Yes, I'll do it.

I'll try to update this PR until the end of the week with the two changes we've discussed:

Returns the schema version with the latest timestamp.
Write a test case for the API exposed.

@raju-saravanan implemented the changes discussed previously, let me know your thoughts. :)

@joaopedroantonio : Left few more comments to address.

Thank you for the comments @raju-saravanan, it think they're addressed. :)


adding jumping robot to ci

Adding jumping robot to ci, and update according to new api changes.

@gchenfc take a look at cable robot failures above.

I think they're jumping-robot failures?
/home/runner/work/GTDynamics/GTDynamics/build/python/jumpingrobot.cpp: In lambda function:
/home/runner/work/GTDynamics/GTDynamics/build/python/jumpingrobot.cpp:75:389: error: invalid initialization of reference of type ‘const KeyVector&’ {aka ‘const std::vector<long unsigned int, tbb::tbb_allocator<long unsigned int> >&’} from expression of type ‘const std::vector<long unsigned int>’
   75 |     m_.def("AddSourceMassCollocationFactor",[](gtsam::NonlinearFactorGraph* graph, const std::vector<gtsam::Key>& mdot_prev_keys, const std::vector<gtsam::Key>& mdot_curr_keys, gtsam::Key source_mass_key_prev, gtsam::Key source_mass_key_curr, gtsam::Key dt_key, bool isEuler, const boost::shared_ptr<gtsam::noiseModel::Base> cost_model){ gtdynamics::AddSourceMassCollocationFactor(graph, mdot_prev_keys, mdot_curr_keys, source_mass_key_prev, source_mass_key_curr, dt_key, isEuler, cost_model);}, py::arg("graph"), py::arg("mdot_prev_keys"), py::arg("mdot_curr_keys"), py::arg("source_mass_key_prev"), py::arg("source_mass_key_curr"), py::arg("dt_key"), py::arg("isEuler"), py::arg("cost_model"));
      |                                                                                ^~~~~~~~~~~~~~
In file included from /home/runner/work/GTDynamics/GTDynamics/build/python/jumpingrobot.cpp:22:
/home/runner/work/GTDynamics/GTDynamics/gtdynamics/jumpingrobot/factors/JRCollocationFactors.h:40:65: note: in passing argument 2 of ‘void gtdynamics::AddSourceMassCollocationFactor(gtsam::NonlinearFactorGraph*, const KeyVector&, const KeyVector&, gtsam::Key, gtsam::Key, gtsam::Key, bool, const shared_ptr&)’
   40 |     gtsam::NonlinearFactorGraph* graph, const gtsam::KeyVector& mdot_prev_keys,
      |                                         ~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~
make[2]: *** [python/CMakeFiles/gtdynamics_py.dir/jumpingrobot.cpp.o] Error 1
python/CMakeFiles/gtdynamics_py.dir/build.make:119: recipe for target 'python/CMakeFiles/gtdynamics_py.dir/jumpingrobot.cpp.o' failed
make[2]: *** Waiting for unfinished jobs....
CMakeFiles/Makefile2:1273: recipe for target 'python/CMakeFiles/gtdynamics_py.dir/all' failed
Makefile:145: recipe for target 'all' failed
make[1]: *** [python/CMakeFiles/gtdynamics_py.dir/all] Error 2
make: *** [all] Error 2
Error: Process completed with exit code 2.

The errors were just listed directly after cablerobot.cpp probably because the -j make option is turned on on the CI.
Nevertheless @yetongumich, taking a look, I think you can just use const gtsam::KeyVector& instead of const std::vector<gtsam::Key>& in the .i file.  Since it's defined in gtsam's preamble/specializations with implicitly_convertible (and handles TBB allocator), then it should still be transparent in python
https://github.com/borglab/gtsam/blob/d7f048b6c4d28708706c5bab4032808df04eb0a0/python/gtsam/specializations/gtsam.h#L14-L20

See the first half of #208
Ignore part about MacOS needing TBB

Passing all CI tests and merge.


Add the function to copy the code generated by ChatGPT separately.

This is much more convenient for me.

good idea, I will incorporate this feature in the next version

updated, check v1.26.0


Cannot persist new entity if primary key contains a foreign key and the referenced object is in state new and its id is not assigned

As the id of the referenced entity is generated, when UnitOfWork#persistNew computes the primary key, it may contain some null values.
Because of https://github.com/doctrine/doctrine2/commit/1cb8d790b64f542406a576b878d67abe284e7275 , UnitOfWork#addToIdentityMap does not allow this anymore, which is a good thing.
We need to delay the insertion into identityMap and entityIdentifiers after the actual insert to ensure that we have a complete primary key, as we do with post-insert ID generators.
This kinda worked in 2.5, but in the end identityMap and entityIdentifiers contained wrong values anyway.

Is this PR ready to be merged ?

It is IMHO, but I'm not the maintainer. @Ocramius, is it OK for you ?

Actually I think this is breaking a lot of projects as it's not possible anymore after upgrading to 2.6 to persist any entity related to a new one in the same batch. Can we get this merged or at least a feedback to get it merged asap?

I'm simply busy with other work stuff ATM - don't expect any deep involved OSS work from me for a while, sorry.

Can we get at least another maintainer have a look at this? It's a really high priority bug to fix

The code provided here doesn't follow our coding standards and we already had a test that reproduces this issue in #6701 (with a simpler set of entities too). I'll try to combine everything and adjust stuff to make this part of v2.6.1 (also checking for any kind of performance impact).

Fix was ported to #6701 and everything works as expected (with a minor, acceptable, performance impact) and it will be released on v2.6.1 ASAP.
@NicolaF thank you for you help on the fix.

This is a huge news, thank you for your time!


Update documention on how to get selected day(s)

Hello,
Thank you for this nice lightweight calendar. I am able to make it show up but then I got stuck as I cannot seem to find a way on how to retrieve the selected day / range.
I have looked at issue #8 but this no longer seems to work.
Can you tell me how to get the selected day/range? I was expecting to get it as an argument in my callback but that doesn't seem to be the case.
Once I have this working, I can send a PR to update the documentation on this point.
Thank you.

I have answered my own question and written the documentation, see PR:
https://github.com/mauroreisvieira/hello-week/pull/15

Hi @roland-d thanks for you PR.


Include complex-type-handling quickstarts in the assembler

Description
Part of https://github.com/apache/incubator-pinot/issues/6904
Include complex-type-handling quickstart examples in the assembler

Codecov Report

Merging #6961 (3ce9f06) into master (71e156c) will decrease coverage by 7.93%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #6961      +/-   ##
============================================
- Coverage     73.28%   65.34%   -7.94%
  Complexity       12       12
============================================
  Files          1432     1432
  Lines         71034    71034
  Branches      10291    10291
============================================
- Hits          52056    46419    -5637
- Misses        15489    21270    +5781
+ Partials       3489     3345     -144

Flag
Coverage Δ
Complexity Δ

integration
?
?

unittests
65.34% <ø> (+0.01%)
12.00 <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71e156c...3ce9f06. Read the comment docs.


Bot randomly not working anymore?

Expected Behavior
it working?
Actual Behavior
cd '/Users/sooriay/PokemonGo-Bot/' && '/usr/local/bin/pythonw'  '/Users/sooriay/PokemonGo-Bot/pokecli.py'  && echo Exit status: $? && exit 1
sooriay:~ sooriay$ cd '/Users/sooriay/PokemonGo-Bot/' && '/usr/local/bin/pythonw'  '/Users/sooriay/PokemonGo-Bot/pokecli.py'  && echo Exit status: $? && exit 1
[2016-07-30 08:55:59] [x] PokemonGO Bot v1.0
[2016-07-30 08:55:59] [x] Configuration initialized
[2016-07-30 08:56:00]
[2016-07-30 08:56:00] [x] Address found: Redfern St, Redfern NSW 2016
[2016-07-30 08:56:00] [x] Position in-game set as: (-33.8929081,<PHONE_NUMBER>, 0.0)
[2016-07-30 08:56:00]
Traceback (most recent call last):
File "/Users/sooriay/PokemonGo-Bot/pokecli.py", line 220, in
main()
File "/Users/sooriay/PokemonGo-Bot/pokecli.py", line 206, in main
bot.start()
File "/Volumes/UserData/Users/sooriay/PokemonGo-Bot/pokemongo_bot/init.py", line 31, in start
self._setup_api()
File "/Volumes/UserData/Users/sooriay/PokemonGo-Bot/pokemongo_bot/init.py", line 151, in _setup_api
player = response_dict['responses']['GET_PLAYER']['player_data']
TypeError: 'bool' object has no attribute 'getitem'
sooriay:PokemonGo-Bot sooriay$
Steps to Reproduce
Other Information
OS:
Git Commit: (run 'git log -n 1 --pretty=format:"%H"' and paste it here)

Sometimes there is a simple 'miscommunication' between the client and server, trying to re-execute the command might already 'fix' the problem for you :)
Another thing you could do is update to the 'dev' branch, which is not necessarily stable, but I haven't had that issue ever since I jumped to the dev branch myself :)

Okay, also after 30minutes or so of running the bot i get some error which causes me to restart the bot. Il post the log soon once it happens, and il try re execute it now and see

Ok! Thanks, working now. Just re-executed it

i'm having the same problem, how do i re-execute?


Add a table of descriptions for the azure deploy parameters.

Let's move the table into a new markdown file and link it from the "fill in the wizard" text in the deployment section. In that way, we have the parameter explanation right next to where they're required.

Ok sounds good! I also realized I forgot a couple details so I'll add them and move this into a separate file.


React-Redux Group project setup

https://github.com/jonas-45/space-travellers-hub/projects/1
We are two team members; @jonas-45 and @rica213

Hi @jonas-45 and @rica213 👋,
Your project is complete!  There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉
Highlights
✔ Kanban board set up is correct
✔ Issue is opened as specified
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Remember to tag me in your question so I can receive the notification.

As described in the Code reviews limits policy  you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

Thank you for your time and effort.


Add file format.

This will add a template file format which can be used for file download. This will support streams and complete files.

The file format has been added and has support for optional headers.


Stylus inside style tags?

Hi there.
Is there a way I can use gulp-stylus to process a html file with style tags?

This only passes the input files to stylus.
The only way I have seen is to process the html, such as: https://stackoverflow.com/questions/12272936/is-it-possible-to-use-stylus-plugins-with-inline-stylus-code-embedded-in-a-jade
The official response:
https://github.com/pugjs/pug/issues/760
Now.... this is what I would do:
Create a simple parser for getting all the <style>
const rgx = /<style*>([^<>]+)<\/style>/
const input = '<style> body background: white </style>'
input.match(rgx)[1]
// => ' body background: white '

Then I'd run stylus over it and inject the css back into the style tags.
More complete example:
const stylus = require('stylus')
const rgx = /(<style*>)([^<>]+)(<\/style>)/

const input = '<head> <style> body { background: white } </style> </head>'

const matches = rgx.exec(input)

const before = input.substr(0, matches.index)
const after = input.substr(matches.index + matches[0].length)
const prefix = matches[1]
const source = matches[2]
const suffix = matches[3]

stylus.render(source, (err, css) => {
  console.log(before + prefix + '\n' + css + suffix + after)
})

output:
<head> <style>
body {
  background: #fff;
}
</style> </head>

Thanks. That was very generous of you to take the effort to explain how I might be achieve this! I'm going to give it a go.
I'm using web components so being able to do this will be a real life saver, as at the moment I'm having to manually process the stylus files and copy them into the html file. 😄


Cody doesn't refer to the current file in some cases where obvious

Customer reports

https://sourcegraph.slack.com/archives/C04MSD3DP5L/p1694454085492699
https://sourcegraph.slack.com/archives/C04MSD3DP5L/p1693507735454299

I hit this as well: https://sourcegraph.slack.com/archives/C05AGQYD528/p1694206443472349


Optional types do not get type casted by dtyper

I am trying to use dtyper with a package that has a command with optional parameters, in this case it is Optional[List[str]]. When called from the command line this is converted to an empty list, but when using dtyper it is returned as None, which is causing the command to fail.
The actual conversion happens in click's Parameter.process_value call.
The package I'm fiddling with is dbx, if you install that then the below is a reproducible example. I will try to find one that is simpler, as I believe dbx requires configuration files and potentially authentication to get to the point of failure and I don't know typer or click well enough to make my own example.
import dtyper
from dbx.commands.deploy import deploy

def dbx_deploy():
    catalog: str = sys.argv[1]
    workflow_name = f"{PACKAGE_NAME}_({catalog})"

    file_path = os.path.join(os.getcwd(), f"{catalog}_deployment.yaml")

    _deploy = dtyper.function(deploy)
    _deploy(workflow_name=workflow_name, deployment_file=file_path)

I couldn't get the test script to run, my attempts (with fixes after each phase) below.
Do you get the same behavior with typer?  dtyper is a thin wrapper over typer, it's not clear how it would introduce any new behavior like that that typer didn't have before.
(fix) tom@bolt:/code/dtyper$ python test_dbx.py
Traceback (most recent call last):
  File "test_dbx.py", line 15, in <module>
    dbx_deploy()
  File "test_dbx.py", line 6, in dbx_deploy
    catalog: str = sys.argv[1]
NameError: name 'sys' is not defined
(fix) tom@bolt:/code/dtyper$ python test_dbx.py
Traceback (most recent call last):
  File "test_dbx.py", line 16, in <module>
    dbx_deploy()
  File "test_dbx.py", line 7, in dbx_deploy
    catalog: str = sys.argv[1]
IndexError: list index out of range
(fix) tom@bolt:/code/dtyper$ python test_dbx.py test
Traceback (most recent call last):
  File "test_dbx.py", line 16, in <module>
    dbx_deploy()
  File "test_dbx.py", line 8, in dbx_deploy
    workflow_name = f"{PACKAGE_NAME}_({catalog})"
NameError: name 'PACKAGE_NAME' is not defined
(fix) tom@bolt:/code/dtyper$ python test_dbx.py test
Traceback (most recent call last):
  File "test_dbx.py", line 16, in <module>
    dbx_deploy()
  File "test_dbx.py", line 13, in dbx_deploy
    _deploy(workflow_name=workflow_name, deployment_file=file_path)
  File "/Users/tom/synthetic/code/dtyper/dtyper.py", line 284, in wrapped
    return typer_command(*bound.args, **bound.kwargs)
  File "/Users/tom/synthetic/code/dtyper/.direnv/python-3.7/lib/python3.7/site-packages/click/core.py", line 1157, in __call__
    return self.main(*args, **kwargs)
  File "/Users/tom/synthetic/code/dtyper/.direnv/python-3.7/lib/python3.7/site-packages/click/core.py", line 1077, in main
    with self.make_context(prog_name, args, **extra) as ctx:
  File "/Users/tom/synthetic/code/dtyper/.direnv/python-3.7/lib/python3.7/site-packages/click/core.py", line 939, in make_context
    self, info_name=info_name, parent=parent, **extra  # type: ignore
TypeError: __init__() got an unexpected keyword argument 'workflow_name'
(fix) tom@bolt:/code/dtyper$

Well, let me know if you can get me more information, and I'll look into it!
I'm fairly sure that the issue is in fact dtyper, but programming is hard. :-)
Let me know how I can help, but I'm going to close this for right now so it isn't hanging over my head. :-D


Computation hangs forever with jax > 0.4.30

Description
Jax is hanging forever on certain calculations for versions > 0.4.30.
This problem is proving extremely difficult to diagnose and create a minimal repro for, but it is popping up in several repos that I maintain including fmmax and invrs_opt.
I will try to get a simplified reproduction, but here is some code that creates the problem (colab).
import jax
import jax.numpy as jnp
from totypes import types

from invrs_opt.optimizers import lbfgsb

def optimization_with_vmap(steps):
    print("running", flush=True)

    def initial_params_fn(key):
        del key
        return types.Density2DArray(array=jnp.ones((3, 3)))

    keys = jax.random.split(jax.random.PRNGKey(0), num=2)
    opt = lbfgsb.density_lbfgsb(beta=2, maxcor=20)

    params = jax.vmap(initial_params_fn)(keys)
    print("vmap params initialized", flush=True)
    state = jax.vmap(opt.init)(params)
    print("vmap state initialized", flush=True)

    @jax.jit
    @jax.vmap
    def step_fn(state):
        params = opt.params(state)
        dummy_value = jnp.array(1.0, dtype=float)
        dummy_grad = jax.tree_util.tree_map(jnp.ones_like, params)
        state = opt.update(grad=dummy_grad, value=dummy_value, params=params, state=state)
        return state, dummy_value

    for i in range(steps):
        print(f"vmap step {i}", flush=True)
        state, value = step_fn(state)

    for k in keys:
        print("If we don't print the key and use jax > 0.4.30, the code hangs.", flush=True)
        # print(f"{k=}", flush=True)
        params = initial_params_fn(k)
        print("params initialized", flush=True)
        state = opt.init(params)
        print("state initialized", flush=True)
        for i in range(steps):
            print(f"step {i}", flush=True)
            params = opt.params(state)
            dummy_value = jnp.array(1.0, dtype=float)
            dummy_grad = jax.tree_util.tree_map(jnp.ones_like, params)
            state = opt.update(grad=dummy_grad, value=dummy_value, params=params, state=state)

optimization_with_vmap(steps=10)

The code with the print statement commented out will hang for jax 0.4.34, and will execute as expected for jax 0.4.30. Bizarrely, it will run in both cases if the print statement is uncommented. As I mentioned, it is popping up in several different places, and so I don't believe that something very specific to this code is to blame. I experienced this problem locally, on github workflows, and on colab.
I'll try to create a smaller repro but just want to get this issue filed first.
System info (python version, jaxlib version, accelerator, etc.)
Colab cpu, jax 0.4.34

I am finding that adding a jax.block_until_ready to the arguments of a jax.pure_callback helps in at least one case. I will investigate this in a few other cases.

Ok, here is a simpler reproduction.
import jax
import jax.numpy as jnp
from invrs_opt.optimizers import lbfgsb
from totypes import types

def optimization_with_vmap(steps):
    def initial_params_fn(key):
        del key
        return types.Density2DArray(array=jnp.ones((3, 3)))

    keys = jax.random.split(jax.random.PRNGKey(0), num=2)
    opt = lbfgsb.density_lbfgsb(beta=2, maxcor=20)

    params = jax.vmap(initial_params_fn)(keys)
    print("vmap params initialized", flush=True)
    state = jax.vmap(opt.init)(params)
    print("vmap state initialized", flush=True)

    @jax.jit
    @jax.vmap
    def step_fn(state):
        params = opt.params(state)
        dummy_value = jnp.array(1.0, dtype=float)
        dummy_grad = jax.tree_util.tree_map(jnp.ones_like, params)
        state = opt.update(grad=dummy_grad, value=dummy_value, params=params, state=state)
        return state, dummy_value

    for i in range(steps):
        print(f"vmap step {i}", flush=True)
        state, value = step_fn(state)
        # Without this `block_until_ready`, this hangs after ~32 steps.
        jax.block_until_ready((state, value))

optimization_with_vmap(steps=100)

There is a block_until_ready call which seems to be critical in avoiding the hanging behavior. When removed, on colab CPU runtime it tends to hang after 32 steps.

It seems this issue is related to use of jax types inside functions called via jax.pure_callback. I will close this and file a new issue that is more specific.


feat(thumbnail): add props to manage cors and listen window's resizing

General summary
Add props to manage CORS and enable listening to window resizing on Thumbnail component
Check list

[ ] (if has style) Add need: review-integration label
[x] (if has textual documentation) Add need: review-doc label
[x] (if has code) Add need: review-frontend label
[x] (if has react) Check through the react dev check list
[x] (if fix or feature) Add need: test label

Check out the contribution guide for general guidelines for submissions to the design system.

not sure if designers are supposed to do something on need: review-integration
but still, I checked, and visually it seems ok for me 👍


PyFolio install from PyPI is broken on Python 3 due to outdated wsgiref dependency.

$ mkvirtualenv -p $(which python3) test
$ pip install pyfolio
Collecting pyfolio
  Using cached pyfolio-0.1.tar.gz
Collecting funcsigs>=0.4 (from pyfolio)
  Using cached funcsigs-0.4-py2.py3-none-any.whl
Collecting matplotlib>=1.4.0 (from pyfolio)
  Using cached matplotlib-1.4.3.tar.gz
Collecting mock>=1.1.2 (from pyfolio)
  Using cached mock-1.3.0-py2.py3-none-any.whl
Collecting numpy>=1.9.1 (from pyfolio)
  Using cached numpy-1.9.3.tar.gz
Collecting pandas>=0.15.0 (from pyfolio)
Collecting pyparsing>=2.0.3 (from pyfolio)
  Using cached pyparsing-2.0.3-py2.py3-none-any.whl
Collecting python-dateutil>=2.4.2 (from pyfolio)
  Using cached python_dateutil-2.4.2-py2.py3-none-any.whl
Collecting pytz>=2014.10 (from pyfolio)
  Using cached pytz-2015.6-py2.py3-none-any.whl
Collecting scikit-learn>=0.15.0 (from pyfolio)
  Using cached scikit-learn-0.16.1.tar.gz
Collecting scipy>=0.14.0 (from pyfolio)
  Using cached scipy-0.16.0.tar.gz
Collecting seaborn>=0.6.0 (from pyfolio)
  Using cached seaborn-0.6.0.tar.gz
Collecting statsmodels>=0.5.0 (from pyfolio)
  Using cached statsmodels-0.6.1.tar.gz
Collecting wsgiref>=0.1.2 (from pyfolio)
  Using cached wsgiref-0.1.2.zip
    Complete output from command python setup.py egg_info:
    Traceback (most recent call last):
      File "<string>", line 20, in <module>
      File "/tmp/user/1000/pip-build-ax77mnu_/wsgiref/setup.py", line 5, in <module>
        import ez_setup
      File "/tmp/user/1000/pip-build-ax77mnu_/wsgiref/ez_setup/__init__.py", line 170
        print "Setuptools version",version,"or greater has been installed."
                                 ^
    SyntaxError: Missing parentheses in call to 'print'

This looks like it's fixed on master, but we haven't yet pushed to PyPI.
cc @twiecki

Any updates on this? Would love to start working with PyFolio but can't get it installed.

@timverheyden I just uploaded 0.2 to pypi, can you try if it works for you and let me know?

Works as a charm. Thanks man! Excellent work!!!


Fix relation when getting a delivery work parent edge

@scoen can you please have a look?

I think the versioning won't be affected adversely.


networking frezzes

hello im trying to get enet working but it just freezes straight im using your enet example from the documentation.

I just tried it and it works okay.  Make sure you copy the client code into client.lua, and the server code into server.lua.  Then start the server with lovr server.lua and run the client with lovr client.lua and you'll see them connect and send a message between each other.

yeah but it  just keeps a white screen and do nothing. i tryed even without initializing the lovr part just from lua but its keeps refusing any kind of connection. same on quest 2 also on windows 11

Have you gotten 2 lovr instances on the same computer to connect to each other (localhost) successfully, or are you still trying to get that working?  There are a lot of things that can go wrong when trying to connect 2 different computers together, so getting it working locally is a good sanity check.
In what way is it refusing the connection?  Are you getting any errors?  Do you see any of the prints?

i tryed but both hangs on a white screen.  strangly if i make a c++ server and use python it connect to m c++ but in lovr   neworking is semingly broken all together im using windiws 11


chore: Update Add command help text

Closes #64

Codecov Report

Merging #65 into master will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##             master      #65   +/-   ##
=========================================
  Coverage     72.30%   72.30%
  Complexity      410      410
=========================================
  Files            72       72
  Lines          1278     1278
  Branches        130      130
=========================================
  Hits            924      924
  Misses          316      316
  Partials         38       38

Impacted Files
Coverage Δ
Complexity Δ

.../java/seedu/address/logic/commands/AddCommand.java
100.00% <100.00%> (ø)
8.00 <1.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e89cd1a...effedc5. Read the comment docs.


Finished run command and custom printing

As discussed during our sync for a future project! 😄
Example gif
I'm trying to break things, but you can tell it all works!

Thank you @syrusakbary ! 😄


Webserver Crashed when serving CommandR-plus

System Info
official tgi image: ghcr.io/huggingface/text-generation-inference:2.0
Information

[X] Docker
[ ] The CLI directly

Tasks

[X] An officially supported command
[ ] My own modifications

Reproduction
web crashed with prompts of some formats.
The prompt:
<|START_OF_TURN_TOKEN|><|SYSTEM_TOKEN|> # Safety Preamble
The instructions in this section override those in the task description and style guide sections. Don't answer questions that are harmful or immoral.

# System Preamble
## Basic Rules
你是一个专业 .........

the error log:
thread 'tokio-runtime-worker' panicked at /usr/src/router/src/server.rs:180:45:
byte index 1000 is not a char boundary; it is inside '你' (bytes 999..1002) of `<|START_OF_TURN_TOKEN|><|SYSTEM_TOKEN|> # Safety Preamble
The instructions in this section override those in the task description and style guide sections. Don't answer questions that are harmful or immoral.

# System Preamble
## Basic Rules
你是一个`[...]
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
2024-04-23T08:26:48.209311Z ERROR text_generation_launcher: Webserver Crashed
2024-04-23T08:26:48.209348Z  INFO text_generation_launcher: Shutting down shards
2024-04-23T08:26:48.480196Z  INFO shard-manager: text_generation_launcher: Shard terminated rank=3
2024-04-23T08:26:48.650012Z  INFO shard-manager: text_generation_launcher: Shard terminated rank=2
2024-04-23T08:26:48.766797Z  INFO shard-manager: text_generation_launcher: Shard terminated rank=0
2024-04-23T08:26:48.958610Z  INFO shard-manager: text_generation_launcher: Shard terminated rank=1
Error: WebserverFailed

Expected behavior
respond normally

I run with debug mode, the code blow leads to crash.
tracing::debug!("Input: {}", &req.inputs[..1000.min(req.inputs.len())]);

请问 是怎么解决的这个问题呀？我用4090 跑 qwen2.5也遇到这个问题了


Add release notes for 0.4.15

Description
These are the autogenerated (manually rearranged) notes for 0.4.15, for which we release the rc tomorrow. Nothing particularly controversial in this release, mostly fixes and documentation improvements, so hopefully a smooth release process!

@alisterburt are you able to give this and my comments above a final look through before I merge and make the rc? :tada: As a reminder the release notes are not final, and will be updated over the coming week.
Actually I'll update the title to rc0 so things aren't confusing on the website... :joy:

Ha, thanks for the quick fix! :joy:


unautherized error

www.figureology.com this is my site . i am used woocomerce--2checkout-api . all details are given correctly. but it came "unauthorized" .whats the problem?. i have used 2checkout publisheable key and private key. used to test credit card details . please tell me solution .

Hey @Ranjani88 - The unauthorized error occurs when a couple of things happen.

The live account credentials are being used while testing in sandbox or vice versa
An invalid token is present, or the token was already used on a prior call.

If you're still experiencing this issue let us know.
Thanks!


Mention the AV detections

As it seems some AVs detect the Windows file as malware (https://www.virustotal.com/gui/file/c52ede3b99c7610c391fac5c89bc1883e4b3dc70228cc1b67b50db70f8a85b88), I think we should add a note to the README informing them that it is a false positive (which it clearly is)
I also checked on a test Windows system, and Windows Defender Smartscreen also displays a warning
I have submitted a False Positive report to Gridinsoft, but it will probably take days for it to be resolved

This is a known issue with pyinstaller pyinstaller/pyinstaller#5490 pyinstaller/pyinstaller#603 we could probably add that...

@donno2048 ok!

LGTM


Add test script with treshold functionality

Coverage increased (+0.05%) to 77.088% when pulling 438ffe16bceff7b259cde1c8f300f15b6990b54d on amarcine:master into 3d994d502b0463be8dbdc9722a7a82364629fafb on contiv:master.


Webhook should validate the presence of gateway

As it is written now, CAPV assumes that a Gateway will be present on IPAddress objects, and will fail to reconcile a VSphereVM if it's not present.
The webhook should validate the presence of the Gateway, and reject pools that do not have a valid gateway. Gateways should need to be in range of the provided subnet.
Alternatively, the gateway could be defaulted to the first IP in the subnet range.

I gave this some more thought. If you want to rely on a Gateway being set, this would need to be specified on IPAM contract level, not for individual providers.
The fun part starts once you consider IPv6. (Disclaimer: I'm not too deep into IPv6, so feel free to validate)
Afaik there is a lot of new ways to configure IP addresses. There are better alternatives to DHCP, which makes the IPAM contract unnecessary in some scenarios. But there are also options to configure individual aspects of the network using "Router Advertising", which e.g. allows setting a static IPv6 on the host, but not providing a default gateway, which will be configured automatically using Router Advertising.
Considering that, I'd keep this field optional. Alternatively we could only make it required when using IPv4. I'll ask my networking colleagues about that as well, maybe there is a reason not to have it for IPv4 either.
Of course nobody thought of us poor software engineers who only want to understand the manageable complexity of IPv4 when coming up with those ideas. :smile:
I'm not sure what a solution for different requirements of providers would be. Of course it should be documented and be properly reflected in resource status. We could also introduce a toggle that makes it required, which would help folks with a less-advanced networking setup.

Thanks for bringing up these points. We agree that there is valid reason to keep it optional.
We do see that right now, the code will fail reconciliation if an invalid gateway is provided:
https://github.com/telekom/cluster-api-ipam-provider-in-cluster/blob/main/internal/poolutil/pool.go#L59
Perhaps for the time being, we guard against an invalid (empty) gateway, and defer making any decision about validation?

I noticed that the capi-webhook validates gateway and it fails if gateway is empty. Probably have to update the capi-webhook to allow empty gateway to truly allow IPAddresses to get reconciled with empty gateways: https://github.com/kubernetes-sigs/cluster-api/blob/4f60841913fa99912771c3906ee81dd13d4e9633/exp/ipam/internal/webhooks/ipaddress.go#L126-L134

You are right. Since it has an omitempty json tag, I think we should change it to check if it's even set.

I had already created https://github.com/kubernetes-sigs/cluster-api/pull/8506, not sure if it makes sense to differentiate between ipv4 and ipv6.

Ah, I should of looked. We can close our PR in favor of yours. I can go either way in terms of allowing or disallowing gateway for ipv4.

I have no strong opinions, and am open to any implementation.
If I were all alone making this choice, I'd require gateway on IPv4 Pools/Addresses, and I'd make gateways on IPv6 Pools/Addresses always optional, per our PR.
My rationale for making IPv4 required: The user would need to configure the Gateway on the cluster yaml if they don't provide it on the Pool. This separation of configuration seems a bit disjointed. If neither the pool nor the cluster yaml specified the Gateway, it becomes hard to detect the misconfiguration, and the user would likely not find out until the deploy failed.

I think this issue has been solved by #118. Please feel free to reopen if that's not correct.


RemoteConfig ignores missing defaults plists

Description
If you point RemoteConfig at a plist file and that file isn't found at runtime, RemoteConfig logs an error to console, but doesn't throw.
Then all attempts to read with configValue(forKey) just return default primitive values, e.g. 0 for numbers. That's very dangerous if you're using this for example to set a minimum time before something is deleted, or to configure the frequency with some operation can happen.
A refactor at any time could cause the plist file to fail to be found, which could then easily go unnoticed if the things that depend on remote config aren't immediate and obvious.
A method that throws or even panics would be preferable.
The whole API seems a bit dangerous. Setting the defaults in bulk when you initialize RemoteConfig, rather than at the call site forces you define the key multiple times, which introduces a not insignificant risk that you either forget to set the default or mistype the key name somewhere. I'd prefer a configValue(forKey: <>, withDefault: <>) method over setDefaults so that I'm guaranteed the ability to set a reasonable default value. Then the worst case scenario is that I use my sane hard coded default instead of my better remote default. Today the worst case seems to be I end up using a risky primitive default value.
Reproducing the issue
Point remote config at non-existent file via https://firebase.google.com/docs/remote-config/get-started?platform=ios#rest_2
Firebase SDK Version
10.29.0
Xcode Version
15.0.1
Installation Method
Swift Package Manager
Firebase Product(s)
Remote Config
Targeted Platforms
iOS
Relevant Log Output
No response
If using Swift Package Manager, the project's Package.resolved

Expand Package.resolved snippet

Replace this line with the contents of your Package.resolved.

If using CocoaPods, the project's Podfile.lock

Expand Podfile.lock snippet

Replace this line with the contents of your Podfile.lock!

Thanks for your feedback, @sjudd. I tried to incorrectly set the default plist, and I was able to get the same behavior you encountered. I get that the SDK should handle the missing default plist well or provide a failsafe default value to prevent unexpected app behavior. I'll raise this to our engineers and see what we can do here.


Restore lazy config feature (provide API key asynchronously)

Hello, I'm opening this issue as requested in https://github.com/SebastianM/angular-google-maps/issues/1726#issuecomment-533020436.
Issue description
Providing an API key asynchronously has been possible for years (we've been using it from 0.17.0 to 1.0.0-beta.7). It is required when, for example, the API key comes from a remote config file.
Version 1.0.0 removed this ability.
Steps to reproduce the problem
Use any @agm/core version from 2016 to 2019, below 1.0.0, it works:
import {LAZY_MAPS_API_CONFIG, LazyMapsAPILoaderConfigLiteral} from '@agm/core/services';
import config from './config';

@Injectable({providedIn: forwardRef(() => CustomerModule)})
export class GoogleMapsConfig implements LazyMapsAPILoaderConfigLiteral {
  apiKey?: string = config.gmapsApiKey;
}

@NgModule({
  imports: [AgmCoreModule.forRoot()],
  providers: [{provide: LAZY_MAPS_API_CONFIG, useClass: GoogleMapsConfig}],
})
export class CustomerModule {}

Update to @agm/core version 1.0.0, it starts failing with 'LAZY_MAPS_API_CONFIG' is not initialized.
Alternatives
Use @angular/google-maps.
Other information
Any of these would be helpful:

Restoring the feature.
Implementing an equivalent feature.
Pointers or instructions of how to implement it, if we'd like to make a PR.

Thanks

This totally breaks the usage we have in https://github.com/cyclosproject/cyclos4-ui as we don't have the API key statically in the client, but it is fetched from the server.
Will keep version 1.0.0-beta.7 but look into alternatives when the time permits.

I would consider this a little more than a nice-to-have, but was a central feature in the beta that was removed with the release. Any chance we can get it re-added soon?

It was never a feature in beta, just a side effect which apparently a lot of people enjoyed.
I am looking into what can be done to re add it.

I‘ll add this feature to my fork of agm. There are several options so I‘ll prepare different variants for this.

Any updates?

Lazy loading configuration

@stale I don't think this regression is fixed, in my opinion you should leave the issue open.
For info, we had to stop using angular-google-maps because of this regression (we use another way).


Issue 45 clear local storage on button click

To clear the local storage for shortlisted items

local storage gets removed on button Clear click


docs: add list

@yuberdysheva deploy of main broke after this PR

@yuberdysheva deploy of main broke after this PR
https://github.com/gravity-ui/landing/actions/runs/5977045760/job/16216165150

Thank you. I will fix it right now.


Choice Picker

Description
I have added a new template named Choice Picker.  In this web app, we can enter our choices and it will pick one or two of them for us.
Fixes: #663
Checklist:

[x] I have made this from my own
[x] I have taken help from some online resourses and mentioned in PR
[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings

ATTACH SCREEN-SHOTS / DEPLOYMENT LINK

Link the issue in the PR description

Linking issue in PR, done.

https://deploy-preview-667--amazing-css-effects.netlify.app/choice picker/

@Shivam-Katare add the link in the comment from where u have taken the refrence

Reference Link added


Generator for app / library does not obey --dry-run

I'll have a fix for this when I finish the builder. It shouldn't be too difficult

I think I can fix it pretty easily too, dotnet supports the -dry-run flag natively, just need to pass it in whenever the generator is ran in dry run mode

Not quite fixed.


I got errors while trying to run Java  using mac terminal, I tried to install it from Oracle but the Java version (permission denied) , may some one guide please?

A fatal error has been detected by the Java Runtime Environment +  SIGSEGV (0xb) at pc=0x000000018407cdc4, pid=33891, tid=8707 JRE version:  (<IP_ADDRESS>+1) (build ) # Java VM: OpenJDK 64-Bit Server VM (<IP_ADDRESS>+1-LTS, mixed mode, tiered, compressed oops, g1 gc, bsd-aarch64) # Problematic frame: # C  [libsystem_platform.dylib+0xdc4]  _platform_strlen+0x4 # # No core dump will be written. Core dumps have been disabled. To enable core dumping, try "ulimit -c unlimited" before starting Java again # # An error report file with more information is saved as: # /Users/aymankhalifa/hs_err_pid33891.log

We distribute the Eclipse Temurin builds from the Adoptium project.  Please try the Oracle forums for your question.


how to feed commands to external process and catch output

i just found your library and i think it can solve my problem : i tried to start a process (a chess engine) in Nim and feed commands to it (stdin) and catch its output (stdout) .. i managed to get this working somehow but my solution seems primitive and incomplete, see https://forum.nim-lang.org/t/10613
when i execute the process 'stockfish' in terminal, the program returns its 'bestmove' but my Nim script doesn't output this last line !? I read about Nim threads, threadpools, async, await, spawn but it i don't find good examples and so it's all too difficult for me ..
can anybody give a (simple) example?  Just feed commands to an external process and catch its output? It seems Malebolgia can do this easily, but i have no clue .. eventually i want to build a GUI app which uses the output info of such chess engine to calculate things and output a graph, while the engine is still running; eg. the engine process also has to listen to a "stop" command ..

Read https://github.com/Araq/nimedit/blob/master/console.nim#L318 for inspiration.
Having said that, you're better off using a library instead of an external process, interprocess communication is usually a clusterfuck on UNIX.


RuntimeError: Event loop stopped before Future completed.
Error: Process completed with exit code 1.

RuntimeError: Event loop stopped before Future completed.
Error: Process completed with exit code 1.

This is probably a race condition when an AsyncSlotBaseEventLoop is being closed. At this point it may no longer be possible to start a Qt event loop to run the cleanup coroutines.
The module has been enhanced to use native asyncio event loop to run cleanup code. Specifically, for an AsyncSlotBaseEventLoop operating in guest mode, run_forever always launches a native asyncio event loop.
I close the issue assuming the race condition is eliminated with this enhancement.


Extract R and S values for ASN1 signature?

I'm trying to extract the R and S values (as Data) from a Data stream. Is that possible with this project? Thanks

Hi @yspreen, I'm sorry for the late response. I have been off the grid for the last 3 weeks.
I believe we can extract any data we want from any asn1 data stream. Unfortunately, I haven't tried to parse anything, but Apple in-app receipt which is just a pcks7 file, but I don't see any problems to do so. If we know the asn1 structure
of incoming data, then we can declare a struct and decode asn1 data into this struct.
Do you have a base64 string of data you want to parse?

I envy your off-the-grid-ness ;)
So the use-case is quite narrow, and I decided to implement it without the use of a library. It would've been overkill. Here's the code: https://github.com/eu-digital-green-certificates/dgca-app-core-ios/blob/main/Sources/Services/ASN1.swift


Use of QUIC_LOG and getting a log file

Not an issue but a question about how to use the logging functionality
Would like to get all levels/granular level of logs.
The current quic_client or quic_server doesn't have the option to
supply the log file name into which the logs will be written.
Was curious as to how get logs. Is it platform dependent (chromium/envoy) configuration/option?

mark

Not an issue but a question about how to use the logging functionality Would like to get all levels/granular level of logs.
The current quic_client or quic_server doesn't have the option to supply the log file name into which the logs will be written.
Was curious as to how get logs. Is it platform dependent (chromium/envoy) configuration/option?

Hi, have you known how to use it?


[DOCS] Github changelog for 0.20.1 is not showing correct commits?

Instructions
Thank you for submitting an issue. Please refer to our issue policy for information on what types of issues we address
Description of proposal (what needs changing)
The changelog for latest release v0.20.1  doesn't seem right. Shouldn't it be showing changes on top of the previous release which in this case is v0.20.0. Same issue is present with the v0.19.0 release as well.
Willingness to contribute
The FiftyOne Community encourages documentation contributions. Would you or another member of your organization be willing to contribute a fix for this documentation issue to the FiftyOne codebase?

[ ] Yes. I can contribute a documentation fix independently
[x] Yes. I would be willing to contribute a documentation fix with guidance from the FiftyOne community
[ ] No. I cannot contribute a documentation fix at this time

Our release change logs are on our documentation site now: https://docs.voxel51.com/release-notes.html


CrowdStrike Falcon Sensor flags Mouse Jiggler

CrowdStrike's Falcon sensor flags and removes Mouse Jiggler's exe as a "suspicious process"
Md5 of the zip for 1.8.35: 2f717ad23dd76d5feec0d4acabe355f7

Honestly, I can't say I'm all that surprised - arguably, to a suitably paranoid antivirus, use of SendInput() probably should qualify as suspicious.
I'll drop CrowdStrike a line and see if they have a procedure for whitelisting. Meanwhile, if you're using their paid services, you might want to do the same.

I filed a false positive report with them and submitted 1.8.35 to their reporting tool: https://www.hybrid-analysis.com/sample/4d787f358ec40b587939e69ff7a3a1d5e95f2646ef680f4b8c0e390e0bb2ee76
Fingers crossed they whitelist it. They didn't flag it until this morning so they must have pushed out some update yesterday.

Thanks, I appreciate it. I'll be sure to submit 1.9 myself when it comes out.

From CrowdStrike:
Hello,
Our team carefully analyzed your False Positive request and determined that the file doesn't meet our detection criteria.
The file will not be detected by our scanner.
Thank you for helping us improve our product.


I 💗 all the colors!!

Wow!!  I'm going to embed the screenshot here to point out what I'm looking at...

Thank you for posting screenshots in your readme!  They always get attention. You've got a rare thing in the Python world, a Graphical User Interface, and that's worth showing.
I was surprised, and thrilled, to see you're using cprint!!  I don't think I've seen anyone using it in projects that I've looked through.

GitHub shows only 247 finds in all of GitHub.  It's really rewarding to see a feature used as I had envisioned.  It's named cprint for "color print" after all, so seeing you print so much color was a great find!  Thanks for dropping me a message that you posted your code.  It's made my day!

OH!  And also, please post some screenshots in the PySimpleGUI GitHub's Screenshot Issue:
https://github.com/PySimpleGUI/PySimpleGUI/issues/10
These posts will be shown in the main PySimpleGUI documentation soon so a lot more people will be able to see all these creative projects.

Hi there,
Here are some screenshots of my Chat Rooms Project.

Thanks for the comments
On Thu, Aug 25, 2022 at 10:49 PM PySimpleGUI @.***>
wrote:

OH! And also, please post some screenshots in the PySimpleGUI GitHub's
Screenshot Issue:
PySimpleGUI/PySimpleGUI#10
https://github.com/PySimpleGUI/PySimpleGUI/issues/10
These posts will be shown in the main PySimpleGUI documentation soon so a
lot more people will be able to see all these creative projects.
—
Reply to this email directly, view it on GitHub
https://github.com/vasja34/Chat-Rooms-Project/issues/1#issuecomment-1227692559,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AZYU3UC2WZTPVN3VIZNDQFLV27E4BANCNFSM57UKLN6A
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

It was a motivating find.  Thanks for taking the time to post the screenshots both in your repo and on the PySimpleGUI GitHub


Try to Connect with ELK Cloud - No Logs Data uploaded

Does this issue relate to a new feature or an existing bug?

[x] Bug
[ ] New Feature

What is the target framework and operating system? See target frameworks & net standard matrix.

[x] net5.0
[ ] netCore 2.0
[ ] netCore 1.0
[ ] 4.7
[ ] 4.6.x
[ ] 4.5.x

Please describe the current behavior?
I try to use Elastic to log the logs to the ELK Cloud(Stupid sentence).
What I have done so far:
CreateHostBuilder(args)
               .ConfigureLogging(logging =>
               {
                   logging.AddSerilog(new LoggerConfiguration()
                       .Enrich.WithElasticApmCorrelationInfo()
                       .WriteTo.Console(outputTemplate: "[{ElasticApmTraceId} {ElasticApmTransactionId} {Message:lj} {NewLine}{Exception}")
                       .WriteTo.Elasticsearch(new ElasticsearchSinkOptions(new CloudConnectionPool("elastic-test:TOKEN",new ApiKeyAuthenticationCredentials("ApiKeyFromELK")))
                       {
                           CustomFormatter = new EcsTextFormatter(),
                           AutoRegisterTemplate = true,
                       })
                       .WriteTo.Elasticsearch(new ElasticsearchSinkOptions(new Uri("https://elastic-test.apm.westus2.azure.elastic-cloud.com"))
                       {
                           ModifyConnectionSettings = x => x.BasicAuthentication("elastic", "PASSWORD"),
                           CustomFormatter = new EcsTextFormatter(),
                           AutoRegisterTemplate = true,
                       })
                       .CreateLogger());
                   logging.AddAzureWebAppDiagnostics();
                   logging.AddConsole();
               })
               .Build().Run();

Please describe the expected behavior?
I wanna see Log data in the cloud, but no data is uploaded. Metric data with UseAllElasticApm works perfectly fine.
So how do I configure the logs correctly?

I've had a similar issue after upgrading to ESv8.
Apparently a _type argument is specified which happened to be deprecated in ESv7 and became an illegal argument in ESv8.
https://www.elastic.co/guide/en/elasticsearch/reference/7.17/removal-of-types.html
Setting ElasticsearchSinkOptions.TypeName = null resolved the issue for me.


Fix chef-config gem homepage

cc @chef/client-maintainers

For other stuff we use https://www.chef.io but I could see a case made that these "component" gems should point here. :+1: either way, as all colors of bikeshed protect bikes from the rain.

:no_bicycles:
:+1:


Typo "Jupyter notebook"→"Jupyter Notebook"

https://docs.microsoft.com/en-us/azure/cloud-adoption-framework/innovate/ai/machine-learning

@hyoshioka0128 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#sign-off

#sign-off

@BrianBlanchard: I'm sorry - only the author of this article, @v-hanki, can sign off on your changes. But we do have an exception process - if you are on the Microsoft content or product team for this product area, you can ask the PR review team to review and merge it by sending mail to the techdocprs alias.

@BrianBlanchard: I'm sorry - only the author of this article, @v-hanki, can sign off on your changes. But we do have an exception process - if you are on the Microsoft content or product team for this product area, you can ask the PR review team to review and merge it by sending mail to the techdocprs alias.