read proxy from .proxy file for deploy RG task

We shouldn't do this.  The agent passes proxy info via envvars that tasks can consume.  It shouldn't be reading the agent proxy config file.  That's the agents file.

proxy config should flow into tasks like they do with git / tfsvc.  see that code.  contact @ericsciple because ps3 lib should make it just work by handing over a connection that's prepped with creds and proxy config.  we don't want every task to react.

@bryanmacfarlane Sorry if the title is misleading, but actually we are reading the proxy uri from the environment variable(AGENT_PROXYURL) that is set by agent(after agent reads from proxy config file). If there is no proxy config file(and hence no environment variable to read proxy from), we then try and read the IE proxy settings.
Also, these changes are in the common VSTS REST helper, which every powershell based task which makes REST calls uses/will use.

also the title of the PR is misleading


spec.auth.gcpServiceAccount validation pattern too restrictive

The pattern used to validate the spec.auth.gcpServiceAccount field of the Google resources (example below) seems too restrictive and is preventing the use of valid GCP Service Account email addresses
https://github.com/triggermesh/triggermesh/blob/c02ba41a8ca31a9d1704305ffccd7120cdb8a351/config/300-googlecloudpubsubsource.yaml#L117-L121
From the section titled "Create a service account" of the official GCP IAM documentation:

When you create a service account, you must provide an alphanumeric ID (SA_NAME in the samples below), such as my-service-account. The ID must be between 6 and 30 characters, and can contain lowercase alphanumeric characters and dashes. After you create a service account, you cannot change its name.
The service account's name appears in the email address that is provisioned during creation, in the format<EMAIL_ADDRESS>
Yet, when using a value that is valid according to Google (i.e., SA_NAME accepted by the GCP API), the API server rejects the request and returns an Invalid value error:
$ cat <<EOF | kubectl apply --server-dry-run -f -
kind: GoogleCloudPubSubSource
apiVersion: sources.triggermesh.io/v1alpha1
metadata:
  name: foo
  namespace: default
spec:
  topic: projects/baz-baz-baz/topics/qux
  auth:
    gcpServiceAccount<EMAIL_ADDRESS>  sink:
    ref:
      apiVersion: v1
      kind: Service
      name: foo
    uri: "/uri"
EOF
The GoogleCloudPubSubSource "foo" is invalid: spec.auth.gcpServiceAccount: Invalid value<EMAIL_ADDRESS>spec.auth.gcpServiceAccount in body should match '^[a-z][a-z0-9-]+@[a-z0-9-]+\.[a-z]+\.[a-z]{2,63}$'

It looks like service accounts might have one more element at the domain than we expect.
We will be fixing it, thanks for the issue.

@odacremolbap you could use this regex if needed: [a-z0-9-]{6,30}@[a-z0-9-]{6,30}\.iam\.gserviceaccount\.com. It may be improved in the PROJECT_ID part, but it is still better than the current version.

@odacremolbap thank you!


Visual Testing tool with Percy

Changes

Setup Percy in the codebase and CI
Add first snapshot with Percy

Context

Closes #511
We have 5,000 screenshots per month with our current plan. Every cy.percySnapshot usage would count as 8 screenshot since we are getting screenshots for 2 widths and 4 browsers. I believe we have enough for now.
Tests

I've checked my work by:

[X] Adding new tests or adjusting existing tests
[ ] Testing manually

Here we have Percy letting us know about the first snapshot!

I need to investigate why the assets are missing in all browsers except Chrome 🤔

I added some allowed hosts so Percy can retrieve the assets, but it's not working.
I've contacted support, I hope they can help me to solve this.

It looks like it's not working correctly after removing PERCY_PARALLEL_TOTAL. I'm double-checking if it was just a coincidence or it actually needs that env var (I believe it's gonna be the latter).

If we need it then we should put it back of course! 😉

If we need it then we should put it back of course! 😉

It seems it's needed, there are snapshots missing now. I'll revert the parallel env var.


Updating app JSON structure

Updating structure of JSON that the app writes to Pub/Sub

Updating structure of JSON that the app writes to Pub/Sub


WIP / Proposal: Maybe drop monix-tail and Iterant

WARN: the decision to merge this has not been made yet. At this point this is only speculation of one possible outcome — the purpose of this PR being to put the possibility on the table.
The TL;DR is that Cats-Effect's cancelation model is under question due to the need to relax its laws to support Scalaz 8's IO. References:

Restate ConcurrentLaws to support auto-cancelable run loops, as a solution to Cancelation laws presuppose no interruption
Technical Summary of the Problem
Proposal: Continual (type class?)

Therefore, without consensus reached in Cats-Effect with the other collaborators, dropping monix-tail might happen in case these issues in Cats-Effect are not solved via a solution that admits the current behavior or an easy update, because in the proposed model Iterant's encoding is broken.
Another possibility would be introducing the new encoding in progress at #678, however this would take at least one month by my estimates, if I and other Monix maintainers were to focus on this. And speaking for myself, I have a full time job, a family, upcoming exams, summer vacation coming up, etc. so 1 month to change that encoding is extremely optimistic, because it's a redo and I've got more important things to do at this point. It isn't fair for current users of monix-eval and monix-reactive to wait for so long on a final version 3.0.
Other possibilities would be:

delay Monix 3.0 indefinitely
release 3.0 soon, then reintroduce monix-tail at a later point after we find a better encoding (which implies the merging of this PR)
specialize Iterant for Task
fork the Cats-Effect type classes in a Monix sub-project, because the purpose of Iterant was to work with Coeval as well

Actually at this point there are no good solutions, unless consensus is reached for a solution that allows the current model to work.

how about move the monix-tail and monix-itrent to a sub repos?

I can't see what can't be achieved with the reactive-stream based one, so drop it would be a release for both the project and our daily life:)


SW-6232 Add mapbox token to session storage with 30 minute expiration

Move useMapboxToken to its own folder
Add util functions for getting and setting the mapbox token to session storage
I used 30 minutes for the default expiration time since that is what is used on the server side.

Before
Here you can see what happens when the token is not stored in session:

As you can see, a page refresh causes the FE to retrieve another token, which requires the previously cached Mapbox image to be ignored
After
Since we are pulling the token from session, we do not get a new token and the Mapbox asset is pulled from browser cache:

#3344  👈 (View in Graphite)
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Looks good. useMapboxSearch also has a MapboxSessionToken that gets stored. I am not sure if it is applicable but we could use that if so.

Looks good. useMapboxSearch also has a MapboxSessionToken that gets stored. I am not sure if it is applicable but we could use that if so.

It looks like SessionToken from Mapbox is just a container for a uuid string, and I am not sure the parameters for the Mapbox search session, but it seems to be a different then the token created by the Terraware server. The other snag is that the token created by the server has a TTL of only 30 minutes, which may be less than the time of the session for some users, so we need to manage it ourselves in order to make sure the browser doesn't have an outdated token.


GameObject - Graphics missing screenshots

https://labs.phaser.io/index.html?dir=game objects/graphics/&q=
GET https://labs.phaser.io/screenshots/game objects/graphics/Line Rendering.png 404 (Not Found)
GET https://labs.phaser.io/screenshots/game objects/graphics/Multiple Graphic Objects.png 404 (Not Found)
GET https://labs.phaser.io/screenshots/game objects/graphics/Trail.png 404 (Not Found)

Thanks for opening the issue. New batches of screenshots are generated when we publish new releases. So am happy to leave these as-is for now.


TLSv1.3: Echo cookies

Checklist

[x] tests are added or updated

Description of change

TLSv1.3 introduces a new cookie extension. We do not support the generation of these cookies (not required to be compliant), however if we encounter one sent to us in a HelloRetryRequest then we must echo it back in the subsequent ClientHello.

Pushed. Thanks.


Update configure-aoag.md

Summarize the change in the pull request title
One space missing

@russrimm : Thanks for your contribution! The author, @aczechowski, has been notified to review your proposed change.

@russrimm - thanks for the contribution!


Add stripe for payment

I WILL ADD MORE TO THIS AFTER MVP IS DONE

https://www.youtube.com/watch?v=1r-F3FIONl8


Update dev guide to explain how to build a custom kernel

Once https://github.com/kata-containers/packaging/issues/1 lands, we should have some tooling to make it easy to create a custom kernel based on the base Kata kernel configuration.

issue#1 is now closed, are there some test branches with this custom kernel tooling?

Hi @mcgrof - well, it's not technically closed yet, but I agree that I believe we've actioned it now ;)
@jcvenegas has added packaging tools for custom kernels here: https://github.com/kata-containers/packaging/tree/master/kernel so we should be able to get someone working on this issue.
There are still a lot of questions around handling kernel configs generally though. See:

https://github.com/kata-containers/packaging/issues/8
https://github.com/kata-containers/packaging/issues/55
https://github.com/kata-containers/packaging/issues/56


Evaluation process consumes more than 2 hours

It took < 1 min ~ 10 min to evaluate before, (notice the time difference between the following 2 lines of the log)
2022-04-19 22:04:21 | INFO     | yolox.core.trainer:362 - Save weights to ./YOLOX_outputs/yolox_m
2022-04-19 22:04:29 | INFO     | yolox.evaluators.coco_evaluator:235 - Evaluate in main process...

However, after I pulled from the latest commit, (i.e., from 1dee0f7 to 4197784), the time it costs rises to ~ 2 h.
2022-04-26 02:29:35 | INFO     | yolox.core.trainer:363 - Save weights to ./YOLOX_outputs/yolox_m
2022-04-26 03:42:11 | INFO     | yolox.evaluators.coco_evaluator:235 - Evaluate in main process...

I'm not sure it's a problem with the clusters or the code, since there seems no changes with the evaluation part of the code.
Any advises for the probable reasons or ways to debug?

plz use git bisect to find the first bad commit, thx.

It seems to be an issue with my clusters, sorry to bother 😥

It seems to be an issue with my clusters, sorry to bother 😥


DBZ-4846 MongoConnector's field exclusion configuration does not work with fields with the same name but from different collections

https://issues.redhat.com/browse/DBZ-4846

@jpechane Fix the duplicate key issue.  The useless pathsByAddress map which key is Path::toString cause following duplicate key issue. But the method toString from Path only use the field name as identity, so remove this useless map will fix it.
In my test case, have four Paths as show below, will have the same key with "name" and "active" in pathsByAddress.
.c1.name,.c1.active,.c2.name,.c2.active
java.lang.IllegalStateException: Duplicate key name (attempted merging values name and name)


DSRC-75: Notification banner

Ticket URL: DSRC-75
About these changes
This PR spruces up the Alert model we've currently got on the site, but enables it to be utilised properly in the API. Also added the AlertMixin to every page (via BasePage) so that you can use the "notification banner" on different pages.
alert_check will get any "cascading" alerts from parent pages. If a parent page, anywhere up the hierarchy, has a cascading alert enabled, then this will be picked up on all child pages.
Home page with an alert on it (cascading false):

A great-great-great-grandchild page:

With cascading true on the alert, on the great-great-great-grandchild page:

Cascading on parent page, differing active alert on great-great-great-grandchild page:

How to check these changes
Alerts are registered in http://localhost:8000/admin/snippets/alerts/alert/, if you want to change or create any, go to that URL, and if you want to add them to a page, you can go into the page and then the Settings tab to add or remove these from the pages.
Before assigning to reviewer, please make sure you have

[x] Checked things thoroughly before handing over to reviewer
[x] Checked PR title starts with ticket number as per project conventions to help us keep track of changes
[x] Ensured that PR includes only commits relevant to the ticket
[x] Waited for all CI jobs to pass before requesting a review
[x] Added/updated tests and documentation where relevant

Merging PR guidance
Follow docs\developer-guide\contributing.md
Deployment guidance
Follow docs\infra\environments.md

@ahosgood I realise alert_check probably isn't the best name for this. Any other suggestions..? Just notification?

@jamesbiggs Is this meant to be an array?
I think something like alerts might be better than alert_check.

@jamesbiggs Is this meant to be an array?
No, just the one item

I think something like alerts might be better than alert_check.
Okay!

No, just the one item

If there is only ever going to be just one, could we call it global_alert instead please? Sorry for flip-flopping on this!


gitignore *.emotion.css files?

emotion version: 5.2.0
react version: 15.5.4

What you did:
I added *.emotion.css to my gitignore, pushed up, pulled down on other workstation.
What happened:
Module not found: [CaseSensitivePathsPlugin] .../src/App.emotion.css does not match the corresponding path on disk - File does not exist.
Reproduction:
Delete any *.emotion.css file when using in conjunction with an ejected create-react-app 1.3.0. Webpack Loaders:
      {
        test: /\.css$/,
        exclude: /\.emotion\.css$/,
        loader: 'style!css?importLoaders=1!postcss'
      },
      {
        test: /\.emotion\.css$/,
        loader: 'style!css?importLoaders=1!postcss'
      },

Suggested solution:
Is it possible to have emotion files generated on start if they are missing? It seems strange that they would be version controlled since they are generated. Am I missing something in my configuration? Or is this simply not an intended use case?
Massive ❤ for this project

I've always just added them to the repo. I'm not sure we can do much about this issue. The imports are added automatically to the top of your js file.

Why are you using 2 different loaders? Just use the same loader for both. Its valid css 😀

Fair! I have no problem including them in the repo personally. It just strikes me that it would be nice if my colleagues didn't see the *.emotion.css in the git diff in our PRs, as well as get any ideas in their heads about editing the *.emotion.css 🤦♂ I guess I'd just catalogue this as a nice to have. Thanks! 🎖

AS for the loaders... ya I fixed that a bit back, leftovers from when I started this project and was fumbling around. Copying your emotion-rewired example in future 👌


Fix the leaderboard being wider than the screen when loading

When the ranking is loading and skeletons are shown the rankings were way too wide, so wide the ranking would go off the right edge of the page and the recent updates column would be wrapped below. It seems that removing flex-basis: auto from Content fixes it. I believe the 100% width on on the Skeleton in Leaderboard.tsx is what was causing issues with the flex basis.
The bug:

The fix:

https://github.com/tadoku/tadoku/blob/f5fb8b39e3b37b75d9d3868be91486ac00496587/frontend/web/src/app/ranking/components/Leaderboard.tsx#L222-L225
Those lines are also causing the nickname skeleton to not be vertically aligned with the other skeletons. Not sure if I should address that in this or not.


Simulate Error Screen

It would be great if we could simulate the failure screen from the 'finalise' function. It would be extremely helpful when writing documentation.

@mattdjerome: Please see Step A.11.


Improving footer UI

There is so much empty space in footer , so it looks incomplete.

I would like to modify the content in footer , reduce the height , make links clickable and add some more social media icons in footer.
Please assign me this issue, i would like to contribute to this project under GSSoC'24.

What will you add in the links as these pages are not developed yet

hey, so in the company section,

the about us has to be linked with the about us section which will be added in #4
create a dummy Contact Us page for now
create a posts option that links to the posts page
create a profile option if the user logged in
remove careers and brand center option

in the legal pages section, link all the options to a dummy policy page for now
on the side of the GitHub icon, add an icon that links to the website
as for the empty spaces don't reduce them to much as it looks good and clean right now

hey, so in the company section,

the about us has to be linked with the about us section which will be added in Enhance Home page of the website #4

on the side of the GitHub icon, add an icon that links to the website

Okay sure, Thanks for assigning me this issue!
Just a small doubt here, should I add a top arrow icon which takes to the top of website?

on the side of the GitHub icon, add an icon that links to the website

Hi, just a small doubt here. Should I add an icon that redirects to the homepage of this website, next to the GitHub icon?

on the side of the GitHub icon, add an icon that links to the website

Hi, just a small doubt here. Should I add an icon that redirects to the homepage of this website, next to the GitHub icon?

yes


[OpenAI-Assistant] Merge without change from the child branch.

Due to merging Assistant-AssistantTests happens before merging https://github.com/mssfang/azure-sdk-for-java/pull/45
This PR will have no changes since last commit of Assistant-AssistantTests but only the PR https://github.com/mssfang/azure-sdk-for-java/pull/45 changes

API change check
APIView has identified API level changes in this PR and created following API reviews.
com.azure:azure-ai-openai-assistants


Display local & remote kernels together

For #8489
Need to add some tests

[ ] Run a cell against a local kernel, connect to remote Jupyter and verify the local kernel state is not lost,
[ ] Run cell in same notebook with local kernel and remote kernel
[ ] Ensure local and remote kernels are listed in controllers when connecting to remote
[ ] Ensure only local kernels are listed in controllers when switching to local
[ ] Keep track of the controllers (base url) and verify it is different when connecting to a different remote Jupyter (with a different port)

Codecov Report

Merging #8490 (5d3f25a) into main (e7381f4) will increase coverage by 0%.
The diff coverage is 85%.

@@          Coverage Diff          @@
##            main   #8490   +/-   ##
=====================================
  Coverage     71%     72%
=====================================
  Files        377     377
  Lines      23932   23936    +4
  Branches    3680    3682    +2
=====================================
+ Hits       17212   17235   +23
+ Misses      5221    5205   -16
+ Partials    1499    1496    -3

Impacted Files
Coverage Δ

.../datascience/kernel-launcher/remoteKernelFinder.ts
90% <ø> (ø)

.../datascience/notebook/notebookControllerManager.ts
73% <81%> (+1%)
:arrow_up:

src/client/common/utils/localize.ts
95% <100%> (+<1%)
:arrow_up:

src/client/datascience/jupyter/kernels/helpers.ts
72% <100%> (+<1%)
:arrow_up:

...t/datascience/notebook/vscodeNotebookController.ts
79% <100%> (+3%)
:arrow_up:

...atascience/interactive-window/interactiveWindow.ts
70% <0%> (-2%)
:arrow_down:

src/client/datascience/jupyter/kernelVariables.ts
58% <0%> (-2%)
:arrow_down:

src/client/datascience/errors/errorHandler.ts
57% <0%> (ø)

src/client/debugger/jupyter/kernelDebugAdapter.ts
77% <0%> (+<1%)
:arrow_up:

... and 6 more


[Feature][Sort] Add Elasticsearch connector on Flink 1.18

Description
Add Iceberg connector on Flink 1.18 to sort-flink-v1.18, you can refer to the latest release of elasticsearch at https://github.com/apache/flink-connector-elasticsearch and the previous realization on Flink 1.15.
Location:
inlong-sort/sort-flink/sort-flink-v1.18
Requirements:

Support report audits to Inlong Audit with exactly once
End-to-end testing

Nice to have:

Pressure testing report

This issue is a dedicated issue for the 2024 Tencent Rhino-bird Open Source Talent Training event and is only available for college students to claim
【Claim the issue】Sign up for the corresponding issue in columns M~R of the Research and Study Base "issue Camp" to be considered as successfully claimed.
【Complete the issue】For students who have claimed the issue, please also reply "Successfully claimed this issue" in the comment section of this issue; if there is no progress submitted within 7 days, including but not limited to comments, commits, or Pull Requests, it will be considered as voluntarily giving up the issue and the committee will release the issue to the next person in line.
Use case
No response
Are you willing to submit PR?

[ ] Yes, I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

I'd like to finish this issue~

This issue finish by es6 pr #10722 and es7 pr #10741 ~

This issue finish by es6 pr #10722 and es7 pr #10741 ~

Thx @XiaoYou201


chore: update vscode launch settings for debugging test suites

It's actually dev.ts. File extension in the launch configs need to be changed as well

My bad, updated the dev file too, weirdly enough it worked with .js too


disable expired date selection in the calendar

we don't want the user to subscribe for dates which are long past.

done! now the user cant open a room in inlogical time.


movim: <IP_ADDRESS>40328 → 0.24

Note: this does not fix the bcrypt issue with Nixpkgs’s PHP being ahead of what Movim’s maintainers are using currently
https://github.com/movim/movim/issues/1311
Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.
[^1]
[^1]: Please consider giving up MS GitHub or offering a non-proprietary, non-US-corporate-controlled mirror for this free software project. I wish to delete this Microsoft account in the future, but I need more projects like this to support alternative methods to send patches & contribute.

Result of nixpkgs-review pr 306454 run on x86_64-linux 1

1 package built:

movim


DE43686-fix-overlap-click-conflict

Overview

Before
After

Resolves a stacking conflict where clicks would activate the item below.
Reason for change
See ticket: DE43686: 2. WTD Full view Back to Home link disabled if another link under it
Changes summarized

Add z-index: 0 to create new stacking context.

Suggested future tasks

Migration of nav components to core.
Warning: This may affect drag and drop functionality. Regression tests may be required.

Checklist

[x] No new warnings are introduced
[x] Comments and documentation are up to date
[x] TODOs resolved or added to issue tracker
[x] No commented-out code
[x] This isn't a 'quick-and-dirty' job

This replaces https://github.com/BrightspaceUI/navigation/pull/115.

Oh man. Tests are failing. Will investigate further.

  form-element
    events
      ✖ should fire invalid-change when validation fails

^ That Sauce Labs test is very flakey and unlikely to be related to your stuff.  You don't need the Sauce Labs tests to pass to merge (we're investigating Browserstack versus Sauce, but only Browserstack is required to pass).

I think this change would be ok.

Why is this still in draft?
Because the tests are failing and I think it might be because of my changes.

@svanherk Many thanks!


Make Validator::complete required

Closes https://github.com/pydantic/pydantic-core/issues/496
I think only DataclassValidator was referencing other validators.

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@91e84f2). Click here to learn what that means.
The diff coverage is 100.00%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #524   +/-   ##
=======================================
  Coverage        ?   94.83%
=======================================
  Files           ?       93
  Lines           ?    12337
  Branches        ?       25
=======================================
  Hits            ?    11700
  Misses          ?      630
  Partials        ?        7

Impacted Files
Coverage Δ

src/validators/mod.rs
98.82% <ø> (ø)

src/validators/any.rs
100.00% <100.00%> (ø)

src/validators/bool.rs
100.00% <100.00%> (ø)

src/validators/bytes.rs
97.05% <100.00%> (ø)

src/validators/callable.rs
100.00% <100.00%> (ø)

src/validators/dataclass.rs
97.39% <100.00%> (ø)

src/validators/date.rs
95.14% <100.00%> (ø)

src/validators/datetime.rs
93.49% <100.00%> (ø)

src/validators/float.rs
89.16% <100.00%> (ø)

src/validators/function.rs
96.09% <100.00%> (ø)

... and 9 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 91e84f2...0af4437. Read the comment docs.

Thanks for the review.
I've just pushed a minor commit to improve some naming which strangely Github is not showing. Please wait for that before merging.

@aminalaee I see the change you made on your fork (changing _build_context to build_context in the dataclasses thing). I agree we should include that, and also agree it's very weird that github isn't showing the commit. Feel free to close and open a new PR with just a single commit that is fixed, or we can just wait and see if github gets its act together.

I'm guessing this is a project/organization settings not allowing commits after approval. Not sure.
Thanks, I'll do that then.


Strange deployment errors via GitHub / Bitbucket - SCM not enabled

Last 12h I've had multiple sites (5 uptil now, different subscriptions) with the same log as below, GitHub and BitBucket web hooks get a 403 from Kudu
  <step title="FetchHandler" date="2016-12-13T09:02:03.059" >
    <step title="Scm is not enabled, reject all requests." date="2016-12-13T09:02:03.075" /><!-- duration: 0ms -->
  </step><!-- duration: 31ms -->
  <step title="Outgoing response" date="2016-12-13T09:02:03.106" type="response" statusCode="403" statusText="Forbidden" Server="Microsoft-IIS/8.0" Cache-Control="private" X-AspNet-Version="4.0.30319" /><!-- duration: 0ms -->

Tried restarting the deployment slot redelivering the web hook solved it.
Don't know if it's related but all sites that had this issue are deployment slots.
Interestingly all these sites won't load in the portal, it just sits like this forever

until I click overview, then everything loads and it's fine the next time I open the blade for that site.

Then going to the deployment slot, restarting that web and redelivering web hook results in an 202 instead of 403

And everything deploys fine. Any ideas what could be causing this?

Hi
If the problem persists and is related to running it on Azure App Service, please open a support incident in Azure:
https://learn.microsoft.com/en-us/azure/azure-portal/supportability/how-to-create-azure-support-request
This way we can better track and assist you on this case
Thanks,
Joaquin Vano
Azure App Service


Test fails "delay Node handles bursts using a buffer" on ARMv8 (aarch64)

Environment: 96 core ARMv8 server, node v4.2.6 from Ubuntu 16.04.
Linux version 4.4.0-38-generic (buildd@bos01-arm64-006) (gcc version 5.4.0 20160609 (Ubuntu/Linaro 5.4.0-6ubuntu1~16.04.2) ) #57-Ubuntu SMP Wed Sep 7 10:19:14 UTC 2016 (Ubuntu 4.4.0-38.57-generic 4.4.19).
Repeat by:

Check out node-red, build according to package directions.
npm install -g istanbul
npm install coveralls
Execute the test that TravisCI runs, namely

istanbul cover ./node_modules/.bin/grunt --report lcovonly && istanbul report text && ( cat coverage/lcov.info | ./node_modules/coveralls/bin/coveralls.js || true ) && rm -rf coverage

Lots of tests pass, but this one fails:
1) delay Node handles bursts using a buffer:
     Error: timeout of 10000ms exceeded. Ensure the done() callback is being called in this test.

Warning: Task "simplemocha:nodes" failed. Use --force to continue.

Suggestions on a separate test invocation to test all the tests to completion? I don't know where the "--force" flag would go.
As an aside, on this very heavily parallel server, it's noticed when the build seems to run slowly; in particular, "npm install" looks single-threaded.

All nodejs apps are single threaded, adding cores will not change anything

This is a test that has occasionally failed for some time now - but not often enough to go chase down.
Had a look at it and made a bit more forgiving. But given we can't reliably make it fail, I can't say for certain if this will fix the issue. Obviously I don't have access to the hardware you've used here.

@knolleary (or anyone else) - if you're interested in getting access to this hardware, let me know; I'm using it at a hosted provider, and they have offered to provide access to others for testing.


Refactor code

Although it could also just delete the unused using result_type =  line, still keep the code style consistent with channel.hpp.

I don't see any value in this change.

It is also not correct as some methods that don't return anything, in this PR indicate they do.


[Question] Stored procedure parameters not matching up. not sure why.

This isn't really a bug, so much as a gap in my knowledge. This lowly noob jr. dev is at your mercy. 😊
I'm trying to access a sybase16 DB to create a node api. I have managed to successfully query with a select statement but would prefer not to do that for security purposes. when I try to call a stored procedure I'm getting a weird response. I need a sanity check here and figure out what I'm missing.
an example stored procedure I tried is a simple sp with one parameter to check for an email address using an account number (this is a fake sp of course, but formated the same way):
"DB"."spGetEmail"(@acctnum varchar(50) )
the docs show this:
const odbc = require('odbc');
odbc.connect(${process.env.CONNECTION_STRING}, (error, connection) => { connection.callProcedure(null, null, 'MY_PROC', [undefined], (error, result) => { if (error) { console.error(error) } // handle // result contains an array of results, and has a parameters property to access parameters returned by the procedure. console.log(result); }); });
I interpreted it to look like this:
odbc.connect(${process.env.CONNECTION_STRING}, (error, connection) => { connection.callProcedure(null, "DB", "spGetEmail", [123456], (error, result) => { if (error) { console.error(error) } // handle // result contains an array of results, and has a parameters property to access parameters returned by the procedure. console.log(result); }); });
then I get this:
[Error: [odbc] The number of parameters the procedure expects and and the number of passed parameters is not equal] { odbcErrors: [] } undefined Segmentation fault
seems straightforward, that I'm missing a parameter apparently. but I KNOW that this stored procedure takes one parameter. 😖
What am I missing here??
ps: this library is a godsend! you're the best!!

[SOLVED]
I'm not sure if the .callProcedure() method is broken or just not suited to Sybase16, but I found a way around it in case it's helpful to anyone in the future.
Instead of using the callProcedure() method, do this:
odbc.connect(connectionString, (error, connection) => {
    let my_procedure = "exec spGetEmail @acct='12345678'"

    connection.query(my_procedure, (error, result) => {
        if (error) { console.error(error) }
        console.log(result);
    });
});


261 new color scheme

Coverage remained the same at 100.0% when pulling 5e1321cec62becf3b060e714db319640a6b66528 on 261_new-color-scheme into 7fecfe1c5012ca487e09cedc5df6979cfaebaa41 on dev.

Coverage remained the same at 100.0% when pulling 761f62984d2ff4d16447b326fc293466c9773449 on 261_new-color-scheme into 2b67c8886b3c678089df3ae878746dd83efdc7ec on dev.

Coverage remained the same at 100.0% when pulling 4d7600a52d55a89bfa923e019132fc44a428b04b on 261_new-color-scheme into 7bd7a034f6bb655a431c50df6bc98ee7e559db3d on dev.

Coverage remained the same at 100.0% when pulling a991f3d5d010643293b72ad5b4d78c7a33cecd85 on 261_new-color-scheme into 7bd7a034f6bb655a431c50df6bc98ee7e559db3d on dev.

Coverage remained the same at 100.0% when pulling a991f3d5d010643293b72ad5b4d78c7a33cecd85 on 261_new-color-scheme into 7bd7a034f6bb655a431c50df6bc98ee7e559db3d on dev.

Coverage remained the same at 100.0% when pulling a957da1b275c66cb507cdc0fe3fe6dce8c884ffe on 261_new-color-scheme into cc61490acb9a26ef9bfc30c8cd55d64e2b66b199 on dev.

Coverage remained the same at 100.0% when pulling a957da1b275c66cb507cdc0fe3fe6dce8c884ffe on 261_new-color-scheme into cc61490acb9a26ef9bfc30c8cd55d64e2b66b199 on dev.

Coverage remained the same at 100.0% when pulling a957da1b275c66cb507cdc0fe3fe6dce8c884ffe on 261_new-color-scheme into cc61490acb9a26ef9bfc30c8cd55d64e2b66b199 on dev.

Coverage remained the same at 100.0% when pulling a957da1b275c66cb507cdc0fe3fe6dce8c884ffe on 261_new-color-scheme into cc61490acb9a26ef9bfc30c8cd55d64e2b66b199 on dev.

Coverage remained the same at 100.0% when pulling f9bf15f312e0d8f0a79ec06c91d56fbe322776b2 on 261_new-color-scheme into cc61490acb9a26ef9bfc30c8cd55d64e2b66b199 on dev.

Coverage remained the same at 100.0% when pulling 2be675622bff154fbc3ca75c80801677642f3f66 on 261_new-color-scheme into 873a45c0d1f0f583a01a27ee56a77bd895ecdda5 on dev.

Coverage remained the same at 100.0% when pulling 46dc3025d5714da9e4046229f00b6cfe06173559 on 261_new-color-scheme into 873a45c0d1f0f583a01a27ee56a77bd895ecdda5 on dev.

Coverage remained the same at 100.0% when pulling c2de7c9d7f4a3556946a14a080e93f7fdaa0b8ab on 261_new-color-scheme into 873a45c0d1f0f583a01a27ee56a77bd895ecdda5 on dev.

Coverage remained the same at 100.0% when pulling 3fc5c773c015786b4aeebcb32174a70189344fca on 261_new-color-scheme into 873a45c0d1f0f583a01a27ee56a77bd895ecdda5 on dev.

I got you a log from what happened in a single reload on my machine. Maybe you can look into it and figure out what went wrong: log.txt

And I feel like the "deletebutton"-red is a tiny bit too pink and to bright, it doesn't really match the calm  orange.

The picture overlap the text for some screen sizes, see picture.

And there are two "Willkommen am HPI" parts, but that may change with correct text examples. I'm just not sure whether that is still intended. (One at the top and one near the bottom)

Fixed the picture thing being weird
Changed the red to HPI "red"
The second block is supposed to house an "about us" section later on, as seen in #350

Coverage remained the same at 100.0% when pulling 665a1df962b03a1c3f78eb5a05cdf01602038c95 on 261_new-color-scheme into 873a45c0d1f0f583a01a27ee56a77bd895ecdda5 on dev.

the text color (red/green/gray) of agreement letter state on the participants overview page (/events/id/participants) is still gone

for some reason the status selection of applications on the event's page doesn't save anymore

Coverage decreased (-98.1%) to 1.853% when pulling 1b5a15c107bc9601f87cad74a56f7d4df10905dc on 261_new-color-scheme into 760a5036dd76e4a287707a07a8fa478227c795b3 on dev.

Coverage remained the same at 100.0% when pulling b7c83e1079140bbae6120df71a6fc58c2e495ca3 on 261_new-color-scheme into 760a5036dd76e4a287707a07a8fa478227c795b3 on dev.

@radscheit @tom95 You broke the applicant selection with this PR. Could you fix it?

@Baschdl MR #358 fixes it and adds tests to check if it's working


unfork ScalaTest

needed change was merged at
https://github.com/scalatest/scalatest/pull/984

test run: https://scala-ci.typesafe.com/view/scala-2.12.x/job/scala-2.12.x-integrate-community-build/783/consoleFull (404 til Jenkins catches up)

their 3.0.x branch is still missing a needed valsig related change; I requested it at https://github.com/scalatest/scalatest/pull/984

needed change was merged upstream
test run: https://scala-ci.typesafe.com/job/scala-2.12.x-integrate-community-build/925/consoleFull (404 til Jenkins finishes scrawling obscenities in the margins of his rhyming dictionary)

oops, wrong parameters on that one. trying again: https://scala-ci.typesafe.com/job/scala-2.12.x-integrate-community-build/928/consoleFull (404 til Jenkins Forest come to Dunsinane)

it worked! thanks @bvenners @cheeseng


Add a troubleshooting section to replace-drives.md

The disk may not get added to the pool automatically if autopool has been disabled. I have not personally tested and verified these steps.

@JasonGerend
Can you review the proposed changes? IMPORTANT: When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"


Massive gh-pages update

A request for a gh-pages update has been a long time coming and requested in #119 and #137.
This is simply an incorporation of content from current master, with the only conflicts being in .gitignore where _site had been on the gh-pages ignore list and I removed it since you didn't have it in master any longer (wasn't sure whether you may have actually needed that added back for gh-pages, and if so, whether it could be in both branches).
gh-pages's .gitignore had also been ignoring tests, but clearly you must have changed that so as to only ignore the auto-built tests/index.html rather than the test specs, so I didn't include the ignoring of the entire tests folder into the merger.

Are there any actual changes to the files that make up the documentation or have you just merged master across? The gh-pages and master branches don't converge.
I've been toying with the idea of straight up deleting the branch and using the GitHub tooling to create it again from the readme.md file, which is how I did it originally.

Oh, sorry, I hadn't noticed there were other commits added to gh-pages, but yeah, I just merged master into it (and reconciled the one conflict that showed up, gitignore).

Closing as it doesn't actually solve the problem


[Feature Request] Execute inline queries

Feature Request
Would it be possible to automatically execute single or multi-line queries? The user process I had in mind was:

highlight text to execute
press reserved key bind command (maybe alt + shift + ENTER)
execute SQL: Query command and pass the highlighted text as a parameter

I don't know anything about vscode extensions, but I could try it out. Would this feature be possible at all? Does anyone know of another extension that takes input from highlighted text?

It looks like the Microsoft's official extension for doing this with MS SQL server does exactly what you're specifying. Looking at their source code, things look quite a bit more complicated than this extension.  This model seems to handle the business logic of showing the query results in a tabular format. I'm guessing it would not be trivial to port some of their logic into this extension.

Sorry for being late to the topic, but did you mean select the chunk of text and execute only that portion, right ?

mysql-scratchpad can do that. But it doesn't have IntelliSense nor can save connections. Can someone please merge the two extensions?

@Torvin you can take a look into my fork at the branch dev-sqlite3, I added this functionality at the runquerybuild file and added a command (ctrl+enter) for it


Errors that reach Jetty aren't correlated with their requests

I recently enabled correlated logs, which was basically taking the trace id from the X-Cloud-Trace-Context header and passing it along with logback messages using the TraceLoggingEnhancer. This works for all the log messages I explicitly generate, great.
It doesn't however seem to work with exceptions that are passed up to the top level and handled by Jetty. Let's say I have a servlet that throws an exception. That exception is caught by Jetty and logged out (as textPayload), but it doesn't seem to be correlated with the request. Consequently, it's really hard to figure out what happened.
I'm not sure if this is a bug, feature request, or question. I'm trying to get logs back to the usability of the Java8 runtime. I can get all my explicit logs correlated with the request, but the jetty-issued logs (such as an exception thrown out of my code) seem to be out of my control. Should I explicitly log exceptions in a top level filter and never let Jetty see them? I guess my main concern there is that any Jetty-internal errors would still remain uncorrelated. As a developer, it seems like this should be part of infrastructure.
I'm using the Java17 runtime with the legacy compatibility layer, so deployed as a WAR.

Hmmmm, upon further analysis it looks like they actually are getting correlated. Nevermind this issue. Sorry about the noise!


Cannot build on latest RN 0.73.4

Description
When trying to build I get the error:
FAILURE: Build failed with an exception.
* What went wrong:
Could not determine the dependencies of task ':app:compileDebugJavaWithJavac'.
> Could not resolve all task dependencies for configuration ':app:debugCompileClasspath'.
   > Could not resolve project :lottie-react-native.
     Required by:
         project :app
      > No matching configuration of project :lottie-react-native was found. The consumer was configured to find a component for use during compile-time, preferably optimized for Android, as well as attribute 'com.android.build.api.attributes.BuildTypeAttr' with value 'debug', attribute 'com.android.build.api.attributes.ProductFlavor:store' with value 'play', attribute 'com.android.build.api.attributes.AgpVersionAttr' with value '8.1.1', attribute 'org.jetbrains.kotlin.platform.type' with value 'androidJvm' but:
          - None of the consumable configurations have attributes.

It used to work fine when I was on RN 0.69.12
React Native Environment
RN 0.73.4
bare project (no expo)
old arch
Lottie Version
Version: 6.6.0
Additional info:
Not sure, but perhaps this is due to a misconfiguration of the new MainApplication.kt?
it used to be MainApplication.java, but RN move to kotlin; and with that I guess the doc should be updated?
In MainApplication.java we had to add the Lottie package like so:
@Override
        protected List<ReactPackage> getPackages() {
          @SuppressWarnings("UnnecessaryLocalVariable")
          List<ReactPackage> packages = new PackageList(this).getPackages();
          // Packages that cannot be autolinked yet can be added manually here, for example:
          // packages.add(new MyReactNativePackage());
          packages.add(new LottiePackage()); // <--- lottie added here
          return packages;
        }

which turned into kotlin should (?) give the following:
 override fun getPackages(): List<ReactPackage> {
          val packages = PackageList(this).packages
          packages.add(LottiePackage())
          return packages
        }

But I am really unsure if that is related
Also, do we still need to have the
import com.airbnb.android.react.lottie.LottiePackage
at the top of the MainApplication file?
I no longer see it in the doc, it used to be mandatory for it not to crash.
I tried removing it (thus removing the necessary added package mentioned above)
But to no avail, still getting the same error upon building
same for the line
 implementation project(':lottie-react-native')
in the app/build.gradle: is it still needed?

FIXED:
had to remove all mention of lottie in
app/build.gradle
settings.gradle
MainApplication


Fixes units for filesizes in index.htm

Fixes a small error that I noticed when viewing the website.

I just realized that this may be European decimal notation, if that is the case then please feel free to discard this PR.

I just realized that this may be European decimal notation, if that is the case then please feel free to discard this PR.

Or i should've known. I would go for XX,YYY byte instead of XX.YYY kilobyte as it's shorter.

Ok, I've updated the PR.

Thanks! :heart:


Pause option

Add a manual endpoint to pause the sink
PUT /pause
If the sink is paused, it will return an error code to trigger exponential backoff from the webhook sink.

Closed by #83


Failure bundling rspec on master

This works fine on 1.6.3.
(I built 1.6.3 from master for the below test)
> git checkout git://github.com/rspec/rspec-support.git && cd rspec-support
> bundle
Fetching git://github.com/rspec/rspec.git
Fetching git://github.com/rspec/rspec-core.git
Fetching git://github.com/rspec/rspec-expectations.git
Fetching git://github.com/rspec/rspec-mocks.git
Fetching gem metadata from https://rubygems.org/.........
Fetching additional metadata from https://rubygems.org/..
Resolving dependencies...
Using rake 10.0.4
Using bundler 1.6.3
Using diff-lcs 1.2.5
Using docile 1.1.5
Using multi_json 1.10.1
Using simplecov-html 0.8.0
Using simplecov 0.8.2
Using rspec-support 3.1.0.pre from source at .
/Users/xavier/.rvm/gems/ruby-2.1.2/gems/bundler-1.6.3/lib/bundler/shared_helpers.rb:52: warning: conflicting chdir during another chdir block

Errno::ENOENT: No such file or directory @ rb_file_s_stat - exe/rspec

Errno::ENOENT: No such file or directory @ rb_sysopen - lib/rspec/expectations.rb

Errno::ENOENT: No such file or directory @ rb_file_s_stat - lib/rspec/mocks.rb
An error occurred while installing rspec-core (3.1.0.pre), and Bundler cannot continue.

I have this problem. Is it closed because there is a solution?

@simmogs could you please open a new issue with details of your setup if you're seeing problems on bundler 1.9.9 or 1.10.1? Thanks!


fix(qwik-city): support non-root basePathname for service-worker.js

What is it?

[ ] Feature / enhancement
[x] Bug
[ ] Docs / tests

Description
Related to this issue: https://github.com/BuilderIO/qwik/issues/1855
tl;dr:

service worker register code refers to /base/base/service-worker.js
service worker output to dist/base/service-worker.js would be served under http://localhost:5173/base/base/service-worker.js which would give the service worker a default scope of /base/base/ and be effectively useless
route patterns generated for the base route would match /base/ and /base//

There are a few issues I noticed with the service worker when provided a non-root basePathname (e.g. /base/).
The original issue focused around the first issue where @qwik-city-sw-register was:
((s,a,i,r)=>{i=(e,t)=>{t=document.querySelector("[q\\:base]"),t&&a.active&&a.active.postMessage({type:"qprefetch",base:t.getAttribute("q:base"),...e})},document.addEventListener("qprefetch",e=>{const t=e.detail;a?i(t):t.bundles&&s.push(...t.bundles)}),navigator.serviceWorker.register("/base/base/service-worker.js").then(e=>{r=()=>{a=e,i({bundles:s})},e.installing?e.installing.addEventListener("statechange",t=>{t.target.state=="activated"&&r()}):e.active&&r()}).catch(e=>console.error(e))})([])

which includes the basePathname twice: /base/base/service-worker.js.
The second related issue is that the service worker chunk is emitted to dist/base/service-worker.js which gets served on http://localhost:5173/base/base/service-worker.js. The other qwik chunks are in dist/build.
I did update entry.express.tsx to be:
app.use(`/base/build`, express.static(buildDir, { immutable: true, maxAge: '1y' }));
app.use(`/base`, express.static(distDir, { redirect: false }));

These two issues together though does make the service-worker.js registration work correctly which led me to originally believe this wasn't that big of an issue. However, with the http://localhost:5173/base/base/service-worker.js path, the service worker's scope is /base/base/ rather than just /base/. This makes it so only pages underneath /base/base/ can interact with the service worker and ultimately the service worker does nothing. (I confirmed this via the Chrome DevTools service worker network.)
A third issue I noticed was the service worker would generate a link bundle that includes a pattern that would match /base/ and /base//:
const linkBundles=[[/^\/base\/flower\/?$/,[3,4,14,5]],[/^\/base\/\/?$/,[3,4,17,1]]];

Note the pattern here is: /^\/base\/\/?$/.
Side-note: If I put a grouped layout at the root of routes like /src/routes/(group)/index.tsx, this will generate the proper pattern of /^\/base\/?$/.
Tracing through the code, the solve I found for the first two issues was to remove the entire basePathname from the chunkFilename for service worker entries in the qwik city build time plugin. And the solve for the last issue was to filter out empty segments when generating the route patterns since the route here would be /base/ which would produce segments of ['base', ''] (which no other routes would ever produce this empty string).
Use cases and why

Service worker should be emitted to dist/service-worker.js and served under http://localhost:5173/base/service-worker.js with route patterns that would match /base and /base/.
Side-note: in order to support the non-trailing slash /base path, I needed to add a Service-Worker-Allowed header to the service-worker.js file in entry.express.tsx:
app.use(/.*\/service-worker\.js$/, (_req, res, next) => {
  res.setHeader('Service-Worker-Allowed', '/base');
  next();
});

Checklist:

[x] My code follows the developer guidelines of this project
[x] I have performed a self-review of my own code
[ ] I have made corresponding changes to the documentation
[x] Added new tests to cover the fix / functionality

This is an amazing piece of work! thank you so much for your PR!, hope to see more :)
Thanks for your time!


Check permissions after they are shown

If a user denies a permission request the next page is shown. The expected behavior is that the current page stays as long as the user hasn't accepted the permission request.

No it's not. Permissions are to be asked once regardless of if the user accepts or denies them. If the user doesn't want location to be used, then it's not used.
The whole idea of Android 6.0 permissions is to give the user the choice in these matters. It would be annoying if I didn't want a permission and the app locked up because I didn't give it what it wants.
That defeats the purpose of giving them the option to deny access to whatever is being requested!
I would consider any app that does this to be in violation of the Android guidelines. As developers, our apps should be open for users to choose what they want and don't want. If they don't want location to be used, tell them briefly why it needs to be used, but ultimately, don't annoy them because they denied access to it.

Furthermore, here's a quote from the developer docs:
The user can grant or deny each permission, and the app can continue to run with limited capabilities even if the user denies a permission request.
http://developer.android.com/training/permissions/requesting.html

At least you should have an option for both.
E.g. You implement the app intro for a file manager that would force close if it hasn't the storage permission...

@HeinrichReimer that is up to the developer of the app to implement this type of thing. The intro library is merely a way to request permissions and talk to the user about them. It does not do things based on what the user does with the request.

Ok, I understand


Health check endpoint is also locked behind API KEY once API_KEY is set, causing healthchecks to fail

System Info
docker container (v1.5.0)
Information

[X] Docker
[ ] The CLI directly

Tasks

[X] An officially supported command
[ ] My own modifications

Reproduction
run TEI with API_KEY environment variable set, and doing a GET /health returns 401 status code
Expected behavior
200 status code when polling /health endpoint, with the API_KEY environment variable set

i see, the last release was back in july, so the fix hasn't been released yet. thanks for pointing me to this issue, will be closing


Free account registration

Usually, before using Fungible Tokens in Near the new user should register by transferring some storage deposit: https://docs.near.org/develop/relevant-contracts/ft#registering-a-user
However, in the current realization, some new users can be registered for free without storage_deposit. For example here: https://github.com/aurora-is-near/aurora-eth-connector/blob/master/eth-connector/src/lib.rs#L223 or here https://github.com/aurora-is-near/aurora-eth-connector/blob/master/eth-connector/src/lib.rs#L563
Moreover, we implement all standard FungiableTokens interfaces, including storage_unregister https://github.com/aurora-is-near/aurora-eth-connector/blob/master/eth-connector/src/lib.rs#L434
which transfer self.storage_balance_bounds().min.0 + 1 back to the user. So, he can get back the deposit that he never provided.
storage_balance_bounds().min.0 is a standard function that we don't change

We used standard storage_unregister or storage_withdraw.

storage_withdraw always panics
storage_unregister:

    fn internal_storage_unregister(
        &mut self,
        sender_id: AccountId,
        force: Option<bool>,
    ) -> Option<(AccountId, Balance)> {
        assert_one_yocto();
        let account_id = sender_id;
        let force = force.unwrap_or(false);
        if let Some(balance) = self.ft.accounts.get(&account_id) {
            if balance == 0 || force {
                self.ft.accounts.remove(&account_id);
                self.ft.total_supply -= balance;
                Promise::new(account_id.clone()).transfer(self.storage_balance_bounds().min.0 + 1);
                Some((account_id, balance))
            } else {
                env::panic_str(
                    "Can't unregister the account with the positive balance without force",
                )
            }
        } else {
            crate::log!("The account {} is not registered", &account_id);
            None
        }
    }

2.1. If balance == 0 - just return attached deposit 1 yocto
2.2 if forse - same logic
What register_account_if_not_exists do? Because we used standard NEP-141 implementation, and actually ft_transfer - inside that method we insert account, and the standard function does not check storage_balance. But we need to count all available accounts. So that function pre-init account definitely will be created and increment counter. So it's all around standard NEP-141 methods.

I see, the ft created without constructor, and the account_storage_usage set as zero. So it is consistent, and storage_deposit cost 0 Near tokens
https://github.com/aurora-is-near/aurora-eth-connector/blob/master/eth-connector/src/lib.rs#L189
https://docs.rs/near-contract-standards/latest/src/near_contract_standards/fungible_token/storage_impl.rs.html#100


quotes and asset and archive digest endpoints

is there a reason the digest endpoints return the digests with quotes?
http://staging.refgenomes.databio.org/v2/asset/hg19/fasta/default/archive_digest?tag=default
"06e47db59dad7054c4b45df7abbaef20"

also: http://staging.refgenomes.databio.org/v2/asset/hg19/fasta/default/asset_digest?tag=default
"7ce3b03e30d6ef76af8c3ad09a141dfc"

we return a python str from the endpoint and in the FastAPI docs they say that some behind the scenes preprocessing is performed upon return:
https://fastapi.tiangolo.com/tutorial/response-directly/ so that's probably a result of that.
Also, any client applications that will query the server to get the digest should handle this JSON properly, as they expect a string anyway, right?

I see. I guess I don't really feel the need to return it as a JSON if it's an atomic output like that...what if you're just hitting it from somewhere like a command line or something? you'd have to pipe to jq to parse it, even for atomic endpoints... what do you think?

I think we need to switch this.
It's inconvenient to get a string with quotes for something like this: http://rg.databio.org/assets/file_path/2230c535660fb4774114bfa966a62f823fdb6d21acf138d4/fasta/fasta?remoteClass=http
now in particular when we're returning paths. the quotes offer no advantage as far as I can see.


Single base config / instructions for Jubilee kit

Topic
Blair and I chatted and aligned on the idea of bringing in the PDFs from the Jubilee wiki into Science Jubilee as static copies, and splitting the PDF pages to allow for in-between content. Each PDF "packet" would get its own webpage (i.e., click next to go to the next "packet"), and each PDF page would have it's own markdown heading with a simple title to make it easier to figure out where to edit it.

Hey @sgbaird, how does this look? #130


EditorConfig Support

This would probably be a bit of work, but would certainly be a nice-to-have. I think Qt supports this type of config file as well, so hopefully that'd reduce the required work.
In case anyone is unfamiliar, this is EditorConfig.

I think it's easy to use QSettings and apply the settings to the editor by yourself.

Right, it supports the file format. But why have everyone else implement this feature instead of just adding it to the library?

I think you mean providing a preference window, but your application may have a preference window, and it's strange to have two.

I think using QSettings is not much harder than calling the responding functions like setTabReplaceSize(), so I believe you mean the preference window.

I don't mean having a preference window, I just mean a function like this:
QCodeEditor::loadEditorConfig(const char* filename) {
  /* here */
}

The file is not really a user settings file. It's dropped into git repositories to help consistency in the project's indentation style.

Oh, is that something like .clang-format? Sorry for that, I didn't read https://editorconfig.org/. However, the name "EditorConfig" is really confusing.

So (how) is EditorConfig better than Clang Format?

Yes, it's very similar to .clang-format. No worries!
I wouldn't say that it's better. I've only ever used clang-format passively, in a formatting script. EditorConfig is usually integrated into a code editor so that it actively maintains the indentations as they are written. I'm sure there's some plugins that support this from a .clang-format file, but I don't really use them.
If there's anything .editorconfig definitely does better than .clang-format, it's that it's much simpler and easier to put into an existing editor. Trying to integrate .clang-format, on the other hand, requires either supporting the many different versions of the clang libraries.


feat: [M3-6643] - Improve error messaging when Image creation or upload fails

Description 📝
It can be difficult for users to identify the specific reason why a Linode Image creation attempt has failed. With more guidance in Cloud Manager, users will be able to quickly identify an issue related to Image size limits without needing to open a ticket.
This ticket focuses on small tweaks we can make to improve our error messaging in the UI based on what is currently returned from the backend.
Note: I have occasionally seen the persistent error toasts appear 5 times for a single image failure but it's not consistent and I haven't been able to repro -- let me know if you observe this too.
Major Changes 🔄

Updated helper text on Images -> Create -> Upload Image to inform users that the maximum image size is 6 GB (uncompressed).
Updated image_upload and disk_imagize (image capture) event messages on failed action.
Updated copy for image_upload and disk_imagize toast messages on failed action.
Made error toasts persistent, requiring the user to close it to dismiss, which ensures the user can see an error has occurred.

Preview 📷
Updated helper text on image upload tab

Updated disk_imagize event message

Updated image_upload event message

Updated disk_imagize toast message

Updated image_upload toast message

How to test 🧪

How to setup test environment?

Know how to adjust your maximum image size to in admin. (Reach out if you need more info on what to change.) This is normally 6044MB  or ~6GB. We want to be sure that we hit the limit by setting it small to trigger the error we'd see if we exceeded the actual image size.

How to verify changes?

Capture Image:

Change your maximum image size to 1 in admin. (Note: 0 will not work! This seems like a bug on the backend...)
Have a 1GB Nanode on hand.
Go to http://localhost:3000/images/create/disk to create a new image captured from disk.
Select the 1GB Nanode and its disk and click 'Create Image'.
You will be redirected back to the Images landing page; Image will show with "creating" status in Custom Images table.
Creation will eventually fail, at which point you should observe the disk_imagize failed event message in the notification menu and persistent error toast should appear.

Previously: toast showed for a few seconds with the message Error creating Image [disk name], then disappeared. The notification center event message was also the same vague message. A user had no way of knowing why failure occurred or how to potentially address it.

Upload Image:

Change your maximum image size to 0 in admin. (Note: you could leave it as 1, but you'd need to upload a zipped file >1MB.)
For the purposes of this PR, compress any file you've got on hand (e.g. touch test.txt && echo hello >> test.txt && gzip test.txt should be fine).
Go to http://localhost:3000/images/create/upload and upload your compressed file that is under the 5GB max file size but exceeding the max image size (which we've reduced to 0 temporarily) and see upload seem to work.
You will be redirected back to the Images landing page; Image will show with "creating" status in Custom Images table.
Creation will eventually fail, at which point you should observe the image_upload event message in the notification menu and persistent error toast should appear.

Previously: toast showed for a few seconds with the message There was a problem processing image [name]: Image is larger than allowed image size 1; please contact Support, then disappeared. We've made the toast message more specific with a direct call to action (support ticket link). There is no <SupporttLink> for the event message because we are limited to strings, not components.

Remember to reset your max image file size back to 6044 when you're done testing!

How to run Unit or E2E tests?

yarn cy:run -s 'cypress/e2e/images/machine-image-upload.spec.ts'

a bit off in mobile view

@hana-linode Good catch. Default styling of the snackbar wasn't handling flex wrapping well in messages with an additional link component. Adjusted some styling at the smaller breakpoints to fix this - can you have another look?
https://github.com/linode/manager/assets/114685994/d144426f-c40c-4055-9ff2-8956b5895230


Newbie: build kubedirector error Couldn't resolve host name for https://cdn-ubi.redhat.com/...

Hello,
I have an error probably trivial but I don't know how to fix to build kubedirector.
I have added on /etc/resolv.conf all DNS to solve the dns entries but still fail the build.

ERROR: make
[root@rhel01 kubedirector]# make

Creating KubeDirector deployment image and YAML...
operator-sdk build bluek8s/kubedirector:0.3.0
INFO[0058] Building OCI image bluek8s/kubedirector:0.3.0
Sending build context to Docker daemon  313.1MB
Step 1/13 : FROM registry.access.redhat.com/ubi7/ubi-minimal:latest
---> 2b4f0d37c483
Step 2/13 : ENV USER_UID=1001     USER_NAME=kubedirector     USER_HOME=/home/kubedirector     OPERATOR=/home/kubedirector/kubedirector     OPERATOR_BUILD_SRC=build/_output/bin/kubedirector
---> Using cache
---> 1a1b0d0365ae
Step 3/13 : RUN microdnf update -y && rm -rf /var/cache/yum
---> Using cache
---> 72cf72d45ec0
Step 4/13 : RUN microdnf -y install --nodocs psmisc procps-ng     && microdnf clean all
---> Running in 0f2e68023aa8

(microdnf:6): librhsm-WARNING **: 22:04:31.270: Found 0 entitlement certificates
(microdnf:6): librhsm-WARNING **: 22:04:31.271: Found 0 entitlement certificates
Downloading metadata...
(microdnf:6): libdnf-WARNING **: 22:04:38.774: Skipping refresh of ubi-7: cannot update repo 'ubi-7': Cannot download repomd.xml: Cannot download repodata/repomd.xml: All mirrors were tried; Last error: Curl error (6): Couldn't resolve host name for https://cdn-ubi.redhat.com/content/public/ubi/dist/ubi/server/7/7Server/x86_64/os/repodata/repomd.xml [Could not resolve host: cdn-ubi.redhat.com; Unknown error]
Downloading metadata...
(microdnf:6): libdnf-WARNING **: 22:04:49.730: Skipping refresh of ubi-7-server-optional-rpms: cannot update repo 'ubi-7-server-optional-rpms': Cannot download repomd.xml: Cannot download repodata/repomd.xml: All mirrors were tried; Last error: Curl error (6): Couldn't resolve host name for https://cdn-ubi.redhat.com/content/public/ubi/dist/ubi/server/7/7Server/x86_64/optional/os/repodata/repomd.xml [Could not resolve host: cdn-ubi.redhat.com; Unknown error]
Downloading metadata...
(microdnf:6): libdnf-WARNING **: 22:04:58.677: Skipping refresh of ubi-7-server-extras-rpms: cannot update repo 'ubi-7-server-extras-rpms': Cannot download repomd.xml: Cannot download repodata/repomd.xml: All mirrors were tried; Last error: Curl error (6): Couldn't resolve host name for https://cdn-ubi.redhat.com/content/public/ubi/dist/ubi/server/7/7Server/x86_64/extras/os/repodata/repomd.xml [Could not resolve host: cdn-ubi.redhat.com; Unknown error]
Downloading metadata...
(microdnf:6): libdnf-WARNING **: 22:05:07.649: Skipping refresh of ubi-7-rhah: cannot update repo 'ubi-7-rhah': Cannot download repomd.xml: Cannot download repodata/repomd.xml: All mirrors were tried; Last error: Curl error (6): Couldn't resolve host name for https://cdn-ubi.redhat.com/content/public/ubi/dist/ubi/atomic/7/7Server/x86_64/os/repodata/repomd.xml [Could not resolve host: cdn-ubi.redhat.com; Unknown error]
Downloading metadata...
(microdnf:6): libdnf-WARNING **: 22:05:16.509: Skipping refresh of ubi-server-rhscl-7-rpms: cannot update repo 'ubi-server-rhscl-7-rpms': Cannot download repomd.xml: Cannot download repodata/repomd.xml: All mirrors were tried; Last error: Curl error (6): Couldn't resolve host name for https://cdn-ubi.redhat.com/content/public/ubi/dist/ubi/server/7/7Server/x86_64/rhscl/1/os/repodata/repomd.xml [Could not resolve host: cdn-ubi.redhat.com; Unknown error]
Downloading metadata...
(microdnf:6): libdnf-WARNING **: 22:05:25.394: Skipping refresh of ubi-7-server-devtools-rpms: cannot update repo 'ubi-7-server-devtools-rpms': Cannot download repomd.xml: Cannot download repodata/repomd.xml: All mirrors were tried; Last error: Curl error (6): Couldn't resolve host name for https://cdn-ubi.redhat.com/content/public/ubi/dist/ubi/server/7/7Server/x86_64/devtools/1/os/repodata/repomd.xml [Could not resolve host: cdn-ubi.redhat.com; Unknown error]
error: No package matches 'psmisc'
The command '/bin/sh -c microdnf -y install --nodocs psmisc procps-ng     && microdnf clean all' returned a non-zero code: 1
Error: failed to output build image bluek8s/kubedirector:0.3.0: (failed to exec []string{"docker", "build", "-f", "build/Dockerfile", "-t", "bluek8s/kubedirector:0.3.0", "."}: exit status 1)
Usage:
operator-sdk build  [flags]
Flags:
-h, --help                      help for build
--image-build-args string   Extra image build arguments as one string such as "--build-arg https_proxy=$https_proxy"
--image-builder string      Tool to build OCI images. One of: [docker, buildah] (default "docker")
Global Flags:
--verbose   Enable verbose logging
make: *** [Makefile:52: build] Error 1

VERIFICATION ACCESS:
[root@rhel01 kubedirector]#    wget https://cdn-ubi.redhat.com/content/public/ubi/dist/ubi/server/7/7Server/x86_64/devtools/1/os/repodata/repomd.xml
--2020-01-02 01:45:55--  https://cdn-ubi.redhat.com/content/public/ubi/dist/ubi/server/7/7Server/x86_64/devtools/1/os/repodata/repomd.xml
Resolving cdn-ubi.redhat.com (cdn-ubi.redhat.com)... <IP_ADDRESS>
Connecting to cdn-ubi.redhat.com (cdn-ubi.redhat.com)|<IP_ADDRESS>|:443... connected.
HTTP request sent, awaiting response... 200 OK
Length: 3850 (3.8K) [application/xml]
Saving to: ‘repomd.xml.1’

repomd.xml.1                              100%[==================================================================================>]   3.76K  --.-KB/s    in 0s
2020-01-02 01:45:56 (164 MB/s) - ‘repomd.xml.1’ saved [3850/3850]
[root@rhel01 kubedirector]# cat /etc/resolv.conf
Generated by NetworkManager
nameserver <IP_ADDRESS>
nameserver <IP_ADDRESS>
nameserver <IP_ADDRESS>
nameserver <IP_ADDRESS>
Thanks in advance,
Miguel

Using version 0.3.0, redhat 8.1

Looks like docker daemon is not setup properly to have access to internet or resolve hostnames. So the container is not able to access internet or resolve dns info? After modifying the /etc/resolv.conf, have you tried restarting docker demon? You can also change daemon.json to include the dns servers.

Thanks swami,
I have fixed the issue finally adding proxy env on Dockerfile.
ENV http_proxy=web-proxy:8088
ENV https_proxy=web-proxy:8088
Best Regards
Miguel

I forgot to comment that my server is behind a VPN with proxy, it is because I needed to add it.
Thanks for your support.
Best regards
Miguel

Glad you got it working!


Include additional VM status phases

We currently only have 'Created' and 'Deleted' as possible VM status phases. As a result, we don't have a means to represent any intermediate phases that the VM goes through. It would be useful to have the following additional phases:

Creating
Deleting
Unknown
It would certainly help give feedback to the user/client that the system is processing the input (Create/Delete). Also, 'Unknown' would help the client identify situations when VM Operator cannot determine the current state of the VM through its provider.

As it stands, there are multiple fields that represent status. You have the vm status phase, the power state and things like network state.
I think there's value in having "Creating" if there are pre-requisite steps like downloading a BLOB that may take a reasonable amount of time before the VM is created. "Deleting" seems useful as a mirror of Creating although I wouldn't have thought it would spend long in this phase.
I know @zjs has given some input previously on phases that are "in progress" vs "static state"

'Creating' might also help provide better user-experience in situations where a VM cannot be scheduled due to issues like resource utilization, wherein additional information can be provided through Events or constructs like Conditions (or equivalent). i.e., a VM stuck in 'Creating' is a hint to probe further into what might be blocking the Create (an equivalent of 'Pending' in pods).

If a VM can't get the compute resource to run, it will get created but will be unable to power on.

I see. Thanks for clarifying. Do you have any suggestions regarding capturing that scenario (unable to power-on due to resource utilization issue) in a phase?

The Machine type in cluster-api also has a phase field in v1alpha3 https://github.com/kubernetes-sigs/cluster-api/blob/master/api/v1alpha3/machine_phase_types.go should we try to align with that?

@janitha : I think that's a good point, since cluster-api is one of the consumers/clients. My thoughts:

I think having a single phase 'Creating' should suffice instead of 'Pending' and 'Provisioning'.
We currently indicate 'Running' with a combination of 'Created' and status.PowerState. Not sure if changing that is a good idea considering that there are clients that are already using status.PowerState.
There could be value in adding 'Failed' to indicate the need for user-intervention.

I think having the proposed phases will provide value in giving the customer a better state of their VM. I like "Provisioning" better than "Creating", simply because provisioning can encompass "Creating" and other necessary customizations. However, since we already have a "Created" phase, I am fine with having "Creating" to maintain continuity.

There could be value in adding 'Failed' to indicate the need for user-intervention.
I agree that this might be helpful. Although an implementation detail, I am not sure about how we will come up with a list of errors that will require user intervention though.

Thanks for your comments @aruneshpa . Yes, 'Creating' is more inline with the existing 'Created'. Also agree that 'Failed' might need more thought. So I'll exclude it for now.

To summarize, here's the full list of phases including the newly proposed ones:

Phase
Description

Creating  (new)
The VM is being created. This also encompasses OVF deploy, which could take long and encounter failures.

Created
The VM has been created. Note that power-state of the VM can be obtained from Status.PowerState.

Deleting (new)
The VM is being deleted.

Deleted
The VM has been deleted by the provider.

Unknown (new)
The status for VM could not be obtained (host not reachable?). State transition to Unknown can happen from any of the above states, and at any time.

@jainvarun21 as we discussed "offline", this looks good to me:

it doesn't break backwards compatibility and doesn't force us to change API versions.
Creating is useful if we ensure that Creating encompasses the long phase when OVF deploy is occurring.


Dependencies not being tracked

We have a stateless service that is running some background process when a service bus message is received. We are referencing Microsoft.ApplicationInsights.ServiceFabric.Native 2.1.1 nuget package.
In the constructor of the StatelessService we are setting the insights key and initializing the telemetry as follows:
var telemetryConfig = TelemetryConfiguration.Active;
telemetryConfig.InstrumentationKey = key;
abricTelemetryInitializerExtension.CreateFabricTelemetryInitializer(context);

We want to track every new message as a request, so when we process the message we create a new RequestTelemetry:
public RequestTelemetry StartRequest(string name)
 {
   var request = new RequestTelemetry { Name = name, Timestamp = DateTime.UtcNow };
   return request;
}

We then Trace the request at the end:
public void TraceRequest(RequestTelemetry request, bool success, string responseCode = null)
{
  request.Duration = DateTime.UtcNow - request.Timestamp;
  request.Success = success;
  request.ResponseCode = responseCode ?? (success ? "200" : "500");
  _client.TrackRequest(request);
 }

In between there are 3 dependecy calls: 1 to SQL Azure, another to Postgres, and the last one to Azure Search Services.
We do see the request on the VS Application Insights tab, but we do not see any dependencies related to the requests or by themselves.
Are we missing any configuration?

Hi @jstawski
Please take a look at this article:
https://devdiv.visualstudio.com/DefaultCollection/DevDiv/Service Profiler/_workitems/edit/553952
You probably need to use a very recent version of ServiceBus library, and the message handler pattern mentioned in that doc.

hi @brahmnes, thanks for the quick reply. We are using the latest version of service bus client and are also using the message handler pattern. I first removed any custom request operation to see if anything would be tracked automagically, but nothing was tracked, even though the document says it would automatically do so. Then I implemented telemetryClient.StartOperation and it did log the request, but it was still missing the dependencies. I manually added a trace operation and it logged correctly, correlating it to the parent operation. I forgot to mention before that we are using .NET Core. Am I missing any configuration?

Can you also confirm if this is a .NET or .NET core app? Since this is a stateless service, I suspect this is more of a console app and not an ASP.NET web app?
Which version of AppInsight SDK you are using and how are you enabling AppInsights?

This is a .NET Core App and it is not an ASP.NET Web App. Using version 2.6.4 of App Insights SDK

Since this is not a ASP.NET core app, I suspect you may need to do extra setup to get the automatic behavior for AppInsights.
In an ASP.NET core app, there is a UseApplicationInsights() method allowing AppInsights to setup the automatic listeners.
https://github.com/Microsoft/ApplicationInsights-aspnetcore/wiki/Getting-Started-with-Application-Insights-for-ASP.NET-Core
With a vanilla .NET core app in your case, you need to setup a DependencyTrackingTelemetryModule with your TelemetryConfiguration. This should give you the dependencies. For getting the request telemetry, I don't know how to setup the "handshake" between service bus SDK and AppInsights, other than just calling StartOperation. @lmolkova, can you provide some insights on setting up for a console style .NET core app?

@jstawski, with the console app you have an option to use ApplcaitonInsights.config or configure ApplicationInsights components one by one programmatically. You can find details and examples in this article: https://docs.microsoft.com/en-us/azure/application-insights/application-insights-console. If you need to enable some other scenario not covered by the article, feel free to create an issue

@lmolkova and @brahmnes thank you for your help. I was able to track the dependecies by pulling information from multiple sources.
Some feedback I have in general with Azure is the lack of good/advanced documentation. This was one of those cases. Service Fabric is a major product within Azure, why isn't there a well established documentation explaining how to set it up. Furthermore, there are two NUGET packages specifically for Service Fabric, but almost no documentation for it. I was expecting for it to work exactly like the ASP.NET Service Fabric package where I would install it and things will magically start working. I even went through the Add Application Insights wizard in Visual Studio 2017. The weird part is that I got it to work without those Service Fabric packages and I still don't understand why or what side effects it would have.
In short, I had to add Microsoft.ApplicationInsights version 2.6.4 and Microsoft.ApplicationInsights.DependencyCollector version 2.6.4. I wasn't able to initialize it declaratively through ApplicationInsights.config, but instead I had to initialize everything via code like specified here.

@jstawski Thank you for your valuable feedbacks!
The nuget package specifically for Service Fabric is mainly for the Context Problem, and correlation when communicating through SF remoting.
@dkkapur Are we able to improve the documentation for Service Fabric diagnostics? As @jstawski mentioned, there is no documentation for these two SF nuget packages. And the "Add Application Insights" wizard in VS does not include these libraries. Also, the AI configuration story varies based on the project types, we probably want to add a link specifically for the configuration.


No results, empty output.html file

Describe the bug
When no findings are generated, an empty output.html is generated.
To Reproduce
Steps to reproduce the behavior:

Create an empty directory, add a single file called "test.c".

Run Application Inspector (CLI).

See the output file is empty.

Expected behavior
The output message from the CLI should probably just say, "No results were generated" and the file shouldn't be overwritten (if it exists). The output error level should probably be non-zero too.
Operating Environment (please complete the following information):

Application Inspector Version: [from appinspector -v]
ApplicationInspector.CLI 1.5.10+0f96c5869d
OS: [e.g. Windows 11 21H2 22000.613, MacOS 13.0.1, Linux Ubuntu 20.04]
Windows 11

Good catch. I noticed this behavior today as well. The issue is the html report generation logic checks for a "success" status - which excludes "no matches" and no-ops if it has no success.

I have an idea for a fix but it needs testing as I'm not sure what the html report generator does if it has no matches. Will take a look tomorrow.


Update stable version in repo from 1.3.8 to 1.3.10

Think about update stable version to 1.3.10
Version: stable=1.3.8 (114 days old) => latest=1.3.10 (15 days old)
Installs: stable=299 (73.65%), latest=30 (7.39%), total=406
Click to use developer portal
Click to edit
Do not close this issue manually as a new issue will be created if condition for update still exists.
Please drop a comment if any reason exists which blocks updating to version 1.3.10 at this time.
Note: This is an automatically generated message and not personally authored by bluefox!
@mcm1957 for evidence

This issue seems to be outdated.
This issue suggests to update the stable version of this adapter to 1.3.10 but the current stable version is already 1.3.10.
So this issue should be closed.
@mcm1957 for evidence


Update irmin to the last version of ocaml-git

This is a draft about an update to the new version of git presented on mirage/ocaml-git#395 and the new version of conduit presented on mirage/ocaml-conduit#311 (including patches into mirage/ocaml-cohttp#692). I think the patch is small enough. The CI will fail but locally (with a pin of conduit and cohttp and a simple dune runtest) it's work (believe me).
This is a draft but people can start to comment it if some details are obscures. Currently, the biggest change is about the synchronization where I updated the interface which seems to be much more simpler.

The CI will fail but locally (with a pin of conduit and cohttp and a simple dune runtest) it's work (believe me).

If you want to get the CI to work, you can add pin-depends on specific commits as we're doing here. (Needs to be a commit hash, otherwise OCaml-CI will not accept it.) Also fine to just leave this failing until the upstream changes have been released :shrug:

[ ] clean the PR
[x] CI is happy

Re-updated to the last version of ocaml-git and remove the update to conduit.3.0.0 (useless due to mirage/ocaml-git#428)

Re-updated to the last version of ocaml-git and remove the update to conduit.3.0.0 (useless due to mirage/ocaml-git#428)

Ready to review :+1:., ocaml-git is freezed.

Ready to review :+1:., ocaml-git is freezed.

Thanks for the patch. My main concern is that I would like to avoid mimic to leak in non-git related codebase. It also seems to me that Mimic should be renamed Git_conduit to avoid confusion (as it's a conduit clone only used by ocaml-git).

Thanks for the patch. My main concern is that I would like to avoid mimic to leak in non-git related codebase. It also seems to me that Mimic should be renamed Git_conduit to avoid confusion (as it's a conduit clone only used by ocaml-git).

It also seems to me that Mimic should be renamed Git_conduit to avoid confusion (as it's a conduit clone only used by ocaml-git).

I'm not sure, even if mimic seems specialized to ocaml-git, I move some of my codebase (SMTP and HTTP/AF) with this small library.

It also seems to me that Mimic should be renamed Git_conduit to avoid confusion (as it's a conduit clone only used by ocaml-git).

I'm not sure, even if mimic seems specialized to ocaml-git, I move some of my codebase (SMTP and HTTP/AF) with this small library.

The diff in irmin-http are weird but I can live with that :-)
Could you also add a line in the changelog (and point to https://github.com/mirage/irmin/issues?q=is%3Aissue+is%3Aopen+git+label%3Agit which would probably be fixed :tada:) ? After that I think we are good to merge.

The diff in irmin-http are weird but I can live with that :-)
Could you also add a line in the changelog (and point to https://github.com/mirage/irmin/issues?q=is%3Aissue+is%3Aopen+git+label%3Agit which would probably be fixed :tada:) ? After that I think we are good to merge.

The diff in irmin-http.opam are weird but I can live with that :-) why does irmin-http now depends on Git? I am not sure I am good with this change.

I reverted the patch on irmin-http.opam however, dune-opam-lint still complains about missing dependencies even if I did not updated src/irmin-http/dune or the irmin-unix's codebase (according to the diff). So I don't really understand why such dependencies appears.

The diff in irmin-http.opam are weird but I can live with that :-) why does irmin-http now depends on Git? I am not sure I am good with this change.

I reverted the patch on irmin-http.opam however, dune-opam-lint still complains about missing dependencies even if I did not updated src/irmin-http/dune or the irmin-unix's codebase (according to the diff). So I don't really understand why such dependencies appears.

So my revert seems good. However, I don't think that this PR fixes #914 or #917 (but #1001 is fixed according to a test in ocaml-git). I will add an entry into the Changelog :+1:.

So my revert seems good. However, I don't think that this PR fixes #914 or #917 (but #1001 is fixed according to a test in ocaml-git). I will add an entry into the Changelog :+1:.

According to the release of git.3.0.0 (see ocaml/opam-repository#17950), this PR is ready to merge.

According to the release of git.3.0.0 (see ocaml/opam-repository#17950), this PR is ready to merge.

Can you fix dune build @fmt to make the CI happy?

Can you fix dune build @fmt to make the CI happy?

It's done :+1:.

It's done :+1:.

LGTM, thanks!

LGTM, thanks!


[tx gen protocol] Non-uniqueness of subfulfillments: is this a problem?

Potential Problem (?)
A threshold condition being fulfilled may contain multiple Ed25519 subconditions attached to the same public key.
By providing one subfulfillment, a user would implicitly also provide the subfulfillments to all the other subconditions that belong to the same public key.
How much of a problem can this be?
Resolution of #1930 will ensure that a fulfillment message is unique for a given input, but not unique for the subfulfillments of a threshold condition.
In the case of very complex threshold conditions, one should be  aware, at the very least, that by providing a (sub)fulfillment, it can be re-used ("replayed") for other (sub)conditions belonging to the same key.
Although it is not clear whether a real world scenario could be thought of in which this would turn out to be problematic, this perhaps potential problem could be prevented by choosing unique messages for each signature-based (sub)fulfilment. From the point of view of the digital circuit modeling of a crypto-condition one could perhaps attempt to use "digital gate" unique identifiers. It is not clear whether this is possible at the moment though. Conditions and fulfillments do have a cost which is used to sort subconditions and subfulfillments in a threshold condition, but that would probably not be enough to establish uniqueness as two subfulfillments could very well have the same cost.

It seems this issue is more complicated than issue #1930 first imagined, so its resolution requires more careful thinking and consideration of alternatives.
Moreover, this issue (and issue #1930) do not affect Tendermint integration, so they could be put off until after that is done.
One alternative resolution would be to add a new transaction validation rule of the form:
If this is a TRANSFER transaction: Create a list (not a set) of all the public keys in all the output conditions referenced by all the inputs in this transaction. If there is are any duplicated keys in that list, then this transaction is invalid.
That wouldn't require making up a different thing-to-be-signed for each sub-fulfillment. It also wouldn't impose any great hardship on users. They could either have a wallet full of different keypairs, and they could refrain from building overly-complicated TRANSFER transactions with lots of inputs.
I propose that we defer resolving this issue and issue #1930 until after we've integrated Tendermint. There are other edge-case transaction model security issues to resolve as well (e.g. issues #677 and #728).

There are other edge-case transaction model security issues to resolve as well (e.g. issues #677 and #728).

These are very different issues. I do not see the benefit of bundling them with this issue.

I propose that we defer resolving this issue and issue #1930 until after we've integrated Tendermint.

I suggest we treat #1930 separately from this issue.
The two issues are quite different in many ways. This issue is concerned with one input only, for which a complex threshold condition would be fulfilled, and would involve two or more identical subfulfillments if the message is the same for the entire threshold fulfillment. In some ways it could even potentially be considered to be a crypto-conditions specific problem (at least partially) not a bigchaindb transaction problem. For instance, in cryptoconditions the validation of a fulfillment (simple or compound, as in ed25519 or threshold) requires one message (https://github.com/bigchaindb/cryptoconditions/blob/master/cryptoconditions/init.py#L26-L27):
def validate_fulfillment(serialized_fulfillment, serialized_condition, message=None):
    # ....

Perhaps this could be addressed by using prefix conditions.
In any case, this problem is quite different from #1930 despite some apparent similarities. I consequently think we should keep both separate.


In all Release pipelines, Azure resources not auto populating after selecting the Azure Pass sponsorship.

Contact Details
<EMAIL_ADDRESS>What happened?
In All release pipelines, after we select the Azure Pass Sponsorship, the azure resources deployed for release are not auto populating.
Various participants including I (MCT), encountered the same issue multiple times.
Screenshots attached
Thanks
Lab
Lab 08 Controlling Deployments using Release Gates
Relevant screenshots

Do you want to help us? 👏

[ ] Create a Pull Request by following this project's Contribution Guide

That's common to happen to me too. My advice is just to type the name of the webapp on the combo box, and follow the rest of the instructions. It will work. If you wait for a long time, it will start to show on the box. I never had time to measure the exact time, but i tried to reset the cache, auth tokens etc.. and nothing seems to work. Would love to see if other MCTs have some other ideas. @petender any idea on this?

How silly as it seems, I've seen this related to screen resolution or how much "space" the graphical section to the right has. It seems to be related to the Javascript engine that's building the ADO web pages. If you try to make that GUI column to the right a bit wider, it seems to be fixed most of the time... Not a solid solution, just sharing what does it for me. FYI, it's not related to AzurePass, have seen the same on Corp subscriptions or Trial ones. (Same comes up with some other labs like the Canary/Prod and Keyvault lists that need to populate)

I will try that next time @petender ! Great tip. Never thought about that. I have an 4k 28'' screen and never had the issue, that might be the reason. Still silly for that to happen but it's what it is.

As mentioned in the thread, my experience has been the same, no matter the susbcription type used. Either try typing the resource or play with bigger resolutions. We need to close the issue, as it is not related to the lab instructions, it is a general issue related to Azure DevOps. You can report it at: https://developercommunity.visualstudio.com/report?space=21&entry=problem


Is there an existing issue for this?

[X] I have searched the existing issues.

Which plugins are affected?
Crashlytics
Which platforms are affected?
iOS
Description
Getting this issue while run my project on iPhone 16 Pro.
Reproducing the issue
Run Flutter build command for iOS
Get the error
Firebase Core version
3.5.0
Flutter Version
3.24.3
Relevant Log Output
Failed to build iOS app
Lexical or Preprocessor Issue (Xcode): Include of non-modular header inside framework module 'firebase_crashlytics.Crashlytics_Platform': '/Users/Desktop/Code/ios/Pods/Headers/Public/Firebase/Firebase.h'
/Users/.pub-cache/hosted/pub.dev/firebase_crashlytics-4.1.2/ios/Classes/Crashlytics_Platform.h:20:8

Lexical or Preprocessor Issue (Xcode): Include of non-modular header inside framework module 'firebase_crashlytics.ExceptionModel_Platform': '/Users/Desktop/Code/ios/Pods/Headers/Public/Firebase/Firebase.h'
/Users/.pub-cache/hosted/pub.dev/firebase_crashlytics-4.1.2/ios/Classes/ExceptionModel_Platform.h:20:8

Could not build the application for the simulator.
Error launching application on iPhone 16 Pro.

Flutter dependencies

Expand Flutter dependencies snippet

Replace this line with the contents of your `flutter pub deps -- --style=compact`.

Additional context and comments
No response

Duplicate of: 13323


Early Stopping for HParam Optimization when model is not converging

I'm running the run_hparam_optimization.sh in the MOABB benchmarks using a variation of EEGNet that I developed (for the BNCI2014001 dataset).
Often the hyperparameters chosen by orion lead to a model which does not converge, and which has an accuracy which is no better than random guessing. However, the program still runs through all the epochs even though it is obviously not converging.
Is there a way to prevent this with the currently available options (other than changing changing the orion flags to adjust the search space)? If not is this a feature that might be useful to add?

Ok, thanks! I will look into adjusting the search space.

I just wanted to follow up and say that it did end up being a small bug in the model. Once fixed, the hyper parameter optimization started working great, and appears to be showing some positive results so far. I look forward to sharing the results once the experiment is complete!


Thread Sanitizer found Data Race in GDTCCTUploadOperation.m:508 in -[GDTCCTUploadOperation finishOperation]

Hello everyone, I am in the process of uploading my app to the app store and there are some bugs that are not caught in the simulator but when I upload my archived version the apple testers say that it crashes after logging in.
After a deeper look into my code, I noticed that there is a race condition related to some Google code for firebase dependencies.
I could really use some help interpreting what is going on here. I have tried many things to synchronize my code and everything seems to be working perfectly in the simulator.
I don't know if this race condition is the error that is preventing my app from being approved, but I still want to understand what is going on.

Thanks for reporting, @Jange1l. It seems like the issue you encountered is related here #7771.

The should be fixed in GoogleDataTransport 8.3.1. Please try to update and let us know if you still have the issue.


Remove unnecessary intermediate variables

In #84445 we've identified a few intermediate variables that are unnecessary. This PR cleans up the code accordingly.

I agree with @Riteo. Cases where it's just used once can be simplified, but others are probably fine (didn't read everything, but things like received_event clearly improve readability and aren't useless).

Renaming would be fine too. Also cases where it just drops p_ are fine to remove as well.

I agree with @KoBeWi and given our differing opinions and the short time I'll be able to dedicate, I don't think I'll be able to properly provide changes we all agree with. For those reasons I'm closing this PR.


Fix qpu decorator not to override the original function name and doc

Without functools.wraps, the name and the doc of a function to be decorated will be lost.  This PR fixes that.
Example code:
#!/usr/bin/env python3

from videocore.assembler import qpu

@qpu
def qpu_code(asm):
    nop()
    exit(interrupt = True)

print(qpu_code.__name__)

Before the change in this PR, the code prints decorated, which is the name of the decorator.  After the change, the output will be qpu_code, which is desired.

Thanks!

Thanks for merging!


Any plans to upstream your fork of Pluto?

The main added functionality of notebook exclusive cells will become very easy to implement when this pr is merged (which should happen relatively soon).
I still have some minor quirks in my own pluto fork for my own convenience that won't probably be accepted as PR, but the notebook exclusive cells should be possible

Since the PR has merged, any update on getting this to run on normal Pluto :)

I'll try to adapt the code to the new metadata in the next days and submit a PR to Pluto :).
It'll probably take a while to get polished and approved while there though.

Draft PR created:
https://github.com/fonsp/Pluto.jl/pull/2018

https://github.com/fonsp/Pluto.jl/pull/2018 has been merged, so I am going to close this issue!


chore: bdd-nh-1587813777 to 0.0.1

chore: Promote bdd-nh-1587813777 to version 0.0.1

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment