iOS not showing renewals when calling GetPurchasesAsync()

InAppBilling Plugin Version: 5.6.1
Xamarin Forms Version: <IP_ADDRESS>5
OS Concerned: iOS
For renewals on iOS, against the Sandbox environment, I am receiving the same Transaction Id (original transaction) for each receipt after calling GetPurchasesAsync() within the App.
I have ensured that I am calling FinalizePurchase on the original purchase and I am quite sure the iOS subscription is set up correctly as it is showing under Auto-Renewing subscriptions in iTunes Connect.
Source
I found this in the inappbilling source code:
	foreach (var trans in SKPaymentQueue.DefaultQueue.Transactions)
	{
		var original = FindOriginalTransaction(trans);
		if (original == null)
			continue;

		allTransactions.Add(original);
	}

It seems as though it only ever adds the original transaction and not renewals. Please, could this be investigated?
Many Thanks.

Hi There,
I was wondering if there was an update on this issue?
Any info on this would be much appreciated.
Many Thanks.

@sachinkanadia did you find any solution? i am having the same problem.

@mbilalbenli No. With a workaround, I will have to go live with this issue in InAppBilling.
The workaround will avoid comparing and checking the TransactionId within my verification code for iOS.

Here is what I do:
 var subs = await CrossInAppBilling.Current.GetPurchasesAsync(ItemType.Subscription);

                if (subs?.Any(p => p.ProductId == productIdSub) ?? false)
                {
                    var sorted = subs.Where(p => p.ProductId == productIdSub).OrderByDescending(i => i.TransactionDateUtc).ToList();
                    var recentSub = sorted[0];
                    if (recentSub != null)
                    {
                        if (DeviceInfo.Platform == DevicePlatform.Android)
                        {
                            foundStuff = true;
                            Settings.HasTippedSub = true;
                            Settings.CheckSubStatus = true;

                            //loop through transactions and keep adding a month until valid
                            var date = recentSub.TransactionDateUtc;
                            while (date < DateTime.UtcNow)
                                date = date.AddMonths(1);

                            Settings.SubExpirationDate = date.AddDays(5);

                            SetPro();
                        }
                        else
                        {
                            if (recentSub.TransactionDateUtc.AddSubTime() > DateTime.UtcNow)
                            {
                                foundStuff = true;
                                Settings.HasTippedSub = true;
                                Settings.CheckSubStatus = true;
                                Settings.SubExpirationDate = recentSub.TransactionDateUtc.AddSubTime();
                                OnPropertyChanged(nameof(SubPrice));
                                SetPro();
                            }
                        }

                        if (DeviceInfo.Platform == DevicePlatform.Android && !recentSub.IsAcknowledged)
                        {

                            try
                            {
                                await CrossInAppBilling.Current.AcknowledgePurchaseAsync(recentSub.PurchaseToken);
                            }
                            catch (Exception ex)
                            {
                                Logger.AppendLine("Unable to acknowledge purcahse: " + ex);
                            }
                        }
                    }
                }

You don't need to compare transactionids... just the productids

Hi James,
I am expecting the most recent transaction on iOS to be the renewal, not the original transaction as per the documentation here.
I need this working otherwise this/your line of code will not work as its always returning the original transaction:
if (recentSub.TransactionDateUtc.AddSubTime() > DateTime.UtcNow)
Can we acknowledge that this is a defect and when the fix will go in?

Hi James,
This defect is an easy fix however, it currently renders the InAppBilling Plugin broken on iOS.
Please could you provide the rationale as to why you're deciding to overlook this matter?

@sachinkanadia I'm experiencing the same/similar problem. I've purchased an auto-renewing subscription, but am not seeing any expiry/renewal data in the purchases being returned.
How did you work around this? I need to know what the status of the current/latest subscription is, along with its expiry/renewal date.


Table and

Follow-up questions:

Do you have an example of Tables and Row class usage? i.e. create_table() Will is be implemented like Pine Code in TV where you create a Table object and subsequently add row object to it?
Do you have an example of how to plot two times series on the same plot using subchart?  i.e. create_subchart()

Many thanks.  I will send donation your way after this week,
Example Pine Code:
var tbl = table.new(position.top_left, 4, 40, frame_color=#151715, frame_width=1, border_width=2, border_color=color.new(color.white, 95))
if barstate.islast
table.cell(tbl, 0, 0, text = " Long>>>                  VWAP AA Scanner                  <<<Short ", bgcolor = color.new(color.black, 85), text_color = #1fbaee)
table.merge_cells(tbl, 0, 0, 8, 0)
table.cell(tbl, 0, 1, '-DMI',  width = col_width,     text_halign = text.align_center, bgcolor = color.new(color.black, 85), text_color =#1fbaee, text_size = size.normal)
table.cell(tbl, 1, 1, '-3SD',  width = col_width,     text_halign = text.align_center, bgcolor = color.new(color.black, 85), text_color =#1fbaee, text_size = size.normal)
table.cell(tbl, 2, 1, '-2SD',  width = col_width,     text_halign = text.align_center, bgcolor = color.new(color.black, 85), text_color =#1fbaee, text_size = size.normal)

Ah, ok.  I think I figured out the 'create_table()' mechanics to generate a floating TV-styled table.
But I could probably benefit most from a create_subchart() example.  Appreciate any thoughts.
Example create_table() functional call:
if name == "main":
chart = Chart(toolbox=True)
chart.legend(True)
chart.events.search += on_search
chart.events.search += on_tick
chart.topbar.textbox("symbol", "SPY")
chart.topbar.switcher(
"timeframe",
("1mn", "15mn", "1hr", "4hr"),
default="1mn",
func=on_timeframe_selection,
)
df = get_bar_data("SPY", "1mn")
table = chart.create_table(
    width=800,
    height=200,
    headings=["Time", "Open", "High", "Low", "Close", "Volume"],
    position="right",
    draggable=True,
)

# Update the table with the initial data
for _, row in df.tail(10).iterrows():
    table.new_row(
        row["time"],
        row["open"],
        row["high"],
        row["low"],
        row["close"],
        row["volume"],
    )

table.visible(visible=True)

# subchart = chart.create_subchart(position="bottom", sync=True)

chart.set(df)
chart.show(block=True)

Read here for the subchart examples.
Louis

Perfect.  Crystal clear. This is a really complete port from JS.  I love the clarity and options you provided.  Any more complex builds are still possible from the JS function option.  Thank you and really appreciate your hardwork!!!


Accidentally committed to Master

On Low Resolution Screens, if Apply With Linkedin was active, users were unable to submit their resume.
Additions

Added a button to the detail card on the right side for Applying with Linkedin

Removals

Removed the Apply with Linkedin Button.

Testing

Tested on IE, Edge, Firefox, Chromium, Chrome, and Opera

Review

zzz

Screenshots
Before

After

Notes

May want to have the div for the message about retrying the apply with LinkedIn integration to shine through.  Needs work.     You can Test at charlesabarnes.com/Career

Checklist

[ x ] Changes are limited to a single goal (no scope creep)
[ x ] Code can be automatically merged (no conflicts)
[ x ] Code follows the standards laid out in the contributing guide
[ x ] Passes all existing automated tests
[ x ] New functions include new tests
[ x ] New functions are documented (with a description, list of inputs, and expected output)
[ x ] Placeholder code is flagged
[ x ] Visually tested in supported browsers and devices

Also tested on mobile, will need to test with functional Apply with LinkedIn API key

Remember to change Apps.json back and clean up the code


Unable to download file on IOS

Please find above image in which added scenario.

Hi,
If I get it correctly from the screenshot, the issue is not related to the plugin itself. It looks like the server responds with an error code 406 when the user tries to download the file. So the issue is either on the server side or probably the download request is malformed somehow.
Try downloading a file from an independent 3rd-party server (e.g. httpbin.org) and see if the problem persists or not.

Feel free to reopen the issue if you can provide more detailed description and after ensuring that the problem is in the plugin itself, not in the server configuration or client-side download implementation.


Example UI: event section

Let's keep expanding the Example UI with more examples.
In this case, show how the Event hooks (useScaffoldEventHistory.ts && useScaffoldEventSubscriber ) work. Right now it's just a console.log in ContractData.tsx
In example-ui.tsx we can add a new component <ContractEvents>, that show in two columns: Event History (history hook) / New Event (subscriber hook) info about the events from the contract: Address (so we can showcase the <Address> component) + Greeting + Value
We can ask Andrea if we need some help with the design

Hey @carletex ! Could you ask Andrea for designs, please?

Hey @carletex any update yet?

Should we close since #576 ?


Fix: Sort out Travis configuration

This PR

[x] moves commands to more appropriate sections
[x] sorts sections by order in which they are executed on Travis

Thank you! Sorry for not having been faster.

No worries, @evert, we all have more important things in our lives. 👍


wixEvents.queryEventsV2 is not a function

I am getting the following error and I am struggling to find the solution in the SDK documentation
TypeError: wixClient.wixEvents.queryEventsV2 is not a function
at Home (webpack-internal:///(rsc)/./app/page.tsx:26:45)
Has anyone come across this? Any pointers please?
Thanks

Hey @avoirsolutions,
Are you getting the error after cloning this repo? Or is that on a different project?
I just cloned the repo and ran it locally, and I'm not an error. Can you add more information on how to reproduce?

Hi @netanelgilad
I cloned the repo and it runs fine but I can't get my events to display locally even after creating a Wix Headless project with Stores and Events app,  and an OAuth app (which I used for my NEXT_PUBLIC_WIX_CLIENT_ID in my env.local).
To try to find out why I couldn't see any events when loading my home page, I added a "console.log(e);" under the catch on the page.tsx as below:
let events: wixEvents.Event[] = [];
try {
events = (
await wixClient.wixEvents.queryEventsV2({
fieldset: [
wixEvents.EventFieldset.FULL,
wixEvents.EventFieldset.DETAILS,
],
query: {
paging: { limit: 10, offset: 0 },
sort: [{ fieldName: 'start', order: wixEvents.SortOrder.ASC }],
},
})
).events!;
} catch (e) {
console.log(e);
}
return (

);
The error message in the terminal is:
"TypeError: wixClient.wixEvents.queryEventsV2 is not a function
at Home (webpack-internal:///(rsc)/./app/page.tsx:28:45)
at process.processTicksAndRejections (node:internal/process/task_queues:95:5)"
Any advice welcome.
Thanks

Did you install the repository with npm? try using yarn which should use the yarn.lock in the repository.
There's an issue with the latest version of @wix/events package, and I'm taking it internally to check what's the cause, but for now, the repo should work when using the locked versions in the yarn.lock.

Just a quick update to confirm that it now works and my events load on the home page. Those are the steps I took (I use Visual Studio Code btw):

cloned repository again in a new folder
npm install --global yarn
yarn install
yarn dev

the only difference from what I did before is step 2.
Thanks again @netanelgilad


TypeError: undefined is not an object (evaluating 'RNOneSignal.configure')

I see an  error in my logcat when I add the example code in the my componentWillMount:
    componentWillMount() {
        OneSignal.addEventListener('received', this.onReceived);
        OneSignal.addEventListener('opened', this.onOpened);
        OneSignal.addEventListener('registered', this.onRegistered);
       OneSignal.addEventListener('ids', this.onIds);
    }

W/ReactNativeJS( 1647): 'Error: ', [ { [TypeError: undefined is not an object (evaluating 'RNOneSignal.configure')]
W/ReactNativeJS( 1647):     line: 54715,
W/ReactNativeJS( 1647):     column: 24,
W/ReactNativeJS( 1647):     sourceURL: 'http://<IP_ADDRESS>:8081/index.android.bundle?platform=android&dev=true&hot=false&minify=false' } ]

I am using React Native 0.42 and react-native-one-signal version 3.0.4. I have also run the react-native link command.
Is there any other step that I may have missed to initialize the OneSignal object?
Thanks.

It was happening because I didn't add the native module to the createAdditionalReactPackages() method in MainApplication.java.


on load

[05:55:42.330] [Server thread/CRITICAL]: InvalidArgumentException: "Commands must have a permission set" (EXCEPTION) in "pmsrc/src/command/SimpleCommandMap" at line 143
--- Stack trace ---
#0 plugins/KDR2_dev-25.phar/src/Aboshxm2/KDR2/Main(66): pocketmine\command\SimpleCommandMap->register(string[4] KDR2, object Aboshxm2\KDR2\commands\KDRCommand#60470)
#1 pmsrc/src/plugin/PluginBase(118): Aboshxm2\KDR2\Main->onEnable()
#2 pmsrc/src/plugin/PluginManager(454): pocketmine\plugin\PluginBase->onEnableStateChange(true)
#3 pmsrc/src/Server(1388): pocketmine\plugin\PluginManager->enablePlugin(object Aboshxm2\KDR2\Main#40800)
#4 pmsrc/src/Server(1032): pocketmine\Server->enablePlugins(object pocketmine\plugin\PluginEnableOrder#40743)
#5 pmsrc/src/PocketMine(334): pocketmine\Server->__construct(object pocketmine\thread\ThreadSafeClassLoader#3, object pocketmine\utils\MainLogger#6, string[37] /portal2elysium/minecraft/kitpvplive/, string[45] /portal2elysium/minecraft/kitpvplive/plugins/)
#6 pmsrc/src/PocketMine(357): pocketmine\server()
#7 pmsrc(11): require(string[81] phar:///portal2elysium/minecraft/kitpvplive/PocketMine-MP.phar/src/PocketMine.ph)
--- End of exception information ---
[05:55:42.330] [Server thread/EMERGENCY]: An unrecoverable error has occurred and the server has crashed. Creating a crash dump
[05:55:42.337] [Server thread/EMERGENCY]: Please upload the "/portal2elysium/minecraft/kitpvplive/crashdumps/Tue_Jul_4-05.55.42-UTC_2023.log" file to the Crash Archive and submit the link to the Bug Reporting page. Give as much info as you can.
[05:55:42.834] [Server thread/EMERGENCY]: The crash dump has been automatically submitted to the Crash Archive. You can view it on https://crash.pmmp.io/view/8913093 or use the ID #8913093.
[05:55:42.835] [Server thread/EMERGENCY]: Forcing server shutdown

Thank you for reporting this issue to me, I'm currently working on it.

https://github.com/Aboshxm2/KDR2/commit/a849b1e7290da1f035105d223a45bae031de4370


Replaced Travis CI with Github Actions

One test is still failing on PHP 8.
PR http-interop/http-factory-tests#46 is the answer.

@t0mmy742 we should fix this warning:
There was 1 warning:

1) Slim\Tests\Psr7\UploadedFileTest::testMoveToStream
assertFileNotExists() is deprecated and will be removed in PHPUnit 10. Refactor your code to use assertFileDoesNotExist() instead.

@l0gicgate assertFileDoesNotExist function does not exist on PHPUnit 8, only with PHPUnit 9. PHPUnit 9 only support PHP >= 7.3.
We need to live with this warning, or we can drop PHP 7.2 support for all slimphp repositories (PHP 7.2 support ended 11 days ago)

@t0mmy742 I guess we'll have to live with this warning. I would like to keep PHP 7.2 support until the next major release if possible.


use varargs instead of string arrays

Pull Request
What does this PR do?
it replaces String[] arguments with varargs (String ... foo). It simplifies method calls and it should be backwards compatible.
NOTE:
This pull requests only changes method signature, additional validation should be added in places where at least one value is needed.

@singlyfy thanks for the PR
Can you fix the tests (integration/unit tests)? cf the CI
Also, is this PR breaking for the users? I really ask, I don't necessarily refuse breaking PRs since the library is not stable yet, if it improves the user experience.
I'm not a Java developer, that's why I ask.

String[] arguments with varargs (String ... foo)

The change should not be breaking @curquiza I tried this sample:
import java.util.Arrays;

public class MyClass {
    public static void main(String args[]) {
      opa("opa", "123");
      opa(new String[] {"opa","data"});
    }

    public static void opa(String... arg) {
        System.out.println(Arrays.toString(arg));
    }
}

and compiled + execute nicely!

Thank you @brunoocasali
Still needs @singlyfy to fix the tests and we are good

Closing for lack of activity


Update GitHub actions to Node 20

Node 16 has reached end of life. GitHub is planning to migrate all actions to Node 20 by Spring 2024.
https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/

Thanks! This should now be taken care of.


Determine plural label based on locale

Some languages do not have a "plural rule",
this PR improves how developers write code
before this PR:
class ProductResource extends Resource
{
    protected static ?string $label = 'Produk';
    protected static ?string $pluralLabel = 'Produk';
    ...
}

after this PR:
class ProductResource extends Resource
{
    protected static ?string $label = 'Produk';
    ...
}

those codes will produce the same output in a language that does not have a "plural rule",
in a language with "plural rule", everything will work as usually

How do you determine whether a locale has plural or not?
Several languages do have plural forms: English, Skandinavian, Slavian, Latin ...

Laravel has a built-in method to check the pluralization index.
This PR makes use of that method to determine whether a locale has a plural or not

Just got around to reviewing this. Thanks!


Add library functions to numpy.pxd

numpy.pxd is incomplete
Migrated from http://trac.cython.org/ticket/339

The NumPy declarations are better maintained in the NumPy project.


Case convertion

Add support to specify case types for the following:

snake_case
SCREAMING_SNAKE_CASE
camelCase
PascalCase
dash-case

Added on v1.2.0.
Requires to have Case Conversion plugin preinstalled, to use the following:

snake_case
SCREAMING_SNAKE_CASE
camelCase
PascalCase


Bad locator detection

We've had a few bad locators/selectors sneak into our code and it would be great if we could provide a linting rule to detect them.
Examples.

nth
.nth()
.first()

More https://www.checklyhq.com/learn/headless/basics-selectors/#examples-of-bad-selectors

@unlikelyzero I'm not sure I understand the issue.  What's wrong with nth and first?  I totally agree that you don't want to over depend on them, but I'm also not sure a rule to prevent them is the right option.

It would be nice to add an additional rule for methods .first(), .last(), .nth().
As Playwright's documentation states they are not recommended:

You can explicitly opt-out from strictness check by telling Playwright which element to use when multiple elements match, through locator.first(), locator.last(), and locator.nth(). These methods are not recommended because when your page changes, Playwright may click on an element you did not intend.

And it would be nice to set a warning for using them.


Release spark metadata client

close #3924
Updated release notes for version 0.2.1, bump the version in build file.

Checkout from the wrong branch


🐞 secrets created inside module constructor fail on repeated accesses

What is the issue?
Reported by @Vincent in discord, with a lovely repro.

I've been getting weird errors when creating secrets inside a module's constructor and trying to use them later on.
The actual use case is exchanging OIDC tokens for a token authenticating to a service, which I then need to use later on.
Here is a reproduction example:

Dagger version
unclear, 11/12/2024
Steps to reproduce
I have a module that generates and stores a secret on initialization:
package main

import (
    "context"

    "dagger/generator/internal/dagger"
)

type Generator struct {
    // +private
    Password *dagger.Secret
}

func New() *Generator {
    return &Generator{
        Password: dag.SetSecret("pass", "admin"),
    }
}

func (m *Generator) Gen(ctx context.Context, name string) error {
    _, err := m.Password.Plaintext(ctx)
    return err
}

I have a second module that depends on the first one and wraps calls to it like so:
package main
import (
    "context"
)

type Keychain struct{}

func (m *Keychain) Get(ctx context.Context, name string) error {
    return dag.Generator().Gen(ctx, name)
}

Finally, I use the second module from a contextual module:
package main

import (
    "context"
    "fmt"
)

type Mymodule struct{}

func (m *Mymodule) Issue(ctx context.Context) error {
    kc := dag.Keychain()

    err := kc.Get(ctx, "a")
    if err != nil {
        return fmt.Errorf("first get: %w", err)
    }

    err = kc.Get(ctx, "b")
    if err != nil {
        return fmt.Errorf("second get: %w", err)
    }
    return nil
}

The first call to kc.Get is succesful.
However, the second one fails with the log output below.
Log output
dagger call -m mymodule issue
✔ connect 0.3s
✔ initialize 0.5s
✔ prepare 0.0s
✔ mymodule: Mymodule! 0.0s
✘ Mymodule.issue: Void 0.7s
! call function "Issue": process "/runtime" did not complete successfully: exit code: 2
┃ invoke: second get: input: keychain.get resolve: call function "Get": process "/runtime" did not complete successfully: exit code: 2
┃
┃ Stdout:
┃ invoke: input: generator.gen resolve: call function "Gen": process "/runtime" did not complete successfully: exit code: 2
┃
┃ Stdout:
┃ get parent name: input: get or init client: initialize client: failed to add client resources from ID: failed to add secret from source client byn8ttu7ly3h7zul71p7ncibf: secret xxh3:cf46d07f3c9661af not found in other store
  ✔ Keychain.get(name: "a"): Void 0.4s
  ✘ Keychain.get(name: "b"): Void 0.2s
  ! call function "Get": process "/runtime" did not complete successfully: exit code: 2
  ┃ invoke: input: generator.gen resolve: call function "Gen": process "/runtime" did not complete successfully: exit code: 2
  ┃
  ┃ Stdout:
  ┃ get parent name: input: get or init client: initialize client: failed to add client resources from ID: failed to add secret from source client byn8ttu7ly3h7zul71p7ncibf: secret xxh3:cf46d07f3c9661af not found in other store
    ✘ Generator.gen(name: "b"): Void 0.1s
    ! call function "Gen": process "/runtime" did not complete successfully: exit code: 2
    ┃ get parent name: input: get or init client: initialize client: failed to add client resources from ID: failed to add secret from source client byn8ttu7ly3h7zul71p7ncibf: secret xxh3:cf46d07f3c9661af not found in other store

Setup tracing at https://dagger.cloud/traces/setup. To hide: export STOPIT=1

Error: response from query: input: mymodule.issue resolve: call function "Issue": process "/runtime" did not complete successfully: exit code: 2

Stdout:
invoke: second get: input: keychain.get resolve: call function "Get": process "/runtime" did not complete successfully: exit code: 2

Stdout:
invoke: input: generator.gen resolve: call function "Gen": process "/runtime" did not complete successfully: exit code: 2

Stdout:
get parent name: input: get or init client: initialize client: failed to add client resources from ID: failed to add secret from source client byn8ttu7ly3h7zul71p7ncibf: secret xxh3:cf46d07f3c9661af not found in other store

Potentially related:

https://github.com/dagger/dagger/pull/8149
https://github.com/dagger/dagger/pull/8358


Fix typo in operator check in raxCompare

The raxCompare is using the following code to check for the valid
operators:
if (op[0] == '=' || op[1] == '=') eq = 1;
if (op[1] == '>') gt = 1;
else if (op[1] == '<') lt = 1;
else if (op[1] != '=') return 0; /* Syntax error. */

This code does not behave as expected for the operators ">=", ">"
(where we want to set gt to one) and "<=", "<" (where we want to
set lt to one) due to a typo in the if conditions. The fixed condition
should be the following to obtain the expected behaviour
if (op[0] == '=' || op[1] == '=') eq = 1;
if (op[0] == '>') gt = 1;
else if (op[0] == '<') lt = 1;
else if (op[1] != '=') return 0; /* Syntax error. */

Thanks @symc, the problem was also identified (more recently) by @QuChen88. I'm merging this one because @QuChen88 reported it later and in the Redis repository, and because here there is regression testing, but I say thank you to both for this fix!


DOM manipulation removal

Summary
Remove most of the existing bad DOM Manipulation code in the codebase and replace it with event handling per issue #10. This will make it much easier in the future to see and change how data flows between components.

[x] Removed almost all instances of document.getElementByID or .innerHTML that grabs and manipulates data poorly, especially in opening/closing modals
[x] Removed almost all $parent references.
[x] Removed other outdated/duplicated code and comments (2 <semester>s, NewCustomCourse.vue, etc.)
[ ] Fixed the new bug making the backdrop on the add course modal gray
[ ] Refactored the add course modal to avoid using DOM Manipulation in Modal.vue, NewCourse.vue, and OnboardingTransfer.vue (waiting for @hahnbeelee's work to be finished before messing around with this file, will take significant more work than these other elements, see Monday)
[ ] Refactored the direction of the triple dot menu on semesters (still need a better solution for this, see Monday)
[ ] Refactored createCourse so it is not called with $parent (@SamChou19815 do you want to take this?)

Test Plan
Ensure that everything works on the site compared to master (https://cornelldti-courseplan-dev.web.app/) with the exception of clicking outside of modals closing them.
Check if all of the following modals can be opened, closed, and used as expected

Add Course
New Semester
Edit Semester
Delete Semester

Notes
The rest of the DOM Manipulation should be removed so it is not duplicated in the future like it has been since CoursePlan started.
Breaking Changes
As specified above, just clicking outside of modals.

@willespencer when do you think it will be ready? I might want to touch some of the files soon.

@willespencer I think it's better for this PR to stop here. It's already start to get big and is blocking some other refactors I plan to do.


please try to scrap that  https://www.mgstage.com  . because   the prestige and msg left  r18 and javlibrary

Expected Behavior
add new  new jav database s website . they have something that javlibrary , dmm  , r18  dont have  it
Current Behavior

Steps to Reproduce (for bugs)
Your Environment
new version

Module version used:
update
Operating System and PowerShell version:
win 10  and up to date powershell

There is already a scraper for mgstage.
Use setting "scraper.movie.mgstageja": true and add mgstageja to your metadata priority settings.

OHH.. Thank you so much.
can i ask you anothee question ?
i read the  topic   https://docs.jvlflame.net/configuration/output-folder-structure
i dont understand it but i think its about  i can do some sort folder  with my designing .
hmm.. the other question come in
i  want to create folder like this
actress/the  studio that create movie / id of the movies.
what is the command line that i need to  put in the powershell
thank you so much

i want to create folder like this
actress/the studio that create movie / id of the movies.

You can use these settings to get that folder format. Movies with multiple actresses will be grouped into a @Group folder.
"sort.format.outputfolder": ["<ACTORS>", "<STUDIO>"]
"sort.format.folder": "<ID>"

thank you so much


failing test for jsx-indent without parens

Starting in 6.4.0 I got some new errors from jsx-indent in some of my projects.
Here's a simple example that I added as a failing test:
{head.title &&

    {head.title}

}

I could wrap the
 with parens and then it works (I added a test for that also), but I'm wondering if it could be made to pass without parens. Or there's probably a good reason why it shouldn't pass that I'm missing 😄 . If this should be ok, I'd be more than willing to work on a fix for this.

Hi, thanks for the failing test, it was a big help 😃
The jsx-indent rule was previously asking you to indent like this but everyone was not really happy with this behavior. If you follow the discussion in #540 you'll see that there is not really a "right" way to indent this case.
I fixed the problem in https://github.com/yannickcr/eslint-plugin-react/commit/963267ad9108c46c76818f28003315a7bf24d589 but accidentally disallowed this style at the same time 😞
I made a fix https://github.com/yannickcr/eslint-plugin-react/commit/cc84a4629a19d49700dfae74757a4ac5263580a9 and it should now allow the following cases:
// No parens, same indentation
{
  head.title &&

    {head.title}

}

// No parens, one indentation deeper
{
  head.title &&

      {head.title}

}

// Parens, same indentation
{
  head.title && (

    {head.title}

)
}

// Parens, one indentation deeper
{
  head.title && (

      {head.title}

  )
}

I'll publish v6.4.1 with the fix shortly.

@yannickcr does it allow all those at once, or can i force one? For my codebases I'd want to force only the last option

@ljharb it allow all those at once. I tried to be pretty flexible on this since ESLint is pretty loose on LogicalExpression too. But I am not against adding an option to enforce one style in particular.

Awesome, I'd love to add that option :-)


⚠ Fox Sports has degraded performance

In b3c9507, Fox Sports (https://foxsports.com) experienced degraded performance:

HTTP code: 200
Response time: 1961 ms

Resolved: Fox Sports performance has improved in de2c41e.


HLSL Sample

Describe the bug
Currently the HLSL texture Sample page is not rendering properly. I was going to file an issue about this but it someone found the issue an has set up a PR: MicrosoftDocs/win32#405.
However I also noticed that some of the other sample page variants list the return type as DXGI_FORMAT and I was going to file a bug for that until I noticed #1353 which fixed this on the base page a long time ago, but didn't fix it on the variants.
Since those variants are only effectively additional optional arguments and not completely different overloads maybe those pages could be combined to simplify things?
To Reproduce
Steps to reproduce the behavior:

Go to HLSL Texture2D::Sample methods page
Compare the first base overload with (S,float,int) parameters (when fixed) to the (S,float,int,float) variant
In the first overload the return value is listed as The texture's template type, which may be a single- or multi-component vector. whereas in the second it's The texture format, which is one of the typed values listed in DXGI_FORMAT..

Expected behavior
All overloads should have the same return type, which is not a DXGI_FORMAT enum value.
Desktop:

OS: Windows 7 SP1 x64
Browser: Firefox
Version: 77

@baldurk Is this issue fixed?


Loading CSV exported dataset has unexpected format

Describe the bug
I wanted to be able to save a HF dataset for translations and load it again in another script, but I'm a bit confused with the documentation and the result I've got so I'm opening this issue to ask if this behavior is as expected.
Steps to reproduce the bug
The documentation I've mainly consulted is https://huggingface.co/docs/datasets/v2.16.1/en/package_reference/loading_methods#datasets.load_dataset and https://huggingface.co/docs/datasets/package_reference/main_classes#datasets.Dataset (where I've found .to_csv())
# Load a dataset of translations
test_dataset = load_dataset("opus100", name="en-fr", split="test")

# Save with .to_csv()
test_csv_path = "try_testset_save.csv"
test_dataset.to_csv(test_csv_path)

# Load dataset from the CSV
loaded_dataset = load_dataset("csv", data_files=test_csv_path)
print(test_dataset_fromfile[0]["translation"])
print(test_dataset_fromfile[0]["translation"]["en"])

Creating CSV from Arrow format: 100%
2/2 [00:00<00:00, 47.99ba/s]
Downloading data files: 100%
1/1 [00:00<00:00, 65.33it/s]
Extracting data files: 100%
1/1 [00:00<00:00, 42.10it/s]
Generating train split:
2000/0 [00:00<00:00, 47486.09 examples/s]

{'en': "She wasn't going to vaccinate her kid against polio,  no way.", 'fr': 'Elle ne vaccinerait pas son enfant contre la polio. Pas question.'}

---------------------------------------------------------------------------
TypeError                                 Traceback (most recent call last)
Cell In[29], line 11
      9 loaded_dataset = load_dataset("csv", data_files=test_csv_path)
     10 print(test_dataset_fromfile[0]["translation"])
---> 11 print(test_dataset_fromfile[0]["translation"]["en"])

TypeError: string indices must be integers, not 'str'

Expected behavior
Each translation was saved as a stringified dict like "{'en': ""She wasn't going to vaccinate her kid against polio,  no way."", 'fr': 'Elle ne vaccinerait pas son enfant contre la polio. Pas question.'}" where I would have expected 2 columns (1st with English segments, and 2nd with French segments), and I was expecting load_dataset to infer the type of feature automatically as I haven't seen anything about it in the documentation.
Do you have an example of how to effectively save and load datasets of translations ?
Environment info

datasets version: 2.15.0
Platform: Linux-3.10.0-1160.36.2.el7.x86_64-x86_64-with-glibc2.17
Python version: 3.11.5
huggingface_hub version: 0.16.4
PyArrow version: 14.0.2
Pandas version: 2.1.4
fsspec version: 2023.10.0

Indeed this works great, thank you !


Error in step Test Agent Deployment

After upgrade to TFS 2017 Version 15.105.25910.0 CodedUI test stopped working. The error occurs in step Deploy test agent. Agent Version 2.111.1, release test agent 14.0.25463.0. This user zav\autorazv is an administrator on wlab-40 computer.
Log

The error was in the Russian project name.


Monaco Language client dependency mix up

vscode-ws-jsonrpc depends on version 8 of vscode-jsonrpc
while latest release of @codingame/monaco-languageclient depends on version 6 of vscode-jsonrpc
Examples I find online show the packages acting in unison:
import { listen } from 'vscode-ws-jsonrpc'
import {
  CloseAction,
  createConnection,
  ErrorAction,
  MessageConnection,
  MonacoLanguageClient,
} from '@codingame/monaco-languageclient'
import ReconnectingWebSocket from 'reconnecting-websocket'

const createLanguageClient = (connection: MessageConnection) =>
  new MonacoLanguageClient({
    name: 'Lua Language Client',
    clientOptions: {
      documentSelector: ['lua'],
      // Disable the default error handler.
      errorHandler: {
        error: () => ErrorAction.Continue,
        closed: () => CloseAction.DoNotRestart,
      },
    },
    connectionProvider: {
      get: (errorHandler, closeHandler) =>
        Promise.resolve(
          createConnection(connection, errorHandler, closeHandler)
        ),
    },
  })

export const connectLanguageServer = (url: string) =>
  listen({
    webSocket: new ReconnectingWebSocket(url) as WebSocket,
    onConnection: (connection) => {
      const languageClient = createLanguageClient(connection)
      const disposable = languageClient.start()
      connection.onClose(() => disposable.dispose())
    },
  })

However in the example above I can't install any version of  vscode-ws-jsonrpc above 0.2.0 which depends on version 5 of vscode-jsonrpc because all newer versions depend on version 8
Any chance to release a version of @codingame/monaco-languageclient which depends on version 8 of vscode-jsonrpc?

Hi @d-baranowski @codingame/monaco-languageclient was only published for a brief amount of time by @CGNonofr before I came back to continue doing maintenance on behalf of TypeFox. The package that is maintained by the two of us is published as: monaco-languageclient
This repo contains the code of vscode-ws-jsonrpc and the current version depends on v8 of vscode-jsonrpc. monaco-languageclient does not depend on vscode-ws-jsonrpc, btw. It is required to build an application, but there is no direct dependency. This is for example needed in the monaco-editor-wrapper

Closing issue. Answer was provided: https://github.com/TypeFox/monaco-languageclient/issues/744#issuecomment-2348354815


【翻译】DOC-05-4-7 Areas

Document Urls：https://docs.asp.net/en/latest/mvc/controllers/areas.html
翻译稿 : https://github.com/heyixiaoran/aspnetcore-doc-cn/blob/areas/aspnet/mvc/controllers/areas.rst

#73 重新关联新的issue，本issue作废


Rescomp : Equivalence table out of Rescomp's similar tiles optimization ?

When Rescomp is told to process an 'IMAGE', it does an amazing job in optimizing the similar tiles, where it store only one occurence of each tile.
Would it be possible, in the next iterations of the SGDK to have an option in Rescomp that dumps/writes/displays the result of the tile optimization ?
It could be a plain text file, containing 2 columns of indexes :

the first column would be the position of the tile in the original image
the second column would be the position of the tile in the optimized tile bank

This is a suggestion, of course. Any other solution would be great, as long as we are given the chance to adress a tile easily after Rescomp did its optimization work.

At least i added the possibility to define the optimization level for the IMAGE resource: NONE, DUPLICATE_ONLY, ALL
Still it would be useful to have both table generated at same time (NONE / ALL)


[BUG] - Error Messages should make more sense, and only be info if info

While running a cardano relay node version 1.30.1, I started to get this error:
[cardano-:cardano.node.LocalErrorPolicy:Error:1099] [2021-12-13 17:57:39.14 UTC] IP LocalAddress "" ErrorPolicyUnhandledApplicationException (MuxError MuxBearerClosed "<socket: 49> closed when reading data, waiting on next header True")
This error seems to imply that my local IP address of "" closed when reading data.
This was working just fine since the release of 1.30.1. This error message is happening a lot
My configuration in pretty simply, running a relay from inputoutput/cardano-node:1.30.1
Can anybody tell me why these error messages are so obtuse, my IP LocalAddress certainly isn't ""?
I'd guess the error means that an open socket to another node closed, and if that's true how is this an error, this would happen all of the time as nodes register and unregister themselves.
Please make error messages actual error if they are, info if they're only info based errors.

In the current implementation this error can be ignored, when the new network stack will be rolled out this will not happen unless a non-clean shutdown happens.
As of "" local address, the qestion is on which OS are you running on?

Closing this. If this is still relevant please reopen.


Assert associated type for trait impl

Currently a type can be asserted to implement a given trait via assert_impl. However, as seen here, there is the restriction of not being able to specify associated types for a trait.

This has been possible for some time now
https://github.com/nvzqz/static-assertions-rs/blob/30f88bc55059e416a86f74809bf2718f13e4d2af/tests/trait_impl.rs#L15


Features/dbc22-2430

Implements basic saved route backend functionality: create, delete, list saved routes.
Adds markdown 3.6 package to requirements so that markdown formatting can be used in docstrings for API presentation.

I will review this once DBC22-2376 is finished.


KOGITO-8670 - Detach Quarkus Platform version from Quarkus version in…

… docs

JIRA: KOGITO-8670
I have left quarkus_version in the following places:

https://github.com/kiegroup/kogito-docs/blob/553fe5dee954d757b487acc56a787a15b4544e11/serverlessworkflow/modules/ROOT/pages/cloud/common/_proc_deploy_sw_kubectl.adoc?plain=1#L39
https://github.com/kiegroup/kogito-docs/blob/553fe5dee954d757b487acc56a787a15b4544e11/serverlessworkflow/modules/ROOT/pages/getting-started/create-your-first-workflow-service.adoc?plain=1#L285
https://github.com/kiegroup/kogito-docs/blob/553fe5dee954d757b487acc56a787a15b4544e11/serverlessworkflow/modules/ROOT/pages/tooling/quarkus-dev-ui-extension/quarkus-dev-ui-overview.adoc?plain=1#L18

@radtriste We need to update the quarkus_platform_version automatically as well when we are updating the Quarkus version. I noticed that here
https://github.com/kiegroup/kogito-docs/blob/553fe5dee954d757b487acc56a787a15b4544e11/.ci/jenkins/dsl/jobs.groovy#L22-L25
we update just the quarkus_version. In community the Quarkus version is equal to Quarkus platform version 99% of time, it's prod builds which cause issues, usually when a new SP build is created (participant release) which is based on the same Quarkus version. We can discuss that offline. But we could have another job probably, which would update just quarkus_platform_version in kogito-docs and ideally it would be run using the update ecosystem job we already have, just a new param will be needed.

How to backport a pull request to a different branch?

In order to automatically create a backporting pull request please add one or more labels having the following format backport-<branch-name>, where <branch-name> is the name of the branch where the pull request must be backported to (e.g., backport-7.67.x to backport the original PR to the 7.67.x branch).

NOTE: backporting is an action aiming to move a change (usually a commit) from a branch (usually the main one) to another one, which is generally referring to a still maintained release branch. Keeping it simple: it is about to move a specific change or a set of them from one branch to another.

Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.
If something goes wrong, the author will be notified and at this point a manual backporting is needed.

NOTE: this automated backporting is triggered whenever a pull request on main branch is labeled or closed, but both conditions must be satisfied to get the new PR created.

@MarianMacik the "update_quarkus_version" job is only used with community versions. So I guess, we can directly update the quarkus_platform_version in the current job.
The update to the prod version when we release OSL is done manually AFAIK for now


friends html

Create Friends html

Your pull request seems good, but must be checked by a human maintainer for the following reason(s):

This contains potentially hazardous tags that need manual review.

Please be patient until a maintainer has time to look over your contribution.
This is an automated response, beep boop.
if you think there is a mistake, contact a maintainer

11b15127a09ee63cd33184a58c4b0eb6d4e9223e


Add nodesource-4.x-precise

For non language: node_js builds, it is useful to specify the nodejs version to be used.

Test failure is same as current master, introduced in [114cd93].

I'm guessing that this probably won't work as build machines use an nvm installed nodejs. Instead I now have nvm install 4 in my before_install.

@lrowe so does nvm install 4 work? great, thanks for the hint!

@danse, yes nvm install 4 is working for me.

Yep for me as well


Forge uses old run script (run.sh) when version is being changed to older

Describe the problem
As in title. If we run 1.18.2 server then stop, change VERSION=1.8.8, server starts up with 1.18.2 instead 1.8.8.
Container definition
Kubernetes values of env:
     - env:
        - name: TYPE
          value: FORGE
        - name: EULA
          value: "TRUE"

then
     - env:
        - name: TYPE
          value: FORGE
        - name: VERSION
          value: 1.8.8
        - name: EULA
          value: "TRUE"

Container logs
[init] Running as uid=1000 gid=1000 with /data as 'drwxrwxrwx 15 1000 1000 4096 Apr  8 12:37 /data'
[init] Resolved version given 1.8.8 into 1.8.8 and major version 1.8
[init] Resolving type given FORGE
[init] **********************************************************************
[init] WARNING: Some mods and modpacks may require Java 8.
[init]          Please use itzg/minecraft-server:java8
[init] **********************************************************************
[init] Checking Forge version information.
Unknown option: '-s'
Possible solutions: --skip-existing, --skip-up-to-date
[init] Downloading 1.8.8-<IP_ADDRESS>5-1.8.8
[init] ...trying https://maven.minecraftforge.net/net/minecraftforge/forge/1.8.8-<IP_ADDRESS>5/forge-1.8.8-<IP_ADDRESS>5-installer.jar
[init] Installing Forge 1.8.8-<IP_ADDRESS>5. This might take a minute or two...
[init] Finding installed server jar...
[init] Using server /data/run.sh
[init] server.properties already created, skipping
[init] Checking for JSON files.
[init] Setting initial memory to 1G and max to 1G
[init] Using Forge supplied run.sh script...

https://github.com/itzg/docker-minecraft-server/blob/513492192ba10427388344fe3c6feae7845a611b/scripts/start-deployForge#L61-L63
That's why it does it. When run.sh exists, it assumes we want to run the version run.sh was created for (not our case in this issue). Perhaps we could remove old run.sh when installing new forge version?


Why the number of bboxes is different in MaxIoUAssigner.assign() and forward_train()

I printed the number of bboxes in these two places:
https://github.com/open-mmlab/mmdetection/blob/master/mmdet/models/detectors/two_stage.py#L113
and
https://github.com/open-mmlab/mmdetection/blob/master/mmdet/core/bbox/assigners/max_iou_assigner.py#L75
However the number is not consistent in these places. In forward_train(), it is always 2000, but in MaxIoUAssigner.assign() it is 2000 or 70420.
I wonder why they are different and what does the difference come from?

For two-stage detectors, the assign process happens both in the RPN stage and RCNN stage, so it is 2000 (number of proposals) or 70420 (number of anchors).

Thanks.


HTTP 500: Error in logs says Worker was unable to load function: 'Cannot find module 'uuid'

When i trigger the function i immediately get a http 500 error.
Then I see this below error thats says cannot find module uuid. The function was working fine until May 3, 2024. My hunch is maybe a regression occured at that time?
I'm not sure if I need to update something as my package.json doesn't have a dependency of uuid directly.
"@azure/functions": "^3.5.0",
"@azure/storage-blob": "^12.10.0"
In host.json, i have
"extensionBundle": {
    "id": "Microsoft.Azure.Functions.ExtensionBundle",
    "version": "[4.0.0, 5.0.0)"
}

Result: Failure Exception: Worker was unable to load function reports: 'Cannot find module 'uuid' Require stack: -<EMAIL_ADDRESS>-<EMAIL_ADDRESS>- /home/site/wwwroot/dist/shared/containerClient.js - /home/site/wwwroot/dist/reports/index.js - /azure-functions-host/workers/node/dist/src/worker-bundle.js - /azure-functions-host/workers/node/dist/src/nodejsWorker.js' Stack: Error: Worker was unable to load function reports: 'Cannot find module 'uuid' Require stack: -<EMAIL_ADDRESS>-<EMAIL_ADDRESS>- /home/site/wwwroot/dist/shared/containerClient.js - /home/site/wwwroot/dist/reports/index.js - /azure-functions-host/workers/node/dist/src/worker-bundle.js - /azure-functions-host/workers/node/dist/src/nodejsWorker.js' at Module._resolveFilename (node:internal/modules/cjs/loader:1140:15) at Module._load (node:internal/modules/cjs/loader:981:27) at Module.require (node:internal/modules/cjs/loader:1231:19) at Object.apply (/azure-functions-host/workers/node/dist/src/worker-bundle.js:2:51713) at require (node:internal/modules/helpers:177:18) at Object. (/home/site/wwwroot/node_modules/@azure/core-http/dist/index.js:5:12) at Module._compile (node:internal/modules/cjs/loader:1364:14) at Module._extensions..js (node:internal/modules/cjs/loader:1422:10) at Module.load (node:internal/modules/cjs/loader:1203:32) at Module._load (node:internal/modules/cjs/loader:1019:12)

Odd that this isn't being loaded since @azure/core-http hasn't been updated since last November: https://www.npmjs.com/package/@azure/core-http and I see it still has the dependency listed in its package.json.
Can you reproduce this error using @azure/storage-blob locally outside of functions? Is it perhaps some issue with functions not deploying all your node dependencies?

i think the issue could be on the host environment itself since im able to execute the function locally with local.settings.json environment variables set to prod account key, storage connection string etc. It all works as expected but in the host environment on azure portal, thats where this error gets thrown. See below for local log of successful function execution

I redeployed the function from local vscode and now getting
Result: Failure Exception: Stack: RestError at handleErrorResponse (/home/site/wwwroot/node_modules/@azure/core-http/dist/index.js:3139:19) at /home/site/wwwroot/node_modules/@azure/core-http/dist/index.js:3075:49 at process.processTicksAndRejections (node:internal/process/task_queues:95:5)

The RestError thrown should have additional details that will let you know what the service responded with. I recommend catching it and logging them.

Closing this issue as I found out my node_modules that was packaged was missing core dependencies. Thanks all


api: regenerate flow.pb.go

Please ensure your pull request adheres to the following guidelines:

[x] For first time contributors, read Submitting a pull request

[ ] All code is covered by unit and/or runtime tests where feasible.

[x] All commits contain a well written commit description including a title,
description and a Fixes: #XXX line if the commit addresses a particular
GitHub issue.

[x] If your commit description contains a Fixes: <commit-id> tag, then
please add the commit author[s] as reviewer[s] to this issue.

[x] All commits are signed off. See the section Developer’s Certificate of Origin

[ ] Provide a title or release-note blurb suitable for the release notes.

[ ] Are you a user of Cilium? Please add yourself to the Users doc

[x] Thanks for contributing!

add DebugEventType DBG_L7_LB, DBG_SKIP_POLICY

regenerate flow.pb.go

Fixes: #27826

It seems something went wrong with GitHub. Let's see if closing and opening the PR fixes it.
 Download action repository 'actions/checkout@f43a0e5ff2bd294095638e18286ca9a3d1956744' (SHA:f43a0e5ff2bd294095638e18286ca9a3d1956744)
Error: Can't use 'tar -xzf' extract archive file: /home/runner/work/_actions/_temp_5842cc54-fb27-4f25-a9e1-b9951ccc0495/eeeb8f1d-2d84-4ac2-bd35-0c5c9472cd27.tar.gz. return code: 2.

@gandro #27798  is merged so I think A is a good choice. I'll fix #27826  in this PR,
so I want to change it to draft pr, but I don't have permissions, is it possible to change it?

@gandro #27798 is merged so I think A is a good choice. I'll fix #27826 in this PR, so I want to change it to draft pr, but I don't have permissions, is it possible to change it?

Sure, I've converted it to a draft PR!

Image build failed due to some GitHub infra error. Closing and re-opening the PR to restart it.

This unfortunately needs a rebase now

@gandro i rebased

/test

Required CI passed. @ldelossa PTAL


Replace Travis with GH Actions!

I'm moving the build/deploy over to github since travis is broken and not sure if galaxyproject buys any more credits for it. it's actually super awesome.

linting workflows/snippets is done in ~40 seconds.
any linting we write that doesn't need ruby, can be done in <40 seconds.
any linting that needs the compiled site can start after ~3minutes.
html proofing done in ~5 minutes.

the configuration is SO much easier to read, too. So we can get feedback to the user super quickly for big issues if we lint for them. e.g. I'm updating the broken boxes detection so it can run without a built copy of the site, and then that will be able to run in ~40 seconds, too.
Other benefits:

gh knows which are PRs vs branches
I've currently set it up to only test PRs, we can open PRs from branches without the 2x builds.
deploys can happen from master and be significantly faster.

it's looking very positive

whoo! thanks @hexylena :tada: and so much faster too, I'm excited


config export and connection file export function

when I switch into a new computer, and I still in use MQTTX tool, so I hope could export all the config I used easylly, and in another computer just do inport the config file of MQTTX tool.
But now, all the MQTTX config I used needs me type on keyboard one by one on another computer, the work is too much.

@BlueCompiler Yes, this is a good ideal. It's planned for the next version. It provides data backup function, import and export json or csv files, etc. Thanks! :)

@BlueCompiler Yes, this is a good idea. It's planned for the next version. It provides data backup function, import and export json or csv files, etc. Thanks! :)

That is GREAT, when the new version issued, please you note me, thanks

Now available in v1.3.4, thanks :)


[stdlib] Remove Strideable closed range operator

This pull request removes the closed range operator on Strideable.
It was originally for CountableClosedRange, when that was a separate type.
The other countable range operators on Strideable were removed in #13342.

Cc: @airspeedswift, @natecook1000
Should any of the removed documentation be transferred to the Comparable extension?

@swift-ci please test

@swift-ci please test source compatibility

There were five failures in the Source Compatibility Suite.
  FAIL: Kitura, 4.0, f1c316, Swift Package
  FAIL: NetService, 4.2, 927eb1, Swift Package
  FAIL: SRP, 4.0, b16683, Swift Package
  FAIL: SwiftLint, 4.2, 60f98e, Swift Package
  FAIL: SwiftLint, 4.0, 60f98e, Swift Package

Each log contained "error: dependency graph is unresolvable; found these conflicting requirements"...

The projects were XFAILed in apple/swift-source-compat-suite@5d5f2582953c254b38be49848cd563900febef60

Rebased to resolve conflict.

Passerby testing
@swift-ci please test

@swift-ci Please test source compatibility

Build failed
Swift Test Linux Platform
Git Sha - 3beaab19d8a2fc901f38b7291202bf4a384e1679

Build failed
Swift Test OS X Platform
Git Sha - 3beaab19d8a2fc901f38b7291202bf4a384e1679

@swift-ci please smoke test and merge


Correctly handle return values

I adapted the return errors of roc-go to the actual returns from c functions. Please take a look at the test, it somehow fails. Could you check if I'm passing the address conrrectly?
Fixes #6.

Please take a look at the test, it somehow fails. Could you check if I'm passing the address conrrectly?

That's interesting! I've added debug logs:
diff --git a/src/lib/src/address.cpp b/src/lib/src/address.cpp
index 4bebe24e..637a943f 100644
--- a/src/lib/src/address.cpp
+++ b/src/lib/src/address.cpp
@@ -34,28 +34,36 @@ address::SocketAddr& get_address(roc_address* address) {
 }

 int roc_address_init(roc_address* address, roc_family family, const char* ip, int port) {
+    roc_log(LogError, "woooooooooooo");
     if (sizeof(roc_address) < sizeof(address::SocketAddr)) {
+        roc_log(LogError, "woooooooooooo1");
         return -1;
     }

     if (!address) {
+        roc_log(LogError, "woooooooooooo2");
         return -1;
     }

     if (!ip) {
+        roc_log(LogError, "woooooooooooo3");
         return -1;
     }

     if (port < 0 || port > USHRT_MAX) {
+        roc_log(LogError, "woooooooooooo4");
         return -1;
     }

     address::SocketAddr& sa = *new (address_payload(address)) address::SocketAddr;

     if (family == ROC_AF_AUTO || family == ROC_AF_IPv4) {
+        roc_log(LogError, "aaa --%s-- --%d--", ip, port);
         if (sa.set_host_port_ipv4(ip, port)) {
+            roc_log(LogError, "bbb");
             return 0;
         }
+        roc_log(LogError, "ccc");
     }

     if (family == ROC_AF_AUTO || family == ROC_AF_IPv6) {
@@ -64,6 +72,8 @@ int roc_address_init(roc_address* address, roc_family family, const char* ip, in
         }
     }

+    roc_log(LogError, "woooooooooooo5");
+
     return -1;
 }

And run the test:
go test -v .
=== RUN   Test_NewAddress
=== RUN   Test_NewAddress/correct_ip_is_parsed_with_no_error
12:08:54.679 [err] roc_lib: woooooooooooo
12:08:54.679 [err] roc_lib: aaa --<IP_ADDRESS>4140625: inuse: : status=Bassa_VahBhaiksukiBigEndianCuneiformDiacriticGC (idle)Hex_DigitInheritedInstMatchInstRune1InterfaceKhudawadiLINUX_2.6MalayalamMongolianNabataeanPalmyreneParseBoolParseUintSamaritanSeptemberSundaneseWednesday[:^wo
12:08:54.679 [err] roc_lib: ccc
12:08:54.679 [err] roc_lib: woooooooooooo5
=== RUN   Test_NewAddress/incorrect_ip_causes_negative_error
12:08:54.679 [err] roc_lib: woooooooooooo
12:08:54.679 [err] roc_lib: aaa --invalid ip stringlocked m0 woke upmalformed profilemark - bad statusmarkBits overflowmissing closing )missing closing ]no data availablenotetsleepg on g0permission deniedreflect.Value.Intreflect.Value.Lenreflect: New(nil)reflect: call of runtime: n
12:08:54.679 [err] roc_lib: ccc
12:08:54.679 [err] roc_lib: woooooooooooo5
--- FAIL: Test_NewAddress (0.00s)
    --- FAIL: Test_NewAddress/correct_ip_is_parsed_with_no_error (0.00s)
        roc-wrapper_test.go:27: WantErr: false, got One or more arguments are invalid
    --- PASS: Test_NewAddress/incorrect_ip_causes_negative_error (0.00s)
FAIL
FAIL	_/home/victor/dev/roc-project/roc-go/roc	0.003s

So instead of <IP_ADDRESS> roc_address_init() receives <IP_ADDRESS>4140625: inuse: : status=Bassa_VahBhaiksukiBigEndianCuneiformDiacriticGC (idle)Hex_DigitInheritedInstMatchInstRune1InterfaceKhudawadiLINUX_2.6MalayalamMongolianNabataeanPalmyreneParseBoolParseUintSamaritanSeptemberSundaneseWednesday[:^wo...
Let's see the generated code:
func addressInit(address *Address, family Family, ip string, port int32) int32 {
	...
	cip, _ := unpackPCharString(ip)
	...
}

func unpackPCharString(str string) (*C.char, *cgoAllocMap) {
	h := (*stringHeader)(unsafe.Pointer(&str))
	return (*C.char)(h.Data), cgoAllocsUnknown
}

So it just casts the Go string to char*. roc_address_init() expects a zero-terminated string (obviously), but IIRC Go strings are not zero terminated (it would be logical since we can slice them).
So we either need to make a zero-terminated string by hand or somehow tell the generator to make it for us, if it has such a feature.

holy shit! it actually does something!!

I mean the go bindings :D

I think we can modify the generator to use safe strings: https://github.com/xlab/c-for-go/issues/19
but now that I've modified the generated code all my edits will go to waste! D:
it's fine :disappointed:

After re-gen all generated functions became exported again... I'll leave it like that right now until the bug in c-for-go will be fixed, because manually changing them after each re-gen is a terrible option...
I mean, we could add a sed command in makefile, but it's sad

actually, scratch that, the bug has nothing to do with the functions being exported. I'll try to dig more into c-for-go or contact them.

https://github.com/xlab/c-for-go/issues/83

I've added travis build to the repo. Please rebase on fresh master and it should be enabled for this PR as well.

It seems that for now, we have no way of unexporting the generated functions. Let's keep it exported and fix the bug in c-for-go or hopefully somebody else will fix it first, what do you think?

sorry, accidental close

I fixed your comments in separate commits so it'll be easier to review. I'll fix them up if you accept this pr before merge

It seems that for now, we have no way of unexporting the generated functions. Let's keep it exported and fix the bug in c-for-go or hopefully somebody else will fix it first, what do you think?

I think I've fixed that, by playing with roc.yml. I've pushed the new roc.yml to master. Now AddressSize is hidden and all functions and Frame type are unexported.
Sorry for conflicts, you'll have to rebase.

I fixed your comments in separate commits so it'll be easier to review. I'll fix them up if you accept this pr before merge

Github allows to see what's changed from last review, so there is no need for it (at least I'm OK without it). So you can just rebase & squash.

Some generated functions are exported, is that intentional?
On Sun, Dec 15, 2019, 7:28 PM Victor Gaydov<EMAIL_ADDRESS>wrote:

It seems that for now, we have no way of unexporting the generated
functions. Let's keep it exported and fix the bug in c-for-go or hopefully
somebody else will fix it first, what do you think?
I think I've fixed that, by playing with roc.yml. I've pushed the new
roc.yml to master. Now AddressSize is hidden and all functions and Frame
type are unexported.
Sorry for conflicts, you'll have to rebase.
I fixed your comments in separate commits so it'll be easier to review.
I'll fix them up if you accept this pr before merge
Github allows to see what's changed from last review, so there is no need
for it (at least I'm OK without it). So you can just rebase & squash.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/roc-project/roc-go/pull/14?email_source=notifications&email_token=ABF6TYVUPNKQQH6EQR4EFPLQYZZM5A5CNFSM4JQ7LND2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEG47CNY#issuecomment-565834039,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABF6TYUS6HO4K6RCSAZFA3DQYZZM5ANCNFSM4JQ7LNDQ
.

Also, this line indicates, that a roc folder must be in the folder with roc.yml?
Includes: ["roc/receiver.h", "roc/sender.h", "roc/log.h"]
btw, is master failing ci?

Some generated functions are exported, is that intentional?

All functions in roc.go and now unexported. All helpers in cgo_helpers.go (like Free, PassRef, ...) are still exported. I think we can deal with them separately.

Also, this line indicates, that a roc folder must be in the folder with roc.yml?

No. roc/receiver.h will match /usr/include/roc/receiver.h (or whenever roc is installed. It just should be in search path).
AFAIK these lines are not for c-for-go, they are just passed to cgo.

btw, is master failing ci?

Build and test pass, coveralls complains that the coverage was decreased. So that's not a real issue.

ah, my mistake, I rebased wrong. fixed now.

LGTM!


feat: add seccomp profiler

This is the first draft for generating seccomp profile from synthetics agent runtime.
To generate a profile use  docker-compose up seccomp-profiler (in seccomp folder)
Remaning issues:

The rsyslog service seems to be running a bit late which creates inconsistency when generating the profile
We should use docker syslog driver

@andrewvc , I've created this draft so we can discuss the approach in more detail. Please have a look and let me know what you think.

@andrewvc , I've created this draft so we can discuss the approach in more detail. Please have a look and let me know what you think.

:broken_heart: Build Failed

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

Build Cause: Pull request #181 opened

Start Time: 2021-01-06T09:04:16.660+0000

Duration: 12 min 7 sec

Test stats :test_tube:

Test
Results

Failed
0

Passed
46

Skipped
0

Total
46

Steps errors
Expand to view the steps failures

Build Docker image

Took 0 min 0 sec . View more details on here

Build Docker image

Took 0 min 0 sec . View more details on here

Log output
Expand to view the last 100 lines of log output

[2021-01-06T09:16:16.871Z] npm notice 244B   dist/reporters/index.d.ts.map
[2021-01-06T09:16:16.871Z] npm notice 1.6kB  dist/core/index.js.map
[2021-01-06T09:16:16.871Z] npm notice 178B   dist/dsl/index.js.map
[2021-01-06T09:16:16.871Z] npm notice 1.5kB  dist/index.js.map
[2021-01-06T09:16:16.871Z] npm notice 221B   dist/plugins/index.js.map
[2021-01-06T09:16:16.871Z] npm notice 252B   dist/reporters/index.js.map
[2021-01-06T09:16:16.871Z] npm notice 1.0kB  dist/dsl/journey.d.ts.map
[2021-01-06T09:16:16.871Z] npm notice 776B   dist/dsl/journey.js.map
[2021-01-06T09:16:16.871Z] npm notice 659B   dist/reporters/json.d.ts.map
[2021-01-06T09:16:16.871Z] npm notice 3.0kB  dist/reporters/json.js.map
[2021-01-06T09:16:16.871Z] npm notice 225B   dist/core/logger.d.ts.map
[2021-01-06T09:16:16.871Z] npm notice 925B   dist/core/logger.js.map
[2021-01-06T09:16:16.871Z] npm notice 827B   dist/plugins/network.d.ts.map
[2021-01-06T09:16:16.871Z] npm notice 6.3kB  dist/plugins/network.js.map
[2021-01-06T09:16:16.871Z] npm notice 221B   dist/parse_args.d.ts.map
[2021-01-06T09:16:16.871Z] npm notice 1.2kB  dist/parse_args.js.map
[2021-01-06T09:16:16.871Z] npm notice 757B   dist/plugins/performance.d.ts.map
[2021-01-06T09:16:16.871Z] npm notice 1.0kB  dist/plugins/performance.js.map
[2021-01-06T09:16:16.871Z] npm notice 967B   dist/plugins/plugin-manager.d.ts.map
[2021-01-06T09:16:16.871Z] npm notice 1.9kB  dist/plugins/plugin-manager.js.map
[2021-01-06T09:16:16.871Z] npm notice 3.2kB  dist/core/runner.d.ts.map
[2021-01-06T09:16:16.871Z] npm notice 6.6kB  dist/core/runner.js.map
[2021-01-06T09:16:16.871Z] npm notice 342B   dist/dsl/step.d.ts.map
[2021-01-06T09:16:16.871Z] npm notice 328B   dist/dsl/step.js.map
[2021-01-06T09:16:16.871Z] npm notice 687B   dist/plugins/tracing.d.ts.map
[2021-01-06T09:16:16.871Z] npm notice 1.5kB  dist/plugins/tracing.js.map
[2021-01-06T09:16:16.871Z] npm notice 1.7kB  README.md
[2021-01-06T09:16:16.871Z] npm notice 1.6kB  dist/reporters/base.d.ts
[2021-01-06T09:16:16.871Z] npm notice 4.3kB  src/reporters/base.ts
[2021-01-06T09:16:16.871Z] npm notice 1.6kB  dist/plugins/browser-console.d.ts
[2021-01-06T09:16:16.871Z] npm notice 2.2kB  src/plugins/browser-console.ts
[2021-01-06T09:16:16.871Z] npm notice 1.2kB  dist/browser-service.d.ts
[2021-01-06T09:16:16.871Z] npm notice 2.0kB  src/browser-service.ts
[2021-01-06T09:16:16.871Z] npm notice 1.2kB  dist/cli.d.ts
[2021-01-06T09:16:16.871Z] npm notice 5.0kB  src/cli.ts
[2021-01-06T09:16:16.871Z] npm notice 2.7kB  dist/common_types.d.ts
[2021-01-06T09:16:16.871Z] npm notice 2.5kB  src/common_types.ts
[2021-01-06T09:16:16.871Z] npm notice 2.1kB  dist/core/gatherer.d.ts
[2021-01-06T09:16:16.871Z] npm notice 3.1kB  src/core/gatherer.ts
[2021-01-06T09:16:16.871Z] npm notice 3.8kB  dist/helpers.d.ts
[2021-01-06T09:16:16.871Z] npm notice 6.6kB  src/helpers.ts
[2021-01-06T09:16:16.871Z] npm notice 1.8kB  dist/core/index.d.ts
[2021-01-06T09:16:16.871Z] npm notice 1.2kB  dist/dsl/index.d.ts
[2021-01-06T09:16:16.871Z] npm notice 1.4kB  dist/index.d.ts
[2021-01-06T09:16:16.871Z] npm notice 1.3kB  dist/plugins/index.d.ts
[2021-01-06T09:16:16.871Z] npm notice 1.4kB  dist/reporters/index.d.ts
[2021-01-06T09:16:16.871Z] npm notice 2.8kB  src/core/index.ts
[2021-01-06T09:16:16.871Z] npm notice 1.2kB  src/dsl/index.ts
[2021-01-06T09:16:16.871Z] npm notice 2.7kB  src/index.ts
[2021-01-06T09:16:16.871Z] npm notice 1.3kB  src/plugins/index.ts
[2021-01-06T09:16:16.871Z] npm notice 1.3kB  src/reporters/index.ts
[2021-01-06T09:16:16.871Z] npm notice 2.1kB  dist/dsl/journey.d.ts
[2021-01-06T09:16:16.871Z] npm notice 2.2kB  src/dsl/journey.ts
[2021-01-06T09:16:16.871Z] npm notice 1.6kB  dist/reporters/json.d.ts
[2021-01-06T09:16:16.871Z] npm notice 5.0kB  src/reporters/json.ts
[2021-01-06T09:16:16.871Z] npm notice 1.3kB  dist/core/logger.d.ts
[2021-01-06T09:16:16.871Z] npm notice 1.8kB  src/core/logger.ts
[2021-01-06T09:16:16.871Z] npm notice 2.7kB  dist/plugins/network.d.ts
[2021-01-06T09:16:16.871Z] npm notice 8.4kB  src/plugins/network.ts
[2021-01-06T09:16:16.871Z] npm notice 1.3kB  dist/parse_args.d.ts
[2021-01-06T09:16:16.871Z] npm notice 3.0kB  src/parse_args.ts
[2021-01-06T09:16:16.871Z] npm notice 1.8kB  dist/plugins/performance.d.ts
[2021-01-06T09:16:16.871Z] npm notice 2.4kB  src/plugins/performance.ts
[2021-01-06T09:16:16.871Z] npm notice 2.1kB  dist/plugins/plugin-manager.d.ts
[2021-01-06T09:16:16.871Z] npm notice 3.4kB  src/plugins/plugin-manager.ts
[2021-01-06T09:16:16.871Z] npm notice 4.4kB  dist/core/runner.d.ts
[2021-01-06T09:16:16.871Z] npm notice 9.6kB  src/core/runner.ts
[2021-01-06T09:16:16.871Z] npm notice 1.4kB  dist/dsl/step.d.ts
[2021-01-06T09:16:16.871Z] npm notice 1.4kB  src/dsl/step.ts
[2021-01-06T09:16:16.871Z] npm notice 2.1kB  dist/plugins/tracing.d.ts
[2021-01-06T09:16:16.871Z] npm notice 3.4kB  src/plugins/tracing.ts
[2021-01-06T09:16:16.871Z] npm notice 71.6kB dist/tsconfig.tsbuildinfo
[2021-01-06T09:16:16.871Z] npm notice === Tarball Details ===
[2021-01-06T09:16:16.871Z] npm notice name:          @elastic/synthetics
[2021-01-06T09:16:16.871Z] npm notice version:       0.0.1-alpha.8
[2021-01-06T09:16:16.871Z] npm notice filename:      elastic-synthetics-0.0.1-alpha.8.tgz
[2021-01-06T09:16:16.871Z] npm notice package size:  62.6 kB
[2021-01-06T09:16:16.871Z] npm notice unpacked size: 331.9 kB
[2021-01-06T09:16:16.871Z] npm notice shasum:        cfd5a5f792e3327a9edac5582b3982ff0a75d159
[2021-01-06T09:16:16.871Z] npm notice integrity:     sha512-VS3w41HQr0UvD[...]jGHfZpw8+JKsQ==
[2021-01-06T09:16:16.872Z] npm notice total files:   114
[2021-01-06T09:16:16.872Z] npm notice
[2021-01-06T09:16:16.872Z] elastic-synthetics-0.0.1-alpha.8.tgz
[2021-01-06T09:16:18.750Z] Running in /var/lib/jenkins/workspace/nt-rum_elastic-synthetics_PR-181/src/github.com/elastic/synthetics
[2021-01-06T09:16:18.783Z] [INFO] getVaultSecret: Getting secrets
[2021-01-06T09:16:19.038Z] Masking supported pattern matches of $VAULT_ADDR or $VAULT_ROLE_ID or $VAULT_SECRET_ID
[2021-01-06T09:16:19.902Z] + set +x
[2021-01-06T09:16:20.164Z] Login Succeeded
[2021-01-06T09:16:20.583Z] + date +%Y-%m-%d_%H:%M
[2021-01-06T09:16:20.583Z] + docker build -t docker.elastic.co/observability-ci/synthetics:7a147e1c34631e44c139677a83dbe8a8f1f1d340-7.10.0-synthetics -t docker.elastic.co/observability-ci/synthetics:PR-181-7.10.0-synthetics --build-arg STACK_VERSION=7.10.0-synthetics --label BRANCH_NAME=PR-181 --label GIT_SHA=7a147e1c34631e44c139677a83dbe8a8f1f1d340 --label TIMESTAMP=2021-01-06_09:16 .
[2021-01-06T09:16:20.583Z] Sending build context to Docker daemon  3.089MB

[2021-01-06T09:16:20.583Z] Error response from daemon: dockerfile parse error line 22: unknown instruction: /USR/SHARE/HEARTBEAT/.NPM
[2021-01-06T09:16:21.703Z] Stage "experimental" skipped due to earlier failure(s)
[2021-01-06T09:16:21.911Z] Failed in branch Matrix - STACK_VERSION = '7.10.0-synthetics'
[2021-01-06T09:16:22.222Z] Running on Jenkins in /var/lib/jenkins/workspace/nt-rum_elastic-synthetics_PR-181
[2021-01-06T09:16:22.311Z] [INFO] getVaultSecret: Getting secrets
[2021-01-06T09:16:22.562Z] Masking supported pattern matches of $VAULT_ADDR or $VAULT_ROLE_ID or $VAULT_SECRET_ID
[2021-01-06T09:16:24.339Z] + chmod 755 generate-build-data.sh
[2021-01-06T09:16:24.339Z] + ./generate-build-data.sh https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-agent-rum/elastic-synthetics/PR-181/ https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-agent-rum/elastic-synthetics/PR-181/runs/1 FAILURE 727411
[2021-01-06T09:16:24.590Z] INFO: curl https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-agent-rum/elastic-synthetics/PR-181/runs/1/steps/?limit=10000 -o steps-info.json

:broken_heart: Build Failed

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

Build Cause: Pull request #181 opened

Start Time: 2021-01-06T09:04:16.660+0000

Duration: 12 min 7 sec

Test stats :test_tube:

Test
Results

Failed
0

Passed
46

Skipped
0

Total
46

Steps errors
Expand to view the steps failures

Build Docker image

Took 0 min 0 sec . View more details on here

Build Docker image

Took 0 min 0 sec . View more details on here

Log output
Expand to view the last 100 lines of log output

[2021-01-06T09:16:16.871Z] npm notice 244B   dist/reporters/index.d.ts.map
[2021-01-06T09:16:16.871Z] npm notice 1.6kB  dist/core/index.js.map
[2021-01-06T09:16:16.871Z] npm notice 178B   dist/dsl/index.js.map
[2021-01-06T09:16:16.871Z] npm notice 1.5kB  dist/index.js.map
[2021-01-06T09:16:16.871Z] npm notice 221B   dist/plugins/index.js.map
[2021-01-06T09:16:16.871Z] npm notice 252B   dist/reporters/index.js.map
[2021-01-06T09:16:16.871Z] npm notice 1.0kB  dist/dsl/journey.d.ts.map
[2021-01-06T09:16:16.871Z] npm notice 776B   dist/dsl/journey.js.map
[2021-01-06T09:16:16.871Z] npm notice 659B   dist/reporters/json.d.ts.map
[2021-01-06T09:16:16.871Z] npm notice 3.0kB  dist/reporters/json.js.map
[2021-01-06T09:16:16.871Z] npm notice 225B   dist/core/logger.d.ts.map
[2021-01-06T09:16:16.871Z] npm notice 925B   dist/core/logger.js.map
[2021-01-06T09:16:16.871Z] npm notice 827B   dist/plugins/network.d.ts.map
[2021-01-06T09:16:16.871Z] npm notice 6.3kB  dist/plugins/network.js.map
[2021-01-06T09:16:16.871Z] npm notice 221B   dist/parse_args.d.ts.map
[2021-01-06T09:16:16.871Z] npm notice 1.2kB  dist/parse_args.js.map
[2021-01-06T09:16:16.871Z] npm notice 757B   dist/plugins/performance.d.ts.map
[2021-01-06T09:16:16.871Z] npm notice 1.0kB  dist/plugins/performance.js.map
[2021-01-06T09:16:16.871Z] npm notice 967B   dist/plugins/plugin-manager.d.ts.map
[2021-01-06T09:16:16.871Z] npm notice 1.9kB  dist/plugins/plugin-manager.js.map
[2021-01-06T09:16:16.871Z] npm notice 3.2kB  dist/core/runner.d.ts.map
[2021-01-06T09:16:16.871Z] npm notice 6.6kB  dist/core/runner.js.map
[2021-01-06T09:16:16.871Z] npm notice 342B   dist/dsl/step.d.ts.map
[2021-01-06T09:16:16.871Z] npm notice 328B   dist/dsl/step.js.map
[2021-01-06T09:16:16.871Z] npm notice 687B   dist/plugins/tracing.d.ts.map
[2021-01-06T09:16:16.871Z] npm notice 1.5kB  dist/plugins/tracing.js.map
[2021-01-06T09:16:16.871Z] npm notice 1.7kB  README.md
[2021-01-06T09:16:16.871Z] npm notice 1.6kB  dist/reporters/base.d.ts
[2021-01-06T09:16:16.871Z] npm notice 4.3kB  src/reporters/base.ts
[2021-01-06T09:16:16.871Z] npm notice 1.6kB  dist/plugins/browser-console.d.ts
[2021-01-06T09:16:16.871Z] npm notice 2.2kB  src/plugins/browser-console.ts
[2021-01-06T09:16:16.871Z] npm notice 1.2kB  dist/browser-service.d.ts
[2021-01-06T09:16:16.871Z] npm notice 2.0kB  src/browser-service.ts
[2021-01-06T09:16:16.871Z] npm notice 1.2kB  dist/cli.d.ts
[2021-01-06T09:16:16.871Z] npm notice 5.0kB  src/cli.ts
[2021-01-06T09:16:16.871Z] npm notice 2.7kB  dist/common_types.d.ts
[2021-01-06T09:16:16.871Z] npm notice 2.5kB  src/common_types.ts
[2021-01-06T09:16:16.871Z] npm notice 2.1kB  dist/core/gatherer.d.ts
[2021-01-06T09:16:16.871Z] npm notice 3.1kB  src/core/gatherer.ts
[2021-01-06T09:16:16.871Z] npm notice 3.8kB  dist/helpers.d.ts
[2021-01-06T09:16:16.871Z] npm notice 6.6kB  src/helpers.ts
[2021-01-06T09:16:16.871Z] npm notice 1.8kB  dist/core/index.d.ts
[2021-01-06T09:16:16.871Z] npm notice 1.2kB  dist/dsl/index.d.ts
[2021-01-06T09:16:16.871Z] npm notice 1.4kB  dist/index.d.ts
[2021-01-06T09:16:16.871Z] npm notice 1.3kB  dist/plugins/index.d.ts
[2021-01-06T09:16:16.871Z] npm notice 1.4kB  dist/reporters/index.d.ts
[2021-01-06T09:16:16.871Z] npm notice 2.8kB  src/core/index.ts
[2021-01-06T09:16:16.871Z] npm notice 1.2kB  src/dsl/index.ts
[2021-01-06T09:16:16.871Z] npm notice 2.7kB  src/index.ts
[2021-01-06T09:16:16.871Z] npm notice 1.3kB  src/plugins/index.ts
[2021-01-06T09:16:16.871Z] npm notice 1.3kB  src/reporters/index.ts
[2021-01-06T09:16:16.871Z] npm notice 2.1kB  dist/dsl/journey.d.ts
[2021-01-06T09:16:16.871Z] npm notice 2.2kB  src/dsl/journey.ts
[2021-01-06T09:16:16.871Z] npm notice 1.6kB  dist/reporters/json.d.ts
[2021-01-06T09:16:16.871Z] npm notice 5.0kB  src/reporters/json.ts
[2021-01-06T09:16:16.871Z] npm notice 1.3kB  dist/core/logger.d.ts
[2021-01-06T09:16:16.871Z] npm notice 1.8kB  src/core/logger.ts
[2021-01-06T09:16:16.871Z] npm notice 2.7kB  dist/plugins/network.d.ts
[2021-01-06T09:16:16.871Z] npm notice 8.4kB  src/plugins/network.ts
[2021-01-06T09:16:16.871Z] npm notice 1.3kB  dist/parse_args.d.ts
[2021-01-06T09:16:16.871Z] npm notice 3.0kB  src/parse_args.ts
[2021-01-06T09:16:16.871Z] npm notice 1.8kB  dist/plugins/performance.d.ts
[2021-01-06T09:16:16.871Z] npm notice 2.4kB  src/plugins/performance.ts
[2021-01-06T09:16:16.871Z] npm notice 2.1kB  dist/plugins/plugin-manager.d.ts
[2021-01-06T09:16:16.871Z] npm notice 3.4kB  src/plugins/plugin-manager.ts
[2021-01-06T09:16:16.871Z] npm notice 4.4kB  dist/core/runner.d.ts
[2021-01-06T09:16:16.871Z] npm notice 9.6kB  src/core/runner.ts
[2021-01-06T09:16:16.871Z] npm notice 1.4kB  dist/dsl/step.d.ts
[2021-01-06T09:16:16.871Z] npm notice 1.4kB  src/dsl/step.ts
[2021-01-06T09:16:16.871Z] npm notice 2.1kB  dist/plugins/tracing.d.ts
[2021-01-06T09:16:16.871Z] npm notice 3.4kB  src/plugins/tracing.ts
[2021-01-06T09:16:16.871Z] npm notice 71.6kB dist/tsconfig.tsbuildinfo
[2021-01-06T09:16:16.871Z] npm notice === Tarball Details ===
[2021-01-06T09:16:16.871Z] npm notice name:          @elastic/synthetics
[2021-01-06T09:16:16.871Z] npm notice version:       0.0.1-alpha.8
[2021-01-06T09:16:16.871Z] npm notice filename:      elastic-synthetics-0.0.1-alpha.8.tgz
[2021-01-06T09:16:16.871Z] npm notice package size:  62.6 kB
[2021-01-06T09:16:16.871Z] npm notice unpacked size: 331.9 kB
[2021-01-06T09:16:16.871Z] npm notice shasum:        cfd5a5f792e3327a9edac5582b3982ff0a75d159
[2021-01-06T09:16:16.871Z] npm notice integrity:     sha512-VS3w41HQr0UvD[...]jGHfZpw8+JKsQ==
[2021-01-06T09:16:16.872Z] npm notice total files:   114
[2021-01-06T09:16:16.872Z] npm notice
[2021-01-06T09:16:16.872Z] elastic-synthetics-0.0.1-alpha.8.tgz
[2021-01-06T09:16:18.750Z] Running in /var/lib/jenkins/workspace/nt-rum_elastic-synthetics_PR-181/src/github.com/elastic/synthetics
[2021-01-06T09:16:18.783Z] [INFO] getVaultSecret: Getting secrets
[2021-01-06T09:16:19.038Z] Masking supported pattern matches of $VAULT_ADDR or $VAULT_ROLE_ID or $VAULT_SECRET_ID
[2021-01-06T09:16:19.902Z] + set +x
[2021-01-06T09:16:20.164Z] Login Succeeded
[2021-01-06T09:16:20.583Z] + date +%Y-%m-%d_%H:%M
[2021-01-06T09:16:20.583Z] + docker build -t docker.elastic.co/observability-ci/synthetics:7a147e1c34631e44c139677a83dbe8a8f1f1d340-7.10.0-synthetics -t docker.elastic.co/observability-ci/synthetics:PR-181-7.10.0-synthetics --build-arg STACK_VERSION=7.10.0-synthetics --label BRANCH_NAME=PR-181 --label GIT_SHA=7a147e1c34631e44c139677a83dbe8a8f1f1d340 --label TIMESTAMP=2021-01-06_09:16 .
[2021-01-06T09:16:20.583Z] Sending build context to Docker daemon  3.089MB

[2021-01-06T09:16:20.583Z] Error response from daemon: dockerfile parse error line 22: unknown instruction: /USR/SHARE/HEARTBEAT/.NPM
[2021-01-06T09:16:21.703Z] Stage "experimental" skipped due to earlier failure(s)
[2021-01-06T09:16:21.911Z] Failed in branch Matrix - STACK_VERSION = '7.10.0-synthetics'
[2021-01-06T09:16:22.222Z] Running on Jenkins in /var/lib/jenkins/workspace/nt-rum_elastic-synthetics_PR-181
[2021-01-06T09:16:22.311Z] [INFO] getVaultSecret: Getting secrets
[2021-01-06T09:16:22.562Z] Masking supported pattern matches of $VAULT_ADDR or $VAULT_ROLE_ID or $VAULT_SECRET_ID
[2021-01-06T09:16:24.339Z] + chmod 755 generate-build-data.sh
[2021-01-06T09:16:24.339Z] + ./generate-build-data.sh https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-agent-rum/elastic-synthetics/PR-181/ https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-agent-rum/elastic-synthetics/PR-181/runs/1 FAILURE 727411
[2021-01-06T09:16:24.590Z] INFO: curl https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-agent-rum/elastic-synthetics/PR-181/runs/1/steps/?limit=10000 -o steps-info.json


404 Kubernetes

There is a link in product that points to https://help.sumologic.com/Solutions/Kubernetes_Solution/13Filter_with_template_variables (on the screen you build filters on in dashboards (new) it currently 404s.  Should redirect here https://help.sumologic.com/docs/dashboards-new/filter-template-variables/
Slack Message

Craig confirmed https://github.com/SumoLogic/sumologic-documentation/pull/736. fixes this


feat(Dialog): use ButtonGroup instead of Box

This PR changes the implementation of Dialog. A ButtonGroup is used instead of Box to hold the cancel and confirm buttons. Relevant issue #1705

Warnings

:warning:
There are no updates provided to CHANGELOG. Ensure there are no publicly visible changes introduced by this PR.

  Generated by :no_entry_sign: dangerJS

Should this be chore instead of a feature?

Warnings

:warning:
There are no updates provided to CHANGELOG. Ensure there are no publicly visible changes introduced by this PR.

  Generated by :no_entry_sign: dangerJS


Implement SH1107 sleep/wake functionality

Add sleep() and wake() methods and a state property to allow users to put the display into a power-saving mode.  Uses the bus object passed to the SH1107 class at initialization to write to the device.  Commands for entering and exiting sleep mode derived from the SH1107 datasheet.
Tested on a Feather M4 Express and SH1107 FeatherWing OLED 128x64 display.

@SAK917 Looks like I forgot to update some stuff on this library. I'll do that tomorrow and then merge it with your fork which will hopefully make your PR pass.

@SAK917 Looks like I forgot to update some stuff on this library. I'll do that tomorrow and then merge it with your fork which will hopefully make your PR pass.

@SAK917 Just heard you're working on adding the licenses. That'd be greatly appreciated! If you've got any questions, feel free to ping me

@SAK917 Just heard you're working on adding the licenses. That'd be greatly appreciated! If you've got any questions, feel free to ping me

@SAK917 Just heard you're working on adding the licenses. That'd be greatly appreciated! If you've got any questions, feel free to ping me

Happy to do what I can... thanks to a LOT of help from @askpatrickw I was able to muddle through all the changes the checks flagged.  Most were for the supporting files, sorry for all the commits!

@SAK917 Just heard you're working on adding the licenses. That'd be greatly appreciated! If you've got any questions, feel free to ping me

Happy to do what I can... thanks to a LOT of help from @askpatrickw I was able to muddle through all the changes the checks flagged.  Most were for the supporting files, sorry for all the commits!

@SAK917 Great to see that it's passing!

@SAK917 Great to see that it's passing!


Questions about Sprite.loadImage

		public function loadImage(url:String, x:Number = 0, y:Number = 0, width:Number = 0, height:Number = 0, complete:Handler = null):Sprite {
			function loaded(tex:Texture):void {
				if (!destroyed) {
					size(x + (width || tex.width), y + (height || tex.height));
					//if (_width == 0 && _height == 0) setBounds(getSelfBounds());
					repaint();
					complete && complete.runWith(tex);
				}
			}
			graphics.loadImage(url, x, y, width, height, loaded);
			return this;
		}

code
Why width hight need to add x y???

sprite is started from (0,0) point,so if draw a image to sprite at (10,10),it's with will added 10px

@yungzhu thank you answer.  I see argument x y of loadImage function  meaning image offset.


Add standardrb linter

This is a copy of rubocop for standardrb
This needs some tests now but this is why it is just a draft.

I have no idea if it is normal that it fails based on environment.
But otherwise code is ready ✌

Anything I can do to get this shipped?
The failing tests are not related to my changes :(

@ocean90 How can I help getting this merged?


The path of test is included in resolve.modules of webpack.config.js

The following code seems to be executing filter to remove compileTestKotlin2Js task.
https://github.com/Kotlin/kotlin-frontend-plugin/blob/22ef064c1c2fcf1a7859a451d0d82e57bbbd3825/kotlin-frontend/src/main/kotlin/org/jetbrains/kotlin/gradle/frontend/webpack/GenerateWebPackConfigTask.kt#L67-L68
However, it is not filtered because ignorecase = true is not set.
Therefore, the path of test is also included in resolve.modules of webpack.config.js. Is this the expected behavior?

Fixed, thanks!

Fixed in 0.0.22


Launch external openstack-cloud-controller-manager in devstack plugin.sh process

Is this a BUG REPORT or FEATURE REQUEST?:
/kind feature
What happened:
When we config devstack to enable plugin openstack-cloud-controller-manager, devstack process will launch kubernetes, but don't launch external openstack-cloud-controller-manager binary, and don't set the suitable cloud-config file, that cause we have to config something manually after devstack process end.
What you expected to happen:
When devstack process finish, kubernetes and external openstack-cloud-controller-manager are launched with correct configuration, those instances can talk with OpenStack that deployed by devstack.
How to reproduce it (as minimally and precisely as possible):

enable_plugin openstack-cloud-controller-manager in devstack local.conf
run stack.sh

Anything else we need to know?:
N/A
Environment:

openstack-cloud-controller-manager version:

$ git log -1
commit 391a2a0f79e08deb445a7a726b6c5ce85155db3e
Merge: 692c16e e77320e
Author: Davanum Srinivas<EMAIL_ADDRESS>Date:   Thu Feb 8 15:10:48 2018 -0500

    Merge pull request #74 from dims/add-support-for-csi

    Add support for csi

@kiwik yep, we can use hack/local-up-cluster.sh to launch kubernetes. please see details in:
https://github.com/dims/openstack-cloud-controller-manager/issues/34#issuecomment-363903625
The other choice is to run kubeadm, but i think it's easier to deal with local-up-cluster.sh as kubeadm starts kubernetes processes inside pods/daemonsets which would be harder to deal with in a CI environment. Not ruling that out, just that we start with local-up-cluster.sh

added some info in https://github.com/dims/openstack-cloud-controller-manager/issues/26 which will help


Feat: sync sdk automatically

Description of your changes

Sync SDK to https://github.com/kubevela-contrib/kubevela-go-sdk when

SDK generating logic is changed
Any Built-in Definition is changed.

Add ToJSON method to application.

I have:

[ ] Read and followed KubeVela's contribution process.
[ ] Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
[ ] Run make reviewable to ensure this PR is ready for review.
[ ] Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Special notes for your reviewer

See #5630


♻ Refactored code to use encryption algorithm name from settings for consistency

Thank you @menkotoglou, please let me know what else I need to do in order to get this PR merged.

@sameeramin unfortunately I cannot do anything about it, since I'm not a repo maintainer.

Thank you for the interest!
I don't think the algorithm should be configurable in the settings, it shouldn't really be variable. Let's better keep it in security.py.
But I agree that the backend utils should use the same variable from security.py. 🤓 Could you please update that?

Sure, I'll update that!

Hello @tiangolo, I have incorporated your suggestions

Great, thanks @sameeramin! :rocket: :cake:


Autocomplete initial positioning

Bug, feature request, or proposal:
I have a project where the autocomplete dropdown does not properly position itself until it the input box that it is acting upon is unfocused and refocused. It initially extends past the bottom of the screen, choosing to initially position on the bottom of its input box.
Perhaps there could be a directive to force positioning of an autocomplete dropdown?
What is the expected behavior?
Expected behavior is for the autocomplete dropdown to recognize that it will be off-screen if it extends downward and instead position itself above the input box.
What is the current behavior?
In its current behavior, the autocomplete dropdown only calculates its position properly once its input box has been refocused. Switching tabs also causes the autocomplete dropdown to position properly.
What are the steps to reproduce?
The project in which this bug is occurring is already large and mature. I have, as of yet, been unable to reproduce this issue within a simple context.
What is the use-case or motivation for changing an existing behavior?
There may be cases where the code does not properly position the autocomplete dropdown. Adding a directive or other such mechanism for forcing positioning may prove useful.
Which versions of Angular, Material, OS, TypeScript, browsers are affected?
@angular/cli: 1.5.0
@angular/material: 2.0.0-beta.12
typescript: 2.3.3
OS: (Gentoo) Linux
Browsers: webkit and gecko

Is there anything else we should know?
I don't particularly expect great support since I am unable to provide reproducable steps, but thanks in advance anybody's time in addressing this matter.

Alternatively, could somebody with knowledge of the autocomplete internals explain how the component decides where to position itself or point me in the right direction?

Since you're unable to reproduce, can you at least share a screenshot or screen recording?

@ehegnes the source for the positioning is here:
https://github.com/angular/material2/blob/master/src/cdk/overlay/position/connected-position-strategy.ts#L118
It should be pretty straightforward to follow the logic

@jelbourn I have run into this issue as well.
It occurs when the options are populated while the user is focused on the input.
It can be reproduced here => https://stackblitz.com/edit/angular-4nrrts by focusing the input before the initial 5 second delay for the options to be added.

Is there any update in this topic? Same issue

I have the same problem :/

@snajperek130 please use the reaction feature instead of posting like that to reduce clutter and forgo email notifications of responses that aren't constructive.

What you can do for now is just triggering a fake window resize event, same as they do in their tests, after you get the async results.
You can do this with window.dispatchEvent(new Event('resize')). Obviously not the best solution, just a temporal one until they have the time to fix the bug.
Updated reproduction with fix here.

try to add following line in style.css
@import<EMAIL_ADDRESS>tis fixed for me

Did they have time to fix the issue ?

I ran into the same issue recently.
It can be fixed by a simple trick, Just programatically do window.scroll() twice one for scroll up and other for scroll down, on focus of the input field.
This solved the issue for me.


Ability to add custom items to masthead profile

The problem
I am not able to add custom items to the masthead profile
The solution
Ability to add custom menu items to the masthead profile - use case would be to add a 'Portal settings' for our page; as opposed to have it in the left hand menu where it feels out of place
Application/website
ideas.ibm.com
Business priority
Medium Priority = upcoming release but is not pressing
What time frame would this ideally be needed by (if applicable)
We want to add our user preferences/settings page as part of the coming iterations, so as soon as this feature would be be available would be great
Examples
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct
[X] I checked the current issues for duplicate issues

@kshah11 Your site does not appear to be responsive on mobile . Have you built this site using the Carbon grid?

@ljcarot yes we have used the carbon grid

@andy-blum FYI

After consultation with @areagan1030 and her team, we're electing to close this issue. The masthead is a global, foundational component and customizations are not aligned with that purpose.

This was also captured on PMOWEB-666, which I have also cancelled.


Cannot get Gerrit plugin to work with Intellij.  "Failed to get Gerrit changes: Request failed"

When I go into the Settings for my gradle project, under Version Control/Gerrit, when I click the "Test" button, I always get the same error message:
Can't login to https://git.epyonpower.com:8445/#: com.google.gerrit.extensions.restapi.RestApiException: Request failed.
Using IntelliJ IDEA 2021.1.3 (Community Edition).
Plugin version 1.2.5-203.
Language JAVA.
This used to work.  Recently we updated our version of IntelliJ and the Plugin.
thank you!

Is https://git.epyonpower.com:8445/ the URL for accessing Gerrit? Is there no sub path? Also, try removing the trailing #.

Yes,  https://git.epyonpower.com:8445/ #/ is the URL.  No sub path.  Tried without trailing #, no difference.
Could it be a certificate issue?  in the browser, it indicates "connection not secure".

You could try to downgrade plugin. You can manually download an older release from GitHub releases and install in IntelliJ from Zip.