AWS Lambda Python 3.6 Deprication

Is your feature request related to a problem?
Update CFT templates and panw-aws.zip to support Python 3.9 due to AWS removing support for Python 3.6
Describe the solution you'd like
Update CFT templates and panw-aws.zip to support Python 3.9 due to AWS removing support for Python 3.6
Describe alternatives you've considered
None
Additional context
Update CFT templates and panw-aws.zip to support Python 3.9 due to AWS removing support for Python 3.6

Hello,
I updated the CloudFormation template with a new AMI ID for 10.1.6-h6 and this updated the Lambda Custom Resource.
Can you please update the panw-aws.zip to support a new version of Python?
cft with autoscale/security_stack/panw-aws.zip

@hxrsmurf ...did you find a resolution for this?  I'm in the same boat :-(

@justinjocewiczahead - One could technically update the CFT themselves. But PA Support and our account rep suggested we migrate to the Terraform AWS VMSeries Module (below)

https://github.com/PaloAltoNetworks/terraform-aws-vmseries-modules


PMID:28977649

normal tRNA aminoacylation
abnormal tRNA aminoacylation
abnormal tRNA folding
decreased nonsense suppression
normal tRNA binding

1 & 2 xp and full-name synonym using GO:0006418; extensions from SO (under SO:0000253 ! tRNA) rather than separate terms for specific tRNAs
3 xp GO:0061818
4 synonyms "decreased translational readthrough", "decreased tRNA-mediated suppression"; not sure whether to kp GO:0006451, because not sure the suppressing tRNA-Ser UCA occurs naturally
5 xp GO:0000049

normal tRNA aminoacylation FYPO:0006249
abnormal tRNA aminoacylation FYPO:0006250
decreased tRNA aminoacylation FYPO:0006251
abnormal tRNA folding FYPO:0006252
normal tRNA binding FYPO:0006253
edit file: 91ae21ddd93e79984f2e98a5d134da4b1ece1da4
release: b67f343991fe9193f081b6dd6127c24351c294fe


Remove trailing forward slash in ceph_docker_registry variable from g…

Remove trailing forward slash in ceph_docker_registry variable from group_vars/rhcs.yml.sample file.
This had caused the docker pull command in site-docker.yml.sample to fail due to the double forward slash // when rendered by Ansible to the command line.
For example: timeout 300s docker pull registry.access.redhat.com/rhceph//rhceph-3-rhel7:latest which is incorrect syntax.
Is not affected when using docker.io defaults for registry due to lack of trailing forward slash in the ceph_docker_registry variable.
Also fixed rhcs_edits.txt for variable ceph_docker_registry.
Signed-off-by: Phuong Nguyen<EMAIL_ADDRESS>

Updated PR as requested

Removed the extra line after the end of line comment as requested

On a second thought could you update the PR to have only one commit ? There's no need to get three commits for this.
Also add a commit message even if it's a short one.

Squashed the 3 commits into one


WhatsApp messenger like view

Issues and steps to reproduce
I want to create message view like whatsapp using flexbox-layout. I have created 2 textview inside flexbox layout that is message and time. On first line everything goes fine. But when text message move to second line, than time automatically goes to third line. But in whatsapp messenger both message and time are on same line. Is there any way to restrict message text to not occupy full line.

Version of the flexbox library
1.0.0

Hi, please debug this with the layout inspector on Android Studio and check the attributes assigned to each TextView.
Let me close this since this seems to be not an issue.


Run initializer using Service Account

FIDC now supports Service Accounts, which can be used to get an access token that is scoped to perform REST API calls.
See docs:
https://backstage.forgerock.com/docs/idcloud/latest/release-notes/rapid-channel/service-accounts.html
https://backstage.forgerock.com/docs/idcloud/latest/release-notes/rapid-channel/service-accounts-authenticate-to-rest-api-with-access-token.html
Tasks:

[ ] Review if it is possible to set up a service account in the CDK so that we have a consistent approach to using the REST API.
[ ] Use service account authentication for FIDC
[ ] Support access token authentication in REST API calls (this will either replace the current cookie based auth OR be in addition to it, depending on whether the CDK can support access tokens)

Need to discuss this with @BohoCode .
This issue was raised prior to discovering the CS_config_manager, if we don't intend to use the initializer in a customer deployment then there is less of a priority to use a service account.
#786

Don't think this is needed anymore, as the initializer at this time is only used in devenv

This is now a necessity for running the initializer against the nightly environment, as 2FA will be required from 1st March 2024. See: https://backstage.forgerock.com/docs/idcloud/latest/product-information/migration-dependent-features/tenant-administrator-mandatory-2-step-verification-faq.html

Going to implement for Test User as it creates the PSU user

Outcome of all this was
CDK does not support service accounts so most of the proposed work isn't possible
We decided to use service accounts for the test initialiser as communication to the cloud instance is required when the cloud type is FIDC
We are not setting this up for FIDC initialiser  as we no longer run the service against our cloud tenants, and use the fr_config_manager instead


Setting cwd when using streams

For example, we have
    const client = new LanguageClient(
      `${language}Proxy`,
      () =>
        Promise.resolve({reader: proxyReadStream, writer: proxyWriteStream}),
      {
        documentSelector: [language],
        uriConverters: {
          code2Protocol: connectionWrapper.uri2Path.bind(connectionWrapper),
          protocol2Code: connectionWrapper.path2Uri.bind(connectionWrapper),
        },
      },
    );

However, in VsCode this results in the rootPath and rootURI attributes in the initialize RPC request to be the workspace root. I want to be able to set them to null.
It seems like there is no way to do that currently. Is there?

No there is not. Why would you. The value correspond to what VS Code uses?

I think it's not so much that we want it to be null, but we want to set it as the URI for our remote file system that we have configured via https://github.com/Microsoft/vscode/pull/30337.
/cc @jrieken

Basically, we want things such that after it goes through the converter (code2Protocol?) that when the message ends up on the other side of the proxy, it is the proper file path on that remote machine.

Perhaps the fix needs to happen in VS Code rather than here? If it's passing in null to the LanguageClient for the rootUri, then I suppose we should focus on fixing that instead?

The right way to address this then is to have a middleware hook for the initialize request as well.
PR welcome to add such a hook. See https://github.com/Microsoft/vscode-languageserver-node/blob/master/client\src\client.ts#L422 for the current middleware definition.


Added possibility for line search methods to return a potential auxiliary value in their results

Linesearch methods affected : Backtracking linesearch and Zoom linesearch.
This was was also used in order to correct the way auxiliary values are handled in the BFGS, L-BFGS and Nonlinear CG solvers where these methods are used.
I still need to add tests on the matching between the auxiliary value and the parameters returned.

@mblondel I added the tests to check for the auxiliary value, all green in local. This can be reviewed.

@mblondel squashed all commits as well


feat: remove scripts section in package.json

closes #662
I'm submitting a...
[ ] Bug Fix
[x] Feature
[ ] Other (Refactoring, Added tests, Documentation, ...)

[ ] Yes
[x] No

Created a new PR #684, since the master branch was deleted.


Not functioning as expected (broken README example etc.)

Hi @Saecki thank you for your work here! We would like to use this crate in another project, for reading existing atoms/tags on M4A files in a personal music library. See https://github.com/agersant/polaris/pull/82
However, it returns None for all atoms/tags. This simplified example based on your README is panicking on the 2nd unwrap:
fn main() {
    let tag = mp4ameta::Tag::read_from_path("music.m4a").unwrap();
    println!("{}", tag.artist().unwrap());
}

Any information would be helpful.

I can't replicate the behavior you're getting. Are you sure the song is using ITunes style mp4 metadata and not ID3? If so could you provide the file so I check what is going wrong?

Certainly. The file is here: https://github.com/rayrrr/polaris/blob/master/test/sample.m4a
AtomicParsley is finding the atoms of this file correctly on the command line with this output:
> AtomicParsley sample.m4a -t
Atom "©nam" contains: TEST TITLE
Atom "©ART" contains: TEST ARTIST
Atom "aART" contains: TEST ALBUM ARTIST
Atom "©alb" contains: TEST ALBUM
Atom "©day" contains: 2016
Atom "©too" contains: Lavf58.29.100
Atom "trkn" contains: 1
Atom "disk" contains: 3

However when replacing music.m4a with sample.m4a in the modified example as posted in description above, I get a panic on the 2nd unwrap which I understand to mean that it did in fact find the file but is unable to retrieve this metadata. Please advise. Thank you.

Thank you for reporting this. There certainly seems to be a bug. I will look into this.

I pushed what I believe is the fix for this. On my end the file is now being parsed successfully .

Thank you so much for the quick response @Saecki. I have confirmed that the example described above now returns TEST ARTIST as expected! Would you mind bumping the crate version and publishing to crates.io so we don't have to use a git dependency in our Cargo.toml?

Done


I can't use git in my vscode

VSCode Version: v1.25.1
OS Version: win10

My version control in VS Code doesn't have the button of init and more, and the settings doesn't contain the option——git.
You can see the picture below of my vscode to know what happend.
thanks for your help~
image
image

Do you have Git installed? https://git-scm.com/

sure, i ve installed git
I can use git to push code to remote in my webstrom

The path my of git is:
D:\installDir\Git
And the path to git executable in my webstrom is:
D:\installDir\Git\cmd\git.exe
And my %PATH% has added:
D:\installDir\Git\cmd
All above can be seen in the piictures below, I hope it can help.
git directory
webstrom git path
%PATH%
@joaomoreno @myfairsyer

I put all my plugins available disabled ,and then reenabled them, the problem was fixed.
I think maybe some plugin has confused the function of the git-scm in my vscode.
I truly show my appreation for your help.
@joaomoreno @myfairsyer


Spec version 1

Fixes #7
Fises #8
Fixes #13
Ping @rabernat @rsignell-usgs @manzt @joshmoore

This is not really a "spec"; it's more of an example

I thought more like an example with explanations that can together be turned into a formal spec :) It could be encoded in a jsonschema and used for validation.

if you showed the complete representation that would be generated by the template

Good idea. Indeed, when implemented in code, this ought to be a test case.

Do we want to link explicitly to a spec document URL

I think version should be a number, but it would be reasonable to also add a link/DOI, etc., in a different field. In the python implementation, we would probably not check this field.

Is there a language-agnostic version of format strings we could point to?

I am happy to have one pointed out, but I believe python's is moderately simple and similar to other languages. Other popular template engines like jinja are also typically tied to a particular implementation.

Putting python code in the spec seems problematic

The alternative is to come up with our own language... For the specific case of range, you could replace with a list literal, but would not want to do that for long lists.

This is the python version of the "moustache" templating framework, which appears to have libs in many many languages: https://github.com/noahmorrison/chevron

Only comment on top of those given so far, I think, is that data doesn't seem to be specified. My assumption is that it's the raw return value with no need for further lookup.
Regarding the Python-ism points, I could certainly see having a second implementation to keep us honest. I'd probably default to doing so in Java, but I won't start on that until I hear whether or not @manzt already has one in JS (which is what usually happens...)

data doesn't seem to be specified. My assumption is that it's the raw return value with no need for further lookup.

Indeed. And that the remote chunks referenced are byte blocks too. To be included in JSON, these literals would have to be ascii (which is fine and normal for zarr). We could optionally introduce an encoding like b64 at this point.
As an interesting contrast, for something like the grib2 case, where we need to make a local file to pass to C, one could imagine using this kind of structure and specify a "literals processor" and/or "reference processor" somehow. Very useful, but I think beyond Version 1.

Perhaps we want to restrict what sort of python expressions can be used. Do we envision needing anything besides range? If not, we could do something like
"i": {"start": 0, "stop": 9}

Do we envision needing anything besides range?

open to suggestions. By using a specific dict as you suggest, though, would hinder future expansion of possibilities, so I would still prefer range (with one, two or three arguments).  I originally had imagined allowing anything in python builtins, but indeed that would be hard to make language agnostic.

Then what about
"i": {"range": {"start": 0, "stop": 9}}

My point is that functions and arguments can be encoded as json and then translated to python, rather than putting python code as strings into the json document.

That syntax is OK with me.

This is the python version of the "moustache" templating framework, which appears to have libs in many many languages.

I think moustache is a good choice for this, echoing @rabernat concern with python-isms.

I originally had imagined allowing anything in python builtins, but indeed that would be hard to make language agnostic.

Ideally we could define the "set" of builtins that the spec may include in JSON like @rabernat's example. This would help clarify which builtins are absolutely necessary and as @joshmoore said "keep us honest" between implementations.

Only comment on top of those given so far, I think, is that data doesn't seem to be specified. My assumption is that it's the raw return value with no need for further lookup.

Also somewhat unclear to me. Can data be both an ascii-encoded string that needs to be parsed as JSON or just JSON?

I won't start on that until I hear whether or not @manzt already has one in JS (which is what usually happens...)

I've written a few ad-hoc pieces of code to parse the spec, but it's coupled with a custom zarr.js store. I can try to separate out pieces and work on something more "official" and reusable for the JS folks.

I've written a few ad-hoc pieces of code to parse the spec, but it's coupled with a custom zarr.js store.

Since you don't have an fsspec to handle the references, I imagine a custom store is the only way to go. That's how this "pieces of HDF" was initially implemented too; but I am keen that the idea be transferrable beyond zarr if possible, at least in python.

Since you don't have an fsspec to handle the references, I imagine a custom store is the only way to go.

Makes sense. I could image an fsspec-reader-js that is just a parser for spec and returns either data or a ref tuple for a given key, delegating how/if a data request should be made to someone else. I think for now (since I'll probably be one of few users), it makes sense to keep these together.

As a side note, I'm not super familiar with mustache, but I'm not sure (don't think) expression evaluation is supported. So handing:
  "offset": "{(i + 1) * 1000}"

could be challenging.

Checking whether this in the spec:
{
    "refs": {
         "key0": "data",
    }
}

covers the use case below (here for context):
{
    "key0": "data:application/octet-stream;base64:<array data>"
}

Good point @ajelenak : this is not described. If the only two formats we consider are text (ascii) and b64-binary, then maybe it can be shorter and simpler.

Simpler by avoiding "data:application/octet-stream;base64:"? I think that in cases of specs explicit is better than implicit. But avoiding the data URI part will certainly save some bytes.

Thanks for walking me through that. This was a misunderstanding on my part (re: which functions are allowed via jinja).

I have specified what the "ref" entries should be, and included the possibility that they are whole files (i.e., no offset/length - but we don't need to scan all files to find their lengths).
I thin this can complete the spec, and I can start making the implementation in fsspec as well as a recipe in pangeo-forge ( @rabernat ?).
This whole-file change would account for the grib2 case or small-hdf case, where we suppose there will be a "filter" stage in the zarr loader which takes the bytes, writes them to disc (or BytesIO for HDF), loads and selects data and passes back the numpy buffer.
This meets the intake-informaticslab use case (especially if we have caching, which could be for the original file or the final array buffer). Of course, specifying this (python) function doesn't happen in this JSON spec, it's either contained in the zarr metadata or even in an intake spec. We could have another convention for those, if we like, such as grib2, hdf:tree/var or generic module:func. I don't intend to implement anything like this quite just yet, but we want it to be possible.
cc @tam203 @arh89

Merging today, unless I hear otherwise. This will be followed by implementation in fsspec's ReferenceFileSystem, and then the pangeo-forge recipe (which will depend on fsspec HEAD).

Implementation: https://github.com/intake/filesystem_spec/pull/568
When that's in, I'll go back fsspec_reference_maker.hdf and edit it accordingly, to be called from a pangeo-forge recipe.

Not sure if anyone here is interested, but figured this an appropriate place to share for now (working on a blob post). I have released an JS package on npm that includes a parser for the specification and a valid store implementation for Zarr.js in the browser (relies on http(s) protocol).
package: https://github.com/manzt/reference-spec-reader
example: https://6060eed9dc5ef100075be024--vizarr.netlify.app/?source=https://gist.githubusercontent.com/manzt/436fc2966c484205a2c60824f659b412/raw/cdc69f2ce645d953185f10d7552501bfd459dd12/Vanderbilt-Spraggins-Kidney-MxIF.ome.tif.json&channel_axis=0
The example url is a preview of this PR in vizarr, a viewer for zarr-based images. The reference (v0) was generated via tifffile for an OME-TIFF we host on GCS.

Vizarr is so cool! Can we point it at some climate data?


Handle system errors and show proper error message (WIP)

It fixes #938
How to test
I tested it on my local MacBook Pro by breaking binary, then I got the same behavior.
E.G. create a new file go-spacemesh (instead of original) and make it executable chmod 755 ./node/mac/go-spacemesh
When PR builds will be ready I'm going to test it in the Windows VM, where we originally caught the bug.

It still does not work on Windows 😢
Keep working on it.

Finally, it's ready! 🙌

It also will show proper error messages in case of missing go-spacemesh or any issues with permissions.


Item value generation

This PR adds numerical values to every single vanilla item, for a total of 1100 items. The values are based on around 500 manually set values (4287a3af3b568eafcf37cee328167c6124fa928d) and inferred based on the crafting recipes. A value of -1 means that the item is disabled, usually because it is based on diamonds or can only be obtained in creative.
All the values are generated and stored in intermediate/item_values.yaml for future use. This new folder is uploaded as a build artifact, and you can find a copy of that file here.

Balancing done in https://github.com/gurkult/gurkcraft/pull/2/commits/221dac38fbc81b5c6573eec8443aa4b6f5ab487e

Let's merge? Unless there's anything else you want to add.


VT100 syntax highlighting within source code files

Thanks for this great extension!
It works very well. Unfortunately though, I need an extension that works in combination with other source code highlighting extensions on my source code files.
I created a fork and changed it to fit my needs. But maybe you want to enhance your extension to support this use case natively.
Feel free to close this issue if you're not interested in that. I just wanted to say hi.
https://github.com/dfaust/vscode-vt100-syntax-highlight

Hey @dfaust,
can you give me an example of how the combination looks like?
I've also seen you changed those lines:
 if (backgroundColor != 'default') {
    appliedDecorations.get('background-color-' + backgroundColor)!.push(range);
}
 if (foregroundColor != 'default') {
    appliedDecorations.get('foreground-color-' + foregroundColor)!.push(range);
}

Is that an optimization for speed?
Regards,
Tobias

Here is a screenshot of my patched vscode-vt100-syntax-highlight version in combination with rust-analyzer.

I changed the lines you mentioned in order to not override the Rust syntax highlighting. Otherwise everything but the VT100 text is just white.

Hey @dfaust,
I've integrated your feature into the extension.
However, there were some problems that I had to work around:
The highlighting is not based on the underlying grammar of the language.
This means that in most cases the highlighting just works.

However, when the escape sequence is not terminated then the rest of the documented will be highlighted, independent of the termination of the string / comment. Therefore, I included an include / exclude option to the extension to enable / disable highlighting for specific languages to not interfere with the editor when undesired. The new version will be available soon.

Best Regards,
Tobias Faller


Search within a podcast for an episode

It would be cool if it would be possible to search within a podcast for a certain episode.

Indeed. I will add this functionality.

@probonopd, I've added this functionality in commit f63a18e and it is part of (pre)release 1.9.9 which will be available as soon as it's done building.


Settings - General Page - Accessibility Issues

📝 Provide detailed reproduction steps (if any)
Run Windows Accessibility Insights on PowerToys Settings General Page.
✔ Expected result

PT Settings must be accessible

❌ Actual result
Code/Property Related tests
Two of the automated check fail.

Link to Accessibility insights file - https://microsoft.sharepoint.com/:u:/t/Notes145/EfgNE--B2_pKlPmBuNFlvk8B-55nQZm6CKxy77I1QhW7Dw?e=dzPtdJ.
Tabbing tests

On comparing and contrasting this with the windows tabbing setting, the following issues are identified -

The individual powertoys tabs, such as color picker, fancyzones etc are not accessible by the keyboard. Ideally we would want to tab into one of the elements on the left panel and then use the arrow keys for navigating across the different powerToys.
We have three radio buttons for the various themes, but we can tab into only the first radio button and not navigate to the other items using arrow keys which is not expected behavior.

The following gif shows how windows handles tabbing.

Screen Reader

When we use the screen reader with a set of radio buttons under a heading, then it is expected to read the heading as well as the content of the button. (This can be easily tested with any windows settings page). However, with PT settings, only the selected item is read such as in the Settings theme, when we have the Dark radio button on focus, the Settings theme text is not read which makes it difficult to understand the complete functionality of the radio button.
The same holds good even with version, it just reads v0.20.1 but does not say the word version.
When we have the focus on , we would also want it to read the warning above it, otherwise a visually impaired user would not be aware that there is some setting which has been turned off because we are not running as admin. (Edit: It is read out when we press Insert+B and other than the image all enabled text is read as expected).
This information is read out on pressing Insert+B. However, the we must provide some information about the image as just the word graphic is being read out now.

Contrast issues
These items do not meet the contrast threshold standard while testing using Accessibility insights -

@niels9001, I've been looking into the tab related accessibility issue for the settings page. The expected behavior for a group of radio buttons is to tab into the selected item and then use the arrow keys for up and down navigation as shown in the gif below.

However, with the powerToys settings page, I'm able to tab into the group of radio buttons but not navigate using arrow keys as shown above.
The arrow navigation is built in by default into the radiobuttons control. Do you have any idea as to why this might be happening?
Adding @laviusmotileng-ms.

update: The two failures that we see with the code/property related checks regarding the on screen property must not have a null bounding property is due to xaml islands. The two pane elements are throwing that error and there is nothing that can be done from our side as they are components which do not have a bounding property. We would no longer face this issue once we switch to winui 3.0.

@alekhyareddy28 Hmm, no idea - is that a XAML Island bug as well?
What we could do, is simply replace the theme selection radiobutton group with a ComboBox. It would save us some space as well.

update: @niels9001, it seems like a xaml island bug. I created a simple xaml island project with just a radiobuttons control with three radio button controls and the keyboard navigation does not work as expected. However, the following code works in a standalone uwp app.
<UserControl
    x:Class="Microsoft.PowerToys.Settings.UI.Views.ShellPage"
    xmlns="http://schemas.microsoft.com/winfx/2006/xaml/presentation"
    xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml"
    xmlns:d="http://schemas.microsoft.com/expression/blend/2008"
    xmlns:mc="http://schemas.openxmlformats.org/markup-compatibility/2006"
    xmlns:behaviors="using:Microsoft.PowerToys.Settings.UI.Behaviors"
    xmlns:winui="using:Microsoft.UI.Xaml.Controls"
    xmlns:helpers="using:Microsoft.PowerToys.Settings.UI.Helpers"
    xmlns:views="using:Microsoft.PowerToys.Settings.UI.Views"
    xmlns:ic="using:Microsoft.Xaml.Interactions.Core"
    xmlns:i="using:Microsoft.Xaml.Interactivity"
    xmlns:muxc="using:Microsoft.UI.Xaml.Controls"
    mc:Ignorable="d">

    <Grid>
        <muxc:RadioButtons>
            <RadioButton>Item 1</RadioButton>
            <RadioButton>Item 2</RadioButton>
            <RadioButton>Item 3</RadioButton>
        </muxc:RadioButtons>
    </Grid>
</UserControl>

@crutkas suggested to create a new issue for xaml island related bugs instead of modifying the ui as they would be fixed in a few months time once we transition to winui 3.

We should file a bug against the WinUI repository and link to this bug.
Lets create a new issue for us for WinUI 3 upgrade for settings as well and reference this as well

Update: When i was trying to fix one of the screen reader issues when the title of the radio buttons was not being read (ie. the screen reader was only reading 'Dark' and not Settings theme, i came across this microsoft accessibility insights article which suggested we use stack panel and group the items. I tried to do a similar thing with the radio buttons control and it did not work. There is no user facing change as well.
Before:
After: Key navigation works as expected and even the heading Settings theme is being read by the narrator.

Created an issue in the winui repo: RadioButtons control does not support keyboard navigation in XAML islands microsoft/microsoft-ui-xaml#3156
#6032 is the tracking issue for accessibility issues related to xaml islands.

update: The contrast related issues are off the threshold by a very small value 0.002. We are using the system brushes so there is little for us to do there. The rest of the issues are fixed in the above PR.


Skip Reduced Precision Testing

OpenCL versions before 2.0 do not have precision requirements for
reduced precision math.

Skip reduced precision testing for devices with
versions < 2.0.

Do you have any thoughts on this PR @kpet, it'd be good to get it in?

The change looks good. A few comments:

This behaviour is not documented in the unified spec. I remember we discussed creating an issue for this but I couldn't find it. @alycm Have I missed something?
Technically the relaxed requirements are linked to -cl-unsafe-math-optimizations and not -cl-fast-relaxed-math. The latter implies the former, so the code is correct but doesn't represent the spec as closely as possible. I don't think we need to change it here though.
We could introduce a feature later and plug this into the framework if we wanted but we'd need substantial changes to how the test is structured (so we can skip parts of the test). Not worth the time with the current state of things I think.

This behaviour is not documented in the unified spec. I remember we discussed creating an issue for this but I couldn't find it. @alycm Have I missed something?

That's because the ULP tables are in the OpenCL C spec, but I've still filed an issue about it (https://github.com/KhronosGroup/OpenCL-Docs/issues/340) as I'd like to get that sorted out soon as well.  So currently in terms of documentation it's their absence from the description of OpenCL C 1.2 (in the OpenCL 1.2 spec) that is important -- but obviously we can do better than that for documenting it.
The fact that these kernels are not compiled with -cl-std=CL2.0 did set off a thought process that is covered in that ticket, but it's a bit of a rabbit hole that I don't think need to affect this PR.

That's because the ULP tables are in the OpenCL C spec [...]

I know that ;). I did check the 1.2 spec and latest unified spec as part of reviewing this change. I made the comment to make sure that we capture the need to document the 1.2/post-1.2 difference in the unified spec since we decided that we want to cover all versions of OpenCL there. Having https://github.com/KhronosGroup/OpenCL-Docs/issues/340 is enough for me, thanks. Since this change is simple and has been in review for a long time, I'll merge it straight away.

Thanks :)


Cant compile, help pls

Hello,
i want to try out this fork, but i cant compile. I am probably missing some libs, can anyone help me out? I added the libs in the wiki, but somehow its not working.
i get this error,
C:\Users\Documents\ESP8266\Glowballs\McLighthingV3\McLighting-master\McLighting-master\Arduino\McLighting\McLighting.ino: In function 'void loop()':
McLighting:726: error: 'handleE131Play' was not declared in this scope
 if (playE131 == true) { handleE131Play(); }

                                        ^

exit status 1
'handleE131Play' was not declared in this scope
thanks

This seems not to be a library problem.
The function is declared in "mode_custom_ws2812fx_animations.h"
Which Arduino Version do you use?

"'handleE131Play' was not declared in this scope"
i had the same issue just before with " initMQTT();" and not in scope
i just added          void  initMQTT(void);        to definition.h and it was working ( just as a "walk " around )
Just check what     handleE131Play (); has as return value ( uint8_t or something else ) and check what is input ( i think its void )
and write the so called called fuctionprototype into .h file
( ive just looked into the files, in this project as from VSCode loaded  there is no handleE131Play function, so maybe you have a newer version of E131 Lib)

My bad, i commented out the CUSTOM_WS2812FX_ANIMATIONS part in definitions.h, but thanks for the help.


Add missing return for when topic isn't found

Add missing return to DeleteTopic API when the topic is not found.

Please send backport


feat: Transformable Text

The text has a rectangular background, can be dragged, size can be increased and decreased.
Your checklist for this pull request
🚨Please review the guidelines for contributing to this repository.

[X] Make sure you are requesting to pull a topic/feature/bugfix branch (right side). Don't request your default branch!
[X] Make sure you are making a pull request against the default branch (left side). Also you should start your branch off default branch.
[X] Check the commit's or even all commits' message styles matches our requested structure.
[X] Check your code additions will fail neither code linting checks nor unit test.
[X] I have added necessary documentation (if appropriate)

Description
The text has a rectangular coloured background, can be dragged, rotated,  size can be increased and decreased. It can also be selected and deselected.
❤Thank you!
Post merge checklist

[ ] Follow steps from the guidelines for contributing to this repository.
[ ] If you are a new contributor, ping in the thread and one of the maintainers will add you to all-contributors list.

@Sonakshi1901 You can pull the main from upstream and get those changes as well. Accordingly you can make changes to your work.


Add Promises interface

There have been numerous requests for a Promises interface for this module. Adding this interface in addition to the err-back will hopefully simplify the use of this module. The existing API will still be supported but we will use Promises for examples.

[ ] Define new interface API
[x] Add a promises interface alongside the existing API
[x] Ensure test coverage
[ ] Update readme and examples

Promises interface available in 0.9.0. This ticket will track a more strategic approach to the API and the documentation for the same.


Docs update - add operator steps to the metric page

Description
This PR adds required changes for the metrics page to support an Operator installation.
Update: Services are now headless. (Thanks to @fasaxc for explanation)
Add: Tabs added to the document to split manifest and Operator resources.
Update: Promethues config updated to get rid of typha-client discovery. (reported by Daniel Carroll in slack)
Add: API-server friendly commands to the document.
Related issues/PRs
https://calicousers.slack.com/archives/CPTH1KS00/p1639154366343900
Todos

[ ] Documentation

Release Note
None required

I have been told: "third time's a charm". :grin:
@caseydavenport


Matrix alertbot-manager

https://github.com/moan0s/alertbot

https://matrix-org.github.io/matrix-hookshot/latest/setup/webhooks.html
?


Issue 26 related to #26

:tada: This PR is included in version 1.9.3 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


chore: update fs-extra to 4

To reduce client node_modules size.
note: I am going to send number of PR and so, when this PR will be accepted, you can postpone publish to npm until all PR will be not accepted.

Totally didn't show up in my notifications till just now 😕
Overally looks fair enough, looked at the changelogs for all bumped modules and it looks OK.  One concern it the adoption of yarn.  No other core repositories (electron, electron-prebuilt, etc.) have adopted yarn yet and in general lock files don't work well cross-platform (so electron dev with yarn is kinda not working too well).  This might just need to be a discussion we have somewhere that says "should we use it".  But for now, if we remove it from this PR I'm happy to approve it.

I just want to speedup installation on CI (according to my experience, yarn works better than npm without global cache (cache on CI doesn't make any sense)). But of course — it depends and for this project doesn't matter. Removed.

didn't show up in my notifications till just now

Yeach... Still no luck to get rid of electron-download-tf because when one my PR is accepted, I need to apply another one :(

@malept Yarn is used only on CI server and doesn't impact local users. yarn.lock removed.

@develar Only thing blocking this rn is the yarn stuff which we don't want to adopt here without a broader discussion, it might make tests slightly faster but it also results in different testing conditions to those people using npm.
A wider discussion needs to be had about supporting yarn with -userland modules, in particular things like cross-platform lock files need to be talked about.  But this PR isn't the place for that, happy to merge this once yarn is moved out and we can open a discussion issue somewhere else RE yarn.

@MarshallOfSound Thanks a lot for breaking the silence. yarn removed on CI servers.

@develar Second time the build timed out on macOS, I reran it the first time.  Any ideas whether the fs bump could have caused the hang?
https://travis-ci.org/electron-userland/electron-download/jobs/270780729

@MarshallOfSound It was ok 16 days ago (and when PR was submitted). I will check.

Stability — electron-builder uses electron-download-tf (this PR and #60 and not yet filed muon support). So, it is widely tested already.


ImportError: ../libmkl_gnu_thread.so: invalid ELF header

I'm submitting a ...

[X] bug report
[ ] feature request

What is the current behavior?
Please describe the current behavior of the WebShop app or agent

After all the installation and when I try to run ./run_dev.sh, I get the following error:

Traceback (most recent call last):
  File "/home/juyoung/.conda/envs/webshop/lib/python3.8/runpy.py", line 193, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "/home/juyoung/.conda/envs/webshop/lib/python3.8/runpy.py", line 86, in _run_code
    exec(code, run_globals)
  File "/home/juyoung/webshop/web_agent_site/app.py", line 14, in <module>
    from web_agent_site.engine.engine import (
  File "/home/juyoung/webshop/web_agent_site/engine/engine.py", line 16, in <module>
    from pyserini.search.lucene import LuceneSearcher
  File "/home/juyoung/.conda/envs/webshop/lib/python3.8/site-packages/pyserini/search/__init__.py", line 19, in <module>
    from .lucene import JLuceneSearcherResult, LuceneSimilarities, LuceneFusionSearcher, LuceneSearcher
  File "/home/juyoung/.conda/envs/webshop/lib/python3.8/site-packages/pyserini/search/lucene/__init__.py", line 18, in <module>
    from ._impact_searcher import JImpactSearcherResult, LuceneImpactSearcher
  File "/home/juyoung/.conda/envs/webshop/lib/python3.8/site-packages/pyserini/search/lucene/_impact_searcher.py", line 28, in <module>
    from pyserini.encode import QueryEncoder, TokFreqQueryEncoder, UniCoilQueryEncoder, \
  File "/home/juyoung/.conda/envs/webshop/lib/python3.8/site-packages/pyserini/encode/__init__.py", line 17, in <module>
    from ._base import DocumentEncoder, QueryEncoder, JsonlCollectionIterator,\
  File "/home/juyoung/.conda/envs/webshop/lib/python3.8/site-packages/pyserini/encode/_base.py", line 19, in <module>
    import faiss
  File "/home/juyoung/.conda/envs/webshop/lib/python3.8/site-packages/faiss/__init__.py", line 18, in <module>
    from .loader import *
  File "/home/juyoung/.conda/envs/webshop/lib/python3.8/site-packages/faiss/loader.py", line 65, in <module>
    from .swigfaiss import *
  File "/home/juyoung/.conda/envs/webshop/lib/python3.8/site-packages/faiss/swigfaiss.py", line 13, in <module>
    from . import _swigfaiss
ImportError: /home/juyoung/.conda/envs/webshop/lib/python3.8/site-packages/faiss/../../.././libmkl_gnu_thread.so: invalid ELF header

FYI, I downloaded Java like this: sudo apt install openjdk-11-jdk.

Steps to Reproduce
If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem

I first confronted this error in my environment, so I tried to use a docker image python:3.8.13-slim to see if this error can be reproduced. And I get a similar error, too:

Traceback (most recent call last):
  File "/usr/local/envs/webshop/lib/python3.8/runpy.py", line 194, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "/usr/local/envs/webshop/lib/python3.8/runpy.py", line 87, in _run_code
    exec(code, run_globals)
  File "/usr/src/app/webshop/web_agent_site/app.py", line 14, in <module>
    from web_agent_site.engine.engine import (
  File "/usr/src/app/webshop/web_agent_site/engine/engine.py", line 16, in <module>
    from pyserini.search.lucene import LuceneSearcher
  File "/usr/local/envs/webshop/lib/python3.8/site-packages/pyserini/search/__init__.py", line 19, in <module>
    from .lucene import JLuceneSearcherResult, LuceneSimilarities, LuceneFusionSearcher, LuceneSearcher
  File "/usr/local/envs/webshop/lib/python3.8/site-packages/pyserini/search/lucene/__init__.py", line 18, in <module>
    from ._impact_searcher import JImpactSearcherResult, LuceneImpactSearcher
  File "/usr/local/envs/webshop/lib/python3.8/site-packages/pyserini/search/lucene/_impact_searcher.py", line 28, in <module>
    from pyserini.encode import QueryEncoder, TokFreqQueryEncoder, UniCoilQueryEncoder, \
  File "/usr/local/envs/webshop/lib/python3.8/site-packages/pyserini/encode/__init__.py", line 17, in <module>
    from ._base import DocumentEncoder, QueryEncoder, JsonlCollectionIterator,\
  File "/usr/local/envs/webshop/lib/python3.8/site-packages/pyserini/encode/_base.py", line 19, in <module>
    import faiss
  File "/usr/local/envs/webshop/lib/python3.8/site-packages/faiss/__init__.py", line 16, in <module>
    from .loader import *
  File "/usr/local/envs/webshop/lib/python3.8/site-packages/faiss/loader.py", line 65, in <module>
    from .swigfaiss import *
  File "/usr/local/envs/webshop/lib/python3.8/site-packages/faiss/swigfaiss.py", line 13, in <module>
    from . import _swigfaiss
ImportError: libmkl_intel_lp64.so.1: cannot open shared object file: No such file or directory

It seems like there are some issues with pyserini and faiss for me, but there are no issues about this. Can you help me with set up process?

What is the expected behavior?
Please describe the desired behavior of the WebShop app or agent
Motivation for Change
What is the motivation / use case for changing the behavior?
Please tell us about your environment:

Version: 2.0.0-beta.X
Browser:
Language:

Hello, I'm facing the same issue when running run_dev.sh. Did you find a way to solve it ? Are there any updates on this one ?

I'm facing the same issue while running the setup.sh, and it cannot find the intel mkl library. I wonder if it's because I'm using an apple m2 chip instead of an intel one?

I resolved this issue by referring to https://github.com/facebookresearch/faiss/issues/2890


fix(icon): add part attribute for CSS overrides

Add part attribute to SVG element so parent components can override styles using the ::part(kd-icon-part) pseudo-element selector.
This can be used to resize the icon per breakpoint from the CSS of a parent component.

@dennisdolliver Can this be merged?

There is already a sizeOverride property, but you should not actually change the size of an icon since Carbon provides different versions at specific sizes. Better to use one size of icon at all breakpoints, or import multiple icons if you absolutely need multiple sizes.

Ok cool. I'll close this since I didn't realize Carbon had icons for specific sizes.


mercurial: 4.9.1 -> 5.2.1 + python3  🚀

Motivation for this change
Get python2 out of my nix profile
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Notify maintainers
cc @

fixed

I don't object this merge. There are problems with tortoisehg which may be fixed in further PRs:

tortoisehg is now slower. Startup, repo opening, any operation. I don't quite understand why. Is it because of Qt5?
iniparse package isn't found at runtime. To reproduce, open File->Settings. It is not critical though


parser: fix hint parsing in select /*+ max_execution_time */ 1 (#366)

Cherry-pick https://github.com/pingcap/parser/pull/366

PTAL @jackysp @kennytm @lysu

release-3.0 branches maybe need be protected

I'll do it @lysu


HDFS-17139. Modify the comments of the class RouterAdminProtocolTranslatorPB

Description of PR
The java doc of the class RouterAdminProtocolTranslatorPB describes the class ClientNamenodeProtocolTranslatorPB
How was this patch tested?
For code changes:

[x] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
[ ] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
12m  4s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
42m 19s

trunk passed

+1 :green_heart:
compile
0m 44s

trunk passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
compile
0m 40s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
checkstyle
0m 32s

trunk passed

+1 :green_heart:
mvnsite
0m 45s

trunk passed

+1 :green_heart:
javadoc
0m 44s

trunk passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
javadoc
0m 31s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
1m 29s

trunk passed

+1 :green_heart:
shadedclient
33m  1s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 31s

the patch passed

+1 :green_heart:
compile
0m 33s

the patch passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
javac
0m 33s

the patch passed

+1 :green_heart:
compile
0m 30s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
javac
0m 30s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 20s

the patch passed

+1 :green_heart:
mvnsite
0m 34s

the patch passed

+1 :green_heart:
javadoc
0m 29s

the patch passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
javadoc
0m 26s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
1m 19s

the patch passed

+1 :green_heart:
shadedclient
32m 45s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
21m  9s

hadoop-hdfs-rbf in the patch passed.

+1 :green_heart:
asflicense
0m 39s

The patch does not generate ASF License warnings.

156m 11s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5917/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5917

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 0ecc13e38488 4.15.0-212-generic #223-Ubuntu SMP Tue May 23 13:09:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 6500d4bf9088caa5a14407764df578dac09eaee8

Default Java
Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5917/1/testReport/

Max. process+thread count
2656 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project/hadoop-hdfs-rbf

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5917/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 36s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
43m 20s

trunk passed

+1 :green_heart:
compile
0m 42s

trunk passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
compile
0m 40s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
checkstyle
0m 35s

trunk passed

+1 :green_heart:
mvnsite
0m 41s

trunk passed

+1 :green_heart:
javadoc
0m 43s

trunk passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
javadoc
0m 32s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
1m 21s

trunk passed

+1 :green_heart:
shadedclient
37m 31s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 35s

the patch passed

+1 :green_heart:
compile
0m 37s

the patch passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
javac
0m 37s

the patch passed

+1 :green_heart:
compile
0m 32s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
javac
0m 32s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 20s

the patch passed

+1 :green_heart:
mvnsite
0m 36s

the patch passed

+1 :green_heart:
javadoc
0m 34s

the patch passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
javadoc
0m 26s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
1m 35s

the patch passed

-1 :x:
shadedclient
43m 45s

patch has errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
30m 42s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs-rbf.txt
hadoop-hdfs-rbf in the patch passed.

-1 :x:
asflicense
0m 41s
/results-asflicense.txt
The patch generated 17 ASF License warnings.

171m 51s

Reason
Tests

Failed junit tests
hadoop.fs.contract.router.TestRouterHDFSContractDelegationToken

hadoop.fs.contract.router.TestRouterHDFSContractConcatSecure

hadoop.fs.contract.router.TestRouterHDFSContractRename

hadoop.fs.contract.router.TestRouterHDFSContractOpen

hadoop.fs.contract.router.TestRouterHDFSContractMkdirSecure

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5917/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5917

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 50ee17afe3f3 4.15.0-212-generic #223-Ubuntu SMP Tue May 23 13:09:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / c3ec399cef068c16e8b3b318a4c335c06efaa9b8

Default Java
Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5917/2/testReport/

Max. process+thread count
1813 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project/hadoop-hdfs-rbf

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5917/2/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 42s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
45m 38s

trunk passed

+1 :green_heart:
compile
0m 44s

trunk passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
compile
0m 38s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
checkstyle
0m 36s

trunk passed

+1 :green_heart:
mvnsite
0m 56s

trunk passed

+1 :green_heart:
javadoc
0m 48s

trunk passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
javadoc
0m 32s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
1m 34s

trunk passed

+1 :green_heart:
shadedclient
35m 24s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 32s

the patch passed

+1 :green_heart:
compile
0m 33s

the patch passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
javac
0m 33s

the patch passed

+1 :green_heart:
compile
0m 31s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
javac
0m 31s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 21s

the patch passed

+1 :green_heart:
mvnsite
0m 33s

the patch passed

+1 :green_heart:
javadoc
0m 30s

the patch passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
javadoc
0m 26s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
1m 18s

the patch passed

+1 :green_heart:
shadedclient
33m 10s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
21m  4s

hadoop-hdfs-rbf in the patch passed.

+1 :green_heart:
asflicense
0m 40s

The patch does not generate ASF License warnings.

151m 43s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5917/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5917

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 174c1971657d 4.15.0-212-generic #223-Ubuntu SMP Tue May 23 13:09:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 8668ab2505ed6e10ff13aac4063f72bc85e605e9

Default Java
Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5917/3/testReport/

Max. process+thread count
2610 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project/hadoop-hdfs-rbf

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5917/3/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

no new tests are needed for this patch.

@goiri If no more comments here, please help merge it, thanks


Error align center navbar with material theme

Hi guys, i've a problem with navbar and the text alignment. The point is that with material theme the text doesn't align properly, and all text overlaps. How can i fix this ?
And in general, the sliding transition with material theme doesn't works properly too.

Example, screenshot or something more clear to understand?

Sorry, the sliding effect that with ios theme works, with material theme doesn't. So, there will be some updating for material theme too ?

Look at Material theme guides and tutorials on website. There is no sliding effect in Material theme

Ok, i'm saying that would be nice to have that effetct on material. Btw, it doesn't matter. Thanks.

Why this ticket has been closed?
If you simply take the Basic Android/Material App Layout proposed in the docs and try to add left, center and right elements in the navbar it doesn't work properly:

      Left Link

Awesome App

       Right Link

will result in:

If I remove left and right links then everything is ok.

I know but the name goes to the left and not on center. Btw thanks for info

Sorry, maybe I was not clear but I think this issue should not be closed.

@coorasse "center" element on Material theme should stick to the left side

By specification? If so, do you have a link to that specific please? I tried to Google a little bit about it but I can't find anything about this topic.

https://www.google.com/design/spec/layout/structure.html

Cool, thanks. I still think "center" class is leading to misunderstanding but I hope this conversation will be helpful for someone else.

Thanks . it saved me hours of frustration.

But for some reason for me it's like this...

my code:

```

@rajabilal555 Had the same issue as you and found this to be the solution.


Upgrade to hyp3lib v2

This PR will upgrade to hyp3lib v2, which downloads orbit files from the new https://dataspace.copernicus.eu/ and requires that the appropriate credentials be provided.
TODO:

[x] Modify environment.yml to install hyp3lib with pip or push the latest release to https://anaconda.org/conda-forge/hyp3lib
[x] Pass esa_credentials wherever downloadSentinelOrbitFile is called.
[x] Update README examples
[x] Update tests
[x] Update notebooks
[x] Find occurrences of EARTHDATA_USERNAME or --username for places that we may need to include the ESA credentials options as well
[x] Validate changes on some sample jobs
[x] Add Changelog entry
[x] Address remaining TODO items in the code

I ran the job specified in sample_run.sh and the outputs look great. You can download the resultshere.

Hey Forrest and Joe.
Thank you for doing this! Know the notebook tests were a pain (maybe that's an understatement...).
Anyways, want to learn more about monkeypatch.context and other nice testing you both provide some templates. So grateful for your participation!


[Bug]: Input widget issues

Is there an existing issue for this?

[X] I have searched the existing issues

Description

Error message when Default Text has more characters than the Max Chars is incorrect. It should be: Default Text length must be less than or equal to Max Chars allowed.

If a user enters some text in the widget and then sets a Max Chars such that it is less than the initial text entered, no error is thrown. (This is reproducible in release. Works fine in prod)
https://www.loom.com/share/1b94a690ce674008ac909f9dc6eb1ba1

Steps To Reproduce

D&D an Input widget.

Public Sample App
No response
Version
Cloud

@jnikhila can you provide copy for the given content

Default Text length must be less than or equal to Max Chars allowed

@shadabbuchh for the 2nd point

The error is not visible to the app viewers since they will not have access to the property pane
The field is not dirty, Does it trigger the error once you make a small change focus & blur the input? How is the behaviour different in Prod and Release?

cc @souma-ghosh

@somangshu - I think it will be helpful to users if we tell them what the current max chars limit is and how many characters they have exceeded. In which case, the users will be able to reword the data.
Below are a few messages that we can use:
Message 1 - The entered text exceeds the MaxChars limit of <AllowedNumberOfChars> characters by <TheExceededChars> characters.
For example, message 1: "The entered text exceeds the MaxChars limit of 150 characters by 20 characters."
Message 2 - You have exceeded the <MaxChars> characters limit for the <Field_Name> field by <TheExceededChars> characters.
For example, message 2: "You have exceeded the 150 characters limit for the input1 field by 20 characters."
Message 3 - The <Field_Name> field has a max length of <MaxChars> characters, and you have exceeded it by <TheExceededChars> characters.
For example, message 3: The input1 field has a max length of 150 characters, and you have exceeded it by 20 characters.
Note - I've assumed the data in the angular brackets can be populated at runtime. Please let me know if that's not the case.

The field is not dirty, Does it trigger the error once you make a small change focus & blur the input? How is the behaviour different in Prod and Release?

@somangshu in Prod when some text is entered in the Input widget and then the Max Chars is set, we instantly see an error if the entered text has more characters that the max limit. However I am not able to see this behaviour in release.

@shadabbuchh @jnikhila On further looking into the issue I have a different POV now.
This issue only occurs when the default text is bigger than the max char allowed, that mean the app viewer has no control over this, I think ideally the error should be shown on the property pane itself.
Hence the error show to the end user today is invalid. Do you guys agree?
cc @dilippitchika need you inputs here

Prod when some text is entered in the Input widget and then the Max Chars is set, we instantly see an error if the entered text has more characters that the max limit. However I am not able to see this behaviour in release.

@shadabbuchh I think the end user cannot enter text more than the allowed char size even if they copy paste some text directly

@shadabbuchh and @somangshu
Ideally, it should not allow the user to enter more chars than the max chars. However, the user can enter more characters than the max chars set in the default text as shown below:

I do agree that a message gives more clarity to user and I guess it'll be more convenient for user to see the field highlighted with error and error message shown on the editor. We can also display the error on the property pane.

Yes that is the only way, The default text can be bound to an API that results in longer text and hence leave the input field in an invalid state. In case the field is in a form, the submit action would be disabled because of this invalid field, So it's obvious that the error need to be shown to the end user as well.
Additionally, I agree that the error should also be should on the default text property.
cc @dilippitchika

A few things

@jnikhila we can't use 2 or 3 as the error messages, app viewer doesn't know what Input 1 is.
Agreed with the fact that we should show the error message on default text as well

So we need an error message in 2 places

The input widget itself
The default text field

Agreeing with @somangshu on this

@dilippitchika - Do you mean that the field names can't be evaluated at runtime?
But then, can the values for<AllowedNumberOfChars>and <TheExceededChars> be derived at runtime.
Message 1 - The entered text exceeds the MaxChars limit of <AllowedNumberOfChars> characters by <TheExceededChars> characters.
For example, message 1: "The entered text exceeds the MaxChars limit of 150 characters by 20 characters."

The above message we can use, also message 1 will be really long. Are you sure you want to use this?

@dilippitchika - We can reword message 1 to be a bit shorter -
Message 1 - The entered text exceeds the <AllowedNumberOfChars> characters limit by <TheExceededChars> characters.
For example, message 1: "The entered text exceeds the 150 characters limit by 20 characters."

Correction: Issue 2 exists on prod as well.

@somangshu as discussed I have created a separate bug https://github.com/appsmithorg/appsmith/issues/14886 for the following issue:

If a user enters some text in the widget and then sets a Max Chars such that it is less than the initial text entered, no error is thrown.

@jnikhila this works, thanks


Alphabetical sorting

I went through the pages of all controls, and carefully took time to sort all the properties/events alphabetically. This will help the docs be better organized and hence make searched properties easy to find. Alphabetical sorting is very common in popular documentations.
If this PR is merged, everyone updating (making a PR to) this repo (adding new properties or controls) should also try his/her best to sort alphabetically... for consistency everywhere.
I also made some very minor fixes along the line: updated some code blocks and fixed some typos
It might not be an easy task for anyone reviewing my changes, so I propose to check the total number of lines in each of the files I touched/modified. Because I wasn't adding anything new, the total number of lines in each modified file before and after my PR should definitely be equal. (some have a slight diff of one because of removal or addition of the/a last line(whiteline? whitespace?))
You could even try deploying a test website as you used to do, so we could better have a look at the changes.
Let me know how you find my idea, or if there is any issue. :)

Indeed, trying to diff changes is completely pointless :)
I'll configure a test branch.

Alright. 👍🏾

I've checked PR locally. Looked good to me!
Fantastic work! How did you do that? Manually?! :)

Yes, manually to minimize mistakes.
I had all the ascii letters on the side, as reference for quick sorting.


Support Hashed Column

For categorical features, in Shifu if > 5000 categories feature will be cut off to 5000. While for features has > 5000 or very large categories, a typical hashed function can be used to reduce large categories to small hashed-size categories, check below tensorflow for more details:
https://www.tensorflow.org/guide/feature_columns#hashed_column
This issue is to support such hashed column in Shifu.

Same as this issue: https://github.com/ShifuML/shifu/issues/171

https://booking.ai/dont-be-tricked-by-the-hashing-trick-192a6aae3087


PATH env variable not set after global install

Node Version: node v10.5.0 - nmp 6.1.0
Platform: Windows 10 Pro (1803)

Installed node-gyp using npm install -g node-gyp in CMD with administrative rights, but node-gyp is not set as a PATH env variable
No errors, no warnings

A little more info
I had my Windows reinstalled and dragged and dropped all my user files (that includes all npm packages and configs) into the freshly installed user folder.
I now uninstalled NodeJs and deleted all of npm, reinstalled everything including node-gyp. The env variable seems to be set now.

npm installs commands (node-gyp.cmd in this case) in a location that is added to the PATH by the Node installer. If you did not install Node on a new box, the PATH was not set up properly.


[crc-support] windows download bundle failure

ssh connection time out during download bundle.
The shasum check of bundle didn't execute. And there is no failure of the download task.
log:
Directory: C:\Users\crcqe\OpenshiftLocal\bundle
Mode                 LastWriteTime         Length Name
d----           12/5/2024  5:52 AM                4.17.7
% Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
Dload  Upload   Total   Spent    Left  Speed
0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100   295  100   295    0     0   1136      0 --:--:-- --:--:-- --:--:--  1147
100   399  100   399    0     0    618      0 --:--:-- --:--:-- --:--:--   618
% Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
Dload  Upload   Total   Spent    Left  Speed
0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100   315  100   315    0     0   1264      0 --:--:-- --:--:-- --:--:--  1275
0 5202M    0 31953    0     0  43756      0 34:38:03 --:--:-- 34:38:03 43756
0 5202M    0 3343k    0     0  1906k      0  0:46:34  0:00:01  0:46:33 3238k
0 5202M    0 18.3M    0     0  6763k      0  0:13:07  0:00:02  0:13:05 9157k
……
8 5202M    8  420M    0     0  14.1M      0  0:06:07  0:00:29  0:05:38 17.6M
8 5202M    8  435M    0     0  14.2M      0  0:06:05  0:00:30  0:05:35 15.9M
8 5202M    8  452M    0     0  14.3M      0  0:06:03  0:00:31  0:05:32 16.0M
9 5202M    9  469M    0     0  14.3M      0  0:06:01  0:00:32  0:05:29 16.5Mclient_loop: send disconnect: Broken pipe
ssh: connect to host windows-crcqe.tpb.lab.eng.brq.redhat.com port 22: Connection timed out
ssh: connect to host windows-crcqe.tpb.lab.eng.brq.redhat.com port 22: Connection timed out
ssh: connect to host windows-crcqe.tpb.lab.eng.brq.redhat.com port 22: Connection timed out
ssh: connect to host windows-crcqe.tpb.lab.eng.brq.redhat.com port 22: Connection timed out
ssh: connect to host windows-crcqe.tpb.lab.eng.brq.redhat.com port 22: Connection timed out
ssh: connect to host windows-crcqe.tpb.lab.eng.brq.redhat.com port 22: Connection timed out
ssh: connect to host windows-crcqe.tpb.lab.eng.brq.redhat.com port 22: Connection timed out
Warning: Permanently added 'windows-crcqe.tpb.lab.eng.brq.redhat.com' (ED25519) to the list of known hosts.
Path
C:\Users\crcqe
Warning: Permanently added 'windows-crcqe.tpb.lab.eng.brq.redhat.com' (ED25519) to the list of known hosts.
/Users/crcqe/OpenshiftLocal/bundle/4.17.7

And there is no failure of the download task.

Connection timed out

This looks like a network failure to the nodes, which can also explain the disconnection/failure of the download.

When the script met ssh timeout, my connection to machine also closed:

PS C:\Users\crcqe> Read from remote host windows-crcqe.tpb.lab.eng.brq.redhat.com: Connection reset by peer
Connection to windows-crcqe.tpb.lab.eng.brq.redhat.com closed.
client_loop: send disconnect: Broken pipe


Ditch Pipenv for pip-tools

Pipenv was nice at first for all our projects, but with time has shown
its warts with dependency-updating behaviour that's hard to reason
about and slowness or outright failure to resolve dependencies.
Using this project as an example and trial case for other projects,
switch to using pip-tools to manage a requirements.in file which is
compiled to a fully-specified requirements.txt file.  The
requirements.txt file is then installed into a vanilla virtualenv
located in .venv/.
There are some rough edges in pip-tools, notably around VCS dependency
support, but pip-tools is being actively developed and is tracking these
issues.
The versions of our deps are constrained to the same versions as were in
Pipfile.lock to avoid upgrading them with this change.  We can remove or
update the constraints in the future to upgrade them.

See also https://github.com/seattleflu/backoffice/pull/101.

Requesting another review or two since this is a decent change to our dev tools.

Reasonable for us to try another tool, if it can solve some of the pain points. When you were using it, did you find pip-tools operations to be faster generally than pipenv? (I imagine it can't be slower than pipenv updates.)
This looks like a good first trial pass. It would be interesting to see how pip-tools works with other projects with more, or more complex, dependencies. Like that id3c pipenv issue we had https://github.com/seattleflu/id3c-customizations/commit/548ffb49460ef8a5f812f58963fe90acfbb0ee32

Reasonable for us to try another tool, if it can solve some of the pain points. When you were using it, did you find pip-tools operations to be faster generally than pipenv? (I imagine it can't be slower than pipenv updates.)
This looks like a good first trial pass. It would be interesting to see how pip-tools works with other projects with more, or more complex, dependencies. Like that id3c pipenv issue we had https://github.com/seattleflu/id3c-customizations/commit/548ffb49460ef8a5f812f58963fe90acfbb0ee32

When you were using it, did you find pip-tools operations to be faster generally than pipenv? (I imagine it can't be slower than pipenv updates.)

Ha, yeah, it's much faster in general.

This looks like a good first trial pass. It would be interesting to see how pip-tools works with other projects with more, or more complex, dependencies.

Indeed. I think it'd be worth migrating something else to pip-tools as well and seeing how that goes. We'll learn a lot by trying to use it more.

When you were using it, did you find pip-tools operations to be faster generally than pipenv? (I imagine it can't be slower than pipenv updates.)

Ha, yeah, it's much faster in general.

This looks like a good first trial pass. It would be interesting to see how pip-tools works with other projects with more, or more complex, dependencies.

Indeed. I think it'd be worth migrating something else to pip-tools as well and seeing how that goes. We'll learn a lot by trying to use it more.


Generic events

This PR introduces a generic HasEvents subclass for models that have related events, and migrates the existing UserEvents and ProjectEvents models to it. It uses generic associations but maintains essentially the same underlying "table per related" structure.
This ensures that events are created and associated with their sources in a consistent and generic way, and allows us to add event support to any new or existing model simply by adding the HasEvents mixin to the models class definition.

I'm going to validate the migration locally, but have no issues with this.
I will ask to coordinate merge so I can be on hand though.

👍

@ewdurbin I'll let you merge whenever you're free to babysit this.

🖖🏼 20.778 month old PR 🚢


'cannot load such file -- util/vmdb-logger' - ManageIQ system stopped working

Hi there!
First of all, thanks for handling and developing this great platform that I've been using for developing a plugin over last couple of weeks.:) Today, I tried to develop it further - as usual, tried to run the rails console (using the standard bundle exec rails c command) and got the following output:

It seems a file called -- a file called util/vmdb-logger isn't loaded as it should have been.
the next thing I did was reinstall the entire ManageIQ system - uninstalled, made sure all the packages are setup correctly, reinstalled and ran bin/setup. During the setup, I got the following error related to VM-DBs:

To be more specific, I think library bootsnap and the ManageIQ project stared to clash in a way.
I explored further and found out that some upstream changes have been made on ManageIQ core: https://github.com/ManageIQ/manageiq/commit/036a0dd73b13d0f21ad0b2eb815d063e1b528e22, where usage of VMDBLogger is removed, which is exactly the problem I've been getting. Nevertheless, I reverted to commit before this one and I get the same error.
Any suggestions to fix the living MiQ system?

VMDBLogger was just removed - it looks like the require is coming from vmdb/loggers.rb which no longer has that line, so this means you just need to update your core repo.

Great, working now. Thanks!


concierge.analytics.console.aws.a2z.com blocked

AWS recently introduced a new Console feature which allows you to search for products and rapidly which from one service to another.
The dynamic search is done against concierge.analytics.console.aws.a2z.com and by blocking the URL the feature of the AWS console breaks.
I had to temporarily add the CNAME to whitelist but it should not be blocked by any means as it blocks a fundamental feature of the AWS Console.

Ping @jawz101
I'm guessing(more like certain) that NextDNS is involved and the mentioned domain is not listed here but the closest is analytics.console.aws.a2z.com so if you don't mind inspect and don't remove if doesn't need to.
The problem is purely downstream and it's about time all those NextDNS users to start addressing that uncontrolled wildcard blocking with the developers there and not here.

Forgot to mention I am experiencing the issue on Pi-Hole.


youtube-dl: bumped to 2020.11.17

Existing package

[x] I am the maintainer of this package.

Sorry, I will create a new one. I didn't update my repository before creating this pull request.


add openmuc text svg

Build failed because of:
item OpenMUC has an invalid repo https://www.openmuc.org/openmuc/download/

Build failed because of:
item OpenMUC has an invalid repo https://github.com/openmuc

Build failed because of:
item OpenMUC has an invalid repo https://gythialy.github.io/openmuc/


possible bug breaking install on wsl2 ubuntu 20.04

Windows 10 2004
wsl2
Ubuntu 20.04
windows terminal preview
git --version 2.25.1
glibc --version 2.31
ruby --version 2.7.0p0
/bin/bash --version GNU bash, version 5.0.17(1)-release (x86_64-pc-linux-gnu)
I'm trying to install homebrew for the first time.
I ran /bin/bash -c "$(curl -fsSL https://raw.githubusercontent.com/Homebrew/install/HEAD/install.sh)" from my $HOME directory.
The installation breaks at the following point after fetching tags.
 * [new tag]             2.7.1      -> 2.7.1
HEAD is now at 635ecbc58 Merge pull request #10178 from Rylan12/documentation-updates
/home/linuxbrew/.linuxbrew/bin/brew: line 70: !VAR: unbound variable
Failed during: /home/linuxbrew/.linuxbrew/bin/brew update --force

When attempting the install subsequent times, I removed the /home/linuxbrew directory first to have a clean-slate install.
I confirmed that the symlink made directly before the update --force was created.
if [[ "${HOMEBREW_REPOSITORY}" != "${HOMEBREW_PREFIX}" ]]; then
  execute "ln" "-sf" "${HOMEBREW_REPOSITORY}/bin/brew" "${HOMEBREW_PREFIX}/bin/brew"
fi

execute "${HOMEBREW_PREFIX}/bin/brew" "update" "--force"

Of the following, I only have values in EDITOR and PATH.
BROWSER DISPLAY EDITOR NO_COLOR PATH
I made these changes locally to get past the line 70 issue.  continue wasn't skipping the remainder of the loop without placing it inside the if..fi block and  the second block failed to test that the $HOMEBREW_EDITOR had been set.
I'm not positive that this will fix the full install because re-running the install.sh wipes out the brew file each time.

[ ] Have you checked to ensure there aren't other open [Pull Requests] for the same change?

I have searched for help with the error shown above and not found anything relevant or current.

/home/linuxbrew/.linuxbrew/bin/brew: line 70: !VAR: unbound variable

That indicates brew was run with set -u/set -o nounset, which I suspect is non-standard even for WSL. I seem to recall several folks posting about Homebrew on WSL, but you're the only one who's reported this error, so it's likely something about your setup rather than an actual bug.
Does echo $BASH_ENV output anything? If it does, look in the file that it points to, since that gets sourced for each bash script run.
Also, if env | grep SHELLOPTS prints anything, that will be the shell options inherited by every bash process started directly or indirectly from your current shell. If one of those options is nounset, that would explain the error you're seeing.

/home/linuxbrew/.linuxbrew/bin/brew: line 70: !VAR: unbound variable

That indicates brew was run with set -u/set -o nounset, which I suspect is non-standard even for WSL. I seem to recall several folks posting about Homebrew on WSL, but you're the only one who's reported this error, so it's likely something about your setup rather than an actual bug.
Does echo $BASH_ENV output anything? If it does, look in the file that it points to, since that gets sourced for each bash script run.
Also, if env | grep SHELLOPTS prints anything, that will be the shell options inherited by every bash process started directly or indirectly from your current shell. If one of those options is nounset, that would explain the error you're seeing.

Thanks for the quick reply.  I don't see nounset referenced in any of the files I'm sourcing along with .bashrc.
$BASH_ENV is empty
env | grep SHELLOPTS
SHELLOPTS=braceexpand:hashall:histexpand:history:interactive-comments:monitor:vi

I have the following in my .bashrc
export XDG_CONFIG_HOME=~/.config
export XDG_DATA_HOME=~/.local/share
shopt -s checkwinsize
export SHELLOPTS
export EDITOR=nvim
export HISTSIZE=99999
export HISTFILESIZE=99999
export HISTCONTROL=ignoreboth:erasedups
export HISTIGNORE=ls:ps:history:exa:cd:clear
shopt -s histappend
shopt -s cmdhist   # store multi-line commands in one history item
set -o vi

Thanks for the quick reply.  I don't see nounset referenced in any of the files I'm sourcing along with .bashrc.
$BASH_ENV is empty
env | grep SHELLOPTS
SHELLOPTS=braceexpand:hashall:histexpand:history:interactive-comments:monitor:vi

I have the following in my .bashrc
export XDG_CONFIG_HOME=~/.config
export XDG_DATA_HOME=~/.local/share
shopt -s checkwinsize
export SHELLOPTS
export EDITOR=nvim
export HISTSIZE=99999
export HISTFILESIZE=99999
export HISTCONTROL=ignoreboth:erasedups
export HISTIGNORE=ls:ps:history:exa:cd:clear
shopt -s histappend
shopt -s cmdhist   # store multi-line commands in one history item
set -o vi

Just did more poking and discovered this:
echo $BASHOPTS
checkwinsize:cmdhist:complete_fullquote:expand_aliases:extglob:extquote:force_fignore:globasciiranges:histappend:interactive_comments:login_shell:progcomp:promptvars:sourcepath

Just did more poking and discovered this:
echo $BASHOPTS
checkwinsize:cmdhist:complete_fullquote:expand_aliases:extglob:extquote:force_fignore:globasciiranges:histappend:interactive_comments:login_shell:progcomp:promptvars:sourcepath

which bash
/usr/bin/bash

I also tried downloading the install.sh and running that with
/usr/bin/bash ./install.sh, as well as changing the curl command to run with /usr/bin/bash.  Both result in the same error described above.

which bash
/usr/bin/bash

I also tried downloading the install.sh and running that with
/usr/bin/bash ./install.sh, as well as changing the curl command to run with /usr/bin/bash.  Both result in the same error described above.

Alright.  I commented out the following and the install has moved past the line 70 issue.
  # export SHELLOPTS
  # shopt -s histappend
  # shopt -s cmdhist   # store multi-line commands in one history item

I'm not sure when or why I added export SHELLOPTS, and tbh I need to read about that to know what it's actually meant to do.

Alright.  I commented out the following and the install has moved past the line 70 issue.
  # export SHELLOPTS
  # shopt -s histappend
  # shopt -s cmdhist   # store multi-line commands in one history item

I'm not sure when or why I added export SHELLOPTS, and tbh I need to read about that to know what it's actually meant to do.

This can be closed.  Thank you.

This can be closed.  Thank you.


Remove reliance on go-open-service-broker-client

I think the osb-broker-lib should not rely on the go-open-service-broker-client. If anything the client should depend on the broker-lib for its data types. It feels weird to have a broker depend on a client.

I do not want to create a project that has both client and broker. Keeping the repositories separate allows us to independently iterate on things and give users the best options for reacting to things like breaking changes. I don’t want to introduce yet another project for the types because it’s one more dependency to track.
It might seem weird to have a broker depend on the client, but remember - the broker has to do what the platform (the client) expects. If you think about it that way it’s not quite as weird. The most important thing is that the broker and platform share the same definition of the contract.


Add Fuzzing and coverage configuration for Clang/GCC

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@32b6a29). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #26   +/-   ##
=======================================
  Coverage        ?   72.80%
=======================================
  Files           ?        8
  Lines           ?     1059
  Branches        ?        0
=======================================
  Hits            ?      771
  Misses          ?      288
  Partials        ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32b6a29...6496578. Read the comment docs.


chore(deps): upgrade dev dependencies

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade-dev-dependencies-2.x" workflow

⚪ Backport skipped
The pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually.
Manual backport
To create the backport manually run:
backport --pr 2403

Questions ?
Please refer to the Backport tool documentation


Issue in vnet-2-vnet routing scenario

[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 55838501-4741-8e7b-268b-0ceca1b16d8c
Version Independent ID: f42d7cef-fa5b-80c2-2495-488eda2da570
Content: Scenario: Isolating VNets - Azure Virtual WAN
Content Source: articles/virtual-wan/scenario-isolate-vnets.md
Service: virtual-wan
GitHub Login: @cherylmc
Microsoft Alias: cherylmc

This page talks about 2 new patterns in the table, but there are no 2 patterns as both the lines indicate the same connectivity option. I think there is a mistake in that table and vnet-2-vnet should be blank to represent that there is no connectivity between vnets as per the requirement.

@aramchandra , thank you for your feedback. We have assigned this to the content owner/author for review.
@cherylmc , for your review.

#reassign:cfields475

Thank you for you dedication to our documentation.
Unfortunately, we have been unable to review this issue in a timely manner. We sincerely apologize for the delayed response. We are closing this issue. If you feel that the problem persists, please respond to this issue with additional information.
Please continue to provide feedback about the documentation. We appreciate your contributions to our community.
#please-close

How can we reopen this issue?