FFI Error when following Metacello install instructions

Hi,
I'm getting the following error -- which I think is FFI related -- when attempting to install via the Metacello instructions in the readme:
Error: ExternalAddress called #basicNew: with invalid argument nil

I'm running Pop_os 20.04 (Ubuntu-derives), Squeak 5.3. I did install the FFI already via the startup preferences wizard, perhaps that's the issue?
Screenshot of stack:

Hey, would it be possible for you to work in a Squeak-trunk image instead? I'm making use of some of the niceties that Marcel added in FFI recently, but with that he also upgraded other calls to be up-to-date with trunk, so for example you'll likely also run into errors with beWritableObject missing later on.
If not, I can have a quick check for how complicated it might be to support older versions, too.

Ok I've tried using the latest Trunk image.
First I got the following warning:

I proceeded and the rest of the install seemed to go fine. But when I tried the TextMorph example with the font loading I got:

I assume this means it cannot find the freetype module for some reason. I'm not 100% sure I have it installed (I assumed that freetype is what Ubuntu uses, but maybe that's wrong?) Perhaps I need to install a dev version to get the shared library?

Squeak's module lookup is a little quirky for the arch-specific libraries. Could you try starting your squeak with env LD_LIBRARY_PATH="$LD_LIBRARY_PATH:/usr/lib/x86_64-linux-gnu/" ./squeak.sh and see if that works?

Ok excellent that has worked and the font can load without error.
Unfortunately this appears to have some of the same glyph lookup problems as the standard TTFont classes, when it comes to the fonts that I am using (they can be found here, in particular the one called Assurbanipal).
When I have time next I might dig into this library and see what's happening. As I mentioned on the mailing list, I think I have some idea of what's going on in the standard TTF package, but I'm having a hard time wrapping my head around the potential solution.
The package loads and runs though, so def feel free to close this issue.

Thank you for reporting back, I will update the README accordingly!
Some pointers for your continued investigation:

we also created a project that is calling into Pango (the text stack on ubuntu/gnome) for its text rendering because we needed support for complex scripts such as Arabic: https://github.com/tom95/Pheno#pango Note that Pheno can integrate with Morphic but is not necessarily built to do so. For an easy way to hack a different font into Pheno, you could edit PHPangoTextLayout>>primLayout:font: and put the name string of the font as installed in your system.
the likely problem given that it doesn't work with freetype is that you need advanced shaping rules as defined by harzbuff. If it does turn out to work using Pango, this is a likely (but not the only) explanation. Both integrating Harfbuzz and an implementation of the advanced OpenType rules you mentioned in squeak's TTFonts would be of tremendous benefit for Squeak. If you were to start investigating a Harzbuff integration I could provide some more ideas.

I'll close this issue as such now, if you have follow up questions, please feel free to "abuse" this issue to continue the discussion (unless it's specifically Pheno-related of course, then we can move to its issue tracker) :)


Add docs for 'Topology Spread Constraint' support in K8S build pods.

Thanks for contributing to the Harness Developer Hub! Our code owners will review your submission.
Description

Please describe your changes: This PR adds docs for 'Topology Spread Constraint' support in K8S build pods.
Jira/GitHub Issue numbers (if any): https://harness.atlassian.net/browse/CI-14248
Preview links/images (Internal contributors only): to be added

@nofarblue this PR adds to FAQ. How can I update this new field in the product documentation? i.e. a page like this?
PR lifecycle
PRs must meet these requirements to be merged:

[ ] Successful preview build.
[ ] Code owner review.
[ ] No merge conflicts.
[ ] Release notes/new features docs: Feature/version released to at least one prod environment.

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://66e856b2e71a801bfbfe9935--harness-developer.netlify.app

@jamie-harness could you pls review?


feat: add info and debug logging to console global

Noticed console.debug was missing, so figured I'd add it. It's also not obvious what log level console.log has, so I added console.info as well as an alias, which seems to match browser behaviour.
Diff looks a bit confusing, as I sorted the functions based on log level. 🤷

Thanks, @Phault!
While we're in here, I wonder if it would be a good time to consider how we could support variadic args for the console functions.
For example, in JS, console.log takes any number of args and logs them, e.g.:
console.log("this", "is", "a", variable, 42, {a: 1}, [1, 2, variable, 3])

How close can we get these functions?
cc/ @bhelx

Thanks for contributing! Let's merge this as is. I think it's a welcome addition. I'll create an issue for making these compatible with the w3c console.log, etc. I do think it might be easier to, instead of implementing some of these globals like console in rust, just expose the IO primitives from rust and implement it in JS in the polyfill layer. Open to different ideas on how to do it though.


AI Integration: Check bulk experience on appinsights

Check closely, what is the experience of bulk operation on AppInsights.

Checked and we are fine. what we have right now. For detail information please check Baseline XMLs


.git/hooks//pre-commit: line 2: pre-commit: command not found

Not sure why, but I started getting this error.
Tried re-installing and following the readme but still seeing it. I can confirm the binary is present. Let me know how I can help.

Repo: https://github.com/gkiely/vite-react-starter

could you please share your .git/pre-commit.sh file? It seems like the wrong command is executing
correct command should be yarn pre-commit or npm run-script pre-commit

That was the fix, my apologies I didn't think to inspect it, I thought it was a binary.
Previous: pre-commit
Working: npm run pre-commit


Fix 29/remove mshr

Hi, this PR fixes issue #29 by removing mshr as a dependency. Instead I created a mesh of the plate with hole with gmsh and just put the mesh files in test. I could also add the script that creates the mesh if you like, but it is actually not needed here.

Since we want to move to fenicsx in the future, I don't think that mshr is needed anymore.
Concerning the mesh from gmsh:
I would also just upload the mesh file instead of the generator script. Otherwise, we would need another dependency for this package in order to run all examples.


in fontShell: glyph.round() works for some glyphs, not for others

Possibly related to #546:
I have a Robofont observer which identifies float coordinates (among other things) and rounds the affected glyphs.
Just now, I yanked that observer out of the script to make it a command line tool. While correctly identifying the glyphs that need rounding, the .round() operation does not do anything.
When trying to figure out to see what’s happening, I found out that the rounding works for some glyphs, but not all:
import sys
import ufonormalizer
from fontParts.fontshell import RFont

def move_glyph_and_round(g):
    g.moveBy((100.333, 0))
    g.round()

paths = sys.argv[1:]
for path in paths:
    f = RFont(path)
    # g = f['hryvnia']  # does not work
    g = f['a']  # does work
    move_glyph_and_round(g)
    f.save()
    ufonormalizer.normalizeUFO(f.path, writeModTimes=False)

The Robofont observer works as expected.
The command line script refuses to round the hryvnia, but works with the a.
What’s going on?
This is the UFO I am working on:
SourceSerif-Italic_c1.ufo.zip

The behavior does not change when I add g.changed() as a 3rd step in the move_glyph_and_round function.

My current guess is that something is going on with defcon, that it's not catching changes. I currently don't have the bandwidth to look into this for the next two weeks, but can after that.

Thank you very much @justvanrossum! #550 works as expected.

Closed by #550


update pipeline upgrade doc with new kfctl

/assign @sarahmaddox

This change is

Preview: https://deploy-preview-610--competent-brattain-de2d6d.netlify.com/docs/pipelines/upgrade/

Thanks!
/lgtm
/approve


Webhook Log Page - Template column is not sorting

Describe the bug
https://www.berrycast.com/conversations/9fbd862a-d53f-5aad-84e7-76f63aeced75

https://www.berrycast.com/conversations/d87bed00-f55e-5dde-9898-ba068d2e5d4d


Support rule units and oopath notation in rules yaml format

Implemented by https://github.com/apache/incubator-kie-drools/commit/07a7e812997beccf45301a402131fb35a392298e


Weird rendering when the page is refreshed after the page has been scrolled to the right

Hi,
Am facing an issue  - attached is my simple html code reproducing the problem.
When I make the screen small enough so that there is a horizontal and vertical scrollbar, and then I scroll down until I see the pane3 text and I scroll to right. Till here everything is fine. Now if I refresh the page, the pane1 text has half disappeared. If I scroll fully to the left also, that text does not reappear.
It seems to be a problem with calculating left in this line: var left = child.getBoundingClientRect().left;
Can you please take a look? Thanks.
(Note replace fixto and jquery with the right url in the attached example).
vgs.txt

I was able to repeat the same issue in your development page 1.
Make the screen small enough to get a horizontal scroll bar. scroll to the right. Then refresh the page. You can see that the pink top bar has moved to the left and we cannot get the hidden portion of the pink bar back.

The fix is to change line:533 from
var left = child.getBoundingClientRect().left;
to
var left = child.offsetLeft;

Hello.
Thanks for digging in. This looks like issue #12
It does not have priority but might be good to fix. I am glad you provided a solution without checking left scroll (Did you delete your comment about checking left offset?)
The only thing remaining is to add cumulative offset, as offsetparent might not be the document itself.
Will do at some point.

Hi, thanks for the response.
Yes I deleted my comment about left offset since I saw that it is more complicated than that. Reason is, currently I have a top bar, a left pane and a right pane. I fix the left pane and right pane, and make it "mind" the top bar. If I set the leftOffset to 0, then the right pane overwrites the left pane. So seems like the solution would be more complex. Haven't been able to solve it, would greatly appreciate if you find a way to solve it.

Unfortunately I am not having much time. I keep the horizontal scroll
issue as low priority.
On Wednesday, 22 June 2016, Vandana Gopal<EMAIL_ADDRESS>wrote:

Hi, thanks for the response.
Yes I deleted my comment about left offset since I saw that it is more
complicated than that. Reason is, currently I have a top bar, a left pane
and a right pane. I fix the left pane and right pane, and make it "mind"
the top bar. If I set the leftOffset to 0, then the right pane overwrites
the left pane. So seems like the solution would be more complex. Haven't
been able to solve it, would greatly appreciate if you find a way to solve
it.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/bbarakaci/fixto/issues/42#issuecomment-227771696, or mute
the thread
https://github.com/notifications/unsubscribe/ABtwNOVG_j5oAebJhOn4bbC2f0oy-Jphks5qOU3WgaJpZM4I4UMC
.


Missing document--Repeat function in Image captioning

Hello All
http://keras.io/examples/#image-captioning
In the example of Image Caption, there is a function: Repeat()
model.add(Repeat(max_caption_len))

I couldn't find doc of this function in Keras.io
Perhaps it is for using the output y head as input feedbacks when generating sequences ?
Could anyone tell me what's it for, and which module I can find it ? Thank you !

Check out RepeatVector.

Thank you for reply.
Personally I don't think Repeat is the RepeatVector
The example is more likely using its previous output Y head , as input..
Are you 100% sure about it ? @lukedeo

Yes, that would be RepeatVector.
About RepeatVector:
Dimensions of input are assumed to be (nb_samples, dim).
Return tensor of shape (nb_samples, n, dim).

Here RepeatVector turns a feature vector into of sequence of this same feature vector repeated max_caption_len times.


E2E Test with df-sql

E2E Test with df-sql

Is this duplicate with https://github.com/oceanprotocol/df-py/issues/587
(And that issue has far more detail)


How to process the raw dataset from Oxford RebotCar dataset ?

Hi, I am very interested in your nice work. I would like to how to process the raw dataset download from the Oxford RebotCar dataset that has a different date compared with your dataset. If you know how to pre-process the dataset, I wish you can give me some advice. Thanks a lot!

Hi, our ethod works on pre-processed RobotCar datasets, prepared by authors of PointNetVLAD paper (available at: https://github.com/mikacuy/pointnetvlad). These point clouds are constructed by accumulating multiple scans from 2D LiDAR, accumulated over 20 meter drive. Such point clouds are downsampled to 4096 points, normalized so coordinates are in -1..1 range and ground plane points are removed.
Which raw LiDAR data do you want to process? Original RobotCar dataset contains both 2D and 3D LiDARs.

The individual scans from 2D LiDAR are rather small - they contain only about 500 points on one 2D plane. They are not informative enough for successful place recognition (or for other tasks).
3D LiDAR scans in original RobotCar dataset doesn't look good for place recognition.
If you want to use raw point clouds from a LiDAR for place recognition or similar purposes, you should look into Oxford Radar RobotCar (https://oxford-robotics-institute.github.io/radar-robotcar-dataset/).  It contains LiDAR scans from Velodyne HDL-32E LIDAR. They are relative large point clouds with few thousand points covering area with app. 80 meter diameter.
For such point clouds you do not need any special pre-processing. My network operates on 3D poitns clouds. You can read the point cloud as triplets of (X, Y, Z) coordinates, quantize the coordinates and pass it through the network. You'll only need to change quantization step (default setting in my code is to use very small quantization step=0.01 - as point coordinates were normalized in -1..1 range). Raw scans have point coords within -80..80 range (or similar) and you need to change quantization step accordingly (0.3 meter looks reasonably good). To get reasonable results you'll need to re-train the model (as it was trained on accumulated point clouds from 2D LIDAR, which have different characteristics.

Hi, thanks a lot for your reply and detailed explanation.

发件人: jac99 @.>
发送时间: 2021年3月28日 20:04
收件人: jac99/MinkLoc3D @.>
抄送: Zhaoliang Luan @.>; Author @.>
主题: Re: [jac99/MinkLoc3D] How to process the raw dataset from Oxford RebotCar dataset ? (#1)
Hi, our ethod works on pre-processed RobotCar datasets, prepared by authors of PointNetVLAD paper (available at: https://github.com/mikacuy/pointnetvladhttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmikacuy%2Fpointnetvlad&data=04|01||67f0e49d119e4d7630ac08d8f21c4776|569df091b01340e386eebd9cb9e25814|0|0|637525550565662436|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=E71BccpSoxjj5OExP%2BThhHGv4iGS%2FVdtVsA85OF959M%3D&reserved=0). These point clouds are constructed by accumulating multiple scans from 2D LiDAR, accumulated over 20 meter drive. Such point clouds are downsampled to 4096 points, normalized so coordinates are in -1..1 range and ground plane points are removed.
Which raw LiDAR data do you want to process? Original RobotCar dataset contains both 2D and 3D LiDARs.

The individual scans from 2D LiDAR are rather small - they contain only about 500 points on one 2D plane. They are not informative enough for successful place recognition (or for other tasks).
3D LiDAR scans in original RobotCar dataset doesn't look good for place recognition.
If you want to use raw point clouds from a LiDAR for place recognition or similar purposes, you should look into Oxford Radar RobotCar (https://oxford-robotics-institute.github.io/radar-robotcar-dataset/https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Foxford-robotics-institute.github.io%2Fradar-robotcar-dataset%2F&data=04|01||67f0e49d119e4d7630ac08d8f21c4776|569df091b01340e386eebd9cb9e25814|0|0|637525550565667432|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=LgmU2L96%2BH2xd05zWU8cmgIuBBcvR2eAFb5FKCy9P5U%3D&reserved=0). It contains LiDAR scans from Velodyne HDL-32E LIDAR. They are relative large point clouds with few thousand points covering area with app. 80 meter diameter.
For such point clouds you do not need any special pre-processing. My network operates on 3D poitns clouds. You can read the point cloud as triplets of (X, Y, Z) coordinates, quantize the coordinates and pass it through the network. You'll only need to change quantization step (default setting in my code is to use very small quantization step=0.01 - as point coordinates were normalized in -1..1 range). Raw scans have point coords within -80..80 range (or similar) and you need to change quantization step accordingly (0.3 meter looks reasonably good). To get reasonable results you'll need to re-train the model (as it was trained on accumulated point clouds from 2D LIDAR, which have different characteristics.

―
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fjac99%2FMinkLoc3D%2Fissues%2F1%23issuecomment-808943217&data=04|01||67f0e49d119e4d7630ac08d8f21c4776|569df091b01340e386eebd9cb9e25814|0|0|637525550565672421|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=JPF%2BAXolWpyyPbMybGkXG74apdfuXBSaOYiMyB2uqaQ%3D&reserved=0, or unsubscribehttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAPBUPYZQZZKJF7WHZDVNOFTTF6DT3ANCNFSM4Z3IEOZQ&data=04|01||67f0e49d119e4d7630ac08d8f21c4776|569df091b01340e386eebd9cb9e25814|0|0|637525550565677410|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=N3MrVdWQR2zQL2%2BCzFWV1Up0mIfMHMwmmotIjX6x9%2Bo%3D&reserved=0.

Hi, actually I would like to try to use the camera RGB image to implement camera pose estimation with supplementary data like point cloud data. However, I don't know which LiDAR(2D or 3D) of Oxford RobotCar that I can use? and I am not clear how to process the raw data.  Thanks!

发件人: jac99 @.>
发送时间: 2021年3月28日 20:04
收件人: jac99/MinkLoc3D @.>
抄送: Zhaoliang Luan @.>; Author @.>
主题: Re: [jac99/MinkLoc3D] How to process the raw dataset from Oxford RebotCar dataset ? (#1)
Hi, our ethod works on pre-processed RobotCar datasets, prepared by authors of PointNetVLAD paper (available at: https://github.com/mikacuy/pointnetvladhttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmikacuy%2Fpointnetvlad&data=04|01||67f0e49d119e4d7630ac08d8f21c4776|569df091b01340e386eebd9cb9e25814|0|0|637525550565662436|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=E71BccpSoxjj5OExP%2BThhHGv4iGS%2FVdtVsA85OF959M%3D&reserved=0). These point clouds are constructed by accumulating multiple scans from 2D LiDAR, accumulated over 20 meter drive. Such point clouds are downsampled to 4096 points, normalized so coordinates are in -1..1 range and ground plane points are removed.
Which raw LiDAR data do you want to process? Original RobotCar dataset contains both 2D and 3D LiDARs.

The individual scans from 2D LiDAR are rather small - they contain only about 500 points on one 2D plane. They are not informative enough for successful place recognition (or for other tasks).
3D LiDAR scans in original RobotCar dataset doesn't look good for place recognition.
If you want to use raw point clouds from a LiDAR for place recognition or similar purposes, you should look into Oxford Radar RobotCar (https://oxford-robotics-institute.github.io/radar-robotcar-dataset/https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Foxford-robotics-institute.github.io%2Fradar-robotcar-dataset%2F&data=04|01||67f0e49d119e4d7630ac08d8f21c4776|569df091b01340e386eebd9cb9e25814|0|0|637525550565667432|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=LgmU2L96%2BH2xd05zWU8cmgIuBBcvR2eAFb5FKCy9P5U%3D&reserved=0). It contains LiDAR scans from Velodyne HDL-32E LIDAR. They are relative large point clouds with few thousand points covering area with app. 80 meter diameter.
For such point clouds you do not need any special pre-processing. My network operates on 3D poitns clouds. You can read the point cloud as triplets of (X, Y, Z) coordinates, quantize the coordinates and pass it through the network. You'll only need to change quantization step (default setting in my code is to use very small quantization step=0.01 - as point coordinates were normalized in -1..1 range). Raw scans have point coords within -80..80 range (or similar) and you need to change quantization step accordingly (0.3 meter looks reasonably good). To get reasonable results you'll need to re-train the model (as it was trained on accumulated point clouds from 2D LIDAR, which have different characteristics.

―
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fjac99%2FMinkLoc3D%2Fissues%2F1%23issuecomment-808943217&data=04|01||67f0e49d119e4d7630ac08d8f21c4776|569df091b01340e386eebd9cb9e25814|0|0|637525550565672421|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=JPF%2BAXolWpyyPbMybGkXG74apdfuXBSaOYiMyB2uqaQ%3D&reserved=0, or unsubscribehttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAPBUPYZQZZKJF7WHZDVNOFTTF6DT3ANCNFSM4Z3IEOZQ&data=04|01||67f0e49d119e4d7630ac08d8f21c4776|569df091b01340e386eebd9cb9e25814|0|0|637525550565677410|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=N3MrVdWQR2zQL2%2BCzFWV1Up0mIfMHMwmmotIjX6x9%2Bo%3D&reserved=0.


feat: Allow setting ALB specific tags

Description
Adds ability to provide custom ALB tags in the Atlantis module
Motivation and Context
Granular ability to tag resources in the context of bundled modules
Breaking Changes
none
How Has This Been Tested?
Tested locally

This PR is included in version 4.4.0 :tada:


Branch testing6.1

Codecov Report
Base: 49.34% // Head: 52.59% // Increases project coverage by +3.24% :tada:

Coverage data is based on head (fc578cc) compared to base (301d227).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #170      +/-   ##
============================================
+ Coverage     49.34%   52.59%   +3.24%
- Complexity      834      876      +42
============================================
  Files           174      174
  Lines          3755     3755
  Branches        438      438
============================================
+ Hits           1853     1975     +122
+ Misses         1753     1610     -143
- Partials        149      170      +21

Impacted Files
Coverage Δ

src/main/java/seedu/address/model/pet/Pet.java
70.45% <0.00%> (+2.27%)
:arrow_up:

src/main/java/seedu/address/model/order/Order.java
85.71% <0.00%> (+3.57%)
:arrow_up:

...in/java/seedu/address/logic/parser/ParserUtil.java
25.13% <0.00%> (+6.01%)
:arrow_up:

src/main/java/seedu/address/model/AddressBook.java
68.86% <0.00%> (+9.43%)
:arrow_up:

...main/java/seedu/address/model/person/Supplier.java
50.00% <0.00%> (+10.71%)
:arrow_up:

...rc/main/java/seedu/address/model/person/Buyer.java
65.21% <0.00%> (+13.04%)
:arrow_up:

.../seedu/address/logic/parser/AddressBookParser.java
82.75% <0.00%> (+17.24%)
:arrow_up:

.../seedu/address/logic/commands/AddBuyerCommand.java
26.92% <0.00%> (+26.92%)
:arrow_up:

...edu/address/logic/commands/AddSupplierCommand.java
26.92% <0.00%> (+26.92%)
:arrow_up:

.../seedu/address/logic/parser/ListCommandParser.java
29.41% <0.00%> (+29.41%)
:arrow_up:

... and 5 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

LGTM!


Service bus track 2 - timeout when run as Live Test in pipeline

Connection timeout error
Some test cases timeout ... For example  com.azure.messaging.servicebus.UnnamedSessionManagerTest.singleUnnamedSessio
https://tfsprodcus3.visualstudio.com/A0fb41ef4-5012-48a9-bf39-4ee3de03ee35/internal/_TestManagement/Runs?runId=11380096&_a=resultSummary&resultId=100343
This is pipeline run and logs can be found here  https://dev.azure.com/azure-sdk/internal/_build/results?buildId=419553&view=logs&j=351a4efb-edfe-5bb4-cda1-1ace5fc54b68&t=332ee861-0df2-58fa-cf63-28af96dd70e8
Could they be because of Following connection error ?
2020-06-10 13:27 [single-1] [INFO] com.azure.core.amqp.implementation.handler.ConnectionHandler - onConnectionBound hostname[sb-java-tbe4fd25775dc4b74.servicebus.windows.net], connectionId[MF_649643_1591795485766]
2020-06-10 13:27 [single-1] [INFO] com.azure.core.amqp.implementation.ReactorExecutor - connectionId[MF_3c7a16_1591795121904], message[Stopping the reactor because thread was interrupted or the reactor has no more events to process.]
The connection was inactive for more than the allowed 240000 milliseconds and is closed by container '03b4e93112274cf0887ca1b55d78a49e_G23'., errorContext[NAMESPACE: ***, PATH: coordinator, REFERENCE_ID: coordinator, LINK_CREDIT: 998]
Note: These test work fine when they are run  with in intellij and we do not see any error. We only see these timeout error  in live test run.

This is fixed in this PR : https://github.com/Azure/azure-sdk-for-java/pull/12374


Update Python Signing API

Update the signing API to follow a more flexible, pluggable model.
Signing algorithms can be encapsulated with a Context and keys with
PrivateKey and PublicKey objects.
A Signer can be used to wrap a private key and a context, which can
then be used repeatedly during operation.  For example, the identity key
for a given validator is loaded at startup time, parsed into a Secp256k1
key, encapsulated in a Signer with the appropriate context, and passed
to all users of the Signer - e.g. the BlockPublisher.
All uses of the old API have been updated to reflect this change.
Signed-off-by: Peter Schwarz<EMAIL_ADDRESS>

I thought about the key classes and we might not be able to make those abstract. They have to be associated with a specific curve.
So then I wonder if we even need a "context" class. Once you instantiate a private key you can create a signature and/or a public key.
Once you instantiate a public key you can use it to verify a signature.
PublicKey's would have constructor logic to handle PrivateKey's as objects, hex, or bytes.
my_private = PrivateKey()
signature = my_private.sign(message)
my_public = PublicKey(my_private)
my_public_key_file.write(my_public.as_hex())
some_socket.write(my_public.as_bytes())
my_public = PublicKey(my_public_key_file.read())
my_public.verify(signature, message)

Context is important for wrapping any state necessary.  That is more clear in the other languages where we avoid global variables.  For secp256k1, this corresponds to the secp256k1 context.

Added a commit to add new_random_private_key to the Context


null Users

As a user who logged in using Github, I don't want to be referred as null on the emails.
As an api provider looking at the activity feed, any other information other than user = null could be more helpful.
DoD: find alternatives to replace null

@elisafw-ux in Github, the name is actually optional, which is the reason I think that some Github users get that null reference related to access requests.  I think the fix (specifically for Github logins) would be to use the username in the event that the name is not provided.  Do you agree?

@ikethecoder Agreed, I was thinking exactly the same, using the Github username when the name is nor provided.


Set cell value by column

就类似按行赋值那样整一个 SetSheetColumn 咯

Thanks for your issue. The cell data was stored row by row in the spreadsheet document, so setting cells by rows is the typical scenario, and it's better for performance, there is no plan to support set cell by column recently, the developer can implement it by existing set cell value APIs.

Issue #1247 was similar to this, 8 months later, I merged a pull request which implement this feature, please upgrade to the master branch code, and this feature will be released in the next version.


Fix issue where CI fails unnecessarily

It seems to usually be the MacOS runners, on the first CLI query command test.


Fix 503 server error

Related Issue
#349
Does this introduce a breaking change?

[ ] Yes
[x] No

Hey @0xjei. We were using tx before but it was not working properly


fix(api): update settings reset copy to avoid confusion

When fusing v1 and v2, we accidentally stopped exposing v1 settings resets. When exposing them again, we bundled them with the v2 options. Those options now need to have their copy updated to indicate the changes.
Closes #4568

@SyntaxColoring Made the suggested changes


1f5e3 missing

emoji 1f5e3 is missing
http://emojipedia.org/speaking-head-in-silhouette/

You're likely looking at version 1 of the repo. It is included in version 2.
https://github.com/twitter/twemoji/blob/gh-pages/2/72x72/1f5e3.png


Proper 2-type texture for hay bales

(maybe after #6 ?)

not gonna bother with 2-part texture for now, just removed the bands around the hay so it looks alright


Solution with .vdproj unable Build Startup Project with MDB Files

Execution of "Build Startup Project with MDB Files" ends with "The method or operation is not implmeneted". Excluding Visual Studio .NET Setup and Deployment Project from solution not help.

I was able to reproduce it and catch the error.
Fixed in Version 0.9.0


[zdxf] sometimes the pipeline may crash when using mlu preprocess for the "object_ infer" module

this should be

this should be


Add support for Webbased frontend experimental feature

Description of problem:
Add support for Webbased frontend experimental feature using ingress
Required updates

[ ] Docs.md update to include this new method for Permit Join and other operations
[ ] Changelog.md to document new
[ ] Update config.json with new changes
[ ] Test locally to make sure ingress when frontend calls backend operations

config.json changes
experimental:
  new_api: true
  frontend:
    port: 8080

    "experimental": {
      "new_api": "bool?",
      "frontend": {
        "port": "int?"
        }
    },

ingress": true,
  "ingress_port": 8080,
  "panel_icon": "mdi:zigbee",

I looked into this, but I was under the impression that addon configurations only support two levels of nesting, hence "port": "int?" would be ignored.

@messismore I didn't test yet as I was looking into some pipeline optimizations, but best is to set it up and try it on a local build. I might get to it later today or tomorrow.

@messismore you are correct, I re-tested and it's still the case:
20-09-23 10:18:02 WARNING (MainThread) [supervisor.store.data] Can't read /data/addons/local/zigbee2mqtt-edge/config.json: expected string or buffer for dictionary value @ data['schema']['experimental']['frontend']. Got {'port': 'int?'}

@Koenkk is it possible to change the setup? Ideally would be something like:
experimental:
  new_api: true
  frontend_port: 8080

Based on the code in z2m if you have experimental.frontend you load the extension and if port is not specified it falls back to 8080.
I was able to get the frontend started by using:
"ingress": true,
  "ingress_port": 8080,

and
"experimental": {
      "new_api": true,
      "frontend": true
    },

    "experimental": {
      "transmit_power": "int?",
      "output": "str?",
      "new_api": "bool?",
      "frontend": "bool?"
    },

However it seems the setup is not ingress friendly. I'm still debugging to understand why. It might be that api calls are trying to get through on the wrong path.

This is now working in latest edge, but with the configuration workaround specified above.

This is now released with 1.15.0


[RFC]: Add C implementation for @stdlib/math/base/special/rempio2

Description
This RFC proposes adding C implementation for @stdlib/math/base/special/rempio2.
double stdlib_base_rempio2( const double x, double *y );

Related Issues
Related issues #735.
Questions
No.
Other
No.
Checklist

[X] I have read and understood the Code of Conduct.
[X] Searched for existing issues and pull requests.
[X] The issue name begins with RFC:.

For reference, we could alternatively have the signature be
rempio2( const double x, double *y1, double *y2 );

Where y1 and y2 are pointers for storing output values. However, this is not conventional. Instead, FreeBSD expects a pointer to a two-element array. It is fine for us to do the same.

Hello @kgryte @Pranavchiku I would like to work on this issue :)

@lovelindhoni I'll prefer you to apply review and get #1659 merged.

Also this PR depends on round.

@Pranavchiku I think we can start working on this as the pkgs for this are already implemented in C
if it is fine can I take up this issue as I have completed the kernel and medium rempio functions ?

Also this PR depends on round.

I only saw these pkg being used in rempio2
high-word-abs-mask, high-word-exponent-mask, high-word-significand-mask, get-high-word, get-low-word, from-words

@USERSATOSHI Since this issue was not assigned specifically, I've been working on this issue and have nearly implemented it,
If possible, could you please let me know if there are any packages required for this?
If you have been working on this too, please let me know!
Best.

@USERSATOSHI Since this issue was not assigned specifically, I've been working on this issue and have nearly implemented it, If possible, could you please let me know if there are any packages required for this? If you have been working on this too, please let me know! Best.

@xaman27x  this package as of right now was not assigned as this dependent on @stdlib/math/base/special/round which is right now in opened pull request state as requires review
and on my side , it is on hold until the c implementation of round is merged

@USERSATOSHI Since this issue was not assigned specifically, I've been working on this issue and have nearly implemented it, If possible, could you please let me know if there are any packages required for this? If you have been working on this too, please let me know! Best.

@xaman27x  this package as of right now was not assigned as this is dependent on @stdlib/math/base/special/round which is right now in opened pull request state as requires review
and on my side , it is on hold until the c implementation of round is merged

my bad it seems like the message repeated cause of poor network connection while i doubled clicked on comment as it wasn't sending

This has now been implemented. Closing...


Remove ReferenceDeclaration

Yes, you read that right.

I'm already on it.

This is mostly done, but a tiny extra bit of work for @chochos.

Done.


Correction for raw affiliation National Institute for Medical Research, P. O. Box 9653, Dar es Salaam, Tanzania.

Correction needed for raw affiliation National Institute for Medical Research, P. O. Box 9653, Dar es Salaam, Tanzania.
raw_affiliation_name: National Institute for Medical Research, P. O. Box 9653, Dar es Salaam, Tanzania.
new_rors: 05fjs7w98
previous_rors: 04tnbqb63
works_examples: W1987879010;W2029553666;W1970118190;W579825595
contact: 15b46335f91578eaa3ff831ffd5f0d85:71b50976e0c07357c32ab69f32580e3753ba1072 @ crick.ac.uk

This issue was accepted and ingested by the OpenAlex team on 2024-10-10. The new affiliations should be visible within the next 7 days.


Highlight keywords input textfield not well updated after a tab change

Describe the bug
When I set Highlight keywords in settings account, it is well updated but if we change the tab and go back to settings, old value is displayed. It actually requires a page refresh to be displayed correctly.
I tried to fix by myself, but can't find the fix.
To Reproduce
Steps to reproduce the behavior:

Go to settings/account
Edit on Hightlight keywords
Click on Save settings
Change tab
Go back to settings/account : Old value is displayed
Refresh
New value is displayed

Screenshots
Go to settings

Edit text field

Save

Change tab

Back to settings (ISSUE HERE)

Refresh

Finally OK

Thanks! 👍

👍 😃


Merlin Scans: "No results found"

Source information
Merlin Scans 1.4.36
Source language
Turkish
Steps to reproduce
Try using merlin scans
Expected behavior
It should work
Actual behavior
It shows no results found. Website is up tho.
Mihon/Tachiyomi version
1.7.4
Android version
Android 11
Other details
No response
Acknowledgements

[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
[X] I have written a short but informative title.
[X] I have updated the app to version 0.15.3.
[X] I have updated all installed extensions.
[X] I have tried the troubleshooting guide.
[X] If this is an issue with the app itself, I should be opening an issue in the app repository.
[X] I will fill out all of the requested information in this form.

Duplicate of #5175
Search the existing issues first before opening a new one, and acknowledging that you did when you clearly didn't.


Mobile-id mail's where been looped

Describe the bug
Mobile-id mail's where been looped
To Reproduce

Open app and head to home page
Click on add ID
Enter a valid UIN and click on generate VID

Expected behavior
we should able to receive OTP, credential issuance conformation, credential information mails
Observed behavior
we are receiving multiple looped mails in order, other receiving the actual mail
Screenshots

MOSIP Version: 1.2.1
MOSIP server: QA-121.mosip.net (QA5)

Tested the this issue in qa-1201-b2 env, this issue is still occuring, please look into it


Machine Remote Deposit Breaking Water Producers

The mod broke water producers after update. Neither atm./ lake gatherers produce water.

What update?

Please post the file
%USERPROFILE%\AppData\LocalLow\MijuGames\Planet Crafter\Player.log

I'm assuming the 1.105. This is the log after I removed all other mods to check (except ModEnabler).
Player.log

Since the full release, the mod no longer produces water into the machine's own inventory. You have to name a container as *WaterBottle1.

Alright, thanks. I had tried to get the water to go to a specialized storage many iterations ago and could never get it to work.


Missing wheels for arm architecture for python 3.10 and 3.11

Issue Description
On the pypi site (https://pypi.org/project/pyrealsense2/#files), the pyrealsense2 does not include wheels for python 3.10 and 3.11 for arm architecture (aarch64). Do you plan to publish those? It would make my life much easier.
Thanks.

Hi @MikiGrit  I will enquire to my Intel RealSense colleagues about aarch64 wheel files for Python 10 and 11.

Hi again @MikiGrit  My colleagues responded that older versions of Python were chosen to create wheels for is because those are the default Python versions that come with "JP4 and JP5" (this is likely a reference to Nvidia Jetson's JetPack 4 and JetPack 5).
They are open to the possibility of adding wheel support for newer versions in future once they see how it would affect development resources.

Ok, thanks for the response. We actually have very similar use-case. We are using JetPack 5. But due to compatibility with other python libraries, we are forced to use more recent python. It would be great if they could find the time to support also newer python versions.

Hi @MikiGrit  As wheel files for Python 3.10 and 3.11 are not being developed at this time (although it is a possibility for the future), can this case be closed?  Thanks!

@MartyG-RealSense Well, sure. I don't have anything other in mind. Thanks for your effort anyway.

@MikiGrit  You are very welcome.  Thanks very much for your understanding.


Block or reduce snapping of road nodes to boundary ways

In normal editing this is not needed and not wanted.

Currently, holding down Alt (Option on macOS) disables snapping regardless of the kind of feature selected. I map in a region where cases like https://github.com/openstreetmap/iD/issues/7619#issuecomment-630954006 are common; would the logic invert so that holding down Alt would temporarily reenable snapping? Or would I need to take the alternative approach of making the road a member of the boundary relation?

A workaround to this is to disable boundaries showing in iD;

Press F to bring up the Map Data tab on the right sidepanel
Under Map Features, disable Boundaries

imo Boundaries should be disabled (or "read only"/semi-transparent etc) by default

imo Boundaries should be disabled (or "read only"/semi-transparent etc) by default

Boundaries and the ways that form them are already filtered out by default as of 7da27f2a16c0530d50557f3885595daedeadee8d for #4292 and e1da28bcd64bf4d1820611480bd1eb82196ffd21 for #5601.


Windows Notification Integration

Replace the old custom Shotr notification system with Windows Toast Notification.

https://github.com/shotr-io/shotr-3/pull/48


[V2]Add Script for metrics markdown table

Description of the changes

Added a script for creating a markdown table to view and compare v1 and v2 metrics using json generated by compare metrics

Checklist

*[x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
*[x] I have signed all commits
[ ] I have added unit tests for the new functionality
*[x] I have run lint and test steps successfully

for jaeger: make lint test
for jaeger-ui: yarn lint and yarn test

In terminal, run make fmt and push again.

@yurishkuro I have made changes as per your reviews,kindly review if there are any changes or errors i may have not noticed


User invite during "share" should not assign org of current_user

Please complete the following fields as applicable:
What version of the DMPRoadmap code are you running? (e.g. v2.2.0)
3.0.2
Expected behaviour:
Actual behaviour:
The org of the current_user is attached to the new user record.
See https://github.com/DMPRoadmap/roadmap/blob/master/app/controllers/roles_controller.rb#L39
This can be problematic if that user is from outside of the organisation.
Then again, where should one supply the (required!) organisation?
Steps to reproduce:

go to tab share of a plan
enter an email address that does not yet in the user table

When a user clicks on the link in the invitation they're able to indicate which Org they belong to. I think the User record requires an Org id. You could update it to use a default Org if its problematic for your installation


Generate Certificate Request with predictable name

Modify certificaterequest controller to generate CertificateRequest with name as function of certificate name and revision.

Pull Request Motivation
As mentioned in #4956 , multiple CertificateRequest objects are created for a fixed certificate object and fixed revision. This happens when the CertificateRequest creation request from requestmanager controller takes more than 5 seconds to create the resource in the api server.
On timeout, the request is re-tried and a new CertificateRequest is created but with a different name. This results in multiple CertificateRequests for a given certificate name and given revision.
In this PR, this issue is being fixed by making the CertificateRequest name to be a function of certificate name and the revision. This makes sure, even if there are multiple CertificateRequest create request, they are requested with same name. Hence, this avoid multiple CertificateRequests for given cert and revision.
Other fix: #5485

Kind
bug

Local testing
This change has been tested by simulating API server delay locally by the following diff:
diff --git a/pkg/controller/certificates/requestmanager/requestmanager_controller.go b/pkg/controller/certificates/requestmanager/requestmanager_controller.go
index 155580ec5..af87dd03c 100644
--- a/pkg/controller/certificates/requestmanager/requestmanager_controller.go
+++ b/pkg/controller/certificates/requestmanager/requestmanager_controller.go
@@ -395,13 +395,16 @@ func (c *controller) createNewCertificateRequest(ctx context.Context, crt *cmapi
 		},
 	}

-	cr, err = c.client.CertmanagerV1().CertificateRequests(cr.Namespace).Create(ctx, cr, metav1.CreateOptions{FieldManager: c.fieldManager})
-	if err != nil {
-		c.recorder.Eventf(crt, corev1.EventTypeWarning, reasonRequestFailed, "Failed to create CertificateRequest: "+err.Error())
-		return err
-	}
+	go func() {
+		time.Sleep(1 * time.Minute)
+		cr, err = c.client.CertmanagerV1().CertificateRequests(cr.Namespace).Create(ctx, cr, metav1.CreateOptions{FieldManager: c.fieldManager})
+		if err != nil {
+			c.recorder.Eventf(crt, corev1.EventTypeWarning, reasonRequestFailed, "Failed to create CertificateRequest: "+err.Error())
+		}
+
+		c.recorder.Eventf(crt, corev1.EventTypeNormal, reasonRequested, "Created new CertificateRequest resource %q", cr.Name)
+	}()

-	c.recorder.Eventf(crt, corev1.EventTypeNormal, reasonRequested, "Created new CertificateRequest resource %q", cr.Name)
 	if err := c.waitForCertificateRequestToExist(cr.Namespace, cr.Name); err != nil {
 		return fmt.Errorf("failed whilst waiting for CertificateRequest to exist - this may indicate an apiserver running slowly. Request will be retried. %w", err)
 	}

Release Note

Creating certificate requests with name being function of certificate name and revision. This helps to prevent the error "multiple CertificateRequests were found for the 'next' revision..."

/ok-to-test
/hold
This is quite a sensitive area of code to change, so I don't think we should just make it like this without any feature gating etc. I'm also concerned about the side effects of this change - if I remember correctly, there are certain edge cases that can come up in our controllers that have benefited from having a generated name, though I can't specifically recall them now.
If we do eventually change the default behaviour here, we may also need to communicate to our users that we are changing the naming format as in the past when we have changed names of things, we have found users have come to rely on the old format & built automation around it. I'm sure we can do it, but it may require a heads up for people.
For now, can you add a featuregate for this functionality, something like StableChallengeName, which is off by default?

/retest

/ok-to-test /hold
This is quite a sensitive area of code to change, so I don't think we should just make it like this without any feature gating etc. I'm also concerned about the side effects of this change - if I remember correctly, there are certain edge cases that can come up in our controllers that have benefited from having a generated name, though I can't specifically recall them now.
If we do eventually change the default behaviour here, we may also need to communicate to our users that we are changing the naming format as in the past when we have changed names of things, we have found users have come to rely on the old format & built automation around it. I'm sure we can do it, but it may require a heads up for people.
For now, can you add a featuregate for this functionality, something like StableChallengeName, which is off by default?

@munnerz , done!

@sathyanarays & @munnerz I like this solution and would be happy to test out the feature gate. We run enough Kubernetes clusters to possibly weed out any disadvantages of not having the unique name when creating certificate requests, too. I spent a few minutes today digging through the issues/discussions on GitHub and on Slack, but I could not find any obvious specific references to the certificate request name needing to be generated.
Outside the solution proposed here, could there be another way to check if there is another certificateRequest with the same revision already in flight before the controller attempts to create a new one? Maybe there is a way to query for certificate requests that match the given name and then look inside it for the revision? Or is the revision not available until after the request succeeds?

@sathyanarays & @munnerz I like this solution and would be happy to test out the feature gate. We run enough Kubernetes clusters to possibly weed out any disadvantages of not having the unique name when creating certificate requests, too. I spent a few minutes today digging through the issues/discussions on GitHub and on Slack, but I could not find any obvious specific references to the certificate request name needing to be generated.
Outside the solution proposed here, could there be another way to check if there is another certificateRequest with the same revision already in flight before the controller attempts to create a new one? Maybe there is a way to query for certificate requests that match the given name and then look inside it for the revision? Or is the revision not available until after the request succeeds?

@AcidLeroy , in the same file, line 184-230 checks if the certificates for the same revision already exists. It creates new certificate request only if there is no existing certificate request for the same revision. But, these checks did not work as the inflight create requests are not showing up in these checks. Only, succeeded certificate requests are returned.
	requests, err := certificates.ListCertificateRequestsMatchingPredicates(c.certificateRequestLister.CertificateRequests(crt.Namespace), labels.Everything(), predicate.ResourceOwnedBy(crt))
	if err != nil {
		return err
	}

	// delete any existing CertificateRequest resources that do not have a
	// revision annotation
	if requests, err = c.deleteRequestsWithoutRevision(ctx, requests...); err != nil {
		return err
	}

	currentCertificateRevision := 0
	if crt.Status.Revision != nil {
		currentCertificateRevision = *crt.Status.Revision
	}
	nextRevision := currentCertificateRevision + 1

	requests, err = requestsWithRevision(requests, nextRevision)
	if err != nil {
		return err
	}

	requests, err = c.deleteRequestsNotMatchingSpec(ctx, crt, pk.Public(), requests...)
	if err != nil {
		return err
	}

	requests, err = c.deleteCurrentFailedRequests(ctx, crt, requests...)
	if err != nil {
		return err
	}

	if len(requests) > 1 {
		// TODO: we should handle this case better, but for now do nothing to
		//  avoid getting into loops where we keep creating multiple requests
		//  and deleting them again.
		log.V(logf.ErrorLevel).Info("Multiple matching CertificateRequest resources exist, delete one of them. This is likely an error and should be reported on the issue tracker!")
		return nil
	}

	if len(requests) == 1 {
		// Nothing to do as we've already verified that the CertificateRequest
		// is up to date above.
		return nil
	}

	return c.createNewCertificateRequest(ctx, crt, pk, nextRevision, nextPrivateKeySecret.Name)

The problem here is that the certificate request create operation is neither transactional nor idempotent.
The operation c.createNewCertificateRequest(ctx, crt, pk, nextRevision, nextPrivateKeySecret.Name) is not transactional because successful call of this function does not mean successful creation of certificate request resource. Also, failure of this function call may not always mean that the certificate resource will not get created.
The best we could do here is to make the create operations idempotent. This is done by creating predictable names for the certificate requests in this PR. There may be other ways to bring in the idempotency.
I could think of one more way to bring in the same idempotency property. This can be done by storing the name of the certificate request that got generated in the status section of the certificate request. And we have to modify the code such that any concurrent requests should check the certificate request name in the certificate resource before proceeding with creation. Though this approach will work, there will be more changes to the core of cert-manager (we have to change the Certificate CRD for example) and we might need to think thoroughly about backward compatibility. Hence, I chose this simpler approach.

@sathyanarays Thank you for the outline, well put!

I could think of one more way to bring in the same idempotency property. This can be done by storing the name of the certificate request that got generated in the status section of the certificate request. And we have to modify the code such that any concurrent requests should check the certificate request name in the certificate resource before proceeding with creation. Though this approach will work, there will be more changes to the core of cert-manager (we have to change the Certificate CRD for example) and we might need to think thoroughly about backward compatibility. Hence, I chose this simpler approach.

How would we store the status of the certificate request? If the apiserver is running slow, wouldn't we potentially have the same timeout issue, or would the proposed status update not need to go through the apiserver? If @munnerz is worried about unintended consequences, maybe the more complex approach would be better in this case? He made it sound like there were a few use cases that relied on the generated names. If we can solve the problem without fundamentally changing the naming scheme of the certificate requests, should we perhaps prefer that one? Anyway, I'm more just thinking outloud here.

@sathyanarays Thank you for the outline, well put!

I could think of one more way to bring in the same idempotency property. This can be done by storing the name of the certificate request that got generated in the status section of the certificate request. And we have to modify the code such that any concurrent requests should check the certificate request name in the certificate resource before proceeding with creation. Though this approach will work, there will be more changes to the core of cert-manager (we have to change the Certificate CRD for example) and we might need to think thoroughly about backward compatibility. Hence, I chose this simpler approach.

How would we store the status of the certificate request? If the apiserver is running slow, wouldn't we potentially have the same timeout issue, or would the proposed status update not need to go through the apiserver? If @munnerz is worried about unintended consequences, maybe the more complex approach would be better in this case? He made it sound like there were a few use cases that relied on the generated names. If we can solve the problem without fundamentally changing the naming scheme of the certificate requests, should we perhaps prefer that one? Anyway, I'm more just thinking outloud here.

@AcidLeroy , in the alternate approach I mentioned, we are going to generate a name for certificate request and store it in the certificate resource and save the certificate resource. If there are multiple outstanding updates on a certificate resource (due to slow API server), exactly one will succeed. We will use the name from the succeeded update to generate the certificate resources.
I understand that it will be slightly difficult to visualise things. What about I make the actual changes, test it out and come up with a draft PR?

To clarify, the original bug here is not anything to do with create requests not succeeding, nor is it because only completed certificate requests are being returned.
The bug here comes about because everything in a controller is driven by the cache, which is a reflection of the apiserver's contents. When the first 'create' call is submitted, a 200 (or 201) response is returned and that object HAS been created. The bug we have hit though, is that it's taking too long (>5s in this case), for our local cache to also observe the recently created new object due to some kind of network latency, connection drop, or apiserver instability.
The object DOES already exist, it's just our own cached copy of CRs that is stored in memory is not up to date enough yet to observe it having been created.
That means that when we re-reconcile the object, we check to see if a CR for this revision already exists once again, but as our cache is out of date the controller still believes that one does not exist, so it creates another.
By making the name predictable/static, we can avoid this happening, because when we go to submit that second create call in the above example, an AlreadyExists error will be returned from the server.
Hope that clears things up a bit 😊

@sathyanarays we cannot store the name of the CR on the Certificate object for exactly the same reason - we once again may not observe our own 'update' operation on the Certificate before we go and re-reconcile the object, creating the same problem again 😅
The only way to make that sort of strategy work is to set the name before firing a Create event, as we could lean on optimistic concurrency with the resourceVersion to protect us from conflicts. However that is effectively what we are looking to do with the revision parameter already - we are persisting an ID number that helps us uniquely identify the CertificateRequest associated with a certificate/revision.

The only way to make that sort of strategy work is to set the name before firing a Create event

@munnerz , that is part of the alternate approach that I described. But, somehow missed to express that verbally.

However that is effectively what we are looking to do with the revision parameter already - we are persisting an ID number that helps us uniquely identify the CertificateRequest associated with a certificate/revision.

Exactly. The approach in the current PR effectively brings the same behavior described in the alternate approach!

To clarify, the original bug here is not anything to do with create requests not succeeding, nor is it because only completed certificate requests are being returned.
The bug here comes about because everything in a controller is driven by the cache, which is a reflection of the apiserver's contents. When the first 'create' call is submitted, a 200 (or 201) response is returned and that object HAS been created. The bug we have hit though, is that it's taking too long (>5s in this case), for our local cache to also observe the recently created new object due to some kind of network latency, connection drop, or apiserver instability.
The object DOES already exist, it's just our own cached copy of CRs that is stored in memory is not up to date enough yet to observe it having been created.
That means that when we re-reconcile the object, we check to see if a CR for this revision already exists once again, but as our cache is out of date the controller still believes that one does not exist, so it creates another.
By making the name predictable/static, we can avoid this happening, because when we go to submit that second create call in the above example, an AlreadyExists error will be returned from the server.
Hope that clears things up a bit 😊

@munnerz , Thanks for clarifying. This helps to understand the problem better!

@sathyanarays can you also change where we do the wait call so that we don't do this waiting if this feature gate is enabled? The point here being that it's no longer required for us to wait if the name is stable/predictable (as we will rely on IsNotFound errors instead).

Is it possible to add some tests for this? Also, we enable all feature gates for e2e test by default here and here

@sathyanarays can you also change where we do the wait call so that we don't do this waiting if this feature gate is enabled? The point here being that it's no longer required for us to wait if the name is stable/predictable (as we will rely on IsNotFound errors instead).

@munnerz , done!

Is it possible to add some tests for this? Also, we enable all feature gates for e2e test by default here and here

@irbekrm , done!

Added a few very minor comments, but otherwise this looks good to me! 😄 going to add /kind feature to this - when we come to flip this to default to true, I think it may be worth classifying that PR as a bugfix.. not sure 🤷
/kind feature /approve (leaving lgtm for after comments are fixed up)

@munnerz , all resolved!

Thanks for the prompt response! I have just one more comment which I should have spotted earlier.. after that though, lgtm and let's get this out for v1.10 🥳

Looking forward to seeing some of the results of this feature gate being enabled! 🥳 thanks very much for getting this one over the line! 🚀
/lgtm
/hold cancel

hmm, looks like we don't really have an appropriate area label for this 👀
/remove-area testing

Would you mind updating the release note now that this is feature gated, just to make it clear that we've added a new (gated) feature? 😄

Would you mind updating the release note now that this is feature gated, just to make it clear that we've added a new (gated) feature? 😄

@munnerz , updated. Just let me know if you have a better one!


Upgrade to v<IP_ADDRESS>-0 fails

Upgrade to 405 fails.
Logs:
Setting up /etc/nginx/nginx.conf...
Setting up /etc/php/conf.d/custom.ini...
Setting up /etc/php/conf.d/custom-opcache-jit.ini...
Setting up /etc/php/php-fpm.d/www.conf...
Starting startup scripts in /docker-entrypoint-init.d ...

*** Running: /docker-entrypoint-init.d/01-uname.sh

Linux moodle 6.6.56-1-lts #1 SMP PREEMPT_DYNAMIC Thu, 10 Oct 2024 12:04:53 +0000 x86_64 Linux

*** Running: /docker-entrypoint-init.d/02-configure-moodle.sh

Waiting for mariadb:3306 to be ready
Z
11.5.2-MariaDB-ubu2404 �  &fQC<C{d ��- ��      =   cDha-XU%SS*t mysql_native_password mariadb is ready
Using default file session store
Checking maintenance status...
Maintenance mode will be kept enabled
Upgrading moodle...

== Maintenance mode (https://edu.xxxxxxxxxx) ==

Your site is currently in CLI maintenance mode, no web access is allowed.
Checking moodle code version...
From https://github.com/moodle/moodle
 * branch                MOODLE_405_STABLE -> FETCH_HEAD
error: Your local changes to the following files would be overwritten by checkout:
	lib/classes/check/environment/publicpaths.php
Please commit your changes or stash them before you switch branches.

Aborting

*** Failed with return value: 1

Setting up /etc/nginx/nginx.conf...
Setting up /etc/php/conf.d/custom.ini...
Setting up /etc/php/conf.d/custom-opcache-jit.ini...
Setting up /etc/php/php-fpm.d/www.conf...
Starting startup scripts in /docker-entrypoint-init.d ...

Loop
I tried overriding the entrypoint and doing a git stash in /var/www/html
It did not resolve the issue.

Hi, in your /var/www/html directory, is it a separated storage that already with a copy of 404 Moodle?
BTW, you may want to mask some parts of the log in case of server info.

Thanks for the mention of redacting a bit of the logs. Updated.

Hi, in your /var/www/html directory, is it a separated storage that already with a copy of 404 Moodle?

It is a mounted volume with the previous version (if I understand your question correctly).

Then I believe the Moodle 404 also has plugin installed? Are they installed via the web interface or installed via scripts (e.g. the install-plugin-list provided in the image)?
If via scripts, one quick workaround could be preparing a new volume to store only the 405 version and install plugin on top of that, then switch to this new container.
What I am doing is build a new image with the list of plugin downloaded at build time. Then using mounted volume for the /var/www/data folder only. And disallow plugin installation via the web interface to ensure no missing plugins in the image.

So the mounts I currently have:
    volumes:
      - /etc/localtime:/etc/localtime:ro # Synchronize time of container with the host system
      - /opt/moodle/moodledata:/var/www/moodledata
      - /opt/moodle/moodlehtml:/var/www/html

I do not have any plugins installed that aren't defaults (I believe?). If they are installed I would presume by web interface as I have no env variable or any reference to the install-plugin-list
Do I need to alter my volume mount from /var/www/moodledata to /var/www/data?
Perhaps that changed during an upgrade that I missed.
Thanks for your attention as always :)

Sorry typo, the folder is still /var/www/moodledata.
The problem is caused by the modification of the publicpaths.php file at 02-configure-moodle.sh#L252 which Git will treat as uncommitted change when switching to the 405 branch.
I am developing a hot fix for this scenario.

Many thanks!

So what I've come to realize is the purpose of mounting /var/www/html is to preserve theme edits (and why "plugins" didn't register as something I was doing).
I had installed a theme and lost it during this upgrade (no real casualty). A documented way on handling this might be something to consider to prevent others from experiencing it perhaps?.
Sharing the logs hoping it helps. Steps that caused this

I removed the html mount
upgraded
disabled maintenance
had default theme (makes sense, my theme isn't mounted)
shutdown
added the mount back
startup to error below

== Maintenance mode (https://edu.xxxxxxxxxxxx.xxx) ==

Your site is currently in CLI maintenance mode, no web access is allowed.

Checking moodle code version...

fatal: Unable to create '/var/www/html/.git/shallow.lock': File exists.

Another git process seems to be running in this repository, e.g.

an editor opened by 'git commit'. Please make sure all processes

are terminated then try again. If it still fails, a git process

may have crashed in this repository earlier:

remove the file manually to continue.

ERROR!!!  The code you are using is OLDER than the version that made these databases!

*** Failed with return value: 1

Glad to hear that you have found a workaround and luckily the impact is not huge. Definity it is a good idea to have some documentation regarding persistence and upgrade.
Even better, the fix is ready and will be available at the next v<IP_ADDRESS>-1 in a couple of hours.


Do not load my project, still loading infinitive mode

I'm trying to load a simple java project, it was worked before.
and Now the VScode / Project Manager do not load the "Java Project"

the settings.json
`{
"java.project.sourcePaths": [
"src"
],
"java.configuration.runtimes": [
{
"name": "JavaSE-1.8",
"path": "/usr/lib/jvm/java-8-openjdk-armhf/",
"default": true
},
{
"name": "JavaSE-11",
"path": "/usr/lib/jvm/java-11-openjdk-armhf/"
  }
],
"JAVA_HOME":"/usr/lib/jvm/java-11-openjdk-armhf/"

}`
also I tried "java.home", anyway I cant run the java ,

The spinning icon in the status bar means that the Language Server is activating. What will you see if clicking on it?

when I click in the circle this screen is appear

How about the server log? You can check it by triggering the command Java: Open Java Language Server Log


Disable libvirt TLS for now

The current certs are not valid for libvirt.
Specific requirements in https://libvirt.org/kbase/tlscerts.html

/retest

recheck

recheck

recheck

recheck

recheck

/lgtm

Current failures look related /var/lib/openstack/cacerts/nova-custom/tls-ca-bundle.pem: no such file (?)
https://logserver.rdoproject.org/13/613/7c897237934d546bb9e0042206b49289f4a14ce0/github-check/podified-multinode-edpm-deployment-crc/9e1f45b/controller/ci-framework-data/logs/openstack-k8s-operators-openstack-must-gather/namespaces/openstack/pods/nova-custom-edpm-deployment-ipam-openstack-edpm-ipam-dn88s/logs/openstackansibleee.log

recheck


Feature request: Game Development Workstation AMI

Use case
The process of creating a workstation on AWS for Unreal Engine development is manual and tedious. I need to provision an instance, install a remote desktop server, configure graphics drivers, install IDEs and download the engine.
Solution/User Experience
Provide a Packer template for building AMIs capable of UE (and other C++ game engine) development. Parameterized installation of the following:

Jetbrains Rider
Git, P4V and p4 client
Common CI and build acceleration agents (Jenkins, TeamCity, Horde, Incredibuild)
Visual Studio + Microsoft build tools

It should also install and configure common remote desktop servers:

NiceDCV
Parsec

And also automatically install graphics drivers and configure them for G family instances.
Optional: Automatically install Unreal Engine following EULA acceptance.
Alternative solutions
Provide Image Builder recipes for this or use existing Cfn templates as a base.

@henrykie Is this a dependency of #290?


Publish to open VSX

https://open-vsx.org/
I use the gitpod.io service which can pull from the openvsx registry.
I can manually install the vsx from the VS Code marketplace but that is less ideal than having it built into gitpod's native registry.

Alternatively or until you get it published to openvsx; If you could release it here on github as a .vsx file that way I can just use the github release link to install it directly to my gitpod workspace.

Hi Garrett, if I understand it right, you suggest to publish this extension to alternate registries?

Correct. The licensing for the VS Code registry doesn't allow any software besides Microsoft's official VS Code releases to interact with the registry. Or something like that. I use gitpod.io 's built in editor based on vs Code which uses Open VSX as it's registry.

https://www.gitpod.io/docs/vscode-extensions

Sorry for all the posts, I'm still half asleep;
It can take a couple days to get ownership of a namespace in the open vsx registry so a solution until then would be to release this extension on github as a .vsix file.

I published a new release:

https://github.com/xpack/vscode-xpack-extension-ts/releases/tag/v0.4.16

As for the openvsx registry, I probably need to take some time to understand what it is and how it can be used.
But, for my information, why would someone not use VS Code directly and prefer alternate solutions which require alternate registries?

Mircosoft doesn't allow unofficial VS Code builds to use their registry.

Mircosoft doesn't allow unofficial VS Code builds to use their registry.

What I'm trying to understand is what other unofficial builds should be considered, and if possible, why they exist, why the official build is not enough?

https://www.gitpod.io/blog/open-vsx

I logged in to Open VSX, I signed the publisher agreement, I created the publish authentication token, but when I tried to publish the extension, it failed, for obvious reasons:
...
webpack 5.49.0 compiled with 1 warning in 3478 ms
 DONE  Packaged: /var/folders/3h/98gc9hrn3qnfm40q7_0rxczw0000gn/T/tmp-66568-JU75BEA1vsX4-.vsix (10 files, 108.84KB)

❌  Cannot resolve dependency: ms-vscode.cpptools
See the documentation for more information:
https://github.com/eclipse/openvsx/wiki/Publishing-Extensions

The xPack extension obviously makes use of the MS C++ extension, which is available only from the VS Code Marketplace.
Sorry to say, but I maintain my bad impression of all these jolly joker pseudo-solutions.

Thanks for trying. I should have realized this would be an issue.
Feel free to close, adding the .vsix to the release is sufficient for my experiments.


getchar sample not working on nRF5x

This commit broke the samples/subsys/console/getchar sample.

@jarz-nordic can you make sure your PR fixes this?

This commit 05c45e359a94e96353dfac1f0abeccf6893e988a https://github.com/zephyrproject-rtos/zephyr/pull/7431 broke the samples/subsys/console/getchar sample.

There's a comment on that commit that zephyr shell is broken too:
https://github.com/zephyrproject-rtos/zephyr/commit/05c45e359a94e96353dfac1f0abeccf6893e988a#commitcomment-29012316 .
I don't have a nRF5x system with UART connection, so can't check it myself.

@pfalcon different issue though. Both shell and getchar work with this PR anyway, so this is fine


4918 telegraf write example

Closes #4918
Copied brief Telegraf config examples to get-started.
Linked to Use Telegraf page for config detail.
Ported Use Telegraf
Cleanup
Tailor v2 python client libraries for Dedicated and Serverless

[ ] Signed the InfluxData CLA
(if necessary)
[ ] Rebased/mergeable

Might be worth checking with @powersj whether we still want to recommend env vars over secret stores for token storage.
Other than that, a few minor tweaks

@powersj Other than release notes, I don't see any documentation for using secret-stores with Telegraf plugins.
I see the --secretstore-filter option and specific implementations in some plugins. Can you point me to more info or examples that I can adapt for docs?


Unable to invoke subcommands

Hi!
I followed your installation guide, installed and link successfully mysql, etc. But after I run this command> swift build -Xswiftc -I/usr/local/include/mysql -Xlinker -L/usr/local/lib
I get the following error message > error: unable to invoke subcommand: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/swift-build (No such file or directory)
How can I solve this problem or what did I in a wrong way? My xCode Verision is> Version 7.3.1 (7D1014) and I installed Swift June 20, 2016 development snapshot.
Thanks

That means you are using Swift 2.
I made a tutorial here for getting started with Vapor, it would help with this package, too.
https://www.youtube.com/watch?v=YxvQo-EH2AA


Revert broccoli asset rev change

Fixes #275.
ember-cli-terser 4.0.2 contains a regression documented in #275 which forces people using both ember-cli-terser and broccoli-asset-rev to pin ember-cli-terser to 4.0.1.
One way forward is to revert the change which introduced the regression (PR #266) and release this as 4.0.3.

🙏 Please, please merge this and find a proper fix for https://github.com/ember-cli/ember-cli-terser/issues/265. It took me several days to figure out why source maps are broken and that it is caused by a regression with ember-cli-terser

is there any way you could add a test for this so the regression doesn't re-introduce itself?
Though, I guess because https://github.com/ember-cli/ember-cli-terser/pull/266 didn't contain any tests, we can't be sure that it was actually fixing anything either.
I'm in favor of merging this PR and releasing 4.0.3, and we really need tests added to cover this stuff before any additional changes around addon load order are done.

cc @rwjblue and @kellyselden ? idk who to tag :sweat_smile:

@st-h can you describe what sort of sourcemaps you are expecting?

hi-fi pre-babel sourcemaps?
or just "good enough" pre-terser sourcemaps?

@NullVoxPopuli the problem is that source maps usually contain a sources entry that contains the different classes of the application like myApp/routes/application. After the changes made in https://github.com/ember-cli/ember-cli-terser/pull/266 the sources entry only contains one link to the minified js file like assets/myapp-<fingerprint>.js. So the source maps just link to the minified js, and therefor won't work.

is it feasible for you to just use the older version?
The thing is that #266 fixed issue #265, so to revert #266 will re-break #265.

@NullVoxPopuli Yes, both. Sure it is possible to just stick to the old version if one requires working source maps. However,  I am quite puzzled why the author of https://github.com/ember-cli/ember-cli-terser/pull/266 did not run into that issue. Given that there are quite a few users that commented on https://github.com/ember-cli/ember-cli-terser/issues/275, I can't be the only one having those issues. I think reverting https://github.com/ember-cli/ember-cli-terser/pull/266 would be a good idea as other users very likely will run into the same issue and it is quite difficult to track down which addon in which version causes it. (As I already mentioned, it took me days of trial and error) We certainly should be looking for a fix for #265 that does not render source maps useless. But at this point I think keeping things the way they are and hoping users that are affected by this regression will figure things out one day or the other is the worst option that we have.
Also, I wonder what did you do to resolve the issue, as you have also been commenting on #275? Might be there is a workaround none of us are aware of, which also worked for the author of https://github.com/ember-cli/ember-cli-terser/pull/266 without knowing about it. There probably is some sort of configuration or something that does not trigger the regression.

@NullVoxPopuli any updates?  What was your workaround to fix this issue in your codebase?

I think at this point we just have two versions folks use depending on the problem the users are facing. Until someone understands and can debug and fix both problems at the same time, that's how it's gotta be for now (imo, of course). The goal is to move to embroider, and ember-cli-terser is not used under embroider, so an option is to do that migration (I think, I could be wrong).
The main problem here is that different people want different levels of fidelity in production. Ultimately though, everyone should be comfortable with reading the "good enough" output in production. Because even outside of ember, that's sometimes all you can ask for.

If different people want different behaviour, perhaps this should be a config instead of forcing people to pin an older version?


Enable jetifier to use AndroidX dependencies

Facebook didn't upgrade to AndroidX yet. Use Android Jetifier to use the new AndroidX libraries instead of the older legacy ones.

Pull Request Test Coverage Report for Build 118

0 of 0   changed or added relevant lines in 0 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage increased (+1.4%) to 89.412%

Files with Coverage Reduction
New Missed Lines
%

lib/flutter_facebook_login.dart
1
89.02%

Totals

Change from base Build 110:
1.4%

Covered Lines:
76

Relevant Lines:
85

💛  - Coveralls

From your perspective, would this mean that we would only merge this PR, or merge #87 too?

I am not sure since I didn't notice the other PR. I think this PR is enough since it uses Jetifier, which the other PR does not use.
For me this solution works well in combination with other dependencies, however you might want to check it as well.

Should fix issues:
#95, #93, #92, #89 (using API 28), #85

Waiting this to land ASAP. Thank you.

@miguelpruivo you can temporarily add the following to your pubspec.yaml:
flutter_facebook_login:
    git:
      url: https://github.com/gi097/flutter_facebook_login
      ref: develop

Thanks!
I just verified that this is working on a sample project and the Reflectly repo.
I would love people to test this and verify that it works. If everything is fine, I'll make a new major release on Pub in a couple days. Follow these instructions to migrate your Flutter app to AndroidX and then include the AndroidX -compatible flutter_facebook_login like this:
dependencies:
  flutter_facebook_login:
    git:
      url: https://github.com/roughike/flutter_facebook_login
      ref: e69fef3


ARIA-305 Advance ARIA version

Set package version to 0.2.0

Can one of the admins verify this patch?


SFTP downloads create un-deletable  duplicates of files

Describe the bug
When downloading files over SFTP to my device, I am prompted to choose where to save the file. The file then takes up space in that location, but the downloaded data also seems to be kept in WebSSH’s storage.
Example: Downloading a 4 GB video file and saving it to a folder in the “On My iPad” tab of Files saves the video in that location as expected. However, the size of the WebSSH app on my device is increased by ~4 GB as well. Deleting the video file from the Files app (and clearing “recently deleted”) frees up that 4 GB of space, but WebSSH still takes up an additional 4GB of space which can only be reclaimed by deleting the WebSSH app and re-downloading it from the App Store.
Informations

Device : iPad Mini 5
OS : iPad OS 14.7.1
WebSSH Pro version : 15.1.2

Screenshots
Fresh install of  WebSSH:

Saving file to my iPad via SFTP:

File is saved in correct spot, as expected:

WebSSH now takes up a lot more space:

Even after the file has been deleted from “On My iPad” and from “Recently Deleted”, WebSSH still takes up a lot of space:

To Reproduce
Steps to reproduce the behavior:

Open system storage and take note of how much space is taken by WebSSH “Documents & Data”
Launch WebSSH and connect to a server via SFTP
Tap on a file and select “Download”
Once download is complete and you are prompted to choose a location to save it, do so
Return to system storage and see that WebSSH “Documents & Data” has increased by roughly the size of the file downloaded
Check that the selected download location also contains the file and takes up the expected amount of space
Delete the downloaded file using the “Files” app
Storage is reclaimed from the deleted file, but checking system storage shows that WebSSH still takes up additional space

Hello @wyntrr-end 👋
Thank you a lot for these reproduce steps 🙏
I will fix this issue with a high priority.
Have a nice day ☀

Hello @wyntrr-end
In the upcoming 16.0.2 Beta Release, temporary files will be deleted :

at WebSSH startup
at SFTP disconnection

@isontheline Awesome, thank you so much! I greatly appreciate your timely response

Should be fixed in WebSSH 16.0.3 : https://testflight.apple.com/join/QSrBK59z


Run juice even without a stylesheet so

I have the same request as https://github.com/niftylettuce/node-email-templates/issues/35.
What I've done here allows me to do something like this:
<style>
  <% include ../shared-styles.css %>
</style>

so that multiple email templates share CSS that gets inlined by juice. I implemented this in a weird, lazy way, so I understand you probably won't want to merge it without some cleaning up.
Are you willing to support something like this or come up with a better way to share CSS?

Any chance this will ever be resolved?

@custa1200 this PR was for a very old version of this project. I'll take a PR if you want to take a stab at it


[Umbrella] Examples in real code

(Please feel free to add your changes!)
NOT a Bug
Bug

[x] https://github.com/istio/istio/pull/40706
[x] https://github.com/ethereum/go-ethereum/pull/25618
[x] https://github.com/influxdata/influxdb/pull/23685
[x] https://github.com/minio/minio/pull/15607
[x] https://github.com/kubernetes/minikube/pull/14882
[x] https://github.com/etcd-io/etcd/pull/14405
[x] https://github.com/etcd-io/etcd/pull/14390
[x] https://github.com/prometheus/prometheus/pull/11225
[x] https://github.com/rook/rook/pull/10827
[x] https://github.com/argoproj/argo-cd/pull/10479
[x] https://github.com/argoproj/argo-workflows/pull/9465
[ ] https://github.com/kubernetes/ingress-nginx/pull/8995
[x] https://github.com/kubevirt/kubevirt/pull/8377
[x] https://github.com/containerd/containerd/pull/7338
[x] https://github.com/thanos-io/thanos/pull/5660
[x] https://github.com/grpc/grpc-go/pull/5616
[x] https://github.com/coredns/coredns/pull/5592
[x] https://github.com/cert-manager/cert-manager/pull/5413
[x] https://github.com/vmware-tanzu/velero/pull/5261
[x] https://github.com/dapr/dapr/pull/5099
[x] https://github.com/caddyserver/caddy/pull/4986
[x] https://github.com/kubeedge/kubeedge/pull/4147
[x] https://github.com/spiffe/spire/pull/3377
[x] https://github.com/goreleaser/goreleaser/pull/3347
[x] https://github.com/fatedier/frp/pull/3081
[ ] https://github.com/kubernetes-sigs/external-dns/pull/2986
[x] https://github.com/junegunn/fzf/pull/2948
[x] https://github.com/ent/ent/pull/2892
[x] https://github.com/evanw/esbuild/pull/2502
[x] https://github.com/volcano-sh/volcano/pull/2470
[x] https://github.com/GoogleContainerTools/kaniko/pull/2232
[x] https://github.com/jesseduffield/lazygit/pull/2143
[ ] https://github.com/cue-lang/cue/pull/1895
[x] https://github.com/mikefarah/yq/pull/1322
[x] https://github.com/github/gh-ost/pull/1175
[x] https://github.com/uber-go/zap/pull/1169
[x] https://github.com/onsi/ginkgo/pull/1028
[ ] https://github.com/Netflix/chaosmonkey/pull/76

some releated issue

[x] https://github.com/golang/go/issues/54740 and Trying to fix CL 426594 has been fixed by CL 426734, just wait a new release.
[x] https://github.com/golang/go/issues/54774 and has been fixed by CL 426654
[x] https://github.com/golang/go/issues/54789 not a bug, will not fix

The above example is enough to show that the wrong duplicate word problem exists in a large number of open source go projects, and if a pull request can be proposed to fix the problem, the probability is that the pull request will be merged.
So just close this issue.


Navbar submenus only work with anchor tags, but anchor tags need hrefs, and anchors with hrefs are impossible to hover on mobile

Sorry for the long title.
So basically, if I have a nav as similar to in Daisy UI docs:

						Projects
						<Icon name="chevron_right" class="w-4 h-4" />

All Projects

Popular

New

Recently Updated

Then on line 2 I have  which is an anchor with no href. This is bad for accessibility, will affect SEO, and the linters go nuts over it, in my IDE, in code analysis, on build, etc. so this isn't an option.
Changing to a  would work, except on small viewports on desktop I can hover a lower menu, then hover a higher menu and get this:

Where both menus are shown on top of each other, which is less than ideal.
Lastly, I can give the anchor tag an href, but this means on mobile users will not be able to navigate the sub menu.

As a side note, I'm having tabindex issues with the submenu, and even giving all elements tabindex="0" doesn't seem to make them focusable.
Thanks in advance, and I absolutely love this component library.

@justingolden21 Can you please provide a code sample where you have hover issues with  as you mentioned?
Because in this example, I'm using  instead of  and it works as expected. You should be able to use  instead of .
About the "tabindex issues", can you tell me what is exactly the issue? and tell me about your OS and browser version?


Trouble this Timer High Level APIs

I'm new about Pico SDK, so I'm just experimenting the APIs... I don't understand why this piece of code doesn't print triggered, unless I decomment sleep_ms(1). It seems the interrupt never triggers.
Reading the docs, the alarm_callback runs in IRQ context, so I don't need to insert sleep_ms(1). Moreover, in the example, in the alarm_callback there is a printf... Is it safe calling a printf in an IRQ routine?
If I'm missing something, let me know please.
I'm using RP2350 and SDK v2.1.0.
#include <stdio.h>
#include "pico/stdlib.h"
#include "hardware/timer.h"

const absolute_time_t period = 1000000;

volatile bool irqTriggered;

absolute_time_t tim = 1000000;

int64_t alarm_callback(alarm_id_t id, void *user_data) {
    irqTriggered = true;
    tim += period;
    add_alarm_at(tim, alarm_callback, NULL, false);
    return 0;
}

int main()
{
    stdio_init_all();

    irqTriggered = false;

    add_alarm_at(tim, alarm_callback, NULL, false);

    while (true) {
        //sleep_ms(1);

        if(irqTriggered){
            irqTriggered = false;
            printf("triggered\n");
        }
    }
}

Sorry, I can't seem to reproduce the problem. I see the printf with or without the sleep. Are you using stdio usb or stdio uart (what pico_enable_stdio_* lines do you have in your cmake file)?

Is it safe calling a printf in an IRQ routine?
It's safe, although it's somewhat unwise.

Adding an alarm at a specific time with add_alarm_at is a bit dangerous as it might be in the past? I would suggest adding a hard_assert that it's returning >0. And/or use add_alarm_in_ms instead.

Also, you might want to look at https://www.raspberrypi.com/documentation/pico-sdk/high_level.html#group_repeating_timer rather than repeatedly setting new alarms in your alarm-callback?

Also worth trying the develop branch to pick up this fix https://github.com/raspberrypi/pico-sdk/commit/969f5895aa6790a9c1af8ed31ccd06cc81fe36cf

Are you using stdio usb or stdio uart (what pico_enable_stdio_* lines do you have in your cmake file)?

I'm using:
pico_enable_stdio_uart 1
pico_enable_stdio_usb 0

https://www.raspberrypi.com/documentation/pico-sdk/high_level.html#group_repeating_timer

I know this api, but I need to change the period between an activation and the next one. I know I can even use other peripherals, but now I'm just playing with this API.
I have a smaller piece of code that gives me problem:
#include <stdio.h>
#include "pico/stdlib.h"
#include "hardware/timer.h"

int main()
{
    stdio_init_all();
    printf("Current time: %llu\n", get_absolute_time());
    printf("Current time: %llu\n", get_absolute_time());
    printf("Current time: %llu\n", get_absolute_time());
    printf("Current time: %llu\n", get_absolute_time());
    sleep_ms(100);
    printf("Current time: %llu\n", get_absolute_time());
}

It prints:
Current time: 0
Current time: 0
Current time: 0
Current time: 0
Current time: 100000

It seems the timer doesn't count untill sleep_ms().
The CMakeList:
# Generated Cmake Pico project file

cmake_minimum_required(VERSION 3.13)

set(CMAKE_C_STANDARD 11)
set(CMAKE_CXX_STANDARD 17)
set(CMAKE_EXPORT_COMPILE_COMMANDS ON)

# Initialise pico_sdk from installed location
# (note this can come from environment, CMake cache etc)

# == DO NOT EDIT THE FOLLOWING LINES for the Raspberry Pi Pico VS Code Extension to work ==
if(WIN32)
    set(USERHOME $ENV{USERPROFILE})
else()
    set(USERHOME $ENV{HOME})
endif()
set(sdkVersion 2.1.0)
set(toolchainVersion 13_3_Rel1)
set(picotoolVersion 2.1.0)
set(picoVscode ${USERHOME}/.pico-sdk/cmake/pico-vscode.cmake)
if (EXISTS ${picoVscode})
    include(${picoVscode})
endif()
# ====================================================================================
set(PICO_BOARD pico2 CACHE STRING "Board type")

# Pull in Raspberry Pi Pico SDK (must be before project)
include(pico_sdk_import.cmake)

project(timer C CXX ASM)

# Initialise the Raspberry Pi Pico SDK
pico_sdk_init()

# Add executable. Default name is the project name, version 0.1

add_executable(timer timer.c )

pico_set_program_name(timer "timer")
pico_set_program_version(timer "0.1")

# Modify the below lines to enable/disable output over UART/USB
pico_enable_stdio_uart(timer 1)
pico_enable_stdio_usb(timer 0)

# Add the standard library to the build
target_link_libraries(timer
        pico_stdlib)

# Add the standard include files to the build
target_include_directories(timer PRIVATE
  ${CMAKE_CURRENT_LIST_DIR}
)

# Add any user requested libraries
target_link_libraries(timer
        hardware_timer
        )

pico_add_extra_outputs(timer)


(WIP) Redis signed int parsing

features a comparison with stdlib
currently can run the bench with cargo bench -p storage-types
This is the output I get on my machine, running in WSL2 on Windows 10 with a Ryzen 9 3900X 12 core processor and 64 GB of RAM
parse_signed_redis/parse_numbers
                        time:   [13.678 ns 13.705 ns 13.734 ns]
                        thrpt:  [72.814 Melem/s 72.964 Melem/s 73.109 Melem/s]
                 change:
                        time:   [-2.7599% -2.3710% -1.9982%] (p = 0.00 < 0.05)
                        thrpt:  [+2.0389% +2.4286% +2.8382%]
                        Performance has improved.
Found 7 outliers among 100 measurements (7.00%)
  1 (1.00%) low mild
  5 (5.00%) high mild
  1 (1.00%) high severe
parse_signed_redis/parse_numbers_std_lib
                        time:   [19.250 ns 19.303 ns 19.354 ns]
                        thrpt:  [51.668 Melem/s 51.805 Melem/s 51.947 Melem/s]
                 change:
                        time:   [-2.6327% -2.2841% -1.9340%] (p = 0.00 < 0.05)
                        thrpt:  [+1.9721% +2.3375% +2.7038%]
                        Performance has improved.
Found 1 outliers among 100 measurements (1.00%)
  1 (1.00%) high mild

I'd need to add a lot more cases to the benchmark before trusting the results

closing in favor of https://github.com/pelikan-io/pelikan/pull/62 which implements the INCR method as well as this parsing logic


Include multiple html files in the project

It seems like the bundlejs is not imported into the other html files, and only imported on the index.html.
Assuming that is something to configure on the webpack.config.

Closed by #12


Enhancement: Make v5 More Expressive

TL:DR Here's a demo of how the v5 could be more expressive (see app.component).  https://stackblitz.com/edit/angular-q7fbm7
The new API is looks good from a minimalist perspective, but it misses the opportunity to simplify tasks should be easy. Let's say you want to do something very common - query a list, then make secondary queries for denormalized data with a specific key.
// v4
const books = db.list('/books', { query: { limitToFirst: 5 } })

// v5 (this is not approachable code IMO)
this.ref = db('books', ref => ref.limitToFirst(5) )
const books = ref.snapshotChanges().map(arr => {
      return arr.map(snap => Object.assign(snap.payload.val(), { $key: snap.key }) )
 })

Proposal
Make common tasks easier to read and perform. The new flexibility can be preserved, while giving developers an simple and approachable API. I hacked together this wrapper of my vision here: https://stackblitz.com/edit/angular-q7fbm7
// option to make queries with objects - much easier than chaining methods in most cases
const ref = db.query('books', { limitToFirst: 5 })

// use a new get method to make the API expressive and flexible
const books = ref.get({ withKeys: true })

// Do other useful stuff while we're at it
this.ref.get({ reverse: true }) /// reverse list
this.ref.get({ callback: callbackFn }) /// map the array with your own callback

There has just been a rewrite of the Database API, see here https://github.com/angular/angularfire2/issues/1158

@codediodeio Thanks for taking the time to send up this proposal! I'm interested in these changes but I don't think they belong in the core API. Perhaps we could provide an additional module?

@Toxicable This is in reference to the rewrite.
@davideast A utility module providing Lodash-style simplification would be extremely useful. I predict new users will get frustrated when trying to do basic data wrangling in Angular.

@codediodeio great! Would you like to flush out a official proposal for a utility module?

@davideast Is there a template for an "official proposal" or do you mean a PR?

@codediodeio First we need an issue. There's no official template. You can take a look at what I've done in the past (#1158). It doesn't have to be perfect. The main thing is to include the interfaces and a small code sample so we can get a good idea of how it would be used.

@davideast Sounds good


Decide on an Item abstract data type

What should items look like? How should they behave?
We want items to be as flexible as possible, assuming only that they know their user and their target (possibly the same). Possible subdivisions of items might be:
Equipables: tools, apparel, etc.
Consumables: potions, food, etc.
(Other categories?)
I really have no idea who we should do this, so any suggestions are more than welcome.

So, on the develop-inventory branch, I have added two modules:
item.py defines the item metaclass, and the equippable class. I still aim to add a consumable items as well.
I have also added an inventory.py module. This defines the inventory class. The underlying implementation is suboptimal. The basic interface should be kept the same, but any changes to the interface are welcome.


[FLINK-3186] Deprecate DataSink.sortLocalOutput() methods

Thanks for addressing the issue, merging this...


Fix a bug where a GrpcDocServicePlugin does not handle exact path map…

…pings
Motivation:
When a user adds a GrpcService with ServerBuilder.service(ServiceWithPathMappings),
GrpcDocServicePlugin fails to add the service endpoints to ServiceSpecification.
To work around this issue, a user has to fall back to the old usage:
ServerBuilder sb = ...;
sb.serviceUnder("/", grpcService); // Works
sb.service(grpcService); // Does not work

Modifications:

Update the endpoint detection logic in GrpcDocServicePlugin

Result:

Fixes #1136

Thanks, reviewers!


Unit test implementation for C++

Which framework should we use for C++ unit tests? Looks like CodeCov offers multiple options for C++. If @T-Rex96 you decide which one we should pick, I will go ahead and include the C++ build in our .travis.yml. Same thing for JS, Go and C, but for those languages I actually know how to do testing/CI so I'll take care of that as soon as possible. I think I only need help with C++, really.

I think Catch2 is the most popular one at the moment, this looks like an example for how to set it up

Good point. I will take a look at it and let you know if I have any problems integrating it into our pipeline. If I manage to streamline the build and automate testing for C++, I will put a note into the README.md for future reference and close this issue. If not, I'll post any issues here.


Update PostgreSQL pgdg apt repository GPG key previous one expired

When attempting to build the heroku-18 stack image it looked like the GPG key for the PostgreSQL PGDG apt repositories in these stack images expired July 2, 2019.
This replaces the key with the one here: https://www.postgresql.org/media/keys/ACCC4CF8.asc (https://wiki.postgresql.org/wiki/Apt), which allowed us to build the image.

Thank you very much!
I'm going to close this PR because cedar-14 needs to have PRs not on a fork to have our Canonical long-term support credentials.


DOC: stats: Fix spelling of 'support'.

What does this implement/fix?
Fixes the spelling of "support" in two places in the stats tutorials.

Thanks Warren


Add ElasticSearchClient (fixes #235)

Prathiba indicated incompleteness of /v1/listLtpsAndFcs and a mistake in the example of the oam put request addressing service-records-policy. Will close this pull-request and solve the changes in a new pull-request without further reviewing.


build(docs): Add MetaData to DocumentNode

we are adding packageName to DocumentNode so its easier to pull the package information into our docs

Probably worth noting in the PR description that this change is breaking, since it changes the signature of DocumentNode.
Additionally, you'll want to bump the version field of the package.json to 0.9.0. We can publish a new version once the PR has merged.