Question regarding creating a registry wrapper class

I am currently working on creating a wrapper class to basic_registry, the reason is to reduce access to certain functions and simplify some flows.
One of my attempts is the following, a function to hook on_construct and connect to the signal at the same time:
    using F = std::function<void(registrywrapper &, entity)>;
    template <typename Component>
    auto on_create(F f) {
        return _registry.on_construct<Component>().connect([](F &ptr, entt::registry &r, entity e) {
            ptr(r.ctx<registrywrapper>(), e);
        }, &f);
    }

However, the problem seems to be that registry creates the signal expecting (entt::registry &, const entt::entity). How can I expand upon this signature and/or pass in a parameter that can be later used (because connect won't allow capturing lambdas). I know I can potentially set some ctx variables in the registry and then access them like I'm doing with ctx but I don't think that's a scalable solution for this scenario.
Thanks!

Hi, do you mind if I convert this issue in a discussion? I think it's better suited. As for your question:

How can I expand upon this signature and/or pass in a parameter that can be later used

Signal support is nothing more than a mixin. You can just define your own and replace it by specializing the storage_traits class (which is a sfinae-friendly one). The registry is fully transparent to the type returned by on_construct and similar, so you don't have to touch it in any way.
Roughly speaking, you can define and set up your mixin that also accepts capturing lambdas and make it return the derived registry to the callbacks. If you want to stick with the current behavior, you can just copy what the sigh_storage_mixin does already and only replace the parts of interest (i.e. the sigh type with a list of std::functions or similar).

Hi, do you mind if I convert this issue in a discussion? I think it's better suited. As for your question:

How can I expand upon this signature and/or pass in a parameter that can be later used

Signal support is nothing more than a mixin. You can just define your own and replace it by specializing the storage_traits class (which is a sfinae-friendly one). The registry is fully transparent to the type returned by on_construct and similar, so you don't have to touch it in any way. Roughly speaking, you can define and set up your mixin that also accepts capturing lambdas and make it return the derived registry to the callbacks. If you want to stick with the current behavior, you can just copy what the sigh_storage_mixin does already and only replace the parts of interest (i.e. the sigh type with a list of std::functions or similar).

Hi, I have the same issue here, but I am not quite understand how to implement this. In my case, I have an Entity class which encapsulates registry and entity both and I want the callback to my Entity class as the argument... Is it possible? Thanks a lot!

I want the callback to my Entity class as the argument

Is it the same entity that you store in the registry/pools? Otherwise, how does a pool know about it when it's time to send a signal? 🤔

I want the callback to my Entity class as the argument

Is it the same entity that you store in the registry/pools? Otherwise, how does a pool know about it when it's time to send a signal? 🤔

In fact, what I mean is to change callback signature from (registry&, entity) to entity, and that's enough, as I can outside create  my Entity out of that passed in entity argument.

The question remains the same: it's possible but where the storage is supposed to find a link to the scene?
Cuz from what I get you're still using entt::entity under the hood. So, this is what the storage has. It know nothing about th scene itself. How can it construct an Entity then? I think I'm missing a piece of your idea here.

The question remains the same: it's possible but where the storage is supposed to find a link to the scene? Cuz from what I get you're still using entt::entity under the hood. So, this is what the storage has. It know nothing about th scene itself. How can it construct an Entity then? I think I'm missing a piece of your idea here.

In my situation, I have a System class holding a reference to my Scene. So that I will only register callback in my System and construct my Entity through that Scene reference. As a result, entt::registry is not needed in this case.

The question remains the same: it's possible but where the storage is supposed to find a link to the scene? Cuz from what I get you're still using entt::entity under the hood. So, this is what the storage has. It know nothing about th scene itself. How can it construct an Entity then? I think I'm missing a piece of your idea here.

In my situation, I have a System class holding a reference to my Scene. So that I will only register callback in my System and construct my Entity through that Scene reference. As a result, entt::registry is not needed in this case.

Hi, do you mind if I convert this issue in a discussion? I think it's better suited. As for your question:

How can I expand upon this signature and/or pass in a parameter that can be later used

Signal support is nothing more than a mixin. You can just define your own and replace it by specializing the storage_traits class (which is a sfinae-friendly one). The registry is fully transparent to the type returned by on_construct and similar, so you don't have to touch it in any way. Roughly speaking, you can define and set up your mixin that also accepts capturing lambdas and make it return the derived registry to the callbacks. If you want to stick with the current behavior, you can just copy what the sigh_storage_mixin does already and only replace the parts of interest (i.e. the sigh type with a list of std::functions or similar).

Is there a step by step way to achieve this? I have a class derived from entt::registry and I do not know how to pass my class around instead of entt::registry as callback argument. Thanks a lot!

Oh, I see. Yeah, there is defniitely a way.
You must define a mixin mostly similar to the sigh_storage_mixin. The only difference is that it works with your class rather than the registry class.
Then, you can specialize the storage_traits template to use your mixin as a default rather than the sigh_storage_mixin. If I remember it correctly, the documentation contains enough details about this. If this isn't the case, feel free to drop a line here and I can help further. 👍

Oh, I see. Yeah, there is defniitely a way. You must define a mixin mostly similar to the sigh_storage_mixin. The only difference is that it works with your class rather than the registry class. Then, you can specialize the storage_traits template to use your mixin as a default rather than the sigh_storage_mixin. If I remember it correctly, the documentation contains enough details about this. If this isn't the case, feel free to drop a line here and I can help further. 👍

I have tested but I come across a null pointer during bind() call in mixin class:
class Reg : public entt::registry
{

};

namespace entt {
    /**
        * @brief Mixin type used to add signal support to storage types.
        *
        * The function type of a listener is equivalent to:
        *
        * @code{.cpp}
        * void(basic_registry<entity_type> &, entity_type);
        * @endcode
        *
        * This applies to all signals made available.
        *
        * @tparam Type The type of the underlying storage.
        */
    template<typename Type>
    class my_sigh_storage_mixin final : public Type {
        using basic_iterator = typename Type::basic_iterator;

        template<typename Func>
        void notify_destruction(basic_iterator first, basic_iterator last, Func func) {
            ENTT_ASSERT(owner != nullptr, "Invalid pointer to registry");

            for (; first != last; ++first) {
                const auto entt = *first;
                destruction.publish(*owner, entt);
                const auto it = Type::find(entt);
                func(it, it + 1u);
            }
        }

        void swap_and_pop(basic_iterator first, basic_iterator last) final {
            notify_destruction(std::move(first), std::move(last), [this](auto... args) { Type::swap_and_pop(args...); });
        }

        void in_place_pop(basic_iterator first, basic_iterator last) final {
            notify_destruction(std::move(first), std::move(last), [this](auto... args) { Type::in_place_pop(args...); });
        }

        basic_iterator try_emplace(const typename Type::entity_type entt, const bool force_back, const void* value) final {
            ENTT_ASSERT(owner != nullptr, "Invalid pointer to registry");
            Type::try_emplace(entt, force_back, value);
            construction.publish(*owner, entt);
            return Type::find(entt);
        }

    public:
        /*! @brief Underlying entity identifier. */
        using entity_type = typename Type::entity_type;

        /*! @brief Inherited constructors. */
        using Type::Type;

        /**
         * @brief Returns a sink object.
         *
         * The sink returned by this function can be used to receive notifications
         * whenever a new instance is created and assigned to an entity.

         * Listeners are invoked after the object has been assigned to the entity.
         *
         * @sa sink
         *
         * @return A temporary sink object.
         */
        [[nodiscard]] auto on_construct() ENTT_NOEXCEPT {
            return sink{ construction };
        }

        /**
         * @brief Returns a sink object.
         *
         * The sink returned by this function can be used to receive notifications
         * whenever an instance is explicitly updated.

         * Listeners are invoked after the object has been updated.
         *
         * @sa sink
         *
         * @return A temporary sink object.
         */
        [[nodiscard]] auto on_update() ENTT_NOEXCEPT {
            return sink{ update };
        }

        /**
         * @brief Returns a sink object.
         *
         * The sink returned by this function can be used to receive notifications
         * whenever an instance is removed from an entity and thus destroyed.

         * Listeners are invoked before the object has been removed from the entity.
         *
         * @sa sink
         *
         * @return A temporary sink object.
         */
        [[nodiscard]] auto on_destroy() ENTT_NOEXCEPT {
            return sink{ destruction };
        }

        /**
         * @brief Assigns entities to a storage.
         * @tparam Args Types of arguments to use to construct the object.
         * @param entt A valid identifier.
         * @param args Parameters to use to initialize the object.
         * @return A reference to the newly created object.
         */
        template<typename... Args>
        decltype(auto) emplace(const entity_type entt, Args &&...args) {
            ENTT_ASSERT(owner != nullptr, "Invalid pointer to registry");
            Type::emplace(entt, std::forward<Args>(args)...);
            construction.publish(*owner, entt);
            return this->get(entt);
        }

        /**
         * @brief Patches the given instance for an entity.
         * @tparam Func Types of the function objects to invoke.
         * @param entt A valid identifier.
         * @param func Valid function objects.
         * @return A reference to the patched instance.
         */
        template<typename... Func>
        decltype(auto) patch(const entity_type entt, Func &&...func) {
            ENTT_ASSERT(owner != nullptr, "Invalid pointer to registry");
            Type::patch(entt, std::forward<Func>(func)...);
            update.publish(*owner, entt);
            return this->get(entt);
        }

        /**
         * @brief Assigns entities to a storage.
         * @tparam It Type of input iterator.
         * @tparam Args Types of arguments to use to construct the objects assigned
         * to the entities.
         * @param first An iterator to the first element of the range of entities.
         * @param last An iterator past the last element of the range of entities.
         * @param args Parameters to use to initialize the objects assigned to the
         * entities.
         */
        template<typename It, typename... Args>
        void insert(It first, It last, Args &&...args) {
            ENTT_ASSERT(owner != nullptr, "Invalid pointer to registry");
            Type::insert(first, last, std::forward<Args>(args)...);

            for (auto it = construction.empty() ? last : first; it != last; ++it) {
                construction.publish(*owner, *it);
            }
        }

        /**
         * @brief Forwards variables to mixins, if any.
         * @param value A variable wrapped in an opaque container.
         */
        void bind(any value) ENTT_NOEXCEPT final {
            auto* reg = any_cast<Reg>(&value); ////////////////////////////////////////////// Here the returned reg is NULL
            owner = reg ? reg : owner;
            Type::bind(std::move(value));
        }

    private:
        sigh<void(Reg&, const entity_type)> construction{};
        sigh<void(Reg&, const entity_type)> destruction{};
        sigh<void(Reg&, const entity_type)> update{};
        Reg* owner{};
    };

    template<typename Type>
    struct storage_traits<entity, Type> {
        /*! @brief Resulting type after component-to-storage conversion. */
        using storage_type = my_sigh_storage_mixin<basic_storage<entity, Type>>;
    };
}

struct TestComponent {};

static void TestOnConstruct(Reg& reg, entt::entity e)
{
}

int main()
{
    Reg reg;
    auto entity = reg.create();
    reg.on_construct<TestComponent>().connect<&TestOnConstruct>();
    auto& testComp = reg.emplace<TestComponent>(entity); //////////////////////////////// CRASH here
}

I guess this is due to the fact that the registry forwards itself and therefore the type to extract is still entt::registry. Then you can static cast it to the derived type.

Although you made me think, I can just make the registry class a template parameter for the sigh_storage_mixin. This would get rid of your implementation and make these cases easier to address. 🤔

I guess this is due to the fact that the registry forwards itself and therefore the type to extract is still entt::registry. Then you can static cast it to the derived type.

So I just replace
auto* reg = any_cast<Reg>(&value);

with
auto* reg = static_cast<Reg*>(value.data());

Is that proper way?

No, I mean more something along this line:
auto* reg =
    static_cast<Reg *>( // <-- static cast to your registry type
        any_cast<entt::registry>(&value)) // << any_cast to the entt registry type
    ;

No, I mean more something along this line:
auto* reg =
    static_cast<Reg *>( // <-- static cast to your registry type
        any_cast<entt::registry>(&value)) // << any_cast to the entt registry type
    ;

Thansk!
But I'm wondering if it is possible to change (on_construct, on_update, on_destroy) these signatures from (entt::registry&, entt::entity) to just (entt::entity)?

Oh, yeah, same stuff. Just swap the mixin with one you like and that fits your needs.
You can really customize everything with EnTT. This is a quick example I packed for you.
There is no way to say change the signature of the sigh mixin for me but you can still replace it with your own if you like.

Oh, yeah, same stuff. Just swap the mixin with one you like and that fits your needs. You can really customize everything with EnTT. This is a quick example I packed for you. There is no way to say change the signature of the sigh mixin for me but you can still replace it with your own if you like.

Thanks. I have tried that already, but my code does not compile when I call registry.group(), maybe something conflict with that?

Oh, yeah, definitely. Groups use signals and do require the registry.

Oh, yeah, definitely. Groups use signals and do require the registry.

So in this situation, is it possible to make registry an optional parameter for signal?

No, I'm sorry, it is not. Definitely. It would be possible if it were the last one but I can't make it work since it's the first one here.


Can't restart jupyter kernel in M3 macbook.

After clicking the restart button

restarting takes forever

The only solution is close vscode and reopen.
I tried with different conda envs and in most of them I have the problem.
Maybe duplicated of #13138
Environment data

VS Code version: Version: 1.85.1
Commit: 0ee08df0cf4527e40edc9aa28f4b5bd38bbff2b2
Jupyter Extension version (available under the Extensions sidebar): v2023.11.1003402403
Python Extension version (available under the Extensions sidebar): v2023.22.1
OS and version: Mac Os 14.2.1
Python and/or Anaconda version: Python 3.11.5 and conda 23.11.0
Type of virtual environment used: conda
Jupyter server running: Local

Expected behaviour
Restart the kernel after clicking the button
Actual behaviour
It gets stuck forever.
Steps to reproduce:
Click the restart button, popup windows appears and gets stuck there.
Logs

Output for Jupyter in the Output panel (View→Output, change the drop-down the upper-right of the Output panel to Jupyter)

19:54:07.829 [info] Restarted 552b6a11-f0f6-4439-b927-c0dda4c0587f

Please could you enable logging as follows:

Open settings & go into Jupyter->Logging
Change the value to verbose
Reload VS Code,
Attempt to repro the issue & then copy the output from the Jupyter output panel.

Hi @DonJayamanne
These are the logs after I click restart
Loos like I need to change something in launch.json. Currently there is no launch.json, but I guess that some timeout would help.
Jupyter:
10:33:39.429 [debug] [I 2024-01-09 10:33:39.428 ServerApp] Kernel restarted: 5bc95b2e-30f4-4849-be95-3de1080bb3d0
10:33:39.431 [debug] [I 2024-01-09 10:33:39.430 ServerApp] Starting buffering for 5bc95b2e-30f4-4849-be95-3de1080bb3d0:63b6cc0c-ffa4-47e9-9220-223ae616b895
10:33:39.434 [info] Restarted 5bc95b2e-30f4-4849-be95-3de1080bb3d0
10:33:39.434 [debug] Executing silently Code (unknown) = import sys as _VSCODE_sys\nprint(_VSCODE_sys.executable); del _VSCODE_sys
10:33:39.434 [debug] [I 2024-01-09 10:33:39.433 ServerApp] Connecting to kernel 5bc95b2e-30f4-4849-be95-3de1080bb3d0.
    [I 2024-01-09 10:33:39.433 ServerApp] Restoring connection for 5bc95b2e-30f4-4849-be95-3de1080bb3d0:63b6cc0c-ffa4-47e9-9220-223ae616b895
10:33:39.437 [debug] Widget Message: Received IPyWidgetMessages.IPyWidgets_onRestartKernel
10:33:39.443 [debug] Widget Message: Received IPyWidgets_kernelOptions in ScriptManager
10:33:39.443 [debug] Widget Message: Received IPyWidgetMessages.IPyWidgets_kernelOptions
10:33:39.445 [debug] IPyWidgetMessageDispatcher.initialize
10:33:39.446 [debug] IPyWidgetMessageDispatcher.initialize
10:33:39.765 [debug] 0.00s - Debugger warning: It seems that frozen modules are being used, which may
    0.00s - make the debugger miss breakpoints. Please pass -Xfrozen_modules=off
    0.00s - to python to disable frozen modules.
    0.00s - Note: Debugging will proceed. Set PYDEVD_DISABLE_FILE_VALIDATION=1 to disable this validation.

Jupyter Server Console
[I 2024-01-09 10:33:39.428 ServerApp] Kernel restarted: 5bc95b2e-30f4-4849-be95-3de1080bb3d0
[I 2024-01-09 10:33:39.430 ServerApp] Starting buffering for 5bc95b2e-30f4-4849-be95-3de1080bb3d0:63b6cc0c-ffa4-47e9-9220-223ae616b895
[I 2024-01-09 10:33:39.433 ServerApp] Connecting to kernel 5bc95b2e-30f4-4849-be95-3de1080bb3d0.
[I 2024-01-09 10:33:39.433 ServerApp] Restoring connection for 5bc95b2e-30f4-4849-be95-3de1080bb3d0:63b6cc0c-ffa4-47e9-9220-223ae616b895
0.00s - Debugger warning: It seems that frozen modules are being used, which may
0.00s - make the debugger miss breakpoints. Please pass -Xfrozen_modules=off
0.00s - to python to disable frozen modules.
0.00s - Note: Debugging will proceed. Set PYDEVD_DISABLE_FILE_VALIDATION=1 to disable this validation.

These are the logs after I click restart.

please can you share all of the logs

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.
Happy Coding!


Add setApplicationIconBadgeNumber action for Android, using ShortcutBadger

Adds https://github.com/leolin310148/ShortcutBadger support for Android badges, using setApplicationIconBadgeNumber()
This doesn't automatically update when data.count is available, so for background updates, you need content-available. Perhaps that could be added, but not really sure how to do that the best way.
Fixes #622

Ideally we could add a badge option to the Android init, and then set the badge when possible, so we avoid any BC breaks.

This PR is updated to support both GCM intents + direct setting with setApplicationIconBadgeNumber(). When the count property is set in a GCM message, it should set the badge directly now.

I have now used a different thread for handling setApplicationIconBadgeNumber() inside the app, similar to other commands.

@barryvdh can you please retest by using the 1.7.x branch of the plugin? I don't actually have any phones that support badging. I've tested on a OnePlusOne and Nexus 5 with no ill affects.

Setting the badge works on my HTC M8. It also works with push messages, with one change:
Sending background badge updates (without message/title) doesn't work anymore, because you set the badge number together with creating the notification. So without message/title, the badge will not be updated (not even with content-available).
I don't know if this intentional?

@barryvdh ah, good point. I'll make a change and let you know when to re-test.

@barryvdh okay, I made the change in the v1.7.x please retest.

@barryvdh have you got a chance to re-test the v1.7.x branch?

Not fully yet, but the way you set the icon didn't really change much since last time I tested..

@barryvdh I thought I made the change so that the badge would be set on every incoming message.

Yeah I meant that you didn't change the way you actually called the badger plugin, just the logic for parsing the message etc. So even if you didn't test it actually sets the badge, you can verify the logic, right?
But I'll check soon.

hi guys,
can I see budge icon on my android version 4.2.2 ?

@barryvdh merged into master now, thanks for the code.

Thanks!

Thanks a lot i am new on cordova and working on asus phone and its working. After spending 4 days. Your great


Incompatible with winit 0.28.x

winit 0.28.x introduced some breaking changes that broke egui_winit_platform:
error: Please select a feature to build for unix: `x11`, `wayland`
  --> /home/<redacted>/.cargo/registry/src/index.crates.io-6f17d22bba15001f/winit-0.27.5/src/platform_impl/linux/mod.rs:10:1
   |
10 | compile_error!("Please select a feature to build for unix: `x11`, `wayland`");
   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

error[E0392]: parameter `T` is never used
  --> /home/<redacted>/.cargo/registry/src/index.crates.io-6f17d22bba15001f/winit-0.27.5/src/event_loop.rs:35:22
   |
35 | pub struct EventLoop<T: 'static> {
   |                      ^ unused parameter
   |
   = help: consider removing `T`, referring to it in a field, or using a marker such as `PhantomData`

error[E0392]: parameter `T` is never used
  --> /home/<redacted>/.cargo/registry/src/index.crates.io-6f17d22bba15001f/winit-0.27.5/src/event_loop.rs:46:34
   |
46 | pub struct EventLoopWindowTarget<T: 'static> {
   |                                  ^ unused parameter
   |
   = help: consider removing `T`, referring to it in a field, or using a marker such as `PhantomData`

error[E0392]: parameter `T` is never used
   --> /home/<redacted>/.cargo/registry/src/index.crates.io-6f17d22bba15001f/winit-0.27.5/src/event_loop.rs:350:27
    |
350 | pub struct EventLoopProxy<T: 'static> {
    |                           ^ unused parameter
    |
    = help: consider removing `T`, referring to it in a field, or using a marker such as `PhantomData`

error[E0392]: parameter `T` is never used
   --> /home/<redacted>/.cargo/registry/src/index.crates.io-6f17d22bba15001f/winit-0.27.5/src/platform_impl/linux/mod.rs:635:20
    |
635 | pub enum EventLoop<T: 'static> {
    |                    ^ unused parameter
    |
    = help: consider removing `T`, referring to it in a field, or using a marker such as `PhantomData`

error[E0392]: parameter `T` is never used
   --> /home/<redacted>/.cargo/registry/src/index.crates.io-6f17d22bba15001f/winit-0.27.5/src/platform_impl/linux/mod.rs:642:25
    |
642 | pub enum EventLoopProxy<T: 'static> {
    |                         ^ unused parameter
    |
    = help: consider removing `T`, referring to it in a field, or using a marker such as `PhantomData`

error[E0392]: parameter `T` is never used
   --> /home/<redacted>/.cargo/registry/src/index.crates.io-6f17d22bba15001f/winit-0.27.5/src/platform_impl/linux/mod.rs:769:32
    |
769 | pub enum EventLoopWindowTarget<T> {
    |                                ^ unused parameter
    |
    = help: consider removing `T`, referring to it in a field, or using a marker such as `PhantomData`
    = help: if you intended `T` to be a const parameter, use `const T: usize` instead

For more information about this error, try `rustc --explain E0392`.
error: could not compile `winit` due to 7 previous errors
warning: build failed, waiting for other jobs to finish...

... Not sure where to begin to fix this! Maybe updating the dep on winit would suffice?

Yes, updating the dep is the first step. Of course breaking changes would then have to be fixed. I haven't had a look at winit 0.28 yet, so I can't comment about it's changes.

I made a quick fork and it looks like winit 0.28 itself didn't break anything egui_winit_platform cares about — it's just that winit added a compile error if you disabled all target platforms (see https://github.com/rust-windowing/winit/blob/265152355eefc4b3db0b44555043c349d72e2499/src/platform_impl/mod.rs#L57-L67), which occurs with default features disabled. I guess we can remove default-features = false for now?


Are we getting rid of past proposals

Why does p_select_proposal have
proposals = {k: p for k, p in raw_proposals.items()
if p.when >= process.current_phase_init_time}
If we are not getting rid of them it is likely weighing down the model. If we want to ensure we can add an assertion

@danlessa


GeasyFork site problem support Waterfox Classic ?

I Notice a problem with Waterfox Classic with date of  comments on Greasyfork:
[Waterfox Classic] No Posted Time for Comments
With Waterfox Classic, the Posted time appear briefly and disappear after...
Work on Firefox Quantum:
in it, i notice an "#shadow-root(open)" element.

Thanks for the issue @decembre.
If you're using this custom element in a browser that does not support custom elements, it will revert to whatever the server rendered content is. If you wish for the actual behaviour of this element, it requires Custom Elements and ShadowDOM to work, you'll need to provide polyfills for those if you're interested in supporting older browsers. It looks as though the GreasyFork website does not include any Custom Elements polyfills, which would mean that the use of RelativeTime would fall back to no behaviour.
Briefly attempting to reproduce by visiting https://github.github.io/relative-time-element/examples/ in Waterfox Classic, I can see that it does not support Web Components/Custom Elements by default. Are you perhaps running an extension or user script which provides some kind of custom elements support?
If you're including a custom elements polyfill script or extension in your browser, then this polyfill will either need to fully support ShadowDOM, or explicitly not support it (by not providing the attachShadow functionality). RelativeTime checks for support of attachShadow before using shadowDOM: https://github.com/github/relative-time-element/blob/1be3d31ddd58aeeca1401c7204da1f8530f64d81/src/relative-time-element.ts#L77 so if the polyfill for custom elements provides that method but otherwise does not support ShadowDOM, that may explain the problems you're having.

Thanks for the explanation!
Because i am only an user of it, I give it to the dev of Greasyfork...
And yes i use, on my side, an extension (very undocumented) named "Polly".
On Greasyfork site, "Polly" is useful here in some case:
It is useful when i want to re Edit a comment.
Without it, i can't re edit a post.
For that, i need to enable "Polly" options:
These 2 options in "Polly" are :
1 - Request modification method for this domain
2 - Pollyfills/Webcomponents-Bundle.js
But... whit these options enable, that break your function....

Unfortunately as I can't really see what the "Polly" extension does I won't be able to help any further; a quick web search suggests this extension is no longer maintained and the source code has been removed from their repository.
As this repository works in modern browsers, and falls back gracefully in stock Waterfox, it leaves us with little to go on. Consequently I'll close this issue. You might want to explore alternatives to the "Polly" extension, perhaps if you find one that is actively maintained and still causes issues with this element, then we can explore options then. Thanks for your understanding.


Uncaught ReferenceError: require is not defined with node integration & webpack

Pre-flight checklist

[X] I have read the contribution documentation for this project.
[X] I agree to follow the code of conduct that this project uses.
[X] I have searched the issue tracker for a bug that matches the one I want to file, without success.

Electron Forge version
6.0.0-beta.61
Electron version
v15.1.1
Operating system
macOS 11.3
Last known working Electron Forge version
No response
Expected behavior
Nothing should be logged. (except CSP warning)
Actual behavior
renderer console says:
Uncaught ReferenceError: require is not defined
    at Object.url (index.js:376)
    at __webpack_require__ (index.js:405)
    at fn (index.js:592)
    at eval (parseURL.js:5)
    at Module../node_modules/webpack-dev-server/client/utils/parseURL.js (index.js:193)
    at __webpack_require__ (index.js:405)
    at fn (index.js:592)
    at eval (index.js?protocol=ws%3A&hostname=<IP_ADDRESS>&port=3000&pathname=%2Fws&logging=info:7)
    at Module../node_modules/webpack-dev-server/client/index.js?protocol=ws%3A&hostname=<IP_ADDRESS>&port=3000&pathname=%2Fws&logging=info (index.js:107)
    at __webpack_require__ (index.js:405)

Steps to reproduce

npx create-electron-app node-integration --template=webpack
cd node-integration
enable node integration in forge config / package.json and browser window / main.js (see package.json and main.js below)
npm start
Open dev tools / console

Additional information
main.js
// ...
  const mainWindow = new BrowserWindow({
    width: 800,
    height: 600,
    webPreferences: {
      nodeIntegration: true,
    },
  });
// ...

package.json
// ...
      "plugins": [
        [
          "@electron-forge/plugin-webpack",
          {
            "mainConfig": "./webpack.main.config.js",
            "renderer": {
              "nodeIntegration": true,
              "config": "./webpack.renderer.config.js",
              "entryPoints": [
                {
                  "html": "./src/index.html",
                  "js": "./src/renderer.js",
                  "name": "main_window"
                }
              ]
            }
          }
        ]
      ]
// ...

instead

It works, thank u! :D

@erickzhao It works, thank u~ :D


Exclude map files from repo?

@mervick, How do you feel about removing the css.map and js.min.map files from the git repo?
IMO they conflict too frequently (since they contain paths to the specific compass and ruby versions you are using).
Plus anyone who is really interested in the map files, its trivial to just generate them locally using grunt build

yes, I think we can remove these files from git


Add echo option to prevent secrets from printing to stdout

Being that secrets generally contain sensitive keys, this PR adds an option to various methods within the secret extension where users will have the option to prevent secret creation from exposing keys in Tilt's UI/logging console.
Default option is set to False as the use case may not apply to all.

In all honesty, I struggled a bit with the name of the new parameter/arg considering that quiet already exists and wasn't sure if echo was explicit enough so I came up with echo_status. Would console_stdout or something of that nature make more sense?

@nicksieger not sure how to get an approver to review but tagging you for the time being

Thanks for the feedback, just updated


fix flake8 and isort reported issues, run tests

Cleaned up the code, added automated tests.
Not adding all the unit tests at once as they are failing on my laptop. I'll enable all tests in a different PR once this is in.
Coverage report: 25%
coverage.py v6.5.0, created at 2022-10-24 13:57 +0000

Module
statements
missing
excluded
coverage

drop_buffer_cache.py
33
15
0
55%

fallocate.py
35
17
0
51%

parser_data_types.py
49
27
0
45%

smallfile.py
1450
1181
0
19%

smf_test_params.py
98
69
0
30%

sync_files.py
47
36
0
23%

yaml_parser.py
146
57
0
61%

Total
1858
1402
0
25%

coverage.py v6.5.0, created at 2022-10-24 13:57 +0000
Signed-off-by: Sandro Bonazzola<EMAIL_ADDRESS>

No, didn't run black. Run flake8 and isort and manually fixed stuff reported there.

No, didn't run black. Run flake8 and isort and manually fixed stuff reported there.

Have you considered using black?  It'd make these changes much easier to consume in review.

pushed an additional commit with black run.

Had to drop both isort and flake8  as they don't agree with black.

If we take that PR in first, and then rebase this PR on that, we'll have just the fixes you have applied which will be a bit easier to review.

ok, go ahead merging #37 and I'll rebase.

moved to #38 due to master/main rename


Issue #107006 closed due to being resolved on master 3.1.0-0.0.pre.1494

Hi @maheshmnj , I am opening a new issue regarding the same problem described in issue 107006. The issue was closed because the team reproduced it on the stable channel but not on the latest master channel (master, 3.1.0-0.0.pre.1494) as described in this comment.
I have tested the same code on the latest stable version of flutter 3.3  and I am able to reproduce the same issue.

Hi @M144-Coder, as mentioned in https://github.com/flutter/flutter/issues/107006#issuecomment-1173658912 the issue doesn't reproduce on the master channel (that means it is fixed). You may verify the fix by switching to the master channel by running
flutter channel master
flutter upgrade

Fixes on the master channel land on stable every quarter, So it is advised to wait until the fix lands on the stable channel. You may read more about the flutter release process here https://github.com/flutter/flutter/wiki/Flutter-build-release-channels

Hello @maheshmnj ,
I have just tested the code sample on the latest Flutter master channel version 3.4.0-19.0.pre.192 on Windows 10 and with Android 12 on a Samsung device and I can reproduce the same issue, even pulling the cursor to the latest position didn't work as in the following video:
https://user-images.githubusercontent.com/18516358/189473592-0256f381-9113-4bf7-b501-ac63bcf8407f.mp4

Hi @M144-Coder, I can confirm this issue is still reproducible on the latest master channel 3.4.0-19.0.pre.192.

Demo
https://user-images.githubusercontent.com/104349824/189583635-a9bdbf23-6090-483b-9420-0ca9f570e0f7.mp4

flutter doctor -v
[✓] Flutter (Channel stable, 3.3.1, on macOS 12.5.1 21G83 darwin-x64, locale en-VN)
    • Flutter version 3.3.1 on channel stable at /Users/huynq/Documents/GitHub/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 4f9d92fbbd (31 hours ago), 2022-09-06 17:54:53 -0700
    • Engine revision 3efdf03e73
    • Dart version 2.18.0
    • DevTools version 2.15.0

[✓] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
    • Android SDK at /Users/huynq/Library/Android/sdk
    • Platform android-33, build-tools 31.0.0
    • ANDROID_HOME = /Users/huynq/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.12+0-b1504.28-7817840)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 13.3)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 13E113
    • CocoaPods version 1.11.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2021.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.12+0-b1504.28-7817840)

[✓] IntelliJ IDEA Community Edition (version 2020.3.3)
    • IntelliJ at /Applications/IntelliJ IDEA CE.app
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart

[✓] IntelliJ IDEA Community Edition (version 2022.1.1)
    • IntelliJ at /Users/huynq/Library/Application Support/JetBrains/Toolbox/apps/IDEA-C/ch-0/221.5591.52/IntelliJ IDEA CE.app
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart

[✓] VS Code (version 1.71.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.48.0

[✓] Connected device (2 available)
    • macOS (desktop) • macos  • darwin-x64     • macOS 12.5.1 21G83 darwin-x64
    • Chrome (web)    • chrome • web-javascript • Google Chrome 105.0.5195.102

[✓] HTTP Host Availability
    • All required HTTP hosts are available

• No issues found!

[✓] Flutter (Channel master, 3.4.0-19.0.pre.192, on macOS 12.5.1 21G83 darwin-x64, locale en-VN)
    • Flutter version 3.4.0-19.0.pre.192 on channel master at /Users/huynq/Documents/GitHub/flutter_master
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 4930444f4a (2 days ago), 2022-09-09 21:58:23 -0400
    • Engine revision f72107f457
    • Dart version 2.19.0 (build 2.19.0-183.0.dev)
    • DevTools version 2.17.0

[✓] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
    • Android SDK at /Users/huynq/Library/Android/sdk
    • Platform android-33, build-tools 31.0.0
    • ANDROID_HOME = /Users/huynq/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.12+0-b1504.28-7817840)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 13.3)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 13E113
    • CocoaPods version 1.11.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2021.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.12+0-b1504.28-7817840)

[✓] IntelliJ IDEA Community Edition (version 2020.3.3)
    • IntelliJ at /Applications/IntelliJ IDEA CE.app
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart

[✓] IntelliJ IDEA Community Edition (version 2022.1.1)
    • IntelliJ at /Users/huynq/Library/Application Support/JetBrains/Toolbox/apps/IDEA-C/ch-0/221.5591.52/IntelliJ IDEA CE.app
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart

[✓] VS Code (version 1.71.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.48.0

[✓] Connected device (3 available)
    • SM T225 (mobile) • R9JT3004VRJ • android-arm64  • Android 12 (API 31)
    • macOS (desktop)  • macos       • darwin-x64     • macOS 12.5.1 21G83 darwin-x64
    • Chrome (web)     • chrome      • web-javascript • Google Chrome 105.0.5195.102

[✓] HTTP Host Availability
    • All required HTTP hosts are available

• No issues found!

But there's an open issue addressing the case you described #110416 which is reported in various of environments (see https://github.com/flutter/flutter/issues/110416#issuecomment-1230103425).
Closing this issue as a duplicate, so please follow up on it for further updates. You can leave there your comment and react an upvote to the original comment will help to raise the issue. Thank you!


Cannot adjust FPS

Many things are hardcoded to the FPS, like the animation speeds, because the rendering cycle and the logic update cycle are one and the same.

Solved in conversion to SDL2


Discrepancy between windows and percentage

So it appears that percentage doesn't match what Windows is reporting at times.
For example, currently, Windows is reporting 98% charged when I hover over the battery icon, but Percentage is reporting 97%. I know it's not much there but it does make me wonder about lower levels.
I will update this issue as I check at different levels throughout the week.
System
MacBook Pro Retina (Mid 2014)
Windows 10 Pro running in Bootcamp

I'm pretty sure the windows percent is updating less often that this program, so in fact the correct one is what you're seeing in "percentage.exe". I looked in the code, and it's textbook reading of battery status.

I have had my system just sitting plugged into my desk set up (Monitors and Power ect) and it has been sitting at that difference for about an hour so I don't think it's to do with the refresh rate. It may be a case of Windows not correctly reading the value or doing the math slightly differently.

then yes, it probably because the value 0.513 for example is computed in "percentage" as 51, using casting to int after multiplying by 100, while windows might be just rounding up, making it 52. This could be changed, but I don't think the project is maintained anymore. Maybe I'll branch it and continue work on it (I already have some changes, mentioned in the issue before this one)

That makes sense. I think if it is just a difference in rounding like that I wouldn't be too concerned. I was more concerned to see if the difference got worse at difference charge levels. Your changes do look interesting, would be good to see a fork just for those.

Yes the percentage comes straight from SystemInformation.PowerStatus.BatteryLifePercent. Feel free to reopen if there's a better way to get the percentage.
Also georgepauna feel free to share your fork here, thanks


fix avoid oom when a lot of tablets fail on load

Proposed changes
When a lot of tablets fail when loading, then detailed information would cause oom.
Issue Number: close #xxx

run buildall

run buildall


⚠ Catalog API Endpoint has degraded performance

In 7cd499f, Catalog API Endpoint (https://catalog.roblox.com/v1/bundles/details?bundleIds=192) experienced degraded performance:

HTTP code: 200
Response time: 3609 ms

Resolved: Catalog API Endpoint performance has improved in de27680.


failed to intialize firewall:  firewall support not found

testing netmaker 0.18.4. netclient ver 0.18.4, on all ubuntu hosts most on 22.04.2 lts with nftables active (iptables-nft), I've all these errors in the netclient docker version: "[netclient] 2023-03-30 10:16:30 Starting firewall...
[netclient] 2023-03-30 10:16:30 iptables is not supported, using nftables
[netclient] 2023-03-30 10:16:30 failed to intialize firewall:  firewall support not found" and also this error:"[netclient] 2023-03-30 10:21:29 error adding route no such device".  The netclient version is 0.18.4, Ubuntu 22.04.2 LTS and iptables v1.8.7 (nf_tables), nftables v1.0.2 (Lester Gooch). The errors shows up only if I configure egress option on the hosts to reach internal subnets. The routes seems to be correctly added to the rest of the allowed nodes but I can ping only the ip of the node exposing the internal subnet. If I manually add an nft rule to masquerade the outgoing interface (like ens18)  I can then ping all the internal hosts. If you need further info just le me know.

testing 0.18.5 and same problem: [netclient] 2023-03-31 13:49:50 Starting firewall...
[netclient] 2023-03-31 13:49:50 iptables is not supported, using nftables
[netclient] 2023-03-31 13:49:50 failed to intialize firewall:  firewall support not found

Had the same issue, using netclient 0.18.x in Docker.
investigating the logs further I found;
netclient  | ./netclient.sh: line 5: wg: command not found
netclient  | [netclient] joining network

The netclient Docker image  seems to be missing the wireguard-tools pakage.
For now fixed it by overriding the entrypoint in docker-compose.
entrypoint: bash -c "apk add wireguard-tools; /bin/bash netclient.sh"

I don't get the firewall error after this anymore.

For now fixed it by overriding the entrypoint in docker-compose.
entrypoint: bash -c "apk add wireguard-tools; /bin/bash netclient.sh"

I don't get the firewall error after this anymore.

Have you upgraded to v0.20.0?  This workaround no longer works for me after upgrading.  Getting "firewall support not found" again.

@FADEC44
Can confirm the first workaround does not help anymore on docker image v0.20.0
Thank you for finding the next workaround!
But still it should be for now;
entrypoint: bash -c "apk add wireguard-tools ip6tables; /bin/bash netclient.sh"

As the "wg" binary is still missing in the docker image and it is used for the cleanup function when netclient is terminated.
I will open a new issue now to point the docker image maintainers to these missing dependencies.
But maybe also useful for the main developers, as netclient is not very clear on the reason it concludes iptables is not supported.

iptables and iptables6 installed in netclient docker image


HBASE-25000 Move delete region info related methods to RegionStateStore

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
4m  0s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 22s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 45s
master passed

+1 :green_heart:
checkstyle
1m 19s
master passed

+1 :green_heart:
spotbugs
2m 35s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 37s
the patch passed

+1 :green_heart:
checkstyle
1m 17s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
12m 16s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1.

+1 :green_heart:
spotbugs
2m 50s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 24s
The patch does not generate ASF License warnings.

40m 39s

Subsystem
Report/Notes

Docker
Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2366/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2366

Optional Tests
dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle

uname
Linux 0d9ea3b69007 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 0d95a8f91b

Max. process+thread count
94 (vs. ulimit of 12500)

modules
C: hbase-balancer hbase-server U: .

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 15s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m 26s
the patch passed

+1 :green_heart:
compile
1m 33s
the patch passed

+1 :green_heart:
javac
1m 33s
the patch passed

+1 :green_heart:
shadedjars
7m 18s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 16s
hbase-balancer in the patch failed.

-0 :warning:
javadoc
0m 43s
hbase-server in the patch failed.

_ Other Tests _

+1 :green_heart:
unit
0m 24s
hbase-balancer in the patch passed.

+1 :green_heart:
unit
129m 25s
hbase-server in the patch passed.

161m 48s

Subsystem
Report/Notes

Docker
Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2366/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2366

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 69c924edc0c0 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 0d95a8f91b

Default Java
2020-01-14

javadoc
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2366/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-balancer.txt

javadoc
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2366/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt

javadoc
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2366/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-balancer.txt

javadoc
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2366/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2366/1/testReport/

Max. process+thread count
4118 (vs. ulimit of 12500)

modules
C: hbase-balancer hbase-server U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2366/1/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  1s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 23s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 43s
master passed

+1 :green_heart:
compile
1m 16s
master passed

+1 :green_heart:
shadedjars
6m 33s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 55s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 16s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 31s
the patch passed

+1 :green_heart:
compile
1m 14s
the patch passed

+1 :green_heart:
javac
1m 14s
the patch passed

+1 :green_heart:
shadedjars
6m 34s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 38s
hbase-server generated 1 new + 28 unchanged - 0 fixed = 29 total (was 28)

_ Other Tests _

+1 :green_heart:
unit
0m 23s
hbase-balancer in the patch passed.

+1 :green_heart:
unit
145m  1s
hbase-server in the patch passed.

174m 10s

Subsystem
Report/Notes

Docker
Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2366/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2366

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux f8d0dc535a1a 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 0d95a8f91b

Default Java
1.8.0_232

javadoc
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2366/1/artifact/yetus-jdk8-hadoop3-check/output/diff-javadoc-javadoc-hbase-server.txt

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2366/1/testReport/

Max. process+thread count
4309 (vs. ulimit of 12500)

modules
C: hbase-balancer hbase-server U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2366/1/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

The overall plan is? Which methods should move to RegionStateStore and which should keep? Thanks.

The overall plan is? Which methods should move to RegionStateStore and which should keep? Thanks.

The final goal is to move all the meta edit related methods to RegionStateStore. As now we only allow editing meta from master, still leaving these methods in MetaTableAccessor will give developer an impression that you can modify meta table if you have a Connection instance, which is incorrect. But it is not easy to finish them at once(I tried in HBASE-24985 but the patch is too big...), so I plan to do them piece by piece.


Devise, Heroku and the Asset Pipeline

I'm not sure if this has been mentioned before, and I'm not sure where to even start fixing it.
When deploying a Rails 3.1 app to Heroku, it runs the asset compilation rake task during the deploy.
However in an app with devise in it this compilation fails because the devise_for route helper causes the rake task to need to talk to the database, which doesn't exist yet.
Is this something that can be changed on Devise's end?
Any thoughts?
Cheers,
Brad

@nas887: how did you fix it?

Hey Andrew,
Can you be a bit more specific, having trouble referencing this one problem
I ran into.
-Neil
On Sat, Oct 8, 2011 at 1:12 PM, Andrew Fecheyr <
<EMAIL_ADDRESS>
@nas887: how did you fix it?
--
Reply to this email directly or view it on GitHub:
https://github.com/plataformatec/devise/issues/1339#issuecomment-2332920

Hi Neil,
I had the same asset:precompile error. I fixed it by changing a scope in my devise user model to a lambda.
On 09 Oct 2011, at 19:06, Neil<EMAIL_ADDRESS>wrote:

Hey Andrew,
Can you be a bit more specific, having trouble referencing this one problem
I ran into.
-Neil
On Sat, Oct 8, 2011 at 1:12 PM, Andrew Fecheyr <
<EMAIL_ADDRESS>
@nas887: how did you fix it?
--
Reply to this email directly or view it on GitHub:
https://github.com/plataformatec/devise/issues/1339#issuecomment-2332920

--
Reply to this email directly or view it on GitHub:
https://github.com/plataformatec/devise/issues/1339#issuecomment-2337339

Hi Andrew,
I'm very new to rails but working really hard.
My error was a simple configuration error. I fixed it by updating the URL that the callback was pointing to.
-Neil

Getting same issue still, "can't connect to localhost 5432" when running rake assets:precompile. Using devise directly, not via activeadmin.
On rails 3.1.1.rc3.

Rails 3.1.1 final has a method called config.assets.initialize_on_precompile. If you set it to false, you should be good but it won't allow you to access model information on your assets (which you probably shouldn't anyway).

Setting this in application.rb is suggested I guess?

Yes, more info about it in the guides:
http://guides.rubyonrails.org/asset_pipeline.html

it was fixed for me by adding attr_accessor :terms_of_service

Thanks @moustafasamir Works!


Support {create,update,read}Time timestamps from DocumentSnapshot

DocumentSnapshot exposes the aforementioned timestamps. It would be good to expose them.
I took a stab, but unsure how to test this and whether this is even feasible direction.

I added the following comment in the original PR, but I'm pasting here as cross-reference. We can use this issue to plan the implementation.

I really think we must add this functionality it's in the roadmap under nice to have! but I'm not fond of adding arbitrary fields to my entities that I won't use. I prefer having a declarative way of telling fireorm to map a field in my entity to one of those "calculated" fields (and this is deeply related to #116).
I see two possible ways of doing this cleanly:
Adding decorators on top of fields to specify that it'll be mapped to an autogenerated (or readonly not manipulated by the developer), something close to @CreatedOnField @ReadOnField
Or fireorm exposing Symbols that can the developer can use to override entities fields. I'm not super clear about how it'll be done in practice but if I'm not mistaken that's the purpose of the symbols.


Provide hint/comment on prediction

Is your feature request related to a problem? Please describe.
As a TFAcon user, I just get prediction on failures. But still I have to look into all failed tests logs to see if prediction is correct. It will be very useful if I get some comment or hint (parsed from logs using some regex) that will explain why particular failure predicted as system issue or product issue or automation issue.
As an example, lets look into following failed test, where prediction given by TFA classifier i.e. Predicted system issue, is correct. But still as a QE, I have to look into logs and verify it's correct prediction.

Describe the solution you'd like
I would like TFA classifier to provide hint/comment on failure and TFAcon to update that comment with prediction as shown below.

Hi @ntkathole , Recommendation Engine is now integrated with tfacon, you can do tfacon run -r to get result for Recommendation Engine. tfacon will update the recommendations in the comment field of you test item. RE will tell you the 3 most similar test times to the current test item. Would it solve your problem?

Thanks @JunqiZhang0 I am able to see some comments from recommendation engine. I will enable and observe how its helpful. I am closing this issue since RE serves main purpose. If required, I will open new issues for RE enhancements.


changed pool name for unit tests

Description

Changes build agent pool name

Switches to a newer build agent pool
Related Issues

Checklist:

[ X] My code follows the code style of this project, as detailed in our contribution guidelines.
[ ] I have added tests.
[ ] I have updated the documentation accordingly.

obsolte

obsolte


Using .map instead of .forEach

This cleans up the code a little bit

@danielmahon, @steelbrain thoughts?

Looks good to me, Daniel Mahon comes online once in a while so you might have to wait :)

@ArtskydJ thanks!


pre- and post- column classes are ignored at wide or high dpi screens

The pre and post classes are not getting applied at screen widths larger than 1525px in normal left-to-right layout. They do work properly in rtl mode.
This is likely due to the fact that these classes come before the html selector in the wide screen rules. See: https://github.com/Esri/calcite-web/blob/master/dist/css/calcite-web.css#L1688

@mpriour I fixed this on master already, will push a new version soon.

@paulcpederson great! thanks.

Will keep you posted when the release is out.


Added files for Docker support

The title says it all, I guess....

This is going to be cool! Thanks!


Revert "feature using fe version to set instance_num"

Reverts apache/doris#22047

run buildall

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.28 seconds
stream load tsv:          506 seconds loaded<PHONE_NUMBER>9 Bytes, about 140 MB/s
stream load json:         20 seconds loaded<PHONE_NUMBER> Bytes, about 112 MB/s
stream load orc:          65 seconds loaded<PHONE_NUMBER> Bytes, about 16 MB/s
stream load parquet:          31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select:          29.6 seconds inserted 10000000 Rows, about 337K ops/s
storage size:<PHONE_NUMBER>0 Bytes


Support ECC keys

We only make RSA keys, we should make ECDSA keys as well.

Replaced with ecdh
https://github.com/Foxboron/age-plugin-tpm/commit/a7e5a4f84a0e80316822da1ef99f63eebc992387


Unity Greeter screen

Hello, I am running Unity 14.04 on a Toshiba Chromebook and I am having issues getting to the lock screen where I can switch sessions. Anyone know of a command line I can use to switch to my cinnamon session?
Thanks

@PearcePunisher,
You can't log out to get the display manager in a crouton chroot like you would on a normal distro.
You'l have to create a custom startcinnamon script or something similar either outside the chroot or inside the chroot or both to launch your cinnamon desktop.
The following article may give you some guidance -
INSTALL CINNAMON ON A CHROMEBOOK WITH CROUTON


[incubator/mysqlha] Standardize the fullnameOverride and the nameOverride mysqlha

Signed-off-by: Aisuko<EMAIL_ADDRESS>
What this PR does / why we need it:
Standardize the fullnameOverride and the nameOverride mysqlha.
Which issue this PR fixes
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

fixes #

Special notes for your reviewer:

Given a version number MAJOR.MINOR.PATCH, increment the:

MAJOR version when you make incompatible API changes,
MINOR version when you add functionality in a backward-compatible manner
PATCH version when you make backward-compatible bug fixes.
Additional labels for pre-release and build metadata are available as extensions to the
MAJOR.MINOR.PATCH format.

These changes are not backward-compatible, e.g if there were any chart dependency on older mysqlha and if they want to use the mysqlha latest version which has been set fullnameOverride, the chart would not work well, and you have to reapir the connection of mysqlha(There may have to modify the chart context). so we should have increased the MAJOR version instead of the PATCH one.
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] DCO signed
[x] Chart Version bumped
[x] Variables are documented in the README.md
[x] Title of the PR starts with chart name (e.g. [stable/chart])

/retest

/test all

/assign @jpoon

/unassign @jpoon

/assign @cpanato

cc @cpanato Please make a review on this, thank you very much.

/lgtm
thanks!


[keymgr] What is KMAC key value when transitioning to CreatorRootKey

@tjaychen

CreatorRootKey is the first operational state of the key manager. When transitioning from Initialized to this state, a KMAC operation is invoked using the RootKey as the key (from OTP), and the remaining inputs as data.

From spec above, key value is just RootKey from OTP. Look at the RTL, key value is entropy ^ RootKey. Could you explain this?
      StWipe: begin
        prng_en_o = 1'b1;

        // populate both shares with the same entropy
        // This is the default mask
        if (cnt < EntropyRounds) begin
          cnt_en = 1'b1;
          for (int i = 0; i < Shares; i++) begin
            key_state_d[i][cnt] = entropy_i;
          end
        end
        // when mask population is complete, xor the root_key into the zero share
        // if in the future the root key is updated to 2 shares, it will direclty overwrite
        // the values here
        else begin
          cnt_clr = 1'b1;
          key_state_d[0] = key_state_q[0] ^ root_key_i;
          init_done_o = 1'b1;
          state_d = StInit;
        end
      end

yeah so this will change slightly in the future, because the value coming out of OTP will be two shares already.
But the basic idea here is that the root_key is split into "two shares" as it's being sent to kmac.  One share is entropy, and the other share is the same entropy^ the key.
That way when you xor the two shares together, you get key ^ entropy ^ entropy, which just gives you the key.
Does that help?

yeah so this will change slightly in the future, because the value coming out of OTP will be two shares already.
But the basic idea here is that the root_key is split into "two shares" as it's being sent to kmac. One share is entropy, and the other share is the same entropy^ the key.
That way when you xor the two shares together, you get key ^ entropy ^ entropy, which just gives you the key.
Does that help?

I see. how about the 2 shares digest data from KMAC? is it using the same way share1 ^ share0 to get the digest? Thanks

yeah that's right. The kmac digest is also in two shares. However we never explicitly combine them.
So when I integrate kmac with otp, i'm going to change the wipe state to wipe to all entropy, and then directly ingest the otp input.
That should be clearer when i do it.

yeah so this will change slightly in the future, because the value coming out of OTP will be two shares already.
But the basic idea here is that the root_key is split into "two shares" as it's being sent to kmac. One share is entropy, and the other share is the same entropy^ the key.
That way when you xor the two shares together, you get key ^ entropy ^ entropy, which just gives you the key.
Does that help?

I see. how about the 2 shares digest data from KMAC? is it using the same way share1 ^ share0 to get the digest? Thanks
EDIT:
I didn't see any logic to check the correlation of 2 share data in keymgr. Perhaps I can just randomize these 2 share digest data, right?

o yeah that's right.  From a testing perspective, you can randomize it however you like.

Cool. Thanks for the explanation.


Fix bug in procs docs

Docs: https://sorbet.org/docs/procs#modifying-the-self-type
The current example has many errors. By contrast, this version is fine by Sorbet.

@ghiculescu I merged the latest master into your branch to fix the build failure (it seems like you were on a really dated branch).

Ahh yep that sounds right. Thanks!


ci: fix clippy workflow & remove audit workflow

:tada: This PR is included in version 1.3.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Restrict which files get copied between tasks

This PR adds a couple schema parameters and basic functionality to enable:

Restricting which files get copied between tasks
Distinguishing types of input files to a task

For an example use case: imagine we wanted to run gate-to-gate LEC between cts and place. We could create a lec task that depends on both place and cts, but then we run into an issue:
$ ls place/0/outputs/
design.def   design.place.vg

$ ls cts/0/outputs/
design.def design.cts.vg

Since these files will get copied directly by the runtime into lec/0/inputs, the checker will throw an error due to the duplicated design.def inputs. In addition, the LEC step has no way of distinguishing the two netlists to be compared.
This PR solves the problem by allowing a user to filter out a specific set of files to be copied between one step and another, which is exposed as an optional kwarg to the edge() API method. For this example, the flow definition might be tweaked to look like:
chip.node(flow, 'lec', 'yosys')
chip.edge(flow, 'place', 'lec', files=[
  ('design.place.vg', 'netlist-ref')
])
chip.edge(flow, 'cts', 'lec', files=[
  ('design.cts.vg', 'netlist')
])

Then, during runtime two things will be different:

Only design.place.vg and design.cts.vg will be copied into lec/0/inputs, solving the first problem.
The new parameter ['tool', <tool>, 'infile', <step>, <index>, <filetype>] will be set for this task to point to these inputs (with distinct filetypes of netlist-ref and netlist), solving the second problem.

We've previously discussed moving towards defining info about flow inputs/outputs directly in the flow definition ( #1087), and this PR enables the immediate use case in a backwards-compatible way while moving towards this broader change. To make this change forward-looking, the schema parameters proposed are a bit more complex than needed for just this functionality.

Postponing this change for later!


Fail to build for powerpc

powerpc Debian unstable gcc 10.2.1
FAILED: source/Lib/vvdec/CMakeFiles/vvdec.dir/__/CommonLib/UnitTools.cpp.o
c++ -DVVDEC_SOURCE -Dvvdec_EXPORTS -I../source/Lib/vvdec/../../../include -I. -I../source/Lib/vvdec/SYSTEM -I../source/Lib/vvdec/. -I../source/Lib/vvdec/.. -I../source/Lib/vvdec/../DecoderLib -I../source/Lib/vvdec/../CommonLib -I../source/Lib/vvdec/../CommonLib/x86 -I../source/Lib/vvdec/../libmd5 -g -O2 -ffile-prefix-map=/home/marillat/vvdec-dmo-1.1.2=. -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -O3 -DNDEBUG -fPIC -Wall -Werror -Wno-unused-function -Wno-sign-compare -fdiagnostics-show-option -Wno-ignored-attributes -std=gnu++14 -MD -MT source/Lib/vvdec/CMakeFiles/vvdec.dir/__/CommonLib/UnitTools.cpp.o -MF source/Lib/vvdec/CMakeFiles/vvdec.dir/__/CommonLib/UnitTools.cpp.o.d -o source/Lib/vvdec/CMakeFiles/vvdec.dir/__/CommonLib/UnitTools.cpp.o -c ../source/Lib/CommonLib/UnitTools.cpp
../source/Lib/CommonLib/UnitTools.cpp: In function ‘void vvdec::PU::getInterMergeCandidates(const PredictionUnit&, vvdec::MergeCtx&, vvdec::MotionHist&, const int&)’:
../source/Lib/CommonLib/UnitTools.cpp:1246:50: error: writing 1 byte into a region of size 0 [-Werror=stringop-overflow=]
 1246 |     mrgCtx.interDirNeighbours [uiArrayAddr     ] = 1;
      |     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~
In file included from ../source/Lib/CommonLib/UnitTools.h:55,
                 from ../source/Lib/CommonLib/UnitTools.cpp:51:
../source/Lib/CommonLib/ContextModelling.h:468:17: note: at offset 6 to object ‘vvdec::MergeCtx::interDirNeighbours’ with size 6 declared here
  468 |   unsigned char interDirNeighbours[ MRG_MAX_NUM_CANDS      ];
      |                 ^~~~~~~~~~~~~~~~~~
../source/Lib/CommonLib/UnitTools.cpp:1247:50: error: writing 1 byte into a region of size 0 [-Werror=stringop-overflow=]
 1247 |     mrgCtx.BcwIdx             [uiArrayAddr     ] = BCW_DEFAULT;
      |     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~
In file included from ../source/Lib/CommonLib/UnitTools.h:55,
                 from ../source/Lib/CommonLib/UnitTools.cpp:51:
../source/Lib/CommonLib/ContextModelling.h:467:17: note: at offset 6 to object ‘vvdec::MergeCtx::BcwIdx’ with size 6 declared here
  467 |   uint8_t       BcwIdx            [ MRG_MAX_NUM_CANDS      ];
      |                 ^~~~~~
../source/Lib/CommonLib/UnitTools.cpp:1253:58: error: writing 1 byte into a region of size 0 [-Werror=stringop-overflow=]
 1253 |       mrgCtx.interDirNeighbours [ uiArrayAddr          ] = 3;
      |       ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~
In file included from ../source/Lib/CommonLib/UnitTools.h:55,
                 from ../source/Lib/CommonLib/UnitTools.cpp:51:
../source/Lib/CommonLib/ContextModelling.h:468:17: note: at offset 6 to object ‘vvdec::MergeCtx::interDirNeighbours’ with size 6 declared here
  468 |   unsigned char interDirNeighbours[ MRG_MAX_NUM_CANDS      ];
      |                 ^~~~~~~~~~~~~~~~~~
cc1plus: all warnings being treated as errors```

That looks like a bug in the static analyzer of the specific GCC version you are using. If you look at the code two lines above the first error, there is a loop condition to check that uiArrayAddr doesn't exceed the MRG_MAX_NUM_CANDS range:
  while (uiArrayAddr < maxNumMergeCand && uiArrayAddr < MRG_MAX_NUM_CANDS)
  {
    mrgCtx.interDirNeighbours [uiArrayAddr     ] = 1;
    mrgCtx.BcwIdx             [uiArrayAddr     ] = BCW_DEFAULT;
    mrgCtx.mvFieldNeighbours  [uiArrayAddr << 1] . setMvField(Mv(0, 0), r);
    mrgCtx.useAltHpelIf       [uiArrayAddr     ] = false;

You can work around the issue by adding -Wno-error=stringop-overflow to the compiler-flags in source/Lib/vvdec/CMakeLists.txt line 100.

I agree the gcc version is old. I already did a build by removing -Werror from compiler flags
You can close this bug. I'll report this bug to GCC if I see again this problem with never GCC.


Fix validating null values throws exception

This PR fixes an issue with validating strings when the string is null.
To reproduce, define a GraphQL mutation with a validatable string argument, e.g.:
    public async Task ExampleMutation([StringLength(6)] string exampleArgument = "")
    {
        ...
    }

Expected/actual behavior:

exampleArgument = null => expected valid, actually throws ArgumentNullException ❌
exampleArgument = String.Empty  => expected valid ✅
exampleArgument = "123456" => expected valid ✅
exampleArgument = "1234567" => expected not valid ✅

Cause:
In the middleware a ValidationContext is created from the value object. If this is null, the context cannot be created.
Solution
When validating values the ValidationContext is not relevant. Therefore it can be ommitted by creating a ValidationContext from the current instance when the value is null

@kroschelino The issue will be resolved easily if you use required attribute.
 public async Task ExampleMutation([StringLength(6),Required] string exampleArgument = "")
    {
        ...
    }

I do not understand why this PR wasn't accepted.
This is an valid scenario when the argument is not required? And certainly a validation should not fail because of StringLength on a null input. If we want to forbid null we add the Required.


Remove unused Python modules in linearize-data.py

Hello,
In my opinion, No json, base64, httplib Python module are required.
Because it is not used.
What do you think of it?
Thanks.

I think that PRs need to address pre-existing issues and/or demonstrate significant work. This is an attempt to game the system; it's not appropriate.


Support deletetion of files with unmappable characters in their names

Please have a look at the individual commit messages for the details.

Splitting out unproblematic stuff to https://github.com/oss-review-toolkit/ort/pull/9068 for now.


add vault_update_policy_type parameter

When changing the loadbalancer from external to internal the instance were not recreated and vault was unreachable
Add vault_update_policy_type parameter so the type can be chanched to PROACTIVE as needed
Default value of the parameter is OPPORTUNISTIC to not change the default behavoir altought a PROACTIVE approach is problably better.

Thanks for the PR! 🚀
Unfortunately it looks like some of our CI checks failed. See the Contributing Guide for details.

⚠check_documentation
The documentation needs to be regenerated. Please run make generate_docs.

Checking for documentation generation
diff -r '--exclude=.terraform' '--exclude=.kitchen' '--exclude=.git' '--exclude=autogen' '--exclude=*.tfvars' /workspace/README.md /tmp/tmp.TLmI2pYeGU/generate_docs/workspace/README.md
229a230
> | vault\_update\_policy\_type | Options are OPPORTUNISTIC or PROACTIVE. If `PROACTIVE`, the instance group manager proactively executes actions in order to bring instances to their target versions | string | `"OPPORTUNISTIC"` | no |
diff -r '--exclude=.terraform' '--exclude=.kitchen' '--exclude=.git' '--exclude=autogen' '--exclude=*.tfvars' /workspace/modules/cluster/README.md /tmp/tmp.TLmI2pYeGU/generate_docs/workspace/modules/cluster/README.md
80a81
> | vault\_update\_policy\_type | Options are OPPORTUNISTIC or PROACTIVE. If `PROACTIVE`, the instance group manager proactively executes actions in order to bring instances to their target versions | string | `"OPPORTUNISTIC"` | no |
Error: Documentation generation has not been run, please run the
'make docker_generate_docs' command and commit the above changes.


Feature request - Nested stacks creation

At the moment stack_master cannot create nested stacks as it's supplying the template body to the API.
Do you have any plans to support that?
The way I see it :

An S3 bucket URL and prefix would have to be added to the config file (global and per-region configuration)
All nested templates would have to be declared alongside the main template, maybe as a file parameter (that would allow one to upload any kind of file to that bucket, if used by a UserData script or such) and uploaded to that bucket
When creating the stack, pass in a template_url instead of a template_body parameter
I'm not sure how the stack events would be handled. Worst case would be that only the events from the toplevel stack would be displayed (so not events from the nested stacks). I suppose it's good enough for a first version
Stack deletion should work as-is as cfn takes care of the substack deletion
Diffs, Output and Resources listing would only show the ones from the toplevel template. AFAIK there is no easy way to get substacks other that iterating over the Cloudformation::Stack resources recursively. Again I assume that would be acceptable in a first version.
The too_big?method would need to know which method is used as the allowed size is different

Any thoughts on this? If not I'm happy to give a crack at this.

Hi @lethalpaga
It sounds like there are two parts to this

allowing CF updates via S3
nested stack support

We don't have any immediate plans to implement either, but we've discussed CF updates through S3 before. We don't use nested stacks and instead connect stacks together with stack outputs/parameter resolvers.

All nested templates would have to be declared alongside the main template, maybe as a file parameter (that would allow one to upload any kind of file to that bucket, if used by a UserData script or such) and uploaded to that bucket

That sounds reasonable. Just thinking out load: I wonder if we could use parameter resolvers for this. For example:
nested_stack_url:
  nested_stack: template-name.rb

The resolver would automatically compile and upload the template and provide an S3 url. I'm not sure how diffing would work on nested stacks though.
Happy for you to have a go implementing this. Thanks!

The SparkleFormation nest!() method will generate a nested stack resource (which includes a path to the template in the S3 Bucket). You would need to support configuring the bucket(s) to use (and providing these to SparkleFormation at compilation) and uploading templates to the bucket.
This is implemented in sfn if you'd like to see it in action to understand how the parts work.

We support S3 uploads now, I'm unsure if nested stacks are supported though. Feel free to open a new issue if there are any issues.


fix: cleanup # symbol in router

before

after

This change would require us to change https://github.com/SJTU-Plus/sjtu-plus-docker/blob/master/caddy/Caddyfile to respond index.html as 404. @danyang685 Would you please take a look?


Investigate why we can remove a post twice

Hitting the delete post endpoint (such as /posts/5) in the admin app succeeds multiple times. This should not happen as multiple deletions shouldn't work!

Hi @matheusgomes28 according to the specification to HTTP the DELETE operation is idempotent and therefore should be callable multiple times. Even though the return code can vary.

Ref: https://developer.mozilla.org/en-US/docs/Glossary/Idempotent

Hey @AlDu2407 , that's fine but the issue is that it succeeds more than once - implying that we're not retuning a 404 on the second time

Pretty sure this is no longer a problem


"No module named llava"

I installed this codebase using the setup script. When running the command:
python -W ignore llava/eval/run_vila.py \
    --model-path Efficient-Large-Model/Llama-3-VILA1.5-8b \
    --conv-mode llama_3 \
    --query "<image>\n Please describe the traffic condition." \
    --image-file "av.png"

I get the error:
Traceback (most recent call last):
  File "/my/homedir/VILA/llava/eval/run_vila.py", line 12, in <module>
    from llava.constants import (DEFAULT_IM_END_TOKEN, DEFAULT_IM_START_TOKEN,
ModuleNotFoundError: No module named 'llava'

What could be causing this?

(I think you need to install the [train] stuff as well?

Same here. Have you resolved this issue?? @vedantroy


flutter_secure_storage does not work on Windows.

Secure storage does not work on Windows, please check.

I am closing all older issues. If this issue still exists in the latest version, please let me know.


compute stats.py {TYPE MODE !!!}

Hi all, I get an error like this when I try to compute metrics for classification (i.e. mode==type) but it works when I set the mode to instances???
(hovernet) DDD:/hover_net$ **python compute_stats.py --mode=type --**pred_dir='/media/hover_net/Output_predFiles/testImages/mat' --true_dir='/media/hover_net/dataset/Test/Labels'
Traceback (most recent call last):
File "compute_stats.py", line 247, in
run_nuclei_type_stat(args.pred_dir, args.true_dir)
File "compute_stats.py", line 103, in run_nuclei_type_stat
paired_all = np.concatenate(paired_all, axis=0)
File "<array_function internals>", line 6, in concatenate
ValueError: need at least one array to concatenate

Did you use a model with typing to make the prediction? And which dataset is this?

yes , i used Consep dataset with nr_types=5 and original mode. I was able to get the instances metrics but I couldn't do that with the types.

yes , i used Consep dataset with nr_types=5 and original mode. I was able to get the instances metrics but I couldn't do that with the types.

I have the same issue. Did you find any solution? I am unable to compute_stats for ConSeP dataset.


Fix typos

Thanks for your contribution!

:partying_face: :partying_face: :partying_face: :partying_face: :partying_face:


README: remove make test-integration since there is no such rule

There is no such rule in the Makefile.

/assign @dgoodwin

/lgtm


There’s not a way to convert from non TLS mode to TLS mode using self-signed certificate.

I’m connected to a system that is configured in non TLS mode, I want to pin the Self Signed certificate.

See https://github.com/open-amt-cloud-toolkit/console/issues/187 for feature request of editing device's credentials/info
See https://github.com/open-amt-cloud-toolkit/console/issues/192 for adding support for TLS pinning


Video playback does not start after upgrading Libreelec

Bug report
Your Environment

Netflix add-on version:  1.11.0
Operating system version/name: Libreelec 9.80 Nightly 20201212
Device model:  RaspberryPi3

Used Operating system:

[ ] Android
[ ] iOS
[ ] Linux
[ ] OSX
[x] Raspberry-Pi 3
[ ] Windows

Describe the bug
After upgrading libreElec to a recent nightly build with Kodi19, Videos don't play anymore. I can select a Video, then the loading spinner appears, and the Video appears to be running in the background, but I cannot watch it.
Can you help out with that? is it a problem with Kodi?
Debug log
The debug log can be found from this link: https://paste.kodi.tv/ituziguxis.kodi
log-2020-12-12-11.13.17.zip

Never mind, reinstallling the inputstream adaptive helped. Sorry!


Fix woff2 font files

These files got mangled in the git commit due to CR/LF issues.
Fixes #4048

Ah yes, this again. Good catch!


Players cannot "doorbump"

Description

Players can no longer walk into a door to open it. and must actively click each door to open.
What is stranger still is I see no recent change to this... also punpun and other animals can doorbump just fine.
Reproduction

Screenshots

Additional context

organic composition thing missing the DoorBumpOpener tag :trollface:

As far as I can tell, in #19859, BaseMobOrganic was split into BaseMobSpecies and BaseMobSpeciesOrganic, and the Tag component appears to have been forgotten about. I'm not sure if it should go on BaseMobSpecies or BaseMobSpeciesOrganic, but adding it to either seems to fix the problem. It previously had the tags CanPilot, FoostepSound and DoorBumpOpener.

Put it in BaseMobSpecies


feat: add commit linting

Content
Addresses https://github.com/The24thDS/vite-reactts17-chakra-jest-husky/issues/1#issue-963258849 :

add commitint in commit-msg husky hook
add commitizen in prepare-commit-msg husky hook allowing devs to use git commit command to be prompted an helping interface as enclosed

Workaround
I was wondering weither or not we should force devs to use commitizen by kind of "overriding" their git commit command in husky hook.
We could also simply add a yarn command in package.json as follows, to let them the choice :
  ...
  "scripts": {
    "commit": "cz"
  }

@The24thDS What is your opinion ? Should I update the README.md file as well ?

Yeah, I totally agree.
Having a yarn command will totally make the job, but maybe we should mention it in the README ?

Yes, of course

Looks good :) Thank you for your contribution!


release-19.2: backport avg for interval

PR: https://github.com/cockroachdb/cockroach/pull/42679
From release notes:

Added the ability to run avg() over intervals. [#42679][#42679] {% comment %}doc{% endcomment %}

Closed by https://github.com/cockroachdb/docs/pull/8476.


Class libraries no longer automatically create NuGet package?

With prior version of ASP.NET 5, class libraries automatically created NuGet packages on build. This no longer appears to be the case with RC2. Was that an intentional change? I don't see any posts about it in the announcements repo.

I'd like to know too.  I know they removed the wrap command when dnx was replaced with dotnet.  I'm not sure if that tooling change caused this to not be possible anymore?

now you can open a command prompt in the root of the project folder and type
dotnet pack -c Release

and that will generate the nuget for you
I don't know if there is supposed to be a gui way right now or not or if they will bring that back later
note also that there is no more artifacts folder, the /bin folder is back and that is where the nuget will be found after running the command

Need to generate nuget package after build , added following in project.json but does seems to be working any idea?
"scripts": {
"postbuild": "dotnet pack"
}

@jalalions Just today I was adding a prebuild option to my scripts in project.json for something else, and it didn't seem to work.  I tried a simple "prebuild" : "echo Hello World!", but with no luck.  So... I believe it's an issue with project.json.  Try putting this in your .xproj just above the close of the </Project> tag.
<PropertyGroup>
<PostBuildEvent>
echo Building NuGet Package
dotnet pack ..
</PostBuildEvent>
</PropertyGroup>

@guardiannite Try precompile instead of prebuild ... and I'm inquiring on a schema change for project.json now, which shows (incorrectly) that prebuild/postbuild will work. https://github.com/dotnet/cli/issues/3338

This issue is being closed because it has not been updated in 3 months.
We apologize if this causes any inconvenience. We ask that if you are still encountering this issue, please log a new issue with updated information and we will investigate.


strict_validation returning 404 instead of 400 as described in documentation

Description
The documentation says that strict_validation should return a 400, however it appears to be returning a 404 instead
Per the documentation at https://connexion.readthedocs.io/en/latest/request.html#parameter-validation

Connexion can apply strict parameter validation for query and form data parameters. When this is enabled, requests that include parameters not defined in the swagger spec return a 400 error.

Expected behaviour
Connexion returns a 400 Bad Request when a parameter does not match the schema
Actual behaviour
Connexion returns a 404 Not Found when a parameter does not match the schema
Steps to reproduce
Sample Curl Results
connexion issue> curl -i localhost:5000/has-param/1
HTTP/1.0 200 OK
Content-Type: application/json
Content-Length: 2
Server: Werkzeug/0.14.1 Python/3.6.4
Date: Fri, 09 Nov 2018 19:31:03 GMT

1
connexion issue> curl -i localhost:5000/has-param/a
HTTP/1.0 404 NOT FOUND
Content-Type: application/problem+json
Content-Length: 206
Server: Werkzeug/0.14.1 Python/3.6.4
Date: Fri, 09 Nov 2018 19:30:55 GMT

{
  "detail": "The requested URL was not found on the server.  If you entered the URL manually please check your spelling and try again.",
  "status": 404,
  "title": "Not Found",
  "type": "about:blank"
}

Sample Code
import connexion
from connexion.resolver import RestyResolver

def get_has_param(demoId):
    return demoId

if __name__ == '__main__':
    app = connexion.FlaskApp(__name__)
    app.add_api(
        'request-validation-demo.yaml',
        validate_responses=True,
        strict_validation=True,
    )
    app.run()

Sample OpenAPI v3 Document
openapi: 3.0.0
info:
  title: This should be returning a 400 on an invalid parameter
  version: '0'
paths:
  /has-param/{demoId}:
    get:
      summary: This should be returning a 400 when it gets an invalid parameter, not a 404
      operationId: main.get_has_param
      parameters:
        - name: demoId
          in: path
          required: true
          description: This should be a 400 when invalid
          schema:
            type: integer
      responses:
        200:
          description: Demo Result
          content:
            application/json:
              schema:
                type: integer
        400:
          description: Demo 400
          content:
            application/json:
              schema:
                $ref: '#/components/schemas/Error'
        404:
          description: Demo 404
          content:
            application/json:
              schema:
                $ref: '#/components/schemas/Error'
components:
  schemas:
    Error:
      required:
        - code
        - message
      properties:
        code:
          type: integer
        message:
          type: string

Additional info:
Output of the commands:
connexion issue> python3 --version
Python 3.6.4
connexion issue> pip3 show connexion | grep "^Version\:"
Version: 2.0.1
connexion issue>

I think what's happening is that the path parameters generate routes for Flask.
The route that's being generated here is something like: /has-param/<demoId:int>: and so Flask is unable to match /has-param/a to this pattern, and returns a 404.
We could drop all types from Flask routes to ensure that parameters make it through to validation - I'm not sure yet what the full implications of that would be. I'll try to play around with it today.

I just worked through an issue with similar symptoms (I'm guessing it's the same core issue, but someone with a deeper knowledge of connexion may know better).
I added a new path to an existing (and working) project, but was getting 404s in all cases while testing. I narrowed it down to this trivial reproduction case:
Openapi spec:
...
  /games/{game_id}:
    get:
      summary: Game_GET
      description: blah testing
      operationId: main.foo
      parameters:
        - name: game_id
          in: path
          description: ID of the game being played
          required: true
          schema:
            type: number
...

With the corresponding handler:
def foo(game_id):
    return {'hi': game_id}, 200

All calls to .../games/<n> would return a 404. Reading this bug led me to noticed I'd inadvertently specified the parameter type as number rather than integer - when I changed it back to integer all was well.
In my case, I intended the parameter to be an int, so number in the spec was just a mistake. But since number is the way to specify a float per the openapi spec, though, I wonder how one would get connexion routing to work with a float parameter.

Just a little push since the bug is still present in version 2.9.0. It's not breaking but the wrong error message and status code is very confusing for users of an API.

Hi @D3nn3, I'm afraid this issue is not at the top of our priority list at the moment. We currently match Flask behavior and while I agree that a 400 error would be better, I don't think a 404 error is completely wrong either. We would definitely welcome a PR though.
Note that this is not related to strict_validation, which applies strict parameter validation for query and form data parameters, but to malformed path parameters. I updated the title of the issue to reflect this. I think @dtkav was correct in his assessment of the underlying issue.
@jrheling routing with numbers is better supported since version 2.9.

Closing this as a wontfix since routing needs to happen before validation, so a 404 error is thrown before reaching validation.


Notebook kernel can be lost when viewing cell's long stdout output, if ipynb is marked as preview (italicized file tab)

Open a notebook that contains a cell that prints a long list of whatever... ala

for i in range(0,100000):
    print(i)

Make sure the filename in the tab is italicized (I don't know what term we use for this state).
Click on the "show more (open the raw output data..." link.
Your notebook closes and is replaced by the opened text file. Basically you've lost your kernel state at this point.

Try to find a consistent repro for this.

Haven't been able to find a repro.


#apolloauto IRC channel is now alive! (unofficial)

#apolloauto on Freenode
Come and say hello!  :-)
(BTW, Sorry, this is not an issue.)

For peoples who don't familiar with IRC:
(Ignore this if you've already know it)

What is IRC?
Simply, IRC is a tool for communicating with folks from all over the world.(from ref[1])

Basics guide:
https://fedoramagazine.org/beginners-guide-irc/

(Replace the installation command:
"su -c 'dnf install hexchat'"
in this post with
"sudo apt-get install hexchat"
for ubuntu users.
)
(You also can use other clients like Quassel, irssi, Konversation, WeeChat, or web based access from browser, etc.
Just choose the one you like.)
Enjoy!
References:
[1] http://www.ircbeginner.com/ircinfo/ircclass.html
[2] https://help.ubuntu.com/community/InternetRelayChat
[3] https://opensource.com/life/16/6/irc-quickstart-guide
[4] https://code.tutsplus.com/tutorials/irc-is-back-heres-your-starter-guide--net-31369
[5] https://opensource.com/life/15/11/top-open-source-irc-clients
[6] https://en.wikipedia.org/wiki/Comparison_of_Internet_Relay_Chat_clients

Nice thanks!

@richtong Yeah, I just registered it a few days ago, only me and a log bot there(logs is at ip of bot/logs, when my domain is ready, I will update the channel topic). I have saw your hello message from logs in the morning, at that time you joined I was probably in a dream :P
I have noticed that peoples here not use IRC much, but many open source project like Qt, Sailfish, Mer, KDE, ROS, openSUSE, Ubuntu, kernel, android, and many many other projects have IRC channels, some of them are very active. It‘s convenient for community collaboration, hope you will like it. :-)

Thanks very much for doing. Many other projects use slack for the same purpose. Excellent to have a place to discuss. I see the core Apollo team there as well
Thanks,
Rich
Sent from my iPhone X
http://tongfamily.com | @richtong | https://fb.me/richtong1

On Nov 30, 2017, at 08:49, Xingtao Zhang<EMAIL_ADDRESS>wrote:
@richtong Yeah, I just registered it a few days ago, only me and a log bot there(logs is at ip of bot/logs, when my domain is ready, I will update the channel topic). I have saw your hello message from logs in the morning, at that time you joined I was probably in a dream :P
I have noticed that peoples here not use IRC much, but many open source project like Qt, Sailfish, Mer, KDE, ROS, openSUSE, Ubuntu, kernel, android, and many many other projects have IRC channels, some of them are very active. It‘s convenient for community collaboration, hope you will like it. :-)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

close

closed #1424