Question about Variable-length.

@liuzuyan
Hi zuyan, great work!!!
I would like to know if Orys can support different token lengths within a batch or how to deal with it?
For example, a batch length is 2, and due to different image sizes, the visual token lengths are 500 and 50 respectively. Will this cause parallel problems? As far as I know, models such as LLaVA are implemented by padding. If the output token length of OrysViT varies depending on the image resolution, not-padding will cause parallel problems, and padding will increase FLOPS.
I noticed that you still chose to use padding in the code:
https://github.com/Oryx-mllm/Oryx/blob/a36a906b98584002c835a36794deb57f32a9a0f0/oryx/model/oryx_arch.py#L259
It would be great if you can help me point out the code that handles this part!
Thanks!

Hi, thanks for your interest in our work!
In our implementation, we also pad tokens (visual + language) in batches following previous works. That is because we use multiple GPUs (64 in our experiments) for training, therefore even if we compute each sequence as its original length, the overall training time is still determined by the longest sequence, and the padding operation will not increase the overall training time.


[k2v - health check] Service remains unhealthy

I'm submitting a ...

[x] bug report
[ ] feature request
[ ] support request

Do you want to request a feature or report a bug?

bug

What is the current behavior?

After restarting kafka and iotagent-mqtt, the service is unhealthy.

If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem

Steps:

Stop kafka & iotagent-mqtt

k2v-bridge_1                  | 2021-03-11T18:45:01.264Z -- microservice-sdk:consumer -- debug: Disconnecting from kafka...
k2v-bridge_1                  | 2021-03-11T18:45:01.264Z -- microservice-sdk:consumer -- debug: Unsubscribing from all topics and disconnecting ...
k2v-bridge_1                  | 2021-03-11T18:45:01.264Z -- microservice-sdk:commit-mngr -- debug: CommitManager finished successfully.. committing processed offsets
k2v-bridge_1                  | 2021-03-11T18:45:01.264Z -- microservice-sdk:commit-mngr -- debug: Submitting a commit to Kafka: [{"partition":0,"offset":3895,"topic":"admin.dojot.device-manager.device"}]
k2v-bridge_1                  | 2021-03-11T18:45:01.264Z -- microservice-sdk:consumer -- debug: Committed processed offsets!
k2v-bridge_1                  | 2021-03-11T18:45:01.264Z -- microservice-sdk:consumer -- debug: Calling resume consumer; isPaused? false...
k2v-bridge_1                  | 2021-03-11T18:45:01.271Z -- microservice-sdk:consumer -- info: Consumer disconnected. { connectionOpened:<PHONE_NUMBER>636 }
k2v-bridge_1                  | 2021-03-11T18:45:01.271Z -- microservice-sdk:consumer -- debug: Successfully disconnected producer from Kafka.
k2v-bridge_1                  | 2021-03-11T18:45:01.271Z -- k2v:mqtt-client -- warn: MQTT connection closed
k2v-bridge_1                  | 2021-03-11T18:45:02.264Z -- k2v:mqtt-client -- warn: Trying to reconnect to the broker...
k2v-bridge_1                  | 2021-03-11T18:45:07.269Z -- k2v:agent-messenger -- debug: Error while finishing Kafka connection, going on like nothing happened
k2v-bridge_1                  | 2021-03-11T18:45:07.270Z -- k2v:mqtt-client -- warn: MQTT connection closed
k2v-bridge_1                  | 2021-03-11T18:45:08.270Z -- k2v:mqtt-client -- warn: Trying to reconnect to the broker...
k2v-bridge_1                  | 2021-03-11T18:45:13.279Z -- k2v:agent-messenger -- debug: Error while finishing Kafka connection, going on like nothing happened
k2v-bridge_1                  | 2021-03-11T18:45:13.279Z -- k2v:mqtt-client -- warn: MQTT connection closed
k2v-bridge_1                  | 2021-03-11T18:45:14.278Z -- k2v:mqtt-client -- warn: Trying to reconnect to the broker...
k2v-bridge_1                  | 2021-03-11T18:45:19.284Z -- k2v:agent-messenger -- debug: Error while finishing Kafka connection, going on like nothing happened
k2v-bridge_1                  | 2021-03-11T18:45:19.284Z -- k2v:mqtt-client -- warn: MQTT connection closed
k2v-bridge_1                  | 2021-03-11T18:45:20.285Z -- k2v:mqtt-client -- warn: Trying to reconnect to the broker...
k2v-bridge_1                  | 2021-03-11T18:45:25.293Z -- k2v:agent-messenger -- debug: Error while finishing Kafka connection, going on like nothing happened
k2v-bridge_1                  | 2021-03-11T18:45:25.294Z -- k2v:mqtt-client -- warn: MQTT connection closed
k2v-bridge_1                  | 2021-03-11T18:45:26.294Z -- k2v:mqtt-client -- warn: Trying to reconnect to the broker...
k2v-bridge_1                  | 2021-03-11T18:45:31.300Z -- k2v:agent-messenger -- debug: Error while finishing Kafka connection, going on like nothing happened
k2v-bridge_1                  | 2021-03-11T18:45:31.301Z -- k2v:mqtt-client -- warn: MQTT connection closed
k2v-bridge_1                  | 2021-03-11T18:45:32.301Z -- k2v:mqtt-client -- warn: Trying to reconnect to the broker...
k2v-bridge_1                  | 2021-03-11T18:45:34.811Z -- k2v:agent-messenger -- debug: Error while finishing Kafka connection, going on like nothing happened
k2v-bridge_1                  | 2021-03-11T18:45:34.812Z -- k2v:mqtt-client -- warn: MQTT connection closed

Start iotagent-mqtt

k2v-bridge_1                  | 2021-03-11T18:45:42.960Z -- k2v:agent-messenger -- info: Initializing Kafka Consumer...
k2v-bridge_1                  | 2021-03-11T18:45:42.960Z -- microservice-sdk:consumer -- info: Consumer configuration {"in.processing.max.messages":1,"queued.max.messages.bytes":10485760,"subscription.backoff.min.ms":1000,"subscription.backoff.max.ms":60000,"subscription.backoff.delta.ms":1000,"commit.interval.ms":5000,"kafka.consumer":{"client.id":"k2v-bridge","group.id":"k2v-bridge-group-id","max.in.flight.requests.per.connection":1000000,"metadata.broker.list":"kafka:9092","socket.keepalive.enable":false,"enable.auto.commit":false},"kafka.topic":{"acks":-1,"auto.offset.reset":"beginning"},"disconnect.interval.ms":3000}
k2v-bridge_1                  | 2021-03-11T18:45:42.960Z -- microservice-sdk:consumer -- info: Kafka features: gzip,snappy,sasl,regex,lz4,sasl_gssapi,sasl_plain,plugins
k2v-bridge_1                  | 2021-03-11T18:46:12.964Z -- microservice-sdk:consumer -- warn: Kafka event.error: Error: host resolution failure
k2v-bridge_1                  | 2021-03-11T18:46:12.964Z -- microservice-sdk:consumer -- warn: Kafka event.error: Error: all broker connections are down
k2v-bridge_1                  | 2021-03-11T18:46:15.967Z -- microservice-sdk:consumer -- error: Error on connect: Error: broker transport failure
k2v-bridge_1                  | 2021-03-11T18:46:15.967Z -- k2v:agent-messenger -- error: Error while initializing the Kafka Consumer
k2v-bridge_1                  | 2021-03-11T18:46:15.967Z -- k2v:agent-messenger -- error: Error: Local: Broker transport failure
k2v-bridge_1                  |     at Function.createLibrdkafkaError [as create] (/opt/k2v_bridge/node_modules/@dojot/microservice-sdk/node_modules/node-rdkafka/lib/error.js:411:10)
k2v-bridge_1                  |     at /opt/k2v_bridge/node_modules/@dojot/microservice-sdk/node_modules/node-rdkafka/lib/client.js:350:28
k2v-bridge_1                  | 2021-03-11T18:46:15.968Z -- k2v:agent-messenger -- error: Bailing out!
k2v-bridge_1                  | 2021-03-11T18:46:15.968Z -- k2v:mqtt-client -- info: MQTT connection established
k2v-bridge_1                  | 2021-03-11T18:46:20.973Z -- microservice-sdk:service-state-manager -- warn: Removing 2 services...
k2v-bridge_1                  | 2021-03-11T18:46:20.974Z -- microservice-sdk:service-state-manager -- warn: Removed service "kafka"
k2v-bridge_1                  | 2021-03-11T18:46:20.974Z -- microservice-sdk:service-state-manager -- warn: Removed service "mqtt"
k2v-bridge_1                  | 2021-03-11T18:46:20.975Z -- microservice-sdk:service-state-manager -- warn: ... successfully removed all services
k2v-bridge_1                  | 2021-03-11T18:46:20.975Z -- k2v:agent-messenger -- warn: Shutting down Kafka connection...
k2v-bridge_1                  | 2021-03-11T18:46:20.976Z -- microservice-sdk:consumer -- debug: Disconnecting from kafka...
k2v-bridge_1                  | 2021-03-11T18:46:20.976Z -- microservice-sdk:consumer -- debug: ... not initialized. Aborting operation.
k2v-bridge_1                  | 2021-03-11T18:46:20.977Z -- k2v:mqtt-client -- warn: Closing MQTT connection...
k2v-bridge_1                  | 2021-03-11T18:46:20.980Z -- microservice-sdk:service-state-manager -- debug: Service "kafka" is not registered, will not signalize anything
k2v-bridge_1                  | 2021-03-11T18:46:20.982Z -- k2v:agent-messenger -- debug: Error while finishing Kafka connection, going on like nothing happened
k2v-bridge_1                  | 2021-03-11T18:46:20.984Z -- k2v:mqtt-client -- warn: MQTT connection was closed!
k2v-bridge_1                  | 2021-03-11T18:46:20.985Z -- k2v:mqtt-client -- warn: MQTT connection closed
k2v-bridge_1                  | 2021-03-11T18:46:20.988Z -- microservice-sdk:service-state-manager -- debug: Service "kafka" is not registered, will not signalize anything
k2v-bridge_1                  | 2021-03-11T18:46:20.988Z -- microservice-sdk:service-state-manager -- debug: Service "mqtt" is not registered, will not signalize anything
k2v-bridge_1                  | 1 - Trying to connect with *kafka* on port *9092*
k2v-bridge_1                  | 2 - Trying to connect with *kafka* on port *9092*
k2v-bridge_1                  | 3 - Trying to connect with *kafka* on port *9092*
k2v-bridge_1                  | No Kafka brokers available, exiting ...
k2v-bridge_1                  | 1 - Trying to connect with *kafka* on port *9092*
k2v-bridge_1                  | 2 - Trying to connect with *kafka* on port *9092*
k2v-bridge_1                  | 3 - Trying to connect with *kafka* on port *9092*
k2v-bridge_1                  | No Kafka brokers available, exiting ...
k2v-bridge_1                  | 1 - Trying to connect with *kafka* on port *9092*
k2v-bridge_1                  | 2 - Trying to connect with *kafka* on port *9092*
k2v-bridge_1                  | 3 - Trying to connect with *kafka* on port *9092*
k2v-bridge_1                  | No Kafka brokers available, exiting ...
k2v-bridge_1                  | 1 - Trying to connect with *kafka* on port *9092*
k2v-bridge_1                  | 2 - Trying to connect with *kafka* on port *9092*
k2v-bridge_1                  | 3 - Trying to connect with *kafka* on port *9092*
k2v-bridge_1                  | 2 - Trying to connect with *kafka* on port *9092*
k2v-bridge_1                  | 3 - Trying to connect with *kafka* on port *9092*
k2v-bridge_1                  | No Kafka brokers available, exiting ...
dojot_k2v-bridge_1 exited with code 1
k2v-bridge_1                  | 2 - Trying to connect with *kafka* on port *9092*
k2v-bridge_1                  | 3 - Trying to connect with *kafka* on port *9092*
k2v-bridge_1                  | No Kafka brokers available, exiting ...
dojot_k2v-bridge_1 exited with code 1
k2v-bridge_1                  | 2 - Trying to connect with *kafka* on port *9092*
k2v-bridge_1                  | 3 - Trying to connect with *kafka* on port *9092*
k2v-bridge_1                  | No Kafka brokers available, exiting ...
dojot_k2v-bridge_1 exited with code 1
k2v-bridge_1                  | 2 - Trying to connect with *kafka* on port *9092*
k2v-bridge_1                  | 3 - Trying to connect with *kafka* on port *9092*
k2v-bridge_1                  | No Kafka brokers available, exiting ...
dojot_k2v-bridge_1 exited with code 1
k2v-bridge_1                  | 2 - Trying to connect with *kafka* on port *9092*
k2v-bridge_1                  | 3 - Trying to connect with *kafka* on port *9092*
k2v-bridge_1                  | No Kafka brokers available, exiting ...
dojot_k2v-bridge_1 exited with code 1
k2v-bridge_1                  | 2 - Trying to connect with *kafka* on port *9092*
k2v-bridge_1                  | 3 - Trying to connect with *kafka* on port *9092*
k2v-bridge_1                  | No Kafka brokers available, exiting ...
dojot_k2v-bridge_1 exited with code 1
k2v-bridge_1                  | 2 - Trying to connect with *kafka* on port *9092*
k2v-bridge_1                  | 3 - Trying to connect with *kafka* on port *9092*
k2v-bridge_1                  | No Kafka brokers available, exiting ...
dojot_k2v-bridge_1 exited with code 1

Start kafka

k2v-bridge_1                  | 2 - Trying to connect with *kafka* on port *9092*
k2v-bridge_1                  | 3 - Trying to connect with *kafka* on port *9092*
k2v-bridge_1                  | No Kafka brokers available, exiting ...
dojot_k2v-bridge_1 exited with code 1
k2v-bridge_1                  | "ok"
k2v-bridge_1                  | dojot EJBCA broker at host 'x509-identity-mgmt:3000' fully started.
k2v-bridge_1                  | Generating KeyPar in /opt/k2v_bridge/app/cert/k2v-bridge.key
k2v-bridge_1                  | Generating RSA private key, 2048 bit long modulus (2 primes)
k2v-bridge_1                  | ............+++++
k2v-bridge_1                  | ...........+++++
k2v-bridge_1                  | e is 65537 (0x010001)
k2v-bridge_1                  | Create CSR for k2v-bridge
k2v-bridge_1                  |
k2v-bridge_1                  | Signing cert : http://x509-identity-mgmt:3000/internal/api/v1/throw-away
k2v-bridge_1                  |   % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
k2v-bridge_1                  |                                  Dload  Upload   Total   Spent    Left  Speed
100  3005  100  2088  100   917  15938   7000 --:--:-- --:--:-- --:--:-- 22938
k2v-bridge_1                  | Saving CRT /opt/k2v_bridge/app/cert/k2v-bridge.crt
k2v-bridge_1                  |
k2v-bridge_1                  | Retrieve certificate of trusted CA : http://x509-identity-mgmt:3000/internal/api/v1/throw-away/ca
k2v-bridge_1                  |   % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
k2v-bridge_1                  |                                  Dload  Upload   Total   Spent    Left  Speed
100  2277  100  2277    0     0  29960      0 --:--:-- --:--:-- --:--:-- 29960
k2v-bridge_1                  | Saving CRT /opt/k2v_bridge/app/cert/ca.crt
k2v-bridge_1                  |
k2v-bridge_1                  | Retrieve CRL of trusted CA : http://x509-identity-mgmt:3000/internal/api/v1/throw-away/ca/crl
k2v-bridge_1                  |   % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
k2v-bridge_1                  |                                  Dload  Upload   Total   Spent    Left  Speed
100  1106  100  1106    0     0  14179      0 --:--:-- --:--:-- --:--:-- 14179
k2v-bridge_1                  | /opt/k2v_bridge/app/cert/k2v-bridge.crt: OK
k2v-bridge_1                  | Certificate Chain - Verification OK
k2v-bridge_1                  | Authenticated!
k2v-bridge_1                  |
k2v-bridge_1                  | ><EMAIL_ADDRESS>app /opt/k2v_bridge
k2v-bridge_1                  | > node index.js
k2v-bridge_1                  |
k2v-bridge_1                  | 2021-03-11T21:45:48.667Z -- k2v:index -- info: Configuration:
k2v-bridge_1                  | {
k2v-bridge_1                  |   healthcheck: { 'kafka.interval.ms': 30000 },
k2v-bridge_1                  |   log: {
k2v-bridge_1                  |     'console.level': 'debug',
k2v-bridge_1                  |     'file.enable': false,
k2v-bridge_1                  |     'file.filename': 'k2v-%DATE%.log',
k2v-bridge_1                  |     'file.level': 'info',
k2v-bridge_1                  |     verbose: false
k2v-bridge_1                  |   },
k2v-bridge_1                  |   messenger: { 'consumer.topic.suffix': 'dojot.device-manager.device' },
k2v-bridge_1                  |   mqtt: {
k2v-bridge_1                  |     clean: false,
k2v-bridge_1                  |     'client.id': 'k2v-bridge',
k2v-bridge_1                  |     host: 'iotagent-mqtt',
k2v-bridge_1                  |     'keep.alive': 60,
k2v-bridge_1                  |     port: 8883,
k2v-bridge_1                  |     protocol: 'mqtts',
k2v-bridge_1                  |     'reject.unauthorized': true,
k2v-bridge_1                  |     username: 'k2v-bridge',
k2v-bridge_1                  |     ca: '/opt/k2v_bridge/app/cert/ca.crt',
k2v-bridge_1                  |     cert: '/opt/k2v_bridge/app/cert/k2v-bridge.crt',
k2v-bridge_1                  |     key: '/opt/k2v_bridge/app/cert/k2v-bridge.key'
k2v-bridge_1                  |   },
k2v-bridge_1                  |   publish: { qos: 1, 'topic.suffix': '/config' },
k2v-bridge_1                  |   sdk: {
k2v-bridge_1                  |     'in.processing.max.messages': 1,
k2v-bridge_1                  |     'queued.max.messages.bytes': 10485760,
k2v-bridge_1                  |     'subscription.backoff.min.ms': 1000,
k2v-bridge_1                  |     'subscription.backoff.max.ms': 60000,
k2v-bridge_1                  |     'subscription.backoff.delta.ms': 1000,
k2v-bridge_1                  |     'commit.interval.ms': 5000
k2v-bridge_1                  |   },
k2v-bridge_1                  |   consumer: {
k2v-bridge_1                  |     'client.id': 'k2v-bridge',
k2v-bridge_1                  |     'group.id': 'k2v-bridge-group-id',
k2v-bridge_1                  |     'max.in.flight.requests.per.connection': 1000000,
k2v-bridge_1                  |     'metadata.broker.list': 'kafka:9092',
k2v-bridge_1                  |     'socket.keepalive.enable': false
k2v-bridge_1                  |   },
k2v-bridge_1                  |   topic: { acks: -1, 'auto.offset.reset': 'beginning' },
k2v-bridge_1                  |   app: {
k2v-bridge_1                  |     'ejbca.address': 'x509-identity-mgmt:3000',
k2v-bridge_1                  |     hostname: 'k2v-bridge',
k2v-bridge_1                  |     'connection.retry.count': '3',
k2v-bridge_1                  |     'user.config.file': 'docker.conf',
k2v-bridge_1                  |     'connection.retry.timeout': '3',
k2v-bridge_1                  |     basedir: '/opt/k2v_bridge'
k2v-bridge_1                  |   }
k2v-bridge_1                  | }
k2v-bridge_1                  | 2021-03-11T21:45:48.668Z -- microservice-sdk:service-state-manager -- info: Initializing the ServiceStateManager...
k2v-bridge_1                  | 2021-03-11T21:45:48.669Z -- microservice-sdk:service-state-manager -- info: ServiceStateManager configuration: {
k2v-bridge_1                  |   lightship: { detectKubernetes: false, terminate: [Function: terminate] }
k2v-bridge_1                  | }
k2v-bridge_1                  | 2021-03-11T21:45:48.673Z -- microservice-sdk:service-state-manager -- info: ... ServiceStateManager initialized.
k2v-bridge_1                  | 2021-03-11T21:45:48.674Z -- microservice-sdk:service-state-manager -- debug: Service kafka was registered
k2v-bridge_1                  | 2021-03-11T21:45:48.674Z -- microservice-sdk:service-state-manager -- debug: Service mqtt was registered
k2v-bridge_1                  | 2021-03-11T21:45:48.675Z -- microservice-sdk:service-state-manager -- debug: Health checker for service kafka was registered
k2v-bridge_1                  | 2021-03-11T21:45:48.675Z -- k2v:mqtt-client -- info: Connecting MQTT client...
k2v-bridge_1                  | 2021-03-11T21:45:48.705Z -- k2v:mqtt-client -- info: Binding event callbacks...
k2v-bridge_1                  | 2021-03-11T21:45:48.706Z -- k2v:mqtt-client -- info: ... bound event callbacks
k2v-bridge_1                  | 2021-03-11T21:45:48.723Z -- k2v:agent-messenger -- debug: Error while finishing Kafka connection, going on like nothing happened
k2v-bridge_1                  | 2021-03-11T21:45:48.723Z -- k2v:mqtt-client -- warn: MQTT connection closed
k2v-bridge_1                  | 2021-03-11T21:45:49.724Z -- k2v:mqtt-client -- warn: Trying to reconnect to the broker...
k2v-bridge_1                  | 2021-03-11T21:45:49.733Z -- k2v:agent-messenger -- debug: Error while finishing Kafka connection, going on like nothing happened
k2v-bridge_1                  | 2021-03-11T21:45:49.733Z -- k2v:mqtt-client -- warn: MQTT connection closed
k2v-bridge_1                  | 2021-03-11T21:45:50.735Z -- k2v:mqtt-client -- warn: Trying to reconnect to the broker...
k2v-bridge_1                  | 2021-03-11T21:45:50.778Z -- k2v:agent-messenger -- debug: Error while finishing Kafka connection, going on like nothing happened
k2v-bridge_1                  | 2021-03-11T21:45:50.778Z -- k2v:mqtt-client -- warn: MQTT connection closed
k2v-bridge_1                  | 2021-03-11T21:45:51.779Z -- k2v:mqtt-client -- warn: Trying to reconnect to the broker...
k2v-bridge_1                  | 2021-03-11T21:45:51.819Z -- k2v:agent-messenger -- debug: Error while finishing Kafka connection, going on like nothing happened
k2v-bridge_1                  | 2021-03-11T21:45:51.819Z -- k2v:mqtt-client -- warn: MQTT connection closed
k2v-bridge_1                  | 2021-03-11T21:45:52.821Z -- k2v:mqtt-client -- warn: Trying to reconnect to the broker...
k2v-bridge_1                  | 2021-03-11T21:45:52.861Z -- k2v:agent-messenger -- debug: Error while finishing Kafka connection, going on like nothing happened
k2v-bridge_1                  | 2021-03-11T21:45:52.862Z -- k2v:mqtt-client -- warn: MQTT connection closed
k2v-bridge_1                  | 2021-03-11T21:45:53.863Z -- k2v:mqtt-client -- warn: Trying to reconnect to the broker...
k2v-bridge_1                  | 2021-03-11T21:45:53.905Z -- k2v:agent-messenger -- debug: Error while finishing Kafka connection, going on like nothing happened
k2v-bridge_1                  | 2021-03-11T21:45:53.905Z -- k2v:mqtt-client -- warn: MQTT connection closed
k2v-bridge_1                  | 2021-03-11T21:45:54.905Z -- k2v:mqtt-client -- warn: Trying to reconnect to the broker...
k2v-bridge_1                  | 2021-03-11T21:45:54.916Z -- k2v:agent-messenger -- debug: Error while finishing Kafka connection, going on like nothing happened
k2v-bridge_1                  | 2021-03-11T21:45:54.916Z -- k2v:mqtt-client -- warn: MQTT connection closed

What is the expected behavior?

What is the motivation / use case for changing the behavior?

Please tell us about your environment:

Version: 0.6.0-rc.1
Environment: docker-compose
Operating system: Ubuntu 20.04

Other information (e.g. detailed explanation, stacktraces, related issues, suggestions how to fix, links for us to have context, eg. stackoverflow, gitter, etc)

when the service status is unhealthy

k2v-bridge_1                  | 2021-03-11T21:45:48.673Z -- microservice-sdk:service-state-manager -- info: ... ServiceStateManager initialized.
k2v-bridge_1                  | 2021-03-11T21:45:48.674Z -- microservice-sdk:service-state-manager -- debug: Service kafka was registered
k2v-bridge_1                  | 2021-03-11T21:45:48.674Z -- microservice-sdk:service-state-manager -- debug: Service mqtt was registered
k2v-bridge_1                  | 2021-03-11T21:45:48.675Z -- microservice-sdk:service-state-manager -- debug: Health checker for service kafka was registered
k2v-bridge_1                  | 2021-03-11T21:45:48.675Z -- k2v:mqtt-client -- info: Connecting MQTT client...
k2v-bridge_1                  | 2021-03-11T21:45:48.705Z -- k2v:mqtt-client -- info: Binding event callbacks...
k2v-bridge_1                  | 2021-03-11T21:45:48.706Z -- k2v:mqtt-client -- info: ... bound event callbacks
k2v-bridge_1                  | 2021-03-11T21:45:48.723Z -- k2v:agent-messenger -- debug: Error while finishing Kafka connection, going on like nothing happened
k2v-bridge_1                  | 2021-03-11T21:45:48.723Z -- k2v:mqtt-client -- warn: MQTT connection closed
k2v-bridge_1                  | 2021-03-11T21:45:49.724Z -- k2v:mqtt-client -- warn: Trying to reconnect to the broker...
k2v-bridge_1                  | 2021-03-11T21:45:49.733Z -- k2v:agent-messenger -- debug: Error while finishing Kafka connection, going on like nothing happened
k2v-bridge_1                  | 2021-03-11T21:45:49.733Z -- k2v:mqtt-client -- warn: MQTT connection closed

when the service status is healthy

k2v-bridge_1                  | 2021-03-12T14:28:34.146Z -- microservice-sdk:service-state-manager -- info: ... ServiceStateManager initialized.
k2v-bridge_1                  | 2021-03-12T14:28:34.147Z -- microservice-sdk:service-state-manager -- debug: Service kafka was registered
k2v-bridge_1                  | 2021-03-12T14:28:34.147Z -- microservice-sdk:service-state-manager -- debug: Service mqtt was registered
k2v-bridge_1                  | 2021-03-12T14:28:34.148Z -- microservice-sdk:service-state-manager -- debug: Health checker for service kafka was registered
k2v-bridge_1                  | 2021-03-12T14:28:34.148Z -- k2v:mqtt-client -- info: Connecting MQTT client...
k2v-bridge_1                  | 2021-03-12T14:28:34.182Z -- k2v:mqtt-client -- info: Binding event callbacks...
k2v-bridge_1                  | 2021-03-12T14:28:34.182Z -- k2v:mqtt-client -- info: ... bound event callbacks
k2v-bridge_1                  | 2021-03-12T14:28:34.213Z -- k2v:agent-messenger -- info: Initializing Kafka Consumer...
k2v-bridge_1                  | 2021-03-12T14:28:34.214Z -- microservice-sdk:consumer -- info: Consumer configuration {"in.processing.max.messages":1,"queued.max.messages.bytes":10485760,"subscription.backoff.min.ms":1000,"subscription.backoff.max.ms":60000,"subscription.backoff.delta.ms":1000,"commit.interval.ms":5000,"kafka.consumer":{"client.id":"k2v-bridge","group.id":"k2v-bridge-group-id","max.in.flight.requests.per.connection":1000000,"metadata.broker.list":"kafka:9092","socket.keepalive.enable":false,"enable.auto.commit":false},"kafka.topic":{"acks":-1,"auto.offset.reset":"beginning"},"disconnect.interval.ms":3000}
k2v-bridge_1                  | 2021-03-12T14:28:34.214Z -- microservice-sdk:consumer -- info: Kafka features: gzip,snappy,sasl,regex,lz4,sasl_gssapi,sasl_plain,plugins
k2v-bridge_1                  | 2021-03-12T14:28:34.222Z -- microservice-sdk:consumer -- info: Consumer is ready
k2v-bridge_1                  | 2021-03-12T14:28:34.222Z -- microservice-sdk:commit-mngr -- debug: CommitManager initialized successfully..
k2v-bridge_1                  | 2021-03-12T14:28:34.222Z -- microservice-sdk:consumer -- debug: Refreshing subscriptions
k2v-bridge_1                  | 2021-03-12T14:28:34.223Z -- microservice-sdk:consumer -- debug: subscribing in the following topics (0): []
k2v-bridge_1                  | 2021-03-12T14:28:34.223Z -- microservice-sdk:consumer -- debug: subscribing on topic: /^.+dojot\.device-manager\.device/
k2v-bridge_1                  | 2021-03-12T14:28:34.224Z -- microservice-sdk:consumer -- debug: Refreshing subscriptions
k2v-bridge_1                  | 2021-03-12T14:28:34.224Z -- microservice-sdk:consumer -- debug: subscribing in the following topics (1): [{}]
k2v-bridge_1                  | % ^.+dojot\.device-manager\.device
k2v-bridge_1                  | 2021-03-12T14:28:34.225Z -- k2v:agent-messenger -- info: ... Kafka Consumer was initialized
k2v-bridge_1                  | 2021-03-12T14:28:34.225Z -- k2v:mqtt-client -- info: MQTT connection established

The error was not reproduced in version v0.6.0-rc.2.


Catalyst crash on launch with thread sanitizer on

Step 0: Are you in the right place?
[REQUIRED] Step 1: Describe your environment

Xcode version: 13.2.1
Firebase SDK version:  8.10.0
Installation method: CocoaPods
Firebase Component: Core
Target platform(s): All | iOS | Catalyst | macOS | tvOS | watchOS

[REQUIRED] Step 2: Describe the problem
Crash when trying to launch on MacOS 12.0.1 Catalyst after compiling with thread sanitizer on
I see the following :
libdispatch.dylib`_dlock_wait.cold.1:
    0x10efcdcf4 <+0>:  movl   %edi, %eax
    0x10efcdcf6 <+2>:  leaq   0x62ab(%rip), %rcx        ; "BUG IN LIBDISPATCH: ulock_wait() failed"
    0x10efcdcfd <+9>:  movq   %rcx, 0x33624(%rip)       ; gCRAnnotations + 8
    0x10efcdd04 <+16>: movq   %rax, 0x3364d(%rip)       ; gCRAnnotations + 56
->  0x10efcdd0b <+23>: ud2

Thread 9: EXC_BAD_INSTRUCTION (code=EXC_I386_INVOP, subcode=0x0)

Thread 9 Queue : com.apple.network.connections (serial)
#0	0x000000010efcdd0b in _dlock_wait.cold.1 ()
#1	0x000000010ef951fa in _dlock_wait ()
#2	0x000000010ef9515c in _dispatch_once_wait ()
#3	0x00007ff8294c620d in nw_protocol_tcp_connect ()
#4	0x00007ff8200359e8 in nw_protocol_boringssl_connect ()
#5	0x00007ff820aeba67 in ___lldb_unnamed_symbol431$$CFNetwork ()
#6	0x00007ff820193de5 in nw_endpoint_flow_connect ()
#7	0x00007ff82015ed72 in nw_endpoint_flow_setup_protocols ()
#8	0x00007ff8202c0d4c in nw_endpoint_flow_setup_channel ()
#9	0x00007ff8201bc42e in -[NWConcrete_nw_endpoint_flow updatePathWithHandler:] ()
#10	0x00007ff820187bea in nw_endpoint_handler_path_change ()
#11	0x00007ff8201bb8bc in __nw_endpoint_handler_initialize_association_block_invoke ()
#12	0x00007ff8201bb7f2 in __nw_association_update_paths_block_invoke.74 ()
#13	0x00007ff8201ad9b1 in nw_hash_table_apply ()
#14	0x00007ff8201bb349 in nw_association_update_paths ()
#15	0x00007ff8201b6045 in nw_path_necp_update_evaluator ()
#16	0x00007ff8201b40f8 in nw_path_necp_check_for_updates ()
#17	0x00007ff8201b3b03 in nw_path_evaluator_force_update ()
#18	0x00007ff8201b37f4 in nw_association_force_update ()
#19	0x00007ff8202c25fd in nw_endpoint_flow_setup_channel ()
#20	0x00007ff82018e534 in -[NWConcrete_nw_endpoint_flow startWithHandler:] ()
#21	0x00007ff820189455 in nw_endpoint_handler_path_change ()
#22	0x00007ff820181240 in nw_endpoint_handler_start ()
#23	0x00007ff82022ae64 in nw_endpoint_resolver_start_next_child ()
#24	0x000000010e0670dc in __tsan::invoke_and_release_block(void*) ()
#25	0x000000010e066e32 in __tsan::dispatch_callback_wrap(void*) ()
#26	0x000000010ef94874 in _dispatch_client_callout ()
#27	0x000000010ef9e9be in _dispatch_workloop_invoke ()
#28	0x000000010efaad1d in _dispatch_workloop_worker_thread ()
#29	0x000000010f03b7e7 in _pthread_wqthread ()
#30	0x000000010f041ceb in start_wqthread ()
Enqueued from com.apple.network.connections (Thread 9) Queue : com.apple.network.connections (serial)
#0	0x000000010ef98ba7 in _dispatch_async_f_slow ()
#1	0x000000010e0670bf in wrap_dispatch_async ()
#2	0x00007ff820261fd1 in nw_queue_context_async ()
#3	0x00007ff820228e14 in nw_endpoint_resolver_update ()
#4	0x00007ff8207257be in __52-[NWConcrete_nw_endpoint_resolver startWithHandler:]_block_invoke.3 ()
#5	0x00007ff8202271b0 in __nw_resolver_update_client_block_invoke ()
#6	0x000000010e0670dc in __tsan::invoke_and_release_block(void*) ()
#7	0x000000010e066e32 in __tsan::dispatch_callback_wrap(void*) ()
#8	0x000000010ef94874 in _dispatch_client_callout ()
#9	0x000000010ef9e9be in _dispatch_workloop_invoke ()
#10	0x000000010efaad1d in _dispatch_workloop_worker_thread ()
#11	0x000000010f03b7e7 in _pthread_wqthread ()
#12	0x000000010f041ceb in start_wqthread ()
Enqueued from com.apple.network.connections (Thread 9) Queue : com.apple.network.connections (serial)
#0	0x000000010ef98ba7 in _dispatch_async_f_slow ()
#1	0x000000010e0670bf in wrap_dispatch_async ()
#2	0x00007ff820261fd1 in nw_queue_context_async ()
#3	0x00007ff820223f8a in nw_resolver_update_client ()
#4	0x00007ff820223349 in nw_resolver_update_status_locked ()
#5	0x00007ff820470ba8 in __nw_resolver_create_dns_getaddrinfo_locked_block_invoke.165 ()
#6	0x00007ff822809c04 in ___dnssd_getaddrinfo_activate_block_invoke ()
#7	0x000000010e066e32 in __tsan::dispatch_callback_wrap(void*) ()
#8	0x000000010ef94874 in _dispatch_client_callout ()
#9	0x000000010ef97792 in _dispatch_continuation_pop ()
#10	0x000000010efaef96 in _dispatch_source_invoke ()
#11	0x000000010ef9e7d1 in _dispatch_workloop_invoke ()
#12	0x000000010efaad1d in _dispatch_workloop_worker_thread ()
#13	0x000000010f03b7e7 in _pthread_wqthread ()
#14	0x000000010f041ceb in start_wqthread ()

There's a couple strange things about this crash.

The symbols are mostly libdispatch symbols and there aren't any Firebase symbols in the stack. Firebase could still be causing this crash, but we'll need a reproducible test case to figure out how that's happening.
The BUG IN LIBDISPATCH and EXC_BAD_INSTRUCTION are unusual as well. If it really is a bug in libdispatch, the crash may not be reproducible in other versions of macOS. Can you test this?

This might be related to #9061.
I don't yet have Xcode 13.2.1, but Xcode 13.2b2 gives me the #9061 crash for Catalyst. Xcode 13.1 works fine. I tested with https://github.com/firebase/quickstart-ios/tree/master/analytics

The Analytics Quickstart runs fine for me with Catalyst on macOS 12.0.1 with Xcode 13.2.1.  I suspect the issue may be specific to the app and we'll likely need a reproducible test case to help.


Improve conversion from scalars to native types

In this PR, conversions from scalars to native data types (int or bool) have been reimplemented, which happens when each scalar token is found in an input buffer during the deserialization process.
The conversions required unnecessary std::string instance creations before, which causes a number of heap allocations even when the instanciations is just the same as duplication of some part of an input buffer.
Most of the unnecessary heap allocations have therefore been replaced with references using iterators with no changes in public APIs and behaviors from the viewpoint of library users.
One exception is that conversions from a scalar to a floating point value still requires unnecessary heap allocations by default.
If std::from_chars() (since C++17) is available, the library now call it and thus no heap allocation happens.
In the other cases, however, the library calls std::stof(), std::stod() or std::stold() depending on the destination type which require a std::string object for a null-terminated string.
Although using some third party libraries like fast_float or implementing a similar feature inside the library can resolve this issue, that either consts a lot or leads to other issues (licensing, dependency management, etc...).
So, I put aside the issue and moved the latest implementations (with some sophistication though).

Pull Request Checklist
Read the CONTRIBUTING.md file for detailed information.

[x] Changes are described in the pull request or in a referenced issue.
[x] The test suite compiles and runs without any error.
[x] The code coverage on your branch is 100%.
[x] The documentation is updated if you added/changed a feature.

Please don't

The C++11 support varies between different compilers and versions. Please note the list of supported compilers. Some compilers like GCC 4.7 (and earlier), Clang 3.3 (and earlier), or Microsoft Visual Studio 13.0 and earlier are known not to work due to missing or incomplete C++11 support. Please refrain from proposing changes that work around these compiler's limitations with #ifdefs or other means.
Please refrain from proposing changes that would break YAML specifications. If you propose a conformant extension of YAML to be supported by the library, please motivate this extension.
Please do not open pull requests that address multiple issues.

CAVEAT
While fixing CI errors, I've found some issues related to Valgrind and MinGW compilers.
The issues are all related to the long double type which were not well tested before.

( Valgrind )
It doesn't support long double and its internal workaround somehow causes wrong errors.
( MinGW compilers )
It produces weired conversion results from scalars(string) to long double values.

All the related test cases are now changed to be disabled when either Valgrind or MinGW is used.


Introduce @SafeUnroll

We came across https://github.com/gradle/gradle/issues/8787 again. As the first step
to get rid of this issue, now we introduce UniqueNameProvider and @SafeUnroll to
find out duplicate test ids in launcher module.
This can be a first step of better @Unroll handing: https://github.com/gradle/gradle/pull/13693

@bot-gradle test QF

OK, I've already triggered QuickFeedback build for you.

@bot-gradle test QF

OK, I've already triggered QuickFeedback build for you.

@bot-gradle test QF

OK, I've already triggered QuickFeedback build for you.

@bot-gradle test this

OK, I've already triggered ReadyForMerge build for you.


Introduce Prometheus Metrics regarding CPU and Memory Limits and Storage at Cluster Level

As Sebastian and Mathew I would like to be able to see Prometheus Metrics regarding CPU Limits and Requests at cluster level so that I can make informed decisions about possible resource problems.
Acceptance Criteria

[ ] Follow Project DOD
[ ] We use prometheus as a source for the metrics
[ ] The feature is enabled when prometheus is available in the cluster and disabled when prometheus is disabled.
[ ] We will follow Fiori Guidelines when comes to the style of the graph
[ ] Our users are used to Grafana dashboards, so  when choosing a graph style use https://grafana.com/docs/grafana/latest/visualizations/ as inspiration
[ ] We show CPU,Memory and Storage Limits and Requests
[ ] We can consider using a design that is similar to the one attached - horizontal stacked bars
[ ] This graph will be on the same level 0 separate card to Historical CPU/Memory graph on Cluster Overview
[ ] The Refresh rate of the data is predetermined and user cannot change it
[ ] Fe follow the DOD

Tasks

[ ] task 1

** External Links **

https://learnk8s.io/setting-cpu-memory-limits-requests
https://sysdig.com/blog/kubernetes-limits-requests/
https://shipit.dev/posts/wasting-money-with-kubernetes.html

Draft work plan

Get the data from Grafana, to have the query (similar to other graphs)

We need to check if we have a query that has all the information that we need, or we need to combine it, which requires more work.

Find out how to display the graphs.


Allow setting additional data for OpenID model

This class should allow additional fields instead of just the base fields. There are more useful pieces of information I need as a response from verify_and_process such as: User citizenship, phone number, etc.

Wouldn't it be better if your provider returned a subclass of OpenID? In #31 there is no IDE autocomplete for the fields you add as extra. If you subclass OpenID, add your custom fields, and then return your custom OpenID from verify_and_process, you get what you need and still keep all fields transparent.

Yeah, this is what I ended up doing, I guess it seems odd that I must subclass OpenID when all I really want is the data that is returned from my SSO server. It seems like something that I shouldn't have to enforce a BaseModel for since as far as I can tell here the only advantage I get is some dot notation and typeahead for static analysis. But your answer does make sense so I am happy to have the issue closed.

Hi again, I've been thinking about this for quite some time now and I understand getting a Pydantic model as a response may not always be what you want. And so I will introduce a way to actually get the bare json response from the server instead. Thank you for this thought-provoking issue.

@sammaphey you can just subclass your SSO and override openid_from_response to return something potentially different. If it's a subclass of OpenID even the type info would be correct :)


Errors at loading

project is not working, black screen and no terrain present, two errore at loading:
1st Error: Missing TerrainGen Modules / Would you like to rebuild them now?
after rebuilding:
2nd Error: Failed to load map!
/mypath/TerrainGen-master/TerrainGen-master/Content/MyLevel.umap appears to be an asset file.

I couldn't reproduce your error unfortunately. I can tell you what I did to build the project from scratch through:

git clone https://github.com/vmartsynovskyy/TerrainGen.git
Open the .uproject file with Unreal Engine
Click ok when it asks to rebuild the modules
After its done click the play button at the top, making sure that the loaded level is MyLevel.umap

I'm doing all of this on Unreal Engine 4.21.2 and Visual Studio 2017 15.9.7 on Windows 10.
If the steps I gave you don't work could you give me the versions of Unreal Engine, Visual Studio, and what OS you are using?

the problem is that the level named MyLevel.umap
appear to be like an asset and not a level map
2nd Error: Failed to load map!
/mypath/TerrainGen-master/TerrainGen-master/Content/MyLevel.umap appears to be an asset file.

I'm on UE 4.21.2 on Windows 10

Hmm I looked into it a bit more online and it seems like it might have to do with Git LFS which is what I'm using to store the umap file, but the weird part is that I can pull it from scratch on my machine just fine.
My output for the command git lfs version is git-lfs/2.4.2 (GitHub; windows amd64; go 1.8.3; git 6f4b2e98). Could you check the output of that command yourself and if your git-lfs version is lower try updating Git and then cloning again to see if it makes a difference.

mine is git-lfs/2.7.1 (GitHub; windows amd64; go 1.11.5; git 6b7fb6e3)
but still can't download a working version

Finally get to work!
Is it normal I don't get any terrain preview since I don't go to play mode?

Glad you got it working. What did you do differently that made it work?
And yeah it's normal.


added spikefinder dataset

Coverage remained the same at 95.392% when pulling 159fe086e236cbc35a9eff8124ab719783970fe6 on codekansas:master into<PHONE_NUMBER>230d1549809952279afdcc7b8ba58b on KordingLab:master.


feat(ktooltip): reskin component styles [KHCP-9007]

Summary
Figma
Jira
KTooltip component reskin
Links:

Kongponents docs preview

PR Checklist

[ ] Conventional Commits all commits follow the conventional commit standards outlined in the main README.
[ ] Tests coverage: test coverage was added for new features and bug fixes
[ ] Docs: includes a technically accurate README

the font weight needs to be bumped up to 500


Add support to install 3rd-party packages

Relational
In case a syntax embeds a 3rd-party syntax it might be required to install it to succeed related syntax tests.
Request
Add a variable like packages to pass a list of repositories to clone packages from.
    steps:
      - uses: actions/checkout@v2
      - uses: SublimeText/syntax-test-action@v2
        with:
          build: ${{ matrix.build }}
          default_packages: ${{ matrix.default_packages }}
          packages:
            - https://github.com/danro/LESS-sublime
            - https://github.com/braver/SublimeSass
            - ...

Might require giving the packages specific names, too, yes?

It will require the repo, a ref and the name to install at, but quite possible indeed.
(I wonder at what point I will change the wrapper script to use Python.)

This is now live in 2.2 after some fixes (via trial and error and an added test case in this repo).


Split TableAdmin samples out of bigtable_samples.cc

We should split the examples related to bigtable::TableAdmin to its own file. We should also change the samples to use the style followed in the Google Cloud Storage examples, i.e.:

The main() function just parses the command (the name of the example) to execute.
The main() function passes argc and argv to a function that implements the example.
The function parses argc and argv and calls a lambda with those arguments.
Only the body of the lambda is reference in the Doxygen snippet.

To see how this works look here:
https://github.com/GoogleCloudPlatform/google-cloud-cpp/blob/58b603dfa10b58303eeb259ea749d1ba7473fa40/google/cloud/storage/examples/storage_bucket_samples.cc#L68
That design is far more flexible, it allow you to have different number of arguments for each example, and the lambda can show the expected types for the arguments.
That would make PRs like #1103 much easier to write.

I would like to confirm my understanding as below
following examples should move to new file  table_admin_samples.cc
CreateTable, ListTables, GetTable, DeleteTable, ModifyTable, DropAllRows, DropRowsByPrefix, Apply, BulkApply, ReadRow, ReadRows, ReadRowsWithLimit, CheckAndMutate, ReadModifyWrite, SampleRows, SampleRowsCollections, RunTableOperations, RunFullExample.
following examples should be written in existing file  bigtable_samples.cc
WaitForConsistencyCheck, CheckConsistency, ListSnapshots, GetSnapshots, DeleteSnapshot, CreateTableFromSnapshot
Above both files should follow the style as per
google-cloud-cpp/google/cloud/storage/examples/storage_bucket_samples.cc

I would like to confirm my understanding as below
following examples should move to new file table_admin_samples.cc

I would suggest you call that table_admin_snippets.cc because we have 3 cases:

CreateTable, ListTables, GetTable, DeleteTable, ModifyTable, DropAllRows, DropRowsByPrefix,

I think these belong in the new table_admin_snippets.cc

Apply, BulkApply, ReadRow, ReadRows, ReadRowsWithLimit, CheckAndMutate, ReadModifyWrite, SampleRows, SampleRowsCollections,

I think these belong in a new file maybe data_admin_snippets.cc?

RunTableOperations, RunFullExample.

We should probably leave these where they are.
following examples should be written in existing file bigtable_samples.cc

WaitForConsistencyCheck, CheckConsistency, ListSnapshots, GetSnapshots, DeleteSnapshot, CreateTableFromSnapshot

Hmmm, I think these belong in table_admin_snippets, right?

Above both files should follow the style as per
google-cloud-cpp/google/cloud/storage/examples/storage_bucket_samples.cc

The snippets files should.
This is going to be a big change.  Please split it in multiple PRs.  I recommend you start with one of the two snippet files and move one example first. Then we move all the examples for that file, then we proceed with the other files.


chore(travis): update browsers to the latest version

Update the used browsers to the latest versions available

@lgalfaso - there appear to be two fixes in this commit.
One is related to a bug in Safari I believe? (The old 2px thing). I think this should be in a separate commit.

Newer versions of Safari do not update the calculated properties (after a programatic css change) synchronously. The change to the test is needed to make it pass in Safari (I can make it 2 commits, but just the browser update without the change on the test will make the test fail in Safari)

You can always have commits that fail followed by commits that fix them as long as they are pushed together. But in this case, it is not needed. We just put the "fix" commit first.

I guess we backport to 1.3.x


Darwin stdenv is broken

Issue description
building '/nix/store/b3vyrfzarzyh51n7fj9wrpw12sq3765l-stdenv-darwin.drv'...
output '/nix/store/3agkxvkbhfpimnx5imr09q4rq9pxmjda-stdenv-darwin' is not allowed to refer to the following paths:
  /nix/store/jnzhx3hni0ds1wf49z8wfnxi3qdnkk6q-gnum4-1.4.18
  /nix/store/smdncnz5pkl5q39k4ldk8bh84p2hmj19-bison-3.3.2

Steps to reproduce

Use darwin
Try to build anything from master.

Bisecting showed that the offending commit is<PHONE_NUMBER>f72d004c09b1fb562a0f6946bfdc4b
cc @ctheune @andir @vcunat @FRidh @NixOS/darwin-maintainers

Revert on staging-19.03 before it lands on release-19.03: #59525

The following diff, which makes gettext use byacc instead of bison, seems to make the error go away, at least for one of the gettext derivations built by my macOS machine. It's probably not the right solution, though, so please don't merge it as-is!
diff --git a/pkgs/development/libraries/gettext/default.nix b/pkgs/development/libraries/gettext/default.nix
index 1dae2c443c8..c26afe1014b 100644
--- a/pkgs/development/libraries/gettext/default.nix
+++ b/pkgs/development/libraries/gettext/default.nix
@@ -1,4 +1,4 @@
-{ stdenv, lib, fetchurl, libiconv, xz, bison, automake115x, autoconf }:
+{ stdenv, lib, fetchurl, libiconv, xz, bison, byacc, automake115x, autoconf }:

 stdenv.mkDerivation rec {
   name = "gettext-${version}";
@@ -47,7 +47,7 @@ stdenv.mkDerivation rec {
     sed -i -e "s/\(libgettextsrc_la_LDFLAGS = \)/\\1..\/gnulib-lib\/libxml_rpl.la /" gettext-tools/src/Makefile.in
   '';

-  nativeBuildInputs = [ xz xz.bin bison automake115x autoconf];
+  nativeBuildInputs = [ xz xz.bin byacc automake115x autoconf];
   # HACK, see #10874 (and 14664)
   buildInputs = stdenv.lib.optional (!stdenv.isLinux && !stdenv.hostPlatform.isCygwin) libiconv;

#59553 is a [possible] proper fix.


CS0111: Type 'Initial' already defines a member called 'Down' with the same parameter types

When I'm adding a migration and call them Initial like using the command Add-Migration Initial, I got the exception

CS0111: Type 'Initial' already defines a member called 'Down' with the same parameter typ es

when I try to write the changes to the Db using Update-Database. It seems that Initial is a .NET class. When I change the name to something other like InitialMigration, it works like expected. Maybe it would be a good idea to check if migration names apply to reversed keywords and then inform the developer or defuse the name like adding a Migration  suffix or some other word to avoid conflicts.

@DMWOO7 - I am not able to find Initial as .NET class. Can you tell us from where it is coming from?

EF Team Triage: Closing this issue as the requested additional details have not been provided and we have been unable to reproduce it.

There will be a Folder called Migrations in your API .Inside that you will get a 'Initial' class .It has been created by the command Add-Migration Initial


[Feature Request] Ability to set the zoom factor

I have a 1920x1080 monitor, and the text appear too small in the app. The global scaling is set to 130% but somehow this electron based app ignores the global scaling. The title bar and the tray menus show in correct size, but the actual todoist website itself is too small. Is there a way I could set and retain the zoom factor, using ctrl keys?
OS: Xubuntu 18.04 x64

Hm... I'll try to find why it doesn't scale. Thanks.

I also have this same problem. The text is much too small. I just wanted to ask if there is any progress on this?
Greets

hi @mickmattes
I didn't look into this issue for long time. I'll try to look at it in few days. I'll let you know about the progress on it

Wow, that's a fast reply! Thank you KryDos. Really good job you do here...

I also have this same problem. The text is much too small. I just wanted to ask if there is any progress on this?
Greets

@mickmattes as a temporary workaround you can change force-device-scale-factor value in the source code.
For example, 200% zoom:
app.commandLine.appendSwitch('force-device-scale-factor', 2);
After that build the app from source. For Ubuntu (or Debian) execute from project root:
./node_modules/.bin/electron-builder --linux deb

@mickmattes as a temporary workaround you can change force-device-scale-factor value in the source code.

@srntqn Great! This did the trick. With a factor of 2 it looks way too big though. But 1.5 looks great. Thanks for the hint. Maybe this should be part of the Readme, so everybody can set it to their own needs.
Thanks again!

hi guys,
that line to force device scale factor with value 1 was forcing the scale factor to 1 as you already found.
Today I removed it completely and it seems like the app now respects the monitor scale factor.
If you still need that option you can run the app with --high-dpi-support=1 --force-device-scale-factor=1 options (replace --force-device-scale-factor value with the one you need).
The app is NOT applying scale factor of a monitor "on the fly" unfortunately so you have to restart the app to see the changes.
Let me know is this solution is working for you. If not, I'll reopen the ticket.
The Latest Version is HERE

Where should I put these command line switches? I'm starting the app with npm start from the src folder.

hi @mickmattes
You cannot add those options to npm start command because npm start just executes a string defined in package.json.
You have two options:

Edit package.json (which is in src folder).

Find scripts -> start section
Replace electron . with electron . --high-dpi-support=1 --force-device-scale-factor=2

Another option is to use ./node_modules/.bin/electron . --high-dpi-support=1 --force-device-scale-factor=2 command instead of npm start
Could you please provide me with more info about this issue? The scaling should be automatic based on the scale factor of your monitor. As it described in my comment above the app cannot scale " on the fly" (when you move the app's window from one monitor to another) but it should work if you start the app from the monitor with bigger scale factor.

The issue is, that I'm using i3 window manager on a quite high resolution, because I need the screen space of my laptop. This forces applications that "auto-scale" to have small text. In most of the applications I use, I can scale them via CTRL-+ or so. If I use Todoist on this laptop, reading the tasks in Todoist is a real pita. Hopefully I could make my problem clear :-)
Thanks for you good work KryDos!

Maybe there is a way to make the app, so it respects "Ctrl +" shortcut to control zoom level as some other electron apps do like Spotify, VS Code, etc?

I also use i3 and have the mentioned problem. Starting it using the mentioned command (in my i3-autostart script) did the trick for me. Thanks!
StartProg todoist --high-dpi-support=1 --force-device-scale-factor=1.5


the hide terminal is not closed actually

Steps to reproduce
:let termbuf = term_start("NONE", {"term_name":"test", "hidden":1, "out_cb": function("g:Xxxxx")})
:let tty = job_info(term_getjob(g:commbuf))['tty_out']
:ls!
:execute("bw " .. termbuf)
:ls!

for line 1: we start a term, and hide them
for line2 : we can see the terminal is in directory "/dev/pts/???"
for line 3: we can see the termbuf in buffers
for line4: we close this buffer
for line5: we can see that the termbuf is closed
buf actually, we can see that the tty of this terminal is still exists. this terminal is not stopped actually. "out_cb" is import for this problem, if there is no "out_cb", the terminal can closed correctly.
Expected behaviour
i hope that ,when the buffer is wiped, ther terminal of this buffer is closed, and the tty is alos disappear.
but it is not, for Plug  "termdebug", when i start for many times, i will get many ttys in  directory "/dev/pts/"
Version of Vim
VIM - Vi IMproved 9.0
Environment
ubuntu 22.04.2
gnome-terminal: # GNOME Terminal 3.44.0 using VTE 0.68.0 +BIDI +GNUTLS +ICU +SYSTEMD
$TERM : xterm-256color
Logs and stack traces
No response

This is not a bug. This is the default behaviour different from one you expect.
If you want terminal process to be killed after Vim's window closed you have to pass an argument to do so. See help for terminal command or term_start() function.

closing then.


Call a smart contract

Hi! I'm exploring the Polkadot/Substrate ecosystem and want to create a dApp that calls a SmartContract.
I found this library to easily connect with one of the browser extensions, but now I want to call a smart contract after the user has connected.
Is that possible? Can it be implemented once and work with all browser extensions?
Do you have any tips for me on where to start?

Sorry @michielpost about late reply!
You also can use signer with smart contract call. Here is example code:
const contract = await new ContractPromise(api, abi, address);
const address = '...' // Account address
const wallet = getWalletBySource('subwallet-js') as BaseDotsamaWallet;
if (wallet) {
  await wallet.enable()
  const signer = wallet.signer;
  if (signer && signer.signRaw && signer.signPayload) {
    await contract.tx
      .doSomething({ /* Smart contract method input go here */ })
      .signAndSend(
        address,
        { signer },
        async ({ status, dispatchError }) => {
          // Handle status callback here
        }
      );
    //Run something after fisish
  }
}

Thanks.
I was able to modify the Sign Dummy sample and then use the contract.tx... with the injected signer. That worked.
What would really help me (as a non react dev) is to have a vanilla-js sample. To really show what this project can do. Now it's very much intertwined with React. So using this without React is a bit complex.

I plan to separate wallet connect into a npm module that can use from any js code run on browser.
If also can read main concept of connect to Dotsama wallet in this article to do it yourseft. It will help interact with extension and other object like signer to use in yout code.


Error: ElegantCalendar.xcassets doesn't exist

I imported library by using Swift packages. After add ElegantCalendarView to view's body, I received fatalError at Image+Custom.swift file at line 9. I found that "uturn.left" image is already existed in ElegantCalendar.xcassets. please tell me how can I fix this?

You need to do this:
"Installation" in Readme.
Inside whatever app is using ElegantCalendar or your Swift Package that uses ElegantCalendar as a dependency:
Scroll the project navigator down to the Swift Package Dependencies section. Inside ElegantCalendar, you'll see a directory called ElegantCalendar.xcassets.
After you've located it, open your project's settings and navigate to your target's build phases in a parallel window.
Drag ElegantCalendar.xcassets into your target's Copy Bundle Resources. Make sure that Copy items if needed is unticked and Create groups is ticked. This step is crucial because ElegantCalendar uses custom icons, which SPM will support in Swift 5.3.
This last step is for making sure that when others clone your repository, the assets will be available to them as well. Click the ElegantCalendar.xcassets that has appeared in your project navigator and in the inspector on the right, select Identity and Type. Inside, make sure that Location is set to Relative to Build Products.

@thrustToga thank you very much, It solved my problem


Manual v1 release

Merge / deployment checklist

[ ] Confirm this change is backwards compatible with existing workflows.
[ ] Confirm the readme has been updated if necessary.
[ ] Confirm the changelog has been updated if necessary.

Update dependencies not running as the nwo guard is still in the releases/v1 branch.


Not a good idea to hardcode server port

Reminder

[X] I have read the README and searched the existing issues.

Reproduction

Not a good idea to hardcode server port like this. This disables gradio's capability of auto assigning a port, or checking env var.
Expected behavior
No response
System Info
No response
Others
No response

Solved, thanks for pointing it out.


Update EFCore.Analyzer

Two concerns:

Can we update Microsoft.CodeAnalysis.CSharp.Workspaces? Will this break compatibility with certain SDK/VS versions? How high can we go? (EF Core 3 requires at least VS 16.3 or the 3.0 SDK)
Newer packages will require us to change from .NET Standard 1.3 to 2.0. This isn't actually breaking, is it?

Compiler warnings as errors on the newest version:
InternalUsageDiagnosticAnalyzer.cs(40,57): error RS1025: Configure generated code analysis
InternalUsageDiagnosticAnalyzer.cs(57,28): error RS1024: Compare symbols correctly
InternalUsageDiagnosticAnalyzer.cs(82,28): error RS1024: Compare symbols correctly
InternalUsageDiagnosticAnalyzer.cs(106,28): error RS1024: Compare symbols correctly


chore: renamed webhooks to be specific to api group

Issue #, if available:
Description of changes:

make apply && TEST_FILTER=TestIntegration make e2etests

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 5 (0.0%)  changed or added relevant lines in 1 file are covered.
7 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.1%) to 73.356%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

pkg/webhooks/webhooks.go
0
5
0.0%

Files with Coverage Reduction
New Missed Lines
%

pkg/controllers/provisioning/scheduling/preferences.go
7
86.96%

Totals

Change from base Build<PHONE_NUMBER>:
-0.1%

Covered Lines:
4741

Relevant Lines:
6463

💛  - Coveralls


add different og:image  for any page in dir docs

Hi
i want add custom og:image in any file.md in dir docs
how can i do it ..?

Not possible ATM. Please use the right issue template to file new feature


Fix reference to the retired dev schema url

ebi-ait/hca-ebi-wrangler-central#215

Thanks @rays22 ! I'll merge this now and try releasing a new version to PyPI.

Thanks @rays22 ! I'll merge this now and try releasing a new version to PyPI.


Create a drop-shadow shader or widget (e.g. for text)

Added temp shadows with 1eab149607713800e5ff5bf082d9e0b3217b3013


[BUG] - peculiar defaults for MEGA-editing with non-GABA targets

For MEGA editing scenarios with non-GABA targets, the user interface forces a default MM3co model of 3to2MM, which is probably not meaningful in those scenarios but cannot be changed from the user interface.
To Reproduce
Steps to reproduce the behavior:

Create Job (interactive jobfile generator)
Sequence Type MEGA, Editing Target GSH
MM3co model cannot be changed from 3to2MM
OspreyFit subsequently fails if MM09 is not in the basis set, due to corresponding check in osp_addDiffMMPeaks

Expected behavior
"none" may be a more appropriate default for non-GABA editing targets? Perhaps osp_addDiffMMPeaks should not be called at all in such a scenario?
Suggested Fix
CreateOspreyJob_app.m around line 521, add
app.MM3coDropDown.Value = 'none';

Relatedly...
Whilst looking into this issue, I noticed that the included metabolites for LCModel fitting are probably unsuitable for use with a Lactate editing target: osp_fitInitialise.m line 354

Hi @alexcraven,
thank you for reporting this. I'll take a look.
About the LCModel MEGA-PRESS wrapper. It is currently meant for GABA-edited MP but could be easily changed according to the target metabolite.
Helge

Hi @alexcraven,
GUI job creator is fixed here (#724).
And I have also changed fitInitialise to assume GABA-editing as a special case of editing. For any other target metabolites, the full basis set is included, and the co-edited MMs are not added to the model. Should also be straight forward now to add a special case for GSH-editing if needed (#725).
Helge

Great; thanks! #724 looks fine in my testing.


Bug 2175979: Change Cores to CPUs in InstanceTypes pages

📝 Description
Change 'Cores' to 'CPUs' in InstanceTypes pages.
🎥 Screenshots

/retest

/lgtm


Written use-porter-in-bgp-mode-en.

Signed-off-by: Patrick-LuoYu<EMAIL_ADDRESS>/assign @FeynmanZhou @duanjiong @zheng1

"Compare to MetalLB" will be moved to the Porter blog subsequently.

/approve

/lgtm


Toggle between satellite and earth view

Function that can toggle between satellite-centric and earth-centric
How to toggle? (Command + info in tab, toggle under settings, icons below header?)

Suggestion: Toggle view button/Earth+Satellite icons + info about it in how-to tab+ command


Right Flow of messages

the new messages now get added to the bottom, like a normal chat

Clear 💪 💪
Legit stuff only 🤝🤝
Lemme merge and test


Not working with other app extension

I created a project where i used an app extension called @dreamonkey/animate that you can find here  https://github.com/dreamonkey/quasar-app-extension-animate.git.
Later when applying SSG AE this error will show up:
  SyntaxError: Cannot use import statement outside a module
...
 Extension(ssg) · ⚠  SyntaxError: Cannot use import statement outside a module

I think the problem is relative to webpack that can't transpile the dependency of the other app extension.
repro
https://github.com/vandelpavel/app-esxtension-test.git
You can try to launch quasar dev and scrolling the page will activate the animations.
But when you try to launch quasar ssg build it will throw that error.

@vandelpavel What happens if you do this:
quasar build -m ssr

With quasar build -m ssr it works.
I also tried quasar build -m ssr --static wich is the one in the read-me and it's no long working.

@vandelpavel, @hawkeye64
I tried to run quasar build -m ssr and the build complete fine.
But if you start the standalone webserver with node index.js inside the previously generated folder dist/ssr you've got the same error than with quasar ssg build.
So i added the dependency for transpiling with babel, then there is no more error and the animations works great.
transpileDependencies: [/@dreamonkey[\\/]quasar-app-extension-animate/]

Ok cool now it works thanks!
But before closing the issue i would like to ask another quesion. That was just a reoro case so when i added the line on the original project the console throws 'Extension(ssg) · ⚠  ReferenceError: window is not defined'
I think thaqt the problem may be the same that on server/side window can not be used.. But i cant find where is used.
I'm inesperienced so any help or a hint on what i should do to find a solution would be very helpfull!

@vandelpavel could you give us more details ?
What is a "reoro case" ?

when i added the line on the original project

Which line are you talking about ?
You are right about window it's a browser-only global that you cannot access from server-side.
The stack trace of the error could help a lot.

Sorry i ment "repro case", the github repository to reproduce the error.
The line that you supplied:
transpileDependencies: [/@dreamonkey[\\/]quasar-app-extension-animate/]
The problem is that it doesn't really give an actual stack trace.... Here is the log:
...
 App · Extension(ssg): Running afterBuild hook...
 Extension(ssg) · Generating route /...
[  ReferenceError: window is not defined

  - 1.92e8cf77.js:1 L
    js/1.92e8cf77.js:1:11858

  - 1.92e8cf77.js:1 r
    js/1.92e8cf77.js:1:11620

  - 1.92e8cf77.js:1 Module.eea6
    js/1.92e8cf77.js:1:58898

  - server-bundle.js:1 n
    server-bundle.js:1:194

  - task_queues.js:97 processTicksAndRejections
    internal/process/task_queues.js:97:5

]
 Extension(ssg) · ⚠  ReferenceError: window is not defined

I can't reproduce it with the repository you gave.
Try to run quasar build -m ssr --static --debug

I was trying to modify the previeus repro but unfortunally when creating other pages it keeps saying "404 on /" when changing the path.
It works just if the path doesn't have a layout like so:
    path: '/',
    component: () => import('layouts/MainLayout.vue'),
    children: [{ path: '', component: () => import('pages/Index.vue') }]
  },
  {
    path: '/p',
    component: () => import('layouts/MainLayout.vue'),
    children: [{ path: '', component: () => import('pages/Page-two.vue') }]
  },```

But assume that we have something like:

...
path: '/',
component: () => import('layouts/frame.vue'),
children: [
{ path: '', component: () => import('pages/home.vue') },
...

I just realized that on the repo works but not on the project. I don't know why.... I just deleted node modules, quasar folder

I think that you missed an uppercase.
layouts/frame.vue doesn't exist.
Does layouts/Frame.vue exists ?
If you can't find where the global window is used in your project files, maybe it is coming from some dependencies you are importing. Try to import them only at client side.
With Quasar you can use process.env.SERVER or process.env.CLIENT in your Vue components.
If you are using boot files it's even easier. Quote from Quasar docs :

When building a SSR app, you may want some boot files to run only on the server or only on the client, in which case you can do so like below:

boot: [
 {
   server: false, // run on client-side only!
   path: '<name>' // references /src/boot/<name>.js
 },
 {
   client: false, // run on server-side only!
   path: '<name>' // references /src/boot/<name>.js
 }
]

You could also try to debug errors by putting the parameter debug to your Quasar command.
quasar build -m ssr --static --debug

No uppercase error, they are reported on log fortunally.
Actually now the problem as i said "I was trying to modify the previeus repro but unfortunally when creating other pages it keeps saying "404 on /" when changing the path." (probably i wasn't clear sorry) the problem is the routing.

I'll close this issue and open another one.

By the way i found why it was saying that window was not defined.
I discovered that window was used inside a mixin (As you said)
If you can't find where the global window is used in your project files, maybe it is coming from some dependencies you are importing. Try to import them only at client side.


Update aws-init.sh

*More detailed description of your change,
this bucket was migrated
*Summary of testing strategy (including rationale)
the url is accessible
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

@soondenana I can't merge it


How to use c# to upload pictures?

How to use c# to upload pictures?

Hi there! If you could provide some additional context on which documentation you believe requires this update and why, we will be better able to address your comments. Thanks!

I'm going to close this issue now, but feel free to open a new issue or ask any questions.


Data analysis repo not found

I'm getting a 404 error for https://github.com/xomicsdatascience/RnaToProteinDataModule. Is it still a private repo?

Yes it was, thank you for catching that! You should be able to access it now. I'm going to close this issue, feel free to open it up if you still have trouble accessing it.


Changing color highlighted in between dates on DateRangePicker

I tried using the Google chrome inspect tool but can't seem to replicate what is triggering it to scoll over to find out the class name.

you cannot change the color and themes through CSS class selectors,
you need to override the variables with your own variables
also you can find the variables , styles from this address:
"~react-dates/css/variables.scss", "~react-dates/css/styles.scss"

Try overriding .CalendarDay__hovered_span class


In example, directory projects/SolarS_HD163296/images is already filled

In the example project: SolarS_HD163296.tar.gz, the directory projects/SolarS_HD163296/images is already filled.  This might be helpful, but it's not written anywhere in the example about whether the images can be overwritten.  Maybe just a few words for clarity will help.
https://github.com/openjournals/joss-reviews/issues/4942

I have included a note mentioning that the product images are already contained in the project folder that can be downloaded for the tutorial. I also clarified that running SIMIO will overwrite any existing image in the project.


Regression test for #19328

Since it seems to already be fixed. As an added bonus, this allows the extract function/symbol tests to test multi-file programs.

Correction: This is does not repro in the test harness but is still not fixed in a real editor! @amcasey any idea on how the extract function unit test environment differs from a real editing scenario for this usecase?

As I suggested offline, it would probably be easier to add a fourslash test than to revise all of the test infrastructure.

Correction: This is does not repro in the test harness but is still not fixed in a real editor! @amcasey any idea on how the extract function unit test environment differs from a real editing scenario for this usecase?

Correction to the correction! The unit tests shows as fixed because it is fixed! I was loading the wrong LS when I tested in-editor. This was fixed by https://github.com/Microsoft/TypeScript/pull/19578


Add Chris Ball to Contributors list

@Balldy, I'm quite elated about your PR. I wanna evolve this project to addresses various problems faced by first time contributors. I'd love to learn about your journey in open source community, the problems, pain points you had etc.
Could you explain how you felt when you went through the tutorial, made a PR and learned that I accepted it?

Hi @Roshanjossey , Thanks for this project, it was a nice introduction to contributing to open source, very easy to follow. I'm just trying to get used to pull requests and forking projects etc.  I'm  gonna start looking for projects I feel I can contribute to.

@Balldy, I'm happy that this helped you.
We also have a slack team to mentor / help people trying to contribute to open source.
You can join the team by going to https://firstcontributions.herokuapp.com


[backport] Fix caffe test with protobuf>=3.8

Backport of #8190

[automatic post] Jenkins, test this please.

Jenkins CI test (for commit d1695cd25a58a7080caa65c81050155753a94da8, target branch v6) failed with status FAILURE.

Jenkins, test this please.

Jenkins CI test (for commit d1695cd25a58a7080caa65c81050155753a94da8, target branch v6) succeeded!


Get-LibreOffice fails

Describe the bug
Get-LibreOffice returns:
Exception calling ".ctor" with "1" argument(s): "Version string portion was too short or too long.
Parameter name: input"
At /Users/aaron/Projects/Evergreen/Evergreen/Public/Get-LibreOffice.ps1:56 char:41
+ ...      $version = [version]::new($($verblock | Select-Object -First 1))
+                                      ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+ CategoryInfo          : NotSpecified: (:) [], MethodInvocationException
+ FullyQualifiedErrorId : ArgumentException

Aaron, I tested with Master branch, not seeing it, getting consistent URL output.

Works on Windows PowerShell but fails on PowerShell Core

Fixed in commit: 4c45344384a6a502e19aecbec8702ddb35a462c7


Layout issue on Retina Display: navbar

It seems the issue #171 is not completely solved. There is screenshot from my retina display:

On my screen, this rule applies:
@media screen and (max-width: 600px),
screen and (-webkit-min-device-pixel-ratio: 2) {
    #nav_main > ul > li {
        width: 25%;
    }
}

Change the width to 50% solve the problem, but I'm not sure this approach is correct for other types of screens.

Just tested, looks great!

:+1:


fix(composable): use #app instead of #imports to avoid circular reference

While composables.ts are registered for auto import, it references #imports which contains all auto imports, making it circular.
After https://github.com/unjs/unimport/pull/85 it might be resolved, but I think it's still better to be explicit and avoid this usage from the beginning.

I would vote against doing this. Introducing two import sources was ba k decision. We shall move #app to an internal namespace before nuxt3 stable release and only use #imports as source of trust.


fix(nodebuilder/header): Cancel subscription when done

Found while debugging swamp.
We never cancel subscription so when node attempts to shut down, there are outstanding subs that need to be closed.

🤠

Codecov Report

Merging #2134 (cb85adb) into main (e39dfab) will decrease coverage by 0.10%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #2134      +/-   ##
==========================================
- Coverage   55.47%   55.37%   -0.10%
==========================================
  Files         209      211       +2
  Lines       13329    13526     +197
==========================================
+ Hits         7394     7490      +96
- Misses       5189     5276      +87
- Partials      746      760      +14

Impacted Files
Coverage Δ

nodebuilder/header/service.go
18.18% <0.00%> (-0.87%)
:arrow_down:

... and 12 files with indirect coverage changes


Huge JS bundle size optimization! 🎉

Huge JS bundle size optimization! 🎉

Path
BEFORE ( JS size )
AFTER ( JS size )
JS Reduction %

/
927 kB
344 kB
-62%

/dashboards
896 kB
314 kB
-65%

/deploy
896 kB
314 kB
-65%

/sdk
906 kB
324 kB
-64%

/ui-components
896 kB
314 kB
-65%

/404
878 kB
296 kB
-66%

/about
896 kB
314 kB
-65%

/auth
905 kB
323 kB
-64%

/network/solana
899 kB
317 kB
-65%

/release
897 kB
315 kB
-65%

/smart-contracts
896 kB
314 kB
-65%

/solutions/commerce
904 kB
322 kB
-64%

/solutions/gaming
915 kB
333 kB
-64%

/storage
895 kB
313 kB
-65%

/hackathon/solanathon
898 kB
316 kB
-65%

/_og/profile
882 kB
314 kB
-64%

What was the issue?

The Tree shaking does not work properly when AddressCopyButton is involved in the import/export

The root cause of the issue is the function shortenIfAddress used in it - when importing that function it adds a TON of web3 dependencies

Code Change

Minimal Code Change - just moved AddressCopyButton to a new file and removed its export from tw-components/index.ts to keep it separate from other exports
With this change, Any page that does not use AddressCopyButton sees a dramatic improvement in JS bundle size

Further Improvements for AddressCopyButton

If we can write a custom implementation of shortenIfAddress - that would improve the bundle sizes on pages where AddressCopyButton is used as well

🎉🎉🎉


Eliminate useless ports

This adds a pass which prunes disconnected input and output ports. These were causing us problems with achieving coverage.
Please pay special attention and review the DeadCodeElimination changes. This PR makes the dead code elimination significantly more aggressive, which may have corner cases I didn't exercise in Rocket.

@jackkoenig Are you the correct person to point at this pass?

Hmm. I see there are unit tests which don't use their ports, but depend on the result having exactly the specified ports. I could resolve these by inserting a body that makes the ports actually used. Or this port removal pass could be made into a command-line option. What's best?

I think aggressive dce and port elimination should be an optional feature. Often, new users of Chisel/Firrtl get extremely confused when they end up with an empty module.
To do this, follow the example of InlineInstances (e.g. extend Transform, not Pass). Ideally, I'd like to see the following annotations:

Turn on the pass (like InlineInstancesAnnotation)
Preserve a wire/port/node/etc. <- this allows future transforms, libraries, etc. to run your pass, even if they have an unused port they want to hook up later.

In order for the PR to be accepted, you'll need to write multiple tests in src/test/scala/firrtlTests, as well as write some more comments in your transform explaining the major functions.

@azidar idk how long it'll take to approve this PR.

It'd be useful for me since who knows when RawModule will ever be merged into chisel.
Even if I don't get something that eliminates unconnected ports, it'd be useful at least to see which ports are actually unconnected...

@terpstra @shunshou I'll go ahead and take care of this PR.

Superceded by #549


Allow users to specify defaults

This PR attempts to fix #2 by adding a setup function, the same pattern as other plugins are using, like telescope, octo.nvim, among others.
I couldn't find a better example for "Per-call" configuration in the README file, so I'll be happy to update it if you have a better use case!
I was wondering also if adding a sample snippet on how to configure it with packer or other plugin managers will be useful, i.e:
use {
  "kosayoda/nvim-lightbulb",
  config = function()
    require'nvim-lightbulb'.setup({
      ignore = {"null-ls"},
    })

    vim.cmd [[autocmd CursorHold,CursorHoldI * lua require'nvim-lightbulb'.update_lightbulb()]]
  end,
}

Thank you!

Thanks for the PR!

I couldn't find a better example for "Per-call" configuration in the README file

The one you have looks good to me.

I was wondering also if adding a sample snippet on how to configure it with packer or other plugin managers will be useful

I was lukewarm on the idea when it was just had per-call configuration, but now with two different ways to configure the handler, it might be a good idea. I'd be happy to accept a PR adding such a snippet.


Unnumbered chapters

Prefaces, introductions, and other appendices don't really have chapter numbers, at least by convention.

Oh! I already built this. Chapters can declare "numbered: false" to avoid being numbered.


Configurable mortality and aging in an AgentTypeMonteCarloSimulator

AgentTypeMonteCarloSimulation current has some hard-coded logic about mortality and birth.
https://github.com/econ-ark/HARK/blob/master/HARK/simulation/monte_carlo.py#L350-L394
One of the recent language research outcomes (RLRO) was a proposal for how mortality/birth/aging information can be encoded as a 'block'.
https://github.com/econ-ark/OverARK/blob/master/Development/hablo/perfect_foresight_full_experimental.yaml#L36-L57
How to properly include aging and mortality in a general, configurable way is currently an unsolved issue for the software design, let alone the language design. This is partly because agent aging also involves indexing into time-dependent parameter values.
This issue is for exploring and implementing the HARK 1.0 version of generalized aging, birth, and mortality, and its interaction with the parameterization logic.
See #1371 for terminology.

Notes from today's meeting with @mnwhite and @alanlujan91 on this:

consider breaking up the information between model definition and simulation specification.
generalized aging: stochastic aging (transitions between life phases, rather than incrementing deterministically)
how to have age-varying parameters without references to age inside the 'hermetic' blocks?
maybe this information goes in the 'links' section, since this can do things like:

'twist' variables (maybe age-indexing happens here also)
direct block flow to a terminal state upon death.


Features list from viewport

Create a method to retrieve the list of features present in the viewport.

hey, just realized the PR has been merged. Is this something we can already use?

thanks!!!

I test it with /sources/MVT.html example and It doesn't work.

For other types of sources works well

What version/revision are you using?

It's a known issue: we cannot use viewportFeatures, viewportAggregation or some interactivity features with MVTs unless they have a cartodb_id property: https://github.com/CartoDB/carto-vl/issues/652

Is there any possibility to tell viewportFeatures to return all the properties? In Mastercard we need to get around 400 properties per feature.

@rochoa master branch

@jgoizueta is a possible workaround to include a cartodb_id in the external datasource?

Hey, as I've commented in https://github.com/CartoDB/carto-vl/issues/652#issuecomment-402754718 viewport functions should work in the current master, albeit with a bug (that was already there) and that can make features duplicated in the viewport aggregations and features list (if they appear in multiple tiles).
@alasarr: right now it makes no difference if you include a cartodb_id, because of the bug we have. As soon as we fix it we'll add support for having a cartodb_id in the MVT, so adding at the external source will be the right solution to avoid duplicated features

Hey, I just commented the problematic code on master since it not only produces that crash with MVT sources, but it is buggy in general (it doesn't avoid repeating duplicated features on viewport aggregations when the features are in multiple tiles due to clipping).
With these lines commented you should be able to work, even though the duplication issue is still there. We'll work on that (https://github.com/CartoDB/carto-vl/issues/588), and on being able to pass or generate ids to MVT sources (https://github.com/CartoDB/carto-vl/issues/652).

@alasarr  regarding having all the 400 properties in viewportFeatures, right now you must explicitly pass all of them to the expression (you could use the JS API, and get the properties in a list programatically => const list = s.viewportFeatures(...list);.
We'll discuss later how to simplify this.

Commented this lines
if (processedFeaturesIDs.has(dataframe.properties.cartodb_id[i])) {                     continue;                 }
I can use viewportFeatures function in MVT source but with 600 properties It's not posible to move or zoom map and I don't know the consequences to comment this lines.

Yes, that's what I commented on master, it was supposed to fix issue #588
We've reproduced the performance problem with many properties and viewportFeatures and we are working on it.

Hi @jgoizueta we've test it and it works, we can get the 400 properties back. However, the performance is not good:
https://gist.github.com/padawannn/f721d9ac681a63636824bf8b4ff03aa5

I've updated my local master branch and viewportFeatures function works with MVT source like @davidmanzanares and @jgoizueta said so we are not blocked while you solve bugs

In our tests everything is working perfect with the latest changes

Vamos!! 💪
Thank you very much for the super fast/useful help!


Bone targeting does not work as expected

For some reason, all of the options merge and are visible on bones that shouldn't even have an option. Not sure if I'm using the export wrong or what is going on.
This my sample code for targeting engine and a rear right wheel

Next, when in-game I see this:
Targeting engine

Targeting rear right wheel

Targeting front right wheel (this shouldn't even have options)

Am I doing something wrong or is this a bug?

https://github.com/overextended/ox_target/commit/91ef33b3d6b2973015f4edccb2aad9a62feff231
https://github.com/overextended/ox_target/commit/18bfa9e6e24c701950750f6ee6f9e39068fa4509


Support N5120 (LTE version)?

Support N5120 (LTE version)?

Sorry,I send the message in the wrong place.


#1739 fix usage of setScale

Delivers #1739
Fix a bug in the usage of setScale where it wasn't being applied

LGTM


Cloud shadows not fully masked for Landsat

Describe the bug
The cloud / cloud shadow mask for L89 SR does not fully capture the cloud shadows.
To Reproduce
Steps to reproduce the behavior:

Go to 'users/wulf/koreg-shadow/Deliverables/Landsat/L89_sr_singleDay_v01'
end_date '2023-07-11'
ROI around '46.69093, 7.23313'
Comparison of the layers 'L89 original' and 'L89 export'

Expected behavior
A mask containing all of the cloud shadows.
Screenshots

Additional context
The same problem occurs for the 'users/wulf/koreg-shadow/Deliverables/Landsat/L57_sr_singleDay_v01' script with the end date '2002-07-09' for the same region and layers.

Hi Joan. Happy new year!
Just to clarify, you are puzzled that the mask does not contain all the cloud shadows visible in the image, right? Most cloud shadows are captured by the mask.
With Landsat I relied on fmask, which already contains a cloud shadow mask (as for the clouds). This is a different route as with S2, where we used the dark pixel approach and shadow direction projection.
Are you saying the Fmask cloud shadow detection is not good enough?

Yes, that's exactely what I meant. Is it feasible to use dark pixels and shadow direction projection for Landsat too? The remaining shadows are quite prominent and I prefer higher omission errors to commission errors.

Yes, implementing that should be feasible.

Done

15.01.2024:

shoudl be ready
we mask more pixel
Same approach as with S2, quite strict


In multihead_attention module (modules.py),

I think that a linear projection layer after concatenation outputs of scaled_dot_product (line 190 / modules.py) is missed.
check paper Figure 2. (Attention is all you need).

You are right. How would one fix that?
outputs = tf.layers.dense(outputs, d_model, use_bias=False)
after line 194?


⚠ Bofrost.es has degraded performance

In 122b22e, Bofrost.es (https://www.bofrost.es) experienced degraded performance:

HTTP code: 200
Response time: 1584 ms

Resolved: Bofrost.es performance has improved in c9c3846 after 10 minutes.


chore: main back to alpha

:tada: This PR is included in version 1.11.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Empty response (async issue?)

Run the script/run.sh
Then, using many from many-rs, run
$ many message --pem ~/Identities/id1.pem --server http://<IP_ADDRESS>:8000 "ledger.send" "{1: 10000_1(h'0184d149a2095851d4994b0a812b9f7d8c42a5acf644031e9f2949b76e'), 2: 10000, 3: 10000_1(h'804a101d521d810211a0c6346ba89bd1cc1f821c03b969ff9d5c8b2f59000001')}"
May 10 17:15:07.668 ERROR many: Empty response:
ResponseMessage {
    version: None,
    from: Identity(
        "public-key",
        "maffbahksdwaqeenayy2gxke32hgb7aq4ao4wt745lsfs6wijp",
    ),
    to: Some(
        Identity(
            "public-key",
            "maffbahksdwaqeenayy2gxke32hgb7aq4ao4wt745lsfs6wijp",
        ),
    ),
    data: Ok(
        [],
    ),
    timestamp: Some(
        SystemTime {
            tv_sec:<PHONE_NUMBER>,
            tv_nsec: 0,
        },
    ),
    id: None,
    attributes: AttributeSet(
        {
            Attribute {
                id: 1,
                arguments: [
                    b"b0effd8bd20b62438e02f4269f129624c97eb5fcfc221ae30959afc273310dd0",
                ],
            },
        },
    ),
}

We just never implemented the waiting feature in many-cli itself. I added it to the PR which will close this.


ignore gradle wrapper

Reasons for making this change:
I don't want to commit an external build tool in my project.
Links to documentation supporting these rule changes:
Gradle Wrapper files: https://docs.gradle.org/current/userguide/gradle_wrapper.html#using_wrapper_scripts
Gradle Wrapper can be ignored completely, however, to ensure that the correct Gradle version is used to build a project, Gradle version can be set in build.gradle file.
http://stackoverflow.com/a/28473686
For Android Studio, Gradle version is set in build.gradle by default
https://developer.android.com/studio/releases/gradle-plugin.html

Nope definitly not...
The Gradle documentation states: "All of these files should be submitted to your version control system."
And this is the way, gradle is usually used...
If you decide to use it in another way, you can simply modify your local .gitignore file. But by default, the gradle wrapper should not be ignored.


[Issue-23363] buf2hexstr_sep ebcdic2ascii translation off by 1

Issue:
buf2hexstr_sep() function was updated in OpenSSL 3.0 so that the buffer q points to the last character in the buffer buf. Because of this change, the calculation for ebcdic2ascii is off by 1. q - str - 1 is 1 less than the length of buf, which results in all characters but the last to be translated in buf.
Solution:
changing to ebcdic2ascii(str, str, q - str);
#23363

Checklist

[ ] documentation is added or updated
[ ] tests are added or updated

Next time, please use Fixes #23363 on a separate line in the commit message body instead of mentioning it in the subject line.

Next time, please use Fixes #23363 on a separate line in the commit message body instead of mentioning it in the subject line.

Sure, Thanks!

This pull request is ready for merging. @t8m, could you please proceed with the merge?

@shahsb no, not really. It needs a second approval. PRs are merged when they have approval: ready to merge label.

@t8m - This PR is pending from long time. How to request approval from core team?

I'm closing this as it's a duplicate of #23404. Apologies for not noticing sooner


Refactor tests to use accelerate launch

Refactor tests to use accelerate launch
What does this add?
This PR refactors all the example tests to use accelerate launch to be ran, adjusting any testing logic that needs to be done to compensate for this. Mostly changing the accelerate.print mocks to use string matching instead based on stdout from subprocess.run
Why is it needed?
In order to have our tests be ran on more than one GPU, the tests needed to be refactored to allow for the accelerate launch command to be used via subprocess rather than calling it in python directly.
What parts of the API does this impact?
User-facing:
All of the example scripts now contain a small snippet denoting that a particular import is only used for testing, and should be ignored
Internal structure:
mocked_dataloaders was migrated to the test utils.

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.


OSC manager crashes if launched when default port is bound by another program

I had another program running and occupying port 9001, and when attempting to launch the OSC manager it immediately crashes but the process is still running. I am unable to kill the zombie process through task manager as it does not show up in the list of running applications, but i can not relaunch the manager afterwards. needing powertoys to search for what is using the exe to kill it.

I just tried re-creating the issue in a Windows 10 VM, but was unable reproduce it. Looking at the log file, it does exit cleanly and when unblocking the port, I can just restart OSC manager.
Which Windows version are you running this on exactly, and could you post the log file contents? They should be somewhere in your AppData directory in your home directory, unter Roaming/vrc-osc-manger.

Also, does powertoys show you information about what is left behind?

I just retried in a Windows 11 VM, but could still not reproduce it. Which is the other program you are using?

Since there was no more update on this issue, and with OSC Query support it will always use a fresh port, I gonna close this issue for now.