withApollo example - move from old HOC APIs to new function-as-child APIs

Since version 2.1, react-apollo is exposing some new components that use the function-as-child (or render-prop) pattern to let you connect apollo-client magic with your components. See the blog article: New in React Apollo 2.1
If I'm not mistaken, it's generally agreed that this pattern is (where it works) superior to the HOC pattern, for reasons that are best explained here: https://cdb.reacttraining.com/use-a-render-prop-50de598f11ce
So I updated the with-apollo example to use the new API, and IMO this code is much simpler and natural to read and understand, especially if you are not already familiar with Apollo's HOC APIs.
I broke up my changes into separate commits, for easier review. Commits with "Refactor" in the message accomplish the goal of switching to the new APIs while minimizing line-by-line differences (select "Hide whitespace changes" under "Diff settings"). Commits with "Clean up" in the message follow up the refactoring with trivial things like reorganizing code sections, renaming variables, etc.
For the components doing mutations, I chose not to use the Mutation component, since that doesn't really make sense to me; a mutation is something that happens at a point in time, so it's not meaningful to represent a mutation in the markup, which exists for a period of time. All that component does is expose a mutate function for a single specified mutation, and result data for a single firing of the mutation (which we don't need anyways; apollo handles updating the local data with the result). To me it seems simpler and more flexible to just get the apollo client via ApolloConsumer and call .mutate() on it.
In case anyone is interested, here's what my version of PostUpvoter using the Mutation component looked like:

import React from 'react'
import { Mutation } from 'react-apollo'
import { gql } from 'apollo-boost'

export default function PostUpvoter ({ votes, id }) {
  return (
    <Mutation mutation={upvotePost}>
      {mutate => (
        <button onClick={() => upvote(id, votes + 1, mutate)}>
          {votes}
          <style jsx>{`
            button {
              background-color: transparent;
              border: 1px solid #e4e4e4;
              color: #000;
            }
            button:active {
              background-color: transparent;
            }
            button:before {
              align-self: center;
              border-color: transparent transparent #000000 transparent;
              border-style: solid;
              border-width: 0 4px 6px 4px;
              content: '';
              height: 0;
              margin-right: 5px;
              width: 0;
            }
          `}</style>
        </button>
      )}
    </Mutation>
  )
}

const upvotePost = gql`
  mutation updatePost($id: ID!, $votes: Int) {
    updatePost(id: $id, votes: $votes) {
      id
      __typename
      votes
    }
  }
`
function upvote (id, votes, mutate) {
  mutate({
    variables: { id, votes },
    optimisticResponse: {
      __typename: 'Mutation',
      updatePost: {
        __typename: 'Post',
        id,
        votes
      }
    }
  })
}

I'm happy with where things are at here, but I'm more than happy to address any comments, concerns, ideas for improvent!
Thanks!

A little more on why I used the ApolloConsumer component rather than Mutation:
It could give the impression that to do a mutation you have to use the Mutation component, and I could see some convoluted code being written to deal with the limitations of that component (mentioned above). Using ApolloConsumer will go a lot further, and it should be easy enough for anyone reading the documentation to discover that the Mutation component is another possibility.

@amytych @joaogarin I see from #5238 that you're working with this example now.. care to give any feedback?

@adamsoffer could you have a look 🙌

If this PR is approved I can follow up with the same updates to the other Apollo examples (with-apollo-auth, with-apollo-and-redux, with-apollo-and-redux-saga)

@timneutkens are we waiting for more reviews before merging?

Looks great 👍 Thanks for the PR 👌

Awesome! I'll follow up with the same changes to the other Apollo examples in a single PR.

I honestly don't like this approach at all.
It seemed cool at first, but when I actually tried it it only made my components harder to read and much less flexible.
You can for the most part avoid the complexity problem by breaking your components artificially into smaller ones, where otherwise it wouldn't even make much sense to do that, but then you end up with a ton of components, which brings the question of whether that is making things more manageable or not.
Imagine a component that needs both a query and a mutation (or two) and a subscription.
And then there're some HOCs you might still want to use (there're some really cool ones out there), even if you do adopt this pattern, so you'll have two different approaches living side by side.
So, as interesting as this idea might seem in theory, I personally would not recommend it to anyone, especially not on medium to large sized projects.
Just my two cents.

@thealjey I hear that. I imagine the apollo team is working hard on hooks support and I'm looking forward to updating this example when ready.


exceed stock in off-canvas cart has no infobox

Description:

customers can not see in off-canvas when limit is exceeded

Environment:

<IP_ADDRESS>

Steps to reproduce:

create product with clearance sale

Expected result:

same hint as with "add to cart" comes in off-canvas too

Actual result:

only "add to cart" from product detail page has a hint, that stock  is 0

[Screenshot%2B2024-08-05%2B142110.png|https://sbp-issuetracker-attachments.s3.eu-west-1.amazonaws.com/1722860633_66b0c459c6053_Screenshot%2B2024-08-05%2B142110.png]

[public] Shopware automated response: This issue is linked to the internal issue: NEXT-37533
[created from NEXT-37533, comment 514379]


github_token - alternatives to secrets.GITHUB_TOKEN

The README says about github_token
{{secrets.GITHUB_TOKEN}} will not work.

But it's not clear what is supposed to work. Is this meant to be a github personal access token, or what other alternatives are there ?
Do I need to consider writing custom code as in Issue #9 ?

You need to provide a GitHub PAT with greater permissions than the token GitHub provides for workflows. You can generate the token using these instructions - you'll need to provide the "admin: write" privilege.


Sentence

Can we add admin prefix in admin_menu_blade.php like this
$linkAttributes =  'href="' . url(config('voyager.prefix').'/'.$item->link()) .'"';
to prevent writing prefix(/admin) on every menu-item creation?
This solution will add admin prefix automatically on every menu-item.
Maybe only for admin menu and for Static URL!!!!
Of Course then external URL-s will not work, but do wee need external URL in admin panel?))))hmmmm
Or maybe create new Link type like External URL for that solution?

No, we want the Menu items to be as flexible as possible.  We recommend using dynamic links and using the route name (i.e. voyager.users.index) to get the prefix appended automatically.


At C2+, Hu Tao should apply blood blossoms with her burst while she's not in paramita

"active hutao;
hutao burst;
wait(1000)" does not apply her mark
"active hutao;
hutao skill, burst;
wait(1000)" applies the blossom as intended
Proof that she does in game: https://www.youtube.com/watch?v=uYOCgwXFpig

Thanks for creating this issue.
This is a rather simple fix, so feel free to submit a PR, where you go here:
https://github.com/genshinsim/gcsim/blob/489b5758af968026ab1772386d5096d4ee76ab13/internal/characters/hutao/burst.go#L49
and change it to:
if c.Base.Cons >= 2 {
    ...
}


fix backuptarget is empty

Summary
PR Checklist
~- Is this a multi-tenancy feature/bug?
- [ ] Yes, the relevant RBAC changes are at:~
~- Do we need to backport changes to the old Rancher UI, such as RKE1?
- [ ] Yes, the relevant PR is at:~
~- Are backend engineers aware of UI changes?
- [ ] Yes, the backend owner is:~
Fixes #

https://github.com/harvester/harvester/issues/4483

Occurred changes and/or fixed issues

Technical notes summary

Areas or cases that should be tested

Areas which could experience regressions

Screenshot/Video

@mergify backport release-harvester-v1.2


remove warnings generated during TS module tests

What does this PR change?
When building OpenCV latest master branch using the ENABLE_PROFILING and ENABLE_IMPL_DETAILS, the building process outputted a bunch of warnings related to int and unsigned int comparisons. These simple fixes remove those warnings and allow for a cleaner building process.

:+1:


with v1.1.1, simple metric visualization is not working.

Hi,
I'm using kibana 6.3.2 and i downloaded and installed the datasweet-formula v1.1.1.
When i tried to create a simple metric visualization it didn't work.
Only when i reverted to v1.1.0 the visualization worked as expected.
Any idea?
Regards

Hi @ttgile ,
Actually we are discussing with team about the change by @gmatheus for the version v6.4
I will take a look
Thx for your report.

Hi,
Many thanks for the fast response.
I just downloaded the new zip and now it seems that the kibana-plugin installation fails while doing the optimization:
Attempting to transfer from file:///opt/installation/kibana/kibana-datasweet-formula-1.1.2.zip
Transferring 12510190 bytes....................
Transfer complete
Retrieving metadata from plugin archive
Extracting plugin archive
Extraction complete
Optimizing and caching browser bundles...
Plugin installation was unsuccessful due to error "Command failed: /usr/share/kibana/node/bin/node /usr/share/kibana/src/cli --env.name=production --optimize.useBundleCache=false --server.autoListen=false --plugins.initialize=false --uiSettings.enabled=false
(node:6980) [DEP0022] DeprecationWarning: os.tmpDir() is deprecated. Use os.tmpdir() instead.
FATAL { Error: Optimizations failure.
6191 modules
ERROR in ./plugins/datasweet_formula/public/decorators/lib/formula_parser.js
Module not found: Error: Can't resolve 'expr-eval' in '/usr/share/kibana/plugins/datasweet_formula/public/decorators/lib'

ERROR in ./plugins/datasweet_formula/public/formulas/percentile.js
Module not found: Error: Can't resolve 'percentile' in '/usr/share/kibana/plugins/datasweet_formula/public/formulas'

at FsOptimizer.failedStatsToError (/usr/share/kibana/src/optimize/base_optimizer.js:245:27)
at compiler.run (/usr/share/kibana/src/optimize/fs_optimizer.js:28:26)
at onCompiled (/usr/share/kibana/node_modules/webpack/lib/Compiler.js:241:12)
at applyPluginsAsync.err (/usr/share/kibana/node_modules/webpack/lib/Compiler.js:514:14)
at next (/usr/share/kibana/node_modules/tapable/lib/Tapable.js:202:11)
at Compiler.<anonymous> (/usr/share/kibana/node_modules/webpack/lib/CachePlugin.js:78:5)
at Compiler.applyPluginsAsyncSeries (/usr/share/kibana/node_modules/tapable/lib/Tapable.js:206:13)
at compilation.seal.err (/usr/share/kibana/node_modules/webpack/lib/Compiler.js:511:11)
at Compilation.applyPluginsAsyncSeries (/usr/share/kibana/node_modules/tapable/lib/Tapable.js:195:46)
at self.applyPluginsAsync.err (/usr/share/kibana/node_modules/webpack/lib/Compilation.js:671:19)
at Compilation.applyPluginsAsyncSeries (/usr/share/kibana/node_modules/tapable/lib/Tapable.js:195:46)
at self.applyPluginsAsync.err (/usr/share/kibana/node_modules/webpack/lib/Compilation.js:662:11)
at next (/usr/share/kibana/node_modules/tapable/lib/Tapable.js:202:11)
at Compilation.<anonymous> (/usr/share/kibana/node_modules/uglifyjs-webpack-plugin/dist/index.js:244:6)
at next (/usr/share/kibana/node_modules/tapable/lib/Tapable.js:204:14)
at Compilation.compilation.plugin (/usr/share/kibana/node_modules/webpack/lib/BannerPlugin.js:67:5)
at Compilation.applyPluginsAsyncSeries (/usr/share/kibana/node_modules/tapable/lib/Tapable.js:206:13)
at self.applyPluginsAsync.err (/usr/share/kibana/node_modules/webpack/lib/Compilation.js:657:10)
at next (/usr/share/kibana/node_modules/tapable/lib/Tapable.js:202:11)
at Compilation.<anonymous> (/usr/share/kibana/node_modules/extract-text-webpack-plugin/dist/index.js:275:11)
at Compilation.applyPluginsAsyncSeries (/usr/share/kibana/node_modules/tapable/lib/Tapable.js:206:13)
at sealPart2 (/usr/share/kibana/node_modules/webpack/lib/Compilation.js:653:9)

cause:
{ Error: Optimizations failure.
6191 modules
Regards

Hi,
Please notice that since i got the above error, i'm still using v1.1.0.
We found another issue with this release: it appears that Min/Max aggregations are breaking the visualization when there is no data according to the time filter.
Regards

Hi @ttgile ,
could you please give us a screenshot. Are you talking about Kibana's built in Min/Max aggs ?

Hi,
Sorry for missing the example,
It appears that the issue occurs when the datasweet formula is part of the visualization.
In the below example, you can see that i create metriv visualization with 3 aggregation:

Count
Max
datasweet related on agg1 only

when using all aggregations when there is data retrieved for the requested time all works fine.
when using all aggregations when there i no data for the requested time, the visualization doesn't work.
when disabling the Max aggregation, only (agg2), the visualization works.
when disabling the datasweet formula only (agg3) the visualization works.
Below screenshot shows the visualization works with agg2 disabled:

Below screenshot shows the visualization exception when agg2 is enabled:

Regards

Hi @ttgile,
i tried to install the plugin from a fresh kibana, its seems OK.
Did you remove the old plugin first with kibana-plugin remove datasweet_formula
Here the install from 6.3.2
tcharlot@tcharlot-linux:~/Téléchargements/kibana-6.3.2-linux-x86_64/bin$ ./kibana-plugin install file:///home/tcharlot/Téléchargements/datasweet_formula-1.1.2_kibana-6.3.2.zip  Attempting to transfer from file:///home/tcharlot/Téléchargements/datasweet_formula-1.1.2_kibana-6.3.2.zip Transferring 407732 bytes.................... Transfer complete Retrieving metadata from plugin archive Extracting plugin archive Extraction complete Optimizing and caching browser bundles... Plugin installation complete
For the bug, i can reproduce with version 1.1.2

Hi @tcharlot-datasweet,
Many thanks for your response and for the fix.
unfortunately, I'm still getting the same exception exception when trying to install either v1.1.2 or v1.1.3 (I verified i remove the old plugin before).
Installing v1.1.0 or v1.1.1 works fine.
I will try to figure out the issue, it might be related to other plugin i'm using.
Thanks & Regards...


Emit a warning when optionals are coerced to Any.

Add a warning (as called for by SE-0140) for any time an optional is coerced to Any.
Three fixits are provided:

Add '??' with a default value
Force-unwrap
use 'as Any' to explicitly cast to Any

Emit a warning for optionals that are implicitly converted to Any, and
add fixits giving options to:

Add '??' with a default value after
Force-unwrap the optional with '!'
Explicitly cast to 'as Any' to silence the warning

This covers diagnostics aspect of SE-0140.
rdar://problem/28196843

@swift-ci Smoke test and merge.


HOTT-846 responsive Rules of Origin tab

Jira link
HOTT-846
What?
I have added/removed/altered:

[x] Added a .govuk-table--responsive class - this will switch to using 'vertical' tables on mobile, deriving column headings from data-label attributes on the cells
[x] Added a .responsive-full-width cell modifier, to force certain cells to be 'stacked' - ie cell label above the cell content instead of side by side

Why?
I am doing this because:

The rules of origin tab uses govuk tables but these are not responsive - the 2 options were to switch to the existing responsive table pattern which would require a lot of custom theming to handle the embedded markdown content properly, or make the .govuk-table class work on mobile. I've made this a modifier css class so that it is opt in.
There is an optional .responsive-full-width cell modifier class because the rule content is potentially long and out of our control so doubling the horizontal width will halve the vertical space taken up by it, at a cost of a predicable 1 additional row for the cell label.

Have you? (optional)

[ ] Reviewed view changes with stake holders
[x] Validated mobile responsive behaviour of view changes

Deployment risks (optional)

None - the css changes are opt-in only

Before

After

Looks great. Do we want to migrate to using this mechanism now in the sections/measures tables just for completeness? Otherwise we're introducing different approaches between the tables when we could be simplifying/consolidating/reducing the WTF's per minute


Improve extraction of full URL from HttpServletRequest.

Added fast-path for the case where a query string is not present in the request.
Previously a potentially unused StringBuilder instance was allocated for every request.

Thanks!


Make primary instance initialized lazily

Description
This makes the primary instance initialization lazy so that it gets thread-safely initialized on first reqeuest.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

It's unclear to me when this would be necessary, unless you are running multiple class-loaders, static field initialization is already thread-safe (AFAIK). and if that was a case I'm not sure your AtomicBoolean would be in any better? can you point me to some documentation on when this would be needed?

It's unclear to me when this would be necessary, unless you are running multiple class-loaders, static field initialization is already thread-safe (AFAIK). and if that was a case I'm not sure your AtomicBoolean would be in any better? can you point me to some documentation on when this would be needed?

The current approach is thread-safe but it is not lazy. Thus even if a user wants to use instance-based approach (i.e. without using primary instance) the primary instance will still be
initialized on first call to spawnInstance() (once Unirest class gets loaded).
In order to solve this, I've moved the primary instance into a separate class so that it gets lazily initialized on actual first request to it.
As for the AtomicBoolean -- its main purpose is simple: guard callers of shutDown from accidentally initializing the primary instance to just have it shut down.
In other words
I didn't mean to say that current implementation is not thread-safe (there may be some thread-unsafe spots in UnirestInstance itself but it is out of this PR's target), it even is with multiple class-loaders as I know.
I did mean to say that the reason for using a separate holder-class was to provide thread-safety with lazy initialization.
Real-life example
A server which uses plugin system to load extensions at runtime: there is an API-plugin (let's call it RestApi Plugin for simplicity) which shades Unirest in so that dependent plugins can use it without relocating it to their own packages. Yet each plugin is required to spawn their own UnirestInstance not to mess with other ones.
As a maintainer of RestApi Plugin I take the responsibility of providing the shaded Unirest classes with my plugin (so that these are available for dependent plugins). However, at RestApi plugin level I cannot guarantee that some developer won't accidentally use primary-instance. Thus I am required to call Unirest.shutDown() on shutdown but want it to be no-op if primary instance was not used by abyone. Yet, if only lazy-init holder was used without AtmomicBoolean guard then attempt to just call primaryInstance().shutDown(clearOptions) would first initialize it (if it has not been initialized yet) and only then shut it down which obviously is redundant.

Ah! Yes, thank you for the explanation. this is a good idea. A couple of things:

There seems to be some checkstyle violation on ci
Is there any way we could test this? I realize this might be tricky to test but maybe not impossible. Did you give any thought to that?

There seems to be some checkstyle violation on ci

I've pushed c586a00 to resolve it;

Is there any way we could test this? I realize this might be tricky to test but maybe not impossible. Did you give any thought to that?

As of this, I am not that sure. There are tools like JCStress (Maven Central) but these seem to fit more for low-level scenarios as it's hard to attach any monitors to the internal singleton to check its state.
As I see, the only possible spot in which I cannot be sure about correct ordering is scenario:

Thread A
Thre   ad B

Atomic CAS of flag
Initialization of Primary.INSTANCE

Call to shutDown()
Volatile write to flag

Thus there are twe following possible invariants (considering the fact that all threads are guaranteed to observe the INSTANCE in the correct state according to JMM):

CAS failed even before INSTANCE was initialized and no shutdown happened
CAS failed between INSTANCE initialization and volatile write and no shutdown happened
CAS succeeded after volatile write thus the INSTANCE was shut down  just after it

IMO, first two scenarios in which (for some reason) shut down was called before initialization do not lead to weird behaviour (or it is the caller's fault that he first managed to issues shut down and then use the instance from which he is not guarded with current implementation too). The last scenario is just correct and does not seem to produce any logical problems.

I actually am not that sure about correctness of all my ideas but at least I tried, haha

The change is failing the tests.  In the old code, while it's true that the UnirestInstance was created. It's configuration was lazy and the core Apache classes (and their various threadpools) were lazy. Calling "shutdown" on an instance shuts everything off and then puts the configuration back into a dormant state which then can be re-initilized.
The tests take advantage of this and shut down the instance after each test, so now only the first shutdown in all the suites works.  I'd like to say this is just a weird thing in the tests but I've spoken with multiple folk who have taken advantage of this in real life. If we change the instance holder to allow for a null state I think we can avoid that. This would require some synchronized methods which we might want to avoid in a heavy traffic situation so theres a little dance here. I'm not saying this is the best answer, I'm open to improvements, but this does what we want I think AND passes all the tests.
We would then have Unirest delegate to the methods rather than looking at the instance itself.
/**
     * Internal holder class which allows lazy initialization of primary {@link UnirestInstance}.
     */
    private static final class Primary {

        /**
         * Instance of the Unirest runtime lazily initialized on startup.
         */
        private static UnirestInstance instance;

        private static UnirestInstance getInstance() {
            if(!exists()) {
                init();
            }
            return instance;
        }

        public static boolean exists() {
            return instance != null;
        }

        private static synchronized void init() {
            if(!exists()) {
                instance = new UnirestInstance(new Config());
            }
        }

        public static synchronized void shutDown(boolean clearOptions) {
            if(exists()){
                instance.shutDown(clearOptions);
                instance = null;
            }
        }

        public static boolean isRunning() {
            return exists() && instance.isRunning();
        }

       private Primary() {
            throw new AssertionError("Primary should never be constructed");
        }
    }

2. Is there any way we could test this? I realize this might be tricky to test but maybe not impossible. Did you give any thought to that?

Have you considered using https://byteman.jboss.org/ ?

One nice thing about using the null pattern would be it's easily tested. because we can call the exists() method.

I'm not saying this is the best answer, I'm open to improvements, but this does what we want I think AND passes all the tests.

This one may requires some changes (I will ltry to imlpement these) as because there are no means of synchronization between method calls, one thread can actually observe null even after the init().
I will try to implement a safer variant with support for switching between initialized and shut down states so that the tests pass.

Considering the problems which appear now while doing this, may I suggest moving the primary instance in 4.0 version into a separate Maven module such as unirest-java-global (or some different name). I.e. keep UnirestInstance and all implementation classes in unirest-java module (also moving Unirest#spawnInstance(..) to UnirestInstance#spawn(..) static factory method) while having unirest-java-global contain the current Unirest with its singleton and stuff.
This would allow (as for the example below) not to rely on primary instance existence (if you don't use unirest-java-global -- then you don't have to worry about it) and yet allow the primary instance approach for those who need it (by providing it as a separate module).
This is OK from point of semver as the major version gets changes allowing backwards-incompatible changes and still it allows more implementation freedom from point of regular unirest-java module.

one thread can actually observe null even after the init().

Wouldn't the synchronized on the method stop that? Unless you had threads fighting to shut down and re-init the instance at the exact moment in which case 🤷 .

Wouldn't the synchronized on the method stop that?

It may but JMM is quite tricky thus I think abot a bit more specific approach.

Unless you had threads fighting to shut down and re-init the instance at the exact moment in which case  .

Yes! That's the exact problem with trying to proof the correctness of the approach)

Just to be clear about one part of all this:

then attempt to just call primaryInstance().shutDown(clearOptions) would first initialize it (if it has not been initialized yet)

this is not true, a configuration exists, but it's not initialized, It's a few classes in memory thats true, but the real engine, the thing that we need to be aware of on application shutdown, are the Apache clients, in an uninitialized configuration those are two empty optionals. So there are no threadpools or anything else going on.
Shutting down only shuts them down if they exist, otherwise it's a noop.
see https://github.com/Kong/unirest-java/blob/main/unirest/src/main/java/kong/unirest/Config.java#L715-L731

Just to be clear about one part of all this:

then attempt to just call primaryInstance().shutDown(clearOptions) would first initialize it (if it has not been initialized yet)

this is not true, a configuration exists, but it's not initialized, It's a few classes in memory thats true, but the real engine, the thing that we need to be aware of on application shutdown, are the Apache clients, in an uninitialized configuration those are two empty optionals. So there are no threadpools or anything else going on.
Shutting down only shuts them down if they exist, otherwise it's a noop.
see https://github.com/Kong/unirest-java/blob/main/unirest/src/main/java/kong/unirest/Config.java#L715-L731

Hm, that's interesting. My bad that I haven't considered this initially.
Funnily, looking at the implementation details this means that the problems possibly appearing in singleton design above (the one with separate synchronized methods) also appear on Config implementation like:
https://github.com/Kong/unirest-java/blob/785d6cc8fc69339ed557cddcdde5fb775ac155bf/unirest/src/main/java/kong/unirest/Config.java#L766-L771
first calling buildAsyncClient writing to asyncClient() and then invoking getFinalAsyncClient() which relies on this field which yet may have been updated to Optional.EMPTY concurrently.

From this perspective this PR may really provide more problems than profit (as you are right that current implementation is already lazy enough).
In this case, is there any chance that the suggestion from https://github.com/Kong/unirest-java/pull/407#issuecomment-863387971 makes its way into 4.0.0? Having this split performed, the UnirestInstance itself may be enhanced later to be enabled once created and shut forever once it's close()d.

4.0 Unirest doesn't use Apache, and there are no background monitors or anything. At least as of right now .... so it's even less of a concern there at the moment. Because there isn't anything to "start" or "shut down".

closing as stale


Add setting for cloudera manager

As Cloudera has mentioned below
https://www.cloudera.com/documentation/enterprise/5-12-x/topics/cm_ig_parcels.html
Hadoop jar was installed in /opt/cloudera/parcels/CDH/ from the Cloudera Manager(parcel),
from yum or somthing(package) , installed in /usr/lib/hadoop.
To deal with both parcel and package, Replace CDH_HADOOP_JAR with the specific value.

@yk-st Your change looks good. However, it might be cleaner to create a separate template for CDH manager (eg pxf-private-cdh-manager.classpath.template) rather than substituting the token values. This will also ensure that PXF pipelines for GPDB are not affected.

@yk-st any update on this ?


fix: add import in alloydb RAG tutorial

Missing import in the AlloyDB RAG tutorial needed for connecting to DB.
Thank you for opening a Pull Request!
Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

[x] Follow the CONTRIBUTING Guide.
[ ] You are listed as the author in your notebook or README file.

[ ] Your account is listed in CODEOWNERS for the file(s).

[x] Make your Pull Request title in the https://www.conventionalcommits.org/ specification.
[ ] Ensure the tests and linter pass (Run nox -s format from the repository root to format).
[ ] Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

Lines in question that fail currently with missing import:
https://github.com/GoogleCloudPlatform/generative-ai/blob/aff5724b3ebb8b7e6292cba8027ec2e4d24a95b9/gemini/reasoning-engine/tutorial_alloydb_rag_agent.ipynb#L404-L406


Issue with the shapes required in tf.layers

Following a standard VAE example for the geneative model that looks like this:
@zs.reuse("p")
def gen2(func, observed, bs, dim_z, n_samples):
    with zs.BayesianNet(observed=observed) as p:
        z_mean = tf.zeros([bs, dim_z])
        z = zs.Normal("z", z_mean, std=1., group_ndims=1, n_samples=n_samples)
        x_logits = func(z)
        x = zs.Bernoulli("x", x_logits, group_ndims=1)
    return p

where func just applies a bunch of dense layers from tf.layers I get the error:
Traceback (most recent call last):
  File "/opt/pycharm-2017.2.3/helpers/pydev/pydevd.py", line 1599, in <module>
    globals = debugger.run(setup['file'], None, None, is_module)
  File "/opt/pycharm-2017.2.3/helpers/pydev/pydevd.py", line 1026, in run
    pydev_imports.execfile(file, globals, locals)  # execute the script
  File "/opt/pycharm-2017.2.3/helpers/pydev/_pydev_imps/_pydev_execfile.py", line 18, in execfile
    exec(compile(contents+"\n", file, 'exec'), glob, loc)
  File "/home/alex/work/python/eval_vi/bin/test.py", line 37, in <module>
    p = gen2(gen_func, {"z": qz_samples, "x": x_bin}, bs, dim_z, n_samples)
  File "/opt/miniconda3/lib/python3.6/site-packages/tensorflow/python/ops/template.py", line 278, in __call__
    result = self._call_func(args, kwargs, check_for_new_variables=False)
  File "/opt/miniconda3/lib/python3.6/site-packages/tensorflow/python/ops/template.py", line 217, in _call_func
    result = self._func(*args, **kwargs)
  File "/home/alex/work/python/eval_vi/bb_eval_vi/models/__init__.py", line 82, in gen2
    x_logits = func(z)
  File "/home/alex/work/python/eval_vi/bb_eval_vi/models/__init__.py", line 47, in dense_stack
    return stack.apply(inputs)
  File "/opt/miniconda3/lib/python3.6/site-packages/tensorflow/python/layers/base.py", line 721, in apply
    return self.__call__(inputs, *args, **kwargs)
  File "/opt/miniconda3/lib/python3.6/site-packages/tensorflow/python/layers/base.py", line 594, in __call__
    input_shapes = nest.map_structure(lambda x: x.get_shape(), inputs)
  File "/opt/miniconda3/lib/python3.6/site-packages/tensorflow/python/util/nest.py", line 387, in map_structure
    structure[0], [func(*x) for x in entries])
  File "/opt/miniconda3/lib/python3.6/site-packages/tensorflow/python/util/nest.py", line 387, in <listcomp>
    structure[0], [func(*x) for x in entries])
  File "/opt/miniconda3/lib/python3.6/site-packages/tensorflow/python/layers/base.py", line 594, in <lambda>
    input_shapes = nest.map_structure(lambda x: x.get_shape(), inputs)
AttributeError: 'Normal' object has no attribute 'get_shape'

originally defined at:
  File "/home/alex/work/python/eval_vi/bin/test.py", line 4, in <module>
    from bb_eval_vi.models import *
  File "<frozen importlib._bootstrap>", line 971, in _find_and_load
  File "<frozen importlib._bootstrap>", line 955, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 665, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 678, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/home/alex/work/python/eval_vi/bb_eval_vi/models/__init__.py", line 77, in <module>
    @zs.reuse("p")
  File "/home/alex/work/python/zhusuan/zhusuan/model/base.py", line 413, in <lambda>
    return lambda f: tf.make_template(scope, f)

Which I think is related to the fact that the model classes have no shapes. However, this makes it quite inconvinient to use like this.

If the issue is just
def get_shape():
    return tf.get_shape(self.tensor)

I can do that, sounds quite simple.

I guess that's it. Does it work?


Move links to crates.io

This is a simple global find-and-replace. There should be a separate effort to verify all these links work, but I think this is at least an improvement.

Closing in favor of #533


How to avoid "vendor" folder when running goimports/goreturns/gofmt on save?

I need to be able to configure the plugin in Atom to NOT update the packages in my vendor folder. How would I do that?

Don't open a file in your vendor folder and then save it. So long as you don't save the file, it won't be formatted.
I suppose we could add an option to not format anything that has vendor as a component of the path, but I'd want to leave it disabled by default, as some people may actually want to mutate a file in the vendor directory and have it formatted.
Is the issue that goimports is losing its mind over the imports?

We are seeing issues with dependencies stored in the vendor folder stripped of git artifacts being updated for some unknown reason. https://github.com/Masterminds/glide/issues/398#issuecomment-239679467  I know that I have the go tools/plugins enabled in Atom (they are awesome!) and am concerned I am inadvertently updating vendored packages.

If you have autosave enabled or if you utilize File > Save All, and you happen to open files in the vendor folder, it's conceivable they could be manipulated by goimports or gofmt (whichever one you have configured)

That makes sense. I would prefer that my tooling NEVER make these sorts of updates for me. I still believe that it would be super helpful if there was a flag I could set to always exclude the vendor folder.


call plug#begin() with no argument in the example

The example starts with a call to plug#begin('~/.vim/plugged').  You already have the logic to select ${first_entry_of_rtp}/plugged if plug#begin is called with no argument, so I would suggest doing so in the example, in order to make it applicable for Windows (where rtp starts with ~/vimfiles instead) -- and I guess for neovim as well, given the comment in the example.

Type:

[ ] Bug
[X] Enhancement
[ ] Feature Request
[ ] Question

OS:

[X] All/Other
[ ] Linux
[ ] OS X
[ ] Windows

Vim:

[X] Terminal Vim
[X] GVim
[X] Neovim

Thanks for the suggestion, but I actually took the opposite direction: 3e65d146ad051e6e65d5797e23d8820b35025e93
Choosing the first path in the runtimepath seemed like a nice idea at first so I suggested it in the past, but it turned out to have been a source of confusion for some users. It is possible that the user manually modifies the runtimepath before plug#begin and ends up with unexpected results. So I decided that we're better off not relying on the mutable global state and being explicit about the path. For using the same configuration file across different platforms, one can use something like has() to decide which path to use. It's obviously more verbose but I believe it's safer and should be preferred.
call plug#begin(has('win32') || has('win64') ? '...' : '...')


(Console): Support multiple files as input

Is your feature request related to a problem? Please describe.
Currently only a single file can be input into lula console -f <single-file>. Need to support multiple files passed to comply to OSCAL standards that each model reside in a separate file. Should also account for writing back to the correct file.
Describe the solution you'd like

Given multiple files are passed to the lula console
When the console is loaded
Then all files/models are reconciled properly

Describe alternatives you've considered
None
Additional context
None
Expected Deliverable
Updated cmd such that lula console -f  accepts multiple files

Bumping to high priority to work before soss fusion demo


New version: HiroshibaKazuyuki.VOICEVOX.CPU version 0.15.2

Pull request has been created with Komac v1.11.0 :mango:
Microsoft Reviewers: Open in CodeFlow

For moderators
This account is automated by Github Actions and the source code was created by CoolPlayLin. If you have any questions about any pull request, don't hesitate to ping @Exorcism0666, I'll get a notification.

[!important]
Please carefully review these Pull Request before merging. If it is a Pull Request for removing incorrect content and the URLs are issue, free upon manual checking, please close this Pull Request directly. (It is best to inform Exorcism0666 of the closure.)

良い一日をお過ごしください！

No errors to post.

No errors to post.

No errors to post.
(Automated response - build 627.)

@wingetbot waivers Add Validation-Executable-Error

@wingetbot waivers Add Validation-Executable-Error


ENG-4525 Update guid-file and guid-node/metadata page titles to include file name/project name

Ticket: ENG-4525
Feature flag: n/a

Purpose
Update guid-file and guid-node/metadata page titles to include file name/project name
Summary of Changes

Modified the analytics charts to display titles from the API instead of GUIDs
Removed aggregation logic for chart data processing

Screenshot(s)

QA Notes

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
8 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.1%) to 68.086%

Files with Coverage Reduction
New Missed Lines
%

lib/analytics-page/addon/components/analytics-charts/component.ts
8
73.4%

Totals

Change from base Build<PHONE_NUMBER>:
-0.1%

Covered Lines:
6132

Relevant Lines:
8756

💛  - Coveralls


Why music: Come up with hosting strategy for photography HTML

Type

✨ Feature
🐛 Bug
🚑 Health report

Needs

[ ] User research
[ ] Content from Content Team
[ ] New visual design
[ ] Analytics and/or component tracking

UI Requirements

Acceptance Criteria

[ ] The interface should do this thing
[ ] and this thing
[ ] and this thing.

Problem to be solved / User Story

In order to
(why? accomplish a goal/get a benefit)
As a
(who? user/persona)
I need/want/expect
(what? to do this thing)

We now have an S3 bucket for this purpose, available at static.wellcomecollection.org


The following classes cannot easily register Hooks, and some even require reflection to obtain filed.  1 DefaultLitePullConsumer 2 DefaultMQProducer 3 DefaultMQPushConsumer

The issue tracker is used for bug reporting purposes ONLY whereas feature request needs to follow the RIP process. To avoid unnecessary duplication, please check whether there is a previous issue before filing a new one.
It is recommended to start a discussion thread in the mailing lists in cases of discussing your deployment plan, API clarification, and other non-bug-reporting issues.
We welcome any friendly suggestions, bug fixes, collaboration, and other improvements.
Please ensure that your bug report is clear and self-contained. Otherwise, it would take additional rounds of communication, thus more time, to understand the problem itself.
Generally, fixing an issue goes through the following steps:

Understand the issue reported;
Reproduce the unexpected behavior locally;
Perform root cause analysis to identify the underlying problem;
Create test cases to cover the identified problem;
Work out a solution to rectify the behavior and make the newly created test cases pass;
Make a pull request and go through peer review;

As a result, it would be very helpful yet challenging if you could provide an isolated project reproducing your reported issue. Anyway, please ensure your issue report is informative enough for the community to pick up. At a minimum, include the following hints:
BUG REPORT

Please describe the issue you observed:

What did you do (The steps to reproduce)?

What is expected to see?

What did you see instead?

Please tell us about your environment:

Other information (e.g. detailed explanation, logs, related issues, suggestions on how to fix, etc):

FEATURE REQUEST

Please describe the feature you are requesting.

Provide any additional detail on your proposed use case for this feature.

Indicate the importance of this issue to you (blocker, must-have, should-have, nice-to-have). Are you currently using any workarounds to address this issue?

If there are some sub-tasks involved, use -[] for each sub-task and create a corresponding issue to map to the sub-task:

sub-task1-issue-number: sub-task1 description here,
sub-task2-issue-number: sub-task2 description here,
...

@freshchen can u describe the question specifically, u can give some examples, and do u have any suggestion to these question?

Im using rocketmq-spring-boot-starter and want add some custom hooks from zipkin trace. seems i need modify 3 class during system initialization. 1 DefaultLitePullConsumer 2 DefaultMQProducer 3 DefaultMQPushConsumer
For DefaultLitePullConsumer I cannot get defaultLitePullConsumerImpl field without reflection to execute registerConsumeMessageHook method.
For DefaultMQProducer and DefaultMQPushConsumer get inner impl field is Deprecated.
suggest add the corresponding register hook method for the above facade class

We'd better add a filter or interceptor chain before pub/sub each message.

所以有拦截器接口定义吗 类似于kafka的ProducerInterceptor

现在有解决方案吗 @lizhanhui


OpenStreetMap import will break if links aren't updated before May 7

http://planet.openstreetmap.org is available over https, and will start redirecting to https on 2018-05-07.
Your project seems to be using osmosis, which will not follow redirects by default.
Would it please be possible to update all files from http://planet.openstreetmap.org to httpS://planet.openstreetmap.org before then?
Ideally, would it be possible to make all requests to openstreetmap.org over https? All services respond over https and will start redirecting soon.

wont it still work on chrome


Logout

@CodiumAI-Agent /review

 ✨ Review tool usage guide:
Overview:
The review tool scans the PR code changes, and generates a PR review which includes several types of feedbacks, such as possible PR issues, security threats and relevant test in the PR. More feedbacks can be added by configuring the tool.
The tool can be triggered automatically every time a new PR is opened, or can be invoked manually by commenting on any PR.

When commenting, to edit configurations related to the review tool (pr_reviewer section), use the following template:

/review --pr_reviewer.some_config1=... --pr_reviewer.some_config2=...

With a configuration file, use the following template:

[pr_reviewer]
some_config1=...
some_config2=...

See the review usage page for a comprehensive guide on using this tool.

PR Reviewer Guide 🔍

 ⏱ Estimated effort to review [1-5]
4

 🧪 Relevant tests
No

 🔒 Security concerns
- Sensitive Information Exposure: The MongoDB connection string with credentials is hardcoded in the source code, which is a security risk. Use environment variables and a secure method to manage secrets.

Input Validation Missing: The lack of input validation on user inputs in the registration and login processes could lead to security vulnerabilities such as SQL injection or other forms of attacks if not handled properly.

 ⚡ Key issues to review

Sensitive Information Exposure: The MongoDB URI containing the username and password is hardcoded in multiple files (server/index.js, server/config/database.js). This poses a significant security risk as it exposes sensitive credentials. Consider using environment variables to store sensitive information securely.

Code Duplication: There is significant duplication of code across different files, particularly in server/index.js and commented sections. This can lead to maintenance issues. Consider refactoring to reduce duplication and improve code maintainability.

Error Handling: The error handling in asynchronous operations (e.g., MongoDB connection, user login) is minimal and could be improved to handle specific error types more gracefully.

No Input Validation: There is no evident validation of user input in the registration and login endpoints, which could lead to security vulnerabilities such as SQL injection or storing invalid data in the database.


Update Optimize Window for Unity 2019

Describe the bug
Virtual Reality supported is now legacy in favor of XR plugins. Need to update the optimize window to account for this between 2018/2019

To reproduce
Open MRTK_Dev in 2019.3+
Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Your setup (please complete the following information)

Unity Version [e.g. 2018.3.11f1]
MRTK Version [e.g. v2.0]

Target platform (please complete the following information)

HoloLens
HoloLens 2
WMR immersive
OpenVR

Additional context
Add any other context about the problem here.

We appreciate your feedback and thank you for reporting this issue.
Microsoft Mixed Reality Toolkit version 2 (MRTK2) is currently in limited support. This means that Microsoft is only fixing high priority security issues. Unfortunately, this issue does not meet the necessary priority and will be closed. If you strongly feel that this issue deserves more attention, please open a new issue and explain why it is important.
Microsoft recommends that all new HoloLens 2 Unity applications use MRTK3 instead of MRTK2.
Please note that MRTK3 was released in August 2023. It features an all new architecture for developing rich mixed reality experiences and has a minimum requirement of Unity 2021.3 LTS. For more information about MRTK3, please visithttps://www.mixedrealitytoolkit.org.
Thank you for your continued support of the Mixed Reality Toolkit!


Inputting an untranslatable character results in resultBox slideDown animation

If you input an untranslatable character, such as a space or characters like @!",. etc., the resultBox element causes the language toggle options to momentarily move down before returning to their original position - I presume the result of slideDown being fired even if there is nothing to display.
This occurs in Firefox (Gecko), Chrome (Blink), Vivaldi (Blink) and Opera (WebKit), but Safari appears unaffected.

This issue has been fixed in commit# 716cde1.


[BUG] PagedIterable stream().paralllel() is behaving as sequential

Describe the bug
PagedIterable<BlobItem> stream().paralllel() is behaving as sequential.
Exception or Stack Trace
Log showing a single forkjoinpool worker is performing the task even though it has 20 workers.
2024-06-21 17:59:21,275 INFO  [ForkJoinPool.commonPool-worker-1] c.o.g.f.v.s.o.IndividualRequestXmlAggregator gpfh-vendor-outbound-job batchId: '2000' sourceSystem: 'GPS': Downloading
blob 789/generated/2023-12-03/1232939632.xml
2024-06-21 17:59:22,208 INFO  [ForkJoinPool.commonPool-worker-1] c.o.g.f.v.s.o.IndividualRequestXmlAggregator gpfh-vendor-outbound-job batchId: '2000' sourceSystem: 'GPS': Downloading
blob 789/generated/2023-12-03/1232939814.xml
2024-06-21 17:59:23,143 INFO  [ForkJoinPool.commonPool-worker-1] c.o.g.f.v.s.o.IndividualRequestXmlAggregator gpfh-vendor-outbound-job batchId: '2000' sourceSystem: 'GPS': Downloading
blob 789/generated/2023-12-03/1232939895.xml
2024-06-21 17:59:24,065 INFO  [ForkJoinPool.commonPool-worker-1] c.o.g.f.v.s.o.IndividualRequestXmlAggregator gpfh-vendor-outbound-job batchId: '2000' sourceSystem: 'GPS': Downloading
blob 789/generated/2023-12-03/1232939934.xml

To Reproduce
Steps to reproduce the behavior:
Use the below code snippet to list the blobs. Logs will display that the task is occurring serially which is causing slowness if the blob counts are in millions.
Code Snippet
BlobServiceClient blobServiceClient = new BlobServiceClientBuilder().connectionString(connectionString).buildClient();
BlobContainerClient blobContainerClient = blobServiceClient.getBlobContainerClient(blobContainerName);
String blobPrefix = "789/generated/";
ListBlobsOptions options = new ListBlobsOptions().setPrefix(blobPrefix).setMaxResultsPerPage(5000);
PagedIterable<BlobItem> blobItems = blobContainerClient.listBlobs(options, null, null);
blobItems.stream()
        .parallel()
        .filter(this::isAnXml)
        .forEach(
            blobItem -> {
              LOGGER.info("Downloading blob {}", blobItem.getName());
              //more business logic
            });

Expected behavior
Execution should happen in parallel by multiple worker threads rather than by the single thread in sequential manner.
Setup (please complete the following information):
OS: Ubuntu 22.04.4 LTS
IDE: Intellij
Library/Libraries: com.azure:azure-storage-blob:12.25.0
Java version: Openjdk version 17.0.10
App Server/Environment: Tomcat embedded in Springboot
Frameworks: Springboot v3.2.3
Information Checklist
Kindly make sure that you have added all the following information above and checkoff the required fields otherwise we will treat the issuer as an incomplete report

[x] Bug Description Added
[x] Repro Steps Added
[x] Setup information Added

Do you happen to have any news on this? I just stumbled across the same issue.


IsInt is not defined

IsInt is not defined.
This should be easy.  I'm just making a note.

Fixed.
function IsInt(data) {
    return (/^\d+$/.test(data));
}


Feature: persisting theme via localStorage

Description
Now theme will remain persisted on page refresh.
Checklist

[x] I am making a proper pull request, not spam.
[x] I've checked the issue list before deciding what to submit.

Related Issues or Pull Requests
https://github.com/wasimreja/book-finder/issues/173
Add relevant screenshot or video (if any)
screen-capture (2).webm

there is some issue with the light/dark mode toggle. fix that.

Thanks, fixed icon based on theme. @wasimreja can you check now.


Can be considered compatible with windows？

I've never tried, but I believe it should work: the library is just a wrapper around the standard library to make things more human friendly
One of the easiest way to know if it works correctly is to install aioextensions and pytest in your windows system,
then run pytest from the test folder of this repo

If something goes wrong let me know! sure thing we can fix it

Because uvloop does not work on Windows

let's keep it open, I'll make uvloop optional so it works on windows
thanks!

@sylvoslee I just released 20.11.1621472, please let me know if you can install and use it on Windows

thank you,it can works on windows now


Add Whole Summary Upload/Download support to GitRest

We've been adding a lot of features to the R11s Driver around "Whole Summary Upload/Download", however, the R11s Git storage scenario has been all but left behind. This PR adds whole summary support to GitRest such that enableWholeSummaryUpload flag in the R11s Driver works with the Git storage scenario.

How do we plan on testing this? Will it just be enabled by default? I don't see any unit testing in the PR.

@skylerjokiel I tested this locally (thanks to #8025) using clicker with enableWholeSummaryUpload flag set to true. It worked great. It's also a totally optional feature, at least for now until we conclude that it is/isn't more performant than Shredded summary uploads/downloads. The default driver setting will still be to have enableWholeSummaryUpload set to false, so the default use case would not hit these routes.
One catch was that I needed to also run the local version of Historian because the latest publicly released Historian image does not include the routes for summaries. We'll have to release both for this functionality to be publicly available.


(comment-newimpl): Updating Option to Option

Can this be separated from the work on package parameters? That would make a nice clean diff.

Yes of course, I'm closing this PR and will create another clean PR checked out from origin/master.


Add array route support

To have more readable codes, small changes have been done. In Route, Controller names are given as arrays.
Example
use App\Api\V1\Controllers\LoginController;
$api->post('login', [LoginController::class, 'login']);

@jasonlew @specialtactics Can you please merge this?

Sorry, but I don't agree that this is more readable - it creates ambiguity because it is not clear what those array elements mean and what they relate to.
It is also not the way documented on the Laravel docs.

I think there has been a misunderstanding. You can set a route in this way at @specialtactics Laravel's own router. But this feature does not exist in Dingo API. I made it as an option. It does not break the current router. Anyone may use or just continue the current one.

Hey @faytekin that's fine in that case, I just requested one change which is to put a comment donoting what the code does.
Also there is a merge conflict with that file which you need to resolve.

Merged, tagged


Enabling DTA tasks in RM

Have already sent a PR in MSeng to take care of Task side changes

Signed off

You will also need M86 merge - branch was created by Bryan yesterday


Copyright should read "Rightpoint"

Copyright should read "Rightpoint"

Should the year (Copyright 2016 Rightpoint) be left as is, or brought forward to year of acquisition (2017), or to now (2019)?

And where are you seeing the copyright? I'm seeing it mostly for pods (Anchorage, BonMot, Swiftilities). The template files are all replaced by cookie cutter: "Copyright © 2017 ORGANIZATION"

I guess it is in LICENSE file at root...

in https://github.com/Rightpoint/ios-template/pull/141


Enum default value is not consistent with other field types

Version: v0.2.6
Given these two fields:
return []ent.Field{
	field.String("strfield").
		Default("default"),

	field.Enum("enumfield").
		Values("default", "something_else").
		Default("default"),
}

The first one works as expected where the default value is filled in during creation and during migration filling the default value for the existing rows.
The second one does not work the same way, even though at least for postgres they are the same varchar type underneath.  The default value is filled in during creation, but not during migration on the existing rows.  I'm looking for clarity if this is intentional.  If so, is there a recommended way of providing default values on existing rows using ent?
Note that if the above code is provided from a Mixin, the generated code fails due to an "unused variable" error from the runtime package.  Not sure if this is a separate issue or stems from the same issue.

Hey @davidharrigan and thanks for reporting this issue.

The second one does not work the same way, even though at least for postgres they are the same varchar type underneath.

Yes, it's too complicated to manage enum types in PostgreSQL and we decided to use varchar at the moment in the database, and enforce this in the application-level only.

The default value is filled in during creation, but not during migration on the existing rows.

Note that if the above code is provided from a Mixin, the generated code fails due to an "unused variable" error from the runtime package. Not sure if this is a separate issue or stems from the same issue.

Checking this now and I'll update this issue

I wasn't able to reproduce the Mixin issue on both v0.2.6 and master. See branch: enum-issue.

Hey @davidharrigan, issue resolved with #646.
Thank you for reporting this issue 😃

thank you for the speedy fix!


Samba: Disabling guest mode by default

I am concerned that by default the Samba add-on allow anyone on the local network to see the entire configuration and secrets. I propose to disable guest mode by default.
You also risk to inadvertently expose the entire configuration to the Internet if you open the Samba ports for remote access.
This is a potential breaking change for users of the add-on.
Note to self: Update documentation afterwards.
(I'm not 100% sure if a pull request is the right place to start this discussion. Please tell me if this in-appropriate.)

In favor of https://github.com/home-assistant/hassio-addons/pull/427, we attach samba to our internal user system, so there is no option available after that

Ah, that sounds awesome!
I'll close this PR then.
Und tschüss.


Feature/API SDK Request:  gdscript SDK

Could there be API SDK for godot engine?
(yes I know I can just make http requests... and that is what I have been doing for now, but it would be nice to have godot API SDK)

Sorry, at least until we reach a more stable version, there are no plans for now to work on other SDKs as it will be really hard for me to maintain, but community contributions are more than welcomed.
Unfortunately I don't have experience with Godot Engine and I'm not sure what to recommend, but if you or someone else want to work on an SDK you can use the JS SDK or the Dart SDK as a reference (I recommend more the Dart code as it is slightly easier to read in my opinion).

ok


GEODE-5083: Alter region --name option no longer auto completes

Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:

[x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

[x] Has your PR been rebased against the latest commit within the target branch (typically develop)?

[x] Is your initial contribution a single, squashed commit?

[ ] Does gradlew build run cleanly?

[ ] Have you written or updated unit tests to verify your changes?

[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to<EMAIL_ADDRESS>

just thought of something, maybe add a test to AlterRegionCommandTest to make sure this converter is used. One of the effect of the converter is to make sure region name starts with a "/". Something like this:
@Test
public void regionNameIsConverted() {
String command = "alter region --name=Person";
GfshParseResult result = parser.parse(command);
assertThat(result.getParamValue("name")).isEqualTo("/Person");
}


Add option to output log to console (for situations when there's no access to log files)

Which version of the AzCopy was used?
10.22.1
Which platform are you using? (ex: Windows, Mac, Linux)
Windows
What command did you run?
n/a
I'm working with automation on the system that is does not allow any connections to it. No RDP, no network access, nothing.
The only way to see what's going on is console output of the runner.
For troubleshooting, I'm collecting some logs with azcopy.
But when azcopy runs into a problem, it does not display enough information on the console, only in the log. And I can't get to the log files (that's the whole reason I'm trying to run azcopy).
Please add option to output logs to console instead of, or in addition to, log files.

AzCopy is very verbose in logging and hence we prefer to dump logs to file. Dumping it on console will hang up your console depending on the job size and most customers working with automation do not like that part. Once your job is complete you can use the job-id to get the log file and analyze it.
" when azcopy runs into a problem, it does not display enough information on the console" can you point something specific here which can help us improve our logging.

AzCopy is very verbose in logging and hence we prefer to dump logs to file. Dumping it on console will hang up your console depending on the job size and most customers working with automation do not like that part.

That's fine, but you're answering as if I asked to make it default for everyone. I did not. The answer does not apply to what I'm asking. Also I don't get "hang up console" part, as far as I know that is not a thing. Again, let me make the choice.

Once your job is complete you can use the job-id to get the log file and analyze it.

Please take another look at the scenario, that is not possible - I have no interactive access to the machine. I can launch something, wait for 1 hour, observe console output.

" when azcopy runs into a problem, it does not display enough information on the console" can you point something specific here which can help us improve our logging.

This is not the correct mindset. I need to be able to troubleshoot any problem by looking at just console output. Which means I cannot be specific by definition - I need to see everything that may indicate root cause of the problem. In on particular narrow scenario, some of the files were in use. So would need to see that. But that's just one example.

Closing this here, we will add this item to our backlog but as of now this will be on low priority. If you are blocked on this one, you can fork the repo and make the required changes. Feel free to submit back the PR as a contribution to AzCopy.


Initial draft for storage-blob

@JonathanGiles   Alan said that I should wait for Queue because it is not merged into master. So for this PR I will only work on blobs.


Compatibility Inquiry: Support for Apollo 6 in pycyber Component

I use cyber_channel echo [channel name] or other command, the pycyber not work in apollo 6.0
Could you please confirm whether pycyber supports Apollo 6 or if there are any plans to provide compatibility in the near future? We greatly value the functionalities provided by pycyber and would like to ensure a seamless integration with the latest version of Apollo.

Apollo 6.0 itself supports cyber command, I don't understand why you use it like this?

Apollo 6.0 itself supports cyber command, I don't understand why you use it like this?

Perhaps I didn't clarify my experimental environment well. I hope to monitor and collect certain data on the host machine where not in Apollo Docker, through a specific channel.

If you work in docker host mode, then you can't communicate between the host and the container, which is determined by the docker policy.
If you want to communicate in a physical machine, you must use the docker bridge mode

If you work in docker host mode, then you can't communicate between the host and the container, which is determined by the docker policy.
If you want to communicate in a physical machine, you must use the docker bridge mode

thanks, after setting bridge mode of docker , pycyber works!


Proposed deprecation policy while still in alpha

📚 Documentation
We should adopt a deprecation policy. Currently our deprecations have been completely ad-hoc, which in a way is fine being in alpha, but as our user base increases, it would be good to document somewhere what can be expected of our API. After some private discussion with @sofroniewn, we'd like to propose something like the following text:

napari is still alpha software, and the API continues to evolve. We recognize that there are many users already depending on napari, though, and so we have put the following policy in place for API changes:

minor changes to the API will be deprecated over at least two patch releases (the y in 0.x.y). That is, if a feature is marked as deprecated in 0.4.1, it will not be removed until 0.4.3 at the earliest. In practice this usually means between 1-2 months.
major changes to the API will be deprecated over a minor release (the x in 0.x.y). That is, if a major part of the API is marked as deprecated in 0.4.5, it will not be removed until 0.5 at the earliest, but could be 0.6 if 0.5 is released soon after 0.4.5.
"minor" and "major" are subjective evaluations based on our own estimation of usage of a part of the API, and are subject to user feedback. If you see some part of napari marked as deprecated that would adversely affect your own software development, please get in touch at https://github.com/napari/napari/issues!

Thoughts appreciated!

Thanks for posting @jni. As noted above, I like this, I think it strikes a good balance. Curious what others thinks.


Add Default implementation for GhostCell

A Default implementation makes GhostCell easier to use when embedded in some other data-structure.

side-note: it may be a good idea to enable some CI.

Thanks for the patch.

side-note: it may be a good idea to enable some CI.

Yes, definitely.
I understand that Github Actions are a good way to do so, but I've never used them before. Would you happen to know some resources I could look at -- notably best practices, and what NOT to do?

I understand that Github Actions are a good way to do so, but I've never used them before. Would you happen to know some resources I could look at -- notably best practices, and what NOT to do?

I don't know of any off the top of my head, sorry. Try looking at GitHub Actions docs or Google? As for things not to do, all I can think of is don't use Travis CI, they are not as good as they used to be.


No Emmet support?

I'm getting no HTML tag completion in the style of Emmet. Is this deliberate? This seems like a critical tool for a Liquid extension.

maybe It should work.

open settings.json in vsode settings(you can edit either user or workspace settings.).
paste this code "emmet.includeLanguages": { "liquid": "html" },

ref:
https://github.com/Microsoft/vscode/issues/56593#issuecomment-415978368

maybe It should work.

open settings.json in vsode settings(you can edit either user or workspace settings.).
paste this code "emmet.includeLanguages": { "liquid": "html" },

ref:
https://github.com/Microsoft/vscode/issues/56593#issuecomment-415978368

It's not working.

Adding "emmet.includeLanguages": { "liquid": "html" }, to the settings works, but I'm having issues with Emmet not line breaking and indenting properly.
Expected:

cursor here + hit Enter

should open the tags like this:

  cursor here

but instead, this happens:

👋🏻 This repo has been moved to https://github.com/Shopify/theme-tools
If this is still an issue, please open a new issue there with the tag area:theme-check-vscode


Trying to connect ADLS and it keeps on showing the processing, but to no avail.

Storage Explorer Version: Azure storage 1.6.2
Platform/OS:  Windows 7?
Architecture: x64
Regression From: This was working when it was downloaded in Dec end  28th or so... and from recent 1 month past, it does not connect
Bug description
NOT able to connect to Azure data lake store .
Even though we are connected to azure subscription
Steps to Reproduce

Launch storage explorer,
Set proxy
connect to azure subscription
browse to azure data lake store

Then it does not connect and does not show any folder
Expected Experience
It should show contents of azure data lake store
Actual Experience
Not connecting to ADLS
Additional Context

@landaindia We recently released v1.7.0. Can you please upgrade and try again?
@djlan Can your team take a look into this?

Even installed the latest released v1.7.0 and having the same issue.
I have the right proxy set up and it is detecting the ADLS from all my subscriptions. But I am not able to view any folder of ADLS.
It shows processing status for a long time  just to show me the below message ..which is very frustrating
tunneling socket could not be established, statusCode=407
This tool has been nightmare to me since a year, here or there or other, it will have prob :(

If somebody from MS wants to have a live demo, I am happy to demonstrate it...

I have raised the same issue under x-plat-cli ... can somebody merge that issue with this issue

Investigating.

I am also facing the same issue with ADLS gen 2. Is there any update for this issue?

@anoopasokan ADLS Gen2 is an entirely different feature set. If you are experiencing an issue with connecting to ADLS Gen2, please open a separate issue.

The retirement of ADLS Gen1 is now less than three months away. As previously announced the service will be retired on 29 February 2024. With this date now close approaching we are going to close this issue as "won't fix". Documentation on how to migrate your data to ADLS Gen2/blob storage can be found here: https://learn.microsoft.com/en-us/azure/storage/blobs/data-lake-storage-migrate-gen1-to-gen2-azure-portal
If you have any non ADLS Gen1 feedback for Storage Explorer, please feel free to open a new issue: https://github.com/microsoft/AzureStorageExplorer/issues/new/choose
This issue will now no longer be monitored.


Add atom.io website archives

I scraped the main atom.io website as well as sub-domains blog, teletype and flight-manual.
atom.io/packages and atom.io/users were excluded as not useful.
The assets folder in each one contains the main website assets.

@Daeraxa, can you confirm that this is not altered content?

It was scraped directly, yes. I haven't touched a single file.


Fix references

Update footnote URLs to new domain and fix up list of references

👋 Hey @lnxchk, I saw you made some of the same fixes in 292ed997ff751c53cfd0ec3401a1e657187a8014, there are still a couple of stragglers so I've updated this branch if you want to take the remainders.

Thanks, Paul!


Consistently maintain the 'this' value for model calls in Promise.try

Going to combine this with my other PR to reduce merge pain.


LoadFontFace support for gofont

The packets in https://godoc.org/golang.org/x/image/font/gofont supply font data for easy inclusion, but there is no method to load the font from a slice.
Therefore, I would like to ses a "ParseFontFace" for this purpose.

Sounds like a good feature!

@maugsburger No need for an API change, see the new gofont.go example from 0e0ff3a

@fogleman lovely, thanks ❤


Remove deprecated code

Remove most of the code which is marked deprecated.

Remove deprecated FixtureHelpers from dropwizard-testing
Remove deprecated methods from DataSourceFactory and PooledDataSourceFactory
Remove deprecated constructors from DropwizardAppExtension
Remove deprecated constructors from DropwizardTestSupport
Remove deprecated FreemarkerViewRenderer#FreemarkerViewRenderer()
Remove deprecated ViewMessageBodyWriter#ViewMessageBodyWriter(MetricRegistry)
Remove deprecated SslReload#reload(SslContextFactory)
Remove deprecated AssertServlet#getResourceUrl(String)
Remove deprecated Application#onFatalError()
Remove deprecated Bundle from dropwizard-core
Remove deprecated Authorizer#authorize(P, String)
Remove deprecated HttpsConnectorFactory#logSslInfoOnStart(SslContextFactory)
Remove deprecated methods from DefaultHealthFactory

After this, the remaining deprecated code is:

junit 4.x support in dropwizard-testing - is the plan to keep this for 3.x?
various *Param classes in dropwizard-jersey - they probably deserve a PR to themselves
dropwizard-hibernate AbstractDAO#criteria() - no need to remove this until it gets removed from hibernate itself
dropwizard-servlets PostBodyTask#execute(Map<String, List<String>>, PrintWriter) - this is marked deprecated as a way of futzing with the inheritance tree
varous methods in dropwizard-jetty GzipHandlerFactory relating to inflate streams and excluding by user agent

Windows build is failing with
[INFO] Running com.example.helloworld.IntegrationTest
[ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.265 s <<< FAILURE! - in com.example.helloworld.IntegrationTest
[ERROR] com.example.helloworld.IntegrationTest  Time elapsed: 0.265 s  <<< ERROR!
java.lang.Exception: java.util.ServiceConfigurationError: io.dropwizard.views.ViewRenderer: io.dropwizard.views.freemarker.FreemarkerViewRenderer Unable to get public no-arg constructor
Caused by: java.util.ServiceConfigurationError: io.dropwizard.views.ViewRenderer: io.dropwizard.views.freemarker.FreemarkerViewRenderer Unable to get public no-arg constructor
Caused by: java.lang.NoSuchMethodException: io.dropwizard.views.freemarker.FreemarkerViewRenderer.<init>()


Expose Suite and Test objects for altercation

Fix for #872
As part of fixing #872 following was done :

Introduced a new listener which when implemented
end users will be able to access both the XmlSuite
and the XmlTest inside it.
Added tests.

@cbeust
This pull request is a follow up to the mail discussion that I had with you in terms of a new feature.

This looks good, @krmahadevan. It's a pretty simple addition that adds a reasonable amount of power. I'm just a tad skeptical on the need since somehow, I don't think this feature has ever been requested before (which is surprising, come to think of it). But I'm leaning toward merging it.
@juherr What do you think?

@cbeust
Thank you. Yes I know. This feature never made sense to me until someone in my org came over to me and asked for this. That was when I felt that this would perhaps be a good addition. I would wait for @juherr to chime in with his comments.

:+1:
And I've already found a use case: configure parent-module by code!
I suppose this new listener will work with service loader. Someone confirms?

@juherr Yes, service loaders work (see the Javadoc above).
Everything good, merging this one. Thanks Krishnan!
Next, can you update

the CHANGES file with a quick description of your addition an
the documentation-main.html with a full description of this feature

?
Thanks again!

@cbeust
I have raised a new PR for the documentation ( https://github.com/cbeust/testng/pull/885 )
Will ensure that the documentation changes are also part of the same PR going forward. Sorry about the confusion


HLS live stream chunklist has to have more than 3 chunks

Have you read the FAQ and checked for duplicate open issues?
Yes
Is your feature request related to a problem? Please describe.

Kind of. We discovered that when using HLS live stream, there has to be more than 3 chunks in the chunklist. With 3 chunks, the buffer stays empty and the next chunk is loaded pretty much at the last second, causing small buffering between chunks.
If chunklist contains more chunks, then there is always one extra in buffer and playback is smooth.
Describe the solution you'd like

I guess that this info should be added to FAQ/Tutorials doc
Describe alternatives you've considered

Additional context

It's already documented in the description of the defaultPresentationDelay configuration.

A default presentationDelay value. For DASH, it's a default presentationDelay value if suggestedPresentationDelay is missing in the MPEG DASH manifest. The default value is 1.5 * minBufferTime if not configured or set as 0. For HLS, the default value is 3 segments duration if not configured or set as 0.

https://shaka-player-demo.appspot.com/docs/api/shaka.extern.html#.ManifestConfiguration

I suppose we could also add it to the FAQ, which is probably more visible to developers than the description of a configuration value.

I agree with @theodab . Now that you mentioned it, yes I can see that it is documented. But it is hard to find, if you don't know what you are looking for. The symptom is live stream lagging; buffer visualizer shows that chunks are not buffered / are requested at last second. What's the reason?  I ended up comparing our stream with some Akamai test stream; same player conf; found out that Akamai chunklist is a lot larger. Tested and verified that this was the case.
But if there would be something like this in the FAQ, it would of made finding the issue a lot easier:
Q: My player keeps buffering after each chunk when streaming live.
A: It is reccomended to have more than 3 chunks in your chunklist. If this is not possible, then you have to change the presentationDelay value. Read more about manifest configuration here.


setTexture is now deprecated

setTexture is now deprecated, please use the texture property, e.g : sprite.texture = texture;
It says in every requestAnimationFrame().
PIXIv3 : v3.0.11
pixi-particles: v1.6.6

Ok, I found the "error". When developing with webpack, PIXI has no version. That's why the useAPI3 flag was false.

Fixed installing:

transform-loader
browserify-versionify

And adding this to my webpack.config.js file:
{
  include: path.resolve(__dirname, 'node_modules/pixi.js'),
  loader: 'transform/cacheable?browserify-versionify',
},

Credits: https://github.com/pixijs/pixi.js/issues/1854#issuecomment-217683997


The transition (SWITCH) point for MPEG2-PS would sometimes never be found because of signed bytes in Java.

I missed this one since my test cases actually passed without this modification, but just the other day I caught a few transition that timed out because over 8MB of data was processed without finding a transition point. The root of the problem is signed bytes. This masks the bytes so we are comparing the correct "unsigned" value.

Could this looped search be done more efficiently with data.getLong(i) and making a single comparison?  I'm not sure about the performance in java of all these single byte data moves and comparisons.
Even faster MIGHT be to use a Long variable to load in at first, and then shift 8 bits and add a data.get(i) byte as it loops through.
Honestly, I'm not even sure how often this search is being done - just my quick observation at seeing this small bit of code.

This is only used to find a good transition point to start a new file. This particular search is really not my code; it's adapted from what is done in the C++ code and is only used for about half a second typically, so I think it's good enough, especially since I have yet to see this code spike the CPU. Think about how slowly the video actually comes in.
This is technically more efficient than getLong because instead of bit shifting 4 times just to find out the first byte isn't the right value, we find out rather quickly. I could have it do the kind of bit shifting that's used to find a sequence header once we reach a valid pack header, but I really don't think this merits that level of optimization given how little it's actually "combing" over the stream.

Makes sense, like i said, It was just an observation on a small bit of the code.  I don't know much about Java performance, and thought that dealing with a single 64-bit number might be easier (especially if more and more run a 64-bit JVM going forward).

I really do appreciate more eyes on what's going into the core. Also I just realized, that would be bit shifting 8 times for long; that's even worse since we only need the first 4 bytes. :) I got hung up on 4 bytes because that's how many we are actually using. I really do consider these things especially when there's a convenience method like that, but often it doesn't actually fit what I need or would do more than I need, so I don't bother with it.
In Java all numbers are signed including bytes. It really makes the language less suitable for processing A/V because it adds a different type of error you can accidentally introduce. Basically the code you see here was originally comparing a byte value to an integer value. 0xBA is actually a negative byte. When compared, Java will keep the sign. So the comparison ends up being (int) 186 != (byte) -70.

Oh yeah...this fun Java issue. :)  I get so tired of ANDing byte values with 0xFF just to compare them against a hex constant in Java....it's all throughout the SageTV codebase.


test: disable Index.Store.output-failure on Windows

chmod -w really doesn't make sense on Windows.  Although NTFS allows
for readonly directories, it is something done through file system level
ACLs.  This test doesn't really apply to Windows.

Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

Resolves SR-NNNN.

CC: @akyrtzi @bitjammer

@swift-ci please smoke test


Update dependency jobConfigHistory to v1146

This PR contains the following updates:

Package
Update
Change

jobConfigHistory
major
1139.v888b_656ca_f6d -> 1146.v94c2521f9213

Release Notes

jenkinsci/job-config-history-plugin
v1146.v94c2521f9213
Compare Source

🚀 New features and improvements

Add modern icons following new Jenkins UI style (#199) @DuMaM

📦 Dependency updates

build: bump bom-2.319.x from 1362.v59f2f3db_80ee to 1382.v7d694476f340 (#198) @dependabot
build: bump jenkins-infra/interesting-category-action from 1.0.0 to 1.1.0 (#197) @dependabot
build: bump bom-2.319.x from 1342.v729ca_3818e88 to 1362.v59f2f3db_80ee (#195) @dependabot
build: bump jenkins-infra/jenkins-maven-cd-action from 1.2.0 to 1.3.0 (#196) @dependabot
build: bump bom-2.319.x from 1289.v5c4b_1c43511b_ to 1342.v729ca_3818e88 (#194) @dependabot
build: bump bom-2.319.x from 1246.va_b_50630c1d19 to 1289.v5c4b_1c43511b_ (#193) @dependabot

Configuration
📅 Schedule: "after 5:00 am before 11:00 am" in timezone utc.
🚦 Automerge: Disabled due to failing status checks.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.

[ ] If you want to rebase/retry this PR, click this checkbox.

This PR has been generated by Renovate Bot.

Branch automerge failure
This PR was configured for branch automerge, however this is not possible so it has been raised as a PR instead.

Branch has one or more failed status checks


Make Character/NPC rendering authentic

Right now, various methods/"enhancements" are used to make character equipment and NPC rendering work "well enough". Instead, EndlessClient should start by emulating the vanilla client's default hard-coded behavior, but allow for overrides via metadata.
Examples of this include:

Hat equipment (currently using supplementary ini file)
NPC offsets (currently using "universal" formula)
Shield equipment vs back equipment (currently incorrectly using ItemSubType == Arrows)
Effects (currently using hard-coded and possibly incorrect metadata)

Instead of trying to improve on this behavior by default, EndlessClient should properly emulate the behavior from the vanilla client which is usually hard-coded based on gfx or npc ID, and load additional metadata for overriding this behavior from the EGF files.
The idea is to add an RCDATA entry with a well-known name (e.g. METADATA) with the contents set to a well-defined JSON format, and load that alongside the EGF files. This would be completely ignored by the vanilla client, but a custom client could make enhancements based on what is specified in this metadata file much more easily than the currently required hex editing process.
Something like the following could be added to INativeGraphicsManager:
MetadataFromResource<TMetadata>(GFXTypes file, int graphic);

Where TMetaData is the model type of the JSON object (this is easily mapped using Newtonsoft).
Using a generic metadata model type would allow different types based on the file being loaded, which would be convenient for properties that don't make sense between different gfx files.
Improvements to PELoaderLib also required since loading RCData is currently not supported.

Default NPC rendering offsets here: https://docs.google.com/spreadsheets/d/1GMo3c2xcPW5Uv3pOsaIS2EwtVA_N0Qfwo9TCTDibUoI/edit#gid=0

Effect metadata available here:
https://docs.google.com/spreadsheets/d/1DQgN4r2cH6HA2ydn4M6CpUJlClWXXBemosYP57k_o5I/edit#gid=0

Shield metadata is a hard-coded branch:
shield_gfxid = player->shield_sprite;
if ( shield_gfxid == 10
  || shield_gfxid == 11
  || shield_gfxid == 14
  || shield_gfxid == 15
  || shield_gfxid == 16
  || shield_gfxid == 18
  || shield_gfxid == 19 )
{
  is_back_slot_item = 1;
}

Hat metadata is a couple hard-coded branches:
if ( player->hat_sprite >= 7 && player->hat_sprite <= 15 )
  is_under_hair_hat = 1;
if ( player->hat_sprite == 32 || player->hat_sprite == 33 || player->hat_sprite == 48 || player->hat_sprite == 50 )
  is_under_hair_hat = 1;
if ( player->hat_sprite >= 16 && player->hat_sprite <= 21 )
  is_bald_hat = 1;
hat_gfxid = player->hat_sprite;
if ( hat_gfxid == 25
  || hat_gfxid == 26
  || hat_gfxid == 28
  || hat_gfxid == 30
  || hat_gfxid == 31
  || hat_gfxid == 34
  || hat_gfxid == 35
  || hat_gfxid == 36
  || hat_gfxid == 37
  || hat_gfxid == 38
  || hat_gfxid == 40
  || hat_gfxid == 41
  || hat_gfxid == 44
  || hat_gfxid == 46
  || hat_gfxid == 47 )
{
  is_bald_hat = 1;
}

Source for this and last comment: https://gist.github.com/tehsausage/2d9e56cb34519ceac54f385bd5f15558


replace find-up with findup-sync in algob

Please merge the master and remove find-up from dependencies. We need to check if find-up is used in any other place

Please merge the master and remove find-up from dependencies. We need to check if find-up is used in any other place

done.


Verify toolkit installation

Attempt at fixing #664

[ ] Determine how to conditionally uninstall a package (that may or may not be found) without sending a bad exit code
[ ] Tag issue being addressed
[ ] Add tests
[ ] Update docstrings/documentation, if applicable
[ ] Update changelog

@jaimergp this has me stumped and I could use your help here whenever you had some bandwith. I expected 'RDKit unexpectedly found' to be caught (see linked issue) but the one-liner isn't even finding OpenEye installed. It shows up in the conda list and nothing fishy has been happening with the license lately, I don't think. Locally, those four one-liners behave as expected (installing/uninstalling each toolkit along the way). It doesn't strike me as an issue with GitHub Actions, conda, or our own software.

Are we sure is it not due to licensing? This line is oddly suspicious given the expiry date (Jun 2020):
https://github.com/openforcefield/openforcefield/blob/e923cd65152d7dbb91ae3f0e3c2a38bf1874364f/.github/workflows/CI.yml#L94

That's probably it - I botched this in #588; the lifetime of that PR extends to before you update the org secret and because that file was changed so much, patch did not get merged in.

Okay, that's a relief. Now the failures are only as expected (RDKit=false, OpenEye=true because RDKit sneaks in when it maybe should be installed)

You can conda remove --force rdkit in that step condition if needed.

I got hung up on how to get that command to behave when the package it's trying to remove might not be there. Not pretty but a bash if does the job

Okay, this serves the purpose I intended it to serve. There is probably some golf that could condense it down to fewer characters, but I think it's readable as is.

LGTM!


docs: RFC Mutually Exclusive Pods Uniformly Distributed Scheduling

Fixes #1418
Description
How was this change tested?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Request for review of RFC
/cc @ellistarn @jwcesign

/retest

ping @ellistarn

Pull Request Test Coverage Report for Build<PHONE_NUMBER>1
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.04%) to 80.838%

Totals

Change from base Build<PHONE_NUMBER>4:
0.04%

Covered Lines:
8450

Relevant Lines:
10453

💛  - Coveralls

/cc @njtran @ellistarn
Please take a look

@njtran @ellistarn @jonathan-innis Recently, I have some free time. Can we continue this work


Short ID and exposes for privacy and compression improvements

In some cases, full path was exposed on module names, specially if you use mendel-manifest-extract-bundles on a bundle with node_modules inside of it.
This fixes this by changing both ids, expose and deps to remove:

Basedir
Anything before first "node_modules" string on path

In most cases both are the same, but since plugins can include shims on their source code (like browserify shims) checking for the first occurrence of node_modules improves the path normalization.

CLA is valid!

👍 Good!


Signify Roadmap

Signify is currently implemented in WebOfTrust/KERIA, WebOfTrust/Signifypy and WebOfTrust/signify-ts


Onboarding gas transfer

[x] user who sends an onboarding transaction will send gas to owner and operator keys of the new validator
[x] patch tests for balances on both sides.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 3 committers have signed the CLA.:white_check_mark: nelaturuk:x: lpgeiger:x: simsekgokhanlpgeiger seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


BarButtonItem action of controllers in controller array

I have vc1 and vc2. On vc1 I have a barbutton item. After starting to use pagemenu, barbutton item is not accessable. Is there a way to trigger the action of barbutton of vc1 while using pagemenu?

@ssaylanc have you got the solution for this?


Deploying via CI

What is the appropriate way of deploying via CI tool (e.g. Jenkins)? I have my project in github with the generated .gitignore. After clone, I use a headless script such as is below:
#!/bin/bash
set -e
IFS='|'

AWSCLOUDFORMATIONCONFIG="{\
\"configLevel\":\"general\",\
\"useProfile\":false\
}"
AMPLIFY="{\
\"envName\":\"master\"\
}"
PROVIDERS="{\
\"awscloudformation\":$AWSCLOUDFORMATIONCONFIG\
}"

amplify init \
--amplify $AMPLIFY \
--providers $PROVIDERS \
--yes

With init, this immediately triggers cloudformation updates, I think replacing the deployment bucket. Should I modify the .gitignore with something to prevent this?
If I instead try to pull, I get the following error
Failed to pull the backend.
TypeError: Cannot read property 'region' of undefined
    at Object.run (/usr/lib/node_modules/@aws-amplify/cli/node_modules/amplify-provider-awscloudformation/lib/attach-backend.js:18:81)
    at Object.attachBackend (/usr/lib/node_modules/@aws-amplify/cli/node_modules/amplify-provider-awscloudformation/index.js:29:3)

This approach works often, but it's completely inconsistent. When I run the script to deploy certain changes, it works fine, updating CloudFormation as expected. Other times, I get auth issues e.g.
Error: Profile configuration is missing for: default
    at Object.getProfiledAwsConfig (/usr/lib/node_modules/@aws-amplify/cli/node_modules/amplify-provider-awscloudformation/lib/system-config-manager.js:82:11)

Error: Unable to upload trigger files to S3
    at uploadFiles (/usr/lib/node_modules/@aws-amplify/cli/node_modules/amplify-category-auth/provider-utils/awscloudformation/utils/trigger-file-uploader.js:49:11)
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (internal/process/task_queues.js:94:5)

These occur directly after some CloudFormation updates have succeeded.

@steveparkerSG
I will check on those and if those were bugs, will send the fixes. Thanks for pointing them out.

The issue here is around how much amplify init does. It tries to do a full deploy, giving me no chance to run amplify pull before a deployment.
If I locally do an amplify pull for the enviroment and check-in the generated cloudformation stack files, then all is fine, but this is no kind of workflow at all. As it stands I'm better off doing local deploys.

Have you tried to run the amplify pull command in headless mode?
https://aws-amplify.github.io/docs/cli-toolchain/usage#amplify-pull-parameters
You can supplied the credentials and region in a profile and put in the headless command parameter

@UnleashedMind I gave up trying to make it work, it was just too inconsistent and difficult. I moved deploys into Amplify Console as suggested by @SwaySway, which has made my life a lot easier.

Closing this issue. @steveparkerSG Let us know if you have any issues deploying via the console.

@UnleashedMind
Please consider reopening this issue because "use Amplify Console" for CI is not a real solution. For example, my app needs to deploy to a Server-Side Rendering engine and I use next.js + now/vercel to do that. In order to use amplify env successfully, I have to be able to create a production aws-exports.js in CI and keep aws-exports.js in .gitignore.

"use Amplify Console" is not the solution for this. I get too many errors with amplify init trying to deploy before the stack is ready for it. Please decouple init and push so that we can get some decent deployment consistency or at least provide a flag for amplify init --no-push so that we can choose when we do that in our pipelines outside of Amplify Console, which is just not cutting it for advanced pipelines or if you are just deploying a backend without a web frontend.

For those coming here for examples with Jenkins or other CICD, I assume the doc linked below is the current interface.
https://docs.amplify.aws/cli/usage/headless


Support for destruction of group

Currently only supports creating a new group and getting an existing group, is it possible to provide a way to destroy an existing group?

No, it is not currently possible.
By destroy do you mean immediately free memory, or close network connections to peers?
Typically programs have a fixed number of groups (usually 1) for the lifetime of their program.
What is your use case?

In my program, I do not need to use groupcache as a distributed cache service, I just use groupcache as a cache library.
So I wish I can control the lifetime of the group, at the appropriate time, I hope to immediately free memory which used by the group.
Therefore, I hope groupcache package can provide a way to destroy the group which I previously created.

In that case, just lose a reference to it and it'll all be garbage collected. You don't need to shut it down or anything.

In my case,  I have some data that needs to be cached and the data will not change for a long time. When the cached data changes, I will be notified.
So, when notified, I want to destroy the previously created group object, freeing up the memory it occupies, and create a new group object to hold the new data.
I don't want to use memcached or redis to do this. If you have a better idea, you can tell me too.
Thanks very much @bradfitz

However, the created group object is saved in the global variable named groups, GC will free the memory it occupies even if not delete(groups, name)? Why?

Oh, true.
I really don't want to add new API to this, though. If you just want an LRU cache, there are a hundred on github / godoc.org. What makes groupcache interesting enough to use it by itself without peer nodes?

Mainly for this reason:

comes with a cache filling mechanism. Whereas memcached just says "Sorry, cache miss", often resulting in a thundering herd of database (or whatever) loads from an unbounded number of clients (which has resulted in several fun outages), groupcache coordinates cache fills such that only one load in one process of an entire replicated set of processes populates the cache, then multiplexes the loaded value to all callers.

It's brilliant.

Well, if you want that part, there is:
https://godoc.org/github.com/golang/groupcache/singleflight
Combine that with an LRU, and that's all you need?

OK, I will customize a cache library, reference groupcache implementation, thanks a lot. @bradfitz


Bluetooth devices get disabled after idling a few minutes

After a few minutes without moving my bluetooth mouse, it gets powered off.
According to the tlp manual, setting USB_EXCLUDE_BTUSB=1 in tlp.conf and kernel boot option btusb.enable_autosuspend=0 would work. However, it does not on my laptop.

Probably this helps.


[1.12] Quartz Unable To be Smelted Into Silicon

Issue description:
When adding nether quartz to a fueled furnace, silicon is not produced. The furnace remains inactive.
What happens:
A fueled furnace with nether quartz in the input slot remains inactive.
What you expected to happen:
Unless I'm mistaken, smelting nether quartz should produce silicon in a furnace.
Steps to reproduce:
1.Fuel a furnace
2.Insert nether quartz in the furnace's input slot
3.Observe that the quartz does not smelt into silicon
...
Version (make sure you are on the latest version before reporting):

Minecraft: 1.12
Forge:<IP_ADDRESS>3
Refined Storage:1.5.18

Does this issue occur on a server? [yes/no]
yes

Are you on the latest RS? Your earlier comment refers to RS 1.5.10.

i am using twitch

also i am using JEI and when i hover over a  item form RS It Says Tooltip Error. see log

You need to be on the latest RS version before you report things to me. Check the RS version by pressing thr mods button in MC.

I cannot reproduce this issue, your modpack is probably messed up, or you're running an outdated version of Refined Storage.