HDFS-17542. EC: Optimize the EC block reconstruction.

Description of PR
https://issues.apache.org/jira/browse/HDFS-17542
The current reconstruction process of EC blocks is based on the original contiguous blocks. It is mainly implemented through the work constructed by computeReconstructionWorkForBlocks. It can be roughly divided into three processes:

scheduleReconstruction
chooseTargets
validateReconstructionWork

For ordinary contiguous blocks:

(1) scheduleReconstruction
Select srcNodes as the source of the copy block according to the status of each replica of the block.
(2) chooseTargets
Select the target of the copy.
(3) validateReconstructionWork
Add the copy command to srcNode, srcNode receives the command through heartbeat, and executes the block copy from src to target.

For EC blocks:
(1) and (2) seems nearly same. However, whether to perform simple block copy or block reconstruction for EC blocks is determined in (3). And when some storage is busy, may result no work, it will lead to the problem described in HDFS-17516. Even if no block copying or block reconstruction is generated, pendingReconstruction and neededReconstruction will still be updated until the block times out, which wastes the scheduling opportunity.
Because the decision of whether to perform block copy or block reconstruction is made in (3), unnecessary liveBusyBlockIndices, and excludeReconstructedIndices are introduced. We know many bugs are related here. These should be avoided.
How was this patch tested?
unit test and test in cluster
For code changes:

Move the work of deciding whether to copy or reconstruct blocks from validateReconstructionWork to scheduleReconstruction.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
11m 42s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
45m  7s

trunk passed

+1 :green_heart:
compile
1m 20s

trunk passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2

+1 :green_heart:
compile
1m 15s

trunk passed with JDK Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08

+1 :green_heart:
checkstyle
1m 10s

trunk passed

+1 :green_heart:
mvnsite
1m 25s

trunk passed

+1 :green_heart:
javadoc
1m  7s

trunk passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2

+1 :green_heart:
javadoc
1m 49s

trunk passed with JDK Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08

+1 :green_heart:
spotbugs
3m 29s

trunk passed

+1 :green_heart:
shadedclient
37m 20s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m  9s

the patch passed

+1 :green_heart:
compile
1m 12s

the patch passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2

+1 :green_heart:
javac
1m 12s

the patch passed

+1 :green_heart:
compile
1m  4s

the patch passed with JDK Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08

+1 :green_heart:
javac
1m  4s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
1m  0s
/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs-project/hadoop-hdfs: The patch generated 5 new + 116 unchanged - 1 fixed = 121 total (was 117)

+1 :green_heart:
mvnsite
1m 17s

the patch passed

+1 :green_heart:
javadoc
0m 54s

the patch passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2

+1 :green_heart:
javadoc
1m 37s

the patch passed with JDK Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08

-1 :x:
spotbugs
3m 25s
/new-spotbugs-hadoop-hdfs-project_hadoop-hdfs.html
hadoop-hdfs-project/hadoop-hdfs generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

+1 :green_heart:
shadedclient
37m  0s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
231m 50s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 45s

The patch does not generate ASF License warnings.

384m 47s

Reason
Tests

SpotBugs
module:hadoop-hdfs-project/hadoop-hdfs

org.apache.hadoop.hdfs.server.blockmanagement.NumberReplicasStriped doesn't override org.apache.hadoop.hdfs.util.EnumCounters.equals(Object)  At NumberReplicasStriped.java:At NumberReplicasStriped.java:[line 1]

Failed junit tests
hadoop.hdfs.server.namenode.TestReconstructStripedBlocks

hadoop.hdfs.server.blockmanagement.TestDatanodeManager

Subsystem
Report/Notes

Docker
ClientAPI=1.46 ServerAPI=1.46 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6915/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6915

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 116b1dfefa0d 5.15.0-106-generic #116-Ubuntu SMP Wed Apr 17 09:17:56 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 535d712ba7485f2a5d70035c46a00867a26e6d4c

Default Java
Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6915/1/testReport/

Max. process+thread count
4086 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6915/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 30s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
44m 51s

trunk passed

+1 :green_heart:
compile
1m 22s

trunk passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2

+1 :green_heart:
compile
1m 20s

trunk passed with JDK Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08

+1 :green_heart:
checkstyle
1m 16s

trunk passed

+1 :green_heart:
mvnsite
1m 26s

trunk passed

+1 :green_heart:
javadoc
1m  8s

trunk passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2

+1 :green_heart:
javadoc
1m 43s

trunk passed with JDK Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08

+1 :green_heart:
spotbugs
3m 23s

trunk passed

+1 :green_heart:
shadedclient
36m 41s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 15s

the patch passed

+1 :green_heart:
compile
1m 18s

the patch passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2

+1 :green_heart:
javac
1m 18s

the patch passed

+1 :green_heart:
compile
1m 10s

the patch passed with JDK Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08

+1 :green_heart:
javac
1m 10s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
1m  5s
/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs-project/hadoop-hdfs: The patch generated 5 new + 116 unchanged - 1 fixed = 121 total (was 117)

+1 :green_heart:
mvnsite
1m 18s

the patch passed

+1 :green_heart:
javadoc
0m 56s

the patch passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2

+1 :green_heart:
javadoc
1m 36s

the patch passed with JDK Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08

-1 :x:
spotbugs
3m 28s
/new-spotbugs-hadoop-hdfs-project_hadoop-hdfs.html
hadoop-hdfs-project/hadoop-hdfs generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

+1 :green_heart:
shadedclient
37m 12s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
232m 52s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 46s

The patch does not generate ASF License warnings.

374m 37s

Reason
Tests

SpotBugs
module:hadoop-hdfs-project/hadoop-hdfs

org.apache.hadoop.hdfs.server.blockmanagement.NumberReplicasStriped doesn't override org.apache.hadoop.hdfs.util.EnumCounters.equals(Object)  At NumberReplicasStriped.java:At NumberReplicasStriped.java:[line 1]

Failed junit tests
hadoop.hdfs.server.blockmanagement.TestDatanodeManager

Subsystem
Report/Notes

Docker
ClientAPI=1.46 ServerAPI=1.46 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6915/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6915

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 37abfc76f55a 5.15.0-106-generic #116-Ubuntu SMP Wed Apr 17 09:17:56 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / f1ac383027accd5fea05f1a2fa9c07f89ff0d961

Default Java
Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6915/2/testReport/

Max. process+thread count
4217 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6915/2/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 29s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
45m 20s

trunk passed

+1 :green_heart:
compile
1m 22s

trunk passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2

+1 :green_heart:
compile
1m 17s

trunk passed with JDK Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08

+1 :green_heart:
checkstyle
1m 14s

trunk passed

+1 :green_heart:
mvnsite
1m 23s

trunk passed

+1 :green_heart:
javadoc
1m  8s

trunk passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2

+1 :green_heart:
javadoc
1m 48s

trunk passed with JDK Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08

+1 :green_heart:
spotbugs
3m 18s

trunk passed

+1 :green_heart:
shadedclient
35m 53s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

-1 :x:
mvninstall
0m 24s
/patch-mvninstall-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch failed.

-1 :x:
compile
0m 23s
/patch-compile-hadoop-hdfs-project_hadoop-hdfs-jdkUbuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2.txt
hadoop-hdfs in the patch failed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2.

-1 :x:
javac
0m 23s
/patch-compile-hadoop-hdfs-project_hadoop-hdfs-jdkUbuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2.txt
hadoop-hdfs in the patch failed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2.

-1 :x:
compile
0m 25s
/patch-compile-hadoop-hdfs-project_hadoop-hdfs-jdkPrivateBuild-1.8.0_412-8u412-ga-1~20.04.1-b08.txt
hadoop-hdfs in the patch failed with JDK Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08.

-1 :x:
javac
0m 25s
/patch-compile-hadoop-hdfs-project_hadoop-hdfs-jdkPrivateBuild-1.8.0_412-8u412-ga-1~20.04.1-b08.txt
hadoop-hdfs in the patch failed with JDK Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08.

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 58s
/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs-project/hadoop-hdfs: The patch generated 2 new + 116 unchanged - 1 fixed = 118 total (was 117)

-1 :x:
mvnsite
0m 26s
/patch-mvnsite-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch failed.

-1 :x:
javadoc
0m 24s
/patch-javadoc-hadoop-hdfs-project_hadoop-hdfs-jdkUbuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2.txt
hadoop-hdfs in the patch failed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2.

-1 :x:
javadoc
0m 24s
/patch-javadoc-hadoop-hdfs-project_hadoop-hdfs-jdkPrivateBuild-1.8.0_412-8u412-ga-1~20.04.1-b08.txt
hadoop-hdfs in the patch failed with JDK Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08.

-1 :x:
spotbugs
0m 24s
/patch-spotbugs-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch failed.

-1 :x:
shadedclient
11m 43s

patch has errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
0m 26s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch failed.

+1 :green_heart:
asflicense
0m 35s

The patch does not generate ASF License warnings.

105m 56s

Subsystem
Report/Notes

Docker
ClientAPI=1.46 ServerAPI=1.46 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6915/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6915

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux cb6430637470 5.15.0-106-generic #116-Ubuntu SMP Wed Apr 17 09:17:56 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / f6c32151b0cea8dd44057c009178f460b4721ef8

Default Java
Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6915/3/testReport/

Max. process+thread count
646 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6915/3/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 30s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

-1 :x:
mvninstall
45m  1s
/branch-mvninstall-root.txt
root in trunk failed.

+1 :green_heart:
compile
1m 21s

trunk passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2

+1 :green_heart:
compile
1m 15s

trunk passed with JDK Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08

+1 :green_heart:
checkstyle
1m 11s

trunk passed

+1 :green_heart:
mvnsite
1m 24s

trunk passed

+1 :green_heart:
javadoc
1m  8s

trunk passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2

+1 :green_heart:
javadoc
1m 45s

trunk passed with JDK Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08

+1 :green_heart:
spotbugs
3m 19s

trunk passed

+1 :green_heart:
shadedclient
36m 39s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 13s

the patch passed

+1 :green_heart:
compile
1m 13s

the patch passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2

+1 :green_heart:
javac
1m 13s

the patch passed

+1 :green_heart:
compile
1m  6s

the patch passed with JDK Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08

+1 :green_heart:
javac
1m  6s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 58s
/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs-project/hadoop-hdfs: The patch generated 2 new + 116 unchanged - 1 fixed = 118 total (was 117)

+1 :green_heart:
mvnsite
1m 14s

the patch passed

+1 :green_heart:
javadoc
0m 53s

the patch passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2

+1 :green_heart:
javadoc
1m 36s

the patch passed with JDK Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08

+1 :green_heart:
spotbugs
3m 17s

the patch passed

+1 :green_heart:
shadedclient
35m 50s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
230m 14s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 46s

The patch does not generate ASF License warnings.

369m 52s

Reason
Tests

Failed junit tests
hadoop.hdfs.server.blockmanagement.TestDatanodeManager

Subsystem
Report/Notes

Docker
ClientAPI=1.46 ServerAPI=1.46 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6915/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6915

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 0d928807140a 5.15.0-106-generic #116-Ubuntu SMP Wed Apr 17 09:17:56 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 06e85b609514d17ff6ca9236f4915c10569594e1

Default Java
Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6915/4/testReport/

Max. process+thread count
4020 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6915/4/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@ayushtkn @Hexiaoqiao @tasanuma @zhangshuyan0
Can you please review this PR?

Failed unit test: org.apache.hadoop.hdfs.server.blockmanagement.testGetBlockLocationConsiderStorageType is not related, will be fixed in https://github.com/apache/hadoop/pull/6919.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
11m 36s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
44m 24s

trunk passed

+1 :green_heart:
compile
1m 20s

trunk passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04

+1 :green_heart:
compile
1m 17s

trunk passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05

+1 :green_heart:
checkstyle
1m 11s

trunk passed

+1 :green_heart:
mvnsite
1m 26s

trunk passed

+1 :green_heart:
javadoc
1m  8s

trunk passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04

+1 :green_heart:
javadoc
1m 45s

trunk passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05

+1 :green_heart:
spotbugs
3m 21s

trunk passed

+1 :green_heart:
shadedclient
36m 46s

branch has no errors when building and testing our client artifacts.

-0 :warning:
patch
37m  8s

Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

-1 :x:
mvninstall
0m 50s
/patch-mvninstall-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch failed.

-1 :x:
compile
0m 54s
/patch-compile-hadoop-hdfs-project_hadoop-hdfs-jdkUbuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04.txt
hadoop-hdfs in the patch failed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04.

-1 :x:
javac
0m 54s
/patch-compile-hadoop-hdfs-project_hadoop-hdfs-jdkUbuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04.txt
hadoop-hdfs in the patch failed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04.

-1 :x:
compile
0m 51s
/patch-compile-hadoop-hdfs-project_hadoop-hdfs-jdkPrivateBuild-1.8.0_422-8u422-b05-1~20.04-b05.txt
hadoop-hdfs in the patch failed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05.

-1 :x:
javac
0m 51s
/patch-compile-hadoop-hdfs-project_hadoop-hdfs-jdkPrivateBuild-1.8.0_422-8u422-b05-1~20.04-b05.txt
hadoop-hdfs in the patch failed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05.

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 58s
/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs-project/hadoop-hdfs: The patch generated 2 new + 116 unchanged - 1 fixed = 118 total (was 117)

-1 :x:
mvnsite
0m 53s
/patch-mvnsite-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch failed.

+1 :green_heart:
javadoc
0m 54s

the patch passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04

+1 :green_heart:
javadoc
1m 41s

the patch passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05

-1 :x:
spotbugs
0m 50s
/patch-spotbugs-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch failed.

-1 :x:
shadedclient
15m  9s

patch has errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
0m 54s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch failed.

+1 :green_heart:
asflicense
0m 35s

The patch does not generate ASF License warnings.

122m 29s

Subsystem
Report/Notes

Docker
ClientAPI=1.46 ServerAPI=1.46 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6915/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6915

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 2b521ab8b6c1 5.15.0-117-generic #127-Ubuntu SMP Fri Jul 5 20:13:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / ea04f95213fc474e73bcad5ae832f026d134026b

Default Java
Private Build-1.8.0_422-8u422-b05-1~20.04-b05

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_422-8u422-b05-1~20.04-b05

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6915/1/testReport/

Max. process+thread count
680 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6915/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
12m 15s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
45m 21s

trunk passed

+1 :green_heart:
compile
1m 21s

trunk passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04

+1 :green_heart:
compile
1m 17s

trunk passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05

+1 :green_heart:
checkstyle
1m 10s

trunk passed

+1 :green_heart:
mvnsite
1m 27s

trunk passed

+1 :green_heart:
javadoc
1m 10s

trunk passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04

+1 :green_heart:
javadoc
1m 45s

trunk passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05

+1 :green_heart:
spotbugs
3m 18s

trunk passed

+1 :green_heart:
shadedclient
36m 12s

branch has no errors when building and testing our client artifacts.

-0 :warning:
patch
36m 33s

Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 11s

the patch passed

+1 :green_heart:
compile
1m 15s

the patch passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04

+1 :green_heart:
javac
1m 15s

the patch passed

+1 :green_heart:
compile
1m  7s

the patch passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05

+1 :green_heart:
javac
1m  7s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 58s
/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs-project/hadoop-hdfs: The patch generated 2 new + 116 unchanged - 1 fixed = 118 total (was 117)

+1 :green_heart:
mvnsite
1m 18s

the patch passed

+1 :green_heart:
javadoc
0m 54s

the patch passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04

+1 :green_heart:
javadoc
1m 38s

the patch passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05

+1 :green_heart:
spotbugs
3m 17s

the patch passed

+1 :green_heart:
shadedclient
36m 11s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
218m 12s

hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 47s

The patch does not generate ASF License warnings.

370m 25s

Subsystem
Report/Notes

Docker
ClientAPI=1.46 ServerAPI=1.46 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6915/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6915

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 2c8155d72793 5.15.0-117-generic #127-Ubuntu SMP Fri Jul 5 20:13:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / dd74849c9d24bac57b6496f075803d75b0cc2c8d

Default Java
Private Build-1.8.0_422-8u422-b05-1~20.04-b05

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_422-8u422-b05-1~20.04-b05

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6915/2/testReport/

Max. process+thread count
4104 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6915/2/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@ayushtkn @Hexiaoqiao @zhangshuyan0 @haiyang1987 @tasanuma
Now that all yetus errors have been fixed, Can you please review this PR?


Insert time/date

Hi,
I have a feature request: Why not add the ability to use the current time and date in the template? For example %D could be the day of the month and %DD the day of the month with a leading zero etc. That way you wouldn't need to mess with locales and everyone could build their own date format:
%MM/%DD/%YY, %h:%mm %a%\n
%YYYY-%MM-%DD, %hh:%mm

Would result in:

06/27/24, 9:03 am
2024-06-27, 09:03

Thank you for this nice plugin. Keep up the great work, I enjoy it very much!
Cheers,
Proedie

+1 would love this as well.


Config Wizard page for Display tab, X-Plane action, hides the value expression, preventing entry

This is a GUI issue which prevents entry of the expression value for X-Plane presets. A hack workaround is to type a value into the generated MCC file, then load it. This works, but is quite annoying.
Steps to reproduce

Create any Output Config
Click ... to open Config Wizard
Open the Display tab
Under Display Type, select Input Action and OnChange
Under On Change, select Action Type of X-Plane (all versions)
Select any preset
Check the box "Show Preset Code"
The expected value field with corresponding "hint" that reads "supports input value ...." is not visible, so no value can be entered.

I noticed that the graphic lines stop, so I think the fix is a matter of enlarging the graphical window so that the field is viewable/editable.

Thanks for reporting, this is a duplicate of #1050 which is already fixed


Video for Chapter 0: Introducing UMH with IT/OT basics

Video for Chapter 0: Introducing UMH with IT/OT basics (+ target state (Grafana Dashboard, Node-RED, Kubernetes) to enable easy entry.
Important for a consistent didactic approach as described in #455

Is this fixed by the currently published videos ?


Create NullLatentModel

          > I think I've nearly fully addressed this concern. Where we might be missing something is not having a NullLatentModel type which just generates nothing values. I wanted to leave the option open for the ODE models to be conditional on a latent process outcome, e.g. as per a Renewal model, but that is not currently used. A nothing returning process would let us use the current infra for model specification.

Good idea
Originally posted by @seabbs in https://github.com/CDCgov/Rt-without-renewal/issues/510#issuecomment-2468572438
As discussed here, this would be an easy and handy feature.

It also makes resolving #526 smoother, because we can reuse the EpiProblem pattern.

Yes good point


Accessibility: use of colour in cards

When looking at accessibility per rancher/dashboard#4324, we have a problem with colour usage is on “cards” with the top line colour coded. This page does not provide additional information to explain the difference in card colours (the line on top that can be blue, yellow or red), only after opening the dropdown
Below, you will find a screenshot for quick reference:

Even if the dropdown was always open, the criteria would still fail since users that depend on SR would not be able to read the references.

Suggested solution:

Add an aria-label with the description associated description to each of the cards. For example, a yellow card should have the aria-label=”Partner providers/services/cluster”. We recommend that there is more context than just the words “rancher”, “partners”, or “RKE2” so the user understands exactly to what they refer. This lines up with an overall suggestion to rely on an aria-label in each <div> to describe the category type for assistive technologies.

Related:
https://xd.adobe.com/view/66c03ec6-d686-44f5-a6b6-ed33e6975f90-3393/
https://github.com/rancher/dashboard/issues/5007

Can't do this until #5007 is done

This is part of the accessibility improvement list and is ready for implementation (add aria-labels as appropriate throughout the ui)

This require a new card design which takes into account ALL possible information which should be included in cards.
Off the top of my head, this includes: Icon, Name, Version, Description, OS, Beta-status, and Type/Source

This is solved in the redesign done by Edén.


Update to gradle 7

Current script is incompatible with latest gradle.
Didn't test publising, but build works

Yes, the properties should be defined even for build or any other task.
People who are not publishing define any dummy values.
чт, 16 сент. 2021 г., 02:17 Yan Pashkovsky @.***>:

@.**** commented on this pull request.
In build.gradle
https://github.com/dzmipt/kdbStudio/pull/93#discussion_r709640245:

                 }

             }
         }
     }
 }

repositories {

   maven {

       url "https://oss.sonatype.org/service/local/staging/deploy/maven2/"

       mavenContent {

           releasesOnly()

       }

   }

   maven {

       url "https://oss.sonatype.org/content/repositories/snapshots/"

       mavenContent {

           snapshotsOnly()

       }

   }

}

Will look at it. Are these properties required to be set (even if you are
not going to publish anything) in $HOME/.gradle/gradle.properties?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/dzmipt/kdbStudio/pull/93#discussion_r709640245, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AG76OVUOLUJWVWI24XBBVJTUCESSLANCNFSM5EBDIODQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

Added gradle wrapper to VCS as it's common practise. This way we fix gradle version that everybody will use.

Thanks @Yanpas !


AppEc2QueueSize Usage

Hello there!
Is AppEc2QueueSize actually used anywhere? From a quick repo scan it looks like its only ever referenced in the CF stack. I also can't find any AWS Quota that matches that restriction. Thanks!

It is used as RUNS_ON_EC2_QUEUE_SIZE in the code, and serves as the queue size for rate limiting RunInstances API calls

Gotcha, and do you generally recommend we ask AWS to increase this param? In other words is the default limit of 2 a bottleneck for most cases?

Really depends on your max number of concurrent jobs. If you need to launch more than 10-20 runners at a time, it would be best to ask for an increase yes, otherwise the delay will start to be noticeable.
For many use cases the default is fine though.

Ah I'm seeing this now: https://docs.aws.amazon.com/ec2/latest/devguide/ec2-api-throttling.html#throttling-increase
I wonder if there's some log or metric we can monitor to see if we're hitting that rate limit threshold often?


test: convert rm -rf && mkdir -p into %empty-directory

This converts the instances of the pattern for which we have a proper
substitution in lit.  This will make it easier to replace it
appropriately with Windows equivalents.

Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

Resolves SR-NNNN.

@swift-ci please test and merge

@gribozavr, @gottesmm: probably makes you two happy :-)

CC: @Rostepher

@swift-ci please test and merge

I greatly appreciate this PR! Thanks for cleaning this up.

Build failed
Swift Test OS X Platform
Git Sha - 106392e581278b3209bd10af915b025632aff239

Build failed
Swift Test Linux Platform
Git Sha - 106392e581278b3209bd10af915b025632aff239

Sure thing!  Okay, the failures are "valid".  The file content changes has changed offsets.  I'll adjust that accordingly.

@swift-ci please test

Build failed
Swift Test Linux Platform
Git Sha - 8b67dcb490af986b1f6bea5a3b181bd1811eb6a5

Build failed
Swift Test OS X Platform
Git Sha - 8b67dcb490af986b1f6bea5a3b181bd1811eb6a5


Are integers cast to BigInt by default with node-odbc?

I'm trying to understand why I'm having BigInt for every result. Does some kind of coercion happening under the hood?
For example I make simple query with DBeaver and with node-odbc
SELECT appId FROM applications LIMIT 1; where appId is integer type
Result with Dbeaver: 1
Results with node-odbc: 1n
This n is added for every integer I have.
I'm not sure that the reason is node-odbc and asking this question because I'm stuck and don't have any ideas.
I'm using ("odbc": "^2.4.4",) for nodejs(nestjs) project with next configurations inside docker
FROM node:14.19.3

COPY . /server

WORKDIR /server

#downloading the relevant linux driver for this docker environment
RUN tar vzxf ./docker/nodejs/odbc/vertica-client-11.1.1-0.x86_64.tar.gz && rm ./docker/nodejs/odbc/vertica-client-11.1.1-0.x86_64.tar.gz
RUN apt update && apt install -y unixodbc-dev=2.3.4-1

RUN DOWNLOAD=1 yarn install
RUN yarn global add @nestjs/cli
RUN yarn global add cross-env

ENTRYPOINT ["yarn", "start:dev"]

My odbc.ini file inside docker has same configurations as my odbc.ini file on host machine.
P.S. I found out that this behaviour was added in [2.1.0] - 2019-08-02 Added support for JavaScript BigInt binding to SQL_BIGINT
Can I disable somehow this behaviour?

Ah, here's why:

INT, INTEGER, INT8, SMALLINT, TINYINT, and BIGINT are all synonyms for the same signed 64-bit integer data type

So your INTEGER field is actually a BIGINT field.


WindowsError: [Error 2] The system cannot find the file specified

Plex && bw_plex environment:
Windows 10 Pro 1809
Plex Server for windows Version <IP_ADDRESS>88
latest pip update from bw_plex git
watching plex playback on firefox 65.0.1
The file being read / passed to ffmpeg contains spaces. So this possibly is related to ticket: #54
bw_plex was launched via powershell with admin rights with the following input:
bw_plex --username [user] --password [pass] --servername [servername] --url [url] watch

I get the title error after starting up bw_plex, relevant log details below;
2019-02-24 10:01:58,007 :: bw_plex :: INFO :: __init__.py:162 :: default folder set to C:\Users\<user>/.config/bw_plex
2019-02-24 10:02:03,513 :: bw_plex :: DEBUG :: misc.py:64 :: Getting server <server>
2019-02-24 10:02:03,513 :: bw_plex :: DEBUG :: misc.py:625 :: Getting hashtable
2019-02-24 10:02:03,605 :: bw_plex :: INFO :: misc.py:711 :: Loading existing files in db
2019-02-24 10:02:06,016 :: bw_plex :: DEBUG :: misc.py:640 :: Files in the hashtable
Watching for media on <server>
2019-02-24 10:02:13,710 :: bw_plex :: DEBUG :: plex.py:1024 :: Failed to find ratingkey 4867 in the db
2019-02-24 10:02:13,726 :: bw_plex :: DEBUG :: plex.py:897 :: Found <episode>
2019-02-24 10:02:13,726 :: bw_plex :: DEBUG :: plex.py:902 :: Download the first 10 minutes of <episode> as .wav
2019-02-24 10:02:13,726 :: bw_plex :: DEBUG :: plex.py:727 :: Checking if we can reach <episode> directly
2019-02-24 10:02:13,726 :: bw_plex :: DEBUG :: plex.py:738 :: Found S:\Plex\TV\<show>\<season>\<episode>.mkv
2019-02-24 10:02:13,730 :: bw_plex :: DEBUG :: misc.py:380 :: calling ffmpeg with ffmpeg -i "S:\Plex\TV\<show>\<season>\<episode>.mkv" -ac 1 -ar 11025 -ss 0 -t 600 -acodec pcm_s16le c:\users\<user>\appdata\local\temp\offset_5gwnrl.wav
2019-02-24 10:02:13,734 :: bw_plex :: ERROR :: plex.py:48 :: There was an exception in task
Traceback (most recent call last):
  File "c:\users\<user>\src\bw-plex\bw_plex\plex.py", line 43, in inner
    return func(*args)
  File "c:\users\<user>\src\bw-plex\bw_plex\plex.py", line 904, in task
    trim=CONFIG['tv'].get('check_for_theme_sec', 600))
  File "c:\users\<user>\src\bw-plex\bw_plex\misc.py", line 385, in convert_and_trim
    psox = subprocess.Popen(cmd, stderr=subprocess.PIPE)
  File "c:\python27\lib\subprocess.py", line 394, in __init__
    errread, errwrite)
  File "c:\python27\lib\subprocess.py", line 644, in _execute_child
    startupinfo)
WindowsError: [Error 2] The system cannot find the file specified

Sorry for the late response. I didnt get notified.
ffmeg need to be available in the system. What they mean by that is that you should be able to use cmd.exe and do ffmpeg and should get some kind of output.

Yeah sorry @Hellowlol my account got flagged for spam and they deleted my latest update that showed I did get ffmpeg installed properly and it was finally working with bw_plex.
Unfortunately, skips are not actually working still.  Trying a hail marry.
2019-03-01 18:11:39,753 :: bw_plex :: INFO :: plex.py:835 :: Connectiong to Firefox
2019-03-01 18:11:39,755 :: bw_plex :: ERROR :: plex.py:48 :: There was an exception in client_action
Traceback (most recent call last):
  File "c:\users\<user>\src\bw-plex\bw_plex\plex.py", line 43, in inner
    return func(*args)
  File "c:\users\<user>\src\bw-plex\bw_plex\plex.py", line 838, in client_action
    requests.exceptions.ConnectionRefusedError):
AttributeError: 'module' object has no attribute 'ConnectionRefusedError'

Thanks for the catch. It’s a bug. I’ll fix this later.

Sorry for the delay @Hellowlol. I got the latest and skips seem to be sending now, which is great! However I'm still seeing an exception (though it's not causing problems so far). This happens right after a successful skip send.
2019-03-08 20:46:38,006 :: bw_plex :: ERROR :: plex.py:48 :: There was an exception in client_action
Traceback (most recent call last):
  File "c:\src\bw-plex\bw_plex\plex.py", line 43, in inner
    return func(*args)
  File "c:\src\bw-plex\bw_plex\plex.py", line 854, in client_action
    proxy_on_fail(correct_client.seekTo(int(offset * 1000)))
  File "c:\src\bw-plex\bw_plex\plex.py", line 772, in proxy_on_fail
    @wraps(func)
  File "c:\python27\lib\functools.py", line 33, in update_wrapper
    setattr(wrapper, attr, getattr(wrapped, attr))
AttributeError: 'NoneType' object has no attribute '__module__'

Thanks. Ill fix that bug. Closing this as the original bug was fixed. Let me know if you have any more issues


Remove trailing whitespace from comment

I decided to make a PR instead, so we can make sure it's actually fixed.

Sorry...  Thanks for fixing this.


Currently the first mani sync fails partially - next execution works

I have a mani.yml file which contain a number of repositories (113) which can be cloned without entering credentials.
Also it works without any issue if I use mani sync --parallel=false which indicates there is some kind of issue related to the parallel execution.
What I have also observed is that only 2 cores seemed to be used instead of the available ones (this is less important)..
If you need more information please ping me

Hi, sorry for the late response, I did some updates to the sync commands (parallel and sync). Now parallel sync should provide some output, let me know if works for you.

I could reproduce the error now and I think I know where it is, will look into providing a patch soon.

Released a patch, https://github.com/alajmo/mani/releases/tag/v0.20.1, the issue was with git opening many file descriptors, fork/exec /usr/bin/git: too many open files, so I limited the number of projects to sync in parallel to 20 at a time. I'll close the issue for now, and if it resurfaces I'll have to lower the number of projects to sync.

Released a patch, https://github.com/alajmo/mani/releases/tag/v0.20.1, the issue was with git opening many file descriptors, fork/exec /usr/bin/git: too many open files, so I limited the number of projects to sync in parallel to 20 at a time. I'll close the issue for now, and if it resurfaces I'll have to lower the number of projects to sync.


ci!: edit semantic release config

still trying to figure out why major version is not updating despite having a BREAKING CHANGE in the commit footer

remove parserOpts to see if breaking change commit will increment the major version

:tada: This PR is included in version 2.7.1 :tada:
The release is available on:

GitHub release
npm package (@latest dist-tag)

Your semantic-release bot :package::rocket:


iOS build failed

/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang++ -o drivers/unix/thread_posix.iphone.debug.o -c -fno-objc-arc -arch armv7 -fmessage-length=0 -fno-strict-aliasing -fdiagnostics-print-source-range-info -fdiagnostics-show-category=id -fdiagnostics-parseable-fixits -Wno-trigraphs -fpascal-strings -Wmissing-prototypes -Wreturn-type -Wparentheses -Wswitch -Wno-unused-parameter -Wunused-variable -Wunused-value -Wno-shorten-64-to-32 -isysroot /Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS5.0.sdk -gdwarf-2 -fvisibility=hidden -Wno-sign-conversion -mthumb "-DIBOutlet=__attribute__((iboutlet))" "-DIBOutletCollection(ClassName)=__attribute__((iboutletcollection(ClassName)))" "-DIBAction=void)__attribute__((ibaction)" -miphoneos-version-min=5.1.1 -MMD -MT dependencies -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS.sdk/ -D_DEBUG -DDEBUG=1 -gdwarf-2 -Wall -O0 -DDEBUG_ENABLED -DDEBUG_MEMORY_ALLOC -DSCI_NAMESPACE -fblocks -DPLATFORM_SERVICES -fblocks -DGAME_CENTER_ENABLED -DSTOREKIT_ENABLED -DICLOUD_ENABLED -DDEBUG_MEMORY_ENABLED -DIPHONE_ENABLED -DUNIX_ENABLED -DGLES2_ENABLED -DMPC_FIXED_POINT -fexceptions -DMUSEPACK_ENABLED -DOPENSSL_ENABLED -DSQUISH_ENABLED -DVORBIS_ENABLED -DOPUS_ENABLED -DTHEORA_ENABLED -DTHEORALIB_ENABLED -DPNG_ENABLED -DDDS_ENABLED -DPVR_ENABLED -DJPG_ENABLED -DWEBP_ENABLED -DSPEEX_ENABLED -DGDSCRIPT_ENABLED -DMINIZIP_ENABLED -DXML_ENABLED -DETC1_ENABLED -DPNG_ARM_NEON_OPT=0 -DOPENSSL_NO_ASM -DOPENSSL_THREADS -DL_ENDIAN -Icore -Icore/math -Itools -Idrivers -I. -Iplatform/iphone -Iplatform/iphone/include -I/Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS.sdk/usr/include -I/Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS.sdk/System/Library/Frameworks/OpenGLES.framework/Headers -I/Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS.sdk/System/Library/Frameworks/AudioUnit.framework/Headers -Idrivers/builtin_openssl2 -Idrivers/builtin_zlib/zlib -Idrivers/unix/vorbis -Idrivers/builtin_openssl2/crypto -Idrivers/builtin_openssl2/openssl -Idrivers/builtin_openssl2/crypto/evp -Idrivers/builtin_openssl2/crypto/asn1 -Idrivers/builtin_openssl2/crypto/modes drivers/unix/thread_posix.cpp
drivers/unix/thread_posix.cpp:103:12:{103:12-103:30}: error: no matching function for call to 'pthread_setname_np' [2]
        int err = pthread_setname_np(pthread, p_name.utf8().get_data());
                   ^~~~~~~~~~~~~~~~~~
/Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS.sdk/usr/include/pthread.h:474:5: note: candidate function not viable: requires 1 argument, but 2 were provided [2]
 int    pthread_setname_np(const char*);
         ^
1 error generated.
scons: *** [drivers/unix/thread_posix.iphone.debug.o] Error 1
scons: building terminated because of errors.

This error with named threads..

Which commit are you trying to compile?

Latest from master

Did we fix this last week?
On 28 December 2015 at 06:46, Max<EMAIL_ADDRESS>wrote:

Latest from master
—
Reply to this email directly or view it on GitHub
https://github.com/godotengine/godot/issues/3148#issuecomment-167528199.

That's what I supposed, but I assume that by "Latest from master" @ealataur meant today's HEAD.

Do you still have this issue @ealataur?

I will check tomorrow..

bash-3.2$ scons platform=iphone b=32 -j5
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: servers/libservers.iphone.debug.a(voice_rb_sw.iphone.debug.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang++ -o core/globals.iphone.debug.o -c -fno-objc-arc -arch armv7 -fmessage-length=0 -fno-strict-aliasing -fdiagnostics-print-source-range-info -fdiagnostics-show-category=id -fdiagnostics-parseable-fixits -Wno-trigraphs -fpascal-strings -Wmissing-prototypes -Wreturn-type -Wparentheses -Wswitch -Wno-unused-parameter -Wunused-variable -Wunused-value -Wno-shorten-64-to-32 -isysroot /Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS5.0.sdk -fvisibility=hidden -Wno-sign-conversion -mthumb "-DIBOutlet=attribute((iboutlet))" "-DIBOutletCollection(ClassName)=attribute((iboutletcollection(ClassName)))" "-DIBAction=void)attribute((ibaction)" -miphoneos-version-min=5.1.1 -MMD -MT dependencies -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS.sdk/ -D_DEBUG -DDEBUG=1 -gdwarf-2 -Wall -O0 -DDEBUG_ENABLED -DDEBUG_MEMORY_ALLOC -DSCI_NAMESPACE -fblocks -DPLATFORM_SERVICES -fblocks -DGAME_CENTER_ENABLED -DSTOREKIT_ENABLED -DICLOUD_ENABLED -DDEBUG_MEMORY_ENABLED -DIPHONE_ENABLED -DUNIX_ENABLED -DGLES2_ENABLED -DMPC_FIXED_POINT -fexceptions -DMUSEPACK_ENABLED -DOPENSSL_ENABLED -DSQUISH_ENABLED -DVORBIS_ENABLED -DOPUS_ENABLED -DTHEORA_ENABLED -DTHEORALIB_ENABLED -DPNG_ENABLED -DDDS_ENABLED -DPVR_ENABLED -DJPG_ENABLED -DWEBP_ENABLED -DSPEEX_ENABLED -DGDSCRIPT_ENABLED -DMINIZIP_ENABLED -DXML_ENABLED -DETC1_ENABLED -DPNG_ARM_NEON_OPT=0 -DOPENSSL_NO_ASM -DOPENSSL_THREADS -DL_ENDIAN -Icore -Icore/math -Itools -Idrivers -I. -Iplatform/iphone -Iplatform/iphone/include -I/Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS.sdk/usr/include -I/Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS.sdk/System/Library/Frameworks/OpenGLES.framework/Headers -I/Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS.sdk/System/Library/Frameworks/AudioUnit.framework/Headers -Idrivers/builtin_openssl2 -Idrivers/builtin_zlib/zlib -Icore/vorbis -Idrivers/builtin_openssl2/crypto -Idrivers/builtin_openssl2/openssl -Idrivers/builtin_openssl2/crypto/evp -Idrivers/builtin_openssl2/crypto/asn1 -Idrivers/builtin_openssl2/crypto/modes core/globals.cpp
core/global_defaults.cpp:8:2: error: use of undeclared identifier 'register_iphone___global_defaults'; did you mean 'register_iphone_global_defaults'? [2]
register_iphone___global_defaults();
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
register_iphone_global_defaults
fix-it:"core/global_defaults.cpp":{8:2-8:35}:"register_iphone_global_defaults"
./platform/iphone__/globals/global_defaults.h:3:6: note: 'register_iphone_global_defaults' declared here [2]
void register_iphone_global_defaults();
^
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang++ -o core/image.iphone.debug.o -c -fno-objc-arc -arch armv7 -fmessage-length=0 -fno-strict-aliasing -fdiagnostics-print-source-range-info -fdiagnostics-show-category=id -fdiagnostics-parseable-fixits -Wno-trigraphs -fpascal-strings -Wmissing-prototypes -Wreturn-type -Wparentheses -Wswitch -Wno-unused-parameter -Wunused-variable -Wunused-value -Wno-shorten-64-to-32 -isysroot /Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS5.0.sdk -fvisibility=hidden -Wno-sign-conversion -mthumb "-DIBOutlet=attribute((iboutlet))" "-DIBOutletCollection(ClassName)=attribute((iboutletcollection(ClassName)))" "-DIBAction=void)attribute((ibaction)" -miphoneos-version-min=5.1.1 -MMD -MT dependencies -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS.sdk/ -D_DEBUG -DDEBUG=1 -gdwarf-2 -Wall -O0 -DDEBUG_ENABLED -DDEBUG_MEMORY_ALLOC -DSCI_NAMESPACE -fblocks -DPLATFORM_SERVICES -fblocks -DGAME_CENTER_ENABLED -DSTOREKIT_ENABLED -DICLOUD_ENABLED -DDEBUG_MEMORY_ENABLED -DIPHONE_ENABLED -DUNIX_ENABLED -DGLES2_ENABLED -DMPC_FIXED_POINT -fexceptions -DMUSEPACK_ENABLED -DOPENSSL_ENABLED -DSQUISH_ENABLED -DVORBIS_ENABLED -DOPUS_ENABLED -DTHEORA_ENABLED -DTHEORALIB_ENABLED -DPNG_ENABLED -DDDS_ENABLED -DPVR_ENABLED -DJPG_ENABLED -DWEBP_ENABLED -DSPEEX_ENABLED -DGDSCRIPT_ENABLED -DMINIZIP_ENABLED -DXML_ENABLED -DETC1_ENABLED -DPNG_ARM_NEON_OPT=0 -DOPENSSL_NO_ASM -DOPENSSL_THREADS -DL_ENDIAN -Icore -Icore/math -Itools -Idrivers -I. -Iplatform/iphone -Iplatform/iphone/include -I/Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS.sdk/usr/include -I/Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS.sdk/System/Library/Frameworks/OpenGLES.framework/Headers -I/Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS.sdk/System/Library/Frameworks/AudioUnit.framework/Headers -Idrivers/builtin_openssl2 -Idrivers/builtin_zlib/zlib -Icore/vorbis -Idrivers/builtin_openssl2/crypto -Idrivers/builtin_openssl2/openssl -Idrivers/builtin_openssl2/crypto/evp -Idrivers/builtin_openssl2/crypto/asn1 -Idrivers/builtin_openssl2/crypto/modes core/image.cpp
1 error generated.
scons: *** [core/global_defaults.iphone.debug.o] Error 1
core/image.cpp:1655:10: warning: 21 enumeration values not handled in switch: 'FORMAT_GRAYSCALE', 'FORMAT_INTENSITY', 'FORMAT_GRAYSCALE_ALPHA'... [-Wswitch,2]
switch(format) {
^
1 warning generated.
scons: building terminated because of errors.

Did you rename platform/iphone to platform/iphone__ yourself?

Not rename.. It is duplicate of folder with my own fixes

You need to fix this line then: https://github.com/godotengine/godot/blob/0c3386b2ed7c3791127e2b12a2227deddad96ae5/core/SCsub#L12

But please try to build the main platform/iphone from git to confirm if the bug reported initially is fixed. It's harder to debug your own copy of the code ;) (and out of the scope of this issue tracker)

Ok. Without my duplicate folder all compiles done. Sorry..
I have some features for iphone platform. And i want commit it in main tree. How I can do it? I tested this features on device and all ok

Ok. Without my duplicate folder all compiles done. Sorry..

Thanks, closing the issue then as it was likely fixed by what @punto- mentioned earlier.

I have some features for iphone platform. And i want commit it in main tree. How I can do it? I tested this features on device and all ok

To do this you would have to make a "pull request".

You need first to fork the main Godot repository by clicking the "Fork" button in the GitHub interface.
Then you can clone your own fork locally with git clone https://github.com/ealataur/godot (or alternatively add a custom "remote" to your existing clone of the godotengine/godot repo - but if you are not experienced with git I would advise you to do the first suggestion)
In your freshly forked and cloned repository, you can then copy you changes on top of the upstream files. By running git diff, it should show you all the changes that you made in the form of diffs/patches. If it looks good, you can commit the changes.
To commit, add all your changes with git add, for example if you only changed files in platform/iphone, you can do git add platform/iphone. git status should show you what files are currently "added".
Once all relevant files are "added", you can make a commit with git commit. It should open a text editor where you will write the commit log which should explain what your changes bring. Don't hesitate to write a complete paragraph if need be (just make the first line short like a "title", and then add more details in the following lines).
After saving and closing the editor, it should have committed your changes locally. You can check with git log and git show. Then you can push your changes to your remote fork with git push - on the GitHub interface for your online repo, it should now show that you are one commit (or more, if you made several commits) ahead of godotengine/master (and maybe some commits behind if new stuff was pushed to the main repo in the meantime, but that's usually not an issue). You can then click the "Pull request" button to make a request to automatically merge your changes in the main repo.

Ok. Thank you


SW-3626 Storybook Integration

Added storybook using npx storybook init
Correctly initialize theme in preview.tsx
Add a story for the TfMain component to prove things are working

Ack, the build is broken for the app now 😭 digging into this

So the webpack dependency addition was causing a different error locally. Taking that out solved local build. However, the Vercel deploy still failed. I updated the node version Vercel is using to 16 and attempting to redeploy...

So the webpack dependency addition was causing a different error locally. Taking that out solved local build. However, the Vercel deploy still failed. I updated the node version Vercel is using to 16 and attempting to redeploy...

Ok 🤞

So the webpack dependency addition was causing a different error locally. Taking that out solved local build. However, the Vercel deploy still failed. I updated the node version Vercel is using to 16 and attempting to redeploy...

And it worked! 🎉


Urls are not allowed in dev dependencies

The following fails:
[project]
name = "foo"
version = "0.4.0"
requires-python = ">=3.12"

[tool.uv]
dev-dependencies = [
  "tqdm @ https://files.pythonhosted.org/packages/18/eb/fdb7eb9e48b7b02554e1664afd3bd3f117f6b6d6c5881438a0b055554f9b/tqdm-4.66.4-py3-none-any.whl",
]

$ uv lock --preview
error: Package `tqdm` attempted to resolve via URL: https://files.pythonhosted.org/packages/18/eb/fdb7eb9e48b7b02554e1664afd3bd3f117f6b6d6c5881438a0b055554f9b/tqdm-4.66.4-py3-none-any.whl. URL dependencies must be expressed as direct requirements or constraints. Consider adding `tqdm @ https://files.pythonhosted.org/packages/18/eb/fdb7eb9e48b7b02554e1664afd3bd3f117f6b6d6c5881438a0b055554f9b/tqdm-4.66.4-py3-none-any.whl` to your dependencies or constraints file.

I assume the the lookahead resolver is missing for dev deps.
Meanwhile, this works:
[project]
name = "foo"
version = "0.4.0"
requires-python = ">=3.12"
dependencies = [
  "tqdm >=4.66.4,<4.67",
]

[tool.uv.sources]
tqdm = { url = "https://files.pythonhosted.org/packages/18/eb/fdb7eb9e48b7b02554e1664afd3bd3f117f6b6d6c5881438a0b055554f9b/tqdm-4.66.4-py3-none-any.whl" }

Thx.


Determine authentication for query proxy and PostgrREST

We need to come up with an authentication scheme that works well for both and allows users to authenticate on both sides.

I think that we should have in-db password checking and JWT creation, and reuse this in the query proxy.

This has now been documented by a design document in the repo.


custom_popup_html javascript seems not to work

Hi,
I am struggling with custom_popup_html to define my custom popup, but it seems not to work and the popup is always the same-attached image.

I am using
`

....
                custom_popup_html: function (task) {
                    const start_date = task._start.toLocaleDateString();
                    const end_date = task._end.toLocaleDateString();
                    return `

${task.name}

Task started on: ${task._start.getDate()}

Expected to finish by ${task._start.getDate()}

${task.progress}% completed!

                `;

`

Use popup instead of custom_popup_html

Can you provide me an example, as I only get cusomt_popup_html examples? Also, why custom_popup_html this not working, if you have maybe this knowledge?

Hi,
Sorry, this was changed back in April as it made more sense to have it all within one popup field. We'll update the examples soon.

@jurerejc instead of custom_popup_html, just write popup and do your thing.


Generic Repository Events

As proposed by @TimoGlastra in #716:

[...] we could maybe solve this generically by adding events to the repository level. This way we can have RecordDeletedEvent, RecordSavedEvent, RecordUpdatedEvent, etc...

We discussed this in the WG today (starting at 29:30 if you want to listen: https://wiki.hyperledger.org/download/attachments/62250923/video1405750752.mp4?version=1&modificationDate=1651158507433&api=v2)
The general consensus is that general repository events are useful and we would like to see this added to the framework.
Is this something you're willing to open a PR for this @Przytua? We can merge https://github.com/hyperledger/aries-framework-javascript/pull/716 for now, but it may be better to switch to the generic events to avoid breaking changes.

Since these would be breaking changes with the state update events anyway,

I think the state changed events can be handled separately at a later time, so if we directly add the generic repository events there won't be any breaking changes is it's just a new feature.

I'd suggest to merge https://github.com/hyperledger/aries-framework-javascript/pull/716 for now,

Sure thats fine by me. But if your PR will be ready before we mark the 0.2.0 release I don't see a reason to keep them in TBH.

Ah, ok. So yeah, let's leave #716 in PR, and if I won't make it before the release (which I hope won't happen), you can merge it, and generic ones would be added to next version.
By the way, is there any planned date for 0.2.0 release?


feat!: test major version update

:tada: This PR is included in version 2.6.0 :tada:
The release is available on:

GitHub release
npm package (@latest dist-tag)

Your semantic-release bot :package::rocket:


Test Trigger

static-scan[branch:main]

sca-scan[branch:main],static-scan[branch:main]

sca-scan[branch:main],static-scan[branch:main]

static-scan


Working on Task 3

I created this issue to notify that i have started working on task 3 thank you.

@ladyami i am already working on that

@Mublin did you create issue about it ( have check before I started I did not see any issue about ) or @BatoolMM  assign the task to you? i was also working on the website SEO but when i notice a issue have open about it i have to drop it.

@Mublin  I am sorry I just recheck I didn't see it before you can continue working on it I will drop it best of luck.

Thank you @ladyami for your hard work and for kindly discussing this issue!
If you opened a duplicate issue, please close it!

okay ma I will close it Immediately


Handle 'hat' currency

There are existing listings that use the 'hat' currency, which currently result in a parse error. The output from one such listing (using /api/v2/classifieds/listings/440_14613584054) is below.
{"id":"440_14613584054","steamid":"76561199123726690","appid":440,"currencies":{"metal":1.5,"hat":1},"value":{"raw":2.885,"short":"2.89 ref","long":"1.5 ref"},"details":"just wanna get rid of it so just send me an trade offer\n","listedAt":1719728674,"bumpedAt":1720314810,"intent":"sell","count":1,"status":"active","source":"steam","item":{"appid":440,"baseName":"Infernal Impaler","defindex":575,"id":"14613584054","imageUrl":"https:\/\/steamcdn-a.akamaihd.net\/apps\/440\/icons\/infernal_impaler.9259a5b1e57bdce5e4cdec7ac0960e36916d86a2.png","marketName":"The Infernal Impaler","name":"The Infernal Impaler","origin":{"id":0,"name":"Timed Drop"},"originalId":"7080536825","price":{"community":{"value":1,"valueHigh":1,"currency":"hat","raw":1.385,"short":"1.33\u20131.44 ref","long":"Random Craft Hat, 1.39 ref, $0.0291","usd":0.029084999999999996,"updatedAt":1706749449,"difference":0.05500000000000016},"suggested":{"raw":1.385,"short":"1.39 ref","long":"1.39 ref, $0.0291","usd":0.029084999999999996}},"quality":{"id":6,"name":"Unique","color":"#FFD700"},"summary":"Level 13 Headgear","level":13,"class":["Soldier"],"slot":"misc","tradable":true,"craftable":true,"tag":null},"user":{"id":"76561199123726690","name":"Huller","avatar":"https:\/\/avatars.steamstatic.com\/7b59a89a2492730a13b332f3949ed7fdd6700d3c_medium.jpg","avatarFull":"https:\/\/avatars.steamstatic.com\/7b59a89a2492730a13b332f3949ed7fdd6700d3c_full.jpg","premium":false,"online":false,"banned":false,"customNameStyle":"","acceptedSuggestions":0,"class":"","style":"","role":null,"tradeOfferUrl":"https:\/\/steamcommunity.com\/tradeoffer\/new\/?partner=1163460962&token=bLS5T96L","isMarketplaceSeller":false,"flagImpersonated":null,"bans":[]}}```

Hat currencies shouldn't be around anymore. It's a little annoying that they do show up. I considered just ignoring the hat field, but this might have the potential effect of currencies just being empty which would look odd.
So I added another variant for currencies which includes hats https://github.com/juliarose/backpacktf-api/commit/7fd731802af08d444b99ef8ec0d634a6e236f5bb


Remove or update references to spring-petclinic-migration

A long time ago we created https://github.com/openrewrite/spring-petclinic-migration as a way to document how to migrate an intentionally outdated Spring Boot application . We're also referencing that repository from our documentation in a number of places:
https://github.com/search?q=repo%3Aopenrewrite%2Frewrite-docs spring-petclinic-migration&type=code
The problem is that spring-petclinig-migration also contains a README with very outdated instructions, for instance using rewrite-maven-plugin 1.2.1, whereas the latest is 5.30.0.
We should go over our documentation and that repository, and from there decide to either update the repo and keep it up to date going forward (or make it time / version less), or rewrite the documentation and archive that repository to avoid confusion.
Triggered by a question in OSS Slack: https://rewriteoss.slack.com/archives/C01A843MWG5/p1715749305401219

I've removed most of the README for that repository and added a link to the OpenRewrite quick start guide that uses it. I think that addresses the issues brought up here. Does that seem reasonable @timtebeek ?


Add instructions for beginners

For somone unfamiliar with Clojure, it is not straightforward to get started with this code. The documentation should have a reference to Leiningen and explain at leat "lein test" and "lein repl" to get started.

Thanks @khinsen for the recommendation. Being a Clojure project one assumes that potential users would know how to load respective diman libraries, however this view also limits diman to only audiences familiar with Clojure. I have therefore added a section in documentation for users new to Clojure.

Very nice! Your project is small enough that it can be a good entry point to the Clojure universe.
BTW, something you might want to consider to encourage adoption is a demo notebook at https://nextjournal.com/, which is very Clojure-friendly (written in Clojure(Script) itself).
The difficulty with diman is that it faces two adoption barriers: a little-known language in science, and a little-known mathematical foundation. Since it's easier to reduce the first barrier than the second, I think it's worth some effort.

The difficulty with diman is that it faces two adoption barriers: a little-known language in science, and a little-known mathematical foundation. Since it's easier to reduce the first barrier than the second, I think it's worth some effort.

This is an excellent advice. Since Clojure is not as well known as say, Python, showing examples in notebook form can be very useful.
I was not familiar with https://nextjournal.com Thank you for letting me know. I will have a look and see if I can post some examples in Nextjournal.

See https://nextjournal.com/try/samritchie/sicmutils for a nice example of a Clojure notebook on Nextjournal.


Refactor controls for administrative roles to reflect role scheme

Issue Type
[ ] bug report
[ X ] feature request

Current Behavior
The following administrative roles are conceptually agreed upon but have not been implemented consistently across the contract system.

Authority: EOA used exclusively to submit plasma block hashes to the root chain.
Deployer: EOA used to deploy all root chain contracts.
Maintainer: MultiSig wallet that is allowed to initiate upgrades/updates of specific parts of the root chain contracts. Can also update the exit bond size.
Contract: A root chain contract that is authorized to call specific functions in other root chain contracts.

Suggested Fix
Suggestions are made as follows on a per contract basis.
Operated

[ ] Rename the contract Operated to Maintainable in order to make it clear for which role it is used for.

contract Maintainable {
    address public maintainer;

    constructor() public {
        maintainer = msg.sender;
    }

    modifier onlyMaintainer() {
        require(msg.sender == maintainer, "Can only be called by maintainer");
        _;
    }

}

EthVault and Erc20Vault
Todo:

[ ] Rename Operated to Maintainable
[ ] Set Maintainer during contract creation
[ ] Use onlyMaintainer to control access to register new DepositVerifier

PlasmaFramework
Todo:

[ ] Rename Operated to Maintainable
[x] The upgrade mechanism registerExitGame and registerVault for VaultRegistry and ExitGameRegistry  is inline with the main product requirements of being able to add components after MIN_EXIT_PERIOD has passed.
[ ] Instead of inlining the check if the function submitBlock is called from Authority create a modifier onlyAuthority() so it's aligned with the scheme of using modifiers for access checks.
[ ] The initAuthority() function is susceptible to front running and can be called by anyone after contract creation until it is called for the first time. I propose to remove initAuthority() and setAuthority() and set authority during contract creation.

PriorityQueue
Todo:

[ ]  Remove the Ownable contract.
[ ] Introduce a new variable plasmaFramework that is set at contract creation.
[ ] Create a new modifier onlyFromPlasmaFramework that restricts calling the functions insert and delMin.

PaymentExitGame
Todo:

[ ] Remove the contract OnlyFromAddress and instead introduce a modifier onlyFromPlasmaFramework that checks if processExit is in fact called by PlasmaFramework
[ ] Change the modifier for updateStartStandardExitBondSize to onlyMaintainer(). Set maintainer during contract creation.

OutputGuardHandlerRegistry
Todo:

[ ]  Remove the Ownable contract. Having to revoke ownership  for Ownable feels awkward.
[ ] Set Maintainer during contract creation
[ ] Use onlyMaintainer to control access to registerOutputGuardHandler

SpendingConditionRegistry
Todo:

[ ]  Remove the Ownable contract
[ ] Set Maintainer during contract creation
[ ] Use onlyMaintainer to control access to registerSpendingCondition

EOA used...

A n00bie question, what is EOA?

Remove the Ownable contract and use Mainainable instead

For OutputGuardHandlerRegistry and SpendingConditionRegistry then we need to some alternative way to freeze the functionality. It has renounceOwnership for free at this moment by using Ownable.

:) Externally Owned Contract ... I got like three people asking me what that is.
I was under the impression that the maintainer can upgrade this. Just looking at the proposed deployment https://github.com/omisego/plasma-contracts/blob/60ca330ab08d1c4a8bd57e067e90851b72539fab/plasma_framework/migrations/5_deploy_and_register_payment_exit_game.js#L77 this does not seem to be the case. registerSpendingCondition seem to suggest that you can register new SpendingCondition contracts based on a key?

I was under the impression that the maintainer can upgrade this

yes, for a short while of span, and then its ownership is renounced immediately.
https://github.com/omisego/plasma-contracts/blob/60ca330ab08d1c4a8bd57e067e90851b72539fab/plasma_framework/migrations/5_deploy_and_register_payment_exit_game.js#L81

seems to work in a similar way.

Yeah, they both have the same concept of design.

If that's the case then why do we need OutputGuardHandlerRegistry and SpendingConditionRegistry. We could just wire PaymentOutputToPaymentTxCondition and PaymentOutputGuardHandler into PaymentExitGame?

The PaymentTxV2 would be able to be spent in multiple transaction types (2 I guess), plus itself would have 2 output types. That's why we decoupled the dependency this way instead of direct injection.

I don't understand the contract system well enough yet to know what that means. Generally speaking though in regards to registries ... A registry that will only ever hold one thing and you will never able to change or add more things seems not very meaningful.

A registry that will only ever hold one thing and you will never be able to change or add more things seems not very meaningful.

I agree. It is more of a future proofing coding and as an effort of not re-audit the PaymentExit game in the future when we introduce DEX (or sth else)

@boolafish just looking at this again and the background you gave me on future developments, I think we can leave OutputGuardHandlerRegistry and SpendingConditionRegistry the way they are. Let's create some inline documentation that provides the background on who the owner is and around the lifecycle of the ownership.

The initAuthority() function is susceptible to front running ... I propose to remove initAuthority() and ... set authority during contract creation.

This needs to be handled also on elixir-omg as we have calc_nonce and there is probably check in Watcher I cannot find atm...

@pnowosie it be great if someone could drive this and coordinate the changes with the elixir-omg team.

This needs to be handled also on elixir-omg as we have calc_nonce and
@thec00n:  it be great if someone could drive this and coordinate the changes with the elixir-omg team.

Well changes in elixir-omg can be avoided as well if we agree that authority address align to the requirements elixir-omg sets.
This means that nonce of the Authority address HAS TO correspond to the OMG Network block numbers: 1000 * nonce == blknum
Assuming that Authority address is fresh generated then without initAuthority it needs to send 1 successful transaction on Ethereum to comply :point_up: requirements and be able to send "block" transactions.
@pdobacz @boolafish you thoughts :question:

it needs to send 1 successful transaction on Ethereum to comply
just a quick not that it has to be any transaction, not even a successful one, so that we enjoy the not-off-by-one nonce-blknum relationship (which is not paramount maybe but I think quite nice, makes diagnosing problems significantly easier on the brain). nonce=1 start for authority is not enforced anymore then, so it's slightly easier to miss.

so that we enjoy the not-off-by-one nonce-blknum relationship

I'm afraid it's just making our lives easier it won't work otherwise

OK, my above comment produced some confusion. To clarify:

I'm in favor of keeping the nonce-to-blknum relationship, unless brings some larger problems to the table. It is useful to have 1000 * nonce == blknum
I understand there's a need for the authority to not have to call initAuthority anymore. If this is the case, we'll need to remember to bump the authority nonce to have (1.). That bump could be any mined tx coming out of authority. This bump is then "not enforced", I'll edit the above comment to say "not enforced in the contract"

OK, so the options we have are:

[Contract only]: Remove initAuthority() as proposed but comply to the rule 1000 * nonce == blknum and then avoid elixir-omg changes
[Contract, ch-ch & Watcher]: as above and then hunt for all the places the :point_up: rule is in force and fix it
[Naive]: Acknowledge the possible "front running" issue and make sure deployment scripts call initAuthority() just after deployment to lower the severity of the threat.

(CC @thec00n, @boolafish )

I am ok with 1. and 2. As you might guess I am not a fan of 3.

I think to be able to handle this #242 to separate maintainer from deployer, we cannot use that Maintainable style modifier directly due to inheritance diamond issue: https://github.com/omisego/plasma-contracts/pull/239#issuecomment-527825228
Some options in my mind:

Proper dependency injection and untangle the inheritance. However, this would be a huge change and need to re-write the public functions to wrap the call to the injected dependency.
reuse the OnlyFromAddress and inject the address to each contract that need protection. I think @thec00n has the recommendation of remove OnlyFromAddress to be something more specific. However, when it is used, it is pretty readable eg. onlyFrom(address(plasmaFramework)). The down side would be the revert message would be more broad without showing which actor fails. Upside is that less code to maintain. We can probably replace all onlyXXX to this instead.
Have library and custom struct + method for each address. eg.

library Maintainable {
    struct Maintainer {
        address actor;
    }

    function isCalledByMaintainer(Maintainer memory self) internal {
        require(msg.sender == self.actor, "Can only be called by maintainer");
    }
}

and then we inject the Maintainable.Maintaner maintainer to each function needed. Remove modifier and call the isCalledByMaintainer instead.

OK, so the options we have are:

I have one more idea, we can store the authority address during constructor but we still need another function to activate the authority address. Basically initAuthority() -> activateAuthority() (and would verify msg.sender==storedAuthority) so everything looks good and making sense though it is really just an action for an action......XD

@boolafish I don't understand ... but we still need another function to activate the authority address. Why do we need that?

It’s really just to comply the rule to do an action to make it nonce starting with one. And by checking with the value during deployment, we can avoid front runner

If it's just about increasing the nonce then why don't we just simply perform a transaction? Why do we need an extra function for that?

As discussed with @boolafish  I am proposing to refactor Blockcontroller (see also https://gist.github.com/thec00n/494d04a2393fcd6aa80c6d2509d2c764#file-blockcontroller-sol-L12-L47) to set authority during contract creation. The child chain needs to trigger the first transaction and call activateChildChain (from the authority address). The function can only be called once and emits the ChildChainActive event. This will also set nonce to 1 and then the child chain can start to produce blocks. FYI @jbunce is working on a solution that will not require us to store the private key on the child chain system. The child chain will request another hardened system to sign transactions for submitBlock() and activateChildChain()` but will not allow any other calls to PlasmaFramwork or any other contract.


Make tools inherit common dependency versions from parent pom

Tools should not unnecessarily override parent pom versions
Recurrence of #2088
Signed-off-by: Gera Shegalov<EMAIL_ADDRESS>

build

build

Does this belong in 21.06 or 21.08?

re-targetted to branch-21.08

build

build

build


Initial SIP Dispatch Rules implementation

Initial SIP Dispatch Rules implementation. Do not merge!
Needs tests and a few changes to the protocol.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


[test-only: do not review] tags related tags test

Description

Related to this pr: https://github.com/Azure/azure-cli/pull/13429
Testing Guide

History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.

This checklist is used to make sure that common guidelines for a pull request are followed.

[ ] The PR title and description has followed the guideline in Submitting Pull Requests.

[ ] I adhere to the Command Guidelines.

add to S171

No longer needed


Airflow config for covid tracking project and covid tracking project metadata

#116

Also, what were your thoughts on joining the metadata and covid tracking project tables? Did you consider putting the ingest to bq operator for the metadata table in the covid tracking project dag?

Also, what were your thoughts on joining the metadata and covid tracking project tables? Did you consider putting the ingest to bq operator for the metadata table in the covid tracking project dag?

Also, what were your thoughts on joining the metadata and covid tracking project tables? Did you consider putting the ingest to bq operator for the metadata table in the covid tracking project dag?

For joining with the metadata, the covid tracking project is going to perform a query to BQ to get the standardized metadata table during its write_to_bq stage. I thought about putting the metadata operator in the CTP dag, but since the metadata is manually uploaded, I thought it better to keep it simple and have it be its own dag. The metadata won't change frequently, so it will only need to be run when we obtain a new file. Since CTP is scheduled daily, doing it this way avoids any accidents if a new metadata file is uploaded but not approved before the CTP scheduled run kicks off.
The joining logic is in this PR #313 if you're interested

Also, what were your thoughts on joining the metadata and covid tracking project tables? Did you consider putting the ingest to bq operator for the metadata table in the covid tracking project dag?

For joining with the metadata, the covid tracking project is going to perform a query to BQ to get the standardized metadata table during its write_to_bq stage. I thought about putting the metadata operator in the CTP dag, but since the metadata is manually uploaded, I thought it better to keep it simple and have it be its own dag. The metadata won't change frequently, so it will only need to be run when we obtain a new file. Since CTP is scheduled daily, doing it this way avoids any accidents if a new metadata file is uploaded but not approved before the CTP scheduled run kicks off.
The joining logic is in this PR #313 if you're interested

Also, what were your thoughts on joining the metadata and covid tracking project tables? Did you consider putting the ingest to bq operator for the metadata table in the covid tracking project dag?

For joining with the metadata, the covid tracking project is going to perform a query to BQ to get the standardized metadata table during its write_to_bq stage. I thought about putting the metadata operator in the CTP dag, but since the metadata is manually uploaded, I thought it better to keep it simple and have it be its own dag. The metadata won't change frequently, so it will only need to be run when we obtain a new file. Since CTP is scheduled daily, doing it this way avoids any accidents if a new metadata file is uploaded but not approved before the CTP scheduled run kicks off.
The joining logic is in this PR #313 if you're interested

Sounds good, thanks!

Also, what were your thoughts on joining the metadata and covid tracking project tables? Did you consider putting the ingest to bq operator for the metadata table in the covid tracking project dag?

For joining with the metadata, the covid tracking project is going to perform a query to BQ to get the standardized metadata table during its write_to_bq stage. I thought about putting the metadata operator in the CTP dag, but since the metadata is manually uploaded, I thought it better to keep it simple and have it be its own dag. The metadata won't change frequently, so it will only need to be run when we obtain a new file. Since CTP is scheduled daily, doing it this way avoids any accidents if a new metadata file is uploaded but not approved before the CTP scheduled run kicks off.
The joining logic is in this PR #313 if you're interested

Sounds good, thanks!


fix: Add reverse() back when adding images to queue in stackPrefetch

Please check if the PR fulfills these requirements

[ ] The commit message follows our guidelines
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

What is the current behavior? (You can also link to an open issue here)

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

Other information:

:tada: This PR is included in version 6.0.2 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


ASP.NET Core Web API Controller simple public method bool return type

Hi,
Not sure if this should be classed as an issue (I could use the [ApiExplorerSettings(IgnoreApi = true)] attribute) but I wanted to check.
I have a method in my controller with the following signature:
[HttpGet]
public bool IsCompliant()
{
return compliance.IsCompliant;
}
When I start the Web App and point the page to swagger I get the above error.  If I add an ignore attribute then everything else loads fine - is this the best practice for bool values I am assuming its kind of pointless for Swagger to rend an endpoint test for this.

Can you elaborate on the error you're seeing. When I use the above action signature, I don't see any issues

Closing due to inactivity


Artifact is deployed to Heroku platform under its full filesystem path in Gradle daemon's directory

I'm using Heroku Gradle plugin (version 1.0.4) to deploy a roughly 13 MB sized executable application JAR.
And struggling with correctly packing only this artifact (and not all the other stuff from Gradle's build folder);
and getting the instruction to launch this app right.
First szenario:
Excerpt from build.gradle:
heroku {
  appName = '[APPLICATION]'
  processTypes(
          web: "java \$JAVA_OPTS -jar ./build/libs/[APPLICATION].jar" as String
  )
}

This works, BUT the artifact uploaded to Heroku platform contains many useless content, e.g. compiled class files etc.:
$ ./gradlew deployHeroku

> Task :deployHeroku
-----> Packaging application...
       - app: [APPLICATION]
       - including: build/
-----> Creating build...
       - file: build/heroku/build.tgz
       - size: 66MB

66 MB, but application's JAR is only 13 MB in size!
Second szenario:
Adding includeBuildDir = false to heroku task in build.gradle:
heroku {
  appName = '[APPLICATION]'
  includeBuildDir = false
  processTypes(
          web: "java \$JAVA_OPTS -jar ./build/libs/[APPLICATION].jar" as String
  )
}

This FAILS, the artifact uploaded to Heroku platform does NOT contain the executable JAR file!
Size of the uploaded build.tgz is simply too small:
$ ./gradlew deployHeroku

> Task :deployHeroku
-----> Packaging application...
       - app: [APPLICATION]
       - including: build/
-----> Creating build...
       - file: build/heroku/build.tgz
       - size: 1MB

Third szenario:
Let's exactly define the artifact file to upload using includes = ["build/libs/[APPLICATION].jar"] in heroku task:
heroku {
  appName = '[APPLICATION]'
  includeBuildDir = false
  includes = ["build/libs/[APPLICATION].jar"]
  processTypes(
          web: "java \$JAVA_OPTS -jar ./build/libs/[APPLICATION].jar" as String
  )
}

This FAILS, Heroku's console tells us the reason:
Error: Unable to access jarfile ./build/libs/[APPLICATION].jar

Size of the uploaded build.tgz is OK now (13 MB), BUT what means the over-long including path:
$ ./gradlew deployHeroku

> Task :deployHeroku
-----> Packaging application...
       - app: [APPLICATION]
       - including: /home/[USER]/.gradle/daemon/6.5.1/build/libs/[APPLICATION].jar
-----> Creating build...
       - file: build/heroku/build.tgz
       - size: 13MB

Connecting to the Heroku platform and searching for our application JAR file shows:
$ heroku run -a [APPLICATION] -- pwd\; find . -name [APPLICATION]\*.jar
Running pwd; find . -name *.jar on ⬢ [APPLICATION]... up, run.2939 (Free)
/app
./home/[USER]/.gradle/daemon/6.5.1/build/libs/[APPLICATION].jar

Oh, my JAR file has been uploaded with its absolute filesystem path of Gradle's daemon!
So changing processTypes instruction to contain ./home/[USER]/.gradle/daemon/6.5.1/build/libs/[APPLICATION].jar would work, but that is not the expected solution!
My expectation is that this operates the same way as with the other two szenarios: Application JAR file is available on Heroku platform under project-relative path build/libs/[APPLICATION].jar.

Hey @dcmoeller, thanks for the detailed report! I'll investigate and update this issue with my findings.

What was your working directory when you encountered the overly long file paths in scenario three? Can you try again while your working directory is the project directory, if not already the case?

@Malax: All commands shown are issued in project's directory, the one containing build.gradle.

I was able to reproduce this when running with my local Gradle installation (i.e. gradle build deployHeroku). It works correctly when using the Gradle wrapper from the project (./gradlew build deployHeroku). I assume the demon does something that trips off our path resolution code.
Try running the deploy with gradlew as a workaround for now. I'll see that we have a fix for this next week.

Interesting! I've not tried local Gradle installation, I've always used project's Gradle Wrapper ./gradlew ....

I'm using Gradle version 6.5.1. Here it show that both invocations gradle deployHeroku as well as ./gradlew deployHeroku behave the same!

Some more output from my invocations, maybe this helps:

$ ./gradlew deployHeroku
Executed by Gradle 6.5.1

> Task :deployHeroku
-----> Packaging application...
       - app: [APPLICATION]
       - including: /home/[USER]/.gradle/daemon/6.5.1/build/libs/[APPLICATION].jar
-----> Creating build...
       - file: build/heroku/build.tgz
       - size: 13MB
-----> Uploading build...
       - success
-----> Deploying...
remote:
remote: -----> heroku-gradle app detected
remote: -----> Installing JDK 14... done
remote: -----> Discovering process types
remote:        Procfile declares types -> web
remote:
remote: -----> Compressing...
remote:        Done: 79.3M
remote: -----> Launching...
[...]

Exactly the same output and outcome if using gradle deployHeroku.

@dcmoeller I started work on a new major version for this plugin which leverages an updated heroku-deploy version that does not show this bug. You can track progress in my draft PR #22. I'm hopeful we can get this out of the door this or at least next week.

Looking forward :smiley:
By the way, fixed issue myself by modifying one line from my original post containing includes: like this (beware of using absolute path here by using Gradle's buildDir path variable):
includes = ["${buildDir}/libs/[APPLICATION].jar"]

With this you can also modify processTypes(web ...) to the following expected version:
web: "java \$JAVA_OPTS -jar ./build/libs/[APPLICATION].jar" as String

This works.

Hey @dcmoeller, 2.0.0 has been released last friday. Can you confirm it resolves your issue? :)

Confirmed: My "Third szenario" works now :+1:
To import new version I have to switch the following clause in build.gradle:
  //classpath 'gradle.plugin.com.heroku.sdk:heroku-gradle:1+'
  classpath 'gradle.plugin.com.heroku.sdk.heroku-gradle:heroku-gradle:2+'

Thanks for confirming and the initial report! 👍


function argument names shown

I just updated to Version: 1.60.0-insider (user setup)
Commit: 1ee61f368ee0570feeb220605578a8768d99e762
Date: 2021-08-09T06:11:00.971Z
Electron: 13.1.8
Chrome: 91.0.4472.164
Node.js: 14.16.0
V8: 9.1.269.39-electron.0
OS: Windows_NT x64 10.0.19042
Now in the IDE, when I call a function, there is some text rendered by VSC which displays the name of the argument (in grey) beside the value that I'm passing into a function.
This new feature is really buggy especially when I copy and paste code.  The greyed out text renders over top of the actual code in the source file making it difficult to see anything.
How do I turn off this new feature?

Can you post a screenshot?
@mattbierner are typescript inlay hints enabled by default?

Here is an example where the grey text renders overtop of my source code

Can you post a screenshot?
@mattbierner are typescript inlay hints enabled by default?

pinging @mjbvz

Yes set "typescript.inlayHints.parameterNames.enabled": "none" to disable the inlay hints
Positioning issues are tracked upstream by https://github.com/microsoft/TypeScript/issues/45320


V4 dev spelling fix in docs/getting-started/flexbox.md

Title says it all, replaced "flexbix" with "flexbox"

Thanks!


Add ML docs

A lot of the info here could be migrated to a Machine Learning page in this repo.

Could also merge with this page: https://ibmi-oss-docs.readthedocs.io/en/latest/PYTHON_PKGS_GUIDE.html


Snowflake Snowpipe: _dbt_copied_at field should use metadata$start_scan_time instead of current timestamp

I suggest replacing the current _dbt_copied_at field which uses current_timestamp since Snowflake recommends against using that function in a Snowpipe.
https://community.snowflake.com/s/article/Incorrect-timestamp-in-Snowpipe-while-using-current-timestampfunction
https://docs.snowflake.com/en/user-guide/data-load-snowpipe-ts#load-times-inserted-using-current-timestamp-earlier-than-load-time-values-in-copy-history-view
Originally posted by @jtmcn in https://github.com/dbt-labs/dbt-external-tables/issues/239#issuecomment-1889956737

resolved by #282


Fix indenting in sample file listing.

Proposed changes
Add one line break.  This fixes the indenting in the sample file listing.  See rich diff view to get the full effect.

I realize the contribution guidelines say:

Don't change whitespace or line wrapping in parts of a file you are not editing for other reasons. Make sure your text editor is not configured to automatically reformat the whole file when saving.

However, I believe this is an exception, because this missing line break completely screws up the formatting of the sample docker-compose file, making it all but unreadable.
Reviewing and merging this pull request should only take a few minutes.

I notice that with this change, the closing </div> becomes visible (at least on GitHub);

On the documentation (the primary use for files in this repository are for reading on docs.docker.com, not on GitHub, as there's sometimes formatting/parsing instructions intended for docs.docker.com), the file seems to render OK (before this change);

So, wondering what's causing it to not show up properly on GitHub

looks like un-indenting the </div> at line 126/127 fixes that; https://github.com/docker/docker.github.io/pull/6926/files#diff-06edd26f33bf2c3f6ee590618f41c62cL126
Mixing HTML and Markdown remains a bit finicky 😓

Thank you for your feedback! We have received and reviewed your changes. To remain consistent with existing technical specifications, we did not incorporate your suggested changes. If you have additional concerns, submit a new issue in this repository.


Cancel rescan

Is it possible to cancel a rescan? I changed a wallet birthday, but I think it continued to scan from the prior birthday.

Unfortunately Bitcoin Core provides no way to cancel a rescan (other than shutting it down). The best advice here is to use an Electrum server like Fulcrum to make individual wallet scanning unnecessary.

Ah, okay. Thank you!


Automatically generate --help

This module should automatically generate the help text based on the command line interface provided and not force you to repeat yourself. Kinda the opposite of: https://github.com/docopt/docopt.nim

Thanks for pointing that out. This is an 'ugly' problem I find.
Right now the arguments and options are not associated with a custom name so mapping them back to a help text would result in <int> and such which is not great. Adding a custom name as another parameter is too distracting. Using the argument variable name is our best bet but I don't know how to do so without going macros all the way -which I don't want to do.
An auto-generated help/usage text should be overridden by exitoption "--help" or instead only be made available through a documented call so that the end result may be further customizable and the format is not forced upon the user.
It is also a slippery slope, there is a ton of additional metadata you would want to squeeze in to make the usage/help text actually helpful:

the help text of each argument and option
the overall description
you might as well have the man page generated...

I am ok with auto-generating a one line usage text. For anything more involved I actually like that the developer needs to write it out. I am open to proposed solutions though :smile_cat: .
I am abiding by my design rule until there is an elegant way to deal with this:
"Keep it simple and streamlined. Command line parsers can do a lot for you, but I prefer to be in adequate control."

Yeah, it indeed is somewhat of a slippery slope. I would surely ask for the first two bullet points you listed. Only because I rarely use man pages, though. ;)
But on the other hand, for anything I would have to write the proper help text, I would probably migrate to a future macroed docopt. The competion is open! XD


call_connection_client is used in the example but this variable is never defined

a variable called "call_connection_client" is used in the example, but this variable is never defined

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 5e4fea0f-97cc-f112-94fb-8db90fa088c4
Version Independent ID: 4d6eb14b-9fc5-3f07-edab-8b9269ca0f12
Content: Quickstart - Make an outbound call using Call Automation - An Azure Communication Services quickstart
Content Source: articles/communication-services/quickstarts/call-automation/quickstart-make-an-outbound-call.md
Service: azure-communication-services
Sub-service: call-automation
GitHub Login: @AnujBh
Microsoft Alias: anujbh

@KristianKjerstad
Thanks for your feedback! We will investigate and update as appropriate.

@KristianKjerstad, I've added the missing lines from communication-services-python-quickstarts/callautomation-outboundcalling at main · Azure-Samples/communication-services-python-quickstarts (github.com) for reference.