BUG: sealos run with  error converting YAML to JSON

Which command or component
 sealos apply -f Clusterfile

Clusterfile
apiVersion: apps.sealos.io/v1beta1
kind: Cluster
metadata:
  creationTimestamp: null
  name: default
spec:
  hosts:
  - ips:
    - <IP_ADDRESS>:22
    roles:
    - master
    - amd64
  - ips:
    - <IP_ADDRESS>:22
    - <IP_ADDRESS>:22
    roles:
    - node
    - amd64
  image:
  - labring/kubernetes:v1.24.3
  - labring/helm:v3.8.2
  - registry.cn-shenzhen.aliyuncs.com/cnmirror/cilium:v1.12.0
  ssh:
    passwd: "123456"
    pk: /root/.ssh/id_rsa
    port: 22
    user: root
status: {}
---
apiVersion: kubeadm.k8s.io/v1beta3
kind: InitConfiguration
skipPhases:
- addon/kube-proxy

The Description of the bug
Describe the bug.
How to reproduce（pictures can be attached if necessary）
#  sealos apply -f Clusterfile
......................
2022-08-02 19:16:49 [INFO] Executing pipeline RunGuest in CreateProcessor.
2022-08-02 19:16:49 [INFO] guest cmd is cp opt/helm /usr/bin/
2022-08-02 19:16:50 [INFO] guest cmd is cp opt/* /usr/bin/
2022-08-02 19:16:57 [INFO] guest cmd is helm install cilium charts/cilium --namespace=kube-system --set kubeProxyReplacement=strict --set k8sServiceHost=apiserver.cluster.local --set k8sServicePort=6443
Error: INSTALLATION FAILED: cannot load values.yaml: error converting YAML to JSON: yaml: line 2119: could not find expected ':'
2022-08-02 19:16:57 [EROR] Applied to cluster error: exit status 1
2022-08-02 19:16:58 [INFO]
      ___           ___           ___           ___       ___           ___
     /\  \         /\  \         /\  \         /\__\     /\  \         /\  \
    /::\  \       /::\  \       /::\  \       /:/  /    /::\  \       /::\  \
   /:/\ \  \     /:/\:\  \     /:/\:\  \     /:/  /    /:/\:\  \     /:/\ \  \
  _\:\~\ \  \   /::\~\:\  \   /::\~\:\  \   /:/  /    /:/  \:\  \   _\:\~\ \  \
 /\ \:\ \ \__\ /:/\:\ \:\__\ /:/\:\ \:\__\ /:/__/    /:/__/ \:\__\ /\ \:\ \ \__\
 \:\ \:\ \/__/ \:\~\:\ \/__/ \/__\:\/:/  / \:\  \    \:\  \ /:/  / \:\ \:\ \/__/
  \:\ \:\__\    \:\ \:\__\        \::/  /   \:\  \    \:\  /:/  /   \:\ \:\__\
   \:\/:/  /     \:\ \/__/        /:/  /     \:\  \    \:\/:/  /     \:\/:/  /
    \::/  /       \:\__\         /:/  /       \:\__\    \::/  /       \::/  /
     \/__/         \/__/         \/__/         \/__/     \/__/         \/__/

                  Website :https://www.sealos.io/
                  Address :github.com/labring/sealos

why the default values.yaml changed
root@node1:~# cat /var/lib/sealos/data/default/rootfs/charts/cilium/values.yaml
..........................
dnsProxy:
  # -- DNS response code for rejecting DNS requests, available options are '[nameError refused]'.
  dnsRejectResponseCode: refused
  # -- Allow the DNS proxy to compress responses to endpoints that are larger than 512 Bytes or the EDNS0 option, if present.
  enableDnsCompression: true
  # -- Maximum number of IPs to maintain per FQDN name for each endpoint.
  endpointMaxIpPerHostname: 50
  # -- Time during which idle but previously active connections with expired DNS lookups are still considered alive.
  idleConnectionGracePeriod: 0s
  # -- Maximum number of IPs to retain for expired DNS lookups with still-active connections.
  maxDeferredConnectionDeletes: 10000
  # -- The minimum time, in seconds, to use DNS data for toFQDNs policies.
  minTtl: 3600
  # -- DNS cache data at this path is preloaded on agent startup.
  preCache: ""
  # -- Global port on which the in-agent DNS proxy should listen. Default 0 is a OS-assigned port.
  proxyPort: 0
  # -- The maximum time the DNS proxy holds an allowed DNS response before sending it along. Responses are sent as soon as the datapath is updated with the new IP information.
  proxyResponseMaxDelay: 100ms
nections with expired DNS lookups are still considered alive.
  idleConnectionGracePeriod: 0s
  # -- Maximum number of IPs to retain for expired DNS lookups with still-active connections.
  maxDeferredConnectionDeletes: 10000
  # -- The minimum time, in seconds, to use DNS data for toFQDNs policies.
  minTtl: 3600
  # -- DNS cache data at this path is preloaded on agent startup.
  preCache: ""
  # -- Global port on which the in-agent DNS proxy should listen. Default 0 is a OS-assigned port.
  proxyPort: 0
  # -- The maximum time the DNS proxy holds an allowed DNS response before sending it along. Responses are sent as soon as the datapath is updated with the new IP information.
  proxyResponseMaxDelay: 100ms

at the end Added multiple lines of content
nections with expired DNS lookups are still considered alive.
  idleConnectionGracePeriod: 0s
  # -- Maximum number of IPs to retain for expired DNS lookups with still-active connections.
  maxDeferredConnectionDeletes: 10000
  # -- The minimum time, in seconds, to use DNS data for toFQDNs policies.
  minTtl: 3600
  # -- DNS cache data at this path is preloaded on agent startup.
  preCache: ""
  # -- Global port on which the in-agent DNS proxy should listen. Default 0 is a OS-assigned port.
  proxyPort: 0
  # -- The maximum time the DNS proxy holds an allowed DNS response before sending it along. Responses are sent as soon as the datapath is updated with the new IP information.
  proxyResponseMaxDelay: 100ms

and the origin just have this
dnsProxy:
  # -- DNS response code for rejecting DNS requests, available options are '[nameError refused]'.
  dnsRejectResponseCode: refused
  # -- Allow the DNS proxy to compress responses to endpoints that are larger than 512 Bytes or the EDNS0 option, if present.
  enableDnsCompression: true
  # -- Maximum number of IPs to maintain per FQDN name for each endpoint.
  endpointMaxIpPerHostname: 50
  # -- Time during which idle but previously active connections with expired DNS lookups are still considered alive.
  idleConnectionGracePeriod: 0s
  # -- Maximum number of IPs to retain for expired DNS lookups with still-active connections.
  maxDeferredConnectionDeletes: 10000
  # -- The minimum time, in seconds, to use DNS data for toFQDNs policies.
  minTtl: 3600
  # -- DNS cache data at this path is preloaded on agent startup.
  preCache: ""
  # -- Global port on which the in-agent DNS proxy should listen. Default 0 is a OS-assigned port.
  proxyPort: 0
  # -- The maximum time the DNS proxy holds an allowed DNS response before sending it along. Responses are sent as soon as the datapath is updated with the new IP information.
  proxyResponseMaxDelay: 100ms

Test Result
1.
2.
3.
What you expected to happen
Expected to xxx
Operating environment

Docker version:   eg. 19.03
Kubernetes version: kube1.24.3
Sealos version: v4.0.0
Operating system: ubuntu 22.04
Runtime environment:  eg. physical machine (100G memory, 10 core cpu, 10T storage), virtual machine (virbox, 10G memory, 2 core cpu, 100G storage), cloud(aws, 10G memory, 2 core cpu, 100G storage)
Cluster size: eg 1master, 2 node
Additional information: cilium

rename values.yaml.tmpl  to values.yaml.tmpl.bak . Because the .tmpl suffix file will be rendered by default.

So this issue is already fixed?
@willzhang seems we can add cilium on our homepage

So this issue is already fixed?
@willzhang seems we can add cilium on our homepage

yes, there have a values.yaml.tmpl
root@ubuntu:/data/git/cluster-image/applications/cilium/v1.12.0# ll charts/cilium/
total 244
drwxr-xr-x  4 root root   176 Aug  3 13:20 ./
drwxr-xr-x  3 root root    20 Aug  3 13:19 ../
-rw-r--r--  1 root root  5201 Aug  3 13:19 Chart.yaml
drwxr-xr-x  3 root root    22 Aug  3 13:19 files/
-rw-r--r--  1 root root   349 Aug  3 13:19 .helmignore
-rw-r--r--  1 root root 11350 Aug  3 13:19 LICENSE
-rw-r--r--  1 root root 65663 Aug  3 13:19 README.md
-rw-r--r--  1 root root  2825 Aug  3 13:19 README.md.gotmpl
drwxr-xr-x 12 root root  4096 Aug  3 13:19 templates/
-rw-r--r--  1 root root 72990 Aug  3 13:19 values.yaml
-rw-r--r--  1 root root 72272 Aug  3 13:19 values.yaml.tmpl

render logs

root@node1:~# sealos run -f registry.cn-shenzhen.aliyuncs.com/cnmirror/cilium:v1.12.0 --debug
2022-08-02 18:57:52 [INFO] start to install app in this cluster
2022-08-02 18:57:52 [DEBG] cmd for sh in host:  type buildah
2022-08-02 18:57:52 [DEBG] cmd for sh in host:  type buildah
2022-08-02 18:57:52 [DEBG] cmd for sh in host:  type buildah
2022-08-02 18:57:52 [DEBG] cmd for sh in host:  type buildah
are you sure to override these app? Yes [y/yes], No [n/no] : y
2022-08-02 18:57:53 [DEBG] sync cluster status is: apiVersion: apps.sealos.io/v1beta1
kind: Cluster
metadata:
  creationTimestamp: "2022-08-02T10:43:42Z"
  name: default
spec:
  hosts:
  - ips:
    - <IP_ADDRESS>:22
    roles:
    - master
    - amd64
  - ips:
    - <IP_ADDRESS>:22
    - <IP_ADDRESS>:22
    roles:
    - node
    - amd64
  image:
  - labring/kubernetes:v1.24.3
  - labring/helm:v3.8.2
  - registry.cn-shenzhen.aliyuncs.com/cnmirror/cilium:v1.12.0
  ssh:
    passwd: "123456"
    pk: /root/.ssh/id_rsa
    port: 22
    user: root
status:
  conditions:
  - lastHeartbeatTime: "2022-08-02T10:53:35Z"
    message: exit status 1
    reason: ApplyClusterError
    status: "False"
    type: ApplyClusterSuccess
  mounts:
  - env:
      criData: /var/lib/containerd
      registryConfig: /etc/registry
      registryData: /var/lib/registry
      registryDomain: sealos.hub
      registryPassword: passw0rd
      registryPort: "5000"
      registryUsername: admin
    imageName: labring/kubernetes:v1.24.3
    labels:
      auth: auth.sh
      check: check.sh
      clean: clean.sh $criData
      clean-registry: clean-registry.sh $registryData $registryConfig
      image: ghcr.io/labring/lvscare:v4.1.0-rc1
      init: init.sh $criData $registryDomain $registryPort $registryUsername $registryPassword
      init-registry: init-registry.sh $registryPort $registryData $registryConfig
      io.buildah.version: 1.25.0-dev
      sealos.io.type: rootfs
      version: v1.24.3
    mountPoint: /var/lib/containers/storage/overlay/b5410fdf9b143fab2847fa391cd3b35aa62e443895aff418f1e0d76b8278695f/merged
    name: default-2etgjy1t
    type: rootfs
  - cmd:
    - cp opt/helm /usr/bin/
    imageName: labring/helm:v3.8.2
    labels:
      io.buildah.version: 1.25.0-dev
    mountPoint: /var/lib/containers/storage/overlay/ef045f9434d903313388d2219c9bdf17c98505d49b315da29b433ae57a749d76/merged
    name: default-azakzg4f
    type: application
  - cmd:
    - cp opt/* /usr/bin/
    - helm install cilium charts/cilium --namespace=kube-system --set kubeProxyReplacement=strict
      --set k8sServiceHost=apiserver.cluster.local --set k8sServicePort=6443
    imageName: registry.cn-shenzhen.aliyuncs.com/cnmirror/cilium:v1.12.0
    labels:
      io.buildah.version: 1.25.0-dev
    mountPoint: /var/lib/containers/storage/overlay/3a38817cdb697e2f3af5a1e58c6b03870fd621a03c87991b1ce40fdde4a548a6/merged
    name: default-j0n5ou7i
    type: application
  phase: ClusterFailed

21e7c5b3cedbed810b1f2f0c3d6725ca03ccbd02f0b30eae7bcea075b8a70379
2022-08-02 18:57:54 [DEBG] current container names is: default-j0n5ou7i
default-j0n5ou7i
2022-08-02 18:57:54 [DEBG] clusterfile config is empty!
2022-08-02 18:57:54 [DEBG] render env dir: /var/lib/containers/storage/overlay/42a607e6035faa68ddb6e9521ebfee64b111fdb4fd4badcb4d4407198e48a189/merged/etc
2022-08-02 18:57:54 [DEBG] render env dir: /var/lib/containers/storage/overlay/42a607e6035faa68ddb6e9521ebfee64b111fdb4fd4badcb4d4407198e48a189/merged/charts
2022-08-02 18:57:54 [DEBG] render env dir: /var/lib/containers/storage/overlay/42a607e6035faa68ddb6e9521ebfee64b111fdb4fd4badcb4d4407198e48a189/merged/manifests
2022-08-02 18:57:54 [DEBG] render env dir: /var/lib/containers/storage/overlay/42a607e6035faa68ddb6e9521ebfee64b111fdb4fd4badcb4d4407198e48a189/merged/etc
2022-08-02 18:57:54 [DEBG] render env dir: /var/lib/containers/storage/overlay/42a607e6035faa68ddb6e9521ebfee64b111fdb4fd4badcb4d4407198e48a189/merged/charts
2022-08-02 18:57:54 [DEBG] render env dir: /var/lib/containers/storage/overlay/42a607e6035faa68ddb6e9521ebfee64b111fdb4fd4badcb4d4407198e48a189/merged/manifests
2022-08-02 18:57:54 [DEBG] render env dir: /var/lib/containers/storage/overlay/42a607e6035faa68ddb6e9521ebfee64b111fdb4fd4badcb4d4407198e48a189/merged/etc
2022-08-02 18:57:54 [DEBG] render env dir: /var/lib/containers/storage/overlay/42a607e6035faa68ddb6e9521ebfee64b111fdb4fd4badcb4d4407198e48a189/merged/charts
2022-08-02 18:57:54 [DEBG] render env dir: /var/lib/containers/storage/overlay/42a607e6035faa68ddb6e9521ebfee64b111fdb4fd4badcb4d4407198e48a189/merged/manifests
2022-08-02 18:57:54 [DEBG] cmd for bash in host:  cd /var/lib/containers/storage/overlay/42a607e6035faa68ddb6e9521ebfee64b111fdb4fd4badcb4d4407198e48a189/merged && chmod -R 0755 *
2022-08-02 18:57:54 [DEBG] send  app images ,ip: <IP_ADDRESS> , init flag: false, app flag: true,image name: registry.cn-shenzhen.aliyuncs.com/cnmirror/cilium:v1.12.0, image type: application
2022-08-02 18:57:54 [DEBG] local copy files src /var/lib/containers/storage/overlay/42a607e6035faa68ddb6e9521ebfee64b111fdb4fd4badcb4d4407198e48a189/merged to dst /var/lib/sealos/data/default/rootfs
2022-08-02 18:57:55 [INFO] guest cmd is cp opt/* /usr/bin/
2022-08-02 18:57:55 [DEBG] cmd for pipe in host:  bash -c cd /var/lib/sealos/data/default/rootfs && cp opt/* /usr/bin/
2022-08-02 18:57:56 [INFO] guest cmd is helm install cilium charts/cilium --namespace=kube-system --set kubeProxyReplacement=strict --set k8sServiceHost=apiserver.cluster.local --set k8sServicePort=6443
2022-08-02 18:57:56 [DEBG] cmd for pipe in host:  bash -c cd /var/lib/sealos/data/default/rootfs && helm install cilium charts/cilium --namespace=kube-system --set kubeProxyReplacement=strict --set k8sServiceHost=apiserver.cluster.local --set k8sServicePort=6443
Error: INSTALLATION FAILED: cannot load values.yaml: error converting YAML to JSON: yaml: line 2119: could not find expected ':'
2022-08-02 18:57:56 [EROR] Applied to cluster error: exit status 1
2022-08-02 18:57:56 [DEBG] write cluster file to local storage: /root/.sealos/default/Clusterfile
2022-08-02 18:57:56 [INFO]
      ___           ___           ___           ___       ___           ___
     /\  \         /\  \         /\  \         /\__\     /\  \         /\  \
    /::\  \       /::\  \       /::\  \       /:/  /    /::\  \       /::\  \
   /:/\ \  \     /:/\:\  \     /:/\:\  \     /:/  /    /:/\:\  \     /:/\ \  \
  _\:\~\ \  \   /::\~\:\  \   /::\~\:\  \   /:/  /    /:/  \:\  \   _\:\~\ \  \
 /\ \:\ \ \__\ /:/\:\ \:\__\ /:/\:\ \:\__\ /:/__/    /:/__/ \:\__\ /\ \:\ \ \__\
 \:\ \:\ \/__/ \:\~\:\ \/__/ \/__\:\/:/  / \:\  \    \:\  \ /:/  / \:\ \:\ \/__/
  \:\ \:\__\    \:\ \:\__\        \::/  /   \:\  \    \:\  /:/  /   \:\ \:\__\
   \:\/:/  /     \:\ \/__/        /:/  /     \:\  \    \:\/:/  /     \:\/:/  /
    \::/  /       \:\__\         /:/  /       \:\__\    \::/  /       \::/  /
     \/__/         \/__/         \/__/         \/__/     \/__/         \/__/

                  Website :https://www.sealos.io/
                  Address :github.com/labring/sealos

reason
2022-08-02 18:57:54 [DEBG] render env dir: /var/lib/containers/storage/overlay/42a607e6035faa68ddb6e9521ebfee64b111fdb4fd4badcb4d4407198e48a189/merged/charts


Edit Apps Scripts on terminal?

I was sent here by http://stackoverflow.com/questions/24739294/external-editor-support-for-google-apps-script
Can I edit Apps Scripts via e. g. VIM? Is there a possibility?

Me Too :(
the short answer is No, up till now.
The long answer:
1-This project is designed to handle google drive files not google scripts. However google script is also google drive file!!.
2- So,You can download your project script by gdrive by

gdrive export ID

3- The whole project will be downloaded as single json file
4- The json file has key files which has a value of list, containing all files in it, each file is represented by an array has the keys: Id, type, name, source.
5- The source values is the script you want to edit.
6- No official way to extract the source to a single file.
7- If you write your own script to extract script source , you will encounter the last issue
8- you can't upload your edits, As gdrive has no authorization to upload google script projects !!
THIS ISSUE

You can use clasp project


JIRA/Confluence plugin issue: improper redirect URL handling

This is certainly not a docs issue but this is the only more or less relevant place I found to report it so please point me to the right direction if it isn't.
There's an issue in plugin that prevents it from redirecting back to confluence properly: it redirects to a non-existing page (because the original URL gets broken in the way when passing from one endpoint to another).
As far as I can tell, paths to redirect users to are not being urlencoded/urldecoded, and are simply splitted by ?, &, and = characters when dealing with query string, so any path from confluence, such as /pages/viewpage.action?pageId=1234567 are handled improperly; anything that follows question mark is truncated when a POST form (that is submitted to Azure) is created. This is a major inconvenience: when a session expires, and user clicks a link, they get redirected to authentication page and then (when auth is passed) to a non-existing page (/pages/viewpage.action in this example, without its query parameters) of JIRA/Confluence instead of the page they were redirected to authentication form from. It would be good if a URL is properly encoded before passing it via query string and decoded when query string parameters turn into form fields.
Feel free to reach out if you need more details on how to reproduce it or for more clarifications on the issue itself, I'll be glad to help.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d38cad90-6574-38c2-3262-059a9f975064
Version Independent ID: dd08d5c5-65a4-c2cc-8b51-7a35268dde68
Content: Tutorial: Azure Active Directory integration with JIRA SAML SSO by Microsoft
Content Source: articles/active-directory/saas-apps/jiramicrosoft-tutorial.md
Service: active-directory
GitHub Login: @jeevansd
Microsoft Alias: jeedes

Hi @kamazee , thanks for your feedback. We are looking into this. What do you have listed as your reply URL when you test this?

@MarileeTurscak-MSFT, thanks for following up!
When I try to open a page such as /pages/viewpage.action?pageId=1234567, I'm redirected to /pages/viewpage.action (I'm not sure I understand your question correctly, though).
I can attach the whole http chat sequence (with sensitive bits stripped) if that would help -- I've got it sniffed.
Also, I think the issue can be clearly seen if one debugs com.microsoft.atlassianplugin.jira.servlet.JiraSSOLoginServlet#doGet, specifically its part that prepares parameters to be inserted into a form that is further submitted to Azure service (however, this finding is not based on the source code, which unfortunately is not open, so it might be simply incorrect).

I've also just realized that my original statement is misleading: a couple of different issues got squashed together in my head. The plugin does not always redirect to the main page, it just handles URL to return a user to incorrectly, and returns a user to a non-existing page. I changed it accordingly.

@kamazee  I am working with our engineering team to review this. We will reach back to you shortly.

@kamazee We are able to reproduce this issue on our environment. AS part of the next action we will investigate and fix this issue on our side and will publish the updated version soon. Till that time I will keep this request open.

@chetansriv Please add this as a bug and assigned to me.

@MarileeTurscak-MSFT could you share a summary? Is it closed because it is fixed? Is it closed because it's not going to be fixed? Is it transferred to any other tracker and will be fixed (if yes, will there be an update here)?

@kamazee I was closing the issue itself since this is now being transferred to the PG team. I will reopen untill there is an update on the bug fix from their end.

We are still experiencing this issue. Any status update on when this is scheduled to be fixed?
I also notice that the download link for the plugin (https://www.microsoft.com/en-us/download/details.aspx?id=56506) now says that it's version 2.0, but when I download and install the plugin in Jira, it still says version 1.0.1.

We have same issue, our on-promised confluence redirect to /pages/viewpage.action after SSO login. We checked with Atlassian support, they said it's problem of the plug in. Any progress and update?

@kamazee and @pauska We have fixed this issue in the latest plugin in JIRA and Confluence. So can you please download the latest plugin and test again? Then I will close this ticket.

@jeevansd this is the best present for the issue anniversary! Will test and report back.

@jeevansd just to clarify: by "latest" you mean version 1.0.5 that was build about 3 months ago, right?

#please-close


Could not load file or assembly System.Text.Encoding.CodePages v6

Bug Report
Prerequisites

[x] Can you reproduce the problem in a MWE?
[x] Are you running the latest version of AngleSharp?
[x] Did you check the FAQs to see if that helps you?
[x] Are you reporting to the correct repository? (there are multiple AngleSharp libraries, e.g., AngleSharp.Css for CSS support)
[x] Did you perform a search in the issues?

For more information, see the CONTRIBUTING guide.
Description
With the recent update from v0.16.x to v0.17 we get issue due to failing dependencies.

One or more errors occurred. (Could not load file or assembly 'System.Text.Encoding.CodePages, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'. The system cannot find the file specified.

See here as an example.
I quickly checked the repo and it seems that the AngleSharp.csproj file really has the dependency to version 6 (see here) but the nuspec still points to version 5 (see here).
Before I do a PR or something else, is this mismatch on purpose?

Before I do a PR or something else, is this mismatch on purpose?

No its not. PR welcome; thanks!

Thanks for the swift response and merge ;)


⚠ Bio Links has degraded performance

In 6126cfa, Bio Links (https://bio.rheinklang.events/links) experienced degraded performance:

HTTP code: 200
Response time: 2011 ms

Resolved: Bio Links performance has improved in 3514dee after 11 minutes.


DLL not found?

Pretty self-explanatory :/

uhhh I'm not sure about this one honestly. I don't have such .dll on my device and it runs normally

get it from rtc

Would update it later so that it won't require the dependency


How does getStaticPaths handle new products / collections / blogs being added

We have a lot of products/collections and are adding close to 10/15 a week.
I notice that to load the paths you use getStaticPaths
Does this mean that we need to redeploy the app every time a new product/collection/blog is added? so it can load paths etc
If this is the case would the best solution be to build some sort of CRON job on a lambda to rebuild the client on its current commit? Is this documented/tutorialised anywhere on vercel?
Thanks in advance

@achadee If you host your site on Vercel, you benefit from Incremental Static Regeneration. When you post a new product it will regenerate homepage and product pages while users visit your site.  Also pages like this https://demo.vercel.store/search?q=clothes grabs latest data with SWR. If there is a new product and user clicks on it, is being generated on the fly, you don't need to rebuild.

Thats actually so good! Im so relieved that I don't need to code that!

@cond0r What are some in-code solutions for sites not deployed with vercel?


formData after rules are applied

If I have a simple rule that conditionally removes a field, how can I get a version of formData that does not include that field?
Currently, { formData } in onChange and onSubmit contains all fields, including those which are conditionally removed (i.e. hidden). Is this by design, or a bug on my end?
If my explanation is unclear I can provide a repro.

@oscar-broman remove - removes data from schema and uiSchema, but it does not affect formData. This is done in order to keep filled value if for some reason field will reappear. We are not going to change this behavior on our end.
You should define another action removeFromFormData, that would do what you want. Refer to documentation, on how to do that. You would sadly need to copy the original condition twice, until #38 is fixed.

I've fixed #38 and released a new version, where you can use array of events in rules definition

Nice! Thank you. I'll give it a try.


Implicit function types

Suggestion

🔍 Search Terms

implicit function types
✅ Viability Checklist

My suggestion meets these guidelines:

[x] This wouldn't be a breaking change in existing TypeScript/JavaScript code
[x] This wouldn't change the runtime behavior of existing JavaScript code
[x] This could be implemented without emitting different JS based on the types of the expressions
[x] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, new syntax sugar for JS, etc.)
[x] This feature would agree with the rest of TypeScript's Design Goals.

⭐ Suggestion
function literals should implicitly have a type - the same way class literals do.
📃 Motivating Example
Currently, to use dependency injection with functions, I have to explicitly add types for function literals, like so:
function sayHello(user: string) {
    window.alert(`Hello, ${user}!`);
}

type sayHello = typeof sayHello; // 👈 this

function start(sayHello: sayHello) {
    // ...
}

Intuitively, before you try that, you're going to try something this:
function sayHello(user: string) {
    window.alert(`Hello, ${user}!`);
}

function start(sayHello: typeof sayHello) {
    // ...
}

That doesn't work.
Contrast function declarations with class declarations, which "just works":
class HelloSayer {
    // ...
}

function start(sayHello: HelloSayer) {
    // ...
}

Why do class declarations get a type, and function declarations don't?
It's also not unconventional in JS to write "constructor" functions like this:
function HelloSayer(user: string) {
    return {
        sayHello() {
            window.alert(`Hello, ${user}!`);
        }
    }
}

function start(sayHello: HelloSayer) {
    // ...
}

There's even been popular talk of "new keyword considered harmful" over the years.
In JavaScript, the result of a class declaration isn't very different from the result of a function declaration - both result in a function type value in the same scope. Both are declarations parsed during the first pass, meaning you can reference them recursively.
And functions do have a type in TypeScript: you can extract it with typeof, and you can import it from another module with import type, so why is this type "hidden" or inaccessible from type-hints? Why do classes have this special status?
I think this could be "fixed" retroactively without any breaking changes, if declaration merging could be applied, allowing existing code to explicitly declare an identical function-type with e.g. type HelloSayer = typeof HelloSayer, since these would almost definitely have identical types. (Or, at least, this would be a very minor breaking change, only affecting codebases where some types are currently inconsistent with the types of function literals with the same name.)
💻 Use Cases
Dependency injection.

Intuitively, before you try that, you're going to try something this:
function sayHello(user: string) {
   window.alert(`Hello, ${user}!`);
}

function start(sayHello: typeof sayHello) {
    // ...
}

That doesn't work.

It works just fine, if you don't shadow the function name:
function start(sayHelloFn: typeof sayHell) {...}

It would be profoundly confusing (as well as actually a breaking change) to do this.

And functions do have a type in TypeScript: you can extract it with typeof, and you can import it from another module with import type, so why is this type "hidden" or inaccessible from type-hints? Why do classes have this special status?

The implicit type declared by a class is not the type of the value, but the type of the instance shape. What equivalent is there for a function -- maybe its return type? The same goes for enum; the type it declares is not the same as its typeof.
The non-declaration of types here is fully intentional.

It works just fine, if you don't shadow the function name:

I deliberately shadow names when injecting dependencies.
For one, inventing new names for no practical reason makes for really confusing code.
And for another, when you inject and shadow globals like document or window, you don't want somebody accidentally accessing the global rather than the injected instance of those objects by accident when making a change to the code.

The implicit type declared by a class is not the type of the value, but the type of the instance shape.

But it is the type of the value, e.g. something like: { new(): ... } with the actual instance shape being a structural subtype, the thing that is produced by the function when you apply new to it.
But I'm not trying to debate which types are declared, but the fact that other symbol declarations have a named type - and functions for some reason don't.
It's kind of surprising if you look at the declaration types side by side - it really looks like an inconsistency in the language:

The error message even says: 'Foo' refers to a value and suggests typeof Foo - so the compiler actually knows what it is I'm trying to do, but for some reason is going to make me jump through hoops to do it.

It would be profoundly confusing (as well as actually a breaking change) to do this.

That's a matter of opinion.
Personally, I find it profoundly confusing when languages deviate from their own norms on fine points like this - inconsistency in programming languages is always confusing and frequently frustrating.
I don't think you've made a very convincing argument why function declarations shouldn't work like all other declarations. The outcome of a class declaration in JavaScript is literally the same thing as a function declaration - a local symbol with the same type:

I understand that it's a breaking change - I explained as much in my original post, but also explained why I think it's probably a very minor breaking change, and how this could probably be made backwards compatible with declaration merging.
If it helps you understand why this is important, I wrote an article about it. Software quality is very important to me - and I think that's the main reason anybody chooses TypeScript. If you care about software quality, you most likely apply IOC everywhere, and it's very likely this will lead you to functional programming patterns eventually.
This would just be more natural and easier to explain, if you could simply type-hint parameters against types.
I wish you wouldn't dismiss the idea quite so promptly.

I wish you wouldn't dismiss the idea quite so promptly.

This is not the first time this has been suggested, considered, and rejected, nor the first time we've thought about what kinds of declarations should introduce kinds of symbols.

So you're saying others have felt the need for an improvement here.
What I'm suggesting may not be the answer, but it sounds like there's a real need here?
Or maybe I'm just reaching the point where I'm ready for a real functional programming language, heh 😉

Maybe this could be an optional feature you turn on via tsconfig?
If this is not a feature you want at all, do you know if it's possible to implement this as a TS compiler plugin? (Since it's a feature that affects type-checking and doesn't change any syntax, an option or plugin shouldn't interfere with use of other compilers like Babel or ESBuild, so that approach might work.)

do you know if it's possible to implement this as a TS compiler plugin? (Since it's a feature that affects type-checking and doesn't change any syntax, an option or plugin shouldn't interfere with use of other compilers like Babel or ESBuild, so that approach might work.)

As per the documentation, language service plugins can't customize the type system.

typeof Class is the type of Class as a runtime value--i.e. the class's constructor, with all its static members attached.  Class by itself is the type of object you get by calling new on it.  They are completely different types, with no subtyping relationship.  There is no equivalent to this dichotomy for regular functions.
As for why regular functions don't have a named type, it's for the same reason let x = 0; doesn't create a named type called x.  You have to use typeof x to get its type.  Same for functions.  typeof gets the type of an identifier that's accessible at runtime.  There is no separate runtime representation for the shape of a class instance (you have to actually call the constructor to get an instance), so TS creates a type that you can refer to when you need an instance.


Always apply field validation, on top of array & formRequest validation

WHY
BEFORE - What was wrong? What was happening before this PR?

You could not add validation to subfields directly in field.
You could not use field/controller validation in conjunction with FormRequest

Mainly because of the second reason I did this PR.
Story:
Our "pivot select field" (aka subfield) is mandatory to be required. I tried to add that as a field validation with validationRules. It was not possible to do because I was already validating this operation with a form request. So for the pivot to be mandatory required, we needed to ask the developer to add that validation rule on his FormRequest if using, otherwise add that rule in controller/field validation.
AFTER - What is happening after this PR?
You can mix validation however you please. It's helpfull for us (backpack) in terms that we can validate our pivot fields automatically for the developer. Also the added benefit that you can validate each repeatable field like a regular one, and the validation rules/messages would be transformed to the appropriate keys for validation.
HOW
How did you achieve that, in technical terms?
refactored, refactored and refactored.
Is it a breaking change or non-breaking change?
non-breaking
How can we test the before & after?
I used this field in MonsterCrud create operation to test all scenarios:
        $this->crud->setValidation(StoreRequest::class);

        $rules = ['vendors.*.something' => 'required|min:2'];
        $messages = [
            'vendors.*.something.required' => 'You gotta give me something!.',
            'vendors.*.something.min' => 'You came up short. Try more than 2 characters.',
        ];
        $this->crud->setValidation($rules, $messages);

        $this->crud->setOperationSetting('contentClass', 'col-md-12 bold-labels');

         $this->crud->addField([
            'name' => 'vendors',
            'type' => 'repeatable',
            'validationRules' => 'required',
            'validationMessages' => [
                'required' => 'i am vendor required'
            ],
            'subfields' => [
                [
                    'name' => 'something',
                    'type' => 'text',
                    'label' => 'zpsh'
                ],
                [
                    'name' => 'type',
                    'type' => 'select2',
                    'model' => 'App\Models\Product',
                    'attribute' => 'name',
                    'validationRules' =>  'required',
                    'validationMessages' => [
                        'required' => 'type is required doug!'
                    ],
                ],
                [ // select2_from_ajax: 1-n relationship
                    'label'                => 'Select2_from_ajax'.backpack_pro_badge(), // Table column heading
                    'type'                 => 'select2_from_ajax',
                    'name'                 => 'select2_from_ajax', // the column that contains the ID of that connected entity;
                    'entity'               => 'article', // the method that defines the relationship in your Model
                    'attribute'            => 'title', // foreign key attribute that is shown to user
                    'model'                => "Backpack\NewsCRUD\app\Models\Article", // foreign key model
                    'data_source'          => url('api/article'), // url to controller search function (with /{id} should return model)
                    'placeholder'          => 'Select an article', // placeholder for the select
                    'minimum_input_length' => 2, // minimum characters to type before querying results
                    'tab'                  => 'Selects',
                    'wrapperAttributes'    => ['class' => 'form-group col-md-4'],
                    'include_all_form_fields' => true, //sends the other form fields along with the request so it can be filtered.

                    'dependencies'         => ['type'],
                ],
            ]
        ]);

// setup all the other fields regularly from the arrays of fields.

@tabacitu added some commits to address your concerns and fix some stuff I found.
https://github.com/Laravel-Backpack/CRUD/pull/4220/commits/8199038115a92fc3abc1286850ceebfaa8f6052e and https://github.com/Laravel-Backpack/CRUD/pull/4220/commits/6b6c4017c8d19a4ff9e2b1420c06fcb8fb4a0d02 is to respect the unsetValidation() so it need to also unset the field validation too. Previously it would only unset the FormRequest validation.
https://github.com/Laravel-Backpack/CRUD/pull/4220/commits/6e33e9e75526534c16fcdbcab5e33142453b9772 and https://github.com/Laravel-Backpack/CRUD/pull/4220/commits/5120e82a11bb03271e09dc35011989d6dc6be16a are two small fixes, one for appending into requiredFields instead of replacing, and the other is to not attempt to validate when there are no rules defined, or for example, you run $this->crud->unsetValidation() 👍

Hey @tabacitu !
I agree with both of your proposals. I just finished them #4287
Let me know if something more is holding you here.
Thanks!

@pxpm looks like if we merge v5 into this... the unit tests start failing. Can you take a look, please?

Sure, it's done @tabacitu
We added tests for arrayed field names previously, and it catched this error since I didn't account for arrayed names here.
Cheers


Adjust Makefile and Container file for new home

Now that the project has been moved to the openshift-kni/oran-o2ims GitHub repository the Makefile and Containerfile need to be updated to use the new oran-o2ims binary generated by default.
Related: https://issues.redhat.com/browse/MGMT-16110

/lgtm Thank you, Juan.


Explicitly import github.json

Hey:
I"m webpacking remark and a few friends and ran into the following error in a file importing remark-html:
ERROR in ./~/hast-util-sanitize/lib/index.js
Module not found: Error: Cannot resolve 'file' or 'directory' ./github in /Users/cloverich/Projects/chronicles/node_modules/hast-ut
 @ ./~/hast-util-sanitize/lib/index.js 15:15-34

I traced it here; I have json-loader set-up in my webpack config but it would only accept this if I made the filetype explicit. I researched a bit but could not figure out if this was canonical / intentional or not -- so please accept my apologies if this is misplaced. I considered opening an issue but figured this was the same effort.
Very much enjoying remark and its related projects!

Thanks, but this is a duplicate, already discussed before (the linked comment shows how you can fix this in your codebase)

Ah nuts, I checked the closed issues but not the closed PR's -- and now I continue the problem. Sorry!

@cloverich No problem ;)


In mempool behaviour use own locks instead of mempool manager locks

This PR addresses one of the issues in #1250 in regards to refactoring mempool behaviour to use it's own locks instead of relying on mempool manager locks. There is one occurrence that required leaving the mempool manager lock. Initially I tried removing it but that caused peers to be dropped, so it must be still required.
This PR also fixes the issue #1375 by actually adding the inventory items to the list of items that is sent.
I have also improved logging support in mempool behaviour which I needed in order to troubleshoot this PR, as well as added some high level logging into mempool orphans.
I tested this PR on both fully synced Bitcoin and Stratis Testnets by running the node fully synced for several hours with full mempool logging and examining the logs for any anomalies. Things appear to
behave as expected.
Integration and unit tests were also run with no new failures identified.

I made an initial review but as @Aprogiena said perhaps a revisit of this logic is needed, my comments still apply though.

Don't review new changes yet - I still need to move to hashsets and figure out to do with the lock that's still being debated.

I changed the collections from dictionary's to hashsets. So I think that I'm pretty much caught up on changes suggested other than the one last remaining mempool manager lock. Let me know if you guys think we should change that in this PR as well.
Going to run my nodes for a while and see if anything breaks but so far so good. My bitcoin node has already accepted several mempool tx's so at least the basics seem to be working.

As mentioned above, I don't think the global lock should be resolved by this PR.

One of the main reasons for this PR is to not use the mempool lock other then mempool operations and we still are, so please either do it in this PR or a following PR immediately after up to you @mikedennis

In that case it should be rewritten completely. I don't think this PR can solve that.

I've addressed the remaining code review issues. I also have removed that last mempool lock and things seem to be hanging together. I've been running on bitcoin testnet for several hours and haven't observed any strange behavior or nodes dropping.

@mikedennis did you sync all the way to the tip and observer transactions going on to the mempool? (just confirming)

@dangershony Yes I ran fully synced on both stratis and bitcoin testsnets. Not much for mempool txs on stratis but did see a couple go through, but lots of action on bitcoin. Things seem to be behaving.

Ok great I will try to run the networks myself today.

Hi @mikedennis I made some changes to help you out, can you run the latest version instead (and tests)?

@dangershony thanks for the help!
I reviewed your additions and fixed up a couple of minor typos, but nothing that should change any functionality. I also ran synced bitcoin testnet node for a couple of hours and it seems to be accepting tx to memory pool and adding orphans etc with no nodes dropping or anything. Looking good!
I ran the integration tests and no new failures (only the ones that always fail for me). I've also started up my stratis testnet node but haven't gotten to the point of having any txs yet so haven't been able to verify it yet but it also is behaving as expected so far.

Hi @mikedennis please pull again the PR I made some more changes so the orphan stats are correct.

@dangershony Ran the node with new changes - didn't see any issues. Also ran all integrations tests again. They are also passing.

OK we need another candidate to run networks and tests (review is high)

It might have been doing this before but I noticed lots of orphans when syncing:
      ======Node stats====== 06/07/2018 23:56:52 agent StratisBitcoin:1.1.7
      Headers.Height:      1324552  Headers.Hash:<PHONE_NUMBER>037c4fd2349de326eef290d7756f215bc18af84671f6812ab0d3e1
      BlockStore.Height:   1324436  BlockStore.Hash:<PHONE_NUMBER>000129e00571f3dcc3d13089d9c332243859b5434c4970e91aaba2
      Consensus.Height:    1324442  Consensus.Hash:<PHONE_NUMBER>00010f14d5417b09233e9cc112ced6d74104f1dc7ba815c625497e
      Wallet.Height:       No Wallet

      ======Mempool======
      MempoolSize: 21   DynamicSize: 36 kb  OrphanSize: 49

Yes thats fine, before the orphans where not correctly displayed so it was always zero.
If the orphans number is changed (up/down) then I beleive it ok.
@noescape00 will sync netowrks as well (Ivan most important is to run on a fully downloaded chain to see mempool trx) so less imporatnt to sync from genesis.

Thanks @noescape00


Those lights

I created this balanced dark color scheme when I couldn't find anything I liked. I hope others derive some peace from it too!

thank you


Endpoint with all the available Tags

Description
It would be very useful 🚀

The /tags endpoint returns a list of all tags (see documentation)
Usage (try in browser)
GET /tags

didn't read that, thanks!

No problem.


DEV1A-1215: fix namespace casing

As discussed with @akertesz, update the casing of intel namespace to INTEL.
Fixes DEV1A-1215.
FYI @akertesz please review and merge.
Type of change

[X] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?
Not tested.

Thanks Tony.
No need to wait for the tester to run -- since this beta10 update is incompatible with beta09, the tests are expected to fail. I will merge immediately.


How to use thanos receiver

I see the thanos-operator is supported thanos receiver. How do i deploy
https://github.com/banzaicloud/thanos-operator/issues/33
Thank you

It is still in an early phase, but you can try it out using the Receiver custom resource:
https://github.com/banzaicloud/thanos-operator/blob/master/config/samples/monitoring_v1alpha1_receiver.yaml
The example above will require you to set up an object store secret and prometheus on your own, or you can simply try running make install-thanos for a development setup with minio and pomerium.
The above will require you to install CRDs and run the operator locally using make install and make run


Warning is not returned for this command: Connect-AzAccount -UseDeviceAuthentication

Hi @daverickdunn hope you're doing well.
Been using this library for quite some time (as you may remember) and it's worked wonderfully.  I'm running into a bit of a wall with one particular command and wondering if you have any ideas.
The last line in the log is:
[>] invoking: Connect-AzAccount -UseDeviceAuthentication
... and then nothing.
Just for the heck of it I tried the same command in node-powershell and got this printed in the log:
WARNING: To sign in, use a web browser to open the page https://microsoft.com/devicelogin and enter the code EA7LKRDG8 to authenticate.
Any idea if it's possible to get that warning message?  Ultimately I'm trying to script something that opens the browser and logs in (automatically) using a combination of full-powershell and puppeteer.  If I can just get the warning message I think I can do it.  I was expecting the warning message to come from the warning$ stream ... but nothing comes through.
I did pull down your source code and tried to write my own unit test ... and saw the same behavior.  "Connect-AzAccount -UseDeviceAuthentication" hangs (no messages appear in the streams).
Here is the unit test.  If you have a moment would you mind running and seeing if you see the same behavior?
test('Connect-AzAccount', (done) => {
    let shell = new PowerShell();
    shell.success$.subscribe(
        (res) => {
            console.log('res', res)
            shell.destroy();
            done();
        }
    );
    shell.warning$.subscribe(
        (res) => {
            console.log('res', res)
            shell.destroy();
            done();
        }
    );
    shell.debug$.subscribe(
        (res) => {
            console.log('res', res)
            shell.destroy();
            done();
        }
    );
    shell.info$.subscribe(
        (res) => {
            console.log('res', res)
            shell.destroy();
            done();
        }
    );
    shell.verbose$.subscribe(
        (res) => {
            console.log('res', res)
            shell.destroy();
            done();
        }
    );
    shell.error$.subscribe(
        (res) => {
            console.log('res', res)
            shell.destroy();
            done();
        }
    );
    shell.call('Connect-AzAccount -UseDeviceAuthentication', null)
});

OK, I've gotten closer.   Seems like the warning message comes through in stream 3>$null.  I'm not sure why it doesn't emit an event in the $wv variable.
try {
        Invoke-Command -NoNewScope -ScriptBlock {
            ${command}
        } 1>$null 2>$null 3>$null 4>$vv 5>$dv 6>$null -ov ov -ev ev -wv wv -iv iv
    }

If I tweak so that 3> writes to a file ... I can see the warning message in the file!
try {
        Invoke-Command -NoNewScope -ScriptBlock {
            ${command}
        } 1>$null 2>$null 3>$wv 4>$vv 5>$dv 6>$null -ov ov -ev ev -iv iv
    }

I might try (tomorrow) writing a custom "call" method that redirects to a file.  Maybe there's a way to redirect to a file and a variable (if that makes sense?) I'm not good enough with Powershell though.
This is a ONE OFF.  So if I can create my own call method, which should be possible, there's no need for any code changes to your repo.  Will post back my results!

An update:

I was able to provide my own "wrap" function and get this working as I wanted!  Woohoo!
Then I discovered an easier way ... and don't need any of this anymore.

It was still interesting to go through all this but sometimes at the end you discover a way that's 10x easier ... oh well!
I will close this ticket.

Hey, sorry, I was on holidays last week. I'm glad you got sorted, but that's still interesting nonetheless and I might try to fix it for posterity. Which PowerShell, OS, etc. were you using? Thanks.


Do not run clippy-check if the branch was pushed by dependabot

Signed-off-by: Thomas Farr<EMAIL_ADDRESS>Description
Workflows triggered by dependabot run with a restricted readonly github token, as such it does not have permissions to write the clippy-check annotations, as can be seen here: https://github.com/opensearch-project/opensearch-rs/actions/runs/3093397255/jobs/5005721692
https://github.com/opensearch-project/opensearch-rs/actions/runs/3093397255/jobs/5005721692
Package updates should not introduce clippy lints due to not changing code.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #79 (467ece2) into main (11bd69a) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main      #79      +/-   ##
==========================================
- Coverage   42.32%   42.30%   -0.02%
==========================================
  Files          49       49
  Lines       27969    27969
==========================================
- Hits        11837    11833       -4
- Misses      16132    16136       +4

Flag
Coverage Δ

integration
42.30% <ø> (-0.02%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

opensearch/src/http/response.rs
16.18% <0.00%> (-2.32%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


WIP Add gender field to the personal information form in user account

Closes #1200

Looks good so far! Could you also attach a screenshot of the form after adding the styling changes?

There definitely should be a distinction between "we don't know"
and "prefer not to say".
On 18.02.2020 09:38, umgelurgel wrote:

@umgelurgel commented on this pull request.

In conference/models.py
https://github.com/EuroPython/epcon/pull/1201#discussion_r380524100:

@@ -336,9 +343,15 @@ class AttendeeProfile(models.Model):
phone = models.CharField(
_('Phone'),
max_length=30, blank=True,

   help_text=_('Enter a phone number where we can contact you in case of administrative issues.
Use the international format, eg: +39-055-123456'),

   help_text=_(

       'Enter a phone number where we can contact you in case of '

       'administrative issues.
Use the international format, '

       'eg: +39-055-123456'

   ),

)
gender = models.CharField(

   max_length=1, choices=ATTENDEEPROFILE_GENDER, blank=True, default=""

Regarding the default, I'm wondering whether it's worth it to
distinguish between users who have yet to provide a value and users who
selected |prefer not to say|. WDYT?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/EuroPython/epcon/pull/1201?email_source=notifications&email_token=ACOLSRMEW3LNFEUCHNP2IMLRDONBZA5CNFSM4KWZ7OEKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCV3XHDI#pullrequestreview-360149901,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACOLSROKUOXWBDUGBCYNW6DRDONBZANCNFSM4KWZ7OEA.

--
Marc-Andre Lemburg
EuroPython Society Chair
http://www.europython-society.org/
http://www.malemburg.com/

I belive the same model is used as backend for the CFP form, where last year we had a free text form instead of a dropdown.
That also means that there are more values in that field already
> select count(distinct gender) from conference_attendeeprofile;
19

I checked the database: the existing gender field would probably serve as better template for default values than the t-shirt size. Because the system (used to) default to men's L for t-shirt sizes, we have quite a few entries which don't match the name or gender setting in the profile.

We'd have to change the existing gender field to a drop-down, though, also in the CFP form and normalize the database.

Hmm, looking at the numbers, we still need some form of logic which requires users to set the gender when they log in to the site. We only have the information from speakers and not from regular attendees.

Changed in the CFP page as well and added a blank default in case they choose not to answer at all. Below are some screenshots with the pages.

@artcz @umgelurgel can you take a look and let me know if I missed any other place where gender should be present in a form or template? Otherwise I would merge this so we can have it for launch.

@aramboi I'm leaving this umerged for now - I think it's best to merge it only once the gender data in staging is normalised, so that this can be deployed.

On 27.02.2020 19:26, umgelurgel wrote:

@aramboi https://github.com/aramboi I'm leaving this umerged for now -
I think it's best to merge it only once the gender data in staging is
normalised, so that this can be deployed.

Hi Angel,
it's better to start from scratch. The existing data is unreliable.
Thanks,
Marc-Andre Lemburg
http://www.malemburg.com/

@malemburg @umgelurgel @matrixise Made the changes required in both tickets. Please review.
Right now we check if gender is present on the cfp, cart and user dashboard pages. If it is not, we redirect the user to the user settings and post a message to complete their profile.

Looks good. Thanks, Angel.


Builld on Ubuntu 14.04 done but with errors

I made a build from source in an Ubuntu 14.04 machine (current Ubuntu LTS version) and got some errors on the console.
The editor is wroking anyway.
Here is what I got.
Running "set-version" task
Done, without errors.
Running "install" task
Done, without errors.
Running "mkrpm" task
>> script/mkrpm: línea 12: rpmdev-setuptree: orden no encontrada
Aborted due to warnings.

@voylinux, for Debian-based distributions (inc. Ubuntu) you only need to run mkdeb.
script/grunt mkdeb

rpmdev-setuptree script is part of Fedora's rpmdevtools.


Enable-WriteCore-feature-for-websites

Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.

API change check
APIView has identified API level changes in this PR and created following API reviews.
Azure.ResourceManager.AppService


Acceptance Criteria

GIVEN an employee payroll tracker
WHEN I click the "Add employee" button
THEN I am presented with a series of prompts asking for first name, last name, and salary
WHEN I finish adding an employee
THEN I am prompted to continue or cancel
WHEN I choose to continue
THEN I am prompted to add a new employee
WHEN I choose to cancel
THEN my employee data is displayed on the page sorted alphabetically by last name, and the console shows computed and aggregated data

meets all acceptance criteria per last commit


add deploy command

What did you implement:
Add deploy sumologic command
How can we verify it:
Run yarn sls deploy sumologic in CLI.
It should deploy just the sumologic stack.
Todos:

[x] Write tests
[x] Write documentation
[x] Fix linting errors
[x] Provide verification config/commands/resources

Codecov Report

Merging #9 into master will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master        #9   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           13        13
  Lines          136       136
  Branches        13        13
=========================================
  Hits           136       136

Impacted Files
Coverage Δ

src/index.js
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb18355...b953c27. Read the comment docs.


Persist configuration information

Persist the following information in the metadata repository database:

Package list, identifying which packages this service instance will monitor
Date range, identifying which months/years this service instance will monitor

If no configuration document is found in the metada repository database, a default shall be created.

Delivered by #6


Ferret crashes upon evaluating a typo (variable preceded by a period)

Reported by andrew wittenberg on 12 Jul 2013 22:12 UTC
Discovered this crash by accident, due to a typo in one of my scripts.  Probably not a big deal, but might want to trap this kind of thing in the parser.
 	NOAA/PMEL TMAP
 	FERRET v6.725
 	Linux 2.6.18-274.12.1.el5 64-bit - 04/10/12
 	12-Jul-13 18:05

yes? list .hello
STOP ALG_BREAK_UP

Similarly for
plot .hello
say `.hello`

etc.
Migrated-From: http://dunkel.pmel.noaa.gov/trac/ferret/ticket/2084

Comment by ansley.b.manke on 12 Jul 2013 23:50 UTC
We definitely want to avoid these STOP's when possible. I've fixed this, so we'll just see an error:
yes? list .hello
 **ERROR: command syntax: .HELLO

and likewise for other commands.


Added a couple of metohods to obtain the variogram model points or to save them to a file

Hi, I've added a couple of methods to UniversalKriging and OrdinaryKriging:

get_variogram_points: wich returns a numpy.array [lags, variogram_value_at_lags] which can be used of interest for the user (for further computations).
save_variogram_to_file: wich saves the variogram to a file output_file with separator separator(which defaults to space  ) with the format lag variogram_value_at_lag according to the separator. Making a call with separator="," would save the values as lag,variogram_value_at_lag.

I'd like to help on the docstrings side, maybe I don't know the API well, but I could help with styling or infering what each of the method does

As for AppVeyor, I figured the problem is with the conda environment for Python 3.5, I did looked what happened, but can't remember the specifics now

With the docstrings, we're trying to follow the numpy docstring convention: https://numpydoc.readthedocs.io/en/latest/format.html#docstring-standard
Most of the main routines (__init__, execute) use these formats now, so you can check them for reference...

As for AppVeyor, I figured the problem is with the conda environment for Python 3.5, I did looked what happened, but can't remember the specifics now

We can ignore the failed Appveyor test, it's a known issue that is fixed on master https://github.com/bsmurphy/PyKrige/commit/0569194b0655af02a37909e337e1c157fa6362c5

Well, I'll look into that, where can I read more about the API? I'd like to be in full compliance with it.

We don't really have a write-up for API principles, so it mostly a discussion at review time. For my part I think it would make sense to adapt as much as possible of scikit-learn's API design. Also if you are integeresed in general ideas about the scipy API principles, see the second part of this presentation particularly starting from slide 60.

Hey, sorry for the late commits, I've added a couple of tests for the method get_variogram_points and an extendend docstring to them. Do you agree with the name of the method get_variogram_points or is it explicit enough? on the other hand, I hope you like what I've made, It is kinda my first time using pytest, and tried to comply with the use of the already existing test data you have. Looking forward to know what you think.
Daniel.

Looks good to me! I think the name is good, fits with the general convention we have going. @rth might have some comments, but I'd say we can go ahead and merge once he takes a look.

@rth, can we merge this?

Sorry for the late response, yes this LGTM, merging. Thanks @Daniel-M !


update humaneval postprocessing

As highlighted in issue https://github.com/bigcode-project/bigcode-evaluation-harness/issues/46 it's possible to have more than one stop word in the code completion and keeping only last black might leave intermediate functions for example. Normally we have the stopping criteria that stops generation once there's a stop word, but when batch_size>1  it's done on all batch and generation stops only when all of them have seen a stop word.
This doesn't seems to have a noticeable impact on performance though especially pass@1 and pass@10.
EDIT: another fix, following this discussion with @Muennighoff he noticed that the eos_token is being skipped during the decoding and this can lead to generations with unwanted extra text when batch_size > 1. Thanks for the fix!

Thanks Niklas! I think for now this will be just the HumanEval python openai version but I'll keep that in mind.


Allow tracking of all trackable links within a container

Creating a single event listener is more efficient than one for every link that could be clicked. It also reduces the number of unique modules that must be started.

Use new pattern on breadcrumbs and related links
I've tested the correct events are generated in frontend

Will make https://trello.com/c/62Gy8pyj/77-track-interactions-with-contents-lists-1-s more efficient.
cc @tijmenb @alecgibson @nickcolley

Closing to add a further feature.

I've tested this branch alongside government-frontend and it's working as expected, do we need to update some docs to indicate the new usage?

I don't think there are docs at the moment.

@fofr How well does this cope with nesting? What happens in these cases?

Two tracked items are nested within one another (eg this possibly happens in the service-manual-frontend accordion?)
Two tracking modules are nested inside each other. For example, let's say so many elements are tracked on a page that someone decides to move the tracking module up to some wrapper. However, that wrapper might contain, eg breadcrumbs, which also instantiate the module. Would we get a double tracking event fired?

@alecgibson The modules shouldn't be nested.

The most nested item would be tracked
Click events would be tracked twice

Do you have an example of either of these happening intentionally?
If more advanced tracking of multiple features with a single click was a required feature we'd develop for it when it was needed.

@fofr My point is more that it's easy to accidentally nest modules (for example, you might forget that breadcrumbs already instantiate the module). Given that the whole point of this module is to accurately track how many times things were clicked on, I think this is important to guard against.
As for complex element tracking, see https://github.com/alphagov/service-manual-frontend/blob/master/app/assets/javascripts/modules/accordion-with-descriptions.js#L284
These are both nasty side-effects of this event delegation pattern (if listeners are attached to all the DOM nodes instead, then an event is fired every time an event propagates through them, as expected).
If this is a pattern that we intend to stick to, I'd suggest creating some sort of well-tested JavaScript Event Delegator object, who takes a callback and a selector, and makes sure that things like nesting are gracefully handled. This sort of refactoring could certainly be left for the next time we implement this pattern, but I definitely think we should be guarding against weird nesting behaviour, because it's highly unintuitive and could be hard to track down.

it's easy to accidentally nest modules (for example, you might forget that breadcrumbs already instantiate the module).

If we see this become a problem we can fix it then, and build an advanced event delegator when we need to. I agree there is some risk, but also that the risk is small and similar to misuse of the module pattern we already have.
We have a similar pattern in place on admin tools and haven't had these issues:
https://github.com/alphagov/govuk_admin_template/blob/master/app/assets/javascripts/govuk-admin-template/modules/track_click.js

@fofr sounds okay to me - the thought just occurred to me and I thought I'd flag it. If you think it's an acceptable risk, then that's fine.

Thanks @fofr and @alecgibson 👍  😄


:tada: 500th PR!... and improved data model for calendars

What's New?

Calendar occurence objects are much more flexible and ready for the future / changes
Added integration test helper for Angular

What's Next?

Figure out why js-data needs an adapter object all of the sudden? (Bug? Misunderstanding of the library? Not sure yet.)
Add better parameter validation for when a sequence_id is missing in schedule creation parameters

Will rectify hound issues in next PR- merging and deploying meow.


MNT: Update repo URL of sklearn nightly build, fix sparse matrix persistence issue

See this comment.

Hmm, I'm really stumped about this error. First of all, even though pickle does not have the problem, saving and loading with scipy (which skops uses under the hood) has the same issue:
>>> from scipy.sparse import load_npz, save_npz
>>> from scipy import sparse
>>> x = sparse.csr_matrix((3, 4))
>>> x.has_canonical_format
True
>>> x._has_canonical_format
True
>>> save_npz('/tmp/sparse_matrix.npz', x)
>>> y = load_npz('/tmp/sparse_matrix.npz')
>>> y._has_canonical_format
AttributeError: 'csr_matrix' object has no attribute '_has_canonical_format'

So in a way it's already broken in scipy, but probably it's not considered a problem there, since it's a private attribute.
What surprises me, however, is that the issue only occurs now. The change in scipy is already 10 years old, so this is not caused by a new scipy version. So then I thought that there was a change in sklearn recently, but the corresponding attribute was also last touched a long time ago (5 years), therefore, this is also not an explanation.
The most likely explanation has thus to be some change in scipy.sparse.diags, which is what is being called by sklearn and has been changed in the last month. I suspect that somewhere inside that function, the attribute is indirectly created, but I cannot pinpoint out where and what recent change affected this.
Anyway, I'll push a solution that will ensure that the private attributes are present on the loaded object iff they were present on the original object. This is achieved by remembering if the attribute was there when storing the state. If it was, when loading the object, loaded.has_canonical_format is accessed, which, as a side effect, creates the private attributes. This is a somewhat ugly solution, but I think it is the "most correct" solution short of fixing the problem inside of scipy.

Okay, CI is green, ready for review @skops-dev/maintainers. Until this, or a different fix, is merged, CI will be red for everyone :/

This to me is similar to the flags issue we had with numpy, i.e. it doesn't affect the actual values in the matrix, and only gives an information about how it's stored.
I think we can safely just ignore this attribute instead of trying to save it.

So the suggestion would be to add a special case to the tests to explicitly remove those two arguments?

yeah I'd just remove them.

@adrinjalali pls take another look.

Its not related to this commit
I just wanted your help in setting up environment in local machine
git clone git@github.com:jot-s-bindra/skops.git
git init
git checkout -b new-feature
conda create -c conda-forge -n skops python=3.10
conda activate skops
python -m pip install -e ".[tests,docs]"
conda install -c conda-forge pre-commit
pre-commit install
pytest

during pytest i am recieving variable declare errors , modules not installed errors like
ERROR examples/plot_california_housing.py - KeyError: 'HF_HUB_TOKEN'
ERROR examples/plot_hf_hub.py - KeyError: 'HF_HUB_TOKEN'
ERROR examples/plot_intelex.py - KeyError: 'HF_HUB_TOKEN'
ERROR scripts/clean_skops.py - OSError: pytest: reading from stdin while output is captured!  Consider using -s.
ERROR spaces/skops_model_card_creator/app.py - ModuleNotFoundError: No module named 'streamlit'
ERROR spaces/skops_model_card_creator/create.py - ModuleNotFoundError: No module named 'streamlit'
ERROR spaces/skops_model_card_creator/edit.py - ModuleNotFoundError: No module named 'streamlit'
ERROR spaces/skops_model_card_creator/gethelp.py - ModuleNotFoundError: No module named 'streamlit'
ERROR spaces/skops_model_card_creator/start.py - ModuleNotFoundError: No module named 'streamlit'
ERROR spaces/skops_model_card_creator/tasks.py - ModuleNotFoundError: No module named 'streamlit'

In order to run hugging face related commands, you need to have your token present in HF_HUB_TOKEN environment variable.
The spaces folder is not for most users. If you want to run it locally, you need to have its dependencies including streamlit installed.


Implement Pymoo

Spinning this out to a new issue so it can be developed independently from nlopt
Also just found out about https://pymoo.org/
Originally posted by @tinosulzer in https://github.com/paramm-team/pybamm-param/issues/30#issuecomment-1453668987

There is some more to be done here but if other people want to have a tinker setting up and solving problems then I think that would be useful.
https://github.com/paramm-team/pybamm-param/commit/15e5610bfc88832cdf8ed83100c6a7a817fc714b

I tested it on datafit but it takes quite long time. There could be an error for datafit class.

After my last comment, I tested Pymoo on multi-variable and single-variable datafit examples and it works fine. It's just slow as multi-variable took 3,5 hours and single variable is 30 mins. @PipGrylls Is there a faster option than NSGA? NSGA2 might be slow for a default method.


update deepsparse perf analysis onnx test files for latest DS build

Can we get this PR approved so it can land and fix the test failures?

I'm going to go ahead and force-land this so we can clear the test errors on main @dhuangnm @bfineran


update: updated variables, read replica option

updated variables, read replica option
closed #14 #13

This PR is included in version 0.1.2 :tada:


hardened runtime?

Is it possible to use this to sign with hardened runtime? (--options=runtime)

I do not normally work on Mac applications, so I do not know, but I would guess that this cannot do that. From the docs, it seems that hardened runtime is something set in an entitlement, and currently this project cannot set entitlements. However the code for signing entitlements is there, just not any way to set entitlements.

Thanks for the response. I am investigating how to notarize a mac app, and it seems that one has to use Apple's codesign to set --options=runtime. But maybe there is a way to do it with signapple so that my detached-sig-create.sh doesn't have to switch from signapple to codesign.

I've added an option that enables hardened runtime when signing.


Add Selection Based support for Java

Try to run "script" run code package in atom but it says "Selection Based runner not available for Java." even tho the package says it support java language. Whats wrong?

Since its been a while closing since its a duplicate of #796, but if you still have issues respond with:

Minimal java file that causes the issue
Exact steps to reproduce
Screenshots/Gifs of what is going wrong


Invoke ginkgo with default args from task

Additionally, use go moduled ginkgo instead of the one on PATH, so that it will always remain up-to-date

Hi @ebroberson
Can you resolve the conflicts on this PR?
Thanks!


[Feature Request] Additional kind of crits

Currently game settings allow to double damage or dices. Please add 3rd option to take maximum of "basic damage" and roll only additional dices.

Double the dice and double the damage are variant rules in the CRB, what you suggest here is not. We do not actively build homebrew rules into the system usually.
Also, this is far more complex to do than one might think because of fatal on the "how does it even work" side and because of the code that does the rolls on the implementation side.


Doesn't work with multiple services on one container

Currently, there is a problem when configuring multiple routers on one container.
For example:
minio:
  image: quay.io/minio/minio
  volumes:
    - ./minio:/data
  ports:
    - 9000:9000
    - 9001:9001
  command:
    - server
    - /data
    - --console-address
    - ":9001"
  environment:
    MINIO_ROOT_USER: root
    MINIO_ROOT_PASSWORD: root
  labels:
    traefik.enable: true
    traefik.http.routers.s3.rule: "Host(`s3.example.com`)"
    traefik.http.routers.s3.entrypoints: webs
    traefik.http.services.s3.loadbalancer.server.port: 9000

    traefik.http.routers.minio.rule: "Host(`minio.example.com`)"
    traefik.http.routers.minio.entrypoints: webs
    traefik.http.services.minio.loadbalancer.server.port: 9001

It would be really nice to get this working, as it is a bit annoying to put the second one into a different config file :)
Regards,
Dorian

Please could you fix this? I'm also keen on this feature :)

@dorianim @hongkongkiwi I just tested this locally and it appears to work without issue. See this sample compose file where I just added an example of a service with multiple ports exposed.
Here's the output when I bring up that service:
time="2022-09-10T14:36:00-04:00" level=info msg="refreshing traefik-kop configuration"
time="2022-09-10T14:36:00-04:00" level=warning msg="found more than one host-port binding for container '/testing-helloworld-1' (5555:5555, 5566:5566)" service=hello2@docker service-type=http
time="2022-09-10T14:36:00-04:00" level=info msg="publishing http://<IP_ADDRESS>:5566" service-type=http service=hello2@docker
time="2022-09-10T14:36:00-04:00" level=warning msg="found more than one host-port binding for container '/testing-helloworld-1' (5555:5555, 5566:5566)" service=hello1@docker service-type=http
time="2022-09-10T14:36:00-04:00" level=info msg="publishing http://<IP_ADDRESS>:5555" service=hello1@docker service-type=http

Ok, nevermind, I just forgot do define the service name. It works like this:
minio:
  image: quay.io/minio/minio
  volumes:
    - ./minio:/data
  ports:
    - 9000:9000
    - 9001:9001
  command:
    - server
    - /data
    - --console-address
    - ":9001"
  environment:
    MINIO_ROOT_USER: root
    MINIO_ROOT_PASSWORD: root
  labels:
    traefik.enable: true
    traefik.http.routers.s3.rule: "Host(`s3.example.com`)"
    traefik.http.routers.s3.entrypoints: webs
    traefik.http.routers.s3.service: s3
    traefik.http.services.s3.loadbalancer.server.port: 9000

    traefik.http.routers.minio.rule: "Host(`minio.example.com`)"
    traefik.http.routers.minio.entrypoints: webs
    traefik.http.routers.minio.service: minio
    traefik.http.services.minio.loadbalancer.server.port: 9001


Support IpRange

What would you like to be added?
Implement IPRangeClaim
Why is this needed?
Support more IPAM types

Closed by https://github.com/netbox-community/netbox-operator/pull/130


Administrative options are not shown to users who are configured as managers

Fresh deployment of v1.3.  API permissions granted and the /sites/ChampionManagementPlatform SharePoint site was successfully provisioned.
All employees were granted edit access to the site collection.  Users who have been added to the Member List as managers do not see any administrative options in the Teams app, only the "Leaderboard" icon, receiving the following error in Teams for web:
"An embedded page at (tenant sp root collection) says / an unexpected error occurred while retrieving user role.  Below are the details: TypeError: Cannot read property 'toLowerCase' of undefined"
Tried deleting app and site and re-deployed, to no avail.

Hi @jwilcot,
Thanks for your feedback. Closing this issue.


Small refactor

Proposed changes
Implementing some of the minor changes discussed in my review of PR #63

https://github.com/ScuffleTV/scuffle/pull/63#discussion_r1126619829
https://github.com/ScuffleTV/scuffle/pull/63#discussion_r1126094642
https://github.com/ScuffleTV/scuffle/pull/63#discussion_r1126636700
https://github.com/ScuffleTV/scuffle/pull/63#discussion_r1126325355
https://github.com/ScuffleTV/scuffle/pull/63#discussion_r1126338350

Types of changes
What types of changes does your code introduce to Scuffle?
Put an x in the boxes that apply

[ ] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] Documentation Update (if none of the other choices apply)

Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

[x] I have read the CONTRIBUTING doc
[x] Lint and unit tests pass locally with my changes
[ ] I have added tests that prove my fix is effective or that my feature works
[x] I have added necessary documentation (if appropriate)
[ ] Any dependent changes have been merged and published in downstream modules

Further comments
Time to sign that CLA :Clueless:

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

If you are going to rename the extend_gql method you might as well also rename the extend_route method too.


Add typing rules for MIR

This adds basic typing rules for MIR.
Currently still work-in-progress.

@voidc needs rebase :)

@voidc let's discuss next steps here!  I think this is going in the right direction but it probably makes sense to map out the plan a bit in advance.

@nikomatsakis definitely! I'm currently still on vacation but will continue to work on this next week. We could talk about the next steps during the meeting on Wednesday or before - whatever works for you.

I updated the typing rules to match the new grammar. Also I added the typing-goals file which contains a translation of the typing rules into goals.

Going to merge this, thanks! I'm doing some local experiments based on this branch to decide on the best overall approach.


rect() API

I've just seen the video on the rect and square implementation. Nice job!
I was wondering why you chose rect as a named argument. I think using the rect as a positional argument and the border radius as named would look cleaner, the same as you did with the square method.
Keep up the great work!

Thanks for watching.
No particular reason. I tend to either use all positional arguments or all named arguments. It's just a habit and a preference.
For questions like this, the YouTube comments are probably a more appropriate place to ask. I try to respond to all specific technical questions that people ask in the video comments. I think the repo issues should be reserved for bugs and feature requests.


possible issue: webapp bombarding fcd.

probably you have already seen this.
I wanted to swap mir for luna, was slow, checked console, it sends 120 query_msg to fcd. Thought maybe something is wrong? not sure.

Yes by checking the number of all cases for routing. We are refactoring a way to reduce this.


pablo tfg branch: methods

Allow expressions like f.b("a") = 2

The trivial example is working. Is this an issue to close?
More tests are needed


[STORM-1038] Upgraded netty to 4.x

Upgraded the netty transportation layer to 4.x to take advantage of its memory management efficiency.

@hsun-cnnxty
Great work. Since it can affect performance I recommend you to include benchmark test result.
You can refer #521 (comment) to how to do it.

@hsun-cnnxty
Btw, Netty 4.0.31 was released 8 days ago, so we may also want to check this out to test it works.
And we'd like to see memory usages with Netty 3.x / 4.x to confirm 4.x is superior to 3.x.

Good suggestion. I will get to work on them as soon as I get some time.  I am also curious to verify the memory efficiency claimed by 4.x

Upgraded to latest 4.0.31.Final and changed the buffer allocation to lett netty choose the best default based on the platform.

@hsun-cnnxty, The changes look good to me.  Please upmerge to the latest code.  Then I would like to run some performance tests on it to see how it compares to the current code.  Please also look at shading.  In storm-core we are shading netty now, and I would like to be sure that it is still shaded correctly.
If you have any questions on how to do this please let me know and I will be happy to help out.

@revans2, just merged with the latest master.  I don't have a decent storm cluster for performance test.  With a small local cluster on single machine.   I had tried https://github.com/yahoo/storm-perf-test and did not see any difference in memory consumption after the upgrade (It was configured in a way to make sure there is inter-worker communication using Netty).  Hope your test can reveal more information.
-thanks

Everything looks really good now.  just a few minor nits.  I still have not found time to run some performance tests, but I will try to do that today.

I just ran some performance tests using https://github.com/apache/storm/blob/master/examples/storm-starter/src/jvm/storm/starter/ThroughputVsLatency.java
I ran with 4 workers on a MacBookPro and the numbers don't look good for netty4.
With the older code I was able to do 20,000 sentences/second at
99%-ile:      43 ms
99.9%-ile:      99 ms
min:       8.8 ms
max:     177 ms
mean:   16 ms
CPU Utilization over 30 second interval:
user:    159,718 ms
sys:     49,670 ms
But with the netty4 patch it could only handle 17,000/sec and the latency was much worse
99%-lie:     148 ms
99.9%-lie:     230 ms
min:       9.2 ms
max:     332 ms
mean:   32 ms
CPU:
user:    162,984 ms
sys:     55,867 ms
To have the netty4 patch have similar latency we needed to only run at 14,000 sentences per second.
99%-lie:      38 ms
99.9%-lie:      55 ms
min:       8.8 ms
max:      76 ms
mean:   16 ms
CPU:
user:    152,865 ms
sys:     52,535 ms
Unless we can get the numbers to be close to or better than the netty3 implementation I cannot let this in.

Cool, at least we get some numbers to compare. I will see if there is default setting need to be changed for netty 4.

@hsun-cnnxty I hope it is something like that.  You should be able to run the tests yourself too.  They are not that complex.  I build
mvn clean install -DskipTests
cd storm-dist/binary
mvn clean package
tar -xzvf ./target/apache-storm-0.11.0-SNAPSHOT.tar.gz
cd apache-storm-0.11.0-SNAPSHOT

I then run a small single node cluster
./bin/storm dev-zookeeper &
./bin/storm nimbus &
./bin/storm supervisor &
./bin/storm ui &
./bin/storm logviewer &

Once it is all up and ready you can run the test.
./bin/storm jar ./examples/storm-starter/storm-starter-topologies-0.11.0-SNAPSHOT.jar storm.starter.ThroughputVsLatency $THROUGHPUT 4 5 wc-test | tee results.txt

It will output metrics about the running test every 30 seconds for 5 mins.  Some of the numbers are in nanoseconds and others are in milliseconds so pay attention to them.  I like to vary the throughput and look to see when it cannot keep up any more to get an idea of the maximum throughput the setup can handle, and what the latency is for a given throughput so we can see how they compare to each other.

mark

With some refactoring, now it can sustain throughput of 20,000 /sec  which it was not able to before.  But latency at 20,000 /sec is still much higher than 3.x (5+ times).  I will continue to investigate.

@revans2
Just merged code from master and seems there is performance degradation with recent changes.  I noticed that it not only affects this branch, but also the master branch.  Here are the comparison on my laptop for running the perf test with only 5,000/sec throughput with code from master.
Before (git hash: 3db968092077363bd766db516b9e1135273672bf)
netty3-r5000.txt
Now (git hash: bd396b3a4ec0c242f18725ddf43e35f26da51269)
netty3-new-r5000.txt
Note: when running the latest code, my CPU is almost 100% busy which may explain why it was so much worse.  When running the "old" code, my CPU still had 10% idle time.
-thanks

Yes I am aware of it.  We are in the process of merging with the JStorm project, and part of this merger involves moving most of the clojure code to java.  In all likelihood the degradation is due to reflection happening on the critical path because many new places in the code are calling into java that were not doing so before.  I plan on doing some profiling soon and submit some fixes, but it is very much a moving target so I have not been very motivated to do so.  The code for the netty messaging layer should stay mostly the same between 1.0 and 2.0 for this, so if you want to do your work based off of the 1.0 branch and show performance comparisons there being the same I would totally accept that as proof that the code is good.
 - Bobby
On Thursday, February 25, 2016 12:53 AM, Sun<EMAIL_ADDRESS>wrote:

@revans2 Just merged code from master and seems there is performance degradation with recent changes. I noticed that it not only affects this branch, but also the master branch. Here are the comparison on my laptop for running the perf test with only 5,000/sec throughput with code from master.Before (git hash: 3db9680)
netty3-r5000.txtNow (git hash: bd396b3)
netty3-new-r5000.txtNote: when running the latest code, my CPU is almost 100% busy which may explain why it was so much worse. When running the "old" code, my CPU still had 10% idle time.-thanks—
Reply to this email directly or view it on GitHub.

@hsun-cnnxty we would like to get this into 1.x-branch as well as master. Did you get a chance to look at @revans2 comment above . It will be great if you can address the comment and up merge your patch.

I am currently on vacation and will be back in two weeks.  Will work on it as soon as I am back home.
-thanks

After rebasing, could you do the performance test against 1.x branch? The status of master branch is a  WIP so we would be more convenient with 1.x branch.

Sure.

As this PR is for master,  new PR #1591 is created for 1.x-branch.  Performance tests to be done soon.

@HeartSaVioR @harshach
I posted performance test results on  #1591.

@hsun-cnnxty, I think this is great change to have. Any way we can implement this as a plugin for us to switch between current implementation? It took substantial amount to get the current version stabilized. So making it plug and play would help us switch between implementations in case of issues.

@kishorvpatil that's an interesting idea. You mean a feature flag to toggle between 3.x and 4.x?  I will investigate the possibility.
Btw, I have moved the work to #1591.
-thanks


WIP: Port bde_verify to llvm11

This series of commits moves bde_verify from llvm9 to llvm11.
This is important as most linux distros are not shipping llvm9 anymore.

Thanks @tcanabrava - we already have an internal effort underway to do this port, but the developer working on that will take a look at your PR.  It's quite possible you've saved them a lot of work.

@RMGiroux I like to help out, and I'm using this to review my code, anything that I can upstream is a good effort.


fix: in cases where both _ids and _id are used, there might be confusion

it now throws if both are used
additionaly it makes sure to only include changed data before denormalizing, comparing and transforming the data

:tada: This PR is included in version @ra-data-prisma/dataprovider-v7.0.0-beta.4 :tada:
The release is available on:

npm package (@beta dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Housekeeping web directory

Removed from .../blog since that is a generated directory. Updated minor typos.

ACK


[regression](partial update) Fix unstable p0 case test_primary_key_partial_update_parallel due to conflicting table name

Proposed changes
Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall


Fix form refresh behaviour when data-turbo=false.

Ported from https://github.com/turbolinks/turbolinks/pull/495
Turbo's initialisation currently breaks the default refresh behaviour when it's run after a POST submission and data-turbo=false.  confirm dialog, whereas with Turbo installed, it just reloads the existing location with a GET.
When starting up, Turbo stores the initial location and restoration identifier in the session history by calling replaceState. This standardises the way to retrieve a restoration identifier on any popstate event. However, according the to the spec:
    [If the state push flag is not set], update the current entry in browsingContext's session history so that … it represents a GET request, if it currently represents a non-GET request (e.g. it was the result of a POST submission).
    https://html.spec.whatwg.org/multipage/history.html#history-1

So when a page loads after a POST, Turbo replaces the current entry with a GET to the same location, and therefore will not re-POST or display a confirm dialog upon refresh*.
This pull request tweaks initialisation to store the initial restoration identifier and location as properties on the History instance, avoiding the need to use replaceState. When the history is popped to the initial entry, event.state will be null, and by asserting that the existing location matches the stored initial location, the restoration identifier is retrieved accordingly. Pops to non-initial entries will be handled as before.
A note on testing this programmatically: in Chrome, a POST, followed by window.location.reload() does not trigger an "Are you sure…?" confirm dialog, which makes this rather hard/impossible to test :/

* This is observed in Chrome and Firefox, which comply with the spec. Safari behaves as we want, but does not comply with the spec.

Dom, should we try to sneak this into 7.0 final?

@dhh I've fixed the conflicts, but not retested yet

Yeah, seems like there are some failing tests on this one.

We really have to do something about these unreliable tests!

There were some big changes to how locations were wrapped after this PR was created, so I'm wondering if I'm missing something here.
The premise is reasonably simple:

Don't replace the history on start, instead store the initial restoration token as a property on the History object
Detect when a user has navigated Back to the initial location and use that restoration token
🤔

I haven't looked enough into this. I only remember having a conversation with Sam at some point where he didn't think this was fixable. But maybe we just didn't consider it from the right angle.

This should be working now. The failing test is in Chrome which demonstrates:

A note on testing this programmatically: in Chrome, a POST, followed by window.location.reload() does not trigger an "Are you sure…?" confirm dialog, which makes this rather hard/impossible to test :/

I can revert the test commit if preferred.

This is great. I'm thinking we just add a skip to that test when the driver is chrome?

Seems to be  an issue still 🤔  Can reproduce it as follows:

Comment out importing turbo
Go to a form and submit it with empty fields (422 response)
Paste this into the JS console: history.replaceState({ foo: 123 }, '', location.href)
Then cmd+r will do a GET instead of a POST /  form resubmission.

When Turbo is loaded, the same happens since it calls replaceState as well: https://github.com/hotwired/turbo/blob/v8.0.10/src/core/drive/history.js#L45. Setting Turbo.session.drive = false doesn't affect this since the replaceState call happens immediately when importing Turbo.


stop using the UID from the card.json response

We already have the UID when we run this engine. Also, users who haven't
set any profile fields will have a null profile in the response, and
this was triggering a warning when we tried to parse out the UID.

@patrickxb

LGTM

Seems like API server could return a UID considering it's getting a UID parameter...

I think it's a bug it's included there at all.

It would have to be specifically deleted from the BASICS fields, if we don't want it, right? Should I go ahead and do that?


The <> button should be disabled when the raw HTML written by the user is not supported by Lexical

Describe the Bug with repro steps

Add an action that uses HTML editor (e.g., send an email)
Open the HTML editor
Click the <> to switch to raw HTML view
Clear the field
Add to the field:

This is not supported by Lexical and so the <> button should be disabled, but it is not. If you switch to Lexical and back,
 is replaced by .
Leftover from PR: #3849
What type of Logic App Is this happening in?
Consumption (Portal)
Are you using new designer or old designer
New Designer
Did you refer to the TSG before filing this issue? https://aka.ms/lauxtsg
Yes
Workflow JSON
No response
Screenshots or Videos
No response
Browser
Chrome 120.X, Windows 11.
Additional context
The disabled={} on the "Raw code toggle" button in libs/designer-ui/src/lib/html/plugins/toolbar/Toolbar.tsx needs to be dependent on the return value of isHtmlStringValueSafeForLexical based on the current HTML code.

If needed, I can take this one once I am back from my holiday break.

Fixed in #3982.


Create an in-depth DPS tutorial/demo

https://docs.google.com/document/d/1jULblYS8CS3bdiyKIV6t_--urd8yDHQM8XJC9riHAeU/edit?pli=1#heading=h.ntvk7f43cq5y

Maap-docs branch for this: https://github.com/MAAP-Project/maap-documentation/tree/dps-tutorial-v1

Overhauled some ordering and re-did screenshots based on initial testing on Feb 28
See “updates based on testing” checklist at the bottom of https://docs.google.com/document/d/1jULblYS8CS3bdiyKIV6t_--urd8yDHQM8XJC9riHAeU/edit

closing this with "v1" stuff done.
will open a "v2" for updates


Reimplement BMP

Just note that this image format requirement should be let this package require php-7.2 version at least.
You can refer the imagebmp function reference.

I want to know why the imagebmp function should require php-7.2 version.
And I saw that it should require php-7.1 version.
I just have the test inside a new Docker container and it looks fine when I call imagebmp function from php-7.1 version.
Instruction
Here is the Dockerfile I create to build the php-7.1 container.
# Install required packages

FROM ubuntu:16.04
RUN apt-get update
RUN apt-get install -y software-properties-common
RUN apt-get install -y python-software-properties
RUN LC_ALL=C.UTF-8 add-apt-repository -y ppa:ondrej/php
RUN apt-get update
RUN apt-get install -y apt-transport-https apt-utils curl php7.1-cli php7.1-mysql php7.1-curl php7.1-gd
RUN apt-get install -y libcurl3-openssl-dev

ENTRYPOINT [ "bash" ]

After building this container successfully, try entering to this container via interactive shell.
And the final result is as follows:

When I use the php-7.2 version, it looks fine finally.
Here is the Dockerfile for building php-7.2.
Here is the `Dockerfile` I create to build the `php-7.1` container.

```bash
# Install required packages

FROM ubuntu:16.04
RUN apt-get update
RUN apt-get install -y software-properties-common
RUN apt-get install -y python-software-properties
RUN LC_ALL=C.UTF-8 add-apt-repository -y ppa:ondrej/php
RUN apt-get update
RUN apt-get install -y apt-transport-https apt-utils curl php7.2-cli php7.2-mysql php7.2-curl php7.2-gd
RUN apt-get install -y libcurl3-openssl-dev

ENTRYPOINT [ "bash" ]

Nice research!
Version 7.2.0 was released 30 Nov 2017. I don't have a problem with having 7.2 as requirement, not personally anyway.
I've not tested it, but if the rest of the formats still work without crashing the whole thing below 7.2 we could have a mixed requirement, something like below?
Requirements

PHP 7.0 - gif, jpg and png supported
PHP 7.1 - webp supported
PHP 7.2 - bmp supported

...or add exceptions to throw errors on old versions with unsupported formats.

@jenstornell, actually, the imagewebp will be supported on php-7.0 version :).


Changes to Rust implementation

Use position() on iter() instead of loop in code_value
Use arithmetic operator in normalize_longitude
Use powi for integer power (-3) in compute_latitude_precision
Use arithmetic operators in encode
Reserve String space (/cpp/openlocationcode.cc) in encode

Thanks @tcyrus ! Nice edits!


Cupertino CupertinoDatePicker  setting a maxDate

I hope CupertinoDatePickerMode.date mode can‘ Set the maximum date, today

looks like a dup of #24820?


Remove deprecated action

Remove deprecated action (components-nightly)
Also, fix fmt and some doc to make CI more green

@JohnTitor Tell me when you want me to merge 😃

I think we can go now :)


Add David Goodwin as approver

What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:

/assign @animeshsingh @ellistarn @cliveseldon

/lgtm

/approve


fix fix some some cases in cloud mode and unify waiting for

schema change done
Proposed changes
Issue Number: close #xxx

run buildall

run buildall

run buildall