Can't generate tube or line

Hello 👋🏻
I am trying to build a sort of circle arc, or torus section, using the provided line and tube methods. Here is my sample code:
func points(of radius: Float, from start: Angle2D, to end: Angle2D) -> [SIMD3<Float>] {
    let degrees = Int(abs(start.degrees - end.degrees))

    var points = [SIMD3<Float>]()

    for i in 0...degrees {
        let angle = Angle2D(degrees: Double(i)).radians

        let x = Float(radius * cos(angle))
        let y = Float(radius * sin(angle))

        points.append([x, 0, y])
    }

    return points
 }

let points = points(of: radius, from: .zero, to: .radians(.pi / 2))

guard let mesh = try? RealityGeometry.line(points: points, radius: 1).0 else { return nil }

let entity = ModelEntity(mesh: mesh, materials: [PhysicallyBasedMaterial.glassMaterial])

The code runs with no errors and manages to go over the guard line. However, using line or generateTube does not produce any visible entity. Interesting fact: using generatePath with the same points does produce the correct mesh, but path is flat and I need a proper 3D tube-like object.
BTW thank you for this package, it's helping me a lot with my non-existent 3D development skills.

I have the same use case and I am experiencing the same issue of my created entities being invisible.
extension RealityGeometry {
    /// Create a new torus arc MeshResource 🍩
    /// - Parameters:
    ///   - sides: Number of segments in the toroidal direction (outer edge of the torus).
    ///   - csSides: Number of segments in the poloidal direction (segments in the tube)
    ///   - radius: Distance from the centre of the torus to the centre of the tube.
    ///   - csRadius: Radius of the tube.
    ///   - startDegrees: The starting angle of the arc
    ///   - endDegrees: The ending angle of the arc
    /// - Returns: A new torus `MeshResource`
    public static func generateTorusArc(
        sides: Int, csSides: Int, radius: Float, csRadius: Float, startDegrees: Float, endDegrees: Float
    ) throws -> MeshResource {

        // Build a series of points that will serve to build a tube around
        let angleIncs = 360.0 / Float(sides)
        let dToR: Float = .pi / 180
        let radIncs = angleIncs * dToR
        let startRads: Float = startDegrees * dToR
        let endRads: Float = endDegrees * dToR
        let ptRadius = (csRadius + radius)

        var i = startRads
        let z: Float = 0.0
        var x: Float
        var y: Float
        var points: [SIMD3<Float>] = []

        while i < endRads {
            var point = SIMD3(x: cosf(i) * ptRadius, y: cosf(i) * ptRadius, z: z)
            points.append(point)
            i += radIncs
        }

        var results = try generateTube(points: points, radius: csRadius, edges: csSides)

        return results
    }

}


Reverse Mob Display Order?

Maybe this is already supported, but what I want is where the Driver becomes the Navigator, which is what the Mob Order of "Navigator,Driver" does, but I want the Driver displayed at the top. In our remote mob, the new Driver is the one who has to take over the screen sharing, and we've been struggling with seeing who the new Driver is since they're not displayed at the top.

Some people use Navigator,Driver,Next. Does that work for your team or is there a further issue that I'm not aware of?

You already can change the order in the timer settings tab

I'm going to close this, but @tedyoung if I missed something, please let me know, and I'll re-open this. Thanks!


sf apex run test --wait allows value -1 but does not respect it

Summary
The command sf apex run test allows specifying a --wait flag value as -1, however, this value seems to be ignored and the command exits and returns after the default 1 minute wait time instead.
Previously, with sfdx force:apex:test:run the value -1 was allowed and was treated as wait indefinitely.
Steps To Reproduce:

 sf apex run test -l RunLocalTest --wait -1

Expected result
Command should wait until all tests have finished execution and display test results.
Alternatively, if -1 is no longer a supported value for the --wait flag the command should return an error for that flag detailing the allowed range of values, in similar fashion to sf project deploy start --wait
Actual result
Run "sf apex get test -i 7078F00000oJGyP -o<EMAIL_ADDRESS>to retrieve test results

System Information
CLI Version:
@salesforce/cli/1.75.6
Architecture:
linux-x64
Node Version:
node-v18.16.0
Plugin Version:
@oclif/plugin-autocomplete 2.1.9 (core)
@oclif/plugin-commands 2.2.14 (core)
@oclif/plugin-help 5.2.9 (core)
@oclif/plugin-not-found 2.3.23 (core)
@oclif/plugin-plugins 2.4.6 (core)
@oclif/plugin-search 0.0.16 (core)
@oclif/plugin-update 3.1.12 (core)
@oclif/plugin-version 1.3.3 (core)
@oclif/plugin-warn-if-update-available 2.0.35 (core)
@oclif/plugin-which 2.2.19 (core)
@salesforce/cli 1.75.6 (core)
apex 2.2.13 (core)
auth 2.7.12 (core)
data 2.3.10 (core)
deploy-retrieve 1.8.14 (core)
info 2.6.7 (core)
limits 2.3.13 (core)
login 1.2.5 (core)
org 2.7.0 (core)
schema 2.3.8 (core)
settings 1.4.4 (core)
sobject 0.1.17 (core)
source 2.10.2 (core)
telemetry 2.1.4 (core)
templates 55.4.9 (core)
trust 2.4.9 (core)
user 2.3.8 (core)
gr-sfdx-plugin 0.0.0 (link) /home/alan.morey/repos/salesforce/gr-sfdx-plugin
OS and Version:
Linux 5.19.0-40-generic
Shell:
zsh
Root Path:
/home/alan.morey/.npm-packages/lib/node_modules/@salesforce/cli

I didn't see any documentation about -1, so we'll put a better error on the flag to make it clearer.
You can use some very large number to mean "indefinitely" if you need that.


feat: add RBAC rules for user-facing ClusterRoles

Problem Statement
Having default user-facing ClusterRoles be able to CRUD group generators.external-secrets.io.
Related Issue
Fixes #2285
Proposed Changes
Adding the appropriate rules to the ClusterRoles.
Checklist

[X] I have read the contribution guidelines
[X] All commits are signed with git commit --signoff
[ ] My changes have reasonable test coverage
[X] All tests pass with make test
[ ] I ensured my PR is ready for review with make reviewable

I don't see any tests for RBAC.
make reviewable doesn't even work for me on main. I don't think my changes further break that.

/ok-to-test sha=58da7af


Add CODEOWNERS

I have removed myself as admin of this repo, so I'll leave up to you to enforce it is properly configured.


Add license file

Add https://www.apache.org/licenses/LICENSE-2.0.txt to this repository.

But please call it LICENSE, like everyone else


[v2] Safe area in landscape not working and missing status bar in portrait

This is a (multiple allowed):

[x] bug

[ ] enhancement

[ ] feature-discussion (RFC)

Framework7 Version: 2.0.2.

Platform and Target: Cordova, iOS 11.2

What you did
Rotate device in landscape and rotate device in portrait. For now, I'm using a simulator and I don't have the actual device to test. Also, safe area for landscape is not working as well.
Expected Behavior
Should have a padding or height for status bar in portrait and safe areas in landscape should be working.
Actual Behavior
Status bar padding or height is missing. Safe areas in landscape not working. It still extends up to the notch.

I think I've found the issue. The issue is upon rotation, it seems that the safe area inset values seems to be not working. Other people said that it is a bug in the UIWebView and it is resolved in later iOS versions but I don't think so since I'm on iOS 11.2. To workaround this, I just get the initial value after init() and check both orientationChange and resize events whether it is necessary to apply the insets.
`
// create a global variable to be accessed anywhere for convenience
var CONST_SAFE_INSET_TOP = 0;
// get the inset value from one of the elements and assign it in a variable
CONST_SAFE_INSET_TOP = $$('html.device-iphone-x .framework7-root').css('padding-top');
// apply this in orientationChange and resize events onDeviceReady
function fixStatusBar() {
var root = $$('html.device-iphone-x .framework7-root');
var statusbar = $$('html.device-ios.device-iphone-x .statusbar');
if (f7.device.needsStatusbarOverlay()) {
    if (statusbar.css('height') == '0px') {
        statusbar.css('height', CONST_SAFE_INSET_TOP);
    }

    if (root.css('padding-top') == '0px') {
        root.css('padding-top', CONST_SAFE_INSET_TOP);
    }
} else {
    statusbar.css('height', 0);
    root.css('padding-top', 0);
}

}`
Most likely this workaround only can be applied when the app starts on portrait. As for landscape > portrait, this might not work since the top inset value is not present during startup. All the selector values are taken from Framework7's css. So, if you need to apply this kind of fix on other inset values, just refer to the css file.

Just wanted to add that I'm getting this same issue on f7 v1.7.1 (update to v1 with iPhone X compatibility). I'm running iOS 11.2 in the iOS simulator.
Everything works beautifully in portrait, but in landscape there are no margins on the left and right, so content ends up under the notch.
Tested with the kitchen sink.

ver. 3.4.2 still got the problem
Safe area in landscape is ok when start app the device in landscape
but the wonderful page display will broken after once rotate
Does any method to re-render like app init when orientationChange?


SnapshotController

What's the correct way to delete snapshot ViewController I don't want translate effects

In my pod you can't remove snapshots - it basic for animating. All translation needs stop before present SPStorkController


Proposal: Make orNotFound return a Http

This will most likely be incompatible in a variety of ways, but maybe we can make this kind of change since 0.20 is breaking anyway.
This should be fine, unless we assume that there are users who call orNotFound on Kleislis that don't have Request[F] in the input.

Ugh.  I was not thinking clearly when I looked earlier.  I thought we were going the other direction, generalizing from Http to Kleisli, so it works with any input type.  I'm sorry about that.
Isn't this change going to make it not work with things like an authed service?

Oh. Well.
Yeah, it probably is. I didn't realise that.


Concrete5 Logo Click Behavior Missing on Site Page

I don't know if this is intentional or not, but the C5 logo does nothing when clicked if you're on a  page of the site (versus being on a dashboard page). I can't think of any reason it should behave any differently in that context. In fact, it's likely to cause confusion because it looks exactly the same in either context, so most users (myself included) would expect it to behave the same.
-Steve

I agree


Ignore unused argument in closure

I'm fairly new to Rust so perhaps I'm overlooking something. But I think this argument should be ignored, right?

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @therealprof (or someone else) soon.
If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.
Please see the contribution instructions for more information.


Add AspNetCore Preview9 Known issues

@vivmishra Looks like you're the one to contact for merging these PRs


Convert analysis endpoint too serverless function

The analysis endpoint can take a few seconds or more to process all the data -- mostly throttled by recursive network requests when iterating over playlists and tracks. It would be a lot more scalable to implement the analysis as a serverless function through GCP, AWS, or Azure.
I'm partial to GCP just because I like their UI and also I've used them before. I also like the idea of leveraging their NLP sentiment APIs for lyrical analysis too.

Google Cloud functions have been set up.


Hive Sink: java.lang.NoClassDefFoundError

What version of the Stream Reactor are you reporting this issue for?
1.2.2
Are you running the correct version of Kafka/Confluent for the Stream reactor release?
What is the expected behaviour?
Sink to work
What was observed?
Connect Task always returns this exception: Could not initialize class com.landoop.streamreactor.connect.hive.ConfigurationBuilder
What is your Connect cluster configuration (connect-avro-distributed.properties)?
key.converter.schema.registry.url=http://localhost:8081 value.converter.schema.registry.url=http://localhost:8081 config.storage.replication.factor=1 offset.storage.topic=connect-offsets offset.storage.replication.factor=1 key.converter=io.confluent.connect.avro.AvroConverter config.storage.topic=connect-configs group.id=connect-fast-data port=8083 value.converter=io.confluent.connect.avro.AvroConverter rest.port=8083 status.storage.replication.factor=1 status.storage.topic=connect-statuses access.control.allow.origin=* access.control.allow.methods=GET,POST,PUT,DELETE,OPTIONS jmx.port=9584 plugin.path=/var/run/connect/connectors/stream-reactor,/var/run/connect/connectors/third-party,/connectors bootstrap.servers=PLAINTEXT://localhost:9092
What is your connector properties configuration (my-connector.properties)?
connector.class=com.landoop.streamreactor.connect.hive.sink.HiveSinkConnector connect.hive.database.name=hive_connect connect.hive.hive.metastore.uris=thrift://hive-metastore:9083 value.converter.schema.registry.url=http://localhost:8081 topics=telecom_italia_data name=test-hive-sink-4 connect.hive.fs.defaultFS=hdfs://namenode:8020 connect.hive.kcql=INSERT INTO dev_test SELECT SquareId FROM telecom_italia_data AUTOCREATE WITH_FLUSH_INTERVAL = 1 value.converter=io.confluent.connect.avro.AvroConverter connect.hive.hive.metastore=thrift key.converter=io.confluent.connect.avro.AvroConverter key.converter.schema.registry.url=http://localhost:8081
Please provide full log files (redact and sensitive information)
 java.lang.NoClassDefFoundError: Could not initialize class com.landoop.streamreactor.connect.hive.ConfigurationBuilder$     at com.landoop.streamreactor.connect.hive.sink.HiveSinkTask.start(HiveSinkTask.scala:52)     at org.apache.kafka.connect.runtime.WorkerSinkTask.initializeAndStart(WorkerSinkTask.java:301)     at org.apache.kafka.connect.runtime.WorkerSinkTask.execute(WorkerSinkTask.java:190)     at org.apache.kafka.connect.runtime.WorkerTask.doRun(WorkerTask.java:175)     at org.apache.kafka.connect.runtime.WorkerTask.run(WorkerTask.java:219)     at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)     at java.util.concurrent.FutureTask.run(FutureTask.java:266)     at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)     at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)     at java.lang.Thread.run(Thread.java:748)

This is fixed. The connector is working if you build new jar from master or 1.2.2


The file order in compare selected is reversed

Does this issue occur when all extensions are disabled?: Yes

Version: 1.92.2 (system setup)
Commit: fee1edb8d6d72a0ddff41e5f71a671c23ed924b9
Date: 2024-08-14T17:29:30.058Z
Electron: 30.1.2
ElectronBuildId: 9870757
Chromium: 124.0.6367.243
Node.js: 20.14.0
V8: <IP_ADDRESS>-electron.0
OS: Windows_NT x64 10.0.19045

Steps to Reproduce:

Select File A
Select File B
Click  compare selected
Then you will see a New Tab, named B ↔ A, but former is  A ↔ B

Download
https://www.dropbox.com/scl/fi/ku9a1wblqyb84rb8ekase/fix.zip?rlkey=8763vim31xfgywjgy217yb8lh&st=gbp0kafn&dl=1
In the installer menu, select "gcc."

Looks like a duplicate of #225441, according to which has been fixed in upcoming 1.93

Thank @gjsjohnmurray for the reply. I am closing this issue because it is a duplicate.


cmd: templ --watch does not close port on SIGINT

Hi, I love the effort in bringing a watcher to templ! Unfortunately, the port of my server is never closed.
I'm running a practically barebones chi server, nothing special going on there.

macOS Sonoma 14.2.1
go version go1.21.5 darwin/arm64
templ v0.2.543

λ templ generate --watch --proxy="http://localhost:3000" --cmd="go run ."

Processing path: /Users/merlijnvos/code/the-boring-stack
Generating dev code: /Users/merlijnvos/code/the-boring-stack
(✓) Generated code for "/Users/merlijnvos/code/the-boring-stack/views/layout.templ" in 1.523417ms
(✓) Generated code for "/Users/merlijnvos/code/the-boring-stack/views/index.templ" in 1.572042ms
(✓) Generated code for 2 templates with 0 errors in 2.030583ms
Executing command: go run .
Proxying from http://<IP_ADDRESS>:7331 to target: http://localhost:3000
Opening URL: http://localhost:3000
2024-02-02 15:04:06 INF starting server port=:3000
^CStopping...
Generating production code: /Users/merlijnvos/code/the-boring-stack
(!) Deleted file "/Users/merlijnvos/code/the-boring-stack/views/index_templ.txt"
(!) Deleted file "/Users/merlijnvos/code/the-boring-stack/views/layout_templ.txt"
(✓) Generated code for "/Users/merlijnvos/code/the-boring-stack/views/index.templ" in 2.432458ms
(✓) Generated code for "/Users/merlijnvos/code/the-boring-stack/views/layout.templ" in 2.350875ms
(✓) Generated code for 2 templates with 0 errors in 4.017542ms
Executing command: go run .

λ 2024-02-02 15:04:17 INF starting server port=:3000

☝ notice that the program stopped but it logged a line where my cursor is
Running it again:
λ templ generate --watch --proxy="http://localhost:3000" --cmd="go run ."

Processing path: /Users/merlijnvos/code/the-boring-stack
Generating dev code: /Users/merlijnvos/code/the-boring-stack
(✓) Generated code for "/Users/merlijnvos/code/the-boring-stack/views/layout.templ" in 1.751917ms
(✓) Generated code for "/Users/merlijnvos/code/the-boring-stack/views/index.templ" in 1.754292ms
(✓) Generated code for 2 templates with 0 errors in 2.152833ms
Executing command: go run .
Proxying from http://<IP_ADDRESS>:7331 to target: http://localhost:3000
Opening URL: http://localhost:3000
2024-02-02 15:05:25 INF starting server port=:3000
listen tcp :3000: bind: address already in use
exit status 1

Would you mind giving the main branch a try please? I completely rewrote the whole of the generate --watch command in https://github.com/a-h/templ/pull/470

Coming from #493
I tested on wsl on windows
using go: upgraded github.com/a-h/templ v0.2.543 => v0.2.544-0.20240205222607-1e6a80f83c3a
with command: /home/huz/go/bin/templ generate --watch --proxy=http://<IP_ADDRESS>:8080 --proxyport=8081 --cmd="go run ."
TLDR: Does not work. Spawns a new cmd after closing templ. claimed evidence is changed id of go process after ctrl+z
It seems that the templ process on ctrl+c is closing itself and the go process it started however after that it create a new go process? I say this based on the fact a the pgid and id of the go process has changed after I pressed ctrl+c to terminate.

I was trying to run templ using custom hotreload go file and ran into this issue on linux. for some reason I can easily kill the command in windows using my custom hotreload

Hi @Huzaifa-MS, from the logs you posted, it looks like you're not using the latest version of the CLI on the main branch.
Would you be able to test it with the main branch instead please? I've rewritten the whole of the --watch mode code from scratch since the version you're using.

I will try. Sorry I thought doing a go get to main would get the latest

It is working correctly now. Great work! :)
Steps:
*New Templ Repo needs slog to compile meaning it needs a Go version which has this. My previous version 1.20 did not have it.

git clone https://github.com/a-h/templ.git
cd templ/cmd/templ
go build
go install.
templ version #should be 2.560 or greater
*go get -u no longer works as in installing package from what I understand in newer go versions

Here is the screenshot:

Also how would I fix the generator warning? or will updating to next release fix itself

Sorry This is unrelated but is there any way to get output to show after using proxy flag?

It's blocking any logs from the changes I make in .templ files from showing up. I believe this is due to XDISPLAY in WSL

It should fix itself in the next release.
With Go, when you do go get -u github.com/a-h/templ it installs the latest tag, based on a semantic version, e.g. v0.0.450.
If you run go get -u github.com/a-h/templ@<commithash> it installs that specific version.
You don't need Go 1.21 installed to run the CLI, if you use a binary that we release, but obviously, if you build from source, you'll need the later Go version.
The strategy we have is to use the latest Go version to build the CLI and produce binaries, but the runtime supports the current Go version - 2 releases. Go 1.22 was released today, so we're now free to start using Go 1.20 features in the runtime.

Thank you for helping me understand this better : )

@Murderlon - the latest release of templ should have fixed this issue. If not, please feel free to reopen, and I'll start investigation again, but here's a demo of it working fine, with the example chi project in the templ repo.
https://github.com/a-h/templ/assets/1029947/7888fb2f-232d-420d-9b75-ceaba996b4c0

Sorry I didn't get around to testing this earlier myself. Thanks for the fix!


Demand letter generation

Description

As a user, I would like the system to generate a demand letter for my claim

Scope of Work

[ ] Obtain a sample demand letter
[ ] Create template filling logic within the back-end
[ ] Create a high-fidelity mock-up for the UI design
[ ] Verify data required to generate the demand letter

Acceptance Criteria

When the user completes their interaction with the system, if the proposed resolution is to submit a demand letter, the option to generate a demand letter is shown to the user.
When the user opts to generate the letter, a form dialog is opened so that the user may fill in required details
Upon submission of the document, a demand letter PDF file is downloaded to the user's system

Story Points

13

Priority

Medium

Risk

High

What kind of demand letters would this generate? Are there any examples that we can be given?

https://www.justice.gouv.qc.ca/vos-differends/avant-le-depot-de-la-demande-la-mise-en-demeure/redaction-et-envoi-de-la-mise-en-demeure/
https://www.educaloi.qc.ca/en/capsules/writing-demand-letter
These would be either demand letters before pursuing legal action, or even simple notices to landlords / tenants. We can come up with an adequate template and might be able to get lawyers to contribute to refining them.

updated story

Verified, medium priority.

Is it possible to generate a word document? PDF might lock them into some undesirable content. If we do perfect the automated document assembly, then PDF would be fine.

updated


Update JIRA GitHub activity field names

To be in alignment with the final implementation in production JIRA.
/cc @edx/ospr

Current coverage is 52.50% (diff: 100%)

Merging #90 into master will increase coverage by 0.08%

@@             master        #90   diff @@
==========================================
  Files            51         51
  Lines          1755       1758     +3
  Methods           0          0
  Messages          0          0
  Branches        205        205
==========================================
+ Hits            920        923     +3
  Misses          823        823
  Partials         12         12

Powered by Codecov. Last update efa3544...81140e3

:+1:


Is it possible to have separate collections for each extended schema ?

Basically I want the base schema to be a skeleton for inheriting schemas. For example, if we suppose Base schema to be PersonSchema, which would contain information like, name, age, address and sex.
Inheriting schema would be Teacher, Student, etc. In this case I would want separate collection for teachers and students. However they all should have information regarding name, age, etc.

It sounds like you're attempting to apply relational concepts where they don't really fit. I suggest either denormalizing the data or moving on to a relational database.

I agree with @chanced, however, you can do it with simple object extension:
var content = {
  URI: {type: String, trim: true, unique: true, required: true },
  auth: {type: [Schema.Types.ObjectId], ref: 'Role'},
  timestamps: {
    creation: {type: Date, default: Date.now},
    lastModified: {type: Date, default: Date.now}
  };

var page = content;
page.title = { type: String, trim: true },
page.format = { type: String, trim: true, required: true, validate: /^(md|html)$/, default: 'html' },
page.body = { type: String, trim: true, required: true }

var ContentSchema = new Schema(content);
var PageSchema = new Schema(page);

And thus, I think this falls out of the scope of mongoose-schema-extend


Add 1000 genomes subpopulation distribution analysis

Purpose/implementation Section
What scientific question is your analysis addressing?
This PR assesses 1000 Genomes project-derived subpopulation probabilities among patients in the PBTA ancestry cohort assigned to each of the five genetic ancestry superpopulations (AFR, AMR, EAS, EUR, SAS).
What was your approach?

Extracted subpopulation probabilities from input file DEI_CBTN-PNOC_rerun_subpopulation.somalier-ancestry.tsv
generated superpopulation-specific barplots showing subpopulation composition by patient; all subpopulations not associated with given superpopulation were assigned to "other" for plotting.

What GitHub issue does your pull request address?
Directions for reviewers. Tell potential reviewers what kind of feedback you are
soliciting.
Which areas should receive a particularly close look?
Please review code and ensure script runs successfully are results are produced as expected:
bash run_module.sh
Is there anything that you want to discuss further?
Is the analysis in a mature enough form that the resulting figure(s) and/or table(s) are
ready for review?
Results
What types of results are included (e.g., table, figure)?
What is your summary of the results?
Reproducibility Checklist

[ ] The dependencies required to run the code in this pull request have been added to the
project Dockerfile.
[ ] This analysis has been added to continuous integration.

Documentation Checklist

[ ] This analysis module has a README and it is up to date.
[ ] This analysis is recorded in the table in analyses/README.md and the entry is up to
date.
[ ] The analytical code is documented and contains comments.

note, we will update the grey bars with super pops


Transactional storage api: limit 128 not enforced in miniflare

When using a durable object and doing something like
await this.state.storage.list({ limit: 1000 });

this works in miniflare but yields an exception in Cloudflare Workers
RangeError: Maximum number of keys is 128.
Ideally both environments should behave the same.

@mrbbot I think the error came from delete not list – looks like Miniflare has this check (https://github.com/cloudflare/miniflare/blob/6075e19b07538128d2de7c7a31f6fb2213b24044/packages/durable-objects/src/storage.ts#L252), we just didn't hit it in tests 👍

I think so, yeah – thank you! 🙏


[UI] Registrant: "Artifact Hub" is inappropriately hardcoded

Current Behavior
See http://localhost:9081/settings?settingsCategory=Registry&tab=Registrants
Screenshots/Logs

Environment

Browser: Safari
Host OS: Mac
Meshery Server Version: stable-v0.7.24

Contributor Guides and Handbook

🎨 Wireframes and designs for Meshery UI in Figma (open invite)
🖥 Contributing to Meshery UI
🙋🏾🙋🏼 Questions: Discussion Forum and Community Slack

@MUzairS15 @Yashsharma1911

can you assign me this task? @leecalcote


add speaker notes, deck link and overview mode to the menu

@kadevgraaf could you instruct me on how to incorporate the new submodule into slidewiki-platform? I followed the steps on JIRA regarding submodules but I'm not convinced to have done it right

I am looking at how and whether we want to make it a submodule


fixes #1542

Pull Request Type
What kind of change does this PR introduce?
[x] Solved an issue/task
Issue Number: #1542

Merged

This is an automated message from Fork, Commit, Merge [BOT].

Thank you for your contribution! Your pull request has been merged. The files have been reset for the next contributor.
What's next?
If you're looking for more ways to contribute, I invite you to check out my other projects. Just click here to find more. These projects contain real issues that you can help resolve. You can also check out the Influences section in the README to find more projects similar to this one.
Also please leave a star to this project if you feel it helped you, i would really appreciate it.
I look forward to seeing your contributions!


Cannot open file, path = '.tmp/ios/firebaseScript.sh'

Hello, thanks for this package, it saved me a lot of time.
I try to add firebase to an existing project and I get this error.
obs. GoogleService-Info.plist has been successfully copied to the iOS project.
Running FileProcessor: writing file ios/Runner/GoogleService-Info.plist with nested EmptyFileProcessor Running ShellProcessor: Running script 'ruby' with arguments .tmp/scripts/ios/add_file.rb, ios/Runner.xcodeproj, Runner/GoogleService-Info.plist Running FileProcessor: writing file .tmp/ios/firebaseScript.sh with nested IOSFirebaseScriptProcessor Unhandled exception: FileSystemException: Cannot open file, path = '.tmp/ios/firebaseScript.sh' (OS Error: No such file or directory, errno = 2) #0      _File.throwIfError (dart:io/file_impl.dart:635:7) #1      _File.openSync (dart:io/file_impl.dart:479:5) #2      _File.writeAsBytesSync (dart:io/file_impl.dart:604:31) #3      _File.writeAsStringSync (dart:io/file_impl.dart:628:5) #4      AbstractFileStringProcessor.execute (package:flutter_flavorizr/processors/commons/abstract_file_string_processor.dart:40:15) #5      QueueProcessor.execute (package:flutter_flavorizr/processors/commons/queue_processor.dart:39:17) #6      QueueProcessor.execute (package:flutter_flavorizr/processors/commons/queue_processor.dart:39:17) #7      Processor.execute (package:flutter_flavorizr/processors/processor.dart:106:24) #8      execute (package:flutter_flavorizr/flutter_flavorizr.dart:54:13) #9      main (file:///Users/rodrigo/Documents/development/flutter/.pub-cache/hosted/pub.dartlang.org/flutter_flavorizr-2.0.0/bin/flutter_flavorizr.dart:4:3) #10     _delayEntrypointInvocation.<anonymous closure> (dart:isolate-patch/isolate_patch.dart:281:32) #11     _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:184:12) pub finished with exit code 255

Hi @rodrigorafaeldamaceno , can you please past your pubspec.yaml content?

Hi @AngeloAvv, of course.
`flutter_flavorizr: ^2.0.0
flavorizr:
app:
android:
flavorDimensions: "flavor-type"
ios:
flavors:
sicredi:
app:
name: "Sicredi"
android:
applicationId: "com.neocred.sicredi"
firebase:
config: ".firebase/sicredi/google-services.json"
ios:
bundleId: "com.neocred.sicredi"
firebase:
config: ".firebase/sicredi/GoogleService-Info.plist"
cresol:
app:
name: "Cresol"
android:
applicationId: "com.neocred.cresol"
firebase:
config: ".firebase/cresol/google-services.json"
ios:
bundleId: "com.neocred.cresol"
firebase:
config: ".firebase/cresol/GoogleService-Info.plist"
neocred:
app:
name: "Neocred"
android:
applicationId: "com.swa.neocred"
firebase:
config: ".firebase/neocred/google-services.json"
ios:
bundleId: "com.swa.neocred"
firebase:
config: ".firebase/neocred/GoogleService-Info.plist"`

hello, @rodrigorafaeldamaceno did you solved it I'm facing the same issue help, please?

Hi @rodrigorafaeldamaceno , I've tested your pubspec configuration on my PCs twice and it went smoothly. Sounds like a problem with permissions or something that has to do with your ruby setup. It's not library-related.

I had to run mkdir .tmp/ios to get over that error. I didn't investigate further what is causing it.

I created the .tmp/ios folder manually and the script worked, thanks.


Use Configuration instead of CMAKE_BUILD_TYPE in MSVC

This uses the Configuration passed to MSBuild instead of CMAKE_BUILD_TYPE. You can actually omit CMAKE_BUILD_TYPE during configuration, and the Configuration selected during build is used.
Several of the CMake scripts used Configuration, several used CMAKE_BUILD_TYPE, so this is just making things consistent for MSVC.
One less parameter to worry about during configuration and makes it possible to build debug and release from a single configuration.

Nagging Assignee @protoget: It has been 21 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Bump. Should be a really quick update. makes cmake --build . --config [whatever] respect the [whatever].

Nagging Assignee @protoget: It has been 15 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @protoget: It has been 30 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @protoget: It has been 44 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @protoget: It has been 60 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @protoget: It has been 75 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @protoget: It has been 90 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @protoget: It has been 105 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @protoget: It has been 119 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @protoget: It has been 135 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @protoget: It has been 14 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @protoget: It has been 29 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

@bstriner gentle ping to rebase branch

Please send this PR to tensorflow/addons instead; contrib is deprecated and stated to be removed so we're not making new changes to it.


[Bug]: KnowledgeGraphIndex.as_retriever ignores 'retriever_mode' parameter

Bug Description
Prior to the v0.10.0 refactor, 'retriever_mode' parameter was being passed via kwargs to KGTableRetriever:
https://github.com/run-llama/llama_index/blob/3823389e3f91cab47b72e2cc2814826db9f98e32/llama-index-legacy/llama_index/legacy/indices/knowledge_graph/base.py#L105-L114
'retriever_mode' is now a non-kwargs param and is not subsequently being passed to KGTableRetriever:
https://github.com/run-llama/llama_index/blob/3823389e3f91cab47b72e2cc2814826db9f98e32/llama-index-core/llama_index/core/indices/knowledge_graph/base.py#L122-L142
The end result being retriever mode defaults to keyword and embeddings are ignored for any kg index queries.
Version
v0.10.4
Steps to Reproduce

Crete KnowledgeGraphIndex

query_engine = kg_index.as_query_engine(retriever_mode=KGRetrieverMode.EMBEDDING)
query_engine.query("Some query that really needs a good embedding")

Keyword query is performed, embeddings are ignored

Relevant Logs/Tracbacks
No response

Thanks for raising @lukeherron. I believe the fix should just be to add the missing retriever_mode param in the construction of the KGTableRetriever. Just submitted a PR for this.


KAFKA-8609: add rebalance-total-time

In addition to the existing metrics added in KAFKA-8609, add the total (cumulative) time spent during rebalances.
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

Hey @guozhangwang , I was trying to use the rebalance metrics you added in KAFKA-8609, and I struggled a bit getting the information I needed. What I wanted to know is what the total amount of time spent in rebalances was. With the existing metrics, I had to multiply the (sampled) average rebalance time by the (cumulative) total number of rebalances. Unfortunately, the resulting number is not really sensible, since one component is subject to decay and the other is not.
I realized the easiest thing for me would just be to add a new cumulative rebalance time metric, and I think it actually makes sense as an addition to the metrics from KAFKA-8609. A lot of my metrics experience is with Datadog, and in that system, you could use this metric to graph both when rebalances happen and how long each instance spent during that rebalance. Also, we're currently providing a rebalances-per-hour metric, but given this proposed metric, you could easily graph the time spent in rebalance in the last second, hour, day, or whatever. There are probably other uses, but my pitch is essentially that I think this would be a useful addition to piggy-back into the release.

@vvcephei please also augment the existing unit test for the added metric as well :) since Jenkins is in a mood right now let's just verify unit tests locally.

Thanks for the review, @guozhangwang . I agree, rebalance-latency-total is a better name. I also updated the test.

LGTM. Will update KIP-429 accordingly after merging.


MobFox sdk without mopub integration

In my project i have already integrated the Mopub SDK to manage my direct adv offers, when i import mob fox sdks i receive a duplicate symbols error, there is a way to get a mob fox sdks version without mop integration?

Hi,
MobFox SDK relies on MoPub for MRAID ads. If you don't want to display MRAID ads I should be able to prepare a version without MoPub for you, but please keep in mind it would be rather experimental builds.

No thanks, is not a problem, maybe i integrate MobFox in future. Thank for help.


Incorrect result was returned when we use the indexed property to query

Bug Type (问题类型)
gremlin (结果不合预期)
Before submit

[X] 我已经确认现有的 Issues 与 FAQ 中没有相同 / 重复问题

Environment (环境信息)

Server Version: v0.11.2
Backend: inmemory
OS: xx CPUs, xx G RAM, Centos 7.x
Data Size:  100 vertices, 200 edges

Expected & Actual behavior (期望与实际表现)
Expected behavior
We indexed properties for a vertex label, and wanted to query the results according to the property value. For example, we expected the result of query 1 g.V().has('person', 'age', lt(30)).has('name', neq('person1')) to be the same as query 2 g.V().has('person', 'age', lt(30)).where(values('name').is(neq('person1'))).
Actual behavior
Actually, HugeGraph thrown a NoIndexException when we executed query 1.
com.baidu.hugegraph.exception.NoIndexException: Don't accept query based on properties [age, name] that are not indexed in label 'person', may not match secondary/range/not-equal condition

Steps to Reproduce
We can reproduce the problem using the following code.
hugegraph.schema().propertyKey("name").asText().ifNotExist().create();
hugegraph.schema().propertyKey("age").asInt().ifNotExist().create();

// vertex
hugegraph.schema().vertexLabel("person").properties("name","age").nullableKeys("name","age").create();
hugegraph.schema().indexLabel("personbyname").onV("person").by("name").shard().ifNotExist().create();
hugegraph.schema().indexLabel("personbyage").onV("person").by("age").shard().ifNotExist().create();

GraphManager graph = hugegraph.graph();

/** create graph data */
Vertex person1 = new Vertex("person").property("name", "person1").property("age", 16);
Vertex person2 = new Vertex("person").property("name", "person2").property("age", 15);
Vertex person3 = new Vertex("person").property("name", "person3").property("age", 23);
Vertex person4 = new Vertex("person").property("name", "person4").property("age", 46);

graph.addVertices(Arrays.asList(person1, person2, person3, person4));

GremlinManager gremlin = hugegraph.gremlin();

String query1 = "g.V().has('person', 'age', lt(30)).has('name', neq('person1'))";
System.out.println("query1 : " + query1);
try{
    ResultSet hugeResult = gremlin.gremlin(query1).execute();
    Iterator<Result> huresult = hugeResult.iterator();
    huresult.forEachRemaining(result -> {
        Object object = result.getObject();
        System.out.println(object);
    });
}catch(Exception e){
    e.printStackTrace();
}

String query2 = "g.V().has('person', 'age', lt(30)).where(values('name').is(neq('person1')))";
try{
    ResultSet hugeResult = gremlin.gremlin(query2).execute();
    Iterator<Result> huresult = hugeResult.iterator();
    huresult.forEachRemaining(result -> {
        Object object = result.getObject();
        System.out.println(object);
    });
}catch(Exception e){
    e.printStackTrace();
}

Vertex/Edge example (问题点 / 边数据举例)
No response
Schema [VertexLabel, EdgeLabel, IndexLabel] (元数据结构)
No response

maybe could refer #1481

@imbajin  Thanks for your reply. The questions are as follows.

The thrown exception is confusing because the properties [age, name] have been indexed in label 'person'. Therefore, we expected the query g.V().has('person', 'age', lt(30)).has('name', neq('person1')) could return results. This is different from #1481 . Why can't we filter data even when the property has been indexed?

According to #1526, we can use has('name', is(neq('person1'))) to query results even there is no index for property name. Since Gremlin supports has(key, Predicate) to search graph, why can't we use has('name', neq('person1'))? Are there any differences? What role does the index play in it？

Looking forward to your reply. THX

Two core reasons:

neq() is not relative with index (think if tom doesn't exist, how can we ensure it? Need scan all persons in table which is same as scanning table), so we ban the neq() in normal index search (support prefix & eq & range)
is() like filter() step, jump out our optimization before has() merge it, so it can search neq() by iterate each vertex with person and filter in memory now.

Some tips for dig gremlin step executor, u can use explain() step in the end:
like xx.has(x, neq()).explain() (or is(neq())), the previous step neq() is optimized into a has() step, and as the description before, has(x, is(xx)) will be treated as filter() step
Last, we'll consider to enhance the usage experience (like issue 1481 & 1526), now u can use the alternative way to handle them.

@imbajin Thanks for your advice.


Segfault on driver update

OS: Arch Linux
GPU:  NVIDIA Corporation G96CGL [Quadro FX 580]
Driver: nvidia-340-xx
Version: 0.3.2

Alacritty automatically segfaults on launch after a system update. (Same with kitty) I haven't been able to see any other messages regarding the crash. Here is the output;
$ RUST_BACKTRACE=1 alacritty
[1]    64392 segmentation fault (core dumped)  RUST_BACKTRACE=1 alacritty

Checked the other posts on segfaults, but this seems different from what they described.

Try rebooting.

I did reboot. (usually my first thing to do when kernel or graphics drivers are updated)

Have you tried running cargo clean and then building from a clean state?
If Kitty is also failing, that does sound like a driver issue though.

I never compiled a cargo app before. I followed the guide, and now have this error when compiling;
$ cargo build --release
error: process didn't exit successfully: `rustc -vV` (signal: 11, SIGSEGV: invalid memory reference)
--- stdout
rustc 1.34.1 (fc50f328b 2019-04-24)
binary: rustc
commit-hash: fc50f328b0353b285421b8ff5d4100966387a997
commit-date: 2019-04-24
host: x86_64-unknown-linux-gnu

But again, I agree that the issue is probably driver side. If anyone is using the old nvidia drivers, maybe they can chime in?

Has this GPU actually worked before? According to Nvidia's online documentation it only supports OpenGL version 3.0.

Alacritty was working fine up until the last update. Kitty never worked on this (in case its relevant, since another gpu accelerated terminal)

It's surprising to me that it worked before because usually Alacritty does not support OpenGL versions below 3.2.
It sounds to me like this might be an Nvidia driver issue with an old GPU though, since it happened after a system update. Archlinux should maintain a nice package cache, could you try downgrading to the previous driver version from there?


Is there a way to get the offsets of an instruction's opcodes within the instruction?

Is there a way to get the offsets of an instruction's opcodes within the instruction? I'm trying to get a list of bytes for a specific range of code with all address references zeroed out for a plugin i'm writing.

You can get the bits that define an instructions operand using:
instruction.getPrototype().getOperandValueMask(opIndex)

Thank you.


Whitespace removal

My pedantic obsessive compulsive nature just couldn't handle the whitespace. I'm sorry :| feel free to ignore this very simple pull request.

I was going to change part of the README.md
Specifically to use crystal deps I didn't even know shards install was an option until this project :).  Ya learn something new everyday!
brew install crystal-lang
git clone https://github.com/f/kamber myblog
cd myblog
crystal deps


docs: remove bugsnag-em from the docs

Goal
bugsnag gem 5.x is no more used and so bugsnag-em should be unreferenced.
Design
As per https://github.com/bugsnag/bugsnag-em/pull/5, we should remove references for bugsnag-em gem.
Changeset

Remove an entry about bugsnag-em from the docs.

Testing
n/a

@imjoehaines Status?


specifiy which wheels to download

sort of fixes https://github.com/jazzband/pip-tools/issues/475

Superseded by #1080.


undefined method generate_token

I followed the TL;DR for upgrading Devise and here's where I stand:
gem 'rails', '~> 3.2.13'
gem 'devise', '~> 3.1.0.rc2'

However, when logging in with email and password, I get the following:
NoMethodError - undefined method `generate_token' for #<Class:0x5665b60>:
  activerecord (3.2.13) lib/active_record/dynamic_matchers.rb:55:in `method_missing'
  devise (3.1.0.rc2) lib/devise/models/rememberable.rb:118:in `remember_token'
  devise (3.1.0.rc2) lib/devise/models/rememberable.rb:51:in `remember_me!'
  devise (3.1.0.rc2) lib/devise/controllers/rememberable.rb:26:in `remember_me'
  devise (3.1.0.rc2) lib/devise/hooks/rememberable.rb:5:in `block in <top (required)>'
...

If I uncheck the remember_me checkbox it works. What did I miss when upgrading to the new Devise version?

still having this issue in 3.5.10


documentation for ASN1ObjectIdentifier doesn't match actual value

Referring to this documentation for ASN1ObjectIdentifier, IIUC it asserts the value should have this shape:
interface Properties {
	class: [ASN1Class](https://asn1.oslojs.dev/reference/main/ASN1Class);
	type: [ASN1EncodingType](https://asn1.oslojs.dev/reference/main/ASN1EncodingType);
	tag: number;
	value: Uint8Array;
}

However, the value I receive for this has a property encodedId instead of value. Are the docs incorrect, or is this code? Or am I misunderstanding something else?

Side question: for detecting if I find a certain kind of ASN1 value inside the DER, is it better practice to match against the tag property (6 for ASN1ObjectIdentifier), or is it more appropriate to use instanceof checks?

Fixed, thanks! I would use the instanceof check to get TS to help you with the typing


Prepare 0.3.2 release

Contains another fix to prevent nil elements when placing additional elements on articles that end with empty paragraphs added by @christofdamian in PR #129 – thanks for the fix!

+1


Change the params api

It would be nice if you could just pass the params you want directly into the perform method. Basically take the api from:
class MyWorker < Mosquito::QueuedJob
  params(param_one : String, other : String)

  def perform
  # ...
  end
end

to
class MyWorker < Mosquito::QueuedJob
  def perform(param_one : String, other : String)
  # ...
  end
end

Just a way to simplify the API a bit.

This isn't a bad idea, but I don't think it creates enough benefit to warrant the breaking change that it would cause to the API. Perhaps for version 1.0, after Crystal 1.0 arrives.


Can't use relative paths in url() in scss files

Bug Report or Feature Request (mark with an x)
- [ ] bug report -> please search issues before submitting
- [x] feature request

Command (mark with an x)
- [x] new
- [x] build
- [ ] serve
- [ ] test
- [ ] e2e
- [ ] generate
- [ ] add
- [ ] update
- [ ] lint
- [ ] xi18n
- [ ] run
- [ ] config
- [ ] help
- [ ] version
- [ ] doc

Versions

npm: 6.4.1
node: v10.7.0
ng cli: 6.2.6
macOS High Sierra
Repro steps

Create new project

ng new ng-sass-test--style=scss

Add following files:

  - src
    - sprite
      - _sprite.scss
      - sprite.svg

With the following content:
# _sprite.scss
.sprite-common {
    background-image: url('sprite.svg');
}

Add the following line to src/styles.scss.
@import '~src/sprite/sprite';
Add the same line to src/app/app.component.scss.
The log given by the failure

ERROR in ./src/styles.scss (./node_modules/raw-loader!./node_modules/postcss-loader/lib??embedded!./node_modules/sass-loader/lib/loader.js??ref--15-3!./src/styles.scss)
Module Error (from ./node_modules/postcss-loader/lib/index.js):
(Emitted value instead of an instance of Error) CssSyntaxError: /***/ng-sass-test/src/sprite/_sprite.scss:2:22: Can't resolve 'sprite.svg' in '/***/ng-sass-test/src'

  1 | .sprite-common {
> 2 |     background-image: url('sprite.svg');
    |                      ^
  3 | }

ERROR in ./src/app/app.component.scss
Module Error (from ./node_modules/postcss-loader/lib/index.js):
(Emitted value instead of an instance of Error) CssSyntaxError: /***/ng-sass-test/src/sprite/_sprite.scss:2:22: Can't resolve 'sprite.svg' in '/***/ng-sass-test/src/app'

  1 | .sprite-common {
> 2 |     background-image: url('sprite.svg');
    |                      ^
  3 | }

Desired functionality

I would like to be able to use the relative file path in the scss file. I know this is solved by using an absolute path for the image. But I'm using the package svg-sprite, I'm not an expert in the package, but it looks like it doesn't support generation of an absolute path. Maybe I'm missing something in the angular-cli setup, so I can use this way of path-handling.
Mention any other details that might be useful

Can you try to prefix the path with a ./?

Images in scss are relative to the base url.
So in your example it should be ./sprite/sprite.svg

Just had a quick look at this, at this is tricky one.
Since in ./src/app/app.component.scss if you want to use relative url, the image src, should be ../sprite/sprite.svg, while for style.scss it should be ./sprite/sprite.svg.

Well yes, if I use a relative path in the one sass-file, it uses it as relative from every other file where I import it. Isn't there a way to just have it relative to the single file with the url()?

I think the recommended approach here is to put these sprite file in the assets folder, and use absolute paths (starting with /) for urls in sass files that are imported by other sass files.
In scss files at an absolute path;
background-image: url('/sprite/sprite.svg');

in your angular.json add the following so that the sprite is copied, under architect -> build -> options
"assets": [
    "src/sprite/sprite.svg"
],

From svg-sprite package point of view, there will be no changes.

The problem with that is that I can't change the sprite.scss, it is generated by the svg-sprite package. For as far as I know, it does not have the option to generate with an absolute path.

The simplest way to do it is to copy https://github.com/jkphl/svg-sprite/blob/6966592489dfcf2cd9ed2bba500cb8ee31c00b9c/tmpl/css/sprite.scss and add a lead slashes / and when using svg-sprite you provide this template via configuration example
config            = {
	mode: {
        css: { // Create a «css» sprite
            render: {
                scss : {
                    template: 'my-custom.scss',
                }
            },
        },
    },
},

Tried it out, works perfect. Thanks for the idea @alan-agius4 !

I’m also interested on this, since Stylus and LESS work fine with relative URLs and SASS doesn’t. For ejected projects resolve-url-loader does the trick.

I get the following, rocking Angular CLI: 7.3.0, Angular: 7.2.3.
// angular.json
"assets": [
    "src/assets"
]

background-image: url('/src/assets/images/icon.png');

// GET http://localhost:3000/src/assets/images/icon.png 404 (Not Found)

background-image: url('../../../../assets/images/icon.png');

// GET http://localhost:3000/icon.png 200 OK

As @agalazis, correctly pointed out the issue. Sass itself doesn't provide Url rewiring. While indeed resolve-url-loader might work in some cases, this relies on a non standard behaviour as it uses sourcemaps to rewire the paths.

@ruimarques, I suggest you open a separate issue with a reproduction for the issue you are encountering.

@alan-agius4 another point to mention in the past svgs in my css but after giving up and setting assets path now they are loaded as links after build

Please consider not removing rebaseRootRelativeCssUrls build option (https://github.com/angular/angular-cli/issues/14587) until this issue is fixed. Since this issue prevents using relative URLs, the rebaseRootRelativeCssUrls option is the only workaround when needing to specify a base-href when building.

background-image: url('~/assets/images/logo.svg');

works for me (version 8.0.1)

@iwnow This has been said to cause the app to be deployed with images copies to the dist folder (out of the assets folder) meaning you have multiple copies for no reason.
Please fix this, it's very sad that it's now  "The recommended method to transition is to use relative paths within the source stylesheet". When you cannot!

@michael-letcher yes I understand but I have no multiple copies, all works as expected
this is a simple workaround, but I still want this to be fixed

background-image: url('../../assets/img/bg-masthead.jpg'); worked for me.
Very annoying.

Hi guys, I've had the same problem and I fixed it as @Dada-Tech has mentioned
I have my site on https://url/account, some background-image: url('/image.png') and it was working on Angular v7.0.2. However, it is not working after migrating to v8.2.1
v7.0.2
scss: background-image: url('/image.png')
url after deploy: https://url/account/image.png
v8.2.1
scss: background-image: url('/image.png')
url after deploy: https://url/image.png

Wouldn't setting the --base-href value during ng build solve your issue @lfdantoni? (see: https://github.com/angular/angular-cli/wiki/build#base-tag-handling-in-indexhtml)

The solution is to write the path as if you were starting from "angular.json".
 The issue is about the inability to use relative paths :D
In some cases you can't use absolute because you have a baseHrefUrl like /en/ so / is going out of that folder to a path that doesn't exist.
You can workaround this using Express I guess but

I am having a similar issue. My production server is running the solution in a subfolder (mydomain.com/myapp/). I have setup the base href to "/myapp/" on localhost it is set to "/".
I have a css file placed in "assets/css" this file is referring to a file in "assets/images", I have done that writing "/assets/images/myimage.png" This is working fine localhost, but when publishing to the server it can't find the image. If I change url on the server in the css to "assets/images/myimage.png", it works on the server.
Then I have tried changing the url in the project to the one on the server ("assets/images/myimage.png"), but then it can't compile I am getting the error:  Can't resolve 'assets/images/myimage.png".
I have tried the following combinations, but without any luck :-|
'./assets/images/myimage.png'
'~assets/images/myimage.png'
'../assets/images/myimage.png'

@pnrdk did you try the following (note the / between the ~ and 'assets')?
~/assets/images/myimage.png

@pnrdk did you try the following (note the / between the ~ and 'assets')?
~/assets/images/myimage.png

This worked for me with the latest version of the CLI.

background-image: url('~/assets/images/logo.svg');

works for me (version 8.0.1)

thankk you

You can use inline CSS style

@iwnow MVP, that really works! Works in latest Angular version (8.3.21)! 🚀

background-image: url('~/assets/images/logo.svg');

works for me (version 8.0.1)

It's compiled to
background-image: url('/./assets/images/logo.svg');

in my case which is not what's expected.
Globally I'd recommand to never use absolute paths in url() as it is pure CSS and is always relative to the index.html file in production.
Anyway, the compiler complains when using relative paths, especially if you import a variables.scss file containing assets in your components.

@bnohad unfortunately this didn't work with --localize flag that has been introduced in angular 9 to compile several language locales using one command.
I use ng build --prod --localize command and has configured 2 languages but there no added language directory to url path when I write like this background-image: url('~/assets/icon.svg')
But I see language directory in Html base tag. Probably this is bug of angular 9

The CLI also adjusts the HTML base HREF for each version of the application by adding the locale to the configured baseHref. https://angular.io/guide/i18n

Just found that when using a caret ^ as the first character on the url provided in url(), the angular building process ignores it (it's actually a postcss-loader plugin), so with that you can use anything including relative urls expecting different base-hrefs. example:
.box {
  background: url("^myfiles/images")
}

Of course, there is an assets folder in angular where you will put the images (to have it working locally you can just url("^assets/images")) but the point is that when you want to deploy it in production, maybe you will copy your assets folder content to your server.com/myapp/myfiles folder, so in this case it's very useful, otherwise, the builder will try to resolve the path and it will throw an error because it can't found the files (actually, it has a problem when the url is relative),
In addition, as off-topic, when resolving the urls (not using ^), the files will be copied to the dist/project folder, not to dist/project/assets (that's the destiny of the assets folder configured in angular.json), so it will be quite a mess. A solution is to override the webpack scss loaders or (a clean way) is to use the next approach by including the target files in the assets directories, even of third party modules.
"assets": [
     "src/favicon.ico",
     "src/assets",
    { "glob": "**/*", "input": "./node_modules/mymodule/assets/", "output": "./assets/" }
 ],

For reference:
https://github.com/angular/angular-cli/blame/523a20d92bc516dbdf2ea17bc9b02d9402232c47/packages/angular_devkit/build_angular/src/angular-cli-files/plugins/postcss-cli-resources.ts#L72

Just found that when using a caret ^ as the first character on the url provided in url(), the angular building process ignores it (it's actually a postcss-loader plugin), so with that you can use anything including relative urls expecting different base-hrefs. example:
.box {
  background: url("^myfiles/images")
}

FYI - the caret sign was previously discussed in the following issue https://github.com/angular/angular/pull/32921

Thanks @dannyskoog , not supported feature means that maybe this hidden gem could be removed without warning?

Yes @devniel. And that was why I wasn't allowed to add it to the documentation (reference: https://github.com/angular/angular/pull/32921#discussion_r331118890)

Thanks It worked :+1:


Always prompt when exiting

Summary of the Pull Request
Add a setting with default as false. If it is true, then there will be a warning when exiting

References
Closes #2976 and addresses https://github.com/microsoft/terminal/issues/6549#issuecomment-646113805.
PR Checklist

[X] Closes #2976
[X] CLA signed. If not, go over here and sign the CLA
[X] Schema updated.

Detailed Description of the Pull Request / Additional comments
Change the name of CloseWarningDialog to CloseAllWarningDialog to avoid confusion and the new dialog (always warn) will be referred to as CloseWarningDialog.
Validation Steps Performed
Manual tests

If this merges, I will add a commit to #7077 for always warn on tab close

I think "exit" should be used instead of "quit"

I think "exit" should be used instead of "quit"

@AnuthaDev or even "Close"? Since the multiple tab warning uses close

I think "exit" should be used instead of "quit"

@AnuthaDev or even "Close"? Since the multiple tab warning uses close

Sure :)

Please merge this asap, it is very annoying when clicking close accidentally on a running program or session

This can be of great help. Looking forward to its being released.

This can be of great help. Looking forward to its being released.

Will this be ready in the next release?

Nope. We'll make sure to update this thread when there is.
The real issue here is that we need to figure this setting out. There's a long thread over in #6549 with a breakdown of how the options should work. It needs to be socialized with the rest of the team, preferably in a formal spec, to make sure we've got the options covered. I'd recommend subscribing to that thread.

Thank you so much for working on this draft work! We've chosen to take the project in a slightly different direction, and make sure that this feature is fully specified before we commit to it since it's deeply related to the other pane/tab/window closing work in your other PR.


Fix flaky ORC filecache test

Fixes #8776.  The fix attempted in #9188 was flawed in that it mistakenly assumed reattempts would increment existing metrics but in fact there are new metrics being generated for each attempt.  Therefore this takes a simpler approach of retrying the operation until we do not see any filecache data range misses and then verifying we see no misses and non-zero hits for footer and data ranges when expecting to get a full cache hit on a file.

build


Security example in tutorial raise bad request

OS: Windows 10 enterprise
FastAPI Version 0.60.1
Python version: 3.8.5

I have followed the tutorial example:
https://fastapi.tiangolo.com/tutorial/security/simple-oauth2/
When I try "See it in action" I get "Bad request".

Look at the response in network tools (e.g. Chrome network in Devtools) the response is correct. Or use curl.

curl -X POST "http://<IP_ADDRESS>:8000/token" -H  "accept: application/json" -H  "Content-Type: application/x-www-form-urlencoded" -d "grant_type=&username=johndoe&password=secret&scope=&client_id=&client_secret="
{"detail":"There was an error parsing the body"}

@JanhSander
Here's working example based on the docs:
With wrong password:
Request
curl 'http://<IP_ADDRESS>:8001/token' -H 'Authorization: Basic Og==' -H 'Content-Type: application/x-www-form-urlencoded' -H 'Accept: application/json' --data 'grant_type=password&username=johndoe&password=badpassword'

Response
{"detail":"Incorrect username or password"}

With correct password:
Request
curl 'http://127.0.==' -H 'Content-Type: application/x-www-form-urlencoded' -H 'Accept: application/json' --data 'grant_type=password&username=johndoe&password=secret'

Response
{"access_token":"johndoe","token_type":"bearer"}

If you don't get the above response, then, there's perhaps an error in your code

Same error:
400 Bad Request
{
"detail": "There was an error parsing the body"
}
I think it must be an error in the docs. The code I am running is just a copy from the docs.

Yes, resolved

Thanks for the help here @chrisjsimpson ! :clap: :bow:
Thanks for reporting back and closing the issue :+1:


Update Germany Hesse holidays

Updated Germany Hesse holidays.
Holidays for Hessia
https://de.wikipedia.org/wiki/Gesetzliche_Feiertage_in_Deutschland

Neujahr (New Year): 01.01.2020 (Wednesday);
Karfreitat (Good Friday): 10.04.2020 (Friday)
Ostersonntag (Easter Sunday): 12.04.2020 (Sunday)
Ostermontag (Easter Monday): 13.04.2020 (Monday)
Tag der Arbeit (Workers Day): 01.05.2020 (Friday)
Christi Himmelfahrt: 21.05.2020 (Thursday)
Pfingstsonntag (Pentecost Sunday): 31.05.2020 (Sunday)
Pfingstmontag (Pentecost Monday): 01.06.2020 (Monday)
Fronleichnam (Corpus Christi): 11.06.2020 (Thursday)
Tag der Deutschen Einheit (Unity Day): 03.10.2020 (Saturday)

Weihnachtstag (Christmas day 1): 25.12.2020 (Friday)

Weihnachtstag (Christmas day 2): 26.12.2020 (Saturday)

quick question about these new holidays: did they appear recently of were there holidays since "forever"? because ideally I'd like to make sure that it doesn't imply to have a if year > 2019: add_this() instead of this class property change that would be valid for every year, past, present or future.

hello... @czubik8805 any news update on this?

Unfortunately, I am forced to close this pullrequest. I found conflicting information about these holidays and I'm not sure. A friend from Germany says there are no these holidays... Sorry for the confusion.

don't worry about that: I'd rather have reliable code. Thank you for the update :o)


Support sqlfluff as an alternative formatter

https://github.com/sqlfluff/sqlfluff
In general sqlfluff is just a nicer and more well-mantained formatter that handles edge cases more robustly IMO. Faced a few cases where sql-formatter is just not doing things consistently, for example:
$ echo "CREATE TABLE foobar ( ids UUID[] );" | sql-formatter
CREATE TABLE foobar (ids UUID []);

$ echo "CREATE TABLE foobar ( ids TEXT[] );" | sql-formatter
CREATE TABLE foobar (ids TEXT[]);

In sqlfluff, they're always consistent. The CLI tool is also more CI-friendly as it can print diagnostics if there are any non-conformant sql files:
$ sqlfluff lint test.sql --dialect ansi
== [test.sql] FAIL
L:   1 | P:   1 | LT01 | Expected only single space before 'SELECT' keyword.
                       | Found '  '. [layout.spacing]

sqlfluff can also be configured a lot more flexibly: https://docs.sqlfluff.com/en/stable/reference/rules.html

I am not having trouble with sql-formatter right now. So I don't plan to support sqlfluff anytime soon. I will consider supporting it as more requests come in.
If we do decide to support more than one formatter, I will allow users to pass commands when formatting, and allow them to use the formatter of their choice.


Is there a way to update the list of IPs in realtime?

I want to add new IPs on the list. Will they be filtered once they are added in the list? or a server restart is necessary?
Thank you,
Alex

You can pass a function that can fetch the latest desired IP list.
`const ips = function() {
return ['<IP_ADDRESS>']
}
// Create the server
app.use(ipfilter(ips, { mode: 'allow' }))
module.exports = app`


Support looping playback

Thanks @december1981  for adding this feature.  I make a couple of tweaks:

Implemented a stub "rewind" in case MPV is used. The audio won't loop but at least it will build.
Consolidated runner options in one structure
Renamed loops to loop_playback. I'm sad we can't use the "loop" keyword so I opted for more clarity/verboseness, I hope you don't mind!

That looks fine my side!

One thing on my original commit, I wasn't too sure about was calling the broker to initiate replay  not sure if that might be called multiple times in the run loop until it takes effect...

One thing on my original commit, I wasn't too sure about calling the broker to initiate replay, if that might be called multiple times in the run loop until it takes effect. I can regress that, or if you want to tighten that up a little to prevent that.

you mean this bit?
                if self.loops && frame.is_none() {
                    self.send_control(MediaControl::Replay)?;
                }

That should just happen zero times or once at the end of playback I think (my memory is a bit rusty). I'll merge for now and if we find it's an issue we can address it with a follow up PR
I

Yes, it was to that I was referring.

thanks for implementing this feature @december1981 ! I'm sure many people will appreciate this new release :)

Not a problem, this is a great little app for fans of the terminal, glad to have contributed.


[Intel MKL] expose inter/intra op config

This PR is trying to expose inter/intra op for Intel CPU.
As the default value of inter/intra op is 0, this PR has no impact of the original command.

@davidsandberg please help to merge it, thanks.


Empty string is a valid JSON-key

Change Summary
An empty string is a valid JSON attribute name, so aliases checking cannot be just like bool(alias) it should be strictly compared with None.
Related issue number
fix #4253

Checklist

[x] Unit tests for the changes exist
[x] Tests pass on CI and coverage remains at 100%
[ ] Documentation reflects the changes where applicable
[x] changes/<pull request or issue id>-<github username>.md file added describing change
(see changes/README.md for details)
[x] My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

Thanks for the contribution.
While I think you're technically correct. I'm not sure I would support changing this at this late stage for pydantic V1.
I believe this is fixed in pydantic-core (the basis for pydantic V2) - if you're willing, it would be very useful to add unit tests for this to pydantic-core?
The plan is to get v1.10 released with mostly cosmetic changes and some new features that having been hanging around for a long time, then move ahead with V2.
What do others think? @PrettyWood @hramezani

Thanks @SergeyTsaplin for the patch :+1: and Thanks @samuelcolvin for explaining and asking my opinion.

I'm not sure I would support changing this at this late stage for pydantic V1.

Why would be the problem? seems we don't need a big change to support it?

it would be very useful to add unit tests for this to pydantic-core

:+1:

ye, I agree it's a small change. Just there's a lot in fields.py that scares me, its pretty complicated. My worry is subtle side-effects not covered tests, but maybe I'm being a wimp. :hand:
Let's wait and see what @PrettyWood thinks.

@samuelcolvin I don't think that the change will break some existed code, it can break only when a user uses Field(alias='')  for not "aliased" fields (I have no idea why to do it:)), but of course, the final decision is up to you. For me, it's not a problem to wait for 1.11 if you accidentally decide to merge it to the V1.
About the unit-test to pydantic-core - I can do it, but not soon. It may take me a few days to find a time for it.

About the unit-test to pydantic-core - I can do it, but not soon. It may take me a few days to find a time for it.

No problem with a wait, this is a marathon, not a sprint.

no, just keep committing, we squash on merge.

Let's wait for @samuelcolvin for final review and probably merge.

thanks so much.

Well (while I still think this is okay to be included in v1.10), my paranoia was well placed, tis was breaking starlite, see  https://github.com/starlite-api/starlite/pull/402.
Basically with pydantic v1's massive public (or semi-public) API, basically every change can break something. Bring on V2.


Install missing vendor dependencies in plugins with bin/grav install

Hello!
I exclude all vendor folders from my Grav repo with putting line vendor/ in my .gitignore in root folder. It brings some issues with installing repo in other computer just because composer install or bin/grav install creates vendor only in root folder.
Now I'm using this command in console:
find . ./user/plugins/ -name composer.json -maxdepth 2 -execdir composer install \;

Works good in Linux/Mac, but need to install Cygwin or Git Bash on Windows.
I also saw https://github.com/composer/installers where Grav is present but didn't understand how to use it...
Maybe .dependencies file can help, but found nothing about it in Grav learn and have problems with using:
https://github.com/getgrav/grav/issues/1027
I think that's checking user/plugins folder and installing missing vendor deps is a good thing for bin/grav install command. Maybe it was -vendor key or something.

this would be nice. currently precompiling Grav with HHVM leads to it complaining about a bunch of plugins:
Unable to stat file /home/atomicthumbs/pinopsida.com/html/user/plugins/admin/vendor/zendframework/zendxml/vendor/autoload.php
Unable to stat file /home/atomicthumbs/pinopsida.com/html/user/plugins/email/vendor/swiftmailer/swiftmailer/lib/Swift.php
Unable to stat file /home/atomicthumbs/pinopsida.com/html/user/plugins/email/vendor/swiftmailer/swiftmailer/tests/acceptance/Swift/swift_required.php
Unable to stat file /home/atomicthumbs/pinopsida.com/html/user/plugins/email/vendor/swiftmailer/swiftmailer/tests/acceptance.conf.php
Unable to stat file /home/atomicthumbs/pinopsida.com/html/user/plugins/email/vendor/swiftmailer/swiftmailer/tests/smoke.conf.php
Unable to stat file /home/atomicthumbs/pinopsida.com/html/user/plugins/login/vendor/birke/rememberme/vendor/autoload.php
Unable to stat file /home/atomicthumbs/pinopsida.com/html/user/plugins/login/vendor/birke/rememberme/test/Storage/PHPUnit/Extensions/Database/TestCase.php
Unable to stat file /home/atomicthumbs/pinopsida.com/html/vendor/seld/cli-prompt/vendor/autoload.php

I think this is the same issue, and I think it may relate to the fact that HHVM seems to be segfaulting regularly when I use the admin panel, but I can't confirm this.

I think your issue is having vendor/ excluded in your .gitignore and you're pushing to a server the repo, so the vendor folder in email/login/code is not committed.
Btw while most of Grav core is (automatically) tested on HHVM too, Admin or other plugins are not regularly tested on HHVM.

This is using the .zip package available on getgrav.org.

Ok so that leaves out the .gitignore issue. Those files are actually existing on the server, right?

@flaviocopes Issue closed. No plans to add this enhancement?


New command: m365 spe container list

Usage
m365 spe container list [options]
Description
Lists containers of a specific Container Type
Options

Option
Description

--containerTypeId [containerTypeId]
The Container Type Id of the container instance. Use either containerTypeId or containerTypeName but not both

--containerTypeName [containerTypeName]
The Container Type name of the container instance. Use either containerTypeId or containerTypeName but not both.

--deleted
When set it will list the deleted containers of that specific type

Examples
List containers of a specific type
m365 spe container list --containerTypeId "91710488-5756-407f-9046-fbe5f0b4de73"

List deleted containers of a specific type
m365 spe container list --containerTypeId "91710488-5756-407f-9046-fbe5f0b4de73" --deleted

Default properties

id
displayName
containerTypeId
createdDateTime

Additional Info
We may use the following GET request to get this:
/storage/fileStorage/containers?$filter=containerTypeId eq {containerTypeId}

https://learn.microsoft.com/en-us/graph/api/filestorage-list-containers?view=graph-rest-1.0&tabs=http
in order to get deleted containers we may use
beta/storage/fileStorage/deletedContainers?$filter=containerTypeId eq {containerTypeId}

whats important to notice and we should point it out in the docs that the endpoint to get the deleted containers as of now is still beta

Hi @Adam-it, few remarks from my side:

As mentioned before, let's either remove the short option or add a short option to containerTypeName.
The command description seems a bit odd. Shouldn't it be: Lists containers of a specific Container Type?
In the option descriptions, we should write container type as Container Type (with uppercase letters)
Usually, if we want to list removed items we have a command like entra user recyclebinitem list, should we use the same approach here (spe container recyclebinitem list) ?

@milanholemans thanks for the feed. I applied all except the last one. I don't have a strong opinion about it and I guess it does make sense. Lets wait for maybe some additional comment from another @pnp/cli-for-microsoft-365-maintainers on that point and move from there.
Thanks for having a look at my issue 👍

@pnp/cli-for-microsoft-365-maintainers kind reminder 🙏

Personally, I'm also more keen on the idea of creating a separate command for deleted items as it gives more clarity than an option here.
Besides that, the specs look very clear to me, nice work @Adam-it!

@milanholemans, @Jwaegebaert I removed the deleted option and I will spec out a separate command for getting the deleted items. Any suggestions how we should name this command?
how to get deleted items
beta/storage/fileStorage/deletedContainers?$filter=containerTypeId eq {containerTypeId}

Maybe something down the line with what @milanholemans mentioned, spe container recyclebinitem list. We already have several command groups available that handle actions with deleted items through recyclebinitem, so it could be interesting to do the same here.

Maybe something down the line with what @milanholemans mentioned, spe container recyclebinitem list. We already have several command groups available that handle actions with deleted items through recyclebinitem, so it could be interesting to do the same here.

ok added #6156

Can I work on this?

Hi @Adam-it
Sorry, I did not get the purpose of option containerTypeName.
Below is an example of one of the Container properties. It has got containerTypeId but no property named as containerTypeName.

Please help me understand. Thank you.

We'll need some logic that can find the proper container type by its displayName, and then use that object's ID to fetch all the related containers.

@nanddeepn containers don't have this property. In case someone will use containerTypeName in the command we first need to query the Container Type by its name to get its ID. After that we may just query all containers by containerTypeID.
This is a help for users that will allow them to operate using names rather than GUIDs


YouCompleteMe (code completion + snippets setup)

I have always had issues with YouCompleteMe + any snippet plugin .. Can you talk about your setup on how you manage to achieve code completion.. since vim-go has built-in support for this, I would love to see it here.

Hi @einthusan. YCM is not supported by vim-go. But you're right about adding information regarding a completion system. I'll do it, let's keep this PR open until it's being added to the tutorial.

@fatih sounds good. Awesome work on vim-go.

@fatih any ETD for this? A lot of new comers to go will be relying on vim-go and the first thing that they need is a autocomplete. It would be really helpful for them. I know your super busy but just a friendly reminder.

@einthusan no. I have a family, I have a job, I have tons of other open source projects. I've created this from my spare times. I'll add when I have time. Meanwhile this repo is open, anyone can contribute.

@fatih didn't mean to offend you.

I use supertab and it works perfectly for me

What about to check this. For me, it is working well.

Hi,
Unfortunately, I'm archiving this project and will no longer maintaining it. For more information, please read my blog post: Taking an indefinite sabbatical from my projects.
Thanks for the feedback and contribution.


feature: login by web like liara desktop

sth like liara login --web

@userdehghani We are currently working on implementing this feature. However, our implementation may use different flags and configurations than the ones you mentioned.
Thank you for your feature suggestion! 🌷

@vashian 😘


SimpleLayout in log4j-1.2-api does not log anything

Description
When using SimpleLayout provided in log4j-1.2-api, it doesn't log anything.   Is this by design?
In log4j1, it used to log with “%level - %m%n” pattern ?
Reproduction
        Logger logger = Logger.getLogger(clazz);
        logger.removeAllAppenders();
        logger.setLevel(Level.DEBUG);
        SimpleLayout layout = new SimpleLayout();
        logFile = File.createTempFile("log", "");
        FileAppender appender = new FileAppender(layout, logFile.toString(),
                        false, false, 0);
        logger.addAppender(appender);

From one of the unit-test we have.  This produces empty logs.  Works when replacing SimpleLayout with PatternLayout.

@kojinoguchi, SimpleLayout is by design a no-op. When a Log4j 1 configuration is read, SimpleLayout component will be replaced with a PatternLayout – see SimpleLayoutBuilder responsible for this transformation. But since you access the element programmatically, which is discouraged!1, you get the no-op component. In short, your Log4j 1 configurations using SimpleLayout will work.
1 Log4j Core treats the configuration file as the public API. Even though we do our best to keep the binary backward compatibility for publicly visible classes, fields, etc. in the code, we don't give the same guarantee that we give for the configuration file syntax.

When a Log4j 1 configuration is read, SimpleLayout component will be replaced with a PatternLayout

Aaah, I see.  In that case, I would have preferred if this empty SimpleLayout didn't exist or failed out with exception instead of silently swallowing the logs (no-op).   Thanks anyways for the infoi!


Cannot handle one-method definition the proper way

For example, from this link
https://webservices.optimalpayments.com/ilsWS/IlsService/v1?wsdl
easysoap.getMethodParamsByName will fail, when other clients, such as Boomerang will display it the proper way.

Hi and thanks for the Error report.
I updated the "wsdlrdr" dependencies with a fix for that.
Maybe you can check and report back.
Thx


Don't fail when codecov test coverage decreases

This PR introduces a threshold in order to not fail the PR when the
codecov test coverage decreases slightly by 0.1 %.

I think this depends on why we have test coverage in the first place? If it's just to make sure that there are no big unexpected drops because a PR accidentally broke the test setup that's one thing, but if we're hoping to increase coverage over time I wouldn't support this since each PR should at worst not change coverage, or improve it.
But all this relies on codecov working reliably, and I think we need more time to see if the current config is stable.
So I'd propose not failing at all when codecov shows reduced coverage for now, and once we trust it's working properly, then fail either on lowered coverage or accept 0.1% or similar drops as in this PR.

See #1754... I think my latest attempt to get Codecov working has failed, so I don't think it's worth merging this until that's resolved.

I'm reopening this in the hope that the issues with codecov are now resolved with #1865.

if we're hoping to increase coverage over time I wouldn't support this since each PR should at worst not change coverage, or improve it

I overlooked this argument.
Agreed. Then I also think we should close this PR.

I also agree. Better to enforce it and make per case exceptions while merging ^^.


Malformed JSON in the extras field: SyntaxError: Unexpected end of JSON input

While adding a new database connection (tried for Postgres and Redshift both), clicking on 'Test Connection' gives  Malformed JSON in the extras field: SyntaxError: Unexpected end of JSON input error.
The Extra field has
{
    "metadata_params": {},
    "engine_params": {},
    "metadata_cache_timeout": {},
    "schemas_allowed_for_csv_upload": []
}

And the Secure Extra field is empty. I also tried removing the JSON in the Extra field altogether but I still get this error.
The connection strings, I've tried are:
redshift+psycopg2://user:pass@host/dbname for Redshift and postgresql://user:pass@host:5432/dbname for Postgres
Expected results
The connection should be tested successfully.
Actual results
Clicking on 'Test Connection' gives  Malformed JSON in the extras field: SyntaxError: Unexpected end of JSON input error.
Screenshots

How to reproduce the bug

Go to Sources > Databases
Click on 'Add a new record' (Plus button)
Keeping all the field as it is, just add the database name and database URI
Click on 'Test Connection' to see the error.

Environment
(please complete the following information):

superset version: "0.999.0dev",
python version: Python 3.6.7
node.js version: v13.1.0
npm version: 6.12.1

Checklist
Make sure these boxes are checked before submitting your issue - thank you!

[X] I have checked the superset logs for python stacktraces and included it here as text if there are any.
[X] I have reproduced the issue with at least the latest released version of superset.
[X] I have checked the issue tracker for the same issue and I haven't found one similar.

Additional context
I have copied the default JSON in the extras field and checked its validity, and it is a valid JSON.

Hi @gamebusterz,
Thank you for taking the time to report this, I'm able to reproduce
Investigating cause and possible fix

@dpgaspar - I added #8630 to fix this issue.
Also, sorry...realize I missed this issue at first glance and created a new issue #8628 . I'll close my issue and update my PR to reference fixing this issue.

Getting the same error when trying to add a new presto database connection.

@bharath0208 are you using the latest version?

@gamebusterz I think it's fixed now I tried with the latest version and I don't see the error anymore


Add DynamicTypeSize support to Timeline

In case issue #195 will be merged, main issue to fully support DynamicTypeSize  will be to find where exactly the icon is located.
The icon might be aligned either to a first text line or to the container top.
Icon size is a dynamic value, while in timeline we use a constant
Also we should expose init with both custom header and content so user will be more flexible with desired design.  As an example, now horisontal padding is hardcoded which leads to a bigger gap, when  custom header is used instead of badge component.

Basic fixes were done as part of #315


Quick Start - does not work - gql-gen: command not found

Could you please help ?
I tried follow the Quick Start.
$ npm install graphql-code-generator
$ gql-gen init
-bash: gql-gen: command not found

this seems to work: $ node_modules/.bin/gql-gen init

Did you install graphql-code-generator in one directory and then change into another directory? If so, that module would not be found.
Other possible solutions would be:

Install globally (npm i -g graphql-code-generator # yarn global add graphql-code-generator)
Use npx (npx gql-gen init)
Install and refresh your terminal session.

If you could give your version of NPM and your OS, that would be helpful. Thanks!

@bastman please read the comments here: https://github.com/dotansimha/graphql-code-generator/issues/1222


Apply root tile scale to tileset geometric error

This is related to the problem that was brought up in https://github.com/CesiumGS/cesium/issues/5330. As of https://github.com/CesiumGS/cesium/pull/8182 we take a scale into account when computing a tile's geometric error (see updateGeometricErrorScale) but we don't take scale into account when computing the top-level tileset geometric error.
This can lead to situations where the tileset's geometric error is less than the root tile's geometric error and traversal exits early.
The fix is to scale the tileset's geometric error by the root tile's scale.

Thanks for the pull request @lilleyse!

:heavy_check_mark: Signed CLA found.
:grey_question: CHANGES.md was not updated.

If this change updates the public API in any way, please add a bullet point to CHANGES.md.

:grey_question: Unit tests were not updated.

Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

[ ] Cesium Viewer works.
[ ] Works in 2D/CV.

Thanks for the fix, @lilleyse! I tested this out on a tileset where the traversal was exiting early and the issue is resolved.

Cross-posting from the cesium community forum:
I have the same issue, where setting a maximumScreenSpaceError of 0.1 makes it so that my tileset appears at lower zoom levels - and it disappears when this max error is set to simply 1.0. I’m using Cesium version 1.106. Has this fix been merged to the current cesium build? Thanks a lot for getting back!
Looks like the fix indeed has been merged into 1.102, but I’m still seeing this issue. If you’d like a link to the dataset, I can share it privately.

Hi @jo-chemla, you can send private data to<EMAIL_ADDRESS>Please include a link to the original post so we know what the context is. Thanks!


Add Duration To Tick Method Of PendulumTicker

Would allow our futures based runtime to utilize this, and any clients that dont want to call tick at exactly the tick duration, can just pass the duration since they last called tick, so that real ticks are managed internally.
Any clients that want to send a real tick can just call it with the tick duration.

Might not want to do this due to supporting situations such as #3 without some way to also query this leftover duration.


Chore/code example

Hi,
I tried using your code usage example, but there seems to be a few errors. I've updated the usage example to a working example.

Thank you, I appreciate your help, this was built on a rush


Stock level status - localization

cart-item.component.html in line 107 renders conditionally the stockLevelStatus property only when it has value outOfStock.
We should use stockLevelStatus to conditaionally show something, but the message should be different, taken from translations.

Please use convention proposed in #1962

@Platonn here I would also get rid off this method:
https://github.com/SAP/cloud-commerce-spartacus-storefront/blob/77c7c65dac0eca5ccb7ae34303f29730df9cc8bf/projects/storefrontlib/src/lib/product/components/product-details/product-summary/product-summary.component.ts#L31
and use cxTranslate in the template.


Food list/controller

Make Food controller:
-Allow users to display the food that has been added by logged user
-Allow users to add new food
-Make sure there are no N+1 queries happening.

Hi @OnlyUnknown  ,
Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉
Highlights
Well Structured Code ✔
Used Git flow ✔
Optional suggestions
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.


[Operating-Systems-and-Networks] [xv6 resources]

Resource Name: xv6 Resources
Contributor (your) Name: Kunwar Shaanjeet Singh Grover
Resource Links:

https://ocw.mit.edu/courses/electrical-engineering-and-computer-science/6-828-operating-system-engineering-fall-2012/lecture-notes-and-readings/MIT6_828F12_xv6-book-rev7.pdf
https://github.com/YehudaShapira/xv6-explained

Have you completed studying this resource?: Read relevant parts for xv6 assignments
Your review of this resource: (1) is the official book with explanations that comes with xv6. (2) Are some great explanations of how and each and every part of it works. Great explanations which make you understand how things in a kernal actually work. For example a thing you can try to find yourself is "how does sleep syscall work in a kernal?"
Why do you think this resource will be useful for others?: From what I saw in my batch, most people either copied the xv6 assignments or did not actually understand what and how they were doing it. These resources help you understand and will enhance what you will learn from that assignment or from xv6 in general.

Added


Storage ARM Template for live tests

Our goal is to create common Azure resources using ARM template for each module. And pipeline to manage common resources and drop them in end. This will save cost and remove unwanted resources after test is complete or stopped in between
Storage will have one common arm template for Queue, File and Blob.
The pipeline will run ARM template and create common resources for example resource group, Accounts etc.
The pipeline will pass on names of these resources as ENV variable into test. For example PRIMARY_STORAGE_ACCOUNT_NAME
In the end pipeline will also delete these common resources which it created earlier and that will cause all the resources created to be removed.

/azp run java - storage - tests

/azp run java - storage - tests

Looks like this PR might have broken the Cosmos build


chore: Extend processing allowed origins with regex match and allow multiple origin support

There is a certain need from nwaku side to enhance support of allowed origin handling for rest request.
Specifically when nwaku serves js-waku requests coming through browser's response header validation.
In order to avoid CORS deny from browser side we need to support proper origin detection and answer.
The idea is to allow specify multiple possible allowed origin for the rest router and also to extend the support with wildcards.
For example: "localhost:*,http://<IP_ADDRESS>:80??,https://somehost.com"
The above example will support http or https requests from localhost on any port.
Also will fill "Access-Control-Allow-Origin" header field in case requests from http://<IP_ADDRESS>:80 or 8080 or any matching port. While only will allow requests from exactly https://somehost.com
This kind of flexibility will help nwaku integration a lot.
While we already tested the solution on our own nwaku build, I was struggling to compile nim-presto tests alone in my fork. I was using choosenim and set to 1.6.16 and all the dependencies nimble bring in.
Unfortunately there is a mainingful difference between the dependencies used under nwaku and what nimble can bring in makes nim-presto test code no compile.
I would like to ask some help on this to tackle down. Maybe it is lack of documentation on proper dependencies to be used, or need to better configure the project itself.
My added CORS tests are verified under nwaku repository separately. Tests can compile there with the dependencies configured under nwaku/vendor.

This change in presto lib will not be needed upon latest design changes with https://github.com/status-im/nim-presto/pull/73


Update Cargo.lock

I got the following error while building the AUR package:
==> Starting prepare()...
    Updating crates.io index
error: the lock file /build/sic-image-cli-git/src/sic/Cargo.lock needs to be updated but --locked was passed to prevent this
If you want to try to generate the lock file without accessing the network, remove the --locked flag and use --offline instead.

It is due to using --locked which is required for reproducible builds.
This PR simply updates Cargo.lock based on the latest state of the dependencies thus fixes this issue.

Oof 😢. That's strange, I updated the lock file minutes before bumping. Thanks!

bors r+

Release is running, included as v0.22.1

Thanks!


await breaks context

Hi guys
I used your library as a dependency of zipkin package.
And I spent 2 days and realized this context doesn't work with await at all
var createNamespace = require('continuation-local-storage').createNamespace;
var session = createNamespace('my session');

const fn = async () => {
	console.log('before await => ', session.get('misha')); // before await =>  yo man
	await Promise.resolve(1);
	console.log('after await => ', session.get('misha')); // after await =>  undefined
};

(async () => {
	session.run(async() => {
		session.set('misha', 'yo man');
		fn();
	});
})();

So if in my code there are awaits, and in enterprize there are a lot of awaits... then context will be lost just right after await.
v10.16.3 test in

Try cls-hooked, or if you're willing to upgrade your Node.js version, you could give AsyncLocalStorage a try. This module is not really well supported anymore as other modules have filled the gap for more modern versions of Node.js This was mostly targetted at pre-10.x versions of Node.js.

@mikhailrojo did cls-hooked work for your problem?

cls-hooked worked for me.

cls-hooked or AsyncLocalStorage works but it is a wrapper built around async-hooks which is in its experimental state as mentioned here. It is not well recommended for a production ready application.

AsyncLocalStorage has been stable since 16.4.0 and uses a tiny subset of async_hooks which will not change any time soon. Also, the "experimental" status of async_hooks is not a great representation, the "legacy" label is more accurate--it's not likely to change any time soon, but the core team discourages direct use of async_hooks as it exposes internals in ways that could be used unsafely. AsyncLocalStorage does not expose those internals so it's perfectly safe to use and recommended by the core team.


CloudSdk.getGCloudPath returns incorrect path for gcloud on PATH

When CloudSdk.getGCloudPath is called with an empty SDK path, this could mean we are trying to use gcloud that is on PATH rather than in a absolute directory. In this case getGCloudPath returns bin/gcloud path which is incorrect, and should just return gcloud so it will be searched on system PATH.

It's hard to believe that the class is broken in search gcloud on PATH at this point.

When CloudSdk.getGCloudPath is called with an empty SDK path, this could mean we are trying to use gcloud that is on PATH rather than in a absolute directory.

I think this assumption is not correct. I just looked into CloudSdk, and looks like the contract is that the CloudSdk instance must be instantiated with a concrete SDK home. For example, if you are setting an SDK home with the builder by CloudSdk.Builder.sdkPath(...), then it's your responsibility that you pass the right SDK home. If you don't call CloudSdk.Builder.sdkPath(), then CloudSdk.Builder.build() will try its best to discover a working SDK home in the system (including searching PATH). It's not that getGCloudPath() will dynamically search for an SDK home. The SDK home is baked into the class and static.
If getGCloudPath() is returning just bin/gcloud, maybe the chances are that you call CloudSdk.Builder.sdkPath(Paths.get("")). Try CloudSdk.Builder.sdkPath(null) (or not calling it at all).

Thanks @chanseokoh! This makes sense. We are working on a single gcloud executor using CloudSdk and we will try to make sure this use case is properly covered. I will try to quickly test your suggestions in the meanwhile.

Sounds like this is not an issue. Closing.