GitHub Actions CI does not download third party dependencies

Hello!
The Travis CI used to use https://github.com/nltk/nltk/blob/develop/tools/travis/third-party.sh to ensure that the Stanford CoreNLP, Parser, POSTagger and SENNA are downloaded before running the CI. The current Github Actions CI workflow does not do this, and more files are lacking too.
These are all the skipped and xfailed tests on the current develop branch:
=========================== short test summary info ============================
SKIPPED [2] nltk/test/childes_fixt.py:9: The CHILDES corpus is not found. It should be manually downloaded and saved/unpacked to [NLTK_Data_Dir]/corpora/childes/
SKIPPED [1] nltk/test/inference_fixt.py:10: Mace4/Prover9 is not available so inference.doctest was skipped
SKIPPED [1] nltk/test/nonmonotonic_fixt.py:10: Mace4/Prover9 is not available so nonmonotonic.doctest was skipped
SKIPPED [1] nltk/test/unit/test_brill.py:33: Should be tested in __main__ of nltk.tbl.demo
SKIPPED [1] nltk/test/unit/test_classify.py:35:

===========================================================================
NLTK was unable to find the megam file!
Use software specific configuration parameters or set the MEGAM environment variable.

  For more information on megam, see:
    <http://www.umiacs.umd.edu/~hal/megam/index.html>
===========================================================================
SKIPPED [6] nltk/test/unit/test_corenlp.py: Skipping all CoreNLP tests.
SKIPPED [1] nltk/test/unit/test_corpora.py:213: A full installation of the Penn Treebank is not available
SKIPPED [1] nltk/test/unit/test_corpora.py:190: A full installation of the Penn Treebank is not available
SKIPPED [1] nltk/test/unit/test_corpora.py:207: A full installation of the Penn Treebank is not available
SKIPPED [2] nltk/test/unit/test_corpora.py: Skipping test for mwa_ppdb.
SKIPPED [1] nltk/test/unit/test_rte_classify.py:88: Skipping tests with dependencies on MEGAM
SKIPPED [4] ../../../../../opt/hostedtoolcache/Python/3.6.14/x64/lib/python3.6/site-packages/_pytest/unittest.py:153: Requires Senna executable
SKIPPED [1] nltk/test/gluesemantics_malt_fixt.py:8: MaltParser is not available
SKIPPED [16] nltk/test/unit/test_tokenize.py:26: Tests for nltk.tokenize.stanford_segmenter skipped:

===========================================================================
  NLTK was unable to find stanford-segmenter.jar! Set the CLASSPATH
  environment variable.

  For more information, on stanford-segmenter.jar, see:
    <https://nlp.stanford.edu/software>
===========================================================================
SKIPPED [1] nltk/test/portuguese_en_fixt.py:5: portuguese_en.doctest imports nltk.examples.pt which doesn't exist!
SKIPPED [1] nltk/test/unit/lm/test_vocabulary.py:141: Test is known to be flaky as it compares (runtime) performance.
SKIPPED [1] nltk/test/unit/test_classify.py:35:

===========================================================================
NLTK was unable to find the tadm file!
Use software specific configuration parameters or set the TADM environment variable.

Tom Aarsen

Good issue! :+1: This has been on my todo list.
You've identified what I believe to be the last thing needed for GitHub Actions CI to match and exceed functionality that was available in Travis - running third party integration tests.
I've attempted to solve this, however, in the processes have discovered several things:

corenlp / postagger / senna dependencies used in Travis are not enough to run all tests with third party dependencies.
Travis used to run tests for third party only for latest version of python, I seem to recall from some conversations at the time that this was done to avoid stressing third party hosts with automated downloads that need to be recreated on every run for every python version.
Some of the third party dependencies only run on specific platforms that are a subset of what nltk codebase runs on. Some dependencies haven't had any maintenance or releases in a long time. Some of the dependencies used in Travis have had many new releases and are actively being developed and nltk integration tests are using old versions.

To address the things above, I'd like to propose creation of a git repository similar to https://github.com/nltk/nltk_data.
This achieves several things:

creates a mirror for third party dependencies, CI would use the mirror to automatically retrieve and cache dependencies. This eliminates any concerns around spiking downloads of some dependencies that were never downloaded before in CI.
provide scripts to automatically download dependency binaries documenting where they come from similar to third-party.sh
allow independent audit of dependencies to confirm their origin, the repository would also include binary file checksums that can be verified

Let me know what you think, feedback is welcome.

This sounds excellent. It's also time we considered dropping dependencies that are no longer maintained, except those used in the nltk book

That sounds like it could work. The following is a (potentially incomplete) list of dependencies that are required to run all tests. I.e. a list of dependencies that skipped tests complain about. Note, all ..._fixt.py files are imported from and used in the corresponding .doctest files to skip tests.

The dependency
Test Files that require the dependency
Special notes

The CHILDES corpus.
nltk/test/childes_fixt.py

Mace4/Prover9
nltk/test/inference_fixt.py  & nltk/test/nonmonotonic_fixt.py

MegaM
nltk/test/unit/test_classify.py

Penn Treebank
nltk/test/unit/test_corpora.py

SENNA
nltk/test/unit/test_senna.py

MaltParser
nltk/test/gluesemantics_malt_fixt.py

StanfordSegmenter
nltk/test/unit/test_tokenize.py
The code in this file gets modified in #2769.

TADM
nltk/test/unit/test_classify.py

The following tests related to third party dependencies are just always skipped:

The dependency
Test file that is (partially) skipped
Special notes

CoreNLP
nltk/test/unit/test_corenlp.py
There's also three different ways these tests can be skipped, one of which is always True.

MWAPPDB
nltk/test/unit/test_corpora.py

The following files contain tests that do not have third party dependencies, which are always skipped:

Test file that is (partially) skipped
Reason for skipping

nltk/test/portuguese_en_fixt.py
"portuguese_en.doctest imports nltk.examples.pt which doesn't exist!"

nltk/test/unit/test_brill.py
"Should be tested in __main__ of nltk.tbl.demo"

nltk/test/unit/lm/test_vocabulary.py
"Test is known to be flaky as it compares (runtime) performance." (See #2605)

The first table should help guide which dependencies might be desired to have - as we have tests for them. However, some of them might be outdated and no longer desirable, like @stevenbird mentioned.
The second table also contains dependencies that might require a critical look at. I.e.: Why are these tests skipped? Should we preserve these tests (under the assumption that they will in the future become useful)? Should the dependencies remain?
The third table contains some tests that simply require some work to fix/update/improve.
Consider these tables as a Todo-list.

Tom Aarsen

Just a quick chime-in, I'm still working out the LM vocabulary performance test. In the interest of reducing the number of tasks (and thus improving focus) you could probably remove it. I hope to arrive at something that doesn't block the CI while being informative enough at least in local development, if I fail at that we can remove the test.

Sounds good - I'll leave it off the list. I've wrestled with that test case in the past - it's a tricky one. Good luck with it!


Stylecop working again

Correct StyleCop violations

disable new PrefixCallsCorrectly rule (requires this or base where compiler is fine)
correct remaining violations
lots of long lines and out-of-order or misnamed static readonly fields

@rynowak, @pranavkm rebased and addressed last two review comments
note final "Use more var" commit relies on a couple of regex searches, not StyleCop

don't have a StyleCop runner that supports defining symbols such as ASPNETCORE50


Support promise for node low version

build failed, await for build fix in master branch.

I believe this is not needed any more.


Terraform init fails when initializing module

Scenario/Intent
Hello,
When I am trying to run the command terraform init in the directory with my .tf files, it fails with an error.
Environment Details

OneView Terraform Docker Image: hewlettpackardenterprise/hpe-oneview-sdk-for-terraform:v6.1.0-13-OV6.1
OneView Appliance Version: 6.10

Steps to Reproduce
You can fin below the Terraform files I have in my directory for the root and child module:
Root module
Variables.tf file
# Variable declarations

## OneView connection variables
variable "oneview_username" {
  description = "OneView Username"
  type        = string
}

variable "oneview_password" {
  description = "OneView Password"
  type        = string
}

variable "oneview_uri" {
  description = "OneView IP address or FQDN (endpoint)."
  type        = string
}

variable "ssl_enabled" {
  description = "Is SSL enabled by default"
  type        = bool
}

variable "oneview_apiversion" {
  description = "Version number of the OneView API"
  type        = number
}

## Ethernet networks variable description
variable "oneview_ethernet_network" {
    description="Parameters to create new ethernet networks"
    type =  list(
              object(
                    {
                        ethernet_network_name    = string
                        network_type             = string
                        ethernet_network_type    = string
                        ethernet_network_purpose = string,
                        ethernet_network_vlan    = number
                        ethernet_network_private = bool
                        smartlink                = bool
                    }
              )
            )
    //No default network, all networks configuration settings are handled in the variables.tfvars file
    default = []
}

Variables.tfvars
oneview_username   = ""
oneview_password   = ""
oneview_uri        = ""
ssl_enabled        = false
oneview_apiversion = 2800

oneview_ethernet_network = [
    {
      ethernet_network_name    = "TUN1",
      ethernet_network_type    = "Tunnel",
      network_type             = "ethernet-networkV4",
      ethernet_network_purpose = "General",
      ethernet_network_vlan    = 999,
      ethernet_network_private = false,
      smartlink                = false
    },
    {
      ethernet_network_name    = "TUN2",
      ethernet_network_type    = "Tunnel",
      network_type             = "ethernet-networkV4",
      ethernet_network_purpose = "General",
      ethernet_network_vlan    = 998,
      ethernet_network_private = false,
      smartlink                = false
    }
]

Main.tf
module "ethernet_networks" {
   source = "./Networking/1-networking-ethernet-create"
 }

versions.tf
terraform {
  required_version = ">= 0.13"
  required_providers {
    oneview = {
      source = "HewlettPackard/oneview"
      version = "6.1.0-13"
    }
  }
}

provider "oneview" {
  ov_username   = var.oneview_username
  ov_password   = var.oneview_password
  ov_endpoint   = var.oneview_uri
  ov_sslverify  = var.ssl_enabled
  ov_apiversion = var.oneview_apiversion
  ov_ifmatch    = "*"
}

Child module
Main.tf
resource "oneview_ethernet_network" "ethernetnetwork" {
  for_each = { for ethernetnetwork in var.oneview_ethernet_network : ethernetnetwork.ethernet_network_name => ethernetnetwork }

  name                  = each.value.ethernet_network_name
  type                  = each.value.network_type
  ethernet_network_type = each.value.ethernet_network_type
  vlan_id               = each.value.ethernet_network_vlan
  private_network       = each.value.ethernet_network_private
  smart_link            = each.value.smartlink
}

Expected Result
The command terraform init is successfull.
Actual Result
Initializing modules...
- ethernet_networks in Networking/1-networking-ethernet-create

Initializing the backend...

Initializing provider plugins...
- Finding hewlettpackard/oneview versions matching "6.1.0-13"...
- Finding latest version of hashicorp/oneview...
- Installing hewlettpackard/oneview v6.1.0-13...
- Installed hewlettpackard/oneview v6.1.0-13 (signed by a HashiCorp partner, key ID 2XXXXXXXXXXX)

Partner and community providers are signed by their developers.
If you'd like to know more about provider signing, you can read about it here:
https://www.terraform.io/docs/plugins/signing.html

Error: Failed to install provider

Error while installing hashicorp/oneview: provider registry
registry.terraform.io does not have a provider named
registry.terraform.io/hashicorp/oneview

The .terraform folder is still created with the modules and plugins folder.
The content of the file modules.json is as follow:
{"Modules":[{"Key":"","Source":"","Dir":"."},{"Key":"ethernet_networks","Source":"./Networking/1-networking-ethernet-create","Dir":"Networking/1-networking-ethernet-create"}]}

Hi,
You have not added the provider details in the sub modules. Please add the required_providers block in all the modules


Add Google Gemini 1.5 Pro EXP 0801

It's supposed to be very good! I did not use it much, but the changes have been tested.

I can't tell if it's smarter than 1.5 Pro, but it definitely has a much more recent knowledge cutoff, which was a weakness of 1.5 Pro compared to Sonnet 3.5.
@mckaywrigley Please merge.

Perhaps this model was removed, gives me a "model not found" error

@spammenotinoz Just checked, works for me. I assume Pro 1.5 works?

Yes Pro 1.5 works but not Pro 1.5 latest.
Thanks for checking must be something with my account.
On 26 Aug 2024, at 7:22 PM, Alexey Zaytsev @.***> wrote:

@spammenotinozhttps://github.com/spammenotinoz Just checked, works for me. I assume Pro 1.5 works?
—
Reply to this email directly, view it on GitHubhttps://github.com/mckaywrigley/chatbot-ui/pull/1826#issuecomment-2309753062, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AG7KS4B26K4HL6KHC5ZZZ2DZTLXURAVCNFSM6AAAAABL3UL5H2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMBZG42TGMBWGI.
You are receiving this because you were mentioned.Message ID: @.***>


Would like the ability to easily collapse all collections

Is your feature request related to a problem? Please describe.
Currently when opening Altair GraphQL Client all collections are expanded and the only way that I know to collapse them is one by one
Describe the solution you'd like
Would like the ability to easily collapse all collections at once

Hey @tracyjs6, what sort of interaction are you expecting for this?


The compiler's default behavior (if invoked without /EH) is poorly and incorrectly documented

Note that this applies to this and other pages in this section, as well as the documentation of /EH itself.
This page explicitly states that "C++ exception handling is the default". However, the compiler seems to default to no exception handling (if no /EH option is specified).
This is easy to verify, just try to compile this with "cl <file.cpp>": "int main() try { } catch (int code) { }". You'll get "warning C4530: C++ exception handler used, but unwind semantics are not enabled. Specify /EHsc"
There are two issues here: when the documentation says that exception handling is the default, it is misleading. But also, it doesn't clearly specify what the default of /EH is (when not specified). This should be corrected.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 5811ff85-117b-379d-711a-3983244282bf
Version Independent ID: 0eeacf8b-984a-087e-9b95-c6ae6b128946
Content: Exception handling in MSVC
Content Source: docs/cpp/exception-handling-in-visual-cpp.md
Product: visual-cpp
Technology: cpp-language
GitHub Login: @corob-msft
Microsoft Alias: corob

@TheJCAB
The phrase "C++ exception handling is the default" refers to the default exception handling setting in Visual Studio C++ projects. This could be made more clear.
When you compile at the command line and don't specify an exception handling model, you get the compiler's default exception handling model. The default model fully supports structured exception handling, and a limited, non-standard form of C++ exception handling. It does not unwind stack objects outside of try blocks, but it does transfer control to a matching catch block. Your example will work in spite of the warning, though non-trivial examples usually do not. For fully C++ conforming safe stack unwinding, you must specify /EHa, /EHs, or the recommended form, /EHsc.
So, why isn't /EHsc the default? Because thirty-some years ago, MSVC was a C compiler that supported structured exceptions by default. When it became a C++ compiler, and C++ got exception handling, you had to tell the compiler to use that instead of the default. It has been that way ever since, even though only a tiny fraction of the projects built use SEH, and a majority use standard C++ exceptions.
An update should appear in a day or so. Automation will close this issue when the changes are moved to the publishing queue.

I assume the update was published. Automation didn't close the issue. Closing since no other communication in over a year.


Remove Vector feature flag logic

This PR removes Vector feature flag logic from Builder Backend.
We need to remove the actual vector_vs_raster feature flag ¿before/after? merging this PR.
Related to https://github.com/CartoDB/cartodb/issues/13461

@rochoa Following the conversation from the other PR, could you take a look to this one and check if there is anything missing before merging?
I am going to ask if someone from the backend team can do a proper code review to this PR as well.

@javitonino What do you mean by invalidate vizjsons? Sorry, I am a bit slow today :)


Symmetric gauge

This PR introduces the function symmetrise_itensornetwork(ψ::ITensorNetwork) which will gauge an ITensorNetwork ψ and make it symmetric. As a result the contract of any local tensor ψ[v] with its adjoint whilst keeping one virtual index uncontracted will be a diagonal matrix.
A test is introduced for this PR:
i) It checks symmetrise_itensornetwork(ψ) is just a gauge transform and has an overlap of unity with ψ
ii) It checks that when one does simple belief propagation on symmetrise_itensornetwork(ψ) the resulting message tensors are diagonal (a property guaranteed by the symmetrise function).
@mtfishman : I haven't implemented a check for setting any small negative diagonal elements of D to 0. This is because we also have to take the inverse of D and so such a reset would create infinities in inv_D. Shall I just throw an error/ warning if any diagonal elements of D are below a small, positive tolerance?

Codecov Report

Merging #72 (7db5bf2) into main (d197854) will increase coverage by 0.33%.
The diff coverage is 100.00%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@            Coverage Diff             @@
##             main      #72      +/-   ##
==========================================
+ Coverage   75.83%   76.17%   +0.33%
==========================================
  Files          56       57       +1
  Lines        2918     2959      +41
==========================================
+ Hits         2213     2254      +41
  Misses        705      705

Impacted Files
Coverage Δ

src/ITensorNetworks.jl
77.77% <ø> (ø)

src/gauging.jl
100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

modify_diagonal_els_itensor is a nice idea. I would use the name map_diag (in analogy to Julia's Base.map).
Here's an implementation using some internal/hidden functions from NDTensors:
using ITensors
using ITensors.NDTensors
using ITensors.NDTensors: getdiagindex, setdiagindex!

function map_diag!(f::Function, it_destination::ITensor, it_source::ITensor)
  return itensor(map_diag!(f, tensor(it_destination), tensor(it_source)))
end
map_diag(f::Function, it::ITensor) = map_diag!(f, copy(it), it)

function map_diag!(f::Function, t_destination::Tensor, t_source::Tensor)
  for i in 1:diaglength(t_desination)
    setdiagindex!(t_destination, getdiagindex(t_source, i), i)
  end
  return t_destination
end
map_diag(f::Function, t::Tensor) = map_diag!(f, copy(t), t)

# Convenience functions
sqrt_diag(it::ITensor) = map_diag(sqrt, it)
inv_diag(it::ITensor) = map_diag(inv, it)
invsqrt_diag(it::ITensor) = map_diag(inv ∘ sqrt, it)
pinv_diag(it::ITensor) = map_diag(pinv, it)
pinvsqrt_diag(it::ITensor) = map_diag(pinv ∘ sqrt, it)

Passing a cutoff to eigen like I comment above or using a pseudoinverse (LinearAlgebra.pinv) would be approaches to handle zero or small eigenvalues. However, to deal with negative eigenvalues, I think the most general approach is adding a small positive shift (a regularization), for example X_D = map_diag(x -> x + regularization, X_D) where we can have regularization as a keyword argument passed to symmetric_gauge. Maybe we could default to regularization=10eps(real(scalartype(ψ)), or automatically set it to something slightly larger than the most negative eigenvalue of X_D (though that could be uncontrolled if it is not close enough to being positive semidefinite, for example if the message tensors aren't properly converged).

Thanks Matt! Let me implement those changes. So we will have one keyword argument for the cutoff of eigen and one for regularising the values of X_D and avoiding anything small and negative.
I guess ideally those functions for mapping the diagonal of an ITensor should go in ITensors.jl but perhaps there is not enough of a use case for it to make a PR for them?

I think those are good candidates for ITensors.jl/NDTensors.jl but we can just keep them in ITensorNetworks.jl for now (maybe in new folders src/NDTensorsExt and src/ITensorsExt) and test them out a bit more here.

Added a Keyword argument to specify number of iterations for calculating message tensors in symmetric_gauge(). Increasing this this helps improve the convergence to diagonal message tensors a lot so we can increase to atol=1e-8 in the check.

Looks good, thanks!


Streams of type Observable | Observable does not work

Bug Report
Current Behavior
You cannot apply any operators to a stream of type Observable<x> | Observable<y>.
The stream Observable<x | y> works as expected.
Reproduction
Look in src/index.ts and uncomment the error part
https://codesandbox.io/s/dazzling-waterfall-rcp91
Environment

RxJS version: 6.5.3

Possible Solution
To solve the issue I do the following:
export type InnerUnion<T> = Observable<T extends Observable<infer U> ? U : never>;
// InnerUnion<Observable<x> | Observable<y>> = Observable<x | y>

This isn't an RxJS issue. This is a TypeScript limitation. When TypeScript sees Observable<x> | Observable<y> it will limit the methods to those that are common to both Observable<x> and Observable<y> which means that the only pipe signature that matches both is pipe().

Ah, I see. That makes sense. Thank you


Rewrite github project references

Fix for https://github.com/microsoft/pxt/issues/6136
This change handles gracefully the publishing of github project with local references.
When a project gets published,

all github local dependencies (workspace:) get rewritten to github references (github:)
the tag is used otherwise the branch is used
if the commit is used to create tag, tag requirement is enforced.

Scenario:
repoA and repoB are both used locally. repoB has a dependency on repoA. When commiting, reference to repoA workspace:... should be converted to github:...

It does restore the workspace reference so you still reference the local projects in your browser but have GitHub refs in GitHub.


Add option to list instances of a web app slot

Related command

az webapp deployment slot
Is your feature request related to a problem? Please describe.

There doesn't appear to be a method to identify web app slot instances outside of navigating to https://resources.azure.com
Describe the solution you'd like

I'd like to see a new list-instances option added to the az webapp deployment slot command, similar to how we can already use the az webapp list-instances command.
Describe alternatives you've considered

Using https://resources.azure.com, which is not preferred or desirable.
Additional context

Web app slot instances can be viewed at this endpoint: https://management.azure.com/subscriptions/<SUB_ID>/resourceGroups/<RSG_NAME>/providers/Microsoft.Web/sites/<WEB_APP_NAME>/slots/<SLOT_NAME>/instances?api-version=2020-12-01

Thank you for opening this issue, we will look into it.


Default config for squad is incorrect

Describe the bug
If you download Squad, it will download the plain_text version, but the config still specifies "default", so if you set the offline mode the cache will try to look it up according to the config_id which is "default" and this will say;
ValueError: Couldn't find cache for squad for config 'default'
Available configs in the cache: ['plain_text']
Steps to reproduce the bug

export HF_DATASETS_OFFLINE=0
load_dataset("squad")
export HF_DATASETS_OFFLINE=1
load_dataset("squad")

Expected behavior
We should change the config_name I guess?
Environment info
linux, latest version of datasets

you can try: pip install datasets==2.16.1


⚠ Bofrost.at has degraded performance

In edf9a21, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 2194 ms

Resolved: Bofrost.at performance has improved in 3c2528d after 14 minutes.


Bump min go version to 1.17

Please provide the following information:
What is this change about?
Change the minimum go version for this library to go1.17.
What problem it is trying to solve?
go1.16 is no longer in support, so we should encourage projects
importing this library in the future to upgrade their go version to at
least 1.17.
What is the impact if the change is not made?
Projects importing this library may continue to use go1.16.
How should this change be described in diego-release release notes?
N/A
Please provide any contextual information.
N/A
Tag your pair, your PM, and/or team!
N/A

Thanks! @ctlong


KRKNWK-15150: CSL phase calculation reworked

The following west manifest projects have been modified in this Pull Request:

Name
Old Revision
New Revision
Diff

hal_nordic
https://github.com/zephyrproject-rtos/hal_nordic/commit/4ee20fd6ca25cd4bf78918f4fffee016a4ef47b9 (master)
https://github.com/zephyrproject-rtos/hal_nordic/pull/123
zephyrproject-rtos/hal_nordic#123/files

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@e-rk @edmont could you please have a look at this PR? It's a cherry-pick from https://github.com/zephyrproject-rtos/zephyr/pull/52192

https://github.com/zephyrproject-rtos/zephyr/pull/52192 was merged, so I updated tags to [nrf fromtree] and rebased.


[ISSUE #4371] Move Rabbitmq plugin into Connector from Storage plugin moudle

Fixes #4371.
Motivation
Explain the content here.
Explain why you want to make the changes and what problem you're trying to solve.
Modifications
Add Connector RabbitMQ.
Documentation

Does this pull request introduce a new feature? (yes / no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
If a feature is not applicable for documentation, explain why?
If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

It works just fine here when I do my part here.
But the RabbitMQSinkConnector as the rabbitmq-producer in eventmesh-storage-rabbitmq doesn't work at the first time. We need to bind channel with exchangeName and queueName like we do it in the rabbiotmq-consumer  Just in case we connect the rabbitmq-server for the first time without creating a binding in rabbitmq-server manually.
  rabbitmqClient.binding(channel, sinkConfig.getConnectorConfig().getExchangeType(),
        sinkConfig.getConnectorConfig().getExchangeName(),
        sinkConfig.getConnectorConfig().getRoutingKey(),
        sinkConfig.getConnectorConfig().getQueueName());

To verify RabbitMQSinkConnector

launch your rabbitmq server and eventmesh-runtime.
enable sinkConnector and check sink-config.yml.

pubSubConfig:
  meshAddress: <IP_ADDRESS>:10000
  subject: TopicTest
  idc: FT
  env: PRD
  group: rabbitmqSink
  appId: 5031
  userName: rabbitmqSinkUser
  passWord: rabbitmqPassWord
connectorConfig:
  connectorName: rabbitmqSink
  host: your.rabbitmq.server
  port: 5672
  username: coyrqpyz
  passwd: passwd
  virtualHost: coyrqpyz
  exchangeType: TOPIC
  # build-in exchangeName or name a new one after you create it in rabbitmq server.
  exchangeName: amq.topic
  # rabbitmq server will create the routingKey and queueName automatically after you connect to it if they aren't exist before.
  routingKey: eventmesh
  queueName: eventmesh
  autoAck: true

start your RabbitMQConnectorServer and you will find the channel in rabbitmq server.

send a message to the Topic TopicTest as you defined above and check the result it rabbit console.

To verify RabbitMQSourceConnector

launch your rabbitmq server and eventmesh-runtime.
enable sourceConnector and check source-config.yml (Basically the same as sink-config.yml)
start your RabbitMQConnectorServer and you will find the channel in rabbitmq server.
put a cloudevent message to queue. Then it will be send to eventmesh, you can check it by log or in eventmesh-dashboard

{"version":"V1","data":"{\"content\":\"testAsyncMessage\"}","extensions":{"protocolversion":"1.0","reqeventmesh2mqtimestamp":"1692799850158","rsp0idc":"FT","datacontenttype":"application/cloudevents+json","subject":"TopicTest","reqsendeventmeship":"[fe80:0:0:0:261b:aa79:91fe:28f3%utun2]","reqreceiveeventmeship":"[fe80:0:0:0:261b:aa79:91fe:28f3%utun2]","protocoldesc":"tcp","rsp0sys":"5031","source":"/","type":"cloudevents","ttl":"30000","reqeventmesh2ctimestamp":"1692799850775","reqmq2eventmeshtimestamp":"1692799850771","rsp0ip":"<IP_ADDRESS>","protocoltype":"cloudevents","rsp0group":"rabbitmqSink","id":"06315467-9624-47d7-b751-d7e4cd04b452","reqc2eventmeshtimestamp":"1692799850091"}}

FYI I just added a new moudel eventmesh-connector-rabbitmq witout removing eventmesh-storage-rabbitmq in case it is still needed. We may clean it up after it is ready for the community.


[FIX] update naming patterns in figures.json

two items that I thought should be changed:

contrast -> ceagent in the anatomical default_path_patterns
remove _bold from echo pattern, (I'm not sure what the original intention of the pattern was, but the double backslash does not appear to match a reasonable string, and echo is not required to be the last key-value pair in the default_path_patterns)

I think it was probably supposed to be _bold\\., but I agree that it doesn't make sense in this context.


Load new images parallel with computation current image on GPU

I want to load new images parallel with computation current image on GPU Mali T628 in OdroidXU4 to reduce an overhead time ( time spend on copying a new image to GPU for computation). Do you know how to do that? Whether It can do?

@minhntu , Hi, in your system are there two blocks of memory for the GPU? While GPU access one block, you want CPU to update the other block? Or it is a single block memory, while GPU access one half , you want CPU update the other half?

Hello @minhntu,
Yes theoretically there is nothing stopping you doing that. Probably create another command queue for this purpose and map your input CLTensor, fill it and unmap, while the network runs. Note that you have to do some synchronization as the first layer of you network that requires your input should have finished before trying to fill your input and on the hand the input filling should have finished before rerunning you network.


[8.x] Mixed orders in cursor paginate

It is possible to remove the following limitation from cursorPaginate() function:

It requires that the "order by" directions (descending / ascending) are the same if there are multiple "order by" clauses.

Example:
$cursor = ['test' => 'foo', 'another' => 'bar', 'third' => 'baz'];
$query->...->orderBy('test')->orderByDesc('another')->orderBy('third');

A desired SQL statement:
SELECT * FROM table
WHERE
    (test > 'foo' or
       (test = 'foo' and (another < 'bar' or
           (another = 'bar' and (third > 'baz')))))
ORDER BY test asc, another desc, third asc
LIMIT 100

Todo

[ ] Remove the limitation from docs.
[ ] Remove the deprecated CursorPaginationException in 9.x.
[x] Check if DBMS can handle queries generated by this PR as efficiently as queries generated by the current Laravel release.
[x] Remove the redundant parentheses generated by this PR.
[ ] Add more tests to check it handles cursors with more that 2 variables and mixed directions.

Tests
I tried to fix tests by checking the resulting query and bindings every time the mocked get() function is called.

Ping @paras-malhotra

@halaei, the reason I didn't take this path is because of the changing behaviour of index usage based on the DB engine. I guess if we construct queries like this, we'll need to check if all 4 databases are able to use: (a) a composite index and (b) a primary index on the first column if a composite index is missing, on the queries constructed. The benefit of the tuple comparison operator is that the DB engine takes care of this automatically.
I haven't looked into index support for database engines but you may find this article useful: https://use-the-index-luke.com/sql/partial-results/fetch-next-page

I am not sure about database support either. Ideally DB engines should be able to find and use the best index in the most efficient way without any hint, but I don't know if they are all as perfect as we need them to be. Regardless of this PR, I would really like to know how DB engines work in this regard.
If there is a performance issue for queries in this PR, beside reporting the issue to DB maintainers :) maybe we can use the simpler tuple comparison clause if possible and fallback to queries generated by this PR if it isn't possible.
One important consideration is that according to sql-workbenck, tuple comparison with < or > is not supported in SQL-Server and Oracle. So this PR removes another limitation for SQL-Server, which is officially supported by Laravel.
Moreover, since this PR doesn't use raw queries, it should probably work for jenssegers/laravel-mongodb too, which is personally important to me.

I'd recommend we stick to the tuple comparison to avoid extra complexity on constructing queries for index usage. If we go with this PR, we should test it or check out the docs to ensure the index is actually used. The whole idea for cursor pagination is better query performance, and if it messes up the execution plan, in the end it may not be worth it from a performance perspective when compared to offset pagination.

According to MySQL optimization docs, there are scenarios where using row constructor, e.g. tuples, actually degrade the performance. So maybe not using tuple comparison is actually a performance optimization! I try to check it with some benchmark.

My benchmark result for MySQL 8.0.25:
Table
CREATE TABLE `foos` (
  `id` bigint unsigned NOT NULL AUTO_INCREMENT,
  `foo` int NOT NULL,
  `bar` int NOT NULL,
  `baz` int NOT NULL,
  `created_at` timestamp NULL DEFAULT NULL,
  `updated_at` timestamp NULL DEFAULT NULL,
  PRIMARY KEY (`id`),
  KEY `foos_foo_bar_baz_index` (`foo`,`bar`,`baz`)
) ENGINE=InnoDB AUTO_INCREMENT=2000001 DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_unicode_ci;

Data
The table is seeded with 2 million records, with 0<=foo<10, 0<=bar<10, 0<=baz<20000. This distribution noticibly slows down queries that can't use the entire 12-byte length of the multi-column index.
for ($foo = 0; $foo < 10; $foo++) {
    for ($bar = 0; $bar < 10; $bar++) {
        for ($i = 0; $i < 20000; $i += 100) {
            $values = [];
            $date = now();
            for ($baz = $i; $baz < $i + 100; $baz++) {
                $values[] = [
                    'foo' => $foo,
                    'bar' => $bar,
                    'baz' => $baz,
                    'created_at' => $date,
                    'updated_at' => $date,
                ];
            }
            \App\Models\Foo::query()->insert($values);
        }
    }
}

Queries
In the following queries we try to get 50 elements from the near end of the index, to make sure they will be slow unless they perfectly use the multi-column index.
1. Paginating all items:
1.1. Using single column comparison:
select * from `foos` where (`foo` > 9 or (`foo` = 9 and (`bar` > 9 or (`bar` = 9 and (`baz` > 19000))))) order by `foo` asc, `bar` asc, `baz` asc limit 51;

Runtime: less than 2 milliseconds.
key_len reported by explain select statement: 12.
1.2. Using tuple comparison:
select * from `foos` where (`foo`, `bar`, `baz`) > (9, 9, 19000) order by `foo` asc, `bar` asc, `baz` asc limit 51

Runtime: 16 seconds.
key_len reported by explain select statement: 12.
This result must be a bug from MySQL. It is multiple times slower than scanning the whole table, e.g. by select count(*).
2. Paginating items with foo = 9:
2.1. Using single column comparison:
select * from `foos` where `foo` = 9 and (`bar` > 9 or (`bar` = 9 and (`baz` > 19000))) order by `bar` asc, `baz` asc limit 51

Runtime: less than 2 milliseconds.
key_len reported by explain select statement: 12.
2.2. Using tuple comparison:
select * from `foos` where `foo` = 9 and (`bar`, `baz`) > (9, 19000) order by `bar` asc, `baz` asc limit 51

Runtime: 0.5 seconds.
key_len reported by explain select statement: 4.
This result agrees with MySQL documentation: https://dev.mysql.com/doc/refman/8.0/en/row-constructor-optimization.html
Conclusion
With MySQL, it is better to use single column comparison for cursor pagination of rows sorted by a 3-column index. Using tuple comparison is slower than simple pagination for some cases. This is most probably caused by a bug in MySQL and InnoDB engine.

@halaei after further investigation, I found this thread: https://github.com/laravel/framework/pull/37216#issuecomment-863787431. It seems that it may be more efficient to actually construct the queries with and/or clauses rather than the tuple syntax, at least for mySQL 8.0. I'm not sure about the other databases though.

@paras-malhotra any other thoughts on this?

Based on the analysis by @halaei and https://github.com/laravel/framework/pull/37216#issuecomment-863787431, it does seem that this PR will improve performance for mySQL but I'm not sure how it compares for PostgreSQL.
I guess, since there are more mySQL users than PostgreSQL and also the fact that SQL Server isn't supported by the current cursor pagination, I think it makes sense to accept this PR. 👍

For the record, MySQL has confirmed the performance bug I reported as "a duplicate of an internally-filed bug report, which is not yet scheduled for fixing":
https://bugs.mysql.com/bug.php?id=104128

Do we have any integration tests on this feature that actually hit the database?

@taylorotwell there are some tests here: https://github.com/laravel/framework/blob/855a919d08b45f93cb3cf709736528c3d1531884/tests/Database/DatabaseEloquentIntegrationTest.php#L324-L402

@halaei can you rebase with 8.x please?

@driesvints I can't pull. Maybe GitHub is down!

Can you mark this as draft until all your checkbox tasks are complete?

The only remaining checkbox can only be done after this PR is merged. And I don't think it is really required to "remove the redundant parentheses generated by this PR", but let me know if I you need me to work on it.


B:18828 - Add Create Okta Account Logic to UpdateRequestedOfficeUser(MERGE AFTER B-18821 & B-18825)(READY)

Agility ticket
Integration MR
Summary
MERGE AFTER B-18821 - MERGED
MERGE AFTER B-18825 - MERGED
This PR introduces additions to the UpdateRequestedOfficeUserHandler. These additions includes the following:

Create okta Account Logic - (This only happens in the case that param.Status == "APPROVED")
UpdateRequestedOfficeUser will always run in all cases EXCEPT the case when CreateAccountOkta logic runs and fails.

Okta API Specifications explains more about the okta api specifications
Verification Steps for the Author
These are to be checked by the author.

[ ] Tested in the Experimental environment (for changes to containers, app startup, or connection to data stores)
[ ] Have the Agility acceptance criteria been met for this change?

Verification Steps for Reviewers
These are to be checked by a reviewer.

[ ] Has the branch been pulled in and checked out?
[ ] Have the BL acceptance criteria been met for this change?
[ ] Was the CircleCI build successful?
[ ] Has the code been reviewed from a standards and best practices point of view?

Setup to Run the Code

Instructions for starting storybook
Instructions for starting the MilMove application
Instructions for running tests

How to test

Start the client & server and log in as a MM Admin
Using postman or swagger UI
Send a PATCH request to /requested-office-users/{officeUserId} (Make sure Status is set to "APPROVED")
Provide relevant needed data for Okta account creation such as otherUniqueId, Email, Firstname, Lastname, gsaID, EDIPI, MobilePhone

Example: May need to adjust for your local env
{
"firstName": "Leo",
"middleInitials": "J",
"lastName": "Spaceman",
"email"<EMAIL_ADDRESS>"telephone": "212-555-5555",
"roles": [
{
"name": "Transportation Invoicing Officer",
"roleType": "transportation_invoicing_officer"
}
],
"transportationOfficeId": "f344dde8-1c04-4a37-b66d-3f1bab7c494c",
"edipi": "1111111110",
"otherUniqueId": "1111111110",
"rejectionReason": "string",
"status": "APPROVED"
}

[ ] There are no aXe warnings for UI.
[ ] This works in Supported Browsers and their phone views (Chrome, Firefox, Edge).
[ ] There are no new console errors in the browser devtools.
[ ] There are no new console errors in the test output.
[ ] If this PR adds a new component to Storybook, it ensures the component is fully responsive, OR if it is intentionally not, a wrapping div using the officeApp class or custom min-width styling is used to hide any states the would not be visible to the user.
[ ] This change meets the standards for Section 508 compliance.

Backend

[ ] Code follows the guidelines for Logging.
[ ] The requirements listed in Querying the Database Safely have been satisfied.

Database
Any new migrations/schema changes:

[ ] Follows our guidelines for Zero-Downtime Deploys.
[ ] Have been communicated to #g-database.
[ ] Secure migrations have been tested following the instructions in our docs.

@TevinAdams Could you resubmit this with your changes cherry-picked from the integration branch? I see that you had some dependencies which is likely how the git history got poluted, but we need to ensure 1:1 commits as much as possible

@cameroncaci  The integration branch for this no longer exist.

@TevinAdams Could you resubmit this with your changes cherry-picked from the integration branch? I see that you had some dependencies which is likely how the git history got poluted, but we need to ensure 1:1 commits as much as possible

@cameroncaci The integration branch for this no longer exist.

Correct, but the commits will always still exist even if a branch is deleted. Optionally, the branch can be restored


dropdown styles don't work

Since we use the select element for dropdowns now, we completely ignore the style attribute.

Perhaps we just delete the dropdown style attribute? We don't provide those style attributes on other input widgets, only on buttons.
Essentially this is just deleting this attribute: https://github.com/ipython/ipywidgets/blob/master/ipywidgets/widgets/widget_selection.py#L229

Actually, given our choices to (at least temporarily) change the dropdown to a select, perhaps we literally rename it and deprecate the dropdown? In the future with a custom dropdown, we can just change the select to a dropdown?

I have no opinion on this.

Actually I prefer to keep the dropdown. We have a phosphor implementation of it and really nice styling. I guess that it can get back in when we fix the issue.

It's broken right now, so I think we should either remove the attribute or fix it (i.e., add styles to the select widget to do fulfill this).

I'm happy to remove the attribute - any problems with that?

ok I think that it is fine to remove the attribute.


Information missing from documentation page "AzureWebJobsStorage app setting is not present"

The documentation linked below has no information on getting the connection string from a storage account and the storage account UI is not easy to navigate or does not have a 'connection string' page.
This error should be 100% resolvable from the Azure portal UI (e.g. a drop down choosing from existing storage accounts or going to create a new one).
Please also include examples of valid connection strings (as these strings are different in every service and so it can be hard to know what to look for).

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: c98355ea-64d5-58d4-e91d-9df10cc3a6e9
Version Independent ID: cf6fd1b4-e6ca-f819-d6a4-966c160893d8
Content: AZFD0001: AzureWebJobsStorage app setting is not present. - Azure Functions
Content Source: articles/azure-functions/errors-diagnostics/diagnostic-events/azfd0001.md
Service: azure-functions
GitHub Login: @soninaren
Microsoft Alias: nasoni

@Cypher1
Thanks for your feedback! We will investigate and update as appropriate.


switchAll, mergeAll etc are not type safe

Bug Report
Current Behavior
const input: Observable<number> = of(1, 2, 3)
const output = input.pipe(switchAll())
output.subscribe(value => console.log(value))

No type error, but runtime error:
You provided '1' where a stream was expected. You can provide an Observable, Promise, Array, or Iterable.

Reproduction

REPL or Repo link: https://stackblitz.com/edit/typescript-zgtnbp

Expected behavior
This should give a type error like number is not assignable to ObservableInput<T>
Environment

RxJS version: 6.2.1

Possible Solution
I tried a few things, but it seems like type inference just fails here. TypeScript needs to infer a type based on the usage of the return value here.
Workaround
Use switchMap(x => x) instead (switchMap(identity) also breaks inference)

The problem seems to have been introduced in 6.2.1 with this commit - which uses the signature that I suggested.
Prior to that commit, the snippet would have effected this error:
[ts]
Argument of type 'OperatorFunction<ObservableInput<{}>, {}>' is not assignable to parameter of type 'OperatorFunction<number, {}>'.
  Type 'number' is not assignable to type 'ObservableInput<{}>'.

The commit fixed an error with the pipe signature, but it could be improved. A more refined rest-parameters signature for pipe would be:
pipe<R>(op1: OperatorFunction<T, any>, ...operations: OperatorFunction<any, any>[]): Observable<R>;

Such a signature would avoid an matching the first parameter with any, but, unfortunately, that's as far as this approach could be taken. It would not solve the problem if switchAll where, say, the second of two parameters. For that situation, a signature like this would be required:
pipe<A, R>(op1: OperatorFunction<T, A>, op2: OperatorFunction<A, any>, ...operations: OperatorFunction<any, any>[]): Observable<R>;

However, such a signature requires the inclusion of another type parameter. And given that the caller of such a rest-parameter signature will want to explicitly specify R, the signature isn't really usable.
I don't know if it's going to be possible to support a rest-parameters signature with which the caller can specify only the result type (R) and proper type safety for the parameters.

As an aside, this is something that would have been caught with an appropriate dtslint test - see #3823. Something like this would have caught it:
const input: Observable<number> = of(1, 2, 3);
const output = input.pipe(switchAll()); // $ExpectError

I don't like the idea of degrading type safety for common cases like this just to support more than n parameters to pipe(). FWIW, the TypeScript compiler cheats in many places itself, e.g. will only check circular types n levels deep (7 I think). I would rather have pipe() only take a maximum of n parameters (let's say 10) than have type safety silently degrade. A user can always call pipe() twice.
That said, would https://github.com/Microsoft/TypeScript/pull/24897 eliminate the need for all the overloads? We should definitely try that out

I've seen the TypeScript PR that you've referenced and looking more closely at it is on my TODO list. However, I suspect that it won't help in the pipe case because of the input-output relationship that exists between consecutive parameters. Hopefully, I'm wrong.

My preferred solution is to abandon the only-specifiy-R signature and add another signature that appends the rest parameter to a parameters-up-to-I signature.
That is, remove this:
pipe<R>(
  ...operations: OperatorFunction<any, any>[]
): Observable<R>;

And add this:
pipe<A, B, C, D, E, F, G, H, I, R>(
  op1: OperatorFunction<T, A>,
  op2: OperatorFunction<A, B>,
  op3: OperatorFunction<B, C>,
  op4: OperatorFunction<C, D>,
  op5: OperatorFunction<D, E>,
  op6: OperatorFunction<E, F>,
  op7: OperatorFunction<F, G>,
  op8: OperatorFunction<G, H>,
  op9: OperatorFunction<H, I>,
  ...operations: OperatorFunction<any, any>[]
): Observable<R>;

Instead of specifying a single R type parameter, callers would have to apply a type assertion, like this:
const result = of("T").pipe(
    mapTo("A"),
    mapTo("B"),
    mapTo("C"),
    mapTo("D"),
    mapTo("E"),
    mapTo("F"),
    mapTo("G"),
    mapTo("H"),
    mapTo("I"),
    mapTo("R")
) as Observable<"R">;

Overall, the typing around the pipe method has been perpetually problematic.
Perhaps we can get @ahejlsberg or @mhegazy's attention and this can be solved either by helping us get it right, or with some solution to the problem on the TypeScript side of things.


[Ajax / Server Error for action upgradeDb] textStatus: "error " errorThrown:"Internal Server Error " jqXHR: " "

Describe the bug
During DB update, after core files successful updated:
[Ajax / Server Error for action upgradeDb] textStatus: "error " errorThrown:"Internal Server Error " jqXHR: " "
Upgrade environment (please complete the following information):

Version you started from: <IP_ADDRESS>
Version you upgrade to: <IP_ADDRESS>
Way of upgrade: Web
Step concerned: upgrade DB

Displayed log
[error] 5183#0: *10971 FastCGI sent in stderr: "PHP message: PHP Warning:  count(): Parameter must be an array or an object that implements Countable in /var/www/prestashop/html/modules/autoupgrade/AdminSelfUpgrade.php on line 3665" while reading response header from upstream

[error] 5180#0: *11061 FastCGI sent in stderr: "PHP message: PHP Fatal error:  Uncaught Symfony\Component\Debug\Exception\FatalThrowableError: Call to a member function can() on null in /var/www/prestashop/html/src/Adapter/Module/AdminModuleDataProvider.php:172

Stack trace:
#0 /var/www/prestashop/html/src/Core/Addon/Module/ModuleManager.php(391): PrestaShop\PrestaShop\Adapter\Module\AdminModuleDataProvider->isAllowedAccess('enable', 'ps_mainmenu')
#1 /var/www/prestashop/html/src/Core/Addon/Theme/ThemeManager.php(302): PrestaShop\PrestaShop\Core\Addon\Module\ModuleManager->enable('ps_mainmenu')
#2 /var/www/prestashop/html/src/Core/Addon/Theme/ThemeManager.php(176): PrestaShop\PrestaShop\Core\Addon\Theme\ThemeManager->doEnableModules(Array)
#3 /var/www/prestashop/html/modules/autoupgrade/AdminSelfUpgrade.php(2688): PrestaShop\PrestaShop\Core\Addon\Theme\ThemeManager->enable('classic')
#4 /var/www/prestashop/html/modules/autoupgrade/AdminSelfUpgrade.php(1996): AdminSelfUpgrade->doUpgrade()
#5 /var/www/prestashop/html/admin" while reading response header from upstream, client: <IP_ADDRESS>, server: prestashop.dev, request: "POST /admin/autoupgrade/ajax-upgradetab.php HTTP/1.1", upstream: "fastcgi://unix:/var/php7-fpm/prestashop.sock:", host: "prestashop.dev", referrer: "http://prestashop.dev/admin/index.php?tab=AdminSelfUpgrade&token=026cc0b04393fd28021f93ef066b86b6"

Line 172 of AdminModuleDataProvider.php is:
return ($this->employee->can('edit', 'AdminModulessf') && $this->moduleProvider->can('configure', $name));

Seems to be $this->moduleProvider is null?
Expected behavior
DB update must be successful
Server (please complete the following information):

Web Server: Nginx 1.6.2
PHP Version: 7.2
Module Version 3.0.5

Everything works fine after upgrade the module to v4.0.0.

Hey, thanks for this awesome feedback.
I close the pull request if everything is ok with the latest version.
Don't hesitate to come back to us if you have a problem :)
Kind Regards

I recently upgraded from 1.7.2 to 1.7.5  and ran into this error.
Checked my server logs through cPanel and noticed a "SoftException in Application.cpp is writeable by group"
Basically autoupgrade was halting during the upgrade process and it was a result of bad permissions in the root autoupgrade module directory.
Solution was to change the permissions on auto-upgradetab.php to 644.
Hope someone finds that helpful.


Tokenizers need to be fixed for training set feature computation

Currently only using SingleSpaceTokenizer.

Fixed, thanks @pfliu-nlp


Remove spurious space before commas

👍

There's still a double space on the right of the comma

So there is, I hadn't noticed. Will see if I can fix that.

this fixes that: https://github.com/openregister/openregister-java/pull/114


require polyfills when needed

@jongold what do you think about that? It could be a great way to polyfill sketch on demand

@mathieudutour this seems like a better solution than BannerPlugin!
We need to fix https://github.com/sketch-pm/sketch-module-fetch-polyfill/commit/710613e6be31a0f5419ce068edc9cbc36487e4c2 first though - all of my projects are pinned to<EMAIL_ADDRESS>- should I create an issue? totally forgot about it :)

I fixed sketch-pm/sketch-module-fetch-polyfill@710613e on 0.1.4. Will send a PR to react-sketchapp


Add Windows Support using MSYS2 and MinGW gcc

Let me elaborate on this. Is it not right not to support Windows users, just as it is not right to exclude Mac OS X users from compiling mailibex. Some deployment environments mandate the use of Windows servers. The mix task script should adapt to each environment without prejudice.

Thank you again !


added todo flutter app by Mohammad Fayaz

I have added a sample todo app in flutter, please review this. Thank you!

@fayaz07 There are the following issues in your code.
display1' is deprecated and shouldn't be used. This is the term used in the 2014 version of material design. The modern term is headline4. This feature was deprecated after v1.13.8. - line 85
info
'display1' is deprecated and shouldn't be used. This is the term used in the 2014 version of material design. The modern term is headline4. This feature was deprecated after v1.13.8. - line 90
info
'title' is deprecated and shouldn't be used. This is the term used in the 2014 version of material design. The modern term is headline6. This feature was deprecated after v1.13.8. - line 116

Sorry for that I didn't check the warnings, I have updated the gist. Thank you

@divyanshub024 Thank you for accepting my PR


the rego filename should reflect the k8s version it is written for

The current deprek8.rego is written for 1.16, when a new Kubernetes version is released with breaking API changes my conftest run would apparently require a different policy file.
That's why I propose the rego filename should reflect the Kubernetes version it is written for.
So instead of running conftest test -p deprek8.rego ... one would run conftest test -p deprek8_1_16.rego ...
Seems more future proof to me.

As today it's the point.
Projects should (and don't always do) announce deprecations months in advance, the mission of deprek8 is to be always cutting edge to warn you "this think will break soon, you should upgrade now, the new API already works".

If I would git clone this rego in my deployment pipeline, my pipeline might break at any time because of a new release of a rego file (because of a new Kubernetes version). If you add individual regos for individual Kubernetes versions then it is my decision when my pipeline break.
Furthermore managed Kubernetes offerings usually have a significant delay in supporting the most recent versions of Kubernetes (e.g. vanilla Kubernetes is 1.16, current AWS EKS is 1.14), so probably I would want my deployment pipeline (or Helm chart release process) explicitely to tell what to verify for.
Maybe providing a latest rego policy if I want cutting edge?

I understand what you say but it's out of scope for now.
Conftest git support is on the way (https://github.com/instrumenta/conftest/pull/107), I guess you can pin an old commit in your CI.
If you don't (or can't) have a recent Kubernetes cluster version, there is less value to use deprek8, nothing should break if you don't upgrade.
Deprek8 can probably be useful in a non-blocking CI job, just to list work before next upgrades.


[Performance] Failed to fetch profiles

Current Behavior

To Reproduce

Go to Performance page
Click on nothing

Environment

Host OS: Linux
Platform: Kubernetes
Meshery Server Version: stable-v0.6.138

Contributor Guides and Handbook

🛠 Meshery Build & Release Strategy
📚 Instructions for contributing to documentation

Meshery documentation site and source

🎨 Wireframes and designs for Meshery UI in Figma (open invite)
🙋🏾🙋🏼 Questions: Discussion Forum and Community Slack

i would like to work on this

I would like to work on this


Update to refined 0.3.6

This version of refined was built with shapeless 2.3.0.

Great, thanks! Merging.

There's a small fix I'd like to push, then I'll cut an RC2 with that.


Add form step completed event

Add new event to payment-provisioning: form-step-completed
In our 5.x.x release, we plan to adjust the expected behavior and payload of our submitted event in the payment-provisioning component. We plan to update the behavior of submitted so that it is only emitted at the very end of the component form UI flow. This will bring its behavior in line with our other components that also emit a submitted event.
This change will be considered a breaking change, which is why we are waiting until our 5.x.x release to commit this change. In the mean time, this PR begins preparing for this change by adding a new event to the payment-provisioning component: form-step-completed
This new event will be emitted alongside submitted for now, until we alter the submitted event's behavior to only emit at the very end of the form flow.
The story documentation and example have been updated as well to reflect the new event. It is also captured on the storybook action panel to view in storybook when it is emitted.
Links

Developer considerations

On any task

[ ] Previous unit and e2e tests are passing
[ ] Perform dev QA on Chrome, Firefox, and Safari

On new features

[ ] Add unit tests
[ ] Add e2e tests
[ ] Add documentation
[ ] Does the component have exportedparts for styling? If so, add unit a unit test for each exportedpart

On bugs

[ ] Add unit tests to prevent the bug from happening again

Developer QA steps

[ ] Each step of the payment provisioning component should now emit form-step-completed event.

[ ] Event.detail.data contains the server response from the form step
[ ] Event.detail.formStep contains the name of the completed form step

[ ] New event documentation in storybook looks OK
[ ] Example usage in storybook docs looks OK

On Storybook actions addon, I can see the event being emitted in all steps, except from 6 to 7 and from 7 to 8.


How to load the original model LM head in the new version of Adapters?

Details
Hello!
We are working with LLaMA which is not supported in the old version of Adapter-Transformers. So we decided to use the beta (Adapters branch). The issue is, it's unclear how to load the llama language modeling head. By default, the model is loaded without any head, which is a problem. This kind of approach made a lot of sense in the BERT era, but it's unclear if it's an intuitive solution now when people want to fine-tune language models with their original head on.
Here's what we tried:
from adapters import LlamaAdapterModel
from transformers import AutoTokenizer

tokenizer = AutoTokenizer.from_pretrained("meta-llama/Llama-2-7b-hf")
model = LlamaAdapterModel.from_pretrained("meta-llama/Llama-2-7b-hf")

model.add_causal_lm_head("lm_head")
adapters.init(model)
out = model.generate(tokenizer("The cat is", return_tensors="pt")["input_ids"], max_length=20)
tokenizer.decode(out[0])
# output: '<s> The cat isРСРoulevalu str siècleTest materadejkradeavenradebosebose étudesvä'

so, it seems like this way the added head is randomly initialized.
Could you help us to get the original llama head weights?

Thank you, everything works now!


improve addMaterials to Ground.rad

addMaterial to Ground.rad function currently just adds new materials at the end, and does not double-check if material exists and if it needs to be overwritten, so it ends up being unclear which material if they are repeated names gets used.

fixed in development branch.


fixes the num_tokens_dropped deserialization

Fixes the serialization issue described in #251 where the value of the dropped tokens does not fit into the int32 type.

@georgemcz thanks, I'll merge it in and make a new release.


[AppInsightsService -> Router]: NullInjectorError: No provider for Router!  (Angular 6)

I am currently updating my insights service to angular 6 and after the update when i try to run ng serve i get the message
Error: StaticInjectorError(InsightsModule)[AppInsightsService -> Router]:
  StaticInjectorError(Platform: core)[AppInsightsService -> Router]:
    NullInjectorError: No provider for Router!
    at<EMAIL_ADDRESS>(core.js:979)
    at resolveToken (core.js:1232)
    at tryResolveToken (core.js:1182)
    at<EMAIL_ADDRESS>(core.js:1077)
    at resolveToken (core.js:1232)
    at tryResolveToken (core.js:1182)
    at<EMAIL_ADDRESS>(core.js:1077)
    at resolveNgModuleDep (core.js:9217)
    at _createClass (core.js:9264)
    at _createProviderInstance$1 (core.js:9234)

I'm not sure on what to do... everything was working fine with angular 5.2

Sorry for it taking a while to reply Mark..
i "fixed" this error msg using
RouterModule.forRoot([           { path: '', component: AppInsightsService },         ]),
in my insights.module.ts
yes i was using the latest version for angular 6

Here's my insights.module.ts
`import { NgModule } from '@angular/core';
import { RouterModule } from '@angular/router';
import { BrowserModule } from '@angular/platform-browser';
import { APP_BASE_HREF } from '@angular/common';
import { ApplicationInsightsModule, AppInsightsService } from '@markpieszak/ng-application-insights';
@NgModule({
imports: [
BrowserModule,
RouterModule.forRoot([
{ path: '', component: AppInsightsService },
]),
ApplicationInsightsModule.forRoot({
instrumentationKeySetlater: true
}),
],
providers: [
AppInsightsService,
{ provide: APP_BASE_HREF, useValue: window['_app_base'] || '/' }
],
declarations: []
})
export class InsightsModule {
}
`
HERES MY MAIN.TS
`import { enableProdMode } from '@angular/core';
import { platformBrowserDynamic } from '@angular/platform-browser-dynamic';
import { InsightsModule } from './app/insight.module';
import { environment } from './environments/environment';
if (environment.production) {
enableProdMode();
}
platformBrowserDynamic().bootstrapModule(InsightsModule)
.catch(err => console.log(err));
`

I am also having the original problem.
version:

markpieszak/ng-application-insights: 5.0.1
angular: 6.0.2
rxjs: 6.2.1

Error: StaticInjectorError(AppModule)[AppInsightsService -> Router]:
StaticInjectorError(Platform: core)[AppInsightsService -> Router]:
NullInjectorError: No provider for Router!
at<EMAIL_ADDRESS>(core.js:951)
at resolveToken (core.js:1195)
at tryResolveToken (core.js:1140)
at<EMAIL_ADDRESS>(core.js:1035)
at resolveToken (core.js:1195)
at tryResolveToken (core.js:1140)
at<EMAIL_ADDRESS>(core.js:1035)
at resolveNgModuleDep (core.js:8071)
at _createClass (core.js:8118)
at _createProviderInstance$1 (core.js:8088)

@jondmcelroy  i fixed that msg with
RouterModule.forRoot([ { path: '', component: AppInsightsService }, ]),
on my app.module

Glad you figured it out! :+1:
Are we all set to close this one out?

I'm getting a similar issue. I don't think just adding RouterModule.forRoot([ { path: '', component: AppInsightsService }, ]) is the solution.
I'm not sure if anyone else has a similar issue but it should just work via your documentation.
I'm using...

Angular: 6.0.3
rxjs: 6.2.2
angular-application-insights: 5.0.2

Could be an issue with how Angular 6 tree shakes services now. I'll do some investigation and report back if I fins anything.

Any update on this? I am having the similar issue after updating to Angular 6
Error: No provider for Router! (AuthService -> Router)
    at injectionError (core.js:1781)
    at noProviderError (core.js:1811)
    at<EMAIL_ADDRESS>(core.js:2558)
    at<EMAIL_ADDRESS>(core.js:2586)
    at<EMAIL_ADDRESS>(core.js:2538)
    at<EMAIL_ADDRESS>(core.js:2528)
    at core.js:2510
    at Array.map (<anonymous>)
    at<EMAIL_ADDRESS>(core.js:2510)
    at<EMAIL_ADDRESS>(core.js:2501)

I needed to implement something really quick for work so I ended up just using the application insights-js package and my own implementation.

On Aug 16, 2018, at 9:45 AM, katyasafford<EMAIL_ADDRESS>wrote:
Any update on this? I am having the similar issue after updating to Angular 6
Error: No provider for Router! (AuthService -> Router)
at injectionError (core.js:1781)
at noProviderError (core.js:1811)
at<EMAIL_ADDRESS>(core.js:2558)
at<EMAIL_ADDRESS>(core.js:2586)
at<EMAIL_ADDRESS>(core.js:2538)
at<EMAIL_ADDRESS>(core.js:2528)
at core.js:2510
at Array.map ()
at<EMAIL_ADDRESS>(core.js:2510)
at<EMAIL_ADDRESS>(core.js:2501)
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub https://github.com/MarkPieszak/angular-application-insights/issues/46#issuecomment-413550685, or mute the thread https://github.com/notifications/unsubscribe-auth/ABmsV1ImaN6RPbU-4O7n2Vx5LoYMrnzlks5uRXd_gaJpZM4USLdG.

Hi,
We use UIRouterModule and not the RouterModule in our angular application so we get the same issue.
Did the PR go through that would support using injector to get the router instead and how could we make it work with the UiRouterModule.
Thanks,
Taavi


Add generation of model/emoji_data.go to make-emojis script

Summary
This PR includes the generation of the emoji_data.go file into the utils\server folder and it also adds the possibility to override the current file in the server folder.
Ticket Link

Fixes https://github.com/mattermost/mattermost-server/issues/8566
Related Pull Requests

None

@hmhealey changes made :)

Seems like the build-docker is stuck in blocked state :\

I tried to restart the build where it got stuck, but if that doesn't work, it might help to merge in the latest master branch. We've had some infrastructure changes lately, so this branch might be caught in the middle of them

@hmhealey now seems to be working hehehe

Thanks again for the change, @ethervoid! Just waiting for this to rebuild, and then we should be good to merge it


error in case

@kof
const sheet = jss.createStyleSheet({}, options)
sheet.addRule('test', {color: red})
sheet.attach()  // componentWillMount
sheet.detach() // conmonentWillUnmount

sheet.addRule('test2', {color: blue})

file: StyleSheet.js
  addRule(name, style) {
    const rule = this.createRule(name, style)
    // Don't insert rule directly if there is no stringified version yet.
    // It will be inserted all together when .attach is called.
    if (this.deployed) {
      const renderable = this.renderer.insertRule(rule)
      if (this.options.link) rule.renderable = renderable
    }
    return rule
  }

after sheet.detach() we delete style tag in DOM tree, but not change this.deployed, it equal true
and when you try to add a new style we get error
  insertRule(rule) {
    // IE8 has only `styleSheet` and `styleSheet.rules`
    const sheet = this.element.sheet || this.element.styleSheet
    const cssRules = sheet.cssRules || sheet.rules  // cssRules not defined
    const nextIndex = cssRules.length
    if (sheet.insertRule) sheet.insertRule(rule.toString(), nextIndex)
    else sheet.addRule(rule.selector, rule.toString({selector: false}), nextIndex)
    return cssRules[nextIndex]
  }

fixed and released


pin to cmake <3.25 on CI to avoid bug with CUDA+conda during build

CMake 3.25 was released today and seems to have broken the CI builds. Trying to pin the version here to see if it resolves the issue.
attn: @jakirkham

cc @robertmaynard (for awareness)

Thanks @ajschmidt8, I applied the suggestions and it should be ready to merge now

@gpucibot merge

Thank you both! 🙏


Preprocessor: Overly aggressive macro expansion?

Example derived from https://github.com/Hirrolot/metalang99 which is a good source of preprocessor edge cases and stress tests.
#define REC_EMPTY
#define REC_DEFER(op) op REC_EMPTY

#define REC_0_HOOK() REC_0
#define REC_1 REC_DEFER(REC_0_HOOK)()

REC_1

With gcc and clang -E option, this expands to: REC_0_HOOK ()
With aro, it currently expands to: REC_0

<IP_ADDRESS> Rescanning and further replacement
After all parameters in the replacement list have been substituted and # and ## processing has
taken place, all placemarker preprocessing tokens are removed. The resulting preprocessing token
sequence is then rescanned, along with all subsequent preprocessing tokens of the source file, for
more macro names to replace.
If the name of the macro being replaced is found during this scan of the replacement list (not
including the rest of the source file’s preprocessing tokens), it is not replaced. Furthermore, if any
nested replacements encounter the name of the macro being replaced, it is not replaced. These
nonreplaced macro name preprocessing tokens are no longer available for further replacement even
if they are later (re)examined in contexts in which that macro name preprocessing token would
otherwise have been replaced.

Pasting the relevant piece of the standard here for future reference. Going from this description to the actual algorithm is very tricky, a lot is implict (in my opinion, it's borderline underspecified).
In thi case, this is how i would imagine the expansion sequence to be like:
^|REC_1$
^REC_1|$
^|REC_DEFER(REC_0_HOOK)()$
^REC_DEFER|(REC_0_HOOK)()$
^|REC_0_HOOK REC_EMPTY()$
^REC_0_HOOK| REC_EMPTY()$
REC_0_HOOK^ REC_EMPTY|()$
REC_0_HOOK^|()$
REC_0_HOOK^()|$
REC_0_HOOK()^|$

legend:

^ is start_idx+advance_idx
$ is moving_end_idx
| is idx
where I'm referring to the variables used in the expansion and scanning phase in Preprocessor.zig
So, initially my code didn't have the advance_idx concept. The sequence was always rescanned beginning from the first expansion point.
The standard is not very clear about this point, but inferring from gcc and clang, I decided to advance the start_idx when all the tokens to its left are expanded and there's no opportunity of further expanding them in the current context.
The relevant logic is:
https://github.com/Vexu/arocc/blob/76a1066249a150327d1331215d01ca3ec4dd1ca2/src/Preprocessor.zig#L953-L955
And this is correct.
Unfortunately, when the preprocessor finds REC_0_HOOK, it sees that is could be a macro call, but in the end it turns out it isn't because there are no () after it, so this is the codepath taken:
https://github.com/Vexu/arocc/blob/76a1066249a150327d1331215d01ca3ec4dd1ca2/src/Preprocessor.zig#L876-L878
The continue prevents the logic that increases advance_idx to be run.

I'm pretty busy with uni atm, if anybody else wants to pick up the fix from here feel free to do so.


Android - Does not encode a valid TensorFlow Lite model.

Previously I was using TensorFlowInferenceInterface to read the model. but I was facing a lot of crashes. As per one of the moderator's recommendation, i replaced the method with the following:
Code:
 private var sTFInterface: Interpreter? = null
 private const val MODEL_FILE = "file:///android_asset/auto.pb"

sTFInterface = Interpreter(File(MODEL_FILE))

But now i see a very strange error and it is unable to read tensorflowlite model. Still "abort" crashes are on spike.
Error:

java.lang.IllegalArgumentException: Contents of /file:/android_asset/auto.pb does not encode a valid TensorFlow Lite model: Could not open '/file:/android_asset/auto.pb'.
The model allocation is null/empty

Please help
Attached model:
auto.pb.zip

Hi @ahmadbajwa8282 ! You should use the below command to convert frozen graph files to tflite .
 converter = tf.compat.v1.lite.TFLiteConverter.from_frozen_graph(
  graph_def_file, input_arrays, output_arrays)
tflite_model = converter.convert()

But I recommend creating the model in V2 api's and load TF 2.x Lite converter to load the model and convert it smoothly.
Attaching TF 1.x Lite converter , 2.x Lite converter guide  for reference.
Thanks!


updated with screenshot including access selection, platform selectio…

updated with screenshot including access selection, platform selection and network settings

https://github.com/Kevinwochan/12-factor-java-workshop/blob/update-environment-settings-screenshot/images/img03.png


Clean up feature flags for macros.

Enable expression macros by default, and add separate feature flags for attached and freestanding macros.

@swift-ci please smoke test

Linux failure is an unrelated DocC issue

https://github.com/apple/swift-docc-symbolkit/pull/55
@swift-ci please smoke test  Linux

@swift-ci please smoke test Linux


Core Balancing Algorithm Enhancements

ModelBalancer balances by recursively forking (up to cluster_concurrent_rebalance times) the cluster one move operation at a time, returning the first goal cluster whose balance is better than the starting cluster with cluster_concurrent_rebalance moves, or less if it worked itself into a state where no further moves were possible.
An improved algorithm would

Only evaluate the balance after cluster_concurrent_rebalance moves have been performed.
Repeat this simulation process some configured number of times, returning the best of all simulated goal clusters, which are all better balanced than the current cluster. This simulation will take longer, but should drastically reduce the number of extraneous/unnecessary moves and thus reduce the time it takes for the cluster to stabilize.
Trim move operations from the goal cluster that do not improve balance.

Tempest 2.x has a whole new modeling and evaluation system.


CC179791: Replacing HTML code by | inside codeblock

Github contributor reported visible HTML code inside codeblock.

Hi @KathleenDollard, @mairaw , can you please help us by approving and merging this PR?
Regards

Thanks @v-maudel.  This is not the right fix and it's duplicate of #16526.

Thanks @mairaw , actually, now I see that PR, it was created byt the same contributor that submitt the changes in a locale repo.
Although, I proposed the change from HTML code to | only because it is inside codeblock and it shouldn't be escaped.


Fix apack manifest 7.15.0

(not sure why it wasn't changed with #957)

I think the issue is that abapGit doesn't actualize the version when the APACK class is already in memory. Thus need to restart abapGit to consider any change in the APACK class. Worth adding an issue in abapGit (possible solution to use RFC to be sure the version of latest APACK class is used). Meanwhile I have updated the checklist in #966.


Set up experiments for single and multi-document evaluation

This sets up a baseline "experiments" folder containing variants of the latest evaluator notebook using the 11 policy center questions. One notebook evaluates against single file ingestion, while the other evaluates against multiple files. Both share the following:

Output schema
Evaluation schema
Ground truth
System prompt

Eval data is returned to the same folder containing the above, while output results are returned to nested experiment-specific folders within "experiments/outputs". Each experiment is re-run 3 times and a mean and standard deviation of these runs is returned in the final cell.
TODO
We want to refactor this so that one evaluator notebook could be used across multiple experiments (parameterizing the different file paths to the input documents we want to use for each experiment).

Please disregard, as this was intended as a PR on my forked repo.


Added Holy Grail Quest

Ran through quest on 2 separate accounts, worked on both.

I'm pretty sure that I am using the RuneLite formatting tools. Both the code style setting in IntelliJ and the CheckStyle plugin say that I have everything formatted properly. But it is also the first time for me using both of these things, so it is very possible that I messed something up somewhere and it's giving me a false positive result.

I updated the quest to implement the comments that you left. Sorry if I'm spamming you with notif's from GitHub, I'm not really sure if I'm supposed to leave a comment when I update my branch or just kinda update it and wait for you to see it.


chore: bump go 1.21.9

Description
A detailed explanation of the changes in your PR.
Feel free to remove this section if it is overkill for your PR, and the title of your PR is sufficiently descriptive.
Checklist

[ ] Investigated and inspected CI test results
[ ] Unit test and regression tests added
[ ] Evaluated and added CHANGELOG entry if required
[ ] Determined and documented upgrade steps
[ ] Documented user facing changes (create PR based on openshift/openshift-docs and merge into rhacs-docs)

If any of these don't apply, please comment below.
Testing Performed
Here I tell how I validated my change
TODO(replace-me)
Use this space to explain how you validated that your change functions exactly how you expect it.
Feel free to attach JSON snippets, curl commands, screenshots, etc. Apply a simple benchmark: would the information you
provided convince any reviewer or any external reader that you did enough to validate your change.
It is acceptable to assume trust and keep this section light, e.g. as a bullet-point list.
It is acceptable to skip testing in cases when CI is sufficient, or it's a markdown or code comment change only.
It is also acceptable to skip testing for changes that are too taxing to test before merging. In such case you are
responsible for the change after it gets merged which includes reverting, fixing, etc. Make sure you validate the change
ASAP after it gets merged or explain in PR when the validation will be performed.
Explain here why you skipped testing in case you did so.
Have you created automated tests for your change? Explain here which validation activities you did manually and why so.
Reminder for reviewers
In addition to reviewing code here, reviewers must also review testing and request further testing in case the
performed one does not seem sufficient. As a reviewer, you must not approve the change until you understand the
performed testing and you are satisfied with it.

We need the go.mod change with the toolchain here as well

...and maybe go mod tidy run with 1.21.9.
Possibly some other changes to the libs will be necessary (e.g. slices vs sliceutils).

/go/src/github.com/stackrox/stackrox/go.mod:5: unknown directive: toolchain

something is wrong here with the go version. Are you sure OSCI is running 1.21?

I will run GOTOOLCHAIN=go1.21.9 make proto-generated-srcs && make go-generated-srcs committing it asap

Possibly some other changes to the libs will be necessary (e.g. slices vs sliceutils).

I looked at https://github.com/stackrox/stackrox/pull/10305 to determine the required changes, added all the go mod tidy updates and the CGOCHECKS changes.

something is wrong here with the go version. Are you sure OSCI is running 1.21?

It's not running 1.21 yet, because the image mirroring is still not approved.

I will run GOTOOLCHAIN=go1.21.9 make proto-generated-srcs && make go-generated-srcs committing it asap

That is a no-op, I ran it and no changes were required.
On the other hand, I applied https://github.com/stackrox/stackrox/pull/10375 to this branch.

You are much quicker than me @tommartensen 😄 Let's see if CI is happy now

/retest

@vikin91 these failures are because we still haven't merged the OSCI changes :(
https://github.com/openshift/release/pull/51515 is still unmerged / unapproved by DPTP.

@vikin91 these failures are because we still haven't merged the OSCI changes :(
openshift/release#51515 is still unmerged / unapproved by DPTP.

I saw some other PR merged and got confused. You are right, this one is still open. What can we do to push things a bit?

I saw some other PR merged and got confused. You are right, this one is still open. What can we do to push things a bit?

We have already pinged the helpdesk again last night, but it looks like the responsible engineer is OOO: https://redhat-internal.slack.com/archives/CBN38N3MW/p1714684748680149?thread_ts=1714635969.631919&cid=CBN38N3MW.

/retest


group_concat with ORDER BY

Hey there! :wave:
I am trying to turn my raw SQL into kysely calls. However, I am having a hard time putting an ORDER BY into a group_concat clause.
This is the result I am looking for:
SELECT
  group_concat (
    DISTINCT CASE
      WHEN foo = "1" THEN bar
      ELSE NULL
    END
    ORDER BY
      bar
  ) AS "barsWhereFooIsOne"
FROM
  "Foo"

This is what I got so far:
kysely
  .selectFrom("Foo")
  .select((eb) =>
    eb.fn
      .agg("group_concat",
        [
          eb.case()
            .when("bar", "=", "1")
            .then("bar")
            .else(null)
            .end()
        ]
      )
      .distinct()
      .as("barsWhereFooIsOne")
  )
  .execute()

It's only missing the ORDER BY. However, I can't find where to put .orderBy("bar"). No matter where I put it, I get an error:

Property 'orderBy' does not exist on type

Here's the playground link.
I'd appreciate any help. Thank you. :pray:

Hey 👋
There is no built-in support for order by outside of over clause in an aggregate function's arguments.
Try the following:
kysely
  .selectFrom("Foo")
  .select((eb) =>
    eb.fn
      .agg("group_concat", [
        sql`${eb
          .case()
          .when("bar", "=", "1")
          .then("bar")
          .else(null)
          .end()} order by ${eb.ref("bar")}`,
      ])
      .distinct()
      .as("barsWhereFooIsOne"),
  )
  .execute()

https://kyse.link/?p=s&i=epxzshFodVoa44dfhc18

Works perfectly, thank you. :pray:
For anyone doing something similar, you can add the types like .agg<string | null>('group_concat',


⚠ SceneTime has degraded performance

In e59eed9, SceneTime ($ST) experienced degraded performance:

HTTP code: 200
Response time: 1175 ms

Resolved: SceneTime performance has improved in 669f64c after 11 minutes.


feat(elements|ino-snackbar): add color scheme property

✨ Features:

Added a new inoColorScheme property to the ino-snackbar component

Closes #115

The new color schemes do not seem to match the designer's specifications. In the specification, it's only the border color that changes with each scheme.

The new color schemes do not seem to match the designer's specifications. In the specification, it's only the border color that changes with each scheme.

whoops I overlooked the specifications - I'll fix it


[Embeddingapi] Correct subcase number in v7.XWalkSettingTest

There should be 11 subcases in v7.XWalkSettingTest(7 new tests
added by commit fb02b606f52c242ea9a9c202205734935d5801b4)
https://crosswalk-project.org/jira/browse/CTS-1819

LGTM


Generating bindings with TypeScript-DOM-lib-generator

It might be possible to generate some bindings via microsoft/TypeScript-DOM-lib-generator.
In my fork, I've started exploring how we can generate ReScript instead of TypeScript.
It's still early to report any substantial progress, but here’s what I have so far:
// do ReScript stuff here
type event = {
    type: string,
    target: string,
    srcElement: string,
    currentTarget: string,
    eventPhase: string,
    cancelBubble: string,
    bubbles: string,
    cancelable: string,
    returnValue: string,
    defaultPrevented: string,
    composed: string,
    isTrusted: string,
    timeStamp: string,
}
type uIEvent = {
    view: string,
    detail: string,
    which: string,
    ...event,
}
type mouseEvent = {
    screenX: string,
    screenY: string,
    clientX: string,
    clientY: string,
    layerX: string,
    layerY: string,
    ctrlKey: string,
    shiftKey: string,
    altKey: string,
    metaKey: string,
    button: string,
    buttons: string,
    relatedTarget: string,
    movementX: string,
    movementY: string,
    pageX: string,
    pageY: string,
    x: string,
    y: string,
    offsetX: string,
    offsetY: string,
    ...uIEvent,
}

I’d like to use this issue to discuss the generation work.
One thought I have is that the generated content will most likely need manual updates afterward. There has been an idea to use the APIs listed at https://developer.mozilla.org/en-US/docs/Web/API. However, right now, the generator consolidates everything into a single file. It may be beneficial to manually split things up after the generation process is complete.

Great stuff!
It's likely that some of the definitions will have to live in the same file because of recursiveness. In that case though, the main definition can live in a general file (imagine type htmlElement = {...}), but we can still have a file for HtmlElement.res:
type t = Webapi.htmlElement

Worth thinking about.


Add contracts for codegen and move method BindService into ServiceBinder

What version of gRPC and what language are you using?
Proto-3, .net core
What operating system (Linux, Windows, …) and version?
n/m
What runtime / compiler are you using (e.g. python version or version of gcc)
n/m
What did you do?
Hello guys, i tried to create some simple extension for .net developers which should help combine asp.net framework code base with grpc libraries.
For now i have simple project:
https://github.com/m-andrei/grpc-example-for-.net-core
Which show my purposes, everything perfect except one thing: i can't move it into separate library due to grpc server codegen don't have interface contracts and method BindService stricly tied on codegen implementation.
I offer to add simple interface for Server and move "BindService" method into separate class like:
`
public interface IGrpcService {}
public interface IGrpcServiceBinder
{
    ServerServiceDefinition BindService(IGrpcService serviceImpl);
}

//CodeGen then will be like:
namespace Grpc.Example
{
    /// <summary>Base class for server-side implementations of Greeter</summary>
    public abstract partial class GreeterBase : IGrpcService
    {
        public virtual Task<HelloReply> SayHello(HelloRequest request, ServerCallContext context)
        {
            throw new RpcException(new Status(StatusCode.Unimplemented, ""));
        }
    }

    //and:

    public class GreeterBaseBinder : IGrpcServiceBinder
    {
        public ServerServiceDefinition BindService(IGrpcService serviceImpl)
        {
            GreeterBase service = (GreeterBase) serviceImpl;
            return ServerServiceDefinition.CreateBuilder()
                .AddMethod(__Method_SayHello, service.SayHello).Build();
        }
    }
}

`
Both IGrpcService IGrpcServiceBinder should be in Grpc.Core library.
This will allow everyone to create they own nuget packages and share it.
I believe almost everyone faced with that issue when tried to share they code with other teams in company.

We now have these:
https://github.com/grpc/grpc/blob/master/src/csharp/Grpc.Core.Api/ServiceBinderBase.cs
and
https://github.com/grpc/grpc/pull/17778
which together seems to address the issue you're having.
also,  https://github.com/grpc/grpc-dotnet is something you might be interested in.


Document compatibility guarantees

Fixes #275

As discussed with @nvoxland, this better belongs to the extension guides of https://github.com/liquibase/liquibase-dev-docs.


Code workflow

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: arddluma sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


Anything going on under the hoods?

I'm not using EF Core yet, because it's missing 2 core features I can't pass: Complex Types, and TPT.
But I'm just curious this repo is 2 years old, is anything going on with it?

I would like to do a version of TE that targets EF Core 2.0.  That has a fix to the TrackGraph method that provides a reference to the entity as the graph is traversed.

Was that issue addressed by the EF team?
Anyway I believe it'll take a while until I'll start adopting EF Core, but it's always good to keep track.

Yes it was addressed and will be in 2.0 (it may be there already in Preview 2).


Unverified release?!

Hello,
I wonder, if it is safe to download the latest version. I noticed a warning message on the releases page for the last few releases (the earlier / initial releases were okay). Please see the screenshot below to understand what I am talking about...

Thank you.

Thanks for clarifying.


chore: adding typediff crate

fixes #45

Looks good, could you rebase this? Or if you'd like I can rebase it

I think I just rebased it ?

Yep, will merge once CI runs and passes! Thanks


{{ foo[0].bar() }} is a parse error

Via this SO question – looks like you can't call methods of references with computed properties:
// these both fail
Ractive.parse( '{{foo[0].bar()}}' );
Ractive.parse( '{{foo[0].bar.baz()}}' );

Demo: http://jsfiddle.net/shLgn4cv/

Only happens with numbers, these work:
Ractive.parse( '{{foo["0"].bar()}}' );
Ractive.parse( '{{foo[bar + 1].bar.baz()}}' );

http://jsfiddle.net/shLgn4cv/1/


Title change: Custom Hooks => Building Your Own Hooks

See
https://mobile.twitter.com/JoshWComeau/status/1058300101456773121
https://mobile.twitter.com/siddharthkp/status/1058322582024314880
@sophiebits's idea is to deemphasize "custom Hooks" as a name in the navigation.
(But keep calling them custom Hooks on the page.)

@gaearon @sophiebits Good change. But I think we should not use custom hooks at all and just say hooks.
We never say write a custom functions in javascript. We just write a function. The custom doesn't add any value. Hook is just an another abstraction. React provides a a few hooks. Just call them built-in hooks.
Just use the terminology, built-in hooks and hooks similar to built-in functions and functions.
I can do a PR if you are okay with the idea.


Celeryconfig.py is missing

Hi,
I'm trying to install via the vagrant script. Up to here, there was only missing module ( gunicorn, south, celery, django-nose, pycurl and decorator). But now I'm stuck with a missing configuration file: celeryconfig.py
The error:
: not found[1;35merr: /Stage[main]//Exec[Syncdb]/returns: change from notrun to 0 failed: sh:
/var/praekelt/vumi/ve/lib/python2.6/site-packages/celery-2.3.3-py2.6.egg/celery/loaders/default.py:33: NotConfigured: No 'celeryconfig' module found! Pleas
e make sure it exists and is available to Python.
"is available to Python." % (configname, )))
Thank you
Oliv

Celery was just there for Django - should be gone now.

Celery is still listed in requirements-webapp.pip. We can close this ticket as soon as that's gone.

requirements-webapp.pip is gone. :)


Fix order of calls

Switch order of calls to allow users to change the response object in the after callback.
Check #24

@aarora91 you're right. Added a commit


Updated demo.

Hosted demo images in quay.io.
Added dockerfiles for the demo images.
Updated readme appropriately.

I've tested it manually.


Remove using from headers

Take under control namespace diffusion from headers

@dmitry-gurulev agree, it introduced huge delta

Please rebase


KeyError: 'TriggerMessage'

I am trying to send some requests like BootNotification, Authorization, StatusNotification, StartTransaction, Meter Values and StopTransaction. All are working fine, I am getting the response from CSMS but i am getting some exceptions which are mentioned below:
ERROR:ocpp:Error while handling request '<Call - unique_id=153291687523070501:TM, action=TriggerMessage, payload={'requestedMessage': 'StatusNotification', 'connectorId': 1}>'
Traceback (most recent call last):
  File "/home/lenovo/.local/lib/python3.8/site-packages/ocpp/charge_point.py", line 174, in _handle_call
    handlers = self.route_map[msg.action]
KeyError: 'TriggerMessage'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/home/lenovo/.local/lib/python3.8/site-packages/ocpp/charge_point.py", line 153, in route_message
    await self._handle_call(msg)
  File "/home/lenovo/.local/lib/python3.8/site-packages/ocpp/charge_point.py", line 176, in _handle_call
    raise NotSupportedError(
ocpp.exceptions.NotSupportedError: NotSupportedError: Request Action is recognized but not supported by the receiver, {'cause': 'No handler for TriggerMessage registered.'}
INFO:ocpp:CP_1: send [4,"153291687523070501:TM","NotSupported","Request Action is recognized but not supported by the receiver",{"cause":"No handler for TriggerMessage registered."}]
INFO:ocpp:CP_1: receive message [2,"153291687523070501:TM","TriggerMessage",{"requestedMessage":"StatusNotification","connectorId":2}]
ERROR:ocpp:Error while handling request '<Call - unique_id=153291687523070501:TM, action=TriggerMessage, payload={'requestedMessage': 'StatusNotification', 'connectorId': 2}>'
Traceback (most recent call last):
  File "/home/lenovo/.local/lib/python3.8/site-packages/ocpp/charge_point.py", line 174, in _handle_call
    handlers = self.route_map[msg.action]
KeyError: 'TriggerMessage'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/home/lenovo/.local/lib/python3.8/site-packages/ocpp/charge_point.py", line 153, in route_message
    await self._handle_call(msg)
  File "/home/lenovo/.local/lib/python3.8/site-packages/ocpp/charge_point.py", line 176, in _handle_call
    raise NotSupportedError(
ocpp.exceptions.NotSupportedError: NotSupportedError: Request Action is recognized but not supported by the receiver, {'cause': 'No handler for TriggerMessage registered.'}
INFO:ocpp:CP_1: send [4,"153291687523070501:TM","NotSupported","Request Action is recognized but not supported by the receiver",{"cause":"No handler for TriggerMessage registered."}]
INFO:ocpp:CP_1: receive message [2,"153291687523070501:TM","TriggerMessage",{"requestedMessage":"StatusNotification","connectorId":3}]
ERROR:ocpp:Error while handling request '<Call - unique_id=153291687523070501:TM, action=TriggerMessage, payload={'requestedMessage': 'StatusNotification', 'connectorId': 3}>'
Traceback (most recent call last):
  File "/home/lenovo/.local/lib/python3.8/site-packages/ocpp/charge_point.py", line 174, in _handle_call
    handlers = self.route_map[msg.action]
KeyError: 'TriggerMessage'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/home/lenovo/.local/lib/python3.8/site-packages/ocpp/charge_point.py", line 153, in route_message
    await self._handle_call(msg)
  File "/home/lenovo/.local/lib/python3.8/site-packages/ocpp/charge_point.py", line 176, in _handle_call
    raise NotSupportedError(
ocpp.exceptions.NotSupportedError: NotSupportedError: Request Action is recognized but not supported by the receiver, {'cause': 'No handler for TriggerMessage registered.'}

If anyone knows how to handle or solve this error, please reply. Thankyou.

The CSMS seems to send a TriggerMessage request to your charger. And the charger doesn't seem to implement a handler for that.

The CSMS seems to send a TriggerMessage request to your charger. And the charger doesn't seem to implement a handler for that.

Thanks for helping, after implemeting TriggerMessage handler the problem is solved.


Fix SVG minification

SVG minification in the next branch is currently broken. I have seen a few issues, one of which seemed to remove actual items from the compressed code. This, of course, affects the new SVG icon sprite-sheet workflow. SVGO is probably to blame for this and I will investigate the various SVGO options to see if one of them is causing the error. It could also be due to strangely formatted SVG code itself.. watch this space 👀

Do you have mode details on this issue and how could I reproduce it?
Maybe you can share files which caused the issue and I could try to have a look.

@rentorm I experienced a few issues where some svg paths or even groups were being removed. I have not been able to find the issue. I should find the offending SVG, the TMW logo, and add to the ticket..

Turned out to be a malformed SVG source file..


fix: Add role assumption configs as inputs with sensible defaults, ad…

…d example to readme.

:tada: This PR is included in version 1.0.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


How to convert from converted isotropic to original resolution (anisotropic)

Hello, thanks for your code for converting from anisotropic to isotropic resolution. It really helps for some kind of dataset such as MRBrainS13 (resolution 0.958mm x 0.958mm x 3.0). I was used your code to convert it to 1mmx1mmx1mm
data, affine = reslice(data, affine, zoom, (1., 1., 1.), order)

After reslice both raw and ground-truth image, we will work in isotropic resolution. For validation, the result file should have the thick slice resolution (voxel size: 0.958mm x 0.958mm x 3.0mm), since the ground truth is only available for the thick slice data. How could we convert the isotropic resolution of segmentation result to anisotropic resolution to perform the evaluation? And what value of order often use? Thanks

The code Ryo provided will preprocess both the training dataset and testing dataset, i.e. the ground truth of the test dataset will also be in isotropic resolution

Hi. but we must convert back to anisotropic for evaluation. Did you solve it?