All entities, including switches for whitelisting games, are unavailable

System Health details
System Information

version
core-2023.12.4

installation_type
Home Assistant OS

dev
false

hassio
true

docker
true

user
root

virtualenv
false

python_version
3.11.6

os_name
Linux

os_version
6.1.58-haos-raspi

arch
aarch64

timezone
America/New_York

config_dir
/config

Home Assistant Community Store

GitHub API
ok

GitHub Content
ok

GitHub Web
ok

GitHub API Calls Remaining
5000

Installed Version
1.33.0

Stage
running

Available Repositories
1363

Downloaded Repositories
8

Home Assistant Cloud

logged_in
false

can_reach_cert_server
ok

can_reach_cloud_auth
ok

can_reach_cloud
ok

Home Assistant Supervisor

host_os
Home Assistant OS 11.2

update_channel
stable

supervisor_version
supervisor-2023.12.0

agent_version
1.6.0

docker_version
24.0.7

disk_total
28.5 GB

disk_used
7.8 GB

healthy
true

supported
true

board
rpi4-64

supervisor_api
ok

version_api
ok

installed_addons
Terminal & SSH (9.8.1), File editor (5.7.0), Matter Server (5.0.1), Samba share (12.2.0)

Dashboards

dashboards
1

resources
2

views
8

mode
storage

Recorder

oldest_recorder_run
December 21, 2023 at 12:09 AM

current_recorder_run
December 29, 2023 at 8:22 PM

estimated_db_size
86.48 MiB

database_engine
sqlite

database_version
3.41.2

Checklist

[X] I have enabled debug logging for my installation.
[X] I have filled out the issue template to the best of my ability.
[X] This issue only contains 1 issue (if you have multiple issues, open one issue for each issue).
[X] This issue is not a duplicate issue of currently previous issues..

Nintendo Parental Controls mobile app

[X] I have checked the configuration of the mobile app and the switch device is registered.
[X] I experience this issue if I test again with the tested configuration in the readme.
[ ] This issue does not happen when tested with the tested configuration in the readme.

Describe the issue
I was following along with the issue you were working on the last couple days regarding no entities being displayed.  I have entities after one of the previous beta updates, but they all show as unavailable, even with 2023.12.3.  No sensor data.  I even configured the switches to whitelist games, and they are also unavailable.  8 entities in all.  The Nintendo Switch is properly configured in the Parental Controls app.
Immediately following the debug logs I included for you below, there is a big chunk of code that appears to be the full proper data that this integration is requesting being pulled from the Nintendo servers.  Didn't want to give too much away to the internet-at-large here, but can definitely get you more info if needed.  Nothing else for this integration seems to fail.

Reproduction steps

Follow the steps to setup the integration
Configure games to whitelist
All entities unavailable
Deleted, rebooted, and reinstalled with each beta update
...

Debug logs
2023-12-29 20:23:15.580 DEBUG (MainThread) [pynintendoparental] Request to https://api-lp1.pctl.srv.nintendo.net/moon/v1/devices/[IDCODE]/monthly_summaries status code 200
2023-12-29 20:23:15.593 ERROR (MainThread) [custom_components.nintendo_parental] Error fetching nintendo_parental data: list index out of range
2023-12-29 20:23:15.593 DEBUG (MainThread) [custom_components.nintendo_parental] Finished fetching nintendo_parental data in 5.219 seconds (success: False)
2023-12-29 20:23:15.619 DEBUG (MainThread) [pynintendoparental] Request to https://api-lp1.pctl.srv.nintendo.net/moon/v1/devices/[IDCODE]/parental_control_setting status code 200
2023-12-29 20:23:15.620 INFO (SyncWorker_7) [homeassistant.loader] Loaded time from homeassistant.components.time
2023-12-29 20:23:15.623 DEBUG (MainThread) [pynintendoparental] Request to https://api-lp1.pctl.srv.nintendo.net/moon/v1/devices/[IDCODE]/daily_summaries status code 200
2023-12-29 20:23:15.625 DEBUG (MainThread) [pynintendoparental] Request to https://api-lp1.pctl.srv.nintendo.net/moon/v1/users/[IDCODE]/devices/[IDCODE] status code 200
2023-12-29 20:23:15.627 DEBUG (MainThread) [pynintendoparental] Updating application stats for device [IDCODE]
2023-12-29 20:23:15.627 DEBUG (MainThread) [pynintendoparental] Parsing app 0100EA80032EA000
2023-12-29 20:23:15.628 DEBUG (MainThread) [pynintendoparental] Parsing app 0100D870045B6000
2023-12-29 20:23:15.628 DEBUG (MainThread) [pynintendoparental] Parsing app<PHONE_NUMBER>010000
2023-12-29 20:23:15.628 DEBUG (MainThread) [pynintendoparental] Parsing app 01006A800016E000

Diagnostics dump
No response

Hi,
Thanks for reporting, I need the full logs to identify where the problem is. The reason why debug logging dumps out so much data is because its nearly impossible to even attempt to replicate as those logs just tell me that something is wrong with the monthly summaries reports. The data will pin point where that actually is.
Could you upload the logs to my file drop please if you don't want to upload directly to GH?
https://cloud.hrvy.uk/s/GECpCXALZAoaa99
Even with the user/device IDs, there isn't a great deal someone could do with just those anyway as to access them requires an account to login with authorization to access those objects, which would require your Nintendo email/password.
Thanks.

Uploaded.  Apologies if you've got duplicate copies.

No problem. Think I see whats wrong, is this a new Nintendo Switch? I think its failing on the monthly summaries because that data doesn't yet exist (which perhaps is expected if the device is new).
I've had mine for a while which would explain why I haven't been able to replicate the issue if this is the case. Could you try the latest beta (2023.12.4) and send the logs again please (even if its working)?

Uploaded new logs.  Almost there.  Whitelisted app switches still not working.  Everything else seems to be.

  Christmas present for the boy.  I thought I was in the same boat as the others on that previous issue, but I was still having these issues after you closed it.

Ahhh, that explains this response on the monthly summaries:
{"count":0,"indexes":[],"items":[]}

I kind of have a fix for those whitelist entities, although as its a new switch I'm assuming there just isn't enough data available yet for full functionality.
Let me push that out, and we can try again. It won't display the current state but should still allow you to set the whitelist status of those apps.

right, can you try again with 2023.12.5 please?
It should assume the state of the switches that are failing where the data is missing.

Hey Guys,
I can confirm 12.5 works with a new Nintendo with no monthly data yet:

One additional thing I noticed is when I configure the applications to register entities, there are duplicates.
Not sure if it's because I have 2 local profiles for my kids, I'll test this out later:

Thanks for your efforts on this topic, I really like it :)

It all seems to be working fine here now.  Thanks, @pantherale0 for the quick responses!  Let me know if there's anything else I can do to help.
In response to @bohmszi, I have 1 out of 4 games total that shows up twice in the whitelist configuration.  If I add 1 instance of that game to the whitelist, the other is no longer available as an option to add.
Appreciate all work that went into this integration.  Do I NEED it?  Absolutely not.  But I'm addicted to Home Assistant and want every GD device I own included in it.  Thanks again!

Fantastic, thank you both for testing.
@bohmszi yeah, there's no checking at the moment to see if an application is already loaded into the temporary array. I'll look at that in the new year as it's purely cosmetic. The app IDs are identical under the hood regardless of switch, user, or NSO account.
Happy new year :)


How to get the past competitions?

hello，
I tried to get all the competitions using the "kaggle competitions list" command.
However, I found that I could only get the competitions that are currently in progress.
Is there any way I can get the competitions that have ended?
By the way, When I tried to use "--category all", some unexpected errors occurred. The full command and results are as follows:
kaggle competitions list --category all
400 - Bad Request - Unrecognized HostSegment enum value

Thanks for the report @BiqiangWang !
I think the active competitions are simply the first ones in the list. However, I couldn't get any competitions when I used the --page option, unless it was page 1. That is a bug.
I haven't tried all categories, but the ones I tried (other than all) worked. Since the default is all there is no loss of functionality, but it still should be fixed. Still, it only selected competitions from the first page, instead of listing 20 competitions in a category. That seems like another bug.

thanks for your reply! @stevemessick
--page does have the above problem. However, when using the --search option, although the information of --page 2 and later can be obtained, there is still no past competition.
maybe this proves that the kaggle competitions list command cannot get past competitions ?

By the way, the version I am currently using is the latest 1.6.17

I've identified the problem. There's a mismatch between how the API interprets parameters and how the web-server does. I'm working on a resolution for that but it won't be released for a while, due to scheduling priorities.
Currently, there is no way for the API to retrieve closed competitions.


clean prod install: "No module named backends.smtp" and "server closed the connection unexpectedly"

This is with a tarball generated last night from master.
I'm getting these two exceptions every few minutes, starting immediately after creating my organization. I'm using the same configuration in settings.py I always use, except now I don't have to provide a DEFAULT_FROM_EMAIL and the email backend is already enabled. Everything else appears to be working correctly and I'm receiving emails as expected.
Error generated by Anonymous user (not logged in) on minmi deployment

Traceback (most recent call last):
 File "/home/zulip/deployments/2017-06-25-15-22-50/zerver/worker/queue_processors.py", line 109, in consume_wrapper
 File "/home/zulip/deployments/2017-06-25-15-22-50/zerver/worker/queue_processors.py", line 286, in consume
 File "/home/zulip/deployments/2017-06-25-15-22-50/zerver/lib/error_notify.py", line 131, in do_report_error
 File "/home/zulip/deployments/2017-06-25-15-22-50/zerver/lib/error_notify.py", line 80, in notify_server_error
 File "/home/zulip/deployments/2017-06-25-15-22-50/zerver/lib/error_notify.py", line 123, in email_server_error
 File "/home/zulip/deployments/2017-06-25-15-22-50/zulip-venv/lib/python2.7/site-packages/django/core/mail/__init__.py", line 103, in mail_admins
 File "/home/zulip/deployments/2017-06-25-15-22-50/zulip-venv/lib/python2.7/site-packages/django/core/mail/message.py", line 348, in send
 File "/home/zulip/deployments/2017-06-25-15-22-50/zulip-venv/lib/python2.7/site-packages/django/core/mail/message.py", line 302, in get_connection
 File "/home/zulip/deployments/2017-06-25-15-22-50/zulip-venv/lib/python2.7/site-packages/django/core/mail/__init__.py", line 36, in get_connection
 File "/home/zulip/deployments/2017-06-25-15-22-50/zulip-venv/lib/python2.7/site-packages/django/utils/module_loading.py", line 20, in import_string
 File "/usr/lib/python2.7/importlib/__init__.py", line 37, in import_module
   __import__(name)
ImportError: No module named backends.smtp

Request info:
- path: None
- None: None
- REMOTE_ADDR: "None"
- QUERY_STRING: "None"
- SERVER_NAME: "None"

Error generated by Anonymous user (not logged in) on minmi deployment

Traceback (most recent call last):
 File "/home/zulip/deployments/2017-06-25-15-22-50/zerver/worker/queue_processors.py", line 109, in consume_wrapper
 File "/home/zulip/deployments/2017-06-25-15-22-50/zerver/worker/queue_processors.py", line 202, in consume
 File "/home/zulip/deployments/2017-06-25-15-22-50/zerver/lib/actions.py", line 2419, in do_update_user_activity_interval
 File "/home/zulip/deployments/2017-06-25-15-22-50/zulip-venv/lib/python2.7/site-packages/django/db/models/query.py", line 289, in __getitem__
 File "/home/zulip/deployments/2017-06-25-15-22-50/zulip-venv/lib/python2.7/site-packages/django/db/models/query.py", line 250, in __iter__
 File "/home/zulip/deployments/2017-06-25-15-22-50/zulip-venv/lib/python2.7/site-packages/django/db/models/query.py", line 1105, in _fetch_all
 File "/home/zulip/deployments/2017-06-25-15-22-50/zulip-venv/lib/python2.7/site-packages/django/db/models/query.py", line 53, in __iter__
 File "/home/zulip/deployments/2017-06-25-15-22-50/zulip-venv/lib/python2.7/site-packages/django/db/models/sql/compiler.py", line 886, in execute_sql
OperationalError: server closed the connection unexpectedly
	This probably means the server terminated abnormally
	before or while processing the request.

Request info:
- path: None
- None: None
- REMOTE_ADDR: "None"
- QUERY_STRING: "None"
- SERVER_NAME: "None"

The only example of the string "backends.smtp" I see is in zproject/settings.py in the value for EMAIL_BACKEND.
########################################################################
# EMAIL SETTINGS
########################################################################
# Django setting. Not used in the Zulip codebase.
DEFAULT_FROM_EMAIL = ZULIP_ADMINISTRATOR

if EMAIL_BACKEND is not None:
    # If the server admin specified a custom email backend, use that.
    pass
elif not EMAIL_HOST and PRODUCTION:
    # If an email host is not specified, fail silently and gracefully
    EMAIL_BACKEND = 'django.core.mail.backends.dummy.EmailBackend'
elif DEVELOPMENT:
    # In the dev environment, emails are printed to the run-dev.py console.
    EMAIL_BACKEND = 'django.core.mail.backends.console.EmailBackend'
else:
    EMAIL_BACKEND = 'django.core.mail.backends.smtp.EmailBackend'

I left it running and stopped getting these emails around 23:45 local (pacific) time. Also, rabbitmq crashed/stopped responding (also starting about then) and I had to restart it. (It looked like Zulip restarted, as expected, at 6:00 gmt.)
The rabbitmq log started doing this shortly after the scheduled restart, but it had been going on all night already
=ERROR REPORT==== 2-Jul-2017::06:06:50 ===
closing AMQP connection <0.5468.5> (<IP_ADDRESS>:44454 -> <IP_ADDRESS>:5672):
{handshake_error,starting,0,
                 {amqp_error,access_refused,
                             "PLAIN login refused: user 'zulip' - invalid credentials",
                             'connection.start_ok'}}

=INFO REPORT==== 2-Jul-2017::06:06:50 ===
accepting AMQP connection <0.5489.5> (<IP_ADDRESS>:44474 -> <IP_ADDRESS>:5672)

=ERROR REPORT==== 2-Jul-2017::06:06:53 ===
closing AMQP connection <0.5489.5> (<IP_ADDRESS>:44474 -> <IP_ADDRESS>:5672):
{handshake_error,starting,0,
                 {amqp_error,access_refused,
                             "PLAIN login refused: user 'zulip' - invalid credentials",
                             'connection.start_ok'}}

@feorlen did you install a fresh machine?  The rabbitmq errors, at least, look like what happens if scripts/setup/configure-rabbitmq wasn't run (aka the 'zulip' user's password hasn't been setup).

I think your actual problem is that your database is down (and maybe also something about the virtualenv being accessible from queue processors), and that exception is being masked by other errors.  Maybe this machine has too little RAM?  I'm not sure, but it seems like a very broken installation.
You probably will want to make sure all the third-party services (postgres, etc.) are working and then restart the Zulip server.

(This seems unlikely to be a code issue, so removing the bug tag).

This is my usual test machine, which is now running with 2GB of ram. If it happens again next time I install, I'll see what new details I can find.


More snake case than camel case for pep8

What is your view on renaming method say toSentence to to_sentence, toUpperSnake to to_upper_snake to match pep8 formatiing?

Fixed!


About the use of the ft tensor

Hello, thanks for your great work! I am curious about the meaning of the output feature tensor in your demo, and how it can be used in other downstream tasks as mentioned in your paper, such as image matching and segmentation? For instance, the output tensor of your demo is [2,1280,48,48], 48 are H and W dimension, and 2 refer to the input image and output image respectively, what is the meaning of 1280?

Hi, thanks for your interest in our work!
Your understanding of 2, 48 is correct. 1280 is the dimension of the feature vector.
Just let me know if you have any more questions.


React Native proof-of-concept implementation

As a Pillarbox developer I want to:

Check that Pillarbox can be used with React Native (Android, Apple, web).
Which team should create / maintain a bridge.

As a Play Suisse developer I want to:

A Reactive library with its sample app being able to play Play Suisse content, provided by the packager.
Use Fabric.
Address all native platforms (TV, mobile).
Have a minimal UI with a playback button and a slider.
Have a multi-instance player example in the demo.
Be able to start playback at some position.
Be able to play content with forced subtitles.
Be able to pick subtitle and audio languages before and during playback.
Investigate subtitle placement and possible alternative solutions.
Discuss with the web team how we can achieve a React.js component around Pillarbox web with an API similar to the React Native one.
Support casting (AirPlay, Google Cast).
Be able to have SRG SSR and custom analytics.

Acceptance criteria

Pillarbox integration with React Native has been investigated.
Learnings / findings / decisions have been recorded.

Tasks

[ ] ...

Workshop 10/10/2023
We have tried to implement a RN 0.72.5 - Turbo Module for the Pillarbox library
https://github.com/SRGSSR/react-native-pillarbox
Learnings
Android
✅ It seems to work
Apple
❌ It does not work

RN Framework does not support SPM
Pillarbox depends on SPM libraries (Swift-Collections, ComScore, Commanders Act)
Having Pillarbox support CocoaPods distribution would break the architecture of the library and have a high maintenance cost

Potential solutions

Native only application for Apple (TV, Mobile)
Native only player screen
Re-write Pillarbox to support RN
Switch to another hybrid development platform (KMM, …)
No longer use SRG SSR players in Play Suisse

Next Steps Play Suisse

Keep status-quo for React-Native Letterbox
Implement a new component based on Letterbox or Pillarbox Android + Letterbox Apple

https://www.notion.so/playsuisse/Pillarbox-on-React-Native-0f1446545859425d91d0ed3cd04baef8?pvs=4

It is possible to use Pillarbox for iOS in an React Native iOS project.
Using Pillarbox in the native iOS project generated by Expo
Here are the relevant steps to create a new project from scratch, add Pillarbox to it via SPM and display a native SwiftUI player view powered by Pillarbox:

Use npx create-expo-app@latest to create a new project with Expo.

Run npx expo prebuild to generate the native Apple and Android projects.

Open the generated Xcode workspace.

Update the minimum deployment target of the application to 16.0, the minimum version currently required by Pillarbox.

Add https://github.com/SRGSSR/pillarbox-apple.git as an SPM dependency and link the desired products (e.g. PillarboxPlayer or PillarboxCoreBusiness with the application target.

Add a Swift implementation file to implement a custom player layout using SwiftUI. Provide @objc annotated APIs so that your Swift code can be called from Objective-C(++) code that React usually requires.

To be able to call your Swift code from Objective-C(++) code import the following headers in order:
#import <ExpoModulesCore-Swift.h>
#import "YourAppName-Swift.h"

Note that the YourAppName-Swift.h header is automatically generated for your project to provide definitions for Swift code exposed to Objective-C(++). This file is managed entirely by Xcode.

Somehow use your APIs to display the player view in your app.

Have fun!

Associated sample code is available.
Using Pillarbox in a React plugin
A PR has recently been merged into React Native main branch to support SPM depdencies in React plugins.
Despite our efforts we could not build / use pre-release versions of React Native to test this new feature but, according to the usual React Native delivery cycle, there is hope that SPM support should appear in version 0.75.0 or soon after.
Once SPM support has been delivered by React Native we will test whether Pillarbox is compatible as dependency. SPM support in CocoaPods / React Native namely seems to have some limitations, some of which possibly incompatible with Pillarbox (e.g. I suspect that binary dependencies Pillarbox has, most notably for 3rd party closed-source analytics SDKs, might be a problem). Stay tuned.

I saw the merge yesterday and wanted to give it try 😄 -> https://github.com/SRGSSR/react-native-pillarbox/pull/1
This PR has SPM working on React Native 0.74 by applying the changes from the official PR to react-native after installation.
You can use the example/ as before to test "our react-native-pillarbox library".
Pillarbox is already setup as SPM dependeny on iOS: https://github.com/SRGSSR/react-native-pillarbox/pull/1/files#diff-0af6797c52bd5c14d8b756faec4fff93fb1956b052a28f292ce3a8a4e116c1a2R43-R53

Great, thanks for the info. We tried your PR but we are sadly facing a few compilation issues, but I guess your setup is probably better than ours.
So do youo confirm that you can create a native plugin that depends on Pillarbox using SPM support recently added to React Native on main?

@defagos I haven't gone far enough in the example to confirm at 100% that it works but I can say that it compiles properly with the Pillarbox Swift dependency.
I don't have the time right now to explore the whole Swift / objective-c++ bridge thing needed but I will try to find some time when I can.
We have the Pillarbox Hackathon 2 coming up next Wednesday so maybe we continue this together that day?
(We could also jump quickly in call and I help you with the compilation issues you are facing if needed)

Second workshop to attempt integration of Pillarbox with React Native
Objectives

Technical contexts:

React Native (with Fabric but without Expo) module integrating Pillarbox Apple and Android.
React Native (with Fabric and Expo) module integrating Pillarbox Apple and Android.

Features:

Builds and runs.
Play a video with native controls.
Play a video with custom controls (playback button / slider).

poke @GautierAnd @leonchabbey We wrote down the output from yesterday. Do not hesitate to comment if you think that something is missing or does not accurately reflect what we achieved yesterday. Thanks in advance.

We will ask the Play CH team for more feedback to be sure we are aligned on the output.

General remark: We spent most of the time struggling with the tools themselves.

This is one of the feedbacks I got from the team on our side. If there is no overall agreement about it we can of course drop it, the goal is really to have a common understanding of what we achieved in the end.

Since Pillarbox is compatible with React Native we think that the objective of this PoC has been fulfilled. If further steps are required we can get in touch again and plan another related issue.


Create a "learningedge-config" eclipse project and ant task for easier dev config setup

Previously we just had a template folder which you copied and modified, it would be easier if there was a project and ant task which did most of the work for you.

To use:
ant generate-config

Import the eclipse project in "Dev/learningedge-config"


Cannot find name $ref (use Ref Sugar (take 2))

When I tried to use Ref Sugar (take 2), Vscode told me the same error as the title, but Vite works properly:
<script setup lang="ts">
let count = $ref(0);
</script>

<template>
  <button type="button" @click="count++">count is: {{ count }}</button>
</template>

In addition, my vite.config.ts is:
import { defineConfig } from 'vite'
import vue from '@vitejs/plugin-vue'

export default defineConfig({
  plugins: [vue({
    refTransform: true,
  })]
})

I found a solution: #521
so sorry!


Project Roadmap

Hi, i saw your project, it sounds pretty good, we have decided to use Linkerd for our production but your project is impressive.
Do you have a Roadmap? if you share a Roadmap or feature difference, we can make better decision
I have another question do you suggest to use OSM in heavy load production for now?

Hey @alirajabi - we have a high level roadmap doc here. We're also doing some planning at the moment to figure out what our next release will look like. In the meantime, we're working on (1) hardening and finishing off our SMI implementations (2) bug fixes (3) helping answer community questions/respond to issues/PR reviews. We don't recommend OSM for production use at this time. We'd recommend running in test clusters only.


Flint tools are better than wood and stone

Like the title says, flint tools from PS are having quite some durability. Wood has 59 and flint for some reason has 225, is this an oversight or is this intended behaviour?

Like the title says, flint tools from PS are having quite some durability. Wood has 59 and flint for some reason has 225, is this an oversight or is this intended behaviour?

This is the intended behavior =)


Decktape

Pull Request Test Coverage Report for Build 473

38 of 59 (64.41%)  changed or added relevant lines in 11 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-0.3%) to 84.581%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

asciidoctor-gradle-js/src/main/groovy/org/asciidoctor/gradle/js/nodejs/AsciidoctorJSExtension.groovy
5
6
83.33%

asciidoctor-gradle-base/src/main/groovy/org/asciidoctor/gradle/base/AsciidoctorUtils.groovy
1
3
33.33%

asciidoctor-gradle-base/src/main/groovy/org/asciidoctor/gradle/base/internal/slides/ProfileUtils.groovy
0
2
0.0%

asciidoctor-gradle-js/src/main/groovy/org/asciidoctor/gradle/js/nodejs/core/NodeJSDependencyFactory.groovy
10
12
83.33%

asciidoctor-gradle-base/src/main/java/org/asciidoctor/gradle/base/slides/Profile.java
0
14
0.0%

Files with Coverage Reduction
New Missed Lines
%

asciidoctor-gradle-base/src/main/java/org/asciidoctor/gradle/base/slides/Profile.java
1
0.0%

Totals

Change from base Build 469:
-0.3%

Covered Lines:
1322

Relevant Lines:
1563

💛  - Coveralls


Break examples out into their own files

Issue Description

The datepicker and time input examples are all in the same file. Because of this, we need to update terra-ui.com whenever we update these examples. We should break these examples into their own files so the updates occur automatically.

https://github.com/cerner/terra-core/blob/master/packages/terra-site/src/examples/date-picker/Index.jsx
https://github.com/cerner/terra-core/blob/master/packages/terra-site/src/examples/time-input/Index.jsx

Issue Type

[ ] New Feature
[x] Enhancement
[ ] Bug
[ ] Other

Resolved in #537


draft: resync document

This document aim to captures the way of maintaining resync between scheduler-plugins u/s and this repo
Signed-off-by: Talor Itzhak<EMAIL_ADDRESS>

LGTM pending the merge vs cherry-pick approach

I'm inclined towards the approach described in the doc but I'm open to a cherry-pick flow if properly discussed and after evaluation of pros/cons
so LGTM for the current state of things.


Fix nullptr dereference in NvmlState

Fixes a bug where NvmlState was dereferencing a nullptr when libnvidia-ml.so.1 is not available.

/merge


[patch_closed_bug] Avoid commenting when a new attached revision is for uplifting

Note
Reported by @moztcampbell

Example: https://bugzilla.mozilla.org/show_bug.cgi?id=1821959#c19

@dsmithpadilla:
Normally, the bug is closed, but when uplifted in the current process we simply add the uplift link to the already attached patch. However, in the new uplift pilot once it lands in central and gets closed, the developer actually opens a new patch to beta or release or esr which will trigger the bot to think they attached a new patch to a closed bug.

Also https://bugzilla.mozilla.org/show_bug.cgi?id=1818762#c27

The tool does not comment when the new patch has an uplift request. However, the new uplift pilot workflow does not add approval flags (i.e., approval-mozilla-*) to the uplift patches.
https://github.com/mozilla/relman-auto-nag/blob/2989185115d608c87ce2c67180a5da0629ec873e/auto_nag/scripts/patch_closed_bug.py#L54-L57

I filed https://bugzilla.mozilla.org/show_bug.cgi?id=1825961 to follow up on identifying uplift patches. We could identify the uplift patches by querying them on Phabrecator, which will add unnecessary overhead. It will be better to have a flag or something on the Bugzilla attachments themselves.

Since bug 1825961 is already deployed. We should drop the workaround in https://github.com/mozilla/bugbot/pull/2011. If the dry-run returns the expected results, we can close this as completed.

@suhaibmujahid what's the status here? The patches referenced have all merged/landed, AFAICT - but this is still happening, cf. https://bugzilla.mozilla.org/show_bug.cgi?id=1842547#c15.

This is a new regression in the new uplift workflow. I reopened bug 1825961 to follow up on the issue. In the meantime, I have also submitted a PR (i.e., #2168) to restore the workaround to avoid spamming the bugs.


Don't run checks or tests on main

What this PR solves / how to test
All checks + tests are run on PRs as well as on Version Packages before a release, and so we don't need to re-run them on main. The relevant checks are test:ci and check, both of which are run on pull requests.
Author has addressed the following

Tests

[ ] TODO (before merge)
[ ] Included
[x] Not necessary because: CI change

Changeset (Changeset guidelines)

[ ] TODO (before merge)
[ ] Included
[x] Not necessary because: CI change

Public documentation

[ ] TODO (before merge)
[ ] Cloudflare docs PR(s): https://github.com/cloudflare/cloudflare-docs/pull/...
[x] Not necessary because: CI change

We don't enforce up-to-date branches, so would mean that a conflict might not be caught until you go to make a release. And worst-case, the Version Packages PR itself could potentially be out-of-date?

We don't enforce up-to-date branches, so would mean that a conflict might not be caught until you go to make a release. And worst-case, the Version Packages PR itself could potentially be out-of-date?

We'll be keeping track of Version Packages for this (and we lock main as we do releases, so there's no chance of Version Packages getting out of sync with main)


Subscribing to list updates

Hi,
Would you be interested in adding a link to my service which allows users subscribing to your list's updates via RSS and email (free, no spam)? Here is your RSS feed, for example.
Let me know if you have any questions!

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@maltsev Thanks for your interest!  It looks like GitHub has a built-in RSS feed now, for example:
https://github.com/CUTR-at-USF/awesome-transit/commits/master.atom
Given this, I'd prefer to rely on that internal mechanism rather than external RSS feed generators.  I appreciate you listing awesome-transit on your list site!

FYI, I just added a link to the built-in RSS feed in https://github.com/CUTR-at-USF/awesome-transit/blob/master/README.md.  Thanks for the idea!


fix: some cosmetic changes in TODO.md and version # in const.py

updated the file giving an error on the linting test

Thanks for the fixes to the readme!
I have been scratching my head re the version thing. There is a github workflow for release that updates the version numbers in both manifest.json and const.py, so that the copies of those files in the released zip file have the version number in them (see .github/workflows/release.yaml).
I don't plan to store the version number in the main branch of the repo because then checkouts of later commits will carry a then-incorrect version number in their files, and automation of releases feels like the right place to manage that. Also I think that a feature of custom components is that if they have a version of 0.0.0 they will override a core integration of the same name (not quite relevant, but I am just trying to go by some established workflow - about which I might be mistaken, however).
I am wondering though if HACS is downloading the zip file or if it's downloading the repo at the commit of the tag instead - the latter would explain how you'd get files with no version number in them. But if you enable "Show beta versions" my understanding is that it will pull directly from the main branch, but maybe the version behaviour is different, too.
I will probably need to push another release before I can test this properly on my system, but there's a bug I want to crush first - hopefully that won't take too long.
If you want to modify your PR to just have the README changes I'll be happy to merge that for now, anyway.

The reason I updated the version number was when submitting an issue, the form has the following text:
## Version of the custom_component

<!-- If you are not using the newest version, download and try that before opening an issue
If you are unsure about the version check the const.py file.
-->

So as I wasn't sure of the version # I went to const.py to check as instructed and found 0.0.0
Anyhow, I'm now trying to figure out how to revert that commit in the PR...

Yeah, that would have been confusing! Once I've worked out if HACS does something odd with downloading releases (like by checking out the tagged commit instead of the zipped release) I'll update the issue template to make things clearer - thanks for pointing that out.
todo cleanup looks good, thanks!


Support of react 14?

Hello, thanks for your component!
I am updating my project to react 14 and as I use react-youtube component currently it is peerDependacy problem, I have started to make changes and wished to make PR but noticed that you have rewrite branch with react 14.
Do you have some estimate when it will be merged with master and published?
Thanks!

The release date is completely up to @troybetz, but I agree an eta would be a good idea.
All that really needs to happen before publishing it on npm is a major version bump seeing as the rewrite branch is already feature complete.
In the meantime you can try using the rewrite branch using npm's "github url as a dependency"-feature like this: "react-youtube": "troybetz/react-youtube#rewrite"
I personally had mixed results with this method but maybe you can figure out how to make it work...

Sorry for the late reply @lapanoid, been swamped on the side. 5.0.0 should be out in a few days, will close this when it's out

@troybetz friendly ping :) is anything blocking v5 still? i'd be happy to help out if so!

Sorry, on it!

5.0.0 is available & supports react 14, sorry for the wait!

all good! many thanks! :)


Add blockCount to Epoch table

Maintaining a count of blocks produced in the current epoch will remove the need for a common aggregation query that impacts performance and db load. In particular, the homepage of the new Cardano Explorer requires this information, and query caching only improves the UX, not load.

This is relatively trivial. The easiest solution that avoids a data migration would be to just drop the epoch table which can be rebuilt in a minute or two.

It needs more than just dropping the epoch table. Dropping the database works.

Dropping the database ans recreating it and now I have:
cexplorer=# select * from epoch ;
 id |      out_sum       | tx_count | blk_count | no |     start_time      |      end_time
----+--------------------+----------+-----------+----+---------------------+---------------------
  1 |<PHONE_NUMBER>6482912 |       33 |     21587 |  0 | 2017-09-24 16:09:11 | 2017-09-28 21:26:11
  2 |<PHONE_NUMBER>14214219 |    12870 |     21590 |  1 | 2017-09-28 21:45:51 | 2017-10-03 21:43:51
  3 |<PHONE_NUMBER>8424764 |     4292 |     21599 |  2 | 2017-10-03 21:45:11 | 2017-10-08 21:38:51
  4 |<PHONE_NUMBER>5422302 |     3293 |     21598 |  3 | 2017-10-08 22:39:31 | 2017-10-13 21:38:11
  5 |<PHONE_NUMBER>1413934 |     3524 |     21601 |  4 | 2017-10-13 21:45:31 | 2017-10-18 21:24:51
  6 |<PHONE_NUMBER>9220193 |     2608 |     21599 |  5 | 2017-10-18 23:56:51 | 2017-10-23 21:43:51
  7 |<PHONE_NUMBER>2009723 |     2404 |     21601 |  6 | 2017-10-23 21:46:51 | 2017-10-28 21:40:51
  8 |<PHONE_NUMBER>47111456 |     2645 |     21600 |  7 | 2017-10-28 21:49:51 | 2017-11-02 21:40:51

How important is a proper data migration?

Since there is only a single DB schema, a schema migration will be needed.

Ok, i have written the migration. All is well.

Ok, have a working migration. All seems well.


Viz throws Uncaught TypeError: Cannot read property 'indexOf' of undefined

Description

Here's the test code, please paste it into https://xstate.js.org/viz/ and click UPDATE button:
  const testMachine = Machine({
    id: 'test',
    initial: 'idle',
    states: {
      idle: {
        on: {
          CLICK: {
            target: 'loading',
            actions: send((context, event) => ({
              type: 'END'
            }), {
              delay: 200
            })
          }
        }
      },
      loading: {
        on: {
          END: {
            target: 'test'
          }
        }
      },
      test: {
        type: 'final'
      }
    }
  })

Expected Result

Viz should work.
Actual Result

It throws Uncaught TypeError: Cannot read property 'indexOf' of undefined in console. The problem was caused by send receiving a function, replace it with send('END', {delay: 200}) works just fine.
Reproduction

As you can see here https://codesandbox.io/s/loving-voice-ec5wk the code works.
Additional context

Duplicated of https://github.com/davidkpiano/xstate/issues/683


Develop a dependency collection interface

Similarly to how we've developed interfaces for vulnerability services and reporting formats: we should have an interface that individual sources of dependencies should implement.
That, in turn, will make our Auditor (#18) implementation sufficiently generic and extensible.

Different sources of dependencies will probably need different initialization state, so we should probably leave the constructor open ended.
A rough sketch of what I'm thinking:
class DependencySource(ABC):
    @abstractmethod
    def collect(self) -> List[Dependency]:
        ...

then, we'd have concrete implementations for requirements-formatted files, pip list, etc.


Getting children nodes

I'm using checkbox plugin and when the user click on a node containing childrens, the check_node event is fired
.on('check_node.jstree', function (e, data) {
  var id = data.node.original.id;
}

data.node contains the checked node, with all properties, but not children.
The two arrays "children" and "children_d" contains only children'IDs, not the node themselves.
How can I obtain child nodes with all their properties? Or, in alternative, searching for the nodes by IDs (NOT getting the DOM element,  but the node himself)
The only way I found is something like:
 for(var i in data.node.children) {
  var curChildren = tree_data.instance.get_node(data.node.children[i]).original;
}

getting the array directly in event data would be way easier

On a side note - do not depend on original - what do you need that is not directly present on the node? If you store extra properties - use the data property (for more read the home page of this repo).
As for the issue - yes - you need to use get_node and use the children array. Collecting all children each time before the event is fired will be way too slow, and would mean transferring a huge object with each event.
Best regards,
Ivan


Stuck at ?login l Same with ?logout

Tried looking at other issues, but nothing in them seems to work. My config file is all configured correctly, and nothing else seems to be happening. I've tried loading older versions that worked before, updating it, using session_start(), and even modifying the files themselves. Nothing worked.
My website is: http://www.livaco.tk/ if anyone needs it.
If anyone knows what's happening that would be great!

When I click on the login button it redirects to http://www.livaco.tk/?login which I don't believe would be a page on your webserver. Can you please post the code that you used for the button. It should call the loginbutton(); function.

also, ? represents a get request to that page and since there is probably nothing to handle it, it ignores it.

Sign In

I was using this code on my test server with the exact same setup, and it worked fine. No issues at all. steamauth.php should be handling the GET request to login since it's being required before the button even gets made.

It will work if you use http://www.livaco.tk/steamauth/steamauth?login but since there is no handler on any other page for that it wont work.

Odd, how would I implement that into my other webpages then? Like i said i'm calling the needed require 'steamauth/steamauth.php'; so I would've assumed it would've worked?

Did you include the form part? https://github.com/SmItH197/SteamAuthentication/wiki/Creating-A-Custom-Logout-Button

You can do either a link or form button. I did the links, but according to that it should work either way.

Try the form version instead then.

That didn't work, but I've just simply done this
Sign In
 and it seems to be working. I'm aware its not the best way to do it, but honestly I just want to get this website running (I spent a while making this new version so i'm a really annoyed from this). Thanks for your help.

Ok, no problem.

not sure if you figued this out yet or not, but all you need is:
<?php
require_once ('steamauth/steamauth.php');
?>

At the top of each of your pages, or in your header.php or whatever you have named it.
Either way this file needs to be included/required on each page for the ?login or ?logout to work.


[BUG] Failed to connect to node due to Interface issue

OS: gentoo
Source Compiles but the VPN itself doesn't work.
Regular WireGuard VPN works without any issue but not with myst vpn client.
The tools set and library should be there.
To debug this. please help me to understand how the client code interface with OS ????
Sorry for my terrible understanding about Typescript.
Screenshot:

Please attach all required logs that are needed for us to investigate the issue.
https://github.com/mysteriumnetwork/mysterium-vpn-desktop#logs

I have attached log into original post


Suggestion: new container with AAD use authenticatioemail as user name

PLEASE DO NOT INCLUDE ANY PASSWORDS OR TOKENS IN YOUR ISSUE!!!
Describe the issue
When I create a new container using New-BcContainer using auth AAD and authenticationemail, I pass parameters $credential for container user and e-mail for ADD authentication
The user created in BC in CRONUS database is $credential.UserName with $authenticationemail.
And the user needed to access container (windows user) is $credential.UserName using $credential.Password.
In this situation, the User Name in BC is the same as the container, but other than the authentication email.
I suggest the in BC User Name should be the same as Authentication Email.
In this case, we have separate credentials for:

Authenticate in container or publish apps from VSCode as NavUser.
Access to BC using AAD credentials using as User Name the same as Authentication Email.

Scripts used to create container and cause the issue
Example:
 $credential.UserName = ADMIN
 $authenticationemail =<EMAIL_ADDRESS>
Full output of scripts
In BC the user created is:
User Name: ADMIN
Authentication Email<EMAIL_ADDRESS>
For container access or VSCode access by "authentication": "UserPassword"
User Name: ADMIN
Password:  (the password used to create container)

Suggested change
In BC the user created is:
User Name<EMAIL_ADDRESS>Authentication Email<EMAIL_ADDRESS>
For container access or VSCode access by "authentication": "UserPassword"
User Name: ADMIN
Password:  (the password used to create container)

Screenshots
If applicable, add screenshots to help explain your problem.
Additional context

does it happen all the time?
did it use to work?

So you want to use username/password authentication with the AAD username as username and the same password as password?
Why wouldn't you just use AAD authentication from VS Code (which works with the latest changes in BcContainerHelper)
I am not a big believer of using your AAD password other places than in a secure AAD login environment (but I might have misunderstood your suggestion)

I'm using many containers shared in a traefik server for many developers and testers using default Cronus database.
Until now, I was always using UserPassword to access from VSCode.
My first idea for containers using AAD is to create a container than can be used with AAD authentication for users in web client, and the two types of authentication from VSCode (UserPassword -that use common for anypeole- or AAD -new in VSCode from OnPrem containers-).
With my initial tests (see description of this issue) I've tried to create a container with two users: one for AAD and other for NavUserPassword, but I have had problems using the admin user (the one I want for NavUserPassword from VSCode) and the email, since they are different users.
Finally, after thinking about Freddy's answer and researching the New-NavContainerHelper code, I found a solution to create both users, I've modified my script for:

Create a container using the same UserName for container admin as the authentication email for AAD. It creates a containers with one user where the user name is the same as authentication email.
Create a user of type NavUserPassord that is common and shared by all developers.

After that, developers can connect from VSCode using dual authentication types.
Finally, I think my suggestion isn't a good idea to modify bccontainerhelper.
@freddydk , yo can close this issue. Thanks for all.

Ok, thanks
But please note that a container setup with AAD authentication CAN be used from VS Code with AAD authentication as well - since this PR: https://github.com/microsoft/navcontainerhelper/pull/2270 (3 weeks ago)


Force Layout tick without d3.timer

So, I'm interested in using d3's force layout headlessly - but with manually calling tick rather than having it run on a timer. Right now the .alpha() method is coupled to animation and it's not really possible to have it both ways - to have alpha set to an animating value but not have the timer firing.
Could these APIs be decoupled somehow? Or is there a workaround I'm missing? Thanks!

Sorry for resurrecting an old post.
Is there any downside when checking against the current .alpha() value instead of a fixed n like your example? I dug around the docs and couldn't find one, nor did my benchmarks show a big difference, but wanted to make sure since you specifically suggested one way.
Perhaps a combination?
Thanks!
function calculateLayout( alpha, max ) {
    alpha = alpha || 0;
    max = max || 1000;
    var i = 0;
    while ( force.alpha() > alpha && i++ < max ) {
        force.tick();
    }
}


Resolve alias for context typename (fixes #259)

See #259
The test added by this PR is failing without the .dealias patch

@propensive Sorry for bothering, could you please provide any feedback on this? We look forward for this fix as inner type shortcuts are important part of our DSL-like structures and dealiasing them manually is not an option. Thanks

Any updates on this? Still waiting for any feedback

Hi @ivan-klass, sorry for the delay. This is a tricky one.
Sometimes dealiasing is what you expect, sometimes the opposite. Actually scalac has lots of issues open because it's not specified when dealiasing can happen and people get surprised.
Back to Magnolia land, I wonder if we should dealias genericType in the beginning rather than just for typeName.

Very sorry for the delay, @ivan-klass. I didn't see the notification, unfortunately. I think we should merge this. I have vague memories of some of the dealiasing issues @joroKr21 mentioned, but my feeling is that dealiasing should produce less surprising results in general. We can publish a new release, and roll back if it's problematic.


Fix: Issue of synchronizing namespaced local memory caches

Changes to namespaced local memory caches do not get pushed correctly.
When the CacheStack is namespaced, it creates a namespaced version of the l1 drivers, however does not create a new bus with the modified l1 driver. This change fixes that.
Added some test cases as well. Should fix #32

Looks perfect!
Thanks a lot for taking the time to fix this issue

@Julien-R44  could we get a release pretty please? 🙏 Wanted to try this fix, but I'm running into other issue when trying to install from main.

@wodCZ Yup sorry! Release with 1.0.0-beta.10

Hmm. I might have misunderstood the goal of this PR, but I'm still having issues with namespace synchronization across multiple processes.
I've created a minimal reproduction: https://github.com/wodCZ/bentocache-bus-repro

Thanks for the repro dude !
There is indeed an issue going on. Let me check that

Different issue with BinaryEncoding not handling the Clear message correctly. #38 should fix it.

Released with beta.11


no need to set Flannel etcd configuration when we add a node

when we add a node  by --limit  to a cluster , this task is redundant , so I use when: inventory_hostname == groups['etcd'][0] to skip it.

ci check this


(umbrello.install) Latest version exceeds 200 MB

Expected Behavior
Be able to submit last version of umbrello.install package.
Current Behavior
-a----       02/08/2019     05:17      198610545 umbrello.install.2.28.3.nupkg

_Containing;_
-a----       02/08/2019     05:16       99762773 umbrello-mingw32-2.28.3-22.1-setup.exe
-a----       02/08/2019     05:17      100542126 umbrello-mingw64-2.28.3-95.1-setup.exe

cpush .\umbrello.install.2.28.3.nupkg
Chocolatey v0.10.15
Attempting to push umbrello.install.2.28.3.nupkg to https://push.chocolatey.org/
An error has occurred. It's possible the package version already exists on the repository.

Possible Solutions
1/ Integrate this package in Chocolatey-coreteam repository who allows packages excedding 200 MB
2/ Change the package to be no longer embedded.
Previous version with a size of about 154 MB
a----       11/05/2019     14:26      154240923 umbrello.install.<IP_ADDRESS>90511.nupkg

Integrate this package in Chocolatey-coreteam repository who allows packages excedding 200 MB

This is not true, the same restrictions are placed on the core team packages repository as with any other package repository.
The reason why there may be some packages that are above 200MB is because there was a short time this was possible. (this was lowered due to external providers I believe. Can't remember which one right now though).
You're free to open a pull request to migrate the package to this repository, but do note that we have stricter requirements/guidelines than those used in the community repository. So be sure to review the       Contribution guidelines before you do.
Do also note that this repository is not meant as a dumping ground, so as such it is expected that the original maintainer (probably you in this case) is responsible to fix any issues regarding the package (be it problems with the package itself, updater not working, considering new features wanted by the community, etc.). This doesn't mean we won't step in at times though, of course.

I will close this since it is not relevant for this repository and migration is based on wrong idea.
For this package I suggest the following solution that we adopted once in the past: provide embedded binary for x64 bit version and keep downloading x32 bit version - since most of the systems today are x64 and x32 bit will eventually be deprecated, this is a good trade for this problem.
If you want to migrate the package here, just do PR and follow the guidelines.


Make possible to see the notification table in the BO

I would like to see the "oyst_notification" in the BO

release


SA1600 (Elements must be documented) treats members that explicitly implement an interface differently from legacy StyleCop

(I may have mentioned this before, but can't find the issue.)
Legacy StyleCop treats members that explicitly implement an interface member as if they were private. Since 0960dcd5b6f8551cefd5a7e87460455e92a408d2 we view them as public. (This isn't consistent with its ordering rules, which treat such members as being public.)
I don't know why SC had this behaviour, since it is easy to argue that such a member is usually a publicly accessible member of the type (assuming the interface itself is public). Maybe it's just a side-effect of the member not having an access modifier, which would usually imply private accessibility.
Alternatively—and this is the rationale that seems most reasonable to me—documentation comments are primarily intended to feed Intellisense. An explicitly implemented interface member is never visible in Intellisense except after casting the object to the interface type. Therefore, any documentation against the implementation is never used.
Even where XML comments are used to generate documentation, it would seem reasonable that comments for explicitly implemented interfaces could be obtained directly from the interface rather than its implementation.

:memo: A code fix is provided for this in #1331.

Fair enough. I do prefer the old behaviour, but if I'm on my own on this, then that's fine. The code fix makes it easy to tidy these up.

Therefore, any documentation against the implementation is never used.

This is a great point BTW. These comments would only ever be used when rendering the documentation with tools like Sandcastle. The only reason I lean away from changing it is it will be so easy to clean these up starting (ideally) with Beta 10.

OK. I can live with that.

One more thing to consider...
The compiler rule CS1591 (Missing comment for publicly visible type or member) seems to have similar logic to the old StyleCop behaviour. It is seemingly never reported for explicit interface implementations.


Issue in Javascript Learn LocalStorage ToDo app Step 11

Describe the Issue
The step doesn't call for an implicit return to be used, but it won't pass without using one.  The following is what the step asked to do:
"Use const to declare a variable called dataArrIndex and assign it the value of taskData.findIndex(). For the findIndex() method, pass in an arrow function with item as the parameter.
Within the arrow function, check if the id property of item is strictly equal to the id property of currentTask."
Affected Page
https://www.freecodecamp.org/learn/javascript-algorithms-and-data-structures-v8/learn-localstorage-by-building-a-todo-app/step-11
Your code
The following code was my initial answer to this step.
  const dataArrIndex = taskData.findIndex((item) => {
    item.id === currentTask.id;
  })

This is the only code that I have been able to get to pass this step.
  const dataArrIndex = taskData.findIndex((item) => item.id === currentTask.id)

Expected behavior
This step should pass with my first code since the step doesn't call for Implicit return.  The other option would be update the step to call for an implicit return.
Screenshots
No response
System

Device: Macbook
OS: macOS
Browser: safari
Version: 17.6

Additional context
Here is a link to my post out on the forum for this issue as well.

https://forum.freecodecamp.org/t/learn-localstorage-step-11/706026/4

That's how javascript works when you define a function block you have to tell the interpreter what that block should return otherwise it will only execute those written within the curly braces and not return anything,  without the curly braces the line after the arrow is treated as the return value

Please note the callback function needs to return result of item.id === currentTask.id, otherwise findIndex method will not work as intended.

Shouldn’t the step call for an implicit return then?

We should not require any specific syntax when teaching array methods. The code should pass with both implicit and explicit returns, it also shouldn't require an arrow function.
The explanation of the method API should include the callback. If you understand how it works, it should be obvious it must return a value. How the camper does it is irrelevant.

The findIndex() array method finds and returns the index of the first element in an array that meets the criteria specified by a provided testing callback function. If no such element is found, the method returns -1. The callback should return a truthy value to indicate a matching element has been found, and a falsy value otherwise.

The problem is, as per usual, we can't test the actual value, so we end up with a regex test. And testing for all valid code is a nuisance. It is, however, the correct thing to do here in my opinion. Requiring specific syntax when teaching a new method is doing a disservice to the camper. They should understand the API of the method so they can write the correct solution no matter what valid syntax they choose to use. That is how you know they understand the API, as exemplified by this issue.

Shouldn’t the step call for an implicit return then?

No. The arrow function itself has its own syntax. That is why when using an arrow function, one of the perks is removing the return and when passing only one parameter, a curly brace isn't needed. For instance, const hello = ((item) => "Hello World!"); // hello = (item) => "Hello World!";

I know this was opened up to contribution but I don't think we have reached a consensus.
In my opinion, we should not force a specific syntax when teaching array methods and we should allow all valid code.
But, if we do force a specific syntax, we should not allow an explicit return. I see no reason to support an explicit return if we are not allowing all valid syntax (i.e. a normal function for the callback). In which case, we should force the use of the most concise syntax for the callback and the requirements should be updated to reflect this.

Allow all valid syntax:

Update the description to include the callback.

The findIndex() array method finds and returns the index of the first element in an array that meets the criteria specified by a provided testing callback function. If no such element is found, the method returns -1. The callback should return a truthy value to indicate a matching element has been found, and a falsy value otherwise.

Remove all mentions of arrow functions in the description, requirements, and test hints.

Update the regex to allow for all valid code.

Allow only concise callback:

Update the description to include the callback.

The findIndex() array method finds and returns the index of the first element in an array that meets the criteria specified by a provided testing callback function. If no such element is found, the method returns -1. The callback should return a truthy value to indicate a matching element has been found, and a falsy value otherwise.

Update the requirements to specify that the callback must use an implicit return and not have a block body.

Leave the tests as is, but update the hints to again restate the callback function requirements.

It might be worthwhile to request specific syntax specifically because learners don't consistently know what all the terms are at this point? Give them a chance to remember some technical terms.

True, requiring an implicit return could be seen as reinforcement.
My main concern with forcing specific syntax when teaching an array method is how it might affect the campers understanding of the API. For example, in this particular instance, the camper should understand that the callback must return a value, be it implicit or explicit. If the camper writes a callback that does not return a value, it points to us not teaching the API correctly.
In general, I'm OK with requiring an implicit return, but I fear doing so when teaching array methods might obscure the understanding of the API. But if the API requirements are properly included as part of the instructions, and then we implicitly ask for the concise syntax, that could work as well.


[Hub Generated] Review request for Microsoft.Consumption to add version stable/2019-10-01

If you are a MSFT employee you can view your work branch via this link.
Contribution checklist:

[x] I have reviewed the documentation for the workflow.
[x] Validation tools were run on swagger spec(s) and have all been fixed in this PR.

/azp run automation - sdk

These changes were reviewed and approved by @sanjaiganesh in the private repo - https://github.com/Azure/azure-rest-api-specs-pr/pull/1143

/azp run automation - sdk

/azp run automation - sdk

Can one of the admins verify this patch?

Is the PR ready to merge?

Is the PR ready to merge?

Yes it is.


Fix flaky web driver test

In RegistrarConsoleScreenshotTest's password setting test,
wait until the transaction has happened instead of a fixed
amount of time.

This change is

While this is definitely better, does it completely eliminate the flakiness? The fact that datastore is updated doesn't indicate that the response has been sent to the user agent and rendered, correct?

We can add a short delay to account for rendering. By the time the query can start the mutation has already committed. Marshalling and wire time shouldn't be a big concern.

Reviewable status: 0 of 2 files reviewed, all discussions resolved (waiting on @CydeWeys and @jianglai)

I mean it's still trading one possibility of flakiness for another. Is there a way to do this deterministically? For example waiting on an HTML element to finish rendering? i. e. calling the waitForElement method?


11:51	Error running '[Local] xxx': SAM build command failed

Description
Sam build command keeps failing every now and then  I keep restarting my docker to ensure it doesnt fail.
Observed result
11:41	Error running '[Local] xxx': SAM build command failed
11:51	Error running '[Local] xxx': SAM build command failed
11:51	Error running '[Local] xxx': SAM build command failed
Additional environment details (Ex: Windows, Mac, Amazon Linux etc)

OS: windows 10
sam --version: 0.50

Add --debug flag to command you are running

Is this a docker mounting issue? are you running on a container?

Closing due to no response.

I have the same problem (and all my colleagues have too).
Maybe it is connected to this: https://github.com/aws/aws-toolkit-jetbrains/issues/1473#issuecomment-601320805
Can we reopen the issue?


No customisation

Hello,
i installed the mod yesterday and i dont know why but if i select modern beta als world type there is no option for further customisation. Does anyone else have that problem?

See #69


Fix minor things

Fix a minor error in the documentation of the function seconds
Fix type declaration for two EZConfig functions used to configure keybindings. I think they should take a KeyMask instead of a ButtonMask (both are synonym for Modifier which is a CUInt).

Applied, thanks!


keybase client provided via macports is out of date (5.8.1 vs 6.0.1) leading to pgp/gpg errors

The macports package for the keybase client is currently on 5.8.1, per https://ports.macports.org/port/keybase/ and the command line port search:
% port info keybase;
keybase @5.8.1 (security)

Description:          Command-line interface to Keybase.io
Homepage:             https://github.com/keybase/client

Build Dependencies:   go
Runtime Dependencies: gnupg2
Platforms:            darwin, freebsd, linux
License:              BSD
Maintainers:          none

As a macports user, I'd expect that if this is going to be supported at all, keybase would push updates to the port tree so that using the port version of keybase syncs well with other services. Notably, using 5.8.1 causes issues when interacting with the tools for supporting pgp/gpg keys. For example:
% sudo port install keybase
# successful install output elided
% keybase help
# help output as per normal
% keybase account email list;
▶ ERROR Unexpected version clash; client is at v5.8.1, which is significantly *less than* server at v6.0.1-20220609162338+0fc9feea3d
% keybase pgp select
▶ ERROR Unexpected version clash; client is at v5.8.1, which is significantly *less than* server at v6.0.1-20220609162338+0fc9feea3d

If the only supported channel for keybase is directly grabbing the dmg, that's fine, but (imo) the macports package should be marked depricated/removed.

And just to confirm:
% sudo port uninstall keybase;
Password:
--->  Deactivating keybase @5.8.1_0
--->  Cleaning keybase
--->  Uninstalling keybase @5.8.1_0
--->  Cleaning keybase
# reinstalling via dmg...
% which keybase;
/Applications/Keybase.app/Contents/SharedSupport/bin/keybase
peri@ged dotfiles-github % keybase account email list;
[private email elided] (visibility: PRIVATE, verified: true, primary: true)
<EMAIL_ADDRESS>(visibility: PUBLIC, verified: true, primary: false)
peri@ged dotfiles-github % keybase pgp select
You are selecting a PGP key from your local GnuPG keychain, and
will publish a statement signed with this key to make it part of
your Keybase.io identity.

Note that GnuPG will prompt you to perform this signature.

You can also import the secret key to *local*, *encrypted* Keybase
keyring, enabling decryption and signing with the Keybase client.
To do that, use "--import" flag.

Learn more: keybase pgp help select

▶ ERROR No PGP keys available to choose from.
# this error is expected as I have revoked all pgp keys

I'd like to note that since there are many different ways to get GnuPG on macOS, working with the same package manager (macPorts in my case, homebrew for many other users) simplifies debugging if there are actually issues in the underlying GnuPG libraries or the integrations with keybase or macOS tooling.


chore(deps): update dependency @types/react to v17.0.2

Closes

User facing changelog

Additional details

How has the user experience changed?

PR Tasks

[ ] Have tests been added/updated?
[ ] Have docs been added/updated?
[ ] Have stories been added/updated?

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

:tada: This PR is included in version 1.2.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Github: Set specific version to actions

It only sets the SHA for every action.

I rebased this on top of all the changes made recently to github actions & config management.
Will merge this PR too, since it's been open for a while and already approved :)


Like feature

First thing, PLEASE READ THIS: ReactPlay Code Review Checklist

Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
Checklist:

[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules

@nirmalkc please post a message here once the style part is done.

@koustov please do a final review.
I am approving it. You do a final review and merge if all is good. Please clean up the play_like table entries before you merge..


Add invisible column feature

Enhancement

Is anyone working on this right now? Can i work on this?

Is anyone working on this right now? Can i work on this? @gaoxueyu ?

Hello Imran,
Regarding your question, no one is currently working on this issue, so you are welcome to take it up and work on it. Feel free to let me know if you have any questions.
Thank you once again for your commitment to IvorySQL, and we look forward to your progress on this issue.

Mapping PR #679


Fix Bot and Docker Python

Description
Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.
Type of change

[ ] Bug fix 🐛
[X] Refactor 🔨
[ ] Style 🎨
[X] New feature ✨
[ ] Breaking change 💥
[ ] This change requires a documentation update 📝

Focus
Please indicate which section the change is directed to

[ ] Frontend 📱
[X] Backend 🗄

Checklist:

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes

mucho spanglish en las variables wn


Fix Master-Layout.md

Fixed:

Invalid markdown syntax on one of the tables
Default value of new_is_master was incorrectly stated as false
See https://github.com/hyprwm/Hyprland/blob/b2cb3b8bf25e42a44dc53681938ec1399f56d784/src/config/defaultConfig.hpp#L97

wrong line
https://github.com/hyprwm/Hyprland/blob/b2cb3b8bf25e42a44dc53681938ec1399f56d784/src/config/ConfigManager.cpp#L107
but yes


binaries no longer appear to be working

$./sqsmv-1.0.0-linux
-bash: ./sqsmv-1.0.0-linux: cannot execute binary file: Exec format error

figured it out. that isn't the binary...


A slight error regarding the helpers.md document

Check List
Please read and check followings before submitting a PR.

[ ] I want to publish my theme on Hexo official website.

[ ] I have read the theme publishing doc.
[ ] name is unique.
[ ] link URL is correct.
[ ] preview URL is correct.
[ ] preview URL web site is rendered correctly.
[ ] Add a screenshot to source/themes/screenshots.
[ ] Screenshot filename is same as value of name.
[ ] Screenshot size is 800 * 500.
[ ] Screenshot file format is png.

[ ] I want to publish my plugin on Hexo official website.

[ ] I have read the plugin publishing doc.
[ ] name is unique.
[ ] link URL is correct.

[x] Others (Update, fix, translation, etc...)

Languages:
[x] en English
[x] ru Russian
[x] zh-cn simplified Chinese
[x] zh-tw traditional Chinese

Note
No need to translate ko, pt-br, th languages if you submit a PR for documentation.

Warning
ko, pt-br, th languages document are inactive. Please, submit issue if you want to continuous contribution to them.

可以给我通过吗？

@tomap

@tomap Est - il possible de passer ma soumission, s'il vous plaît? May I ask if I can submit it? 请问可以通过我的提交吗？


The link on the support page to the posting rules of the community forum is broken

The link on the support page to the posting rules of https://groups.google.com/forum/#!forum/cukes, that is https://cukes.info/posting-rules (which is also used in the header of the https://groups.google.com/forum/#!forum/cukes), currently returns "404 NOT FOUND".

fixed in https://github.com/cucumber/website/commit/d52175959a15d6cbe303002e4d29eb4251e954f5


Uncaught Error: ENOENT: no such file or directory, open '$ATOM_HOME/packages\w3c-validation\READM...

[Enter steps to reproduce:]

...
...

Atom: 1.45.0 x64
Electron: 4.2.7
OS: Unknown Windows version
Thrown From: Atom Core
Stack Trace
Uncaught Error: ENOENT: no such file or directory, open 'C:\Users\Владислав.atom\packages\w3c-validation\README.md'
At fs.js:115

Error: ENOENT: no such file or directory, open 'C:\Users\Владислав\.atom\packages\w3c-validation\README.md'
    at Object.openSync (fs.js:436:3)
    at Object.module.(anonymous function) [as openSync] (ELECTRON_ASAR.js:160:31)
    at Proxy.readFileSync (fs.js:341:35)
    at Proxy.fs.readFileSync (ELECTRON_ASAR.js:580:40)
    at PackageDetailView.renderReadme (<embedded>:14:825951)
    at PackageDetailView.updateInstalledState (<embedded>:14:825711)
    at <embedded>:14:826582
    at Function.simpleDispatch (<embedded>:11:1214120)
    at Emitter.emit (<embedded>:11:1215561)
    at PackageManager.emitPackageEvent (<embedded>:11:945159)
    at <embedded>:11:942291
    at r (<embedded>:11:936821)
    at n (<embedded>:14:1125047)
    at t.bufferStream (<embedded>:14:1125201)
    at Socket.e.on (<embedded>:14:1123803)
    at Socket.emit (events.js:187:15)
    at Pipe._handle.close (net.js:606:12)

Commands
 26x -7:44.7.0 core:backspace (input.hidden-input)
  3x -7:33.9.0 core:confirm (input.hidden-input)
     -3:41.9.0 core:backspace (input.hidden-input)
     -3:36.8.0 core:confirm (input.hidden-input)
     -1:12 core:backspace (input.hidden-input)

Non-Core Packages
atom-beautify 0.33.4
atom-bootstrap4 1.4.0
atom-console 0.4.6
atom-material-syntax 1.0.8
atom-material-ui 2.1.3
atom-ternjs 0.20.0
autocomplete 0.47.0
autoprefixer 4.2.0
busy-signal 2.0.1
color-picker 2.3.0
editorconfig 2.6.0
emmet 2.4.3
file-icons 2.1.40
git-plus 8.7.1
hyperclick 0.1.5
intentions 1.1.5
jquery-snippets 11.0.0
linter 2.3.1
linter-bootlint 1.1.9
linter-csslint 2.0.6
linter-eslint 8.5.5
linter-htmlhint 1.6.3
linter-jshint 3.1.19
linter-stylelint 4.5.0
linter-ui-default 1.8.1
linter-write-good 0.9.3
minimap 4.29.9
minimap-linter 2.2.1
platformio-ide-terminal 2.10.0
remote-ftp 2.2.4
w3c-validation 0.4.0

Thanks for reaching out!
We require the template to be filled out on all new issues and pull requests. We do this so that we can be certain we have all the information we need to address your submission efficiently. This allows the maintainers to spend more time fixing bugs, implementing enhancements, and reviewing and merging pull requests.
Thanks for understanding and meeting us half way 😀


How does the rhythm system work exactly?

What is your question?
Hey!
Sorry if this question is stupid I'm quite new to the inner workings of rhythm games in general and this is quite a BROAD question but in the context of FNF and psych engine how does the rhythm system work in a broad summary. (Not talking about the conductor, I mean the input system and all that)
I'm trying to read through the code to understand it more but I only have a tiny understanding of how it works and I understand more of how it's implemented if you get what I mean.
I want to understand the concept for the scope of my own project.

 Notes at the same time for some reason.
Accuracy is determined by how close you were to hitting a sick! So it saves those judgements and uses it to calculate your accuracy on a scale of 0% “(you suck!) to 100% (perfect!)”
combo is self explanatory.
If anyone wants to correct me do it

@jimmyjamescool in psych it works like etterna, the 0.5 update changed how the timing windows work from vanilla fnf to etterna timing windows

sorry not Etterna, I meant Judge four

Huh

Huh

psych engine 0.5 and above use judge four as it's timing windows

what you showed in the picture was the vanilla timing windows

Ik I was just saying “huh never knew that”
they also asked for the vanilla timing windows too so…

ohhh, my b

Your talking about timing and rating but what about how the notes are generated or how strumlines work in psych?


updating the popup content on popupopen

I'm trying to update the popup content associated to a marker (in the pointtolayer function when adding a GeoJSON overlay) in the popupopen event handler, with the following code:
const addTest = () => {
  const container = document.getElementById(containerID);
  container.innerHTML = "
TEST
"
}

popup.setContent(`<div id="${containerID}"></div>`) //popupContent)

marker
  .bindPopup(popup)
  .on("popupopen", function (popup) {
    console.log(popup);
    addTest();
  });

The first time I click on a marker the popup content is not updated. If I click again, while the popup is open, the popup content is updated.
Using the debugger, I noticed that also during the first click event handling the popup is updated, but before the completion of the same click event handling it is restored to the previous value.
What's wrong in my code? Or is a Leaflet issue?

Is working fine for me: https://plnkr.co/edit/q9Eo7elzRUoKcNP3
Are you sure that you are using Leaflet Version 1.7.1 or newer?

Yes, I am using Leaflet Version 1.7.1.
In my code  I'm defining the marker popup in the function passed to the pointToLayer option  of L.GeoJson().
Can this make the difference?

Please share your code and if possible make a demo here: www.leafletjs.com/SlavaUkraini/edit.html

It might be either to a user's error by now keeping track of the variables involved (I'm kinda tired of linking to an explainer of how JS closures work), or it might be due to Leaflet firing the popupopen event before the container has been actually added to the DOM (but then, a getElementById() call would return undefined, and something should throw an error).
In any case:  the container for a popup can be reliably fetched, even if it hasn't been added to the DOM, by:
foo.on('popupopen', function(ev) {
  var popupContainer = ev.popup.getElement();
});

Also note one can use L.Popup's setContent() in a similar fashion by using ev.popup.setContent().
I'm partial to closing this as "not a Leaflet bug" since it's perfectly possible to update a popup's content from an event related to that popup.

Probably it is "not a Leaflet bug", but i fixed my problem doing something "strange" with a Leaflet marker method:
marker
  .bindPopup(popup)
  .on("popupopen", function (popup) {
    console.log(popup);
    addTest();
    this.setPopupContent();
  });

I just added the line this.setPopupContent(); after popup content update, which shouldn't (?) do anything... but it is actually doing something, in Falke-Design's demo too. In fact the popup rendering is different, with or without that call.
I don't know why, maybe someone can try to figure out.
Check this demo with a longer line of text in the popup: https://plnkr.co/edit/egZnvbHMjPAK1gHY
If you comment out the added line of code,  the popup content is the same but is differently rendered.
In my case it is correctly set to my "exepcted" content.

This Your suggestion is very tricky and not a clean workaround.
Why is happening?
Leaflet defines the size of the popup based on the content, but you changing the DOM directly without letting Leaflet know, that the content has changed, because of this the width of the container is not growing.
When you call setPopupContent() the caclucation for the size of the container is triggered but without passing an argument you set the content variable in Leaflet to undefined. Now functions like getPopup().getContent() not working anymore.
The right way would be this:
const addTest = () => {
	popup.setContent(`<div id="${containerID}"><p>This is a longer line of text!</p></div>`) //popupContent)
};

marker
	.bindPopup(popup)
	.on("popupopen", function (popup) {
		console.log(popup);
		addTest();
	});

I close this "error" because of a wrong usage of the API.

You are right that it was a very tricky suggestion. But I found a workaround with a correct usage of the API.
popup.setContent(`<div id="${containerID}-wrap"><div id="${containerID}"></div></div>`) //popupContent)

marker
  .bindPopup(popup)
  .on("popupopen", function (e) {
    addTest();
    const innerHTML = document.getElementById(containerID+"-wrap").innerHTML;
    this.setPopupContent(innerHTML);
    alert(e.popup.getContent());
  });

I add a wrapper to the previous popup content and then I pass the innerHTML of the wrapper to setPopupContent. Now Leaflet knows the DOM changed and getContent is working properly.
Check the demo here: https://plnkr.co/edit/egZnvbHMjPAK1gHY


⚠ Aither has degraded performance

In 9e6023d, Aither ($AIH) experienced degraded performance:

HTTP code: 200
Response time: 2219 ms

Resolved: Aither performance has improved in 156ac20 after 12 minutes.


[BP-1.9][FLINK-14315] Make heartbeat manager fields non-nullable

Backport of #9837 to release-1.9.

@flinkbot run travis

Thanks for the review @TisonKun. Merging this PR now.

Merged into release-1.9.


russian mail.ru domain is not allowed

gmail working very well.
Russians mail servers not working.
mail.ru have @mail.ru, @list.ru, @inbox.ru, @bk.ru, @mydoname.com accounts
ex. If i use smtp.mail.ru its not working with my<EMAIL_ADDRESS>Its working only smtp.mail.ru with @mail.ru
can i use force smtp andress without checking doname?
How to fix this?

sorry, my fail in settings, Name of doname must be mydoname.com, but i am use mydoname


add txtype filter to /transactions/interval/ endpoint

@johnsnewby I'm thinking that this filter should also be on /transactions/account/. what do you think?


Refactor client code and update docs

Add keep-alives to SOAP/REST clients
source is extracted from the underlying client connection
Make secret mount path configurable via env for local testing
Remove naming conflicts with imported packages
Update docs with changes and clean build instructions

Closes: #140
Signed-off-by: Michael Gasch<EMAIL_ADDRESS>

Also there's some lint warnings:
https://github.com/vmware-tanzu/sources-for-knative/pull/141/checks?check_run_id=1347387580
very aggressive on the log formats :)

Also there's some lint warnings:
https://github.com/vmware-tanzu/sources-for-knative/pull/141/checks?check_run_id=1347387580
very aggressive on the log formats :)

Hm, what is that linter check trying to tell me?:
Error: [Redundant Format] reported by reviewdog 🐶
Please consider avoiding tail format like this:
logger.Info("vCenter current time: ", t.String())

The actual line is logger.Infof("vCenter current time: %s", t.String())
Is it recommending to not use f syntax but rather stitching together strings?
If so, not sure why this is failing now (I only had to rename the variable):
Error: [Redundant Format] reported by reviewdog 🐶
Please consider avoiding tail format like this:
ev.SetID(fmt.Sprintf("%d", be.GetEvent().Key))

The actual line is ev.SetID(fmt.Sprintf("%d", be.GetEvent().Key))

Yeah, perhaps there were existing linting errors, but yes in general it wants to not have the f variant with the last argument being formatted, instead just remove the formatting and add the argument alone as the last argument, something like this:
logger.Info("vCenter current time: ", t.String())

Over using formatting, since Info will stitch things together for you:
logger.Infof("vCenter current time: %s", t.String())

Not sure about the other one, will need to look at the code, and we can clean these up later, so don't worry about it now.


Serialize models using GlobalID

First off, thanks for making this library! Just came across it looking for a way to control the sequence of jobs and I think this will do the trick.
One nuance we'll have to code around for now is that ActiveRecord objects get serialized as a HashWithIndifferentAccess by the looks of things, whereas I was expected to get the model record back. Please do let me know if it sounds like I'm doing something wrong though! It would be awesome if this library used GlobalID to (de)serialize job arguments.

Well this is designed for arbitrary data, and not specifically AR records, so all data it reads and writes is simply a hash, serialized as JSON in the sidekiq_sequence_record DB table using ActiveRecord::Base.serialize.
I wouldn't recommend you store model data, as that could out of sync with the actual model data. Instead, simply store model ID's in @data.
@data[:user_id] = 102

Then look up the record when needed. That way, you are always reading data from the source of truth - the model.
But I see no reason why GlobalID couldn't be used. PR's are welcome 😉


[WIP] ImageField: clear float using clear: both

Hi there,
This PR is for #395 and allow the ImageField component to be used as last field of a form without breaking the form display.
Thanks 😄

Any updates on this one?

Bump

Problem does not exist anymore


Dev/agilent34450a

Adds instrument Agilent34450A Digital Multimeter.

All functions were tested with the instrument, I took out the tests with commit 5539936 to not mess up with the normal testing routine when the device is not connected.

Nice work on the large number of tests! I'm hesitant to just throw this away - alternatively, could you mark the tests as skipped instead? Using pytest.skip('Only work with connected hardware', allow_module_level=True) at the top of the file should skip all the tests, but would keep them around.
In case we implement a better test suite even for non-connected hardware (see #249), we could then enable/adapt these tests.
(You'll need to fix the merge conflict in the authors file first so that CI can run correctly)

Re-added the tests with the skip. I corrected the AUTHORS.txt conflict, but it still shows up somehow, I am not sure what is up with that.

Don't worry, I'll sofrt out the authors.txt for you.

Oh, you used f-strings, which are incompatible with python 3.5. I think it is time to remove support for EOL'd python3.5, see #338, so this should be fine for now.
There is a warning in the test log:
pymeasure/instruments/agilent/agilent34450A.py:555

  /home/travis/build/ralph-group/pymeasure/pymeasure/instruments/agilent/agilent34450A.py:555: DeprecationWarning: invalid escape sequence \s

    list_of_elements = re.split('["\s,]', one_long_string)

Pytest does not show the skipped tests, but that is apparently a known issue.

I removed Python 3.5 support from master, so with your next modifications, do a merge/rebase from pymeasure master and the CI should start to work again. :-)

Thank you for your effort! Merging this now.


Fix remote config bug

The configuration objects not initialized with the remote configuration aren't correctly initialized resulting in a wrong default configuration.

Mistakenly opened. This fix is part of #582.


Pip does not come native with MAC OS.

I tried to run setup-build-macos script, but I think that pip does not come native with mac os.
+ sudo pip2 install lit
sudo: pip2: command not found

I solved problem by running sudo easy_install pip. You might want put this to script or give some error message like you do with brew.

Thanks! Fixed.


add MIT license file

Hello @maksbd19 ,
first of all, thank you for this plugin!
I would love to use it but I'm missing a license file. I'm assuming it was intended to be MIT and therefore I propose to accept this pull request.
Thank you!
Best Regards.

@pateta thanks a lot for the PR


Load configuration

Issue #10 says that we need to have a configuration data type. How do we load that configuration?
Idea: allow the user to specify a config-as-Haskell code that is imported from a specific location.
I think I'm mostly a fan of 3, as we already need to provide the user a way to import a module to provide relevant types (as raised in issue #1). If that module contains a kaleConfig value, then we can import it and use it.
Depending on the type of kaleConfig, we could handle it in different ways:

kaleConfig :: Config = just use this
kaleConfig :: Config -> Config = given the defaults, modify them like this
kaleConfig :: IO Config = bind this out of IO
kaleConfig :: Config -> IO Config = given the defaults, load this configuration

Actually, that idea can't work! The preprocessor strategy that the library is currently using means that the code hasn't been compiled yet, and we can't import it or use it at all while constructing the module.
We need the preprocessor bits in order to construct the import list. And we can use the preprocessor to scan for an _.Import module which we'll then import. However, in order to let the Config type affect code generation, then the bits of code that are generated using the Config must be TemplateHaskell.
TemplateHaskell can construct data types, provide instances for them, and generate the case expression as well, so I think this is pretty doable.


Add custom mock assertions

Could add minitest assertions used with objects

assert_mocked
assert_mock_called
assert_mock_called_with (maybe)

It looks like this may be more difficult than originally expected. A plugin cannot define the assertions. They have to be injected into a reopened Minitest::Assertions which would require the project using grift to modify it's test case base class.


infinite file opening loop

Here is my System info:
Operating System: Garuda Linux
KDE Plasma Version: 5.21.5
KDE Frameworks Version: 5.82.0
Qt Version: 5.15.2
Kernel Version: 5.12.1-zen2-1-zen
OS Type: 64-bit
Graphics Platform: X11
Processors: 8 × 11th Gen Intel® Core™ i7-1185G7 @ 3.00GHz
Memory: 15.4 GiB of RAM
Graphics Processor: Mesa Intel® Xe Graphics

This happened first to me when I tried ctrl+shift+p to open up the settings.json. I wasn't able to reproduce this in mac os and I think it just started happening recently. Anyway, the jist of it is that it just continuously opens new files. I get two errors in the console:
ERR nvim_win_close: Invalid window id: 1051: Error: Error making request to nvim_win_close
  at o.request (/home/joshua/.vscode-oss/extensions/asvetliakov.vscode-neovim-0.0.78/dist/extension.js:1:15853)
  at Timeout._onTimeout (/home/joshua/.vscode-oss/extensions/asvetliakov.vscode-neovim-0.0.78/dist/extension.js:3:101219)
  at listOnTimeout (internal/timers.js:549:17)
  at processTimers (internal/timers.js:492:7)

and
  ERR nvim_win_get_cursor: Invalid window id: 1060: Error: Error making request to nvim_win_get_cursor
	at o.request (/home/joshua/.vscode-oss/extensions/asvetliakov.vscode-neovim-0.0.78/dist/extension.js:1:15853)
	at he.<anonymous> (/home/joshua/.vscode-oss/extensions/asvetliakov.vscode-neovim-0.0.78/dist/extension.js:3:100678)
	at Generator.next (<anonymous>)
	at /home/joshua/.vscode-oss/extensions/asvetliakov.vscode-neovim-0.0.78/dist/extension.js:3:88882
	at new Promise (<anonymous>)
	at ce (/home/joshua/.vscode-oss/extensions/asvetliakov.vscode-neovim-0.0.78/dist/extension.js:3:88627)
	at Timeout._onTimeout (/home/joshua/.vscode-oss/extensions/asvetliakov.vscode-neovim-0.0.78/dist/extension.js:3:100617)
	at listOnTimeout (internal/timers.js:549:17)
	at processTimers (internal/timers.js:492:7)

But mostly the first window close error. I don't know why this causes continuous new windows to open up, but when I disable the extension it stops it.
You can see what it looks like here:

As a side note, I thought maybe I could fix this myself and put in a pull request, but I don't have a whole lot of time and I was having trouble getting into debugging the extension. I couldn't really get it activated. If there's a slack channel that can help me get up and running I can try to fix it myself.
Let me know! Thanks!

I forgot to mention, I'm using both VScodium and code-oss... not the official vs code builds.

This is the first time I installed this extension, but due to this issue, it is not useable.
I hope this bug gets fixed soon.

I applied @seandewar's patch to the latest release of the plugin, and it works fine as far as I can tell.
If you want to use the plugin without downgrading neovim:
curl -L https://gist.github.com/kidonng/1f70b2e3de50b519483f6c79dd3d82e2/raw/6b865cec34f78475dc50b208b30563d337427543/extension.js > ~/.vscode/extensions/asvetliakov.vscode-neovim-0.0.78/dist/extensions.js

Thanks

Update: A decision was made to revert the patch within a month if there's no fix upstream, so a workaround may not be necessary soon! tada

I'm no expert, but imo it should have been reverted ASAP after it was figured out, and then do the fix on unreleased version

I'm no expert, but imo it should have been reverted ASAP after it was discovered, and then do the fix on unreleased version

One reason for not reverting immediately is at https://github.com/neovim/neovim/pull/14531#issuecomment-838119219.
Breaking changes are to be expected in 0.5, as it is the currently unreleased version.

This is the first time I installed this extension, but due to this issue, it is not useable.
I hope this bug gets fixed soon.

I'm in the same boat. Also, because this is my first time installing neovim and vscode-neovim extension I also have an empty init.vim and this issue still happens like every 10-30 minutes (not sure what I'm doing to trigger the bug). Had to uninstall the extension for now but will follow progress here and try again when it's resolved :)

Hello, I'm also a new user, and I would like to know if the workaround will be implemented in the VScode plugin and released soon? I will apply the patch on my end, but I suggest it be released asap as well. Thanks.

I applied @seandewar's patch to the latest release of the plugin, and it works fine as far as I can tell.
If you want to use the plugin without downgrading neovim:
curl -L https://gist.github.com/kidonng/1f70b2e3de50b519483f6c79dd3d82e2/raw/6b865cec34f78475dc50b208b30563d337427543/extension.js > ~/.vscode/extensions/asvetliakov.vscode-neovim-0.0.78/dist/extensions.js

This command writes to a file named extensions.js, but the correct file is extension.js, which means the following is correct:
curl -L https://gist.github.com/kidonng/1f70b2e3de50b519483f6c79dd3d82e2/raw/6b865cec34f78475dc50b208b30563d337427543/extension.js > ~/.vscode/extensions/asvetliakov.vscode-neovim-0.0.78/dist/extension.js

How did the original comment get 5 (positive) reaction while having a typo and thus not working is beyond me.

@eyalch Typo fixed, thanks for spotting it!

🎉 fix by @eyalch works for me

That fix also works for me. Should this fix be merged back into master?

Glad to see my fix appears to be working. :tada:
I'm happy to open a PR if @asvetliakov is OK with this.

can confirm that the fix is working with vscodium also, thank you.

I can reliably trigger this issue with the julia extension. Open a Julia REPL from the F1 menu, and run @enter println("hello") and enjoy 300 windows with the same content. I guess I'm going back to the regular VIM extension for now.

I applied @seandewar's patch to the latest release of the plugin, and it works fine as far as I can tell.
To use the plugin without downgrading neovim:

Can confirm this resolved the issue. Thanks for the fix ❤

os : Pop!_OS 20.10
vscode :
1.56.2
054a9295330880ed74ceaedda236253b4f39a335
x64

FWIW, asvetliakov's instructions above on building an old version of nvim worked for me.
Note that I originally pointed the extension towards a softlink and it continued to default to the standard nvim.  I had to set it to the actual nvim executable.

FWIW, asvetliakov's instructions above on building an old version of nvim worked for me.
Note that I originally pointed the extension towards a softlink and it continued to default to the standard nvim. I had to set it to the actual nvim executable.

The old version also worked for me, but ran into some issues with my other vim configurations where Lua plugins assumed a newer version. It was better for me to replace the extension with the one from the latter curl fix.

curl -L https://gist.github.com/kidonng/1f70b2e3de50b519483f6c79dd3d82e2/raw/6b865cec34f78475dc50b208b30563d337427543/extension.js > ~/.vscode/extensions/asvetliakov.vscode-neovim-0.0.78/dist/extension.js

I just ran into this issue on Windows, and this solved it for me. (just change the path to your user home).

This major showstopper bug has been left open for 18 days after a working solution was posted, what is the hold up? It could be integrated at least temporarily while upstream fixes the root cause.

This major showstopper bug has been left open for 18 days after a working solution was posted, what is the hold up?

Welcome to the open source.
I'll push the update soon, sorry for taking it too long and any inconvenience it caused

I appreciate your help Alexey!
This plugin literally is what makes vscode a viable editor for me.
On Fri, May 28, 2021 at 9:00 AM Alexey Svetliakov @.***>
wrote:

This major showstopper bug has been left open for 18 days after a working
solution was posted, what is the hold up?
Welcome to the open source.
I'll push the update soon, sorry for taking it too long and any
inconvenience it caused
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/asvetliakov/vscode-neovim/issues/632#issuecomment-850517731,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAG64TR4U3VNKDKFAY5HPLTP643HANCNFSM44POVTEQ
.

--
Fabio Miranda Costa (he/him/his)
twitter: @fabiomiranda https://twitter.com/fabiomiranda
github: fabiomcosta https://github.com/fabiomcosta/
linkedin: fabiomirandacosta
https://www.linkedin.com/in/fabiomirandacosta/

Releases 0.0.79 with the fix. Thanks @seandewar !

Thanks! Happy to have helped. 🎉
Just a heads up that I'm working on a proper fix upstream at https://github.com/neovim/neovim/pull/14659 that may add a noautocmd option to nvim_open_win to restore the old behaviour.
The eventignore fix will continue to work after that PR is merged so there's no rush to update things (it may also take a while for  openWindow in https://github.com/neovim/node-client to be updated with the new option unless someone volunteers to do it).

@seandewar Awesome, thank you. Subscribed for noautocmd PR. I also might be revisiting window management later (by dropping support of external buffers)

@seandewar @asvetliakov you people are saviours. Thanks a lot!!

Is it possible that this issue has returned? I'm observing a similar behaviour.
An untitled copy of the current file opens at Vscode's startup. And multiple start to appear when I run a python script on an interactive window. Curiously this only happens when a init.vim file is present. Even a fully commented out init.vim triggers the issue. Deleting or renaming the default init.vim solves the problem.
My specific setup consists on:
OS: Windows 10
Visual Studio Code: 1.78.2
Neovim: 0.9.0 or 0.10.0-dev-382-gebb10d624 (I have tried both in case the issue was solved on nightly builds)
Could be something related to Python or Jupyter extensions? I'm working with python scripts via the Microsoft plugins.
The extension is great, but dealing with the tab clutter becomes a bit tiresome after a while...

@ngmoviedo I have run into this problem as well, with extension version 0.3.2 (the latest version has been giving me some trouble so I haven't updated yet).
Even though I normally see it with Python or Robot files, I was able to reproduce the issue today while trying an Extension Bisect where only vscode-neovim was enabled. I didn't have empty init.vim though, but it sounds like you were able to reproduce even with empty init.vim? If I can figure out a way to reproduce it more reliably (and on the latest extension version) I'll probably open a new issue... but I just wanted to mention that I've narrowed it to this extension specifically.