doc: added documentation for input type=file

Have added some explanation on how to implement the form input type=file in React as suggested in #86. Please review and revert :smile:
Have used a ref to the file input and used it to access the file(s) in submit handler instead of saving the file in the state. (Was suggested as a better solution in #218)

@bvaughn
Was wondering if this PR works?

Have committed the changes in this branch as suggested in the review @bvaughn

@bvaughn Can't exactly figure out what went wrong. Was wondering if you could help resolve? :disappointed_relieved:

Yup! Looks like CI is failing on the yarn prettier command. Run it locally and you'll see that the example gets slightly reformatted.
Since this reformats the example slightly, you'll want to verify the line number highlights. To make sure Gatsby regenerates the markdown for this example, the safest thing to do is clear cache before spinning up the devserver: rm -rf .cache && yarn dev. (This is a downside of using this plug-in and maybe something I can address with a future update...)
Anyway, the end result after doing both of the following should be something like this:
diff --git a/examples/forms/input-type-file.js b/examples/forms/input-type-file.js
index 5cc084d9f..5eff7c5b8 100644
--- a/examples/forms/input-type-file.js
+++ b/examples/forms/input-type-file.js
@@ -1,27 +1,45 @@
 class FileInput extends React.Component {
   constructor(props) {
     super(props);
-    this.handleSubmit = this.handleSubmit.bind(this);
+    this.handleSubmit = this.handleSubmit.bind(
+      this
+    );
   }
-// highlight-range{1-4}
-  handleSubmit (event) {
+
+  // highlight-range{5}
+  handleSubmit(event) {
     event.preventDefault();
-    alert(`Selected file - ${this.fileInput.files[0].name}`);
+    alert(
+      `Selected file - ${
+        this.fileInput.files[0].name
+      }`
+    );
   }

   render() {
     return (
-      <form onSubmit={this.handleSubmit}>
+      <form
+        onSubmit={this.handleSubmit}>

           Upload file:
-          {/* highlight-next-line */}
-          <input type='file' ref={input => {this.fileInput = input}} />
+          {/* highlight-range{1-6} */}
+          <input
+            type="file"
+            ref={input => {
+              this.fileInput = input;
+            }}
+          />

-

-        <button type='submit'>Submit</button>
+

+        <button type="submit">
+          Submit
+        </button>
       </form>
     );
   }
 }

-ReactDOM.render(<FileInput />, document.getElementById('root'));
+ReactDOM.render(
+  <FileInput />,
+  document.getElementById('root')
+);

@bvaughn That fixed it. Thanks. :smile: (Apologies for not being able to figure out the CI problem myself)


add contributors

@all-contributors
please add @ for .
please add @ for .

@all-contributors
please add @liyaowhen for .
please add @the-jasoney for .

@all-contributors
please add @the-jasoney for flood fill.
please add @liyaowhen for owner.

@all-contributors
please add @liyaowhen for projectManagement.
please add @the-jasoney for ideas.

https://github.com/all-contributors
please add @liyaowhen for projectManagement.
please add @the-jasoney for ideas.

@all-contributors
please add @liyaowhen for projectManagement.
please add @the-jasoney for ideas.


Autorest Generated Client Incorrect

Describe the bug
I have generated a Java client library using autorest and the swagger specs in this repo. However, the autorest generated code seems to be stuffing the request headers with info that the microservices cannot handle.
For example the following snippet of code generated by autorest is what calls the IIoT microservices:
@Headers({ "Content-Type: application/json; charset=utf-8", "x-ms-logging-context: com.microsoft.azure.iiot.ua.sdk.swagger.registry.OpcRegistryService activateEndpoint" })
@POST("v2/endpoints/{endpointId}/activate")
Observable<Response<ResponseBody>> activateEndpoint(@Path("endpointId") String endpointId);

Initially, calling activateEndpoint failed and gave me errors like: The format of value 'application/json; charset=utf-8' is invalid.
After removing "Content-Type: application/json; charset=utf-8" from the code snippet above, activateEndpoint worked as expected.
To Reproduce
Steps to reproduce the behavior:

Use autorest to generate Java client library
Call activateEndpoint
See error: 'application/json; charset=utf-8' is invalid.`

Expected behavior
Autorest should generate correct client library off of swagger specs or microservices should handle what the generated client code is sending to them.
Additional context
Also confirmed through Postman, that calling activate endpoint with Content-Type: application/json; charset=utf-8 in the Headers resulted in the same problem.

I also wanted to note that this error occurs with deactivateEndpoint as well. These are the only two calls I have noticed that have these issues thus far. Unsure if there are more producing this problem since I have only tested a very small subset (getListOfEndpoints, getListOfApplications, de/activateEndpoint).

Hi @msha1026 - this likely occurs for all API.   We are going to fix this in sprint 2003.

@marcschier thanks for the info :) What does sprint 2003 mean in regards to date? Is there an approximate date?

Hi @msha1026 , I tried to reproduce for the same API call with Postman, however, it was working fine. Screenshot below:

Could you please try again with the newer codebase and also attach your swagger json file which you used to generate Java client using autorest?

@monikavar I can confirm I do not see this error with the new release. The swagger json I was using was with the 2.5.2 release.


MPLUGIN-417 Descriptor with plain text by default

Report uses enhanced descriptor with HTML
Include better links to javadoc
Include more block taglets in description

@rfscholte What do you think of this approach and scanning the sources twice for plain-text and html separately?

The commit is too big for me to see what's happening.
With TDD I'd like to see:

plugin descriptor keeps the original javadoc, so inlcluding inline doclettags.
the generated help-goal prints plain text
the report generator of the goal transforms the inline doclettags to valid html.

IIRC in the past I've made a change that the two outputs are always based on the same source: the plugin descriptor.

IIRC in the past I've made a change that the two outputs are always based on the same source: the plugin descriptor.

The whole point is that this approach prevents emitting the full details. Currently the plugin descriptor contains inline taglets (which is wrong) and the HTML report does no longer have access to the full context. So in order for the report to not go via
(parse source file information -> convert javadoc to html -> convert html to plaintext -> serialize descriptor) -> (deserialize descriptor -> convert plain text to html)
(while the former block being goal descriptor and the latter being report) you have to do the parsing twice.

The commit is too big for me to see what's happening.

Right now you can completely ignore the newly added classes, just look at the modification of the existing ones, to tell me what you think of the approach in general.

I think I get your point regarding the context. Based on that it is indeed fine to use HTML as content for the plugin descriptor. Just make sure there's a test that requires this context, as it is the critical part of this solution.


Build source code to x86_64 on RPi

Describe the bug
The RPi architecture is arm but it builds the source code with x86_64.
To Reproduce

Download source code on RPi
Build source code like below
$ ./build

Screenshots
pi@raspberrypi:~/workspace/edge-home-orchestration-go $ uname -m
armv7l
pi@raspberrypi:~/workspace/edge-home-orchestration-go $ docker logs edge-orchestration
standard_init_linux.go:211: exec user process caused "exec format error"

Test environment configuration (please complete the following information):

Hardware: RPi2
Edge Orchestration Release: Baobab

@t25kim Thank you for the kind report!


Entering spaces in bank details

GOV.UK Design System’s Bank details has the following guidance.
Account number

“Must be between 6 and 8 digits long”

International bank account details

“Must be between 8 and 11 characters long”

Sort code

“Let users enter their sort code in whatever format is familiar to them. Allow additional spaces, hyphens and dashes.”

Error message
If the account number is not in the correct format

‘Enter a valid account number like 00733445’.

Any spaces which are added to the account number field will generate an error. This behaviour feels wrong, especially as some users need to break up strings of digits in order to read them properly. We should accept spaces in these fields and amend the hints and errors accordingly.

This issue has been seen in the following services:

Manage a claim for P800 BACS repayment

Account number and sort code now allowing for inout with spaces and different formats.


Update README.md - added authenticated channel example

Added an example for subscribing to authenticated channel.
I was a little bit confused since in the official pusher website, the example is in objective-c and it uses a delegate so it's a bit different.
Hopefully this will be helpful and avoid confusion.

Awesome - thanks!
I was thinking about adding something like this in but you've done it for me 👍


Fix for WFCORE-5722, Can't upgrade JBoss Modules artifact

Issue: https://issues.redhat.com/browse/WFCORE-5722

The Bootable JAR boot artifact is no more shading org.jboss:jboss-modules. It is expected that this assembly is done by the Bootable JAR maven plugin.

The Bootable JAR Maven plugin used by tests is updated to the latest version (required upgrade).

Diff: https://github.com/wildfly-extras/wildfly-jar-maven-plugin/compare/5.0.2.Final...6.1.1.Final

@jmesnil this is the only one I need a review on, the others I can approve myself if they pass as a set.


GLTF model rendering incorrectly with NFT marker

Hi all,
I'm currently working on a project where we use NFT markers to place our 3D models. Those 3D models are working correctly with the typical Hiro marker but when using NFT, the model renders quite weirdly.
For example, the further you get, the least layers of the model you see and whenever you get closer, layers(textures) start to show up, which makes it quite useless at this moment for our implementation.
I believe this is a bug, since it's not happening with standard markers or different 3D viewers.
Example images:
https://i.stack.imgur.com/cDRk2.jpg
https://i.stack.imgur.com/A1FpE.jpg

This is still the case. Anybody has an idea on what can be the cause?

use this
renderer="logarithmicDepthBuffer: true;"
inside your  attribute


Remove header in README

Add example for del-wed in command summary
Change point of contact in index.md
Add more use cases in the DG

LGTM!


Could not list roles , in  "Adding a new workflow definition"> "Workflow template: multi-step user / role approval".

Describe the issue:
unable to list role in Workflow Definition >  "Add Approval Step.",
If select Domain as "ALL_USER_STORE_DOMAINS" & search it displaying "Internal/admin" only., even if there are roles available in Primary user store -a role with required permissions.
Tested with tenant and super user
How to reproduce:

Login to Management console
Create 2 roles
1 Role1 > All permissions
2.2 Role2 > Login
Human Tasks > View Task List
Workflow Management > BPS Profiles >View Permisstions
Add a New Workflow Definition
Provide a name for a New Workflow Definition
Set the required approval levels.
add an approval level, click Add Approval Step.
search a user role in a specific user store, select the Search Roles radio button. or Enter the role name and click Search Roles.
roles are not displaying

Roles with required permissions in Primary user store

Only display when select "ALL_USER_STORE_DOMAINS"

When select Primary User store

Environment information (Please complete the following information; remove  any unnecessary fields) :

Product Version: 5.11 Beta6 Snapshot
OS:  Mac
Database:H2
Userstore: LDAP

I think this is expected. @ashensw can you confirm? Don't we support groups here?
I think we need to track this in the migration client. @Buddhimah

As per the issue description, it seems here @NilukaSripalim has created groups not roles. So I think it's expected to not show them when Search roles in the Add workflow path. If we create a role by using internal domain that is getting listed properly in add workflow. So @IsuraD as it seems it does not support groups here.

This issue is being closed due to extended inactivity. Please feel free to reopen it if further attention is needed. Thank you for helping us keep the issue list relevant and focused!


Question:

Is there a way to support a verb syntax? e.g. by nested DUs or something.
We have a tool that needs verbs like
git pull blabla

Is this possible? Or what would need to change to support that (I might be able to give it upstream, if I knew what needs extension)

You can sort of achieve this by using FirstAttribute on your verbs. I think this is how the guys at Paket have done it. I recognize that this is kind of awkward, since you have to write a lot of parsing logic on your own. Let me also refer you to this discussion.

Well, you idea of supporting multiple DUs would pretty much exactly correspond to that. Mind you, if you then set all of them to first, you have verbs. (Maybe then you'd want to call them without -- but that's a detail then)

Fixed in #54


Rustls upgrade fix

This is the simplest solution that gets rid of the error:  #1389
thread 'main' panicked at /home/chona/.cargo/registry/src/index.crates.io-6f17d22bba15001f/rustls-0.23.12/src/crypto/mod.rs:259:14:
no process-level CryptoProvider available -- call CryptoProvider::install_default() before this point

on cargo run.
I'm not sure if ring is the option we want nor if run_cli is the right place to call that install.

This is blocked on #1401

This is blocked on #1401

not exactly. however
allowing Nacho to run the full test suite is maximum priority and will have to happen before we can expect him to perfect this fix

Sorry I was not aware of the state of this PR when I wrote #1426. This looks good but we will also have to delete the crypto provider install from netutils as this is called multiple times which causes an error. Would you mind if we closed this for #1426 ?

I'm fine with closing this one. Didn't do it already yesterday only cause @zancas  asked me to add a test, documenting and some other stuff on #1426 and I wasnt sure how to collaborate on your PR. What is our flow in those cases? commit directly on it? PR on it? So far i got working on a local branch and was planning on PRing into yours.

Sorry I was not aware of the state of this PR when I wrote #1426. This looks good but we will also have to delete the crypto provider install from netutils as this is called multiple times which causes an error. Would you mind if we closed this for #1426 ?

I'm fine with closing this one. Didn't do it already yesterday only cause @zancas asked me to add a test, documenting and some other stuff on #1426 and I wasnt sure how to collaborate on your PR. What is our flow in those cases? commit directly on it? PR on it? So far i got working on a local branch and was planning on PRing into yours.

I commented on your PR as I think a doc test is difficult in this case but good practice for functions that can be unit tested. So in most cases the flow would be to PR into my branch. However, in this case I am happy for you to just PR into dev and I'll close mine or push directly to my branch if your have collaborator rights (I'm not sure if you being part of the organisation allows this by default). It's up to you really

closed for #1426


This cannot be inferred during runtime based on # lines because empty lines will be stripped during the parsing process. This is #104

resolved


Remove scroll listener preload script that is no longer used. r=vporof

Coverage increased (+0.06%) to 42.93% when pulling 14c88aa45b377150b0736dddcc39fb93e12fc810 on jsantell:remove-scroll into 38ebe1d266fda0588a48f110dc2bed372997a024 on mozilla:master.

Coverage increased (+0.06%) to 42.899% when pulling def68524f4cf1f904a22f419b92cd89e1c9cba57 on jsantell:remove-scroll into 9e572addf96a98c8723afbd77765fceb948783e9 on mozilla:master.


[HOLD for payment 2023-11-06] Refactor EmojiPickerMenu component for web to avoid unnecessary rerenders

Coming from here
Proposal
Refactor EmojiPickerMenu component for web to avoid unnecessary rerenders
Problem
Currently, the logic responsible for highlighting the emoji on hover is living in EmojiPickerMenu component, which contains a highlightedIndex state, keeping the index number of emoji that need to be highlighted. Since this index changes each time user hovers in/hovers out, it causes rerender of whole EmojiPickerMenu component (see video 1 - console is showing the amount of EmojiPickerMenu rerenders and the rendered components are highlighted in the browser).
Solution
To address this issue, the logic for highlighting should be moved to EmojiPickerMenuItem component to rerender only the hovered component. This will prevent the whole EmojiPickerMenu from rerendering (see video 2 - console is showing the amount of EmojiPickerMenu rerenders and the rendered components are highlighted in the browser).
Also attaching screenshots from the profiler - you can see that originally the whole picker menu is  rerendering on each hover change, and after fixing it the only thing that gets rerendered is a single menu item.
Issue OwnerCurrent Issue Owner: @muttmuure

I’m Tomasz from Callstack, I’d like to work on this job

Hi, after further investigation I noticed that hovering is not the only way of highlighting an emoji - there is also a possibility of navigating through the list with tab & arrows. This makes the proposed solution incorrect, as highlightedIndex is primarily used for the keyboard navigation. While EmojiPickerMenuItem doesn't directly contain this state, its's behavior is closely tied with it. Introducing separate logic for highlighting items on hover would not be a good fit here, as it would break switching between mouse hover and using a keyboard navigation. In this case, looks like using a highlightedIndex state is reasonable and moving away from it would require a significant amount of effort and would likely complicate the component further.
Therefore, I wonder what the next steps should be?

@mountiny yeah, it's not very common but works that way now 🤷♂  If there's no need of navigating from hovered emoji to it's closest elements by tab/arrows then it's doable. We can separate hover state as mentioned in the issue and then use highlightedIndex in the menu only to determine which element is currently focused. In that case we'll reduce rerenders of the menu when hovering, but keep in mind it will still happen when navigating with keyboard. I think if anyone use keyboard navigation after hover, we could just focus on the first item on the list. Let me know what you think

Brought this up for discussion in slack btw

Coming back from Slack discussion, we decided that we can stop moving from hover to focus state on closest emoji when using keyboard. Working on creating a pull request.

@TMisiukiewicz interesting, I would say we want to keep this but not if it will cost us some performance slow down
Can you handle this case please? I would consider this as a regression as we did not realize this feature was removed

I think we need to pay $500 to @akinwale for the first PR testing and review and $500 to @ntdiary for the second one cc @muttmuure

I think the payments would be $500 to @ntdiary and $500 to @akinwale, is that correct?

Or the second was a regression from the first one essentially so I guess $250 for @akinwale?

@muttmuure bump for payment. Thanks.

$500 - @ntdiary
$250 - @akinwale
Invited in Upwork: https://www.upwork.com/en-gb/ab/applicants/1727390644937363456/hires?filter=wentao&page=1

Contract extended

Has this been paid out? @muttmuure @ntdiary ?

Paid

@ntdiary @akinwale is this all sorted then?

@ntdiary @akinwale is this all sorted then?

Yes. I have also received payment, thanks.


[TW#26982] Bluetooth LE: Core 0 panic'ed on bt_controller_disable w. client connected OR esp_ble_set_encryption called

Environment

Development Kit:    none
Core (if using chip or module): ESP32-PICO-D4 rev. 1
IDF version: 35f9cb070
Development Env:		Eclipse
Operating System:		Debian 9
Power Supply:                external 3.3V

Problem Description
I have found the exact same error message (see log below) to be caused under two similar circumstances:

The ESP BT Controller is disabled via esp_bt_controller_disable() while a client is still connected. This does not throw any other error about the client connection still being on before it crashes.
The ESP had a connection with a client, during which a esp_ble_set_encryption(ID, ESP_BLE_SEC_ENCRYPT) was called. The client then disconnects without producing an error. On the following esp_bt_controller_disable(), the exact same crash is produced.

Expected Behavior
No crash should happen when disabling the BT Controller. If disabling the BT controller without first disabling the Bluedroid controller is an invalid task, a warning should be attached to the disable function, either in the README or during runtime.
Actual Behavior
The ESP crashes with an unrelated and hard to trace error message, whose real reason can only be found out with trial and error.
Steps to repropduce
No external circuitry is needed. Compile the following main:
https://gist.github.com/Xasin/475d2e237f4799ac1980fe481603ceaa
And connect to the ESP at boot-up. Stay connected until it disables BT, then observe the crash.
Due to the nature of the error message (prvGetExpectedIdleTime is in the logs), Tickless Idle Mode must most likely be enabled for this to work.
Debug Logs
BT: Disabling controller
Guru Meditation Error: Core  0 panic'ed (LoadProhibited). Exception was unhandled.
Core 0 register dump:
PC      : 0x4004baaa  PS      : 0x00060031  A0      : 0x800875ad  A1      : 0x3ffbe650
A2      : 0x00000000  A3      : 0x00000000  A4      : 0x8008d8b8  A5      : 0x3ffcb120
A6      : 0x00000003  A7      : 0x00060223  A8      : 0x00000000  A9      : 0x3ffb00d8
A10     : 0x0000000a  A11     : 0x3ffbc930  A12     : 0x00000000  A13     : 0x3ffbc920
A14     : 0x3ffbeda0  A15     : 0x00000000  SAR     : 0x00000020  EXCCAUSE: 0x0000001c
EXCVADDR: 0x00000048  LBEG    : 0x4008ddfa  LEND    : 0x4008de01  LCOUNT  : 0x00000000
0x4008ddfa: xHaveReadyTasks at /opt/ESP/esp-idf/components/freertos/tasks.c:4961
 (inlined by) prvGetExpectedIdleTime at /opt/ESP/esp-idf/components/freertos/tasks.c:2191

0x4008de01: xHaveReadyTasks at /opt/ESP/esp-idf/components/freertos/tasks.c:4961
 (inlined by) prvGetExpectedIdleTime at /opt/ESP/esp-idf/components/freertos/tasks.c:2191

Core 0 was running in ISR context:
EPC1    : 0x4004baaa  EPC2    : 0x00000000  EPC3    : 0x00000000  EPC4    : 0x00000000

Backtrace: 0x4004baaa:0x3ffbe650 0x400875aa:0x3ffbe670 0x40084f95:0x3ffbe6b0 0x4008871d:0x3ffbe6d0 0x40089437:0x3ffbe6f0 0x40082cba:0x3ffbe710 0x4000bfed:0x00000000
0x400875aa: r_lld_evt_schedule at ??:?

0x40084f95: r_ea_finetimer_isr at ??:?

0x4008871d: r_rwbt_isr at ??:?

0x40089437: r_rwbtdm_isr_wrapper at intc.c:?

0x40082cba: _xt_lowint1 at /opt/ESP/esp-idf/components/freertos/xtensa_vectors.S:1105

Rebooting...

Additional requests
It would be nice to have a BLE implementation that follows the whole "low energy" thing. As such, having the BT controller stack not keep the ABP max frequency lock during the entire time it's enabled, but instead only when needed, would be very nice to have. I would like to inquire if this is doable, or if efforts are already being made in this direction.

@Xasin ,Sorry,  I will fix this crash.

@Xasin, we have fixed the bug, please updated to the latest IDF and try, thanks.

@Weijian-Espressif, I haven't run into a crash similar to this in a bit, so I would say it's been fixed.
My BLE code is running smoothly now.
I do have a problem with my BT SPP code (crash upon disable then enable), and will have to make another issue about that ^^'


put selectSensorCell in a header file so it's visible before its own use

Building from rogerlinndesign/linnstrument-firmware using arduino SDK 1.6.9 fails for a couple reasons.
One of them is the use of selectSensorCell in two files before (or absent) any declaration.
I'm mystified how this can work in master, perhaps special whole program optimisation or other compile flags are used.
NOTE: I have no idea about the consequences of the use of the keyword inline in the actual definition of this function if it's not declared with inline.  Some thought required.

Looking at https://www.arduino.cc/en/Hacking/BuildProcess it seems that the IDE is supposed to concatenate all the source files 'with no extension' together.  Sounds like it would do the trick, except 1) files have the extension 'ino'.  They are displayed without extension in the tab titles, does that count?  if not, something else is going wrong.

This change affects 1.6.6 online. in light of the response to
[linnstrument-firmware] Arduino libraries accepting char * require const (#22)
where 1.6.4 is chosen as the standard SDK, I see no action required on this issue.
If dev ever needs to move to 1.6.7, the problems will re-present themselves without preserving this issue open.

I moved it in front together with other pre-declarations that were needed for 1.6.5 and earlier.


fix: file formats

All file formats but .mov fail to record.
I actually am not quite sure why this happens, file formats in video do not make as big of a difference as you would expect. However, still needs to be fixed.

Fixed in v1.1


Consistency of controllable components

We need a more consistent approach to how our components with internal state can be used in a controlled and an uncontrolled way. In general, components are controlled by supplying it with a prop that controls some state (i.e., checked) and an event callback prop that triggers when that state is trying to change internally (i.e., onChange).
In other words, controlling a component requires two props to be controlled. Here is what I would propose:

A state prop

When defined, this should set the component's initial internal state.
When undefined, the component should define its initial state.

An event callback prop

When defined, user interaction effects should be passed to the callback, having no effect on internal state.
When undefined, user interaction should change internal state.

State defined
State undefined

Callback defined
Controlled
Controlled but broken*

Callback undefined
Initial state controlled
Uncontrolled

* If the callback is defined but the state is not, nothing will happen when the event occurs.
@JRebella, does this match with your expectations?

Below are all the components that meet these criteria in some way, and how they match or don't match this pattern. I'll update this list as I find more issues.
Checkbox & Radio
Both of these components wrap Choice, which itself is an <input type={radio/checkbox}> under the hood. We're using the DOM interface for this (HTMLInputElement), which exposes the following two props:

state: checked
event: onChange
behaves as outlined in the proposal

Disclosure
Since our disclosure wraps the details element, the internal state that must be controlled is the details' open attribute. Since our disclosure animates open/closed, we've broken the events into 6 callback props, only two of which affect the internal open state.

state: isOpen (open/closed)

This is ignored after the first render, making it impossible to fully control this component. Note: this should be considered a bug.

events: onOpenStart triggers when isOpen becomes true & onCloseEnd triggers when isOpen becomes false.

Returning false causes these callbacks to do nothing.
Returning a Promise will await that promise and then initiate the transition. This gives you time to update your state, but it is not then used to update the component.

does not behave as outlined in the proposal

Switch

state: checked (on/off)
event: onToggle.

This triggers when the internal state changes.
Unintuitively and perhaps incorrectly, the onClick event makes checked controllable. This should probably be fixed in a refactor.
Side note: we should probably deprecate this and rename it onChange for consistency.

does not behave as outlined in the proposal

Dropdown
This controls two internal pieces of state: isOpen (whether the list box is rendered), and selected (what option is selected).

events for isOpen: onRequestOpen & onRequestClose.
event for selected: onChange
behaves as outlined in the proposal

It also occurred to me that all of our BaseInput-derived components have multiple controlled props:

errors + onValidate - this is completely custom to the design system.
value + onChange - derived from the HTMLInputElement interface.
checked + onChange - derived from the HTMLInputElement interface.

Hey @sh0ji thanks for taking the time to improve this, I think it's very important
I agree on what you describe that the component should act in one way or to other depending on the props but I think we should try to match the standard that React already has in place for <input /> for example
The pattern I see in the props is the following:

value: Should only be defined when the component will be controlled
defaultValue: The default value of the input, should only be defined when the component will be uncontrolled
onChange: callback that will be called every time no matter if controlled or uncontrolled. If controlled it's usually used to change the external state (value prop). Although uncommon, it can also be used in uncontrolled components to trigger side effects (for example trigger form validation once one of the uncontrolled inputs is interacted with)

So bottom line is, the value prop should be the "source of truth" for determining if the component will be used as controlled or uncontrolled. If it's undefined then the component is uncontrolled, if it's defined, then it's controlled
I ran some tests on https://codesandbox.io/s/objective-dream-tvy8l?file=/src/App.js
There's some border cases and some warnings that react will throw in the console if you provide the wrong props. For example if you provide value and defaultValue at the same time, the input will be controlled and defaultValue will be ignored
There's also some border cases like when the value prop goes from defined to undefined (or vice versa) along the lifetime of the component which also causes react to throw a warning that this should not happen

If we follow the React's criteria, then checkbox should be updated so that the following code renders a checked checkbox that can't be toggled:
<Checkbox
    checked={true}
>
    Checkbox
</Checkbox>

Great point. defaultValue and defaultChecked are defined by the DOM spec for the HTMLInputElement interface, so we should use those for initial values and we should probably mirror that convention for custom controllable props.
We'll want to be careful about this change though, since breaking existing functionality would require a major version bump. We'll want to add this functionality while continuing to support the current functionality (even though it's inconsistent/confusing), and add deprecation warnings that recommend switching to the new functionality. Will that work for you?

We'll want to be careful about this change though, since breaking existing functionality would require a major version bump. We'll want to add this functionality while continuing to support the current functionality (even though it's inconsistent/confusing), and add deprecation warnings that recommend switching to the new functionality. Will that work for you?

Yes of course! Makes total sense to me

Issue linked to JIRA Stories: [NDS-38] [NDS-39] [NDS-40] [NDS-41] [NDS-42] [NDS-43]


more snippets

a snippet for if-else blocks would be nice.
maybe even another one for the one-line version?
UPDATE
why not add alot more snippets? i found snippets in the atom/fortran package:
https://github.com/dparkins/language-fortran/blob/master/snippets/language-fortran.cson

I am fine with adding more snippets but I don't have the time to do it myself. PRs are welcome though

Done in #123


Add Feather anchor to the IndexPage

self explanatory, just trying to cut you some time,
Great project by the way, every project I do, I have to create an Icon component for Feather.
Looking forward to use and contribute to this one :tada:

Awesome, thank you for this!


Added ability to specify controlsTpl in a custom directive

I added the ability to specify a "controlsTpl" property, overriding any referenced theme, in a custom directive. I found this useful when creating a custom xeditable directive that uses a custom, composite directive, made up of Angular Material elements.
The controls wrapper "md-input-container" was being applied over an existing one. This override allows me to use a DIV or something else (other than what's specified in the theme) and avoid having nested "md-input-container".

Hi @ttonyh, thanks for you PR.
To be able to merge it - could you also add documentation how to use it and unit test.

@ eugef I'd be happy to. What's the documentation procedure for this project?

@ttonyh , just add information about new attribute to the docs/jade/reference.jade and also nice to add demo example as it is done for some other attributes.

@eugef Docs have been updated per your request, please review when you get the chance. Thanks :-)

You don't need the index.html, that gets generated on build.
For the demo example, create a new folder in docs/demos called custom-template or what ever seems appropriate.   Create a controller.js, desc.md, test.js, view.html (or copy them) and put in your example and tests.
You will also need to update structure.js with your new example

@ckosloski Ok, will do. Thank you!

@ttonyh can you update your request?

@ttonyh please include only src/ files in your PR

@ttonyh Can you remove all the generated files from your request?

@ttonyh any update on this?


Fix small typo in concepts/architecture/nodes

Fix a small typo in the docs for concepts/architecture/nodes
"informaton" should be "information"

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.
It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address.  Check your existing CLA data and verify that your email is set on your git commits.
If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at<EMAIL_ADDRESS>

I have signed the CLA.

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.
It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address.  Check your existing CLA data and verify that your email is set on your git commits.
If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at<EMAIL_ADDRESS>

Attempting to sign the CLA again

/assign @tengqm


Breaking change [CommitBehavior] added to Preview Posting

Apparently a relatively new feature [CommitBehavior] has been added to Gen. Jnl.-Post Preview in 18.1.26444.
This breaks our solution where relatively complex prevalidation procedures must be run in the same manner during posting preview as in ordinary posting.
As far as I can tell, the only reasonable way for us to log the issues encountered during the validation, is to commit the changes to the log table. How do we do this now, when we run into "Commit if prohibited in the current scope." ?

We have added an integration event you can use to perform commits before the preview posting begins.
It is part of codeunit 19 "Gen. Jnl.-Post Preview" and has the following declaration:
[IntegrationEvent(false, false)]
local procedure OnBeforeRunPreview(Subscriber: Variant; RecVar: Variant)

And please use temporary table for your logs, like we do in Posting Preview.

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.


Add default namespace default to ServiceAccount definition in example yaml

This is to catch the case where users find-replace the default namespace with another namespace (say, goldpinger but don't change it for the ServiceAccount definition.
Issue number of the reported bug or feature request: #
Describe your changes
Added a namespace key under metadata with corresponding namespace (default) used elsewhere in the sample yaml.
Testing performed
Tested on prem, k8s 1.27 with kubectl apply -f file.yaml.
Additional context
N/A.

Thank you so much for your contribution. This looks good. We do need a DCO before we can approve this - please see this link: https://github.com/bloomberg/goldpinger/blob/master/CONTRIBUTING.md#contribution-licensing for details.

@skamboj did I not already do it in my first commit? LMK if something is wrong syntactically:

@skamboj did I not already do it in my first commit? LMK if something is wrong syntactically:

Sorry the reason it failed is given here: https://github.com/bloomberg/goldpinger/runs/23516585421
Commit sha: [bda1235](https://github.com/bloomberg/goldpinger/pull/142/commits/bda1235c406be80ee1c3fa6189b6d3c8dd193889), Author: ABC Taylor, Committer: ABC Taylor; Expected "ABC Taylor [abc@abctaylor.com](mailto:abc@abctaylor.com)", but got "Andrew Taylor [abc@abctaylor.com](mailto:abc@abctaylor.com)".

I think it was expecting ABC Taylor and got Andrew Taylor instead.

@skamboj I have now --amended the message.


add provider checking based on model name and provider

This might not be totally connected to this PR but it would be nice if mentat didn't disable the user input box if they get a 404 from the api. For instance if I set my model to test I get the following (reasonable) error but then I can't enter anything into the box again

This might not be totally connected to this PR but it would be nice if mentat didn't disable the user input box if they get a 404 from the api.

Agreed but it might be better to do in a separate PR


Feature: Active state for markers

I'm looking for a feature that allows setting an active marker either in the cartodb ui or in the js API, and being able to set the selected feature to active, thus changing it's marker.
Currently we use a hack, where we have generated circle polygons that represent the clickable area, and that gets highlighted.

There has been no activity on this issue for several months and that's why we are closing it (automatically). If you think this still needs to be addressed please reopen it. The good news is that we are now working on the next version of CARTO.js, stay tuned.


[zh-cn][Umbrella] API reference pages to sync.

We have already translated some of the API references into Chinese. The following are pages that still need to be translated.

[ ] DaemonSet-v1   @sarazqy  #34985

855 content/en/docs/reference/kubernetes-api/workload-resources/daemon-set-v1.md

[ ] Job-v1  @sarazqy   #34746

896 content/en/docs/reference/kubernetes-api/workload-resources/job-v1.md

[ ] ReplicaSet-v1   @windsonsea   #34889

805 content/en/docs/reference/kubernetes-api/workload-resources/replica-set-v1.md

[ ] CronJob-v1  @sarazqy   #34748

802 content/en/docs/reference/kubernetes-api/workload-resources/cron-job-v1.md

[x] HPA-v1  @twilight0620    #34747

791 content/en/docs/reference/kubernetes-api/workload-resources/horizontal-pod-autoscaler-v1.md

[ ] StatefulSet-v1  @yaolixin-creater  #34859

888 content/en/docs/reference/kubernetes-api/workload-resources/stateful-set-v1.md

[ ] HPA-v2  @zhangxyjlu   #35125

1357 content/en/docs/reference/kubernetes-api/workload-resources/horizontal-pod-autoscaler-v2.md

[ ] HPA-v2beta2   @zhangxyjlu

1343 content/en/docs/reference/kubernetes-api/workload-resources/horizontal-pod-autoscaler-v2beta2.md

[ ] PodTemplate-v1   @qlijin   #34319

583 content/en/docs/reference/kubernetes-api/workload-resources/pod-template-v1.md

[ ] Pod-v1  @ydFu  #34927

3340 content/en/docs/reference/kubernetes-api/workload-resources/pod-v1.md

[ ] ReplicationController-v1  @windsonsea   #34891

805 content/en/docs/reference/kubernetes-api/workload-resources/replication-controller-v1.md

[ ] Deployment-v1   @windsonsea #34892

868 content/en/docs/reference/kubernetes-api/workload-resources/deployment-v1.md

[x] CRD-v1   @zhangxyjlu   #34926

1161 content/en/docs/reference/kubernetes-api/extend-resources/custom-resource-definition-v1.md

[x] ValidatingWebhookConfiguration-v1   @yaolixin-creater  #34870

618 content/en/docs/reference/kubernetes-api/extend-resources/validating-webhook-configuration-v1.md

[ ] MutatingWebhookConfiguration-v1  @donghui21  #34991

628 content/en/docs/reference/kubernetes-api/extend-resources/mutating-webhook-configuration-v1.md

[x] TokenRequest-v1  @windsonsea   #34741

185 content/en/docs/reference/kubernetes-api/authentication-resources/token-request-v1.md

[x] FlowSchema-v1beta2  @windsonsea  #34806

800 content/en/docs/reference/kubernetes-api/cluster-resources/flow-schema-v1beta2.md

[x] RuntimeClass-v1   @windsonsea   #34749

518 content/en/docs/reference/kubernetes-api/cluster-resources/runtime-class-v1.md

[x] Node-v1  @yaolixin-creater   #34979

983 content/en/docs/reference/kubernetes-api/cluster-resources/node-v1.md

[x] PriorityLevelConfiguration-v1beta2  @windsonsea  #34827

702 content/en/docs/reference/kubernetes-api/cluster-resources/priority-level-configuration-v1beta2.md

[x] Event-v1  @syxunion   #34482

651 content/en/docs/reference/kubernetes-api/cluster-resources/event-v1.md

[x] ComponentStatus-v1  @windsonsea   #34744

203 content/en/docs/reference/kubernetes-api/cluster-resources/component-status-v1.md

[x] LimitRange-v1   @windsonsea   #34779

606 content/en/docs/reference/kubernetes-api/policy-resources/limit-range-v1.md

[ ] NetworkPolicy-v1   @gangchen03   #35105

909 content/en/docs/reference/kubernetes-api/policy-resources/network-policy-v1.md

[x] PDB-v1   @yaolixin-creater  #34937

828 content/en/docs/reference/kubernetes-api/policy-resources/pod-disruption-budget-v1.md

[ ] ResourceQuota-v1  @donghui12  #34933

783 content/en/docs/reference/kubernetes-api/policy-resources/resource-quota-v1.md

[x] PSP-v1beta1   @windsonsea   #34789

739 content/en/docs/reference/kubernetes-api/policy-resources/pod-security-policy-v1beta1.md

[x] EndpointSlice-v1   @Michelle951   #34928

666 content/en/docs/reference/kubernetes-api/service-resources/endpoint-slice-v1.md

[ ] Endpoints-v1  @shixiuguo   #34641

657 content/en/docs/reference/kubernetes-api/service-resources/endpoints-v1.md

[x] IngressClass-v1 @qlijin     #34723

503 content/en/docs/reference/kubernetes-api/service-resources/ingress-class-v1.md

[x] Service-v1   @donghui12   #34849

963 content/en/docs/reference/kubernetes-api/service-resources/service-v1.md

[ ] Ingress-v1   @shixiuguo   #34654

911 content/en/docs/reference/kubernetes-api/service-resources/ingress-v1.md

/triage accepted
/language zh
/help

I would like to take TokenRequest-v1 at a start :)

I would like to take pod-v1.md.
/assign

I would like to handle:
custom-resource-definition-v1

I would like to handle:
EndpointSlice-v1
/assign

I would like to handle:
service-v1
/assign

I would like to handle: service-v1 /assign

@donghui12 Thanks for stepping out. Please be sure to check existing API reference translations before working on the new ones. There are quite some tricky issues to handle when translating API reference. Looking forward to your contribution.

I would like to handle:
StatefulSet-v1
/assign

I would like to handle:
ResourceQuota-v1
/assign

I would like to handle:
DaemonSet-v1
/assign

I would like to handle:
ValidatingWebhookConfiguration-v1
/assign

Please reciew @Michelle951 @ydFu

I would like to take:
NetworkPolicy-v1
/assign

I would like to handle:
MutatingWebhookConfiguration-v1
/assign

I would like to handle:
Node-v1
/assign

I would like to handle:
HPA-v2 ：horizontal-pod-autoscaler-v2.md
HPA-v2beta2 ：horizontal-pod-autoscaler-v2beta2.md

/open

/reopen
This issue is still in progress.

/reopen

/reopen
#34985 should not close this yet.

We have completed all tasks!  🎉🎉🎉

🎉🎉🎉

All tasks completed. Wonderful job, team!


Construct JavaScript Objects with Functions - inconsistent with previous challenge

For consistency, it should be:
var Car = function() {
  this.wheels = 4;
  this.engines = 1;
  this.seats = 5; // was = 1;
};

It's just an example.  It doesn't materially affect the challenge in any way.
Thanks and Happy Coding.


Content modal: Prevent right click

As per design request.
Fixes #828

Note that master won't show any content because of errors until https://github.com/endlessm/kolibri-explore-plugin/issues/817#issuecomment-1725936890 is fixed.


Remove ability to put decimal in price

Fixed in https://github.com/macterra/artx-market/commit/aed18e8b81f8882b46025f44f1e983ba8318ffb2

Tested


[MISC] add link for rfc3339, fix typo

In https://github.com/bids-standard/bids-validator/pull/1019 I wanted to add the validation of the newly introduced "fractional seconds" that we allow for AcquisitionTime in scans.tsv files.
While discussing that code, we stumbled over potential incongruencies between RFC3339 and the way that standard is implemented in BIDS.

particularly with regards to the timezone (see https://github.com/bids-standard/bids-validator/pull/1019)

In this PR we may clarify/fix some aspects ... or in the least we'll add a link and fix a typo (see
de4ab9f )

I now also link to the Units section from the modality specific MEG, EEG, and iEEG sections to

avoid duplicating explanations
drop the unspecific reference to ISO8601 (we are using a specific subset of this standard)

while doing that, I found the following sentence:

It does not need to be fully detailed, depending on local REB/IRB ethics board policy.

repeated across the files.
For now I dropped it from the three files and added it to the Units section. However, I think we can drop this sentence completely, because it is more or less covered in the point on anonymization that we have.


Changed expert mode enabled splash screen on stax

Also bumped the version to 3.0.3

Creating another PR for audited code which includes these changes


Autoplay doesn't work correctly in vertical

Is this a bug report, a feature request, or a question?
This is a bug report

Have you followed the required steps before opening a bug report?
(Check the step you've followed - put an x character between the square brackets ([]).)

[x] I have read the guidelines regarding bug report.
[x] I have reviewed the documentation in its entirety, including the dedicated documentations :books:.
[x] I have searched for existing issues and made sure that the problem hasn't already been reported.
[x] I am using the latest plugin version.
[x] I am following the issue template closely in order to produce a useful bug report.

Have you made sure that it wasn't a React Native bug?
Yes

Is the bug specific to iOS or Android? Or can it be reproduced on both platforms?
I just try it in ios. don't know the effect in android.
Is the bug reproductible in a production environment (not a debug one)?
i don't have try. and just in debug discover it.
bug i think it will also happened in release

Environment
Environment:
React: 16.10.2
React native: 0.61.2
react-native-snap-carousel: 3.8.2
Target Platform:
Android (6.0)
iOS (10.3) 13.2

Expected Behavior
Not Vertical
it's great.

autoplay can work correctly.
don't have any behavior when i touch it

(Write what you thought would happen.)
Actual Behavior
when i in "vertical"  mode.

autoplay can't work correctly.
it will scroll to the above item when i touch it

(Write what happened. Add screencasts/screenshots!)
Reproducible Demo
                <Carousel
                  vertical  \\ you can remove it get the right behavior
                  loop
                  useScrollView
                  autoplay
                  lockScrollWhileSnapping
                  data={[1, 2, 3]}
                  renderItem={({ item, index }) => <Text>{item}</Text>}
                  itemHeight={100}
                  sliderHeight={100}
                  \\ itemWidth={100} \\ should remove \\ when your remove the vertical
                  \\ sliderWidth={100} \\  like above
                />

(Paste the link to a Snack example in which the issue can be reproduced. Please follow the guidelines for providing a Minimal, Complete, and Verifiable example.)

Steps to Reproduce

(Write your steps so that anyone can reproduce the issue in the Snack demo you provided.)

copy the component above
make the vertical to true
make the autoplay to true, and touch it

try this out: https://github.com/archriss/react-native-snap-carousel/issues/353#issuecomment-480874780


SAKIII-4875 - Content authoring

https://jira.sakaiproject.org/browse/SAKIII-4875

Squashed and merged


Automation that checks that keys haven't changed and that nodes can connect

It's hard to tell if there is an issue joining the network

https://github.com/CodaProtocol/coda/pull/2888 has a partial approach to half this issue

"The real heart of this task is a CI job that connects to our running testnet" -- @cmr


Adding Gamma World 4e Sheet

Changes / Comments
Roll20 Requests
Comments are very helpful for reviewing the code changes. Please answer the relevant questions below in your comment.

[ ] Does the pull request title have the sheet name(s)? Include each sheet name.
[ ] Is this a bug fix?
[ ] Does this add functional enhancements (new features or extending existing features) ?
[ ] Does this add or change functional aesthetics (such as layout or color scheme) ?
[ ] If changing or removing attributes, what steps have you taken, if any, to preserve player data ?
[ ] If this is a new sheet, did you follow Building Character Sheets standards ?

If you do not know English. Please leave a comment in your native language.

Yes - GammaWorld4e
No
N/A (new sheet)
N/A (new sheet)
N/A (new sheet)
Yes

Character Sheet Info Roll20 Internal Use only.


Add documentation for what functions invoked in model.train as in model.predict

#148
Updated the docs of the unionml.model.Model.train method to show what functions are invoked as done in the model.predict method.

No, thank you @cosmicBboy 👍🏼


undefined method `dump' for Psych:Module

I'm getting this error on heroku, any idea where this might come from? I'm using version 0.7.6
undefined method `dump' for Psych:Module
 vendor/bundle/ruby/1.9.1/gems/ice_cube-0.7.6/lib/ice_cube/schedule.rb:256:in `to_yaml'

Thanks!

I think it might be because of the ruby version (1.9.1) on heroku. I've added the Psych gem (https://github.com/tenderlove/psych) and it works now. Hopes this helps someone :)

Ah yes, if it can find Psych, it'll try to use it - I ownder why Pysch#dump wasn't defined though

I had the same issue deploying to Heroku this morning. I've been deploying an app with ice_cube to heroku for weeks without issue.
The problem was solved by adding psych to my Gemfile. This introduced some issues with bundling locally, which was resolved by installing bundler-1.1.rc.7.
I suspect this problem has arisen due to a recent change in the Heroku environment.

Thanks for the follow-up ben, must appreciated


Only list special categories in TOC if used

Previously, if options.toc was set to 'categories', the special categories ('Methods' and 'Properties') were both added to the TOC even when there were no entries for either or both of these categories, as shown in the following output:
## `Methods`

<!-- /div -->

<!-- div -->

## `Properties`

<!-- /div -->

<!-- /div -->

<!-- div class="doc-container" -->

Hi @DannyNemer could you rebase this?

Done!

Rock, thanks!


Scheduled snapshots don't work properly

Describe the bug
If you want to schedule a snapshot on an attached existent disk, this is the output:

Environment
Terraform v1.6.1

0cd1fd45

To Reproduce
Use this:
module "vm-disks-example" {
  source     = "./modules/compute-vm"
  project_id = local.project_id
  zone       = local.zone
  name       = "testvm"
  network_interfaces = [{
    network    = local.network
    subnetwork = local.subnet
  }]
  attached_disks = [{
    name        = "test"
    size        = 10
    source_type = "attach"
    source      = "zone/${local.zone}/disks/test"
    snapshot_schedule = "my-schedule"
  }]
  service_account = {
    auto_create = true
  }
  snapshot_schedules = {
    my-schedule = {
      schedule = {
        daily = {
          days_in_cycle = 1
          start_time    = "03:00"
        }
      }
    }
  }
}

NB: "test" disk must exists.

Expected behavior
Scheduled snapshot should be created.
Result
The requested URL /compute/v1/projects/PROJECT_ID/zones/us-central1-a/disks/zone/us-central1-a/disks/test/addResourcePolicies?alt=json was not found on this server.
Additional context
To fix the error, you have to use disk name instead of disk path. This PR fixes the issue: https://github.com/GoogleCloudPlatform/cloud-foundation-fabric/pull/1983

Does it work if you set it up as:
  attached_disks = [{
    name        = "test"
    size        = 10
    source_type = "attach"
    source      = "test"
    snapshot_schedule = "my-schedule"
  }]

The docs say to use disk name (set source to the name (for zonal disks)).

I missed this part of docs, sorry! Thank you :)


How to use this plugin to migrage from the option templateContent of html-webpack-plugin

The html-webpack-plugin has supported the option templateContent which we can use to generate a file with an inline template, is that plugin support when I try to migrate from webpack to vite?

I have changed to use @rollup/plugin-html, thanks.


Section Tags Classroom is very confusing

https://github.com/sendgrid/docs/blob/develop/source/Classroom/Build/Add_Content/substitution_and_section_tags.md
This documentation is very confusing, and has technical errors. Should be reformatted to provide and Example JSON & Resulting Body for each setup.

Hello @jacobmovingfwd,Thanks for your suggestion or question! In an attempt to clear out our backlog,                                              we are closing out issues over 90 days old.                                             If this is still an issue, please feel free to reopen it.                                              I've added it to our internal backlog.

I have requested a pull where I made the necessary changes here https://github.com/sendgrid/docs/pull/2959

thanks Kyle!!


Color customization

This pr adds the ability to customize the color of nearly all elements of a log line.
I don't expect this pr to necessarily get merged, but I figured it would be worth trying since that's what I, as a user want. In case this does not get merged I can just keep maintaining my fork no problem.
I made sure the current log colors are the default. If wanted I could add a new predefined default theme, but I don't think this is necessary. I'm open to address any feedback
The following different kind of thing can be colorized in a log line (it is sorted in order of their usual appearance):
const (
	KindTime Kind = iota
	KindSourceFile
	KindSourceSeparator
	KindSourceLine
	KindMessage
	KindGroup
	KindKey
	KindSeparator
	KindValue
	KindErrorKey
	KindErrorSeparator
	KindErrorValue
)

I also changed tint.Err to not return a tintError since that's a weird behavior imo.
If let's say a library logs an error, the error is not being logged red unless they also depend on the tint module which is really annoying

I also changed tint.Err to not return a tintError since that's a weird behavior imo.
If let's say a library logs an error, the error is not being logged red unless they also depend on the tint module which is really annoying

That's a feature. It allows you to use different handlers in different environments, e.g tint in dev and slog's JSON handler in prod. You don't want your json log to contain ansi codes.

I'm not sure why this is needed then, I already use the json handler for production and I don't have any ansi codes in my production logs

It is needed because tint should not print every error in red color, but only those wrapped in tint.Err(...). And errors wrapped in tint.Err(...) should just be "normal" errors to all the other handlers.

Thank's for the effort, but I will not merge the changes. tint provides an opinionated output format, that can be customized to some extend via Options.ReplaceAttr (e.g. change level colors), or can be forked to tailor the output format to your liking. Also this PR degrades performance quite a lot.


Link Header CSS Performance

Is your feature request related to a problem? Please describe.
CSS is define in csthml like this:
   <link rel="stylesheet" href="~/mystylesheet.min.css" asp-append-version="true" />
Performance issue:
Browser must start read html code and link element to begin to request the stylesheet.
Solution:
Use Link header:
            Response.Headers.Add("Link", "</mystylesheet.min.css>; rel=\"stylesheet\"");
Now, when browser read header, it can start to request the css in parallel of html page.
Implemenation:
Add a attribute to link to add this link directly in the Link header:
   <link rel="stylesheet" href="~/mystylesheet.min.css" asp-append-version="true" header="true" />

I don't think the feature is well-supported across browsers. Example: https://bugs.chromium.org/p/chromium/issues/detail?id=19237
Do you have of a more recent listing that describes what the status for HTTP Link headers for is across browsers?

No, it is difficult to found browser compatiblity on it.

In the absence of standard support across browsers, I don't think it makes sense to support this feature.


i18n(es): Update of markdown-content.mdx, content-schema-containts-slug-error.mdx, invalid-content-entry-slug-error.mdx and publish-to-npm.mdx

What kind of changes does this PR include?

New or updated content
Translated content

Description

What does this PR change? Give us a brief description.

Multiple page updates based on these commits as follows:

markdown-content.mdx → 471f2388d6ef0d60211eea75afd683c6138d415d & f3b0625a51f54636e203f8650352cb7fc4c443b6

content-schema-containts-slug-error.mdx → 0de27116b410c0e68d3702ff6f944edc5235a12b

invalid-content-entry-slug-error.mdx → 0de27116b410c0e68d3702ff6f944edc5235a12b

publish-to-npm.mdx → e58d23c63167bcf2c96e9a8a7f171f63f3286b21, 9d4bd688365a562ccf013310d8840f3271c232d9 & c5f02333db29b2810d986025d9f418d22f7693a0

Note
cloudflare.mdx doesn't need update to spanish cause they fixed small typos which were translated properly based on these commits  471f2388d6ef0d60211eea75afd683c6138d415d & f3b0625a51f54636e203f8650352cb7fc4c443b6

Muchas gracias por el review @agustinmulet 🚀


trying to log message for missing keyword, difference between ["foo"] and at("foo")

I want to print a helpful message when a required keyword is missing from a json file. I mimicked the example code given here to print a message about a caught exception. Instead of printing “key 'foo' not found” it continued to print the less helpful “type must be number, but is null”. I eventually realized that the difference was not related to handling the exception—the default handler was fine—but it came down to how I wrote the keyword lookup. This produces “type must be number, but is null”:
float foo = properties["foo"];

While this produces what I wanted, “key ‘foo’ not found”:
float foo = properties.at("foo");

Is this an intentional/expected difference between [] and at()? And is the solution to my desire for more specific “keyword not found” error messages simply to use at() instead of []? Or is something more subtle going on?
(I’m using version 3.6.1)

Yes, properties["foo"] creates a new null entry if the entry isn't found and properties is not const.  If it is const, then it asserts (I think).  If you aren't sure if it's there, you need to use find() first to check, or at() with exception handling.

Thanks @gregmarr for the explanation. Performance of json reading is not a key issue in my application, it only happens at initialization. So I will replace [] with at() on nlohmann::json objects in order to get better error messages “for free.”


Also Concerning CHEBI:26167

The Incoming list of amino acids for CHEBI:26167 does not include tryptophan (CHEBI:27897) which is most definitely a side-chain proton donor for hydrogen bonds as evidenced by the function of the significant WWD motif in N-glycosyl transferase (PMID:21677752).

Tryptophan has now been added. Thanks


Prepare for release v1.14.12

Prepare for release v1.14.12
Summary of Changes
Minor Changes:

(v1.14) Generate SBOMs using Syft instead of bom (cilium/cilium#32750, @ferozsalam)
Improved background resynchronization of nodes. Before all nodes were being updated at the same time, now we spread updates over time to average out CPU usage. (Backport PR #32874, Upstream PR #32577, @marseel)
Introduce CLI commands to troubleshoot connectivity issues to the etcd kvstore and clustermesh control plane (Backport PR #32571, Upstream PR #32336, @giorio94)
ipsec: Improve CPU usage of cilum-agent in large clusters (Backport PR #32883, Upstream PR #32588, @marseel)
pkg/labels: print all leaf CIDRs, not just the last one. (Backport PR #32511, Upstream PR #28224, @squeed)

Bugfixes:

.github/workflows: fix digests file creation (Backport PR #32888, Upstream PR #32860, @aanm)
[v1.14] iptables: Do not install NOTRACK rules if IPv4NativeRoutingCIDR is nil (cilium/cilium#32650, @pippolo84)
cni: Reserve local ports for DNS proxy even if IPv6 is disabled (Backport PR #32787, Upstream PR #32725, @gandro)
Fix PromQL query in Cilium Metrics dashboard (Backport PR #32695, Upstream PR #32017, @mikemykhaylov)
Fix rare race condition afflicting clustermesh when disconnecting from a remote cluster, possibly causing the agent to panic (Backport PR #32695, Upstream PR #32513, @giorio94)
Fix: Ensure enabling metrics turns on identity GC metrics (cilium/cilium#32447, @jaredledvina)
Fixes accidentally ignoring the preflight.nodeSelector Helm value. (Backport PR #32695, Upstream PR #32548, @squeed)
ipsec: Safely delete Xfrm state (Backport PR #32704, Upstream PR #32450, @jschwinger233)
proxy: Re-enable proxy rule installation in native-routing mode for CEC (Backport PR #32483, Upstream PR #32367, @sayboras)
Remove deprecated hubble.ui.securityContext.enabled from hubble-ui deployment template (Backport PR #32888, Upstream PR #32338, @stelucz)

CI Changes:

ci: Filter supported versions of EKS (Backport PR #32888, Upstream PR #32304, @marseel)
ci: Filter supported versions of GKE (Backport PR #32695, Upstream PR #32302, @marseel)
ci: l4lb: Don't hang on gathering logs forever (Backport PR #32968, Upstream PR #32947, @joestringer)
ci: l4lb: gather more infos about docker-in-docker issues (Backport PR #32695, Upstream PR #32570, @mhofstetter)
ci: l4lb: restart docker-in-docker container on failure (Backport PR #32695, Upstream PR #32600, @mhofstetter)
eks: Don't use spot instances (Backport PR #32695, Upstream PR #32553, @michi-covalent)
GCP OIDC instead of SA creds. (Backport PR #32708, Upstream PR #30809, @viktor-kurchenko)
gha: test certificate generation methods in conformance clustermesh (Backport PR #32787, Upstream PR #32654, @giorio94)
Modify GitHub Actions Workflows to echo the inputs they are given when triggered by a workflow_dispatch event. (Backport PR #32503, Upstream PR #31424, @learnitall)
Use GH_RUNNER_EXTRA_POWER for CI image workflow (Backport PR #32503, Upstream PR #32402, @michi-covalent)
workflows: ignore "No egress gateway found" drops (Backport PR #32695, Upstream PR #32564, @jibi)
workflows: Remove stale CodeQL workflow (Backport PR #32695, Upstream PR #32084, @pchaigno)

Misc Changes:

(v1.14) Bump golang.org/x/net (cilium/cilium#32792, @ferozsalam)
background-sync: fix bootstrap issue and edge-case with 1 node (Backport PR #32874, Upstream PR #32630, @marseel)
bump cni plugins to v1.5.0 (Backport PR #32695, Upstream PR #32629, @antonipp)
Bump timeout of lint-build-commits.yaml (Backport PR #32787, Upstream PR #32746, @YutaroHayakawa)
chore(deps): update all github action dependencies (v1.14) (cilium/cilium#32495, @renovate[bot])
chore(deps): update all github action dependencies (v1.14) (cilium/cilium#32637, @renovate[bot])
chore(deps): update all github action dependencies (v1.14) (cilium/cilium#32720, @renovate[bot])
chore(deps): update all github action dependencies (v1.14) (cilium/cilium#32741, @renovate[bot])
chore(deps): update all github action dependencies (v1.14) (cilium/cilium#32842, @renovate[bot])
chore(deps): update all github action dependencies (v1.14) (cilium/cilium#32925, @renovate[bot])
chore(deps): update all github action dependencies (v1.14) (patch) (cilium/cilium#32638, @renovate[bot])
chore(deps): update cilium/cilium-cli action to v0.16.7 (v1.14) (cilium/cilium#32496, @renovate[bot])
chore(deps): update cilium/little-vm-helper action to v0.0.18 (v1.14) (cilium/cilium#32581, @renovate[bot])
chore(deps): update dependency cilium/cilium-cli to v0.16.9 (v1.14) (cilium/cilium#32836, @renovate[bot])
chore(deps): update dependency cilium/hubble to v0.13.5 (v1.14) (cilium/cilium#32949, @cilium-renovate[bot])
chore(deps): update docker.io/library/golang:1.21.10 docker digest to 16438a8 (v1.14) (cilium/cilium#32636, @renovate[bot])
chore(deps): update docker.io/library/ubuntu:22.04 docker digest to 19478ce (v1.14) (cilium/cilium#32924, @renovate[bot])
chore(deps): update docker.io/library/ubuntu:22.04 docker digest to a6d2b38 (v1.14) (cilium/cilium#32369, @renovate[bot])
chore(deps): update github/codeql-action action to v3.25.5 (v1.14) (cilium/cilium#32510, @renovate[bot])
chore(deps): update go to v1.21.11 (v1.14) (cilium/cilium#32895, @renovate[bot])
chore(deps): update hubble cli to v0.13.4 (v1.14) (cilium/cilium#32722, @renovate[bot])
chore(deps): update stable lvh-images (v1.14) (patch) (cilium/cilium#32723, @renovate[bot])
contrib: Remove CHARTS_PATH dependency (Backport PR #32695, Upstream PR #32328, @joestringer)
Docs: add note about AKS kube-apiserver entity (Backport PR #32695, Upstream PR #32464, @darox)
docs: ipsec: remove limitation for native-routing with L7 egress policy (Backport PR #32956, Upstream PR #32906, @julianwiedmann)
Miscellaneous improvements to the clustermesh troubleshooting guide (Backport PR #32571, Upstream PR #32552, @giorio94)
Remove release scripts (Backport PR #32968, Upstream PR #32938, @aanm)

Other Changes:

[1.14-backport] ipsec: Fix unencrypted traffic when IPsec is used with L7 egress proxy (cilium/cilium#31976, @jschwinger233)
[v1.14] bugtool: Avoid sensitive data in envoy config dump (cilium/cilium#32965, @sayboras)
[v1.14] envoy: Bump envoy version to v1.28.4 (cilium/cilium#32910, @sayboras)
envoy: Update envoy 1.27.x to 1.28.3 (cilium/cilium#32482, @sayboras)
install: Update image digests for v1.14.11 (cilium/cilium#32545, @nebril)

⚠⚠⚠ i used a modified version of start-release.sh because i could not create a project for v1.14.13 due to https://github.blog/changelog/2024-05-23-sunset-notice-projects-classic/.
as a result, https://github.com/cilium/cilium/blob/5ea546af5c8078a26df7fb54c0f1dd90bc365231/.github/maintainers-little-helper.yaml#L1 is still pointing to v1.14.12 project.


Update Wikipedia dataset

This PR combines all updates to Wikipedia dataset.
Once approved, this will be used to generate the pre-processed Wikipedia datasets.
Finally, this PR will be able to be merged into master:

NOT using squash
BUT a regular MERGE, so that all commits are preserved

CC: @geohci

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

I'm starting to generate the pre-processed data for some of the languages (for backward compatibility).
Once this merged, we will create the pre-processed data on the Hub under the Wikimedia namespace.


fix(deps): resolve vulnerability in axios version

This commit forces a release for the updated axios version that resolved a vulnerability. It also includes build changes to stop testing on Node 14, which had EOL 6 months ago, start testing on Node 20, and document that Node 14 is technically no longer guaranteed, even though it is supported.

:tada: This PR is included in version 4.1.4 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Action with multiple commands in the same Process, in a portable way

Hi,
First of all many thanks for this project - it was a relief for me to find that someone had the same needs than us to escape from the legacy make-like build tools while preserving the good features. From what I've seen up to now, you did it quite well!
I have been struggling to find information about the possibility to run several commands in the same process in a task.
As of today it is possible to do it using a shell-dependent separator:
import platform
OS_CMD_SEP = '&' if platform.system() == 'Windows' else ';'

def task_stupid():
    return {
        'actions': ["echo 'hello' %s echo 'world'" % OS_CMD_SEP],
        'verbosity': 2,
    }

It feels like it could be so much more elegant :) for example I would suggest:
def task_elegant():
    return {
        'actions': ["""
                    echo 'hello'
                    echo 'world'
                    """],
        'verbosity': 2,
    }

Would that make sense ? If so I can try to work on a PR.
Note for the record, that my initial need was not to call 'echo' but to activate a conda environment before running other commands :)
See also https://stackoverflow.com/questions/39721924/how-to-run-multiple-commands-synchronously-from-one-subprocess-popen-command

Note that we could use this opportunity to allow users to insert comments in their command lines, too. These would be removed automatically before being sent to shell.
def task_elegant():
    return {
        'actions': ["""
                    echo 'hello'  # says hello
                    echo 'world'  # says world
                    """],
        'verbosity': 2,
    }

It would also be interesting to support this syntax everywhere a string represents a command (for example in 'uptodate')

Why don't you call a shell script? Most editors will give a much better authoring experience that way... if the logic is complex and requires comments, I'd use a python action and uptodate implementation in the first place, so I can test and debug...

I agree with Mike.

Thanks @moltob ! Unfortunately calling a shell script breaks windows/mac/linux portability. In many of my libraries where the build system is travis or appveyor I end up calling bash or bat scripts, or python scripts, so I very much know what are the other ways to do this "less elegantly" :) .
But consider the case where people just want to call
conda activate xxx
python -c "command1"
python -c "command2"
conda deactivate  # I guess this is optional since subprocess dies anyway

These three simple commands are common to all systems we target (we assume that conda is used on all targets for this project for portability purposes). Would it really be elegant to create a dedicated script just for this, as you suggest ? Certainly not. And using a python callable for this would not as well, as the user would need to reimplement all the code you have already done in CmdAction: a bit of a waste of time...


fixed partitioner exception in large files

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/mango-prb/107/
Test PASSed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/mango-prb/108/
Test FAILed.

Merged build finished. Test FAILed.


Redirect tigerbook links directly to res college facebook

The current https://tigerbook.herokuapp.com/ link loads a redirect page. We've decided to directly redirect to the res college facebook.

Q: Header for the app is still "Tigerbook." Should we bother changing it? I feel like people know it as Tigerbook but it is not exactly the app anymore...

I think it's fine to keep the header as Tigerbook, as that's what most students are familiar with, but maybe explicitly mention that we redirect to the Res College Facebook. Also, can you change all instances of "Tigerbook" to "TigerBook" to stay consistent?

@Danielpark1239 made the changes!


chore(litmus-portal): Added image-registry changes in workflow manifest

Signed-off-by: Amit Kumar Das<EMAIL_ADDRESS>
Proposed changes
This PR adds:

Image-Registry changes in workflow manifest

Types of changes
What types of changes does your code introduce to Litmus? Put an x in the boxes that apply

[ ] New feature (non-breaking change which adds functionality)
[ ] Bugfix (non-breaking change which fixes an issue)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation Update (if none of the other choices applies)

Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

[ ] I have read the CONTRIBUTING doc
[ ] I have signed the commit for DCO to be passed.
[ ] Lint and unit tests pass locally with my changes
[ ] I have added tests that prove my fix is effective or that my feature works (if appropriate)
[ ] I have added necessary documentation (if appropriate)

Dependency

Please add the links to the dependent PR need to be merged before this (if any).

Special notes for your reviewer:

/merge


have more rooms for local Games

I don't know how to solve the conflicts, tell me when you have time to hop on a call and solve them.

Can you help me resolve the conflicts? @rdoukali42


Sync the serialization and deserialisation between render and hydration

Right now, the signals are maintaining a reverse map, which is a very hacky solution. We need to serialize the tree map on the hydration end and then move to the front.
Maybe we will need the streaming to work for this.
But, for the initial part, we can transfer it across the files.

We will be setting a window variable in every web page


Generate a daily email that summarizes diffs that happened in branches relevant to you as a re-engagement / retention tactic

Problem

There are many users who churn and stop using Cody over a period of time. For example, we have a D1 retention of ~20%, which means 80% of users don't come back the next day after signup/install.
A problem that developers encounter is that if there are changes in branches relevant to the branch they're working on, then their branches may have conflicts with other branches. Developers also just generally need to be up-to-date on these changes.

KPI

Retention rate (for users who used the product on Day N, who return on Day N+1?
Resurrection rate (for users who haven't used the product in the past 7 days, how many return on Day N)

Potential solution

Cody can take all the diffs in relevant branches for a developer and prioritize the highest value information in an email. The main CTA should somehow drive the user back to the IDE to use Cody.

@dominiccooney @umpox documenting the idea we were chatting about here. Feel free to change the description if anything looks off!
Going from "Email for diffs" to "Use Cody in IDE" feels like a stretch. What useful flow could we meaningfully drive users to from the email back to ultimately end the user back to using Cody in IDE?

Going from "Email for diffs" to "Use Cody in IDE" feels like a stretch.


Greener Days support

Describe the feature
Octopus have this web page which shows predictions for electricity prices over the upcoming week. It would be great if there was some way to integrate this you could see the info from HA
https://octopus.energy/smart/greener-days/
Expected behaviour
https://octopus.energy/smart/greener-days/ in HA
Use Case
Allows you see potential cheap days in advance without having to visit other websites outside of home assistant
Confirmation

[X] By submitting this feature request, you agree that you have read the documentation and confirmed it does not already exist
[ ] I am willing/able to help contribute to the solution of this feature
^Able to test but not develop

Hello. This is already present in the latest version of the integration, as per the docs - https://bottlecapdave.github.io/HomeAssistant-OctopusEnergy/entities/greenness_forecast/


Start of Week Change

Please add the ability to change the Week Start value; at the moment all dialogs; despite regional browser settings - start on the Sunday.

What is this referring to? There are no calendars in autoform core package.

@aldeed the date picker

The add on package? If you're just doing type="date", then that's showing the date picker generated by the browser. Nothing coming from autoform there.

weird then. As all other date pickers within the browser, abide by the regional settings of the OS; and display accordingly. For some reason the meteor-autoform doesn't.
Is there a way to explicitly specify the region then?

AutoForm isn't doing anything other than generating the input[type=date]. It should not have any differences in UI. If it does, you'll need to provide a reproduction repo so we can see what's going on.

Closing pending reproduction


Hot Deploy without monitor file

Hello, this patch adds support for hot deployment without touching the tmp/restart.txt.
It does this by adding a few things:

support for monitoring directories
support for monitoring multiple files and directories
monitoring app/, lib/ and public/ by default (more can be added in the trinidad.yml

Let me know what you think.  I fully expect to change this to meet your expectations.
Thanks,
Joe
@codefinger

Okay, so i was wrong about Rails stuff getting reloaded - i think i still had my patch installed when i tested that.
So let me see if I understand this correctly. you guys like the idea of supporting directories as valid options for the monitor parameter.  but don't include the app/, lib/, etc by default.  Does that sound like something you'd accept?
My motivation for doing this was to give those who are using trinidad in development instant feedback when they make changes (without having to touch a monitor file).
Thanks.

Yes, that sounds great to me. If we support a list of values rather than a single value everybody could set their own reload policies.

@jkutner Rails stuff under app by default does get reloaded (in development mode) unless You explicitly require of course ... have You tried using ActiveSupport::Dependencies with Your Rack app and following it's auto-loading conventions ?
it seems a bit magical at first but once You get the idea and the fact that it's built upon const_missing You're there.
otherwise You're loosing a big part of the awesomeness of Ruby web development :)


fix(order-export): support for customLineItems

Summary
Fixes: #108

Coverage decreased (-0.2%) to 94.824% when pulling 1164e6ed3a5897c767577dc5433328d08aff36f7 on 108-add-support-for-customLineItems into 9b6c27dda0be57e76a399e91dcd3de634541155b on master.

Coverage decreased (-0.2%) to 94.824% when pulling 1164e6ed3a5897c767577dc5433328d08aff36f7 on 108-add-support-for-customLineItems into 9b6c27dda0be57e76a399e91dcd3de634541155b on master.


Add alternative hotkey for panning the view

Feature/enhancement description:
Right now the only way you can pan the camera is with the middle mouse button. There doesn't seem to be an alternative for people who are using touchpads (laptop).
There should be an alternative like ctrl + left mouse or shift + left mouse for people with faulty middle mouse buttons or no mouse.

Are you using a drawing tablet? If so you can map the middle mouse button to one of the pen's keys. That's how i pan with a tablet.
But i agree that there should be some kind of fallback mechanism.

I use a mouse mainly, but when my mouse wasn't next to me I used my touchpad a little bit and was surprised there isn't a different way to pan

Implemented in #278