Updating docs to have more travis info

I can't find the original comment, but someone noted that there wasn't enough info in the docs regarding .travis.yml and adding ones framework to it so that it will be tested by Travis.
Will mark with :shipit: when I'm done adding files, opening PR now.

See issue #26

There we go! The issue was in this repo not in the FrameworkBenchmarks one.

Does this effectively fix Issue #26? Is it alright if I merge this/close the issue?

I think so.

I'm closing this for now, as major travis changes are coming and I will have a set of docs to accompany it.


Feature/export fix

A fix for the submit button in metaproteomics analysis when the export option is selected. This will reset the button after the data has been downloaded.
Original pull request by calmalak on Fri Feb 10 2017 at 06:33.
Merged by @bmesuere on Fri Nov 17 2017 at 20:12.

This code was recently rewritten
Original comment by @bmesuere on Fri Nov 17 2017 at 20:12.


Removed unneeded dependency on deprecated LtGt library.

The LtGt library is deprecated (see here and here) and not used directly by the YoutubePlaylistDownloader. This dependency is an artifact because of an indirect dependency from the YoutubeExplode library; LtGt was replaced by AngleSharp starting with YoutubeExplode version 5.0.

I forgot to say that I've tested this and it's working as expected.

Thanks!


ARROW-8028: [Go] Allow duplicate field names in schemas and nested types

PTAL @alexandreyc @stuartcarnie @richardartoul


Support i686

Could you please support windows 32 bit machines for the build.
I'm using Windows NT 10 15063
Building the app is quite a sassle for me (as win32 users) because:

My windows version does not support symlinks even though I enabled developer options.

Installing MSVC is quite a sassle (I tried 5 times; the download can't finish)

By the way, I have very limited resources; RAM, CPU even Storage
Needed requirements

Updated Windows version with Dev Options enabled (.symlinks not working for me)
Cargo or Rust in general (not installable for me since it needs MSVC)
MSVC (not installable for me)
Python version 2, not 3 (working for me)

I think anyone with the listed above resources .
can build it NOW and send it because I think it is not a difficult task and
I'm not even trying to go into node and I NEED it desperately. PLEASE HELP.

Duplicate of https://github.com/denoland/deno/issues/3438.

cc @bartlomieju Since https://github.com/denoland/deno/issues/3438 is closed now, I think this issue can be closed as well.

No, it was reopened (by me). Here's why:

Whoa! the actual releases I thought are i686 are actually 64bit. Since this is still an issue, re-opening it.

Deno does not support Windows i686 and will not in the future. See https://github.com/denoland/deno/issues/3438#issuecomment-678697954


actually fix firedragon when both other dragons are met

my previous fix was incomplete, but now it actually directly patches the fire dragon even, so there is no chance of it going to the unpatched flow which doesn't give the item and spits you out near earth temple

Verified the incorrect behaviour and tested this fix. Works and looks good to me :p


-DCUSTOM_MEMORY_MANAGEMENT=0  flag doesn't work

When this flag is set, I don't expect to get a link error:
/projects/unroadmap/adns/adnsedgepackager/../aws-sdk-libs/include/aws/core/utils/memory/stl/AWSAllocator.h:74: undefined reference to `Aws::Free(void*)'
This is because of:
    void deallocate(typename Base::pointer p, size_type n)
    {
        AWS_UNREFERENCED_PARAM(n);

        Free(p);
    }

Apparently, in the same class, somewhere "Malloc" has been defined, but "Free" has not.
This is on Ubuntu 14.04.4

Can you add your full cmake command line and what compiler you're using to this issue?

cmake -DCMAKE_BUILD_TYPE=Release -DBUILD_ONLY="s3"  -DCUSTOM_MEMORY_MANAGEMENT=0 -DSTATIC_LINKING=1
~$ gcc --version
gcc (Ubuntu 4.8.4-2ubuntu1~14.04.3) 4.8.4
Copyright (C) 2013 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
The STATIC_LINKING flag is not relevant other than the readme says that with STATIC_LINKING customer memory management is turned off.  I tried without and with ('so' libs and 'a' libs).
I also realize that what should be happening is that Free and Malloc should are found in AWSMemory.cpp.  Is it possible that using BUILD_ONLY prevented some required modules to be left out?

BUILD_ONLY only affects the service-level clients, it should have nothing to do with aws-cpp-sdk-core where this module resides.

I will try to recreate this on my local machine, but it's an earlier version of Ubuntu.  If that doesn't work we'll need to wait until I get home tonight to try it on Ubuntu 14.

My initial test on Ubuntu 12 did not have any problems; I'll try on 14 later tonight.  Do you have a file called SDKConfig.h in your .../aws-cpp-sdk-core/include/aws/core/  directory?  If so, what's in it?  If not, what commit are you building off of?

I do.  All that is in it is below (SDKConfig.h).  I assume the "#undef" should not be commented.
/*

Copyright 2010-2016 Amazon.com, Inc. or its affiliates. All Rights Reserved.

Licensed under the Apache License, Version 2.0 (the "License").
You may not use this file except in compliance with the License.
A copy of the License is located at

http://aws.amazon.com/apache2.0

or in the "license" file accompanying this file. This file is distributed
on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either
express or implied. See the License for the specific language governing
permissions and limitations under the License.
*/

/* #undef USE_AWS_MEMORY_MANAGEMENT */

Your SDKConfig.h looks correct given your cmake configuration.  It seems like USE_AWS_MEMORY_MANAGEMENT is getting defined somewhere else in your build process because your link error is from code that is only active if that is defined.
Do you get the link error building aws-cpp-sdk-core or when linking your own target against it?  Can you check the build and link flags  for aws-cpp-sdk-core (from your build directory -> aws-cpp-sdk-core/CMakeFiles/aws-cpp-sdk-core.dir/flags.make && link.txt) as well as your own target?

The link error is when building my own target (I don't define any of the SDK flags).
I want to note that I also get the "CryptoBuffer" build error mentioned in #194, with the difference that the build continues and the libraries are created successfully.  This seems a bit odd to me, but it looks like a build of a unit test is failing so the primary target continues.  A copy/paste of the section of the build I am referring to is at the bottom of this post.
flags.make and link.txt attached.
link_files.tar.gz
[ 50%] Building CXX object aws-cpp-sdk-s3/CMakeFiles/aws-cpp-sdk-s3.dir/source/model/IndexDocument.cpp.o
/home/rbross/Dyn/projects/unroadmap/adns/aws-sdk-cpp-master/aws-cpp-sdk-core-tests/utils/crypto/SymmetricCiphersTest.cpp: In function ‘void TestGCMMultipleBuffers(const String&, const String&, const String&, const String&, const String&)’:
/home/rbross/Dyn/projects/unroadmap/adns/aws-sdk-cpp-master/aws-cpp-sdk-core-tests/utils/crypto/SymmetricCiphersTest.cpp:498:70: error: call of overloaded ‘CryptoBuffer()’ is ambiguous
auto decryptResult = CryptoBuffer({ std::move(decryptedStreams) });
^
/home/rbross/Dyn/projects/unroadmap/adns/aws-sdk-cpp-master/aws-cpp-sdk-core-tests/utils/crypto/SymmetricCiphersTest.cpp:498:70: note: candidates are:
In file included from /home/rbross/Dyn/projects/unroadmap/adns/aws-sdk-cpp-master/aws-cpp-sdk-core/include/aws/core/utils/crypto/Factories.h:19:0,
from /home/rbross/Dyn/projects/unroadmap/adns/aws-sdk-cpp-master/aws-cpp-sdk-core-tests/utils/crypto/SymmetricCiphersTest.cpp:17:
/home/rbross/Dyn/projects/unroadmap/adns/aws-sdk-cpp-master/aws-cpp-sdk-core/include/aws/core/utils/Array.h:246:13: note: Aws::Utils::CryptoBuffer::CryptoBuffer(Aws::Utils::CryptoBuffer&&)
CryptoBuffer(CryptoBuffer&& other) : ByteBuffer(std::move(other)) {}
^
/home/rbross/Dyn/projects/unroadmap/adns/aws-sdk-cpp-master/aws-cpp-sdk-core/include/aws/core/utils/Array.h:245:13: note: Aws::Utils::CryptoBuffer::CryptoBuffer(const Aws::Utils::CryptoBuffer&)
CryptoBuffer(const CryptoBuffer& other) : ByteBuffer(other) {}
^
/home/rbross/Dyn/projects/unroadmap/adns/aws-sdk-cpp-master/aws-cpp-sdk-core/include/aws/core/utils/Array.h:244:13: note: Aws::Utils::CryptoBuffer::CryptoBuffer(const ByteBuffer&)
CryptoBuffer(const ByteBuffer& other) : ByteBuffer(other) {}
^
/home/rbross/Dyn/projects/unroadmap/adns/aws-sdk-cpp-master/aws-cpp-sdk-core/include/aws/core/utils/Array.h:243:13: note: Aws::Utils::CryptoBuffer::CryptoBuffer(Aws::Vector<Aws::Utils::Array>&&)
CryptoBuffer(Aws::Vector<ByteBuffer>&& toMerge) : ByteBuffer(std::move(toMerge)) {}
^
/home/rbross/Dyn/projects/unroadmap/adns/aws-sdk-cpp-master/aws-cpp-sdk-core-tests/utils/crypto/SymmetricCiphersTest.cpp: In function ‘void TestCBCMultipleBlockBuffers(const String&, const String&, const String&, const String&)’:
/home/rbross/Dyn/projects/unroadmap/adns/aws-sdk-cpp-master/aws-cpp-sdk-core-tests/utils/crypto/SymmetricCiphersTest.cpp:567:70: error: call of overloaded ‘CryptoBuffer()’ is ambiguous
auto decryptResult = CryptoBuffer({ std::move(decryptedStreams) });
^
/home/rbross/Dyn/projects/unroadmap/adns/aws-sdk-cpp-master/aws-cpp-sdk-core-tests/utils/crypto/SymmetricCiphersTest.cpp:567:70: note: candidates are:
In file included from /home/rbross/Dyn/projects/unroadmap/adns/aws-sdk-cpp-master/aws-cpp-sdk-core/include/aws/core/utils/crypto/Factories.h:19:0,
from /home/rbross/Dyn/projects/unroadmap/adns/aws-sdk-cpp-master/aws-cpp-sdk-core-tests/utils/crypto/SymmetricCiphersTest.cpp:17:
/home/rbross/Dyn/projects/unroadmap/adns/aws-sdk-cpp-master/aws-cpp-sdk-core/include/aws/core/utils/Array.h:246:13: note: Aws::Utils::CryptoBuffer::CryptoBuffer(Aws::Utils::CryptoBuffer&&)
CryptoBuffer(CryptoBuffer&& other) : ByteBuffer(std::move(other)) {}
^
/home/rbross/Dyn/projects/unroadmap/adns/aws-sdk-cpp-master/aws-cpp-sdk-core/include/aws/core/utils/Array.h:245:13: note: Aws::Utils::CryptoBuffer::CryptoBuffer(const Aws::Utils::CryptoBuffer&)
CryptoBuffer(const CryptoBuffer& other) : ByteBuffer(other) {}
^
/home/rbross/Dyn/projects/unroadmap/adns/aws-sdk-cpp-master/aws-cpp-sdk-core/include/aws/core/utils/Array.h:244:13: note: Aws::Utils::CryptoBuffer::CryptoBuffer(const ByteBuffer&)
CryptoBuffer(const ByteBuffer& other) : ByteBuffer(other) {}
^
/home/rbross/Dyn/projects/unroadmap/adns/aws-sdk-cpp-master/aws-cpp-sdk-core/include/aws/core/utils/Array.h:243:13: note: Aws::Utils::CryptoBuffer::CryptoBuffer(Aws::Vector<Aws::Utils::Array>&&)
CryptoBuffer(Aws::Vector<ByteBuffer>&& toMerge) : ByteBuffer(std::move(toMerge)) {}
^
/home/rbross/Dyn/projects/unroadmap/adns/aws-sdk-cpp-master/aws-cpp-sdk-core-tests/utils/crypto/SymmetricCiphersTest.cpp: In function ‘void TestCTRMultipleBlockBuffers(const String&, const String&, const String&, const String&)’:
/home/rbross/Dyn/projects/unroadmap/adns/aws-sdk-cpp-master/aws-cpp-sdk-core-tests/utils/crypto/SymmetricCiphersTest.cpp:629:70: error: call of overloaded ‘CryptoBuffer()’ is ambiguous
auto decryptResult = CryptoBuffer({ std::move(decryptedStreams) });
^
/home/rbross/Dyn/projects/unroadmap/adns/aws-sdk-cpp-master/aws-cpp-sdk-core-tests/utils/crypto/SymmetricCiphersTest.cpp:629:70: note: candidates are:
In file included from /home/rbross/Dyn/projects/unroadmap/adns/aws-sdk-cpp-master/aws-cpp-sdk-core/include/aws/core/utils/crypto/Factories.h:19:0,
from /home/rbross/Dyn/projects/unroadmap/adns/aws-sdk-cpp-master/aws-cpp-sdk-core-tests/utils/crypto/SymmetricCiphersTest.cpp:17:
/home/rbross/Dyn/projects/unroadmap/adns/aws-sdk-cpp-master/aws-cpp-sdk-core/include/aws/core/utils/Array.h:246:13: note: Aws::Utils::CryptoBuffer::CryptoBuffer(Aws::Utils::CryptoBuffer&&)
CryptoBuffer(CryptoBuffer&& other) : ByteBuffer(std::move(other)) {}
^
/home/rbross/Dyn/projects/unroadmap/adns/aws-sdk-cpp-master/aws-cpp-sdk-core/include/aws/core/utils/Array.h:245:13: note: Aws::Utils::CryptoBuffer::CryptoBuffer(const Aws::Utils::CryptoBuffer&)
CryptoBuffer(const CryptoBuffer& other) : ByteBuffer(other) {}
^
/home/rbross/Dyn/projects/unroadmap/adns/aws-sdk-cpp-master/aws-cpp-sdk-core/include/aws/core/utils/Array.h:244:13: note: Aws::Utils::CryptoBuffer::CryptoBuffer(const ByteBuffer&)
CryptoBuffer(const ByteBuffer& other) : ByteBuffer(other) {}
^
/home/rbross/Dyn/projects/unroadmap/adns/aws-sdk-cpp-master/aws-cpp-sdk-core/include/aws/core/utils/Array.h:243:13: note: Aws::Utils::CryptoBuffer::CryptoBuffer(Aws::Vector<Aws::Utils::Array>&&)
CryptoBuffer(Aws::Vector<ByteBuffer>&& toMerge) : ByteBuffer(std::move(toMerge)) {}
^
make[2]: *** [aws-cpp-sdk-core-tests/CMakeFiles/runCoreUnitTests.dir/utils/crypto/SymmetricCiphersTest.cpp.o] Error 1
make[2]: *** Waiting for unfinished jobs....
[ 50%] Building CXX object aws-cpp-sdk-s3/CMakeFiles/aws-cpp-sdk-s3.dir/source/model/ObjectIdentifier.cpp.o

Can you attach the flags and link text for your target that doesn't link?  In particular, anything that provides the full compile command line for the .o file that is generating the bad reference as well as the full link command line for your target.
Also, a few more dumb questions:
In a previous message you said "I downloaded the zip from the repo on Friday"  Is "zip" just a typo?  I'm not aware of an archived release.
Have you been using the SDK for a while or is the Friday download the first time you've used it?
If you've been using the SDK previous to the last download, have you cleared your cmake build directory recently (for both the SDK and your target, if they are separate)?

The "Clone or Download" button on github has a "Download zip" link.
As far as compile flags;  unfortunately I'm on to another project with a deadline, so I might not get back to it for a few days.  I have no AWS C++ SDK flags defined.  I simply add the libraries to my linker list and cut and pasted the following from the README in main.cpp:
SDKOptions options;
Aws::InitAPI(options);
Aws::ShutdownAPI(options);
But I did a grep anyway so I could confirm for you; no hits.
rab-sprt:~/projects/unroadmap/adns/adnsedgepackager$ grep -r USE_CUSTOM_MEMORY_MANAGEMENT *
rab-sprt:~/projects/unroadmap/adns/adnsedgepackager$

If you are using cmake, I don't recommend manually specifying flags, we provide export targets that will do all of this for you.
Sent from my iPhone

On Jun 1, 2016, at 8:40 AM, rabinnh<EMAIL_ADDRESS>wrote:
The "Clone or Download" button on github has a "Download zip" link.
As far as compile flags; unfortunately I'm on to another project with a deadline, so I might not get back to it for a few days. I have no AWS C++ SDK flags defined. I simply add the libraries to my linker list and cut and pasted the following from the README in main.cpp:
SDKOptions options;
Aws::InitAPI(options);
Aws::ShutdownAPI(options);
But I did a grep anyway so I could confirm for you; no hits.
rab-sprt:~/projects/unroadmap/adns/adnsedgepackager$ grep -r USE_CUSTOM_MEMORY_MANAGEMENT *
rab-sprt:~/projects/unroadmap/adns/adnsedgepackager$
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

Any updates on this?

closing per no updates. Feel free to reopen if issues persist


issue with CATS unable to validate certificates when google log file is not available

Hi @dmariogatto,
currently my app is blocked from making any http call because CATS can't get the below url to validate the certificate
https://www.gstatic.com/ct/log_list/v2/log_list.json
there is a newer version v3 available that the library can update to.
https://www.gstatic.com/ct/log_list/v3/log_list.json
at the time of writing, google took down the v2 document and cause clients to fail.
as temp solution, file is back up now but for permanent solution, can the library define both and have interface for clients to select between v2 and v3?
Thanks

The v2 log list is now temporarily back to minimise the impact. Please upgrade to v3 log list as soon as possible.

@xhh2yqm Why would you want both v2 & v3?
Discussion for reference Turning down Google's v1, v2 CT log list publishing.


Crashlytics logging crash during app launch, and Realm setup

I am seeing below crash quite often. Looks like it's happening during the app launch or app coming to active mode from the background, but I am not able to reproduce it myself. I do have a feeling Fabric aka Crashlytics is logging manual termination of the app from iPhone's app switcher as a crash?
OS Version: 9.3.2 (13F69)
Device: iPad 3
RAM Free: 26.1%
Disk Free: 14.7%
#0. Crashed: com.apple.main-thread
3  phil                           0x19e2e0 static UserApiService.isUserLoggedIn() -> Bool (UserApiService.swift:14)
4  phil                           0x25b3c4 specialized AppDelegate.application(UIApplication, didFinishLaunchingWithOptions : [NSObject : AnyObject]?) -> Bool (AppDelegate.swift:83)
5  phil                           0x259140 @objc AppDelegate.application(UIApplication, didFinishLaunchingWithOptions : [NSObject : AnyObject]?) -> Bool (AppDelegate.swift)
6  UIKit                          0x272f9785 -[UIApplication _handleDelegateCallbacksWithOptions:isSuspended:restoreState:] + 392
7  UIKit                          0x275212d1 -[UIApplication _callInitializationDelegatesForMainScene:transitionContext:] + 3080
8  UIKit                          0x27525285 -[UIApplication _runWithMainScene:transitionContext:completion:] + 1588
9  UIKit                          0x2753983d __84-[UIApplication _handleApplicationActivationWithScene:transitionContext:completion:]_block_invoke3286 + 36
10 UIKit                          0x275227b3 -[UIApplication workspaceDidEndTransaction:] + 134
11 FrontBoardServices             0x243aec07 __FBSSERIALQUEUE_IS_CALLING_OUT_TO_A_BLOCK__ + 18
12 FrontBoardServices             0x243aeab9 -[FBSSerialQueue _performNext] + 224
13 FrontBoardServices             0x243aedb9 -[FBSSerialQueue _performNextFromRunLoopSource] + 48
14 CoreFoundation                 0x22ccddff __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ + 14
15 CoreFoundation                 0x22ccd9ed __CFRunLoopDoSources0 + 452
16 CoreFoundation                 0x22ccbd5b __CFRunLoopRun + 794
17 CoreFoundation                 0x22c1b229 CFRunLoopRunSpecific + 520
18 CoreFoundation                 0x22c1b015 CFRunLoopRunInMode + 108
19 UIKit                          0x272f2c3d -[UIApplication _run] + 524
20 UIKit                          0x272ed189 UIApplicationMain + 144
21 phil                           0x25a1c4 main (AppDelegate.swift:15)
22 libdispatch.dylib              0x228c3873 (Missing)

I'm not aware that Fabric/Crashlytics is logging false-positives of manual app terminations as crashes. I can't recognize from the stack trace how this crash should be related to Realm. Would you like to explain what brings you to that conclusion? It might help if you share what happens within UserApiService.isUserLoggedIn().

Thanks, that method basically does the realm setup if user doesn't exists. I will add more logging to see where it fails and see what's going on
Thanks


🐛 header broken without logo on mobile

Describe the bug
When logo is not defined, header looks weird on mobile.

Expected behavior
You should see something like this:

Hugo & Blowfish versions
Hugo: hugo v0.108.0+extended linux/amd64
Blowfish: v2.22.0 (commit 99cb56f9f5a53eaef9b9a1d46ea3115736f363f3)

Merged into dev will be available in the next release


Question : How to refer to ints in another json file

Hi,
Sorry for opening an issue, I'm not sure how to contact you.
I'm trying to mod sins2 and on this repo's main page, you have a picture where "starting_units_in_hyperspace" : {},
I have come to understand that {} is used by the game engine to mean to use a variable's value.
However, I haven't found how to refer to a value defined somewhere else.
I was hoping your usage of this meant maybe you know how to point to any generic values defined elsewhere in json.
I know that the ':' symbol is used to mean 'don't interpolate, just use as-is' but i haven't found a way to specify 'go fetch the value from this variable at this location'
Please let know if you know how to use variables and a better way to contact you in the future :)
Thank you !

Hey, you can get in touch here: https://discord.gg/cRm5UdmhsJ
As per your issue, the curly braces {} are an object definition, it has no relation to any type of variable within the modding context, it's simply a text format the engine serializes its game data in
You can learn about the format here: https://www.json.org/json-en.html


Is this project dead?

Is this still being actively deveoped any more?
I ask because I don't see any meaninful feature additions in a while.
There's hardly any response on open issues either.
Sorry if this is rude.

maybe, It's been six months since a new commit

Is this still being actively deveoped any more?
I ask because I don't see any meaninful feature additions in a while. There's hardly any response on open issues either.
Sorry if this is rude.

You could try Yarp.
https://github.com/microsoft/reverse-proxy
https://microsoft.github.io/reverse-proxy/articles/authn-authz.html

I think members are no more active!

Yeah seems like no one is handling this any more but we can use its features, it cool!


OP gets confused with a sudden exit ramp and almost crashed into a divider

Describe the bug
While driving on a freeway, behind a lead car, OP got confused by an exit ramp. It stopped following the lead car to instead almost took the exit. I had to take control to bring it back on the road. Had I not done that I would have most ceratainly crashed into the divider.
How to reproduce or log data
This probably needs a very specific road condition to reproduce. See the video.
Expected behavior
I would expect OP to continue following the lead car and not take the exit in this case
Device/Version information (please complete the following information):

Device: comma two
Dongle ID: 3c946decd6bc40b9
Route: [e.g.<PHONE_NUMBER>638/1608748144744 (link to segment: https://my.comma.ai/3c946decd6bc40b9/1608744542638/1608748144744
Timestamp: Dec 23 10:16:57
Version: release2 0.8
Car make/model: 2020 Chrysler Pacifica

Additional context

This isn't really caused by a specific bug, just the model misunderstanding the scene. This should get better as the model improves. Thanks for the report!


[6.x] Don't return nested data from validator when failing an exclude rule

When using the exclude_if or exclude_unless validation rules, nested fields are excluded from being validated, however they are not being removed from the validated data.
This is a breaking change, however I would consider it a bugfix since the documentation is clear that "The field under validation will be excluded from the request data returned by the validate and validated methods."
The existing test case for this feature did not reflect the intended behaviour, so I just corrected that test rather than including a new one.

Please give an example.

The test case I modified in ValidationValidatorTest::testExcludeIf demonstrates the issue.  It uses the following rules:
[
    'vehicles.*.type' => 'required|in:car,boat',
    'vehicles.*.wheels' => 'exclude_if:vehicles.*.type,boat|required|array',
    'vehicles.*.wheels.*.color' => 'required|in:red,blue',
    // In this bizzaro world example you can choose a custom shape for your wheels if they are red
    'vehicles.*.wheels.*.shape' => 'exclude_unless:vehicles.*.wheels.*.color,red|required|in:square,round',
]

With this data:
[
    'vehicles' => [
        [
            'type' => 'car',
            'wheels' => [
                ['color' => 'red', 'shape' => 'square'],
                ['color' => 'blue', 'shape' => 'hexagon'],
                ['color' => 'red', 'shape' => 'round', 'junk' => 'no rule, still present'],
                ['color' => 'blue', 'shape' => 'triangle'],
            ],
        ],
        ['type' => 'boat'],
    ],
]

This produces identical validated data, however we expect the exclude_if rule to remove the vehicles.*.wheels.*.shape values from the validated output when color != red (hexagon and triangle), but currently they remain because only the first level of of validated data is removed by the unset statements.  Changing these to Arr::forget fixes this to also remove the nested data.


[CUBRID] Issue with about transaction(log) in 'Keep Alive' when Autocommit is false.

If you set 'Keep Alive' and 'autocommit' to false, When not used for a long period of time, transaction(log) accumulate occurs. (Because every 'SQL Editor's connection' sends a 'Keep Alive')
Similar or identical issues are expected to occur in other databases.
(when database overriding 'testsql')
To this end, we offer the following suggestions:

Request to modify isConnectionAlive inside the JDBCUtils class.
Even if testSQL is defined, We want to execute 'conntion.isValid' first.

Let's create a PR by overriding 'checkContextAlive' just for Cubrid. This creates duplicate code.

We want to use 'select 1' , but Let's create a PR by delete 'testsql' defind again for Cubrid . No duplicate code is not created.

Would like advice.
Best Regard.

Thank you for asking. We will discuss and let you know

We suggest to set test sql to empty string for Cubrid.


Delete user from all tables

What steps will reproduce the problem?
Delete a user.
What is the expected result?
User removed from tables user, profile and auth_assignment (if rbac used)
What do you get instead?
User is not removed from table profile and auth_assignment.
Additional info

Q
A

Yii2 version
2.0.10

Yii2-user version
0.9.12

PHP version
7

Probably adding some foreign keys with cascade would solve the problem. Though I dunno if this is the case when using rbac (as it's optional and uses it's own migration).
For principle I would not delete a user, but disable it anyway (unless it was a mistake or never used).


Fixes #40 (make this optional)

Prior art at #35 for #40
cc @kleinfreund this is the one!

So… I deleted a lot of the code and went with a much better solution using vm (no destructuring or Function strings) 😅 https://nodejs.org/docs/latest-v14.x/api/vm.html#new-vmscriptcode-options
This is node-specific but seems more idiomatic and some of the code in moduleScript was already Node specific. We can add more adapters for different runtimes if folks want them!


Support counting words

Hi, thanks for creating a great plugin!
It would be awesome to support counting words as well.
You can use the words-count module. Or, you can use this regex posted on the user forum.
It would affect performance, so you can debounce the process by using a module like lodash.debounce.

Hi, thank you for giving an idea to me.
Sounds like a good feature! I will work on it.

@craftzdog Just added a word count feature! I hope you will check it out.
Your advice was very helpful in the implementation. Thank you very much.

Cool! Thank you for improving the plugin :D
Works perfectly.


Warnings during build .net core project

Hi!
Thank you for your project.
I'm using FluentValidation.AspNetCore 7.2.1.
I have warnings during build:
C:\Program Files\dotnet\sdk\2.1.2\Microsoft.Common.CurrentVersion.targets(2041,5): warning MSB3277: Found conflicts between different versions of "Microsoft.Win32.Registry" that could not be resolved. These reference conflicts are listed in the build log when log verbosity is set to detailed. [d:\Projects\FluentValidationBuildWarnings\FluentValidationBuildWarnings.csproj]

C:\Program Files\dotnet\sdk\2.1.2\Microsoft.Common.CurrentVersion.targets(2041,5): warning MSB3277: Found conflicts between different versions of "System.Security.Principal.Windows" that could not be resolved. These reference conflicts are listed in the build log when log verbosity is set to detailed. [d:\Projects\FluentValidationBuildWarnings\FluentValidationBuildWarnings.csproj]

Issue demonstration: https://github.com/jincod/FluentValidationBuildWarnings
Unfortunately, I did find cause of this behavior.

Hi, that's not actually related to FluentValidation.
As the message says, setting the build log to detailed will show you what's happening. Essentially it's complaining because you're targetting netstandard2.0 but you're bringing in Microsoft.AspNetCore.Mvc 1.1 which targets netstandard1.6 and the .net sdk it's getting confused between different version of mscorlib (the .net core build process is still pretty buggy)
Nuget is bringing in microsoft.aspnetcore.mvc 1.1 because that's the minimum version supported by FluentValidation. But your project is targetting .NET Core 2.0, so you should be referencing microsoft.aspnetcore.mvc 2.0. Add the following to your project and you'll see the warning goes away:
<PackageReference Include="Microsoft.AspNetCore.Mvc" Version="2.0.0" />

Also; if you upgrade to FluentValidation 7.3-beta2 you’ll see this doesn’t happen as it’s metadata explicitly targets different versions of Microsoft.AspNetCore.Mvc depending on which netstandard version you’re running on. So going forward you won’t run into this.

FluentValidation 7.3-beta2 works for me
Thanks a lot!


sst: Allow filtering secrets by fallback values

In some cases its been useful to know if any fallback values are being used in certain stages. For instance, making sure a prod stage isn't using any fallback values.

Can you share how this works?

Sure. This just adds a boolean flag for listing secrets in cli that will filter the list down to just fallback values. A use case that I have is making sure certain stages aren't using fallback values. It can be used like sst secrets list --fallback. Second to that, it adds a comment in the env layout to denote fallback values, again for easier parsing.


Training page loaded with light theme

Chrome, OSX, No error was shown in console. App.data.theme == 'inverted'.
Only train page is inverted. I must logout and back in to fix.

Closing this because I believe it's been fixed.


Redirects for functions result in a 404

Describe the bug
When using a _redirects file, proxy redirects for Netlify Functions
To Reproduce
Steps to reproduce the behavior:

Clone https://github.com/jlengstorf/feature-tour-sep29-2
Install the latest Netlify CLI
Run netlify dev
Visit http://localhost:8888/api/hello-world

Configuration
see repo
Expected behavior
redirect should work
CLI Output
it appears to be trying for HTML, but not a function
[access] /api/hello-world
[access] /404
[access] Not Found: /api/hello-world
[access] /api/hello-world.html

Hi @jlengstorf,
Thanks for the report.
I am not able to reproduce using the repository:
$ netlify dev
◈ Netlify Dev ◈
◈ Ignored general context env var: LANG (defined in process)
◈ Loaded function hello-world.
◈ Functions server is listening on 42209
◈ Starting Netlify Dev with Astro

><EMAIL_ADDRESS>dev
> astro dev

[19:56:36] [snowpack] Hint: run "snowpack init" to create a project config file. Using defaults...
[19:56:37] [snowpack] Ready!
[19:56:37] [snowpack] watching for file changes...
[dev server] Server started in 715ms.
[dev server] Local: http://localhost:3000/
[access] /

   ┌─────────────────────────────────────────────────┐
   │                                                 │
   │   ◈ Server now ready on http://localhost:8888   │
   │                                                 │
   └─────────────────────────────────────────────────┘

[access] /
◈ Rewrote URL to /.netlify/functions/hello-world
Request from ::ffff:<IP_ADDRESS>: GET /.netlify/functions/hello-world
Response with status 200 in 43 ms.

I am using Netlify CLI 6.9.28. Could you try again using the reproduction repository with that Netlify CLI version and confirm this is still not working for you?

I haven't hit this again, so I'm going to assume something was weird in my setup


Unhandled value '28' outside enum range for ChargingReason

Getting recurring errors in the HA logs about an unhandled value 28
extracted error message:
This error originated from a custom integration.
Logger: custom_components.wattpilot.sensor
Source: custom_components/wattpilot/sensor.py:132
Integration: Fronius Wattpilot (documentation)
First occurred: April 30, 2024 at 10:04:28 PM (9 occurrences)
Last logged: May 2, 2024 at 1:30:34 PM
Wattpilot - modelStatus: _async_update_validate_platform_state failed: state 28 not within enum values: {0: 'NotChargingBecauseNoChargeCtrlData', 1: 'NotChargingBecauseOvertemperature', 2: 'NotChargingBecauseAccessControlWait', 3: 'ChargingBecauseForceStateOn', 4: 'NotChargingBecauseForceStateOff', 5: 'NotChargingBecauseScheduler', 6: 'NotChargingBecauseEnergyLimit', 7: 'ChargingBecauseAwattarPriceLow', 8: 'ChargingBecauseAutomaticStopTestLadung', 9: 'ChargingBecauseAutomaticStopNotEnoughTime', 10: 'ChargingBecauseAutomaticStop', 11: 'ChargingBecauseAutomaticStopNoClock', 12: 'ChargingBecausePvSurplus', 13: 'ChargingBecauseFallbackGoEDefault', 14: 'ChargingBecauseFallbackGoEScheduler', 15: 'ChargingBecauseFallbackDefault', 16: 'NotChargingBecauseFallbackGoEAwattar', 17: 'NotChargingBecauseFallbackAwattar', 18: 'NotChargingBecauseFallbackAutomaticStop', 19: 'ChargingBecauseCarCompatibilityKeepAlive', 20: 'ChargingBecauseChargePauseNotAllowed', 22: 'NotChargingBecauseSimulateUnplugging', 23: 'NotChargingBecausePhaseSwitch', 24: 'NotChargingBecauseMinPauseDuration'}
Describe the expected behavior
There is no apparent effect or detrimental impact as far as the actual functionality
To Reproduce
N/A
What version of Home Assistant Core is installed
Home Assistant 2023.10.0
Frontend 20231002.0 - latest
What version of Wattpilot integration is installed
"wattpilot": {
"version": "0.1.9",
What version of Wattpilot are you using
22KW-V2    WattPilot Go   firmware version 40.7
Error message shown within Home Assistant log
see above
Diagnostics information of Wattpilot integration
config_entry-wattpilot-3b55bc54926ad59482acc64c23ce8639.json.txt
Additional Information
Unrecognised value '28' is ChargingReason, which is described as 'Reason why we allow charging or not right now - values are listed at: https://github.com/goecharger/go-eCharger-API-v2/blob/main/apikeys-de.md -> modelStatus'.
Looking at the Solar.Wattpilot app, this code is associated with the message "Charging Stopped by OCPP backend" on the WattPilot app.
Which I suspect is newly added in the 40.7 firmware and wasn't there when the 'goecharger' code was written.
Reporting it here for your info, will also report it in the goecharger project.
https://github.com/goecharger/go-eCharger-API-v2/issues/214

ah - nvm
just saw code 28 was already discovered as:
'NotChargingBecauseOCPPBackend=28'

fixed in 5a8d249ae35fc7c84ca052d63f3fe1d427fedff8

Rather than open a completely new issue, I can see you released a version 0.2.0 recently.
Could you please update the version in manifest.json, which still shows v0.1.9?


Classification counter stuck on one value for some time

This is with regards to the MWP : https://www.zooniverse.org/projects/povich/milky-way-project
Our classification counter is stuck at 25,862 for ~18hrs now. The statistics page shows that there were no classifications made today. We have applied for full launch and the project is in the "live" mode.
Are our classifications being lost? I am curious about this! Any help would be appreciated :)
Thanks again for the great work Zooniverse!

Sorry for the confusion, we're having some technical issues with the statistics page and the counter values on project homepages.
Classifications are still getting stored.

Marten

On 2 Sep 2016, at 05:39, mwp-tj<EMAIL_ADDRESS>wrote:
This is with regards to the MWP : https://www.zooniverse.org/projects/povich/milky-way-project
Our classification counter is stuck at 25,862 for ~18hrs now. The statistics page shows that there were no classifications made today. We have applied for full launch and the project is in the "live" mode.
Are our classifications being lost? I am curious about this! Any help would be appreciated :)
Thanks again for the great work Zooniverse!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

We're working on this and should have a solution out today. For what it's worth the stats page graphs show the classifications are still being counted:
https://www.zooniverse.org/projects/povich/milky-way-project/stats

this should be fixed now.


Add a grab'n'go to GCP marketplace

Expected Behaviour
It would be cool to get a preconfigured App Engine Project for Grab'n'go on the Marketplace. This would make it super easy to deploy the program on your own with minimal effort.
Actual Behaviour
There are tons of steps with high error potential to be taken.
Steps to Reproduce
... see your installation guide ... :)

+1

all I'd say is that sometimes delaying gratification is sooo satisfying!  The reward for persevering and following the steps is amazing .... we have more than four hundred Grab 'n Go Chromebooks and nine hundred very happy staff!  95% of the feedback is that they loved it!!

You need to work through the guide two or three times, to get used to the steps and the pitfalls, it's worth the effort.


Get pictures and details for all participants who want to be acknowledged on the page

Similar to #10 - gather a list of contributors, and images for the about page.


Support reading api key from file

This PR will add support for a new environment variable which allows reading the API key from a file.
This features allows support for docker swarm secrets as stated in #77.

Thanks for investigating this and putting this together @ArwynFr!
Since we can't really use the API key file just to separate secret config, I think the best approach here might be to support reading any configuration from a file. We can do this by deriving serde::Deserialize on our Config types, allowing them to be read (probably as YAML or TOML) and then applying environment variables on top. Is this something you'd be interested in looking at? If so I'd be happy to help out if you run into any trouble!

It's been a while since any updates here so I'll go ahead and close this one for now. If anybody wants to look into loading configuration from a file independently to this then please feel free!
Thanks again @ArwynFr 🙇


Track wsSB in Effective Next Reward Amount

"Effective Next Reward Amount" will show the amount that is earned via wsSB
It can improve UX by showing the effective amount of sSB you are getting (if you only have wsSB), instead of someone having to calculate it themselves with Next Reward Yield.
When there are wsSB tokens being tracked in that user's wallet, it could display a small icon that users can hover on or click to show an informational message about wsSB being tracked.
Sorry maintainers for notifications/pings, I accidentally did it from main instead of on a branch.

@0xOtoguro

Great work! @cybertelx


Update Brazilian Portuguese translations

All the new stuff should be translated.
I took a little long due to Internet issues and getting distracted with other random stuff and TikTok lol

what is this check

its literally done

Thanks also dw i feel ya w the internet thing, its my daily life. It gets multiple times for me to be able to even just push a commit, update a repo or reload gradle.


Updated WordPress to 4.8.3

What has been done

Updated WordPress to 4.8.3

How to test

Pull this branch
Run docker-compose up --build
See that the latest version of WordPress has been installed.

Notes
Nice container!

Published the 4.8.3 release https://github.com/TrafeX/docker-wordpress/releases/tag/4.8.3


ISPN-15353 Quarkus 3.6.0

https://issues.redhat.com/browse/ISPN-15353
https://issues.redhat.com/browse/ISPN-15354

Merged, thanks


Invalid links with no text are generated for lineanchors without linenos

$ cat x.py
if 1 == 2:
    print("Hello!")
$ pygmentize -f html -O lineanchors=x x.py

if 1 == 2:
    print("Hello!")

This change was introduced in #1973. There are two issues with it:

The href attribute is not valid, since it links to a file and not the anchor. It should refer to #x-1 for example.
I'm not convinced that this behavior is useful. I can access the link with the Tab key, but I can't access it via mouse. This feature would require extra CSS, which the default Pygments CSS does not include. Is the required CSS documented anywhere?

You're right on the missing #, but I'm not following the "is that behavior useful" question. There are ids assigned so it makes sense to link to them. Is there some use case that is broken now that was working differently previously?

It might make sense to link to them — but if you’re linking to them, why not just use line numbers, or something visible? The new feature is not accessible to mouse users and might be confusing for keyboard and screen-reader users, and I don’t think the feature is documented or explained anywhere.

@Kwpolska See https://github.com/pygments/pygments/pull/1973#issuecomment-1004852001 for some CSS to make the line numbers visible/clickable
I think this is only needed if you're using CSS to display the line numbers, rather than using linenos + anchorlinenos.


Which is the right Monorepo tool?

Triggering a discussion about Monorepo tools

Corresponding decision table here

Corrections to table:

lerna is maintained; Nrwl, the company behind Nx, took over stewardship of Lerna
nx and lerna are orthogonal and compatible

Hey @joebowbeer, welcome aboard 🌻
Yes, we should emphasize more that a valid monorepo strategy is a workspace + build-tool (e.g. Nx)
About Lerna - I will update, thanks. Personally, I think that Nx will swallow it but it's not fair to write that it's not maintained

I had a good experience with Turborepo.

two issues/points of confusion i have: 1) https://github.com/nrwl/nx-recipes/tree/main/pnpm-workspace this example shows that NX can be used with multiple package.json, so i don't think it's fair to argue that it can only have a root package.json (which would increase tight coupling) and 2) how is that NX is locally linking by using typescript and webpack? if you are using pnpm, for example, it is locally linking by means of pnpm workspace, and i believe it would be the same for yarn and npm as well.
thanks for this write up, i just want to make sure the information is accurate here

@d1onys1us Welcome aboard. Appreciate your feedback!
About the 1st point - Nx encourages this coupling, it doesn't enforce it. If you use the default Node plugin, this is the setup that one gets
About 2nd point - You're right. We should update the wording. Care to do this or shall I?

Hi @goldbergyoni, quick update on Lernajs.
The table states that Lerna doesn't support parallelism, but it does support concurrency as read here.

Based on simplicity, documentation, and community support, my personal opinion leans towards Nx.
This doesn't mean Turborepo isn't good; it's just a newcomer, and its community is still growing.
Nx (monorepo) + Nest (framework) = ❤


Add more log to sd integration test.

Please provide a description for what this PR is for.
And to help us figure out who should review this PR, please
put an X in all the areas that this PR affects.
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
Pull Request Attributes
Please check any characteristics that apply to this pull request.
[ ] Does not have any changes that may affect Istio users.

@bianpengyuan: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
d9164007b1d19f388504486dc99f2f8be13fc7f1
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@bianpengyuan: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
d9164007b1d19f388504486dc99f2f8be13fc7f1
link
/test release-notes_istio

lint_istio
d9164007b1d19f388504486dc99f2f8be13fc7f1
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@bianpengyuan: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
d9164007b1d19f388504486dc99f2f8be13fc7f1
link
/test release-notes_istio

lint_istio
d9164007b1d19f388504486dc99f2f8be13fc7f1
link
/test lint_istio

analyze-tests_istio
d9164007b1d19f388504486dc99f2f8be13fc7f1
link
/test analyze-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@bianpengyuan: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

analyze-tests_istio
d9164007b1d19f388504486dc99f2f8be13fc7f1
link
/test analyze-tests_istio

lint_istio
c8f97a9fda10171468f63bfde72f0627d6262dba
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@bianpengyuan: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
c8f97a9fda10171468f63bfde72f0627d6262dba
link
/test lint_istio

unit-tests_istio
4c7b02a197a6b9c5945c5252d798d0236c020e9b
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@istio/wg-policies-and-telemetry-maintainers ptal, thanks!

@istio/wg-policies-and-telemetry-maintainers ptal, thanks!

@istio/wg-policies-and-telemetry-maintainers ptal, thanks!

Ping @istio/wg-policies-and-telemetry-maintainers ptal thanks!


Full screen notch

So I recently upgraded you plus and before I had those setting disabled and enabled to see the difference now when I do so I no longer see the difference

Have you tried adjusting the safe area constant?


Escape path for the file list (#22741)

Backport #22741
Fix #22740

merged with 🪄 as this should not be causing CI failure.


login google with service-worker does not work using angularfire2": "^4.0.0-rc.0 :

Version info

"dependencies": {
"@angular/common": "^4.1.2",
"@angular/compiler": "^4.1.2",
"@angular/core": "^4.1.2",
"@angular/forms": "^4.1.2",
"@angular/http": "^4.1.2",
"@angular/platform-browser": "^4.1.2",
"@angular/platform-browser-dynamic": "^4.1.2",
"@angular/router": "^4.1.2",
"angularfire2": "^4.0.0-rc.0",
"core-js": "^2.4.1",
"firebase": "^3.9.0",
"rxjs": "^5.1.0",
"zone.js": "^0.8.10"
},
"devDependencies": {
"@angular/cli": "1.0.3",
"@angular/compiler-cli": "^4.1.2",
"@types/jasmine": "2.5.47",
"@types/node": "~7.0.18",
How to reproduce these conditions
Hi, After update angularfire2": "^4.0.0-rc.0 login with google does not work anymore when I use a service-worker.
It goes fine when I use the local host. Only after the ng build, the error occurs.

I've created a simple example project for this :
running example : https://afterchat-a27ef.firebaseapp.com/
code : https://github.com/hansanker/afterChat

Sample data and security rules
Debug output
ERROR oo {code: "auth/network-request-failed", message: "A network error (such as timeout, interrupted connection or unreachable host) has occurred."}
Actual behavior
After login without service-worker login popup closes after some time. Login failed.

The problem was I had to update the user creation in the database.
name: this.af.auth.currentUser.displayName ||  this.af.auth.currentUser.email,

I am having the same issue, seems to be working on Firefox though, not on Chrome.

I have the same problem. Any solution at all?
If I disable service worker, the auth works fine, otherwise, if enabled I only receive network error message.
Authorized domains its ok.
Thanks!

I found the the solution.


add dynamic highscores, displaying their history, correcting links

🛠 Fixes Issue
Fixes: #688
👨💻 Description
What does this PR do?
Currently the share your score page displays a fixed no. 150. I have make this dynamic so that users can share their updated highest score everytime they use the page to share their score.
I have also added a history of highscores & when they r achieved by player in this page.
📄 Type of Change

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation update (adds or updates related documentation)

📷 Screenshots/GIFs (if any)
Include screenshots or GIFs to demonstrate your changes
https://github.com/user-attachments/assets/7dd58adf-dd79-46ea-baa6-f1f0efe32c86
✅ Checklist

[ ] I am a participant of GSSoC-ext.
[ ] I have followed the contribution guidelines of this project.
[ ] I have made this change from my own.
[ ] I have taken help from some online resources.
[ ] My code follows the style guidelines of this project.
[ ] I have performed a self-review of my own code.
[ ] I have added documentation to explain my changes.

Mandatory Tasks

[x] Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

🤝 GSSoC Participation

[ ] This PR is submitted under the GSSoC program.
[ ] I have taken prior approval for this feature/fix.

@YadavAkhileshh pls review this pr


update docs for python sdk changes.

These updates are for the python SDK changes from the tickets
UID2-1270
UID2-970

All good. Thx!


Copy uap->policy into the kernel before dereferencing.

This change uses copyinstr to safely read the uap->policy. With the change, I can load the extension without crashing and I'm seeing sandboxmirrord events in the console! If the style or anything is not to your liking, feel free to change or reject this. Thanks.

Thanks, Hafta!
  What's odd is that I never saw these myself, on multiple machines and over the course of a year.  Some weird timing issue, I suppose.  But you definitely found a bug and I need to fix it.

Hafta, I just landed your modified patch:
https://github.com/steven-michaud/SandboxMirror/commit/aa76eecf4354b4d57ce86ee2dccb2139cfa2dacc
Thanks again!

Oops, I made a mistake copying your patch:
https://github.com/steven-michaud/SandboxMirror/commit/1a26cca768f575e742e93f51764b83685d2e573b


Schema jsonConfig.json - potentially missing definitions

Moved from https://github.com/ioBroker/adapter-react/issues/29 on request of GermanBluefox
I linked https://raw.githubusercontent.com/ioBroker/adapter-react-v5/master/schemas/jsonConfig.json to vsCode. vsCode reports the errors which seem to be caused by missing definitions in schema:
validatorNoSaveOnError
seems to be missing completly
validator, validatorErrorText, validatorNoSaveOnError
seems to be missing at table elements (item array of table). Validator is working, so the schema seems to be incorrect. As validatorErrorText does not seem to work the schema might be correct - in this case schema.md at admin is incorrect
default, hidden
seem to be missing at table elements (item array of table).
options
seems to be missing at table elements (item array of table) of type "select".

cloned from https://github.com/ioBroker/adapter-react/issues/29#issuecomment-1100712214
In table items, most (all?) type specific definitions seams to be missing.
E.g. for selectSendTo: command, data, jsonData, defaultFunc, noTranslation are missing.
noMultiEdit is missing completely.
maxLength for type text is missing.
The defaultFunc and onChange object syntax seams to be missing completely. This is used e.g. in linkeddevices here and here for example.

What is not possible is to make table in table definitions.

I still have the following schema mismatches / errors reported by vsCode:
The following tabel attributes are reported as invalid:
showSecondAddAt
The following attributes of table elements ("items" array) are reported as invalid:
attr
title
filter
sort
validatorErrorText
options
min
max

I'm not sure what your last remark refering table in table definitions refers to. I only have one table inside a tab ("tabs" array).
The complete json config raising errors at vsCode can be found here:
https://github.com/mcm1957/ioBroker.snmp/blob/dvp-2.1.x/admin/jsonConfig.json

This still an open issue

jsonEditor ist also missing

New 'accordion' element is likely to be missing too

For the initial validatorErrorText is also not working for items, so maybe it is on purpose see https://github.com/ioBroker/ioBroker.admin/issues/1911

As admin now validates the jsonConfig of every adapter against the schema, it is now crucial that the schema is up-to-date.
Additional it will make sense to validate it in tests https://github.com/ioBroker/testing/issues/583

@did you test with jsonConfig-demo adapter?
It for sure does not cover all situations - but if some check fail, the schema should be checked.
Which admin version includes the check so that I could test too.
In addition where is the schema taken from - always online from head of master/main?

Schema always taken from https://github.com/ioBroker/adapter-react-v5/blob/main/schemas/jsonConfig.json
Admin 6.12.0 includes the check whenever an adapter config is opened via browser.

"cron" type is missing completely in the schema though it works and is documented at https://github.com/ioBroker/ioBroker.admin/blob/22bd130648ff2754922a91bcdbfad7e9fc278fc3/src/src/components/JsonConfigComponent/SCHEMA.md?plain=1#L263.

cron has been added now, for the tables we have a separate issue at https://github.com/ioBroker/adapter-react-v5/issues/183

Please create separate issues if more errors occur


Getting FrozenError (can't modify frozen String: "false") after upgrading to Ruby 2.7.3 using awesome_print (1.9.2)

Recently upgraded to Ruby 2.7.3 and all of the sudden we are getting the error below
irb(main):005:0> ap User.last
Traceback (most recent call last):
FrozenError (can't modify frozen String: "false")

I upgraded awesome print to the latest awesome_print (1.9.2) but we are still having the same issue.
This error happens when ap is used before any ActiveRecord call. Any ideas?
Weird, it looks like it works on some models and not on others. Simpler models seem to work, more complex models have the freeze issue.

@ritec This is unrelated to awesome_print. Upgrade irb and reline and you should see the issue disappear.

@ryansch Oh wow, I did not have much time to research in depth but I will close the issue now then. Thanks for the heads up!

@ryansch hmmm upgraded both and still having the same issue.

@ritec If you're using bundler, you need to specify them in your Gemfile.

ok thanks, I now did that and nothing prints when  I do ap User.last for example, but I don't want this to turn into a help me session more than it has so I will go ahead and leave it at that. Thanks. Something funky is definitely going on here.


[FLINK-9860][REST] fix buffer leak in FileUploadHandler

What is the purpose of the change
The current implementation of FileUploadHandler has two cases where the given message was not released or forwarded for some other handler to release.
Brief change log

change the use of SimpleChannelInboundHandler to auto-release objects and make sure we retain them only when needed

Verifying this change
This change added tests and can be verified as follows:

adapted FileUploadHandlerTest to use a customized (Netty) leak detector that does not only log but fails with an assertion
enable ERROR logging level for log4j.logger.org.apache.flink.shaded.netty4.io.netty.util.ResourceLeakDetector in all unit tests in flink-runtime - the leak detector will otherwise not report anything

Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): no
The public API, i.e., is any changed class annotated with @Public(Evolving): no
The serializers: no
The runtime per-record code paths (performance sensitive): no
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no
The S3 file system connector: no

Documentation

Does this pull request introduce a new feature? no
If yes, how is the feature documented? not applicable

+1

merging.


Fix codeblock lang in RSS guide [i18nIgnore]

Description (required)

Fixes an incorrect language in codeblocks in the RSS guide.
Before:

After:

Related issues & labels (optional)

Closes #
Suggested label:

Lunaria Status Overview
🌑 This pull request will not trigger status changes.

Learn more
Lunaria automatically ignores changes on specific PRs by adding a ignored keyword in its title. Found: i18nIgnore.
You can change this by either removing the keyword above from the PR's title, or modifying the ignoreKeywords property in your Lunaria configuration file.

Tracked Files

File
Note
Locale

src/content/docs/en/guides/rss.mdx
Source changed, localizations will be marked as outdated.
en

src/content/docs/es/guides/rss.mdx
Localization changed, will be marked as complete.
es

src/content/docs/fr/guides/rss.mdx
Localization changed, will be marked as complete.
fr

src/content/docs/ko/guides/rss.mdx
Localization changed, will be marked as complete.
ko

src/content/docs/zh-cn/guides/rss.mdx
Localization changed, will be marked as complete.
zh-cn

Warnings reference

Icon
Description

🔄
The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.


[XENOSCAPE] bug fix

Submission Checklist
Required

[x ] The pull request title clearly contains the name of the sheet I am editing.
[ x] The pull request title clearly states the type of change I am submitting (New Sheet/New Feature/Bugfix/etc.).
x[ ] The pull request makes changes to files in only one sub-folder.
[x ] The pull request does not contain changes to any json files in the translations folder (translation.json is permitted)

New Sheet Details

The name of this game is: <   >  (i.e. Dungeons & Dragons 5th Edition, The Dresden Files RPG)

The publisher of this game is: <   > (i.e. Wizards of the Coast, Evil Hat)

The name of this game system/family is: <   > (i.e. Dungeons & Dragons, FATE)

[ ] I have followed the Character Sheets Standards when building this sheet.

[ ] This sheet has been made on behalf of, or by, the game's publisher.
[ ] This game is not a traditionally published game, but a copy of the game rules can be purchased/downloaded/found at: <   >
[ ] This sheet is for an unofficial fan game, modification to an existing game, or a homebrew system.

Changes / Description

Hi @alessiaricci85
It appears there are merge conflicts on this branch; we can't merge this PR until they're resolved. You may want to rebase your fork.


Updated following README.md

Updated README-ja.md with Japanese translation following README.md.

Merging into 2020-maintenance-work branch. Thanks for the updates @taijihagino


Add media microservice backend

This PR resolves #24 and adds a new microservice media. This microservice has the following endpoints:

POST /media/upload an endpoint available only for users with scope media:write. The body is multipart/form-data with field file. The response is the id of the uploaded media file.

GET /media/<id> a public endpoint, returns a media file by id.

These new endpoints were added to the postman workspace:

Thanks for the review 🚀

I think there will be merge conflicts with the frontend pr later because I also made changes to the ERole and products microservice

I think it's much better to follow the Single responsibility principle and avoid changing backend in the frontend branch.


Network

Hello, can I ask you what changes you've made in tablemaster?Thank you！

I want to ask this question, too


GPIOD issues - loses connection with GPIO

What are the steps to reproduce?
Run node-red in the official docker container.
Verify that the gpiod nodes have connection to the gpiod (daemon). Check that gpio input node actually works (e.g. use a simple switch to connect pin 5 to ground and see "OK" changing to 1 or 0).

Wait an hour or two.
Check that gpio input node still works (in my setup it stoppes working). The gpiod node still states "OK" which indicates the gpio daemon is running. running ps aux confirms this. HOWEVER -connecting a pin to ground no longer makes the node change state.
restart the docker container - now it works again for a limited time.
Please tell us about your environment:

[ ] Node-RED version: 1.0.3
[ ] Node.js version: latest?
[ ] npm version: latest?
[ ] Platform/OS: latest docker image. host os raspian
[ ] Browser: google chrome (not a browser issue).

pigiod is latest version:

you've raised this issue in the main Node-RED project... the node itself is part of the node-red-nodes project and the docker container is part of the node-red-docker container.
Does this behaviour exist if you run it outside of docker ?

Apologies if I posted it the wrong place. I don’t know if the issue exists outside docker. Last time I used Node-RED outside docker, there was no PiGPIOdaemon and gpiod nodes - only default GPIO nodes (this was before version 1.0.)
Please share a link to the proper page, if this issue should be raised elsewhere.

Well the proper page depends if it fails outside of docker or not...
If it does still fail then https://github.com/node-red/node-red-nodes
else https://github.com/node-red/node-red-docker
(Also which raspberry Pi hardware and version of raspbian are you using ?)

Thanks. I don’t know if it fails outside docker, so I guess the best place is github.com/node-red/node-red-docker.
Running latest Raspbian buster on a Rpi 3B+

Closing as this isn't a core Node-RED issue


modelscope platform lacks user self-service account deletion function

Describe the feature
Features description
Motivation
A clear and concise description of the motivation of the feature. Ex1. It is inconvenient when [....]. Ex2. There is a recent paper [....], which is very helpful for [....].
Please refer to https://m.thepaper.cn/kuaibao_detail.jsp?contid=1936177&from=kuaibao
Related resources
If there is an official code release or third-party implementations, please also provide the information here, which would be very helpful.
Additional context
Add any other context or screenshots about the feature request here. If you would like to implement the feature and create a PR, please leave a comment here and that would be much appreciated.

the feature is currently in testing. stay tuned.

the feature was released last week.


fix: update to eye v9.0.9

fix: update to eye v9.0.9

:tada: This PR is included in version 11.0.5 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release
v11.0.5

Your semantic-release bot :package::rocket:


Bound ModelForm for a model with a TinyMCE field doesn't load the last update of the model instance data

I'm experiencing an issue with a ModelForm for a model with a description field using HTMLField().
Django Admin pages save and load data correctly but my custom view (still a propotype) seems to load the form and its widgets correctly, however it doesn't update the information that the ModelForm is bound to for the HTMLField() like the Django Admin. Instead, it keeps loading a version of the field content that seems to be that one that was given at the ModelForm class instanciation.
Here's my model (abridged)
class Ad(models.Model):      description = HTMLField()
Here's my ModelForm prototype:
class AdForm(ModelForm):     class Meta:         model = Ad         fields = [                 # other fields working correctly                 'description',             ]
Here's the view prototype:
`
@login_required
def modifica_annuncio(request):
try:
    annuncio_utente = Ad.objects.get(utente = request.user)
    form_annuncio = AdForm(instance=annuncio_utente)
except Exception as e:
    print(e) # which is never showing issues
    form_annuncio = AdForm()

context = {'form':form_annuncio}

return render(request, 'template_file.html', context)

`
How I'm using it in my template:
{{ form.media }} inside my <head> tag and {{ form }} where it belongs inside the <body> which includes the output of the field description, which outputs normally, including all the editor html.
I consistently experience a different behavior between the ModelForms from Admin pages which just update and load data correctly for that description field and my prototype which is always showing some sort of cached information, which doesn't change even if restart apache.
Is there anything I'm doing wrong with Django TinyMCE?

I'm unable to use code quotation properly, I'm sorry

It seems the browser itself was to blame, caching form content despite refreshing


CSRF Token and Cookie never match

I have CSRF enabled and it was working without any problems 2 weeks ago and then when I got back from a vacation it stopped working all of a sudden. I believe this to be a bug in Codeigniter 3 as I have not made any changes to my code.
The hidden field is being generated with a token in the value and a cookie is also being created but they do not match.
How can i get this resolved?

Please ask such questions on the forums ... we don't provide general support here.


Cannot find module webpack-dev-server

When following the "CONTRIBUTING" section in the README, I get the following error:
sbt @ metadoc > [error] module.js:491
[error]     throw err;
[error]     ^
[error]
[error] Error: Cannot find module '/data/rw/code/scala/scala-profiling/metadoc/metadoc-js/target/scalajs-bundler-webpack-dev-server/node_modules/webpack-dev-server/bin/webpack-dev-server.js'
[error]     at Function.Module._resolveFilename (module.js:489:15)
[error]     at Function.Module._load (module.js:439:25)
[error]     at Function.Module.runMain (module.js:609:10)
[error]     at startup (bootstrap_node.js:158:16)
[error]     at bootstrap_node.js:598:3

Executing the next command in the guide ~js/fastOptJS succeeds but the server is not spinned up, so I cannot open the Metadoc website.

Solution: to make this work, git clean -xdf and run the sbt commands again.

Cool, thanks for the workaround!


Add campaigns routes

Changes

Adds the following endpoints to the service:

GET /api/v1/locking/campaigns
GET /api/v1/locking/campaigns/:campaignId

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

38 of 38 (100.0%)  changed or added relevant lines in 7 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.02%) to 93.071%

Totals

Change from base Build<PHONE_NUMBER>:
0.02%

Covered Lines:
7075

Relevant Lines:
7320

💛  - Coveralls


Proposal to improve alerts

Oracle Price Server can send alerts to Slack and Sentry.io. The alerts look like this: Kraken is no response!. Our ops team is getting a lot of different alerts and it is important for them to understand where an alert is coming from.
To be able to better understand the alert I suggest to:

Prefix it with Terra Oracle Price Server.
Add an optional identification string to the config that will be send with the alert. This is important for people that run multiple price servers (e.g. in a HA scenario).

Example: Terra Oracle Price Server [instance-12345]: Kraken did not respond!
Furthermore it would be great to support more than just Slack. For example we use Atlassian OpsGenie as our alerting system. I know there are libraries that abstract away the differences between alerting systems. For example: https://github.com/containrrr/shoutrrr or https://github.com/caronc/apprise. I unfortunately do not know if similar libraries exist in the Javascript ecosystem.

Thanks for the suggestion. Since there's no one has experience with OpsGenie. We would appreciate PR for this.

Apologies for the delay. It's been a bit busy on my side. It's on my todo list to create a PR but I can't make any promises regarding timelines.

@JonasPf Great idea, I'll work on this.


python39Packages.openai: 0.11.5 -> 0.12.0

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python39Packages.openai is: "Python client library for the OpenAI API"
meta.homepage for python39Packages.openai is: "https://github.com/openai/openai-python"
meta.changelog for python39Packages.openai is: ""
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS
Warning: a test defined in passthru.tests did not pass
Warning: no invocation of /nix/store/5ssdw6yw8wnpfs4l0gffg6shfyvl7cgg-python3.9-openai-0.12.0/bin/.openai-wrapped had a zero exit code or showed the expected version
Warning: no invocation of /nix/store/5ssdw6yw8wnpfs4l0gffg6shfyvl7cgg-python3.9-openai-0.12.0/bin/openai had a zero exit code or showed the expected version
0 of 2 passed binary check by having a zero exit code.
0 of 2 passed binary check by having the new version present in output.
found 0.12.0 with grep in /nix/store/5ssdw6yw8wnpfs4l0gffg6shfyvl7cgg-python3.9-openai-0.12.0
found 0.12.0 in filename of file in /nix/store/5ssdw6yw8wnpfs4l0gffg6shfyvl7cgg-python3.9-openai-0.12.0

Rebuild report (if merged into master) (click to expand)

6 total rebuild path(s)

3 package rebuild(s)

3 x86_64-linux rebuild(s)
3 x86_64-darwin rebuild(s)

First fifty rebuilds by attrpath
openai
python310Packages.openai
python39Packages.openai

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/5ssdw6yw8wnpfs4l0gffg6shfyvl7cgg-python3.9-openai-0.12.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A python39Packages.openai https://github.com/r-ryantm/nixpkgs/archive/206d369867051e2052c197a4e5f60b981130f347.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/5ssdw6yw8wnpfs4l0gffg6shfyvl7cgg-python3.9-openai-0.12.0
ls -la /nix/store/5ssdw6yw8wnpfs4l0gffg6shfyvl7cgg-python3.9-openai-0.12.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

2 packages built:

openai (python39Packages.openai)
python310Packages.openai

Maintainer pings
cc @malob for testing.

@GrahamcOfBorg eval


stable grid independent from screen size

gridster tries to be smart about the screen size and rearranges widgets if they don't fit. That's undesired behavior and should be prevented.

bd3a32379a305f4e549bf0f6268d7b5157312580 should to the trick. It's more of a workaround than a proper solution, but gridster doesn't seem to offer a more straightforward solution to disable smart widget positioning.


Help email opens in same tab

Bug
In Chrome (but not Firefox), clicking the help button opened outlook in the same tab, which made me worried I had lost my progress.
It would be better to open it in a new tab or window.

Clicking the help button opened outlook in the same tab, which made me worried I had lost my progress. It would be better to open it in a new tab or window.

Now opens in email window.


download file does not work in Safari correctly

I am using the following to allow a user to download a generated zip file:
	$headers = Yii::$app->response->headers;
	$headers->set('Content-Disposition', "attachment; filename={$file_name}");
	$headers->set('Content-Type', 'application/zip');
	Yii::$app->response->content = $zipfile;
	return;

This works fine in every browser except Safari. Unfortunately, if the file name is file.zip, it downloads as file.zip.html
However, this works as expected:
header('Content-Type: application/zip');
header("Content-disposition: attachment; filename={$file_name}");
echo $zipfile;
exit;

Q
A

Yii version
2.0.?

PHP version

Operating system

Have you tried special response methods for file uploads?

I originally was going to use Yii::$app->response->sendContentAsFile($zipfile, $file_name)->send(); but was under the impression that there was a bug with this method. This is why I went with the Yii::$app->response->content = $zipfile;
However, I just tried Yii::$app->response->sendContentAsFile($zipfile, $file_name)->send();  on Mac in both Chrome and Safari and by golly, it did work. So, maybe whatever bug there was has been fixed.
Thanks for your attention.


docs: Documentation and clean up of bevy_input

Part of #3492.
Objective

Add and update the bevy_input documentation to achieve a 100% documentation coverage.
Add the #![warn(missing_docs)] lint to keep the documentation coverage for the future.

Solution

[x] Added and updated the documentation and tests.
[x] Added #[warn(missing_docs)] to the lib.rs file.
[x] Ran the cargo +nightly doc -p bevy_input --all-features --no-deps command with the RUSTDOCFLAGS="-Z unstable-options -- show-coverage" environment variable which returned a doc coverage of 100%.

Additional work
I did some additional work while documenting the crate. I'm happy to change/discuss any of these.
Tuple structs
I changed GamepadAxis, GamepadButton, Gamepad, GamepadEvent, and GamepadEventRaw to be normal structs instead of tuple structs. Main reason being is that tuple structs are not descriptive and extending them is harder.
Constructors
I added new() functions to GamepadAxis, GamepadButton, GamepadEvent, GamepadEventRaw, Gamepad, KeyboardInput, MouseButtonInput, MouseMotion, MouseWheel, and TouchInput. The main reason being that it made changing the tuple structs to normal structs easier. The Events also received a new() function that isn't used inside of Bevy, but I thought it would be a good idea to add them for consistency and also for users of Bevy that might use these to simulate inputs (for tests or even game logic).
Structure change
I split up the keyboard.rs, mouse.rs, gamepad.rs, and touch.rs files into smaller chunks, because some of these files were quite huge and hard to navigate (especially gamepad.rs).
Logic change
I changed the gamepad_connection_system to run after the InputSystem instead of in parallel, because this system checks the GamepadEvents which get send inside of the gamepad_event_system. This means that the gamepad_connection_system could respond to the events one frame later, instead of instantly resulting in one frame lag.
Old possible case:

gamepad_connection_system (reacts to the GamepadEvents too early)
gamepad_event_system (sends the GamepadEvents)

New:

gamepad_event_system (sends the GamepadEvents)
gamepad_connection_system (reacts to the GamepadEvents)

Removed constants
I removed the Axis::MIN and Axis::Max constants, because they were only used inside of one spot. I also removed the ALL_BUTTON_TYPES and ALL_AXIS_TYPES constants, because I added strum instead to use the EnumIter instead (as suggested by @alice-i-cecile).
Renamed ElementState
I renamed the ElementState to ButtonState as the old name was too generic and if something can be pressed it is automatically button-like (thanks to @alice-i-cecile for bringing it up).
Breaking Changes

GamepadAxis, GamepadButton, Gamepad, GamepadEvent, and GamepadEventRaw are no longer tuple structs. To create instances of them you would have to use the new() function or a struct literal.
The Axis::MIN, Axis::Max, ALL_BUTTON_TYPES and ALL_AXIS_TYPES constants have been removed. The minimum axis value is -1.0 and the maximum axis value is 1.0. To iterate through the GamepadButtonTypes and GamepadAxisTypes you can now use the iter() method provided by strum (GamepadButtonType::iter() or GamepadAxisType::iter()).
The ElementState received a rename and is now called ButtonState.

@alice-i-cecile Done.
There is still an open conversation about the exit_on_esc_system if you missed it. I'm considering if we might just remove it all together.

@KDecay WRT exist_on_esc_system, my feeling is that we need to take a holistic look at how we want to handle these "helper systems". There's a few of them scattered about the code base IIRC. My feeling is that they should probably be either in a separate crate, or in-lined into our examples.
Regardless, I think that's out of scope for this PR :)

I agree. It would be a great idea to collect them all and discuss what we want to do with them. I resolved the conversation for now.
Currently the only open thing in here is which type of struct creation we prefer:

Tuple structs
Struct literals
new() functions.

Currently the only open thing in here is which type of struct creation we prefer:

Tuple structs
Struct literals
new() functions.

@cart, when you get a chance could you weigh in on this? Then we'll add the decision to the style guide.

This PR should be merged before #3419.

the merge commit may have gone wrong

Did it? Looking at the Files changed I can't see any obvious things that went wrong. The merge conflict was cause because of the gamepad.rs file that got modified in #2934. I added a missing semicolon that was adding in there, but ignored the .iter() removal, because we now use strum to iterate through the enums.

My bad, somehow GitHub UI is not loading for me when I try to view the changes. Loading it when not connected to my account works fine 🤷

@bevyengine/docs-team Can I get a couple more eyes on this? IMO this should be merged ASAP, to unblock more improvements to bevy_input.

@BoxyUwU isn't thrilled with the addition of the strum dependency, and doesn't like the fact that their macro uses .iter as the method name. This is reasonable.
I wrote my own replacement for it here: https://github.com/Leafwing-Studios/leafwing_input_manager/blob/main/macros/src/actionlike.rs. Feel free to cannibalize that, or bug me to make a PR for this.

Done. You could create an issue for it so we don't forget and can worry about fixing it another time.

Going to close this down and split it into multiple smaller PR's to make it easier to review and merge.