[FLINK-28125] Promote leadership changing logs to INFO level

What is the purpose of the change
Promote leadership changing logs to INFO level.
Brief change log

Printing the INFO logs from DeafaultLeaderElectionService
Removing the contender side logs to avoid redundancy

Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): no
The public API, i.e., is any changed class annotated with @Public(Evolving): no
The serializers: no
The runtime per-record code paths (performance sensitive): no
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
The S3 file system connector: no

Documentation

Does this pull request introduce a new feature? no

@flinkbot run azure


Feature Request: Change default cache directory from home to project

Is your feature request related to a problem? Please describe.

I use flakeheaven in several projects and would like to be able to reset the cache under the project. I usually just do it with rm -rf .cache.
I had problems releated to issue https://github.com/flakeheaven/flakeheaven/issues/71. I removed one of the plugins from the venv project, but that plugin error still kept showing up after linter running. It wasn't obvious to me that flakeheaven was caching the results somewhere. I expected that if a cache is used, it would be in the project directory

Describe the solution you'd like

Why not make the project directory as the main one for the cache folder location? that's how it's done for pytest, mypy, etc.
There is no information of configuring the cache directory in the documentation. It would be nice to add a description of the variables FLAKEHEAVEN_CACHE and FLAKEHEAVEN_CACHE_TIMEOUT
Describe alternatives or workarounds you've considered

no ideas
Additional context

Other tools cache example:

P.S. I really love flakeheaven, thank you very much for this amazing tool! ❤

PRs for both contributions are welcome (docs and changing default location) :)

Great! I'll try to do it this week

Hi, @pwoolvett ! I made a PR, can you check it?


OAuth with Google

As a user, I want to be able to sign in to Gatekeeper with google
So that I don't need a new login/password for Gatekeeper
So that I can make a Gatekeeper account to track my passwords/subscriptions

setup commit - manual update


netshare volume plugin not working in "swarm mode" v1.12.0-rc3 with docker volume create, docker service create --mount

Output of docker version:
Client:
 Version:      1.12.0-rc3
 API version:  1.24
 Go version:   go1.6.2
 Git commit:   91e29e8
 Built:        Sat Jul  2 00:17:11 2016
 OS/Arch:      darwin/amd64

Server:
 Version:      1.12.0-rc3
 API version:  1.24
 Go version:   go1.6.2
 Git commit:   91e29e8
 Built:        Sat Jul  2 00:17:11 2016
 OS/Arch:      linux/amd64

Output of docker info:
Containers: 0
 Running: 0
 Paused: 0
 Stopped: 0
Images: 1
Server Version: 1.12.0-rc3
Storage Driver: aufs
 Root Dir: /mnt/sda1/var/lib/docker/aufs
 Backing Filesystem: extfs
 Dirs: 1
 Dirperm1 Supported: true
Logging Driver: json-file
Cgroup Driver: cgroupfs
Plugins:
 Volume: local nfs
 Network: overlay bridge host null
Swarm: active
 NodeID: 91wk9arjzrqnkzdvigu4wzcii
 IsManager: Yes
 Managers: 1
 Nodes: 4
 CACertHash: sha256:8e03c7e964a135ab6200346e7de585139e08b725d4fe62fd7dc0558104b838a6
Runtimes: runc
Default Runtime: runc
Security Options: seccomp
Kernel Version: 4.4.14-boot2docker
Operating System: Boot2Docker 1.12.0-rc3 (TCL 7.1); HEAD : 8d9ee9f - Sat Jul  2 05:02:44 UTC 2016
OSType: linux
Architecture: x86_64
CPUs: 1
Total Memory: 492.7 MiB
Name: swmaster-1
ID: I5SS:M4L6:ZKWZ:W37G:FJ24:VLMF:BCHA:LRAF:GVQ3:C2MR:INFO:WE3Y
Docker Root Dir: /mnt/sda1/var/lib/docker
Debug Mode (client): false
Debug Mode (server): true
 File Descriptors: 35
 Goroutines: 144
 System Time: 2016-07-09T18:57:45.749715718Z
 EventsListeners: 0
Registry: https://index.docker.io/v1/
Labels:
 provider=virtualbox
Insecure Registries:
 <IP_ADDRESS>/8

Additional environment details:
docker-machine create -d virtualbox \
      --virtualbox-boot2docker-url https://github.com/boot2docker/boot2docker/releases/download/v1.12.0-rc3/boot2docker.iso \
      --virtualbox-memory "512" swmaster-1

docker-machine create -d virtualbox \
      --virtualbox-boot2docker-url https://github.com/boot2docker/boot2docker/releases/download/v1.12.0-rc3/boot2docker.iso \
      --virtualbox-memory "512" swnode-1

docker $(docker-machine config swmaster-1) swarm init --listen-addr $(docker-machine ip swmaster-1):2377

docker $(docker-machine config swnode-1) swarm join $(docker-machine ip swmaster-1):2377 --listen-addr $(docker-machine ip swnode-1):2377

netshare is running in every host, including master https://github.com/ContainX/docker-volume-netshare/releases/download/v0.18/docker-volume-netshare_0.18_linux_amd64-bin:
sudo /var/lib/boot2docker/bin/docker-volume-netshare nfs -v 3 --basedir=/mnt
netshare is working with docker run -v
docker run -it --volume-driver=nfs -v <IP_ADDRESS>/Volumes/HDD/tmp:/mnt --name test1 alpine /bin/ls /mnt
## List all files in <IP_ADDRESS>/Volumes/HDD/tmp OK

netshare is not working with docker volume create + docker service create
docker volume create -d nfs --name /<IP_ADDRESS>/Volumes/HDD/tmp
docker service create --endpoint-mode dnsrr --mount type=volume,source=<IP_ADDRESS>/Volumes/HDD/tmp,target=/mnt,volume-driver=nfs --name test10 alpine ping uol.com.br

Nothing is mounted ...
docker service inspect test10 shows:
"Mounts": [
                        {
                            "Type": "volume",
                            "Source": "<IP_ADDRESS>/Volumes/HDD/tmp",
                            "Target": "/mnt",
                            "VolumeOptions": {
                                "DriverConfig": {
                                    "Name": "nfs"
                                }
                            }
                        }
                    ]

docker service tasks test10 shows:
ID                         NAME      SERVICE  IMAGE   LAST STATE          DESIRED STATE  NODE
3li5cdzauffoqhrlktpu72qhx  test10.1  test10   alpine  Running 20 minutes  Running        swnode-1

Inside swnode-1 docker ps -a shows:
463fd2f94510        alpine:latest       "ping uol.com.br"   7 minutes ago       Up 7 minutes                            test10.1.3li5cdzauffoqhrlktpu72qhx

And finally, docker inspect 463fd2f94510 shows:
Mounts": [
            {
                "Name": "48fc07f3be24cc706598e3082316cb547fdd93d24df3b97c78b6c8f4862edc52",
                "Source": "/mnt/sda1/var/lib/docker/volumes/48fc07f3be24cc706598e3082316cb547fdd93d24df3b97c78b6c8f4862edc52/_data",
                "Destination": "/mnt:ro,nocopy",
                "Driver": "local",
                "Mode": "",
                "RW": true,
                "Propagation": ""
            }
        ],

Inside the container test10.1 a folder named /mnt:ro,nocopy is created.
$ docker exec 463fd2f94510 /bin/ls /
bin
dev
etc
home
lib
linuxrc
media
mnt
mnt:ro,nocopy
proc
root
run
sbin
srv
sys
tmp
usr
var

If I change the target= to any other folder, I still getting 'folder_name:ro,nocopy' created inside the container.

netshare is not working with docker volume create + docker service create

docker volume create -d nfs --name /<IP_ADDRESS>/Volumes/HDD/tmp

What is the output of docker volume ls afterwards?
Could you try
docker volume create -d nfs --name somename -o share=<IP_ADDRESS>/Volumes/HDD/tmp

Havn't had time to play with 1.12-rc yet, however I found the following new example in the 1.12 docs
Could you try the follwoing example from the doc for creation of the volume?
$ docker volume create --driver local --opt type=nfs --opt o=addr=<IP_ADDRESS>,rw --opt device=:/path/to/dir --name foo

But I'd say that there is a problem within the new docker service command, because it seems to change the driver from nfs   to local (according to docker inspect).
Further the following output from docker service inspect looks strange:
                            "VolumeOptions": {
                                "DriverConfig": {
                                    "Name": "nfs"
                                }

I wouldn't expect to see  "Name": "nfs" rather I'd expect maybe  "Type": "nfs". But this is just guesing...
BTW: where did you found a detailed reference to the --mountOption of docker service create?

Hi, It seems docker team have done some work in 1.12.0-rc4 #24484
I will give it a try and let you know.
Do you know if ContainX is working with the experimental "docker plugin" command ?
For the --mount docs, I found this issue #24277
There is another issue (open or closed, i dont know) at https://github.com/docker/docker

With docker v1.12.1 in swarm mode I get:
$ docker volume create --driver=local --opt=type=nfs --opt=o=addr=<IP_ADDRESS>,rw --opt device=:/vol/vol_docker_registry_mirror --name=registry-mirror
registry-mirror
$ docker volume ls
DRIVER              VOLUME NAME
local               registry-mirror
$ docker volume inspect registry-mirror
[
    {
        "Name": "registry-mirror",
        "Driver": "local",
        "Mountpoint": "/var/lib/docker/volumes/registry-mirror/_data",
        "Labels": {},
        "Scope": "local"
    }
]

...at which point docker run -it --rm -v registry-mirror:/data ubuntu /bin/bash does work for me.
However, I'm mildly concerned.  When I ran this the first time, additional volumes (previously invisible) suddenly appeared.  The volumes were my previous attempts to get this to work. :-/

I was able to get a service to work, using that volume command.  But I had to run the volume command by hand on every node in the swarm.  It looks like it tried to auto-copy the volumes over, but it failed to work. :-/

@docwhat I can confirm that it works with your solution.
Docker version 1.12.1, build f1e1b83
Core-OS version 1164.1.0

# first create the volume on all nodes where the container is to be ran (core-03 in this example)
#
# if I don't create the volumes on each node the service will start without any error messages but the volume won't be mounted inside the container
docker volume create --driver=local --opt=type=nfs --opt=o=addr=<IP_ADDRESS>,rw --opt device=:/storage/mysql --name=mysql-staging

# start the service on core-03
docker service create --mount=type=volume,src=mysql-staging,dst=/mysql --name=nginx --constraint 'node.hostname == core-03' -p 8080:80 nginx

# verify that the volume is mounted in the container ran on core-03
docker exec a5f4b52bece4 mount | grep storage
:/storage/mysql on /mysql type nfs (rw,relatime,vers=3,rsize=65536,wsize=65536,namlen=255,hard,proto=tcp,timeo=600,retrans=2,sec=sys,mountaddr=<IP_ADDRESS>,mountvers=3,mountproto=tcp,local_lock=none,addr=<IP_ADDRESS>)

docker exec a5f4b52bece4 ls /mysql/data
auto.cnf
ib_buffer_pool
ib_logfile0
ib_logfile1
ibdata1
ibtmp1
mysql
performance_schema
sys

Everything works without docker-volume-netshare even beeing started. The only thing not working without the daemon started is docker volume ls, I get this error message:
list nfs: Post http://%2Frun%2Fdocker%2Fplugins%2Fnfs.sock/VolumeDriver.List: dial unix /run/docker/plugins/nfs.sock: connect: connection refused
DRIVER              VOLUME NAME
local               mysql-staging

But everything else is as said working.

Could someone clarify if it is required to create the volumes on every node in the swarm in order to get this to work? currently I am getting nfs volumes in the manager, but on the rest of the nodes I just get driver=local, seems like the swarm is distributing the volumes across the nodes but does not understand that the volumes are using the netshare plugin. Furthermore, @simonwahlgren seems to manage to mount nfs using the local driver, is there any disadvantage using this approach? does it also require to create the volumes in every node?

In Docker version 1.12.3, build 6b644ec and docker-volume-netshare_0.20:
You must create nfs volume on every node, otherwise the volume will be  empty.
leader,node2,node3
#run only in leader
docker volume create -d nfs --name nfshare -o share=${NFSHARE_SERVER}:/share
docker service create  \
  --mount type=volume,src=nfshare,dst=/share  \
  --publish 8080:80
   --replicas=10 \
   --name nginx nginx

Then ssh to node2, node3 and jump into nginx, the /share is empty.

@o3o3o As far as I know (I learnt this recently), this is the way volumes are supposed to work in swarm. The only supported way is to create the volume when creating the service: https://docs.docker.com/engine/reference/commandline/service_create/
In my opinion not a good approach, but I hope this is just because swarm node is quite new and they have not figured out everything just yet.

Are volumes suppose to persist across docker-volume-netshare service restarts?
I setup my volumes with the docker volumes command, but when restarting the docker-volume-netshare service they disappear. This worries me that the containers will lose their volumes if the host reboots.

@blandman they will not persist.

There's absolutely no way to define the volume when creating the service? I can get single nodes to work with the volumes, but not all nodes at the same time.

@blandman that's my predicament, too.  I don't want to have to manually create the volume on each host.

same problem here:
root@docker3:/opt# docker volume create --driver nfs --name netsharenfs -o share=<IP_ADDRESS>:/
netsharenfs
root@docker3:/opt# docker node ls
ID                            HOSTNAME            STATUS              AVAILABILITY        MANAGER STATUS
0zizhqemxr3fmhr949qqg94ly     docker1             Ready               Active
88qpfbyudpeqzrfabvhptnz36     docker2             Ready               Active
wx1fj0df7mdkihr5855xlfdcx *   docker3             Ready               Active              Leader
root@docker3:/opt# docker service create --mode=global --mount src=netsharenfs,dst=/nfs --name nfstest phusion/baseimage
fup2srz49c7p6uw9vu0bf8w82
Since --detach=false was not specified, tasks will be created in the background.
In a future release, --detach=false will become the default.
root@docker3:/opt# docker volume inspect netsharenfs
[
    {
        "Driver": "nfs",
        "Labels": {},
        "Mountpoint": "/var/lib/docker-volumes/netshare/nfs/netsharenfs",
        "Name": "netsharenfs",
        "Options": {
            "share": "<IP_ADDRESS>:/"
        },
        "Scope": "global"
    }
]

root@docker1:/opt# docker volume inspect netsharenfs
[
    {
        "Driver": "local",
        "Labels": null,
        "Mountpoint": "/var/lib/docker/volumes/netsharenfs/_data",
        "Name": "netsharenfs",
        "Options": {},
        "Scope": "local"
    }
]

root@docker2:/opt# docker volume inspect netsharenfs
[
    {
        "Driver": "local",
        "Labels": null,
        "Mountpoint": "/var/lib/docker/volumes/netsharenfs/_data",
        "Name": "netsharenfs",
        "Options": {},
        "Scope": "local"
    }
]

This problem has some time, so most likely won't be able to get much help, but nonetheless, I'll give it a shot, maybe someone can help...
I'm trying to use the plugin with Docker Swarm. Naturally, I don't want to have to manually create the volumes on every node, that's unthinkable, so I'm using a named volume, which means that if it doesn't exist, it's created, if it does, it re-uses it.
The command that I'm using to create the service is as follows
docker service create --name nuget-server --with-registry-auth \
--log-driver json-file --log-opt max-size=2mb \
--constraint 'node.role==worker' \
--mount 'type=volume,src=baget,dst=/var/baget,volume-driver=nfs,volume-opt=share=<IP_ADDRESS>:/mnt/volume_3/nfs/baget' \
--env ApiKey=some-random-key \
--env Storage__Type=FileSystem \
--env Storage__Path=/var/baget/packages \
--env Database__Type=Sqlite \
--env Search__Type=Database \
baget:latest

That seems to work, as it follows the parameters as when manually creating the volume. And it looks ok as well.
[
    {
        "CreatedAt": "0001-01-01T00:00:00Z",
        "Driver": "nfs",
        "Labels": {},
        "Mountpoint": "/var/lib/docker-volumes/netshare/nfs/baget",
        "Name": "baget",
        "Options": {
            "share": "<IP_ADDRESS>:/mnt/volume_3/nfs/baget"
        },
        "Scope": "local"
    }
]

So, it all looked good, until I try to write to the folder mapped to the volume, where I get an unauthorized error. Can anyone shed some light on this? Maybe I'm not doing the volume creation properly via service create?
Cheers


remove unnecessary slashes from url

remove unnecessary slashes from DRONE_HOST URL.

Signed-off-by: Bo-Yi Wu<EMAIL_ADDRESS>

@bradrydzewski I can fix the conflicts if you want to merge this PR.

we ended up separating the proto and host environment variables to reduce opportunity for misconfiguration:
DRONE_SERVER_PROTO=https
DRONE_SERVER_HOST=ec41d0de.ngrok.io


Testing futures

Type of change

Refactoring

Description
Extract a promise factory so that we can apply better testing around timeouts (and potentially other common behaviours in future)
Additional Context
Checklist
Please go through this checklist and make sure all applicable tasks have been done

[x] Write tests
[x] Make sure all tests pass
[ ] Review performance test results. Ensure that any degradations to performance numbers are understood and justified.
[x] Make sure all Sonarcloud warnings are addressed or are justifiably ignored.
[ ] Update documentation
[ ] Reference relevant issue(s) and close them after merging
[ ] For user facing changes, update CHANGELOG.md (remember to include changes affecting the API of the test artefacts too).

Does this supercede #1125? We're now setting up cancellation for both usages of scheduled timeouts. The PR name/description makes it sound like refactoring only.

Does this supercede #1125? We're now setting up cancellation for both usages of scheduled timeouts. The PR name/description makes it sound like refactoring only.

I guess it sorta does, I was expecting #1125 to have been merged before this was ready so it would just have been a refactoring.


Arrange passing -Wall, check whether used compiler flags are supported

The first commit arranges passing -Wall to the compiler, checking whether compiler flags are supported before adding them to the set of used ones, and using CMake's built-in C/C++ standard selection smarts. The second adds final to declarations to avoid a compiler warning (and it is good practice, too).

Does the compiler complain for not adding final to structs? it looks weird to me. I'm fine adding final for final classes that derive for another one, but I don't see how it helps for classes and structs with no parent.

Does the compiler complain for not adding final to structs? it looks weird to me.

No, it doesn't… it just seemed a good idea to add final there because C++ allows “subclassing” a struct and also adding virtual methods to them. The idea is to avoid footguns: if someone subclasses a type, the compiler will bail because of the final and make us all think twice about how to do the subclassing properly.

I'm fine adding final for final classes that derive for another one, but I don't see how it helps for classes and structs with no parent.

For the ones with no parent, it makes the compiler forbid subclassing them.

Updated to add final only to the ViewBackend class.
@carlosgcampos, @mcatanzaro: WDYT about merging this now?

Updated to add final only to the ViewBackend class.
@carlosgcampos, @mcatanzaro: WDYT about merging this now?

LGTM


Articles created from templates can't be searched

When I create a KB article from a template article, it doesn't appear in the Knowledge Base Search control. A KB article created from scratch will appear though.
They are both published, same keywords, same subject

@ornellaLaleouse apologies for the slow response. The KB experience has evolved. If your issue still persists, please reach out to customer support.


Replace the existing list of node names by the list of mountains in the Alps

https://github.com/crate/elasticsearch/pull/90
Note: discard the second commit from the linked and current PRs if the idea with the sys.summits is not approved/accepted/etc.

@mfussenegger or @matriv can you finish the review?

@mfussenegger can you take a final look?

ack from jordi


Storage Monitor/Conversion Monitor equivalents?

Applied Energistics 2 has a block called the Storage Monitor that displays the count of an item on the network. This makes it easy to see at a glance when you're running low on certain resources. The Conversion Monitor is a Storage Monitor that also allows you to withdraw and store the displayed item into the network directly.
Here's a screenshot of a wall of Storage Monitors displaying the count of various items in my AE2 network:

It would be great to see something similar added to Refined Storage.

Greetings raoulvdberge,
Would it be possible to backport the storage monitor to 1.10.2?  I understand it's going to soon be an unfocused version for most mod developers as 1.12 is the new base, but since ExtraCells doesn't exist for 1.10 yet, AE2 doesn't support liquid storage.
Sorry for such an inconvenient request; I fully understand your decision to not do so.  I'll figure out another way otherwise.

No.

Understood, thanks anyway.


fix: Stack trace lost when exception is thrown the when using decorator

Please provide the issue number

Issue number: #353
Summary
When an exception is thrown inside a method which that is decorated with utilities the user should see the full stack trace for that exception.
Currently the stack traces is lost.
Changes

Please provide a summary of what's being changed

MethodAspectHandler interface update so that OnException does not return.
On each utility that implements MethodApstectHandler, we capture the exception with ExceptionDispatchInfo.
[ExceptionDispatchInfo](https://learn.microsoft.com/en-us/dotnet/api/system.runtime.exceptionservices.exceptiondispatchinfo?view=net-7.0&redirectedfrom=MSDN) is used to preserve the stack trace after an Exception is thrown, allowing you to catch that exception, not throwing it immediately (as part of a catch), and to raise such exception on a later point in the future.
Docs on how to Capture exceptions and rethrow later
Added tests that validate the stack trace is being sent to the client
User experience

Please share what the user experience looks like before and after this change

Checklist
Please leave checklist items unchecked if they do not apply to your change.

[x] Meets tenets criteria
[x] I have performed a self-review of this change
[x] Changes have been tested
[ ] Changes are documented
[x] PR title follows conventional commit semantics

Is this a breaking change?
RFC issue number:
Checklist:

[ ] Migration process documented
[ ] Implement warnings (if it can live side by side)

Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

Codecov Report
Patch coverage: 86.48% and project coverage change: +2.11 :tada:

Comparison is base (15e76b4) 69.19% compared to head (6490453) 71.31%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #357      +/-   ##
===========================================
+ Coverage    69.19%   71.31%   +2.11%
===========================================
  Files           79       79
  Lines         3464     3496      +32
===========================================
+ Hits          2397     2493      +96
+ Misses        1067     1003      -64

Flag
Coverage Δ

unittests
71.31% <86.48%> (+2.11%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...Powertools.Common/Aspects/MethodAspectAttribute.cs
37.93% <25.00%> (+37.93%)
:arrow_up:

...mbda.Powertools.Idempotency/IdempotentAttribute.cs
86.44% <93.10%> (+11.44%)
:arrow_up:

...ls.Idempotency/Persistence/BasePersistenceStore.cs
98.72% <100.00%> (ø)

...owertools.Logging/Internal/LoggingAspectHandler.cs
74.07% <100.00%> (+0.78%)
:arrow_up:

...owertools.Metrics/Internal/MetricsAspectHandler.cs
78.43% <100.00%> (+2.43%)
:arrow_up:

...owertools.Tracing/Internal/TracingAspectHandler.cs
93.33% <100.00%> (-0.79%)
:arrow_down:

... and 6 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Updating Vocalink version to 4997

Updating Vocalink version to 4997.

Codecov Report

Merging #4 (97c8354) into main (d163dbf) will decrease coverage by 0.16%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main       #4      +/-   ##
==========================================
- Coverage   97.70%   97.54%   -0.17%
==========================================
  Files          18       18
  Lines         611      611
==========================================
- Hits          597      596       -1
- Misses         14       15       +1

Impacted Files
Coverage Δ

random_uk_bank_account/utils/config.py
100.00% <100.00%> (ø)

random_uk_bank_account/generator/uk_account.py
98.87% <0.00%> (-1.13%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d163dbf...97c8354. Read the comment docs.


Undefined property: Jenssegers\Mongodb\Relations\BelongsTo::$otherKey

I upgrade to laravel 5.4 and i got an error when using relation belongs to.
Here is the file after I correct it in belongs.php
query->where($this->ownerKey, '=', $this->parent->{$this->foreignKey});
        }
    }

    /**
     * Set the constraints for an eager load of the relation.
     *
     * @param  array  $models
     */
    public function addEagerConstraints(array $models)
    {
        // We'll grab the primary key name of the related models since it could be set to
        // a non-standard name and not "id". We will then construct the constraint for
        // our eagerly loading query so it returns the proper models from execution.
        $key = $this->otherKey;

        $this->query->whereIn($key, $this->getEagerModelKeys($models));
    }
}

There seems to be something wrong with your PR?

Sorry already solved
Thank you
Sent from my iPad
On Feb 14, 2017, at 21:15, Jens Segers <notifications<EMAIL_ADDRESS>wrote:
There seems to be something wrong with your PR?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/jenssegers/laravel-mongodb/pull/1089#issuecomment-279717916, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AQA7gkrKAkekiQCy7IhyqQIUcCL81umIks5rcbcTgaJpZM4LtQC9.


Anoncreds schema endorsement

Adds the flow for schema endorsement.
The endorsement flow is triggered by the agent having an author role or by manually setting the create_transaction_for_endorser option request param.
The anoncreds registry submits the transaction based on wallet type, and the post processing (storing the schema in the wallet) is triggered by the transaction manager using a new anoncreds schema event.
The endorsement integration tests are run with anoncreds wallets on the endorser and author roles. Added unit tests mostly on the registry register schema flow.

Overall looks good.
I think we need to move where the ledger write actually happens, tho.  Right now the transaction manager writes to the ledger (https://github.com/hyperledger/aries-cloudagent-python/blob/main/aries_cloudagent/protocols/endorse_transaction/v1_0/manager.py#L428) and then emits the event that we listen for (https://github.com/hyperledger/aries-cloudagent-python/blob/main/aries_cloudagent/protocols/endorse_transaction/v1_0/manager.py#L526).
For anoncreds, I think the ledger write needs to move into our new (anoncreds) event handler method.

@ianco Ok, thanks. I will look into doing that, and add some unit tests and ping you when I'm finished.

The latest commit removes the extending of the registry interface, and instead implements the txn_submit method from within the legacy_indy registry. Author triggered txn_submits in the indy ledger and endorser manager complete_transaction create an instance of the LegacyIndyRegistry to submit the transactions.
This will still end up submitting the transaction from the indy ledger but will make sure that ledger is injected from the anoncreds registry.
One drawback is that because the transaction manager and ledger are imported from the ledger routes module on initialization, importing the LegacyIndyRegistry from the top level caused a circular import exception. To get around this the Registry is only imported when needed during anoncred transaction submit operations.

I fear I'm coming across as harsh but I think there were some mistakes made in the first iteration of endorser support in ACA-Py that really need to be corrected. As it stands, I think we're inheriting a bit too much of those mistakes in this iteration.

I fear I'm coming across as harsh but I think there were some mistakes made in the first iteration of endorser support in ACA-Py that really need to be corrected. As it stands, I think we're inheriting a bit too much of those mistakes in this iteration.

I think that's fair. A lot of this is new to me so I appreciate the feedback. Some of the things you mentioned I had been confused about. I don't think it should take to long.

I think I'm getting a grip on the old implementation and how we want it to change with anoncreds. This should be way better now.
One thing I noticed is that the GET /schema/{id} endpoint doesn't return the state, so you can't see it's finished though the api even though the record is updated. Not sure if that should be change as another ticket.
I added a state for transaction_requested and I used a random uuid for the job-id. Wasn't sure if this was exactly what we wanted to do.

One thing I noticed is that the GET /schema/{id} endpoint doesn't return the state, so you can't see it's finished though the api even though the record is updated. Not sure if that should be change as another ticket.

Isn't there a ledger transaction id that isn't available until the schema is written to the ledger?

One thing I noticed is that the GET /schema/{id} endpoint doesn't return the state, so you can't see it's finished though the api even though the record is updated. Not sure if that should be change as another ticket.

Isn't there a ledger transaction id that isn't available until the schema is written to the ledger?

That should still be there, yes. This is just for the anoncreds Result object. It has a state field I was setting to transaction_requested and then finished when it is written to the ledger. You can't ever see the finished state from the current GET api. Only the inner anoncreds object.

POST /schema
{
  "job_id": "db16fd5f8c094d62ba3d1722dacb2467",
  "schema_state": {
    "state": "transaction_requested",
    "schema_id": "WgWxqztrNooG92RXvxSTWv:2:author-schema:1.1",
    "schema": {
      "issuerId": "WgWxqztrNooG92RXvxSTWv",
      "attrNames": [
        "score"
      ],
      "name": "author-schema",
      "version": "1.1"
    }
  },
  "registration_metadata": {
    "txn": {
      "state": "request_sent",
      "created_at": "2024-01-30T00:08:21.960157Z",
      "updated_at": "2024-01-30T00:08:21.968250Z",
      "trace": false,
      "transaction_id": "7e664eb2-2ed0-460e-8411-b6858aeb2fa2",
      "_type": "https://didcomm.org/sign-attachment/1.0/signature-request",
      "signature_request": [
        {
          "context": "did:sov",
          "method": "add-signature",
          "signature_type": "default",
          "signer_goal_code": "aries.transaction.endorse",
          "author_goal_code": "aries.transaction.ledger.write"
        }
      ],
      "signature_response": [],
      "timing": {
        "expires_time": null
      },
      "formats": [
        {
          "attach_id": "4cef3a8f-b910-4794-9326-6f0a638d683c",
          "format"<EMAIL_ADDRESS>        }
      ],
      "messages_attach": [
        {
          "@id": "4cef3a8f-b910-4794-9326-6f0a638d683c",
          "mime-type": "application/json",
          "data": {
            "json": "{\"endorser\": \"6bX4vukUZxxGKm7f5bBkmN\", \"identifier\": \"FB5yHWKaZk59hiKqjJKEHs\", \"operation\": {\"data\": {\"attr_names\": [\"score\"], \"name\": \"author-schema\", \"version\": \"1.1\"}, \"type\": \"101\"}, \"protocolVersion\": 2, \"reqId\":<PHONE_NUMBER>954441235, \"signature\": \"5ihP9oXmgg6WRRMmNjHiiiP6W3r3S5xVfJFCru3BUzHSqiV6gkmRhvo3UgDzsTmQHU2Z4zp91hwU3cKHtLsG9xWA\"}"
          }
        }
      ],
      "meta_data": {
        "context": {
          "job_id": "db16fd5f8c094d62ba3d1722dacb2467",
          "schema_id": "WgWxqztrNooG92RXvxSTWv:2:author-schema:1.1"
        }
      },
      "connection_id": "2e64c27e-5c35-4090-87ef-a48e4db3f2ba"
    }
  }
}

GET /schems/{id}
  "schema": {
    "issuerId": "FB5yHWKaZk59hiKqjJKEHs",
    "attrNames": [
      "score"
    ],
    "name": "author-schema",
    "version": "1.1"
  },
  "schema_id": "FB5yHWKaZk59hiKqjJKEHs:2:author-schema:1.1",
  "resolution_metadata": {
    "ledger_id": null
  },
  "schema_metadata": {
    "seqNo": 1234
  }
}

A few comments but I think this is still a great first set of changes. I'm okay with my comments being ignored in the interest of unblocking this from moving forward!

I'll update it. I'd rather address them here before the next PR which will be a lot bigger.

@dbluhm Addressed the comments now.


Error install

Hi, I'm try to install the library following this guide but when run make all -j 5 get the following error
/home/vagrant/mongo-php-driver/src/libmongoc/src/mongoc/mongoc-config.h:156:30: error: operator '!=' has no left operand
 #if MONGOC_ENABLE_SASL_CYRUS != 1
                              ^
/home/vagrant/mongo-php-driver/src/libmongoc/src/mongoc/mongoc-config.h:167:29: error: operator '!=' has no left operand
 #if MONGOC_ENABLE_SASL_SSPI != 1

I believe this is the same issue described in https://github.com/mongodb/mongo-php-driver/issues/582. Please confirm if https://github.com/mongodb/mongo-php-driver/pull/595 addresses the problem for you.

Closing this due to inactivity. It's likely this was a duplicate of https://github.com/mongodb/mongo-php-driver/pull/595 and fixed by PHPC-964 in ext-mongodb 1.3.0.


transaction FAIL with no further info

https://polygonscan.com/tx/0x49ebdaae4fdf126c974e5a7e1198109454f9b9ce8aa5f2c4aa571192510a7793
seems to be the same error as before with the other contract, not sure how to troubleshoot this
finds plenty of opportunities, gas is set way higher than it needs to be just in case, also running in a VPS near the alchemy servers for improved speed

Are you using the latest code? That might be because of the burn address issue that I have solved recently.

peculiar, i must have messed up my Dir, have updated and will run today with same circumstances and post result.

@bpevreall hi there. Any news on your bot? Have you made a profit with this bot?


⚠ Jenkins Plugins Artifactory has degraded performance

In c360f97, Jenkins Plugins Artifactory (https://get.jenkins.io/plugins/artifactory/) experienced degraded performance:

HTTP code: 200
Response time: 1143 ms

Resolved: Jenkins Plugins Artifactory performance has improved in 3ec1426 after 16 minutes.


Edge is loading also the "nomodule" version of the bundle. Known missing feature.

We should find a better check for Edge for loading the correct bundle (module or no module bundle) because it's currently impossible using the nomodule property for the script. More info: https://developer.microsoft.com/en-us/microsoft-edge/platform/issues/10525830/

Isn't that already implemented (as per link above) ?

Yep. I just need to test before closing this one.

As per:
Edge 38.14393.2068.0
EdgeHTML 14.14393
We are still having the issue as you can see from the snapshot below. I think we need to wait before closing this one.

I was looking into it lately and there is pending bug in edge that cause to download nomodule but it will not execute it

Yep, it is mentioned in the first comment of the issue


Error on make up

When I run  make up I get this error

Step 1/4 : FROM hgraca/explicit-architecture:app.sfn.dev
ERROR: Service 'app' failed to build: manifest for hgraca/explicit-architecture:app.sfn.dev not found: manifest unknown: manifest unknown

Do I need to download the image first? if so there is an issue with image in https://hub.docker.com/r/hgraca/explicit-architecture

Hi,
Yes, that's possible.
I haven't maintained this in quite some time.
I will try to have a look later this week.
Tkx for the heads up.

Thank you very much Ill check it out!


Color settings not stored properly

My code color style settings for your wonderful Bash Support plugin seem to get reset on any update of the plugin or an update of the platform.  Any idea what that could be?
I happen to have some software that keeps my configs in sync between machines and after a sync, I made some changes to the color config, tried a sync again and it found no changes which suggests to me that the settings are being stored outside of the PhpStorm config directory, is that right?

I'm using Windows 10 x64, Using 64-bit PhpStorm w/ the latest Java 8...

@cpriest I checked this on Mac OS X. It seems to be alright.
Do you have a global or a project profile which contains the settings?
Could you please check your color file location whether there is a file named after you profile?
See https://www.jetbrains.com/help/phpstorm/2016.1/file-idea-properties.html?origin=old_help for the locations on the different platforms.

Yes, there is a Clint.icls file in the config\colors directory, is that
what you mean?
On 04/27 Wed 3:01 PM, J. Ansorg wrote:

@cpriest https://github.com/cpriest I checked this on Mac OS X. It
seems to be alright.
Do you have a global or a project profile which contains the settings?
Could you please check your color file location whether there is a
file named after you profile?
See
https://www.jetbrains.com/help/phpstorm/2016.1/file-idea-properties.html?origin=old_help
for the locations on the different platforms.
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
https://github.com/jansorg/BashSupport/issues/311#issuecomment-215210671


add a unit test

Pushing just to get thoughts on tooling (mocha, sinon, chai), code style (bdd, should, formatting) etc.
In actual anger i'd like to refactor some of the code at the same time so that its more testable
for example for these tests move the maps out of the functions then i can stub them when testing a function with conditionals more easily.

I made a slack channel https://zwave2mqtt.slack.com/archives/C011XBWV7QX to discuss if thats easier

Hi @chrisns, thanks for this, it is on my todo list from the start but I was always focused on features :rofl: I usually use other test suites like tap/tape but I think one or another it's the same the important is the result :) I think we could create tests for ZwaveClient and MqttClient separately and then some tests using Gateway and both clients. The problem is to test the zwave client we should create a FakeServer that emits events about nodes

yeah, i don't see the zwave (or mqtt) as a massive issue, it doesn't need to emit that much, just enough to prove that you've setup listeners.
cool, i'll plough on then, will make this not a draft PR when its a bit more meaningful

@chrisns add you to contributors list :) https://github.com/OpenZWave/Zwave2Mqtt/commit/c30ad261d402ea7cfa255fb32c99fe00ba382cd5

LGTM thanks @chrisns !


Create demo/dev factories to populate data #844

Purpose
Creates sample data which is tested and doesn't need maintenance like current fixtures do.
Ticket
https://github.com/toladata/TolaActivity/issues/844

Coverage increased (+1.1%) to 54.525% when pulling 8af075740abd3ade55dd7e70c36945f7e524abfd on Menda:844-demo-dev-factories into b4dcbc70d30e999c3b8d23c9e2ef42ae012f053e on toladata:dev-v2.

The file tola/management/commands/loadinitialdata.py is too long. It has to be modularized otherwise it will be hard to maintain @Menda


CoolSelect 3.5.2 : error vm.$coolSelect.options

Not sure why but since I upgraded to the latest version of coolSelect and Webpack I am getting this error  in my browser:

[Vue warn]: Error in render: "TypeError: undefined is not an object (evaluating '_vm.$coolSelect.options')"found in--->   at src/vue/component/message/new-message-component.vue

if I understand well, Vue is looking for an options prop ?
Removing the cool select component gets rid of the error
Could this be coming from webpack ?
here is my webpack config:

Big code
const path = require('path');
  const CopyWebpackPlugin = require('copy-webpack-plugin');
  const WebpackNotifierPlugin = require('webpack-notifier');
  const ManifestPlugin = require('webpack-manifest-plugin');
  const { CleanWebpackPlugin } = require('clean-webpack-plugin');
  const ProvidePlugin = require("webpack").ProvidePlugin;
  const { VueLoaderPlugin } = require('vue-loader')
  const MiniCssExtractPlugin = require('mini-css-extract-plugin')
  const TerserPlugin = require('terser-webpack-plugin');
  const CleanObsoleteChunks = require('webpack-clean-obsolete-chunks');
  const CKEditorWebpackPlugin = require( '@ckeditor/ckeditor5-dev-webpack-plugin' );
  const { styles } = require( '@ckeditor/ckeditor5-dev-utils' );

  module.exports = {

  optimization: {
    minimizer: [new TerserPlugin({
        parallel: true,
        terserOptions: {
            ecma: 5,
            warnings: false,
            parse: {},
            compress: {},
            mangle: true,
            module: false,
            output: null,
            toplevel: true,
            nameCache: null,
            ie8: true,
            keep_classnames: undefined,
            keep_fnames: false,
            safari10: true,
            html5_comments:false,
            webkit:true
        },
    })],
},

watchOptions: {
    ignored: ['node_modules']
},

entry: {
 ...
},

devtool: 'inline-source-map',

output: {
    path: path.resolve(__dirname,'./public/build'),
    filename: '[name]-[hash].js',
    publicPath: '/build/',
    library: ["library", "[name]"],
    libraryTarget: "umd"
},

module: {
    rules: [
        {
            test: /\.ts$/,
            exclude: /node_modules/,
            use: {
                loader: "babel-loader",
                options: {
                    presets: ['@babel/preset-typescript']
                }
            }
        },
        {
            test: /\.js$/,
            exclude: /node_modules/,
            use: {
                loader: "babel-loader",
                options: {
                    presets: ['@babel/preset-env']
                }
            }
        },
        {
            test: /\.(png|jpg|gif)$/,
            use: [
                {
                    loader: 'url-loader',
                    options: {
                        limit: 250
                    }
                }
            ]
        },
        {
            test: /\.svg/,
            use: [ 'raw-loader']
        },
        {
            test: /\.css$/,
            use: [

                {
                    loader: 'style-loader',
                    // options: {
                    //     singleton: true
                    // }
                },
                {
                    loader: 'postcss-loader',
                    options: styles.getPostCssConfig( {
                        themeImporter: {
                            themePath: require.resolve( '@ckeditor/ckeditor5-theme-lark' )
                        },
                        minify: true
                    } )
                },

            ]
        },
        {
            test: /\.scss$/,
            use: [
                "style-loader",
                "css-loader",
                "sass-loader"
            ]
        },
        {
            test: /\.vue$/,
            use: 'vue-loader'
        }
    ]
},

plugins: [

    new CopyWebpackPlugin([
        {
            from: 'assets',
            to: '../[path][name].[ext]',
            force: true,
            ignore: [ '.DS_Store', '.gitignore' ]
        }
    ]),

    new WebpackNotifierPlugin(
        {
            excludeWarnings: true
        }
    ),

    new ManifestPlugin(
        {
            basePath: 'build/',
            writeToFileEmit: true
        }
    ),

    new CleanWebpackPlugin(
        {
        verbose:  false,
        dry:      false,
        watch: true,
    }),

    new ProvidePlugin({
        $: "jquery",
        jQuery: "jquery"
    }),

    new MiniCssExtractPlugin({
        filename: '[name].css',
        chunkFilename: '[id].css',
    }),

    new VueLoaderPlugin(),

    new CKEditorWebpackPlugin( {
        language: 'en'
    } ),

    new CleanObsoleteChunks()

],
};

I am almost completely sure that an error occurs at this  place.
Webpack has nothing to do with it. Could you show what code you are responsible for installing this plugin. I mean this code.

I'm having the same problem, but I'm not installing it as a plugin. I'm using it with
import { CoolSelect } from 'vue-cool-select'
My guess is that the options object is only set during the plugin installation, leaving options undefined when imported as a component.

It might be because he is importing the component without installing the plugin. You define options only during the plugin installation and from skimming the code I see that options is only ever used in one place. If thats the case you should make noData into a prop so that the component can work regardless of being installed or imported.

@dubonzi there is a point in your words, but since I made it work through the plugin, there is no sense in changing it.
For now I close the issue, because I have not received more information from @signmeuptwice.

@iliyaZelenko I was also using it as a plugin like import { CoolSelect } from ... NOT using (Vue.use(CoolSelectPlugin))
Used to work fine before then broken since update.
I have since moved to another select plugin so not on it anymore but the bug remains.

As far as I can see, the code for installing the plugin was needed before. If you did not write the plugin installation code before, then this really did not cause an error, but in fact it is not the correct use, which caused your problem.
To solve this error is simple, it is to add the code Vue.use(CoolSelectPlugin) and that’s it.


IOTDB-1140 optimize regular data encoding

current regular data encoding algorithm：
Calculate the difference between two adjacent values. The smallest difference is used as the equal-frequency frequency.
Determine the data range of this batch of data based on the difference between the last value and the first value.
Traverse this batch of data, use a BitSet, compare the difference between two adjacent values with the same frequency, and save the value true by default,
If the value is not equal to the equal frequency, calculate the number of equal frequency differences and set the value to false at the corresponding position, indicating that the point is a missing point.
this algorithm only can identity missing point, if have error point , it will throw exception..
because BitSet only can do this thing, indicates whether the same frequency exists in a segment of data
But there is some optimize point..
If there is an abnormal value in a column of values, the algorithm is deviated if the difference is directly obtained to the minimum value.
sample: 1000，1100，1800，1400，1500...
current algorithm be do not use...
1800 is a error point, we should identity error point, revise data.
revise data should be : 1000，1100，1300，1400，1500
After discussion , solution:

The value cannot be in regular encoding.
time_encoder can not alter after service start.

@jixuan1989 @qiaojialin  hi , could you please review this PR?
Thanks...


Web UI - problem displaying collections

My environment running ArangoDB
I'm using the latest ArangoDB of the respective release series:

[X] 3.2

Mode:

[X] Cluster

Storage-Engine:

[X] mmfiles

On this operating system:

[ ] Linux

[X] Ubuntu .deb

We were in 3.1.27 and decided to set up a cluster, so we upgraded to 3.2.3. After that, we set up the cluster and deployed it with Docker. The config is 3 coordinators and 2 db_servers. Yesterday, we upgraded to 3.2.4.
This is an example of coordinator configuration in docker-compose file:
coordinator1:
  image: arangodb/arangodb
  environment:
  - ARANGO_NO_AUTH=1
  command: arangod --server.authentication=false --server.endpoint tcp://<IP_ADDRESS>:8529 --cluster.my-address tcp://coordinator1:8529 --cluster.my-local-info coord1  --cluster.my-role COORDINATOR --cluster.agency-endpoint tcp://agency1:8529 --log.file /var/log/arangodb3/arangod.log
  volumes:
  - ./data/c1:/var/lib/arangodb3
  - ./apps/c1:/var/lib/arangodb3-apps
  - ./logs/c1:/var/log/arangodb3
  ports: ['8629:8529']
  depends_on:
  - agency1

And this is an example of db server:
db1:
  image: arangodb/arangodb
  environment:
  - ARANGO_NO_AUTH=1
  command: arangod --server.authentication=false --server.endpoint tcp://<IP_ADDRESS>:8529 --cluster.my-address tcp://db1:8529 --cluster.my-local-info db1 --cluster.my-role PRIMARY --cluster.agency-endpoint tcp://agency1:8529 --log.file /var/log/arangodb3/arangod.log
  volumes:
  - ./data/d1:/var/lib/arangodb3
  - ./logs/d1:/var/log/arangodb3
  depends_on:
  - agency1
  - coordinator1
  - coordinator2

this is a web interface-related issue:
I'm using the web interface with this browser:  Chrome   running on this OS: Ubuntu 16.04

[X] authentication is enabled?
[X] using the cluster?
[X] _system database?

These are the steps to reproduce:

open the browser and got to my local web UI
log in as root
use database [ ] _system [X] other: "assistant"
click to any collection
There are some pages with documents, but documents are not visible

The following problem occurs:
The web UI display various pages in collection but documents are not displayed

Instead I would be expecting:
Documents displayed in collection view

Hello, can you attach the dump of your database with arangodumb in order to reproduce the problem?

Sure! This is the file:
arango_dump.zip

Hi @sergionov ,
Thank you for opening this issue. I have reproduced the problem with v. 3.2.5
We will work to find a fix
Thanks again,

Hi @sergionov,
We have pushed a fix for this problem in v. 3.2.6, which has been released today
Please let us know if there is anything else we can do to help you or we can close this ticket
Many thanks,

Hi, I am from @sergionov team.
We just deployed a brand new ArangoDB 3.2.6 cluster with an agency of three coordinators and two databases completely from scratch. We create a collection with two documents as a test and the bug is still there. You may see in the screenshot that the two docs where stored but the WebUI does not show them.

Hi,
New info about this issue in case it is useful. When running a single instance of Arango 3.2.6 using Docker (in the same environment we are running our cluster mentioned in the previous comment), the problem is fixed and we can see the documents inside the collections.
Apparently the problem of being unable to see the documents inside a collection comes when running an Arango cluster and not with individual instances.
Thank you for your help,

Hi,
This is a problem that occurs during the loading of collections.
The UI should show a throbber while the server is warming up the collection, and load the dataset to show once thats done.

Hi,
with ArangoDB 3.7 support for the MMFiles storage engine has been dropped.
Please find the release note here:
https://www.arangodb.com/2020/08/arangodb-3-7-a-big-step-forward-for-multi-model/


jshint 2.6.3 doesnt define Promise anymore

which broke the build over in #18 for reasons unrelated to that PR.

LGTM


Couldn't keep to the domain

When I added -a, but I should be able to do either:
-a, --additional
With
node --max-old-space-size=6000 --no-deprecation purple-a11y/cli.js -u https://www.whitehouse.gov -c 2 -s same-domain -p 50  -a none --blacklistedPatternsFilename ./pa-gTracker-exclude-medicare.csv -k "Random<EMAIL_ADDRESS>It ran fine, but I found sub-domains in the returned results.

Hi @mgifford, -s same-domain will result in scan results from any sub-domain of the parent domain. E.g. scanning -s same-domain -u tom.example.tld will make it possible to scan jerry.example.tld and example.tld.
If you wish to stick to just scan tom.example.tld, then specify -s same-hostname.
Marking this issue as closed.  Let me know if you encountered otherwise. :)

I read this completely wrong:

-s, --strategy              Strategy to choose which links to crawl in
a website scan. Defaults to "same-domain".
[choices: "same-domain", "same-hostname"]

It's not useful to go into a discussion of domain vs hostname, but maybe it is possible to change the help text.
Maybe something like:

-s, --strategy            Crawl specific hostname or more general domain
Defaults to "same-domain", which includes sub-domains.
[choices: "same-domain", "same-hostname"]

Maybe it's just me though @younglim

Thanks @mgifford!  I have re-word it to as follows so it's clearer:
  -s, --strategy                     Crawls up to general (same parent) domains,
                                      or only specific hostname. Defaults to "sa
                                     me-domain".
                                       [choices: "same-domain", "same-hostname"]


npm install fails

Bug Report or Feature Request (mark with an x)
- [x] bug report -> please search issues before submitting
- [ ] feature request

Command (mark with an x)
- [ ] new
- [ ] build
- [ ] serve
- [ ] test
- [ ] e2e
- [ ] generate
- [ ] add
- [ ] update
- [ ] lint
- [ ] xi18n
- [ ] run
- [ ] config
- [ ] help
- [ ] version
- [ ] doc

Versions
node v8.12.0
npm 6.4.1
Windows8
Repro steps
npm install -g @angular/cli
The log given by the failure

npm ERR! code ETARGET
npm ERR! notarget No matching version found for<EMAIL_ADDRESS>npm ERR! notarget In most cases you or one of your dependencies are requesting
npm ERR! notarget a package version that doesn't exist.
npm ERR! notarget
npm ERR! notarget It was specified as a dependency of '@angular/cli'
npm ERR! notarget
Desired functionality
Us a dependency of @angular-devkit/core that is accually released
Mention any other details that might be useful

Same here


Storage variables

I am taking this issue alongside #918 because they are related

This was addressed on https://github.com/NethermindEth/warp/pull/958 as what was needed for ERC20 to work was already covered with the generated functions modified in that PR
Some errors related to this task were also addressed in https://github.com/NethermindEth/warp/pull/983


[backport] Bump supported NumPy & SciPy versions

Backport of #7992 by @kmaehashi

@kmaehashi We should backport https://github.com/cupy/cupy/commit/0c483d7c2489a69abdea9b943d14fef3f8009d8a to pass build-cuda test?

/test mini


call stop on consumer class when trapping signals

As we're rewriting our consumers we've noticed that there's one case we can't handle with racecar right now.  This PR would allow us to have the same behaviour in racecar.

Made some adjustments & added notes to README.


docs: clarify motivations

In the motivation.md, I would push even more on the current problems enumeration (with publishable packages e2e tests):

complex and redundant setup
can’t be parallelized due to file conflicts (and potential locks from npm/git)
non-optimized flow, as not cacheable

Yes, I will put all 3 mentioned points in the motivation doc and add more details as well as examples.

Added more information on:

can’t be parallelized due to file conflicts (and potential locks from npm/git)
non-optimized flow, as not cacheable


More robust keycloak

Better handling of keycloak

Looks good, makes the keycloak deployment/installation more reliable and robust 👍
If I understand it correctly a new file is generated in the case of the online option in the quickstart.shscript: keycloak/realm-config/chorus-realm.json.bu
If that's the case we should add that to the .gitignore file as well.


[EventRequest] Table 5093 "Opportunity Entry".UpdateOppFromOpp

Please add new event
    procedure UpdateOppFromOpp(var Opp: Record Opportunity)
    begin
        Opp.TestField(Closed, false);
        DeleteAll();
        Init;
        Validate("Opportunity No.", Opp."No.");
        "Sales Cycle Code" := Opp."Sales Cycle Code";
        "Contact No." := Opp."Contact No.";
        "Contact Company No." := Opp."Contact Company No.";
        "Salesperson Code" := Opp."Salesperson Code";
        "Campaign No." := Opp."Campaign No.";

	//---------------------------------------OnUpdateOppFromOppOnBeforeStartWizard2:BEGIN
	OnUpdateOppFromOppOnBeforeStartWizard2(Opp,Rec)
	//---------------------------------------OnUpdateOppFromOppOnBeforeStartWizard2:END

        StartWizard2;
    end;

    //---------------------------------------OnUpdateOppFromOppOnBeforeStartWizard2:BEGIN
    [IntegrationEvent(false, false)]
    local procedure OnUpdateOppFromOppOnBeforeStartWizard2(Opp: Record Opportunity; var OpportunityEntry: Record "Opportunity Entry")
    begin
    end;
    //---------------------------------------OnUpdateOppFromOppOnBeforeStartWizard2:END

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.


How to sync in the OpenEye license?

Hi I am trying to use the openduck protocol from AMBER. I have amber22 installed and openeye toolkits in my home folder as well. I installed openduck following the steps.
I then went to the example folder and ran this:
openduck amber-prepare -y test1.yaml -l ../../data/cdk2_lig.mol -r ../../data/2r3k.pdb
It says it cannot locate the openeye toolkits, how do I point it to the openeye toolkits installation? Also how do I point it to my amber22 installation folder location?
Thanks

Hello @debarati31,
The OpenEye toolkit is a warning that is automatically pushed by the openff-toolkit library. OpenEye is not needed nor used for the openduck preparation.
The error you see in the examples on the test is a problem in the receptor (it has a dioxy-cystein, a non-standard residue). It is my mistake, as the tests are still not well setup. In order not to cause confusion I have moved them away from the main branch. If you require a tutorial or test system to learn the method I have a (still work in progress) tutorial here : https://github.com/AlvaroSmorras/openduck-tutorial , where the simulations are pre-computed. You are free to check it, of course.
Regarding 'pointing' the OpenEye and Amber installations to openduck, you don't need to do that. We use antechamber (sqm) to calculate the partial charges and the simulations are independent from the system preparation with openduck. Once you have the systems prepared, you can activate amber and launch the simulations (you can also do the preparation and the simulations in different computers, they are completely independent). Just ensure you have python3 with numpy available for the getWqbValues.py script.
I hope this answers your questions,
Álvaro


Does the manager supports setting passwords on tags?

Our library supports sending raw commands to NFC tags.
The password setting feature for a particular NFC tag normally involve several custom commands, which CAN be implemented using this library, but we don't provide these flows directly in it.


steamtinkerlaunch missing dependencies?

To get steamtinkerlaunch working I had to sudo pacman -Syu yad xdotool org-xwininfo. Fwiw, I'm using gnome but am still using protonup-qt before this commit because I couldn't find an option in ProtonPlus to install it 🤷

These dependencies weren't in bazzite-arch, they are now. Thanks!


Camera zoom as Vec2

Summary:
Would like the zoom to be a Vec2 instead of f32.
Why is this needed?
To do aspect ratio independent zooming. Useful to create a zoom value like this zoom = desired_game_size / viewport_size

This wouldn't be too hard to do - the underlying matrix already takes an X and Y parameter. It'd probably make sense to call it scale instead (for consistency with DrawParams) and change it to a Vec2. That would be a breaking change, though, so I'm not sure if there's a way I can do this until 0.6.
That said, Camera is deliberately designed to only use Tetra's public API - therefore, it's entirely possible for you to copy and paste it into your project and make modifications, if the current API doesn't suit your needs :) So hopefully that's an acceptable workaround for now.

This wouldn't be too hard to do - the underlying matrix already takes an X and Y parameter. It'd probably make sense to call it scale instead (for consistency with DrawParams) and change it to a Vec2. That would be a breaking change, though, so I'm not sure if there's a way I can do this until 0.6.
That said, Camera is deliberately designed to only use Tetra's public API - therefore, it's entirely possible for you to copy and paste it into your project and make modifications, if the current API doesn't suit your needs :) So hopefully that's an acceptable workaround for now.

Done on the 0.6 branch.

Done on the 0.6 branch.


Host Port Configuration

Is an existing page relevant?
No response
What karpenter features are relevant?
Problem
IF aws-load-balancer controller is already present in a single node EKS cluster, Karpenter fails to startup and stays in a pending state with the error:
Warning  FailedScheduling  33s (x6 over 3m55s)  default-scheduler  0/1 nodes are available: 1 node(s) didn't have free ports for the requested pod ports.

This is because host port 8080, which is the port Karpenter expects to bind http-metrics to, is already in use by the aws-load-balancer controller metrics-server. This is currently not configurable in either open-source project.
Workaround
Option 1: Allow Karpenter to come online before the alb controller.
Option 2: Scale down alb controller to 0 to allow Karpenter to bind to port 8080 first, then allow Karpenter to recognize the alb controller as unschedulable and scale out accordingly.
Solution
Allow the host port to be configurable with something like:
controller:
  env:
  - name: METRICS_PORT
    value: "8088"
  - name: HEALTH_PROBE_PORT
    value: "8089"

https://github.com/aws/karpenter-core/blob/main/pkg/operator/options/options.go#L59
How should the docs be improved?
Troubleshooting guide could be improved to include a note on this subject until the host port becomes configurable.
Community Note

Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
If you are interested in working on this issue or have submitted a pull request, please leave a comment

I have exactly same issue with karpenter when trying to deploy it with host mode on the same nodes where ALB controller resides.

I'm confused. You can currently set this with env vars.
To be honest this does not work for some reason. I tried to did the similar settings before:

controller:
  env:
  - name: METRICS_PORT
    value: "8188"
  - name: HEALTH_PROBE_PORT
    value: "8189"

And it didn't helped. Moreover these ports just hardcoded in chart https://github.com/aws/karpenter/blob/main/charts/karpenter/templates/deployment.yaml#L88-L93.

@jtgorny forgot to add that I ended up with set metricsBindAddr: ":8180" on ALB controller chart and was able to successfully deploy karpenter on the same nodes as ALB.

I have exactly same issue with karpenter when trying to deploy it with host mode on the same nodes where ALB controller resides.

I'm confused. You can currently set this with env vars.

@ellistarn To be honest this does not work for some reason. I tried to did the similar settings before:
controller:
  env:
  - name: METRICS_PORT
    value: "8188"
  - name: HEALTH_PROBE_PORT
    value: "8189"

And it didn't helped. Moreover these ports just hardcoded in chart https://github.com/aws/karpenter/blob/main/charts/karpenter/templates/deployment.yaml#L88-L93.

Good point. You need to both set the pod port and the env var. Happy to accept a pull request on this.

Thanks for that @igor-nikiforov , setting the metricsBindAddr on the ALB controller worked for me. I must've missed this when skimming the docs initially as I opened this ticket under the impression this wasn't configurable on either project!
I do still think it would be convenient to configure this on Karpenter as well ¯_(ツ)_/¯

@ellistarn @jtgorny PR for this issue is already opened https://github.com/aws/karpenter/pull/3119. Hope it will be merged soon.

Needs a rebase, I think.


Working on server side ratelimiting

TODO:
Store data:

User ID
Post list (same as localstorage method)
IP?
Ratelimited bool

Closed
https://mastodon.social/@maxbittker/110295206683845564

Closed
https://mastodon.social/@maxbittker/110295206683845564


Button Group cuts off in Chrome

Current Behavior
When rendering a lot of options in a Button Group, then Chrome appears to be cutting off the content prematurely.
Chrome:

Safari:

Expected Behavior
No response
Steps To Reproduce
No response
Environment
No response
Have you provided an initial effort estimate for this issue?
I have provided an initial effort estimate

Narrowing down to chrome on iOs. Works fine with Chrome on windows. Most probably issue with flex-wrap there have been occasional problems with this. Not tools to investigate further.


Update residual-layers.lua to be consistent with other torch nn models

Hi,
I updated residual-layers.lua so that it can be used with other available layers in torch community.
I thought this might be useful for someone who might want to use the residual layer in their network architecture.
This might be not the preferred way of @gcr.
Anyway, thank you for sharing your review work.
Best regards,
Jaehyun

I see! Thank you -- I wasn't sure how to express this network in the usual Torch way, so I had to use the nngraph module. This example makes that clearer.

I just meant that the modification intended to make the layer be look-alike some tutorials in https://github.com/torch/torch7/wiki/Cheatsheet, e.g. https://github.com/soumith/imagenet-multiGPU.torch.
Thank you :)


Keyboard: Incorrectly typed letters are displayed on the confirm screen

Solved in this PR
https://github.com/Deykun/diffle-lang/pull/17

A new modal is used there now:

ℹ Released in 2.2


RichEditBox.ContextMenuOpening event reports wrong cursor position on W10 October Update

Describe the bug
As the title says, I noticed that the RichEditBox.ContextMenuOpening event reports an incorrect cursor position when running under W10 October Update. I should note that the app I'm working on is targeting the SDK 17134 at the moment, and I double checked on a PC with W10 April Update, and the same exact code works just fine there.
Here's a GIF that shows the issue, I'm opening a context menu with the offset reported by the event, and you can see it opens far away from the actual mouse cursor.

Steps to reproduce the bug

Steps to reproduce the behavior:

Create a new UWP app targeting either SDK 17134 or 17763
Place a RichEditBox in the root Grid
Add a handler to the ContextMenuOpening event
Paste this code in the handler:

e.Handled = true;
Rectangle rect = new Rectangle { Height = 50, Width = 50, Fill = new SolidColorBrush(Colors.Green) };
new Popup
{
    Child = rect,
    HorizontalOffset = e.CursorLeft,
    VerticalOffset = e.CursorTop,
    IsLightDismissEnabled = true,
    IsOpen = true
};

Expected behavior
The ContextMenuEventArgs CursorTop and CursorLeft properties should correctly report the mouse position, like the do when running on W10 April Update.
Version Info
Not using WinUI, this is just with the default SDK.
Windows 10 version:

[ ] Insider Build (xxxxx)
[X] October 2018 Update (17763)
[ ] April 2018 Update (17134)
[ ] Fall Creators Update (16299)
[ ] Creators Update (15063)
[ ] Anniversary Update (14393)

Device form factor:

[X] Desktop
[ ] Mobile
[ ] Xbox
[ ] Surface Hub
[ ] IoT

Good issue! This is going to be a problem lower down in the stack but I've filed an internal issue for tracking.

Hi @jevansaks - thanks for your reply!
Glad to hear opening this issue was good feedback for you! 😄
I can't see that internal issue though, please post an update here when you have some news about this!
Cheers, and merry Christmas! 🎅

Hey @jevansaks - sorry for the late reply!
I've just tried the workaround (just setting ContextFlyout="{x:Null}", as the RichEditBox.SelectionFlyout property isn't available in the 17134 SDK) and it did work the issue, the event is now reporting the right cursor offset and I can finally open the custom menu in the right position 🎉
Thank you so much for your help!
Cheers, have a nice day!


Ability to create Schema with new fields but same everytthing else

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
It is common downstream to manipulate Schamas in someway, such as to reorder the fields or select a subset of the fields
Schema also contains metadata, and thus care must be taken when creating derivative schemas to call Schema::new_with_metadata
Forgetting to do this has lead to several issues downstream in DataFusion -- see list on https://github.com/apache/datafusion/issues/12733
Describe the solution you'd like
I would like it to be easier to create a Schema with different fields and different properties
Describe alternatives you've considered

Additional context

Actually, reading the code i see SchemaBuilder already mostly does this, though it looks like it is not super clear how to specify a field subset. I will play around with some examples


[Storage] Add client-side encryption V2 for Queue

Adding a new version of client-side encryption supporting the use of AES-GCM.

API change check
API changes are not detected in this pull request.


Fixed profile redirects on new Mastodon versions

Closes Issue #10

Uses same query selector from the existing exstension but splits the string by new line. As newer versions have invisible text in the HTML element that causes the Mastodon server domain to be present twice separated by new lines. If an older server version is running there's only one element returned if not the array contains three strings.
For example userFromProfilePage from https://mastodon.social/@Mastodon returns:
['@Mastodon', <EMAIL_ADDRESS>'mastodon.social']

The first two elements can be concatenated to redirect the user.

Thanks for digging in and filing this PR. Fix is looking good!


fix missing field

fix missing field input for get operators method

@vitorhsb Thanks for the PR. Would you mind helping out with the Unit test to catch this?


Certain SSC Segments Can Trigger Invalid Noteskin States

In this example, some mines are faked, and when the arrows are held down, it gives the exact same color flash as hitting a Flawless persisting until the keys are released. Upon request of Kid, further investigation has proved that this problem acts exactly the same in Stepmania 5.0.12.
Sent with GitHawk

Even further investigation has been done, and it may turn out that the ReceptorOverlay acting twice on doubled input may be part of it.
Sent with GitHawk


how to get text from  Translated(src=en, dest=hi, text=वह एक अच्छा आदमी है।, pronunciation=None, extra_data="{'translat...")

from googletrans import Translator
translator = Translator()
Translation = ((translator.translate('वह एक अच्छा आदमी है।', dest='en')).text)
print(Translation)

I wanted to extract Hindi text part only from Translated(....).
I hope now you get my question.
On Fri, Jun 14, 2019, 6:11 PM Mr. Thicc<EMAIL_ADDRESS>wrote:

from googletrans import Translator
translator = Translator()
Translation = ((translator.translate('वह एक अच्छा आदमी है।',
dest='en')).text)
print(Translation)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/ssut/py-googletrans/issues/125?email_source=notifications&email_token=AI4P7FJQBUBLYZNFKALQN2LP2OGXBA5CNFSM4HYFP6V2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXWVTKY#issuecomment-502094251,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AI4P7FPJI7HEVEHV7HAQIALP2OGXBANCNFSM4HYFP6VQ
.

just add .text after the variable name then


TF with CUDA 11 and cuDNN 8

Enable TF-nightly with CUDA 11 and cuDNN 8 for Ubuntu and Windows.

NVIDIA pretty much pushed CUDA 10 out of the view. This team needs to have tf-nightly with CUDA 11. A lots of bugs are being introduced because of this not being to CUDA 11.

This bug is the tracking bug for converting to CUDA 11.

But this used to work.

Accidentally. We never tested it and breakages of something that was accidentally working were not discovered.
This bug tracks moving to building with CUDA 11 by default

As of now, i am building from source for Nvidia 11. But... we have to be careful though, the recent Nvidia update upended my system. :-( and had to spend lots of time figuring out.

the recent Nvidia update upended my system

@summa-code I recommend using docker if that works for your use case.

Well, i know i would have used docker if there are frequent issues in building in the source. But the problem was in the system level nvidia kernal. Reinstalling fixed the issue.

Hi all: We made the changes for Ubuntu last night. Changes for Windows should land soon.

Closing as nightly now uses CUDA 11


Add conftest.py to store pytest fixtures

PR Summary:
Same idea as #242 but using @ctk3b's suggestion of @pytest.fixture(scope="session")
Can't really verify on CI that the extraneous files aren't being written, but they're not in my local directory. Somebody else should grab these changes and runs tests to see that it works for them as well.
PR Checklist

[ ] Includes appropriate unit test(s)
[ ] Appropriate docstring(s) are added/updated
[ ] Code is (approximately) PEP8 compliant
[ ] Issue(s) raised/addressed?

It looks like tests with the pytest scope=session flag never get tested. It's not like they get skipped (has_mbuild=True and the testing output doesn't show the tests were skipped). Initially I didn't see any files being written so I thought it was working well, but I think it's because the tests aren't being run. This might just mean we have to learn more about this pytest fixture
(py36) ayang41@DeltaDurian:~/Programs/foyer/foyer/tests$ pytest -v test_forcefield.py --disable-warnings
================================== test session starts ===================================
platform darwin -- Python 3.6.7, pytest-4.5.0, py-1.8.0, pluggy-0.11.0 -- /Users/ayang41/anaconda3/envs/py36/bin/python
cachedir: .pytest_cache
rootdir: /Users/ayang41/Programs/foyer
collected 17 items

test_forcefield.py::test_load_files PASSED                                         [  5%]
test_forcefield.py::test_duplicate_type_definitions PASSED                         [ 11%]
test_forcefield.py::test_missing_type_definitions PASSED                           [ 17%]
test_forcefield.py::test_from_parmed PASSED                                        [ 23%]
test_forcefield.py::test_from_mbuild PASSED                                        [ 29%]
test_forcefield.py::test_preserve_resname PASSED                                   [ 35%]
test_forcefield.py::test_apply_residues PASSED                                     [ 41%]
test_forcefield.py::test_from_mbuild_customtype PASSED                             [ 47%]
test_forcefield.py::test_improper_dihedral PASSED                                  [ 52%]
test_forcefield.py::test_residue_map PASSED                                        [ 58%]
test_forcefield.py::test_independent_residues_molecules PASSED                     [ 64%]
test_forcefield.py::test_independent_residues_atoms PASSED                         [ 70%]
test_forcefield.py::test_topology_precedence PASSED                                [ 76%]
test_forcefield.py::test_missing_topo_params[ethane-angle-typo.xml-kwargs0] PASSED [ 82%]
test_forcefield.py::test_missing_topo_params[ethane-dihedral-typo.xml-kwargs1] PASSED [ 88%]
test_forcefield.py::test_overrides_space PASSED                                    [ 94%]
test_forcefield.py::test_assert_bonds PASSED                                       [100%]

========================= 17 passed, 41 warnings in 9.16 seconds =========================

Right, we don't actually check for this after the tests run. Maybe there should be something in the CI scripts to check for extraneous files like these (before the VM gets nuked)?
If you run the same tests on master it should have those files, like this:
(pytest-scope)$ git checkout master
Switched to branch 'master'
Your branch is up to date with 'upstream/master'.
(mosdef) [Clausius] ~/software/foyer
(master)$ pytest -q foyer/tests/test_forcefield.py --disable-warnings
.....................                                                    [100%]
21 passed, 62 warnings in 10.73 seconds
(mosdef) [Clausius] ~/software/foyer
(master)$ ls *xml *bib
ethane-multi.bib	ethane.bib		opls-snippet.xml
(mosdef) [Clausius] ~/software/foyer
(master)$ rm *xml *bib
(mosdef) [Clausius] ~/software/foyer
(master)$ git checkout pytest-scope
Switched to branch 'pytest-scope'
(mosdef) [Clausius] ~/software/foyer
(pytest-scope)$ pytest -q foyer/tests/test_forcefield.py --disable-warnings
.................                                                        [100%]
17 passed, 49 warnings in 7.57 seconds
(mosdef) [Clausius] ~/software/foyer
(pytest-scope)$ ls *xml *bib
ls: *bib: No such file or directory
ls: *xml: No such file or directory

Oops I didn't notice that those 4 tests aren't being run at all (21 vs 17 on the different branches).

Ah sorry I did not phrase my suggestions accurately. I think you want to do this:
https://docs.pytest.org/en/latest/fixture.html#conftest-py-sharing-fixture-functions
Basically take the existing
@pytest.fixture(autouse=True)
def initdir(self, tmpdir):
    tmpdir.chdir()

And put it in conftest.py
Sorry for the confusion.
If you have other reasons for wanting to use test classes then by all means

So moving that fixture into a conftest.py seems to do the trick. Note that this uses autouse=True instead of scope="session", but I I think that's what you mean to propose?
(pytest-scope *)$ pytest -q foyer/tests/test_forcefield.py --disable-warnings  ; ls *xml *bib
.....................                                                    [100%]
21 passed, 62 warnings in 10.34 seconds
ls: *bib: No such file or directory
ls: *xml: No such file or directory

I think that's what you mean to propose?

Yup - sorry for the hastily written suggestion


command: Add capability to use relative numbers in goto

With this change relative numbers are supported. They need to be prefixed with + or -. In case no prefix is given they're interpret as absolute numbers.
Currently it needs to be discussed if we stick to the introduced wrap-over handling or if we drop it.
Closes #2897

This breaks the feature added in https://github.com/zyedidia/micro/pull/1691 (changes the semantics of the minus sign), right?

:man_facepalming:
Yep, it break it.
From normal ruler point of view it maybe makes sense, although it's kind of static respective counted from a fixed position.
In relation with relativeruler being set it doesn't make that much sense any longer.

If you are suggesting to make the goto behavior dependent on the relativeruler setting, I'm not sure it's a good idea. Let's not introduce complex rules unnecessarily.
BTW, the current goto behavior is documented in help commands.
I don't need either of these features myself, so it don't know what makes sense and what doesn't. But apparently both features have their users. (I guess it's vim users that are used to "relative goto", and nano users that are used to "wrapped goto".) And there are no technical obstacles for us to provide both features, independently of each other and without limitations. Just need to come up with a nice interface allowing that.
For example, maybe just add a separate command for relative goto? Name it jump or something? Or maybe 2 separate commands, for jumping up and down?

Ok, to don't break the current interface/functionality it's then, as you mentioned, better to expose it on a separate way.

For example, maybe just add a separate command for relative goto? Name it jump or something? Or maybe 2 separate commands, for jumping up and down?

Hm, I'm no friend of having to functions for the same base functionality (up/down). I would prefer one own function (e.g. the mentioned relativegoto) or a further argument as we do for the search (-r for relative). I guess you will prefer the first, right?

I would prefer one own function (e.g. the mentioned relativegoto) or a further argument as we do for the search (-r for relative). I guess you will prefer the first, right?

Both seem fine to me (and neither seems perfect...), but as I said, I'm not gonna use that myself, so I'm not the one to judge what would be the best here from the user perspective.
We should also take into account that micro also has a default Ctrl+L shortcut for goto, so what should we do in this regard when it comes to relative goto? Add another shortcut for it? Or try to make Ctrl+L reusable (and convenient to use) for relative goto as well?
Thinking more about it, the behavior you implemented (i.e. + or - sign indicating that this a relative goto) actually seems the cleanest one to me (if it wasn't unfortunately incompatible with the already existing and documented behavior).

From my point of view the goto command should always work with one shortcut.
A normal number goes to the absolute line number, +xyz goes down xyz and -xyz goes up/back xyz number of lines.
This should not even be affected by which ruler (relative or absolute) you use at the moment.

A normal number goes to the absolute line number, +xyz goes down xyz and -xyz goes up/back xyz number of lines.

That's what this PR does. Unfortunately we've already one kind of behavior, which is derived from nano and documented accordingly. No matter at which position in the test file you are, in the moment you do a goto -# you will not go by # lines from the current position above but from the end of the file instead (see commands.md?plain=1#L34).
Now we've different approaches to solve this:

break with the previous implementation/approach and directly provide relative goto within the existing command by +/-
create the capability to have both together (which one would be preferred then?)

one new additional command e.g. relativegoto or jump
two new additional commands for the explicit direction

Maybe a community vote would be a good choice or a dictatorial decision. :wink:
@zyedidia
What are your thoughts?

Now I'm inclined to agree with @dase78 that providing relative goto within the existing command by +/- seems to be the nicest option. Yes, it would break compatibility, but maybe in this case we can let it go and not be dogmatic about that?
We can still provide the existing behavior as well, just with a different (incompatible) interface. How about the ~ (tilde) sign instead of the - sign for it?

Unfortunately we've already one kind of behavior, which is derived from nano and documented accordingly. No matter at which position in the test file you are, in the moment you do a goto -# you will not go by # lines from the current position above but from the end of the file instead...

Yes, right, I remember. I never ever used this kind of navigation, because for me it never made sense.

Now we've different approaches to solve this:
* break with the previous implementation/approach and directly provide relative goto within the existing command by +/-

* create the capability to have both together (which one would be preferred then?)

If I had to decide, I would let the nano-way go. I found it useless for my cases and workflow (never used it in nano also). But that's just my point of view. Some others may see it different.

We can still provide the existing behavior as well, just with a different (incompatible) interface. How about the ~ (tilde) sign instead of the - sign for it?

EDIT: The ~ could be a nice compromise to keep up all 3 kinds of fast navigation.

Yep, this sounds like a good idea to not fully loose this "feature".

Another idea would be:

#-> absolute linenumber
+# / -# -> "nano-movement"
j# / k# -> relative movement to actual linenumber

Myself would not be very happy about it, because I've never been a Vimuser and I don't find the shortcuts intuitive in any kind of way (that's one big reason, why I love Micro that much). But as mentioned from @dmaluka in another related topic, it seems, that many Vimusers are used to this navigation (relativeruler and jk).
My first vote would be #, +-~. This I would use heavily.

I will prepare this suggestion in the next few days and try to update the documentation accordingly.

Shall I already respect #2966?

This PR is now proudly present by @dmaluka  :wink:

I just noticed this breaks my #1691 patch with the latest build. It's a shame the behaviour has changed after 4 years.
Can this be reconsidered?
I use the "Nano way" daily to jump to the end of the document, having developed that habit since before Micro even existed.
In addition I find the new method where "goto 5" is absolute and "goto +5" is relative is completely unintuitive since numerically 5 and +5 are identical.
A better solution to stay compatible with other editors, as well as itself, would've been to use ~ (or another prefix) for relative goto. Or just use "jump" for relative goto.

@JoeKar Reverting then? We can always implement a serapate relativegoto command (with a separate default shortcut for it), if anyone needs it.

In addition I find the new method where "goto 5" is absolute and "goto +5" is relative is completely unintuitive since numerically 5 and +5 are identical.

Just for the record, this method is pretty common. Vim has used it since always, and vi used it before vim, and ed used it before vi.

A separate command would be perfect since it would allow the user to bind Ctrl+L to one command or the other, depending on their own preference.
Point taken about how vi does things. Though arguably vi's un-intuitiveness isn't something Micro should be emulating. :)

I use the "Nano way" daily to jump to the end of the document, having developed that habit since before Micro even existed.
Just as a second method, Ctrl+Up/Down brings you also at start/beginning of a document. But habits are habits. ;)

... We can always implement a serapate relativegoto command (with a separate default shortcut for it), if anyone needs it.
This was already mentioned earlier and would be great, don't know "jumpup" and "jumpdown"? Then we really could bind everything to own shortcuts. +1

Though arguably vi's un-intuitiveness isn't something Micro should be emulating. :)
I don't think, this is going to happen.;)

I've reverted it anyway, since user regressions are not good. I'll let you guys decide among yourselves how to proceed further.

Though arguably vi's un-intuitiveness isn't something Micro should be emulating.

Intuitiveness is subjective.

Ok, since it's reverted anyway already we should open #2897 again, where the whole story should be discussed and voted by the community. So please continue there...


Expose all libtorrent settings

Could it be possible to expose all libtorrent settings? If nowhere else then in the database? There's a lot an advanced user might want to change. If there's something PT absolutely needs to function these could be overrided from another table; existence of that table would be enough documentation.
And a default settings table so it'll be easy to return to PT install default settings if something's not right. Maybe an UI button to reset (if someone messed around the db maybe more messing around is not what's needed).

There's been requests for this before - and while I like the idea it also makes it extremely easy to break the client in unexpected ways 😄 As you said we definitely need a Reset to defaults button somewhere for this. I'll see if I can make something happen in a future version.

I'm closing this in favor of #667 which is the same issue reported.


Cleaned up some formatting in README

Capitalized all Microstate helper names
Added missing ) in Select example
Renamed 1st argument of Select to array from options

Hit merge please

😺


include total count param

[ X] I have checked that the CLI documentation and API documentation doesn't solve my issue

Description of the Issue
API results does not include the total_count field in the returned results.
Eg: box users:list --json
box CLI v1 used to include this in the results.

Box CLI: v2.2
Operating System: Windows 10, MacOS X
Steps to Reproduce
Run any command that return results as a list
box users:list --json
box events --json
Error Message, Including Stack Trace
n/a

@Band-Aid Unfortunately, I think adding this to the output would be a breaking change.  The JSON output for commands like box users:list is currently an array; we can't add total_count to it without changing the output type to an object.  The CLI always returns the full set of results; you should be able to parse or grep the JSON and count the number of elements in the array to get the total count.
If you use a tool like jq, you can do something like this to parse the JSON and get the correct length:
box users --json | jq '. | length'

Otherwise, since every user should have a "type": "user" line in the JSON, you could use grep to get the count like this:
box users --json | grep '"type": "user"' | wc -l


Add script to set DB schema before running ETL pipeline

Closes #2377
This makes it so that we don't start with a completely empty DB, we start with one that has the same schema as whatever is written in our pudl.metadata package.
This sidesteps the various concurrency issues with trying to make sure the schema is correct within the DAG run.
In the future, we might want to use migrations, or have some sort of non-concurrent setup op in the DAG, but for now this will provide a decent UX and hopefully get around the flakiness we've been seeing with the nightly builds (see #2469).
We decided to not use alembic for the migrations because of the slightly more complicated UX, but I think using it for diffing schemas is fine and I trust them more than I trust myself, to catch the various edge cases of "does this database setup look right?"

A tiny comment that isn't a blocker but would be nice to address.


[iOS] Location update are disabled after one kCLErrorLocationUnknown

Bug Report
Problem
On iOS, start requesting location updates. You reveive locations updates. Ok.
Put the app in background and make the phone in sleep mode (press the right button).
The app receive still some updates then an error is triggered. That is normal.
What is expected to happen?
When I wake up the phone and the app in foreground, I expect to be notified again with locations updates.
What does actually happen?
When you restart the app, no more updates.
In the error delegate, the plugin call "stopUpdatingLocation". I think there is no reason to do that.
Information
Command or Code
In locationManager:didFailWithError:
This code should be removed
if (error.code != kCLErrorLocationUnknown) {       [self.locationManager stopUpdatingLocation];       __locationStarted = NO;     }
Environment, Platform, Device
Tested on iPhone 13 mini iOS 15.1.1

In the error delegate, the plugin call "stopUpdatingLocation". I think there is no reason to do that.

I think this is intentional based on Apple's guidelines on handling location errors.

If the user denies your app's use of the location service, this method reports a kCLErrorDenied error. Upon receiving such an error, you should stop the location service.

The code:
https://github.com/apache/cordova-plugin-geolocation/blob/5957a80f644ac1d8477e501e99f7fa04f64b9a3d/src/ios/CDVLocation.m#L349-L352
follows this suggestion (although a bit too broadly) by stopping the service if the error is not an kCLErrorLocationUnknown error. The reason for this "not kCLErrorLocationUnknown" check is because kCLErrorLocationUnknown can safely be ignored.
I suspect that you're not receiving kCLErrorLocationUnknown here and when the app goes into the background, you're actualyl receiving a different error, likely kCLErrorDenied because you require special permissions for background location access.

Yes ok, that is a kCLErrorDenied. The problem is the JS side is not notified in this very case (the request has been stoped). Maybe we should pass something special to the error callback or add another specific callback (locationRequestStopped?).
Thank you.

No, lData is not null so the error callback seems to be called with PERMISSIONDENIED (=1).
But still it's hard to find out ... I guess we need

at least to document that (ios quirk : when you receive an error=1, the location service is stopped by the plugin so you should restart it when needed)
or you let the responsability to stop the service in the JS side (and document it : ios quirk : when you receive an error=1 the apple guideline ask you to stop the service)
or add another callback "locationServiceStopped" to simplify the handling of the restart.

What do you think ?

I think we fixed this issue with denied pull request. You can try. https://github.com/apache/cordova-plugin-geolocation/pull/225

No, lData is not null so the error callback seems to be called with PERMISSIONDENIED (=1).
But still it's hard to find out ... I guess we need

at least to document that (ios quirk : when you receive an error=1, the location service is stopped by the plugin so you should restart it when needed)
or you let the responsability to stop the service in the JS side (and document it : ios quirk : when you receive an error=1 the apple guideline ask you to stop the service)
or add another callback "locationServiceStopped" to simplify the handling of the restart.

What do you think ?

Based on https://developer.apple.com/documentation/corelocation/cllocationmanagerdelegate/1423786-locationmanager?language=objc

The location manager calls this method when it encounters an error trying to get the location or heading data. If the location service is unable to retrieve a location right away, it reports a kCLErrorLocationUnknown error and keeps trying. In such a situation, you can simply ignore the error and wait for a new event. If a heading could not be determined because of strong interference from nearby magnetic fields, this method returns kCLErrorHeadingFailure.
If the user denies your app's use of the location service, this method reports a kCLErrorDenied error. Upon receiving such an error, you should stop the location service.

I think perhaps we can proceed... If we are stopping location services on kCLErrorLocationUnknown, then perhaps that logic can be removed, as the apple docs states it can be ignored. I think we'd need to pay attention to make sure any configured timeouts are properly honoured.

Duplicate of: https://github.com/apache/cordova-plugin-geolocation/issues/224
I think we fixed this issue with denied pull request. You can try. https://github.com/apache/cordova-plugin-geolocation/pull/225

I don't think this is a duplicate because #224 is subjected around kCLErrorDenied and Apple explicitly states that the application should stop location services on this error code, so I believe the geolocation plugin behaviour in this case is intentional. This issue is in regards of kCLErrorLocationUnknown.
In either case, listening on the resume event and calling watchPosition again should be a sufficient workaround.


Send alert to external services

Why not use NotifyMe https://github.com/notifymehq for the alert to others services

Sounds like a good candidate for a plugin... https://github.com/alerta/alerta-contrib/tree/master/plugins Pull requests welcome.


Improve form rendering

Everyone who uses PDF forms is already used to how they are rendered natively in the Adobe Acrobat desktop client or the Reader web plugin.  Here are a few suggestions to consider:

Change the background color of form fields to #dde4ff
Change checkboxes to use a toggled font checkmark (i.e. Acrobat uses the "Adobe Pi Std" font (AdobePiStd.otf) for checkmarks)

Rendering Differences
Adobe Pi Std Font

I'm afraid we aren't allowed to see you Dropbox files, it'd be nice if you could upload them somewhere else :)

Sorry, the links should be working now...

Nope, now they're just pointing at the issue.
Den 07-03-2012 15:22, Edward J. Stembler skrev:

Sorry, the links should be working now...

Reply to this email directly or view it on GitHub:
https://github.com/mozilla/pdf.js/issues/1313#issuecomment-4368704

Okay, I had to moved them to my personal Dropbox account. Apparently they were being auto-deleted from the Team account I originally put them on.

#1459 seems to be some form of meta-issue.

For reference, here are the attached images (uploaded from Dropbox):

Differences:
Adobe Pi Std Font:

Also see #2738 concerning other Formfield/Font related issues

Closing as duplicate of #7613, in which we are tracking this.


Fix redis cache logic

Fix redis cache logic

Codecov Report

Merging #1 (a4d6e21) into master (a33b8c4) will increase coverage by 0.15%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master       #1      +/-   ##
==========================================
+ Coverage   96.82%   96.98%   +0.15%
==========================================
  Files          15       15
  Lines         252      265      +13
==========================================
+ Hits          244      257      +13
  Misses          8        8

Impacted Files
Coverage Δ

TestApi/Service/UserService.cs
100.00% <ø> (ø)

EasyCache.Core/Attributes/CacheableAttribute.cs
100.00% <100.00%> (ø)

EasyCache.Core/Entity/CacheItem.cs
100.00% <100.00%> (ø)

EasyCache.Redis/Driver/RedisCache.cs
100.00% <100.00%> (+4.34%)
:arrow_up:

TestApi/Program.cs
100.00% <100.00%> (ø)

EasyCache.InMemory/Setup/Setup.cs
0.00% <0.00%> (-60.00%)
:arrow_down:

EasyCache.Redis/Setup/Setup.cs
100.00% <0.00%> (+100.00%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a33b8c4...a4d6e21. Read the comment docs.