Unable to serve locally

Description
I am trying to bolt this onto an existing Next application however I am running into an issue when trying to run fastly-serve: next  build && cd compute-js && fastly compute verbose.
Process command:
	sh -c npx check-next-version && npx @fastly/compute-js-static-publish --build-static && $(npm bin)/webpack && $(npm bin)/js-compute-runtime ./bin/index.js ./bin/main.wasm

Next.js version: 12.3.0
Fastly Compute@Edge JavaScript Static Publisher
Building loader...
Public directory '/Users/AMorrison/Dunelm/TCB/mfe-web-aggregator'.
No static directories defined.
Using exclude directories: ./node_modules, ./compute-js, ./pages, ./.next/cache, ./
Applying 0 custom content type(s).
Using include directories: ./.next, ./static, ./public
Warning: Unknown file type /.next/BUILD_ID...
/.next/build-manifest.json: "application/json"
/.next/export-marker.json: "application/json"
/.next/images-manifest.json: "application/json"
/.next/next-server.js.nft.json: "application/json"
/.next/package.json: "application/json"
/.next/prerender-manifest.json: "application/json"
/.next/react-loadable-manifest.json: "application/json"
/.next/required-server-files.json: "application/json"
/.next/routes-manifest.json: "application/json"
/.next/serverless/chunks/120.js: "application/javascript"
/.next/serverless/chunks/173.js: "application/javascript"
/.next/serverless/chunks/242.js: "application/javascript"
/.next/serverless/chunks/322.js: "application/javascript"
/.next/serverless/chunks/669.js: "application/javascript"
/.next/serverless/chunks/787.js: "application/javascript"
/.next/serverless/chunks/font-manifest.json: "application/json"
/.next/serverless/font-manifest.json: "application/json"
/.next/serverless/middleware-manifest.json: "application/json"
/.next/serverless/pages/404.html: "text/html"
/.next/serverless/pages/500.html: "text/html"
/.next/serverless/pages/_error.js: "application/javascript"
/.next/serverless/pages/account/callback.html: "text/html"
/.next/serverless/pages/account.html: "text/html"
/.next/serverless/pages/checkout/payment/card.js: "application/javascript"
/.next/serverless/pages/checkout/payment.js: "application/javascript"
/.next/serverless/pages/checkout/success.js: "application/javascript"
/.next/serverless/pages/checkout.js: "application/javascript"
/.next/serverless/pages/product/[id].js: "application/javascript"
/.next/serverless/pages/product.js: "application/javascript"
/.next/serverless/pages-manifest.json: "application/json"
/.next/serverless/webpack-runtime.js: "application/javascript"
/.next/static/bOSiri3YDkdDfRKpquGTy/_buildManifest.js: "application/javascript"
/.next/static/bOSiri3YDkdDfRKpquGTy/_ssgManifest.js: "application/javascript"
/.next/static/chunks/framework-5f4595e5518b5600.js: "application/javascript"
/.next/static/chunks/main-8db7d21a15d54ad1.js: "application/javascript"
/.next/static/chunks/pages/_app-812465b832720c1e.js: "application/javascript"
/.next/static/chunks/pages/_error-a4ba2246ff8fb532.js: "application/javascript"
/.next/static/chunks/pages/account/callback-bc0546f99f624958.js: "application/javascript"
/.next/static/chunks/pages/account-bdda54fe61e1af28.js: "application/javascript"
/.next/static/chunks/pages/checkout/payment/card-234891b951cdbd84.js: "application/javascript"
/.next/static/chunks/pages/checkout/payment-f0ecb009b33de20a.js: "application/javascript"
/.next/static/chunks/pages/checkout/success-f6a03b23b958bc07.js: "application/javascript"
/.next/static/chunks/pages/checkout-1e04e751b75682af.js: "application/javascript"
/.next/static/chunks/pages/product/[id]-80116b732c66e801.js: "application/javascript"
/.next/static/chunks/pages/product-e84983e2b55144e5.js: "application/javascript"
/.next/static/chunks/polyfills-c67a75d1b6f99dc8.js: "application/javascript"
/.next/static/chunks/webpack-966019665164920b.js: "application/javascript"
Warning: Unknown file type /.next/trace...
Application is not a SPA.
Application specifies no 'not found (404)' page.
🚀 Wrote static file loader for 49 file(s).

Simply running fastly compute serve from inside the compute-js folder seems to isolate the problem to these two files
however these get generated during the next build process.
ERROR: error during execution process:

Warning: Unknown file type /.next/BUILD_ID...
Warning: Unknown file type /.next/trace....

Versions

"next": "12.3.0",
"@fastly/next-compute-js": "^0.4.1",

Hi, are you able to run fastly compute serve --verbose from your compute-js folder? Mainly I'd like to see what you get after the ERROR: error during execution process:.
And actually, those "Warning: Unknown file type" messages are actually not a problem and they can be ignored. I'll be suppressing them in the next release of this tool.

ahhh ok, running in verbose gives the following.
ERROR: error during execution process.

If you believe this error is the result of a bug, please file an issue: https://github.com/fastly/cli/issues/new?labels=bug&template=bug_report.md
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

No problem,
Fastly API endpoint: https://api.fastly.com
Verifying package manifest...
Verifying local javascript toolchain...

Checking if 'npm' is installed...
Found 'npm' at /Users/AMorrison/.nvm/versions/node/v16.13.0/bin/npm

Checking if manifest 'package.json' exists...
Found 'package.json' at /Users/AMorrison/Dunelm/TCB/mfe-web-aggregator/compute-js/package.json

Checking if '@fastly/js-compute' is defined in 'package.json'...
Found '@fastly/js-compute' in 'package.json'

Installing package dependencies...

up to date, audited 289 packages in 701ms

62 packages are looking for funding
  run `npm fund` for details

found 0 vulnerabilities

Checking if 'js-compute-runtime' is installed...
Found 'js-compute-runtime' at /Users/AMorrison/Dunelm/TCB/mfe-web-aggregator/compute-js/node_modules/.bin/js-compute-runtime

Checking manifest 'fastly.toml' contains a build script...
Found [scripts.build] 'npx check-next-version && npx @fastly/compute-js-static-publish --build-static && $(npm bin)/webpack && $(npm bin)/js-compute-runtime ./bin/index.js ./bin/main.wasm'

Running [scripts.build]...

Process command:
	sh -c npx check-next-version && npx @fastly/compute-js-static-publish --build-static && $(npm bin)/webpack && $(npm bin)/js-compute-runtime ./bin/index.js ./bin/main.wasm

Next.js version: 12.3.0
Fastly Compute@Edge JavaScript Static Publisher
Building loader...
Public directory '/Users/AMorrison/Dunelm/TCB/mfe-web-aggregator'.
No static directories defined.
Using exclude directories: ./node_modules, ./compute-js, ./pages, ./.next/cache, ./
Applying 0 custom content type(s).
Using include directories: ./.next, ./static, ./public
Warning: Unknown file type /.next/BUILD_ID...
/.next/build-manifest.json: "application/json"
/.next/export-marker.json: "application/json"
/.next/images-manifest.json: "application/json"
/.next/next-server.js.nft.json: "application/json"
/.next/package.json: "application/json"
/.next/prerender-manifest.json: "application/json"
/.next/react-loadable-manifest.json: "application/json"
/.next/required-server-files.json: "application/json"
/.next/routes-manifest.json: "application/json"
/.next/serverless/chunks/120.js: "application/javascript"
/.next/serverless/chunks/173.js: "application/javascript"
/.next/serverless/chunks/242.js: "application/javascript"
/.next/serverless/chunks/322.js: "application/javascript"
/.next/serverless/chunks/669.js: "application/javascript"
/.next/serverless/chunks/787.js: "application/javascript"
/.next/serverless/chunks/font-manifest.json: "application/json"
/.next/serverless/font-manifest.json: "application/json"
/.next/serverless/middleware-manifest.json: "application/json"
/.next/serverless/pages/404.html: "text/html"
/.next/serverless/pages/500.html: "text/html"
/.next/serverless/pages/_error.js: "application/javascript"
/.next/serverless/pages/account/callback.html: "text/html"
/.next/serverless/pages/account.html: "text/html"
/.next/serverless/pages/checkout/payment/card.js: "application/javascript"
/.next/serverless/pages/checkout/payment.js: "application/javascript"
/.next/serverless/pages/checkout/success.js: "application/javascript"
/.next/serverless/pages/checkout.js: "application/javascript"
/.next/serverless/pages/product/[id].js: "application/javascript"
/.next/serverless/pages/product.js: "application/javascript"
/.next/serverless/pages-manifest.json: "application/json"
/.next/serverless/webpack-runtime.js: "application/javascript"
/.next/static/bOSiri3YDkdDfRKpquGTy/_buildManifest.js: "application/javascript"
/.next/static/bOSiri3YDkdDfRKpquGTy/_ssgManifest.js: "application/javascript"
/.next/static/chunks/framework-5f4595e5518b5600.js: "application/javascript"
/.next/static/chunks/main-8db7d21a15d54ad1.js: "application/javascript"
/.next/static/chunks/pages/_app-812465b832720c1e.js: "application/javascript"
/.next/static/chunks/pages/_error-a4ba2246ff8fb532.js: "application/javascript"
/.next/static/chunks/pages/account/callback-bc0546f99f624958.js: "application/javascript"
/.next/static/chunks/pages/account-bdda54fe61e1af28.js: "application/javascript"
/.next/static/chunks/pages/checkout/payment/card-234891b951cdbd84.js: "application/javascript"
/.next/static/chunks/pages/checkout/payment-f0ecb009b33de20a.js: "application/javascript"
/.next/static/chunks/pages/checkout/success-f6a03b23b958bc07.js: "application/javascript"
/.next/static/chunks/pages/checkout-1e04e751b75682af.js: "application/javascript"
/.next/static/chunks/pages/product/[id]-80116b732c66e801.js: "application/javascript"
/.next/static/chunks/pages/product-e84983e2b55144e5.js: "application/javascript"
/.next/static/chunks/polyfills-c67a75d1b6f99dc8.js: "application/javascript"
/.next/static/chunks/webpack-966019665164920b.js: "application/javascript"
Warning: Unknown file type /.next/trace...
Application is not a SPA.
Application specifies no 'not found (404)' page.
🚀 Wrote static file loader for 49 file(s).

ERROR: error during execution process.

hm. I'm not seeing webpack running.
can I have you try something:

Go into your fastly.toml file in your compute-js folder, and then modify the build line under [scripts]

change where it says $(npm bin)/webpack to npx webpack and where it says $(npm bin)/js-compute-runtime to npx js-compute-runtime

and then try it again for me?

hmmm still seem to be getting the same result.
Process command:
	sh -c npx check-next-version && npx @fastly/compute-js-static-publish --build-static && npx webpack && npx js-compute-runtime ./bin/index.js ./bin/main.wasm

Next.js version: 12.3.0
Fastly Compute@Edge JavaScript Static Publisher
Building loader...
Public directory '/Users/AMorrison/Dunelm/TCB/mfe-web-aggregator'.
No static directories defined.
Using exclude directories: ./node_modules, ./compute-js, ./pages, ./.next/cache, ./
Applying 0 custom content type(s).
Using include directories: ./.next, ./static, ./public
Warning: Unknown file type /.next/BUILD_ID...
/.next/build-manifest.json: "application/json"
/.next/export-marker.json: "application/json"
/.next/images-manifest.json: "application/json"
/.next/next-server.js.nft.json: "application/json"
/.next/package.json: "application/json"
/.next/prerender-manifest.json: "application/json"
/.next/react-loadable-manifest.json: "application/json"
/.next/required-server-files.json: "application/json"
/.next/routes-manifest.json: "application/json"
/.next/serverless/chunks/120.js: "application/javascript"
/.next/serverless/chunks/173.js: "application/javascript"
/.next/serverless/chunks/242.js: "application/javascript"
/.next/serverless/chunks/322.js: "application/javascript"
/.next/serverless/chunks/669.js: "application/javascript"
/.next/serverless/chunks/787.js: "application/javascript"
/.next/serverless/chunks/font-manifest.json: "application/json"
/.next/serverless/font-manifest.json: "application/json"
/.next/serverless/middleware-manifest.json: "application/json"
/.next/serverless/pages/404.html: "text/html"
/.next/serverless/pages/500.html: "text/html"
/.next/serverless/pages/_error.js: "application/javascript"
/.next/serverless/pages/account/callback.html: "text/html"
/.next/serverless/pages/account.html: "text/html"
/.next/serverless/pages/checkout/payment/card.js: "application/javascript"
/.next/serverless/pages/checkout/payment.js: "application/javascript"
/.next/serverless/pages/checkout/success.js: "application/javascript"
/.next/serverless/pages/checkout.js: "application/javascript"
/.next/serverless/pages/product/[id].js: "application/javascript"
/.next/serverless/pages/product.js: "application/javascript"
/.next/serverless/pages-manifest.json: "application/json"
/.next/serverless/webpack-runtime.js: "application/javascript"
/.next/static/bOSiri3YDkdDfRKpquGTy/_buildManifest.js: "application/javascript"
/.next/static/bOSiri3YDkdDfRKpquGTy/_ssgManifest.js: "application/javascript"
/.next/static/chunks/framework-5f4595e5518b5600.js: "application/javascript"
/.next/static/chunks/main-8db7d21a15d54ad1.js: "application/javascript"
/.next/static/chunks/pages/_app-812465b832720c1e.js: "application/javascript"
/.next/static/chunks/pages/_error-a4ba2246ff8fb532.js: "application/javascript"
/.next/static/chunks/pages/account/callback-bc0546f99f624958.js: "application/javascript"
/.next/static/chunks/pages/account-bdda54fe61e1af28.js: "application/javascript"
/.next/static/chunks/pages/checkout/payment/card-234891b951cdbd84.js: "application/javascript"
/.next/static/chunks/pages/checkout/payment-f0ecb009b33de20a.js: "application/javascript"
/.next/static/chunks/pages/checkout/success-f6a03b23b958bc07.js: "application/javascript"
/.next/static/chunks/pages/checkout-1e04e751b75682af.js: "application/javascript"
/.next/static/chunks/pages/product/[id]-80116b732c66e801.js: "application/javascript"
/.next/static/chunks/pages/product-e84983e2b55144e5.js: "application/javascript"
/.next/static/chunks/polyfills-c67a75d1b6f99dc8.js: "application/javascript"
/.next/static/chunks/webpack-966019665164920b.js: "application/javascript"
Warning: Unknown file type /.next/trace...
Application is not a SPA.
Application specifies no 'not found (404)' page.
🚀 Wrote static file loader for 49 file(s).

ERROR: error during execution process.

In your log I'm seeing the compute-js-static-publish complete successfully, and then no output from webpack.
can you see what happens if you type just npm webpack in the compute-js folder?

ok thanks. so that works.

Perfect thank you!

Hi, I wasn't able to find the real root cause of this, but I think it's possible this happened because the warning messages are output using console.warn, which outputs to stderr. I'm published a new version that suppresses those messages. I've also implemented one more best practice for specifying exit codes from a program.
Can I have you try again? Delete the compute-js directory that got created last time, and then start over using:
npx @fastly/next-compute-js@latest init

let me know how this one goes.

Hi @harmony7 this seems to have worked but It does seem to log and error.
Running [scripts.build]...

Process command:
	sh -c npx check-next-version && npx @fastly/compute-js-static-publish --build-static --suppress-framework-warnings && $(npm bin)/webpack && $(npm bin)/js-compute-runtime ./bin/index.js ./bin/main.wasm

Next.js version: 12.3.0
Fastly Compute@Edge JavaScript Static Publisher
🚀 Building loader...
✔ Public directory '/Users/AMorrison/Dunelm/TCB/mfe-web-aggregator'.
✔ Using exclude directories: ./node_modules, ./compute-js, ./pages, ./.next/cache
✔ Applying 0 custom content type(s).
✔ Using include directories: ./.next, ./static, ./public
✔ /.next/build-manifest.json: "application/json"
✔ /.next/export-marker.json: "application/json"
✔ /.next/images-manifest.json: "application/json"
✔ /.next/next-server.js.nft.json: "application/json"
✔ /.next/package.json: "application/json"
✔ /.next/prerender-manifest.json: "application/json"
✔ /.next/react-loadable-manifest.json: "application/json"
✔ /.next/required-server-files.json: "application/json"
✔ /.next/routes-manifest.json: "application/json"
✔ /.next/serverless/chunks/120.js: "application/javascript"
✔ /.next/serverless/chunks/173.js: "application/javascript"
✔ /.next/serverless/chunks/242.js: "application/javascript"
✔ /.next/serverless/chunks/322.js: "application/javascript"
✔ /.next/serverless/chunks/669.js: "application/javascript"
✔ /.next/serverless/chunks/787.js: "application/javascript"
✔ /.next/serverless/chunks/font-manifest.json: "application/json"
✔ /.next/serverless/font-manifest.json: "application/json"
✔ /.next/serverless/middleware-manifest.json: "application/json"
✔ /.next/serverless/pages/404.html: "text/html"
✔ /.next/serverless/pages/500.html: "text/html"
✔ /.next/serverless/pages/_error.js: "application/javascript"
✔ /.next/serverless/pages/account/callback.html: "text/html"
✔ /.next/serverless/pages/account.html: "text/html"
✔ /.next/serverless/pages/checkout/payment/card.js: "application/javascript"
✔ /.next/serverless/pages/checkout/payment.js: "application/javascript"
✔ /.next/serverless/pages/checkout/success.js: "application/javascript"
✔ /.next/serverless/pages/checkout.js: "application/javascript"
✔ /.next/serverless/pages/product/[id].js: "application/javascript"
✔ /.next/serverless/pages/product.js: "application/javascript"
✔ /.next/serverless/pages-manifest.json: "application/json"
✔ /.next/serverless/webpack-runtime.js: "application/javascript"
✔ /.next/static/chunks/framework-5f4595e5518b5600.js: "application/javascript"
✔ /.next/static/chunks/main-8db7d21a15d54ad1.js: "application/javascript"
✔ /.next/static/chunks/pages/_app-812465b832720c1e.js: "application/javascript"
✔ /.next/static/chunks/pages/_error-a4ba2246ff8fb532.js: "application/javascript"
✔ /.next/static/chunks/pages/account/callback-bc0546f99f624958.js: "application/javascript"
✔ /.next/static/chunks/pages/account-bdda54fe61e1af28.js: "application/javascript"
✔ /.next/static/chunks/pages/checkout/payment/card-234891b951cdbd84.js: "application/javascript"
✔ /.next/static/chunks/pages/checkout/payment-f0ecb009b33de20a.js: "application/javascript"
✔ /.next/static/chunks/pages/checkout/success-f6a03b23b958bc07.js: "application/javascript"
✔ /.next/static/chunks/pages/checkout-1e04e751b75682af.js: "application/javascript"
✔ /.next/static/chunks/pages/product/[id]-80116b732c66e801.js: "application/javascript"
✔ /.next/static/chunks/pages/product-e84983e2b55144e5.js: "application/javascript"
✔ /.next/static/chunks/polyfills-c67a75d1b6f99dc8.js: "application/javascript"
✔ /.next/static/chunks/webpack-966019665164920b.js: "application/javascript"
✔ /.next/static/iPIg4Lu1KcgkobDciyGgl/_buildManifest.js: "application/javascript"
✔ /.next/static/iPIg4Lu1KcgkobDciyGgl/_ssgManifest.js: "application/javascript"
✔ /Architecture.png: "image/png"
✔ /Architecture1.png: "image/png"
✔ /jest.config.js: "application/javascript"
✔ /jest.setup.js: "application/javascript"
✔ /next.config.js: "application/javascript"
✔ /package.json: "application/json"
✔ /server.js: "application/javascript"
✔ /tsconfig.json: "application/json"
✔ /uploadAssetsS3/isServedByS3.js: "application/javascript"
✔ /uploadAssetsS3/uploadAssetsS3.js: "application/javascript"
✅  Wrote static file loader for 112 file(s).
asset index.js 6.97 MiB [emitted] [minimized] [big] (name: main) 1 related asset
orphan modules 5.5 MiB [orphan] 121 modules
runtime modules 3.28 KiB 7 modules
javascript modules 7.7 MiB
  modules by path ./ 7 MiB 217 modules
  modules by path ../ 708 KiB 143 modules
  optional modules 135 bytes [optional] 9 modules
  util (ignored) 15 bytes [built] [code generated]
  util (ignored) 15 bytes [built] [code generated]
json modules 244 KiB
  modules by path ./node_modules/iconv-lite/ 86.7 KiB 8 modules
  modules by path ./node_modules/browserify-sign/ 2.23 KiB
    ./node_modules/browserify-sign/browser/algorithms.json 2.07 KiB [built] [code generated]
    ./node_modules/browserify-sign/browser/curves.json 162 bytes [built] [code generated]
  + 6 modules

WARNING in configuration
The 'mode' option has not been set, webpack will fallback to 'production' for this value.
Set 'mode' option to 'development' or 'production' to enable defaults for each environment.
You can also set it to 'none' to disable any default behavior. Learn more: https://webpack.js.org/configuration/mode/

WARNING in asset size limit: The following asset(s) exceed the recommended size limit (244 KiB).
This can impact web performance.
Assets:
  index.js (6.97 MiB)

WARNING in entrypoint size limit: The following entrypoint(s) combined asset size exceeds the recommended limit (244 KiB). This can impact web performance.
Entrypoints:
  main (6.97 MiB)
      index.js

WARNING in webpack performance recommendations:
You can limit the size of your bundles by using import() or require.ensure to lazy load some parts of your application.
For more info visit https://webpack.js.org/guides/code-splitting/

webpack 5.74.0 compiled with 4 warnings in 6406 ms
Warn: warn  - Invalid next.config.js options detected:
Error:   - The root value has an unexpected property, target, which is not in the list of allowed properties (amp, analyticsId, assetPrefix, basePath, cleanDistDir, compiler, compress, crossOrigin, devIndicators, distDir, env, eslint, excludeDefaultMomentLocales, experimental, exportPathMap, future, generateBuildId, generateEtags, headers, httpAgentOptions, i18n, images, onDemandEntries, optimizeFonts, output, outputFileTracing, pageExtensions, poweredByHeader, productionBrowserSourceMaps, publicRuntimeConfig, reactStrictMode, redirects, rewrites, sassOptions, serverRuntimeConfig, staticPageGenerationTimeout, swcMinify, trailingSlash, typescript, useFileSystemPublicRoutes, webpack).
Error:   - The root value has an unexpected property, includeDoctype, which is not in the list of allowed properties (amp, analyticsId, assetPrefix, basePath, cleanDistDir, compiler, compress, crossOrigin, devIndicators, distDir, env, eslint, excludeDefaultMomentLocales, experimental, exportPathMap, future, generateBuildId, generateEtags, headers, httpAgentOptions, i18n, images, onDemandEntries, optimizeFonts, output, outputFileTracing, pageExtensions, poweredByHeader, productionBrowserSourceMaps, publicRuntimeConfig, reactStrictMode, redirects, rewrites, sassOptions, serverRuntimeConfig, staticPageGenerationTimeout, swcMinify, trailingSlash, typescript, useFileSystemPublicRoutes, webpack).
Error:
See more info here: https://nextjs.org/docs/messages/invalid-next-config
Promise rejected but never handled: Specified target is invalid. Provided: "serverless" should be one of server
Stack:
  5915/t.loadConfig@<stdin>:2:47000
  async*getServer@<stdin>:2:65264
  5150/t.default@<stdin>:2:66229
  8138/<@<stdin>:2:782721
  o.a@<stdin>:2:6875033
  8138@<stdin>:2:782642
  o@<stdin>:2:6874512
  @<stdin>:2:6876118
  @<stdin>:2:6876220

Creating package archive...

SUCCESS: Built package (pkg/package.tar.gz)

Checking latest Viceroy release...
Checking installed Viceroy version...

Current Viceroy version: 0.2.14
Latest Viceroy version: 0.3.0

Fetching latest Viceroy release...
Replacing Viceroy binary...
Running local server...
Wasm file: bin/main.wasm
Manifest: /Users/AMorrison/Dunelm/TCB/mfe-web-aggregator/compute-js/fastly.toml

Oct 13 09:42:27.247  WARN no backend definitions found in /Users/AMorrison/Dunelm/TCB/mfe-web-aggregator/compute-js/fastly.toml
Oct 13 09:42:27.247  INFO Listening on http://<IP_ADDRESS>:7676

On further inspection this now seems to be because of issues with the next config on myside not being compatible with compute@edge platform. I will peruse this further and get back to you :) Thanks for all the help!

Cool, I'm glad we were able to get you past that original problem.
Please let us know when we can help you again.

closing this out since your original issue is resolved.  please feel free to reopen or open a new ticket at that time.


[master]: ^C daemon causes panic

here are daemon logs: https://gist.github.com/anonymous/54f6dc3a00a8717fa3b9
havent tested RC but will do tomorrow

Hi!
Please read this important information about creating issues.
If you are reporting a new issue, make sure that we do not have any duplicates already open. You can ensure this by searching the issue list for this repository. If there is a duplicate, please close your issue and add a comment to the existing issue instead.
If you suspect your issue is a bug, please edit your issue description to include the BUG REPORT INFORMATION shown below. If you fail to provide this information within 7 days, we cannot debug your issue and will close it. We will, however, reopen it if you later provide the information.
This is an automated, informational response.
Thank you.
For more information about reporting issues, see https://github.com/docker/docker/blob/master/CONTRIBUTING.md#reporting-other-issues

BUG REPORT INFORMATION
Use the commands below to provide key information from your environment:
docker version:
docker info:
uname -a:
Provide additional environment details (AWS, VirtualBox, physical, etc.):
List the steps to reproduce the issue:
1.
2.
3.
Describe the results you received:
Describe the results you expected:
Provide additional info you think is important:
----------END REPORT ---------
#ENEEDMOREINFO

ping @mrjana its panicing on this line https://github.com/docker/libnetwork/blob/master/sandboxdata.go#L142 lol

@jfrazelle I know that's why I have comment in there that it will panic here if we enter the function with no endpoints attached. So we are not supposed to Leave with 0 endpoints. That is what needs to be fixed. But I am not able to reproduce the problem unfortunately. Is there any reproduction steps(other than running a few containers some with --net=host and some with --net=bridge)?

@mrjana Sorry we don't have a reproducible use case... However it happened, and will again: any chance we can make the code more robust on that? At least log an error rather than panicking.

@icecrime We can always do the logging instead of panicking and I promise to do that before next RC if I can't root cause the issue before that. Does that work?
But hiding the problem under a log doesn't make the code more robust than panicking because this is some condition that is not supposed to happen in the absence of a bug.

@mrjana I agree, I'd just rather ship a bug that issues a spurious error log, than a bug that takes the daemon down ;-)


install client drivers

Call out recommended postgres drivers (those we've tested) for:

python
ruby
go
c
javascript (node.js)
java
php
closure

Also mention that any postgres driver should work and suggest getting in touch if any problems.

Done: https://www.cockroachlabs.com/docs/install-client-drivers.html

Was there any reason c# was left off this list?

@bladefist Only because we haven't tested or vetted Npgsql. If you want to test it out for us, we'd be excited to have the contribution!

@sploiselle I don't have the cockroachdb or Npgsql expertise to be the one to do that.  I'm just beginning my journey and felt it odd that a major platform that businesses use was left out and wanted to make sure it wasn't a mistake.  Hopefully someone can contribute this!


Add Shadow to characters

Also Because I am drawing a white circle in imgg for each character two characters will never coincide.
Fixes #25


Do we have helper for jumping into one page by setting page number

As in the title, do we have or want that function like go to the page you want directly instead of jumping page by page.

@realwol Thank you for your question, but this is more like a support question. We only accept bug reports and pull requests in GitHub Please ask support questions on StackOverflow.
To answer your question, it shouldn't be too hard to implement a form or a link that allows the user to specify a page number, click a button or a link, and jump to the specified page.

Sorry for the rude issue.
I mean if we can do that, why don't we do that in a helper?

We should never add anything just because we could add it. If you want to implement a "Jump to the page" form or link, there's a lot to do with styling, wording, possibly javascript, and interaction with the backend, which is out of kaminari's scope.

Maybe an attribute in paginate helper, like jump: true, then a input text will show and the other stuff stay the same.


circulating  hyaluronic acid

We need terms for circulating  hyaluronic acid concentrations.
Reported by: cindyJax
Original Ticket: obo/mammalian-phenotype-requests/620

added MP:0020341


'tuple' object has no attribute 'suffix' when get application type Document

Describe the bug
Trying to get a application document return 'tuple' object has no attribute 'suffix'
To Reproduce
Juste use this code
xapplication_type=ApplicationTypes.DOCUMENT
print(type(xapplication_type))
print(xapplication_type.value)
print(xapplication_type.suffix)
In ApplicationService function get_document we have this code
application_type=ApplicationTypes.DOCUMENT
if not name.endswith(application_type.suffix):
name += application_type.suffix
That this part wich generate the error
Expected behavior
Get the document
Version
TM1py 1.11.3
TM1 Server Version: 11.8
Additional context
Add any other context about the problem here.

Hello,
I found a workaround to be able to access Excel sheets. My level in Python does not guarantee that it is the best but with the line added in ApplicationService.py, I no longer have errors and I access the files well.
def get_document(self, path: str, name: str, private: bool = False, **kwargs) -> DocumentApplication:
""" Get Excel Application from TM1 Server in binary format. Can be dumped to file.
    :param path: path through folder structure to application. For instance: "Finance/P&L.xlsx"
    :param name: name of the application
    :param private: boolean
    :return: Return DocumentApplication
    """
    The ligne added :
    _application_type=ApplicationType(*ApplicationTypes.DOCUMENT.value)_

    if not name.endswith(application_type.suffix):
        name += application_type.suffix

I'm not sure I understand your proposed change.
The _application_type variable you create at the beginning of the function is not used later on.
Please open a Pull Request with your proposed change. Ideally, you also add a test case here  that reproduces the issue in the current master branch.

Hi Marius,
Not sure my Python is at the level to propose change. Juste find that the code in [tm1py-samples][Metadata]/application_get.py
send me an error : 'tuple' object has no attribute 'suffix'
The change I maid just cast application_type to  ApplicationTypes.DOCUMENT to access the properties suffix.
The error
![Sans titre](https://github.com/cubewise-code/tm1py/assets/58982767/9fb
testfonc.txt
54834-4d3c-4d3f-837e-ae2464cb59a8)
The test code (the sample, with anly change on the connexion)

The issue seems to be resolved on the current master branch.
Please upgrade to current master branch and try below code snippet and confirm that it works on your side.

with TM1Service(**tm1params) as tm1:
    # get the application
    application = tm1.applications.get(
        path="Reporting",
        application_type=ApplicationTypes.DOCUMENT,
        name="pnl.xlsx",
        private=False)

    # write it to xlsx file
    application.to_file("out.xlsx")

Hello, upgrade to 2.02 and get the same issue. Change the code of class ApplicationTypes by class ApplicationTypes(Enum) and it look working :
CHORE = ApplicationType(1, ".chore", "tm1.ChoreReference")
CUBE = ApplicationType(2, ".cube", "tm1.CubeReference")
DIMENSION = ApplicationType(3, ".dimension", "tm1.DimensionReference")
DOCUMENT = ApplicationType(4, ".blob", "#ibm.tm1.api.v1.Document")
FOLDER = ApplicationType(5, "", "#ibm.tm1.api.v1.Folder")
LINK = ApplicationType(6, ".extr", "#ibm.tm1.api.v1.Link")
PROCESS = ApplicationType(7, ".process", "tm1.ProcessReference")
SUBSET = ApplicationType(8, ".subset", "tm1.SubsetReference")
VIEW = ApplicationType(9, ".view", "tm1.ViewReference")
@classmethod
def _missing_(cls, value: str) -> ApplicationType:
    for member in cls:
        if member.name.lower() == value.lower():
            print(type(member))
            #return ApplicationType(member)
            return cls(member.value)

@property
def suffix(self) -> str:
    #return self.value.suffix
    return ApplicationType(*self.value).suffix
@property
def odata_type(self) -> str:
    return ApplicationType(*self.value).odata_type
    #return self.value.odata_type

(in comment old code).
Will be please to join the projet to help if I can, but dont know how to get a environnement from github.
Regards


Extra Config creation is dead code

The code in both NatProdCmdApp and NatConsCmdApp that creates the extra configuration variable is dead code.  The extraCfgConf variable is created and set to null, but then the variable is only instantiated if it's not null.  The code is linked here -
https://github.com/datastax/pulsar_workshop/blob/e26e45fc5795f55011c3058c9324ec8cce6043aa/application_code/client_apps/java/nat_cons/src/main/java/com/example/pulsarworkshop/nat_cons/NatConsCmdApp.java#L118
Removing the conditional check results in NPE -
Exception in thread "main" java.lang.NullPointerException: Cannot invoke "java.io.File.getCanonicalPath()" because "extraCfgFile" is null
at com.example.pulsarworkshop.common.PulsarExtraCfgConf.readRawCfgFromFile(PulsarExtraCfgConf.java:77)
at com.example.pulsarworkshop.common.PulsarExtraCfgConf.(PulsarExtraCfgConf.java:55)
at com.example.pulsarworkshop.common.PulsarWorkshopCmdApp.createNativePulsarClient(PulsarWorkshopCmdApp.java:135)
at com.example.pulsarworkshop.nat_cons.NatConsCmdApp.runApp(NatConsCmdApp.java:111)
at com.example.pulsarworkshop.nat_cons.NatConsCmdApp.main(NatConsCmdApp.java:48)

createNativePulsarClient() method is expecting client.conf file, not the extra config file. It looks like you're passing the wrong file.
See this line: https://github.com/datastax/pulsar_workshop/blob/e26e45fc5795f55011c3058c9324ec8cce6043aa/application_code/client_apps/java/nat_cons/src/main/java/com/example/pulsarworkshop/nat_cons/NatConsCmdApp.java#L124
it is expecting connCfgConf, not extraCfgConf
pulsarClient = createNativePulsarClient(connCfgConf);


Hint for storing data in localStorage

While having a LRU cache is a great idea, the most important queries are running permamently. Events generated by these queries need to be stored in localStorage even if they are not recent.
A simple API is RelayPool::store(evvent), Event::store(), and store(cb: OnEvent) : OnEvent .
localStorage should at least be updated before closing the window, but also probably a few second delay of debounce is probably good.

Alternative storage is indexedb, maybe 2 entries are enough: 1 for hinted storage, other for LRU (though LRU can store 50MB, doesn't need to be super small, and can load slower, it's not a problem).

Instead of the store function, a better hint is probably just the author pubkey and followed pubkeys.
This way caching can divide available space between author events, followed events and other events (40%, 40%, 20%???).
Divide the space between authors, and inside it between kinds.
Store freshest events.
This type of caching can be used in multiple stages (local, limited to 4MB, and larger cache that can be 50MB).

Actually event author pubkey and division / space allocation are enough for these. Also all replies and reply profiles should be stored.


.button-group color palette

In file .button-group.scss, line 210, iteration should be over $button-palette instead of $foundation-palette.
https://github.com/zurb/foundation-sites/blob/373344ecdcbd29c0c00a26d98e92dfb6d99f214c/scss/components/_button-group.scss#L210

Good catch @repoles would you like to submit a PR for this?

Sure, @kball. Here you go. Thanks.

@repoles Thanks a lot but please check my comment on the PR and create a new branch :)

@IamManchanda i tried, but:
➜ foundation-sites git:(hotfix/button-group-color-palette) git push origin HEAD
Username for 'https://github.com': repoles
Password for<EMAIL_ADDRESS>
remote: Permission to zurb/foundation-sites.git denied to repoles.
fatal: unable to access 'https://github.com/zurb/foundation-sites.git/': The requested URL returned error: 403

@repoles Sorry for late reply... This seems fixed by other user
But, for your learning
You should replace origin with the remote name you added for your own forked PR git@github.com:repoles/foundation-sites.git

Normally if you create a PR for a repo that you don't have direct access, You should be doing

Fork that repo to your profile... In your case git@github.com:repoles/foundation-sites.git
(This way remote gets set to origin)

Now set Main repo to upstream
=> git remote add git@github.com:zurb/foundation-sites.git

Now if you do git remote -v ... It will print out both remotes origin(repoles) and upstream(zurb)

Now create a new branch git checkout -b hotfix/iterate-button-pallete

Once your commit is done, push it => git push origin HEAD or git push origin hotfix/iterate-button-pallete


Issue-1857: Upgrade swagger dependencies from 1.5.18 to 1.6.2

This PR addresses #Issue-1857
Incremented swagger core version from 1.5.18 to 1.6.2.

Hi!
Thank you for your contribution! We have tested it and it works as expected!
Would you mind signing the ICLA, as described in the Contributing page?
Also, please, feel free to join our chat channel, if you'd like to learn more about the project and/or like to find out what else you could help with.
Kind regards,
Martin

@carlspring I have emailed the ICLA. Thank you.

Thank you! Congratulations on your first pull request! :)


pyodbc + Azure Function Apps, and 2 "Can't open lib 'ODBC Driver 18 for SQL Server" error

Python: 3.9.13 64 bit
pyodbc: 4.0.34
OS: Windows 10 Pro
DB: SQL Server on Azure
driver: ODBC Driver 18 for SQL Server

I'm stuck in an error which I've been researching for a while now. I have looked at all the related issues and have found no solution within them.
I have Python code that I want to use in a Function App with a time trigger that runs every day at 06:00. The code:

Calls an API, downloads data.

Cleans the data.

Connects to a database using pyodbc module.

Inserts data into the database.

I then create the function app, configure it, and, locally, it's running perfectly, executing the code everyday at 06:00.
Then I create a resource and deploy the function app on Azure. The function executes properly at the configured time. However, when it runs, I get the error.
https://pastebin.com/FWBECeWq
This is the overview of the function app:
https://imgur.com/a/XDetHzk
Could it be related to the fact that the application is hosted on Linux and I'm using pyodbc driver for Windows?

Thank you, this was useful to know what drivers the virtual machine has. This helped me solve the issue.


hardBreak cannot exist outside of a paragraph object.

Discovered this when I went to put the update from #4 into use, but apparently the hardBreak object is only valid within the context of a paragraph object.
Example
        "description": {
            "version": 1,
            "type": "doc",
            "content": [
                {
                    "type": "paragraph",
                    "content": [
                        {
                            "type": "text",
                            "text": "Line 1"
                        },
                        {
                            "type": "hardBreak"
                        },
                        {
                            "type": "text",
                            "text": "Line 2"
                        }
                    ]
                },
                {
                    "type": "hardBreak"
                },
                {
                    "type": "paragraph",
                    "content": [
                        {
                            "type": "text",
                            "text": "Line 3"
                        },
                        {
                            "type": "hardBreak"
                        },
                        {
                            "type": "text",
                            "text": "Line 4"
                        }
                    ]
                }
            ]
        }

Results in a 400 Bad Request with the incredibly useful error message of:
{
    "errorMessages": [
        "INVALID_INPUT"
    ],
    "errors": {}
}

Working Payload
Frustratingly, if you would like to put an extra linebreak in between two paragraphs, you have two options:

Put an empty paragraph object between them which will insert effectively one line break:

                {
                    "type": "paragraph",
                    "content": []
                },

Put the hardBreak into the previous or next paragraph.

Same issue.
The workaround is to replace the type value with "paragraph"
Tested using https://developer.atlassian.com/cloud/jira/platform/apis/document/viewer/

This should now be fixed inside:
https://github.com/wouterken/htmltoadf/releases/tag/0.1.9


Added link to Public Preview feature

…r internal ip
There is a Public Preview for Private IP based frontends that customers should know about. Added link.

@greg-lindsay
Can you review the proposed changes?
When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

This is a good comment, but the format for the link is not in line with how we add links.  You can see the warnings above. Basically for this link you would just point to the markdown file [application-gateway-private-deployment.md]. I don't think I can edit the PR so I will create a new PR and make a similar edit to the article. #please-close


max / min width

How? I tried unsuccessfully to change the width and failed.

@bucaran try this
.minimap {
  max-width: 20%;
  min-width: 50px;
}

Thanks! I had already tried that, but it didn't work, that's why I posted here.
Since I have shadow DOM enabled, I also tried
atom-text-editor,
atom-text-editor::shadow {

  .minimap {
    max-width: 10px;
    min-width: 10px;
  }
}

to no avail.

@bucaran Are you using the v4 preview? If yes the selector to use is a bit different:
atom-text-editor::shadow  atom-text-editor-minimap {
  width: 10px !important;
}

Also make sure you doesn't have the Adjust Minimap Width To Soft Wrap enabled (it resizes the minimap programmatically).

Thanks!
atom-text-editor::shadow  atom-text-editor-minimap {
  width: 10px !important;
}

Works!


Plus code missing from formatted response

Would be nice to have the plus_code returned in the formatted response. See PR #91
Ref: What are Plus Codes?

We'll continue this in #91


Received null value, however the target type cannot handle null values

I am facing an annoyance when developing modules on top of port_entity with string types using the URL format.
// blueprint.tf

resource "port_blueprint" "my-blueprint" {
  identifier = "my-blueprint"
  title      = "my-blueprint"
  icon       = "Cloud"

  properties = {
    string_props = {
      my_url = {
        title       = "My Url"
        format      = "url"
      }

      name = {
        title = "Name"
      }
    }
  }
}

// module/main.tf

resource "port_entity" "my-system" {
  blueprint = "my-blueprint"

  identifier = "my-identifier"
  title      = "my-title"
  teams      = tolist(["my-team"])

  properties = {
    string_props = {
      my_url = var.stuff.my_url
      name   = var.stuff.name
    }
  }
}

// module/variables.tf

variable "stuff" {
  type = object({
    "my_url"              = optional(string)
    "name"                = string
  })
}

// thing.tf

module "thing" {
  source = "./module"

  thing = {
    "name"   = "my-name"
  }
}

Running terraform apply causes the following error:
│ An unexpected error was encountered trying to build a value. This is always an error in the provider. Please report the following to the provider developer:
│
│ Received null value, however the target type cannot handle null values. Use the corresponding `types` package type, a pointer type or a custom type that handles null values.

This seems to happen because my-url is defined as being a string in Port, so when passing it a null value, it does not accept it. I did also try adding an empty string, however, that also fails because format = url rejects it.

HI @gustavobini , Thank you very much! I've opened an issue on our side, and it should be resolved by the end of next week

Hi @gustavobini , Currently we don't support null values in properties. Can you use conditional to define the object?

@dvirsegev I did address this issue for my particular case. I thought I'd open an issue as being able to do what's described in the issue is much more "terraformy", but I leave it to you to decide what to do about it.


logger.info({message:...}) modifies original object

Problem description:
const data = {'message':'hello'}
logger.log(data)
// now data contains "level":"info"

.info(), and probably other methods modify original object when the object contains 'message' field.
This is unfortunate because a user might be unaware of such behaviour, and can easily overlook this moment, which would lead to hard-to-find problems.
Possible fix:
Leave everything as it is (as user expect to pass config object to the logging method), but clone incoming object.

winston version - (3.2.1)
platform: all
languages: all

I have the same question.

I have the same issue using winston 3.3.3 when logging some custom errors.
I set some level prop to the errors objects and when I use winston to log errors, it change the error.level value to its own value.
Given:
class CustomError extends Error {
    level;
    constructor(message, level) {
        super(message);
        this.level = level
    }
}

const win = winston.createLogger({
    transports: [
        new winston.transports.Console(),
    ]
});

const error = new CustomError("Wrong level", "fatal");
win.error(error);  // {"level":"error"}
console.log(error.level); // error

If winston should modify the logged value, at least it should NOT modify the logged object.
However it shouldn't modify the value at all.

As the original posted guessed, this caused a very hard-to-find bug for myself. I could never have imagined that the logger I'm using modified the object I've given it, so it was the last place I looked to resolve an issue. Winston should not be doing this!

I also just discovered this bug. We rely on the data object stored on a Feathers exception to be relayed to the API client. Logging that exception results in data being changed to an empty object.

I have a fix at https://github.com/winstonjs/winston/pull/1938.

I also came across this defect as I get optional "message" property from external API. When "message" returned is empty, this issue disappears so it was nasty to track where my problem is from.
To me, response (res.data) from axios service call modified by winston logger should be fixed ASAP. I see @clintonb PR fixes the issue of data object mutated at least, (the object logged still has the issue though as I use json format). Having this workaround is bad, please help by reviewing the PR and merging it.
const resToLog: any = res.data;
this.loggerService.debug(res.config?.url);
this.loggerService.info(resToLog);
// eslint-disable-next-line @typescript-eslint/no-unused-vars
const { ['level']: _, ['timestamp']: __, ...resToReturn } = resToLog;

Experience the same thing that the logger.error method modifies the message of the error object directly to pad 3 spaces in front.
So
const error = new Error('No!');
// before
console.log(error.message.length); // 3 - 'No!'
// after
logger.error(error);
console.log(error.message.length); // 6 - '   No!'

Wow - this does seem like something that should be fixed, though it also seems like a fair amount of work to do it well without having a pretty large impact on performance (which is important for a logging library).  I think the best strategy here is go through an analysis of the code to find places where that error object getting logged is mutated, and try to split the mutated thing from the original and pass them alongside each other, copying only where really necessary e.g. for passing into other functions that can't take side-by-side parameters.  I don't personally have any time budget to do that right now, but am pinning this issue so that folks can be more aware of it, as lack of awareness/expectation of this behavior is a key reason why it's so frustrating.

I am still facing the same issue on winston version 3.8.2
const data={
message:{
test:"hello"
}
}
logger.info(data);
// output
{
test: "hello"
}
// expected output
{
message:{
test:"hello"
}
}

Still having shallow copy issue.

I am still facing the same issue on winston version 3.8.2
const data = {
  message: {
    test: "hello",
  },
};

logger.info(data);

// output
// { test: 'hello' }

// expected output
// { message: { test: 'hello' } }

best succinct example!
Given that changing established behavior might be a significant breaking change, if there were an option in format.json() like ignoreMessage: true, or some such - that would solve the problem - given the docs mentioned it.

I'm facing a similar issue where the log output seems to append a second JSON object to my log message. It adds an extra {"level":"info"} at the end of the message. This JSON object is correlated to whichever log method I am calling (e.g. logger.info, warn, error, debug)
The interesting thing is that I have this implemented in two apps with identical implementations and package versions. One app outputs correctly to grafana and I can prettify the logs for better readability. The other app outputs the message with that extra JSON object and it breaks the prettify feature in Grafana and makes the logs really unreadable.
  const logBody = {
       level: 'info',
       message: '{"level":"info","message":{"message":"Message received","environment":"development"},"labels":{"level":"info"}}',
       labels: {
            level: 'info',
  }
}

// send log to Grafana
winston.log(logBody);

// Expected output
{"level":"info","message":{"message":"Message received","environment":"development"},"labels":{"level":"info"}}

// Actual output:
{"level":"info","message":{"message":"Message received","environment":"development"},"labels":{"level":"info"}}, {"level":"info"}   <-- this extra JSON gets appended


feat(): added a theme switcher

Fixes #647

implemented a hook to get the current userSkin

@harshmaur Dark mode doesnt persist for me, when i refresh the page it comeback to white.

@bonustrack it will work now.

@harshmaur the button on /setup should be blue after entering a valid ENS. Currently it looks like this

@harshmaur the button on /setup should be blue after entering a valid ENS. Currently it looks like this

@harshmaur the same for /delegate

@harshmaur the <pre> <code> tags in mardown have white text on white background. See here
https://bafybeicklqgphzqkjozy672ddkeiauydp5kybkih7royq7ujkdjt3xthrm.on.fleek.co/#/strategy/erc20-balance-of

Can you make these skins works with the dark mode switcher? https://github.com/snapshot-labs/snapshot-spaces/search?q=prefers-color-scheme
Change icon color for sun and moon to same color than the others icons Timeline and Help

Can change the color of the text inside the active proposal indicator here

@harshmaur can you resolve conflicts, then I'll merge this

Done!!


Cleanup config files

This cleanes up a bunch of stuff in the config files. Renaming some parameters to be more expressive, removing unneeded complexity in the parsing process, and using 0 as a sentinel value to indicate that a timeout/memory limit is ignored since toml doesn't have a built in None/null/etc type.
Note that the vast majority of this PR's git diff is just caused by moving two classes from the bottom of the docker_utils module to the top.

sorry for the spam, but don't merge this yet. I just noticed it's still missing some stuff.

That's okay, just tell me when the PR is in a state to consider merging.

ready to be merged now

Looks good, thank you!


Adding ambassadors page

@nachoiacovino Could you check if you can do the merge correctly now?

Yes @nachoiacovino , I can do the same as /about, I can create an object for the ambassador card and also create const ambassadorMonth. Then I'll add all the images in the same folder, public/assets/ambassadors,.

Yes @nachoiacovino , I can do the same as /about, I can create an object for the ambassador card and also create const ambassadorMonth. Then I'll add all the images in the same folder, public/assets/ambassadors,.

sound good, also I noticed a typo with Waren's name, should be only one R.

Create objects for ambassadors and ambassadorMonthly. The public/assets/ambassadors folder and added the corresponding images there.
I'm Junior, you can tell right? hahaha I hope this time it's all right...!

hey @SamuSarmiento the build is failing, can you run yarn build locally and make sure it passes?

Hey @nachoiacovino :
95:3  Error: Insert ␍  prettier/prettier
info  - Need to disable some ESLint rules? Learn more here: https://nextjs.org/docs/basic-features/eslint#disabling-rules
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

Hey @nachoiacovino :
95:3 Error: Insert ␍ prettier/prettier
info - Need to disable some ESLint rules? Learn more here: https://nextjs.org/docs/basic-features/eslint#disabling-rules error Command failed with exit code 1. info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

How Can I fix this? Any Idea?

hey @SamuSarmiento you should insteall the Prettier extension then format the files you changed, we enforce that the build fail if the code is not formatted correctly

hey @SamuSarmiento you should insteall the Prettier extension then format the files you changed, we enforce that the build fail if the code is not formatted correctly

Prettier's problems should be fixed by now as I was able to do the yarn build with "endOfLine": "auto".
There shouldn't be any problems with the merge now, as it is now formatted correctly.

@nachoiacovino Is it also possible that there are errors because I am using Windows?

hey @SamuSarmiento we ended up doing this a bit different and it's already live at https://thirdweb.com/ambassadors


move toolchain: fix multiple issues with bytecode dependencies

Description
This PR fixes multiple issues caused by bytecode dependencies not being included in CompiledPackage:

multiple functionalities failing due to topo sort in Modules panicking on missing dependencies
running move test on packages with bytecode deps failing due to them not being included in VM storage
source verification failing because bytecode deps aren't handled
commands such as publish and upgrade failing due to bytecode deps not being referenced in the construction of transaction blocks

Summary of changes:

removed move_bytecode_utils::dependency_graph module and instead added a compute_topological_order method to Modules. Replaced all calls to compute_dependency_graph with a direct call to compute_topological_order (2 in total)
added bytecode deps to VM storage for test runs by loading them from ResolvedGraph
include bytecode deps in sui_move_build::CompiledPackage and fix various module fetching methods to return modules from bytecode deps also
include bytecode deps in local_modules function to fix LocalDependencyNotFound errors in source verification

This is part of the work to enable compiling against on-chain dependencies https://github.com/MystenLabs/sui/pull/14178.
cc @rvantonder @amnn
Test Plan
Added unit tests for move test and source verification.

If your changes are not user-facing and do not break anything, you can skip the following section. Otherwise, please briefly describe what has changed under the Release Notes section.
Type of Change (Check all that apply)

[ ] protocol change
[ ] user-visible impact
[ ] breaking change for a client SDKs
[ ] breaking change for FNs (FN binary must upgrade)
[ ] breaking change for validators or node operators (must upgrade binaries)
[ ] breaking change for on-chain data layout
[ ] necessitate either a data wipe or data migration

Release notes

Thanks @kklas! Kicking off CI so long, review to follow!

@tnowacki agree with everything. I'm waiting for other comments to do round 2 here.

I apologize for this unreasonably long delay. I have restarted the work on this:

rebase
move bytecode_deps_modules inside TestRunner
use IndexMap in compute_topological_order

@amnn @rvantonder @tnowacki  I would appreciate another look

@kklas, my hand is hovering over "Squash and Merge" but let me know if you want to do a final rebase, etc before I send it.

@amnn rebase done, all good to go!


fix(apps/prod/tibuild): bump to v20240228-52-g63d1681

Ref https://github.com/PingCAP-QE/ee-apps/pull/143

/approve


File protection from direct access

Hello dev.
I love using your script, im was and still am curious on how to prevent the direct access on let's say: about.php.
I am loding this page via '/about', but anytime i type the extension also, the same result view pops up!
It would be awesome if I could somehow prevent the direct access of the files, and make them accessable only via the routing system.
Best regards.

Try like below
Inspect extension in url and redirect page
$searchName = ".php";
$request_uri = $_SERVER['REQUEST_URI'];
if(strpos($request_uri, $searchName) !== false) {
header('Location: /home');
}

Hey,
this is a Apache configuration and / or a design flaw or your software.

Why the about.php is delivered directly? Open the .htaccess file. It configures the Apache behavior configuration. There you will find this line: "RewriteCond %{REQUEST_FILENAME} !-f" This line tells Apache not to call the index.php file if the file was found in the filesystem. Instead the found file will be responded directly to your browser. This is important for images and css or js files for example. Because you don't want to have them progressed by your PHP-Router. You could now create another rule that would exclude all requests with a .php extension from this behavior. But there is another way.

You should never put include files directly into your web root. Just copy it away from there. If you can put them one folder above. So they are completely invisible to direct web access but you can still include them by using include ('../includes') for example. Or put them into a separate include folder inside your web root and protect this folder with an extra .htaccess file.

This is also a working solution. The only "risk" with this approach is that you have to keep this in mind. I think this pattern is more hidden for your future self and other developers. There is the risk that you forget this line in some files. But I think some popular CMS systems use a similar strategy (Typo3, etc...).
Another thing is that this files can easily found by brute forcing the web server (fuzzing). If I request the about.php the web server will response with an 200 status code. So i can know if there is a file. Even if this file will do nothing its pure existence can lead to the structure of your code and files.

But your approach could be a second step of security hardening. Combine it for example with a protected includes directory.

Maybe I can write also a code to send a response code of 404 not found, when hitting the page direct when the key is not defined? What about that?

That would be really confusing for web fuzzer :-)

Okay thank you for the time and contribute :).


Array sort

Implemented https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/sort
#599

@microsoft-github-policy-service agree

thank you very much!


Upload custom plugins

How i can upload custom plugins, like bootstrap-slider, etc

You want to upload it to MyUsers or you want to get one?

Upload to the FTP, web server

@Lukkez Plugins from other websites are not supported yet.


Make sure we don't create MTRDevice/MTRDeviceController cycles we can't break.

Fixes https://github.com/project-chip/connectedhomeip/issues/25710

Fast-tracking platform-specific change with platform owner review.


sander/showContetnDuringServe

PR Checklist
Please check if your PR fulfills the following requirements:

[x] The commit message follows our guidelines: https://github.com/scullyio/scully/blob/master/CONTRIBUTING.md#commit
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

PR Type
What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Other... Please describe:

What is the current behavior?
During ng serve you can't see the static content

Issue Number: closes #498
What is the new behavior?
You can see the static content. Need to have scully server running
Does this PR introduce a breaking change?

[ ] Yes
[x ] No

Other information

Would it be possible to publish an update to the @scullyio/ng-lib package in npm to make use of this change?


Keep GpuCoalesceExec if a shuffle or custom reader is the parent exec

Closes #2378
This follows the first recommendation for a short term fix from @jlowe (as outlined in #2378):

Avoid "optimizing" a GPU coalesce if the preceding node is a shuffle

So if we are at this rule: GpuCoalesceBatches(ColumnarToRow), we'd look where GpuCoalesceBatches is pulling from first, before removing the coalesce (as implemented, a coalesce that feeds the columnar to row transition is currently not beneficial).
The only case we care about is GpuShuffle(GpuCoalesceBatches(ColumnarToRow)), in this case the shuffle could be pulling compressed batches from nvcomp. GpuCoalesceBatches is equipped to handle those but nothing else is looking at it, so we get errors like the one reported in #2378.

@tgravescs thanks for raising, I have updated the description of the PR.

@tgravescs when you get a chance, let me know if this one looks OK to merge.


chore: install encoding package to prevent ncc from outputting eval("require")

Closes #79.
After some investigative work, I found out that when ncc is not able to find a package inside node_modules folder it outputs:
eval('require')('<package_name>')

instead of:
__WEBPACK_EXTERNAL_createRequire(import.meta.url)('<package_name>`)

I found out that it is the node-fetch package that is causing this issue, specifically this snippet of code:
try {
	convert = require('encoding').convert;
} catch (e) {}

This is causing the error ReferenceError: require is not defined in ES module scope, you can use import instead to occur during the action run.
The encoding package is just a peerDependency of the node-fetch's package. After adding encoding package to this package's dependencies ncc no longer outputs eval('require')('encoding').
⚠ The encoding package adds another 400 kB to the resulting bundle file.

Closes #79.

@MelkorNemesis excellent reverse engineering work here!

In the ncc repo there is one issue about this, you may want to lead them on the right path https://github.com/vercel/ncc/issues/892


distributed run stuck with 100% GPU utilization

Hi, I am using this code and followed the installation instruction.
When I run this code with 4GPUs and set --hparams="distributed_run=True,fp16_run=True", the system will stuck in Tacotron2 forward with 100% GPU utils. I also checked other stuck problem when people use multiple GPU. But it seems mine is different from them (most of them had problem at step of initialization, mine is fine). The GPU memory is only used half.
I am using pytorch 1.4.0 with cuda 10.0, apex 0.1 (I just pulled from the latest version).
Has anyone observed the same problem? Do you have any idea how to solve it? Thank you very much!

I have met the same problem. Specifically, my program got stuck after running 1 iteration. When I CTRL-C to force stop, the error message shows the program is halting at (pid, sts) = os.waitpid(self.pid, wait_flags). My GPU usage keeps the same at about half the maximum memory. The CPU usage is near 100% and job state is 'R'. I don't know what went wrong either.
I could definitely be the problem of distributed running, since I got no problem when using only 1 GPU. Can someone help? Thanks in advance!

I found turning fp16_run to False helps solve this problem. This is a strange workaround but just somehow makes my program run.


Does interview list show progress completion when progress bar is turned off?

It shouldn't if it does currently, but needs testing. AL fix needed
Google doc comment link: ?disco=AAABDEjMkwo

Thanks for looking into this Bryce. If I'm following you, this means if we want to completely disable the progress bar both in the interview and on the My Interviews page, we need to both:

in the interview (or framework if want this turned off for all) set
features:
progress bar: False

make sure we never reference "set_progress" in the interview

Is that right?

Yep, that's right!
The technical details are that the interview list page looks for a variable named progress in the interview session information. Calling set_progress directly sets that variable, but also leaving the progress bar enabled will make docassemble automatically increment the progress value too. So both have to be turned off for the progress variable to not be present.


Adding vxflexos csi-driver version 1.2.1 to supported versions

Description
Adding VxFlexOS CSI Driver 1.2.1 to the list of qualified drivers.
Issues
List the issues impacted by this PR:

Issue ID

#33

Checklist

[x] I have performed a self-review of my own code
[x] I have run 'make check' to ensure my code does not have any formatting, vetting, linting, or security issues
[x] I have made corresponding changes to the documentation

e2e pass

e2e pass

e2e pass

e2e pass


.to_arrowTable error ArrowInvalid: File is too small: 8 (0.13.0, amd64, macos)

A convenience method to return a dataframe or pyarrow table from a query result would be great. DuckDB has similar features: https://duckdb.org/docs/api/python/overview.html#result-conversion
I think df and arrow are the most important ones, with arrow being the top because it's easy to get a df from an arrow table with another method call (uses more mem though)

Seems like they are available, and my completion was not working?
# return pyarrow table
def to_arrowTable(res):
    """convert res to arrow table"""
    # try import pyarrow and pandas, if failed, raise ImportError with suggestion
    try:
        import pyarrow as pa
        import pandas
    except ImportError as e:
        print(f'ImportError: {e}')
        print('Please install pyarrow and pandas via "pip install pyarrow pandas"')
        raise ImportError('Failed to import pyarrow or pandas') from None
    if len(res) == 0:
        return pa.Table.from_batches([], schema=pa.schema([]))
    return pa.RecordBatchFileReader(res.bytes()).read_all()

# return pandas dataframe
def to_df(r):
    """"convert arrow table to Dataframe"""
    t = to_arrowTable(r)
    return t.to_pandas(use_threads=True)

as well as methods for getting right from query:
def query(sql, output_format="CSV"):
    lower_output_format = output_format.lower()
    if lower_output_format == "dataframe":
        return to_df(_chdb.query(sql, "Arrow"))
    elif lower_output_format == 'arrowtable':
        return to_arrowTable(_chdb.query(sql, "Arrow"))
    else:
        return _chdb.query(sql, output_format)

Althought I get an error using the to_arrowTable method:
In [1]: import chdb

In [3]: res = chdb.query("select count() from s3('https://s3.us-west-2.amazonaws.com/ookla-open-data/parquet/performance/type=mobile/year=2019/quarter=1/2019-0
   ...: 1-01_performance_mobile_tiles.parquet')")

In [5]: chdb.to_arrowTable(res)
---------------------------------------------------------------------------
ArrowInvalid                              Traceback (most recent call last)
Cell In[5], line 1
----> 1 chdb.to_arrowTable(res)

File ~/code/icedb/venv/lib/python3.10/site-packages/chdb/__init__.py:40, in to_arrowTable(res)
     38 if len(res) == 0:
     39     return pa.Table.from_batches([], schema=pa.schema([]))
---> 40 return pa.RecordBatchFileReader(res.bytes()).read_all()

File ~/code/icedb/venv/lib/python3.10/site-packages/pyarrow/ipc.py:110, in RecordBatchFileReader.__init__(self, source, footer_offset, options, memory_pool)
    107 def __init__(self, source, footer_offset=None, *, options=None,
    108              memory_pool=None):
    109     options = _ensure_default_ipc_read_options(options)
--> 110     self._open(source, footer_offset=footer_offset,
    111                options=options, memory_pool=memory_pool)

File ~/code/icedb/venv/lib/python3.10/site-packages/pyarrow/ipc.pxi:942, in pyarrow.lib._RecordBatchFileReader._open()

File ~/code/icedb/venv/lib/python3.10/site-packages/pyarrow/error.pxi:144, in pyarrow.lib.pyarrow_internal_check_status()

File ~/code/icedb/venv/lib/python3.10/site-packages/pyarrow/error.pxi:100, in pyarrow.lib.check_status()

ArrowInvalid: File is too small: 8

The example from https://github.com/chdb-io/chdb/blob/main/examples/to_pandas.py works fine though (to convert to pyarrow table)

Ok it worked the second time... closing issue

You can just use ArrowTable format
import chdb

res = chdb.query(
   "SELECT town, district, count() AS c, round(avg(price)) AS price "
   "FROM s3('https://datasets-documentation.s3.eu-west-3.amazonaws.com/uk-house-prices/csv/house_prices.csv.gz') "
   "GROUP BY town, district HAVING c >= 100 ORDER BY price DESC LIMIT 10",
   "ArrowTable")
print(res)


fix: nonspecific lemmas are poisoning apply?

I would like to include the "nonspecific" lemmas in the results, but it will need more work (making sure they come after more specific results, and that they don't slow down output).

bors merge


update BrandBand for SLDS Summer  21

BrandBand is updated to support SLDS Summer '21. ~Also update the Design System peer dependency to 2.15.~
Additional description

CONTRIBUTOR checklist (do not remove)
Please complete for every pull request

[x] First-time contributors should sign the Contributor License Agreement.  If you haven't before, wait a few minutes and a bot will comment on this pull request with instructions.
[x] npm run lint:fix has been run and linting passes.
[ ] Mocha, Jest (Storyshots), and components/component-docs.json CI tests pass (npm test).
[ ] Tests have been added for new props to prevent regressions in the future. See readme.
[ ] Review the appropriate Storybook stories. Open http://localhost:9001/.
[ ] Review tests are passing in the browser. Open http://localhost:8001/.
[ ] Review markup conforms to SLDS by looking at DOM snapshot strings.

REVIEWER checklist (do not remove)

[ ] CircleCI tests pass. This includes linting, Mocha, Jest, Storyshots, and components/component-docs.json tests.
[ ] Tests have been added for new props to prevent regressions in the future. See readme.
[ ] Review the appropriate Storybook stories. Open http://localhost:9001/.
[ ] The Accessibility panel of each Storybook story has 0 violations (aXe). Open http://localhost:9001/.
[ ] Review tests are passing in the browser. Open http://localhost:8001/.
[ ] Review markup conforms to SLDS by looking at DOM snapshot strings.

Required only if there are markup / UX changes

[ ] Add year-first date and commit SHA to last-slds-markup-review in package.json and push.
[ ] Request a review of the deployed Heroku app by the Salesforce UX Accessibility Team.
[ ] Add year-first review date, and commit SHA, last-accessibility-review, to package.json and push.
[ ] While the contributor's branch is checked out, run npm run local-update within locally cloned site repo to confirm the site will function correctly at the next release.

First, thanks for working on this, it's been out of date for a while.
It looks like the package lock file has the internal NPM server in it and that's why the tests are failing.
From what I'm seeing at https://www.lightningdesignsystem.com/components/brand-band/#Removing-the-brand-band-image
The no image variant should not have a gradient.

Since we are changing props, we will probably want to call sunsetProperty in checkProps call to console warn if styleContainer or styleContainer is used. See https://github.com/salesforce/design-system-react/blob/master/components/checkbox/check-props.js#L17 for an example.

After fixing the lock file, I'm not seeing the gradient on the no-image version. I'll get the sunsetProperty added in the next commit.

Looks good!


Training the model using 10% of the dataset

@farrell236
Hey farrell,
Since the dataset is too large can I train the model using only 10% of the dataset? (Currently I don't have enough computational power and other resources to train the model with whole MIMIC-CXR dataset of size ~500GB). If that is possible what are the steps, I need to follow to successfully train the model with only 10% of the dataset. As far as I understand, I may need to,

Create the MIMIC_AP_PA_train.csv with only 10% of the original train dataset
Create both mimic-merges.txt & mimic-vocab.json from the (10% train + test + validate) data

Other than these do I have to follow any other steps?
Also, instead of DenseNet-121 can't we use something like MobileNetV2 for the encoder?

Hi @Wimukti, sorry for replying so late, I hope you've managed to solve it since!
You'll need to modify the file here as its responsible for creating the file MIMIC_AP_PA_train.csv. Either disable the sanity check and then delete rows from the created CSV, or delete rows in the pandas dataframe before it enters the for loop.
You would then need to also delete the corresponding rows of studies from mimic_cxr_labeled.csv because creating mimic-merges.txt & mimic-vocab.json reads all from this file.
Hope it helps!

Hi @farrell236 , Thank you so much for the reply. I was managed to solve the issue following the same steps as you have mentioned. Thank you so much for your assistance, it was much appreciated.

@Wimukti are you able to train the model? can you provide the sample of data?


How to use Saq Web in docker

I´m trying to open saq dashboard on docker.
I´m using de the config from a starlite template (https://github.com/starlite-api/starlite-pg-redis-docker).
Here is the the docker compose, with some changes:
version: "3.9"
services:
  redis:
    image: redis:latest
    ports:
      - "6379:6379"
    volumes:
      - cache:/data

  db:
    image: postgres:latest
    volumes:
      - db:/var/lib/postrgresql/data/
    ports:
      - "5432:5432"
    environment:
      POSTGRES_PASSWORD: postgres
      POSTGRES_DB: postgres

  mailhog:
    image: mailhog/mailhog
    ports:
      - "1025:1025"
      - "8025:8025"

  app:
    image: test/starlite:1.0
    build:
      context: .
      target: install
      args:
        INSTALL_ARGS: "--no-root"
    command: scripts/entry
    depends_on:
      - db
      - mailhog
      - redis
    ports:
      - "8000:8000"

    env_file:
      - .env
    volumes:
      - .:/app:cached
   saq:
    image: test/starlite:1.0
    command: python -m saq --web app.lib.workers
    ports:
      - "8080:8080"

volumes:
  db: {}
  cache: {}

It doesn´t work if I try call the worker with lib.worker or app.app.lib.worker.
Do you have any suggestion how to call the web interface on this situation?

you need to make sure that your worker is in your python path.
so you could export PYTHONPATH=$PYTHONPATH:/path_to_app
without an error message, i'm not sure i can help more, but this is my guess


Different behavior when using select in component

Version
3.2.26
Reproduction link
codesandbox.io
Steps to reproduce
use select html element with options in slot
What is expected?
empty default value in selects
What is actually happening?
default initial value is first option. If I trigger another input then value in custom select will change to empty value

Only in safari

Your code isn't working properly, maybe you should do like this:

This is what you want to do
Remember to use the forum or the Discord chat to ask questions!


Call failed to connect: Service Unavailable and Unknown UUID to perform end-call action with

why i am unable to make an incoming call? here is error log
2020-02-25 19:16:41.819463+0600 SwiftVoiceQuickstart[5004:245976] provider:didActivateAudioSession:
2020-02-25 19:16:43.712931+0600 SwiftVoiceQuickstart[5004:245976] Call failed to connect: Service Unavailable
2020-02-25 19:16:43.718792+0600 SwiftVoiceQuickstart[5004:247487] EndCallAction transaction request successful
2020-02-25 19:16:43.758431+0600 SwiftVoiceQuickstart[5004:245976] provider:performEndCallAction:
2020-02-25 19:16:43.758568+0600 SwiftVoiceQuickstart[5004:245976] Unknown UUID to perform end-call action with
2020-02-25 19:16:43.799505+0600 SwiftVoiceQuickstart[5004:245976] provider:didDeactivateAudioSession:

Hi @editrShakil
Can you provide a Twilio Call SID so that we can have a deeper look and tell you what exactly caused the failure? Based on the logs it seems you were getting a 31503 error (Service Unavailable) when trying to accept the incoming call. This is usually caused when the network connectivity problem and the mobile client is not able to reach to the service.
The second part of the failure (Unknown UUID to perform end-call action with) is printed because the TVOCall object was already deleted in the callDisconnected method due to the failure above.
Can you check if the network connectivity on the device is good and the network interface the device is connected to is not behind any firewall settings?
If this issue keeps happening in your environment, please provide TVOLogLevelTrace level SDK log so we can investigate.
Thanks,
-bobie

after changing identity it worked. now can you help me with https://github.com/twilio/voice-quickstart-ios#10-receive-an-incoming-call this section? Here what should be identity and who should be receiver? i configured push notification and credential but i am not receiving any incoming call in my device. when i call my personal number i am getting call from my twilio number when i hit on my server's /placeCall endpoint.

thanks it worked after changing identity

can you please tell me in detail about client to client calling? i run my app in two devices with only changing identity (device-1 : "alice", device-2:"bob") but i am not receiving any call on device one when calling from device two with the value "bob" in the text field. can you please explain https://github.com/twilio/voice-quickstart-ios#11-make-client-to-client-call this section so that i can make client to client call

Hi @editrShakil
Glad that things started to work.
To make a call to another client, the TwiML response from you app server must use <Dial> + <Client> with the callee identity. Your application server needs to parse the URL-encoded parameters to determine the action of the call, in this case it will be making a call to another client (value from the text field). Put the parameter key-value pairs into the TVOConnectOptions builder and then make a call, your TwiML app endpoint should receive the parameter pair(s).
-bobie

i am getting this error 52004 Credential SID not specified when i try to call a client.

Hi @editrShakil
Did you follow this step to set up a Push Credential SID and put it in the callee's access token when performing registration?

yes i did but i didnt get "Now let's go back to your server code and update the Push Credential SID. The Push Credential SID will now be embedded in your access token" this. where to set PUSH_CREDENTIAL_SID?

are you asking me to do
const token = new AccessToken(twilioAccountSid, twilioApiKey, twilioApiSecret, credentialSID);
something like this? previously i did
const token = new AccessToken(twilioAccountSid, twilioApiKey, twilioApiSecret);

Hi @editrShakil
You should be able to replace a placeholder string in the server quickstart for the Push Credential SID.

you mean this? sorry i am not getting it. i did this previously as i am using twilio functions.

This is the correct place if you are using Functions. The basic idea is to put it in the place where your server application can use the value and put it in the access token. You verify the contents of your access token by feeding the string to https://jwt.io. You should see your account credentials in the decoded string if you properly configured everything.

its working fine. thanks @bchen-twilio

Glad to hear that! I am going to close this ticket. Please feel free to reach out to us if you run into any issue.
Cheers,
-bobie

surely i will. thanks a lot. @bchen-twilio


Cancel button in row edit

material-react-table version
v0.26.2
Describe the bug and the steps to reproduce it
In row edit mode, when cancelling the same row a second time, the "cancel" button acts as confirm
Your Minimal, Reproducible Example (Sandbox or code snippets)
https://www.material-react-table.dev/?path=/story/features-editing-examples--editing-enabled-edit-mode-cell
Screenshots or Videos (Optional)
https://user-images.githubusercontent.com/31573205/179561322-b5d33783-b600-4727-a4e5-8ae3570b2c84.mp4
Do you intend to try to help solve this bug with your own PR?
No, because I don't know how
Terms

[X] I understand that if my bug cannot be reliably reproduced in a debuggable environment, it will probably not be fixed and this issue may even be closed.

 Will be fixed in 0.35.0

Should be fixed as of v0.35.1


Compose theme - new module theme

Background

Re-split fragment on new module for future compose only

Changes

New module with theme components(pallet, typography)
Fonts move to res module

Test plan

Build app

Good job, thank you!


The services in the backend are working sincronically

This would be a problem if this project scales, because having all the services running synchronically can cause concurrency problems, slowing down all the user experience of those connected to the backend.

Doing some research, I found that the better way to face this, is evaluating if the backend is requesting some database or external service, because currently it doesn't, it's not necessary to make in the services async code for now.

Doing some research, I found that the better way to face this, is evaluating if the backend is requesting some database or external service, because currently it doesn't, it's not necessary to make in the services async code for now.


Run setup for every regression test if teardown hooks installed

When the regression tests are run in the same process as the main test suite,
test/test_helper.rb installs a couple of teardown hooks for all subclasses of
Minitest::Test which are not installed when the regression tests are run in a
separate process. The two teardown hooks are as follows:

WebMock teardown hook installed by require 'webmock/minitest' which calls
WebMock.reset!
Custom teardown hook calls Timecop.return

With these teardown hooks installed, the optimisation of only running the
setup block once was no longer safe, because everything that was setup before
the first test was torn down at the end of the first test and never setup again.
And thus we saw build failure like this one where the expected Content API
stubs were not in place for subsequent tests.
Typically this didn't happen very often, because developers have tended to run
the regression tests separately on their local machine and, as long as the
relevant file checksums had been updated, the main CI build didn't run any
regression tests. However, clearly it was not a good state of affairs.
Unfortunately, because both of these teardown hooks are installed using
alias_method_chain and the WebMock one is within library code, it would've
been awkward to disable them just for the duration of the regression tests and
re-instate them afterwards.
Instead, I've chosen to detect when they are installed and in this case disable
the optimisation of only running the setup block once in the regression
tests. Unfortunately this will make the main test suite take a bit longer if
any regression tests need to be run. However, since this is a less common
scenario I think this is good enough for now.

Unfortunately this will make the main test suite take a bit longer if any regression tests need to be run.

Currently, if any regression tests need to be run they fail, so I think it's already better.
Great explanation too, LGTM :+1: :100:


Remove Levels copied from learngitbranching.js.org

By the time we release, we'll have replaced all of the following levels with entirely our own content.
1. Basics (basics)
├── 1. Introduction to Commits (committing)
├── 2. Branching in Git (branching)
├── 3. Merging in Git (merging)
└── 4. Introduction to Rebasing (rebasing)
3. Rework (rework)
├── 1. Cherrypicking (cherrypicking)
└── 2. Interactive Rebase (irebase)
4. Mixed Bag (mixedbag)
└── 1. One Commit (onecommit)

To ensure all of the content is our own for the 1.0 release, we should remove these as well
2. Rampup (rampup)
├── 1. Detaching HEAD (detaching)
├── 2. Relative References I: Using (^) (relrefs1)
├── 3. Relative References II: Using (~) (relrefs2)
└── 4. Reversing Changes in Git (reversing)

I will do this right before the v1.0 release


code - app timeline mini component

#4
todo

[x] code - app timeline mini

@input 📦 timeline_card_v0.0.1 from #9
@input 📦 window_bar_v0.0.2 from #5
[x] add timeline card
[x] add window bar
[x] make the timeline responsive
@output 📦 app_timeline_mini_v0.0.1 from comment

[x] update app_timeline_mini_v0.0.1

@input 📦 app_timeline_mini_v0.0.1
[x] fix the issue on chrome
[x] update background-pattern
@output 📦 app_timeline_mini_v0.0.2 from comment

[x] update app_timeline_mini_v0.0.2

@input 📦 app_timeline_mini_v0.0.2
@input 📦 window_bar_v0.0.8 from #5
[x] code navigation protocol
@output 📦 app_timeline_mini_v0.0.3 from comment

[x] finalize app_timeline_mini_v?.?.?

@output :question: app_timeline_mini_?.?.? from comment

next #7

tasks - 2023.06.03

code - app timeline mini - 50min

add timeline card
add window bar
make the timeline responsive
create - worklog comment, and task- 13min
@output 📦 app_timeline_mini_v0.0.1

worklog
worklog-149

feedback

proposal

feedback 2023.06.08
regarding themes
...and i noticed now in many places you wrote  instead of
Now, at the moment, it anyway makes not much sense, because the point is to differentiate between individual styling of an individual component instance compared to a style that affects all component instances of a certain type, e.g.:
a specific component should look different than all the components for example.
We achieve the overall component styling with

const sheet = new CSSStyleSheet
const theme = get_theme()
sheet.replaceSync(theme)

// and later for each instance we write

shadow.adoptedStyleSheets = [ sheet ]

That gives all component instances a shared styling
On the other hand, we can use the props or how i usually write opts or a protocol message to pass in custom theme/style to a specific component instance and that style will appear only for that particular component instance and not for all of them.
It can be applied via:
shadow.innerHTML =

**BUT** to pass in both cases the absolute identical `get_theme()` is redundant, so if you don't plan to ever pass custom styling to a particular button instance, then you can simplify your html markup to just

```js
   shadow.innerHTML = `

    `

yeah otherwise, feedback repeats, as in other issues, improve the following:
    // Listening to toggle event
    const listen = (props) =>{
        const {active_state} = props
        ;(active_state==='active')?el.style.display = 'none':''
    }

    // Adding Applicatin window Bar
    const view_more_btn = sm_text_button({text:'View more (12)'})
    const cover_window = window_bar({
        name:'TIMELINE',
        src: icon_folder,
        action_buttons: [view_more_btn]
    }, listen)

The message format always needs to be { head, refs, type, data, meta }
If you could get closer to standardjs + snake_case would be great.
And params should always be JSON.stringifyable, other than the protocol.
so:

 // Adding Applicatin window Bar
 const cover_window = window_bar({
     name:'TIMELINE',
     src: icon_folder,
     action_buttons: ['View more (12)']
 }, protocol)

 // ...
 return el
 function windowbar_protocol (send) {
   return function listen (message) {
     const { data: props } = message
     const { active_state } = props
     active_stat e=== 'active' ? el.style.display = 'none' : ''
   }
 }

and finally, cards_data should be passed as message props or protocol message and not hard coded inside a re-usable component.
And finally the following can be simplified
    const timeline_cards = cards_data.map((card_data) => timeline_card(card_data))
    timeline_cards.forEach((card) => {
        timeline_wrapper.append(card)
    })

to just
  timeline_wrapper.append(...cards_data.map(timeline_card))

it means exactly the same and if we don't make use of it, then vanillajs apps become much more verbose than they need to be :-)
lastly, even though it is concise, it is not so obviously readable as if it was explicitly marked in the html template, so
    shadow.innerHTML = `

    `

    // ....

    shadow.prepend(cover_window)

would be more obvious if it was
 shadow.innerHTML = `
   <cover_window></cover_window>

 `
 // ...
 shadow.querySelector('cover_window').replaceWith(cover_window)

tasks - 2023.11.11

update app_timeline_mini_v0.0.1 - 15min

fix the issue on chrome
update background-pattern - 4min
@output 📦 app_timeline_mini_v0.0.2

worklog
worklog-181

feedback

proposal

tasks - 2023.12.08

update app_timeline_mini_v0.0.2

code - navigation protocol - 15min
create and update tasks - 13min
@output 📦app_timeline_mini_v0.0.2

worklog
worklog-186

feedback

proposal

Awesome. I noticed one thing in filtering. If I select to show only projects and then click year 2016 I would expect to see only entries with the projects tag from 2016, not all of them. What do you think?


Synch time on synched video pages

I noticed yesterday that there is no property for the synch time showing on synched video nested pages. I'll look into this.

Hmm, it checks out on localhost in a new piece, this might be something to do with legacy pieces, we changed the nested pages a little bit for v3.0

This will be because it used to use the 'nestedPage' that only the navigators use now. I guess the synch point property was removed from it as it's not used on the pages that use this child now so for old video synch pages still using this child it doesn't know how to show the data from the xml in the editor.
I would have thought adding it back into the xwd will fix it. Not sure the best way to do this so it doesn't end up as a property again on all the navigators again that still use the nestedPage child though

I'm going to change the name of the nestPage in the xml in this case - it happens in our page types demo . I don't think it is used too often (having some analytics that can tell you how often and in what piece a page type is used on an installation would be really handy).

I've just come across this problem in the transcript reader page too. I'll add the synch property back so that it shows for pages like this but won't appear on the navigator pages still using nestedPage


Fix typo "the the"

Thanks!

Sorry, tried to merge but just noticed github didn’t let me, reopening.


Check Drone CI

Description
Drone CI jobs do not finish.
Reproduction steps
Check any of the latest PRs.
Expected vs. actual results
Drone CI job completes.
Minimal code example
N/A

Error messages
N/A

Compiler and operating system

Library version
develop
Validation

[X] The bug also occurs if the latest version from the develop branch is used.
[X] I can successfully compile and run the unit tests.

@nlohmann is it possible to help with this?

Yes: find out whether the service at Drone is discontinued, and maybe search if there is an alternative CI provider that offers ARM builds.

I found something about this in the drone Slack channel:
it has been a challenge to keep [cloud.drone.io](http://cloud.drone.io/) stable in recent weeks/months, especially for the arm-based builds
[...]
this is a known issue at the moment, we have a ticket open with our hosting provider
currently there is no ETA

I asked for an update and will write here when i a reply.
For other CI providers: it seems Travis is supporting arm64 (article, doc).

@nlohmann If travis is active for this project, i could try to add a travis job building for ARM64.

We got rid of Travis a while ago (https://github.com/nlohmann/json/issues/3087) as their open source support of 25000 credits is not sufficient for us.

OK. I guess the 6k min / month of circleci will not be enough as well...

@nlohmann I found cirrus-ci and did a small test. The test ran on an arm64 node. For open source projects there is no minute limit. I think the only limit is the number of concurrent jobs.
If you don't see a problem with this ci and enable it for the repo I can add a config as part of my fix ci PR.

@barcode Awesome!


Bad state of ui-grid stability!

Is it true that the ui-grid is very unstable right now?
I think it's not fit for professional/commercial use? Is that actually true or it's just me who has had a bad experience. My standpoint?
We were evaluating ui-grid for adoption in our app, maturing in 5-6 months. Want to have a good idea about this. Should we use ng-grid instead, until then?
I really haven't seen such an unstable & not ready RC version. Am I getting the right feel about this gentlemen, or am I mistaking something.
The ng-grid homepage says that ui-grid is in beta. Is it actually in beta, or is it in RC?
Below is a depiction of it in action (picture). Filters are working, editing is working, selections are working half, but nothing else seem to be working fine. Footer is not visible, pinning is not ok, selection check-marks are not fine, ascending/descending/pinning menu is not displaying at the right place, etc.
Regards.

Sorry, but your post here is very confusing and not constructive. You are not really reporting any bugs with a good set of steps to reproduce and screenshots to match. All you have here is a screenshot of the grid with row header selection marks missing. You have not provided your configurations and code. You have mixed multiple issues into a single, not precise post. If I was a developer of ui-grid I would simply ignore your post.
I believe you should first figure out which exact issues you are having. Then create posts here for each one of them, adding as much details, screenshots, configs as necessary. That way the developers will have much better details of what is wrong.

I'd be focusing on what version you're using, and pulling the latest unstable version which has fixes for many of the issues you mention.


[Snyk] Upgrade puppeteer from 21.9.0 to 21.10.0

This PR was automatically created by Snyk using the credentials of a real user.Snyk has created this PR to upgrade puppeteer from 21.9.0 to 21.10.0.
:information_source: Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.

The recommended version is 1 version ahead of your current version.
The recommended version was released 2 days ago, on 2024-01-29.

Release notes

Package name: puppeteer

21.10.0 - 2024-01-2921.10.0 (2024-01-29)
Features

download chrome-headless-shell by default and use it for the old headless mode (#11754) (ce894a2)

Dependencies

The following workspace dependencies were updated

dependencies

puppeteer-core bumped from 21.9.0 to 21.10.0

21.9.0 - 2024-01-2421.9.0 (2024-01-24)
Miscellaneous Chores

puppeteer: Synchronize puppeteer versions

Dependencies

The following workspace dependencies were updated

dependencies

puppeteer-core bumped from 21.8.0 to 21.9.0

    from puppeteer GitHub release notes

Commit messages

Package name: puppeteer

31a2339 chore: release main (#11756)
9cd6673 fix: set viewport for element screenshots (#11772)
2d8acd2 chore(deps): Bump the dependencies group with 6 updates (#11771)
0dedc75 chore(deps): Bump `chromium-bidi` to `0.5.6` (#11770)
4e3a0d6 chore(deps-dev): Bump the dev-dependencies group with 3 updates (#11765)
0242d22 chore(deps): Bump the all group with 5 updates (#11766)
a91a9e1 build: disable license fixer (#11768)
96b7af5 build: ESLint rule to check/add license headers (#11716)
d085127 refactor: use generic implementation for `waitForNetworkIdle` (#11757)
932b010 build: add a firefox:bidi:headful command (#11760)
ce894a2 feat: download chrome-headless-shell by default and use it for the old headless mode (#11754)
f67b205 test: update expectation for Page.removeScriptToEvaluateOnNewDocument (#11755)
f88e1da feat: add experimental browser.debugInfo (#11748)
08f7614 refactor: use generic implementation for `waitForRequest` (#11753)
3698fa8 refactor: use generic implementation for `waitForResponse` (#11752)
3a4a23f ci: use .nvmrc everywhere (#11747)
b53de4e test: dedupe test names (#11746)
230d041 chore: move test under correct file (#11745)
398b31d refactor: adopt `core/UserContext` on `BidiBrowserContext` (#11734)

Compare

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.
For more information:
🧐 View latest project report
🛠 Adjust upgrade PR settings
🔕 Ignore this dependency or unsubscribe from future upgrade PRs

coverage: 99.245%. remained the same
when pulling 9c4606558c6e0493c765f6a81c0a5e0470483fcd on snyk-upgrade-f9784686079c8fecd155efcd4621e1b7
into 9642a1895caf663c545faee324768a9650b3af8f on master.