Partial file can not use the outer context passed to it

I have a partial file, like the following:
File: pagination.html

  {{ if .NextInSection }}
    Next
  {{ end }}
  {{ if .PrevInSection }}
    Prev
  {{ end }}

In the post's single.html file, I wrote the following:
{{ partial "pagination.html" . }}

Then the build come up with an error saying:
NextInSection is not a field of struct type *hugolib.Node
However, if I replace the partial part in single.html with pagination.html's content. It works.
When calling partial file in single.html, I just passed the current context to it. Normally, pagination.html should take the outer context and find the .NextInSection variable.
Maybe I am missing something here. Any ideas ?

This should not happen.  What version of Hugo are you running?
If you are doing this from a single.html page template, the default context should be *hugolib.Page.  What does the following do?
{{ partial "pagination.html" $ }}

$ is an alias to the initial template context.

Please use http://discuss.gohugo.io/ for questions.
@moorereason I know you started a dialogue here, but if we cut a strict line here, we'll drown.

Hi @moorereason @bep ,
I have posted a question on the forum
https://discuss.gohugo.io/t/partial-file-can-not-use-the-outer-context-passed-to-it/2931
@moorereason , I have tried what you said. There are still errors.
In fact, the strange thing here is that the pagination still works on my site even if there are errors during compilation. FYI, the version of hugo is v0.15


Add support for option to select bestvideo quality and preserve audio track

By default youtube-dl provides wide range of options to select specific format, however -
-f best not always downloads best quality video. I have tried quite many other alternatives, but if you specify -f bestvideo, bestaudio - then audio is download in separate from video, or you need to have ffmpeg toolset installed.
I would prefer that it would be possible to select best video and preserve any audio, which was originally in youtube video.
youtube-dl.exe -f "(mp4)[width>=1920],keep" https://www.youtube.com/watch?v=O_t3w_jyrGQ
here is an example of command line, from my perspective it should download best video, and preserve audio. External tools (ffmpeg) should not be required.

Have you read format selection section at all? bestvideo is video only there is no audio to preserve.

What if I want to select best video based on video quality, but by preserving audio track ?


Rehome python bazel distribtest

This moves all existing Bazel distribtests to the same directory.
I also needed to run Python formatting since the previous directory was apparently excluded from formatting.

Ah, looks like isort broke the test. Interesting. I don't see why this should have failed. I guess this was a latent bug. I've filed a TODO for this to tackle fixing the latent bug, but just turned off isort in this block for now.

(I confused by the name a bit, it's testing Bazel versions, instead of using Bazel to test Python or C++.)

The point of the Bazel distribtest is to ensure that people who pull in gRPC as a dependency via Bazel are able to use it properly. Specifically, this tests:

grpc_deps
grpc_extra_deps
py_proto_library
py_grpc_library
cc_grpc_library

And various features of all of the above. The Python Bazel distribtest in particular has really good feature coverage because of community contributions.


[themes] Offer a theme checker that reports missing theme keys

In this iteration we added tree.indentGuidesStroke. I had to open an issue for my fav theme, but there would be countless themes that's not updated.
We should have a theme checker that would report themes that's not specifying newly added keys.
/cc @bpasero @Tyriar

I am not convinced, I think the best themes will win that update themselves frequently. That is just natural selection?

Also themes aren't meant to use all keys imo, we should be calling out the new ones in release notes and theme authors can always diff manually if they want.

I'm the creator of the Nord theme and I'd really appreciate to have a helper tool like this to keep up with the regular changes.
Maybe it's not necessary to directly implement this into VS Code, but creating a NPM package that is officially maintained by the VS Code team would be already enough.
As an example, there is a package called eslint-find-rules I'm also using for my ESLint rule presets and it really helps to keep up-to-date with the frequent updates of ESLint. The package is on average downloaded over 15k times a day so it's definitely a common use case and it's also co-maintained by the core maintainer of the famous Airbnb JavaScript style guide and ESLint presets since it also helps to maintain their packages.
@bpasero  @Tyriar I agree with your argument that this is kind of a "natural sorting of good themes" and that a theme author should care about the upstream application it has been developed for by adapting to changes, but not everyone has the time (or gets paid) to actively maintain open source projects or in my case when maintaining more than 35 other repositories of a color theme + a many other projects (+job etc.).
One could argue now that a theme creator could create the theme key checker NPM package, but in the required effort would be the same: Manually crawling through release notes as well as hundreds of commits in order to find all new/modified/deprecated/removed theme keys.
I think it won't take much time to create such a package and to maintain it either

a single new developer guideline for PR's in the VS Code repository could be introduced that says to also always create a PR in the NPM package repository too when the PR changes anything regarding theme keys.
the NPM package parses the JSON schema for themes and generates a list of valid (+deprecated) keys of it.

Regarding the fact that not every theme makes use of every theme key: The package could provide a way (config file, CLI flag etc.) to allow theme authors to define keys that should be ignored.
To keep the NPM package also up-to-date it could be added to VS Code's automated CI/CD pipeline by always pushing a new tagged NPM package version as soon as a new VS Code gets prepared and deployed.
Sorry for the wall of text, but I'd like to bring in some ideas so this request might be accepted without taking too much effort.

@arcticicestudio thanks for your input and btw I really like your theme 👍 . Let's see what we can do here, I am happy to review a PR that implements this maybe as part of our "developer" related actions (link).

@bpasero Thanks for the kind words 😊
A developer action sounds like a  great idea and would fit well to the already existing action >Developer: Generate Color Theme From Current Settings to allow user to verify and lint their newly created color theme before using/publishing it.

This seems like something that should not be bundled with vscode in the interest of reducing bloat? Someone could build an npm package that extracts and exposes all the keys from https://code.visualstudio.com/api/references/theme-color or from the vscode code base?

This should be automate-able as well. Programmatically run find references on registerColor in colorRegistry.ts and for each result, extract the color name/deafult/nls-name and output them into a JSON.
Or expose a command to ask ColorRegistry all keys.

@Tyriar, @bpasero I think that I can implement something that does what is mentioned above using the developer action.
Should I submit a PR for this, or is this something that should be done in a separate npm package?

This can probably be closed with https://github.com/microsoft/vscode/commit/1436b523d4aaa773ab246daa68daaa70cef48b1d.  All colors are output now, if the color isn't specified then it is output with the default or null as a comment.
{
	"$schema": "vscode://schemas/color-theme",
	"type": "dark",
	"colors": {
		"activityBarBadge.background": "#007acc",
		"editor.background": "#1e1e1e",
		"editor.foreground": "#d4d4d4",
		//"activityBar.activeBorder": "#ffffff",
		//"activityBar.background": "#333333",
		//"activityBar.activeBackground": null,
		//"activityBar.activeFocusBorder": null,
	}
}


esjob can not shutdown correctly when encountering spring context destory in initializing

Description :
I have more than one job in an elastic-job base project and running in the spring envionment.
when spring application  initializing and some of jobs was already initialized ，but before initialize other jobs , some compoents encountering a problem and throw an error, it cause the
spring beans' destory(call spring destory method) and rest of initializing processes must be stop.
for all that , the initialized jobs still running .so the application is running but some uninitial  jobs‘ state was shutdown  and in the running jobs' method , it can not run correctly(because some components such as datasource was already shutdown.
Which version of ElasticJob did you use?
2.1.5
Which project did you use? ElasticJob-Lite or ElasticJob-Cloud?
ElasticJob-Lite
Expected behavior
all jobs in project and the application must shutdown
Actual behavior
some jobs was running and some jobs was shutdown , the application still running
Reason analyze (If you can)
the elastic-job framework didn't handle the spring destory event and when spring initialize failed , esjob still in the memory.
Steps to reproduce the behavior.

create two jobs implements SimpleJob and config as elastic-job
in the second job class , inject an instance which not in spring context.
run the application an will see the first job is running and second not.

Example codes for reproduce this issue (such as a github link).
simple jobs code like that
public A implements SimpleJob{

  public void execute(ShardingContext shardingContext) {
         System.out.println("A");
    }
}

public B implements SimpleJob{
  @Autowired
  A a;
  public void execute(ShardingContext shardingContext) {
         System.out.println("B");
    }
}

make A  job before B job  in the esjob-config xml  file

I will try to reproduce in the latest version, and if the bug still exists, I will try to fix it later.

Hi, @terrymanu and @mmx1960 , this issue seems to be fixed by #583 .

Hi, @terrymanu and @mmx1960 , this issue seems to be fixed by #583 .

thank u , this  commit is sure to fixed this issue, but there is another little problem and i will open a new issue


Ingest orderbook to DGraph (R&D required)

Core has "orders" database table which is updated using LedgerDelta on behalf of transaction meta. It must be done in DGraph in the same way (this involves meta ingestion, requires R&D).

Decision: for now, we can keep orderbook on core side only, just need to implement queries.


NVS Encryption Bug - symmetric key not generated inside device and image not encrypted (IDFGH-13675)

Answers checklist.

[X] I have read the documentation ESP-IDF Programming Guide and the issue is not addressed there.
[X] I have updated my IDF branch (master or release) to the latest version and checked that the issue is present there.
[X] I have searched the issue tracker for a similar issue and not found a similar issue.

IDF version.
v5.3.1
Espressif SoC revision.
ESP32 WROVER - 8MB PSRAM version
Operating System used.
Linux
How did you build your project?
Command line with idf.py
If you are using Windows, please specify command line type.
None
Development Kit.
ESP32 WROVER - 8MB PSRAM version
Power Supply used.
USB
What is the expected behavior?
When NVS encryption is enabled and I generate the NVS image in plain text outside of the device and then program it to device, the ESP32 fails to generate its own key and this causes the NVS section to NOT be encrypted.
I would expect that if I enable the correct options, that once the NVS plain-text image is programmed, that the device will generate its own key (never seen outside of the device) and allow NVS section to be encrypted
Here are things that do work:

Generating the key outside of the system and then pre-encrypting the NVS and writing the keys and NVS does allow NVS to be encrypted
Not programming the NVS image into the device BUT instead just having the code do NVS read() /writes() and enabling NVS encryption does manage to generate the key inside the device and encrypt.

What is the actual behavior?
When NVS encryption is enabled and I generate the NVS image in plain text outside of the device and then program it to device, the ESP32 fails to generate its own key and this causes the NVS section to NOT be encrypted.
Steps to reproduce.

Use python nvs_partition_gen.py generate  static_config.bin 0x6000
Above will generate a file called static_config.bin that can be programmed to 0x12000 (or whatever address you set up for the NVS partition
Make sure in the sdkconfig you enable : CONFIG_NVS_ENCRYPTION=y
boot device and notice encryption key does not get generated and NVS section is not encrypted
You can use  esp's read flash utility to look at the memory

Debug Logs.
No response
More Information.
No response

@lnayman
Relevant https://github.com/espressif/esp-idf/issues/12350
If you would like to pre-flash encrypted NVS contents then you can generate the NVS encryption key on the host and then encrypt the partition using the generated key. NVS component does not encrypt the pre-flashed contents which already exist in the NVS partition.
Please refer to this guide for generating the NVS key partition and encrypted data partition on the host machine.
Hope this helps!


doc: fix typo

modify "成为" to "称为"

/check-cla

/retitle [zh] doc: fix typo

Hi @kylinxiang70 , this PR has been open for over 50 days with no action to sign the CLA. If there's no action within 7 days, a PR wrangler may close this PR.

Hi @kylinxiang70 , since there has been no action to sign the CLA, I'm closing this PR.
Feel free to re-open when you have signed the CLA
/close


Fix update to scope that was defined with an enum

This is a non-issue with activesupport 5.0, but prior to that, when
check_scope is assigning the attributes hash, the assignment of an enum
is invalid and results in a value of 0 being assigned as the scope.
Assigning with the enum's setter instead.
Fixes #277

Thanks bro :)


Move webpack-cli to devDependencies

Fixes #522.

For the record, it appears that fsevents was added in the package-lock.json It appears to be an optionalDependency for chokidar. I don't see any harm in it being added. However
@frangio Out of curiosity, are you on a Mac? I would guess why the FSEvents was installed:

Native access to OS X FSEvents in Node.js

I'm on Linux so I don't know why that happened. I've lost hope on trying to understand the lockfile changes done by npm.


Update MD file on new branch 2017-20-13_19-11-35

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

split/updateTestCon.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Improve PROJECT TAB "Number of Variables" and "Number of Sources" card

adjusts wording to emphasize more than just COVID
Original "15 variables" was likely 5 conditions x 3 demographic options. This updates the dynamic calculation to include all COVID sub-variables, along with accounting for these demographic multipliers. Currently brings total variables to 24
Adds hyperlinks to condition names directly to a national level report on the data tracker. Makes it easy to navigate directly to where a user might have interest


Brightness warning

Getting the following warning:
[02/12/2024, 16:26:58] [homebridge-enphase-envoy] This plugin generated a warning from the characteristic 'Brightness': characteristic value expected valid finite number and received "NaN" (number). See https://homebridge.io/w/JtMGR for more info.

Post debug log please

Warning went away after defining a few sensors, hitting some errors now:
Error: Start error: Error: Update power production state error: Request failed with status code 401, trying again.
See attached debug log
homebridge-enphase-envoy.log.txt

Disable power production control in plugin config, this options require installer credentials data

Same error in PLC. Device: envoy.local Zonnepanelen, Error: Start error: Error: Update plc level error: Request failed with status code 401, trying again.

Yes, disable it

Both issue fixed in 9.6.4

Ok.thx


How to implement 'logout' feature

I'm very new to JWT and postgrest, so the following question may seem stupid: Is there any example for 'logout'?  Thanks for help!

Using plain JWT, logging out would simply be 'forgetting' the JWT on the client side. But then you will need a way to retrieve the same JWT from the server the next time you log in, i.e. an extra layer of authentication.

Ah, I got it! BTW, I noticed the token generated from server is the same string for the same user/pass, only if I change the -j parameter. Is there best practice to make it 'more' secure? (i.e change the jwt secret automatically). Thanks!

The best practice is to generate a binary secret: https://github.com/begriffs/postgrest/issues/473
but sadly, this currently results in a corrupted secret due to a pending bug: https://github.com/begriffs/postgrest/issues/495
In the meantime, I would suggest choosing a long enough passphrase in plain text, rather than a single word, for your secret.

For voluntary client logout discarding the jwt on the client side will work. For forcible server-side user banning there is a PR open to help with that. Closing this issue. If you have more questions about JWT feel free to ask.


Extract ImportAssets out of auto_import

See https://github.com/rust-analyzer/rust-analyzer/pull/6172#issuecomment-707182140
I couldn't fully pull out AssistContext as find_node_at_offset_with_descend: https://github.com/rust-analyzer/rust-analyzer/blob/81fa00c5b5d5ffb559a39c7ff5190a2519a8ea61/crates/assists/src/assist_context.rs#L90-L92 requires the SourceFile which is private in it and I don't think making it public just for this is the right call?

Hm, I could use insert_use on the ide level: I'm slowly working on autocompletion with automatic usage insertion and just realised this.
Any ideas the approach we should take to share the code?

All that would be required for that should be in the utils module after this PR, you'd basically have to do the same work auto import does I'd say. So all that would have to change for that would be the visibility qualifiers.

bors r+

bors retry
some npm fluke

bors retry


RSA10d

Not entirely sure I understand the isOnlyForce logic, but this change sin 0.9 anyway so I think we should merge anyway

Not entirely sure I understand the isOnlyForce logic

RSA10d spec states:

A special case convenience exists for AuthOption stating that if all its attributes are null apart from force, then when passed to authorise as an argument, the previously configured authentication options will remain intact.

So I had to check that all attributes except force are nil, store result in isOnlyForce variable and use inside scope of ARTAuth class.

So I had to check that all attributes except force are nil, store result in isOnlyForce boolean variable and use inside scope of ARTAuth class.

Ok, thanks, I do follow now, sorry about that!

Please review and merge if everything looks good

@EvgenyKarkan I am aware that this change is a 0.9 change that is breaking i.e. we should not be merging this into master as that is currently the 0.8 branch.  Before we merge this, I think we need to start a 0.8 branch and maintain that in case any hot fixes are needed on that branch.
It may be worth having a quick catch up today / tomorrow to discuss our 0.8/0.9 strategy

Will change the base to master.

Squashed.

@mattheworiordan @tcard Are you happy with this?

@mattheworiordan Just clarifying, i'm confused. Why are you saying that this is a 0.9 change and should not be merged? From what I saw, the 0.9 removes the force property, so this change is only for 0.8, right?

LGTM


Any thoughts for providing support for TimeStamp?

Are you planning to add timestamp type to the json schema?

Hi, so far we don't have such plans. For our use-case it suffices to use timestamps as strings and let the specific parsing be done by the application. However we do welcome external pull requests.

Thanks for letting me know.

Just to clarify, this request is to add support for date-time formatted strings in a JSON Schema like:
"TimestampField": {
    "type": [
        "null",
        "string"
    ],
    "format": "date-time"
},

And having spark-json-schema interpret these fields as Timestamps?


feat: nature.semver module

the nature.semver module would offer parsing and other things related to semantic versions.
it'll be able to parse a string into a table for major, minor and patch version numbers, compare versions, etc
Functions

greater(ver1, ver2) - checks if ver2 is greater than ver1
lesser(ver1, ver2) - checks if ver2 is less than ver1
major(ver) - returns major version number
minor(ver) - returns minor version number
patch(ver) - returns patch version number
parse(ver) - attempt to parse ver as a semantic version
valid(ver) - check if ver is a valid semver

existing external solutions exist, and i don't think it's really needed in default so just use the existing solutions if you want them


Improve error reporting in case of knative is required but not installed

Fix https://github.com/apache/camel-k/issues/3803
The knative check, required the Client object in Environment for various tests.
Release Note
Fix: Improve error reporting in case of knative is required but not installed

I think it makes sense to backport this one to 1.12 and 1.10.


Use new submariner-operator Helm chart in Helm docs

There is a new Helm chart that is a loose wrapper around the Operator to deploy Submariner. Move the main Helm docs to use that submariner-operator chart, vs the old Helm-only submariner chart.

helm install submariner submariner-latest/submariner

https://submariner.io/operations/deployment/helm/

This was reported by a user on Slack.
https://kubernetes.slack.com/archives/C010RJV694M/p1612989666481200

also the following needs to be changed on the https://submariner.io/operations/deployment/helm/ page: export SUBMARINER_NS=submariner


Updates the deployment code to use a different default ARN

Updates clusternator to use an updated default ARN for certs
Updates documentation to note that on OS X brew now uses gpg 2 by default

:shipit:


Last tab is moved to second place on session restore

For several weeks, I've been annoyed by a strange behaviour and finally took the time to look for the cause which happens to be the "Open tabs next to current" extension.
The problem: every time I open Firefox, my previous session is reloaded BUT the last tab is suddenly moved to the second place in the tab bar (very similar to the Closed issue https://github.com/sblask/webextension-open-tabs-next-to-current/issues/28)
It took me a bit of time and patience to find the cause as I have 40+ extensions and had to use dichotomy in deactivating them until the problem disappeared.
To make matter worse, the problem does NOT happen the first time you restart Firefox after you just disabled/enabled/removed/installed any add-on!
Anyway here are simple steps to reproduce it:

Create a new profile in Firefox
Preferences > General > When Firefox starts: Show your windows and tabs from last time
Install add-on "Open Tabs Next to Current"
Open 4 tabs with different websites to identify them easily, let's call them A B C D
Close & Reopen Firefox: the order is correct: A B C D
Close & Reopen Firefox again: the order is now A D B C
Close & Reopen Firefox again: the order is now A C D B
and so on...

I'm using Firefox 54 (64 bits) on Ubuntu 17.04 with Open Tabs Next to Current 2.0.8

Nothing I can do about this right now. Seems like my hacks don't work good enough and there is no proper way of fixing this. See https://bugzilla.mozilla.org/show_bug.cgi?id=1364019 and my comment there.

I have the same problem (FF 57, Fedora 27, OTNTC 2.0.8). It took me several hours to find this report, and I even reported a bug against a wrong extension (https://github.com/piroor/treestyletab/issues/1483). This is still supposed to be not fixed, right?
Could you please reopen this ticket, so that it's clear this is an unresolved bug immediately when looking at this github page? Also, could you please mention it in the readme in the appropriate section? This is pretty much a show-stopper for anyone using TreeStyleTabs, so it would be nice to make it a bit more discoverable.
Also, if there's no proper way to handle this, is it possible to add some hack, e.g. "don't touch the tabs in the first 10 seconds after starting the browser"? Not ideal, but better than nothing. Thanks.

Another idea is to detect when too many tabs are opened during a very short time interval (like > 5 tabs in < 0.5 seconds - just random numbers) and ignore those events. Maybe some other extensions (like TST) already have some code working around this problem?

Here is a workaround on my addon Tree Style Tab:
https://github.com/piroor/treestyletab/blob/697d62cbe896ac97fbe8c8d19a41232ecec83bfb/webextensions/background/background.js#L70

And here is another workaround to detect duplicated/restored tab on tabs.onCreated:
https://github.com/piroor/treestyletab/blob/697d62cbe896ac97fbe8c8d19a41232ecec83bfb/webextensions/common/tree/base.js#L76
This workaround depends on sessions.setTabValue/getTabValue, introduced at Firefox 57.

I won't do any hacks, but I might do the session value workaround when I find the time. Not a big fan of using a Chrome incompatible API though.

Any ETA for the fix?

I uploaded a new beta to https://addons.mozilla.org/en-GB/firefox/addon/open-tabs-next-to-current/versions/beta . I think it does the right thing (if you use Firefox 57). But I could never reproduce this problem reliably, so please have a look and let me know.

It seems to be a race condition. With 2.0.10b it's much rarer, but still happens from time to time :/

I have a hard time seeing how it could still happen, unless you create loads of tabs and close the browser immediately so the ID can't be saved. Let me know if you find a way to reproduce.

I have a hard time seeing how it could still happen, unless you create loads of tabs and close the browser immediately so the ID can't be saved.

I thought it could be the case, but even when I try, I can't break it now. Hmm. I've also seen the issue multiple times right after upgrading from 2.0.8 to 2.0.10b, but again it's not reliable, and a one-time issue doesn't concern me that much. During standard open up/close browser sequence, I don't seem to be able to break it at the moment. I'll need to use it for a longer time and see.
Definitely thanks for the fix, though.

Fair enough. I think there could be a problem once you install the new version and have existing tabs. It seems random when the extension gets access to tab events (probably because tabs and extensions are loaded concurrently). So some tabs might not cause an event / get the ID and on another start they cause the event I am listening to, don't have the ID and hence are moved. As you said, normal use should not be an issue. I'll go ahead, merge the fix and release a proper version.

I think there could be a problem once you install the new version and have existing tabs. It seems random when the extension gets access to tab events (probably because tabs and extensions are loaded concurrently). So some tabs might not cause an event / get the ID and on another start they cause the event I am listening to, don't have the ID and hence are moved.

That's likely. Maybe you could add ID to all existing tabs when your extension is started, to make sure they're not considered new tabs the next time the browser starts? That could cover this "parallel tabs+extensions startup" loophole.

I'll go ahead, merge the fix and release a proper version.

Thanks.

This is not fixed :/ I upgraded my home computer yesterday from FF56 + tab groups to FF57 + tree style tabs + open tabs next to current. It had 100+ tabs. On the second browser restart the tabs got shifted, probably due to the bug we talked about here, no problem, one time issue. But today, after many more browser restarts, my tabs got shifted again. The browser was running for hours, it was not a "quick startup and shutdown" case. I spent 10 minutes moving the tabs into the correct trees (I have lots of tabs!). I tried two more browser restarts, no issue. I don't know how to trigger this, but it's clearly happening from time to time. Perhaps it's related to tabs that were opened before OTNTC was installed, maybe not. But I simply can't afford to fix my 100 tabs every time this occurs, so I had to disable OTNTC :(

Alright, now it happened even with OTNTC disabled. So this time it was not its fault, but probably a fault of tree style tabs.  Sorry for confusion.

If you want to open an issue with  them, you can point to this commit I made: https://github.com/sblask/webextension-open-tabs-next-to-current/commit/17a55731752c2be399dd73b47a111eb97be9e335 it sets a ID for all open tabs and whenever a new tab gets opened. Maybe it can be useful to fix the issue...

Hi,
It does not seem to be fixed on V2.0.11 with Firefox ESR 52.9.0
Can you reopen this issue ?

@sebma Firefox 52 is not supported.

@sblask https://addons.mozilla.org/en-US/firefox/addon/open-tabs-next-to-current/versions/ says :
Version 2.0.11 Released Nov. 24, 2017 9.4 KiB
Works with Firefox for Android 51.0 and later, Firefox 51.0 and later
Isn't Firefox 52 later than Firefox 51 ?

Yes and it does work. But the fix works only for later versions. Also Firefox 52 is past it's end of life.

@sblask I see. My problem is I can't use Firefox-ESR 60 because, 3/4 of the addons I have won't work anymore because they have not been ported and most of them don't have an equivalent.
Do you think you could provide a fix for Firefox-ESR 52 as well ?

No, it requires an API that is not available in 52.

@sblask OK, I understand I'll switch to "tab mix plus" instead. It contains the same functionality (among others) without this bug.
Thanks a lot for your help :-)
Cheers.


Refresh and best practice

Reading the code I see there is a poller that checks for the version of the AWS secrets and updates them in k8s if they change. I also see that the polling can be disabled and that in that case Kubernetes events are watched regarding the secrets.
Am I right ? It should be noted that secrets are not updated automatically if used as environment variables for instance, and pods won't be restarted automatically. I think it should be noted somewhere

Events for external secrets are always watched for, regardless of whether polling is enabled or disabled. Polling is enabled by default, and will trigger updates in the kubernetes secrets if anything happens to change in the secret backend.
I believe its to be expected that pods won't be magically restarted due to a secret object being reconfigured. This is left to how kubernetes behaves normally, one could for example probably use something like https://github.com/stakater/Reloader to

Thanks @Flydiverny, I'll definitely look at that other project. So you're saying that external secrets are always watched, and polling is more about updating the Kubernetes secrets right away or based on polling frequency ?


get_char_size() is exposed only by BitmapFont but should be exposed by Font

Godot 3.1 alpha2
If you want to get the size of a single character within a string, you have to use get_char_size() to handle kerning. This is a function available in Font, however it was exposed to the script API only for BitmapFont, while it should have been exposed from the base class. As a result, the call fails if you use a DynamicFont.

Yes just ran into this as well while trying to implement some custom text rendering. Would really appreciate if someone who contributes could expose this function.


Input doesn't work in fullscreen

When I use the Phaser function to go to fullscreen, it breaks the phaser-input functionality.  I still see the input box and have a blinking cursor but cannot enter any text. If I toggle back out of fullscreen, without reloading the browser page or the game state, the input field works again.
I confirmed that the default setting for input options for zoom is correctly set to false and I'm currently testing on a desktop browser using Chrome.

Hey @ebyron15,
I found the problem and fix it for my self. Let me explain to you.
Phaser Input is adding the input element to directly body and if you add your game in another div it's not working.
So for example i change my config like this:
var config = {
     width: 1920,
     height: 1080,
     renderer: Phaser.AUTO,
     fullScreenTarget: document.getElementById('core'), // this line is new for me
     parent: 'core'
};

And also inside phaser-input.js, on var InputElement = .... part, added this instead of this:
document.body.appendChild(this.element);
->
document.getElementById('core').appendChild(this.element);

Just cause my parent div is named core.
Cause my config have fullScreenTarget option, It's changing that div which is core div for me.
And cause they are the same directory like same parent div's(i mean canvas and input element) it's working.
I actually wanted to make the change and make a PR for this. But idk how to edit .ts files 😄
I only change the phaser-input.js, so it's not inside .min or .map or .ts files.
Anyway i changed directly on .js build. But Maybe @AleBles could change and make it for us?

Thanks for sharing this. I don't have a div in my html but I was able to
add the id to the  and that worked.  Really appreciate the help.
Eric
On Tue, Nov 27, 2018 at 12:42 AM Halil CAKAR<EMAIL_ADDRESS>wrote:

Hey @ebyron15 https://github.com/ebyron15,
I found the problem and fix it for my self. Let me explain to you.
Phaser Input is adding the input element to directly body and if you add
your game in another div it's not working.
So for example i change my config like this:
var config = {
width: 1920,
height: 1080,
renderer: Phaser.AUTO,
fullScreenTarget: document.getElementById('core'), // this line is new for me
parent: 'core'
};
And also inside phaser-input.js, on var InputElement = .... part, added
this instead of this:
document.body.appendChild(this.element);->document.getElementById('core').appendChild(this.element);
Just cause my parent div is named core.
Cause my config have fullScreenTarget option, It's changing that div which
is core div for me.
And cause they are the same directory like same parent div's(i mean canvas
and input element) it's working.
I actually wanted to make the change and make a PR for this. But idk how
to edit .ts files 😄
I only change the phaser-input.js, so it's not inside .min or .map or .ts
files.
Anyway i changed directly on .js build. But Maybe @AleBles
https://github.com/AleBles could change and make it for us?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/orange-games/phaser-input/issues/74#issuecomment-441708971,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AacAJqc_DmMUaTYiPj2i35wkTGtZZLT8ks5uzBnugaJpZM4YlBhU
.

I'm glad that i could help @ebyron15. I hope also they made the changes for us for use properly @AleBles @zBart

@halilcakarr If I understand correctly I can do the following:

First check if fullscreentarget is set, if so, append input to that element
If there is no fullscreen target we'll add it to the parent of the canvas
If all fails we can add it to the body

Hey @AleBles,
I think with this update, everything will be fine for now.

Hello @AleBles, Is there any news about this ? :)


remove akka from LICENSE-binary

I downloaded the Pinot 1.0.0 binary release and couldn't find any Akka jars or classes. Since Akka is no longer OSS, it is good to try to remove remaining uses.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (1d490c1) 61.77% compared to head (f66fdc2) 27.73%.

Additional details and impacted files
@@              Coverage Diff              @@
##             master   #12443       +/-   ##
=============================================
- Coverage     61.77%   27.73%   -34.05%
  Complexity      207      207
=============================================
  Files          2436     2436
  Lines        133130   133128        -2
  Branches      20623    20623
=============================================
- Hits          82241    36921    -45320
- Misses        44850    93400    +48550
+ Partials       6039     2807     -3232

Flag
Coverage Δ

custom-integration1
?

integration
<0.01% <ø> (ø)

integration1
<0.01% <ø> (ø)

integration2
0.00% <ø> (ø)

java-11
?

java-21
27.73% <ø> (-33.93%)
:arrow_down:

skip-bytebuffers-false
27.73% <ø> (-34.00%)
:arrow_down:

skip-bytebuffers-true
<0.01% <ø> (-61.62%)
:arrow_down:

temurin
27.73% <ø> (-34.05%)
:arrow_down:

unittests
27.72% <ø> (-34.05%)
:arrow_down:

unittests1
?

unittests2
27.72% <ø> (-0.03%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Thanks for updating this!


FTP was solved with old version of AllSky

Greetings,  with the older version of Allsky I was able to follow this link to get the ftp working
https://github.com/thomasjacquin/allsky/issues/74
I added the setting to the files but the software will not upload to my website.
any suggestions.
Mike

Mike, try adding "echo" before the lftp line in the .sh file that isn't uploading correctly.  Then try executing that command manually.   You will need to put quotes in the same places you see them in the .sh file.  This way you will see any error messages.

Mike, try adding "echo" before the lftp line in the .sh file that isn't uploading correctly. Then try executing that command manually. You will need to put quotes in the same places you see them in the .sh file. This way you will see any error messages.

I not sure if it just lack of knowledge or I screwed up something good.  I placed the echo on the command line you stated and it echo the command but does nothing. i check my hosting site and there is nothing placed there.
the log file is stating it is upload the file but it is not on my website
Aug 14 20:10:29 Pi-AllSky allsky.sh[1355]: lftp ftp://*:@n3bsq.com:/domains/n3bsq.com/public_html/allsky/ -e set net:max-retries 2; set net:timeout 20; put image.jpg -o si-3941; rm -f image.jpg; mv si-3941 image.jpg; bye
not sure if i did the command correctly or not.

Mike,
you did it correctly.  "echo" simply outputs everything on the line; it does not execute anything.  I wanted to see what that file was trying to execute.
Remove the "echo", then at a shell prompt, type the following from the /home/pi/allsky directory:
lftp "ftp://*:@n3bsq.com:/domains/n3bsq.com/public_html/allsky/" -e "set net:max-retries 2; set net:timeout 20; put image.jpg -o si-3941; rm -f image.jpg; mv si-3941 image.jpg; bye"
Make sure you include the double quotes.
What's in the shell script is:
lftp "$PROTOCOL://$USER:$PASSWORD@$HOST:$IMGDIR" -e "set net:max-retries 2; set net:timeout 20; put "$IMAGE_TO_USE" -o $TEMP_NAME; rm -f "$IMAGE_TO_USE"; mv $TEMP_NAME "$IMAGE_TO_USE"; bye" &
The "echo" allows us to see what all the variables are (that start with $).
I notice some likely issues:

Your $USER is "*".
Your $PASSWORD is empty.

Make sure your settings in the scripts/ftp-settings.sh file are correct.  Here are the defaults:
PROTOCOL='ftp'
USER='username'
PASSWORD='password'
HOST='example.com'
IMGDIR='/allsky/'
MP4DIR='/allsky/videos/'
KEOGRAM_DIR='/allsky/keograms/'
STARTRAILS_DIR='/allsky/startrails/'

Once you can successfully login manually and have fixed your settings, allsky should be able to as well.

i have the setting set correctly in the ftp-settings.sh I just scrubbed the username and password from the lftp line
here is the output i get from the lftp command
pi@Pi-AllSky:~/allsky/scripts $  lftp ftp://:@n3bsq.com:/domains/n3bsq.com/public_html/allsky/ -e set net:max-retries 2; set net:timeout 20; put image.jpg -o si-3941; rm -f image.jpg; mv si-3941 image.jpg; bye
cd ok, cwd=/domains/n3bsq.com/public_html/allsky
set cmd:prompt "lftp \S\? \u\@\h:\w> "
set cmd:term-status/rxvt "\e[11;0]\e]2;\T\007\e[11]"
set cmd:term-status/screen \e_\T\e\
set cmd:term-status/xterm "\e[11;0]\e]2;\T\007\e[11]"
set color:dir-colors "rs=0:di=01;34:ln=01;36:mh=00:pi=40;33:so=01;35:do=01;35:bd=40;33;01:cd=40;33;01:or=40;31;01:mi=00:su=37;41:sg=30;43:ca=30;41:tw=30;42:ow=34;42:st=37;44:ex=01;32:.tar=01;31:.tgz=01;31:.arc=01;31:.arj=01;31:.taz=01;31:.lha=01;31:.lz4=01;31:.lzh=01;31:.lzma=01;31:.tlz=01;31:.txz=01;31:.tzo=01;31:.t7z=01;31:.zip=01;31:.z=01;31:.dz=01;31:.gz=01;31:.lrz=01;31:.lz=01;31:.lzo=01;31:.xz=01;31:.zst=01;31:.tzst=01;31:.bz2=01;31:.bz=01;31:.tbz=01;31:.tbz2=01;31:.tz=01;31:.deb=01;31:.rpm=01;31:.jar=01;31:.war=01;31:.ear=01;31:.sar=01;31:.rar=01;31:.alz=01;31:.ace=01;31:.zoo=01;31:.cpio=01;31:.7z=01;31:.rz=01;31:.cab=01;31:.wim=01;31:.swm=01;31:.dwm=01;31:.esd=01;31:.jpg=01;35:.jpeg=01;35:.mjpg=01;35:.mjpeg=01;35:.gif=01;35:.bmp=01;35:.pbm=01;35:.pgm=01;35:.ppm=01;35:.tga=01;35:.xbm=01;35:.xpm=01;35:.tif=01;35:.tiff=01;35:.png=01;35:.svg=01;35:.svgz=01;35:.mng=01;35:.pcx=01;35:.mov=01;35:.mpg=01;35:.mpeg=01;35:.m2v=01;35:.mkv=01;35:.webm=01;35:.ogm=01;35:.mp4=01;35:.m4v=01;35:.mp4v=01;35:.vob=01;35:.qt=01;35:.nuv=01;35:.wmv=01;35:.asf=01;35:.rm=01;35:.rmvb=01;35:.flc=01;35:.avi=01;35:.fli=01;35:.flv=01;35:.gl=01;35:.dl=01;35:.xcf=01;35:.xwd=01;35:.yuv=01;35:.cgm=01;35:.emf=01;35:.ogv=01;35:.ogx=01;35:.aac=00;36:.au=00;36:.flac=00;36:.m4a=00;36:.mid=00;36:.midi=00;36:.mka=00;36:.mp3=00;36:.mpc=00;36:.ogg=00;36:.ra=00;36:.wav=00;36:.oga=00;36:.opus=00;36:.spx=00;36:.xspf=00;36:"
set dns:order "inet6 inet"
set file:charset UTF-8
set ftp:auto-sync-mode "icrosoft FTP Service|MadGoat|MikroTik"
set ftp:sync-mode/ftp.idsoftware.com on
set ftp:sync-mode/ftp.microsoft.com on
set ftp:sync-mode/sunsolve.sun.com on
set ssl:ca-file /etc/ssl/certs/ca-certificates.crt
set ssl:verify-certificate no
set xfer:max-redirections 10
lftp u919658081@n3bsq.com:/domains/n3bsq.com/public_html/allsky>

i hit the enter key too quick.  i have to type bye and then get the following
lftp u919658081@n3bsq.com:/domains/n3bsq.com/public_html/allsky> bye
-bash: put: command not found
mv: cannot stat 'si-3941': No such file or directory

For the record - I haven't updated either of my external web-hosts with the new updates from Eric 9 days ago (https://bit.ly/3AFs1CP). But I did update my Allsky to v0.8.
I had to change up the LFTP command a bit to the following:
lftp "$PROTOCOL://$USER:$PASSWORD@$HOST:$IMGDIR" -e "set net:max-retries 2; set net:timeout 20; put "$IMAGE_TO_USE" -o $TEMP_NAME; rm -f "$IMAGE_TO_USE"; mv $TEMP_NAME "image-resize.jpg"; rm -f $TEMP_NAME; bye" &
It made it so the original "image-resize.jpg" would still be used.
Just a thought that may help, if you're in the same boat.

Mike,
The "-bash" error implies the "put" part of the lftp was being executed by the shell, not by lftp.  Check your double quotes.  They should be like this:
lftp "ftp://*:@n3bsq.com:/domains/n3bsq.com/public_html/allsky/" -e "set net:max-retries 2; set net:timeout 20; put image.jpg -o si-3941; rm -f image.jpg; mv si-3941 image.jpg; bye"
lftp is taking 3 arguments - one with the protocol, user name, etc.  One with "-e" and the last with "set ... bye".

ok i just reimaged my sd card and did a new pull for the software.  I reset my ftp-settings.sh and now i see the image on my website.  hopefully it will work with the video/keograms/startrails tonight.
Mike

Mike, are you running version 0.8?  If so, do you have a ZWO camera?  What are your "USB Bandwidth" and "Auto USB" settings?

I have a zwo 224 cameras
I have the Auto USB Bandwidth set to no
My USB Bandwidth is set to 40
not sure how to find what version I have.
my setup is a raspberry pi 3b+
pi@Pi-AllSky:~ $ cat /etc/debian_version
10.10
pi@Pi-AllSky:~ $ cat /etc/os-release
PRETTY_NAME="Raspbian GNU/Linux 10 (buster)"
NAME="Raspbian GNU/Linux"
VERSION_ID="10"
VERSION="10 (buster)"
VERSION_CODENAME=buster
ID=raspbian
ID_LIKE=debian
HOME_URL="http://www.raspbian.org/"
SUPPORT_URL="http://www.raspbian.org/RaspbianForums"
BUG_REPORT_URL="http://www.raspbian.org/RaspbianBugs"
pi@Pi-AllSky:~ $ uname -a
Linux Pi-AllSky 5.10.52-v7+ #1441 SMP Tue Aug 3 18:10:09 BST 2021 armv7l GNU/Linux

Mike,
The /var/log/allsky.log file will tell you if you're running AllSky 0.7 or 0.8.
I assume you aren't having problems capturing images?

I will look when I get home.
So far it is capturing an image during daylight.  It is 6 pm where I am and will check to see what it looks like when it is dark

Eric,
here is what the allsky.log file says.
Aug 15 13:39:44 Pi-AllSky allsky.sh[31149]: #033[32m *** Allsky Camera Software v0.8 | 2021 ***


MyHomePlanet

MyHomePlanet
A Tokenized Real Estate Investment Eco System for a new Generation of Investors.
We make Real Estate affordable for all.
https://myhomeplanet.io/
nft / marketplace / tokens

Closing this as a showcase has to have a running product. (no presale, no protected pages, no coming soon messages)


HTTPS and HTTP/2 support?

Hey Davide,
I just want to make sure I'm not missing anything. Currently HTTPS and HTTP/2 are not supported, right?
Best regards
Henning

Hey Henning,
The HTTP client of RestTestGen is just a simple OkHttp client, so it has all the features of OkHttp.
HTTPS is definitely supported! I used it successfully in the past. FYI, I set the OkHttp client to trust all certificates (including those not emitted by a recognized certification authority), as RestTestGen is often used in development contexts where certificates are self-signed. For further information about this, please see the constructor of the TestRunner class.

Oh, you are absolutely right. Maybe next time I'll try it before I ask :D
I just tested it on some API with HTTPS and HTTP/2 and RestTestGen works great!
Thanks

That's great. No worries. Get in touch anytime!


[FTR] Dockerize application

Description
Dockerized the app and added a docker-compose.yml file for easy deployment.
None of the .env variables are required, and the port is defaulted to 3000.  We'll need them when we implement incidents.
Updated the README.md file to better reflect our fork.
Testing
Run docker-compose up, go to localhost:305 in your browser.

Rename the docker-compose.yaml file to compose.yaml.


[BUG] chrom

Hello, can this component be independent of chrom

unfortunately that's not a mode that we support


Help request (Staubli TX60)

Hello,
I would like to ask for help with Staubli XT60, to add to the library. I modified the bartlett library and add the robot to xml, and 3d model, but can not fix to not falling apart, even if using the DH parameters.
May I ask you for add the robot correctly?
Here are the necessary files (3d model, xml, DH parameters): https://www.dropbox.com/sh/9ziq0qys1qapfl9/AAC4jETHgbto-r9fl0a2YIYma?dl=0
Thank you very mutch!

I think the problem is with the plugin itself?
TX60 is slightly special in that not all joints are on the XZ plane, I think this is what's causing problems.

I've also noticed that the plugin does not read the d value for Revolute number 2 and number 3, you can change it to some absurd vlaue like 5000 and there'd be no difference.
Will need Vicente or Vincent to confirm this tho, just pointing out my observations.

@v-xup6 Thanks for you observation. I saw this shift in design on other staubli robots and it is involved in xml. I think somewhere else is the problem, but I can't find it.

Hi, I recommend you get a view with dimensions like above for one of the existing Staubli robots in the Bartlett library, see what dimensions the numbers correspond to, and then replace them with the TX60 numbers of the same dimension.

I did this as you suggested and also calculated the DH parameters for the dimensions. As a result, the robot is much better assembled, but it always breaks down.  That's why I'm looking for your help.

Strange, you shouldn't be calculating any dimensions, just copying the exact number from the drawing.

i checked once again and seems the data is good in xml. Could you please take a look at it? Maybe can ask you to create a sample sketch in grasshopper with TX60 to test it out and send to me as a reference? It would help a lot.

Ok, I'll try to have a look in the evening. Just giving you a chance first, since it always feels better to figure out the issue on your own.

Thanks, I'll check one more time.

Did you manage to take a look at it?

Sorry but no success on my side. Could you manage to look at the files please?

@eduardsik  I had a look at this and @v-xup6  is correct, that offset is not supported in the kinematics used by Robots (the d value of the second axis is not used). I don't think I will have time to work on adding this anytime soon, but would be a great if anyone else is willing to try.

@eduardsik  I had a look at this and @v-xup6  is correct, that offset is not supported in the kinematics used by Robots (the d value of the second axis is not used). I don't think I will have time to work on adding this anytime soon, but would be a great if anyone else is willing to try.

I will close this issue, the conclusion being, not a supported feature yet.

I will close this issue, the conclusion being, not a supported feature yet.


Tf2 migration

WIP:
Starting migration to TensorFlow 2. Tested only for Cart-pole DQN.
Optimizer, loss, and DNN model are implemented in different classes and instantiated inside trainer class. Head and loss are separated.
The following UML class diagram provides a high level description

The only way I managed to stop sending alerts to Neta is by closing the PR


What analysis was done on the threats posed by a " Project Security Metrics"

We are introducing a prospective reference tool for customers/developers to refer to, in this sense, what kind of security threat/risk analysis are done on introducing such tool and providing a reference go-to place in to open-source landscape ?

Does this tool introduces new threats and increases customer compromise level ?
Does this tool introduces new type of attack vectors ?

I went through your documentation and meeting minutes, I did not see any such analysis for me to refer to and what type of counter measures or protections are put in place.
PS : My native mother tongue is not English, Please pardon my self if I misspoke some technical Jargons, I know when it comes to security people are peculiar about technological jargons. but I hope the message is received well, If not, Please comment on the ticket , I will try my best to clarify within my reach.

Hi @pjeyarat!
If I understand correctly, you're talking about whether this tool itself could be used as part of an attack (meaning, the tool, dashboard, etc.) might have a flaw where an attacker could insert some bad data in (either at a technical vulnerability level like XSS or a higher-level attack like manipulating certain projects to get a "good" or "bad" standing)? Like maybe if we weight the number of commits too high in the scoring mechanism, an attacker could create a lot of bogus commits that would elevate their project above others?
Or did you mean that creating such a tool would have others rely on it, and trust what it says -- and make decisions based on that trust -- and if we made a mistake and the customer was attacked as a result -- would they come back to us?
To address these, I think:

Technical Attacks: We need to test/validate that our code is secure generally.
Defend Against Manipulation: We need to be transparent about the criteria we use, especially for aggregations, and take feedback/input from the community. We should also specifically threat model this aspect of the system.
Mistakes and Trust: Transparency should go some way here, but this is also what separates this project from a "certification" body -- we're making no claims about whether a user should rely on X, but rather giving them information upon which to make such a decision. We could give them wrong information (a bug), but I think we can mitigate this by having multiple individuals be involved in the implementation.

I certainly welcome others' thoughts, too on this!

Dear @scovetta
In my opinion, before we embark on a tool associated to security we need to produce a "Threat/Vulnerability/Risk) assessment of  such Project introduction in to the public domain, For example a stake-holder based risk analysis should include;

Risk for customers
Risk for developers
Risk for the public
Risk for the Project Participants ( OSSF/Project-Security-Metrics) team
Risk for project enablers ( People who will supply data and tools to enable our Project-Security-Matrix eco-system, Linux Foundation / OSSF etc )

Additionally, We need to understand the type of attack vectors of our Project ( Here are some over the top of my head, this requires careful analysis) introduces,

Attacks using  the end product ( tool)  ( What you have mentioned in above as Technical Attack )
Attacks using the tool operational process ( Somewhat similar to what you have mentioned as manipulation )
Attacks using the tool policy ( Short term/ Long Term )
Attacks using the Trust of OSSF / Linux Foundation within the mind of general public/customers and developers

If we have already done this, Please point to the documentation which analyzes and concludes that " Project Security Metrics" is indeed a worthwhile endeavor to undertake upon.
Finally, we need to analyze that this Project does not violate the "Ethics", "Logic" or "Emotional" aspect of stake-holders and participants. If it does so, we need to improve the process to find a win-win situation to all parties associated to the eco-system.
Please guide me in the right direction If I have missed or under looked or over-looked any aspect on this,.
I welcome others and experts thoughts/inputs on this!

Hi @pjeyarat! I appreciate your thoughts here -- we don't have anything formally documented like this. Would you be interested in driving this effort to create such a document? I think it would be very useful.

Dear @scovetta ,
Thank you very much for your response and offer.  I am glad to take participate in such effort if We can collectively discuss and finalize such an effort.
If it sounds, worth endeavoring upon for yourself, We may be able to discuss this on our meeting and see whether we could collectively pen such a documentation.


Build and publish binary releases

Fixes #216

Other than that, the battle-tested shell-script lgtm


UI updates

These are just the UI updates that are implemented in the language translation PR. I think these UI updates are worthwhile, better credit for contributors and a better processing panel that doesn't cover up the window where the plots are. Also some nicer text in places and added tweets.

@zsteinmetz I think that the translation PR is going to take a few months at least to implement so I am hoping that for now, we can just review and merge the UI updates that are within it which I have separated here.

This contains all added components from #106 so that can be merged after this is or just deleted.

Sorry for the confusion, I meant to delete the app.R file, it was just a
concept I tested out. Use the ui.R and server.R files. Yeah I felt the same
way when I tried to open this up again after a few months, crazy how fast
we forget it. What kind of errors are you getting?
Cheers
Win
On Wed, Jan 12, 2022, 6:42 AM Zacharias Steinmetz @.***>
wrote:

@.**** commented on this pull request.
What was your reason for adding app.R and not keeping the UI and the
Shiny server separated in two R files? Which one is supposed to work? I get
errors for both. Sorry, I'm confused. Maybe it has been too long that I
worked with the code 🙈
—
Reply to this email directly, view it on GitHub
https://github.com/wincowgerDEV/OpenSpecy/pull/110#pullrequestreview-850573646,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AGMUJU6DWYQMFAENO7FZ773UVWHOHANCNFSM5LEATHCQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you authored the thread.Message ID:
@.***>

That's a relic, thanks for finding it!
On Thu, Jan 13, 2022, 3:18 AM Zacharias Steinmetz @.***>
wrote:

@.**** commented on this pull request.
In inst/shiny/server.R
https://github.com/wincowgerDEV/OpenSpecy/pull/110#discussion_r783864544
:

@@ -91,7 +111,8 @@ load_data <- function() {
server <- shinyServer(function(input, output, session) {
#For theming
#bs_themer()

observe_helpers()

What is the purpose of calling observe_helpers() here? It's part of the
shinyhelpers package not defined above. I commented out in my local repo
for now without missing any functionality. If it's not a relic but needed,
we should define the dependency properly.
—
Reply to this email directly, view it on GitHub
https://github.com/wincowgerDEV/OpenSpecy/pull/110#pullrequestreview-851578880,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AGMUJU73DPETNXQMIR2MBJ3UV2YJTANCNFSM5LEATHCQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you authored the thread.Message ID:
@.***>

YUP!
On Thu, Jan 13, 2022 at 5:58 AM Zacharias Steinmetz <
@.***> wrote:

@.**** commented on this pull request.
In inst/shiny/server.R
https://github.com/wincowgerDEV/OpenSpecy/pull/110#discussion_r783981635
:

Translate page ----

Also a relic, I suppose?
—
Reply to this email directly, view it on GitHub
https://github.com/wincowgerDEV/OpenSpecy/pull/110#pullrequestreview-851746485,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AGMUJUYBBC4PFLQQ6CWO4JTUV3LBPANCNFSM5LEATHCQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you authored the thread.Message ID:
@.***>

--
´¯·.¸¸.·´¯·.´¯·.¸¸.·´¯ツ ------------------------------
*Win Cowger, PhD *
Pronouns: he/him
Research Scientist
Moore Institute for Plastic Pollution Research
Contact Info
515-298-3869  | @.*** | @Win_OpenData
https://twitter.com/Win_OpenData
Websites
Personal Website: www.wincowger.com
Currently Employed: https://mooreplasticresearch.org/
Alumni Of: https://www.thegraylab.org/
Project Websites: www.openspecy.org
Research Gate: https://www.researchgate.net/profile/Win-Cowger
Github: https://github.com/wincowgerDEV
OSF: https://osf.io/kxeh5/

When I try to pull the update I get this error
error: cannot lock ref 'refs/remotes/origin/fix-offline-tests': Unable to create 'G:/My Drive/GrayLab/Projects/Plastics/ActiveProjects/OpenSpecy/Code/Github/.git/refs/remotes/origin/fix-offline-tests.lock': File exists.
Another git process seems to be running in this repository, e.g.
an editor opened by 'git commit'. Please make sure all processes
are terminated then try again. If it still fails, a git process
may have crashed in this repository earlier:
remove the file manually to continue.
From https://github.com/zsteinmetz/OpenSpecy
! [new branch]      fix-offline-tests -> origin/fix-offline-tests  (unable to update local ref)

I just made one more tiny UI fix to remove the UI panels for revolutionizing so that it is obvious what levels of support we have at first glance. I am good with your updates.

Two last things, sorryy:

I'm not so super pleased with the additional scrolling needed to view the support and Twitter panels. While I suggest to simply enlarge the support panels, we could randomly chose two or three tweets every time the page is loaded.
The "gear" icons are not displayed on my local machine anymore:

Have you experienced something similar?

I got the following error:
This Font Awesome icon ('gear') does not exist:
* if providing a custom `html_dependency` these `name` checks can
  be deactivated with `verify_fa = FALSE`

Exchanging 'gear' with 'cog' as recommended here made the error message go away but the UI still looks the same.

Yeah I agree that the new scrolling is a bit of a poor point. I wanted
something more like a right arrow click function to show the next item so
that the whole first tweet and the whole first support would be visible but
I couldn't get it to work. Any ideas? I'm not sure how removing a few of
the tweets would improve the scrolling but I'm down to give it a try.
I hadn't experienced the gear error but the cog alternative sounds good to
me.
On Fri, Jan 21, 2022, 3:38 AM Zacharias Steinmetz @.***>
wrote:

Two last things, sorryy:

I'm not so super pleased with the additional scrolling needed to
view the support and Twitter panels. While I suggest to simply enlarge the
support panels, we could randomly chose two or three tweets every time the
page is loaded.
The "gear" icons are not displayed on my local machine anymore:
[image: image]
https://user-images.githubusercontent.com/10266826/150520231-e0277de3-05d0-4991-8eb7-8de536c2eadc.png
Have you experienced something similar?

I got the following error:
This Font Awesome icon ('gear') does not exist:* if providing a custom html_dependency these name checks can
be deactivated with verify_fa = FALSE
Exchanging 'gear' with 'cog' as recommended here
https://github.com/jlab/FlowSoFineApp/issues/1 made the error message
go away but the UI still looks the same.
—
Reply to this email directly, view it on GitHub
https://github.com/wincowgerDEV/OpenSpecy/pull/110#issuecomment-1018429759,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AGMUJU4HVCIPK6PGWXDLJFLUXFASBANCNFSM5LEATHCQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you authored the thread.Message ID:
@.***>

What do you think about such a landing page?

What do you think about such a landing page?

Definitely better than the current one!

I hadn't experienced the gear error but the cog alternative sounds good to me.

Well done! Love it :)
On Wed, Feb 9, 2022 at 8:15 AM Aline Carvalho @.***>
wrote:

[image: image]
https://user-images.githubusercontent.com/10266826/153236706-c33cebed-3435-436a-a55d-a4978c6ec0c0.png
What do you think about such a landing page?
Definitely better than the current one!
—
Reply to this email directly, view it on GitHub
https://github.com/wincowgerDEV/OpenSpecy/pull/110#issuecomment-1033935226,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AGMUJUZGI7BFTEBXEODXO2LU2KHJRANCNFSM5LEATHCQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you authored the thread.Message ID:
@.***>

--
´¯·.¸¸.·´¯·.´¯·.¸¸.·´¯ツ ------------------------------
*Win Cowger, PhD *
Pronouns: he/him
Research Scientist
Moore Institute for Plastic Pollution Research
Contact Info
515-298-3869  | @.*** | @Win_OpenData
https://twitter.com/Win_OpenData
Websites
Personal Website: www.wincowger.com
Currently Employed: https://mooreplasticresearch.org/
Alumni Of: https://www.thegraylab.org/
Project Websites: www.openspecy.org
Research Gate: https://www.researchgate.net/profile/Win-Cowger
Github: https://github.com/wincowgerDEV
OSF: https://osf.io/kxeh5/

Yeah the top one is the one I intended to make it, that way people could
see what was active in the bottom window, open to alternative options
though.
On Wed, Feb 9, 2022 at 8:26 AM Zacharias Steinmetz @.***>
wrote:

I hadn't experienced the gear error but the cog alternative sounds good to
me.
Even when using "cog" instead of "gear", the toggles look like this on my
machine:
[image: image]
https://user-images.githubusercontent.com/10266826/153244077-b880ae66-4c05-40b9-9eaf-0d7707235f4c.png
Are they still supposed to look like this?
[image: image]
https://user-images.githubusercontent.com/10266826/153244266-8a8e9bfb-9f08-4a83-a3c1-53afca871a2c.png
—
Reply to this email directly, view it on GitHub
https://github.com/wincowgerDEV/OpenSpecy/pull/110#issuecomment-1033947795,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AGMUJU3KIQ4CNPXQJ3BPLYLU2KIUVANCNFSM5LEATHCQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you authored the thread.Message ID:
@.***>

--
´¯·.¸¸.·´¯·.´¯·.¸¸.·´¯ツ ------------------------------
*Win Cowger, PhD *
Pronouns: he/him
Research Scientist
Moore Institute for Plastic Pollution Research
Contact Info
515-298-3869  | @.*** | @Win_OpenData
https://twitter.com/Win_OpenData
Websites
Personal Website: www.wincowger.com
Currently Employed: https://mooreplasticresearch.org/
Alumni Of: https://www.thegraylab.org/
Project Websites: www.openspecy.org
Research Gate: https://www.researchgate.net/profile/Win-Cowger
Github: https://github.com/wincowgerDEV
OSF: https://osf.io/kxeh5/

And "adv" is short for "advanced options"? I'll try to give it a second thought. Maybe we can find something more intuitive.

Then, I'd opt for something like this:

@wincowgerDEV, should I squash and merge this commit?

BTW @zsteinmetz and @ardcarvalho I finally got Open Specy up on a more professional looking EC2 server, been spending the whole week on this. https://openanalysis.org/openspecy/
By having the tool on the server, we have more control over how we scale while more users jump on. Let me know what you think .

I finally got Open Specy up on a more professional looking EC2 server

Awesome :heart_eyes: it's lightning fast!! I like the gray color. I'll add it to main.

BTW @zsteinmetz and @ardcarvalho I finally got Open Specy up on a more professional looking EC2 server, been spending the whole week on this. https://openanalysis.org/openspecy/

This is amazing! And indeed, super fast.
Just the formatting that is lost in the mobile version (for both) and looking gets worse. Hard to configure this? (Imagining you've struggled with...)

Hey Aline,
Yeah, I have noticed that. I guess I figured that few people would want to
analyze spectra from their cell phone so I haven't gotten around to
formatting it in a way that would be compatible with the cell phone but it
is a good thing to think about if we end up getting some people who do want
to use their phone. I think the next version of Open Specy's UI will be
simpler and therefore easier for us to program in the conversion so it
might be a good idea to bring up with the UI team now.
Warm Regards
Win
On Sun, Feb 13, 2022 at 10:56 PM Aline Carvalho @.***>
wrote:

BTW @zsteinmetz https://github.com/zsteinmetz and @ardcarvalho
https://github.com/ardcarvalho I finally got Open Specy up on a more
professional looking EC2 server, been spending the whole week on this.
https://openanalysis.org/openspecy/
This is amazing! And indeed, super fast.
Just the formatting that is lost in the mobile version (for both) and
looking gets worse. Hard to configure this? (Imagining you've struggled
with...)
—
Reply to this email directly, view it on GitHub
https://github.com/wincowgerDEV/OpenSpecy/pull/110#issuecomment-1038717056,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AGMUJU67P3ATJC7K7VX6H5LU3CRSBANCNFSM5LEATHCQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you were mentioned.Message ID:
@.***>

--
´¯·.¸¸.·´¯·.´¯·.¸¸.·´¯ツ ------------------------------
*Win Cowger, PhD *
Pronouns: he/him
Research Scientist
Moore Institute for Plastic Pollution Research
Contact Info
515-298-3869  | @.*** | @Win_OpenData
https://twitter.com/Win_OpenData
Websites
Personal Website: www.wincowger.com
Currently Employed: https://mooreplasticresearch.org/
Alumni Of: https://www.thegraylab.org/
Project Websites: www.openspecy.org
Research Gate: https://www.researchgate.net/profile/Win-Cowger
Github: https://github.com/wincowgerDEV
OSF: https://osf.io/kxeh5/


Investigate why latest develop branch requires latest master branch to launch

Running the ./gradlew run task looks like it will launch the CDA server along with the Swagger page, but returns a 404 error The origin server did not find a current representation for the target resource or is not willing to disclose that one exists. when trying to access with the following in the log:
Tomcat listening at http://localhost:7000/

Feb 28, 2023 2:04:03 PM [org.apache.catalina.authenticator.AuthenticatorBase](https://org.apache.catalina.authenticator.authenticatorbase/) invoke

FINE: Security checking request GET /swt-data/swagger-ui.html

Feb 28, 2023 2:04:03 PM [org.apache.catalina.realm.RealmBase](https://org.apache.catalina.realm.realmbase/) findSecurityConstraints

FINE: No applicable constraints defined

Feb 28, 2023 2:04:03 PM [org.apache.catalina.authenticator.jaspic.AuthConfigFactoryImpl](https://org.apache.catalina.authenticator.jaspic.authconfigfactoryimpl/) loadPersistentRegistrations

FINE: Loading persistent provider registrations from [J:\Workspaces\git\cwms-radar-api\cwms_radar_api\build\tomcat\conf\jaspic-providers.xml]

Feb 28, 2023 2:04:03 PM [org.apache.catalina.authenticator.AuthenticatorBase](https://org.apache.catalina.authenticator.authenticatorbase/) invoke

FINE: Not subject to any constraint

The updates to authentication theoretically should allow the read access to still work.

Couple of things I've noticed: the cwms_radar_api/src/main/webapp/WEB-INF/web.xml file looks to have a bad merge resolve
Additionally, swagger comes up just fine at commit hash f125cd, but then fails by commit f50e7d. I wasn't able to get commits in between to compile due to compiler errors, but I didn't check them all.

I made #323 to remove the bad merge resolve.

Looks fixed from tomcat war deploy as well as the gradle run task


Pass key to transformer function

Passes S3 key to transformer function.
Updates tests

My use case : I need to decrypt and decompress in the transformer function and my decryption key is derived from the filename.

This change is

nice, looks good to me 👍


Added missing query param and updated status enums

ARM (Control Plane) API Specification Update Pull Request
PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

Purpose of this PR
What's the purpose of this PR? Check all that apply. This is mandatory!

[ ] New API version. (Such PR should have been generated with OpenAPI Hub, per this wiki doc.)
[ ] Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
[ ] Update existing version to fix swagger quality issues in S360.
[x] Other, please clarify:

The Resource Bridge swagger definition was missing a query param on the listkeys route, which is fixed with this PR
And also updated the set of statuses to be updated.

Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

[ ] I have reviewed the general guidance on the spec PR review process: https://aka.ms/specprreview.
[ ] I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data-plane related specifications.
[ ] I commit to follow the Breaking Change Policy.
[ ] I have reviewed following Resource Provider guidelines, including
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can request review from an ARM API Review board.

ARM API changes review

If you want for the ARM team to review this PR, you must add the ARMReview label.
The automation may automatically add the ARMReview label, if appropriate.
If this happens, proceed according to guidance given in GitHub comments also added by the automation.

Breaking change review
If you have any breaking changes as defined in the Breaking Change Policy,
follow the process outlined in the High-level Breaking Change Process doc.
Getting help

For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
and https://aka.ms/ci-fix.
For additional help, see https://aka.ms/azsdk/support/spectools.

azp /run

azp /run

/azp run

/azp run

/azp run

/pr requestMerge

/azp run


Added unit test for length properties of constant arrays.

Isn't it bad practice to leave the print in? I was going to remove that.


Use variables in requests.

A frequent use case when testing a REST API is having a request path containing variable values, like a resource ID. This PR adds the possibility to include scenario variables and/or global variables in request paths. The variable names must be enclosed in backticks. By example:
/users/`userId`/files/`fileId`
You can mix global and scenario variables in the same path. Scenario variable will shadow global variable with the same name.

Hi @PascalLeMerrer,
Thanks for this.
We didn't want to allow the use of Global Variables, as BDD promotes independent scenarios. If you get time, please review PR 58 and let me know what you think. I have also resolved the merge conflicts in this PR.
Thanks, Sean

Closed by #58


scan-selector: enable DATA_MATRIX

The 2D barcodes from Grocy are data matrix.
I haven't built and tested this: I don't know how :(. But I'd love to know how so that I can!

The easiest way to test it is to load the custom build on your phone. If you can't do that I'll try and get it tested. Do you have an example barcode you want it to scan?

These are all different sizes of the same barcode:

I don't think I can build and install it since I don't have a mac, I don't suppose it is possible for you to do that, sending me the app using Testflight or something?

I've tested this and it will scan the barcode, however the value is grcy:p:4:6186fc9bf095b
Testing the barcode's on the grocy demo site shows this is correct. I'll go ahead a merge this, but I need to fix a couple other bugs while i'm at it.


Output of one Piano cover is a MIDI with 62 instruments in MuseScore

Hi, I input a cover of a piano song into the Python library, and opened the resulting MIDI file in MuseScore. This was the result:

Essentially, there were a few notes played by 62 different pianos, despite the original performance being played on 1.
Is this expected behaviour from basic-pitch? Is it because I don't have the CUDA dependencies? Installed CUDA and cuDNN.
If it is expected behaviour, I'm looking for some angles to attack this problem from on the MuseScore side and the Basic-Pitch side.
Any help would be appreciated.

Tried all of the following, unsuccessfully:

Merging with Tools->Implode in Musescore (Does nothing): https://musescore.org/en/node/332630
This Python script: https://github.com/m13253/midi-track-merge (Converted to 16 tracks, still not what I wanted, repeated uses leads to errors)
Miditocsv, edit first column, csvtomidi: https://www.fourmilab.ch/webtools/midicsv (Didn't change anything, strangely)
My own script to turn Basic Pitch's csv into a MIDI. Sounds decent, but timing is obviously off and I'm not sure how to calculate the proper time in beats from the given time in seconds. https://streamable.com/vkmahx
This library and this code (does nothing)

I ended up getting to merge by modifying mido, the package behind pretty midi - still didn't look pretty, but it was on one track at least.
import os
import mido

mid = mido.MidiFile(os.path.join("outputs", "bakamitai_basic_pitch.mid"))
merged_track = mido.merge_tracks(mid.tracks)
new_midi= mido.MidiFile()
new_midi.tracks=[merged_track]
new_midi.save("merged.mid")

mido/midifiles/tracks.py:
`def _to_abstime(messages):
"""Convert messages to absolute time."""
now = 0
for msg in messages:
now += msg.time
try:
msg.channel = 1
except:
pass
yield msg.copy(time=now)
The remaining problem is that MIDI -> sheet music has not come far enough yet.

Hi, I just tried using main (no master branch). I downloaded the zip, unzipped it, and then called my venv/Scripts/python setup.py install to install it. The output is still the same. The version number also still seems to be 0.0.1. Am I doing anything wrong?

Thanks for this information and update and everyone's work on basic pitch. I had come to ask about the same topic and found this thread.  Your web based version at spotify produced a very accurate sounding single track, while the command line version split the same audio sample out to about 30 tracks. I manually combined all those in to one within my daw, but the result didn't sound as accurate as the web based tool . I considered trying the repository, but in reading kevinglinxc's last message, I think I'll just look forward to the next version on PyPi if it will be coming soon.

I tried installing directly from GitHub and I'm facing the same issue. Dragging and dropping the MIDI file into Ableton Live creates a lot of MIDI tracks. MIDI output of the webapp only creates one track.

This eve I took a look at the repository diffs and pulled down the latest versions of inference, note_creation, and predict. I directly replaced those files in my module folder and now I'm now generating the same single track midi files that the webtool was providing. yay

@Misfire2 I followed your method, but I'm still getting multiple tracks in the output MIDI. I diffed the files and they're the same as the ones in the repo. Can you please share your command/function call?
I noticed something just now. If I run basic-pitch via the terminal with command basic-pitch output_folder input.wav, I get a MIDI file with a single track. However, if I call the predict_and_save function in a python script, I get a MIDI file back with multiple tracks. I compared the arguments and they are the same and mostly just the defaults. Any clue?

I'm working from a windows box and have only been using the command line option ...
/>basic-pitch output-folder input-file .  From the start, even command line was giving me multiple tracks.
Once I replaced the 3 files, command line produced just the single track.
My setup might be slightly different than your because I originally installed the package from https://pypi.org/project/basic-pitch/    I didn't use the entire repository version, I only replace those 3 files while leaving the rest of the  pypi package in place.  I'm just a C++ guy and haven't delved deeper in to the code since I was getting the basic function I needed from command line.

Just a quick update - we've updated the version on pypi, and starting from version 0.1.0 this problem should be solved.


fix: liveness probes airflow 2.6.0 support

What issues does your PR fix?

fixes #737

What does your PR do?
This PR updates the liveness probes for the scheduler and triggerer so they are compatible with Airflow 2.6.0. Not sure how best to deal with backwards compatibility though so this PR still requires some work. I assume there are some ways backwards compatibility with airflow versions that already exist, so if those can be recommended I can update this PR.
Checklist
For all Pull Requests

[x] Commits are signed off
[x] Commits have semantic messages
[ ] Documentation updated
[ ] Passes ct linting

For releasing ONLY

[ ] Chart.yaml version bumped
[ ] CHANGELOG.md updated

Is there a plan to merge this pull request?

@DavidSpek @wikitops I agree we need to get this fixed, but I am not sure explicitly checking the version of airflow in the code is the best way.
Perhaps a simple approach might be just to wrap try/except around the import, and possibly exit with NO error if we can't import either one (so if it changes again in the future, the probes don't completely break the user's deployment).

Is there a reason why the /health probing endpoint isn't being used? It would also be possible to inspect the JSON that is returned from that endpoint for more advanced probing. I agree that the implementation is a bit clunky and I don't like checking the version in the code, I just needed a quick fix initially.

@DavidSpek regarding the /health probe, what could we additionally do with it?

@thesuperzapper The health endpoint seems to be doing most of the same things as the current probe, but exposes it as an http endpoint on the component. https://github.com/apache/airflow/blob/86d62d3c0398d0d842c9368c5832de92bc6ec4c5/airflow/utils/scheduler_health.py#L31 is an example for this, and it's the code I used to base this PR around. I don't think that endpoint covers the full capabilities of the current probe though, like task creation. I'm also not sure when the endpoint was introduced so there might be an issue with backwards compatibility to certain Airflow versions of the chart were to start using it. However, since using the endpoint would solve forwards compatibility it could be worth considering.

I am using the same /health endpoint within my org, thought of implementing the same for upstream https://github.com/airflow-helm/charts/pull/742
PTAL

This is a wrong fix. Look at the airlfow -community managed chart. We've changed long time ago the liveness probes to depart from Hard-coded ways of checking it and runnning airflow jobs check command. You should do the same here.
The details (including the data models and code used to run the health checl) should not be present in the health check. They can and will change as new versions of airflow will be released and changing it in this way makes completely no sense, because it will likely break for 2.7 and beyond.
See this for an example how it should be done: https://github.com/apache/airflow/blob/main/chart/templates/_helpers.yaml#L649

@potiuk @chattarajoy I am aware of the airflow jobs check feature (and the /health endpoint), but there are two problems that prevent the user-community chart from adopting it exclusively for our health checks:

We aim to support all versions of airflow, and airflow jobs check was only added recently. I note that you also have a similar version-based if/else condition in the upstream chart.
We have an optional feature called "task creation check", which is more advanced than checking the airflow-provided SchedulerJob, and checks for actual tasks being scheduled (which is needed for some older airflow versions which are subject to deadlocks in their scheduler, preventing SchedulerJob from reflecting the true state of the scheduler).

Given this, I think my initial patch to get airflow 2.6.0 working properly will be what I suggested in https://github.com/airflow-helm/charts/pull/738#issuecomment-1542848354, that is, a try/except block to detect which of SchedulerJob or SchedulerJobRunner is available.
To be clear, I don't see it as a problem if the chart needs a patch release for new versions of airflow (but I would obviously appreciate airflow not breaking/renaming APIs if not truly needed). Also, we have a support matrix for airflow version <-> chart version which helps users know when its safe to upgrade to new airflow versions.

Closing in preference of https://github.com/airflow-helm/charts/pull/743

but I would obviously appreciate airflow not breaking/renaming APIs if not truly needed

Airflow has (as of 2.6.0) very detailed list of what is considered a public interface and what is not: https://airflow.apache.org/docs/apache-airflow/stable/public-airflow-interface.html
And it has this very clear explanation of what is not a public API. You are now explicitly using somethig that Airflow specifically explained as something that is not a public API and explained that it is and will be changing in the future:

What is not part of the Public Interface of Apache Airflow?
Everything not mentioned in this document should be considered as non-Public Interface.

Sometimes in other applications those components could be relied on to keep backwards compatibility, but in Airflow they are not parts of the Public Interface and might change any time:

Database structure is considered to be an internal implementation detail and you should not assume the structure is going to be maintained in a backwards-compatible way.

Web UI is continuously evolving and there are no backwards compatibility guarantees on HTML elements.

Python classes except those explicitly mentioned in this document, are considered an internal implementation detail and you should not assume they will be maintained in a backwards-compatible way.

@potiuk my main request is that changes to long-standing DB structures are treated as "soft breaking", so only happen in major or minor releases (e.g. 2.6.X -> 2.7.0), because I am not the only one using them.
For example, many users have plugins (like custom UI's and monitoring systems) that make various queries to the database.
I don't think it's a huge inconvenience for the Airflow project to limit DB structure changes to minor versions, and it also limits the blast radius when these changes cause issues in airflow itself (like https://github.com/apache/airflow/pull/30302), as people are more careful about upgrading to major/minor releases.

I don't think it's a huge inconvenience for the Airflow project to limit DB structure changes to minor versions, and it also limits the blast radius when these changes cause issues in airflow itself (like https://github.com/apache/airflow/pull/30302), as people are more careful about upgrading to major/minor releases.

It is huge inconvenience and we all agreed that DB structure is an implementation detail and we communicate it clearly now. Don't realy, nor use it. There is a comprehensive API that can be used instead  (and it was introduced almost 3 years ago precisely for the purpose that you can use it). This was actually the purpose of the API introduced then and it was clearly stated that this is teh "maintained" and stable way of accessing Airflow from outside.
There is absolutely no difference in which version - minor or patchlevel - it is going to change. We had cases where we had to change structure in patchlevel versions already (and we will likely have to do it again).
Simply Don't rely on it being unchanged. You've been warned. It's very clearly stated now, while before it has been implicit.
And it's not discussion with me to have. It should be a discussion on a devlist if you want to change the current approach.

@potiuk my main request is that changes to long-standing DB structures are treated as "soft breaking", so only happen in major or minor releases (e.g. 2.6.X -> 2.7.0), because I am not the only one using them.

And in case you have not noticed, yes. We want everyone using them to stop doing so.


always cleanup nginx locations on start

when threebot start it needs to clear all locations
keep letsencrypt location on website 80 (or regenerate it no problem)

steps:

Start any threebot package as an example j.threebot.package.calendar.start()
Change the package default names as an example change "calendar" to "xyz" in sandbox/code/github/threefoldtech/jumpscaleX_threebot/ThreeBotPackages/threebot/calendar/package.py
Stop the running pakcage.
Start it again
check that ls /sandbox/cfg/nginx/default_openresty_threebot/servers/website_443_locations/ doesnt have calendar but xyz config file.


Detect and Refactor Duplicates (via Extract Method)

Currently, I can use the "Extract Method" to take a section of code, and wrap it in a function. I should be able to detect duplicated sections of code, and easily extract them into a single common function. The duplication detection should include configurations to detect similar sections, even if minor differences exist, such as comments or different variable names. The minimum number of lines should be adjustable. These configurations should be settable via UX elements so that a developer can examine different combinations of settings quickly. I might, for example, first  want to search for duplicates that are 8 lines long, but ignore comments and variable names; and then do a different search of 3 lines but only exact matches.

Visual Studio has a feature called "Code Clone" that might be interesting to look at should we decide to do this.
https://visualstudiomagazine.com/articles/2011/11/17/visual-studio-11-code-clone-analysis.aspx


Repository connection is broken when setting up Amplify App via CloudFormation

Hi there, we're creating an Amplify App using the following CloudFormation Snippet
The app is created just fine, but then when we deploy, we get this error message
We follow the instructions to re-connect the repository and then deploy and get the same error message

Thanks for jumping on this. I saw via another bug that the Role needs Admin privileges changing resource: amplify:* to * did the trick


Neaten playground output with --line-directive-mode none

the #line preprocessor directives are just noise in the human readable output

it is used to control the line numbers and filenames reported by the compiler in error messages and debugging information. This can be particularly useful in scenarios where code is generated by tools or macros, as it allows the compiler to refer back to the original source file and line number, making it easier to trace errors back to their source.
Aren't they useful?


Keep multiple infoWindows always visible

Hey,
I was thinking if its possible to keep multiple infoWindows visible at the same time and not let them disappear once you click somewhere else.
My case is that I would need to populate the marker with some dynamically loaded content  (it's not possible to do so with marker, as far as am concerned) and then style it accordingly.
Ultimately, I want to hide marker icons and just display their infoWindows.
Is it possible, by any chance?
##EDIT
Would it be possible to provide html as icon for a marker?
Greetings

Since Google Maps Android API v2 and Google Maps SDK for iOS do not provide the multiple infoWindows, this plugin can not do also.
And html is not available in infoWindow since the native map sdks do not support it.


Translate reference/scheduling/config.md into Korean

This is a Feature Request

What would you like to be added

Translate reference/scheduling/config.md into Korean.
Why is this needed
There is no document of docs/reference/scheduling/config.md which is translated into Korean.
Comments

Page to translate: https://kubernetes.io/docs/reference/scheduling/config/
/language ko

/assign

/triage accepted


Fix issue #1030

Parse a four character hex string (like #48F) as a 7 character one
(#4488FF)

@mucaho or @starwed could this be merged? It will change the original specs however (see Diff on test file). This fixes #1030


[Service Bus] Cancel a message in a queue by sequenceNumber

Is your feature request related to a problem? Please describe.
Hello,
My current work using Service Bus is to provide a producer/consumer scheme by scheduling works for a set of workers.
When an user schedule a work, a message is directly published in a queue.
Since workers can take some time to be available, an user can be frustated and may want to cancel its current work.
Describe the solution you'd like
As currently available with scheduledMessages, I would like to have the same function as cancelScheduledMessages for messages already available in queue.
Currently it relies on "receiveMessages" and "abandonMessage", but it increases the number of "delivered". It should not on this use-case.
Describe alternatives you've considered
To do so, I would like to be able to cancel(), or complete() a message by its sequenceNumber.
Example:
    const sbClient = new ServiceBusClient(AZURE_SERVICEBUS_CONNECTION_STRING, sbOptions);
    const queueReceiver = sbClient.createReceiver(queueName, { receiveMode: 'peekLock' });
    const queueSender = sbClient.createSender(queueName);
    try {
        let canceled = false;
        for (const message of await queueReceiver.peekMessages(1000)) {
            const { shouldBeCanceled } = message.body;
            if (shouldBeCanceled && message.sequenceNumber) {
                await queueReceiver.cancelMessages(message.sequenceNumber);
                /* or: await queueSender.cancelMessages(message.sequenceNumber); */
                canceled = true;
            }
        }
        return { canceled, message: canceled ? 'Message deleted' : 'Message does not exist' };

    }
    catch (err: unknown) {
        if (isError(err)) {
            return { canceled: false, message: 'Error while deleting message: ' + err.message };
        }
        return { canceled: false };
    } finally {
        await queueReceiver.close();
        await queueSender.close();
        await sbClient.close();
    }

Additional context
Add any other context or screenshots about the feature request here.

@YHAMSTM thank you for submitting this issue!  To clarify, you would like remove/delete a message from the queue by its sequence number? This operation isn't supported by the Azure Service Bus service today but I will forward this feedback to the service team for consideration.

Hi @jeremymeng
Yes, exactly. I would like to have the ability to receive, complete or cancel a message by its sequence number.
Since my current way to "cancel" is by receiving a batch of messages in queue (with peekLock), complete the message I want to cancel and abandon messages I want to let in queue. With this, raising "maxDeliveryCount" is mandatory...

@YHAMSTM the service team has planned features that may enable this scenario. But we don't have any ETA on when this will be available.

Great news!


Merge in CBIO commits

May need to sync with CBIO commits on a branch to resolve potential conflicts

May be addressed in the H3ABioNet hackathon...

Currently being worked on:
https://github.com/h3abionet/16S-rDNA-dada2-pipeline/tree/merge-HPCBio_master

Closing out, this is happening on the branch in the primary repo. We can add issues there.