Impossible to disable http2

ISSUE TYPE

Bug Report

Checklist

[ ] .env file is attached
[ ] ./check-config.sh output is added below
[ ] docker-compose logs output is added below
[ ] docker-compose.override.yml is attached (if exists)
[ ] Custom configs from cfg/ dir are attached (if exist)
[x] I've looked through the docs: https://devilbox.readthedocs.io/en/latest/
[x] I've looked through existing issues: https://github.com/cytopia/devilbox/issues
[x] I've read troubleshooting: https://devilbox.readthedocs.io/en/latest/support/troubleshooting.html

OS / ENVIRONMENT

Host operating system and version: Ubuntu 20.04.3 LTS (Focal Fossa)
(Windows only) Native Docker or Docker Toolbox:
Docker version: Docker version 20.10.9, build c2ea9bc
Docker Compose version: docker-compose version 1.26.2, build eefe0d31
(Linux) Is SELinux enabled?: no
What git commit hash are you on?: f6bbdc72 (HEAD -> master, tag: v1.9.2, origin/master, origin/HEAD) Merge pull request #814 from cytopia/release/v1.9.2

SUMMARY

I start having HTTP2 connection errors. In Firefox I just don't seem to get anything back, while Chrome shows HTTP2 connection error.
The error log doesn't show anything while the access log shows a normal request with a 2xx or 3xx status.
Disabling http2 in nginx-stable solves the issue.
STEPS TO REPRODUCE

Not sure how to reproduce the http2 connection issue.
However, to be able to disable http2 I would have thought, it's enough to create a nginx.yml file under cfg/vhost-gen. However, that does not seem to help.
EXPECTED BEHAVIOUR

Either, http2 should be working, or able to be disabled.
ACTUAL BEHAVIOUR

http2 needs to be disabled by entering the http container, editing the following files setting http2: False (under ssl):

/etc/vhost-gen/mass.yml
/etc/vhost-gen/conf.yml
/etc/vhost-gen/main.yml

Obviously this change is not permanent and needs to be redone after docker-compose down.
OTHER INFORMATION
Seems to be related to

https://github.com/cytopia/devilbox/issues/431
https://github.com/devilbox/vhost-gen/pull/33

Having created a file ~/devilbox/cfg/vhost-gen/nginx.yml with setting the http2 to False seem not to have helped (as either http2 is active for all vhosts on one address/port or disabled for all of them):
# Generic vhost generator configuration file.
# Location: /etc/vhost-gen/mass.yml
#
# See: https://github.com/devilbox/vhost-gen
#
# If not specified or file is missing the following
# default values will be merged to your current (if any)
# configuration:
#
# server: nginx
# conf_dir: /etc/nginx/conf.d
# custom:
# vhost:
#   port:
#   name:
#     prefix:
#     suffix:
#   docroot:
#     suffix:
#   log:
#     access:
#       prefix:
#       stdout: no
#     error:
#       prefix:
#       stderr: no
#     dir:
#       create: no
#       path: /var/log/nginx
#   listen:
#     enable: no
#   php_fpm:
#     enable: no
#     address: php
#     port: 9000
#   alias: []
#   deny: []
#   server_status:
#     enable: no
#     alias: /server-status

# The server type determines which template
# from etc/templates/ will be chosen.
# Allowed server types:
# server: apache22
# server: apache24
# server: nginx
server: nginx

# Where to store the generated configuration files.
# This must be a directory the web server will read
# configuration files from.
conf_dir: /etc/httpd/vhost.d

# Custom directive
# Everything specified here will be directly replaced
# into the corresponding vhost directive:
#   nginx:  server { HERE }
#   apache: <VirtualHost *:80> HERE </VirtualHost>
#
# How to add multiline strings?
#
# custom: |
#   custom statement 1
#   custom statement 2
custom:

# Vhost definition
vhost:
  # What port should this virtual host listen on
  port: 80
  ssl_port: 443

  # The virtual host name is specified as an command line argument
  # to vhost-gen via '-n', however it is possible
  # to prepend and/or append additional name strings.
  name:
    prefix:
    suffix: .local
  # The document root directory is specified as an command line argument
  # to vhost-gen via '-p', however it is possible
  # to prepend another subdirectory here.
  docroot:
    suffix: htdocs
  # Array of indecies to serve as default files (e.g.: index.php, index.html, etc)
  index:
    - index.php
    - index.html
    - index.htm
  # SSL Definition
  ssl:
    http2: False
    dir_crt: /etc/httpd/cert/mass
    dir_key: /etc/httpd/cert/mass
    protocols: 'TLSv1 TLSv1.1 TLSv1.2'
    honor_cipher_order: 'on'
    ciphers: 'HIGH:!aNULL:!MD5'

  # Log definition
  log:
    # Log file settings (error/access log)
    access:
      # By default the vhost name is used for log file names.
      # You can also prepand an additional string to the access log
      # as shown here:
      # <prefix><vhost>-access.log
      prefix: ''
      # For use inside a docker container, enable this in order
      # to redirect the access log to stdout instead of to file.
      # NOTE: When enabling this, the prefix will have no effect and the access
      # log will be stored under /tmp/www-access.log which will be a symlink of
      # /dev/stdout
      stdout: no
    error:
      # By default the vhost name is used for log file names.
      # You can also prepand an additional string to the error log
      # as shown here:
      # <prefix><vhost>-error.log
      prefix: ''
      # For use inside a docker container, enable this in order
      # to redirect the error log to stderr instead of to file.
      # NOTE: When enabling this, the prefix will have no effect and the error
      # log will be stored under /tmp/www-error.log which will be a symlink of
      # /dev/stderr
      stderr: no
    # Directory to store log files in.
    # Also define if the directory should be created or not.
    dir:
      create: yes
      path: /var/log/nginx-stable
  # Enable PHP-FPM
  php_fpm:
    enable: yes
    # Hostname or IP address
    address: <IP_ADDRESS>
    port: 9000
    # Timeout to upstream FPM service
    timeout: 36600
  # Create additional aliases
  alias:
    - alias: /devilbox-api/
      path: /var/www/default/api
      # Allow cross-domain-request to this alias from the hosts/origin
      # specified by the below defined regex
      xdomain_request:
        enable: yes
        origin: 'http(s)?://(.*)$'
  # Denies locations
  deny:
    - alias: '/\.git'
    - alias: '/\.ht.*'
  # Enable server status on the following alias
  server_status:
    enable: no
    alias: /httpd-status

Happy to provide further details or information.

@bhujagendra-ishaya Fixed here: https://github.com/cytopia/devilbox/releases/tag/v1.11.0 via https://github.com/cytopia/devilbox/pull/871

Awesome, thank you @cytopia. Works perfectly


Right-justify backslashes according to style(9)

From style(9):

Right-justify the backslashes, as the resulting definition is easier to
read.

Looks good to me!

Thanks, merged as cb2eb4c.


Handle empty-input for number arguments

Given
{
  "additionalProperties": false,
  "properties": {
    "sleep_time": {
      "description": "Interval to sleep, in seconds.",
      "title": "Sleep Time",
      "type": "integer"
    }
  },
  "required": [],
  "title": "DummyParallel",
  "type": "object"
}

An optional number parameter sleep_time (with no default).
No explicit setting of sleep_time via `args.
Upon the first GET, fractal-web receives args with no sleep_time in there.
Input field in the form is empty, and user can write in there.
User sets sleep_time=123, and saves.
PATCH sends args={"sleep_time":123}
New GET will give back args={"sleep_time":123}
Input field in the form shows 123, and user can modify it
User deletes 123 (EXPECTED BEHAVIOR: this sets sleep_time=null)
User saves, and fractal-web (A) remove null values (including sleep_time), (B) successfully validates with AJV, (c) make PATCH call.

To-do:

[x] Verify the expected behavior described in point 9.

Already checked and tested.
Closing


persistent failure of atomic kv operations until docker is restarted

Frequently, I get errors of the following form on container start which persist until docker is restarted.
docker start e834638cd1db -- Error response from daemon: Cannot start container e834638cd1dbbc60209a772c385d5f15d8a86b8d12a96e04d077e52869555b0c: Unable to complete atomic operation, key modified

Other docker hosts which use the same consul instance as a kv store for libnetwork do not have this issue and consul continues to operate normally.

@alfredr It has been detected that this issue has not received any activity in over 6 months. Can you please let us know if it is still relevant:

For a bug: do you still experience the issue with the latest version?
For a feature request: was your request appropriately answered in a later version?

Thank you!
This issue will be automatically closed in 1 week unless it is commented on.
For more information please refer to https://github.com/docker/libnetwork/issues/1926

had the same issue right now with Docker version 17.10.0-ce, build f4ffd25.
service docker restart helped. :+1:
But I guess unresolved issue.

@fcrisciani they are not related. Lets track it with moby issues.

@abhi the description is actually fitting perfectly the same behavior that I saw, but it's ok to track it on moby, maybe you can post here the reference issue to have a link.

@fcrisciani i opened https://github.com/moby/moby/issues/35310 to track this. This is unrelated to the IPAM changes. But the endpoint_cnt states are messed up due to the lb-endpoint management.

@mavenugo sure no prob, agree to keep only one place to track, I previously reopened this one because was generic enough to track the error message experienced.


More from (user) caching issue in new public map page II

Closes #3408

@javisantana CR please :trollface:

:es:

Frontend tests were OK :+1: (details)

Frontend tests were OK :+1: (details)

Frontend tests were OK :+1: (details)

Frontend tests were OK :+1: (details)


Thames-Coromandel District Councils (TCDC), New Zealand

https://services5.arcgis.com/MYtLmLEStmKgdmln/arcgis/rest/services/Property_Information/FeatureServer/0

duplicate of #3842


ADR: Remove Attribute Value Members from Policy and instead house Value groupings in configuration of PDPs

Background
Members were a legacy artifact of the OpenTDF Platform v1 (this is v2) and were kind of a virtualization of attribute values. Some of the following were revealed with the refactor of policy:

Value members seemed to only apply to anyOf rule attributes, where values were groupings of other values

https://demo.com/attr/association/value/group_c which has as members the values group_a and group_b
hierarchy and allOf rules don't really make sense for this grouping

It was additional burden placed on platform admins to understand entitlement policy around members, with some significant questions

are members always anyOf within themselves?
how is entitlement resolved if an admin has Subject Mappings pointing directly to a value with members? Is this behavior that should be explicitly prevented?
how is entitlement resolved if an attribute value with members adds members of another attribute definition?

Tagging PDP and other PDPs can separately hold configured groupings of values as it makes sense contextually to roll up values appropriately outside of policy decisioning logic

Therefore, the decision was reached to Remove Attribute Value Members from Policy and instead house Value groupings in configuration of PDPs
The benefits are:

simplified administrative burden when there is only one way to entitle (subject mappings)
reduction of policy complexity
PDP-specific configuration flexibility without solving every PDP's contextual needs with a one-size-fits-all solution
greater unity across definition types (since members only seemed to have use cases within anyOf rule attribute definitions)

By 2 cents:

Members are currently used by Tagging PDP for computing rollup data policy
I also think decision logic should be using these member values as part of the decision.  If a data policy with data attribute "someattr" is requested and its attribute definition includes members ["someotherattr"] and requesting entity has "someotherattr" as an entitlement then access should be granted.
The use of subject mappings to directly entitling attribute values that have members should really not be used except for special cases (if ever?)

Does the above align with the architecture direction of the platform as you both see it @jrschumacher @ttschampel ?


Update init sequence

Updates to AD469x and AD4170 projects

@ribdp - does this PR look good to go?


Refactor project to a final name

The following are the candidate names:

Moneta
Quanti
Tanti
CoinX
Denaro
Solido
Tiny
Centi
Bold
CoinZ

Have to change all internals for 0.18 and master to moneta

work is completed


Converting tensor2tensor transformer to tf-lite graph

I am trying to convert the frozen transformer model from tensor2tensor to a tf-lite graph:
$ tflite_convert --output_file=/tmp/tf-lite/mdl --graph_def_file=frozen.pb --input_arrays=wave_input --output_arrays=outputs

I am getting the following error
Traceback (most recent call last):
  File "/home/sfalk/miniconda3/envs/t2t/bin/tflite_convert", line 11, in <module>
    sys.exit(main())
  File "/home/sfalk/miniconda3/envs/t2t/lib/python3.5/site-packages/tensorflow/contrib/lite/python/tflite_convert.py", line 412, in main
    app.run(main=run_main, argv=sys.argv[:1])
  File "/home/sfalk/miniconda3/envs/t2t/lib/python3.5/site-packages/tensorflow/python/platform/app.py", line 125, in run
    _sys.exit(main(argv))
  File "/home/sfalk/miniconda3/envs/t2t/lib/python3.5/site-packages/tensorflow/contrib/lite/python/tflite_convert.py", line 408, in run_main
    _convert_model(tflite_flags)
  File "/home/sfalk/miniconda3/envs/t2t/lib/python3.5/site-packages/tensorflow/contrib/lite/python/tflite_convert.py", line 162, in _convert_model
    output_data = converter.convert()
  File "/home/sfalk/miniconda3/envs/t2t/lib/python3.5/site-packages/tensorflow/contrib/lite/python/lite.py", line 453, in convert
    **converter_kwargs)
  File "/home/sfalk/miniconda3/envs/t2t/lib/python3.5/site-packages/tensorflow/contrib/lite/python/convert.py", line 342, in toco_convert_impl
    input_data.SerializeToString())
  File "/home/sfalk/miniconda3/envs/t2t/lib/python3.5/site-packages/tensorflow/contrib/lite/python/convert.py", line 135, in toco_convert_protos
    (stdout, stderr))
RuntimeError: TOCO failed see console for info.

I would seem that there are a lot of unsupported operations - does this cause the error?
The last line from the tflite_convert output says

F tensorflow/contrib/lite/toco/tooling_util.cc:968] Check failed: array->has_shape()

I don't know if anybody can make sense out of that ...
Is it possible to fix this or is there simply no way to convert this graph at this point in time?
  Also, provide details on the template. thanks!

@jvishnuvardhan I've installed tensorflow==2.0.0-alpha0-gpu and executed the same command as above. It seems it is not supported and I do not find any information about tf.lite.TFLiteConverter.from_concrete_function().
$ tflite_convert --output_file=/tmp/tf-lite/mdl --graph_def_file=frozen.pb --input_arrays=wave_input --output_arrays=outputs
Traceback (most recent call last):
  File "/home/sfalk/miniconda3/envs/tf2/bin/tflite_convert", line 10, in <module>
    sys.exit(main())
  File "/home/sfalk/miniconda3/envs/tf2/lib/python3.5/site-packages/tensorflow/lite/python/tflite_convert.py", line 448, in main
    app.run(main=run_main, argv=sys.argv[:1])
  File "/home/sfalk/miniconda3/envs/tf2/lib/python3.5/site-packages/tensorflow/python/platform/app.py", line 40, in run
    _run(main=main, argv=argv, flags_parser=_parse_flags_tolerate_undef)
  File "/home/sfalk/miniconda3/envs/tf2/lib/python3.5/site-packages/absl/app.py", line 300, in run
    _run_main(main, args)
  File "/home/sfalk/miniconda3/envs/tf2/lib/python3.5/site-packages/absl/app.py", line 251, in _run_main
    sys.exit(main(argv))
  File "/home/sfalk/miniconda3/envs/tf2/lib/python3.5/site-packages/tensorflow/lite/python/tflite_convert.py", line 263, in run_main
    raise ValueError("tflite_convert is currently unsupported in 2.0. "
ValueError: tflite_convert is currently unsupported in 2.0. Please use the Python API tf.lite.TFLiteConverter.from_concrete_function().

Would be nice to get this fixed. I'm hitting the same error.
Converting multiple functions is under development.

Can't wait for improvements of lite.TFLiteConverter. I'm not able to convert resnet_v1 to .tflite
Getting this logs:
I tensorflow/lite/toco/import_tensorflow.cc:193] Unsupported data type in placeholder op: 20
I tensorflow/lite/toco/import_tensorflow.cc:1336] Converting unsupported operation: TensorArrayScatterV3
I tensorflow/lite/toco/import_tensorflow.cc:1336] Converting unsupported operation: TensorArrayV3
I tensorflow/lite/toco/import_tensorflow.cc:193] Unsupported data type in placeholder op: 20
I tensorflow/lite/toco/import_tensorflow.cc:1336] Converting unsupported operation: Enter
I tensorflow/lite/toco/import_tensorflow.cc:1336] Converting unsupported operation: Enter
I tensorflow/lite/toco/import_tensorflow.cc:1336] Converting unsupported operation: Enter
I tensorflow/lite/toco/import_tensorflow.cc:1336] Converting unsupported operation: LoopCond
I tensorflow/lite/toco/import_tensorflow.cc:1336] Converting unsupported operation: Enter
I tensorflow/lite/toco/import_tensorflow.cc:193] Unsupported data type in placeholder op: 20
I tensorflow/lite/toco/import_tensorflow.cc:1336] Converting unsupported operation: Enter
I tensorflow/lite/toco/import_tensorflow.cc:1336] Converting unsupported operation: TensorArrayReadV3
I tensorflow/lite/toco/import_tensorflow.cc:1336] Converting unsupported operation: Substr
I tensorflow/lite/toco/import_tensorflow.cc:1336] Converting unsupported operation: DecodeJpeg
I tensorflow/lite/toco/import_tensorflow.cc:1336] Converting unsupported operation: DecodePng
I tensorflow/lite/toco/import_tensorflow.cc:1336] Converting unsupported operation: DecodeGif
I tensorflow/lite/toco/import_tensorflow.cc:1336] Converting unsupported operation: Substr
I tensorflow/lite/toco/import_tensorflow.cc:1336] Converting unsupported operation: DecodeBmp
I tensorflow/lite/toco/import_tensorflow.cc:193] Unsupported data type in placeholder op: 2
I tensorflow/lite/toco/import_tensorflow.cc:193] Unsupported data type in placeholder op: 2
I tensorflow/lite/toco/import_tensorflow.cc:193] Unsupported data type in placeholder op: 2
I tensorflow/lite/toco/import_tensorflow.cc:193] Unsupported data type in placeholder op: 2
I tensorflow/lite/toco/import_tensorflow.cc:193] Unsupported data type in placeholder op: 2
I tensorflow/lite/toco/import_tensorflow.cc:193] Unsupported data type in placeholder op: 2
I tensorflow/lite/toco/import_tensorflow.cc:1336] Converting unsupported operation: Enter
I tensorflow/lite/toco/import_tensorflow.cc:193] Unsupported data type in placeholder op: 20
I tensorflow/lite/toco/import_tensorflow.cc:1336] Converting unsupported operation: TensorArrayWriteV3
I tensorflow/lite/toco/import_tensorflow.cc:1336] Converting unsupported operation: Exit
I tensorflow/lite/toco/import_tensorflow.cc:1336] Converting unsupported operation: TensorArraySizeV3
I tensorflow/lite/toco/import_tensorflow.cc:1336] Converting unsupported operation: TensorArrayGatherV3
F tensorflow/lite/toco/tooling_util.cc:1041] Check failed: array->has_shape()

If you know a way to convert that kind of model - I would appreciate any tips

I am trying to convert the frozen transformer model from tensor2tensor to a tf-lite graph:
$ tflite_convert --output_file=/tmp/tf-lite/mdl --graph_def_file=frozen.pb --input_arrays=wave_input --output_arrays=outputs

I am getting the following error
Traceback (most recent call last):
  File "/home/sfalk/miniconda3/envs/t2t/bin/tflite_convert", line 11, in <module>
    sys.exit(main())
  File "/home/sfalk/miniconda3/envs/t2t/lib/python3.5/site-packages/tensorflow/contrib/lite/python/tflite_convert.py", line 412, in main
    app.run(main=run_main, argv=sys.argv[:1])
  File "/home/sfalk/miniconda3/envs/t2t/lib/python3.5/site-packages/tensorflow/python/platform/app.py", line 125, in run
    _sys.exit(main(argv))
  File "/home/sfalk/miniconda3/envs/t2t/lib/python3.5/site-packages/tensorflow/contrib/lite/python/tflite_convert.py", line 408, in run_main
    _convert_model(tflite_flags)
  File "/home/sfalk/miniconda3/envs/t2t/lib/python3.5/site-packages/tensorflow/contrib/lite/python/tflite_convert.py", line 162, in _convert_model
    output_data = converter.convert()
  File "/home/sfalk/miniconda3/envs/t2t/lib/python3.5/site-packages/tensorflow/contrib/lite/python/lite.py", line 453, in convert
    **converter_kwargs)
  File "/home/sfalk/miniconda3/envs/t2t/lib/python3.5/site-packages/tensorflow/contrib/lite/python/convert.py", line 342, in toco_convert_impl
    input_data.SerializeToString())
  File "/home/sfalk/miniconda3/envs/t2t/lib/python3.5/site-packages/tensorflow/contrib/lite/python/convert.py", line 135, in toco_convert_protos
    (stdout, stderr))
RuntimeError: TOCO failed see console for info.

I would seem that there are a lot of unsupported operations - does this cause the error?
The last line from the tflite_convert output says

F tensorflow/contrib/lite/toco/tooling_util.cc:968] Check failed: array->has_shape()

I don't know if anybody can make sense out of that ...
Is it possible to fix this or is there simply no way to convert this graph at this point in time?
Click to show full tflite_convert output
System information

OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Ubuntu 16.04
TensorFlow installed from (source or binary): pip
TensorFlow version (use command below): 1.12.0
Python version: 3.5.6
CUDA/cuDNN version: 9.0
GPU model and memory: 4x GeForce 1080 GTX

$ uname -spomvi
Linux #48~16.04.1-Ubuntu SMP Tue Jan 29 18:03:48 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

$ pip freeze | grep tensor
mesh-tensorflow==0.0.5
tensor2tensor==1.12.0
tensorboard==1.12.0
tensorflow-gpu==1.12.0
tensorflow-metadata==0.9.0
tensorflow-probability==0.5.0

Hi Stefan, I am also facing the same problems. A lot of operations are not yet supported by tf-lite. I was trying to convert a saved model to a tf-lite file. BTW how did you manage to obtain frozen graph for the transformer mode.
I am using https://github.com/tensorflow/models/tree/master/official/transformer/ to create my model.
I have been able to generate saved_model.pb with estimator's export_saved_model fn, but facing issues while obtaining frozen graph. Could you help with this?

@abhishekm-in , I hope this will help with frozen graph issue

g = tf.Graph()
with g.as_default():
    # start a session using a temporary fresh Graph
    with tf.Session(graph=tf.Graph()) as sess:
        output_graph = "name_of_the_frozen_graph.pb"

        # clear devices to allow TensorFlow to control on which device it will load operations
        clear_devices = True

        # import the meta graph in the current default Graph
        saver = tf.train.import_meta_graph('path_to_saved_model .meta',
                                            clear_devices=clear_devices)

        # restore the weights
        saver.restore(sess, 'path_to_last_checkpoint .ckpt')

        # use a built-in TF helper to export variables to constants
        output_graph_def = tf.graph_util.convert_variables_to_constants(
                            sess, # session is used to retrieve the weights
                            tf.get_default_graph().as_graph_def(), # graph_def is used to retrieve the nodes
                            ["name_of_the_last_layer"])

        # serialize and dump the output graph to the filesystem
        with tf.gfile.GFile(output_graph, "wb") as f:
            f.write(output_graph_def.SerializeToString())

        print("%d ops in the final graph." % len(output_graph_def.node))

The conversion fails because there are (among other unsupported ops) control flow ops (like Enter, Exit, LoopCond) in your model. tflite_convert can't handle those control flow ops at the moment. And we are working on a new converter that can handle the control flow ops.

@haozha111 That's great news. Any idea when this new converter might be available?

Hi, the new converter is being developed and hopefully it will release in a few months (I don't have a timeline though, sorry about that).

@abhishekm-in , I hope this will help with frozen graph issue
import tensorflow as tf

# start a session using a temporary fresh Graph
with tf.Session(graph=tf.Graph()) as sess:
    output_graph = "name_of_the_frozen_graph.pb"

    # clear devices to allow TensorFlow to control on which device it will load operations
    clear_devices = True

    # import the meta graph in the current default Graph
    saver = tf.train.import_meta_graph("path_to_saved_model .meta",
                                        clear_devices=clear_devices)

    # restore the weights
    saver.restore(sess, "path_to_last_checkpoint .ckpt")

    # use a built-in TF helper to export variables to constants
    output_graph_def = tf.graph_util.convert_variables_to_constants(
                        sess, # session is used to retrieve the weights
                        tf.get_default_graph().as_graph_def(), # graph_def is used to retrieve the nodes
                        ["name_of_the_last_layer"])

    # serialize and dump the output graph to the filesystem
    with tf.gfile.GFile(output_graph, "wb") as f:
        f.write(output_graph_def.SerializeToString())

    print("%d ops in the final graph." % len(output_graph_def.node))

@Vearol, Thanks for your reply! I am aware of this method. The problem is that the transformer model I cited in my reply uses estimator. So I converted to saved_model.pb but I am not able to convert it to frozen graph pb. Do you know how to go about it?
@stefan-falk could you let me know how you managed to obtain frozen graph from transformer estimator.

Hi there, I'm also experiencing this issue in TF 2.0.  I use save_model in TF 2.0 and get saved_mode.pb as well as variables folder.  When I try to convert this to tflite file I get following error:
Converting unsupported operation: AddV2 (I get many of these lines)

Current thread 0x00007f6e8b969780 (most recent call first):
  File "/usr/local/lib/python3.6/dist-packages/tensorflow/lite/toco/python/toco_from_protos.py", line 33 in execute
  File "<path>/dist-packages/absl/app.py", line 250 in _run_main
  File "<path>/dist-packages/absl/app.py", line 299 in run
  File "<path>/dist-packages/tensorflow/python/platform/app.py", line 40 in run
  File "<path>/dist-packages/tensorflow/lite/toco/python/toco_from_protos.py", line 59 in main
  File ".../local/bin/toco_from_protos", line 10 in <module>
Aborted (core dumped)

Would be great to find solution...

@stefan-falk , others: Do you have a code snippet on how you froze the transformer network?
I am using the TF 2.0 implementation that's part of the tensorflow repository.
Thanks in advance.

@EphChem Can you please provide simple standalone code to reproduce the issue? Can you try to use new experimental converter by adding this line converter.experimental_new_converter = True and see whether the error persists. Thanks!

@EphChem Could you please respond to the above comment.
@stefan-falk please confirm if the issue still persist.

Hi There,
We are checking to see if you still need help on this, as you are using an older version of tensorflow which is officially considered end of life . We recommend that you upgrade to the latest 2.x version and let us know if the issue still persists in newer versions. Please open a new issue for any help you need against 2.x, and we will get you the right help.
This issue will be closed automatically 7 days from now. If you still need help with this issue, please provide us with more information.


Add more constructors

Use the number of cpus as pool size
Allows sharing the thread pool

Why don't you want to simply remove the constructor that accepts a number of threads? I don't see many consumers of this one, and they can work around by creating ThreadPool themselves.

As @nchash wrote

Maybe add a Planner::new, taking a usize and Planner::new_num_cpus. There are use cases where you don't need an Arc and you need to set the number of threads (for example to benchmark performance with and without multithreading).

And from the user's perspective it isn't obvious that the way you get a Planner with a set number of threads is call Planner::from_pool.

Additionally, doing it that way is non breaking and easier to understand what it does from the function name.
And there's not really a disadvantage of having one more function.

Well, I don't agree with @nchash proposal here. I think new() should be dumb simple and good for everyone, so having no parameters is great.

There are use cases where you don't need an Arc and you need to set the number of threads (for example to benchmark performance with and without multithreading).

The non-multithreaded mod is a bigger task - #72 , we don't need to cater for it since we don't yet know how it is going to work.

And from the user's perspective it isn't obvious that the way you get a Planner with a set number of threads is call Planner::from_pool.

As I said, a regular user would not care. An advanced user would figure from_pool out.

Additionally, doing it that way is non breaking ...

Don't worry about breaking too much. We are on the verge of 0.8, which is fine to break API a little.

... and easier to understand what it does from the function name.

The easiest thing to understand is new() without parameters, and that's what I'm arguing for.

And there's not really a disadvantage of having one more function.

Sure thing, as long as you keep the most used case unencumbered. So, it's fine to have an extra with_num_threads constructor, but not fine to have usize parameter for new().

@kvark Good idea, did that

Thanks @torkleyy ! Last things - make CI happy and squash the commits please.


In a typical single text-buffer set up move the scrollbar to the page side

It would in theory be possible to detect whether the window arrangement has a typical single text-buffer, and if so to do some shenanigans to move the scroll bar to the side of the page. Maybe the <div> dimensions would be stretched to the page limits, and an inner div (or padding?) was used to limit the width of the window. If GlkOte was ever changed to use the flex box system it might be simpler?
Low priority, and rather hacky, but raising this issue so that the idea isn't forgotten.

I investigated this while trying to research #50 (but wound up solving it another way).
What I did was to set the buffer window to position: static and all other windows to position: fixed. It was fine, but it didn't solve any of my problems, so I didn't turn it into a PR.
(What problem is this intended to solve?)

(What problem is this intended to solve?)

This ugliness. But it could also be helped with some scroll bar styles.

These styles work nicely (in Webkit at least)
.BufferWindow {
    overflow: auto;
    scrollbar-gutter: stable;
}
.BufferWindow::-webkit-scrollbar {
    width: 10px;
}
.BufferWindow::-webkit-scrollbar-thumb {
    background: rgba(50%,50%,50%,25%);
}


Panic on "The device doesn't support any format!?: DeviceNotAvailable" when playing sound

Similarly (but not the same afaict) to #130, Rodio panics on this trivial example:
if let Some(device) = rodio::default_output_device() {
    if let Ok(file) = File::open("res/notification_sound_clearly.ogg") {
        if let Ok(src) = rodio::Decoder::new(BufReader::new(file)) {
            rodio::play_raw(&device, src.convert_samples());
        }
    }
}

with the following message:
ALSA lib pcm_dmix.c:1108:(snd_pcm_dmix_open) unable to open slave
thread 'main' panicked at 'The device doesn't support any format!?: DeviceNotAvailable', /home/restioson/.cargo/registry/src/github.com-1ecc6299db9ec823/rodio-0.10.0/src/engine.rs:147:30
stack backtrace:

I am on Pop_OS! latest release (Linux/GNOME).
Perhaps my system is misconfigured, but it should still probably not panic, and rather return an error.

I had a different error, but it resulted in the same panic: The device doesn't support any format!?: DeviceNotAvailable.
For me the problem was that I was running the application as root. My PulseAudio instance runs in user mode (default), and the root user does not have a running instance. Running the application as current user, or starting an audio server for root solved it. This might be relevant for you as well.
Here's my complete log:
ALSA lib confmisc.c:767:(parse_card) cannot find card '0'
ALSA lib conf.c:4568:(_snd_config_evaluate) function snd_func_card_driver returned error: No such file or directory
ALSA lib confmisc.c:392:(snd_func_concat) error evaluating strings
ALSA lib conf.c:4568:(_snd_config_evaluate) function snd_func_concat returned error: No such file or directory
ALSA lib confmisc.c:1246:(snd_func_refer) error evaluating name
ALSA lib conf.c:4568:(_snd_config_evaluate) function snd_func_refer returned error: No such file or directory
ALSA lib conf.c:5047:(snd_config_expand) Evaluate error: No such file or directory
ALSA lib pcm.c:2564:(snd_pcm_open_noupdate) Unknown PCM default
thread 'main' panicked at 'The device doesn't support any format!?: DeviceNotAvailable', src/libcore/result.rs:1165:5
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace.

I believe it was user mode but I'm not sure. I will try it again. I think in the end I switched to some other crate that worked correctly. Thanks!

I get similar error running on Arch:
connect(2) call to /dev/shm/jack-1000/default/jack_0 failed (err=No such file or directory)
attempt to connect to server failed
thread 'main' panicked at 'The device doesn't support any format!?: DeviceNotAvailable', src/engine.rs:151:30

I am using pulseaudio and sound works in Chrome/Firefox

@koalefant it's trying to connect to jack, is this what you intended?

@koalefant it's trying to connect to jack, is this what you intended?

Not at all. It detects it as default device and crashes. Althought other applications work fine through Pulse.
I wrote a code as a workaround that first tries default with name "pulse" and then falls back to default device.
Unfortunately I had to add explicit dependency on cpal for this to my project.

Same issue here. @koalefant Could you post your workaround please?

@RodrigoLeiteF
I use following code, but it is only tested on my machine:
            let available_hosts = cpal::available_hosts();
            let mut pulse_device = None;
            for host_id in available_hosts {
                let host = match cpal::host_from_id(host_id) {
                    Ok(h) => h,
                    Err(_) => continue
                };
                let devices = match host.devices() {
                    Ok(d) => d,
                    Err(_) => continue
                };
                for (_device_index, dev) in devices.enumerate() {
                    if let Ok(dev_name) = dev.name() {
                        if dev_name == "pulse" {
                            pulse_device = Some(dev);
                        }
                    }
                }
            }
            let pulse_output = pulse_device.as_ref().map(|d| rodio::OutputStream::try_from_device(d).ok()).flatten();
            let output = pulse_output.or_else(|| rodio::OutputStream::try_default().ok());

Is there a priority for different audio servers? My setup keeps trying to use alsa while pulseaudio is running.
I think it's always preferable to use an audio service that supports multiple outputs first: pulseaudio, jack, oss, sndio, etc.

Is there a priority for different audio servers? My setup keeps trying to use alsa while pulseaudio is running.
I think it's always preferable to use an audio service that supports multiple outputs first: pulseaudio, jack, oss, sndio, etc.

(caveat: this might not be correct) I think work on rodio predates different hosts in cpal. It might just be a case of forwarding the host enumeration/selection options from cpal into rodio?

(caveat: this might not be correct) I think work on rodio predates different hosts in cpal. It might just be a case of forwarding the host enumeration/selection options from cpal into rodio?

Same issue. I didn't feel comfortable even trying to start a sound server for root, so instead installing https://archlinux.org/packages/extra/x86_64/pulseaudio-alsa/ solved it for me.

Same issue. I didn't feel comfortable even trying to start a sound server for root, so instead installing https://archlinux.org/packages/extra/x86_64/pulseaudio-alsa/ solved it for me.

Same issue but installing pulseaudio-alsa did not solve it for me (I already had it installed, anyway)


fix HTTPS m3u8 file not loading

Added a configuration setting to the player to set demuxer-lavf-o with the value protocol_whitelist=[file,tcp,tls,http,https] this property allows the library to parse M3U8 files with the specified protocols, which should resolve issues with playing HTTPS M3U8 files.
Dart example with using  protocolWhitelist
final Player player = Player(
  configuration: const PlayerConfiguration(
    logLevel: MPVLogLevel.warn,
    protocolWhitelist: ["file", "tcp", "tls", "http", "https", "crypto","data"],
  ),
)

Test File from omagestream service
#EXTM3U
#EXT-X-VERSION:3
#EXT-X-INDEPENDENT-SEGMENTS

#EXT-X-STREAM-INF:BANDWIDTH=674554,CODECS="avc1.640015,mp4a.40.2",RESOLUTION=426x240,FRAME-RATE=30,AUDIO="audio2"
https://api.omegastream.net/stream/company/processed-enterprise-media/bd413f82/video/57721636-0247-4588-8772-b2ec036504e0/playlist_1.m3u8?s=58c953dcbcfda4dd29e9cafa2c0a38a21964fef7

#EXT-X-STREAM-INF:BANDWIDTH=994337,CODECS="avc1.64001E,mp4a.40.2",RESOLUTION=640x360,FRAME-RATE=30,AUDIO="audio2"
https://api.omegastream.net/stream/company/processed-enterprise-media/bd413f82/video/57721636-0247-4588-8772-b2ec036504e0/playlist_2.m3u8?s=58c953dcbcfda4dd29e9cafa2c0a38a21964fef7

#EXT-X-STREAM-INF:BANDWIDTH=1518890,CODECS="avc1.64001F,mp4a.40.2",RESOLUTION=854x480,FRAME-RATE=30,AUDIO="audio2"
https://api.omegastream.net/stream/company/processed-enterprise-media/bd413f82/video/57721636-0247-4588-8772-b2ec036504e0/playlist_3.m3u8?s=58c953dcbcfda4dd29e9cafa2c0a38a21964fef7

#EXT-X-STREAM-INF:BANDWIDTH=2666804,CODECS="avc1.64001F,mp4a.40.2",RESOLUTION=1280x720,FRAME-RATE=30,AUDIO="audio2"
https://api.omegastream.net/stream/company/processed-enterprise-media/bd413f82/video/57721636-0247-4588-8772-b2ec036504e0/playlist_4.m3u8?s=58c953dcbcfda4dd29e9cafa2c0a38a21964fef7

#EXT-X-MEDIA:TYPE=AUDIO,GROUP-ID="audio2",NAME="5",AUTOSELECT=YES,URI="https://api.omegastream.net/stream/company/processed-enterprise-media/bd413f82/video/57721636-0247-4588-8772-b2ec036504e0/playlist_5.m3u8?s=58c953dcbcfda4dd29e9cafa2c0a38a21964fef7",CHANNELS="2"

Example using MPV command line tool
mpv --demuxer-lavf-o="protocol_whitelist=[file,tcp,tls,http,https]" example.m3u8

Credits: @zezo357 helped alot ♥

Not a dev here, but do you have an example of a failing https m3u8?
Is it only with omegastream?
Because I did not had the problem. with the wrong protocol. It fails sometimes for over reason.

Not a dev here, but do you have an example of a failing https m3u8?
Is it only with omegastream?
Because I did not had the problem. with the wrong protocol. It fails sometimes for over reason.

It's fails when playing a m3u8 local file like the mentioned in PR , and mostly it's https not being allowed
It works if it's a m3u8 url

oh yes. sorry

oh yes. sorry
Is the following not working?
final player = Player();
if (player.platform is libmpvPlayer) {
  await (player.platform as dynamic).setProperty('demuxer-lavf-o', 'protocol_whitelist=[file,tcp,tls,http,https]');
}

adapted from https://github.com/alexmercerind/media_kit/issues/129#issuecomment-1508019709

Yes this was added in the player configuration. In this pr.

yes. I saw.
The question is, is this needed to hard-code it, in the player config? or not?
Given, you can add it yourself, before playing the video, if this is what kind of source you are expecting to play.
This was what I meant.

yes. I saw.
The question is, is this needed to hard-code it, in the player config? or not?
Given, you can add it yourself, before playing the video, if this is what kind of source you are expecting to play.
This was what I meant.

For me yes, I added it to player before playing, but me and ahmed thought some settings should be added to player configurations to make it easier for developers

Same for HTTP headers, thought it may be better to set it in Media.

Yeah, it is in the plans.

Same for HTTP headers, thought it may be better to set it in Media.

Yeah, it is in the plans.

Will try to make a pr for it.


FHIR Testing Match Conformance/Interoperability tests between Capability Statement and FHIR Published Specifications

As a FHIR Server I am required by FHIR Specifications to publically publish a Capability (formerly Conformance) Statement - in accordance with the FHIR Specification the Capability Statement (http://hl7.org/fhir/2017Jan/capabilitystatement.html) includes an element fhirVersion (http://hl7.org/fhir/2017Jan/capabilitystatement-definitions.html#CapabilityStatement.fhirVersion) - valid published FHIR Version(s) are viewable here - http://hl7.org/fhir/directory.html
(#1) As a FHIR Server I would like Crucible to identify and ensure the Server fhirVersion is actively part of the test cases chosen and are specific to the published version of FHIR being tested.  Note: FHIR Version STU 3 Candidate or Ballot currently has available four valid published version(s) - with active systems running 1.4.0, 1.6.0 and now 1.8.0 coming online daily.
(#2) As a FHIR Server I would like Crucible to identify which version of FHIR test cases (suite) were used to test my server. e.g. Dec 6, 2016 build 1.8.0 FHIR STU3 Candidate + Connectathon 14 (San Antonio)
(#3) Please ensure Crucible does NOT publically publish test results where active public servers running a valid version of FHIR are being tested against none compatible published standards - that would represent erroneous reporting by Crucible (could potentially introduce harm to the Organization being reported against).  Given our proximity to HIMSS 2017 - a number of Organizations are planning very high profile FHIR announcements (accurate reporting by public test platforms will be critical to the healthcare marketplace, the industry and HL7).
e.g. AEGIS WildFHIR (URL - http://wildfhir.aegis.net/fhir1-6-0) self identifies as a FHIR 1.6.0 implementation, and should only be tested against FHIR STU3 version 1.6.0 Baltimore Connectathon profile.  If the Crucible Team updates the public version of Crucible to support/test 1.8.0 - please ensure testing of 1.8.0 occurs only against AEGIS WildFHIR (URL - http://wildfhir.aegis.net/fhir1-8-0) self identifies as a FHIR 1.8.0.
This notes that there are significant and breaking changes being published between the various STU3 versions.  This conversation will be posted to Zulip for more feedback

Rob, see #97.

Pull requests on fhir-crucible/crucible#211 and fhir-crucible/crucible#212 should address and close both #97 and #95

Crucible only displays results from the latest version of FHIR. If someone chooses to test an older version, we allow the test to run, but results are not reported on the homepage.


Clicking the extension's sidebar button causes VSCode to hang

Describe the bug
VSCode hangs when clicking the extension's sidebar button if a path is added to the extension settings.
If a path is not added, VSCode doesn't hang, but obviously no search is done and no projects are listed.
Memory usage is also increasing while VSCode hangs. I've hit 2GB memory usage before I killed the process manually via the Task Manager.
To Reproduce
Steps to reproduce the behavior:

Add a path like the extension is asking
Click on the extension's sidebar button
VSCode hangs

Expected behavior
A successful search in the provided path(s).
VSCode not to hang and consume a lot of memory.
Desktop (please complete the following information):

OS: Windows 10, 64-bit

Additional context

I've tried adding different paths, from different drives. Some with projects, some without and even ones that were completely empty directories. Everything made VSCode hang.
Might be a Windows thing. Might also be a portable VSCode thing, as this is what I'm using.

I get the same thing, but only on Windows.  It works fine on Linux.  When I first encountered it,  I thought it was because I had directories with large numbers of sub-folders in the path pointed to (which is warned about in the docs).  It wasn't until today that I tried again in a situation where I didn't have those directories, and I found that it still hung.  It's chewing up a  lot of  memory and cpu, and showing lots of disk activity.

Same here.

Has anyone looked any closer at this?  It's been a year.  I don't have Typescript skills, or I'd be looking at it closer.  Has anyone actually gotten Workspace Manager to work under Windows?


Added Azure deploy button

Added Azure deployment button in README.md file

Merged.
Ibon.
From: sescalada<EMAIL_ADDRESS>Sent: Wednesday, September 28, 2016 10:02 AM
To: Microsoft/XamarinAzure_ShoppingDemoApp<EMAIL_ADDRESS>Subject: [Microsoft/XamarinAzure_ShoppingDemoApp] Added Azure deploy button (#2)
Added Azure deployment button in README.md file

You can view, comment on, or merge this pull request online at:
https://github.com/Microsoft/XamarinAzure_ShoppingDemoApp/pull/2
Commit Summary

Added deploy button

File Changes

M README.mdhttps://github.com/Microsoft/XamarinAzure_ShoppingDemoApp/pull/2/files#diff-0 (2)
M Xamarin.Azure.Backend.Deployment/Scripts/Deploy-AzureResourceGroup.ps1https://github.com/Microsoft/XamarinAzure_ShoppingDemoApp/pull/2/files#diff-1 (2)
M Xamarin.Azure.Backend.Deployment/Xamarin.Azure.Backend.Deployment.deployprojhttps://github.com/Microsoft/XamarinAzure_ShoppingDemoApp/pull/2/files#diff-2 (4)
R azuredeploy.jsonhttps://github.com/Microsoft/XamarinAzure_ShoppingDemoApp/pull/2/files#diff-3 (0)

Patch Links:

https://github.com/Microsoft/XamarinAzure_ShoppingDemoApp/pull/2.patch
https://github.com/Microsoft/XamarinAzure_ShoppingDemoApp/pull/2.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://github.com/Microsoft/XamarinAzure_ShoppingDemoApp/pull/2, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ABmc9QqzDUm0dkR8XEjS_YdFN053t_TNks5quh8MgaJpZM4KIhgm.


[Question] SSL support

Is there out of the box support for HTTPS?
Sorry. I could not find this anywhere. Thanks

Hi, unfortunately there is not, but I strongly and personally recommend Caddy.


Create Server endpoints (v2) returning the checkpoins data of a partitioning

Background
We need to read all the measurements across a checkpoint of certain name within a flow.
Feature
Create the REST API endpoint and required class in model module to return the data received from DB.
Proposed Solution [Optional]
Use #141 for endpoints path.
Envelope is not needed, to be implemented yet.
Depends on #189

This item depends on:

AbsaOSS/atum-service#189
By Dependent Issues.

This item depends on:

AbsaOSS/atum-service#189
By Dependent Issues.


Fix initial prompt and commit message

The initial prompt is now more specific about not including "This commit" in the description, and adds a newline between the subject and description.

@dararish i've changed base branch to dev, could you solve the conflict pls :)

please pull latest dev and run npm run build to solve conflicts @dararish


Pract.03: Add 01-02 | Nikolay Radilov

Solutions for tasks from pract 03

Do not upload the .bin files


feat(storage):   iterator support min_epoch check

I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.
What's changed and what's your intention?
Some change about TTL as title
Please explain IN DETAIL what the changes are in this PR and why they are needed:

~keyspace adapt table properties with CatalogTable~
UserIterator add check through min_epoch
ReadOptions add Option and support to calculate min_epoch for iterator

Checklist

[x] I have written necessary docs and comments
[x] I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

https://github.com/singularity-data/risingwave/issues/3298

UserIterator add check through min_epoch

How is it different from previous (with/with out min_epoch)?

UserIterator add check through min_epoch

How is it different from previous (with/with out min_epoch)?

At first min_epoch means that user could not access keys which under min_epoch. It use for consistent for ttl. Without min_epoch, user may access the key which under compaction, lead to Inconsistency between two reads

UserIterator add check through min_epoch

How is it different from previous (with/with out min_epoch)?

At first min_epoch means that user could not access keys which under min_epoch. It use for consistent for ttl. Without min_epoch, user may access the key which under compaction, lead to Inconsistency between two reads

But I remembered that iter will always need a epoch as parameter?


chore: update a string of ci configs & gitignore & REAME

also fix typo

@coderzc after this PR merged, travis CI will disappear


Add device history docs

Change-type: minor

@vipulgupta2048 As the feature currently undertakes a little restructuring of the data model, the device history itself won't be surfaced in the UI but a real device audit log. May be similar but not same. Will keep it updated.


Factory uses getForeignKeyName instead of getForeignPivotKeyName on morphToMany/belongToMany relationship

Laravel Version: 9.19
PHP Version: 8.1.7
Database Driver & Version: Postgres 14.4

Description:
Factory has a bug where it tries to use getForeignKeyName() method instead of getForeignPivotKeyName() method on morphToMany or belongsToMany relationships causing the following error:
Call to undefined method Illuminate\Database\Eloquent\Relations\MorphToMany::getForeignKeyName()

Steps To Reproduce:

Create 4 models following the morph-to-many example from Laravel documentation with the pivot morph table.
Attempt to create morph objects using the factory to create instances of the morphToMany model.

$user = User::factory()->create();
$posts = Post::factory()->count(10)->for($user, 'user')->create();
$tags = Tag::factory()->count(3)->for($user->posts[0], 'posts')->create();

You will end up with the following error as factory attempts to use an erroneous method name getForeignKeyName() which only exists on BelongsTo/HasMany instead of getForeignPivotKeyName() which is the method name on BelongsToMany and MorphToMany relationships.

Call to undefined method Illuminate\Database\Eloquent\Relations\MorphToMany::getForeignKeyName()

Conclusion?

getForeignKeyName() only exists on hasMany and belongsTo relationships. Factory should know when it's being used on a belongsToMany or morphToMany and use getForeignPivotKeyName() instead.

Heya, thanks for reporting.
We'll need more info and/or code to debug this further. Can you please create a repository with the command below, commit the code that reproduces the issue as separate commits on the main/master branch and share the repository here? Please make sure that you have the latest version of the Laravel installer in order to run this command. Please also make sure you have both Git & the GitHub CLI tool properly set up.
laravel new bug-report --github="--public"

Please do not amend and create a separate commit with your custom changes. After you've posted the repository, we'll try to reproduce the issue.
Thanks!

I'll re-open this once you can provide a repo. Thanks


Add retries to rattler-build upload

quetz-client has the options for retries because quetz is sometimes flaky and returns 504s. It would be nice if rattler-build could do something similar.

ideally with exponential backoff with random factor. when uploading to quetz concurrently a lot of times at once, it can happen that quetz crashes

Another issue but this is quetz related:
upload retries in quetz are broken anyways because its not unlikely that you get 502 on the first attempt, but it still goes through, and then you get 409 on your second attempt

Also, the current behavior is that when the first package upload fails, the rest will not be tried. This is bad when the first is a 409 for some reason. Then it's not possible to upload all the packages from CI through retries of the CI.


lowercase is much better

Codecov Report

Merging #15 (575d6ba) into main (8aff3aa) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #15   +/-   ##
=======================================
  Coverage   68.20%   68.20%
=======================================
  Files           9        9
  Lines        1211     1211
=======================================
  Hits          826      826
  Misses        309      309
  Partials       76       76

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8aff3aa...575d6ba. Read the comment docs.


bails before reaching --max-count; "|wc -l" differs from grep -c

ag bails out with "Too many matches" before reaching --max-count:
$ grep -c a /usr/share/dict/words
61444

$ ag --max-count 61444 a /usr/share/dict/words |wc -l
ERR: Too many matches in /usr/share/dict/words. Skipping the rest of this file.
48018

$ ag --max-count 61445 a /usr/share/dict/words |wc -l
ERR: Too many matches in /usr/share/dict/words. Skipping the rest of this file.
48019

$ ag --max-count 61446 a /usr/share/dict/words |wc -l
ERR: Too many matches in /usr/share/dict/words. Skipping the rest of this file.
48019

And if we give a really high --max-count, it gets even more confusing:
$ ag --max-count 9999999 a /usr/share/dict/words |wc -l
62226

That last one is somehow more than what grep -c reported – who should I trust?

FWIW, I'm still getting the problem of max-count bailing out too early, i.e. the error:
        Too many matches in /tmp/whatever.txt Skipping the rest of this file.

When using ag --max-count 1 /tmp/whatever.txt.
This is on OS X 10.11 using 0.31.0

I am as well. with a simple --max-count 1
ag version 2.2.0

Features:
  +jit +lzma +zlib


Update the glossary section in the Developer Guide

There are currently no terms which may be worth recording so this issue should be done only if necessary.

Not sure if this was necessary so this will be closed for now. This can be reopened later if necessary.


Links to the documentation are broken

The links to the documentation in the README do not work

@goerz thanks for pointing this out. There currently aren't any automatically generated docs (these links are just from the pkg template) and all the docs are in the README and in the code itself. I'll try to get around to adding a documenter.jl config soon to fix this.


Cannot attach debugger to a node.js application running inside a Docker container

I'm trying to attach the Visual Studio Code debugger to a node.js app that is running inside a Docker container.
The app starts like:
node --debug-brk app.js

My docker-compose.yml exposes the port for attaching:
app:
  build: .
  working_dir: /code
  volumes:
    - .:/code
  command: npm run debug
  ports:
    - "3004:3000"
    - "5858:5858"

launch.json is pretty simple:
{
	"version": "0.2.0",
	"configurations": [
		{
			"name": "Docker",
			"type": "node",
			"request": "attach",
			"port": 5858
		}
	]
}

Now, when I start the application and attach the debugger this will correctly connect (I can see the values flashing in the debugger UI already), but then it will stop, telling me the following:

Error opening 'app.js' (File not found: /code/app.js).

Is there any way to fix this path offset? Should one handle this scenario completely different?

VS Code assumes that the (absolute) file paths returned from node.js, can be found in the filesystem where VS Code runs. As long as node.js runs on the same system as VS Code, this is always the case.
In your case node.js runs on a different system than VS Code, so the paths returned from node.js are not valid in VS Code.
We are planning to improve this path mapping soon. Until that has happened, can you try tweak your setup, so that the docker paths are valid paths on your host system too? (e.g. by using symbolic links).

Thanks for getting back to me so fast. I already tried the symlinking approach and everything mentioned in this Stack Overflow post but could not get it to work in any constellation.
Should symlinking work in theory?

This issue was moved to Microsoft/vscode-node-debug#8

This is late to the game but I just ran into this issue.  Make sure your remoteRoot node and localRoot node in your launch.json point to the proper location.  I have a situation where I develop in a /lib folder and in my Docker file the files are put in a /app folder.  This is how my launch.json is configured...
        "localRoot": "${workspaceRoot}/lib",
        "remoteRoot": "/app/"

The debugger will attach properly then.


Adding configuration file validation for more file formats

At the start beet only supported Json configuration files. Therefore the extension shipped with built-in validation using Json schemas.
However, since v0.27.0 beet now also supports *.yaml, *.yml, *.toml and pyproject.toml as configuration files. I think it would be usefull to add validation for these files.
Now there is the challlenge of how this will be implemented. Json validation is built-in to Vscode, YAML and toml unfortunately not.
YAML
YAML is a superset of Json and can therefore use the same schemas that are used for Json. The validation itself however requires an extension.
A possible solution would be to use the YAML extension from RedHat, since it supports schemas from SchemaStore. If we add the existing Json schemas to SchemaStore, they can be used for both Json and Yaml validation. Schemas would no longer be packaged inside the extension and could be updated independently.
Toml / pyproject.toml
I'm still searching for a toml validator. Again, relying on an extension is probably the best solution.

It seems Even Better Toml is an extension that supports toml validation using Json schemas.
But instead of SchemaStore it uses its own remote schema registry.

Nice suggestion! That seems like a pretty reasonable solution. The YAML extension from RedHat is great, and I didn't know about Even Better Toml but it looks good as well. I've actually been thinking that maybe there's a way to alleviate the maintenance burden of keeping the schema up-to-date by leveraging pydantic to generate json schemas automatically. Currently this would only work for the main config because plugins that retrieve configuration from the context metadata kind of do their own thing. However I'm trying to figure out a way for plugins to use pydantic models to provide runtime validation, and this would potentially make it possible to resolve the schema for plugins statically as well.

Also I investigated a bit further and it looks like the YAML extension allows other extensions to contribute schemas directly https://github.com/redhat-developer/vscode-yaml#mapping-a-schema-in-an-extension

Nice find, I should have read the docs more ;).
I will try to implement this solution for Yaml. Maybe Even Better Toml has something similar, if not I can open a feature request.
This will not change our schemas setup for now, so no big refactor is neccessary. I think this a good first step and when it works, we can implement generated schemas

Just confirmed the solution for Yaml works 🎉. I will make a new release right now

Even Better Toml sadly does not have a similar feature, but the maintainer is open to the idea (https://github.com/tamasfe/taplo/issues/130#issuecomment-870687765) of adding the feature from the Yaml extension.
I will try to work in that direction, as it seems to be the most optimal solution.

Just tried out the yaml autocompletion in the new version it works great! Glad to see that at some point we might be able to do the same for toml. In the meantime I made a first step towards automatically generating schemas by introducing a @configurable plugin decorator that can use pydantic models as validators. Now that I see the improvement it makes I wish I introduced something like this sooner. No more awkward factory functions!


fileutil: remove dependency on prometheus/prometheus

fileutil tests depended on https://github.com/prometheus/prometheus/util/testutil for creating temporary directories. This change copies the code to the tsdb repository instead of importing it and creating this weird dependency chain. Especially since it isn't used by https://github.com/prometheus/prometheus directly itself.
This is a straight copy of the code but it could even be stripped down as not all exported identifiers are needed by the tsdb code.
cc @krasi-georgiev

I think @gouthamve  and @fabxc  are both in favour of having no external dependencies so no objections from me.
if it is an exact copy feel free to merge.

Thanks for the quick review! I'll give a bit of time for others to review and merge tomorrow if no one complains.


Add role requirements for spo hubsite register and unregister

Currently the 2 commands spo hubsite register and spo hubsite unregister have a remark stating that the API is in preview and is subject to change. However I think the API is stable right now. When I consult the docs, I don't see any warning saying that the API is in preview.
https://learn.microsoft.com/en-us/sharepoint/dev/features/hub-site/rest-registerhubsite.method
https://learn.microsoft.com/en-us/sharepoint/dev/features/hub-site/rest-unregisterhubsite-method
Another thing about the docs: you should be SharePoint admin or Global admin to register or unregister a site as hub site. Usually when you need  special permissions, we also explicitly show them in our docs. In this case the permissions are missing.
Things to do
For both spo hubsite register and spo hubsite unregister:

Remove the API preview remark from the docs
Add remark To use this command you must be a Global or SharePoint administrator.
Example:
https://github.com/pnp/cli-microsoft365/blob/1f313f74e14ab58d6f8323c290dc8bc8c1183810/docs/docs/cmd/planner/tenant/tenant-settings-list.md?plain=1#L17-L18

@pnp/cli-for-microsoft-365-maintainers do you agree that we can remove the 'API is in preview' warning?

Seems like you're right indeed! Ship it 👍

Seems solid. Let's update the remarks.

All right let's open it up, thanks for the review @martinlingstuyl @Jwaegebaert!

All yours!


Some problems about English version.

Hi, there,
I use this source file to compile an English version. I found that the captions of Figure/Table are compiled with Figure1/Table1, which have no space between Figure/Table and 1. I hope that Figure 1/ Table 1 can be compiled. Moreover, in the reference, there is also no space between the reference number and paper information (like: ''[1]Ilya Sutskever,** Oriol Vinyals,''). I hope the reference could be compiled as ''[1]  Ilya Sutskever, Oriol Vinyals.''
Would you please tell me how to solve this problem? I really appreciate any help you can provide.

For figure and table names, I have added a new option english in branch nlp2021-en. Please have a try:
\documentclass[lualatex,english]{nlp2021}

With this option, you can remove the redefinitions of \refname etc. that I mentioned in #2.

Moreover, in the reference, there is also no space between the reference number and paper information (like: ''[1]Ilya Sutskever,** Oriol Vinyals,'').

This does not reproduce for me. Maybe you didn't give an appropriate number to the thebibliography environment? Could you provide a minimal working example?

This does not reproduce for me. Maybe you didn't give an appropriate number to the thebibliography environment? Could you provide a minimal working example?

Reply: After using your new branch for En version, this problem has been solved!
Additionally, the problem about Figure/Table has also been solved by using the new en branch.
Thank you very much! Have a nice day~

Excuse me, after using the new en version, I found new problems.
The interlinkage for the reference and Figure/Table are disappeared.
For example, in the text "BLEU (B) [28] andMETEOR(M) [29] metrics," the number [28] and [29] have no link function. When I click the [28]/[29], there is no action. (In the former version, the [28]/[29] is blue font and has link function. But now the font of these number is black, and no link function any more.)
The same problem with Figure and Table, in the text "As shown in Table 1," nothing happens when I click the number "1,"  do you have any ideas?
Thank you in advance!

Did you load the hyperref package?

👍 It has been solved now! Thank you for your cooperation!


I've also got this issue: Module parse failed: Unexpected character '#' (17:0);

DEPRECATED
Please use: https://github.com/webpack-contrib/mini-css-extract-plugin

Thanks a lot. This issue was solved by revising the webpack.config.js.
Here are the details:
const config = {
module: {
rules: [
{
test: /.styl/,
use: ExtractPlugin.extract({
fallback : 'style-loader',
use: [
'css-loader',
{
loader: 'postcss-loader',
options:{
sourceMap : true,
}
},
'stylus-loader'
]
})
}
]
}
};
module.exports = config;


reading from depth texture  disables depth test.

Godot version
4 beta 6
System information
Kubuntu
Issue description
When reading from the depth texture in the shader, everything becomes messed up if it overlaps itself.
I think when this happens no specific draw order is imposed.
Steps to reproduce
1- Make a model that overlaps itself
2- Make a shader material that reads from DEPTH_TEXTURE.
Minimal reproduction project
gd4test.zip

Duplicate of https://github.com/godotengine/godot/issues/63675 (same cause – see below).
Reading from the depth texture forces the material to be transparent, which causes transparency sorting issues. These are an inherent limitation of the rendering engine, and cannot always be resolved.


App hang during message input

Description
App slows down and eventually hangs completely while entering a non-trivial amount of text in the message input box.
Devices and Versions
Your Rocket.Chat.Android version: 3.0.0 Build 2048 65de72ff - play
Your Rocket.Chat Server version: 0.69.2
Mobile device model and OS version: Nexus 5x - Android 8.1.0
Steps to reproduce
Write a slightly larger (multiple sentences) message in the input Box in a group chat. Use a small amount of markup (*bold*). Text input becomes gradually slower, eventually the app hangs completely. "App is not responding" system dialog appears.
Logs
N/A

@MarcSchmitzer Is this always reproducible? We're trying with a very long text here, bold and mentions and the app is not getting slow. 🤔

@MarcSchmitzer could you provide some sample inputs that are causing the problem for you?

Sorry for not responding. I can't provide the exact inputs, but there's a pattern that might be relevant:
The occasions where this happened was when I tried to write my "daily" report, which has the pattern (albeit in German):
*Yesterday:* ...
*Today:* ...

So there's some markup with colons mixed in. As I said, the "..." stands for a non-trivial amount of text, multiple sentences.
The other thing is that this always happened on the train, so with a potentially flaky internet connection.
Thanks for looking into this.

I am seeing this aswell on RC App 3.1.1, Server 0.70.0, Oneplus 3 running LineageOS.
I did not get the app to crash though. It seems like the markup really compounds the issue. i can type long messages with emojis and pure text without problems.

@luciofm We identified the problem here... it's being caused after you type : and start typing other things... something is still being processed, probably related to the autocomplete.
We'll be working on a fix for this ASAP. 👍

Bug is fixed and will be included in our next beta already, please make sure to help us testing it! 👌


Documentation

Here I am setting up documentation for Sphinx and Docs2Pages.

Okay, so now there 2 things left: 1) Polish the tiny rest of the documentation so it renders properly. 2) Find out why there's a 404 popping up after deploying the website.


go.mod: Tidy with Go 1.19

Runs go mod tidy with -go=1.19 on the go.mod for the project.
Note that as of Go 1.20, the go directive is not
the minimum required Go version.
It's the version of the toolchain we developed against.
This is changing in Go 1.21.
The -compat flag specifies which version of Go the go.mod file
needs to be compatible with.
By default, this is one release behind the -go flag
(or go directive).
So we don't need to specify it manually.
Lastly, this deletes the go mod tidy in the test job.
Only the lint job should bbe modifying the go.mod
to ensure that the go.mod is up to date.
(This is a copy of #471, which was accidentally merged into #474.)

Current dependencies on/for this PR:

main

PR #474

PR #475   👈

PR #473

PR #472

PR #471

This comment was auto-generated by Graphite.

@abhinav started a stack merge that includes this pull request via Graphite.

@abhinav merged this pull request with Graphite.


Check if importing public vs private key in rust

in rust the importPrivateJwk works with a public key, this needs to have a check added to throw if it detects a public key
once this change is made, updates will have to made to kotlin

I fixed it live


Updated paths in .eslintignore

Didn't you forget this part when reorganizing the modules?

Thanks! Merged in 7f4ce0e6b96bd65630604d124267f0bb72593383 (with the duplicate wagtail/images/static removed, and wagtail/contrib/search_promotions updated too)


How to use Gradient Accumulation with RectifiedAdam

I'm trying to use Gradient Accumulation with RectifiedAdam optimizer.
How can I modify the code to use gradient accumulation ?
I saw this, but it's based on Keras backend so I can't apply it here.
There is also various other implementation for Keras out there, but nothing for Optimizer v2.
Any tip on how to implement this feature my self ?
I'm using Keras fit method.

Have you tried with https://github.com/run-ai/runai/?

TensorFlow Addons is transitioning to a minimal maintenance and release mode. New features will not be added to this repository. For more information, please see our public messaging on this decision:
TensorFlow Addons Wind Down
Please consider sending feature requests / contributions to other repositories in the TF community with a similar charters to TFA:
Keras
Keras-CV
Keras-NLP


Polybar shows on wrong monitor after hide

Describe the issue
When the polybar hides and then shows again it appears on the wrong monitor.
Expected behavior:
The hidden polybars should be appearing on the same monitor on which they were hidden.
Actual behavior:
Running polybar-msg cmd toggle twice makes all the polybars from all my monitors  show up on a single monitor.
To Reproduce
A minimal but complete config with which the problem occurs:
# File: ~/.config/polybar/config
[bar/middle]
monitor = ${env:MONITOR_MIDDLE}

[bar/right]
inherit = bar/middle
monitor = ${env:MONITOR_RIGHT}

# File: ~/.profile
# Monitors
export MONITOR_MIDDLE=DP-2
export MONITOR_RIGHT=DVI-D-0

Screenshots

Environment:

WM: i3-gaps

polybar 3.2.1

Features: +alsa +curl +i3 +mpd +network +pulseaudio +xkeyboard

X extensions: +randr (+monitors) -render -damage -sync -composite +xkb +xrm +xcursor

Build type: RelWithDebInfo
Compiler: /usr/sbin/c++
Compiler flags: -march=x86-64 -mtune=generic -O2 -pipe -fstack-protector-strong -fno-plt -Wall -Wextra -Werror -Wno-noexcept-type -O2 -pedantic -pedantic-errors
Linker flags: -Wl,-O1,--sort-common,--as-needed,-z,relro,-z,now

Try to set override-redirect = true in the bar section and see if that helps, i3 really likes to mess with bar positioning. I know this will introduce other problems (no space reserved for bars), I just want to confirm that this happens because of i3.
Please also post the output of the bar that is moved when it is toggled (preferably with the additional -l trace command line argument).
I will also try to reproduce this on my end.

Setting override-redirect to true did in fact keep the two polybars on their respective monitors.
As for running polybar with -l trace I got this. Output was the same for both bars.
* Receiving ipc message
* Hiding bar window
* Receiving ipc message
* Showing bar window
- bar: Force update
* Redrawing bar window
- renderer: flush(1 geom=57x27+0+0, falloff=0)
- bar: Received expose event

Alright, so it is in fact i3 messing everything up (as usual).
It seems your only option is to leave this option set to true and use a transparent dummy bar to make i3 reserve space for your bars as described here.  This way i3 can reclaim the space when you hide the bars.

Well that sure is a bodge if there ever was one. Thanks for the answer, I will keep it in mind. Hopefully there will be a native solution with i3 at some point.

No, polybar-msg cmd restart should not break anything

I can't say I appreciate @patrick96's tone, but in trying to hunt this down I would appreciate if someone could tell us what it is polybar does that is supposed to let the window manager know onto which output to place the bar.
From the log file provided by @jluttine in https://github.com/i3/i3/issues/3819 it appears that polybar sets the geometry to x=0/y=0 for both windows, so I guess the geometry when mapping the window is not what polybar tries to use(?)

@Airblader Now that I read my comment again it does sound demeaning. I'm sorry about that, it certainly was not meant that way.
Polybar sets the x and y coordinates of the window to position it on the screen. It calculates those coordinates from the monitor specified in the config (or the primary monitor). So for example if I had two 1920p monitors side-by-side and polybar on the monitor on the right at the top, it would set its geometry as 1920x50+1920+0 (assuming it is 50px high). As far as I know we don't use the monitor name for anything else when positioning the bars. Does i3 need polybar to explicitly set the monitor name somewhere?
I am currently on my way back from vacation, so I don't have much time to track this down right now but I will try to dig into this and give a more in-depth answer tonight or tomorrow.
Sorry again, I didn't mean to attack anyone. I'm very much a fan of your and the i3 team's work. I hope we can fix this issue together.

Does i3 need polybar to explicitly set the monitor name somewhere?

No, that is fine, and i3 does / should respect that: https://github.com/i3/i3/blob/next/src/manage.c#L246
The log file provided by @jluttine shows this:
10/13/2019 10:25:34 AM - manage.c:manage_window:83 - window 0x01200002
10/13/2019 10:25:34 AM - WM_CLASS changed to polybar (instance), Polybar (class)
10/13/2019 10:25:34 AM - WM_NAME changed to "polybar-nide_eDP-1"
10/13/2019 10:25:34 AM - Using legacy window title. Note that in order to get Unicode window titles in i3, the application has to set _NET_WM_NAME (UTF-8)
10/13/2019 10:25:34 AM - window.c:window_update_name:67 - _NET_WM_NAME not specified, not changing
10/13/2019 10:25:34 AM - window.c:window_update_leader:148 - CLIENT_LEADER not set on window 0x01200002.
10/13/2019 10:25:34 AM - window.c:window_update_transient_for:173 - TRANSIENT_FOR not set on window 0x01200002.
10/13/2019 10:25:34 AM - window.c:window_update_strut_partial:210 - Reserved pixels changed to: left = 0, right = 0, top = 27, bottom = 0
10/13/2019 10:25:34 AM - window.c:window_update_role:223 - WM_WINDOW_ROLE not set.
10/13/2019 10:25:34 AM - window.c:window_update_hints:389 - WM_HINTS not set.
10/13/2019 10:25:34 AM - window.c:window_update_normal_hints:275 - Could not get WM_NORMAL_HINTS
10/13/2019 10:25:34 AM - startup.c:startup_sequence_get:287 - No _NET_STARTUP_ID set on window 0x01200002
10/13/2019 10:25:34 AM - manage.c:manage_window:195 - startup workspace = (null)
10/13/2019 10:25:34 AM - This window is of type dock
10/13/2019 10:25:34 AM - randr.c:get_output_containing:108 - comparing x=0 y=0 with x=0 and y=0 width 1280 height 720
10/13/2019 10:25:34 AM - manage.c:manage_window:220 - Starting search at output eDP-1
10/13/2019 10:25:34 AM - manage.c:manage_window:226 - Top dock client
10/13/2019 10:25:34 AM - manage.c:manage_window:245 - Initial geometry: (0, 0, 1280, 27)
10/13/2019 10:25:34 AM - Checking window 0x01200002 (class Polybar)
10/13/2019 10:25:34 AM - dock status matches

So the position polybar requested is x=0/y=0. @jluttine Can you please clarify the placement of the outputs you used for that test, i.e. how where the two outputs placed and on which output did they open?

I made two tests during the same logging session. In the first one, I "mirrored" the same view to two monitors and then everything worked when hiding and showing the polybar. Then, I placed the two monitors horizontally (eDP-1 on left and HDMI-1 on right, IIRC). In that setup, both polybars appeared on eDP-1 after being hidden. Just to make sure: Are these log file parts from the latter, not former, setup?

@jluttine I think the problem is fixed on this branch
Could you test?

Are these log file parts from the latter, not former, setup?

In the log files, there are four polybar windows being mapped in total, grouped into two events: one at 10:45:27 and one at 10:45:43. The logs above are from the latter one.
Out of all four requests, there is only one with an initial geometry of x != 0:
10/13/2019 10:25:27 AM - manage.c:manage_window:195 - startup workspace = (null)
10/13/2019 10:25:27 AM - This window is of type dock
10/13/2019 10:25:27 AM - randr.c:get_output_containing:108 - comparing x=1280 y=0 with x=0 and y=0 width 1280 height 720
10/13/2019 10:25:27 AM - randr.c:get_output_containing:108 - comparing x=1280 y=0 with x=1280 and y=0 width 1280 height 720
10/13/2019 10:25:27 AM - manage.c:manage_window:220 - Starting search at output HDMI-1
10/13/2019 10:25:27 AM - manage.c:manage_window:226 - Top dock client
10/13/2019 10:25:27 AM - manage.c:manage_window:245 - Initial geometry: (1280, 0, 1280, 27)

But this is from the first of the two events(?) and also it can be seen that that one actually shows at HDMI-1 while all others go to eDP-1, so it sort of sounds like i3 is doing the correct thing.

I have unfortunately not been able to get to my multimonitor setup yet and efforts to simulate on on my laptop using Xephyr failed. So the only thing I can do for right now is to comment on what polybar is doing.
The bar is certainly positioned correctly when it is launched. But it seems to me as soon as the bar is unmapped (hidden) and remapped (shown) xcb_get_geometry suddenly returns x=0/y=0 in manage.c:manage_window:96.
Is the window position reset when a window is unmapped? Because polybar only calls xcb_configure_window_checked when it is started but not when it is remapped. Maybe this is the issue. I can give a more definitive answer on this once I am at my dual monitor setup.

It seems this also happens on a single monitor (it is just not noticeable visually).
I have a bottom bar with the following config:
[bar/example]
width = 80%
modules-left = text
background = #ff0000
offset-x = 10%

enable-ipc = true

tray-position = none

bottom = true

[module/text]
type = custom/text
content = Filler

; vim:set ft=dosini:

I'm running this in a Xephyr session: Xephyr +extension RANDR -screen 2560x1440 :1, the output is called default. Here is an excerpt of the i3 log when starting that bar and running polybar-msg cmd hide and polybar-msg cmd show (full log is attached below):
[...] POLYBAR START
[...]
10/15/2019 02:36:02 PM - handlers.c:handle_map_request:262 - window = 0x00800001, serial is 1619.
10/15/2019 02:36:02 PM - manage.c:manage_window:83 - window 0x00800001
10/15/2019 02:36:02 PM - window.c:window_update_name:67 - _NET_WM_NAME not specified, not changing
10/15/2019 02:36:02 PM - window.c:window_update_leader:148 - CLIENT_LEADER not set on window 0x00800001.
10/15/2019 02:36:02 PM - window.c:window_update_transient_for:173 - TRANSIENT_FOR not set on window 0x00800001.
10/15/2019 02:36:02 PM - window.c:window_update_strut_partial:209 - Reserved pixels changed to: left = 0, right = 0, top = 0, bottom = 24
10/15/2019 02:36:02 PM - window.c:window_update_role:223 - WM_WINDOW_ROLE not set.
10/15/2019 02:36:02 PM - window.c:window_update_hints:389 - WM_HINTS not set.
10/15/2019 02:36:02 PM - window.c:window_update_normal_hints:275 - Could not get WM_NORMAL_HINTS
10/15/2019 02:36:02 PM - startup.c:startup_sequence_get:287 - No _NET_STARTUP_ID set on window 0x00800001
10/15/2019 02:36:02 PM - manage.c:manage_window:195 - startup workspace = (null)
10/15/2019 02:36:02 PM - randr.c:get_output_containing:107 - comparing x=256 y=1416 with x=0 and y=0 width 2560 height 1440
10/15/2019 02:36:02 PM - manage.c:manage_window:220 - Starting search at output default
10/15/2019 02:36:02 PM - manage.c:manage_window:229 - Bottom dock client
10/15/2019 02:36:02 PM - manage.c:manage_window:245 - Initial geometry: (256, 1416, 2048, 24)
[...] Presumably the configure request in bar.cpp:814
10/15/2019 02:36:02 PM - handlers.c:handle_configure_request:279 - window 0x00800001 wants to be at 256x1416 with 2048x24
10/15/2019 02:36:02 PM - handlers.c:handle_configure_request:312 - Configure request!
10/15/2019 02:36:02 PM - handlers.c:handle_configure_request:362 - Reconfiguring dock window (con = 0x55faa23df550).
10/15/2019 02:36:02 PM - randr.c:get_output_containing:107 - comparing x=256 y=1416 with x=0 and y=0 width 2560 height 1440
10/15/2019 02:36:02 PM - handlers.c:handle_configure_request:386 - Dock client will not be moved, we only support moving it to another output.
10/15/2019 02:36:02 PM - xcb.c:fake_absolute_configure_notify:85 - fake rect = (0, 1416, 2560, 24)
[...] HIDE
10/15/2019 02:36:18 PM - handlers.c:handle_event:1357 - event type 18, xkb_base 85
10/15/2019 02:36:18 PM - handlers.c:handle_unmap_notify_event:464 - UnmapNotify for 0x00800001 (received from 0x00800001), serial 1691
10/15/2019 02:36:18 PM - tree.c:tree_close_internal:201 - closing 0x55faa23df550, kill_window = 0
[...] SHOW
10/15/2019 02:36:32 PM - handlers.c:handle_event:1357 - event type 20, xkb_base 85
10/15/2019 02:36:32 PM - handlers.c:handle_map_request:262 - window = 0x00800001, serial is 1732.
10/15/2019 02:36:32 PM - manage.c:manage_window:83 - window 0x00800001
10/15/2019 02:36:32 PM - window.c:window_update_name:67 - _NET_WM_NAME not specified, not changing
10/15/2019 02:36:32 PM - window.c:window_update_leader:148 - CLIENT_LEADER not set on window 0x00800001.
10/15/2019 02:36:32 PM - window.c:window_update_transient_for:173 - TRANSIENT_FOR not set on window 0x00800001.
10/15/2019 02:36:32 PM - window.c:window_update_strut_partial:209 - Reserved pixels changed to: left = 0, right = 0, top = 0, bottom = 24
10/15/2019 02:36:32 PM - window.c:window_update_role:223 - WM_WINDOW_ROLE not set.
10/15/2019 02:36:32 PM - window.c:window_update_hints:389 - WM_HINTS not set.
10/15/2019 02:36:32 PM - window.c:window_update_normal_hints:275 - Could not get WM_NORMAL_HINTS
10/15/2019 02:36:32 PM - startup.c:startup_sequence_get:287 - No _NET_STARTUP_ID set on window 0x00800001
10/15/2019 02:36:32 PM - manage.c:manage_window:195 - startup workspace = (null)
10/15/2019 02:36:32 PM - randr.c:get_output_containing:107 - comparing x=0 y=0 with x=0 and y=0 width 2560 height 1440
10/15/2019 02:36:32 PM - manage.c:manage_window:220 - Starting search at output default
10/15/2019 02:36:32 PM - manage.c:manage_window:229 - Bottom dock client
10/15/2019 02:36:32 PM - manage.c:manage_window:245 - Initial geometry: (0, 0, 2560, 24)
[...]

i3log.txt
The bar requests geometry 2048x24+256+1416 which is also reflected in these two lines:
10/15/2019 02:36:02 PM - manage.c:manage_window:245 - Initial geometry: (256, 1416, 2048, 24)
10/15/2019 02:36:02 PM - handlers.c:handle_configure_request:279 - window 0x00800001 wants to be at 256x1416 with 2048x24

But after running hide and show, the initial geometry turns into:
10/15/2019 02:36:32 PM - manage.c:manage_window:245 - Initial geometry: (0, 0, 2560, 24)

I am suspecting this has to do with i3 reparenting the window into its own container. Looking at the output of  xwininfo -tree -root, it gives me:
     0x20008f "[i3 con] container around 0x55faa23b01f0": ("i3-frame" "i3-frame")  2560x24+0+1416  +0+1416
        1 child:
        0x800001 "polybar-example_default": ("polybar" "Polybar")  2560x24+0+0  +0+1416

This is directly after polybar is started and it doesn't change once polybar is hidden and shown again. See how here the geometry already is 2560x24+0+0. I'm assuming the reparenting in manage.c:manage_window:535 is the thing that changes the geometry:
    xcb_void_cookie_t rcookie = xcb_reparent_window_checked(conn, window, nc->frame.id, 0, 0);

This makes sense since, relative to the container, the bar should be at position 0,0. It seems to me some information is lost when unmapping the window because the container around polybar is destroyed by i3 and when remapping i3 no longer knows the original position of the bar.
From initial testing I was able to get the same manage.c:manage_window:245 - Initial geometry message after hiding and showing polybar again by calling xcb_configure_window_checked directly before remapping the bar so that i3 has the correct position information again.
I'm not completely sure that this is what's causing the issue on a multi-monitor system because I only have limited testing capabilities right now. Will be able to confirm later and try out my polybar fix on a dual-monitor system.

That could be. I tried to scan the ICCCM but couldn't find anything regarding how window managers should behave or what clients can / have to expect apart from the usual rule that a client must be prepared that a window manager can choose to do what it wants (not helpful here).
I tend to believe that a client who unmapped itself and then wants to map again should make sure all appropriate things, including geometry, are set right before mapping, but nonetheless it would be interesting to know if window managers like awesome etc reparent the window to some specific location on the root window. If so I would see no harm in doing the same for i3.

I just checked awesome and openbox. awesome seems to in fact reparent to the current location while openbox does so for normal clients but also uses (0, 0) for dock clients (can someone check if this bug occurs in openbox, too?)
In any case, perhaps we should just consider changing this in i3.

I've quickly opened https://github.com/i3/i3/pull/3834.
@jluttine or anyone else, could you maybe try running this patch to see if it fixes the issue?

I was able to now finally reproduce this problem in i3. I have a polybar fix for which I will open a PR shortly.
However, that fix only works if polybar unmaps and remaps itself. If polybar is unmapped and remapped with xdotool windowunmap and xdotool windowmap. it will always move to the monitor on the left.
But when unmapping with an external tool then other bars like tint2 and i3bar both also get placed on the wrong monitor, so I think it's on i3 to handle this.
Interestingly, stalonetray always stays in the right position, I haven't been able to figure out how it does it.
Openbox's behavior is very weird. For one it does not recognize polybar as a dock window. It only recognizes windows as docks if they set initial_state = WithdrawnState in WM_HINTS or if the second string in WM_CLASS is DockApp. So it treats it as a normal client and the bug doesn't occur. However, for some reason when remapping it sets the y coordinates of the frame to 160 which places polybar in the middle of the screen, not sure what is up with that but it's probably not related to the issue here.
I will try out your PR ASAP.

Your PR works for this issue. I have nonetheless added a fix within polybar since there are likely other WMs that do a similar thing.

BTW, i3bar also reconfigures itself before unhiding:
https://github.com/i3/i3/blob/next/i3bar/src/xcb.c#L356

The fix in i3 is merged now. Thanks everyone :-)

BTW, i3bar also reconfigures itself before unhiding:

I see, didn't know i3bar could hide itself. That's why I only tested with xdotool.

The fix in i3 is merged now.

Awesome!
I have now adapted my PR to also reconfigure width, height, stacking order, struts and hints just to be on the safe side. It should be merged shortly.


[Event Request] table 179 "Reversal Entry"

Please change event OnAfterSetReverseFilter as follows :
[IntegrationEvent(true, false)]
    local procedure OnAfterSetReverseFilter(Number: Integer; RevType: Option Transaction,Register; GLRegister: Record "G/L Register")
    begin
    end;

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.


Fix tar silence

Windows was cancelled, but it passes for the branch on travis. I'll just merge since we need this in.


Problems on URL renaming

URL renaming should be in the 4th step "Extract Modlist Data", and it is extract_modlist that should be modifield.
It is usual to have files from different games in a single modlist file. So it will be more compatible to get game name from modlist file instead of using a fixed value. It can be found under key Meta, which is a string formated as INI.

I'm just putting it together and doing the README. I don't plan on touching the code, as it's not my code. Sorry.


Mechanism to aggregate status of all required image builds

Is your feature request related to a problem? Please describe.
Our CI pipelines need to know when all images have been bumped for cf-deployment.
Describe the solution you'd like
When all docker images have been created for a cf-deployment version (when fissile or stemcell is bumped), the pipeline that builds the images should trigger the pipeline that bumps release versions. See #172 .

@mudle, @f0rmiga and I already had some discussions around this, we probably should store some sentinel file on s3 as soon as the pipelines are finished building images. We can also store fissile stemcell os and version info required for bump.


Updated version number in package.json to reflect latest release

This should resolve issue #14. :)

Thank you @MerlijnVH


Proper error handling for very long segments

If there are more than ~1000 tokens, the model will give an error.  We need to either handle this with a graceful error or somehow break up the segment into multiple segments and then recombine.

Just give the error unless there is a really easy way to do otherwise.  "doing it better" is handled in https://github.com/sillsdev/silnlp/issues/182.

One other potential for these really long strings is just to truncate them to the max number of tokens.  Therefore, no error needs to be given and the user at least gets something, even if it is not complete.

Or alternatively, truncate to 50% of the max tokens, around 500.  That would allow translations to take more tokens than on the input.  I think "something is better than nothing" is likely the best choice.

NLLB only allows 200 tokens max -> https://huggingface.co/facebook/nllb-200-3.3B/blob/main/config.json.  Therefore, we should just truncate to 200 tokens and be done with it.


Remove Content-Type response header if the file is cached

The content-type currently defaults to text/html, which is inaccurate
because no content is being returned. Google, along with popular CDNs,
omit the Content-Type header for 304 response.

Didn't know that CDNs and browsers don't care about it.
Thanks 👍


recursion

Is it possible to make recursion for the case when there is another archive in the archive? If yes, what should be the condition for this?

I'm not sure I understand what you mean. Can you fill out the issue template fully, for a feature request? For your proposal, please be very clear and specific so that someone who is implementing what you are requesting can do so exactly. Thanks!
Then we can re-open this.


fix: update how to contribute url

Update how to contribute link from this which is open the GitHub docs instead of the guides. The guide now is moved to this link.
Here is a preview when I tried to open the guide is redirected to GitHub docs

Thanks!


Fixed bugs for low zooms with tiles exceeding the world's size

For smaller zooms, or when asking for images at the edge of the world, fixed bugs with tile list generation

CC: @flippmoke

/cc @camilleanne @yhahn

@flippmoke @camilleanne @yhahn  Hi, any updates on this PR?

hi @nyurik -- I'll review this today. Could you restart the travis build that failed? https://travis-ci.org/mapbox/abaculus/jobs/121131105

@camilleanne the mapnik-config keeps failing for node 12, but seems to be fine for node 10. Hae you seen this before?  Is that a bug in the PR or somewhere else?

@camilleanne If you have any questions, ping me on IRC - yurik (i'm in the # mapbox and various wikimedia-* channels)

@flippmoke @camilleanne @yhahn I re-based my changes on top of your rewrite with the tile sizes. Lets merge this soonish so that it doesn't diverge too far again. There is a number of critical bug fixes that we really need in our env. Thanks!


allow to customize walletconnect

Description
For featuring different wallets that are based on walletconnect
PLEASE NOTE- Checklist must be complete prior to review.
Checklist

[x] Increment the version field in package.json of the package you have made changes in following semantic versioning and using alpha release tagging
[x] Check the box that allows repo maintainers to update this PR
[x] Test locally to make sure this feature/fix works
[ ] Run yarn check-all to confirm there are not any associated errors
[ ] Confirm this PR passes Circle CI checks
[x] Add or update relevant information in the documentation

Docs Checklist

[ ] Include a screenshot of any changes (see docs README on running locally)
[x] Add/update the appropriate package README (if applicable)
[ ] Add/update the related module in the docs demo (if applicable)
[ ] Add/update the related package in the docs/package.json file (if applicable)

If this PR includes changes to add an injected wallet or SDK wallet module:
Please complete the following using the internal demo package.
To run this demo use the command yarn && yarn dev to get the project running at http://localhost:8080/
Tests with demo app (injected)

[ ] send transaction
[ ] switch chains
[ ] sign message
[ ] sign typed message
[ ] disconnect

Tests with demo app (SDK)

[ ] send transaction
[ ] switch chains
[ ] sign message
[ ] sign typed message
[ ] disconnect

@sirpy can you elaborate on use cases for these changes?
We are hesitant to allow changing of labels/icons from WalletConnect for security reason mostly based on misleading the users.

@sirpy we aren't going to be able to support this change for the Walletconnect package. We will are opting to keep the package as clearly labeled and branded for walletconnect but will continue to support the direction you noted above with custom modules.


export details preview image incorrect

I am testing the new export tool, and created an export job for the Philippines: http://export.hotosm.org/en/exports/9ef1948e-14dd-42d2-975f-bb469c5151ad/
The preview image for the job incorrectly displays the area of Thailand/India/Pacific ocean, instead of the expected area of interest, the Philippines. Below is a screenie:

Thank you very much for letting us know.
I think the linked to image is not displaying properly, could you drag and drop it in the text window here?

Sorry about that. Image in the post displays properly from my end.
But try this link instead: http://en.zimagez.com/zimage/screenshot-181015-101902.php

Not sure what the problem is there.. looks ok to me? http://export.hotosm.org/en/exports/9ef1948e-14dd-42d2-975f-bb469c5151ad/

Hi @bjohare .
From my end,  what I see is a preview  of Thailand/India/Pacific Ocean not my area of interest, which is the Philippines. Are you saying, you're seeing the overview map of the Philippines instead?

Yes I see the Philippines..What happens if you refresh the page?

Even after a refresh, I still see the same thing.

I tried to take a look at the preview map for the export but seems it no longer exists. Could you please confirm if this issue was addressed @govvin or is it still displaying the wrong location?

@mataharimhairi , thanks for keeping tabs on this. It appears that the original job has been deleted, so I made a job here, which is still running: http://export.hotosm.org/en/exports/e8223714-100f-47f2-827c-f2e34333fd84/
Looks like the original issue is no longer a problem, and the map preview now correctly displays the map of the Philippines.