Deprecate Flink 1.16

:mag: Description
Issue References 🔗
This pull request add a message to tell users that Flink 1.16 is deprecated.
Disscusion: https://lists.apache.org/thread/fmq7462vcfm8l3m38xh4b4jjgd4smzn7
Describe Your Solution 🔧
Add a message to tell users that Flink 1.16 is deprecated.
Types of changes :bookmark:

[ ] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Test Plan 🧪
Behavior Without This Pull Request :coffin:
Behavior With This Pull Request :tada:
Related Unit Tests

Checklist 📝

[x] This patch was not authored or co-authored using Generative Tooling

Be nice. Be informative.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 61.15%. Comparing base (8cc9b98) to head (11c9289).

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6142      +/-   ##
============================================
+ Coverage     61.11%   61.15%   +0.03%
  Complexity       24       24
============================================
  Files           625      625
  Lines         37234    37234
  Branches       5028     5028
============================================
+ Hits          22755    22769      +14
+ Misses        12036    12013      -23
- Partials       2443     2452       +9

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Thanks, merged to master


[HIGH] Make the Search Sidebar transition relatively smooth on slower devices

Problem
When user navigates back from Search Sidebar there’s a noticeable delay and lag in closing the Search Sidebar. It mainly arises from withNavigationFocus HOC as it re-renders the BaseOptionSelector tree including OptionsList . Adding a memo to OptionsList doesn’t help as it’s parent gets re-rendered due to the withNavigationFocus HOC.
Also, we notice that due to isFocused state value in ActionItemView the ReportActionsList re-renders which also adds the overhead to the rendering cycle as it recreates the instances of recordTimeToMeasureItemLayout and loadOlderChats which are passed as props to ReportActionsList
Solution
We can remove the withNavigationFocus HOC and add navigation listeners(focus, blur) in BaseOptionSelector and memoize OptionsListto not re-render when state is set in it’s parent. We can avoid recreating instances of recordTimeToMeasureItemLayout and loadOlderChats by wrapping them in useCallbacks and memorizing ReportActionsList.
Before on 6x CPU throttle:
See profile-ranked-before
See profile-timeline-before
See recording-before
After on 6x CPU throttle:
See profile-ranked-after
See profile-timeline-after
See recording-after
The results looks impressive as we are able to save more than 700ms for the commit that happens when we close the Search sidebar.

@hurali97's PR is here! https://github.com/Expensify/App/pull/31354


Calls to .pause() fail after a .restart()

Just noticed that calls to .pause() on timelines have no affect following a call to .restart() a timeline.
Not seeing anything in the docs, so not sure if this is a "feature" or a bug?
If it matters I am running nested timelines when this occurs.
Otherwise this is a great library that has helped a ton.
Thanks.
John

Hi John,
first of all, thanks for the report.
Are you calling the pause() on the parent timeline (correct) or on one of the nested timeline (wrong)?
Can you put online a codepen that replicates the bug? This would help a lot.
Thanks

Hello,
I've used my pen from another issue :
http://codepen.io/anon/pen/zGdXwz
If you click to launch the animation and click on restart, you'll see it plays both tweens at the same time.
Thanks!

Hi, thanks for the report.
I am able to reproduce the issue locally. I can solve it in the next days, I hope it's not an urgent thing.
Thanks again.

Not urgent, it can wait. Thank you

Find the issue has been easier than expected, so I just solved it right now.


remove log_ncerr logging macro

It turns out, we don't need the log_ncerr macro, the log_ncerr does the same thing:
log_ncerr(status); just prints the error string associated with status, e.g.
[ERROR] /p/home/jhamman/rasm_vic5/models/lnd/vic/vic/drivers/cesm/src/get_nc_field.c:49: errno: No such file or directory
it would be better to use
log_err("%s", "a useful message"); to print out a bit more information.  log_err retrieves the error number and prints the error string as well. Which would print something like this:
[ERROR] /p/home/jhamman/rasm_vic5/models/lnd/vic/vic/drivers/cesm/src/get_nc_field.c:49: errno: No such file or directory: trouble opening ${VIC5TESTDIR}/vic_params_wr50a_vic5.0.dev.nc

Closed per #279


IDE should have password

Right now, all it requires is an email address, which it doesn't check. It then provides command line access to the system

Yeah - I'd agree the Google version should have this - you agree the vagrant and Docker versions shouldn't though right?

Actually, it might be better to just have everything require username and password for everything except for the API endpoints (which require an api key)
So in the server stanza, add something like
    auth_basic      "devbox";
    auth_basic_user_file  /etc/nginx/htpasswd;

Add a line to /etc/nginx/htpasswd for user planemo, password planemo
planemo:8Xvgj/h3f4hB6

Then add an exception (as described in http://stackoverflow.com/questions/9281564/nginx-auth-basic-for-everything-except-a-specific-location) for the /api
location /api {
       auth_basic off;
}

IDE removed.


feat(button-group) implements the ButtonGroup component

updated so that it reuses the core Button component


Add an "X-Powered-By" and "X-AspNet-Version" header

From aspnet/KestrelHttpServer#138

Following up from @Daniel15 comment

Is it worth adding something like X-Powered-By too? The server header is usually overwritten by reverse proxies (eg. Nginx).

Looks that that's a bug in the proxy? rfc2616 14.38 Server

If the response is being forwarded through a proxy, the proxy application MUST NOT modify the Server response-header. Instead, it SHOULD include a Via field (as described in section 14.45).

Also:

Note: Revealing the specific software version of the server might
allow the server machine to become more vulnerable to attacks
against software that is known to contain security holes. Server
implementors are encouraged to make this field a configurable
option.

Looks that that's a bug in the proxy?

The section you quoted is for "regular"/forward proxies. RFC2616 says:

The Server response-header field contains information about the software used by the origin server to handle the request.

With a reverse proxy, the proxy itself is considered the origin server. See http://trac.nginx.org/nginx/ticket/538.

RFC2616 does give conditions for a gateway in 14.45 Via

The Via general-header field MUST be used by gateways and proxies to indicate the intermediate protocols and recipients between the user agent and the server on requests, and between the origin server and the client on responses.

The fact the nginx bug tracker they consider themselves to be the origin server and quote mod_proxy to justify this is a bit of a reach since that continues to say:

A typical usage of a reverse proxy is to provide Internet users access to a server that is behind a firewall. Reverse proxies can also be used to balance load among several back-end servers, or to provide caching for a slower back-end server. In addition, reverse proxies can be used simply to bring several servers into the same URL space.

The reverse-proxy acts as the origin for networking purposes meaning no client configuration is required.
Following nginx argument though; it would mean all load balancers should overwrite the server header and all caches should overwrite the server header.
Examples of other reverse-proxies:

Varnish cache
Adds: Via:1.1 varnish
Example: https://www.varnish-cache.org/ or https://en.wikipedia.org/ or all of github.io
Apache Traffic Server
Adds: via: http/1.1 usproxy1.fp.bf1.yahoo.com (ApacheTrafficServer)
Example: https://www.yahoo.com/
Application Request Routing
Doesn't add anything; though sets a ARRAffinity cookie
Example: http://azure.microsoft.com/en-us/
Squid cache
Doesn't add anything
Example: http://www.squid-cache.org/
AWS Cloudfront CDN
Adds: Via:1.1 d84fed7fd1b1bbf46db79b86f6968b79.cloudfront.net (CloudFront)
Example: https://a0.awsstatic.com/main/css/1.0.170/style.css (on http://aws.amazon.com/ )
Google HTTP/HTTPS Load Balancing
Adds: Via: 1.1 google
Example: ? docs here: https://cloud.google.com/compute/docs/load-balancing/http/

I think you comparison to gateway is accurate and nginx is poorly behaved.

Updated nginx ticket: https://trac.nginx.org/nginx/ticket/538#comment:4

It is worth noting that RFC 7231 has removed the language about proxies not being allowed to modify the server.  I not yet found the specific reasons why it was removed.  Still looking.
I personally don't think the intent of saying that a reverse-proxy looks like the origin web server to the client was intended to allow it to mask the existence of all infrastructure behind it.  The whole point of the layered architecture and the uniform interface is that each layer looks like the origin server.  I suspect the use of the word proxy in the 2616 text was intended to mean "intermediary".

RFC 7230 states:

An HTTP-to-HTTP gateway  MUST send an appropriate Via header field in each inbound request
message and MAY send a Via header field in forwarded response messages.

A "gateway" (a.k.a. "reverse proxy")

Based on this I would argue that it is valid for a gateway to add its identifier to the Via header of a response and therefore leave the server header untouched.  It is also valid for the gateway to change the server header and not add a via header.  As was mentioned earlier, this should be configurable.
Personally I would like to avoid having the X-Powered-By and X-ASPNET-Version headers appear in my responses.

Interesting; have updated the ngnix ticket

Personally I would like to avoid having the X-Powered-By and X-ASPNET-Version headers appear in my responses.

:+1: Please provide control to deactivate if it this request is approved. I think we should have that for Server, too. Otherwise, you have to go to this trouble:
public void Configure(IApplicationBuilder app) {
    app.Use(next =>
    {
        return ctx =>
        {
            ctx.Response.Headers.Remove("Server");
            return next(ctx);
        };
    });
    app.UseMvc();
}

Whatever we do for this definitely must be turn-off-able. In previous versions of ASP.NET there was always a switch for this.


Request failed at creating new application

Hy,
I have already successfully added an application that works perfectly. Now I wanted to add a new application, but every time I enter the password for authentication I get the following message: "FATA Request failed with HTTP 500 Internal Server Error."
The current application can be displayed without any problems.
Does anyone here have any ideas?

I have probably found the error.
I deleted my current database and reconfigured PushBits. I realised that an additional "sqlite sequence" table had been added to the database.
After I reconfigured PushBits, I was able to add several applications.

Interesting, thank you for reporting this behavior.

When did you originally create the (first) database?
What do you mean by "After I reconfigured PushBits"?

I used PushBits for the first time on 16.05.2023.
I deleted the database but kept the config file. I then restarted the container and added the applications again via pbcli, as they were no longer present with the database deletion.

I tried again today to add a new application. Unfortunately, I now get the error message again.
I have already added 3 applications.

I have found the error. The container did not have write access to the database file. Therefore it could not add any new applications to the database.

I'm curious what the server log gave you as output. In either case, since this seems to be a configuration issue, I would go ahead and close it. Feel free to open a new issue if you think there is still something to be fixed.


Incompatibility with rsbuild caused by Import attributes syntax

Describe the bug
Rsbuild (based on rspack) is an incredibly performant builder :  https://github.com/web-infra-dev/rsbuild
It's more and more popular
There's an integration with storybook : https://github.com/rspack-contrib/storybook-rsbuild
Unfortunately, rspack does not support syntax Import attributes
see https://github.com/web-infra-dev/rspack/issues/4358
and there's one here ->
https://github.com/JesusTheHun/storybook-addon-remix-react-router/blob/e8b13193d2fe560ed76d64c274db8791a70cf7de/src/constants.ts#L2
thus using storybook-addon-remix-react-router causes the following compilation error with rsbuild :

  × JavaScript parsing error: Expected ';', got 'assert'
         ╭─[1:1]
       1 │ import { makeDecorator, addons } from '@storybook/preview-api';
       2 │ import P, { useState, useMemo, useCallback, useRef } from 'react';
       3 │ import de from '../package.json' assert { type: 'json' };
         ·                                  ──────
       4 │ import { createMemoryRouter, RouterProvider, UNSAFE_RouteContext, useLocation, useParams, useSearchParams, useNavigationType } from 'react-router-dom';
       5 │
         ╰────

I understand it's more an issue from the rsbuild side, but I wonder if this syntax is really necessary and if you could remove it ?
An imported thing to know is this syntax is only supported in V8-based engines, and its removal from the web is being investigated by tc39.
To Reproduce
Describe all the steps required to reproduce the issue.
see https://github.com/rspack-contrib/storybook-rsbuild/issues/42
Additional context
Add any other context about the problem here.
Environment
Share the output of the following command :
Storybook Environment Info:
System:
OS: Windows 11 10.0.22631
CPU: (16) x64 AMD Ryzen 7 5800H with Radeon Graphics
Binaries:
Node: 18.18.2 - C:\Program Files\nodejs\node.EXE
Yarn: 1.22.22 - C:\Program Files\nodejs\yarn.CMD <----- active
npm: 9.8.1 - C:\Program Files\nodejs\npm.CMD
Browsers:
Edge: Chromium (123.0.2420.65)
npmPackages:
@storybook/addon-essentials: 8.2.2 => 8.2.2
@storybook/addon-interactions: 8.2.2 => 8.2.2
@storybook/addon-links: 8.2.2 => 8.2.2
@storybook/addon-onboarding: 8.2.2 => 8.2.2
@storybook/blocks: 8.2.2 => 8.2.2
@storybook/react: 8.2.2 => 8.2.2
@storybook/react-vite: 8.2.2 => 8.2.2
@storybook/test: 8.2.2 => 8.2.2
@storybook/test-runner: 0.19.0 => 0.19.0
chromatic: 11.5.4 => 11.5.4
eslint-plugin-storybook: 0.8.0 => 0.8.0
msw-storybook-addon: 2.0.3 => 2.0.3
storybook: 8.2.2 => 8.2.2
storybook-addon-manual-mocks: 1.0.4 => 1.0.4
storybook-addon-remix-react-router: 3.0.0 => 3.0.0
storybook-builder-rsbuild: 0.0.7 => 0.0.7
storybook-react-rsbuild: 0.0.7 => 0.0.7

Ah I've just seen https://github.com/JesusTheHun/storybook-addon-remix-react-router/pull/55 so I guess it's not so simple...

@abenhamdine you guessed right, it's not so simple to remove it. Also, that's the path forward with javascript, so I don't plan going back on this. I'm going to close this as there is nothing I plan to do, and you can re-open it if you have some new information.

I understand, no problem, thx for your reply !

For future readers :  a workaround is to compile this addon with rsbuild, with the following config :
rsbuildFinal: (config) => {
    return mergeRsbuildConfig(config, {
      source: {
        include: [
          /node_modules[\\/]storybook-addon-remix-react-router[\\/]dist[\\/]index.js/
        ]
      }
    })
  },


Rework Pulsar NOTICE file

Feedback from IPMC :
Also the binary NOTICE needs a little work and incorrectly lists bundled projects copyrights, only relocated copyright statements or those mentioned in NOTICE files need to be included in NOTICE. It also has the incorrect year. Be great if you could fix this up for the next release.

This NOTICE file was already reworked.


Decorations disappear when scroll bar thumb fades

Is the thumb fading to the opaque bg color instead of fully transparent?

setting the z-index of xterm-decoration-overview-ruler to 50 fixes the issue

I looked into it as well just now, starting to think it's not possible without a non-native scroll bar. Wouldn't be surprised if it's different on different browsers too.

A high z-index seems to fix it, that didn't work for you? We just need to make sure to add pointer-events: none as well.
It's not perfect as then it's different to the editor, but it's a very subtle difference.


chore: bdd-gh-1585242238 to 0.0.2

chore: Promote bdd-gh-1585242238 to version 0.0.2

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


java 9 build failed

The datetimeformatter fail on the zoned date time. looks like a java9 bug. filled a bug report.

need to test of b66 apparently fixed

http://bugs.java.com/bugdatabase/view_bug.do?bug_id=8080644

tests passes with jdk9-b72!


Add Prim's algorithm

(Put an X inside the [ ] to denote check mark [X].)

[X] If creating a new file :

[X] added links to it in the README files ?
[ ] included tests with it ?
[X] added description (overview of algorithm, time and space compleixty, and possible edge case) in docstrings ?

[ ] if done some changes :

[ ] wrote short description in the PR explaining what the changes do ?
[ ] Fixes #[issue number] if related to any issue

[ ] other

Pull Request Test Coverage Report for Build 752

0 of 33 (0.0%)  changed or added relevant lines in 1 file are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-0.4%) to 71.162%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

algorithms/graph/prim.py
0
33
0.0%

Files with Coverage Reduction
New Missed Lines
%

algorithms/linkedlist/is_palindrome.py
1
93.33%

Totals

Change from base Build 750:
-0.4%

Covered Lines:
4306

Relevant Lines:
6051

💛  - Coveralls


Unread status [Chance]

Adding a read/unread status of a download would be nice. I often binge download stuff and end up not reading some because there are so many in the library
An option to show all/read/unread would also be nice if the status gets added
Note : implement with a "number of reads" counter and add a "sort by number of reads" filter

This issue was moved to avluis/Hentoid#204


WIP:Feat(taskRun): make Entrypoint image configurable

Load entrypoint image configuration dynamically for the controllers.
Fixes #203

Test load configuration dynamically in my cluster:
Change the config map config-entrypoint without restarting the controller
...
{"level":"info","logger":"controller.taskrun-controller.config-store","caller":"configmap/store.go:166","msg":"taskrun config \"config-entrypoint\" config was added or updated: &{test.caicloudprivatetest.com/knative/pipeline-entrypoint}","knative.dev/controller":"taskrun-controller"}
...

Thanks for reviewing, i will address these comments as soon as possible.

Thanks for reviewing, i will address these comments as soon as possible.

Thanks @zhujian7 ! Let us know when you would like us to take another look :D

I test the feature in my own cluster, and it works well. But some test cases failed.

Have fixed.

Would you be able to add some docs about how to use this in our docs about the entrypoint override

I tried my best, but i need help in english(please correct me) :D

Is it possible to update the commit messages with a bit more information about why this commit is happening

I wrote some information about why this commit is happening in the commit message's body.
@bobcatfish @pivotal-nader-ziada PTAL

Hi @zhujian7
Thanks so much for the updates and working on this PR
Do you mind resolving the merge conflicts so we can run the tests?

Thanks @zhujian7
/ok-to-test

@ImJasonH it was Jian idea to build this infrastructure similar to serving and since it's more generic and configurable, we were okay with merging it in and maybe looking at simplifying things in the future, @zhujian7 what do you think of Jason's approach?
Also @zhujian7 I didn't realize the StatsReporter is now mandatory in the controller with the new version vendored in, in that case, its better to keep it then to put an empty one! Sorry about that

@ImJasonH it was Jian idea to build this infrastructure similar to serving and since it's more generic and configurable, we were okay with merging it in and maybe looking at simplifying things in the future, @zhujian7 what do you think of Jason's approach?

Consistency with Serving sounds like a useful goal. Can you link to where Serving does this, so I can learn more? I don't know if Serving has any common configurable sidecar images that it builds itself like we would.
It sounds like our options are:

do the complex-but-consistent-with-Serving thing and use config maps, then simplify over time as we find it necessary/possible, or
do the simple-and-consistent-with-Build thing and use flags, then migrate toward what Serving does as we find it necessary/possible.

Between those two, I slightly prefer (2), but if there's significant sentiment the other way that's fine too.

@ImJasonH I believe this change is inspired by this in serving
https://github.com/knative/serving/blob/c92f92076a32653bb4c377990ca1079b1bbdd207/pkg/reconciler/v1alpha1/route/config/store.go#L50
Its not exactly an image, but Jian is following the same pattern.
I usually prefer to do the simplest option and only add to it if there is a need, but also wanted to let @zhujian7 decide what he prefers

do the complex-but-consistent-with-Serving thing and use config maps, then simplify over time as we find it necessary/possible, or
do the simple-and-consistent-with-Build thing and use flags, then migrate toward what Serving does as we find it necessary/possible.

@pivotal-nader-ziada @ImJasonH Sorry for my late. Thanks @ImJasonH for providing your points.
I submitted this PR just want to pull an entrypoint image from my own local docker registry. And I think the two options are acceptable.

Also @zhujian7 I didn't realize the StatsReporter is now mandatory in the controller with the new version vendored in, in that case, its better to keep it then to put an empty one! Sorry about that

I tried to put an empty one, but unfortunately, it panics while running the controller.
And @pivotal-nader-ziada Thank you very, very much, again. Thanks for your patience, I am very appreciated.

Thank you @zhujian7 for the PR and for your patience with comments, would you please revert the last commit removing the StatReporter except for the removal of the unused variable

would you please revert the last commit removing the StatReporter except for the removal of the unused variable
@pivotal-nader-ziada Have done, PTAL

/lgtm
/approve

Thanks again for taking care of this @zhujian7 !! :heart:
And p.s.


Sphinx build failing

See https://github.com/asciineuron/bgls/actions/runs/7037869959/job/19153875759. @chiragbhansali can you take a look? :)

@rmlarose Will do

The issue is with numba, which is required by the quimb package. As per this post, numba doesn't support Python 3.10.0, which is what we are using across the repo


Roll engine 7c702404b820..7d97afd8a371 (3 commits)

https://github.com/flutter/engine/compare/7c702404b820...7d97afd8a371
git log 7c702404b820c670cda34b564ac3f8c0b914f40e..7d97afd8a37100d9d87d2146fe9256206249fdee --no-merges --oneline
7d97afd8a Roll src/third_party/skia 37064c1739f3..be39f713e530 (7 commits) (flutter/engine#7757)
3bfd26505 Add flutter config to macOS targets (flutter/engine#7756)
4d3a11227 Document GPUSurfaceGLDelegate methods and move it to its own file. (flutter/engine#7755)
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (chinmaygarde@google.com), and stop
the roller if necessary.

Trybots failed. These were the failed builds: https://cirrus-ci.com/task/5858376941568000

Commit queue failed; closing this roll.


Instructions to integrate with Saleor?

Is your feature request related to a problem? Please describe.
I want to integrate this frontend with Saleor
Describe the solution you'd like
A simple readme with how to get started would be great!
Otherwise, just some resources on how to get started will also do.
Describe alternatives you've considered
I've tried to have a look at config.js, but I guess this frontend is using a REST API and Saleor uses GraphQL, I'm new to GraphQL and can't figure out the integration.

Hello Rohan,
You may need to use https://github.com/timhall/svelte-apollo

Hello Rohan,
You may need to use https://github.com/timhall/svelte-apollo

Thanks!


Refactor Segment creation to use TransformPipeline too

Description

Following previous PR https://github.com/apache/pinot/pull/8335 to reuse the TransformPipeline in two other places.

Because of potential circular dependency issue, move the  TransformPipeline class from pinot-core into pinot-segment-local.
Refactor SegmentIndexCreationDriverImpl to use the TransformPipeline too
Refactor the RecordReaderSegmentCreationDataSource to use the TransformPipeline

Upgrade Notes
Does this PR prevent a zero down-time upgrade? (Assume upgrade order: Controller, Broker, Server, Minion)

[ ] Yes (Please label as backward-incompat, and complete the section below on Release Notes)

Does this PR fix a zero-downtime upgrade introduced earlier?

[ ] Yes (Please label this as backward-incompat, and complete the section below on Release Notes)

Does this PR otherwise need attention when creating release notes? Things to consider:

New configuration options
Deprecation of configurations
Signature changes to public methods/interfaces
New plugins added or old plugins removed

[ ] Yes (Please label this PR as release-notes and complete the section on Release Notes)

Release Notes

Documentation

cc @npawar The PR for the follow up

Codecov Report

Merging #8364 (a9e0059) into master (7c54ca6) will increase coverage by 0.26%.
The diff coverage is 34.45%.

:exclamation: Current head a9e0059 differs from pull request most recent head fc6db35. Consider uploading reports for the commit fc6db35 to get more accurate results

@@             Coverage Diff              @@
##             master    #8364      +/-   ##
============================================
+ Coverage     69.48%   69.75%   +0.26%
- Complexity     4251     4273      +22
============================================
  Files          1637     1640       +3
  Lines         85796    85933     +137
  Branches      12906    12913       +7
============================================
+ Hits          59616    59942     +326
+ Misses        22020    21832     -188
+ Partials       4160     4159       -1

Flag
Coverage Δ

integration1
28.90% <0.00%> (?)

integration2
?

unittests1
66.98% <78.46%> (+0.04%)
:arrow_up:

unittests2
14.21% <0.00%> (+<0.01%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...manager/realtime/LLRealtimeSegmentDataManager.java
69.57% <ø> (-0.14%)
:arrow_down:

...gin/stream/kinesis/server/KinesisDataProducer.java
0.00% <0.00%> (ø)

...eam/kinesis/server/KinesisDataServerStartable.java
0.00% <0.00%> (ø)

...he/pinot/segment/local/utils/TableConfigUtils.java
65.34% <30.00%> (-0.80%)
:arrow_down:

...ache/pinot/segment/local/utils/IngestionUtils.java
25.00% <66.66%> (+5.74%)
:arrow_up:

...ocal/recordtransformer/ComplexTypeTransformer.java
58.57% <78.57%> (+2.89%)
:arrow_up:

.../pinot/segment/local/segment/creator/Fixtures.java
100.00% <100.00%> (ø)

...creator/RecordReaderSegmentCreationDataSource.java
75.86% <100.00%> (+4.80%)
:arrow_up:

...gment/local/segment/creator/TransformPipeline.java
91.42% <100.00%> (ø)

...t/creator/impl/SegmentIndexCreationDriverImpl.java
84.75% <100.00%> (+1.14%)
:arrow_up:

... and 177 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c54ca6...fc6db35. Read the comment docs.


Add optional support for SonarQube Integration

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Most CI/CD systems will have integration to continous code quality systems namely SonarCube. This PR adds SonarCube integration for Angular 4 projects .

What is the current behavior? (You can also link to an open issue here)

N/A

What is the new behavior (if this is a feature change)?

Optional installation notes for SonarCube integration have been added . This feature will push code quality matrix to SonarCube based on linting , coverage etc.

Other information:
Here are some sample screenshots

Angular Starter project dashboard

Quality Metrics

A simulated lint issue added to view results on SonarCube

Added support for unit test results as well

this is really kool

can you redo the PR? and make it optional?

@gdi2290 sure .. will take the latest version and make that change ..

While I am at it found another issue related to a corejs warning (https://github.com/angular/angular/issues/20357)
We get this error during the tests
WARNING in<EMAIL_ADDRESS>6581:15-36 Critical dependency: the request of a dependency is an expression
<EMAIL_ADDRESS>@ ./src/app/app.component.spec.ts
@ ./src .spec.ts
@ ./config/spec-bundle.js
WARNING in<EMAIL_ADDRESS>6601:15-102 Critical dependency: the request of a dependency is an expression
<EMAIL_ADDRESS>@ ./src/app/app.component.spec.ts
@ ./src .spec.ts
@ ./config/spec-bundle.js
Solution:
https://github.com/gdi2290/angular-starter/commit/268f54ae499eb1727f6ca326bce1b769c45f7873

One more point .. Can we add   browserNoActivityTimeout: 30000 in the karma.conf.js .. (increase from the default to 3x the value)
For slower machines we do run into this issue at times ...

@gdi2290 I have made the required changes for making SonarQube optional. We need to use npm test:sonar for generating the sonar reports. Also updated the README for the same.

@gdi2290 I have merged by changes again with the latest. Do let me know if anything else is required


Macro for installing conan

Hi,
I was wondering if there is any reason why there is no install_conan() macro (similar to run_vcpkg() )?
Sometimes I use machines that do not have conan installed and it will be nice to have an option to install it automatically.
(If my suggestion is acceptable I already have some macro I use, And I would very much like to port it to project_options)

Upvote & Fund

I am using Polar.sh so you can upvote and help fund this issue. The funding is received once the issue is completed & confirmed by you.

Thank you in advance for helping prioritize & fund our backlog.

There is, but not documented. We should document it.
run_conan()

What I mean is installing conan - the actual command (e.g pip install conan)
It seems like run_conan() only installs conan-cmake

For installing the development tools (e,g. Conan itself), we use setup-cpp.

I considered to add a macro to install conan before. However, conan depends on python, which makes it difficult for me to find the appropriate behaviour of this macro:

If there's no python installed, should we install python and then install conan, or simply issue an error to inform the user to install python?
If we only support conan installation for those who installed python, why don't we also issue an error to install conan instead?

This is quite tricky for both usage and documentation. As a result, I choose not to support any level of conan automatic installation.


Verification Email Links

Looks like when verifying emails, the email sent still has links to comicsgamesandthings.com rather than valhallahobby.com

Somewhat related to other issues on loading the default site (#38),
The default site was set to site 1, which is configured for the old settings on  cg&t . I've added a setting to override the default site, so it can be configured to now return Valhalla Hobby.


get argument

how to get argument from start key like this bot https://telegram.me/EvandBot?scope=&redirect_uri=https%3A%2F%2Fevand.com%2Fauth%2Foauth
?

hmm ... you have to do something tricky ..
here is the example:
user should start the bot via this url: http://t.me/botname?start=12345
require 'telegram/bot'

token = 'SECRET_BOT_TOKEN'
Telegram::Bot::Client.run(token) do |telegram_bot|
	telegram_bot.listen do |message|
		case message.text
		when '/start'
			p "user was clicked the start button"
			p message.text
		else
			p "user typed something else ..."
			p message.text
		end
	end
end

and here is the result of our code:
> "user typed something else ..."
> "/start 12345"

i hope you've found the answer


feat(build): Enables hermes

This PR resolves PHIRE-415
Description

Enables hermes on iOS and android.
Adds @babel/plugin-transform-named-capturing-groups-regex to our babel config and devDeps as suggested here to prevent android crashes

Adds build scripts in steps similarly as we have in eigen:

bundle:android:hermes - Bundle bytecode
bundle:android:js - Bundle JS
bundle:android:sourcemap - generate sourcemap
bundle:ios:hermes - Bundle bytecode
bundle:ios:js -  Bundle JS
bundle:android:hermes - generate sourcemap

Follow ups - QA plan

check that sentry works by triggering the errors from dev menu in both platforms

✅ iOS tested successfully on beta ios-3.0.0-2<IP_ADDRESS> stacktrace works as expected (sentry event here)
✅ Android tested successfully on beta android-3.0.0-167 stacktrace works as expecte4d (sentry event here)

PR Checklist

[x] I have tested my changes on iOS and Android.
[x] I have included screenshots or videos, or I have not changed the UI.
[x] I have added tests, or my changes don't require any.
[x] I added an app state migration, or my changes do not require one.
[x] I have documented any follow-up work that this PR will require, or it does not require any.

To the reviewers 👀

[ ] I would like at least one of the reviewers to run this PR on the simulator or device.

Need help with something? Have a look at our docs, or get in touch with us.

~ do not merge yet there might be a slight issue that I am looking into right now ~

tested successfully on both - merged! QAed during Mobile Office Hours - thanks @MrSltun


charts/timesketch remove deprecated config file

Description of the change
Hot patch to fix config being removed in latest PR: https://github.com/google/timesketch/pull/2913
Checklist

[ x] Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
[ x] Variables are documented in the values.yaml and added to the README.md usingreadme-generator-for-helm
[ x] Title of the pull request follows this pattern [charts/<name_of_the_chart>] Descriptive title

FYI @jkppr


Language support

Is there ever going to be update so it work with languages other then English :)

There is already support for archives in a number of languages other than English (see here). Which language are you looking for support for?

I really need support for Serbian (Cyrillic and Latinic ). Thanks for help btw :)

Does Facebook actually support Cyrillic or Latin for the Serbian language? I can't find either in the list of supported languages. Closest I can find is Croatian.

Yup. Latinic is not listed. We use Cyrilic and Latinic both in our language but when you want to use serbian language somewhere on internet you only have Cyrilic as supported language (in 99% cases), so yes that was my bad sorry . :)

Oh okay. This parser itself actually supports all languages in terms of actual message text, and support just needs to be added to parse the time stamps, which Facebook translates into whatever your locale is.
I have added support for Croatian (I'm assuming at least some Serbians who want the Latin standard use this), but I cannot download any samples with Cyrillic due to Facebook only letting you download your data approximately once per day.
If you already have your data downloaded for Serbian (Cyrillic), would you mind running the following and post the output?
$ fbcap messages.htm
It should crash and give a sample Serbian time stamp I can work with to add proper support.

Discovered chat thread with [...........................(i hope this doesnt metter :) )]...
Unexpected time format in "четвртак 24. новембар 2016. у 20:11 UTC+01". If you downloaded your Facebook data in a language other than English, then it's possible support may need to be added to this tool.
Please report this as a bug on the associated GitHub page and it will be fixed promptly.
There you go .

Okay, thanks for providing that. I think I have fixed it. Please try the new version I just posted: 0.9.post29

Now i got this.. :/
Discovered chat thread with [.........................................................................]...Traceback (most recent call last):
File "c:\program files\python36\lib\runpy.py", line 193, in _run_module_as_main
"main", mod_spec)
File "c:\program files\python36\lib\runpy.py", line 85, in run_code
exec(code, run_globals)
File "C:\Program Files\Python36\Scripts\fbcap.exe_main.py", line 9, in
File "c:\program files\python36\lib\site-packages\fbchat_archive_parser\main.py", line 188, in main
app.run()
File "c:\program files\python36\lib\site-packages\clip.py", line 652, in run
self.invoke(self.parse(tokens))
File "c:\program files\python36\lib\site-packages\clip.py", line 634, in invoke
self._main.invoke(parsed)
File "c:\program files\python36\lib\site-packages\clip.py", line 519, in invoke
self._callback(**{k: v for k, v in iteritems(parsed) if k not in self._subcommands})
File "c:\program files\python36\lib\site-packages\fbchat_archive_parser\main.py", line 125, in fbcap
fbch = parser.parse()
File "c:\program files\python36\lib\site-packages\fbchat_archive_parser\parser.py", line 107, in parse
self._parse_content()
File "c:\program files\python36\lib\site-packages\fbchat_archive_parser\parser.py", line 133, in _parse_content
self._process_element(pos, element)
File "c:\program files\python36\lib\site-packages\fbchat_archive_parser\parser.py", line 262, in _process_element
parse_timestamp(e.text, self.use_utc, self.timezone_hints)
File "c:\program files\python36\lib\site-packages\fbchat_archive_parser\time.py", line 226, in parse_timestamp
timestamp = date_parser.parse(timestamp_string)
File "c:\program files\python36\lib\site-packages\fbchat_archive_parser\time.py", line 93, in parse
return self._parse_fallback(timestamp)
File "c:\program files\python36\lib\site-packages\fbchat_archive_parser\time.py", line 87, in _parse_fallback
locale=self.locale_id).datetime
File "c:\program files\python36\lib\site-packages\arrow\api.py", line 23, in get
return _factory.get(*args, **kwargs)
File "c:\program files\python36\lib\site-packages\arrow\factory.py", line 198, in get
dt = parser.DateTimeParser(locale).parse(args[0], args[1])
File "c:\program files\python36\lib\site-packages\arrow\parser.py", line 55, in init
self.locale = locales.get_locale(locale)
File "c:\program files\python36\lib\site-packages\arrow\locales.py", line 20, in get_locale
raise ValueError('Unsupported locale '{0}''.format(name))
ValueError: Unsupported locale 'hr_hr'

Ah, had a bug. I fixed it in 0.9.post31, but it will crash again because the parser is likely not recognizing the name of a month. This is due to Facebook frequently using the wrong inflection in dates in Slavic languages. I can fix this, however, I require another sample. Facebook doesn't want to let me re-download my own data in Serbian.
Please try running again and report the error it prints out.

Sorry but i am kinda new in github. How do i get that version?
Should i just redownload and install it again or?

Oh, actually, I think everything should work fine now.
Not sure how you installed, but if you used pip you can get the latest version by doing pip install fbchat-archive-parser --upgrade.


Add pre-commit to Travis job

As discussed in #160, instead of calling flake8 directly or from tox, if we call pre-commit run --all-files we take advantage of all the other checks in pre-commit (see .pre-commit-config.yaml for a list), which is even nicer.
Of course, a little round of minor changes in the current files to adequate them to the conventions coded in the config files (such as .isort.cfg) was necessary, but the good part is that, with the result, if the contributor follows all the steps in the CONTRIBUTING.rst file, no surprises will appear (such as a failing pre-commit hook), and the coding conventions will be always consistent.
I also updated the format of the .pre-commit-config.yaml  to the latest version, and configured a list of paths that are not part of the project itself to be ignored in all the checks.

Coverage decreased (-0.02%) to 96.53% when pulling b2cac81c435cc841d8966ebb1029d5c19f8401df on abravalheri:add-pre-commit-to-travis into c65c54f7fc6608d288e874693d9b226b74ff6c0c on blue-yonder:master.

@abravalheri, cool! Thank you.


[Bug]: Coolify Proxy is messed up if you restart Coolify

Is there an existing issue for this?

[X] I have searched the existing issues

Example public repository
coolify
Description
For whatever reason whenever you try to restart coolify the coolify instance either detaches from the proxy or just doesn't work properly anymore. It ends up throwing error:
Coolify Proxy Error

PS : I am on ARM ( ORACLE ARM SERVER )
Steps To Reproduce

Go to settings, Restart Coolify
Coolify no more reachable through defined FQDN

Version
3.12.32

Can confirm this is mostly the only thing holding me back from using it and moving from dokku.
It seems that the container stops and never starts again and or gets removed coolify-proxy

This is mostly because of the Live Restore functionality.
You can disable it manually in /etc/docker/daemon.json and restart Docker Engine (it could interrupt your currently running containers!)


[1.15.2] Chunk Loading Setting Inconsistencies

There's some weirdness around the chunk loading setting for points and plugs. However, this may be due to my own ignorance around chunk loading. In some cases, I can turn chunk loading on for both the point and plug in the same chunk. Now, my understanding is that chunks stretch all the way up and down, so if instead, they only stretch up and down 16 blocks, then that may be the issue. But in some cases, this is allowed, and in some cases, I get an error saying "The server rejected some settings."
https://github.com/SonarSonic/Flux-Networks/blob/3781383a99d200e875128485889eb0f5c1267c46/src/main/java/sonar/fluxnetworks/common/network/BatchEditingPacket.java#L135

Fixed and improved in 1.16.4

This feature may be backported to 1.15 if I'm available


Ignore Ruby Version and Gemset for RVM

I found this commented in .gitignore. Can I ignore those files? I like to keep my local env organized.
# for a library or gem, you might want to ignore these files since the code is
# intended to run in multiple environments; otherwise, check them in:
# Gemfile.lock
# .ruby-version
# .ruby-gemset

Makes no difference to me. @doomspork?

Open a PR :+1:

I don't fully understand this issue. Wouldn't it be better if just you uncomment those files in your local without affecting the whole repo? Or is it a real need for the repo? :shipit:

@setzer777 you make a good point.  It's certainly not a repo need, though I am willing to consider small changes that make it easier for contributors.  Do you have concerns?

@doomspork Small changes in the .gitignore? or which kind of changes?

@setzer777 adding .ruby-version and .ruby-gemset (not Gemfile.lock).  Many Ruby developers rely on them and they're not included in this project.  I suspect for folks like @pragmaticivan it's annoying having to remember to not commit those files.

Going to close this.  @pragmaticivan feel free to open a PR for further discussion.
Thanks!


Allow unused tokens

If I have this token type:
pub enum Token {
    LParen,
    RParen,
    Var,
}

and don't use the Var token in my parser:
parser! {
    enum Token {
        "(" => Token::LParen,
        ")" => Token::RParen,
    }

    pub Entry: usize = {
        <test:Test> => test,
    };

    Test: usize = {
        "(" <t:Test> ")" => t + 1,
        => 0,
    };
}

I get a compile error in generated code, with a terrible "help":
error[E0004]: non-exhaustive patterns: `&Var` not covered
  --> src/main.rs:21:10
   |
21 |     enum Token {
   |          ^^^^^ pattern `&Var` not covered
   |
note: `Token` defined here
  --> src/main.rs:8:5
   |
5  | pub enum Token {
   |          -----
...
8  |     Var,
   |     ^^^ not covered
   = note: the matched value is of type `&Token`
help: ensure that all possible cases are being handled by adding a match arm with a wildcard pattern or an explicit pattern as shown
   |
23 ~         ")" => Token,::LParen,
24 ~         &Var => todo!()::RParen,
   |

The problem is in the token_value function that we generate to extract values (fields) of tokens and convert them to SemanticActionRersult type: (which should probably be called "value", as it defines the values for the value stack)
fn token_value(token: &Token) -> SemanticActionResult {
    match token {
        Token::LParen => SemanticActionResult::Token0(),
        Token::RParen => SemanticActionResult::Token1(),
    }
}

Here unused tokens are not matched, causing the non-exhaustive pattern match error.
I think we should be able to just add a _ => unreachable!() at the end here. We should also probably add #[inline(always)] as in the call sites this function will be called after the next token matches a pattern with the token, so the constructor is always known, and the compiler should be able to easily eliminate this match expression using the known shape (constructor) of the token.

We also generate a function that maps tokens to terminal indices:
    fn token_terminal_idx(token: &Token) -> usize {
        match token {
            Token::LParen => 0usize,
            Token::RParen => 1usize,
            Token::Backslash => 2usize,
            Token::Dot => 3usize,
            Token::Colon => 4usize,
            Token::Arrow => 5usize,
            Token::Top => 6usize,
            Token::Bot => 7usize,
            Token::Id(_) => 8usize,
        }
    }

These indices are then used to index the action table, and the table that maps tokens to their strings used in error messages.


Add kAbandonPartialAggregationMinMemory config for partial aggregation flush

To fix https://github.com/facebookincubator/velox/issues/6035, add kAbandonPartialAggregationMinMemory config for partial aggregation flush. With this config, abandonPartialAggregationEarly can be set as true only when the allocated memory is larger than this limit.

@PHILO-HE Could you help review? Thanks.

@mbasmanova Could you help review? Thank you.


官网示例出现 Uncaught ReferenceError: $ is not defined     at tree-vertical.html:23

Version
4.2.1
Steps to reproduce
并不清楚所用的echarts版本, 但代码是官方的
从官网下载示例 https://echarts.apache.org/examples/en/editor.html?c=tree-vertical, 换用自己的ak, 出现错误

Uncaught ReferenceError: $ is not defined
    at tree-vertical.html:23

What is expected?
期望出现官网的效果
What is actually happening?
一直loading

@OpenWaygate how do you resolve?


Can't deploy OpenMetadata on standard google kubernetes engine

Affected module
Ingestion, airflow
Describe the bug
Currently following https://docs.open-metadata.org/deployment/kubernetes is not working on standard GKE due to the fact that airflow requires a persistent disk with ReadWriteMany access mode.
the workaround is described here https://github.com/nabilm/openmetadata-gke
To Reproduce
Follow https://docs.open-metadata.org/deployment/kubernetes
Expected behavior
Airflow gets successfully on standard google Kubernetes engine cluster
Version:
all versions
Additional context
An automated fix using terraform, Kubernetes manifest need to be present

Closing this issue as we documented the steps to configure OpenMetadata Helm Charts on GKE.
Thank you @nabilm for amazing contribution.


set skew in CARP manually

Is your feature request related to a problem? Please describe.
I want to transfer from pfsense to opnsense. I used 2 vitural machine in 2 different computers to do CARP . I have 2 internet service, one for each machine .I use two CARP IPs as load balancing .
OPNSENSE lan IPs:
<IP_ADDRESS>
<IP_ADDRESS>
CARP IPs:
<IP_ADDRESS> means <IP_ADDRESS> as master
<IP_ADDRESS> means <IP_ADDRESS> as master
My use case:  one computer is using <IP_ADDRESS> as gateway. Downloading at max speed.  other computers is using <IP_ADDRESS> as gateway. And they are not affected by that computer's downloading.

If I understand it correctly
advbase:
Specifies the base of the advertisement interval in seconds. The acceptable values are 1 to 255.
is only set the Advertising frequency not how important the firewall is
Somehow I can set the value higher. And it seems to be working as I wanted .But it is wrong
If i do a HIGH AVAILABILITY sync the backup's skew will become 100. So skew is an important number but currently not allow user to set it manually

Describe the solution you like
add this option as in pfsense.And after some rearch it was possible to do this in opnsense before .But it is removed in the latest version

https://youtu.be/-fR3ULmaM-c?si=dhEUugcCosPJTI_s
Additional context
Add any other context or screenshots about the feature request here or links to relevant forum thread or similar

advanced mode?

advanced mode?

I did not see that .thanks.

close?

close?

yes


Unable to index compressed pages

How do you index compressed html files?
I have a large static site with around ~100k html files. My static site generator outputs gzipped compressed html files, which get uploaded to S3. The compression saves a ton of money a month on hosting costs, and every modern browser than auto-detect and depress gzipped html files, so it's a necessary publication format.
However, I'm walking through you getting started docs and npx pagefind is failing when it tries to walk my build directory:
Running Pagefind v0.9.1 (Extended)
Running from: "/var/project"
Source:       "build"
Bundle Directory:  "_pagefind"

[Walking source directory]
Found 90544 files matching **/*.{html}

[Parsing files]
Did not find a data-pagefind-body element on the site.
↳ Indexing all <body> elements on the site.
90544 pages found without an <html> element.
Pages without an outer <html> element will not be processed by default.
If adding this element is not possible, use the root selector config to target a different root element.

[Reading languages]
Discovered 0 languages:

[Building search indexes]
Total:
  Indexed 0 languages
  Indexed 0 pages
  Indexed 0 words
  Indexed 0 filters
  Indexed 0 sorts
Error: Pagefind wasn't able to build an index.
Most likely, the directory passed to Pagefind was empty or did not contain any html files.

So it looks like it's seeing my files but not finding any  tags, even though each page definitely contains an  tag. Why is this?
My build directory isn't flat and is structured like:
build
    category1
         subcategory1
             index.html
         subcategory2
             index.html
         subcategory3
             index.html
          ...
     ...

Is it failing to find any files because of my structure, or because of the gzip compression?
Either way, how would I resolve this?
For practicality reasons, I'm unable to change the folder structure nor remove gzip compression.

Hi @chrisspen 👋
As of Pagefind v0.9.2, gzipped files will be handled automatically. Let me know how that goes — curious to hear what the indexing speed is like with this update.

Thanks, that's great. Is there any special requirement to activate the decompression?
I upgraded to 0.9.2 and disabled the decompression in my named pipes, so pagefind sees the raw gzip data, but it reports it now can't see any  tags:
[Walking source directory]
Found 679 files matching **/*.{html}

[Parsing files]
Did not find a data-pagefind-body element on the site.
↳ Indexing all <body> elements on the site.
679 pages found without an <html> element.
Pages without an outer <html> element will not be processed by default.
If adding this element is not possible, use the root selector config to target a different root element.

If I test the file like cat path/to/my/compressed/file.html | gunzip it outputs valid html, containing an  tag.
Is Pagefind expecting the file to end with a .gz extension?

Hmm, no special handling needed, it should all be automatic. For reference, this is the test case:
https://github.com/CloudCannon/pagefind/blob/dfb07b09939b934664bed7a6986b03791fd35994/pagefind/features/input_quirks.feature#L11-L33
It seems to be working fine for me if I test it on my machine: https://app.warp.dev/block/2DI0I35XdrdS8ANfqBShn0

Could you paste in what the output of the following is?
head -c 3 path/to/my/compressed/file.html | hexdump

Perhaps Pagefind isn't recognizing the gzip header

0000000 8b1f 0008
0000003

Hmm, that looks correct. [^1]
Unfortunately that means I might need to debug. Would you be willing to provide:

An example compressed source file that isn't working
The command/library you're using to compress files
Information on the os + arch you're running Pagefind on?

[^1]: Well I was actually looking for 1f 8b 08 but I believe 8b1f 0008 is how it will appear with two-byte grouping (or on a big-endian system..?)

I'll check. It might be a bug on my end.

Hi @chrisspen — did you track this down on your end?

No, but I can't formula a MRE to send you either. I'd consider this issue resolved for now.


Having an issue with Byte[] input.

So my big idea is to try and capture frames from camera preview, and do OCR on the fly!
However when I pass in the byte array for the current frame:
               await _Api.SetImage(imageBytes);

It essentially hangs and doesn't return.
Does this Byte array need to be encoded before I pass it in? Any ideas on why it might hang?
My code is doing this:

            _Camera = Android.Hardware.Camera.Open();
            _Camera.SetPreviewCallback(this); // the call back method is OnPreviewFrame, below.
            _Camera.StartPreview();
...
        public void OnPreviewFrame(byte[] data, Android.Hardware.Camera camera)
        {
            // data is the bytes representing the current frame.
            var text = GetText(data).Result;
        }
        public async Task<string> GetText(byte[] imageBytes)
        {
            // todo: call web api, send image, and get back text.
            try
            {
                EnsureInitialised();
                await _Api.SetImage(imageBytes); /// this hangs
                // await api.SetImage(imagePath);
                string text = _Api.Text;
                return text;
            }
            catch (Exception ex)
            {
                throw;
            }
        }
    }

Any help or advice is much appreciated.

I've asked this on stackoverflow as well: http://stackoverflow.com/questions/30920675/camera-preview-and-ocr?noredirect=1#comment49878574_30920675

There is an answer there. Being honest I didn't play much with byte array format as I use XLabs MediaService to get images from camera and it returns stream or file name. Will try using camera directly today.

So apparently the byte[] data coming from the camera preview is YuvImage format. So I am now doing this to convert it to JPEG:
  public byte[] TranscodeImageBytesToJpeg(byte[] imageBytes, Android.Hardware.Camera camera)
        {
            var parameters = camera.GetParameters();
            int width = parameters.PreviewSize.Width;
            int height = parameters.PreviewSize.Height;

            Rect rect = new Rect(0, 0, width, height);
            YuvImage yuvimage = new YuvImage(imageBytes, ImageFormatType.Nv21, width, height, null);

            using (MemoryStream memStream = new MemoryStream())
            {
                if (yuvimage.CompressToJpeg(rect, 100, memStream))
                {
                    return memStream.ToArray();
                }
                throw new InvalidOperationException("Could not compress camera to Jpeg");
            }

        }

Now interestingly, If i pass this new byte[] directly to SetImage() - it still hangs.
However, if i write the byte[] data as is, to a file on disk, and then call the SetImage() with the filepath overload - it runs ok. It gives me back gibberish text but guessing that's just the quality of my image that I'm passing in (not very good). This does seem to suggest there may be something wrong with the byte array overload

Could you please give me an example of your image? I'll have a look. I'll check what's wrong with SetImage(byte[]).

Thank you!

Oh, this text is definitely not recognisable :)

haha yeah - definately not!

Did you get the image file ok?

Yes.

Cool beans :)


Hound: Disable scss.

Refs #24225

How trivial is it to setup stylelint to report back via CI instead of code review like Hound?

Are you able to clarify what you're trying to achieve here? You're spawning three separate Node 8 containers, two of which seem to do the same thing.

@mdo we're already doing that. Hound as an additional layer of linting is just being mad, presumably for the reason mentioned in https://github.com/twbs/bootstrap/pull/23572#issuecomment-333347685, and XhmikosR additionally says in #24225 that there may be some bugs in Hound's stylelint implementation.

From what I understand, Hound is using their own configs which is why this doesn't work properly.
@bardiharborow: this PR is just for testing crap.


Track Memory x Time metric for queries

This is analogous to cumulative CPU time, but would allow us to understand how much memory a query holds on to during its lifetime.

Merged #4293.


Build universal binaries for use on the macOS platform

Currently, OCIO's build system will build ARM libraries with the CMake option -DCMAKE_OSX_ARCHITECTURES=arm64.  However, attempting to build a universal binary using the =arm64;x86_64 option fails.  This task is to improve the build process to easily support macOS universal binaries (i.e., a library that will work on either Intel or ARM hardware).

Hi Doug, we're building OCIO 2.1.2 into USD universal binaries and aren't experiencing this issue.  Which version of OCIO are you seeing it on?

I also managed to build universal binaries in the past and that was used for Python wheels until recently. One thing I remember though is that at some point the SSE detection code started to break and try to use SSE for the ARM backend so I had to manually turn SSE off with OCIO_USE_SSE.

Thanks for the feedback @jonny-apple and @remia !  I logged this issue after doing a very quick test in 2.2.0.  Glad to hear it's working for you both.  Should be straight-forward to get this working.  I will reach out if we have any trouble, once we start actually working on this task.

The work for this was done in PR #1775.


feat: content type metadata support

Summary
Introduce metadata to the tool and support for annotations management
Description
Enable the tool to tolerate existing annotations on content type payloads.
Add functionalities to edit annotations assignments for content types and fields

Awesome. Just minor stuff left.

🙏🏼  Thanks for spotting those


Support ssl and ssl_opts connection options

What kind of change does this PR introduce?
This adds support for the ssl and ssl_opts Postgrex connection options.
What is the current behavior?
If a custom SSL cert is required then the connection will fail.
What is the new behavior?
Custom SSL certs can now be configured and used.
Additional context
Crunchy Bridge provides customers their own SSL PEM, and SSL is enforced with all db connections. This PR addresses issues with SSL details not being passed to Postgrex.

@Ziinc @filipecabaco sorry to ping you, I was wondering if this PR could be reviewed.
We have a change we are looking to merge into NervesHub (https://github.com/nerves-hub/nerves_hub_web/pull/1151) and it would be great to not use my fork.
p.s. such a god damn smart use of postgres for node discovery!

@joshk could you add in some docs around the ssl options and example usage, as well as bump the patch version?

Thanks for the quick reply @Ziinc
Done! Let me know if you want something with extra detail.

Awesome, thank you!

@Ziinc  Happy New Year!
any chance of having this merged?

hey! just a quick heads up that I'll review this one today. sorry for the delay 🙏

@filipecabaco  thanks for the quick reply!


Added an azure pipeline configuration file.

Since Azure Pipelines supports all os and has 10 concurrent jobs, I would like to try and see if it's easier to manage and if we get a faster CI system by doing that. Let's keep the other too for a while to see what we prefer.
You can see the build done on my fork here to get an idea of what the interface look like.

I don't have access to Sacred's settings, so I don't think I can enable azure pipelines myself. @Qwlouse if you have the time, could you look into it? You don't have to make a microsoft account, you can log into azure pipelines directly with your github account.

Done. Let's see if it works. :-)

Looks good. :rocket:
See e.g. https://dev.azure.com/qwlouse/Sacred CI/_build/results?buildId=2

Coverage remained the same at 85.306% when pulling 8c13ad7fe6c91b9cfbd869922b9022eb6a2579a0 on gabrieldemarmiesse:trying_azure_2 into d3fe102ff5e0dbe12e4b1735ec391f63e2ce7fb7 on IDSIA:master.


🐛

Area
Voting Pillar
Domain
preview.gov.tools
Which wallet were you using?
Latest Lace
Context
I am testing vote context submission. Any voter, it seems can provide 'context' without voting.
https://www.loom.com/share/3e2bdcd6bb6149cd9354a0c50a27caa9?sid=5ee3bc0c-59e0-437e-8297-1e1a4746f674
Steps to reproduce

Go to a Governance Action
Click "provide context about vote"
Follow the next steps,
return to vote
Your context seems to have been accepted but you DIDN'T VOTE.

Actual behavior
Users can provide context on vote without voting
Expected behavior
Users cannot provide context on vote without voting

This has not been implemented as per the Figma files. Here is the flow design: https://www.figma.com/design/mJTBiUofLfb74Xc3W2U59o/Voltaire---GOV-TOOL?m=auto&node-id=10191-87764&t=6ullviCCpsQajaY8-1


Support Digital level with software I2C

Abandoning this PR. Digital Level is very underused and code change is too old.


Immutable fields in Spec

Is your feature request related to a problem?
Currently many APIs have fields which are valid during creation but cannot be modified later. This can potentially create confusion as the resource would not be updated.
Example -
https://docs.aws.amazon.com/cli/latest/reference/elasticache/create-replication-group.html
In this ElastiCache API, --transit-encryption-enabled  , --at-rest-encryption-enabled are currently immutable.
Describe the solution you'd like
Validate if an immutable spec field is modified, then set appropriate condition.
Describe alternatives you've considered
Webhook to validate the immutable fields.

I believe this is done in https://github.com/aws-controllers-k8s/code-generator/pull/77 and https://github.com/aws-controllers-k8s/runtime/pull/17.
/close


typedoc@next

So I'm having some spare time which I'd like to devote to this project, since I will be needing it myself in the future and because it would be really great if the idea discussed in TypeStrong/discussions#3 got through with it. I know a bit of TypeScript's internals so at least there should be no problem. However, it will take me some time to get used to the code base. If it's ok I'll use this issue to track my progress.

This is rather off the record: I tampered with a small tool called ts-gen-transform to see if it is possible to autogenerate some of the boilerplate code that is there when creating reflections, but it was more about getting to know the TypeScript compiler than the actual result. I don't think it is of any use, but you never know.


feature/softmax: use an override CUDNNTensorDescriptor for 1-3D softmax

There were the following issues with your Pull Request

Commit: b77ba005d21f7e0622d6a59785b34228075edc7d
Invalid type. Valid types are feat, fix, docs, style, refactor, perf, test, chore, revert

Guidelines are available at https://github.com/autumnai/collenchyma-nn/blob/master/CONTRIBUTING.md#git-commit-guidelines

This message was auto-generated by https://gitcop.com

@homu r+

:pushpin: Commit b77ba00 has been approved by hobofan

:hourglass: Testing commit b77ba00 with merge f3c3900...

:sunny: Test successful - status


[Peek] Add Audio Previewer

Summary of the Pull Request
Add a new previewer that support audio files into Peek.

PR Checklist

[x] Closes: #25989
[ ] Communication: I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected
[ ] Tests: Added/updated and all pass
[x] Localization: All end user facing strings can be localized
[ ] Dev docs: Added/updated
[ ] New binaries: Added on the required places

[ ] JSON for signing for new binaries
[ ] WXS for installer for new binaries and localization folder
[ ] YML for CI pipeline for new test projects
[ ] YML for signed pipeline

[ ] Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments
This uses  file thumbnail to render the artwork and this choice could lead to unexpected behavior if users have different thumbnails on their system.
TODO

[x] Need WinAppSDK 1.5: https://github.com/microsoft/microsoft-ui-xaml/issues/916

Validation Steps Performed

Tested all the file extensions using sample files downloaded from the internet
Tested reaction to OS theme/accent change
Tested play/pause using space bar

We should show the format after the length. What do you think?

We should show the format after the length. What do you think?

The idea was to focus on audio related properties. Does it make sense?
This also have  the same tooltip used for images and videos with secondary info.

We should show the format after the length. What do you think?

The idea was to focus on audio related properties. Does it make sense?

Yes, it does.

Still a draft, so I've removed the label to revisit on 0.80 :)

Reviewed the PR and re-tested with all the file extensions: It's ready for review.

/azp run

Woow.. 😞
I can reproduce it also on 0.79.0 with Monaco and default previewer but I can't get what's going on.
I have noticed that it's not only the button but also the red area doesn't allow to drag the window.

It disappear after maximizing/restoring the window and it doesn't seems to affect Images 😮

I have pushed a work-around for the first Peek activation.
The problem is related to the code that "create" the draggable area of the custom title bar: it doesn't work well with the collapsed button (no default app to open the previewed file).
Note that the issue isn't fully fixed since also in 0.79, while navigating from a file to a folder, a non draggable area could be found in the button location (now hidden).
Hope this is clear! 😅

I have reverted the UpdateDragRegion change.
I have ready another PR that try to completely address the issue.


Use svg instead of png to get better image quality

Looks good to me, thanks!

Thanks for Nice and Informative Post. This article is really contains lot more information about This Topic.  -
Packers and Movers Chennai
Packers and Movers Hyderabad
Packers and Movers Mumbai
Packers and Movers Noida

This article is really fantastic and thanks for sharing the valuable post.
Packers and Movers Pune
Packers and Movers Bangalore
Packers and Movers Delhi
Packers and Movers Gurgaon

Thanks for sharing your info. I really appreciate your efforts and I will be waiting for your further write
Packers and Movers Faridabad
Packers and Movers Thane
Packers and Movers Navi Mumbai
Packers and Movers Ghaziabad

Thanks for post this helpful post - Please visit for More information about -
Packers and Movers Gurgaon
Packers and Movers Bangalore
Packers and Movers Hyderabad
Packers and Movers Pune


Can't change scheme

In Preferences => Editor => Colors & Fonts If I change scheme name and hit OK nothing happens in the editor.
Consulo 1.0 build #621

Hm. Try change it at root configurable.
Here

Hmm got it to work now when ticking 'Show only monospaced fonts'.
However, rendering of font (Source Code Pro) seems to be different.
Same settings (ignore the red underline)
Consulo:

Intellij:

Hm. Random bug - for me.

Maybe fix  - updated. In few minutes 622 will be available

U can check it at http://must-be.org/vulcan/

Fix help?

Nope. But I have gone through my Consulo download history and in build #610 there's no problem but in #618 the font rendering has changed.
#610:

#618:

Can I download older builds somewhere? Then I can try to track it down...

There no changes in render. But was changed Java options
https://github.com/consulo/consulo/commit/76fedbcc98e7ee7155c5aff05aba51164764bcc9
I think - was used Apple(or oracle) after this update, your consulo start with another JDK

Yes. Changing JVMVersion to 1.6* seems to fix it:
JVMVersion
1.6*

Can u show about screen ('Help->About') for 1.6* and 1.6+ ?

Sure!
1.6*:

1.6+:

I didn't know, until now, that I had JDK 1.8 installed. I thought I was on 1.7.

:smile:

Bug with color scheme exists?

No I can't reproduce it now.
Thanks for helping me track it down.


⚠ ClamAV has degraded performance

In 7bca0e7, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 69 ms

Resolved: ClamAV performance has improved in 73a57d4.


Sync lazarus project file flags with makefiles

Currently the building settings for lazarus and the ones used in the makefiles are different.
Work already started to resolve this. The makefile now outputs into the same folders (build/win32-i386 for example).
But further work is needed for both to use the same flags when building debug / release builds.

Makefiles have been removed, currently two build options are available:

Lazarus Project file
CMake.


Add version listing

loadimpact -v sholud list CLI version

Added in develop by, #[https://github.com/loadimpact/loadimpact-cli/commit/0653c2b9edce72f78e34f0e437ad3bf94b88a42d](this commit).


Update New York State file

Two changes here:

The source data switched to a zipped GDB that the New York State GIS folks sent me. It explicitly has New York City carved out of the dataset. They will be sending it to me quarterly.
A few months ago the New York State GIS team negotiated an agreement with Here to allow the zipcodes that are part of this dataset to be free and open, so I removed the note and added back in the zipcodes.

oh, that's pretty

:drooling_face:

Never realized how empty that northeastern bit really is.

Does this supersede #2482?

Yep, thanks @trescube.


ExtendedDataType = Masked is ignored when the table is not the primary table on a page.

1. Describe the bug
If you add a table to a page indirectly, the ExtendedDataType = masked, is ignored.
2. To Reproduce
Create two tables, Table A and Table B,  to keep it simple just create the same table twice.
Both Tables are (in this case) setup tables with only a single record, so no linkage / keys are needed.
table 50000 "TABLE A"
{
fields
{
field(1; "Primary Key"; Code[10])
{
Caption = 'Primary Key';
}
field(2; "Password"; Text[1024])
{
Caption = 'Password';
ExtendedDatatype = Masked;
}
}
}
table 50001 "TABLE B"
{
fields
{
field(1; "Primary Key"; Code[10])
{
Caption = 'Primary Key';
}
field(2; "Password"; Text[1024])
{
Caption = 'Password';
ExtendedDatatype = Masked;
}
}
}
Now create a page based on Table A, which references Table B;
Page 50000 "TEST PAGE"
{
Caption = 'Test Page';
PageType = Card;
UsageCategory = Administration;
ApplicationArea = All;
SourceTable = "Table A"
layout
{
area(content)
{
group('Table A')
{
field(Password;Rec.Password)
{
ApplicationArea = All;
ToolTip = 'This field is correctly masked';
}
}
group('Table B')
{
field(Password;TableB.Password)
{
ApplicationArea = All;
ToolTip = 'You would expect this field to be masked';
}
}
}
trigger OnOpenPage()
begin
TableB.Get();    // Both Tables are Single Record Setup Pages, so no filters needed;
end;
var
TableB : Record "Table B";
}
3. Expected behavior
The Table Field must be MASKED on the Page. Both the Field from Table A (Primary table for the page) as for Table B (Secondary/Referenced Table)
The only way to get the field from Table B masked, is to add the ExtendedDataType = Masked to the Page as well.
4. Actual behavior
The Table field for Table B (The Referenced table) is not masked, but cleartext.
You might argue that adding two tables to one page is not best practice, but this poses a potential security risk where passwords or other sensitive data might be exposed if someone links to the fields on a page by malicious end users / extensions.
5. Versions:

AL Language:  7.4.496506
Visual Studio Code:  1.51.1
Business Central: 18.3
List of Visual Studio Code extensions that you have installed: Not relevant for this bug.

This has always been the same: any field from a non-Rec table on a page does not inherit any of the properties from the table field definition. They act just the same as a variable or any other expression would. Only Rec fields get special treatment and automatically inherit properties. For anything else, we have always needed to manually duplicate the properties on the page.

this poses a potential security risk where passwords or other sensitive data might be exposed if someone links to the fields on a page by malicious end users / extensions.

If that's a concern, you should store the data securely, rather than just using Masked.

You have a point about storing the data securely, but we both know that is very often not the case :)
I never had to deal with this specific issue before, so I had no idea if it has been that way since C/AL.
However it would be a nice feature to have this working for a Record variable in my humble opinion.
But then I'm in the wrong Thread :)

Yeah, that could definitely be worth posting or upvoting on BCIdeas :-)


CODE RUB: CompletionClientValidationException Class Update v2.10.1

Updated CompletionClientValidationException class by removing constructors in which the error message was hard coded in. Updated all relevant service files to include message.

Closing Pull Request. Resolving in PR #544.


[BUG] Document or expose the 'remove big  masks' filter

Describe the bug
A user (the40x)  struggled with segmenting their large mask. The cell probability output looked clean and they were puzzled why despite tuning flow error/prob threshold etc, they were unable to get the final mask out
Link: https://forum.image.sc/t/cellpose-failing-to-produce-masks-despite-obvious-flows-and-cellprobs/86849/4
Screenshots
Above post has detailed images.
They eventually traced this down to:
https://github.com/MouseLand/cellpose/blob/5fb74fde155c35dafcd096fd66118b3cfdd174a0/cellpose/dynamics.py#L713C3-L713C3

I could not find anything relevant with a quick search for 'max' in the online doc, I might be mistaken and this may be documented somewhere.
There likely was a good reason to add this. So maybe we could expose this as max_size and default to the same 0.4 value?

I think exposing this via the CLI/API makes the most sense. @carsen-stringer

I've added this as an option: CellposeModel.eval(..., max_size_fraction=0.4)


Update std to 0.75.0 for Deno 1.5.0 compat

It seems like Deno 1.5.0's stricter Typescript setting break the older std versions:
> deno cache<EMAIL_ADDRESS>Check<EMAIL_ADDRESS>error: TS1205 [ERROR]: Re-exporting a type when the '--isolatedModules' flag is provided requires using 'export type'.
export { LogLevels, LevelName } from "./levels.ts";
                    ~~~~~~~~~
    at https://deno.land/std@0.61.0/log/mod.ts:13:21

So I've simply updated std to latest, and it seems to work fine again.

@danopia Thank you for you contribution! Could you also update std in dev_deps.ts?

Hello, I just updated the second file and also ran the tests and it looks good there.
I'm not too sure how Deno library versioning is supposed to work, say if the newer stds use APIs that older denos don't have available. I suppose the recommendation is to use recent Denos 😛

Published as v0.5.0

Hey @vslinko, thanks for the timely actions here.
I just wanted to add that I don't see v0.5.0 in the /x/ registry. 😒  I mentioned it on Discord and there was the suggestion that the webhook might've failed. Maybe you can see a relevant failure in the webhook log on Github. I think we'd have to reach out to a registry dev if everything looks good from your end.

Yup. If you find something, just ping me here or on Discord.

I've configured webhook and released 0.5.1. Please welcome<EMAIL_ADDRESS>


error[E0635]: unknown feature stdsimd

What type of bug is this?
Other
What subsystems are affected?
Standalone mode
Minimal reproduce step
Regular build.
What did you expect to see?
n/a
What did you see instead?
Build breaks after rust-nightly was updated:
error[E0635]: unknown feature `stdsimd`
  --> /wrkdirs/usr/ports/databases/greptimedb/work/greptimedb-0.7.0/cargo-crates/ahash-0.8.6/src/lib.rs:99:42
   |
99 | #![cfg_attr(feature = "stdsimd", feature(stdsimd))]
   |                                          ^^^^^^^

ahash needs to be updated to resolve this.
What operating system did you use?
FreeBSD 14.0
What version of GreptimeDB did you use?
0.7.2
Relevant log output and stack trace
No response

Build breaks after rust-nightly was updated:

Which toolchain is used when getting this error?

stdsimd is removed early this year. I'm bumping ahash to fix this

The old version of ahash is still dependent indirectly via many dependencies like sqlx and rustpython. It might be slow to bump ahash completely. As a workaround, use the toolchain specified in https://github.com/GreptimeTeam/greptimedb/blob/main/rust-toolchain.toml should compile.

cross reference the progress of upgrade axum https://github.com/GreptimeTeam/greptimedb/issues/3610


Is it a method off to  unregister event listener needed?

Is it a method off or called something else to  unregister event listener needed? Just for something leak. I'm a newer to dart/flutter, so asked such a question.

Here is an example of how you can cancel the listener:
StreamSubscription loginSubscription = eventBus.on<UserLoggedInEvent>().listen((event) {
  print(event.user);
});

loginSubscription.cancel();


Can Shaka detect the key license server from the init segment?

We have live content that contains content protection info for Widevine and PlayReady.
The license server url is passed in to Shaka for Widevine but for PlayReady, the license server url is in the init segment.
When the browser is MS Edge and we don't specify a drm:servers object, Shaka dispatches a 6012 error NO_LICENSE_SERVER_GIVEN. Shaka only reads the manifest in this scenario and doesn't download the init segments.
Is there an option to force shaka to look for the url in the init segment? I've tried using "ignoreDrmInfo" but that has no effect.
I've attached an example manifest.
Thanks.
manifest.xml.zip

We only support providing license server URLs in the configuration or in the manifest.  We don't look in the init segments since that would require parsing the key-system specific init data and we don't want to provide too much work for individual key systems.  Our system works (mostly) independent of which key system is used and there is no generic way of specifying the license URL in the init segment.

It is also a feature of Shaka Player that the configured license servers dictate which key systems we will use, overriding what's in the manifest.  So waiting to get the license server from the init segment would conflict with that.
You could make it work through a combination of a phony license server URI and a request filter.  The way it would work is that the filter would delay license requests until it sees an init segment.  It could then parse the init segment, extract the license server URI, and then replace the server URI in all license requests with the one it extracted.
But this could be a lot of work, and it might be easier to find another way to get this information.
What encoder/packager do you use?  Why does your application not know its own license server?

Hi @joeyparrish @TheModMaker Thanks very much for the feedback.
The application does know the license server when the content is ClearKey / Widevine. But when it's PlayReady, this is defined in the init segment so we've never needed it.
The reason it's defined in the init segment for PlayReady (I think) is because the packager originally setup the work flow with dashjs in mind. Dashjs looks in the init segment for key server urls. We've recently moved from dashjs to shaka for simulcast playback in our application.
It's not a problem as we can get the key server url but it involves a back end change for it to be passed through to the application.  I thought I would see if there was a setting / config for Shaka to do this before we go ahead and make the change.
Anyway, it's all good. Thanks for your feedback!

Thanks for being flexible, and understanding the trade-offs we made in design.


Feedback system for documentation

What problem will this feature address?
The main reason we want to build our own documentation project is to provide accurate and latest information to the users. But since we are humans, we might make mistakes such as typo or wrong information and we might miss the mistakes.
Describe the solution you'd like
I wish there is a feature for feedback system on right side of the documentation for every page.
Describe alternatives you've considered
Maybe create another api for feedback or simply form submission external links as a feedback system?
Additional context
Thanks for building this project. This is by far the best documentation project that is compatible with Next JS app router. I hope this project will be continued and improved more.

I'll just recommend using Github Issues or any API services if your docs is for non-technical people, building an API for feedback needs a database, realtime notification system and a full-powered rich editor + UI. This is obviously too much for a docs framework. Taking some reference from Next.js docs or Nextra, you can add a button to report docs issues (which redirects users to Github Issues template).


Email Validation

Devise email regexp does not validate email with successive dots e.g<EMAIL_ADDRESS>gets saved.

As discussed in https://github.com/plataformatec/devise/issues/3537, https://github.com/plataformatec/devise/issues/3376, you can always change the regexp in Devise's config.
Devise's default regexp does not attempt to validate all email cases.


Running unit tests with bad master key raises unfriendly exception

I ran the unit tests with an intentionally invalid master key. The tests fail with:
Error
Traceback (most recent call last):
  File "C:\Users\clam\Documents\azure-documentdb-python\test\crud_tests.py", line 40, in setUp
    databases = list(client.ReadDatabases())
  File "C:\Users\clam\Documents\azure-documentdb-python\pydocumentdb\query_iterable.py", line 68, in next
    callback, self._resource_throttle_retry_policy)
  File "C:\Users\clam\Documents\azure-documentdb-python\pydocumentdb\backoff_retry_utility.py", line 27, in Execute
    raise e
Error: Incorrect padding

Some tests also log WARNING:root:Operation will NOT be retried. Exception: Incorrect padding.

Hi Carson,
I tried tampering with the master key by deleting some of the chars and I was getting:
HTTPFailure: Status code: 401
{"code":"Unauthorized","message":"The input authorization token can't serve the request. Please check that the expected payload is built as per the protocol, and check the key being used. Server used the following payload to sign: 'get\ndbs\n\nwed, 11 nov 2015 06:30:31 gmt\n\n'\r\nActivityId: ef1b4818-5541-4b92-8455-786735288abd"}
Can you give an example of the invalid master key that gives you that exception?
Regards,
Rajesh

Hey Rajesh - something like "xxxxx" or the existing dummy value of "[YOUR_KEY_HERE]" triggers the exception.

I get the same Error: Incorrect padding when I haven't entered the [YOUR_KEY_HERE] & [YOUR_ENDPOINT_HERE].

@rnagpal it's because of auth.py __GetAuthorizationTokenUsingMasterKey here it does:
key = master_key.decode('base64')
If the invalid master key doesn't decode from base64 correctly, then you get the error: Error: Incorrect padding, but the stacktrace is not correct due to the try/except backoff_retry_utility.Execute
which catches any exception and doesn't re-raise the caught exception e and instead does an empty raise.

@RedCraig We had fixed this stack trace issue sometimes in Jan this year, so the stack trace shown in the initial thread now shows as:
File "F:\DocDB-Main1\Product\SDK\python\python\pydocumentdb\auth.py", line 37, in GetAuthorizationHeader
document_client.master_key)
File "F:\DocDB-Main1\Product\SDK\python\python\pydocumentdb\auth.py", line 61, in __GetAuthorizationTokenUsingMasterKey
key = master_key.decode('base64')
File "C:\Python27\lib\encodings\base64_codec.py", line 42, in base64_decode
output = base64.decodestring(input)
File "C:\Python27\lib\base64.py", line 321, in decodestring
return binascii.a2b_base64(s)
Error: Incorrect padding
We were doing "raise e" earlier which didn't showed the complete stack trace. But now that has been changed to "raise"(empty raise) which does shows the complete stack trace that I pasted above.
I see that you have a PR to fix this annoying message for someone just coming in and running the tests as is. Thanks!

@rbcarson : @RedCraig had fixed this issue by submitting a PR which has been merged. Closing this issue.


Can't compile xxh3, Erlang/OTP 26

error: could not compile xxh3 (lib) due to 2 previous errors
===> Uncaught error in rebar_core. Run with DIAGNOSTIC=1 to see stacktrace or consult rebar3.crashdump
===> When submitting a bug report, please include the output of rebar3 report "your command"
** (Mix) Could not compile dependency :xxh3, "/Users/ben/.mix/elixir/1-16/rebar3 bare compile --paths /Users/ben/oxen/OxenHub/_build/dev/lib/*/ebin" command failed. Errors may have been logged above. You can recompile this dependency with "mix deps.compile xxh3 --force", update it with "mix deps.update xxh3" or clean it with "mix deps.clean xxh3"
Looks possibly related to #2, let me know if there's any other output that's useful!

Which versions of rust, erlang, and elixir do you use?

I'm also getting a:
11:57:33.012 [warning] The on_load function for module xxh3 returned:
{:function_clause,
 [
   {:filename, :join, [{:error, :bad_name}, 'crates'],
    [file: 'filename.erl', line: 453]},
   {:filename, :join, 1, [file: 'filename.erl', line: 440]},
   {:xxh3, :init, 0,
    [
      file: 'path/deps/xxh3/src/xxh3.erl',
      ...
    ]},
   {:code_server, :"-handle_on_load/5-fun-0-", 1, [...]}
 ]}

** (UndefinedFunctionError) function :xxh3.hash128/1 is undefined (module :xxh3 is not available)
    (xxh3 0.3.5) :xxh3.hash128("")
    (fmv1992_content_enforcer 0.1.0) lib/fmv1992_content_enforcer.ex:20: Fmv1992ContentEnforcer.main/1
    (elixir 1.13.4) lib/kernel/cli.ex:126: anonymous fn/3 in Kernel.CLI.exec_fun/2

11:57:33.012 [error] Process #PID<0.96.0> raised an exception
** (FunctionClauseError) no function clause matching in :filename.join/2
    (stdlib 4.0.1) filename.erl:453: :filename.join({:error, :bad_name}, 'crates')
    (stdlib 4.0.1) filename.erl:440: :filename.join/1
    (xxh3 0.3.5) path/deps/xxh3/src/xxh3.erl:45: :xxh3.init/0
    (kernel 8.4.2) code_server.erl:1317: anonymous fn/1 in :code_server.handle_on_load/5
make: *** [makefile:10: run] Error 1

It does work with iex -S mix though.

By hard coding the right value to __PATH I was able to make it work:
-define(load_nif_from_crate(__CRATE, __INIT),
    (fun() ->
        __APP = ?CARGO_LOAD_APP,
        __PATH = "/home/myuser/myproj/deps/xxh3/priv/crates/xxh3/xxh3",
        erlang:load_nif(__PATH, __INIT)
    end)()
).

You might want to fix how that path discovery works.


An error with Xcode9/CP

RealmSwift (via CocoaPods) is ready to use on Xcode9 b1 when its target is set to Swift 3.2 except for one issue:

Once the "Fix" button is clicked it's possible to create a Swift 4 app with the modified current version of RealmSwift. Maybe it's worth making the change to the code right now so people can start testing their apps in Xcode9?

This was fixed by https://github.com/realm/realm-cocoa/pull/5006.

@tgoyne is it possible to install this through coco-pods
pod 'RealmSwift', :git => 'https://github.com/realm/realm-cocoa.git', :branch => 'master'

this does not work cocopods fails to download.

@tgoyne bump, this was not fixed by #5006 for Cocoapods users

What sort of errors are you getting? If Xcode is complaining about missing files, it's because you need to add :submodules => true to the pod definition.


FeatureStoreRedis to support redis sentinel

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/37425646-featurestoreredis-to-support-redis-sentinel?utm_campaign=plugin&utm_content=tracker%2F1038413&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F1038413&utm_medium=issues&utm_source=github).

Hello,
I expect the FeatureStoreRedis to already support the Sentinel as describe here :
https://github.com/clun/ff4j/wiki/Store-Technologies#redis
Exemple:
//  {@link redis.clients.jedis.JedisSentinelPool}
RedisConnection rc = new RedisConnection(new JedisSentinelPool("localhost", Util.set("master", "slave1")));

FF4j ff4j = new FF4j();
ff4j.setFeatureStore(new FeatureStoreRedis(redisConnection));
ff4j.setPropertiesStore(new PropertyStoreRedis(redisConnection));
ff4j.setEventRepository(new EventRepositoryRedis(redisConnection));

May I missed something ?

Do you think i close this issue ?

Yes pls. Thanks.
On Sep 8, 2016 07:33, "Cédrick Lunven"<EMAIL_ADDRESS>wrote:

Do you think i close this issue ?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/clun/ff4j/issues/157#issuecomment-245617393, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AUI7y2EKcpFYk5Q9phPzMZ_KOfzwEOHMks5qoBy8gaJpZM4Jw7cO
.


Volume difference

Hi dheijl, little feedback ..
As you know I use swyh-rs especially with Deezer, today I am testing the sending of sound with Youtube launched on Microsoft Edge, and I have, despite having the volume Max on youtube, a very low volume in the swyh-rs stream .. I also tried with Molotov (a French TV application) same result despite the max volume in the application the stream remains at very low level .. .
Is there a way to choose the sound level of what we send in the stream or to normalize the output stream to a level (0dB) that we could adjust?
I don't understand why I have such a low volume with Edge or Molotov while with Deezer it works well ...

Hi @MX10-AC2N ,
Have you checked the volume of the browser in the Windows Volume Mixer?

I don't know what happened again but hey after restarting the whole system, it is much better, I still have a difference in volume between the applications but quite slight ... Sorry a little noise for Not much...

No problem!

Thanks again for everything you do ..


Clear SM data section on sancus_enable

Currently, the data section doesn't seem to be cleared when enabling protection for an SM.

This probably requires a straightforward change in the crypto_control state machine.


Use acceptAllDevices for bluetooth prompt

FIX: #38

aaargh, I saw and merged #40 first. But thanks for also sending this change. :-)


Convert bytes to new args style

Codecov Report

Merging #759 into master will increase coverage by 0.04%.
The diff coverage is 75%.

@@            Coverage Diff             @@
##           master     #759      +/-   ##
==========================================
+ Coverage   61.95%   61.99%   +0.04%
==========================================
  Files          80       80
  Lines       12708    12686      -22
  Branches     2606     2607       +1
==========================================
- Hits         7873     7865       -8
+ Misses       3165     3158       -7
+ Partials     1670     1663       -7

Impacted Files
Coverage Δ

vm/src/obj/objbytes.rs
73.91% <75%> (+7.24%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5c9181...c2d04f9. Read the comment docs.


os: enable symlink creation on Windows 10

Fixes #22874

More information on the topic is provided by Git on Windows:
https://github.com/git-for-windows/git/wiki/Symbolic-Links#allowing-non-administrators-to-create-symbolic-links

Empty comment for triggering CLA check.


Removing "coming soon" note (#67)

Removing coming soon note

Fixing dates

Docs Build status updates of commit 2937246:
:clock10: Pending: waiting for processors (6 builds ahead of you)
:warning: Docs Build is busy, currently there are 6 builds ahead of this one, for more information you can view the Build queue graph on the Docs Portal.

Docs Build status updates of commit 2937246:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/includes/preview-note.md
:white_check_mark:Succeeded

docs/index.md
:white_check_mark:Succeeded

docs/overview/excel.md
:white_check_mark:Succeeded

docs/tutorials/excel-tutorial.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Remove extra copies of Apache 2 license

Signed-off-by: Ry Jones<EMAIL_ADDRESS>

These files exist for a reason and are part of our automated license check system, so cannot be deleted.


SA1135 throws exception for type keywords

When adding a type alias using a keyword, the analyzer throws AD0001, when inside a namespace
namespace ClassLibrary
{
    using Example = string;
}

and also when using value tuple values
namespace ClassLibrary
{
    using Example = (System.Collections.IList, int);
}

This does not occur when outside a namespace, but this violates SA1200

What version are you using?

Sorry! I asked because I couldn't reproduce it, but I see it now using the latest beta.

I will have a look.

We've also encountered this bug, using StyleCop.Analyzers.Unstable <IP_ADDRESS>6 (can't use Beta for reasons)
namespace Library;
using Foo = (int A, string B);

Workaround (but names are lost):
using Foo = System.ValueTuple<int, string>;


Custom map (tiles) without Google Maps API (Android) ??

I want to use MapMyIndia As provider not google .
Does Anyone know ????

I also need this.

duplicate #773


fix typo

Hi @friism, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, MSBOT;

@friism : Thanks for your contribution to the Azure documentation! The author, @neilpeterson, has been notified to review your proposed change.

@friism - thanks Michael.
#sign-off


anyway to get thin vertical lines instead of thick bars?

title

let g:indent_guides_guide_size=1

let g:indent_guides_guide_size=1

This works for me, thank you!


Refactor endpoints

Issue Link
https://github.com/ita-social-projects/GreenCity/issues/7339
Summary of change

Refactored endpoints in EventController and EventCommentController.
Rewrited two SQL in EventRepo to Criteria API.
Added correct events order when you get all of it.
Added column "type" to "events" table that represent event type: offline, online or online_offline.
Edited SecurityFilterChain according to the changes.
Added/modified test.

Changelog: Changelog-2.txt

Next time when you create a pull request, please split it by entities, as there is too much information in a single PR.

Next time when you create a pull request, please split it by entities(or some one else), as there is too much information in a single PR.

Absolutely agreed.