For those who want to use this screensaver on Windows

I just found these two repositories:

https://github.com/sinky/html5-screensaver-node-webkit
https://github.com/sinky/runscreensaver

Follow the instructions of these two repositories first. Then simply replace the HTML, JavaScript, CSS files in screen.nw folder with those in webview folder.
For your convenience, I've packed up all the files needed into an archive which can be downloaded here. Extract this archive and put those files into screen.nw folder. Then rename the HTML you want to use to index.html.

Thank you so much!

Thank you so much, this has been very helpful!

Little complex but it works! Thanks a lot.

Hey everyone!  I now have my .scr file ready.  When I double click it, it runs the screensaver.  However, I cannot get it to show up as a screensaver choice in Windows.  Any guidance on this?
Thanks!

Hi, i need help. I followed all the steps, but dont know what command line on the configuration of the screensaver "Specify a command to run when the screensaver starts". I think i need to put the dir of the screen-nw but dont know what exactly. Can you help me?? Thanks

Hi, i dont understand the steps of the autoit, i dowload it and then when i tried to convert the file it didn't let me, and I noticed that the file of the "runscreensaver" is already at .scr format, also i don't now what to write on the configuration of the screensaver "Specify a command to run when the screensaver starts". I would apreciate your help

Hi @Estein0, @asanez4,
As for "Specify a command to run when the screensaver starts", just fill in "/path/to/your/nw.exe /path/to/your/screen.nw/folder".


On Linux, make swift_reportError always print backtraces

Recently, Swift runtime changed not to print backtraces in non-assert builds of the runtime. It seems that there shouldn't be any problems with printing backtraces on Linux, even in optimized builds, so this PR makes swift_reportError always print backtraces there.

@swift-ci please test

Build failed
Jenkins build - Swift Test Linux Platform
Git Commit - 43b30946579f6648a1f02cebf3db950f43779e75
Test requested by - @kubamracek

If the tests pass, LGTM.

@swift-ci please test

Build failed
Jenkins build - Swift Test OS X Platform
Git Commit - 43b30946579f6648a1f02cebf3db950f43779e75
Test requested by - @kubamracek

Build failed
Jenkins build - Swift Test Linux Platform
Git Commit - 43b30946579f6648a1f02cebf3db950f43779e75
Test requested by - @kubamracek


Rank sorting in Tablist

Sort ranks in tablist by naming them with numbers like this
001owner
002admin
003player

implemented in https://github.com/0PandaDEV/Nextron/commit/432288924adb61ab307e29115217b37b11acd0a9


MP3 player extension

An extension that can can play mp3s via url and hard drive
i know that there is a Spotify extension from Scratch X
Example block:

menu selection:
From URL
From File

wow

i tried to do a prototype (with ABSOLUTELY NO KNOWLEDGE of java) with the spotify extension

Lazy loading?

Lazy loading?

I think it's just a suggestion

Closing this as the extension is added


Next.js rewrite

For archival reasons move the golang version of it to a separate branch before merging it to main alright?

do whatever you think is best

although, commit history exists so i dont see the purpose of doing that

also it's Go not golang

Forgot to say. Yep, this is kind of a joke PR, there is no way we will use Next.js for Segfautils because the Docker image will be too massive and it's just not necessary. What we will do is make a rewrite in Fiber, however I'm not exactly motivated to work on this project unless akis really pushes me to. Sorry for wasting your time, if I did


chore(test): add more test case

Signed-off-by: d2lark<EMAIL_ADDRESS>complete test case for sort-merge-join exexcutor

Do you want to get this changed in this PR?

I also think the test case bug is a bit of a bummer, it's better written this way


Add compatibility for Python 3.12

Fixes the deprecation/renaming of SHAP code

This should fix: https://github.com/ing-bank/probatus/issues/234 and https://github.com/ing-bank/probatus/issues/233

@adri0 it is finally succeeded and ready for review ;)

Maybe you can add python 3.12 to the unit test matrix in the workflow.

Maybe you can add python 3.12 to the unit test matrix in the workflow.

Nice find. I forgot! It should be added now.


Add empty azdata extension

Getting the boilerplate stuff in before I start adding actual functionality

Coverage decreased (-0.1%) to 35.751% when pulling 996ee29a65f4d061b2e2759a200c8cde85ad53d1 on chgagnon/addAzdata into 7d5ecfe905e2e521e9c10c8ce8ffca881bc8c611 on main.


not rendering everyone sometimes

randomly people disappear from the esp

Yes same problem here

my esp doesnt even work

The offsets will not be updated in the future, please update it by self.

We dont say we wont update it on future.
Even a2x did not released anything.
And esp not rendering sometimes is not related with offsets at all.

no, we won't be updating the offsets in the future, because it makes "opensource" pointless.
also, esp not rendering it has nothing to do with offsets.


Move create_physical_expr to physical-expr-common

Is your feature request related to a problem or challenge?
https://github.com/apache/arrow-datafusion/blob/671cef85c550969ab2c86d644968a048cb181c0c/datafusion/functions-aggregate/src/first_last.rs#L102-L117
I found that we need to match Alias cases,  it seems we should try to reuse create_physical_sort_exprs if possible
We need to move create_physical_expr to physical-expr-common, and this might involve moving lots of things to physical-expr-common` too, not sure if it is reasonable yet.
Describe the solution you'd like
Two places that we need create_physical_expr

Convert to physical-expr in accumulator with create_physical_sort_exprs.
reverse_expr, convert logical aggr expr to physical aggr expr with create_physical_expr, given AggregateFunction expect to get Arc<dyn AggregateExpr>

Describe alternatives you've considered
~Actually, we have what we need of physical sorting expression ordering_req in AggregateFunctionExpr already.
But since AccumulatorArgs and AggregateUDFImpl live in datafusion_expr layer, so we can't get the value from it.~
~I still think it would be nice to have a design that can deal with physical-expr for UDAF 😞
Should we move AggregateUDFImpl to a crate that imports both datafusion-expr and datafusion-physical-expr-common?~ 🤔
No response
Additional context
No response

I would like to continue the discussion in #9972 since I don't have a good reason not to support directly mutating physical-expr. And the solution (moving conversion to optimizer rule) is specific to FIRST/LAST for me, I'm not sure moving all the function including reverse_expr to optimizer rule is a good idea.

I still think it would be nice to have a design that can deal with physical-expr for UDAF 😞
Should we move AggregateUDFImpl to a crate that imports both datafusion-expr and datafusion-physical-expr-common

I think we can consider moving AggregateUDFImpl to functions-aggregate-common that imports both datafusion-expr and datafusion-physical-expr-common.
The pros are that we can avoid doing conversion of ordering twice in accumulator where it is already computed while creating udaf expr.
https://github.com/apache/arrow-datafusion/blob/4ad4f90d86c57226a4e0fb1f79dfaaf0d404c273/datafusion/core/src/physical_planner.rs#L1926-L1933
Not only accumulator but also reverse_expr has the similar issue.
https://github.com/apache/arrow-datafusion/blob/4ad4f90d86c57226a4e0fb1f79dfaaf0d404c273/datafusion/physical-expr/src/aggregate/array_agg_ordered.rs#L138-L150
If we have only sort_exprs: Vec<Expr>, we need to compute PhysicalSortExpr again.
I think the benefit of avoiding re-computing is large than the complexity of introducing yet another crate functions-aggregate-common. And, note that we have aggregate function in window function too. We may have functions-window-common and functions-window crates if follow the design.
Unless the cost of re-computing logical-expr to physical-expr is negligible otherwise I think able to directly mutating physical-expr is good for long term.

I play around it and does not look like a good idea at all...

🤔  it seems like the core challenge is that the implementation of the aggregate functions -- specifically https://github.com/apache/arrow-datafusion/blob/671cef85c550969ab2c86d644968a048cb181c0c/datafusion/functions-aggregate/src/first_last.rs#L102-L117
need to have some way to create a PhysicalExpr without directly depending on create_physical_expression
Rather than moving create_physical_expression around so the aggregtes could have a direct dependency (which I think is going to be tough to do without creating a cycle as create_physical_expression ), what about passing in a callback ?
Something like
pub struct AccumulatorArgs<'a> {
...
  /// Function for converting Exprs to PhysicalExprs, if needed
  create_physical_expression: &dyn Fn(&Expr) -> Result<Arc<dyn PhysicalExpr>>;

AccumulatorArgs  is in expr crate, PhysicalExpr is in physical-expr-common crate. And, AccumulatorArgs  is used in AggregateUDFImpl, so it is not possible for it to move out expr. PhysicalExpr makes sense to stay in physical-layer. I think the idea here does not work.

AccumulatorArgs  is used in AggregateUDFImpl

I think this is the key problem
Can we pull AccumulatorArgs into physical-expr-common?

Moving AccumulatorArgs into physical-expr-common which means we need to import physical-expr-common in expr, because AggregateUDFImpl  is in expr. If we consider moving AggregateUDFImpl to physical-expr-common, then, AggregateUDF and all many things need to move too, which does not make sense

Hmm this is a tricky refactor -- it is like a ball knot in a piece of string -- we just need to keep tugging at it and at some point it will unravel.

How about we introduce physical aggregate function trait, AggregateUDFPhysicalImpl
I expect that AggregateUDFPhysicalImpl handle the physical-expr, for example, accumulator and reverse_expr.
We create logical aggregate and handle optimization in logical layer. Create physical aggregate via create_physical_expr. Once we created, we never need to deal with logical-expr and physical-expr conversion. For reverse_expr, we just create another physical-expr that implement AggregateUDFPhysicalImpl.

I'm thinking of moving AggregateUDFImpl to aggregate-common, which imports both physical-common and expr-common. Then, we import  AggregateUDFImpl in datafusion-expr.
The overall idea is to enable us to import common things to Expr::AggregateFunction which lives in datafusion-expr.
Those common things mainly include AggregateUDFImpl and of course, physical-expr AggregateExpr. Although, having a physical-expr idea in the logical layer is quite counter-intuitive, if we consider it as common level thing, it is not a weird thing. But, I need to play around with it to see if I miss something.
  graph TD;
      functions-aggregates-common-->expr-common;
      functions-aggregates-common-->physical-expr-common;
      functions-aggregates-->functions-aggregates-common;
      physical-expr-common-->expr-common;
      expr-->expr-common;
      expr-->functions-aggregates-common;
      physical-expr-->physical-expr-common;
      core-->functions-aggregates;
      core-->physical-expr;

@alamb I try the idea in #10327 and it seems promising!
I would like to split the large #10327 into several ones for easier review, before that I would like to know your thought about the design and the dependency in the above graph, does it looks good?
My thought about categorize those crate
expr-common:  Things other than Expr and LogicalPlan can place it here
expr: Mainly for Expr and LogicalPlan. Import functions-aggregate-common for UDAF.
physical-common:  Physical expr trait or other common things.
functions-aggregate-common: Import physical-common and expr-common, for other users to build their own udaf.
functions-aggregate:  datafusion builtin functions
With functions-aggregate-common, we finally can have physical-expr as returns value in AggregateUDFImpl.
pub trait AggregateUDFImpl: Debug + Send + Sync {
    fn reverse_expr(&self) -> Option<Arc<dyn AggregateExpr>> {
        None
    }
}

And, we import `functions-aggregate-common` to `expr`, we can have our new `AggregateUDF` in logical layer but user defined physical-expr interaction!

```rust
pub enum AggregateFunctionDefinition {
    BuiltIn(aggregate_function::AggregateFunction),
    /// Resolved to a user defined aggregate function
    UDF(Arc<function::AggregateUDF>),
    /// A aggregation function constructed with name. This variant can not be executed directly
    /// and instead must be resolved to one of the other variants prior to physical planning.
    Name(Arc<str>),
}

The overall idea is to enable us to import common things to Expr::AggregateFunction which lives in datafusion-expr.

In the chart you have in https://github.com/apache/datafusion/issues/10074#issuecomment-2088004947 it seems like it will mean that datafusion-expr will depend (indirectly) on datafusion-physical-expr which I thought was the dependency we are trying to avoid
I am sorry I am so slow to respond and getting lost here. Can we take a step back and help figure out what problem we are trying to solve
Can you remind me why datafusion-functions-aggregate (the implementation of aggregate functions) shouldn't depend on datafusion-physical-expr and datafusion-expr? I thought the thing we are trying to do is avoid datafusion-expr depending on datafusion-physical-expr 🤔
What I believe we are trying to do is to pull the aggregate functions out of datafusion-physical-expr
I am sorry if you have explained this to me already.

@alamb
First of all, we plan to pull the aggregate function out from datafusion-physical-expr. And, we also split datafusion-physical-common from datafusion-physical, so the user can only import the minimum things they need, but this is not enough. We want to handle physical-expr in UDFImpl, which is not possible given the current crate graph, because UDFImpl should be in datafusion-expr and we can't import datafusion-physical-expr to datafusion-expr.
But, what if we allow datafusion-expr to import physical-expr-common 🤔
We now differentiate common as the higher level crate. datafusion-common is the highest. Introduce expr-common as the second, datafusion-physical-common as the third (import common and expr-common), and aggregate-common as the fifth, that import all other common. Allow datafusion-expr to import datafusion-physical-common, so we can handle physical-expr concept in UDFImpl.
As long as we don't introduce things that depend on datafusion-expr into physical-expr-common, I think we don't need to strictly avoid any physical-expr concept things ported into datafusion-expr.

Can you remind me why datafusion-functions-aggregate (the implementation of aggregate functions) shouldn't depend on datafusion-physical-expr and datafusion-expr

datafusion-functions-aggregate can import datafusion-expr and datafusion-physical-expr-common but not datafusion-physical-expr to keep the minimum dependencies for the user.

I thought the thing we are trying to do is avoid datafusion-expr depending on datafusion-physical-expr

This idea is what blocking us! Now, I would allow datafusion-physical-expr-common dependency for datafusion-expr

But, what if we allow datafusion-expr to import physical-expr-common 🤔

I see -- this makes sense. What I am worried about is that physical-expr-common would end up with all the code from physical-expr so while it has a different name it ends up being the same issue.
I get the sense that part of the problem is that first_value and last_value are some of the most complex aggregate functions (as they can be used by window functions, and they have various other optimziations like reverse and sort aware)
I wonder if we could try starting with some of the simpler and less used aggregates like corr, stddev, covariance that use fewer APIs and have fewer features.
That might make it easier to incrementally discover how to structure the dependencies so we could extract the aggregates out of the core 🤔

I get the sense that part of the problem is that first_value and last_value are some of the most complex aggregate functions

Actually, that is the reason why I work on it first, to ensure the design is solid for most of the functions.

What I am worried about is that physical-expr-common would end up with all the code from physical-expr

I also thought about this, but I don't think there is more we need to move the code into common, because first value covered all the cases except grouping accumulator which is not so different from normal accumulator from the perspective of moving code to physical-expr-common, both returns Accumulator.  I now believe that what I had tried to do  Move create_physical_expr to physical-expr-common is the wrong step, as it moved out unnecessary things, including Column physical-expr which is already moved into common.
I agree that the design deserves more discussion. I will work on covariance first.

Actually, that is the reason why I work on it first, to ensure the design is solid for most of the functions.

I agree that the design deserves more discussion. I will work on covariance first.

That makes sense to me -- thank you. I will attempt to review those PRs in a timely manner so you can iterate more quickly. I often feel I am slowing you down as I can't review the PRs fast enough


welch method unexpected results for low frequency

When computing the PSD of the synthetic signal below using welch method I obtain an unexpected peak near 0 Hz with no physical meaning. The equivalent MATLAB code produces different results for that region.
Python code example:
import numpy as np
import matplotlib.pyplot as plt
from scipy.signal import welch, hanning

x = np.linspace(0, 10, 100001)
dt = x[1] - x[0]
fs = 1 / dt

a1 = 1
f1 = 500

a2 = 10
f2 = 2000

y = a1 * np.sin(2*np.pi*f1*x) + a2 * np.sin(2*np.pi*f2*x)

datos = y

nblock = 1024
overlap = 128
win = hanning(nblock, True)

f, Pxxf = welch(datos, fs, window=win, noverlap=overlap, nfft=nblock, return_onesided=True)

plt.semilogy(f, Pxxf, '-o')

plt.grid()
plt.show()

MATLAB code example
x = linspace(0, 10, 100001);
dt = x(2) - x(1);
Fs = 1 / dt;
a1 = 1;
f1 = 500;
a2 = 10;
f2 = 2000;
y = a1 * sin(2*pi*f1*x) + a2 * sin(2*pi*f2*x);

nblock=1024;
overlap=128;
windowsel=hann(nblock);
[Pxx,f]=pwelch(y,windowsel,overlap,nblock,Fs,'onesided');
figure()
semilogy(f,Pxx, '-o')

Scipy/Numpy/Python version information:
Scipy 0.19.1
NumPy 1.13.1
Python 3.6.2 final (serial 0)

Matlab:

Python

I can reproduce with simplified scripts that only process a single window and shorter signals:
fs = 10.
n_samp = 32
t = np.arange(n_samp) / fs
y = np.sin(2*np.pi*2*t)
win = windows.hann(n_samp, False)
f, Pxxf = welch(y, fs, window=win, noverlap=0, nfft=n_samp,
                return_onesided=True)
plt.semilogy(f, Pxxf, '-o')
plt.xlim([0, 5])
plt.ylim([1e-7, 1])
plt.show()

MATLAB:
clear all; close all; home;
fs = 10;
n_samp = 32;
x = (0:n_samp-1) / fs;
y = sin(2*pi*2*x);
overlap=0;
windowsel=hann(n_samp);
[Pxx,f]=pwelch(y,windowsel,overlap,n_samp,fs,'onesided');
figure();
semilogy(f,Pxx, '-o');

But Octave at least agrees with our output:

I'm not sure what MATLAB is doing to change/correct these values.

I will have a look at the implementation of scipy and try to figure out where this behaviour might be coming from. Do you have any suggestion on that?

I have also found this matlab example that might be relevant: https://es.mathworks.com/matlabcentral/answers/33653-psd-estimation-fft-vs-welch
It compares results obtained using FFT with results using PSD and both show the same behaviour near 0 Hz. It may be a good starting point.

Try using detrend=False.  signal.welch defaults to subtracting the mean of the data (detrend='constant') which seems to be giving you this DC artifact.

Thanks @ewmoore I can confirm detrend=False fixes it.

Awesome! Thank you!

It occurred to me that the root cause of this low-frequency energy showing up in the estimated PSD is that detrending takes place before windowing (check _fft_helper()). This means that the DC component of the windowed frame is not zero even though it has been detrended to have zero mean!
To illustrate, I modified the example provided by @larsoner:
fs = 10.
n_samp = 32
t = np.arange(n_samp) / fs
y = np.sin(2*np.pi*2*t)
win = windows.hann(n_samp, False)
windowed_y = y*win  # apply window already now
f, Pxxf = welch(windowed_y , fs, window='boxcar', noverlap=0)  # do not apply it here
plt.semilogy(f, Pxxf, '-o')
plt.xlim([0, 5])
plt.ylim([1e-7, 1])
plt.show()

This results in:

Which has zero energy at DC, as expected given the default detrending method.
@larsoner, do you think this qualifies as a bug that should be reported?
Sorry for adding a comment years after this issue was marked as closed.

(as a procedural note, feel free to open a new issue in case this doesn't receive a response)


Add man page for each installed C++ header with hyperlink

For all installed C++ headers which do not have a hand written man page, install a man page for each class which links to the published doxygen web page, e.g.
https://geopm.github.io/dox/classgeopm_1_1_exception.html
A brief SYNOPSIS and DESCRIPTION section might be nice as well.

b0f909c893480bd2bb060cb48514525cf04e6cc6


Add migration to be compatible with django 1.8

Fixes #537

Coverage remained the same at 95.581% when pulling a9f0fb06a05f91b4134e89236f628543282775a2 on hovel:missing_migration into 7dfb3d5d148127e32f217a62096d507266a3a83c on bread-and-pepper:master.

Any chance we can we get this merged? This one has been bothering me as well.


Custom decoder

I would like the get the clientX/clientY coordiantes instead of pageX/pageY. Is this possible?

Someone answered here but it's a bit old. Here's how I wrote a custom decoder to get pageX, pageY, and which button was pressed. It think you just need to change the "pageX" to "clientX".
I confess I'm not sure how to put this in a subscription (that is, how you would use it with this library) - can anyone fill in the blanks on that?
type alias MouseEvent = {pos: Mouse.Position, button: Int}
type Msg =  MyMsg MouseEvent

decodeClickEvent : (MouseEvent -> a) -> JSD.Decoder a
decodeClickEvent fn =
  let toA : Int -> Int -> Int -> a
      toA px py button =
        fn {pos= {x=px, y=py}, button = button}
  in JSDP.decode toA
      |> JSDP.required "pageX" JSD.int
      |> JSDP.required "pageY" JSD.int
      |> JSDP.required "button" JSD.int

In your HTML, instead of using Events.mouseDown, you use
    Html.Events.on "mousedown" (decodeClickEvent (SomeMsg))

@pbiggar Thanks for your input
I think the problem is, that this library doesn't allow you to pass your own JSON decoder, there is one fixed decoder which extracts the values for pageX and pageY.
It would be great if it was possible to pass your own decoders to the subscription.

That would be useful for me too. I don't see any way to get mouse event attributes from a subscription otherwise.

Custom decoder needed here as well. For the time being, I'm just working about this problem by copying the Mouse module into our project and redefining the internal position decoder to suit our needs.

+1000 on this.
A custom decoder would allow to implement an "onClickOutside" subscription, by checking all the element ids from the event.target to document.
This would be a similar approach to that used by https://github.com/Pomax/react-onclickoutside

You can modify the Mouse module to expose all mouse event properties and listen to any type of event. Demo

This is possible with the new elm/browser package, in the Browser.Events module.


Uncaught Error: RangeError (index): Index out of range: no indices are valid: 0 when this error generally arises in dart?

Thank you for taking the time to file an issue!
This tracker is for issues related to:

Analyzer
Common Front End (CFE) and kernel
Dart core libraries ("dart:async", "dart:io", etc.)
Dart VM
dart2js
dev_compiler

Some other pieces of the Dart ecosystem are maintained elsewhere. Please
file issues in their repository:

Dart language: https://github.com/dart-lang/language
Dart website: https://github.com/dart-lang/site-www
Flutter: https://github.com/flutter/flutter
Linter: https://github.com/dart-lang/linter
dartfmt: https://github.com/dart-lang/dart_style

If you aren't sure, file the issue here and we'll find the right home for it.
In your issue, please include:

Dart SDK Version (dart --version)
Whether you are using Windows, MacOSX, or Linux (if applicable)
Whether you are using Chrome, Safari, Firefox, Edge (if applicable)

Missing some or all of the above might make the issue take longer or be
impossible to act on.
If you simply have a question, consider starting with Stack Overflow:
https://stackoverflow.com/questions/tagged/dart
For a real-time response, consider our Gitter channel:
https://gitter.im/dart-lang/sdk

Thanks for filing an issue @ashiN-coder11 , can you explain your question in more details?

@ashiN-coder11 any updates on this? Can you explain your question with more details.

@ashiN-coder11 any updates on this? Can you explain your question with more details.

@ashiN-coder11 - this error Uncaught Error: RangeError (index): Index out of range: no indices are valid: 0  means you're accessing index 0 in an empty array/list.  The array/list must have at least one element to access at index 0.
You'd get this error from something like:
void main() {
  var l = [];
  print(l[0]);
}

I'm closing this issue.  Please open a new one if you believe there is a bug in Dart itself.  For general questions, please consider using stackoverflow or gitter.

@ashiN-coder11 - this error Uncaught Error: RangeError (index): Index out of range: no indices are valid: 0  means you're accessing index 0 in an empty array/list.  The array/list must have at least one element to access at index 0.
You'd get this error from something like:
void main() {
  var l = [];
  print(l[0]);
}

I'm closing this issue.  Please open a new one if you believe there is a bug in Dart itself.  For general questions, please consider using stackoverflow or gitter.


[BUG] part.has_complete_bom_pricing is broken by c6fd2281

Describe the bug
There are two code errors in https://github.com/inventree/InvenTree/commit/c6fd2281d689309007b06c46560e6f446ee931bd which completely break the part.has_complete_bom_pricing property (at least in head, and the current stable release... and afaict, the code was never correct, but I haven't gone back to check).
The issues are:

before the loop - calling common.models.get_setting instead of common_models.InvenTreeSetting.get_setting when trying to retrieve PART_BOM_USE_INTERNAL_PRICE - afaict there is no get_setting method at the module level and never has been, only in the class...
within the loop passing an argument (use_internal) to the has_pricing_info property of the sub_part, e.g. attempts to call a property as a method, this is not supported, and Python raises an exception.

These problems have been hidden, because the way this property is used (within template if statements, as a property checking for falseness) falls victim to Django's bug (https://code.djangoproject.com/ticket/17664) where the exception is wrapped and compared to the == False part of the statement.... so the fact an exception is being raised in this method is not highlighted.
Steps to Reproduce

Create a part with no pricing info
Create a part with pricing info
Create a composite part with a BOM that includes each of the parts created at step 1 and 2
Navigate to the Pricing tab of part created in 3

Expected behavior
A warning should be shown below the BOM pricing table stating that BOM pricing is incomplete for this part. Instead no warning is shown because the method is failing and the exception is somehow being eaten within the template processing...
Deployment Method
N/A
Version Information
Running from HEAD

I have a fix for this and will send a pull request shortly.


AWS Windows 2022 - Userdata Chef Installation

Description
Any Chef 18+ MSI fails to install correctly in userdata on Windows 2022 on AWS.
The installation fails with exit code 1622 and a log message is shown:
Error opening installation log file.  Verify that the specified log file location exists and is writable.
Chef Version
18+
17.x works fine
Platform Version
Windows 2022 on AWS (Windows_Server-2022-English-Full-Base-2024.09.11)
Windows 2019 on AWS (EC2LaunchV2-Windows_Server-2019-English-Full-Base-2024.09.11)
(Windows 2016 works fine)
Replication Case
Create a simple userdata installing 18
. { iwr -useb https://omnitruck.chef.io/install.ps1 } | iex; install -version 18.5

Try 17 and it will work fine:
. { iwr -useb https://omnitruck.chef.io/install.ps1 } | iex; install -version 17.10.95

Client Output
###
### STDOUT
###

Name              : Omnitruck
Path              : C:\Windows\system32\217bb7ce-b5ed-4a39-9b1f-7cb6f4753eec
Description       :
Guid              : 00000000-0000-0000-0000-000000000000
Version           : 0.0
ModuleBase        : C:\Windows\system32
ModuleType        : Script
PrivateData       :
AccessMode        : ReadWrite
ExportedAliases   : {[install, install]}
ExportedCmdlets   : {}
ExportedFunctions : {[Get-ProjectMetadata, Get-ProjectMetadata], [Install-Project, Install-Project]}
ExportedVariables : {}
NestedModules     : {}

Installing chef from C:\Windows\TEMP\chef-client-18.5.0-1-x64.msi
Error opening installation log file.  Verify that the specified log file location exists and is writable.

###
### STDERR
###
msiexec was not successful. Received exit code 1622
At line:458 char:5
+     throw "msiexec was not successful. Received exit code $($p.ExitCo ...
+     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : OperationStopped: (msiexec was not... exit code 1622:String) [], RuntimeException
    + FullyQualifiedErrorId : msiexec was not successful. Received exit code 1622

@bdwyertech Can you provide complete snippet around chef installation in packer?


unable to download

Checklist

[ ] I'm reporting a broken site support issue
[x] I've verified that I'm running youtube-dl version 2019.05.11
[x] I've checked that all provided URLs are alive and playable in a browser
[x] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[x] I've searched the bugtracker for similar bug reports including closed ones
[x] I've read bugs section in FAQ

Verbose log

youtube-dl -f 22 --verbose ICtkpLqY3BY
[debug] System config: []
[debug] User config: []
[debug] Command-line args: [u'-f', u'22', u'--verbose', u'ICtkpLqY3BY']
[debug] Encodings: locale UTF-8, fs UTF-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2016.02.22
[debug] Python version 2.7.12 - Linux-4.15.0-50-generic-x86_64-with-Ubuntu-16.04-xenial
[debug] exe versions: ffmpeg 2.8.15-0ubuntu<IP_ADDRESS>, ffprobe 2.8.15-0ubuntu<IP_ADDRESS>, rtmpdump 2.4
[debug] Proxy map: {}
[youtube] ICtkpLqY3BY: Downloading webpage
[youtube] ICtkpLqY3BY: Downloading video info webpage
ERROR: ICtkpLqY3BY: "token" parameter not in video info for unknown reason; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see  https://yt-dl.org/update  on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
Traceback (most recent call last):
  File "/usr/lib/python2.7/dist-packages/youtube_dl/YoutubeDL.py", line 666, in extract_info
    ie_result = ie.extract(url)
  File "/usr/lib/python2.7/dist-packages/youtube_dl/extractor/common.py", line 316, in extract
    return self._real_extract(url)
  File "/usr/lib/python2.7/dist-packages/youtube_dl/extractor/youtube.py", line 1175, in _real_extract
    video_id=video_id)
ExtractorError: ICtkpLqY3BY: "token" parameter not in video info for unknown reason; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see  https://yt-dl.org/update  on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.

Description

script unable to download anything from youtube

I've verified that I'm running youtube-dl version 2019.05.11

You are using a very old version:

[debug] youtube-dl version 2016.02.22

thank you, i'll check the update version.
Pada Minggu, 19 Mei 2019 18.24.38 WIB, bitraid<EMAIL_ADDRESS>menulis:
I've verified that I'm running youtube-dl version 2019.05.11
You are using a very old version:
[debug] youtube-dl version 2016.02.22
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.


postRender problem?

postRender is not call if we do "addItem" in a tab....is it normal?

hi, what do you mean by "a tab"?
Can you create a JSFiddle to reproduce the problem?

an array, sorry for my french ^^

two solution : postRender is call when it geenrate a new cell of my array (when user click on "add item") OR more easy, put a class "additem" on the button, as it,i can know a new rendering was done ?

postRender is called once, when the form is rendered.
Use a decorator instead.
https://github.com/brutusin/json-forms#static-members


Fix autocompletion for sf-client installation

Python Click made changes requiring changes to autocomplete setup.
https://github.com/pallets/click/pull/1622
First released in v8.0.0  2021-05-11

LGTM, thanks for chasing.

LGTM, thanks for chasing.

I should note that this may/will break auto-completion on systems running old version of the click library. It's easily fixed, so maybe we can afford to be a little opinionated on what is supported?

I should note that this may/will break auto-completion on systems running old version of the click library. It's easily fixed, so maybe we can afford to be a little opinionated on what is supported?


[Bug]: 404 page not found

Error Message and Logs
2024-09-21T10:30:40.059750345Z 2024-09-21T10:30:40Z ERR Unable to obtain ACME certificate for domains error="unable to generate a certificate for the domains [wordpress.DOMAIN.com]: error: one or more domains had a problem:\n[wordpress.DOMAIN.com] acme: error: 403 :: urn:ietf:params:acme:error:unauthorized :: 2606:4700:3031::6815:3f97: Invalid response from http://wordpress.DOMAIN.com/.well-known/acme-challenge/tejvAQeTMW_C_6FMnE78ucB2K9lxYB08f2zkpIbxF7I: 404\n" ACME CA=https://acme-v02.api.letsencrypt.org/directory acmeCA=https://acme-v02.api.letsencrypt.org/directory domains=["wordpress.DOMAIN.com"] providerName=letsencrypt.acme routerName=https-0-i0ko08880gkg44s8g4kg4080-wordpress@docker rule="Host(wordpress.DOMAIN.com) && PathPrefix(/)"
Steps to Reproduce

fresh coolify setup (hetzner)
adding remote server (hetzner)
adding Instance's Domain => host.domain.com (cloudflare
A | host | SERVERIP
Custom SSL/TLS => full
creating new project and adding wordpress
auto generated url works fine, now i click "edit domains" putting https://wordpress.domain.com into it (cloudflare
A | wordpress | SERVERIP
Custom SSL/TLS => full
trying to open url => 404 page not found

Example Repository URL
No response
Coolify Version
v4.0.0-beta.341
Are you using Coolify Cloud?
No (self-hosted)
Operating System and Version (self-hosted)
Ubuntu 24.04
Additional Information
No response

I have the same issue. I'm also running the Coolify (running on Hetzner) and Cloudflare combo.
The auto generated URL works fine, but when I fill in a custom domain (in my case: https://example.com:8000,https://www.example.com:8000) while having my domains pointing at the IP of the server I get the 404 page not found error.
The application is running because when I access the IP directly (:) the app is there.
I'm running my application with the docker compose setup on the latest version of Coolify (v4.0.0-beta.341).

@errol59
I found the problem, we need to point to the servers ip that we add to coolify and not coolify itself.


Design the Home Page

Make any required changes to the website home page to reflect current stylings and brand.
Design work for the home page will be done in Figma and can be found there.

Hi @segacy1! Just wanted to check in and see how the design work is going for the Home page. Anything you need? Anthony and I have draft copy in #58 and we're happy to modify it based on the final design. We're still hoping to complete the Home page by the end of Q2, which is crazily this month, so hoping we can package up the content + design for this and hand it off to dev soon. But let me know if that's feeling too tight on your end!

Hi @o-ram! I have 2 options for the homepage:

Text only
Illustrated hero + text

With option 2 (and our about page designs), I did want to ask if the team would be interested in hiring an illustrator to create a few designs for the site (maybe 2-3 hero images, a few spot illustrations, team member photos, and a small icon set). If so, I'd happily work with the illustrator to provide direction. I think one case for illustrations is that they're a (generally) evergreen to add visual interest. We can mix and match and repurpose to create new images for the site without relying on photography and it keeps things looking cohesive/can also use them for other collateral beyond the website.

@ segacy1 I would like to know what everyone thinks about illustrations, but I like illustrations over photos because they are more evergreen and not dependent on staff to be at the center of all images. My only concern and this might not be a thing based on the direction you can provide, is does that make our website too playful and abstract?
As for the Home page, I like the brand mark on top of the heading, so I am leaning towards no image, but if people like the other option, we have some new images we got from our last retreat, and there are some landscape photos of LA that I think would work.

@AnthonyRollins yes, it definitely depends on the illustration style we go with! Ideally, we can share the brand guidelines/do’s and don’ts we came up with to help guide the illustrator too. I think even just expanding our pattern collection for moments like this or creating a small icon set that includes human-centered icons or illustrations like these would have an impact. I could put together a list of exactly what I have in mind/what illustrations id request if that would help!
@machikoyasuda also shared this website with me that's pretty cool. I think we can definitely develop something that feels like Compiler but gives us a little more flexibility in our designs.
As for the mocks, I was thinking that for the last one that doesn't have a brand mark in the nav, we could potentially have a bespoke illustration that says our name.
All that being said, if we just want to get something out this month and shift our focus to the about page (and any illustration that come with that), I like the one you selected and I think that certainly works!

@segacy1 Anthony and I spoke yesterday, and I think we are all in agreement that we want to go with the text-only option so we can keep to the roadmap timeline. We definitely love the idea of illustrations, and are thinking that could be the plan for Home Page v2, when the time comes.
That said, I think where we stand is:

Design is done (text only option)
copy is done. Final copy is in #58 and I left a comment in Figma. LMK if you have any questions!

If that tracks with your thinking, then we can focus on handing this off to dev and move on to about!

Sounds good! Just updated the copy and will update the figma style library today to match the direction we're going with so everything can be ready for dev as of tomorrow.

Updated everything here! Should be good to go.

@segacy1 The heading copy is correct, but the we build software for government sub-heading should use this copy:
Compiler is a woman-owned software consultancy that’s passionate about making government tech solutions easy-to-use   and accessible for all.
Let's update the copy. I will ask about the best way to send the final copy and design to the dev team, but I think having everything in Figma should be the best approach.

@AnthonyRollins the we build software for government copy is what we had worked out in #58 and we identified as needing changing in Figma, so I asked Segacy to change it. Did you mean that you wanted the copy in Figma to be the final?

All good! Updated.

Perfect! I think we can close out this issue.


Error in CustomMultiplayer Poll

Godot version
3.4 beta3 mono
System information
Debian 10
Issue description
I have these errors:
E 0:00:50.130   _process_get_node: Invalid packet received. Unabled to find requested cached node.
  <C++ Error>   Condition "!F" is true. Returned: nullptr
  <C++ Source>  core/io/multiplayer_api.cpp:260 @ _process_get_node()
  <Stack Trace> :0 @ void Godot.NativeCalls.godot_icall_0_3(IntPtr , IntPtr )()
                MultiplayerAPI.cs:256 @ void Godot.MultiplayerAPI.Poll()()
                Gateway.cs:30 @ void DesertEdge.Singleton.Gateway._Process(Single )()

E 0:00:50.130   _process_packet: Invalid packet received. Requested node was not found.
  <C++ Error>   Condition "node == nullptr" is true.
  <C++ Source>  core/io/multiplayer_api.cpp:203 @ _process_packet()
  <Stack Trace> :0 @ void Godot.NativeCalls.godot_icall_0_3(IntPtr , IntPtr )()
                MultiplayerAPI.cs:256 @ void Godot.MultiplayerAPI.Poll()()
                Gateway.cs:30 @ void DesertEdge.Singleton.Gateway._Process(Single )()

Steps to reproduce
I make a custom connection, then I connect a peer, then a disconnect the peer, then I try to reconnect another peer.
The error show up when I try to reconnect another peer.
I use this code in _process:
     public override void _Process(float delta)
        {
            if (CustomMultiplayer == null)
                return;
            if (!CustomMultiplayer.HasNetworkPeer())
                return;
            CustomMultiplayer.Poll();
        }

The error link bring me in "CustomMultiplayer.Poll()" row
Minimal reproduction project
NA

@git2013vb Please upload a minimal reproduction project to make this easier to troubleshoot.

@git2013vb Please upload a minimal reproduction project to make this easier to troubleshoot.

Its no so simple to make one... I'm still in learning mode :).  Often I can resolve my issues but in this one I don't have enough details to understand where the problem lie. There is a way to show a better stack trace and more verbose log? With more details I can try to make a minimal project.

cc @Faless

Hey! I couldn't reproduce this issue in testing, but that is likely due to this being difficult to reproduce without more context.
If you can try to break it down to a project that shows the issues, that'd help immensely. If not, maybe talk to us on the Godot Engine chat, there are ways to provide your project privately for debugging purposes.
Note that the latter is quite time intensive on our side, so no promises.
I'm going to close this for now, as it was working fine in my testing. Please ping us for a reopen if there is any additional info!


zrevrank with score

since redis 7.2.0 WITHSCORE flag added
https://redis.io/commands/zrevrank/
ioredis does not support it currently

** Didnt notice the 7.2 version is still candidate release, but will leave the issue here for when it will be released**

Can I work on this?

Both zrank and zrevrankshould have support for this. I would need this feature


Refactor bitfan binaries

binaries are now in cmd/

bitfan
bitfanUI - WebUI
bitfanDoc - documentation generator

Changes Unknown when pulling 13d9ff8df6d771b4f237c461721dc48498bf03cf on refactor-bitfan-cmd into ** on master**.

Changes Unknown when pulling 0a9db297e783b5275fa0a83dc97ff50ec3dfe2b0 on refactor-bitfan-cmd into ** on master**.

Changes Unknown when pulling 076be9cdca208a062ed3b5c9b5ffe413afd87e70 on refactor-bitfan-cmd into ** on master**.

Changes Unknown when pulling 97ff580dc78a08469ed44b78bb741acad1129227 on refactor-bitfan-cmd into ** on master**.

Changes Unknown when pulling 8aad37e30361ffb3aa394460abda4b824300475c on refactor-bitfan-cmd into ** on master**.


Update test-and-deploy-microsoft-365-apps.md

Added a note about test deployment and what it means

@JohanFreelancer9 Please copy review

Issue#https://github.com/MicrosoftDocs/microsoft-365-docs/issues/9465

Docs Build status updates of commit 8e1a41b:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-365/admin/manage/test-and-deploy-microsoft-365-apps.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 4d51276:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-365/admin/manage/test-and-deploy-microsoft-365-apps.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

@kwekuako Please merge this PR. Thanks

@kwekuako Gentle reminder

Learn Build status updates of commit f547920:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-365/admin/manage/test-and-deploy-microsoft-365-apps.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

Learn Build status updates of commit b32a667:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-365/admin/manage/test-and-deploy-microsoft-365-apps.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel


feat(#194): Add the first implementation of the RuleOnlyTestMethods

Add the first implementation of the RuleOnlyTestMethods rule.
Closes: #194

PR-Codex overview
This PR focuses on improving the test class characteristics in the codebase.
Detailed summary

Updated the isNotJUnitExtension method in ProjectWithoutJUnitExtensions.java to use the characteristics() method.
Added exclusion for JTCOP.RuleNotContainsTestWord in pom.xml.
Added documentation for RuleOnlyTestMethods in docs/rules/only-test-methods.md.
Updated assertions in test classes to use the characteristics() method instead of isJUnitExtension().
Added new test cases and methods in test classes for CharacteristicsJavaParser.

The following files were skipped due to too many changes: src/main/java/com/github/lombrozo/testnames/TestClass.java, src/test/java/com/github/lombrozo/testnames/bytecode/BytecodeTestClassCharacteristicsTest.java, src/main/java/com/github/lombrozo/testnames/bytecode/BytecodeTestClassCharacteristics.java, src/main/java/com/github/lombrozo/testnames/rules/RuleOnlyTestMethods.java, src/main/java/com/github/lombrozo/testnames/TestClassCharacteristics.java

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@rultor merge

@rultor merge

@volodya-lombrozo OK, I'll try to merge now. You can check the progress of the merge here

@rultor merge

@volodya-lombrozo Done! FYI, the full log is here (took me 3min)


nvim netrw and lightline visibility.

duplicate of https://github.com/itchyny/lightline.vim/issues/269


Cannot resolve recursive copy of configuration with cyclic project dependencies.

Here's all the context you need -
https://discuss.gradle.org/t/cannot-resolve-recursive-copy-of-configuration-with-cyclic-dependencies-within-beforeresolve/8726
https://github.com/spring-gradle-plugins/dependency-management-plugin/issues/46

@bigdaz @melix @jjohannes Could you please comment on this?

Closing as duplicate of #1638


Break up into separate dylibs

I'd suggest building each command as a dynamic library (either .dylib or .framework), and lazy loading them at runtime.
As noted in the README, all the code for all of the commands is loaded into memory at app launch. This seems wasteful & unnecessary, and probably won't scale too well when adding more commands over time.
Additionally, it looks like they are currently being built into a single Xcode target. It'd be great if each command was its own target, with defined inputs/outputs (i.e. build these source files into this dylib). That way it's easier to pick & choose, and scales better.

I think I can close this one.


checkout manually to avoid detached HEAD

Should we include this in the 1.1.0 release right?

Should we include this in the 1.1.0 release right?

No I'm going to close it. Default gitlabci executor is getting properly commit so no need for most cases


Missing jar files in v1.3.1 release

No binaries are currently available from:
https://github.com/cstaelin/Stats-Extension/releases/tag/v1.3.1
See:
http://stackoverflow.com/questions/29616944/stats-extension-no-stats-jar-file

Fixed in v1.3.2.

Thanks for taking care of this! Note, however, that committing the jar files to your repo is not ideal. As shown in https://github.com/blog/1547-release-your-software, you can attach binaries to your releases:

The best practice is to upload a separate zip file with only what the users need (in most cases: only the jars).

Thanks Nicolas.  I'm still learning this release stuff, and slowly!  I have
an upcoming addition to the extension and I'll make that change when I
publish it.
Best,
Charles

Charles P. Staelin
Professor and chair, Department of Economics
Director, Global South Development Program
Smith College
Northampton, MA 01063
On Tue, Apr 14, 2015 at 10:15 AM, Nicolas Payette<EMAIL_ADDRESS>wrote:

Thanks for taking care of this! Note, however, that committing the jar
files to your repo is not ideal. As shown in
https://github.com/blog/1547-release-your-software, you can attach
binaries to your releases:
[image: screenshot]
https://camo.githubusercontent.com/63e25ab0df8956e54ffc5822c7508a6e428b7b62/68747470733a2f2f662e636c6f75642e6769746875622e636f6d2f6173736574732f32312f3733373937352f62393837656136322d653333622d313165322d393332622d3335366437356338363338352e6a7067
The best practice is to upload a separate zip file with only what the
users need (in most cases: only the jars).
—
Reply to this email directly or view it on GitHub
https://github.com/cstaelin/Stats-Extension/issues/2#issuecomment-92867743
.


Docs: Add a pull request template

We can use a pull request template to nudge contributors to add information to the PRs that make it easier to review them.
This template is based on https://github.com/twbs/bootstrap/blob/main/.github/PULL_REQUEST_TEMPLATE.md?plain=1 but change to fit the tagging schema.
My idea is, to nudge contributors to first add more context to PRs like links. But then after the preview was generated, to get back , edit the description and add more links and screenshots that make it super fast to review the PRs.

Here are the docs on adding those templates. In general they are much less fancy than the issue templates, so it's just a Markdown template.
https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/creating-a-pull-request-template-for-your-repository

I like this idea as it helps us newbies to provide all necessary informations.
Maybe we could add a hint in the "Related issues"-Section to use the closes #Issue-Number Syntax because sometimes issues stay open after the related PR was merged (Example 1, Example 2) and afaik by using closes #... these Issues are closed automatic after a successful PR.

Note to self: New users don't get the preview (and checks) automatically. Once a PR was merged, the checks run for that user automatically.

This is a test comment to test the copy-paste template

Test-Documentation
Preview links & Sidebar Screenshots

Search

Info-i

Wording

[ ] American English
[ ] name, aliases (if present) use Title Case
[ ] terms (if present) use lower case, sorted A-Z

@tyrasd  this is ready to be merged from my point of view. It will make new PRs a lot easier to review…
I will iterate on it if needed once we learn how people use / understand it.

Personally, I prefer the description to be in an issue and not duplicated, but I know that this will be annoying for the contributors and maintainers (these groups usually make PRs without issues). As such, my recommendation is that this template should only be used when there isn't an issue linked to the PR

Personally, I prefer the description to be in an issue and not duplicated,

Agreed. However I would assume people are lazy and will just leave this part blank or reference the issue for the first section.
While reviewing the PRs recently I found that the issue did not really help a lot, which is why I ask for more context here.
The issues are sometimes created by users that only know the wiki link of a tag but don't know how to do more research on it. My goal for the PR is to ask people to do this research now …
I think we can see how it goes with this one and modify if needed.

I think we can see how it goes with this one and modify if needed.

I fully agree let's see how it will work in the wiled


Update Blog “2017-01-04-just-in-small-batch-of-jamaican-blue-mountain-in-store-next-week”

Automatically generated by Netlify CMS

👷 Deploy Preview for nervous-engelbart-a15395 processing.
🔨 Explore the source changes: 571268b32fdca992ee6ace362c6354c15358f699
🔍 Inspect the deploy log: https://app.netlify.com/sites/nervous-engelbart-a15395/deploys/61b37937bcfee000083c9124


SUBMARINE-377. [SDK] Submit a job by pysubamrine

What is this PR for?
Use python SDK to submit a submarine job.
What type of PR is it?
[Improvement]
Todos

[ ] - Task

What is the Jira issue?
https://issues.apache.org/jira/browse/SUBMARINE-377
How should this be tested?
https://travis-ci.org/pingsutw/hadoop-submarine/builds/648336769
Screenshots (if appropriate)
Questions:

Does the licenses files need update? No
Is there breaking changes for older versions? No
Does this needs documentation? No

Can this feature add e2e tests to submarine-test/e2e?

Thanks @liuxunorg for the suggestion. Could I file anthoer JIRA ticket for e2e tests

Update patch.

remove pb2*.py that generated from protobuf
update readme

Update patch.

A README describes how to use sdk to submit a job
Use REST to submit a job to submarine server
Unit tests for the client (e2e test will add in next pr)

@liuxunorg @yuanzac, Could you help me review the new patch


Step-7: Add filtering based on task state.

Step-7
Add Task filtering to app.
Changes
1.By default, show all the cards and make all as default filter.
2.Upon click on Incomplete , show only the incomplete tasks and same for Complete and All.
3.Make filtering play nice with pagination.

@sta-wtag apu, couldn't run locally. Fails with the following errors. Also please consider using yarn.lock or package-lock.json, but not both as it'll create a problem with versions. Please have a look, thanks.


Clear the data in stringBuffers_ when the filtering rate is 100%

When the Filter filtering rate is 100%, clear the data in stringBuffers_, otherwise the TableScan operator will occupy a lot of memory.

@Yuhta Can you help to review this PR?

Can you give some more context where the high memory usage happens?  In ideal case, one split should contain only one stripe or row group to maximize the parallelism, and in that case the column readers are release right after the only stripe is read, so no memory is left over.  Are you scheduling one split to contains a lot stripes?

@Yuhta In my test environment, the input parameter of HiveDataSource's addSplit function is an entire Parquet file (size is about 250MB). This Parquet file contains more than 20 columns, each column is of string type (length is more than 40KB after decompress), and then when filtering When the rate is 100%, a lot of data is accumulated in stringBuffers_, eventually leading to OOM.

@Yuhta
What other variables do you think need to be cleared in this test scenario? values_?


Pulling data to chosen

I am working on a project where we are trying to use chosen for a filter drop down. We have the list set up and are sucessfully pulling data to the list box. However, when we implement chosen we can still see the data in the DOM but we get nothing in the chosen list. Is anyone familiar with this? Is this a possible bug or am I just doing something wrong?

Hey @jtmurphree
Can you share the markup of the list where you used the directive? It should be something like this:
<select chosen options="properties"
        ng-model="property.name"
        ng-options="p.name as p.name for p in properties">
</select>

Make sure you add the options attribute. If you are using options and still facing an issue:

is the options attribute a promise?
can you share a sample json of the data?

actualy turns out it was rendering before the data was populated. We have solved the problem. Thank you.


Can't viewWillAppear on iOS 9 due to Unsatisfiable Constraints but only in fresh install of app

:muscle::sunglasses::facepunch:
Only on a fresh install I am getting an error related to NSLayoutContstraints when trying to display my subclass of JSQMessagesViewController.
Weirdly, if you kill the app out of memory (not uninstall) everything is fine the next time you come back and try to open the chat.
Steps to reproduce

On a FRESH INSTALL of the app
Try to open the chat window
Get stuck on view will appear in JSQMessagesViewController and chat screen never appears.

When I put in a breakpoint for UIViewAlertForUnsatisfiableConstraints it stops on [self.view layoutIfNeeded]; in viewWillAppear for JSQMessagesViewController:

Environment

Using JSQMessagesViewController 7.2.0 (also tried 7.1.0, still had the issue)
Built in XCode 7
I CAN reproduce this on an iPhone 6 simulator with iOS 9.0  and iPod touch with iOS 9.0.1
I CANNOT reproduce this issue on an iPhone 6 simulator with iOS 8.4

Error from console
Unable to simultaneously satisfy constraints.
	Probably at least one of the constraints in the following list is one you don't want. Try this: (1) look at each constraint and try to figure out which you don't expect; (2) find the code that added the unwanted constraint or constraints and fix it. (Note: If you're seeing NSAutoresizingMaskLayoutConstraints that you don't understand, refer to the documentation for the UIView property translatesAutoresizingMaskIntoConstraints)
(
    "<NSAutoresizingMaskLayoutConstraint:0x7ffcc3bfa760 h=--& v=--& H:[UIView:0x7ffcc3e14d30(0)]>",
    "<NSLayoutConstraint:0x7ffcc3bfb540 H:[UIView:0x7ffcc3b439b0(34)]>",
    "<NSLayoutConstraint:0x7ffcc3f024b0 H:[UIView:0x7ffcc3b83380(41)]>",
    "<NSLayoutConstraint:0x7ffcc3dec850 H:|-(8)-[UIView:0x7ffcc3b439b0]   (Names: '|':JSQMessagesToolbarContentView:0x7ffcc3d61e20 )>",
    "<NSLayoutConstraint:0x7ffcc3dec990 H:[UIView:0x7ffcc3b439b0]-(8)-[JSQMessagesComposerTextView:0x7ffcc1d66400]>",
    "<NSLayoutConstraint:0x7ffcc3dec9e0 H:[JSQMessagesComposerTextView:0x7ffcc1d66400]-(8)-[UIView:0x7ffcc3b83380]>",
    "<NSLayoutConstraint:0x7ffcc3deca80 H:[UIView:0x7ffcc3b83380]-(8)-|   (Names: '|':JSQMessagesToolbarContentView:0x7ffcc3d61e20 )>",
    "<NSLayoutConstraint:0x7ffcc3d71c80 JSQMessagesInputToolbar:0x7ffcc3870ac0.leading == JSQMessagesToolbarContentView:0x7ffcc3d61e20.leading>",
    "<NSLayoutConstraint:0x7ffcc3d91c10 H:[JSQMessagesToolbarContentView:0x7ffcc3d61e20]-(0)-|   (Names: '|':JSQMessagesInputToolbar:0x7ffcc3870ac0 )>",
    "<NSLayoutConstraint:0x7ffcc3e151c0 H:[JSQMessagesInputToolbar:0x7ffcc3870ac0]-(0)-|   (Names: '|':UIView:0x7ffcc3e14d30 )>",
    "<NSLayoutConstraint:0x7ffcc3e15210 H:|-(0)-[JSQMessagesInputToolbar:0x7ffcc3870ac0]   (Names: '|':UIView:0x7ffcc3e14d30 )>"
)

Will attempt to recover by breaking constraint
<NSLayoutConstraint:0x7ffcc3f024b0 H:[UIView:0x7ffcc3b83380(41)]>

Make a symbolic breakpoint at UIViewAlertForUnsatisfiableConstraints to catch this in the debugger.
The methods in the UIConstraintBasedLayoutDebugging category on UIView listed in <UIKit/UIView.h> may also be helpful.

Not sure if this will surprise anyone, but I did pull down the JSQMessagesViewController sample app for the 7.2.0 release and COULD NOT reproduce the issue.

@atroutt thanks so much! :muscle: :heart: :+1:
Looks like auto-layout behavior has changed in iOS 9. Which isn't surprising because every iOS release since iOS 7 has broken something :smile:
Interesting that the demo doesn't reproduce this. Are you loading a lot of messages? Or none?

I think this is one of the best reports anyone has ever provided. :blush:

When viewWillAppear there are no messages yet. We are pulling messages in from Firebase, but at the time, they haven't arrived yet.
I tested on the sample project with and without messages and did not experience the issue. I'm going to keep moving my code to the sample project to see if I can force the issue.

aww thanks :blush:

THIS IS NOT YOUR FAULT!
Ugh... I finally did a git bisect on my project and it turns out upgrading Branch.io from 0.10.9 to 0.11.4 causes this issue. I HAVE NO IDEA WHY.
Sorry for wasting your time!

branch.io has had similar issues with me. They make a 0x0 UIWindow on first launch that breaks a ton of stuff including BRYXBanner

It looks like they just released 0.11.5, which does not cause the issue.

Thanks for the update @atroutt ! :smile: No worries!

Im having exactly the same issue on the same line, but i dont use branch.io.
Trying to find if some other library is creating this issue...


chore(provider): remove redundant aws provider

Description

Specifying AWS provider alias via additional provider block is not needed anymore. Tested with Terraform 1.5.
How Has This Been Tested?
I was getting following waning
│ Warning: Redundant empty provider block
│
│   on .terraform/modules/cloudtrail/provider.tf line 4:
│    4: provider "aws" {
│
│ Earlier versions of Terraform used empty provider blocks ("proxy provider configurations") for child modules to declare their need to be passed a provider configuration by their callers. That approach was
│ ambiguous and is now deprecated.
│
│ If you control this module, you can migrate to the new declaration syntax by removing all of the empty provider "aws" blocks and then adding or updating an entry like the following to the
│ required_providers block of module.cloudtrail:
│     aws = {
│       source = "hashicorp/aws"
│       configuration_aliases = [
│         aws.destination,
│       ]
│     }

after removal of the redundant provider is it not present anymore. Tested with Terraform 1.5.

Seems additional provider is still needed, see https://github.com/lablabs/terraform-aws-cloudtrail/actions/runs/11124936318/job/30911565979


Shooting while moving using time of flight

The target logic does update in sim, needs to test irl. Looking for feedback

will review later tonight

Moved interpolation to shooter data distance points. In simulation at least, the target position did seem to update to where it should theoretically be so one can hope that it will work when going forwards and backwards. Still need to add ToF points and update the CSV parser

My goal is to test this over the week in class and if all goes well, get it merged in by the end of the year


Fix: Update 404 URLs in the example section of docs

Fix all links throwing 404 in the examples page of the docs :).
...examples/vite -> .../react-vite etc.

Thank you!


Optional[datetime] field with value null/None gets isoparse'd

I have a field in my generated model like this:
timestamp: Union[Unset, datetime.datetime] = UNSET
My API returns {"timestamp": null}, which then gets deserialized as None, and ends up in the else clause of this generated code:
        if isinstance(_timestamp, Unset):
            timestamp = UNSET
        else:
            timestamp = isoparse(_timestamp)

.. when then ends up raising in dateutil's isoparser.py.
I'm using 0.10.1 and saw https://github.com/openapi-generators/openapi-python-client/issues/381 and https://github.com/openapi-generators/openapi-python-client/pull/420 - wondering if datetime.datetime wasn't fixed with that issue or if I'm doing something wrong?

If the type of the generated model is Union[Unset, datetime.datetime] then I’m guessing the schema doesn’t have nullable set. In which case, null is an invalid value for the server to be returning according to the schema.
See https://github.com/openapi-generators/openapi-python-client/discussions/385 for more info on the required vs nullable difference in spec.
If your schema does have nullable: true in it then it sounds like a generation bug, as the type should be Union[Unset, datetime.datetime, None] (if not required) or Optional[datetime.datetime] (if required).

thanks for the quick response!
yeah, I was indeed missing nullable fields :) adding it changed the parameter from Union[Unset, datetime.datetime] to Optional[datetime.datetime]. Unfortunately that also caused an additional problem - ironically enough it seems the parameter is no longer optional when instantiating the model class.
for example, in the generated from_dict method, the line changed from:
timestamp = d.pop("timestamp", UNSET)

to
timestamp = d.pop("timestamp")

and similarly, a timestamp argument now needs to be specified if instantiating via the constructor.

Sounds like now it thinks the parameter is in the required list. Did you happen to add it there when you added nullable?

Just to be a little more clear, I believe you have a schema that looks something like this (depending on where it's defined). The property being nullable and also required means that it has to be set, but could be set to null. If you remove it from required then it could be null, but could also be omitted (leading to UNSET).
"AModel": {
    "required": [
         "timestamp"
    ],
    "type": "object",
        "properties": {
            "timestamp": {
                "type": "string",
                "format": "date-time",
                "nullable": true
            }
        }
}

thanks @dbanty, that was the problem. I'm using pydantic/fastapi, and adding = pydantic.Field(..., nullable=True) to the field somehow ended up making it required in the openapi output. appreciate the help!


AttributeError: 'HTTPRequest' object has no attribute 'headers' in 1.4.1

Can't even use the tool

Would you mind sending a sample request

This type of error is the same as what I wanted to explain here. Mine was giving this error too.
https://github.com/r0oth3x49/ghauri/issues/195


WPF touchscreen zoom

Suggestion:
mine attempt at multitouch zoom for touchscreen. It works well, but it can use some polishing.
ScottPlot.WpfPlot myPlot = new();
myPlot .TouchDown += OnTouchDown;
myPlot .TouchMove += OnTouchMove;
myPlot .TouchUp += OnTouchUp;

 private double _initialDistance;
 private bool _isPinching;
 private Dictionary<int, TouchDevice> _activeTouches = new Dictionary<int, TouchDevice>();

OnTouchDown
This method is for detecting if there are 2 touches, if yes then disable every interaction, save distance and enable manipulation for smoother movement.
Enabling manipulation disables right click, and other actions, but it helps a lot with smoothnes of zooming, also allows you to use SendMouseScrollEvent. Without disabling the manipulation you need to zoom using Plot.Axes.Zoom(zoomFactor, zoomFactor);
        private void OnTouchDown(object sender, TouchEventArgs e)
        {
            if (!_activeTouches.ContainsKey(e.TouchDevice.Id))
            {
                _activeTouches.Add(e.TouchDevice.Id, e.TouchDevice);
            }

            if (_activeTouches.Count == 2)
            {
                _isPinching = true;
                var touches = _activeTouches.Values.ToList();
                _initialDistance = GetDistance(touches[0], touches[1]);
                (sender as WpfPlot).IsManipulationEnabled = true;
                (sender as WpfPlot).Interaction.IsEnabled = true;
                (sender as WpfPlot).UserInputProcessor.IsEnabled = false;

            }
        }

OnTouchMove
this method sends mouse scroll to the graph, and calculates new distance between points
private void OnTouchMove(object sender, TouchEventArgs e)
{
    if (_isPinching && _activeTouches.Count == 2)
    {
        var touches = _activeTouches.Values.ToList();
        double newDistance = GetDistance(touches[0], touches[1]);

        // Calculate the change in distance
        double distanceChange = newDistance - _initialDistance;

        // Perform zoom based on distance change
        if (Math.Abs(distanceChange) > 10)
        {

            _initialDistance = newDistance; // Update the initial distance for continuous zooming

            if (distanceChange > 2)
                SendMouseScrollEvent(1);
            else
                SendMouseScrollEvent(-1);
            (sender as WpfPlot).Refresh();
/*
another option is to calculate zoom scaling and use it,
  SettingsMine.FloatingXaxisSens is for changing zoom sensitivity, it is float, must be bigger than 1
*/
/* double zoomFactor = distanceChange > 2 ? SettingsMine.FloatingXaxisSens: 1 / SettingsMine.FloatingXaxisSens;
                      (sender as WpfPlot).Plot.Axes.Zoom(zoomFactor, zoomFactor);
*/
        }
    }
}

[DllImport("user32.dll")]
private static extern void mouse_event(uint dwFlags, uint dx, uint dy, int dwData, int dwExtraInfo);

private const uint MOUSEEVENTF_WHEEL = 0x0800;

private void SendMouseScrollEvent(int scrollAmount)
{
    mouse_event(MOUSEEVENTF_WHEEL, 0, 0, scrollAmount, 0);
}

OnTouchUp
If there are less than 2 touching points, you should disable manipulation and enable interaction/UserInputProcessor
if (_activeTouches.ContainsKey(e.TouchDevice.Id))
 {
     _activeTouches.Remove(e.TouchDevice.Id);
 }

 if (_isPinching && _activeTouches.Count < 2)
 {
     _isPinching = false;
     (sender as WpfPlot).IsManipulationEnabled = false;
     (sender as WpfPlot).Interaction.IsEnabled = false;
     (sender as WpfPlot).UserInputProcessor.IsEnabled = true;

 }

GetDistance
I would like to change this method, since it does rely on WpfPlot reference, so in my case i have 3 _if_s depending on which graph is selected.
private double GetDistance(TouchDevice touch1, TouchDevice touch2)
 {
     Point p1;
     Point p2;
         p1 = touch1.GetTouchPoint(myPlot ).Position;
         p2 = touch2.GetTouchPoint(myPlot ).Position;
         return Math.Sqrt(Math.Pow(p2.X - p1.X, 2) + Math.Pow(p2.Y - p1.Y, 2));
 }

Thanks for sharing this @Tadza0641! It will be really useful for others wishing to add multitouch support to their apps. If someone wants to try modifying the WPF control to add these features, I would be happy to review a pull request 😄


Victor VosMottor: Watch medpack.in

Victor VosMottor requests the watch of the watch_keyword medpack\.in. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

medpack\.in has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by tripleee in Charcoal HQ


fast_default_resource_pack caused crash

I have installed CoreTweaks-1.7.10-<IP_ADDRESS>+nomixin
When I disable this option, the crash no longer occurs.
Here is a log
fml-client-latest.log
I'm not sure what's causing this issue，could you please fix this issue or tell me what I should do next?🙂

This sounds like a duplicate of #25, which should be fixed as of <IP_ADDRESS> (which was just released). Try updating.

Yes, the new version fixes the issue and the game now launches properly.


Add Gif support

This will require some changes to the UI, validation and image handling logic we have.
The canvas library we currently use to process images doesn't support Gifs across all 3 operating systems (I think it MIGHT support it on Mac).

Will animated .png work?

GIFs not working...


[ENHANCEMENT]: SCSS Linting

Project Enhancement or Maintenance Idea
Describe the enhancement or maintenance

It would be good to install an SCSS linter such as Stylelint so we can standardise code.
Acceptance criteria

[ ] Install a linter to lint SCSS
[ ] Lint any files that need linting
[ ] Add a linting check to the pipeline

Why is this enhancement or maintenance important?

This is important to ensure consistency across SCSS code patterns

Project already has linting 🤦♂


TypeScript: Return type of useRemixForm hook is incorrect.

Hi,
Thanks for building this package!
I'm trying to migrate my app from remix-validated-form to this one but I've run into some issue regarding TS types.
Loos like useRemixForm is incorrectly returning form types.
Here's the type returned from react-hook-form:

...and here's remix-hook-form:

You can see the values are incorrectly typed as undefined. According to the zod schema, those fields should never be undefined just like in the first example.
const schema = z.object({
  name: z.string().trim().min(3).max(32),
  slug: z.string().trim().min(3).max(32),
})

hi @piotrkulpinski, I'll look into this but you can pass in the schema type as a workaround and it will work correctly, eg. useRemixForm<YourSchema>()

hi @piotrkulpinski, I'll look into this but you can pass in the schema type as a workaround and it will work correctly, eg. useRemixForm<YourSchema>()

Tried that, but this has given me even bigger problems with typing the models correctly.

Hmm can you guys install the latest versions of remix-hook-form and react-hook-form and let me know if that resolves it? It could be a mismatch between the versions, but what is important to note is that the return types ARE different, there are a few changes added on top of react-hook-form so they can't be identical, like handleSubmit, register, reset etc are enhanced for remix use-cases

Hi @AlemTuzlak, any way you can expose the equivalent type of UseFormReturn which remix-hook-form is using? I'm passing the form object to a custom hook so no way to init the form there.
export function useSomeCustomHook(
  setSomeState: React.Dispatch<React.SetStateAction<boolean>>,
  form: UseFormReturn,
) {..}

Running into the same issue. I have the latest versions of both react-hook-form and remix-hoko-form.
Here's the error I am seeing:
Type '{ children: Element; handleSubmit: (e?: BaseSyntheticEvent<object, any, any> | undefined) => Promise<void>; reset: (values?: { email: string; password: string; } | { ...; } | undefined, options?: Partial<...> | undefined) => void; ... 12 more ...; setFocus: UseFormSetFocus<...>; }' is not assignable to type 'UseFormReturn<{ email: string; password: string; }, any, undefined>'.
  Types of property 'reset' are incompatible.
    Type '(values?: { email: string; password: string; } | { email?: string | undefined; password?: string | undefined; } | undefined, options?: Partial<{ keepDirtyValues: boolean; keepErrors: boolean; keepDirty: boolean; ... 7 more ...; keepSubmitCount: boolean; }> | undefined) => void' is not assignable to type 'UseFormReset<{ email: string; password: string; }>'.
      Types of parameters 'values' and 'values' are incompatible.
        Type '{ email: string; password: string; } | { email?: string | undefined; password?: string | undefined; } | ResetAction<{ email: string; password: string; }> | undefined' is not assignable to type '{ email: string; password: string; } | { email?: string | undefined; password?: string | undefined; } | undefined'.
          Type 'ResetAction<{ email: string; password: string; }>' is not assignable to type '{ email: string; password: string; } | { email?: string | undefined; password?: string | undefined; } | undefined'.ts(2322)

My code:

const schema = z.object({
  email: z
    .string({ required_error: "Email is required" })
    .email("Email is invalid"),
  password: z.string({ required_error: "Password is required" }),
});
type FormData = z.infer<typeof schema>;

// Form component is from shadcn
export default function Login() {
  const form = useRemixForm<FormData>({
    mode: "onSubmit",
    resolver,
  });
  return (
      <Form {...form}>
        <form onSubmit={form.handleSubmit} className="space-y-8">
          <FormField
            control={form.control}
            name="email"
            render={({ field }) => (
              <FormItem>
                <FormLabel>Email</FormLabel>
                <FormControl>
                  <Input placeholder="shadcn" {...field} />
                </FormControl>
                <FormDescription>
                  This is your public display name.
                </FormDescription>
                <FormMessage />
              </FormItem>
            )}
          />
          <FormField
            control={form.control}
            name="password"
            render={({ field }) => (
              <FormItem>
                <FormLabel>Password</FormLabel>
                <FormControl>
                  <Input placeholder="shadcn" {...field} />
                </FormControl>
                <FormDescription>
                  This is your public display name.
                </FormDescription>
                <FormMessage />
              </FormItem>
            )}
          />
          <Button type="submit">Submit</Button>
        </form>
      </Form>
  );
}

@makrandgupta It seems you're using the FormProvider from react-hook-form the two are not interchangeable as the remix-hook-form package augments certain functions to allow for easier handling in Remix.
@usr3 I now export UseRemixFormReturn type

a lot of issues arise from the fact that remix-hook-form has different types compared to react-hook-form, I'm closing this for now as this was opened a while ago and I've changed the signatures of many of these functions, please feel free to open new issues!


Update es_419.json

Added new keys

Could you update tip15 to use $keybind_keyPickBlock like in en_us?

Thank you, merging now


DEV Bot stop working after 9-20 minutes with ServerBusyorOfflineException

Expected Behavior
Bot should run constantly without problems. Or at least autorecover.
Actual Behavior
[16:37:21]  PokemonGO Bot v1.0
After 9 minutes the bot produce the following:
[16:46:17]  Server seems to be busy or offline - try again - 1/5
[16:46:18]  Server seems to be busy or offline - try again - 2/5
[16:46:18]  Server seems to be busy or offline - try again - 3/5
[16:46:20]  Server seems to be busy or offline - try again - 4/5
[16:46:20]  Server seems to be busy or offline - try again - 5/5
[16:46:20]  Server seems to be busy or offline - try again - 1/5
[16:46:21]  Server seems to be busy or offline - try again - 2/5
[16:46:22]  Server seems to be busy or offline - try again - 3/5
[16:46:23]  Server seems to be busy or offline - try again - 4/5
[16:46:25]  Server seems to be busy or offline - try again - 5/5
Traceback (most recent call last):
File "pokecli.py", line 494, in
File "pokecli.py", line 81, in main
File "pokecli.py", line 89, in report_summary
File "pokemongo_bot\metrics.py", line 75, in capture_stats
File "pokemongo_bot\api_wrapper.py", line 74, in call
pgoapi.exceptions.ServerBusyOrOfflineException
Additional information
The servers are working properly the master branch work properly.
Changing the api_wrapper requests per second to 1 delay the problem for another 9 minutes or so
I tried stoping the SpinForts,MoveForts Tasks.
Also tried both path and spiral.
It seems after some number of API calls the servers stop answering.
This time may depend on the area where the bot is running.
From the debug logs it seems that GET MAP OBJECTS requests are the first 5 failing attempts
status_code: 2
request_id:<PHONE_NUMBER>888207460
requests {
request_type: GET_MAP_OBJECTS
then 5 attempts on
status_code: 2
request_id:<PHONE_NUMBER>888207460
requests {
request_type: GET_INVENTORY
}
requests {
request_type: GET_PLAYER
}
Steps to Reproduce
Other Information
OS: Win7
Git Commit: 3fe8eb07c098c45c87db0d643d579ac4f7464cf6

Duplicate issue - See: https://github.com/PokemonGoF/PokemonGo-Bot/issues/2009


Update glyphs to 2.4.2-1017

After making all changes to the cask:

[x] brew cask audit --download {{cask_file}} is error-free.
[x] brew cask style --fix {{cask_file}} left no offenses.
[x] The commit message includes the cask’s name and version.

Thank you for the contribution. It was merged directly as 264d90f758216f113e371d5549031aba7c7d9035. Your contribution is still credited to you.


Update the way to access libsox global config

Preparation for splitting libtorchaudio and _torchaudio.
When two libraries are compiled separately, and each code does
#include <sox.h> independently, two copies of libsox's static global
variables (sox_globals_t) are created.
Our code should be referring to the same instance. To achieve this,
_torchaudio should be accessing the global variable defined in
libtorchaudio via the custom utility functions, and it should not
directly use sox_get_globals.

@hwangjeff
In https://github.com/pytorch/audio/pull/1752, the vorbis large header test was failing.
https://app.circleci.com/pipelines/github/pytorch/audio/7223/workflows/8ad268f4-b970-4128-87b8-60c7af957cca/jobs/320861
After the investigation, it turned out that when splitting the compilation of _torchaudio into libtorchaudio and _torchaudio, the direct use of sox_get_globals cause the problem.


Create pull_request_template.md

Goal: highlight user impact of changes and encourage docs and recorded demos at time of pull requests to potentially be used for automated updates when deployed.

Thanks!


question: is it possible to send arbitrary specific app messages from pipecat to client using RTVI 2.0?

Is there a defined approach to do this in RTVI & Pipecat? I see on the onGenericMessage callback in the rtvi client but I don't see any pipecat frame messages that allow for this. Any suggestions?

Hi @brelig ! You can try sending a TransportMessageUrgentFrame and copy one of the existing RTVI messages, for example:
https://github.com/pipecat-ai/pipecat/blob/main/src/pipecat/processors/frameworks/rtvi.py#L337-L340
All you need is the rtvi-ai label and a custom type value.
Then you can just send it downstream:
        frame = TransportMessageUrgentFrame(message=message.model_dump(exclude_none=exclude_none))
        await self.push_frame(frame)

If the message is not handled by RTVI client (which it will not since you set your custom type) you will then get it through the onGenericMessage callback.

@brelig I agree with @aconchillo. This is the recommended approach. If you have any other questions, feel free to drop ask in Discord or reopen the issue.


Can we have a 'friendly' name for the clusters? So we don't send "Peloton is a Linux Based Supercomputer primarily used by the UC Davis College of Letters and Science account" and we just send Peloton. Or Farm. Or Franklin.

Addressed by PR #251


Cosmos DB users and Azure AD RBAC

We are trying to update our application to use a ManagedIdentity instead of a primary key but are still stumbling upon an issue.
We have the following code in our application:
var client = new CosmosClient(...);
client.GetDatabase(databaseId).GetUser(userId);

The error we receiving is the following:

Action cannot be authorized by AAD token in data plane.

The documentation states the following:

This permission model only covers database operations that let you read and write data. It does not cover any kind of management operations, like creating containers or changing their throughput. This means that you cannot use any Azure Cosmos DB data plane SDK to authenticate management operations with an AAD identity.

I'm somewhat confused with the term "management operations". Is creating a user defined as a management operation?
Based on the permission model defined on the documentation page I assume this isn't supported with Azure AD RBAC?
Is this correct?
For management operations like this, we should still use a primary key then?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: aba612b3-f404-11b2-45d9-6e10f1fbf11d
Version Independent ID: 86ccb46e-5ebd-50a4-a911-2ac83c8a41f4
Content: Configure role-based access control for your Azure Cosmos DB account with Azure AD
Content Source: articles/cosmos-db/how-to-setup-rbac.md
Service: cosmos-db
GitHub Login: @ThomasWeiss
Microsoft Alias: thweiss

@thomasvdb Thank you for providing your feedback. We are looking into this and will get back shortly.

@thomasvdb Yes, managing users is not covered by our data plane RBAC. May I ask what is exactly your use-case? If you're using our AAD-based RBAC, why do you need to create users in your database?

@ThomasWeiss We're using it for isolation purposes. When a user accesses our application, they access it in a particular security context. There's a direct link between this security context and the partition key in our collections.
So when the user accesses the application for the first time, we create a user and give it read/write permission on that particular partition key only. Everytime a query is executed against Cosmos DB we're using that user.
If, for instance, a programming error happens were the the wrong partition key is used (a partition key of another customer because of an incorrect manual override for example) we would get an Exception.

@thomasvdb Thanks for clarifying your use-case.
Right now, and as you've quoted in your issue above, our data plane RBAC only covers operations that read/write data. Creating users and permissions is considered a management operation, so it is not covered currently so you'll have to continue using the primary key for these operations.
Note that we plan to add partition-level scoping to our RBAC in the future, which should let you rely on AAD identities end-to-end without the need for resource tokens.
#please-close


Adapt UltraFeedbackTask to new Task interface

Shall I take it @alvarobartt ? Given that I've finished the QualityScorer


Provide a way to suppress warnings in the jshintrc config

At the moment it is not possible (according to several issues) to specify
  "-W007": true,

in the jshintrc file to suppress an individual warning.

I like this a little better than #1922 and friends, for a whole project.
As for semantics, I would prefer this:
"W007": true, // enable, equivalent to +W007
"W007": false, // disable, equivalent to -W007

Little more explicit, which is always a bonus in config files.

+1 for the syntax proposed by @impinball

i prefer it too.  i suggested the syntax above because I've seen it already somewhere in jshint (tests?).

and there is a reason why I've seen it before.. This syntax works..! It is just undocumented.
Should this be a docs issue or should the other syntax be added?

If it works in .jshintrc, then it is most definitely a docs issue.

@impinball

I like this a little better than #1922 and friends, for a whole project.

How does this differ from #1922?
I agree with @impinball and everyone else that avoiding the "double negative" "spelling" of the option would be preferable. But on that note, W007, or any variation thereof, is a terrible name. Is it not possible for these to have non-cryptic names?

@jmm

How does this differ from #1922?

This is a little more general than that bug.

But on that note, W007, or any variation thereof, is a terrible name. Is it not possible for these to have non-cryptic names?

I honestly don't know if it is, considering how many of these there are:

52 individual error templates
126 individual warning templates
2 individual info templates

Note: I took into account some of the templates were null.

Is it not possible for these to have non-cryptic names?

related: https://github.com/jshint/jshint/issues/1270
I think giving more info about the rule controlling a warning would help.

@impinball

This is a little more general than that bug.

I just don't really understand what you mean by "this" in this quote:

I like this a little better than #1922 and friends

In #1922 I was asking how to suppress a warning via the config file and that's what's discussed here. Do you just mean that this is a generic method for suppressing any warning? I'm all for having a way to suppress any of them, although as noted the error numbers are not a good system.

I honestly don't know if it is, considering how many of these there are:

I don't understand what the fundamental difference is between suppressing, say, confusing plusses and usage of the increment operator period, which has its own option name: plusplus.
What is the difference between a "warning" and an "error"? I'm thinking now that it may also be desirable to have a way to suppress all warnings.
@lukeapage

related: #1270
I think giving more info about the rule controlling a warning would help.

Thanks for the link, that sounds like a good idea. I hope you're also in favor of giving them non-cryptic names for referencing in the config file.

@jmm

I meant "this" as in "this bug". And yes, this is a more general bug in that it's searching for a more general solution to the problem than just "Confusing plusses".
I was saying that with the large number of individual warnings, it's not as easy to simply rename all of them to something more human-readable. It's just not that practical for almost 200 individual warnings and errors. IMHO it's easier to tell at a glance the severity of the rule based on a specific prefix than a phrase.
The difference between a warning and an error:

Warning: stuff like using object["prop"] instead of object.prop. Basically, 99% of user-set linter rule violations.
Error: bad arguments for the linter, syntax errors, etc. Basically, any unrecoverable error or guaranteed runtime errors that can be caught statically (assignment to arguments, etc.).

and there is a reason why I've seen it before.. This syntax works..! It is just undocumented.
Should this be a docs issue or should the other syntax be added?

Just a note: based on this comment, I tried "W018" and got a warning that it was an unrecognized option. It looks like the specific way to implement this is to include -W018 as a key to disable, or +W018 as a key to enable. The actual value of the option appears to be ignored.
I'm editing jshint.options in my VSCode settings JSON, if that makes any difference.


Categories in the filter are not ordered by the IDs

The categories in the filter are not ordered by the IDs
To Reproduce

Go to 'int.visualize.admin.ch' and search "Rétributions uniques pour installations photovoltaïques"
Open the filter "Standort der Anlage"
The list of cantons in the left-hand filter is displayed in alphabetical order.
Select "Show Datafilter" for "Standort der Anlage", Publish the graph and show filters
The list of cantons in interactiv filter is displayed in alphabetical order.
Copy and edit the visualization
Choose "Standort der Anlage" as color.
The list of cantons in the left-hand filter is also displayed by alphabetical order.

Expected behavior
Categories in filters should be sorted by default by ID (Gitlab Issue #405).

It must work in all filters
It must work for all dimensions, including the shared dimension with hierarchy (at least for level 1). Try with : https://int.visualize.admin.ch/en/v/OM6rpkJ7K9bT
The order of "Emission sources" according to the id is : 1. Sectors Ordinance CO2 / 2. International aviation (not included in total) / 3. Balance of land use
it must work in edit mode and in publish mode with interactive filters.

Screenshots

Environment (please complete the following information):

Visualize environment and version: v3.12.0 ([c7820ce]
Browser : Edge

Additional context
Add any other context about the problem here.

@bprusinowski the filters in the left and the legend below the visualization do not show the same order. Shouldn't that be the same (both on Automatic)?

See also here, when I change the X-Axis to "Standort der Anlage" and then change the Sorting, it doesn't affect the Sorting of the filters below
https://user-images.githubusercontent.com/59613691/203071865-b79bfca7-56ae-4543-9896-d52eacd169c7.mov

And in the leftsidepanel the sorting seems to work within the datafilters, but once published, the order is alphabetical again. I wonder if we would need to add the sorting options to the published chart? As an enduser might be confused if it is not ordered from A-Z?

dear @AnninaWalker
We had decided that the filter sorting should be done by default according to the ID and that it should not change. So as not to confuse the graph editor. See my comment here: https://gitlab.ldbar.ch/bafu/umweltdatenkiosk-planning/-/issues/405#note_9066
I understand your point about the end user. Especially as the end user does not have the possibility to search for a term within the filter like the editor.
However, I propose to do as we decided. We will have to think more generally about these different sorts. There are a lot...

Thank you for your feedback @ortnever . Yes I agree, it needs some further thinking. An option could be to add the Sorting options also in the Published Chart, so that the enduser could change the default sorting. And I think it would help to add a a search field on top to allow quicker access as a future enhancement.

@ortnever We've added on test the search and ordering of hierarchies by order id. Please tell if it's correct for you and re-open if there's something unexpected.

@ptbrowne I can't find my feedback that I wrote a few minutes ago...I've got the wrong issue?
Just one more remark : while consulting another dataset, I noticed that the search field was not available in the filter.
See here :

Your last feedback was there : https://github.com/visualize-admin/visualization-tool/issues/858#issuecomment-1330362910
Can you give me a link to the chart you screenshotted ? The search input right now is only available for dimension with a hierarchy. We haven't had time to add it to dimensions without hierarchy.

Here the link but you don't need it. It was to show that everything is good :-)
https://int.visualize.admin.ch/fr/v/PaEo-LY9rOWl

Yes.


Add first class Javascript/Typescript support to the Mill build tool

Related Issues
#3927
Checklist

[x] example/jslib/basic

[x] 1-simple/: A minimal Typescript module demonstrating typechecking/running/testing/bundling of a Node CLI tool
[x] 2-react/: A minimal Typescript module demonstrating typechecking/running/testing/bundling of a React-based web application, served using a static HTML page
[x] 3-custom-build-logic/: A Typescript module with custom build logic

Each top-level bullet of the original bounty should be its own PR. For this PR, just focus on example/jslib/basic/, and we can review/merge/payout the first part of the bounty first. Extending it for further top-level bullets can come later

It's a start and good that tests pass, but the code in the various build.mill example projects is far too messy to serve their purpose as documentation examples.
For reference, look at the equivalent build.mill files in example/pythonlib/basic/ or example/kotlinlib/basic/ for what I would expect the build.mill files to look like. Everything else should be pushed upstream into javascriptlib/src/ library traits and helpers, and those will have to be organized appropriately (see pythonlib/src/ as an example)

Left more comments. We're making progress, still more to be done
We need to figure out a proper interface between the user code in build.mill and the library code in javascriptlib/src/. Putting everything in either place is wrong, which is what we have so far: 1-simple just puts everything in build.mill, 2-react just puts everything in javascriptlib/src/. This is a tricky balance to strike, but it is the key to making javascriptlib useful at all, so we will need to continue discussing it until we find a decent place to draw the line
One thing you should do is start the english explanations of each examples, similar to the ones we see in example/scalalib/basic or example/pythonlib/basic. If you cannot come up with a concise understandable explanation of what the code is doing and how it can be extended, then the code likely needs to be reworked

@jodersky could you give this a review when you have some time? Since your work on the Pythoncside is very similar you may have ideas that are transferable to JS/TS

Will do!

I think this would be easier to review and improve if each example were its own pull request, starting with only the basic example.
A couple of things stand out to me:

I think that testing can be factored out into its own module, without having to subclass modules and have custom tasks. Eg. instead of defining the "main" module to be a JestModule with testSources etc, the test sources could become the normal sources of a nested JestModule which would extend something like `TestModule. This is how Mill's Java and Scala support does it, and is what I used for the Python support as well.
It will also be easier to approach this by documentation to examples first, and also commenting what every task is supposed to do.

In general, I'd suggest to take a look at what we're doing with pythonlib and use it as inspiration on how to approach this. The reason is that it's still fairly minimal and to-the-point, but it does strive to follow general tendencies and structure of the established javalib and scalalib.

the abstraction (TestModule) is done in another pr, as that extends beyond the scope of this task set (and many other things here really)
I can open that next after this is done / move them here whichever you prefer @jodersky
Separating into smaller pr's would be somewhat difficult, its length is due to the modifications made to TypescriptModule and creating the other two modules. I promise the other pr's would be much smaller.

I think this looks in decent enough state to merge. It's not perfect, but it would be useful to get some of the follow on use cases in place first before polishing further.
@monyedavid there's a test failure that needs to be fixed, then I'll merge this and close out the bounty

Merged this, thanks @monyedavid for bearing with all our review and feedback! I think the PR is in a great state now to build upon for later, and I expect follow-up PRs to be easier since you are now more familiar with the Mill tool, codebase, and coding conventions.
Please send me your international bank transfer details over email and I will wire over the bounty


Ensure the timout_hander always returns True so it doesn't get destroyed

Fixes #8. But it also reduces the error logging of those timeout events. If you care, you can improve upon the simple print(e) business. Thanks for this project!

Thanks for the help!