GunProgect-----Skyrim-Behavior-Editor---

Hey. Nice to chat with you again.
  I have long dreamed of realizing in Skyrim the shooting system of duales which I could not realize in the FNV. But not enough skills or courage.
But almost a year ago, the project began. And still developing.
Video-1Per. Video-3Per(old)
But I would not even take up the project without your program (Behavior-Editor). Without it, sorting out the files of behavior is simply impossible. I could solve many problems, but there are problems with which I have not been able to resolve for a year.

Delayed shot from the left hand on the second consecutive shot. (only from the left hand, the right hand works correctly) The second shot occurs only when you release the previously pressed mouse button. Words are hard to describe. Here's a video. Or install my mod.
Forced Delay occurs on the "stfmagic_preready" event. I have already tried all possible methods of editing and deleting this event, and all is useless.
Instantly disappearing weapon when Unequipped with a staff(gun) from the 1st person. In my video it is noticeable. I have already tried all the available event commands, I registered both in the files of behavior and in the animation itself in order to establish the time of the disappearance of the staff, but it always disappears instantly.

Help please understand what could be the problem.
Sorry for my bad English

I'll need to reinstall Skyrim to test. I'm off work on Monday and Tuesday so I'll take a look then.

Wow, this is a pretty awesome mod! I know what the problem is regarding the delay but my first attempt to fix it only causes the muzzle flash to occur but no projectile is fired. It's an issue with the way the engine handles input. I'll try again tomorrow.

Thanks for the praise of my MOD. I appreciate it very much.Sorry for the slightly bad (crooked) animation, in the future I will polish it, or make a new one, just for a start I had to do any, for tests. Now I am fixing the mechanics of animations moving and rocking the camera. I still can not understand why when shooting on the move magcast_walkforward removes recoil. I will try the options. Little by little I create Gun-reload animations. Individually for each hand to work with magic.

I updated the project. Here is the new link.
Corrected from the 1st person with jerked hands when shooting and castes of magic when running and walking. Redid the recoil shots. Redid the animation of walking and running, added rocking camera. And added a sprint animation with a gun. But while walking and running, I could not add recoil shots, I tried a lot but the ideas ran out.
Say, can you have some success in a Delayed shot from the left hand or a prematurely disappearing Unequipped gun?

Thanks, no luck so far though I've only had one chance to look at it yet. I'll take another look later today. Regarding the delayed shot, it's an issue with the way the engine handles input but I think there may be a way to "trick" the engine to correct it. I'll try later today after work.

Ok, nothing is working for me anymore. Even hkxcmd is broken for me and my tool is not functioning correctly. I bet windows updates have broken stuff. Anyway, I suggest you try removing the "MLh_WinStart" and "MLh_WinEnd" events in the "StfMagic_Release" clip generator. This may fix the left hand delay. Let me know if it changes anything.

Hello !!!
As you told, I deleted the “MLh_WinStart” and “MLh_WinEnd” events in the “StfMagic_Release” clip generator. But nothing has changed, nothing at all. Maybe there are other ideas ???

Check and see if those events are raised in the animation file “StfMagic_Release.hkx”. If so remove them. I'm pretty sure those events control how the next left attack input event is handled by the engine.

Hello!!!Sorry to be gone for 3 weeks. It was loaded at work.But I redid all the animations from the 1st. Finished with reload animations for the left and right hand. Here is the new version of the mod. As you ordered, I looked at the animation StfMagic_Release.hkx as well as all the others, but no events were registered in them. All are clean.Maybe I should tell you what I changed in the behavior files in the mod:stfmagic_chargeloop.hkx --- did not change events, animation in 0 frames (cropped)stfmagic_precharge.hkx --- did not change events, animation in 0 frames (cropped)stfmagic_preready.hkx --- events from stfmagic_release.hkx, the animation is complete.stfmagic_readyloop.hkx ---- events from stfmagic_release.hkx, the animation is complete (but this animation is not used when shooting, I don’t know why it is needed).stfmagic_release.hkx ---- I did not change the event but reduced the time. Shooting is conducted sequentially from two animations. First shot with stfmagic_preready.hkx and then stfmagic_release.hkxThe first shot is normal, but shot delay occurs when switching to stfmagic_release.hkx.I tried many different options for editing events in these animations but to no avail. Maybe I need to enter some other event in them, but I don’t know which one.It seems that while the Behavior-Editor is not working for you, the result will not be.

Hello!!!
Sorry to be gone for 3 weeks. It was loaded at work.
But I redid all the animations from the 1st. Finished with reload animations for the left and right hand. Here is the new version of the mod.
As you ordered, I looked at the animation StfMagic_Release.hkx as well as all the others, but no events were registered in them. All are clean.
Maybe I should tell you what I changed in the behavior files in the mod:
stfmagic_chargeloop.hkx --- did not change events, animation in 0 frames (cropped)
stfmagic_precharge.hkx --- did not change events, animation in 0 frames (cropped)
stfmagic_preready.hkx --- events from stfmagic_release.hkx, the animation is complete.
stfmagic_readyloop.hkx ---- events from stfmagic_release.hkx, the animation is complete (but this animation is not used when shooting, I don’t know why it is needed).
stfmagic_release.hkx ---- I did not change the event but reduced the time.
Shooting is conducted sequentially from two animations.
First shot with stfmagic_preready.hkx and then stfmagic_release.hkx.
The first shot is normal, but shot delay occurs when switching to stfmagic_release.hkx.
I tried many different options for editing events in these animations but to no avail. Maybe I need to enter some other event in them, but I don’t know which one.
It seems that while the Behavior-Editor is not working for you, the result will not be.

No problem, I'm very busy myself at work. I was thinking that the problem was related to the AttackWinStart/End events which determine which actor action is executed by the game engine. If those events are not triggered then the engine will execute the AttackLeftStart actor action on each click of the mouse. But if the AttackWinStart event is triggered by the resulting animation and the player clicks again before the AttackWinEnd event is triggered then another actor action is executed (such as AttackLeftRelease).
I've updated Windows 10 on my other SSD (I use Linux Mint most of the time now) but I'll have another try to see if I can get my tool to work again sometime tomorrow.

Still cannot even get hkxcmd to work on my system :/
If you can try recreating the "MLh_AimedFireAndForgetBehavior" branch to be identical to the "MRh_AimedFireAndForgetBehavior" (except using the left hand version of the events and variables).

Hurray !!! Removed the delay of the left shot !!!
I took your advice and gradually remade "MLh_AimedFireAndForgetBehavior" under "MRh_AimedFireAndForgetBehavior". The structure of the behavior of the “Left” is very different from the “Right”. Animation generally ceased to work. He returned to the beginning and after much suffering and trial stopped at

https://jpegshare.net/a8/cd/a8cdf21a48aad44c091a3a707ad0596d.jpg.html

in "to_Mlh_AimedSpellRelease" replaced the "eventId" from "to_Mlh_AimedPreReady" and the delay was removed.
BUT the flash of the second shot was removed. Here is the corrected behavior file. Tell me now how to restore the flash to the second left shot ???

Good, magicbehavior.hkx is an inconsistent mess. I was once considering rewriting it from scratch myself. I'll try to fix the flash.

I accidentally discovered a strange crap trying to repair the flash: when the FPS falls during fast shooting, a flash of a shot appears. I do not understand!!!

Hello!!!
You have not tried to repair a flash of a shot?
Um ... I know that I have asked you so much. But ....... "Houston, we have a problem"
My friend and I worked on animating the active parts of the weapon (Slide, Bolt, Clip, Magazine, triggers) using the "Animation Tools N4 - Body Animator" and everything was fine in the beginning, but when we started trying in Skyrim everything crashed to the desktop. We tried to repair for a long time but to no avail. I decided to try starting from the beginning. At the very beginning of the project, I tried to animate Slide like a Bow.
In the Mod that I attached earlier, at the address "Data \ meshes \ weapons \ Gun" the weapon model "1911.nif" has a Slide01 bone and the BGP "Weapons \ Gun \ GunProject.hkx" is registered in BGED.
In this folder, I tried to animate a behavior pattern based on a Bow. I registered all the necessary links and made a shutter animation (in the folder "Gun \ animations" stfmagicright_readyloop.hkx and stfmagicright_release.hkx) But Slide did not work.
I could not understand the structure of "Data \ meshes \ weapons \ Gun \ behaviors \ Gunbehavior.hkx,  therefore I simply renamed Events, therefore it does not work.
Please help me what I'm doing wrong. How to move bone Slide01.
P.S. all files with (+), (like Gunproject + .hkx) in xml.
Sorry for my importunity.

With active parts of the weapon (Slide, Bolt, Clip, Magazine, triggers) , a little progress went, I found some of my mistakes. But with a flash of a shot, everything is very bad for me. I really hope for your help.

Hooray!!! I could do it !!! I was able to send a pistol slide, as it should be from my separately created Gunproject.hkx.
They work stably.

Sorry for the late response, work has been taking up all of my time. I recently noticed that my copy of hkxcmd was corrupted, I downloaded a new copy of it and it now works. Glad to see that you could fix it.

Hello! Glad you're back in business.
I figured out a little about animating the Right Slide pistol but got stuck on the Left Slide.
My Gunbehavior.hkx behavior file does not see AttL.hkx shot animation for Left Slide.
And the Slide movement does not work on the first shot of the right hand.
Please take a look at my Gunbehavior.hkx using Skyrim.Behavior.Tool and say that it is not correct in it, why it works crookedly.
I have no ideas !!!
P. S. Now in MOD two M1911 for the right and separately for the left.
Gunbehavior- (Source + Animation) (XML) .hkx ---- this is the original behavior file for Magic from the 1st person with replaced animation shots.

Experimenting with Gunbehavior.hkx.
In desperation, he deleted all the blocks and left only one block "MRh_AimedFireAndForgetBehavior". The animation of the Slide with the right began to work better, but any cast of the left hand moves the Slide.
I repeated this with "MLh_AimedFireAndForgetBehavior" but no effect, the animation does not work. Strange, all the new bones are working, the animation, too, but the behavioral does not start it.
I hope you can help me.

The good news is!!!
I solved the problem with a delayed shot.
Very easy and simple, without interfering with the behavior file.
Just inscribed MLh_SpellRelease_Event in the zero frame stfmagic_preready.hkx
But I'm afraid with the left Slide it will not be so easy.
I hope for your support.

The left slide is working.
I could not understand how to get two Slides to work with one Gunproject.hkx..
I had to create a separate GunprojectL.hkx. for him, for the left hand.
The problem now is different. The beginning of any magical action moves the Slide.
New vers Mod. Need your help.

There could be some blending going on between both hands when casting with one hand. I'll take a look and if if that's the case. If so you would probably need to redirect the gun slide animation based on one of the animation variables that is set when casting begins. I'll have a look tomorrow after work and see if that's happening.

hi, nice tool. But my first go on it disappointed me. I believe i followed the suit, but it wont open, and neither close, the computer froze that i had to reboot it. Do you have any clue, waiting for your insight

ok i tried troll instead defaultuman, it made it!, so excited. dont know why human wont work,  but ill just steer clear of it.
cheers!

Hey.24.08.2019 You said you looked at my Slide behavior files.Any ideas what could be the problem with Slide ??? I tried many times to solve the problem myself, but it seems that my knowledge is not enough.

I have tried to look at your files but for some reason my tool cannot open them properly, even though it will open the default _1stperson project just fine! Does it work for you?

@kavinever DefaultMale.hkx should open. I tested to tool with it the most. What errors to you get?

Sorry forgot to say. Yes!  And there is.  My ---- meshes \ Weapons \ Gun \ Gunproject.hkx does not open the "Behavior-Editor",    I don’t know why. I took the vanilla files of the project of the behavior of the active parts for the Bow. And he threw it from ---------- meshes \ Weapons \ Gun \ ------- skeleton.hkx, Guncharacter.hkx, Gunbehavior.hkx, only then "Behavior-Editor" opens the project.And I have the same problem with Gunbehavior.hkx. Video 0:19 in the message from 08/18/2019.When casting magic of the left hand, the Slide of the right hand moves on the first shot.When casting magic in the right hand, the Slide of the left hand moves on the first shot.

Sorry forgot to say.
Yes!  And there is.
My ---- meshes \ Weapons \ Gun \ Gunproject.hkx does not open the "Behavior-Editor",    I don’t know why.
I took the vanilla files of the project of the behavior of the active parts for the Bow. And he threw it from ---------- meshes \ Weapons \ Gun \ ------- skeleton.hkx, Guncharacter.hkx, Gunbehavior.hkx, only then "Behavior-Editor" opens the project.
Here is a working in "Behavior-Editor" project.
Latest version of mod.
And I have the same problem with Gunbehavior.hkx. Video 0:19
.When casting magic of the left hand, the Slide of the right hand moves on the first shot.When casting magic in the right hand, the Slide of the left hand moves on the first shot.

Sorry, but I don't have any. It was like falling into a loop, no response from clicks. So I have to manually restart my computer, really pity my harddisk though.
For now, I'm digging into the other actors' behaviors, which strain my brain, so much fun.
Thanks for the tool and effort.

I understand that you have very little time, but if a minute is suddenly free, could you answer two questions on vanilla magicbehavior.hkx from the 1st person ???

Why is the animation magcast_walkforward.hkx blocking the operation of the cast animation magic camera, and how to unlock it ???

-What function or modifier aligns the angle of the hands when casting magic ??? And can it be used for Idel magic in constant mode ???

Can you explain in more detail? I don't understand.
There is a twist modifier in 0_master.hkx in the root modifier list that twists the body when in first person, if I recall correctly. That may be it.

Can you explain in more detail? I don't understand.
Sorry for my very bad english !!!I tried to say briefly and clearly but overdid it.

The camera does not produce recoil when shooting on the run.
The only animation that can interfere is magcast_walkforward.hkx. I tried all the options with the weight settings of the bones of the animation group magcast_walkforward.hkx, and removing the anamation magcast_walkforward.hkx but recoil did not appear on the run.

+Solved the problem with pistol slides.+I solved the problem of tilting arms and the camera from the 1st person.-There was one problem with the lack of recoil when running. I wrote about it earlier. Tell me where the problem is in the behavior files ???

Hello!!!
The project with duals is actively developing.
All questions that I previously asked have already been successfully closed!!!
The latest version of my mod.
Now I am trying to solve the problem of shooting in a jump. In your Character Behaviors Enhanced MOD, you were able to add the function of jump hit. Please help me figure out what I need to do ??? I in "0_master.hkx" in "MT_Jump_Behavior" in "MT_Jump" replaced the "JumpFall" event with "JumpLandEnd" and it seems to work but is ugly.

Hello.
Do you know this tool?
https://github.com/ShikyoKira/Project-New-Reign---Nemesis-Main
The developper's youtube channel:
https://www.youtube.com/watch?v=8VIYokV-sW0
Le sam. 26 oct. 2019 à 17:15, DeclineDawn<EMAIL_ADDRESS>a
écrit :

Hello!!!
The project with duals is actively developing.
All questions that I previously asked have already been successfully
closed!!!
The latest version of my mod. https://yadi.sk/d/X1UKJ2S0c4SlNg
Now I am trying to solve the problem of shooting in a jump. In your
Character Behaviors Enhanced MOD, you were able to add the function of jump
hit. Please help me figure out what I need to do ??? I in "0_master.hkx"
in "MT_Jump_Behavior" in "MT_Jump" replaced the "JumpFall" event with
"JumpLandEnd" and it seems to work but is ugly.
https://yadi.sk/i/Fc2xscPQcJm7qg
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/BrannigansLaw/Skyrim-Behavior-Editor-/issues/16?email_source=notifications&email_token=ALQFZSYI74H24CPBYQBXA7TQQRNIVA5CNFSM4H4EMIBKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECKKDEA#issuecomment-546611600,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ALQFZS4KE26WWQD6ZXVGL4LQQRNIVANCNFSM4H4EMIBA
.

Hello Madao1 .
Yes, I heard about this program! But never used it. Do you know ShikyoKira ???
 I would like to use it, but I don’t understand scripts and don’t know how to create an animation substitution script for Nemesis.
Now I am working on the finalization of the mechanics of jumping combat for all game weapons and magic in skyrim.

I'm on his Discord named ProjectNewReign.
Do you want me to ask him to invite you? (You'll be able to ask what want
you want directly to him).
Le mer. 11 déc. 2019 à 23:08, DeclineDawn<EMAIL_ADDRESS>a
écrit :

Hello Madao1 .
Yes, I heard about this program! But never used it. Do you know ShikyoKira
???
I would like to use it, but I don’t understand scripts and don’t know how
to create an animation substitution script for Nemesis.
Now I am working on the finalization of the mechanics of jumping combat
for all game weapons and magic in skyrim.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/BrannigansLaw/Skyrim-Behavior-Editor-/issues/16?email_source=notifications&email_token=ALQFZS2GNRPXGJRMKFIB5A3QYFQHJA5CNFSM4H4EMIBKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEGUXZYA#issuecomment-564755680,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ALQFZS5VXYYIOQGCMRUDTB3QYFQHJANCNFSM4H4EMIBA
.

Yes, that would be great!
I am now on this discord server. Under the name DeclineDawn#1851
I will be glad to talk with him !!!
Tell me why you help me make contact with ShikyoKira???

Nice.
I helped you to make contact with ShikyoKira because he seems to understand how behaviors files work, so I thought that he should be able to make you win some time :) .
And I like what you're trying to do (bring guns to skyrim).

Hmm !!!
Looks like I'm not the only one so crazy mod maker.
Pleased to meet you ;)  !!!
For half a year now I’ve been trying to find help in online communication with the implementation of guns. Such a chance cannot be missed.


Plurals are not handled by the editor

Hi, first of all, congratulations for this awesome plugin.
I have some plurals in my translation files and the editor just those fields empty. You can paste the string with plurals in the editor and it will be correctly saved, but even if you sign them of they will show up as "Need translation" when you open them again with the editor. It's not a big deal, because you can translate them directly in the xlf file and just ignore the editor for the fields containing plurals.
The source of the unit with plurals is this:
<source>{VAR_PLURAL, plural, =0 {No files} =1 {1 file} other {<x id="INTERPOLATION" equiv-text="{{fileNumber}}"/>files} }</source>
Thanks.

Thank you for the feedback. And yes, the plural cases are some that I've left behind while I building this extension. I will try to fix this soon.


UX-75 Layout stories

Note that a bunch of the code style changes are from me auto-applying the current ESLint rules.
Some of the style objects can probably have some things pruned; I made some guesses as to what would look good at least for the demo.

Thanks. Lets go with it for now :)


Indepth Optional System Params

Objective

There is boilerplate for T and Option<T> system params where you have to implement SystemParamState and SystemParamFetch for both types.

Solution

This removes that boilerplate by making it necessary to only implement SystemParam or OptionalSystemParam and their respective traits.

Ok, I switched it from Option<T> to OptionState<T>, since @JoJoJet was right, it does better reflect the fact that it is the state of an option, not an optional state.
I also used OptionState to implement ReadOnlySystemParamFetch for all Option<T::Fetch: ReadOnlySystemParamFetch>.


error in building

Describe the bug
when building
An error occured while streaming this message.
Link to the Bolt URL that caused the error
https://bolt.new/~/sb1-hfv1jk
Steps to reproduce
An error occured while streaming this message.
Expected behavior
building
Screen Recording / Screenshot
npm install
src/types/index.ts
src/App.tsx
src/components/Layout.tsx
src/pages/Dashboard.tsx
Platform
Browser name = Chrome
Full version = <IP_ADDRESS>
Major version = 130
navigator.appName = Netscape
navigator.userAgent = Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/<IP_ADDRESS> Safari/537.36 Edg/<IP_ADDRESS>
performance.memory = {
  "totalJSHeapSize": 66262285,
  "usedJSHeapSize": 61790793,
  "jsHeapSizeLimit":<PHONE_NUMBER>
}
Username = NeiMaldaner
Chat ID = b0a0c1d06500

Additional context
An error occured while streaming this message.

@NeiMaldaner thanks for your patience during this beta period! This issue is being tracked and investigated in #1022 so please subscribe there for updates!


Big Endian compatibility fix

I believe the test logic was inverted. The #ifndef __LITTLE_ENDIAN__ branch did no conversion from little endian to host order on the radiotap data, which is necessary because radiotap data is little endian.
The remaining branch uses le32toh() and le16toh() on the data, converting it from little endian to native host order, so it is safe to use on either little or big endian systems.

You're right, that doesn't work as expected.
Not merged, because I did it a little differently:
https://github.com/ZerBea/hcxdumptool/commit/d25e554236c19649923ddfebea0488b4c3595a59
because I don't want to handle this at runtime:
Initialize main scan loop...ENDIANESS at runtime took 0.000002 seconds to execute
versus
Initialize main scan loop...ENDIANESS at compiletime took 0.000001 seconds to execute
If ENDIANESS is not detected at compile time and ERROR is printed:
$ make
cc -O3 -Wall -Wextra -Wpedantic -std=gnu99   -o hcxdumptool hcxdumptool.c -DVERSION_TAG=\"6.3.2-78-g3802d57\" -DVERSION_YEAR=\"2023\" -DSTATUSOUT -DNMEAOUT -DWANTLIBPCAP -lpcap
hcxdumptool.c: In function 'process_packet':
hcxdumptool.c:2673:3: error: #error "Please fix ENDIANESS <endian.h>"
 2673 | # error "Please fix ENDIANESS <endian.h>"
      |   ^~~~~
make: *** [Makefile:74: hcxdumptool] Error 1

A rounding error during the measurement is possible.
But anyway, now the compiler print an ERROR if an ENDIANESS error occurs.


Using validatedPrompt together with PromptType.choice

This issue relates to the Node.js botbuilder SDK version 3.4.4.
I am defining a dialog like this:
bot.dialog('/destination', builder.DialogAction.validatedPrompt(builder.PromptType.choice, function (response) {
  // Here I'd like to validate the response for the choice - see issue 1. below
}));

And using it like this:
    session.beginDialog(
      '/destination',
      {
        prompt: 'Choose or send location to set the destination'
      }
      // How to pass choices - see issue 2. below
    );

I have two issues that I didn't yet manage to solve:

The custom validator function doesn't seem to get called at all when user responds to the choice (works as expected when using PromptType.text)
How to pass the choices to the underlying choice prompt

My use case is such that I'd like to give the user the possibility to set destination from a pre-defined set of locations that I'd send as choices via the prompt, but also allow the user to respond with any location outside of the pre-defined choices (and in the custom validator, check that user responded either with one of the choices or with a message containing a location).

So I just added a new basics-customChoicePrompt example that shows how you'd do this.  You can't really use a validated prompt because it requires you successfully chose an option from the set.  The sample shows how to use Prompts.choice() with maxRetries = 0.

If this does not work for you, please let us know.


Installing k8tz in airgap environment

Hi
Being not very versed in use of kubernetes and how to inject timezone manually i tested k8tz in a test env with internet access and it seems to work great.
However are the any way to install k8tz in an airgapped environment?
If yes, how do i accomplish that?

Hi @Vinnyaaa,
To install k8tz in an airgapped environment you need to make sure that the image (quay.io/k8tz/k8tz:0.8.0) is available in all cluster nodes.
If you are using local container registry (such as nexus or artifactory) you need to push the image to your registry and when installing k8tz, specify custom repository, for example: helm install k8tz k8tz/k8tz --set image.repository=my-private-registry.domain.local:5000 --set timezone=Europe/London


Meet the designer #4

Preparation for meet the designer:

[ ] Status update

[ ] Echo Team presentation

[ ] QA

is this done? @lucasveil

Yep @mimarz


Update SQL VM registration documentation to incorporate Full mode ins…

…tallation without Lightweight mode installation
It is feasibile to register the SQLVM Provider directly to Full mode without undertaking the Lightweight mode installation. Of course, a SQL Server service, or the VM, restart is required, and should be planned according to company scheduled maintenance windows. This update to the documentation is to provide the PowerShell and Bash commands to directly perform a Full mode installation.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: johnbilliris sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

@johnbilliris : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Hi @johnbilliris , my apologies for the delay, but your change came in right in the middle of a large content shuffle so we could not address it in time. However, a change has been made to the documentation to include installing directly to full so your change was incorporated :)
Thank you so much for helping improve our docs, and my apologies once more that we could not implement your change in time.
Hope you have a wonderful rest of your day!
#please-close


teleportation status effect teleports the other player to the same location they were in

it almost feels like cessation and its very scary due to the fact that you can't see how long the effect will last.
On a similar note, blindness works as intended but also lacks a timer for the client

This happened due to adding player_unit tag to clients at some point for testing, shouldn't happen anymore.


Trace API function for trace writer project ID

This will be used by the best-effort logs correlation changes to be able to format the LogEntry.trace field in the specified projects/[PROJECT-ID]/traces/[TRACE-ID] format (per https://cloud.google.com/logging/docs/reference/v2/rest/v2/LogEntry).

No problem. If all is good, can you go ahead and merge this?


pthread: facilitate dynamically allocated thread stacks

This change allows users to call pthread_create(3) with the pthread_attr_t argument equal to NULL, or with the pthread_attr_t argument specifying a NULL stack.
If either of the above to requirements are met, then a stack will be heap-allocated internally and freed again after the thread has terminated.
This helps the Zephyr implementation of pthread_create(3) become more compliant with the normative spec.
Fixes #25973

Had to recreate this PR from #29029 due to some repo issues in my fork.

Had to recreate this PR from #29029 due to some repo issues in my fork.

Still working on an item that this depends on. Has to do with treating user thread stacks as dynamic objects to avoid triggering the mmu / mpu.


context2d - Fix multiple transform matrices

This fixes a TODO in the transform method of context2d to apply nested transform matrices properly.
See example at https://jsfiddle.net/j8a5nzby/2/.

I find it useful to use the existing _matrix_multiply
What about:
this.ctx._transform = this._matrix_multiply( this.ctx._transform, [a, b, c, d, e, f] );

will be part of #1751


modified about and nav

Made the about responsive, added fonts and modified navbar to perform bluring effect when scrolled.

Awesome Work


Some dates are not displayed at all

Environment

real device. iPhone 8
Platforms

iOS
Versions

Android: 4.0 AI-193.69<IP_ADDRESS>26763
iOS: 11.4.1/11E503a - /usr/bin/xcodebuild
react-native-modal-datetime-picker: "^8.7.1",
react-native-community/datetimepicker: "2.4.0"
react-native: https://github.com/expo/react-native/archive/sdk-38.0.2.tar.gz => 0.62.2
react: 16.11.0

Description

On some iOS devices (not all) there is some strange behaviour where the picker doesn't display all dates:

As suggested on the issue template, I tried using @react-native-community/datetimepicker and it worked as expected. (Edited)
Reproducible Demo
I pasted some relevant parts of my component for some context.
...
const [value, setValue] = useState();
const [showDatePicker, setShowDatePicker] = useState(false);
const show = useCallback(() => {
	setShowDatePicker(true);
}, [setShowDatePicker]);
const hide = useCallback(() => {
	setShowDatePicker(false);
}, [setShowDatePicker]);

const setDate = useCallback(
	(date: Date) => {
		setShowDatePicker(false);
		const newDate = moment(date);
		setValue(newDate);
	},
	[setShowDatePicker, setValue]
);

<View style={localStyles.container}>
	<View style={localStyles.dateContainer}>
		<Text style={[localStyles.date, localStyles.label]}>{label}</Text>
		<TouchableOpacity onPress={show}>
			<Text style={localStyles.date}>{displayDate}</Text>
		</TouchableOpacity>
	</View>
	{showDatePicker && (
		<View style={localStyles.datePickerContainer}>
			<DateTimePickerModal
				isVisible={showDatePicker}
				mode="datetime"
				headerTextIOS={"Set time"}
				minimumDate={minimumDate.toDate()}
				maximumDate={maximumDate.toDate()}
				onConfirm={setDate}
				onCancel={hide}
			/>
		</View>
	)}
</View>

Thanks in advance!
Let me know if I can give you more info. I'm using this package mainly to support android devices but it would be nice to still use it for iOS.
Edited

I can also confirm this with expo sdk 38, react-native-modal-datetime-picker ~> 8.7.1, and @react-native-community/datetimepicker ~> 2.1.0.
I tried to force a light theme with userInterfaceStyle but does not seems to work.
Using colorScheme from react-native works but breaks when the theme is changed while the app is running. Have to restart the app to make it work again.

How's it different from:

https://github.com/mmazzarolo/react-native-modal-datetime-picker#is-the-ios-dark-mode-supported
and https://github.com/mmazzarolo/react-native-modal-datetime-picker#i-cant-see-the-picker-on-iosthe-picker-is-white-on-ios
?

I can confirm it happens when dark mode is on. I see now you've had a bunch of similar issues being opened (apologies for being one more, I thought I had to opt-in to support dark mode).
To solve this I was forced to support dark mode by using https://docs.expo.io/versions/latest/sdk/appearance/:

I've added "userInterfaceStyle": "automatic", on app.json,
used the useColorScheme hook to detect the mode and
used the DateTimePickerModal prop isDarkModeEnabled={colorScheme === "dark"}

No worries :)
Yeah this theming thing is confusing, especially on Expo... not much that we can do on our side to fix it though :/

I'm trying to force light theme by providing "userInterfaceStyle": "light", but picker is not respecting the light theme when dark mode is enabled. Anything we can do about this?

@maharjanaman please see

https://github.com/mmazzarolo/react-native-modal-datetime-picker#is-the-ios-dark-mode-supported
and https://github.com/mmazzarolo/react-native-modal-datetime-picker#i-cant-see-the-picker-on-iosthe-picker-is-white-on-ios

and @dmdmd solution's above ☝

or wait for #458

Supporting dark-mode because of this component gave me trouble on other parts of my app. So I reverted to supporting only light mode.
But even with version "8.9.3" I still have this bug. And "@react-native-community/datetimepicker" works correctly.

hey @dmdmd , sorry to hear that. If you could provide a (complete) reproducible example of the issue that would be great. I tested the example project and it works correctly for on iPhone 11 (both dark and light mode).

My code is the same as above.
Did you try adding "userInterfaceStyle": "light" on your app.json and enabling dark-mode on your device?
I think I tracked down the issue to the usage of DatePicker inside a Modal (I replaced the Modal from react-native-modal-datetime-picker code with a View and the bug didn't manifest). I'm not sure if the Modal component is respecting the light mode rule...


Deduplicate CallOpConversion

Further renames CallOpConversion to GenericOpConversion.

LGTM. Should we rename the conversion pattern to something like GenericOpConversion while we are at it?

We agreed to rename it to GenericOpConversion.


Font issues

To get results sooner I've opted for a texture-font.
This is awful for many reasons:

Stuck to a limited subset of characters, namely Latin based.
Stuck to one font
Stuck to one rendering of said font, which may not scale nicely
It's monospaced. I'm happy with this but most people probably won't be

For all these reasons we need to look into a real font rendering library that we can hook into.

Decision: Render with Iced/libCosmic


Allow linking to JavaFlowSupport

JavaFlowSupport is a case object without corresponding class in the scaladsl, and an inner class in javadsl. this is currently not supported, as we filter out all case objects that do not have a corresponding regular class.

This should now work by using the regular @scaladsl directive as it now understands inner classes. https://github.com/lightbend/paradox/pull/397

It works for @scaladsl but not for @apidoc, so we don't have a convenient way to link to scaladoc for scala users and javadoc for java users yet.

Isn't that the same problem as you discussed in https://github.com/lightbend/sbt-paradox-apidoc/issues/48#issuecomment-561658997 ?

No, I'd want it to link to akka.stream.javadsl.JavaFlowSupport for Java and to akka.stream.scaladsl.JavaFlowSupport$ for Scala.


perf: preserve space to prevent mem allocations when evaluate the bool expression

https://github.com/risingwavelabs/risingwave/blob/d4629c3fde1b3da8cfef91304913177ef63e1ad8/src/common/src/buffer/bitmap.rs#L597-L602

just curious, is this memory flame graph generated by Buildkite pipeline?
Or it requires manual work right now? If so, I will try to automate it.

Some benchmark results:

Collecting 1024 bools into a bitmap is ~90ns.
Evaluating less_than(bigint, int) on 2 int arrays with 1024 elements and outputting the result as a boolean array is 138ns.
Evaluating less_than(bigint, int) on a data chunk with 1024 rows is 378ns.

Some explanations:

The reason why Bitmap::from_iter takes a majority overhead in the flamegraph is that it includes function evaluation.
The reason why we construct an intermediate Vec<bool> in Bitmap::from_iter is that both steps can utilize auto-vectorization. But collecting bools directly into a bitmap does not have a fast way as far as I know.

Conclusions:

The overhead is not caused by memory allocations because the input iterator has implemented TrustedLen.
The performance of less_than(bigint, int) function is not optimal, but also not too bad (compared with other functions which can not utilize SIMD). The potential optimization is no more than 3x faster (378 -> 138ns). I think it's not a big bottleneck of the query.


vars file for easy-rsa 3.0 different form original one?

What are you seeing
Currently, the vars template of easy-rsa 3.0 differs form the original var.example file.
For example, all vars are exposed through shell builtin export while vars.example is using set_var.
I would like recreate the easy-rsa 3 vars template file based on the original vars.example to come closer.
Before I going the create a PR, i would like to ask if a maintainer is interested into this. It unknown to me I we could test that it won't break existing setups.

I updated to EasyRSA 3.x, not realizing that puppet-openvpn didn't yet support it, and ran into the following error when regenerating the CRL:
These problems have been found in your 'vars' settings:
Use of 'export':
Remove 'export' or replace it with 'set_var'.

I just submitted #461, which enables it to work with EasyRSA 3.2.1, at least.


The Operator injected with proxy failed to start.

General Question
My Operator : mysql-operator
k8s version : v1.21.5
controller-mesh : v0.1.2
shardingconfig-root :
apiVersion: ctrlmesh.kusionstack.io/v1alpha1
kind: ShardingConfig
metadata:
  name: sharding-root
  namespace: test-mysql
spec:
  root:
    prefix: mysql-operator
    targetStatefulSet: mysql-operator
    canary:
      replicas: 1
      inNamespaces:
      - demo-0a
      - demo-0b
      - demo-0c
    auto:
      everyShardReplicas: 2
      shardingSize: 2
    resourceSelector:
    - relateResources:
      - apiGroups:
        - '*'
        resources:
        - '*'
  controller:
    leaderElectionName: mysql-operator-leader-election

My Operator has 2 containers (operator and orchestrator). When not using patch to add the labels required by ctrlmesh (ctrlmesh.kusionstack.io/enable-proxy: "true", ctrlmesh.kusionstack.io/watching: "true") , can be started successfully. After using patch to request labeling, ctrlmesh-proxy and operator can start normally, but orchestrator fails to start with the following error:
Error starting command: `--kubeconfig=/etc/kubernetes/kubeconfig/fake-kubeconfig.yaml` - fork/exec --kubeconfig=/etc/kubernetes/kubeconfig/fake-kubeconfig.yaml: no such file or directory

kubectl get  pod/mysql-operator-0 -oyaml Check the pod and find that the /etc/kubernetes/kubeconfig/fake-kubeconfig.yaml file has been mounted
Who can help me?

/assign @wu8685

Thx for your report, @qiuming520
Please check:

Whether the configmap named fake-kubeconfig has been automatically created in namespace test-mysql;
Whether the file /etc/kubernetes/kubeconfig/fake-kubeconfig.yaml exists in the container directory.

If none of the above issues have occurred, I may need more information, such as the complete pod yaml, pod events, etc.

Thx for your report, @qiuming520
Please check:

Whether the configmap named fake-kubeconfig has been automatically created in namespace test-mysql;
Whether the file /etc/kubernetes/kubeconfig/fake-kubeconfig.yaml exists in the container directory.

If none of the above issues have occurred, I may need more information, such as the complete pod yaml, pod events, etc.

@Eikykun

cm (named fake-kubeconfig)  already exists

My Operator has 2 containers  (operator and orchestrator).  For the operator container that started successfully, I can  the file /etc/kubernetes/kubeconfig/fake-kubeconfig.yaml.  For the orchestrator container that failed to start, it is impossible to enter the inside of the container, so it is impossible to view the internal files. I have tried to manually mount the /etc/kubernetes/kubeconfig/fake-kubeconfig.yaml into My Operator without injecting ctrlmesh-proxy, and it can be started successfully, and both have /etc/kubernetes/kubeconfig/fake-kubeconfig.yaml . After injecting ctrlmesh-proxy,  orchestrator failed to start

Thx for your report, @qiuming520
Please check:

Whether the configmap named fake-kubeconfig has been automatically created in namespace test-mysql;
Whether the file /etc/kubernetes/kubeconfig/fake-kubeconfig.yaml exists in the container directory.

If none of the above issues have occurred, I may need more information, such as the complete pod yaml, pod events, etc.

this is My Operator's pod
apiVersion: v1
items:
- apiVersion: v1
  kind: Pod
  metadata:
    annotations:
      checksum/orchestrator-config: 2e45145f5b5bb11a0f82027015b5fd76d661bfea6b05ba68adae09df886eff93
      checksum/orchestrator-secret: 508297128b9dc867611b9f1339e035f090c7fdbf9f4a3abb9e57b6c4b6680508
      cni.projectcalico.org/containerID: 62603afe25757219694bb42dd8d22570040690ccb5756f3a3a62b9dd0cfdbf09
      cni.projectcalico.org/podIP: 10.xx.xx.62/32
      cni.projectcalico.org/podIPs: 10.xx.xx.62/32,fd33:xx.xx:e03e/128
    creationTimestamp: "2024-02-05T11:14:55Z"
    generateName: mysql-operator-
    labels:
      app.kubernetes.io/instance: mysql-operator
      app.kubernetes.io/name: mysql-operator
      controller-revision-hash: mysql-operator-75fd7f67b9
      ctrlmesh.kusionstack.io/control: "true"
      ctrlmesh.kusionstack.io/enable-proxy: "true"
      ctrlmesh.kusionstack.io/namespace: test-mysql
      ctrlmesh.kusionstack.io/shard-hash: "3"
      ctrlmesh.kusionstack.io/sharding-config-injected: mysql-operator-0-canary
      ctrlmesh.kusionstack.io/watching: "true"
      statefulset.kubernetes.io/pod-name: mysql-operator-0
    name: mysql-operator-0
    namespace: test-mysql
    ownerReferences:
    - apiVersion: apps/v1
      blockOwnerDeletion: true
      controller: true
      kind: StatefulSet
      name: mysql-operator
      uid: 23342e03-437d-4937-8c27-cff333dbb6f5
    resourceVersion: "15311632"
    uid: b9b5b80c-0b20-4527-ab29-65a2f5c549d3
  spec:
    containers:
    - args:
      - --leader-election-name=mysql-operator-leader-election
      env:
      - name: POD_NAME
        valueFrom:
          fieldRef:
            apiVersion: v1
            fieldPath: metadata.name
      - name: POD_NAMESPACE
        valueFrom:
          fieldRef:
            apiVersion: v1
            fieldPath: metadata.namespace
      - name: POD_IP
        valueFrom:
          fieldRef:
            apiVersion: v1
            fieldPath: status.podIP
      image: xxx/cnp/kusionstack/ctrlmesh-proxy:v0.1.2
      imagePullPolicy: IfNotPresent
      lifecycle:
        postStart:
          exec:
            command:
            - /bin/sh
            - -c
            - /poststart.sh
      name: ctrlmesh-proxy
      readinessProbe:
        failureThreshold: 3
        httpGet:
          path: /readyz
          port: 5441
          scheme: HTTP
        periodSeconds: 3
        successThreshold: 1
        timeoutSeconds: 1
      resources:
        limits:
          cpu: 100m
          ephemeral-storage: 2Gi
          memory: 100Mi
        requests:
          cpu: 100m
          ephemeral-storage: 2Gi
          memory: 100Mi
      securityContext:
        privileged: true
        runAsUser: 1359
      terminationMessagePath: /dev/termination-log
      terminationMessagePolicy: File
      volumeMounts:
      - mountPath: /var/run/secrets/kubernetes.io/serviceaccount
        name: kube-api-access-drm8w
        readOnly: true
    - args:
      - --leader-election-namespace=test-mysql
      - --orchestrator-uri=http://mysql-operator.test-mysql/api
      - --sidecar-image=xxxcnp/bitpoke/mysql-operator-sidecar-5.7:v0.6.3
      - --sidecar-mysql8-image=xxx/cnp/bitpoke/mysql-operator-sidecar-8.0:latest
      - --metrics-exporter-image=xxx/cnp/prom/mysqld-exporter:v0.13.0
      - --failover-before-shutdown=true
      - --kubeconfig=/etc/kubernetes/kubeconfig/fake-kubeconfig.yaml
      env:
      - name: ORC_TOPOLOGY_USER
        valueFrom:
          secretKeyRef:
            key: TOPOLOGY_USER
            name: mysql-operator-orc
      - name: ORC_TOPOLOGY_PASSWORD
        valueFrom:
          secretKeyRef:
            key: TOPOLOGY_PASSWORD
            name: mysql-operator-orc
      - name: KUBECONFIG
        value: /etc/kubernetes/kubeconfig/fake-kubeconfig.yaml
      image: xxx/cnp/bitpoke/mysql-operator:v0.6.3
      imagePullPolicy: IfNotPresent
      livenessProbe:
        failureThreshold: 3
        httpGet:
          path: /healthz
          port: 8081
          scheme: HTTP
        periodSeconds: 10
        successThreshold: 1
        timeoutSeconds: 1
      name: operator
      ports:
      - containerPort: 8080
        name: prometheus
        protocol: TCP
      readinessProbe:
        failureThreshold: 3
        httpGet:
          path: /readyz
          port: 8081
          scheme: HTTP
        periodSeconds: 10
        successThreshold: 1
        timeoutSeconds: 1
      resources: {}
      securityContext: {}
      terminationMessagePath: /dev/termination-log
      terminationMessagePolicy: File
      volumeMounts:
      - mountPath: /var/run/secrets/kubernetes.io/serviceaccount
        name: kube-api-access-drm8w
        readOnly: true
      - mountPath: /etc/kubernetes/kubeconfig
        name: fake-kubeconfig
        readOnly: true
    - args:
      - --kubeconfig=/etc/kubernetes/kubeconfig/fake-kubeconfig.yaml
      env:
      - name: POD_IP
        valueFrom:
          fieldRef:
            apiVersion: v1
            fieldPath: status.podIP
      - name: KUBECONFIG
        value: /etc/kubernetes/kubeconfig/fake-kubeconfig.yaml
      envFrom:
      - prefix: ORC_
        secretRef:
          name: mysql-operator-orc
      image: xxx/cnp/bitpoke/mysql-operator-orchestrator:v0.6.3
      imagePullPolicy: IfNotPresent
      livenessProbe:
        failureThreshold: 3
        httpGet:
          path: /api/lb-check
          port: 3000
          scheme: HTTP
        initialDelaySeconds: 200
        periodSeconds: 10
        successThreshold: 1
        timeoutSeconds: 10
      name: orchestrator
      ports:
      - containerPort: 3000
        name: http
        protocol: TCP
      - containerPort: 10008
        name: raft
        protocol: TCP
      readinessProbe:
        failureThreshold: 3
        httpGet:
          path: /api/raft-health
          port: 3000
          scheme: HTTP
        periodSeconds: 10
        successThreshold: 1
        timeoutSeconds: 10
      resources: {}
      securityContext: {}
      terminationMessagePath: /dev/termination-log
      terminationMessagePolicy: File
      volumeMounts:
      - mountPath: /var/lib/orchestrator
        name: data
      - mountPath: /usr/local/share/orchestrator/templates
        name: config
      - mountPath: /etc/kubernetes/kubeconfig
        name: fake-kubeconfig
        readOnly: true
      - mountPath: /var/run/secrets/kubernetes.io/serviceaccount
        name: kube-api-access-drm8w
        readOnly: true
    dnsPolicy: ClusterFirst
    enableServiceLinks: true
    hostname: mysql-operator-0
    nodeName: kcs-operator-mesh-s-cqngs
    preemptionPolicy: PreemptLowerPriority
    priority: 0
    restartPolicy: Always
    schedulerName: default-scheduler
    securityContext:
      fsGroup: 65532
      runAsGroup: 65532
      runAsNonRoot: true
      runAsUser: 65532
    serviceAccount: mysql-operator
    serviceAccountName: mysql-operator
    subdomain: mysql-operator-orc
    terminationGracePeriodSeconds: 30
    tolerations:
    - effect: NoExecute
      key: node.kubernetes.io/not-ready
      operator: Exists
      tolerationSeconds: 240
    - effect: NoExecute
      key: node.kubernetes.io/unreachable
      operator: Exists
      tolerationSeconds: 240
    volumes:
    - configMap:
        defaultMode: 420
        name: fake-kubeconfig
      name: fake-kubeconfig
    - configMap:
        defaultMode: 420
        name: mysql-operator-orc
      name: config
    - emptyDir: {}
      name: data
    - name: kube-api-access-drm8w
      projected:
        defaultMode: 420
        sources:
        - serviceAccountToken:
            expirationSeconds: 3607
            path: token
        - configMap:
            items:
            - key: ca.crt
              path: ca.crt
            name: kube-root-ca.crt
        - downwardAPI:
            items:
            - fieldRef:
                apiVersion: v1
                fieldPath: metadata.namespace
              path: namespace
  status:
    conditions:
    - lastProbeTime: null
      lastTransitionTime: "2024-02-05T11:14:55Z"
      status: "True"
      type: Initialized
    - lastProbeTime: null
      lastTransitionTime: "2024-02-05T11:14:55Z"
      message: 'containers with unready status: [orchestrator]'
      reason: ContainersNotReady
      status: "False"
      type: Ready
    - lastProbeTime: null
      lastTransitionTime: "2024-02-05T11:14:55Z"
      message: 'containers with unready status: [orchestrator]'
      reason: ContainersNotReady
      status: "False"
      type: ContainersReady
    - lastProbeTime: null
      lastTransitionTime: "2024-02-05T11:14:55Z"
      status: "True"
      type: PodScheduled
    containerStatuses:
    - containerID: containerd://bc122c413a4c436b260456d100ffd4a477ae34d3f54ac7983f7a84ef96d7fc6f
      image: xxx/cnp/kusionstack/ctrlmesh-proxy:v0.1.2
      imageID: xxx/cnp/kusionstack/ctrlmesh-proxy@sha256:50afae553649cdf57b0182fb3693d93902e9f6f7830ae588ea19d69ee1aee9c9
      lastState: {}
      name: ctrlmesh-proxy
      ready: true
      restartCount: 0
      started: true
      state:
        running:
          startedAt: "2024-02-05T11:14:55Z"
    - containerID: containerd://8ac364315ff100fe95aa4c6636aca5cd221d922da4fea0fb01327f2e39fe1376
      image: xxx/cnp/bitpoke/mysql-operator:v0.6.3
      imageID: xxx/cnp/bitpoke/mysql-operator@sha256:0076da68c4aa7a845f5e7e7b9f26c5765d3a9aee339ca39d686663b764a4cd26
      lastState: {}
      name: operator
      ready: true
      restartCount: 0
      started: true
      state:
        running:
          startedAt: "2024-02-05T11:14:58Z"
    - containerID: containerd://adb84258961d9256bf8ccd25677cb77efc8b8a5b4da984fb1190ee59a95bde9d
      image: xxx/cnp/bitpoke/mysql-operator-orchestrator:v0.6.3
      imageID: xxx/cnp/bitpoke/mysql-operator-orchestrator@sha256:49b6c3e06b02c970382d7a0f1e6079ee211bab1504ea97214a059f49d247e883
      lastState:
        terminated:
          containerID: containerd://adb84258961d9256bf8ccd25677cb77efc8b8a5b4da984fb1190ee59a95bde9d
          exitCode: 1
          finishedAt: "2024-02-05T12:11:44Z"
          reason: Error
          startedAt: "2024-02-05T12:11:44Z"
      name: orchestrator
      ready: false
      restartCount: 16
      started: false
      state:
        waiting:
          message: back-off 5m0s restarting failed container=orchestrator pod=mysql-operator-0_test-mysql(b9b5b80c-0b20-4527-ab29-65a2f5c549d3)
          reason: CrashLoopBackOff
    hostIP: <IP_ADDRESS>
    phase: Running
    podIP: <IP_ADDRESS>
    podIPs:
    - ip: <IP_ADDRESS>
    - ip: fd33:1111:2222:4da8:56ad:5fb6:afcc:e03e
    qosClass: Burstable
    startTime: "2024-02-05T11:14:55Z"
kind: List
metadata:
  resourceVersion: ""
  selfLink: ""

Thx for your report, @qiuming520
Please check:

Whether the configmap named fake-kubeconfig has been automatically created in namespace test-mysql;
Whether the file /etc/kubernetes/kubeconfig/fake-kubeconfig.yaml exists in the container directory.

If none of the above issues have occurred, I may need more information, such as the complete pod yaml, pod events, etc.

this is My Operator's pod mysql-operator.txt

Can you provide the last log of the orchestrator container when it failed to start with ctrlmesh-proxy injected. You can find it by command kubectl logs pod <your-operator-pod-name> -c orchestrator -p.

Thx for your report, @qiuming520
Please check:

Whether the configmap named fake-kubeconfig has been automatically created in namespace test-mysql;
Whether the file /etc/kubernetes/kubeconfig/fake-kubeconfig.yaml exists in the container directory.

If none of the above issues have occurred, I may need more information, such as the complete pod yaml, pod events, etc.

this is My Operator's pod mysql-operator.txt

Can you provide the last log of the orchestrator container when it failed to start with ctrlmesh-proxy injected. You can find it by command kubectl logs pod <your-operator-pod-name> -c orchestrator -p.

this is log

The orchestrator's operator process might not have permissions to read /etc/kubernetes/kubeconfig/fake-kubeconfig.yaml. You can try removing the securityContext from the pod and start the manager process inside the container orchestrator with root privileges to troubleshoot this issue. @qiuming520

You can try removing the securityContext from the pod and start the manager process inside the container orchestrator with root privileges to troubleshoot this issue

I have added securityContext for my containers (operator and orchestrator).
apiVersion: apps/v1
kind: StatefulSet
metadata:
  name: mysql-operator
  namespace: test-mysql-1
spec:
  template:
  ... ...
    spec:
      containers:
      - name: operator
        securityContext:
          privileged: true
  ... ...
      - name: orchestrator
        securityContext:
          privileged: true
  ... ...
      securityContext: {}
  ... ...

As you can see in the picture below, the file （/etc/kubernetes/kubeconfig/fake-kubeconfig.yaml） exists and has root privileges in operator container.

But the issue still exists~ @Eikykun

I tried to reproduce this issue using two sample operator containers, but was not successful.  Can you provide a scenario that reproduces this issue in kind? @qiuming520

I tried to reproduce this issue using two sample operator containers, but was not successful. Can you provide a scenario that reproduces this issue in kind?

of course ！ my Operator github https://github.com/bitpoke/mysql-operator
my scenario：Some pods use the canary namespace, and some pods use the normally released namespace.
shardingconfig-root :
apiVersion: ctrlmesh.kusionstack.io/v1alpha1
kind: ShardingConfig
metadata:
  name: sharding-root
  namespace: test-mysql-1
spec:
  root:
    prefix: mysql-operator
    targetStatefulSet: mysql-operator
    canary:
      replicas: 1
      inNamespaces:
      - mysql-01
      - mysql-02
      - mysql-03
    auto:
      everyShardReplicas: 1
      shardingSize: 1
    resourceSelector:
    - relateResources:
      - apiGroups:
        - '*'
        resources:
        - '*'
  controller:
    leaderElectionName: mysql-operator-leader-election

I tried to reproduce this issue using two sample operator containers, but was not successful. Can you provide a scenario that reproduces this issue in kind?

of course ！ my Operator github https://github.com/bitpoke/mysql-operator
my scenario：Some pods use the canary namespace, and some pods use the normally released namespace. shardingconfig-root :
apiVersion: ctrlmesh.kusionstack.io/v1alpha1
kind: ShardingConfig
metadata:
  name: sharding-root
  namespace: test-mysql-1
spec:
  root:
    prefix: mysql-operator
    targetStatefulSet: mysql-operator
    canary:
      replicas: 1
      inNamespaces:
      - mysql-01
      - mysql-02
      - mysql-03
    auto:
      everyShardReplicas: 1
      shardingSize: 1
    resourceSelector:
    - relateResources:
      - apiGroups:
        - '*'
        resources:
        - '*'
  controller:
    leaderElectionName: mysql-operator-leader-election

I briefly looked at the orchestrator container, and it seems that it may not be a standard operator implemented using controller-runtime, as it does not use the --kubeconfig argument. Here, it may be necessary to understand the operating logic of the orchestrator container. If there is a case where a container is not an operator, it might require additional support from a new version.

I tried to reproduce this issue using two sample operator containers, but was not successful. Can you provide a scenario that reproduces this issue in kind?

of course ！ my Operator github https://github.com/bitpoke/mysql-operator
my scenario：Some pods use the canary namespace, and some pods use the normally released namespace. shardingconfig-root :
apiVersion: ctrlmesh.kusionstack.io/v1alpha1
kind: ShardingConfig
metadata:
  name: sharding-root
  namespace: test-mysql-1
spec:
  root:
    prefix: mysql-operator
    targetStatefulSet: mysql-operator
    canary:
      replicas: 1
      inNamespaces:
      - mysql-01
      - mysql-02
      - mysql-03
    auto:
      everyShardReplicas: 1
      shardingSize: 1
    resourceSelector:
    - relateResources:
      - apiGroups:
        - '*'
        resources:
        - '*'
  controller:
    leaderElectionName: mysql-operator-leader-election

I briefly looked at the orchestrator container, and it seems that it may not be a standard operator implemented using controller-runtime, as it does not use the --kubeconfig argument. Here, it may be necessary to understand the operating logic of the orchestrator container. If there is a case where a container is not an operator, it might require additional support from a new version.

Thx for your reply to helped me solve confusion~ @Eikykun


[Pilot] FastlaneCore::BuildWatcher found more than 1 matching build

New Regression Checklist

[x] Updated fastlane to the latest version
[x] I read the Contribution Guidelines
[x] I read docs.fastlane.tools
[x] I searched for existing GitHub issues

Regression Information

Breaking version: [e.g. 2.127.0]
Last working version: [e.g. 2.126.0]

Regression Description
After a successful gym and read_changelog, starting the pilot command job failed
Complete output when running fastlane, including the stack trace and command used
After
INFO [2019-07-10 17:53:30.37]: -----------------------------------------------------
INFO [2019-07-10 17:53:30.37]: Successfully uploaded package to App Store Connect. It might take a few minutes until it's visible online.
INFO [2019-07-10 17:53:30.37]: -----------------------------------------------------
INFO [2019-07-10 17:53:30.38]: Successfully uploaded the new binary to App Store Connect
fastlane got error
> FastlaneCore::BuildWatcher found more than 1 matching build

Environment
✅ fastlane environment ✅
Stack

Key
Value

OS
10.14.4

Ruby
2.4.2

Bundler?
false

Git
git version 2.20.1 (Apple Git-117)

Installation Source
~/.rbenv/versions/2.4.2/bin/fastlane

Host
Mac OS X 10.14.4 (18E226)

Ruby Lib Dir
~/.rbenv/versions/2.4.2/lib

OpenSSL Version
OpenSSL 1.1.0i  14 Aug 2018

Is contained
false

Is homebrew
false

Is installed via Fabric.app
false

Xcode Path
/Applications/Xcode.app/Contents/Developer/

Xcode Version
10.2.1

System Locale

Variable
Value

LANG
en_US.UTF-8
✅

LC_ALL
en_US.UTF-8
✅

LANGUAGE
en_US.UTF-8
✅

### fastlane gems

Gem
Version
Update-Status

fastlane
2.127.0
✅ Up-To-Date

Loaded fastlane plugins:

Plugin
Version
Update-Status

fastlane-plugin-versioning
0.3.4
✅ Up-To-Date

fastlane-plugin-changelog
0.15.0
✅ Up-To-Date

Loaded gems

Gem
Version

did_you_mean
1.1.0

slack-notifier
2.3.2

rouge
2.0.7

xcpretty
0.3.0

terminal-notifier
2.0.0

terminal-table
1.8.0

CFPropertyList
3.0.0

multipart-post
2.0.0

word_wrap
1.0.0

public_suffix
2.0.5

babosa
1.0.2

colored
1.2

highline
1.7.10

commander-fastlane
4.4.6

unf
0.1.4

domain_name
0.5.20180417

http-cookie
1.0.3

faraday-cookie_jar
0.0.6

gh_inspector
1.1.3

mini_magick
4.5.1

multi_xml
0.6.0

security
0.1.3

xcpretty-travis-formatter
1.0.0

bundler
1.17.1

jwt
2.1.0

tty-cursor
0.7.0

tty-spinner
0.9.1

tty-screen
0.7.0

faraday
0.15.4

openssl
2.0.5

json
2.2.0

excon
0.64.0

rubyzip
1.2.3

plist
3.5.0

atomos
0.1.3

claide
1.0.2

colored2
3.1.2

nanaimo
0.2.6

xcodeproj
1.10.0

faraday_middleware
0.13.1

multi_json
1.13.1

signet
0.11.0

uber
0.1.0

declarative
0.0.10

declarative-option
0.1.0

representable
3.0.4

httpclient
2.8.3

google-api-client
0.23.9

google-cloud-env
1.1.0

google-cloud-core
1.3.0

digest-crc
0.4.1

google-cloud-storage
1.16.0

memoist
0.16.0

googleauth
0.6.7

fastimage
2.1.5

io-console
0.4.6

unicode-display_width
1.6.0

dotenv
2.7.2

addressable
2.6.0

os
1.0.1

psych
2.2.2

retriable
3.1.2

mime-types
3.2.2

mime-types-data
3.2019.0331

fastlane-plugin-versioning
0.3.4

fastlane-plugin-changelog
0.15.0

What command are you actually running?
 You only posted the not really interesting part.

What command are you actually running?
 You only posted the not really interesting part.

   pilot(
   changelog: release_notes,
   verbose: true,
   skip_submission: false,
   skip_waiting_for_build_processing: false,
   beta_app_feedback_email<EMAIL_ADDRESS>   wait_for_uploaded_build: true,
   distribute_external: false
 )

.rbenv/versions/2.4.2/lib/ruby/gems/2.4.0/gems/fastlane-2.127.0/fastlane_core/lib/fastlane_core/build_watcher.rb:65:in matching_build': [!] FastlaneCore::BuildWatcher found more than 1 matching build (RuntimeError)
from /Users/macbuildserver1strikersoft/.rbenv/versions/2.4.2/lib/ruby/gems/2.4.0/gems/fastlane-2.127.0/fastlane_core/lib/fastlane_core/build_watcher.rb:23:in `block in wait_for_build_processing_to_be_complete'
from /Users/macbuildserver1strikersoft/.rbenv/versions/2.4.2/lib/ruby/gems/2.4.0/gems/fastlane-2.127.0/fastlane_core/lib/fastlane_core/build_watcher.rb:22:in `loop'
from /Users/macbuildserver1strikersoft/.rbenv/versions/2.4.2/lib/ruby/gems/2.4.0/gems/fastlane-2.127.0/fastlane_core/lib/fastlane_core/build_watcher.rb:22:in `wait_for_build_processing_to_be_complete'
from /Users/macbuildserver1strikersoft/.rbenv/versions/2.4.2/lib/ruby/gems/2.4.0/gems/fastlane-2.127.0/pilot/lib/pilot/build_manager.rb:87:in `wait_for_build_processing_to_be_complete'
from /Users/macbuildserver1strikersoft/.rbenv/versions/2.4.2/lib/ruby/gems/2.4.0/gems/fastlane-2.127.0/pilot/lib/pilot/build_manager.rb:52:in `upload'
from /Users/macbuildserver1strikersoft/.rbenv/versions/2.4.2/lib/ruby/gems/2.4.0/gems/fastlane-2.127.0/fastlane/lib/fastlane/actions/upload_to_testflight.rb:16:in `run'
from /Users/macbuildserver1strikersoft/.rbenv/versions/2.4.2/lib/ruby/gems/2.4.0/gems/fastlane-2.127.0/fastlane/lib/fastlane/runner.rb:256:in `block (2 levels) in execute_action'
from /Users/macbuildserver1strikersoft/.rbenv/versions/2.4.2/lib/ruby/gems/2.4.0/gems/fastlane-2.127.0/fastlane/lib/fastlane/actions/actions_helper.rb:50:in `execute_action'
from /Users/macbuildserver1strikersoft/.rbenv/versions/2.4.2/lib/ruby/gems/2.4.0/gems/fastlane-2.127.0/fastlane/lib/fastlane/runner.rb:235:in `block in execute_action'
from /Users/macbuildserver1strikersoft/.rbenv/versions/2.4.2/lib/ruby/gems/2.4.0/gems/fastlane-2.127.0/fastlane/lib/fastlane/runner.rb:227:in `chdir'
from /Users/macbuildserver1strikersoft/.rbenv/versions/2.4.2/lib/ruby/gems/2.4.0/gems/fastlane-2.127.0/fastlane/lib/fastlane/runner.rb:227:in `execute_action'
from /Users/macbuildserver1strikersoft/.rbenv/versions/2.4.2/lib/ruby/gems/2.4.0/gems/fastlane-2.127.0/fastlane/lib/fastlane/runner.rb:157:in `trigger_action_by_name'
from /Users/macbuildserver1strikersoft/.rbenv/versions/2.4.2/lib/ruby/gems/2.4.0/gems/fastlane-2.127.0/fastlane/lib/fastlane/fast_file.rb:154:in `method_missing'
from Fastfile:121:in `block (2 levels) in parsing_binding'
from /Users/macbuildserver1strikersoft/.rbenv/versions/2.4.2/lib/ruby/gems/2.4.0/gems/fastlane-2.127.0/fastlane/lib/fastlane/lane.rb:33:in `call'
from /Users/macbuildserver1strikersoft/.rbenv/versions/2.4.2/lib/ruby/gems/2.4.0/gems/fastlane-2.127.0/fastlane/lib/fastlane/runner.rb:49:in `block in execute'
from /Users/macbuildserver1strikersoft/.rbenv/versions/2.4.2/lib/ruby/gems/2.4.0/gems/fastlane-2.127.0/fastlane/lib/fastlane/runner.rb:45:in `chdir'
from /Users/macbuildserver1strikersoft/.rbenv/versions/2.4.2/lib/ruby/gems/2.4.0/gems/fastlane-2.127.0/fastlane/lib/fastlane/runner.rb:45:in `execute'
from /Users/macbuildserver1strikersoft/.rbenv/versions/2.4.2/lib/ruby/gems/2.4.0/gems/fastlane-2.127.0/fastlane/lib/fastlane/lane_manager.rb:56:in `cruise_lane'
from /Users/macbuildserver1strikersoft/.rbenv/versions/2.4.2/lib/ruby/gems/2.4.0/gems/fastlane-2.127.0/fastlane/lib/fastlane/command_line_handler.rb:36:in `handle'
from /Users/macbuildserver1strikersoft/.rbenv/versions/2.4.2/lib/ruby/gems/2.4.0/gems/fastlane-2.127.0/fastlane/lib/fastlane/commands_generator.rb:108:in `block (2 levels) in run'
from /Users/macbuildserver1strikersoft/.rbenv/versions/2.4.2/lib/ruby/gems/2.4.0/gems/commander-fastlane-4.4.6/lib/commander/command.rb:178:in `call'
from /Users/macbuildserver1strikersoft/.rbenv/versions/2.4.2/lib/ruby/gems/2.4.0/gems/commander-fastlane-4.4.6/lib/commander/command.rb:153:in `run'
from /Users/macbuildserver1strikersoft/.rbenv/versions/2.4.2/lib/ruby/gems/2.4.0/gems/commander-fastlane-4.4.6/lib/commander/runner.rb:476:in `run_active_command'
from /Users/macbuildserver1strikersoft/.rbenv/versions/2.4.2/lib/ruby/gems/2.4.0/gems/fastlane-2.127.0/fastlane_core/lib/fastlane_core/ui/fastlane_runner.rb:76:in `run!'
from /Users/macbuildserver1strikersoft/.rbenv/versions/2.4.2/lib/ruby/gems/2.4.0/gems/commander-fastlane-4.4.6/lib/commander/delegates.rb:15:in `run!'
from /Users/macbuildserver1strikersoft/.rbenv/versions/2.4.2/lib/ruby/gems/2.4.0/gems/fastlane-2.127.0/fastlane/lib/fastlane/commands_generator.rb:333:in `run'
from /Users/macbuildserver1strikersoft/.rbenv/versions/2.4.2/lib/ruby/gems/2.4.0/gems/fastlane-2.127.0/fastlane/lib/fastlane/commands_generator.rb:41:in `start'
from /Users/macbuildserver1strikersoft/.rbenv/versions/2.4.2/lib/ruby/gems/2.4.0/gems/fastlane-2.127.0/fastlane/lib/fastlane/cli_tools_distributor.rb:119:in `take_off'
from /Users/macbuildserver1strikersoft/.rbenv/versions/2.4.2/lib/ruby/gems/2.4.0/gems/fastlane-2.127.0/bin/fastlane:23:in `<top (required)>'
from /Users/macbuildserver1strikersoft/.rbenv/versions/2.4.2/bin/fastlane:23:in `load'
from /Users/macbuildserver1strikersoft/.rbenv/versions/2.4.2/bin/fastlane:23:in `'
Build step 'Execute shell' marked build as failure`

This is also not the complete output, this is just the end. We really want to look at everything that is output during the command you are running. The pilot calls also seems to be part of a Fastfile, so that should usually have been included in your fastlane env output but is not. Please post it as well so we know what you are running besides that pilot  call.

This is also not the complete output, this is just the end. We really want to look at everything that is output during the command you are running. The pilot calls also seems to be part of a Fastfile, so that should usually have been included in your fastlane env output but is not. Please post it as well so we know what you are running besides that pilot  call.

This is the minimum version number required.
Update this, if you use features of a newer version
fastlane_version "2.66.0"
custom_output_path = "./fastlane/build"
project_name = "ios-client.xcodeproj"
workspace_name = "ios-client.xcworkspace"
test_scheme_name = "ios-clientUITests"
default_platform :ios
platform :ios do
before_all do
# ENV["SLACK_URL"] = "https://hooks.slack.com/services/..."
cocoapods(use_bundle_exec: false)
end
desc "Runs all the tests"
lane :test do
sh "git checkout --force"
ensure_git_status_clean
scan(
workspace:workspace_name,
test_without_building: false,
clean: true,
fail_build: true,
scheme: test_scheme_name,
devices: ["iPhone 7"]
)
end
desc "Submit a new build"
lane :build do
sh "git checkout --force"
sh "git status"
ensure_git_status_clean
gym(
scheme: ENV['SCHEME'],
workspace: workspace_name,
export_method: "app-store",
clean: true,
silent: false,
suppress_xcode_output: true,
include_bitcode: false,
output_directory: custom_output_path
)
end
desc "Submit a new Beta Build to Apple TestFlight"
desc "This will also make sure the profile is up to date"
lane :beta do
puts ENV['TARGET']
puts ENV['SCHEME']
sh "git checkout --force"
  sh "git status"
  ensure_git_status_clean

commit = last_git_commit
hash = commit[:commit_hash] # long sha of commit
set_info_plist_value(path: "ios-client/Info.plist", key: "GitCommitHash", value: hash)

sh "pod install"

app_version = get_version_number_from_plist(xcodeproj: project_name, target: ENV['TARGET'])
puts app_version
begin
build_number = latest_testflight_build_number(version:app_version, initial_build_number:1).to_i + 1
rescue
build_number = get_build_number_from_plist(xcodeproj: project_name, target: ENV['TARGET']).to_i + 1
end
increment_build_number(
    	build_number: build_number,
        xcodeproj: project_name
)

match(git_url: ENV['MATCH_GIT_URL'], type: "appstore", readonly: true, app_identifier: ENV['APP_IDENTIFIER'])
gym(
  scheme: ENV['SCHEME'],
  workspace: workspace_name,
  export_method: "app-store",
  clean: true,
  silent: false,
  suppress_xcode_output: true,
  include_bitcode: false,
  output_directory: custom_output_path
  )

release_notes = read_changelog(section_identifier: '[Unreleased]')

puts release_notes

if (ENV['EXT_GROUPS'] != nil && ENV['EXT_GROUPS'].length > 0)
 pilot(
   changelog: release_notes,
   verbose: true,
   skip_submission: false,
   skip_waiting_for_build_processing: false,
   beta_app_feedback_email<EMAIL_ADDRESS>   distribute_external: true,
   wait_for_uploaded_build: true,
   groups: ENV['EXT_GROUPS']
 )
else
   pilot(
   changelog: release_notes,
   verbose: true,
   skip_submission: false,
   skip_waiting_for_build_processing: false,
   beta_app_feedback_email<EMAIL_ADDRESS>   wait_for_uploaded_build: true,
   distribute_external: false
 )
end

download_dsyms(version:app_version.to_s, build_number:build_number.to_s)                  # Download dSYM files from iTC
upload_symbols_to_crashlytics   # Upload them to Crashlytics
clean_build_artifacts           # Delete the local dSYM files

end
desc "Update change log and push to git"
lane :push do
app_version = get_version_number_from_plist(xcodeproj: project_name, target: ENV['TARGET'])
build_number = latest_testflight_build_number(version:app_version).to_i
release_version = "#{app_version}-#{build_number}"
stamp_changelog(section_identifier: release_version)
git_add(path: "./CHANGELOG.md")

commit_version_bump(message: "Version bump to "+release_version, force: true) # force - to commit CHANGELOG.md

if git_tag_exists(tag: release_version)
  puts "Tag #{release_version} already exists!"
else
  add_git_tag(tag: release_version)
end

push_to_git_remote

end
desc "Build all targets"
lane :build_all do
sh "fastlane build --env target1"
sh "fastlane build --env target2"
end
desc "Deploy all targets"
lane :deploy_all do
sh "fastlane beta --env target1"
sh "fastlane beta --env target2"
end
desc "Download and install certs and provision profiles"
lane :install_certs do
match(git_url: ENV['MATCH_GIT_URL'], type: "appstore", app_identifier: ENV['APP_IDENTIFIER'])
end
after_all do |lane|
# This block is called, only if the executed lane was successful
# slack(
#   message: "Successfully deployed new App Update."
# )

end
error do |lane, exception|
# slack(
#   message: exception.message,
#   success: false
# )
end
end

@vitaminBW Ohhhhh, I might know here 😱 Have you had any rejected versions? We might need to only query for PROCESSING and VALID states 🤔 I'm going to look into this and see if I can replicate.

@vitaminBW Would you be able to runfastlane run spaceship_logs print_contents:true after you run pilot and send me the contents? I'm curious to what your response looked like where it returned more than one build since that shouldn't be possible 😬

Update: I'm not able to replicate this but I am putting in a better error message that shows which builds were all found so that there is useful output if/when this error occurs

We got the same issue yesterday. Fastfile content and log as below:

Fastfile

# Customise this file, documentation can be found here:
# https://github.com/fastlane/fastlane/tree/master/fastlane/docs
# All available actions: https://docs.fastlane.tools/actions
# can also be listed using the `fastlane actions` command

# Change the syntax highlighting to Ruby
# All lines starting with a # are ignored when running `fastlane`

# If you want to automatically update fastlane if a new version is available:
# update_fastlane

# This is the minimum version number required.
# Update this, if you use features of a newer version
fastlane_version "2.38.1"

default_platform :ios

platform :ios do

  before_all do
    # ENV["SLACK_URL"] = "https://hooks.slack.com/services/..."
    # cocoapods
  end

  desc "Runs all the tests"
  lane :test do
    scan
  end

  lane :upload_build do |options|

    version = get_version_number(target: "********")
    build = get_build_number.to_i - 1
    last_tag = "%s/%s.%s" % [version, version, build]

    if !git_tag_exists(tag: last_tag)
      changelog = ""
    else
      changelog = changelog_from_git_commits(
        between: [last_tag, 'HEAD'], # Optional, lets you specify a revision/tag range between which to collect commit info
        merge_commit_filtering: 'only_include_merges' # Optional, lets you filter out merge commits
      )

      # For 3600 characters limit from Apple
      changelog = changelog[0, 3500]
    end

    pilot(
      changelog: changelog,
      username: options[:username],
      distribute_external: true,
      notify_external_testers: false,
      groups: "Public Beta"
    )
  end

  after_all do |lane|
    # This block is called, only if the executed lane was successful

    # slack(
    #   message: "Successfully deployed new App Update."
    # )
  end

  error do |lane, exception|
    # slack(
    #   message: exception.message,
    #   success: false
    # )
  end
end

# More information about multiple platforms in fastlane: https://github.com/fastlane/fastlane/blob/master/fastlane/docs/Platforms.md
# All available actions: https://docs.fastlane.tools/actions

# fastlane reports which actions are used. No personal data is recorded.
# Learn more at https://github.com/fastlane/fastlane#metrics

Output log (2019/07/10 UTC+8)

19:42:16 [19:42:16]: ----------------------------------------
19:42:16 [19:42:16]: --- Step: Verifying fastlane version ---
19:42:16 [19:42:16]: ----------------------------------------
19:42:16 [19:42:16]: Your fastlane version 2.127.0 matches the minimum requirement of 2.38.1  ✅
19:42:16 [19:42:16]: ------------------------------
19:42:16 [19:42:16]: --- Step: default_platform ---
19:42:16 [19:42:16]: ------------------------------
19:42:16 [19:42:16]: Driving the lane 'ios upload_build' 🚀
19:42:16 [19:42:16]: --------------------------------
19:42:16 [19:42:16]: --- Step: get_version_number ---
19:42:16 [19:42:16]: --------------------------------
19:42:16 [19:42:16]: ------------------------------
19:42:16 [19:42:16]: --- Step: get_build_number ---
19:42:16 [19:42:16]: ------------------------------
19:42:16 [19:42:16]: $ cd /Users/jenkins/.jenkins/workspace/ios-member-release-build/Solution/******** && agvtool what-version -terse
19:42:17 [19:42:17]: ▸ 6
19:42:17 [19:42:17]: ----------------------------
19:42:17 [19:42:17]: --- Step: git_tag_exists ---
19:42:17 [19:42:17]: ----------------------------
19:42:17 [19:42:17]: ----------------------------------------
19:42:17 [19:42:17]: --- Step: changelog_from_git_commits ---
19:42:17 [19:42:17]: ----------------------------------------
19:42:17 [19:42:17]: Collecting Git commits between 1.35.0/<IP_ADDRESS> and HEAD
19:42:17
19:42:17 Fix/order contact page crash via push (#1714)
19:42:17 Fix/order contact page crash via push
19:42:17 Merge pull request #1710 from ********/fix/upload-image-size
19:42:17 Fix/upload image size
19:42:17
19:42:17 [19:42:17]: -------------------
19:42:17 [19:42:17]: --- Step: pilot ---
19:42:17 [19:42:17]: -------------------
19:42:17 [19:42:17]: Login to App Store Connect (****)
19:42:19 [19:42:19]: Login successful
19:42:21 [19:42:21]: Ready to upload new build to TestFlight (App: ********)...
19:42:24 [19:42:24]: Going to upload updated app to App Store Connect
19:42:24 [19:42:24]: This might take a few minutes. Please don't interrupt the script.
19:57:13 [19:57:13]: iTunes Transporter successfully finished its job
19:57:14 [19:57:14]: --------------------------------------------------------------------
19:57:14 [19:57:14]: Successfully uploaded package to App Store Connect. It might take a few minutes until it's visible online.
19:57:14 [19:57:14]: --------------------------------------------------------------------
19:57:14 [19:57:14]: Successfully uploaded the new binary to App Store Connect
19:57:14 [19:57:14]: If you want to skip waiting for the processing to be finished, use the `skip_waiting_for_build_processing` option
19:57:16 +------------------+--------------------------------------------------------------+
19:57:16 |                                  Lane Context                                   |
19:57:16 +------------------+--------------------------------------------------------------+
19:57:16 | DEFAULT_PLATFORM | ios                                                          |
19:57:16 | PLATFORM_NAME    | ios                                                          |
19:57:16 | LANE_NAME        | ios upload_build                                             |
19:57:16 | VERSION_NUMBER   | 1.35.0                                                       |
19:57:16 | BUILD_NUMBER     | 6                                                            |
19:57:16 | FL_CHANGELOG     | Fix/order contact page crash via push (#1714)                |
19:57:16 |                  | Fix/order contact page crash via push                        |
19:57:16 |                  | Merge pull request #1710 from ********/fix/upload-image-size |
19:57:16 |                  | Fix/upload image size                                        |
19:57:16 +------------------+--------------------------------------------------------------+
19:57:16 [19:57:16]: FastlaneCore::BuildWatcher found more than 1 matching build
19:57:16
19:57:16 +------+----------------------------+-------------+
19:57:16 |                fastlane summary                 |
19:57:16 +------+----------------------------+-------------+
19:57:16 | Step | Action                     | Time (in s) |
19:57:16 +------+----------------------------+-------------+
19:57:16 | 1    | Verifying fastlane version | 0           |
19:57:16 | 2    | default_platform           | 0           |
19:57:16 | 3    | get_version_number         | 0           |
19:57:16 | 4    | get_build_number           | 0           |
19:57:16 | 5    | git_tag_exists             | 0           |
19:57:16 | 6    | changelog_from_git_commits | 0           |
19:57:16 | 💥   | pilot                      | 899         |
19:57:16 +------+----------------------------+-------------+
19:57:16
19:57:16 [19:57:16]: fastlane finished with errors
19:57:16
19:57:16 Looking for related GitHub issues on fastlane/fastlane...
19:57:16
19:57:17 ➡  [spaceship, pilot] Getting "410 gone"
19:57:17     https://github.com/fastlane/fastlane/issues/14521 [closed] 177 💬
19:57:17     2 weeks ago
19:57:17
19:57:17 🔗  You can ⌘ + double-click on links to open them directly in your browser.
19:57:17 /Users/jenkins/.gem/ruby/2.3.0/gems/fastlane-2.127.0/fastlane_core/lib/fastlane_core/build_watcher.rb:65:in `matching_build': [!] FastlaneCore::BuildWatcher found more than 1 matching build (RuntimeError)
19:57:17 	from /Users/jenkins/.gem/ruby/2.3.0/gems/fastlane-2.127.0/fastlane_core/lib/fastlane_core/build_watcher.rb:23:in `block in wait_for_build_processing_to_be_complete'
19:57:17 	from /Users/jenkins/.gem/ruby/2.3.0/gems/fastlane-2.127.0/fastlane_core/lib/fastlane_core/build_watcher.rb:22:in `loop'
19:57:17 	from /Users/jenkins/.gem/ruby/2.3.0/gems/fastlane-2.127.0/fastlane_core/lib/fastlane_core/build_watcher.rb:22:in `wait_for_build_processing_to_be_complete'
19:57:17 	from /Users/jenkins/.gem/ruby/2.3.0/gems/fastlane-2.127.0/pilot/lib/pilot/build_manager.rb:87:in `wait_for_build_processing_to_be_complete'
19:57:17 	from /Users/jenkins/.gem/ruby/2.3.0/gems/fastlane-2.127.0/pilot/lib/pilot/build_manager.rb:52:in `upload'
19:57:17 	from /Users/jenkins/.gem/ruby/2.3.0/gems/fastlane-2.127.0/fastlane/lib/fastlane/actions/upload_to_testflight.rb:16:in `run'
19:57:17 	from /Users/jenkins/.gem/ruby/2.3.0/gems/fastlane-2.127.0/fastlane/lib/fastlane/runner.rb:256:in `block (2 levels) in execute_action'
19:57:17 	from /Users/jenkins/.gem/ruby/2.3.0/gems/fastlane-2.127.0/fastlane/lib/fastlane/actions/actions_helper.rb:50:in `execute_action'
19:57:17 	from /Users/jenkins/.gem/ruby/2.3.0/gems/fastlane-2.127.0/fastlane/lib/fastlane/runner.rb:235:in `block in execute_action'
19:57:17 	from /Users/jenkins/.gem/ruby/2.3.0/gems/fastlane-2.127.0/fastlane/lib/fastlane/runner.rb:227:in `chdir'
19:57:17 	from /Users/jenkins/.gem/ruby/2.3.0/gems/fastlane-2.127.0/fastlane/lib/fastlane/runner.rb:227:in `execute_action'
19:57:17 	from /Users/jenkins/.gem/ruby/2.3.0/gems/fastlane-2.127.0/fastlane/lib/fastlane/runner.rb:157:in `trigger_action_by_name'
19:57:17 	from /Users/jenkins/.gem/ruby/2.3.0/gems/fastlane-2.127.0/fastlane/lib/fastlane/fast_file.rb:154:in `method_missing'
19:57:17 	from Fastfile:135:in `block (2 levels) in parsing_binding'
19:57:17 	from /Users/jenkins/.gem/ruby/2.3.0/gems/fastlane-2.127.0/fastlane/lib/fastlane/lane.rb:33:in `call'
19:57:17 	from /Users/jenkins/.gem/ruby/2.3.0/gems/fastlane-2.127.0/fastlane/lib/fastlane/runner.rb:49:in `block in execute'
19:57:17 	from /Users/jenkins/.gem/ruby/2.3.0/gems/fastlane-2.127.0/fastlane/lib/fastlane/runner.rb:45:in `chdir'
19:57:17 	from /Users/jenkins/.gem/ruby/2.3.0/gems/fastlane-2.127.0/fastlane/lib/fastlane/runner.rb:45:in `execute'
19:57:17 	from /Users/jenkins/.gem/ruby/2.3.0/gems/fastlane-2.127.0/fastlane/lib/fastlane/lane_manager.rb:56:in `cruise_lane'
19:57:17 	from /Users/jenkins/.gem/ruby/2.3.0/gems/fastlane-2.127.0/fastlane/lib/fastlane/command_line_handler.rb:36:in `handle'
19:57:17 	from /Users/jenkins/.gem/ruby/2.3.0/gems/fastlane-2.127.0/fastlane/lib/fastlane/commands_generator.rb:108:in `block (2 levels) in run'
19:57:17 	from /Users/jenkins/.gem/ruby/2.3.0/gems/commander-fastlane-4.4.6/lib/commander/command.rb:178:in `call'
19:57:17 	from /Users/jenkins/.gem/ruby/2.3.0/gems/commander-fastlane-4.4.6/lib/commander/command.rb:153:in `run'
19:57:17 	from /Users/jenkins/.gem/ruby/2.3.0/gems/commander-fastlane-4.4.6/lib/commander/runner.rb:476:in `run_active_command'
19:57:17 	from /Users/jenkins/.gem/ruby/2.3.0/gems/fastlane-2.127.0/fastlane_core/lib/fastlane_core/ui/fastlane_runner.rb:76:in `run!'
19:57:17 	from /Users/jenkins/.gem/ruby/2.3.0/gems/commander-fastlane-4.4.6/lib/commander/delegates.rb:15:in `run!'
19:57:17 	from /Users/jenkins/.gem/ruby/2.3.0/gems/fastlane-2.127.0/fastlane/lib/fastlane/commands_generator.rb:333:in `run'
19:57:17 	from /Users/jenkins/.gem/ruby/2.3.0/gems/fastlane-2.127.0/fastlane/lib/fastlane/commands_generator.rb:41:in `start'
19:57:17 	from /Users/jenkins/.gem/ruby/2.3.0/gems/fastlane-2.127.0/fastlane/lib/fastlane/cli_tools_distributor.rb:119:in `take_off'
19:57:17 	from /Users/jenkins/.gem/ruby/2.3.0/gems/fastlane-2.127.0/bin/fastlane:23:in `<top (required)>'
19:57:17 	from /Users/jenkins/.gem/ruby/2.3.0/bin/fastlane:23:in `load'
19:57:17 	from /Users/jenkins/.gem/ruby/2.3.0/bin/fastlane:23:in `<main>'

i get a same issue at today.

fastlane log (2019.07.11)
15:37:12 + fastlane pilot upload --wait_for_uploaded_build 15:37:13 [15:37:13]: Get started using a Gemfile for fastlane https://docs.fastlane.tools/getting-started/ios/setup/#use-a-gemfile 15:37:13 /Library/Ruby/Gems/2.3.0/gems/fastlane-2.127.0/fastlane/lib/fastlane/actions/changelog_from_git_commits.rb:4: warning: already initialized constant Fastlane::Actions::SharedValues::FL_CHANGELOG 15:37:13 /Library/Ruby/Gems/2.3.0/gems/fastlane-2.127.0/fastlane/lib/fastlane/actions/make_changelog_from_jenkins.rb:4: warning: previous definition of FL_CHANGELOG was here 15:37:13 /Library/Ruby/Gems/2.3.0/gems/fastlane-2.127.0/fastlane/lib/fastlane/actions/xcodebuild.rb:5: warning: already initialized constant Fastlane::Actions::SharedValues::XCODEBUILD_ARCHIVE 15:37:13 /Library/Ruby/Gems/2.3.0/gems/fastlane-2.127.0/fastlane/lib/fastlane/actions/build_ios_app.rb:6: warning: previous definition of XCODEBUILD_ARCHIVE was here 15:37:13 [15:37:13]: Using deprecated option: '--wait_for_uploaded_build' (No longer needed with the transition over to the App Store Connect API) 15:37:13 [15:37:13]: Login to App Store Connect<EMAIL_ADDRESS>15:37:15 [15:37:15]: Login successful 15:37:16 [15:37:16]: Ready to upload new build to TestFlight (App: 596642855)... 15:37:17 [15:37:17]: Going to upload updated app to App Store Connect 15:37:17 [15:37:17]: This might take a few minutes. Please don't interrupt the script. 15:48:55 [15:48:55]: iTunes Transporter successfully finished its job 15:48:55 [15:48:55]: -------------------------------------------------------------------- 15:48:55 [15:48:55]: Successfully uploaded package to App Store Connect. It might take a few minutes until it's visible online. 15:48:55 [15:48:55]: -------------------------------------------------------------------- 15:48:55 [15:48:55]: Successfully uploaded the new binary to App Store Connect 15:48:55 [15:48:55]: If you want to skip waiting for the processing to be finished, use theskip_waiting_for_build_processingoption 15:49:08  15:49:08 Looking for related GitHub issues on fastlane/fastlane... 15:49:08  15:49:09 ➡  [Pilot] FastlaneCore::BuildWatcher found more than 1 matching build 15:49:09     https://github.com/fastlane/fastlane/issues/15007 [open] 8 💬 15:49:09     3 hours ago 15:49:09  15:49:09 ➡  [spaceship, pilot] Getting "410 gone" 15:49:09     https://github.com/fastlane/fastlane/issues/14521 [closed] 177 💬 15:49:09     2 weeks ago 15:49:09  15:49:09 🔗  You can ⌘ + double-click on links to open them directly in your browser. 15:49:09 /Library/Ruby/Gems/2.3.0/gems/fastlane-2.127.0/fastlane_core/lib/fastlane_core/build_watcher.rb:65:inmatching_build': [!] FastlaneCore::BuildWatcher found more than 1 matching build (RuntimeError)
15:49:09 	from /Library/Ruby/Gems/2.3.0/gems/fastlane-2.127.0/fastlane_core/lib/fastlane_core/build_watcher.rb:23:in block in wait_for_build_processing_to_be_complete' 15:49:09 	from /Library/Ruby/Gems/2.3.0/gems/fastlane-2.127.0/fastlane_core/lib/fastlane_core/build_watcher.rb:22:in loop'
15:49:09 	from /Library/Ruby/Gems/2.3.0/gems/fastlane-2.127.0/fastlane_core/lib/fastlane_core/build_watcher.rb:22:in wait_for_build_processing_to_be_complete' 15:49:09 	from /Library/Ruby/Gems/2.3.0/gems/fastlane-2.127.0/pilot/lib/pilot/build_manager.rb:87:in wait_for_build_processing_to_be_complete'
15:49:09 	from /Library/Ruby/Gems/2.3.0/gems/fastlane-2.127.0/pilot/lib/pilot/build_manager.rb:52:in upload' 15:49:09 	from /Library/Ruby/Gems/2.3.0/gems/fastlane-2.127.0/pilot/lib/pilot/commands_generator.rb:66:in block (2 levels) in run'
15:49:09 	from /Library/Ruby/Gems/2.3.0/gems/commander-fastlane-4.4.6/lib/commander/command.rb:178:in call' 15:49:09 	from /Library/Ruby/Gems/2.3.0/gems/commander-fastlane-4.4.6/lib/commander/command.rb:153:in run'
15:49:09 	from /Library/Ruby/Gems/2.3.0/gems/commander-fastlane-4.4.6/lib/commander/runner.rb:476:in run_active_command' 15:49:09 	from /Library/Ruby/Gems/2.3.0/gems/fastlane-2.127.0/fastlane_core/lib/fastlane_core/ui/fastlane_runner.rb:76:in run!'
15:49:09 	from /Library/Ruby/Gems/2.3.0/gems/commander-fastlane-4.4.6/lib/commander/delegates.rb:15:in run!' 15:49:09 	from /Library/Ruby/Gems/2.3.0/gems/fastlane-2.127.0/pilot/lib/pilot/commands_generator.rb:166:in run'
15:49:09 	from /Library/Ruby/Gems/2.3.0/gems/fastlane-2.127.0/pilot/lib/pilot/commands_generator.rb:18:in start' 15:49:09 	from /Library/Ruby/Gems/2.3.0/gems/fastlane-2.127.0/fastlane/lib/fastlane/cli_tools_distributor.rb:111:in take_off'
15:49:09 	from /Library/Ruby/Gems/2.3.0/gems/fastlane-2.127.0/bin/fastlane:23:in <top (required)>' 15:49:09 	from /usr/local/bin/fastlane:22:in load'
15:49:09 	from /usr/local/bin/fastlane:22:in <main>' 15:49:09 Build step 'Execute shell' marked build as failure 15:49:09 [Slack Notifications] found #583 as previous completed, non-aborted build 15:49:09 Finished: FAILURE

@vitaminBW Would you be able to runfastlane run spaceship_logs print_contents:true after you run pilot and send me the contents? I'm curious to what your response looked like where it returned more than one build since that shouldn't be possible 😬

Can't catch it today. If I find it again I will post a response here.

@vitaminBW Ohhhhh, I might know here 😱 Have you had any rejected versions? We might need to only query for PROCESSING and VALID states 🤔 I'm going to look into this and see if I can replicate.

I don't have rejected versions at least one year

I have the same problem with command upload_to_testflight today

Found the problem 😱 Fixing it in 2.127.1 which will be release within a few hours

This is now released in 2.127.1 🚀


for apisession.get_*_values add option to account for interval_label

Currently, start and end describe the range of timestamps expected in the return value of the methods. If interval_label of the model is accounted for, start and end can instead describe the time range that the forecast/observation are valid over. For example, if a forecast has interval_label = beginning and interval_length = 1hr, a request from 2019-05-01T1200Zto 2019-05-01T1400Z will return a timeseries with time labels 2019-05-01T1200Z and 2019-05-01T1300Z since these values represent the entire following hour.
Both conventions can be useful. For example, when plotting something over a plot range, specifying the range in terms of the expected output can be useful. When requesting data to compare forecasts and observations, specifying the range in the second way returns values that only use/contain information from the range.

Nice summary

The functions in reference_forecasts.persistence assume that data returned by the API accounts for interval label. As a result, the reference_forecasts.main.run_persistence wrapper of these functions produces slightly incorrect forecasts or fails due to the length of forecast being 1 element longer than the index.


Docs 661 add batch api to sql doc (Do not merge yet)

For Docs issue#661.
@dgaubert , I am being proactive and created draft content for the SQL Batch API content.  Let's use this PR as a placeholder for editing and/or new content until this is ready to be "officially released".

What is the status on when this feature will be "public"?

@dgaubert (the Travis CI build failed for some reason, not sure why? We'll need to resolve before merging).
I added the multi query batch info to the Batch API section. Here is the updated staging envn that I generated from the Docs repo. Please review all the Batch API content, and code, and let me know if anything needs to be edited?   http://661-add-batch-api-to-sql-docs.docs.cartodb-staging.com/cartodb-platform/sql-api/sql-batch-api/

@dgaubert , okay- good stuff!  I removed the Patch process and updated the multi query cancel description, as discussed.  Give it another skim and let's make sure it is good to go.

@dgaubert , I added the error code to the Cancel operation. Just need confirmation about the Update operation response code.

:shipit:


Another Request (Multitasker)

Hello Andy,
I'm literally using S.L.A.M Everytime when I'm playing CSGO!
It's The best thing!
Back to the Real Post :)
Are you able to like add if someone is having S.L.A.M turned on (music loaded and started) to make him also able to like Speak with the Normal key set in the Settings which will pause the music and if he's finished talking itcontinues the music
Would be literally a very Nice Feature
Sincerely JustMinePlayz
Aurel

it would be the best feature idk why no one has added it yet


Add auto-date histogram aggregations documentation

Description
Closes content gaps for the following bucket aggregations:
Auto-interval date histogram
Children
Composite
Parent
Rare terms
Issues Resolved
#4293
Version
Backport to latest version
Frontend features
If you're submitting documentation for an OpenSearch Dashboards feature, add a video that shows how a user will interact with the UI step by step. A voiceover is optional.
Checklist

[X] By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Thank you, @vagimeli! Can we add more info about these parameters? Is there granularity to the returned intervals? What are the formats for dates/times and time zones? Is there a default time zone?
@bowenlan-amzn Please provide technical input about the above questions. Where can I find these details?

Hi @bowenlan-amzn @kolchfa-aws I've addressed feedback comments. Please review and approve at your availability. Thank you :)


RuntimeError: No CUDA GPUs are available

Hi @LiYingwei  hope that is well.
When I run torch.cuda.is_available() it shows true. And Cuda is always work fine in all projects that need GPU. However, in this project when I run python imagenet.py -a resnet50 --data %DATA% --mixbn --evaluate --load %CKPT% , it returns RuntimeError: No CUDA GPUs are available
Could you please give me some clue?
Thanks

maybe you should replace the arg.gpu_id with your real gpu_id such as "0"

Thanks @LiuShisan23 Yes, it's already resolved.


build(material): add bazel rules for all components

Part of #8369
cc @DevVersion
The genrules for transforming the css output are unfortunate but should be able to be removed without a ton of effort.

Updated now with CircleCI config to build everything

Even if srcs accepts an array I think $< still works if there happens to be
one value?
On Wed, Nov 15, 2017, 5:22 PM Jeremy Elbourn<EMAIL_ADDRESS>wrote:

@jelbourn commented on this pull request.
In .circleci/config.yml
https://github.com/angular/material2/pull/8457#discussion_r151299078:

@@ -34,7 +34,7 @@ jobs:
# For some reason, circleci needs the postinstall to be run explicitly.
# This may be unnecessary once ngcontainer uses nodejs 8

Done
In src/lib/autocomplete/BUILD.bazel
https://github.com/angular/material2/pull/8457#discussion_r151299283:

@@ -0,0 +1,40 @@
+package(default_visibility=["//visibility:public"])
+load("@angular//:index.bzl", "ng_module")
+load("@io_bazel_rules_sass//sass:sass.bzl", "sass_library")
+load("@io_bazel_rules_sass//sass:sass.bzl", "sass_binary")

Done
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
https://github.com/angular/material2/pull/8457#discussion_r151299078,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAC5I9RgWn7V-c_T7mzMoCHe1rBlSN1Rks5s245tgaJpZM4Qff7n
.

@alexeagle
ERROR: /usr/local/google/home/jelbourn/material2/src/lib/button/BUILD.bazel:39:9: in cmd attribute of genrule rule //src/lib/button:button_css: variable '$<' : more than one input file

CircleCI issues are now resolved


Thoughts on what to be stored in the mongodb

I was thinking three collections in the mongodb; Cases, Variants,
Samples. The Schemas for these collections are found in
mutacc/mutaccDB/schema/
I've added functions and classes to parse the input case data and make
appropriate objects to be imported to the three collections
respectively.

Now using mongo-adapter to communicate with database.
New files:
mutacc/mutaccDB/db_adapter.py
mutacc/mutaccDB/insert.py
change in file:
mutacc/builds/build_case.py
More tests, and logging, will be added in upcoming pull request.


[v2] Python Extension - Interactive Window not working

code-server version: 2.preview.9-vsc1.37.0
OS Version: Ubuntu 16.04
Extension: VSCode Python - 2019.6.24221

Description
The Python Interactive feature (uses Jupyter to run Python code) does not seem to work with the v2 code-server version. When trying to run any script in interactive mode, the window will stay blank, and the Starting Jupyter server indicator in the status bar will remain there indefinitely:

This feature is working with the v1 version of code-server (same machine, settings, versions, configuration).
I tried to gather a few more insights to help solve the issue:

The Jupyter notebook server process is never created in v2 (for v1 the process is started)
The last log message in the developer tools console is Getting jupyter server options...

The index_bundle.js under this url path /webview/vscode-resource/root/.vscode/extensions/ms-python.python-2019.6.24221/out/datascience-ui/history-react/index_bundle.js returns Not Found (in v1 the correct script is returned). However, the service worker seems to be able to load a valid script.
I wasn't able to find any specific errors in the logs that seems to be related to this issue, but here are some other errors that appear:

Steps to Reproduce

Start code server (preview 9)
Install VSCode Python Extension
Create python script and select Run Current File in Python Interactive Window

Just tried with 2.preview.11-vsc1.37.0 and I can confirm that  d33b2d2af9ce87b789e256ed16b94ddc81ff13f3 fixes the issue for me. Thanks to @code-asher for the fix.


Review - Bruno

Since you already merged all the PRs, I'm creating this PR with few suggestions.

We already had the call to discuss these suggestions.


Fix missing bots when generating soldat.smod file

The bots files are missing form the soldat.smod file.
They have to be placed in the configs folder to get zipped.
Also soldatserver looks inside configs/bots/* for the bot files.
See https://github.com/Soldat/soldat/issues/11 for the resulting error and how to reproduce it.

I'm not sure if the client can still be run as a server/host a local game.
I remember there was some discussion to separate both.


Deposit contract fixes

Address #1357 and #1279.
Todo: Wait for https://github.com/ethereum/vyper/issues/1563 to be addressed and a new Vyper release to address #1341.

@JustinDrake do you mind also updating the deposit contract spec? (https://github.com/ethereum/eth2.0-specs/blob/0e7287eda5ea7601707a5a4e2167f98fab699644/specs/core/0_deposit-contract.md#deposit-function?) Otherwise, this PR looks good to me. :)

do you mind also updating the deposit contract spec?

done :+1: