How to make the remote video view fill the entire view

Description
I managed to get the video chat set up with the help of the Quick start code samples. I used the same code from the sample to layout the remote video view.
I want it to be portrait and fill the entire view. But what I get looks like this.

Remote video view does not fill the entire view
Code
private func setupRemoteVideoView() {
    // Creating `VideoView` programmatically
    remoteVideoView = VideoView(frame: CGRect.zero, delegate: self)
    remoteVideoView?.contentMode = .scaleAspectFit
    view.insertSubview(remoteVideoView!, at: 0)

    let centerX = NSLayoutConstraint(item: remoteVideoView!, attribute: NSLayoutConstraint.Attribute.centerX, relatedBy: NSLayoutConstraint.Relation.equal, toItem: view, attribute: NSLayoutConstraint.Attribute.centerX, multiplier: 1, constant: 0);
    view.addConstraint(centerX)
    let centerY = NSLayoutConstraint(item: remoteVideoView!, attribute: NSLayoutConstraint.Attribute.centerY, relatedBy: NSLayoutConstraint.Relation.equal, toItem: view, attribute: NSLayoutConstraint.Attribute.centerY, multiplier: 1, constant: 0);
    view.addConstraint(centerY)
    let width = NSLayoutConstraint(item: remoteVideoView!, attribute: NSLayoutConstraint.Attribute.width, relatedBy: NSLayoutConstraint.Relation.equal, toItem: view, attribute: NSLayoutConstraint.Attribute.width, multiplier: 1, constant: 0);
    view.addConstraint(width)
    let height = NSLayoutConstraint(item: remoteVideoView!, attribute: NSLayoutConstraint.Attribute.height, relatedBy: NSLayoutConstraint.Relation.equal, toItem: view, attribute: NSLayoutConstraint.Attribute.height, multiplier: 1, constant: 0);
    view.addConstraint(height)
}

Expected Behavior
The remote video view to fill the entire view.
Actual Behavior
Remote video view does not fill the entire view.
Reproduces How Often
100%
Versions
Video iOS SDK
3.2.2 via CocoaPods
Xcode
11.3
iOS Version
13.3.1
iOS Device
iPhone 11 Pro

Hi @Isuru-Nanayakkara,
From your screenshot, it looks like the remote party has their device in landscape. If both are iOS devices, holding them in the same orientation will result video that fills more, but not all of the screen. If you just want to crop the video to fill the screen then you can use UIViewContentModeScaleAspectFill.
remoteVideoView?.contentMode = .scaleAspectFill

It is also possible to use TVICameraSource to choose a 16:9 format that will be closer to filling the screen when the orientation of each device is the same. See Selecting a Device Format in our guide, and also the MultiPartyExample for some pointers.
Let me know if you need any more help.
Thanks,
Chris

Hi @ceaglest, thanks for the help. Setting the content mode to . scaleAspectFill indeed did the trick.
If I were to go with the TVICameraSource route, I'll have to check the orientation and device types dynamically to choose the best format, right?

Hey @Isuru-Nanayakkara,
That's good to hear.

If I were to go with the TVICameraSource route, I'll have to check the orientation and device types dynamically to choose the best format, right?

Yes that is correct. For example, if one device is an iPad then the default format (640x480) will already fill the screen in most cases.
Best,
Chris

I see. I think remoteVideoView?.contentMode = .scaleAspectFill fits my needs fine for now. Thanks for the help!

Sorry to reopen this, but in my case, the remote view is sideways despite both devices being in the same orientation. Any ideas?
Here's how I capture the frames:
 @objc func displayLinkDidFire(timer: CADisplayLink) {
        self.arView.snapshot(saveToHDR: false) { (image) in
            let compressedImage = UIImage(data: (image?.pngData())!)
            self.frame = VideoFrame(timeInterval: timer.timestamp,
                                    buffer: (compressedImage?.convertToBuffer())!,
                                    orientation: VideoOrientation.left)
            self.sink!.onVideoFrame(self.frame!)
        }
    }

and
remoteVideoView?.contentMode = .scaleAspectFill.


[BEAM-11418] Small fixes to Go xlang artifact staging.

Add back a field I accidentally dropped and add a package comment to avoid lint errors. Small stuff.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[x] Choose reviewer(s) and mention them in a comment (R: @username).
[x] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] Update CHANGES.md with noteworthy changes.
[x] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

R: @lostluck


mitmweb isn't protected against DNS rebinding

The mitmweb interface does not seem to include protection against DNS rebinding. This could be exploited by a malicious website to either access the sniffed data or run arbitrary Python scripts on the filesystem by setting the scripts config option.
I have hacked together a PoC here (nothing really special to be seen though).

Thanks for raising this. Any recommendations on how we can fix this best?

I like the Jupyter implementation - effectively password protect the web interface, but pass an access token to your webbrowser.open call not to annoy the user too much. As a simpler alternative, you can implement Host header based whitelist (allowing localhost or IP address access by default).

Thanks again - we've just released mitmproxy 4.0.4, which includes the fix from #3243. :)

Can I allow binding? Trying to use ngrok

Is it possible to turn it off and allow DNS rebinding?

Would also like to know if this can be disabled - my instance is behind a reverse proxy so I am presuming this is safe enough for what I need it for, and accessing it externally would be helpful.

Yes would love for this to be configurable.

As @Kriechi merged https://github.com/mitmproxy/mitmproxy/pull/3243 into the master.
Also mentioning @mhils @atx
Whats the problem having by default DnsBinding protection enabled,
but have this option configurable?
In our case, for internal usage purposes, we need to fork this repo and revert mentioned PR in order to fulfill our needs.
IMHO, thats not the best way to do that.
 A day spent trying to figure out why a docker swarm Traefik router for mitmweb.example.com always returned 404.

@chrisbecke regarding traefik you need to disable passHostHeader see below example using compose - hope it helps you too :)
mitmproxy:
    image: mitmproxy/mitmproxy
    tty: true
    command: "mitmweb --web-host *"
    labels:
      - "traefik.http.services.mitmproxy.loadbalancer.server.port=8081"
      - "traefik.http.services.mitmproxy.loadbalancer.passHostHeader=false"

Ive passed that, and used a middleware to set the host header to <IP_ADDRESS> - but the websocket that fetches updates always says "connection lost", or "connecting" forever.

@chrisbecke ah sry, forgot to mention them too, you also need to add a middleware that drops some request headers to make the websocket work:
      - "traefik.http.routers.mitmproxy-https.middlewares=mitmproxy-header@docker"
      - "traefik.http.middlewares.mitmproxy-header.headers.isDevelopment=true"
      - "traefik.http.middlewares.mitmproxy-header.headers.customrequestheaders.Host="
      - "traefik.http.middlewares.mitmproxy-header.headers.customrequestheaders.Origin="

I was able to get it working with nginx (NPM actually) as reverse proxy by adding following two lines in config and allowing websocket
   proxy_set_header Host "";
   proxy_set_header Origin "";

How to implement this workaround for nginx-proxy-manager?

It is work for kubernetes traefik ingressRoute:
apiVersion: traefik.containo.us/v1alpha1
kind: IngressRoute
metadata:
  annotations:
    kubernetes.io/ingress.class: traefik2
  name: mitmproxy
  namespace: xxxx
spec:
  entryPoints:
  - web
  routes:
  - kind: Rule
    match: Host(`web.xxxx.com`)
    services:
    - kind: Service
      name: mitmproxy
      namespace: weimob-ops
      port: 8081
    middlewares:
    - name: mitmproxy-web-header
      namespace: xxx
---
apiVersion: traefik.containo.us/v1alpha1
kind: Middleware
metadata:
  name: mitmproxy-web-header
  namespace: xxx
spec:
  headers:
    customRequestHeaders:
      # hack to remove origin request Host header
      # may be relate https://github.com/traefik/traefik/pull/6502
      Host: " " # this is a space
      Origin: ""
    isDevelopment: true

Here's what I eventually got working on haproxy for a home assistant docker container.
frontend main
    bind *:8081

    http-response del-header    x-frame-options
    default_backend             mitmweb

backend mitmweb
    balance     roundrobin
    http-request set-header Host <IP_ADDRESS>:9090
    http-request set-header Origin http://<IP_ADDRESS>:9090
    server  mitm    <IP_ADDRESS>:9090 check

In my case, haproxy is listening on 8081, then proxying this to a mitmproxy instance running its web server on 9090.  Both of these are inside a docker container.
The http:// on the origin header line turned out to be important. I'm not fully sure why, but without this, the websocket connection was not allowed through haproxy to mitmproxy.

A further potentially helpful snippet for users of Kubernetes' Nginx controller:
apiVersion: networking.k8s.io/v1
kind: Ingress
metadata:
  annotations:
    nginx.ingress.kubernetes.io/upstream-vhost: "<IP_ADDRESS>:8081"

For anyone using Caddy as their reverse proxy:
https://mitmproxy.example.com {
	reverse_proxy * localhost:8081 {
		header_up Host <IP_ADDRESS>:8081
		header_up Origin http://<IP_ADDRESS>:8081
	}
}

example docker-compose.yml
services:
  mitmproxy:
    image: mitmproxy/mitmproxy
    command: mitmweb --web-host <IP_ADDRESS>
    ports:
      - 8080:8080
      - 8081:8081
    volumes:
      - /mitmproxy-data:/home/mitmproxy/.mitmproxy


Updated to add SetUserFTA tool

Updated to add SetUserFTA tool, MUST update ssWPI tools, local SetupS install for it to operate (ignored if old version)

I've not compiled the changes to the pull request to keep it small and easy to compare :)

good work


⚠ ClamAV has degraded performance

In 04dbbc7, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 87 ms

Resolved: ClamAV performance has improved in fa9c992.


add verbosity

add verbosity

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Add data science minor

Add data science minor to minors.
This is a new minor offered starting Spring 2023: https://stat.cornell.edu/academics/undergraduate/data-science-minor/minor-requirements
Test Plan

Test if ENGRD 2700 or ECE 3100 fulfill core statistics requirement.
Test if the two subrequirements in "Categories" requirement work as expected - 4 total courses in 3 categories.

Notes

There is no existing way to check against classes taken for a student's major.

Applies to computing requirement. If intro computing is required for major, then they cannot use intro computing for the req. Currently addressed as a checkerWarning.
Applies to Categories requirement. Courses cannot also be used in major core. Currently included in just the description as checkerWarning produces user-inconveniencing behavior.

The minor is technically offered under the CIS school.
No set information available on advisors yet. I tentatively included the undergraduate director for data science as the advisor.

Good work. Are we sure that this minor is only available to EN, AG, and AS?

These refer to the colleges that offer the minor, not those eligible to complete it.


[youtube] "WARNING: unable to extract html5 player" on some videos

Make sure you are using the latest version: run youtube-dl --version and ensure your version is 2018.12.09. If it's not, read this FAQ entry and update. Issues with outdated version will be rejected.

[x] I've verified and I assure that I'm running youtube-dl 2018.12.09

Before submitting an issue make sure you have:

[x] At least skimmed through the README, most notably the FAQ and BUGS sections
[x] Searched the bugtracker for similar issues including closed ones
[x] Checked that provided video/audio/playlist URLs (if any) are alive and playable in a browser

What is the purpose of your issue?

[x] Bug report (encountered problems with youtube-dl)

If the purpose of this issue is a bug report, site support request or you are not completely sure provide the full verbose output as follows:
Add the -v flag to your command line you run youtube-dl with (youtube-dl -v <your command line>), copy the whole output and insert it here. It should look similar to one below (replace it with your log inserted between triple ```):
$ youtube-dl --verbose --no-call-home --list-formats --cookies cookies.txt "https://www.youtube.com/watch?v=ktkjUjcZid0"
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: [u'--verbose', u'--no-call-home', u'--list-formats', u'--cookies', u'cookies.txt', u'https://www.youtube.com/watch?v=ktkjUjcZid0']
[debug] Encodings: locale UTF-8, fs UTF-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2018.12.09
[debug] Python version 2.7.15rc1 (CPython) - Linux-4.15.0-36-generic-x86_64-with-Ubuntu-18.04-bionic
[debug] exe versions: ffmpeg 4.0.3-1, ffprobe 4.0.3-1
[debug] Proxy map: {}
[youtube] ktkjUjcZid0: Downloading webpage
[youtube] ktkjUjcZid0: Downloading video info webpage
WARNING: unable to extract html5 player; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
[youtube] {22} signature length 40.40, html5 player None
WARNING: unable to extract html5 player; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
[youtube] {18} signature length 40.40, html5 player None
WARNING: unable to extract html5 player; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
[youtube] {313} signature length 40.40, html5 player None
WARNING: unable to extract html5 player; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
[youtube] {271} signature length 40.40, html5 player None
WARNING: unable to extract html5 player; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
[youtube] {137} signature length 40.40, html5 player None
WARNING: unable to extract html5 player; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
[youtube] {248} signature length 40.40, html5 player None
WARNING: unable to extract html5 player; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
[youtube] {136} signature length 40.40, html5 player None
WARNING: unable to extract html5 player; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
[youtube] {247} signature length 40.40, html5 player None
WARNING: unable to extract html5 player; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
[youtube] {135} signature length 40.40, html5 player None
WARNING: unable to extract html5 player; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
[youtube] {244} signature length 40.40, html5 player None
WARNING: unable to extract html5 player; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
[youtube] {134} signature length 40.40, html5 player None
WARNING: unable to extract html5 player; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
[youtube] {243} signature length 40.40, html5 player None
WARNING: unable to extract html5 player; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
[youtube] {133} signature length 40.40, html5 player None
WARNING: unable to extract html5 player; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
[youtube] {242} signature length 40.40, html5 player None
WARNING: unable to extract html5 player; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
[youtube] {160} signature length 40.40, html5 player None
WARNING: unable to extract html5 player; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
[youtube] {278} signature length 40.40, html5 player None
WARNING: unable to extract html5 player; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
[youtube] {140} signature length 40.40, html5 player None
WARNING: unable to extract html5 player; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
[youtube] {171} signature length 40.40, html5 player None
WARNING: unable to extract html5 player; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
[youtube] {249} signature length 40.40, html5 player None
WARNING: unable to extract html5 player; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
[youtube] {250} signature length 40.40, html5 player None
WARNING: unable to extract html5 player; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
[youtube] {251} signature length 40.40, html5 player None
WARNING: unable to extract html5 player; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
[youtube] {256} signature length 40.40, html5 player None
WARNING: unable to extract html5 player; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
[youtube] {258} signature length 40.40, html5 player None
[info] Available formats for ktkjUjcZid0:
format code  extension  resolution note
249          webm       audio only DASH audio   61k , opus @ 50k, 8.94MiB
250          webm       audio only DASH audio   78k , opus @ 70k, 11.61MiB
171          webm       audio only DASH audio  127k , vorbis@128k, 18.39MiB
140          m4a        audio only DASH audio  131k , m4a_dash container, mp4a.40.2@128k, 22.53MiB
251          webm       audio only DASH audio  151k , opus @160k, 22.80MiB
256          m4a        audio only DASH audio  196k , m4a_dash container, mp4a.40.5, 33.76MiB
258          m4a        audio only DASH audio  387k , m4a_dash container, mp4a.40.2, 67.11MiB
278          webm       256x144    144p  102k , webm container, vp9, 24fps, video only, 14.70MiB
160          mp4        256x144    144p  148k , avc1.4d400c, 24fps, video only, 19.48MiB
242          webm       426x240    240p  224k , vp9, 24fps, video only, 25.11MiB
133          mp4        426x240    240p  283k , avc1.4d4015, 24fps, video only, 43.06MiB
243          webm       640x360    360p  342k , vp9, 24fps, video only, 46.60MiB
134          mp4        640x360    360p  671k , avc1.4d401e, 24fps, video only, 62.53MiB
244          webm       854x480    480p  700k , vp9, 24fps, video only, 96.06MiB
135          mp4        854x480    480p 1210k , avc1.4d401e, 24fps, video only, 127.04MiB
247          webm       1280x720   720p 1393k , vp9, 24fps, video only, 202.95MiB
136          mp4        1280x720   720p 2397k , avc1.4d401f, 24fps, video only, 245.77MiB
248          webm       1920x1080  1080p 2533k , vp9, 24fps, video only, 372.78MiB
137          mp4        1920x1080  1080p 4435k , avc1.640028, 24fps, video only, 466.40MiB
271          webm       2560x1440  1440p 6400k , vp9, 24fps, video only, 990.92MiB
313          webm       3840x2160  2160p 12900k , vp9, 24fps, video only, 1.96GiB
18           mp4        640x360    medium , avc1.42001E, mp4a.40.2@ 96k, 85.40MiB
22           mp4        1280x720   hd720 , avc1.64001F, mp4a.40.2@192k (best)

Youtube Premium - WARNING: unable to extract html5 player; but download seems fine
First of all, I have seen that similar issues have been reported:
https://github.com/rg3/youtube-dl/issues/17516
https://github.com/rg3/youtube-dl/issues/18297
However, none of them mention Youtube Premium. So far, in addition to the example videos mentioned in those issue reports, I have only encountered this issue on Youtube Premium videos, be they freely available ones or behind a paywall.
The example video corresponding to the URL provided in the log is a free episode (the 1st one) from the 3rd season of Vsauce's series Mind Field.
As the log shows, I get several WARNING: unable to extract html5 player; messages.
The videos seem to download just fine though.
This issue also happens in other episodes, including those behind a paywall. If one needs access to the episodes behind the paywall, it is sufficient to create a Google account and start a 1-month free trial of Youtube Premium, or to do so with an existing Google account.
New Google accounts can be created easily without using/linking phone numbers.

The videos seem to download just fine though.

it only effects the logs when used with --verbose
https://github.com/rg3/youtube-dl/blob/2511eee215c2a66020ae927c86face826f48ba8e/youtube_dl/extractor/youtube.py#L1814
the player_url path is not supported within youtube-dl, this regex needs an update
https://github.com/rg3/youtube-dl/blob/2511eee215c2a66020ae927c86face826f48ba8e/youtube_dl/extractor/youtube.py#L1827
supported player_url
/yts/jsbin/player-vfluiJ5_w/en_US/base.js

not supported player_url (there might be more)
/yts/jsbin/player_ias_remote_ux-vfltTlFCE/en_US/base.js
/yts/jsbin/player_ias-vflsBa1u2/en_US/base.js

more urls
https://github.com/rg3/youtube-dl/issues?utf8=✓&q=is%3Aissue+player_ias

@back-to
Thanks for the detailed reply.
What is the impact of players being different/unsupported?


vertical: add summary of by levels at top of report [5]

Complete list of all combinations of the by variables and count of obs within each level. Could run into width issues if lots of variables are specified. Might need to go landscape for this first page and then flip back to portrait for subsequent pages.

priority = 5/10

added to branch 'enhancements', not yet in 'master'

Added to v0.12


Endpoint for 'remove email address from spam'

Documentation
Adding the endpoint that lets one remove a list of email addresses from Braze's spam list.

Thanks @brrusselburg this looks legit but wasn't built on CircleCI due to #35 - I hope to address that and then maybe we can trigger this PR to build with a rebase? Will report back soon!

Hey @brrusselburg can you rebase on latest main branch - that should cause CircleCI to build and verify this work. Thanks!

Hey @brrusselburg I wanted to call out that you can run bundle exec rake on your local machine to simulate the CircleCI behavior. It'll first run standardrb and then rspec. I think you'll find that there are standardrb violations here and I think those can be fixed with bundle exec standardrb --fix. Hope that helps!!

Hey @brrusselburg I wanted to call out that you can run bundle exec rake on your local machine to simulate the CircleCI behavior. It'll first run standardrb and then rspec. I think you'll find that there are standardrb violations here and I think those can be fixed with bundle exec standardrb --fix. Hope that helps!!

Thank you! That helped with most of the lint issues. It looks like Circle CI is still not happy? When I run locally it's passing.

Hi again @brrusselburg I took the liberty of cloning down your work, fixing the violations, rebasing and pushing to this PR - hope that's ok! It's back to green so I'm going to merge and cut a release with this work. Thanks again for contributing!! 🎉 🏆

Hi again @brrusselburg I took the liberty of cloning down your work, fixing the violations, rebasing and pushing to this PR - hope that's ok! It's back to green so I'm going to merge and cut a release with this work. Thanks again for contributing!! 🎉 🏆

Absolutely fine, thanks a ton!


Reorganize the second dispatch module

This should be about dealing with values of fields, since the logic of dispatch based on types combinations was in the rock paper scissors example - a good example for this is to create a niche model of food web?

Done with the fox/hare example


picture: paint and surface reloading separation

I'd rather use https://github.com/thorvg/thorvg/pull/1338
For svg files without any viewbox and widht/height
information it has to be ensured, that the loading
process is finished before any api like size/viewbox/bounds
is called.

solved in #1338


Requests slow over time

Description
Hi! I first of all want to say that I really appreciate you for making this code and letting us use it. I am running on windows and am having a problem however, the lookups start at a frequent pace but after about 20 or so they start to slow down dramatically, eventually taking 30 seconds to a minute for every search, and repeats when the program is terminated and started again. When I was manually refreshing the site on launch day after about 15 minutes it kicked me off and I had to restart my browser. That could be something similar to what's happening.
Possible solution
Forgive me for being naïve, but would it be possible to make another instance after too much lag, or is this a setting I can change? Again I want to thank you again for making this, and I completely understand that this is your free time.

What is in your STORES= in your .env?

it is currently not set, it only searches the nvidia store by default I assumed. Will changing this fix the issue?

Nvidia site is being very slow.  If you only want to search Nvidia I'd change to nvidia-api until the website stops being so non-responsive/slow.

Thank you! I'll give it a try

Nvidia site is being very slow.  If you only want to search Nvidia only I'd change to nvidia-api until the website stops being so non-responsive/slow.

Will using the Nvidia-api still have the auto add to cart feature or just open the browser and take you to page?


dex example timeout in CI

recently dex waffle example kept getting timeout in CI, looks like it happens after we upgraded to latest mandala #470

this is likely due to the limited resources in github machine, but oddly it doesn't happen before

runner@fv-az241-328:~/work/bodhi.js/bodhi.js$ docker logs -f 67e7b84212db
yarn run v1.22.19
$ export NODE_ENV=test && mocha -r ts-node/register/transpile-only --timeout 50000 --no-warnings test/**/*.test.{js,ts}

  ------------------------------------------
  ⚡ running in production (standard) mode ⚡
  ------------------------------------------

test provider connected to ws://mandala-node:9944

  Dex
2022-06-17 09:28:49        API/INIT: RPC methods not decorated: evm_blockLimits
    1) "before all" hook for "getLiquidityPool works"

  0 passing (50s)
  1 failing

  1) Dex
       "before all" hook for "getLiquidityPool works":
     Error: Timeout of 50000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (/app/examples/waffle/dex/test/Dex.test.ts)
      at listOnTimeout (node:internal/timers:559:17)
      at processTimers (node:internal/timers:502:7)

error Command failed with exit code 1.

using own runner solves it


TaxonomyPicker + Select Term Panel does not support RTL mode

Category
[ X ] Bug
Version
2.9.0
Expected
When using Arabic Site and TaxonomyPicker RTL mode for Suggestions and Select Term panel should work.
Steps to Reproduce
Just use Taxonomy picker on Arabic site
Screenshot of Select term in Arabic site (broken tree - wrong paddings and margins + Save cancel buttons should have margin between):

Screenshot of suggestions in Arabic site (should be at right side):

I suppose TaxonomyPicker.module.scss should have additional lines. I tried next to fix this (probably need more):

'termSuggestion'
 html[dir='rtl'] .termSuggestion { text-align: right; }
'termset'
html[dir='rtl'] .termset { margin-left: 0; margin-right: 15px; }
'listItem'
html[dir='rtl'] .listItem img { margin-right: 0px;  margin-left: 5px; }
4)'termEnabled', 'termDisabled', 'termNoTagging '
html[dir='rtl'] .termEnabled,  html[dir='rtl'] .termDisabled,  html[dir='rtl'] .termNoTagging{ background-position: calc(100% - 30px); }
'term label>span'
html[dir='rtl'] .term label>span { padding-left: 0; padding-right: 25px; }

Also Term.js script file contains next lines:
var styleProps = {
            marginLeft: (this.props.term.PathDepth * 30) + "px"
        }

This should be changed to check if RTL used and set marginRight instead.
And one more point - Cancel and Save buttons - it should have margin between
Thanks!
Vladyslav

@VladNS90 You should probably look into upgrading to v3 of the controls since v2 soon will be deprecated. In v3 you will soon find the ModernTaxonomyPicker (should be available in the beta version already) and I just made a PR with some small changes that should make it work with RTL mode (#1041). The ModernTaxonomyPicker is not yet a full feature replacement for TaxonomyPicker but if you dont use any of the special features and just want a regular taxonomy picker you should be fine. Read more about the features here: #1014

@VladNS90 - unfortunately v2 is deprecated. We do not maintain it anymore.
I totally understand the issue you're experiencing, but the only way to fix it from library standpoint is to upgrade to v3 and use Modern Taxonomy Picker.


Feature Request: Calendar View Filtering

I am missing the ability to filter out completed tasks/events. This is particularly true for the Calendar View, for which each day says something like "14 more" for the current day, which when I click them, I see half of them are tasks which I have already marked as finished (they are crossed out).
This same issue plagues my side-bar view of tasks, which I recently discovered and is a great feature. However, there I am also facing clutter from finished tasks. I can somewhat filter in the Review tab, by status, but this page is not as useful for me, since I wish to look at a visual version of the tasks I've written, not a list format. A check box or something to filter out completed tasks would be perfect.
I've included some example images, in the case that they help.
Below is a screenshot of the Calendar View of the Agenda page, demonstrating a bunch of tasks "14 more", but also showing that some of these are already completed. I cannot find a setting to prevent this.

Below is a show of the sidebar, generated using the {{renderer agenda, task-list}} code.

Thank you for any help,

Thanks for your feedback, I will add this feature in the next version.

Agenda3 has a brand new calendar, you can give it a try.


docs: fix some link errors

Pre-Checklist
Note: please complete ALL items in the following checklist.

[x] I have read through the CONTRIBUTING.md documentation.
[x] My code has the necessary comments and documentation (if needed).
[ ] I have added relevant tests

Description
Please see #656 for more information.
Related Issues
close #656

If we we want to ref core-concepts.md in verfiy.md:

After test, there are three availiable ways:

relative path: ../../core-concepts/core-concepts. It seems that mkdocs regard each file as a page(dir), so we need ../../ instead of ../
absolute path: /core-concepts/core-concepts. (with the docs directory as the root directory)
using md: ../core-concepts/core-concepts.md (this is relative path, absolute path is similar).

I prefer the second one.
This comment can be used as a reference for future document reference changes. @daniel-hutao

If we we want to ref core-concepts.md in verfiy.md:

After test, there are three availiable ways:

relative path: ../../core-concepts/core-concepts. It seems that mkdocs regard each file as a page(dir), so we need ../../ instead of ../
absolute path: /core-concepts/core-concepts. (with the docs directory as the root directory)
using md: ../core-concepts/core-concepts.md (this is relative path, absolute path is similar).

I prefer the second one.
This comment can be used as a reference for future document reference changes. @daniel-hutao

But the third way is supported to read in local with markdown reader.

If we we want to ref core-concepts.md in verfiy.md:

After test, there are three availiable ways:

relative path: ../../core-concepts/core-concepts. It seems that mkdocs regard each file as a page(dir), so we need ../../ instead of ../
absolute path: /core-concepts/core-concepts. (with the docs directory as the root directory)
using md: ../core-concepts/core-concepts.md (this is relative path, absolute path is similar).

I prefer the second one. But the third way is supported to read in local with markdown reader.
This comment can be used as a reference for future document reference changes.

I need your opinion, @daniel-hutao

@aFlyBird0 I agree with your choice, 2 is better.

I switch style of all links except plugins dir into way 2. And I haved checked each edited links in local. Please Review @daniel-hutao


Node js error at startup: 'Cannot read property 'close' of undefined'

Hi Daniel,
Some people, including me,  are experiencing the issue below. I've tried te restart and resinstall the addon on hassio but without luck. Can you take a look at this?
p.s.: The edge version has the same error.
HA: 0.86.3
add-on: 1.1.0
@danielwelch
I'm getting this error now:
zigbee2mqtt:info 2019-1-31 06:14:03 Error while starting zigbee-shepherd, attemping to fix... (takes 60 seconds)
/zigbee2mqtt-1.1.0/node_modules/q/q.js:155
                throw e;
                ^
TypeError: Cannot read property 'close' of undefined
    at shepherd.start (/zigbee2mqtt-1.1.0/lib/zigbee.js:45:47)
    at /zigbee2mqtt-1.1.0/node_modules/q/q.js:2059:17
    at runSingle (/zigbee2mqtt-1.1.0/node_modules/q/q.js:137:13)
    at flush (/zigbee2mqtt-1.1.0/node_modules/q/q.js:125:13)
    at _combinedTickCallback (internal/process/next_tick.js:132:7)
    at process._tickCallback (internal/process/next_tick.js:181:9)```

_Originally posted by @noxhirsch in https://github.com/danielwelch/hassio-zigbee2mqtt/issues/95#issuecomment-459218637_

Can you try with version v<IP_ADDRESS>? It's just been pushed to Docker hub

Is there a way to make this happen via hass.io UI? Or need to ssh in and run some docker commands?

I just mean updating via the normal UI process

Patiently waiting for it to show up. Thanks for the quick patch.

Just updated, but same result.

same failure here

May have to turn to @Koenkk for some help here. Seems like an error starting zigbee-shepherd, and then it throws shen attempting to handle that error here https://github.com/Koenkk/zigbee2mqtt/blob/master/lib/zigbee.js#L45

They have already addressed the problem and fixed it in the dev-branche:
https://github.com/Koenkk/zigbee2mqtt/issues/971

Tested the work around without luck 🤕 ... @danielwelch Maybe you can create a edge release from the dev-branche of @Koenkk  I don't know if that's possible?

Ah, well the edge version of the add-on uses the dev branch so if that’s the case, should be good to go with the edge version

Oke, does the Instagram checkout the latest git branche? Cool!

Indeed not an hassio addon issue & should be fixed in -edge.

I've installed the edge-version. removed and reconnected the device. A different error. Because i can't figure out if it's a add-on related issue or an issue in the original code I place it here:
><EMAIL_ADDRESS>start /app
> node index.js
		Zigbee2mqtt requires node version 10, you are running v8.14.0!
  zigbee2mqtt:info 2019-2-1 19:39:47 Logging to directory: '/share/zigbee2mqtt/log/2019-02-01.19-39-47'
  zigbee2mqtt:info 2019-2-1 19:39:48 Starting zigbee2mqtt version 1.1.0 (commit #dd8ee60)
  zigbee2mqtt:info 2019-2-1 19:39:48 Starting zigbee-shepherd
  zigbee2mqtt:info 2019-2-1 19:39:51 Error while starting zigbee-shepherd, attemping to fix... (takes 60 seconds)
  zigbee2mqtt:info 2019-2-1 19:40:51 Starting zigbee-shepherd
  zigbee2mqtt:error 2019-2-1 19:40:54 Error while starting zigbee-shepherd!
  zigbee2mqtt:error 2019-2-1 19:40:54 Press the reset button on the stick (the one closest to the USB) and start again
  zigbee2mqtt:error 2019-2-1 19:40:54 Failed to start
	{"message":"request timeout","stack":"Error: request timeout\n    at CcZnp.<anonymous> (/app/node_modules/cc-znp/lib/ccznp.js:255:22)\n    at Object.onceWrapper (events.js:315:30)\n    at emitOne (events.js:116:13)\n    at CcZnp.emit (events.js:211:7)\n    at Timeout.<anonymous> (/app/node_modules/cc-znp/lib/ccznp.js:234:18)\n    at ontimeout (timers.js:498:11)\n    at tryOnTimeout (timers.js:323:5)\n    at Timer.listOnTimeout (timers.js:290:5)"}

stop zigbee2mqtt
re-plug stick
press reset button on the stick (the one close to the usb port), green light should go off
start zigbee2mqtt

stop zigbee2mqtt
re-plug stick
press reset button on the stick (the one close to the usb port), green light should go off
start zigbee2mqtt

Did that, now again, just to be sure. Gives me the same result.

I upgraded via the Hass.io UI and now it wont start and my config is reset to default :-(
`><EMAIL_ADDRESS>start /zigbee2mqtt-1.1.0

node index.js
zigbee2mqtt:info 2019-2-1 21:25:15 Logging to directory: '/share/zigbee2mqtt/log/2019-02-01.21-25-15'
zigbee2mqtt:info 2019-2-1 21:25:16 Starting zigbee2mqtt version 1.1.0 (commit #unknown)
zigbee2mqtt:info 2019-2-1 21:25:16 Starting zigbee-shepherd
zigbee2mqtt:info 2019-2-1 21:25:16 Error while starting zigbee-shepherd, attemping to fix... (takes 60 seconds)
/zigbee2mqtt-1.1.0/node_modules/q/q.js:155
throw e;
^
TypeError: Cannot read property 'close' of undefined
at shepherd.start (/zigbee2mqtt-1.1.0/lib/zigbee.js:45:47)
at /zigbee2mqtt-1.1.0/node_modules/q/q.js:2059:17
at runSingle (/zigbee2mqtt-1.1.0/node_modules/q/q.js:137:13)
at flush (/zigbee2mqtt-1.1.0/node_modules/q/q.js:125:13)
at _combinedTickCallback (internal/process/next_tick.js:132:7)
at process._tickCallback (internal/process/next_tick.js:181:9)
npm

ERR!`

I restored to a snapshot that was working

The edge version finally works for me. After the fix for the 'close' issue, the combination with my  zigbee usb stick wasn't successful. I managed to fix that.

I am experiencing the same issue. My zigbee devices are no longer changing their state (they are detected). I don't want to switch to the edge version as it is more work. What can I do? Do I need to do anything after updating to 1.1.1?

Just had setup this up yesterday and was enjoying home automation until the Android HomeAssistant app glitched out on the brightness of a Phillips Hue bulb and now after restarting zigbee2mqtt, I get the close error.
Log error:
 zigbee2mqtt:info 2019-2-3 17:27:03 Error while starting zigbee-shepherd, attemping to fix... (takes 60 seconds) /zigbee2mqtt-1.1.0/node_modules/q/q.js:155                 throw e;                 ^ TypeError: Cannot read property 'close' of undefined     at shepherd.start (/zigbee2mqtt-1.1.0/lib/zigbee.js:45:47)     at /zigbee2mqtt-1.1.0/node_modules/q/q.js:2059:17     at runSingle (/zigbee2mqtt-1.1.0/node_modules/q/q.js:137:13)     at flush (/zigbee2mqtt-1.1.0/node_modules/q/q.js:125:13)     at _combinedTickCallback (internal/process/next_tick.js:132:7)     at process._tickCallback (internal/process/next_tick.js:181:9) npm  ERR!  code ELIFECYCLE npm ERR!  errno 1 npm  ERR<EMAIL_ADDRESS>start:node index.js npm  ERR! Exit status 1 npm ERR!  npm ERR! Failed at the<EMAIL_ADDRESS>start script. npm  ERR! This is probably not a problem with npm. There is likely additional logging output above. npm ERR!  A complete log of this run can be found in: npm ERR!     /root/.npm/_logs/2019-02-03T17_27_03_316Z-debug.log 2019-02-03T17:27:04: PM2 log: App [npm:0] exited with code [1] via signal [SIGINT] 2019-02-03T17:27:04: PM2 log: App [npm:0] starting in -fork mode- 2019-02-03T17:27:04: PM2 log: App [npm:0] online
I currently do not have access to an Phillips dimmer, so I would be unable to reset these paired bulbs.
Just want to know if pressing the reset button on the CC2531 will loose my paired devices? Will updating to the addon loose my paired devices.

* Pressing the reset button on the CC2531 (the one closest to USB port) won't loose your paired devices

* Updating zigbee2mqtt won't loose your paired devices

* Only updating (flashing) the firmware of the CC2531 looses your paired devices.

Thanks dude, I can confirm that has fixed the issue and the bulbs and Xiaomi sensors are all paired sucessfully on the normal zigbee2mqtt <IP_ADDRESS> hass.io addon.
I will try the edge version as well to confirm that no glitches that cause the close state are present.

@DeliriousMetro 1.1.1 should already be out for hassio.

@DeliriousMetro 1.1.1 should already be out for hassio.

Still on the old one for me, so ended up using the edge one.

I'll try to reinstall it now, maybe that would trigger an update check.

@DeliriousMetro sorry, should be up in an hour.

@DeliriousMetro sorry, should be up in an hour. (will be up when https://travis-ci.org/danielwelch/hassio-zigbee2mqtt/builds/488214025?utm_source=github_status&utm_medium=notification is done)

Do not worry, I appreciate the time and work you have put into this. Especially, as a neat standalone hass.io addon. Thanks for the quick fix too, for me, resetting the usb did work on both builds so I will be fine to update whenever the build has been passed.

It worked for me again, but I have the problem now that one sensor which is a bit far away won't connect anymore. It was working previously flawlessly, but now I can't get it to send signals. It's a door sensor and I've already mounted it to the door. Anyone with an idea on how to get it to be recognized again?

I'll go ahead and close this issue since it seems things have been resolved with zigbee2mqtt version 1.1.1


Wrong word Initalizr

I found the word  on line 111 in README.adoc.
The Initalizr creates a class with a `main()` method. The following listing shows the
class the Initializr creates (at
`src/main/java/com/example/consumingrest/ConsumingRestApplication.java`):

Can you fix initalizr to initialzr

Good catch. I'm going to leave it rather than fix it, though, as a good first issue for someone to take as their first contribution to Spring (a risk-free way to get started, basically). I have added the corresponding label.

Fixed by https://github.com/spring-guides/gs-consuming-rest/pull/55


StrongBox crashes immediately

Bug Description
Today I have updated to the newest version of strongbox (1.48.13), but I cannot use it at all, the software crashes immediately after I launch it, and tried several times and restart my iphone, doesn't work. My phone is iphone 11 pro, IOS version is 13.5.1.

Hi,
You've posted this issue to the wrong project. I assume you're referring to the strongbox-password-safe/Strongbox project. I'm therefore closing this bug report.
Kind regards,
Martin


Event building code fix for OOTB reports with db EventStream/PolicyEvent

Need to skip building grouping of events in timeline for OOTB reports with db as EventStream/PolicyEvent. Events in these reports are not based on categories, all events in such reports are shown in one single group.
https://bugzilla.redhat.com/show_bug.cgi?id=1394316
@dclarizio please review, you can import attached report to recreate/test the fix.
Reports_20161111_182327.yaml.zip
before:

after:

Euwe Backport details:
$ git log -1
commit 6b459d2c1547aca6c3a3c2f779c00884070f311c
Author: Dan Clarizio<EMAIL_ADDRESS>Date:   Fri Nov 11 16:04:03 2016 -0800

    Merge pull request #12593 from h-kataria/timeline_fix_for_ootb_reports

    Event building code fix for OOTB reports with db EventStream/PolicyEvent
    (cherry picked from commit 7eb22b956d2d086a806fd30c78a6949c81111deb)

    https://bugzilla.redhat.com/show_bug.cgi?id=1394316


Sensors sensor.byd_charge_total_energy and sensor.byd_discharge_total_energy does show unaccurate values

Sensors sensor.byd_charge_total_energy and sensor.byd_discharge_total_energy does show unaccurate values.
In comparison with the BYD Logger App which shows:

Do we know why this difference exists?
        charge_lfte = self._client.convert_from_registers(regs[17:19], data_type = self._client.DATATYPE.UINT32) * 0.001
        discharge_lfte = self._client.convert_from_registers(regs[19:21], data_type = self._client.DATATYPE.UINT32) * 0.001

It is interesting, that the efficiency is exactly the same with 91.7%. So may we have to calculate something with this Modbus values?
Btw.: Should we default to kWh instead of Wh?
Edit:
Tried some troubleshooting. As I've no coding skills I tried to find out, what Olli's tool is doing over the network. So I dumped the communication between BYD Logger and the BYD Battery. The communication protocol is modbus rtu over tcp.
If I understand it right, then the tool does this request:

Then answer has then a lot of regsiters while one is showing the values which correlate with the total charged/discharged:

I'm not Modbus expert and just trying to reverse engineer what is happening. May I'm completely wrong.
There is also an other modbus query which gets an answer that is looking like the voltage of each battery cell.

Issue was caused that the values were converted use Big Endian bytes instead of Little Endian bytes. Fix is done in dev, will be going out in next release.

You're great! Possible to buy/donate you somewhere a coffee?

Thanks for the coffee! You already found the link before I could post it here. Really appreciate it!

Released


Can't login on firefox

Accessing http://localhost:8081/app/ on firefox asks for a username and password and i can't find where the credentials are.

Never mind, i figured it out. the commandline prints out a url with credentials tagged on.


Gzip support, and a couple of new kwargs

Codecov Report
Attention: Patch coverage is 82.14286% with 5 lines in your changes missing coverage. Please review.

Project coverage is 81.14%. Comparing base (8a996d9) to head (277a7d5).

Files
Patch %
Lines

mw2fcitx/fetch.py
76.19%
5 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #27      +/-   ##
==========================================
+ Coverage   77.43%   81.14%   +3.70%
==========================================
  Files          18       18
  Lines         523      488      -35
  Branches       84       76       -8
==========================================
- Hits          405      396       -9
+ Misses         94       71      -23
+ Partials       24       21       -3

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


passwordA in plaintext in log file

Security issue??
The password is in raspiblitz.setup.log

At which point? Can you give more information? If its about passwordB - that is stored in the lnd/bitcoin configs anyway. Passwotd C only if user activates LND-auto-unlock. Bit PasswordA should never be stored on disk or in any logs.

Thanks for the report - good catch. I think I found it - it was a left over from an debug output while refactoring the setup process for the 1.7.1 - it not super critical, but good to have that out of the system for v1.7.2

OK this fix will be part of v1.7.2 release. Closing issue.


Proposal: Use integers for FontStyle

Currently, FontStyle is represented as a (possibly packed after #5) struct of bools.
I think using integer types and bitwise operations, we could achieve better and possibly faster functionality. Consider the following simplified example:
const FontStyle = u3;

const default: FontStyle = 0b000;
const bold: FontStyle = 0b001;
const dim: FontStyle = 0b010;
const italic: FontStyle = 0b100;

Combining font styles can be done with bitwise or; checking for a style can be done with bitwise and.
cc @data-man

I think bitwise operations will decrease output's performance.

@data-man That may be right for checking a specific field of the FontStyle, i.e. checking whether font_style.bold == true. When using integers, we have an additional overhead of one bitwise operation in addition to the comparison.
But for other purposes, this has increased performance:

checking if multiple fields are set
checking for equality (includes checking isDefault)
checking if a given font style has at least the attributes of another font style (no attributes were removed)

All operations are turned into O(1) operations instead of O(n) where n is the number of fields.

When using integers, we have an additional overhead of one bitwise operation in addition to the comparison.

And for convenience, some helpers will be needed: isBold/setBold, etc.

@data-man Yes, that would aid the usability of FontStyle if it would be represented as an integer. But those will be small functions which will be almost-surely inlined in a release build, so the overhead of an additional function call won't be there, only the overhead of the bitwise operation then.
I'll leave this proposal open until some benchmarks have been integrated into the library. From then on, we can test the performance of checking attributes/setting attributes/checking equality/subset of attributes/etc. And from these results, we can then proceed to select the appropriate representation of FontStyle

@joachimschmidt557
I think helpers for RGB type are more important. Maybe in new module.
Rust's rgb24 as example.

@data-man If you want, feel free to implement that.

pub const FontStyle = packed struct {
...
const Self = @This();
...
pub fn asUInt(self: Self) u11 {
    return @bitCast(u11, self);
}
...

?


Write tests for src/syft-model.js

Description
src/syft-model.js
Type of Test

[x] Unit test (e.g. checking a loop, method, or function is working as intended)
[ ] Integration test (e.g. checking if a certain group or set of functionality is working as intended)
[ ] Regression test (e.g. checking if by adding or removing a module of code allows other systems to continue to function as intended)
[ ] Stress test (e.g. checking to see how well a system performs under various situations, including heavy usage)
[ ] Performance test (e.g. checking to see how efficient a system is as performing the intended task)
[ ] Other

Expected Behavior
We expect this file to be covered completely by tests. It's not intended to test feature-related functionality but is instead intended to test the file in isolation.
Additional Context
None

hey can I work on this ?

Absolutely @bicycleman15 ! Feel free to give us an update once you’ve got a PR. 😊

@bicycleman15 Hey Jatin, I've made some edits to the documentation for this file. Any progress on the unit tests from your end?

He's gone @nahuakang - you should work on this yourself.


Invalid attribute error when combined with thiserror

Describe the bug
Combining the derive macros derivative::Derivative and thiserror::Error seems to break arbitrary debug expressions in thiserror.
To Reproduce
use {derivative::Derivative, std::fmt::Debug, thiserror::Error as ThisError};

trait NonDebugTrait {
    type DebugAssociatedType: Debug;
}

#[derive(ThisError, Derivative)]
#[derivative(Debug(bound = "T: NonDebugTrait"))]
enum ThatError<T: NonDebugTrait> {
    #[error("error {:?}", .0)]
    Variant(T::DebugAssociatedType),
}

fn main() {
    println!("Hello, world!");
}

Expected behavior
Successful compilation.
Errors
error: invalid attribute: expected identifier or literal
  --> src/main.rs:10:27
   |
10 |     #[error("error {:?}", .0)]
   |                           ^

Version (please complete the following information):
rustup --version # n/a
cargo --version # cargo 1.49.0-nightly (2af662e22 2020-11-12)
rustc --version # rustc 1.50.0-nightly (603ab5bd6 2020-11-15)

Version of derivative: 2.1.1

Additional context
I originally reported this at https://github.com/dtolnay/thiserror/issues/111, but @dtolnay indicated this was a problem with rust-derivative, not thiserror.

Fixed in #79 and released as v2.1.2 just now.

Fixed in #79 and released as v2.1.2 just now.


refactor: depreacate SSLCertificates and update docs

Affected Components

[ ] New Features
[ ] Bug Fixing
[ ] Types
[ ] Tests
[x] Docs
[ ] Other

Style

[x] Go code is formatted with go fmt

Notes for the Reviewer

Deprecate SSLCertificates property/struct, update docs and test cases

Resolves #70

Moved to https://github.com/checkly/checkly-go-sdk/pull/76


Update janitza-gridvis to 3.1.3

Please update my adapter ioBroker.janitza-gridvis to version 3.1.3.
This pull request was created by https://www.iobroker.dev c0726ff.

3.1.3 created 11.10.2023
7 nuser (8%)
OK


Sync from release-1.22 to release-1.22-bp

This pulls the latest changes from release-1.22 into release-1.22-bp.

test


The map is 4 times smaller than it should be and cannot be enlarged.

Version: v2.5.3
I'm sending a video where it's most clear what I mean.
https://user-images.githubusercontent.com/62265168/123537866-08bef100-d732-11eb-9045-a055f2d09291.mp4

It looks like the OpenGL viewport is set when the app is not yet maximized/fullscreen.
Could you please try this fix?
https://alien-project.org/files/alien_bugfix.zip
Does it solve this issue?

It looks like the OpenGL viewport is set before the app is maximized/fullscreen.
Could you please try this fix?
https://alien-project.org/files/alien_bugfix.zip
Does it solve this issue?

Unfortunately, it didn't work out. Still the same. :(

If you zoom more than 32x, then the editor mode should pop up automatically.
Do you then see the world in the correct size?
If so, then when you zoom out, does it stay at the correct size?

If you zoom more than 32x, then the editor mode should pop up automatically.
Do you then see the world in the correct size?
If so, then when you zoom out, does it stay at the correct size?

Yes. When I get into that 2 mode, where it's very close and I see the numbers of each cell, it's in normal size.

Ok, and when you then zoom out?

Ok, and when you then zoom out?

That's what happens in the video. It's 4 times smaller.

I've prepared a special version again under https://alien-project.org/files/alien_bugfix.zip with 2 changes:

it opens a console beside the app
I simply doubled the width and height of the viewport (just for testing)

Could you please start and end the program and send me the content of the console? (the console should be visible after closing)
Is the map shown normally?
Thanks!

I've prepared a special version again under https://alien-project.org/files/alien_bugfix.zip with 2 changes:

it opens a console beside the app
I simply doubled the width and height of the viewport (just for testing)

Could you please start and end the program and send me the content of the console? (the console should be visible after closing)
Is the map shown normally?
Thanks!

It's 50 to 50, because... watch the video.
https://user-images.githubusercontent.com/62265168/123546185-db873880-d75b-11eb-97ac-97411b5dfe8e.mp4

The actual problem is not the viewport. It could be a clipping problem.
Can you please try again: https://alien-project.org/files/alien_bugfix.zip ?
A screenshot of the open program suffices.
The view should still not be correct in this version but if it look different from your initial video I might found the problem and could fix it.

We are back to the beginning ... D:
https://user-images.githubusercontent.com/62265168/123549489-936f1280-d769-11eb-937a-de4c0bd45c49.mp4

hmm.
Could it be that you are using a higher resolution than 1920x1080 (e.g. 4k) and scaling the apps in Windows by a factor of, say, 2?

I mean, have you set more than 100% in this setting?

I mean, have you set more than 100% in this setting?

Yes. I have 200%

That is the problem :) The scaling from Windows does not apply to the map view. You should switch to 100% and it should work.

That is the problem :) The scaling from Windows does not apply to the map view. You should switch to 100% and it should work.

Oh God.  I apologize for your loss of time :D. Right now I have set 1920x1080 and 100% and it works normal without bugfix v2.5.3. I apologize again.

No apology! This was new for me too. I will make a FAQ and mention it :)


Migrate terraform to terragrunt for high number of modules

I have microservice non-prod env. where each team has its own env. which means a lot of envs, in terms of terrafrom right now I have two github repos:

The first one has root tf modules.
The Second one has reusable tf modules.

The first one contains 10 root modules each one of them calls just a single module that resides in the second repo, this module in the second repo calls 13 modules, so one of the modules in the second repo represents a proxy repo.
to recap, the first repo structure:

tf-env1.tf
tf-env2.tf
tf-env3.tf
....
tf-env10.tf

The second one has a structure:

api-gateway.tf
vpc.tf
rds.tf
ec2.tf
s3.tf
lambda.tf
lb.tf
SPECIAL_Module.tf

the call chain goes as:

in repo1 : tf-envX.tf
|
in repo2 : SPECIAL_Module.tf
|
in repo2 : api-gateway.tf,vpc.tf,rds.tf,s3.tf .... etc

As part of migrating to terragrunt in order to give the developers an ability to control their env. via managing their env. variables and free up the SRE team to just writing new terraform modules.
I'm thinking of getting rid of SPECIAL_Module.tf, since it has a lot of local controls on how terraform works, but the issue is if I remove SPECIAL_Module.tf terragrunt doesn't support more than one source on each hcl file.
Another option is to create an hcl for each module from the second repo, but this means I would manage # of modules * # of envs files., so it came to my mind to group the modules in the second repo into 3 or 4 groups.
One solution I thought about is to move SPECIAL_Module.tf to the first module and include it in each env., but this means a huge single terraform file would reside inside terragrunt repo. which I'm not sure if it's an abuse for terragrunt.
So is there a way to migrate from terraform to terragrunt with a high # of modules and a high # of envs?

hi,
ideas on how to adopt Terragrunt can be collected from examples:

https://github.com/gruntwork-io/terragrunt-infrastructure-live-example
https://terragrunt.gruntwork.io/docs/features/keep-your-terraform-code-dry/

Code from SPECIAL can be referenced in dependencies
https://terragrunt.gruntwork.io/docs/reference/config-blocks-and-attributes/#dependencies

The first link is very simple example use case, in the second one the # of modules are 3 with 3 env. which is a different case.


Query translator

This may appear to be a much larger PR than it really is.
Note that all of the new files under the frontend directory are auto-generated from the Cypher.g4 grammar file.  They should not be reviewed.
Also note that the Cypher.g4 file under the tools directory is a copy of the grammar file from opencypher.org.  This should not be reviewed.
I have created a new example for this query_translator feature, but not (yet) a Jupyter notebook.  I think we should do that as a separate PR.

Should the generated files have copyright headers?

Should the generated files have copyright headers?

The probably should, but they certainly should not be our copyright headers.
The grammar file was published by opencyhper.org but with a Neo Technology copyright notice, and the antlr software generated those files from the grammar file.  It should be either copyright OpenCypher.org/Neo Technology or copyright Antlr.
I don't see a way to ask the antlr software to generate a copyright notice.  And I don't feel comfortable asserting copyright on behalf of OpenCypher.org or Neo Technology.


Sorry, this is just an exercise

Sorry, this is just an exercise

Sorry, this is just an exercise

Please exercise on your own repos, instead of spamming others'.


npm run eject fails when removing node_modules

Description
When running npm run eject everything goes well up to the point where the code removes the node_modules folder where it fails on a random module.
Expected Behavior
The script runs without issues and displays a success message (or informs me in any way that everything went well.
Observed Behavior
Randomly while removing the process fails with the error message that a folder could not be removed because it is not empty. After that there is a line telling me that a directory was not found and then there is the usual npm error block:
Error running eject: Error: ENOTEMPTY: directory not empty, rmdir 'C:\Users\Username\ReactNative\ProjectName\node_modules\lottie-react-native\src\android\build\tmp\expandedArchives\classes.jar_5gdp4bb5izj6gs3qq6f6ejit7\com\facebook\react'
System cannot find the given directory (translated from German; might be inaccurate)
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR<EMAIL_ADDRESS>eject: `react-native-scripts eject`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>eject script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR!      C:\Users\Username\AppData\Roaming\npm-cache\_logs\2018-05-26T22_22_42_547Z-debug.log

I tried to get around this by using Ctrl+C to pause execution of the script, remove the folders in node_modules by hand and then continuing the process however that seemed to crash the script, no further output was printed and I was able to put in a new command (without yarn install for example was run).
Environment
Please run these commands in the project folder and fill in their results:

npm ls react-native-scripts:

<EMAIL_ADDRESS>C:\Users\Username\ReactNative\ProjectName
`-- (empty)
(1.14.0 is installed)

npm ls react-native:

<EMAIL_ADDRESS>C:\Users\Username\ReactNative\ProjectName
`-- UNMET DEPENDENCY<EMAIL_ADDRESS>
npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! extraneous<EMAIL_ADDRESS>C:\Users\Username\ReactNative\ProjectName\node_modules\react-native

(0.55.4 is installed)

npm ls expo:

<EMAIL_ADDRESS>C:\Users\Username\ReactNative\ProjectName
`-- UNMET DEPENDENCY<EMAIL_ADDRESS>
npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>
(27.0.1 is installed)

node -v: v8.9.1
npm -v: 6.0.0
yarn --version: 1.6.0
watchman version: 4.9.1

Also specify:

Operating system: Windows 7 64-bit
Phone/emulator/simulator & version: iPhone 5S, Galaxy S5

Reproducible Demo
Create a new project, change into the directory and eject
create-react-native-app TestingNodeModulesRemoval && cd TestingNodeModuleRemoval && npm run eject
However the issue can already be seen without ejecting by just trying to remove the node_modules folder with the command rmdir /S /Q node_modules. This is also described in this stackoverflow post and appears to be a windows issue. It would be great though if some kind of workaround could be implemented so this does not randomly happen.
Running the command from an administrator prompt did not solve the issue.

Workaround: Run the command from git bash if installed. That completed the removal of node_modules without error. This might work with the WSL as well but I haven't tested that.
If there is a solution for the windows command line though, it would be much appreciated if someone could post this here :)

FYI, you actually have to add everything to git before running npm run eject. This resolved node_modules removal issue for me.

When I was testing with a small project I did not use git in that directory at all, so I doubt that was the cause (you don't need to git init in order to reproduce the problem).

Yeah, me too, but when I've initialized git and added everything - the error was gone while deleting node_modules.
It didn't help running whole npm run eject script successfully tho :/

Strange. I tried the same thing but it wouldn't work either. Anyway; using git bash instead of the windows command-line appears to get rid of that issue.

my solution: npm install -g react-native-scripts  then run react-native-scripts eject . this will do the same as npm run eject. hope it works!


Not an issue - Just help needed

Hi,
I am trying to test your tables in my react project as your component is the closest to my requirement.
I cant for the life of me get it to work though, here is my code below, maybe you can tell me if im doing something wrong. Im a newbie with react, so this could be adding to the problem but Ive tried for many hours, so please bare with me.
I have populated the test.php file with the same code from your php file and when i run it in my terminal it renders the results.
When I run this my main container div in the app is rendering nothing, not even the card.
import React from 'react';
import { Reactables, Header, editor } from 'gigatables-react';
import { Card, CardTitle} from 'reactstrap';
var settings = {
struct: {
search: ['top', 'bottom'],
rowsSelector: ['desc', 'top', 'bottom'],
pagination: ['bottom']
},
lang: 'en', // english default
perPageRows: [25, 50, 100, 200],
defaultPerPage: 100,
ajax: 'test.php',
// ajaxAutoloadData: true, // default false
// ajaxAutoloadPeriod: 8, // sec
requestType: 'GET',
columns: [
{// include all defaults
data: "id",
sortable: true, // true by defualt
visible: true, // true by defualt
searchable: true, // true by defualt
discreteSearch: true, // false by default
discreteSearchValue: function (title) {
return 'Search by field - ' + title;
}
},
{
data: "title",
cISearch: true // default false
},
{
data: "desc",
sortable: false,
discreteSearch: true,
discreteCISearch: true // default false
},
{
data: "date",
searchable: false
},
{
data: "info"
},
{data:"field1"},
{data:"field2"},
{data:"field3", visible: false}
],
columnOpts: [
{
render: (data, row, type) => (

{data}

),
target: 'title' // provide data column index to match opts
},
{
render: (data, row, type) => (

{data}
{(row.id % 2 === 0) ? '**' : '*'}

),
target: 'date'
}
],
tableOpts: {
buttons: [
{extended: "editor_create", editor: editor, triggerAfter: (function () {
console.log('after create');
}), triggerBefore: (function () {
console.log('before create');
})},
{extended: "editor_edit", editor: editor, triggerBefore: (function () {
console.log('before edit');
})},
{extended: "editor_remove", editor: editor, triggerAfter: (function () {
console.log('after del');
})}
],
buttonsPosition: ['top', 'bottom'],
theme: 'std'
}
};
export default class UserManPage extends React.Component {
render() {
return (

    <Card block>
      <CardTitle>My Table</CardTitle>
        <Reactables editor={editor} settings={settings}>
          ID
          Name
          Description
          Date
          Info
          Field123 but data from field2
          Field1
          Field3 invisible
          Field3 invisible
        </Reactables>
    </Card>

);

}
}

Hi, first of all - the import should be declared like this:
import { Reactables, Header } from 'gigatables-react'

there is no component/class like editor. There are Editor class, which is used internally.
Another thing that I can see - You hadn't declared var editor = {} object to provide it in settings
{extended: "editor_edit", editor: editor, triggerBefore: (function () {
console.log('before edit');
})},

Read about it here https://github.com/GigaTables/reactables#user-content-an-example-of-using-gigatables-with-editor-tool  - it should be declared before var settings object.
Also, may be U can see errors in React Developer Tools? Probably some warnings?

Great, thanks for that.
I have managed to make it work.
I just need two more answers from you if possible.

Are the tables not responsive?
Is it possible to fix the header and have the table data scrolling below?

Thanks

Glad that answer was helpful.

If this question means ex.: horizontal/vertical scrolling while shrink the browser window - no.
Not yet, but thoughts about an integration of this kinda functionality visited me and I think that it is rather be implemented for better UX in near future.

I`m closing this discussion with functionality for fixed header https://github.com/GigaTables/reactables/releases/tag/1.6.1
It is already build + published, so enjoy =)


run_install with --global throws permission denied

With config:
    - name: Setup pnpm
      uses<EMAIL_ADDRESS>      with:
        version: 5.17.2
        run_install: |
          - args: [--global, typescript, ts-node]

I get the following:
Run<EMAIL_ADDRESS> with:
   version: 5.17.2
   run_install: - args: [--global, typescript, ts-node]

   dest: ~/setup-pnpm
   bin_dest: ~/setup-pnpm/.bin
   registry: https://registry.npmjs.com
 env:
   DOCKER_BUILDKIT: 1
Running self-installer...
 Downloading https://registry.npmjs.org/pnpm/-/pnpm-5.17.2.tgz
Installation Completed!
Running pnpm install --global typescript ts-node...
  ERROR  EACCES: permission denied, mkdir '/usr/local/pnpm-global'

Error: Command pnpm install --global typescript ts-node (cwd: undefined) exits with status 1

I must know the cause before I fix this. Can you please try this?
    - name: Setup pnpm
      uses<EMAIL_ADDRESS>      with:
        version: 5.17.2
        run_install: false

  - run: pnpm i -g typescript ts-node

BTW, why didn't you just add typescript and ts-node to devDependencies in package.json and then use pnpx to execute tsc and ts-node?

Result from test:

BTW, why didn't you just add typescript and ts-node to devDependencies in package.json and then use pnpx to execute tsc and ts-node?

That's how I was doing it, actually. But for aesthetics' sake, I wanted to use shebangs and run my scripts directly.

This could be fixed by having pnpm choosing a different directory for global packages (ergo, pnpm/action-setup can't do anything).
You could do a workaround by running chown and chmod before pnpm/action-setup.

BTW, why didn't you just add typescript and ts-node to devDependencies in package.json and then use pnpx to execute tsc and ts-node?

That's how I was doing it, actually. But for aesthetics' sake, I wanted to use shebangs and run my scripts directly.

I guess this is because #! /usr/bin/env <command> interprets <command> as a binary name? If that is the case, you should try #! /usr/bin/env -S <command>.

Beautiful. #!/usr/bin/env -S pnpx ts-node-transpile-only works and is way better since I don't have to worry about either risking installing typescript twice or keeping my project's version and pnpm i -g typescript@version synced.
Thanks!

Be aware that -S is a GNU extension, it does not work on macOS, BSD, or any pure POSIX implementation.

(ergo, pnpm/action-setup can't do anything).
You could do a workaround by running chown and chmod before pnpm/action-setup.

Maybe that should be mentioned in the readme. In any case, feel free to close the issue.

Another thing, instead of relying on -S and pnpx, you can just add $(pwd)/node_modules/.bin to PATH, it would enable you to do just this:
#! /usr/bin/env ts-node-transpile-only

Excellent point.

In case you aren't aware, this is how you add a path in GitHub Workflow.


[AMBARI-24445] [Log Search UI] exclude mock data from production build

(cherry picked from commit ea95b8353ac07f4c6897ba4b7b31513ad23bd13d)
What changes were proposed in this pull request?
Removing the mock data from the application. So that from now in order to develop you'll need to have a Log Search server set up and set the Webpack Dev Server proxy. See README.md
How was this patch tested?
It was tested manually and by running unit tests:
PhantomJS 2.1.1 (Mac OS X 0.0.0): Executed 268 of 268 SUCCESS (10.885 secs / 10.718 secs)
Please review Ambari Contributing Guide before opening a pull request.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/3547/
Test PASSed.


Build fixes.

Needed for import.
Not to be merged until the build moratorium is over.

Nico, perhaps you can review this, since Yang is out sick?

@nicolasnoble tells me that this is no longer needed.


Added buttons that hides and shows the sidebar

Looks good, testing it locally now

Works now everything looks good


Allow executable

@millerdev @javierwilson was debugging why formplayer wasn't working on swiss. it turns it out it couldn't download the application because when it'd attempt to, the nginx worker (user www-data) didn't have permissions to open the file. you cannot read a file unless you have access to the dir, so i figured that was the intent of the permissions already

this isn't an issue on prod because the nfs has different user:group owners


Multiple events being registered with the same API timestamp and in weird order...

Hi,
We have decided to integrate Mixpanel recently (1.6.0). Initially, it had been looking very promising but then we noticed that flows often don't make sense. And by that I mean i.e same event being triggered more than once or in an order which is not possible in the app's flow. I started to investigate it and after ruling out that the app itself triggers them incorrectly I began to analyse random user sessions in your dashboard. It looks like often there is a series of event with exactly the same API timestamp being assigned to it. Events that in the real app can not be triggered at once but are seconds or more away from each other.
Could you please explain how it is possible that events can share the same API timestamp? How is it possible that the order looks random?
If that's a bug when we can expect it to be fixed?
Thank you in advance for your reply

.

Hey Mixpanel team,
We are having the same issue. Do you have any update on it? Or maybe some workaround?

Hey Mixpanel team,
We are having the same issue.


Media query is sorted wrong

In a StyleSheet.InlineI have
val xs = media.minWidth(0.px)
val sm = media.minWidth(576.px) // Small devices (landscape phones, 576px and up)
val md = media.minWidth(768.px) // Medium devices (tablets, 768px and up)
val lg = media.minWidth(992.px) // Large devices (desktops, 992px and up)
val xl = media.minWidth(1200.px) // Extra large devices (large desktops, 1200px and up)
...

Everything works fine and very responsive until I get to xl
After debugging I can see the order is sorted wrong
@media (min-width:0) {...}
@media (min-width:1200px) {...}
@media (min-width:576px {...}
@media (min-width:768px) {...}
@media (min-width:992px) {...}

@japgolly Can you point me in the right direction
Can we fix it here or is not related?
https://github.com/japgolly/scalacss/blob/master/core/shared/src/main/scala/scalacss/internal/Cond.scala#L57

Oh my, I completely forgot to respond to this, I'm so sorry @FabioPinheiro . Yes I believe that's exactly the place to fix it. I'd also recommend adding your exact example as a test case to InlineTest.scala.

Now is I who is sorry for not replying. The last couple of months was not easy for me.
But now I'm 100% invested in trying to transform my pet project into job.
I want to see this fixed. I think there are more ordering problems when I use the media query in multiple places.


change merge to deepCopy in Session.prototype.begin() to create a new…

… instance of the session policy object.
using _.merge only references the existing policy object, which means the global policy object gets modified instead of an instance specific to the session later in the code.
changing it to u.deepCopy makes sure the session gets its own instance.

fixed in 2cb0797f58ddd0f6e1e6be6535a19aeae19def0b, thanks again for the report and fix!


Engine compilation configuration editor: add new categories

Planned categories:

[X] Networking
[X] Image formats
[ ] Audio farmats/libs

ogg
vorbis
theora
...

[ ] Texture compression formats

astcenc
cvtt
...

[ ] Linux dispaly server protocols

Additional ideas:

[ ] Update general category to include metal, d3d12.
[ ] Update general category to include noise, mono, alsa, pulseaudio, dbus,
[ ] Maybe extract additional category "rendering backend"
[ ] Add category 3d

csg
mesh optimizer
vhacd
gltf

Ideas which are most likely not for this PR (I just need to write it somewhere to not forget or maybe someone will tell something about...):

[x] There exist disable_3d option which automatically disables all 3d modules at once. It looks like disable_xr option would fit to disable all XR modules (webxr, mobile_vr, openxr) at once
[ ] Find a way to pass data from /modules/<module_name>/config.py to the menu

Doesn't show the nodes in the most bottom menu if it is was disabled but disabling its module
Reflect dependencies of can_build function inside the editor for example disable_3d or hypothetical disable_xr...

Hmm... JSON-RPC can be used even inside the same process. Someone could use it for command pattern.  Should it be considered as a part of networking category?

PNG is a driver not module 0_o

It seem that there is no way to know if module is enabled or disabled at run time, only in compile time with defines MODULE_NAME_ENABLED. Maybe there could be used workaround with feature flags OS.has_feature()


App Bar and... Edge

Again me and Microsoft browsers ^^
When collapsed mode wih EDGE (not tested with IE), each line of menu is bigger as waiting :

Same bug in IE11. At the moment I do not have a solution :(

Fixed

You're the best ;-)
Many thanx for your reactivity.
Surely made others issues : I'm testing different menu for a site...


fix(docs): tweak decorator in resolver reference

Description
Small tweak to point decorator correctly
Types of Changes

[ ] Core
[ ] Bugfix
[ ] New feature
[ ] Enhancement/optimization
[x] Documentation

Issues Fixed or Closed by This PR
N/A
Checklist

[x] My code follows the code style of this project.
[x] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x] I have added tests to cover my changes.
[x] I have tested the changes and verified that they work and don't break anything (as well as I can manage).

ignore. I think strawberry_django is the correct decorator 🤔


Test with different versions of sqlalchemy and address a deprecation warning

fixes #671

Draft PRs don't trigger build apparently, so let's trigger a build.

Tested on Python 3.7 with sqlalchemy 1.3.0.
Works for me! Please merge. 👍

You're adding way too many test envs here.

You're doubling the number of envs to cover one changed line.

for travis do you mean ?
If I don't do it only one version of sqlalchemy gets tested
https://travis-ci.org/pallets/flask-sqlalchemy/jobs/502480830

You need one extra env here, not 5.

ok I'll see what I can do, thanks.

sorry @davidism I don't know how to make the travis matrix simpler
Could you point me to some example maybe ?
tox -l
py36-sqla1.2
py36-sqla1.3
py35-sqla1.2
py35-sqla1.3
py34-sqla1.2
py34-sqla1.3
py27-sqla1.2
py27-sqla1.3
pypy-sqla1.2
pypy-sqla1.3
py36-lowest
py34-lowest
py27-lowest
pypy-lowest
docs_html
coverage_report

Just don't add most of the things you added?

you need to be more specific, you don't want I touch the travis.yaml file ? the tox.ini file ? both ?

Side note: that's not a sane way of communication to edit you previous comments, because we don't get notified about the change and we appear to be dumb of asking an obvious question, which was not the case at the time it was written.
So, let's play the guessing game, because there is many ways to interpret your directions. Would you like to see in the travis matrix only those two combinations added ?
py36-sqla1.2
py36-sqla1.3

And for the rest of python versions we don't care which version of sqlalchemy is picked ?
Please confirm.
Thanks

seems to me the question is, since the change calls for testing against multiple versions of SQLA, what combination of python versions and SQLA versions gets you the appropriate coverage without making CI too heavy? Do you want to test all python versions against SQLA<=1.3, and only 3.7 against SQLA>1.3? All python versions against the newer SQLA and only 3.7 against SQLA<=1.3? Or should it be only python versions supported by the specific SQLA version? (I suspect that would still be a much larger matrix.) Regardless it seems like a decision for the maintainer.

@jpassaro totally makes sense, I'm up for it, I just wish to receive clear directions, because obviously I'm very bad at guessing.

@davidism please can you have another look ?

Thanks for getting us started on this.
https://github.com/pallets/flask-sqlalchemy/pull/687 will address testing different SA versions
There is a commit in https://github.com/pallets/flask-sqlalchemy/pull/684 that will address the deprecation warning.


helmfile v0.147 does not work with helm v3.5.4 and "helm diff" plugin v3.1.3

Operating system
Ubuntu 20.04 LTS
Helmfile Version
0.145.0 (0.147.0 fails with the same error)
Helm Version
3.5.4
Bug description
helmfile diff operation fails because of a cmdline flag (--colors) passed to what looks like an older version of helm diff plugin.
$ helm plugin list | grep diff
diff   	3.1.3    	Preview helm upgrade changes as a diff

The documentation states that helm diff versions down to v2.9.0+1 should be supported, hence the bug report. Judging by the error message, the older plugin has --no-colors parameter instead.

Example helmfile.yaml
helmfile doesn't seem to matter as it is a problem with invocation of an underlying helm command
Error message you've seen (if any)
PATH:
  /home/immerrr/.local/bin/helm

ARGS:
  0: helm (4 bytes)
  1: --kube-context (14 bytes)
  2: <snip> (43 bytes)
  3: diff (4 bytes)
  4: upgrade (7 bytes)
  5: --allow-unreleased (18 bytes)
  6: ingress-nginx (13 bytes)
  7: ingress-nginx/ingress-nginx (27 bytes)
  8: --version (9 bytes)
  9: 3.23.0 (6 bytes)
  10: --kube-context (14 bytes)
  11: <snip> (43 bytes)
  12: --namespace (11 bytes)
  13: ingress-nginx (13 bytes)
  14: --values (8 bytes)
  15: /tmp/helmfile1688400903/ingress-nginx-ingress-nginx-values-64657bf977 (69 bytes)
  16: --values (8 bytes)
  17: /tmp/helmfile2830367879/ingress-nginx-ingress-nginx-values-7cc5c75c94 (69 bytes)
  18: --color (7 bytes)
  19: --reset-values (14 bytes)

ERROR:
  exit status 1

EXIT STATUS
  1

STDERR:
  Error: unknown flag: --color
  Usage:
    diff upgrade [flags] [RELEASE] [CHART]
  Examples:
    helm diff upgrade my-release stable/postgresql --values values.yaml
  Flags:
        --allow-unreleased             enables diffing of releases that are not yet deployed via Helm
    -C, --context int                  output NUM lines of context around changes (default -1)
        --detailed-exitcode            return a non-zero exit code when there are changes
        --devel                        use development versions, too. Equivalent to version '>0.0.0-0'. If --version is set, this is ignored.
        --disable-openapi-validation   disables rendered templates validation against the Kubernetes OpenAPI Schema
        --disable-validation           disables rendered templates validation against the Kubernetes cluster you are currently pointing to. This is the same validation performed on an install
        --dry-run                      disables cluster access and show diff as if it was install. Implies --install, --reset-values, and --disable-validation
    -h, --help                         help for upgrade
        --include-tests                enable the diffing of the helm test hooks
        --install                      enables diffing of releases that are not yet deployed via Helm (equivalent to --allow-unreleased, added to match "helm upgrade --install" command
        --kubeconfig string            This flag is ignored, to allow passing of this top level flag to helm
        --no-hooks                     disable diffing of hooks
        --output string                Possible values: diff, simple, json, template. When set to "template", use the env var HELM_DIFF_TPL to specify the template. (default "diff")
        --post-renderer string         the path to an executable to be used for post rendering. If it exists in $PATH, the binary will be used, otherwise it will try to look for the executable at the given path
        --reset-values                 reset the values to the ones built into the chart and merge in any new values
        --reuse-values                 reuse the last release's values and merge in any new values. If '--reset-values' is specified, this is ignored
        --set stringArray              set values on the command line (can specify multiple or separate values with commas: key1=val1,key2=val2)
        --set-file stringArray         set values from respective files specified via the command line (can specify multiple or separate values with commas: key1=path1,key2=path2)
        --set-string stringArray       set STRING values on the command line (can specify multiple or separate values with commas: key1=val1,key2=val2)
        --show-secrets                 do not redact secret values in the output
        --suppress stringArray         allows suppression of the values listed in the diff output
    -q, --suppress-secrets             suppress secrets in the output
    -f, --values valueFiles            specify values in a YAML file (can specify multiple) (default [])
        --version string               specify the exact chart version to use. If this is not specified, the latest version is used
  Global Flags:
        --no-color   remove colors from the output
  Error: plugin "diff" exited with error

COMBINED OUTPUT:
  Error: unknown flag: --color
  Usage:
    diff upgrade [flags] [RELEASE] [CHART]
  Examples:
    helm diff upgrade my-release stable/postgresql --values values.yaml
  Flags:
        --allow-unreleased             enables diffing of releases that are not yet deployed via Helm
    -C, --context int                  output NUM lines of context around changes (default -1)
        --detailed-exitcode            return a non-zero exit code when there are changes
        --devel                        use development versions, too. Equivalent to version '>0.0.0-0'. If --version is set, this is ignored.
        --disable-openapi-validation   disables rendered templates validation against the Kubernetes OpenAPI Schema
        --disable-validation           disables rendered templates validation against the Kubernetes cluster you are currently pointing to. This is the same validation performed on an install
        --dry-run                      disables cluster access and show diff as if it was install. Implies --install, --reset-values, and --disable-validation
    -h, --help                         help for upgrade
        --include-tests                enable the diffing of the helm test hooks
        --install                      enables diffing of releases that are not yet deployed via Helm (equivalent to --allow-unreleased, added to match "helm upgrade --install" command
        --kubeconfig string            This flag is ignored, to allow passing of this top level flag to helm
        --no-hooks                     disable diffing of hooks
        --output string                Possible values: diff, simple, json, template. When set to "template", use the env var HELM_DIFF_TPL to specify the template. (default "diff")
        --post-renderer string         the path to an executable to be used for post rendering. If it exists in $PATH, the binary will be used, otherwise it will try to look for the executable at the given path
        --reset-values                 reset the values to the ones built into the chart and merge in any new values
        --reuse-values                 reuse the last release's values and merge in any new values. If '--reset-values' is specified, this is ignored
        --set stringArray              set values on the command line (can specify multiple or separate values with commas: key1=val1,key2=val2)
        --set-file stringArray         set values from respective files specified via the command line (can specify multiple or separate values with commas: key1=path1,key2=path2)
        --set-string stringArray       set STRING values on the command line (can specify multiple or separate values with commas: key1=val1,key2=val2)
        --show-secrets                 do not redact secret values in the output
        --suppress stringArray         allows suppression of the values listed in the diff output
    -q, --suppress-secrets             suppress secrets in the output
    -f, --values valueFiles            specify values in a YAML file (can specify multiple) (default [])
        --version string               specify the exact chart version to use. If this is not specified, the latest version is used
  Global Flags:
        --no-color   remove colors from the output
  Error: plugin "diff" exited with error

Steps to reproduce
Run helmfile diff
Working Helmfile Version
0.144
Relevant discussion
No response

@immerrr --color option is available in https://github.com/databus23/helm-diff/releases/tag/v3.4.0
you are using diff 3.1.3  and you need to update your helm-diff to the latest.
helm plugin update https://github.com/databus23/helm-diff

Yep, upgrading diff plugin helped, if that's the intended solution I guess it's just the doc that needs a minor tweak (w.r.t. minor helm diff version requirement)

@immerrr @ismailyenigul i will update document. Thanks very much.


aksv2 - should be able to select AZs for User Mode NPs, if available for selected region

What kind of request is this (question/bug/enhancement/feature request): Bug
Steps to reproduce (least amount of steps as possible):
Right now, NPs gets AZs from whatever is selected by user in "Cluster Location", which is fine for System Mode NPs. However for User Mode NPs, it will be nice if user is given an option to choose from list of AZs selected in Cluster Location step.
Result:
Other details that may be helpful:
Environment information

Rancher version (rancher/rancher/rancher/server image tag or shown bottom left in the UI):
Installation option (single install/HA):

Cluster information

Cluster type (Hosted/Infrastructure Provider/Custom/Imported):
Machine type (cloud/VM/metal) and specifications (CPU/memory):
Kubernetes version (use kubectl version):

(paste the output here)

Docker version (use docker version):

(paste the output here)

This required some tweaks to the UI. I removed the AZ's from the section next to the region selection. Since it really ties to the node pool I think its less confusing to select the AZ's per node pool instead of trying to keep the on selection next to the region and also add it to node pools when adding a new one.

tested on master-b2f8824


Wiki entry for prime faces needs to be updated

The example FONT_DEST is incorrect, it should be
FONTS_DEST = `${this.APP_DEST}/fonts`;

Thanks for pointing this out! Would you update the wiki if you have a minute?

Done.. never edited a wiki page for someone before, didn't even see the "Edit" button..

Thanks!


Add itemName for paged operations in generated openapi spec

When defining a paged operation in TypeSpec, folks who are still relying on the generated openapi spec need the itemName field to be part of the x-ms-pageable data.
Playground: example
Current output:
        "x-ms-pageable": {
          "nextLinkName": "nextLink"
        }

Expected output:
        "x-ms-pageable": {
          "itemName": "items",
          "nextLinkName": "nextLink"
        }

cc @minhanh-phan the App Config v-team needs support for this

Smaller repro


kube-proxy resource limits

Hi all!
Would it be possible to include in this article what are the CPU and memory requirements / default values (requested and limits) for kube-proxy?
Thank you!

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: fd78c752-728a-9db9-fa4a-8e2167d2e48f
Version Independent ID: aff6f80f-f2f4-b830-827a-963b444d2d91
Content: Configure kube-proxy (iptables/IPVS) (preview) - Azure Kubernetes Service
Content Source: articles/aks/configure-kube-proxy.md
Service: azure-kubernetes-service
Sub-service: aks-networking
GitHub Login: @asudbring
Microsoft Alias: allensu

@olamiral-mulesoft
Thanks for your feedback! We will investigate and update as appropriate.

Thanks for your dedication to our documentation. Unfortunately, at this time we have been unable to review your issue in a timely manner, and we sincerely apologize for the delayed response. The requested updates have not been made since the creation of this issue, and the timeline for resolution may vary based on resourcing, so we've created an internal work item to incorporate your suggestions. We are closing this issue for now, but feel free to comment here as necessary.
#please-close

#reassign:schaffererin

Hi, @olamiral-mulesoft, thank you for your feedback. I apologize for the delay in receiving a response. I've made updates to the doc, which you can see in this PR. Once the build validation tests complete, I'll sign off on the PR and the changes will go live in the article shortly thereafter. Thanks again!


Handle r? as assignment

This adds parsing support for handling r? to direct assignment; anyone can do so
on a PR to any org member.
A future commit will add support for r? with a team.
This does not currently auto-assign reviewers like highfive to new PRs, though.

Other than that comment this PR looks good!

Rebased on master at https://github.com/kellda/triagebot/tree/highfive-review

This can be closed since the functionality is now implemented, right?


Const ext args

@nucleosynthesis
This is the discussion with Luca.
Add the possibility to set const ext arg and/or to freeze them with nuisance edit.

Looks good, and compiles+runs as expected. Merging now but we should add something to the docs for completeness.