[FUZZ] Beaconfuzz_v2 crash-5f5801ee2ad7be3a2c9017f3c731ccdbd3b0e64c

I've identified a fuzzer crash and am contributing to the security of Ethereum 2!
I've done and provided the following:

[x] Checked to see if any other [FUZZ] issue already refers to that crasher
[x] Attached the crashing input (either attached to the issue as a .zip or .gz, or as a link to a file sharing service)
[x] Noted the beacon-fuzz version or commit used.
[x] Provided crash output
[x] Noted the command or fuzzer used to generate the crash:
[x] Name of the original crash file.
[x] (Optional but optimal) Checked if the crash can be consistently replicated by re-running the input.

Info to Reproduce

Command run: make fuzz_attester_slashing-struct
Crasher file name: crash-5f5801ee2ad7be3a2c9017f3c731ccdbd3b0e64c
crash-5f5801ee2ad7be3a2c9017f3c731ccdbd3b0e64c.zip
Client exercised: Unsure, I ran it with the beaconfuzz_v2 differential fuzzer, I think it is Nim
Fuzzing engine used (if applicable): Structural fuzzing using libfuzzer

Crash output and stacktrace
Attached as a screenshot:

Re-ran the input on the nightly compiler (rustup default nightly, it refused to compile on default).
Command used to re-run input: RUST_BACKTRACE=1 cargo fuzz run struct_attester_slashing fuzz/artifacts/struct_attester_slashing/crash-5f5801ee2ad7be3a2c9017f3c731ccdbd3b0e64c
Stacktrace:
    Finished release [optimized] target(s) in 0.26s
     Running `fuzz/target/x86_64-unknown-linux-gnu/release/struct_attester_slashing -artifact_prefix=/root/fuzzing/beaconfuzz_v2/beacon-fuzz/beaconfuzz_v2/fuzz/artifacts/struct_attester_slashing/ fuzz/artifacts/struct_attester_slashing/crash-5f5801ee2ad7be3a2c9017f3c731ccdbd3b0e64c`
INFO: Seed:<PHONE_NUMBER>
INFO: Loaded 1 modules   (201440 inline 8-bit counters): 201440 [0x5555594799a1, 0x5555594aac81),
INFO: Loaded 1 PC tables (201440 PCs): 201440 [0x5555594aac88,0x5555597bda88),
fuzz/target/x86_64-unknown-linux-gnu/release/struct_attester_slashing: Running 1 inputs 1 time(s) each.
Running: fuzz/artifacts/struct_attester_slashing/crash-5f5801ee2ad7be3a2c9017f3c731ccdbd3b0e64c
ERRO[0018] Could not get rough time result: no reply     prefix=roughtime
ERRO[0018] Could not get rough time result: no reply     prefix=roughtime
ERRO[0018] Could not get rough time result: no reply     prefix=roughtime
ERRO[0018] Could not get rough time result: no reply     prefix=roughtime
ERRO[0018] Could not get rough time result: no reply     prefix=roughtime
ERRO[0018] Could not get rough time result: no reply     prefix=roughtime
ERRO[0018] Failed to calculate roughtime offset          error="no valid responses" prefix=roughtime
INFO[0018] New calculated roughtime offset is 0 ns       prefix=roughtime
couldn't interpret ETH2FUZZ_BEACONSTATE: environment variable not found
thread '<unnamed>' panicked at 'No valid beaconstate in the seed folder', fuzz_targets/struct_attester_slashing.rs:122:13
stack backtrace:
   0: std::panicking::begin_panic
   1: core::ops::function::FnOnce::call_once
   2: std::sync::once::Once::call_once::{{closure}}
   3: std::sync::once::Once::call_inner
             at /rustc/d006f5734f49625c34d6fc33bf6b9967243abca8/library/std/src/sync/once.rs:421
   4: rust_fuzzer_test_input
   5: __rust_try
   6: LLVMFuzzerTestOneInput
   7: _ZN6fuzzer6Fuzzer15ExecuteCallbackEPKhm
   8: _ZN6fuzzer10RunOneTestEPNS_6FuzzerEPKcm
   9: _ZN6fuzzer12FuzzerDriverEPiPPPcPFiPKhmE
  10: main
  11: __libc_start_main
  12: _start
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.
Traceback (most recent call last, using override)
/root/fuzzing/beaconfuzz_v2/nim-beacon-chain/vendor/nimbus-build-system/vendor/Nim/lib/system/excpt.nim(614) signalHandler
SIGABRT: Abnormal termination.
==1211654== ERROR: libFuzzer: fuzz target exited
    #0 0x5555560d6901  (/root/fuzzing/beaconfuzz_v2/beacon-fuzz/beaconfuzz_v2/fuzz/target/x86_64-unknown-linux-gnu/release/struct_attester_slashing+0xb82901)
    #1 0x55555836c630  (/root/fuzzing/beaconfuzz_v2/beacon-fuzz/beaconfuzz_v2/fuzz/target/x86_64-unknown-linux-gnu/release/struct_attester_slashing+0x2e18630)
    #2 0x55555835fb3b  (/root/fuzzing/beaconfuzz_v2/beacon-fuzz/beaconfuzz_v2/fuzz/target/x86_64-unknown-linux-gnu/release/struct_attester_slashing+0x2e0bb3b)
    #3 0x7ffff7bf2a26  (/lib/x86_64-linux-gnu/libc.so.6+0x49a26)
    #4 0x7ffff7bf2bdf  (/lib/x86_64-linux-gnu/libc.so.6+0x49bdf)
    #5 0x55555635a2d7  (/root/fuzzing/beaconfuzz_v2/beacon-fuzz/beaconfuzz_v2/fuzz/target/x86_64-unknown-linux-gnu/release/struct_attester_slashing+0xe062d7)
    #6 0x7ffff7bef20f  (/lib/x86_64-linux-gnu/libc.so.6+0x4620f)
    #7 0x7ffff7bef18a  (/lib/x86_64-linux-gnu/libc.so.6+0x4618a)
    #8 0x7ffff7bce858  (/lib/x86_64-linux-gnu/libc.so.6+0x25858)
    #9 0x55555841d146  (/root/fuzzing/beaconfuzz_v2/beacon-fuzz/beaconfuzz_v2/fuzz/target/x86_64-unknown-linux-gnu/release/struct_attester_slashing+0x2ec9146)
    #10 0x5555584061d5  (/root/fuzzing/beaconfuzz_v2/beacon-fuzz/beaconfuzz_v2/fuzz/target/x86_64-unknown-linux-gnu/release/struct_attester_slashing+0x2eb21d5)
    #11 0x555558359176  (/root/fuzzing/beaconfuzz_v2/beacon-fuzz/beaconfuzz_v2/fuzz/target/x86_64-unknown-linux-gnu/release/struct_attester_slashing+0x2e05176)
    #12 0x55555840d4e7  (/root/fuzzing/beaconfuzz_v2/beacon-fuzz/beaconfuzz_v2/fuzz/target/x86_64-unknown-linux-gnu/release/struct_attester_slashing+0x2eb94e7)
    #13 0x555556120954  (/root/fuzzing/beaconfuzz_v2/beacon-fuzz/beaconfuzz_v2/fuzz/target/x86_64-unknown-linux-gnu/release/struct_attester_slashing+0xbcc954)
    #14 0x55555611d569  (/root/fuzzing/beaconfuzz_v2/beacon-fuzz/beaconfuzz_v2/fuzz/target/x86_64-unknown-linux-gnu/release/struct_attester_slashing+0xbc9569)
    #15 0x5555561207f4  (/root/fuzzing/beaconfuzz_v2/beacon-fuzz/beaconfuzz_v2/fuzz/target/x86_64-unknown-linux-gnu/release/struct_attester_slashing+0xbcc7f4)
    #16 0x55555612877c  (/root/fuzzing/beaconfuzz_v2/beacon-fuzz/beaconfuzz_v2/fuzz/target/x86_64-unknown-linux-gnu/release/struct_attester_slashing+0xbd477c)
    #17 0x55555611ff6b  (/root/fuzzing/beaconfuzz_v2/beacon-fuzz/beaconfuzz_v2/fuzz/target/x86_64-unknown-linux-gnu/release/struct_attester_slashing+0xbcbf6b)
    #18 0x555558407164  (/root/fuzzing/beaconfuzz_v2/beacon-fuzz/beaconfuzz_v2/fuzz/target/x86_64-unknown-linux-gnu/release/struct_attester_slashing+0x2eb3164)
    #19 0x55555618605c  (/root/fuzzing/beaconfuzz_v2/beacon-fuzz/beaconfuzz_v2/fuzz/target/x86_64-unknown-linux-gnu/release/struct_attester_slashing+0xc3205c)
    #20 0x5555583591a0  (/root/fuzzing/beaconfuzz_v2/beacon-fuzz/beaconfuzz_v2/fuzz/target/x86_64-unknown-linux-gnu/release/struct_attester_slashing+0x2e051a0)
    #21 0x555558358dff  (/root/fuzzing/beaconfuzz_v2/beacon-fuzz/beaconfuzz_v2/fuzz/target/x86_64-unknown-linux-gnu/release/struct_attester_slashing+0x2e04dff)
    #22 0x55555835ff9c  (/root/fuzzing/beaconfuzz_v2/beacon-fuzz/beaconfuzz_v2/fuzz/target/x86_64-unknown-linux-gnu/release/struct_attester_slashing+0x2e0bf9c)
    #23 0x55555833cbf9  (/root/fuzzing/beaconfuzz_v2/beacon-fuzz/beaconfuzz_v2/fuzz/target/x86_64-unknown-linux-gnu/release/struct_attester_slashing+0x2de8bf9)
    #24 0x5555583469f2  (/root/fuzzing/beaconfuzz_v2/beacon-fuzz/beaconfuzz_v2/fuzz/target/x86_64-unknown-linux-gnu/release/struct_attester_slashing+0x2df29f2)
    #25 0x5555560534b6  (/root/fuzzing/beaconfuzz_v2/beacon-fuzz/beaconfuzz_v2/fuzz/target/x86_64-unknown-linux-gnu/release/struct_attester_slashing+0xaff4b6)
    #26 0x7ffff7bd00b2  (/lib/x86_64-linux-gnu/libc.so.6+0x270b2)
    #27 0x55555605365d  (/root/fuzzing/beaconfuzz_v2/beacon-fuzz/beaconfuzz_v2/fuzz/target/x86_64-unknown-linux-gnu/release/struct_attester_slashing+0xaff65d)

SUMMARY: libFuzzer: fuzz target exited
────────────────────────────────────────────────────────────────────────────────

Error: Fuzz target exited with exit code: 77

Stack backtrace:
   0: cargo_fuzz::project::FuzzProject::exec_fuzz
   1: <cargo_fuzz::options::run::Run as cargo_fuzz::RunCommand>::run_command
   2: cargo_fuzz::main
   3: std::sys_common::backtrace::__rust_begin_short_backtrace
   4: std::rt::lang_start::{{closure}}
   5: core::ops::function::impls::<impl core::ops::function::FnOnce<A> for &F>::call_once
             at /rustc/d006f5734f49625c34d6fc33bf6b9967243abca8/library/core/src/ops/function.rs:259
      std::panicking::try::do_call
             at /rustc/d006f5734f49625c34d6fc33bf6b9967243abca8/library/std/src/panicking.rs:381
      std::panicking::try
             at /rustc/d006f5734f49625c34d6fc33bf6b9967243abca8/library/std/src/panicking.rs:345
      std::panic::catch_unwind
             at /rustc/d006f5734f49625c34d6fc33bf6b9967243abca8/library/std/src/panic.rs:382
      std::rt::lang_start_internal
             at /rustc/d006f5734f49625c34d6fc33bf6b9967243abca8/library/std/src/rt.rs:51
   6: main
   7: __libc_start_main
   8: _start

Your Environment

Fuzzer ran: Beaconfuzz_v2 using libfuzzer
Version/Commit used: b56bf452adc05ac5b0a73aa8844dac0465894ebc refs/heads/beaconfuzz_v2
Operating System and version: Ubuntu 20.04, Docker version 19.03.12, Linux 4.15.0 kernel, Running on a OpenVZ virtualized VPS

I just noticed that the stacktrace has a statement couldn't interpret ETH2FUZZ_BEACONSTATE: environment variable not found. I can't find any info on setting this variable in the README, please do let me know how one can set the variable. The issue might then just be a config related error and not a fuzzing crash.

Thanks for your efforts @parithosh!
Agreed there doesn't look to be any info on ETH2FUZZ_BEACONSTATE in the current README.
From the Makefile, we can see that it's set to point to eth2fuzz corpora's folder of known beaconstates:
https://github.com/sigp/beacon-fuzz/blob/4e329051eabb8ed7b50beee8a6ff71fa70c6b585/beaconfuzz_v2/Makefile#L53-L54
But this would only be a config issue during the attempt to reproduce, and not during the initial crash identification.
We'll look into it further!

@gnattishness I confirm, when ETH2FUZZ_BEACONSTATE is not set, I make the program to panic ;)
Thanks @parithosh

@pventuzelo glad that it was a config error then :D
My other issue might have the same cause, so I think you can just add the same comment and close that as well.

I reopen the issue until we give a try to your testcase, look like the variable was impacting only the repro

With the latest update of prysm and beaconfuzz_v2, i'm not able to repro the bug using this command:
ETH2FUZZ_BEACONSTATE=../eth2fuzz/workspace/corpora/beaconstate cargo +nightly fuzz run struct_attester_slashing crash-5f5801ee2ad7be3a2c9017f3c731ccdbd3b0e64c

or using:
./beaconfuzz_v2 debug

Thanks for reporting @parithosh - this is another great find by the structural fuzzer, highlighting a subtle difference between how Nimbus, Prysm and Lighthouse handle the AttesterSlashing processing.
As per the eth2 specification:
def process_attester_slashing(state: BeaconState, attester_slashing: AttesterSlashing) -> None:
    attestation_1 = attester_slashing.attestation_1
    attestation_2 = attester_slashing.attestation_2
    assert is_slashable_attestation_data(attestation_1.data, attestation_2.data)
    assert is_valid_indexed_attestation(state, attestation_1)
    assert is_valid_indexed_attestation(state, attestation_2)

    slashed_any = False
    indices = set(attestation_1.attesting_indices).intersection(attestation_2.attesting_indices)
    for index in sorted(indices):
        if is_slashable_validator(state.validators[index], get_current_epoch(state)):
            slash_validator(state, index)
            slashed_any = True
    assert slashed_any

The function is_valid_indexed_attestation is defined as follows:
def is_valid_indexed_attestation(state: BeaconState, indexed_attestation: IndexedAttestation) -> bool:
    """
    Check if ``indexed_attestation`` is not empty, has sorted and unique indices and has a valid aggregate signature.
    """
    # Verify indices are sorted and unique
    indices = indexed_attestation.attesting_indices
    if len(indices) == 0 or not indices == sorted(set(indices)):
        return False
    # Verify aggregate signature
    pubkeys = [state.validators[i].pubkey for i in indices]
    domain = get_domain(state, DOMAIN_BEACON_ATTESTER, indexed_attestation.data.target.epoch)
    signing_root = compute_signing_root(indexed_attestation.data, domain)
    return bls.FastAggregateVerify(pubkeys, signing_root, indexed_attestation.signature)

It turns out that Lighthouse and Prysm are performing the indexed attestation validation as part of their signature verification:
In Lighthouse:
https://github.com/sigp/lighthouse/blob/c9596fcf0ee3a17bfb1df48e23ed6339c3791457/consensus/state_processing/src/per_block_processing/is_valid_indexed_attestation.rs#L39-L51
The closure |i| get_pubkey_from_state(state, i) would return an error for out-of-range attesting indices, however since fuzzing disables BLS verification, that particular check is not performed (the entire code block is skipped).
For Prysm:

https://github.com/prysmaticlabs/prysm/blob/de3f112a0500234a27d9cd8b29a60dc26fba6394/beacon-chain/core/blocks/attester_slashing.go#L79-L103
https://github.com/prysmaticlabs/prysm/blob/3734bfacce3b927c56c83c7acbbf24b4b8a76835/beacon-chain/core/blocks/attestation.go#L305-L327

When BLS signatures are disabled, PublicKeyFromBytes() returns an empty BLS signatures, regardless of the attesting indices provided (therefore not checking for out-of-range attesting indices).
As a result, the AttesterSlashing object produced by the structural fuzzer is considered valid by Lighthouse and Prysm, with the associated state transition resulting in a post-BeaconState.
For Nimbus:

https://github.com/status-im/nim-beacon-chain/blob/4b38619c4f51847fc591e85327ed226ad46d24ac/beacon_chain/spec/state_transition_block.nim#L193-L224
https://github.com/status-im/nim-beacon-chain/blob/4b38619c4f51847fc591e85327ed226ad46d24ac/beacon_chain/spec/beaconstate.nim#L442-L447

In the snippet linked above, we can see that Nimbus performs an additional check on the attesting indices:
  let num_validators = state.validators.lenu64
  if anyIt(indexed_attestation.attesting_indices, it >= num_validators):
    return err("indexed attestation: not all indices valid validators")

As a result, the AttesterSlashing generated by the structural fuzzer is rejected by Nimbus (since the second attesting index in the second IndexedAttestation causes the check above to fail).
This explains the discrepancy raised by the fuzzer. Thanks again for reporting this @parithosh !

Thanks for the details response @zedt3ster ! Glad I could be of help :)


Refactors project to use Svelte

Implementation of: #13
As far as I know, this is feature complete.
Changes From Current

Appearance
Analysis does not need a button to trigger. Starts immediately after upload.
Each phenotype header shows how many variants are pathogenic
Rendering of pathogenicity of a variant is now an explicit label, rather than coloring the entire line red

Additions

Genotype class - An abstraction so that the developer does not have to worry about flipping the order of the nucleotides
GeneDataParser class - For encapsulating parsing methods.
GeneVariant class - So we can have nice methods

To do

More user-friendly error handling and reporting now that we have access to Svelte-powered UI. I have put this off to minimize the scope of this PR.
Probably drag and drop for file upload.
Delete the public directory

Notes

Not actually sure if gh-deploy will work properly
I want to do so much more with the UI, but I have tried to keep it as close to status quo as possible, to limit the scope to a refactor rather than a redesign.

This seems good, if you can just bring it up-to-date with the latest main, I'll fix up the CI part and merge it.

@d6e done! :D

Alright looks good! Thank you so much!


Fix race condition / edge case in _strokeUpdate

Replicates https://github.com/szimek/signature_pad/pull/481/files but into v2 branch
Originally submitted on https://github.com/szimek/signature_pad/pull/601 but got rejceted. Then discussed at length in https://github.com/agilgur5/react-signature-canvas/pull/68 and aims to solve this issue https://github.com/szimek/signature_pad/issues/329

Our app has been getting spammed with errors from this lingering issue. Would really appreciate getting this fix merged in 🙏

What's the hold up on this guy getting merged?

Was there any update on this ? Have also been getting flooded error logs recently.


New version <IP_ADDRESS>5 available

There is a new version of crashplan available <IP_ADDRESS>5

Thanks for reporting, I will update the docker image.

New image now available :)


more iswap backend kwargs, hotel

changes:
added to STAR.pick_up_resource:

iswap_grip_strength: int = 4
minimum_traverse_height_at_beginning_of_a_command: Optional[float] = None
z_position_at_the_command_end: Optional[float] = None
plate_width_tolerance: float = 2.0
hotel_open_gripper_position: Optional[float] = None
hotel_depth=160.0
hotel_clearance_height=7.5
high_speed=False
plate_width: Optional[float] = None
use_unsafe_hotel: bool = False
iswap_collision_control_level: int = 0
iswap_fold_up_sequence_at_the_end_of_process: bool = True

added to STAR.drop_resource:

minimum_traverse_height_at_beginning_of_a_command: Optional[float] = None
z_position_at_the_command_end: Optional[float] = None
hotel_open_gripper_position: Optional[float] = None
hotel_depth=160.0
hotel_clearance_height=7.5
hotel_high_speed=False
use_unsafe_hotel: bool = False
iswap_collision_control_level: int = 0

the resource-tree update logic was moved form LiquidHandler.move_{plate,lid} into LiquidHandler.{pick_up,drop}resource so that resources are put in the correct spots and the tree is accurate, also when the user doesn't use the highest levels methods. I am tempted to remove LiquidHandler.move{plate,lid} because they only provide a default value for the parameter pickup_distance_from_top at this point (the default value can be in LiquidHandler.pick_up_resource instead.
I also deleted STAR.{iswap_pick_up_resource,iswap_release_picked_up_resource} and put the logic there into STAR.pick_up_resource and STAR.drop_resource. STAR.pick_up_resource and STAR.drop_resource now call the lowest-level firmware-command-implementations iswap_get_plate and iswap_put_plate, removing one layer (simple is better). This also allows the sharing of that logic with the hotel-variants of iswap commands.


Test/Validate published ScubaGear module (for test repository)

💡 Summary
Test/Validate the nighly publish ScubaGear module.
Motivation and context
This would be useful because it will assist in testing/preparing to publish to a public repository.
Implementation notes
Reference #672 for context and additional information

Code re-useable function(s) to test ScubaGear module is published properly.
Add test to nightly publishing action for ScubaGear to test repository

Acceptance criteria

[ ] Automated nightly test shows Install-Module is successful
[ ] Automated nightly test shows Find-Module is successful
[ ] Automated nightly test shows Update-Module is successful
[ ] Automated nightly test shows Uninstall-Module is successful

Closed with #699


add shadow in editor hove and suggest-widget

This PR fixes #
add rules editorSuggestWidget.shadow , editorHoverShadow.color   for editor suggest-widget and hover-widget
these looks like

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: onsunny sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

Which issue does this fix?
Please note that we don't easily take UI changes. It is better to open an issue with a proposal, and only do the change after a member approves your UI change. @misolori FYI

Agreed, please create an issue with your request/proposals.


OneClick and SEPA fix

OneClick is not working for alternative payment methods and SEPA will always use the AUTH/CAP flow and can't be changed.

Wrong repository this is for Magento2 extension


SW-4761 Create NurseriesRouter and move all nurseries related views (that exist within /nurseries path) and sub components to scenes directory

SW-4761 Create NurseriesRouter and move all nurseries related views (that exist within /nurseries path) and sub components to scenes directory
Fix route so it matches any routes behind /nurseries

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

Current dependencies on/for this PR:

main

PR #2050

PR #2061

PR #2062

PR #2063

PR #2064

PR #2065

PR #2066

PR #2067

Merge activity

Jan 25, 3:38 PM: @sgrimm started a stack merge that includes this pull request via Graphite.


feat(@schematics/angular) add .history directory to gitignore

closes #12895

I signed it!

Will reopen with fixes

Re-opened in MR #13002


Add support to display images in the code editor

It is very good to have this feature. It is a must to implement things like:

#3220 can be another way to achieve similar effects, but it seems that there is no update for that?

dupe of #3220


Fix/search text cell on edit

This PR fixes #9196

It would be helpful if you gave more context about what was broken and how you're fixing it in PRs, helps with reviewing it. (It doesn't have to be super complex, just a brief overview of the changes to help people get oriented)


Localization broken

SVN r515 was fine, but since the new build system was introduced (in SVN r516), localization is broken and fbpanel displays with the C locale.
This of course isn't noticeable to English-language users.

confirm, my system is in italian language but systemmenu of fbpanel is english. how can i solve?

@lodgerz this bug has been around for years, this is starting to smell of abandonware.
When the build system was changed at revision 515, localization was broken in the process.
As for solving, you need to copy the missing files, as I do in that packaging script:
https://aur.archlinux.org/cgit/aur.git/tree/PKGBUILD?h=fbpanel-git
I guess the author has an English locale and therefore does not care.

a :+1: here @calimeroteknik  this is the only real issue in the hole list of issues..  @lodgerz  me too noted this problem..
@aanatoly  this are some king of irresponsability.. seems do you not noted that you are using only english desktop..
but @calimeroteknik  please dont paste link to shit script that in future can be dissapear (specially from a distro that are a fashion way of made thigs)
here are the manual fix of:
    cd po
    for mofile in *.mo;do
        install -Dm755 "$mofile" "{{prefix}}/usr/share/fbpanel/locale/${mofile%%_*}/LC_MESSAGES/fbpanel.mo"
    done

of course due the configure scrip must be tuned.. i'm too busy right now and this manual fix works for debian of course

No reason to be irate or rude, though; you're not paying anything to the author, this is all voluntary work.

i can make a PR but seems will be ignored for a time! ... does that mean if are free are less important?

I don't really understand what you mean.
If that answers your question, I believe that you can't demand anything from software that is available to you for free.
Since this can be forked freely, you may just as well have your own fixed fork ; of course this is some trouble, and it's much more interesting to upstream your patches, but when the original author/maintainer hasn't replied about such as simple fix for more than 3 years and you're in a relative hurry, you might as well maintain it your own fork.
You know — it's free software.
Besides, with Wayland being the next display manager norm, fbpanel is in need of either a rewrite for some Wayland compositor protocol for panels like wlroot's, or just a replacement.

@calimeroteknik  I will repeat: I can make a Pull Request CALLED "PR" to be seen by the author, but in first place. seems author are not very alert respect fbpanel repository..
and in second place: but the objective of fbpanel is not to be more complex or to give support to more complex things... (neither things that are criticited to be far away of unix spirit) but to the simple things... wayland and several monitors is already something more complex than just showing the panel and painting a menu in it.
in last and most important way: "you're not paying" and "voluntary work", what does that means? if it's voluntary and free you don't have to put in the same effort as if it were something paid for? it's not strange because the bosses always say "put in some real software" instead of using free software.. or else when they use free software they alter it and never return what's really important (like androit and azure)


chore: Workflows for validations

Workflow for semantic release, as well as PR unit tests

Did we ever resolve the SDK ordering issue where some schemas are named with numerical suffixes and would sometimes generate in a different order? I don't have an example off-hand but if you run the generator a handful of times you may run into it. Any automation we build around generating the SDK will probably have to address that issue before we can rely on it, otherwise if we rename these types due to random ordering the clients will break.

We have not addressed it yet. In the meantime, I added this workflow so we can easily re-run generation if something is not looking right to us.


Enable and expose ECDH

Example higher-level wrapping call:
let ecdh ~context ~pk ~sk =
  (* ECDH(k, rk): performs an Elliptic-Curve Diffie-Hellman operation using sk, which
     is a valid secp256k1 private key, and pk, which is a valid public key

    The returned value is the SHA256 of the compressed format of the generated point. *)
  let cstruct = Cstruct.create 32 in
  let retval = Secp256k1.Ecdh.ecdh context ~pk ~sk cstruct.Cstruct.buffer in
  if Int.( <> ) retval 1
  then failwithf "ecdh: exponentian failed: scalar was invalid (zero or overflow)" ();
  cstruct

Link to this issue at Nomadic Labs' Gitlab https://gitlab.com/nomadic-labs/ocaml-secp256k1-internal/-/issues/7


NavigateUp to fragment ,The sliding state of the AppBarLayout cannot be preserved

NavigateUp to fragment ,The sliding state of the AppBarLayout cannot be preserved

Can you elaborate on the issue, or perhaps record a small video illustrating the behavior?

any gif to demonstrate this?

This isn't an issue specific to Sunflower.  I'd suggest asking the question in the Android community at Stack Overflow.


(fix) Scoping bug in inlining

Addresses #389
Signed-off-by: Jerome Simeon<EMAIL_ADDRESS>

This looks better:
define constant x : Integer = 1
define function f(x : String) : String { return x ++ "hi" }
return f("hi");
Response. "hihi"
  :  {emit: Event[], response: String, state: Unit}?
define function g(y : String) : String { if x = 1 then return y ++ "hi" else return y ++ "bye" }
return g("boo");
Response. "boohi"
  :  {emit: Event[], response: String, state: Unit}?

A much easier fix would have been to just add the params to the local context before inlining globals. This creates yet another context, which is only used to fix this bug.

Add them with which value?

dunit would suffice — it just needs to know that the name is in scope, it doesn't care what it is bound to.


[NEW FEATURE] -

Briefly describe the feature.
Voting Issue on Optimism
Which problem is this feature trying to solve?
I can't vote on snapshot.org, i have had tokens since first airdrop of the protocol . I got tokens in my metamask wallet im trying to vote and i can't vote on any proposals, its showing that i have 0 OP token to vote. can sone one help me resolve this issue ?
What is the expected solution?
idk
How do you currently handle this problem?
waiting
Anything else you'd like to mention?
No response

OP tokens needs to be delagated to yourself, once done you will be able to vote on future proposals not currents.
https://app.optimism.io/airdrop/delegates
Click on delegate to anyone


Flatpickr not close in modal window

When I set properties static: true and enableTime: true flatpickr not close on lost focus in modal window.
My version<EMAIL_ADDRESS>

@AndriyYushko  Please provide an online demo link and steps here to reproduce the issue. Thanks


can't open it  at port 4000

when i cloned the theme and try to open at localhost in hexo s way,i just recived
WARN  No layout: index.html
what should i do? i have the index.ejs.

are u sure that you put the cloned folder under /theme and changed both the folder name and the one in config to 'aircloud' (not necessarily aircloud, but have to be identical)?

@BrainLyh I got the same problem.
should be under '/themes' folder.
For example,
/hexo-aircloud-blog-master/themes/aircloud(hexo-theme-aircloud-master)

It would be work.


Release tags store entries when a check sampler is discarded

What does this PR do?
Release tags store entries when a check sampler is discarded.
When a check is removed, contexts for active metrics are not expired yet, and are not removed from the context resolver, but the entire object tree is simply discarded. This patch adds a finalizer to context resolver, so reference counts can be updated for context objects that are about to be GC'd.
Motivation
Avoid accumulating tags from checks that were de-scheduled.
Additional Notes
Possible Drawbacks / Trade-offs
Finalizers are reliable for the purpose, but timing is unpredictable. Explicitly clearing the resolver on check deregister would be more deterministic, but requires plumbing a new call through several components.
Describe how to test/QA your changes
Run the agent with tags store enabled, and a large number of checks scheduled, sending metrics, and de-scheduled.
Verify that total number of entries in the tags store does grow and remains similar to the number of metrics sent.
Reviewer's Checklist

[x] If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
[x] The appropriate team/.. label has been applied, if known.
[ ] Use the major_change label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.
[ ] A release note has been added or the changelog/no-changelog label has been applied.
[ ] Changed code has automated tests for its functionality.
[ ] Adequate QA/testing plan information is provided if the qa/skip-qa label is not applied.
[ ] If applicable, docs team has been notified or an issue has been opened on the documentation repo.
[ ] If applicable, the need-change/operator and need-change/helm labels have been applied.
[ ] If applicable, the config template has been updated.

That alternative doesn't seem bad to me, but I suppose it's a matter of taste.  This is also one of the few places we're using atomic refcounts, so perhaps it makes sense to introduce this as a new idiom in the codebase.


add LICENSE.txt

In setup.py you mention the license to be "BSD". I propose that a License file should be added, also there's old and new BSD license.. I'm assuming you want the new BSD-3-Clause?

thank you!

Btw. I stumbled over this when working on conda packaging.. see conda-forge/staged-recipes/3215

cool, let me know if there is anything I can do to help you.
I suppose you need a new release with the update LICENSE.txt?

I suppose you need a new release with the update LICENSE.txt?

No, not really. I don't think having it is enforced strictly but it's strongly encouraged. It can be included starting with the next build (if the conda packaging succeeds).


Can it be used inside browser enviroment?

As the title says.

I see in browser.js:
module.exports = require('buffer')

So this package depends on buffer. But why does this dependency not be written inside file :packge.json

Yes, this package can be used inside a browser environment. When you bundle your code with browserify or webpack, calls to Node.js built-ins like require('buffer') will automatically be replaced with browser implementations. In this case, the implementation used is feross/buffer.
You don't need to add Node.js built-in packages to your package.json.

@feross
Now I see: the bundle tool does the magic.
Thanks.


Merge to live

Docs Build status updates of commit 54926b8:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/overview/office-add-in-availability.md
:white_check_mark:Succeeded

docs/reference/requirement-sets/excel-api-online-requirement-set.md
:white_check_mark:Succeeded

docs/reference/requirement-sets/excel-api-requirement-sets.md
:white_check_mark:Succeeded

docs/toc.yml
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


"uninstall_oh_my_zsh" command not working properly

uninstall_oh_my_zsh command returns to bash instead of zsh.
reproduce steps;

install oh-my-zsh
run uninstall_oh_my_zsh

System;
Macos Catalina 10.15 with default zsh shell
I think it's because of this part. There is no .shell.pre-oh-my-zsh file in the home directory;
https://github.com/robbyrussell/oh-my-zsh/blob/687c50bdf999f8efd45f3c8f578a62329b0633da/tools/uninstall.sh#L28-L32

This was added recently, meaning that if you installed OMZ previous to this change, the file wasn't created and the uninstaller defaults to going back to bash. You can manually return to zsh with chsh -s $(which zsh).

@mcornella I didn't install before the change. The issue took place 26 days ago. I tested it a few times. How do you close it without testing or getting answers?

I assumed that based on your information,

I assumed that based on the information that there wasn't a .shell.pre-oh-my-zsh file. The commit to save the previous shell was committed on June 3rd, 2019. Here's the bit that generates that file on install:
https://github.com/robbyrussell/oh-my-zsh/blob/52f58785645c18aa88ea515d070a42bcfe97508d/tools/install.sh#L197-L202
I see now that the file is deleted on successful change to $old_shell, so you may have had it before the uninstall:
https://github.com/robbyrussell/oh-my-zsh/blob/52f58785645c18aa88ea515d070a42bcfe97508d/tools/uninstall.sh#L34-L37
The whole thing could be improved, but the only explanation I can see is that (1) the shell saved was bash, due to $SHELL or the shell in /etc/passwd being bash; or (2) the file was deleted or never generated in the first place, and the uninstaller defaulted to bash.
As per

How do you close it without testing or getting answers?

it's a habit I've developed after not receiving any answer on giving a solution, making the issue open for months without response. Once we work through the old issues we'll add a stale bot to keep that from happening.

@mcornella in my opinion file is never generated in the first place.  When I tested the shell script condition separately, the file was created.
 if [ -n "$SHELL" ]; then
 	echo $SHELL > ~/.shell.pre-oh-my-zsh

this way the file was not created. ;
sh -c "$(curl -fsSL https://raw.githubusercontent.com/robbyrussell/oh-my-zsh/master/tools/install.sh)"
maybe it may be related to write permissions.

Right, this is the culprit: https://github.com/robbyrussell/oh-my-zsh/blob/52f58785645c18aa88ea515d070a42bcfe97508d/tools/install.sh#L143-L146
If the current shell is already zsh do not attempt to change. Therefore the shell is never stored and when uninstalling it will switch to bash. This is indeed a bug, I'll think of a fix tomorrow.


add persistence.existingClaim to postgresql

@prydonius Based on our conversation yesterday, I thought this might be a reasonable solution. Please let me know what you think. If this is agreeable, I can apply these basic changes to redis, rabbit, redmine, and jenkins.

I signed it!

LGTM

@databus23 Hey, is it possible that this PR requires the lgtm tag, rather than just the comment? I've noticed that  other PRs have the tag applied.

@flah00 Could be. I don't have committer access. ping @mgoodness

@databus23 @mgoodness I got some feedback on 394a4ef59df912964219e51850c497e852640ff1, do you want me to clean this up as well? Or are you happy with this PR as it is?

@flah00 I updated with the other changes to be consistent, and bumped the minor version according to semver :)


Unlock layer when locked by a runner that does not exist anymore

For unknown reasons, it happens that Burrito locks a layer and never unlocks it (probably because a pod was killed due to a spot instance reclaim). That causes all the next runs to fail, as the layer is locked.
To prevent this behavior, we could implement a way to unlock the layer before starting a plan / apply operation only if the following conditions are met:

The layer was locked by a Burrito run
The pod that locked the layer is not running anymore

add in the UI that a layer is locked, that could be useful if somebody (or an automated process) left a lock on a layer


Problems with updates

Hello,
After update and after a new install of the template I get the following errors:
Warning: filemtime(): stat failed for ./themes/bootstrap_darkroom/node_modules/font-awesome/web-fonts-with-css/css/fontawesome-all.min.css in /home/xxxxxxxxx/public_html/xxxxxxxx/include/template.class.php on line 1894
Warning: file_get_contents(./themes/bootstrap_darkroom/node_modules/font-awesome/web-fonts-with-css/css/fontawesome-all.min.css): failed to open stream: No such file or directory in /home/xxxxxxxxxxxx/public_html/xxxxxxxxx/include/template.class.php on line 1990
Some forum posts also escalated on piwigo forums: https://piwigo.org/forum/viewtopic.php?pid=173189
Your help is appreciated.

UPD: this happened after the last piwigo and template. The piwigo installed in folder on server with the url like: https://domainname.com/xxxxxxxx/
So as I can see it's a problem with a url compiling.. Any suggestions?

I just posted this in the mentioned topic:

Do you maybe have a template copy in template-extension\bootstrap_darkroom, for example
"index.tpl"? This has to be adjusted too to the new folder structure... I had the same problem.

Best regards
Friedemann

Good catch @Schmidtze2
So, to summarize:

make sure any custom template overrides are updated
purge compiled template cache
purge the browser cache


Thoughts on Message Digest

I'm trying to use this gem in an service-oriented architecture, where there are multiple writers to SQS queues.
The Rails app is the "center-piece" and also where all job processing is performed.
Due to the checks of a message-digest and the "origin=AEJ" header (https://github.com/tawan/active-elastic-job/blob/master/lib/active_elastic_job/rack/sqs_message_consumer.rb#L59) it is currently very hard to have publishers to SQS, other than the Rails app (with the same secret_key_base).
I believe I'll be able to "fake" these headers so that I can have my other publishers' jobs accepted. (Either that or I'll fork this gem and delete that check :P)
Either way, this got me thinking if this feature isn't "too much", and maybe it should be configurable (at least to turn on/off).
I think the check for localhost requests is all ok, but other than that it feels like this gem is doing too much. It's the user's job to ensure that their queues aren't publicly accessible and AWS provides all the tools to make that happen.
In my case the other publishers aren't rails/ruby apps, but even if they were, I'd have to ensure those other rails apps had the same secret_key_base, which is a bad thing.

Hi @Onumis ,
Thanks for your input. I can understand your points, however I'd rather leave the security messages in place for now. The focus of this gem is simplicity and ease of use. A user should be able to use the gem and the gem takes care of protecting the  web-environment from being spoofed into processing jobs. Even though the middleware can be disabled by an environment variable in the web environment, I'd rather keep the additional layers of protection in place - a user might forget to seth the environment variable.
You can of course fork the gem and adapt it to your needs, but there is another option:
You can write your own middleware and replace the SQSMessageConsumer.  In your middleware you can remove checks that you don't need. Have a look on Rails' guide on Rack. It explains how to delete and insert middleware.
I leave this issue open, let's see how others think about it.
Thanks again for your input.

@tawan thanks!

By the way @tawan you can avoid

a user might forget to set the environment variable.
If you instead use an env var to activate the worker: ENABLE_SQS_CONSUMER=TRUE

That way the web environment keeps as is, and the user has to explicitly activate this on the worker environment.

@Onumis  That is correct. The opt-in environment variable would have been a better solution. I don't know if I can introduce this change and be backwards compatible, though. I'll think about it, but thanks for   noticing.

Better start with a deprecation warning and only do the change in a future release.

I am not sure that would be better. In my case, for instance, I got a single web environment and a few worker environments. This is probably the average setup because you need an worker environment per queue. I believe simpler applications would use only a single queue, but most are likely to use more than one. At least to me it is easier to disable the consumer on the web environment (once) and be free to create more queues not having to worry with that.

@zaaroth  Makes sense. I'll leave it as it is.


Better support for ENUMs

SQLAlchemy offers great support for ENUM fields, mapping them from either a list of options or a Python Enum.
OData-Query doesn't utilize this feature well enough, and currently just crashes if you try to use a non-existing ENUM member.

This is partially solved in SQLAlchemy by passing validate_strings=True to the ENUM definition, which will raise LookupError when an unknown enum member is used. So this might not be our concern.
One adjacent feature that would be cool is supporting OData's enum type, which uses syntax like status eq PostStatus'DRAFT'.

hey @OliverHofkens , thanks for this great project!
what the is the syntax for current version for the ENUM query?
thank you so much


Entity Linker takes a while to process

I tried using the entity linker with UMLS from scispacy and it takes a while to load (for the first time) ~ around 14s.
The second time I run it is noticeably faster ~ 30 ms. I assume its cached?
Here is the code I ran:
%%time

doc = nlp("arrhythmia")
spacy.displacy.render(doc, style = "ent", jupyter = True)

entity = doc.ents[0]
print("Name: ", entity)

linker = nlp.get_pipe("scispacy_linker")
for umls_ent in entity._.kb_ents:
    print(umls_ent)
    print(linker.kb.cui_to_entity[umls_ent[0]])
    print("----------------------")

and it outputted:
..(the printed values)...
CPU times: user 0 ns, sys: 297 ms, total: 297 ms
Wall time: 13.8 s

Is this normal? Is there a way to make the results appear faster as in the demo in Streamlit, when I type in words in the textbox, the results seem to come out instantaneously.


check that release 0.7.x is getting updated

Should be done by https://cloudnative-k8sci.southcentralus.cloudapp.azure.com/view/pmem-csi/job/pmem-csi-release/

The job ran (instead of the one for release-0.6?!): https://cloudnative-k8sci.southcentralus.cloudapp.azure.com/blue/organizations/jenkins/pmem-csi-release/detail/pmem-csi-release/142/pipeline/77
However, it failed because parallel testing did not anticipate the tag name change from v0.7.0 to v0.7.1. Needs to be fixed.


Update transaction value validation

This PR updates transaction value validation to only accept valid integer numbers.
Resolves https://github.com/MetaMask/gaba/issues/68

Codecov Report

Merging #74 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master    #74   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files          20     20
  Lines        1087   1091    +4
  Branches      126    128    +2
=====================================
+ Hits         1087   1091    +4

Impacted Files
Coverage Δ

src/util.ts
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0027e06...bb6a344. Read the comment docs.


Improve unit testing

Not sure if this repository accepts pull requests, but I want to propose a change for improving the testability of code that has a dependency on the esri-loader.  As currently written, when the EsriMapComponent test suite executes, it will call the loadModules() method from the esri-loader library, and make actual HTTP requests to fetch the ArcGIS API for JavaScript resources for the given modules. This is less than desirable behavior in a unit test, making the test more like an integration test as it needs to communicate across a network. There may also be a scenario where tests are executing in an environment, such as an automated build pipeline or server, where they cannot connect to the outside internet, causing the tests to fail.
The resolution is breaking the tight coupling between the EsriMapComponent class and the esri-loader.  This can be done by leveraging Angular's built-in dependency injection, and implementing the Facade Pattern around the esri-loader with a wrapper class. This will allow the app to use the esri-loader as designed, lazy loading modules at run time, but the abstraction layer provided by the wrapper class can be more easily mocked for tests and eliminates the need to make HTTP requests to fetch concrete implementations of ArcGIS JS API modules.
I recently posted on my blog about this, going much more in depth on this issue:
https://seesharpdotnet.wordpress.com/2020/12/03/angular-and-arcgis-api-for-javascript-a-unit-testing-strategy-using-dependency-injection-and-the-facade-pattern/
Changes made in this pull request:

Add EsriLoaderService class to act as a wrapper for the esri-loader library.
Remove reference to esri-loader in EsriMapComponent class, using EsriLoaderService instead.
Remove the @import() CSS rule for ArcGIS JS API styles in "esri-map.component.scss" and moved this to the loadScriptOptions parameter of the loadModules method to ensure the CSS version and API module version is consistent.
Improve unit test coverage of the EsriMapComponent class.
Remove unnecessary return of this._view from EsriMapComponent.initializeMap().
Update EsriMapComponent.ngOnInit() to set property _loaded only if initializeMap() was successful.
Consistent use of double quotes per this project's tslint.json file.
Consistent use of async/await.

This is awesome work @mfcallahan and nice work on the blog post! You've clearly put a ton of work into this. We do accept pull requests for small and incremental changes. For larger changes or rewrites like what you've done, those are best served by keeping them on your own personal repo where you can maintain it. We have many instances of this in the past.
Also note: This repo is being deprecated at the 4.18 release later this week, as per this issue: https://github.com/Esri/angular-cli-esri-map/issues/90#issuecomment-737443119. I'd like to close your PR and when I update this repo I can add a reference to your blog post and your github repo in the README.
We aim to keep our JavaScript framework github repos fairly simple and then provide intermediate to advanced content through our Esri DevSummit technical sessions: https://www.esri.com/arcgis-blog/products/js-api-arcgis/announcements/arcgis-api-for-javascript-devsummit-2020-videos-available/. Here's the 2020 Angular tech session video. However, after the release I'm interested in updating the Angular sample on jsapi-resources
For the 2021 Developer Summit (early March 2021), we are planning doing a technical session that also covers how to do unit testing with the new ES modules.

Thanks for the reply, I appreciate you taking this into consideration.  I will keep my version of this repo up for anyone who would like to use it for reference, and this pull request can be closed. Please do feel free to reference my repository and/or blog post anywhere that you feel may be appropriate.
I'm definitely excited to hear that there will be a tech session on unit testing with the new ArcGIS JS API ES modules for the 2021 Dev Summit. Are there any sample repositories yet with a demonstration of the new ES modules being used in an (Angular) app? I was a little bit confused by the intended use of the @arcgis/core, and arcgis-js-api packages. I'm  interested in getting a jump start on migrating some apps to the new ES modules.

There's a PR of the new (updated) 4.18 ESM samples that will be merged in a few days: https://github.com/Esri/jsapi-resources/pull/229. Here's the "older" versions of those samples that will work today with Angular 11: https://github.com/Esri/feedback-js-api-next/tree/master/esm-samples/jsapi-angular-cli. It's pretty simple: npm install, copy the /assets, and reference the CSS, and that's it.

I was a little bit confused by the intended use of the @arcgis/core, and arcgis-js-api packages.

@arcgis/core is the new ES modules. And, arcgis-js-api is the existing AMD modules, those have been around for quite a while. At 4.18, there will be updated documentation in the SDK explaining the differences. Starting at 4.18, the arcgis-js-api modules will mainly be for developers using Dojo or RequireJS.


 The objective is to identify datasets that include multiple images of the same person to enable matching across a large database. If possible, find labelled datasets that give bounding boxes for face detection.

[x] Key Criteria: Multiple images of the same person, Dataset size (number of individuals and total images), Annotations available (bounding boxes, keypoints, etc.), License (open for commercial or research use)
[x] Create a comparison table with the above criteria

Deliverable
A report or table summarizing potential datasets with recommendations on the most suitable ones for face detection and matching tasks.

The attached doc contains research on datasets that could be used for the task.
https://docs.google.com/document/d/1CpN__oPgmAvY65s-tWg4X-pZPCPwNEAU-ULrkdKWES4/edit?usp=sharing


Implementing infinite scrolling for strain catalog

make a separate component for the strain catalog table

remove commented out code

use default props for constant value (cell height/width)

use git branch for code archiving -> new branch for code that you want to save for later reference

Current screenshot


Feature/package version

Let Rimu know which version of it is installed.
This is potentially useful for scripts that save and read metadata in order to ensure or check compatibility between versions of Rimu.
Minor updates to docstrings and the documentation starting page.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.05%) to 90.033%

Totals

Change from base Build<PHONE_NUMBER>:
0.05%

Covered Lines:
3794

Relevant Lines:
4214

💛  - Coveralls


Auto Approval based on Release Status

Is your feature request related to a problem? Please describe.
I usually run auto approval for movies for users and do tv manually. This is mostly just me being particular about downloading gigs of files for a `150 ep TV show unexpectedly.
Describe the solution you'd like
An option to auto approve TV and Movies by release type, eg. Announced, Airing, etc. That way I can have TV show's that haven't started yet auto approved.
Describe alternatives you've considered
Adding an auto approval option to the filter options for matching content. Then adding release status as a filter. (I think this is the stronger option since it'll let people stack filters and auto approval for certain things.
An approval threshold for episodes aired would be nice as well. (Ex. Less than three episodes have come out for a show, go ahead and auto approve it)

I think it's possible for us to improve the auto approve system to allow for such an option, but I don't think it is something that will happen like what you have described, however it would have to be discussed between the developers to workout a proper way to make this happen.
It's not something we are planning to do just yet, but is something we can get around to later down the line.

yes seconded, we can allow auto approve conditions, but it's not on the immediate roadmap, will leave open for now


Kill all child processes that are owned by k3s if Rancher fails

Continuation of https://github.com/rancher/rancher/pull/36143
As a continuation of my conquest to fix the flaky testing in Rancher, I discovered that there is a condition in which Rancher can die (concurrent map read write on rancher startup and panic: indexer conflict: map[byPod:{}], I'm looking at you)
When this happens, the K3s processes that are started under the parent Rancher process are NOT cleaned up/killed, and instead, the K3s processes get inherited by PID 1. This is not good, and is why when subsequent attempts to start rancher end up with the bind address already in use message.
This PR adds functionality to properly clean up the K3s processes if Rancher fails.
Realistically, this should probably be fixed properly in norman, but for now, this bandaid will have to do to make CI more reliable.
Line ~1924 and further in this run show what can happen: https://drone-pr.rancher.io/rancher/rancher/20345/4/2

Huzzah, random OTHER flakes!


Is this an empty password?

In this file: https://github.com/danielmiessler/SecLists/blob/master/Passwords/xato-net-10-million-passwords-1000.txt
What is line 43 between hunter and buster? Is this an empty password?

Yes, it is


fix(split): always spawn split from current window when relative = editor

https://github.com/MunifTanjim/nui.nvim/discussions/335

[!WARNING]
I haven't added any tests and I don't know how to work with the test suite.
It would be nice if you @MunifTanjim could make a followup PR if you want to add some tests.

Should fix this issue as well.

https://github.com/folke/noice.nvim/issues/636

[!WARNING]
I haven't added any tests and I don't know how to work with the test suite.
It would be nice if you @MunifTanjim could make a followup PR if you want to add some tests.

Thanks! @pysan3

Please release a new version v0.3 as soon as you are convinced ;)
(Maybe I have to wait till you change type annots for param to :update_layout() to winid?)
And maybe wait till this gets closed?
https://github.com/MunifTanjim/nui.nvim/pull/337#issuecomment-1949205043


Progressive line sample does not seem to match documentation and fails type check

Documentation Is:

[ ] Missing or needed?
[X] Confusing
[ ] Not sure?

Please Explain in Detail...
The progressive line sample (https://www.chartjs.org/docs/latest/samples/animations/progressive-line.html) seem to run, but the code itself does not match the API described by the documentation on https://www.chartjs.org/docs/latest/configuration/animations.html#animation, and TS fails the type check.
Your Proposal for Changes
If it is possible to configure each individual property separately then the type for animation should probably be something along the lines of Record<string, AnimationSpec<TType>> instead
Example
https://www.typescriptlang.org/play?#code/JYWwDg9gTgLgBAbzgYQBYENYBo4EEB2o6MwE+AymAKYDGcAvnAGZQQhwDkNGsAdAFYBnDgG4AsAChJAN0xwaMAB5wAvHAAmEGgFcQVfDF4BzKjACiAGyp6DAIQCeASXUAKAEQh7aTDDcBKOHRBOAAJABUAWQAZZHR8WUFLa30YcSkJGjJBeHVidFU4AG0AXTTM-GyNPIAmApK0q3gwKCppAoBGAAZOhtM4ZtbatQAOHskmaDgXRrhgAp7ZuAAeOC7ukVmAak2AhEk4fpa2zbUAVjgAWjgI4lReKDjNEBcAgCpVsYkD3Jh0XjBtIJUC4EIoAFyzHD2CEDaT0PxpA6w2onODnK43GB3B74J4vODvLqIqq-ar-QHA0EQ4BQmFHarwtL0SSScqVGAQX4WAAi2geJDIHW661ZWRyVAs6HstlMAHcqPoAAoQYAGYJqDlc3n80j4OAAehJfys+CMWLKYsOrVIgIAmgUXApFAEVAA+eRKXiq9RUZQqf1wTpwAD8HsUvG4Pl4gho6Csgl49mMpkVwEUEoAYtAAGpx7RUFxrAIQp0RniGEwwbl5QSmCKmdCOz0-IKmRy431+Xgtwql72+y6rYrJmCK1hgQQuQocewcYo4GBQfNd+wWirwOJEAX4CEELe6yi0JYcCyqqgcd1qPZfODgxD7A5wGD2agQjj4XQAIyoUA4WAfBxUEEqpGG+p74EBv7-je3x8sQuoQj6krSnKCr4MqqowII0GPswrAgBCABy6CETg+qGliVD9CqBizMEqrACQcYWPYcCCAA1sAYDUOoAEaBKUpNs694wY+wBMFMpbPtQcAAIQBhwLYcHAAA+KlhrwijkL8sBUOoux8bhLQwHyeqfLhBzMqJByllpOkwHpBSLvmxJGaYpkaf2yjvEhUoyjA8pKjRWGuQwD70DhcDQiJuHSVQb4fiA35QXxQGCCBYFnpgf58eocHbohAkoQFaEYWqkUHCwbB0taEB2hV-HIUJBnWbMElCbwcVyQpSmqeppb2NpPh6S1FmPsZHnmRZVljQNQ26eoTlLlQoUHBNUB6n2HbeY1fmoUFmGCKFM1hRI9BpDIcieN4sAFBBsooOWQk4NesUvvFnDgeeDUthCr1jXAkrfhYggQoUbgAEp6W4OBuLYFj5jDcBuLaEoWBAspI24ADiLT6Fjip8mAVhYwA8jiJhuPOhmPi2tZYWD-0A4+QMSm+ADEcAQBJ2aclQwgNczv1FO01Q4O0ACcOAAMw4KcOBi3A0vU61lnFHxEV8RAYDbqDMUWZuIDwWQgtsbG8Z-TTBx3kzANWwwpsHNFttjfbJ24e7p2MkAA

It should actually be animations that are configured. A bit surprised it works as animation.
The type of AnimationsSpec<TType> is still lacking though.


Fixed

added package NuGet: NUnit.2.6.4
clear code style
changed unit tests for new interface

While I appreciate the PR for the NUnit NuGet dependency, I'm not fond of having every single line of the project restyled.
Maybe your styling preferences don't match my own, but if you're using this as a dependency in one of your projects it shouldn't matter, really. If you want to conform to some other style guide I'd prefer the project be forked so you can match your own style guide without impacting the existing project.
I'd be perfectly happy to accept a PR with the NuGet package and unit test changes, though. Thanks!


CD warning message is confusing since it refers to function.json

From this issue: https://github.com/projectkudu/AzureFunctionsPortal/issues/366#issuecomment-250917342, the message in the portal is confusing, since it implies that that's how you turn off CI/CD or opt out of the editor lockout issue.

Remove the part of the string that says "You can edit these settings in function.json".
@christopheranderson - produce a link to a doc which describes some of this stuff, that way we don't need to update this message repeatedly.


GT1 is done backwards?

We currently ask: if det(A) is known and we apply a row operation, what's the new determinant?
Would it make more sense to ask for det(A) given that A is the result of a row operation applied to a matrix with known determinant?  This better models how to find determinants with row operations: I want to find det(A), so I apply row operations until eventually I get a matrix of known determinant.

In particular, the equation is now det(C)=det(R)det(A), so we divide to get det(A)=det(C)/det(R). Which is why we divide by 2 ('factor out a 1/2") when we double a row, and multiply by 2 ("factor out a 2") when we halve a row.


Setting custom fonts [regression]

As of #140 it is impossible to set a custom font for the console, since set_custom_font was converted to a method, but has to be called before we could possibly have an instance of the Root console.

Closed via #144.


feat: Add CSRF prevention plugin

Pull Request
JIRA Ticket
CZID-8322
Description
Add CSRF protection to graphQL mesh using @graphql-yoga/plugin-csrf-prevention: https://the-guild.dev/graphql/mesh/docs/plugins/csrf.
Remove CSRF token being passed as header, as this check is now disabled.
Notes
Dependencies
chanzuckerberg/czid-web-private/pull/4049

We need to wait until this PR is merged to that appropriate headers are being sent by the React app.

Developer actions

Containers need to be rebuilt:docker compose down
docker compose build
docker compose up

CSRF header need to be added to GraphiQL if you wish to use the playground:{
  "x-graphql-yoga-csrf": "csrf",
}

Tests
Test that there are no regressions in functionality that uses Rails graphQL schema.  This includes the following:

Pathogen list
Quality control page
User creation

[ ] tested locally
[ ] tested in sandbox

@jacoblerner-czi @saq7 would either of you be able to review this?


doc nit: to_u32_digits doc uses "little-endian order" instead of "least significant first"

Little endian is about byte order, not word order. So the order of the bytes in the u32 itself would be little endian or big endian depending on the platform, but the u32 values themselves are ordered least significant first, not in little-endian order.

Wikipedia's description of endianness supports a broader sense:

It can also be used more generally to refer to the internal ordering of any representation, such as the digits in a numeral system or the sections of a date.

I would accept a PR changing to "least significant first" though, if you find that clearer.


move the translated documentation files to a docs folder

add translation section in Readme
replace multilinks with a  single link to translation section

Will the (../filename) syntax work?

Will the (../filename) syntax work?

It should!
Maybe needs some checks after merge:

Insights -> Community: have a green status
start a navigation from assistive links provided by github (eg in issues or PR).

Awesome proofreading, @davorpa

Awesome proofreading, @davorpa

Reviewing is one of my specialties. I suppouse you are in the middle of changes but there are still 29 suggestions (collapsed in web UI) to be applied :wink:

I think I got them all now

I think that's all...

Will the (../filename) syntax work?

It should!
Maybe needs some checks after merge:

Insights -> Community: have a green status
start a navigation from assistive links provided by github (eg in issues or PR):
Remember, contributions to this repository should follow its **contributing guidelines** and **code of conduct**.

Try links (../README.md#translations) from rendered Github Pages. Maybe would be better  (../#translations) as target, or make a README.md in docs too moving section added in root

ALL RIGHT :rocket:


Please update RPP in conan center

As my current project relies heavily on conan, and coincidentally I am using distinct op in v2.1.0 as git submodule, please conisder updading package in conan.
At the time being, latest version on conan is still v2.0.0. And I've requested update request at conan center.
Let me know if anything I can do to speed up the process.

Hi, @RobinQu ,
To be honest all previous conan/vcpkg updates were done by some other people's, not me 😅
I would try to investigate how to do it

@RobinQu , updated

Awesome!


Failed to execute 'setTransform' on 'CanvasRenderingContext2D': 6 arguments required, but only 1 present.

Version

Phaser Version: 3.70 (but tested also with 3.87)

Operating system: Windows

Browser: CEF (Chromium Embedded Framework): CEF 52 (default browser from Sketchup 2017)

Description
When open that browser I have an error:
Uncaught TypeError: Failed to execute 'setTransform' on 'CanvasRenderingContext2D': 6 arguments required, but only 1 present.
this problem do not invoke in newest version of Sketchup Browser (like CEF 88 and above)

Example Test Code
in the config file I am using Phaser.CANVAS, because that renderer is better for my case (using phaser to visualize pdf so thin lines are necessary)
when Phaser.Auto then it is working but that renderer isn't good in my case
Additional Information
I have solved that issue by changing line
return t.setTransform(this),t}
into
return t.setTransform(this.a, this.b, this.c, this.d, this.e, this.f),t}
not sure if it is safe solution, but it's working ;P
maybe in future releases you can add something like this.
ps. very very great library!!!

Hiya - how old is this device/set-up you're testing? Because setTransform has allowed you to pass a matrix object to it for years now! See https://developer.mozilla.org/en-US/docs/Web/API/CanvasRenderingContext2D/setTransform#browser_compatibility

yeees, that is pretty old browser, from 2017 probably.
Full situation:
We are developing plugin for SketchUp (app for architects) and using phaser to have some kind of PDF viewer.
SketchUp has own browser based on CEF.

Of course we wish that everybody use the newest version of SketchUp, but reality is not like that :P
So we try to have compatibility with old SketchUp versions like this from 2017.
And that why here we have problem ;/
in worst scenario I will just update the source code each time :P

If you want to submit a PR then I don't mind reverting to the old way of doing it for the v3.88 release. This will be one of our final v3.x releases and we won't maintain this going forward for 4.x, but I don't mind doing it here.


Login failed - 401 Unathorized on callback

After going through the log in process we get a successfully response from https://login.microsoftonline.com//***/login
We then are asked if we want to stay signed in. After selecting an option we're redirected to https://ourwebsite.com/oauth2/callback?code=0.AXUA....# which gives a 401 Unauthorized with a Login failed response.
We have a Django app hosted on an Azure App Service behind a private endpoint accessed through an Application Gateway. We're using django_auth_adfs for authentication.
To get the redirects working we've added three Rewrites to our Application Gateway.

Sets request header X-Forwarded-Proto to https
Sets location that matches (.)(redirect_uri=https%3A%2F%2F)..azurewebsites.net(.)$ to {http_resp_Location_1}{http_resp_Location_2}{var_host}{http_resp_Location_3}
Sets location that matches (https://)..azurewebsites.net(.*)$ to https://{var_host}{http_resp_Location_2}

The flow works locally, so I'm not sure if there is setting on the Django side I need to add for production with our set up or if I've possibly just misconfigured something on the Azure side. I'm currently stuck and am hoping someone here has run in to this issue before or has some ideas of where to look for issues. Any help would be greatly appreciated and please let me know if I can provide any more details.
relevant settings.py below:
AUTHENTICATION_BACKENDS = (
    'django_auth_adfs.backend.AdfsAuthCodeBackend',
    'django_auth_adfs.backend.AdfsAccessTokenBackend',
)

SECURE_PROXY_SSL_HEADER = ('HTTP_X_FORWARDED_PROTO', 'https')

INSTALLED_APPS = [
    ...
    'django_auth_adfs',
	...
]

AUTH_ADFS = {
    'AUDIENCE': client_id,
    'CLIENT_ID': client_id,
    'CLIENT_SECRET': client_secret,
    'CLAIM_MAPPING': {'first_name': 'given_name',
                      'last_name': 'family_name',
                      'email': 'upn'},
    'GROUPS_CLAIM': 'roles',
    'MIRROR_GROUPS': True,
    'USERNAME_CLAIM': 'upn',
    'TENANT_ID': tenant_id,
    'RELYING_PARTY_ID': client_id,
}

MIDDLEWARE = [
    ...
    'django_auth_adfs.middleware.LoginRequiredMiddleware',
]

LOGIN_URL = "django_auth_adfs:login"
LOGIN_REDIRECT_URL = "/"

relevant urls.py below:
urlpatterns = [
	...
    re_path(r'oauth2/', include('django_auth_adfs.urls')),
]

Please post logs, you can find a tutorial on how to set it up here: https://django-auth-adfs.readthedocs.io/en/latest/troubleshooting.html

Closing from lack of response. Feel free to reopen :slightly_smiling_face:

Apologies for delayed response. We're having a little trouble getting the debug output in the Azure App Service. I'm working on it now and will update as soon as I have it.


Give ability to place contracts in dedicated project

As a developer developing contracts
I would like to package tests into JAR
so that it is possible to execute in other project.
Currently running tests that are residing in JAR is not possible.
This is a fix that allow to read resources from JAR.
This is enough to make overall approach to work.

@oleksiyp Please sign the Contributor License Agreement!
Click here to manually synchronize the status of this Pull Request.
See the FAQ for frequently asked questions.

@oleksiyp Thank you for signing the Contributor License Agreement!

Can you please create a test for this?

Closing due to lack of feedback


[backport] Update supported MPI list

Backport of #7086

[automatic post] Jenkins, test this please.

Jenkins CI test (for commit e8e51204cef65a5112d7a4fbce9eb6b2dbe33ead, target branch v6) failed with status FAILURE.


redesigned tabs with dropdowns switch filters and carousel

The toggles don't have enough color difference between switched on and off. Could you change the off color to white or black?
There is a missing < on the vegetarian label

The toggles don't have enough color difference between switched on and off. Could you change the off color to white or black?
There is a missing < on the vegetarian label


Feature request: Allow settings profiles to be linked to specs!

ok :D don't mind the mess i goofed in setup and forgot the feature that i'm wanting to suggest hadn't made it through :) busy man and all LOL

The image contains reference to the request
i would love it if gUI had the capability that bartender does when it comes to laying out frames and such for different specs.
this is due to the factor of not all spec UI's will be the same for the person needing the adjusting.

Would definitely be a useful feature. Being both tank and dps, and previously healer and dps, I totally understand the need for instantly different bar layouts and such when changing specs in the middle of a raid. :)


uptick transfer -- cannot add a memo

This works:
uptick transfer someaccount 1.00 BTS
This does not:
uptick transfer someaccount 1.00 BTS "some memo"
It seems to crap out here:
... wallet.py", line 171, in getPrivateKeyForPublicKey
bitshares.exceptions.KeyNotFound
I am using version 0.2.1. It was the same thing in 0.2.0
I really want to be able to include a memo. Much appreciated if you can fix this!

That error usually means you do not have the private memo key which is required also when doing a transfer with a memo. New versions of pybitshares show the actualy key missing in the assert.
Also, uptick permissions <account> will show the distinct memo key too

That was it. Not sure how I missed that. Problem solved. Thank you!


Adding new files

We should add a new file to the folder playground named "test2.py". The file should contain a for-loop printing out the numbers between 0 and 100 reverse.

This message was generated by git-bob 0.1.0, an AI-based assistant.
I created a branch with a potential solution here. I will attempt to send a pull-request.

This message was generated by git-bob 0.1.0, an AI-based assistant.
I created a branch with a potential solution here. I will attempt to send a pull-request.

This message was generated by git-bob 0.1.0, an AI-based assistant.
I created a branch with a potential solution here. I will attempt to send a pull-request.


Unable to get injection to work with macOS app.

I've downloaded the Injection app and tried to use it with a newly created macOS project. I created the main.m file, and used the macOS menu patch option to patch it. main.m was successfully patched.
The dummy project consists of a view and a label, and all I'm trying to do is change the text on the table to see this reflected in the running application. In order to do this, I've saved the file, then used the keyboard shortcut to try to inject the update.
The result is a window displaying the error: Injection Error, simulator is not running.
MacOS 10.13
Xcode Version: 9.2
Derived data location is set to default.

Does Injection connect to the app? Is anything logged. If the app is sandboxed it will need network entitlements for this connection.

No, nothing is logged.
I've tried setting App Sandbox to NO, and I've also tried setting com.apple.security.network.server and com.apple.security.network.client to YES. Still the same problem.

Is -DDEBUG defined?

I’m using Swift, and the settings are the Xcode’s defaults. I looked around build settings and there were a number of debug settings, but no DDEBUG.

On Feb 20, 2018, at 12:58 PM, John Holdsworth<EMAIL_ADDRESS>wrote:
-DDEBUG defined

Look for Preprocessor Macros and add DEBUG=1 is it’s not there already. There really should be something logged.

It was set to that by default. So, yes, DEBUG=1 defined in Preprocessor Macros...

On Feb 20, 2018, at 1:17 PM, John Holdsworth<EMAIL_ADDRESS>wrote:
Look for Preprocessor Macros and add DEBUG=1 is it’s not there already. There really should be something logged.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/johnno1962/InjectionApp/issues/35#issuecomment-367069162, or mute the thread https://github.com/notifications/unsubscribe-auth/ACaom9WublLcIEi7XCrBfpZlTgiheENfks5tWwxOgaJpZM4SMOZE.

what are the contents of main.m?

// From here to end of file added by Injection Plugin //
#ifdef DEBUG
#define INJECTION_PORT 31452
static char _inMainFilePath[] = FILE;
static const char *_inIPAddresses[] = {"<IP_ADDRESS>", "<IP_ADDRESS>", 0};
#define INJECTION_ENABLED
#import "/tmp/injectionforxcode/BundleInjection.h"
#endif

On Feb 20, 2018, at 1:23 PM, John Holdsworth<EMAIL_ADDRESS>wrote:
what are the contents of main.m?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/johnno1962/InjectionApp/issues/35#issuecomment-367070877, or mute the thread https://github.com/notifications/unsubscribe-auth/ACaom-trXUIFBIrJNYkkren-poG0HRijks5tWw2pgaJpZM4SMOZE.

Can you try https://github.com/johnno1962/InjectionIII please. I’d rather support the newer version.

Absolutely. I’d love to use this and I really appreciate your work putting it out there and supporting it. Thank you!
I’ll give the new version a shot and see what happens.

On Feb 20, 2018, at 1:29 PM, John Holdsworth<EMAIL_ADDRESS>wrote:
Can you try https://github.com/johnno1962/InjectionIII https://github.com/johnno1962/InjectionIII please. I’d rather support the newer version.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/johnno1962/InjectionApp/issues/35#issuecomment-367072775, or mute the thread https://github.com/notifications/unsubscribe-auth/ACaom7uJk0SfPmi8aD00UPKTVNffsdErks5tWw77gaJpZM4SMOZE.

So I downloaded and tried the new app. Same result - an error message saying that the simulator is not running.

And still nothing logged.

Did you add Bundle(path: "/Applications/InjectionIII.app/Contents/Resources/macOSInjection.bundle")?.load()
to your appDidInit?

So that does work. I am no connected and it's logging. The logs suggest its' working correctly, but I'm not seeing a change in the app.
Log outputs are as follows:
Injection connected, watching /Users/foo/Documents/Programming/InjectionTest/... Compiling /Users/foo/Documents/Programming/InjectionTest/InjectionTest/ViewController.swift Loading /tmp/eval1.dylib. (Ignore any duplicate class warning) objc[6194]: Class _TtC13InjectionTest14ViewController is implemented in both /Users/foo/Library/Developer/Xcode/DerivedData/InjectionTest-ewblganvhtibaobplpuewjhyqkde/Build/Products/Debug/InjectionTest.app/Contents/MacOS/InjectionTest (0x100005e88) and /tmp/eval1.dylib (0x105980360). One of the two will be used. Which one is undefined. Injected 'InjectionTest.ViewController', vtable length: 64

That’s what it looks like when it’s working. You’ll need to puzzle out what is happening using the limitations in the README like you can’t inject structs, final classes, possibly even using whole module optimisation doesn’t work. Start simple and work your way up.

Ok, thanks for the feedback. Here’s the problem I have: I’ve simply created a blank macOS app template project in Xcode and placed a text label in the middle of the default view. I’ve created an IBOutlet for the label in the sole view controller in the project. I assign it a value in viewDidLoad. When I change the value, I get log messages suggesting that the new value is being injected, but no change. There are no structs or final classes.

On Feb 20, 2018, at 5:07 PM, John Holdsworth<EMAIL_ADDRESS>wrote:
That’s what it looks like when it’s working. You’ll need to puzzle out what is happening using the limitations in the README like you can’t inject structs, final classes, possibly even using whole module optimisation doesn’t work. Start simple and work your way up.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/johnno1962/InjectionApp/issues/35#issuecomment-367137290, or mute the thread https://github.com/notifications/unsubscribe-auth/ACaomyo5lGE9OfQ5mFpg3ZKjlL9byF7Vks5tW0IegaJpZM4SMOZE.

Is viewDidLoad being called again?

Only on the initial compile. It’s not called on changes.
Sent from my iPhone

On Feb 20, 2018, at 6:39 PM, John Holdsworth<EMAIL_ADDRESS>wrote:
Is viewDidLoad being called again?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

If it’s not called again you need to look at an @objc injected() (which should be called when the class is injected) calling it when code is injected so you can see your code changes take effect.

I've tried several variations, including an @objc injected() method. injected() is not called either. Here is all of the relevant code:
ViewController:
class ViewController: NSViewController {

    @IBOutlet weak var label: NSTextField!

    override func viewDidLoad() {
        super.viewDidLoad()
        print("Executing viewDidLoad\n")
        setup()
        // Do any additional setup after loading the view.
    }

    func setup() {
        self.label.stringValue = "Hello!"
    }

    @objc func injected() {
        print("Executing injected\n")
        viewDidLoad()
    }
}

App delegate:
@NSApplicationMain
class AppDelegate: NSObject, NSApplicationDelegate {

    func applicationDidFinishLaunching(_ aNotification: Notification) {
        Bundle(path: "/Applications/InjectionIII.app/Contents/Resources/macOSInjection.bundle")?.load()
        // Insert code here to initialize your application
    }

    func applicationWillTerminate(_ aNotification: Notification) {
        // Insert code here to tear down your application
    }

}

Also, App Sandbox is set to NO

Can you try on thing? Make an outlet from you AppDelegate to the ViewController to see if injected() starts working? Objects need to be findable from a memory sweep starting at AppDelegate.

Otherwise you can subscribe to the INJECTION_BUNDLE_NOTIFICATION to have you code called.


Clean up custom base class

(Second part of the points listed in https://github.com/nlohmann/json/pull/3110#issuecomment-1229141478, the rest is done in a different PR to prevent mixing of separate issues / features)

Warn users about potential conflicts with newer versions, i.e., base members should avoid generic names to avoid clashes with future member additions to basic_json.
(Run reuse.)

Also adds a new method as_base_class to make it easier to access members of a custom base class shadowed by nlohmann::basic_json

Pull request checklist
Read the Contribution Guidelines for detailed information.

[x]  Changes are described in the pull request, or an existing issue is referenced.
[x]  The test suite compiles and runs without error.
[x]  Code coverage is 100%. Test cases can be added by editing the test suite.
[x]  The source code is amalgamated; that is, after making changes to the sources in the include/nlohmann directory, run make amalgamate to create the single-header files single_include/nlohmann/json.hpp and single_include/nlohmann/json_fwd.hpp. The whole process is described here.

Coverage: 100.0%. Remained the same when pulling ca8a0594b240169ba7a13c1a7bf0d0d64c1356a5 on barcode:clean_up_custom_base_class into 4c6cde72e533158e044252718c013a48bcff346c on nlohmann:develop.

Work on this PR is done and it only needs a review.


Ability to store data on layout items

I had a use case where I needed to attach certain data to each grid item. The issue is that custom data points disappear after every layout change (happens in utils.js/cloneLayoutItem). I added a special data point, data, which will be preserved.

@oguzgelal thank you for your contribution! But can we solve this problem by storing data in some object like this:
const store = {
  'id1': { /* some data here */ },
  'id2: { /* some data here */ },
}

and getting the data by GridItem id?


Do not show the additional file/errors table when there's 1 file with many errors

E.g. this compile ending:
Found 2 errors in 1 file.

Errors  Files
     2 src/index.ts:14

Now shows as:
Found 2 errors in 1 file: src/index.ts:14

Some unit test failures lit up

OK, I'm going to merge this as it has all feedback accepted, and I'd like to rebase https://github.com/microsoft/TypeScript/pull/47126 on it


Remove dependency on get_or_set for compose.stream_name.

Change references of compose.stream_name to new get/set functions.

Automated message from Dropbox CLA bot
@wangjames, it looks like you've already signed the Dropbox CLA. Thanks!

@showell can you review this one?
The test failures are something that was failing on master, so likely unrelated.

@showell what are your thoughts on this change?  Given all the frontend refactoring, we'd need to basically redo it before merging due to merge conflicts, but I guess the question is whether we feel that having replaced the get_or_set pattern this way makes the code cleaner and thus we should do that, or should we just abandon the concept?
Regardless, I'm closing this PR under the theory that it'll be easier to redo the changes than merge this exactly, since all 5 files it touches merge conflict :)


python 3 support

Hi Allen,
We are hoping to use your PPCA implementation for a toolbox to visualize high dimensional data.  I'd like to submit a small PR to add python3 support, but wanted to clarify something first. In the middle of the implementation, you import IPython, is that on purpose, or some debugging code left in on accident? Thanks!
https://github.com/allentran/pca-magic/blob/master/ppca/_ppca.py#L110
Andy

Apologies for the late response, that IPython import was leftover debug code for sure, it's removed now.


fix issue #27985

The dresult variable may be an IndexedSlices object, which does not have a _copy method.
Link to the issue: https://github.com/tensorflow/tensorflow/issues/27985

I signed it!

@alextp yeah let me briefly look into that

I managed to reproduce the problem with a small self-contained script:
#!/usr/bin/env python3
# -*- coding: utf-8 -*-

import tensorflow as tf
import tensorflow.contrib.eager as tfe

config = tf.ConfigProto()
config.gpu_options.allow_growth = True

tf.enable_eager_execution(config=config)

shape = (5, 5)
initializer = tf.random_uniform_initializer(-1.0, 1.0)
var = tfe.Variable(initializer(shape), name='tensor')

with tf.GradientTape() as tape:
        a = tf.gather(tf.gather(var, [0, 1]), [0, 1])
        b = tf.gather(tf.gather(var, [2, 3]), [0, 1])

        x = tf.reshape(tf.concat((a[0], a[1]), axis=0), [1, -1])
        y = tf.reshape(tf.concat((b[0], b[1]), axis=0), [1, -1])

        r = tf.einsum('ij,ij->i', x, y)

g = tape.gradient(r, [var])

Here's the output - I'll commit a unit test shortly.
$ ./fun.py
2019-04-19 20:27:55.511171: I tensorflow/core/platform/cpu_feature_guard.cc:141] Your CPU supports instructions that this TensorFlow binary was not compiled to use: AVX2 FMA
2019-04-19 20:27:55.580302: I tensorflow/stream_executor/cuda/cuda_gpu_executor.cc:964] successful NUMA node read from SysFS had negative value (-1), but there must be at least one NUMA node, so returning NUMA node zero
2019-04-19 20:27:55.580656: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1432] Found device 0 with properties:
name: TITAN X (Pascal) major: 6 minor: 1 memoryClockRate(GHz): 1.531
pciBusID: 0000:02:00.0
totalMemory: 11.91GiB freeMemory: 5.75GiB
2019-04-19 20:27:55.580679: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1511] Adding visible gpu devices: 0
2019-04-19 20:27:55.921738: I tensorflow/core/common_runtime/gpu/gpu_device.cc:982] Device interconnect StreamExecutor with strength 1 edge matrix:
2019-04-19 20:27:55.921768: I tensorflow/core/common_runtime/gpu/gpu_device.cc:988]      0
2019-04-19 20:27:55.921779: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1001] 0:   N
2019-04-19 20:27:55.921949: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1115] Created TensorFlow device (/job:localhost/replica:0/task:0/device:GPU:0 with 5526 MB memory) -> physical GPU (device: 0, name: TITAN X (Pascal), pci bus id: 0000:02:00.0, compute capability: 6.1)
Traceback (most recent call last):
  File "./fun.py", line 25, in <module>
    g = tape.gradient(r, [var])
  File "/home/anaconda/anaconda3/lib/python3.6/site-packages/tensorflow/python/eager/backprop.py", line 901, in gradient
    output_gradients=output_gradients)
  File "/home/anaconda/anaconda3/lib/python3.6/site-packages/tensorflow/python/eager/imperative_grad.py", line 64, in imperative_grad
    output_gradients)
  File "/home/anaconda/anaconda3/lib/python3.6/site-packages/tensorflow/python/framework/ops.py", line 858, in grad_fun
    return [dresult._copy(device_name=self_device)]
AttributeError: 'IndexedSlices' object has no attribute '_copy'

@alextp this should do the trick - what do you think?

@alextp link to the test: https://github.com/pminervini/tensorflow/blob/master/tensorflow/python/framework/ops_test.py#L161
Is there a way to enforce this to run on GPU?

Use the  @test_util.run_gpu_only decorator

@alextp done!

@alextp there was one line exceeding 80 chars in ops_test.py, it should be fine now

@alextp mmm where is the problem?

Nothing wrong, the build is just currently broken.


Add models and clean up

The social media icons and payment icons will be added as models: this allows for a superuser to change them and even add more. We also do some clean up of the code.

Instead of turning social media icons and payment icons into models, we change features and testimonials into models.


net-vpc should allow for the definition of subnets with purpose=PRIVATE

net-vpc can create subnets with purpose=PRIVATE_SERVICE_CONNECT, which are consumed by Service Attachments.
PSC forwarding rules require instead a subnet with purpose=PRIVATE.

Is this issue being worked on or can I contribute to this change ?

I think this a stale issue. The net-vpc module already supports PSC subnets through the subnets_psc variable.
@simone

Obsoleted by #1264


Dates presented are off by one in relation to the date of the receipt

Looks like something in the client side based on the API response 🤔

Probably caused by a Date.parse() in GMT and conversion to negative timezone.

The decoding is done using new Date(str) not the parser… very bizarre… starting to investigate now. Thanks for the heads up @fgrehm!

@Irio nailed it:
> new Date('2015-10-05');
< Sun Oct 04 2015 21:00:00 GMT-0300 (BRT)

I'm gonna drop the Date type and use an improvised one just with regular Int numbers… ugly and dirty but… does anyone have a better idea?

new Date(dateString) does an implicit call to Date.parse(dateString).
new Date(dateString + ' (BRT)')

should solve the bug.

Yay! (BRT) didn't work, but you pointed me to the right direction:
> new Date("2015-10-05T12:00:00-03:00")
< Mon Oct 05 2015 12:00:00 GMT-0300 (BRT)


Support for command options

Hi,
Thank you for this awesome package.
I just wanted to ask if you are planning to add support for command options  as well via variables soon.
The variables work perfectly when used for command arguments but not for options.
We have a scenario in which we are using command options to take start date and end date.
Sample command:
command:test-command {--startDate=default} {--endDate=default}

Now in config, if we simply add following:
'Test Command' => [
            'run' => 'command:test-command {--startDate=default} {--endDate=default}',
            'type' => 'primary',
            'group' => 'Test'
        ],

It takes input value for --startDate and --endDate, but we also need to append prefix --startDate= and --endDate= with date values to make it work.

Also we can't use field => "date" in this scenario, which is usable if we would have been using arguments.

@abdulwahid
We support options to configure them in your example, use the following code
This will create a log:demo --startDate=2022-04-19 --endDate=2022-04-21 command
'Demo Log' => [
    'run' => 'log:demo --startDate={startDate} --endDate={endDate}',
    'type' => 'primary',
    'group' => 'Text',
    'variables' => [
        [
            'label' =>  'startDate',
            'field' => 'date',
        ],
        [
            'label' =>  'endDate',
            'field' => 'date',
        ]
    ],
],

@stepanenko3
Thanks for your quick response.
But this combination doesn't seem to be possible in Laravel command signature.
Every option or argument must be enclosed in curly braces, we can't define --startDate= without curly braces in command signature.
The example you provided throws error:
The "--startDate" option does not exist.

because it tries to find {--startDate} in command signature which we don't have, we have it without braces --startDate.

@stepanenko3 Can I create a PR to for this support?

@abdulwahid,
Yes, it will be great if you open a PR

@stepanenko3
I am unable to push my branch because of permissions.
ERROR: Permission to stepanenko3/nova-command-runner.git denied to abdulwahid.
fatal: Could not read from remote repository.

In src/Dto/CommandDto.php:
I changed from:
$command->setParsedCommand(
                            str_replace('{'.$variable['label'].'}', $variable['value'], $command->getParsedCommand() )
                        );

to:
if (strpos($variable['label'], '--') !== false) {
                        $variableName = explode('=', $variable['label'])[0];
                        $command->setParsedCommand(
                            str_replace('{'.$variable['label'].'}',  $variableName . '=' .$variable['value'], $command->getParsedCommand() )
                        );

                    } else {
                        $command->setParsedCommand(
                            str_replace('{' . $variable['label'] . '}', $variable['value'], $command->getParsedCommand())
                        );
                    }

Hi @stepanenko3 ! Any plans to add this or adjust the repo permissions so a PR can be made?

@nathan-io, @abdulwahid I released new version 4.0.11, which supports this


Performance Issue: Slow File Loading with Multiple Hyperlinks

Describe the bug
Dear orgmode.nvim development team,
I am a user of lunavim with the integrated orgmode.nvim plugin, and I have encountered a performance issue that I would appreciate your assistance and advice on.
When using multiple hyperlinks in my org files, I have noticed that file loading becomes extremely slow, and my CPU usage is also high. I have tested the performance with a small number of hyperlinks (approximately 10 or less), and it functions normally. However, once the number of hyperlinks exceeds a certain threshold, the performance issue arises.
Here is an example of one of the hyperlinks (:e ~/test.org):
[[https://anvilproject.org/guides/content/creating-links][link]]
If I have the same example hyperlink repeated more than 14 times in the file, the CPU usage spikes and the file loading becomes significantly slower.
I have also experimented with the mkdnflow.nvim plugin, which renders markdown hyperlinks, and I have noticed that it does not encounter any performance issues even when the same link is repeated for 100 lines.
Additionally, I have tested the minimal configuration provided by your team (minimal_init.lua) by running nvim -u minimal_init.lua, and I encountered the same performance issue.
I would appreciate any suggestions or solutions you can provide to help resolve this performance issue. Thank you for your assistance!
Steps to reproduce
Open org file by executing the command :e ~/test.org in your editor.
Create a hyperlink with the following format:
[[https://anvilproject.org/guides/content/creating-links][link]].
Copy and paste this hyperlink more than 10 times in your org file.
Expected behavior
When there are multiple hyperlinks, the reading of an Org file should be smooth, similar to how the mkdnflow.nvim plugin reads Markdown files.
Emacs functionality
No response
Minimal init.lua

-- Enter your minimal_init.lua here
vim.cmd([[set runtimepath=$VIMRUNTIME]])
vim.cmd([[set packpath=/tmp/nvim/site]])

local package_root = '/tmp/nvim/site/pack'
local install_path = package_root .. '/packer/start/packer.nvim'

local function load_plugins()
  require('packer').startup({
    {
      'wbthomason/packer.nvim',
      { 'nvim-treesitter/nvim-treesitter' },
      { 'kristijanhusak/orgmode.nvim', branch = 'master' },
    },
    config = {
      package_root = package_root,
      compile_path = install_path .. '/plugin/packer_compiled.lua',
    },
  })
end

_G.load_config = function()
  require('orgmode').setup_ts_grammar()
  require('nvim-treesitter.configs').setup({
    highlight = {
      enable = true,
      additional_vim_regex_highlighting = { 'org' },
    },
  })

  vim.cmd([[packadd nvim-treesitter]])
  vim.cmd([[runtime plugin/nvim-treesitter.lua]])
  vim.cmd([[TSUpdateSync org]])

  -- Close packer after install
  if vim.bo.filetype == 'packer' then
    vim.api.nvim_win_close(0, true)
  end

  require('orgmode').setup()

  -- Reload current file if it's org file to reload tree-sitter
  if vim.bo.filetype == 'org' then
    vim.cmd([[edit!]])
  end
end

if vim.fn.isdirectory(install_path) == 0 then
  vim.fn.system({ 'git', 'clone', 'https://github.com/wbthomason/packer.nvim', install_path })
  load_plugins()
  require('packer').sync()
  vim.cmd([[autocmd User PackerCompileDone ++once lua load_config()]])
else
  load_plugins()
  load_config()
end

Screenshots and recordings
No response
OS / Distro
Arch Linux on WSL
Neovim version/commit
0.9.0
Additional context
No response

Hi @ESSO0428, thanks for the report. Did you update nvim-orgmode lately? This might	be due to the parsing issue reported in 550 and 570. There were recent changes to address this. Please update nvim-orgmode and check if the issue persists :+1:

Thank you very much for your response. I have followed the instructions and updated to the latest version. However, I am still encountering performance issues. I have tested it on Arch Linux on WSL, and I'm experiencing subpar performance both in Lunavim and with nvim -u minimal_init.lua.
I have also tested on another Linux distribution, Ubuntu, within my WSL environment using the same minimal_init.lua configuration, and I still observe slow performance. Furthermore, I tested the performance using Lunavim, where I installed the orgmode plugin using lazy loading. Interestingly, when using Lunavim (an nvim pre-configured version that combines nvim with their configuration files and environment variables and utilizes lazy loading for managing packages), the performance improved significantly when loading the example org file. Hyperlinks with more than 60 lines worked smoothly, and I was able to navigate in normal mode using hjkl without any issues. However, there is still some latency when entering insert mode for editing.
PS: The performance has improved on the Ubuntu on WSL with Lunavim installed on my current PC. However, it is still important to explore other possible solutions to address the performance issues. Thank you once again for your response, and I appreciate your understanding.

This issue should be resolved on latest master. If the problem persists, please open up a separate issue. Thanks.

This issue should be resolved on latest master. If the problem persists, please open up a separate issue. Thanks.

Thank you for your response and for the efforts to address this issue. I've updated to the latest master as advised and can confirm that the performance issues when reading org files with many hyperlinks have indeed been resolved. Your support and the team's dedication to improving the experience for all users are truly appreciated.
Thanks!!!


[FIX] Fix class naming

Fix the class namings as pointed out in #1787

Nothing, let me merge the PR!


Error : chessboard was not found in './capture_0/0_ProjectorImg8.png'

Hi,
I am now doing a camera simulation project. I rendered some images with ray tracing method.
Aim is to simulate camera and projector, a finge projection system.
I use a chess board to calibrate the virtual camera and projector.
Your method seems pretty good. However, it does not work on my rendered images.

This is an example form my application.

This is the command I used: ""python3 ../calibrate.py 768 1024 9 11 10 1 -black_thr 80 -white_thr 45".
And this is the terminal output:
Searching input files ...
'./capture_0' was found
Calibrating ...
patch size : 25
checking './capture_0'
chessboard  './capture_0/0_ProjectorImg8.png'
Error : chessboard was not found in './capture_0/0_ProjectorImg8.png'
I do not know why this happened. Could you please give some advice? Thanks in advance!

I made a mistake, names of these sample images were not correctly sorted.