[Question] TypeError: 'NoneType' object is not callable in Rendering Fetch Environments

Hi,
I'm getting this error at the end of rendering the Fetch environments https://github.com/Farama-Foundation/Gymnasium-Robotics in "human" mode:
Exception ignored in: <function WindowViewer.del at 0x7fb4ea7d2680>
Traceback (most recent call last):
File "miniconda/envs/gym/lib/python3.7/site-packages/gymnasium/envs/mujoco/mujoco_rendering.py", line 335, in del
File "miniconda/envs/gym/lib/python3.7/site-packages/gymnasium/envs/mujoco/mujoco_rendering.py", line 328, in free
TypeError: 'NoneType' object is not callable
I'm able to render the entire scene but when the program closes I get this error. Would appreciate more insight into whether it is a glfw based issue, mujoco environment based issue, or another package, thanks!

Can you share the code you are using to replicate the issue?
Also, we are working in a similar issue in that comes from the mujoco renderer implemented in Gymnasium https://github.com/Farama-Foundation/Gymnasium/issues/325

Sure, here is the code snippet:
`
import gymnasium as gym
env = gym.make('FetchReach-v2', render_mode="human")
observation, info = env.reset(seed=42)
for _ in range(100):
action = env.action_space.sample()  # this is where you would insert your policy
observation, reward, terminated, truncated, info = env.step(action)
if terminated or truncated:
observation, info = env.reset()
env.close()
`
Working on:
Ubuntu 18.04
mujoco 2.3.2
gymnasium-robotics 1.2.1
python 3.7.16

This seems to have been fixed in https://github.com/Farama-Foundation/Gymnasium/issues/438 , and has been merged into the main gymnasium repo. Any idea it will be updated in a new release @rodrigodelazcano?

@aalmuzairee can you try using the main git version of Gymansium.

@aalmuzairee yes it will be updated once Gymnasium makes the next release. As @Kallinteris-Andreas mentioned if you can check that it works with the source code of Gymasaium that would be great

Seems to be working for me, thank you!

Hi @rodrigodelazcano @Kallinteris-Andreas,
It seems that it wasn't working as ideally as I expected.
In this code:
import gymnasium as gym

# env = gym.make('CartPole-v1', render_mode="rgb_array")
env = gym.make('FetchReach-v2', render_mode="rgb_array")
observation, info = env.reset(seed=42)

for i in range(2):
   action = env.action_space.sample()  # this is where you would insert your policy
   observation, reward, terminated, truncated, info = env.step(action)
   if terminated or truncated:
      observation, info = env.reset()

   # Render the rgb_arrays
   if i % 1 == 0:
      print("Frame", i , ":", env.render())
      env.close()
env.close()

When I render the frames, this is the output for the
CartPole-v1:
Frame 0 : [255 255 255]
Frame 1 : [255 255 255]
Frame 2 : [255 255 255]
Frame 3 : [255 255 255]

any Fetch Environment (FetchReach-v2 here):
Frame 0 : [114 218 145]
Frame 1 : [0 0 0]
Frame 2 : [0 0 0]
Frame 3 : [0 0 0]

When rendering the CartPole environment, the frames are normal even after calling "env.close()" after rendering. However, for the fetch environments, this code causes every frame after the first one to be completely black (array of zeros). This is caused by the close() function in each environment. The CartPole uses PyGame to close the viewer, while the Fetch environments use the mujoco_rendering.py file to close. Any ideas on how to make the behaviour similar to the CartPole environment? Appreciate your help.

You are using close incorrectly, you are supposed to close at the very end not in every step

I see, but the problem is it is used in this way in https://github.com/Farama-Foundation/Gymnasium/blob/main/gymnasium/wrappers/monitoring/video_recorder.py#L148.
Every video recording wrapper ( From Gymnasium or SB3  ), calls the "close()" function from video_recorder.py to save the video, which also closes the running env. This causes trouble when a user it trying to record multiple videos from one agent.

The renderer is supposed to be reopened after each reset()

Are you able to get more than one video from the same agent using any of the video wrappers above on the Fetch Environment?

What do mean "from the same agent" the policy should be irrelevant here, show us how you use the video_recorder

Sure thing, here is an example using SB3:
(make sure to install SB3 > 2.0 so that it supports gymnasium, you can do that with:
pip install "stable_baselines3>=2.0.0a1" --upgrade)
from stable_baselines3 import PPO
from stable_baselines3.common.monitor import Monitor
from stable_baselines3.common.vec_env import DummyVecEnv, VecVideoRecorder
import gymnasium as gym

env_id = "FetchReach-v2"

def make_env():
    env = gym.make(env_id, render_mode="rgb_array")
    env = Monitor(env)
    observation, info = env.reset(seed=42)
    return env

env = DummyVecEnv([make_env])
env = VecVideoRecorder(env, f"videos", record_video_trigger=lambda x: x % 500 == 0, video_length=50)

model = PPO("MultiInputPolicy", env, verbose=1)

model.learn(total_timesteps=2000)

You should now have four videos in your "videos" folder, only the first one of them is a normal video, the others are all black. Please let me know if you have a different results, thanks.

Does the same problem persist with env_id='Hopper-v4'

I'm not able to run Hopper-v4 because of a mujoco-xml-versioning error, however I'm able to run 'Ant-v4' and it works normally, all videos are good. Hope this helps.

well then this is unrelated to the original issue, i am familiar with how franka envs render

You're right, this is a bit different from the original issue. I found a hacky fix for it for now, appreciate your help.

Hey @aalmuzairee was your issue solved?

Hi @rodrigodelazcano, yes thank you.


Tokens are not propagated to the parent scopes

This prevents nested scopes from invalidating dependent entries.

@sebastienros Any updates on this one?

c.f. https://github.com/aspnet/Caching/pull/168


Add 7.8 images

Oh, heh, I guess we did this at the exact same time. I didn't notice the notification before merging. Sorry!

Wow, spooky. Thank you though!


Add initial CMake file

Added a primitive CMake file to build a library. Actually globbing is not ideal (see here but it can be improved later by swapping with explicit source filenames.
I'm doing this to build the SDL simulator in Windows. I'll detail it on its own PR.
Also fixes a wrong include path.

Thanks!


Swap inspect.getmro() for mro attribute

inspect.getmro() maps to reading __mro__ (__mro__ docs), so use that for clarity and a slight performance improvement.

coverage: 100.0%. remained the same
when pulling ac936bfcfed05c7ec87dca80494a177b7533f52a on adamchainz:avoid_inspect
into ced294de83544e77b46846931be4efe03d5dce28 on django-import-export:main.


Can you implement a way to pass --target via ~/.cargo/config?

I'm trying to get cross-compile working, from x86_64 to armv7.
While it's possible to setup a linker specificly per target in the cargo config file, it's not possible to do that for what would be --target = armv7-unknown-linux-gnueabihf
Why is this a good idea? To get rust/cargo based cross compile out of the box for distros. Gentoo for instance uses a handcrafted cargo/config file for every package out there, but sticks to the simple rustc command for compiling stuff, when it has to be rustc -C --target = armv7-unknown-linux-gnueabihf. If passing that --target via the config file, it is possible to enable cross compile without much hassle.
Thanks :-)

I'm not sure I understand.  The default target can be set via the build.target key in .cargo/config.  If you are compiling without cargo, it sounds like this is a request for Gentoo?

Without more information, I don't think this is actionable.  If you can maybe provide more detail, feel free to reopen.

this was fixed in the meantime, I forgot to close :-S


Package this as an rpm

I've just been trying this out on Silverblue 34. Happily enough it works, which means VS Code is actually viable in the Toolbox workflow :)
Would you be able to package it into an rpm and distribute it? That way we'd only need to do rpm-ostree install <thing> to get it. This would be an easier sell to people thinking of moving to Silverblue.

The tricky thing about packaging it as an RPM is that to make this work code.sh needs to be in the user's path, inside the toolbox. So it would need to be something like:
rpm-ostree install code.sh
<reboot>
ln -s /run/host/usr/lib/toolbox-vscode/code.sh ~/.local/bin/code

would work, but that takes some of the easy-sell out of it :-). There has been some discussion of creating a system for adding extra commands from the host into toolboxes (https://github.com/containers/toolbox/issues/145); if we had that, then fitting into that could make things automatic.
I suppose something lke toolbox-vscode init [--homedir|F35] to create symlinks into ~/.local/bin/ or /usr/bin in the specified toolbox would remove some potential for user error.
Will have to think about this .. just having a git repository for me personally, but doesn't come across as ready-for-prime time :-)

Wrap up that script in a cURL command, and now you have a one-line install: curl https://cooldomain.here | bash

The tricky thing about packaging it as an RPM is that to make this work code.sh needs to be in the user's path, inside the toolbox. So it would need to be something like:
rpm-ostree install code.sh
<reboot>
ln -s /run/host/usr/lib/toolbox-vscode/code.sh ~/.local/bin/code

Could we just inject something like this into the toolbox's /etc/profile.d?
if [ -r /run/.containerenv -a -x /run/host/usr/lib/toolbox-vscode/code.sh ]; then
  alias code=/run/host/usr/lib/toolbox-vscode/code.sh
fi


Update max_heaser_data deafult from 4K to 20K

I've experienced Ran out of header data space while I have multiple sessions stored in my development server. (The different http servers runs on 3000,5000 and 8080 and stored cookie as a single domain) .
From an issue,  libwebsocket has options to increase this.  For now,  just increase 5 times bigger than default(4096), which is sufficient for the most of the case, I believe.

Also related to #4


Example not working out of the box. Error: Could not resolve entry module (rollup.config.js)

First off, I'm really excited to use this plugin to make an interactive, tutorial style website. It looks really neat! Unfortunately, I am unable to get the minimum example working out of the box.
To reproduce:
quarto use template jimjam-slam/sverto # Create new project `test-sverto`
cd test-sverto
npm install
quarto render example.qmd # ERROR

This last line produces the error [!] Error: Could not resolve entry module (rollup.config.js), full output below. I get the same error for quarto preview example.qmd and npm run build. I am new to the quarto ecosystem -- any tips?
hoo@hoo-M1 test-sverto % quarto render example.qmd
pandoc
  to: html
  output-file: example.html
  standalone: true
  section-divs: true
  html-math-method: mathjax
  wrap: none
  default-image-extension: png

metadata
  document-css: false
  link-citations: true
  date-format: long
  lang: en
  title: Sverto example
  date: last-modified
  sverto:
    use:
      - Circles.svelte

><EMAIL_ADDRESS>build
> rollup -c rollup.config.js --configQuartoOutPath=./ --configSvelteInPaths=Circles.svelte:

[!] Error: Could not resolve entry module (rollup.config.js).
Error: Could not resolve entry module (rollup.config.js).
    at error (/Users/hoo/Projects/test-sverto/node_modules/rollup/dist/shared/rollup.js:198:30)
    at ModuleLoader.loadEntryModule (/Users/hoo/Projects/test-sverto/node_modules/rollup/dist/shared/rollup.js:22306:20)
    at async Promise.all (index 0)

Error running filter /Applications/quarto/share/filters/main.lua:
...ts/test-sverto/_extensions/jimjam-slam/sverto/sverto.lua:104: attempt to concatenate a nil value (local 'svelteResult')
stack traceback:
        [C]: in ?
        [C]: in method 'walk'
        /Applications/quarto/share/filters/main.lua:224: in local 'checked_walk'
        /Applications/quarto/share/filters/main.lua:276: in function 'run_emulated_filter'
        /Applications/quarto/share/filters/main.lua:942: in local 'callback'
        [string "..."]:1888: in field 'withScriptFile'
        /Applications/quarto/share/filters/main.lua:958: in upvalue 'run_emulated_filter_chain'
        /Applications/quarto/share/filters/main.lua:996: in function </Applications/quarto/share/filters/main.lua:993>
stack traceback:
        /Applications/quarto/share/filters/main.lua:224: in local 'checked_walk'
        /Applications/quarto/share/filters/main.lua:276: in function 'run_emulated_filter'
        /Applications/quarto/share/filters/main.lua:942: in local 'callback'
        [string "..."]:1888: in field 'withScriptFile'
        /Applications/quarto/share/filters/main.lua:958: in upvalue 'run_emulated_filter_chain'
        /Applications/quarto/share/filters/main.lua:996: in function </Applications/quarto/share/filters/main.lua:993>

This error has been resolved by updating quarto from v1.4.555 to v1.5.42.

Ok this bug is back after restarting my computer. Not sure why...

I've merged a fix in for this, @bhoov! Try re-running quarto use template ... so you can get the new version and let me know how you go 😊

Incredible, you fixed this so quickly and the example works for me out of the box now. Thank you!!

Unfortunately, I am still having issues integrating sverto into an existing quarto website. After running quarto preview example.qmd, I get:
Error running filter sverto-prerender.lua:
cannot open sverto-prerender.lua: No such file or directory

I will open a new issue in the morning when I can make a minimally reproducible example. Ty!

That'd be great, @bhoov! I'll have more time to take a look later in the day, so if you can get a reprex going in the mean time, I'd be happy to take a look 😊 Apologies for the trouble you're having!

If I can get it working it will have been worth all the trouble :)


It seems that this code needs an update for Firebase 3

isn't it?

I think this firebase-token'generator has been deprecated. You can now generate custom token with auth module.
https://firebase.google.com/docs/auth/server#create_a_custom_token

yes you're probably right, but I was using this to generate token on a non nodejs (parse.com) environment  and now I'm kind of stuck. I'll figure out a way :-)

See https://firebase.google.com/docs/auth/server#use_a_jwt_library for minting your own Custom tokens with any JWT minting library.
Please note that there has been a fundamental change on how custom tokens work in v3. Now custom tokens are not directly consumable by the DB. You need to send them to your clients, from there call FirebaseAuth#signInWithCustomToken() (or equivalent in other non Java langs), and now you can authenticate against the database.
If your use case was to make direct calls from your server to the database, take a look at https://firebase.google.com/docs/database/server/start#section-account instead :)

Also see firebase login:ci and firebase --token for some command line tools.


Mobile Device Fullscreen Rotation Problem

When on a mobile device in fullscreen mode, if you rotate to a different orientation, the video canvas no longer fills the screen, it just remains the same size.  This is fixed by adding !important to both height and width for .mejs-container-fullscreen on css line 73.
On my site I changed this:
.mejs-container-fullscreen .mejs-mediaelement,
.mejs-container-fullscreen video {
	width: 100%;
	height: 100%;
}

to this:
.mejs-container-fullscreen .mejs-mediaelement,
.mejs-container-fullscreen video {
	width: 100% !important;
	height: 100% !important;
}

This seems like this is a symptomatic fix, not a system-level fix, so I don't recommend it for production, but I wanted to let you all know about the bug.

Thanks I'll check this and let you know when it's fixed

@andyh4 Seems like that's a potential solution; as a favor can you implement in your local environment and test the fix specified in https://github.com/johndyer/mediaelement/issues/1609#issuecomment-261255607 and let me know if that works so I can implement it in the core package, please?

Are you referring to this?
setTimeout(function(){
                t.container.find('video')
                .width('100%')
                .height('100%').css('min-width','100%').css('min-height','100%');
            }, 500);

Yeah I'm curious to see if that could solve this issue by adding that into the full screen feature in te enterFullscreen() method

@andyh4 I integrated the fix in the various-fixes branch, can you confirm that this is fixed there before I merge it into 3.x-dev please? Use the test/player-full.html file for testing this

@andyh4 I removed the branch but the solution you were talking about was:
if (isNative) {
	t.$media
		.width('100%')
		.height('100%')
                .css('min-width','100%').css('min-height','100%');
} else {
	t.container.find('iframe, embed, object, video')
		.width('100%')
		.height('100%')
                .css('min-width','100%').css('min-height','100%');
}

for the enterFullscreen() method and
if (isNative) {
	t.$media
		.width(t.normalWidth)
		.height(t.normalHeight)
                .css('min-width','initial').css('min-height','initial');
} else {
	t.container.find('iframe, embed, object')
		.width(t.normalWidth)
		.height(t.normalHeight)
                .css('min-width','initial').css('min-height','initial');
}

for the exitFullscreen(), correct? Let me know so I can add it into 3.x-dev branch, please. Thanks

@andyh4 Just FYI your fix was cleaner than the other approach and it's a valid approach using !important on the CSS styles. I pushed this fix and the latest version has this fixed. I used Android for testing and everything seems fine. Let me know if it works for you and close this ticket please

Works for me, thanks!.


Add option to skip hashing if unsafe-inline is present

Summary
Modern browsers ignore the 'unsafe-inline' CSP setting if any hash or nonce exists in that directive. This means that this plugin's automatic sha256 hashes that it generates for inline scripts and styles implicitly disable 'unsafe-inline' for modern browsers even if the developer explicitly wants 'unsafe-inline' enabled.
This PR addresses the issue by adding an option to the plugin config to disable the implicit hashing. Setting hashIfUnsafeInlinePresent to false when initializing the plugin will make it skip hashing if a script-src or style-src directive contains an 'unsafe-inline' value.
Requirements (place an x in each [ ])

[x] I've read and understood the Contributing Guidelines and have done my best effort to follow them.
[x] I've read and agree to the Code of Conduct.
[x] I've written tests to cover the new code and functionality included in this PR.
[x] I've read, agree to, and signed the Contributor License Agreement (CLA).

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@AnujRNair apologies for the long turnaround here. I just updated the code based on your feedback. Thanks!

@AnujRNair I made the changes you requested. As for unsafe-eval, I'm not sure if it's quite the same, since these policies only deal with included scripts and styles… I suppose I could change line 159 to something like intersection(flattenedUserPolicy, ["'unsafe-inline'", "'unsafe-eval'"]).length > 0) to support that though.

Thanks for the change! Let's start with this, and if we find we need to expand this more in the future, we can do


java.lang.ClassNotFoundException: org.elasticsearch.spark.rdd.EsSpark$$anonfun$saveToEs$1

I cannot run the example at https://www.elastic.co/guide/en/elasticsearch/hadoop/current/spark.html
My sbt is like below;
name := "..."

version := "..."

scalaVersion := "2.10.6"

libraryDependencies ++= Seq(
  "org.apache.spark" %% "spark-core" % "1.5.2",
  "org.apache.commons" % "commons-lang3" % "3.4",
  "org.elasticsearch" % "elasticsearch-spark_2.10" % "2.1.2",
  "org.elasticsearch" % "elasticsearch-hadoop" % "2.1.2"
)

resolvers += "conjars" at "http://conjars.org/repo"

Copied the source file;
object ES {
  def main(args: Array[String]) {
    val conf = new SparkConf().setAppName("ES")
                              .set("es.nodes", "[ip address for es]")
    val spark = new SparkContext(conf)

    val numbers = Map("one" -> 1, "two" -> 2, "three" -> 3)
    val airports = Map("arrival" -> "Otopeni", "SFO" -> "San Fran")

    spark.makeRDD(Seq(numbers, airports)).saveToEs("spark/docs")
  }
}

Ran with this command;
SPARK_LOCAL_DIRS=./tmp/ HADOOP_CONF_DIR=/etc/hadoop/conf /path/to/spark-1.5.2-bin-hadoop2.4/bin/spark-submit --class "ES" --master yarn-client --num-executors 17 --executor-cores 5 --executor-memory 8g --driver-class-path /path/to/.ivy2/cache/org.elasticsearch/elasticsearch-spark_2.10/jars/elasticsearch-spark_2.10-2.1.2.jar ./target/scala-2.10/cat_2.10-0.1.jar

And I got the exception in title. Anything wrong?
Thanks.

I missed --packages when running.


[OpenCV2] add library for projects that require the C API

as per title, I propose the inclusion of the older OpenCV 2, guarded with an error like MySQL/MariaDB, since it is necessary to build projects that still use the C API (abandoned/broken in OpenCV3). For example, it is necessary to build YOLO on Windows ;)

I did another commit, to fix building on macOS (I hope it fixes also Ubuntu, still not tested). Since vcpkg is now cross-platform, I hope it is better now 🤓

I tested building also on Ubuntu and it worked. Added a small notice (comment) at the beginning of the port file to explain pre-requisites.

As a side note, I tried building also on x86-windows but I got a failure when linking with OpenGL32.lib, with the linker complaining that it couldn't solve _imp_wglGetProcAddress symbol...

I think that this port is in a good shape to be at least tried by someone, if interested @ras0219-msft @UnaNancyOwen @patrikhuber @jasjuang

@cenit Thanks, it might become useful some day (as you mentioned... YOLO & stuff...), but for now I long moved to OpenCV3 (and probably 4 soon) for my own projects :-)

closed because there's not enough interest and it would be difficult to keep tested (vcpkg discourages not using the latest version by design)


fix: fixed the nav color on scroll in dark mode

Pull Request Template

Please provide all of the details below. Pull requests missing any of the information below will be closed!
Providing the issue number/url helps us identify the problem being solved and keep the issues tab clean and tidy

This is not a fix. This is a request to add login and signup pages to the site.
Summarize what this PR fixes:-
Fixes #
Checklist
(Add an x between the brackets to check the items)

[x] I have summarize what this PR fixes above
[ ] I have provided the issue ID/URL above
[ ] I have not added Bootstrap or jQuery and used correct styling guide.
[ ] This PR fixes only the issue mentioned above (create separate PRs for separate issues)
[ ] I was the first one to claim the issue or I created the issue - I created the issue

There needs to be a complete pr template with an issue linked.


Uncaught TypeError: Cannot read property 'css' of undefined

When implementing tokenize into my current form its throwing above error. Is there a way I can limit the functionality of dropdown to index.php ?

Hi,
What version and browser do you use ?
I don't understand your second question, what do you want to do according "limit the functionality of dropdown" ?


Hal API to retrieve TID stats via iw and Netlink

Signed-off-by: Rajakumaran1106<EMAIL_ADDRESS>

https://jenkins.code.rdkcentral.com/job/github-triggered/128/ started

https://jenkins.code.rdkcentral.com/job/build-component-rdk-next/8706/ started.

build-turris-broadband Console Log uploaded to Gist URL: https://gist.github.com/6625a49bea536b8f27e0d578438379a9

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Fix typo in readme

cargo check is a built in command, cargo-watch is the external one that needs installation

LGTM


Update docs

It would be nice to have docs updated.
There are handy options like:

zoomLevel - initial zoom
minZoomLevel
maxZoomLevel

And more.
Here is (probably) complete options list (from the source code):
    borderColour: '#888',
    borderSize: 4,
    constrainSize: false,  //in pixels the dimensions you want to constrain on
    constrainType: false,  //width or height
    containLensZoom: false,
    cursor: 'inherit', // user should set to what they want the cursor as, if they have set a click function
    debug: false,
    easing: false,
    easingAmount: 12,
    enabled: true,

    gallery: false,
    galleryActiveClass: 'zoomGalleryActive',
    gallerySelector: false,
    galleryItem: 'a',

    imageCrossfade: false,

    lensBorderColour: '#000',
    lensBorderSize: 1,
    lensColour: 'white', //colour of the lens background
    lensFadeIn: false,
    lensFadeOut: false,
    lensOpacity: 0.4, //opacity of the lens
    lensShape: 'square', //can be 'round'
    lensSize: 200,
    lenszoom: false,

    loadingIcon: false, //http://www.example.com/spinner.gif

    // This change will allow to decide if you want to decrease
    // zoom of one of the dimensions once the other reached it's top value,
    // or keep the aspect ratio, default behaviour still being as always,
    // allow to continue zooming out, so it keeps retrocompatibility.
    mantainZoomAspectRatio: false,
    maxZoomLevel: false,
    minZoomLevel: false,

    onComplete: $.noop,
    onDestroy: $.noop,
    onImageClick: $.noop,
    onImageSwap: $.noop,
    onImageSwapComplete: $.noop,
    onShow: $.noop,
    onZoomedImageLoaded: $.noop,

    preloading: 1, //by default, load all the images, if 0, then only load images after activated (PLACEHOLDER FOR NEXT VERSION)
    respond: [],
    responsive: true,
    scrollZoom: false, //allow zoom on mousewheel, true to activate
    scrollZoomIncrement: 0.1,  //steps of the scrollzoom
    showLens: true,
    tint: false, //enable the tinting
    tintColour: '#333', //default tint color, can be anything, red, #ccc, rgb(0,0,0)
    tintOpacity: 0.4, //opacity of the tint
    touchEnabled: true,

    zoomActivation: 'hover', // Can also be click (PLACEHOLDER FOR NEXT VERSION)
    zoomContainerAppendTo: 'body', //zoom container parent selector
    zoomId: -1, // identifier for the zoom container
    zoomLevel: 1, //default zoom level of image
    zoomTintFadeIn: false,
    zoomTintFadeOut: false,
    zoomType: 'window', //window is default,  also 'lens' available -
    zoomWindowAlwaysShow: false,
    zoomWindowBgColour: '#fff',
    zoomWindowFadeIn: false,
    zoomWindowFadeOut: false,
    zoomWindowHeight: 400,
    zoomWindowOffsetX: 0,
    zoomWindowOffsetY: 0,
    zoomWindowPosition: 1, //Possible values: 1-16, but we can also position with a selector string.
    zoomWindowWidth: 400,
    zoomEnabled: true, //false disables zoomwindow from showing
    zIndex: 999

yes you are right, docs need some love. I'm at the moment very short on time for the next weeks. Will try to improve it.  but in-between PR's are also very welcome. :)

First of all many thanks for this plugin.
Tell me how (and where) and will try to find some time for docs update.

Great!, here is the file:
https://github.com/igorlino/elevatezoom-plus/blob/master/demo/api.htm
You may open&edit the project using WebStorm, it has a nice auto-format function.(shortcut is ctrl-alt-L)

Thanks that is what I was looking for. I'll try to contribute soon.


Include/Exclude the range min & max values

This is a suggestion that could make the package a little neater if it was implemented. The following plot will complete the chart:
plot(log(x), (x, 0, 10))

However, it will also produce an error:
<lambdifygenerated-94>:2: RuntimeWarning: divide by zero encountered in log
  return log(x)

It would be neater if the min or max values themselves could be optionally excluded from the range of values being plotted so as to avoid such errors.

I see two options. The first:
plot(log(x), (x, 1e-5, 10))

The second:
plot(log(x), (x, 0, 10), exlude=something)

I very much prefer the first because I type less... It would be relatively easy to implement an exclusion list, but that would only work with adaptive=False.

However, it will also produce an error:

That's not an error: it's a warning. An error stops the execution, whereas a warning allows the execution to continue.

I've no strong feeling either way although being able to list exclusions may be useful. Maybe the user could exclude ranges too? I don't feel this is a big deal though; maybe something to keep in mind. Thanks.


Extra pages in documentation

It would be beneficial for the docs to have a page on the theory behind pytaser, as well as a page on preferred settings/tips for new users.

@savya10 I would suggest that this can be achieved by either copying the text from the JOSS draft (as done for easyunfold's theory page), or the lazier option would be to include a link to the JOSS paper when accepted.

This is partially achieved now with the addition of the Background section to the docs.
I propose once the JOSS is published (soon 🙏 ), we just add a link to this saying "More details on the theory behind TAS can be found in the JOSS paper." (linked)

Now handled by 5b8a6d5


Optimize the memory usage of streaming operators

See details on https://risingwave-labs.slack.com/archives/C03U9AB2P45/p1661360900296829
Profile results: https://risingwave-labs.slack.com/files/U030TMLQ1LJ/F0409NBGQ56/2_run_1h30min.svg
The memory used in streaming operators is:
- HashJoin
  - 2.4GB PK (Vec<Datum>)
  - 1.5GB JoinRow (serialized)
  - 2.7GB B-Tree data structure
- HashAgg
  - 1.6GB ExtremeState (Vec<OrderedDatum>)

[ ] Optimize PK (VecDatum) of streaming HashJoin

Can be replaced with memcomparable row

[ ] Optimize ExtremeState (Vec<OrderedDatum>) in streaming HashAgg

Can be replaced with memcomparable row

[ ] Optimize B-Tree in streaming HashJoin

Don't know how... need investigation

For B-Tree data structure, have we known which component memory is used for Key-Value and which component memory is just allocated for B-Tree Node?

For B-Tree data structure, have we known which component memory is used for Key-Value and which component memory is just allocated for B-Tree Node?

Yes, it can be seen in the heap profile results.

I'll start with the ExtremeState.


Footnotes are squished together by cargo doc when there's no empty line between them

Problem
Footnote lines, when written on adjacent lines, squish into a single footnote:
//! [^1]: Footnote A.
//! [^2]: Footnote B.
//! [^3]: Footnote C.

Steps

Copy-paste the following snippet at the top of a new module:
//! Reference to footnotes A[^1], B[^2] and C[^3].
//!
//! [^1]: Footnote A.
//! [^2]: Footnote B.
//! [^3]: Footnote C.

Run cargo doc.

Observe that the footnotes have been incorrectly rendered as a single footnote.

Possible Solution(s)
No response
Notes
One workaround is to separate the footnotes with empty lines:
//! [^1]: Footnote A.
//!
//! [^2]: Footnote B.
//!
//! [^3]: Footnote C.

It's not pretty, though.
Version
cargo 1.64.0-nightly (b1dd22e66 2022-07-09)
release: 1.64.0-nightly
commit-hash: b1dd22e668af5279e13a071ad4b17435bd6bfa4c
commit-date: 2022-07-09
host: x86_64-apple-darwin
libgit2: 1.4.2 (sys:0.14.2 vendored)
libcurl: 7.79.1 (sys:0.4.55+curl-7.83.1 system ssl:(SecureTransport) LibreSSL/3.3.6)
os: Mac OS 12.5.0 [64-bit]

Transferring to Rust as it is an issue with doc generation.


Update README to reference Meilisearch cloud

Pull Request
What does this PR do?
Fixes #106
PR checklist
Please check if your PR fulfills the following requirements:

[x] Does this PR fix an existing issue?
[x] Have you read the contributing guidelines?
[x] Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

bors merge


Displaying version

Hi Levi,
May I suggest to include version in the exe/zip name and also in the engine id (after uci command)?
Gabor

Also, please indicate if you'd prefer Eggnog 5 or Eggnog 5.0 as the version.


Cannot pass reference to input

Bug report 🐞
Expection
I want to use the ref attribute of the Input component to use with react-hooks-form, but i cannot pass the reference.
Actual results (or Errors)
<Input width="100%" name="email" ref={register} />

Input is forward Ref by default. I cerated an exampel here and not found any issue.
Would you mind sharing more information about this error? (version / behavior / alert messages / online example)

Ok,

I'm using the react+typescript with the latest version, @zeit-ui/react: 1.2.0-rc.0, and react-hook-form: 5.6.3. And when I try to use the ref attribute (I also try to use itemRef) I got the following:

Thank for you feedback, this is a type issue of forward function, I fixed it here: #190 .


Make question buttons underlined when focused

Previously quick question buttons would change in appearance when
focused. The normally used shadow was removed since it would make the
question look horrible.
Instead the button now underlines its text when in focus.

Sorry, but this seems to have been superseded by https://github.com/isaacphysics/isaac-cs-app/pull/111 now!


Colons cannot be used in page title

Unfortunately, colons cannot be used as part of a page's title in the meta section.
For example the following
/*
Title: Knowledge: Introduction to my tool
*/

should give the title 'Knowledge: Introduction to my tool' but instead produces only 'Knowledge'.
I am using version 0.16.2.

Did you try with %3A? Didn't test but it might work.

Did you try with %3A? Didn't test but it might work.

Nope, does not work unfortunately. It simply results in 'Knowledge%3A Introduction to my tool'.

By looking at the projects unit tests I found out that one can use yaml syntax to declare page metadata.
So instead of
/*
Title: Knowledge: Introduction to my tool
*/

one can write
---
Title: "Knowledge: Introduction to my tool"
---

which results in the expected output.
I missed that at first because this feature is not mentioned in the docs.

Thanks for noting this. If you edit meta data via the web UI it uses this format.

Thanks for reporting.
Closing this and adding to the megathread of Documentation updates (see above)


add "halt" boolean to consume event

Is this a useful idea for you?  (I'm sure the implementation needs work, and I haven't yet tried to understand the test suite.)
The purpose is for a "to" event entry to be able to fully consume the input event.  After "halt": true. no other "to" events will fire.  halt is only respected on the last event of a series.
My usecase is holding down a key.  When pressing the key normally I want the normal single keystroke to be sent, which I do with to_after_key_up.  When holding down the key I want a precise double-tap to be sent.  Without this patch I could not work out a configuration that would reliably send exactly two keystrokes for the double-tap.
My configuration for using this looks like
{
    "title": "Emacs Hold Control-Q to double-tap",
    "rules": [
        {
            "description": "Emacs: translate Hold-Control-Q to fast double-tap.",
            "manipulators": [
                {
                    "type": "basic",
                    "conditions": [
                        {
                            "type": "frontmost_application_if",
                            "bundle_identifiers": [
                                "^org\\.gnu\\.Emacs$"
                            ]
                        }
                    ],
                    "from": {
                        "key_code": "q",
                        "modifiers": {
                            "mandatory": [
                                "control"
                            ]
                        }
                    },
                    "to_after_key_up": [
                        {
                            "key_code": "q",
                            "modifiers": ["control"],
                            "repeat": false
                        }
                    ],
                    "to_if_held_down": [
                        {
                            "key_code": "q",
                            "modifiers": ["control"]
                        },
                        {
                            "key_code": "q",
                            "modifiers": ["control"],
                            "repeat": false,
                            "halt": true
                        }
                    ]
                }
            ]
        }
    ]
}

Thank you!


[V7 Breaking] feat: improve WalletAccount class instantiation

Motivation and Resolution
Currently, the WalletAccount class in the account.ts file has the connection logic and account address retrieval mixed with the object construction process in the constructor. This violates the principle of separation of concerns and can lead to potential issues such as race conditions and difficulty in testing.
To address this concern, the connection logic and account address retrieval have been separated from the constructor and moved into static connect and connectSilent methods. This change ensures that the object construction process remains synchronous and focused on initializing the object's state, while the connection logic is handled separately.
RPC version (if applicable)
N/A
Usage related changes
No changes to the usage of the WalletAccount class from the user's perspective.
Development related changes

The WalletAccount class constructor no longer includes any asynchronous operations or connection logic. It now focuses solely on initializing the object's state and setting up event listeners.

The connect and connectSilent static methods have been introduced to handle the connection logic and account address retrieval from the wallet provider.

Developers should now use the connect or connectSilent methods to create instances of WalletAccount with the appropriate account address retrieved from the wallet provider.

This approach facilitates better integration with libraries like starknetkit and starknet-react, which handle the connection logic internally. After establishing a connection, these libraries can return a WalletAccount instance without attempting to connect again, as the connection logic is now separated from the object construction process.

Checklist:

[x] Performed a self-review of the code
[x] Rebased to the last commit of the target branch (or merged it into my branch)
[x] Linked the issues which this PR resolves
[x] Documented the changes in code (API docs will be generated automatically)
[x] Updated the tests
[x] All tests are passing

This will be breaking change with connect() for existing users.
Is there an imminent issue with this one, so should it be forced into the current version?
If so can we for this version leave auto-connect width a delay for connect let's say 2000 ms, and in v7 merge it with connect?

Rollback to merge.
Solution resolved in branched PR https://github.com/starknet-io/starknet.js/pull/1259

It would be good to reopen this one rebased on #1259 with breaking changes for V7

Reopen with resolved base


feat: improve breadcrumbs functionality

Notes

Improves breadcrumbs component.
Adds context menu when right clicking a breadcrumb clickable item.

Fixes #840.

Updated Joyride tour in https://github.com/ipfs-shipyard/ipfs-webui/pull/1599/commits/91a0d3a6232613722f5a2734a8eeb4ad8324b387 - screenshot below:

[X] Unpin label in context menu

[X] Download in a directory - this was actually the assumption that I made that the last item of the breadcrumbs would be always a file 🤦 Sorry about that f(a)il(e), changed the method to use ipfs.files.stat to get both CID and Type

[X] Dragging onto any level of breadcrumb actually just imports it into the presently displayed directory. - I've updated the code from the dragging already uploaded files and forgot to update the one from new files 🤦

[ ] @jessicaschilling "would it be possible to display a directory's CID on hover of the breadcrumb, as in the mockup in that comment?" That would force us to run ipfs.files.stat for every breadcrumb. We could make this async (after loading with a small delay), but don't you think that the cursor: pointer is sufficient feedback for the user? I really don't want to impact the normal usage of the files page because of a small interaction 🤔

[X] Changed translation to "an item", makes more sense 👍

breadcrumb for parent has all the context menu items, but its parents only have three items – bit confusing, are we able to unify this?

The logic is that if an item is a directory, you can only do the 3 options, if it's a file you can do the full list

[X]  Found a D&D bug: while in "Files, click on the "Files" in navbar and keep it clicked, then drag it into Files ;-) . Fixed every drag & drop of text inside webui. If you find a weird use-case where this should be possible please tell me

When I right click on a crumb, its menu is displayed. When I click on another, its menu does not display: I see menu for previous crumb + browser-native menu instead. Was able to reproduce in both Firefox and Chromium. Are we able to close existing menu if a different crumb is right-clicked?

@lidel unfortunately I don't think it's possible with the current solution, since we create an invisible overlay around the dropdown to catch mouse interactions. There's 2 solutions that come to my head:

Remove the overlay and change the click handling to a global listener that checks if there was a click the dropdown and just close it if that's the case.
Make a onContextMenu handler on the overlay that simply prevents the default behavior (so that you don't see the native right click action)

What option would you prefer?
--
Thanks both of you for your deep review 🙏

Bummer about the hover being expensive. We can leave it out.

@rafaelramalho19 IIUC  going with "global listener that checks if there was a click the dropdown and just close it if that's the case" would produce better UX:

We want to disable native right click action and only display webui ones when interacting with breadcrumbs or file list
There should be only one context menu at a time

if a new one is opened an existing one should be automatically closed


Entry on the timeline when finishing the new Python certificates is not working

Currently when you complete/claim a certificate there's an entry on the timeline:

This doesn't seem to be working for the new Scientific Computing with Python, Data Analysis with Python, and Machine Learning with Python certificates.

I'm a new contributor but I'd like to help out on this.

I think this is mostly working. You just need to refresh the page before it shows up...

Ah, interesting. This does seem to work locally but not on .dev for some reason.

This may be a one off issue related to https://github.com/freeCodeCamp/freeCodeCamp/issues/39002 where the new/split certificates (Quality Assurance, Information Security, Scientific Computing with Python, Data Analysis with Python, and Machine Learning with Python) were not seeded to the .dev database for some reason. I can confirm this is working locally like @moT01 mentioned above.
@jasnkwcz, thank you for your interest in contributing. Please check out issues with the help wanted label for other things we need help with.


QDrawer does not honour model

I expected the QDrawer to supports the toggle method to control its visibility (https://quasar.dev/layout/drawer).
Of course, I do not know the policy on which methods are and which are not supported.
(As a workaround I used model to control the visibility, but that is more verbose.)

The run_method allows you to run any method https://justpy.io/quasar_tutorial/introduction/#running-quasar-component-methods
Currently to get the functionality you want you would have to create your  QDrawer derived class and add the following method to it:
class MyQDrawer(jp.QDrawer):

    async def toggle(self, msg):
        await self.run_method('toggle()', msg.websocket)

Now use MyQDrawer instead and you should have what you need. Let me know if this doesn't work.
I agree that it is a good idea to have this for all quasar components as part of the framework. I'll do this in stages since there are tons of methods to support.

Ah, that's good to know. Thanks.

For the moment I'd think that this would would work. It doesn't:
class LayoutPage(jp.QuasarPage):
    def __init__(self, **kwargs):
        super().__init__(**kwargs)
        self.data = {'left': True}

        self.layout = jp.QLayout(view='hHh lpR fFf', a=self)
        self.header = jp.QHeader(elevated=True, classes='bg-primary text-white', a=self.layout)
        self.toolbar = jp.QToolbar(a=self.header)

        async def click_btn(comp, msg):
            # self.data['left'] = not self.data['left']
            await self.drawer.run_method('toggle()', msg.websocket)

        c4 = jp.QBtn(dense=True, flat=True, round=True, icon='menu', click=click_btn, a=self.toolbar)

        c5 = jp.QToolbarTitle(a=self.toolbar)
        c6 = jp.QAvatar(a=c5)
        c7 = jp.Img(src='https://cdn.quasar.dev/logo/svg/quasar-logo.svg', a=c6, text='Title')

        self.drawer = jp.QDrawer(show_if_above=True, side='left', bordered=True, a=self.layout)

The button click handler is called (verified).

Thank you for flagging this.
In order to make this work, you just need to add temp=False to the definition of self.drawer:
self.drawer = jp.QDrawer(show_if_above=True, side='left', bordered=True, a=self.layout, temp=False)

This forces JustPy to generate an id for the element without which run_method does not work.
The documentation of run_method is incomplete and I apologize I forgot to mention this to you in my previous answer. I will update the docs.

Yes that works. Thx.
You might want to consider renaming the temp argument to something less common and more descriptive, like gen_id or generate_id (or whatever it really means).

Yes, I'll do that (without removing temp so as not to break current programs).
In the initial development stages of JustPy the framework generated ids for all elements and had a reference to them in the internal data structures. But I soon realized that only elements that you need to interact with need an id and a reference. That saved a lot of memory and complexity. The temp name is a leftover from those experiments.

Now you can still afford breaking things ;-) It's still v0.10


numpy>=1.24 breaks ktrain.utils

numpy>=1.24 breaks ktrain.utils.  Must remove references to np.int and np.float, as shown here

Fixed by 165782d6d44bd8c53edb9c7803dc754ebe60118c


Improve techempower benchmark

So, Javalin is back here: https://www.techempower.com/benchmarks/#section=data-r21&l=zik0vz-6bj&test=composite
But it's not looking so fast. Maybe we can fix that?
The repo for the benchmark code is here: https://github.com/TechEmpower/FrameworkBenchmarks/tree/master/frameworks/Java/javalin
Some things we should do:

[x] Update to newest Javalin
[x] Replace Pebble with JTE and precompiled templates
[x] Remove before/after/error stages from request lifecycle
[x] Cleanup database controller
[x] Use custom JSON setup
[ ] Enable Loom via --enable-preview and Java 19
[ ] Copy DB stuff from vertx or jooby?
[ ] ~Enable HTTP2~ (not supported by wrk)
[ ] ~See if we can make Jackson faster~

Here is our branch: https://github.com/javalin/FrameworkBenchmarks/tree/javalin-improvements

@JohnnyJayJay interested in working on this? 😁

I forked the repo and created a branch that can be worked on: https://github.com/javalin/FrameworkBenchmarks/tree/javalin-improvements
@casid do you want to replace pebble with JTE?

@JohnnyJayJay interested in working on this? 😁

Sure, could work through your points tomorrow and get feedback from the TechEmpower people.

Sure, could work through your points tomorrow and get feedback from the TechEmpower people.

Cool! I already took care of migrating to Javalin 5 and bumping the other dependencies.

@casid do you want to replace pebble with JTE?

Exciting to see how fast, we're going to make it :-) I'll have a look into it!

@tipsy I think you need to allow me to push to the branch. Currently I receive this error message:
remote: Permission to javalin/FrameworkBenchmarks.git denied to casid.
fatal: unable to access 'https://github.com/javalin/FrameworkBenchmarks.git/': The requested URL returned error: 403

@casid Is that possible without giving write-access to the whole repo? If not, you could create a pull-request?

Gave you write access too, @JohnnyJayJay !

@tipsy thanks! I pushed my changes, the fortunes are now rendered with precompiled jte templates.

Great, thank you!

Will enabling HTTP/2 have an impact? https://github.com/TechEmpower/FrameworkBenchmarks/wiki/Project-Information-Framework-Tests-Overview They are not banning it.

Will enabling HTTP/2 have an impact?

It should, let's try?

Found another repo https://github.com/networknt/microservices-framework-benchmark

Will enabling HTTP/2 have an impact? https://github.com/TechEmpower/FrameworkBenchmarks/wiki/Project-Information-Framework-Tests-Overview They are not banning it.

The underlying http client is wkr and it does not support http/2 so... https://github.com/wg/wrk/issues/439

Nice one @tipsy! Was just about to look into removing those calls to getDbServiceFromPath(ctx.path()), but you've been faster :-D.

Nice one @tipsy! Was just about to look into removing those calls to getDbServiceFromPath(ctx.path()), but you've been faster :-D.

I took the easy part, but I suspect there is more room for improvement in the DB code itself 😄

We could try to get GraalVM working, that could really boost things up

@zugazagoitia a lot of people would appreciate that in general, the tutorial is outdated.

@zugazagoitia is there a warmup phase before the benchmark? If so, the JIT should probably beat AOT GraalVM compiler in terms of throughput.
I looked into vertx-web and jooby, and they both have -XX:+AggressiveOpts JVM option set. Maybe we could give it a try how this affects the benchmark?
Looking at the results, it seems the DB is also a bottleneck at the moment. I tried to look into how other frameworks connect to the DB. The frameworks with high scores I looked at (officefloor, inverno, jooby) all use vert.x for DB connection handling. Maybe it would be possible to replace Hikari with https://github.com/eclipse-vertx/vertx-sql-client?

@zugazagoitia is there a warmup phase before the benchmark? If so, the JIT should probably beat AOT GraalVM compiler in terms of throughput.

There is a warmup, I have no idea if this would improve performance but either way I'll make a graalvm branch and run some benchmarks, you might be right.

looked into vertx-web and jooby, and they both have -XX:+AggressiveOpts JVM option set. Maybe we could give it a try how this affects the benchmark?

After a litte googling I found this: https://bugs.openjdk.org/browse/JDK-8199847

Looking at the results, it seems the DB is also a bottleneck at the moment. I tried to look into how other frameworks connect to the DB. The frameworks with high scores I looked at (officefloor, inverno, jooby) all use vert.x for DB connection handling. Maybe it would be possible to replace Hikari with https://github.com/eclipse-vertx/vertx-sql-client?

I believe the DB to be the biggest bottleneck right now, we have major improvements comming to Json on a dsl-json branch I'm working on. Could you try and replace it?

After a litte googling I found this: https://bugs.openjdk.org/browse/JDK-8199847

Thanks for link, makes sense to not use this option then.

we have major improvements comming to Json on a dsl-json branch

Nice, this should improve JSON performance a lot!

Could you try and replace it?

Would be quite interesting, but I currently don't have the time to try it. :-(

This is the current state of the branches in the repo, the DSL implementation is better across the board, with Loom improving the DB tests that put more strain on the DB, such as Twenty and Updates. I'll go ahead and merge the DSL branch.
Any input on loom usage?

Any input on loom usage?

We could use loom only for DB. Either via Context#async, or a custom thing?

Since we haven't worked on this in a while I think we should PR our fork in it's current state and see if we bump some positions on the charts. We could always some back and improve it.

Update
JVM
We've actually improved some positions, this was our standing amongst JVM frameworks before merging:

And this is it now:

Jetty Frameworks
Same story but only against Jetty based frameworks, this was our standing before:

And after:

There's some improvement to be done in DBs it seems.

This is a bit of work, and doesn't actually give us much. Should we close or keep open?

IMO, we should close it by now.

✅


Adds variables_path_partitions function

What does this PR do?
Adds a variables_path_partitions function to traverse_util, this function makes it easy to use create functions that take in Flax's variables structures and output path dictionaries that work with with Optax'smulti_transform and masked combinators.

Codecov Report

Merging #2371 (ca10344) into main (82daae3) will increase coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2371      +/-   ##
==========================================
+ Coverage   69.76%   69.81%   +0.05%
==========================================
  Files          62       62
  Lines        5493     5503      +10
==========================================
+ Hits         3832     3842      +10
  Misses       1661     1661

Impacted Files
Coverage Δ

flax/traverse_util.py
99.03% <100.00%> (+0.04%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


scrcpy: unknown option --prefer-text

on Windows I get the message "scrcpy: unknown option --prefer-text"

By default, letters are injected using key events, so that the keyboard behaves as expected in games (typically for WASD keys).

But this may cause issues. If you encounter such a problem, you can avoid it by:

scrcpy --prefer-text

(but this will break keyboard behavior in games)

Sorry, I was using version 1.10.
Works on the latest


[BUG] Fix Docker Builds

Support temporary volumes/mounts for internal frameworks & aapt(2) copies.

This is a bit over my head at the moment.

Apktool needs the apk, but then writes the output somewhere
It writes frameworks into ~ somewhere
It writes aapt/aapt2 into /tmp somewhere

So when folks mount a volume 1/1 into container - we don't have the other chunks covered. We basically need a tmpfs for the aapt/aapt2 and internal frameworks and some helper script to mount the intended apk (read only) into container, with some volume/mount to write the output.


Privilege escalation: unable to run docker commands in a task.

I need outputs(logs) of running an image and save them to /workspace/ later. Regardless of safety, how can I run a docker command in a task?
For example, running the following task will result in docker: Cannot connect to the Docker daemon at unix:///var/run/docker.sock. Is the docker daemon running?.
apiVersion: tekton.dev/v1alpha1
kind: Task
metadata:
  name: run-image
spec:
  inputs:
    resources:
      - name: image-source
        type: image
  steps:
    - name: run-docker-image
      image: gcr.io/cloud-builders/docker
      command: ["docker"]
      args: ["run", "hello-world"]

This is a typical error message if you don't have the permission. I usually solve this by sudo if it's on a local machine (i.e. sudo docker run ...)
Is there a way to achieve privilege escalation to run docker or is there a similar tool to run images inside a task? (kaniko is for build only afaik)
Thanks in advance!

For Docker to run, I think you'll need to have a daemon running somewhere as a sidecar. We've recently added support for this!
Can you check out the example at https://github.com/tektoncd/pipeline/blob/master/examples/taskruns/dind-sidecar.yaml?


PR: Avoid showing "No such comms" warning when restarting the kernel (IPython csole)

Description of Changes
I decided to override a comms method in our kernel to not show that warning once and for all.
Issue(s) Resolved

Fixes #15498.
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct: @ccordoba12.

Hello @ccordoba12! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file external-deps/spyder-kernels/spyder_kernels/customize/spyderpdb.py:

Line 519:28: E721 do not compare types, use 'isinstance()'
Line 521:21: E701 multiple statements on one line (colon)


Add support for #270:  Recursive -i argument

Fix https://github.com/dylanaraps/pywal/issues/270

Add a new optional command line argument: --recursive, to use with -i
Uses all images from subdirectories
Works with random and iterative method

I tested it with this structure:
test-dir
├── dir1
│   ├── dir11
│   │   └── img_dir11.jpg
│   └── img_dir1.jpg
├── dir2
│   ├── img_dir21.JPG
│   └── img_dir2.jpg
├── dir3
│   ├── img_dir3.jpg
│   └── wrong_file_type.sh
├── img_root1.jpg
└── img_root2.jpg

Let me know what you think!
Feel free to sqash the commits btw, I fought with Travis over the indentation of a single line.

Hey is anyone gonna look at this? Seems like newer MRs have been merged... @dylanaraps ?

LGTM :+1:
I apologize, my backlog across my projects was over 200 different issues and pull requests. I've most likely forgotten some (including this one).

Thanks, and no worries 😎

Great stuff, I can't believe this wasn't a thing already. So what happen to this?

-i does not look in subdirectories in 2024:  [E] image: No images found in directory.

there is no --recursive option: wal: error: unrecognized arguments: --recursive

Well it still exists, not sure what's going wrong:
https://github.com/dylanaraps/pywal/blob/master/pywal/__main__.py#L56

I would suggest pulling the project down from GitHub and installing it with pip -e.  The version uploaded to pypy has not been updated in a long time. :)

Yep, you are absolutely right, manually cloning the project and then pip install that, did the job. Now I can use the --recursive argument.
Maybe we should make it more clear in the install instructions that the pypy version is out of date and that the manual installation is the remanded method?
 I can imagine quite a lot of people getting frustrated and uninstalling pywal thinking that you can't have it search for images recursively.

I agree, however this project repo has not been updated in 3 years.  So this is simply not possible at the moment unless there is an authoritative fork someone is maintaining.


Achieving the optimal in the class hierarchy tab (3.0.89)

See issue #641 for some back story on this feature.
I am not entirely happy with the current behavior.
First - when you go to the hierarchy tab with say class RwDefinition selected, you see only the immediate subclasses (good) but NOT the little plus indicators that there are subclasses (bad).
I do think double-click should open only one level, and not be identical to expand-all.
Expand All is a useful feature. But there's no contractAll.  I'd like to be able to select the class I want and then contract down to it - which I can do selecting, clicking on the class tab then back on the hierarchy tab.

I've filed some other bugs on related issues and I'm not going to worry about whatever I wanted so long ago.


Update drive.rst suggest integers for values

Added the hint that the min x, min y, max x and max y should be integers

Thanks for the suggestion, but sometimes these values should be non-integers.


FHIRProxy may fail when continuation token is too large

We ran across an issue where the Azure API for FHIR returns a continuation token that is larger than 4kb. The maxQueryStringLength parameter of Azure Functions is set to 4kb, so anything larger than that is truncated.
Does the FHIRProxy handle this scenario?
See related issue: https://github.com/microsoft/fhir-server/issues/1567

@daemel @sordahl-ga - I thought we fixed this issue. Can you confirm?

@daemel @sordahl-ga - I thought we fixed this issue. Can you confirm?

Still an issue:
https://github.com/microsoft/fhir-server/issues/1567#issuecomment-845478523

A change was introduced to the FHIR Service to shorten the token.  Please re-test and inform us issues.


What about The Cloud?

Is your feature request related to a problem? Please describe.
Frontend and backend web app engineering can't be the full tech stack in a company that deploys live, public software. If create-t3-app wants to be a template for a complete software project, it has to factor in the rest of the infrastructure that makes real-world software projects possible. We have to answer the question "How is my app going to run?"
Describe the solution you'd like
It goes without saying that there's a massive cacophony of cloud services which will help you build and push your app, orchestrate deployments, and run your software. Most of those services are proprietary and contribute to vendor lock-in, which I'm guessing is in conflict with the values of this project. Despite how simple it'd be to throw heroku deploy into the mix, and despite how many people use similar cloud products, I would be pretty shocked if this project were to "pick a winner" among cloud platforms, so to speak.
There's good news, though. There are at least two technologies that we can safely assume will integrate gracefully with any architecture running on any cloud platform which, at this point, most vendors are assuming that you're already using for as much as you can. They are:

Containers
Kubernetes

I personally think mixing in those two technologies would be really well aligned with the T3 Axioms. This could start out small with a baked in helm chart, and evolve into a more full-featured open-source internal developer platform with techs like CrossPlane, KubeVela, and Argo.
Describe alternatives you've considered

Just not doing this and officially committing to the idea that create-t3-app is for frontend and backend software only.
Creating a create-t3-app companion project template that deals with infrastructure which assumes you're planning on defining those things in a separate GitHub repo, but provides all the nice reasonable defaults for the infrastructure concerns of an app created with create-t3-app.

So if I understand you correctly, you want use to have a deployment guide?

So if I understand you correctly, you want to add deployment guide?

I think we could go further and just add actual Kubernetes manifests and/or an official helm chart.

So if I understand you correctly, you want to add deployment guide?

I think we could go further and just add actual Kubernetes manifests and/or an official helm chart.

So you want to add a prompt for setting up kubernetes? I think that is way too opinionated and overkill.

So if I understand you correctly, you want to add deployment guide?

I think we could go further and just add actual Kubernetes manifests and/or an official helm chart.

So you want to add a prompt for setting up kubernetes? I think that is way too opinionated and overkill.

⬆

Yea I don't think Kubernetes is something every developer needs for their hobby apps. If you use Kubernetes I think you should set it up yourself.


Filter counts are wrong

Describe the bug
The counts on each filter item are incorrect, can result in poor and confusing UX.
To Reproduce
On staging (right now, at least) are "0" relays in poland, there is actually on relay from poland in the list
Expected behavior
Counts must be accurate, otherwise functionality breaks.
Additional context
This is likely a hydration/reference issue related to the results object. Right now, results does not propagate via Pinia because the pinia-persisted-state does not support independent storage objects. Modifying a large results objects can cause memory leaks/crash in the context of pinia using pinia-persisted-state, so this one variable was moved out of pinia and instead writes to local storage directly. While ugly, this has not caused problems until now. Instead, have a dedicated resultsstore, exclude the large object from persisted state and write own local storage functionality, so that hydration via pinia can be utilized, and all race conditions around results can be mitigated while the issues surrounding pinia-persisted-state can be complely avoided. This will also have performance improvements, because instead of binding results, we can utilize pinia computed (getters) properties, reducing memory impact in each component.

https://github.com/iendeavor/pinia-plugin-persistedstate-2#serialization-and-deserialization


Ease creation of QuerySpecs

If I want a QuerySpec that returns everything I need to:
    QuerySpec querySpec = new QuerySpec();
    querySpec.setFirstResult(0);
    querySpec.setMaxResult(Integer.MAX_VALUE);

Maybe it would be better to use something like QuerySpec.withNoRestrictions();
Also it would be great to have a builder pattern to make it easier to build a new instance.

If I want a QuerySpec that returns everything I need to:

If both firstResult and maxResult are null, it will be a non-paged query:
https://github.com/FlowingCode/backend-core/blob/6c23b719edaf5ecbbd3232a9a35d3a51aa5ff911/backend-core-business-spring-impl/src/main/java/com/flowingcode/backendcore/service/JpaCrudService.java#L102-L104

Also it would be great to have a builder pattern to make it easier to build a new instance

+1


Packages?

I can't see the packages from my account, is this normal?
(I'm wondering if they are set to public.)

Glad to hear that!
Looking forward to the new UX.

Closing this issue as packages are now visible!


Need Properties file for  coverity collector

I compiled and ran the collector according to the instructions but can't get any data . I checked db.collectors.find() collection and the coverity servers array is empty.
I copied my properties file from  https://github.com/Hygieia/hygieia-codequality-coverity-collector and changed the values.
How do I add the coverity URL and credentials so that the collector may fetch data?
Thanks
Tarun

@fidelcoria-aa can you respond back?

Hi @tarun-teja as I mentioned in gitter you should add connection details from the Admin Configuration Page.

Thanks @fidelcoria-aa . I was able to configure the Code Analysis Widget for Coverity.
One caveat for everyone : This collector only collects security related info.


debounce added

I liked to prevent some db callbacks so I added the debouncing feature.
"Debouncing is a technique used to optimize application performance by reducing the rate at which functions are called."
Use it like that:
AwesompleteUtil.start('#user_combo',
  {
    url: 'json.php?search=',
    limit: -1,
    debounce: 300
  },
  {
    minChars: 3,
    maxItems: 8,
    data: function(rec, input) {
      return rec['last_name'];
    }
  }
)

without "debounce" it should work just like before

"debounce" is in milli seconds.
It's the waiting time after each keypress until a new lookup is started. If one hits multiple keys with less than the debounce time, the lookup is holding back while typing.

Thanks for your pull request.
I will make a few changes when I pull it in.

_AWE_TIMER is not a constant in your PR, and state should not be kept on the AwesompleteUtil object
detachCopyFun should also call the clearTimeout
I want to keep the same code style as the rest, even though it is has a really old school style
documentation should be updated
a new minimized version should be made

dat is helemaal prima!

Merged


Full CRUD Admin API

Add full CRUD (Create, Read, Update, Delete) methods to Admin API for all API Umbrella data objects.
User Story
As an application developer
I would like to have full CRUD methods for all API Umbrella data objects
so that I can fully integrate my application with the API Umbrella platform

Definition of done
API Users

[x] Create
[x] Read
[x] Update
[x] Delete

API Backends

[x] Create
[x] Read
[x] Update
[x] Delete

Admin Users

[x] Create
[x] Read
[x] Update
[ ] Delete

API Scopes

[x] Create
[x] Read
[x] Update
[x] Delete

Admin Groups

[x] Create
[x] Read
[x] Update
[x] Delete

Thanks for pulling this together as a cohesive list! Nothing quite like checkboxes to make it clear what's missing. :)
We do already have CRU[D] APIs (well, lacking the deletes like seemingly most everything else) for API Scopes at /api-umbrella/v1/api_scopes and Admin Groups at /api-umbrella/v1/admin_groups. But I'll try to get the DELETEs implemented everywhere soon and finally, finally get all the API documentation updated on all this.

@GUI thanks for the quick response. We have another issue open regarding the documentation, with the idea to produce a Swagger or RAML description of the Admin API. What do you think of the Swagger/RAML description file idea?

@brylie: Sorry again for the delays. I believe I've added all the missing CRUD endpoints in master (https://github.com/NREL/api-umbrella-web/commit/fafa1a85e4f83e8ce7ef81f27135232d396fc507) with the exception of a DELETE action for users. However, users can be disabled, which should effectively be the same.
If you do want to delete users, let me know, since that would be helpful to know. We can certainly add delete capabilities, there's just a bit more to figure out (mainly soft deletes vs hard deletes, but also analytics implications).
And I definitely like the idea of a RAML or Swagger specification for all these API endpoints. I was hoping to get that those docs fully written for all of these endpoints as part of this update, but unfortunately I haven't gotten that done and I'll be without much internet access for the next couple weeks. So it will be a few weeks before I can circle back to this, but I do really want to get the docs updated so all of this is more clearly documented. Do you have any preferences on RAML vs Swagger, or does either one suit you?

@GUI can we please discuss the Admin API documentation in the related issue?

I'm going to go ahead and close this since the missing DELETE endpoints have been added and the documentation has been updated.

I creating user using postman tool it will created user successfully but it will calll in my front end application it will give 403 error(Response for preflight has invalid HTTP status code  403) please give response as soon as possible

but it will generated api key on apiumbrella/admin -> users ->API Users it will not send back to the apikey on email it will show as above comment 403 error


/app/system after compiled by webpack, run error

Problem
webpack run success. webpack info:
C:\Bitnami\wamp\apps\pagekit\htdocs\app\system>webpack
Hash: e95943eda5d32c0ec761
Version: webpack 1.13.2
Child
    Hash: e95943eda5d32c0ec761
    Version: webpack 1.13.2
    Time: 2450ms
                  Asset    Size  Chunks             Chunk Names
    ./app/bundle/vue.js  168 kB       0  [emitted]  vue
       [0] ./app/vue.js 3.4 kB {0} [built]
       [1] ./app/lib/cache.js 662 bytes {0} [built]
       [2] ../assets/JSONStorage/storage.js 9.25 kB {0} [built]
       [3] ../assets/vue-form/dist/vue-form.common.js 14.5 kB {0} [built]
       [4] ../assets/vue-intl/dist/vue-intl.common.js 26.9 kB {0} [built]
       [5] ../assets/vue-resource/dist/vue-resource.common.js 34.5 kB {0} [built]
       [6] ./app/lib/asset.js 2.56 kB {0} [built]
       [7] ./app/lib/state.js 1.15 kB {0} [built]
       [8] ./app/lib/resourceCache.js 1.3 kB {0} [built]
       [9] ../assets/js-md5/js/md5.js 9.64 kB {0} [built]
      [10] ./app/lib/csrf.js 342 bytes {0} [built]
      [11] ./app/lib/notify.js 529 bytes {0} [built]
      [12] ./app/lib/trans.js 19.1 kB {0} [built]
      [13] ./app/lib/filters.js 609 bytes {0} [built]
      [36] ./app/directives/check-all.js 2.9 kB {0} [built]
      [37] ./app/directives/confirm.js 1.52 kB {0} [built]
      [38] ./app/directives/gravatar.js 3.31 kB {0} [built]
      [39] ./app/directives/order.js 1.32 kB {0} [built]
      [40] ./app/directives/lazy-background.js 242 bytes {0} [built]
      [41] ./app/directives/stack-margin.js 351 bytes {0} [built]
        + 22 hidden modules

but,pagekit isn't working correctly.
case: debug is not working .
page isn't loading correctly.
storage list isn't showing
by the way , my system is win10. when I execute “npm install” in root dir
there is a tips , fvsevent won't support it 。
Technical Details

Pagekit version: 1.0.8
Webserver:apache
Database:mysql
PHP Version:5.6

I would suggest to use the latest release package from our website: https://pagekit.com/download


Subviewport's render_target_update_mode keep setting itself to Always

Tested versions

Reproductible in 4.3 stable

System information
Godot v4.3.stable - macOS 14.5.0 - Vulkan (Mobile) - integrated Apple M1 Pro - Apple M1 Pro (10 Threads)
Issue description
render_target_update_mode keep setting itself to Always. If I change it to When Visible, save and reload the project, it's back to Always

Steps to reproduce
Create a scene, Add a Control node, add a SubviewportContainer as a child and a SubViewport as a child of that container.
Then change the update mode (or leave it at When Visible), then reload the project and the Update Mode will have set itself to Always
Minimal reproduction project (MRP)
MMR.zip

This is handled by the container and is probably something to document rather than a bug

Thank you for reporting, consolidating in:

https://github.com/godotengine/godot/issues/23729

See there for more details, if you think something was missed about this and it's not the same issue, please comment here and it can be reopened

Thanks for clarifying!


[5.8] Previous URL in Session contains current full URL

Laravel Version: 5.8.2
PHP Version: 7.2.10
Database Driver & Version: MySQL 5.7

Description:
session()->previousUrl() contains the current $request->fullUrl() instead of the real previous url.
Current situation is that \Illuminate\Session\Middleware\StartSession::storeCurrentUrl() is called before $next($request) is called, I would assume that the response should have been generated before storing the current url.
$this->storeCurrentUrl($request, $session);

$this->addCookieToResponse(
    $response = $next($request), $session
);

Steps To Reproduce:
public function testPreviousUrl(): void
{
    session()->setPreviousUrl($previousUrl = 'https://www.example.com/foo/bar/');

    \Route::get('foo', function() {
        return response(session()->previousUrl());
    })->middleware('web');

    $this->get('foo')->assertSeeText($previousUrl);
}

Generates
1) PreviousUrlTest::testPreviousUrl
   ✖ Failed asserting that 'https://***/foo' contains "https://www.example.com/foo/bar/".

The way it works currently is correct. The problem with your example is that in context of a test you're switching the url of the current session of a test instead of the session when the route is called.
This works:
Route::get('/', function () {
    session()->setPreviousUrl($previousUrl = 'https://www.example.com/foo/bar/');

    return response(session()->previousUrl());
});

@driesvints, you're right, I setup my test wrong. But how about when the session already contains a previous url like the example given below.
public function testPreviousUrl(): void
{
    \Route::get('foo', function() {
        return response(back()->getTargetUrl().' -- '.session()->get('bar'));
    })->middleware(\Illuminate\Session\Middleware\StartSession::class);

    $this->withSession([
        'bar' => $baz = 'baz',
        '_previous.url' => $previousUrl = 'https://www.example.com/foo/bar/',
    ])->get('foo')
        ->assertSeeText($previousUrl)
        ->assertSeeText($baz);
}

Here the previous url is set by some previous request and when calling back() we should return to that previous url (right?), so the target url should be the url of the previous request.
1) Tests\PreviousUrlTest::testPreviousUrl
   ✖ Failed asserting that 'https://www.example.com/foo -- baz' contains "https://www.example.com/foo/bar/".

@tswestendorp you shouldn't perform two route calls in the same test. Use separate test methods.

@driesvints There are some issue when using laravel browserkit tests though:
Given some controller route with a return redirect()->back():
<?php
public function archive($model)
{
    $model->archive();
    return redirect()->back();
}

And a browserkit test:
<?php
$this->actingAs($user)
    ->visit('model.show')
    ->click('archive')
    ->see(...)

You run into an infinite redirect on Laravel 5.8, rapidly filling up your storage/framework/session directory with session files.
I do think short test methods is a great "best practice" advise, but when using some functional testing to tie important things together you easily run into problems with this (undocumented?) change.
The whole purpose of the ->click('button') method in browserkit tests is to visit two or more routes in one test.

@okdewit can you create an issue on the browser kit testing repo with a full example of how this breaks?

My issue was fixed by https://github.com/laravel/framework/pull/27935 in Laravel 5.8.5 👍


[Splashscreen] Options to adjust splashscreen settings per game

Extension name
Spashcreen
Feature Description
suggestion: be able to choose the image that will appear on the splashscreen of each game individually, not depending on the background image.
for example: in the background image of the game it is an image but in the splashscreen it is another one I selected.
or being able to choose how the icon will react for each game individually, if I want the icon to appear on the splashscreen of a game on the left side, and in another game on the right side.
currently there is only one global option, all icons on the right or all on the left, for example.
thankful.
great job, keep it up
Screenshots
background image example:

spashscreen image exemple:

Splashscreen specific image has already been suggested and can be tracked in #261

adding to this: option to disable splash screen per game

Done in https://github.com/darklinkpower/PlayniteExtensionsCollection/commit/c1901b5f0bc23c0cd946e0cadfd14847410500a5 and https://github.com/darklinkpower/PlayniteExtensionsCollection/commit/63703ba6fed941813f1eeec0841ece10ba9e0fef


SPIR-V SER tests

Enable Shader Execution Reordering (SER) tests for output of SPIR-V
Update SER doc to say SPIR-V is supported.

Is there a reason we need to turn the expected result into SPIRV?
The text comparison is already very annoying to maintain every time we make changes to the compiler so that the generated result is different. We have to manually inspect the test to know whether or not the change in result is actually OK.
Turning this into SPIRV makes it even harder to tell if a different result is actually correct or not.

I wonder if we could make do with some less stringent matching for these. In lots of these sorts of tests we only care about the structure of a few salient lines, the tests could look something like
              <a>:   (fvec3) Load XXX
              <b>:   (float) Load XXX
                              HitObjectRecordMissNV <c>(hitObj_1) <a> <b> XXX XXX XXX
              XXX:   (bool) HitObjectIsMissNV <c>(hitObj_1)

Yes, that is why I am been arguing that we should include FileCheck.exe in our llvm build and use it to do pattern based checks instead of plain string comlarisons. Maintaining these tests is becoming an increasingly expensive burden whenever we change our IR generation logic.


[improve] PIP-347 Extend LTS release process to client SDKs

Motivation

Modifications

Verifying this change

[ ] Make sure that the change passes the CI checks.

(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)

Added integration tests for end-to-end deployment with large payloads (10MB)
Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

[ ] Dependencies (add or upgrade a dependency)
[ ] The public API
[ ] The schema
[ ] The default values of configurations
[ ] The threading model
[ ] The binary protocol
[ ] The REST endpoints
[ ] The admin CLI options
[ ] The metrics
[ ] Anything that affects deployment

Documentation

[ ] doc
[X] doc-required
[ ] doc-not-needed
[ ] doc-complete

Matching PR in forked repository
PR in forked repository:

Hi, this PIP is confict with https://github.com/apache/pulsar/pull/22564.


Grunt -> gulp

@hensleyrob : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Thank you for these corrections!


use or in place of if-else

@karansthr you can find more details about why this is required in #8262.


CODEC-286 upgrade to commons-lang v3.9

Handles https://issues.apache.org/jira/browse/CODEC-286
I understand it needs to also bump java to v1.8, but that should probably be done soon.
I work on java 1.6, 1.7, 1.8 and 11 projects at work, for the 1.6 and 1.7 projects we have no intension of upgrading and if we needed new commons-codec for new features or bug fixes, it would force us to upgrade which is probably a good thing.

Coverage remained the same at 93.84% when pulling 3b398edacf3607de5065a9e3b221cc4e1a8ac83d on nhojpatrick:CODEC-286 into 126f90424cc8f62d928686ec20c6c8bd944b527b on apache:master.

I am against the bump to 1.8 for convenience. There should be a good reason for this.
IIUC you can still include collections 3.9 as a test dependency and require Java 8 to run the build, but the target should be 1.7. We should at least get a last release out on the 1.7 target because it contains some fixes that are applicable to those still running against that version of Java.

Having a read of this and you can specify the test source and target separately (see maven compiler plugin):
    <maven.compiler.source>1.7</maven.compiler.source>
    <maven.compiler.target>1.7</maven.compiler.target>
    <maven.compiler.testSource>1.8</maven.compiler.testSource>
    <maven.compiler.testTarget>1.8</maven.compiler.testTarget>

So you can upgrade the build toolchain and tests to JUnit 5 but still support codec at 1.7. When I made the above changes to the pom this worked fine:
@Test
public void useLambda() {
    IntUnaryOperator f = i -> i * i;
    Assert.assertEquals(9, f.applyAsInt(3));
}

The class files extracted from the jar after running mvn package are version 7 (major version: 51) when inspected using javap -v.
Q. Is this going to work for all the other changes you are doing to support a module-info build?

Having a read of this and you can specify the test source and target separately (see maven compiler plugin):
    <maven.compiler.source>1.7</maven.compiler.source>
    <maven.compiler.target>1.7</maven.compiler.target>
    <maven.compiler.testSource>1.8</maven.compiler.testSource>
    <maven.compiler.testTarget>1.8</maven.compiler.testTarget>

So you can upgrade the build toolchain and tests to JUnit 5 but still support codec at 1.7. When I made the above changes to the pom this worked fine:
@Test
public void useLambda() {
    IntUnaryOperator f = i -> i * i;
    Assert.assertEquals(9, f.applyAsInt(3));
}

The class files extracted from the jar after running mvn package are version 7 (major version: 51) when inspected using javap -v.
Q. Is this going to work for all the other changes you are doing to support a module-info build?

changed as suggested

I am against the bump to 1.8 for convenience. There should be a good reason for this.
IIUC you can still include collections 3.9 as a test dependency and require Java 8 to run the build, but the target should be 1.7. We should at least get a last release out on the 1.7 target because it contains some fixes that are applicable to those still running against that version of Java.

should I bump a major version bump then and that be 1.8 and 11 dual support. e.g. 1.8 src/main/java and src/test/java, with 11 for just src/main/java11/module-info.java?
if someone could created a v2.x branch from master i'll be happy to get that working and also keep back porting v1.x fixes into the branch.

My question was whether your dual support would work with 1.7 and 11? Is there any difference with regard to modules between 1.7 and 1.8 since they are both pre java 9.
You can update the build tools to 1.8 so the changes are consistent across the four projects you are addressing (and you know it works), but the final jar has 1.7 class files.

My question was whether your dual support would work with 1.7 and 11? Is there any difference with regard to modules between 1.7 and 1.8 since they are both pre java 9.
You can update the build tools to 1.8 so the changes are consistent across the four projects you are addressing (and you know it works), but the final jar has 1.7 class files.

1.7 and 11 dual support should work... but never tried it, will try it out
but some other conversations around spring and class scanners might break so the dual support i'm thinking should be a major version bump. so then anyone upgrading knows it's a major change and as such can correctly tests before releasing themselves.

See how far you get. I'm happy to roll a final release at 1.7 if the consensus is to bump to 1.8 moving forward. There is an unreleased regression fix to restore some functionality from prior to v1.13 that is blocking some upgraders. Getting this out would allow users to upgrade and get all the other 1.13-1.15 work (about 1 year of change history) while not having to switch java versions.

In order to KISS it, perhaps we can:

Release on more time on Java 7
Update to Java 8

Gary
On Tue, Mar 3, 2020 at 7:11 AM Alex Herbert<EMAIL_ADDRESS>wrote:

Having a read of this and you can specify the test source and target
separately (see maven compiler plugin
https://maven.apache.org/plugins/maven-compiler-plugin/testCompile-mojo.html
):
<maven.compiler.source>1.7</maven.compiler.source>
<maven.compiler.target>1.7</maven.compiler.target>
<maven.compiler.testSource>1.8</maven.compiler.testSource>
<maven.compiler.testTarget>1.8</maven.compiler.testTarget>

So you can upgrade the build toolchain and tests to JUnit 5 but still
support codec at 1.7. When I made the above changes to the pom this worked
fine:
@Test
public void useLambda() {
IntUnaryOperator f = i -> i * i;
Assert.assertEquals(9, f.applyAsInt(3));
}
The class files extracted from the jar after running mvn package are
version 7 (major version: 51) when inspected using javap -v.
Q. Is this going to work for all the other changes you are doing to
support a module-info build?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/apache/commons-codec/pull/40?email_source=notifications&email_token=AAJB6N4SM7JJ3IPB5UAPXELRFTXVZA5CNFSM4K72BQRKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENTH3PI#issuecomment-593919421,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAJB6N4GIDOHMMTDZRTHKITRFTXVZANCNFSM4K72BQRA
.

In order to KISS it, perhaps we can: - Release on more time on Java 7 - Update to Java 8 Gary
…
On Tue, Mar 3, 2020 at 7:11 AM Alex Herbert @.***> wrote: Having a read of this and you can specify the test source and target separately (see maven compiler plugin https://maven.apache.org/plugins/maven-compiler-plugin/testCompile-mojo.html ): <maven.compiler.source>1.7</maven.compiler.source> <maven.compiler.target>1.7</maven.compiler.target> <maven.compiler.testSource>1.8</maven.compiler.testSource> <maven.compiler.testTarget>1.8</maven.compiler.testTarget> So you can upgrade the build toolchain and tests to JUnit 5 but still support codec at 1.7. When I made the above changes to the pom this worked fine: @test public void useLambda() { IntUnaryOperator f = i -> i * i; Assert.assertEquals(9, f.applyAsInt(3)); } The class files extracted from the jar after running mvn package are version 7 (major version: 51) when inspected using javap -v. Q. Is this going to work for all the other changes you are doing to support a module-info build? — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#40?email_source=notifications&email_token=AAJB6N4SM7JJ3IPB5UAPXELRFTXVZA5CNFSM4K72BQRKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENTH3PI#issuecomment-593919421>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJB6N4GIDOHMMTDZRTHKITRFTXVZANCNFSM4K72BQRA .

makes a lot of sense, i'm after 1.8 and 11 dual, and i understand and appreciated for some they need a stepping stone towards it. Until recently I was working on 1.6, 1.7 and 1.8 at work, over past 18 months we have managed to get all now on 1.8 with most frameworks or shared code doing dual support for 1.8 and 11.
So major version for each? so if needed we can do bug fixes for 1.7, 1.8 and 1.8/11 if needed.


Defined GPIO behavior during boot

While booting up the IOT2050, configured digital outputs might "flicker" between LOW and HIGH, and not show a defined state. Configuration in iot2050setup does not prevent this from happening:

The flickering occurs up-until the device is fully booted up.
Having a default LOW state during boot would be a desired requirement from safety perspective.

I think we discussed this somewhere already: Without consistent changes across the device trees (firmware and kernel), the safe state of GPIOs is "input" (high impedance). I think this is what we have today.

In fact, that may even be unsolvable via firmware patches, because before the firmware comes power-on, and that defines the GPIO mode in hardware, not by any software bit. @BaochengSu, am I right?

@jan-kiszka I think so, the GPIO pin has a initail mode before change it in the spl, that initail mode could not be configure to output low or high, even could not be a GPIO at all.
Anyway, I am contacting with TI regarding this topic.

Checked w/ TI, confirmed that our understand is correct.

Let's close this as "not possible", unfortunately.


Bring in a collection of commits addressing the new location.

@schmidtw in resources.go, you map everything in index (constant: mainMod). Can you have a look if you can group a subset of the resources and functions into different modules?
Have a read up on this issue on what I mean with this:
https://github.com/pulumiverse/pulumi-heroku/issues/1

@schmidtw in resources.go, you map everything in index (constant: mainMod). Can you have a look if you can group a subset of the resources and functions into different modules?
Have a read up on this issue on what I mean with this: pulumiverse/pulumi-heroku#1

Yes and thanks for the suggestion.  I had initially split things out, but thought I was over-thinking the API since it was so small.  I'll adjust them.

@schmidtw I don't know about the VRA specifics, so I leave this mainly up to you.
Though, I invite you to look at it from the perspective of the user of your VRA provider: what would make sense for this person when they know the VRA product terminology? Is the module and class naming "fluent" to use?
Changing this mapping later on results in breaking changes in the generated SDKs, which is something to prevent.

@schmidtw I don't know about the VRA specifics, so I leave this mainly up to you.
Though, I invite you to look at it from the perspective of the user of your VRA provider: what would make sense for this person when they know the VRA product terminology? Is the module and class naming "fluent" to use?
Changing this mapping later on results in breaking changes in the generated SDKs, which is something to prevent.

I spent a fair bit of time trying to find the right combination of modules.  This (5717df3) seems as reasonable as I can come up with & I'm sticking with that.
I was able to query a few things, create a VM and delete the VM so I think this code is working ok.  I'm completely new to VRA.