fix(ground_segmentation): add omp parallel for

Description

🤖[deprecated] Generated by Copilot at 5cb8eab
This pull request enhances the scan_ground_filter_nodelet class in the perception/ground_segmentation package by parallelizing and refactoring its point cloud processing logic. It uses OpenMP to speed up the classification of points into ground and non-ground segments, and it simplifies the input and output of some functions by using vectors of point indices.
Related Link
TIER IV INTERNAL LINK
Tests performed

I've tested by logging_simulator on my PC using sample-rosbag and internal bus rosbag and confirmed the processing time of ground_segmentation is decreased.

-
Current
After change

sample-rosbag

Bus rosbag

Effects on system behavior

Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.

[ ] I've confirmed the contribution guidelines.
[ ] The PR follows the pull request guidelines.

In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.

[ ] The PR follows the pull request guidelines.

Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.

[ ] There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@badai-nguyen do you have any plans for this PR, or should we close it for now?

@miursh I'm sorry for missed your mention. I updated the result I test this PR on Bench PC which shows the decrease processing_time so I will open it and hope can merge this PR. Could you review or assign someone to review it?


Dynatrace API Auto Tag Contract Change

Describe the bug
Monaco bug caused by a Dynatrace API change on the autoTag endpoint. Workaround available (see below).
The API response from Dynatrace differs between tenant versions 1.216 and 1.217 causing monaco to throw an error.
A new field type is introduced into rules.conditions.key
Tag definition from a 216 tenant:
{
  "name": "tagRule",
  "description": null,
  "rules": [
    {
      "type": "PROCESS_GROUP",
      "enabled": true,
      "valueFormat": "{HostGroup:Name}",
      "propagationTypes": [ "PROCESS_GROUP_TO_HOST", "PROCESS_GROUP_TO_SERVICE" ],
      "conditions": [{
          "key": {
            "attribute": "HOST_GROUP_NAME"
          },
          "comparisonInfo": {
            "type": "STRING",
            "operator": "EXISTS",
            "value": null,
            "negate": false,
            "caseSensitive": null
          }
        }]
    }],
  "entitySelectorBasedRules": []
}

Here's the same tag from 217. Notice the new type: "STATIC" attribute:
{
  "name": "tagRule",
  "description": null,
  "rules": [{
      "type": "PROCESS_GROUP",
      "enabled": true,
      "valueFormat": "{HostGroup:Name}",
      "propagationTypes": [ "PROCESS_GROUP_TO_HOST", "PROCESS_GROUP_TO_SERVICE" ],
      "conditions": [{
          "key": {
            "attribute": "HOST_GROUP_NAME",
            "type": "STATIC"
          },
          "comparisonInfo": {
            "type": "STRING",
            "operator": "EXISTS",
            "value": null,
            "negate": false,
            "caseSensitive": null
          }
        }]
    }
  ],
  "entitySelectorBasedRules": []
}

Log Output
Note that the tag rules are actually created but the error is:
2021-05-05 10:06:57 ERROR       Failed to create DT object app (HTTP 400)!
    Response was: {"error":{"code":400,"message":"Could not map JSON at 'rules[0].conditions[0].key.type' near line 15 column 21"}}, responsible config: projects\baseconfig\auto-tag\app.json
2021-05-05 10:06:57 ERROR Errors during deployment! Check log!

Workaround
The type field does not seem to be enforced (yet?) so just remove it from the JSON and monaco will continue to work without error on tenants >= 1.217

Hi @Dynatrace-Adam-Gardner, this change is affecting multiple API's and it's not something monaco should deal with. Just remove type: STATIC and everything should work as expected.


add custom path/filename prop override

when creating new "collections" - the json file is created in predefined place and format name .... its a good idea to have ability to override this conf

fixed in version 2.0.0


[SPARK-33767][SQL][TESTS] Unify v1 and v2 ALTER TABLE .. DROP PARTITION tests

What changes were proposed in this pull request?

Move the ALTER TABLE .. DROP PARTITION parsing tests to AlterTableDropPartitionParserSuite
Place v1 tests for ALTER TABLE .. DROP PARTITION from DDLSuite and v2 tests from AlterTablePartitionV2SQLSuite to the common trait AlterTableDropPartitionSuiteBase, so, the tests will run for V1, Hive V1 and V2 DS.

Why are the changes needed?

The unification will allow to run common ALTER TABLE .. DROP PARTITION tests for both DSv1 and Hive DSv1, DSv2
We can detect missing features and differences between DSv1 and DSv2 implementations.

Does this PR introduce any user-facing change?
No
How was this patch tested?
By running new test suites:
$ build/sbt -Phive -Phive-thriftserver "test:testOnly *AlterTableDropPartitionParserSuite"
$ build/sbt -Phive -Phive-thriftserver "test:testOnly *AlterTableDropPartitionSuite"

Test build #132699 has started for PR 30747 at commit 90d167d.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/37302/

Test build #132699 has finished for PR 30747 at commit 90d167d.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/132699/

@cloud-fan @HyukjinKwon Please, review this PR.

Test build #132773 has started for PR 30747 at commit 9126bc0.

Test build #132773 has finished for PR 30747 at commit 9126bc0.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37375/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/132773/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37375/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/37375/

Test build #132775 has started for PR 30747 at commit 62f539b.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37377/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37377/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/37377/

Test build #132775 has finished for PR 30747 at commit 62f539b.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/132775/

thanks, merging to master!


Flag parser issue: flag provided but not defined

Previous commit (162ff0f4b) broke the command line flag parser functionality. Container cannot be started.
 Only required if out-of-cluster.
  -master --kubeconfig
    	(Deprecated: switch to --kubeconfig) The address of the Kubernetes API server. Overrides any value in kubeconfig. Only required if out-of-cluster.

Fixed by #21


fix(yarn): fix yarn bad merge

yarn.lock was full of merge conflicts. This should solve the issue.
I also change the graphql version in graphiql to prevent a message about graphql conflicts.
babel-jest was not added properly
2 tests had new properties

Thanks for your PR, but it’s a duplicate of https://github.com/graphql/graphiql/pull/964


Best way to detect node had loaded?

Any way to react once the vnode has been rendered to the screen?
This doesn't seem to work:
function utterance(props, state, setState) {
  let inner = 'hey'
  let obj = {
    onload () {
      this.setAttribute("data-id", props.id)
    }
  }
  return H('div', obj, inner);
}

R(H(utterance), document.body)

You might have to wait for the lifecycle methods. I am currently thinking for the best approach to it so the API might change but try to use the build from here https://github.com/wavesoft/dot-dom/blob/ba038fbda06ad17d3deb983605fd406f3060851b/dotdom.min.js
You can see an example of the dog API in the PR here https://github.com/wavesoft/dot-dom/pull/12

Wow, that's fantastic! Thanks again!

This will be resolved with #12 please comment there if there are any other issues 👍


Web | Help & support | Error message should be visible

Environment

Platform : Website
Browser : Chrome
Chrome Version : Version 129.0.6668.90 (Official Build) (64-bit)
Build/ Commit ID : 1b5abbf0e850cf534720d6232944c772d859a9bd
Window : Windows 10 Pro
Version : 22H2
Server : Local / Dev / QA / PreProd / Production

Description

When a user tries to subscribe to a newsletter subscription using a wrong Username , Mail Id & Mobile number , user should get an ERROR message on display.

Test Steps

Open URL : https://www.drishtilearningapp.com/
Nevigate to footer and Click on Help & Support
Nevigate to Newsletter subscription
Enter Wrong username , gmail id and mobile number
Click on Subscribe Now

Test Data

Invalid Username :
Invalid Email :
Invalid Mobile Number :

#Expected

Error message should be visible : Entered Invalid Username or Mail id & Entered Invalid Mobile Number

Actual

No one ERROR message displayed on screen

@nishahedau Please suggest appropriate error message for the scenario mentioned as it is not mentioned on required documents.


Add patch to fix fmt v10.1.1 version

Description
fmt version 10.1.1 isn't reflected in core.h for tag 10.1.1, yielding a fmt CMake package with version 10.1.0.
This leads to find_package(fmt 10.1.1) failing if a user configures and installs fmt from the 10.1.1 tag.
The fmt maintainer prefers not to hotfix tag 10.1.1, so we should patch it in rapids-cmake.
This PR adds a patch to update the version in core.h to 100101, i.e. v10.1.1.
Checklist

[x] I am familiar with the Contributing Guidelines.
[ ] New or existing tests cover these changes.
[ ] The documentation is up to date with these changes.
[ ] The cmake-format.json is up to date with these changes.
[x] I have added new files under rapids-cmake/

[ ] I have added include guards (include_guard(GLOBAL))
[ ] I have added the associated docs/ rst file and update the api.rst

/merge


Deno.core.close(null) coerces to null to 0

  assertThrows(() => {
    Deno.close((null as unknown) as number);
  }, TypeError);

fails because instead of throwing TypeError the rid inside op_close is actually 0.

Issue: to_i32, to_u32 and the other numeric methods should throw type errors rather than coercing to zero.


tslint fails

When running npm run lint the command fails due to several code rule violations:
Client/app/index.ts[23, 52]: file should end with a newline Client/containers/chat/chat.component.ts[9, 1]: misplaced opening brace Client/containers/chat/chat.component.ts[18, 5]: misplaced opening brace Client/containers/not-found/not-found.component.ts[5, 15]: The selector of the component "NotFoundComponent" should be named kebab-case (https://goo.gl/mBg67Z) Client/containers/not-found/not-found.component.ts[10, 1]: misplaced opening brace Client/containers/not-found/not-found.component.ts[19, 5]: misplaced opening brace Client/shared/cache/storage/index.ts[4, 35]: file should end with a newline Client/shared/cache/storage/storage.browser.ts[29, 2]: file should end with a newline Client/shared/cache/storage/storage.node.ts[23, 2]: file should end with a newline Client/shared/meta/meta.store.ts[16, 2]: file should end with a newline Client/shared/meta/meta.store.ts[16, 2]: Missing semicolon
I will submit a PR to fix unless that is not advised.

Sure PR's are more than welcome!
Must of missed that one 👍


github-action version usage and guidelines

What are the current best practice guidelines for specifying the version of github-action to use?
https://docs.cypress.io/guides/continuous-integration/github-actions#Explicit-Version-Number shows:

whereas https://github.com/cypress-io/github-action#explicit-version is not so outspoken about using a full version tag:

Doesn't GHA update the major version number when there are breaking changes? Is it really "best practice" to use a full version tag, which means that when minor versions or patches are published, they won't be automatically used.
In any case, the document https://docs.cypress.io/guides/continuous-integration/github-actions should be updated to align with PR https://github.com/cypress-io/github-action/pull/668 which updates to v5.
See also guidance in GitHub Actions toolkit
"Recommendation: bind to major versions to get functionality and fixes but reserve binding to a specific release or SHA as a mitigation strategy for unforeseen breaks."
which seems to apply here as well.

The README: Explicit version does not need to be changed, so I transferred this issue instead to https://github.com/cypress-io/cypress-documentation/issues/5046.


428 - Use global primitive data types instead of local data type caches

This looks great! My only gripe is that when adding a new type to the system, we have to update three files: the CASS_VALUE_TYPE_MAPPING in cassandra.h and the two .gperf files. The former actually has some of the same info as the value_types_by_cql.gperf file.
Consider this alternative:

Add the class-names in CASS_VALUE_TYPE_MAPPING
Just as we have the DataType::native_types_ class variable, add a map variable for mapping class-names to DataType's (or the enum value), and add a map variable for mapping cql-type-names to DataType's.
Have the DataTypeInitializer initialize the maps

If it's an STL map, we'll have log(n) access, which is, of course, worse than the O(1) hash access provided by gperf. If that's a concern, maybe there's a general hash-map impl we can leverage. It may not be perfect hashing, but I think that would be good enough.

I'm not concerned O(log(n)) vs O(1). I'm trying to avoid heap allocation from being done in the static context. We did this a bunch when we first release the driver and had clients that had issues. I'm trying to remember what the issues were (I'll get back to you when I remember or find the issues). At first I wasn't even going to use static initialization (because this can have issues too). I was going to use a pattern similar to SSL's initialization, but this seems to be simple enough of a use case and doesn't have any heap allocation.

Side note: We could have moved the std::map to the dense_hash_map for O(1) performance. This is something I highly recommending with code moving forward. Esp. in cases where you can find a suitable empty key and/or deleted key.

I remembered the issue. Allocating heap memory in static initialization prevents users from allocating that memory using their custom heap allocator. Static initialization usually happens when the library is loaded, before the client application has had a chance to run, so the client application is unable to set their allocator for memory allocated during that prior static initialization.
Custom allocation is something we plan to support, in short order, because it has been requested by several major users. The issue: https://datastax-oss.atlassian.net/browse/CPP-360

I agree, it's not great having that same information duplicated in few files.  Maybe those .gperf files can be generated on-the-fly, as an intermediate step, using the information fromcassandra.h?

Heh, Since you both thumbs up it do you want to write the generator? :)

This is finally ready to review again. This iteration doesn't require having value type information in multiple places and is simpler. This uses dense_hash_map with a static allocator so its a hybrid between the two approaches.

Merged at 3c55e33328dd36c78b43be754a5056e7ddc5b6ea


remove unnecessary newline breaking expected text in patch script

brought up in #120
pending approval/testing from @zombieCraig
remove newline that I thought was normalized by python and blocked correct behavior in windows

Looks good, sir!


[Bug] Duplicate content for Marco Siccardi

Looks like we got twite your content:
https://www.wearedotnet.io/msiccdev
https://www.wearedotnet.io/MSicc
Which one should we keep, and which is to remove?
So that you know, you may use feed.type = personal (in your JSON cards) in order to avoid it will be shown on the landing page.
@MSicc @msiccdev

Ahh yea, thats because we imported the PlanetXamarin content... damn

I guess i can merge those


Add information for py3-pip-wheel package.

just for my or anyone else's reference
$ wolfictl advisory copy py3-pip py3-pip-wheel
$  wolfictl advisory id
CGA-m8v2-c2c5-24w8
$ vi py3-pip-wheel.advisories.yaml
# change the id by hand
$ git commit


rofi-rbw: add previously implicit dependency to rbw

Description of changes
rofi-rbw uses Python's subprocess.run(["rbw", ...]) to run rbw, making this program a dependency of rofi-rbw. This isn't part of the derivation yet, however, and so just installing rofi-rbw and running it will fail with an obscure error message.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

It seems to me that wtype is also required on GNOME on Wayland?

It seems to me that wtype is also required on GNOME on Wayland?

That's a different issue though. rofi-rbw supports multiple typing and clipboard "backends". It'll auto-choose what's installed. It's not clear to me how or if the derivation should choose one here. Probably it cannot. The issue I'm fixing here is a bit more fundamental, as rbw is a mandatory dependency and the program will completely fail without it.


Static properties.

I was going through the source and found that the HOC will hide static properties on wrapped components. This is a known issue with HOC as mentioned here.
So, either we should add this thing in the documentation or figure out some robust solution.

Hi!
I don't think it hides static props (some HOCs does, but inverted inheritance HOC does not). Can you provide a  code example?

I can see that only few properties are taken from the inherited component.

Check the roles in the inheritance: class ReactiveHOC extends BaseComp. Your original component - passed to view - is the parent (inherited) and ReactiveHOC (inheriting) is the child. There is no need to copy anything from your component to ReactiveHOC, since it inherits the from your component BaseComp already.
I only copy static props from stateless (function) components, since they can not be inherited from. Copying only React specific props here could be a problem as you mentioned, but people rarely store custom props on functions. It happens much more frequently with classes and static props, which is already handled by the inheritance.
I hope this make sense, I will try to figure out something more robust for stateless components too. (Maybe copying all enumerable own props could work.)

but people rarely store custom props on functions. It happens much more frequently with classes and static props, which is already handled by the inheritance.

I have not much experience with react but that was my only concern, since you more experience with React this makes sense. I am closing this issue for now.
Thanks,


try to run train.py but get TypeError: AbortedError.init() missing 2 required positional arguments: 'node_def' and 'op'

Sorry, I'm not sure the error there, that seems to potentially be a hardware issue, or local config?

Thanks @liaoxin2 for bring this up, did you solve it?


Cant run commands besides build

Hi, I'm new to this bot. I spent a few hours trying to figure this out. I was able to install the requirements and build my ad, but when it comes to posting, reposting, or even showing I keep getting this message. Here is an example of the error I get when trying to use the show command. I just downloaded all of the files when I started a few hours ago, so I'm pretty sure everything is good in terms of updates.
python3 kijiji_repost_headless [-u USERNAME] [-p PASSWORD] show
Note: A recent update has broken all previously generated .inf files. Please regenerate all your files - this script is not backwards compatible with previous versions. The commands are also changed. See README for details.
usage: kijiji_repost_headless [-h] [-u USERNAME] [-p PASSWORD]
{post,show,delete,nuke,check_ad,repost,build_ad}
...
kijiji_repost_headless: error: invalid choice: '[-u' (choose from 'post', 'show', 'delete', 'nuke', 'check_ad', 'repost', 'build_ad')

@ArthurG you can probably close this. The user hasn't responded in a month and likely hasn't even logged into their account since they first created it to submit this issue.


Mapbox (Independent Publisher)

When submitting a connector, please make sure that you follow the requirements below, otherwise your PR might be rejected. We want to make you have a well-built connector, a smooth certification experience, and your users are happy :)
If this is your first time submitting to GitHub and you need some help, please sign up for this session.

[x] I attest that the connector doesn't exist on the Power Platform today. I've verified by checking the pull requests in GitHub and by searching for the connector on the platform or in the documentation.
[x] I attest that the connector works and I verified by deploying and testing all the operations.
[x] I attest that I have added detailed descriptions for all operations and parameters in the swagger file.
[x] I attest that I have added response schemas to my actions, unless the response schema is dynamic.
[x] I validated the swagger file, apiDefinition.swagger.json, by running paconn validate command.
[x] If this is a certified connector, I confirm that apiProperties.json has a valid brand color and doesn't use an invalid brand color, #007ee5 or #ffffff. If this is an independent publisher connector, I confirm that I am not submitting a connector icon.

If you are an Independent Publisher, you must also attest to the following to ensure a smooth publishing process:

[x] I have named this PR after the pattern of "Connector Name (Independent Publisher)" ex: HubSpot Marketing (Independent Publisher)
[x] Within this PR markdown file, I have pasted screenshots that show: 3 unique operations (actions/triggers) working within a Flow. This can be in one flow or part of multiple flows. For each one of those flows, I have pasted in screenshots of the Flow succeeding.
[x] Within this PR markdown file, I have pasted in a screenshot from the Test operations section within the Custom Connector UI.
[x] If the connector uses OAuth, I have provided detailed steps on how to create an app in the readme.md.

Hi @SimonL26 congratulations on submitting your first Independent Publisher connector :) We're excited to start reviewing Mapbox within the next week.

[[certify-connector]]

Hello @SimonL26,
I hope you are doing well.
Congratulations, your connector is approved. We will move forward with the certification process. We are preparing your connector for production deployment and will queue up for the next deployment schedule. Once your connector onboards the next deployment schedule, it starts to deploy your connector in our production environments that typically takes 3-4 weeks.
Please let us know if you have any questions.
Thank you very much for working with us.

Hello @SimonL26,
I hope you are doing well.
Your connector is in production deployment and queued up for the next deployment schedule. This process typically takes 3-4 weeks. Please note that the documentation for your connector will not be generated until the deployment process is in the final steps.
Please let us know if you have any questions.
Thank you very much for working with us.

@SimonL26 Congratulations! The deployment of your connector and documentation page is now complete, We have a short survey on the connector certification process that we would like for you to complete. Your feedback is appreciated and will help us improve the program, thanks.


OCPBUGS-14846: webhook - set minimum TLS version back to 1.2 to support FIPS clusters

The goal of this PR is to support environments where TLS versions 1.2 is still used, mainly FIPS enabled systems. The boringcrypto enabled builds check for the maximum FIPS TLS version which is set to TLS1.2.
Initial upstream PR: https://github.com/kubernetes-sigs/aws-load-balancer-controller/pull/3313
Upstream follow-up PR: https://github.com/kubernetes-sigs/aws-load-balancer-controller/pull/3318
Note
https://github.com/kubernetes-sigs/aws-load-balancer-controller/pull/3318 uses TLSOpts of the webhook server, it's a feature which is available in controller-runtime 0.14.x. The currently used controller-runtime doesn't have it, so we cannot specify ciphers (as the upstream PR did), only the minimum TLS version.
Test
Operator e2e (not FIPS): https://github.com/openshift/aws-load-balancer-operator/pull/99
Manual test (FIPS):
# controller is there
$ oc -n aws-load-balancer-operator get pods
NAME                                                             READY   STATUS    RESTARTS   AGE
aws-load-balancer-controller-cluster-fcbc7bbdb-7rnx4             1/1     Running   0          2m19s
aws-load-balancer-operator-controller-manager-85d94d56c5-mjpq6   2/2     Running   0          5m11s

# it uses a manually built image (same as in the operator PR, see above)
$ oc -n aws-load-balancer-operator get pods aws-load-balancer-controller-cluster-fcbc7bbdb-7rnx4 -o yaml | yq .spec.containers[0].image
quay.io/aws-load-balancer-operator/aws-load-balancer-controller:8.10.234-tls12

# ingress webhook is on
$ oc -n aws-load-balancer-operator logs aws-load-balancer-controller-cluster-fcbc7bbdb-7rnx4 | grep 'webhook.*ingress'
{"level":"info","ts":1691706492.4913087,"logger":"controller-runtime.webhook","msg":"registering webhook","path":"/validate-networking-v1-ingress"}

# ingress resource got created with no TLS errors
$ oc -n echoserver get ing
NAME         CLASS   HOSTS   ADDRESS                                                                   PORTS   AGE
echoserver   alb     *       k8s-echoserv-echoserv-314d49d2d2-1425878010.us-east-1.elb.amazonaws.com   80      42s

https://github.com/kubernetes-sigs/aws-load-balancer-controller/pull/3318 merged, we should carry patch this change, removing WIP.
/retitle OCPBUGS-14846: webhook - set minimum TLS version back to 1.2 to support FIPS clusters

The issue seems still there.
1. % oc get clusterversion NAME      VERSION                                                AVAILABLE   PROGRESSING   SINCE   STATUS version   4.14.0-0.test-2023-08-10-015323-ci-ln-4n63sjk-latest   True        False         3h4m    Cluster version is 4.14.0-0.test-2023-08-10-015323-ci-ln-4n63sjk-latest 2. %  oc get -n aws-load-balancer-operator pods  NAME                                                             READY   STATUS    RESTARTS   AGE aws-load-balancer-controller-cluster-6b8c4db884-q45j5            1/1     Running   0          9m38s aws-load-balancer-operator-controller-manager-574896dcdc-lnz6j   2/2     Running   0          14m %  3.  % oc create -f ingress-test-internet-facing.yaml Error from server (InternalError): error when creating "ingress-test-internet-facing.yaml": Internal error occurred: failed calling webhook "vingress.elbv2.k8s.aws": failed to call webhook: Post "https://aws-load-balancer-controller-cluster.aws-load-balancer-operator.svc:9443/validate-networking-v1-ingress?timeout=10s": remote error: tls: protocol version not supported %

@ShudiLi : you are right. The new image with this controller's code needs to be added to ALBO. A PR for ALBO is coming.

/lgtm


Auto renew ssl cert

Describe the solution you'd like
A button or toggle switch that sets up a cron job to renew an certificate a few days before ssl cert expiry
Describe alternatives you've considered
I was going to set up my own one but i think it would be nice as an extra feature

@JS-E as standard it does this, indeed you can't stop it as far as I know, if its not renewing for you, there is a bug currently that stops the renew if Force SSL is ticked, untick and it can renew, then retick the Force SSL.

Okay, this isn't very clear when setting up an SSL cert. Would be cool if it was mentioned that it would auto renew and maybe give a date when it's planned to renew.

From the main page on the homepage
Free SSL
Built in Let’s Encrypt support allows you to secure your Web services at no cost to you. The certificates even renew themselves!

@the1ts - Didn't see that, thanks for pointing that out. Could this perhaps be shown on the actual SSL page as i still don't know what day the SSL cert will actually renew.

From my very amateur reading of the backend certificate code in NPM and the log files created, the renewal time isn't handled by NPM. NPM simply calls certbot on a 1 hour timer and certbot runs against all current certs, certbot tries a renew of the cert if certbots own renewal time has been met. I think the certbot renewal time is currently at 30 days before expiry. So you get a 90 day cert and after 60 days it will renew. The reason we use NPM and automated letsencrypt in general, is so we don't have to worry about renewal times any longer.
Some of this is not much better than guess work, but you can see in the logs when you do a manual renewal, a single cert is attempted in the certbot commandline and certbot will complain about not ready for renewal without reaching out to letsencrypt, when its the hourly renewal no cert is pointed to and not ready for renewal messaging is seen again from certbot but for all known certs.
Of note, I've not seen the automated, "your cert is about to expire" email that you get from letsencrypt at about 2 weeks to expiry since moving to NPM, but there is currently an issue around this which is waiting a new build so keep your container up to date.
In short we are automating so we don't need to worry about when the cert is renewed. If you have to know when a cert is renewed for some cert pinning problem perhaps NPM and lets encrypt in general isn't the tool you need.

After checking now and upgrading, i can see this automatically upgrading the cert so i'm happy to close


Add icon titles on hover in the interface, with the expected action/behavior

I feel we (lesser forms of life, aka non tech people) will need ToolTips (help or titles on hover on small icons where the action is not obvios - like table view). And the ? sign with help in many places.

Yes, this is a duplicated issue.
THanks for reporting!


Error when running command line 2

Hello! I´m trying your script but I get this error when running:
error: invalid utf-8 sequence of 1 bytes from index 6
at https://raw.githubusercontent.com/xaviripo/fmpd/master/mod.ts:5:0
How can I solve it? Thanks for your help!

Hi! What operating system are you on? What version of deno are you using (deno --version)? What command are you running exactly?

Windows 10;
deno 1.8.0 (release, x86_64-pc-windows-msvc)
v8 9.0.257.3
typescript 4.2.2
and the command is the one that you give: deno run --unstable --allow-net --allow-read --allow-write https://raw.githubusercontent.com/xaviripo/fmpd/master/mod.ts - < fbids.txt

I just tried that command with those same versions on Windows 10 and it works. Maybe try downloading the repository and running the command agains the local copy of the mod.ts file instead of the online copy.

Getting the same error, I don't know what could be causing it but thanks for your time

What terminal are you using? I've only tried Git Bash.

Oh, I used cmd from Windows. I've installed Git Bash, tried on it,  and the command run seems to not exists. If you can explain the process with the terminal I would appreciate it. I'm situated in the folder with all the neccesary files and deno program.

and the command run seems to not exists

The command you have to run starts with deno, not run. Make sure that Git Bash can find Deno by running deno --version, for example. If the version number shows up correctly, then you just have to run
deno run --unstable --allow-net --allow-read --allow-write https://raw.githubusercontent.com/xaviripo/fmpd/master/mod.ts - < fbids.txt

for the online version or, if that doesn't work,
deno run --unstable --allow-net --allow-read --allow-write mod.ts - < fbids.txt

for the local version.

Same output here
$ ./deno run --unstable --allow-net --allow-read --allow-write https://raw.githubusercontent.com/xaviripo/fmpd/master/mod.ts - < fbids.txt
error: invalid utf-8 sequence of 1 bytes from index 6
at https://raw.githubusercontent.com/xaviripo/fmpd/master/mod.ts:4:0
Also with the local archives same error
It detects deno
$ ./deno --version
deno 1.8.0 (release, x86_64-pc-windows-msvc)
v8 9.0.257.3
typescript 4.2.2

I'm sorry, I'm not capable of reproducing the error. As this seems to be an error with how Deno processes the mod.ts file, you could try to report a bug at the Deno repo and see if they have anything to see regarding this. If you find any other clue please report it here and I will try to look further into it.


Allow GraphiteBridge to set a prefix

Hi,
while testing and maybe transitioning, I’m very grateful for the GraphiteBridge.
However as far as I can tell, there’s no way to namespace (with a dot) my metrics and they just land in the main “directory”.
Could you please add a way to set a prefix that is prepended to all metrics?

That sounds like a reasonable and simple request, I'll add it to the Hacktoberfest list.

Hi Brian,
I was looking into this. Does this mean bridge.graphite.GraphiteBridge.push() needs an optional namespace parameter? And it gets _sanitize()ed with . preserved and prepended to name.

I'd add an optional prefix parameter so as not to confuse it with the namespace parameter that Prometheus client libraries have. I'm not sure there's any need to sanitize it, as it's provided by a user that knows that it's going to graphite and what storage backend they have - unlike normal label values which can be arbitrary Unicode.

Fixed by #56

Sweet, thanks!


Cannot read properties of undefined (reading 'none')

Describe the bug
Cannot read properties of undefined (reading 'none')
Profile/Location
A link to the profile which the bug occurred with, if applicable (e.g. https://sky.shiiyu.moe/stats/Minikloon/Banana)
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):
Windows 10

chrome,


Page Control doesn't synchronize with a swipe action

Dear developer,
I tried to install this SwiftyOnboard pod into my project, but its page control doesn't synchronize with a swipe action.
For example, even if I swipe the display to the next page, the dot point of page control doesn't move.
Plus, even if I tap the dot, the display doesn't move to the designated page.
In order to synchronize page control and swipe and tap actions like the demo, where and which code should I add?
My environment is Xcode 9 beta 6, macOS Sierra.
I'm a beginner who started learning of iOS development 2 months ago, so I wonder if you cloud explain a solution to me simply.
Thanks in advance from Japan.

Hey there @y-hara1031 I'll try to guide you so that you can solve this as soon as possible :)

Plus, even if I tap the dot, the display doesn't move to the designated page.

This is an existing bug, I'm afraid it's something I'm going to have to fix in the following days.

For example, even if I swipe the display to the next page, the dot point of page control doesn't move.

This should be working correctly out of the box. Did you edit some of the code inside any of the following files? (SwiftyOnboard.swift, SwiftyOnboardOverlay.swift, SwiftyOnboardPage.swift)

Could you send over a code snippet of your implementation of the onboarding?
Cheers.

@juanpablofernandez Thanks for your reply and help.
No, I didn't edit the files so much.
Basically, I followed the guidance of this pod and write the code.
Anyway, I'll send you the snippets that I wrote.
I wonder if you could correct that.
Thanks in advance.

ViewController.swift
`import UIKit
import SwiftyOnboard
class ViewController: UIViewController,SwiftyOnboardDelegate, SwiftyOnboardDataSource {
@IBOutlet var swiftyOnboard: SwiftyOnboard!

override func viewDidLoad() {
    super.viewDidLoad()

    swiftyOnboard.style = .light
    swiftyOnboard.delegate = self
    swiftyOnboard.dataSource = self
    swiftyOnboard.fadePages = true
    swiftyOnboard.backgroundColor = UIColor(red: 46/256, green: 46/256, blue: 76/256, alpha: 1)

}
@objc func handleSkip() {
    swiftyOnboard?.goToPage(index: 2, animated: true)

}

@objc func handleContinue(sender: UIButton) {
    let index = sender.tag
    swiftyOnboard?.goToPage(index: index + 1, animated: true)
}
func swiftyOnboardNumberOfPages(_ swiftyOnboard: SwiftyOnboard) -> Int {
    return 3
}

func swiftyOnboardPageForIndex(_ swiftyOnboard: SwiftyOnboard, index: Int) -> SwiftyOnboardPage? {
    let view = CustomPage.instanceFromNib() as? CustomPage
    view?.image.image = UIImage(named: "\(index).png")
    if index == 0 {
        //On the first page, change the text in the labels to say the following:
        view?.titleLabel.text = "このアプリでは"
        view?.subTitleLabel.text = "いろんな事をシェアしよう"
    } else if index == 1 {
        //On the second page, change the text in the labels to say the following:
        view?.titleLabel.text = "出かけた場所の上空に"
        view?.subTitleLabel.text = "写真を保存したり、落書きをしたり"
    } else {
        //On the thrid page, change the text in the labels to say the following:
        view?.titleLabel.text = "さあはじめましょう！"
        view?.subTitleLabel.text = "楽しい世界へようこそ！"
    }
    return view
}

func swiftyOnboardViewForOverlay(_ swiftyOnboard: SwiftyOnboard) -> SwiftyOnboardOverlay? {
    let overlay = CustomOverlay.instanceFromNib() as? CustomOverlay
    overlay?.skip.addTarget(self, action: #selector(handleSkip), for: .touchUpInside)
    overlay?.buttonContinue.addTarget(self, action: #selector(handleContinue), for: .touchUpInside)
    return overlay
}

func swiftyOnboardOverlayForPosition(_ swiftyOnboard: SwiftyOnboard, overlay: SwiftyOnboardOverlay, for position: Double) {
    let overlay = overlay as! CustomOverlay
    let currentPage = round(position)
    overlay.pageControl.currentPage = Int(currentPage)
    overlay.buttonContinue.tag = Int(position)
    if currentPage == 0.0 || currentPage == 1.0 {
        overlay.buttonContinue.setTitle("続ける", for: .normal)
        overlay.skip.setTitle("スキップ", for: .normal)
        overlay.skip.isHidden = false
    } else {
        overlay.buttonContinue.setTitle("はじめる!", for: .normal)
        overlay.skip.isHidden = true
    }
}

override func didReceiveMemoryWarning() {
    super.didReceiveMemoryWarning()
    // Dispose of any resources that can be recreated.
}

}`

CustomPage.swift
`import Foundation
import SwiftyOnboard
class CustomPage: SwiftyOnboardPage {
@IBOutlet weak var titleLabel: UILabel!
@IBOutlet weak var image: UIImageView!
@IBOutlet weak var subTitleLabel: UILabel!

class func instanceFromNib() -> UIView {
    return UINib(nibName: "CustomPage", bundle: nil).instantiate(withOwner: nil, options: nil)[0] as! UIView
}

}`

CustomOverlay.swift
`import Foundation
import SwiftyOnboard
class CustomOverlay: SwiftyOnboardOverlay {
@IBOutlet weak var skip: UIButton!
@IBOutlet weak var buttonContinue: UIButton!
@IBOutlet weak var contentControl: UIPageControl!

override func awakeFromNib() {
    super.awakeFromNib()

    buttonContinue.layer.borderColor = UIColor.white.cgColor
    buttonContinue.layer.borderWidth = 1
    buttonContinue.layer.cornerRadius = buttonContinue.bounds.height / 2
}

class func instanceFromNib() -> UIView {
    return UINib(nibName: "CustomOverlay", bundle: nil).instantiate(withOwner: nil, options: nil)[0] as! UIView
}

}`

That's all.

@y-hara1031 The first issue has been fixed, I just updated the pod.
The reason you are getting these issues is because you are using a custom overlay. When doing this you must handle the logic for the UIPageControl just like you are handling the logic for the continue/skip buttons, when using the default Overlay this logic is handled for you.
Does your CustomOverlay succeed in showing?

I think I know the source of your problem
In the DataSource Method: swiftyOnboardOverlayForPosition you are updating the PageControl's current page overlay.pageControl.currentPage = Int(currentPage) this however is the default UIPageControl that belongs to the class SwiftyOnboardOverlay. You are subclassing SwiftyOnboardOverlay and creating your own UIPageControl which is named contentControl as you can see here: @IBOutlet weak var contentControl: UIPageControl! therefore setting the currentPage for pageControl isn't going to display the changes since it's a different UIPageControl.
Replace overlay.pageControl.currentPage = Int(currentPage) with overlay.contentControl.currentPage = Int(currentPage) and it should do the trick.

Yes, my CustomOverlay succeed normally except for page control.
I appreciate your guide.
I'll try to modify my project file.
Thank you very much!

Firstly, I replace the code overlay.pageControl.currentPage = Int(currentPage) with overlay.contentControl.currentPage = Int(currentPage) in the ViewController.swift.
Then my page control gets to work normally.
In other words, when I swipe the display, the bubble moves to the next.
Secondly, in CustomOverlay.swift, I created IBAction of contentConrol and added self.overlay?.contentControl.addTarget(self, action: #selector(didTapPageControl), for: .allTouchEvents).
And added the method below.
func didTapPageControl(_ sender: Any) {         let pageControl = sender as! UIPageControl         let page = pageControl.currentPage         self.goToPage(index: page, animated: true)     }
However, an error message appeared like the below.
Value of type 'CustomOverlay' has no member 'goToPage'
Did I mistake the place to add the method?

I'm glad the first issue was resolved!
You are getting the second issue because self.goToPage(index: page, animated: true) is a method that belongs to the SwiftyOnboard class. The CustomOverlay class doesn't have it, so you are getting the error, the same goes for the 'overlay' error.
That's why I said above to add the target programmatically to the PageControl, inside your viewController and under the swiftyOnboardViewForOverlay  method. I also made a mistake, once you add the action programmatically and add the didTapPageControl function replace self.goToPage(index: page, animated: true) with swiftyOnboard.goToPage(index: page, animated: true) this should fix the issues.
Good luck!

Thank you very much for your courteous guide again!
I misunderstood the place where I had to add the method.
Thanks to your guide, now the all functions of the pod gets to work normally in my project.
Firstly,  I added overlay?.contentControl.addTarget(self, action: #selector(didTapPageControl), for: .allTouchEvents) in swiftyOnboardViewForOverlay method in ViewController.swift.
Secondly, I added the method func didTapPageControl(_ sender: Any) {         let pageControl = sender as! UIPageControl         let page = pageControl.currentPage         swiftyOnboard.goToPage(index: page, animated: true)     }.
Then Xcode instructed me to add @objc in the front of didTapPageControl method.
After that, build succeeded and finally the page control got to work perfectly.
Anyway, I really appreciate your repeated support.
I will make the most of your pod for my project.
Muchas gracias!

I'm glad everything is now working.
Happy Coding!


Cow: Blacklist<PHONE_NUMBER>0

Cow requests the blacklist of the number<PHONE_NUMBER>0. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

Approved by tripleee in Charcoal HQ


Basic Tooltips creation without html

Hello,
It is more a feature request but I did not find how to create one.
It could be nice to be able to complete the hovertools by adding other column.
The best way I see could be in the same format as bokeh with a list of tuple:
TOOLTIPS = [
    ("index", "$index"),
    ("(x,y)", "($x, $y)"),
    ("desc", "@desc"),
]

that you get a basic funcy tooltips without to dive into html code

Hi @leopoletti,
I had a look at the code and I would propose the following API change:

Deprecation of hovertool_string
Usage of hovertool parameter as:

string: Use HTML for Hovertool
List of tuples: pass to tooltips ( as shown above)
True (default): use default tooltips with passed columns
False: Do not use tooltips

This feature however needs some development and refactoring. As a quickfix, you can go to pandas-bokeh/plot.py and comment out the following 2 lines:

Hope this helps you,
best Patrik

Hello @PatrikHlobil ,
It was not working since the code is based on string for hovertool_string and the new input is list of tuples.
Thus I change the code to this and its work as a first quick fix:
    if hovertool_string is not None:
        lstColumns=[tup[1] for tup in hovertool_string]
        lstColumns=[col.replace('@',"").replace('{',"").replace('}',"") for col in lstColumns]

        additional_columns=[col for col in lstColumns if col in df.columns ]

best Léopold

hi @leopoletti ,
yes this seems better for now. However, as I mentioned above the whole API should be changed.
Best Patrik


Hide Answer Bar

Since anki provides shortcut keys for answering the questions. Would it be possible to add a feature that removes the answer bar all together? This way, there would be nothing taking your eyes of your cards. Thanks in advance!

Under "Answer Bar Visibility" in the menu options you can set the answer bar to be hidden. Note that if you hover your mouse over them they'll appear again, but shortcuts should still work


[fuzzing] adding a flamegraph command

@bors-libra r=sausagee

:pushpin: Commit 2e76743 has been approved by sausagee

:hourglass: Testing commit 2e767439397ca0a685b4964f26c5c545f28ce642 with merge 3b406d9013f6aebef2021c26366b20eccd66780e...

:sunny: Test successful - checks-actions_land_blocking_test, checks-circle_commit_workflow
Approved by: sausagee
Pushing 3b406d9013f6aebef2021c26366b20eccd66780e to master...


Add installation and compilation help to tutorial

Need to add a mention of sourcing to tutorial, and not use pdirun (as currently), which is mandatory starting with the exercise 9.
See issues related to Jupyter Notebook, Docker.

Starting with the exercise 9 of the tutorial, further plugins need to be enabled manually, and sourced to.
The tutorial here may need to link to the PDI usage setup, in order to use source pdirun or source [...]/env.bash.
Others issues worth mentioning here are #3 and #4 to help containerize the tutorial and prevent leaking setups between default and custom location.


Enable Metal for macOS x86_64.

This PR enables Metal for macOS x86_64.
Additionally, rendering_context_driver_metal.mm now logs the actual Metal GPU family, as the previously computed value was incorrect.

CC @stuartcarnie


release version: 0.2.4

Coverage remained the same at 94.468% when pulling e3ec2f473bf9e61488b1e2bd2f70c37d901be8f2 on docUpdate into add813583c76ff4b831719d4bb6e8792225431b2 on master.


Teach test scripts about ch.exe

Added support for ch.exe (run-js.py and polyfills in js scripts)
Todo, currently no script to build/download ch.exe it has to be built separately.

lgtm, thanks!


gosymtab may be empty

See
https://groups.google.com/forum/#!topic/golang-nuts/7PIDQtjMOUE[1-25]
Fixes #3

LGTM.

Sorry for the late merge. Thanks! ✨

@FiloSottile, I worked on improving the style of this code, leading to https://github.com/shurcooL/play/blob/456f0172d733e4e6730f290ed042849370c132a7/200/cmd/importpathof/main.go#L28-L74. If you'd like, I could send those improvements upstream here as a PR.


Ident c185 use motorcycle router

Manditory Checks

[x] I added new tests for the issue I fixed or the feature I built
[ ] I ran npm test for the package I'm modifying
[ ] I used npm run commit instead of git commit

 REFACTOR: Drop-in replacement of our router with @motorcycle/router

Just need to fix the failing tests that have to do with unused imports


Root ACL should return 409 when attempting to DELETE/PATCH the backstop ACL

JIRA Ticket:
https://jira.duraspace.org/browse/FCREPO-2870
https://jira.duraspace.org/browse/FCREPO-2871
What does this Pull Request do?
Root ACL should return 409 when attempting to DELETE/PATCH the backstop ACL.
Added tests to verify:

Cannot DELETE/PATCH backstop ACL
Can PUT/PATCH/DELETE user-defined ACL.

How should this be tested?

Verify that the tests pass for fcrepo-http-api

Interested parties
@fcrepo4/committers

@dbernstein, I was trying to test PUT/PATCH/DELETE user-defined ACL for root, but I got a 409 for the PUT so I was not able to manually test.
curl -u"fedoraAdmin:fedoraAdmin" -i  http://localhost:8080/rest/fcr:acl -XPUT -H"Content-Type: text/turtle" --data-binary @body.ttl

@prefix acl: <http://www.w3.org/ns/auth/acl#> .
@prefix foaf: <http://xmlns.com/foaf/0.1/> .

<#readAccess> a acl:Authorization ;
    acl:agent foaf:Agent ;
    acl:mode acl:Read .

@dbernstein The problem was that I missed the main acl type. I was able to manually test with the following steps.

Put an acl

curl -u"fedoraAdmin:fedoraAdmin" -XPUT http://localhost:8080/rest/fcr:acl --data-binary @body.ttl -H"Content-Type: text/turtle"

body.ttl
@prefix acl: <http://www.w3.org/ns/auth/acl#> .
@prefix foaf: <http://xmlns.com/foaf/0.1/> .
@prefix webac: <http://fedora.info/definitions/v4/webac#> .

<> a webac:Acl .

<#readAccess> a acl:Authorization ;
    acl:agent foaf:Agent ;
    acl:mode acl:Read .

Patch the acl

curl -u"fedoraAdmin:fedoraAdmin" -XPATCH http://localhost:8080/rest/fcr:acl --data-binary @update.rq -H"Content-Type: application/sparql-update"

update.rq
PREFIX acl: <http://www.w3.org/ns/auth/acl#>
INSERT { <#readAccess> acl:mode acl:Write . } WHERE { }

Delete the acl

curl -I -u"fedoraAdmin:fedoraAdmin" -XDELETE http://localhost:8080/rest/fcr:acl


Upgrade Zustand

Description

Upgrade zustand and immer dependencies
Zustand v4+ deprecated some types so brought them in-package

Awesome, thanks for the PR @enchorb. Could you fix the CI? Then I'll land it.
Fixes #53

@zbeyens I believe the one test errored on CI because it is on node 12, added another commit to bump CI node version to 16

@enchorb You don't need to bump the version, changeset will take care of this.

@zbeyens If you need another maintainer I'd be happy to be added

Sure, invite sent!


Replace rails error pages with generic gov ones

Have asked Dan C to take a look at this – he’s setting up a GitHub account.

[5f90e22] fixes the spacing/layout of error pages, but I wasn’t able to get a 404 page to show, so this is just guess work, for now.

@paulrobertlloyd have updated the screenshots post your spacing changes so check that

have updated the screenshots post your spacing changes so check that

Sweet. All checks out! Quite impressed that I can debug layouts blind… 😆

Content looks fine to me!


Current ktfmt version doesn't work with Gradle 7.2

🐛 Describe the bug
After updating a project using ktfmt-gradle to Gradle 7.2, ktfmt-gradle fails to process files. The error message looks like :point_down:  (repeated for each file that needs to be processed):
[ktfmt] Failed to analyse: /home/me/src/srs/app/src/main/java/io/github/rsookram/srs/App.kt
[ktfmt] e: Generic error during file processing

The error message isn't too helpful, but upon further debugging, the code is falling into this path and the actual Exception is:
java.lang.RuntimeException: Unsupported runtime Kotlin version: 1.5.21
        at com.facebook.ktfmt.FormatterKt.createAstVisitor(Formatter.kt:160)
        at com.facebook.ktfmt.FormatterKt.prettyPrint(Formatter.kt:136)
        at com.facebook.ktfmt.FormatterKt.format(Formatter.kt:124)
        at com.ncorti.ktfmt.gradle.tasks.KtfmtBaseTask.processFile$plugin(KtfmtBaseTask.kt:103)
        at com.ncorti.ktfmt.gradle.tasks.KtfmtBaseTask$processFileCollection$$inlined$map$lambda$1.invokeSuspend(KtfmtBaseTask.kt:122)
        at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33)
        at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:106)
        at kotlinx.coroutines.scheduling.CoroutineScheduler.runSafely(CoroutineScheduler.kt:571)
        at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.executeTask(CoroutineScheduler.kt:750)
        at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.runWorker(CoroutineScheduler.kt:678)
        at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.run(CoroutineScheduler.kt:665)

This seems to be because ktfmt-gradle is using ktfmt version 0.24, but Kotlin 1.5 isn't supported until ktfmt 0.25.
It happens when upgrading to Gradle 7.2 because Gradle updated its version of Kotlin to 1.5.21 in that version.
✅ Expected behavior
I expected ktfmt-gradle to continue to process files like before the Gradle update.
💣 Steps to reproduce
Run either the ktfmtFormat or ktfmtCheck task on a project using Gradle 7.2.
I was also able to reproduce the issue by cloning the ktfmt-gradle repo, updating to Gradle 7.2, then running the tests with ./gradlew test.
:wrench: Steps to fix?
Updating ktfmt to 0.25 or newer seems to work for me. In my local clone of ktfmt-gradle, I was able to update Gradle to 7.2 and ktfmt to 0.25 (0.27 is fine too), and the tests passed. I can put up a PR with these changes if it sounds reasonable. I'm not sure if there's a reason for sticking with an older ktfmt version though.
📱 Tech info

OS: Linux
Library version: 0.6.0 (although it also happens at the HEAD of master: https://github.com/cortinico/ktfmt-gradle/commit/7521ad34601fad195f66a2f651271c5940b2f247)

Version 0.7.0 should solve this 👍 Let me know if it does now


WQ file with duplicate column names

A few of the raw water quality files have headers that have the duplicate column name. This causes the data import to fail. Manually fixed for the few files with this issue by renaming the field to another alias since it doesn't need to be imported to the data base. If more cases popup, we should implement a function to test for this.
Example: ARC_060314_BKO_WQP_GN1 has two TurbsSC fields (units Volts & NTU). Only want to keep the NTU one.

manually renamed the header in the few files where this was an issue


REQUEST FOR G DRIVE API V3 SUPPORT

As per this https://developers.google.com/apis-explorer/#p/  link, one new version updated in Drive Api service as v3, so need to update drive file also from v2 to v3 which is located in https://github.com/google/google-api-php-client/blob/master/src/Google/Service/Drive.php Line no.86.
I checked latest version of 1.1.6 Release, in this package the drive file not having current version v3
Please fix ASAP

Any updates regarding version issue,  we need API V 3 support drive in google-api-php-client immediately.
Please any one update.

Try including this file and you should be good to go.


re-add breeze to 2.12 build

it's in the 2.11.x-jdk8 build but not the 2.12 one. not sure how that happened, probably a mistake during merging

this might not be worth tackling unless we can upgrade spire at the same time. which requires adding machinist. which we should have anyway.

fixed by #303


Added Lighthouse Game

PR Description 📜
Build a Lighthouse is an immersive and challenging strategy game where players are tasked with constructing a vital structure that will guide ships safely to shore before darkness falls. If player failed to build it brefore time, he will lose the game.
Fixes #464

[X] I follow CONTRIBUTING GUIDELINE & CODE OF CONDUCT of this project.
[X] I have performed a self-review of my own code or work.
[X] I have commented my code, particularly in hard-to-understand areas.
[X] My changes generates no new warnings.
[X] I have followed proper naming convention showed in CONTRIBUTING GUIDELINE
[X] I have added screenshot for website preview in assets/images
[X] I have added entries for my game in main README.md
[X] I have added README.md in my folder
[X] I have added working video of the game in README.md (optional)
[X] I have specified the respective issue number for which I have requested the new game.

Thank you @gp0814 ,for creating the PR and contributing to our GameZone 💗
Review team will review the PR and will reach out to you soon! 😇
Make sure that you have marked all the tasks that you are done with ✅.
Thank you for your patience! 😀

Thank you  @gp0814 , for your valuable time and contribution in our GameZone 💗.
It’s our GameZone, so Let’s build this GameZone altogether !!🤝
Hoping to see you soon with another PR again 😇
Wishing you all the best for your journey into Open Source🚀


Bottom in Mainmenu is overflowing

The bottom is overflowing if the device is just a bit smaller

problem fixed


a problem in detect.py

Traceback (most recent call last):
File "detect.py", line 221, in
pt1 = tuple(reversed(map(int, pt1)))
TypeError: argument to reversed() must be a sequence
how to deal with ?

The simplest (but not necessarily the most elegant) solution I could think of:
pt1 = tuple(reversed(list(map(int, pt1))))


🐛 [BUG] Batchsize Problem in PerAtomMSELoss

Describe the bug
when I use NequIP to training and validation in a Fe-C-H-O dataset (traindata frame number is 12135 while  test data frame number is 1000) with batchsize for training is 5 and batchsize for validation is 5, error will occur:
Traceback (most recent call last):
  File "/home/liuzq/apps/anaconda3/envs/nequip2/bin/nequip-train", line 8, in <module>
    sys.exit(main())
  File "/home/liuzq/apps/anaconda3/envs/nequip2/lib/python3.9/site-packages/nequip/scripts/train.py", line 78, in main
    trainer.train()
  File "/home/liuzq/apps/anaconda3/envs/nequip2/lib/python3.9/site-packages/nequip/train/trainer.py", line 778, in train
    self.epoch_step()
  File "/home/liuzq/apps/anaconda3/envs/nequip2/lib/python3.9/site-packages/nequip/train/trainer.py", line 916, in epoch_step
    self.batch_step(
  File "/home/liuzq/apps/anaconda3/envs/nequip2/lib/python3.9/site-packages/nequip/train/trainer.py", line 855, in batch_step
    loss, loss_contrib = self.loss(pred=scaled_out, ref=_data_unscaled)
  File "/home/liuzq/apps/anaconda3/envs/nequip2/lib/python3.9/site-packages/nequip/train/loss.py", line 104, in __call__
    _loss = self.funcs[key](
  File "/home/liuzq/apps/anaconda3/envs/nequip2/lib/python3.9/site-packages/nequip/train/_loss.py", line 90, in __call__
    loss = loss / N
RuntimeError: The size of tensor a (461) must match the size of tensor b (5) at non-singleton dimension 0

I have tried lots of different batchsize for training and validation, which all failed unless I set 1 for batchsize for training and validation. but batchsize=1 is so unefficient.
To Reproduce
This is my yaml file:
root: FeCHO_valid
run_name: FeCHO_run
workdir: FeCHO_workdir
seed: 42
# dataset_seed: 456
append: true
default_dtype: float32
allow_tf32: false
device:  cuda

# == network ==
model_builders:
 - SimpleIrrepsConfig
 - EnergyModel
 - PerSpeciesRescale
 - ForceOutput
 - RescaleEnergyEtc

r_max: 6.0
num_layers: 6

l_max: 2
parity: true
num_features: 32

nonlinearity_type: gate
resnet: false

nonlinearity_scalars:
  e: silu
  o: tanh

nonlinearity_gates:
  e: silu
  o: tanh

# radial network basis
num_basis: 8
BesselBasis_trainable: true
PolynomialCutoff_p: 6

# radial network
invariant_layers: 3
invariant_neurons: 64
avg_num_neighbors: auto
use_sc: true
compile_model: false

# for extxyz file
dataset: ase
dataset_file_name: ./data/traindata.xyz
ase_args:
  format: extxyz
# include_keys:
#   - user_label
# key_mapping:
#   user_label: label0

# A list of chemical species found in the data. The NequIP atom types will be named after the chemical symbols and ordered by atomic number in ascending order.
# (In this case, NequIP's internal atom type 0 will be named H and type 1 will be named C.)
# Atoms in the input will be assigned NequIP atom types according to their atomic numbers.
chemical_symbols:
  - H
  - C
  - O
  - Fe

# If you want to use a different dataset for validation, you can specify
# the same types of options using a `validation_` prefix:
validation_dataset: ase
validation_dataset_file_name: ./data/test_1000.xyz                                            # need to be a format accepted by ase.io.read

# logging
wandb: true                        # we recommend using wandb for logging
wandb_project: FeCHO_valid                         # project name used in wandb
wandb_watch: false

# see https://docs.wandb.ai/ref/python/watch
# wandb_watch_kwargs:
#   log: all
#   log_freq: 1
#   log_graph: true

verbose: info         # the same as python logging, e.g. warning, info, debug, error. case insensitive
log_batch_freq: 200    # batch frequency, how often to print training errors withinin the same epoch
log_epoch_freq: 1     # epoch frequency, how often to print
save_checkpoint_freq: -1    # frequency to save the intermediate checkpoint. no saving of intermediate checkpoints when the value is not positive.
save_ema_checkpoint_freq: -1  # frequency to save the intermediate ema checkpoint. no saving of intermediate checkpoints when the value is not positive.

# training
n_train: 12135                   # number of training data
n_val: 1000                      # number of validation data
learning_rate: 0.005        # learning rate, we found values between 0.01 and 0.005 to work best - this is often one of the most important hyperparameters to tune
batch_size: 5        # batch size, we found it important to keep this small for most applications including forces (1-5); for energy-only training, higher batch sizes work better
validation_batch_size: 5      # batch size for evaluating the model during validation. This does not affect the training results, but using the highest value possible (<=n_val) without running out of memory will speed up your training.
max_epochs: 100000   # stop training after _ number of epochs, we set a very large number here, it won't take this long in practice and we will use early stopping instead
train_val_split: random    # can be random or sequential. if sequential, first n_train elements are training, next n_val are val, else random, usually random is the right choice
shuffle: true         # If true, the data loader will shuffle the data, usually a good idea
metrics_key: validation_loss    # metrics used for scheduling and saving best model. Options: `set`_`quantity`, set can be either "train" or "validation, "quantity" can be loss or anything that appears in the validation batch step header, such as f_mae, f_rmse, e_mae, e_rmse
use_ema: true          # if true, use exponential moving average on weights for val/test, usually helps a lot with training, in particular for energy errors
ema_decay: 0.99              # ema weight, typically set to 0.99 or 0.999
ema_use_num_updates: true     # whether to use number of updates when computing averages
# report_init_validation: true   # if True, report the validation error for just initialized model

# early stopping based on metrics values.
# LR, wall and any keys printed in the log file can be used.
# The key can start with Training or validation. If not defined, the validation value will be used.
early_stopping_patiences:    # stop early if a metric value stopped decreasing for n epochs
  validation_loss: 1000

# early_stopping_delta:    # If delta is defined, a decrease smaller than delta will not be considered as a decrease
#   validation_loss: 0.005

early_stopping_cumulative_delta: false   # If True, the minimum value recorded will not be updated when the decrease is smaller than delta

early_stopping_lower_bounds:     # stop early if a metric value is lower than the bound
  LR: 1.0e-5

# early_stopping_upper_bounds:    # stop early if a metric value is higher than the bound
#   cumulative_wall: 1.0e+100

# loss function
loss_coeffs:   # different weights to use in a weighted loss functions
  forces:   # if using PerAtomMSELoss, a default weight of 1:1 on each should work well
    - 1
    - PerAtomMSELoss
  total_energy:
    - 1

# output metrics
metrics_components:
  - - total_energy
    - rmse
  - - total_energy
    - rmse
    - PerAtom: True                      # if true, energy is normalized by the number of atoms
  - - total_energy
    - mae
  - - total_energy
    - mae
    - PerAtom: True                      # if true, energy is normalized by the number of atoms
  - - forces                               # key
    - rmse                                  # "rmse" or "mae"
    - PerSpecies: True                     # if true, per species contribution is counted separately
      report_per_component: False          # if true, statistics on each component (i.e. fx, fy, fz) will be counted separately
  - - forces
    - mae
    - PerSpecies: True
      report_per_component: False

optimizer_name: Adam
optimizer_amsgrad: true
optimizer_betas: !!python/tuple
  - 0.9
  - 0.999
optimizer_eps: 1.0e-08
optimizer_weight_decay: 0

max_gradient_norm: null

# lr scheduler, currently only supports the two options listed below, if you need more please file an issue
# first: on-plateau, reduce lr by factory of lr_scheduler_factor if metrics_key hasn't improved for lr_scheduler_patience epoch
lr_scheduler_name: ReduceLROnPlateau
lr_scheduler_patience: 100
lr_scheduler_factor: 0.5

per_species_rescale_scales_trainable: false
# whether the scales are trainable. Defaults to False. Optional
per_species_rescale_shifts_trainable: false
# whether the shifts are trainable. Defaults to False. Optional

PerSpeciesScaleShift_shifts: [0.0, 0.0, 0.0, 0.0]

PerSpeciesScaleShift_scales: [1.0, 1.0, 1.0, 1.0]

Just do nequip train <yamlfile> in a normal nequip environment
Expected behavior
Training Process running properly as example in NequIP
Environment (please complete the following information):

OS: Fedora
python version : 3.9
python environment (commands are given for python interpreter):

nequip version : 0.5.6
e3nn version : 0.5.1
pytorch version : 1.12.1 (installed by conda)

(if relevant) GPU support with CUDA

cuda Version according to nvcc : 11.6
cuda version according to PyTorch : 11.6

Additional context
Specific data will be uploaded
nequip_1000vaild5.log
FeCHO_nequip.1.tar.gz
FeCHO_nequip.2.tar.gz

I guess the error reason may lines in my dataset, which has different atoms number in each structure frame.
But I cannot find a way to load multiple dataset in our yaml input , which can be easily done in deepmd json-format inpur file.

The problem lies in the format of loss function. After I changed the format of loss function:

# loss function
loss_coeffs:   # different weights to use in a weighted loss functions
  forces:   # if using PerAtomMSELoss, a default weight of 1:1 on each should work well
    - 5
    - MSELoss
  total_energy:
    - 1
    - MSELoss

batch_size can be any number and no problem emerged.
I think the problem is in the funtion of PerAtomMSELoss

You should use
loss_coeffs:   # different weights to use in a weighted loss functions
  forces:   1.0
  total_energy:
    - 1.0
    - PerAtomMSELoss

instead of
loss_coeffs:   # different weights to use in a weighted loss functions
  forces:   # if using PerAtomMSELoss, a default weight of 1:1 on each should work well
    - 1
    - PerAtomMSELoss
  total_energy:
    - 1

PerAtomMSELoss works for total_energy instead of forces.

@Hongyu-yu is entirely right here; thanks for responding to this!
I've added a better error message for this case.


x/website: install windows broken

What is the URL of the page with the issue?
https://go.dev/doc/install
What is your user agent?
Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/96.0.4664.45 Safari/537.36 Edg/96.0.1054.29

Screenshot

What did you do?
I tried to click the button to download the Windows installer.
What did you expect to see?
The windows installer start to download.
What did you see instead?

cc @rsc  @dmitshur
looks like missing content security policy for golang.org/dl/?mode=json

Also, the link is to "golang.org/dl/" but should likely be updated to "go.dev/dl/". CC @rsc.


Fix broken headings in Markdown files

GitHub changed the way Markdown headings are parsed, so this change fixes it.
See bryant1410/readmesfix for more information.
Tackles bryant1410/readmesfix#1

Thank you :)


Rsync fails when caching with drone exec

Drone cli version: 0.7.0
OS: OSX 10.12.6
I encounter the following error when using caching with drone exec:
rsync: failed to set permissions on "/pipeline/src/node_modules/.bin/handlebars": Not supported (95)                                                                                │ 71     mount:
rsync: failed to set permissions on "/pipeline/src/node_modules/.bin/uglifyjs": Not supported (95)                                                                                │ 72       - app/build
rsync error: some files/attrs were not transferred (see previous errors) (code 23) at main.c(1178) [sender=3.1.2]                                                                                │ 73       - build
panic: runtime error: slice bounds out of range [recovered]                                                                                │ 74       - .gradle
        panic: runtime error: slice bounds out of range                                                                                │ 75     volumes:
                                                                                │ 76       - /tmp/cache:/cache
goroutine 1 [running]:                                                                                │ 77
panic(0x822140, 0xc82000a060)                                                                                │ 78   slack:
        /usr/local/go/src/runtime/panic.go:481 +0x3e6                                                                                │ 79     image: plugins/slack
github.com/drone-plugins/drone-slack/vendor/github.com/urfave/cli.HandleAction.func1(0xc8200d1418)                                                                                │ 80     username: drone
        /go/src/github.com/drone-plugins/drone-slack/vendor/github.com/urfave/cli/app.go:476 +0x417                                                                                │ 81     channel: android-dev #TODO: Set the channel here if it's different
panic(0x822140, 0xc82000a060)                                                                                │ 82     secrets: [ slack_webhook ]
        /usr/local/go/src/runtime/panic.go:443 +0x4e9                                                                                │ 83     when:
main.message(0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0xc8200d214c, 0x4, 0x0, 0x0, ...)                                                                                │ 84       status: [ failure ]
        /go/src/github.com/drone-plugins/drone-slack/plugin.go:93 +0x40a                                                                                │ 85
main.Plugin.Exec(0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0xc8200d214c, 0x4, 0x0, 0x0, ...)                                                                                │ 86   slack:
        /go/src/github.com/drone-plugins/drone-slack/plugin.go:56 +0x7d                                                                                │ 87     image: plugins/slack
main.run(0xc8200c2f00, 0x0, 0x0)                                                                                │ 88     username: drone
        /go/src/github.com/drone-plugins/drone-slack/main.go:190 +0x983                                                                                │ 89     channel: android-dev #TODO: Set the channel here if it's different
reflect.Value.call(0x780780, 0x9708e8, 0x13, 0x8a9398, 0x4, 0xc8200d1378, 0x1, 0x1, 0x0, 0x0, ...)                                                                                │ 90     secrets: [ slack_webhook ]
        /usr/local/go/src/reflect/value.go:435 +0x120d                                                                                │ 91     when:
reflect.Value.Call(0x780780, 0x9708e8, 0x13, 0xc8200d1378, 0x1, 0x1, 0x0, 0x0, 0x0)                                                                                │ 92       event: [ tag ]
        /usr/local/go/src/reflect/value.go:303 +0xb1                                                                                │~
github.com/drone-plugins/drone-slack/vendor/github.com/urfave/cli.HandleAction(0x780780, 0x9708e8, 0xc8200c2f00, 0x0, 0x0)                                                                                │~
        /go/src/github.com/drone-plugins/drone-slack/vendor/github.com/urfave/cli/app.go:485 +0x2ee                                                                                │~
github.com/drone-plugins/drone-slack/vendor/github.com/urfave/cli.(*App).Run(0xc820001080, 0xc82000a210, 0x1, 0x1, 0x0, 0x0)                                                                                │~
        /go/src/github.com/drone-plugins/drone-slack/vendor/github.com/urfave/cli/app.go:244 +0xb05                                                                                │~
main.main()                                                                                │~
        /go/src/github.com/drone-plugins/drone-slack/main.go:146 +0x17eb                                                                                │~
2017/10/12 13:54:17 drone_step_3 : exit code 2```

My project is a simple node based project with the following setup for the cache:
pipeline:
  restore-cache:
    image: drillster/drone-volume-cache
    restore: true
    mount:
      - ./node_modules
    volumes:
      - /tmp/cache:/cache

Could this be a permissions issue relating to /tmp/cache? Looking in /tmp/cache however, I am able to see node_modules.

I'm sorry I didn't get around to this before... It's been a busy time for me..
This is probably an issue with the mounted volume. MacOS does not natively support Docker, which is why it's run inside a VM. Everything inside this VM works just fine, but a mounted volume will persist changes to the host. If, however, the VM filesystem tries to do something that's not supported by the host, you got yourself an error.
I'm not sure I can fix this though. The plugin isn't doing anything wrong.
Are you using Docker for Mac or the older Docker Toolbox?

Hey @mjwwit, no worries, thanks for getting back to me.
I'm using the latest Docker for mac: 17.09.0-ce, build afdb6d4.
Is there a good way to get more info or debug this a little further myself?

Well, you can run the project outside of Drone like this: https://github.com/Drillster/drone-volume-cache#usage
If you need more logging, just clone this repo, add some additional echos, build your own image and run that. If you can isolate which file permissions are causing the issue we may be able to figure out a solution.

Sure thing, I'll look into it and let you know how I get on!

Aha... symlinks. Everything in node_modules/.bin/ is a symlink and this causes issues for rsync as it tries to resolve and copy it as a symlink, which seems to fail (I'm not 100% sure why... not sure what issue docker volumes have with it). We could run with -L which will create the file rather than as a symlink? As long as binary correctly exists in .bin/ it will be accessible to any node scripts right? And the same with any other files of other kinds which are symlinks.

The purpose of caching something is to make sure the file system is as close to the original as possible. If I start replacing links with the actual files that'd be changing the file system, which may cause way more problems than the one you're having. We should see why Docker for Mac can't deal with symlinks and get that fixed instead.

I'm closing this as it's an issue of Docker for Mac.


Feature streamtag ctrl

Change log description
Enable StreamTags on the Controller. Enable GRPC APIs on the controller and ensure these APIs can be invoked by the
PravegaClient.
Purpose of the change
(e.g., Fixes #666, Closes #1234)
What the code does
The code enables StreamTag feature for Pravega. This PR includes the following changes.

Client-side changes:
StreamManager APIs:

The user can now pass stream tags during the stream creation using StreamConfiguration.

   /**
     * Creates a new stream

     * @param scopeName  The name of the scope to create this stream in.
     * @param streamName The name of the stream to be created.
     * @param config The configuration the stream should use.
     * @return True if stream is created
     */
    boolean createStream(String scopeName, String streamName, StreamConfiguration config);

    /**
     * Change the configuration for an existing stream.
     *
     * @param scopeName  The name of the scope to create this stream in.
     * @param streamName The name of the stream who's config is to be changed.
     * @param config     The new configuration.
     * @return True if stream configuration is updated
     */
    boolean updateStream(String scopeName, String streamName, StreamConfiguration config);

A new API has been added to fetch the tags for the given Stream.

 /**
     * Gets the Tags associated with a stream.
     *
     * @param scopeName Scope name.
     * @param streamName Stream name.
     * @return Tags associated with the stream.
     */
    Set<String> getStreamTags(String scopeName, String streamName);

The existing getStreamInfo() API now returns the current stream configuration along with other data.

  /**
     * Get information about a given Stream, {@link StreamInfo}.
     * This includes {@link StreamCut}s pointing to the current HEAD and TAIL of the Stream and the current
     * {@link StreamConfiguration}
     *
     * @param scopeName The scope of the stream.
     * @param streamName The stream name.
     * @return stream information.
     */
    @Beta
    StreamInfo getStreamInfo(String scopeName, String streamName);

New API to list streams with the given tag in a scope.

/**
     * Gets an iterator to list all streams with the provided tag.
     *
     * @param scopeName The name of the scope for which to list streams in.
     * @param tagName The name of the tag.
     *
     * @return Iterator of Stream to iterator over all streams in scope with the provided tag.
     */
    Iterator<Stream> listStreams(String scopeName, String tagName);

Controller side changes:

The controller GRPC server has now enabled two new APIs.

API to fetch the current configuration of the provided Stream. This includes the tag information also.

// Fetch the current Stream configuration.
public void getStreamConfiguration(StreamInfo request, StreamObserver<StreamConfig> responseObserver) ;

API to list the streams associated with the given tag in a scope. The user can pass a continuationtoken which helps the client to iterate over the results.

    public void listStreamsInScopeForTag(Controller.StreamsInScopeWithTagRequest request,
                                   StreamObserver<Controller.StreamsInScopeResponse> responseObserver);

How to verify it
All the existing and newly added tests should pass.

Codecov Report

Merging #28 (ba74eb3) into master (fa8c1d1) will decrease coverage by 0.14%.
The diff coverage is 79.12%.

:exclamation: Current head ba74eb3 differs from pull request most recent head 8d1322d. Consider uploading reports for the commit 8d1322d to get more accurate results

@@             Coverage Diff              @@
##             master      #28      +/-   ##
============================================
- Coverage     85.45%   85.30%   -0.15%
- Complexity    14488    14549      +61
============================================
  Files           941      943       +2
  Lines         53892    54270     +378
  Branches       5483     5508      +25
============================================
+ Hits          46055    46297     +242
- Misses         4970     5091     +121
- Partials       2867     2882      +15

Impacted Files
Coverage Δ
Complexity Δ

...in/java/io/pravega/client/admin/StreamManager.java
0.00% <ø> (ø)
0.00 <0.00> (ø)

...o/pravega/controller/server/ControllerService.java
86.41% <0.00%> (-1.42%)
118.00 <0.00> (-1.00)

...ava/io/pravega/controller/store/InMemoryScope.java
90.47% <0.00%> (-1.10%)
24.00 <0.00> (ø)

...c/main/java/io/pravega/controller/store/Scope.java
25.00% <ø> (ø)
1.00 <0.00> (ø)

...main/java/io/pravega/controller/store/ZKScope.java
82.81% <0.00%> (-1.99%)
43.00 <0.00> (ø)

...ller/store/stream/AbstractStreamMetadataStore.java
93.49% <0.00%> (-0.51%)
158.00 <0.00> (ø)

...vega/shared/controller/tracing/RPCTracingTags.java
0.00% <ø> (ø)
0.00 <0.00> (ø)

...ller/server/rpc/grpc/v1/ControllerServiceImpl.java
81.56% <1.96%> (-6.13%)
175.00 <0.00> (ø)

...troller/server/eventProcessor/LocalController.java
69.25% <20.00%> (-2.12%)
120.00 <0.00> (ø)

...ega/controller/store/stream/records/TagRecord.java
61.29% <61.29%> (ø)
7.00 <7.00> (?)

... and 47 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8be2afa...8d1322d. Read the comment docs.


[TST] Add test for C to Python binded functions

Test build_matrix_from_file located in python\.

As completed.


[BSI][20200603] GUID of Scanned QR Code saved in Unencrypted Database

Rating: Low
Description:
After the iOS app scans a QR Code, it stores the GUID in the unencrypted database, which is found at $app_Storage_Directory/Library/Application Support/secureStore.sqlite. All data in this database is in cleartext including submitted TAN as well. An attacker with root privileges, or code execution in the scope of the CWA app can read this information.
Proof of Concept:
in class ENAExposureSubmissionService:
	private func store(key: DeviceRegistrationKey) {
		switch key {
		case let .guid(testGUID):
			store.testGUID = testGUID
		case let .teleTan(teleTan):
			store.teleTan = teleTan
		}
	}

class SecureStore:
final class SecureStore: Store {
	private let fileURL: URL
	private let kvStore: SQLiteKeyValueStore

	init() {
		do {
			fileURL = try FileManager.default
				.url(for: .applicationSupportDirectory, in: .userDomainMask, appropriateFor: nil, create: true)
				.appendingPathComponent("secureStore.sqlite")
		} catch {
			// swiftlint:disable:next force_unwrapping
			fileURL = URL(string: "file::memory:")!
		}
		kvStore = SQLiteKeyValueStore(with: fileURL)
	}

store of teletan is already removed
https://github.com/corona-warn-app/cwa-app-ios/commit/d07cf7d171b833c213b6e08379600049507531af
Database is encrypted enabled
https://github.com/corona-warn-app/cwa-app-ios/commit/88d9c60f26ba2590138e007c5babee23b47a1d41

HI @BSI-TF-CWA thanks for sharing this security attack vector.
For the production build of the CWA mobile any application specific storage will be encrypted.
Best regards,
Chris


Section highlight

Hello.
Use case:

One of sections has intent as target
Click it (activity comes up)
Press back button

Expected:

current fragment section should be highlighted

Actual result:

no highlight

We've already talked about that. I think you can change that behavior but right now it's correct.

check this: #147


Adds Event Constructor, Parameter, Field and Method

I think I have everything setup correctly to work on Event. I have added the most basic of functionality for Event to test my understanding. I am new to contributing to open source projects, Gradle and AssertJ. I know just enough to be dangeours with Java and TDD.

Only the last commit is useful here.  Here's my shot at fixing this PR.  Try these commands.
git checkout master
git branch pr14
git fetch --all
git reset --hard a7c11f44d5beb557edd591f594aa18db78c772c7
git checkout -b eventTitle
git cherry-pick pr14
git push origin --set-upstream
git branch -D pr14
After that go to https://github.com/bravogolfgolf/meetup and you should see a button letting you create a new PR for branch eventTitle.  You should reuse the same text you used for this PR.  Doing a PR on a separate branch is better because if you push something new to your master branch now, it will show in this PR and that's not what you'd like.  After this is done, don't forget to close this PR as it is not relevant any more.

Perhaps I should just start again...I am going to delete my fork, create a new one, then create a branch for the new code. I have many things I am trying to learn with this project...using git properly is one of them.


Promote transaction API to core (& no-op implementation for in-memory)

Spun off from #2866
The primary scenario is testing relational data access code against in-memory provider

This is limited to:

Move interfaces to core
Make anything relational specific an extension method
Create a null implementation for in-memory

Hello @mikary, apparently this fix is not part of rc1.
Although I can find this fix in dev branch, I can not find it in the rc1 tag. For example the src/EntityFramework/Storage folder does not contain the IDbContextTransaction interface that has been introduced by this fix (https://github.com/aspnet/EntityFramework/tree/7.0.0-rc1/src/EntityFramework.Core/Storage)
Am I wrong or could you update the milestone of this ticket which is confusing IMHO?
Yanal

@Yanal-Yves That is correct, we were originally trying to get this change in for RC1 but it didn't quite make the cut. Just updated the milestone to reflect this.


Mutually exclusive group with check box subitems

Hi there,
I'm quite new to Gooey and I've been trying to make Gooey interface which has a checkbox as subitem for each mutually exclusive item. Something like:

item 1

check box 1

item 2

check box 2
The important thing is that item 1 and item 2 are mutually exclusive here.

I would expect this to work maybe using subparsers like:
subparsers = parser.add_subparsers(help='')

# create the parser for the item 1 command
parser_a = subparsers.add_parser('--item_1', help='item 1 help')
parser_a.add_argument('--check_box_1', action='store_true', help='check box 1 help')

# create the parser for the item 2 command
parser_b = subparsers.add_parser('--item_2', help='item 2 help')
parser_b.add_argument('--check_box_2', action='store_true', help='check box 2 help')

Unfortunately this crashes with "Gooey doesn't currently support top level required arguments when subparsers are present."
Now, I was thinking I can achieve the same with a mutually exclusive group. But I don't exactly see how.
So is there no way in Gooey to implement such an interface?
Thanks in advance for the help!

Hard to know what's up without a full, runnable code example. However, if I'm understanding what you want correctly, a top-level mutually exclusive group, check out this example: https://github.com/chriskiehl/GooeyExamples/blob/master/examples/dynamic_updates.py . Give that a run. It has a single exclusive option. One is a checkbox, the other is a listbox.
Note: checkboxes will not show up when they're inside of a mutually exclusive grup, as selecting an option is implicitly selecting the checkbox.
Top level required positional will throw the error you're seeing because it's somewhat undefined at the moment how to present mixed options like that in the UI.

Closed due to inactivity.