NQueen Problem [Java]

This issue is about NQueenProblem Java (https://github.com/iiitv/algos/blob/master/n_queen_problem/NQueenProblem.java).

[x] Issue Title is in form Algo/DS Name [Language].
[x] I searched or browsed the repo’s other issues to ensure this is not a duplicate.
[x] This Algo/DS is worth adding to this repository.
[x] Assign this issue to me (I want to work on this).

[x] I ensure that I am not already assigned to 2 or more issues.

[x] I will send my PR only after I'm assigned to this issue by any maintainer.
[X] I understand that I will be unassigned from this issue if I fail to send a PR for this within a week.

I think the current implementation can be improved. First, code doesn't use Java strengths at all, the same implementation could be done in non OOP-languages. Second, code is really low level so while it works, is hard to understand at first glance. I think algorithms should be code in a Clean Code manner so that anyone can understand what they do.
I would like to code an OOP solution using better levels of abstractions on methods.

The contributors most likely able to help are:
@singhpratyush

@gaijinco: Can you please give an outline of how will you be improving it? What structure will you follow?

@singhpratyush as I mentioned, the solution is not OOP. In the literature there's usually no mention of any solution like this, and that's why I think is cool to do it. An OOP solution will have a class NQueen which I can build with some parameters (at least size, probably queens already placed) and have an iterator method which returns an Iterator to the solution for the given configuration. Also a configuration shouldn't be something low level like an array but a class which at least has a toString method that let's get a nice String representation. That'd be my approach.

@gaijinco: Cool! Waiting to see the implementation. :)


Introduce histogram support

Prior to this change, the custom queries were restricted to counters and gauges.
This change introduces a new ColumnUsage, namely HISTOGRAM, that expects the column to contain an array of upper inclusive bounds for each observation bucket in the emitted metric.  It also expects three more columns to be present with the suffixes:

_bucket, containing an array of cumulative counters for the
observation buckets;
_sum, the total sum of all observed values; and
_count, the count of events that have been observed.

A flag has been added to the MetricMap struct to easily identify metrics that should emit a histogram and the construction of a histogram metric is aided by the pg.Array function and a new helper dbToUint64 function.
Finally, and example of usage is given in queries.yaml.
fixes #402
This was something I needed on a last_seen timestamp type of column in my database.

Coverage increased (+7.0%) to 71.685% when pulling 1c4cc30988713bd1df615621a0bb35ff07cee063 on rs3000:issue-402 into b12c8ab04e077ba493b5b490f8733b8a44e0ef22 on wrouesnel:master.


Option to disable logging of log producer in audit log

when log level < 9.
[Issue #1069 - Marc Stern]

Please make sure that the JSON audit log is also covered.

done

Hi @marcstern,
Made a comment in your patch, please verify. Before send me any updates make sure to do it in a clean tree. Please also avoid to long commit to replaced the \r with \r\n. Thanks.

I can't see, in "Files changed", in which files \r were replaced by \r\n.
I can't find this on my local copy either.


x/tools/gopls: notable slowdown on save with vscode-go + gopls

This was created from a comment on #43127

I am experiencing an extended "Waiting for code actions from Go" after
saving when using vscode-go + gopls.
Notes:

We have a large number of packages in our module (thousands, including
vendor/)
We have a large number of replace statements
We have a larger-than-normal git repository.

What did you do?

Open a Go file.
Allow the initial "loading packages" operation to finish.
Begin changing the file. Do not pause typing to wait for the autocomplete
prompt.
Save the file one (or more) times, and continue working.

What did you expect to see?

I should be able to continue seeing prompts and suggestions in my editor.

What did you see instead?

I see a dialog box saying "Saving '[file name]': Getting code actions from
"Go"", which persists for ~30-40 seconds during which I have no
suggestions/langauge server features.

Build info
golang.org/x/tools/gopls v0.5.5
<EMAIL_ADDRESS>h1:YBLs2WCwxx6mBF98Y6/mDIpKhP4Dt4Dz2q6LnMRBpDw=
<EMAIL_ADDRESS>h1:WXkYYl6Yr3qBf1K79EBnL4mak0OimBfB0XUf9Vl28OQ=
<EMAIL_ADDRESS>h1:JFrFEBb2xKufg6XkJsJr+WbKb4FQlURi5RUcBveYu9k=
<EMAIL_ADDRESS>h1:we8PVUC3FE2uYfodKH/nBHMSetSfHDR6scGdBi+erh0=
<EMAIL_ADDRESS>h1:RM4zey1++hCTbCVQfnWeKs9/IEsaBLA8vTkd0WVtmH4=
<EMAIL_ADDRESS>h1:SQFwaSi55rU7vdNs9Yr0Z324VNlrF+0wMqRXT4St8ck=
<EMAIL_ADDRESS>h1:uxH+MECLNmX/vsPe4txyeQ1LCmhdUxf7p4hjkHexg+c=
<EMAIL_ADDRESS>h1:go1bK/D/BFZV2I8cIQd1NKEZ+0owSTG1fDTci4IqFcE=
<EMAIL_ADDRESS>h1:W18jzjh8mfPez+AwGLxmOImucz/IFjpNlrKVnaj2YVc=
<EMAIL_ADDRESS>h1:z+/YqapuV7VZPvBb3GYmuEJbA88M3PFUxaHilHYVCpQ=
<EMAIL_ADDRESS>h1:NSZPykBXJFCetGZykLAxaL6SIpvbVy/UFEniIfHAa8A=

Relevant trace
[Trace - 11:45:02.826 AM] Sending request 'textDocument/foldingRange - (75)'.
Params: {"textDocument":{"uri":"file:///home/ubuntu/co/[redacted].go"}}

[Trace - 11:45:02.903 AM] Sending request 'textDocument/codeLens - (76)'.
Params: {"textDocument":{"uri":"file:///home/ubuntu/co/[redacted].go"}}

[Trace - 11:45:02.903 AM] Sending request 'textDocument/codeAction - (77)'.
Params: {"textDocument":{"uri":"file:///home/ubuntu/co/[redacted].go"},"range":{"start":{"line":154,"character":2},"end":{"line":154,"character":2}},"context":{"diagnostics":[]}}

[Trace - 11:45:02.984 AM] Sending request 'textDocument/codeLens - (78)'.
Params: {"textDocument":{"uri":"file:///home/ubuntu/co/[redacted].go"}}

[Trace - 11:45:03.345 AM] Sending request 'textDocument/codeAction - (79)'.
Result: (very large)

[Trace - 11:45:26.677 AM] Received notification 'window/logMessage'.
Params: {"type":3,"message":"2020/12/14 11:45:26 background imports cache refresh starting\n"}

[Info  - 11:45:26 AM] 2020/12/14 11:45:26 background imports cache refresh starting

[Trace - 11:45:26.732 AM] Received notification 'window/logMessage'.
Params: {"type":3,"message":"2020/12/14 11:45:26 background refresh finished after 55.87281ms\n"}

[Info  - 11:45:26 AM] 2020/12/14 11:45:26 background refresh finished after 55.87281ms

[Trace - 11:45:40.987 AM] Received response 'textDocument/foldingRange - (75)' in 38161ms.
Result: (very large)

[Trace - 11:45:40.988 AM] Received response 'textDocument/codeLens - (76)' in 38084ms.
Result: null

[Trace - 11:45:41.013 AM] Received response 'textDocument/codeAction - (77)' in 38109ms.
Result: null

[Trace - 11:45:41.013 AM] Received response 'textDocument/codeLens - (78)' in 38028ms.
Result: null

[Trace - 11:45:41.042 AM] Received response 'textDocument/codeAction - (79)' in 37696ms.
Result: null

[Trace - 11:45:41.077 AM] Received notification 'textDocument/publishDiagnostics'.
Params: {"uri":"file:///home/ubuntu/co/[redacted].go","diagnostics":[{"range":{"start":{"line":71,"character":4},"end":{"line":71,"character":43}},"severity":2,"source":"simplifycompositelit","message":"redundant type from array, slice, or map composite literal","tags":[1]}]}

[Trace - 11:45:41.081 AM] Received notification 'textDocument/publishDiagnostics'.
Params: {"uri":"file:///home/ubuntu/co/[redacted].go","diagnostics":[{"range":{"start":{"line":970,"character":5},"end":{"line":970,"character":42}},"severity":2,"source":"simplifycompositelit","message":"redundant type from array, slice, or map composite literal","tags":[1]},{"range":{"start":{"line":1917,"character":5},"end":{"line":1917,"character":42}},"severity":2,"source":"simplifycompositelit","message":"redundant type from array, slice, or map composite literal","tags":[1]}]}

[Trace - 11:45:41.084 AM] Received notification 'textDocument/publishDiagnostics'.
Params: {"uri":"file:///home/ubuntu/co/[redacted].go","version":63,"diagnostics":[]}

Per request, I ran gopls -v -rpc.trace check [file] on the file being edited
in the above trace
$ time ~/go/bin/gopls-v0.5.5 -v -rpc.trace check [redacted]
2020/12/14 11:58:09 Info:2020/12/14 11:58:09 go env for /home/ubuntu/co/backend/go/src/our_module
(root /home/ubuntu/co/backend/go/src/our_module)
(go version go version go1.15.5 linux/amd64)
(valid build configuration = true)
(build flags: [])
GOMODCACHE=/home/ubuntu/co/backend/go/pkg/mod
GOPATH=/home/ubuntu/co/backend/go
GOPROXY=https://proxy.golang.org,direct
GO111MODULE=on
GOMOD=/home/ubuntu/co/backend/go/src/our_module/go.mod
GOINSECURE=
GONOPROXY=
GOROOT=/home/ubuntu/co/backend/opt/go1.15.5
GOSUMDB=sum.golang.org
GONOSUMDB=
GOPRIVATE=
GOCACHE=/home/ubuntu/.cache/go-build
GOFLAGS=

2020/12/14 11:58:36 Info:2020/12/14 11:58:36 go/packages.Load
	snapshot=0
	directory=/home/ubuntu/co/backend/go/src/our_module
	query=[builtin our_module/...]
	packages=5729
~/go/bin/gopls-v0.5.5 -v -rpc.trace check   98.58s user 10.40s system 293% cpu 37.079 total

When using a recent checkout from master, I do not observe this issue.
Build info
golang.org/x/tools/gopls master
<EMAIL_ADDRESS>h1:VxtAq4uV1lJkZzfzd7XQnTy2oqRHDJdCDlDAGlCjJgs=
<EMAIL_ADDRESS>h1:WXkYYl6Yr3qBf1K79EBnL4mak0OimBfB0XUf9Vl28OQ=
<EMAIL_ADDRESS>h1:JFrFEBb2xKufg6XkJsJr+WbKb4FQlURi5RUcBveYu9k=
<EMAIL_ADDRESS>h1:we8PVUC3FE2uYfodKH/nBHMSetSfHDR6scGdBi+erh0=
<EMAIL_ADDRESS>h1:RM4zey1++hCTbCVQfnWeKs9/IEsaBLA8vTkd0WVtmH4=
<EMAIL_ADDRESS>h1:qwRHBd0NqMbJxfbotnDhm2ByMI1Shq4Y6oRJo21SGJA=
<EMAIL_ADDRESS>h1:/zwc1T/TCf9evHOKBS+iOctX4P4oUufJApG6rD8Klos=
<EMAIL_ADDRESS>h1:go1bK/D/BFZV2I8cIQd1NKEZ+0owSTG1fDTci4IqFcE=
<EMAIL_ADDRESS>h1:W18jzjh8mfPez+AwGLxmOImucz/IFjpNlrKVnaj2YVc=
<EMAIL_ADDRESS>h1:z+/YqapuV7VZPvBb3GYmuEJbA88M3PFUxaHilHYVCpQ=
<EMAIL_ADDRESS>h1:NSZPykBXJFCetGZykLAxaL6SIpvbVy/UFEniIfHAa8A=

Relevant trace
[Trace - 11:20:31.794 AM] Received response 'textDocument/documentHighlight - (20)' in 1520ms.
Result: [{"range":{"start":{"line":105,"character":32},"end":{"line":105,"character":44}},"kind":1},{"range":{"start":{"line":78,"character":16},"end":{"line":78,"character":28}},"kind":1},{"range":{"start":{"line":82,"character":27},"end":{"line":82,"character":39}},"kind":1},{"range":{"start":{"line":91,"character":1},"end":{"line":91,"character":13}},"kind":1},{"range":{"start":{"line":70,"character":16},"end":{"line":70,"character":28}},"kind":1},{"range":{"start":{"line":84,"character":1},"end":{"line":84,"character":13}},"kind":1},{"range":{"start":{"line":86,"character":32},"end":{"line":86,"character":44}},"kind":1},{"range":{"start":{"line":89,"character":27},"end":{"line":89,"character":39}},"kind":1},{"range":{"start":{"line":93,"character":32},"end":{"line":93,"character":44}},"kind":1},{"range":{"start":{"line":98,"character":27},"end":{"line":98,"character":39}},"kind":1},{"range":{"start":{"line":61,"character":1},"end":{"line":61,"character":13}},"kind":1},{"range":{"start":{"line":74,"character":16},"end":{"line":74,"character":28}},"kind":1},{"range":{"start":{"line":79,"character":7},"end":{"line":79,"character":19}},"kind":1},{"range":{"start":{"line":100,"character":1},"end":{"line":100,"character":13}},"kind":1},{"range":{"start":{"line":71,"character":7},"end":{"line":71,"character":19}},"kind":1},{"range":{"start":{"line":75,"character":7},"end":{"line":75,"character":19}},"kind":1}]

[Trace - 11:20:32.429 AM] Received response 'textDocument/codeAction - (21)' in 1905ms.
Result: null

[Trace - 11:20:32.430 AM] Received response 'textDocument/codeAction - (22)' in 1756ms.
Result: null

[Trace - 11:20:32.609 AM] Sending request 'textDocument/formatting - (23)'.
Params: {"textDocument":{"uri":"file:///home/ubuntu/co/[redacted].go"},"options":{"tabSize":4,"insertSpaces":false}}

[Trace - 11:20:32.616 AM] Received response 'textDocument/formatting - (23)' in 6ms.
Result: []

[Trace - 11:20:33.216 AM] Sending notification 'textDocument/didSave'.
Params: {"textDocument":{"uri":"file:///home/ubuntu/co/[redacted].go","version":1}}

[Trace - 11:20:33.507 AM] Sending notification 'workspace/didChangeWatchedFiles'.
Params: {"changes":[{"uri":"file:///home/ubuntu/co/[redacted].go","type":2}]}

[Trace - 11:20:49.553 AM] Sending request 'textDocument/documentHighlight - (24)'.
Params: {"textDocument":{"uri":"file:///home/ubuntu/co/[redacted].go"},"position":{"line":78,"character":35}}

You said that master seems to be working well--can you please try the current gopls pre-release? You can download it by running GO111MODULE=on go get<EMAIL_ADDRESS>We will be tagging this release on Wednesday, so if it works for you then it's possible the issue has already been resolved.

Hi,
I tested with the following version:
golang.org/x/tools/gopls v0.6.0
<EMAIL_ADDRESS>h1:i+eJsCS+4N+3YSxLbuq0SrfWim3V8eG4WgdK8xQdzwI=
<EMAIL_ADDRESS>h1:WXkYYl6Yr3qBf1K79EBnL4mak0OimBfB0XUf9Vl28OQ=
<EMAIL_ADDRESS>h1:JFrFEBb2xKufg6XkJsJr+WbKb4FQlURi5RUcBveYu9k=
<EMAIL_ADDRESS>h1:we8PVUC3FE2uYfodKH/nBHMSetSfHDR6scGdBi+erh0=
<EMAIL_ADDRESS>h1:RM4zey1++hCTbCVQfnWeKs9/IEsaBLA8vTkd0WVtmH4=
<EMAIL_ADDRESS>h1:SQFwaSi55rU7vdNs9Yr0Z324VNlrF+0wMqRXT4St8ck=
<EMAIL_ADDRESS>h1:8fYBhX5ZQZtb7nVKo58TjndJwMM+cOB1xOnfjgH3uiY=
<EMAIL_ADDRESS>h1:go1bK/D/BFZV2I8cIQd1NKEZ+0owSTG1fDTci4IqFcE=
<EMAIL_ADDRESS>h1:W18jzjh8mfPez+AwGLxmOImucz/IFjpNlrKVnaj2YVc=
<EMAIL_ADDRESS>h1:z+/YqapuV7VZPvBb3GYmuEJbA88M3PFUxaHilHYVCpQ=
<EMAIL_ADDRESS>h1:NSZPykBXJFCetGZykLAxaL6SIpvbVy/UFEniIfHAa8A=

Repeating my experiments, the longest textDocument/codeLens operation I observed was around 4000ms. This seems consistent with pre v0.5.5, so I am happy to close this issue.


Add NextJS lib generator

ref: https://app.clickup.com/t/24336023/PRD-1187

@ipakhomov as discussed


Feature Request: Add Server and Client IP addresses to output

Howdy,
It would be super handy if this module could output the external IP addresses assigned to server and clients. I see there is some scripting made to do this in either test or examples
Is there any reason this isn't done currently?
Thanks! :)

The Consul nodes run in an Auto Scaling Group (ASG). Terraform does not provide the IP address outputs for an ASG, as the ASGs are dynamic by design, and new instances can come and go any time.


Update alpine image to ubi9-micro

Resolves intermittent failures when creating the initContainer in the init-deployment and init-statefulset scorecard tests. Related issue: https://github.com/OpenLiberty/open-liberty-operator/issues/464

I believe this can be closed as tests in the common repo were updated by PR https://github.ibm.com/websphere/operators/pull/52/files and now apply to all Operators. @kabicin please close if you agree. Thanks.

Yes, it can be closed since https://github.ibm.com/websphere/operators/pull/66 was merged.


Fix for the get_inconsistent_fieldnames() function. The fieldset can be a dictionary, not a tuple.

The fix given the possibility that the fieldset could be a dictionary (when it defined as collapsible).
https://django-constance.readthedocs.io/en/latest/#fieldsets-collapsing
CONSTANCE_CONFIG = {
    'SITE_NAME': ('My Title', 'Website title'),
    'SITE_DESCRIPTION': ('', 'Website description'),
    'THEME': ('light-blue', 'Website theme'),
}

CONSTANCE_CONFIG_FIELDSETS = {
    'General Options': {
        'fields': ('SITE_NAME', 'SITE_DESCRIPTION'),
        'collapse': True
    },
    'Theme Options': ('THEME',),
}

Currently, if the set is defined as collapsible, there is no way to save changes due to incorrect validation.

Thank you


Add the extractContacts parameter as documented on outscraper api

Add an extra parameter for google place search as per Outscraper's api documentation: https://app.outscraper.com/api-docs#tag/Google-Maps/paths/~1maps~1search-v2/get
@vlad-stack

hi @franagustin,
Thank you for your contribution! I've just added the enrichment parameter that you can use to enrich GM with emails and other services (validator, WA checker, etc.). Check this example: https://github.com/outscraper/outscraper-node/blob/main/examples/Enrichments.md.

Your code looks good BTW! But the reason we want to use enrichments is that we want to allow using other services and keep the number of parameters low. Let me know if there is anything else!


Editing a procedure should not scroll flyout

Expected Behavior
Editing a procedure spec (the labels/inputs) should never scroll the flyout, since editing a procedure is usually done to change how existing calls to the procedure look, not to create new calls.
Actual Behavior
Editing a procedure spec does scroll the flyout to the "My Blocks" section.
Steps to Reproduce
Right-click an existing custom procedure block and press Cancel or OK.
Operating System and Browser
Firefox 65.0b7, Linux (Debian).

Closing this issue as won't fix since it's a very low severity bug with a much higher-risk solution.


We need to deal with NUMA

Measured performance in different configurations. 4 cores used: receive, empty handler, send.
Traffic: pktgen (1 machine) -> nff app (2 machine) -> pktgen (1 machine)
Configurations: 0 - use cpu from the closest numa node to port, 1 - use cpu from remote numa node.
first - send, second - receive, third - segment. For example, 101 means that send and segment are on remote node, receive on the same.
Below are the measurements of memory (with pcm) and throughput (with pktgen).

you can make your exepiments with https://github.com/intel-go/nff-go/compare/develop...numa?expand=1 changes. running perf_light with needed flags


Enable service configuration by using configuration files

FEATURE REQUEST

Is there an open issue addressing this request? If it does, please add a "+1" reaction to the
existing issue, otherwise proceed to step 2.

Describe the feature you are requesting, as well as the possible use case(s) for it.

Currently, services are configured by setting environment variables, or by defaults if variables are not set.
It would be nice to be able to supply a configuration file to the service as well.

Indicate the importance of this feature to you (must-have, should-have, nice-to-have).

This is a nice to have feature, especially in cases when someone runs a service outside a docker container.

I would advise looking that viper, since it can read environment variables and also read configuration files in several formats

Agreed - Viper looks like a nice tool for the job.

I am not sure that we need this one. Config files are more difficult to distribute (although not much more), and we have nice solution no with .env.
@nmarcetic @anovakovic01 opinions?

Also - if we leave both solutions - ENV and .config files if present (or used with a --config switch), this might be the best option.

@mainflux/contributors do we really need two ways for configuration? IMHO we should have one and only one way for configuration. I personally don't like systems where a same functionality can be achieved in many different ways as it confuses the users and it makes the implementation more complex

@chombium my opinion is that config via ENV variables is the best approach, but it would not bother me if config files and command line switches exist as an alternative.
I just think that this is really not necessary and makes things harder to maintain.

@drasko We solved the problem for docker but natively it still complicated to setup the system (if you're not using default one, of course) because there are many duplicated variables all around the code.
How hard it would be to remove all definitions from main.go and copy the values from the same file used for Docker .env ?

I agree with @srados I would use Viper to read config files and/or ENV var. So would support bought config + env, it would be great!

Reopening this one to finish services implementation

idk if it is relevant but in microservices architecture, it is very common to use discovery + config servers such as a consul, it can even store passwords if integrated with the vault. provisioning in k8s, docker-compose will be more easy

@cyber-goka we use k8s for professional deployments and docker-compose for dev, so no problems with service discovery.

got it, thanks


Fix shift calculation by considering biases

Biases are used to be taken into consideration while calculating the factor but not in writing the out_shift. This commit fixes this.

Added another changed file to this PR.

Verification done, the new version works in both cifar100_qat_mixed and unet v7 with no accuracy difference with their QAT versions.


[terra-application-v2] Create new Modal API using LayerManager

Story
Description

As a consumer of terra-application, I would like access to a Modal implementation using the LayerManager
Motivation

So that I can utilize the simplified modal presentation APIs and UI.
Definition of Done

We'll know we're done when the new Modal component is created.

Closing as dupe of https://github.com/cerner/terra-application/issues/204


Group NUGs geographically?

Presently, the NUGS are displayed as a single group (see below). Would it not be better to group them? Say, as North America, Europe, Asia, etc.

Already done if you simply search in the search bar for your country/city.

I think I wanted to do this, but left it out for simplicity, as parsing the yml was hard, and homer doesn't support json, would be nicer if it did support json.


Add comment to exported function WindowsServiceName (make revive)

Running make revive locally complains about this.

Codecov Report

Merging #9241 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master   #9241      +/-   ##
=========================================
+ Coverage   41.09%   41.1%   +<.01%
=========================================
  Files         555     555
  Lines       72400   72400
=========================================
+ Hits        29753   29758       +5
+ Misses      38907   38900       -7
- Partials     3740    3742       +2

Impacted Files
Coverage Δ

models/unit.go
62.16% <0%> (-5.41%)
:arrow_down:

models/pull_list.go
57.74% <0%> (-2.12%)
:arrow_down:

models/error.go
32.67% <0%> (-0.6%)
:arrow_down:

models/repo_list.go
74.07% <0%> (+0.92%)
:arrow_up:

modules/log/event.go
65.64% <0%> (+1.02%)
:arrow_up:

models/repo_indexer.go
67.74% <0%> (+1.79%)
:arrow_up:

modules/indexer/indexer.go
55.26% <0%> (+10.52%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e43de0d...7d38f90. Read the comment docs.


Vickel: Watch ayurvedichospital.com

Vickel requests the watch of the watch_keyword ayurvedichospital\.com. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

ayurvedichospital\.com has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by Jeff Schaller in Charcoal HQ


server busy

if captcha solves (fails alot) says either python command not found and if python command is found then it says server busy

sh: python:command not found


Make assets for the iOS track

Any updates on this?

Going to close it for now. I don't see myself having the time to complete it.


Fix c++17 compiler issues

Hi together,
when using anyrpc in a project compiling with c++17 compiler options enabled I got some deprecated-warnings. The proposed commit solves this issue.
See also https://www.fluentcpp.com/2018/05/08/std-iterator-deprecated/.
Greatings
Jan

I had to make a small change for Linux compatibility.  Explicit specification of std:: with ptrdiff_t.


Convenience overload AmbientTasks.Post(Func)

One place so far, refactoring from:
private async void EventHandler(object sender, EventArgs e)
{
    await Task.Yield();

    // ...

    await BarAsync();
}

This would be a nice result (proposed):
private void EventHandler(object sender, EventArgs e)
{
    AmbientTasks.Post(async () =>
    {
        // ...

        await BarAsync();
    });
}

This workaround happened to work out, though it would not be as simple if there had been multiple awaits:
private void EventHandler(object sender, EventArgs e)
{
    AmbientTasks.Post(() =>
    {
        // ...

        AmbientTasks.Add(BarAsync());
    });
}

Implemented in 351276a580da78539a3ba228e28136a2f0123921

Implemented in bcf21c40b59ddef990ebc8b71099d3a5e96eee11


adds test for update post

Overview 🚀
Adds test for updating post title and content
Type of change 🧙

🎉 Initial commit (area): a brief description of change.

✨ New feature (area): a brief description of change.

🐛 Bugfix (area): a brief description of change.

📚 Documentation (area): a brief description of change.

💡 Documenting source code (area): a brief description of change.

🐎 Performance (area): a brief description of change.

🚨 Tests (updatePost): adds test for updating post title and content.

💚 Continuous Integration (area): a brief description of change.

🔒 Security (area): a brief description of change.

👕 Lint (area): a brief description of change.

🚀 Deploying stuff (area): a brief description of change.

🚧 Work in progress (area): a brief description of change.

🔧 Configuration files (area): a brief description of change.

💩 Bad code / need improv. (area): a brief description of change.

💥 Breaking changes (area): a brief description of change.

👌 Code review changes (area): a brief description of change.

How Has This Been Tested? 🚨
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

✅ Test A

❌ Test B

Related Issue 🛠
Which issue(s) are related to this pull request?

closes #33

Checklist ✅

[x] My code follows the style guidelines of this project

[x] I have performed a self-review of my own code

[x] I have commented my code, particularly in hard-to-understand areas

[x] I have made corresponding changes to the documentation

[x] My changes generate no new warnings

[x] I have added tests that prove my fix is effective or that my feature works

[x] New and existing unit tests pass locally with my changes

[x] Any dependent changes have been merged & published in downstream modules

@Mr-emeka you have an unused import in your test as well

One thing I noticed I don't think clearData function works as expected.

@Mr-emeka your test currently passes due to a bug that on main when you created the pr. please sync main to your branch & confirm if it still passes

@Mr-emeka your test currently passes due to a bug that on main when you created the pr. please sync main to your branch & confirm if it still passes

It doesn't pass checking out the issue


Syntax errors in generated stubs

Hi there,
I've noticed this problem in recent versions:
/nix/store/cm7xda19nh3bb326y5qv56750ni3dz49-python3.10-homeassistant-stubs-2022.10.4/lib/python3.10/site-packages/homeassistant-stubs/components/bluetooth/models.pyi:27: error: invalid syntax
Found 1 error in 1 file (errors prevented further checking)

This appears to be due to https://github.com/python/mypy/issues/12441, so not really a bug in this project (hence feel free to just close the issue), but I thought I should note it.
I managed to work around it with the following hacky sed commands on the installed .pyi files:
find $out -name "*.pyi" -print0 | xargs -0 sed -i 's/, \*,/, *args,/g'
find $out -name "*.pyi" -print0 | xargs -0 sed -i 's/, \*\*)/, **kwargs)/g'

* is actually legit separator for keyword-only arguments, see: PEP 3102.
Nameless kwargs is wrong but there are only 3 places right now:

components/unifi/update.pyi
components/unifiprotect/text.pyi
components/zwave_js/humidifier.pyi


Window's background color doesn't render the correct Hex value

regarding the backgroundColor option of BrowserWindow
1 - backgroundColor is ignored unless transparent is true, is that the desired behavior?
2 - After testing with a couple of Hex value it seems like backgroundColor is rounding up any non 0 value to F
for instance #66CD00 (green)  [(from the documentation)]  (https://github.com/atom/electron/blob/master/docs/api/browser-window.md)  is correctly rendered in the Webpage, but the Main Process' BrowserWindows render it  #FFFF00  (yellow)

Electron version: electron-v0.36.12
Operating system: OS X 10.10.5

1 - backgroundColor is ignored unless transparent is true, is that the desired behavior?

On some platforms backgroundColor is not fully implemented yet, it is tracked at #861.

2 - After testing with a couple of Hex value it seems like backgroundColor is rounding up any non 0 value to F

It is a new bug, thanks for reporting this.


Add extra info when a value with a wildcard might not be in quotes

Goal
This PR adds an info message when an argument that allows a wildcard is used and we encounter an unknown value error. For example, the following command will cause an unknown value error because --base-url has two arguments:
$ ./bin/cli upload-browser --base-url 123 xyz

If a user is using a wildcard argument and we get an unknown value, it's likely that this is because the wildcard isn't wrapped in quotes — i.e. --base-url * should be --base-url "*"
This is hard to know for sure because asterisk expansion happens in the shell before the CLI is run, so we have to guess that this happened

Suggestion added to make it clear "why", though it may just confuse matters. Take it or leave it!

Yeah this makes a lot of sense — it's google-able if someone isn't familiar with "shell expansion"


Fails to run on case sensitive file system

If the game is loaded on a case sensitive file system it does not run owning to the miss matched use of upper and lower case
For example images/ui is lower case on disk but upper case (images/UI) in code at lines 38 and 39

This seems to be the only case where upper case was used. Should be fixed now.


Regenerate Mnemonic Word List

Is there a way in NBitcoin to regenerate the same seed words list from wallet private key? If so how? I cannot find an obvious way via the API. Thanks

no you can't


Notification filters

Is your feature request related to a problem? Please describe.
When you go to /notifications, you don't have a way to filter by type so replies can get missed:

Describe the solution you'd like
Add a filter like we have for the recent feed:

Tabs as @SatsAllDay is implemented for settings might also be something one could explore.

Describe alternatives you've considered
n/a
Additional context
https://stacker.news/items/496134

Zooming out a bit, in the long run all item pages will have a button like this which will host all the item filters in a modal. Implementer's choice whether they do this or not.


Remove chef bootstrap script from command line / ps output

When bootstrapping in Chef Infra 15, the chef-full script is now run through train, for the most part fixing #3871. However https://github.com/chef/chef/blob/master/lib/chef/knife/bootstrap/templates/chef-full.erb still is wrapped by a sh -c '... ' block which means the contents end up in ps output.
We should be able to simply remove that block from the template, but will need to test and verify tests.

#8885 fixed


Swagger file has validation errors

SUMMARY
Swagger file has parse errors
ISSUE TYPE

Bug Report

STEPS TO REPRODUCE
Running the openapi.yaml file through Swagger validation (online, use https://editor.swagger.io/) fails with the following errors:
Semantic error at paths./api/v1/executions/{id}/re_run.post.parameters.1.schema.properties.tasks
Schemas with 'type: array', require a sibling 'items: ' field
Jump to line 1220
Semantic error at paths./api/v1/executions/{id}/re_run.post.parameters.1.schema.properties.reset
Schemas with 'type: array', require a sibling 'items: ' field
Jump to line 1223
Semantic error at paths./api/v1/packs/index/search.post.responses.200.schema.type
Schema "type" key must be a string
Jump to line 1845
Semantic error at paths./api/v1/policies.get.responses.200.schema.items
`items` must be an object
Jump to line 2296
Semantic error at paths./api/v1/rules/{rule_ref_or_id}
Equivalent paths are not allowed.
Jump to line 2717
Semantic error at paths./api/v1/webhooks/{url}
Equivalent paths are not allowed.
Jump to line 4206
Schema error at definitions['AliasExecution'].properties['actionalias'].properties['formats'].items
should NOT have additional properties
additionalProperty: oneOf
Jump to line 4638
Schema error at definitions['AliasExecution'].properties['actionalias'].properties['formats'].items
should be array
Jump to line 4638
Schema error at definitions['AliasExecution'].properties['actionalias'].properties['formats'].items
should match some schema in anyOf
Jump to line 4638
Schema error at definitions['AliasExecution'].properties['execution'].properties['$ref']
should be object
Jump to line 4687
Semantic error at definitions.PackIndex.properties.indexes.properties.status
Schemas with 'type: array', require a sibling 'items: ' field
Jump to line 5042
Semantic error at definitions.WebhookBody.type
Schema "type" key must be a string
Jump to line 5167
Semantic error at definitions.TokenRequest.properties.ttl.type
Schema "type" key must be a string
Jump to line 5232
Semantic error at definitions.TokenValidationRequest.properties.token.type
Schema "type" key must be a string
Jump to line 5255
Schema error at securityDefinitions['auth-token-cookie']
should NOT have additional properties
additionalProperty: name, in
Jump to line 5348
Schema error at securityDefinitions['auth-token-cookie'].type
should be equal to one of the allowed values
allowedValues: basic, oauth2
Jump to line 5350
Schema error at securityDefinitions['auth-token-cookie'].in
should be equal to one of the allowed values
allowedValues: header, query
Jump to line 5352

EXPECTED RESULTS
API Tools such as autorest or swagger-codegen would create a client API
ACTUAL RESULTS
All the tools that I've tried, fail with errors on parsing the swagger file.

I was curious why CI wasn't catching these errors, here's my investigation
Investigation

Makefile contains lint-api-spec target https://github.com/StackStorm/st2/blob/master/Makefile#L189-L197
lint-api-spec target calls st2common/bin/st2-validate-api-spec https://github.com/StackStorm/st2/blob/master/Makefile#L197
st2common/bin/st2-validate-api-spec calls st2common.cmd.validate_api_spec.main
st2common.cmd.validate_api_spec uses Prance to do its "validation" https://github.com/jfinkhaeuser/prance
Looks like schema validation was disabled: https://github.com/StackStorm/st2/blob/master/st2common/st2common/cmd/validate_api_spec.py#L117-L118

I can confirm this problem still exists on v3.1:
.
This also prevents swagger-codegen to generate client codes as well:
[INFO] --- openapi-generator-maven-plugin:4.2.3:generate (codegen) @ ---
[ERROR] failed to read resource listing
com.fasterxml.jackson.core.JsonParseException: Unrecognized token 'swagger': was expecting (JSON String, Number, Array, Object or token 'null', 'true' or 'false')

Note that there are things in the yaml thats not supported by Swagger/OAS 2. Things like "cookie" tag where you can see they are supported only in OAS 3:

I also like to mention that client code is successfully auto-generated if you remove duplicated & problematic paths from the yaml.

I can see that whole api document, as v1 is not up-to-date. Most request/responses conflicting with the documentation.
hey @armab! should I expect any update here?
For example, here is the GET api/v1/pack response:

and the reality:

Looks like https://github.com/StackStorm/st2/issues/4051 has more information about api.stackstorm.com issue.
As for the Swagger validation errors for StackStorm API, - we'll be welcoming contribution fixes!

hey @armab, thanks for the quick response!
I've inspected the issues you've opened. I'd like to add that I wasn't talking about the conflict between apidocs UI and openai.yaml, but rather that openapi.yaml is wrong by itself.
If you inspect the circleci link you posted you can see that it gets its openapi.yaml from st2-common. This is the yaml that's not true. Real responses are rather different as I've described deeper in my previous comment.
This is a blocker issue for me as I was about to generate client side automatically with swagger codegen. I managed to do that by fixing the validation errors; but fixing the actual models seems like quite a lot of task.

@TunaYagci
Can ypu please post your fixed version?


Migration to new Nexus, outdated or no-longer available dependencies

While migrating Ondex to our new Nexus, I've discovered a number of Ondex 3rd-party dependencies that:

either are very old and cannot be found in any public Maven repository anymore
or have never been proper Maven projects, but someone made a Jar in more manual ways (eg, via IDE) and uploaded it in the old Nexus.

In the first case, I tried to find more recent versions or replacements. Some of them worked, but we need entensive testing of the new build. In particular, we need to re-run relevant Mini workflows (ara, wheat, etc) and see if the resulting OXL is fine.
In the second case (and in cases where no version or replacement was available), I had to disable modules that depends on those missing components. These are:

Ondex Module ID
Module Name
URL
Lost Deps

nclondexexpression
NCL Ondex Expression
https://github.com/Rothamsted/ondex-opt/tree/master/modules-opt/expression
de.mpg.mpiinf.csb:KPM

psimi2ondex
PSI-MI 2.5 parser for Ondex
https://github.com/Rothamsted/ondex-opt/tree/master/modules-opt/psimi25
uk.ac.ncl.cs:psimi

sbml
sbml
https://github.com/Rothamsted/ondex-opt/tree/master/modules-opt/sbml
org.biojava:biojava:1.0

We need to confirm that the above modules aren't needed anymore. Or to discuss a solution.

I can confirm they are not needed any longer. It might be a good idea to spring clean our plugins and just keep the ones that are used for building KnetMiner knowledge graphs.


Add Morecon as a pre-genesis validator for v0.20

Hi Bengt,
I'm looking forward to being looped at new testnet which including ETH bridge version.
my previous PR:
#958
Best regards

I've tried to join pre-genesis validators twice.  which PR are:
https://github.com/anoma/namada-testnets/pull/958
https://github.com/anoma/namada-testnets/pull/732

Mistake in PR. Fixed and merging


⚠ MBKM Cloud has degraded performance

In 1efa64f, MBKM Cloud (https://mbkm-cloud.unmer.ac.id/) experienced degraded performance:

HTTP code: 200
Response time: 6734 ms

Resolved: MBKM Cloud performance has improved in ce3a1a1 after 20 minutes.


python312Packages.toggl-cli: 2.4.4 -> 3.0.2

Things done
Fix build on darwin.
cc @mmahut

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 361814

x86_64-linux

:white_check_mark: 4 packages built:

python311Packages.toggl-cli
python311Packages.toggl-cli.dist
python312Packages.toggl-cli
python312Packages.toggl-cli.dist

aarch64-linux

:white_check_mark: 4 packages built:

python311Packages.toggl-cli
python311Packages.toggl-cli.dist
python312Packages.toggl-cli
python312Packages.toggl-cli.dist

x86_64-darwin

:white_check_mark: 4 packages built:

python311Packages.toggl-cli
python311Packages.toggl-cli.dist
python312Packages.toggl-cli
python312Packages.toggl-cli.dist

aarch64-darwin

:white_check_mark: 4 packages built:

python311Packages.toggl-cli
python311Packages.toggl-cli.dist
python312Packages.toggl-cli
python312Packages.toggl-cli.dist


Add OpenDefinitions type and initial fetch

Overview
This adds initial fetch of definitions

Implementation notes
Add a new type: OpenDefinitions that tracks the state of the
Definitions open in the workspace area. It's an opaque wrapper around
an OrderedMap from Hash WebData Definition.
Add OpenDefinitions to App and use it to fetch Definitions by
Hash, render a loading indicator for each Definition being fetched
(correctly positioned due to the wrapped OrderedMap) and render a
placeholder for when the data is returned from the server.
Additionally clean up the UI and Icons a little and make Hash opaque.
Interesting/controversial decisions
I'm currently just working off of 1 FQN, but after pairing with @runarorama I learned that
there could be many. Initially I had thought that I could pick based on how the user navigated to a definition,
but i'm now realizing that, from a clicked link, I might not know since i'm using Hashes as identifiers (which will be reflected in the url) as opposed to FQNs.
Would love some thoughts on that!
Loose ends
The Definition decoders are placeholder as the API is
changing shortly which will include a List of FQNs and a UniqueSuffixName,
which will be the primary way I'll display things
I think there's a bug in the backend where a Hash sometimes has a # prefix and sometimes,
which is resulting in some double entries in OpenDefinitions.

After chatting with @aryairani this morning I think I'll change my Hash data structure to a Reference and have it work for both builtins and non-builtins, but will definitely do that in a separate effort.

@pchiusano @runarorama I think this is good now for a review. Main pieces is the Definition decoders and the OpenDefinitions data structure.


friendlier setup.py errors when numpy is missing.

(I have a patch for this coming in, see if you like where it goes)
issues:

need numpy for dependency compilation
no easy way to tell setup.py to get numpy and work with it first.  (or is there?)
$ pip install numpy pandas still isn't enough.

So the best I can do I give a friendlier message.  Patch inbound.

This looks good to close


Concerto Printer should implement functionality for additional formats: JSONSchema, XMLSchema, OData

Feature Request 🛍
At present, Concerto Printer provides functionality to print to CTO format, for example Printer.toCTO(ast). This allows 'code gen' for each namespace associated in the meta-model hierarchy.
For example, a metal-model with both a direct and a transitive dependency will have multiple namespaces (one per node in the hierarchy), and therefore we can pull multiple AST's from the ModelManager, and using Printer, print a string representation of each AST, or namespace - each string being the generated CTO from the AST associated with the namespace.
  public generateConcerto(mgr: ModelManager) {
    const ns = mgr.getNamespaces().filter(ns => ns !== 'concerto'); // ignore root level 'concerto' ns
    const asts = ns.map(ns => mgr.getModelFile(ns).getAst());
    // print each AST of each ns to CTO
    const cto = asts.map(ast => Printer.toCTO(ast));
    return cto;
  }

A current use case for this might be writing each of these strings to file, where they will be ultimately exported as a Zip archive. The end user is able to faithfully recreate a file per namespace from the meta-model using the above approach.
As demonstrated, this works great when end users want to work with the Concerto format, however the current functionality is limited in regard to all other supported formats (XMLSchema, JSONSchema, OData, PlantUML).
Take a JSONSchema use case for example. At present, the end user can generate only a single string which contains all dependencies in the hierarchy. It is not currently possible to generate a JSONSchema file per namespace - there is no parity with the Concerto format in this respect.
One other inconsistency to note is in the code path - this is not 1:1 if generating source files for the other formats, when compared to CTO - as no Printer implementation currently exists for these other formats. The end user must make use of a Visitor, and pass in a FileWriter as a dependency. The generated code can then be retrieved from the FileWriter, once Vistor.visit(...) has traversed the AST.
We would ideally like to have the ability to print to each of the formats - JSONSchema, XMLSchema, OData, with a string representation per namespace in the model hierarchy, preferably mirroring the implementation of Print.toCTO(...) -- for example Printer.toOData(...)
Possible Solution
Implement functions in the Printer class to support JSONSchema, XMLSchema, OData,. For example - Printer.toOData(...), or possibly create a Printer per format eg. ODataPrinter.
Detailed Description

I think I prefer to leave the format conversions in the concerto-tools package - and callable either via API using their Visitor, or via the concerto CLI. The CTO format has a special status in that it is the concrete syntax for the metamodel and is hence lossless.


sleep timer

hi, can you add a sleep timer to Cpod?

Hi, I can do that. Just to clarify, do you mean an option to keep playing episodes until a certain time limit?

yes


Contract Removal Flag

Description
Allow contract removals when using the --contract-removal flag on the emulator. Emulator should act in two ways, first is to precisely match the behavior of the mainnet for testing, but during the initial development phase, it has to allow different development features that are not possible on mainnet in order to make the development process easy. Removing contract is for sure one of them, which would allow devs to update contracts as they develop them.

For contributor use:

[ ] Targeted PR against master branch
[ ] Linked to GitHub issue with discussion and accepted design OR link to spec that describes this work
[ ] Code follows the standards mentioned here
[ ] Updated relevant documentation
[ ] Re-reviewed Files changed in the GitHub PR explorer
[ ] Added appropriate labels

I think we can make a --strict flag to emulate mainnet behavior strictly, but default settings should focus on ease of development in my opinion.

I think we can make a --strict flag to emulate mainnet behavior strictly, but default settings should focus on ease of development in my opinion. ( we don't have transaction fees enabled default for example )

I was thinking of something very similar. I don't want to make it part of this PR tho. But strict flags sounds the way to go to me. And that should be explicitly required.


Convert E2E tests for PITR on volume snapshots to declarative mode

Currently, E2E tests for PITR on volume snapshots use the plugin. Before we release 1.21 we are planning to deprecate the cnpg snapshot command in favor of the cnpg backup -v volumeSnapshot command, which builds the Backup resource.
As a results, such E2E tests need to be converted to use declarative mode.

Closing. It will be merged as part of https://github.com/cloudnative-pg/cloudnative-pg/issues/2797


SOUND: more cleanup

More cleanups.
Also takes care of: https://github.com/source-academy/cadet-frontend/issues/620

Subsumed by: https://github.com/source-academy/cadet-frontend/pull/637


Loss of data precision

Regarding the cdm_reader_mapper.cdm_mapper and see  Issue #8 and PR #23:
Current state
Whenthe mapping to the CDM format, the data is stored in a StringIO buffer and then read back into a pd.DataFrame.  I think this is due to memory limits and older pandas versions similar to the TextFileReader issue. The data type of the data in the StringIO buffer is NOT necessarily the same as the data type of the data in the pd.DataFrame. Setting the data type of the pd.DataFrame does not solve this issue. I did some tests with and without setting the data type. In this process there is a loss off data precision. I do not know why reading from a StringIO buffer leads to this loss.
Example
The latitude in the input data is 8838.  The mdf_reader converts this value into the float16 value 88.3750.  After mapping the data and reading it back, we get 88.40. The reqested number of digtis in the cdm_mapper psv output files is 4. Thus, we get 88.4000 in those files.
Crazy issue
Since cdm_reader_mapper converts data from pd.DataFrames into TextFileReader objects and StringIO buffer and vice versa, mainly for memory limit reasons, the input data is manipulated in a way that we may not want.
Question to @aanderss, @rcornes, @lizkent and @jtsiddons
Do we want this loss of data precision in our data? If not, I do not think I can fix this issue until the next release.

Could we use Float32 instead of Float16? I think 8838 would go to 88.3800 in this case.

The issue begins in mdf_reader. At the beginning each element is read as an  object. Afterwards this object is converted into

Could we use Float32 instead of Float16? I think 8838 would go to 88.3800 in this case.

I am searchin for the first occurance of the problem. I could't find where the data type of longitude is set to float16 😕

The issue begins in mdf_reader. At the beginning each element is read as an object. Afterwards this object is converted into the requested data type. For our latitude  example this is float32 (object_to_numeric). This is the code snippet:
        scale = scale if scale else self.numeric_scale
        offset = offset if offset else self.numeric_offset
        if data.dtype == "object":
            data = self.to_numeric(data)

        data = offset + data * scale
        return pd.Series(data, dtype=self.dtype)

At the beginning data is an object: 8838
scale is a float64: 0.01 (this is the default float type)
offset is a float64 too: 0.01
self.dtype is float32
data = self.to_numeric(data) -> data turns into an int64 (this is the default integer type): 8838
data = offset + data * scale -> data turns into a float64: 88.38
pd.Series(data, dtype=self.dtype) -> data turns into a float32: 88.379997

Here you can see the first "strange" thing.
After some data type conversions more the value is a float64: 88.379997
In the ouput file (of the mdf_reader) on disk it is 88.37999725341797.
😵
Do we really need all those data type conversions?
What is the value we expect in both mdf_reader and cdm_mapper ouput files?

If I set requested data type to float, the output is float64: 88.38.
The tests works with both the old expected testing values (88.37999725341797) and the new ones (88.38).
For python float64 88.38 seems to be the same as float64 88.37999725341797.
I would suggest using float instead of float32. Then we won't get digits in the output that are not in the imma1 input. 88.37999725341797 turns into 88.38 in the mdf_reader ouput. This seems better to me to be better than before, or are there any reasons why we have this long digits number.

Setting the latitude type to be float16 in the schema gives me 88.375 in the mdf_reader output file

In my view the mdf_reader ouput values should be as similar as possible to the input.
8838 -> 88.38 and not 88.375 or anything else containing digits that are not in the inputs, isn't it?

Some schema have a decimal_places field, I can't find anything in the mdf_reader module that references this field. Could we use the value from this field to round these values?
e.g: https://github.com/glamod/cdm_reader_mapper/blob/8e4e8422d315d84be85831016d25562819a1f483/cdm_reader_mapper/mdf_reader/schema/imma1.json#L67-L76

However we may still get extraneous digits...
>>> s = pd.Series([1012, 2249, 8838])
>>> (s/100).astype('float32').round(2)
0    10.120000
1    22.490000
2    88.379997
dtype: float32

Output should of course be similar to the input. That is why scale and offset are used in the input data and values are stored as integers. Type castings and conversions should be avoided and it is a good idea to reduce them.
The decimal module provides some of the capabilities we need here.

Some schema have a decimal_places field, I can't find anything in the mdf_reader module that references this field. Could we use the value from this field to round these values?
e.g:
https://github.com/glamod/cdm_reader_mapper/blob/8e4e8422d315d84be85831016d25562819a1f483/cdm_reader_mapper/mdf_reader/schema/imma1.json#L67-L76

That is good to know.

I created I new PR #60.

Some schema have a decimal_places field, I can't find anything in the mdf_reader module that references this field. Could we use the value from this field to round these values?
e.g:
https://github.com/glamod/cdm_reader_mapper/blob/8e4e8422d315d84be85831016d25562819a1f483/cdm_reader_mapper/mdf_reader/schema/imma1.json#L67-L76

I have removed these lines in PR #60 as they are not used.

However we may still get extraneous digits...
>>> s = pd.Series([1012, 2249, 8838])
>>> (s/100).astype('float32').round(2)
0    10.120000
1    22.490000
2    88.379997
dtype: float32

When we use default integer and float types we don't need any rounding.

Luckily, we do not need to touch the TextFileReader issue to solve this issuue.
Using default int and float types seems to be enough.

#60 merged
Done.


deltachat-desktop: 1.38.0 -> 1.38.1

Description of changes
Diff: https://github.com/deltachat/deltachat-desktop/compare/v1.38.0...v1.38.1
Changelog: https://github.com/deltachat/deltachat-desktop/blob/v1.38.1/CHANGELOG.md

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

cc @Simon-Laux

Result of nixpkgs-review pr 239414 run on x86_64-linux 1

1 package built:

deltachat-desktop


Write dedicated building code for ArgListSR

Still nothing beats reading construct hacks with code in strings :)

I don't think this is a hack. It's specialising the code generation for this struct. I could've gone with a custom class that inherits from  DictAdapter and overrides the emitbuild/parse methods, but that's boilerplate for the sake of boilerplate.
Code in strings is the life of doing runtime code generation.

I consider this a hack because it doesn't really scale very well in terms of readability. If you end up with 10 objects of class A but each has overwritten private methods on an per instance level, it get's really confusing. If they are all subclasses, yeah it's more boiler plate but less confusing when reading the code because you can already see and expect that they do something different because they are instances of different sub classes. An overwritten private method per instance 50 lines later is harder to recognize.
Anyways, it's also true that it doesn't matter that much here because the implementation's goal is to lead to the same output eventually.

In practice, ArgListSR is kinda a class? I think it just reads entirely worse by making a pointless class used in one single place.


ADD: Update fees to always use high gas on all blockchains

To not have transactions stuck in the mempool please configure that fees always uses highest current gas to sign transactions on every blockchain.

fixed in https://github.com/vultisig/vultisig-android/pull/272


Add SkipVersionCheck Parameter to Invoke-Maester to Support Air-Gapped Environments

Issue Description
The Invoke-Maester function currently performs a version check every time it is run. This is causing errors in air gapped environments so to provide more flexibility, it would be beneficial to have a SkipVersionCheck parameter that allows users to bypass this check.
Proposed Solution
Implement a SkipVersionCheck parameter in the Invoke-Maester function. When this parameter is set, the version check should be skipped.
Example Implementation
Add the SkipVersionCheck parameter to the Invoke-Maester function.
# Skip the version check.
# If set, the version check will not be performed.
[switch] $SkipVersionCheck

Wrap Get-IsNewMaesterVersionAvailable | Out-Null in an if statement.
if (-not $SkipVersionCheck) {
    Get-IsNewMaesterVersionAvailable | Out-Null
}

Please let me know if there are any additional details you would like to include.

Added skip version check option #567

Merged into preview release now. Thanks @joshuafdo!


DropdownButton fails to render if item's value is non-null

Steps to Reproduce
Using the following program the bug can be recreated. Notice that the "value" of the DropdownMenuItem is commented out. Initially the DropdownButton will properly render the text of "First".
Uncomment the line where the value is set.
Restart the app.
Expected Result:
The button renders the same as before.
Actual Result:
DropdownButton is empty.
I was also able to recreate this by using a 'String' object for T , however the posted code is closer to my actual use case.
import 'package:flutter/material.dart';

///Application Entry Point
void main(){
  runApp(new RecreationApp());
}

class RecreationApp extends StatelessWidget{

  @override
  Widget build(BuildContext context) {
    return new MaterialApp(
      title: "DropdownButton bug",
      home: new _RecreateScreen(),
    );
  }
}

class _RecreateScreen extends StatefulWidget {

  @override
  State<StatefulWidget> createState() => new _RecreateScreenState();
}

class _RecreateScreenState extends State<_RecreateScreen> {

  @override
  Widget build(BuildContext context) {
    List<DropdownMenuItem<CustomObject>> items = <DropdownMenuItem<CustomObject>>[];

    items.add(getItem("First"));
    items.add(getItem("Second"));
    items.add(getItem("Third"));

    return new Scaffold(
      body: new DropdownButton<CustomObject>(
        items: items,
        onChanged: (CustomObject o){
          if (o == null) {
            print("Object was null!");
          } else {
            print("Item was selected and non-null!");
          }
        },
      ),
    );
  }

  DropdownMenuItem<CustomObject> getItem(String name) {
    CustomObject object = new CustomObject(name);
    return new DropdownMenuItem(
//      value: object,
      child: new Text(object.fieldName),
    );
  }
}

class CustomObject extends Object {
  String fieldName;
  int specialNumber = 3;
  double otherNumber = 42.0;

  CustomObject(this.fieldName);
}

Logs
#Flutter Run Output :
(13:07 john@john-Blade-Stealth iminate) > flutter run
Launching lib/main.dart on Android SDK built for x86 in debug mode...
Initializing gradle...                                0.7s
Resolving dependencies...                             0.7s
Running 'gradlew assembleDebug'...
Configuration 'compile' in project ':app' is deprecated. Use 'implementation' instead.
Configuration 'debugCompile' in project ':app' is deprecated. Use 'debugImplementation' instead.
Configuration 'profileCompile' in project ':app' is deprecated. Use 'profileImplementation' instead.
Configuration 'releaseCompile' in project ':app' is deprecated. Use 'releaseImplementation' instead.
registerResGeneratingTask is deprecated, use registerGeneratedFolders(FileCollection)
registerResGeneratingTask is deprecated, use registerGeneratedFolders(FileCollection)
registerResGeneratingTask is deprecated, use registerGeneratedFolders(FileCollection)
Configuration 'debugProvided' in project ':connectivity' is deprecated. Use 'debugCompileOnly' instead.
Configuration 'releaseProvided' in project ':connectivity' is deprecated. Use 'releaseCompileOnly' instead.
Configuration 'compile' in project ':firebase_analytics' is deprecated. Use 'implementation' instead.
Configuration 'debugProvided' in project ':firebase_analytics' is deprecated. Use 'debugCompileOnly' instead.
Configuration 'releaseProvided' in project ':firebase_analytics' is deprecated. Use 'releaseCompileOnly' instead.
Configuration 'compile' in project ':firebase_auth' is deprecated. Use 'implementation' instead.
Configuration 'debugProvided' in project ':firebase_auth' is deprecated. Use 'debugCompileOnly' instead.
Configuration 'releaseProvided' in project ':firebase_auth' is deprecated. Use 'releaseCompileOnly' instead.
Configuration 'compile' in project ':google_sign_in' is deprecated. Use 'implementation' instead.
Configuration 'debugProvided' in project ':google_sign_in' is deprecated. Use 'debugCompileOnly' instead.
Configuration 'releaseProvided' in project ':google_sign_in' is deprecated. Use 'releaseCompileOnly' instead.
Built build/app/outputs/apk/debug/app-debug.apk (27.2MB).
Installing build/app/outputs/apk/app.apk...           1.7s
I/FlutterActivityDelegate(19371): onResume setting current activity to this
D/EGL_emulation(19371): eglCreateContext: 0xa63857e0: maj 3 min 1 rcv 4
D/EGL_emulation(19371): eglCreateContext: 0xa1bc5ee0: maj 3 min 1 rcv 4
D/EGL_emulation(19371): eglMakeCurrent: 0xa63857e0: ver 3 1 (tinfo 0x893eb770)
E/eglCodecCommon(19371): glUtilsParamSize: unknow param 0x000082da
E/eglCodecCommon(19371): glUtilsParamSize: unknow param 0x000082da
Syncing files to device Android SDK built for x86...
D/EGL_emulation(19371): eglMakeCurrent: 0xa1bc5ee0: ver 3 1 (tinfo 0xa1bd2e50)
E/eglCodecCommon(19371): glUtilsParamSize: unknow param 0x000082da
E/eglCodecCommon(19371): glUtilsParamSize: unknow param 0x000082da
D/        (19371): HostConnection::get() New Host Connection established 0x8737d940, tid 19397
D/EGL_emulation(19371): eglMakeCurrent: 0xa1bc5ee0: ver 3 1 (tinfo 0xab669980)
I/Choreographer(19371): Skipped 63 frames!  The application may be doing too much work on its main thread.
D/EGL_emulation(19371): eglMakeCurrent: 0xa63857e0: ver 3 1 (tinfo 0x893eb770)

🔥  To hot reload your app on the fly, press "r". To restart the app entirely, press "R".
An Observatory debugger and profiler on Android SDK built for x86 is available at: http://<IP_ADDRESS>:45350/
For a more detailed help message, press "h". To quit, press "q".

#Flutter Analyze Output :
(08:54 john@john-Blade-Stealth iminate) > flutter analyze
Analyzing /home/john/Code/flutter/iminate...
No issues found!
Ran in 5.9s

Flutter Doctor
`
[✓] Flutter (on Linux, locale en_US.UTF-8, channel alpha)
• Flutter at /home/john/Dev/flutter
• Framework revision 8f65fec5f5 (5 weeks ago), 2017-12-12 09:50:14 -0800
• Engine revision edaecdc8b8
• Tools Dart version 1.25.0-dev.11.0
• Engine Dart version 2.0.0-edge.d8ae797298c3a6cf8dc9f4558707bd2672224d3e
[✓] Android toolchain - develop for Android devices (Android SDK 27.0.3)
• Android SDK at /home/john/Android/Sdk
• Android NDK location not configured (optional; useful for native profiling support)
• Platform android-27, build-tools 27.0.3
• Java binary at: /home/john/Programs/android-studio-preview/jre/bin/java
• Java version OpenJDK Runtime Environment (build 1.8.0_152-release-915-b01)
[✓] Android Studio (version 3.0)
• Android Studio at /home/john/Programs/android-studio-preview
• Java version OpenJDK Runtime Environment (build 1.8.0_152-release-915-b01)
[✓] Android Studio (version 2.3)
• Android Studio at /home/john/Programs/android-studio
• Java version OpenJDK Runtime Environment (build 1.8.0_112-release-b06)
[✓] IntelliJ IDEA Ultimate Edition (version 2017.3)
• Flutter plugin version 20.0.3
• Dart plugin version 173.4127.31
[-] IntelliJ IDEA Community Edition (version 2017.2)
✗ Flutter plugin not installed; this adds Flutter specific functionality.
✗ Dart plugin not installed; this adds Dart specific functionality.
• For information about installing plugins, see
https://flutter.io/intellij-setup/#installing-the-plugins
[✓] Connected devices
• Android SDK built for x86 • emulator-5554 • android-x86 • Android 7.1.1 (API 25) (emulator)
`

For more information about diagnosing and reporting Flutter bugs, please see https://flutter.io/bug-reports/.

In case of the custom dropdown model. just adding
bool operator ==(o) => o is CustomObject && o.fieldName == fieldName;   //New
made it work. Thank you.


A reshape problem in InvConvNear

Hi, @jaywalnut310 。I'm trying to understand the glow-tts by reading the code. And I am a little bit confused about this piece of code in InvConvNear。
https://github.com/jaywalnut310/glow-tts/blob/13e997689d643410f5d9f1f9a73877ae85e19bc2/modules.py#L214-L215
So if the purpose is reshape the input x from [b,c,t] to [b, self.n_split, c // self.n_split, t]，what's the purpose of the L214？

I know the purpose of
https://github.com/jaywalnut310/glow-tts/blob/13e997689d643410f5d9f1f9a73877ae85e19bc2/modules.py#L214
is some kind of shuffle channel now, but I still not understand why this step is required.

I know the purpose of
https://github.com/jaywalnut310/glow-tts/blob/13e997689d643410f5d9f1f9a73877ae85e19bc2/modules.py#L214
is some kind of shuffle channel now, but I still not understand why this step is required.

对，这是一种通道维的shuffle。为什么要做通道维的shuffle？这个和Flow这个生成模型的原理相关，简单来说，在做affine transformation时，只有一半通道维的数据进行了运算，另一半保持不变，为了让另一半通道维的数据也进行运算，在下一次做affine transformation时可将通道维“互换”（参照《DENSITY ESTIMATION USING REAL NVP》）或者将通道维shuffle（参照《NICE: NON-LINEAR INDEPENDENT COMPONENTS
ESTIMATION
》）。


⚠ Jenkins Plugins Artifactory has degraded performance

In 3a46c2c, Jenkins Plugins Artifactory (https://get.jenkins.io/plugins/artifactory/) experienced degraded performance:

HTTP code: 200
Response time: 1287 ms

Resolved: Jenkins Plugins Artifactory performance has improved in b3b0d22 after 18 minutes.


Fix Android CI

The first commit stops assuming the username of the termux user, and queries the emulator for instead. This fixes #6570.
The second commit fixes android builds of stat, which had a bad android cfg sneak in.

CI seems good. Windows nightly code coverage failure is unrelated, android x86 passed but timed out uploading the artifact (presumably a network blip).


Add Battlestar

Added Battlestar.
More Hello World snippets here: http://rosettacode.org/wiki/Hello_world/Text

You should probably leave out the VIM line.


[BEAM-6432] Set dependent libraries' versions for the starter archetype automatically

For now, users have to replace the placeholders in pom.xml generated by beam-sdks-java-maven-archetypes-starter themselves.
This PR makes them to be replaced automatically, just like beam-sdks-java-maven-archetypes-examples does.

Follow this checklist to help us incorporate your contribution quickly and easily:

[x] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[x] If this contribution is large, please file an Apache Individual Contributor License Agreement.

It will help us expedite review of your Pull Request if you tag someone (e.g. @username) to look at it.


Labels don't appear on in app mobile browser for Android 4.2 (Samsung) emulator and device

The labels do not appear on a mobile in-app browser Android 4.2 (Samsung) emulator and device. The HTML and JS should be fine because it works on anything else we tested. The OS browser however works fine, there is only a problem with the in-app browser.
For already populated fields, the labels are there on load. When typing into an empty field, the placeholder dissapears, but the labels do not appear.

it seems that android 4.2 webview (I'm assuming that by 'in-app browser', you means the webview component) doesn't support blur and/or keyup events, so jvfloat won't work on the environment :disappointed:
sorry, but I can't do much about that. anyway, also welcoming discussions for the alternate events that we can hook to make this work on legacy environments.


Major Gift fields on Opp and Grant Deadlines rename to Deliverables

Critical Changes
Changes

NPSP has renamed the Grant Deadlines object to be Deliverables.  The fields have also been renamed to be less Grant specific.  This was done to make this object more applicable to additional types of Opportunities, such as Major Gifts.  All of the developer/api names have stayed the same.  If you prefer sticking with the previous labels, you can rename then, following the steps outlined in this knowledge article.  https://help.salesforce.com/apex/HTViewHelpDoc?id=customize_rename.htm&language=en_US
The Deliverables (previously Grant Deadlines) object now has a new picklist field called Type.  You need to enable Field Level Security on this new field.
Opportunity has 4 new fields that you need to enable Field Level Security for.  These are Ask Date, Qualified Date, Gift Strategy, and Closed Lost Reason.

Issues Closed
Fixes #1617

We might want to pre-empt this by pointing users to the "How to Change Labels" KB article from the release notes when this is released - thoughts?

Good idea Kevin.  I added the following:
If you prefer sticking with the previous labels, you can rename then, following the steps outlined in this knowledge article. https://help.salesforce.com/apex/HTViewHelpDoc?id=customize_rename.htm&language=en_US

👍

@davidhabib should the new Opportunity-Major Gift Layout.layout be added to the package? I noticed that de and en translations were added for the changed Grant_Deadline object and de only for the new fields on the Opportunity object. I'm always unsure of when we need to include the translation files, is there any hard and fast rule on that?

For the record, we have been including page layouts in the package (Matching Gift and Membership, for example) but not the Record Types.

@jjbennett

yes, we want the opp major gift layout added to the package, even though we won't package a record type.
i just include the language files whenever my checkin causes new ones to be generated.  since this is usually just placeholders for new terms, not a big deal to include or not include.  but i tend to include if they have changed.
don't merge this pull request until W-008308 Add "Type" field as part of included Grant Deadline Object fields is also done.  I'll ping you when it is ready early next week.
thanks!

@jjbennett I went ahead and finished this work, so it now also has the new Type picklist field on the Deliverables object, and I've added the Major Gift opp page layout to package.xml.
Unfortunately, this is sitting in the build queue, so not sure when it will run build.  hopefully soon, and hopefully it will pass.  but no need to get this merged until next week.  I'd like to get Nic's stuff in first into dev.  thanks.

@jjbennett added the missing Opp field renames.  thanks.

@davidhabib looks good, I'll wait for your go ahead to merge.


Add cluster plotting functions in pypots.utils.visualization

Adding handful of functions which allow user to visualize individual and mean cluster trajectories. Functions added:

get_cluster_members()
clusters_for_plotting()
plot_clusters()
get_cluster_means()
plot_cluster_means()

Sample output of plot_clusters():

Sample output of plot_cluster_means():

Related to #177
Before submitting

[x] Was this discussed/approved via a GitHub issue? Please add a link to it if that's the case.
[x] I have commented my code, particularly in hard-to-understand areas.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 73 (0.0%)  changed or added relevant lines in 1 file are covered.
6 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-1.5%) to 82.317%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

pypots/utils/visualization.py
0
73
0.0%

Files with Coverage Reduction
New Missed Lines
%

pypots/classification/base.py
2
76.92%

pypots/cli/env.py
4
57.14%

Totals

Change from base Build<PHONE_NUMBER>:
-1.5%

Covered Lines:
3780

Relevant Lines:
4592

💛  - Coveralls


Improvements for Usability

Are you open to export PoseViewer class in https://github.com/sign-language-processing/pose/blob/master/src/js/pose_viewer/src/index.ts so that that can be used as a component in different frameworks, currently only Components namespace is exported

Sure. if that helps you, please export it.
The reason it is not exported, is that the moment you use a pose-viewer element, you can then just access it from the DOM and that allows you access to the class instance

@AmitMY above PR solves it


An unhandled exception occurred while processing the request.

An unhandled exception occurred while processing the request.
VStudio：17.7.0-preview1.0
NETSDK：8.0.100-preview.4.23260.5
GrpcService1.zip

<PackageReference Include="Grpc.AspNetCore" Version="2.54.0-pre1" />
<PackageReference Include="Grpc.AspNetCore.Server.Reflection" Version="2.54.0-pre1" />
<PackageReference Include="Microsoft.AspNetCore.Grpc.JsonTranscoding" Version="8.0.0-preview.4.23260.4" />
<PackageReference Include="Microsoft.AspNetCore.Grpc.Swagger" Version="0.8.0-preview.4.23260.4" />
<PackageReference Include="Microsoft.VisualStudio.Azure.Containers.Tools.Targets" Version="1.19.1" />

https://github.com/dotnet/aspnetcore/issues/48589#issuecomment-1588684386
https://github.com/dotnet/runtime/issues/87460

This might be fixed in DotSwashbuckle, can you test using it please.
https://github.com/Havunen/DotSwashbuckle
https://www.nuget.org/packages/DotSwashbuckle.AspNetCore

It seems to be dependency of Microsoft.AspNetCore.Grpc.Swagger :/

Closing as external, and also the repro is using pre-release versions.
Please open a new issue if you can reproduce this with stable versions and you're certain the issue is with Swashbuckle and not an external dependency.


Fix react-native link fails

I've noticed that react-native link doesn't link correctly anymore.
Took some time until I found out that params passed in the android link step is an empty array.
I am pretty sure the reason for this lies somewhere else, this fixes the issue though.
So I made the check in the if more explicit which shouldn't harm either way.
Before the fix:
$ react-native link react-native-sentry
Scanning 563 folders for symlinks in /Users/haza/Projects/sentry-examples/react-native/AwesomeProject/node_modules (5ms)

After the fix:
$ react-native link react-native-sentry
react-native link react-native-sentry
Scanning 563 folders for symlinks in /Users/haza/Projects/sentry-examples/react-native/AwesomeProject/node_modules (6ms)
rnpm-install info Linking react-native-sentry android dependency
rnpm-install info Android module react-native-sentry has been successfully linked
rnpm-install info Linking react-native-sentry ios dependency
rnpm-install info iOS module react-native-sentry has been successfully linked
android/sentry.properties already exists
ios/sentry.properties already exists

Thanks for this!, was driving me insane trying to get link to go anything

cc: @Kureev

Sorry, I don't like to bump things but this still seems broken for some version.
@grabbou @Kureev

Sorry for not reacting earlier. I'm on it right now. Will test it on a blank project. If I can reproduce the issue and fix it by running react-native link from your branch - I'll give my approve.

I can confirm this PR fixes the linking problem for my project. I've been applying this patch before linking anything for some time.

I just checked the current state of the link using blank project and react-native-sentry. So far it all works good.
Here is my package.json:
{
        "name": "Test",
        "version": "0.0.1",
        "private": true,
        "scripts": {
                "start": "node node_modules/react-native/local-cli/cli.js start",
                "test": "jest"
        },
        "dependencies": {
                "react": "16.0.0-alpha.12",
                "react-native": "0.47.2",
                "react-native-sentry": "^0.22.0"
        },
        "devDependencies": {
                "babel-jest": "20.0.3",
                "babel-preset-react-native": "3.0.2",
                "jest": "20.0.4",
                "react-test-renderer": "16.0.0-alpha.12"
        },
        "jest": {
                "preset": "react-native"
        }
}

In the project I use
react-native-cli: 2.0.1
react-native: 0.47.2

For some reason I can't reproduce your issue. Can you be a bit more specific about it?

@Kureev I can confirm that this error is gone for the latest react-native version 0.47.2.
As I wrote in the initial PR comment the reason for this possibly lies somewhere else than the fix I submitted.
But this was broken for a version in the past.
So I let you decide what to do from here, probably you can just close it and people should upgrade their react-native if they are still having troubles.

@HazAT I'm wondering if you know the way we can fix it for previous versions. IIRC there were no incidents when the previous version has been patched after the new one is released with the fix.
Theoretically speaking: if I merge this PR, it'll land in something like 0.47.3 or 0.48, but in these versions the issue you want to fix is already gone, so I don't see any arguments for merging.
Don't get me wrong, you did a great job investigating and solving the issue, but because of the delay from our side it is not relevant anymore 😞 . I'm very sorry for this experience, especially taking into account it is your first contribution to the project. I hope it won't undermine your trust in the community or RN team and we'll see your contributions in the future.
I'm about to close this PR as the issue is already fixed in the newest version. If you feel there is still something we need to do, feel free to ping me to re-open this.
Thanks for understanding!

@Kureev No problem at all 😄
I totally understand the decision, would have done the same.
move fast, break things, fix stuff >>> never release anything
that's the best and worst thing about react native 😂

@Kureev Another user of ours reported that it's not working.
Turns out the broken version was 0.47.0
Steps to reproduce:
react-native init AwesomeProject --version<EMAIL_ADDRESS>cd AwesomeProject
yarn add react-native-sentry
react-native link react-native-sentry
Output:
Scanning 583 folders for symlinks in /private/tmp/AwesomeProject/node_modules (9ms)

So no actual linking, since this is working in 0.47.2 there is nothing to do, I just wanted to document this for completeness.

I have the same issue with 0.46.0, I am using ReactXP which just upgraded react native to 0.46.0. Is there any way I can get react-native link working on that version?
Really stuck on this one, any help is highly appreciated :)

Still having the same issue as @HazAT posted on Aug 31


Add delay flag, bump to 0.8

Should this be updated in the README before this is merged?
Defaults have changed with the current release. See the CHANGELOG for details.

Yup--fine to remove that README warning I think.


feat: DNM v0.50 EVM Support

This appetizer pairs very nicely with a bottle of https://github.com/rollchains/cosmos-evm/pull/1 if you wish

ATM I am not sure if this TxIndex() is required or an upstream Sei specific feature (for their multi threaded processing). Something with the sdk.AnteDepGenerator as well


Add https.agent to xior.create() and interceptors

Hi there. I'm giving xior a try on Next.js 14, but the issue is I need to send client certificates (certificate.crt, certificate.key) in all requests along with access_token acquired during authentication.
I've messed around with axios on Next.js API Routes where I have access to node and I got something along the following lines working.
I'm setting up the certificates with axios as bellow:
/lib/banking-api.ts
import https from 'https'
import fs from 'fs'
import axios from 'axios'
import { getServerSession } from 'next-auth'
import { authOptions } from '@/auth'

const baseURL = process.env.BANKING_API_BASE_URL

const certFile = fs.readFileSync('certificates/api-cert.crt')
const keyFile = fs.readFileSync('certificates/api-cert.key')

export const httpsAgent = new https.Agent({
  cert: certFile,
  key: keyFile,
  //passphrase: ''
})

Here I finish axios configuration such as passing token to headers config...
export const httpClient = axios.create({
  baseURL: baseURL,
  headers: {
    'x-account': process.env.BANKING_API_ACCOUNT,
    withCredentials: true
  },
  httpsAgent: httpsAgent
})

httpClient.interceptors.request.use(
  async (config) => {
    const session = await getServerSession(authOptions)
    const token = session?.user?.access_token
    config.headers.Authorization = token ? `Bearer ${token}` : ''
    return config
  },
  (error) => {
    return Promise.reject(error)
  }
)

const api = httpClient

export default api

Within API routes I've tried to use Next.js 14 fetch() but it seems not to support the https.agent configuration so I couldn't set up the certificates. I've tried something along the lines bellow:
import { httpsAgent } from '@/lib/banking-api'

const result = await fetch('https://api.banking.com', {
    (...)
    agent: httpsAgent
}

Bellow is an API route that successfuly works as expected, but given the way I've set up axios as httpClient under /lib/banking-api.ts, a few issues arrise as I explain ahead.
/api/banking/balance/route.ts
'use server'
import type { NextApiHandler } from 'next'
import { NextApiRequest, NextApiResponse } from 'next'
import { NextResponse } from 'next/server'
import { httpClient } from '@/lib/banking-api'

const dateSimple = () => new Date().toISOString().slice(0, 10) // 2024-04-19

export const GET: NextApiHandler = async (request: NextApiRequest, response: NextApiResponse) => {
  try {
    // calling external api service with custom axios config
    const response = await httpClient.get('https://api.banking.com/v2/balance', {
      params: {
        date: dateSimple()
      }
    })

    const data = response.data

    return NextResponse.json(data, { status: 200 })
  } catch (error) {
    return NextResponse.json(error, { status: 500 })
  }
}

On client components or pages explicity setting 'use client' directive, if I make a request to https://localhost:3000/api/banking/balance using Next.js fetch() I successfully get a response data from the API route above. I then use React.useState() to manage the data for the component or page...
However, If I try to import the custom axios httpClient and use it to make requests within client components, 'fs' and 'https' modules won't load giving "module not found" error as long as they're used server side only.
On server components or pages if I make a request to https://localhost:3000/api/banking/balance using Next.js fetch() I get a 401 unauthorized response as long as fetch() is not sending the client certificates in the request.

I got you!
Try to proxy the API on the server side, 2 steps:
Step 1. Create file pages/api/[...path].ts:

don't forget to install http-proxy

import fs from 'fs';
import { IncomingMessage, ServerResponse } from 'http';
import httpProxy from 'http-proxy';
import https from 'https';

const baseURL = process.env.BANKING_API_BASE_URL;
const certFile = fs.readFileSync('certificates/api-cert.crt');
const keyFile = fs.readFileSync('certificates/api-cert.key');

export const httpsAgent = new https.Agent({
  cert: certFile,
  key: keyFile,
  //passphrase: ''
});

const proxy = httpProxy.createProxyServer();
export default function api(req: IncomingMessage, res: ServerResponse<IncomingMessage>) {
  return new Promise((resolve, reject) => {
    proxy.web(req, res, { target: baseURL, changeOrigin: true, agent: httpsAgent }, (err) => {
      if (err) {
        return reject(err);
      } else {
        resolve(1);
      }
    });
  });
}

export const config = {
  api: {
    bodyParser: false,
  },
};

Steps 2.  Use axios or xior to request:
import axios from 'xior';
import { getServerSession } from 'next-auth'
import { authOptions } from '@/auth'

const isServer = typeof document === 'undefined';

export const httpClient = axios.create({
  baseURL: 'http://localhost:3000', // This depends on your next.js server
});

httpClient.interceptors.request.use(
  async (config) => {
    let token = '';
    if (isServer) {
      const session = await getServerSession(authOptions)
      token = session?.user?.access_token
    } else {
       // TODO: get token for client
     }
    config.headers.Authorization = token ? `Bearer ${token}` : ''
    return config
  },
  (error) => {
    return Promise.reject(error)
  }
)

const api = httpClient

export default api

Tips: you can add syntax highlight to your code like: ```ts console.log('hi'); ````

@suhaotian Thank you so much for guiding me in detail! I'll give it try and come back here to share any further achievements. I've applied the highlight syntax for a better reading, thanks for the tip!
I've came across tons of questions without any answer from other people trying to deal with that kind of two-way (mTLS) Client Certificate communication relying solely on Next.js 13 / 14, but I'm happy I might have found the way!