Removed ForwardingMap

What
Removed usage of Guava ForwardingMap.
How
Replaced SimpleChangeNotifyingMap class usages with ChangeNotifyingMap
interface.
Created new instances of ChangeNotifyingMap with SimpleChangeNotifyingMap.wrap method that uses a reflection proxy to delegate to another Map and implements the hasChanged method and checks for map changes in an InvocationHandler.
Testing
Added resolveConflictsForDocument_twoConflictAndNewWinner_newWinnerInsertedWithModifiedAttachments to exercise the hasChanged path which was untested before.
Issues
Part of #308

+1

+1


[cloud_firestore] Need id generator like createId() function in AngularFire

In some cases I need generate id before store document in firestore.
In AngularFire there is function createId()
In Flutter I can import 'package:cloud_firestore/src/utils/auto_id_generator.dart' (since 0.12.8, push_id_generator before)
and then use AutoIdGenerator.autoId()
But it's not true way, because I should import implementation files from another package.

CollectionReference has an add method which returns an auto-generated ID:
https://pub.dev/documentation/cloud_firestore/latest/cloud_firestore/CollectionReference/add.html

Maybe it is not perfect way, but I persist Document Id inside it. So I need generate id before calling add() method.

I use:
String id = reference.document().documentID;
Then apply the id within the document and any other documents, then save.

Ok, storing Document Id in itself not good practice. So in this case no need for id generation.
But what about transaction or batch writes?
For example, I want to add document to collection and then store it Id in other document
Firestore.instance.runTransaction((tx) async {
  String docId = 'docId';//It should be generated
  await tx.set(Firestore.instance.collection('collection').document(docId), {'some':'data'});
  //There i need docId to store it in other Document
  await tx.set(Firestore.instance.collection('collection2').document('DocumentId2'), {'docId':docId});
});

Transaction doesn't have add method, so I need use set with generated id.
With Batch write situation is similar.

Use document without passing a path:
https://pub.dev/documentation/cloud_firestore/latest/cloud_firestore/CollectionReference/document.html
This generates a unique id without setting it within database like add does.

It is solution, thank you

I know its late but here is what I did
String randomId() {
    var _randomId = Firestore.instance.collection('').document().documentID;
    print(randomId());
    return _randomId;
}

I know its late but here is what I did
String randomId() {
    var _randomId = Firestore.instance.collection('').document().documentID;
    print(randomId());
    return _randomId;
}

Can this produce a unique ID. I am thinking it would somehow create an ID that already exists.

They are unique: https://stackoverflow.com/questions/46618719/firestore-are-ids-unique-in-the-collection-or-globally

I know its late but here is what I did
String randomId() {
    var _randomId = Firestore.instance.collection('').document().documentID;
    print(randomId());
    return _randomId;
}

Doesn't work on web at the present moment (cloud_firestore: 0.13.7), getting this error:
Function Firestore.collection() requires its first argument to be of type non-empty string, but it was: ""


Merging #594 into latest sources

Got latest version. Synced #594 into new branch, made sure it compiled by fixing merging issues. Fixed missing resources. Commited. Realized I should have used a fork instead of working under same repo. Created fork. Pulled new branch into fork, merged with dev. Committed. Synced. Pull Request.

Thanks for taking the time to do this.  I am going to update my original PR


⚠ Bofrost.at has degraded performance

In e24d193, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 2091 ms

Resolved: Bofrost.at performance has improved in 16ae515.


feat: add azure-pipelines-language-server

@mason-org/triage notify(Reason::NewPullRequest)
This comment ensures a notification is delivered to maintainers.
 🤖 This is an automated comment.    📖 Source code


Portuguese (Brazil) translation

Hi!
This is the translation to Portuguese (Brazil). I hope this helps! Keep it up, I've loved this pkg manager!

@ricardoprins thank you for contributing. The pr has issues with liniting, you can just run $ xc prettier should help fix it.
Also is there a 2-letter code for this language/country?

There is; however, Brazilian Portuguese is a little different from Portugal Portuguese, and it is usually the norm to use pt-br to differentiate both.
I'll run the linter here.

@ricardoprins thanks for enlightening us.

@ricardoprins you need to execute in the root $ xc prettier then stage and commit the changes.

I'll do it later today :) gonna take my kid to have some fun first haha

@ricardoprins thank you merging this now.


Closing the fullscreen via "X" or Esc key doesn't toggle the full screen icon back

https://user-images.githubusercontent.com/51932655/116824982-93c8a400-ab52-11eb-8e3a-eb98628f06a9.mp4
When the "X" (one icon to the right just next to it) or the Esc key is pressed, the full screen icon is not toggling its sprite correctly (it ends showing the exit full screen instead of enter full screen icon).
This is only a minor visual bug on the icon, the actual entering/exiting of the full screen is working correctly.
The third way I found to exit the full screen is by clicking the full screen icon while in full screen, this however toggles the icon back correctly and is working as intended.
I'm using FireFox 88.0 (64 bits).

Yes, that's a side-effect when toggling the fullscreen manually. Sadly a global key listener will not trigger the event when pressing Esc to leave the fullscreen. I could try to add a resize listener, or some kind of observer to catch the fullscreen switch when toggled manually. The reason why the icon still have the correct behavior when clicked on it is, when leaving the fullscreen a false state will trigger fullscreen instead (it reduces the side-effect to just visually false). These check needs to be assigned on one of the listeners which could be catched by a fullscreen toggle. That is something which I could fix very soon.
Thank you for the hint.

Btw, when clicking the close icon, I just forget to reset state, that will be fixed in the next commit.

The new version 0.7.2 has a perfect workaround for this. But it comes with a tiny drawback. When a user entering the fullscreen state manually the icon goes hidden, because there is no way to leave a manual toggled fullscreen state due to a restriction by the browser.


FixBrokenLinks: User Story 1562968

I'm fixing broken links for User Story 1562968 (Intune repo). A link goes to the page I changed but the heading markdown is not rendering correctly. I've removed the span tag on the affected heading (and others) so they render correctly.
@Dansimp you are listed as the author of the article. Just wanted to let you know why I'm touching anything. Let me know if you have any questions or feedback.

@Dansimp I've finished my changes. Please review the changes and merge if they look good to you.


June gems

June Gems are here- going to try to get it out while it's still June! :)

@shcheklein revisions are pushed

I think all issues are addressed. Aiming to publish tomorrow AM so let's merge then?


Feature Request: Support HSV output

This would be useful when using the Adafruit NeoPixel library for some easy color transitions.
Maybe something like this in CheerLights.h:
// Public
uint16_t currentColorHue();
uint8_t currentColorSaturation();
uint8_t currentColorValue();
// Private
uint16_t _colorHue;
uint8_t _colorSat;
uint8_t _colorVal;

Then in CheerLights.cpp:
// in _fetchColor create separate struct (or modify RGB one):
  // Map the color name to a HSV value
  static const struct {
    const char* name;
    uint16_t hue;
    uint8_t sat;
    uint8_t val;
  } colorMapHSV[] = {
    {"red", 0, 255, 255},
    {"green", 21845, 255, 255},
    {"blue", 43690, 255, 255},
    {"cyan", 32767, 255, 255},
    {"white", 0, 0, 255},
    {"warmwhite", 7123, 23, 253},
    {"oldlace", 7123, 23, 253},
    {"magenta", 54612, 255, 255},
    {"yellow", 10922, 255, 255},
    {"orange", 6954, 255, 255},
    {"purple", 54612, 255, 128},
    {"pink", 63627, 63, 255},
    {"black", 0, 0, 0}
  };

  for (const auto& colorHSV : colorMapHSV) {
    if (strcasecmp(_colorName, colorHSV.name) == 0) {
      _colorHue = colorHSV.hue;
      _colorSat = colorHSV.sat;
      _colorVal = colorHSV.val;
      break;
    }
  }

For returning values:
uint16_t CheerLights::currentColorHue() {
  return _colorHue;
}

uint8_t CheerLights::currentColorSaturation() {
  return _colorSat;
}

uint8_t CheerLights::currentColorValue() {
  return _colorVal;
}

Thanks for the detailed enhancement request. I was able to implement it fairly quickly with Releaser v1.0.4 (https://github.com/cheerlights/cheerlights-arduino-library/releases/tag/1.0.4). I agree this will help out with the  Adafruit NeoPixel library. If you come up with any other ideas/feedback, please share.
We are active on Discord: https://cheerlights.com/discord

Thanks for the detailed enhancement request. I was able to implement it fairly quickly with Releaser v1.0.4 (https://github.com/cheerlights/cheerlights-arduino-library/releases/tag/1.0.4). I agree this will help out with the Adafruit NeoPixel library. If you come up with any other ideas/feedback, please share.
We are active on Discord: https://cheerlights.com/discord


Fix typos

Found via typos --format brief

Hey @kianmeng! Sorry for the huge delay, there were some security implications of having an external PR merged that we hadn't been able to sort out yet. We can merge this if you resolve the conflicts in the notebooks. Thanks for your contribution!

@ianspektor I can't seem to clone this repo due to this error:
$ git clone https://github.com/google/temporian
Cloning into 'temporian'...
remote: Enumerating objects: 24853, done.
remote: Counting objects: 100% (2115/2115), done.
remote: Compressing objects: 100% (645/645), done.
error: RPC failed; curl 92 HTTP/2 stream 5 was not closed cleanly: CANCEL (err 8)
error: 5989 bytes of body are still expected
fetch-pack: unexpected disconnect while reading sideband packet
fatal: early EOF
fatal: fetch-pack: invalid index-pack output

Even after trying the solutions suggested here, it still won't work for me after over 30 attempts.
Perhaps you guys want to resolve this on your own?

Hey @kianmeng - I can clone it correctly. Have you tried these?

Hey @kianmeng - I can clone it correctly. Have you tried these?

Not working for me, still the same issue, even after tweaking the recommended solutions suggested in the link.

Hey @kianmeng! Cloning is working fine for everyone in the team, and for external contributors too. I'd suggest to keep trying out the solutions recommended in StackOverflow/GH issues. Sorry to not be of much help here!

@ianspektor Sorry for the delay, I have managed to clone without issue right now.
I will close the PR since all the typos have been resolved. Thanks.


Support branch coverage

Branch coverage parsing is only implemented for the xml coverage format. If there is interest, I can look into parsing the text format as well.

@MishaKav Looks like the workflow doesn't work in forks

Thanks for the PR, it's a great feature,
it has some problems with forks #68 , I will try to find some time, to test your changes and to merge them.

@MishaKav thank you. Let me know if you have any comments in the PR, happy to fix or improve it.

@MishaKav It looks like to fix the issues in the pipeline, the two common approaches are to either

Use the pull_request_target trigger instead of pull_request. Set the minimal permissions for the job, probably {repo: read, issues: write}. There is a small chance that someone will abuse this, but since you review the changes before triggering the workflow, it should be pretty safe. Some background on this is given here.
Add a workflow_run workflow in addition to the pull_request one you have. For this, you'll need to add an option to your action to save the output as a, say, json file instead of posting the comment directly. In the pull_request workflow you will produce that json file and upload it as an artifact. Then in the workflow_run you will download that artifact and post it as a comment. See here for an example. This is clearly more work than option 1, but the advantage is that no untrusted code ever runs with access to your project. Other people using your action to can use this approach as well.

Let me know if you are interested in implementing either of the options.

@MishaKav thank you! FWIW I've been using this change for two months without issues. The caveat is that I use the xml format, so I did not update the text format parser.


Enabling monitoring by providing "enable_cluster_monitoring: true" in cluster yml file during creation fails

Version: Master
Steps:

Create a DO cluster by providing "enable_cluster_monitoring: true"

#   # Rancher Config
#
docker_root_dir: "/var/lib/docker"
enable_cluster_alerting: false
enable_cluster_monitoring: true
enable_network_policy: false
local_cluster_auth_endpoint:
  enabled: true
name: "enablemonitoringthroughyaml"

After the cluster is active, monitoring is not enabled
Monitoring is not enabled at the cluster level

In the system project, the cattle-prometheus namespace has only one pod running as below:

Note: On a cluster with monitoring enabled manually, the cattle-prometheus namespace is as below:

Tested with master-head build from July 31st.

Create a DO cluster by providing "enable_cluster_monitoring: true" in the cluster yml
After the cluster is active, verified that monitoring is enabled.
In the system project, the cattle-prometheus namespace is as below:


add support for 4.26

@n-jing Thank you for your contribution. I gave it a quick test with UE4.26 and it works properly.


Fix non ssl connection in aqueduct db upgrade even if --use-ssl is used.

The cli command aqueduct db upgrade was not able to connect to SSL only postgres instances while running migration scripts. Issue #811
This PR changes src/cli/scripts/run_upgrade.dart -> RunUpgradeExecutable.execute to use SSL if --use-ssl is used while aqueduct db upgrade.

@joeconwaystk what do you think about this PR? Something that could be merged soon? :-)


Meta Issue - Goals

Hi @mkbouaziz ,
I see that you forked https://github.com/retrography/OrientR repos and included new features!
I am currently in a R project and we will use Orient so I have a high interest in helping this package out. Do you know why your PR's haven't been accepted as they look very promising and feature documentation?
Do you have any plans for this package in future?
What is missing?
Best, Philip

Hi @pmig , Welcome,
About PR haven't been accepted:
sincerely I don't know why, I contacted @retrography for this issue, but no answer yet.
I haven't any plan now, but I can work more in this package by weekends
About file orientSql.R:
I saw that I couldn't use: Insert, update, delete in the old package of OrientR, so I decide to resolve the problem by checking the type of query. until now I haven't resolved this problem.
I added other functions for more details about Orient Databases
Best, Mohamed

The Orient REST API provides different interfaces:

Document Interface which provides GET / PUT / POST Methods to update single nodes
** currently only get is implemented
** I would like to implement also the HEAD/ POST / PUT / DELETE / PATCH methods, for more information see #5

Query Interface which only performs queries that don't change the state of the orient

And can only perform idempotent commands

Command interface which can perform different update types

The Query and Command Interface in this package is strangely mixed into  the orientSql function. Whats the plan on that one?

about the documentation, I used the official WebSite Documentations.
there are two methods:
1- we implement one function that can execute all types of SQL query, so users will not have a problem. I implemented functions by this way.
2- we implement functions by type of query.
So our first goal is to implement successfully all REST API, then we can choose the best one.
If you want to split query I have no problem, but I think it will not be great, we can try it no problem.

ah ok cool. Yeah I think implementing all REST API is a good first step. Then we can fore sure choose / optimize (-:
I'm currently on the document api as described in #5

Hi guys,
I am happy you are getting active on this. I developed the original package just because I needed to fetch some data into R for my research and never thought it may attract further attention.  Feel free to fork and modify and put the things in order.
I am awfully busy writing up my doctoral thesis, what explains the lack of responsiveness on my side. I do look at the activity here and I gladly accept the pull requests, but sometimes it may take me days to come back to you.
@mkbouaziz you closed your pull request before I get to write to you about it. I was in a conference when you made it and I did not agree with some of the minor changes, and I thought we could see to t together. The I followed the development on your branch and noticed you have not worked on it anymore, so I didn't bother.
My two cents about the dev: I have recently noticed you can easily get CSV from OrientDB's REST API. The process of JSON conversion is very slow and error prone in R. Actually I have noticed several bugs in the current version of the package. If I were you, I would plan on fetching all responses in CSV rather than JSON (if the objective is having data frames in the end). That will reduce the complexity of the whole process and will allow you to move much faster. It will also make it unnecessary to optimize your code, given that you will write very little code!

Hi @retrography ,
Thank you for your comment.
For my part. I also currently work on my master thesis and need to do analysis within R and put the data back to orient.
I will now work on the document API #5  as soon as I have we have a new feature ready.
We should merge together all our projects!

Hi @pmig,
Again, I am glad you are working on it. If you guys have time feel free to take the project over.
This used to be a fork of my repo, but it seems @mkbouaziz has reimported the repo / removed the fork, which makes it quite complicated to merge. I think it is important to keep this as a fork of my repo, given that my repo is referenced on OrientDB's website. Anyway, let's come up with a solution for that.
I am more interested in interfacing between OrientDB and igraph. If you guys get the basics done, I will put a weekend on interfacing. It would be amazing to be able to load a whole graph from OrientDB right into igraph (or statute) for analysis!

Yes I definitely saw this problem and YES we have to work on it!
We also have to think about breaking the API. Right of now @retrography  and @mkbouaziz  packages already have different methods for executing a query AND accessing the database.
We should either revert these changes or create a v1 / v2 version and keep the old one unmaintained.

@pmig That's exactly what I wanted to discuss with @mkbouaziz when I took long to respond to his pull request!


[RFC]: Remove scheme filtering

RFC

Q
A

Proposed Version(s)
4.0.0

BC Break?
Yes

Goal

Remove the scheme filtering which prevents creating non-HTTP URIs.
Background

Diactoros is providing a PSR-7 UriInterface implementation but Uri is not tied to HTTP only.
In mezzio/mezzio-cors, we do make use of the UriInterface for Origin.
We do use the CORS implementation in our project which seems to be requested from within whatever chrome extension.
When that chrome extension does execute requests, we receive the following Origin:
Origin: chrome-extension://knohfebhibeknbfioecpdmdkjkjdnjnl

When parsing that origin header and after passing to UriFactoryInterface#createUri, an exception is thrown:
Laminas\Diactoros\Exception\InvalidArgumentException: Unsupported scheme "chrome-extension"; must be any empty string or in the set (http, https)

Considerations

I do not really see a huge benefit in having this kind of restriction unless the class is named HttpUri.
I am aware that extending the Uri might be a solution (as I could extend allowedSchemes), but since we do add final to a bunch of components lately, at some point, the Uri of diactoros will receive that as well.
Due to the fact that the CORS component does not use diactoros directly, I am unsure if that issue should be handled by upstream users.
However, I've checked nyholm/psr7 and guzzlehttp/psr7 and both are "fine" with having chrome-extension (or non-HTTP related schemes) in place. For the sake of interoperability, I'd love to get rid of throwing exceptions when Uris are created with non-HTTP schemes.
Proposal(s)

Just remove the Uri#filterScheme logic where we throw an exception when the scheme is not part of the allowedSchemes map. We should just verify that the scheme is valid as per RFC definition.
Appendix

Guzzle PSR7 implementation
Nyholm PSR7 implementation

One important consideration: PSR-7 packages are about abstracting HTTP messaging, so that needs to be considered upfront.
I'm fine with the proposal, just throwing in this data point.

My takes:

PSR-7 very explicitly states: "UriInterface models HTTP and HTTPS URIs as specified in RFC 3986 (the primary use case)". When developing PSR-7, there was some discussion about modeling any URI, and we chose NOT to do this, as there are a number of URIs that are formed quite differently; many would NOT work in an HTTP context. The consensus was that something targeting all of RFC 3986 would need a separate PSR, and that most likely if we abstracted only HTTP/HTTPS URIs, it could likely later extend such a PSR and still retain compatibility with PSR-7.
Technically, if other PSR-7 implementations are supporting anything other than HTTP/HTTPS in their UriInterface implementations, they are deviating.
All that said, I have no problem with changing this, but we need to be careful to note that our implementation does NOT cover all of RFC 3986, and that it's potentially possible to obtain and/or construct a URI that cannot be used within your application.


Ug spelling mistake

Codecov Report
Base: 65.72% // Head: 65.67% // Decreases project coverage by -0.05% :warning:

Coverage data is based on head (a032a02) compared to base (39b15f9).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #355      +/-   ##
============================================
- Coverage     65.72%   65.67%   -0.06%
  Complexity      684      684
============================================
  Files           113      113
  Lines          2241     2243       +2
  Branches        257      258       +1
============================================
  Hits           1473     1473
- Misses          665      667       +2
  Partials        103      103

Impacted Files
Coverage Δ

...address/logic/parser/EditMeetingCommandParser.java
0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Null-check Client and Client.Data in all the places in the components…

… to hopefully avoid some hard to debug crashes people have been having when disconnecting at the wrong time.
I haven't test-ran this yet to see if I did anything silly.

Perhaps CelesteNetGameComponent.Init should fail if it can't register the handlers, it just shouldn't crash 🤔 But surely just not registering the handlers wouldn't be good either.


Bootstrap DatePicker

The selection of a day via mause cklick don't work. The input field stay empty.
If I want change the month (click to the arrow icons) than the calender will closed.
...tested with Firefox 56.0.2, IE 11
see: http://gijgo.com/datepicker/example/bootstrap

This is fixed in the new development build. Thanks for reporting this.


Add an overview and vision statement to the documentation landing page

This can help people understand the overall project.

There is something that makes some noise I believe:
(I generated locally that's why you don't see the readthedocs theme)

This index page contains a Maliput Overview section, however, there is also a Maliput Overview page for the overview over the library: https://maliput.readthedocs.io/en/latest/maliput_overview.html
We should rename either one of them probably to avoid any confusion.

Thanks for the improved integration with the getting started content. The new layout looks good to me.


docs: Version 10.x

Platforms affected
Docs
Motivation and Context

Think it's about time to release CLI 10 docs.
Closes https://github.com/apache/cordova-docs/issues/1146
Description

Testing

Ensure pages load.
Checklist

[x] I've run the tests to see all new and existing tests pass
[x] I added automated test coverage as appropriate for this change
[x] Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
[x] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
[x] I've updated the documentation if necessary

Will merge on Saturday assuming there is no rejections.


Use after free when awaiting in event callback if object is freed

When firing an event and then immediately deleting an object, we get a use after free if the event callback has a suspension point
#include <Unknwn.h>

#define __cpp_coroutines // temporary workaround to get coroutines working in C++20 mode
#include <winrt/base.h>
#include <winrt/Windows.Foundation.h>

#include <chrono>
#include <iostream>
#include <memory>

struct test : winrt::implements<test, IUnknown>
{
	winrt::event<winrt::delegate<>> testEvent;
};

int main()
{
	auto testClass = winrt::make_self<test>();
	auto veryimportant = std::make_unique<int>(1337);

	testClass->testEvent.add([stillveryimportant = std::move(veryimportant)]() -> winrt::fire_and_forget
	{
		using namespace std::chrono_literals;

		co_await 1s;

		// use-after-free here
		std::cout << *stillveryimportant;
	});

	testClass->testEvent();
	testClass = nullptr;

	MSG msg;
	while (GetMessage(&msg, nullptr, 0, 0))
	{
		TranslateMessage(&msg);
		DispatchMessage(&msg);
	}
}

The lambda internal this is freed on the first coroutine suspension point, meaning accessing captured variables after this point will lead to undefined behavior and crashes.

See #766


The compilation time is slow

I used nlohmann::json in some AST tree to JSON conversion in a compiler, and it was very easy to get started, documentation is good, syntax is simple and it just works. However, I noticed that the compilation time of my code got really slow. So I switched to rapidjson, it took me a lot longer to get started, but when all was done, the compilation of one file got from 4.8s to 1.8s, here is the patch that achieves this speed up:
https://gitlab.com/lfortran/lfortran/commit/904cb6301e86f95e6ad86d571ea74b23cd2b0e70
and another file from 5.7s to 2.8s:
https://gitlab.com/lfortran/lfortran/commit/bfe179ec2ab72855d273db1258c858857ddb9fa2
I am posting it here as a feedback, if there is anything that you can do to speedup the compilation, that would be very helpful.

I just want to +1 this suggestion.
Compilation with nlohmann::json is really, really slow. I use it extensively in my company's project, but since we're in the initial phase of rapid prototyping, the high compilation times are making development grind to a halt.
I found this ticket while searching for a way to improve compilation times with nlohmann::json. Even gcc precompiled headers aren't solving the problem.

Something that could help is the forward declaration header. I used it in my project so that I only had to include json in my cpp files.
However, the JsonFwd.h does not work ad-hoc with the singleinclude json header (you have to remove the default template arguments in json.h).
Another suggestion would be to introduce variability, maybe through ifdefs. There are lots of cool features in nlohmann::json but as I do not need all of them, turning some things off for compilation would help, too.

I don't think json_fwd.hpp works together with NLOHMANN_JSON_SERIALIZE_ENUM. The enums serialization must be defined in the header file, and it requires json.hpp. Or maybe I'm doing something wrong...

Constexpr slow down compilation time but should help execute code faster.
I am not REALLY sure of what I said above but I hide strings in some of my binaries using Constexpr and I see a huge difference while compiling .. like it takes more time to finish when using Constexpr.

@ClaudiuHKS Do you have some benchmarks on the effect of constexpr?

@ClaudiuHKS Do you have some benchmarks on the effect of constexpr?

With Constexpr
#include <Windows.h>
#include <stdio.h>
void main (void)
{
constexpr char Data [8192] = { '-', };
printf ("%s\n", Data);
};
Without Constexpr
#include <Windows.h>
#include <stdio.h>
void main (void)
{
char Data [8192] = { '-', };
printf ("%s\n", Data);
};
You should really see the difference yourself, while compiling them, like it takes much more time to compile when Constexpr exists, but I think the code will execute faster when it runs, rather than when Constexpr is absent.
NOTE! I have tested it with Visual Studio 2019 on Windows 10, I have no idea if it's the same for other operating systems.

I cannot reproduce this on macOS:

https://pastebin.com/Wbz0rHd6

Hi, any updates? The slowness of compilation is quite annoying :(

Please reopen. This stale-bot is just closing valid stuff for no reason.

@nlohmann I see that you gave a thumbs down to my original issue report above. May I ask what I wrote that deserved this? Do you not want me to give feedback anymore? Or was the tone of my report not good (if so, how can I improve it)?


Don't set DOTNET_ROOT during build

Summary

As a part of https://github.com/paketo-buildpacks/dotnet-core/issues/722, the .NET Core Runtime buildpack will no longer be needed during build, so there's no need to make the DOTNET_ROOT available at build-time anymore.
Use Cases

Checklist

[X] I have viewed, signed, and submitted the Contributor License Agreement.
[X] I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
[X] I have added an integration test, if necessary.
[X] I have reviewed the styleguide for guidance on my code quality.
[X] I'm happy with the commit history on this PR (I have rebased/squashed as needed).

This should probably get merged in after the related SDK and Publish PRs.


[Bug/漏洞] Crash - Ticking Entity - 1.20.1

Checks / 检查

[X] I confirm that I have searched for existing issues / pull requests before reporting to avoid duplicate reporting./我确认在报告之前我已经搜索了现有的问题或者拉取请求，以避免重复报告。
[X] I confirm that I followed the Docs and read the Changelog, but this problem still exists./我确认我按照文档配置并阅读了Changelog，但这个问题仍然存在。
[X] I confirm that I noted that if I don't follow the instructions, the issue may be closed directly./我确认我已经检查，如果我不按照说明进行操作，该问题可能会被直接关闭。

Java Version / Java版本
17.0.8
Minecraft Version / Minecraft版本
1.20.1
Avaritia-Reforge Version / Avaritia-Reforge版本
<IP_ADDRESS>
Description / 描述
Game crashes on start for some players. Seems similar to https://github.com/Nova-Committee/Re-Avaritia/issues/96#issuecomment-2380839636 apologies if this is a duplicate.
To Reproduce / 重现
Start game, some players will encounter a crash. Due to ticking entity according to crash log. Crash log points to Avaritia as the cause.
Log / 日志
crash-2024-10-13_14.04.46-client.txt
Config / 配置
Default

fixed at <IP_ADDRESS>


[ResolutionRequest] Fix 'isRelativeImport' to allow require('.') and require('..')

@davidaurelio 👍

By analyzing the blame information on this pull request, we identified @davidaurelio to be a potential reviewer.

@facebook-github-bot shipit

Thanks for importing. If you are an FB employee go to Phabricator to review internal test results.

Thanks for importing. If you are a Facebook employee, you can view this diff on Phabricator.


Add "Country_abbrev" to node metadata

When plotting out, it's very helpful to write "UK" rather than "United Kingdom". Can we add a "Country_abbrev" field that shortens at least the names UK and USA? It's tedious to do the replacements every time we want a plot.

I don't think it's worth doing this because we'd have to write a function that'll convert the country code for everything in the metadata, whereas we're likely to only every look at a handful. Adding this key to the metadata in the actual trees that we ship means that we should make it work properly, whereas if we have a quick function that does a mapping for our own viz needs we don't have to worry about quality.
It's hard to overstate the messiness of the metadata here, so it should be approached with great caution!


Add sorting to the timers page

Add sorting to the timers page, same stuff as what's on the modules page

On second thoughts, this seems pointless. Nobody's timer page should be overly big that they can't scroll down a bit.


docs: add Talos to adopters list

Add Talos to Adopters list
Signed-off-by: Noel Georgi<EMAIL_ADDRESS>

CiliumClusterwideNetworkPolicy, Hubble, BPF NodePort - work fine with Talos )


Rethink how offsets in raw data should be handled in the GS-Iterator

At the moment, the aggregation functions handle the offset to adjust reported event relative to the GS that is currently iterated over.
However, this causes issues because within one iteration we might adjust the GS (for example because of #79 ). Maybe we should make this explicit and have a function that a user can use to manually adjust the offsets when reporting values?

Implemented in #135 with the help of subiteration


chg: usr: SDK-283 Added implementation for parameters for commands history api

Approved - apart from minor nit.

Made changes as per Amogh's comments


[SPARK-5373][SQL] Literal in agg grouping expressioons leads to incorrect result

select key, count( * ) from src group by key, 1  will get the wrong answer.
e.g. for this table
  val testData2 =
    TestSQLContext.sparkContext.parallelize(
      TestData2(1, 1) ::
      TestData2(1, 2) ::
      TestData2(2, 1) ::
      TestData2(2, 2) ::
      TestData2(3, 1) ::
      TestData2(3, 2) :: Nil, 2).toSchemaRDD
  testData2.registerTempTable("testData2")

result of SELECT a, count(1) FROM testData2 GROUP BY a, 1  is
                     [1,1]
                     [2,2]
                     [3,1]

Test build #25995 has started for   PR 4169 at commit 05751db.

This patch merges cleanly.

Test build #25995 has finished for   PR 4169 at commit 05751db.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25995/
Test PASSed.

LGTM

It looks to me that using a literal in agg grouping expressions has no effect at all, is this true?
If true, can we just remove literal expression in grouping during analysis instead of changing the aggregate internals?

yes, i think so.


merge upstream changes from v0.13.0

Which brings along a few security patches such as a fix for CVE-2023-49569
I had to resolve a few conflicts in buildpack.toml. I kept all the current changes from 5.4-release although upstream brings in new versions of Python which we will miss out on.
See https://github.com/plotly/paketo-buildpacks_cpython/compare/upstream-1.13.0..paketo-buildpacks:cpython:v1.13.0 for a diff between upstream's v1.13.0 and the content of the current branch.
I published the new image with:
./scripts/package.sh --version 5.4.0b2 --output quay.io/plotly/paketo-buildpacks-cpython:5.4.0b2

same here re: the release branch -- should this be landing against main with the idea being we'd cut the 5.4 release branch when we freeze off of main?

@antoinerg Left a comment around pipCleanup -- Are you able to test this properly on both workspaces and dash apps?
Making sure workspace have all the dependencies installed (pip, apt deps etc.) and predeploy scripts continue to work.

I added this as a TODO in https://github.com/plotly/dek-deployment/pull/3963. Hopefully, I can test this out this afternoon.

I added this as a TODO in plotly/dek-deployment#3963. Hopefully, I can test this out this afternoon.

@tarzzz please see https://github.com/plotly/dek-deployment/pull/3963 for test updates. I provided a cluster where you can login and try to break things!

I think this one is ready for another round of review!

I got an approval over Slack!


improve examples

fix #190, fix #189, fix #186, fix #185, fix #194
This PR synthesizes all suggestions mentioned in these issues.

There's too many "Note" callouts and occurrences of the word "Note" in exposition on the Quick Look page. Callouts have to be used sparingly or they lose their value in drawing the user's attention.

@arkzem1 needs to review

I would be happy to. But is there a way to see the rendered effect of these changes?

Yes, see: https://github.com/CPPAlliance/url/pull/192#issuecomment-1150137625

BTW, as you change the examples, I think there is an error in the third table in section "Accessing", the one below text "To differentiate between empty and absent components, we can use functions such as has_fragment". The source code doesn't have any instruction that would print "has fragment 1".

Amended!

@vinniefalco, @akrzemi1
I guess this is good, right?

I guess this is good, right?

Very good! Thanks.
If I could have a tiny suggestion, this text:

Only std::length_error, when s.size() > url_view::max_size, is reported via exceptions.

It may bee too much details for an intro page. The user will learn it from the synopsis, when they need to.

The URL under std::regular at https://192.url.prtest.cppalliance.org/libs/url/doc/html/url/quick_look.html is wrong.


Some results trained with Adam and AdamW on Librispeech

I use the script (mmi_att_transformer_train.py) as the basic experiment setting and use train-clean-100 as the training data.
I use Adam or AdamW optimizer to replace Noam.
I compare the performance from the three optimizers.
The results are based on different learning rate and decay weight.
All the results are based on single GPU.

OK, thanks.  I guess this confirms that we need the noam-type learning rate scheduler.
At some point I'd like to try something like Adam but with weight decay where it decays to the initial (random) value, not
to 0.

Yes, maybe I can try to set the lr (learning rate) according to the epoch. When the epoch <=5 (or other value), setting the lr=0.0001. And when the epoch >5, setting the lr=0.00001.

Study the Noam optimizer, how it sets the learning rate.
It is just a modification of Adam, to set a certain schedule.
On Tue, Jul 6, 2021 at 4:46 PM Mingshuang Luo @.***>
wrote:

Yes, maybe I can try to set the lr (learning rate) according to the epoch.
When the epoch <=5 (or other value), setting the lr=0.0001. And when the
epoch >5, setting the lr=0.00001.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/k2-fsa/snowfall/issues/228#issuecomment-874578540,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAZFLO536WF6ZRGIUXYEW5LTWK7F3ANCNFSM474ASOPQ
.


Language support issues

Describe the issue:

Following section was not update in my account

How to reproduce:

Login to My account
Change a different language from the right hand side dropdown
Validate the content
Expected behavior:
Content should be fully converted to selected language.

Environment information (Please complete the following information; remove  any unnecessary fields) :

Product Version: [e.g., IS 5.10.0, IS 5.9.0]
OS: [e.g., Windows, Linux, Mac]
Database: [e.g., MySQL, H2]
Userstore: [e.g., LDAP, JDBC]

Optional Fields
Related issues:

Suggested labels:

This is invalid. Hence closing the issue


Add instructions / requirements for better user input handling.

I feel like there's a good opportunity in this lab to talk about gracefully handling user input. We should add some basic instructions / requirements along the lines of handling things like case sensitivity in text fields,  invalid requests, etc.

@kklamberty – the form validation work you've done on Lab 4 (and which should move back to Lab 3) seems to address this to some degree. Do you think that we want/need this here, or is having it come up later OK?

@NicMcPhee - @koran023 , @kklamberty , and I talked about that this term. Perhaps we will include some validation for user input on filters in lab 3. https://github.com/UMM-CSci-3601/3601-lab3_angular-spark/issues/190 . We are still discussing if it would make sense to worry about handling odd data like negative ages since that won't happen except for thing like (maybe) URL hacking once the validation is in place in later work.

@NicMcPhee do you think we should we close this old issue as wontfix?
It seems like it's not something we're planning on adding to this lab. (And for my part, I kind of like the idea of keeping this lab simple/less feature-rich! 🙂)

@helloworld12321 – I have mixed feelings on this. I agree that complicating the labs isn't helpful. On the other it would be a good opportunity to introduce some error handling ideas since that's an area where folks often don't do a great job?

Ah, sounds good! In that case I'm happy to leave it. :)

Just as a note, I did talk a bit in class today about making sensible choices for input that prevent users from searching from things in ways that won't know what they mean (like, freeform typing where you might spell things wrong compared to selecting from a set of feasible options).


Show qr code when deploying

When wanting to check your deployment on a mobile device, it's a bit of pain having to type the address every time. So I thought it'd be nice to have deployments show a QR code which can just be scanned? ¯_(ツ)_/¯
This PR introduces that feature by default. Maybe it'd make more sense as an option with a flag like now --qr? If this is interesting I don't mind tweaking it a bit...

Thanks for the effort you've put into researching this, but I think the project is already way too complex. In turn, I don't think it's good idea to support such an edge case.
I hope you understand that! 😊
We're also planning to introduce plugins, which will allow this.


Allow custom email backends

The current send_email helper uses SMTP, but sometimes it's useful to be able to send mail without SMTP--for example when using API-based services like Sendgrid, Mailgun, etc. It would be useful to include a hook for overriding send_email--maybe a Django-style override like email_backend = path.to.plugin:send_email. If folks would be interested, I'm happy to send in a patch for this.

Seems reasonable. Good call on mimicking the Django approach.


fix(resolver): Add cascading support, which fixes #15

[Current coverage][cc-pull] is 100%

Merging [#17][cc-pull] into [master][cc-base-branch] will not change coverage

@@           master   #17   diff @@
===================================
  Files           1     1
  Lines          21    21
  Methods         0     0
  Messages        0     0
  Branches        0     0
===================================
  Hits           21    21
  Misses          0     0
  Partials        0     0

Powered by Codecov. Last updated by [651f1d0...89e0849][cc-compare]
[cc-base-branch]: https://codecov.io/gh/tleunen/eslint-import-resolver-babel-module-alias/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/tleunen/eslint-import-resolver-babel-module-alias/compare/651f1d0ffe1be290224ab049dbf54b84bd647f24...89e084975aec3aadd95dcc2c30eae245350665be?src=pr
[cc-pull]: https://codecov.io/gh/tleunen/eslint-import-resolver-babel-module-alias/pull/17?src=pr

Thanks @jgkim. Indeed, the search should start from the current file directory.


Update Docs for SAM S3 event generator

Issue #, if available:
None
Description of changes:
The SAM CLI has evolved since these docs were written and the syntax for generating an example s3 file now requires an additional argument. I found it and was able to successfully generate the event templates using the CLI help, so I wanted to help improve the getting started docs
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

SAM related content has moved to the SAM developer guide-
https://docs.aws.amazon.com/serverless-application-model/latest/developerguide/serverless-sam-cli-install.html
Thanks,
-Michael


Verify Code component

we need a new component for verifying codes:
Inputs

sting for label text
number for amount of inputs to render
type for number or text versions
onChange function that returns the values concatenated into a string (empty inputs are ignored)

check list

[ ] Made from NewComp to ensure standardisation
[ ] Has initial, focus, filled states like in design please
[ ] Using modern RTL (see Accordion)
[ ] actions returning the value in Storybook
[ ] killer DX

design

being used in context

Is there figma available?


Add HTTP Route to handle get detail info for consumer

Provide the data for a consumer

Name
Topics
Last Read Data
Queue Status Totals
Consumer Concurrency

Exposed the QDB object and defined the json for it


soft body move with kinematic body will lag behind

Godot version:
3.1 a16d9c6
OS/device including version:
Windows 7
Issue description:
a soft body parent with kinematic body will lag behind parent when parent move

You can see idle in left and moving in right. The distance between the cube and the soft body is different
Steps to reproduce:
make a soft body as child of a kinematic body.
move the kinematic body
Minimal reproduction project:
test_project.zip

Duplicated #21599

.. or #23482? To me it looks like the softbody just doesn't move from the spot it was instanced at, just sinks down..

This is hard to fix without changing the engine, I'm not sure how to fix it

Any workaround available? My character's hair are lagging behind when moving.

update: I applied fix #21599 and it works correctly

It still work in progress, because at that time I saw that a part of the engine must be changed in order to fix it

Is there an update on this case?
Am I correct that at the moment it is not possible to move a soft body, e.g. by moving its parent KinematicBody or RigidBody? Is there a workaround or is it simply impossible to programmatically move SoftBodys ?

Move soft bodies is possible, but in godot there is a problem that makes the softbody to be updated 1 frame later. I should work on this to find a viable solution.

Fixed by #36048


[Engine-1.21] etcd-snapshot loading config fails with "flag provided but not defined"

Backport of https://github.com/k3s-io/k3s/issues/4449

Closing as engine only


Better config directories layout to make synchronisation of data files easy

Hi,
Right now Lagrange on UNIX stores all it's data files in $XDG_CONFIG_DIR/.config/lagrange. I guess this is because it is easier to support macOS and Windows with this layout. However it would be a nice improvement to move some of these data files to ~/.cache/lagrange and ~/.local/share/lagrange for the following reasons:
The fonts directory, the idents directory, idents.lgr and bookmarks.ini could go in ~/.local/share/lagrange. This data can be shared between several computers independently even if those computers have different lagrange settings. But you might also explicitly not want to share this between computers with different operating systems some of which you trust less than others.
State.lgr and visited.2.txt could go in ~/.cache/lagrange so it would be as trivial as rm -rf'ing ~/.cache/lagrange to clean cached data which is easily recreated. This data you often don't want to share between several computers.
The prefs.cfg could be split into two files, with one of them for settings that are machine dependent such as "window.setrect" which is a problem to share between several computers that have different screen sizes such as a laptop with a smaller screen and a desktop with a huge screen.
This would make it easy to synchronize lagrange data files one might need between several computers with tools like rsync/syncthing instead of the various over-engineered syncing solutions for major web browsers that are bolted on top to sort through the disorganized data files.

I like this idea. Splitting the configuration and files into multiple directories based on usage would have some nice benefits indeed. The current implementation is mostly for simplicity: there's just one directory to manage instead of multiple different ones.
This doesn't have to be XDG-specific, though. macOS has comparable directories like ~/Library/Caches/ and ~/Library/Preferences/ where some of the data could be placed. Windows has the Roaming and Local AppData directories, for example.
Migrating to a new runtime directory layout will require some careful management, though, and will likely not allow sharing data with earlier versions of the app.

It's definitely not a set of changes to rush into. It takes a bit of thought to figure out a good layout for the data files that would be future proof. I just thought I'd share this idea I had yesterday while setting up lagrange on a laptop. I sync all my config files with syncthing and I didn't run into any other problems so far except for the window.setrect setting.

Something to consider: the export/import feature in v1.12 could be leveraged to build an automated sync mechanism.


how about generate the label heatmap in the 384x288 resolution and resize the label to 96x72?

Hi,
I find that you generate the label heatmap in  92x72 resolution, so the [int(x/4.),[int(y/4.)]] was the center to generate Gaussian Blur. But it seems may cause  mismatch with the original coordinate.e.g.int(17/4)=4,but 4*4=16. So I wonder could I generate the label heatmap in 384x288 resolution and resize it to 96x72? This method would be much slower than your implement but more accuracy?
Thanks in advance!

Anyway, it's a bug I've known. That maybe causing 4-pixel error in the highest point. But I don't think it seriously because some post-processing operations might relieve the problem. I've just implemented the code (models/COCO.res50.256x192.CPN.finerlabel) quickly following your thinking in branch dev and do the experiment. You're welcome to check the code. I'll later report the result.

How about adding an regression layer to learn the offset, like the Region Proposal Network?(Faster RCNN).

It seems that CNN is good at classification rather than regression in general. Adding regression to reduce error may helps a little more but it requires proper design of code implementation.

The performance of finer label is same as the original. I think it may be because

there exists other coordinate misaligned problem in code.
post processing relieved the problem of 4-pixel error.
COCO evaluation tools are not sensitive to this small error. ( exp(-x) )
But I think it actually helps (+ >0.0) if the implementation is completely right. it's a pity...

get It. Thanks for your nice feedback

Hi! I am interested in this issue. Could you please list some high-level summaries of the post-processing step? Or, is there some papers or blogs describing similar post-processing step?

@kaleidoscopical These testing tricks are listed in experiments section in our paper.


KAFKA-13881: Add Connect package infos

Signed-off-by: Greg Harris<EMAIL_ADDRESS>Split off from #12895 to target only Connect packages.
There are currently no descriptions of packages in the javadocs, which can be intimidating to new users that look at the documentation and see a wall of raw package names. An example of this can be seen here: https://kafka.apache.org/31/javadoc/
This change adds the following package descriptions based on a best-effort reading of the existing javadocs. Please feel free to correct any factual errors in the proposed descriptions, I am not asserting that these descriptions are currently accurate. This PR only covers the connect packages.
For clarity of review, I'll summarize the new descriptions in a table. This summary may become stale by accident, so please be sure to view the diff itself or build the changes locally with ./gradlew javadoc.

Package
Description

org.apache.kafka.connect.components
Provides common interfaces used to describe pluggable components.

org.apache.kafka.connect.connector
Provides pluggable interfaces for Connector and Task implementations.

org.apache.kafka.connect.connector.policy
Provides pluggable interfaces for connector security policies.

org.apache.kafka.connect.data
Provides classes for representing data and schemas handled by Connect.

org.apache.kafka.connect.errors
Provides common exception classes for Connect.

org.apache.kafka.connect.header
Provides API for application-defined metadata attached to Connect records.

org.apache.kafka.connect.health
Provides interface for describing the state of a running Connect cluster.

org.apache.kafka.connect.rest
Provides pluggable interface for altering the behavior of the Connect REST API.

org.apache.kafka.connect.sink
Provides API for implementing connectors which write Kafka records to external applications.

org.apache.kafka.connect.source
Provides API for implementing connectors which read data from external applications into Kafka.

org.apache.kafka.connect.storage
Provides pluggable interfaces and some implementations for (de)serializing data to and from Kafka

org.apache.kafka.connect.transforms
Provides pluggable interface for altering data which is being moved by Connect.

org.apache.kafka.connect.transforms.predicates
Provides pluggable interface for describing when a Transformation should be applied to a record.

org.apache.kafka.connect.util
Provides common utilities that can be used in component implementations.

Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

@C0urante Could you take a look at this? TIA!

Thanks for improving the javadocs!

Cherry-picked to 3.4 branch.


[CI] Add llvm-15 and mlir-15 to Docker setup

Add llvm-15 and mlir-15 for CPU docker image for RFC: Introduce PresburgerSet

@tvm-bot re-run

I feel it is still helpful to be able to rely on the official apt for some, mainly because most people do not have the capacity necessarily build LLVM from scratch.

I feel it is still helpful to be able to rely on the official apt for some(wasn't aware of the source change).
This is mainly because most people do not have the capacity necessarily build LLVM from scratch and being able to rely on official ones helps to reduce that burden.

I agree. I think the problem goes away in newer versions of Ubuntu according to apt.llvm.org. Once we update Ubuntu in our CI, I think we should go with packages as we always did, for now I'd recommend building it from source.

opened a related thread here https://discuss.tvm.apache.org/t/discuss-upgrade-overall-ci-dependency/14531

Thanks for the discussion, following the discussion mentioned above, would be worth installing LLVM15 from source in the meantime while the prerequisite upgrades are carried out?

Hi. Friendly nudge so that we can take a decision on how to proceed here. I'd suggest that we build LLVM 15 from source, similar to what is being done in ci_arm for now. Once we move to Ubuntu 22, then we can just go back to the APT repository, mostly because of the global libc++ change which might affect all other builds we do.
If we agree on this strategy, we have the option to change this PR or submitting a new one with LLVM build from source, which is equally simple as a PR. Happy to help.
@lhutton1 @multiverstack-intellif @tqchen what do you think?

Hi. Friendly nudge so that we can take a decision on how to proceed here. I'd suggest that we build LLVM 15 from source, similar to what is being done in ci_arm for now. Once we move to Ubuntu 22, then we can just go back to the APT repository, mostly because of the global libc++ change which might affect all other builds we do.
If we agree on this strategy, we have the option to change this PR or submitting a new one with LLVM build from source, which is equally simple as a PR. Happy to help.
@lhutton1 @multiverstack-intellif @tqchen what do you think?

I think building from source is a good temporary solution for this, since the overall upgrade may take weeks or even months to get done. I'll change the PR accordingly and ask for another review if no objection.

happy to go with what @multiverstack-intellif you think is convenient

@leandron I'm asking just in case you may know. The change is merged, but I only found image tlcpackstaging/ci_cpu in daily docker build(https://ci.tlcpack.ai/job/docker-images-ci/job/daily-docker-image-rebuild/). Do you have any idea how tlcpack/ci_cpu is built? Tag of tlcpack/ci_cpu is expected to be finally used, right? Thanks very much!

Hi @multiverstack-intellif, you should be able to post a PR with the tlcpackstaging image tag but under the tlcpack account, see https://tvm.apache.org/docs/contribute/ci.html#updating-a-docker-image-tag


Make table_format shading toggle

Currently turns on automatically when nrow(df) > 4

Changed to logical shade argument


Libraries

This branch introduces libraries which can be used in recipes for
installing and configuring Varnish. The libraries are tested on CentOS
6.5, 7.0, and Ubuntu 14.04, with apt, yum, and vendor-cache
packages. None of the existing recipes or attributes have been altered,
so consumers of the cookbook will have a choice on whether or not to use
the cookbook recipes, or the libraries. There are examples in the
fixtures directory on how to use the resources in your recipes, and
documentation in the README has been updated.
In addition, a cloud task has been added to the Rakefile to allow
overriding of Test Kitchen variables. A module was written that detects
the version of Varnish that is running, and Serverspec syntax was
updated on the existing varnish3 and varnish4 spec_helpers.

LGTM.

Should we rewrite the default recipe so it uses the libraries? The usage will not be different (same attributes/ same behavior) but it will consume libraries. The final step will be to remove recipes :-)

Yes, I think this should be done before publishing.  Next publish will be a major bump.  The one after that (Major) will remove the recipes.

Should we rewrite the default recipe so it uses the libraries?

:+1: this would be great.


Storage: possible data corruption if a HTTP/2 streaming error occurs while an object is changed

See the comment on https://code-review.googlesource.com/c/gocloud/+/25630

Copying the comment from the CL:

There looks like a bug here. The retry calls to reopen() don't include the generation number from the headers of the first response. If a new generation of the object is uploaded between the first call and the retry we'll end up concatenating data from two different generations. I haven't experienced this - I was looking at the code and noticed it.

Actually, if a specific generation number is set, a generation=N query parameter will be the URL of all requests, so that case is OK.
The problem is when you don't specify a generation number. Unfortunately, I don't think GCS returns a generation number in the response. But it does return an Etag header, and we should be able to use that in an If-Match header in subsequent requests.
Reference: https://cloud.google.com/storage/docs/xml-api/get-object-download.

The generation is returned in a header from GCS:
X-Goog-Generation:[123455]
X-Goog-Metageneration:[1]

https://cloud.google.com/storage/docs/xml-api/reference-headers#xgooggeneration

https://code-review.googlesource.com/c/gocloud/+/31950


Implementation of non QML launcher

Changes

Added new tool "launcher" to pype.tools which is not QML base

based on BigRoy's launcher draft

Launcher's context is out of avalon.io.Session so we don't have to care about unexpected context changes
Launching of application should be the same as from Ftrack (except triggering timer)

extracted launch_application function from ftrack to pype.lib

TODOs

Action launch error handling
Trigger timer on app launch

:black_flag:
this depends on

pype-config
https://github.com/pypeclub/pype-config/pull/75

avalon-core
https://github.com/pypeclub/avalon-core/pull/177

Note
I think we can remove avalon-launcher repo.

Nice to see this being adopted by pype. Hope it's usable on your end. :) Any clients using this?


Add syntax highlighting to Clojure documentation codeblocks

Add syntax highlighting to codeblocks from Clojure documentation when viewed in IntelliJ's documentation window, improving readability and comprehension within the docs code.
Solves issue: https://github.com/clojure-lsp/clojure-lsp-intellij/issues/38
Key changes:

Upgraded markdown-clj to version 1.12.1, which introduces the :codeblock-callback argument that enables the integration of a callback function to parse codeblocks from the documentation markdown, facilitating the addition of a highlight function

markdown-clj documentation regarding codeblock callbacks

Implemented the use of SyntaxHighlighter and Lexer to traverse through code tokens extracted from the codeblocks. Additionally, utilized EditorColorsScheme to obtain font color, background color, and font style attributes (bold and italic).

The code walking process is managed through .start and .advance methods from lexer, handling each code token such as parentheses ( ), defn, variable names, etc.

Based on the extracted token attributes, encapsulate each token within an HTML <span> element, applying inline styles to mimic the desired syntax highlighting effect translating the token attributes to CSS.

How to test:
Run plugin, install a theme or use a default one and try out.
Preview:
Using theme "One Dark Vivid Italic", before/after:

@ericdallo Suggestions applied! Thanks a lot.
Also added the CHANGELOG in the unreleased section, that's correct? Let me know if we need anything else.

It looks and works great! Thank you for your first contribution!


add $APX logos

Please review the following token assets:
📑 Description

Token Name: AstroPepeX
Project Website: https://astropepe.io
Explorer URI: https://basescan.org/address/0xcacf1ca03983CE6c7E235fb20C70aCC70ed13509

✅ Checks

[ ] I created a new folder with the token address, all in lowercase
[ ] I added the token's logo as a 32x32 PNG file, named logo-32.png
[ ] I added the token's logo as a 128x128 PNG file, named logo-128.png
[ ] I added the token's logo as a SVG file, named logo.svg
[ ] My SVG logo is a proper SVG and not some base64 stuff
[ ] My documentation/website clearly display the token address somewhere

the SVG in this PR isn't a true SVG, it contains base64 encoded elements. Can you try converting your logo PNG using this tool and edit this PR
https://convertio.co/image-converter/


RFC: API Change: dma: callback status

Introduction
Provide contextual information in the DMA callback.
Problem description
DMA API allows for one callback, with one success status (0), even though there might be more than one DMA event/interrupt.
Proposed change
The current callback can be leveraged without modifying its signature to pass more information into the status parameter:
typedef void (*dma_callback_t)(const struct device *dev, void *user_data,
			       uint32_t channel, int status);

Detailed RFC
The DMA driver has the ability to configure one callback called whenever a DMA transfer is completed. Below is the current description for this callback which is set when configuring the DMA device (see struct dma_config):
/**
 * @typedef dma_callback_t
 * @brief Callback function for DMA transfer completion
 *
 *  If enabled, callback function will be invoked at transfer completion
 *  or when error happens.
 *
 * @param dev Pointer to the DMA device calling the callback.
 * @param user_data A pointer to some user data or NULL
 * @param channel The channel number
 * @param status 0 on success, a negative errno otherwise
 */
typedef void (*dma_callback_t)(const struct device *dev, void *user_data,
			       uint32_t channel, int status);

Usage of DMA on different microcontrollers might differ. For example, most STM32 microcontrollers have two interrupts: one for half complete, and one for fully complete transfer. It might be needed to call the DMA callback for both of these interrupts and the user of the DMA device might need to be informed about which interrupt occurred. It is not possible at this point to pass this kind of information using the current API description: 0 on success meaning when DMA transfer completes.
The dma_get_status() function could be used to guess which interrupt occurred but the current status of DMA might have changed by the time the user calls the dma_get_status() function (it happened to me when working on https://github.com/zephyrproject-rtos/zephyr/pull/51795) and we might want to process the buffers differently depending on the source of the interrupt, not the current status.
Proposed change (Detailed)
Change the dma_callback_t description so that any positive status gives information about the source of the interrupt, which might differ depending on the platform: STM32 might use 2 status codes for fully and half complete while other platforms might use only 1 status code.
Pull Request #52780
Dependencies
Several Zephyr drivers are using the DMA API (I2S, UART, SPI) as well as some tests and it is also possible that Zephyr users use the DMA driver directly in their source code.
Alternatives
Store several callbacks, one for each interrupt sources in the platform-dependent implementation, like done in dma_dw_common.h:
struct dw_dma_chan_data {
        // ...
	dma_callback_t dma_blkcallback; // block complete callback
	void *blkuser_data;
	dma_callback_t dma_tfrcallback; // transfer complete callback
	void *tfruser_data;
}

I don't think this is a bad idea and actually stumbled upon this implementation while writing this issue. It has the advantage of having one user data pointer per callback instead of one for all the interrupt sources.
Let me know if you have preferences.

Also worth mentioning #37372 which proposes to use an enum to give the status, which would be shared across all the DMA implementations

I dived a bit more into it and the dma.h struct dma_config only has one callback used when configuring a DMA device so I don't think it's that easy to store several callbacks. It would involve calling the .config function of struct dma_driver_api with several parameters to configure the DMA clients differently depending on struct dma_config...
I think the idea of having a negative status for errors and any positive value for status about a DMA interrupt is the best option.
cc @teburd let me know what you think, I can submit a PR to change the DMA API description and status handling (make sure status < 0 for error instead of status != 0.

I'd say send a PR, I'm ok with updating the status to indicate more information than error or success.
For the circular modes this makes good sense. This change will require some careful review though of the code base to ensure status != 0 isn't being used to check for the error case. While not exactly breaking the API, it is changing expectations of how the API works. So in that regard we may need to ensure broadcast this change in a few places. I need to review the projects requirements around stable API changes and if this would constitute one.

Please change the issue title to one similar to the stable API change RFC title noted here, https://docs.zephyrproject.org/latest/develop/api/api_lifecycle.html#introducing-incompatible-changes and make sure all the fields are here (I believe they are).

@teburd I just modified the issue so that it can be treated as an RFC

Thanks @erwango was out for the holidays

@teburd any change to see this discussed in the weekly meeting?

Architecture WG: Some agreement, some request for more design on possible use cases beyond this STM32 part's half-full/full behavior.

For the https://github.com/zephyrproject-rtos/zephyr/pull/51795 is a change in the status really needed?  If I'm understanding the code change there is more about if the callback is a cyclic callback or not.  Can't that be determined in the callback in the uart based on how cyclic got configured?

@galak
Passing the status from the DMA callback is desired because dma_get_status() provides status of a the DMA peripheral that might have changed since the interrupt fired.
Let's say we are receiving data into a RX buffer that gets full but the status shows a write index at the beginning of the RX buffer like at index 1 for example (data wrapped around). As we keep track of the last write index into the DMA buffer between interrupts, we can correctly use the data from the buffer but because the UART API expects a continuous chunk of memory (see API definition below), we then need to call the UART callback twice (see uart_callback_t), instead of once, because the write index made progress, even though we are not done receiving UART data (idle interrupt didn't fire).
/**
 * @brief UART RX event data.
 *
 * The data represented by the event is stored in rx.buf[rx.offset] to
 * rx.buf[rx.offset+rx.len].  That is, the length is relative to the offset.
 */
struct uart_event_rx {
	/** @brief Pointer to current buffer. */
	uint8_t *buf;
	/** @brief Currently received data offset in bytes. */
	size_t offset;
	/** @brief Number of new bytes received. */
	size_t len;
};

Here is a piece of logs from my running example. My buffer is 2048-byte long, and the message is 688-byte long.
The first line will lead to 2 calls to the UART callback: one for data from index 1729 to 2048 and one from 0 to 1, instead of 1 call if we use information from the DMA module that the buffer is full.
2023-02-01 11:18:15.373 [00:03:35.665,000] <dbg> uart_stm32: async_evt_rx_rdy: rx_rdy: (1729 1)
2023-02-01 11:18:15.381 [00:03:35.668,000] <dbg> uart_stm32: async_evt_rx_rdy: rx_rdy: (1 369)

Because we know the interrupt reason from the DMA module, I thought it would be more efficient to directly use this piece of information and pass it to the DMA user, in this case the UART module.
I made a running example this morning that doesn't involve DMA API modifications and can probably open a new PR with theses changes.

@galak please take a look, thanks!

We should make the return code well defined.  So 0 means DMA complete, and 1 means circular water mark complete.

@erwango @fouge please see the response here from Kumar, does this make sense? Effectively the request is the status values need to be well defined for the success cases. 0 being "transfer complete" and 1 being "watermark complete". In the case of st's circular dma setup 1 would imply the half full (watermark) completion event.
This could be useful as well for other DMAs that implement circular buffers with potentially configurable/fixed watermarks.
Thanks!

Hey
if you look at my UART implementation, I actually use 3 different statuses in case DMA times out. In this case, the dma_get_status function is used, see here.

Hey if you look at my UART implementation, I actually use 3 different statuses in case DMA times out. In this case, the dma_get_status function is used, see here.

I only see the one added status code here https://github.com/zephyrproject-rtos/zephyr/pull/51795/files#diff-14bcedc892b7643865d068e532c3dab525465a9814a505eba6724db5026028b7R122

@teburd Indeed you're right, the other status code is only used internally in uart_stm32.c level so I guess the API can be changed with these 2 status code.
I will send an updated PR next week


Storybook test coverage

Hi there,
You extracted storybook into a separate folder (which I am also trying to do). I have it fully working except for the coverage add-on. Were you able to get that working? It was working for me if storybook is in the same package.json as the app, but not if it is extracted.
Any help would be greatly appreciated.
Thanks!

Hello, I'm not using the plugin, so I can't comment on that. However, I'm playing with a migration to Storybook Vite from time to time, and the last time I've looked several weeks ago the separate folder was also a blocker. I find the current separation important due to the amount of additional dependencies that are being installed, especially around webpack. Developers who are not interested in Storybook benefit from fewer dependencies = smaller node_modules and faster installation time. However, with Vite being used for both the app and Storybook, I might reconsider and move the Storybook folder back into the app.


The gpu memory increases rapidly when using executor reshape function.

Hi,
I tried to use "reshape" of executor to dynamically change the input size. Then I found the memory increases rapidly and becomes out of memory after some iterations. I use the following code to reproduce this problem:
import mxnet as mx
import random
input_data = mx.symbol.Variable(name="data")
conv1 = mx.symbol.Convolution(data=input_data, kernel=(11, 11), stride=(4, 4), num_filter=200)

e = conv1.simple_bind(ctx=mx.gpu(0),
                   grad_req="write",
                   data=(1, 3, 600, 600))
for i in range(1000):
    temp_shape = (1,3, random.randint(600, 700),random.randint(600, 700))
    e = e.reshape(allow_up_sizing=True, partial_shaping=True, data=temp_shape)
    e.forward(is_train=True)

My gpu has 4g memory. As far as I can tell, this cannot exceed the limit. The reality is I got out of memory error very soon. @tqchen @piiswrong

add e.outputs[0].wait_to_read() after forward

@tqchen We get this kind of issues every week. Maybe add a limit to how many forward can be pushed to engine?

A better documentation might be a better way to address this, limiting queues in engine by blocking will bring extra complexity to it

@ascust If you add e.output[0].copyto(mx.cpu()).asnumpy() which will be needed when you really copy data out, that will impose a synchronization as well so wait_to_read is not needed

@piiswrong @tqchen Thanks for your replies. i tried both your suggestions and the issue remains. I found that if I use another gpu with 6 GB memory, there is no out of memory because the maximum gpu memory usage is about 4.2 GB, which is sufficient for this card but not for my previous one. What is interesting is that why it takes so much memory to reshape if the new executor shares the memory with the old one?
If I change the shape to a fixed one instead of random one like this:
temp_shape = (1,3, 700,700)

there is no problem, even without wait_to_read or copyto. The memory usage is only 180 MB. I guess there should be some extra memory usage during the allocation of the new shaped arguments, but 180 MB compared with 4.2 GB seems a little big difference.
This only happens when I frequently change the input size. Any help would be really appreciated.

try to avoid allow_up_sizing and always allocate the largest executor

The problem is I am trying to train a network with various input size. I do not know in advance what size the input has and it would be not a good choice to sort the data based on their size and do the training using this order. Would it be possible to change the input size arbitrarily with not that much extra memory cost? I mean would it be possible to recycle the some cach memory more efficiently?

Stop sending me emails or I will report youSent from my Huawei Mobile-------- Original Message --------Subject: Re: [dmlc/mxnet] The gpu memory increases rapidly when using executor reshape function. (#2232)From: Tianqi Chen To: dmlc/mxnet CC: @ascust If you add e.output[0].copyto(mx.cpu()).asnumpy() which will be needed when you really copy data out, that will impose a synchronization as well so wait_to_read is not needed
—You are receiving this because you are subscribed to this thread.Reply to this email directly or view it on GitHub

you can bind with the maximum size that fit in the memory and you won't need allow_up_sizing

Alright, I tried this and it worked. This is clever. Thanks guys.

It seems if the network has more complex structures, it becomes not that stable. Here I use the residual structure from "example" folder. I changed number of filters for each group to increase the capcity of the network. and I also remove the alst fc and pooling layer to allow different input shapes. If I bind the network with say data = (1, 3, 1000, 1000), the memory usage is around 1533MB when the input size is fixed. If I bind the network with this maximum input size and reshape it using different smaller sizes, I will get out of memory soon. I have only 4GB gpu memory. The problem seems that the new executor does not really share the memory with the old one.
I have pasted code here, please have a look. @piiswrong @tqchen
import mxnet as mx

def conv_factory(data, num_filter, kernel, stride, pad, act_type='relu', conv_type=0):
    if conv_type == 0:
        conv = mx.symbol.Convolution(data=data, num_filter=num_filter, kernel=kernel, stride=stride, pad=pad)
        bn = mx.symbol.BatchNorm(data=conv)
        act = mx.symbol.Activation(data=bn, act_type=act_type)
        return act
    elif conv_type == 1:
        conv = mx.symbol.Convolution(data=data, num_filter=num_filter, kernel=kernel, stride=stride, pad=pad)
        bn = mx.symbol.BatchNorm(data=conv)
        return bn

def residual_factory(data, num_filter, dim_match):
    if dim_match == True:  # if dimension match
        identity_data = data
        conv1 = conv_factory(data=data, num_filter=num_filter, kernel=(3, 3), stride=(1, 1), pad=(1, 1),
                             act_type='relu', conv_type=0)

        conv2 = conv_factory(data=conv1, num_filter=num_filter, kernel=(3, 3), stride=(1, 1), pad=(1, 1), conv_type=1)
        new_data = identity_data + conv2
        act = mx.symbol.Activation(data=new_data, act_type='relu')
        return act
    else:
        conv1 = conv_factory(data=data, num_filter=num_filter, kernel=(3, 3), stride=(2, 2), pad=(1, 1),
                             act_type='relu', conv_type=0)
        conv2 = conv_factory(data=conv1, num_filter=num_filter, kernel=(3, 3), stride=(1, 1), pad=(1, 1), conv_type=1)

        # adopt project method in the paper when dimension increased
        project_data = conv_factory(data=data, num_filter=num_filter, kernel=(1, 1), stride=(2, 2), pad=(0, 0),
                                    conv_type=1)
        new_data = project_data + conv2
        act = mx.symbol.Activation(data=new_data, act_type='relu')
        return act

def residual_net(data, n):
    # fisrt 2n layers
    for i in range(n):
        data = residual_factory(data=data, num_filter=64, dim_match=True)

    # second 2n layers
    for i in range(n):
        if i == 0:
            data = residual_factory(data=data, num_filter=128, dim_match=False)
        else:
            data = residual_factory(data=data, num_filter=128, dim_match=True)

    # third 2n layers
    for i in range(n):
        if i == 0:
            data = residual_factory(data=data, num_filter=256, dim_match=False)
        else:
            data = residual_factory(data=data, num_filter=256, dim_match=True)

    return data

def get_symbol(num_classes=10):
    conv = conv_factory(data=mx.symbol.Variable(name='data'), num_filter=64, kernel=(3, 3), stride=(1, 1), pad=(1, 1),
                        act_type='relu', conv_type=0)
    n = 3  # set n = 3 means get a model with 3*6+2=20 layers, set n = 9 means 9*6+2=56 layers
    resnet = residual_net(conv, n)  #
    return resnet

net = get_symbol()

e = net.simple_bind(ctx=mx.gpu(0),
                    grad_req="null",
                    data=(1, 3, 1000, 1000))
import random
for i in range(1000):
    temp_shape = (1, 3, random.randint(600, 900), random.randint(600, 900))
    e_t = e.reshape(data=temp_shape)
    e_t.forward(is_train=False)
    output = e_t.outputs[0].copyto(mx.cpu()).asnumpy()

@ascust I've run the code locally and have not experienced the OOM problem. The memory usage is around 1400MB. I'm using Windows 10 + GTX 980 Ti + Cuda 8.0

Ok Thanks for your reply. I found the problem might be this as shown below. Please try the below code, where there is only one conv layer with big dilation and num_filter. Normally, if I fix the input size, it uses only 800 MB memory, but if I vary the input size, more than 4000 MB will be used. There seems a lot of memory that could be squeezed. @sxjscience
Try this out:
net = mx.symbol.Convolution(data=mx.symbol.Variable(name='data'), kernel=(3,3),pad=(12,12), num_filter=150, dilate=(12,12), workspace=2048)

e = net.simple_bind(ctx=mx.gpu(0),
                    grad_req="null",
                    data=(1, 2048, 80, 80))
import random
for i in range(1000):
    temp_shape = (1, 2048, random.randint(50, 80), random.randint(50, 80))
    e_t = e.reshape(data=temp_shape)
    e_t.forward(is_train=False)
    output = e_t.outputs[0].copyto(mx.cpu()).asnumpy()

@piiswrong @tqchen any thoughts guys? is that because the previous memory did not get released instantly? Just out of curiosity, since the new executor would share the memory, how come this could happen?

I have made some tests for different dilation size and I found if dilation!=1, this question seemed to be very obvious. The table below shows the gpu memory for different dilation size with or without reshape (means fixed input size or various input size). We can see that when dilation=1, everything is very normal, but when it is equal to 2, there is a big memory usage, for various input size. fixed size has a big increase as well but not that significant. Then with the dilation size increases, the memory usage seems to drop.
The code I used to make the test was just my previous reply. Is this normal? Is there supposed to be big memory usage when dilation is bigger than 1? @piiswrong @tqchen

When dilation > 1 we use mxnet's own conv layer instead of cudnn because it
doesn't support dilation.
Could you try turn off cudnn and see if dilation still has this effect?
On Mon, Aug 8, 2016 at 10:42 PM, AsCu<EMAIL_ADDRESS>wrote:

[image: screen shot 2016-08-09 at 3 06 04 pm]
https://cloud.githubusercontent.com/assets/12552820/17505798/cf5a4832-5e42-11e6-9837-c0690587c71f.png
I have made some tests for different dilation size and I found if
dilation!=1, this question seemed to be very obvious. The table below shows
the gpu memory for different dilation size with or without reshape (means
fixed input size or various input size). We can see that when dilation=1,
everything is very normal, but when it is equal to 2, there is a big memory
usage, for various input size. fixed size has a big increase as well but
not that significant. Then with the dilation size increases, the memory
usage seems to drop.
The code I used to make the test was just my previous reply. Is this
normal? Is there supposed to be big memory usage when dilation is bigger
than 1? @piiswrong https://github.com/piiswrong @tqchen
https://github.com/tqchen
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/dmlc/mxnet/issues/2232#issuecomment-238458957, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAiudCR_9uIqlTzpYU_-wjwntTvSQtmmks5qeBNZgaJpZM4ImGM8
.

@piiswrong Without using Cudnn, this effect still exists. For example, using dilation=12, fixed input size uses 600MB, while various input size has more than 4GB usage, since my 4GB gpu is out of memory. More importantly, this time, even with dilation=1, the system got out of memory when there is various input size since cudnn is disabled.

Are you using current master? https://github.com/dmlc/mxnet/pull/2927 should fix this problem

@piiswrong I just updated mxnet to the lastest one and I dont think the issues has been fixed. Nevertheless, it seems the issue has been mitigated but still obvious. For example, with cudnn, if I use dilate=12, with fixed input size=(1,2048,80,80), the memory usage is around 600MB. However if I used reshape to get a new shared-weights executor with a new input size(even though the new size is equal to the previous one), the memory usage increased to 1800MB (three times). I have tried using other dilate values, I observed at lease 2 times bigger of memory usage.

@piiswrong @tqchen I am using various input for inference, so it is important to have a relatively stable memory usage. Is there any way of fixing this kind of issue?

This issue is closed due to lack of activity in the last 90 days. Feel free to reopen if this is still an active issue. Thanks!


Change npm dependencies to devDependencies

These NPM dependencies are getting pulled in with lein-npm for projects that use re-frame-http-fx and lein-npm, but they should be marked as devDependencies just like the change in re-frame itself (https://github.com/Day8/re-frame/commit/79a1ea6851382f9c113271addaf63e11155d5aa0).

Good catch, thanks!

I've just released 0.1.6 which includes this fix.


How to export my mind map to png?

How to export my mind map to png?
sometimes png is useful when pasting it on figma canvas

How？

You can do that with this Obsidian plugin.
https://github.com/verocloud/obsidian-mindmap-nextgen

You can do that with this Obsidian plugin. https://github.com/verocloud/obsidian-mindmap-nextgen

but I still don't know how to do in markmap 😅.

As a workaround, You can export high definition pngs if you use Firefox.
In order to do so:

Position your mind map so that it can be fully shown in the browser window
Ctrl+Shift+K to pull up the debug console
Enter :screenshot --dpr 4 --fullpage to take a high-definition screenshot
if the text in the resulting image is blurry, change the 4 after --dpr to a higher value.

https://github.com/JuanIrache/d3-svg-to-png
svg2png('#mindmap-graph', 'svg-to-png-q-default', { scale: 3, format: 'png', background: 'white' })


[Bug] fern-generate --docs --preview output shows production url

Describe the bug
When running fern generate --docs --preview, the URL shown while waiting for generation shows the production site instead of the preview, and the final output line also shows the production URL:

To reproduce
Steps to reproduce the behavior:
Run the command with any site.
Expected behavior
The URL shown during and after generation should reflect the preview site.
Version
Fern Version: 0.17.8

Closing - tracking internally.


Fix second_to_last_weekday_of_month test

The rrule
DTSTART;TZID=America/New_York:19970929T090000
RRULE:FREQ=MONTHLY;BYDAY=MO,TU,WE,TH,FR;BYSETPOS=-2

is incorrectly validated or/and produces incorrect results.
Expected:
"1997-09-29T09:00:00-05:00",
"1997-10-30T09:00:00-05:00",
"1997-11-27T09:00:00-05:00",
"1997-12-30T09:00:00-05:00",
"1998-01-29T09:00:00-05:00",
"1998-02-26T09:00:00-05:00",
"1998-03-30T09:00:00-05:00",

Current result (incorrect):
"1997-10-29T09:00:00-05:00",
"1997-11-26T09:00:00-05:00",
"1997-12-29T09:00:00-05:00",
"1998-01-28T09:00:00-05:00",
"1998-02-25T09:00:00-05:00",
"1998-03-29T09:00:00-05:00",
"1998-04-28T09:00:00-04:00",

See test: second_to_last_weekday_of_month
Test source: https://icalendar.org/iCalendar-RFC-5545/3-8-5-3-recurrence-rule.html

I started digging in a little bit now and found that changing this line from:
from_ordinal(ii.year_ordinal().unwrap() + i as i64, tz); to from_ordinal(ii.year_ordinal().unwrap() + i as i64, &UTC); produces the correct values except that it does not produce the first occurrence if it is equal to DTSTART.
The same thing happens with #33 so I think they are the same bug and one of them can be closed.


MongoDB samples

I think it would be useful to have examples of using mongodb api with the popular drivers and also cosmosdb sdk latest version. Setup indexes CRUD operations  queries and agregation if supported !
Describe the solution you'd like
One csproj for each driver usage and in each one of them with classes for each use cases.

Hi @vpaulino ,
I think there is some confusion around the way Cosmos DB works. The Azure Cosmos MongoDB accounts use the Mongo driver. This repo is only for the .NET  SQL SDK which only works for the Cosmos DB SQL accounts.

Did not realized it was only about sql. I have asked this because i have observed diferent behaviour on the mongodb driver when comunicating with cosmosdb vs a real mongodb database.

The examples could be use to show that all features are compatible using the .net mongodb driver against mongodb database and cosmosdb.


Implement improved Product Page and essential modules

Who for

As an user, I want to have the feeling of learning something new when viewing the product page (eg something I couldn't have guessed easily)

What

[x] #542
[x] Implement the decided list of knowledge modules

[x] KP1
[x] KP2
[x] …

[x] Ensure the framework is future-proof and scalable for the next modules

Blocked on

[x] #496

@jasmeet0817 congratulations on solving this one.
Closing


Added changes to archiver to add domain Tag

What changed?
Added changes to archiver to add domain Tag

Why?
To create metrics with Domain Tag for Domain Cost Attribution

How did you test it?
Tested locally and added mocks as well.

Potential risks
No potential risks

Release notes
N/A

Documentation Changes
N/A

Pull Request Test Coverage Report for Build 0182a897-b22b-48c5-b10d-271d3b4a3240

15 of 16 (93.75%)  changed or added relevant lines in 1 file are covered.
202 unchanged lines in 18 files lost coverage.
Overall coverage decreased (-0.1%) to 57.648%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

service/worker/archiver/client.go
15
16
93.75%

Files with Coverage Reduction
New Missed Lines
%

common/types/shared.go
1
41.63%

common/persistence/sql/sqlExecutionStore.go
2
62.21%

common/task/weightedRoundRobinTaskScheduler.go
2
88.6%

service/history/execution/mutable_state_builder.go
2
69.03%

service/history/task/transfer_active_task_executor.go
2
71.51%

service/matching/matcher.go
2
91.46%

common/types/mapper/thrift/shared.go
4
63.12%

service/history/task/fetcher.go
4
91.24%

service/matching/taskListManager.go
5
76.37%

service/history/task/transfer_standby_task_executor.go
8
86.68%

Totals

Change from base Build 0182a7d2-95cd-4c18-882a-e8774ca9aec8:
-0.1%

Covered Lines:
84007

Relevant Lines:
145725

💛  - Coveralls


Links to Download Models No Longer Work

The links to download models now direct to github 404.
# Download small model
curl -L 'https://github.com/imgly/background-removal-js/raw/main/bundle/models/small' -o 'assets/small.onnx'

# Download medium model
curl -L 'https://github.com/imgly/background-removal-js/raw/main/bundle/models/medium' -o 'assets/medium.onnx'

# Download large model
curl -L 'https://github.com/imgly/background-removal-js/raw/main/bundle/models/large' -o 'assets/large.onnx'

<-non of the above links work; you may check it yourself i.e. "https://github.com/imgly/background-removal-js/raw/main/bundle/models/large"

Thanks, I updated the links.


 This is bad practice, if you don't expect exceptions, just rethrow all exceptions as RuntimeException but don't ignore them.

You're right, thanks!
That must be this line: https://github.com/delight-im/Android-Languages/blob/228ab5da286cb8723e93c98e1a953cc7fb49a82b/Source/library/src/main/java/im/delight/android/languages/Language.java#L134


Update the relevant part of the FAQs new limit

We should also update the relevant part of the FAQs with this new limit:
https://github.com/biosimulations/Biosimulations/blob/dev/biosimulations/apps/dispatch/src/app/components/help/faq/faq.component.html#L178
The following FAQ already has a note that users can contact us for help executing larger simulations.
Originally posted by @jonrkarr in https://github.com/biosimulations/Biosimulations/issues/2536#issuecomment-839258747

:tada: This issue has been resolved in version 2.2.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Introduce Manifest CR lookup logic into handling of SKR events

Proposed changes
Implement look up logic for the manifest CR based on the resources which changed in SKR.

/test all

/test all

This could be too heavy a compute. Take for instance: 10000 Kymas x 5 manifests each = 5000 Manifests.
After a custom CR in SKR gets updated, the skr-webhook mapping should containing the mapping of name/namespace of the parent Manifest responsible for its operations.

This could be too heavy a compute. Take for instance: 10000 Kymas x 5 manifests each = 5000 Manifests. After a custom CR in SKR gets updated, the skr-webhook mapping should containing the mapping of name/namespace of the parent Manifest responsible for its operations.

Thanks for pointing this out! I totally agree.
Should we create a separate issue for this task in our PoC?

This could be too heavy a compute. Take for instance: 10000 Kymas x 5 manifests each = 5000 Manifests. After a custom CR in SKR gets updated, the skr-webhook mapping should containing the mapping of name/namespace of the parent Manifest responsible for its operations.

Thanks for pointing this out! I totally agree. Should we create a separate issue for this task in our PoC?

Yes please, to have a resource prepared and shipped to each skr, for parent-child relationship. Also, the watcher should take care that this resource is always present in the skr using the manifest library.


Rename operator-operator -> operator

Missed these during nucleus -> registration-operator rename

/retest

/retest

/lgtm


Add new for DelayedOrigin

Codecov Report

Merging #849 (0ef342d) into master (f336875) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #849      +/-   ##
==========================================
- Coverage   78.82%   78.81%   -0.01%
==========================================
  Files         102      102
  Lines       10529    10530       +1
==========================================
  Hits         8299     8299
- Misses       2230     2231       +1

Impacted Files
Coverage Δ

authority/src/lib.rs
82.35% <0.00%> (-0.55%)
:arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Fix code scanning alert - Insertion of sensitive information into log files

Consider using a secure logging library for Java
Tracking issue for:

[ ] https://github.com/ConsenSys/teku/security/code-scanning/652

Going to close this one - we already have this alert tracked through the code scanning alerts and the information being logged isn't sensitive (and is important for the user to see to be able to resolve the issue).


add 1 zero byte when compiling empty glyf tables...

...to make Windows happy.
The OTS does that too now.
See discussion
https://github.com/khaledhosny/ots/issues/52#issuecomment-289369267

Sgtm


Reformat README

👨💻 Changes proposed:
Reformat the README to make full use of Markdown syntax, read more fluidly, and use clearer sentence constructions.
✔ Check List (Check all the applicable boxes)

[x] My code follows the code style of this project.
[x] This PR does not contain plagiarized content.
[x] The title of my pull request is a short description of the requested changes.
[x] I am a participant of Hacktoberfest 2022.

📄 Note to reviewers
An awesome repository indeed, quite a nice website!
📷 Screenshots
N/A — see preview

These changes are not needed. Kindly try to find other issues in the project. Thank you😊


Define float16::operator-() only for ROCm 5.0+

Fix #6615. Following up #6524.

LGTM, could you import #6622 PR into this one?

Done!

/test mini


Groups Dashboard Pagination

Summary
Currently the Groups Dashboard loads all top level Groups that a User has access to. This could potentially lead to a large request depending on how many Groups a User has been provided access to.
Acceptance Criteria
When a User navigates to the Groups Dashboard page they should see a pagination summary and pagination buttons like they currently see on the Projects Dashboard.

Completed in #218