Message::Array cause memory leaks

$ git diff
diff --git a/src/fluent/message.hpp b/src/fluent/message.hpp
index a71c6a3..a184c5d 100644
--- a/src/fluent/message.hpp
+++ b/src/fluent/message.hpp
@@ -149,7 +149,7 @@ namespace fluent {
       std::vector<Object*> array_;
     public:
       Array() {}
-      ~Array() {}
+      ~Array();
       Map *retain_map();
       Array *retain_array();
       void push(const std::string &val);
diff --git a/src/message.cc b/src/message.cc
index 4d1b705..c3e04d8 100644
--- a/src/message.cc
+++ b/src/message.cc
@@ -265,6 +265,12 @@ namespace fluent {
     return map;
   }

+  Message::Array::~Array() {
+    for (auto it = this->array_.begin(); it != this->array_.end(); it++) {
+      delete *it;
+    }
+  }
+
   void Message::Array::push(const std::string &val) {
     Object *v = new String(val);
     this->array_.push_back(v);

Should I post a PR for this?

Thanks for the report and sorry for my late reply. I fix the issue at fc6658e . Please reopen if you still have some problem.

Message::Array leaks was fixed, could you check leaks I attached below?
root@b553084e0e53:/libfluent# valgrind --leak-check=full ./bin/fluent-test
==5502== Memcheck, a memory error detector
==5502== Copyright (C) 2002-2015, and GNU GPL'd, by Julian Seward et al.
==5502== Using Valgrind-3.11.0 and LibVEX; rerun with -h for copyright info
==5502== Command: ./bin/fluent-test
==5502==
[==========] Running 22 tests from 6 test cases.
[----------] Global test environment set-up.
[----------] 5 tests from FluentTest
[ RUN      ] FluentTest.InetEmitter
[       OK ] FluentTest.InetEmitter (502 ms)
[ RUN      ] FluentTest.InetEmitter_with_string_portnum
[       OK ] FluentTest.InetEmitter_with_string_portnum (454 ms)
[ RUN      ] FluentTest.InetEmitter_QueueLimit
[       OK ] FluentTest.InetEmitter_QueueLimit (3172 ms)
[ RUN      ] FluentTest.Logger
[       OK ] FluentTest.Logger (926 ms)
[ RUN      ] FluentTest.QueueLimit
[       OK ] FluentTest.QueueLimit (252 ms)
[----------] 5 tests from FluentTest (5329 ms total)

[----------] 1 test from FileEmitter
[ RUN      ] FileEmitter.basic
[       OK ] FileEmitter.basic (23 ms)
[----------] 1 test from FileEmitter (23 ms total)

[----------] 1 test from QueueEmitter
[ RUN      ] QueueEmitter.basic
[       OK ] QueueEmitter.basic (26 ms)
[----------] 1 test from QueueEmitter (26 ms total)

[----------] 2 tests from Logger
[ RUN      ] Logger.QueueEmitter
[       OK ] Logger.QueueEmitter (30 ms)
[ RUN      ] Logger.TagPrefix
[       OK ] Logger.TagPrefix (12 ms)
[----------] 2 tests from Logger (44 ms total)

[----------] 4 tests from Message
[ RUN      ] Message.basic
[       OK ] Message.basic (8 ms)
[ RUN      ] Message.linkedMessage
[       OK ] Message.linkedMessage (2 ms)
[ RUN      ] Message.MapGetObject
[       OK ] Message.MapGetObject (191 ms)
[ RUN      ] Message.clone
[       OK ] Message.clone (79 ms)
[----------] 4 tests from Message (280 ms total)

[----------] 9 tests from MessageTest
[ RUN      ] MessageTest.Map
[       OK ] MessageTest.Map (146 ms)
[ RUN      ] MessageTest.Array
[       OK ] MessageTest.Array (132 ms)
[ RUN      ] MessageTest.NestArray
[       OK ] MessageTest.NestArray (138 ms)
[ RUN      ] MessageTest.NestMap
[       OK ] MessageTest.NestMap (133 ms)
[ RUN      ] MessageTest.AllowMapOverwriteValue
[       OK ] MessageTest.AllowMapOverwriteValue (132 ms)
[ RUN      ] MessageTest.AllowMapOverwriteRetain1
[       OK ] MessageTest.AllowMapOverwriteRetain1 (133 ms)
[ RUN      ] MessageTest.AllowMapOverwriteRetain2
[       OK ] MessageTest.AllowMapOverwriteRetain2 (132 ms)
[ RUN      ] MessageTest.AllowMapOverwriteRetain3
[       OK ] MessageTest.AllowMapOverwriteRetain3 (134 ms)
[ RUN      ] MessageTest.AllowMapOverwriteRetain4
[       OK ] MessageTest.AllowMapOverwriteRetain4 (134 ms)
[----------] 9 tests from MessageTest (1217 ms total)

[----------] Global test environment tear-down
[==========] 22 tests from 6 test cases ran. (7024 ms total)
[  PASSED  ] 22 tests.
==5502==
==5502== HEAP SUMMARY:
==5502==     in use at exit: 81,078 bytes in 124 blocks
==5502==   total heap usage: 860 allocs, 736 frees, 527,811 bytes allocated
==5502==
==5502== 144 (56 direct, 88 indirect) bytes in 1 blocks are definitely lost in loss record 94 of 115
==5502==    at 0x4C2E0EF: operator new(unsigned long) (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==5502==    by 0x458383: Message_basic_Test::TestBody() (in /libfluent/bin/fluent-test)
==5502==    by 0x48D9CD: void testing::internal::HandleSehExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) (in /libfluent/bin/fluent-test)
==5502==    by 0x488D2E: void testing::internal::HandleExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) (in /libfluent/bin/fluent-test)
==5502==    by 0x46EE9B: testing::Test::Run() (in /libfluent/bin/fluent-test)
==5502==    by 0x46F6CD: testing::TestInfo::Run() (in /libfluent/bin/fluent-test)
==5502==    by 0x46FD34: testing::TestCase::Run() (in /libfluent/bin/fluent-test)
==5502==    by 0x476C0F: testing::internal::UnitTestImpl::RunAllTests() (in /libfluent/bin/fluent-test)
==5502==    by 0x48E920: bool testing::internal::HandleSehExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) (in /libfluent/bin/fluent-test)
==5502==    by 0x489B6E: bool testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) (in /libfluent/bin/fluent-test)
==5502==    by 0x475807: testing::UnitTest::Run() (in /libfluent/bin/fluent-test)
==5502==    by 0x498FAC: RUN_ALL_TESTS() (in /libfluent/bin/fluent-test)
==5502==
==5502== 144 (56 direct, 88 indirect) bytes in 1 blocks are definitely lost in loss record 95 of 115
==5502==    at 0x4C2E0EF: operator new(unsigned long) (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==5502==    by 0x45A6A7: MessageTest_AllowMapOverwriteValue_Test::TestBody() (in /libfluent/bin/fluent-test)
==5502==    by 0x48D9CD: void testing::internal::HandleSehExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) (in /libfluent/bin/fluent-test)
==5502==    by 0x488D2E: void testing::internal::HandleExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) (in /libfluent/bin/fluent-test)
==5502==    by 0x46EE9B: testing::Test::Run() (in /libfluent/bin/fluent-test)
==5502==    by 0x46F6CD: testing::TestInfo::Run() (in /libfluent/bin/fluent-test)
==5502==    by 0x46FD34: testing::TestCase::Run() (in /libfluent/bin/fluent-test)
==5502==    by 0x476C0F: testing::internal::UnitTestImpl::RunAllTests() (in /libfluent/bin/fluent-test)
==5502==    by 0x48E920: bool testing::internal::HandleSehExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) (in /libfluent/bin/fluent-test)
==5502==    by 0x489B6E: bool testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) (in /libfluent/bin/fluent-test)
==5502==    by 0x475807: testing::UnitTest::Run() (in /libfluent/bin/fluent-test)
==5502==    by 0x498FAC: RUN_ALL_TESTS() (in /libfluent/bin/fluent-test)
==5502==
==5502== 152 (32 direct, 120 indirect) bytes in 1 blocks are definitely lost in loss record 96 of 115
==5502==    at 0x4C2E0EF: operator new(unsigned long) (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==5502==    by 0x459313: MessageTest_Array_Test::TestBody() (in /libfluent/bin/fluent-test)
==5502==    by 0x48D9CD: void testing::internal::HandleSehExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) (in /libfluent/bin/fluent-test)
==5502==    by 0x488D2E: void testing::internal::HandleExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) (in /libfluent/bin/fluent-test)
==5502==    by 0x46EE9B: testing::Test::Run() (in /libfluent/bin/fluent-test)
==5502==    by 0x46F6CD: testing::TestInfo::Run() (in /libfluent/bin/fluent-test)
==5502==    by 0x46FD34: testing::TestCase::Run() (in /libfluent/bin/fluent-test)
==5502==    by 0x476C0F: testing::internal::UnitTestImpl::RunAllTests() (in /libfluent/bin/fluent-test)
==5502==    by 0x48E920: bool testing::internal::HandleSehExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) (in /libfluent/bin/fluent-test)
==5502==    by 0x489B6E: bool testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) (in /libfluent/bin/fluent-test)
==5502==    by 0x475807: testing::UnitTest::Run() (in /libfluent/bin/fluent-test)
==5502==    by 0x498FAC: RUN_ALL_TESTS() (in /libfluent/bin/fluent-test)
==5502==
==5502== 184 (56 direct, 128 indirect) bytes in 1 blocks are definitely lost in loss record 97 of 115
==5502==    at 0x4C2E0EF: operator new(unsigned long) (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==5502==    by 0x45BCA9: MessageTest_AllowMapOverwriteRetain3_Test::TestBody() (in /libfluent/bin/fluent-test)
==5502==    by 0x48D9CD: void testing::internal::HandleSehExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) (in /libfluent/bin/fluent-test)
==5502==    by 0x488D2E: void testing::internal::HandleExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) (in /libfluent/bin/fluent-test)
==5502==    by 0x46EE9B: testing::Test::Run() (in /libfluent/bin/fluent-test)
==5502==    by 0x46F6CD: testing::TestInfo::Run() (in /libfluent/bin/fluent-test)
==5502==    by 0x46FD34: testing::TestCase::Run() (in /libfluent/bin/fluent-test)
==5502==    by 0x476C0F: testing::internal::UnitTestImpl::RunAllTests() (in /libfluent/bin/fluent-test)
==5502==    by 0x48E920: bool testing::internal::HandleSehExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) (in /libfluent/bin/fluent-test)
==5502==    by 0x489B6E: bool testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) (in /libfluent/bin/fluent-test)
==5502==    by 0x475807: testing::UnitTest::Run() (in /libfluent/bin/fluent-test)
==5502==    by 0x498FAC: RUN_ALL_TESTS() (in /libfluent/bin/fluent-test)
==5502==
==5502== 200 (56 direct, 144 indirect) bytes in 1 blocks are definitely lost in loss record 98 of 115
==5502==    at 0x4C2E0EF: operator new(unsigned long) (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==5502==    by 0x45001A: FluentTest_InetEmitter_QueueLimit_Test::TestBody() (in /libfluent/bin/fluent-test)
==5502==    by 0x48D9CD: void testing::internal::HandleSehExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) (in /libfluent/bin/fluent-test)
==5502==    by 0x488D2E: void testing::internal::HandleExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) (in /libfluent/bin/fluent-test)
==5502==    by 0x46EE9B: testing::Test::Run() (in /libfluent/bin/fluent-test)
==5502==    by 0x46F6CD: testing::TestInfo::Run() (in /libfluent/bin/fluent-test)
==5502==    by 0x46FD34: testing::TestCase::Run() (in /libfluent/bin/fluent-test)
==5502==    by 0x476C0F: testing::internal::UnitTestImpl::RunAllTests() (in /libfluent/bin/fluent-test)
==5502==    by 0x48E920: bool testing::internal::HandleSehExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) (in /libfluent/bin/fluent-test)
==5502==    by 0x489B6E: bool testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) (in /libfluent/bin/fluent-test)
==5502==    by 0x475807: testing::UnitTest::Run() (in /libfluent/bin/fluent-test)
==5502==    by 0x498FAC: RUN_ALL_TESTS() (in /libfluent/bin/fluent-test)
==5502==
==5502== 200 (56 direct, 144 indirect) bytes in 1 blocks are definitely lost in loss record 99 of 115
==5502==    at 0x4C2E0EF: operator new(unsigned long) (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==5502==    by 0x4500C4: FluentTest_InetEmitter_QueueLimit_Test::TestBody() (in /libfluent/bin/fluent-test)
==5502==    by 0x48D9CD: void testing::internal::HandleSehExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) (in /libfluent/bin/fluent-test)
==5502==    by 0x488D2E: void testing::internal::HandleExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) (in /libfluent/bin/fluent-test)
==5502==    by 0x46EE9B: testing::Test::Run() (in /libfluent/bin/fluent-test)
==5502==    by 0x46F6CD: testing::TestInfo::Run() (in /libfluent/bin/fluent-test)
==5502==    by 0x46FD34: testing::TestCase::Run() (in /libfluent/bin/fluent-test)
==5502==    by 0x476C0F: testing::internal::UnitTestImpl::RunAllTests() (in /libfluent/bin/fluent-test)
==5502==    by 0x48E920: bool testing::internal::HandleSehExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) (in /libfluent/bin/fluent-test)
==5502==    by 0x489B6E: bool testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) (in /libfluent/bin/fluent-test)
==5502==    by 0x475807: testing::UnitTest::Run() (in /libfluent/bin/fluent-test)
==5502==    by 0x498FAC: RUN_ALL_TESTS() (in /libfluent/bin/fluent-test)
==5502==
==5502== 224 (56 direct, 168 indirect) bytes in 1 blocks are definitely lost in loss record 101 of 115
==5502==    at 0x4C2E0EF: operator new(unsigned long) (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==5502==    by 0x4E5D6A5: fluent::Logger::retain_message(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) (in /libfluent/lib/libfluent.so)
==5502==    by 0x456911: Logger_QueueEmitter_Test::TestBody() (in /libfluent/bin/fluent-test)
==5502==    by 0x48D9CD: void testing::internal::HandleSehExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) (in /libfluent/bin/fluent-test)
==5502==    by 0x488D2E: void testing::internal::HandleExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) (in /libfluent/bin/fluent-test)
==5502==    by 0x46EE9B: testing::Test::Run() (in /libfluent/bin/fluent-test)
==5502==    by 0x46F6CD: testing::TestInfo::Run() (in /libfluent/bin/fluent-test)
==5502==    by 0x46FD34: testing::TestCase::Run() (in /libfluent/bin/fluent-test)
==5502==    by 0x476C0F: testing::internal::UnitTestImpl::RunAllTests() (in /libfluent/bin/fluent-test)
==5502==    by 0x48E920: bool testing::internal::HandleSehExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) (in /libfluent/bin/fluent-test)
==5502==    by 0x489B6E: bool testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) (in /libfluent/bin/fluent-test)
==5502==    by 0x475807: testing::UnitTest::Run() (in /libfluent/bin/fluent-test)
==5502==
==5502== 232 (192 direct, 40 indirect) bytes in 1 blocks are definitely lost in loss record 102 of 115
==5502==    at 0x4C2E0EF: operator new(unsigned long) (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==5502==    by 0x45161C: QueueEmitter_basic_Test::TestBody() (in /libfluent/bin/fluent-test)
==5502==    by 0x48D9CD: void testing::internal::HandleSehExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) (in /libfluent/bin/fluent-test)
==5502==    by 0x488D2E: void testing::internal::HandleExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) (in /libfluent/bin/fluent-test)
==5502==    by 0x46EE9B: testing::Test::Run() (in /libfluent/bin/fluent-test)
==5502==    by 0x46F6CD: testing::TestInfo::Run() (in /libfluent/bin/fluent-test)
==5502==    by 0x46FD34: testing::TestCase::Run() (in /libfluent/bin/fluent-test)
==5502==    by 0x476C0F: testing::internal::UnitTestImpl::RunAllTests() (in /libfluent/bin/fluent-test)
==5502==    by 0x48E920: bool testing::internal::HandleSehExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) (in /libfluent/bin/fluent-test)
==5502==    by 0x489B6E: bool testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) (in /libfluent/bin/fluent-test)
==5502==    by 0x475807: testing::UnitTest::Run() (in /libfluent/bin/fluent-test)
==5502==    by 0x498FAC: RUN_ALL_TESTS() (in /libfluent/bin/fluent-test)
==5502==
==5502== 272 (56 direct, 216 indirect) bytes in 1 blocks are definitely lost in loss record 103 of 115
==5502==    at 0x4C2E0EF: operator new(unsigned long) (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==5502==    by 0x45AD91: MessageTest_AllowMapOverwriteRetain1_Test::TestBody() (in /libfluent/bin/fluent-test)
==5502==    by 0x48D9CD: void testing::internal::HandleSehExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) (in /libfluent/bin/fluent-test)
==5502==    by 0x488D2E: void testing::internal::HandleExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) (in /libfluent/bin/fluent-test)
==5502==    by 0x46EE9B: testing::Test::Run() (in /libfluent/bin/fluent-test)
==5502==    by 0x46F6CD: testing::TestInfo::Run() (in /libfluent/bin/fluent-test)
==5502==    by 0x46FD34: testing::TestCase::Run() (in /libfluent/bin/fluent-test)
==5502==    by 0x476C0F: testing::internal::UnitTestImpl::RunAllTests() (in /libfluent/bin/fluent-test)
==5502==    by 0x48E920: bool testing::internal::HandleSehExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) (in /libfluent/bin/fluent-test)
==5502==    by 0x489B6E: bool testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) (in /libfluent/bin/fluent-test)
==5502==    by 0x475807: testing::UnitTest::Run() (in /libfluent/bin/fluent-test)
==5502==    by 0x498FAC: RUN_ALL_TESTS() (in /libfluent/bin/fluent-test)
==5502==
==5502== 272 (56 direct, 216 indirect) bytes in 1 blocks are definitely lost in loss record 104 of 115
==5502==    at 0x4C2E0EF: operator new(unsigned long) (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==5502==    by 0x45B545: MessageTest_AllowMapOverwriteRetain2_Test::TestBody() (in /libfluent/bin/fluent-test)
==5502==    by 0x48D9CD: void testing::internal::HandleSehExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) (in /libfluent/bin/fluent-test)
==5502==    by 0x488D2E: void testing::internal::HandleExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) (in /libfluent/bin/fluent-test)
==5502==    by 0x46EE9B: testing::Test::Run() (in /libfluent/bin/fluent-test)
==5502==    by 0x46F6CD: testing::TestInfo::Run() (in /libfluent/bin/fluent-test)
==5502==    by 0x46FD34: testing::TestCase::Run() (in /libfluent/bin/fluent-test)
==5502==    by 0x476C0F: testing::internal::UnitTestImpl::RunAllTests() (in /libfluent/bin/fluent-test)
==5502==    by 0x48E920: bool testing::internal::HandleSehExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) (in /libfluent/bin/fluent-test)
==5502==    by 0x489B6E: bool testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) (in /libfluent/bin/fluent-test)
==5502==    by 0x475807: testing::UnitTest::Run() (in /libfluent/bin/fluent-test)
==5502==    by 0x498FAC: RUN_ALL_TESTS() (in /libfluent/bin/fluent-test)
==5502==
==5502== 272 (56 direct, 216 indirect) bytes in 1 blocks are definitely lost in loss record 105 of 115
==5502==    at 0x4C2E0EF: operator new(unsigned long) (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==5502==    by 0x45C45F: MessageTest_AllowMapOverwriteRetain4_Test::TestBody() (in /libfluent/bin/fluent-test)
==5502==    by 0x48D9CD: void testing::internal::HandleSehExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) (in /libfluent/bin/fluent-test)
==5502==    by 0x488D2E: void testing::internal::HandleExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) (in /libfluent/bin/fluent-test)
==5502==    by 0x46EE9B: testing::Test::Run() (in /libfluent/bin/fluent-test)
==5502==    by 0x46F6CD: testing::TestInfo::Run() (in /libfluent/bin/fluent-test)
==5502==    by 0x46FD34: testing::TestCase::Run() (in /libfluent/bin/fluent-test)
==5502==    by 0x476C0F: testing::internal::UnitTestImpl::RunAllTests() (in /libfluent/bin/fluent-test)
==5502==    by 0x48E920: bool testing::internal::HandleSehExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) (in /libfluent/bin/fluent-test)
==5502==    by 0x489B6E: bool testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) (in /libfluent/bin/fluent-test)
==5502==    by 0x475807: testing::UnitTest::Run() (in /libfluent/bin/fluent-test)
==5502==    by 0x498FAC: RUN_ALL_TESTS() (in /libfluent/bin/fluent-test)
==5502==
==5502== 331 (56 direct, 275 indirect) bytes in 1 blocks are definitely lost in loss record 107 of 115
==5502==    at 0x4C2E0EF: operator new(unsigned long) (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==5502==    by 0x4E5D6A5: fluent::Logger::retain_message(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) (in /libfluent/lib/libfluent.so)
==5502==    by 0x456236: FluentTest_QueueLimit_Test::TestBody() (in /libfluent/bin/fluent-test)
==5502==    by 0x48D9CD: void testing::internal::HandleSehExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) (in /libfluent/bin/fluent-test)
==5502==    by 0x488D2E: void testing::internal::HandleExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) (in /libfluent/bin/fluent-test)
==5502==    by 0x46EE9B: testing::Test::Run() (in /libfluent/bin/fluent-test)
==5502==    by 0x46F6CD: testing::TestInfo::Run() (in /libfluent/bin/fluent-test)
==5502==    by 0x46FD34: testing::TestCase::Run() (in /libfluent/bin/fluent-test)
==5502==    by 0x476C0F: testing::internal::UnitTestImpl::RunAllTests() (in /libfluent/bin/fluent-test)
==5502==    by 0x48E920: bool testing::internal::HandleSehExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) (in /libfluent/bin/fluent-test)
==5502==    by 0x489B6E: bool testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) (in /libfluent/bin/fluent-test)
==5502==    by 0x475807: testing::UnitTest::Run() (in /libfluent/bin/fluent-test)
==5502==
==5502== 331 (56 direct, 275 indirect) bytes in 1 blocks are definitely lost in loss record 108 of 115
==5502==    at 0x4C2E0EF: operator new(unsigned long) (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==5502==    by 0x4E5D6A5: fluent::Logger::retain_message(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) (in /libfluent/lib/libfluent.so)
==5502==    by 0x45633B: FluentTest_QueueLimit_Test::TestBody() (in /libfluent/bin/fluent-test)
==5502==    by 0x48D9CD: void testing::internal::HandleSehExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) (in /libfluent/bin/fluent-test)
==5502==    by 0x488D2E: void testing::internal::HandleExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) (in /libfluent/bin/fluent-test)
==5502==    by 0x46EE9B: testing::Test::Run() (in /libfluent/bin/fluent-test)
==5502==    by 0x46F6CD: testing::TestInfo::Run() (in /libfluent/bin/fluent-test)
==5502==    by 0x46FD34: testing::TestCase::Run() (in /libfluent/bin/fluent-test)
==5502==    by 0x476C0F: testing::internal::UnitTestImpl::RunAllTests() (in /libfluent/bin/fluent-test)
==5502==    by 0x48E920: bool testing::internal::HandleSehExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) (in /libfluent/bin/fluent-test)
==5502==    by 0x489B6E: bool testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) (in /libfluent/bin/fluent-test)
==5502==    by 0x475807: testing::UnitTest::Run() (in /libfluent/bin/fluent-test)
==5502==
==5502== 352 (32 direct, 320 indirect) bytes in 1 blocks are definitely lost in loss record 109 of 115
==5502==    at 0x4C2E0EF: operator new(unsigned long) (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==5502==    by 0x459713: MessageTest_NestArray_Test::TestBody() (in /libfluent/bin/fluent-test)
==5502==    by 0x48D9CD: void testing::internal::HandleSehExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) (in /libfluent/bin/fluent-test)
==5502==    by 0x488D2E: void testing::internal::HandleExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) (in /libfluent/bin/fluent-test)
==5502==    by 0x46EE9B: testing::Test::Run() (in /libfluent/bin/fluent-test)
==5502==    by 0x46F6CD: testing::TestInfo::Run() (in /libfluent/bin/fluent-test)
==5502==    by 0x46FD34: testing::TestCase::Run() (in /libfluent/bin/fluent-test)
==5502==    by 0x476C0F: testing::internal::UnitTestImpl::RunAllTests() (in /libfluent/bin/fluent-test)
==5502==    by 0x48E920: bool testing::internal::HandleSehExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) (in /libfluent/bin/fluent-test)
==5502==    by 0x489B6E: bool testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) (in /libfluent/bin/fluent-test)
==5502==    by 0x475807: testing::UnitTest::Run() (in /libfluent/bin/fluent-test)
==5502==    by 0x498FAC: RUN_ALL_TESTS() (in /libfluent/bin/fluent-test)
==5502==
==5502== 432 (56 direct, 376 indirect) bytes in 1 blocks are definitely lost in loss record 110 of 115
==5502==    at 0x4C2E0EF: operator new(unsigned long) (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==5502==    by 0x4588E9: MessageTest_Map_Test::TestBody() (in /libfluent/bin/fluent-test)
==5502==    by 0x48D9CD: void testing::internal::HandleSehExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) (in /libfluent/bin/fluent-test)
==5502==    by 0x488D2E: void testing::internal::HandleExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) (in /libfluent/bin/fluent-test)
==5502==    by 0x46EE9B: testing::Test::Run() (in /libfluent/bin/fluent-test)
==5502==    by 0x46F6CD: testing::TestInfo::Run() (in /libfluent/bin/fluent-test)
==5502==    by 0x46FD34: testing::TestCase::Run() (in /libfluent/bin/fluent-test)
==5502==    by 0x476C0F: testing::internal::UnitTestImpl::RunAllTests() (in /libfluent/bin/fluent-test)
==5502==    by 0x48E920: bool testing::internal::HandleSehExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) (in /libfluent/bin/fluent-test)
==5502==    by 0x489B6E: bool testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) (in /libfluent/bin/fluent-test)
==5502==    by 0x475807: testing::UnitTest::Run() (in /libfluent/bin/fluent-test)
==5502==    by 0x498FAC: RUN_ALL_TESTS() (in /libfluent/bin/fluent-test)
==5502==
==5502== 464 (160 direct, 304 indirect) bytes in 1 blocks are definitely lost in loss record 111 of 115
==5502==    at 0x4C2E0EF: operator new(unsigned long) (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==5502==    by 0x456F3E: Logger_TagPrefix_Test::TestBody() (in /libfluent/bin/fluent-test)
==5502==    by 0x48D9CD: void testing::internal::HandleSehExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) (in /libfluent/bin/fluent-test)
==5502==    by 0x488D2E: void testing::internal::HandleExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) (in /libfluent/bin/fluent-test)
==5502==    by 0x46EE9B: testing::Test::Run() (in /libfluent/bin/fluent-test)
==5502==    by 0x46F6CD: testing::TestInfo::Run() (in /libfluent/bin/fluent-test)
==5502==    by 0x46FD34: testing::TestCase::Run() (in /libfluent/bin/fluent-test)
==5502==    by 0x476C0F: testing::internal::UnitTestImpl::RunAllTests() (in /libfluent/bin/fluent-test)
==5502==    by 0x48E920: bool testing::internal::HandleSehExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) (in /libfluent/bin/fluent-test)
==5502==    by 0x489B6E: bool testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) (in /libfluent/bin/fluent-test)
==5502==    by 0x475807: testing::UnitTest::Run() (in /libfluent/bin/fluent-test)
==5502==    by 0x498FAC: RUN_ALL_TESTS() (in /libfluent/bin/fluent-test)
==5502==
==5502== 512 (56 direct, 456 indirect) bytes in 1 blocks are definitely lost in loss record 112 of 115
==5502==    at 0x4C2E0EF: operator new(unsigned long) (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==5502==    by 0x459E31: MessageTest_NestMap_Test::TestBody() (in /libfluent/bin/fluent-test)
==5502==    by 0x48D9CD: void testing::internal::HandleSehExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) (in /libfluent/bin/fluent-test)
==5502==    by 0x488D2E: void testing::internal::HandleExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) (in /libfluent/bin/fluent-test)
==5502==    by 0x46EE9B: testing::Test::Run() (in /libfluent/bin/fluent-test)
==5502==    by 0x46F6CD: testing::TestInfo::Run() (in /libfluent/bin/fluent-test)
==5502==    by 0x46FD34: testing::TestCase::Run() (in /libfluent/bin/fluent-test)
==5502==    by 0x476C0F: testing::internal::UnitTestImpl::RunAllTests() (in /libfluent/bin/fluent-test)
==5502==    by 0x48E920: bool testing::internal::HandleSehExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) (in /libfluent/bin/fluent-test)
==5502==    by 0x489B6E: bool testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) (in /libfluent/bin/fluent-test)
==5502==    by 0x475807: testing::UnitTest::Run() (in /libfluent/bin/fluent-test)
==5502==    by 0x498FAC: RUN_ALL_TESTS() (in /libfluent/bin/fluent-test)
==5502==
==5502== 896 (56 direct, 840 indirect) bytes in 1 blocks are definitely lost in loss record 113 of 115
==5502==    at 0x4C2E0EF: operator new(unsigned long) (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==5502==    by 0x45CD65: Message_MapGetObject_Test::TestBody() (in /libfluent/bin/fluent-test)
==5502==    by 0x48D9CD: void testing::internal::HandleSehExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) (in /libfluent/bin/fluent-test)
==5502==    by 0x488D2E: void testing::internal::HandleExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) (in /libfluent/bin/fluent-test)
==5502==    by 0x46EE9B: testing::Test::Run() (in /libfluent/bin/fluent-test)
==5502==    by 0x46F6CD: testing::TestInfo::Run() (in /libfluent/bin/fluent-test)
==5502==    by 0x46FD34: testing::TestCase::Run() (in /libfluent/bin/fluent-test)
==5502==    by 0x476C0F: testing::internal::UnitTestImpl::RunAllTests() (in /libfluent/bin/fluent-test)
==5502==    by 0x48E920: bool testing::internal::HandleSehExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) (in /libfluent/bin/fluent-test)
==5502==    by 0x489B6E: bool testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) (in /libfluent/bin/fluent-test)
==5502==    by 0x475807: testing::UnitTest::Run() (in /libfluent/bin/fluent-test)
==5502==    by 0x498FAC: RUN_ALL_TESTS() (in /libfluent/bin/fluent-test)
==5502==
==5502== LEAK SUMMARY:
==5502==    definitely lost: 1,200 bytes in 18 blocks
==5502==    indirectly lost: 4,414 bytes in 100 blocks
==5502==      possibly lost: 0 bytes in 0 blocks
==5502==    still reachable: 75,464 bytes in 6 blocks
==5502==         suppressed: 0 bytes in 0 blocks
==5502== Reachable blocks (those to which a pointer was found) are not shown.
==5502== To see them, rerun with: --leak-check=full --show-leak-kinds=all
==5502==
==5502== For counts of detected and suppressed errors, rerun with: -v
==5502== ERROR SUMMARY: 18 errors from 18 contexts (suppressed: 0 from 0)

@axot I guess the memory leaks are occurred in test/Message.cc , not in libfluent. I forgot to delete object that created by new in test code. But let me check in this weekend.


Not updating the actual files, instead its sending code in the chat.

Describe the bug
The AI is suddenly not typing in the code editor it is sending me the code instead. I told it a few times to type in the code editor but instead it would just send me the code again.
Link to the Bolt URL that caused the error
https://bolt.new/~/sb1-7etvmb
Steps to reproduce
Im not sure how to reproduce. It just started doing it.
Expected behavior
Expected to actually update the code.
Screen Recording / Screenshot

Platform
Browser name = Chrome
Full version = <IP_ADDRESS>
Major version = 131
navigator.appName = Netscape
navigator.userAgent = Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/<IP_ADDRESS> Safari/537.36
performance.memory = {
  "totalJSHeapSize": 133511499,
  "usedJSHeapSize": 127985119,
  "jsHeapSizeLimit":<PHONE_NUMBER>
}
Username = mully2422
Chat ID = 070503cb43be

Additional context
Error:
You cancelled this message.

It happens. copy and paste your same prompt again and say Dont do it in the chat update the actual files.
I notice it starts to do this after your browser hasnt been refreshed in awhile and the chat starts to get too big. Id recommend refreshing the browser


py -m pipx list does not work

I just tried pipx using Python 3.7.3 on Windows, which has just been released. I went through the following steps:

Uninstall Python 3.7.2, and install Python 3.7.3 (I didn't do an upgrade install).
py -m pip install --user pipx (note that I did not choose to add Python to my path when installing, that was deliberate).
py -m pipx install invoke
py -m pipx list

When I tried the list command I got the following traceback:
>py -m pipx list
venvs are in C:\Users\pfmoore\.local\pipx\venvs
binaries are exposed on your $PATH at C:\Users\pfmoore\.local\bin
multiprocessing.pool.RemoteTraceback:
"""
Traceback (most recent call last):
  File "C:\Users\pfmoore\AppData\Local\Programs\Python\Python37\lib\multiprocessing\pool.py", line 121, in worker
    result = (True, func(*args, **kwds))
  File "C:\Users\pfmoore\AppData\Local\Programs\Python\Python37\lib\multiprocessing\pool.py", line 44, in mapstar
    return list(map(*args))
  File "C:\Users\pfmoore\AppData\Roaming\Python\Python37\site-packages\pipx\commands.py", line 525, in _get_package_summary
    metadata = venv.get_venv_metadata_for_package(package)
  File "C:\Users\pfmoore\AppData\Roaming\Python\Python37\site-packages\pipx\Venv.py", line 74, in get_venv_metadata_for_package
    stdout=subprocess.PIPE,
  File "C:\Users\pfmoore\AppData\Local\Programs\Python\Python37\lib\subprocess.py", line 472, in run
    with Popen(*popenargs, **kwargs) as process:
  File "C:\Users\pfmoore\AppData\Local\Programs\Python\Python37\lib\subprocess.py", line 775, in __init__
    restore_signals, start_new_session)
  File "C:\Users\pfmoore\AppData\Local\Programs\Python\Python37\lib\subprocess.py", line 1178, in _execute_child
    startupinfo)
FileNotFoundError: [WinError 2] The system cannot find the file specified
"""

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "C:\Users\pfmoore\AppData\Local\Programs\Python\Python37\lib\runpy.py", line 193, in _run_module_as_main
    "__main__", mod_spec)
  File "C:\Users\pfmoore\AppData\Local\Programs\Python\Python37\lib\runpy.py", line 85, in _run_code
    exec(code, run_globals)
  File "C:\Users\pfmoore\AppData\Roaming\Python\Python37\site-packages\pipx\__main__.py", line 5, in <module>
    cli()
  File "C:\Users\pfmoore\AppData\Roaming\Python\Python37\site-packages\pipx\main.py", line 496, in cli
    exit(run_pipx_command(parsed_pipx_args, binary_args))
  File "C:\Users\pfmoore\AppData\Roaming\Python\Python37\site-packages\pipx\main.py", line 187, in run_pipx_command
    commands.list_packages(PIPX_LOCAL_VENVS)
  File "C:\Users\pfmoore\AppData\Roaming\Python\Python37\site-packages\pipx\commands.py", line 586, in list_packages
    for package_summary in p.map(_get_package_summary, dirs):
  File "C:\Users\pfmoore\AppData\Local\Programs\Python\Python37\lib\multiprocessing\pool.py", line 268, in map
    return self._map_async(func, iterable, mapstar, chunksize).get()
  File "C:\Users\pfmoore\AppData\Local\Programs\Python\Python37\lib\multiprocessing\pool.py", line 657, in get
    raise self._value
FileNotFoundError: [WinError 2] The system cannot find the file specified

Looks like this might be a Python bug - https://bugs.python.org/issue36435

No, it's not a Python bug - I messed up my minimal test case :-(
... and now I can't even reproduce the pipx issue locally :-(
I'm going to close this as not a bug, but it did happen that once, so maybe there's something in the traceback that points at an intermittent problem.  I'm OK with just classing it as user error though.


StochasticSwap does not map move_measurements.qasm

Trying to move the swap mapper to StochasticSwap (PR #1574), it seems that the pass is not able to map the circuit described in /test/python/qasm/move_measurements.qasm. Here is the code I'm running (the result should be True, but it is False):
from qiskit import QuantumCircuit, QuantumRegister
from qiskit.converters import circuit_to_dag
from qiskit.transpiler.passes import StochasticSwap, CheckMap,\
    BarrierBeforeFinalMeasurements, Unroller
from qiskit.mapper import CouplingMap, Layout

circ = QuantumCircuit.from_qasm_file('./test/python/qasm/move_measurements.qasm')
dag = circuit_to_dag(circ)

qr_qa = QuantumRegister(2, 'qa')  # qreg qa[2];
qr_qb = QuantumRegister(3, 'qb')  # qreg qb[3];
qr_qN = QuantumRegister(3, 'qN')  # qreg qN[3];
qr_qc = QuantumRegister(1, 'qc')  # qreg qc[1];
qr_qNt = QuantumRegister(2, 'qNt')  # qreg qNt[2];
qr_qt = QuantumRegister(1, 'qt')  # qreg qt[1];

layout = Layout({(qr_qa, 0): 0, (qr_qa, 1): 1, (qr_qb, 0): 15,
                 (qr_qb, 1): 2, (qr_qb, 2): 14, (qr_qN, 0): 3,
                 (qr_qN, 1): 13, (qr_qN, 2): 4, (qr_qc, 0): 12,
                 (qr_qNt, 0): 5, (qr_qNt, 1): 11, (qr_qt, 0): 6})

coupling_map = CouplingMap([[1, 0], [1, 2], [2, 3], [3, 4], [3, 14], [5, 4], [6, 5], [6, 7],
                            [6, 11], [7, 10], [8, 7], [9, 8], [9, 10], [11, 10], [12, 5], [12, 11],
                            [12, 13], [13, 4], [13, 14], [15, 0], [15, 2], [15, 14]])

dag = Unroller(['u1', 'u2', 'u3', 'cx', 'id']).run(dag)
dag = BarrierBeforeFinalMeasurements().run(dag)
dag = StochasticSwap(coupling_map=coupling_map, initial_layout=layout, seed=2).run(dag)
pass_ = CheckMap(coupling_map)
pass_.run(dag)
print(pass_.property_set['is_mapped'])

Of course! The CheckMap pass needs the same initial layout!
pass_ = CheckMap(coupling_map, initial_layout=layout)

Because of this issue, I found a problem in CheckMap (see PR #1604). Even with the issue fixed. This problem persisted. So, reopening (and adapting the original example)


Phase 1 Content Generator

The following components are still required for the content generator of phase 1:

[x] Blog body generator
[x] Markdown formatter and writer
[x] Example to show usage

LGTM 👍


Switch to better status codes

Currently, the http status codes are used when returning messages. Most notably:
200 - OK
404 - Not found (in case a request came in to import a non-existent dump)
500 - Internal Server Error.
Instead, we should probably have different status codes. That way, we wouldn't be constricted to the HTTP ones, so we could differentiate actual server errors (see error on #23) from, say, validation errors (again, #23 but once it gets implemented)

Implemented


make keybase log send read from journalctl when running under systemd

r? @maxtaco
Commits from https://github.com/keybase/client/pull/9373 and https://github.com/keybase/client/pull/9343 are dependencies here, so I've included them in this branch. But please only look at the topmost commit, currently f1a6d29.
This is the third and final Pull The Lever PR. These three will all need to go in at the same time. (We could consider adding some kind of feature gate, but it would need to somehow get read by both client Go code and the run_keybase script, so I've avoided doing it.)

 Also tested setting the "heuristic expected line length" to 1, to exercise the case where we wind up with more bytes than we meant to. We truncate the logs to the tail, and add this to the top:
#####
WARNING: Lines in the journal are longer than expected. Truncating log.
#####

See this example log file. We also print the same warning to the terminal.

There is a transition edge case here, where someone could do this:

run_keybase right now, without systemd sypport
upgrade the package tomorrow or whatever, after we turn on systemd support
do a keybase log send, without having restarted anything

In that case the client command would by in systemd-is-running mode, but the running service would not, and all logs would still be going to the old files. So the new client would pull mostly empty logs from the systemd journal, and upload a mostly useless log send.
On the one hand, this all goes away after the first restart, so it's not a long term problem. On the other hand, people are particularly likely to run into issues in this transition period, so it would be nice to be able to logsend them. On the other other hand, issues are likely to be of the form "systemd failed to start keybase.service", which actually would show up in the otherwise-empty journal output.
Anyway, I've decided not to do any fancy old-style-new-style-log-merging dance, and just ignore the old files as soon as systemd support ships. Let me know if you would prefer something different.

@patrickxb do you have time to take a look at this one?

sure

Thanks!

I changed the switch to use WantsSystemd from https://github.com/keybase/client/pull/9373. That means that even on machines where systemd is running, we won't look at the journals unless KEYBASE_SYSTEMD=1 is set (until we flip that default).


fix: update jaeger namespace in tracing mesh

Motivation and Context
The previous commit ea76cce8440f9c4c32355944d52eedab66632977 changed the method to install traffic tracing component on kubernetes. Going from using a local yaml file to using the default kumactl install tracing command. The problem is that the previous version was installed in the default namespace when the new version is installed in the kuma-tracing.
Full changelog

fix: update jaeger namespace in tracing mesh

Issues resolved
None

Thanks for circling back on this @xbauquet, as promised, you can fill out the tshirt request here for contributing :) https://docs.google.com/forms/d/e/1FAIpQLSfacQHac-PYIDIrDOi_W2l7cWxBDRIVBs6xE5HnlojPvdhL9g/viewform


Suggestion : Load the whole video thumbnail without scrolling.

Thanks for sharing the code for trimming the video.
Could we provide the same functionality as in existing Apple's photo trimming tool which loads the video without scrolling?
Please let me know if we can accommodate this changes in the existing code so it will be more useful tool.

I think you can achieve this by using the maxDuration on the TrimmerView.
The maxDuration is the max duration of the asset that will be shown at once, i.e. without scrolling.
If it's smaller than the length of the asset, no scrolling will be necessary.
Make sure to set it before setting the asset, as setting the assets will regenerate all the thumbnails.

Does this solve your issue @ram2386 ?

Thanks for the reply, I had tried your solution but it does not work for me, so I had used the default controller of UIVideoEditorController which provide the same UI as Apple does for Photos app.


Automate dev signing server with CI/CD on AWS

Add Github hook to signing server for automated deployments to dev environment.

Closing this as this is being tracked in internal list.


Incorrect decompilation for floating point types

Describe the bug
Ghidra seems to have issues recognizing long double types.
To Reproduce
Steps to reproduce the behavior:

Load the program float_type.out into ghidra. There is also DWARF data provided
Click on '....'
Scroll down to '....'
See error

Expected behavior
The relevant original c code is:
   float f;
    double d;
    long double ld;
    printf("Enter float: ");
    scanf("%f", &f);
    printf("Enter double: ");
    scanf("%lf", &d);
    printf("Enter a long double: ");
    scanf("%Lf", &ld);
    printf("The values are %f %lf %LF\n", f, d, ld);
    printf("The sizes is %lu %lu %lu\n", sizeof(f), sizeof(d), sizeof(ld));

This is compiled with clang on an M1 mac using the following command:
gcc float_types.c -O0  -target x86_64-apple-darwin  -fno-stack-protector -g -o float_types.out
so x64 is emitted.
The decompilation (with DWARF info) is
  undefined8 in_R8;
  undefined8 in_R9;
  undefined auStack_28 [8];
  longdouble ld;
  double d;
  float f;
  d._4_4_ = 0;
  _printf("Enter float: ");
  _scanf("%f",&d);
  _printf("Enter double: ");
  _scanf("%lf",(long)&ld + 8);
  _printf("Enter a long double: ");
  _scanf("%Lf",auStack_28);
  _printf("The values are %f %lf %LF\n",(double)d._0_4_,stack0xffffffffffffffe8);
  _printf("The sizes is %lu %lu %lu\n",4,8,0x10,in_R8,in_R9,_auStack_28);
  return 0;

It seems that there are a few problems here. The line
_printf("The values are %f %lf %LF\n",(double)d.0_4,stack0xffffffffffffffe8);
is not detecting the third argument (the long double). Additionally, there seems to be some variable misalignment
A clear and concise description of what you expected to happen.
I expect the decompilation to better match the original source, especially with debug information available. Minimally, the printf function should capture the correct number of arguments and the variable types should be right (again especially with debug information available).
Attachments
The original program source code, binary, and debug info:
float_types.zip
Environment (please complete the following information):

OS: macOS Sonoma 14.0
Java Version: openjdk 17.0.4 2022-07-19
Ghidra Version: 10.4 PUBLIC
Ghidra Origin:  official GitHub distro

Additional context
The float_types program was compiled with Homebrew clang version 16.0.6

You can improve the situation slightly by running the "Variadic Function Signature Override" analyzer (which you can find via Analysis->One Shot).  This analyzer will parse the format strings and apply the correct signature overrides at the call sites of printf and scanf.  It does look like something is off with the alignment; we'll take a closer look.


Fix #967, Update startup script names

Describe the contribution
Startup script reflects names fixed in SAMPLE_APP and SAMPLE_LIB.
Fixes #967.
Testing performed
Boot CFE and verify startup works correctly with new names.
Expected behavior changes
N/A.
System(s) tested on
Ubuntu 20.04
Additional context
Need this at the same time as nasa/sample_app#100 and nasa/sample_lib#34.  Must be merged in same cycle as the those two.
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.

CCB 2020-10-28 APPROVED


bits/c++config.h: No such file or directory

Here's the output log. It appears some headers are expected but not available in the container.
Cross compiling github.com/wellington/wellington/wt...
Fetching main repository github.com/wellington/wellington/wt...
Fetching dependencies...
Compiling for linux/amd64...
Compiling for linux/386...
# github.com/wellington/go-libsass
In file included from /usr/include/c++/4.8/bits/stl_tree.h:61:0,
                 from /usr/include/c++/4.8/set:60,
                 from ../../go-libsass/ast.hpp:4,
                 from ../../go-libsass/ast.cpp:1:
/usr/include/c++/4.8/bits/stl_algobase.h:59:28: fatal error: bits/c++config.h: No such file or directory
 #include <bits/c++config.h>

Hey, sorry about not replying earlier. Didn't have time to work on xgo.
The issue was basically that xgo was not set up until now to cross compile C++, meaning that none of the required C++ headers, libraries or toolchains were present. I've been hacking a bit on the project in the last week or so, and I'm happy to say I managed to get this aspect covered too, so now your project compiles successfully to Linux and Windows:
$ xgo --targets=linux/*,windows/* github.com/wellington/wellington/wt

OSX fails with some missing standard library component error. I'm not entirely sure where this error comes from. It may simply be caused by an old SDK or some other error. I'll have to dig deeper into it.
In file included from ../../go-libsass/libs/unity.cpp:2:
In file included from ../../go-libsass/libs/../libsass-build/ast.cpp:1:
../libsass-build/ast.hpp:12:10: fatal error: 'unordered_map' file not found

The other missing platform that I cannot get your code built is Android (late addition to the xgo flock), due to the following error:
../../go-libsass/libs/../libsass-build/util.cpp:31:38: error: 'struct lconv' has no member named 'decimal_point'
     char separator = *(localeconv()->decimal_point);

According to a stack overflow question, this is caused by the Android NDK having a limited locale.h header, that is missing a few things. So this should be corrected on your side.
PS: docker is still crunching through the updates, so it will take a half an hour until the updates are downloadable.

Oh hey awesome, thanks for taking the time to build against my project. Looking online the unordered map error could be fixed by adding stdlib=libc++. I may just need to add that to my cgo instructions. Odd that I build fine locally on OS X.

Hmm, I think the issue is that xgo uses the OSX 10.6 SDK, which contains tr1/unordered_map, which was moved to simply unordered_map in a later SDK. However I'm not entirely sure what the correct fix for xgo is. I could include a newer SDK, but that would break all binaries on older platforms, so it's not really advisable. Maybe for now I'd suggest dependent code to include a C++ macro to check whether the tr1 or the new version should be included.

That does sound like the culprit. OS X 10.6 is very old and takes a lot of header sniffing to detect differences from modern OS X. I'm not aware of a way to test for existence of a header in cgo. The upstream C project uses autotools to detect for the correct header and set it. Not an elegant solution for a go project unfortunately.

I've been searching a bit around for whether or not Go 1.5 still supports OS X 10.6 as there's only one version on the download page, and according to this issue https://github.com/golang/go/issues/9511, 1.5 is the last officially supporting release, with 1.6 simply not maintaining it any more.
Now, the interesting question really is what xgo should do in this respect. The best theoretical solution would be to use the old 10.6 SDK's when building with anything below Go 1.5, and to switch over to the 10.8 SDK (or whatever version) above it. The problem is that all cross compilation tools are in the base image, and only the Go distribution changes above it based on the version requested, so to support two different SDKs, it would mean creating multiple base images, which will become a maintenance nightmare.
I think that for now, I'll leave it as is as I don't have the time to do a full OSX rework, and when Go 1.6 arrives, I'll replace the old SDK with 10.8. Hopefully not many people will have issues with it until then.

Sounds good! I'll just keep using my windows and Linux CIs to create
binaries. Glad to see there's some helpful tools for cgo projects. Thanks a
lot for working on this.
On Sat, Sep 19, 2015, 10:09 AM Péter Szilágyi<EMAIL_ADDRESS>wrote:

I've been searching a bit around for whether or not Go 1.5 still supports
OS X 10.6 as there's only one version on the download page, and according
to this issue golang/go#9511 https://github.com/golang/go/issues/9511,
1.5 is the last officially supporting release, with 1.6 simply not
maintaining it any more.
Now, the interesting question really is what xgo should do in this
respect. The best theoretical solution would be to use the old 10.6 SDK's
when building with anything below Go 1.5, and to switch over to the 10.8
SDK (or whatever version) above it. The problem is that all cross
compilation tools are in the base image, and only the Go distribution
changes above it based on the version requested, so to support two
different SDKs, it would mean creating multiple base images, which will
become a maintenance nightmare.
I think that for now, I'll leave it as is as I don't have the time to do a
full OSX rework, and when Go 1.6 arrives, I'll replace the old SDK with
10.8. Hopefully not many people will have issues with it until then.
—
Reply to this email directly or view it on GitHub
https://github.com/karalabe/xgo/issues/18#issuecomment-141678657.


A few questions

On android, can i use this compressed like on windows and linux
am i able to use this with adaway for android?

@MrMuttons Yes, you can use compressed host file on Android but performance difference between the compressed and uncompressed host file is very small.
You can use this host file with Adaway or DNS66


Rewrite VQE with primitives.

Separate classes EstimatorVQE/SamplerVQE or estimator/sampler in one class? Prepare design options.

Hey @dlasecki, I'm currently working on this issue. Hopefully you can assign me now.


CircleCI Cleanup

This PR does a few things for CircleCI. Soon, CircleCI will start charging for storage:
https://circleci.com/docs/2.0/persist-data/#how-to-calculate-an-approximation-of-your-monthly-costs
By FAR the most expensive storage we do is for the GCM run tests here. It was a noble experiment, but until I can do some cost calculations, etc., I'm going to turn off the GCM run tests and the persist_to_workspace bits here.
I'm also going to try compressing the logfile artifacts as well.

Before we had for gfortran and Intel:
Uploading /logfiles to logfiles
Uploading /logfiles/cmake.log (6.2 kB): DONE
Uploading /logfiles/make.log (2.0 MB): DONE
Total size uploaded: 1.9 MiB
...
Uploading /logfiles to logfiles
Uploading /logfiles/cmake.log (5.4 kB): DONE
Uploading /logfiles/make.log (5.6 MB): DONE
Total size uploaded: 5.3 MiB

and now:
Uploading /logfiles to logfiles
Uploading /logfiles/cmake.log.gz (2.1 kB): DONE
Uploading /logfiles/make.log.gz (124 kB): DONE
Total size uploaded: 123 KiB
...
Uploading /logfiles to logfiles
Uploading /logfiles/cmake.log.gz (1.3 kB): DONE
Uploading /logfiles/make.log.gz (358 kB): DONE
Total size uploaded: 351 KiB

So from 7.2 MiB (7372.8 KiB) to 474 KiB. A pretty good reduction.


FATAL : Kernel too old

When I finished installing the arch WSL through .appx package I launched it in terminal. And I got this error Fatal : Kernel Too old
Any solution?

Could you use WSL2?
ArchWSL only supports WSL2.


Add SMPlayer 20.4.2 Manifest

Microsoft Reviewers: Open in CodeFlow

Greetings lavinir
During installation testing, this application failed to install with out user input. Did you forget to add Silent or SilentWithProgress switches?
Please investigate a fix and resubmit the Pull Request.

Hi,
I had the Silent switch defined. Noticed that the default behavior would not run Silent without using winget -h switch.
Once I added the SilentWithProgress switch seems default now works as expected.

Why does "winget install mpv" install smplayer?


Update Lefey.toml

I forgot that after gentx to first namada testnet and was not selected, i deleted pre-genesis files 🥴
So, please, merge my fresh gentx file from this PR 🙏

Oh, i see file updated. Thank you! 🤝


Move pre-commit hook to pre-push

You must delete the file ./.git/hooks/pre-commit that was previously generated by the package pre-commit.
Fixes #70
Features

Move the pre-commit hook to pre-push

Used package git_hooks instead of pre_commit

Fix a test that would fail if IVLE_KEY in .env was non-empty

By using regex in the custom cassette

Pull Request Test Coverage Report for Build 512

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 96.845%

Totals

Change from base Build 507:
0.0%

Covered Lines:
307

Relevant Lines:
317

💛  - Coveralls

Btw what elixir/mix version are you running?

W.r.t. to the README, I don't think we should add the instructions in. It wouldn't be relevant in a few days time, anyways. This sounds more like a 'send-it-in-slack' kind of deal.

Yup, d271eb1 fixes the inconsistency

LGTM


❌ Failed to fetch track details; maybe that track is age restricted on YouTube. Try playing any other.

Hello, I installed the music bot, but I am getting the error in the title, ERROR in the terminal:
[youtube+oauth2] 6tcxlHM3yqc: Sign in to confirm you're not a bot. This helps protect our community. Learn more
I'm getting the error

@neonhexit Did you doing the oauth method for playing music
if yes so try again with another gmail

cookies/oauth2 in this what are you using?

cookies.txt in repo

@neonhexit Comment out this if you are using cookies

I don't know how to do it can you teach me

Come on Telegram on @TheTeamvk

Hello, I installed the music bot, but I am getting the error in the title, ERROR in the terminal:
[youtube+oauth2] 6tcxlHM3yqc: Sign in to confirm you're not a bot. This helps protect our community. Learn more
I'm getting the error

use cookies


The description of block Examples don’t match with blocks in Reference

1 .Repro steps:
•	Navigate to https://pxt.microbit.org/reference/devices/signal-strength
•	Observe the Examples
Expect reault:
The content should show the "signal strength" block examples
Actual result:
Shows "on signal strength changed" block examples

2 .Repro steps:
•	Navigate to https://pxt.microbit.org/reference/devices/raise-alert-to
•	Observe the Examples
Expect result:
The different description should match with different blocks content.
Actual result:

First one seems like a decompiler bug.

@abchatra Nope, not a bug. We don't support optional parameters in the blocks so it won't decompile if you pass the second argument. The second one is strange. The API looks like it takes in a string, so I don't know why it's being rendered as a dropdown. Decompiler doesn't know what to do with it so it always decompiles to the first entry.

These two bugs seem like fixed.
The first one now shows:

The second one now shows :

I am looking into the Bluetooth stuff. Fixed those docs.


rfd for file dialogs

@PolyMeilex I saw that you're a frequent contributor here. Is there a chance that your rfd crate can be used for file dialogs?

Yes it can be. I use rfd in my iced app https://github.com/harmony-development/Crust/blob/master/src/screen/mod.rs#L1336.

If you are asking if it can be used at the moment, then sure, it can easily be done.
If you are asking about tighter integration, for example proper setting of parent window, that would probably require integration inside iced, because we need window handle for that. I'm open to working on something like that, if there is enough interest from users and from @hecrj himself

I think file dialogs were requested several times in the past. To me, rfd is the best existing crate for this I'm aware of. This is because it's pure Rust and so allows cross-compilation (e.g. for ARM Macs) in an easy way.

rfd looks great!
We could expose a file-dialog feature to expose additional actions related to file dialogs once the new Command implementation lands (see #1019).
Since the new Command actions are processed in the event loop, at the shell level, it should be easy to obtain the window handle for proper integration, without actually exposing it in iced.

#1019 sounds great 👍

@PolyMeilex Since winit 0.26 was integrated to egui, the dialogs work fine there even on macOS (they were freezing before). What is the situation regarding this here with iced? Do I have to use the async versions to make them work? Would it be better to wait until winit is also updated?

@PolyMeilex Since winit 0.26 was integrated to egui, the dialogs work fine there even on macOS (they were freezing before). What is the situation regarding this here with iced? Do I have to use the async versions to make them work? Would it be better to wait until winit is also updated?

Good to know that my fix was published already 🎉
But winit has its own fork of winit, so it has to be rebased. The update of winit is also blocking my wgpu PR  #1164

Working on designing an API for this in my fork.  It might turn into a PR once I'm a little happier with the shape of it

When reviewing rfd, I noticed that it uses gtk3. If we are talking pure rust, gtk3 is not pure rust. I would suggest converting the gtk3 to something simple like https://github.com/Barugon/egui_file.

There's the option to use the xdg-portal backend which is pure-rust and much simpler than the GTK-3 one. It has the advantage of using your desktop environment's native file picker, which is nicer.

When reviewing rfd, I noticed that it uses gtk3. If we are talking pure rust, gtk3 is not pure rust. I would suggest converting the gtk3 to something simple like https://github.com/Barugon/egui_file.

xdg-portal backend depends only on std (so libc in extent) you can't get purer than that, it also has the least unsafe lines of all platforms (as all others have to call into FFI), using something like egui_file is not that simple, it will not work in sandboxed environment, GTK3 (with xdg-portal code backed into it), and RFD's pure rust xdg-portal backend can both handle that case.
That being said it could act as a fallback to our backend, if someone for example is running some kind of dbus-free system and treats xdg-portal as a bloat, then egui could kick in as a fallback.

The main disadvantage with xdg-portal is that it doesn't support filters, at least according to the rfd docs.

The main disadvantage with xdg-portal is that it doesn't support filters, at least according to the rfd docs.

Yeah that's an overnight, starting directory is GTK only, filters are supported, docs have a mistake in the table.


opening in a split plane?

Hi,
Thank you for building this. Is there any way to open the .h/.cc file in a split plane, instead of having a buffer be opened on top? Thanks!

Hi,
Does the section in the README about splits work for this?:

If you'd like to open the result in a split, simply pipe Ouroboros to vsplit or split:
autocmd! Filetype c,cpp noremap<buffer> <leader>sv :vsplit \| Ouroboros<CR> " open result in a vertical split
autocmd! Filetype c,cpp noremap<buffer> <leader>sh :split \| Ouroboros<CR>  " open result in a horizontal split

You can use your own keybindings but the idea is the same, just pipe the Ouroboros command to the split command you prefer.
Let me know if this doesn't work and is about something else!
Thanks,
Jake

great thanks!

(sorry i should have RTFM)

No worries, we've all done it before :)


Record list top bar not responsive on smaller screens

Description of the bug
Record list top bar (the search box and such) are not responsive
Reproduction steps

Open a page with a record list (and search enabled)
Shrink the screen

Expected behavior
The search input box should probably be expanded
Screenshot/Video

Version
Branch: 2023.3.0-dev.5.1
Reporer: Tomaz (Test Fest)
Browser: Firexox

This issue has probably been resolved in some other ticket


upgrade the aws-iam-auth version to 0.5.9

Signed-off-by: hchenxa<EMAIL_ADDRESS>the old version of aws-iam-authenticator was not able to use any more, follow https://docs.aws.amazon.com/eks/latest/userguide/install-aws-iam-authenticator.html to upgrade the version to v0.5.9

/assign @gurnben


Ensure shim start & exit events are sent in right order

Signed-off-by: Kenfe-Mickael Laventure<EMAIL_ADDRESS>

LGTM

LGTM (not a maintainer)


Fix no combat knives in sec techfab

About the PR

When I made https://github.com/space-wizards/space-station-14/pull/27224/ I overlooked the /Resources/Prototypes/Entities/Structures/Machines/lathe.yml change needed to properly implement the lathe recipe I intended. I've made this change here and tested it in game now that I have an environment set up.
Why / Balance

This was my oversight / a bug, I always intended for this recipe to be in the sec techfab but neglected a necessary step due to lack of knowledge. I'm just fixing that.

Media

I would like this one reopened please


build: Add checks for vite compatibility.

What does this PR do?
This PR brings vite support to the build sistem.
Motivation
It seems like vite has a diffrent way of exporting  envrionment variables, as opposed to create-react-app and similar applications, so attempting build an application that uses excalidraw on vite will automatically deploy the development build (and since more recent changes, the Preact build since it seems to be skipping those checks and just falling through the first condition on the if tree).
Explanation of the changes
Whereas create-react-app will export variables using the convention process.env.* in order to let programs access (among other things) the environment configuration (DEV/PROD, etc..), vite will export variables using the convention import.meta.env.* .
This PR adds a few checks to the main exports file to make sure to check for the correct variables on both vite and create-react-app (process is not defined on vite, for example) hence ensuring that users that use excalidraw projects on vite, can get the correct production build without having to manually modify the exports file.

@fdemian if the host app is using vite, they will need to expose the process.env.IS_PREACT since vite doesn't expose it by default :/, this is specific to vite so instead of adding customizations for every possible build, its better the host exposes the needed env vars as mentioned in the docs - However this will soon go away as we move to ESM which we are working on and will be shipping soon.

Hi, @ad1992
It seems like I found another solution to this. The NODE_ENV variable has to be defined, otherwise, excalidraw will just use the development build. (Maybe that can be clarified in the docs?).
Here's what I'm using right now. The value of buildMode on my code depends on wether the command is build or serve:
export default defineConfig(({ command, mode }) => {
    const env = loadEnv(mode, process.cwd(), '');
    const buildMode = command === "build" ? "production" : "development";
    return {
      define: {
        'process.env.NODE_ENV': JSON.stringify(buildMode),
        'process.env.IS_PREACT': 'false'
      },
 }


Renderer for tabular like data

Tabular data might be displayed using html styled tables.
Tabular data can come from list of structured objects or
for specific types like data frames in rapaio.

This feature will be delegated to libraries which can extend displayable objects.


Compilation error - 'EventHubProducerClient': type used in a using statement must be implicitly convertible to 'System.IDisposable'

[ ] bug report -> please search issues before submitting
[ ] feature request
[X ] documentation issue or request
[ ] regression (a behavior that used to work and stopped in a new release)

Minimal steps to reproduce
Clone and build the solution > Got compilation error.
Any log messages given by the failure

Error	CS1674	'EventHubProducerClient': type used in a using statement must be implicitly convertible to 'System.IDisposable'	SendSampleData	C:\Dev\event-hubs-dotnet-ingest\EventHubSampleData\EventHubSampleSendData\Program.cs	23	Active

Expected/desired behavior
No compilation errors
OS and Version?

Windows 10

Versions
Latest

@jongio, @mgblythe  - can you please review?


[NuGet.org Bug]: Unable to load the service index for source https://api.nuget.org/v3/index.json.

Impact
I'm unable to use NuGet.org
Describe the bug
[nuget.org] Unable to load the service index for source https://api.nuget.org/v3/index.json.
An error occurred while sending the request.
The underlying connection was closed: Could not establish trust relationship for the SSL/TLS secure channel.
The remote certificate is invalid according to the validation procedure.
Unable to load the service index for source https://api.nuget.org/v3/index.json.
Repro Steps
1 use the VS2019(Microsoft Visual Studio Enterprise 2019 Version 16.11.7) and VS2022 create a Console App
2 manage Nuget Packages and Click the Browse tab
3 the Error occurred
Expected Behavior
can load the service index for source https://api.nuget.org/v3/index.json. And can install the common nuget package
Screenshots

Additional Context and logs
No response

Hi, @charlesx163! My apologies for this inconvenience!
Does that work for you when you reach out to "https://api.nuget.org/v3/index.json" in browsers?
Could you please send us an email to<EMAIL_ADDRESS>with the following information?

Your location
DNS record: (on Windows) “Resolve-DnsName api.nuget.org” or “nslookup api.nuget.org”

Thanks!

Hi, @charlesx163! My apologies for this inconvenience!
Does that work for you when you reach out to "https://api.nuget.org/v3/index.json" in browsers? Could you please send us an email to<EMAIL_ADDRESS>with the following information?

Your location
DNS record: (on Windows) “Resolve-DnsName api.nuget.org” or “nslookup api.nuget.org”

Thanks!

Yeah, It works when I open "https://api.nuget.org/v3/index.json" in browsers.
Email has been sent.

I am closing this issue because there has been no response back. If you continue to face an issue, please feel free to open a new issue. Thanks!


Upgrade libraries to newest versions

Tried to do an upgrade when seeing deprecated / old dependencies, and failed. Have to take some time, to find all reasons why changes are necessary, and how to do them.

Relax the necessity to support old NPM versions, perhaps that will solve a little bit the problem. People don't need to develop with old versions, the library provided should be with minimal dependencies.


Local engine doesn't get copied or used

Example boxfile.yml: (· represent space)
run.config:
··engine:·../python·

Turns out the sync fails even without a space and with the proper path.
    - Copying engine :
       sync:               0 100%    0.00kB/s    0:00:00 (xfr#0, to-chk=0/1)

Trailing whitespace should always be removed, everywhere. I mean, we shouldn't have to strip it ourselves, but still. Trailing whitespace is anathema.

Yes, turns out it is has nothing to do with this issue though. I falsely assumed my first run (with no trailing whitespace) worked. Since the hooks handle and parse the boxfile my guess is nanobox isn't mounting in the engine to be rsynced from the specified location.
It is planned to incorporate the boxfile validation in nanobox itself, so as to save time before finding out a bad node was entered, but there is much in the plans (so no solid ETA).


Add option to limit thread usage per query

Description
Add instance config and query option to limit the maximum execution threads used for a query.
By default (same as existing behavior), pinot will use up to 10 threads (or half of the CPU cores is it is smaller than 10) for non-group-by queries; and all threads for group-by queries.
This option can be used to:

Limit the thread usage for very expensive queries such as large group-by or full table scan
Fully utilize all the threads for non-group-by queries to get the smallest latency

Example run of large group-by queries (10 segments, each with 10M records, grouping on a column of cardinality 10M):
Without thread limit:

Latency: 4103ms
Total thread time:<PHONE_NUMBER>7ns

With thread limit 1 (single thread):

Latency: 10495ms
Total thread time:<PHONE_NUMBER>7ns

Profile of CPU usage (run without limit 3 times, then single thread 3 times)

Release Notes
Added server instance config pinot.server.query.executor.max.execution.threads to configure the instance level thread limit
Added query option maxExecutionThreads to configure the query level thread limit, which can be used to override the instance level limit if both exist

Codecov Report

Merging #7492 (b951928) into master (240bcb8) will increase coverage by 37.65%.
The diff coverage is 71.64%.

@@              Coverage Diff              @@
##             master    #7492       +/-   ##
=============================================
+ Coverage     32.19%   69.85%   +37.65%
- Complexity        0     3332     +3332
=============================================
  Files          1514     1129      -385
  Lines         75167    53424    -21743
  Branches      10966     8049     -2917
=============================================
+ Hits          24203    37320    +13117
+ Misses        48870    13455    -35415
- Partials       2094     2649      +555

Flag
Coverage Δ

integration1
?

integration2
?

unittests1
69.85% <71.64%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...reaming/StreamingSelectionOnlyCombineOperator.java
0.00% <0.00%> (-70.46%)
:arrow_down:

...va/org/apache/pinot/spi/utils/CommonConstants.java
26.31% <ø> (+26.31%)
:arrow_up:

...operator/combine/SelectionOnlyCombineOperator.java
58.62% <20.00%> (ø)

...rator/combine/SelectionOrderByCombineOperator.java
24.13% <33.33%> (-27.59%)
:arrow_down:

...nMaxValueBasedSelectionOrderByCombineOperator.java
62.40% <50.00%> (-12.01%)
:arrow_down:

.../java/org/apache/pinot/core/util/QueryOptions.java
80.64% <50.00%> (+15.12%)
:arrow_up:

...pinot/core/plan/maker/InstancePlanMakerImplV2.java
72.22% <72.72%> (+5.26%)
:arrow_up:

...va/org/apache/pinot/core/plan/CombinePlanNode.java
85.24% <88.88%> (+0.24%)
:arrow_up:

...erator/combine/AggregationOnlyCombineOperator.java
75.00% <100.00%> (ø)

...not/core/operator/combine/BaseCombineOperator.java
82.60% <100.00%> (-6.44%)
:arrow_down:

... and 1316 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 240bcb8...b951928. Read the comment docs.

This is awesome!
One high level question, shall we consider set this numExecutionThreads part of QueryContext?

@xiangfu0 Good point. This is independent of this PR, so added #7494 to track that

@snleee @Jackie-Jiang

I think that this is an interesting feature for the multi-tenant cluster.

Do we have admission control mechanism? In multi-tenant environment, if we don't have good admission controlling, a greedy user will set the value of query level option "maxExecutionThreads" as an extremely large value to get the best performance (even if they don't need that), and impact other users. What made matters worse was that, once other users aware that heir performance drops due to a greedy user “stealing” the public resource, they will also increase their config value. Which will eventually burn out the server.

@mqliang Our old behavior is to use min(numOperator, MAX_NUM_THREADS_PER_QUERY) for all incoming queries. So, even if the user tries to be greedy (I hope this is not the case in reality), they will get the same behavior as before. I think that we can consider enabling the server level config by default for our large MT cluster given that the latency requirement is not too strict. This can protect the cluster from a single super expensive query. In our current scheme, one super-expensive query can bring down the cluster. I think that it's already a good start.
Yes, if we want to solve the problem of "fairness" among all clients for our MT cluster resource, a more sophisticated scheduling algorithm will be needed and this would be a complex research problem.

@mqliang Good point. I considered that and we want to add admission control so that regular users cannot set the query options. This PR won't make things worse because the group-by queries (most expensive ones) are already using all the system resources.
We should build all the knobs so that admin can control how the query should be executed, but also build mechanism to limit regular users from overriding these configs.

@snleee

if we want to solve the problem of fairness among all clients for our MT cluster resource, a more sophisticated scheduling algorithm will be needed and this would be a complex research problem.

A proactive scheduling algo to ensure "fairness" in the first place may be a overkill, but a protective admission control is helpful to protect the whole cluster and each server.
@Jackie-Jiang

but also build mechanism to limit regular users from overriding these configs.

This is a Authorization(AuthZ), which is a different story from admission control.

@mqliang I think that this is a good topic for discussion. Let's create an issue to capture this. Can you elaborate more about admission control vs authorization in the issue? Since this PR is already closed, it will be a bit hard to continue the discussion here.

Just going by the comments here, it may be good to impose that the per-query value of maxthreads is not above the instance config (i.e. the instance config is the max that anyone can ever set). I am not sure if this check is already being performed. @Jackie-Jiang

@mcvsubbu Good idea to bound the per-query limit by the instance limit. Let me add that in a separate PR


Add techreport type for preferred-citations.

Coverage remained the same at 100.0% when pulling a3a836b426f1d1e0e1f3e2de39b5aec6fed545e9 on add-techreport into 636faa947bcc56c77136afd568abe44de04d7506 on main.


Add -c/--report-close option so caller can know WebSocket exit status.

Thank you for your consideration!

Thanks!

Published as 2.3.0


feat: support transforming selected fragments in vector transform stage for ivf_pq index

I updated from main, let's merge if CI passes


Pinning the Delivery CLI omnibus definition because there isn't a good way to query for released versions

\cc @afiune @tylercloke

Rebase away

:shipit:

:shipit:


error with java VM on rstudio-server affecting sparklyr

Hi everyone,
I've seen a lot of issues/questions around the below error:
Script used:
library(sparklyr)
Sys.setenv(SPARK_HOME='/usr/hdp/current/spark2-client')
config <- spark_config()
config=c(config,list("spark.executor.memory"="4G",
                     "spark.driver.memory"="4G",
                     "spark.executor.instances"="3",
                     "spark.executor.cores"="4",
                     "spark.driver.cores"="4"))
sc <- spark_connect(master = 'yarn-client',config = config)

#also tried for sanity check
sc <- spark_connect(master = 'local')

Error:
Error in force(code) :
  Failed while connecting to sparklyr to port (8880) for sessionid (4530): Gateway in port (8880) did not respond.
    Path: /usr/hdp/<IP_ADDRESS>-37/spark2/bin/spark-submit
    Parameters: --class, sparklyr.Shell, '/usr/lib64/R/library/sparklyr/java/sparklyr-2.0-2.11.jar', 8880, 4530
    Log: /tmp/RtmpfR4yCu/file724a3e698ce_spark.log

---- Output Log ----
Error occurred during initialization of VM
Could not allocate metaspace:<PHONE_NUMBER> bytes

---- Error Log ----

So that you are aware, I'm on a cluster on centos using RStudio Server, Version 1.0.153. After going through the several errors issues and stackoverflow questions I realised this might be something related to Java given the following command also returned a weird error:
system2("java", "-version")
Error occurred during initialization of VM
Could not allocate metaspace:<PHONE_NUMBER> bytes

What was very interesting to see is that opening a terminal in the same cluster and same edge machine as rstudio server, open R in command line and using the above script it runs perfectly without a problem and the system2 command also runs without a problem. As a result, i'm not sure if this has anything to do with sparklyr itself but instead with some settings and potentially java settings on the rstudio-server itself.
We have opened a ticket in rstudio-server to see what we can do as we have already tried a few things to increase JVM heap size without luck.
I'm not sure if this is relevant for you or not or for other users but i just wanted to leave this here in case is handy. If you have come across this issue and can give any hints great.

R version 3.4.1 (2017-06-30)
Platform: x86_64-redhat-linux-gnu (64-bit)
Running under: CentOS Linux 7 (Core)

Matrix products: default
BLAS/LAPACK: /usr/lib64/R/lib/libRblas.so

locale:
 [1] LC_CTYPE=en_US.UTF-8       LC_NUMERIC=C               LC_TIME=en_US.UTF-8
 [4] LC_COLLATE=en_US.UTF-8     LC_MONETARY=en_US.UTF-8    LC_MESSAGES=en_US.UTF-8
 [7] LC_PAPER=en_US.UTF-8       LC_NAME=C                  LC_ADDRESS=C
[10] LC_TELEPHONE=C             LC_MEASUREMENT=en_US.UTF-8 LC_IDENTIFICATION=C

attached base packages:
[1] stats     graphics  grDevices utils     datasets  methods   base

other attached packages:
[1] sparklyr_0.6.2

loaded via a namespace (and not attached):
 [1] Rcpp_0.12.12     compiler_3.4.1   dbplyr_1.1.0     plyr_1.8.4       bindr_0.1
 [6] base64enc_0.1-3  tools_3.4.1      digest_0.6.12    jsonlite_1.5     tibble_1.3.4
[11] nlme_3.1-131     lattice_0.20-35  pkgconfig_2.0.1  rlang_0.1.2      psych_1.7.8
[16] shiny_1.0.5      DBI_0.7          rstudioapi_0.7   parallel_3.4.1   bindrcpp_0.2
[21] dplyr_0.7.3      httr_1.3.1       stringr_1.2.0    rprojroot_1.2    grid_3.4.1
[26] glue_1.1.1       R6_2.2.2         foreign_0.8-69   reshape2_1.4.2   tidyr_0.7.1
[31] purrr_0.2.3      magrittr_1.5     backports_1.1.0  htmltools_0.3.6  assertthat_0.2.0
[36] mnormt_1.5-5     mime_0.5         xtable_1.8-2     httpuv_1.3.5     stringi_1.1.5
[41] lazyeval_0.2.0   broom_0.4.2

Thank you as always,
Eliano

@ElianoMarques Take a look at /etc/rstudio/profiles, is it perhaps that the max-memory-mb is being set? See https://s3.amazonaws.com/rstudio-server/rstudio-server-pro-0.98.507-admin-guide.pdf
BTW. If you are using our pro products, support would be able to give you fast response rates on this RStudio server issue since it's most likely, a RStudio server configuration issue.

Hi, thanks we believe we have solve the issues upgrading the memory settings of rstudio, at least this error is no longer showing. Thank you for your hint and i hope this is helpful for the others.


add more infos to readme to use MQTT / Example

I agree, their is not a lot of information about getting this working properly. I had to dig around in the source code to find the Client ID that the MQTT app I am using needs (it’s “printer”). Even when it works everything prints on one line, their doesn’t seem to be a way to do a new line with MQTT which makes it useless.

Now you can refer to this example of ours https://github.com/m5stack/ATOM-PRINTER/blob/master/examples/PRINTER_FW/PRINTER_FW.ino


Add README.md and datasets/ directory.

I think than soon we want a directory for small artificial examples (as opposed to full datasets) which will be useful for both documentation and tests. I suppose we should also have a directory in which we can define the schema ml types, and then one or several directories for the tools / libraries we create. Here maybe something like "python/" (in case more tools in other language are needed later) and in there "lib/" and "bin/" maybe.

recheck

recheck


Symbol for "esc" (escape) key is confusing

(I'm using the version from brew cask)
The Escape key will have some weird symbol that I've never seen before:

This macbook has a "esc" key on the touchbar and my physical keyboard also just has an "Esc" key.
The displayed symbol does not make any sense to me.
Instead of the symbol, I'd like to display it as "Esc" or "esc".
See https://github.com/keycastr/keycastr/issues/157#issuecomment-774105208 for the same request in another issue.

This is Apple's symbol for the escape key in menu item shortcuts. For example, click the Apple menu and observe the shortcut for Force Quit.


ModusTable : Buttons and Icons can be inside the cell

Prerequisites

[X] I have searched for duplicate or closed feature requests
[X] I have read the Modus style guidelines

Proposal
Use Case :

Table cell can have button/icon for rich user experience

Motivation and context
No response
What is the issue regarding ?
@trimble-oss/modus-web-components
Priority
Medium
What product/project are you using Modus Components for ?
Trimble Construction Cloud
What is your team/division name ?
Industry Clouds
Are you willing to contribute ?
Maybe
Are you using Modus Web Components in production ?
yes, https://console.construction.cloud/#/workflow

Check with Djenifer if her team can contribute or wait for top priority items to be finished first for the table component

hey @Jayanthbalakrishnan in the screenshot, do both the icons perform some action ? Also can you please confirm if the issue https://github.com/trimble-oss/modus-web-components/issues/1729 is what your team needs too ?

Our use case  :
This page is basically displaying list of users belongs to the accounts,
When customer is clicking on,
info icon, page should be redirected to different page / dialog box - that should have more information about the user.
more icon, page should be displayed with small pop up like menus to add further more actions like edit / delete button

This use case can be handled with Row Actions #1729


Create ci-test.yml

Description

A clear and concise summary of the change and which issue (if any) it fixes. Should also include relevant motivation and context.
Resolved or fixed issue:
Affirmation

[ ] My code follows the CONTRIBUTING.md guidelines

Description
A clear and concise summary of the change and which issue (if any) it fixes. Should also include relevant motivation and context.
Resolved or fixed issue:
Affirmation

[ ]  My code follows the CONTRIBUTING.md guidelines

https://pwning.owasp-juice.shop/companion-guide/latest/part3/contribution.html#_handling_of_spam_prs


Help in settting site up

Hi @itzzzme,
I hope you're doing well! I'm currently having some trouble with setting up the reverse proxy and proxy during my site deployment. I was wondering if you could create a video tutorial on this topic?
Your help would be greatly appreciated, and by the way, the site is absolutely awesome—great work!
Looking forward to your response.

Hi @itzzzme,
I hope you're doing well! I'm currently having some trouble with setting up the reverse proxy and proxy during my site deployment. I was wondering if you could create a video tutorial on this topic?
Your help would be greatly appreciated, and by the way, the site is absolutely awesome—great work!
Looking forward to your response.

@Gupta507 You can refer to this https://github.com/itzzzme/zenime/blob/main/.env.example. I have explained everything to setup the proxy servers