When in Windows, do as Windows does aka store settings/extensions in %APPDATA% or %LOCALAPPDATA%

VSCode Version: 1.1.1
OS Version: 10

Steps to Reproduce:

Install VS Code.
Install one or more extensions.
Notice that there is a .vscode folder in your user directory.

In Windows, the root of the user directory is NOT the right place to store application settings.  This is a very common convention in Linux but Windows != Linux and not all Windows users want to pretend they are running Linux.  In windows the correct location for application settings is %APPDATA% and the correct location for extensions is %LOCALAPPDATA% or %PROGRAMDATA% (depending on level of security consciousness).
To avoid a flame war, I want to be clear that this issue isn't debating why C:/Users/<username>/.<appname> is the wrong place for these files, it is only asserting that Microsoft has very clearly documented the right place for settings files and VSCode does not follow it.  If the authors of VSCode have consciously decided to go against the long-running convention established by the OS authors then I won't press on the issue (though I think that would be a silly decision for VSCode).  I am submitting this issue under the assumption that the authors didn't realize there was an established convention (very common in open source projects) and did what was familiar to them.

Related to https://github.com/Microsoft/vscode/pull/5570; we are probably moving these directories soon.

cc @bpasero @joaomoreno

@Tyriar will we save user preferences in roaming data for Windows sync up?

Totally agree. We need an owner for this story that just implements it right for all platforms. Not only implements the change but migration as well.

Windows: %APPDATA%
Linux: .vscode
OSX: ~/Library/Application\ Support

Note that %APPDATA% on Windows seems to be the "Roaming" folder, so you potentially end up roaming extensions and settings around.

Extensions should go with %LOCALAPPDATA% but it would be great if we can have an extension list manifest file stored in %APPDATA% which roams, then notify users if there is newly added/deleted extension on other machines.

@rebornix why would we separate them? Is it bad to roam things potentially as big as extensions or something?

@Tyriar yes it's not a good idea to roam big data, per TechNet's documentation about app data roaming https://technet.microsoft.com/en-us/library/cc766489(v=ws.10).aspx , data (or data change) larger than 20 megabytes or more might cause delays in user logons.
Windows Application guideline also suggests not to roam large set of data, https://msdn.microsoft.com/en-us/library/windows/apps/hh465094.aspx . Of course, our app is not a Windows Application, but I think they share the same design principal.
So the last question is, are our extensions data too large? IMHO, they are sometimes too large and our extension development toolchain leads to this situation. When we package our extension into vsix, we don't have a good way to separate source code files and other dependencies (like test files, dev dependencies, node_modules), we always put a bunch of unused files in the extension vsix package. Take Go extension for example

The test folder is not necessary, most files from node_module packages are not necessary either. But our current toolchain can't help people easily avoid this kind of file duplication, which finally makes extension packages too large.

So something like %APPDATA%/extensions.json and %LOCALAPPDATA%/extensions/ would eventually be ideal, with the extensions from extensions.json maybe downloading automatically on launch?

@Tyriar yup it's the expected behavior the system will do. The extension json file is synced by the system automatically so I suggest we detect its change and the real extension list and notify users about the change, let them decide whether to sync the extensions on the new machine.

@Zoltu I'd appreciate your feedback on the Windows portion of #3884

@Zoltu Wow, finally someone who also embraces Windows' program storage conventions. One question though, what is the exact difference between %APPDATA% and %APPDATALOCAL%?

@felixfbecker Local doesn't get copied over the network when on a domain and roaming profiles are enabled.  When on a domain, Roaming is copied to a central server on logout and pulled down again on login.  Because of this, you generally want to keep Roaming small but Local can be big.

Closing this in favor of #3884, moved the extension manifest discussion to #15442.


windows input: Godot 3D scene has extremely laggy input

Tested versions

Reproducible in 4.3.beta bd2300d
Reproducible in 4.3.beta f2f67279
Not reproducible in 4.2.1
Not reproducible in 4.3 2efbc6b

Probable bisect by @SaracenOne :
[12fda2fc13426799bd4376c1fbd99b179c685559] Windows: Fix WINDOW_EVENT_FOCUS_IN not delivered in some cases
Not 100% sure since this bug reproduces randomly
System information
Godot v4.3.beta (bd2300d77) - Windows 10.0.19045 - Vulkan (Forward+) - dedicated NVIDIA GeForce RTX 3090 (NVIDIA; <IP_ADDRESS>13) - Intel(R) Core(TM) i9-9900K CPU @ 3.60GHz (16 Threads)
Issue description
When using things such as right click drag, WASD, scroll zoom or moving around the scene in general, the mouse and keyboard input becomes frequently lagged out, sometimes causing the camera to move in one direction continuously for 5-10 seconds
https://github.com/godotengine/godot/assets/39946030/4263f393-0687-4fa9-a533-f05ed772285a
Steps to reproduce

Open an empty project
Hold right click
Use WASD
Drag the mouse and/or use scroll wheel while doing the above.
Try scrolling the mouse wheel separately.
If it doesn't reproduce, try another editor. See #92304 and #92306 for reproduction steps that help trigger this issue

Minimal reproduction project (MRP)
Reproduces on an empty new project

I can't be 100%, but I've been doing some bisecting and while it is quite difficult to reproduce, I'm beginning this PR 12fda2fc13426799bd4376c1fbd99b179c685559 might have led to the regression.

This issue will be solved by #92742 (see https://github.com/godotengine/godot/issues/92759#issuecomment-2148797918)


[MM-669]: Fixed the TS errors in webapp's util files

Summary
Fixed the Typescript errors in the web app's util files.

Created a PR with all the changes on mattermost remote, hence closing this PR


"Error: Cannot find module 'lib/recall'" with LT 0.8 alpha

When starting Light Table 0.8 alpha, Recall throws the following errors:
Error loading JS file: /Users/thsoft/Library/Application Support/LightTable/plugins/Recall/index.js : Error: Cannot find module 'lib/recall'
Error: Cannot find module 'lib/recall'
    at Function.Module._resolveFilename (module.js:336:15)
    at Function.Module._load (module.js:286:25)
    at Module.require (module.js:365:17)
    at require (module.js:384:17)
    at Object.requireLocal [as require] (/Users/thsoft/Library/Application Support/LightTable/plugins/Recall/node_modules/ltrap/index.js:70:7)
    at nodePluginBootstrap (/Users/thsoft/Library/Application%20Support/LightTable/plugins/Recall/index.js:23:22)
    at eval (/Users/thsoft/Library/Application%20Support/LightTable/plugins/Recall/index.js:25:3)
    at eval (native)
    at c (file:///Applications/lighttable-0.8.0-alpha-mac/LightTable.app/Contents/Resources/app/core/node_modules/lighttable/bootstrap.js:21542:41)
    at a (file:///Applications/lighttable-0.8.0-alpha-mac/LightTable.app/Contents/Resources/app/core/node_modules/lighttable/bootstrap.js:21550:18)

I ran across the same problem. Is there any progress on this?
My complete stacktrace:
Error loading JS file: /Users/arnold/Library/Application Support/LightTable/plugins/Recall/index.js : Error: Cannot find module 'lib/recall'
bootstrap.js [30062]	lt.objs.plugins.__BEH__load_js
Error: Cannot find module 'lib/recall' at Function.Module._resolveFilename (module.js:336:15)
 at Function.Module._load (module.js:286:25) at Module.require (module.js:365:17)
 at require (module.js:384:17)
 at Object.requireLocal [as require] (/Users/arnold/Library/Application Support/LightTable/plugins/Recall/node_modules/ltrap/index.js:70:7)
 at nodePluginBootstrap (/Users/arnold/Library/Application%20Support/LightTable/plugins/Recall/index.js:23:22)
 at eval (/Users/arnold/Library/Application%20Support/LightTable/plugins/Recall/index.js:25:3)
 at eval (native)
 at c (file:///Applications/LightTable.app/Contents/Resources/app/core/node_modules/lighttable/bootstrap.js:21545:41)
 at a (file:///Applications/LightTable.app/Contents/Resources/app/core/node_modules/lighttable/bootstrap.js:21553:18)
bootstrap.js [30063]	lt.objs.plugins.__BEH__load_js

I can confirm the problem. It also isn't as @heyarne hinted at the reminisce plugin, it is this one. This is a:

fresh LightTable stock release download (so not compiled locally)
moved away ~/.config/LightTable to somewhere else so no plugins installed

Reminisce plugin installs fine. Install this one, instantly:

I was not trying to suggest that the error stems from the reminisce plugin, but that reminisce provides (from what I understand) similar functionality to this one while still being more actively maintained. Hope this helps.

Ah.. my bad :) Thanks for clarifying


Update OCamlLangImpl5.rst

Remove redundant code block and update comment.

Can one of the admins verify this patch?

Merged in r296968


Support novel disease description via HPO-Terms as condition

ClinVar supports describing novel disease via a list of HPO-Terms and setting multiple conditions to novel_disease. This is currently not possible via clinvar-this as the API model does not implement the multipleConditionExplanation field.
See #138

Closed via 147


Confusion about your copyright & license

in README.md:

Copyright
This code is intended only for personal privacy protection or academic research.
We are currently exploring the filing of a provisional patent on the Fawkes algorithm.

The expression personal privacy protection lead to ambiguity. Only for personal use or only aimed at personal privacy?
In context that you mentioned patent, it sounds like you're stressing only for personal use.
However, the BSD 3-Clause "New" or "Revised" License you released on inclueds high-level permission to commercial use.
Is it a contradiction?

What's more, there is this:
https://github.com/Shawn-Shan/fawkes/blob/3775bba1b42756ca0fb3e25500eee0b0622bcfe1/fawkes/detect_faces.py#L1-L3
The link goes to MIT licensed code. The MIT license requires you to reproduce copyright and permission notice to be included in all copies or substantial portions of the software.

We have 1 year period to file for provisional patent. But in the meantime, we would like to release the code to help the public for privacy protection. More details in regarding to this will come shortly on our webpage.
RE: I will append the MIT license to the code. Thanks for pointing this out.


Proposal: Mapped Types syntax to remove modifiers

Current TypeScript Version:  2.1.1
We have a syntax to add "readonly" to every property of a type. Unfortunately, it seems there is no way to have the reverse operation: removing it.
This is useful for creating Mocked version of types for UTs, which have readonly fields in production.
This should work recursively.
Code
interface MyType2 {
  readonly z1: number;
  z2: string;
}

interface MyType {
  readonly a: number;
  readonly b: MyType2;
  c: string;
  d: MyType2;
}

type Mock<T> {
  [P in keyofwithoutmodifiers T]: Mock<T[P]>;
}

type MyMockedType = Mock<MyType>;

Expected behavior:
type MyMockedType to be
{
  a: number;
  b: { z1: number; z2: string };
  c: string;
  d: { z1: number; z2: string };
}

Actual behavior:
not possible right now

I do not think we will be adding yet another construct to remove readonly and optionality in mapped types; we have a limited budget of complexity and every new concept comes in with its cost both for language users and maintainers.
You can do this today by breaking the homomorphic relationship between the target of the map and the result; to do so you need to disassociate the key from the type. e.g.:
type Mutable<T extends { [x: string]: any }, K extends string> = {
    [P in K]: T[P];
}

type Mock<T> = Mutable<T, keyof T>;

@mhegazy your code example is a solution if you want to transform
interface TypeA {
  readonly name: string;
}

to
interface TypeB {
  name: string;
}

But if you have
interface TypeA {
  readonly name: string;
  readonly color?: string;
}

and this would transform it to this
interface TypeB {
  name: string;
  color: string;
}

which is more then just removing the modifiers.
In combination with Partial<T> it is possible to remove all modifiers and make everything optional or make everything required but is isn't possible to just remove the modifiers and keep the original mix of required and optional fields or is it?

it is possible to remove all modifiers and make everything optional or make everything required but is isn't possible to just remove the modifiers and keep the original mix of required and optional fields or is it?

No; we will need to add a new mutable/readwrite modifier to undo the readonly modifier effect. but as i noted earlier, there is limited budget to adding concepts in the language.

I think this was fixed by #21919.

It definitely appears that way. The following works for me:
type Mutable<T> = {
    -readonly [P in keyof T]: T[P];
};

What if I want to remove the "private" keyword?


Cannot test for instance_of? RestClient::Response

A RestClient::Response appears to be a String class, although it can respond to non-stringy methods like #headers and #code.  There is no easy way to validate that an object is a RestClient::Response instance, other than to check whether it can respond_to? :headers or :code.  (It's OK if this is a "won't fix" issue, but it would be great to have an explanation and possibly advice on the recommended way to detect a RestClient::Response instance.)

Yep, that's a long standing (really bad) known bug. It won't be fixed until 3.0 since it's very dramatically not backwards compatible.
In code, you can tell the difference with obj.is_a?(RestClient::Response).
You'll be pleased to find that RestClient on master at least defines a sensible Response#inspect method so that you can visually tell the difference as well. The next version of RestClient will also return a true String object when you call Response#body so that there is a better way to get a plain string object than calling String.new(resp).


jdk11 version warning

WARNING: An illegal reflective access operation has occurred WARNING: Illegal reflective access by net.sf.cglib.core.ReflectUtils$1 (file:/C:/mavenRepository/xx/cglib/cglib/3.3.0/cglib-3.3.0.jar) to method java.lang.ClassLoader.defineClass(java.lang.String,byte[],int,int,java.security.ProtectionDomain) WARNING: Please consider reporting this to the maintainers of net.sf.cglib.core.ReflectUtils$1 WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations WARNING: All illegal access operations will be denied in a future release

As a result of https://bugs.openjdk.java.net/browse/JDK-8255363, this warning will cause an error as of JDK 16.


boost signals error while compiling

I cloned the package to src directory and tried to compile it but I have encountered a problem with the boost package.
`-- +++ processing catkin package: 'unitree_controller'
-- ==> add_subdirectory(unitree_ros/unitree_controller)
-- Using these message generators: gencpp;geneus;genlisp;gennodejs;genpy
CMake Error at /usr/lib/cmake/Boost-1.78.0/BoostConfig.cmake:141 (find_package):
Could not find a package configuration file provided by "boost_signals"
(requested version 1.78.0) with any of the following names:
boost_signalsConfig.cmake
boost_signals-config.cmake

Add the installation prefix of "boost_signals" to CMAKE_PREFIX_PATH or set
"boost_signals_DIR" to a directory containing one of the above files.  If
"boost_signals" provides a separate development package or SDK, be sure it
has been installed.
Call Stack (most recent call first):
/usr/lib/cmake/Boost-1.78.0/BoostConfig.cmake:262 (boost_find_component)
/usr/share/cmake-3.10/Modules/FindBoost.cmake:242 (find_package)
/usr/lib/x86_64-linux-gnu/cmake/gazebo/gazebo-config.cmake:159 (find_package)
unitree_ros/unitree_controller/CMakeLists.txt:17 (find_package)
`
Have anyone got an idea what may cause this problem?

@Segev-Cohen How did you resolve the boost version issue? I am running into the same error

How did you solve this problem? I had the same problem.


User: 위치, 좌표표기, 내선번호 표기 드로잉기능

Canvas, Javascript, Interior Library Search
map 기반의 UX를 만들기에 좋은 프로젝트
https://gojs.net/latest/samples/shapes.html
https://gojs.net/latest/samples/flowchart.html
https://gojs.net/latest/samples/planogram.html
https://gojs.net/latest/samples/seatingChart.html

https://developers.google.com/maps/documentation/javascript/reference/coordinates
lat, lng 셋팅


Add Go OTLP over gRPC exporter section

Added in previous release.

/fix:refcache

/fix:refcache


Expanded group description space missing scrollbar

On tablets, the group description space does not show a scroll bar when the area is expanded by clicking 'more' and the text expands beyond the display area. The text scrolls, but there is no scroll bar.

marking this as known issue and closing.


Create workflow to add /release-pr comment to deploy a snapshot rel…

…ease
This will allow any maintainer of this repo to post a comment of /release-pr and it will trigger a snapshot release of changesets

@JakeGinnivan this looks awesome! ❤ I'll just ping some people for an extra pair of eyes on this: @mitchellhamilton @dotansimha


teslams 1.3.0 not published on npmjs.org

Kindly asking to push the current version npm.

Seconded. This would make the install easier.
Thanks!

Published now. Sorry for the delay. Work has me swamped and I finally have some free time to get back up to date on this.


Integrated UI does not remove appended child elements

Describe the bug
I noticed this when debugging the #1210  demo. Removing the wrapper does not GC the child elements. Therefore, when the wrapper is mounted again, the number of child elements will continue to increase.
I will submit PR for fix.
https://github.com/user-attachments/assets/f2b5c594-1e61-416d-8704-8cf4b7be8368
Reproduction
c469da8 (#1210)
The current demo of this commit will grow in elements.
Steps to reproduce
No response
System Info
System:
    OS: macOS 15.1.1
    CPU: (14) arm64 Apple M4 Pro
    Memory: 2.19 GB / 64.00 GB
    Shell: 3.7.1 - /opt/homebrew/bin/fish
  Binaries:
    Node: 22.11.0 - ~/.local/share/mise/installs/node/22.11.0/bin/node
    npm: 10.9.0 - ~/.local/share/mise/installs/node/22.11.0/bin/npm
    pnpm: 9.13.0 - ~/.local/share/mise/installs/node/22.11.0/bin/pnpm
    bun: 1.1.34 - ~/.local/share/mise/installs/bun/1.1.34/bin/bun
    Watchman: 2<IP_ADDRESS> - /opt/homebrew/bin/watchman
  Browsers:
    Brave Browser: <IP_ADDRESS>
    Chrome: 131.0.6778.86
    Edge: 131.0.2903.70
    Safari: 18.1.1
  npmPackages:
    wxt: workspace:* => 0.19.16

Used Package Manager
pnpm
Validations

[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

Released in v0.19.17


Issue with the current flow of registering anoncreds objects with an external endorser

Currently, it is expected to register AnonCreds objects (using an external endorser) with the following code:
      // t = a tenant on the agent

      const { credentialDefinitionState } =
        await t.modules.anoncreds.registerCredentialDefinition<IndyVdrRegisterCredentialDefinitionOptions>(
          {
            credentialDefinition: {
              issuerId: issuerDid,
              schemaId,
              tag,
            },
            options: {
              endorserMode: 'external',
              endorserDid,
              supportRevocation: supportsRevocation,
            },
          },
        );

      if (
        credentialDefinitionState.state !== 'action' ||
        credentialDefinitionState.action !== 'endorseIndyTransaction'
      ) {
        throw new Error(
          `Error registering credentialDefinition: ${
            credentialDefinitionState.state === 'failed'
              ? credentialDefinitionState.reason
              : 'Not Finished'
          }`,
        );
      }

      const signedcredentialDefinitionRequest =
        await this.agentService.endorseTransaction(
          // eslint-disable-next-line @typescript-eslint/ban-ts-comment
          // @ts-expect-error
          credentialDefinitionState.credentialDefinitionRequest,
          endorserDid,
        );

      const credentialDefinitionSubmitResult =
        await t.modules.anoncreds.registerCredentialDefinition<IndyVdrRegisterCredentialDefinitionOptions>(
          {
            options: {
              endorsedTransaction: signedcredentialDefinitionRequest,
              endorserMode: 'external',
              supportRevocation: supportsRevocation,
            },
            credentialDefinition:
              credentialDefinitionState.credentialDefinition,
          },
        );

      if (
        credentialDefinitionSubmitResult.credentialDefinitionState.state !==
        'finished'
      ) {
        throw Error(
          `Error while registering credentialDefinition. Cause: ${JSON.stringify(credentialDefinitionSubmitResult)}`,
        );
      }

      return {
        credentialDefinitionId:
          credentialDefinitionState.credentialDefinitionId,
        ...credentialDefinitionState.credentialDefinition,
      };

In general, for all objects apart from the revocation registry definition, this works "fine". However, when registering the revocation registry definition it has some issues.

The anoncreds.registerRevocationRegistryDefinition will be called twice (once to create the transaction and once to actually submit the transaction after it being signed). This is causes anoncreds-rs to be called twice to create the revocation registry definition and also uploads it twice to the tails service. In the registerRevocationRegistryDefinition and registerCredentialDefinition there are two checks that only store the private parts when the state is finished which is fine for now, but something that I would prefer to avoid.
Another issue is that the tailsFileLocation value is being reused for the localPath, as provided by anoncreds-rs and for the URL later on. This causes an issue as the uploadTailsFile method returns the URL, but you do NOT want to upload it when the transaction is not yet finished. BUT, we must have the URL in order to create the final transaction, so we are in a chicken-and-egg loop.
Currently when this flow is done (create a rev reg def with an external endorser), it will not work when the holder receives the credential. I believe this is because we generate another rev reg def with the second anoncreds.registerRevocationRegistryDefinition call and it will be different data due to the first call being used for the actual transaction (I hope this is in some way clear...).

I have discussed this for a bit with @karimStekelenburg and we came to two conclusions but I am very open to hear other solutions for this.
Separate the create TXN and publish functions
Right now we have the anoncreds.registerSchema which must be called twice with slightly different input and some code will run twice which is not needed. We could split it up into two methods: anoncreds.createSchema and anoncreds.uploadSchema. anoncreds.registerSchema could still exist along side these other two methods for convience (or just when using an internal endorser).
The downside of this is that we will introduce 8 additional methods on the anoncreds public API which will make explaining which one you need rather difficult. However, the current API is already complex to me as well with the additional options. You only get to see them once you know the exactly what you have to do (i.e. use the IndyVdrAnonCreds...Options generic).
Have an option that just creates the TXN and expose a submitRequest on the indyVdr module
This is my current solution for the problem and it makes the API quite a bit easier. The anoncreds.registerSchema will stay the same, but instead of calling it twice, it will only have to be called once. Like so:
      const { revocationRegistryDefinitionState } =
        await t.modules.anoncreds.registerRevocationRegistryDefinition({
          options: {
            endorserMode: 'external',
            endorserDid,
          },
          revocationRegistryDefinition: {
            maximumCredentialNumber,
            credentialDefinitionId,
            tag,
            issuerId: issuerDid,
          },
        });

      if (
        revocationRegistryDefinitionState.state !== 'action' ||
        revocationRegistryDefinitionState.action !== 'endorseIndyTransaction'
      ) {
        throw new Error(
          `Error registering revocation registry definition: ${
            revocationRegistryDefinitionState.state === 'failed'
              ? revocationRegistryDefinitionState.reason
              : 'Not Finished'
          }`,
        );
      }

      const signedRevocationRegistryDefinitionRequest =
        await this.agentService.endorseTransaction(
          // eslint-disable-next-line @typescript-eslint/ban-ts-comment
          // @ts-expect-error
          revocationRegistryDefinitionState.revocationRegistryDefinitionRequest,
          endorserDid,
        );

      await t.modules.indyVdr.submitTransaction(
        signedRevocationRegistryDefinitionRequest,
        issuerDid,
      );

At the bottom there is a new method on the indyVdr module which is submitTransaction, which just takes the signed transaction from the endorser and submits this. An issue with this, is that when the submission fails the wallet already has the private parts for the cred def or rev reg def in the wallet and the tails file is already uploaded. The upside of this is is that it will work, avoid double API calls with different context and does not expose 8 new methods on the anoncreds API.
I understand partly why this API design was chosen, due to this being more of an indyVdr issue and not an AnonCreds issue per se. Right now it does not work nicely when combining anoncreds and indyVdr, which is the most common combination of credential format and registry I'd say.
Feel free to ask any questions regarding this ramble, there is a chance I skipped over some of the details of the issue so I'd be happy to clear that up :).

The anoncreds.registerRevocationRegistryDefinition will be called twice (once to create the transaction and once to actually submit the transaction after it being signed)

Hmm if the revocation registry definition is already passed, it shouldn't be created another time, we should just use the already existing revocation registry definition. Could we tweak that?
I think for e.g. createCredentialDefinition it is also only called once right? First time the cred def is created, the second time it is submitted, but we don't create two cred defs?

Another issue is that the tailsFileLocation value is being reused for the localPath, as provided by anoncreds-rs and for the URL later on. This causes an issue as the uploadTailsFile method returns the URL, but you do NOT want to upload it when the transaction is not yet finished. BUT, we must have the URL in order to create the final transaction, so we are in a chicken-and-egg loop.

I think it's OK to upload the tails file already before the transaction is completed. Storage is cheap, do we expect this flow to fail very often? Could even do a clean up separately to see if some tails files were never finished and remove them afterwards.
We could add something like getTailsUrl to the tails file service, but this will require URLs to be consistent (so the same tails file should always return the same URL, which is possible if you use e.g. the hash, but not if you want to use UUIDs)

Currently when this flow is done (create a rev reg def with an external endorser), it will not work when the holder receives the credential. I believe this is because we generate another rev reg def with the second anoncreds.registerRevocationRegistryDefinition call and it will be different data due to the first call being used for the actual transaction (I hope this is in some way clear...).

Yes that's bad and shouldn't happen. We should only call registerRevocationRegistryDefinition once and this is a bug in the implementation. As you can see with credential definition we check if the input is a full cred def, and if it is we skip the generation of the cred def. That's why external endorsement works fine for cred defs: https://github.com/openwallet-foundation/credo-ts/blob/d7c2bbb4fde57cdacbbf1ed40c6bd1423f7ab015/packages/anoncreds/src/AnonCredsApi.ts#L253-L255. @auer-martin has run into the same problem and this is how we ended up fixing it. I think we should take the same approach here.

Separate the create TXN and publish functions

I'm open to do this, but we should think about the possible flows a bit beforehand. Different ledgers work differently and we should optimize this API just for Indy external endorsement. Still, if we use the new create and publish functions the options will differ based on the ledger you use, thus still requiring some interfaces and maybe confusing overly generic options.

Have an option that just creates the TXN and expose a submitRequest on the indyVdr module

I'd prefer this approach over the seprate create TXN and publish function on the AnonCreds API. I think it could work. The reason why we didn't go with it is because then we'd already have to store the anoncreds object when you call register the first time, you would be able to use it locally, but then it will fail as it's not registered on the ledger. But I think that's a fair trade-off and probably easier to understand (= if you use external endorsment, you need to make sure that the transaction is endorsed and submitted manually)
For indy vdr it would work, for some other ones we can't be 100% sure. It could be that an identifier is generated by the ledger and thus we can't be certain that if state = action, we can already store the credential definition/schema/revocation registry.
Any thoughts on that?

I think for 0.5 we should just quickly fix it in the way we have done for cred defs using this method: https://github.com/openwallet-foundation/credo-ts/blob/d7c2bbb4fde57cdacbbf1ed40c6bd1423f7ab015/packages/anoncreds/src/AnonCredsApi.ts#L253-L255, and make sure the private parts are stored already also.
That way it'll at least work, and then we can look at making some big breaking changes refactors of the API to make it simpler (as I agree it's a shit show)

Thanks for the elaborate response @TimoGlastra!

I think for 0.5 we should just quickly fix it in the way we have done for cred defs using this method:

Yes, I think that will suffice for now.
We could add something like getTailsUrl to the tails file service, but this will require URLs to be consistent (so the same tails file should always return the same URL, which is possible if you use e.g. the hash, but not if you want to use UUIDs)

This was something I started to implement, but ran into the exact issue you just described, so I did not finish it.

For indy vdr it would work, for some other ones we can't be 100% sure. It could be that an identifier is generated by the ledger and thus we can't be certain that if state = action, we can already store the credential definition/schema/revocation registry.

Yeah that is a difficult one. That was also my main issue with my proposed solution, it is fully focussed on indy vdr.


Add experimental interface for Checkpoint/Restore.

The interface is a prerequisite for C/R support in the docker engine.
Signed-off-by: Ross Boucher<EMAIL_ADDRESS>

The tests pass, but I'm fairly sure they're only running the non experimental build. Not sure if you want to add explicit tests/build support in here for experimental mode, or just let those tests be handled at the Docker level.

@boucher I think we might want to add tests for experimental mode at some point, but I don't think this is the scope of this PR :stuck_out_tongue:

Great :)

it would be good if you could add a new Make target to run the tests with the experimental flag on in this PR, we can run it in travis with the normal suite.  Is something like this in the Makefile what I'm looking for?
test_experimental:
    go test -tags="test experimental" ./...

This looks good based on the fact it looks like a clean migration of the experimental API side of C/R to engine-api.  If we're fine with it, it would be great to get this in so we can re-vendor and get the rest of the C/R capability into docker/docker.

@crosbymichael I'm closing this PR as well, based on our discussion.

@boucher ok, thanks!


test/import fails without nyc

npx nyc tap test/import.js passes, but npx tap test/import.js fails. Let's figure out what causes this and fix it.

Fixed by d1987c0.


python312Packages.aocd-example-parser: unstable-2023-12-17 -> 2023.12.20

Diff: https://github.com/wimglenn/aocd-example-parser/compare/07330183f3e43401444fe17b08d72eb6168504e1...2023.12.20

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 355860

x86_64-linux

:white_check_mark: 8 packages built:

aocd (python312Packages.aocd)
aocd.dist (python312Packages.aocd.dist)
python311Packages.aocd
python311Packages.aocd-example-parser
python311Packages.aocd-example-parser.dist
python311Packages.aocd.dist
python312Packages.aocd-example-parser
python312Packages.aocd-example-parser.dist


Inliner v2 error coding & and template {{#each}} tags

Hello, i'm having some problems with the inlined code.

I have already encoded &; special chars, but the inliner make it again. For example:
This: Products & Services
Turns: Products &amp; Services
I have some {{#each}}tags using mustachio template language; it remains in the code but not a the same place. For example:

This:

    {{#each order_items}}

        {{{item_description}}}
        {{{../../order_currency}}} {{{item_price}}}

    {{/each}}

Turns:
{{#each order_items}} {{/each}}

      <tr class="row" style="padding: 0; ........
        <td class="width-75" style="Margin:........
        <td class="text-right".........

How can we reproduce this bug?
I attached the html and css into this message.
What did you expect to happen?
If I already have an encode &;tag, then, the inliner do not needs to encode the & char again.
And, it would be nice if the inliner place the {{#each}} tags in the correct (original) places
What happened instead?
For & I got &amp;
The {{#each}} tags places (open and close) before the right place.
What email clients does this happen in?
This problems are present in the inlined html generated.
email.zip

Duplicate of https://github.com/zurb/foundation-emails/issues/841, can be closed.

Hello,
#335 (mine) --> esteban-maidana opened this issue on 7 Apr 2016
#841 --> afterbit01 opened this issue on 30 Oct 2017
Regards,
Esteban Maidana
2018-03-11 18:34 GMT-03:00 Daniel Ruf<EMAIL_ADDRESS>
Duplicate of #841 https://github.com/zurb/foundation-emails/issues/841,
can be closed.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/zurb/foundation-emails/issues/335#issuecomment-372151371,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ARfYiYb2mSJxbzBnouX3Bf1_sNWk3YJFks5tdZh3gaJpZM4ICoyM
.

We will track this in the latest related issue which is https://github.com/zurb/foundation-emails/issues/841

Ok. Thanks.


Programmatically Alter Number of Paid 'Azure DevOps Services Users'

We are looking for a way to increase/decrease the number of paid users through the marketplace.
A solution involving a cli command to take care of this would be great, and also something to assign those roles to an AD email.
An available api endpoint that can be hot to make these changes would also be hugely appreciated!
I have done a lot of searching through the documentation for cli commands and endpoints.  I realize these may not exist, because it is inadvisable to automate these aspects of AzDO, so I am open to that feedback as well.  It would be great to easily be able to add a user and assign subscriptions quickly during our on boarding process.  This will allow less downtime for new employees, as well as lighten the current load and confusion we are currently dealing with getting these things done.  Thank you for any help or feedback in advance!

@tjprescott : I don't see the option to transfer issues, if you can then please transfer it to devops cli repo https://github.com/Microsoft/azure-devops-cli-extension
cc: @Azure/azure-devops-cli

Hi @gauravsaralMs the transfer option is a beta feature in Github, but I can't transfer to that repo because it is in "Microsoft" and not "Azure".  But I will try the Zenhub move feature and see if that works.

@tightightight : can you please close this issue and open the same at https://github.com/Microsoft/azure-devops-cli-extension

Since this has not surfaced in our repo, just providing a quick update here - we released the user management commands that lets you add users to an organization and assign licenses. Feel free to reopen any follow ups in our repo - https://github.com/azure/azure-devops-cli-extension

@tightightight Closing the issue as per comment from George. Please feel free to open a follow up in our repo  if your issue is not resolved by the new commands.


Canvas Clipping fix

There is a bug when doing canvas clipping inside viewports where they will clip relative to the size of the screen rather than the viewport. In my specific case, I have a viewport which I use to draw a GUI onto a texture. I later discovered that this fix also broke clipping in the editor viewport, so the workaround I presented was to check if the viewport had a rendertarget or not, but I'm not sure if this is universally ideal.

I'm not exactly sure how this bug happens, could you make a small test showing the broken behavior? maybe there is a better way to fix it if you are not sure

I'll see what I can do. I'll send you an example when I get the chance. Perhaps if I modify the render-to-texture example project to use GUI elements with clipping it will expose the bug.

Okay, I've modified the GUI in 3D demo to include a scrollbox which without this fix, doesn't show up properly because the default clipping behaviour uses the window height in its calculation regardless of what is being clipped. This should hopefully help demonstrate the bug. While I was at it, I noticed another small bug with this code which I've promptly fixed in this branch now.


Demo using Azure App Service with .NET backend with UWP client throws error

I downloaded--  https://github.com/Azure/azure-mobile-apps-quickstarts
*I followed this instruction in the ReadMe-----
From the command line, run
"C:\Program Files (x86)\MSBuild\14.0\Bin\MSBuild.exe" .\Microsoft.WindowsAzure.Mobile.Build.msbuild

then I followed the instructions exactly at
https://docs.microsoft.com/en-us/azure/app-service-mobile/app-service-mobile-windows-store-dotnet-get-started
1-created the App Service on Azure
2- built the .NET backend from the Quickstart and published it to my new Service successfully
3- built the UWP client
The UWP throws an error when I add a todoitem
As far as I can tell (I'm new to Azure)... the ToDoItem table is not being found
The Azure portal shows me this message
HTTP 4XX requests detected
HttpStatus	HttpSubStatus	Instance	Errors	Description
404	0	Worker	1	Not Found. The resource that you are requesting does not exist.
the UWP error is---
Message = "The request could not be completed.  (Internal Server Error)"
Request = {Method: GET, RequestUri: 'http://tomzum017.azurewebsites.net/tables/TodoItem?$filter=(complete eq false)', Version: 2.0, Content: , Headers:
{
X-ZUMO-FEATURES: TT,TC
X-ZUMO-INSTALLATION-ID: e5e3f9e6-ad65-43c6-879c-e619d9173ed0
Accept: appli...

Shouldn't this in the .NET backend Project create the table?
public class ZUMOAPPNAMEInitializer : CreateDatabaseIfNotExists<ZUMOAPPNAMEContext>
{
    protected override void Seed(ZUMOAPPNAMEContext context)
    {
        List<TodoItem> todoItems = new List<TodoItem>
        {
            new TodoItem { Id = Guid.NewGuid().ToString(), Text = "First item", Complete = false },
            new TodoItem { Id = Guid.NewGuid().ToString(), Text = "Second item", Complete = false },
        };

        foreach (TodoItem todoItem in todoItems)
        {
            context.Set<TodoItem>().Add(todoItem);
        }

        base.Seed(context);
    }
}

thank you for your help
Tom

Closing for inactivity


Restoration ran well but I cannot find my restored files & folders

The restoration seemed to complete successfully. However, I cannot find my restored files & folders in Dropbox (neither desktop nor on the web). What can be wrong here? Thanks.

I've never heard that before and I can't think of anything that would cause that.


idGenerator does not apply

setting id-generator to strong still leads to dbGenerator

can you give a more detailed description so I can reproduce?

With #244 and after adding id-generator: strong the logs tell:
started instance: dbef917e-2e3e-11e7-bb38-9a907e785252
completed task: Task[dbf18d51-2e3e-11e7-bb38-9a907e785252]

can be closed?

super cool!


Improve maintainability

I changed docker image from Ubuntu to Julia, and use REQUIRE file when installing packages.

I make a new Docker code for Julia 1.0.0 https://github.com/Kaggle/docker-julia/pull/6
So I close this.


Add Documentation for React Component Libraries

Add documentation for famous React Component libraries like Material UI, React Bootstrap

Is this still open? would love to contribute

Is this still open? would love to contribute

Yes go ahead!
https://github.com/shriya030/CS-Hut/pull/75 Refer to this PR to get clarity on how to add and follow the guidelines to add resources mentioned in the README.

@joshi-kaushal Is it done?

Sorry but I am still working on it.
I am adding tools like Reactstrap, Redux, Styled Components but there is not enough resources (just a website and quite a few YT Playlists) So I am confused what whould I do.


how to Download only the type of file i want?

Can we set the file format? For example, I want to download only pdf among documents.

I will be adding a "customize filters" option soon.

Check this version: TgDownloader v0.1.700 Preview.


Allow 2^14 + 1 for S2N_TLS_MAXIMUM_FRAGMENT_LENGTH in TLS 1.3

Problem:
S2N_TLS_MAXIMUM_FRAGMENT_LENGTH is currently 2^14 but TLS 1.3 allows 2^14 + 1
Proposed Solution:
Ensure both record read and write supports this.
Make S2N_TLS_MAXIMUM_FRAGMENT_LENGTH() a macro that takes in a parameter too

the current implementation is also a little more restrictive than what RFC allows. eg, TLS 1.2 allows TLSCiphertext.fragment length up to 2^14 + 1024 and TLSPlaintext fragment 2^14 bytes.
In TLS 1.3, TLSPlaintext is allow up to 2^14 bytes and TLSCiphertext.encrypted_record 2^14 + 256 bytes

s2n_record_rounded_write_payload_size() should return S2N_TLS_MAXIMUM_FRAGMENT_LENGTH when possible. the change in #1780 will make it possible.


Support veewee/xml 3.x

Feature Request

Q
A

New Feature
no

RFC
no

BC Break
no

Summary
This library should add support for veewee/xml version 3.x.
Thanks!

I'dd surely accept a PR for that. ;) Care to give it a spin?

Here you go ;-) Mind that I couldn't test this on a real-world example, though.

Thanks!
v3 was mostly a breaking upgrade for the reader component. It will work the same for this package as v2.


error: Failed to install cpython-3.12.4-macos-aarch64-none: Request failed after 3 retries

Comand: uv python install
Output: error: Failed to install cpython-3.12.4-macos-aarch64-none: Request failed after 3 retries
Re-ran command with verbose flag and got this output (three times):
DEBUG Transient request failure for https://github.com/indygreg/python-build-standalone/releases/download/20240726/cpython-3.12.4%2B20240726-aarch64-apple-darwin-install_only_stripped.tar.gz, retrying: error sending request for url (https://github.com/indygreg/python-build-standalone/releases/download/20240726/cpython-3.12.4%2B20240726-aarch64-apple-darwin-install_only_stripped.tar.gz)
  Caused by: client error (Connect)
  Caused by: invalid peer certificate: UnknownIssuer

UV version: uv 0.2.36 (Homebrew 2024-08-13)
Platform: MacOS Sonoma 14.5 on M1 Pro Apple Silicon
Notes: Python version specified in pyproject.toml:
[project]
requires-python = ">=3.12"

Hi! Do you have a proxy running? Are you using UV_NATIVE_TLS?

Not using UV_NATIVE_TLS.
Looks like it may be a proxy issue, thanks.
Will have to fall back to pyenv for now. Thanks.

I can only presume you are able to access GitHub normally? You can set UV_NATIVE_TLS=true or use the --native-tls flag if you need to use your system certificates with uv. We do not use the system certificate store by default, but I presume you're using a proxy with a certificate that is registered with your system.

Just a suggestion since this may be an issue for others: instead of downloading pre-compiled versions of python you could build python locally like pyenv does. This zig project could make that a lot easier, I think (and, likely, faster): https://github.com/allyourcodebase/cpython. It would likely require significant contributions to mature that project to the point where it could act as a full replacement for pyenv, but it would be a great alternative.

It's going to be way slower to locally build optimized versions of Python — thats why we offer pre-built distributions. They're hosted on GitHub and you can use UV_PYTHON_INSTALL_MIRROR if you need to install them from a different host .

Yep, of course, I meant faster than pyenv 😄.
Here's a great discussion about how pre-building Python wheels for PyPI (not exactly the same issue, but related...) is getting out of hand with the number of build targets exploding, and how the zig build system could be a better option: https://www.youtube.com/watch?v=i9nFvSpcCzo
Thanks for your help!

No problem. Feel free to let us know if you have any more problems.

Hi! Do you have a proxy running? Are you using UV_NATIVE_TLS?

BTW I tried again this time using the --native-tls flag and it worked!
Interesting that it installed Python 3.12.4, though. Python 3.12.5 is the latest version of 3.12. It's only been out for about a week, so maybe it hasn't been compiled yet?

Oh, thank I can add it. I'm annoyed, I thought I subscribed to release notifications!

Adding here: https://github.com/indygreg/python-build-standalone/pull/299

FYI: this issue (uv python not having 12.5 available) came up on the most recent episode of Python Bytes (they're big fans of UV): https://www.youtube.com/watch?v=0Sa0z2XXwwk


Can't patch ibss on ipad 5th gen ios16.1

YUP SAME PROBLEM AS ME happening right now.. any solutions you got?

have some one found a solution for this.

Try using SSHRD Lite  it's supports decrypting iboot files directly with img4


Roman Numeral Analysis add on

This PR supports the export of harmony annotations in Roman Numeral Analysis form for musicxml which can be read from Musescore.
Added:

Harmony Class in part and in musicxml export
Staff for a custom number of lines in part and in musicxml export

Missing:

Unittests
Beaming information

Notes
Currently only export is supported (no import)

Codecov Report
Patch coverage: 45.76% and project coverage change: -0.24 :warning:

Comparison is base (8b18ac8) 84.83% compared to head (ad213de) 84.59%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #220      +/-   ##
===========================================
- Coverage    84.83%   84.59%   -0.24%
===========================================
  Files           69       69
  Lines        12204    12264      +60
===========================================
+ Hits         10353    10375      +22
- Misses        1851     1889      +38

Impacted Files
Coverage Δ

partitura/io/importmusicxml.py
72.29% <6.66%> (-1.57%)
:arrow_down:

partitura/io/exportmusicxml.py
70.28% <42.10%> (-1.10%)
:arrow_down:

partitura/score.py
79.05% <72.00%> (-0.46%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

Notes Currently only export is supported (no import)
Update: Import function added for MusicXML

Transposition by interval also added.

Discussion Topic on representing Different elements of Harmony tags such as chords and/or Roman Numerals

Hello, there are imminent changes and discussion for this merge, I'm restoring the branch and reverting the merging.


Cannot read from store within a lambda function

Hi guys,
I have player with Stein lately, it's really cool.
I have built a small project with Gatsby and used Stein+spreadsheet as the database.
It's working well when I used it on the front end, from the react app. I now want to include the call from a lambda function to make the app secure, but it seems I really can't read from a store inside my lambda function. I really do not understand why. Here is the code and the errors I get:
// lambda function js
import SteinStore from "stein-js-client"

const store = new SteinStore(
    "https://api.steinhq.com/v1/storages/PRIVATE"
);

export function handler(event, context, callback) {
    console.log("queryStringParameters", event.queryStringParameters)
    console.log(store);
    store.read("questions").then(result => {
        console.log("result:");
        console.log(result);
    })
}

Here is the log from the console:
Request from ::ffff:<IP_ADDRESS>: GET /questionList
queryStringParameters [Object: null prototype] {}
u {
  url:
   'https://api.steinhq.com/v1/storages/PRIVATE/' }
(node:4144) UnhandledPromiseRejectionWarning: TypeError: r(...) is not a function
    at e.exports.global.fetch (/Users/matt/Documents/htdocs/gatsbydynamic/lambda/questionList.js:1:1625)
    at Promise (/Users/matt/Documents/htdocs/gatsbydynamic/lambda/questionList.js:1:21063)
    at new Promise (<anonymous>)
    at e.exports (/Users/matt/Documents/htdocs/gatsbydynamic/lambda/questionList.js:1:21043)
    at u.read (/Users/matt/Documents/htdocs/gatsbydynamic/lambda/questionList.js:1:20213)
    at Object.s [as handler] (/Users/matt/Documents/htdocs/gatsbydynamic/lambda/questionList.js:1:22728)
    at /Users/matt/Documents/htdocs/gatsbydynamic/node_modules/netlify-lambda/lib/serve.js:143:27
    at Layer.handle [as handle_request] (/Users/matt/Documents/htdocs/gatsbydynamic/node_modules/express/lib/router/layer.js:95:5)
    at next (/Users/matt/Documents/htdocs/gatsbydynamic/node_modules/express/lib/router/route.js:137:13)
    at next (/Users/matt/Documents/htdocs/gatsbydynamic/node_modules/express/lib/router/route.js:131:14)
    at next (/Users/matt/Documents/htdocs/gatsbydynamic/node_modules/express/lib/router/route.js:131:14)
    at next (/Users/matt/Documents/htdocs/gatsbydynamic/node_modules/express/lib/router/route.js:131:14)
    at next (/Users/matt/Documents/htdocs/gatsbydynamic/node_modules/express/lib/router/route.js:131:14)
    at next (/Users/matt/Documents/htdocs/gatsbydynamic/node_modules/express/lib/router/route.js:131:14)
    at next (/Users/matt/Documents/htdocs/gatsbydynamic/node_modules/express/lib/router/route.js:131:14)
    at Route.dispatch (/Users/matt/Documents/htdocs/gatsbydynamic/node_modules/express/lib/router/route.js:112:3)
(node:4144) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 15)

Any clue ?

Webpack messes up requires in modules. We should set it to exclude stein-js-client.
To do this, create a webpack config file (something like webpack.functions.js) (if not already), and add this to it:
module.exports = {
  externals: {
    "stein-js-client" : {commonjs: "stein-js-client"}
  }
}

Then, to serve your source, run:
netlify-lambda serve .\source\ -c .\webpack.functions.js

Let me know if it works!

Great, it is working locally now.
So you know, since I am using Gatsby, I had to change the package.json file like this (to serve the lambda functions which are located in src/lambda in my app):
"scripts": {
     ...
    "start:lambda": "netlify-lambda serve --config ./webpack.functions.js src/lambda",
    ...
  }

I have yet to try it in production but I definitely let you know.
Thanks ;-)

I'm closing this for now. If there's an issue during production, feel free to open this issue again.

For production I had to add this to package.json
"scripts": {
     ...
    "build:lambda": "netlify-lambda --config ./webpack.functions.js build src/lambda",
    ...
  }


Moved the note section

#6462

Dear @JohanFreelancer9,
could you please have a look?
Thank you

@mapalko - PR has been copy edited and is ready for final review. This is based on issue #6462
Thank you.
cc: @kenwith

Final review completed (see approval above).

@Dansimp @kenwith - Can you please assist to merge this PR? This has been approved by @mapalko
Thank you.


Use autotools macros to find ncurses library

Use a better macro to determine the C compiler. This will look for the CC environment variable first, so that it is possible to use e.g. clang.
Use macros to determine how to link ncurses. On some systems the correct flag is -lcurses and on others -lncurses. This should determine the correct form.

I've used autoconf 2.69 and aclocal 1.13.4 to update configure, and I've tested on OpenSUSE 13.2 and Scientific Linux 5.11. I'm afraid because configure is automatically generated, the changes are quite unreadable, but configure.in and Makefile.in are the important changes, and they are much easier to read.

I'm going to hold off on this one until the next version, so that I can take some time to test this under a few different platforms.  The other pulls related to the time parsing segfault and support for Nagios 4.x are important so I want to get those out now.
Thanks again for taking care of all this!

No worries, glad to help!


fix render bug for good-first-issues:>2 javascript

These backticks cause the embedded > to pass through escaped and be rendered not as a > symbol, but rather > in the HTML output. This change corrects that and also brings it inline with the other example in the same table (no backticks).

Why:
Closes: 25292

What's being changed (if available, include any code snippets, screenshots, or gifs):

Simply removed the conflicting backticks to bring it inline with other example in table and fix rendering bug.
Check off the following:

[x] I have reviewed my changes in staging (look for the "Automatically generated comment" and click the links in the "Preview" column to view your latest changes).
[x] For content changes, I have completed the self-review checklist.

@danhood Thank you for opening a PR and linking it to your issue! ✨


RSpec tests failing ActiveRecordError: "Cannot expire connection, it is owned by a different thread" with Ubuntu 20.04 (20240414) Image Update

Description
Starting a few days ago, we started seeing intermittent failures on our RSpec tests.
raise ActiveRecordError, "Cannot expire connection, " \
         "it is owned by a different thread: #{@owner}. " \
         "Current thread: #{Thread.current}."

While troubleshooting we rolled back to code that preceded the weekend and found that we were still seeing the errors. Wondering if there is anyone else out there who started seeing intermittent test failures with the same error.
Platforms affected

[ ] Azure DevOps
[X] GitHub Actions - Standard Runners
[ ] GitHub Actions - Larger Runners

Runner images affected

[X] Ubuntu 20.04
[ ] Ubuntu 22.04
[ ] macOS 11
[ ] macOS 12
[ ] macOS 13
[ ] macOS 13 Arm64
[ ] macOS 14
[ ] macOS 14 Arm64
[ ] Windows Server 2019
[ ] Windows Server 2022

Image version and build link
Runner Image: 20240414.1.0
Is it regression?
20240407.1.0
Expected behavior
All RSpec tests pass.
Actual behavior
Intermittent failures occurring where a test will fail with the following error:
raise ActiveRecordError, "Cannot expire connection, " \
         "it is owned by a different thread: #{@owner}. " \
         "Current thread: #{Thread.current}."

Repro steps
To reproduce this issue we just need to run our full RSpec test suite.

Hello @tpodlipni!
Could you please provide us with the minimal repro steps so that we can reproduce the issue from our side? It would be great if you could provide us with a link to the public repository where the issue occurs.

@MaksimZhukov, this is for a private repository actually.

What did you end up discovering? I'm coming across this problem currently.

@slikstir, sorry for not posting more information about the resolution. The culprit was in a new set of rspecs. We decided to skip the tests and revisit them during a future bug bash/cleanup. The best recommendation I can give based on our experience is to review recently added or changed tests.


v2 theme discussion

@dbeg mentioned in #9 about the potential to create a v2 of this theme that could provide some larger improvements to the theme.  I'm opening this issue here so we can discuss and list some of the wants and needs for a v2 of this theme.

[ ] Header image which properly repeats
[ ] Remove Helvetica Neue in favor of the new fonts we use
[ ] Icons which match our brand icons
[ ] Improved accessibility and responsiveness

Let's also address cache/busting during this time to ensure our stylesheet caches are busted during deploys (as I just got a cached copy and ran into some incorrect styles).


Update site index page with lighter font

What type of PR is this:

/kind documentation
What does this PR do / why we need it:
Updates the website so the index page isn't "shouting" at you with the
bolded text. Changes it to a softer weighted font.
Which issue(s) this PR fixes:

N/A
Signed-off-by: Charlie Drage<EMAIL_ADDRESS>

Updates the website so the index page isn't "shouting" at you with the
bolded text.

I find the fonts for the blog title to be shouting loudly and violently as well. Just saying.
/lgtm
/approve
(small change)

/override windows-integration-test/Windows-test


Added minutes, seconds, and milliseconds to the date bucket values.

I wanted to be able to create heat maps down to the millisecond instead of just the hour.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: jonathanbyrne sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


Setup a staging deployment in IT cluster

User story
As an MDN developer, I want a staging deployment in the IT cluster, so I can better estimate the work for feature parity with the MozMEAO cluster
Acceptance criteria

A staging deployment (database, files, backing services, etc) is running in the IT cluster
The manual staging checklist is complete
Follow-on tasks are documented with the migration team

Tasks
Tracked in MDN migration project, Staging Cluster milestone.

This is done:

A stage instance is running in the IT-owned cluster: https://developer.mozilla-mdn.nubis.allizom.org/en-US/
All tests within the manual stage checklist have been successfully completed.
One follow-on task (https://github.com/mozilla-itcloud/mdn-migration-project/issues/39) has been added to the "Metrics & Monitoring" milestone for the migration tam.

The details are documented in https://github.com/mozilla-itcloud/mdn-migration-project/issues/29.


Try native plugins

https://github.com/swc-project/swc/issues/1048

Hey, @Brooooooklyn! I'd like to use some plugin for performance optimizations of jest. E.g. swc-plugin-transform-import, is this PR somehow related to it? I briefly checked the implementation of transform and there is no option to pass plugins to it. Also I don't quite understand how new plugin system related to this PR https://github.com/swc-project/swc/discussions/3540, can you please shed some light on it?


Buttons and Zoom in or Zoom out related issue at  /integrations page

Description
There is extra div and buttons should not be in mid of the container . another issue is that if we click anywhere on the page then the image zoom in or zoom out easily and hover on the text .
Expected Behavior
There should not be extra div and  buttons should be top of the container or bottom of the container . if we zoom the image then it's zooming behaviour should be inside it's container itself , it should not be efffected another container.
Screenshots

Enviroment:

OS: Mac Linux Windows
Browser: Chrome Safari Firefox
Version:
Device: Desktop Mobile

Contributor Guides and Handbook
The meshery.io website uses Jekyll and GitHub Pages. Site content is found under the master branch.

📚 See the Contributing to Meshery.io Website section of the readme.md and other contributing instructions, too.
🎨 Wireframes and designs for Meshery UI in Figma
🙋🏾🙋🏼 Questions: Discussion Forum and Community Slack

issue #1190

@Rajivkumawat3,  We can close this one as the concerned issue has been taken care of, see the latest deployment for this. Thank you for looking up.

@Rajivkumawat3,  We can close this one as the concerned issue has been taken care of, see the latest deployment for this. Thank you for looking up.


Update README.md

Added Helix QAC

Helix QAC :copyright: - Enterprise-grade static analysis for embedded software. Supports MISRA, CERT, and AUTOSAR coding standards.

Great! Thank you.


esphome: add missing libstdc++

Description of changes
Related issue: #275679.
In order to build the ESP32x binaries, platformio needs access to libstdc++.
Things done

Built on platform(s)

[X] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[X] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

platformio needs access to libstdc++

So why are we patching esphome?

platformio needs access to libstdc++

So why are we patching esphome and not platformio then?

Platformio itself doesn’t need the library, it’s the context (in this case the esphome payload) that requires it.

Please update the commit message, with a reason, why it is needed. Then I will merge it.

Thanks for the update. Unfortunately it needs one more rebase, after the wrapper was extended with ping through another PR.

Would it be possible for this to be backported?


:bug: Input and Output formatters now are async.

This change resolve the System.InvalidOperationException: Synchronous operations are disallowed. Call ReadAsync or set AllowSynchronousIO to true instead. that occours when you use formatters on netcore 3.+

This change resolves the #186 issue

I need this. Any chance of it getting merged anytime soon? :)

We need this badly!

I would obviously loved for this to released. Assume @neuecc is busy.
It isn't too terribly difficult to just copy the JsonOutputFormatter and the JsonInputFormatter into your project and use them with these changes either.

Top PR, Looking at the code frequency @neuecc is not maintaining this repository anymore.
The last commit was in January 2018.
https://github.com/neuecc/Utf8Json/graphs/code-frequency
That is sad because as for me this is for far the best serializer in dotnet, it is simple, elegant, and super fast compare to System.Text.Json. I understand that the maintainers move to MessagePack that fit better their requirements as game developers. But, it will be so cool if they let the community maintain this repo :)
I recommend you @bernardbr to create a separate repo and publish this formatter as a new NuGet.

Wow, this has been here long... I ran into this but I am surprised that this PR has been waiting here SO long... Please fix this and help the world... accept this PR... it's such an easy one to push through...


[top/dv] Automatically generate rstmgr exclusion

Automatically exclude resets that are not used at the top level.

Should address #15426

Signed-off-by: Timothy Chen<EMAIL_ADDRESS>

hey all, i don't really know if i'm doing this right, so please have a look and let me know.

My preference is to use "cover*.cfg" files rather than ".el" files for these sorts of exclusions. These files are tool-specific (just like *.el files are). One example is at  hw/top_earlgrey/dv/cov/chip_cover_reg_top.cfg, except for your purpose you would need to do "-node ", where - means ignore coverage.

My preference is to use "cover*.cfg" files rather than ".el" files for these sorts of exclusions. These files are tool-specific (just like *.el files are). One example is at hw/top_earlgrey/dv/cov/chip_cover_reg_top.cfg, except for your purpose you would need to do "-node ", where - means ignore coverage.

I am working on adding a constfile that can be added to the coverage collection via -cm_constfile switch. I feel like that will be even better than a -cm_hier cfg file, since it allows VCS to do constant propagation analysis and automatically mark the fanouts of these as unreachable.

sounds good @sriyerg .
do you want me to wait on that for now? I can follow whatever format you think makes sense and add to it.

sounds good @sriyerg . do you want me to wait on that for now? I can follow whatever format you think makes sense and add to it.

Yes please!

We talked about having these exclusions get placed in .cfg rather than .el files: .el files generally tag each exclusion wiith CHECKSUM and ANNOTATION. It is not clear they are indispensable or if the exclusion will work if they are not present. In .cfg files the syntax is "-node ", and no additional tagging is needed.

sounds good @sriyerg . do you want me to wait on that for now? I can follow whatever format you think makes sense and add to it.

VCS unfortunately does not support MDAs in constfiles (I added you to an email thread with SNPS AE). Since resets_o is an MDA (struct), we will not be able to use this approach. We will need to go with @matutem's suggestion instead, and have these implemented in a -cm_hier coverage hierarchy file. Here's an example:
https://github.com/lowRISC/opentitan/blob/d2dce395b2128e5acc40fa772cfd565e4754c82a/hw/top_earlgrey/dv/autogen/xbar_tgl_excl.cfg#L9

sorry this has taken awhile.
@sriyerg / @matutem can you let me know if i did this right?

You can verify if this was done correctly by running a smoke regr with coverage:
$ util/dvsim/dvsim.py hw/top_earlgrey/dv/chip_sim_cfg.hjson -i smoke --cov

and check the generated report located at  /path/to/scratch/<branch>/chip_earlgrey_asic-sim-vcs/cov_report/dashboard.html.

ah sounds good, i did run that sim, but didnt really know what ot check, let me try that.

merging! thanks for the reviews all.


Cascade Layers: Shipping in Firefox 97 and Chrome 99

Triggered by https://www.bram.us/2021/12/27/css-in-2022/#the-hotlist--cascade-layers

Cascade layers will be supported in Chromium 99 and Firefox 97. They're also supported in Safari TP 133 (behind a flag), and I expect them to ship in the first quarter of 2022.

I checked:

https://bugs.chromium.org/p/chromium/issues/detail?id=1095765#c55

Ship CSS Cascade Layers to M99

https://bugzilla.mozilla.org/show_bug.cgi?id=1699215#c6

Target Milestone: --- → 97 Branch

While https://tests.caniuse.com/css-cascade-layers is red in all cases (maybe the test is not totally right?) the codepen https://codepen.io/miriamsuzanne/pen/poweapY is green:

as well as

Thanks! Have updated the test, is green now.


getEditText(int idx) seems not working

From<EMAIL_ADDRESS>on July 29, 2013 13:42:18
Using robotium 4.2
this fails :
assertTrue(solo.getCurrentViews(EditText.class).get(3).isEnabled());
but if I comment out the assertTrue, this works:
solo.enterText(3, "some string");
Original issue: http://code.google.com/p/robotium/issues/detail?id=494

From<EMAIL_ADDRESS>on July 29, 2013 14:06:33
my bad, adding a waitForView and hiding the keyboard did the trick

From<EMAIL_ADDRESS>on July 29, 2013 21:44:10
Status: Invalid


update python bindings, pygw, to allow for newer versions of python greater than 3.7

The current version of python is 3.9. Many still use 3.8. However, error checking in your code will cause it to error out if the version is greater than 3.7.
Thanks

there is a library (or at least at one point was a library) that we depend on that could only work on python <= 3.7 which is where that came in.  I'm not actually the expert on the inner workings of pygw so I just checked in and got that conclusion.  When we get a chance we will revisit and see if there's anything more we can do about that now.

Saw that in the requirements after submitting this issue. I believe that the problem is py4j. Thanks for looking into it


Implement Diff::format_email

The test is a little ugly, but at least it passes :)

Thanks for the quick review! I fixed the formatting errors raised by the initial checks.
I can't seem to figure out why they're still failing.

I can confirm using that patch files created with this method can be parsed by #560 (Diff::parse_buffer).
I can take an input patch file (made using libgit2), parse it, apply it, then get an identical patch file if I output it again.
There are some minor formatting differences with the patch files generated by git format-patch, but they don't affect patch application.

Ok looks good to me, and thanks!
I think with a rustfmt this should be good to go.


Android: Loading big files takes too much time

Describe the bug
Whenever I select a file to send, the loading spinner takes too much time. The larger the file the more time it takes. I think this is because the app is copying the file to its own directory before sending instead of directly opening the said file.
I don't know if this is just the nature of Android file picker but this doesn't happen in apps like Google Chrome. When I pick a large file to upload, it just starts right away.
To reproduce

Go to the send tab
Click on 'File'
Select a large file
Loading spinner spins for a long time

Expected behavior
Should not take too much time to load files
Screenshots
No response
Desktop (please complete the following information)
No response
Smartphone (please complete the following information)

Device: Redmi 9
OS: Android 12
Version: 1.10.0

Additional context
No response

@abe1242, related to #532

@abe1242, related to #532

Ok, I'm closing this issue


change Locale lang in app lunch (main method)

i saved current lang in SharedPreferences key
when app start i get this key and want to set this as my current local
i tray with main method

String currentLang=await AppUtil.currentLang();
var delegate = await LocalizationDelegate.create(
fallbackLocale:currentLang !=null && currentLang != "" ? currentLang : 'en_US',
supportedLocales: ['en_US', 'ar']);

but not work as expected

This is not the correct way to do this. Please see saving/restoring the selected locale for an example.
The fallbackLocale is only used for fallback, not for actually changing the locale.


Use nested paths for use declarations

This commit follows up on Commit 0753b1206b79254b9c71d82ccfcbd2ddb9c00fc2 ("Use nested paths for use declaration") and uses nested paths for cranelift_codegen, and some of the standard library use declarations in wasm2obj.rs and wast.rs.

I’m not particularly set on any style, and I’ll adjust to whatever we decide to follow so it’s up to you guys!

My inclination is to hold off on this right now. Patch review bandwidth is a precious resource, so I'd prefer not to have a lot PRs changing import nesting a few files at a time. If there are unambiguos cleanups, we can still do those, but otherwise my sense is to wait until there's a prevailing sense in the Rust community for how to format imports that we can follow, and then we can format the whole codebase at once, using rustfmt.

My inclination is to hold off on this right now.

That makes sense. I'll close this pr now. Thanks.


Mettre à jour le composant d'annotation NER

NER currently displays a sample text.
We have to find a way to recover user-defined text (with JobDataset task) without writing specific code.


Messed comments in codes due to sources "Encoding" in GBK instead of UTF-8

Hi, cenvin15,
Thanks for your wonderful efforts!
I download your codes. As I read them by NetBeans, files are opened with warnings about "unsafely opened by GBK", and Chinese comments are shown in messed characters in my env although my windows is Chinese with GBK encoding. Maybe I need do more settings of Netbeans.
My projects are developed with Netbeans and their sources are always in UTF-8 encoding because I think our codes are shared with non-Chinese people too.  I write comments in English due to same reason.
In other way, Chinese comments may be the better way to share codes with Chinese developers. So no best choice~
Mara

@Mararsh First, sorry for my poor English and thank you for issue.
I didn't write comments with English becaush of my poor English. I don't think I can comment clear with English. May be only myself can understand my English coments...
If you want to read the codes, you can set encoding to UTF-8.
Thank you again for you issue :-)


Use ViGEm instead of SCPToolkit

Imagine using an unsupported driver whose source code is a horrible monster that the gods fear :eyes:

how do i install ViGEm?


Autoscroll to cursor position after folding or unfolding

When folding or unfolding large blocks, it is possible to move the cursor off screen. Whenever this happens it is annoying and confusing, so this PR changes all code paths that create or destroy folds to autoscroll to the cursor position afterwards.
There were several different fold/unfold code paths, so I decided to weave simple autoscroll assertions into the existing tests.

I have no idea why Travis keeps failing it seems unrelated to me.


[QUESTION] drs certification range

Have you read the documentation?

[x] Yes

Hi, I am testing the drs certification using python and getting large values (1-4).
I tested it on both test data (bunny)
and my own data.
I saw in the paper and  in the code that the range should be in 0.001 range.
I am also seeing that there is no real correlation between these values and actual error.
what certification value range is actually valid?
thanks

Hi @benmatok sorry for the late response. Do you mind share your certification script? That part of the code wasn't as thoroughly tested so it's possible that we made a mistake when porting it from MATLAB to C++.


Update dependencies

Update dependencies
Bump gradle to 7.0, it's a big release to enhance speed of build

Sorry, but as stated in first line of Pull Request Process


Add [OpenVSX] registry badges

Closes #5218

Messages

:book:
:sparkles: Thanks for your contribution to Shields, @IronGeek!

  Generated by :no_entry_sign: dangerJS against 289ccd4d0a3ae2305c4f9939178b6804db337a2b

Thank you for the PR @IronGeek! Have taken an initial pass through this and overall it's looking pretty good. Left inline comments in places where we'll need to make some changes for your review

Hi @calebcartwright, thank you for taking the time to review this PR.
I will look into the inline comments and update as approriate.

Thanks for the updates @IronGeek, two closing thoughts/tweaks, then will be good to merge!

Sorry, prettier usually seems to complain about my inline typing from GitHub :smile: Could you run prettier to fix the formatting/style issue to fix the CI check?

Sorry, prettier usually seems to complain about my inline typing from GitHub  Could you run prettier to fix the formatting/style issue to fix the CI check?

I think I'm running into this issue with the prettier: https://github.com/prettier/prettier/issues/3368
If I run the prettier, it would change this line:
url: `https://open-vsx.org/api/${namespace}/${extension}/${version || ''}`

to this line:
url: `https://open-vsx.org/api/${namespace}/${extension}/${
  version || ''
}`,

This breaks the whole Open VSX service badge functionality.
But, If i skip the prettier... then it will definitely complain again on CI :sweat:
What should I do?

But, If i skip the prettier... then it will definitely complain again on CI sweat
What should I do?

Just to confirm, it functions fine with:
url: `https://open-vsx.org/api/${namespace}/${extension}/${version || ''}`,

but breaks with the other? does pulling url back out into a local variable help?

but breaks with the other? does pulling url back out into a local variable help?

My bad, no line breaking doesn't break any functionality.
It must've been an temporary issue with my network connection to open-vsx.org

Update: The status codes (https://github.com/badges/shields/pull/5815#discussion_r522724667) and error result fields (https://github.com/badges/shields/pull/5815#discussion_r522726269) are fixed now.

Update: The status codes (#5815 (comment)) and error result fields (#5815 (comment)) are fixed now.

Thank you for following up @spoenemann!


python3.pkgs.sphinxHook: fix co-installability of generated documentation

Include full $name of the derivation into docdir, so documentation for
python package "foo" is installed into $out/share/doc/python3.10-foo-1.2.3
instead of just $out/share/doc/foo, where it may conflict with some
other package named "foo" and not-coinstallable with different
versions of the same python package.
Change from $name to $pname was introduced in [1ee5fca], probably as
unindented side-effect of adding support for formats other than html.
@mweinelt

Thanks!


Large Volume Usage By Zookeeper In Cluster Setup

I Setup a cluster following this instruction, and setup 3-shardes and 3-replica cluster successfully (with 3-zookeeper replica).
Then I insert data, and found that the zookeeper volume usage increasing continually sth like this:

each-data-node-volume: 1.5GB
each-zookeeper-node: 5GB

Is this the way the cluster working?
Or how it be working in long term with big volume of data
---Updates----
Now I got ~10BG on each zk node, and 1.8 GB on each clickhouse node.
What is really happening under the hood?
Means if I want to have 100GB data of clickhouse shard, I need 500GB of zookeeper volume usage? How zookeeper can handle that

ZooKeeper log and snapshot usually do not exceed 10GB. You need to allocate 25GB for ZooKeeper node to be safe.


Fix refcounting bug for mdstrs

And importantly, introduce no new atomic ops along this path.
Fixes #6197

Such green.

Please note that due to the green-ness and the P1-ness of this bug, I
merged rather than LGTMing.
On Tue, Apr 26, 2016 at 10:02 PM Craig Tiller<EMAIL_ADDRESS>wrote:

Such green.
—
You are receiving this because you were assigned.
Reply to this email directly or view it on GitHub
https://github.com/grpc/grpc/pull/6303#issuecomment-214970564


On OpenBSD only root can set sticky bit

What is the purpose of this change? What does it change?
Fix tests on OpenBSD. Currently the sticky bit test in internal/restic/node_test.go is broken on OpenBSD. From the man page for sticky(8), only root can set the sticky bit. (Thanks @brycied00d for the man page clue stick :D)
Was the change discussed in an issue or in the forum before?
No.
Checklist

[X] I have read the Contribution Guidelines
[ ] I have added tests for all changes in this PR
[ ] I have added documentation for the changes (in the manual)
[ ] There's a new file in a subdir of changelog/x.y.z that describe the changes for our users (template here)
[X] I have run gofmt on the code in all commits
[X] All commit messages are formatted in the same style as the other commits in the repo
[X] I'm done, this Pull Request is ready for review

Would it make more sense for this test to examine whether it's being run as root (on OpenBSD) and perform the test in that case still? Obviously I don't need to preach what a big no-no it is to run things as root, but it still seems reasonable to provide a way for this test to still be run under the correct circumstances that should result in success.

I thought about making the test check for root.. but from the standpoint of integrating it into ports (which is my goal - https://github.com/jasperla/openbsd-wip/tree/master/sysutils/restic) .. tests will never run as root. I can re-work it to check permissions if that's preferred.

Thanks for giving this a try. We can certainly disable the test for the sticky bit for OpenBSD, but rather than disabling the mode test completely for OpenBSD (which is not a great idea), let's strip the sticky bit for OpenBSD only, in both test.Mode and n2.Mode.

Let me know if you need help with any of this!

Codecov Report

Merging #1611 into master will decrease coverage by 5.31%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1611      +/-   ##
==========================================
- Coverage   51.46%   46.14%   -5.32%
==========================================
  Files         142      142
  Lines       11362    11362
==========================================
- Hits         5847     5243     -604
- Misses       4597     5259     +662
+ Partials      918      860      -58

Impacted Files
Coverage Δ

internal/backend/azure/azure.go
0% <0%> (-78.89%)
:arrow_down:

internal/backend/b2/b2.go
0% <0%> (-77.95%)
:arrow_down:

internal/backend/swift/swift.go
0% <0%> (-77.91%)
:arrow_down:

internal/backend/gs/gs.go
0% <0%> (-73.66%)
:arrow_down:

internal/backend/swift/config.go
36.95% <0%> (-54.35%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 514f1b8...28fdeb4. Read the comment docs.

Updated to only skip testSticky.


fix: supabase integration guide links

Description
It appears this https://docs.powersync.com/integration-guides/supabase link has changed to https://docs.powersync.com/integration-guides/supabase-+-powersync so users were being redirected to the overview page. This fixes the links to map to the correct guide.

Thanks Dom, I saw this old link in the Dashboard too the other day. Can you maybe also add a redirect on the mintlify docs for this - that should ensure existing old links out there will continue to work: https://github.com/powersync-ja/mintlify-docs/blob/docs/mint.json#L428

Perhaps we should add a redirect on the docs site? There may be other sites also using the old link.


COLLECTIONS-853: Change LayerManager to use List and added generics to LayerdedBloomFilter

Changes to the is code:

Added generics to LayeredBloomFilter and LayerManager so that the implementation of the enclosed Bloom filter can be specified.
Modified WrappedBloomfFilter to require copy() implementation.
Changed the LayerManager internal LinkedList declaration to List.

Codecov Report
Attention: Patch coverage is 79.16667% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 81.58%. Comparing base (229425c) to head (6a4d287).
Report is 74 commits behind head on master.

Files
Patch %
Lines

...commons/collections4/bloomfilter/LayerManager.java
75.00%
1 Missing and 4 partials :warning:

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #481      +/-   ##
============================================
- Coverage     81.60%   81.58%   -0.03%
- Complexity     4745     4752       +7
============================================
  Files           295      295
  Lines         13751    13752       +1
  Branches       2022     2021       -1
============================================
- Hits          11222    11219       -3
- Misses         1929     1932       +3
- Partials        600      601       +1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Question: Code coverage complains about this block from the advanceOnSaturate predicate.
            return manager -> {
                BloomFilter bf = manager.last();
                return bf != null && maxN <= bf.getShape().estimateN(bf.cardinality());
            };

The manager should never have an empty list, so manager.last() should always work.  This is defensive programming in case there is a bad cleanup or similar call that makes the list empty.  Should I try to contrive a test that covers this line, or should I not perform the null test and just let and NPE happen if the list is empty?

At present the contract of LayerManager.last() states that it can be null, so the null check is required. However this does not seem to be the intention of LayerManager which should always have 1 layer.
If you think that the layers should never be empty then we should enforce this in documentation and can remove empty checks in first() and last(). Looking at the code, addFilter is called whenever clean-up/clear is performed when the layers are empty. So given this is not meant to be thread-safe (e.g. one thread calls clear while another is calling last) then the intention is to never be empty. Any time the layers are empty is a bug. In this case it may be highlighted by use of a null pointer. So I would be inclined to drop the null checks throughout.

COMMONS-853?

COMMONS-853?

I don't find this.  what is it?

COMMONS-853?

I don't find this. what is it?

You originally named the PR COMMONS-853. I have updated to the title to COLLECTIONS-853.

@aherbert any requested changes for this pull?

@garydgregory @aherbert Any reason not to merge this?

I just want to make sure @aherbert approves before I merge.


DnsHelper for email check #10

Q
A

Is bugfix?
❌

New feature?
✔

Breaks BC?
❌

Tests pass?
✔

Fixed issues
#10

Merged. Thank you!


feat: update description with append model

Codecov Report
Attention: Patch coverage is 95.55556% with 2 lines in your changes missing coverage. Please review.

Project coverage is 90.97%. Comparing base (a89ec7a) to head (542df99).

Files with missing lines
Patch %
Lines

...er/routes/journeys/referral/description/schemas.ts
85.71%
1 Missing :warning:

...journeys/update-referral/description/controller.ts
90.90%
1 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #207      +/-   ##
==========================================
+ Coverage   90.89%   90.97%   +0.08%
==========================================
  Files         213      216       +3
  Lines        3140     3180      +40
  Branches      496      503       +7
==========================================
+ Hits         2854     2893      +39
- Misses        281      282       +1
  Partials        5        5

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


docs: Add note about updating external resources after release

This PR adds a note to the release docs about updating external tools and guides after releasing a new version of Cilium.

This change is

test-docs-please

Coverage decreased (-0.009%) to 41.245% when pulling 6e5f736ca926f0c18bce6642cbad6e6da0c44aec on pr/brb/docs-release-update-guides-step into 43cc0d39940bd4036530f29a8c3850f16ec12503 on master.


KAFKA-14233: disable testReloadUpdatedFilesWithoutConfigChange

disable testReloadUpdatedFilesWithoutConfigChange to fix the build
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

Thanks, LGTM! Shall we open a separate JIRA for the fix?

Sure, will do!

https://issues.apache.org/jira/browse/KAFKA-14242 is created for the fix

All tests passed.

backport to 3.3

Finally got a build without red light

Thanks @showuon!


Timeout while loading project in docker-compose.yml setup.

[2021-09-15 14:29:02,631] [urllib3.connectionpool::urlopen::780] [WARNING] Retrying (Retry(total=1, connect=None, read=None, redirect=None, status=None)) after connection broken by 'NewConnectionError('<urllib3.connection.HTTPSConnection object at 0x7fb1ec28b130>: Failed to establish a new connection: [Errno 110] Connection timed out')': /api/5820521/envelope/
Frontend is available and I can navigate and create a project and load data. But loading a project in the frontend never comes to an end with above log. What is enpoint /api/5820521/envelope/ doing?

@schudoku It's our bug tracker system and these messages could be simply ignored.


MM-13428 Opening channels with unreads has loading indicator placed above unread messages line

Summary
Uses https://github.com/mattermost/mattermost-redux/pull/735 hash for fixing Opening channels with unreads has loading indicator placed above unread messages line
Ticket Link
MM-13428

@sudheerDev cherry-pick this one along with the redux PR


Add treat optionals flag

First of all, thanks for the lib - clean, simple and also a good entry point for learning advanced typescript.
Initially, I wanted to create a flag:
treatOptionals?: 'asUndefined' | 'asOptional' | 'asBoth'

But that would be more complicated, so I ended up with optionalPropertiesForOptionals
Tests weren't working on windows, I fixed that in #9

Thanks for this! I wanted to implement this but decided to wait until someone made an issue for it. I don't have time right now, but I'll look at this later today.

Everything looks good here, but I actually quite like this API:

Initially, I wanted to create a flag
treatOptionals?: 'asUndefined' | 'asOptional' | 'asBoth'

I don't think it would be too hard. I think it would make sense to split this into two properties though: treatOptionalsAsUndefined and treatOptionalsAsOptional. Then there shouldn't be any extra work messing around with options.

By more complicated I meant we need to know parent here, since the flag should only affect objects (and maybe records?).
As far as I understand, zod doesn't provide a way to extract parent type from schema. The closest thing I found is ctx.path from superRefine.
So I've created a flag in store, which I set to true in ObjectType case. It works, tests are passing (thx for vitest btw, testing now is fun). This looks hacky to me and I didn't take the time to think through all possible use cases, so I'd appreciate if you check this.
I don't see any crucial extra work with flags here so I don't see the reason to split. Moreover, such approach would leave opportunity to provide:
`treatOptionalsAsUndefined`: false,
`treatOptionalsAsOptional`: false

i.e. - remove optionals for objects (and objects only). Imo, one should modify the schema beforehand if this desired.
So I ended up with:
treatOptionalsAs?: 'undefined' | 'optional' | 'both'

By more complicated I meant we need to know parent here, since the flag should only affect objects (and maybe records?).

I thought so, but I'm not sure why the parent matters here. If it's a ZodOptional then it should be optional no matter what its parent is.

So I've created a flag in store, which I set to true in ObjectType case

I don't think the parent matters here. This should also not be a store item because those are exposed to users. If we had to add an option like this, it should be an additional parameter only passed in zodToTsNode.

thx for vitest btw, testing now is fun

Yeah, I've been loving it. The watch mode is amazing.

Moreover, such approach would leave opportunity to provide
treatOptionalsAsUndefined: false,
treatOptionalsAsOptional: false

Ah, good point I didn't think about that.

This should also not be a store item because those are exposed to users
And the thing was actually broken for nested primitives since the flag wasn't reset to false. I move it to params and replaced test schema to more complex one.

I'd suggest to treat optionals the same way as z.infer / z.input or z.output does.
const test = z.string().optional();
type Test = z.infer<typeof test>; // string | undefined

const test2 = z.object({
  test: z.string().optional(),
});
type Test2 = z.infer<typeof test2>; // { test?: string | undefined }

@RobinTail I've tried to stay as close to Zod's inferred types as possible, but I guess I didn't notice that. I'd love to support it but I'm honestly not sure how to do it. I tried to write a TS transformer but it didn't work correctly. I can try again but would be nice if someone more experienced with the TS compiler API could help out here.

closing this as fixed in #11


Port Disconnect exception in windows

I have write a code in serial port,  is working on Linux as well as windows. it is common code for both machine,
problems:-

I have disconnect the device in Linux i will get IO Exception.

2 . I have disconnect the device in Window i will get error message in (version 0.0.22)
jtermios.windows.JTermiosImpl$Fail
at jtermios.windows.JTermiosImpl$Port.fail(JTermiosImpl.java:102)
at jtermios.windows.JTermiosImpl.clearCommErrors(JTermiosImpl.java:776)
at jtermios.windows.JTermiosImpl.select(JTermiosImpl.java:872)
at jtermios.JTermios.select(JTermios.java:439)
at purejavacomm.PureJavaSerialPort$3.run(PureJavaSerialPort.java:1226)
at java.lang.Thread.run(Unknown Source)
and also get this type of error (version 0.0.26)
Exception in thread "COM5" com.sun.jna.LastErrorException: [995] The I/O operati
on has been aborted because of either a thread exit or an application request.
at jtermios.windows.WinAPI$Windows_kernel32_lib_Direct.GetOverlappedResu
lt(Native Method)
at jtermios.windows.WinAPI.GetOverlappedResult(WinAPI.java:779)
at jtermios.windows.JTermiosImpl.select(JTermiosImpl.java:937)
at jtermios.JTermios.select(JTermios.java:467)
at purejavacomm.PureJavaSerialPort$3.run(PureJavaSerialPort.java:1222)
at java.lang.Thread.run(Unknown Source)
how to handle this error.

And the same will be true with 0.0.27.  select() in Windows does not throw an IOException as Fail is not an IOException.  This is a good point for consistency across platforms; if the base design is to throw an exception of a certain type (in this case, an IOException), that should be carried through to all platforms including Windows.

@PeteSL yes, I agree with this.

@nyholku Of course, the problem is identifying where an IOException is passed through elsewhere and making it the same throughout (probably should identify in the JTermioImpl Interface definition).  Not an easy task and the simple answer initially is catch Exception, not just IOException until the those situations can be identified.

Yes, probably should be an IOException.  It will likely be some time before the Windows code is fully compared to the reset of the implementations (note a number FIX comments in the Windows source regarding translating errors which would probably address this).  In the mean time, if you catch Exception instead of IOException, you will probably be good until the Windows code is updated to match the other implementations.

Looking again at the original stack trace this is actually the internal PJC thread that crashes because the device disappears.
So the OP cannot catch this exception and the stack trace is coming from the Thread class I presume.
Thinking further, this should not happen with latest code because select() (or any other JTermios method) should never thrown an exception but return an error code.


Medic checks, steps, etc break in envsubst when any environment variables contains {

This seems like it's in the usage of envsubst for allowing environment variables in MEDIC_CONFIG for finding the manifest file.

Fixed in v2.6.2


Issue with MMCV library

CUDA_VISIBLE_DEVICES=0 python tools/test.py projects/configs/VAD/VAD_base.py /path/to/ckpt.pth --launcher none --eval bbox --tmpdir tmp
Traceback (most recent call last):
  File "tools/test.py", line 22, in <module>
    from mmdet3d.apis import single_gpu_test
  File "/home/cthalia/.local/lib/python3.8/site-packages/mmdet3d/__init__.py", line 21, in <module>
    assert (mmcv_version >= digit_version(mmcv_minimum_version)
AssertionError: MMCV==1.4.0 is used but incompatible. Please install mmcv>=2.0.0rc4, <2.2.0.

You need to reinstall mmdetection3d and check that its version is not 0.17, then check that the corresponding dependencies are installed correctly

You need to reinstall mmdetection3d and check that its version is 0.17.1, then check that the corresponding dependencies are installed correctly


Fix example test #916

When we updated the example to nested route, we forgot to update the test too.
#916

Thanks!
I forgot to update the example with the child pages
LGTM