ERROR TypeError: Cannot read property '_checkField' of undefined

[ X ] bug report => search github for a similar issue or PR before submitting
[ ] feature request
[ ] support request
Hello All,
I am trying to wrap ngx-formly in an angular element. I have done that successfully but when I plugging into a plain html file and trying to provide [field] or [formGroup] via input property of my element then facing following error:
custom-button-element.js:4 ERROR TypeError: Cannot read property '_checkField' of undefined
at jc.checkExpressionChange (custom-button-element.js:4)
at jc.ngDoCheck (custom-button-element.js:4)
at custom-button-element.js:4
at custom-button-element.js:4
at li (custom-button-element.js:4)
at Ai (custom-button-element.js:4)
at Object.updateDirectives (custom-button-element.js:4)
at Object.updateDirectives (custom-button-element.js:4)
at ii (custom-button-element.js:4)
at pi (custom-button-element.js:4)
Here is the project that you can regenerate:
https://github.com/LalitKushwah/wrapper-formly
Target File:
test.html at the root location

Now I am getting

what you've done there is passing a string value to the formly fields (see https://github.com/angular/angular/issues/24415#issuecomment-396225443)
try with  the following code:
// formly-wrapper-component.component.html
-- <formly-form [model]="order" [fields]="input">
++ <formly-form *ngIf="input" [model]="order" [fields]="input">

<app-formly-wrapper-component name="text"></app-formly-wrapper-component>
<script>
  document.querySelector('app-formly-wrapper-component').input = [
    {
      fieldGroup: [
        {
          key: 'grid-title-url',
          type: 'input',
          templateOptions: {
            label: 'Grid Title URL',
            description: 'Link to destination for title text in header'
          }
        }
      ]
    }
  ];
</script>


Added Sacramento County CA to counties.csv

Closing as inactive for now, but please feel free to reopen!


Add localization to date picker options

Hello,
After many tries to set localization without success, I decided to add an item in the DatePickerOptions. This solution doesn't need any additional injection.
Could you please, accept my PR?
Gratefully

merged and published. thanks!


Enable external suppliers

There are a number of important tasks to help enable external suppliers, and the in-house team, to work productively and safely.
Firebase

[x] Permissions test: set up new supplier and check assigned permissions. Follow-on task being written up by @KateMJAC
[x] Remove old/unused projects
[x] Remove old/unused collections from Staging database

Github

[x] Permissions. Set up new supplier and test assigned permissions
[x] Remove/archive old repos

Documentation

[x] Intro for new developers
[x] Document firebase permissions
[x] Document github permissions

@KateMJAC the above tasks are all done. Please review the documentation website and then close this ticket when all is ok :)

@warrensearle this all looks great. Thank you for completing against the clock.


Map preferences in the menu to the gear button

Would be nice if we could use the preferences label in the menu (and cmd ,) to open the preferences dialog, maybe you could even disable the gear button all together, makes it cleaner.

Addition: If you could disable the gear button you could put the traffic lights on the same height as 'Goofy'.


For Canada, Remembrance Day is treated differently depending on subdivisions

First, thanks for the great package! Very helpful.
Some Canadian subdivisions use the _add_observed method before adding 'Remembrance Day' as a holiday, whereas others don't use this. The effect is that Remembrance Day falling on a Sunday will have an observed day on the following Monday in 5 subdivisions but not the other 6. I haven't seen anything that these holidays are actually treated differently in this way.
In addition for those that use the self._add_observed() method, they have include_sat=False. I also haven't seen any reference that says this holiday doesn't count for a day in-lieu (i.e., observed) if falling on the Saturday but does if falling on the Sunday.
self._add_observed(self._add_remembrance_day(tr("Remembrance Day")), include_sat=False)
Used by:
NL, NS, NT, PE, SK
_add_subdiv_pe_holidays
self._add_remembrance_day(tr("Remembrance Day"))
Used by:
AB, BC, MB, NB, NU, YT
Recommended fixes:

Change all uses to use self._add_observed() before self._add_remembrance_day() (In Canada)
Set include_sat=True in all uses of self._add_observed() for Remembrance Day (In Canada)

If you agree with the changes, I can make a PR for this.

Hi Tim, thanks for filing this.
Yeah, I can't deny Canada holidays implementation needs some attention (see another recent issue #1439).
BTW, the issue detailed description is much appreciated 👍
I took a quick look and it seems those changes were added by @KJhellico (who is really good in figuring out holidays and respective observance rules). I guess it was done based on this source https://en.wikipedia.org/wiki/Public_holidays_in_Canada

If you agree with the changes, I can make a PR for this.

This would be totally awesome as we always encourage people to submit their contributions. I'd wait for a reply from @KJhellico though to make sure that proposed changes are what we want.
If you have any questions -- just let us know.

@timcashion, thank you for your feedback! I'll take a closer look at this.

I started with Alberta. Official source says nothing about additional holiday if Remebrance Day falls on weekend. The only holiday to be shifted in Alberta is Canada Day (and only if on Sunday):

Canada Day is on July 1 every year except when it falls on a Sunday, then it’s on July 2.

Yes, "Observed" in this project - it's something like "additional day off that appears when holiday falls on non-working day (weekend/Sunday/other holiday etc)". But we are trying to use reliable sources, especially official ones, to determine the rules of this "Observed" calculation.


CI Setup

This repo needs some kind of CI. I'm not sure the best way to test it, but we should at least set up a skeleton with Travis to test that the service can be run and basic functionality works.
Will make it easier to welcome new contributors to help out!

I think I addressed this in #18 . @ntdef I'll leave it to you to decide whether or not you want that PR and whether or not it addresses this issue

oh hey this is done!

Thanks @jameslamb


[Core] make document counters on server side switchable on/off

to see how it affect performance.
also, sometime xdm-counters topic becames full, have to investigate this case further

done


update hedera-sdk-go

Type of change

Bug fix

Description

pull in recent bug fixes in hedera go sdk
Additional details

Related issues

the commits hash somehow differed between dev & master, so close this PR


vstest.console.exe cannot resolve assembly for extension with target framework .net8.0, however dotnet test (vstest.console.dll) resolves it correctly

Description
I'm trying to use the next extension  in my test porject, when I'm running my tests via VS2022 or directly via the vstest.console.exe, it looks like it cannot correctly resolve the extension assembly via the vstest.console.exe:
TpTrace Verbose: 0 : 12032, 1, 2024/07/17, 19:29:47.635,<PHONE_NUMBER>925, vstest.console.exe, MetadataReaderExtensionsHelper: Discovering extensions inside assembly 'ReportPortal.VSTest.TestLogger, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=null' file path 'C:\Users\test\source\repos\test_project\Tests\bin\Debug\net8.0\ReportPortal.VSTest.TestLogger.dll'
TpTrace Information: 0 : 12032, 1, 2024/07/17, 19:29:47.651,<PHONE_NUMBER>464, vstest.console.exe, AssemblyResolver.OnResolve: System.Runtime, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a: Resolving assembly.
at the same time, when I'm running the tests via the dotnet test, it resolves everything correctly
TpTrace Verbose: 0 : 8448, 1, 2024/07/17, 19:29:57.585,<PHONE_NUMBER>270, vstest.console.dll, MetadataReaderExtensionsHelper: Discovering extensions inside assembly 'ReportPortal.VSTest.TestLogger, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=null' file path 'C:\Users\test\source\repos\test_project\Tests\bin\Debug\net8.0\ReportPortal.VSTest.TestLogger.dll'
TpTrace Information: 0 : 8448, 1, 2024/07/17, 19:29:57.586,<PHONE_NUMBER>350, vstest.console.dll, AssemblyResolver.OnResolve: ReportPortal.Shared: Resolving assembly.
the same issue was described for the package here and here
also GenerateBindingRedirectsOutputType true didn't help
Steps to reproduce

Add this extension  and include it into your run settings (for TestAdaptersPaths please use the full path)
Try to run a test via the Test Explorer or the vstest.console.exe

Expected behavior
The assemblies should be resolved correctly, the same how it works via dotnet test
Actual behavior
TpTrace Warning: 0 : 14804, 1, 2024/07/18, 02:17:15.668,<PHONE_NUMBER>026, vstest.console.exe, TestPluginDiscoverer-FileLoadException: Failed to load extensions from file 'C:\Users\test\source\repos\test_project\Tests\bin\Debug\net8.0\ReportPortal.VSTest.TestLogger.dll'.  Skipping test extension scan for this file.  Error: System.IO.FileLoadException: Could not load file or assembly 'System.Runtime, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' or one of its dependencies. The located assembly's manifest definition does not match the assembly reference. (Exception from HRESULT: 0x80131040)
File name: 'System.Runtime, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' ---> System.IO.FileLoadException: Could not load file or assembly 'System.Runtime, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' or one of its dependencies. The located assembly's manifest definition does not match the assembly reference. (Exception from HRESULT: 0x80131040)
File name: 'System.Runtime, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'
at System.Reflection.RuntimeAssembly.nLoad(AssemblyName fileName, String codeBase, Evidence assemblySecurity, RuntimeAssembly locationHint, StackCrawlMark& stackMark, IntPtr pPrivHostBinder, Boolean throwOnFileNotFound, Boolean forIntrospection, Boolean suppressSecurityChecks)
at System.Reflection.RuntimeAssembly.InternalLoadAssemblyName(AssemblyName assemblyRef, Evidence assemblySecurity, RuntimeAssembly reqAssembly, StackCrawlMark& stackMark, IntPtr pPrivHostBinder, Boolean throwOnFileNotFound, Boolean forIntrospection, Boolean suppressSecurityChecks)
at System.Reflection.Assembly.Load(AssemblyName assemblyRef)
at Microsoft.VisualStudio.TestPlatform.Common.ExtensionFramework.TestPluginCache.CurrentDomainAssemblyResolve(Object sender, AssemblyResolveEventArgs args) in //src/Microsoft.TestPlatform.Common/ExtensionFramework/TestPluginCache.cs:line 513
at System.AppDomain.OnAssemblyResolveEvent(RuntimeAssembly assembly, String assemblyFullName)
Diagnostic logs
Added the diagnostic message logs above
Environment
Local: VS2022 (recent Community and recent Preview Version 17.11.0 Preview 4.0), .net8.0,
CI: _tool\VsTest\17.10.0\x64\tools\net462\Common7\IDE\Extensions\TestPlatform

PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.10.0" />
PackageReference Include="MSTest.TestAdapter" Version="3.5.0" />
PackageReference Include="MSTest.TestFramework" Version="3.5.0" />

vstest.console.exe is a .NET Framework application. .NET Framework cannot load .NET assemblies.
The linked extension is targeting .NET Framework and .NET Standard, but the error suggests that you are in fact loading a dll that targets .NET 8.  This won't work, you either have to retarget the extension, or not use it with vstest.console.exe.

vstest.console.exe is a .NET Framework application. .NET Framework cannot load .NET assemblies.
The linked extension is targeting .NET Framework and .NET Standard, but the error suggests that you are in fact loading a dll that targets .NET 8. This won't work, you either have to retarget the extension, or not use it with vstest.console.exe.

the logs that I've provided after the lib update into net8.0, it looks like the problem is related to the target framework for Microsoft.TestPlatform.ObjectModel that probably is not compatible with net8.0


Add initial set of composition puzzles

usda files and explanatory notes on some common composition issues, excerpted from a soon-to-be publicly available presentation on USD composition.

@ablev-nv Ready to land I think?

Let's do it. Thanks @meshula


New topic why migrate wcf to gRPC

Fixes #19011
This new topic is simply a short summary of the advantages of gRPC for WCF developers that also points them to the extensive eBook published for extensive guidance if the reader chooses to get started migrating.   The content here is the summary of advantages taken directly out of the book, and at the end of the summary it points to the eBook.
We generally really like to avoid copying content to put in two places, it affects SEO a bit for starters and they become out of sync. However the summary in the book is already short and to the point of what is needed here.  I put the eBook author in the "author" metadata.

@JamesNK, is this summary and link to the the eBook about what you environed here?   The single page summary that is already in the book was not very long, so I didn't end up making it shorter.  Do you want something different?  This is just draft for now.
Also, do you want it located in TOC menu at the top gRPC level, but perhaps at the bottom?  https://docs.microsoft.com/aspnet/core/grpc/

Also, do you want it located in TOC menu at the top gRPC level, but perhaps at the bottom? docs.microsoft.com/aspnet/core/grpc

Place it next to "Migrate gRPC services from C-core" (near the bottom).

@shirhatti I think this page should mention https://github.com/CoreWCF/CoreWCF. Do you have an opinion?

@shirhatti, go with Jame's suggestion above?  It looks good to me.  CoreWCF still states "Please note that right now, this port is not production ready. We suggest waiting until there are release packages available before using WCF in a production environment.", Should we wait until later or state that up front here as well?


docstrings/sphinx: Support "Other Parameters" sections

Is your feature request related to a problem? Please describe.
The goal is to have a common set of features between all parsers.
Describe the solution you'd like
The Sphinx parser should be able to parse "Other Parameters" sections, if it makes any sense.

Closing for cleanup, but if you'd like to work on this, just ask and I'll reopen!


(lib/AST/GenericEnvironment) no generic environment provided for type with type parameters!

crashes on DEVELOPMENT-SNAPSHOT-2022-09-29-a:
protocol P
{
    subscript<Value>(x:Value) -> Int
    {
        get
    }
}
struct S:P
{
    subscript<Value>(x:Int) -> Value
    {
    }
}

$ swiftc test9.swift
error: compile command failed due to signal 6 (use -v to see invocation)
test9.swift:12:5: error: missing return in subscript expected to return 'Value'
    }
    ^
test9.swift:8:8: error: type 'S' does not conform to protocol 'P'
struct S:P
       ^
swift-frontend: /home/build-user/swift/lib/AST/GenericEnvironment.cpp:239: static swift::Type swift::GenericEnvironment::mapTypeIntoContext(swift::GenericEnvironment *, swift::Type): Assertion `(env || !type->hasTypeParameter()) && "no generic environment provided for type with type parameters"' failed.
Please submit a bug report (https://swift.org/contributing/#reporting-bugs) and include the project and the crash backtrace.
Stack dump:
0.      Program arguments: /home/ec2-user/.swiftenv/versions/DEVELOPMENT-SNAPSHOT-2022-09-29-a/usr/bin/swift-frontend -frontend -c -primary-file test9.swift -target x86_64-unknown-linux-gnu -disable-objc-interop -color-diagnostics -new-driver-path /home/ec2-user/.swiftenv/versions/DEVELOPMENT-SNAPSHOT-2022-09-29-a/usr/bin/swift-driver -empty-abi-descriptor -resource-dir /home/ec2-user/.swiftenv/versions/DEVELOPMENT-SNAPSHOT-2022-09-29-a/usr/lib/swift -module-name test9 -o /tmp/TemporaryDirectory.ZBcDAU/test9-1.o
1.      Swift version 5.8-dev (LLVM 338153f292479fa, Swift b752d7883c26cea)
2.      Compiling with the current language version
3.      While evaluating request TypeCheckSourceFileRequest(source_file "test9.swift")
4.      While type-checking 'S' (at test9.swift:8:1)
5.      While type-checking protocol conformance to 'P' (at test9.swift:1:1) for type 'S' (declared at [test9.swift:8:1 - line:13:1] RangeText="struct S:P
{
    subscript<Value>(x:Int) -> Value
    {
    }
")

I just had a look.... @AnthonyLatsis I see you added this assertion in https://github.com/apple/swift/commit/1cf9622f3206bad5bbd7db21275e639a80685a90 but maybe its too strict?
The code is doing subscript->getDeclContext()->mapTypeIntoContext(...) but the subscript's declaration context (struct S) isn't a generic context in this case, so it trips the assert. Although, if S is generic (i.e. if it was struct S<T>) then it doesn't trip the assert.

I believe the assertion is accurate, i.e., we cannot map a type containing type parameters into a contextual type without a generic environment. Rather, it looks like we’re mapping into the wrong context.

@AnthonyLatsis Hi Anthony, new to Swift. Made an attempt at fixing this. It seems to just require using the subscriptDecl instead of subscriptDecl->getDeclContext()
Please let me know if i missed something.


Confirmation dialog when reverting a saved window

The revert button for reverting the state of a saved window is dangerous -- @killian inadvertenly lost a bunch of tabs when trying it for the first time and suggested a confirmation dialog.

Initial cut at dialog:


route add sorting

example:
router.get('/a/:ddd', function () {});
router.get('/a/bbb',function () {});
If you use this format.You can't access second. Increase routing sorting function. Automating applications

Hi @webIcome sorry we all missed your pull request. It looks like the existing tests are all failing with your change, indicating this is likely not backwards-compatible (and based on what this is trying to accomplish). Since that would men this would need to land in 5.x or later and in he 5.x branch there is no longer any routing code part of this repository, I would suggest re-opening your pull request at https://github.com/pillarjs/router . Be sure to include tests as well :) !


Full fine-tuning code for Falcon

Hi Authors,
Thank you so much for releasing this awesome work, it is really helpful!
Could you please guide me on how to run full fine-tuning for Falcon 7B without using any adapters?
Here you wrote the same script as Lora.

Your fast response is highly appreciated.
Best regards,
Abdelrahman.

@carmocca your input is highly appreciated.

Hi @Amshaker. Just merged support for this, please see the guide in https://github.com/Lightning-AI/lit-gpt/blob/main/howto/finetune_full.md.
Hope that helps!

Hi @carmocca ,
Thank you for merging this request, it is quite helpful.
However, I am not able to do full-finetuning for Falcon-7B using 8 AMD MI250x with 64GB VRAM due to OOM issues. I tried all the tips you mentioned here but still can't fit the model into the memory. The total memory is 64x8=512GB. You mentioned that Falcon-7B needs around 240GB. Could you please let me know the reason or your proposals to do this full fine-tuning?
Thank you so much.
Abdelrahman.


DataBoundaries Changes

@skadhiresan please link pr changes in azure-cli or azure-cli-extensions. Thanks

@kairu-ms https://github.com/Azure/azure-cli/pull/29961 Is this what you are asking for?


move over to baragon client

@tpetr This does a few things:

upgrade baragon version to 0.1.6 and use BaragonClient instead of old LoadBalancerImpl
update vagrant setup for baragon
Don't put non-load-balanced tasks into the lbcleanup queue
INVALID_REQUEST_NOOP should go to a LOAD_BALANCE_FAILED status
make sure failed load balancer update messages make it to the task json

closing, going to reopen against master


Read-Only?

SteemPHP is read-only, I mean i can't create posts etc. right?

@fervi we will be adding create post/comment/upvote/resteem and more fuctions very soon


Make notebooks executable from within the lesson

Something like jupyter-book. It's doable with sphinx-thebe, but the content needs to be entirely in the rst sources. I would like to keep it in the ipynb files, such that they can be reused in other contexts.
See coderefinery/sphinx-lesson#55

Seems switching to sphinx-book-theme makes this work out of the box!


Add hostname path when container is set in 'container' network mode

When a container is running in 'container' network mode, its HostnamePath is not set in initializeNetworking. So the /etc/hostname in the container will be empty. This PR adds the configuration to have correct hostname file.

Can you give us a use case and a test in integration-cli?


Faster prompt eshell

There's no need for a shell or for any complex output parsing. So this is simpler and more efficient.
 I'm open to suggestions on how to refactor things.
The whole sh thing is confusing btw. Avoiding the shell seems like the whole point of using doom-sh.

I approve of this change, but it conflicts with an upcoming rewrite of Doom's CLI, where doom-sh has been replaced with a generalized version. Inspired by this PR I will employ this optimization, but I must turn down the PR. In any case, thanks for bringing it to my attention!


[ConfigTransformer] Ability to skip failed transformations

Initially reported here. When config transformer fails on some file, it's impossible to skip that file. When transforming large, nested, multi-file directory (our configs dir has 600+ YAML files and many levels of nesting), it leads to situation when sub-directories / sub-files have to be transformed with explicit commands.
It's cumbersome and takes time to manually invoke transformation for each path after that failing one.
Expected behavior
It's possible to use some kind of --skip-failures and continue transformation of the other files. Summary of failed files could be displayed at the end of the output.

Silently skipping files on failure would be unexpected behavior.
Intead, the failures must be resolved to work propperly.

But if you have hundreds of files you would like to transform all that can be handled and in the end focus on those that are failing. Keeping original file without transformation is totally fine in this scenario, as I continued transforming files but with explicit paths (which took much longer). Sometimes the failure was caused by something that wasn't even clear for me (Argument 1 passed to Symplify\PhpConfigPrinter\NodeFactory\Service\ServiceOptionNodeFactory::shouldSkip() must be of the type string, int given) and I didn't even want to fix it on my side. I wanted to skip it and such option really would help me and would save my time.

That looks like a bug to me with wrong type. It must be fixed.

I know, but the point is that from the user's perspective it's probably not something that can be fixed (or at least it's not that explicit to find what's causing the issue). It really would be good to skip those files and continue with the others without need to iterate through directory structure.


bump stm32f1

Bump stm32f1 dependency (coming soon). Fix some warnings.

cc @TheZoq2
cc @therealprof


[docs] Fix Nav components subsections to be open by default

[ ] I have followed (at least) the PR section of the contributing guide.

😆⚖
expect(document.querySelectorAll('.algolia-lvl0').length).toBe(1) // 🔥KO

Oops, didn't realise the algolia logic was also broken. Hope I've correctly understood the desired output.

I believe the following solve your problem and mine. Let me know.


Change the fault members identifying way

When same host having more than one instance and if one instance goes
down fault member map contain the host name. It is a bug. It must be
unique for each instance. Change identifier to mamber_id witch unique
one in conf file

Seems something went wrong with this PR. Why there are 58 commits?

I got some unnecessary commits to my git repo. So I roll back those.

I guess you can do the following;

take this diff
reset your local git repo branch (sajithswa:master) with apache master branch (apache:master)
apply the diff
send the PR

Since you have sent a different PR with these changes, can you please close this PR?

Sure.


Can't seem to login when site requires __RequestVerificationToken

Hi there
Thanks for your library. I do have an issue where I'm trying to login to an asp.net mvc website that has __RequestVerificationToken. It seems if I disable antiforgery token I'm able to login.
So basically

Request a page
Navigate to the login page
I can see the __RequestVerificationToken coookie
I then submit the form with username and password
I get the error: Empty or invalid anti forgery header token

I'm using the ASP.NET Bolierplate. I think it submits forms using ajax is that a reason why it's not working?

Well, usually these pages do not require JS, so I just assume that this is not the reason.
I cannot see your configuration (please make sure to submit a MWE in order to be helpful), therefore I cannot comment, but if you, e.g., don't include cookies this cannot work (I assume you know why - so I skip anti forgery token basics).


Weird page layout

The layout on this page looks broken

Do you mean the big gap?
It should be like this, but they couldn't provide the mandate data and it was too laborious for us to do it again


[DDW-807] Detect and display dates in users date format

This PR fixes all date formats and renders them in user locale format.
Todos

[ ] Recheck if all date formats are correct

Screenshots

Testing Checklist

Slack QA thread
[ ] Test if all date formats are rendering in the correct way

Review Checklist
Basics

[ ] PR has been assigned and has appropriate labels (feature/bug/chore, release-x.x.x)
[ ] PR is updated to the most recent version of the target branch (and there are no conflicts)
[ ] PR has a good description that summarizes all changes and shows some screenshots or animated GIFs of important UI changes
[ ] CHANGELOG entry has been added to the top of the appropriate section (Features, Fixes, Chores) and is linked to the correct PR on GitHub
[ ] Automated tests: All acceptance and unit tests are passing (yarn test)
[ ] Manual tests (minimum tests should cover newly added feature/fix): App works correctly in development build (yarn dev)
[ ] Manual tests (minimum tests should cover newly added feature/fix): App works correctly in production build (yarn package / CI builds)
[ ] There are no flow errors or warnings (yarn flow:test)
[ ] There are no lint errors or warnings (yarn lint)
[ ] There are no prettier errors or warnings (yarn prettier:check)
[ ] There are no missing translations (running yarn manage:translations produces no changes)
[ ] Text changes are proofread and approved (Jane Wild / Amy Reeve)
[ ] Japanese text changes are proofread and approved (Junko Oda)
[ ] UI changes look good in all themes (Alexander Rukin)
[ ] Storybook works and no stories are broken (yarn storybook)
[ ] In case of dependency changes yarn.lock file is updated

Code Quality

[ ] Important parts of the code are properly commented and documented
[ ] Code is properly typed with flow
[ ] React components are split-up enough to avoid unnecessary re-renderings
[ ] Any code that only works in main process is neatly separated from components

Testing

[ ] New feature/change is covered by acceptance tests
[ ] New feature/change is manually tested and approved by QA team
[ ] All existing acceptance tests are still up-to-date
[ ] New feature/change is covered by Daedalus Testing scenario
[ ] All existing Daedalus Testing scenarios are still up-to-date

After Review

[ ] Merge the PR
[ ] Delete the source branch
[ ] Move the ticket to done column on the YouTrack board
[ ] Update Slack QA thread by marking it with a green checkmark

Is it testable in netlify?

No @a-rukin

@DeeJayElly can you please think of test-cases for this change?
E.g. what date formats should we expect with different language settings on the OS level.
Thanks!

@DeeJayElly seems like we have Flow issues too. Can you please fix those 🙏

@DeeJayElly wouldn't it be better if we would set the moment.js global locale based on the detectSystemDateLocale method response 🙏

@DeeJayElly wouldn't it be better if we would set the moment.js global locale based on the detectSystemDateLocale method response 🙏

I am doing that exactly that. waiting on the response, collecting the value and parsing it :)

@DeeJayElly I was referring to: https://momentjs.com/docs/#/i18n/changing-locale/
In the code changes, I can only see that we are using moment.localeData.
Also, can you please make sure we use correct localization for the date shown on the paper wallet certificate? https://github.com/input-output-hk/daedalus/blob/develop/source/renderer/app/containers/wallet/dialogs/paper-wallet-certificate/InstructionsDialogContainer.js#L36

@DeeJayElly seems like we have Flow issues too. Can you please fix those 🙏

Done

@DeeJayElly after discussing this approach with @darko-mijic we have come to a conclusion that it simply won't be good enough. Instead of trying to identify user's date-format OS settings we will add the date-format selectbox with most common options to the "General Settings" screen. A new card will be created for this implementation.
This PR will now be closed without merging.
Thanks for your efforts!


add variable through file formatter

The PR enables file formatter to add a variable to existing file
Description

Related Issue

Motivation and Context

How Has This Been Tested?

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Trivial change (affects only documentation or cleanup)

Checklist:

[ ] I have tested this change with a run of GEOSgcm (if non-trivial)
[x] I have added one of the required labels (0 diff, 0 diff trivial, 0 diff structural, non 0-diff)
[ ] I have updated the CHANGELOG.md accordingly following the style of Keep a Changelog

@tclune Why the test fails even I just add an empty test ?

It suddenly passes all tests

Sorry -  I fell behind on monitoring MAPL issues.  The @tclune should have gotten it into my priority inbox, but ... apparently not.   Must be a bug in my filters.   Let me know if there is something that needs my attention.

@tclune Before this PR, MAPL cannot add variables to an existing netcdf file ( it can create a new one). This PR adds that function. It helps gigatraj when users are trying to add some extra variables to an existing particles's position file.

@weiyuan-jiang Do you think this is ready to go?


Gh 824 flink library

Codecov Report

Merging #1037 into develop will increase coverage by 10.61%.
The diff coverage is n/a.

@@              Coverage Diff               @@
##             develop    #1037       +/-   ##
==============================================
+ Coverage      62.15%   72.76%   +10.61%
+ Complexity      1141       78     -1063
==============================================
  Files            529      142      -387
  Lines          15771     5041    -10730
  Branches        1831      619     -1212
==============================================
- Hits            9802     3668     -6134
+ Misses          5199     1122     -4077
+ Partials         770      251      -519

Impacted Files
Coverage Δ
Complexity Δ

...operation/handler/DeleteNamedOperationHandler.java

...ore/operationdeclaration/OperationDeclaration.java

...ava/uk/gov/gchq/gaffer/data/IsEntityValidator.java

...er/store/operation/handler/compare/MinHandler.java

...gov/gchq/gaffer/serialisation/FloatSerialiser.java

...java/uk/gov/gchq/gaffer/commonutil/StringUtil.java

.../element/comparison/ElementPropertyComparator.java

...named/operation/handler/NamedOperationHandler.java

...er/spark/examples/GetRDDOfAllElementsExample.scala

...ava/uk/gov/gchq/gaffer/store/ElementValidator.java

... and 375 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 626a864...fce36d0. Read the comment docs.


Return the instance from validate

The validate function currently returns None. Returning the instance allows the user to use validate in a function chain, for example:
try:
    return process(validate(deserialize(string)))
except jsonschema.ValidationError:
    ...

Hey -- thanks for the PR, it's appreciated.
It's a bit late in jsonschema's life to make this kind of change. If it were being rewritten from scratch it's very likely this is how this would have looked, and someday if/when Seep gets some love, it has an API like this, but at this point I don't think I want to take this unfortunately.
There's a few reasons other than just inertia -- they're minor but I'll mention them -- one is that in exchange for being able to write the code you put up there (which I'd call only a millimeter better than just using separate lines), someone now will overextend their except block and try to cover exceptions from all 3 functions at the same time -- often incorrectly so, and then be hit by bugs when exceptions they don't expect come from functions they don't expect. ValueError is a great example, since that is the awful exception the json module blesses us with and is a good possibility for your deserialize. There's also another minor one that typically stuff that returns things gets named in past tense, so validated here instead of validate. And lastly, I'm sure for better or worse someone has (incorrectly) written a line of code that looks like if jsonschema.validate(...) is None in attempting to test whether things passed validation, which turns this into a very slight issue of backwards compatibility, since None is a perfectly valid instance. These all (even together) were probably ignorable, but pointing them out as well since they do at least come to mind.
Overall I think this is really appreciated, and definitely a reasonable change to propose, but I'd push you towards contributing within Seep if you're trying to make something that looks like this happen!

Thanks for the thought-out reply.
Worth mentioning that since Python 3.5 the json module raises a more specific JSONDecodeError.
For now I can write my own wrapper jsonschema.validate.

Ah, good to know!
On Sun, Sep 23, 2018, 06:30 Beau Barker<EMAIL_ADDRESS>wrote:

Thanks for the thought-out reply.
Worth mentioning that since Python 3.5 the json module raises a more
specific JSONDecodeError.
For now I can write my own wrapper jsonschema.validate.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/Julian/jsonschema/pull/462#issuecomment-423806529,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAUIXv9DQ_vd-0lImd07i_jqnr7vVA0Uks5ud2LUgaJpZM4W1F0O
.


Warning in testAssume()

There's this function is asserts.t.cpp:
int testAssume( int i, std::vector<int> const& v )
{
    // This should compile without warnings.
    gsl_ASSUME( i >= 0 && static_cast<std::size_t>(i) < v.size() );
    return v.at( i );
}

Despite the comment, the return statement generates a warning ("conversion from unsigned to signed int", however it is phrased in different compilers).
The warning itself is pretty easy to fix (just add static_cast, duh), but the comment worries me: is v.at() supposed to handle a signed argument? Or does the comment talk about another warning? (Also, why aren't warnings treated as errors in the Travis builds to catch these things early?)

The warning itself is pretty easy to fix (just add static_cast, duh), but the comment worries me: is v.at() supposed to handle a signed argument? Or does the comment talk about another warning?

The test was added in commit https://github.com/martinmoene/gsl-lite/commit/97fb51f782afb5df2618a8fa2941ec9807a6f86b which explains it:

Use __builtin_unreachable() instead of __builtin_assume() for Clang
__builtin_assume() warns about possible side effects (cf.
https://github.com/microsoft/clang/blob/master/test/Sema/builtin-assume.c),
which is generally helpful, but the warning is produced even if the
optimizer will later inline the expression and find it free of side-
effects, cf. https://gcc.godbolt.org/z/ZcKfbp .

The comment should have conveyed this information too; I'll add it with my next PR (and also the missing static_cast<>(); thanks for pointing it out).

(Also, why aren't warnings treated as errors in the Travis builds to catch these things early?)

I agree that this is something we should do. I plan to look at CI soon (something I'm not very experienced with), to add more configurations (e.g. VS 2019), and also to make warnings build-breaking.

Thanks for the answer! The comment referring to another warning was my first guess, but I wanted to make sure. :) I also do not have much experience with Travis and AppVeyor (we use TeamCity and custom build scripts), but they seem nicely configurable, and easy to use systems.

Comment was added in https://github.com/martinmoene/gsl-lite/commit/b81d806aeddc9d4b0c475241f92135e35b283b8b (PR #202).


enhancement Support limit user connection by ip

Proposed changes
Issue Number: close #xxx
In some cases, multiple services may use a common account, but the service may not be able to control the number of connections well, and we need to restrict it in the doris.
Such as prod and stage environment use common user, but stage database connection use too many due to user connection too many.
This parameter can be used to refine user connection limits.
The use way as follow
SET PROPERTY FOR 'root' 'max_user_ip_connections' = '50';

You can use it control server connect number per ip(such as podIp in k8s) and control it concurrent.

run buildall

run buildall

run buildall

run buildall

run buildall

run buildall

run p0


chore: various fixes found by Gabriele

3a80d130f83c4e9c60b0e5da1eabbc0d96e96d8a contains most of these, plus some formatting changes

#244  👈
master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @rphmeier and the rest of your teammates on  Graphite


Update Contributing and Code of Conduct

I have updated Contributing and Code of Conduct file.

Hey, You have two points numbered as 8. Please check once.

Hey, You have two points numbered as 8. Please check once.

Sorry for the inconvenience. I have corrected it now

Nice :)


Bugfix/578 allow chunked read stream write operations

Relates to #578. FYI @JonasBenz.

Relates to #578. FYI @JonasBenz.

Oh wow, thanks a lot for your effort.

@galvesribeiro Is there anything against adopting the changes, see #581, #578, #554?

No. I believe they are good. Please rebase it on the main branch and force push and we can merge it to push a release.
Thanks!

No. I believe they are good. Please rebase it on the main branch and force push and we can merge it to push a release.
Thanks!

Great, thanks a lot 🙏. I'll rebase and push the changes tomorrow.

I have added my changes that refactors the TestFixture too. The fixture now uses IAsyncLifetime and the async API. The test classes now access the fixture properties consistently.

@galvesribeiro Is there anything missing? Could you adopt the changes, please?
Just let me know if I can take care of any specific following task, otherwise I will take a look at another open pull requests or issue.

Sorry for the delay. LGTM. Is there any other PR you wanna go with the same build?

Sorry for the delay. LGTM. Is there any other PR you wanna go with the same build?

No problem. No, not for now. Having the last two PRs helps us a lot to continue. I’ll look through the other PRs and issues afterwards.


Changed azure authz support to use v1beta1 version instead of v1 for SubjectAccessReview

Making this change as even though we are expecting v1 version of SAR, we are still getting v1beta1 version. Also, in v1beta1 version there is k8s bug where instead of "groups" SAR decodes it as "group". Even though this is fixed in v1, we are not being able to use v1 version. Will be raising a bug on k8s on this regarding how we can use v1 version. Till then as we don't want to explicity call graph every time to get the groups, we are changing to use v1beta1 version so that we can get the groups the user is part of
Signed-off-by: Anumita Shenoy<EMAIL_ADDRESS>

K8s bug: https://github.com/kubernetes/kubernetes/issues/91698

@weinong , @tamalsaha , could you review this PR?

relate to https://github.com/kubernetes/kubernetes/pull/85441


Volsnap error 16

When Im using cloudbase and create a shadow copy , when i restart my machine I get this error which tells me the disks I added getting force dismount which cause the deletion of the shadow copies I made.
When I comment the line of the metadata in the config file the shadow copies doesnt get deleted.
Any idea of what can fix it?

Hello @Lior97,
Can you give some details on the comment the line of the metadata in the config file ? Also, if you can give more details on how to reproduce the issue.
There might be an issue related to https://cloudbase-init.readthedocs.io/en/1.1.6/plugins.html#san-policy-config-main, but I need more information on how to reproduce the issue.
Thank you,
Adrian Vladu

metadata_services=cloudbaseinit.metadata.services.configdrive.ConfigDriveService,
בתאריך יום ב׳, 5 באוג׳ 2024, 11:17, מאת LioR @.***>:

In the config file of the cloudbase there's a line that enables the
metadata, when i comment it the shadow copies doesn't disappear afer reboot.
Also when we disable the cloudbase service we manage to keep the copies.
בתאריך יום ב׳, 5 באוג׳ 2024, 11:02, מאת Adrian Vladu <
@.***>:

Hello @Lior97 https://github.com/Lior97,
Can you give some details on the comment the line of the metadata in the
config file ? Also, if you can give more details on how to reproduce the
issue.
There might be an issue related to
https://cloudbase-init.readthedocs.io/en/1.1.6/plugins.html#san-policy-config-main,
but I need more information on how to reproduce the issue.
Thank you,
Adrian Vladu
—
Reply to this email directly, view it on GitHub
https://github.com/cloudbase/cloudbase-init/issues/149#issuecomment-2268426154,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AR4JQEHON34RYQRT7PGQDV3ZP4WSJAVCNFSM6AAAAABLTT4ACSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENRYGQZDMMJVGQ
.
You are receiving this because you were mentioned.Message ID:
@.***>

Conf file :
[DEFAULT]
metadata_file=meta_data.json
userdata_file=user_data
username="NT AUTHORITY\SYSTEM"
groups=Administrators
first_logon_behaviour=no
check_latest_version=false
enable_automatic_updates=false
stop_service_on_exit=false
cdrom=true
bsdtar_path=C:\Program Files\Cloudbase
Solutions\Cloudbase-Init\bin\bsdtar.exe
mtools_path=C:\Program Files\Cloudbase Solutions\Cloudbase-Init\bin
verbose=true
debug=true
log_dir=C:\Program Files\Cloudbase Solutions\Cloudbase-Init\log
log_file=cloudbase-init.log
default_log_levels=comtypes=INFO,suds=INFO,iso8601=WARN,requests=WARN
userdata_save_path=C:\Windows\Temp\CloudBaseData
metadata_services=cloudbaseinit.metadata.services.configdrive.ConfigDriveService,cloudbaseinit.metadata.services.base.EmptyMetadataService
plugins=cloudbaseinit.plugins.common.userdata.UserDataPlugin
the cloudbase log i`ll send later, my co-worker working on another thing
right now and he cant focus on that atm.
On Mon, 5 Aug 2024 at 11:46, Adrian Vladu @.***> wrote:

Can you also share the cloudbase-init configuration files and logs when
the issue appears? Also, if you can share how the shadow copied were
created, to try to reproduce the issue.
—
Reply to this email directly, view it on GitHub
https://github.com/cloudbase/cloudbase-init/issues/149#issuecomment-2268508827,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AR4JQEHB6RTQNOG67VMZ2NTZP43VRAVCNFSM6AAAAABLTT4ACSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENRYGUYDQOBSG4
.
You are receiving this because you were mentioned.Message ID:
@.***>

Thanks. I have tried to reproduce the issue, but could not so far, all the extra volumes I added were showing the shadow copies fine after cloudbase-init run and a reboot.

which os version do you using?
On Mon, 5 Aug 2024 at 13:38, Adrian Vladu @.***> wrote:

Thanks. I have tried to reproduce the issue, but could not so far, all the
extra volumes I added were showing the shadow copies fine after
cloudbase-init run and a reboot.
—
Reply to this email directly, view it on GitHub
https://github.com/cloudbase/cloudbase-init/issues/149#issuecomment-2268754658,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AR4JQEEIZEGH7WXXSY2YQDLZP5I2PAVCNFSM6AAAAABLTT4ACSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENRYG42TINRVHA
.
You are receiving this because you were mentioned.Message ID:
@.***>

which os version do you using?
…
On Mon, 5 Aug 2024 at 13:38, Adrian Vladu @.> wrote: Thanks. I have tried to reproduce the issue, but could not so far, all the extra volumes I added were showing the shadow copies fine after cloudbase-init run and a reboot. — Reply to this email directly, view it on GitHub <#149 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AR4JQEEIZEGH7WXXSY2YQDLZP5I2PAVCNFSM6AAAAABLTT4ACSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENRYG42TINRVHA . You are receiving this because you were mentioned.Message ID: @.>

I ran a small test with the 10.0.20348 Windows Server 2022 Datacenter trial version. To continue the debug, please provide the following:

OS version (systeminfo.exe)
disk information (get-diskdrive) + details on what the disk type is, how the disks are attached or detached during boot / after boot. Also, any details if your environment is baremetal or virtualized (disk types, virtualization type, etc). More, the better.
how the Windows image has been created and if there is any special customization related the SAN policy(diskpart> san).
cloudbase-init logs
any other information that you consider to be relevant to be able to reproduce the environment and the issue
what is the error message (or printscreen) and what is the desired outcome
is the issue happening at every boot or just happens in certain conditions?

Once we have the full information,

OS Version : 10.0.20348
Disk info : Thin/Thick (Didn`t work with both), Virtualized, qcow2
Windows image: cloudbase, vm-tools , qemu-agent installations + sysprep
(also tried shadow copy without sysprep and didnt work)
The error message that I see in the event viewer after restart is this :
Volsnap 16: “The shadow copies of volume D: were aborted because D: which
contains storage for this shadow copy was force dismounted”
This problem happens in every boot, if i disable cloudbase service/comment
the metadata in the config file it doesn't happen.
P.S The deletion of the shadow copies effect only for new added disks
(doesn't happen on C), after reboot I cant see the copy but I can see it
takes place on the disk.
On Mon, 5 Aug 2024 at 15:39, Adrian Vladu @.***> wrote:

which os version do you using?
… <#m_5028423060229492875_>
On Mon, 5 Aug 2024 at 13:38, Adrian Vladu @.> wrote: Thanks. I have
tried to reproduce the issue, but could not so far, all the extra volumes I
added were showing the shadow copies fine after cloudbase-init run and a
reboot. — Reply to this email directly, view it on GitHub <#149 (comment)
https://github.com/cloudbase/cloudbase-init/issues/149#issuecomment-2268754658>,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AR4JQEEIZEGH7WXXSY2YQDLZP5I2PAVCNFSM6AAAAABLTT4ACSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENRYG42TINRVHA
https://github.com/notifications/unsubscribe-auth/AR4JQEEIZEGH7WXXSY2YQDLZP5I2PAVCNFSM6AAAAABLTT4ACSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENRYG42TINRVHA
. You are receiving this because you were mentioned.Message ID: @.>
I ran a small test with the 10.0.20348 Windows Server 2022 Datacenter
trial version. To continue the debug, please provide the following:

OS version (systeminfo.exe)
disk information (get-diskdrive) + details on what the disk type is,
how the disks are attached or detached during boot / after boot. Also, any
details if your environment is baremetal or virtualized (disk types,
virtualization type, etc). More, the better.
how the Windows image has been created and if there is any special
customization related the SAN policy(diskpart> san).
cloudbase-init logs
any other information that you consider to be relevant to be able to
reproduce the environment and the issue
what is the error message (or printscreen) and what is the desired
outcome
is the issue happening at every boot or just happens in certain
conditions?

Once we have the full information,
—
Reply to this email directly, view it on GitHub
https://github.com/cloudbase/cloudbase-init/issues/149#issuecomment-2268978274,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AR4JQEHWQW7UEWJD3LMIFC3ZP5XA3AVCNFSM6AAAAABLTT4ACSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENRYHE3TQMRXGQ
.
You are receiving this because you were mentioned.Message ID:
@.***>

The cloudbase-init service should not do in any way a force dismount of the disk.
One possibility, from the config file you shared, is that the only enabled plugin might do something: plugins=cloudbaseinit.plugins.common.userdata.UserDataPlugin. But the run logs are needed to confirm or not this possibility.
Also, is it possible to share the userdata script that is being run?

conf:
[DEFAULT]
metadata_file=meta_data.json
userdata_file=user_data
username="NT AUTHORITY\SYSTEM"
groups=Administrators
first_logon_behaviour=no
check_latest_version=false
enable_automatic_updates=false
stop_service_on_exit=false
cdrom=true
bsdtar_path=C:\Program Files\Cloudbase Solutions\Cloudbase-Init\bin\bsdtar.exe
mtools_path=C:\Program Files\Cloudbase Solutions\Cloudbase-Init\bin
verbose=true
debug=true
log_dir=C:\Program Files\Cloudbase Solutions\Cloudbase-Init\log
log_file=cloudbase-init.log
default_log_levels=comtypes=INFO,suds=INFO,iso8601=WARN,requests=WARN
userdata_save_path=C:\Windows\Temp\CloudBaseData
metadata_services=cloudbaseinit.metadata.services.configdrive.ConfigDriveService,cloudbaseinit.metadata.services.base.EmptyMetadataService
plugins=cloudbaseinit.plugins.common.userdata.UserDataPlugin
og:
2024-08-06 10:01:02.744 776 INFO cloudbaseinit.init [-] Cloudbase-Init version: 1.1.4
2024-08-06 10:01:02.744 776 DEBUG cloudbaseinit.utils.classloader [-] Loading class 'cloudbaseinit.plugins.common.userdata.UserDataPlugin' load_class C:\Program Files\Cloudbase Solutions\Cloudbase-Init\Python\lib\site-packages\cloudbaseinit\utils\classloader.py:27
2024-08-06 10:01:02.775 776 INFO cloudbaseinit.init [-] Executing plugins for stage 'PRE_NETWORKING':
2024-08-06 10:01:02.775 776 DEBUG cloudbaseinit.utils.classloader [-] Loading class 'cloudbaseinit.plugins.common.userdata.UserDataPlugin' load_class C:\Program Files\Cloudbase Solutions\Cloudbase-Init\Python\lib\site-packages\cloudbaseinit\utils\classloader.py:27
2024-08-06 10:01:02.775 776 INFO cloudbaseinit.init [-] Executing plugins for stage 'PRE_METADATA_DISCOVERY':
2024-08-06 10:01:02.775 776 DEBUG cloudbaseinit.utils.classloader [-] Loading class 'cloudbaseinit.metadata.services.configdrive.ConfigDriveService' load_class C:\Program Files\Cloudbase Solutions\Cloudbase-Init\Python\lib\site-packages\cloudbaseinit\utils\classloader.py:27
2024-08-06 10:01:02.791 776 DEBUG cloudbaseinit.utils.classloader [-] Loading class 'cloudbaseinit.metadata.services.osconfigdrive.windows.WindowsConfigDriveManager' load_class C:\Program Files\Cloudbase Solutions\Cloudbase-Init\Python\lib\site-packages\cloudbaseinit\utils\classloader.py:27
2024-08-06 10:01:02.791 776 DEBUG cloudbaseinit.utils.classloader [-] Loading class 'cloudbaseinit.osutils.windows.WindowsUtils' load_class C:\Program Files\Cloudbase Solutions\Cloudbase-Init\Python\lib\site-packages\cloudbaseinit\utils\classloader.py:27
2024-08-06 10:01:02.791 776 DEBUG cloudbaseinit.metadata.services.osconfigdrive.windows [-] Looking for Config Drive iso in hdd with expected label config-2 get_config_drive_files C:\Program Files\Cloudbase Solutions\Cloudbase-Init\Python\lib\site-packages\cloudbaseinit\metadata\services\osconfigdrive\windows.py:221
2024-08-06 10:01:02.807 776 DEBUG cloudbaseinit.metadata.services.osconfigdrive.windows [-] Looking for Config Drive iso in partition with expected label config-2 get_config_drive_files C:\Program Files\Cloudbase Solutions\Cloudbase-Init\Python\lib\site-packages\cloudbaseinit\metadata\services\osconfigdrive\windows.py:221
2024-08-06 10:01:02.947 776 WARNING cloudbaseinit.metadata.services.osconfigdrive.windows [-] ISO extraction failed on <Partition: \?\GLOBALROOT\Device\Harddisk0\Partition2> with WindowsCloudbaseInitException("Cannot open file: 'The process cannot access the file because it is being used by another process.'"): cloudbaseinit.exception.WindowsCloudbaseInitException: Cannot open file: 'The process cannot access the file because it is being used by another process.'
2024-08-06 10:01:02.947 776 DEBUG cloudbaseinit.metadata.services.osconfigdrive.windows [-] Looking for Config Drive iso in cdrom with expected label config-2 get_config_drive_files C:\Program Files\Cloudbase Solutions\Cloudbase-Init\Python\lib\site-packages\cloudbaseinit\metadata\services\osconfigdrive\windows.py:221
2024-08-06 10:01:02.947 776 DEBUG cloudbaseinit.metadata.services.osconfigdrive.windows [-] Looking for a Config Drive with label 'config-2' on 'D:'. Found mismatching label 'None'. _check_for_config_drive C:\Program Files\Cloudbase Solutions\Cloudbase-Init\Python\lib\site-packages\cloudbaseinit\metadata\services\osconfigdrive\windows.py:68
2024-08-06 10:01:02.947 776 DEBUG cloudbaseinit.metadata.services.osconfigdrive.windows [-] Looking for Config Drive vfat in hdd with expected label config-2 get_config_drive_files C:\Program Files\Cloudbase Solutions\Cloudbase-Init\Python\lib\site-packages\cloudbaseinit\metadata\services\osconfigdrive\windows.py:221
2024-08-06 10:01:03.009 776 DEBUG cloudbaseinit.utils.windows.vfat [-] Could not retrieve label for VFAT drive path '\\.\PHYSICALDRIVE1' is_vfat_drive C:\Program Files\Cloudbase Solutions\Cloudbase-Init\Python\lib\site-packages\cloudbaseinit\utils\windows\vfat.py:45
2024-08-06 10:01:03.009 776 DEBUG cloudbaseinit.utils.windows.vfat [-] mlabel failed with error b"init :: sector size (190) not a small power of two\r\nCannot initialize '::'\r\nC:\Program Files\Cloudbase Solutions\Cloudbase-Init\bin\mlabel: Cannot initialize drive\r\n" is_vfat_drive C:\Program Files\Cloudbase Solutions\Cloudbase-Init\Python\lib\site-packages\cloudbaseinit\utils\windows\vfat.py:47
2024-08-06 10:01:03.009 776 DEBUG cloudbaseinit.utils.windows.vfat [-] Could not retrieve label for VFAT drive path '\\.\PHYSICALDRIVE0' is_vfat_drive C:\Program Files\Cloudbase Solutions\Cloudbase-Init\Python\lib\site-packages\cloudbaseinit\utils\windows\vfat.py:45
2024-08-06 10:01:03.009 776 DEBUG cloudbaseinit.utils.windows.vfat [-] mlabel failed with error b"init :: sector size (190) not a small power of two\r\nCannot initialize '::'\r\nC:\Program Files\Cloudbase Solutions\Cloudbase-Init\bin\mlabel: Cannot initialize drive\r\n" is_vfat_drive C:\Program Files\Cloudbase Solutions\Cloudbase-Init\Python\lib\site-packages\cloudbaseinit\utils\windows\vfat.py:47
2024-08-06 10:01:03.009 776 DEBUG cloudbaseinit.metadata.services.osconfigdrive.windows [-] Looking for Config Drive vfat in partition with expected label config-2 get_config_drive_files C:\Program Files\Cloudbase Solutions\Cloudbase-Init\Python\lib\site-packages\cloudbaseinit\metadata\services\osconfigdrive\windows.py:221
2024-08-06 10:01:03.009 776 DEBUG cloudbaseinit.metadata.services.osconfigdrive.windows [-] Looking for a Config Drive with label 'config-2' on '\?\Volume{1f7df349-0000-0000-0000-100000000000}'. Found mismatching label 'System Reserved'. _check_for_config_drive C:\Program Files\Cloudbase Solutions\Cloudbase-Init\Python\lib\site-packages\cloudbaseinit\metadata\services\osconfigdrive\windows.py:68
2024-08-06 10:01:03.009 776 DEBUG cloudbaseinit.metadata.services.osconfigdrive.windows [-] Looking for a Config Drive with label 'config-2' on '\?\Volume{0ec29355-d9af-4f30-bf90-7d34b5002430}'. Found mismatching label 'NewVolume'. _check_for_config_drive C:\Program Files\Cloudbase Solutions\Cloudbase-Init\Python\lib\site-packages\cloudbaseinit\metadata\services\osconfigdrive\windows.py:68
2024-08-06 10:01:03.009 776 DEBUG cloudbaseinit.metadata.services.osconfigdrive.windows [-] Looking for a Config Drive with label 'config-2' on '\?\Volume{1f7df349-0000-0000-0000-500600000000}'. Found mismatching label ''. _check_for_config_drive C:\Program
packages\cloudbaseinit\metadata\services\osconfigdrive\windows.py:204
2024-08-06 10:02:03.947 2520 DEBUG cloudbaseinit.metadata.services.osconfigdrive.windows [-] Looking for Config Drive iso in partition with expected label config-2 get_config_drive_files C:\Program Files\Cloudbase Solutions\Cloudbase-Init\Python\lib\site-packages\cloudbaseinit\metadata\services\osconfigdrive\windows.py:221
2024-08-06 10:02:04.150 2520 WARNING cloudbaseinit.metadata.services.osconfigdrive.windows [-] ISO extraction failed on <Partition: \?\GLOBALROOT\Device\Harddisk0\Partition2> with WindowsCloudbaseInitException("Cannot open file: 'The process cannot access the file because it is being used by another process.'"): cloudbaseinit.exception.WindowsCloudbaseInitException: Cannot open file: 'The process cannot access the file because it is being used by another process.'
2024-08-06 10:02:04.150 2520 DEBUG cloudbaseinit.metadata.services.osconfigdrive.windows [-] Looking for Config Drive iso in hdd with expected label config-2 get_config_drive_files C:\Program Files\Cloudbase Solutions\Cloudbase-Init\Python\lib\site-packages\cloudbaseinit\metadata\services\osconfigdrive\windows.py:221
2024-08-06 10:02:04.150 2520 DEBUG cloudbaseinit.metadata.services.osconfigdrive.windows [-] Looking for Config Drive iso in cdrom with expected label config-2 get_config_drive_files C:\Program Files\Cloudbase Solutions\Cloudbase-Init\Python\lib\site-packages\cloudbaseinit\metadata\services\osconfigdrive\windows.py:221
2024-08-06 10:02:04.150 2520 DEBUG cloudbaseinit.metadata.services.osconfigdrive.windows [-] Looking for a Config Drive with label 'config-2' on 'D:'. Found mismatching label 'None'. _check_for_config_drive C:\Program Files\Cloudbase Solutions\Cloudbase-Init\Python\lib\site-packages\cloudbaseinit\metadata\services\osconfigdrive\windows.py:68
2024-08-06 10:02:04.150 2520 DEBUG cloudbaseinit.utils.classloader [-] Loading class 'cloudbaseinit.metadata.services.base.EmptyMetadataService' load_class C:\Program Files\Cloudbase Solutions\Cloudbase-Init\Python\lib\site-packages\cloudbaseinit\utils\classloader.py:27
2024-08-06 10:02:04.150 2520 INFO cloudbaseinit.init [-] Metadata service loaded: 'EmptyMetadataService'
2024-08-06 10:02:04.150 2520 DEBUG cloudbaseinit.init [-] Instance id: None configure_host C:\Program Files\Cloudbase Solutions\Cloudbase-Init\Python\lib\site-packages\cloudbaseinit\init.py:202
2024-08-06 10:02:04.150 2520 DEBUG cloudbaseinit.utils.classloader [-] Loading class 'cloudbaseinit.plugins.common.userdata.UserDataPlugin' load_class C:\Program Files\Cloudbase Solutions\Cloudbase-Init\Python\lib\site-packages\cloudbaseinit\utils\classloader.py:27
2024-08-06 10:02:04.150 2520 INFO cloudbaseinit.init [-] Executing plugins for stage 'MAIN':
2024-08-06 10:02:04.150 2520 INFO cloudbaseinit.init [-] Executing plugin 'UserDataPlugin'
2024-08-06 10:02:04.150 2520 INFO cloudbaseinit.init [-] Plugins execution done
the cloudbase-init purpse for my goals is to run the powershell script that is in the user_data file and it's modules in the /openstack/content.
and I wish for the cloudbase-init to utilze the NT AUTHORITY\SYSTEM account for the task.

Hello,
From the logs that you shared, I do not see any possible causes for the force dismount of the E: drive and I do not see the cause of cloudbase-init service exiting with error code (terminated unexpectedly). What is the E: drive - a QEMU scsi/virtio/ide disk and how was it attached? And the error can be reproduced every time cloudbase-init runs?
Also,  Metadata service loaded: 'EmptyMetadataService' -> means that there was no config-drive attached to the VM and the only plugin plugins=cloudbaseinit.plugins.common.userdata.UserDataPlugin cannot run without a metadata service that provides  the user data. EmptyMetadataService should be used in case you want to run only the ExtendVolume or LocalScripts plugins, that do not require user data or meta data.
This key-value - username="NT AUTHORITY\SYSTEM" is meant for cloudbase-init to create that user, and not to have cloudbase-init service run under that user. To achieve a similar thing, you will need to install the Cloudbase-Init MSI with the LocalSystem checkbox activated (to run under the LocalSystem user. NT AUTHORITY\SYSTEM is not a Windows user, as far as I know). One can automate such MSI installation using https://github.com/cloudbase/windows-imaging-tools/blob/master/UnattendResources/Logon.ps1#L637.
Creating a working Windows image can get quite tedious at times, I might suggest using this tool https://github.com/cloudbase/windows-imaging-tools, as it automates the whole process of creating an image.
Thanks.

Thank you for the time you take for this.
I will try the tools but i'm still trying to make sure that Cloudbase doesn't have anything to do with the Shadow Copy with my configurations.
This is a fresh STD 22 OS with Cloudbase 1.1.6
updated conf file:
[DEFAULT]
username="NT AUTHORITY\SYSTEM"
groups=Administrators
first_logon_behaviour=no
check_latest_version=false
enable_automatic_updates=false
stop_service_on_exit=false
cdrom=true
bsdtar_path=C:\Program Files\Cloudbase Solutions\Cloudbase-Init\bin\bsdtar.exe
mtools_path=C:\Program Files\Cloudbase Solutions\Cloudbase-Init\bin
log_dir=C:\Program Files\Cloudbase Solutions\Cloudbase-Init\log
log_file=cloudbase-init.log
default_log_levels=comtypes=INFO,suds=INFO,iso8601=WARN,requests=WARN
verbose=true
debug=true
metadata_file=meta_data.json
userdata_file=user_data
userdata_save_path=C:\Windows\Temp\CloudBaseData
metadata_services=cloudbaseinit.metadata.services.configdrive.ConfigDriveService

cloudbase-init.log


Initial rpm spec

Here's my initial attempt at a spec file so we can create an RPM.
Also pull in Docker as it's required to build.

@mrunalp I was able to vendor Docker and I don't think there are any circular dependency issues. What were you seeing?

Good. I think it doesn't  matter in this case as we are not compiling all of docker. I was seeing docker and dockerexec depending on different versions of cgroup library causing issues but vendoring should solve that.
Sent from my iPhone

On May 26, 2015, at 10:08 AM, Andy Goldstein<EMAIL_ADDRESS>wrote:
@mrunalp I was able to vendor Docker and I don't think there are any circular dependency issues. What were you seeing?
—
Reply to this email directly or view it on GitHub.

Specfile works, produces an rpm with /usr/bin/dockerexec LGTM
If we need to get this into Fedora we'll want to add a license file and ideally a man page, I think they also have stricter requirements about vendoring things but we haven't done that with other packages yet, so I don't think we need to fix that yet.
https://fedoraproject.org/wiki/PackagingDrafts/Go#Dependencies_2

:+1: LGTM

LGTM


HDFS-16965. Add switch to decide whether to enable native codec.

JIRA: HDFS-16965. Add switch to decide whether to enable native codec.

JIRA: HDFS-16965. Add switch to decide whether to enable native codec.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 48s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+0 :ok:
xmllint
0m  0s

xmllint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
51m 15s

trunk passed

+1 :green_heart:
compile
25m 12s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
21m 31s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
checkstyle
1m  5s

trunk passed

+1 :green_heart:
mvnsite
1m 38s

trunk passed

+1 :green_heart:
javadoc
1m  8s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
0m 41s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
spotbugs
2m 45s

trunk passed

+1 :green_heart:
shadedclient
25m  9s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m  0s

the patch passed

+1 :green_heart:
compile
24m 33s

the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javac
24m 33s

the patch passed

+1 :green_heart:
compile
21m 41s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
javac
21m 41s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 58s
/results-checkstyle-hadoop-common-project_hadoop-common.txt
hadoop-common-project/hadoop-common: The patch generated 3 new + 2 unchanged - 0 fixed = 5 total (was 2)

+1 :green_heart:
mvnsite
1m 36s

the patch passed

+1 :green_heart:
javadoc
0m 59s

the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
0m 42s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
spotbugs
2m 42s

the patch passed

+1 :green_heart:
shadedclient
25m 15s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
18m  8s

hadoop-common in the patch passed.

+1 :green_heart:
asflicense
0m 50s

The patch does not generate ASF License warnings.

229m 15s

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5520/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5520

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets xmllint

uname
Linux 2b49cc2fb4a5 4.15.0-206-generic #217-Ubuntu SMP Fri Feb 3 19:10:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / ed64df4dc94f859501002007e2364c06a8fa4828

Default Java
Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5520/2/testReport/

Max. process+thread count
1239 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5520/2/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 49s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+0 :ok:
xmllint
0m  1s

xmllint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
45m 42s

trunk passed

+1 :green_heart:
compile
25m  5s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
21m 35s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
checkstyle
1m  6s

trunk passed

+1 :green_heart:
mvnsite
1m 38s

trunk passed

+1 :green_heart:
javadoc
1m  8s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
0m 42s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
spotbugs
2m 45s

trunk passed

+1 :green_heart:
shadedclient
25m 21s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m  0s

the patch passed

+1 :green_heart:
compile
24m 36s

the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javac
24m 36s

the patch passed

+1 :green_heart:
compile
21m 29s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
javac
21m 29s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
1m  0s
/results-checkstyle-hadoop-common-project_hadoop-common.txt
hadoop-common-project/hadoop-common: The patch generated 3 new + 2 unchanged - 0 fixed = 5 total (was 2)

+1 :green_heart:
mvnsite
1m 34s

the patch passed

+1 :green_heart:
javadoc
1m  0s

the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
0m 42s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
spotbugs
2m 45s

the patch passed

+1 :green_heart:
shadedclient
25m 36s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
18m  3s

hadoop-common in the patch passed.

+1 :green_heart:
asflicense
0m 53s

The patch does not generate ASF License warnings.

224m  7s

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5520/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5520

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets xmllint

uname
Linux 8fe3d4c76c52 4.15.0-206-generic #217-Ubuntu SMP Fri Feb 3 19:10:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 2bc4f6d674490e0c72f3c6cc4a2b708c3f5d39c2

Default Java
Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5520/3/testReport/

Max. process+thread count
1239 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5520/3/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@cnauroth  I've updated the PR based on your suggestion, could you review this please?  Thanks.

@cnauroth I've updated the PR based on your suggestion, could you review this please? Thanks.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 49s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+0 :ok:
xmllint
0m  0s

xmllint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
42m  9s

trunk passed

+1 :green_heart:
compile
25m  0s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
21m 38s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
checkstyle
1m  6s

trunk passed

+1 :green_heart:
mvnsite
1m 39s

trunk passed

+1 :green_heart:
javadoc
1m 10s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
0m 42s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
spotbugs
2m 45s

trunk passed

+1 :green_heart:
shadedclient
25m  6s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m  2s

the patch passed

+1 :green_heart:
compile
24m 32s

the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javac
24m 32s

the patch passed

+1 :green_heart:
compile
21m 45s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
javac
21m 45s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
1m  0s
/results-checkstyle-hadoop-common-project_hadoop-common.txt
hadoop-common-project/hadoop-common: The patch generated 3 new + 2 unchanged - 0 fixed = 5 total (was 2)

+1 :green_heart:
mvnsite
1m 37s

the patch passed

+1 :green_heart:
javadoc
0m 59s

the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
0m 42s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
spotbugs
2m 41s

the patch passed

+1 :green_heart:
shadedclient
25m 17s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
18m 22s

hadoop-common in the patch passed.

+1 :green_heart:
asflicense
0m 54s

The patch does not generate ASF License warnings.

220m 51s

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5520/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5520

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets xmllint

uname
Linux 52b89c025e4e 4.15.0-206-generic #217-Ubuntu SMP Fri Feb 3 19:10:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / d9db1fd8e5793c2b950d0b8fdfe0060f33a0dfef

Default Java
Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5520/4/testReport/

Max. process+thread count
1261 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5520/4/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@cnauroth Thank you for your very nice suggestion. I'v updated the code and could you review this please?

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m 25s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+0 :ok:
xmllint
0m  1s

xmllint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
36m  5s

trunk passed

+1 :green_heart:
compile
19m 41s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
22m 43s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
checkstyle
1m 18s

trunk passed

+1 :green_heart:
mvnsite
1m 46s

trunk passed

+1 :green_heart:
javadoc
1m 16s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
0m 42s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
spotbugs
2m 58s

trunk passed

+1 :green_heart:
shadedclient
26m 48s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 56s

the patch passed

+1 :green_heart:
compile
18m  2s

the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javac
18m  2s

the patch passed

+1 :green_heart:
compile
16m  0s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
javac
16m  0s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
1m  0s

the patch passed

+1 :green_heart:
mvnsite
1m 29s

the patch passed

+1 :green_heart:
javadoc
1m  0s

the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
0m 42s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
spotbugs
2m 35s

the patch passed

+1 :green_heart:
shadedclient
25m 15s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
18m 29s

hadoop-common in the patch passed.

+1 :green_heart:
asflicense
0m 54s

The patch does not generate ASF License warnings.

201m 22s

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5520/6/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5520

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets xmllint

uname
Linux 5b4ed3e97a15 4.15.0-206-generic #217-Ubuntu SMP Fri Feb 3 19:10:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / df3bda08b4681c9bcaa961efb90ef773b777dac8

Default Java
Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5520/6/testReport/

Max. process+thread count
1261 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5520/6/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@ayushtkn  Hello,Would you please help assign the Jira(HDFS-16965) ticket to me? Could you please help review this PR?

Thank you for the ticket and merging. Looking forward to meeting you in the next PR. @ayushtkn


Unable to deploy Azure function from VS code

<Please be sure to remove any private information before submitting.>
Repro steps:
<Enter steps to reproduce issue>
Action: azureFunctions.deploy
Error type: Error
Error Message: Failed to deploy path that does not exist: /home/sandeep/Documents/azure/azure.zip
Version: 0.13.1
OS: linux

@sandeep0473 I believe this may be a duplicate of another bug we've been seeing. You can try the workarounds listed here: https://github.com/Microsoft/vscode-azurefunctions/issues/892#issuecomment-459054366
We've fixed on master already and plan to release soon, but you're welcome to try earlier:
How to install: https://aka.ms/azCodeInsiders
Build: https://dev.azure.com/ms-azuretools/AzCode/_build/results?buildId=2905
NOTE: This relies on VS Code v1.31.0 just released yesterday
If you're still having problems, please copy the full output of the "func pack" task here


Update Get-CsOnlineUser.md

Docs Build status updates of commit 8fe9d59:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

skype/skype-ps/skype/Get-CsOnlineUser.md
:white_check_mark:Succeeded
View (skype-ps)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit d0617b6:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

skype/skype-ps/skype/Get-CsOnlineUser.md
:white_check_mark:Succeeded
View (skype-ps)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 27b2980:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

skype/skype-ps/skype/Get-CsOnlineUser.md
:white_check_mark:Succeeded
View (skype-ps)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 2bae674:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

skype/skype-ps/skype/Get-CsOnlineUser.md
:white_check_mark:Succeeded
View (skype-ps)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit f613184:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

skype/skype-ps/skype/Get-CsOnlineUser.md
:white_check_mark:Succeeded
View (skype-ps)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 2bee871:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

skype/skype-ps/skype/Get-CsOnlineUser.md
:white_check_mark:Succeeded
View (skype-ps)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit c9bfa00:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

skype/skype-ps/skype/Get-CsOnlineUser.md
:white_check_mark:Succeeded
View (skype-ps)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

@isrumnon

@yogkumgit done! please merge

Docs Build status updates of commit e350bea:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

skype/skype-ps/skype/Get-CsOnlineUser.md
:white_check_mark:Succeeded
View (skype-ps)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

@get-itips

@tiburd Please merge this Pr. Thanks

Docs Build status updates of commit 070488d:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

skype/skype-ps/skype/Get-CsOnlineUser.md
:white_check_mark:Succeeded
View (skype-ps)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Will the develop branch have a Parse() function too?

Hi, I'm dipping my toes back into this library, which I'm really looking forward to (the develop branch).
I notice the README for v1 shows a function, imagemeta.Parse(). Will or does the develop branch have something like this too?
Basically, "here's a file, parse out all the metadata you can find, whatever the format."
That would make this an absolute dream. :sun_behind_small_cloud:
Thanks for working on this lib!
PS. Will there be a way to iterate all metadata fields/values? I know currently there's a lot of getter methods, but do you think we will be able to enumerate them all? Even if they're uncommon I'd like to access whatever is in there.

Hi. Thanks for coming back to this library. I am actively working on the develop branch. Since there are so many changes it will replace the current main branch.
There will be a similar function to imagemeta.Parse(io.Reader). The develop branch has this function but I believe it can be refined and clarified. Do you have any suggestions?
I am working on a function to iterate all metadata tags and their values. It may potentially be less efficient but hope to include it.

Perfect. Sounds great for my use case.
This is my wishlist:

A function that can parse any/all metadata out of a file (any common formats)

This doesn't have to be 100% comprehensive -- for example, we talked about Maker Notes before, and how they're proprietary; you don't need to decode those, but if you can still parse the value out, that'd be awesome, even if this lib doesn't interpret them.

A way to read any/all metadata that was parsed

I understand there are a ton of fields. If I can somehow access their values easily in my own code, that'd be great -- ideally as string, int, or whatever basic type it may be.
Helper methods for the most common data would be nice to have. For example, a getter for DateTime() or LatLon() that can know the variety of ways that data is stored, so I don't have to. Those two are the big ones for me.

Efficient is great, but correctness and completeness is more important to me. I would be OK with sacrificing some efficiency to get access to more/all metadata, for example.

Anyway, your lib totally fits the bill. That's all I have for feedback right now. :+1: Let me know how else I can help!

Makernotes: I would like to add these in as soon as the basics are well developed. As you mention, there is variety of data and each Make/Model may be slightly different.
Custom Tag Parsing: Take a look at 5fb96b9. Does this fit what you are looking for? It can still do with some polishing.
Precision / Completeness / Efficiency: I agree priority should be in this order.

Ideas are a great help, will appreciate PRs as soon as I can push develop to main.

@evanoberholster Awesome! I am excited to try it out. I see your PR in progress. I'll try to clone it down soon and let you know how it goes.

I believe my request was fulfilled by the imagemeta.Decode() function now. Thank you!


[Enhancement] k8s-postgres-queryreport

Observation
To compliment the k8s-postgres-querymetric SLI codebundle, it would be helpful to have a taskset that can produce some more detailed report output via psql.
Current Outcome
No TaskSet exists to create a psql based report.
Desired Outcome
The ability to create psql reports via TaskSets that we might add to an SLX that is already running the k8s-postgres-querymetric codebundle.

This was resolved in this PR: https://github.com/runwhen-contrib/rw-public-codecollection/pull/46


Nice username!!!!

Hi! just wanted to say you have a nice username, I like it

Since there's no response, I'll close the issue


Add test container for UT of MySQL passwordless feature

As title

/azp run java - spring - tests

/azp run java - spring - tests

/azp run java - spring - tests


UC 17 - As an employee, I want to generate a report showing me all the capital cities in the world sorted by the largest population to the smallest.

As an employee, I want to generate a report showing me all the capital cities in the world sorted by the largest population to the smallest.

Edited the issue heading/topic as agreed upon during 2.11.24 Sprint review meeting


Fix bug with too-long substrings

Tracking issue for #350.

Issue created only in order be able to track #350's size.


An initial TCP implementation

Part of #48
Adds TCP as a protocol we can use to listen for messages on. It's similar to UDP, but because messages are null terminated it doesn't support compression. We can use the same receive logic though, there are just some features that won't be included.
This needs a bunch more integration tests and a good burn in.

A few more things to look at:

Is using .incoming().flatten() going to wait for each incoming connection to close before attempting to handle the next one?
What transient error conditions do we need to handle in the tcp side?
Backpressure, keep alive, other tcp load management things

Also needs a seq-input-gelf.d.json update to include the new parameter 👍


Use dep jobslot instead of jobserver

What is jobslot?
jobslot is a fork of jobserver.
Advantages over jobserver?

jobslot contains bug fix for Client::configure is unsafe
jobslot removed use of signal handling in the helper thread on unix
jobslot uses winapi on windows instead of manually declaring bindings (some of the bindings seem to be wrong)
jobslot uses getrandom on windows instead of making homebrew one using raw windows api

Signed-off-by: Jiahao XU<EMAIL_ADDRESS>

Sorry, I never got around to reviewing this (as it also mostly required auditing jobslot).

Sorry, I never got around to reviewing this (as it also mostly required auditing jobslot).

No worries, I can open it again if you are interested.


Adding the capability to adding fields other than id and contents

In this PR, I create the framework to add fields other than id and contents.
The implementation leaves the specific fields to the collections, i.e., what fields are supported should be decided by each collection and the type of the fields are also finalized in the collection.
Then the additional list of fields are passed to the generator to be added into Lucene Documents.
Also, as the part of this PR I've added 4 fields url, title, anchor_text and html_body to ClueWeb collections.

Hey guys,
are there any updates on this pull request and issue #404?
That feature would be really appreciated.
Cheers,
Robin

hi @Peilin-Yang we never merged this (for whatever reason) and it's gone out of date... what do you want to do? should we close it for now and reopen when we have the need?

Closing, since there are too many conflicts to merge cleanly... we'll have to reimplement when we need these features...


Need error messages on GetFirstComponent and GetLastComponent

These methods throw errors under certain conditions, but no error message is output

#1e7e21bdd added error messages and exception codes


GSAGH-555: Set up CI with Azure Pipelines

@psarras not sure what stage this is at, but we need to discuss before merge, particularly with respect to coverage analysis


docs: put all anchor at the beginning of app.rs in json-editor-app

additional pr to #586

This seems to have removed the anchor instead of moving it to the top of the file. Am I misunderstanding the intent of the PR?

??? Didn't I move line 3 to line 1 to include the HashMap import?

Oops my bad! GitHub's UI for showing the line numbers has the same color as the diff being added, and I somehow just skimmed past it:

This LGTM


[Question] Does it work for Typescript files?

The symbols don't appear in the window when I'm in a Typescript file.

Can confirm that it works in typescript. Just used it today.

@manderson21 No one is talking about macos, stop recommending macos tools if no clear mention of this OS is made.

Wow. Why the hostility? No comment was made about Windows or Linux either. My response was only to give an accounting of my experience with my OS.
And if it pleases you, I can also confirm that the symbols work for me on windows as well. Now we're just missing Linux.

Hi @manderson21 thank you for your suggestion!
I'm using JetBrainsMono Nerd Font, and the plugin is working great with other languages, like Python.
It's only with Typescript 🤔
I'm having some problems also with TypescriptReact LSP (it's not showing me props suggestions), maybe it's a correlated problem.


nixos/qemu-vm: fix minor typo

Description of changes
The typo creates an empty directory /0755 in initrd rootfs rather than create the Nix store directories with mode 0755
I guess setting the mode is not strictly necessary if it worked before this change, but I'll leave the -m 0755 in just in case
cc: @ElvishJerricco (since we discussed this in Matrix in #systemd-stage-1:nixos.org)
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

0755 should be the default anyway, so this change should be practically a no-op aside from the missing 0755 directory; is that right?

0755 should be the default anyway, so this change should be practically a no-op aside from the missing 0755 directory; is that right?

That is probably right, yeah. I mean it worked before so if you'd rather I removed it I'm fine with doing that too

No it's probably best to have the explicit permissions there just for the style points. I just wanted to be sure I was sane for thinking this change should be a no-op.

@ofborg test systemd-initrd-simple fsck
Just picking the simplest tests I can think of to prove this works here.