Feature/cloudarmor policies

New cloudarmor_policies module and associated example and test-cases for managing security polices.

Thanks for the PR! 🚀
Unfortunately it looks like some of our CI checks failed. See the Contributing Guide for details.

⚠check_generate_modules
The modules need to be regenerated. Please run make_build.

Checking submodule's files generation
diff -r '--exclude=.terraform' '--exclude=.kitchen' '--exclude=.git' /workspace/README.md /tmp/tmp.1z6fpyHo2j/workspace/README.md
167,177d166
<
<
< ## Contributing
<
< Refer to the [contribution guidelines](./CONTRIBUTING.md) for
< information on contributing to this module.
<
< ## Additional References
< - [project-factory-module](https://registry.terraform.io/modules/terraform-google-modules/project-factory/google) for project creation and configuration.
< - [terraform-provider-gcp](https://www.terraform.io/docs/providers/google/index.html)
< - [terraform](https://www.terraform.io/downloads.html)
\ No newline at end of file
Error: submodule's files generation has not been run, please run the
'make build' command and commit changes

⚠check_whitespace
Failed whitespace check. More details below.

Checking for trailing whitespace
./examples/cloudarmor-policies/variables.tf:16:
./examples/cloudarmor-policies/main.tf:15:        action   = "deny(404)"
./examples/cloudarmor-policies/main.tf:27:        priority       = "2147483647"
./examples/cloudarmor-policies/main.tf:35:          action      = "allow"
./examples/cloudarmor-policies/main.tf:55:
./examples/cloudarmor-policies/main.tf:68:
./test/integration/cloudarmor_policies/controls/http.rb:17:
./test/fixtures/cloudarmor-policies/main.tf:35:        action   = "deny(404)"
./modules/cloudarmor_policies/main.tf:18:See:
./modules/cloudarmor_policies/main.tf:19:- For TF properties: https://registry.terraform.io/providers/hashicorp/google/latest/docs/resources/compute_security_policy
./modules/cloudarmor_policies/main.tf:28:
./modules/cloudarmor_policies/main.tf:42:        }
Error: Trailing whitespace found in the lines above.
Checking for missing newline at end of file
Error: No newline at end of file ./examples/cloudarmor-policies/variables.tf
Error: No newline at end of file ./examples/cloudarmor-policies/outputs.tf
Error: No newline at end of file ./examples/cloudarmor-policies/versions.tf
Error: No newline at end of file ./examples/cloudarmor-policies/README.md
Error: No newline at end of file ./test/fixtures/cloudarmor-policies/outputs.tf
Error: No newline at end of file ./modules/cloudarmor_policies/variables.tf
Error: No newline at end of file ./modules/cloudarmor_policies/main.tf
Error: No newline at end of file ./modules/cloudarmor_policies/outputs.tf
Error: No newline at end of file ./modules/cloudarmor_policies/versions.tf
Error: No newline at end of file ./modules/cloudarmor_policies/README.md
Error: No newline at end of file ./README.md

⚠check_headers
All files need a license header. Please make sure all your files include the appropriate header. A helper tool available here.

Checking file headers
./examples/cloudarmor-policies/variables.tf
./examples/cloudarmor-policies/main.tf

⚠check_terraform
Failed Terraform check. More details below.

Running terraform fmt
examples/cloudarmor-policies/variables.tf
--- old/examples/cloudarmor-policies/variables.tf
+++ new/examples/cloudarmor-policies/variables.tf
@@ -1,17 +1,17 @@
variable "security_policies" {
-    type = any
-    description = "CloudArmor security policies"
-    default = {}
+  type        = any
+  description = "CloudArmor security policies"
+  default     = {}
}

variable "project_id" {
-  type = string
+  type        = string
  description = "Project where the policies are created."
}

variable "region" {
-    default = "us-central1"
-    type = string
-    description = "Resources region"
-
+  default     = "us-central1"
+  type        = string
+  description = "Resources region"
+
}
\ No newline at end of file
Error: terraform fmt failed with exit code 3
Check the output for diffs and correct using terraform fmt <dir>
examples/cloudarmor-policies/main.tf
--- old/examples/cloudarmor-policies/main.tf
+++ new/examples/cloudarmor-policies/main.tf
@@ -1,59 +1,59 @@
locals {
  security_policies = {
-  "tf-managed-policy-01" = {
-    rules = [{
-      action         = "allow" #Allow by default policy
-      type           = "CLOUD_ARMOR_EDGE"
-      priority       = "2147483647" #Default rule priority.
-      versioned_expr = "SRC_IPS_V1"
-      config = [{
-        src_ip_ranges = ["*"]
-      }]
-      description = "Default rule, higher priority overrides it"
-      },
-      {
-        action   = "deny(404)"
-        priority = "1000"
-        expr = [{
-          expression = "evaluatePreconfiguredExpr('sqli-stable') || evaluatePreconfiguredExpr('xss-stable') || evaluatePreconfiguredExpr('php-stable') || evaluatePreconfiguredExpr('cve-canary')"
-        }]
-        description = "Protection for Google Cloud Preconfigured expressions."
-    }]
-  },
-    "tf-managed-policy-02" = {
+    "tf-managed-policy-01" = {
      rules = [{
-        action         = "deny(404)" #Deny by default policy
-        type = "CLOUD_ARMOR_EDGE"
-        priority       = "2147483647"
+        action         = "allow" #Allow by default policy
+        type           = "CLOUD_ARMOR_EDGE"
+        priority       = "2147483647" #Default rule priority.
        versioned_expr = "SRC_IPS_V1"
        config = [{
-            src_ip_ranges  = ["*"]
+          src_ip_ranges = ["*"]
        }]
-        description    = "Default rule, higher priority overrides it."
+        description = "Default rule, higher priority overrides it"
        },
        {
-          action      = "allow"
-          priority    = "1000"
+          action   = "deny(404)"
+          priority = "1000"
+          expr = [{
+            expression = "evaluatePreconfiguredExpr('sqli-stable') || evaluatePreconfiguredExpr('xss-stable') || evaluatePreconfiguredExpr('php-stable') || evaluatePreconfiguredExpr('cve-canary')"
+          }]
+          description = "Protection for Google Cloud Preconfigured expressions."
+      }]
+    },
+    "tf-managed-policy-02" = {
+      rules = [{
+        action         = "deny(404)" #Deny by default policy
+        type           = "CLOUD_ARMOR_EDGE"
+        priority       = "2147483647"
        versioned_expr = "SRC_IPS_V1"
        config = [{
-            src_ip_ranges  = ["<IP_ADDRESS>/24", "<IP_ADDRESS>"]
+          src_ip_ranges = ["*"]
        }]
+        description = "Default rule, higher priority overrides it."
+        },
+        {
+          action         = "allow"
+          priority       = "1000"
+          versioned_expr = "SRC_IPS_V1"
+          config = [{
+            src_ip_ranges = ["<IP_ADDRESS>/24", "<IP_ADDRESS>"]
+          }]
          description = "Allow traffic only from specific sources."
-        }]
+      }]
    },
-}
+  }
}

module "cloud_armor_security_policies" {
-    source = "../../modules/cloudarmor_policies"
-    project_id = var.project_id
+  source     = "../../modules/cloudarmor_policies"
+  project_id = var.project_id

-    for_each = local.security_policies
+  for_each = local.security_policies

-    name = each.key
-    description = "CloudArmor policy for ${each.key}"
-
-    rules = each.value.rules
+  name        = each.key
+  description = "CloudArmor policy for ${each.key}"
+
+  rules = each.value.rules
}

provider "google" {
@@ -65,14 +65,14 @@
}

module "lb-http" {
-
+
  source  = "GoogleCloudPlatform/lb-http/google//modules/serverless_negs"
  version = "6.2.0"
  name    = "cloud-armor-test-gclb"
  project = var.project_id

-  ssl                             = false
-  https_redirect                  = false
+  ssl            = false
+  https_redirect = false

  backends = {
    default = {
Error: terraform fmt failed with exit code 3
Check the output for diffs and correct using terraform fmt <dir>
test/fixtures/cloudarmor-policies/variables.tf
--- old/test/fixtures/cloudarmor-policies/variables.tf
+++ new/test/fixtures/cloudarmor-policies/variables.tf
@@ -15,12 +15,12 @@
 */

variable "security_policies" {
-    type = any
-    description = "CloudArmor security policies"
-    default = {}
+  type        = any
+  description = "CloudArmor security policies"
+  default     = {}
}

variable "project_id" {
-  type = string
+  type        = string
  description = "Project where the security policy will be deployed."
}
Error: terraform fmt failed with exit code 3
Check the output for diffs and correct using terraform fmt <dir>
test/fixtures/cloudarmor-policies/main.tf
--- old/test/fixtures/cloudarmor-policies/main.tf
+++ new/test/fixtures/cloudarmor-policies/main.tf
@@ -19,26 +19,26 @@
  project_id = var.project_id

-security_policies = {
-  "tf-managed-policy-01" = {
-    rules = [{
-      action         = "allow" #Allow by default policy
-      type           = "CLOUD_ARMOR_EDGE"
-      priority       = "2147483647" #Default rule priority.
-      versioned_expr = "SRC_IPS_V1"
-      config = [{
-        src_ip_ranges = ["*"]
-      }]
-      description = "Default rule, higher priority overrides it"
-      },
-      {
-        action   = "deny(404)"
-        priority = "1000"
-        expr = [{
-          expression = "evaluatePreconfiguredExpr('sqli-stable') || evaluatePreconfiguredExpr('xss-stable') || evaluatePreconfiguredExpr('php-stable') || evaluatePreconfiguredExpr('cve-canary')"
+  security_policies = {
+    "tf-managed-policy-01" = {
+      rules = [{
+        action         = "allow" #Allow by default policy
+        type           = "CLOUD_ARMOR_EDGE"
+        priority       = "2147483647" #Default rule priority.
+        versioned_expr = "SRC_IPS_V1"
+        config = [{
+          src_ip_ranges = ["*"]
        }]
-        description = "Protection for Google Cloud Preconfigured expressions."
-    }]
+        description = "Default rule, higher priority overrides it"
+        },
+        {
+          action   = "deny(404)"
+          priority = "1000"
+          expr = [{
+            expression = "evaluatePreconfiguredExpr('sqli-stable') || evaluatePreconfiguredExpr('xss-stable') || evaluatePreconfiguredExpr('php-stable') || evaluatePreconfiguredExpr('cve-canary')"
+          }]
+          description = "Protection for Google Cloud Preconfigured expressions."
+      }]
+    }
  }
}
-}
Error: terraform fmt failed with exit code 3
Check the output for diffs and correct using terraform fmt <dir>
modules/cloudarmor_policies/variables.tf
--- old/modules/cloudarmor_policies/variables.tf
+++ new/modules/cloudarmor_policies/variables.tf
@@ -15,28 +15,28 @@
 */

variable "security_policies" {
-    type = any
-    default = {}
-    description = "Cloud Armor security policies. https://cloud.google.com/armor/quotas#quotas for quotas."
+  type        = any
+  default     = {}
+  description = "Cloud Armor security policies. https://cloud.google.com/armor/quotas#quotas for quotas."
}

variable "rules" {
-    type  = any
+  type = any
}

variable "name" {
-    type = string
-    description = "Cloud Armor security policy name."
+  type        = string
+  description = "Cloud Armor security policy name."
}

variable "description" {
-    type = string
-    description = "Policy description"
-    default = ""
+  type        = string
+  description = "Policy description"
+  default     = ""
}

variable "project_id" {
-    type = string
-    description = "ProjectID where policy is created."
-    default = ""
+  type        = string
+  description = "ProjectID where policy is created."
+  default     = ""
}
\ No newline at end of file
Error: terraform fmt failed with exit code 3
Check the output for diffs and correct using terraform fmt <dir>
modules/cloudarmor_policies/main.tf
--- old/modules/cloudarmor_policies/main.tf
+++ new/modules/cloudarmor_policies/main.tf
@@ -21,29 +21,29 @@
**************************************************************/

resource "google_compute_security_policy" "cloud_armor_security_policy" {
-  project  = var.project_id
+  project = var.project_id

-  name = var.name
+  name        = var.name
  description = var.description
-
+
  dynamic "rule" {
    for_each = var.rules
    content {
-      action   = rule.value.action
-      priority = rule.value.priority
-      description =rule.value.description
+      action      = rule.value.action
+      priority    = rule.value.priority
+      description = rule.value.description
      match {
        versioned_expr = lookup(rule.value, "versioned_expr", null)
-        dynamic config {
+        dynamic "config" {
          for_each = lookup(rule.value, "config", [])
          content {
            src_ip_ranges = lookup(config.value, "src_ip_ranges", null)
          }
-        }
-        dynamic expr {
+        }
+        dynamic "expr" {
          for_each = lookup(rule.value, "expr", [])
          content {
-          expression = lookup(expr.value, "expression", null)
+            expression = lookup(expr.value, "expression", null)
          }
        }
      }
Error: terraform fmt failed with exit code 3
Check the output for diffs and correct using terraform fmt <dir>
modules/cloudarmor_policies/outputs.tf
--- old/modules/cloudarmor_policies/outputs.tf
+++ new/modules/cloudarmor_policies/outputs.tf
@@ -15,5 +15,5 @@
 */

output "security_policy_id" {
-    value = google_compute_security_policy.cloud_armor_security_policy.id
+  value = google_compute_security_policy.cloud_armor_security_policy.id
}
\ No newline at end of file
Error: terraform fmt failed with exit code 3
Check the output for diffs and correct using terraform fmt <dir>

@vponnam
Thanks for the PR! 🚀
Unfortunately it looks like some of our CI checks failed. See the Contributing Guide for details.

⚠check_generate_modules
The modules need to be regenerated. Please run make_build.

Checking submodule's files generation
diff -r '--exclude=.terraform' '--exclude=.kitchen' '--exclude=.git' /workspace/modules/cloudarmor_policies/README.md /tmp/tmp.PFHgcMyM4L/workspace/modules/cloudarmor_policies/README.md
36c36
< | project_id | ProjectID where policy is created. | `string` | n/a | yes |
---
> | project\_id | ProjectID where policy is created. | `string` | n/a | yes |
Error: submodule's files generation has not been run, please run the
'make build' command and commit changes

⚠check_documentation
The documentation needs to be regenerated. Please run make generate_docs.

Checking for documentation generation
diff -r '--exclude=.terraform' '--exclude=.kitchen' '--exclude=autogen' '--exclude=*.tfvars' '--exclude=*metadata.yaml' /workspace/modules/cloudarmor_policies/README.md /tmp/tmp.CcBGXWES3c/generate_docs/workspace/modules/cloudarmor_policies/README.md
36c36
< | project_id | ProjectID where policy is created. | `string` | n/a | yes |
---
> | project\_id | ProjectID where policy is created. | `string` | n/a | yes |
Error: Documentation generation has not been run, please run the
'make docker_generate_docs' command and commit the above changes.

⚠check_tflint
Failed TFlint check. More details below.

Checking for tflint
Working in . ...
tflint passed .
Working in ./examples/cloudarmor-policies ...
tflint passed ./examples/cloudarmor-policies
Working in ./examples/cloudrun ...
tflint passed ./examples/cloudrun
Working in ./examples/dynamic-backend ...
tflint passed ./examples/dynamic-backend
Working in ./examples/https-gke ...
tflint passed ./examples/https-gke
Working in ./examples/https-gke/gke-node-port ...
tflint passed ./examples/https-gke/gke-node-port
Working in ./examples/https-redirect ...
tflint passed ./examples/https-redirect
Working in ./examples/mig-nat-http-lb ...
tflint passed ./examples/mig-nat-http-lb
Working in ./examples/multi-backend-multi-mig-bucket-https-lb ...
tflint passed ./examples/multi-backend-multi-mig-bucket-https-lb
Working in ./examples/multi-mig-http-lb ...
tflint passed ./examples/multi-mig-http-lb
Working in ./examples/multiple-certs ...
tflint passed ./examples/multiple-certs
Working in ./examples/shared-vpc ...
tflint passed ./examples/shared-vpc
Working in ./modules/cloudarmor_policies ...
3 issue(s) found:
Notice: `security_policy_id` output has no description (terraform_documented_outputs)
 on outputs.tf line 17:
 17: output "security_policy_id" {
Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.1.1/docs/rules/terraform_documented_outputs.md
Warning: variable "security_policies" is declared but not used (terraform_unused_declarations)
 on variables.tf line 17:
 17: variable "security_policies" {
Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.1.1/docs/rules/terraform_unused_declarations.md
Notice: `rules` variable has no description (terraform_documented_variables)
 on variables.tf line 23:
 23: variable "rules" {
Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.1.1/docs/rules/terraform_documented_variables.md
tflint failed ./modules/cloudarmor_policies
Working in ./modules/dynamic_backends ...
tflint passed ./modules/dynamic_backends
Working in ./modules/serverless_negs ...
tflint passed ./modules/serverless_negs
Skipping ./test/fixtures/cloudarmor-policies
Skipping ./test/fixtures/cloudrun
Skipping ./test/fixtures/https-redirect
Skipping ./test/fixtures/mig_nat
Skipping ./test/fixtures/multi_certs
Skipping ./test/fixtures/multi_mig
Skipping ./test/setup

⚠check_terraform
Failed Terraform check. More details below.

Running terraform fmt
Running terraform validate
terraform_validate .
Success!
The configuration is valid.
terraform_validate ./examples/cloudarmor-policies
╷
│

Error:
Missing required argument
│

│

 on main.tf line 17, in module "cloud_armor_security_policies":
│

 17: module "cloud_armor_security_policies"
{
│

│

The argument "project_id" is required, but no definition was found.
╵
╷
│

Error:
Unsupported argument
│

│

 on main.tf line 19, in module "cloud_armor_security_policies":
│

 19:
project
= var.project_id
│

│

An argument named "project" is not expected here.
╵
terraform_validate ./examples/cloudrun
Success!
The configuration is valid.
terraform_validate ./examples/dynamic-backend
Success!
The configuration is valid.
terraform_validate ./examples/https-gke
Success!
The configuration is valid.
terraform_validate ./examples/https-gke/gke-node-port
Success!
The configuration is valid.
terraform_validate ./examples/https-redirect
Success!
The configuration is valid.
terraform_validate ./examples/mig-nat-http-lb
Success!
The configuration is valid.
terraform_validate ./examples/multi-backend-multi-mig-bucket-https-lb
Success!
The configuration is valid.
terraform_validate ./examples/multi-mig-http-lb
Success!
The configuration is valid.
terraform_validate ./examples/multiple-certs
Success!
The configuration is valid.
terraform_validate ./examples/shared-vpc
Success!
The configuration is valid.
terraform_validate ./modules/cloudarmor_policies
Success!
The configuration is valid.
terraform_validate ./modules/dynamic_backends
Success!
The configuration is valid.
terraform_validate ./modules/serverless_negs
Success!
The configuration is valid.
terraform_validate ./test/fixtures/cloudarmor-policies
╷
│

Error:
Missing required argument
│

│

 on ../../../examples/cloudarmor-policies/main.tf line 17, in module "cloud_armor_security_policies":
│

 17: module "cloud_armor_security_policies"
{
│

│

The argument "project_id" is required, but no definition was found.
╵
╷
│

Error:
Unsupported argument
│

│

 on ../../../examples/cloudarmor-policies/main.tf line 19, in module "cloud_armor_security_policies":
│

 19:
project
= var.project_id
│

│

An argument named "project" is not expected here.
╵
terraform_validate ./test/fixtures/cloudrun
Success!
The configuration is valid.
terraform_validate ./test/fixtures/https-redirect
Success!
The configuration is valid.
terraform_validate ./test/fixtures/mig_nat
Success!
The configuration is valid.
terraform_validate ./test/fixtures/multi_certs
Success!
The configuration is valid.
terraform_validate ./test/fixtures/multi_mig
Success!
The configuration is valid.
terraform_validate ./test/setup
Success!
The configuration is valid.

@bharathkkb
Can we close this PR since we have a dedicated cloud armor module
https://registry.terraform.io/modules/GoogleCloudPlatform/cloud-armor/google/latest

Sorry, this has been a long pending PR and wasn't able to take this to the finish line w.r.t other priorities. Happy to close the this PR for now and re-evaluate any potential additions w.r.t the dedicated module at a later time.


Unable to configure XLA_TARGET=cuda118 to use GPU

I've been trying to use XLA_TARGET=cuda118 within a livebook app.
I'm running using the livebook github repository (https://github.com/livebook-dev/livebook.git, my HEAD is 361455cd4eb1b527e6fd04d5c51f2901cbb4ed90).
I am running using XLA_TARGET=cuda118 MIX_ENV=prod mix phx.server.
I also tried setting XLA_TARGET=cuda118 inside the environment variables of the livebook settings.
No matter what I do, when I run an example Neural Network, it always prints out:
14:30:19.336 [info] TfrtCpuClient created.

If I'm targeting the GPU, I assume it would print out a different client, right?
Notebook dependencies and setup are:
Mix.install(
  [
    {:kino_bumblebee, "~> 0.1.0"},
    {:exla, "~> 0.4.1"}
  ],
  config: [nx: [default_backend: EXLA.Backend]]
)

Bumblee seems to be the correct version:
Application.spec(:kino_bumblebee, :vsn)
'0.1.0'

Also:
Livebook v0.8.0
Elixir v1.14.2

I believe I have a supported version of nvidia on the host:
$ nvidia-smi
Fri Dec  9 14:37:59 2022
+-----------------------------------------------------------------------------+
| NVIDIA-SMI 520.56.06    Driver Version: 520.56.06    CUDA Version: 11.8     |
|-------------------------------+----------------------+----------------------+
| GPU  Name        Persistence-M| Bus-Id        Disp.A | Volatile Uncorr. ECC |
| Fan  Temp  Perf  Pwr:Usage/Cap|         Memory-Usage | GPU-Util  Compute M. |
|                               |                      |               MIG M. |
|===============================+======================+======================|
|   0  NVIDIA GeForce ...  Off  | 00000000:01:00.0 Off |                  N/A |
|  0%   37C    P8     6W / 120W |     15MiB /  6144MiB |      0%      Default |
|                               |                      |                  N/A |
+-------------------------------+----------------------+----------------------+

+-----------------------------------------------------------------------------+
| Processes:                                                                  |
|  GPU   GI   CI        PID   Type   Process name                  GPU Memory |
|        ID   ID                                                   Usage      |
|=============================================================================|
|    0   N/A  N/A     14189      G   ...xorg-server-1.20.14/bin/X        9MiB |
|    0   N/A  N/A     14217      G   ...hell-43.1/bin/gnome-shell        2MiB |
+-----------------------------------------------------------------------------+

What if you set cuda explicitly in your config?
  config: [
    nx: [
      default_backend: EXLA.Backend,
      default_defn_options: [compiler: EXLA, client: :cuda]
    ]
  ],
  system_env: [
    XLA_TARGET: "cuda"
  ]

You can also run: EXLA.Client.get_supported_platforms() and see if CUDA is listed. If it isn't, for some reason XLA is not identifying your GPU device.

And additionally EXLA.Client.default_name() to get the name of the default one.

When I encountered this I had run the Livebook before I had set the XLA_TARGET, so XLA was already compiled with only CPU support. Even after adding the XLA_TARGET and ensuring I had CUDA and cuDNN installed properly I would get 14:30:19.336 [info] TfrtCpuClient created..
I solved this by deleting the xla and mix folders in ~/.cache, as I couldn't see a clean way to run mix deps.clean xla --build in Livebook.

@jonatanklosko we should consider the XLA_TARGET in the cache key, right?

@zolrath Yes, that is what must have happened to me as well. I did get CUDA at first, and then could not switch back to it no matter what I tried. Thanks everyone for your help, and thanks @seanmor5 and @josevalim for an amazing project!

@josevalim ohh I've just realised that setting the env var and restarting runtime is not enough (unless the env var is set in Mix.install options). That's because we changed XLA to look at the initial XLA_TARGET, rather than every time it compiles. So in a mix project that would require mix deps.clean xla --build and for mix install force: true.

Do you remember why we did such change?

Actually what I was remembering is XLA_BUILD (https://github.com/elixir-nx/nx/issues/845#issuecomment-1193780545). The issue with XLA_TARGET is that we compile dependencies only once, specifically exla.
Inside the exla project if you call mix compile with a different XLA_BUILD it will pick up the new version, but if you call mix compile in a project that depends on exla, it wouldn't pick up the change, since exla doesn't recompile.

But it works if we pass it to Mix.install/2 or force build, right?
maybe we should have an option to “force build” from Livebook UI? Maybe a drop down on the “Reconnect and setup”?

I'm able to use cuda now, shall I close it?

We will close it @xrd as soon as we figure out how to improve the user experience :)

Actually, one way to improve this would be to add:
system_env: %{"XLA_TARGET" => System.get_env("XLA_TARGET")}

this will enforce system differences to be picked up.

So I guess the best option is some UI to force installation the next install?

That could be useful in other cases too. Would we modify the code on the fly to include force: true?

@jonatanklosko there is an env var called MIX_INSTALL_FORCE, we can set it to "true" before we evaluate.

Moved to Livebook backlog: https://github.com/livebook-dev/livebook/issues/1579


InsecureRequestWarning: Unverified HTTPS request is being made. Adding certificate verification is ... Do I need to worry about this?

I've started getting message like this when running the DD with x509 validation and a proxy.  Is this something I should worry about?
export DATA_DISPATCHER_URL=https://metacat.fnal.gov:9443/dune/dd/data
export DATA_DISPATCHER_AUTH_URL=https://metacat.fnal.gov:8143/auth/dune
export METACAT_SERVER_URL=https://metacat.fnal.gov:9443/dune_meta_demo/app
export METACAT_AUTH_SERVER_URL=https://metacat.fnal.gov:8143/auth/dune
...
Start Project for : files from schellma:run5141recentReco ordered limit 10
Project ID: 236
DDInterface: the query is: files from None limit 1
2022-12-15 12:16:34.197233
/cvmfs/fermilab.opensciencegrid.org/products/common/prd/python_request/v2_9_1/NULL/lib/python/requests/packages/urllib3/connectionpool.py:787: InsecureRequestWarning: Unverified HTTPS request is being made. Adding certificate verification is strongly advised. See: https://urllib3.readthedocs.org/en/latest/security.html
warnings.warn((
c79127f4

That error seems to be coming from /cvmfs/fermilab.opensciencegrid.org/products/common/prd/python_request/v2_9_1/NULL/lib/python/requests/packages/urllib3/connectionpool.py. I am not sure what that is


Expect warnings for EnforceSuperclass during tests

Right now when running bundle exec rspec to run the test suite, the following warning pops several times:
`RuboCop::Cop::EnforceSuperclass` is deprecated and will be removed in RuboCop 2.0. Please upgrade to RuboCop Rails 2.9 or newer to continue.

As I believe it's expected behavior, I'm suggesting to silence them during the test suite

Before submitting the PR make sure the following are checked:

[x] The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
[x] Wrote good commit messages.
[ ] Commit message starts with [Fix #issue-number] (if the related issue exists).
[x] Feature branch is up-to-date with master (if not - rebase it).
[x] Squashed related commits together.
[x] Added tests.
[x] Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
[ ] Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

Thanks!


Implement a rollback mechanism for all other Okta transactions (besides creating an organization)

Currently many of our endpoints create entities in both postgres and Okta, but in the event of an error, postgres transactions get rolled back while Okta ones do not. This can leave weird inconsistencies where an error causes a user's email in Okta to get claimed even though it still remains available in postgres. The most pressing example of this is in the account request sign-up flow, where a new organization and a new user are created in Okta (and in postgres).
Ticket https://app.zenhub.com/workspaces/simplereport-growth--engagement-605b43a6ceb92c000f86279a/issues/cdcgov/prime-simplereport/1614 investigates and implements rollback mechanisms so that if an error occurs mid-request after an organization has been created in Okta, that transaction will be reversed.
For this ticket, create rollback mechanisms for all other Okta transactions. (If after ticket 1614, it becomes clear that this present ticket is too large in scope, feel free to break it up.)

closing until we see an example of this in the wild


cleanup: revert unused changes

to reduce diff from upstream.

never mind... it was use in CheckProofOfWork2


Merge pull request #1 from apache/master

Pull recent changes - May 15, 2016

Pull recent changes - June 3, 2016

Pull recent changes - June 3, 2016

Coverage increased (+0.01%) to 93.419% when pulling a7298622e112280fe8ef46e5844155eb474d3a98 on Force66:master into 03a2ab275b94f19003de12b0009639bf8f831a13 on apache:master.


FIX Adoption prompt: New way to obtain position embeddings

This PR resolves the failing adoption prompt tests in the CI using transformers installed from source.
In this transformers PR:
https://github.com/huggingface/transformers/pull/34858/
the module.rotary_emb attribute has been removed, which adoption prompt so far assumed was present. Instead, the position_embeddings are now already computed and can be taken directly from the kwargs.

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

But cos and sin are guaranteed to be present during the model's forward anyway 👌


When running /purge the bot doesn't respond

The command works as desired, it just doesn't respond to the interaction, instead showing this:

Fixed this in 3ee1c59e96b16cff8c600fb7bb8e61c98038faf9 by making it actually respond on success


Upgraded to Angular v13

@linnenschmidt  Is it possible to get this merged please? I am using angular 13 now, and it would help tremendously to be able to continue to use this package.

@meraj-ahmed This lib doens't seem to be updated
We might have to create a new lib forked from this and add it to npm.
I was going to implement the needed changes to use in angular 13 when i had the idea to come here to the pull requests tab.
Maybe @linnenschmidt  doesn't have the time for it right now. I had much much smaller libs and didn't have time to update in the past
@linnenschmidt can you add someone else to the project so that it can merge things? Thanks for your work 💯

@mdudek noticed that you didn't change the tests directory. Maybe this is important to test that it works with Angular 13. FIles at https://github.com/linnenschmidt/build-ng-packagr/tree/master/tests/build_ng_packagr/ng-packaged

@iursevla Thanks for the response. I ended up just implementing ng-packagr instead, which now supports copying static assets.

@meraj-ahmed ah I see
In my case I'm copying static assets but expecting to rename the directories (e.g. from A/ to dist/C). Do you know if ng-packagr supports that?

@mdudek for the time being using your changes (did a fork from your pull request) plus some minor updates (mostly versions of packages) I have it working for Angular 13 on my company's library
Here's the npm package: https://www.npmjs.com/package/@iursevla/build-ng-packagr
The Github page is: https://github.com/iursevla/build-ng-packagr


Chrome v45: Unexpected token ...

Uncaught SyntaxError: Unexpected token ...

Changed because minimal supported version for the ARC is 45.

the same in 46

The fix will be available in next update.


CSS property completion with semicolon should place cursor at the end after inserting value

This is pretty self-explanatory. Before "CSS property completion with semicolon" was added my workflow was okay, the feature was really missing(!) but:

inserted colo
selected color from dropdown
inserted red;
pressed enter to go to next line for new prop

And now it is:

inserted colo
selected color from dropdown
inserted red
move cursor one right
pressed enter to go to next line for new prop

So it's really making it worse now to move the cursor to go to the next line.

You can press ctrl/cmd + enter to jump over the semicolon.

I really thought I was losing my mind because this setting wasn't taking effect no matter what I tried. Restarted vscode, rebooted my machine, etc. Turns out there are three settings to watch out for:
css.completion.completePropertyWithSemicolon
scss.completion.completePropertyWithSemicolon
less.completion.completePropertyWithSemicolon

Since I despise the new workflow it made sense for me to set them all to false.


(Re)Calculate SEO Score in realtime with javascript without need to save first

I did have a go at this but because the stars are updated via updateCMSFields I couldn't update those fields via javascript.
I think we would need to separate out the extension into a model and controller so we'd have access to $allowed_actions in the controller.
Once some of the fields are in templates this might be easier to complete.

@hubertusanton I am thinking that this may no longer be possible if #36 gets implemented? As each related phrase would need the current page to be updated in order to re-calculate the score?
What do you think @hubertusanton ?

i hope so, i'm wondering how this is done and if it's possible to also default just have 1 search phrase, that way someone who uses the module without this feature understands it as well.


Don't error if job hasn't been submitted yet (resolves #1666)

@cket this is ready for review

Oh, looks like this is a duplicate of @lordzappo 's #1682
Sorry!


cmd/cgo: ${SRCDIR} does not handle paths with %

What version of Go are you using (go version)?
go version go1.6.3 linux/amd64
Also tested with go version go1.6.3 linux/amd64
What operating system and processor architecture are you using (go env)?
GOARCH="amd64"
GOBIN=""
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"
GOPATH=""
GORACE=""
GOROOT="/usr/local/go"
GOTOOLDIR="/usr/local/go/pkg/tool/linux_amd64"
GO15VENDOREXPERIMENT="1"
CC="gcc"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0"
CXX="g++"
CGO_ENABLED="1"

What did you do?
mkdir a%2fb
cd a%2fb
mkdir include

Save this Go program as a%2fb/silly.go:
package main

// #cgo CFLAGS: -I"${SRCDIR}/include"
import "C"

func main() {
}

What did you expect to see?
Expected successful compilation/execution of the program.
What did you see instead?
# go run silly.go
package main: /somewhere/a%2Fb/silly.go: malformed #cgo argument: -I/somewhere/a%2Fb/include

This happens for CFLAGS and LDFLAGS on multiple architectures.
Related to #7906, #16455, #11868, which all discuss spaces in paths; there are issues with other valid path characters as well.
This path was not something I created naturally; it was a side-effect of our CI environment (Jenkins) which occasionally uses paths like foo%2Fbar if a Git branch has a name "foo/bar". It also can create paths like foo%2Fbar@2 when a second scratch directory is needed.

I am able to use bind mounts as a workaround. Something like:
mkdir /simplename
mount -o bind $PWD /simplename
cd /simplename
<go commands that previously failed...>

Have you tried "-I${SRCDIR}/include" (that is, put quotes around the entire argument?)

Behavior is the same with full argument quoting.

Note: I tried full argument quoting for CFLAGS with -I but did not re-test LDFLAGS.

The list of allowed characters for $SRCDIR is src/go/build/build.go's safeString. % is not one of them.
I am a bit wary of adding % for fear that it will lead to environment variable interpolation on Windows,
but I guess we can try it.


[SPARK-25353][SQL] executeTake in SparkPlan is modified to avoid unnecessary decoding.

What changes were proposed in this pull request?
In some cases, executeTake in SparkPlan could decode more than necessary.
For example, in case of below odd/even number partitioning, total row's count from partitions will be 100, although it is limited with 51. And 'executeTake' in SparkPlan decodes all of them, "49" rows of which are unnecessarily decoded.
spark.sparkContext.parallelize((0 until 100).map(i => (i, 1))).toDF()
      .repartitionByRange(2, $"_1" % 2).limit(51).collect()

By using a iterator of the scalar collection, we can make ensure that at most n rows are decoded.
How was this patch tested?
Existing unit tests that call limit function of DataFrame.
testOnly *SQLQuerySuite
testOnly *DataFrameSuite

Can one of the admins verify this patch?

Can one of the admins verify this patch?

cc: @maropu @viirya @kiszk @HyukjinKwon
This PR is separated from https://github.com/apache/spark/pull/22219 by @maropu's opinion.

Can one of the admins verify this patch?

Thank you for your update.
Is it better to add test case to confirm the state of the internal structures is as you expected? @maropu

@kiszk
It is impossible counting decoded rows without modify SparkPlan, because there is no way of counting iterated size.
Instead I can simulate this patch in Scala WorkSheet with below code.
var decodeCount = 0
def decoding(buf: Array[Int]): Iterator[String] = {
  new Iterator[String] {
    var remain = buf.sum
    var index = 0
    override def hasNext: Boolean = remain > 0
    override def next(): String = {
      while (buf(index) == 0) index += 1
      buf(index) -= 1
      remain -= 1
      decodeCount += 1    // increase decodeCount
      f"[decode Result:$remain]"
    }
  }
}

// reset decodeCount
decodeCount = 0

// Before Patch : decode without scala view
val buf = new ArrayBuffer[String]
val inputIter = Array(Array(2, 2, 2), Array(2), Array(2)).iterator
while (inputIter.hasNext) buf ++= Array(inputIter.next()).flatMap(decoding)
val result1 = buf.take(3).toArray

// ensure decode count is 10
assert(decodeCount == 10)

// reset decodeCount
decodeCount = 0

// After Patch : decode with scala view
val result2 = ArrayBuffer(Array(2, 2, 2), Array(2), Array(2)).toArray.view
  .flatMap(decoding).take(3).force

// ensure decode count is 3
assert(decodeCount == 3)

// assert same element
assert(result1 sameElements result2)

btw, do we have any actual performance benefit (wall time) from this patch?

Let me leave this ok to test since there looks a progress here anyway.

ok to test

Test build #95859 has started for PR 22347 at commit a8f1481.

Test build #95859 has finished for PR 22347 at commit a8f1481.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95859/
Test FAILed.

I tested in my local PC. 3.3 GHz Intel Core i5, and selected 400,000 rows x 25 times.
I took a total execution time between decodeUnsafeRows.
My tested data is skewed, so gathered rows from executor are distributed between 400000 and  800000.
The average execution time decreased from 175.92ms to 93.52ms.
Memory usage also improved, and total GC Time is decreased from 13.883 sec to 10.764 sec.
Before Patch
GC statics

S0
S1
E
O
M
CCS
YGC
YGCT
FGC
FGCT
GCT

0
100
24.92
48.66
96.92
88.25
150
13.883
0
0
13.883

Wall time : AVG 175.92 ms

Row Count
Decode Time(ms)

428942
73

473726
106

476322
78

509996
83

510590
124

556896
94

556896
362

595272
193

595272
175

642478
120

644970
279

679544
269

693354
116

723532
124

729912
136

730218
120

730246
184

773640
183

774148
380

810198
128

811606
131

859090
138

895474
314

895954
339

939636
149

After Patch : 93.52ms
GC statics

S0
S1
E
O
M
CCS
YGC
YGCT
FGC
FGCT
GCT

0
100
81.37
33.34
97.21
88.35
127
10.764
0
0
10.764

Wall time : AVG 93.52 ms

Row Count
Decode time (ms)

421922
61

422516
180

422850
110

473218
62

473218
103

473438
115

507198
60

554606
144

557202
119

601392
71

642652
61

645276
64

679036
64

679036
63

729624
242

729652
62

729912
131

773814
122

774234
62

807908
59

810198
64

814900
72

844772
59

858582
127

858582
61

Jenkins, retest this please

Test build #95892 has started for PR 22347 at commit a8f1481.

Test build #95892 has finished for PR 22347 at commit a8f1481.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95892/
Test PASSed.

Retest this please.

Thank you for your first contribution, @Dooyoung-Hwang ! So, this is a spin-off PR from STS?

Thank you for review.
Yes, ThriftServer will use intermediate "collection view" in this PR.
And Original PR of ThriftServer will be updated accordingly ,if this PR is merged.

Test build #96870 has finished for PR 22347 at commit a8f1481.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96870/
Test PASSed.

Test build #96937 has started for PR 22347 at commit 8666272.

I added example code of issue case to the content of PR.

Test build #96937 has finished for PR 22347 at commit 8666272.

This patch fails SparkR unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96937/
Test FAILed.

@dongjoon-hyun can this be merged?

retest this please

Test build #97242 has started for PR 22347 at commit 8666272.

Test build #97242 has finished for PR 22347 at commit 8666272.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97242/
Test PASSed.

please merge

Can one of the admins verify this patch?

Is it better to revisit this? cc @maropu

Looks ok to me, but I think we need more comments from other reviewers... cc: @dongjoon-hyun @viirya @cloud-fan

retest this please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/12254/
Test PASSed.

Test build #107061 has started for PR 22347 at commit 8666272.

LGTM, @maropu can you take it over if @Dooyoung-Hwang is not active?

sure.
@Dooyoung-Hwang are you there?

Test build #107061 has finished for PR 22347 at commit 8666272.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/107061/
Test PASSed.

@maropu
Thank you for review. I will prepare for a patch following @cloud-fan's comment.

Test build #107078 has started for PR 22347 at commit e09a10d.

Test build #107082 has started for PR 22347 at commit 8685e2c.

Test build #107078 has finished for PR 22347 at commit e09a10d.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/107078/
Test FAILed.

Test build #107082 has finished for PR 22347 at commit 8685e2c.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/107082/
Test FAILed.

retest this please

Test build #107091 has started for PR 22347 at commit 8685e2c.

LGTM, pending Jenkins.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/12270/
Test PASSed.

Test build #107091 has finished for PR 22347 at commit 8685e2c.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/107091/
Test FAILed.

retest this please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/12275/
Test PASSed.

Test build #107095 has started for PR 22347 at commit 8685e2c.

Maybe this test code in DataFrameSuite causes OOM.
   // SPARK-12340: overstep the bounds of Int in SparkPlan.executeTake
    checkAnswer(
      spark.range(2).toDF().limit(2147483638),
      Row(0) :: Row(1) :: Nil
    )

oh.... this pr makes the memory pressure higher in the query?

Test build #107098 has started for PR 22347 at commit 7266236.

Ah I see the problem, we should not create the result array ahead, as the limit can be large but the data only has very few records.

is that bad like this? I like the previous version because that was simple:
val rowCount = if (scannedRowCount < n) scannedRowCount else n
val buf = new Array[InternalRow](rowCount)

Test build #107095 has finished for PR 22347 at commit 8685e2c.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/107095/
Test FAILed.

Test build #107103 has started for PR 22347 at commit 29e27aa.

Test build #107098 has finished for PR 22347 at commit 7266236.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Test build #107103 has finished for PR 22347 at commit 29e27aa.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/107103/
Test FAILed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/107098/
Test FAILed.

retest this please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/12286/
Test PASSed.

Test build #107107 has started for PR 22347 at commit 29e27aa.

Test build #107107 has finished for PR 22347 at commit 29e27aa.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/107107/
Test PASSed.

thanks, merging to master!


Feature Request: Have gamepiece buttons disabled when it's not the player's turn

Issue Context
Here we can see that the user can click a button even when it's the computer's turn to play. This should... not be so.

Suggested Solution
Behind the scenes, an active game exists in one of four turn states
type Player
    = Human
    | Computer

type alias Winner =
    Player

type Turn
    = ChoosingPiece
    | ChoosingCellToPlay ChosenPiece

type GameStatus
    = InPlay ActivePlayer Turn
    | Won Winner
    | Draw

Based on these types, the valid gamestatuses can be
Inplay Human ChoosingPiece
Inplay Computer ChoosingPiece
Inplay Human ChoosingCellToPlay ChosenPiece
Inplay Computer ChoosingCellToPlay ChosenPiece
Won Winner
Draw
Note that of these 6 options, the only time a game piece should be selectable is the first one, when a person is choosing a piece.
The view logic in Top.elm will have to be modified so the buttons are disabled except when the game is that specific turn state.
Alternatives Considered
Additional Resources

See here in the read me for how to run and install the application.
See here in contributing for the basics on forking and cloning the repository.

I'd like to take this on!

All yours my friend


Remove ReaderInputStream in favor of the commons.io version

Another tweak to socrata-http from talking with @rjmac.

socrata-http #120 SUCCESS
This pull request looks good

Great, thanks.  I wonder why we implemented our own version -- there were no comments to explain it.   Going to merge.


refactor gateways send_payment_v2

I don't really have any context on what this is refactoring. Is it just moving logic that was previously in the gateway into the gateway's client module?

@m1sterc001guy yes. This ist just to factor it in a similar way as receiving payments is factored now.


Proposal for unknown key error

There are realistically a few cases when unknown key errors occurs:

A fully deprecated variable.
Depending on the implementation, a variable that is references in other variables.
Since json doesn't support comments, one might add a variable as comment.

The other possible scenario is that a user made a typo with a specific variable. As the possibilities are finite, I think a typo can be detected and causing an error before running the flow.

Agreed.


chore(deps): update Microsoft.Extensions.Logging.* dependencies

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

AWS CodeBuild CI Report

Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository


Failed to load the clipboard-plus package

Try to update clipboard-plus to 0.4.0

Atom Version: 0.211.0
System: Microsoft Windows 10 Pro Insider Preview
Thrown From: clipboard-plus package, v0.4.0
Stack Trace
Failed to load the clipboard-plus package
At variable @ui-padding is undefined in C:\Users\Jordi Orlando\.atom\packages\clipboard-plus\styles\clipboard-plus.less:15:11

LessError: variable @ui-padding is undefined
  at C:\Users\Jordi Orlando\.atom\packages\clipboard-plus\styles\clipboard-plus.less:15:11

Commands
  2x -9:53.5.0 core:backspace (atom-text-editor.editor.mini.is-focused)
  3x -9:46.5.0 core:confirm (atom-text-editor.editor.mini.is-focused)
     -0:40 settings-view:check-for-package-updates (atom-workspace.workspace.scrollbars-visible-always.theme-base16-eighties-one-dark.theme-spacegray-eighties-ui)

Config
{
  "core": {
    "disabledPackages": [
      "minimap-color-highlight",
      "atom-color-highlight",
      "project-palette-finder"
    ],
    "themes": [
      "spacegray-eighties-ui",
      "base16-eighties-one-dark"
    ]
  }
}

Installed Packages
# User
atom-html-preview, v0.1.8
atomatigit, v1.5.3
autoclose-html, v0.18.0
autocomplete-clang, v0.7.0
autocomplete-paths, v1.0.2
base16-eighties-one-dark, v0.2.2
clipboard-plus, v0.4.0
color-picker, v2.0.7
file-icons, v1.5.8
hex, v0.6.2
highlight-line, v0.11.0
highlight-selected, v0.10.1
language-arduino, v0.2.1
language-scala, v1.1.3
linter, v1.0.4
linter-clang, v2.26.0
linter-csslint, v0.0.13
linter-htmlhint, v0.0.16
linter-jshint, v0.1.6
minimap, v4.10.0
minimap-git-diff, v4.1.3
minimap-highlight-selected, v4.3.0
minimap-selection, v4.2.0
pretty-json, v0.3.3
project-manager, v1.15.10
spacegray-eighties-ui, v1.0.0
Sublime-Style-Column-Selection, v1.3.0
tab-control, v0.6.6
tabs-to-spaces, v0.11.0

# Dev
No dev packages

This also happens on my Macbook Pro running OS X 10.10.3 and Atom 0.211.0

Please try the latest version.

Works perfectly, thanks!

:smiley:


Geolocation weather doesn't work

Watch: Pebble Time Steel
Phone: Nexus 6P (64GB, Android N NPD56N Dev Preview 4)
Watch Face Version: 6.3 (updated June 19th)
When Weather location is set to Automatic (GPS) the watch face doesn't update the current weather. When Weather location is set to Manual, the watch face does update. I have tried setting it back to Automatic after the initial retrieval and the watch face uses the "cached" Manual location values.

I also have this problem. The error from wunderground is "querynotfound", location is /api/(my_key)/conditions/q/undefined,undefined.json

Hmm, it would appears that the last version may have broken something with weather when automatic location is used. I'll have to look into it and see what I can find.

Allright, I just pushed out a new version that should fix this issue. The problem was that the logic I added for the stored coordinates was running even when you didn't have stored coordinates.


Add namespace command executor

Usage:
> active namespace a
> ok

You can do some operations in the namespace 'a' after you actived the namespace 'a'.

Could you please add the usage of the command line in the PR descriptor?

close #497


Using test result as a condition?

Edit: reworded issue.
I have some tests that fill a DIN A4 page because each sub-check depends on the previous step to check out (think testing several assumptions about kerning classes one after the other where checking later stages makes no sense if something before that fails). I'd like to break these into separate checks where later checks don't execute if previous checks fail. Achievable or should I do something else?

As you already suggested before the rewording, make them into conditions and have the checks just be thin layer looking at the condition values. Dependencies can be modeled using the conditions argument of the check decorator.

About boilerplate: you may be able to meta-program it away …

yeah. I think that the strategy suggested by Lasse is good enough for our current codebase/code-style. I will close this issues as this does not seem to be an actual fontbakery bug, but feel free to continue using this space as a forum for discussing strategies related to implementing your new checks.


Strange InvalidCastException of System.Text.Json for 3.0 preview7 only

Describe the bug
        [HttpGet]
        public ActionResult<IEnumerable<ValueB>> Get()
        {
            var valueAs = Enumerable.Range(0, 10).Select(x => new ValueA { Value = x }).ToList();
            return new ActionResult<IEnumerable<ValueB>>(valueAs.Select(x => new ValueB { Value = x.Value }));
        }

It will throw InvalidCastException: Unable to cast object of type 'aspnetcorebug.Controllers.ValueB' to type 'aspnetcorebug.Controllers.ValueA'.
by System.Text.Json.JsonPropertyInfoNotNullable<TClass, TDeclaredProperty, TRuntimeProperty, TConverter>.OnWrite(ref WriteStackFrame current, Utf8JsonWriter writer)
To Reproduce
Sample code:
https://github.com/iron9light/aspnetcore_issue12569
Expected behavior
It should return serialized json list.
It works with preview6 and works with NewtonsoftJson.
Additional context
Add any other context about the problem here.
Include the output of dotnet --info
.NET Core SDK (reflecting any global.json):
 Version:   3.0.100-preview7-012821
 Commit:    6348f1068a

Runtime Environment:
 OS Name:     Windows
 OS Version:  10.0.18362
 OS Platform: Windows
 RID:         win10-x64
 Base Path:   C:\Program Files\dotnet\sdk\3.0.100-preview7-012821\

Host (useful for support):
  Version: 3.0.0-preview7-27912-14
  Commit:  4da6ee6450

@iron9light looks like a bug in the JsonSerializer. I tried running your app using a preview8 (Microsoft.NETCore.App v3.0.0-preview8-28373-17) build and it looks like this issue has been resolved - it prints the serialized output.
/cc @ahsonkhan \ @layomia \ @steveharter \ @ericstj in case you'd like to link this to a CoreFx issue.


notes sometimes disappear on monster

while playing monster on some sections one note will just disappear right before youre about to hit it :/

version?

latest version, 1.5.4

btw notes also disappear on satin panties

video?


Add documentation about ways to add custom breaking of words or remove it completely

Description
After watching the video, I checked if docs have this:

...It doesn't, so should be added. Actually, some other things from that and other videos should also be documented.

While I don't disagree with making stuff like this more discoverable, it is wrong that this doesn't exist in the docs at all. All of these are listed in the symbol list with their shorthand and their full name which is where they should be found, as they are symbols. This is not to say they couldn't appear somewhere else in the docs but the premise is somewhat wrong.
Also, I would kindly ask to change the title of this issue as removing them is not a suitable alternative.


Set up linting and lint and formatting

📺 What
Set up opinionated linting and formatting with eslint and prettier.
🛠 How
Prettier runs when you commit and formats the commited code.
Automatic linting is left as a todo after this is merged.
We want to agree on a set of linting and formatting rules before we re-lint and re-format the code on a large scale.

TODO: only lint staged files


pull the mainline latest of 8/23/2024

@naiming-zededa This is not yet the rebase of the clustering changes on top of the mainline latest, correct?


Fix problems with IMATH_VERSION

The "IMATH_VERSION_EXTRA" cannot be incorporated into IMATH_VERSION
because CMake versions need to in the form be
major.minor[.patch[.tweak]] and IMATH_VERSION gets folded all the way
into ImathConfigVersion.cmake, and thus messes with downstream
projects.
I have now renamed "IMATH_VERSION_EXTRA" to "IMATH_VERSION_SUFFIX" for
clarity, and instead of appending it to IMATH_VERSION, I just
incorporate it into IMATH_PACKAGE_NAME, which can be an arbitrary
string. That will print the right designation when it's used, but without
polluting the numeric version.
Signed-off-by: Larry Gritz<EMAIL_ADDRESS>

Notes: (1) this may conflict slightly with #145, which will need a bit of merge reconciliation; (2) OpenEXR will need an equivalent change, I think. (3) I haven't looked at the release branches to see if the equivalent of this needs to be applied to any of those.

Abandoning, as Cary has folded the equivalent changes into #145


2nd accessory not showing up in homekit

Having a hard time getting my homekit to see the second accessory in my json file.  I am sure it's just something I am doing wrong though.  Here is my file if that is helpful...
{
"bridge": {
"name": "Homebridge",
"username": "CC:22:3D:E3:CE:30",
"port": 51826,
"pin": "031-45-154"
},
"accessories": [{
		"accessory": "MagicHome",
		"name": "LED Strip",
		"ip": "<IP_ADDRESS>",
		"setup": "RGBW",
		"purewhite": false,
		"singleChannel": false
	},
	{
		"accessory": "MagicHome",
		"name": "LED Strip 2",
		"ip": "<IP_ADDRESS>",
		"setup": "RGBW",
		"purewhite": false,
		"singleChannel": false
	}
]

}

Look like your config is correct.
This is the site for check the config file
https://jsonlint.com

Try to uninstall homebridge and reinstall it. But if homebridge sees the first accessory maybe not the path is the problem. Does the first accessory work?

The first accessory works great.  I actually tried removing the json file to see if I could "break" it and it sill worked. Which is what makes me think its somehow pulling from somewhere else.  I tried un-installing it and re-installing it and it made no difference.


onResizeStop and onDragStop callbacks should return updated layout

I'm not sure why a callback for changing state would return the old state that we already have. In my opinion this should be returning the updated layout state.

Because onLayoutChange has that new layout state. This is just to notify you of a specific action.

@STRML Right, but different actions might need to be performed based on whether the grid changed from a drag or a resize, and onLayoutChange doesn't allow that.

Hmm that makes sense. I'm thinking about why it was there. In fact, it's really not well done as the onDragStop handler passes a modified layout after the moveElement call but before compaction. I can't understand why this was done.
I need to look into "why" to make sure we don't break anything big but otherwise I think this is a good change. If you have a moment could you add a test?

Yep I'll try to get that done today! Also one more case for this change is that onLayoutChange is called on initial render, which isn't suitable for change effects.

@STRML This one got away from me! I'm trying to add a test and struggling to figure out how to simulate a drag or resize event such that the callbacks are called. Do you have any pointers? I know this issue has been a problem for others as well, so would be great to get it out there.

There should be some examples of simulating that in the react-draggable and react-resizable libraries that will help out. You could just copy the helpers over.

Right that is the first place I looked, but those don't seem to trigger the callbacks for whatever reason. I've tried a few other things but nothing's worked for me so far.

Should not be stale. Without these changes onResizeStop and onDragStop are pretty much useless.

I've found that onLayoutChange is called during the initial render as well (no layout changes), which means that I cant rely on this function to save an updated state. I will need to compare the args to what is currently in state and then save. I tried to get around this by using onResizeStop and onDragStop, which would allow me to save the updated state when one of these events occur to guarantee an update event. They seem to trigger as expected, but they dont pass an object array of allLayouts like onLayoutChange handler does, which renders them useless for my case. Maybe i'm not understanding how they are meant to be used.


Allow contributes.views into Comments panel / workbench.panel.comments

contributes.views at the moment allows contributing to the built-in explorer, scm, debug, and test view containers, as well as custom view containers. We would additionally like the capability to contribute a view to the workbench.panel.comments view container for the Comments panel.
Our extension has a need to display contextual information and actions alongside the Comments panel, e.g. a button to publish comments drafted by the user, if applicable. We are aware that commands can be contributed to the Comments panel already, but discoverability of commands that we put there has been extremely low for our users in the past year.
Since the Comments panel lives in the bottom panel, the alternative of contributing a web view with actions to e.g. the Explorer or SCM view container unfortunately leads to an inconsistent experience where this view is not guaranteed to show up together with the Comments panel automatically, as it depends on which sidebar the user happens to have open.
While users can manually drag any view into the Comments panel view container, they are unlikely to do so on their own initiative. ViewDescriptorService allows programmatically moving views in this manner, but is not available to extensions.
cc @JonasMa @laurentlb @a-stewart

This seems reasonable. Tentatively adding for July.

Moving to the backlog. I would also accept a PR for this!

Took a quick look into this and there are two parts:

Add the contribution point
Register the Comments view container (we don't do this until there are comments in the workspace right now).

The first part can be seen in https://github.com/microsoft/vscode/commit/cc9d4ffed8790bf7fe984c0e5e92e6c6166348e3

If this is still something folks want then I will reopen!


Add verify bundle

Adds a new verify bundle command that executes make bundle and ensures
the contents of ./bundle are unchanged.
Add a check for createdAt being the only change to the bundle and ignore
it. Since operator-sdk 1.26.0, make bundle changes the createdAt
field from the bundle even if there are not other changes.
see https://github.com/Kuadrant/kuadrant-operator/blob/main/Makefile#L427
Update out of date OLM bundle contents make bundle

/lgtm


fix: remove cdk re-exports from @angular/material

BREAKING CHANGE: @angular/material no longer re-exports symbols from
@angular/cdk.

Caretaker note: I have an internal change to go in before this one to prevent it from breaking anyone

Fixing unit tests, but that shouldn't block presumit

Unit tests were actually broken in #6822, and I sent a fix in #7117

needs rebase

Rebased


Could not load bitsandbytes native library: libcusparse.so.11: cannot open shared object file: No such file or directory

System Info
arch, kohya_ss, python 3.10
LD_LIBRARY_PATH ==
echo $LD_LIBRARY_PATH
:/opt/cuda/lib64/:/opt/cuda/nvvm/lib64/:/opt/cuda/extras/CUPTI/lib64/:/opt/cuda/targets/x86_64-linux/lib/

outpout of $PATH
echo $PATH
/usr/local/bin:/usr/bin:/bin:/usr/local/sbin:/opt/cuda/bin:/opt/cuda/nsight_compute:/opt/cuda/nsight_systems/bin:/var/lib/flatpak/exports/bin:/usr/lib/jvm/default/bin:/usr/bin/site_perl:/usr/bin/vendor_perl:/usr/bin/core_perl:/home/username/.local/share/yabridge

Reproduction
execute the following commands:
pip install bitsandbytes
python -m bitsandbytes

get this error:
Could not load bitsandbytes native library: libcusparse.so.11: cannot open shared object file: No such file or directory
Traceback (most recent call last):
  File "/home/username/kohya_ss/venv/lib/python3.10/site-packages/bitsandbytes/cextension.py", line 85, in <module>
    lib = get_native_library()
  File "/home/username/kohya_ss/venv/lib/python3.10/site-packages/bitsandbytes/cextension.py", line 72, in get_native_library
    dll = ct.cdll.LoadLibrary(str(binary_path))
  File "/usr/lib/python3.10/ctypes/__init__.py", line 452, in LoadLibrary
    return self._dlltype(name)
  File "/usr/lib/python3.10/ctypes/__init__.py", line 374, in __init__
    self._handle = _dlopen(self._name, mode)
OSError: libcusparse.so.11: cannot open shared object file: No such file or directory

CUDA Setup failed despite CUDA being available. Please run the following command to get more information:

python -m bitsandbytes

Inspect the output of the command and see if you can locate CUDA libraries. You might need to add them
to your LD_LIBRARY_PATH. If you suspect a bug, please take the information from python -m bitsandbytes
and open an issue at: https://github.com/bitsandbytes-foundation/bitsandbytes/issues

++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
++++++++++++++++++ BUG REPORT INFORMATION ++++++++++++++++++
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
++++++++++++++++++++++++++ OTHER +++++++++++++++++++++++++++
CUDA specs: CUDASpecs(highest_compute_capability=(8, 6), cuda_version_string='118', cuda_version_tuple=(11, 8))
PyTorch settings found: CUDA_VERSION=118, Highest Compute Capability: (8, 6).
To manually override the PyTorch CUDA version please see: https://github.com/TimDettmers/bitsandbytes/blob/main/docs/source/nonpytorchcuda.mdx
The directory listed in your path is found to be non-existent: local/thing
The directory listed in your path is found to be non-existent: @/tmp/.ICE-unix/1346,unix/thing
The directory listed in your path is found to be non-existent: /org/freedesktop/DisplayManager/Session0
The directory listed in your path is found to be non-existent: /org/freedesktop/DisplayManager/Seat0
The directory listed in your path is found to be non-existent: //debuginfod.archlinux.org
Found duplicate CUDA runtime files (see below).

We select the PyTorch default CUDA runtime, which is 11.8,
but this might mismatch with the CUDA version that is needed for bitsandbytes.
To override this behavior set the `BNB_CUDA_VERSION=<version string, e.g. 122>` environmental variable.

For example, if you want to use the CUDA version 122,
    BNB_CUDA_VERSION=122 python ...

OR set the environmental variable in your .bashrc:
    export BNB_CUDA_VERSION=122

In the case of a manual override, make sure you set LD_LIBRARY_PATH, e.g.
export LD_LIBRARY_PATH=$LD_LIBRARY_PATH:/usr/local/cuda-11.2,
* Found CUDA runtime at: /opt/cuda/lib64/libcudart.so.12.6.77
* Found CUDA runtime at: /opt/cuda/lib64/libcudart.so
* Found CUDA runtime at: /opt/cuda/lib64/libcudart.so.12
* Found CUDA runtime at: /opt/cuda/targets/x86_64-linux/lib/libcudart.so.12.6.77
* Found CUDA runtime at: /opt/cuda/targets/x86_64-linux/lib/libcudart.so
* Found CUDA runtime at: /opt/cuda/targets/x86_64-linux/lib/libcudart.so.12
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
++++++++++++++++++++++ DEBUG INFO END ++++++++++++++++++++++
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Checking that the library is importable and CUDA is callable...
Couldn't load the bitsandbytes library, likely due to missing binaries.
Please ensure bitsandbytes is properly installed.

For source installations, compile the binaries with `cmake -DCOMPUTE_BACKEND=cuda -S .`.
See the documentation for more details if needed.

Trying a simple check anyway, but this will likely fail...
Traceback (most recent call last):
  File "/home/username/kohya_ss/venv/lib/python3.10/site-packages/bitsandbytes/diagnostics/main.py", line 66, in main
    sanity_check()
  File "/home/username/kohya_ss/venv/lib/python3.10/site-packages/bitsandbytes/diagnostics/main.py", line 40, in sanity_check
    adam.step()
  File "/home/username/kohya_ss/venv/lib/python3.10/site-packages/torch/optim/optimizer.py", line 373, in wrapper
    out = func(*args, **kwargs)
  File "/home/username/kohya_ss/venv/lib/python3.10/site-packages/torch/utils/_contextlib.py", line 115, in decorate_context
    return func(*args, **kwargs)
  File "/home/username/kohya_ss/venv/lib/python3.10/site-packages/bitsandbytes/optim/optimizer.py", line 291, in step
    self.update_step(group, p, gindex, pindex)
  File "/home/username/kohya_ss/venv/lib/python3.10/site-packages/torch/utils/_contextlib.py", line 115, in decorate_context
    return func(*args, **kwargs)
  File "/home/username/kohya_ss/venv/lib/python3.10/site-packages/bitsandbytes/optim/optimizer.py", line 521, in update_step
    F.optimizer_update_32bit(
  File "/home/username/kohya_ss/venv/lib/python3.10/site-packages/bitsandbytes/functional.py", line 1571, in optimizer_update_32bit
    optim_func = str2optimizer32bit[optimizer_name][0]
NameError: name 'str2optimizer32bit' is not defined
Above we output some debug information.
Please provide this info when creating an issue via https://github.com/TimDettmers/bitsandbytes/issues/new/choose
WARNING: Please be sure to sanitize sensitive info from the output before posting it.

Expected behavior
expected behavior: libcusparse.so.11 should be installed by bitsandbytes if it is a dependency.

Hi @joshgura,
Since you've installed PyTorch with a CUDA 11.8 build, the libcusparse.so.11 should be available as it is included as a dependency. Unfortunately it's not sure where to find the library that was distributed with PyTorch. However, since your machine also has a CUDA 12 toolkit installed, it's trying to look there.
If you could, I would recommend switching to a CUDA 12.x build of PyTorch.
Alternatively, you can add ~/kohya_ss/venv/lib/python3.10/site-packages/nvidia/cusparse/lib/ to LD_LIBRARY_PATH as one option. This is where libcusparse.so.11 should be. You may additionally need to do the same for libcublas.so.11.


Support multiple sourceFiles

For large android project, sourceFile can be modified by many members of group.
And it is easy to conflict by Version Control System.
If feature-flag-android plugin supports multiple sourceFile(s), VCS conflict can be mitigated.

Closed by #34


Enable more linters

Enabled more linters (some were temporarily disabled):

bidichk
gofmt
goimports
revive

Resolved a few linting errors (nothing notable).

@x448 PTAL


SharePoint feature issue

Getting this below error
"For Each SharepointSite" -> Unable to initialize operation details for swagger based operation - Get_blob_content_(V2). Error details - Incomplete information for operation 'Get_blob_content_(V2)'
"Get blob content (V2)" -> Unable to initialize operation details for swagger based operation - Get_blob_content_(V2). Error details - Incomplete information for operation 'Get_blob_content_(V2)'
"List folder" -> Unable to initialize operation details for swagger based operation - List_folder. Error details - Incomplete information for operation 'List_folder'
and many steps are just going into "Skipped" State
Here is the example of env try with two different formate
Main URL - https://{mysharepoint.com}/sites/test/Shared Documents/Forms/AllItems.aspx?FolderCTUD=xyz&id=xyz"

export SHAREPOINT_TO_SYNC='[
{ "url": "https://{mysharepoint.com}", "folder": "sites/test/Shared Documents/Forms/AllItems.aspx?FolderCTUD=xyz&id=xyz" }
]'

export SHAREPOINT_TO_SYNC='[
{ "url": "https://{mysharepoint.com}/sites/test", "folder": "/Shared Documents/Forms/AllItems.aspx?FolderCTUD=xyz&id=xyz" }
]'
And also try the Document Library
export SHAREPOINT_TO_SYNC='[
{ "url": "https://{mysharepoint.com}/sites/test", "folder": "/Shared Documents/Forms/AllItems.aspx" },
{ "url": "https://{mysharepoint.com}", "folder": "/sites/test/Shared Documents/Forms/AllItems.aspx" }
]'
Can someone guide me here if doing something wrong or something? I followed all the steps which are mentioned in the documentation like authorizing the SharePoint online and run manually etc

Hello,
The SharePoint configuration should look like this
export SHAREPOINT_TO_SYNC='[ { "url": "https://{mysharepoint.com}/sites/test", "folder": "/Shared Documents/Forms" } ]'
It does not ingest singular files, but all files within a folder and it's sub-folders.
Our current pipeline also does not officially support aspx files.
https://github.com/microsoft/PubSec-Info-Assistant/blob/main/docs/features/sharepoint.md#document-support
The unable to initialize... errors are a bug with Logic App Preview Designer, they are purely cosmetic and do not impact the SharePoint ingestion process. Switch to the Generally Available Designer and these errors will go away.
https://github.com/microsoft/PubSec-Info-Assistant/blob/main/docs/knownissues.md#there-are-errors-in-the-sharepoint-logic-app-designer

This issue is marked for closure due to inactivity for 2 weeks. It will be closed in 5 days.

closing due to inactivity


Custom level up formula

Add the ability to set the formula for when to award a level up from the configuration file.
Currently the formula is simply: curLvl * 100

@Erigitic Depends on what we/you 'd like the JBRs to support I guess. I can think of some permanent issue to collect ideas and have a list about what's supported.

I've created an issue to track the progress.
Since this may result in an overhaul of the class I'll continue my suggestions in the tracking issue.


feat: Network ACL

Description
A dedicated network-acl sub-module was added.
Motivation and Context
We are using terragrunt to describe our infrastructure.
We have standardized subnet naming (e.g. "Transfer", "Transit", etc.) and subnets already provisioned for us by another team.
All we need to do is to create and associate NACLs with them.
The current VPC module allows us to create NACLs, but only the predefined ones (e.g. "public", "outpost", "redshift", etc.).
To support custom NACLs a simple module was created.
It has an optional subnet_ids input to associate NACL with subnets.
We are using this module within the organization and now decided to contribute it to the public VPC module.
Breaking Changes
No
How Has This Been Tested?

[x] I have updated at least one of the examples/* to demonstrate and validate my change(s)
[x] I have tested and validated these changes using one or more of the provided examples/* projects

examples/network-acl was used for the testing with existing VPC and subnet

[x] I have executed pre-commit run -a on my pull request

I completely understand what you want to achieve, but I don't think we should be maintaining it as a separate submodule for two reasons:

We need to improve the module to use some of the later features of Terraform (like we have done in EKS, RDS, and some other modules already).
If we add a NACL submodule, we need to add one for subnets, routes, routing tables, NAT gateways, etc. This is too much repetitive work.

I propose that instead of doing a separate module, we look into extending this module by managing extra resources (like NACL, subnets, etc) in the provided VPC. This is doable, but only after the first step from above is implemented (specifically, by using for_each instead of count).
@bryantbiggs WDYT?

I propose that instead of doing a separate module, we look into extending this module by managing extra resources (like NACL, subnets, etc) in the provided VPC. This is doable, but only after the first step from above is implemented (specifically, by using for_each instead of count).
@bryantbiggs WDYT?

For me it's sound great, How can I help to refactor this module?
My example sub-modules with for each loops.
https://github.com/terraform-aws-modules/terraform-aws-vpc/pull/834/files


Style formatted Pandas Dataframe with ,

Hi ,
I am using datapane table populated with formatted pandas dataframe. The issue is out of 6 column , one column transforms to date. Rest of the 5 columns display correctly with , formatted.

Thanks for the update - we've got some fixes for dataframe tables coming out in the next week that should fix this

closed in c36a4eb

closed in c36a4eb


docs: generated page displayed in section /docs/reference/

cc @lambdanis
The generated page injected into https://tetragon.io/docs/reference/tetragon-configuration/ is visible in https://tetragon.io/docs/reference/. It could be done like the other page where it's straight injected into the Markdown at creation without an intermediate page.

Is there a way to have it as a separate file, but not a separate docs page? I thought that maybe it can be hidden from the TOC by something like hide_summary: true (docs), but then I ended up with hide_summary: true being the title of the embedded page :) So I guess that would require a different way of embedding.


update version and setup.py

This just preps the code to be pushed to pypi as idem_azurerm

I can push without you merging this so no rush :)

forgot this guy was out there and made similar edits... closing without merge as it's now OBE


The writing-rules should be updated

After a few months, the writing rules should be updated now.
Some new features ought to be added:

[x] how to edit the course information, singlely edit readme or fork it and create a pr
[x] base rules should be obeyed when uploading new materials
[x] a more reasonable way to connect issue and pr, making the commit tree more clear

The all task had been finished by https://github.com/HITSZ-OpenAuto/hoa.moe/pull/93 and https://github.com/HITSZ-OpenAuto/hoa.moe/pull/94


Version for LV2018

Any chance of getting it for LV2018?

I've saved a version for LV2018 and added it to the v0.5.0 release. Please let me know if there are any issues with it!


feat: pretty-print for iterative deployment

Description of changes

This change introduces pretty-print log feature into iterative deployment.
Issue #, if available

Description of how you validated changes
Checklist

[X] PR description included
[X] yarn test passes
[X] Tests are changed or added
[ ] Relevant documentation is changed or added (and PR referenced)
[ ] New AWS SDK calls or CloudFormation actions have been added to relevant test and service IAM policies

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Closing in favor of https://github.com/aws-amplify/amplify-cli/pull/11051


LUA error at start

Hello, I'm getting the following error at start (Titan [Reputation Continued] v<IP_ADDRESS>), Italian WoW client:
1x TitanReputation/libs/lang.lua:37: attempt to call method 'LangitIT' (a nil value)
[string "@TitanReputation/libs/lang.lua"]:37: in function `UpdateLanguage'
[string "@TitanReputation/libs/lang.lua"]:47: in main chunk
Locals:
self =  {
LangdeDE =  defined @TitanReputation/locale/deDE.lua:3
GT =  defined @TitanReputation/libs/lang.lua:10
GetLangTab =  defined @TitanReputation/libs/lang.lua:4
UpdateLanguageTab =  defined @TitanReputation/locale/enUS.lua:3
UpdateLanguage =  defined @TitanReputation/libs/lang.lua:25
LangenUS =  defined @TitanReputation/locale/enUS.lua:9
}
(*temporary) = nil
(*temporary) =  {
LangdeDE =  defined @TitanReputation/locale/deDE.lua:3
GT =  defined @TitanReputation/libs/lang.lua:10
GetLangTab =  defined @TitanReputation/libs/lang.lua:4
UpdateLanguageTab =  defined @TitanReputation/locale/enUS.lua:3
UpdateLanguage =  defined @TitanReputation/libs/lang.lua:25
LangenUS =  defined @TitanReputation/locale/enUS.lua:9
}
(*temporary) = "attempt to call method 'LangitIT' (a nil value)"
TitanPanelReputation =  {
LangdeDE =  defined @TitanReputation/locale/deDE.lua:3
GT =  defined @TitanReputation/libs/lang.lua:10
GetLangTab =  defined @TitanReputation/libs/lang.lua:4
UpdateLanguageTab =  defined @TitanReputation/locale/enUS.lua:3
UpdateLanguage =  defined @TitanReputation/libs/lang.lua:25
LangenUS =  defined @TitanReputation/locale/enUS.lua:9
}

Hey @Arkewas,
this is because currently, we are missing an Italian localization for this addon. We should prevent erroring, instead, we should print a simple msg stating that we still miss localization for the given language. I will look into this.
If you find some time, I would appreciate it if you could take a look at the Italian localization and provide a translation for it :)
You can find it here: https://github.com/paulbuechner/titan-reputation/blob/main/locale/itIT.lua

Hi,
thanks for the fast reply. I've downloaded the file and I will take a look at it for sure.
Regards


Move o-auth2 authentication allow inactive user to edx drf extension

LEARNER-6512

@ahsan-ul-haq I apologize for this miscommunication.  If the mobile app's use of completion API needs OAuth2AuthenticationAllowInactiveUser, moving it to edx-drf-extensions is counter to the direction we are headed.  edx-drf-extensions is meant to be used across all IDAs.  However, OAuth2Authentication (and the like) cannot be used in any IDA other than the LMS - since it depends on the OAuth2 tables that should be accessible by only the LMS.
On the other hand, JWTAuthentication can be used across all IDAs since JWTs are stateless tokens and don't need to make any SQL table queries.
My initial confusion stemmed from whether mobile apps really need to make API calls to completion or can they just update their completions when accessing components via their web-views?  This was an implicit assumption made in the original ticket: https://github.com/edx/completion/pull/29
We have now gone down a possibly non-viable path.  At this point, I believe we either need to (1) update the mobile apps to use JWTs (if they need to call any of our non-LMS APIs) or (2) break abstractions and have completion depend on the LMS.  Are the mobile apps calling any non-LMS APIs today?  And if so, how are they doing so?
FYI @staubina

@nasthagiri Thanks for detailed clearance on this.
As per my knowledge this is the first time mobile team needed to call any non-LMS APIs.

Since the comment https://github.com/edx/edx-drf-extensions/pull/51#issuecomment-427903909 states that this is the wrong direction, and this PR includes DOP related changes which is long out of date, I am closing this PR.


fix: @rpiazza GitHub profile link

Hey, while scrolling through the README I randomly clicked on @rpiazza profile link which led to the GitHub 404 page due to a trailing ).
This PR simply removes it :)

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


AMQP-559: @RabbitListener Test Harness

Captures method arguments and results (when non-null return) in blocking queues to facilite
validation in tests.
Overrides the BPP and proxies the listener instance with CGLIB (listener methods must not be final).

PoC only, for review - needs docs.

Added a spy version. In some ways, the first version is better because you don't need a latch for one-way tests.
However, we can offer both; the other can also be used when spy won't work (e.g. final methods).

That's all for now.
I think I will be fine with the solution, so you can go ahead with anything what you have in mind on the matter.
Of course, I don't mean bypassing the farther nit-pick review :wink:

Thanks for the tip on ImportAware - pushed.
I still need to do the other suggestions you made, (which are good).

Pushed; let me know if you have further suggestions before I start the docs.

That's all for now.
No more ideas yet...

Pushed the change to support both spy and capture advice.
I got all kinds of NPEs when moving to after initialization (null connectionMonitor in the CF - presumably some side-effect of Mockito spy. Mockito does say you shouldn't use the spied object directly.
So I'm inclined to not spend more time. Any more thoughts?

Pushed

Pushed

Doc fix.

Fixing all Copyrights on merge...

Merged as https://github.com/spring-projects/spring-amqp/commit/f9ad86b9de8fc04056c2989063318077cf8f6937


chore(package): update babel-core to version 6.17.0

https://greenkeeper.io/

This pull request is now managed with CodeReviewHub. Refresh.


telescope.nvim is outdated

Checklist
See https://github.com/NixOS/nixpkgs/pull/178180#issuecomment-1197726116 cc @thatsmydoing

It seems like that data folder mentioned in that issue contains the mappings telescope needs to do syntax highlighting correctly. Any idea how to include it?

related https://github.com/nvim-lua/plenary.nvim/issues/390 + assocaited PR https://github.com/nvim-lua/plenary.nvim/pull/391

I think this can be closed once plenary is updated in nixpkgs.

My plenary PR has been merged but seems like luarocks hasn't been updated yet https://luarocks.org/search?q=plenary&non_root=on

This issue has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/telescope-nvim-not-working-with-home-manager/21667/2

Closing this since plenary in nixpkgs is from september 2022. A better fix might be https://github.com/NixOS/nixpkgs/pull/190824


Payload return from handler?

Looking to replace RabbitMQ with something a bit simpler, so now looking at Neoq.
It seems fairly straight forward for the "add jobs to queue, have handlers process the jobs" type of thing.
There doesn't seem to be a clear way for handlers to return data (eg resized image, etc) back to the job submitter though.
Does that need to be done separately?  eg have a db table for return data, probably indexed on job id or similar

Hi @justinclift, you're right that there's no clear way for handlers to return data.
Returning data (in the sense of a function return type) would be a synchronous workflow, which is not in scope for neoq.
While that's the case, I'd simply encourage you to think about your problem differently. Let's take your case of resizing images.
In a synchronous workflow for resizing images, you ask a function to perform a resize, and the caller of that function does something with the resized image bytes after they're returned. Typically, they're going to place the image in permanent storage.
In an asynchronous workflow like neoq, this can be achieved as follows:
Instead of the caller placing the returned bytes in permanent storage, the caller declares where it wants the handler to store the bytes, leaving the permanent storage responsibility up to the handler code.  It either downloads the original from the original URL, or grabs the base64-encoded bytes from original_base64, performs conversion, and places the result where storage specifies it should. On success, the resized image is guaranteed to be in the declared storage bucket and at the given path.

Thanks.  My example was just using image resizing as it's one of the code examples given.
My actual use cases though are substantially different from that, mostly around doing SQL operations or SQL adjacent things (database creation/deletion, running SQL queries and returning results, etc).
Can probably get away with returning SQL query results via a database table indexed on the job id.  Will experiment a bit and see how it goes. :smile:

Gotcha. In that case, I recommend inserting records in your tables directly from your Handler code.

Yeah, that's the initial idea I'm working with. :smile:


The speed of lite-model_movenet_singlepose_thunder_tflite_int8_4.tflite is very slow

Hi Author,
Have you ever tried "lite-model_movenet_singlepose_thunder_tflite_int8_4.tflite", the in8 quantized version? The inference speed is very slow compared to float version. I guess the quantize/dequantize operations in the model are the root cause, not sure.

The TensorFlowLite runtime is not optimized for x86_64 (amd) CPUs; inference on a RaspberryPi aarch64 INT8 is about 10 times faster.

Got it, that should be the reason. Another question, I review the structure of the lite-model_movenet_singlepose_thunder_tflite_int8_4.tflite, which is a quantization-aware trained model. I intend to extract the weights and bias value and convert them back to float type. For the weights, the quantization type is int8 while the bias looks like to be int32. For instance:

I have no idea about how to convert the bias back to float since there's only int8 quantization attribute in the corresponding layer such as:

Any suggestions? Thanks a lot.

Already have.
https://github.com/PINTO0309/PINTO_model_zoo/tree/main/115_MoveNet

Big thanks for your suggestions. Actually, the website you mention is not what I really need. As you guess, I intend to  inverse quantize INT8 model to float32 model. The reason is that the official float model has very bad accuracy for int8 quantization. Hence, I am thinking about getting better int8 quantization accuracy in such way, i.e, inverse quantize INT8 model to float32 model, and then do the int8 quantization. Moreover, I need to fine tune the thunder model based on such a float32 one.
I tried the approach you suggest:
tflite INT8 -> tensorflow-onnx -> onnx Float32 -> tflite Float32
Due to some reasons that cannot be overcome(some ops are not supported in related tools), I just succeed in converting to onnx float32. Based on the onnx model, I check the dequant layer to get the scale and zero_point data, and then inverse quantize to float32 simply using the formula:
R = (Q - Z) * S
where R is the float32 value, Q is the quantized int8 value, and Z, S are the zero point and scale respectively.
e.g:

I finally applied all the extracted weights/bias to thunder model and save as a pth model. The model can be inferenced normally but the results are very bad. I have no idea what could be the reason.

(some ops are not supported in related tools) This error is easy to work around. I won't go into details in this discussion because I've explained it so many times here and there that it's disgusting.
https://github.com/PINTO0309/PINTO_model_zoo/issues/150

@PINTO0309
Thank you very much for your answer.
@liamsun2019
I think the original question has been resolved.
Inverse quantization and post-quantization accuracy improvements are not supported by this repository and will be closed.

Sorry to bother. But it's not that easy.

convert tflite to onnx:
python3.6 -m tf2onnx.convert --opset 13--tflite lite-model_movenet_singlepose_thunder_tflite_int8_4.tflite --output model.onnx  --inputs-as-nchw serving_default_input:0
The opset must be set to 13 since per-axis quantization for some layers must be supported. Above command can be executed normally on my side.

convert onnx to tf
from onnx_tf.backend import prepare
import onnx
import os
import sys

TF_PATH = "./my_tf_model.pb"
ONNX_PATH = "./simplified.onnx"
onnx_model = onnx.load(ONNX_PATH)
tf_rep = prepare(onnx_model)  # creating TensorflowRep object
tf_rep.export_graph(TF_PATH)
where simplified.onnx is the model simplified by onnxsim using above model.onnx as the input.
The following error is reported:
onnx_tf_prefix_truediv_1;truediv_1/y1_prequant' is not a valid scope name
I cannot google any similar information.


feat(debugger): frame playground

Change Summary
This PR adds playground section to debugger where users can test how their frames are rendered.
TODO:

[x] - show syntax errors if there are any
[x] - add navigation debugger -> playground, playgroud -> debugger
[x] - add a way to debug an existing frame, somehow get the JSX definition if possible
[x] - fix buffer usage in browser/edge runtime, if still necessary

Merge Checklist

[x] PR has a Changeset
[x] PR includes documentation if necessary
[x] PR updates the boilerplates if necessary

Basic playground
You can either open a frame from debugger (if the frame is valid, you will see small icon button in top right corner of rendered frame). Also you can open playground directly and you will have default type definition open.

@stephancill I removed the playground and instead added new tab Image to debugger where you can see rendered svg with bounding boxes.

@stephancill I added Image debugging switch to sidebar, which is enabled if the frame contains debug info with image. Otherwise it is disabled and has an explanation in tooltip.

I also removed Image tab from diagnostics

@stephancill I did not implement svg image since that requires satori, @vercel/og is not able to return svg. I think for now it's good enough.

is there any way to detect debug mode and disable this toggle + set false if its not on?

@davidfurlong there is no easy way to detect debug mode. We can only rely on the data returned from frames app.

@davidfurlong I applied your suggestions.

lgtm


pretrained model about EfficientNet

Where to download pretrained model about EfficientNet？ Thanks！

You can download the weights from: here


Support Windows machines

The generated file names are included symbols, that are not compatible with windows os.
Example crystalruby/crystalruby/src/generated/Stats::Csv::TopProducts includes :.

This should be fixed in 0.3.1 🙏


Clarify network port requirements

Doc says: Ensure that your VNET Network Security Group rules don't block the following communication ports 443, 53, 9354, 445, 12000
To where? The source database? The target? The Internet? What?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 9a49a982-613b-76a9-4a0a-7132d6058dcb
Version Independent ID: b2a280d2-ea2c-1836-f265-ccaa2c6758b3
Content: Tutorial: Use Azure Database Migration Service to migrate offline from SQL Server to a single/pooled database in Azure SQL Database
Content Source: articles/dms/tutorial-sql-server-to-azure-sql.md
Service: dms
GitHub Login: @HJToland3
Microsoft Alias: jtoland

@jtuliani - These should be enabled in the Azure portal, Network Security Group (NSG) rules. For more detail on Azure VNET NSG traffic filtering, see the article Filter network traffic with network security groups (https://docs.microsoft.com/azure/virtual-network/virtual-network-vnet-plan-design-arm).

@jtuliani If there are further questions regarding this matter, please comment and we will gladly continue the discussion.

@Mike-Ubezzi-MSFT Thanks. NSGs require me to specify the source and destination IP ranges. The issue here is it's not clear what those should be.

Thanks for the feedback! I have assigned the issue to the content author to evaluate and update as appropriate.

@jtuliani, re the original prerequisite (Ensure that your VNET Network Security Group rules don't block communication ports 443, 53, 9354, 445, 12000), the easiest way to accomplish this is to explicitly allow those ports access to the DMS resource in the NSG.

Thanks, that helps. It clarifies these are inbound ports to the DMS. @Mike-Ubezzi-MSFT - that's what needs to be added to the doc

@jtuliani, I have updated the prerequisites in all related tutorials to clarify that we are referring to inbound ports for DMS. Thank you!

#please-close

We will now proceed to close this thread. If there are further questions regarding this matter, please comment and we will gladly continue the discussion.

@HJToland3 Thanks for sharing the details.
The deployment issue has been resolved after adding an inbound rule for DMS
Rule Ref
Source: Subnet for DB server and DMS
Source Port range: *
Destination: Subnet for DB server and DMS [After deployment, value has been replaced with DMS local IP]
Destination port: 443, 53, 9354, 445, 12000
Protocol: Any

@HJToland3 Thanks for sharing the details.
The deployment issue has been resolved after adding an inbound rule for DMS
Rule Ref
Source: Subnet for DB server and DMS
Source Port range: *
Destination: Subnet for DB server and DMS [After deployment, value has been replaced with DMS local IP]
Destination port: 443, 53, 9354, 445, 12000
Protocol: Any