Support for emulators?

This would likely require manual (hard coded/specific) support per emulator, but a way to backup saves from emulators would be nice.
Some emulators have one folder and multiple files within it e.g. ppsspp has one folder with psp state and screenshot files, so you'd need to get a games id and match that to a game.
I think some form of profile system would be good, like how playnite has, where you have a list of profiles for different emulators, and all of the settings etc are stored within it (example, although the contents would be very different).

Alternatively, you could ask PCGW to include paths for emulators, they already cover them briefly here: https://www.pcgamingwiki.com/wiki/Emulation but that to cover might require more work on the wiki's side sadly. :(

This is possible with custom entries, but I don't think it's feasible to add default entries for it. There are several variables that make it difficult to support automatically:

Emulators can be installed in a custom location
Emulators can be configured to store saves in a custom location
Some systems store multiple games' saves in a single file (memory card)
Some emulators base the save file name on the ROM name, so if you wanted to match a game to its save file, you may have to know the game's file name

Now, if people started having some particularly popular custom entries and wanted an easier way to share/reuse them, then I could see adding support for extra manifests. But depending on your configuration, this could be as simple as just making a custom entry to back up a common C:/Emulators/Saves.

I think supporting external/shared manifests might be a good feature. Not exactly sure what that would look like though.
Yuzu (and RPCS3 I think) for instance has predictable save data paths based on a title ID. Personally, I've been automating this on my machine using a script that adds custom entries.
But I can see the benefit of a user defining their "Yuzu Root", referencing an external Yuzu Ludusavi manifest repo, and not having to worry about it again.

That sounds good. I've opened #95 to track that enhancement.


add environment variables to powershell profile

This adds all variables from load-omnibus-toolchain to the powershell $profile which allows one to build in a powershell environment and also avoids having to manually load the batch file

@delivery review

Failed to review change: 11983531-5c13-43a7-be54-c231236f4bef @schisamo


[5.8] Allow chaining on Query Builder dump() method.

This fixes a mistake in my previous PR to add this.
It currently isn't possible to chain onto the dump method.

You just forgot to update the docblock heh

@brunogaspar fixed.


run a model (e.g. padim) with export to onnx enabled

How do you convert the algorithm to onnx for model deployment?(e.g. Padim)

Since applying the OpenVINO optimization will generate an .onnx file you could this to your config:
optimization:
  openvino:
    apply: true

The ONNX file should be saved near your model weights folder.
I am creating a #509 PR to make this export more generic. You could also pull from top of main branch once it is merged.

The most recent up-to-date instructions for exporting a trained model can be found on this page in our documentation. I'm closing this issue now, but please feel free to re-open if you have any additional questions.

The most recent up-to-date instructions for exporting a trained model can be found on this page in our documentation. I'm closing this issue now, but please feel free to re-open if you have any additional questions.

Hello,
Great work you have done here.
I am trying to export a trained CFLOW model to onnx format, I don't want to retrain the model.
How can I achieve that ?
The posted link is dead,  and everything on the documentation suggests to re-train the model with the export flag enabled.
Also I want to use a different back-end, MobileNetV3_large for example.
What changes should I do?
I have spent several days on this, and I believe you can help.
Thanks in advance.


WIP Improvements to deploy scripts for ext. usage

WIP do not merge yet
This PR works in tandem with a demo application that uses zos and aims to simplify the usage of the deploy utilities residing here for the time being at deploy/.

@ajsantander lgtm, but I'd ask a review by @facuspagnuolo, who was working on something similar

This now also includes changes to truffle.js and package.json, so that this repo can be used to "emulate" a deployed zos version in development.


libtmux: 0.32.0 -> 0.35.0, tmuxp: 1.39.0 -> 1.43.0

Fixes: #297760.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 297803 at 603e0a09 run on x86_64-linux 1

4 packages built successfully:

arsenal
python311Packages.libtmux
python312Packages.libtmux
tmuxp


Bug Report: UserWarning occuring when running xgboost

Code to reproduce:
using following  version
xgb.version= 1.4.0
System: Ubuntu 20.04 LTS
import xgboost as xgb
from sklearn.metrics import mean_squared_error
import pandas as pd
import numpy as np
from sklearn.datasets import load_boston
boston = load_boston()
data = pd.DataFrame(boston.data)
data.columns = boston.feature_names
X, y = data.iloc[:,:-1],data.iloc[:,-1]
data_dmatrix = xgb.DMatrix(data=X,label=y)
xg_reg = xgb.XGBRegressor(objective ='reg:squarederror', colsample_bytree = 0.3, learning_rate = 0.1, max_depth = 5, alpha = 10, n_estimators = 10)
xg_reg.fit(X,y)
preds = xg_reg.predict(X)
rmse = np.sqrt(mean_squared_error(y, preds))
print("RMSE: %f" % (rmse))

Following warning is received:
~venv/lib64/python3.6/site-packages/xgboost/data.py:115: UserWarning: Use subset (sliced data) of np.ndarray is not recommended because it will generate extra copies and increase memory consumption
  "memory consumption")

This is expected behavior, since you are using a sliced array (data.iloc[:,:-1]) as an input to DMatrix. The program will work; just keep in mind that the array will be copied and load to increased memory usage.

Hey @sheecegardezi ,
Althought this issue is closed, I thought I would add that you can make the array contiguous with
X = np.ascontiguousarray(X)
Which will improve memory usage and avoid the warning.
Would you consider adding this fix for uncontiguous arrays to XGboost @hcho3?  I would like to do it if so. Thank you very much in advance.

Hey @sheecegardezi ,
Althought this issue is closed, I thought I would add that you can make the array contiguous with
X = np.ascontiguousarray(X)
Which will improve memory usage and avoid the warning.

Hi, it something to do with our data or a modification that XGBoost should do?


UP-4830:  Decompose sources in uportal-war into Gradle-based submodules (unit test sequel)

https://issues.jasig.org/browse/UP-4830
Checklist

[x] the individual contributor license agreement is signed
[x] commit message follows commit guidelines
[x] tests are included

Description of change

All sources in uportal-war/src/main/java have been previously moved (and merged).  This PR is for decomposing the unit tests to match.
Not all the tests, however, are moved in this delta.  Some of the existing unit tests are written in a way that makes it difficult to separate them from the complete portal configuration & runtime classpath.

Previous #860 #886 #897 #901 #904

@apetro I know I moved that file (and the same test is passing locally).  I suspect this issue stems from a shortsighted definition in .gitignore.

These are the (possibly over) specific custom that were brought into the new gitignore.
!uportal-portlets-overlay/CalendarPortlet/3rd-party/repository/org/osaf/caldav4j/0.7/*.jar
!uportal-portlets-overlay/CalendarPortlet/3rd-party/repository/slide/jakarta-slide-webdavlib/2.2pre1-httpclient-3.0/*.jar
!uportal-war/src/test/resources/org/apereo/portal/io/xml/import_archive.*
!uportal-war/src/test/resources/org/apereo/portal/utils/DirScannerData.zip

I suspect these two could be the culprits.
!uportal-war/src/test/resources/org/apereo/portal/io/xml/import_archive.*
!uportal-war/src/test/resources/org/apereo/portal/utils/DirScannerData.zip

IMHO we probably don't need a rule in .gitignore that ignores all .zip files in the entire project.
Probably no files in **/src/** should be ignored.

IMHO we probably don't need a rule in .gitignore that ignores all .zip files in the entire project

zip, jar, war, and ear files are artifacts. We really shouldn't being checking any artifacts into the source control management.

zip, jar, war, and ear files are artifacts.
We really shouldn't being checking any artifacts into the source control management.
If we need to bring one its okay, but it should be the exception, not the rule.

It already is the exception.  No one is suggesting that we start adding more of these files or change our opinion of when/where they should be added to the repo in any way.
The current configuration in .gitignore is error-prone.  We don't add these files under {module.name}/src/ except if we intend to add them.  We don't use any processes or human practices that would cause unwanted files to be in that location.

@apetro & @ChristianMurphy -- I added the parts I'm working on now (even though they are WIP) b/c @ChristianMurphy may be able to help me with LESS compilation, and he will need this stuff.

No one is suggesting that we start adding more of these files or change our opinion of when/where they should be added to the repo in any way.

:+1:

We don't add these files under {module.name}/src/ except if we intend to add them. We don't use any processes or human practices that would cause unwanted files to be in that location.

I'm less worried about human practices, and more worries about human mistakes.
Artifacts can get accidentally get moved to a src folder, I would prefer for that file to be only checked in if there is also an explicit exception added to the .gitignore.

For less work see https://github.com/drewwills/uPortal/pull/3

@ChristianMurphy, @bjagg, @apetro, @asgrant, @cousquer, @bpowell, et al...
This PR is ready to merge.  I will do so shortly (after lunch) barring new information.


[SPARKR][BACKPORT-2.1] backporting package and test changes

What changes were proposed in this pull request?
cherrypick or manually porting changes to 2.1
How was this patch tested?
Jenkins

Test build #81550 has started for PR 19165 at commit b53f812.

Test build #81550 has finished for PR 19165 at commit b53f812.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81550/
Test FAILed.

jenkins, retest this please

[info] All tests passed.
[info] Passed: Total 2002, Failed 0, Errors 0, Passed 2002, Ignored 592
[error] (core/test:test) sbt.TestsFailedException: Tests unsuccessful
[error] Total time: 5800 s, completed Sep 8, 2017 3:07:30 AM

Test build #81565 has started for PR 19165 at commit b53f812.

Test build #81565 has finished for PR 19165 at commit b53f812.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Test build #81572 has started for PR 19165 at commit bb6f326.

Test build #81572 has finished for PR 19165 at commit bb6f326.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81572/
Test FAILed.

Test build #81595 has started for PR 19165 at commit 7ded0ae.

Test build #81595 has finished for PR 19165 at commit 7ded0ae.

This patch fails SparkR unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81595/
Test FAILed.

Test build #81600 has started for PR 19165 at commit 9d53891.

Test build #81600 has finished for PR 19165 at commit 9d53891.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81600/
Test PASSed.

merged to 2.1


[Sema] Relative line numbers in test expectations

No functional change, just uses relative line numbers in expected warnings so that there aren't diffs here every time line numbers change in the rest of this (long) test file.

@swift-ci Please smoke test


PR#137 - Handle config changes on docker updates

https://github.com/mcuadros/ofelia/pull/137

So much time has passed on this that this pull request will no longer work with the most recent version of Ofelia.
I'm not terribly proficient at Golang so this may be a bit of a challenge to get re-integrated into Chadburn, my fork. Seems like Ofelia project stalled when it comes to critical fixes.


devpi-client: add missing input, switch to pytestCheckHook

Motivation for this change
Fix build (https://hydra.nixos.org/build/167846556)
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 162614 run on x86_64-linux 1

1 package built:

devpi-client

@ofborg eval


Android SDK file not found after upgrading to Android Studio 4.0

After upgrading to AS 4.0, this is the output of flutter doctor -v:
[✓] Flutter (Channel master, 1.19.0-2.0.pre.193, on Microsoft Windows [VersiÃ³n 10.0.19041.264], locale es-ES)
    • Flutter version 1.19.0-2.0.pre.193 at C:\src\flutter
    • Framework revision fed18fc433 (85 minutes ago), 2020-05-29 03:43:01 -0400
    • Engine revision 17737e6fd4
    • Dart version 2.9.0 (build 2.9.0-11.0.dev 6489a0c68d)

[!] Android toolchain - develop for Android devices (Android SDK version 29.0.3)
    • Android SDK at C:\Users\crist\AppData\Local\Android\sdk
    • Platform android-29, build-tools 29.0.3
    ✗ Android SDK file not found: C:\Users\crist\AppData\Local\Android\sdk\platforms\android-29\android.jar.
    • Try re-installing or updating your Android SDK,
      visit https://flutter.dev/docs/get-started/install/windows#android-setup for detailed instructions.

[✓] Chrome - develop for the web
    • Chrome at C:\Program Files (x86)\Google\Chrome\Application\chrome.exe

[✓] Android Studio (version 4.0)
    • Android Studio at C:\Program Files\Android\Android Studio
    • Flutter plugin version 46.0.4-dev.7
    • Dart plugin version 193.7361
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)

[✓] Connected device (2 available)
    • Web Server • web-server • web-javascript • Flutter Tools
    • Chrome     • chrome     • web-javascript • Google Chrome 83.0.4103.61

! Doctor found issues in 1 category.

The part where it says;
    ✗ Android SDK file not found: C:\Users\crist\AppData\Local\Android\sdk\platforms\android-29\android.jar.
    • Try re-installing or updating your Android SDK,
      visit https://flutter.dev/docs/get-started/install/windows#android-setup for detailed instructions.

My Android SDK wasn't changed, but that file it's looking for right now no longer exists. This is the outpud of dir on platform-29 directory:
28/05/2020  20:57    <DIR>          .
28/05/2020  20:57    <DIR>          ..
28/05/2020  20:57    <DIR>          data
28/05/2020  20:57            30.605 framework.aidl
28/05/2020  20:57            17.835 package.xml
28/05/2020  20:57               209 sdk.properties
28/05/2020  20:57    <DIR>          skins

Screenshots of Android SDK Manager:

Hi @Zazo032
I see there's an open issue addressing the case you described.
Please follow up on that issue, I'm closing the current one as duplicate.
If you disagree, please write in the comments and I will reopen it.
Thank you

Hi @iapicca
This is not about Flutter's Android Studio plugin support, as you can see here: https://github.com/flutter/flutter-intellij/issues/4581#issuecomment-635866705
it's a false alarm, after upgrading to 4.0, the IDE will suggest you compatible versions of the plugins. This is about the flutter tool support, seems to be looking for a file that no longer exists.

@iapicca @TahaTesser https://github.com/flutter/flutter-intellij/issues/4581#issuecomment-635933675


Support native ttl

@pi0 Any progress here?

for Redis, this could be addressed by #150

Thinking more about the generic TTL idea, the new transaction options feature (https://github.com/unjs/unstorage/pull/168) can allow any driver to implement it per setItem call in their native way.
Also drivers can globally support ttl. For memory, you can use LRU Driver instead with ttl option.


DeprecationWarning: The argument dtypes for read_csv is deprecated.

site-packages\gtfparse\read_gtf.py:106: DeprecationWarning: The argument `dtypes` for `read_csv` is deprecated. It has been renamed to `schema_overrides`.
    df = polars.read_csv(

https://github.com/openvax/gtfparse/blob/149990478ba4ce90064aaf90537eaf4291f71838/gtfparse/read_gtf.py#L99-L109

#51 should fix this.


Helm Version 0.4.2 doesn't print Postgres or Redis env vars into deployment.

Describe the issue
Recently updated to version 0.4.2 and deployed. I noticed that the app wasn't working to I inspected the rendered yaml and noticed none of the postgres or redis env vars were in there. Despite the relevant section of my values file looking like this:
postgresql:
  enabled: false
  postgresqlHost: // removed for issue
  postgresqlUsername: "postgres"
  postgresqlDatabase: "weblate"

redis:
  enabled: false
  password: "" // My redis instance has no password
  redisHost: // removed for issue

The issue is clearly this commit: https://github.com/WeblateOrg/helm/commit/b1aa48d5c5ec3f49648af7bc714e72825399c48b
But the docs contradict this commit by saying

External postgres database endpoint, to be used if postgresql.enabled == false

and

External redis database endpoint, to be used if redis.enabled == false

Seems like there was a miscommunication as to what enabled means. Perhaps renaming that configuration key from enabled to external to make things more clear?
Workaround
just append --version 0.4.1 to your helm command.

Seems like https://github.com/WeblateOrg/helm/issues/121


add GeoAdmin provider

This adds the GeoAdmin provider for geocoding in Switzerland. It's my first contribution to anything - so feedback is welcome.

Hi, thanks for the PR! I note that you're proposing both an API change, and a new provider. Please split this PR so we can review and discuss the merits of the API change separately (fwiw, I don't think returning a Result<Option> is necessarily a problem or something we're opposed to)

sorry for not reviewing this sooner! your changes looked good to me, if you reopen i can merge it for you 👋

@frewsxcv no problem! working on this i realised that regional geocoding providers probably need some further attention. the main unresolved issues i encountered are local coordinate systems. how should this be addressed?

@b4l Can you say a little more about how the local coordinates are used? Either way, we can enable conversion between EPSG4326 and local coordinate systems using https://github.com/georust/proj, although that requires the user to have a recent  (6.0.0) PROJ installation on their system.

@urschrei The geoadmin provider uses EPSG:2056 or its predecessor internally. Reverse geocoding requests only accept these CRS.  The responses have additionally WGS84 coordinate as well.
Providing a convenient and consistent WGS84 interface comes with the dependency tradeoff in this case. I am not sure how i fell about this.

Ahh, OK. You could implement it without conversion, and document the requirement for EPSG:2065 coordinates when reverse-geocoding, along with a bounding-box check (it's not perfect, but it's cheap and not a bad trade-off), or we could go with proj, putting the GeoAdmin provider behind a feature flag.

Yes, both ok. Maybe the first solution is to prefer at the moment for maintainability and let the users do conversion if needed.

👍


Document the None case for ::rotation_between

The current documentation of ::rotation_between should explain in what cases it returns None, and what to do in those cases.

If I found the correct ::rotation_between (the ones in src/geometry/quaternion_construction.rs and src/geometry/rotation_specialization.rs), these functions are implemented via their respective scaled_rotation_between and return None, if the two vectors / quaternions / ... point in (within rounding error) opposite directions.
In those regions, the scaled_rotation_between becomes very unstable (i.e. undefined in the presence of rounding error) if the scale isn't an even integer, so it makes sense to return None.
The caller can either avoid this case entirely (if possible) or handle the None in whatever way they would handle vectors pointing in opposite directions.


fix:use reentrantLock instead of spinlock

Ⅰ. Describe what this PR did
I'm sorry that I used spinLock in the wrong way before. The advantage of spinLock is that there is no need for thread context switch, but locksupport.park caused thread switch.
And SpinLock is good for locking parts to execute quickly, but we have IO operations in our changeStatus which is locking part, so to prevent CPU waste, I think ReentrantLock is more appropriate.
SpinLock can be seen as doing CAS all the time.The ReentrantLock  lock the first time is CAS then it will be parked.
Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews

Codecov Report

Merging #987 into develop will decrease coverage by 0.01%.
The diff coverage is 66.66%.

@@              Coverage Diff              @@
##             develop     #987      +/-   ##
=============================================
- Coverage      38.34%   38.32%   -0.02%
  Complexity      1046     1046
=============================================
  Files            219      219
  Lines           8714     8708       -6
  Branches        1085     1082       -3
=============================================
- Hits            3341     3337       -4
  Misses          4951     4951
+ Partials         422      420       -2

Impacted Files
Coverage Δ
Complexity Δ

...in/java/io/seata/server/session/GlobalSession.java
80.68% <66.66%> (+0.46%)
50 <3> (ø)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43fb0d3...33ca7a3. Read the comment docs.


Statically usable literals

Currently, once you create a UInt literal, you can't get the literal back out. For RTL construction purposes, this isn't much of a issue (since you don't usually need it back), but because Chisel's literal from string constructor supports more radix types than base Scala (notably, binary), it helps to be able to use the same syntax for example when writing testvectors.
One possible proposal is for UIntLit to extend UInt, where UIntLit has an additional method to get the value. UIntLit would be returned by all literal constructors.

Chisel2 had isLit and litOf methods defined on Data (or maybe Bits?). The API wasn't ideal, but the feature was a useful feature from time to time.  It was also even useful for RTL, as sometimes an implementation can be improved on the basis of constness. It's the same rationale behind gcc offering __builtin_constant_p.

For constructing binary and hexadecimal numbers succinctly, you can just have a StringContext for them, e.g.: h"abcd" or b"1111" that returns a BigInt.
Similarly, you could add an inspection function to see if some UInt or SInt is currently bound to being a literal. (It is really odd how Data currently has the literal methods.)

So the StringContext is a method, as would be PML on strings (i.e. "1111".b), but Chisel needs a standardized way to do this on tests, otherwise everyone else is going to write their own and it's going to be a giant mess. I think the most intuitive API would allow these to be specified the same way as Chisel literals (where we can do like "b111".U). Considering that bundle literals are also a desired feature, it should interoperate with that too, when (if?) it happens.

No, you should actually read the documentation: http://www.scala-lang.org/api/2.12.0/scala/StringContext.html

I know how StringContext works (b"1111"). PML ("1111".b) was another way that's been commonly suggested. Yes, they're different (I assume this is what you mean).
For the purposes of this discussion, what I want to resolve is standardizing literal specification in a way that's accessible for a testbench, and in a way that would both be consistent with these literals can currently be specified ("b1111".U) as well as potentially upcoming features (like Bundle literals).

The UIntLit is somewhat problematic because you will be unable to define a proper cloneType method for it. Path dependent types like this.type are checked by scala but the JVM will still require UIntLit.cloneType return a UIntLit. However, the contract of cloneType requires that return item be bindable to anything so Reg(init = 0.U) will rapidly result in a UIntLit representing a register.
I don't understand the target scenario. It seems odd that you would start with a scala numeral, transform it into a Chisel literal, and then want the scala numeral back (but have no way of structuring the code that you can retain both).
In general, I think it is an odd (likely bad design) to start with a scala numeral, transform it into a Chisel literal, and then want the scala numeral back. If a testbench needs (and knows it will need) as both scala numeral like BigInt, Int, etc. (e.g for functional modelling) and Chisel literal, then it should generate, store, and manipulate scala numerals right up until it has to inject the value into the Chisel dut (done via a literal creation).
A UInt => BigInt function because it makes a false promise. (Even UInt => Option[BigInt] will end up being None a bit too often.) I think it would be a bad idea to make it too easy for users to expect a BigInt to be extractable from something of type 'UInt'. (All it takes is one designer writing testbench having a helper function that takes a literal UInt and another designing expecting to be able to pass anything there. Further, this would expose a major (somewhat implementation-particulars difference) between storing your data in Seq(0.U, 1.U, 2.U) and Vec(0.U, 1.U, 2.U) and then doing a static lookup.
There are a few rare times it may be exceptionally convenient to try to extract a scala numeral from a Chisel.UInt (like from an enumeration). Even then, it is rarer that you want to actually treat the enumeration numerically.
Thus, making it a reflection-style function (so isolated in its own subpackage with a name reinforcing its volatile nature) should help prevent the user from considering it part of the core API to be used extensively. In fact, we used to have a handful of testbenches that needed this function (although at the time I just used litValue defined on Data) but, after a few rounds of refactoring and cleanup, we were able to remove their use completely.

Yeah, Scala value -> Chisel lit -> Scala value obviously sounds pretty awful in the case of numbers, though if we have Bundle literal constructors it's less clear how that should be handled (separate method call for literals? perhaps defaulting construction to Scala-land values, with a .toLit or something to create a Chisel-land literal object? perhaps two constructor signatures, one accepting Chisel-land types and another accepting Scala-land types?).
I was hoping for UIntLit, though I see the issue with cloneType now. I also remember that there was a discussion a while ago about this.type being bad practice, though I don't think there was a good resolution. F-bounded polymorphism seems like it would allow better control over cloneType, though it incurs a pretty nasty syntax cost for Bundles.
I also agree that UInt => BigInt is a bad idea.
I'd still like thoughts on a literal specifier for Scala-land values that has syntax consistent with Chisel literal specifiers. Perhaps something like "b1111".L (which returns a BigInt, but shares parsing logic with .U and friends)? Though reserving .L might be too limiting of the future? Or perhaps ~removing~ deprecating the PML string literal constructor and restructuring it as a chain of StringContext and literal conversion (like b"1111".U)?
I think we can also do a better job of enums (#373), rather than just having them return Chisel types. One option may be to have enum values be objects that have methods to get as either a BigInt or Chisel literal.

I think it's time we made another push for this, while simultaneously considering implications for #418 Bundle literals and #373 Enums.
Considering integer literal types alone, either StringContext (u"0b111") or PML ("0b111".L) are clean and safe - it's just a discussion about style (which is still very important). The overall philosophy would be "construct literal types in Scala-land, and do a cast to Chisel-land", much like how you start with 2, then do a .U conversion to turn it into a UInt literal.
A similar philosophy may work with Enums, where they could be used as Scala-land integers and converted to Chisel-land through a .U conversion. The main benefits from using a custom Chisel Enum type would be ability to propagate value names down to Verilog (future feature as this isn't yet supported anywhere in the Chisel stack) and consistent bitwidths of all values in the same Enum. What I would like to see would be (though I don't yet know if the type system / syntax will support it):
object MyState extends ChiselEnum
object MyStateIdle extends MyState.Value(0)
object MyStateRunning extends MyState.Value(1)

in RTL:
val currState = Reg(MyState.asType)
currState := MyStateIdle.U

in test:
poke(currState, MyStateIdle)

However, where this would get hairy would be how to make it type-safe (allowing APIs that are more specific than any ol' UInt) and perhaps how to separate Scala-land and Chisel-land types (since we're only declaring a single Chisel-land ChiselEnum type). If more types need to be declared, macro metaprogramming may be part of the solution to eliminate the need to write repeated boilerplate.
A similar problem would come up with Bundle constructors. Macro metaprogramming would make it possible to automatically generate a companion object and literal constructor for Bundle types, but the problem is that Bundle types are Chisel types rather than Scala types. For example this:
@bundle
class MyInnerBundle extends Bundle {
  val a = UInt(2.W)
  val b = UInt(4.W)
}
@bundle
class MyBundle extends Bundle {
  val a = UInt(6.W)
  val z = new MyInnerBundle()
}

would expand with companion object constructors with signatures:
MyInnerBundle(a: UInt, b: UInt) -> MyInnerBundle
MyBundle(a: UInt, z: MyInnerBundle) -> MyBundle

side note: it's almost always undesirable to construct a Bundle literal in both directions, so more thought about that is needed; the example above sidesteps it as a undirectioned bundle
but the problem is that since it takes a UInt, it will not be safe to turn those back into Scala-land types for use in testing. One possible nasty solution is to understand the Scala-land / Chisel-land mapping and automatically generate literal constructors instead:
MyInnerBundle(a: BigInt, b: BigInt) -> MyInnerBundleLit
MyBundle(a: BigInt, z: MyInnerBundleLit) -> MyBundleLit

but this is probably really, really brittle and doesn't extend / compose well (this function would need to be kept up-to-date with all Data subtypes). It's also generating a different MyBundleLit type in the background, which could confuse people trying to debug code ("where did this class come from and why can't I find it in my source?").
The problem with both Bundle and Enum literals seem similar (Scala-land and Chisel-land data types without requiring user boilerplate and in a type-safe manner) and a good solution will probably apply across both.
I think that in the larger picture, we need a Chisel-land data type, but don't necessarily need a Scala-land data type (for instance, if given guarantees, preferably statically checked, that a Chisel-land data type could be turned into a integer, it wouldn't be terrible API design to take a UInt in a test function) - though the problem with this path is how to get those guarantees.

My vote is "0b111".U to get UIntLiteral(7), and "0b111".S to get SIntLiteral(-1). This seems the most similar to the existing mechanism.
Re: the enum proposal - I can't think of any way to test whether a returned value value is 0, or MyStateIdle, unless types propagate to Firrtl.
Re: literal bundles - I have a feeling that adding an @bundle macro is probably a bad idea from a usability perspective. If people forget it, we get a crazy error. In contrast, we could have a dynamically-checked constructor that takes a map. Though not statically checked, we could through a very clear error message, and have more context into what the user was intending to do.

We can table the discussions of what a Enum constructor could do, but the resolution to the literal specifications will restrict the range of (philosophically consistent, at least) solutions for Enums literals and Bundle literals. Which is why I'd like to have a resolution that makes everything possible, even if we don't decide on the exact semantics and implementation of those yet.
For Enums, one immediate gain would be type safety, for example assigning a general UInt to a Enum wire would error out.
I don't particularly like dynamic Map-based Bundle literal constructors, both because the type signature isn't meaningful (a good IDE should be able to tell you exactly what the fields are for a macro-based version; whereas a generic Map is meaningless) and there's clunky map syntax (as opposed to named arguments). I'm on the fence about the macro doing too much behind the scenes, though it's arguable that there's precedent with case classes that automatically generate a constructor companion object for you.

Also, see Stephen's post above about why UIntLiteral (as a separate class, which both extends UInt but also gives literal conversion guarantees) would be problematic (mostly that all Data-derived subtypes define cloneType that returns its own type, so UIntLiteral cloneType must return UIntLiteral, which is not generally useful). There may be ways around that that are worth discussing (for example, can UIntLiteral be made not a subtype of UInt while still supporting the use cases we care about?).
In response to @sdtwigg 's comment about Scala value -> Chisel lit -> Scala value sounding bad, one possibility is to redefine the testing APIs to take Chisel lits rather than Scala lits (so you avoid that last conversion, at least as far as the user is concerned)

One thing to note is that stuff like b"1111" or h"ffff" (returning UInt) will end up syntax highlighting nicely (where just the literal part is red rather than the radix selector).

Random thought for statically usable literals:
What about replacing Data.cloneType: this.type with object cloneType and def apply[T <: Data](toClone: T): T = .... Then, a DataLiteral (or something) could be mixed in to a UInt and provide some conversion function (like toBigIntBits) on the literal (or not, even just marking it as a literal would be fine). This should provide a correct return type (similarly to how Wire(...) and Reg(...) work; unlike this.type which isn't strictly correct) and a correct API.
Internally, it would call Data.cloneType: Data (and let's be blunt, we're throwing around .asInstanceOf[this.type] everywhere and losing type-checker guarantees anyways).
Of course, there would need to be some interop (so we may leave Data.cloneType: this.type alone, define a new Data.newCloneType: Data and have the default implementation delegate to the old one so old code still compiles). If may also be possible to add some syntactic sugar (for example, implicit conversions that give the illusion of Data.cloneType (and you'll never chain an apply after a non-synthesizable node anyways) but properly type-parameterized.
@sdtwigg ?

^^ this implementation strategy for typeclassed cloneType was in #193

Superseded by #777


timer trigger failed with "panic: interface conversion: interface {} is nil, not string"

I exported project from flogo docker UI with timer (repeating=false) and log message(msg=hello world~~~~) as below(flogo.json) and execution failed with "panic: interface conversion: interface {} is nil, not string" in both Windows and Centos 7.
===== flogo.json ====
{
"name": "runonce",
"type": "flogo:app",
"version": "0.0.1",
"description": "",
"triggers": [
{
"name": "Timer",
"ref": "github.com/TIBCOSoftware/flogo-contrib/trigger/timer",
"description": "Simple Timer trigger",
"settings": {},
"id": "timer",
"handlers": [
{
"settings": {
"repeating": "false",
"notImmediate": null,
"startDate": null,
"hours": null,
"minutes": null,
"seconds": null
},
"actionId": "flow_1"
}
]
}
],
"actions": [
{
"name": "flow1",
"data": {
"flow": {
"type": 1,
"attributes": [],
"rootTask": {
"id": 1,
"type": 1,
"tasks": [
{
"id": 2,
"name": "Log Message",
"description": "Simple Log Activity",
"type": 1,
"activityType": "tibco-log",
"activityRef": "github.com/TIBCOSoftware/flogo-contrib/activity/log",
"attributes": [
{
"name": "message",
"value": "hello world ~~~~",
"required": false,
"type": "string"
},
{
"name": "flowInfo",
"value": "false",
"required": false,
"type": "boolean"
},
{
"name": "addToFlow",
"value": "false",
"required": false,
"type": "boolean"
}
]
}
],
"links": [],
"attributes": []
}
}
},
"id": "flow_1",
"ref": "github.com/TIBCOSoftware/flogo-contrib/action/flow"
}
]
}
==== error msg ===
D:\dev\go\src\github.com\lwlwlwlw\flogo-project\runonce\bin>runonce.exe
2017-10-23 19:37:24.178 DEBUG  [engine] - Registering action factory: 'github.com/TIBCOSoftware/flogo-contrib/action/flow'
2017-10-23 19:37:24.190 DEBUG  [engine] - Registering activity: 'github.com/TIBCOSoftware/flogo-contrib/activity/log'
2017-10-23 19:37:24.191 DEBUG  [engine] - Registering trigger factory: 'github.com/TIBCOSoftware/flogo-contrib/trigger/timer'
2017-10-23 19:37:24.192 INFO   [engine] - Engine: Starting...
2017/10/23 19:37:24 In init, id: 'timer', Metadata: '&{ID:github.com/TIBCOSoftware/flogo-contrib/trigger/timer Handler:0xc0420c0d20 Settings:map[] Output:map[params:0xc04206f950 content:0xc04206f9b0] Reply:map[]}', Config: '&{Name:Timer Id:timer Ref:github.com/TIBCOSoftware/flogo-contrib/trigger/timer Settings:map[] Output:map[] Handlers:[0xc042102090] Outputs:map[]}'
2017-10-23 19:37:24.193 DEBUG  [engine] - Uncompressed flow with id 'flow_1' added
2017-10-23 19:37:24.194 DEBUG  [engine] - ActionRunner Service: Starting...
2017-10-23 19:37:24.194 DEBUG  [engine] - Starting worker with id '1'
2017-10-23 19:37:24.194 DEBUG  [engine] - Starting worker with id '2'
2017-10-23 19:37:24.194 DEBUG  [engine] - Starting worker with id '3'
2017-10-23 19:37:24.195 DEBUG  [engine] - Starting worker with id '4'
2017-10-23 19:37:24.195 DEBUG  [engine] - Starting worker with id '5'
2017-10-23 19:37:24.195 DEBUG  [engine] - ActionRunner Service: Started
2017-10-23 19:37:24.196 INFO   [engine] - Engine: Starting Services...
2017-10-23 19:37:24.196 INFO   [engine] - Engine: Started Services
2017-10-23 19:37:24.196 DEBUG  [engine] - Trigger [ 'timer' ]: Starting...
2017/10/23 19:37:24 Start
2017/10/23 19:37:24 Processing handlers
2017/10/23 19:37:24 Repeating:  false
2017/10/23 19:37:24 Scheduling a run one time job
panic: interface conversion: interface {} is nil, not string
goroutine 1 [running]:
github.com/TIBCOSoftware/flogo-lib/core/trigger.(*HandlerConfig).GetSetting(...)
D:/dev/go/src/github.com/lwlwlwlw/flogo-project/runonce/vendor/src/github.com/TIBCOSoftware/flogo-lib/core/trigger/config.go:115
github.com/TIBCOSoftware/flogo-contrib/trigger/timer.getInitialStartInSeconds(0xc042102090, 0xc0420314a0)
D:/dev/go/src/github.com/lwlwlwlw/flogo-project/runonce/vendor/src/github.com/TIBCOSoftware/flogo-contrib/trigger/timer/timer.go:176 +0x122d
github.com/TIBCOSoftware/flogo-contrib/trigger/timer.(*TimerTrigger).scheduleOnce(0xc0421103c0, 0xc042102090)
D:/dev/go/src/github.com/lwlwlwlw/flogo-project/runonce/vendor/src/github.com/TIBCOSoftware/flogo-contrib/trigger/timer/timer.go:97 +0xac
github.com/TIBCOSoftware/flogo-contrib/trigger/timer.(*TimerTrigger).Start(0xc0421103c0, 0xf, 0xc0420313b0)
D:/dev/go/src/github.com/lwlwlwlw/flogo-project/runonce/vendor/src/github.com/TIBCOSoftware/flogo-contrib/trigger/timer/timer.go:65 +0x5a6
github.com/TIBCOSoftware/flogo-lib/util.StartManaged(0xc0420deec0, 0x13, 0x36a8680, 0xc0421103c0, 0xc0421103c0, 0xc0420deec0)
D:/dev/go/src/github.com/lwlwlwlw/flogo-project/runonce/vendor/src/github.com/TIBCOSoftware/flogo-lib/util/managed.go:62 +0xf6
github.com/TIBCOSoftware/flogo-lib/engine.(*EngineConfig).Start(0xc04206c550, 0xa1c380, 0xc04206c550)
D:/dev/go/src/github.com/lwlwlwlw/flogo-project/runonce/vendor/src/github.com/TIBCOSoftware/flogo-lib/engine/engine.go:143 +0x419
main.main()
D:/dev/go/src/github.com/lwlwlwlw/flogo-project/runonce/src/runonce/main.go:37 +0xac

You should probably open an issue here as there is where the Timer trigger is hosted.

I have created an issue in flogo-contrib:#137.  It should now handle a nil startDate (which will be interpreted as start immediately).  I have created a pull request for this as well.

Thank you for your help!
Glad to know this is fixed. And I will open issue in the right place.

fixed in TIBCOSoftware/flogo-contrib#137


Button group style inconsistent?

Description
I just noticed that the selection and geounit button groups have slightly different amounts of spacing between them. @alexelash do you know if this is intentional?

@jfrankl It's a mix of intentional and not intentional—we had briefly talked about this way back. I had hoped to make them like the demo, but was having trouble styling the first and last button like end caps so I kept spacing between them.  Maybe we had crossed wires, but either way I forgot to follow up on it so I'm glad you're bringing it up.
Long and short is: it'd be better if they were the same.

@alexelash thanks for the reply. That all makes sense. I'll assign this to myself and see if I can remove the spacing.


private key not found

When running script i keep getting private key not found.
I edited the .env file and included private key from secondary phantom wallet.
also converted private key to base 58 format and still get same error msg [22:59:01.574] error: private_key is not set
Thanks again!
Sully

Did you change the name of .env.copy to .env?


Add LoRA as efficient finetuning strategy

Added the option to apply LoRA (https://arxiv.org/pdf/2106.09685.pdf) to Huggingface text model as an additional option for efficient fine-tuning, see PR #1666. New PR based on #1780 for easier merge. Code is largely based on https://github.com/microsoft/LoRA/blob/main/loralib/layers.py

Added flag to optimizer optimization.efficient_finetuned: lora, lora_bias and lora_norm. The first fine-tunes only loRA weights, the second updates both LoRA weights and all biases of the transformer (LoRA + bit_fit), and the third updates LoRA, all biases and normalization terms (LoRA + norm_fit).
LoRA uses three hyperparameters. These are also set through optimization config. While Lora r and alpha are quite robust and likely do not need much tuning, the filter parameter restricts which linear layers LoRA should be injected into. The original paper indicates that Query and Value attention weights work best so this is set as the default for now. Depending on use we might need to consider a more sophisticated filter algorithm, e.g. using regular expressions.
Currently, when saving the model the entire model is stored, which is unnecessary. TODO: Need to change to solely save fine-tuned weights, also applies to bit_fit and norm_fit.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Let me edit the file to see if the CI will pass.

Really appreciate the contribution!!!
We can change the saving logic in a later PR. If the CI passes, the PR looks good to me. Some remaining items:

Profiling on text backbone other than mdeberta, e.g., roberta, electra, etc
Change the saving logic to solely save fine-tuned weights, also applies to bit_fit and norm_fit.

Job PR-1809-6 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-1809/6/index.html

Job PR-1809-7 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-1809/7/index.html


Make pipeline inference tests more focused

This PR rationalises the tests in the pipeline to make it easier to identify the error in the forecast step.
Closes #474
From this branch
 function make_inference(pipeline)
        truthdata_dg_task = do_truthdata(pipeline)
        truthdata = fetch.(truthdata_dg_task)
        do_inference(truthdata[1], pipeline)
    end

        pipeline = SmoothOutbreakPipeline(; ndraws = 20, nchains = 1, testmode = true)
        inference_results_tsk = make_inference(pipeline)
        inference_results = fetch.(inference_results_tsk)

inference_results[1]["forecast_results"]
#InexactError(:Int64, Int64,<PHONE_NUMBER>3999718400)

Which focuses the issue towards wild sampling (probably due to very badly specified priors).

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 90.02%. Comparing base (f93efeb) to head (b47309e).

Additional details and impacted files
@@                                        Coverage Diff                                        @@
##           404-upgrade-the-testmode-pipeline-script-to-just-pipeline-script     #475   +/-   ##
=================================================================================================
  Coverage                                                             90.02%   90.02%
=================================================================================================
  Files                                                                    57       57
  Lines                                                                   742      742
=================================================================================================
  Hits                                                                    668      668
  Misses                                                                   74       74

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


LICENSE: Copyright Owner and Year Missing

https://github.com/oss-review-toolkit/ort/blob/main/LICENSE#L189
License still contains place holders of original template for copyright owner and year.
I was instructed by a legal council once, that templates are not always valid in every jurisdictions.
I am not a lawyer and this is not legal advice. This is just an observation that the copyright does not look right to me.

License still contains place holders of original template for copyright owner and year.

Yes, that's on purpose. We use the original Apache-2.0 license text, as-is including the instructions how to apply the license.

I was instructed by a legal council once, that templates are not always valid in every jurisdictions.

Note that the template from the appendix is not supposed to apply to ORT itself.

This is just an observation that the copyright does not look right to me.

The actual copyrights for ORT are contained in the NOTICE file.


surah page layout breakdown fixed.

This pr closes issue-499.
Small screen:

Medium screen:

Large screen:

Deployed to: http://staging.quran.com:32951


fix #1075

I have a bad feeling about dryRun; it adds edge cases and nontrivial technical debt. But the only alternative I can see is duplicating a lot of the SetNick logic into a ValidateNick function.


refactor(simplifier): many fixes, extensions, and tests

This pull request contains dozens of minor fixes to the simplifier, new support for n-ary associative operators, new macros for encapsulating proofs, and hooks for theory solvers to be plugged in. Note: eq is always used by default, and propext is assumed throughout. All macros are given high enough trust level that they are always unfolded, except for the propositional theory module for which expansion has not been implemented yet. Reason: the necessary lemmas are only in the library for iff, and it didn't seem worth proving the propext versions until we settled on actually using propext. It is still fairly easy to revert to iff.
I am switching projects today, and I think that even if the simplifier gets extensively refactored again it is still better to merge this PR and start from here.
Issues:

I am not sure the point of LEAN_BELIEVER_TRUST_LEVEL. The result of those checks in unfold_macros.cpp was that untrusted macros were not expanded before giving them to the kernel, and then the kernel would fail because of the macros. I simplify removed the checks.

Outstanding items:

Expanding the prop-simplifier macro.
Better canonization of subsingletons (see https://github.com/dselsam/lean/blob/simp_refactor/tests/lean/run/simplifier_canonize_subsingletons.lean#L71-L80).

The use of propext is still bugging me, and not just because some things will no longer compute. Users will want to prove iff theorems and tag them as [simp], but these would be ignored when simp is called with eq as it would be by default. The user would need to prove the propext version of the theorem as well or instead.
Right now the only impediment to removing propext is tracking the ability to flatten an n-ary application, which requires an equivalence relation, an associativity lemma for the operator over that relation, and a congr_arg lemma for that relation/op combination. We want and and or to be flattened.
The fully general solution is to deal with all of using type classes that take or store all of the necessary facts:
structure equiv_relation [class] {A : Type} (rel : A → A → Prop) :=
(refl : ∀ x, rel x x)
(symm : ∀ x y, rel x y → rel y x)
(trans : ∀ x y z, rel x y → rel y z → rel x z)

structure is_associative [class] {A : Type} (rel : A -> A -> Prop)
                                                  [equiv_relation rel]
                                                  (op : A -> A -> A) :=
(congr : forall x y z, rel y z -> rel (op x y) (op x z))
(assoc : forall x y z, rel (op (op x y) z) (op x (op y z)))

The only concern here is performance for the common cases. An intermediate solution is to have one is_associative for eq that only takes assoc, and one for iff that takes assoc and congr_arg, that users rarely need to consider.


Pparrot mittal tang dcache clockgate

clock gating dcache's data_mem, stat_mem, tag_mem

Good changes!
Do you have the PPA analysis? In terms of the change, I suggest refactoring it a little:
Add a bsg_clkgate to bsg_ip_cores/misc.
Modify the bsg rams to include a clkgate_p parameter whose default is 0.
Based on this, you can use a generate statement to instantiate inside the ram module the bsg_clkgate.
Then just invoke .clkgate(1) as a parameter to the rams. The benefit of this approach is 1) code can easily be adapted to use the clock gating cell if it is available in the standard cell library, and 2) you make it easy for others to enable clock gating in other rams.

Per discussion, closing so that somebody may push the desired change.


Saving items to Notion... TypeError

Describe the issue
A clear and concise description of what the issue is.
My folder is as follows

and My Notero setting is

When I drag file into a folder, the following error occurs.

To Reproduce
Steps to reproduce the behavior:

Zotero in Chinese version
same procedure as README.md
In the step 4. Add or update items in your collections., this error occurs.

Expected behavior
A clear and concise description of what you expected to happen.
No error occurs and files are synchronized in Notion.
Screenshots
If applicable, add screenshots to help explain your problem.

Nothing in Notion.

Additional context
Add any other context about the problem here.

Ok, I have solve the problem. It's my fault when copying the Internal Integration Token.

··················· here will not be changed to the secret token automatically in Zoreto. So I have to show the secrect token and then copy the real token, like secret_...


Consistent retries over the time

Coverage increased (+0.6%) to 41.429% when pulling 6b7e9cd495be57c0242d1e58b364fbfc000bac32 on next into bb4659e00ca8717a7690929f0beb426afd5a502f on master.


pidgin does not find icon for SIPE plugin

I'm not sure whether this is a pidgin or pidgin-sipe (the plugin) issue, but the result is no icon.
I see in the log that pidgin-sipe looks for its icon in pidgin directory:
$ pidgin -d
...
(15:51:57) gtkutils: gdk_pixbuf_new_from_file() returned nothing for file /nix/store/adb6bqnpnyb4crb8wl2ibq0sywmgfnp5-pidgin-2.10.11/share/pixmaps/pidgin/protocols/16/sipe.png: Failed to open file '/nix/store/adb6bqnpnyb4crb8wl2ibq0sywmgfnp5-pidgin-2.10.11/share/pixmaps/pidgin/protocols/16/sipe.png': No such file or directory

sipe.png is found in pidgin-sipe output:
$ find /nix/store/1i0mdncw7a34jp23hifmvcdk5kk4dimj-pidgin-sipe-1.18.1 -name sipe.png
/nix/store/1i0mdncw7a34jp23hifmvcdk5kk4dimj-pidgin-sipe-1.18.1/share/pixmaps/pidgin/protocols/24/sipe.png
/nix/store/1i0mdncw7a34jp23hifmvcdk5kk4dimj-pidgin-sipe-1.18.1/share/pixmaps/pidgin/protocols/48/sipe.png
/nix/store/1i0mdncw7a34jp23hifmvcdk5kk4dimj-pidgin-sipe-1.18.1/share/pixmaps/pidgin/protocols/22/sipe.png
/nix/store/1i0mdncw7a34jp23hifmvcdk5kk4dimj-pidgin-sipe-1.18.1/share/pixmaps/pidgin/protocols/16/sipe.png
/nix/store/1i0mdncw7a34jp23hifmvcdk5kk4dimj-pidgin-sipe-1.18.1/share/pixmaps/pidgin/protocols/32/sipe.png

I use pidgin-with-plugins.override { plugins = [ pidginsipe ]; }.

Duplicate of #8999.


Create Tests!

I've never written tests before, I should really learn.

Well I have a whole 2 tests now, go me.


bugfix: when array value is not set, the default value contains one e…

bugfix： https://github.com/elastic/elasticsearch-hadoop/issues/1527
Thank you for submitting a pull request!
Please make sure you have signed our Contributor License Agreement (CLA).
We are not asking you to assign copyright to us, but to give us the right to distribute your code without restriction. We ask this of all contributors in order to assure our users of the origin and continuing existence of the code.
You only need to sign the CLA once.

[ ✅] I have signed the Contributor License Agreement (CLA)

no read and sign the above mentioned agreement if you want to contribute to this project


 This new OWNERS content is a copy of
prow/OWNERS.
What this PR does / why we need it:
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #
Special notes for your reviewer:
Release note:

@jmuk: Adding do-not-merge/release-note-label-needed because the release note process has not been followed.

One of the following labels is required "release-note", "release-note-action-required", or "release-note-none".
Please see: https://github.com/kubernetes/community/blob/master/contributors/devel/pull-requests.md#write-release-notes-if-needed.
Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

/release-note-none

/assign @mandarjog
cc @yutongz @sebastienvas

@jmuk: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
5dbcf50ba933ffa9d2a83bf2600d270b0d76085b
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Codecov Report

Merging #1729 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1729   +/-   ##
=======================================
  Coverage   79.83%   79.83%
=======================================
  Files         208      208
  Lines       21072    21072
=======================================
  Hits        16822    16822
  Misses       3758     3758
  Partials      492      492

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d075c93...5dbcf50. Read the comment docs.

/test istio-presubmit

isn't this more restrictive ? (fewer people)

I was thinking the toplevel OWNERS will apply on top of it. Isn't that right?

I think it replaces not add ? cc @yutongz

It adds. People in this level and higher levels can approve :)

that's a bummer because I think we had put fewer people in release/ to avoid accidental changes to the release/downloader etc...

I would just add those 2 to the toplevel one

I think the ideal situation is we don't have a lot top level approvers but apparently that not we are right now. https://github.com/kubernetes/test-infra/blob/master/OWNERS

/lgtm

/test e2e-smoke


AWS: Add support for Internet Gateway

Title: Add support for Internet Gateway
Description:
As of now, Cartography doesn't support Internet Gateway.
An internet gateway allows communication between your VPC and the internet.
The relationships that I've identified are
(AWSAccount) - [RESOURCE] -> (EC2InternetGateway)
(EC2InternetGateway) -[ATTACHED_TO]-> (AWSVpc)
Relevant Links
Internet Gateway

Started working on this here https://github.com/lyft/cartography/pull/555


Hyperparams for state of the art performance

Hi, I was looking at ur other file with the hyper params etc but u didn't show it achieving 95% accuracy...I was wondering, did you ever manage to achieve that?

Hi, I was looking at ur other file with the hyper params etc but u didn't show it achieving 95% accuracy...I was wondering, did you ever manage to achieve that?

i have also tried this architecture but i couldnt manage to reduce loss for cifar10 dataset.
Loss is not decreasing any further.
@brando90  could please tell how did you managed to get accuracy of 95 %,


Specify a git ref for rails

I don't know exact steps to reproduce this, but I often get this error when running lobsters with Ruby master.
Fetching gem metadata from https://rubygems.org/.........
Your bundle is locked to rails (7.1.0.beta1) from https://github.com/rails/rails.git (at main@d21d811), but that version can no longer be found in that source. That
means the author of rails (7.1.0.beta1) has removed it. You'll need to update your bundle to a version other than rails (7.1.0.beta1) that hasn't been removed in
order to install.

This is fixed if you have ref in Gemfile. The local git caching doesn't seem to work well unless you specify ref. This could be a bug on the rubygems side, but I'd like to run benchmarks whether we fix this or not.

Fair. To update Rails without the ref you can do "bundle update rails". But it's also good to do it explicitly like this -- much more trackable.


Pull channel or video description through to home

Is your feature request related to a problem? Please describe.
When on the desktop app home, there's a lot of wasted space and a video or channel name is not always descriptive enough. Especially as the app and user base grows.
Describe the solution you'd like
I would like to suggest that one the home page of the app (see screenshot attached) it pulls through a truncated or excerpted part of the channel or video description. There's plenty of space and will help with user experience. I appreciate right now we want as many people viewing as many videos/content as possible - but if we learn from Google's search params - giving people wnat they want quicker will ensure better user experience.
Describe alternatives you've considered
There are no alternatives - this is an enhancement.
Additional context
A small piece of login so that it displays a description consistently is that if there's a channel description, display that, else display content description (which should be a required field)

Thanks for the suggestion Mark! I know that area will be used for other information, so I'm not sure if we'll get the description into it. I know we are also exploring expanding those to include a video player, so we can probably add the description there. I'll let the app design guys decide what's best.

Totally cool - always worth putting ideas out there - I guess it's driven largely by what the majority of users need to see on that particular part of the UI that'll determine what takes priority.


[question] should serde_json re-export Serialize+Deserialize?

I am mostly wondering if there is a real reason it doesn't export them. It seems like it would be a good idea. For instance if you had to depend on two serde versions, you could have access to the exact trait that serde_json implements (this occaisonally happens when libraries haven't updated serde in a while).
I'm not necessarily saying it would be a good idea to do this, I'm just wondering why it is not done.

For bridging across Serde versions I would prefer to point people to these legacy shims. Having code in which serde::Serialize is different from serde_json::Serialize seems way more confusing than using serde09::Serialize and serde1::Serialize.

that's cool, I didn't know about those.
I forgot to mention it above, but do you think there would be value in exportin Serialize+Deserialize so that users could remove a dependency on the serde crate itself if they just wanted to create a function that accepted serializable types?


Fix NodeAnalyzer to accept quote and textbox definition as heading

Quotes or Text Boxes are to be defined in the Google Document as a paragraph prefixed with either the Quote: or the Textbox: word and suffixed by a horizontal line.
This commit allows the hotword to also be within a heading instead of insisting on it to be a regular paragraph.

+1, Nice!

+1

+1


Tenant Id

Do you think the tenant id should be part of the metadata ?

Yes, I think so.

Is this about making akka-ddd multi-tenant (i.e. segregating different "clients" events etc.)?

I think akka-persistence, akka-sharding and Eventstore fit well into multi-tenant architecture. But this issue was just a question about tenant Id. @albertolobrano: if akka-ddd needs to provide some additional support for multi-tenancy please share your expectations by creating new ticket.

@AshleyAitken I forgot to say you are also welcome to create an issue for multi-tenancy support :)


Polling new

Summary:
Added ability to update the schema on given time interval.
https://github.com/tailcallhq/tailcall/assets/62684960/ac10bcef-f798-448f-bf57-d4ef61f60335
Issue Reference(s):
Fixes https://github.com/tailcallhq/tailcall/issues/441
/claim https://github.com/tailcallhq/tailcall/issues/441
Build & Testing:

[x] I ran cargo test successfully.
[x] I have run ./lint.sh --mode=fix to fix all linting issues raised by ./lint.sh --mode=check.

Checklist:

[ ] I have added relevant unit & integration tests.
[x] I have updated the documentation accordingly (if applicable).
[ ] I have performed a self-review of my own code.

You might want to rebase the last two commits onto main

yup did that

Left one is main and the right one is with polling

We need further thinking of how reloads should be implemented. The current implementation is fairly thorough but may this isn't within the scope of the tailcall server. Configuration management should be done via external tools ideally.

/tip 50$


Add an option to forc deploy and forc run to write the constructed transaction to a file

This could be used in combination with --dry-run to output a transaction to file rather than deploying or running directly.
This would be useful for creating transactions that can be used for testing, and for greater interop with the forc submit and forc wallet sign plugin commands.
This would ideally support either json or the binary representation used by fuel-core.

This could also be useful for the forc-tx plugin if that feature is still planned.


Update omnidisksweeper to 1.10.x-r297660

According to the official website, the test builds is recommended for macOS 10.12 and later.
After making all changes to the cask:

[X] brew cask audit --download {{cask_file}} is error-free.
[X] brew cask style --fix {{cask_file}} reports no offenses.
[X] The commit message includes the cask’s name and version.

Additionally, if updating the sha256 only:

[ ] I verified this change is legitimate how do I do that? and am providing confirmation below:

Additionally, if adding a new cask:

[ ] Named the cask according to the token reference.
[ ] brew cask install {{cask_file}} worked successfully.
[ ] brew cask uninstall {{cask_file}} worked successfully.
[ ] Checked there are no open pull requests for the same cask.
[ ] Checked the cask was not already refused in closed issues.
[ ] Checked the cask is submitted to the correct repo.

https://omnistaging.omnigroup.com/omnidisksweeper/
Not for the faint of heart! These unstable and untested builds are snapshots of our development, updated every few hours. This means that you might actually be the first person to try a particular build and discover that it eats your system. (We hope that doesn't happen, of course, but since we won't have tested the app before giving you access we can't make any guarantees.)
If you'd like to join us on the bleeding edge of our development process, please select a download from below. If you'd prefer to work with something a little less risky, grab the latest stable release from our main site.

Despite that it is recommended for 10.12+ it is still considered unstable.
Please submit this to caskroom/versions as omnidisksweeper-test using a url do block.


immutable user creation yields bad ownership

Issue description
When I add the following to my coniguration.nix and rebuild:
  security.sudo.wheelNeedsPassword = false;
  users.mutableUsers = false;
  users.users.nixos = {
    isNormalUser = true;
    extraGroups = [ "wheel" "networkmanager" ];
    home = "/home/nixos";
    description = "Default system user";
    openssh.authorizedKeys.keys = ["ssh-rsa blah"];
  };
  users.users.brandon = {
    isNormalUser = true;
    extraGroups = [ "wheel" "networkmanager" ];
    home = "/home/brandon";
    description = "Default system user";
    openssh.authorizedKeys.keys = ["ssh-rsa  blah"];
  };

Before that, nixos was just a mutable user with password set.
I get this error after logging in as brandon:
WARNING: bad ownership on /nix/var/nix/profiles/per-user/brandon
WARNING: bad ownership on /nix/var/nix/gcroots/per-user/brandon

Indeed these directories are owned by nixos:users instead of brandon:users. Easy to fix manually but odd.
Steps to reproduce
Not 100% sure the above details are all that is needed, but I don't know what else is needed. If a NixOS dev wants to try this out, I'm happy to provide access to a virtual machine for a while.
Technical details

system: "x86_64-linux"
host os: Linux 4.14.83, NixOS, 18.03.133381.a18112a7e8f (Impala)
multi-user?: yes
sandbox: no
version: nix-env (Nix) 2.0.4
channels(nixos): ""
channels(root): "nixos-18.03.133381.a18112a7e8f"
nixpkgs: /nix/var/nix/profiles/per-user/root/channels/nixos/nixpkgs

Somewhat related: https://github.com/NixOS/nixpkgs/issues/10888


FaceX Library

About
A unified library for FaceX to run all the FaceX algorithms using only one line of code.
Example
Running cartoonify using FaceX library
import facex
import cv2

img = facex.cartoonify('your-img.jpg', method='opencv')
cv2.imshow(img)
cv2.waitkey()

Similarly we can run,
facex.face_detect('your-img.jpg', method='opencv') #Face detection
facex.face_mask('your-img.jpg', method='opencv')   #Face mask detection

And many more....

Pending Tasks ⏰

Release facex library V1.0 ✅
Refine the environment for easy access to the algorithms. ✅
Make a facex pip package.
Make clear documentation to use the package. ✅
Make clear documentation for the contributors to link the algorithms with the package.
Add more algorithms.

Contributions are welcome 🤗
Feel free to suggest any changes or fixes for the benefit of the package by commenting down below.
Notice to the maintainer

Please pin this issue.
Please add FaceX-API label to track activities regarding this API.

@akshitagupta15june  Please don't close this issue. Please read the Contributions are welcome ,pending tasks and Notice to the maintainer sections. I'd like to keep this open so to welcome more contributions and keep track of the progress of this library.

Sure i have opened the issue

Please pin this issue and add FaceX-API label.

Hello, I am a GSSOC'21 participant and would like to contribute to this project.

Please pin this issue and add FaceX-API label.

This is a good issue. @AdityaNikhil will it be okay if I contribute to this?

@Hamza3226  @animesh-007 With pleasure✌
Check the pending tasks section in the above issue. See if you can contribute to any of those or suggest new ideas by commenting here. Would love to collaborate!

sure

@AdityaNikhil can you guide the participants in this issue.

@akshitagupta15june Of course..!

@Hamza3226 and @animesh-007

Do we have to cartoonify an image ?

@Hamza3226  That's been done..!
Please check the How to use section here and get familiar with the codebase here.
@akshitagupta15june Can you open a discussion section for this repo. It'll be easier to make discussions.

done @AdityaNikhil

@akshitagupta15june if this issue is open can I please work on this

@subhangi2731
Of course, you can work on this issue. It's been a while since I worked on this.
You can check the homepage of this library here. Let me know if you like to discuss anything.

I'm surprised this hasn't been done already. If you'd like, I can take on the task. Creating a pip package shouldn't take more than a few minutes. Regarding the specifics of what this library should include, please provide me with the details.

I'm also unsure why the facex-library/GCA-Gender Classification API directory is located within the facex-lib package. It doesn't appear to be relevant or connected to the library.


fix: [#4470] Migrate off @azure/ms-rest-js botbuilder-ai

#minor
Description
This PR replaces the uses of @azure/ms-rest-js in the following botbuilder-js libraries.

[ ] botbuilder
[x] botbuilder-ai
[ ] botframework-connector
[ ] tool

Specific Changes

Replaced the @azure/ms-rest-js imports with @azure/core-http.
Added @azure/core-http to libraries package.json.
Added @azure/core-util version 1.5.0 to resolutions.
Updated unit tests to work with core-http RestError.

Testing
The following image shows some samples working after the update.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

46 of 49 (93.88%)  changed or added relevant lines in 8 files are covered.
82 unchanged lines in 5 files lost coverage.
Overall coverage decreased (-0.4%) to 84.436%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

libraries/botframework-connector/src/auth/tokenCredentials.ts
11
12
91.67%

libraries/botbuilder-ai/src/luisRuntimeClientContext.ts
11
13
84.62%

Files with Coverage Reduction
New Missed Lines
%

libraries/botbuilder-lg/src/templateExtensions.ts
1
84.48%

libraries/botframework-streaming/src/utilities/createNodeServer.ts
1
78.57%

libraries/botframework-streaming/src/namedPipe/namedPipeServer.ts
12
50.68%

libraries/botframework-streaming/src/namedPipe/namedPipeClient.ts
17
34.09%

libraries/botframework-streaming/src/namedPipe/namedPipeTransport.ts
51
3.92%

Totals

Change from base Build<PHONE_NUMBER>:
-0.4%

Covered Lines:
20210

Relevant Lines:
22671

💛  - Coveralls

Promoted /4577


fix: optionals in extracted types

this one ended up being just shapes, did tagged unions upstack

Current dependencies on/for this PR:

main

PR #6   👈

This comment was auto-generated by Graphite.

Graphite Merge Job
Current status: 🔄 Waiting for checks to pass
This pull request is currently waiting for CI and mergeability checks to pass before being merged.
This comment was auto-generated by Graphite.

Job Reference: pXLNmN6X5NmFIiJrO8xZ


Great project! how's the Whisper API coming along?

++

Thanks for this library, +1 for whisper :)

OpenAI's Whisper API still does not support streaming. See https://github.com/openai/whisper/discussions/2.
Related:

https://github.com/ggerganov/whisper.cpp
https://github.com/chengsokdara/use-whisper


Searching in row-column sorted matrix (GFG)

Description
In this PR I have solved question to search if a number is present in a sorted array or not using C++.
link:- https://practice.geeksforgeeks.org/problems/search-in-a-matrix-1587115621/1/?category[]=Matrix&category[]=Matrix&page=1&query=category[]Matrixpage1category[]Matrix
Fixes  #1831
Type of change
Please delete options that are not relevant.

[x] New feature (non-breaking change which adds functionality)

Checklist:

[x] My code follows the style guidelines(Clean Code) of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have created a helpful and easy to understand README.md
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests/screenshots(if any) that prove my fix is effective or that my feature works

@chicken-biryani @ravikr126  Please review my PR

@chicken-biryani @Amit366 @ravikr126  Please review my PR

Resolve merge conflict


Effective Cost descriptions

We need to document to the user what the effective cost max is.
https://issues.redhat.com/browse/COST-2444

Updated the description to help QE

Codecov Report

Merging #2361 (afd8bd4) into main (7cecf42) will increase coverage by 0.06%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2361      +/-   ##
==========================================
+ Coverage   68.83%   68.90%   +0.06%
==========================================
  Files         412      412
  Lines        7856     7880      +24
  Branches     1859     1736     -123
==========================================
+ Hits         5408     5430      +22
- Misses       2444     2445       +1
- Partials        4        5       +1

Impacted Files
Coverage Δ

src/locales/messages.ts
100.00% <ø> (ø)

...rc/pages/costModels/components/inputs/selector.tsx
97.05% <100.00%> (+2.32%)
:arrow_up:

.../pages/costModels/components/rateForm/rateForm.tsx
96.96% <100.00%> (-3.04%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7cecf42...afd8bd4. Read the comment docs.


Our individual fish data with ages < aged fish data

Even when we only look at aged fish from the gears we have effort data for, and filter for the years.
Individual fish data (1968 though 2022, only reliable through 2020)
First aged fish in individual fish data is 1986

Could be river fish. The individual fish file did NOT have any rivers (no kittles).
But with aged fish, there are rivers!!!

Is this a MN data problem?

This issue was resolved with the data request from DNR completed 23 Aug 2023 (implemented in the code in this repo mid-Sep 2023).


Count LOC for all kind of files

We should provide the number of lines for files also when we have no tree-sitter grammar for the language.

We should add the LOC metric in the output for every file that is considered as "not supported". Otherwise it would like like, that we can also calculate other metrics for those files.
Depending on the performance, we might want to introduce a cmd line argument to toggle this behavior. This would not be that important but could help us.


[Feature request] Support for multiple system access control configurations

According to the official Trino documentation:

Multiple system access control implementations may be configured at once using the access-control.config-files configuration property. It should contain a comma separated list of the access control property files to use (rather than the default etc/access-control.properties).

Currently only one system access control method can be configured by using the Helm Chart.
Ideally, the user should be able to provide a list of access control configurations.
I can provide a PR for this feature.

Isn't it possible to set access-control.config-files in .Values.server.coordinatorExtraConfig?

oh I had not thought of that.
So one would leave accessControl empty, and then proceed in creating configmaps for each system access control configuration externally from the chart, and mount them with additionalVolumes and additionalVolumeMounts. Does this sound right?

Yes, exactly.

 In Trino DENY always wins so as long as any one of the access controls deny the permission is denied. This is good since it fails-closed. But can be confusing to explain and debug.
Just my 2 cents.


C++/WinRT static members are not visible through derived type

From internal bug report:
Hi, we have some code that looks like this:
template <class T>
bool TryUpdateBackgroundBrush(T element, const folly::dynamic& propertyName, const folly::dynamic& propertyValue)
{
  if (propertyName == "backgroundColor")
  {
    if (propertyValue.isInt())
      element.Background(BrushFrom(propertyValue));

I need to add some code to this function to Clear the property when null... I tried adding something like this:
    if (propertyValue.isNull())
      element.ClearValue(T::BackgroundProperty());

but I get errors that BackgroundProperty() doesn't exist on Canvas, ScrollViewer, TextBox, etc.
It does exist on the base of those types, Panel::BackgroundProperty() or Control::BackgroundProperty()
Is there a secret way so Canvas::BackgroundProperty() can be called, or I have to walk its parent types until I find one with that?
Taking Canvas as an example, the winrt header looks like this:
struct WINRT_EBO Canvas :
    Windows::UI::Xaml::Controls::ICanvas,
    impl::base<Canvas, Windows::UI::Xaml::Controls::Panel, Windows::UI::Xaml::FrameworkElement, Windows::UI::Xaml::UIElement, Windows::UI::Xaml::DependencyObject>,

but I don't know of a way to get to the static methods on Panel from the Canvas type
is there one?

Moved to https://github.com/microsoft/cppwinrt/issues/354


Unable to add row color on hover

Cells styles override the row styles and unable to add a hover color on a row.
Also, it is background that is used and not background-color so it is not accepting the hex codes with opacity values in. It accepts it but cells can be seen as overlapped when scrolled behind the sticky columns.

How did you solve this? Having the same problem...


[source-git update] git cherry-pick fails due to staged changes

$ cd rpms; git clone "https://git.centos.org/rpms/apr.git"
$ cd ../source-git; git clone<EMAIL_ADDRESS>$ cd ..; CONTAINER_CMD="dist2src -v convert rpms/apr:c8s source-git/apr:c8" make run
docker run \
	-ti --rm \
	-v /home/jpopelka/git/packit/dist-git-to-source-git/dist2src:/usr/local/lib/python3.6/site-packages/dist2src:Z \
	-v /home/jpopelka/git/packit/dist-git-to-source-git/packitpatch:/usr/bin/packitpatch:Z \
	-v /home/jpopelka/git/packit/dist-git-to-source-git/macros.packit:/usr/lib/rpm/macros.d/macros.packit:Z \
	-v /home/jpopelka/git/packit/dist-git-to-source-git/tests:/tests:Z \
	-v /home/jpopelka/git/packit/dist-git-to-source-git/rpms:/workdir/rpms:Z \
	-v /home/jpopelka/git/packit/dist-git-to-source-git/source-git:/workdir/source-git:Z \
	-u 1000 \
	 \
	dist2src dist2src -v convert rpms/apr:c8s source-git/apr:c8
convert(origin='rpms/apr:c8s', dest='source-git/apr:c8')
Running command get_sources.sh in /workdir/rpms/apr
rpmbuild stderr = + umask 022
+ cd /workdir/rpms/apr/BUILD
+ cd /workdir/rpms/apr/BUILD
+ rm -rf apr-1.6.3
+ /usr/bin/bzip2 -dc /workdir/rpms/apr/SOURCES/apr-1.6.3.tar.bz2
+ /usr/bin/tar -xof -
+ STATUS=0
+ '[' 0 -ne 0 ']'
+ cd apr-1.6.3
+ /usr/bin/chmod -Rf a+rX,u+w,g-w,o-w .
+ /usr/bin/git init
+ /usr/bin/git add -f .
+ /usr/bin/git commit -q --allow-empty -a -m 'apr-1.6.3 base'
+ echo 'Patch #1 (apr-1.6.3-r1834495.patch):'
+ /usr/bin/packitpatch '%{1}' '%{2}' --fuzz=0 --no-backup-if-mismatch --no-backup-if-mismatch -p1 -b --suffix .r1834495 --fuzz=0
+ echo 'Patch #2 (apr-1.2.2-locktimeout.patch):'
+ /usr/bin/packitpatch '%{1}' '%{2}' --fuzz=0 --no-backup-if-mismatch --no-backup-if-mismatch -p1 -b --suffix .locktimeout --fuzz=0
+ echo 'Patch #3 (apr-1.2.2-libdir.patch):'
+ /usr/bin/packitpatch '%{1}' '%{2}' --fuzz=0 --no-backup-if-mismatch --no-backup-if-mismatch -p1 -b --suffix .libdir --fuzz=0
+ echo 'Patch #4 (apr-1.2.7-pkgconf.patch):'
+ /usr/bin/packitpatch '%{1}' '%{2}' --fuzz=0 --no-backup-if-mismatch --no-backup-if-mismatch -p1 -b --suffix .pkgconf --fuzz=0
+ echo 'Patch #5 (apr-rh1539844.patch):'
+ /usr/bin/packitpatch '%{1}' '%{2}' --fuzz=0 --no-backup-if-mismatch --no-backup-if-mismatch -p1 -b --suffix .rh1539844 --fuzz=0
+ echo 'Patch #6 (apr-1.4.8-deepbind.patch):'
+ /usr/bin/packitpatch '%{1}' '%{2}' --fuzz=0 --no-backup-if-mismatch --no-backup-if-mismatch -p1 -b --suffix .deepbind --fuzz=0
+ exit 0

The repo is not dirty, nothing to commit.
Fetch the dist-git %prep branch to source-git branch updates.
Traceback (most recent call last):
  File "/usr/local/bin/dist2src", line 33, in <module>
    sys.exit(load_entry_point('dist-git-to-source-git==0.1.dev218+g8cf46c8.d20201019', 'console_scripts', 'dist2src')())
  File "/usr/local/lib/python3.6/site-packages/click/core.py", line 829, in __call__
    return self.main(*args, **kwargs)
  File "/usr/local/lib/python3.6/site-packages/click/core.py", line 782, in main
    rv = self.invoke(ctx)
  File "/usr/local/lib/python3.6/site-packages/click/core.py", line 1259, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/usr/local/lib/python3.6/site-packages/click/core.py", line 1066, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/usr/local/lib/python3.6/site-packages/click/core.py", line 610, in invoke
    return callback(*args, **kwargs)
  File "/usr/local/lib/python3.6/site-packages/dist2src/cli.py", line 83, in wrapper
    ret = func(*args, **kwargs)
  File "/usr/local/lib/python3.6/site-packages/click/decorators.py", line 21, in new_func
    return f(get_current_context(), *args, **kwargs)
  File "/usr/local/lib/python3.6/site-packages/dist2src/cli.py", line 226, in convert
    d2s.convert(origin_branch, dest_branch)
  File "/usr/local/lib/python3.6/site-packages/dist2src/core.py", line 391, in convert
    from_branch=TEMP_SG_BRANCH, to_branch=dest_branch, theirs=update
  File "/usr/local/lib/python3.6/site-packages/dist2src/core.py", line 140, in cherry_pick_base
    self.repo.git.cherry_pick(f"{from_branch}~{num_commits - 1}", **git_options)
  File "/usr/local/lib/python3.6/site-packages/git/cmd.py", line 542, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/site-packages/git/cmd.py", line 1005, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/site-packages/git/cmd.py", line 822, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git cherry-pick updates~6
  stderr: 'error: your local changes would be overwritten by cherry-pick.
hint: commit your changes or stash them to proceed.
fatal: cherry-pick failed'
make: *** [Makefile:41: run] Error 1

I'm gonna start by creating a test case for this.

Ok, let's take an easier example, acl package has only c8 branch in dist-git as well as in source-git. If I'm told to regenerate the source-git package how should I do it?

CONTAINER_CMD="dist2src -v convert rpms/acl:c8 source-git/acl:c8" make run (which in my case results in the same issue as reported here)
or CONTAINER_CMD="dist2src -v convert rpms/acl:c8 source-git/acl:c8-updated" make run
or somehow else?

I'm gonna start by creating a test case for this.

Do you have any work-around for me meanwhile? (because I'm seeing it every time)

I would say you can use CONTAINER_CMD="dist2src -v convert rpms/acl:c8 source-git/acl:c8" make run
See this example update on rpm. It builds the new source-git changes on the top of the c8s branch, create imports/c8s/rpm-4.14.3-4.el8 branch and lastly move the c8s to the HEAD of that imports branch.
If there is a problem with that, we should fix it.

I'd love to point out that we should create a new branch and not update existing c8 source-git branch with content from c8s

OK, if we don't want to move the old branch, we should have to make optional the last step (moving the HEAD of the branch) that I described in the last comment.

sorry, missed these comments, reading just now
the guidance I'd love to give is keep things in the same structure as they are in dist-git right now - when we update repos, we should always update the same branches in source-git, so it should always be:
$ dist2src convert dist-git:branch source-git:branch

we should not move changes between c8 and c8s
luckily, the update mechanism "reverts" all previous changes so we can always recover if something bad happens, that's awesome!
does this help?


Always respect forced splits, even when feature_fraction < 1.0 (fixes #4601)

Fixes #4601.
Root cause for this issue: The histogram for the force split feature might not construct if feature_fraction < 1.0. And it would failed at SplitInner.

Only col-wise histogram construction impacted.  row-wise histogram construction would go through all features.
Only force split settings gain > 0 impacted. If no gain for force_split leaf, the force_split settings would be auto ignored.

Thanks for the changes. Please see a few suggestions I left about the tests. I think it's important to test with force_col_wise=true and force_row_wise=true to be confident that this fixes #4601.

@jameslamb Hi James, we found that when force_row_wise=true, the test case fails due to other problem, which is not related to using forced splits with feature_fraction < 1.0. It is probably due to the same problem as in issues #3679 #4739.
Can we leave this in subsequent PRs to fix, and merge this for now, given that all tests are passed?

Hi James, we found that when force_row_wise=true, the test case fails due to other problem

@shiyu1994 just to be sure I understand, which of these do you mean?

the tests added in this PR fail if you run them on master with force_row_wise=True
the tests added in this PR fail on this PR branch (but not master) with force_row_wise=True

If it's number 1, then I support merging this PR as-is and fixing the other bug in a later PR.
If it's number 2, then that means that bug would be introduced by this PR, and I don't think it should be merg ed.

@jameslamb thanks for the check here. It is for #1, "force_row_wise=True" same test would also repro on current master branch.

It is for #1

Got it, thanks! Then I think it's ok to merge this and fix that other bug separately. Thanks for explaining it to me 😄


Routes not detecting when vhost

Routes not found when vhost is setup, but in running artisan serve it can get the routes. I'm using laravel 5.3. Any idea?

Make sure to activate mod rewrite and point your domain into the public folder.
Also this .htaccess file belongs into the public folder.
BTW. this question belongs on some Q&A board like StackOverflow.


Update http4s-circe, http4s-dsl, ... to 0.21.25

Updates

org.http4s:http4s-circe
org.http4s:http4s-dsl
org.http4s:http4s-ember-client
org.http4s:http4s-ember-server

from 0.21.24 to 0.21.25.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.http4s" } ]

labels: library-update, semver-patch

Superseded by #40.


Unable to install extension

Hi,
I have tried to install the extension multiple times but hitting this issue - it is unable to locate the META-INF/bundle.xml under the zip.  I verified manually the file and folder exist.
bundle.xml -

<u:update id="keepalive">
<u:name>keepalive</u:name>
<u:version>1.3.1</u:version>
<u:author>Stefano Cristalli</u:author>
<u:author-url>http://scristalli.altervista.org</u:author-url>
<u:description>keepalive extension for Oracle SQL Developer 4+.</u:description>
</u:update>

SQL Developer version - 18.3

Just an update after giving direct path  to META-INF under zip , I am able to load the extension but unable to see any extension  icon after restart

Please refer to issue #31.

thanks it worked.


window.$ is undefined under async code execution

Hello!
I use mocha test runner under Cygwin and faced a problem loading jquery in any code snippets from README file here: https://github.com/tmpvar/jsdom/blob/master/README.md
For example:
// Print all of the news items on hackernews
var jsdom = require("jsdom");

jsdom.env({
  url: "http://news.ycombinator.com/",
  scripts: ["http://code.jquery.com/jquery.js"],
  done: function (errors, window) {
    var $ = window.$;
    console.log("HN Links");
    $("td.title:not(:last) a").each(function() {
      console.log(" -", $(this).text());
    });
  }
});

Inside the done() callback I have 'window' but 'window.$' appears undefined. I don't get any errors in console. After some research I came to the idea it is related to async unit tests execution.
Is there(or, are you going to add) async support for jsom.env and other functions?
Thanks in advance,
Anna.

I'm experiencing this too.

@dgreene1 You'll need to provide a sample code, all posted examples in this thread work fine.

Thanks I'll do that @Sebmaster. I'm currently retesting my code and I'll update afterwards.


Basic Example results in Assertion Error

After work around of Issue #3 (added NoneType = type(None) ).
I get the following error when executing the basic code.
from fomo import FomoClassifier
from pmlb import pmlb
X,y = pmlb.fetch_data('adult', return_X_y=True)
groups = ['race','sex']
est = FomoClassifier()
est.fit(X,y, protected_features=groups)

AssertionError: X should be a dataframe
"""
The above exception was the direct cause of the following exception:
AssertionError                            Traceback (most recent call last)
Cell In[2], line 6
4 groups = ['race','sex']
...
769     return self._value
770 else:
--> 771     raise self._value
AssertionError: X should be a dataframe

X does need to be a dataframe. Try this instead:
dataset = pmlb.fetch_data('adult')
dataset = dataset.sample(n=2000)
X = dataset.drop('target',axis=1)
y = dataset['target']


[Platform] Interoperability: extended_resource

[Acceptance Criteria] (TBD)
Interoperability test: extended_resource test
Short description of platform test:
if a survey of extended resources and fields determine that the cluster has a lower percentage of available nodes for the class that is required for a cnf pod, then the platform test is not using commoditized scheduling

goal of this interoperability test

Test Category

ADD Interoperability category

determining what 'resources' are allocatable for the anuket reference implementation:
https://cntt.readthedocs.io/projects/ri2/en/stable-moselle/chapters/chapter04.html#operational-runbook
https://kubernetes.io/docs/concepts/extend-kubernetes/compute-storage-net/device-plugins/
"Kubernetes provides a device plugin framework that you can use to advertise system hardware resources to the Kubelet.
Instead of customizing the code for Kubernetes itself, vendors can implement a device plugin that you deploy either manually or as a DaemonSet. The targeted devices include GPUs, high-performance NICs, FPGAs, InfiniBand adapters, and other similar computing resources that may require vendor specific initialization and setup. "
https://kubernetes.io/docs/concepts/configuration/manage-resources-containers/#cluster-level-extended-resources
AKA does this violate "commoditized scheduling"?
service provider test?
only makes sense if a platform and a cnf is being evaluated

Implementation Tasks: TBD
Environment set up tasks:

[ ]

Upstream tool set up tasks: (test suite + upstream tools)

[ ]

CNF setup Tasks

[ ]

Sample CNF tasks:

[ ]

Code implementation tasks:

[ ]

Documentation tasks:

[ ] Update Test Categories md if needed
[ ] Update Pseudo Code md if needed
[ ] Update USAGE md if needed
[ ] Update installation instructions if needed

QA tasks
Dev Review:

[ ] walk through A/C
[ ] do you get the expected result?
[ ] if yes,

[ ] move to Needs Peer Review column
[ ] create Pull Request and follow check list
[ ] Assign 1 or more people for peer review

[ ] if no, document what additional tasks will be needed

Peer review:

[ ] walk through A/C
[ ] do you get the expected result?
[ ] if yes,

[ ] move to Reviewer Approved column
[ ] Approve pull request

[ ] if no,

[ ] document what did not go as expected, including error messages and screenshots (if possible)
[ ] Add comment to pull request
[ ] request changes to pull request

See https://github.com/lfn-cnti/bestpractices/issues/309
Relevant for Anuket:

Review Anuket "4. Operational Runbook" and tests or tests ideas from the CNTI Test Catalog
See https://github.com/cnti-testcatalog/testsuite/issues/1716


Buil-in VAR for the Home Assistant version running on the system

Hi, would it be possible to have a new buil-in var for the current HA version running on the system?
Would love adding that to the title bar (button text, options).
Tks

{{ hassVersion }} template variable added in 1.4.6

Tks a lot

Hi Ryan,
please update doc accordingly for that {{ hassVersion }}
https://maykar.github.io/custom-header/#templates/builtin
Implemented! Tks
Denis
Le dim. 24 mai 2020 à 03:53, Ryan Meek<EMAIL_ADDRESS>a écrit :

{{ hassVersion }} template variable added in 1.4.6
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/maykar/custom-header/issues/172#issuecomment-633165147,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AKEZB7C257KCYF2AT43NJBDRTB4YTANCNFSM4MLOAIRA
.

That's the next thing on my list, docs need a fair few updates.

There is an edit link on each page of the docs as well so anyone can submit and update to be pulled.