Cleanups in Listings.go

Includes changing Desc to Description for consistency. This may require an equivalent change on the frontend.

Coverage remained the same at 60.427% when pulling dc5c1f668bc01a15329e1c1a44636be82ffa635f on JustinDrake:patch-22 into a60b71f495297e9b2ee618c4fff4fb3226e0ed64 on OpenBazaar:master.

Just have to let @rmisio know that desc was changed to description in the listing index.

Just have to let @rmisio know that desc was changed to description in the listing index.

Who do you think you are!?
(just kidding, sounds good :))

Also @JustinDrake do you want to update api.yaml to reflect the change from desc to description.

Actually looks like that api call isn't in the yaml and needs to be created.


Is this not supported in Azure DevOps Server at all?

Is this not supported in Azure DevOps Server at all?
Thanks!

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 365bff0e-8532-ae8a-f1c9-37ea7017e5b1
Version Independent ID: a324129d-0edb-00ce-1217-819be9fda4f6
Content: Change process from Basic to Agile - Azure Boards
Content Source: docs/organizations/settings/work/change-process-basic-to-agile.md
Product: devops
Technology: devops-agile
GitHub Login: @kaelli
Microsoft Alias: kaelli

@gojanpaolo - Thank you for your inquiry. Yes, currently the Change process for a project is only supported on Azure DevOps Services. It is scheduled to be available with Azure DevOps Server 2020 (according to the Feature timeline) slated to be released sometime this summer.


adding code block examples

What are you changing in this pull request and why?
Adding code block examples per and internal Slack conversation.
Checklist

[ ] Review the Content style guide and About versioning so my content adheres to these guidelines.
[ ] Add a checklist item for anything that needs to happen before this PR is merged, such as "needs technical review" or "change base branch."

Adding new pages (delete if not applicable):

[ ] Add page to website/sidebars.js
[ ] Provide a unique filename for the new page

Removing or renaming existing pages (delete if not applicable):

[ ] Remove page from website/sidebars.js
[ ] Add an entry _redirects
[ ] Ran link testing to update the links that point to the deleted page

hey @runleonarun - following up on this, i'll go ahead and commit @nghi-ly 's suggestion and merge this for you - hope that's ok! if not, i can revert this for you.


Build broken in 32-bit

..\..\..\AppData\Roaming\dub\packages\imageformats-4.2.1\imageformats.d(2121,54)
: Error: cannot implicitly convert expression (cast(long)cl0 + dc.comps[1].x) of
 type long to uint

Suggested patch
                    resample(dc.comps[1].data[cl0 .. cl0 + cast(size_t)dc.comps[1].x],
                             dc.comps[1].data[cl1 .. cl1 + cast(size_t)dc.comps[1].x],
                             comp1[]);
                    resample(dc.comps[2].data[cl0 .. cl0 + cast(size_t)dc.comps[2].x],
                             dc.comps[2].data[cl1 .. cl1 + cast(size_t)dc.comps[2].x],
                             comp2[]);

Uh, I was silly to ever use long anywhere and it's still haunting me. I'll change the type to size_t in the struct.

And thanks for reporting, I'd never have noticed myself because I always forget to try with -m32.

Maybe Travis CI could help with that,


Dynamically update tachyons version in docs

When we bump the tachyons version in the package.json the new version should be picked up on the next build.

This is fixed.


swagger inconsistencies: fix /libpod/events

Fix a confusing inconsistency between swagger and actual
registration. I think this is the intention, but please
review carefully.
Signed-off-by: Ed Santiago<EMAIL_ADDRESS>

@baude @jwhonce PTAL; I suggest checking out into your local git tree, and/or using the expandos to view full context (i.e. the //swagger comments above). I believe this is the intended behavior, but I might be mistaken.

this is covered in https://github.com/containers/libpod/pull/5525 i believe

Yep, hadn't seen that, thanks. Closing.


Parallelism for CLI

This PR introduced parallelism for the CLI as well as ensuring that full coverage is sent to sonar cloud.
This PR is extremely similar to this one https://github.com/dockstore/dockstore/pull/4970, so I will just be noting differences here.
Parallelism
Unfortunately, the maven build phase dockstore takes approximately 5 minutes to run in each parallel job. Meaning that as we increases parallelism, the amount of billable time increases rapidly, whereas the amount of actual time decreases slowly. Below is a link to the results of my tests of different levels of parallelism.
https://docs.google.com/document/d/1If-ARO5RvfZ5LQc7ZZIU3mg86NR7atIftfKfrkWoBuM
The levels of parallelism implemented in this PR are highlighted in yellow.
I have also split some large test files into several smaller files to ensure that all parallel jobs are running a roughly equal amount of tests (more details in referenced PR).
Sonar Cloud
The Sonar Cloud job now runs after all other jobs have completed. It takes about 7 minutes to run (as it needs to build the project first), however it now sends the coverage from all the tests to sonar cloud.
ISSUE
SEAB-4502

[X] Check that you pass the basic style checks and unit tests by running mvn clean install

I have gone through all the files I have split and double checked that no tests have been deleted by accident.


Fix forgetting smeshing is enabled

bug description: set up smeshing, wait until node is synced, close the app and then reopen it. Go to smeshing tab and app will state that smeshing is not set

This issue is not fixed.

@yaelmhoffman - plz describe the steps to reproduce and what build you were testing and on what platform e.g. 0.0.6.RC2 on win 10 home....

And I think you want to comment that the issue is still happening in the comment of the issue itself and not this PR which was merged...

Using build 0.0.6.RC2 on Windows 10 Home.
Closed app. Reopened app. It says that smeshing needs to be set up, even though I've already set up smeshing upon installation.

Build: v0.0.6RC5
OS: Windows 10 home
Fix confirmed!


Remove need for spin projection in spin_magnitude_conservation rule

The spin_magnitude_conservation() rule requires SpinEdgeInput, which has a spin_projection attribute, even though the rule implementation does not need it. This is a problem for #158. That issue either needs to work with spin projections for now (which is what we eventually want to remove, see #219) or we need to remove the need for providing a spin projection altogether by solving this issue first.
https://github.com/ComPWA/qrules/blob/e60ff895b4cf84be18291b6e4fe0ab516e75a493/src/qrules/conservation_rules.py#L694-L728

Has been implemented in the remove_spin-projections_in_cons-rules-branch. Issue should be closeable after merging.


jinja2 is not optional

langchain was installed via pip
Traceback (most recent call last):
  File "/Users/oleksandrdanshyn/github.com/dalazx/langchain/test.py", line 1, in <module>
    from langchain.agents import load_tools, initialize_agent, AgentType
  File "/Users/oleksandrdanshyn/github.com/dalazx/langchain/langchain/__init__.py", line 6, in <module>
    from langchain.agents import MRKLChain, ReActChain, SelfAskWithSearchChain
  File "/Users/oleksandrdanshyn/github.com/dalazx/langchain/langchain/agents/__init__.py", line 2, in <module>
    from langchain.agents.agent import (
  File "/Users/oleksandrdanshyn/github.com/dalazx/langchain/langchain/agents/agent.py", line 17, in <module>
    from langchain.chains.base import Chain
  File "/Users/oleksandrdanshyn/github.com/dalazx/langchain/langchain/chains/__init__.py", line 2, in <module>
    from langchain.chains.api.base import APIChain
  File "/Users/oleksandrdanshyn/github.com/dalazx/langchain/langchain/chains/api/base.py", line 8, in <module>
    from langchain.chains.api.prompt import API_RESPONSE_PROMPT, API_URL_PROMPT
  File "/Users/oleksandrdanshyn/github.com/dalazx/langchain/langchain/chains/api/prompt.py", line 2, in <module>
    from langchain.prompts.prompt import PromptTemplate
  File "/Users/oleksandrdanshyn/github.com/dalazx/langchain/langchain/prompts/__init__.py", line 3, in <module>
    from langchain.prompts.chat import (
  File "/Users/oleksandrdanshyn/github.com/dalazx/langchain/langchain/prompts/chat.py", line 10, in <module>
    from langchain.memory.buffer import get_buffer_string
  File "/Users/oleksandrdanshyn/github.com/dalazx/langchain/langchain/memory/__init__.py", line 11, in <module>
    from langchain.memory.entity import (
  File "/Users/oleksandrdanshyn/github.com/dalazx/langchain/langchain/memory/entity.py", line 8, in <module>
    from langchain.chains.llm import LLMChain
  File "/Users/oleksandrdanshyn/github.com/dalazx/langchain/langchain/chains/llm.py", line 11, in <module>
    from langchain.prompts.prompt import PromptTemplate
  File "/Users/oleksandrdanshyn/github.com/dalazx/langchain/langchain/prompts/prompt.py", line 8, in <module>
    from jinja2 import Environment, meta
ModuleNotFoundError: No module named 'jinja2'

since prompt.py is one of the fundamental modules and it unconditionally imports jinja2, jinja2 should probably be added to the list of required dependencies.

Just ran into the same issue.

I see this issue is due to #3013. I opened a pull request in #3123 that makes langchain only imports jinja2 when jinja2 prompt template is used. Thanks for pointing that out.

Should be fixed in the latest release.


peg: Allow single quoted key 'col'

Overview
Updates the col rule support single quoted column keys (which matches the item rule).
Pull request checklist

[x] I have read the contributing guide.
[x] I have agreed to the Contributor License Agreement.
[x] I have resolved any merge conflicts.
[x] I have included tests that cover my changes.
[x] All new and existing tests pass.

Code review checklist
This is the checklist that the reviewer will follow while reviewing your pull request. You do not need to do anything with this checklist, but be aware of what the reviewer will be looking for.

[ ] Ensure that any changes to external docs have been included in this pull request.
[ ] If the changes require that minor/major versions need to be updated, tag the PR appropriately.
[ ] Ensure the new code is properly commented and follows Idiomatic Go.
[ ] Check that tests have been written and that they cover the new functionality.
[ ] Run tests and ensure they pass.
[ ] Build and run the code, performing any applicable integration testing.

@jaffee IIRC you had some comment about sticking with one type of quote delimiter - was that relevant here?

I'm cool with this


Mirror sections and (section) descriptions in the prototype

This pull request:

Creates the sections as they currently are in the prototype.
Adds descriptions to the sections as they currently read in the prototype.  Using the description key instead of the summary_page_description key because we saw it first.  Open to changing it if anyone has strong opinions.
Adds a step key to manifest files so that we can group sections more precisely on the overview page.
Adds an extra check for a multiquestion's any_of field before generating all of our crazy anyOfs and dependencies in JSON schemas.

It doesn't:

Modify any existing questions.  In creating new sections, I roughly grouped questions where they might make sense, but generally the questions in the prototype are quite different.
Add dynamic content to descriptions.  There's a section description in the prototype that wants the current user's email address, but we can't really do this with our static descriptions.

👍


client to server connection lag

Describe the bug
at random times (at least i couldnt figure out a way to constantly reproduce this), when you hit an entity even once, the client acts like the server froze- all entities are frozen in place, cant damage anything, no drops etc... - when in fact it just lags for the player who had hit an entity. other players continue playing fine as if nothing happened. running fabric 1.20.1 on a dedicated server, i can share the log:
latest.log
" [18:31:43] [Netty Play IO Thread #0/ERROR]: (AttackServer.recieve) literal{Caelus_HSR}: Entity is null! " seems like it represents the player trying to hit an entity while in this "fake frozen" state
To Reproduce
Steps to reproduce the behavior:

hit an entity
sometimes will make it seem like the server's frozen

Expected behavior
the client not acting like the server froze
Screenshots
log above
Additional context
fourth issue in a row haha. i really really enjoy this mod, if you could look into this so i dont have to remove it from my modpack, that'd be amazing 🙏

This has to do with how the client interacts with the server, I will fix this issue in the next update.


[MINOR][CORE] Replace get+getOrElse with getOrElse with default value in StreamingQueryException

What changes were proposed in this pull request?
This PR replaces get + getOrElse with getOrElse with a default value in StreamingQueryException.
Why are the changes needed?
Simplify code
Does this PR introduce any user-facing change?
No
How was this patch tested?
Pass GitHub Actions
Was this patch authored or co-authored using generative AI tooling?
No

Thanks @dongjoon-hyun


Handle large cookies / Check whether cookie save was successful

Many browsers have a max cookie size (eg, 4096 bytes). If the authenticated data object returned by an authenticator is large enough, the resulting cookie can be too large to save.
On Chrome 54.0.2840.98, the attempt to write this cookie fails, but ember-simple-auth currently doesn't detect this failure. The flow-on effect is that when _syncData is next called, it detects a change (because while the main cookie failed, the cookieExpirationTime cookie was set successfully), and without the main cookie, it logs the user out.
In an ideal world, ember-simple-auth would handle this automatically behind the scenes, eg by splitting the data over multiple cookies and reassembling them again later.
In a more realistic world, ember-simple-auth might detect cookie-writing failure, and send an appropriate error back to the application to make debugging easier.
At the least, the docs could warn that when using the cookie store to be mindful of data sizes, and consider saving additional information in separate cookies.
Needless to say, this problem does not occur when using local storage.
Happy to submit a PR for documentation change, but I couldn't find them in the repo.
On the whole though, great plugin, very helpful.

Other details:
ember-simple-auth version: #274f0e7
operating system: OSX 10.12 (Sierra)
browser: 54.0.2840.98 (64-bit)
reproduction steps:

Use cookie session storage
Create a custom authenticator
Implement authenticate to resolve with a very large object, eg one containing very long strings
Try to log in
Observe that the user is successfully logged in, then immediately logged out

Yeah, good point. I think mentioning the maximum cookie size in the docs would be a good idea. Maybe there should also be an assertion in the code.

In an ideal world, ember-simple-auth would handle this automatically behind the scenes, eg by splitting the data over multiple cookies and reassembling them again later.

I'm actually not sure this is a good idea as it would add a ton of complexity to ESA. Storing more data in the cookie is an antipattern anyway IMO.


Enable SSL by default

From discussion on issue #117: Enabling SSL by default on the Shadow Reader:

Changes to app.yaml, package.json. and server.js, to enable SSL by default, by following suggestions from @andreban on his experience with PWA Directory (see app.yaml, app.js, package.json).

Added helmet, as recommended on ExpressJs site.

Additional Notes:

Uploaded current version of Shadow Reader (not on SSL by default) to GCP, and tested the changes, by uploading a new version of the webapp at steel-topic-208022.appspot.com. Testing the url on any browser with or without protocol, always redirects to HTTPS.

During the tests, just by adding the logic suggested by @andreban was enough to ensure SSL by default. Consider removing helmet, if the additional benefits listed here are not needed.

This version replicates the logic on PWA Directory. Worth checking if the condition on this line would be required for Shadow Reader as well, or we should omit that one (I'm not familiar with the architecture, to be sure).

LGTM, thanks much!

Can one of you deploy this as new version to our app engine?

I can deploy it!
@demianrenzulli, the test instance you kindly set up at steel-topic-208022.appspot.com isn't currently functional... but if you all think this is good, I'll deploy.  Can you confirm?

@morsssss that's right Ben! I turned it off, because I was being billed, even when the service had almost no traffic.
From my tests everything worked well. If you want, you can just deploy this version, and we can make sure it's working as intended (not sure if you can, for example, deploy to a version different than the default, just in case).

@demianrenzulli @pbakaus We just saw this problem again in Brazil... @rsimha was demonstrating amp.cards, but he didn't get a service worker because he typed in amp.cards, not https://amp.cards, and it didn't redirect.

Sad. Please fix!


Internal error in sentry_sdk

Environment
SaaS (https://sentry.io/)
Steps to Reproduce
I am randomly getting the following error from some of my Python services. The SDK seems it is sending events correctly to sentry.io. No clue if it is skipping some of them. The error seems to occur more with load.
The service is mainly a Flask Python 3.11 g, run by guincorn on a kubernetes cluster in multiple instances on Google Cloud. All dependencies are basically up to date, and I'm using sentry-sdk-1.40.2 and urllib3-2.0.7.
In the attempt of fixing it, I tried to customize as follows the HttpTransport used by Sentry SDK, with no luck.
try:
    logger.info('Initializing Sentry SDK...')
    sentry_sdk.init(
        ...,
        environment=...,
        traces_sample_rate=...,
        integrations=[FlaskIntegration(), RedisIntegration()],
    )

    import socket
    from sentry_sdk import transport
    from sentry_sdk.transport import HttpTransport
    from urllib3.connection import HTTPConnection

    class KeepAliveHttpTransport(HttpTransport):
        def _get_pool_options(self, ca_certs):
            opts = super()._get_pool_options(ca_certs)
            opts['socket_options'] = HTTPConnection.default_socket_options + [
                (socket.SOL_SOCKET, socket.SO_KEEPALIVE, 1),
                (socket.SOL_TCP, socket.TCP_KEEPIDLE, 45),
                (socket.SOL_TCP, socket.TCP_KEEPINTVL, 10),
                (socket.SOL_TCP, socket.TCP_KEEPCNT, 6),
            ]
            return opts

    logger.info('Forcing keep alive for Sentry SDK HTTP transport...')
    transport.HttpTransport = KeepAliveHttpTransport

except Exception as e:
    logger.info(f'Unable to Start Sentry due to error: {e}')

Expected Result
No connection errors
Actual Result
Internal error in sentry_sdk
Traceback (most recent call last): File "/usr/local/lib/python3.11/dist-packages/urllib3/connectionpool.py", line 793, in urlopen response = self._make_request(
^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.11/dist-packages/urllib3/connectionpool.py", line 537, in _make_request
response = conn.getresponse()
^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.11/dist-packages/urllib3/connection.py", line 466, in getresponse
httplib_response = super().getresponse()
^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.11/dist-packages/sentry_sdk/integrations/stdlib.py", line 126, in getresponse
return real_getresponse(self, *args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/lib/python3.11/http/client.py", line 1386, in getresponse
response.begin()
File "/usr/lib/python3.11/http/client.py", line 325, in begin
version, status, reason = self._read_status()
^^^^^^^^^^^^^^^^^^^
File "/usr/lib/python3.11/http/client.py", line 294, in _read_status
raise RemoteDisconnected("Remote end closed connection without"
http.client.RemoteDisconnected: Remote end closed connection without response
{}
During handling of the above exception, another exception occurred:
{}
Traceback (most recent call last): File "/usr/local/lib/python3.11/dist-packages/sentry_sdk/transport.py", line 535, in send_envelope_wrapper self._send_envelope(envelope) File "/usr/local/lib/python3.11/dist-packages/sentry_sdk/transport.py", line 434, in _send_envelope self._send_request( File "/usr/local/lib/python3.11/dist-packages/sentry_sdk/transport.py", line 245, in _send_request response = self._pool.request(
^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.11/dist-packages/urllib3/_request_methods.py", line 144, in request
return self.request_encode_body(
^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.11/dist-packages/urllib3/_request_methods.py", line 279, in request_encode_body
return self.urlopen(method, url, **extra_kw)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.11/dist-packages/urllib3/poolmanager.py", line 444, in urlopen
response = conn.urlopen(method, u.request_uri, **kw)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.11/dist-packages/urllib3/connectionpool.py", line 847, in urlopen
retries = retries.increment(
^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.11/dist-packages/urllib3/util/retry.py", line 470, in increment
raise reraise(type(error), error, _stacktrace)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.11/dist-packages/urllib3/util/util.py", line 38, in reraise
raise value.with_traceback(tb)
File "/usr/local/lib/python3.11/dist-packages/urllib3/connectionpool.py", line 793, in urlopen
response = self._make_request(
^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.11/dist-packages/urllib3/connectionpool.py", line 537, in _make_request
response = conn.getresponse()
^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.11/dist-packages/urllib3/connection.py", line 466, in getresponse
httplib_response = super().getresponse()
^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.11/dist-packages/sentry_sdk/integrations/stdlib.py", line 126, in getresponse
return real_getresponse(self, *args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/lib/python3.11/http/client.py", line 1386, in getresponse
response.begin()
File "/usr/lib/python3.11/http/client.py", line 325, in begin
version, status, reason = self._read_status()
^^^^^^^^^^^^^^^^^^^
File "/usr/lib/python3.11/http/client.py", line 294, in _read_status
raise RemoteDisconnected("Remote end closed connection without"
urllib3.exceptions.ProtocolError: ('Connection aborted.', RemoteDisconnected('Remote end closed connection without response'))

Product Area
Issues
Link
No response
DSN
<EMAIL_ADDRESS>Version
No response

Likely to be caused by https://github.com/getsentry/sentry-python/issues/2386

Likely to be caused by #2386

@vartec how is that connected? My app does not crash, only the Sentry SDK is complaining...

I am getting the same issue as above:
sentry-sdk[flask,django,celery]==1.29.0
python3.9

Hey @manuellazzari-cargoone and @kieran-sf! Thanks for reporting this.
My first suggestion would've been exactly what you tried @manuellazzari-cargoone with the custom socket options from https://github.com/getsentry/sentry-python/issues/1198#issuecomment-1802638463. Are you seeing at least some improvement?
I'm curious whether spacing out the events sent from the SDK makes a difference. Can you try overriding _send_request in your custom transport roughly like this?
import time

class KeepAliveHttpTransport(HttpTransport):
    def _send_request(self, *args, **kwargs):
        time.sleep(0.01)
        super()._send_request(self, *args, **kwargs)

@sentrivana thanks for getting back -- when trying the custom socket settings I wasn't able to see any major differences. Now I'm testing the whole package (custom socket settings and custom send request).

@sentrivana the issue is still there even by adding the custom _send_request. From a qualitative perspective, it seems that it appears more or less with the same frequency (see below an extraction from our logs before and after the changes were deployed).
2024-02-16T15:29:33.048565197Z ERROR - sentry_sdk.errors - Internal error in sentry_sdk
2024-02-16T15:30:55.565954424Z ERROR - sentry_sdk.errors - Internal error in sentry_sdk
2024-02-16T15:33:13.537149008Z ERROR - sentry_sdk.errors - Internal error in sentry_sdk
2024-02-16T15:33:17.914818994Z ERROR - sentry_sdk.errors - Internal error in sentry_sdk
2024-02-16T15:34:47.778557487Z ERROR - sentry_sdk.errors - Internal error in sentry_sdk
2024-02-16T15:34:47.819326396Z ERROR - sentry_sdk.errors - Internal error in sentry_sdk
2024-02-16T15:37:33.774480759Z ERROR - sentry_sdk.errors - Internal error in sentry_sdk
2024-02-16T15:37:34.586534890Z ERROR - sentry_sdk.errors - Internal error in sentry_sdk
2024-02-16T15:41:53.741483570Z ERROR - sentry_sdk.errors - Internal error in sentry_sdk
2024-02-16T15:45:11.560933696Z ERROR - sentry_sdk.errors - Internal error in sentry_sdk
2024-02-16T15:51:10.940568800Z ERROR - sentry_sdk.errors - Internal error in sentry_sdk
2024-02-16T15:51:11.016053254Z ERROR - sentry_sdk.errors - Internal error in sentry_sdk
2024-02-16T15:51:20.146324668Z ERROR - sentry_sdk.errors - Internal error in sentry_sdk
2024-02-16T15:51:28.814144310Z ERROR - sentry_sdk.errors - Internal error in sentry_sdk
2024-02-16T15:58:53.136957655Z ERROR - sentry_sdk.errors - Internal error in sentry_sdk
2024-02-16T15:58:54.053616565Z ERROR - sentry_sdk.errors - Internal error in sentry_sdk
2024-02-16T15:59:16.002942751Z ERROR - sentry_sdk.errors - Internal error in sentry_sdk
2024-02-16T16:03:12.954825518Z Initializing Sentry SDK... <-- changes deployed
...
2024-02-16T16:13:44.713686531Z ERROR - sentry_sdk.errors - Internal error in sentry_sdk
2024-02-16T16:22:30.285920011Z ERROR - sentry_sdk.errors - Internal error in sentry_sdk
2024-02-16T16:25:48.997920085Z ERROR - sentry_sdk.errors - Internal error in sentry_sdk
2024-02-16T16:25:49.389493362Z ERROR - sentry_sdk.errors - Internal error in sentry_sdk
2024-02-16T16:26:00.889221302Z ERROR - sentry_sdk.errors - Internal error in sentry_sdk
2024-02-16T16:38:44.314760846Z ERROR - sentry_sdk.errors - Internal error in sentry_sdk

@manuellazzari-cargoone Thanks for the follow up. It looks like the sleep might've had a tiny effect, at least from the logs it looks like there's less occurrences if you look at a comparable time span before and after -- but this could obviously have to do with traffic etc., so don't think this is exactly conclusive.
Are you seeing any network errors for outgoing requests anywhere else in your system? Just trying to rule out general network instability. Alternatively I'm thinking if there's anything special about the errors/transactions -- maybe them being unusually big so it takes long to send each one and the server drops the connection?

Are you seeing any network errors for outgoing requests anywhere else in your system? Just trying to rule out general network instability.

I'm observing this issue just with 2 services both running with gunicorn. Also it's all GCP, so I would rule out consistent network instability.

Alternatively I'm thinking if there's anything special about the errors/transactions -- maybe them being unusually big so it takes long to send each one and the server drops the connection?

I'm not sure about size, but I know for sure we have services deal with a lot more traffic and a lot bigger packages. In particular, one of the affected services is dealing with very little traffic and small packages and still experiencing the problem.

FYI @manuellazzari-cargoone we have now experimental Http2Transaport that you can find here: https://github.com/getsentry/sentry-python/blob/master/sentry_sdk/transport.py#L736C11-L736C25
Maybe this solves your problem?

HI
What happens to me is very similar, only it is when I create a “simple event”, I have my sentry in a k8s cluster.
Error:
  File "/.venv/lib/python3.12/site-packages/urllib3/connectionpool.py", line 843, in urlopen
    retries = retries.increment(
              ^^^^^^^^^^^^^^^^^^
  File "/.venv/lib/python3.12/site-packages/urllib3/util/retry.py", line 519, in increment
    raise MaxRetryError(_pool, url, reason) from reason  # type: ignore[arg-type]
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
urllib3.exceptions.MaxRetryError: HTTPConnectionPool(host='localhost', port=64186): Max retries exceeded with url: /api/1/envelope/ (Caused by NewConnectionError('<urllib3.connection.HTTPConnection object at 0x7fa3f3d3cf50>: Failed to establish a new connection: [Errno 111] Connection refused'))
00:28:10 [ERROR] sentry_sdk.errors: Internal error in sentry_sdk


Transformer Version

Dear authors
Thanks for sharing your codes. When I was running train_text_classifier.py
I got some errors, and I would like to ask which version of transformers you are using. Thank you very much.
Traceback (most recent call last):
File "train_text_classifier.py", line 681, in
main()
File "train_text_classifier.py", line 634, in main
train_dataset = load_and_cache_examples(args, args.task_name, tokenizer, evaluate=False)
File "train_text_classifier.py", line 386, in load_and_cache_examples
features = convert_examples_to_features(
File "~/site-packages/transformers/data/processors/glue.py", line 72, in glue_convert_examples_to_features
return _glue_convert_examples_to_features(
File "~/site-packages/transformers/data/processors/glue.py", line 143, in _glue_convert_examples_to_features
batch_encoding = tokenizer(
File "~/site-packages/transformers/tokenization_utils_base.py", line 2318, in call
return self.batch_encode_plus(
File "~/transformers/tokenization_utils_base.py", line 2503, in batch_encode_plus
return self._batch_encode_plus(
File "~/site-packages/transformers/tokenization_utils_fast.py", line 375, in _batch_encode_plus
encodings = self._tokenizer.encode_batch(
TypeError: TextInputSequence must be str

Hi Ziqian,
Please try transformers==3.0.2. I will make an update to the requirements.txt. Thanks for pointing out!

Thank you very much!


removed self as a dependency if it s found

Fixing #179
cc @ricfio

Codecov Report

Merging #197 (437492b) into main (1981d28) will decrease coverage by 0.35%.
The diff coverage is 75.00%.

@@             Coverage Diff              @@
##               main     #197      +/-   ##
============================================
- Coverage     92.94%   92.59%   -0.36%
- Complexity      280      283       +3
============================================
  Files            50       50
  Lines           709      716       +7
============================================
+ Hits            659      663       +4
- Misses           50       53       +3

Impacted Files
Coverage Δ

src/Analyzer/FileVisitor.php
86.95% <75.00%> (-5.36%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1981d28...437492b. Read the comment docs.

Could there be the same bug when using the static keyword instead of the self keyword?

A bigger problem might be that the static keyword (as well as parent) should be interpreted before to detect its namespace, unlike self wich always indicates the same class within which you use self.

I removed static also @ricfio .
I think that parent could be a different context and not part of this PR :)

Ok but could  parent or also static refer to a base class outside the namespace in the rule?
I think not, because in this case you already have in your code an import (use ..) with an outside namespace for the base class.

I am trying with some code and we can avoid to add parent as your suggestions @ricfio


shared_connection_block should unblock in its destructor

Boost:

A shared_connection_block releases its block when it is destroyed or its unblock method is called.

The following simple test case fails:
callbackCalled = false;
event(value);
CHECK(callbackCalled);

{
    callbackCalled = false;
    shared_connection_block block(conn);
    event(value);
    CHECK(!callbackCalled);
}

callbackCalled = false;
event(value);
CHECK(callbackCalled); // <-- fails here because the connection is still blocked

shared_connection_block doesn't have a destructor to unblock its connection, and none of the existing test cases cover this simple scenario.
In this PR I simply add unblock() to the destructor.

Merged, thanks!


Polymorphic Preload doesn't respect OwnerType

Hey jinzhu :)
Somehow Preload() doesn't respect the *Type field when the association is polymorphic, here's a gist to show what I mean: gist (You need to uncomment the create()-call on first run.)
Preload results in:
SELECT * FROM "countdowns"  WHERE ("owner_id" IN ('1')) ORDER BY "countdowns"."id" ASC

Adding .Model() doesn't change that unfortunately.

Created a pull request, but I'm not sure if that's the right way to tackle this.


Fix renaming userprofile to account

There are still few places with userprofile naming after merging #1757. This PR fixes it by renaming to account. It also removes unused account/password_set.html template.

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@221b101). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #1765   +/-   ##
=========================================
  Coverage          ?   83.17%
=========================================
  Files             ?      140
  Lines             ?     6110
  Branches          ?      660
=========================================
  Hits              ?     5082
  Misses            ?      858
  Partials          ?      170

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 221b101...ede8467. Read the comment docs.


Rhythm

Add a behavioral rhythm:

Bin to small interval
aggregate a large interval (reduce time frame)
calculate distribution over medium interval

Update demos with rhythm functions

Added a very simple documentation example. We need to example analysis documentation in general, but maybe wait for more functionality first.


EPMLABSBRN-63 create Unique KEY StudyHistory (userId and exerciseId) and update record

EPMLABSBRN-63  Create Unique KEY StudyHistory (userId and exerciseId) and update record
CONTENTS:

Configured mapstruct processor, KAPT for code generation and idea plugin. Necessary for MapStruct to work.
Added PATCH and PUT. Added PUT capabilitites to POST when record exists as requested.
Created constraints.

EDIT

Reorganized and completed README file

Ready for review.

Fixed merge conflictsd

great work!

Thanks!

MapStruct creates some constraints in data objects, but i think the benefits in development speed and ease are worth it. Else we need to either map manually or find another solution.
@goopnigoop Any thoughts on this?

I've used this one in java project and it's more preferable than boilerplate code. I like to see it here, I think if we faced some problems or restrictions we can rollback to simple kotlin solution

Finished requested changes, please review when possible


Need to document securing host endpoints in k8s environment

When using host endpoints for filtering traffic in a k8s environment, the host endpoint policy is applied to forwarded traffic also which will block some nodePort traffic.  We should have some additional documentation mentioning this specifically in the k8s documentation.

If you add an “allow to ” ingress rule to your host endpoints then that will allow all nodePort traffic to get forwarded.  (The only time such a packet hits the ACLs is if kube-proxy as DNATed it to a pod on a remote node.)

^ per lxpollitt in slack
Context
If slack history hasn't elapsed see https://calicousers.slack.com/archives/C0BCA117T/p1498500538031463
dirbaio [12:49 PM] ￼
yes, ingress on the pod is allowed from anywhere

[12:49] ￼
that's why it works when I talk to node A

[12:49] ￼
talking to node B doesn't work, node B drops the packets

[12:50] ￼
I think the issue is due to what's there in the FORWARD table

[12:50] ￼
the packet is this:

[12:50] ￼
[8234457.532499] calico-packet: IN=ens4 OUT=tunl0 MAC=42:01:0a:84:00:08:42:01:0a:84:00:01:08:00 SRC=<IP_ADDRESS> DST=<IP_ADDRESS> LEN=60 TOS=0x00 PREC=0x00 TTL=63 ID=9260 DF PROTO=TCP SPT=44260 DPT=5432 WINDOW=28400 RES=0x00 SYN URGP=0 MARK=0x4000

[12:50] ￼
the packet is not matching the -i cali+ and -o cali+ rules (edited)

[12:51] ￼
so it goes to cali-from-host-endpoint and cali-to-host-endpoint

[12:52] ￼
and I have a catch-all deny all in the host endpoint policies

[12:52] ￼
but this packet is not going to this host

matt_dupre [12:53 PM] ￼
Host endpoints policies also apply to traffic being NATed

dirbaio [12:53 PM] ￼
it's forwarded somewhere else :confused:

[12:53] ￼
shouldn't host endpoint only apply to packets actually trying to access a port in the host?

[12:55] ￼
IMO allowing all ingress to a pod, and making it a nodePort service should "just work"

lxpollitt [12:57 PM] ￼
So the traffic you are testing is originating off host, right?  So it’s coming in via the host endpoint interface, and targeting the node port?

dirbaio [12:58 PM] ￼
yes

lxpollitt [12:58 PM] ￼
OK, I think I grok the issue.

dirbaio [1:01 PM] ￼
you're right that the docs do say that forwarded traffic between interfaces does go through the host endpoint policies..

[1:01] ￼
http://docs.projectcalico.org/v2.3/getting-started/bare-metal/bare-metal

[1:01] ￼
but it's a bit strange :confused:

[1:01] ￼
maybe calico could make an exception for tunl0, the ipip tunnel

[1:01] ￼
but it'd still break nodePorts when not running with ipip

[1:02] ￼
it's strange that if the destination pod is in this node, it gets passed, but if it's not, it doesn't

[1:03] ￼
in my mind the "host endpoint policies" were like a firewall for the host itself

lxpollitt [1:04 PM] ￼
Give me a few minutes and I will suggest some cool policy for you.

[1:08] ￼
If you add an “allow to <podCIDR>” ingress rule to your host endpoints then that will allow all nodePort traffic to get forwarded.  (The only time such a packet hits the ACLs is if kube-proxy as DNATed it to a pod on a remote node.)

[1:09] ￼
Obviously substituting <podCIDR> for the actual CIDR you are using for your pods.

dirbaio [1:09 PM] ￼
yeah, that would work..

[1:09] ￼
will try now, thanks :smile:

[1:09] ￼
it's very counterintuitive though

[1:10] ￼
why merge the forward and input policies?

lxpollitt [1:10 PM] ￼
Yes, this area of policy is tough to get your head around and none obvious.

dirbaio [1:10 PM] ￼
host endpoints should just be in iptables INPUT and OUTPUT

[1:10] ￼
and if you want to allow securing FORWARD maybe there should be a new kind of policies

lxpollitt [1:11 PM] ￼
We are going to add a new kind of policy that is effectively “pre-NAT”.  That would allow you to specify host endpoint rules that open up only specific node ports for example.

[1:15] ￼
The current behavior of skipping host endpoint policy if the traffic is being forwarded to a local pod was designed that way so that you don’t have to update host endpoint policy every time you add/remove a pod or change pod policy on that host.  It makes perfect sense for pod-to-pod traffic.  But it is non-obvious when considering node ports and kube-proxy interactions, where as you have spotted, if kube-proxy NATs to a local pod then the result is skipping the host endpoint policy, but if kube-proxy NATs to a remote pod then it does not skip the host endpoint policy.

https://docs.projectcalico.org/v3.10/security/protect-hosts
https://docs.projectcalico.org/v3.10/security/host-forwarded-traffic
I believe we have how-to content on this now.


Add HTTPS support

Offer the possibility to start Whales Manager server using HTTPS

By default, Whales Manager must start in HTTP only mode
The HTTPS must be a configurable option in the server config file
Update the Wiki accordingly

Done in commit feat (backend): add https running mode (bc04107)


[REQUEST] Backport to 1.19.4

some things still havent updated to 1.20, most of the people still uses 1.19.4 nowadays, i was hoping we could have it xD

the 1.19.3 version should work on 1.19.4.  I'll mark it on CurseForge.  I didn't really have to change anything for 1.20.1, so it should all be backwards and forwards compatible so far


Figures in PuTTY do not display correctly at all

I have two machines running Ubuntu with the same fonts/colors. One is Vagrant VM which I SSH into with PuTTY and the other is a regular laptop running the OS. When trying to use these figures within PuTTY they are either partially cut off or they are not displayed at all. Some fonts display them better than others but I am using Inconsolata for Powerline.
The laptop works great.
I don't really expect this to be fixed as it is a fringe case but was more or less wondering if someone was able to tweak some settings (in PuTTY, Ubuntu, etc) to get these to work?

https://www.google.com/search?q=putty+unicode

I have unicode characters working. Some of them just look like complete crap.

@adam-beck in the unlikely event that you still care about this, after all of this time, I was able to get characters to display correctly by switching to the "DejaVu Sans Mono" font, as suggested on SuperUser:

https://superuser.com/questions/393834/how-to-configure-putty-to-display-these-characters

I've only tested a limited subset of the characters, but the main takeaway, for me, was the fact that its definitely a PuTTY issue and it's highly influenced by the font that you choose.
Hope this helps someone...


Added All Priority Queue Operations using Array and Linked List

Description

I have Added All Priority Queue Operations like Enqueue, Dequeue, Display using Array and Linked List Implementation in a single Code.
LGM-SOC'21

Fixes #1286
Type of change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update
[ ] Documentation Update

Checklist:

[ ] My code follows the style guidelines(Clean Code) of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have created a helpful and easy to understand README.md
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests/screenshots(if any) that prove my fix is effective or that my feature works

@Saurabh4626 Please Review the PR and Merge it.
LGM-SOC'21
Thank You


add text styling changes

This isn't pretty, but makes it possible to set/override the text color using a new "survey_text" color value.

Hello. Did you have time to check the reviews and fix them so that we can merge?

Thanks all. Haven't had time, but appreciate this being resolved!

Thank you for your PR! I was a necessary and important change and I'm really happy that you took your time and effort to work on it!
I'll try to find a time this week to release a new version👍🏻


DocumentGenerator generate has side effects on SW-Context

PHP Version
7.4
Shopware Version
<IP_ADDRESS>
Expected behaviour
The SW-Context should be untouched. And if you use the TranslatorService it should still be work.
Actual behaviour
The SW-Context is corrupted, so the languageIdChain gets overwritten and it holds two Languages the SystemLanguage (new) and the shop language.
This leads to the problem, that the TranslatorService only returns technical snippet names.
How to reproduce

$this->translator->trans('Acme.key'); // works

// Render a invoice document
/** @var DocumentGenerator $documentService */
$pdfDocumentData = $this->documentService->generate(InvoiceRenderer::TYPE, $operations, $context)->getSuccess()->first();

$this->translator->trans('Acme.key'); // just returns technical name

I think this line of code should be changed somehow:
// Shopware\Core\Checkout\Document\Renderer\InvoiceRenderer
public function render(array $operations, Context $context, DocumentRendererConfig $rendererConfig): RendererResult
{
// ...
// The Context has now side effects
$context = $context->assign([
    'languageIdChain' => array_unique(array_filter([$languageId, $context->getLanguageId()])),
]);
// ...
}

Hi,
thx for your issue we will put it into our new evaluation process and have a look at it again.

[public] Automated response: This issue is linked to the internal issue https://shopware.atlassian.net/browse/NEXT-37924.
[created from NEXT-37924, comment 488838]


[BUG] Service Fabric Management SDK deserialization exception when listing applications

Describe the bug
Added Microsoft.Azure.Management.ServiceFabric (v1.1.0) package to a .csproj, tried to ListApplications for a cluster and received a deserialization exception. Seems to be that that the client is trying to hit the Service Fabric resource provider with api-version=2018-02-01, but getting a response where the upgradeReplicaSetCheckTimeout is a string.
Exception or Stack Trace
Exception message:
{"Error converting value \"00:20:00\" to type 'System.Nullable`1[System.Int64]'. Path 'properties.upgradePolicy.upgradeReplicaSetCheckTimeout', line 32, position 53."}
Stack Trace:
at Microsoft.Azure.Management.ServiceFabric.ApplicationsOperations.ListWithHttpMessagesAsync(String resourceGroupName, String clusterName, Dictionary`2 customHeaders, CancellationToken cancellationToken)
at Microsoft.Azure.Management.ServiceFabric.ApplicationsOperationsExtensions.ListAsync(IApplicationsOperations operations, String resourceGroupName, String clusterName, CancellationToken cancellationToken)

To Reproduce
Steps to reproduce the behavior:
Try retrieving applications on a Service Fabric cluster using the Microsoft.Azure.Management.ServiceFabric ( version 1.1.0 ) NuGet package.
Code Snippet
var armToken = await tokenProvider.GetAccessTokenAsync(Constants.AzureResourceManagementUrl);
serviceFabricManagementClient = new ServiceFabricManagementClient(new TokenCredentials(armToken))
{
    SubscriptionId = options.Value.SubscriptionId.ToString(),
};
var applications = await serviceFabricManagementClient.Applications.ListAsync("myResourceGroupName", "myCluster", cancellationToken);

Expected behavior
The list of Service Fabric Applications running on the Service Fabric cluster is returned.
Screenshots

Setup (please complete the following information):

OS: Windows
IDE : Visual Studio 2019
Version of the Library used : 1.1.0

Information Checklist
Kindly make sure that you have added all the following information above and checkoff the required fields otherwise we will treat the issuer as an incomplete report

[ x] Bug Description Added
[ x] Repro Steps Added
[ x] Setup information Added

CC: @shahabhijeet

Duplicate of #4510. Thanks for reporting. We have made the fix for version 2019-03-01. We will publish the sdk with this new version shortly.


build(deps): use Angular v16 compatible zone.js

0.13.x
It was incorrectly upgraded

#274  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @davidlj95 and the rest of your teammates on  Graphite


service_template fmt::join build error on MacOS

I followed the tutorial but got compilation error, see https://stackoverflow.com/questions/78935510/no-member-named-join-in-namespace-fmt#comment139204286_78935510

I have the same issue after updating toolchain to 15 version:
./cmake-build-release/_deps/userver-src/universal/include/userver/utils/traceful_exception.hpp:52:25: error: no member named 'back_inserter' in namespace 'std'
   52 |     fmt::format_to(std::back_inserter(ex.GetMessageBuffer()), "{}", data);

if you fix it manually, then:
cmake-build-release/_deps/userver-src/universal/include/userver/utils/checked_pointer.hpp:52:5: error: no member named 'abort' in namespace 'std'; did you mean simply 'abort'?
   52 |     std::abort();

And etc.

Adding missing #include <fmt/ranges.h> in ~10 files helped in my case.


⚠ Bofrost.be has degraded performance

In 2c0d174, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 993 ms

Resolved: Bofrost.be performance has improved in 33c1c6c after 6 minutes.


luaPackages.lz-n: init ad 1.2.2-1

Description of changes
cc @teto
I've added it as a vimPlugin too, but the vim plugin updater script seems to be broken, so I had to add it manually.

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 320322 run on x86_64-linux 1

6 packages built:

lua51Packages.lz-n
lua52Packages.lz-n
lua53Packages.lz-n
lua54Packages.lz-n
luajitPackages.lz-n
vimPlugins.lz-n


Multi root: Adopt and Improve Settings editor for Multi root workspaces

Multi root: Adopt and Improve Settings editor for Multi root workspaces

Please note that e6770cc broke the user settings editing when EditorConfig extension is installed.
See #31246

In Multi-root workspaces, workspace settings come from the workspace config file which has other configurations like id, folders.  Eg:
{
	"id": "1499978571481",
	"folders": [
		"file:///.../vscode",
		"file:///.../vscode-docs"
	],
	"settings":{
	    "editor.insertSpaces": false,
	    "files.eol": "\n",
       }
}

Hence, Settings editor needed a virtual editor for displaying only settings section of the config file for Workspace Settings. This should also support editing just like in other editors.

To get consistent experience in Settings Editor across, while editing settings in virtual editor (Workspace Settings), content is written directly into the real configuration file on disk. This needs #23413 Auto saving of settings for consistent experience.

Reverted virtual editor support in favour of #31246


Specify Marathon URL either via Master state or ZK connection string to support HA mode

We're running Marathon in HA mode, meaning that we have 3 Marathon instances which are "clustered" via ZooKeeper.
So, for us it wouldn't necessarily make sense to use a static Marathon URL as it seems to be implemented now. If the exact instance would go down (for whatever reason), we could not make use of the HA feature of Marathon IMHO, and nixy would be in an inoperable state (if I understand correctly).
Possible solutions for (additionally) be able to use HA:

Derive the actual webui_url of the Marathon framework via the Mesos Master's /state endpoint (I guess first you'd have to get the actual Master address via the ZK connection string of Mesos), or
Use a ZK client to receive the leadership changes (not sure how this needs to be implemented though)

References:

https://mesosphere.github.io/marathon/docs/high-availability.html

Thanks for the feedback and its a valid point you have there. Personally we dont have this problem since we run all our marathon nodes from our HA cluster behind an external Load Balancer. But I will in either case try to attend this issue.
I have on purpose tried to avoid adding a ZK client since it adds a lot to the complexity and Marathons REST API has everything that is needed. And to query Mesos could potentially add the same issue if that particular node is down.
An alternative solution would be to add a list of marathon endpoints, if one fails nixy would just retry with the next one in the list, and so on. Just have to see how to implement this the best way, but an idea would be a background health probe that checks all instances periodically.

Feature is now added in new release, went with adding a background endpoint probe.
Please make an issue if there is anything else :smile:
https://github.com/martensson/nixy/releases/tag/v0.4.0

Great 😀 That was fast!


implement default sort

Context
Previously we did not specify any default sort, so it defaulted to an order based on the order of entries in the RSF.
Changes proposed in this pull request
If name field exists sort by name else sort by primary key.
Guidance to review
Load a register with and without name field and observe sort order.

Going to merge this now, but we should re-visit with @conordelahunty if we want to set the sorting params so that the sorting arrow shows by default.


use dict.setdefault

rewite this construction
if key not in counts:
  counts[key] = <<initial value>>

with
counts.setdefault(key, <<initial value>>)

for example in
https://github.com/TaiSakuma/AlphaTwirl/blob/v0.9.x/AlphaTwirl/Summary/Count.py#L16-L17
It will run faster because it searches for key once instead of twice

Implemented in the commit https://github.com/TaiSakuma/AlphaTwirl/commit/fecb08042bd8


Add tests for Commands from CLI

The test cases now covers existing Tasks but do not cover adequately all the parameters supplied via CLI.

Superseded by #105


[next] merge changes from main

[!IMPORTANT]
This PR needs to be merged by a maintainer as we need to merge it non-squashed. Otherwise we'll have to do the same work again.

Updates next with the latest changes from main, all changes here are pre-reviewed already

This probably should be updated to pull in 8ab52d547990692e2f7a4dc5242ec61a3e42971e, currently any PR targeting next will fail without it. #5280 would be nice to have as well if it makes it in time for the release.

This probably should be updated to pull in 8ab52d5, currently any PR targeting next will fail without it. #5280 would be nice to have as well if it makes it in time for the release.

Done 🙂


Comment erroneously says output instead of input for the input_node_names.

Can one of the admins verify this patch?

I signed it!


Properly Parsing a Form

I'm having trouble parsing a form.
Here Is the handler:
post[
    path("/api/contact")[
      formBody(proc(form: StringTableRef): auto =
        echo form
        ok("Form")
      )
    ]
  ]

Here is the output from echo form:
{------WebKitFormBoundaryb2NDKUkTY9ZiqSk9
Content-Disposition: form-data; name: "customerName"

User Name
------WebKitFormBoundaryb2NDKUkTY9ZiqSk9
Content-Disposition: form-data; name="customerEmail"

<EMAIL_ADDRESS>------WebKitFormBoundaryb2NDKUkTY9ZiqSk9
Content-Disposition: form-data; name="customerPhone"

3458769089
------WebKitFormBoundaryb2NDKUkTY9ZiqSk9
Content-Disposition: form-data; name="customerMessage"

Test Message
------WebKitFormBoundaryb2NDKUkTY9ZiqSk9--
}

When I try to access a value using form["customerName"] similar to tests/server.nim it fails and the server returns a 404.
Any help is very much appreciated.

It looks like a mulitpart form and not a url-encoded form, you can use multipart for that


Ioplacer places pins on "chip boundary"

Hello,
Since this commit https://github.com/The-OpenROAD-Project/ioPlacer/commit/d9f75b6c1d2f60f173b82ad4dd0cd32f56f9b07d, ioPlacer started calculating the boundaries using "chip bbox". So I tried running ioPlacer after cell placement and it seems that it can overlap with power rails. Previously, the design had a margin surrounding the core and pins were placed at the die boundary.
Attached is an image of a pin overlapping with the power rail:

Update: I think this was fixed here https://github.com/The-OpenROAD-Project/ioPlacer/commit/819289d6a47f900f4bb0e95cd625b4714be6c0a3


Questions about AmazonCognitoYourUserPoolsDemo

Hi,
Are you going to add token handling to AmazonCognitoYourUserPoolsDemo so it can be easily integrated to Mobile Hub based app (using IdentityManager and SignInManager classes)?
Another related question: Is Mobile Hub app generator going to include Your User Pools in the future?
Any estimates of schedules? :)
BR,
Jukka

Unfortunately the Mobile Hub sample app, and those in this repo and distinct and aren't built to use with each other.
And as to the related question, we typically do not release information about unreleased features. That being said, we do think User Pools would be a great addition to Hub, and I will keep this issue open as a feature request.

The User Pools feature has now been added to the AWS Mobile Hub sign in provider options. You can configure User Pools by selecting "Email & Password" as an option on the sign-in feature. And, you will get the appropriate demo functionality in the sample app and minimal SDK downloads from the Mobile Hub "Integrate" page.


Bug: Bulk update changes date-modified for random files even if there was no linting done in them

[x] I have verified that I am on the latest version of the Linter

Describe the Bug
When doing bulk linting on a vault of 1000+ notes, random files will have date-modified updated but no other changes.
How to Reproduce
Steps to reproduce the behavior:

Do linting on the big folder or whole vault

Expected Behavior
If date-modified exists and no other linting changes where done then do not update date-modified. (already happening for some files but not others)
Screenshots

Device

[x] Desktop
[x] Mobile

Hey @jvdevlab . I will need more information in order to be able to do anything about this. Are you able to reproduce this consistently with the bulk update? If so, could you verify that the data modified in the file system is within 5 seconds of the date modified in the frontmatter? If so, then there likely is a bug, but if not, it is going to be very hard to track down this issue.
Also, I would like to rule out syncing across multiple devices being the problem. You are not syncing these files from one device to another are you? If so, the Linter has no way to know where a change comes from except when it makes a change itself. So it is not really feasible to just update date modified when the Linter updates the file (the file system is considered to be the source of truth according to the Linter).
Thanks for helping me better understand what is going on in your case!

@pjkaufman

Are you able to reproduce this consistently with the bulk update?

Yes.
I take the vault with 1000+ notes that was already linted according to the enabled rules.
I lint the whole vault again (without changing anything) I get 178 changes. I commit to git.
Repeat. I get 170 changes. Commit
Repeat. I get 133 changes. Commit
...
117
I can repeat it and see if it goes down to 0
You can see how with each run I get less and less files. Each next run is a subset of files from previous run. At first I though maybe these files formatted weirdly or there is something special about them. I compared them to "normal" files (for which date-modified is not changing as expected) but I do not see difference. I used diff to show special chars and whatnot but nothing stands out.
I have another vault with all the same plugins, settings, rules etc. except it has 200 notes and it is not happening there.

If so, could you verify that the data modified in the file system is within 5 seconds of the date modified in the frontmatter?

I checked bunch of offending files.
They all  shows modified on Saturday, January 27, 2024, 9:50:33 AM in Windows File Explored
In Frontmatter these files range from: 2024.01.27 09:50:20 to 2024.01.27 09:50:27

Also, I would like to rule out syncing across multiple devices being the problem. You are not syncing these files from one device to another are you?

I'm using Obsidian Sync.
I suspected it as well but I think it is safe to rule out. The above runs that I did (where number of changed files keep decreasing) were done during the time when the other devices were offline. So unless there is an issues with single device and Sync we should be good here.

Interesting. Is it affecting a subset of the same files? If so, does the same happen if you try linting 10 or so of them at random from the list of previously updated files on mass lint? Make sure that when you do a single file lint you change the log level for the debug tab to trace and enable capturing logs when running the linter on save. You can then post the Linter's logs here which should be able to help identify the issue.
I am guessing based on what you are listing as the date modified time is that the larger the amount of files are that get linted, the farther out of sync the date modified file metadata and the file frontmatter get.
I am definitely open to ideas on how to fix this if we can confirm that is the case. However, I am not 100% sure that is the case. Nor do I have a test setup large enough to test this scenario since it sounds like I need to lint more than a couple hundred files for this to happen.
Sorry that this is getting long. I do want to make sure that you are not using custom commands as a part of the way you use the Linter if you are using it in conjunction with the date modified logic since the Linter is unable to account for modifications made by custom commands which could be causing the date modified update to happen since custom commands could modify the file more than 5 seconds from when the Linter sets the date modified (that is not really fixable at this time).
Thanks for the info so far.

Is it affecting a subset of the same files?

Yes, the next run even so smaller contains files from previous runs. I didn't compare every single file but it is very much look that way.

If so, does the same happen if you try linting 10 or so of them at random from the list of previously updated files on mass lint?

When I open them one by one and do not change anything and hit ctrl+s it is linting them. Says 4 chars added and 4 removed. (minutes and seconds)

Make sure that when you do a single file lint you change the log level for the debug tab to trace and enable capturing logs when running the linter on save. You can then post the Linter's logs here which should be able to help identify the issue.

See attached file.
log.txt

I am definitely open to ideas on how to fix this if we can confirm that is the case.

I didn't look at your code. But if you tracking all the changes before committing the save can you have a postprocessing routine that would check: If the only linting change is date-modified and date-modified already exist with a value then do not commit changes.

I do want to make sure that you are not using custom commands as a part of the way you use the Linter

I do not
Thank you for the plugin and your help in troubleshooting the issue.

Interesting. This is not something I am seeing anything in the logs that would indicate what is going on. I am thinking that I need the logs with a modified version of the plugin to make it include information about why it is updating the values.

Could you reproduce the issue again while using the main.js from the following zip file and grab the debug logs for the file?
main.zip
To install the main.js:

Unzip the zip file
Copy the main.js from the output to path_to_vault/.obsidian/plugins/obsidian-linter/
Then either start Obsidian or turn off and back on again the Linter plugin

Thanks for helping better understand what is going on in this situation.

Hey. Just wanted to check back in and see if there was any update on whether or not there will be an attempt to reproduce the issue with the custom plugin logic to help better understand the problem. It has more logging info that should clarify why the logic thinks an update needs to happen. If you do not plan on reproducing the issue with the custom logic, that is fine, it just leaves the actual cause of the problem here as a bit of a mystery.
Thanks!

@pjkaufman Sorry it was on my todo all week. And I didn't get to it. I will do today.

@pjkaufman,
Here are the results.
First time I ran the linting on the whole vault it modified date for 544 files. Second time -- 445.
Then I cherry picked a file.
date-created: 2024.01.29 16:34:04
date-modified: 2024.02.11 10:13:08 (this was actually from linting the whole vault)
After manually linted it
date-modified: 2024.02.11 10:27:06
Here I are the relevant part from the log.

Running YAML Timestamp
Key found
Text modified already? false
modified date time from frontmatter is undefined? false
modified date time is valid? true
current modified date metadata: 2024.02.11 10:13:24
frontmatter modified date: 2024.02.11 10:13:08
time difference between now file modified at time and frontmatter value? 16
yaml-timestamp: 0.5 ms
And then it sets it to date-modified: 2024.02.11 10:27:06
Here is the full log.
obsidian-linter.txt

@pjkaufman can you please expose it as advanced setting? It could have 5 sec default (as you mentioned above) and whoever runs into the issue can set a higher number.

I am not sure if it will get exposed as a setting. It is a bit tricky since some users will go ahead and bork things by changing it. I will have to think about this and see if it is something that makes sense to do. I would much rather address the root cause of the issue without making a settings change. But that will be difficult given the size of the data set needed to test this scenario.

Hi @pjkaufman,
There are number of large vaults online that can be downloaded. Quick search gave me this one with 1300 notes. There probably bigger ones.
Can you point me to the constant value in the code? (hopefully it's in one place) I can change it locally. And keep changing every time I take a plugin update. I don't know if the Obsidian plugins allow you to externalize constants on the code level. In a way that you can update the plugin but constant will remain the same. This way it will be truly advanced settings as it will not be exposed in the UI.

The constant in the code is located here. It is not really a constant. It just is used in place since it is only needed there to represent 5 seconds.


Notebook Kernel can not be identified by id

Testing #103883
Is it possible to have the currently active, preferred kernel also show up as the first one or the highlighted one in the quick pick?

When I change the kernel provider to a placeholder one from my sample extension, it doesn't seem to get highlighted in the quick pick:

Here's the code I added in extension.ts in the sample renderer:
export class TestKernel implements vscode.NotebookKernel {

  constructor(public label: string) {}
  executeCell = () => {};
  cancelCellExecution = () => {};
  executeAllCells = () => {};
  cancelAllCellsExecution = () => {};

}
export class KernelProvider implements vscode.NotebookKernelProvider<TestKernel> {
  provideKernels() {
    const provider1 = new TestKernel('provider1');
    const provider2 = new TestKernel('provider2');

    return Promise.resolve([provider1, provider2]);
  }
}
// This method is called when your extension is activated
// your extension is activated the very first time the command is executed
export function activate(context: vscode.ExtensionContext) {

  context.subscriptions.push(
    vscode.notebook.registerNotebookContentProvider(
      'test-notebook-renderer', new TestProvider()
    ),
  );

  const provider = new KernelProvider();
  vscode.notebook.registerNotebookKernelProvider({ filenamePattern: '**/*' }, provider);

}

When users click the kernel status bar item, we will fetch the latest kernels from kernel provider again, and in the snippet @RMacfarlane posted above
export class KernelProvider implements vscode.NotebookKernelProvider<TestKernel> {
  provideKernels() {
    const provider1 = new TestKernel('provider1');
    const provider2 = new TestKernel('provider2');

    return Promise.resolve([provider1, provider2]);
  }
}

Every time the kernel provider returns two new objects with the same labels but since we only use object identifiers to check if the kernels are identical or not, none of the kernels listed in the quick is selected as they are different from the active kernel.
For example, if we always return same kernels in providerKernels, you can see the kernel is selected as expected.
export class KernelProvider implements vscode.NotebookKernelProvider<TestKernel> {
	provider1 = new TestKernel('provider1');
	provider2 = new TestKernel('provider2');
	provideKernels() {

		return Promise.resolve([this.provider1, this.provider2]);
	}
}

Removing bug label for now. We may want to enforce the kernel provider to provider id.

This has happened. The new NotebookController API enforces the use of unique identifiers


Clear-Text Credential

We noticed that our CSPM tool detects as a cleartext key in a text file. Is it possible to keep the secret in Secret Manager instead?

if it works with aws-cli, it should work with goofys as well. additionally you can also use IAM roles


Add Customizer Option for Topbar or Offcanvas Mobile Menu

This pull request allows the user to select the type of mobile menu
they want - Topbar or Offcanvas - in the theme customizer.
header.php
Selectively output the code needed for an off-canvas menu. If the
customizer setting is offcanvas, that code will be output. I also fixed
what appears to be a bug introduced in the last merge. The
$GLOBALS['offcanvasposition'] was not being echoed when called in the
template.
footer.php
Selectively output the code needed for an off-canvas menu.
library/custom-nav.php
A new file creating the customizer options. also added a filter to add
“offcanvas” or “topbar” classes to the body tag to help with CSS
styles.
functions.php
calling custom-nav.php
parts/top-bar.php
added in the needed  for the mobile hamburger menu
scss/site/_topbar.scss
hiding .top-bar at breakpoint only if menu option is set offcanvas

Good stuff. Seems like a few build checks have failed, though. Could you have a look at it?

Thanks, Ole. I will have a look at how to run the tests on my end to make sure I get everything fixed.

Ole, the tests are passing now. I wasn't 100% sure about changing the the status badge to point to my repo, so if there is something else I need to do on that end, let me know.

:+1:  awesome!

As of now the off canvas position is to be set multiple places. It kind of works, but the current solution is still not ideal. On a general basis I mean it's bad practice to put settings like this in template files (such as the header or the off-canvas-menu template). It would be quite cool if we could expose the 'left' or 'right' setting for off canvas position in the theme customizer menu, instead of hard coding the off canvas position as a global variable in various php files. Any thoughts about this, @AdamChlan ?

I was thinking the same this. I can integrate that functionality into the customizer panel.


[improve][cli] PIP-353: Improve transaction message visibility for peek-message

Motivation
#22746
Modifications

Support --show-server-marker and --transaction-isolation-level flags for peek-messages cmd.

Verifying this change

Add testPeekMessageForSkipTxnMarker, testPeekMessageForSkipAbortedAndUnCommittedMessages and testPeekMessageForShowAllMessages unit test to corver this change.

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

[ ] Dependencies (add or upgrade a dependency)
[ ] The public API
[ ] The schema
[ ] The default values of configurations
[ ] The threading model
[ ] The binary protocol
[ ] The REST endpoints
[x] The admin CLI options
[ ] The metrics
[ ] Anything that affects deployment

Documentation

[ ] doc
[ ] doc-required
[x] doc-not-needed
[ ] doc-complete

Matching PR in forked repository
PR in forked repository: https://github.com/shibd/pulsar/pull/34

Codecov Report
Attention: Patch coverage is 85.18519% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 73.18%. Comparing base (bbc6224) to head (de5dd2e).
Report is 298 commits behind head on master.

Additional details and impacted files

@@             Coverage Diff              @@
##             master   #22762      +/-   ##
============================================
- Coverage     73.57%   73.18%   -0.39%
- Complexity    32624    32900     +276
============================================
  Files          1877     1889      +12
  Lines        139502   141480    +1978
  Branches      15299    15528     +229
============================================
+ Hits         102638   103548     +910
- Misses        28908    29946    +1038
- Partials       7956     7986      +30

Flag
Coverage Δ

inttests
27.38% <0.00%> (+2.79%)
:arrow_up:

systests
24.57% <0.00%> (+0.25%)
:arrow_up:

unittests
72.21% <85.18%> (-0.64%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files
Coverage Δ

...in/java/org/apache/pulsar/client/admin/Topics.java
77.50% <ø> (ø)

...pulsar/broker/admin/impl/PersistentTopicsBase.java
69.52% <94.44%> (+4.06%)
:arrow_up:

...in/java/org/apache/pulsar/admin/cli/CmdTopics.java
80.00% <57.14%> (-1.18%)
:arrow_down:

...pache/pulsar/client/admin/internal/TopicsImpl.java
83.18% <86.20%> (+1.17%)
:arrow_up:

... and 353 files with indirect coverage changes

I will cherry-pick this to branch-3.0 and branch-3.3, Although it introduces a new configuration(--transaction-isolation-level and --show-server-marker) on admin CLI, it fixes the incorrect behavior by default when this configuration is not used.


Create a reference guide

Create a reference guide containing a page for each rule, that we could use as a link in the rule.

Generate with a script new reference pages (only if they don't already exist).
Each new page displays the name of the rule as a title, the message of the rule as main content, and the content of the rule file in a source block. Manual authoring necessary to complete the information.
Generate the navigation from the pages list.
Generate an overview with some helpers to navigate the pages.

Review the Reference guide pages to make them meaningful:

When applicable, copy over the word usage description from https://redhat-documentation.github.io/supplementary-style-guide/
When necessary, complete the usage description using the rule source file.

Fixed by #156, #161, #162 and #164


[BUG] Invalid response after enabling SSL

First of all, thank you for this wonderful plugin! I was hoping you could help me with the following problem:
After I enabled SSL, I suddenly receive the following error:
This site can’t be reached
The webpage at https://www.mywebsite.com/admin/page/system/export/visitors might be temporarily down or it may have moved permanently to a new web address.
ERR_INVALID_RESPONSE
It's odd, because the error doesn't occur on my local environment, and didn't occur before I switched over to SSL. Might there be something which I am missing?
`        Excel::create('export', function($excel) use ($name, $data) {
        $excel->sheet($name, function($sheet) use ($data) {
            $sheet->fromArray($data);
        });

    })->download('xlsx');`

I managed to temporary resolve this situation by downloading the file as xls instead of xlsx.
Chrome does indicate the following in this situation:
Resource interpreted as Document but transferred with MIME type application/vnd.ms-excel: "https://www.mywebsite.com/admin/page/system/export/visitors".

Same issue for me but without even the SSL requirement.  xlsx works fine in my windows environment but does not work in my linux environment.

Turns out you need to have the zip php extension installed and enabled.  XLSX has some compression on it.  Got that running in my linux environment and xlsx is working now.

I had to change the time limit and memory limit before executing create().
set_time_limit(0);
ini_set('memory_limit', '1G');

I faced similar issue. @ckc11 answer solve my problem


Updating the readme

Update supported browser
Add docs link
Add a screenshot

Feel free to modify as needed.


JuliaPDE?

Interested in getting this repo included? A PR or an issue would be welcome...

https://discourse.julialang.org/t/psa-thread-local-state-is-no-longer-recommended-common-misconceptions-about-threadid-and-nthreads/101274/9

Thanks, @PetrKryslUCSD, for pointing out this very useful repo! I gladly accept your offer and already made a PR.
https://github.com/JuliaPDE/SurveyofPDEPackages/pull/41.


Add audio dependency to tests

Adds the audio dependency for tests as it is now required to download audio datasets.

Might need sudo?

The Linux and macOS virtual machines both run using passwordless sudo. When you need to execute commands or install tools that require more privileges than the current user, you can use sudo without needing to provide a password.

Still a failure related to the audio test of the inference API cc @osanseviero
Will take a look at it this afternoon

From the error you should add soundfile to the testing dependencies our add soundfile to datasets audio installation https://github.com/huggingface/datasets/blob/master/setup.py#L104.

Thanks for this PR!


Store tree in Packr

Take the address tree and store it alongside the code with packr. Also implement a bash script that automatically updates the packr shtuff.

https://github.com/lavalamp-/ipv666/pull/111/commits/c2dadf8cfa01047835d2d5dc9e3b940b78abf936


v0.17 renders using Plotly v4 default templates

Issue #212 is one example of subtle differences that crop up with v0.17 because we don't opt out of the default Plotly template here. Another is that titles are now no longer centered by default. I have a partial fix but it works for .figure() only and not .iplot()

The easiest thing is probably to override whichever defaults are not appreciated in the existing themes.py file, such as adding layout.hovermode = 'x' etc.
Re-centering the title will likely be a bit more complicated because layout.title used to be a string and is now an object, so if we set layout.title = { ... } in themes.py and then the rest of the code writes a string to layout.title it will get overwritten, so we'd need to find every instance where we write to layout.title and have it write to layout.title.text.

Hi! Any updates on title centering? Trying to use x, xanchor and xref doesn't work on a customized theme...
layout:
  title: {x: 0.5, xanchor: 'center', xref: 'container'}

Update: actually worked here!
layout:
  title_x: 0.5

@fernandascovino I'm having the same problem. Can you include a reproducible example please? Don't know where i should put the
layout:
  title_x: 0.5

Thank you

Of course! So, I've put it into a yaml file, like the one below (named cufflinks_template.yaml)
layout:
  height: 500
  legend:
    font: {size: 12}
    traceorder: normal
  paper_bgcolor: white
  plot_bgcolor: white
  title_x: 0.5 # here the line!
  width: 700
  xaxis:
    automargin: true
    titlefont:
        size: 16
    zerolinecolor: black
    zerolinewidth: 2
  yaxis:
    automargin: true
    tickfont: {size: 15}
    titlefont:
        size: 16
    zerolinecolor: black
    zerolinewidth: 2

And then in Jupyter you can call like this:
import cufflinks as cf

# Setting cuffilinks template - use it with .iplot(theme='custom')
cf.themes.THEMES['custom'] = yaml.load(open([_themes_path_] / 'cufflinks_template.yaml', 'r'))

df.iplot(theme='custom', title=iplottitle('Plotting a graph with custom theme'))

If you want to check out more, I made it into a project here (the example.ipynb has it when you run): https://github.com/JoaoCarabetta/project-templates/tree/master/basic/notebooks

Ok. Thank you. I will look at it later but i don't think there will be any problems (and i never thought about using a yaml file with cufflinks, thanks for the new knowledge).
Obrigado!!


Discuss conventions: element vs. attribute selector

We start to have different approaches to @Directive selectors: compare accordion that uses both element and attribute vs. dropdown that uses element for something that could be an attribute.

I don't think that it is more of a Directive or Component things.
If a component (as generic components, not @Component) is meant to be a whole widget like an accordion, it is better to leave it as element:
<accordion>
  <group></group>
  <group></group>
  <group></group>
</accordion>

It would be weird to use it as attribute (I put it on our accordion because that existed in uibs)
On the other hand, if you have a component that is meant to modify a behavior, you should use attribute:
<input [(ng-model)]="date" ngb-datepicker-popup ...>

It doesn't make sense to use element in there.

If a component (as generic components, not @Component) is meant to be a whole widget like an accordion, it is better to leave it as element

Agreed. This is why I was wondering why you've decided to mark accordion as both an element and an attribute.

First implementation was a bit straight from uibs to get my feet wet. I will file a PR.

I think that this one is resolved.


Windows Installer should unistall prior version during upgrade phase

During upgrade testing it was found that the 13.x installer acknowledges the prior versions installation and asks the user if they wish to upgrade however at that point does not uninstall the prior version to allow it to be successful breaking 13.x usage of the program.

Broken in what way?

Front page layout and formatting prevents me from using it it to determine other ways it may be broken see issue 3501 in the ka-lite repo.

This was fixed with PR #19


Unique Identifiers and Resolutions

It would be great if it's possible to get the Id of an Slot Value!
https://developer.amazon.com/de/docs/custom-skills/define-synonyms-and-ids-for-slot-type-values-entity-resolution.html#slot-value-synonyms-unique-identifiers-and-entity-resolution

Hi, I've added required changes to support slot resolutions to PR #53 currently being reviewed. I hope we will be able to release new library version with all the new features this year.

Fixed by #53


Change from +nodes to +walltime

Calculations are typically more efficient on less nodes, and I'd usually rather bump the walltime than the number of nodes to conserve cost

Codecov Report
All modified lines are covered by tests :white_check_mark:

Comparison is base (5eed9cb) 90.23% compared to head (f895d8e) 90.23%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff           @@
##             main      #10   +/-   ##
=======================================
  Coverage   90.23%   90.23%
=======================================
  Files          19       19
  Lines        2079     2079
=======================================
  Hits         1876     1876
  Misses        203      203

Files
Coverage Δ

vasp_manager/calculation_manager/bulkmod.py
86.76% <100.00%> (ø)

vasp_manager/calculation_manager/elastic.py
80.61% <100.00%> (ø)

vasp_manager/calculation_manager/rlx.py
76.51% <100.00%> (ø)

vasp_manager/calculation_manager/rlx_coarse.py
84.81% <100.00%> (ø)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Feature Request - Show cUrl example for each path

Hi,
I think that auto-generating a curl / languages commands should be a great addon for the paths:
For example:

Thanks,
Guy

Hi @mrin9 ,
Perhaps adding something like this:
https://apiembed.com/
I think it can be very useful.
Thanks,
Guy

auto code generation is not the primary focus of this library.
However, I have added this feature in our internal roadmap


Added pycache to ignore files

Fixes #781 for the defang repo

added **/__pycache__/ to top-level .gitignore file
added a trailing slash / (for consistency with the other repos) to **/__pycache__ in the .dockerignore file

Seems it's already done


Exclude file

Hi,
Is it possible to exclude some file from CaptureImage ?
like :
C:\System Volume Information
hiberfil.sys
...
It's look like possible on the native C++ API via callback process.
Cordialy,

Yes, you would need to register a callback which receives a WimMessageType.Process which you can cancel if you want it left out of the capture.
You can find a sample of registering a callback in the unit test CaptureImageWithCallbackTest
And there's a native sample here as well: https://msdn.microsoft.com/en-us/library/windows/desktop/dd834943.aspx


Added the possibility to config android-packageName and iosBundleIdentifier

Thank you very much for this PR! Some extra notes.

Indentation is wrong. Indent with tabs instead of spaces. I'd suggest to install an EditorConfig plugins for your editor of choice.
Can you add some extra tests to test these 2 methods?

I made the changes you requested. Although when I actually ran the tests with the npm test script, none of them (even the ones that were defined earlier) seemed to work. I decided to put the tests in the same format as you did, as I am not familiar with the particular tooling setup I wasn't able to find a fix for it.

@rstraub the linter is failing. Have to fix that first before I am able to merge and do a new release. If you have some time and are willing to do another PR for that, be my guest :). I can always help you understand the failures. If not, no problem, I'll have to see when I find some time to fix it.

Sounds like a plan. If I have some spare time I will check into it. 👍

Alright, thanks 👍

Ping @rstraub Still interested in completing this?


gh-pages version and jekyll problem

After early November, bundler will install wrong version of gh-pages (latest is 104, but installed 39 instead).
It will cause a lot problem, for example when you try to deploy your Jekyll site locally, it will fail because your Jekyll version is too old.
bundle exec jekyll serve

Configuration file: /Users/shuwan/code/Shu-Wan.github.io/_config.yml
            Source: /Users/shuwan/code/Shu-Wan.github.io
       Destination: /Users/shuwan/code/Shu-Wan.github.io/_site
      Generating...
jekyll 2.4.0 | Error:  uninitialized constant Jekyll::Drops

For now, this can be fixed temporarily by specify gh-pages version in your Gemfile by adding
gem "github-pages", '>=104', group: :jekyll_plugins
Once bundler update, this problem should be fixed

github/pages-gem#351

github/pages-gem#351
See discussion in this issue for more details

Marked open until bundler update and don't need to specify version explicitly.

With latest bundler v1.13.6, this problem has been fixed.
Closed 🎉


Ensure that signature validation works behind SSL and reverse proxy

When running Apache as a reverse proxy for a Node.js app using SSL, signature validation fails because of a protocol mismatch. As Apache is proxying to Node.js, the protocol on the request object will be http instead of https, causing signature validation to fail as the original URL contains https. Therefore, we check if the x-forwarded-proto header is present on the request and use that if it is. 'x-forwarded-proto is the standard header for specifying the forwarded protocol (https://tools.ietf.org/html/rfc7239 --> 5.4. Forwarded Proto)

See #28.
If you still find it necessary, I'd like it to be configurable, default off.

That fixes my problem. Thanks for the pointer.


Fixed grid issue #3

Fixed the shortcut links layout by making them a grid display

LGTM :+1:

Thanks :)


url_launcher on Flutter Web executes JavaScript URIs by default

Description of the problem: launchUrlString() in url_launcher on Flutter Web executes JavaScript URIs by default. Many apps, for example social media web apps, use url_launcher to open user-provided URLs and links to external web pages. For example https://skyfeed.app/, which is a third-party client for the Bluesky social network. Malicious users can craft a simple JavaScript URI and post it on the network, and then when users see that link and click it, it executes the code directly in the client-side app context. Attackers could use this to steal sensitive data like authentication tokens or act as the currently logged-in user.
Steps you took to reproduce the problem:

Clone the latest example app of https://pub.dev/packages/url_launcher
Hook up launchUrlString('javascript:alert(1)'); to a button somewhere
Run with flutter run -d web-server , open web app and click button
It shows an alert dialog, indicating that the JavaScript was executed

Affected versions: latest and likely all previous ones of https://pub.dev/packages/url_launcher
Any known mitigations:

checking canLaunchUrlString first, but many apps don't do that (the docs do not indicate that it's required)
manually checking for javascript: URIs and rejecting them before calling the url_launcher plugin

In my opinion, this behavior is not really intuitive for developers, because they don't expect a "URL launcher" to just execute JavaScript code, especially when it's not mentioned in the README on pub.dev. So developers likely won't expect this attack vector, which can cause a massive risk to users depending on the type of app.

Hi @redsolver. Thanks for filing this. I see this behaviour on my end as well but contrary to this not being stated, I can see this is mentioned.

This should be used only in the very rare case of needing to launch a URL that is considered valid by the host platform, but not by Dart's [Uri] class. In all other cases, use [launchUrl] instead, as that will ensure that you are providing a valid URL.

The behavior of this method when passing an invalid URL is entirely platform-specific; no effort is made by the plugin to make the URL valid. Some platforms may provide best-effort interpretation of an invalid URL, others will immediately fail if the URL can't be parsed according to the official standards that define URL formats.

Can you check this out as well?

This is definitely an XSS issue, we should be sanitizing the src before we render the link or open the URL.

I'm preparing a fix that is going to do two things:

Disallow opening urls from the javascript: scheme, as suggested above.
Pass noreferrer,noopener to the new window, so scripts in the target window cannot talk to the page that opened the new window :) (this is the real problem! See: OWASP: HTML5 Security: Tabnabbing)

this behavior is not really intuitive for developers, because they don't expect a "URL launcher" to just execute JavaScript code

I have to say that this is 100% normal behavior on the web, see this example. It's not desirable because it can be exploited, but things are "working as intended" :)
Anyway, I'm arguing semantics now... thanks for reporting, we're plugging this hole ASAP!

I have a PR out for this: https://github.com/flutter/packages/pull/5180


Smooth out network/scheduling effects when sending heartbeats

The comment in the code explains it all. By sending the same rate that we emit heartbeats at, it's easy for network effects to cause the server to not see a heartbeat in time and time out the connection. Basically it turns into a distributed race condition.
By emitting the heartbeats at 75% of the rate the server expects, we have a much better chance of avoiding this situation.

This probably isn't actually necessary. RabbitMQ, at least, allows for 2 missed heartbeats before timing out the connection, so there is no need to skew the local emission time.
Feel free to close this if you don't feel it's necessary.

Thanks for the concern! The higher rate would indeed be needed if RabbitMQ didn't handle multiple failed heartbeats.
This client tolerates 3 missed server heartbeats with the thought that having the same tolerable missed heartbeats as the server increases the chance of an idle disconnect race under symmetric congestion/partition. This client prefers the server to close first:  https://github.com/streadway/amqp/blob/master/connection.go#L517
I'm not certain how RabbitMQ behaves when applies TCP flow control on publishers. I assume that it also disables the heartbeat checks while TCP flow control (closed TCP window) is active. This client doesn't remove the read timeout under any TCP flow control on deliveries.
I can imagine head-of-the-line blocking from slow consumers that exceed 3 heartbeat intervals between deliveries will generate read timeouts which look like idle servers.


Cucumber 2.0 support

Using Cucumber 2.0, steps in the test will not be rendered until after the user passes or fails them.
This occurs even if the Cucumber 2.0 gem is not used at runtime.

**#

_

[ ] 1. PLEASE DO THIS PRODUCT IS USELESS WITHOUT

_
**

@gausie your review is unhelpful without a star rating out of 5.

here's an answer by @mattwynne that might help

@d-led the answer referenced there is well out of date. It pre-dates the new formatter API.

@mattwynne thanks! So, what would a 2.+ solution be?

I'm not sure, I need a lot more context about how you're doing things at the moment and what Cucumber 2.0 did to break that. All I know is that subclassing the existing pretty formatter is probably not a good idea.

Hi @mattwynne and @d-led thanks for the info and for bringing this long dormant issue back to my attention! 😄 I'm planning on having another look at this. From what I can remember, the formatter I created was based on the SlowHandCuke formatter which also broke for a short time with Cucumber 2.0. Perhaps if that was fixed then the fix for this will most likely be the same.


BAR - Client redirect to Entities dashboard - confirm direction and solution

AR filing will point to the Entities dashboard when filing completes (needs to be updated this PI)
When we cut over to the new dashboard, BAR needs to update where they direct a client to after they complete the AR. This will be done when we go live. (Currently, BAR ends the screen on a confirmation page that the user has successfully filed the AR. The client is not directed to the Business Registry.
If that remains the decision, there is no impact). Please confirm this w/ Melissa what the decision is
once the decision is between the teams (Omid, you, Entities) is confirmed and the solution is confirmed, we will need to advise Melissa

@hanlunBCRegistries we want to start the first piece of this work.    We would like a BAR Filing once completed to redirect to the Business Registry Dashboard.  let me know if you have any questions.

Need more detail about what to display on the landing page and where to redirect. Some of the work need to be done here can be overlap with tix 147


Implement metrics

Use the AppMetrics to implement metrics for:

[ ] NeonService

[ ] Console
[ ] Web

[ ] Cadence
[ ] Temporal

Another possible solution: https://github.com/prometheus-net/prometheus-net

We're going to go with: https://github.com/prometheus-net/prometheus-net

We ended up implement metrics here: #1039


Header files for the solver structure

This is a "fake" PR, it does not compile, it will not really be merged directly.
This PR contains the header files for the new structuring of our symbolic solver and interprater.
When approved, these header files will be used in the end2end PR and the source code will be updated to follow their structure.
p4_symbolic/symbolic/symbolic.h is the API-exposing header file, this needs to be used included and used by enclosing code that wants to use our solver.
symbolic.h/SymbolicState and the internal functions in action.h may still be extended/changed in end2end as necessary. The rest is fixed.

This is beautiful! Thanks you!

All your comments are addressed. I am going to close this PR since it is only fake and the actual code has been posted to end2end.


Cannot use GPU support in virtualized Windows 11 21H2 (22000.556)

Is your feature request related to a problem? Please describe.
I am not able to use my Nvidia GPU inside WSL2 in a nested virtualization scenario (WSL2 is running inside a Windows 11 Virtual Machine). The GPU works fine on both the Host and the Virtual Machine (via GPU partitioning)
Describe the solution you'd like
I would like to be able to use the GPU inside WSL2
Describe alternatives you've considered
I can run WSL2 directly on the host I guess
Additional context
Host: Windows 11 Pro
Virtual Machine: Windows 11 Pro
GPU: Nvidia RTX 3090 with latest drivers (511.79)
Kernel: <IP_ADDRESS>-microsoft-standard-WSL2 #1 SMP Wed Aug 25 23:20:18 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

YES. I TOTALLY SUPPORT THIS!
I did a post on https://forums.developer.nvidia.com/t/run-cuda-inside-docker-wsl-on-windows-11-hyper-v-vm-with-gpu-patritioning/308212. I tried to explain it in more detail to see if somebody knows how to do it but I realized this is kinda a Microsoft problem.


Allow to break the build if there are issues that need attention

So obviously it is great to see the violations in Stash, but it would be great to also break the build to stop the Jenkins pipeline at this step.
For Sonar 5.3 there is also the build breaker plugin to achieve that, however that breaks the build only for full (non-preview) analysis runs. Also the build breaker plugin waits for the analysis to finsh while this plugin seems to be able to evalutate the result immediately (I believe this is because sonar-stash is not checking the quality gate but "only" simple issues on particular files).
So I suggest introducing a config flag that if it is set to true, will simple break the build after pushing the issues to stash. Breaking the build should be a matter of throwing an exception (compare https://github.com/SonarQubeCommunity/sonar-build-breaker/blob/2.1/src/main/java/org/sonar/plugins/buildbreaker/QualityGateBreaker.java#L184 for this)

I think this functionality does not belong into this plugin.
Whatever is missing should be implemented in the build breaker plugin or a new plugin.