Webpack 4

Hey, Webpack 4 will be released soon. I'm creating this issue to track when this template is updated so I can update my projects. And I'm particularly interesting in how #1022 will be affected (or not).

It's out now: https://github.com/webpack/webpack/releases/tag/v4.0.0

Compelling reason for upgrading

Better Defaults — #0CJS (Zero configuration - no need for a webpack config file)
webpack takes care of dead code elimination (previously done by uglifyjs)
huge performance/bundle size improvement over webpack 3.

Things to consider

webpack-cli is separated
webpack 4 has newer plugin system (current webpack 3 plugin system deprecated)
changes in common js importing

Syntax

import() always returns a namespace object. CommonJS modules are wrapped into the default export
    This probably breaks your code, if you used to import CommonJs with import()

changes in module type support (auto, esm, json, webassembly)

Defaults

webpack now looks for the .wasm, .mjs, .js and .json extensions in this order

nodejs 4 support is dropped (expected)
a fork of vuejs-templates/webpack for webpack 4 (until everyone realizes webpack 4 has huge benefits over webpack 3)

Not a smooth upgrade with Webpack 4 particular extract-text-webpack-plugin
https://github.com/webpack-contrib/extract-text-webpack-plugin/issues/727

As I mentioned, webpack 4 has new plugin system
The extract-text-plugin is currently in alpha version (there's no stable release for webpack 4 yet)
plugins are required to rewriiten with webpack 4 compatible API
plugin users have to keep an eye on releases and issues for smooth update (wait for the right time)

Waiting for something new...

extract-text-plugin is in beta now, and seems almost stable...

Webpack Stable!

Would it make sense to switch to Mini CSS Extract in place of extract-text-plugin? See: https://github.com/webpack-contrib/extract-text-webpack-plugin/issues/749

It seems the maintainer of ETWP decided to deprecate this plugin on webpack >= v4.0.0 and recommend mini-css-extract-plugin instead. Many issues related to ETWP 4 (with prefix 4.0.0-beta.0) is closed with that notification. Maybe we should consider mini-css-extract-plugin?

@jiyyxx @dak Do you know what would be involved in replacing extract-text-plugin with mini-css-extract-plugin?

The mini-css-extract-plugin, from my perspective, is quite simple with only two options filename and chunkFilename. As the maintainer of ETWP claims, if you only use ETWP to extract css, migration should be very simple. I didn't have time to try the migration out, but I believe it would not be tricky if this template uses ETWP to extract css only.

I just tried updating all the deps to webpack 4 compatible version, and altered the config a bit but UNFORTUNATELY faced with numerous errors :-(
The previous build/utils.js calling ExtractTextPlugin.extract is a tricky part to me. I doesn't have sufficient knowledge on how the function works and simply copied related code from ExtractTextPlugin.extract, together with other related code and made a few necessary changes such as changing ExtractTextPlugin.loader to MiniCssExtractPlugin.loader. Eventually, the code could begin to work but reporting Module build failed: ReferenceError: document is not defined with every css file in my project.
A typical stacktrace:
Module build failed: ReferenceError: document is not defined
    at addStylesClient_addStyle (E:\Desktop\QY Project\QingyunMusicPlayer-JS\node_modules\vue-style-loader\index.js!E:\Desktop\QY Project\QingyunMusicPlayer-JS\node_modules\css-loader\index.js??ref--10-2!E:\Desktop\QY Project\QingyunMusicPlayer-JS\node_modules\postcss-loader\lib\index.js??ref--10-3!E:\Desktop\QY Project\QingyunMusicPlayer-JS\node_modules\element-ui\lib\theme-chalk\display.css:329:22)
    at addStylesClient_addStylesToDom (E:\Desktop\QY Project\QingyunMusicPlayer-JS\node_modules\vue-style-loader\index.js!E:\Desktop\QY Project\QingyunMusicPlayer-JS\node_modules\css-loader\index.js??ref--10-2!E:\Desktop\QY Project\QingyunMusicPlayer-JS\node_modules\postcss-loader\lib\index.js??ref--10-3!E:\Desktop\QY Project\QingyunMusicPlayer-JS\node_modules\element-ui\lib\theme-chalk\display.css:313:20)
    at addStylesClient_addStylesClient (E:\Desktop\QY Project\QingyunMusicPlayer-JS\node_modules\vue-style-loader\index.js!E:\Desktop\QY Project\QingyunMusicPlayer-JS\node_modules\css-loader\index.js??ref--10-2!E:\Desktop\QY Project\QingyunMusicPlayer-JS\node_modules\postcss-loader\lib\index.js??ref--10-3!E:\Desktop\QY Project\QingyunMusicPlayer-JS\node_modules\element-ui\lib\theme-chalk\display.css:267:3)
    at Object.SOZN (E:\Desktop\QY Project\QingyunMusicPlayer-JS\node_modules\vue-style-loader\index.js!E:\Desktop\QY Project\QingyunMusicPlayer-JS\node_modules\css-loader\index.js??ref--10-2!E:\Desktop\QY Project\QingyunMusicPlayer-JS\node_modules\postcss-loader\lib\index.js??ref--10-3!E:\Desktop\QY Project\QingyunMusicPlayer-JS\node_modules\element-ui\lib\theme-chalk\display.css:169:14)
    at __webpack_require__ (E:\Desktop\QY Project\QingyunMusicPlayer-JS\node_modules\vue-style-loader\index.js!E:\Desktop\QY Project\QingyunMusicPlayer-JS\node_modules\css-loader\index.js??ref--10-2!E:\Desktop\QY Project\QingyunMusicPlayer-JS\node_modules\postcss-loader\lib\index.js??ref--10-3!E:\Desktop\QY Project\QingyunMusicPlayer-JS\node_modules\element-ui\lib\theme-chalk\display.css:21:30)
    at module.exports.I1BE.module.exports.list (E:\Desktop\QY Project\QingyunMusicPlayer-JS\node_modules\vue-style-loader\index.js!E:\Desktop\QY Project\QingyunMusicPlayer-JS\node_modules\css-loader\index.js??ref--10-2!E:\Desktop\QY Project\QingyunMusicPlayer-JS\node_modules\postcss-loader\lib\index.js??ref--10-3!E:\Desktop\QY Project\QingyunMusicPlayer-JS\node_modules\element-ui\lib\theme-chalk\display.css:70:18)
    at Object.<anonymous> (E:\Desktop\QY Project\QingyunMusicPlayer-JS\node_modules\vue-style-loader\index.js!E:\Desktop\QY Project\QingyunMusicPlayer-JS\node_modules\css-loader\index.js??ref--10-2!E:\Desktop\QY Project\QingyunMusicPlayer-JS\node_modules\postcss-loader\lib\index.js??ref--10-3!E:\Desktop\QY Project\QingyunMusicPlayer-JS\node_modules\element-ui\lib\theme-chalk\display.css:73:10)
    at Module._compile (module.js:649:30)
    at exec (E:\Desktop\QY Project\QingyunMusicPlayer-JS\node_modules\mini-css-extract-plugin\dist\loader.js:54:10)
    at childCompiler.runAsChild (E:\Desktop\QY Project\QingyunMusicPlayer-JS\node_modules\mini-css-extract-plugin\dist\loader.js:132:14)
    at compile (E:\Desktop\QY Project\QingyunMusicPlayer-JS\node_modules\webpack\lib\Compiler.js:238:11)
    at hooks.afterCompile.callAsync.err (E:\Desktop\QY Project\QingyunMusicPlayer-JS\node_modules\webpack\lib\Compiler.js:486:14)
    at AsyncSeriesHook.eval [as callAsync] (eval at create (E:\Desktop\QY Project\QingyunMusicPlayer-JS\node_modules\tapable\lib\HookCodeFactory.js:24:12), <anonymous>:15:1)
    at AsyncSeriesHook.lazyCompileHook [as _callAsync] (E:\Desktop\QY Project\QingyunMusicPlayer-JS\node_modules\tapable\lib\Hook.js:35:21)
    at compilation.seal.err (E:\Desktop\QY Project\QingyunMusicPlayer-JS\node_modules\webpack\lib\Compiler.js:483:30)
    at AsyncSeriesHook.eval [as callAsync] (eval at create (E:\Desktop\QY Project\QingyunMusicPlayer-JS\node_modules\tapable\lib\HookCodeFactory.js:24:12), <anonymous>:6:1)
    at AsyncSeriesHook.lazyCompileHook [as _callAsync] (E:\Desktop\QY Project\QingyunMusicPlayer-JS\node_modules\tapable\lib\Hook.js:35:21)
    at hooks.optimizeAssets.callAsync.err (E:\Desktop\QY Project\QingyunMusicPlayer-JS\node_modules\webpack\lib\Compilation.js:957:35)
    at AsyncSeriesHook.eval [as callAsync] (eval at create (E:\Desktop\QY Project\QingyunMusicPlayer-JS\node_modules\tapable\lib\HookCodeFactory.js:24:12), <anonymous>:6:1)
    at AsyncSeriesHook.lazyCompileHook [as _callAsync] (E:\Desktop\QY Project\QingyunMusicPlayer-JS\node_modules\tapable\lib\Hook.js:35:21)
    at hooks.optimizeChunkAssets.callAsync.err (E:\Desktop\QY Project\QingyunMusicPlayer-JS\node_modules\webpack\lib\Compilation.js:948:32)
    at _err2 (eval at create (E:\Desktop\QY Project\QingyunMusicPlayer-JS\node_modules\tapable\lib\HookCodeFactory.js:24:12), <anonymous>:20:1)
 @ ./src/main.js

I think I must make sth wrong, so I hope someone familiar with webpack, ETWP, mini-css-extract-plugin or anything related to text extraction could come to help.

I replaced ETWP with Mini-CSS-Extract-Plugin with fairly minimal changes.

I removed the ETWP code from build/utils.js completely
I added optimization config to webpack.base.conf.js:

optimization: {
    minimize: false,
    runtimeChunk: {
        name: 'vendor'
    },
    splitChunks: {
        cacheGroups: {
            default: false,
            commons: {
                test: /node_modules/,
                name: "vendor",
                chunks: "initial",
                minSize: 1
            }
        }
    }
}

I replaced ExtractTextPlugin with MiniCSSExtractPlugin in webpack.prod.conf.js:

const MiniCSSExtractPlugin = require('mini-css-extract-plugin'); // import

// added optimization.minimize: true to settings
optimization: {
    minimize: true
}

// changed `new ExtractTextPlugin({` to `new MiniCSSExtractPlugin({` with the exact same param `{filename: utils.assetsPath('css/[name].[contenthash].css')}` passed as an argument.

Removed all CommonsChunkPlugin code.

I have changed the build process in my project quite a bit since I used this template, so there may be some differences. I also was seeing two deprecation warnings that I wasn't able to track down, but didn't seem to have any detrimental effect:
(node:37161) DeprecationWarning: Tapable.plugin is deprecated. Use new API on `.hooks` instead
(node:37161) DeprecationWarning: Tapable.apply is deprecated. Call apply on the plugin directly instead

Hopefully this helps.

@dak That's nice work.

I removed the ETWP code from build/utils.js completely (I faced similar problems as @jjyyxx)

Comment these code out leads to other errors as
CssSyntaxError {
  name: 'CssSyntaxError',
  reason: 'Unknown word',
  file: 'E:\\Desktop\\QY Project\\QingyunMusicPlayer-JS\\src\\components\\TmDocContainer.vue',
  source: 'exports = module.exports = require("../../node_modules/css-loader/lib/css-base.js")(false);\n// imports\n\n\n// module\nexports.push([module.id, "\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\r\\n.tm {\\r\\n  display: block;\\r\\n  background-color: black;\\r\\n  padding: 10px;\\r\\n}\\r\\n", ""]);\n\n// exports\n',
  line: 1,
  column: 1,
  message: 'E:\\Desktop\\QY Project\\QingyunMusicPlayer-JS\\src\\components\\TmDocContainer.vue:1:1: Unknown word',
  input:
   { line: 1,
     column: 1,
     source: 'exports = module.exports = require("../../node_modules/css-loader/lib/css-base.js")(false);\n// imports\n\n\n// module\nexports.push([module.id, "\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\r\\n.tm {\\r\\n  display: block;\\r\\n  background-color: black;\\r\\n  padding: 10px;\\r\\n}\\r\\n", ""]);\n\n// exports\n',
     file: 'E:\\Desktop\\QY Project\\QingyunMusicPlayer-JS\\src\\components\\TmDocContainer.vue' } }

Did I miss sth?

@jjyyxx I left the vue-style-loader to always return (probably from an old version of this template):
function generateLoaders(loader, loaderOptions) {
    const loaders = [cssLoader];

    if (loader) {
        loaders.push({
            loader: `${loader}-loader`,
            options: Object.assign({}, loaderOptions, {
                sourceMap: options.sourceMap
            })
        });
    }

    // Extract CSS when that option is specified
    // (which is the case during production build)
    // if (options.extract) {
    //     return MiniCSSExtractPlugin.extract({
    //         use: loaders,
    //         fallback: 'vue-style-loader'
    //     });
    // }

    return ['vue-style-loader'].concat(loaders);
}

So currently CSS has to be bundled within the JS files?

@dak Thanks for sharing how you fixed it.
I'm also having same warnings. I'm not sure what the cause is. I've tried to trace it using by following the steps mentioned here - https://github.com/webpack/webpack/issues/6568#issuecomment-374871753, but it didn't work for me.

@jjyyxx I wasn't a huge fan of that either, but it wasn't worth it to me to figure out the fix (especially for my usecase, where a single version of an application is being installed in isolation, so I get little benefit out of caching files separately). I'm not even sure there is a good solution (yet).
@kinsomicrote I believe the errors are coming from the plugins being used. Apparently WebPack 4 is backwards compatible with WebPack 3 plugins, which are where the deprecation warnings are coming from. I saw html-webpack-plugin fixed an issue with that exact deprecation warning in I believe 3.0.6, although I imagine it will take some time for all the plugins used to be fully updated for WebPack 4.

@dak Thanks for your help. It currently works. However, without extracting css leads to no minification (remove comments, etc) of the css declarations, increasing my bundle size by 500kb.
My case might be special but I think extraction is necessary for part of the users. Maybe someone could solve this.

Hi all:
I have a full demo for webpack 4 vue project , with extracting css and splitChunks. pls check , https://github.com/jinwyp/koa-user/blob/master/frontend-vue/src/config/webpack.base.conf.js
I would say it need a bit work to upgrade to webpack4.

I recommend to wait for vue-loader 15 - https://github.com/vuejs/vue-loader/tree/next, to have native support.

I recommend to wait for vue-loader 15

Webpack 4 with @jinwyp 's solution works but result in huge file size (js bundle in 2.4MB) while Webpack 3 with default vue-template config producing 725KB files.

I recommend to wait for vue-loader 15 to have native support.

vue-loader v15.0.0 is out now 🚀

@LinusBorg Any updates on this?

Also we should wait for vue-cli v3

@jingzheshan I haven't looked at the implementation details regarding this but it might be useful to set up a demo repository for reference for everyone else?

The build for my PR (#1369) is failing. I have a pretty good idea why, and I'd appreciate it if anybody familiar with CircleCI or permissions to manage the official build on CircleCI could take a quick look.
The details are here: https://github.com/vuejs-templates/webpack/pull/1369#issuecomment-385192951.

https://github.com/vuejs/vue-cli/issues/1205
vue-cli is currently at beta.9. So the official template may come out soon.

vue-cli  beta.10 just released a few hours ago which upgraded to webpack 4

@LinusBorg The PR for this seems to be ready. Would you be able to review it?
https://github.com/vuejs-templates/webpack/pull/1369

@dak your walkthrough really helped me out. thank you!


IN-597 : WAS folder search

Description
This PR contains code-changes for IN-597 -> PR https://github.com/dhvanilshah-tenable/pyTenable/pull/90
Type of change

[ ] New feature (non-breaking change which adds functionality)

How Has This Been Tested?
To test code-changes of this PR, first I ran test-cases of pyTenable/tests/io/v3/was/folders/test_folders_api.py file to validate if new test-cases are working fine. All test-cases of this file are ran successfully and getting passed. PFA Output of TCs executed and snap-shot :

After that, I ran all test-cases of pyTenable/tests folder to validate if existing test-cases are not affected. All test-cases of this folder are ran successfully and getting passed. PFA TCs execution output and snap-shot :

Test Configuration:

Python Version(s) Tested: 3.10

Checklist:

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules

https://github.com/alpesh-te/pyTenable/pull/10 is created for this script changes


EPA CEMS can't process states (AK and PR) that only show up in some years

Alaska was added to the EPA CEMS data in 2019, and we just added it to the list of states that we attempt to process during the EPA CEMS ETL, since the files are there already. However, the current system can't deal with this because it iterates over all combinations of the values found in epacems_states and epacems_years. And since there's no AK data before 2019, it fails immediately.
2021-09-29 23:08:45 [    INFO] pudl.etl:439 Processing EPA CEMS data and writing it to Apache Parquet.
2021-09-29 23:08:45 [    INFO] pudl.extract.epacems:168 Processing EPA CEMS hourly data for AK-1995
Traceback (most recent call last):
  File "/home/zane/code/catalyst/pudl/src/pudl/workspace/datastore.py", line 351, in get_unique_resource
    _, content = next(res)
StopIteration

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/home/zane/miniconda3/envs/pudl-dev/bin/pudl_etl", line 33, in <module>
    sys.exit(load_entry_point('catalystcoop.pudl', 'console_scripts', 'pudl_etl')())
  File "/home/zane/code/catalyst/pudl/src/pudl/cli.py", line 140, in main
    pudl.etl.etl(
  File "/home/zane/code/catalyst/pudl/src/pudl/etl.py", line 764, in etl
    etl_epacems(dataset["epacems"], pudl_settings, ds_kwargs)
  File "/home/zane/code/catalyst/pudl/src/pudl/etl.py", line 444, in etl_epacems
    for df in epacems_transformed_dfs:
  File "/home/zane/code/catalyst/pudl/src/pudl/transform/epacems.py", line 228, in transform
    for raw_df in epacems_raw_dfs:
  File "/home/zane/code/catalyst/pudl/src/pudl/extract/epacems.py", line 171, in extract
    ds.get_data_frame(partition)
  File "/home/zane/code/catalyst/pudl/src/pudl/extract/epacems.py", line 109, in get_data_frame
    archive = self.datastore.get_zipfile_resource(
  File "/home/zane/code/catalyst/pudl/src/pudl/workspace/datastore.py", line 362, in get_zipfile_resource
    return zipfile.ZipFile(io.BytesIO(self.get_unique_resource(dataset, **filters)))
  File "/home/zane/code/catalyst/pudl/src/pudl/workspace/datastore.py", line 353, in get_unique_resource
    raise KeyError(f"No resources found for {dataset}: {filters}")
KeyError: "No resources found for epacems: {'year': 1995, 'state': 'ak'}"

For the moment I will comment out AK and PR from the list of available states.
Possible fixes

Specify desired state-year combinations explicitly, rather than combining states and years independently. This would work, but require a lot more information to be specified.
If a requested data partition isn't available, just print out a logging message and move on. However, since this error is happening at the datastore level, that kind of change would have wider implications.
We could create dummy zero length data for the year-state combinations that don't exist. This seems to be what's happening for other states that are missing early data (except EPA is doing it for us...)
We could create a custom MissingDataPartitionError and have the Datastore code raise it when this happens, and pass it up to the EPA CEMS ETL code, which could deal with it appropriately (Ignore if it's AK before 2019, or PR not in 2015...) This is probably the right way to handle this. We should get better at exception handling generally and start defining our own exception classes that are more informative than the generic ones.

I think #1292 gets us closer to resolving this issue.
We could have a pc.MISSING_PARTITIONS dictionary that contains tuples of missing partitions for each dataset:
MISSING_PARTITIONS = {
	"epacems": [("AK", 2018), ("PR", 2015)]
}

GenericDatasetSettings could then validate and exclude the missing partitions from the cartesian product of partitions. Parts of our ETL might need to be updated to extract and transform specific partitions.

Maybe there's a more general way to think about the "working partitions" that also includes the tables. Right now we exclude certain tables in certain years via the spreadsheet maps -- lots of source tables / columns don't exist in many of the older years, or get discontinued in latter years. Or they need to come from different file formats or different original sources in different years. Like the FERC-423 / EIA-423 which contains the fuel receipts and costs data before 2008 (which is found in the EIA-923 data thereafter).

I love both of these ideas. I didn't realize some tables aren't available for certain years. Tables can easily be added to WORKING_PARTITIONS in our new dataset settings validation.

@zschira This issue has some previous conversation about generalizing partitions.

Will be fixed in https://github.com/catalyst-cooperative/pudl-archiver/pull/138 because the download links are dynamically generated from API list of available state/year combos.


Add a Gitter chat badge to README.md

Bash-it/bash-it now has a Chat Room on Gitter
@tswicegood has just created a chat room. You can visit it here: https://gitter.im/Bash-it/bash-it.
This pull-request adds this badge to your README.md:

If my aim is a little off, please let me know.
Happy chatting.
PS: Click here if you would prefer not to receive automatic pull-requests from Gitter in future.

Already adjusted this manually.


Tagged releases and tarball on PyPI still contains SNAPSHOT

https://github.com/bm1549/frigidaire/blob/ab6209c7fb0d176cfa60cca6eb2d25c7bede1b20/setup.py#L8
The tagged releases on GitHub still contain SNAPSHOT instead of the actual release. This also applies for the tarballs which are published on PyPI. This is an issue for all distributions as it requires them to patch the version.
In the near future the module is also no longer installable for Home Assistant users.

The release flow doesn't seem to work.
$ curl https://files.pythonhosted.org/packages/4b/19/e1e3df057e4022a86fa688663472078ed9d7c3b5ee3d396d7fa2bebdef15/frigidaire-0.18.5.tar.gz -O
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  6622  100  6622    0     0  57412      0 --:--:-- --:--:-- --:--:-- 57582
$ tar -xzf frigidaire-0.18.5.tar.gz
$ cat frigidaire-0.18.5/setup.py | grep -e version
version = "SNAPSHOT"
if "--version" in sys.argv:
    idx = sys.argv.index("--version")
    version = sys.argv.pop(idx)
print("Using version " + version)
    version=version,
``

Thanks for reporting @fabaff - can you confirm that 0.18.10 resolves the issue you're seeing?


Add instantiation parameters to the scheduled job

This allows to use instantiation parameters to the scheduled job.
For it to work, it needs two steps:

Schedule the job with  MyScheduledClass.schedule_job(nil, params=[p1, p2, p3])
Keep the params array at the @params var, so simply add something like @params = [p1, p2, p3] in your classes initialize function.

Maybe there's a cleaner way to do this ?

Closing this myself since this is a bit of an unnecessary hack.
If the different scheduled jobs are going to be in the same schedule, they can be implemented in the same job, if they don't, time_to_recur is going to be different so probably subclassing is a better solution


Update Spectrum UI.

Adobe just shipped a new and updated version of its Spectrum web UI, the one used for this extension. Part of that UI is also a new font, Adobe Clean (see distribution discussion on Slack).
We should probably update the UI… 🤔

Commit https://github.com/bookalope/InDesign-CEP/commit/727a0811208c595946ed3ef7cc62295263e4568b.


Update checkstyle rule version

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@2a34619). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master   #14186   +/-   ##
=========================================
  Coverage          ?   64.73%
  Complexity        ?      426
=========================================
  Files             ?     2173
  Lines             ?    95949
  Branches          ?    12817
=========================================
  Hits              ?    62117
  Misses            ?    28812
  Partials          ?     5020

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a34619...46ab091. Read the comment docs.


MRG: Add support for channel types, add .DS_Store to .gitignore, add a conversion to str for fname

Hello, I had to move some of my -raw.fif files to EEGLAB; and I noticed the lack of support for channels types (which is problematic for me). I'm adding it here, using the example channel types provided here.
A quick test shows that everything is working; the now loaded .set file in EEGLAB does show the correct channel types.
Please correct me if I'm wrong or if I overlooked anything.
I'm not adding anything to the test (yet) because mne.io.read_raw_eeglab() doesn't seem to support reading the channel types anyway. I will add it there as well when MNE release a version including https://github.com/mne-tools/mne-python/pull/9990

I also added 2 more small improvements:

.DS_Store to the .gitignore for macOS developers.
str(fname) before calling scipy.io.savemat. It's not uncommon for users to provide the path to a file as a pathlib.Path instance and this would raise an error in scipy.

@jackz314 pinging for review.

Thanks @mscheltienne !


The links of the model and experimental data are no longer valid

The links of the model and experimental data are no longer valid

Sorry for this delayed reply, we'll fix this bug quickly


identity management blocks if you enter the wrong secret

branch: unstable
I tried to follow the documentation how to configure the new identity manager : https://github.com/threefoldtech/jumpscaleX_core/blob/unstable/docs/Identity.md

So it seems I enter the wrong secret (which secret ? we don't know no information about it...)
I then retried to start kosmos with jsx kosmos -n zaibon.3bot but always get the same error directly. No chance to enter another secret.

Even when entering kosmos normally and then trying j.me.configure()  save error

that's not an issue anymore right? you delete /sandbox/cfg/bcdb_config already no?

I've killed redis and used different secret and now gives different error

The key is now saved in redis,

key name is: "threebot.secret.encrypted"
should we implement something called identity reset to delete that key, or it's not in the flow ?

updated the docs with secret  @ https://github.com/threefoldtech/jumpscaleX_core/blob/unstable/docs/Identity.md

If you entered a wrong secret just delete the key from redis
3BOTDEVEL:3bot:~: redis-cli
<IP_ADDRESS>:6379> KEYS *
1) "threebot.secret.encrypted"
<IP_ADDRESS>:6379> del "threebot.secret.encrypted"
(integer) 1
<IP_ADDRESS>:6379>

verified.


Setup and TearDown on Suite level

How can user define setup and teardown actions on suite level?

Currently not possible. I'm planning on implementing something like this, please check http://golem-framework.readthedocs.io/en/latest/golem-test-framework.html if you have time. It's the draft of what I'm planning to implement.
Thanks!

Looks good.Thank you.


Failing to split use case

Firstly, this is some awesome work so thank you for your time.
JD-GUI can display the class. Jar is here https://www.dropbox.com/s/u36hzev27hcgq8h/large method.jar?dl=1
The offending method in question has a huge switch statement. 31152 Instructions.

Code I'm using

MethodNode       big     = myClassNode.methods.get(0);
System.out.println("identified big method: "+big+" ... attempting to split");
SplitMethod.Result result = new SplitMethod(Opcodes.ASM5).split(node.name, big, 2000, 15000, 15000);
if (result == null)
	throw new NullPointerException("splitmethod failed :(");
node.methods.remove(big);
node.methods.add(result.trimmedMethod);
node.methods.add(result.splitOffMethod);

System.out.println("attempting new nodeToClass of customized node!");
Class<?> c = nodeToClass(node, ClassWriter.COMPUTE_MAXS | ClassWriter.COMPUTE_FRAMES); // splitting removes both, so needed here

Output
Exception in thread "Thread-7" java.lang.NullPointerException: splitmethod failed :(
Disclosure, Im new to ASM. I tried ASM 4&5 in constructor params and min/max ranges of 2k - 15k, 20k 25k

Yeah, this is a limitation of the algorithm I chose. I specifically chose to split off a large set of instructions without jumps. If there are no large sets of instructions, but instead a bunch of small sets inside a switch, it will take a different algorithm.
I'm afraid it doesn't fit my use case to split large switches, but this shouldn't hard to dev. Just take LookupSwitchInsnNode and take out half (or however many) the pairs, make a new method, have the default case of the now=halved lookup call the other with the same index var, and build the switch there.

I also got a null pointer thrown from this line, https://github.com/cretz/msplit/blob/master/src/main/java/msplit/Splitter.java#L352. This caused because there is a throe instruction before this store instruction. After throws and returns, the adopter you use clears the stack. Hence it is very frequent to hit this NPE. A fix from you would be nice.

@vinok88 got the same NPE with GOTO instruction on https://github.com/cretz/asmble/issues/30. I am trying to investigate it now, could you please provide your test case?

The problem here is in absence of StackMapTable generation. Docs for AnalyzerAdapter says that
If this adapter is used with a class that does not contain stack map table attributes (i.e., pre Java 6 classes) then this adapter may not be able to compute the stack map frame for each instruction.
```.
And [here](https://gitlab.ow2.org/asm/asm/blob/master/asm-commons/src/main/java/org/objectweb/asm/commons/AnalyzerAdapter.java#L344) `stack` and `locals` set to null.


Server connection count vs client connection count

What is the max number of client connections I could have with 1 unit?  I know it says 1000 connections, but how does that work with the server connection count?
In other words, will the automatic 5 server connections per hub sustain more than 5 client connections?  Or do I have to make changes to my code to enable a single hub (with the 5 server connections) to serve 1000 client connections.
My goal is to have a single hub and 1000 users (clients) connected to serve real time data to a very large team.

First, the quota contains the server connections and client connections, so if you need to guarantee 1000 client connections, 2 units is a better choice.
Then, one hub with 5 server connections can handle 1000 client connections. But please note, one client connection will be routed to a specific server connection, and once the server connection abort somehow, all client connections routed to this server connection will be terminated at once.

That sounds great thank you for your response!  Also, what constitutes a message in the message count?  Because I'm sending a JSON object which seems to be counted as around 100 messages.  Is there a better way I could package this to be a smaller number of messages?  Because right now with only about 10 clients connected, I've hit 152k messages in the span of a few hours.

#299


display PlexAPI version in header

Description
Adds a line displaying the PlexAPI version in use.  Yes, it's pinned in the requirements, but all three branches are currently different and this might be useful information if the user has manually changed it.
Type of Change
Please delete options that are not relevant.

[X] New feature (non-breaking change which adds functionality)

Checklist

[X] My code was submitted to the nightly branch of the repository.

May be cleaner to use the pre-defined constants in PlexAPI: https://github.com/pkkid/python-plexapi/blob/master/plexapi/const.py


died with <Signals.SIGILL: 4>

Hi,
When I tried running the command sh scripts/arch_adapt_retinanet.sh with the model seed_mbv2.pt you provided as mentioned in README.md, I got following error,
06/26 06:47:57 PM - Start loading the model from ./seed_mbv2.pt 06/26 06:47:57 PM - Remapping for architecture adaptation starts! 06/26 06:47:57 PM - Remapping for architecture adaptation finished! Traceback (most recent call last):   File "/home/liqs/anaconda3/envs/py37/lib/python3.7/runpy.py", line 193, in _run_module_as_main     "__main__", mod_spec)   File "/home/liqs/anaconda3/envs/py37/lib/python3.7/runpy.py", line 85, in _run_code     exec(code, run_globals)   File "/home/liqs/anaconda3/envs/py37/lib/python3.7/site-packages/torch/distributed/launch.py", line 235, in <module>     main()   File "/home/liqs/anaconda3/envs/py37/lib/python3.7/site-packages/torch/distributed/launch.py", line 231, in main     cmd=process.args) subprocess.CalledProcessError: Command '['/home/liqs/anaconda3/envs/py37/bin/python', '-u', './tools/search.py', '--local_rank=0', './configs/fna_retinanet_fpn_search.py', '--launcher', 'pytorch', '--seed', '1', '--work_dir', './', '--data_path', './coco/']' died with <Signals.SIGILL: 4>.
can you help me to fix it?
Environment:

OS: CentOS Linux release 7.4.1708
GPU: P100
Drivers: nvidia-418.43
cuda 10.0.130
cudnn  7.6.5
Python: 3.7.7
Pytorch: 1.1.0
mmdet 0.6.0
mmcv 0.2.10

Thanks!

06/26 06:47:57 PM - Start loading the model from ./seed_mbv2.pt
06/26 06:47:57 PM - Remapping for architecture adaptation starts!
06/26 06:47:57 PM - Remapping for architecture adaptation finished!
Traceback (most recent call last):
  File "/home/liqs/anaconda3/envs/py37/lib/python3.7/runpy.py", line 193, in _run_module_as_main
    "__main__", mod_spec)
  File "/home/liqs/anaconda3/envs/py37/lib/python3.7/runpy.py", line 85, in _run_code
    exec(code, run_globals)
  File "/home/liqs/anaconda3/envs/py37/lib/python3.7/site-packages/torch/distributed/launch.py", line 235, in <module>
    main()
  File "/home/liqs/anaconda3/envs/py37/lib/python3.7/site-packages/torch/distributed/launch.py", line 231, in main
    cmd=process.args)
subprocess.CalledProcessError: Command '['/home/liqs/anaconda3/envs/py37/bin/python', '-u', './tools/search.py', '--local_rank=0', './configs/fna_retinanet_fpn_search.py', '--launcher', 'pytorch', '--seed', '1', '--work_dir', './', '--data_path', './coco/']' died with <Signals.SIGILL: 4>.

It seems that the setup of the script is not so correct. It should be started by python -m torch.distributed.launch --nproc_per_node=8 ./tools/search.py ... to launch the distributed mode not python -u ./tools/search.py provided by your log.

I haven't modified the command in  scripts/arch_adapt_retinanet.sh your provided:
# !/usr/bin/env sh

python -m torch.distributed.launch --nproc_per_node=8 ./tools/search.py \
            ./configs/fna_retinanet_fpn_search.py \
            --launcher pytorch \
            --seed 1 \
            --work_dir ./ \
            --data_path ./coco/

I don't know why this is happening after running sh scripts/arch_adapt_retinanet.sh

Could you please check if mmdetection is compiled successfully by running any script of the original mmdetection?

Very helpful! It should be a failed compilation of mmdetection. I replace gcc-4.8 that i originally used with gcc-5.5, and rebuild the environment this project needs and it works. Thank you for your help!

Hi,
When I tried running the command sh scripts/arch_adapt_retinanet.sh with the model seed_mbv2.pt you provided as mentioned in README.md, I got following error,
06/26 06:47:57 PM - Start loading the model from ./seed_mbv2.pt 06/26 06:47:57 PM - Remapping for architecture adaptation starts! 06/26 06:47:57 PM - Remapping for architecture adaptation finished! Traceback (most recent call last): File "/home/liqs/anaconda3/envs/py37/lib/python3.7/runpy.py", line 193, in _run_module_as_main "__main__", mod_spec) File "/home/liqs/anaconda3/envs/py37/lib/python3.7/runpy.py", line 85, in _run_code exec(code, run_globals) File "/home/liqs/anaconda3/envs/py37/lib/python3.7/site-packages/torch/distributed/launch.py", line 235, in <module> main() File "/home/liqs/anaconda3/envs/py37/lib/python3.7/site-packages/torch/distributed/launch.py", line 231, in main cmd=process.args) subprocess.CalledProcessError: Command '['/home/liqs/anaconda3/envs/py37/bin/python', '-u', './tools/search.py', '--local_rank=0', './configs/fna_retinanet_fpn_search.py', '--launcher', 'pytorch', '--seed', '1', '--work_dir', './', '--data_path', './coco/']' died with <Signals.SIGILL: 4>.
can you help me to fix it?
Environment:

OS: CentOS Linux release 7.4.1708
GPU: P100
Drivers: nvidia-418.43
cuda 10.0.130
cudnn  7.6.5
Python: 3.7.7
Pytorch: 1.1.0
mmdet 0.6.0
mmcv 0.2.10

Thanks!

Hi there,
My environment is the same as yours but created using anaconda in Ubuntu 18.04. I have pasted a snap of the errors I am getting, please suggest the solution if possible. Thank you! Best regards.


chore: add a witness for enum_variant_missing

Similar to https://github.com/obi1kenobi/cargo-semver-checks/pull/977 (but a bit more wrong syntax gets produced)
Similar to , this is not quite correct syntax:
a query for variant would be nessesary to have the correct brackets to construct the enum (struct, vs plain vs tuple).

In this case, I think it's worth getting the variant kind right.
We can tweak the lint query by adding kind: __typename @output on the original variant which will say if it's plain / tuple / struct, and then use either no extra notation, or (...), or { ... } accordingly.
Also, it seems like the PR title got cut off maybe?

Shure. Please review, if I picked the correct query (=you did not mean witness.witness_query)
(I have also added a testcase to prove that it works)

I'm happy to merge this once CI is happy with it again.


Add support for comments

Would be nice if there was some way of commenting the source. Maybe <!-- ... --> like Markdown supports?

perhaps you can use:
[]: this is a comment

@estan , I have been using comments (in the form you suggested) for a long time already.  Have you tried it?  I do think that ronn-format(7) probably should mention this though.

Yeah, I can confirm the <!-- ... --> HTML/Markdown style comments are working. Is this still an issue?

It is not working. For example:
<!-- ## SEE ALSO -->


[WIP]OSF-Admin basic auth: User login

 Purpose:
Add basic authentication to the admin project
 To do

[x] Change back to default User (currently uses foreign key reference)
[x] Add login/registration views
[x] Add login/registration forms
[x] Add authentication logic
[x] UI

[x] Get static assets working (routing issue - waiting on Lauren's webpack PR)

[ ] Clean up code
[ ] Change db to postgres

Just some basic questions and requests. Looking good! :+1:
Remember to do a couple more things before the next commit:

inv flake8 - travis failed because of Pep8 issues
[skip ci] in your commit message - Will allow you to skip tests on travis so that it isn't doing tests on WIP PRs. That said though, it should be allowed to run before formal code reviews.
Everyday you make changes, please commit them. I don't always remember either, but it should become reflexive.

It's all about the learning through doing. :)

@Ghalko Thanks for the comments; some of these I planned to address in a commit coming in tomorrow; others I will certainly address. Appreciate the feedback, it's very helpful!

@cwisecarver Thanks for the feedback, much appreciated.
I added another subtask to clean up the code, especially the template code. A lot of it came from the adminLTE template files, but I never got around to properly formatting everything.
I will get to that and your other comments; in the meantime I will make PRs for the rest of the code

Thanks @zkraime. Let me know if you have any questions or if I've misunderstood anything.


Cleanup redocly resources

What/Why/How?
Reference
Testing
Screenshots (optional)
Check yourself

[ ] Code is linted
[ ] Tested
[ ] All new/updated code is covered with tests

Security

[ ] Security impact of change has been considered
[ ] Code follows company security practices and guidelines

delete redly resources


HELM-73: make $node template variable work in alarm queries

This PR fixes the fault-ds so it turns a node=foreignSource:foreignId criteria from a template variable into a separate set of criterias for foreign source and foreign ID.
Note: it does not solve the (probably common) issue of wanting to multi-select nodes.  That will require additional work.

Looks good - haven't tried it yet though. Can we add unit test coverage for this?

This is when I realize I should put the filtering in the datasource.buildQuery instead because it's gonna be a lot easier to test.  ;)

A couple things:

'node' isn't a field that shows up in the available list of fields, so we may want to add it there. Might be worth adding some documentation to explain what it's used for.
This doesn't work if the referenced node doesn't have a FS:FID - in this case the nodeFilter() query will just set the value as the node id

👍  (I added a note to HELM-5 w.r.t. documenting the 'node' field.)


fastlane android question

I read how to setup android with fast lane but I got a few question.For google play console how do I setup my app to be upload to google play console I have to update my app only for this tools?

Stack

Key
Value

OS
10.12.2

Ruby
2.0.0

Bundler?
false

Git
git version 2.10.1 (Apple Git-78)

Installation Source
/usr/local/bin/fastlane

Host
Mac OS X 10.12.2 (16C68)

Ruby Lib Dir
/System/Library/Frameworks/Ruby.framework/Versions/2.0/usr/lib

OpenSSL Version
OpenSSL 0.9.8zc 19 Mar 2015

Is contained
false

Xcode Path
/Applications/Xcode.app/Contents/Developer/

Xcode Version
8.2.1

System Locale

Variable
Value

LANG
en_US.UTF-8
✅

LC_ALL

LANGUAGE

fastlane files:
No Fastfile found
No Appfile found
fastlane gems

Gem
Version
Update-Status

fastlane
2.3.0
✅ Up-To-Date

Loaded fastlane plugins:
No plugins Loaded
Loaded gems

Gem
Version

slack-notifier
1.5.1

i18n
0.7.0

json
1.7.7

thread_safe
0.3.5

tzinfo
1.2.2

minitest
5.10.1

activesupport
<IP_ADDRESS>

CFPropertyList
2.3.4

claide
1.0.1

colored
1.2

nanaimo
0.2.3

xcodeproj
1.4.2

rouge
1.11.1

xcpretty
0.2.4

terminal-notifier
1.7.1

unicode-display_width
1.1.2

terminal-table
1.7.3

plist
3.2.0

public_suffix
2.0.4

addressable
2.5.0

multipart-post
2.0.0

word_wrap
1.0.0

babosa
1.0.2

highline
1.7.8

commander
4.4.2

excon
0.54.0

faraday
0.10.0

unf_ext
<IP_ADDRESS>

unf
0.1.4

domain_name
0.5.20161129

http-cookie
1.0.3

faraday-cookie_jar
0.0.6

fastimage
2.0.1

gh_inspector
1.0.2

uber
0.0.15

representable
2.3.0

retriable
2.1.0

mime-types-data
3.2016.0521

mime-types
3.1

hurley
0.2

little-plugger
1.1.4

multi_json
1.12.1

logging
2.1.0

jwt
1.5.6

memoist
0.15.0

os
0.9.6

signet
0.7.3

googleauth
0.5.1

httpclient
2.8.3

google-api-client
0.9.20

mini_magick
4.5.1

multi_xml
0.6.0

rubyzip
1.2.0

security
0.1.3

xcpretty-travis-formatter
0.0.4

dotenv
2.1.1

bundler
1.13.7

faraday_middleware
0.10.1

There's an entire section in the docs regarding this: https://docs.fastlane.tools/getting-started/android/release-deployment/
There's more information available via the Supply documentation.

You can find the supply specific documentation here 👍

Going to close this issue for now. Feel free to open a new issue with specific questions after consulting the docs @cmpetty123

I try to setup supply for fast lane in google play console.


[Admin] Publish

Docs Build status updates of commit 27d4549:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/outlook/autolaunch.md
:white_check_mark:Succeeded
View

docs/outlook/compare-outlook-add-in-support-in-outlook-for-mac.md
:white_check_mark:Succeeded
View

docs/overview/office-add-ins-community-call.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Small improvements in readme

Hi @304NotModified, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
The agreement was validated by .NET Foundation and real humans are currently evaluating your PR.
TTYL, DNFBOT;

@maartenba is there a way to enable the statistics locally? As I have seen from the code, there are some .json files (containing the stats) needed for that?

Correct. There is no good way to do this currently. The Operations projects do contain some scripts that can read from the PackageStatistics table and generate these files, however the gallery no longer writes anything to that table when a download happens.

Can't we have some (old) example statistics / json files? Because a cannot test any changes made in the stats pages.

Here are a few example files: https://www.dropbox.com/s/wol2xjk2mcz56g4/stats.zip?dl=0

@maartenba thanks! Got it working. But I had to write my own IReportService ?
Anyway, maybe a bit off topic but,

why are those files not included in the GitHub repos?
I'm a bit surprised that this information isn't in a database? IMO a database call can be cheaper then reading a (json) file.
Ever more surprised that this information isn't cached (in memory)? Or do I miss some config?

@304NotModified Let's discuss that in a separate thread. Reason is we have a slightly bigger setup that sources stats from blobs (that come from our CDN). Ideally we should log package requests into the PackageStatistics table (based on a config setting so we can turn it off for nuget.org) and create an IReportService that generates stats based on that table for local gallery installs.

OK, I will move the discussion in the future.
I will also push a new commit once the web hook has been fixed (#2715)

Just push, no need to wait for the web hook (has to be fixed but shouldnt be a requirement)


Revisions for first complete draft

Data, text, and figures are in good shape. Ready to be submitted.


Collect DH Dependency Metrics

Collect some platform details (collected once per benchmark run) for Deephaven and its dependencies.

Collect Deephaven python environment size
Collect Deephaven lib directory size
Collect top Deephaven lib size

Add these things to platform details and started using them in the prototype Adhoc Dashboard.


Wrong ABAP language version is stored for object types handled by AFF common handler

If an abapGit repository is pulled into a system and the repository's setting for the ABAP language version is set to "Any" (*), it seems that the particular value is passed to AFF object handlers and stored in the data base.
As soon as the object shall be changed again you face locking issues because ABAP language version "*"  is not supported.
If ABAP language version is set to "Ignore" (-), it seems to work (by accident), because AFF framework ignores this value as no ABAP language version is set.

See also #6663


Support for full-length YouTube URLs

Checklist

[x] I'm reporting a feature request
[x] I've verified that I'm running youtube-dl version 2<IP_ADDRESS>
[x] I've searched the bugtracker for similar feature requests including closed ones

Description

I was wondering if youtube-dl could support full YouTube URLs. For example, it supports youtube-dl https://youtu.be/limrI_1IQBk and youtube-dl limrI_1IQBk, but I was wondering if it's possible to support youtube-dl https://www.youtube.com/watch?v=limrI_1IQBk. In my opinion, I think it would be easier if people could copy the URL right from the URL bar of their browser to download a YouTube video. If there is a fix for this, please let me know. Thank you!

youtube-dl supports any kind of input form mentioned.

I am running the latest version and youtube-dl does not support youtube-dl https://www.youtube.com/watch?v=limrI_1IQBk. It tells me zsh: no matches found: https://www.youtube.com/watch?v=limrI_1IQBk

? is a special character in zsh and mumst be escaped. Read doc on your shell.


Milestone 3 Peer Feedback

suggest scaling numbers so that the MSE is more readable
the conclusion should clearly describe the final model of what features we should include and the model
you should set the airbnb price to the ones that are actually gettting booked, more important research question, differentiate which observations have a higher booking rate

-Feedback from Manuel and Zoe

Suggestion 2:

This is included in the intro; no feature selection was done so the beginning features are the final features

Suggestion 3:

This is not possible. Booking rates was not a part of the initial dataset. We also assume that in a competitive market that hosts are setting prices at market levels. Booking rate may not also be what we are optimizing for since optimal pricing is maximum profit which may involve lower than average booking rates at high prices.

Suggestion 1 addressed through update to report script that set the formatting of numerical tables through Kable


fix login issue

Resolve #4
along some commits by others that fixed things that broken this project.

Thanks @detiam, I was wondering why I was having 'login failed' errors today, and this PR fixes it. Steam must have enforced the new websocket today.
Looks good to me.


No need to generate gql-tag object, then print it to graphql-request

I have a query file like this
getRocketQuery.graphql
query getRocket($limit: Int!) {
  launchesPast(limit: $limit) {
    mission_name
  }
}

I am running with the following plugins
  src/generated/graphql.ts:
    plugins:
      - "typescript"
  src/generated/operations.ts:
    plugins:
      - "typescript-operations"
      - "typescript-graphql-request"

what gets generated is something like this
export const GetRocketDocument = gql`
  query getRocket($limit: Int!) {
    launchesPast(limit: $limit) {
      mission_name
    }
  }

export function getSdk(client: GraphQLClient) {
  return {
    getRocket(variables: GetRocketQueryVariables): Promise<GetRocketQuery> {
      return client.request<GetRocketQuery>(
        print(GetRocketDocument),
        variables
      );
    }
  };
}
`;

It seems strange that now I require two more libraries in my runtime bundle gql and print from graphql. In addition it seems like the client needs to generate an gql AST just to convert back to string at runtime.
Could this template just bypass all of this, and just create the graphql string at runtime.

@lemiesz I added an additional configuration for documentMode, now it accepts string option.
Use:
generates:
  src/generated/sdk.ts:
    config:
      documentMode: 'string'
    plugins:
      - typescript
      - typescript-operations
      - typescript-graphql-request

You should use the latest alpha (1.8.3-alpha-d0acf100.27), since it's not in a release yet.

Cool thanksalot for this man

Let's keep this open until it is released

Fixed in 1.8.3


[WFCORE-3427] Upgrade WildFly Elytron to 1.2.0.Beta10

https://issues.jboss.org/browse/WFCORE-3427

@soul2zimate -- A CI run for this PR[1] showed a failure in OperationCancellationTestCase, which I doubt is related. I've seen a couple failures reported from that class since merging the recent stuff you did. Can you have a look?
[1] https://ci.wildfly.org/viewLog.html?buildId=80835&buildTypeId=WildFlyCore_PullRequest

I will try to reproduce it locally.


How to manually register the necessary COM entries for easy custom deployments?

Hello,
With our VS deployments, to ease custom deployments of VS build tools, deploy to different/strange configurations (like Wine on linux), and also to simply understand how things work, we'd really prefer to just be able to copy a few directories, then make a couple of registry entries and be up and running like the old days.
With this new COM-based method of doing things, It sounds like this should still be possible, but I'll need to register some things with COM now rather than registry entries.
Is this process documented somewhere? If not, could it please please be done?
It would read something like this:

Copy the build tools to a target system, for e.g.:
C:\Program Files (x86)\Microsoft Visual Studio\2017\BuildTools
As well as your Window 10 kit here:
C:\Program Files (x86)\Windows Kits\10
Also copy the COM component to some-such directory and register it with some command.
Now run these COM related commands to register the presence of your VC tools and windows 10 kit:

etc
etc

(Note for most things I'm fine just doing the first step, but some tools like CMake actually use vswhere style techniques, and so they need these installation roots to be registered properly via com, or they won't be able to find the VC tools at all). Thanks!

That wasn't supported even in the "old days". A number of dependencies need to be properly installed. Without going through the installer - for any past or current version of Visual Studio and/or Build Tools - the product is not in a supported state.
Installing the product properly will install the query APIs. vswhere also supports the -legacy switch to use registry detection for Visual Studio 2010 through 2015 such that the query API does not have to be installed.

VS build tools 2017 msbuild/cl.exe/link.exe work just fine to build c/c++ projects after copying the relevant folders I mentioned to a machine and setting three or four environment variables related to the UniversalCRT. I have built many solutions and projects successfully this this way. I can ship a compiler toolchain as part of a private repository without needing to worry about deploying it everywhere. I run run msbuild/cl/link under wine. All of this works very nicely -- supported or not.
Where it breaks down is when tools like cmake become involved, as they depend upon these vswhere-like queries to find the VS installation, which depends on COM rather than at least allowing for simpler environment variable or registry entry overrides (i.e. "here's my VS installation, here's my Windows Kit" is all that is needed in many cases).
I guess I'll just switch to the ninja generator with cmake and set the INCLUDE/LIB environment variables (which does also work... I just tested it). Or I'll try to convince the cmake devs (and any other projects that will listen) to implement ways of circumventing the vswhere-like query system and by way of a set of environment variables or something so that msbuild can work again.
Sigh.

Environment variables will not be supported for reasons I've said in several other issues and in blog posts: they don't work with multi-instancing, same reason we no longer support registry-based detection. Anything using them would not be supported and subject to breaking changes.
Instead of trying to circumvent the system and deploy Build Tools on a way that has never been supported or checking in binaries to your repo (never recommended work DVCS like git), have to considered containerizing the build (you can map the source directory - many projects including docker itself build this way) or using a [supported and easy to acquire] (https://blogs.msdn.microsoft.com/vcblog/2016/04/26/stay-up-to-date-with-the-visual-c-tools-on-nuget/) method of getting the toolset you want?

Is there any reason environment variable support cannot be offered when no installations are found via the COM method? This way, the multi-instances you mentioned could be located via the COM method if present, but if none are found via this method, environment variables would be used if available (for the single instance that they point to). This would keep things simpler for those that wish to opt out of the COM deployment type and use the same simple folder form of deployment that can already be used for all other build chains on the market (ninja+clang/gcc or cmake+clang/gcc).
The other options you mentioned are not things that I will consider because they are more complicated and resource consuming than what is necessary with any other compiler toolchain on the market. I didn't even say that I'm using git, so its binary file handling is not really germane here (for e.g. P4 handles binaries just fine, and large companies have been using it that way for years... they check in their build toolchains all the time. Alternatively, a fast shared network drive with all the compiler toolchains is another popular deployment technique I've seen).

The COM APIs provide more than just the installation path and many tools rely on this information to light up features based on what packages are installed, for example.
It doesn't change the fact that copying Visual Studio this way is not and has not been supported. You've reverse engineered part of what the installation is doing but there's more that goes on such as the dockerfiles and integrations tests on this site show.

Okay, I'm just going to move to cmake+ninja+cl.exe+link.exe for my buildchains, keeping msbuild.exe out of the equation entirely. This allows things to stay simple. In the future, I'll probably just move off of cl/link based buildchains altogether and settle on clang especially once they get their windows linker in order. I'm simply not interested in any kinds of deployments that depend upon COM and don't support straightforward environment variable based setups.


Fix xaxis font

Hi,
This fixes an issue where the drawing of the X axis labels ignores the given axisColor style at certain angles.
This becomes very obvious e.g. when modifying the basic example with:
   var options = {
        axisFontSize: 24,
        axisColor: '#aDaDaD',
        showPerspective: false,
        cameraPosition: {horizontal: 0, vertical: 1.7, distance: 2},
    };

For Y/Z the issue did not manifest (even though the code has the same issue) because by then the style is set on the context from before.
I also noticed some additional inconsistencies in the code (that are not fixed by this PR):
drawAxisLabelXRotate sets ctx.textAlign, ctx.textBaseline and modifies point2d.y after drawing the text and right before restoring the context (first if case). So these lines will have no effect.
It should probably be changed to set these properties explicitly before drawing the text. From console.log I know that it is currently implicitly using ctx.textAlign == 'left' and ctx.textBaseline == 'alphabetic' in my tests, but it may be different depending on the environment. Similar issue in drawAxisLabelYRotate.

The other issues you mentioned look really weird too. Do you plan to open another PR for them? And thank you in advance if you do.


Unexpected behaviour UILabel's width with '.greaterThanOrEqualTo'.

New Issue Checklist

[x] I have looked at the Documentation
[x] I have read the F.A.Q.
[x] I have filled out this issue template.

Issue Info

Info
Value

Platform
iOS

Platform Version
11.3.1

SnapKit Version
5.0.1

Integration Method
Cocoapods

Issue Description
I'm expecting a UILabel to resize to its intrinsic content size when constraining it to the superview's center, with leading and trailing constraints relation set to 'Greater Than Or Equal'. Instead, SnapKit displays the UILabel in full width. I've created an example with Storyboard and Snapkit, both having the same constraints. Am I missing something here?
SnapKit code:
class SnapKitExampleViewController: UIViewController {

    override func viewDidLoad() {
        super.viewDidLoad()

        let snapKitLabel = UILabel()
        snapKitLabel.text = "SnapKit example"
        snapKitLabel.textColor = .white
        snapKitLabel.backgroundColor = .purple
        self.view.addSubview(snapKitLabel)

        // Setup constraints.
        snapKitLabel.snp.makeConstraints { (make) in
            make.center.equalTo(self.view.safeAreaLayoutGuide)
            make.leading.greaterThanOrEqualTo(self.view.safeAreaLayoutGuide).offset(15)
            make.trailing.greaterThanOrEqualTo(self.view.safeAreaLayoutGuide).offset(-15)
        }
    }

}

With Storyboard constraints (expected behaviour):

With SnapKit constraints (unexpected behaviour):

@thomasneuteboom could you please also add an example recreated with NSLayoutConstraints?

Hi @martinpucik, thanks for your reply! I tested it with standard NSLayoutConstraint's and the problem seems to persist. Apparently it has nothing to do with SnapKit. I'll address this issue somewhere else. Thank you.

You have incorrect trailing constraint. It should be:
make.leading.greaterThanOrEqualTo(self.view.safeAreaLayoutGuide).offset(15)
make.trailing.lessThanOrEqualTo(self.view.safeAreaLayoutGuide).offset(-15)


Upload feature request

Hello developers!
I would like to add a upload feature there. I think it would be great if users can upload some files into server. Integrate interface to upload files without additional connection like, ftp, scp... . If users want to add some file, they don't need to use additional system.
What do you think about it?

This is a great thought, however, file uploading is out of the scope for this project. While the idea of adding uploads to Directory Lister sounds like a good idea it would add a lot of complexity for the developers (i.e. me) and the users. Additionally, uploads would increase the chance of security risks substantially. The intent of Directory Lister has always been to keep things simple, straight forward and as secure as possible and file uploads does not fit this intent.


Bluepill fails

bluepill version: 5.8.0
xcode version: 12.4
run bluepill -c config.json
{
   "xctestrun-path": "./output/Build/Products/xxx_iphonesimulator14.4-x86_64.xctestrun",
   "output-dir": "./output/bluepill/",
   "runtime": "iOS 14.4",
   "num-sims": 6
}

2021-03-04 11:58:18.372 bluepill[8104:2796488] Debug Enabled == 0
{8104} 20210304.115819 [  INFO  ] (BLUEPILL) Using xctestrun configuration
{8104} 20210304.115819 [  ERROR ] (BLUEPILL) Could not extract bundleID: (null)
2021-03-04 11:58:19.805 bluepill[8104:2796488] *** Terminating app due to uncaught exception 'NSInvalidArgumentException', reason: '*** -[__NSDictionaryM setObject:forKeyedSubscript:]: key cannot be nil'
*** First throw call stack:
(
	0   CoreFoundation                      0x00007fff204876af __exceptionPreprocess + 242
	1   libobjc.A.dylib                     0x00007fff201bf3c9 objc_exception_throw + 48
	2   CoreFoundation                      0x00007fff2053ba9a -[__NSCFString characterAtIndex:].cold.1 + 0
	3   CoreFoundation                      0x00007fff20547a1f -[__NSDictionaryM setObject:forKeyedSubscript:].cold.2 + 0
	4   CoreFoundation                      0x00007fff203d587e -[__NSDictionaryM setObject:forKeyedSubscript:] + 999
	5   bluepill                            0x00000001048e5439 +[BPXCTestFile BPXCTestFileFromDictionary:withTestRoot:andXcodePath:andError:] + 1777
	6   bluepill                            0x00000001048d1056 +[BPApp testsFromXCTestRunDict:andXCTestRunPath:andXcodePath:withError:] + 574
	7   bluepill                            0x00000001048d160e +[BPApp appWithConfig:withError:] + 1049
	8   bluepill                            0x00000001048c8689 main + 971
	9   libdyld.dylib                       0x00007fff20330631 start + 1
)
libc++abi.dylib: terminating with uncaught exception of type NSException
fish: 'bluepill -c config.json' terminated by signal SIGABRT (Abort)

@AlexanderPan We use Bazel variant which uses test-plan-path instead of xctestrun-path and v5.8.0 works fine. Let me try the Xcode version using xctestrun-path and get back to you. Meanwhile, can you examine the contents of file referred by bp/src/SimulatorHelper.m#L157 and why the NSDictionary is coming out to be (null) for you?

@AlexanderPan  would you be able to share a redacted version of this file:
"./output/Build/Products/xxx_iphonesimulator14.4-x86_64.xctestrun" ?

@chenxiao0228
    -enableCodeCoverage YES \
    -workspace xxx.xcworkspace \
    -scheme xxxUITests \
    -destination "platform=iOS Simulator,name=iPhone 12 Pro Max" \
    -configuration Tests \
    -derivedDataPath 'output/' \
    | xcpretty

iphonesimulator14.4-x86_64.xctestrun.zip

@ravimandala
I don't know which Info.plist to check kCFBundleIdentifierKey.
Could you provide path let me check?

@ravimandala
https://github.com/linkedin/bluepill/blob/master/bp/src/BPXCTestFile.m#L171
My .xctestrun file DependentProductPaths contains apple watch extension.
at TESTROOT/Tests-iphonesimulator/AppleWatchBarImg not found Info.plist.

@ravimandala i am building my app using the following command:
bazelisk build --config=Debug /MyApp
What is the value I need to use for test-plan-path
I am able to generate .xctestrun for  xctestrun-path but I am not sure what the value is for the key test-plan-path


Support for 2021.3.5s

Title says it all. I love this mod that removes the need for swapping layout all the time, and I miss it. :)

Hi, the mod has been updated for 2021.3.31s (Airship update), enjoy :)


Split extendRead() for ezc3d vs BTK

@carmichaelong @pariterre I thought we could just fully duplicate extendRead(). What do you think?

I did a diff between the ezc3d and btk portions of the file from this PR to see how different they were. I think they differ enough that I prefer this version.
Only minor thing would be on L45 would be to add a comment that the #else is for BTK, as seen on L339.

TGDM (I will add the comment in my own branch and push it in the opensim PR


Need spurious bind to make function check

assume val p : int
assume val q : int
assume val foo : int -> slprop
assume val lem () : Lemma (foo p == foo q)

ghost
fn test ()
  requires foo p
  ensures  foo q
{
  lem();
  // ()
}

This function fails to check:
- Cannot prove:
    foo q
- In the context:
    foo p

But uncommenting the extra (), or doing anything, will make it work. I think without it, the lemma is not eliminated into the context and so is not in scope for the query foo p == foo q.

Yes, I believe that's because we only run the elimination logic at the beginning of a statement, not after it.  https://github.com/FStarLang/pulse/blob/0b457c21b9bfe383275ac3f33a87b1eefd75231a/src/checker/Pulse.Checker.fst#L149-L154
It's the same reason why you have to write (); show_proof_state instead of show_proof_state.


Modify mruby-sys build to only generate sources and compile with cc crate.

mruby-sys depends on the mruby build for codegen and compilation, and linking. This requires a fairly massive dependency on a clang toolchain. We can avoid this by modifying our build configuration to only depend on mruby build for source generation and use the cc crate to build the generated sources.
Compiling with the cc crate instead of using minirake to compile gives several advantages:

avoids dependency on clang installation
gives cross builds for free
gives wasm32-unknown-unknown target support for free.

We can do this by replacing the conf.cc.command, conf.linker.command, and conf.ar.command with /usr/bin/true.
See GH-137.

I have a branch that experiments with this idea here: https://github.com/artichoke/artichoke/tree/mruby-sys-build
Able to build, but the playground fails to load and cargo test fails to compile mruby-sys.


Migrate application to ModusToolbox 3.0 format

Apply Makefile modifications required for ModusToolbox 3.0 compatibility (set MTB_TYPE)
Cleanup comments and docs in README.md and Makefile
Delete fix-sdk-cc-files.sh and duplicated *.cpp files

@vmedcy thank you for the good collaboration and this valuable contribution 🏅


No way of retrieving the url of a video recorded

Hello,
Currently the play services recording api has no means to retrieve the url of the shared video.
We plan to incentivize users to record their play but it is mandatory that we can :
1-Get confirmation of the share.
2-Get the actual url of the share so that we can create a sort of leaderboard with the recording of the best players.
Please add such feature to the service.
Thanks
Regards
Chris

Thanks for the feedback!

I confirmed that there is no way to get the URL of the shared video back.  One idea is to also integrate the YouTube API and search for the video to get a playable link?

And what would you search? You don't have any data at all on the shared video.

Good point. I guess you could prompt the player for the title or something in order to get the reward.  Alternatively, the video is stored locally on the device and you upload it using the API and you would know more about the metadata (but that does lessen the value of the recording API....).

How does it currently upload the video? Doesn't it use youtube api already?
If it does isn't enough to implement the callback to receive the uploaded video details?

Thanks

So, go anything cooking on this issue for next versions?

So has there been any progress on this?

Any feedback would be welcome, it has been more than 1 year without answers

Has this feature been abandoned?


IoT extension 0.9.4 release (Digital Twins content release)

This checklist is used to make sure that common guidelines for a pull request are followed.

For new extensions:

[ ] My extension description/summary conforms to the Extension Summary Guidelines.

About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update src/index.json automatically.
The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify src/index.json.

If this PR is for a new extension or change to an existing extension, use the following to try out the changes in this PR:
docker run -it microsoft/azure-cli:latest
export EXT=<NAME>
pip install --upgrade --target ~/.azure/cliextensions/$EXT "git+https://github.com/digimaun/azure-cli-extensions.git@iotext094#subdirectory=src/$EXT&egg=$EXT"


Core TODO

This will be our TODO list for the Core. Layout:
##################################

One line description.

List of related PRs and issues

##################################

Fix the time format for the MCLogger.
Add catalog.json applier class.

Put it in the projects.

@liach dont have access to projects (not part of MinigameCore org)


Make sure we do not use SP1 node for cinder-volume

See e.g. https://ci.suse.de/job/openstack-mkcloud/31710/

It would be better to take SP2 node out from that $unclustered_nodes, but this is faster and IMHO sufficient. Also, $sles12plusnode is the last SP2 node so it likely is also not part of cluster

+1

+1

+1


Development environment question

Hello, I hope you don't mind me asking here. I am working on a cross-platform Taiwanese IME. I am struggling to set up a reasonable development environment for Mac OSX. Do you have some ways to develop the app without logging out and logging in every time to use the new build? Do you have any way to debug the IME besides simple text logging? I've looked through your repo a bit but I did not find any solutions, so I thought I would ask.
Thanks

Thank you, I already saw that article, but for me it seems I am unable to rebuild and use the new code without logging out and logging in again. Also, the article mentions that it's not possible to debug, so I guess this is correct?

I guess there's no way to use Xcode to debug the IME, logging is the only way.
For the rebuild issue, I think killing the old IME running instance before replacing it may help, not sure.
As an example, here is the command line to quit the Jyutping IME:
osascript -e 'tell application id "org.jyutping.inputmethod.Jyutping" to quit'

That was my missing step. Seems like a simple killall -9 works just fine. Great, well at least with file logging and being able to reload without logging out, I can actually do some work. Thanks for the tip!


What is hparams exactly?

Hi, thanks for the nice product again.
From #525 and #599, I could guess that hparams is required to load a saved model (which I think should be mentioned somewhere in the doc btw). And from the examples, seems like hparams may be argparse.Namespace. Unfortunately though, it was not so easy to understand the concept.
What is hparams exactly? What kind of information it should/can/should not include to work properly? Is it recommended to use hyperparameter argument parser? Say, if I'm not into hyperparameter search at the moment and just want to be able to load the checkpoint model, what is the requirement on the hparams?

hparams is just a dict that contains your hyperparameters for easy logging and experiments. It is optional, but it does make loading models more tedious.

It should be an argparse.Namespace. You can get this from argparse, testtube's HyperOptArgumentParser, or create it manually from a dict like so: argparse.Namespace(**my_dict).

@s-rog Thanks, but it's not a dict :-)
@neggert Thanks. Yes those are the info I could assume by reading code etc. But I think those and probably more details should be documented somewhere. I'd like to contribute, but I can't document something I don't know clearly.
Also, in my opinion, it should be very strongly recommended to use it so that they can load the model later, assuming the use cases of pytorch-lightning would be more serious than just training something on MNIST. Because, for those toy example, why bother :)

oh yeah I keep forgetting, you're right!

Yes, there's a complete overhaul of the docs in progress. We'll make sure this gets in there.


qpy roundtrip for FourierChecking fails with TypeError: DiagonalGate.init() takes 2 positional arguments but 5 were given

Environment

Qiskit Terra version: 0.24.1
Python version: 3.10
Operating system: NixOS 23.11

What is happening?
This is likely because the named gate (DiagonalGate) is not explicitly supported in the gates in the following code branch: https://github.com/Qiskit/qiskit-terra/blob/e9f8b7c50968501e019d0cb426676ac606eb5a10/qiskit/qpy/binary_io/circuits.py#L282-L289
How can we reproduce the issue?
import io
from qiskit import qpy
import qiskit.circuit.library as qcl

def encode(qc):
    with io.BytesIO() as f:
        qpy.dump(qc, f)
        # Rewind back to the beginning of the "file".
        f.seek(0)
        serialized = f.read()
    return serialized

def decode(data):
    with io.BytesIO(data) as f:
        circuits = qpy.load(f)
    return circuits[0]

# Works
decode(encode(qcl.QFT(3)))
# Doesn't work
decode(encode(qcl.FourierChecking([1, -1, -1, -1], [1, 1, -1, -1])))

What should happen?
The error message should have said that the DiagonalGate is not supported when it is not covered by the if-else checks in the _read_instruction.
Any suggestions?
No response

The traceback:
Traceback (most recent call last):
  File "/qiskit_bug_report.py", line 21, in <module>
    decode(encode(qcl.FourierChecking([1, -1, -1, -1], [1, 1, -1, -1])))
  File "/qiskit_bug_report.py", line 15, in decode
    circuits = qpy.load(f)
  File "/home/rht/code/venv/lib/python3.10/site-packages/qiskit/qpy/interface.py", line 269, in load
    loader(
  File "/home/rht/code/venv/lib/python3.10/site-packages/qiskit/qpy/binary_io/circuits.py", line 932, in read_circuit
    custom_operations = _read_custom_operations(file_obj, version, vectors)
  File "/home/rht/code/venv/lib/python3.10/site-packages/qiskit/qpy/binary_io/circuits.py", line 423, in _read_custom_operations
    definition_circuit = common.data_from_binary(
  File "/home/rht/code/venv/lib/python3.10/site-packages/qiskit/qpy/common.py", line 261, in data_from_binary
    obj = deserializer(container, **kwargs)
  File "/home/rht/code/venv/lib/python3.10/site-packages/qiskit/qpy/binary_io/circuits.py", line 934, in read_circuit
    _read_instruction(file_obj, circ, out_registers, custom_operations, version, vectors)
  File "/home/rht/code/venv/lib/python3.10/site-packages/qiskit/qpy/binary_io/circuits.py", line 289, in _read_instruction
    gate = gate_class(*params)
TypeError: DiagonalGate.__init__() takes 2 positional arguments but 5 were given

Thanks for the report.  The fix should be a case of adding the string "diagonal" to the check of line 282 in your code link - DiagonalGate is an old gate that has its constructor and params fields behave in slightly different ways to most Qiskit gates.

Let me resolve it by adding diagonal


Add demo: different transition per clicked anchor

Added demo solving #143.

Thanks for the support @bfncs!

I'm glad I could help you out here. Keep up the good work!


build: go get goveralls

We were missing goveralls and Travis wasn't even telling us of the
error. Bad Travis, bad!
Signed-off-by: Damien Lespiau<EMAIL_ADDRESS>

Changes Unknown when pulling ff5f3951e148282c3284fff2f34bd29d40735462 on dlespiau:20170202-coveralls-fix into ** on clearcontainers:master**.

\o/

lgtm! ;)

LGTM


Updated Willow to v12 and Seaside to v3.3.3

Coverage remained the same at 98.8% when pulling 9c61830d859f03f13235eff4b06bee58fdc0213d on update_dependencies into 5563d3c0ce0ddce66004acedb6e131a4b1944f8a on release-candidate.


About performance of LLama (llama2, llama3) model

Thank you for your wonderful work!
Have you ever experimented with LLama2-7B as the model to do C-RLFT? How about the performance? Because OpenChat-3.5-0106 is based on Mistral, performance is really high, I have tried using LLama2-7B, the performance is not satisfied.
Another 2 questions: can chat model be used as the model to do C-RLFT? I think, some code needs to be done, e.g., chat template, etc.
How about LLama3-8B-instuct, how to easy train, any performance data?
Thanks in advance.

Hi @huazhenliu We've tried Llama 2 13B, the performance is worse than Mistral 7B, so we've chosen Mistral 7B as the base model.

For your second question, it's OK. We can do C-RLFT on any model. You can edit the chat template here https://github.com/imoneoi/openchat/blob/master/ochat/config/init.py
We're actively working on a new version based on Llama-3-8B


HOTFIX: rename run_test to execute in streams simple benchmark

Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

Triggered https://jenkins.confluent.io/job/system-test-kafka-branch-builder/1736
cc @ijuma

Build succeeded, will merge to trunk now.


Error "Unknown method 'params'" when running cocoapods with clean_install:true

New Issue Checklist

[X] Updated fastlane to the latest version
[X] I read the Contribution Guidelines
[X] I read docs.fastlane.tools
[X] I searched for existing GitHub issues

Issue Description
Saw a "Deprecated" notice when I was using the clean flag, so tried to migrate to clean_install but I keep getting this "Unknown method 'params'" error message... Already tried reinstalling fastlane, cocoapods & bundler, but it doesn't seem to make a difference.
Command executed
fastlane run cocoapods clean_install:true
Complete output when running fastlane, including the stack trace and command used

 DEBUG [2020-02-01 16:17:11.99]: Checking if there are any plugins that should be loaded...
DEBUG [2020-02-01 16:17:12.12]: Using clean_install: true
INFO [2020-02-01 16:17:12.13]: -----------------------
INFO [2020-02-01 16:17:12.13]: --- Step: cocoapods ---
INFO [2020-02-01 16:17:12.13]: -----------------------
INFO [2020-02-01 16:17:12.15]: gem 'cocoapods' is already installed
ERROR [2020-02-01 16:17:12.15]: Unknown method 'params'

Environment

✅ fastlane environment ✅
Stack

Key
Value

OS
10.15.2

Ruby
2.4.5

Bundler?
false

Git
git version 2.21.0 (Apple Git-122)

Installation Source
~/.rbenv/versions/2.4.5/bin/fastlane

Host
Mac OS X 10.15.2 (19C57)

Ruby Lib Dir
~/.rbenv/versions/2.4.5/lib

OpenSSL Version
OpenSSL 1.0.2q  20 Nov 2018

Is contained
false

Is homebrew
false

Is installed via Fabric.app
false

Xcode Path
/Applications/Xcode.app/Contents/Developer/

Xcode Version
11.1

System Locale

Variable
Value

LANG
en_GB.UTF-8
✅

LC_ALL

LANGUAGE

fastlane files:
`./fastlane/Fastfile`
fastlane_version '2.117.1'
identifier = CredentialsManager::AppfileConfig.try_fetch_value(:app_identifier)

platform :ios do
  desc 'Fetch certificates and provisioning profiles'
  lane :certificates do
    match(app_identifier: identifier, type: 'development', readonly: false)
  end
end

`./fastlane/Appfile`
app_identifier "com.mycompany.app"
apple_id<EMAIL_ADDRESS>package_name "com.mycompany.app"

fastlane gems

Gem
Version
Update-Status

fastlane
2.141.0
✅ Up-To-Date

Loaded fastlane plugins:
No plugins Loaded
Loaded gems

Gem
Version

did_you_mean
1.1.0

slack-notifier
2.3.2

atomos
0.1.3

CFPropertyList
3.0.2

claide
1.0.3

colored2
3.1.2

nanaimo
0.2.6

xcodeproj
1.14.0

rouge
2.0.7

xcpretty
0.3.0

terminal-notifier
2.0.0

unicode-display_width
1.6.1

terminal-table
1.8.0

plist
3.5.0

public_suffix
2.0.5

addressable
2.7.0

multipart-post
2.0.0

word_wrap
1.0.0

tty-screen
0.7.0

tty-cursor
0.7.1

tty-spinner
0.9.3

babosa
1.0.3

colored
1.2

highline
1.7.10

commander-fastlane
4.4.6

excon
0.72.0

faraday
0.17.3

unf_ext
<IP_ADDRESS>

unf
0.1.4

domain_name
0.5.20190701

http-cookie
1.0.3

faraday-cookie_jar
0.0.6

faraday_middleware
0.13.1

fastimage
2.1.7

gh_inspector
1.1.3

mini_magick
4.10.1

multi_xml
0.6.0

rubyzip
1.3.0

security
0.1.3

xcpretty-travis-formatter
1.0.0

dotenv
2.7.5

bundler
2.1.4

naturally
2.2.0

simctl
1.6.7

jwt
2.1.0

uber
0.1.0

declarative
0.0.10

declarative-option
0.1.0

representable
3.0.4

retriable
3.1.2

mini_mime
1.0.2

multi_json
1.14.1

signet
0.12.0

memoist
0.16.2

os
1.0.1

googleauth
0.10.0

httpclient
2.8.3

google-api-client
0.36.4

google-cloud-env
1.3.0

google-cloud-errors
1.0.0

google-cloud-core
1.5.0

digest-crc
0.4.1

google-cloud-storage
1.25.1

emoji_regex
1.0.1

openssl
2.0.9

json
2.3.0

io-console
0.4.6

psych
2.2.2

generated on: 2020-02-01

What version of cocoapods are you using?

$ pod --version
1.8.4

Versions >1.7 should have and use clean_install, so you should be good there.
Can you run with --verbose and post the complete output please?

There is actually a PR that seems to fix this problem: https://github.com/fastlane/fastlane/pull/15947

Ah great 👍, missed that one, only checked the issues.


Rollup dependency resolution error on installation

The following dependency resolution error was encountered while trying to checkout and install the backend and subsequent calls to npm run build fail due to rollup not being installed:
npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR!
npm ERR! While resolving<EMAIL_ADDRESS>npm ERR! Found<EMAIL_ADDRESS>npm ERR! node_modules/rollup
npm ERR!   rollup@"*" from the root project
npm ERR!   peerOptional<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR!   node_modules/@rollup/plugin-babel
npm ERR!     @rollup/plugin-babel@"*" from the root project
npm ERR!   5 more (@rollup/plugin-inject, @rollup/plugin-json, ...)
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peerOptional<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR! node_modules/@rollup/plugin-commonjs
npm ERR!   @rollup/plugin-commonjs@"*" from the root project
npm ERR!
npm ERR! Conflicting peer dependency<EMAIL_ADDRESS>npm ERR! node_modules/rollup
npm ERR!   peerOptional<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR!   node_modules/@rollup/plugin-commonjs
npm ERR!     @rollup/plugin-commonjs@"*" from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.

Environment:
OS: MacOS Monterey
Node: 18.9.0
NPM: 9.2.0

According to the README found here, the minimum rollup version required is Rollup v2.68.0 for plugin-commonjs v23.0.7

Which NodeJS version are you using?
We have some known dependency problems which relate to the fact that there is incorrect version definitions in the uglifyjs plugin. Newer NodeJS/NPM breaks because of these. This might be another issue though.

Which NodeJS version are you using?
We have some known dependency problems which relate to the fact that there is incorrect version definitions in the uglifyjs plugin. Newer NodeJS/NPM breaks because of these. This might be another issue though.
Workaround could be to use v14 for installation and switch to v18 after that.

So the issue appears to be that the following dependencies can manage with rollup versions below 2.68 (unlike plugin-commonjs)
node_modules/rollup
  rollup@"*" from the root project
  peerOptional<EMAIL_ADDRESS>from<EMAIL_ADDRESS>  node_modules/@rollup/plugin-babel
    @rollup/plugin-babel@"*" from the root project
  peerOptional<EMAIL_ADDRESS>from<EMAIL_ADDRESS>  node_modules/@rollup/plugin-inject
    @rollup/plugin-inject@"*" from the root project
  peerOptional<EMAIL_ADDRESS>from<EMAIL_ADDRESS>  node_modules/@rollup/plugin-json
    @rollup/plugin-json@"*" from the root project
  peerOptional<EMAIL_ADDRESS>from<EMAIL_ADDRESS>  node_modules/@rollup/plugin-replace
    @rollup/plugin-replace@"*" from the root project
  peer<EMAIL_ADDRESS><2" from<EMAIL_ADDRESS>  node_modules/rollup-plugin-uglify
    rollup-plugin-uglify@"*" from the root project
  peerOptional<EMAIL_ADDRESS>from<EMAIL_ADDRESS>
Some of the above are compatible with 2.68+ but I guess the uglify one cannot?

Workaround could be to use Node v14 for installation and switch to v18 after that -- but of course needs to be fixed

I'll try using Node 14 for installation for now :). Thanks JHH :)

Yeah, uglifyjs plugin is actualy compatible but it is so old that it has incorrectly defined compatiblity settings

Is it this dependency that should be looked at?
peer<EMAIL_ADDRESS><2" from<EMAIL_ADDRESS>node_modules/rollup-plugin-uglify
rollup-plugin-uglify@"*" from the root project

I'll create a fork of it once I get to my workstation

I can confirm that this relates to Node v18. It doesn't fail with v14.

I had some issues trying to install node 14 on my Mac OS Monterey machine (via nvm). It seems the dev Gods do not want me to install this... at least today :)

I have a fix now for v18.
There's another issue, I'll update our templates.

I had some issues trying to install node 14 on my Mac OS Monterey machine (via nvm). It seems the dev Gods do not want me to install this... at least today :)

Yeah, I installed it using NVM and it actually compiled it there. (v18 did not need compiling.) :)

In order to install Node 14 on my Mac I needed to run this first
arch -x86_64 zsh
nvm install 14

I guess the M1 Macs need to run Rosetta for node versions < 15

In order to install Node 14 on my Mac I needed to run this first
arch -x86_64 zsh
nvm install 14

I guess the M1 Macs need to run Rosetta for node versions < 15

No, I don't think so...
$ file /Users/jhh/.nvm/versions/node/v18.12.1/bin/node
/Users/jhh/.nvm/versions/node/v18.12.1/bin/node: Mach-O 64-bit executable arm64

I have also it installed from the official site globally as v14.

Did you have full compile system installed? That might be the case; I have full xcode toolset so it could find a C++ compiler and compile that natively :D

No. I was just thinking that I should installed a C/C++ compiler as it did not find one during the setup. I haven't been actively using Macs for development for about 6 years so I'm still a bit rusty with how OSX works these days

I am almost done with the fixed version for this issue.
Btw you might be interested about his: https://github.com/heusalagroup/hg-dashboard -- it is a complete full stack project template. We don't have an installer for that yet though.

This issue has been fixed with version v1.0.5:
https://www.npmjs.com/package/@heusalagroup/create-backend


React JS incompatible

I want to use this library with React (and Next.JS). But I got error:
Module not found: Error: Can't resolve 'fs'
Steps to reproduce:

Create fresh React app: yarn create react-app my-app --template typescript
Add zk-merkle-tree dependency yarn add zk-merkle-tree
Import zk-merkle-tree in src/App.tsx: import {generateCommitment} from "zk-merkle-tree"
Call generateCommitment:

useEffect(() => {
    generateCommitment().then()
  }, [])

src/App.tsx full file example
5. Start project yarn start
6. Get errors:
ERROR in ./node_modules/ejs/lib/ejs.js 46:9-22
Module not found: Error: Can't resolve 'fs' in '<...>/node_modules/ejs/lib'
And much more, here is full error message

I don't use ejs directly (you can check it here: https://github.com/TheBojda/zk-merkle-tree/tree/main/src ), so it should be a dependency of one of the dependencies.
In my sample Vue project (https://github.com/TheBojda/zktree-vote) I used parcel that maybe emulates the nodejs functions that are used (https://parceljs.org/features/node-emulation/).
I'm not really familiar with next.js and the build system that uses (webpack?) but maybe this node emulation could help.


use the fallback on the GPU

this gives up the extended precision, but should fix #67

@ChrisRackauckas can you check if that helps your example?

Yes, I can check on Monday.

Works


[5.1] Adding getter methods for raw tags and extensions

We need them when we want to extend BladeCompiler and we want to use global settings of Blade that usually we write them in a custom provider for examples: extend blade or
public function register()
{
Blade::setRawTags('{{', '}}');
Blade::setContentTags('{{{', '}}}');
Blade::setEscapedContentTags('{{{', '}}}');
}
Please accept, thanks.

Thanks. Sorry about comments. My English is not very professional;)


Stack level too deep with Rake

rails new EnsureTest
edit Gemfile, add
gem "ensure-encoding", :git => "https://github.com/Manfred/Ensure-encoding.git"
bundle install
rake
Error:
rake aborted!
stack level too deep

I don't think i'ts related to running on Windoze.
I'm running Ubuntu 11.04 (Natty) and I get the error  when i do  rake db:create


Fix migration v96 to keep issue attachments

As title.
Closes #8434

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@3810fa4). Click here to learn what that means.
The diff coverage is 0%.

@@           Coverage Diff            @@
##             master   #8435   +/-   ##
========================================
  Coverage          ?   41.8%
========================================
  Files             ?     497
  Lines             ?   65631
  Branches          ?       0
========================================
  Hits              ?   27437
  Misses            ?   34678
  Partials          ?    3516

Impacted Files
Coverage Δ

models/migrations/v96.go
0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3810fa4...08cfb1e. Read the comment docs.


Borders on empty cells

I'm trying to add borders on all cells, including empty ones. Here is the code I tried to use:
var borderStyles = {
  top: { style: "thin" },
  left: { style: "thin" },
  bottom: { style: "thin" },
  right: { style: "thin" }
};

worksheet.eachRow({ includeEmpty: true }, function(row, rowNumber) {
  row.eachCell({ includeEmpty: true }, function(cell, colNumber) {
    cell.border = borderStyles;
  });
});

I thought that using { includeEmpty: true } would do this for me, but it doesn't seem to work, as you can see here:

I want the gaps in between the sections to have borders as well. I made those gaps by doing addRow and passing it an empty object {}, could that be causing an issue?
Or is there any other way to get borders to appear on all cells?

I am facing the same problem... I found a workaround by placing empty strings to force values on cells. It works this way, although it's causing me trouble with cell merging in MS Excel
if (!cell.value) {
cell.value = '';
}

Yup, that's the workaround I went with as well. Not very pretty, but it worked :/
And yeah, I didn't have to do any cell merging but I see how that would be an issue

So... any update on this problem? I'm trying to create border on empty cells too and I cant do it :( (Without using the trick of adding '' character)

I managed to get this working by tweaking the code locally. I hope to get a PR open by mid next week.
The basic problem is that there are several places in the codebase where it checks to see if a cell has a type of Enum.ValueType.Null and if it does, it doesn't include it in the final render, presumably as an optimization. This is, of course, problematic when that cell still have styles applied to it, despite being empty.
The short summary of my local changes is that I:

Removed the if (cell.type != Enum.ValueType.Null) check in the get model() accessor in row.js
Removed the spans="<%=row.min%>:<%=row.max"> attribute in the row section of sheet.xml since I had a hard time getting the min and max there to actually work (spans is an optional optimization attribute anyway).
Added a default: case to the switch (cell.type) statement in xlsx.js to do the same thing it was already doing for case Enums.ValueType.Merge.

Found a better way.
Instead of using:
worksheet.eachRow({ includeEmpty: true }, function(row, rowNumber) {
  row.eachCell({ includeEmpty: true }, function(cell, colNumber) {
    cell.border = borderStyles;
  });
});

Try using it like this:
worksheet.eachRow({ includeEmpty: true }, function(row, rowNumber) {
  row.border = borderStyles;
});

As a bonus it is probably faster because you are only setting one property instead of iterating of all the cells.

Any news on "Setting borders on empty cells" ?
Found nothing new except above PR but still having the same issue

this worked for me. It will set the border for the specific data table.
        worksheet.eachRow((cell, rowNumber) => {
            worksheet.getRow(rowNumber).eachCell({includeEmpty:true}, (cell_v, colNumber) => {
                if(colNumber <= worksheet.columnCount) {
                    cell_v.border = this.borderStyles;
                }
            })
        })


[bug] Some strings are handled as booleans instead of strings

Describe the bug/feature
I needed an environment variable with the value of Y in one of my kubernetes templates. When I tried to generate it based on the followin jsonnet snippet:
env+: [
  { name: 'ACCEPT_EULA', value: 'Y' },
]
...

It gets rendered by kapitan as :
- name: ACCEPT_EULA
  value: Y

This yaml is not accepted by kubectl/Kubernetes because it expects a string value here and apparently the Y character (without quotes) is treated as a boolean instead of a string somewhere during the processing of kapitan :
for: "compiled/euw-ci/manifests/sql-server-deployment.yml": unrecognized type: string
See https://yaml.org/type/bool.html on which strings are treated as booleans
Expected behavior
String values like 'Y' should be rendered as 'Y' in the output file, or at least there must be a way to escape the current behaviour.

This is very likely caused by a bug in PyYaml
https://github.com/yaml/pyyaml/issues/247
It does the right thing for all variations listed on https://yaml.org/type/bool.html, expect for the single char Y or N
$ kapitan eval --output yaml <(echo '{ "value": "yes" }')
value: 'yes'

$ kapitan eval --output yaml <(echo '{ "value": "Y" }')
value: Y

I'm closing this as this is not a bug and is indeed the expected behavior.