Trim leading and trailing space from email/phone input in new contact method page

@Santhosh-Sellavel @luacmartins PR is ready for review.
Details
Within new contact method page it allows save email/phone with leading and trailing space, so within ui leading/tariling spaces makes improper indentation while display.  Within this pr we updated logic, so during save it will trim leading/trailing space from the login input.
Fixed Issues
$ https://github.com/Expensify/App/issues/17770
PROPOSAL: https://github.com/Expensify/App/issues/17770#issuecomment-1517469634
Tests

Go to Settings -> Profile -> Contact methods
Click on "New contact method" button
Add email/phone with leading and trailing spaces e.g “<EMAIL_ADDRESS> ”
Tap Add button
Now, it will go back to "Contact methods" page
Verify that leading/trailing spaces does not show while display email/phone number.

[x] Verify that no errors appear in the JS console

Offline tests

Go to Settings -> Profile -> Contact methods
Click on "New contact method" button
Add email/phone with leading and trailing spaces e.g “<EMAIL_ADDRESS> ”
Tap Add button
Now, it will go back to "Contact methods" page
Verify that leading/trailing spaces does not show while display email/phone number.

QA Steps

Go to Settings -> Profile -> Contact methods
Click on "New contact method" button
Add email/phone with leading and trailing spaces e.g “<EMAIL_ADDRESS> ”
Tap Add button
Now, it will go back to "Contact methods" page
Verify that leading/trailing spaces does not show while display email/phone number.

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web
Chrome

Safari
https://user-images.githubusercontent.com/7823358/233762095-fc0a9dd8-07dd-4415-9e16-41f6535f48ee.mov

Mobile Web - Chrome
https://user-images.githubusercontent.com/7823358/233762145-4ff8e5a6-b48f-44b0-8562-364224e3c4ac.mp4

Mobile Web - Safari
https://user-images.githubusercontent.com/7823358/233762150-fb06c995-6275-4e3f-9d6b-e9b0676fd0a9.mov

Desktop
https://user-images.githubusercontent.com/7823358/233762158-6aed3cae-4146-4594-a490-21b1542f4dbe.mov

iOS
https://user-images.githubusercontent.com/7823358/233762167-905601fe-77a9-4709-9258-f209b3a64f2b.mov

Android
https://user-images.githubusercontent.com/7823358/233762172-0bd262e1-5116-4503-8a37-203883dd5f46.mp4

@luacmartins @Santhosh-Sellavel One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@Santhosh-Sellavel PR is ready for review. Should we able to merge asap, so eligible for timeline bonus. Thank you.

Will try to get to it soon, but we have still time left until Wednesday for the timeline bonus!

Reviewer Checklist

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR

[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I checked that screenshots or videos are included for tests on all platforms
[x] I included screenshots or videos for tests on all platforms
[x] I verified tests pass on all platforms & I tested again on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web
https://user-images.githubusercontent.com/85645967/234099335-d3c3f973-ca94-48a3-8700-9e899234950c.mov

Mobile Web - Chrome
https://user-images.githubusercontent.com/85645967/234101044-3b02b67b-9be0-4ffb-93aa-4f4d011e7b0d.mp4

Mobile Web - Safari
https://user-images.githubusercontent.com/85645967/234101195-7fb355b0-ad47-403e-b36e-cac51705767b.mp4

Desktop
https://user-images.githubusercontent.com/85645967/234099391-4e1a2a23-5a2e-45de-9d66-52356bb0e5b0.mov

iOS
https://user-images.githubusercontent.com/85645967/234101172-2c9b2fc9-e027-4478-b88e-e613c419947d.mp4

Android
https://user-images.githubusercontent.com/85645967/234101067-d46fc526-ea05-4c7d-a875-8a155eeb67f9.mp4

🚀 Deployed to staging by https://github.com/luacmartins in version: 1.3.5-1 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.5-6 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Fix backward compatibility with Fluent::DetachProcess and Fluent::DetachMultiProcess

Some 3rd party plugins use these methods in their code:
class HTTPServer # w/o inheriting Fluent::Input, Fluent::Output
  include DetachMultiProcess

  def start
    detach_multi_process do
      # Do something to run HTTP server
    end
  end
end

See also:

https://github.com/groonga/fluent-plugin-groonga/blob/530f421080cd4ad131eacc1cfd6ade474fabc19d/lib/fluent/plugin/in_groonga.rb#L144
https://github.com/groonga/fluent-plugin-groonga/blob/530f421080cd4ad131eacc1cfd6ade474fabc19d/lib/fluent/plugin/in_groonga.rb#L83-L85

Failed CI but the failure seems not to be related to my changes.

@repeatedly Could you apply this change and release a new version?
Our plugin, fluent-plugin-groonga, doesn't work with the latest Fluentd...
(fluent-plugin-groonga still uses 0.12 API. It will migrate to 0.14 API later. The problem will be solved at the timing.)

Sorryr for the late. Merged.


Project properties not accessible from settingsEvaluated

I have an init.d file with logic similar to this:
settingsEvaluated { settings ->
  settings.pluginManagement {
    resolutionStrategy {
      eachPlugin {
        if (requested.id.id.startsWith("jb_")) {
          useModule("dk.jyskebank.tooling.buildscripts:buildscripts:${buildScriptsVersion}")
        }
      }
    }
  }
}

I would like the project to provide buildScriptsVersion in its gradle.properties file.
Reading the documentation https://docs.gradle.org/current/dsl/org.gradle.api.initialization.Settings.html, I would expect properties to be available.
Expected Behavior
The property buildScriptsVersion should be picked up from gradle.properties.
Current Behavior
The builds fail with:
Could not get unknown property 'buildScriptsVersion' for object of type org.gradle.plugin.management.internal.DefaultPluginResolveDetails.

Context
I am trying to make use of the new id {} syntax for applying plugins, while providing the resolution strategy from a global init file.
I would like to avoid replicating the resolution strategy into all our projects, as it will probably change over time.
Steps to Reproduce
The attached project archive demonstrates the problem.
Run with:
./gradlew --init-script initd.gradle clean
It should moan about missing a dependency, but instead fails due to the missing property.
Your Environment
Build scan URL: https://scans.gradle.com/s/ebguqklj66rrg

gradle-settings-bug.zip

Adding rootProject does fix the problem. This was not clear to me from reading the docs.

Actually, adding rootProject is a bit strange. Instead you should be using settings, which, as documented in the link from the description, has access to the different properties.
What happens is that without a prefix, buildScriptsVersion is resolved against the Gradle object, as documented.
That last section could have a note clearly stating that you need to pay attention to the scope of what you are attempting to reach when writing init scripts logic.


MAPREDUCE-7120. Make hadoop consider wildcard host as datalocal

This allows hadoop to treat "" as data local. This allows remote filesystems to increase performance by skipping retrys for data locality by returning "" as the block host when the filesystem is asked for the block location.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
62
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

-1
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1
mvninstall
1073
trunk passed

+1
compile
33
trunk passed

+1
checkstyle
24
trunk passed

+1
mvnsite
36
trunk passed

+1
shadedclient
711
branch has no errors when building and testing our client artifacts.

+1
javadoc
21
trunk passed

0
spotbugs
58
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
56
trunk passed

_ Patch Compile Tests _

+1
mvninstall
29
the patch passed

+1
compile
29
the patch passed

+1
javac
29
the patch passed

-0
checkstyle
19
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app: The patch generated 1 new + 271 unchanged - 0 fixed = 272 total (was 271)

+1
mvnsite
32
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
738
patch has no errors when building and testing our client artifacts.

+1
javadoc
19
the patch passed

+1
findbugs
64
the patch passed

_ Other Tests _

+1
unit
590
hadoop-mapreduce-client-app in the patch passed.

+1
asflicense
28
The patch does not generate ASF License warnings.

3629

Subsystem
Report/Notes

Docker
Client=18.09.8 Server=18.09.8 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-399/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/399

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 579f8c5c2fbf 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 7f1b76c

Default Java
1.8.0_212

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-399/1/artifact/out/diff-checkstyle-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-app.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-399/1/testReport/

Max. process+thread count
594 (vs. ulimit of 5500)

modules
C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app U: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-399/1/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
39
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

-1
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1
mvninstall
1067
trunk passed

+1
compile
42
trunk passed

+1
checkstyle
28
trunk passed

+1
mvnsite
40
trunk passed

+1
shadedclient
696
branch has no errors when building and testing our client artifacts.

+1
javadoc
21
trunk passed

0
spotbugs
56
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
53
trunk passed

_ Patch Compile Tests _

+1
mvninstall
30
the patch passed

+1
compile
28
the patch passed

+1
javac
28
the patch passed

-0
checkstyle
19
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app: The patch generated 1 new + 271 unchanged - 0 fixed = 272 total (was 271)

+1
mvnsite
34
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
757
patch has no errors when building and testing our client artifacts.

+1
javadoc
23
the patch passed

+1
findbugs
65
the patch passed

_ Other Tests _

+1
unit
581
hadoop-mapreduce-client-app in the patch passed.

+1
asflicense
26
The patch does not generate ASF License warnings.

3616

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-399/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/399

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux a526161e692c 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / c7c7a88

Default Java
1.8.0_212

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-399/2/artifact/out/diff-checkstyle-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-app.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-399/2/testReport/

Max. process+thread count
597 (vs. ulimit of 5500)

modules
C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app U: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-399/2/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
99
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

-1
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1
mvninstall
1249
trunk passed

+1
compile
34
trunk passed

+1
checkstyle
25
trunk passed

+1
mvnsite
39
trunk passed

+1
shadedclient
816
branch has no errors when building and testing our client artifacts.

+1
javadoc
25
trunk passed

0
spotbugs
79
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
76
trunk passed

_ Patch Compile Tests _

+1
mvninstall
40
the patch passed

+1
compile
36
the patch passed

+1
javac
36
the patch passed

-0
checkstyle
26
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app: The patch generated 1 new + 271 unchanged - 0 fixed = 272 total (was 271)

+1
mvnsite
37
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
842
patch has no errors when building and testing our client artifacts.

+1
javadoc
20
the patch passed

+1
findbugs
68
the patch passed

_ Other Tests _

+1
unit
592
hadoop-mapreduce-client-app in the patch passed.

+1
asflicense
28
The patch does not generate ASF License warnings.

4142

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-399/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/399

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 2096792ca141 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / e872ceb

Default Java
1.8.0_222

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-399/3/artifact/out/diff-checkstyle-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-app.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-399/3/testReport/

Max. process+thread count
581 (vs. ulimit of 5500)

modules
C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app U: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-399/3/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
86
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

-1
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1
mvninstall
1220
trunk passed

+1
compile
34
trunk passed

+1
checkstyle
29
trunk passed

+1
mvnsite
32
trunk passed

+1
shadedclient
782
branch has no errors when building and testing our client artifacts.

+1
javadoc
23
trunk passed

0
spotbugs
63
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
61
trunk passed

_ Patch Compile Tests _

+1
mvninstall
32
the patch passed

+1
compile
25
the patch passed

+1
javac
25
the patch passed

-0
checkstyle
22
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app: The patch generated 1 new + 271 unchanged - 0 fixed = 272 total (was 271)

+1
mvnsite
29
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
813
patch has no errors when building and testing our client artifacts.

+1
javadoc
21
the patch passed

+1
findbugs
57
the patch passed

_ Other Tests _

+1
unit
623
hadoop-mapreduce-client-app in the patch passed.

+1
asflicense
36
The patch does not generate ASF License warnings.

4004

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-399/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/399

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 31adfee04c24 4.15.0-48-generic #51-Ubuntu SMP Wed Apr 3 08:28:49 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 00b5a27

Default Java
1.8.0_212

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-399/4/artifact/out/diff-checkstyle-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-app.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-399/4/testReport/

Max. process+thread count
582 (vs. ulimit of 5500)

modules
C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app U: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-399/4/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
134
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

-1
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1
mvninstall
1210
trunk passed

+1
compile
34
trunk passed

+1
checkstyle
28
trunk passed

+1
mvnsite
35
trunk passed

+1
shadedclient
837
branch has no errors when building and testing our client artifacts.

+1
javadoc
28
trunk passed

0
spotbugs
57
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
55
trunk passed

_ Patch Compile Tests _

+1
mvninstall
37
the patch passed

+1
compile
24
the patch passed

+1
javac
24
the patch passed

-0
checkstyle
23
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app: The patch generated 1 new + 271 unchanged - 0 fixed = 272 total (was 271)

+1
mvnsite
31
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
823
patch has no errors when building and testing our client artifacts.

+1
javadoc
23
the patch passed

+1
findbugs
72
the patch passed

_ Other Tests _

-1
unit
629
hadoop-mapreduce-client-app in the patch failed.

-1
asflicense
30
The patch generated 1 ASF License warnings.

4135

Reason
Tests

Failed junit tests
hadoop.mapreduce.v2.app.webapp.TestAMWebServicesAttempt

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-399/5/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/399

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 72964f7aff76 4.15.0-48-generic #51-Ubuntu SMP Wed Apr 3 08:28:49 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / e356e4f

Default Java
1.8.0_212

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-399/5/artifact/out/diff-checkstyle-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-app.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-399/5/artifact/out/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-app.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-399/5/testReport/

asflicense
https://builds.apache.org/job/hadoop-multibranch/job/PR-399/5/artifact/out/patch-asflicense-problems.txt

Max. process+thread count
589 (vs. ulimit of 5500)

modules
C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app U: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-399/5/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
76
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

-1
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1
mvninstall
1156
trunk passed

+1
compile
28
trunk passed

+1
checkstyle
25
trunk passed

+1
mvnsite
30
trunk passed

+1
shadedclient
790
branch has no errors when building and testing our client artifacts.

+1
javadoc
25
trunk passed

0
spotbugs
55
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
53
trunk passed

_ Patch Compile Tests _

+1
mvninstall
31
the patch passed

+1
compile
23
the patch passed

+1
javac
23
the patch passed

-0
checkstyle
20
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app: The patch generated 1 new + 271 unchanged - 0 fixed = 272 total (was 271)

+1
mvnsite
26
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
807
patch has no errors when building and testing our client artifacts.

+1
javadoc
29
the patch passed

+1
findbugs
76
the patch passed

_ Other Tests _

+1
unit
654
hadoop-mapreduce-client-app in the patch passed.

+1
asflicense
34
The patch does not generate ASF License warnings.

3976

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-399/6/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/399

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 0bad64be6cdf 4.15.0-48-generic #51-Ubuntu SMP Wed Apr 3 08:28:49 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 094d736

Default Java
1.8.0_212

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-399/6/artifact/out/diff-checkstyle-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-app.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-399/6/testReport/

Max. process+thread count
580 (vs. ulimit of 5500)

modules
C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app U: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-399/6/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
39
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

-1
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1
mvninstall
1177
trunk passed

+1
compile
31
trunk passed

+1
checkstyle
25
trunk passed

+1
mvnsite
36
trunk passed

+1
shadedclient
720
branch has no errors when building and testing our client artifacts.

+1
javadoc
21
trunk passed

0
spotbugs
57
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
55
trunk passed

_ Patch Compile Tests _

+1
mvninstall
32
the patch passed

+1
compile
25
the patch passed

+1
javac
25
the patch passed

-0
checkstyle
21
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app: The patch generated 1 new + 271 unchanged - 0 fixed = 272 total (was 271)

+1
mvnsite
27
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
764
patch has no errors when building and testing our client artifacts.

+1
javadoc
23
the patch passed

+1
findbugs
69
the patch passed

_ Other Tests _

+1
unit
636
hadoop-mapreduce-client-app in the patch passed.

+1
asflicense
28
The patch does not generate ASF License warnings.

3804

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-399/7/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/399

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux cc8f46ba2d25 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 69ddb36

Default Java
1.8.0_222

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-399/7/artifact/out/diff-checkstyle-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-app.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-399/7/testReport/

Max. process+thread count
579 (vs. ulimit of 5500)

modules
C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app U: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-399/7/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
37
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

-1
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1
mvninstall
1261
trunk passed

+1
compile
28
trunk passed

+1
checkstyle
25
trunk passed

+1
mvnsite
31
trunk passed

+1
shadedclient
774
branch has no errors when building and testing our client artifacts.

+1
javadoc
22
trunk passed

0
spotbugs
55
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
53
trunk passed

_ Patch Compile Tests _

+1
mvninstall
31
the patch passed

+1
compile
24
the patch passed

+1
javac
24
the patch passed

-0
checkstyle
21
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app: The patch generated 1 new + 271 unchanged - 0 fixed = 272 total (was 271)

+1
mvnsite
26
the patch passed

+1
whitespace
1
The patch has no whitespace issues.

+1
shadedclient
827
patch has no errors when building and testing our client artifacts.

+1
javadoc
24
the patch passed

+1
findbugs
64
the patch passed

_ Other Tests _

+1
unit
594
hadoop-mapreduce-client-app in the patch passed.

+1
asflicense
27
The patch does not generate ASF License warnings.

3958

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-399/8/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/399

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 4f377ab796c7 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 3329257

Default Java
1.8.0_222

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-399/8/artifact/out/diff-checkstyle-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-app.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-399/8/testReport/

Max. process+thread count
581 (vs. ulimit of 5500)

modules
C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app U: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-399/8/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
40
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

-1
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1
mvninstall
1142
trunk passed

+1
compile
34
trunk passed

+1
checkstyle
31
trunk passed

+1
mvnsite
38
trunk passed

+1
shadedclient
772
branch has no errors when building and testing our client artifacts.

+1
javadoc
27
trunk passed

0
spotbugs
61
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
59
trunk passed

_ Patch Compile Tests _

+1
mvninstall
32
the patch passed

+1
compile
27
the patch passed

+1
javac
27
the patch passed

-0
checkstyle
24
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app: The patch generated 1 new + 271 unchanged - 0 fixed = 272 total (was 271)

+1
mvnsite
29
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
764
patch has no errors when building and testing our client artifacts.

+1
javadoc
24
the patch passed

+1
findbugs
63
the patch passed

_ Other Tests _

+1
unit
612
hadoop-mapreduce-client-app in the patch passed.

+1
asflicense
31
The patch does not generate ASF License warnings.

3829

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-399/9/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/399

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 7f3d445aa851 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 915cbc9

Default Java
1.8.0_222

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-399/9/artifact/out/diff-checkstyle-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-app.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-399/9/testReport/

Max. process+thread count
597 (vs. ulimit of 5500)

modules
C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app U: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-399/9/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m  6s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
38m 14s

trunk passed

+1 :green_heart:
compile
0m 43s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
compile
0m 38s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
checkstyle
0m 31s

trunk passed

+1 :green_heart:
mvnsite
0m 44s

trunk passed

+1 :green_heart:
javadoc
0m 33s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
0m 27s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
1m 13s

trunk passed

+1 :green_heart:
shadedclient
20m 31s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 39s

the patch passed

+1 :green_heart:
compile
0m 39s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javac
0m 39s

the patch passed

+1 :green_heart:
compile
0m 31s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
javac
0m 31s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 25s

the patch passed

+1 :green_heart:
mvnsite
0m 36s

the patch passed

+1 :green_heart:
javadoc
0m 24s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
0m 23s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
1m 30s

the patch passed

+1 :green_heart:
shadedclient
19m 50s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
9m 36s

hadoop-mapreduce-client-app in the patch passed.

+1 :green_heart:
asflicense
0m 32s

The patch does not generate ASF License warnings.

100m  6s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-399/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/399

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux 1ffef2bf070f 4.15.0-128-generic #131-Ubuntu SMP Wed Dec 9 06:57:35 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 002719c586934c5e40a5201fb8ce57268d7dde99

Default Java
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-399/1/testReport/

Max. process+thread count
574 (vs. ulimit of 5500)

modules
C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app U: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-399/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 28s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
32m  5s

trunk passed

+1 :green_heart:
compile
0m 28s

trunk passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
compile
0m 26s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
checkstyle
0m 28s

trunk passed

+1 :green_heart:
mvnsite
0m 30s

trunk passed

+1 :green_heart:
javadoc
0m 32s

trunk passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
javadoc
0m 26s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
0m 48s

trunk passed

+1 :green_heart:
shadedclient
21m  8s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 20s

the patch passed

+1 :green_heart:
compile
0m 21s

the patch passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
javac
0m 21s

the patch passed

+1 :green_heart:
compile
0m 18s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
javac
0m 18s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 18s

the patch passed

+1 :green_heart:
mvnsite
0m 21s

the patch passed

+1 :green_heart:
javadoc
0m 21s

the patch passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
javadoc
0m 19s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
0m 45s

the patch passed

+1 :green_heart:
shadedclient
22m 39s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
6m 58s

hadoop-mapreduce-client-app in the patch passed.

+1 :green_heart:
asflicense
0m 29s

The patch does not generate ASF License warnings.

93m 28s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-399/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/399

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 5d59595d7589 4.15.0-213-generic #224-Ubuntu SMP Mon Jun 19 13:30:12 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 002719c586934c5e40a5201fb8ce57268d7dde99

Default Java
Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-399/1/testReport/

Max. process+thread count
768 (vs. ulimit of 5500)

modules
C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app U: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-399/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.


MAINT: Updating HiGHS to match latest

Along with some unmerged fixes (companion PR to HiGHs is incoming).

Closing in favor of #68


env selector deletion + routing adjustment

Description

Short description here *

closes #4577
Self Check:
Strike through any lines that are not applicable (~~line~~) then check the box

[x] Attached issue to pull request
[x] Changelog entry
[x] Code is clear and sufficiently documented
[x] Sufficient test cases (reproduces the bug/tests the requested feature)
[ ] Correct, in line with design
[ ] End user documentation is included or an issue is created for end-user documentation (add ref to issue here: )

Processing this pull request

Pull request rejected by merge tool. This pull request has not been approved yet.

Processing this pull request

Merged into branches iso6, master in 80f8839c3445c78c7fd335617e7ef8cac90ad7b6


Add property to convert between UTC and default ZoneId

The DateTimeHelper uses ZoneOffset.UTC for serializing and deserializing dates. The problem in our apps is that the LocalDateTime uses a different zone than UTC by default. So ZoneId.systemDefault() is equal to Amsterdam in our case.
It would be nice if we could enable a property to have the DateTimeHelper automatically convert between UTC and the ZoneId.systemDefault(). Default behavior would stay as is to not break the lib for anybody else using it.

@oliemansm, I’m ok to provide ability to change this behaviour through application.yml. Can you make a PR?

@donbeave Yeah, I'll take a look.

@oliemansm, awesome!


[v6] useRoutes does not work with loadable/component

Version
6.0.0-alpha.5
Test Case
https://codesandbox.io/s/react-router-loadable-component-t97j0?file=/src/App.jsx
Steps to reproduce
I created a route config array and added the name of the page component as a string:
const routes = [
  {
    path: "/",
    componentName: "Home"
  },
  {
    path: "/about",
    componentName: "About"
    children: [
      {
        path: "me",
        componentName: "AboutMe"
      }
    ]
  },
  {
    path: "/users",
    componentName: "Users"
    children: [
      {
        path: ":user",
        componentName: "User"
      }
    ]
  }
]

I created a component <AsyncPage component="componentName" /> which returns a loadable/component:
const AsyncPage = loadable(props => import(`./pages/${props.component}`));

I created a function to recursively map the <AsyncPage> to the element property.
const mapRoutesForUse = routes => {
  return routes.map(({ path, componentName, children }) => ({
    path,
    element: <AsyncPage component={componentName} />,
    children: children && mapRoutesForUse(children)
  }));
};

I created a <ProjectRoutes> component with useRoutes:
const ProjectRoutes = () => useRoutes(mapRoutesForUse(routes));

I added the <ProjectRoutes /> component to my App:
const App = () => {
  return (

          <Link to="/">Home</Link>

          <Link to="/about">About</Link>

              <Link to="/about/me">Me</Link>

          <Link to="/users">Users</Link>

      <ProjectRoutes />

  );
};

I added an <Outlet> component to the <About> and <Users> page components:
const About = () => (
  <>

About Page

    <Outlet />
  </>
);

Expected Behavior
I would expect this setup to work and the router to render the requested pages.
Actual Behavior

When you are on the "Home" page of the testcase and you click on a link in the navigation, the URL changes but does not get rendered.
When you are on the "About" page and click on the "Home" or "Users" link nothing happens. But clicking on the "Me" link works!
When you are on the "Me" page and click on the "Home" or "Users" link it will take you to "About".
When you are on the "Users" page its same as on the "About" page. Clicking the links to the "User" pages works but clicking on "Home" or "About" takes you again to "Users".

Workaround
I created a function to recursively map the route config to <Route> components:
const mapRoutes = routes => {
  return routes.map(({ path, componentName, children }, key) => (
    <Route
      path={path}
      key={key}
      element={<AsyncPage component={componentName} />}
      children={children && mapRoutes(children)}
    />
  ));
};

And use it in the App like this:
      ...

      <Routes>{mapRoutes(routes)}</Routes>

  );
};

This works great and every link navigates to the correct page.
But shouldn't this be the same as what useRoutes returns?

@shwao I have no idea how much time you just saved me. I started with useRoutes, and the component mounting behavior was working well until I changed something.  Unfortunately, I was not able to pin down exactly what change caused it to no longer work correctly, much to my frustration. I think it may have something to do with how the useRoutes is nested, because I was implementing error handling when it stopped working. I'm suspicious that there may be something to do with classed, functional, or a mixture of classed and functional components in the useRoutes lineage that causes this behavior, but investigating this is not something I can commit time to ATM.
Thank you very much for your workaround (I can confirm that it resolved my issue as well), and yes - I think this behavior may be worth understanding so that it can have test cases or documentation written against it.

I'm migrating from v5 to v6 in a test app. The v5 app I had also loaded components dynamically. The switch from Component to Element has me scratching my head as to how I should accomplish functionality I had working great in v5. I have a similar array to yours (route name, component, etc). Now when I try to assign that to , it fails because it's looking for an Element, not a component.
Is this the only/best way to assign components to routes dynamically? I feel like I'm missing something easy.
So I have to use the component name as a string and create it via loadable?
Appreciate any help/guidance.

@shwao I fixed ur issue -> https://codesandbox.io/s/react-router-loadable-component-forked-m0hfr?file=/src/App.jsx

Yes it works, thank you @danilobrinu ! But do you know why? Is that a bug or is it supposed to be like that? I cant think of reason why that would make a difference.

@bbuchanan Yes use a string of the component name and create via loadable like in danilobrinu's example. But you do not need to have the components imported like in his sandbox.
Here i forked it and removed the components so that it is cleaner: https://codesandbox.io/s/react-router-loadable-component-forked-vx1g0

Yes it works, thank you @danilobrinu ! But do you know why? Is that a bug or is it supposed to be like that? I cant think of reason why that would make a difference.

@shwao it's supposed to be like that because loadable return a React.Function instead of React.Element but you can get the React.Element just calling to a React.Function.
So the way to do that is assigning the result of loadable to a variable (in my case is Component) a calling like a React.Component (). Don't forget the element prop expect to a React.Element, so is you the pass component itself doesn't work.

Ah okay, that makes sense. Thanks again for your help, i will close this issue.

There is something wrong here. The way @danilobrinu showed to use useRoutes works but i changed my private project to use it and i discovered a problem with react-spring.
I came to the conclusion that it must be because of the Component inside the mapRoutes function. I changed the mapRoutes function from this (which works but with the react-spring problem):
return routes.map(({ path, component, routes }) =>
{
	const Component = loadable(() => import(`shared/pages/${component}/index`));

	return {
		path,
		element: <Component />,
		children: routes && mapRoutes(routes),
	};
});

to this where i use the same AsyncPage component like in my first issue post:
const mapRoutes = (routes: ProjectRoute[]): PartialRouteObject[] =>
{
	return routes.map(({ path, component, routes }) => ({
		path,
		element: <AsyncPage component={component} />,
		children: routes && mapRoutes(routes),
	}));
};

And it works in my project! The page components are being lazy loaded and react-spring also works!
But then i tried the same again in the codesandbox and it does not work! Its the same behaviour like i described above.
It makes no sense to me why it would work in my project but not in the sandbox. I think this is a bug and i will reopen this issue.

There is something wrong here. The way @danilobrinu showed to use useRoutes works but i changed my private project to use it and i discovered a problem with react-spring.
I came to the conclusion that it must be because of the Component inside the mapRoutes function. I changed the mapRoutes function from this (which works but with the react-spring problem):
return routes.map(({ path, component, routes }) =>
{
	const Component = loadable(() => import(`shared/pages/${component}/index`));

	return {
		path,
		element: <Component />,
		children: routes && mapRoutes(routes),
	};
});

to this where i use the same AsyncPage component like in my first issue post:
const mapRoutes = (routes: ProjectRoute[]): PartialRouteObject[] =>
{
	return routes.map(({ path, component, routes }) => ({
		path,
		element: <AsyncPage component={component} />,
		children: routes && mapRoutes(routes),
	}));
};

And it works in my project! The page components are being lazy loaded and react-spring also works!
But then i tried the same again in the codesandbox and it does not work! Its the same behaviour like i described above.
It makes no sense to me why it would work in my project but not in the sandbox. I think this is a bug and i will reopen this issue.

@shwao that code is wrong, if you want to lazy load components (using dynamic import) dynamically you need to be explicit.
So the next code should works, let me know if something is wrong.
// This only works is the extension is .js
const Component = loadable(() => import(`shared/pages/${compoment}/index`))
// In other cases you need to be explicit like in the example that I share you
const Component = loadable(() => import(`shared/pages/${compoment}/index.jsx`))

Please remove the quote from your comment it makes the thread hard to read.
My project is Typescript and it works so it is not wrong.

Please remove the quote from your comment it makes the thread hard to read.
My project is Typescript and it works so it is not wrong.

Can you provide an codesandbox for that ?

You mean a working Typescript example like I have in my project now? That makes sense. I will try to set one up.

I created a sandbox in Typescript but im having the same problem. But it does fully work in my larger more complex project, so there must be something! I will try to find out why it works but that could take some time as i do not have enough time right now.

You mean a working Typescript example like I have in my project now? That makes sense. I will try to set one

I just need a basic example

@shwao I think is some related to how you are implementing because I created a basic example with TypeScript and works very well. https://codesandbox.io/s/falling-smoke-ye0jz?file=/src/App.tsx:565-568

Yes you are correct, i did the mistake again and returned the loadable component directly. So instead like you:
const AsyncComponent: React.FC<AsyncComponentProps> = ({ name, ...props }) => {
  const Component = loadable(() => import(`./components/${name}.tsx`));

  return <Component {...props} />;
};

I did:
const AsyncComponent = loadable(({ name }) => import(`./components/${name}.tsx`));

And i am doing it like this in my project and it works! But it does not work in the sandbox. Only your way of wrapping it works. Thats what i dont understand, why does it work for me?
But if i understand you correctly, passing the loadable component directly should not work and the only correct way is to wrap it in a component?
And what purpose do the rest props in the AsyncComponent serve?  About the rest props is not necessary but that means you can pass some props to the route component and that component can receive that props.

Okay i understand. Thank you very much for your help, it's greatly appreciated!
I can finally close this issue.

For everyone having problems to get typescript + react-router v6 + loadable components to work, look at this sandbox from @danilobrinu : https://codesandbox.io/s/falling-smoke-ye0jz?file=/src/App.tsx


First F5 does not seem to have any effect in extension host debugging

VS Code 0.10.12-alpha

create a Hello World extension
open in VS Code
press F5

Observe: nothing happens

press F5

Observe: extension host window appears

reload window of the extension workspace (not the extension host window)
press F5

Observe: nothing happens

Dup of #4105


Update plan-wake-up-clients.md

wakeup option is greyed out when connected to a CAS, only works when connected to a primary
Summarize the change in the pull request title
Describe your change, specifically why you think it's needed.
Fixes #Issue_Number (if necessary)

@russrimm : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Hey @russrimm I approved your other similar PR #1674, but this one, I am going to decline. Reason:This article  is focused on an older version of ConfigMan. Hit me up on Teams if you are super passionate about getting this specific change in.


chore: add dependabot

If you want.

Thank you, but no. I will keep deps up to date manually from time to time, not a fan of receiving a batch of bot prs.


KYLIN-3597 fix sonar issues and refactor test cases

Can one of the admins verify this patch?

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@7e9a8e1). Click here to learn what that means.
The diff coverage is 38.46%.

@@            Coverage Diff            @@
##             master     #467   +/-   ##
=========================================
  Coverage          ?   24.48%
  Complexity        ?     4962
=========================================
  Files             ?     1143
  Lines             ?    69396
  Branches          ?     9896
=========================================
  Hits              ?    16989
  Misses            ?    50694
  Partials          ?     1713

Impacted Files
Coverage Δ
Complexity Δ

...ain/java/org/apache/kylin/tool/KylinConfigCLI.java
73.07% <ø> (ø)
6 <0> (?)

.../cube/cuboid/algorithm/greedy/GreedyAlgorithm.java
0% <0%> (ø)
0 <0> (?)

...kylin/cube/cuboid/algorithm/CuboidRecommender.java
0% <0%> (ø)
0 <0> (?)

.../java/org/apache/kylin/common/KylinConfigBase.java
14.26% <100%> (ø)
41 <0> (?)

...main/java/org/apache/kylin/common/KylinConfig.java
35.88% <33.33%> (ø)
23 <0> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e9a8e1...d7ce935. Read the comment docs.

[INFO] Reactor Summary for Apache Kylin 2.6.0-SNAPSHOT:
[INFO]
[INFO] Apache Kylin ....................................... SUCCESS [  5.683 s]
[INFO] Apache Kylin - Core Common ......................... SUCCESS [ 14.554 s]
[INFO] Apache Kylin - Core Metadata ....................... SUCCESS [ 51.741 s]
[INFO] Apache Kylin - Core Dictionary ..................... SUCCESS [05:41 min]
[INFO] Apache Kylin - Core Cube ........................... SUCCESS [01:01 min]
[INFO] Apache Kylin - Core Metrics ........................ SUCCESS [  1.042 s]
[INFO] Apache Kylin - Core Job ............................ SUCCESS [ 45.752 s]
[INFO] Apache Kylin - Core Storage ........................ SUCCESS [  6.427 s]
[INFO] Apache Kylin - MapReduce Engine .................... SUCCESS [ 22.720 s]
[INFO] Apache Kylin - Spark Engine ........................ SUCCESS [  8.384 s]
[INFO] Apache Kylin - Hive Source ......................... SUCCESS [  7.370 s]
[INFO] Apache Kylin - DataSource SDK ...................... SUCCESS [ 11.792 s]
[INFO] Apache Kylin - Jdbc Source ......................... SUCCESS [ 20.565 s]
[INFO] Apache Kylin - Kafka Source ........................ SUCCESS [  5.982 s]
[INFO] Apache Kylin - Cache ............................... SUCCESS [  9.057 s]
[INFO] Apache Kylin - HBase Storage ....................... SUCCESS [ 39.704 s]
[INFO] Apache Kylin - Query ............................... SUCCESS [ 15.685 s]
[INFO] Apache Kylin - Metrics Reporter Hive ............... SUCCESS [  0.975 s]
[INFO] Apache Kylin - Metrics Reporter Kafka .............. SUCCESS [  0.699 s]
[INFO] Apache Kylin - REST Server Base .................... SUCCESS [ 25.364 s]
[INFO] Apache Kylin - REST Server ......................... SUCCESS [01:53 min]
[INFO] Apache Kylin - JDBC Driver ......................... SUCCESS [  7.716 s]
[INFO] Apache Kylin - Assembly ............................ SUCCESS [ 15.062 s]
[INFO] Apache Kylin - Tool ................................ SUCCESS [ 10.927 s]
[INFO] Apache Kylin - Tool Assembly ....................... SUCCESS [  4.315 s]
[INFO] Apache Kylin - Integration Test .................... SUCCESS [  02:38 h]
[INFO] Apache Kylin - Tomcat Extension .................... SUCCESS [  2.705 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  02:53 h
[INFO] Finished at: 2019-02-13T06:52:52Z
[INFO] ------------------------------------------------------------------------

Pull Request Test Coverage Report for Build 4127

6 of 13 (46.15%)  changed or added relevant lines in 4 files are covered.
2 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-0.001%) to 26.955%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

core-cube/src/main/java/org/apache/kylin/cube/cuboid/algorithm/greedy/GreedyAlgorithm.java
0
1
0.0%

core-common/src/main/java/org/apache/kylin/common/KylinConfig.java
3
6
50.0%

core-cube/src/main/java/org/apache/kylin/cube/cuboid/algorithm/CuboidRecommender.java
0
3
0.0%

Files with Coverage Reduction
New Missed Lines
%

core-cube/src/main/java/org/apache/kylin/cube/cuboid/algorithm/CuboidRecommender.java
1
0.0%

server-base/src/main/java/org/apache/kylin/rest/util/QueryRequestLimits.java
1
47.62%

Totals

Change from base Build 4123:
-0.001%

Covered Lines:
18706

Relevant Lines:
69396

💛  - Coveralls


chore(rockspec) bump lua-resty-healthcheck to 0.4.2

@hishamhm Could we send this to master maybe?

But we don't bump dependencies on point releases, right?

Or is it fine to bump in a point-release, given that it is itself a point-release? (That would make sense.)

We do, but it depends on the content of the dependency bump. In this case, we have a fix and a refactor, so it is a bit hard to send it to master indeed...

Pushed to master!


[TextArea] Textarea verticalGrow auto doesn't work for programmed updation of value

Describe the bug
Textarea component verticalGrow =auto doesn't work for programmed updation of value
To Reproduce

Add a controlled TextArea component with with value controlled using a state variable.
Use default verticalGrow option as 'auto'.
Add a button, which will replace the content of textarea with a long text using the state variable (> 4 lines).
Click the button to update the content of textarea.
Expectation is height of the textarea should increase upto the size of the content, but it will not increase.
Now click in the textarea, and add any character, then it can be noticed, textarea grows upto content size.

Expected behaviour
Textarea vertical grow auto should grow, irrespective of whether programmatic value update or userkeypress based update.
Screenshots
Added codesandbox link for the issue recreation.
Additional context

Reference Codesandbox link here.
Pls. note, this issue doesn't occur in halstack version 10.1.0. This can be verified by simply changing the version in the codesandbox link mentioned above.
verticalGrow default option is auto.

Add labels
Textarea

After analysis, If the team could provide tentative date/fix version, for this issue, that would be helpful for me.
Thanks in advance.

Github issue created in halstack,
Link to issue,
https://github.com/dxc-technology/halstack-react/issues/1951
And this issue is kept open to watch the original issue

Hello, @diwakarang!
It's definitely an issue, I've checked. The problem is that the old code in the version you pointed to, while it may have worked, was not the correct code from React's point of view. Let's check it out to find the best possible solution.
Thanks for the feedback!

Hello again, @diwakarang!
We have fixed your issue as we considered it fair enough. We will release a new Halstack patch version with this fix.
Thanks for the patience!

Hi @GomezIvann
Thank you very much for the quick update. 👍


Padding is marked as required in TS, but has a default value of 0

Padding is marked as required in TS, but has a default value of 0. It should be marked as optional in TS.

A regression from https://github.com/react-simple-code-editor/react-simple-code-editor/pull/125.


Refactor password archivable and expirable for instance method overriding

We wanted a way to set password archive and expire settings at the instance level so we abstracted the class level variables behind instance methods.

I'm closing since much of this has been incorporated and the branch is horrible behind. #151 replaces this.


Display in English (US) layout of keyboard shortcuts in both Help and Settings whatever default keyboard input is

Description of the new feature / enhancement
The experience user level of PowerToys is relatively high, they usually understand shortcuts written in English keyboard layout.
Therefore, I suggest using only English (US) keyboard shortcuts in both Help and Settings, even if different default language is used.
Scenario when this would be used?

I open PowerToys Help app, I would like to see shortcuts written in English. Latin characters can easily be confused with Cyrillic ones.

Supporting information
Happens on:

PowerToys 0.56+, maybe the older versions, too
Windows 11 latest stable

+1 on this.
Although I run PowerToys interface in English, if my keyboard language (at the time of app's window appearing) is non-english, then all shortcuts are displayed in that language, which really confuses me since all the other text is English.


Dream web server support all flags(and GFPGAN).

So this pull request standardize the flags between the DreamServer and the regular application.
With this code the dream.py script must be called with the --web flag to start the web server.
The dream_web.py was renamed to dream_server.py to match the class name inside and avoid peoples used to the old way to call it.
A GFPGAN Strength field was also added to the web interface so it is now possible to use GFPGAN from the web interface if dream.py is started with the --gfpgan --web flags.
This should mostly cover the request here: https://github.com/lstein/stable-diffusion/issues/123
Cheers.

I'm doing the merge now. Would it be safe to remove scripts/dream_server.py now?

Seems like all is working. Thanks!


Bugs in Public Cloud MVP

List of bugs

No Filters on the Public Cloud Product page -> Decided to push MVP without them
After creating Edit request the Budget is not shown in the Product waiting for approval
After creating Edit request the old Account Coding is shown instead of a requested one -> fixed by Zhanna is in the PR with e-mails for Public Cloud
After Edit request approval the Account Coding is not changed -> fixed by Zhanna is in the PR with e-mails for Public Cloud
When Edit request is created there is no ability to Approve the Request as it is approved automatically and goes straight to the Processing stage
Namespace links in the Request

Hey team! Please add your planning poker estimate with Zenhub @Kolezhanchik @okanji @funtigr

Private Zenhub Image

Filters are now available for Public Cloud and work as expected
Private Zenhub Image

The Budget is shown in the Edit Request and reflects the edit changes
Private Zenhub Image

The Account Coding in the Edit Request is showing the new edited value
Private Zenhub Image

The Account Coding changes are now applied after Edit Request is Provisioned:
Private Zenhub Image

The Edit Request is approved automatically - it is made like this by design.

Namespace links are removed from the Public Cloud Request page:
Private Zenhub Image

Public Cloud info is not added to the Login page for now:
Private Zenhub Image

The Request page for Public Cloud now has the text and contacts for Public Cloud:
Private Zenhub Image

Common Components are removed from the Public Cloud Request page:
Private Zenhub Image

The Budget field is now showing CAD both in Edit mode and in Plain Text mode:
Private Zenhub Image

Private Zenhub Image

Provider field is shown in Plain Text in the Provisioned Product:
Private Zenhub Image


Avoid "The set-output command is deprecated" in CI

https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

Closed in favor of #32


ziti-edge-tunnel enroll fails silently if missing required params

Running:
./ziti-edge-tunnel enroll -j ./my_identity.jwt
silently fails with no output. (command is missing the -i flag for the output file)
Should have some basic validation around commands so if required args are missing that you get usage suggestions printed back to you.

duplicate of https://github.com/openziti/ziti-tunnel-sdk-c/issues/174

v


Rice Fixes

@ankane - To get the new version of Rice working, remove the *[] to lambdas. If you want a pointer the syntax you can use is +[]. See:
https://stackoverflow.com/questions/18889028/a-positive-lambda-what-sorcery-is-this
But really you need neither, just use a lambda. Note a good post about what is really happening under the covers here:
https://devblogs.microsoft.com/oldnewthing/20150220-00/?p=44623
Next, change the calls from define_method to define_function since there is no "self" object you are passing around. define_method adds an implicit self parameter to the front of the argument list while define_self does not.
Also, I would recommend not naming the extension ext - that seems to be asking for conflicts with other gems. I'd call it something like midas, so you end up with midas.so.
Updated file attached (I did one lambda as +[] and one without...but I would do both without).

Hmm, github doesn't like uploading C++ files. So here it is
// stdlib
#include <iostream>
#include <vector>

// midas
#include <FilteringCore.hpp>
#include <NormalCore.hpp>
#include <RelationalCore.hpp>

// rice
#include <rice/rice.hpp>

void load_str(std::vector<int>& src, std::vector<int>& dst, std::vector<int>& times, const std::string& input, bool directed) {
  int* input_ptr = (int*) input.data();
  size_t n = input.size() / sizeof(int);

  if (directed) {
    for (size_t i = 0; i < n; i += 3) {
      src.push_back(input_ptr[i]);
      dst.push_back(input_ptr[i + 1]);
      times.push_back(input_ptr[i + 2]);
    }
  } else {
    for (size_t i = 0; i < n; i += 3) {
      src.push_back(input_ptr[i]);
      dst.push_back(input_ptr[i + 1]);
      times.push_back(input_ptr[i + 2]);
      src.push_back(input_ptr[i + 1]);
      dst.push_back(input_ptr[i]);
      times.push_back(input_ptr[i + 2]);
    }
  }
}

// load_data from main.cpp
// modified to throw std::runtime_error when cannot find file
// instead of exiting
void load_file(std::vector<int>& src, std::vector<int>& dst, std::vector<int>& times, const std::string& input_file, bool undirected) {
  FILE* infile = fopen(input_file.c_str(), "r");
  if (infile == NULL) {
    throw std::runtime_error("Could not read file: " + input_file);
  }

  int s, d, t;

  if (undirected == false) {
    while (fscanf(infile, "%d,%d,%d", &s, &d, &t) == 3) {
      src.push_back(s);
      dst.push_back(d);
      times.push_back(t);
    }
  } else {
    while (fscanf(infile, "%d,%d,%d", &s, &d, &t) == 3) {
      src.push_back(s);
      dst.push_back(d);
      times.push_back(t);
      src.push_back(d);
      dst.push_back(s);
      times.push_back(t);
    }
  }
}

std::string fit_predict(std::vector<int>& src, std::vector<int>& dst, std::vector<int>& times, int num_rows, int num_buckets, float factor, float threshold, bool relations, int seed) {
  srand(seed);
  size_t n = src.size();
  const auto result = new float[n];

  if (!std::isnan(threshold)) {
    MIDAS::FilteringCore midas(num_rows, num_buckets, threshold, factor);
    for (size_t i = 0; i < n; i++) {
      result[i] = midas(src[i], dst[i], times[i]);
    }
  } else if (relations) {
    MIDAS::RelationalCore midas(num_rows, num_buckets, factor);
    for (size_t i = 0; i < n; i++) {
      result[i] = midas(src[i], dst[i], times[i]);
    }
  } else {
    MIDAS::NormalCore midas(num_rows, num_buckets);
    for (size_t i = 0; i < n; i++) {
      result[i] = midas(src[i], dst[i], times[i]);
    }
  }
  return std::string((char*) result, sizeof(float) / sizeof(char) * n);
}

extern "C"
void Init_ext() {
  auto rb_mMidas = Rice::define_module("Midas");

  Rice::define_class_under(rb_mMidas, "Detector")
    .define_function(
      "_fit_predict_str",
      +[](const std::string& input, int num_rows, int num_buckets, float factor, float threshold, bool relations, bool directed, int seed) {
        std::vector<int> src, dst, times;
        load_str(src, dst, times, input, directed);
        return fit_predict(src, dst, times, num_rows, num_buckets, factor, threshold, relations, seed);
      })
    .define_function(
      "_fit_predict_file",
      [](const std::string& input, int num_rows, int num_buckets, float factor, float threshold, bool relations, bool directed, int seed) {
        std::vector<int> src, dst, times;
        load_file(src, dst, times, input, !directed);
        return fit_predict(src, dst, times, num_rows, num_buckets, factor, threshold, relations, seed);
      });
}

Thanks @cfis, that fixed the error on Mac: https://github.com/ankane/midas/compare/rice-header-only2. Also, thanks for sharing the lambda resources!
I'm not sure if there's a way to make it work with the new changes/what the trade-offs are, but I think having a single C++ function for both situations (with and without self) as the current version does is simpler for users than having two different ones (cc @jasonroelofs).
Re ext: I have noticed the Ruby convention is to name it midas instead of ext, so may do that after the header-only stuff. I haven't seen any conflicts when using gems together that use ext, like Midas and Faiss, so not sure what's going on there.

The problem with the single function is that it doesn't allow the use of lambdas for both define_method and define_global_function. I thought it was better to global support for lambdas (so define_method, define_singleton_method, define_global_function) then it was to have a single method. It also makes Rice simpler - the dual support led to various special cases in Rice to make it work.
Thus I changed it. I do think this is better in some ways, it makes it explicit whether you want a self parameter or not. In the same way you could have just define_method and not define_singleton_method, but the library has both to make it more explicit what you are trying to do.
The issue I was wondering with ext.so is they both have Init_ext as the initialization function. But thinking about it more, that function would only be triggered in the dll/so being loaded. So I take back my comment, there wouldn't be conflicts.

On the lambdas, I think msvc and gcc are acting differently.
+[] works on msvc, didn't test gcc
*[] does not work on msvc, does work on gcc. MSVC fails because it gets confused between different call types (fastvector and cdecl) - explained a bit in that blog post I linked

Thanks for the explanation/context on the change.
I updated Faiss (diff - CI), which eliminated the "wrong number of arguments" errors.

Cool. Somehow inheritance is broken when I test that library, have to check why.

Great, I started a new issue to track progress of testing libraries and migration notes: https://github.com/ankane/midas/issues/2


Can this do it vertical instead of horizontal?

No, horizontal only. I don't see us adding vertical support in the future either.


[otbn] Create block-level simulation

This is still a pre-DV thing (although we'll hopefully be able to use some of it at "DV-time").
Wrap up a "stepping" ISS and the RTL simulation. Eventually we'll do step-by-step state diffs, but that depends on instruction tracing that doesn't yet exist. Until then, just dump final reg file and memory and check they match.

estimate 16

Much of this is now done, but we're not yet dumping register contents. Probably 4 "story points" of work remaining.


Add apt keys as task

I have also tested this change on Xenial/Bionic VMs, so not just
Docker images. This change is also necessary for Bionic support, since
the 04EE7237B7D453EC key is not available there by default.

ping @emmetog

Ping @emmetog 😄

Thanks @nre-ableton !

@emmetog Thanks!


docs(meshroutes): adjust tables to new format

adjust targetref tables to new format
Did you sign your commit? Instructions yes
Have you read Contributing guidelines? yes
https://deploy-preview-1621--kuma.netlify.app/docs/dev/policies/meshtcproute/#targetref-support-matrix
and
https://deploy-preview-1621--kuma.netlify.app/docs/dev/policies/meshhttproute/#targetref-support-matrix

It was covered by: https://github.com/kumahq/kuma-website/pull/1626


ENH: sparse: revisit default index dtype selection in sparray constructors

Let's turn on default check_contents of index dtype in csr_array() while adding a new keyword argument to turn it off. Something like:
csr_array((data, coords), auto_index_dtype=False)
Justification:
The current approach in csr_array was introduced in #18509 and turns off automatic index dtype discovery for sparray while leaving it turned on for spmatrix. There are three comments at the end of 18509 which discuss the problems associated with this approach. It is harder for many/most users, and requires a large code change in order to switch to sparray.
The many popular 32bit-index sparse tools make it hard to switch to 64bit-index sparse arrays. But selecting the minimal index dtype needed is hard. Even NumPy doesn't provide a nice interface to return the minimal dtype needed to hold some data. We have one in get_index_dtype with the check_contents option set, but changing all existing code to add calls to that function and use the result to cast their index arrays is a daunting task.
The arguments for avoiding check_contents inside `get_index_dtype() were stated in #18509 as:

it is expensive to compute max index value to find the smallest dtype
it is hard to force int64 indices when we anticipate needing them for later steps in our algorithm

The arguments for turning on check_contents by default in sparray constructors:

lots of existing code relies on default numpy dtypes, which for most systems today are 64bit.
lots of existing sparse code and sparse libraries use 32bit index arrays.
the many users of these many 32bit libraries suggest that for many/most use-cases, 32bit indexing is sufficient.
using 64bit index arrays as the default takes more memory. Sparse is supposed to save memory.

I think we can avoid checking contents when needed while gaining the advantages of the current spmatrix default by introducing a keyword argument that turns off check_contents inside get_index_dtype during sparray construction. This does mean sparray will change its default handling of index array dtype.
Impacts:
I don't think the disruption of such a change will be large:

the default matches spmatrix
only a small number of users 1) have switched to sparray, and 2) care about downcasting of index arrays being too expensive is quite small. And I think they are the early adopter type who will be willing to add the keyword arg to their performance code.

We are comparing the pain of early adopter coders adding a performance oriented keyword arg, to the pain of the large number of users of 32bit sparse libraries having to rewrite their index array creation code to manually set the dtype of every index array.
Thoughts?

While I certainly don't claim a deep grasp of the sparse landscape, I'd suggest to seriously consider making sparse arrays either always use 64-bit integers (preferred IMO) or make the int32/int64 choice a ctor kwarg.

Providing a ctor argument is often a bit tricky with sparse container types, because we create many objects internally for various functions. So even if a user passes a check_contents keyword argument, then operations returning a new sparse array (slicing, arithmetic, etc) may not be consistent with that setting.
My current position is that we should work to update native code to support 64-bit indices where possible, and provide a utility function that does safe downcasting as a minimal fix for cases that can't/won't update. Kind of like the old six.ensure_str() approach.

Thanks for this -- I see that a ctor arg implies a contract to keep that "state" with subsequent format changes and with operations results. Plus, we'd have to make rules for binop/interacting sparse containers with different states. That seems fragile for sure.
The expressed preference for all index arrays to be int64 is certainly easier to maintain. And I guess it "only" costs a factor of 2 in memory storage. But at present it would limit users significantly. Combined with the argument against keeping and propagating a state attribute for how to handle idx_dtype, it seems that the default should tend toward int64 indices in the long run, and this switch to sparray is an opportunity to take a step in that direction. But the move away from matrix api is orthogonal to the move toward int64 index dtypes. If we put too many changes together it will likely take longer for people to migrate to to sparray. I suppose we could make the idx_dtype change in both sparray and spmatrix with appropriate deprecation cycles. But it looks like the decision to avoid that has been made. spmatrix will stay with value-based index dtypes to avoid backward incompatibility.
So, how can we help who need to deal with int32 indexing. We can certainly help with updating native code in SciPy to work with 64bit indices. But I doubt we will be able to help with the many other 32-bit libraries used for sparse algorithms. I'll take a look at what 32-bit sparse libraries scikit-learn and scikit-image use to get a feel for how many packages we are talking about.
Meanwhile, we have a PR to provide a function to safely cast indices from an existing containers to a prescribed idx_dtype. And we already have get_index_dtype() which returns an idx_dtype for folks to use as they create their index arrays. Are there other helper functions that would be good for this? I suppose one that takes index arrays, uses get_index_dtype to find an idx_dtype and then casts the arrays accordingly. Like new_arrays = autocast_index_arrays(arrays, maxval, check_contents, copy). Are there other good helper functions?

I like the helper function you proposed, thanks!


Remove disabled from TestInfoParser

disabled is replaced by disable

Signed-off-by: renfeiw<EMAIL_ADDRESS>

Grinder_TKG/1457, Grinder_TKG/1459

@renfeiw could you double-check that we do not have disabled in the following openj9 branch? Thanks https://github.com/eclipse-openj9/openj9/tree/v0.29.0-release https://github.com/eclipse-openj9/openj9/tree/v0.29.1-release

Checked, the branches are not using  tag.


Remove JSON-encoded provider config

Looks like we could remove the complex JSON encoding in provider serde:
https://github.com/pulumi/pulumi/pull/15032

Wow, nice!
On Thu 9. May 2024 at 14:37, Paweł Prażak @.***> wrote:

Looks like we could remove the complex JSON encoding in provider serde:
pulumi/pulumi#15032 https://github.com/pulumi/pulumi/pull/15032
—
Reply to this email directly, view it on GitHub
https://github.com/VirtusLab/besom/issues/490, or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACBVNUUCB2KOAGEXUIOF4ATZBNUWZAVCNFSM6AAAAABHOXX5GOVHI2DSMVQWIX3LMV43ASLTON2WKOZSGI4DONRQG42DQNQ
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>


CAMEL-13319 - TwitterConverter calls deprecated getSenderScreenName, throws UnsupportedOperationException

https://issues.apache.org/jira/browse/CAMEL-13319

Thanks. Merged on master, camel-2.x, camel-2.23.x and camel-2.22.x

Would it feasible to merge to camel-2.21.x too, as syndesis depends on this version.

No, it's not feasible.


Is there any Training scripts?

Thanks for your codes. However, I have a question. Why the iteration step is 1? When I tried to set it, say 100, the result sucks, since only the outcome of step 1 is fine and others are just mixed pieces of style picture and content picture.
And I notice that the original paper says it needs to be trained on coco, so did you implement the training codes?

Step in Eval.py - this is the number of stylization iterations per image, i.e. it is not network training, but evaluation. The typical value of this parameter is 1, as you noticed, but you can set values up to 5, they in many cases allow you to achieve better results than at 1. Training codes (Train.ipynb) I posted. Trained on Google Colab using the parameters specified in the author's paper.

Thanks a lot!


Docs need to force https. Disqus tracks both separately.

From @k-funk on July 11, 2016 19:13
Bug:
Current behavior: Different Disqus comments depending on usage of http/https.
Reproduce: visit both links, view Disqus comments

https://webpack.github.io/docs/usage-with-gulp.html
http://webpack.github.io/docs/usage-with-gulp.html

Copied from original issue: webpack/webpack#2758

With the new docs this is still relevant, but not very important. I still would like to move to https if possible. Also allows us to use http/2, which is nice.

@indus Any thoughts on this? Can js.org be forced to https somehow?

It could - but -  only when i force everybody to https (and thats not what i want; it would propably break other pages).
I would suggest this solution. Looks a bit hackish but works great. And when JavaScript is disabled in a browser, there would be no Disqus anyway, or am I wrong?

Forget about my last post. Its 2016 and enforcing SSL is a good thing. This only affects all requester that opted-in to use Cloudflares "Universal SSL" and all that requested after it became default, all others can still use http. I think that is the cleanest solution not only for your project.
So you should now notice enforced https when you serve your page.

Great work. Closing.

Is this deployed/fixed on the live site? The http link i posted still doesn't redirect to the https version.

@k-funk, this is the repo for the new docs website for webpack v2. It was also an issue on the new website, which is fixed now.


Text widget auto converts some strings to emoji/symbol(?) upon render

Text widget automatically converts some strings to emoji/symbol(?) upon rendering on web (tested on Chrome and Safari) and mobile (tested on iOS only for now).
I have found out that "edge" and "ember" seems to be converting itself to some kind of symbol/emoji(?).
I've been searching the web for similar issues but found none - am I going mad or could someone explain or replicate this? 😆
I've just found out while working on a flutter web and thought it was only for web but it turns out it affects mobile too (which I'm highly doubtful of)! Also tried adding a generic :) to see if it converts to an emoji, but it doesn't seem to do that.
In Code:
Text('To wisdom belongs the intellectual apprehension of eternal things; to knowledge, the rational knowledge of temporal things.')
On Web:

In Code:
Text('To wisdom belongs the intellectual apprehension of eternal things; to knowledge, the rational knowledge of temporal things. :) ember')
On iOS:

I am on latest Flutter Master channel.

UPDATE: I'm confident that the culprit is my imported font Font Awesome. If this is the case, how should one prevent this from happening?

Hi @json469
Are you using font_awesome_flutter
If that's the cause of the use, the issue is related to a 3rd party plugin rather than to Flutter itself. Please open the issue in the dedicated repository. or open issue on whichever font awesome flutter package you're using
If the problem persist without using third party packages,  Can you please provide your flutter doctor -v your flutter run --verbose and a complete reproducible minimal code sample
Thank you

Without additional information we are unfortunately not sure how to resolve this issue.
We are therefore reluctantly going to close this bug for now.
Please don't hesitate to comment on the bug if you have any more information for us; we will reopen it right away!
Thanks for your contribution.


Why Ctrl+q kills the terminal ? Should we switch the behavior of Ctrl+q and Ctrl+Shift+q ?

Description of the problem or steps to reproduce
I realize the following key bindings behavior:

Ctrl+q: Exits micro and kills the terminal (even if the terminal has several tabs open)
Ctrl+Shift+q: Exits micro and returns to the terminal

Can we switch these two key bindings ?
Make Ctrl+q to exit micro and return to the terminal ?
Version: 2.0.13
Commit hash: 68d88b57
Compiled on October 21, 2023

Micro has no control over keybindings for your terminal. On my terminal emulator (and probably most others) pressing Ctrl-q in micro returns to terminal as you'd expect. You should check the manual for whichever terminal emulator you're using for instructions to change its keybindings.

OK, got it, thanks for the reply.
The Ctrl+q binding is being handled by the terminal and not micro itself.