Cf autoscaling issue

The application is unable to scale up/down when i tried to deploy CF autoscaler release
https://github.com/cloudfoundry-incubator/app-autoscaler-release/tree/master
Location for app-autoscaler tree is mentioned below
https://github.com/cloudfoundry-incubator/app-autoscaler/tree/cef9090c0b2b1d18dd1c9fac9ce9f2896abd5d6b
Issue description.
In past release (unfortunately i don't have the location of the code which i deployed ).We used scale up/down based on memoryutil .
With latest master branch for app-autoscaler-release we are unable to scale-up/down .It work perfectly fine with requests/persec configuration .Please find my policy attached .
{
  "instance_min_count": 1,
  "instance_max_count": 4,
  "scaling_rules": [{
    "metric_type": "memoryutil",
    "stat_window_secs": 60,
    "breach_duration_secs": 100,
    "threshold": 49,
    "operator": "<",
    "cool_down_secs": 60,
    "adjustment": "-1"
  }, {
    "metric_type": "memoryutil",
    "stat_window_secs": 60,
    "breach_duration_secs": 100,
    "threshold": 50,
    "operator": ">=",
    "cool_down_secs": 60,
    "adjustment": "+1"
  }]
}

covladmins-MacBook-Pro-6:~ nsharma$ cf app hello-world
Showing health and status for app hello-world in org paas / space properties as nsharma...
OK

requested state: started
instances: 1/1
usage: 1G x 1 instances
urls: hello-world-new.run.us2.covapp.io
last uploaded: Thu Jul 26 19:27:31 UTC 2018
stack: covs-internal-stack
buildpack: covs-java-III

     state     since                    cpu    memory         disk           details
#0   running   2018-07-27 04:14:41 PM   0.1%   760.4M of 1G   317.7M of 1G ```

![app-autoscaler- cef9090c0b2b1d18dd1c9fac9ce9f2896abd5d6b](https://user-images.githubusercontent.com/11034994/43407355-868e3604-93ec-11e8-8f7d-40c282794404.png)
![old_master](https://user-images.githubusercontent.com/11034994/43407356-869774a8-93ec-11e8-97ae-706cb8ee3ef9.png)

@nsharmacovs  , just want to clarify the situation a little bit:
You mentioned:
In past release (unfortunately i don't have the location of the code which i deployed ).We used scale up/down based on memoryutil .

With latest master branch for app-autoscaler-release we are unable to scale-up/down .It work perfectly fine with requests/persec configuration

So, if my understanding is correct, the situation could be summarized as below:

with an older master auto-scaling-release (commit number unknown),   scale-up/down works CORRECTLY  based on memoryutil .

with the latest master release  (commit ef9090c0b2b1d18dd1c9fac9ce9f2896abd5d6b), CAN't scale up/down with memoryutil but  CAN scale up/down with requests/persec ?
So, only not the entire scale up/down functions broken, but just the memoryutil based scale up/down?

Yes your understanding is correct..
Also , i have one more  question :-

Can we do autoscaling based on CPU metrics ?

I did some more investigation of my part and found that memoryutil metrics works with Diego containers only, where was memoryused,RPS etc works with Diego and DEA.
Just for your information, we are running CF 256(DEA+Diego) and not yet migrated to CF deployments(Diego only) .

what is finding led to the conclusion "memoryutil metrics works with Diego containers only, where was memoryused,RPS etc works with Diego and DEA."  ?   all these metrics should work with Diego.  For DEA, I don't have an environment to try out with it now, but I think it should work with all metrics as well.

@nsharmacovs
Some operations may help to debug this issue:
1 As you mentioned, there is no memoryutil data in app_metric table, could you check whether there are data in appinstancemetrics table for the app in the same duration as you queried app_metric table. If there are data in appinstancemetrics, continue. Or there is no data, I think there maybe some issue in the cf env that the autoscaler can not pull metrics from it.
2 As there are data in appinstancemetrics table but no data in app_metric table. Could you check the  eventgenerator log to see whether there are error logs for saving app_metrics to database?
3 Please attach the whole configuration files of metricscollector and eventgenerator in your bosh deployment so we can check whether there are some configuration issue.

Please find the logs attached from metriccollector for DEA and DIEGO.
Policy defined as below
{
  "instance_min_count": 1,
  "instance_max_count": 4,
  "scaling_rules": [{
    "metric_type": "memoryutil",
    "stat_window_secs": 60,
    "breach_duration_secs": 100,
    "threshold": 49,
    "operator": "<",
    "cool_down_secs": 60,
    "adjustment": "-1"
  }, {
    "metric_type": "memoryutil",
    "stat_window_secs": 60,
    "breach_duration_secs": 100,
    "threshold": 50,
    "operator": ">=",
    "cool_down_secs": 60,
    "adjustment": "+1"
  }]
}```

DEA container :-
Showing health and status for app hello-world in org paas / space properties as nsharma...
OK

requested state: started
instances: 1/1
usage: 1G x 1 instances
urls: hello-world-new.run.us2.covapp.io
last uploaded: Mon Jul 30 17:17:21 UTC 2018
stack: covs-internal-stack
buildpack: covs-java-III

     state     since                    cpu    memory         disk           details
#0   running   2018-07-31 12:08:58 PM   0.0%   565.7M of 1G   317.7M of 1G```

{"data":{"metric":{"app_id":"c03231de-202e-4396-a1ee-a7166460187c","collected_at":1.533053829154743e+18,"instance_index":0,"name":"memoryused","timestamp":1.5330538291355292e+18,"unit":"MB","value":"572"},"session":"10"},"log_level":0,"log_time":"2018-07-31T16:17:09Z","message":"metricscollector.app-streamer.process-event-get-memoryused-metric","source":"metricscollector","timestamp":"1533053829.154748440"}
{"data":{"metric":null,"session":"10"},"log_level":0,"log_time":"2018-07-31T16:17:09Z","message":"metricscollector.app-streamer.process-event-get-memoryutil-metric","source":"metricscollector","timestamp":"1533053829.154921770"}
{"data":{"event":{"containerMetric":{"applicationId":"c03231de-202e-4396-a1ee-a7166460187c","cpuPercentage":1.4036672798381065,"diskBytes":3.33152256e+08,"instanceIndex":0,"memoryBytes":6.15030784e+08},"deployment":"cf","eventType":9,"index":"c417fd31-a21c-45a9-b35a-d291338b96e6","ip":"<IP_ADDRESS>","job":"ao_runner_internal_z2","origin":"DEA","timestamp":1.5330538591405343e+18},"session":"10"},"log_level":0,"log_time":"2018-07-31T16:17:39Z","message":"metricscollector.app-streamer.process-event-get-containermetric-event","source":"metricscollector","timestamp":"1533053859.146079779"}
{"data":{"metric":{"app_id":"c03231de-202e-4396-a1ee-a7166460187c","collected_at":1.5330538591463685e+18,"instance_index":0,"name":"memoryused","timestamp":1.5330538591405343e+18,"unit":"MB","value":"587"},"session":"10"},"log_level":0,"log_time":"2018-07-31T16:17:39Z","message":"metricscollector.app-streamer.process-event-get-memoryused-metric","source":"metricscollector","timestamp":"1533053859.146374226"}
{"data":{"metric":null,"session":"10"},"log_level":0,"log_time":"2018-07-31T16:17:39Z","message":"metricscollector.app-streamer.process-event-get-memoryutil-metric","source":"metricscollector","timestamp":"1533053859.146582127"}
{"data":{"appId":"c03231de-202e-4396-a1ee-a7166460187c","end":["1533053866311132434"],"metrictype":"memoryutil","order":["ASC"],"session":"4","start":["1533053806311132434"]},"log_level":0,"log_time":"2018-07-31T16:17:46Z","message":"metricscollector.http_server.get-metric-histories","source":"metricscollector","timestamp":"1533053866.311388016"}
{"data":{"appId":"c03231de-202e-4396-a1ee-a7166460187c","end":["1533053866311350143"],"metrictype":"memoryutil","order":["ASC"],"session":"4","start":["1533053806311350143"]},"log_level":0,"log_time":"2018-07-31T16:17:46Z","message":"metricscollector.http_server.get-metric-histories","source":"metricscollector","timestamp":"1533053866.311697960"}
{"data":{"event":{"containerMetric":{"applicationId":"c03231de-202e-4396-a1ee-a7166460187c","cpuPercentage":0.11964180884995643,"diskBytes":3.33152256e+08,"instanceIndex":0,"memoryBytes":6.1503488e+08},"deployment":"cf","eventType":9,"index":"c417fd31-a21c-45a9-b35a-d291338b96e6","ip":"<IP_ADDRESS>","job":"ao_runner_internal_z2","origin":"DEA","timestamp":1.5330538891462648e+18},"session":"10"},"log_level":0,"log_time":"2018-07-31T16:18:09Z","message":"metricscollector.app-streamer.process-event-get-containermetric-event","source":"metricscollector","timestamp":"1533053889.171801805"}
{"data":{"metric":{"app_id":"c03231de-202e-4396-a1ee-a7166460187c","collected_at":1.5330538891720794e+18,"instance_index":0,"name":"memoryused","timestamp":1.5330538891462648e+18,"unit":"MB","value":"587"},"session":"10"},"log_level":0,"log_time":"2018-07-31T16:18:09Z","message":"metricscollector.app-streamer.process-event-get-memoryused-metric","source":"metricscollector","timestamp":"1533053889.172084808"}
{"data":{"metric":null,"session":"10"},"log_level":0,"log_time":"2018-07-31T16:18:09Z","message":"metricscollector.app-streamer.process-event-get-memoryutil-metric","source":"metricscollector","timestamp":"1533053889.172315836"}
{"data":{"appId":"c03231de-202e-4396-a1ee-a7166460187c","end":["1533053906311246774"],"metrictype":"memoryutil","order":["ASC"],"session":"4","start":["1533053846311246774"]},"log_level":0,"log_time":"2018-07-31T16:18:26Z","message":"metricscollector.http_server.get-metric-histories","source":"metricscollector","timestamp":"1533053906.311526537"}
{"data":{"appId":"c03231de-202e-4396-a1ee-a7166460187c","end":["1533053906311207799"],"metrictype":"memoryutil","order":["ASC"],"session":"4","start":["1533053846311207799"]},"log_level":0,"log_time":"2018-07-31T16:18:26Z","message":"metricscollector.http_server.get-metric-histories","source":"metricscollector","timestamp":"1533053906.311607361"}
{"data":{"event":{"containerMetric":{"applicationId":"c03231de-202e-4396-a1ee-a7166460187c","cpuPercentage":0.27444242639010397,"diskBytes":3.33152256e+08,"instanceIndex":0,"memoryBytes":6.15133184e+08},"deployment":"cf","eventType":9,"index":"c417fd31-a21c-45a9-b35a-d291338b96e6","ip":"<IP_ADDRESS>","job":"ao_runner_internal_z2","origin":"DEA","timestamp":1.5330539191531167e+18},"session":"10"},"log_level":0,"log_time":"2018-07-31T16:18:39Z","message":"metricscollector.app-streamer.process-event-get-containermetric-event","source":"metricscollector","timestamp":"1533053919.169936419"}
{"data":{"metric":{"app_id":"c03231de-202e-4396-a1ee-a7166460187c","collected_at":1.5330539191702144e+18,"instance_index":0,"name":"memoryused","timestamp":1.5330539191531167e+18,"unit":"MB","value":"587"},"session":"10"},"log_level":0,"log_time":"2018-07-31T16:18:39Z","message":"metricscollector.app-streamer.process-event-get-memoryused-metric","source":"metricscollector","timestamp":"1533053919.170219660"}
{"data":{"metric":null,"session":"10"},"log_level":0,"log_time":"2018-07-31T16:18:39Z","message":"metricscollector.app-streamer.process-event-get-memoryutil-metric","source":"metricscollector","timestamp":"1533053919.170441389"}
{"data":{"appId":"c03231de-202e-4396-a1ee-a7166460187c","end":["1533053946311147061"],"metrictype":"memoryutil","order":["ASC"],"session":"4","start":["1533053886311147061"]},"log_level":0,"log_time":"2018-07-31T16:19:06Z","message":"metricscollector.http_server.get-metric-histories","source":"metricscollector","timestamp":"1533053946.311497211"}
{"data":{"appId":"c03231de-202e-4396-a1ee-a7166460187c","end":["1533053946311232856"],"metrictype":"memoryutil","order":["ASC"],"session":"4","start":["1533053886311232856"]},"log_level":0,"log_time":"2018-07-31T16:19:06Z","message":"metricscollector.http_server.get-metric-histories","source":"metricscollector","timestamp":"1533053946.311847925"}
{"data":{"event":{"containerMetric":{"applicationId":"c03231de-202e-4396-a1ee-a7166460187c","cpuPercentage":0.10315671294712296,"diskBytes":3.33152256e+08,"instanceIndex":0,"memoryBytes":6.15133184e+08},"deployment":"cf","eventType":9,"index":"c417fd31-a21c-45a9-b35a-d291338b96e6","ip":"<IP_ADDRESS>","job":"ao_runner_internal_z2","origin":"DEA","timestamp":1.5330539491587226e+18},"session":"10"},"log_level":0,"log_time":"2018-07-31T16:19:09Z","message":"metricscollector.app-streamer.process-event-get-containermetric-event","source":"metricscollector","timestamp":"1533053949.172878027"}
{"data":{"metric":{"app_id":"c03231de-202e-4396-a1ee-a7166460187c","collected_at":1.533053949173177e+18,"instance_index":0,"name":"memoryused","timestamp":1.5330539491587226e+18,"unit":"MB","value":"587"},"session":"10"},"log_level":0,"log_time":"2018-07-31T16:19:09Z","message":"metricscollector.app-streamer.process-event-get-memoryused-metric","source":"metricscollector","timestamp":"1533053949.173182726"}
{"data":{"metric":null,"session":"10"},"log_level":0,"log_time":"2018-07-31T16:19:09Z","message":"metricscollector.app-streamer.process-event-get-memoryutil-metric","source":"metricscollector","timestamp":"1533053949.173395872"} ```

Diego Container works fine:-
{"data":{"appId":"c03231de-202e-4396-a1ee-a7166460187c","end":["1533053786311254400"],"metrictype":"memoryutil","order":["ASC"],"session":"4","start":["1533053726311254400"]},"log_level":0,"log_time":"2018-07-31T16:16:26Z","message":"metricscollector.http_server.get-metric-histories","source":"metricscollector","timestamp":"1533053786.311712027"}
{"data":{"event":{"containerMetric":{"applicationId":"c03231de-202e-4396-a1ee-a7166460187c","cpuPercentage":0.2660120643811918,"diskBytes":3.33152256e+08,"instanceIndex":0,"memoryBytes":5.9994112e+08},"deployment":"cf","eventType":9,"index":"c417fd31-a21c-45a9-b35a-d291338b96e6","ip":"<IP_ADDRESS>","job":"ao_runner_internal_z2","origin":"DEA","timestamp":1.533053799132011e+18},"session":"10"},"log_level":0,"log_time":"2018-07-31T16:16:39Z","message":"metricscollector.app-streamer.process-event-get-containermetric-event","source":"metricscollector","timestamp":"1533053799.141810894"}
{"data":{"metric":{"app_id":"c03231de-202e-4396-a1ee-a7166460187c","collected_at":1.5330537991420833e+18,"instance_index":0,"name":"memoryused","timestamp":1.533053799132011e+18,"unit":"MB","value":"572"},"session":"10"},"log_level":0,"log_time":"2018-07-31T16:16:39Z","message":"metricscollector.app-streamer.process-event-get-memoryused-metric","source":"metricscollector","timestamp":"1533053799.142088890"}
{"data":{"metric":null,"session":"10"},"log_level":0,"log_time":"2018-07-31T16:16:39Z","message":"metricscollector.app-streamer.process-event-get-memoryutil-metric","source":"metricscollector","timestamp":"1533053799.142276049"}
{"data":{"appId":"c03231de-202e-4396-a1ee-a7166460187c","end":["1533053826311182115"],"metrictype":"memoryutil","order":["ASC"],"session":"4","start":["1533053766311182115"]},"log_level":0,"log_time":"2018-07-31T16:17:06Z","message":"metricscollector.http_server.get-metric-histories","source":"metricscollector","timestamp":"1533053826.311442375"}
{"data":{"appId":"c03231de-202e-4396-a1ee-a7166460187c","end":["1533053826311141920"],"metrictype":"memoryutil","order":["ASC"],"session":"4","start":["1533053766311141920"]},"log_level":0,"log_time":"2018-07-31T16:17:06Z","message":"metricscollector.http_server.get-metric-histories","source":"metricscollector","timestamp":"1533053826.311459541"}
{"data":{"event":{"containerMetric":{"applicationId":"c03231de-202e-4396-a1ee-a7166460187c","cpuPercentage":0.11941110790684305,"diskBytes":3.33152256e+08,"instanceIndex":0,"memoryBytes":5.9994112e+08},"deployment":"cf","eventType":9,"index":"c417fd31-a21c-45a9-b35a-d291338b96e6","ip":"<IP_ADDRESS>","job":"ao_runner_internal_z2","origin":"DEA","timestamp":1.5330538291355292e+18},"session":"10"},"log_level":0,"log_time":"2018-07-31T16:17:09Z","message":"metricscollector.app-streamer.process-event-get-containermetric-event","source":"metricscollector","timestamp":"1533053829.154466629"}
{"data":{"metric":{"app_id":"c03231de-202e-4396-a1ee-a7166460187c","collected_at":1.533053829154743e+18,"instance_index":0,"name":"memoryused","timestamp":1.5330538291355292e+18,"unit":"MB","value":"572"},"session":"10"},"log_level":0,"log_time":"2018-07-31T16:17:09Z","message":"metricscollector.app-streamer.process-event-get-memoryused-metric","source":"metricscollector","timestamp":"1533053829.154748440"}
{"data":{"metric":null,"session":"10"},"log_level":0,"log_time":"2018-07-31T16:17:09Z","message":"metricscollector.app-streamer.process-event-get-memoryutil-metric","source":"metricscollector","timestamp":"1533053829.154921770"}
{"data":{"event":{"containerMetric":{"applicationId":"c03231de-202e-4396-a1ee-a7166460187c","cpuPercentage":1.4036672798381065,"diskBytes":3.33152256e+08,"instanceIndex":0,"memoryBytes":6.15030784e+08},"deployment":"cf","eventType":9,"index":"c417fd31-a21c-45a9-b35a-d291338b96e6","ip":"<IP_ADDRESS>","job":"ao_runner_internal_z2","origin":"DEA","timestamp":1.5330538591405343e+18},"session":"10"},"log_level":0,"log_time":"2018-07-31T16:17:39Z","message":"metricscollector.app-streamer.process-event-get-containermetric-event","source":"metricscollector","timestamp":"1533053859.146079779"}
{"data":{"metric":{"app_id":"c03231de-202e-4396-a1ee-a7166460187c","collected_at":1.5330538591463685e+18,"instance_index":0,"name":"memoryused","timestamp":1.5330538591405343e+18,"unit":"MB","value":"587"},"session":"10"},"log_level":0,"log_time":"2018-07-31T16:17:39Z","message":"metricscollector.app-streamer.process-event-get-memoryused-metric","source":"metricscollector","timestamp":"1533053859.146374226"}
{"data":{"metric":null,"session":"10"},"log_level":0,"log_time":"2018-07-31T16:17:39Z","message":"metricscollector.app-streamer.process-event-get-memoryutil-metric","source":"metricscollector","timestamp":"1533053859.146582127"}
{"data":{"appId":"c03231de-202e-4396-a1ee-a7166460187c","end":["1533053866311132434"],"metrictype":"memoryutil","order":["ASC"],"session":"4","start":["1533053806311132434"]},"log_level":0,"log_time":"2018-07-31T16:17:46Z","message":"metricscollector.http_server.get-metric-histories","source":"metricscollector","timestamp":"1533053866.311388016"}
{"data":{"appId":"c03231de-202e-4396-a1ee-a7166460187c","end":["1533053866311350143"],"metrictype":"memoryutil","order":["ASC"],"session":"4","start":["1533053806311350143"]},"log_level":0,"log_time":"2018-07-31T16:17:46Z","message":"metricscollector.http_server.get-metric-histories","source":"metricscollector","timestamp":"1533053866.311697960"}
{"data":{"event":{"containerMetric":{"applicationId":"c03231de-202e-4396-a1ee-a7166460187c","cpuPercentage":0.11964180884995643,"diskBytes":3.33152256e+08,"instanceIndex":0,"memoryBytes":6.1503488e+08},"deployment":"cf","eventType":9,"index":"c417fd31-a21c-45a9-b35a-d291338b96e6","ip":"<IP_ADDRESS>","job":"ao_runner_internal_z2","origin":"DEA","timestamp":1.5330538891462648e+18},"session":"10"},"log_level":0,"log_time":"2018-07-31T16:18:09Z","message":"metricscollector.app-streamer.process-event-get-containermetric-event","source":"metricscollector","timestamp":"1533053889.171801805"}
{"data":{"metric":{"app_id":"c03231de-202e-4396-a1ee-a7166460187c","collected_at":1.5330538891720794e+18,"instance_index":0,"name":"memoryused","timestamp":1.5330538891462648e+18,"unit":"MB","value":"587"},"session":"10"},"log_level":0,"log_time":"2018-07-31T16:18:09Z","message":"metricscollector.app-streamer.process-event-get-memoryused-metric","source":"metricscollector","timestamp":"1533053889.172084808"}
{"data":{"metric":null,"session":"10"},"log_level":0,"log_time":"2018-07-31T16:18:09Z","message":"metricscollector.app-streamer.process-event-get-memoryutil-metric","source":"metricscollector","timestamp":"1533053889.172315836"}
{"data":{"appId":"c03231de-202e-4396-a1ee-a7166460187c","end":["1533053906311246774"],"metrictype":"memoryutil","order":["ASC"],"session":"4","start":["1533053846311246774"]},"log_level":0,"log_time":"2018-07-31T16:18:26Z","message":"metricscollector.http_server.get-metric-histories","source":"metricscollector","timestamp":"1533053906.311526537"}
{"data":{"appId":"c03231de-202e-4396-a1ee-a7166460187c","end":["1533053906311207799"],"metrictype":"memoryutil","order":["ASC"],"session":"4","start":["1533053846311207799"]},"log_level":0,"log_time":"2018-07-31T16:18:26Z","message":"metricscollector.http_server.get-metric-histories","source":"metricscollector","timestamp":"1533053906.311607361"}
{"data":{"event":{"containerMetric":{"applicationId":"c03231de-202e-4396-a1ee-a7166460187c","cpuPercentage":0.27444242639010397,"diskBytes":3.33152256e+08,"instanceIndex":0,"memoryBytes":6.15133184e+08},"deployment":"cf","eventType":9,"index":"c417fd31-a21c-45a9-b35a-d291338b96e6","ip":"<IP_ADDRESS>","job":"ao_runner_internal_z2","origin":"DEA","timestamp":1.5330539191531167e+18},"session":"10"},"log_level":0,"log_time":"2018-07-31T16:18:39Z","message":"metricscollector.app-streamer.process-event-get-containermetric-event","source":"metricscollector","timestamp":"1533053919.169936419"}
{"data":{"metric":{"app_id":"c03231de-202e-4396-a1ee-a7166460187c","collected_at":1.5330539191702144e+18,"instance_index":0,"name":"memoryused","timestamp":1.5330539191531167e+18,"unit":"MB","value":"587"},"session":"10"},"log_level":0,"log_time":"2018-07-31T16:18:39Z","message":"metricscollector.app-streamer.process-event-get-memoryused-metric","source":"metricscollector","timestamp":"1533053919.170219660"}
{"data":{"metric":null,"session":"10"},"log_level":0,"log_time":"2018-07-31T16:18:39Z","message":"metricscollector.app-streamer.process-event-get-memoryutil-metric","source":"metricscollector","timestamp":"1533053919.170441389"}
{"data":{"appId":"c03231de-202e-4396-a1ee-a7166460187c","end":["1533053946311147061"],"metrictype":"memoryutil","order":["ASC"],"session":"4","start":["1533053886311147061"]},"log_level":0,"log_time":"2018-07-31T16:19:06Z","message":"metricscollector.http_server.get-metric-histories","source":"metricscollector","timestamp":"1533053946.311497211"}
{"data":{"appId":"c03231de-202e-4396-a1ee-a7166460187c","end":["1533053946311232856"],"metrictype":"memoryutil","order":["ASC"],"session":"4","start":["1533053886311232856"]},"log_level":0,"log_time":"2018-07-31T16:19:06Z","message":"metricscollector.http_server.get-metric-histories","source":"metricscollector","timestamp":"1533053946.311847925"}
{"data":{"event":{"containerMetric":{"applicationId":"c03231de-202e-4396-a1ee-a7166460187c","cpuPercentage":0.10315671294712296,"diskBytes":3.33152256e+08,"instanceIndex":0,"memoryBytes":6.15133184e+08},"deployment":"cf","eventType":9,"index":"c417fd31-a21c-45a9-b35a-d291338b96e6","ip":"<IP_ADDRESS>","job":"ao_runner_internal_z2","origin":"DEA","timestamp":1.5330539491587226e+18},"session":"10"},"log_level":0,"log_time":"2018-07-31T16:19:09Z","message":"metricscollector.app-streamer.process-event-get-containermetric-event","source":"metricscollector","timestamp":"1533053949.172878027"}
{"data":{"metric":{"app_id":"c03231de-202e-4396-a1ee-a7166460187c","collected_at":1.533053949173177e+18,"instance_index":0,"name":"memoryused","timestamp":1.5330539491587226e+18,"unit":"MB","value":"587"},"session":"10"},"log_level":0,"log_time":"2018-07-31T16:19:09Z","message":"metricscollector.app-streamer.process-event-get-memoryused-metric","source":"metricscollector","timestamp":"1533053949.173182726"}
{"data":{"metric":null,"session":"10"},"log_level":0,"log_time":"2018-07-31T16:19:09Z","message":"metricscollector.app-streamer.process-event-get-memoryutil-metric","source":"metricscollector","timestamp":"1533053949.173395872"}
{"data":{"event":{"containerMetric":{"applicationId":"c03231de-202e-4396-a1ee-a7166460187c","cpuPercentage":0.26676323379470407,"diskBytes":3.33152256e+08,"instanceIndex":0,"memoryBytes":6.15305216e+08},"deployment":"cf","eventType":9,"index":"c417fd31-a21c-45a9-b35a-d291338b96e6","ip":"<IP_ADDRESS>","job":"ao_runner_internal_z2","origin":"DEA","timestamp":1.5330539791616686e+18},"session":"10"},"log_level":0,"log_time":"2018-07-31T16:19:39Z","message":"metricscollector.app-streamer.process-event-get-containermetric-event","source":"metricscollector","timestamp":"1533053979.181741714"}
{"data":{"metric":{"app_id":"c03231de-202e-4396-a1ee-a7166460187c","collected_at":1.533053979182004e+18,"instance_index":0,"name":"memoryused","timestamp":1.5330539791616686e+18,"unit":"MB","value":"587"},"session":"10"},"log_level":0,"log_time":"2018-07-31T16:19:39Z","message":"metricscollector.app-streamer.process-event-get-memoryused-metric","source":"metricscollector","timestamp":"1533053979.182008028"}
{"data":{"metric":null,"session":"10"},"log_level":0,"log_time":"2018-07-31T16:19:39Z","message":"metricscollector.app-streamer.process-event-get-memoryutil-metric","source":"metricscollector","timestamp":"1533053979.182161331"}
{"data":{"appId":"c03231de-202e-4396-a1ee-a7166460187c","end":["1533053986311326551"],"metrictype":"memoryutil","order":["ASC"],"session":"4","start":["1533053926311326551"]},"log_level":0,"log_time":"2018-07-31T16:19:46Z","message":"metricscollector.http_server.get-metric-histories","source":"metricscollector","timestamp":"1533053986.311561108"}
{"data":{"appId":"c03231de-202e-4396-a1ee-a7166460187c","end":["1533053986311270257"],"metrictype":"memoryutil","order":["ASC"],"session":"4","start":["1533053926311270257"]},"log_level":0,"log_time":"2018-07-31T16:19:46Z","message":"metricscollector.http_server.get-metric-histories","source":"metricscollector","timestamp":"1533053986.311869860"}
{"data":{"event":{"containerMetric":{"applicationId":"c03231de-202e-4396-a1ee-a7166460187c","cpuPercentage":0.12944969247275176,"diskBytes":3.33152256e+08,"instanceIndex":0,"memoryBytes":6.18348544e+08},"deployment":"cf","eventType":9,"index":"c417fd31-a21c-45a9-b35a-d291338b96e6","ip":"<IP_ADDRESS>","job":"ao_runner_internal_z2","origin":"DEA","timestamp":1.533054009167351e+18},"session":"10"},"log_level":0,"log_time":"2018-07-31T16:20:09Z","message":"metricscollector.app-streamer.process-event-get-containermetric-event","source":"metricscollector","timestamp":"1533054009.180141211"}
{"data":{"metric":{"app_id":"c03231de-202e-4396-a1ee-a7166460187c","collected_at":1.5330540091804163e+18,"instance_index":0,"name":"memoryused","timestamp":1.533054009167351e+18,"unit":"MB","value":"590"},"session":"10"},"log_level":0,"log_time":"2018-07-31T16:20:09Z","message":"metricscollector.app-streamer.process-event-get-memoryused-metric","source":"metricscollector","timestamp":"1533054009.180423498"}
{"data":{"metric":null,"session":"10"},"log_level":0,"log_time":"2018-07-31T16:20:09Z","message":"metricscollector.app-streamer.process-event-get-memoryutil-metric","source":"metricscollector","timestamp":"1533054009.180584669"}
{"data":{"appId":"c03231de-202e-4396-a1ee-a7166460187c","end":["1533054026311129026"],"metrictype":"memoryutil","order":["ASC"],"session":"4","start":["1533053966311129026"]},"log_level":0,"log_time":"2018-07-31T16:20:26Z","message":"metricscollector.http_server.get-metric-histories","source":"metricscollector","timestamp":"1533054026.311421871"}
{"data":{"appId":"c03231de-202e-4396-a1ee-a7166460187c","end":["1533054026311223907"],"metrictype":"memoryutil","order":["ASC"],"session":"4","start":["1533053966311223907"]},"log_level":0,"log_time":"2018-07-31T16:20:26Z","message":"metricscollector.http_server.get-metric-histories","source":"metricscollector","timestamp":"1533054026.311718941"}
{"data":{"event":{"containerMetric":{"applicationId":"c03231de-202e-4396-a1ee-a7166460187c","cpuPercentage":0.34749586965277013,"diskBytes":3.33152256e+08,"instanceIndex":0,"memoryBytes":6.45799936e+08},"deployment":"cf","eventType":9,"index":"c417fd31-a21c-45a9-b35a-d291338b96e6","ip":"<IP_ADDRESS>","job":"ao_runner_internal_z2","origin":"DEA","timestamp":1.5330540391717793e+18},"session":"10"},"log_level":0,"log_time":"2018-07-31T16:20:39Z","message":"metricscollector.app-streamer.process-event-get-containermetric-event","source":"metricscollector","timestamp":"1533054039.175348520"}
{"data":{"metric":{"app_id":"c03231de-202e-4396-a1ee-a7166460187c","collected_at":1.5330540391756078e+18,"instance_index":0,"name":"memoryused","timestamp":1.5330540391717793e+18,"unit":"MB","value":"616"},"session":"10"},"log_level":0,"log_time":"2018-07-31T16:20:39Z","message":"metricscollector.app-streamer.process-event-get-memoryused-metric","source":"metricscollector","timestamp":"1533054039.175613165"}
{"data":{"metric":null,"session":"10"},"log_level":0,"log_time":"2018-07-31T16:20:39Z","message":"metricscollector.app-streamer.process-event-get-memoryutil-metric","source":"metricscollector","timestamp":"1533054039.175771236"}
{"data":{"event":{"containerMetric":{"applicationId":"c03231de-202e-4396-a1ee-a7166460187c","cpuPercentage":0,"diskBytes":1.355776e+06,"diskBytesQuota":1.073741824e+09,"instanceIndex":0,"memoryBytes":249856,"memoryBytesQuota":1.073741824e+09},"deployment":"cf","eventType":9,"index":"07dd3bad-97be-43ff-8fbc-0533f2da50fb","ip":"<IP_ADDRESS>","job":"ao_diego_cell_internal_stack_z2","origin":"rep","timestamp":1.5330540520575286e+18},"session":"10"},"log_level":0,"log_time":"2018-07-31T16:20:52Z","message":"metricscollector.app-streamer.process-event-get-containermetric-event","source":"metricscollector","timestamp":"1533054052.072551727"}
{"data":{"metric":{"app_id":"c03231de-202e-4396-a1ee-a7166460187c","collected_at":1.5330540520728238e+18,"instance_index":0,"name":"memoryused","timestamp":1.5330540520575286e+18,"unit":"MB","value":"0"},"session":"10"},"log_level":0,"log_time":"2018-07-31T16:20:52Z","message":"metricscollector.app-streamer.process-event-get-memoryused-metric","source":"metricscollector","timestamp":"1533054052.072827339"}
{"data":{"metric":{"app_id":"c03231de-202e-4396-a1ee-a7166460187c","collected_at":1.5330540520729761e+18,"instance_index":0,"name":"memoryutil","timestamp":1.5330540520575286e+18,"unit":"%","value":"0"},"session":"10"},"log_level":0,"log_time":"2018-07-31T16:20:52Z","message":"metricscollector.app-streamer.process-event-get-memoryutil-metric","source":"metricscollector","timestamp":"1533054052.072979927"}
{"data":{"appId":"c03231de-202e-4396-a1ee-a7166460187c","end":["1533054066311217801"],"metrictype":"memoryutil","order":["ASC"],"session":"4","start":["1533054006311217801"]},"log_level":0,"log_time":"2018-07-31T16:21:06Z","message":"metricscollector.http_server.get-metric-histories","source":"metricscollector","timestamp":"1533054066.311486483"}
{"data":{"appId":"c03231de-202e-4396-a1ee-a7166460187c","end":["1533054066311374643"],"metrictype":"memoryutil","order":["ASC"],"session":"4","start":["1533054006311374643"]},"log_level":0,"log_time":"2018-07-31T16:21:06Z","message":"metricscollector.http_server.get-metric-histories","source":"metricscollector","timestamp":"1533054066.311936855"}
{"data":{"event":{"containerMetric":{"applicationId":"c03231de-202e-4396-a1ee-a7166460187c","cpuPercentage":182.09221891654653,"diskBytes":3.34491648e+08,"diskBytesQuota":1.073741824e+09,"instanceIndex":0,"memoryBytes":4.60128256e+08,"memoryBytesQuota":1.073741824e+09},"deployment":"cf","eventType":9,"index":"07dd3bad-97be-43ff-8fbc-0533f2da50fb","ip":"<IP_ADDRESS>","job":"ao_diego_cell_internal_stack_z2","origin":"rep","timestamp":1.5330540670742047e+18},"session":"10"},"log_level":0,"log_time":"2018-07-31T16:21:07Z","message":"metricscollector.app-streamer.process-event-get-containermetric-event","source":"metricscollector","timestamp":"1533054067.089231968"}
{"data":{"metric":{"app_id":"c03231de-202e-4396-a1ee-a7166460187c","collected_at":1.533054067089519e+18,"instance_index":0,"name":"memoryused","timestamp":1.5330540670742047e+18,"unit":"MB","value":"439"},"session":"10"},"log_level":0,"log_time":"2018-07-31T16:21:07Z","message":"metricscollector.app-streamer.process-event-get-memoryused-metric","source":"metricscollector","timestamp":"1533054067.089524269"}
{"data":{"metric":{"app_id":"c03231de-202e-4396-a1ee-a7166460187c","collected_at":1.5330540670896737e+18,"instance_index":0,"name":"memoryutil","timestamp":1.5330540670742047e+18,"unit":"%","value":"43"},"session":"10"},"log_level":0,"log_time":"2018-07-31T16:21:07Z","message":"metricscollector.app-streamer.process-event-get-memoryutil-metric","source":"metricscollector","timestamp":"1533054067.089678049"} ```

If you notice memoryUtil is diego is capture in the log file
{"data":{"metric":{"app_id":"c03231de-202e-4396-a1ee-a7166460187c","collected_at":1.5330540670896737e+18,"instance_index":0,"name":"memoryutil","timestamp":1.5330540670742047e+18,"unit":"%","value":"43"},"session":"10"},"log_level":0,"log_time":"2018-07-31T16:21:07Z","message":"metricscollector.app-streamer.process-event-get-memoryutil-metric","source":"metricscollector","timestamp":"1533054067.089678049"}, hence the app_metrics data is getting populated with the data .

@nsharmacovs
The reason is DEA does not report memory quota to loggreator, while Diego does.  So autoscaler can not get memoryutil if you are using DEA.
We did not list it as a limitation since DEA has been deprecated.

see code : https://github.com/cloudfoundry-incubator/app-autoscaler/blob/develop/src/autoscaler/metricscollector/noaa/app_events.go#L72
it will return nil metric when cm.GetMemoryBytesQuota() == 0


Sets honorLabels default value to true. Fixes #53

I see in Kubecost this defaults to "true", so I think I'm good with this. Could you update the README.md to document the change in the default?

Done

Will pull into a bulk merge and update version.

Merging here:
https://github.com/opencost/opencost-helm-chart/pull/60


Bug: Bluetooth is choppy (no matter wether EqMac is running or not)

[x] I have checked for a similar issue and sure it hasn't been reported before.
Describe the bug
Bluetooth is extremely choppy after EqMac has been install
Steps to Reproduce
Steps to reproduce the behaviour (feel free to change the placeholder as you need):

Install EqMac
Restart machine
Connect to bluetooth speaker
Observe extremely choppy audio (whether EqMac is running or not makes no difference)
I've tried all the various "Bluetooth" fixes out there, the only thing that works is removing the EqMac driver from /Library/Audio/Plug-Ins/HAL/

Expected behaviour
Bluetooth sound shouldn't be choppy
Setup information:

Audio device used for playback: Samsung Galaxy Buds Pro
Audio transmission interface: Bluetooth
macOS Version: 11.5.1
eqMac Version: 1.4.4 (but I've always had this problem, for many months and many EqMac versions)

Happy to provide any further input if needed

Hi, Is this still happening? I have several models of AirPods and they all work fine. An interesting thing you said is even with eqMac closed, the bug is still happening, but eqMac's driver is disabled when it is not running, so might it is a macOS bug, but I can't really be sure. If this bug still happens to you, please reopen this issue and comment, I would be here to help.


Tab-Navigating through UI Table with Input fields

Hi,
I have encountered a strange behaviour. When tab-navigating through a ui table with multiple input fields without changing anything everything works fine, the cursor is set to the next input field:

However when a user edits an input field which triggers a change event and a view model update, sometimes (not always!) the focus is changed from the input field to the surrounding table cell:

This is a problem because the user can't change multiple table entries one after the other fast and the usability of the app is worsened. Do you have an idea what could trigger this behaviour?
Best regards
Jan

Hi,
Yes focus handling is often complex in UI5. Never had this issue before but I can take a look to it. Is there a chance that you share a little sample app which reproduces your problem? Then I can easily check it on my side.
Best regards.

thank you, added you code as sample 172 and try to take a look to it in the next days.

That seems to be a general problem of the sap.ui.table:
https://community.sap.com/t5/technology-q-a/sap-ui-table-table-moving-focus-from-column-to-input-field-within-template/qaq-p/12564500
you can consider if changing the table to sap.m.table is an option for you.
anyway, i added some pure JavaScript to adjust the focus handling, check demo 172. After every backend roundtrip the position of the focus gets corrected. Maybe there are more elegant ways to solve this issue but for now it seems to work:

Hi @oblomov-dev
great, thank you for your help, the custom JS solution works with my app! This is something I would not have been able to achieve as a pure ABAP developer without JS knowledge 😆
Have a nice week!
Best regards
Jan


Make json parse work for windows environments

Currently the regex doesn't match on windows environments due to the CRLF. This minor fix does make the regex work on windows enviroments as well.

Sorry for the sporadic activity here and thanks for this @ChrisRAoW - just published v1.1.2 - A bigger release including the other PRs is incoming 👍


Script doesn't work for me

After execution I get the following output:
#: sudo ./block-all-google.sh -b
script set to block
running as root
check network interface connectivity
interface enp1s0 online
interface wlp0s29f7u5 online
pinging ipinfo.io
ipinfo.io ping success
pinging google
google ping success
downloading ip ranges to /home/MYUSERNAME/AS15169
file exists, backup created at /home/MYUSERNAME/AS15169.bak
curl: (7) Failed to connect to ipinfo.io port 443: Verbindungsaufbau abgelehnt
error
making changes to routing table
0 ip ranges processed
ping test google again
fail (google ping successful)
//done

It seems like ipinfo.io is not available for me. Using a proxy or tor browser I can reach ipinfo.io without any problems. Do they filter the number of requests or something like that?
Is there anything I can try instead of looking for an alternative to this script?

I gave it another go and now it worked.


I18n

What kind of change does this PR introduce?

Does this PR introduce a breaking change?

What needs to be documented once your changes are merged?

👷 Deploy Preview for joyful-sunflower-19f8d6 processing.

Name
Link

🔨 Latest commit
3533ae79c4f073c5dd052d04556bd4e9ba61a576

🔍 Latest deploy log
https://app.netlify.com/sites/joyful-sunflower-19f8d6/deploys/65b9b5c7a39ed70008524684


Fix the note about resizing virtual disks while the VM is running

The note about resizing virtual disks while the VM is running is not accurate. Deallocating the VM only needs to be done in certain cases as seen in the link that is just above the note, https://learn.microsoft.com/en-us/azure/virtual-machines/linux/expand-disks#expand-an-azure-managed-disk. This should be updated to make customers aware and not deallocate their VM when it is not necessary.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 05d62208-3608-176c-ad6d-f20e9e6e6800
Version Independent ID: 4cce03da-9830-a35a-816f-3ee0529ebea3
Content: How to resize disks encrypted using Azure Disk Encryption - Azure Virtual Machines
Content Source: articles/virtual-machines/linux/how-to-resize-encrypted-lvm.md
Service: virtual-machines
Sub-service: disks
GitHub Login: @jofrance
Microsoft Alias: jofrance

@justingross-msft
Thanks for your feedback! We will investigate and update as appropriate.

@justingross-msft
Thanks for reporting this! We have created a PR for this issue and the changes should go live soon.


TextField -> CharField, enable MySQL testing

Fixes #10
ATTENTION!

This caused a migration reset, so we'll need to change the MAJOR version of this project to support MySQL.

Current coverage is 100% (diff: 100%)

Merging #12 into master will not change coverage

@@           master   #12   diff @@
===================================
  Files           2     2
  Lines          19    19
  Methods         0     0
  Messages        0     0
  Branches        0     0
===================================
  Hits           19    19
  Misses          0     0
  Partials        0     0

Powered by Codecov. Last update b34448f...bb78d94

MySQL support will be brought online with a 2.0 release of this project since migrations need to be re-worked / reset.


Personal best placeholder

Simple placeholder showing personal best survival time, backstory type, and character name

Duplicate https://github.com/GamerSafer/ablockalypse/issues/15


Deploy all the backing apps of a given service to a single space dedicated to the SI

GIVEN The application manifest contains:
spring:
  cloud:
    appbroker:
      services:
        target:
        - name: SpacePerServiceInstance
        apps:
        - name: my-app
      deployer:
        cloudfoundry:
          api-host: api.cf.example.org
          default-org: my-broker-org
          default-space: development

WHEN a service instance is created
THEN the a backing app is deployed with the following properties (where [SI GUID] is the GUID assigned by the platform to the created service instance):
org: my-broker-org
space: [SI GUID]
app name: my-app
app route host: my-app-[SI GUID]

Moving target one level up, since it will make the design cleaner and there is no need to deploy each app on a separate space.
Now we could have createTarget and deleteTarget methods in the AppBrokerDeployer interface to perform the creation and deletion of spaces/namespaces at the beginning/ending of each flow.

@albertoimpl I noticed this is in To Be Refined column but I thought this was already implemented? Am I incorrect?

Today we deploy each independent app into a specific space.
This story will move that one level up and create the space, then try to do the deployment of the applications.
It will help us organize the code a bit better, since, there is no need for deploying each app into a different space.
In other words, from what we have today:
spring:
  cloud:
    appbroker:
      services:
        apps:
        - name: my-app
          target:
          - name: SpacePerServiceInstance

to
spring:
  cloud:
    appbroker:
      services:
        target:
        - name: SpacePerServiceInstance
        apps:
        - name: my-app


Add chainlink docs

Converted and edited the Chainlink deployment tutorial by Julian Martinez .
Needs further editing, do not merge please.

@jpop32 Just a note that you can mark a PR as a draft. It's a little cleaner than the "do not merge" label :)


dart-sass: 1.69.0 -> 1.69.5

Diff: https://github.com/sass/dart-sass/compare/1.69.0...1.69.5
Changelog: https://github.com/sass/dart-sass/blob/main/CHANGELOG.md#1695
Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review run on x86_64-linux 1

14 packages built:

dart-sass
discourse
discourseAllPlugins
python310Packages.nbdev
python310Packages.nbdev.dist
python311Packages.nbdev
python311Packages.nbdev.dist
quarto
quartoMinimal
rstudio
rstudio-server
rstudioServerWrapper
rstudioWrapper
shopware-cli

Superseded by #282442.


LEGO: Pull request from lego/hb_04604851-bac4-4681-9f74-73de611d6e48_20210720153329271 to main

LEGO: Pull request from lego/hb_04604851-bac4-4681-9f74-73de611d6e48_20210720153329271 to main with localized lcls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 42.552%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
26727

Relevant Lines:
56924

💛  - Coveralls


Format numbers in templates

We need tool to format numbers in templates https://www.traccar.org/forums/topic/overspeed-email-template/
We can pass https://velocity.apache.org/tools/2.0/apidocs/org/apache/velocity/tools/generic/NumberTool.html object in templates.

Sounds good to me. We are already using similar tool for formatting dates.


Beautify the default auth error page

The page is https://www.memfree.me/api/auth/error
you could generate the page in https://www.memfree.me/generate-ui
the config the error page in frontend/auth.ts
    pages: {
        signIn: '/login',
        verifyRequest: '/verify',
        error: '/auth-error'
    },

I would like to work on this.

@Riyan-Mo Thank you. you could refer to this doc:  https://authjs.dev/guides/pages/error

@ahaapple I have created the page but I don't know in which directory to place it.

@Riyan-Mo Hi, you could put it in  frontend/app/[locale]/(marketing) dir. like login page and vefiry page. thanks.

I was thinking the same. Thank you. I'll add it.


Update clang-format?

The clang-format.x script uses clang-format-12:
https://github.com/electronic-structure/SIRIUS/blob/84a71b78c5fa964a78cffb0d4878874b15b107f0/clang_format.x#L5
clang-format-12 is rather old (and no longer available via apt in Ubuntu 23). Should the clang-format version be updated?
Commits can be ignored in the blame view.

I'm using .clang-format via the IDE. But it seems indeed that ubuntu is not adding a symlink called clang-format (unless /usr/lib/llvm-[ver]/bin is in the path:
https://packages.ubuntu.com/kinetic/amd64/clang-format-15/filelist

Fixed by #918


fix(rc-slider): fix style rc-slider

add missing style for the rc-slider
Proposed Changes

Potential Breaking Changes

Acceptance Criteria

[ ] The proposed changes are covered by unit tests
[ ] The potential breaking changes are clearly identified
[ ] README.md is adjusted to reflect the proposed changes (if relevant)

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@279eca2). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #1457   +/-   ##
=========================================
  Coverage          ?   98.99%
=========================================
  Files             ?      496
  Lines             ?    10271
  Branches          ?     2370
=========================================
  Hits              ?    10168
  Misses            ?      103
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 279eca2...df10019. Read the comment docs.


As a manager/reviewer, easy access to completed reviews and notes while composing a determination response

Does this issue include templates determination language automatically populating the text box when team member drafts a letter? Example: Team member selects "approve" and template determination language about approval populates in text box.

@fourthletter No, that is a separate issue. If one do not exist please create one and specify how you like the feature to work and what options are needed.

The determination create form opens in a new tab so the submission detail views, with reviews etc. are just a tab away.
If that is not enough, would you like to have a sidebar with reviews and notes on the determination create form page as well?


More comprehensive property sort order error messages

What do the changes you have made achieve?
This PR introduces new option for property-sort-order rule: display-mode: lines/blocks.
Display Mode"lines" (default) works as before. Display mode "blocks" tries to agregate wrongly sorted properties in longer blocks and displays one message per detected block instead of per single line. Message for block contains expected and actual order of properties in block.
There is naive algorithm used for block detection, may not support correctly some corner cases but in general should give better (or at least not worse) advices that original.
Are there any new warning messages?
Yes, introduces messages like:
"Expected order width, display, found display, width"
instead of
"Expected width, found display"
"Expected display, found width"
for detected blocks (single element blocks are reported as before).
Have you written tests?
Yes, single test in both scss and sass suites.
Have you included relevant documentation
Yes
Which issues does this resolve?
Closes #416
<DCO 1.1 Signed-off-by: Rafal Witczak<EMAIL_ADDRESS>

Coverage decreased (-0.02%) to 97.567% when pulling ae356216de46490aacee68d81f695833e98fe7ec on rafw87:property-sort-order-display-mode into cf935247a96ed887895ed26db4f3313d063525fa on sasstools:develop.

Coverage decreased (-0.02%) to 97.567% when pulling ae356216de46490aacee68d81f695833e98fe7ec on rafw87:property-sort-order-display-mode into cf935247a96ed887895ed26db4f3313d063525fa on sasstools:develop.


[Bug]: Class Names plugin occour error when we use page transition library

Which variants of Embla Carousel are you using?

[X] embla-carousel (Core)
[ ] embla-carousel-react
[ ] embla-carousel-vue
[ ] embla-carousel-svelte
[ ] embla-carousel-autoplay
[ ] embla-carousel-auto-scroll
[ ] embla-carousel-solid
[X] embla-carousel-auto-height
[X] embla-carousel-class-names
[ ] embla-carousel-fade
[ ] embla-carousel-docs (Documentation)
[ ] embla-carousel-docs (Generator)

Steps to reproduce
The bug occurs when I use "auto-height" and/or "class-names" plugin.

I have use "Page transition library (https://swup.js.org/)" on my project. It's change DOM elements when visit a link. In this case JS works once. For this I am destroy Embla instance and init it again, you can see below.
If I use one instance it will work correctly but If I use one-more Embla instance, embla-carousel-class-names will occour an error, you can see below.

Error
Console

Source

General logic
   const emblaInstance = function() { ... }

   emblaInstance(); // First page load, first embla init
   document.addEventListener('swup:page:load', emblaInstance); // Swup page load, I init embla
   document.addEventListener('swup:content:replace', function(){ // Before Swup content replace, I destroy embla instance
       emblaInstance.destroy();
   }, {before: true});

If you duplicate the above example with more than one Embla slider instance, it will start to give errors during page transitions.
If I remove Embla Plugins from all code everything works fine. For plugins, is it necessary to call a separate "destroy" method along with "emblaInstance.destroy()"?
Expected Behavior
Embla instances should be destroyed before Swup changes each page, and they should work again after changing the page.
Additional Context
I have also tried... remove Embla plugins from project, it was work normal.
What browsers are you seeing the problem on?
All browsers
Version
v8.1.6
CodeSandbox
Before submitting

[X] I've made research efforts and searched the documentation
[X] I've searched for existing issues
[X] I agree to follow this project's Contributing Guidelines for bug reports

@bozdevs thanks for your question,

If I remove Embla Plugins from all code everything works fine. For plugins, is it necessary to call a separate "destroy" method along with "emblaInstance.destroy()"?

No it's not.

If I use one instance it will work correctly but If I use one-more Embla instance, embla-carousel-class-names will occour an error, you can see below.

I see. I have nothing to debug in your issue description and no relevant code. If it's working with one instance and not with multiple instances, it's likely the problem is on your side. Make sure to create a new plugin instance for every separate carousel and don't re-use the same instance.
Please create a proper bug report as described in the contributing guidlines. You need to provide a CodeSandbox with a minimal reproduction of the bug meaning no production site with a lot of noise.

@bozdevs did you solve the problem? Why did you close the issue?

No, I will create codesandbox and open it again. In the meantime, I'll try a few things.


Q&A channel for longer discussions

We plan for a suite of Q&A channels, including StackOverflow for typical how-to problems and GitHub Issues for bugs and most feature requests. In addition to those, we want a channel for longer discussions (e.g. more complicated feature requests) and announcements.
A mailing list would be a good choice for this channel, but there are tradeoffs to balance.

We have mailing lists now, and we could configure a similar Mailman list as we desire, right beside them, but that list would have an mit.edu domain, which might unnecessarily tie our brand to MIT.
We could deploy our own instance of Mailman. This was the proposed plan, but we see that installing and running Mailman is a very heavy lift, suited only for experienced Linux sysadmins.

So we need to figure out where our long-form discussion channel will reside. One of those options above? Or another option not yet listed.

We could consider GitHub Discussions.  I've seen some projects use GitHub Discussions, and it seemed like they work well.  But I don't have a ton of experience with them.
GitHub Discussions is currently enabled on our repositories, if you want to take a look.

Thanks, TB. Great idea. I will take a look.

I am thinking about piloting GitHub Discussions, by starting one (or a few) threads where it could be great to hear from the team. Possible topics are

What are some good blog ideas? (I have a starting list from Charles)
What kinds of application, tool, and benchmark integrations would be good to promote?
More about our (community) resource list?
Other?

What do you think? Then, when/if I start Discussions, which repository should I use? Maybe opencilk-project? I created a separate Issue-tracker for the website (which I'm happy to revisit if we want) but it seems like we really want a single place for OpenCilk community discussion and announcements. Right?

Yes, GitHub provides facilities for moderating discussions: https://docs.github.com/en/site-policy/github-terms/github-community-guidelines#what-if-something-or-someone-offends-you.

Thanks @dcurtisatmit and @neboat. I will pilot GitHub Discussions for us.
Are you OK with using opencilk-project as the host repository for our discussions?

That's fine with me.


[editorconfig] Use tab_width instead of indent_size

If indent_style is set to tab on editorconfig, the proper value to use in setting indentation size is tab_width, as per the EditorConfig specifications:

For example, tab_width need not be specified unless it differs from the value of indent_size. Also, when indent_style is set to "tab", it may be desirable to leave indent_size unspecified so readers may view the file using their preferred indentation format.

Looks like it doesn't matter so much as indent_size is the fallback for tab_size?

indent_size: a whole number defining the number of columns used for each indentation level and the width of soft tabs (when supported). When set to tab, the value of tab_width (if specified) will be used.

@Tyriar Ah, you're right. I guess this could be closed. (Sorry, this slipped under my radar for quite a while!)


Maintainance

Hi,
Just checking if this plugin is still maintained. I checked the android equivalent and realised it gets frequent updates, fixes etc.
However, this iOS plugin was last updated 3 years ago.

Hi,
Yes, work is underway on a new version of the plugin for iOS and a new version will be released soon.

@Mastersam07 do you have any specific needs that needs to be addressed?

I maintain a flutter plugin for livechat https://github.com/mastersam07/livechat.
I was looking at making changes that match what's available on the native android and iOS sdks. While the android sdk seems to be under active development, there are certain changes on android that doesnt seem to be available on ios, hence my coming here to ask.

I'm not aware of any active development instead of bugfixing. @konradk do you know about any features added to Android that iOS is missing? @Mastersam07 do you have any specific functional differences in mind?

Hi @Mastersam07 as per what I established there are no functional differences between iOS and Android widget wrappers. If you feel like you need anything specific please fill a separate issue.

ChatWindowEventsListener
This listener gives you opportunity to:

get notified if new message arrived in chat. This gets handy if you want to show some kind of badge for a user to read new message.
react on visibility changes (user can hide the view on its own)
handle user selected links in a custom way
react and handle errors coming from chat window
allow users to use SnapCall integration
get notified if user device can't handle file picker activity Intent

I copied the above from the android docs at https://github.com/livechat/chat-window-android. I cant find a 1:1 equivalent on ios. The closest thing i could find is https://github.com/livechat/chat-window-ios#handling-chat-window-resence-events.


[NEW CONTENT TYPE REQUEST] Visual Studio C# Project

What type of file would you like magika to detect?
Visual Studio C# Project (.csproj)
What software can create/open these files?
Visual Studio
Where can these files be found?
https://github.com/search?q=language%3AC%23+&type=repositories
If possible, please provide a specification for this file type.
Additional context

Closing, see #152 for context. Thanks!


KAFKA-4643: Improve test coverage of StreamsKafkaClient

The commit brings improved test coverage for StreamsKafkaClientTest.java

@dguy addressed your comments

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/6725/
Test FAILed (JDK 8 and Scala 2.12).

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk7-scala2.11/6740/
Test PASSed (JDK 7 and Scala 2.11).

retest this please

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk7-scala2.11/6745/
Test PASSed (JDK 7 and Scala 2.11).

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/6730/
Test PASSed (JDK 8 and Scala 2.12).

merged to trunk


Figure out what marking up raw JS definitions would need

@domenic is trying to write specs that define new features in raw JS, rather than using WebIDL. Bikeshed's IDL-related definition types and linking features are designed to, well, work with IDL.  I'm not happy with the idea of this serving two masters; the set of valid things between the two aren't identical, the sort of automatic helpers I can provide are different, etc.
I should figure out what raw-JS definitions need and set up some definition types for them.

Awesome, let's do this. The structures are very similar, but yeah, we can avoid some awkwardness. Here's what I've got. (*) indicates not needed for Streams. (**) indicates we would use it in streams but are currently just not cross-linking so it's not as important.

Classes, which have:

constructors
prototype getters
(*) prototype setters
prototype methods
(*) static methods
(*) static data properties
(*) static getters/setters
instance data properties
(**) instance internal slots
(**) instance internal methods

Singleton objects, which have getters/setters/methods/data properties/instance internal slots/instance internal methods

Motivating example
Motivating Streams example
Maybe Reflect could count as this too?

Abstract interfaces, which have properties and methods

Method-only example
Mixed example

Things to allow when naming:

getters/setters/methods/properties should be allowed to be symbol-named, e.g. [Symbol.asyncIterator] or [@@asyncIterator]
Classes and singleton objects should be allowed to be of the form %Foo%.

Other:

There may be something to do around assuming that constructor = class, as these are sometimes not separated. Maybe if a definition exists for one but not the other, then assume that defines both? Not sure what the practical impact would be.
I'd like to keep using the IDL auto-linking syntax if at all possible. It's quite nice.

An important thing that I messed up in IDL (and will one day fix in a compatible way; it's just an engineering problem I haven't wanted to spend the time on yet) is splitting up the definition categories more finely than the set of things that share a namespace.  Right now, you can define an attribute and a method with the same name in IDL, and Bikeshed doesn't complain at you, even tho that's nonsensical.
So I need to figure out what the actual namespace-sharing categories are here, such that two things can't be defined with the same name, and then figure out what to call those. I think that the categories are:

classes/constructors (and anything else on the global object) (js-class?)
anything on the prototype, namespaced by for (js-proto?)
anything on the class, namespaced by for (js-static?)
anything on the instance, namespaced by for (js-property?)

I think that's it? Concrete/singleton/abstract distinction doesn't matter, I think, they're all "classes".

There may be something to do around assuming that constructor = class, as these are sometimes not separated. Maybe if a definition exists for one but not the other, then assume that defines both? Not sure what the practical impact would be.

Yeah, I assume they'll often be treated as the same thing, and if only one exists, autolinking can just link you to the other.

I'd like to keep using the IDL auto-linking syntax if at all possible. It's quite nice.

Need to come up with a different glyph than {{, but otherwise yeah, I agree.

I think that the categories are:

For classes, that seems correct.

Concrete/singleton/abstract distinction doesn't matter, I think, they're all "classes".

I don't think this is accurate. In particular it seems like more of the same thinking "IDL interfaces and JS classes are approximately the same, so let's reuse the same concepts"
For example, there is no concept of instance vs. prototype vs. static for singleton objects or abstract interfaces. They just have one namespace, the object or interface contract itself.

Need to come up with a different glyph than {{, but otherwise yeah, I agree.

Aww, why?

I don't think this is accurate. In particular it seems like more of the same thinking "IDL interfaces and JS classes are approximately the same, so let's reuse the same concepts"

By "all classes", I mean "they all occupy the same namespace as classes".  You can't have a concrete class and an abstract class with the same name.

Aww, why?

Because:
> bikeshed refs --type=idl --text=ReadableStream
status:    current
for:       []
level:     1
url:       https://fetch.spec.whatwg.org/#concept-readablestream
type:      interface
export:    True
text:      ReadableStream
shortname: fetch
normative: True
spec:      fetch
==========
status:    current
for:       []
level:     1
url:       https://streams.spec.whatwg.org/#rs-class
type:      interface
export:    True
text:      ReadableStream
shortname: streams
normative: True
spec:      streams

Streams themselves already have two versions of the same name defined, one as an IDL interface and one as a JS class. ^_^

Ah, ok. Well, we can separate those then.
So I think I want these categories:

js-class for classes and other things living on the global
js-abstract-class for abstract classes (just a spec concept, right?)
js-prop for all properties of an instance (for of the class)
js-proto for all properties of a prototype object (for of the class)
js-static for all static properties of a class (for of the class)

Do singleton objects need to be separated out from js-class or js-abstract-class?
Hm, with js-class and js-abstract-class both existing and both having instance/proto/static properties, the for attribute is technically ambiguous. As you say, that should generally not clash, so it's probably fine in practice, but I don't really have a route to fixing that right now, since for values are currently just opaque strings. :/

Properties divide up into a few categories, but I think they're all distinguishable with some obvious conventions:

getters/setters are named get foo and set foo
slots are already distinguished by the [[foo]] naming
methods have a () at the end (and there are no overloads, thank god)
"ordinary" properties are everything else

js-abstract-class for abstract classes (just a spec concept, right?)

Yes, just a spec concept. I'd call it "js-abstract-interface"

Do singleton objects need to be separated out from js-class or js-abstract-class?

Yes. An interface like "AsyncIterator" or "AsyncIterable" is just a concept. Singleton objects like %AsyncFromSyncIteratorPrototype%, ReadableStreamDefaultReaderAsyncIteratorPrototype, or Reflect are concrete objects.

Hm, with js-class and js-abstract-class both existing and both having instance/proto/static

Abstract interfaces can't have all three tiers of things, I don't think. They're really about describing the shape of a single object. They don't care whether the properties are instance vs. proto. And they aren't actually a description of two objects (constructor and prototype), like classes are.

Properties divide up into a few categories, but I think they're all distinguishable with some obvious conventions:

Interesting approach. I guess it works, although it's a bit less natural to me to put <dfn js-proto>foo()</dfn> instead of <dfn js-method>foo()</dfn>. Probably for the best though.
My only worry is that without the semantic information of property vs. getter vs. setter vs. slot vs. method, the "Terms defined by this specification" index will be a bit less pretty. E.g. instead of saying "Method for ReadableStream", it'll say something like "Prototype property for ReadableStream". And instead of having one entry for closed, alpabetized under "c", it'll have two entries, get closed and set closed, alphabetized with all the other getters/setters.
(Well, there is no closed setter in the real Streams standard, but you get the idea.)
Maybe we could reconstruct those from the naming of the item? Or maybe just not worry about how pretty the index is...

Singleton objects like %AsyncFromSyncIteratorPrototype%, ReadableStreamDefaultReaderAsyncIteratorPrototype, or Reflect are concrete objects.

K. Do singletons have all three tiers of things?

Abstract interfaces can't have all three tiers of things, I don't think. They're really about describing the shape of a single object. They don't care whether the properties are instance vs. proto. And they aren't actually a description of two objects (constructor and prototype), like classes are.

Ooh, nice, that makes things simpler. I didn't want to duplicate all three categories of sub-item for abstract interfaces, but if it's only one, I'm fine with having js-abstract-prop.

Maybe we could reconstruct those from the naming of the item?

Oh we can definitely reconstruct them, don't worry about that.

K. Do singletons have all three tiers of things?

Nope, just one tier again :)

Cool. So I think this is my final structure:

Looks good!!

` and [foo] for Symbol-naming

Also need to allow [foo.bar] and/or [@@foo].

The top-level constructs will match JS ident production, but will allow %Foo% for whatever meaning JS assigns to that.

I think it would be good to allow js-abstract to be more free form, in particular including spaces. E.g. I currently use "underlying source".

Now if you can just tell me what glyph-wrapping you want for auto-linking, I can go ahead and add these.

All the bracket pairs are taken, hrm. What's left?
Combinations: <[x]>, [<x>], [{x}], {[x]}, {(x)}...
Sigils inside brackets: {|x|}, {\x\}, {-x-}, ...
I lean toward {-x-}? {-ReadableStream-}, {-ReadableStream/getReader()-}, {-underlying source/start()-}... seems nice.


don't require manually passing in the github token

Use the GitHub provided ${{ github.token }} as the default so the user does not need to provide one.
Example of actions/checkout using the same syntax.
This update does NOT require existing users to change anything.

The check shows as an error because of this line.

- uses: scacap/action-surefire-report@master

To see a successful run you can look here.
I initially tried to fix this as well by adding this commit however it lead to this error:

Error: Resource not accessible by integration

This happens because a fork is trying to add a comment to a PR in a diff repo (this one), which github denies. There are some lengthy threads and ugly solutions (here and here), but the fixes are outside the scope of this PR.

Thanks for the contribution! I'll check this on the project itself and then link to v1 branch.


[QUESTION] - Publishing the WSL image

Hello mate, very nice project!
I would like to ask you how were you able to publish your WSL image to Microsoft Store. I have a Microsoft developer account but I don't find any documentation that describe how to publish a WSL image to Microsoft Store. Do you know the steps for doing this?

Solved


add namespace std for sort function.

because compiling in some environment is failed due to name ambiguous error.

llvm: 8.0.0


ViewComponents called with the vc taghelper are broken on 7.0.3

Is there an existing issue for this?

[X] I have searched the existing issues

Describe the bug
View Components aren't called properly when building the project with .NET SDK 7.0.200. The tags are instead left on the page as a regular HTML tag. In some cases, passing arguments to the HTML tag results in error CS1503: Argument 3: cannot convert from 'method group' to 'object?'
This is likely a result of the newest SDK using MSBuild version 17.5.0-preview-23061-01+040e2a90e for .NET. I'm not sure a preview version of MSBuild was meant to leak into the production CLI.
Do not that I didn't update MSBuild separately, this is just what came with the 7.0.200 SDK.
Expected Behavior
View Components should work
Steps To Reproduce
Take any simple view component test repo, build and run it using MSBuild 17.5.0-preview-23061-01+040e2a90e
Exceptions (if any)
No response
.NET Version
7.0.200
Anything else?
Using dotnet publish; this issue started surfacing on our build server. Using ASP.NET Core 7.0.2, but updating to 7.0.3 didn't seem to fix the issue.
.NET SDK:
 Version:   7.0.200
 Commit:    534117727b

Runtime Environment:
 OS Name:     ubuntu
 OS Version:  20.04
 OS Platform: Linux
 RID:         ubuntu.20.04-x64
 Base Path:   /usr/share/dotnet/sdk/7.0.200/

Host:
  Version:      7.0.3
  Architecture: x64
  Commit:       0a2bda10e8

.NET SDKs installed:
  3.0.103 [/usr/share/dotnet/sdk]
  3.1.416 [/usr/share/dotnet/sdk]
  5.0.404 [/usr/share/dotnet/sdk]
  6.0.300 [/usr/share/dotnet/sdk]
  7.0.200 [/usr/share/dotnet/sdk]

.NET runtimes installed:
  Microsoft.AspNetCore.App 3.0.3 [/usr/share/dotnet/shared/Microsoft.AspNetCore.App]
  Microsoft.AspNetCore.App 3.1.22 [/usr/share/dotnet/shared/Microsoft.AspNetCore.App]
  Microsoft.AspNetCore.App 5.0.13 [/usr/share/dotnet/shared/Microsoft.AspNetCore.App]
  Microsoft.AspNetCore.App 6.0.5 [/usr/share/dotnet/shared/Microsoft.AspNetCore.App]
  Microsoft.AspNetCore.App 7.0.3 [/usr/share/dotnet/shared/Microsoft.AspNetCore.App]
  Microsoft.NETCore.App 3.0.3 [/usr/share/dotnet/shared/Microsoft.NETCore.App]
  Microsoft.NETCore.App 3.1.22 [/usr/share/dotnet/shared/Microsoft.NETCore.App]
  Microsoft.NETCore.App 5.0.13 [/usr/share/dotnet/shared/Microsoft.NETCore.App]
  Microsoft.NETCore.App 6.0.5 [/usr/share/dotnet/shared/Microsoft.NETCore.App]
  Microsoft.NETCore.App 7.0.3 [/usr/share/dotnet/shared/Microsoft.NETCore.App]

Other architectures found:
  None

Environment variables:
  Not set

global.json file:
  Not found

Learn more:
  https://aka.ms/dotnet/info

Download .NET:
  https://aka.ms/dotnet/download```

@chsienki is this related to the issue you were looking at?

I hit this today as well, targeting 7.0.103 SDK resolved the issue.

Exactly same issue.
Build with 7.0.200, any <vc: tags in .cshtml are not working.
7.0.103 has no issue.

Same issue here. Targeting 7.0.103 SDK however does not resolve it for me. The Azure Pipeline still uses the problematic MSBuild version 17.5.0-preview-23061-01+040e2a90e for .NET.
How can I get rid of this? Uninstalling 7.0.200 SDK didn't help.

@janstrube If you use Self-Hosted agent, you need to delete 7.0.200 files and folders from _work_tool\dotnet\sdk.

@recumbented Thanks, that worked.

This is also an issue on 6.0.406. We float our SDK minor version. No errors, no warnings, just a stealthy switch to a prerelease version of MSBuild which completely broke multiple projects (we rely heavily on ViewComponents).
It took us several hours to pinpoint the issue. The giveaway was the dll being way smaller on the broken version, which made us look at the build, and that's where we spotted the prerelease version of MSBuild.
Our fix was to pin the version in global.json, and modify our pipelines to use this rather than the floating version. This has been a huge pain, and if we need to wait a month to get a fix (per the SDK team's response), then we're unlikely to continue floating minor versions, which is really unfortunate.

Happened to me as well, using MSBuild version 17.5.0-preview-23061-01+040e2a90e breaks vc tag helpers

Exactly the same issue.
Build with 7.0.200, any <vc: tags in .cshtml are not working.
7.0.103 has no issue. Are you really done releasing or experimenting with us?
How can the preview version be released :(

Another workaround is to add the global.json file to the solution/project to specify the SDK. We went back to use the previous stable version (7.0.102-103) using that instead of removing the SDK did it for me.

Same problem, just spent 4 hours trying to figure out what PR broke our build but then found that 7.0.200 pulls in a PREVIEW of MSBUILD. Comon....

According to the comments on https://github.com/dotnet/sdk/issues/30624  the cause is in dotnet itself (probably roslyn) rather than the msbuild version

Following the installation of the VS 17.5 release, I observe the same issue on my workstation. Not impressed.

Following the installation of the VS 17.5 release, I observe the same issue on my workstation. Not impressed.

I'm facing the same issue after installing VS 17.5 on Windows, have you found a workaround?

@vhugogarcia You have to remove the new SDK or use global.json to pin the SDK version to 7.0.103

Thanks @kanadaj for the response. I tried with the global.json file setting the version you mentioned and even a lower to 6.0.406 without luck. I'm trying to uninstall .NET 7.0.200 version, however, it says that I cannot uninstall it because it was installed with VS.
I tried to uninstall it from VS and it warnings me that all dependent features of .NET will be removed, I'm wondering if that will uninstall everything. Have you faced this issue with uninstalling a SDK?

@vhugogarcia Have you tried this in the solution or the project root? I can't remember if VS uses the solution or the project folder as the root
{
  "sdk": {
    "version": "7.0.103",
    "rollForward": "disable"
  }
}

I added to the project root. However, I was able to fix the issue by rolling back to a previous version of Visual Studio 17.4.x
I will test the global.json on the solution as a matter to confirm if it goes into the project or solution. Thanks @kanadaj for the helpful information, it really helped to solve my issue. I can continue developing :)

We are aware of this regression and working to port our fix to 17.5 and 7.0.200.
https://github.com/dotnet/razor/pull/8328

I've noticed a fix on 7.0.201 when running an application locally but still experience issues when running integration tests that host the webapp via WebApplicationFactory. I don't think this is directly related to WebApplicationFactory, but might possibly be caused by another project (the Integration test project, in this case) sitting above the WebApp.

We are aware of this regression and working to port our fix to 17.5.2 and 7.0.202.
#8328

This issue doesn't allow publish my website to prod. Do you have an estimate how much time it will take to publish a new version of VS with this fix?  Thanks

@rpnetcoder You can force an old SDK version using a global.json file. More information in https://github.com/dotnet/aspnetcore/issues/46740

@DavidDeSloovere, thanks. Invoking view components with Component.InvokeAsync() instead ofvc:/ tag resolved the issue in my case.

If only we had given those tests 🧪 some 💖 and attention ⚠🤣

Just wanted to clarify my understanding... we have a .NET 6 website that is affected by this issue.
Why would the .NET SDK v7.0.200 bits get in the way of the view components being processed for a website targeting .NET 6? I thought anything v7* would be for .NET 7 instead?

@MrClyfar From what I can tell the problem seems to affect the dotnet runtime versions 6.0.14 and 7.0.3.
SDK versions that match those runtimes are therefore affected, so that'd be: 6.0.114, 6.0.309, 6.0.406 for .Net 6 and 7.0.103, 7.0.200 and 7.0.201 for .Net 7.
We've just run straight into this problem since the Azure DevOps Windows hosted build agents appear to have been updated in the last 24 hours and have picked up the new runtimes. We've used the global.json workaround.

Just wanted to add my findings.
I've tried with SDKs 7.0.103, 7.0.201,  and 6.0.406 in global.json
201 doesn't work, but 103 and 406 does work.
@indigogiant I just want to check if you've tested those versions you list, or if it was just assumption? Since my testing partly contradicts the versions you listed, I just wanted to check.
Here's my json file. Github doesn't allow .json though so i changed it to .txt
global.json.txt

Just to toss my experience on here.
Pinning to a prior version of the SDK using a global.json file fixes things when working locally.  However, publishing the application still stops all <vc style usages to totally stop working.
There is no viable workaround that allows us to publish applications.  Currently haunting deployments for > 45 of our customer applications

@mitchelsellers if you're using docker, you probably want to pin the container versions too. For azure app services I assume this is impossible if you use the installed runtime, so I'm not sure what can be done there.

@kanadaj all AppServices. So I'm basically screwed.
We have had to modify 400+ code files in the past 2 days to fix things. It's a nightmare

assuming you publish with CI, have you made sure to use an earlier version of the SDK in your pipeline?

That worked for me in a DevOps build pipeline. YAML:
- task: UseDotNet@2
  displayName: 'Use .NET Core sdk 7.0.103'
  inputs:
    version: 7.0.103

@JasonTheProgrammer Yup!  Tried that today, deployment to Azure AppService still has the issue.
We are publishing Self Contained for win-x64

Just to be 100% clear on what we have tried.
GitHub Action Step for Installation
- name: Ensure .NET Installed
      uses: actions/setup-dotnet@v3
      with:
        dotnet-version: '7.0.103'

We then also added a global.json file next to the .sln file with the following content
{
    "sdk": {
      "version": "7.0.103"
    }
  }

Our command for publishing is
dotnet publish "MyProject.csproj" --runtime win-x64 --self-contained --configuration Release --output ./App --no-restore  -p:version=2.0.3

Running/deploying using these steps did NOT fix the final solution.  If I'm missing something I'm all ears

@mitchelsellers For what it's worth, your global.json isn't specifying "rollForward": "disable" like offered in earlier examples. I don't know what the default behaviour is if that's not specified, but it could be rollowing forward to the later version?
The GitHub action step looks like it's just ensuring dotnet 7.0.103 is installed, not necessarily instructing the build to use that version.
What's your build log output saying with respect to SDK and MSBuild version? If it's showing MSBuild as "MSBuild version 17.5.0-preview-23061-01+040e2a90e for .NET", then you've not effectively pinned the earlier SDK. Pinning SDK 7.0.103 should result in it using MSBuild 17.4.1.

@JasonTheProgrammer it worked locally so I didn't expect it to behave differently.  Without the "rollForward" bit in the global.json the MS Build version on the GitHub built was MSBuild version 17.5.0-preview-23061-01+040e2a90e for .NET.
I added the rollForward bit to my global.json so it looks like this now
{
    "sdk": {
      "version": "7.0.103",
      "rollForward": "disable"
    }
}

Still seeing the same MSBuild version when using that one

@kanadaj Ok, this is a fun one, our repository had the structure of
/
/src
/src/projects
Our solution file was in the /src folder, we had put the global.json there, which fixed locally etc.  But didn't work with GitHub Actions.
Putting it in the root still allowed the local stuff to work, AND fixed it on GitHub Actions for now.  The part I bolded from the docs here was what escaped my management

The .NET SDK looks for a global.json file in the current working directory (which isn't necessarily the same as the project directory) or one of its parent directories.

I just updated:

SDK: 7.0.202, 6.0.407
runtime: 7.0.4, 6.0.15
VS for Mac: 17.5.2 (build 14)

and the problem is gone...

@indigogiant I just want to check if you've tested those versions you list, or if it was just assumption? Since my testing partly contradicts the versions you listed, I just wanted to check.

Sorry for the late response, probably not much use now but for what it's worth it's partly experience and partly assumption. We hit it when the VS build agents moved to the new runtimes, .406 was failing for us so curious that it worked for you.
It was mentioned elsewhere that the issue was related to those runtime versions, hence the caveat about it being from what I could gather.

Sorry for the late response, probably not much use now but for what it's worth it's partly experience and partly assumption. We hit it when the VS build agents moved to the new runtimes, .406 was failing for us so curious that it worked for you.
It was mentioned elsewhere that the issue was related to those runtime versions, hence the caveat about it being from what I could gather.

Ah those sneaky runtimes! I completely missed that part, i don't think i ever checked that.
Anyway, the problem seems solved, so thanks everyone involved 🙂

Is the problem resolved in Azure DevOps yet? I can see it's fixed in Visual Studio but I think the problem still happens if you build using Azure DevOps.

Fixed in VS 17.5.2?

For those using Rider: 7.0.202 seems to solve problem.
I target .NET 6 and I fixed SDK in global.json to 7.0.202. With this SDK vc taghelper is compiled as before.

Fixed by https://github.com/dotnet/razor/pull/8328.
The fix was released in .NET March 2023 Update (SDK 7.0.202 and 6.0.407) and Visual Studio 17.5.2.
Sorry for the inconvenience everyone!

Is it safe to assume that the update has also been made to azure, so that we can stop pinning build SDKs to 7.103

Same question. It's been closed but is it actually fixed in Azure DevOps?

Not fixed in Azure DevOps.
I just tried it and the agent hasn't been updated yet, the sdk for the win2022 is still 7.0.201.
Agent description page : https://github.com/actions/runner-images/blob/main/images/win/Windows2022-Readme.md


PanOnScrollMode.Horizontal seems to be broken

Describe the Bug
I set zoomOnScroll={false} and then set the panOnScroll prop on my ReactFlow and set the panOnScrollMode using ternary logic according to a state value that is modified when I hold down Shift (to intuitively match behavior of a plain old HTML web page section's scrolling) but it doesn't work. The logic: shiftHeld ? PanOnScrollMode.Horizontal : PanOnScrollMode.Vertical
I searched on the Discussions tab and found this discussion. I accordingly updated the panOnDrag prop (newer version equivalent of paneMoveable mentioned in that thread) to be false when Shift is held down. It still doesn't work. Am I missing something? Can anyone point me to a place that demonstrates a working example that causes horizontal panning when Shift is held down?
Note: I can verify my state is being conveyed correctly because it no longer pans in the vertical direction when I hold down Shift, but neither is it panning horizontally like it's supposed to.
Your Example Website or App
No response
Steps to Reproduce the Bug or Issue
Attempt to configure a ReactFlow to panOnScroll horizontally with<EMAIL_ADDRESS>Expected behavior
I wanted to have the diagram pan horizontally like simple web pages scroll horizontally when you perform a Shift+<mouse-wheel> action.
Screenshots or Videos

Platform

OS: Windows 10 Enterprise
Browser: Chrome
Version: Version 115.0.5790.110 (Official Build) (64-bit)

Additional context
I have no idea what version of react-flow is used for this demo app and I doubt they have the specific key handling , but it at least demonstrates that PanOnScrollMode.Horizontal does not achieve out-of-the-box what I intuitively thought it should (that is, Shift+mouse-wheel panning side-to-side).

Hey @bcrudolp I have raised a PR for this issue you can test it by checking out in this branch. Thanks.

This must be a Windows issue then. I was actually using PanOnScrollMode.Horizontal only as a workaround when I found I couldn't use Shift+mousewheel-scroll to pan sideways with PanOnScrollMode.Free.

@checkomkar this fix does seem to fix being able to horizontally scroll, and would work with my current strategy of catching the Shift key manually to switch between PanOnScrollMode.Horizontal and PanOnScrollMode.Vertical. But it does not establish the behavior where PanOnScrollMode.Free allows horizontal panning when Shift+mousewheel-scroll is used.
@moklick are you in agreement that it should pan horizontally in PanOnScrollMode.Free with a Shift+mousewheel-scroll action?

@bcrudolp I can pan horizontally with Shift + mousewheel scroll when I use panOnScroll + PanOnScrollMode.Free.

@moklick on Mac, right?

Yep, macOS. I need to check a windows machine

For now I couldn't find a solution for this. On Windows the middle mouse key activates horizontal scroll for IE, Firefox and Chrome (Shift is the macOS default) https://q8gsdq.csb.app/.
Middle mouse should already work but a mouseup event gets triggered as soon as the user moves the mouse (while holding middle mouse) on Windows. I need to figure out why.


Several keylime tenant commands not handline error returned by server

Description
Several of the keylime tenant commands (addruntimepolicy,updateruntimepolicy,deleteruntimepolicy) are not looking at the returned status_code at all and keylime_tenant exits with 0 even though an error occurred.
https://github.com/keylime/keylime/blob/63aff11f8029ef071039b0f36808c7110390a7c7/keylime/tenant.py#L1235-L1264

Per the test cases, yes: https://github.com/RedHat-SP-Security/keylime-tests/pull/354


Navigation styles missing in custom build scss file

Swiper Version: v6.4.10 (from tag) and latest from master
Platform/Target and Browser Versions: web

What You Did
Built custom swiper build with following configuration:
build-config.js
module.exports = {
  components: [
    'virtual',
    'navigation',
  ],
  themeColor: '#007aff',
  colors: {
    white: '#ffffff',
    black: '#000000',
  },
};

Expected Behavior
/package/swiper.scss file should contain navigation styles, e.g. .swiper-button-prev, .swiper-button-next etc.
Actual Behavior
Navigation styles are missing from swiper.scss and swiper.less files, while swiper-bundle.css file has navigation styles included, as expected.

https://swiperjs.com/swiper-api#scss-styles
Navigation styles are in components/navigation/navigation.scss


Authentication redirects to plain HTTP signin-oidc callback

I am currently running a setup where I am hosting my IdentityServer application on Azure, and the rest of my infrastructure on Docker. HTTPS is provided through a reverse proxy.
When I land on my application via HTTPS, it correctly redirects to identity server over HTTP. The user then provides their credentials, after which IdentityServer redirects it back to my application over plain HTTP.
I'm currently not exposing my application over plain HTTP, and if at all possible, prefer not to expose it over HTTP at all.
My question is, why does IdentityServer use plain HTTP for the callback, and is it possible to change this behaviour through an option I'm missing?
I've tried only providing a HTTPS address for the callback, but that results in an error unfortunately.
Thanks for your time!

I had a similar problem (docker and reverse proxy) and fixed it with the following code in startup before app.UseIdentityServer():
app.Use(async (context, next) =>
{
   context.Request.Scheme = "https";
   await next.Invoke();
});

IdentityServer passes back the protocol it received.
Sounds like your app is running http with a reverse proxy terminating SSL and then forwarding http. Therefore, it is issuing the callback-redirect-url using http.
You should map a X-FORWARDED-PROTO to the request protocol.  Kestrel's .useIISIntegration() should do that, if that applies.  Otherwise, in your Startup.cs, configure:
app.UseForwardedHeaders(new ForwardedHeadersOptions
            {
                ForwardedHeaders = ForwardedHeaders.XForwardedFor | ForwardedHeaders.XForwardedProto
            });

Yep - that's how ASP.NET Core works.

Thank you guys for the assist - I managed to get it working with the above snippets, and learned something about how ASP.NET Core works.

Hi,
I'm using ASP.Net Core 2.1 and IdentityServer4 and having the same issue after the login is authorized. The callback page http://test.ems.net/signin-oidc return an empty page with error 404.
Request header:
Host: test.ems.net User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:62.0) Gecko/20100101 Firefox/62.0 Accept: text/html,application/xhtml+xml,application/xml;q=0.9,*/*;q=0.8 Accept-Language: en-US,en;q=0.5 Accept-Encoding: gzip, deflate Content-Type: application/x-www-form-urlencoded Content-Length: 1612 Cookie: .AspNetCore.OpenIdConnect.Nonce.CfDJ8PB7g-EnrphIjAiOy7MzaJT90TnYvMl8F3mLCAK-uAWfUxRnfSVSWG2sDaIcCfgJQLXBLLVVO22vKddmZSUSdxBp6VU6X4pPDd2bhEIgzkSHxWso0GY3aOcp0rjsCPxZKxEydGGntQKHVN-wytrNSv-QShwJAY-BPJoPY4pus0SHnU8TMdQLtiirSTZjEWFzXKgCjUSVQt7Pvx1k8l5GPcFb0Dk36IPyw0qeJmWGoeBgPZO2lv2BRLkOu-7PRqKjvfvjGp1vKaB9Q62Piy91lDo=N; .AspNetCore.Correlation.oidc.tP5mvB60KVsX6jwQuxbCGABLvSsRXBMy9QAxLnbAAEM=N; .AspNetCore.OpenIdConnect.Nonce.CfDJ8PB7g-EnrphIjAiOy7MzaJSfkdcOdrFRm6NuakDdc6pjqsAHFV30sINZ1Ab2tDHWMX8D-tk8T3oxjEl1IVggERxFSz3MKpoTq7c1-FS5_cPZdJbHMAeSmHPNB0_9vAXRPPQfyCFLQMS-5hv1b5Cj_ayqx2KV2G-Xk6ogUjYcdLnGKptTzCF0CBfoGRvQiaTV5a0A30mpIo2abvvoP1K9J6zV7poWBUdoheW9--EBC189NwRx1ip3vaUGqSO0YsXvjxxu7dhCxKHYG-f5Ss9KkzE=N; .AspNetCore.Correlation.oidc.byOSCm3Z18EOYK2g3Ty4Cb7bjOW2YiCZNM7aazhzmuE=N; .AspNetCore.OpenIdConnect.Nonce.CfDJ8PB7g-EnrphIjAiOy7MzaJQddbLcPdIXdzDQNI7jG10PHt1Acnnp2HnrNmqbIBpza-3r83M7W2Q_ambQH6uKw_uyy0jI7R7Nf3B6qARkoBqYU_BxOoaW6uUIjGoxwTrttdvQaW9fvwFcxIvKKKXIr7tbEHY8M3Fglsw__ST0R4d28r1wK6_7xh2yGuhOhYClmnD4aNpXQuyEfVDndN9doS4tk_aLMUUXTRhpSNDq4mX1Sz64nI79tBjKzmiLkqTyy4_zIMkIt2ur-nG4wgt9tno=N; .AspNetCore.Correlation.oidc.BUVGAC2UC7mkbV6_OtVSda9DmH6FAh9h03-Xua_cqIc=N DNT: 1 Connection: keep-alive Upgrade-Insecure-Requests: 1 Cache-Control: max-age=0
Response Header:
HTTP/1.1 404 Not Found Server: Kestrel X-Powered-By: ASP.NET Date: Thu, 04 Oct 2018 12:36:00 GMT Content-Length: 0
FireFox error message:
The character encoding of the plain text document was not declared. The document will render with garbled text in some browser configurations if the document contains characters from outside the US-ASCII range. The character encoding of the file needs to be declared in the transfer protocol or file needs to use a byte order mark as an encoding signature.
My log text:
`2018-10-04 08:46:43.219 : Information => 0 - Authorize endpoint response
{
"SubjectId": "1",
"ClientId": "EMS_WebApp",
"RedirectUri": "http://test.ems.net/signin-oidc",
"State": "CfDJ8PB7g-EnrphIjAiOy7MzaJRb1lkrRjfrD1i-DStJUMXu5YvWwiShBuvPXcvjnN6k1LmEOiH42GZly75kf5ADbba6B1WFnHOynLTV5nlMRwfnRFPGW_t6MFH9YJvriIwzrubgTQZRD1vYzmiciK60dlzg6fyhyXGH--TtoxuC6b2y3AUMTXJ4ru7RnS2ggodAUWO6vzvsH-wGIlB19uZUHkRXAz3RTsksCtYg91fnA7UG6d1SVy0p-akpDEnJOsHTqFN2qu3UWHZ4GX6T5QlFuqgBl4HpvlHCfvXp1U_p04217E1QF10AI_7B7OdDSNUFlg",
"Scope": "openid profile"
} - *
2018-10-04 08:46:43.22 : Debug => 0 - Augmenting SignInContext - *
2018-10-04 08:46:43.22 : Information => 10 - AuthenticationScheme: idsrv signed in. - *
2018-10-04 08:46:43.22 : Information => 2 - Request finished in 8.1483ms 200 text/html; charset=UTF-8 - *
2018-10-04 08:46:43.586 : Information => 1 - Request starting HTTP/1.1 POST http://test.ems.net/signin-oidc application/x-www-form-urlencoded 1612 - *
2018-10-04 08:46:43.586 : Information => 2 - Request finished in 0.5654ms 404  - *
2018-10-04 08:46:43.586 : Information => 32 - Connection id "0HLH9UN00CBF8", Request id "0HLH9UN00CBF8:00000002": the application completed without reading the entire request body. - *
`
The same application, IdentityServer and Clients works perfectly in my LocalHost, after publishing to Windows Server 2012 R2 and ISS 8.5, the issue happens after the login.
Please help.
Regards.


README.md: Link IRC channel

Can you please change that to be the same way as in the last line in https://github.com/ArchiveTeam/standalone-readme-template/blob/master/README.wget-at.md?

Can you please change that to be the same way as in the last line in https://github.com/ArchiveTeam/standalone-readme-template/blob/master/README.wget-at.md?

The whole line? Or just the IRC channel link part?

I would say the IRC channel link part and the explicit mention of hackint IRC. The problem with an non-HTTP IRC URL is that it'll be hard for many people to get in contact as they don't have an IRC client set up.

Thank you!


[shared_preferences] Failed to resolve native function 'Window_sendPlatformMessage' in 'Window._sendPlatformMessage@112065589'

Steps to Reproduce

execute method with compute
call await SharedPreferences.getInstance()

Logs

../../third_party/dart/runtime/vm/native_entry.cc: 222: error: Failed to resolve native function 'Window_sendPlatformMessage' in 'Window._sendPlatformMessage@112065589'

Analyzing schoolsen-mobile...
No issues found! (ran in 12.2s)

[✓] Flutter (Channel beta, v1.3.8, on Linux, locale en_US.UTF-8)
    • Flutter version 1.3.8 at /home/gregor/development/flutter
    • Framework revision e5b1ed7a7f (4 weeks ago), 2019-03-06 14:23:37 -0800
    • Engine revision f4951df193
    • Dart version 2.2.1 (build 2.2.1-dev.0.0 571ea80e11)

[✓] Android toolchain - develop for Android devices (Android SDK version 28.0.3)
    • Android SDK at /home/gregor/Android/Sdk
    • Android NDK location not configured (optional; useful for native profiling support)
    • Platform android-28, build-tools 28.0.3
    • Java binary at: /snap/android-studio/73/android-studio/jre/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1248-b01)
    • All Android licenses accepted.

[✓] Android Studio (version 3.3)
    • Android Studio at /snap/android-studio/73/android-studio
    • Flutter plugin version 34.0.1
    • Dart plugin version 182.5215
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1248-b01)

[✓] Connected device (2 available)
    • ONEPLUS A3003             • fe20f4e6      • android-arm64 • Android 8.0.0 (API 26)
    • Android SDK built for x86 • emulator-5554 • android-x86   • Android 9 (API 28) (emulator)

• No issues found!

There should be a better error message.

Duplicate of https://github.com/flutter/flutter/issues/13937


Units in Reports

The organization report shows the names of the aggregated quantities without the units. It would be good to have both the names and the units for each metric in the report.

IMO adding the units to all aggregated and accumulated usage docs would unnecessarily bloat them (as opposed to just having a side configuration of the units if you need to display these units in your UI for example).
For that reason, I'm not planning to implement this change, so I'm closing the issue for now.
If anybody wants to submit a pull request with the changes to implement this and clear evidence that they're not causing a significant performance degradation, then please feel free to reopen this issue with the pull request. Thanks!


[KF related] DTS and patch

KF: Use correct DTS for dom0 and domd
KF: Add patch "Add multichannel audio ranges ..."

I'm okay with the changes, but for the first patch, could you please elaborate what is "proper" dts and why original one was not suitable for the build?
With this addressed:
Acked-by: Volodymyr Babchuk<EMAIL_ADDRESS>

Explanation regarding DTSes is provided as commit message.
For convenience, here is explanation:

KF: Use correct DTS for dom0 and domd
Now we use KF related DTS from prod-devel REL-v7.0.
At same time we have two important fixes for KF in prod-devel's master.
bc02c4583e42698e060e143c0dd68b0c697e9aa0
dom0/domd: Update h3ulcb-4x2g-kf resources to match Yocto v5.1.0

bfc60292d30707e74fe2697e5369262ef4029114
h3ulcb-4x2g-kf: Enable missing ipmmu_rt in dom0 device-tree

This patch replaces KF's DTS (from REL-v7.0) by their fixed versions
from prod-devel's master.

"Acked-by" is added. Comment is addressed.
PR is ready to be merged.


converting 3 minimal mDNS unit tests from NL_unit to pw_unit

This is based on the effort of issue #29342

#33069 seems to be the equivalent full conversion. Since this PR seems to have timed-out in some CI, closing this and keeping the other complete conversion for review.