HBASE-28028 Read all compressed bytes to a byte array before submitti…

…ng them to decompressor

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 37s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m  9s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 53s
master passed

+1 :green_heart:
compile
2m 56s
master passed

+1 :green_heart:
checkstyle
0m 51s
master passed

+1 :green_heart:
spotless
0m 44s
branch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
2m  5s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 31s
the patch passed

+1 :green_heart:
compile
2m 56s
the patch passed

+1 :green_heart:
javac
2m 56s
the patch passed

+1 :green_heart:
checkstyle
0m 51s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
9m 11s
Patch does not cause any errors with Hadoop 3.2.4 3.3.5.

-1 :x:
spotless
0m 37s
patch has 19 errors when running spotless:check, run spotless:apply to fix.

+1 :green_heart:
spotbugs
2m 16s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 20s
The patch does not generate ASF License warnings.

34m 51s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5357/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5357

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile

uname
Linux 6c8baba94495 5.4.0-152-generic #169-Ubuntu SMP Tue Jun 6 22:23:09 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / b1fd92d3c7

Default Java
Eclipse Adoptium-11.0.17+8

spotless
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5357/1/artifact/yetus-general-check/output/patch-spotless.txt

Max. process+thread count
78 (vs. ulimit of 30000)

modules
C: hbase-common hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5357/1/console

versions
git=2.34.1 maven=3.8.6 spotbugs=4.7.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 25s
Docker mode activated.

-0 :warning:
yetus
0m  2s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 51s
master passed

+1 :green_heart:
compile
0m 58s
master passed

+1 :green_heart:
shadedjars
4m 57s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 37s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 37s
the patch passed

+1 :green_heart:
compile
0m 59s
the patch passed

+1 :green_heart:
javac
0m 59s
the patch passed

+1 :green_heart:
shadedjars
4m 56s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 35s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
2m  7s
hbase-common in the patch passed.

-1 :x:
unit
211m 34s
hbase-server in the patch failed.

237m 24s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5357/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5357

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 572d90827a87 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / b1fd92d3c7

Default Java
Eclipse Adoptium-11.0.17+8

unit
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5357/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5357/1/testReport/

Max. process+thread count
5025 (vs. ulimit of 30000)

modules
C: hbase-common hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5357/1/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 34s
Docker mode activated.

-0 :warning:
yetus
0m  2s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 28s
master passed

+1 :green_heart:
compile
0m 57s
master passed

+1 :green_heart:
shadedjars
4m 35s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 41s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 16s
the patch passed

+1 :green_heart:
compile
0m 57s
the patch passed

+1 :green_heart:
javac
0m 57s
the patch passed

+1 :green_heart:
shadedjars
4m 31s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 38s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 48s
hbase-common in the patch passed.

+1 :green_heart:
unit
229m 39s
hbase-server in the patch passed.

254m  9s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5357/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5357

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 3e0b92bdf1ff 5.4.0-156-generic #173-Ubuntu SMP Tue Jul 11 07:25:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / b1fd92d3c7

Default Java
Temurin-1.8.0_352-b08

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5357/1/testReport/

Max. process+thread count
4790 (vs. ulimit of 30000)

modules
C: hbase-common hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5357/1/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 35s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 50s
master passed

+1 :green_heart:
compile
3m 45s
master passed

+1 :green_heart:
checkstyle
0m 52s
master passed

+1 :green_heart:
spotless
0m 52s
branch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
2m 22s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 47s
the patch passed

+1 :green_heart:
compile
3m 34s
the patch passed

+1 :green_heart:
javac
3m 34s
the patch passed

+1 :green_heart:
checkstyle
0m 52s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
13m 50s
Patch does not cause any errors with Hadoop 3.2.4 3.3.5.

+1 :green_heart:
spotless
1m  4s
patch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
3m 20s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 31s
The patch does not generate ASF License warnings.

49m  2s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5357/2/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5357

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile

uname
Linux a5f8e88ffb96 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 8ccb910fa9

Default Java
Eclipse Adoptium-11.0.17+8

Max. process+thread count
79 (vs. ulimit of 30000)

modules
C: hbase-common hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5357/2/console

versions
git=2.34.1 maven=3.8.6 spotbugs=4.7.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 36s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 15s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m  7s
master passed

+1 :green_heart:
compile
1m 24s
master passed

+1 :green_heart:
shadedjars
5m 51s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 47s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 43s
the patch passed

+1 :green_heart:
compile
1m 22s
the patch passed

+1 :green_heart:
javac
1m 22s
the patch passed

+1 :green_heart:
shadedjars
5m 42s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 42s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
2m 32s
hbase-common in the patch passed.

-1 :x:
unit
224m 13s
hbase-server in the patch failed.

256m 15s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5357/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5357

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 47cc28b6f228 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 8ccb910fa9

Default Java
Eclipse Adoptium-11.0.17+8

unit
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5357/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5357/2/testReport/

Max. process+thread count
5198 (vs. ulimit of 30000)

modules
C: hbase-common hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5357/2/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 38s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m  1s
master passed

+1 :green_heart:
compile
1m  2s
master passed

+1 :green_heart:
shadedjars
5m 20s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 42s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 50s
the patch passed

+1 :green_heart:
compile
0m 57s
the patch passed

+1 :green_heart:
javac
0m 57s
the patch passed

+1 :green_heart:
shadedjars
5m  9s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 38s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
2m 23s
hbase-common in the patch passed.

+1 :green_heart:
unit
228m 30s
hbase-server in the patch passed.

256m 20s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5357/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5357

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux b496e2e8994a 5.4.0-152-generic #169-Ubuntu SMP Tue Jun 6 22:23:09 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 8ccb910fa9

Default Java
Temurin-1.8.0_352-b08

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5357/2/testReport/

Max. process+thread count
4593 (vs. ulimit of 30000)

modules
C: hbase-common hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5357/2/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Ping @apurtell

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 34s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 16s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 39s
master passed

+1 :green_heart:
compile
2m 57s
master passed

+1 :green_heart:
checkstyle
0m 50s
master passed

+1 :green_heart:
spotless
0m 42s
branch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
2m  0s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 12s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 33s
the patch passed

+1 :green_heart:
compile
2m 55s
the patch passed

+1 :green_heart:
javac
2m 55s
the patch passed

+1 :green_heart:
checkstyle
0m 50s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
9m  6s
Patch does not cause any errors with Hadoop 3.2.4 3.3.5.

+1 :green_heart:
spotless
0m 40s
patch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
2m 13s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 19s
The patch does not generate ASF License warnings.

34m 45s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5357/3/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5357

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile

uname
Linux 8c9495fa4d51 5.4.0-152-generic #169-Ubuntu SMP Tue Jun 6 22:23:09 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 8ccb910fa9

Default Java
Eclipse Adoptium-11.0.17+8

Max. process+thread count
79 (vs. ulimit of 30000)

modules
C: hbase-common hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5357/3/console

versions
git=2.34.1 maven=3.8.6 spotbugs=4.7.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 24s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 20s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 35s
master passed

+1 :green_heart:
compile
0m 58s
master passed

+1 :green_heart:
shadedjars
4m 54s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 35s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 12s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 32s
the patch passed

+1 :green_heart:
compile
0m 58s
the patch passed

+1 :green_heart:
javac
0m 58s
the patch passed

+1 :green_heart:
shadedjars
4m 53s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 35s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
2m 12s
hbase-common in the patch passed.

+1 :green_heart:
unit
211m  3s
hbase-server in the patch passed.

236m 26s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5357/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5357

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 5d84e00dbb9c 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 8ccb910fa9

Default Java
Eclipse Adoptium-11.0.17+8

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5357/3/testReport/

Max. process+thread count
4682 (vs. ulimit of 30000)

modules
C: hbase-common hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5357/3/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 31s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 10s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 27s
master passed

+1 :green_heart:
compile
0m 56s
master passed

+1 :green_heart:
shadedjars
4m 33s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 38s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 18s
the patch passed

+1 :green_heart:
compile
0m 56s
the patch passed

+1 :green_heart:
javac
0m 56s
the patch passed

+1 :green_heart:
shadedjars
4m 32s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 38s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
2m  2s
hbase-common in the patch passed.

+1 :green_heart:
unit
236m  1s
hbase-server in the patch passed.

260m 41s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5357/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5357

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 4346a8e45a52 5.4.0-156-generic #173-Ubuntu SMP Tue Jul 11 07:25:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 8ccb910fa9

Default Java
Temurin-1.8.0_352-b08

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5357/3/testReport/

Max. process+thread count
4833 (vs. ulimit of 30000)

modules
C: hbase-common hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5357/3/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 34s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 15s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 40s
master passed

+1 :green_heart:
compile
2m 58s
master passed

+1 :green_heart:
checkstyle
0m 50s
master passed

+1 :green_heart:
spotless
0m 42s
branch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
1m 58s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 33s
the patch passed

+1 :green_heart:
compile
2m 56s
the patch passed

+1 :green_heart:
javac
2m 56s
the patch passed

+1 :green_heart:
checkstyle
0m 50s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
9m  8s
Patch does not cause any errors with Hadoop 3.2.4 3.3.5.

+1 :green_heart:
spotless
0m 40s
patch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
2m 16s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 19s
The patch does not generate ASF License warnings.

34m 57s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5357/4/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5357

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile

uname
Linux a50de2ebd35d 5.4.0-152-generic #169-Ubuntu SMP Tue Jun 6 22:23:09 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 89ca7f4ade

Default Java
Eclipse Adoptium-11.0.17+8

Max. process+thread count
78 (vs. ulimit of 30000)

modules
C: hbase-common hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5357/4/console

versions
git=2.34.1 maven=3.8.6 spotbugs=4.7.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 25s
Docker mode activated.

-0 :warning:
yetus
0m  2s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 21s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 38s
master passed

+1 :green_heart:
compile
1m  0s
master passed

+1 :green_heart:
shadedjars
4m 57s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 36s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 32s
the patch passed

+1 :green_heart:
compile
1m  1s
the patch passed

+1 :green_heart:
javac
1m  1s
the patch passed

+1 :green_heart:
shadedjars
4m 57s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 35s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
2m 13s
hbase-common in the patch passed.

+1 :green_heart:
unit
213m 52s
hbase-server in the patch passed.

239m 36s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5357/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5357

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 62e9adecd48a 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 89ca7f4ade

Default Java
Eclipse Adoptium-11.0.17+8

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5357/4/testReport/

Max. process+thread count
4674 (vs. ulimit of 30000)

modules
C: hbase-common hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5357/4/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 30s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 14s
master passed

+1 :green_heart:
compile
0m 57s
master passed

+1 :green_heart:
shadedjars
4m 36s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 37s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 17s
the patch passed

+1 :green_heart:
compile
0m 57s
the patch passed

+1 :green_heart:
javac
0m 57s
the patch passed

+1 :green_heart:
shadedjars
4m 32s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 38s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
2m  2s
hbase-common in the patch passed.

+1 :green_heart:
unit
232m  0s
hbase-server in the patch passed.

256m 56s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5357/4/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5357

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux ec561a3c4095 5.4.0-156-generic #173-Ubuntu SMP Tue Jul 11 07:25:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 89ca7f4ade

Default Java
Temurin-1.8.0_352-b08

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5357/4/testReport/

Max. process+thread count
4805 (vs. ulimit of 30000)

modules
C: hbase-common hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5357/4/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.


Support Portal Masks

It would be really sick if we could use an image or a gif or something as a mask for the portal. Masks are often used in video/photo editing to define an area to cut out. So we could use an image (or a gif for a spinning/moving portral) to cutout what the portal is shaped like, that way we could do something like make a portal shaped like a wormhole or some other kind of portal.
It would also be cool if we could supply image or gif overlays on top of the portal to do things like make tentacles coming out. Or perhaps this would be better suited as custom portal models?
I think these features would enhance the potential of this mod by making them feel more immersive and natural to the game scene (especially for map creators)

It's probably achievable using the GUI portal feature


Implementing client credentials grant for Spring fox

I have a working spring mvc swagger implementation (the old version prior to spring fox) and I am looking at updating it to spring fox.
I have a working client credentials version using some custom code. Is client credentials grant supported? I saw some talk on the issues page that said it would be in the future (has the future happened yet).
I want to update my version of this with the new spring fox. Any examples?

@EvilJinious1

I have a working client credentials version using some custom code.

Custom code swagger-ui or springfox plugin?

Is client credentials grant supported?

oauth support in general is very spotty in swagger-ui. I haven't checked but as far as I know everything thats supported in swagger-ui 2.14 is supported in the latest snapshot build

I want to update my version of this with the new spring fox. Any examples?

This is the repo to look for examples! So you're in luck :smile: There is a document that explains the transition from swagger-springmvc to sprinfox

any examples on client credentials grant type (application flow) using springfox?

@ankurdhingra Here is a minimal example:
`    AuthorizationScope authScope = new AuthorizationScope("read_write_scope", "Read/Write scope.");
Docket api = new Docket(DocumentationType.SWAGGER_2)
    .securitySchemes(securitySchemes())
    .securityContexts(securityContexts());

/**
 * Generates the Security Definition Object of the Swagger Object
 * http://swagger.io/specification/#securityDefinitionsObject
 *
 *     {
 *         "oauth2_client_credentials": {
 *             "type": "oauth2",
 *             "tokenUrl": "http://host/oauth/token",
 *             "flow": "application",
 *             "scopes": {
 *                 "read_write_scope": "Read/Write scope."
 *             }
 *         }
 *     }
 */
private List<OAuth> securitySchemes() {
    return singletonList(new OAuth(
      "oauth2_client_credentials",
      singletonList(authScope),
      singletonList(new ClientCredentialsGrant("http://host/oauth/token"))));
}

/**
 * The List<SecurityReference> to put on each Operation Object matching the endpoints defined in the regex.
 * http://swagger.io/specification/#operationObject
 *
 */
private List<SecurityContext> securityContexts() {
    return singletonList(new SecurityContext(
      securityRequirements(),
      PathSelectors.regex(API_PATH_REGEX)));
}

/**
 * Generates a Security Requirement Object.
 * http://swagger.io/specification/#securityRequirementObject
 *
 *     "security": [{
 *         "oauth2_client_credentials": [ "read_write_scope" ]
 *     }]
 */
private List<SecurityReference> securityRequirements() {
    AuthorizationScope[] authScopes = new AuthorizationScope[1];
    authScopes[0] = authScope;
    return singletonList(new SecurityReference("oauth2_client_credentials", authScopes));
}`

Here is a good example on client credentials grant type ("application" flow):
https://stackoverflow.com/questions/42054384/how-to-configure-oauth2-with-password-flow-with-swagger-ui-in-spring-boot-rest-a#answer-46715492


URL for each puzzle

Thanks for creating this.  It would be great if each puzzle had its own URL, e.g. https://www.devangthakkar.com/wordle_archive/42 so you could, e.g. bookmark the one you've got up to.  Want a PR for this?

Sure, that would be great! Thanks for working on this. :)

PR created.  Let me know if you get a chance to look at it.  Cheers.

Thanks for working on this. Closing this.


Where does augmentation happen in pretraining?

Hello!
Very cool idea and repo but I cannot see where exactly in the code the augmentation happens to constrast the moelcules in the pretraining.
Can you maybe point it out?
Thanks in advance.

Hi,
You can find the code for augmentation at here, and the code for contrastive learning at here.
I hope this helps!


Crash on meeting G-Baby

Version
3.1.8 (133fb8e)
Seed
R721-YQ4B-XXRA00Q6Z2Y7E17X8HW8210CKCV052C9FLA3B4YNQX1E0KZZZ
Scenario
RE 2 (Claire)
Player Character
Sheva as Claire
What happened?
Immediately after seeing Piers with his "face-shirt," going to fight G-Baby results in a crash. I have no idea if this data is relevant, but I included the crash pop-up.

Please post a saved game

I would, but I deleted all of them after the crash. I tend to keep my Save folder tidy. I'll remember to preserve my save files from now on.

I think this is fixed in latest version


Retain Suggestions When Typing

Obsidian Copilot Auto Completion will reject the suggestion as soon as the user continues to type, even if their text matches the suggestion.
This is different to the behaviour of GitHub Copilot, which continues to provide the suggestion up until the user types something that doesn't match the suggestion.
Pressing escape or clicking away will still clear the suggestion and transition back to the idle state.
Example
GitHub Copilot

Obsidian Copilot Auto Completion

I've already hacked together a working version of this feature, but if you think it's a good addition I can clean it up and make a PR.

This is indeed something on my wish list but I haven't had time. So I'm happy to hear what you propose and discuss to come to a nice solution :)


Recreate the various lily-* repos I have

I created repos like postgres and apache a long time ago. Normally I wouldn't do this, but most of their history is not code that's been added to them. Rather, their history is largely about fixing the library for adjustments in the api. Recreating the repos would allow a fresh history, untainted by api changes that would make it difficult to read why changes have been done.

Gonna not do this after all. Yeah, a lot of the history is churn, but some of the repos have contributions that I don't want to erase after all.


PIXI. FilterManager ?

hum , what this suppose do ?
if i understand , it just a class to store, create and distribute the filters need in a project?
https://pixijs.download/v4.5.2/docs/PIXI.FilterManager.html

https://github.com/pixijs/pixi.js/blob/dev/src/core/renderers/webgl/managers/FilterManager.js#L62
pushFilter, popFilter are called from Container.


expose removeAllListeners method in ValorantWebsocketClient

Allow websocket consumers to remove event listeners without disconnecting.

Can you briefly explain the condition/use-case where this code change would be useful?

Sure, whenever we unsubscribe from events we would also like to remove the websocket listeners. Without this capability, one cannot subscribe() again with new event listeners since the previous event listeners are still active

Thanks for the contribution, Good PR.


Include offending identifier in collision error message.

Message would be annoyingly useless to a newcomer.

Or rather, since this case is special, perhaps just a different message.

Actually, or do we want to just use NameAllocator to have the same behavior as table_name for this special case?

feels like a good use for NameAllocator
The trick is that it's not obvious to the person consuming the java class which CREATE_TABLE they're getting

So this case is especially tough because the create_table-named statement is implicitly created and the name never shows up in the .sq file. Perhaps we should special case this situation to get a better exception message.


Shutter not re-opening when channel is changed during live mode

We are having some issue with changing channels when in Live Mode. Essentially, if the channel (which LED is on) is changed during the live mode, the LED gets turned off, but the new LED does not get turned on. The change only fully occurs when the live mode is stopped and restarted it.
I'm not sure if that's the best way, but I resolved this bug by adding this to the self._connections list in the _core_link.py code:
self._mmc.events.configSet, self._restart_live

thanks for the very specific help @simonecoppola, i'm find with that fix.  would you be willing to submit a PR?  (if not, no worries i can submit it)

Great! I've just submitted the PR (I'm not super familiar with that aspect of Github yet so I hope I've done it right!)
And thank you for your work on pymmcore-plus, it's great! I have a lot more questions but will open other issues as I go :)

Thanks for the PR!
Glad you're finding pymmcore-plus useful.  Please feel free to ask away :)
If you'd like more real-time discussion, I also pay attention on the Imagesc zulip chat, and started a channel there: https://imagesc.zulipchat.com/#narrow/stream/442785-pymmcore.5B-plus.5D


implement turbulence statistic in the core module

The sequence analysis package TraMineR (written in R) implements Elzinga's turbulance statistic - a Python implementation in pysan would be very useful.
Useful Links:
TraMineR implementation
Elzinga & Liefbroer's 2007 paper defining the statistic

completed, pending thorough testing


Connect to Azure Service Bus Emulator via Service Bus Explorer

Is there a way to connect to Azure Service Bus Emulator via Service Bus Explorer?
I tried a couple of things, using connection strings provided in the brief documentation but nothing is working

@MuhamedKr - Azure Service Bus emulator isn't compatible with community owned open-source Service Bus explorer. We have mentioned it in our public documentation as well - https://learn.microsoft.com/en-us/azure/service-bus-messaging/overview-emulator#benefits


Music just doesn't repeat

I've created my own Music pack and the tracks don't loop after they've ended, no errors appear in console or anything the music just stops and won't replay unless I reload the map..
As far as I can tell this doesn't happen with any other pack I've downloaded

https://github.com/relaxtakenotes/gm-action-music/assets/173845521/cdf252af-058b-4ae6-8e6f-4b2b60b6f1d3
Here's that video, pardon the low quality I had to make it fit on this website but it should still be readable
I couldn't find that debug command you mentioned although I have a feeling developer gives enough info still

well doesn't seem to tell me much. can you send over the pack? you can use https://send.vis.ee/ for that

Sure here it is
https://send.vis.ee/download/d01bf7b8a199d7d5/#uledE0xLlVfq9jRyHTAAaQ

I didn't intend for it be a buildup and continuation it was just supposed to loop with one track in the category
but anyway so the issue is that I just needed more than one song in the categories?


chore(rating): update storybook with functionality

Description
Bring in some of the functionality to the rating storybook that exists for the site.
How and where has this been tested?

How this was tested:
[ ] Open storybook instance, move focus into the rating: expect is-focused class to be added
[x] Open storybook, click one of the icons: expect the input value to change

To-do list

[x] If my change impacts documentation, I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x] I have updated any relevant storybook stories and templates.
[x] This pull request is ready to merge.

TODO: find out why the focus isn't working... tabindex needed?

This should be taken care of when we merge #1642


Add pure CMake support

Public-Facing Changes

Adds CMake support

Description
We internally use CMake-based tooling to build packages from source and install. This PR improves the existing CMakeLists.txt to install CMake config.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Does https://github.com/foxglove/ws-protocol/blob/main/cpp/foxglove-websocket/CMakeLists.txt not work for you?

Hi @achim-k, unfortunately the existing CMakeLists.txt doesn't generate cmake package configuration. It only installs headers and libraries. For now, I have internally incorporated this repo as a submodule and wrapped it inside our custom CMakeLists.txt. You could check the closed PR diff to see the proposed change. The proposed change will work as a pure CMake build but needs more effort to make it work with Conan.


Android: PX dimension support for Android

In the iOS module the imageAsResized accounts for DP. Not Android. I'm resizing to 300x300 and the image is blurry. I had to manually account for the dp before sending to imageAsResized.
Is this intended? Seems annoying to have the modules be different.

@nitrag Still happening? And do you mean the density? Should be fixable in the Android source using the TiConvert class

Can't say for sure, sorry, closing.


[QUERY] How to set UserAssignedManagedIdentity to a VM that is created using new Azure SDK ( Azure.ResourceManager.Compute )

Library name and version
Azure.ResourceManager.Compute 1.4.0
Query/Question
I have an app that runs in a pool of VirtualMachines that are created using a C# App using new Azure .NET SDK ( Azure.ResourceManager.Compute ). I want to assign a UserAssignedManageIdentity to the VMs. I know how to do it using Azure's web interface and using old fluent SDK ( WithExistingUserAssignedManagedServiceIdentity ), but I haven't found how to do it using the new library.
Environment
Windows 10 .NET Framework 4.7.2

I found it. Setting VirtualMachineData.Identity made it work. Thanks for your support!
https://github.com/Azure/azure-sdk-for-net/blob/867aa6159e48b20e86ea14fa3e7b2324eb2f7ed3/sdk/compute/Azure.ResourceManager.Compute/samples/Generated/Samples/Sample_VirtualMachineCollection.cs#L1075


How to deal with IN operation?

Is there a easy way to determine whether m.A in ['a','b','c']?

Hi, thanks for asking the question. Currently the rules engine doesn't support the IN operator. We will consider adding it in the future.


Tests fail to run on Python 3.10 due to nose incompatibility

Describe the bug
The file test/runTests.py has a codepath that executes a shell command. The shell command requires the Python testing framework called nose. Unfortunately, nose is no longer maintained, and it broke starting with Python 3.9 (see here). So if you try to run python runTests.py in the test folder you'll get an error before any tests run.
To Reproduce

change directory so you're in the test folder.
run python runTests.py
Get output below.

Running tests:
tools
iotest
objects
construction
drivers
report
reportb
algorithms
algorithmsb
optimize
extras
mpi
python3.10 -m nose -v tools iotest objects construction drivers report reportb algorithms algorithmsb optimize extras mpi --with-id
Traceback (most recent call last):
  File "/Users/riley/miniforge3/envs/gsti310/lib/python3.10/runpy.py", line 196, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "/Users/riley/miniforge3/envs/gsti310/lib/python3.10/runpy.py", line 86, in _run_code
    exec(code, run_globals)
  File "/Users/riley/miniforge3/envs/gsti310/lib/python3.10/site-packages/nose/__main__.py", line 8, in <module>
    run_exit()
  File "/Users/riley/miniforge3/envs/gsti310/lib/python3.10/site-packages/nose/core.py", line 118, in __init__
    unittest.TestProgram.__init__(
  File "/Users/riley/miniforge3/envs/gsti310/lib/python3.10/unittest/main.py", line 100, in __init__
    self.parseArgs(argv)
  File "/Users/riley/miniforge3/envs/gsti310/lib/python3.10/site-packages/nose/core.py", line 179, in parseArgs
    self.createTests()
  File "/Users/riley/miniforge3/envs/gsti310/lib/python3.10/site-packages/nose/core.py", line 193, in createTests
    self.test = self.testLoader.loadTestsFromNames(self.testNames)
  File "/Users/riley/miniforge3/envs/gsti310/lib/python3.10/site-packages/nose/loader.py", line 481, in loadTestsFromNames
    return unittest.TestLoader.loadTestsFromNames(self, names, module)
  File "/Users/riley/miniforge3/envs/gsti310/lib/python3.10/unittest/loader.py", line 220, in loadTestsFromNames
    suites = [self.loadTestsFromName(name, module) for name in names]
  File "/Users/riley/miniforge3/envs/gsti310/lib/python3.10/unittest/loader.py", line 220, in <listcomp>
    suites = [self.loadTestsFromName(name, module) for name in names]
  File "/Users/riley/miniforge3/envs/gsti310/lib/python3.10/site-packages/nose/loader.py", line 431, in loadTestsFromName
    return self.loadTestsFromModule(
  File "/Users/riley/miniforge3/envs/gsti310/lib/python3.10/site-packages/nose/loader.py", line 354, in loadTestsFromModule
    tests.extend(self.loadTestsFromDir(module_path))
  File "/Users/riley/miniforge3/envs/gsti310/lib/python3.10/site-packages/nose/loader.py", line 183, in loadTestsFromDir
    yield self.loadTestsFromName(
  File "/Users/riley/miniforge3/envs/gsti310/lib/python3.10/site-packages/nose/loader.py", line 431, in loadTestsFromName
    return self.loadTestsFromModule(
  File "/Users/riley/miniforge3/envs/gsti310/lib/python3.10/site-packages/nose/loader.py", line 359, in loadTestsFromModule
    return self.suiteClass(ContextList(tests, context=module))
  File "/Users/riley/miniforge3/envs/gsti310/lib/python3.10/site-packages/nose/suite.py", line 428, in __call__
    return self.makeSuite(tests, context, **kw)
  File "/Users/riley/miniforge3/envs/gsti310/lib/python3.10/site-packages/nose/suite.py", line 475, in makeSuite
    suite = self.suiteClass(
  File "/Users/riley/miniforge3/envs/gsti310/lib/python3.10/site-packages/nose/suite.py", line 159, in __init__
    super(ContextSuite, self).__init__(tests)
  File "/Users/riley/miniforge3/envs/gsti310/lib/python3.10/site-packages/nose/suite.py", line 53, in __init__
    super(LazySuite, self).__init__()
  File "/Users/riley/miniforge3/envs/gsti310/lib/python3.10/unittest/suite.py", line 22, in __init__
    self._tests = []
  File "/Users/riley/miniforge3/envs/gsti310/lib/python3.10/site-packages/nose/suite.py", line 106, in _set_tests
    if isinstance(tests, collections.Callable) and not is_suite:
AttributeError: module 'collections' has no attribute 'Callable'

Expected behavior
Tests are launched (and ideally pass).
Environment (please complete the following information):

pyGSTi version <IP_ADDRESS>
python version 3.10
macOS 13.3

I imagine this nose issue has been on your radar for a while. Let me know if you'd like me to port things to pytest!

We've actually migrated a lot of our testing framework to use pytest already. If you look in .github/workflows, you'll see that both main.yml and extras.yml use pytest on the test/unit and test/test_packages directories (which are our main directories containing tests we run regularly).
That said, there are probably several places in the other test directories where nose is still being called. If you wanted to strip all those references out and replace it with pytest instead, that would be great! Relatively low priority since our GitHub workflows do work for 3.10, but also shouldn't be a big lift either.

Closed with release of 0.9.12.


Broken or Flaky test: AuthenticationTokenSecretManagerTest

Test name(s)

AuthenticationTokenSecretManagerTest.testVerifyPassword

Describe the failure observed
There seems to be some small probability that the AuthenticationTokenSecretManager will generate the same random password. I've seen the following error a few times, but it's hard to reproduce. Since it's calling into Hadoop code to generate things, this could depend on specific Hadoop versions.
[ERROR] Tests run: 10, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 11.485 s <<< FAILURE! - in org.apache.accumulo.server.security.delegation.AuthenticationTokenSecretManagerTest
[ERROR] org.apache.accumulo.server.security.delegation.AuthenticationTokenSecretManagerTest.testVerifyPassword  Time elapsed: 0.003 s  <<< FAILURE!
org.opentest4j.AssertionFailedError: Different tokens for the same user shouldn't have the same password ==> expected: <false> but was: <true>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)
	at org.junit.jupiter.api.AssertFalse.failNotFalse(AssertFalse.java:63)
	at org.junit.jupiter.api.AssertFalse.assertFalse(AssertFalse.java:36)
	at org.junit.jupiter.api.Assertions.assertFalse(Assertions.java:236)
	at org.apache.accumulo.server.security.delegation.AuthenticationTokenSecretManagerTest.testVerifyPassword(AuthenticationTokenSecretManagerTest.java:222)

Additional context
If I remember correctly, this code is part of the delegation token management stuff that is used with Kerberos-enabled clusters so that MapReduce and other similar tasks don't need a keytab for each individual job task. Most recently, I saw this on 3.0.0-SNAPSHOT in the main branch, but I've previously seen it in development on earlier branches as well.

I took a look at this and ran the test in a loop in my IDE until it failed and it fails pretty fast after a few attempts.
The root cause is that the identifiers are the same between the two generated tokens. This is due to the fact that the issue date is part of the ID and is used for equality and it's set using System.currentTimeMillis() as shown below.
https://github.com/apache/accumulo/blob/b5701423330c8a55e50e8409d2492735149d70e0/server/base/src/main/java/org/apache/accumulo/server/security/delegation/AuthenticationTokenSecretManager.java#L81-L84
This means that if the test runs fast enough and System.currentTimeMillis() returns the same time then the generated ID is the same and the test fails. A simple fix for the test itself is just sleeping 1 millisecond before generating the next token to guarantee a different timestamp and I'll do a quick PR for that.
However, a follow on question/issue is whether or not this behavior is ok and if we want to update the Token id to be more random in some way so that this collision doesn't happen.
I added some logging to illustrate the issue.
Here are IDs from a successful run where the issueDate timestamps are different values:
<EMAIL_ADDRESS>keyId:1, issueDate:1669849979940, expirationDate:1669850039940, instanceId:6c7a4bc6-f7e6-45c2-be8a-4870d2e59fb5)
<EMAIL_ADDRESS>keyId:1, issueDate:1669849979950, expirationDate:1669850039950, instanceId:6c7a4bc6-f7e6-45c2-be8a-4870d2e59fb5)
And here is a failed run where the issueDate timestamps are the same value:
<EMAIL_ADDRESS>keyId:1, issueDate:1669849979983, expirationDate:1669850039983, instanceId:e77af232-3d4b-4bf6-941a-5cfd7f3b25d5)
<EMAIL_ADDRESS>keyId:1, issueDate:1669849979983, expirationDate:1669850039983, instanceId:e77af232-3d4b-4bf6-941a-5cfd7f3b25d5)

Depending on the timer precision 1 millisecond may not be enough to guarantee the timestamp changes - it will depend on the underlying clock and currentTimeMillis() likely does not use nano seconds (that's why its faster)
The sleep "may" work because of the additional overhead - but using a larger value (say > 65 millis) may force it to always be a new timestamp.  The 65 millis sticks in my head as being the worst case precision of a windows timer, but that may not be accurate anymore, or it was a different value.  But there is a precision difference between the reported milliseconds and the underlying clock so 1 millisecond may not guarantee a different value.

Fair enough, I'll just bump it to 100 millis to play it safe, the test runs very fast so it isn't going to be a big deal.

Yea - sorry. Using 100 millis is the tl/dr read version ;-)


agenda__next button function

hello,
i have too many events and i want to load when user click next or prev button. how can i handle that ? do you have any function?

onDateRangeChange this prop is a callback that fires when you use the next and previous buttons , it will trigger with two paramaters : start date , end date , you can use it to load your events on that period.
Hope it helps


Operation request: Fletcher-32 and -64 checksums

Request summary
Development of operations to calculate Fletcher-32 and Fletcher-64 checksums. CyberChef already supports Fletcher-16 (example and code).
Example input and output
Fletcher-32
Input: Test
Output: 03d901a0
Fletcher-64
Input: Test
Output: Currently unavailable
Resources
https://en.wikipedia.org/wiki/Fletcher%27s_checksum

@n1474335
Is there a reason for doing the operations byte-wise, even with 32-bit sums in Fletcher64? Reading the Wikipedia page, it seems as if operations should work on the data as 32-bit chunks, but the original paper from Fletcher doesn't address sizes greater than Fletcher16.
For example, Fletcher64('AAAABBBB') as 0xc4c4c4c483838383 rather than 0x92e0000020c.


Utilize code interpreter to take in datasets

I have not tried this out, but this is based on this video of the code interpreter plugin for chatGPT.
The idea here is that typing datasets into a chat prompt is tedious. Perhaps we should pass an uploaded data file to code interpreter and then specify a response format suitable for reCharts API.

This is not a publicly available plugin. Only for people on the list for now.


build custom model error

Thanks for your work.
I have an error.When I run "finetune_local_global_attn_depth16_region_size2510_with_diff_target_164.sh", an error apperance,it seems the model name error. The dataset is DFEW,some config has edited. Can you support some solutions?
Traceback (most recent call last):
File "D:\PyCharm 2019.3.3\plugins\python\helpers\pydev\pydevd.py", line 1434, in _exec
pydev_imports.execfile(file, globals, locals)  # execute the script
File "D:\PyCharm 2019.3.3\plugins\python\helpers\pydev_pydev_imps_pydev_execfile.py", line 18, in execfile
exec(compile(contents+"\n", file, 'exec'), glob, loc)
File "E:/code/ME/MAE-DFER-master/run_class_finetuning.py", line 679, in
main(opts, ds_init)
File "E:/code/ME/MAE-DFER-master/run_class_finetuning.py", line 332, in main
model = create_model(
File "D:\anaconda\envs\Pytorch_GPU\lib\site-packages\timm\models\factory.py", line 78, in create_model
raise RuntimeError('Unknown model (%s)' % model_name)
RuntimeError: Unknown model (vit_base_dim512_no_depth_patch16_224)

Hi, thanks for your interest in our work!
The reason is that 'vit_base_dim512_no_depth_patch16_224' is not defined in model_finetuning.py. Due to the limited computational resources, we can only pre-train the model at the size of 160x160 instead of 224x224.
---- Replied Message ----
| From | @.> |
| Date | 11/09/2023 17:34 |
| To | @.> |
| Cc | @.***> |
| Subject | [sunlicai/MAE-DFER] build custom model error (Issue #3) |
Thanks for your work.
I have an error.When I run "finetune_local_global_attn_depth16_region_size2510_with_diff_target_164.sh", an error apperance,it seems the model name error. The dataset is DFEW,some config has edited. Can you support some solutions?
Traceback (most recent call last):
File "D:\PyCharm 2019.3.3\plugins\python\helpers\pydev\pydevd.py", line 1434, in _exec
pydev_imports.execfile(file, globals, locals) # execute the script
File "D:\PyCharm 2019.3.3\plugins\python\helpers\pydev_pydev_imps_pydev_execfile.py", line 18, in execfile
exec(compile(contents+"\n", file, 'exec'), glob, loc)
File "E:/code/ME/MAE-DFER-master/run_class_finetuning.py", line 679, in
main(opts, ds_init)
File "E:/code/ME/MAE-DFER-master/run_class_finetuning.py", line 332, in main
model = create_model(
File "D:\anaconda\envs\Pytorch_GPU\lib\site-packages\timm\models\factory.py", line 78, in create_model
raise RuntimeError('Unknown model (%s)' % model_name)
RuntimeError: Unknown model (vit_base_dim512_no_depth_patch16_224)
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: @.***>

Hello, there is another issue now. The following error was reported during back propagation during training. Can you provide some help?
Traceback (most recent call last):
File "E:/code/ME/MAE-DFER-master/run_class_finetuning.py", line 680, in
main(opts, ds_init)
File "E:/code/ME/MAE-DFER-master/run_class_finetuning.py", line 583, in main
train_stats = train_one_epoch(
File "E:\code\ME\MAE-DFER-master\engine_for_finetuning.py", line 93, in train_one_epoch
grad_norm = loss_scaler(loss, optimizer, clip_grad=max_norm,
File "E:\code\ME\MAE-DFER-master\utils.py", line 349, in call
self.scaler.scale(loss).backward(create_graph=create_graph)
File "D:\anaconda\envs\Pytorch_GPU\lib\site-packages\torch_tensor.py", line 307, in backward
torch.autograd.backward(self, gradient, retain_graph, create_graph, inputs=inputs)
File "D:\anaconda\envs\Pytorch_GPU\lib\site-packages\torch\autograd_init.py", line 154, in backward
Variable._execution_engine.run_backward(
RuntimeError: one of the variables needed for gradient computation has been modified by an inplace operation: [torch.cuda.FloatTensor [2, 8, 512]], which is output 0 of AsStridedBackward0, is at version 2; expected version 0 instead. Hint: the backtrace further above shows the operation that failed to compute its gradient. The variable in question was changed in there or anywhere later. Good luck!

Sorry, I never met this issue before. Did you use the required version of python packages (e.g., pytorch1.7.1) shown in Installation?BTW, did you change the code?

I met this error too,and i solved it correctly. Here I will give out my solution, and maybe that will help you.
The key reason is that the tensor is 'updated' is is computed twice, so you are required to clone it before backward operation.
The error happened in model_finetuning.py -> LGBlock -> near line 290,310, under 'if not self.no_second:' and 'if not self.no_third:' .
You can use: 'messenger_tokens = x[:,0].clone()'  and 'local_tokens = x[:,1:].clone() ' to replace the original code:'messenger_tokens = x[:,0]' and 'local_tokens = x[:,1:].clone()'. By doing this, you can keep the tensor only be operated once during bacaward operation.
Good Luck!

Thanks very much for your kindful solution! @Huangzhw0221


Revert to Submariner 0.17.0-rc0

The main branch is used for 2.10 development; for the time being, 2.10 is supposed to use Submariner 0.17, so revert to that.

/approve


Feature Request: New Policy to enforce a set Liveness and/or Readiness Probe

Is your feature request related to a problem?
No, Just a suggestion for a new Policy.
Solution you'd like
It would be useful for us for a policy that enforces a non-empty Liveness and/or Readiness probe for each pod. In an effort to enforce 'best practices', Enforcing this for our devs would force health endpoints and better health reporting from engineers monitoring the environments.
Possibly a minimal config like this?
liveness:
  enforce: true
readiness:
  enforce: true

I could see this going as far as to enforce periodSeconds with a default minimun or limit. "For better response times, we limit Liveness probes to 30s", is an example use case / purpose for this.
Alternatives you've considered
No response
Anything else?
No response

I am aware of a community rust policy that implements this: https://github.com/nlamirault/probes-policy
We contacted the author in the past, the policy seems ready, and the steps for publishing it into artifacthub.io seem almost done. From the looks of it, the policy is missing an artifacthub id in artifacthub-repo.yml that can be provided by the author when signed into artifacthub.io.
Another option is to provide a fork maintained by the Kubewarden team.

Another option is to provide a fork maintained by the Kubewarden team.

I think we should go that way given the maintainer doesn't seem to be actively maintaining it


docker/run fails

 lars  ~/D/C/datatracker   feat/bs5  docker  bash -x ./run
+ docker-compose -f docker-compose.yml -f docker-compose.extend.yml up -d
[+] Running 0/1
 ⠿ db Error                                                                                0.5s
Error response from daemon: Head "https://ghcr.io/v2/ietf-tools/datatracker-db/manifests/latest": denied: denied
+ docker-compose exec app /bin/sh /docker-init.sh
service "app" is not running container #1
+ docker-compose down
[+] Running 1/0
 ⠿ docker  Warning: No resource found to remove                                                                          0.0s

Any idea?

 I also tried from a remote machine and the image pulled just fine...
I also get unauthorized when opening the link you posted, so I'm not sure why it's trying to fetch that in your case.

Are you able to pull the image manually?

No.
# docker pull ghcr.io/ietf-tools/datatracker-db:latest
Error response from daemon: Head "https://ghcr.io/v2/ietf-tools/datatracker-db/manifests/latest": denied: denied

Ah, it works when I do docker login -u larseggert -p $GITHUB_API_TOKEN ghcr.io.
It's odd that I wasn't logged in already, since I use ghcr.io a lot. Anyway, this should probably go into a README and then I'll close?

That shouldn't be required though, the image is public and doesn't require authentication. I was able to pull it from a server that never logged in to ghcr.io before...

I don't know. All I know is that it worked After docker login.

Just confirmed it works fine on a brand new ubuntu droplet:

So it must be some weird configuration issue on your machine...?

I don't know. Let's close it, and I will reopen if I can reliably reproduce.


Improve performance of environment clear and delete operation (#6381)

Pull request opened by the merge tool on behalf of #6381

Merged into branches iso6 in dd29462312e0508bfbfa1b9c4229ca353800685e


Landing event not getting body name and sometimes gets correct coords.

When landing (ATM I have only tested it on COL 285 SECTOR ZP-G A40-0 9 A,  A land-able moon) and about 40-50% of the time it gives the right coords. the other times it says I am at 0,0.  It never says the body name.  I will dig into the issue.
CURRENT EDDI VERSION : 2.3.1

Update: found similar issue with the touchdown event.
the coords are not always retrieving.

The original developer has stepped away from maintaining EDDI after version 2.3.0. For EDDI versions 2.3.1 & later, please report issues at https://github.com/EDCD/EDDI/issues. We've taken over maintenance of this project and maintain 2.3.1 & later on a different branch (at the address noted above). Please open a new issue at that location and if possible please include answers to the questions below:

In the cases that you are describing, are you describing touchdown events where you are flying the ship as well as ship-controlled touchdowns while you are in an SRV? Per the journal manual, longitude & latitude are given only of the player is flying the ship.
Are you using the default touchdown script from 2.3.1 or has it been modified in some way?

Thanks!

No problem. I didn't know about the transfer.  why didn't he just transfer the existing repo to you?

He'd stepped away and we were unable to reach him, so we forked the project and began working on our own fork.


Ruby to Crystal transformation tool?

I am not sure to what level this is possible and what the benefit would be.
Because ruby is so dynamic there are some structures and patterns that I do not think could be migrated to Crystal.  Also,  I don't know if this tool existed I don't know what the value would be.  For example if you could migrate the rails project to crystal would that be better then just making a web application framework in Crystal.
I guess the best place to start is what project do you want to migrate to Crystal?

There is ruby2crystal from @faustinoaq. I haven't tested it.
This issue isn't related to the Crystal programming language itself, but an external tool. A better place would be https://github.com/crystal-community/crystal-libraries-needed

Please use https://forum.crystal-lang.org for asking questions.


update helm chart version before re-releasing

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 53.09%. Comparing base (3391cce) to head (8f03fc9).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1233   +/-   ##
=======================================
  Coverage   53.08%   53.09%
=======================================
  Files         137      137
  Lines       11465    11465
=======================================
+ Hits         6086     6087    +1
  Misses       4980     4980
+ Partials      399      398    -1

Flag
Coverage Δ

unittests
53.09% <ø> (+<0.01%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Omit certain types of toasts

Is there a way in toast.promise(...) to only show the success / error toasts and not the loading toast? The current ways I see are to either set the duration to 0 or auto dismiss, which actually renders it for a second before it goes away. Can I configure it to just not show the loading toast in some scenarios?

I'd be happy to make a PR for this -- I've looked at the code, and although it's not a complicated change, I'm torn about how to approach it.  @timolins if you want to give me some feedback about which approach is preferred from your perspective (and more likely to be approved/merged), I'll go ahead and open a PR.
Approach 1: omit undefined messages
Right now, the type definitions require that in a call to toast.promise(msgs), all 3 toast-type properties (loading, success, and error) must be present in msgs, and can be null but not undefined.  So, it seems reasonable to make a change so that if the message value for a given toast type is undefined (or is a function that returns an undefined value), that toast type would be omitted from display.
For instance, an invocation might look like: toast.promise({success: 'Yay!', error: 'Oops!'}).
My only hesitation here is that some users may not be using TypeScript types, or might be (knowingly or not) passing in undefined values anyway.  In this case, currently they would get the same result as passing a message value of null: an appropriately-styled toast, including the icon, but no text.  So although technically undefined is not currently an allowed value for a message, in some real-world edge cases this could be a breaking change.
Approach 2: add an option for disabling certain toast types
An option could be added (e.g. disabled) which can cause a certain toast type to be omitted when called from a toast.promise().
For instance, an invocation might look like: toast.promise({success: 'Yay!', error: 'Oops!'}, {loading: {disabled: true}}).
As part of this change, it would be necessary to change the type definitions so undefined is explicitly an allowed message value.  This usage is also more verbose and less convenient than the first approach.  However it more thoroughly guards against breaking existing edge-case behavior.

Love this library! And just bumped into a use case for this, where I'd only want to show something in case of an error, when defining the toast for a promise (and silently load and succeed otherwise).
This still looks like it it would be an helpful feature.
I'd suggest approach 1 from @zacronos, except undefined should never be explicitly set by users. Secondly we don't want users to accidentally forget to define success, error or loading states.
Therefore I think using explicit null for omitting the toast type would be most appropriate.

Therefore I think using explicit null for omitting the toast type would be most appropriate.

The drawback to that approach is that null is already an allowed value, with a very specific result: an appropriately-styled toast, including the icon, but no text.  This is no doubt a value currently in use by many applications.
Changing the result of passing in an explicit null from that to omitting the toast altogether would be a breaking change for those applications, and so would require a major version bump.  So, although I would agree with you if this were a discussion about a new library without an existing user base, for practical reasons I don't think changing the intent of explicit null in this way would work.

To be honest, what's the point of having an empty toast message? Do we really expect many people to use it?
Either way, we could keep that behaviour by passing an empty string instead of null. I believe it would be more semantically correct (no point to render an element for the text if there is an empty string anyway) and worth the major bump.
The upgrade steps would simply be "replacing null with ''". We could even automate the process if you indeed expect many people to be affected.

Have a usecase for omitting the "success" message, as well:

user signs a transaction (pending toast, potential error message but no success message),
we wait for the transaction to happen (pending toast, success and error messages possible).

It's just awkward to confirm (with a success message) that the user has just confirmed (with a signature).

@numpde good to know! Would replacing null with '' work in your case?

@numpde good to know! Would replacing null with '' work in your case?

Not sure I understand. I'd expect this kind of construct
const tx = await toast.promise(
    contractCall,
    {
        loading: "Waiting for signature...",
        error: "Signature rejected.",
    }
);

to not show anything on success. It seems logical that an empty string should correspond to an empty toast (although it currently looks a bit asymmetrical). I have no opinion on null.

@numpde Ah I assumed by "no success message" you meant just the toast with no text. My bad.
Looking numpde's example, indeed it could make sense to just omit the whole toast when nothing is passed (undefined), making the properties passed to toast.promise optional, with a minimum of one.
The biggest worry I have is signature for more complex cases. Let's maybe look at them side by side.
This is what the signature would become between the two, these are all the cases I could come up with:
Simple case (no difference)
// undefined
const result = await toast.promise(myFn, { success: 'worked', /* rest */ })

// null
const result = await toast.promise(myFn, { success: 'worked', /* rest */ })

Inlined condition (more idiomatic with null)
// undefined
const result = await toast.promise(myFn, { success: () => { if (condition) return 'worked' }, /* rest */ })

// null
const result = await toast.promise(myFn, { success: condition ? 'worked' : null, /* rest */ })

Passing as variable based on condition (no major difference, slightly more flexibility with null)
// undefined
let success;
if (condition) success = 'worked'
const result = await toast.promise(myFn, { success, /* rest */ })

// null
const success = condition ? 'worked' : null
const result = await toast.promise(myFn, { success, /* rest */ })

Always omitting success (explicit vs not explicit)
// undefined
const result = await toast.promise(myFn, {
  loading: 'loading message',
  error: (err) => `error message: ${err}`,
})

// null
const result = await toast.promise(myFn, {
  loading: 'loading message',
  success: null,
  error: (err) => `error message: ${err}`,
})

Omitting error with predefined other messages (again explicit vs not explicit)
// undefined
const success = 'worked'
const loading = 'loading'
const result = await toast.promise(myFn, { loading, success })

// null
const success = 'worked'
const loading = 'loading'
const result = await toast.promise(myFn, { loading, success, error: null })

Personally I'd go with null because of its slightly cleaner and more explicit signature, but I guess we could maybe vote?
🚀 = I prefer undefined signature
❤ = I prefer null signature

No offense intended @webbertakken, but you are expressing some opinions as facts.
There's no reason undefined shouldn't be explicit.  If you're willing to consider that it is acceptable for a user to explicitly pass undefined for the sake of being explicit, then my suggested approach 1) can use the same signature format that you're advocating for with null.  For instance,
const result = await toast.promise(myFn, { success: condition ? 'worked' : undefined, /* rest */ })

Explicit is not always cleaner.  If someone wants to show a toast only on error (for something that should otherwise be invisible to the user), I think this:
const result = await toast.promise(myFn, { error: 'Something bad happened!' })

is cleaner than:
const result = await toast.promise(myFn, { loading: null, success: null, error: 'Something bad happened!' })

In the end, "clean" is often an opinion.  But consider this more extreme example: when passing a config object, if there are 30 possible options, would you suggest it is cleaner to pass null explicitly for 29 options, in order to indicate the default value should be used for all except the 1 option you want to set?
Using undefined explicitly to indicate lack of toast has the advantage of more explicit code as you want, but also allows the simpler and cleaner omission syntax, and most importantly this represents an extension to the existing typescript signatures rather than a backward-incompatible change to them -- and so is possible without a major version bump.
I actually do agree with you that, if this were a new or v0.x project, it would be worth changing to use '' for lack of message and null for lack of toast (though I still think there's value in allowing omission as well).  But, in my experience, frequent version bumps are painful enough for users that it is worth avoiding them when possible.  It all boils down to what the project maintainer thinks and wants to prioritize -- if they even think this feature is worth supporting.

Thanks for your input @zacronos. Please note that the examples and the poll are merely intended to move the discussion forward (and potentially create a PR) to help make the maintainers life a bit easier.

Explicit is not always cleaner. If someone wants to show a toast only on error (for something that should otherwise be invisible to the user), I think this:
const result = await toast.promise(myFn, { error: 'Something bad happened!' })

is cleaner than:
const result = await toast.promise(myFn, { loading: null, success: null, error: 'Something bad happened!' })

Fair point! Personally I have no preference between the two for this specific signature, in this case where the options object of the programmatic api only has 3 potential properties. I'd say, both have pros and cons.
About expressing opinions as facts:

There's no reason undefined shouldn't be explicit.

While this is technically true, semantically it makes a real difference. null adds information about the implementers intention. Using the difference correctly makes for better quality software. Let me try to explain:
Consider wanting to pass an object that conforms to Partial<Options>.
By omission, it simply works:
const options = { loading: 'loading' }
console.log(Object.hasOwnProperty('success')) // false

By explicitly passing undefined we see behaviour that not every developer realises:
const options = { loading: 'loading', success: undefined }
console.log(Object.hasOwnProperty('success')) // true

This also means the type Option will have to account for string | null | undefined or Options has to use Option | undefined. That doesn't yet include the function signature. The combination of everything trickles down to a fair bit of additional code when done correctly. I've also seen the key: undefined case left unnoticed and unhandled quite a few times by newer developers.
Of course you can replace null types with undefined and implement undefined checks instead of null checks, but in that case you lose information. This might be fine in many cases but it's also a slippery slope. Therefor I would regard manually passing undefined generally as bad practice.
I agree it's ultimately up to the maintainer to decide. And I also think that the vote is useful to give an indication from the community as more brains catch more cases. Your vote would be greatly appreciated as well.


Add reset signal to FlipFlop

Motivation
It would be nice to use FlipFlop with a reset signal (optionally synchronous or asynchronous)
Desired solution
Add optional named parameter(s) to FlipFlop that, when specified, add reset behavior.
Alternatives considered
People can already achieve this using the Sequential block, but FlipFlop is convenient.

i can do this

While we're at it, we should really make d and clk private in FlipFlop


Some guys are on the list twice

https://commits.top/worldwide.html

cheshire137
yegor256

This should be fixed now


⚠ Portainer-HEL has degraded performance

In 2c584f3, Portainer-HEL ($URL_PORTAINER_FI) experienced degraded performance:

HTTP code: 200
Response time: 6258 ms

Resolved: Portainer-HEL performance has improved in 76365ef.


Prevent class name collisions in proto builders

This PR resolves #84
Unfortunately when the proto builder generator is configured with the option  unwrap_builders = true, and java_multiple_files = true and any message within the file has a nested message, a class name collisions occurs.
There isnt much that can be done to fix it without breaking existing user generated code. The best option to resolve the issue is to not use the unwrap builders option and fallback to a static import of the generated builder wrapper object.
The changes introduced in this PR are meant to catch these specific conditions and prevent the generation of invalid code.
Configuration docs have been updated. Warnings are also outputted in the comments of the generated code to let users know when unwrap_builders has been deliberately ignored.

Codecov Report

Merging #88 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #88   +/-   ##
=========================================
  Coverage     85.29%   85.29%
  Complexity       19       19
=========================================
  Files            15       15
  Lines           306      306
  Branches         49       49
=========================================
  Hits            261      261
  Misses           16       16
  Partials         29       29

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7fef300...335c2e3. Read the comment docs.


HasSubstructMatch fails unexpectedly

Description:

RDKit Version: 2019.03.2
Platform: Mac, Python 3.7.3, Anaconda install

I would expect this code snippet to print True and not False
parent = Chem.MolFromSmiles('O=C(c1n[nH]c2ccccc12)N1C2COCC1C2')
child = Chem.MolFromSmiles('O=CN1C2COCC1C2')
print(parent.HasSubstructMatch(child))

False

This is the structure:

Replacing the parent with the following SMILES gives the expected True, so I assume it has to do with the bicyclic ring system and with a ring connected to the carbonyl
parent = Chem.MolFromSmiles('O=C(c1n[nH]c2ccccc12)N1CCOCC1')
parent = Chem.MolFromSmiles('O=C(CCCCCCCC)N1C2COCC1C2')

Other cases that return False:
parent = Chem.MolFromSmiles('O=C(C1CCCCCCC1)N1C2COCC1C2')
parent = Chem.MolFromSmiles('O=C(c1ccccc1)N1C2COCC1C2')

Interestingly, the smarts version matches.
>>> sma_child = Chem.MolFromSmarts('O=CN1C2COCC1C2')
>>> print(parent.HasSubstructMatch(sma_child))
True

Here's a further simplification of the example:
In [31]: child2 = Chem.MolFromSmiles('N1C2COCC1C2')

In [32]: parent2 = Chem.MolFromSmiles('C1CC1CN1C2COCC1C2')

In [33]: parent2.HasSubstructMatch(child2)
Out[33]: False

In [34]: parent2 = Chem.MolFromSmiles('CCCCN1C2COCC1C2')

In [35]: parent2.HasSubstructMatch(child2)
Out[35]: True

Hi, this is likely because when SMILES parses strings, it treats them almost as if complete string literals, looking for bond and ring closure identifiers. In the example in question, it will encounter the cyclopropyl group at "1", close it at "1", and thereafter expect a "2" to read. However, there is another ring, also labeled "1", and instead of closing that one, it opens "2". Hence, SMILES fails here.
However, SMARTS does not have this problem. It opens and closes rings sequentially & correctly. It is generally advisable to use SMARTS for functional group/fragment recognition.

That's not really an accurate description of the way the RDKit parsers work. I haven't tracked this bug down yet, but I think it's unlikely to be due to problems with the SMILES parser

That's not really an accurate description of the way the RDKit parsers work. I haven't tracked this bug down yet, but I think it's unlikely to be due to problems with the SMILES parser

Oops. My bad. Just trying to look for problems, I know FROWNS parsed SMILES in a fashion somewhat like this, just might have thought that was the cause for the issue. Don't listen to me! :d


Use session to send request

Current dependencies on/for this PR:

main:

PR #54

PR #57 👈

This comment was autogenerated by Freephite.


Hide help menu from top bar

When a lovelace dashboard has 2 tabs that you want to be able to access you can currently hide just the sidebar.
This is nice but leaves the help / menu in the top right visible, it would be nice if there was an option to hide this as well.
Note that when in kiosk mode it almost never makes sense to show this, so one could argue that this should always be hidden if the sidebar is hidden.

+1

If you want, I think you could use card-mod themes for this.

As KTibow mentions this is possible with card-mod and this feels unrelated to kiosk-mode.

I disagree.. Card mod is for modding cards. Of course you can misuse it for global css but that's not what it is for.
Cardmod can also be used to hide the sidebar, the reasoning that if it can be done by another mod it shouldn't be in this one is faulty.
This is about kiosk mode, in kiosk mode you want to limit certain interactions by hiding elements. The sidebar is one of them, as is the help button..

I want to avoid the mistakes that were made with Custom Header, I don't want this to become another feature bloated monstrosity. If I add the ability to hide elements beyond the sidebar and header this is no longer about kiosk mode (hiding header and sidebar for real estate) and will continue to receive feature requests to hide other elements as well, then that will lead to conditional hiding of elements, and before you know it I'm making Custom Header again.
Also, if something can already be done simply with another mod, it's still a good idea to avoid feature overlap between projects. I will consider this, but for the reasons mentioned above, I will avoid doing anything similar in the future.

Card mod theme to hide the overflow menu
  card-mod-root-yaml: |
      ha-button-menu {
        display: none;
      }


TokenMismatchException in VerifyCsrfToken.php line 53

I feel as though I run into this EVERYTIME.
I've set up laravel-cors per the instructions. When issuing a POST command I'm getting the following error from the server:
TokenMismatchException in VerifyCsrfToken.php line 53

Stack:
in VerifyCsrfToken.php line 53
at VerifyCsrfToken->handle(object(Request), object(Closure))
at call_user_func_array(array(object(VerifyCsrfToken), 'handle'), array(object(Request), object(Closure))) in Pipeline.php line 124
at Pipeline->Illuminate\Pipeline\{closure}(object(Request)) in ShareErrorsFromSession.php line 54
at ShareErrorsFromSession->handle(object(Request), object(Closure))
at call_user_func_array(array(object(ShareErrorsFromSession), 'handle'), array(object(Request), object(Closure))) in Pipeline.php line 124
at Pipeline->Illuminate\Pipeline\{closure}(object(Request)) in StartSession.php line 62
at StartSession->handle(object(Request), object(Closure))
at call_user_func_array(array(object(StartSession), 'handle'), array(object(Request), object(Closure))) in Pipeline.php line 124
at Pipeline->Illuminate\Pipeline\{closure}(object(Request)) in AddQueuedCookiesToResponse.php line 37
at AddQueuedCookiesToResponse->handle(object(Request), object(Closure))
at call_user_func_array(array(object(AddQueuedCookiesToResponse), 'handle'), array(object(Request), object(Closure))) in Pipeline.php line 124
at Pipeline->Illuminate\Pipeline\{closure}(object(Request)) in EncryptCookies.php line 59
at EncryptCookies->handle(object(Request), object(Closure))
at call_user_func_array(array(object(EncryptCookies), 'handle'), array(object(Request), object(Closure))) in Pipeline.php line 124
at Pipeline->Illuminate\Pipeline\{closure}(object(Request)) in CheckForMaintenanceMode.php line 42
at CheckForMaintenanceMode->handle(object(Request), object(Closure))
at call_user_func_array(array(object(CheckForMaintenanceMode), 'handle'), array(object(Request), object(Closure))) in Pipeline.php line 124
at Pipeline->Illuminate\Pipeline\{closure}(object(Request))
at call_user_func(object(Closure), object(Request)) in Pipeline.php line 103
at Pipeline->then(object(Closure)) in Kernel.php line 122
at Kernel->sendRequestThroughRouter(object(Request)) in Kernel.php line 87
at Kernel->handle(object(Request)) in index.php line 53

My routes.php:
Route::group(['prefix'=> 'api/v1', 'after' => 'allowOrigin', 'middleware'=>'cors'], function() {
    Route::resource('programs', 'ProgramController');
    Route::resource('programEvents', 'ProgramEventController');
    Route::resource('recruitingEvents', 'RecruitingEventController');
    Route::resource('subscriptions', 'SubscriptionController');
});

My config/cors.php file:
return [
    /*
     |--------------------------------------------------------------------------
     | Laravel CORS
     |--------------------------------------------------------------------------
     |

     | allowedOrigins, allowedHeaders and allowedMethods can be set to array('*')
     | to accept any value, the allowed methods however have to be explicitly listed.
     |
     */
    'supportsCredentials' => false,
    'allowedOrigins' => ['*'],
    'allowedHeaders' => ['*'],
    'allowedMethods' => ['GET', 'POST', 'PUT',  'DELETE'],
    'exposedHeaders' => [],
    'maxAge' => 0,
    'hosts' => [],
];

My request's headers:
POST /api/v1/subscriptions HTTP/1.1
Host: recruiter-sync-server-api
Connection: keep-alive
Content-Length: 72
Accept: application/json, text/javascript, */*; q=0.01
Origin: http://localhost:4200
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_10_5) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/44.0.2403.157 Safari/537.36
Content-Type: application/json; charset=UTF-8
Referer: http://localhost:4200/
Accept-Encoding: gzip, deflate
Accept-Language: en-US,en;q=0.8

What am I missing?

Did you disable csrf protection?

I may be understanding CSRF protection then, wouldn't I want to keep it for everything or is it unnecessary for an API?

Depends, I think your API is usually stateless and/or protected with authentication, not just a session.
But if you do want to use it, you should get the token by calling the API and use that token in post requests.

So do a GET request to the API for the token, have the server return it, store it on the client, send that as a header for all future requests?

I guess, but if you use an API token we something, you wouldn't need it I think.

Ok. I'll disable CSRF then. Thanks for the response. Closing.


Migrate version detection to ChromiumDash

Description
Changes version detection from Omaha to ChromiumDash
Motivation and Context
OmahaProxy has been deprecated, it now returns the message below.
This small change moves version detection to the new service.
*** Service Permanently Offline ***

OmahaProxy has been turned down.
Please migrate to <https://chromiumdash.appspot.com>.

How Has this Been Tested?
Run AU locally, the version is correctly extracted.
Screenshot (if appropriate, usually isn't needed):
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Migrated package (a package has been migrated from another repository)

Checklist:

[ ] My code follows the code style of this repository.
[ ] My change requires a change to documentation (this usually means the notes in the description of a package).
[ ] I have updated the documentation accordingly (this usually means the notes in the description of a package).
[ ] I have updated the package description and it is less than 4000 characters.
[ ] All files are up to date with the latest Contributing Guidelines
[ ] The added/modified package passed install/uninstall in the chocolatey test environment.
[x] The changes only affect a single package (not including meta package).

:white_check_mark: Package verification completed without issues. PR is now pending human review

:white_check_mark: Package verification completed without issues. PR is now pending human review

This appears to be a duplicate of https://github.com/chocolatey-community/chocolatey-packages/pull/2369 I think

This appears to be a duplicate of #2369 I think

@asmolenski It is a duplicate of sorts, I'm who submitted the #2369 PR. I originally was submitting it to fix the fact that google was altering the download link, but I then ran into the Omaha issue and fixed that too.

As this is a duplicate of the work done in #2369, and it was decided to go with the other PR instead, I will be closing this now.
We do appreciate the interest in addressing problems with packages in this repository.


Left arrow, change and enter leads to space disappear and words glue

Bug description

Left arrow, change word and enter leads to space disappear and words glue
Steps to reproduce

Connect to a Linux machine (raspberry pi in my case)
Try any command. E.g type "cd ." and enter. The command should work fine
Then press arrow up
The same command "cd ." appears again. Then press arrow left one time. Press backspace. Press space. You should see same "cd ." except that the cursor is at "." rather than at the end of the line.
Press enter. You get
pi@raspberrypi:~ $ cd.                                       ��
-bash: cd.: command not found
That means the space between "cd" and "." has been deleted before submitting the command

Expected behavior

Press enter. You get
pi@raspberrypi:~ $ cd .

Screenshot attached

Android device

Device: Xiaomi Mi 9
OS: QQ2A.200501.001.B2
PixelExperience_Plus_cepheus-10.0-20200527-1603-OFFICIAL
ConnectBot Version: 1.9.6

Server information

OS: Raspberry pi OS Version May 2020
SSH Software and Version: OpenSSH
Pubkeys used (if applicable): Ed25519

I assume that if you move cursor to the end before putting in "\r" then it would work correctly. Maybe just adding "setCursorPosition" before "write" in the code below in the file vt320.java
    if (((keyCode == KEY_ENTER) || (keyChar == 10))
            && !control) {
      write('\r');
      if (localecho) putString("\r\n"); // bad hack
      return;
    }

    if ((keyCode == 10) && !control) {
      debug("Sending \\r");
      write('\r');
      return;
    }


Exit properly when the k8s cluster is not available.

Close https://github.com/apache-spark-on-k8s/spark/issues/225

cc @ash211

@ash211 updated.

@lins05 it looks like the latest push doesn't build on Jenkins:
[error] /home/jenkins/workspace/PR-spark-k8s-full-build/resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/kubernetes/submit/v1/LoggingPodStatusWatcher.scala:56: value scheduleWithFixedDelay is not a member of java.util.concurrent.ExecutorService
[error]       scheduler.scheduleWithFixedDelay(logRunnable, 0, interval, TimeUnit.MILLISECONDS)
[error]                 ^

http://spark-k8s-jenkins.pepperdata.org:8080/job/PR-spark-k8s-full-build/302/consoleFull#-1164448660c3852bdb-3a63-45ca-a0d4-973026729059

@ash211 Fixed. Was in a hurry yesterday and forgot to run a full compilation.


Unable to resolve type in nodeDefinitions

I'm fetching data from MySQL database, but I'm unable to resolve types of returned data by instanceof operator or by it's content (they are just pure JS objects, they don't have any specific class). My nodeDefinitions looks something like that:
let {nodeInterface, nodeField} = nodeDefinitions(
  (globalId) => {
    let {type, id} = fromGlobalId(globalId)
    return db.findOne(type, id)
  },
  (obj) => {
    // can't resolve type of obj
  }
)

What is the prefered way to solve this problem? So far I invented just this, but it's ugly because it change returned object:
let {nodeInterface, nodeField} = nodeDefinitions(
  (globalId) => {
    let {type, id} = fromGlobalId(globalId)
    return Object.assign({_type: type}, db.findOne(type, id))
  },
  (obj) => {
    if(obj._type === 'User') {
      return userType
    } else if(obj._type === 'Article') {
      return articleType
    }
    // ... and so on
  }
)

Can you think of any better solution? Thank you.

Yeah, this is tricky. An option might be
let {nodeInterface, nodeField} = nodeDefinitions(
  (globalId) => {
    let {type, id} = fromGlobalId(globalId)
    return Object.assign({globalId}, db.findOne(type, id))
  },
  (obj) => {
    let {type} = fromGlobalId(obj.globalId);
    if(type === 'User') {
      return userType
    } else if(type === 'Article') {
      return articleType
    }
    // ... and so on
  }
)

and then you can just have the id field on these objects return globalId. But the larger problem is that anytime you have a field that returns Node (or any other interface), GraphQL needs to be able to map from the resolved value to the concrete type. So I could see having a helper method:
function dbFindOneWithType(type, id) {
   return Object.assign({_type: type}, db.findOne(type, id))
}

and then use that in place of db.findOne for all fetches, so that the objects are always tagged with their types.
Let me know if this helps, or if there are API changes that you think would make this easier!

Feel free to re-open if you're still having issues.


important code error: losses["loss"].detach()  in train_util.py line 246

please check the losses variable
        if isinstance(self.schedule_sampler, LossAwareSampler):
            self.schedule_sampler.update_with_local_losses(
                t, losses["loss"].detach()
            )
        losses = losses1[0]
        sample = losses1[1]

I met the same situation. Do you know how to solve it now?

waiting for the author to reply...

you can simply put line 248 in front of it. actually this block will not be run in the current version

losses["loss"].detach()  ---> losses1[0].detach() ?


Only encode uniswap approval when needed

to save gas. This is coupled with a change to the Interaction trait to make the encoding function async. An alternative to this is to move this work into the constructor of the interaction itself or add another function to the trait like prepare_interaction. I don't like the latter because you would always call it before encode anyway and could make the internal state of the interaction more complicated. Doing it in the constructor has the advantage that the self encode stays simpler but it makes it more complicated to create an interaction in the first place.
For the uniswap interaction specifically we could later add a cache to remember that we have already given approval.
Test Plan
e2e test

encourage to do all potentially long running computation beforehand
How can we do this when don't know what tokens will be in the solution beforehand? The only way I see is to check this for all tokens that we have orders for (and update the list for new orders) and then pass that info to the uniswap interaction.

Yes, basically my thinking was we could do it at the same time when we query the reserve sizes (which also needs to happen optimistically for all possible pairs). At that point we can also remember that in case we want to use a given pool, it might need to be approved first.

I see. I agree we should do it at that point if we have to do perform such an action anyway.


Change Broker Allocation Algorithm

https://fabric-testbed.atlassian.net/browse/FIP-714
Change Broker Allocation Algorithm to spread resources across available hosts more evenly as opposed to first fit.

OOM issue has been resolved by reserving 24GB of RAM for the host and allocating rest to CF for allocation: https://fabric-testbed.atlassian.net/jira/servicedesk/projects/FIP/queues/custom/44/FIP-1405
Following change is requested for Allocation to avoid users from exhausting all shared NICs on a specific host.
Maybe we should have something like: Choose the first host in the list where the VM fits and the host has at least X% of the cores/ram/disk/shared_nics available, unless all the hosts have less than X% of the cores/ram/disk/shared_nics available.  If all the hosts have less than X% of the cores/ram/disk/shared_nics available, then choose a random host that has enough resources.


Updated documentary for users

Hi there, this feels very much like a PR to get a hacktoberfest t-shirt. It's been marked invalid.
If you're interested in contributing to Mycroft please take a look at one of the many issues tagged hacktoberfest or help wanted


texteditor module not compiling withi PyInstaller

I can compile a simple program (see below) which calls the texteditor module succesfully.  but upon launching the executable I get the error shown although the source runs with no issues before compile.
`#!/usr/bin/python3
import texteditor
text = texteditor.open(filename = 'readme.md')`
When running the executable on my windows 10 machine the below errors are displayed:
Traceback (most recent call last):
File "texted.py", line 3, in
File "", line 1007, in _find_and_load
File "", line 986, in _find_and_load_unlocked
File "", line 680, in load_unlocked
File "c:\users\cvsch\appdata\local\programs\python\python39\lib\site-packages\PyInstaller\loader\pyimod03_importers.py", line 493, in exec_module
exec(bytecode, module.dict)
File "texteditor_init.py", line 2, in
File "", line 1007, in _find_and_load
File "", line 986, in find_and_load_unlocked
File "", line 680, in load_unlocked
File "c:\users\cvsch\appdata\local\programs\python\python39\lib\site-packages\PyInstaller\loader\pyimod03_importers.py", line 493, in exec_module
exec(bytecode, module.dict)
File "texteditor\version.py", line 4, in
File "pkg_resources_init.py", line 899, in require
File "pkg_resources_init.py", line 785, in resolve
pkg_resources.DistributionNotFound: The 'text-editor' distribution was not found and is required by the application
[21060] Failed to execute script texted
a 'pip list' does show the required package is installed.
C:\Users\cvsch\Documents\pyqtprojects\oog4b201018-2200\dist\texted>pip list
Package                   Version

altgraph                  0.17
beautifulsoup4            4.9.3
bs4                       0.0.1
desktop-file              1.2
future                    0.18.2
iso8601                   0.1.13
pefile                    2019.4.18
pip                       20.2.4
py2exe                    <IP_ADDRESS>
pyinstaller               4.0
pyinstaller-hooks-contrib 2020.9
pypiwin32                 223
PyQt5                     5.15.1
PyQt5-sip                 12.8.1
PyQt5Designer             5.14.1
pyserial                  3.4
pywin32                   228
pywin32-ctypes            0.2.0
PyYAML                    5.3.1
serial                    0.0.97
setuptools                49.2.1
soupsieve                 2.0.1
text-editor               1.0.5

"text-editor" (with an hyphen) was an old, temporary name of the package. The name is now "texteditor" (without the hyphen).
Please update your requirements to use the "texteditor" instead https://pypi.org/project/texteditor/
I will remove the old package from pypi to avoid further confusion.


Only check python package requirements if requirements.txt exists.

Most users download PKB in its entirety, including requirements.txt, so
the default behavior will still be to verify package versions.

LGTM