old/new swapped in nix-build --check?

I re-built something that cache.nixos.org had built on Ubuntu without sandbox, and got this:
% git rev-parse HEAD
8c74f97c15d09cac2012a17e680dcf8086f0ee5e

% NIX_PATH=nixpkgs=. nix-build -A grass
these paths will be fetched (46.39 MiB download, 116.57 MiB unpacked):
  /nix/store/h825l674yxg4gb5ly88bjxy1gjqibx4v-grass
copying path '/nix/store/h825l674yxg4gb5ly88bjxy1gjqibx4v-grass' from 'https://cache.nixos.org'...
/nix/store/h825l674yxg4gb5ly88bjxy1gjqibx4v-grass

% NIX_PATH=nixpkgs=. nix-build -A grass --check
checking outputs of '/nix/store/2jwsj8x6wv8wszywc24q0i978ir6nv2b-grass.drv'...
unpacking sources
unpacking source archive /nix/store/lyqnfxnilhwq4hbn3h01zg3mang5bqx0-source
...
strip is /nix/store/ydk00ssq4fyx78rpmdmq1hcmz0iw575f-binutils-2.31.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/h825l674yxg4gb5ly88bjxy1gjqibx4v-grass/lib  /nix/store/h825l674yxg4gb5ly88bjxy1gjqibx4v-grass/bin
patching script interpreter paths in /nix/store/h825l674yxg4gb5ly88bjxy1gjqibx4v-grass
/nix/store/h825l674yxg4gb5ly88bjxy1gjqibx4v-grass/grass76/tools/mkhtml.py: interpreter directive changed from "/usr/bin/env python" to "/nix/store/l7qqqls96q6x7wgvii6p0chin5ni74yz-python-2.7.18/bin/python"
/nix/store/h825l674yxg4gb5ly88bjxy1gjqibx4v-grass/grass76/gui/scripts/d.rast3d: interpreter directive changed from "/usr/bin/env python" to "/nix/store/l7qqqls96q6x7wgvii6p0chin5ni74yz-python-2.7.18/bin/python"
/nix/store/h825l674yxg4gb5ly88bjxy1gjqibx4v-grass/grass76/gui/scripts/d.wms: interpreter directive changed from "/usr/bin/env python" to "/nix/store/l7qqqls96q6x7wgvii6p0chin5ni74yz-python-2.7.18/bin/python"
/nix/store/h825l674yxg4gb5ly88bjxy1gjqibx4v-grass/grass76/config.status: interpreter directive changed from " /bin/sh" to "/nix/store/ypag3bh7y7i15xf24zihr343wi6x5i6g-bash-4.4-p23/bin/sh"
/nix/store/h825l674yxg4gb5ly88bjxy1gjqibx4v-grass/bin/.grass76-wrapped: interpreter directive changed from "/usr/bin/env python" to "/nix/store/l7qqqls96q6x7wgvii6p0chin5ni74yz-python-2.7.18/bin/python"
checking for references to /build/ in /nix/store/h825l674yxg4gb5ly88bjxy1gjqibx4v-grass...
derivation '/nix/store/2jwsj8x6wv8wszywc24q0i978ir6nv2b-grass.drv' may not be deterministic: output '/nix/store/h825l674yxg4gb5ly88bjxy1gjqibx4v-grass' differs
error: build of '/nix/store/2jwsj8x6wv8wszywc24q0i978ir6nv2b-grass.drv' failed

Note here it says:
interpreter directive changed from "/usr/bin/env python" to "/nix/store/l7qqqls96q6x7wgvii6p0chin5ni74yz-python-2.7.18/bin/python"

That looks like it's the wrong way around, shouldn't it have changed from [proper store path] to /usr/bin/env python?

The code that prints this is this:
https://github.com/NixOS/nixpkgs/blob/a8efeed583652738414e3d93bb724ee9c05e70b6/pkgs/build-support/setup-hooks/patch-shebangs.sh#L91

As far as I understand it, the current message is alright -  all packages in /nix/store depend primarily on other packages from /nix/store too, without relying on global state like /usr/bin/env or /lib.
That is: the original, source file had /usr/bin/env python and the new, Nix-built file has /nix/store/fancy-hash/bin/python - so the message seems fine; why do you think it should be the other way around? :-)

You are right, I confused myself here.
I thought the interpreter directive changed was part of some --check diffing logic, but it's just the normal thing patchShebangs does.


Add CLI reporter

Description
Adds a CLI reporter for output to chef log(similar to old Audit phase report)

Check List

[ ] All tests pass. See https://github.com/chef-cookbooks/community_cookbook_documentation/blob/master/TESTING.MD
[ ] New functionality includes testing.
[ ] New functionality has been documented in the README if applicable
[ ] All commits have been signed for the Developer Certificate of Origin. See https://github.com/chef-cookbooks/community_cookbook_documentation/blob/master/CONTRIBUTING.MD

@aknarts Thanks for taking the time to put this PR together, but we've actually integrated the code from the audit cookbook directly into Chef Infra Client as part of a new Compliance Phase. The codebase is mostly identical to this cookbook so you could probably just add this there. The goal is to deprecate this cookbook so that users can just run compliance scans on their nodes without an additional dependency.

@aknarts Thanks for taking the time to put this PR together, but we've actually integrated the code from the audit cookbook directly into Chef Infra Client as part of a new Compliance Phase. The codebase is mostly identical to this cookbook so you could probably just add this there. The goal is to deprecate this cookbook so that users can just run compliance scans on their nodes without an additional dependency.

@aknarts Thanks for taking the time to put this PR together, but we've actually integrated the code from the audit cookbook directly into Chef Infra Client as part of a new Compliance Phase.

I was not aware of this. I am in the process of migrating to the latest Chef Infra Client(16), what version is this supposed to be in/are there any docs for it?

@aknarts Thanks for taking the time to put this PR together, but we've actually integrated the code from the audit cookbook directly into Chef Infra Client as part of a new Compliance Phase.

I was not aware of this. I am in the process of migrating to the latest Chef Infra Client(16), what version is this supposed to be in/are there any docs for it?


Realtime chess

Can't you use solid'/Notification or solid'/websocket first to use realtime, and if the opponent is not connected send to mailbox ?

I use notifications to synchronise the boards. It does have a delay of 5 seconds, because the interval between two checks of the inbox for new notifications is set to 5 seconds.
You could set up a websocket connection between two running applications, but you will need to let others know that a user is online (which you could do via notifications again). The question is, however, if in this case the increased number of notifications, as people switch between games often maybe, is justified.
In the case you would be dealing with like an FPS, RTS, MMO, then yes websockets would be better I think, considering that there is a lot more data shared among the players.


question about the training result

Hello~ I wonder the performance of the final models would be similar or different  when I train the network from scratch each time.  Have you ever evaluated this issue?
Thanks.

Hello, what exactly do you mean by "each time"? On a different dataset? Or are you just asking about reproducibility on the dataset we trained with?

Hello, what exactly do you mean by "each time"? On a different dataset? Or are you just asking about reproducibility on the dataset we trained with?

I mean the reproducibility with the same dataset.

Ok, is your question not covered by the relevant section of readme? In short, yes, it should be easily reproducible up to 0.50432 stereo AUC and 0.72624 multiview AUC on IMW2020 test set and up to the paper results with the slightly more involved schedule explained in that paragraph. Are you seeing different results on your end?

Ok, is your question not covered by the relevant section of readme? In short, yes, it should be easily reproducible up to 0.50432 stereo AUC and 0.72624 multiview AUC on IMW2020 test set and up to the paper results with the slightly more involved schedule explained in that paragraph. Are you seeing different results on your end?

In fact I just began to train the model and haven't performed evaluation. Due to the nature of sampling, the variances of all metrics (for example ”n_keypoints“, "n_pairs" during the training stage) are very large. So I am curious whether the performance among each trained model would vary.
Thanks for your response! I would track this issue if different results were saw on my end.

Yes, the variance of the training metrics is very large indeed, but we found the validation numbers (averaged across the entire set) to be quite reliable. Please reopen if you find any major discrepancies :)


[cpprestsdk] Update to v2.10.15.

Need to test features.

After merging #10116, issues related to uwp will be resolved.

/azp run

Thanks @BillyONeal !


Decomposition tests are being skipped

Upstream changes to the dispatcher caused infinite recursion for decompositions. Once the fix is in upstream, we'll need to unskip these and reinstate the fbcode skip (currently commented out)

Closed with 020efbc


Made Image Responsive

Made the image responsive by adding image fluid in the class
Closes #309

@SauravMukherjee44 could this be merged?


Please change the code in the example.

In line 45 of your code example, it should be changed to Token::Start(kind) => match kind.as_str() {. The change is from match *kind to kind.as_str().

New version of synoptic, and an updated example.


Db prefix should be used for the subjects DB too

This PR fixes the env var:
DB_WHISK_AUTHS from subjects to local_subjects

I'm merging this PR on the basis of the Travis build in order to bring master back to a stable state.


Fix capture when no properties are set

If no properties are set on the outgoing event, the code fails with Cannot convert undefined or null to object.
Fix this by substituting an empty object if undefined.

Works fine


Certs not found when starting EG

Description:
Cert Job runs after deploying deployment of EG, when starting EG, the secret is not existed.

Kustomize is used to manage the manifests and handles the ordering of resources. Even if the cert-gen Job is created before the EG deployment, there is no startup ordering guarantee. As long as the cert-gen Job completes successfully and EG starts, IMHO this is not a bug.
xref: https://github.com/envoyproxy/gateway/issues/479


Update README.md (making command simpler for newbies)

Why not list both? I think ./pokemon-showdown has some support issues on some OS.

ye it fucks with windows
tho perfect with ubuntu and bash on windows.....
also we also use /updateserver which has the same prob as this windows isnt compatible

bash on windows

Also, people shouldn't really be running a server on Windows

ye exactly right @panpawn if its that then this PR should be merged 2

node app.js is simple enough


CT QueryStringMachine is not defined

scenery : pageload : /doc/a-tour-of-scenery.html
https://bayes.colorado.edu/continuous-testing/ct-snapshots/1645601952560/scenery/doc/a-tour-of-scenery.html
Uncaught ReferenceError: QueryStringMachine is not defined
ReferenceError: QueryStringMachine is not defined
at https://bayes.colorado.edu/continuous-testing/ct-snapshots/1645601952560/scenery/build/scenery.min.js:1:660199
at https://bayes.colorado.edu/continuous-testing/ct-snapshots/1645601952560/scenery/build/scenery.min.js:1:1044409
at https://bayes.colorado.edu/continuous-testing/ct-snapshots/1645601952560/scenery/build/scenery.min.js:1:1044413
at https://bayes.colorado.edu/continuous-testing/ct-snapshots/1645601952560/scenery/build/scenery.min.js:1:1044416
id: Bayes Chrome
Snapshot from 2/23/2022, 12:39:12 AM

----------------------------------

scenery : pageload : /doc/accessibility/accessibility.html
https://bayes.colorado.edu/continuous-testing/ct-snapshots/1645601952560/scenery/doc/accessibility/accessibility.html
Uncaught ReferenceError: QueryStringMachine is not defined
ReferenceError: QueryStringMachine is not defined
at https://bayes.colorado.edu/continuous-testing/ct-snapshots/1645601952560/scenery/build/scenery.min.js:1:660199
at https://bayes.colorado.edu/continuous-testing/ct-snapshots/1645601952560/scenery/build/scenery.min.js:1:1044409
at https://bayes.colorado.edu/continuous-testing/ct-snapshots/1645601952560/scenery/build/scenery.min.js:1:1044413
at https://bayes.colorado.edu/continuous-testing/ct-snapshots/1645601952560/scenery/build/scenery.min.js:1:1044416
id: Bayes Chrome
Snapshot from 2/23/2022, 12:39:12 AM

----------------------------------

scenery : pageload : /doc/implementation-notes.html
https://bayes.colorado.edu/continuous-testing/ct-snapshots/1645601952560/scenery/doc/implementation-notes.html
Uncaught ReferenceError: QueryStringMachine is not defined
ReferenceError: QueryStringMachine is not defined
at https://bayes.colorado.edu/continuous-testing/ct-snapshots/1645601952560/scenery/build/scenery.min.js:1:660199
at https://bayes.colorado.edu/continuous-testing/ct-snapshots/1645601952560/scenery/build/scenery.min.js:1:1044409
at https://bayes.colorado.edu/continuous-testing/ct-snapshots/1645601952560/scenery/build/scenery.min.js:1:1044413
at https://bayes.colorado.edu/continuous-testing/ct-snapshots/1645601952560/scenery/build/scenery.min.js:1:1044416
id: Bayes Chrome
Snapshot from 2/23/2022, 12:39:12 AM

----------------------------------

scenery : pageload : /doc/user-input.html
https://bayes.colorado.edu/continuous-testing/ct-snapshots/1645601952560/scenery/doc/user-input.html
Uncaught ReferenceError: QueryStringMachine is not defined
ReferenceError: QueryStringMachine is not defined
at https://bayes.colorado.edu/continuous-testing/ct-snapshots/1645601952560/scenery/build/scenery.min.js:1:660199
at https://bayes.colorado.edu/continuous-testing/ct-snapshots/1645601952560/scenery/build/scenery.min.js:1:1044409
at https://bayes.colorado.edu/continuous-testing/ct-snapshots/1645601952560/scenery/build/scenery.min.js:1:1044413
at https://bayes.colorado.edu/continuous-testing/ct-snapshots/1645601952560/scenery/build/scenery.min.js:1:1044416
id: Bayes Chrome
Snapshot from 2/23/2022, 12:39:12 AM

----------------------------------

scenery : pageload : /examples/cursors.html
https://bayes.colorado.edu/continuous-testing/ct-snapshots/1645601952560/scenery/examples/cursors.html
Uncaught ReferenceError: QueryStringMachine is not defined
ReferenceError: QueryStringMachine is not defined
at https://bayes.colorado.edu/continuous-testing/ct-snapshots/1645601952560/scenery/build/scenery.min.js:1:660199
at https://bayes.colorado.edu/continuous-testing/ct-snapshots/1645601952560/scenery/build/scenery.min.js:1:1044409
at https://bayes.colorado.edu/continuous-testing/ct-snapshots/1645601952560/scenery/build/scenery.min.js:1:1044413
at https://bayes.colorado.edu/continuous-testing/ct-snapshots/1645601952560/scenery/build/scenery.min.js:1:1044416
id: Bayes Chrome
Snapshot from 2/23/2022, 12:39:12 AM

----------------------------------

scenery : pageload : /examples/hello-world.html
https://bayes.colorado.edu/continuous-testing/ct-snapshots/1645601952560/scenery/examples/hello-world.html
Uncaught ReferenceError: QueryStringMachine is not defined
ReferenceError: QueryStringMachine is not defined
at https://bayes.colorado.edu/continuous-testing/ct-snapshots/1645601952560/scenery/build/scenery.min.js:1:660199
at https://bayes.colorado.edu/continuous-testing/ct-snapshots/1645601952560/scenery/build/scenery.min.js:1:1044409
at https://bayes.colorado.edu/continuous-testing/ct-snapshots/1645601952560/scenery/build/scenery.min.js:1:1044413
at https://bayes.colorado.edu/continuous-testing/ct-snapshots/1645601952560/scenery/build/scenery.min.js:1:1044416
id: Bayes Chrome
Snapshot from 2/23/2022, 12:39:12 AM

----------------------------------

scenery : pageload : /examples/input.html
https://bayes.colorado.edu/continuous-testing/ct-snapshots/1645601952560/scenery/examples/input.html
Uncaught ReferenceError: QueryStringMachine is not defined
ReferenceError: QueryStringMachine is not defined
at https://bayes.colorado.edu/continuous-testing/ct-snapshots/1645601952560/scenery/build/scenery.min.js:1:660199
at https://bayes.colorado.edu/continuous-testing/ct-snapshots/1645601952560/scenery/build/scenery.min.js:1:1044409
at https://bayes.colorado.edu/continuous-testing/ct-snapshots/1645601952560/scenery/build/scenery.min.js:1:1044413
at https://bayes.colorado.edu/continuous-testing/ct-snapshots/1645601952560/scenery/build/scenery.min.js:1:1044416
id: Bayes Chrome
Snapshot from 2/23/2022, 12:39:12 AM

----------------------------------

scenery : pageload : /examples/mouse-wheel.html
https://bayes.colorado.edu/continuous-testing/ct-snapshots/1645601952560/scenery/examples/mouse-wheel.html
Uncaught ReferenceError: QueryStringMachine is not defined
ReferenceError: QueryStringMachine is not defined
at https://bayes.colorado.edu/continuous-testing/ct-snapshots/1645601952560/scenery/build/scenery.min.js:1:660199
at https://bayes.colorado.edu/continuous-testing/ct-snapshots/1645601952560/scenery/build/scenery.min.js:1:1044409
at https://bayes.colorado.edu/continuous-testing/ct-snapshots/1645601952560/scenery/build/scenery.min.js:1:1044413
at https://bayes.colorado.edu/continuous-testing/ct-snapshots/1645601952560/scenery/build/scenery.min.js:1:1044416
id: Bayes Chrome
Snapshot from 2/23/2022, 12:39:12 AM

----------------------------------

scenery : pageload : /examples/multi-touch.html
https://bayes.colorado.edu/continuous-testing/ct-snapshots/1645601952560/scenery/examples/multi-touch.html
Uncaught ReferenceError: QueryStringMachine is not defined
ReferenceError: QueryStringMachine is not defined
at https://bayes.colorado.edu/continuous-testing/ct-snapshots/1645601952560/scenery/build/scenery.min.js:1:660199
at https://bayes.colorado.edu/continuous-testing/ct-snapshots/1645601952560/scenery/build/scenery.min.js:1:1044409
at https://bayes.colorado.edu/continuous-testing/ct-snapshots/1645601952560/scenery/build/scenery.min.js:1:1044413
at https://bayes.colorado.edu/continuous-testing/ct-snapshots/1645601952560/scenery/build/scenery.min.js:1:1044416
id: Bayes Chrome
Snapshot from 2/23/2022, 12:39:12 AM

----------------------------------

scenery : pageload : /examples/nodes.html
https://bayes.colorado.edu/continuous-testing/ct-snapshots/1645601952560/scenery/examples/nodes.html
Uncaught ReferenceError: QueryStringMachine is not defined
ReferenceError: QueryStringMachine is not defined
at https://bayes.colorado.edu/continuous-testing/ct-snapshots/1645601952560/scenery/build/scenery.min.js:1:660199
at https://bayes.colorado.edu/continuous-testing/ct-snapshots/1645601952560/scenery/build/scenery.min.js:1:1044409
at https://bayes.colorado.edu/continuous-testing/ct-snapshots/1645601952560/scenery/build/scenery.min.js:1:1044413
at https://bayes.colorado.edu/continuous-testing/ct-snapshots/1645601952560/scenery/build/scenery.min.js:1:1044416
id: Bayes Chrome
Snapshot from 2/23/2022, 12:39:12 AM

----------------------------------

scenery : pageload : /examples/shapes.html
https://bayes.colorado.edu/continuous-testing/ct-snapshots/1645601952560/scenery/examples/shapes.html
Uncaught ReferenceError: QueryStringMachine is not defined
ReferenceError: QueryStringMachine is not defined
at https://bayes.colorado.edu/continuous-testing/ct-snapshots/1645601952560/scenery/build/scenery.min.js:1:660199
at https://bayes.colorado.edu/continuous-testing/ct-snapshots/1645601952560/scenery/build/scenery.min.js:1:1044409
at https://bayes.colorado.edu/continuous-testing/ct-snapshots/1645601952560/scenery/build/scenery.min.js:1:1044413
at https://bayes.colorado.edu/continuous-testing/ct-snapshots/1645601952560/scenery/build/scenery.min.js:1:1044416
id: Bayes Chrome
Snapshot from 2/23/2022, 12:39:12 AM

----------------------------------

scenery : pageload : /examples/sprites.html
https://bayes.colorado.edu/continuous-testing/ct-snapshots/1645601952560/scenery/examples/sprites.html
Uncaught ReferenceError: QueryStringMachine is not defined
ReferenceError: QueryStringMachine is not defined
at https://bayes.colorado.edu/continuous-testing/ct-snapshots/1645601952560/scenery/build/scenery.min.js:1:660199
at https://bayes.colorado.edu/continuous-testing/ct-snapshots/1645601952560/scenery/build/scenery.min.js:1:1044409
at https://bayes.colorado.edu/continuous-testing/ct-snapshots/1645601952560/scenery/build/scenery.min.js:1:1044413
at https://bayes.colorado.edu/continuous-testing/ct-snapshots/1645601952560/scenery/build/scenery.min.js:1:1044416
id: Bayes Chrome
Snapshot from 2/23/2022, 12:39:12 AM

----------------------------------

scenery : pageload : /tests/text-bounds-comparison.html
https://bayes.colorado.edu/continuous-testing/ct-snapshots/1645601952560/scenery/tests/text-bounds-comparison.html
Uncaught ReferenceError: QueryStringMachine is not defined
ReferenceError: QueryStringMachine is not defined
at https://bayes.colorado.edu/continuous-testing/ct-snapshots/1645601952560/scenery/build/scenery.min.js:1:660199
at https://bayes.colorado.edu/continuous-testing/ct-snapshots/1645601952560/scenery/build/scenery.min.js:1:1044409
at https://bayes.colorado.edu/continuous-testing/ct-snapshots/1645601952560/scenery/build/scenery.min.js:1:1044413
at https://bayes.colorado.edu/continuous-testing/ct-snapshots/1645601952560/scenery/build/scenery.min.js:1:1044416
id: Bayes Chrome
Snapshot from 2/23/2022, 12:39:12 AM

I am not sure why QueryStringMachine is not available for usage when utterance-queue is built for scenery. QueryStringMachine was added as a preload for utterance-queue and it is working in usages with sims in build and unbuilt versions. It is added like himalaya, another preload of utterance-queue. But himalaya probably isn't an issue for scenery because himalaya is already used by scenery.

QueryStringMachine has been removed from utterance-queue and updated accordingly. Scenery docs are loading with an updated build off of master for me. Closing.

@arouinfar pointed out that this change didn't work because of my check for phet, we need to check window.phet before we can look for globals. Fixed above.


fix: upgrade to version 3.0.708

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign cagiti
You can assign the PR to them by writing /assign @cagiti in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jenkins-x-bot-test: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

kube
97b311a5da9331eab9504554bdff153340f0a953
link
/test kube

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

@jenkins-x-bot-test: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

kube
97b311a5da9331eab9504554bdff153340f0a953
link
/test kube

vault
97b311a5da9331eab9504554bdff153340f0a953
link
/test vault

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

@jenkins-x-bot-test: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

kube
97b311a5da9331eab9504554bdff153340f0a953
link
/test kube

vault
97b311a5da9331eab9504554bdff153340f0a953
link
/test vault

gsm
97b311a5da9331eab9504554bdff153340f0a953
link
/test gsm

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

@jenkins-x-bot-test: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

kube
97b311a5da9331eab9504554bdff153340f0a953
link
/test kube

gsm
97b311a5da9331eab9504554bdff153340f0a953
link
/test gsm

vault
1196e330e67f17ab4f961d4ceb80905ac67cdfab
link
/test vault

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

@jenkins-x-bot-test: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

gsm
97b311a5da9331eab9504554bdff153340f0a953
link
/test gsm

vault
1196e330e67f17ab4f961d4ceb80905ac67cdfab
link
/test vault

kube
1196e330e67f17ab4f961d4ceb80905ac67cdfab
link
/test kube

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

@jenkins-x-bot-test: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

vault
1196e330e67f17ab4f961d4ceb80905ac67cdfab
link
/test vault

kube
1196e330e67f17ab4f961d4ceb80905ac67cdfab
link
/test kube

gsm
1196e330e67f17ab4f961d4ceb80905ac67cdfab
link
/test gsm

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.


Moved testing.go to testing_test.go

This stops the import "testing" from bringing the testing package into anything that imports GoUtils.
This fixes a naming mistake for the testing.go file.
Tested with the existing makefile
Signed-off-by: Dan Finneran<EMAIL_ADDRESS>

Did I do the merge correctly Dan :-)?

You did, thanks for accepting that small change 👍


Overwrite value to string for keccak256field

This PR overwrite value_to_string function of keccak256field because the function of BinaryField code/decode using base64 and this not works for keccak256field.

Overwrite value to string for keccak256field

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

2 of 2 (100.0%)  changed or added relevant lines in 1 file are covered.
2 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-0.02%) to 84.205%

Files with Coverage Reduction
New Missed Lines
%

gnosis/eth/ethereum_client.py
1
81.38%

gnosis/protocol/gnosis_protocol_api.py
1
88.64%

Totals

Change from base Build<PHONE_NUMBER>:
-0.02%

Covered Lines:
3284

Relevant Lines:
3900

💛  - Coveralls


LEGO: Pull request from lego/hb_04604851-bac4-4681-9f74-73de611d6e48_20220121163511951 to main

LEGO: Pull request from lego/hb_04604851-bac4-4681-9f74-73de611d6e48_20220121163511951 to main with localized lcls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.01%) to 48.27%

Totals

Change from base Build<PHONE_NUMBER>:
0.01%

Covered Lines:
14749

Relevant Lines:
29016

💛  - Coveralls


ConsumerGroup fails to consume with MockBroker

Versions
Please specify real version numbers or git SHAs, not just "Latest" since that changes fairly regularly.

Sarama
Kafka
Go

v1.29.0
2.7.0.
1.16

Configuration
What configuration values are you using for Sarama and Kafka?
    kConfig := mocks.NewTestConfig()
    kConfig.Version = sarama.V2_7_0_0
    kConfig.Consumer.Return.Errors = true
    kConfig.ClientID = "test"
    kConfig.Consumer.Offsets.Initial = sarama.OffsetNewest

Logs
When filing an issue please provide logs from Sarama and Kafka if at all
possible. You can set sarama.Logger to a log.Logger to capture Sarama debug
output.
logs: CLICK ME

=== RUN   TestEBSConsumerReadsOneMessageAndExits
time="2021-05-27T19:27:47-07:00" level=info msg="*** mockbroker/0 listening on <IP_ADDRESS>:56820\n" func=github.com/Shopify/sarama.NewMockBrokerListener file="/Users/abhimanyu.seth/Alation/alation_event_bus/client_libraries/go/pkg/mod/github.com/!shopify/sarama@v1.29.0/mockbroker.go:404"
time="2021-05-27T19:27:47-07:00" level=info msg="Mock Broker: [<IP_ADDRESS>:56820]" func=alation_event_bus/sarama_test_test.TestEBSConsumerReadsOneMessageAndExits file="/Users/abhimanyu.seth/Alation/alation_event_bus/client_libraries/go/alation_event_bus/sarama_test/consumer_group_mock_test.go:32"
time="2021-05-27T19:27:47-07:00" level=info msg="Initializing new client" func=github.com/Shopify/sarama.NewClient file="/Users/abhimanyu.seth/Alation/alation_event_bus/client_libraries/go/pkg/mod/github.com/!shopify/sarama@v1.29.0/client.go:141"
time="2021-05-27T19:27:47-07:00" level=info msg="client/metadata fetching metadata for all topics from broker <IP_ADDRESS>:56820\n" func="github.com/Shopify/sarama.(*client).tryRefreshMetadata" file="/Users/abhimanyu.seth/Alation/alation_event_bus/client_libraries/go/pkg/mod/github.com/!shopify/sarama@v1.29.0/client.go:884"
time="2021-05-27T19:27:47-07:00" level=info msg="Connected to broker at <IP_ADDRESS>:56820 (unregistered)\n" func="github.com/Shopify/sarama.(*Broker).Open.func1" file="/Users/abhimanyu.seth/Alation/alation_event_bus/client_libraries/go/pkg/mod/github.com/!shopify/sarama@v1.29.0/broker.go:209"
time="2021-05-27T19:27:47-07:00" level=info msg="*** mockbroker/0/0: connection opened" func="github.com/Shopify/sarama.(*MockBroker).handleRequests" file="/Users/abhimanyu.seth/Alation/alation_event_bus/client_libraries/go/pkg/mod/github.com/!shopify/sarama@v1.29.0/mockbroker.go:223"
time="2021-05-27T19:27:47-07:00" level=info msg="*** mockbroker/0/0: replied to *sarama.MetadataRequest with *sarama.MetadataResponse\n-> (*sarama.MetadataRequest){Version:(int16)5 Topics:([]string)<nil> AllowAutoTopicCreation:(bool)false}\n-> (*sarama.MetadataResponse){Version:(int16)5 ThrottleTimeMs:(int32)0 Brokers:([]*sarama.Broker)[<max>] ClusterID:(*string)<nil> ControllerID:(int32)0 Topics:([]*sarama.TopicMetadata)[<max>]}" func="github.com/Shopify/sarama.(*MockBroker).handleRequests" file="/Users/abhimanyu.seth/Alation/alation_event_bus/client_libraries/go/pkg/mod/github.com/!shopify/sarama@v1.29.0/mockbroker.go:269"
time="2021-05-27T19:27:47-07:00" level=info msg="client/brokers registered new broker #0 at <IP_ADDRESS>:56820" func="github.com/Shopify/sarama.(*client).updateBroker" file="/Users/abhimanyu.seth/Alation/alation_event_bus/client_libraries/go/pkg/mod/github.com/!shopify/sarama@v1.29.0/client.go:615"
time="2021-05-27T19:27:47-07:00" level=info msg="Successfully initialized new client" func=github.com/Shopify/sarama.NewClient file="/Users/abhimanyu.seth/Alation/alation_event_bus/client_libraries/go/pkg/mod/github.com/!shopify/sarama@v1.29.0/client.go:185"
time="2021-05-27T19:27:47-07:00" level=info msg="client/metadata fetching metadata for [test.topic] from broker <IP_ADDRESS>:56820\n" func="github.com/Shopify/sarama.(*client).tryRefreshMetadata" file="/Users/abhimanyu.seth/Alation/alation_event_bus/client_libraries/go/pkg/mod/github.com/!shopify/sarama@v1.29.0/client.go:881"
time="2021-05-27T19:27:47-07:00" level=info msg="*** mockbroker/0/0: replied to *sarama.MetadataRequest with *sarama.MetadataResponse\n-> (*sarama.MetadataRequest){Version:(int16)5 Topics:([]string)[<max>] AllowAutoTopicCreation:(bool)true}\n-> (*sarama.MetadataResponse){Version:(int16)5 ThrottleTimeMs:(int32)0 Brokers:([]*sarama.Broker)[<max>] ClusterID:(*string)<nil> ControllerID:(int32)0 Topics:([]*sarama.TopicMetadata)[<max>]}" func="github.com/Shopify/sarama.(*MockBroker).handleRequests" file="/Users/abhimanyu.seth/Alation/alation_event_bus/client_libraries/go/pkg/mod/github.com/!shopify/sarama@v1.29.0/mockbroker.go:269"
time="2021-05-27T19:27:47-07:00" level=info msg="client/coordinator requesting coordinator for consumergroup tests from <IP_ADDRESS>:56820\n" func="github.com/Shopify/sarama.(*client).getConsumerMetadata" file="/Users/abhimanyu.seth/Alation/alation_event_bus/client_libraries/go/pkg/mod/github.com/!shopify/sarama@v1.29.0/client.go:1048"
time="2021-05-27T19:27:47-07:00" level=info msg="*** mockbroker/0/0: replied to *sarama.FindCoordinatorRequest with *sarama.FindCoordinatorResponse\n-> (*sarama.FindCoordinatorRequest){Version:(int16)0 CoordinatorKey:(string)tests CoordinatorType:(sarama.CoordinatorType)0}\n-> (*sarama.FindCoordinatorResponse){Version:(int16)0 ThrottleTime:(time.Duration)0s Err:(sarama.KError)kafka server: Not an error, why are you printing me? ErrMsg:(*string)<nil> Coordinator:(*sarama.Broker){<max>}}" func="github.com/Shopify/sarama.(*MockBroker).handleRequests" file="/Users/abhimanyu.seth/Alation/alation_event_bus/client_libraries/go/pkg/mod/github.com/!shopify/sarama@v1.29.0/mockbroker.go:269"
time="2021-05-27T19:27:47-07:00" level=info msg="client/coordinator coordinator for consumergroup tests is #0 (<IP_ADDRESS>:56820)\n" func="github.com/Shopify/sarama.(*client).getConsumerMetadata" file="/Users/abhimanyu.seth/Alation/alation_event_bus/client_libraries/go/pkg/mod/github.com/!shopify/sarama@v1.29.0/client.go:1070"
time="2021-05-27T19:27:47-07:00" level=info msg="*** mockbroker/0/1: connection opened" func="github.com/Shopify/sarama.(*MockBroker).handleRequests" file="/Users/abhimanyu.seth/Alation/alation_event_bus/client_libraries/go/pkg/mod/github.com/!shopify/sarama@v1.29.0/mockbroker.go:223"
time="2021-05-27T19:27:47-07:00" level=info msg="Connected to broker at <IP_ADDRESS>:56820 (registered as #0)\n" func="github.com/Shopify/sarama.(*Broker).Open.func1" file="/Users/abhimanyu.seth/Alation/alation_event_bus/client_libraries/go/pkg/mod/github.com/!shopify/sarama@v1.29.0/broker.go:207"
time="2021-05-27T19:27:47-07:00" level=info msg="*** mockbroker/0/1: replied to *sarama.JoinGroupRequest with *sarama.JoinGroupResponse\n-> (*sarama.JoinGroupRequest){Version:(int16)1 GroupId:(string)tests SessionTimeout:(int32)10000 RebalanceTimeout:(int32)60000 MemberId:(string) ProtocolType:(string)consumer GroupProtocols:(map[string][]uint8)map[<max>] OrderedGroupProtocols:([]*sarama.GroupProtocol)[<max>]}\n-> (*sarama.JoinGroupResponse){Version:(int16)1 ThrottleTime:(int32)0 Err:(sarama.KError)kafka server: Not an error, why are you printing me? GenerationId:(int32)0 GroupProtocol:(string) LeaderId:(string) MemberId:(string) Members:(map[string][]uint8)map[<max>]}" func="github.com/Shopify/sarama.(*MockBroker).handleRequests" file="/Users/abhimanyu.seth/Alation/alation_event_bus/client_libraries/go/pkg/mod/github.com/!shopify/sarama@v1.29.0/mockbroker.go:269"
time="2021-05-27T19:27:47-07:00" level=info msg="*** mockbroker/0/1: replied to *sarama.SyncGroupRequest with *sarama.SyncGroupResponse\n-> (*sarama.SyncGroupRequest){GroupId:(string)tests GenerationId:(int32)0 MemberId:(string) GroupAssignments:(map[string][]uint8)<nil>}\n-> (*sarama.SyncGroupResponse){Err:(sarama.KError)kafka server: Not an error, why are you printing me? MemberAssignment:([]uint8)[<max>]}" func="github.com/Shopify/sarama.(*MockBroker).handleRequests" file="/Users/abhimanyu.seth/Alation/alation_event_bus/client_libraries/go/pkg/mod/github.com/!shopify/sarama@v1.29.0/mockbroker.go:269"
time="2021-05-27T19:27:47-07:00" level=info msg="client/coordinator requesting coordinator for consumergroup tests from <IP_ADDRESS>:56820\n" func="github.com/Shopify/sarama.(*client).getConsumerMetadata" file="/Users/abhimanyu.seth/Alation/alation_event_bus/client_libraries/go/pkg/mod/github.com/!shopify/sarama@v1.29.0/client.go:1048"
time="2021-05-27T19:27:47-07:00" level=info msg="*** mockbroker/0/0: replied to *sarama.FindCoordinatorRequest with *sarama.FindCoordinatorResponse\n-> (*sarama.FindCoordinatorRequest){Version:(int16)0 CoordinatorKey:(string)tests CoordinatorType:(sarama.CoordinatorType)0}\n-> (*sarama.FindCoordinatorResponse){Version:(int16)0 ThrottleTime:(time.Duration)0s Err:(sarama.KError)kafka server: Not an error, why are you printing me? ErrMsg:(*string)<nil> Coordinator:(*sarama.Broker){<max>}}" func="github.com/Shopify/sarama.(*MockBroker).handleRequests" file="/Users/abhimanyu.seth/Alation/alation_event_bus/client_libraries/go/pkg/mod/github.com/!shopify/sarama@v1.29.0/mockbroker.go:269"
time="2021-05-27T19:27:47-07:00" level=info msg="*** mockbroker/0/1: replied to *sarama.HeartbeatRequest with *sarama.HeartbeatResponse\n-> (*sarama.HeartbeatRequest){GroupId:(string)tests GenerationId:(int32)0 MemberId:(string)}\n-> (*sarama.HeartbeatResponse){Err:(sarama.KError)kafka server: Not an error, why are you printing me?}" func="github.com/Shopify/sarama.(*MockBroker).handleRequests" file="/Users/abhimanyu.seth/Alation/alation_event_bus/client_libraries/go/pkg/mod/github.com/!shopify/sarama@v1.29.0/mockbroker.go:269"
time="2021-05-27T19:27:47-07:00" level=info msg="client/coordinator coordinator for consumergroup tests is #0 (<IP_ADDRESS>:56820)\n" func="github.com/Shopify/sarama.(*client).getConsumerMetadata" file="/Users/abhimanyu.seth/Alation/alation_event_bus/client_libraries/go/pkg/mod/github.com/!shopify/sarama@v1.29.0/client.go:1070"
time="2021-05-27T19:27:47-07:00" level=info msg="*** mockbroker/0/1: replied to *sarama.OffsetFetchRequest with *sarama.OffsetFetchResponse\n-> (*sarama.OffsetFetchRequest){Version:(int16)1 ConsumerGroup:(string)tests RequireStable:(bool)false partitions:(map[string][]int32)map[<max>]}\n-> (*sarama.OffsetFetchResponse){Version:(int16)1 ThrottleTimeMs:(int32)0 Blocks:(map[string]map[int32]*sarama.OffsetFetchResponseBlock)map[<max>] Err:(sarama.KError)kafka server: Not an error, why are you printing me?}" func="github.com/Shopify/sarama.(*MockBroker).handleRequests" file="/Users/abhimanyu.seth/Alation/alation_event_bus/client_libraries/go/pkg/mod/github.com/!shopify/sarama@v1.29.0/mockbroker.go:269"
time="2021-05-27T19:27:47-07:00" level=info msg="*** mockbroker/0/1: replied to *sarama.OffsetRequest with *sarama.OffsetResponse\n-> (*sarama.OffsetRequest){Version:(int16)1 IsolationLevel:(sarama.IsolationLevel)0 replicaID:(int32)0 isReplicaIDSet:(bool)false blocks:(map[string]map[int32]*sarama.offsetRequestBlock)map[<max>]}\n-> (*sarama.OffsetResponse){Version:(int16)0 ThrottleTimeMs:(int32)0 Blocks:(map[string]map[int32]*sarama.OffsetResponseBlock)map[<max>]}" func="github.com/Shopify/sarama.(*MockBroker).handleRequests" file="/Users/abhimanyu.seth/Alation/alation_event_bus/client_libraries/go/pkg/mod/github.com/!shopify/sarama@v1.29.0/mockbroker.go:269"
time="2021-05-27T19:27:47-07:00" level=info msg="Closed connection to broker <IP_ADDRESS>:56820\n" func="github.com/Shopify/sarama.(*Broker).Close" file="/Users/abhimanyu.seth/Alation/alation_event_bus/client_libraries/go/pkg/mod/github.com/!shopify/sarama@v1.29.0/broker.go:248"
time="2021-05-27T19:27:47-07:00" level=info msg="*** mockbroker/0/1: invalid request: err=EOF, ([]uint8) <nil>\n" func="github.com/Shopify/sarama.(*MockBroker).handleRequests" file="/Users/abhimanyu.seth/Alation/alation_event_bus/client_libraries/go/pkg/mod/github.com/!shopify/sarama@v1.29.0/mockbroker.go:241"
time="2021-05-27T19:27:47-07:00" level=info msg="*** mockbroker/0/1: connection closed, err=<nil>" func="github.com/Shopify/sarama.(*MockBroker).handleRequests" file="/Users/abhimanyu.seth/Alation/alation_event_bus/client_libraries/go/pkg/mod/github.com/!shopify/sarama@v1.29.0/mockbroker.go:323"
time="2021-05-27T19:27:47-07:00" level=info msg="client/metadata fetching metadata for [test.topic] from broker <IP_ADDRESS>:56820\n" func="github.com/Shopify/sarama.(*client).tryRefreshMetadata" file="/Users/abhimanyu.seth/Alation/alation_event_bus/client_libraries/go/pkg/mod/github.com/!shopify/sarama@v1.29.0/client.go:881"
time="2021-05-27T19:27:47-07:00" level=info msg="*** mockbroker/0/0: replied to *sarama.MetadataRequest with *sarama.MetadataResponse\n-> (*sarama.MetadataRequest){Version:(int16)5 Topics:([]string)[<max>] AllowAutoTopicCreation:(bool)true}\n-> (*sarama.MetadataResponse){Version:(int16)5 ThrottleTimeMs:(int32)0 Brokers:([]*sarama.Broker)[<max>] ClusterID:(*string)<nil> ControllerID:(int32)0 Topics:([]*sarama.TopicMetadata)[<max>]}" func="github.com/Shopify/sarama.(*MockBroker).handleRequests" file="/Users/abhimanyu.seth/Alation/alation_event_bus/client_libraries/go/pkg/mod/github.com/!shopify/sarama@v1.29.0/mockbroker.go:269"
time="2021-05-27T19:27:47-07:00" level=info msg="*** mockbroker/0/2: connection opened" func="github.com/Shopify/sarama.(*MockBroker).handleRequests" file="/Users/abhimanyu.seth/Alation/alation_event_bus/client_libraries/go/pkg/mod/github.com/!shopify/sarama@v1.29.0/mockbroker.go:223"
time="2021-05-27T19:27:47-07:00" level=info msg="Connected to broker at <IP_ADDRESS>:56820 (registered as #0)\n" func="github.com/Shopify/sarama.(*Broker).Open.func1" file="/Users/abhimanyu.seth/Alation/alation_event_bus/client_libraries/go/pkg/mod/github.com/!shopify/sarama@v1.29.0/broker.go:207"
time="2021-05-27T19:27:47-07:00" level=info msg="*** mockbroker/0/2: replied to *sarama.OffsetRequest with *sarama.OffsetResponse\n-> (*sarama.OffsetRequest){Version:(int16)1 IsolationLevel:(sarama.IsolationLevel)0 replicaID:(int32)0 isReplicaIDSet:(bool)false blocks:(map[string]map[int32]*sarama.offsetRequestBlock)map[<max>]}\n-> (*sarama.OffsetResponse){Version:(int16)0 ThrottleTimeMs:(int32)0 Blocks:(map[string]map[int32]*sarama.OffsetResponseBlock)map[<max>]}" func="github.com/Shopify/sarama.(*MockBroker).handleRequests" file="/Users/abhimanyu.seth/Alation/alation_event_bus/client_libraries/go/pkg/mod/github.com/!shopify/sarama@v1.29.0/mockbroker.go:269"
time="2021-05-27T19:27:47-07:00" level=info msg="Closed connection to broker <IP_ADDRESS>:56820\n" func="github.com/Shopify/sarama.(*Broker).Close" file="/Users/abhimanyu.seth/Alation/alation_event_bus/client_libraries/go/pkg/mod/github.com/!shopify/sarama@v1.29.0/broker.go:248"
time="2021-05-27T19:27:47-07:00" level=info msg="*** mockbroker/0/2: invalid request: err=EOF, ([]uint8) <nil>\n" func="github.com/Shopify/sarama.(*MockBroker).handleRequests" file="/Users/abhimanyu.seth/Alation/alation_event_bus/client_libraries/go/pkg/mod/github.com/!shopify/sarama@v1.29.0/mockbroker.go:241"
time="2021-05-27T19:27:47-07:00" level=info msg="*** mockbroker/0/2: connection closed, err=<nil>" func="github.com/Shopify/sarama.(*MockBroker).handleRequests" file="/Users/abhimanyu.seth/Alation/alation_event_bus/client_libraries/go/pkg/mod/github.com/!shopify/sarama@v1.29.0/mockbroker.go:323"
time="2021-05-27T19:27:47-07:00" level=info msg="Consumer run completed" func=alation_event_bus/sarama_test_test.runConsumerGroup file="/Users/abhimanyu.seth/Alation/alation_event_bus/client_libraries/go/alation_event_bus/sarama_test/consumer_group_mock_test.go:66"
time="2021-05-27T19:27:47-07:00" level=info msg="loop check partition number coroutine will exit, topics [test.topic]" func="github.com/Shopify/sarama.(*consumerGroup).loopCheckPartitionNumbers" file="/Users/abhimanyu.seth/Alation/alation_event_bus/client_libraries/go/pkg/mod/github.com/!shopify/sarama@v1.29.0/consumer_group.go:466"
    consumer_group_mock_test.go:40:
        	Error Trace:	consumer_group_mock_test.go:40
        	Error:      	Not equal:
        	            	expected: 1
        	            	actual  : 0
        	Test:       	TestEBSConsumerReadsOneMessageAndExits
time="2021-05-27T19:27:47-07:00" level=info msg="*** mockbroker/0/0: invalid request: err=read tcp <IP_ADDRESS>:56820-><IP_ADDRESS>:56821: use of closed network connection, ([]uint8) <nil>\n" func="github.com/Shopify/sarama.(*MockBroker).handleRequests" file="/Users/abhimanyu.seth/Alation/alation_event_bus/client_libraries/go/pkg/mod/github.com/!shopify/sarama@v1.29.0/mockbroker.go:241"
time="2021-05-27T19:27:47-07:00" level=info msg="*** mockbroker/0/0: connection closed, err=<nil>" func="github.com/Shopify/sarama.(*MockBroker).handleRequests" file="/Users/abhimanyu.seth/Alation/alation_event_bus/client_libraries/go/pkg/mod/github.com/!shopify/sarama@v1.29.0/mockbroker.go:323"
time="2021-05-27T19:27:47-07:00" level=info msg="*** mockbroker/0: listener closed, err=accept tcp <IP_ADDRESS>:56820: use of closed network connection" func="github.com/Shopify/sarama.(*MockBroker).serverLoop" file="/Users/abhimanyu.seth/Alation/alation_event_bus/client_libraries/go/pkg/mod/github.com/!shopify/sarama@v1.29.0/mockbroker.go:176"
--- FAIL: TestEBSConsumerReadsOneMessageAndExits (0.01s)

Problem Description
I'm using sarama ConsumerGroup in my project and have a consumer built on top of it. To test my consumer logic, I wanted to use a MockBroker (since I didn't see any mock for ConsumerGroup)
Based on the sarama consumer test here (which I'm able to run successfully without errors):
https://github.com/Shopify/sarama/blob/master/consumer_test.go
and a lot of debugging to set all mock responses on MockBroker, I got the following sample code to run without hanging:
https://gist.github.com/abhimanyuseth/c13ecc299dbfa200eb851cd70d45bfab
On debugging, the test fails during OffsetRequest (sarama/client.go -> getOffset()) with error "kafka: insufficient data to decode packet, more bytes expected"
From the sarama debug logs, it looks like the connection to the broker is getting closed during the OffsetRequest? I'm not sure if/what settings in MockBroker can be tweaked or if I'm missing something here.
It would be helpful if anyone can confirm if there's an issue here or if I can update some config to fix this.

@abhimanyuseth I think the issue here is that the mockbroker expects/requires you to manually set the protocol version that you want it to send as the mocked response. But your consumer group will be sending versioned requests based on your configuration (kConfig.Version = sarama.V2_7_0_0) which will be a V2 fetch request and will expect to decode a V2 fetch response. So you need to configure your mocked response to be a V2 fetch response so the decoding will succeed
i.e.,
@@ -97,7 +95,8 @@ func initMockBroker(t *testing.T, group string) *sarama.MockBroker{
 		SetError("test.topic", 0, sarama.ErrNoError)
 	mockOffsetResponse := sarama.NewMockOffsetResponse(t).
 		SetOffset("test.topic", 0, sarama.OffsetOldest, 0).
-		SetOffset("test.topic", 0, sarama.OffsetNewest, 1)
+		SetOffset("test.topic", 0, sarama.OffsetNewest, 1).
+		SetVersion(2)
 	mockFetchResponse := sarama.NewMockFetchResponse(t, 1).
 		SetMessage("test.topic", 0, 0, sarama.StringEncoder("testing 123")).
 		SetMessage("test.topic", 0, 1, sarama.StringEncoder("testing 123")).

You'd need to examine the versions of each of your mocked messages to account for this


Add ONNX & TensorRT to README.md

Hi @Parskatt, very cool work!
I created a version of DeDoDe compatible with ONNX and TensorRT. It'd be great if you could add it to your README :)

Cool!


Fix p6doc build errors

The problem
zef install p6doc fails after building.
Solution provided
After looking through zef's code, I found that it considers the build to have passed only if a truthy value is returned, so I made the build method return True.

Would checking if all the files were copied over and returning True/False depending on whether or not it succeeded be a better idea?

Something like this

Can this be merged now?

Looks good to me, addresses JJ's concern.


Do not assume CRD exists

Signed-off-by: Alexis de Talhouët<EMAIL_ADDRESS>

LGTM.  Will merge once checks complete.

@pittar Thanks - and apologies for the churn. I thought I tested this thoroughly before... but as I just setup  a new cluster, I came to notice it was missing the SkipDryRunOnMissingResource flag which prevents Argo from synching the app.

@adetalhouet  , I've started add that as a "commonAnnotation" in the kustomization file.  That way the CRDs are pretty clean, and it automatically gets applied to all the bases/resources, like this:
https://github.com/redhat-cop/gitops-catalog/blob/main/advanced-cluster-security-operator/aggregate/default/kustomization.yaml#L4
However... good both ways.  There's only 1 CR that needs it in this case, so no need to move it up to the kustomization file.

@pittar just noticed I forget it as well in ansible-automation-platform - added in this PR.

LGTM (again)


Making the last pod work on watch 2 requires moving the version tag

Hi,
Thanks for merging my change on the pod.
However there is one last thing that needs to be done so that an app wit ha watchos 2 target can work with it, which is to move the version tag 1.2.2 to the latest commit.
Thanks a lot!
Sebastian

Hi @seviu. Sorry for taking so long to respond to this. I really have no excuse other than laziness and just not paying attention to my public GitHub account.
I merged in your pull request and I will update to CocoaPods 1.0 this weekend and then update v1.2.2 of this pod to point to the latest (or maybe I'll just end up publishing v1.2.3).

v1.3.0 of FDKeychain has been published to CocoaPods and it contains support for both watchOS and tvOS.


Array.apply() false positive

Array.apply() is a native function but it's currently marked as an error

Thank you! I just pushed up a fix and will publish after CI passes.


Server issues?????

I am not sure how github works, but I have noticed your work, to download or upgrade, has been very slow lately. Like right now, I am downloading the latest muta version and it is going to take 5 hours, normal takes about 2 minutes. :(

I have not had any issues pushing or pulling to the repository. Out of curiosity I have noticed on my home network since switching providers that my router assigns an IPv6 address to my machines. When this would happen running something as simple as sudo apt update I would see in the output an IPv6 address as if it was trying to use IPv6 to download the update. After awhile it would, I am guessing, time out and switch to IPv4 which would download said update with no problem at least until the next request is made then it would stall on the IPv6 address again.
To resolve the problem I disable IPv6 DHCP in my router and had no issues since.
Example output of which I am talking about.

100MB connection would never take 4:18 minutes to do so. Notice it then again stalls after sudo apt install git was initiated and once again we see an IPv6 address...

If you could take a screen shot or paste more of the output from your device here it would help.
Possible related issue #400

all working full speed now. :)


Simplify module hierarchy

I was expecting to have several serial modifiers to the default property creators, but after discovering zipLogic, the default functions might be enough for most cases.

Separation on smallcheck-lens and tasty-lens will take care of this.


Implement binding subcommand

Fixes #60

⚠ stacked against https://github.com/vmware-tanzu/sources-for-knative/pull/67 - merge it first! ⚠


LoE and shrinking of schedules

This PR implements Limit of Eagerness and shrinking of schedules for genesis tests.
Please, note that this PR targets the branch of #840, our previous milestone.
Shrinking
Each test currently has one honest peer, and one or more adversarial peers, which are adversarial because they might serve other chains than the honest one, or they might send headers or blocks with delay.
Shrinking, then, is implemented by dropping adversarial peers or messages sent by adversarial peers. It does not attempt yet to modify the schedule of the honest peer. The shrinker is best approached from the function shrinkPeerSchedules in ouroboros-consensus-diffusion/test/consensus-test/Test/Consensus/PointSchedule/Shrinking.hs in 20eec7d. 17331dc includes some preparatory refactorings.
LoE
Limit of Eagerness is a mechanism that prevents the syncing node from selecting a chain more than k blocks long when its peers disagree on what the best chain is. In combination with a component in the works that disconnects peers with suboptimal chains (GDD governor), LoE helps the syncing node to follow the best chain.
The commit implementing LoE is in 28f4f86.
Other work
Additionally, further improvements to pretty printing of traces can be found in 11a913a, and a fix to the schema generator can be found in b942a82.
More details on the schema generator problems can be found in the documentation of ensureLowerDensityInWindows, but the essence of it is that adversarial chains could be generated that didn't lose the density comparisons with the honest chain. These chains aren't interesting then, because in practice we always expect the honest chain to win the density comparisons.

No regressions during syncing visible with the LoE (setup: local sync, no bandwidth limit, GHC 9.6.3, default RTS opts):

Rebased main after merging #840.


Zijian/change command word

change the command word for tasks

Codecov Report

Merging #208 into master will decrease coverage by 3.34%.
The diff coverage is 11.44%.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fce1c84...1897fc4. Read the comment docs.


createMintToInstruction is throwing error

I'm getting error when i'm creating 9 digit token for amount of<PHONE_NUMBER>
Here is the code sample

And here is the error.:

hi. we don't use github for support requests. please join us in #developer-support on https://solana.com/discord


Is there a better home for IContextAccessor implementation?

Should interface be assembly neutral?
Should interface live in a carrier assembly?

This is a dupe of https://github.com/aspnet/DependencyInjection/issues/186 since ContextAccessor got renamed to IScopedInstance...


pkg/logging: Fix HTTP logging middleware panic

[x] I added CHANGELOG entry for this change.
[ ] Change is not relevant to the end user.

Changes
Use net.SplitHostPort instead of strings.Split with a direct slice access, which caused panics when the Host header is not available or doesn't contain a port.
Verification
Added a unit test that without this patch paniced.
Fixes #3921
@thanos-io/thanos-maintainers

Looks great to me 💯

Enabling auto-merge when CI goes green :)


v 1.1.145 breaks postgis on M1 Mac

Describe the bug
I'm way out of my league here, but basically I use Homebrew as my package manager on my M1 Mac.  I use postgis which depends on aws-sdk-cpp.  In the most recent Homebrew update, this bumped the version from 1.1.140 -> 1.1.145, which broke my installation with a cryptic error.  I eventually tracked things down to this package which, after downgrading to 1.1.140, restored my environment.
I can not possibly help to debug the error itself; again, I'm out of my depth.  However, I am very happy to answer any questions that might potentially help diagnose the problem.
Expected Behavior
postgis to work
Current Behavior
postgis breaks
Reproduction Steps
update to 1.1.145 as dependency for postgis
Possible Solution
No response
Additional Information/Context
Current packages:
"""
√ ~ % brew list --versions
abseil 20230125.3
aom 3.6.1
apache-arrow 12.0.1_4 12.0.1_3
aws-sdk-cpp 1.11.140
boost 1.82.0_1
brotli 1.0.9
bzip2 1.0.8
c-ares 1.19.1
ca-certificates 2023-05-30
cairo 1.16.0_5
cfitsio 4.3.0
cgal 5.6
double-conversion 3.3.0
edencommon 2<IP_ADDRESS>
eigen 3.4.0_1
epsilon 0.9.2
expat 2.5.0
fb303 2<IP_ADDRESS>
fbthrift 2<IP_ADDRESS>
fizz 2<IP_ADDRESS>
fmt 10.1.0
folly 2<IP_ADDRESS>
fontconfig 2.14.2
freetype 2.13.1
freexl 2.0.0
gcc 13.1.0
gdal 3.7.1_1
geoip 1.6.12
geos 3.12.0
gettext 0.21.1
gflags 2.2.2
giflib 5.2.1
git 2.41.0_2
glib 2.76.4
glog 0.6.0
gmp 6.2.1_1
grpc 1.56.2
hdf5 1.14.1
heroku 8.3.1
highway 1.0.6
hugo 0.117.0
icu4c 73.2
imath 3.1.9
isl 0.26
jpeg-turbo 3.0.0
jpeg-xl 0.8.2
json-c 0.17
krb5 1.21.1
libaec 1.0.6
libarchive 3.7.1
libb2 0.98.1
libde265 1.0.12
libevent 2.1.12_1
libgeotiff 1.7.1_3
libheif 1.16.2
libkml 1.3.0_1
liblerc 4.0.0
libmpc 1.3.1
libnghttp2 1.55.1
libpng 1.6.40
libpq 15.4
librttopo 1.1.0
libsodium 1.0.18_1
libspatialite 5.1.0
libtiff 4.5.1
libtool 2.4.7
libuv 1.46.0
libvmaf 2.3.1
libx11 1.8.6
libxau 1.0.11
libxcb 1.15_1
libxdmcp 1.1.4
libxext 1.3.5
libxml2 2.11.5
libxrender 0.9.11
little-cms2 2.15
lz4 1.9.4
lzo 2.10
m4 1.4.19
mailhog 1.0.1
minizip 1.2.13
mpdecimal 2.5.1
mpfr 4.2.0-p12
netcdf 4.9.2_1
node 20.5.1
nspr 4.35
nss 3.92
numpy 1.25.2
openblas 0.3.23
openexr 3.1.11
openjpeg 2.5.0_1
openssl@3 3.1.2
pcre2 10.42
pipenv 2023.8.20
pixman 0.42.2
poppler 23.08.0
popt 1.19
postgis 3.3.4_1
postgresql@14 14.9
proj 9.2.1
protobuf 23.4
protobuf-c 1.4.1_4
python-certifi 2023.7.22
<EMAIL_ADDRESS>3.11.4_1
qhull 2020.2
rapidjson 1.1.0
re2 20230801
readline 8.2.1
redis 7.2.0
sfcgal 1.4.1_5
shared-mime-info 2.2
snappy 1.1.10
sqlite 3.42.0
thrift 0.18.1_1
unixodbc 2.3.12
uriparser 0.9.7
utf8proc 2.8.0
wangle 2<IP_ADDRESS>
watchman 2<IP_ADDRESS>
webp 1.3.1
x265 3.5
xerces-c 3.2.4_1
xorgproto 2023.2
xz 5.4.4
yarn 1.22.19
zstd 1.5.5
wkhtmltopdf 0.12.6-2
"""
AWS CPP SDK version used
1.1.145
Compiler and Version used
Apple clang version 14.0.3 (clang-14<IP_ADDRESS>.1) Target: arm64-apple-darwin22.6.0 Thread model: posix InstalledDir: /Library/Developer/CommandLineTools/usr/bin
Operating System and version
M1 Max, 13.5.1

Hello @dbinetti ,
Thank you very much for your submission.
First of all, Thank you very much for documenting a work around for other potential users encountering this issue.
Could you please provide more information on the error received?
Best regards,
Yasmine

I just updated brew this morning, and I think I'm seeing the same problem. The error message is:
OSError: dlopen(/opt/homebrew/lib/libgdal.dylib, 0x0006): Symbol not found: __ZN3Aws6Client19ClientConfigurationC1Ev
  Referenced from: <FA8C3295-2793-3C69-A419-16C41753696B> /opt/homebrew/Cellar/apache-arrow/12.0.1_4/lib/libarrow.1200.1.0.dylib
  Expected in:     <BDB1F1E3-0BE9-3D7D-A57E-9D9F8CAD197A> /opt/homebrew/Cellar/aws-sdk-cpp/1.11.145/lib/libaws-cpp-sdk-core.dylib

I second this, this broke for me earlier today - exact same error message.

Hello @rowanseymour ,
Thank you very much for providing the error message and thanks to all of you for reaching out.
The latest version has an ABI incompatible change.
We are working on a fix right now. I will keep you updated on here.
Thank you very much for bringing this up to our attention.
Best regards,
Yasmine

We ran into this issue:
Solution, downgrade to aws-sdk-cpp v1.11.140. Based on recommendations here for downgrading brew versions, these commands fixed our issue:
wget https://raw.githubusercontent.com/Homebrew/homebrew-core/0faa586d8415cd2ced33345aa3e13c664c92aeda/Formula/a/aws-sdk-cpp.rb -O aws-sdk-cpp.rb
brew install aws-sdk-cpp.rb

A fix has been merged, and is currently release, once done releasing it will be tagged 1.11.147

1.11.147 should now be published


Create ub.txt

Added ub

@mgazzarm First stage of verification passed, official domain is pubmed.ncbi.nlm.nih.gov as far as I verified. This is just an informational note. Pull request is still in the review. I appreciate your patience while waiting for the final decision. Proof of domain ownership: https://pubmed.ncbi.nlm.nih.gov/33024197/

@mgazzarm Thank you for your patience while waiting for a review and processing your request. Pull request merged.


shared memory segment creation failure on RHEL 7

On a Bitnami RHEL 7 VM with 1CPU, 2GB RAM I see the following when trying to run this container:
waiting for server to start....FATAL:  could not create shared memory segment: Invalid argument
DETAIL:  Failed system call was shmget(key=5432001, size=45793280, 03600).
HINT:  This error usually means that PostgreSQL's request for a shared memory segment exceeded your kernel's SHMMAX parameter.  You can either reduce the request size or reconfigure the kernel with larger SHMMAX.  To reduce the request size (currently 45793280 bytes), reduce PostgreSQL's shared memory usage, perhaps by reducing shared_buffers or max_connections.
	If the request size is already small, it's possible that it is less than your kernel's SHMMIN parameter, in which case raising the request size or reconfiguring SHMMIN is called for.
	The PostgreSQL documentation contains more information about shared memory configuration.
pg_ctl: could not start server
Examine the log output.
.... stopped waiting
$ ipcs -lm

------ Shared Memory Limits --------
max number of segments = 4096
max seg size (kbytes) = 4194303
max total shared memory (kbytes) =<PHONE_NUMBER>
min seg size (bytes) = 1

The request size is smaller than the maximum and larger than the minimum, so I think the invalid argument claim for the shmget system call may be the real issue. I attempted to run with --privileged but it didn't seem that the permissions were the issue, either. Thoughts on whether this is a postgres config issue with the container or not?

On my RHEL7 machine, I see this:
$ sysctl -a | grep shmmax
kernel.shmmax =<PHONE_NUMBER>3692774399

I'm not sure what Bitnami is, but I would check available memory and shmmax.
This has been fixed by rhbz#1056547.

shmmax is aliased in the output of ipcs above, it's ^max seg size (kbytes) = 4194303`


prepare-commit-message hook

As mentioned in #516, this commit implements the prepare-commit-msg hook, with a default hook that prepends a message based on the branch name through regex substitution.

@dcluna Is this still active? I'd love to see prepare-commit-message support merged. I'm happy to tidy up this PR if necessary...

@bpaul sorry, I haven't had enough time to tidy this up. Feel free to move this forward

@bpaul Hey, are you still planning on tidying this up? I'd be very much interested in having this hook as part of overcommit

Thanks @dcluna!


The balance on the home page is always 0 when we change the currency type

Balance on home page is always 0 when we change currency type and switch to that changed currency and that balance refreshes only when we kill the app and restart it again.

Verified this issue on dev app v2.0.1(375)


Add translation for ReactDOM API reference

Ciao.
This is the translation for ReactDOM API reference.

Closes #28

Ciao.
Do I need to take some further action other than resolving conversations? Yesterday, I committed the changes requested.

Ciao! There's still an item pending as far as I can see 😄

Sorry, I don't know how to remove this pending item. I had accepted some proposed changes, but for two of them I only resolved the conversation because changes were not needed.

I requested changes again, here's the link btw:
https://github.com/reactjs/it.reactjs.org/pull/121/files/fd9d619c460dbb6a0aa3f3240f08ea48f91f8aeb#diff-2514a3eb27676d9d3974be1c30731a97R47
😄


Move nc_format to be a submodule (from sub-submodule..)

It seems a bit weird to hide the nc_format functionality within data. At the moment, the nc_format modules including conventionalize are an important part of kval.
Suggestion:

Move from kval.data.nc_format to   kval.nc_format.
Will need to fix dependencies, particularly in the ctd module.

Done


[Test 3] Try to speed up htmlproofer

Same as https://github.com/cockroachdb/docs/pull/2689
but increasing threads instead of cpu.

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/9b360dc81e45a9fef3c1e100515e2669ebd11f8e/

TC finished in 30m:44s. No apparent benefit to increasing threads.


[python] Fix failed to convert buffer on update_obs/update_var

Issue and/or context: #2517 / [sc-46654]
Changes: As described in the PR
Notes for Reviewer:

Moving back to draft status until I add a unit-test case

@nguyenv @ryan-williams ready for review 🙏

@nguyenv thoughts?


Apps: Update status text

Update the relevant compute statuses display text to

"Not started"
"In progress. You may return later to use results in the visualization."
"Complete, results saved in the system"

Yes, status text appears as expected. QA is complete.


MSET currently does not support COMMAND getkeys

MSET currently does not support COMMAND GETKEYS
How to reproduce
$ command getkeys MSET K v A b
1) "K"

Expected behavior
1) "K"
2) "A"

created a PR


Updated Chinese translations

This pull request will complete the Chinese translations of the signup form.
Related file: ghost/i18n/locales/zh/signup-form.json

🤖 Generated by Copilot at c3bfeee
This file adds Chinese translations for the signup form messages in ghost/i18n/locales/zh/signup-form.json. It is part of a larger effort to localize Ghost for Chinese users.

Thanks @yinguobing! 🙂


Paginating with Single Attribute Filtering in JDBC user stores without providing a count only returns up to 100 results across pages.

Describe the issue:

When paginating with single attribute filtering in JDBC userstores, without providing a count value, the items per page decreases although there are more records available.
First request;

Total results which meet the filtering conditions: 1000.
Since a count isn't given, the max pagination size of the server (100) is taken, and 100 items per page are displayed - Intended behavior.
Second request;

When startIndex is increased to 50, the items per page is reduced to 51, although there should be 100 as the total results are 1000.
Third request;

Items per page keep decreasing when the startIndex value is increased.
Fourth request;

How to reproduce:

Use a copy of "wso2is-5.12.0-alpha14-SNAPSHOT"
Using POSTMAN send a request with a single filter and a startIndex to a domain using a JDBC userstore.

Try subsequent requests with increasing startIndex values.

Expected behavior:

Even through the startIndex value increases, the results per page should be 100 until it reaches the max limit of 1000.
Environment information

Product Version: wso2is-5.12.0-alpha14
OS: Ubuntu Linux
Database: MySQL
Userstore: JDBC

This issue is being closed due to extended inactivity. Please feel free to reopen it if further attention is needed. Thank you for helping us keep the issue list relevant and focused!


Workaround for conda-build issues

Checklist

[ ] Used a fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

@beckermr, this fixes https://github.com/conda/conda-build/issues/3876. Can I get another review?

Seems reasonable to me

Thanks @scopatz for the review. I'll give this a spin and revert if there are issues.


Introduce pkg/ctrlz, Istio's introspection package.

Processes that integrate with ControlZ open up a port that enables operators
to connect with a web browser and interact with the process. Through the browser,
the operator can adjust logging scope levels, see the process' command-line arguments
and envirinment variables, see statistics about heap use, and more.
Integration with ControlZ is nominally two line deal for processes. Optionally,
processes can extend the base ControlZ UI and integrate their own screens into the
main UI.
In addition to the browser interface, there is a REST API enabling access to all
the same things that the UI shows.
Mixer is integrated with ControlZ but doesn't currently have custom UI. We should
integrate ControlZ with our other server components in due time.

@geeknoid: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-v1alpha3.sh
48584aeb7b20708b76d7ec9e77c59d6e96375174
link
/test e2e-bookInfo-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: geeknoid
Assign the PR to them by writing /assign @geeknoid in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

mixer/OWNERS
pkg/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@geeknoid: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-v1alpha3.sh
68292d0844f3ac5032b9860faf636425eda0d732
link
/test e2e-bookInfo-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@geeknoid: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-v1alpha3.sh
8e5ba65a561a8830dc81aaed4db93000e09567d2
link
/test e2e-bookInfo-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@geeknoid: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-v1alpha3.sh
5a5c13e20993063d4e6a1dee11fe63d441e2008f
link
/test e2e-bookInfo-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler It'd be great to expose similar controls from the sidecars, but alas it would have to be completely separate code. I think the Envoy team is probably in a better position to deliver such a thing. Let's see how well this works for Istio components and maybe it'll be an obvious thing that other components will want to emulate.

@geeknoid Yup .... sgtm, thanks!

@geeknoid: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-v1alpha3.sh
5a5c13e20993063d4e6a1dee11fe63d441e2008f
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/istio-unit-tests.sh
b0ba248901557f56d342df973addabb6a934a76e
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@geeknoid: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-v1alpha3.sh
b33c5bcf546e7ba1f544ace53b74ae2f5ad8164b
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/istio-unit-tests.sh
e4f0ba3efe74f8a63dc030e1de90db4d24e28036
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@geeknoid: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
e4f0ba3efe74f8a63dc030e1de90db4d24e28036
link
/test istio-unit-tests

prow/e2e-bookInfoTests-v1alpha3.sh
e4f0ba3efe74f8a63dc030e1de90db4d24e28036
link
/test e2e-bookInfo-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


QA & Cert: Test Summary & Linearity Data Validations

The following are general Test Summary & Linearity checks that should be applied before creating, updating, or importing any and all QA Test Summary data.
QA and Certification Data Linearity Checks

[x] LINEAR-19 Linearity Injection Injection Time Valid
[x] LINEAR-34 Too Many Gas Injections

Testing
Test Case: TC790
Tester: @mosesdeeCVP

Test Passed


New version: OrbitPropagationLibrarySOFA v0.2.1

Registering package: OrbitPropagationLibrarySOFA
Repository: https://github.com/ampalski/OrbitPropagationLibrarySOFA.jl
Created by: @ampalski
Version: v0.2.1
Commit: 930c2c4c895de9239692cc9811cb5edbf36ced35
Reviewed by: @ampalski
Reference: https://github.com/ampalski/OrbitPropagationLibrarySOFA.jl/commit/930c2c4c895de9239692cc9811cb5edbf36ced35#commitcomment-144228605
Release notes:

New types enforcing stricter inputs, (better) compliance with the style guide.

[merge approved]


Undoing an accidental submission is not covered

I had a user report a phish on accident and I can see the submission but can't undo that. Please provide guidance. Where can the user retrieve the email (it's not in quarantine) and where can I revert it, there's no option in the user submissions.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 162f11ad-8add-952e-fd64-488e8e3f3b14
Version Independent ID: addf14d5-f1c1-662d-9844-6888df0349bd
Content: Admin submissions - Office 365
Content Source: microsoft-365/security/office-365-security/admin-submission.md
Service: o365-seccomp
GitHub Login: @chrisda
Microsoft Alias: chrisda

@sk1tt1sh Thank you for your feedback. Did the user report it via the report message add-in? I tested it now and the admin can only view what the user reported and cannot revert the user submission, however, the user can undo it by restoring it from Junk/deleted folder. I'll do a few more testing and add more details on this feature to the document.
Hope this helps!
Thanks
Sri

@msbemba Thank you very much for the contribution and updating the documentation with PR. @sk1tt1sh Hope this update is helpful for you. Thanks for taking out some time to open the issue. Appreciate and encourage you to do the same in future also.


Recipe App Group Project

This pull request implements the following features and requirements:

Login and Registration Pages: Implemented using Devise for user authentication.

Food List:

Displays a user's food items with quantities.
Allows users to add new food items via a form.

Recipes List:

Displays a user's created recipes.
Allows the owner to delete recipes.
Leads to recipe details.

Public Recipe List:

Displays all public recipes, sorted by newest.
Leads to recipe details.

Recipe Details:

Allows recipe owners to toggle between public and private status.
Displays recipe details for public recipes or if the user is the owner.
Leads to a form for owners to add new food items to their recipes.

General Shopping List View:

Shows missing food items for all of the user's recipes.
Counts total food items and calculates the total price of missing items.

Ensures efficient database queries to avoid N+1 issues.
Navigation Menu: Created a navigation menu for easy access to all pages.
Unit and Integration Tests: Included comprehensive tests to ensure the functionality is working as expected.

@elisha2kyakpo1 Thanks a lot for the feedback and tips.

Hi @Owusu-Desmond. We appreciate your feedback. The requested change will be implemented.


python3Packages.cairocffi: 1.1.0 -> 1.2.0

Motivation for this change
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 115305 at 35453bdf run on x86_64-linux 1

8 packages failed to build:

mirage-im
python38Packages.cairosvg
python38Packages.pygal
python38Packages.weasyprint
xml2rfc (python38Packages.xml2rfc)
python39Packages.cairosvg
python39Packages.pygal
sourcehut.metasrht

9 packages built:

python38Packages.cairocffi
python38Packages.graphite-web
python38Packages.graphite_api
python38Packages.influxgraph
python39Packages.cairocffi
python39Packages.graphite-web
python39Packages.graphite_api
python39Packages.influxgraph
qtile

1 suggestion:

warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?
Near pkgs/development/python-modules/cairocffi/generic.nix:48:5:
   |
48 |     maintainers = with maintainers; [];
   |     ^

Result of nixpkgs-review pr 115305 at 35453bd run on x86_64-linux 1
8 packages failed to build:
9 packages built:
1 suggestion:

Fixed in https://github.com/NixOS/nixpkgs/pull/115307

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 115305 run on x86_64-linux 1

17 packages built:

mirage-im
python38Packages.cairocffi
python38Packages.cairosvg
python38Packages.graphite-web
python38Packages.graphite_api
python38Packages.influxgraph
python38Packages.pygal
python38Packages.weasyprint
xml2rfc (python38Packages.xml2rfc)
python39Packages.cairocffi
python39Packages.cairosvg
python39Packages.graphite-web
python39Packages.graphite_api
python39Packages.influxgraph
python39Packages.pygal
qtile
sourcehut.metasrht

The following issues got detected with the above build packages.
Please fix at least the ones listed with your changed packages:

mirage-im:

warning: unclear-gpl
lgpl3 is a deprecated license, check if project uses lgpl3Plus or lgpl3Only and change meta.license accordingly.
Near pkgs/applications/networking/instant-messengers/mirage/default.nix:53:5:
   |
53 |     license = licenses.lgpl3;
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md

18 packages updated:
metasrht mirage python38Packages.cairocffi (1.1.0 → 1.2.0) python3.8-CairoSVG python3.8-graphite-api python3.8-graphite-web python3.8-influxgraph python3.8-pygal python3.8-weasyprint python3.8-xml2rfc python39Packages.cairocffi (1.1.0 → 1.2.0) python3.9-CairoSVG python3.9-graphite-api python3.9-graphite-web python3.9-influxgraph python3.9-pygal qtile xml2rfc

$ nix --experimental-features nix-command build --no-link --keep-going --option build-use-sandbox relaxed -f /home/teto/.cache/nixpkgs-review/rev-d1dc02322ae15ec34be233d1f84d600c9c939101/build.nix
17 packages built:
mirage-im python38Packages.cairocffi python38Packages.cairosvg python38Packages.graphite-web python38Packages.graphite_api python38Packages.influxgraph python38Packages.pygal python38Packages.weasyprint xml2rfc python39Packages.cairocffi python39Packages.cairosvg python39Packages.graphite-web python39Packages.graphite_api python39Packages.influxgraph python39Packages.pygal qtile sourcehut.metasrht

nix-build -A python27Packages.cairocffi
error: undefined variable 'numpy' at /home/hotpi/.cache/nixpkgs-review/pr-115305-1/nixpkgs/pkgs/development/python-modules/cairocffi/generic.nix:26:19
(use '--show-trace' to show detailed location information)

nixpkgs-review happy macos 10.14

python38Packages.xml2rfc evntually core dumps:
       > ............................................................/nix/store/zqycq4ajl75ardhhiixndn9wkprxbhl6-stdenv-linux/setup: line 1310:   308 Trace/breakpoint trap
(core dumped) pytest -k 'not test_font_stretch'

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 115305 run on x86_64-linux 1

3 packages failed to build and already failed to build on hydra master:

python38Packages.weasyprint: log was empty
xml2rfc: log was empty
sourcehut.metasrht: log was empty

1 package failed to build and are new build failure:

(python38Packages.xml2rfc): log was empty

14 packages built:

mirage-im
python38Packages.cairocffi
python38Packages.cairosvg
python38Packages.graphite-web
python38Packages.graphite_api
python38Packages.influxgraph
python38Packages.pygal
python39Packages.cairocffi
python39Packages.cairosvg
python39Packages.graphite-web
python39Packages.graphite_api
python39Packages.influxgraph
python39Packages.pygal
qtile


Eliminate 2 gpu ops during sampling when logit_bias is zero

Reason for PR: Eliminate 2 gpu ops during sampling when logit_bias is not used (all zeros)

skip allocation of logit_bias
skip applying logits.add_(self.logit_bias)

On our internal test of Yi-6B quantized using marlin on 4090 we see tangible improvement: up to 63% throughput improvement for small sized tokens output work loads when batch > 1.
Concurrency is 10 requests so it will cause sglang to use batch size between 1-10:

@Qubitium Sorry to cause trouble. I have directly pushed the commit on your branch.


Unable to use UUID as primary key

Sails version: v1.0.0-36
Node version: any
NPM version: any
Operating system: any

Sails v1.x.x requires that id (or whatever the primary key is) is either set to required or autoIncrement. This makes it difficult (impossible?) to use a uuid (uuid.v4()) as the primary key.
In v0.12.x, either of these would work:
autoPK: false,
attributes: {
  id: {
    type: 'string',
    primaryKey: true,
    defaultsTo: function() {
      return uuid.v4();
    }
  }
}

or
autoPK: false,
attributes: {
  id: {
    type: 'string',
    primaryKey: true
  }
},
beforeCreate: function(values, cb) {
  values.id = uuid.v4();
  cb();
}

In v1.x.x, neither of the above work. Is there another way to use a uuid as the primary key?

In v0.12.x, either of these would work:
autoPK: false,
attributes: {
  id: {
    type: 'string',
    primaryKey: true,
    defaultsTo: function() {
      return uuid.v4();
    }
  }
}

or
autoPK: false,
attributes: {
  id: {
    type: 'string',
    primaryKey: true
  }
},
beforeCreate: function(values, cb) {
  values.id = uuid.v4();
  cb();
}

In v1.x.x, neither of the above work. defaultsTo is not allowed on a primary key and the primary key is required to be set to required or autoIncrement. Is there another way to use a uuid as the primary key?

@fenichelar Interesting question -- is there an issue with setting the id directly in your .create() statement or blueprint POST?

@sgress454 Not if I was using .create() lol. I am using the automatic rest blueprints, my favorite part of Sails! 😄

@fenichelar When you use the automatic blueprint, you're still setting some attributes, right?  You should be able to set id as one of those.  You'll just need to generate your UUID on the front end.

Ahh I see, I think UUIDs on the front end could be very dangerous. I am using UUIDs for uniqueness across tables. Malicious users could try to exploit this.
I ended up finding a solution. I used a policy to set the id. It is just a little weird to do it that way. It would be great if the Sails 1.x.x restrictions preventing defaults to on a primary key was removed as defaults to can be a function.

@fenichelar glad you found a solution, and we'll look into this as a feature.  Re: security issue, without a policy like the one you're describing, the app would have that security issue regardless -- a malicious user could still just POST to the endpoint and set whatever id they wanted.  Policies are there to protect your endpoints from this kind of silliness!

Hey, Is anyone have solution to set uuid() as Primary key without using required: true in model attributes. I am facing issues in setting uuid as the primary key, it through me error

primary key id must have either required or autoIncrement set

I have required: true set for the id. I have a policy that applies to all create actions:
const uuid = require('uuid');
const actionUtil = require('sails-ember-rest/templates/util/actionUtil');

module.exports = (req, res, next) => {
  const model = actionUtil.parseModel(req);
  if (!model) {
    return res.badRequest();
  }
  const identity = _.camelCase(model.globalId);
  if (!identity) {
    return res.badRequest();
  }
  if (!req.param(identity)) {
    return res.badRequest();
  }

  req.param(identity).id = uuid.v4();

  return next();
};

Hi @umarfarook882 , @fenichelar ,
I'm sorry for the late comment, I just want to show how to setup model to use UUID with 'sails-postgresql'.
on your postgree database, you need to create new extension :
CREATE EXTENSION IF NOT EXISTS "uuid-ossp";
on config/model.js :
migrate: 'drop',
 attributes: {
 id: { type: 'string', columnType: 'UUID DEFAULT uuid_generate_v4()', autoIncrement: true},
}

you should setting migrate to 'drop' or 'safe' if you setting to 'alter' you will get an error message.
You can find that ways on sails-postgresql code here
https://github.com/balderdashy/sails-postgresql/blob/881275fc999e680f517eb4dccbc99a7bb3dbe1ce/helpers/private/schema/build-schema.js#L51
Hopes it can helps anyone who want to use UUID on their primary key. Thanks.

Does the Sails project have more than 5 Years and there is still no functionality to generate UUID for IDs?
Somewhere there must be some documentation for such a thing.

Thanks @toni-ismail . Currently i am generating the UUID on controller side and using that as primary key in model with the following config. it's  seem working fine for me. Anyway i will give a try with your idea.
primaryKey: 'uuid',
  attributes: {
    uuid:      { type: 'string',required: true,isUUID: true}
}

Does the Sails project have more than 5 Years and there is still no functionality to generate UUID for IDs?
Somewhere there must be some documentation for such a thing.

That's true. Even if the trick is easy it requires attention:
  primaryKey: 'id',
  dontUseObjectIds: true,
    id: {
      type: 'string',
      isUUID: true,
      columnName: '_id',
      unique: true,
    },

hi, is there an update/solution to make blueprint model attribute's id to default to mysql uuid?

@deeyonn Please can you share with me the code of how you have done this in the blueprint?

Can we reopen this issue or should I create a new one?

@deeyonn Please can you share with me the code of how you have done this in the blueprint?

Its the same as the example listed in their documentation, but instead of the find blueprint, its the create blueprint.
https://sailsjs.com/documentation/reference/configuration/sails-config-blueprints#?using-parseblueprintoptions


Use ES6 Promise in place of callbacks

I think this would be a beneficial change long term - 6.0?

if people want to use Promise, node v8's promisfy or bluebird's promisfy function is a viable option. 90% of the callbacks plugAPI provides is in the correct form of callback(err, data) => {};  (There are a few that only callback(data)  )
I see no benefit of having to rewrite the entire lib to use promises and making people change their existing code to have to use promises.

Do either v8's or bluebirds promisify work on PAPI yet? last time I checked
they did not.
On Mon, Oct 16, 2017 at 9:43 PM Alex Pham<EMAIL_ADDRESS>wrote:

if people want to use Promise, node v8's promisfy or bluebird's promisfy
function is a viable option. 90% of the callbacks plugAPI provides is in
the correct form of callback(err, data) => {}; (There are a few that only
callback(data) )
I see no benefit of having to rewrite the entire lib to use promises and
making people change their existing code to have to use promises.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/plugCubed/plugAPI/issues/144#issuecomment-337035259,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADNEI4l-47seQrwiGjk-CuoghjZVSllvks5ss7__gaJpZM4P7NgE
.

In my opinion, using a standard feature of the platform is a benefit in and of itself.

As a kind of compromise, maybe methods that take a callback could return a promise if called without a callback argument?

As an interim solution, I wrote this function:
function toPromise(call)
{
	return new Promise(
		function(resolve, reject)
		{
			call(
				function(err, data)
				{
					if(err)
						return reject(err);
					resolve(data);
				}
			);
		}
	);
}


[Question] Is there a way to reset user's start date selection on calendar-range

Our date picker displays a panel that renders the cally component inside when the date picker input is focused/clicked.
We have noticed a strange behavior when using the calendar-range component, I'll try to explain it:

When the user clicks the input and selects the start date of the range but suddenly clicks outside of the element, we close the calendar panel (where cally is rendered)
At this point, a start date has been selected in Cally, but there was no end date selected
If the user clicks the date picker input and opens the calendar panel again, the previous selection is still there.

Is there a way we can reset the calendar-range state? I'm attaching a video here for clarification, the same can be seen in the Cally documentation site.
https://github.com/WickyNilliams/cally/assets/328492/6cac17c7-fdce-4c63-8a73-b389d4f66c8f
What we would like, is a way that allows us to reset the calendar-range state if the user clicks outside and no end date has been selected. This should take into account that if a date range (start/end date is already set) we should be able to keep that range selection and only reset the start date selection action that was not completed.
I hope I've explained myself, otherwise please feel free to ask for details, I'll be more than glad to provide as many as needed.

Makes sense. There's definitely a need for some ability to cancel a tentative selection. I'll have a think on how best to support this

Check out #49. I've exposed a tentative prop on the range component. You can clear this whenever you like e.g. on click outside / close of the picker, and it should give you the desired behavior
Would this work for you?

Hey @WickyNilliams , thank you for taking the time to look into this so quickly.
I looked at the changes in the PR, if I understood correctly we would have a new tentative prop that can be set externally (default it will be the range start date value I think). That means I can set tentative as undefined on the calendar click outside handler and the range start selection will be cleared. Did I miss something?
I think this will work great for us 👍🏼

That's exactly right 👍

Released in 0.7.0


Change path grep syntax to match Laravel

Taylor just informed me that Laravel recently got except-path and has had only-path for a while, so it would probably be worth deprecating the old syntax and changing this package's flags to match Laravel's:
https://twitter.com/stauffermatt/status/1389245939106390019

Would you accept a PR to change the syntax and either drop the old syntax, or offer it as a deprecated fallback?

Should we change the "name" flags as well in that case? 🤔
--name and --except-name

@Gummibeer sure. For consistency.
@mattstauffer of course. If you can’t make it in the next few days I could also do it myself.

The only fear I have with these namings is conflicts. But would also match my idea of --group-by and --group options.

group and group-by would mean two really different things. If I understand your proposal correctly, you'd like to have a group option for the type of the route, e.g. web or api. I'm wary to have two so similar options. 🤔

No, the --group would be like --name=user/*.
So it would filter by group name. A filter name matches every route containing "user". But --group would match only routes starting with given string.

Will upgrade it when Laravel 9 is released.

Closing as the Laravel 9 will support the command natively as per this PR.

@Wulfheart what happens are they using your package or do they write it again from scratch and added it to Laravel 9

As far as I can see did they write it from scratch but stated in the PR that it is inspired by this package (which is inspired by many other packages itself) but they enhanced it quite a lot and I'm really happy about it as it relieves me of the maintenance burden. 😍

Yeah, it's pretty cool that they did it, but you also did a great job here too 😉💪💪💪

Thanks!


Docs: How To Set Default Value for an Entity Field

(docs): Creating a page for How To Set Default Value on Entity Field in the How To section.
This PR takes care of Issue #386.

looks good to me.

@mulygottlieb @overbit This PR has been approved.


[1.16] gateway deployment controller: handle backwards compatibility …

Fixes https://github.com/istio/istio/issues/44215

Future proof Gateway deployment controller

This introduces a mechanism to tell older versions to stop managing a Gateway.
How this works:
1.17 controls all Gateways. Users will upgrade to a patched version (basically this PR backported) which annotates all Gateways with version=1. It also has logic to not control Gateways with version>1 User installs 1.18 as canary revision. Any Gateways in canary revision will get version=2 set; at this point, the 1.17 controller will stop trying to manage it. Warning: if a user needs to remove 1.18 at this point, they would need to manual set the version label back to 1. This is not ideal, but it is the best we can do I think. User makes 1.18 the "default revision". At this point it does the same as above, but to a wider set of gateways. Eventually, if we somehow run into the same circumstance, we can change the logic again to version=3 in some future version and completely change how we do gateway ownership. That is, this solution is future proof.

improvements from master

lint

(cherry picked from commit b8b08a18116c779bbc9388a2903335b28112dd16)
Please provide a description of this PR:

@howardjohn: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-test_istio_release-1.16
5a04761e0f2b3789ab9be9b97d94043d45230956
link
true
/test release-test

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Speedup avoid loading pkg_resources at startup

Avoid an import time dependency on pkg_resources. This takes 0.3-4 s to import
To do this

Make import lazy in two instances where it is only used for logging
Dont use this to generate absolute paths to config files. This does in principle mean that these are no longer zip safe. However QCoDeS is currently not marked as zip safe and running from a zip file is not really something we want to support

bors merge


Animation on column control and components not working

@nicholas-haggerty Could you please have a look at this?


Add method to return json of objects in ingest-validation-tools

Done.
https://github.com/sennetconsortium/ingest-validation-tools/blob/4aaa8182c9ab77cb5e831cc33738449819a6edb4/src/ingest_validation_tools/table_validator.py#L96


Chart does not properly update with animation in master

Regression from #5331
I have a chart parameterized by a slider, so as the user is moving the slider, I repeatedly call update() on the chart to reflect the new parameter value in real time.
It is working well with version 2.7.3, but when testing with master, the chart does not update until the user stops moving the slider.
I found that this is a regression from #5331 which removes the drop frame mechanism. As the update() method is called nearly each frame, the animation start time is also reset each frame, and consequently the chart is updated each frame with an animation progress of zero.
The same bug appears on tooltip animation with a line chart configured like this:
               tooltips: {                     mode: 'nearest',                     intersect: false                 }
As moving the mouse cursor on the chart:

In 2.7.3 the tooltip follows the cursor
In master the tooltip does not move until we stop moving the cursor

@emmcbd can you please provide a codepen or jsfiddle that reproduces this issue? you can use https://chartjs.org/dist/master/Chart.min.js which is the latest build from master.

Here a reproduce case with tooltips, which is easier to reproduce:
https://codepen.io/anon/pen/pYyWbK
Quickly move your mouse over the chart, you will see that the tooltip does not move (or with very jerky animation) until you  stop moving.
If you switch back Chart.js to version 2.7.3, or revert #5331, everything is fine again.

@emmcbd what browser are you using?

@serhii-yakymuk you may want to be aware of this issue

@serhii-yakymuk you may want to be aware of this issue

Yes, thanks. I'll try to look into it.

@benmccann
Got to the same conclusion as @kurkle - bug is happening cause of currentStep being 0 all the time when animation is canceled quickly. If we keep currentStep in a range [1 ... numSteps] everything's working fine for me.


clicks do not register on embedded windows when a shell/log is active

When a shell/log is active and a user is creating/editing an RKE1 (embedded view) cluster through dashboard, clicks don't register near the bottom of the page, which is where the save button is. You can see in the screenshot below the flashing yellow cursor. Clicks/scrolls do not register below this line. The user must close out or minimize the shell in order to continue/save on the embedded page
Repro steps:

add an RKE1 cluster (i.e. linode) through the dashboard using the embedded view
wait for cluster to deploy
open shell on one of the workloads
go back to cluster management and edit the cluster with shell still open
user is unable to click save

master-head (5d2b7ac)

@nwmac z-index and/or where the iframe is put into the layout.  The partial-page loading screen mode is also half on top of windowmanager tabs.

on master-head (d3ad5d3):

windows are now organized properly when logs are viewed
clicks are registering correctly in all windows with logs up or hidden


Upgrade to Bean Validation 2.0

Also upgrade Maven plugins that were old and couldn't handle Java 8 annotations.

Great, thanks.


Remove "materialize" alias

This little PR just removes the "materialize" alias and uses the original "materialize-css" package name. This allows other build systems like Webpack to not need to create an alias for "materialize" and materialize-css can still load before everything else. I ran npm run dist and tested it locally in my angular-cli@webpack project and it works.

I'll bump up the major version and release a new version to NPM soon

Awesome. Thanks! Great repo by the way :)

Thanks. I'd like to spend some time cleaning it up and upgrading to the latest angular. Super busy at the moment so it will wait. Maybe in a couple of weeks.
Appreciate the feedback and initiative.