Create Crafting Finance.md

Grant Application Checklist

[x] The application-template.md has been copied, renamed ( "project_name.md") and updated.
[x] A BTC or Ethereum (DAI) address for the payment of the milestones is provided inside the application.
[x] The software of the project will be released under the Apache license version 2.0 as specified in the terms and conditions.
[x] The total funding amount of the project is below USD $30k for initial grant applications and $100k for follow-up grants.
[x] The initial PR contains only one commit (squash if needed before submitting your PR).
[x] The grant will only be announced once we've successfully delivered the first milestone.

And could you please clarify why you stated in your last application that "more than 70% of the team members have a Master degree or a PhD degree" when in the current application only 1 out of the 3 team members has one?

Closing due to inactivity.

@Noc2  @alxs
Sorry, I did not reply in time. Because we have recently communicated with the Acala team, they believe that the Crafting Finance project and Acala are highly complementary. The Acala team recommends that we use the WASM smart contract to complete the project and run it on Acala. Therefore, we have made adjustments to the technical roadmap, and we will upload some of the developed code in the near future.
In fact, the Crafting Finance project is more similar to Synthetix than Laminar. We recently had a conversation with Jordan from the Synthetix team. In the Crafting Finance project, we have upgraded the sharing debts pool model (SDP) proposed by Synthetix. Different from Synthetix, in which users have no choice and can only join the debt pool when forging synthetic assets. We innovatively proposed that users can choose whether to join the debt pool, and found that even if users do not join the debt pool, they can still trade in the system (Kingsman), and bring more possibilities to the entire system. Below we use an example to illustrate.
Suppose there are user A and user B. User A chooses not to join the debt pool when forging synthetic assets, and user B chooses to join the debt pool when forging synthetic assets. Suppose that before A and B forged synthetic assets, there were originally $100 rBTC in the system. Then, A forged $100 of rUSD but did not join the debt pool, and B forged $100 of rBTC and joined the debt pool. Then, the assets and liabilities of the entire system become $200 rBTC in the debt pool, and $100 rUSD outside the debt pool. B accounts for 50% of the system’s liabilities, and A has no debt ratio because he/she has not joined the debt pool.
Now if B buys $100 rUSD from A, and the $100 rUSD is not in the system, can it be traded in the system? The answer is yes. For example, B converts this $100 rUSD to rBTC through our trading system Kingsman, and the assets in the debt pool become a total of $300 rBTC, -$100 rUSD, the total assets and liabilities of the system are still $200, and B’s debt ratio is still 50% which is $100. That is, by allowing the balance of an asset in the debt pool to be negative, we have realized that synthetic assets that are not in the debt pool can also be traded in Kingsman.
Regarding the question "more than 70% of the team members have a Master degree or a PhD degree", because the application only includes technical team members, considering personal privacy, the operation team and marketing team members are not included. If you can provide a channel to ensure privacy, we are willing to verify this.

Thank you for the updates.
May I ask what your affiliation with the Coinversation team is? We recently noticed that a lot of the information in your last and this application had been copied from theirs.
Regarding a private communications channel, you can find David and me on Element under @david:web3.foundation and @aleixo:web3.foundation.

Just to add, you can also send us an email to<EMAIL_ADDRESS>and feel free to reopen and update the application accordingly once you are ready.


(IAC-804) Implement PSDscRunAsCredential

Prior to this commit specifying a PSDscRunAsCredential to run a DSC resource as was not possible, the run errored unpredictably.
This commit updates the base provider to handle running as another user, including handling logon errors and failures and caching them to prevent recurring failures.
Two limitations in this implementation exist:

It is not currently possible to cease processing a resource if there is an error with the credentials (e.g. unauthorized or bad password) so code paths have been introduced to handle this and minimize additional calls to the system.
Something in the way that Puppet compares Sensitive values is causing the strict check for canonicalization of retrieved data to fail, resulting in a warning message that claims the values are different while displaying identical (to the screen) results for the retrieved and canonicalized values.

However, the resources do not flap when the credentials are correct and have sufficient permissions to perform the action. Canonicalization continues to function as expected.

This still needs added acceptance tests.

Acceptance tests are in place.


Update .gitmodules

Otherwise pulling submodules fails in repo created using this repo as a template.

Hello,
Thank you for your PR - the issue with .gitmodules has been resolved, so I'm closing this PR.
Best regards,
Grzegorz Latosinski


Magic oneline input

input examples:
basics

@customer 15min #project #service fixed something
start #service fixing something @customer #project

stop recent activity

stop
stop @customer
stop #project
stop #service
stop fixing something

continuing recent activity

continue
continue @customer
continue #project
continue #service
continue fixing something

Frontend should provide auto-completion for customers, projects, services and recent activity descriptions.
API should receive the input string only.
Prefixes (@, #, ...) may be configurable.

see https://github.com/phpugl/DimeTimetrackerFrontendBundle/issues/5


M2 Integration

All of the changes encompassing M2.

Pull Request Test Coverage Report for Build 50

304 of 833 (36.49%) changed or added relevant lines in 48 files are covered.
12 unchanged lines in 6 files lost coverage.
Overall coverage decreased (-8.4%) to 10.316%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

libraries/botbuilder-choices/src/channel.ts
0
1
0.0%

libraries/botbuilder-core-extensions/src/memoryStorage.ts
3
4
75.0%

libraries/botbuilder-core-extensions/src/browserStorage.ts
3
5
60.0%

libraries/botbuilder-core/src/internal.ts
6
8
75.0%

libraries/botframework-connector/src/auth/microsoftAppCredentials.ts
0
3
0.0%

libraries/botbuilder-core/src/middlewareSet.ts
14
18
77.78%

libraries/botbuilder-prompts/src/textPrompt.ts
2
6
33.33%

libraries/botbuilder-prompts/src/attachmentPrompt.ts
2
6
33.33%

libraries/botbuilder-prompts/src/internal.ts
2
7
28.57%

libraries/botbuilder-dialogs/src/prompts/numberPrompt.ts
3
10
30.0%

Files with Coverage Reduction
New Missed Lines
%

libraries/botbuilder-dialogs/src/prompts/textPrompt.ts
1
17.65%

libraries/botbuilder-dialogs/src/prompts/numberPrompt.ts
1
17.65%

libraries/botbuilder-dialogs/src/prompts/confirmPrompt.ts
1
17.39%

libraries/botbuilder-dialogs/src/prompts/datetimePrompt.ts
1
17.65%

libraries/botbuilder-dialogs/src/prompts/attachmentPrompt.ts
1
17.65%

libraries/botbuilder-choices/src/channel.ts
7
14.29%

Totals

Change from base Build 30:
-8.4%

Covered Lines:
1273

Relevant Lines:
8707

💛  - Coveralls


Simplify harden to climb prototype chain

@kriskowal I do not understand the CI error I see at https://github.com/Agoric/SES-shim/pull/541/checks?check_run_id=1522424814
Other than that, ready for review.

Intermittent. It is all passing now. Nevermind?


Module not found error: markup safe

`Collecting MarkupSafe>=2.0 (from Jinja2>=3.0->Flask->-r ./requirements.txt (line 1))
Downloading https://files.pythonhosted.org/packages/bf/10/ff66fea6d1788c458663a84d88787bae15d45daa16f6b3ef33322a51fc7e/MarkupSafe-2.0.1.tar.gz
Complete output from command python setup.py egg_info:
Traceback (most recent call last):
File "", line 1, in
File "/tmp/pip-build-j3ci1_81/MarkupSafe/setup.py", line 61, in
run_setup(True)
File "/tmp/pip-build-j3ci1_81/MarkupSafe/setup.py", line 44, in run_setup
ext_modules=ext_modules if with_binary else [],
File "/usr/local/lib/python3.6/site-packages/setuptools/init.py", line 129, in setup
return distutils.core.setup(**attrs)
File "/usr/local/lib/python3.6/distutils/core.py", line 121, in setup
dist.parse_config_files()
File "/usr/local/lib/python3.6/site-packages/setuptools/dist.py", line 442, in parse_config_files
ignore_option_errors=ignore_option_errors)
File "/usr/local/lib/python3.6/site-packages/setuptools/config.py", line 106, in parse_configuration
meta.parse()
File "/usr/local/lib/python3.6/site-packages/setuptools/config.py", line 382, in parse
section_parser_method(section_options)
File "/usr/local/lib/python3.6/site-packages/setuptools/config.py", line 355, in parse_section
self[name] = value
File "/usr/local/lib/python3.6/site-packages/setuptools/config.py", line 173, in setitem
value = parser(value)
File "/usr/local/lib/python3.6/site-packages/setuptools/config.py", line 430, in _parse_version
version = self._parse_attr(value)
File "/usr/local/lib/python3.6/site-packages/setuptools/config.py", line 305, in _parse_attr
module = import_module(module_name)
File "/usr/local/lib/python3.6/importlib/init.py", line 126, in import_module
return _bootstrap._gcd_import(name[level:], package, level)
File "", line 994, in _gcd_import
File "", line 971, in _find_and_load
File "", line 953, in _find_and_load_unlocked
ModuleNotFoundError: No module named 'markupsafe'
----------------------------------------

Command "python setup.py egg_info" failed with error code 1 in /tmp/pip-build-j3ci1_81/MarkupSafe/ `

https://stackoverflow.com/questions/68556262/command-python-setup-py-egg-info-failed-with-error-code-1-in-tmp-pip-build-dl


Add initial development setup

Adds the initial baseline for dev work to begin on the UI.
While the exact means of distribution for this GUI is still not clear, I assume we will want to embed assets inside a go binary at some point, so this PR has an asset generation -> embedding flow that can be used for that. There is some build tag trickery to generate the embed-able assets using a package called vfsgen.
Important points about some of the other choices:

Uses parcel as the front-end bundler. This is a superior choice to webpack in my opinion, as it requires much less configuration
Uses a development middleware server to proxy requests to the backend and do all the fancy React hot-reloading you would expect
React stateless-functional-components and hooks will be used for state management (as opposed to redux). Much of the advantages of redux can be better encapsulated in a hook.

@stefanprodan  It seems that the 800+ dependencies come from the flux/pkg/runtime and prometheus/client_golang modules :man_shrugging:.
The code generation library is behind a build tag, so I don't think it gets included?


Project status

Can we get a project status update?
Essentially all issues that I can see that have been raised since 2018 have been marked stale and closed by the stalebot very soon afterwards without comment from project owners.
I'm not saying all issues have to be worked on, this is open source and we can contribute, but are there active maintainers that can comment on issues and indicate that a PR would be well received?
(Even then, valid PRs are being ignored and closed by the stalebot).
At the very least can we disable the stalebot?

@jcouball, @perlun or @tarcinil are any of you maintainers?

Yes, I am a (too passive) maintainer. My main problem is that I am not using the gem any more after switching jobs; I'm hardly even using Ruby at all. So there is very little incentive from my end to spend time on the project, regretfully.
@jcouball have been lending a helping hand lately; thanks a lot for this.
I will try to get a version 1.6.0 released later this week. But in the long run, we should clearly try to get more active people helping out with maintaining this gem. Especially useful would be to get people in who are using it in their work, where one or more work projects depend on the gem for its functionality.

Thanks, Per.  I will be spending more time on this.  If you'd like I can try to get this release out with the notes you sent me.
James.
On Tuesday, January 14, 2020, 12:20:34 PM PST, Per Lundberg<EMAIL_ADDRESS>wrote:
Yes, I am a (too passive) maintainer. My main problem is that I am not using the gem any more after switching jobs; I'm hardly even using Ruby at all. So there is very little incentive from my end to spend time on the project, regretfully.
@jcouball have been lending a helping hand lately; thanks a lot for this.
I will try to get a version 1.6.0 released later this week. But in the long run, we should clearly try to get more active people helping out with maintaining this gem. Especially useful would be to get people in who are using it in their work, where one or more work projects depend on the gem for its functionality.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.


Require a method for specific subtypes only?

I have a situation where I require a method only for some subtypes of the interface.
Would it be possible to support something like this for example?
abstract type MyType{T} end

function my_func end
function my_other_func end

@required MyType my_func(::MyType)

@required MyType{<:AbstractVector} my_other_func(::MyType)

This can get complicated very quickly. Should my_other_func error when it encounters a MyType{Int}, for example? This is not an issue in the current implementation, because @required doesn't handle UnionAll types right now. I'm inclined to think that they fall under the "optional interface" umbrella that IMO should be a distinct interface type, but I can also see how that is unnecessary duplication.

This can get complicated very quickly. Should my_other_func error when it encounters a MyType{Int}, for example?

In my case it shouldn't error, my_other_func is optional for MyType{Int}, it can exist but is not needed for using all implemented features of MyType. For instance, there can be a method my_feature in the package that uses my_other_func only when dispatched on a MyType{<:AbstractVector}.
Having the possibility to specify optional methods would be nice indeed.
Here is an extended example:
using RequiredInterfaces
using Test
const RI = RequiredInterfaces

abstract type MyType{T} end

function my_func end
function my_other_func end

@required MyType begin
    my_func(::MyType)
    my_other_func(::MyType)
end

function my_feature(t::MyType)
    return my_func(t)
end

function my_feature(t::MyType{<:AbstractVector})
    return my_func(t) * " " * my_other_func(t)
end

struct MySubType <: MyType{Int} end

my_func(t::MySubType) = "Hello"

struct MyOtherSubType <: MyType{Vector{Int}} end

my_func(t::MyOtherSubType) = "Hello"
my_other_func(t::MyOtherSubType) = "world"

struct MyWrongOtherSubType <: MyType{Vector{Int}} end

my_func(t::MyWrongOtherSubType) = "Hello"

The my_feature methods works as I want it to, which is nice:
my_feature(MySubType())   # returns "Hello"
my_feature(MyOtherSubType())   # returns "Hello world"
my_feature(MyWrongOtherSubType())   # raises a not implemented error, and suggests to implement my_other_func

However, check_interface_implemented does not work as I would want it to because my_other_func is considered mandatory, even for MySubType:
@test RI.check_interface_implemented(MyType, MyOtherSubType)   # passes
@test RI.check_interface_implemented(MyType, MyWrongOtherSubType)   # fails
@test RI.check_interface_implemented(MyType, MySubType)   # fails, and ideally should pass

Yes, that is intentional - an interface cannot really have optional methods. In your example, I'd be open to add something like
abstract type MyType{T} end

@required MyType begin
    my_func(::MyType)
end

@required MyType{<:AbstractArray} begin
    my_other_func(::MyType{<:AbstractArray})
end

or, with some syntax sugar:
@required T=MyType{<:AbstractArray} begin
    my_other_func(::T)
end

being equivalent to
abstract type MyType end
# note how the UnionAll is resolved here by hand, and
# `MyTypeAbstractArray` inherits the interface of `MyType`
abstract type MyTypeAbstractArray <: MyType

@required MyType begin
    my_func(::MyType)
end

@required MyTypeAbstractArray begin
    my_other_func(::MyTypeAbstractArray)
end

but I wouldn't make that happen automatically and/or add my_other_func as an "optional" method to the MyType interface in general. It's not optional at all for MyType at all - it is required, and that's exactly the case when the type is <: MyType{<:AbstractArray}.
In other words, I'd say that no user of your package should ever expect or think of my_other_func as being "optional". Having that available on a type means it implements an entirely different (larger) type than can be assumed from MyType alone.

I didn't think of using a MyTypeAbstractArray inheriting from MyType, this works quite well in my case I think!
I also like your other suggestion, but it might not be needed in my case.
Thanks a lot for your help!

Great! I'll leave this open, since support for UnionAll-style child interfaces seems intriguing.


Can not download

Error:(46, 13) Failed to resolve: com.github.BlacKCaT27:CurrencyEditText:v2.0.1

My apologies, it looks like I neglected to update the maven repo with 2.0.1. I've just pushed an upload. Give it a few minutes from the time of this reply and try again. If it still doesn't work, you can try the jitpack repo instead. Either way, I'll be sure to get this pack up soon.

nop, unable to resolve form both jitpack and maven central

Hrm...jitpack appears to be able to see the update, at least from their
website.
https://jitpack.io/#BlacKCaT27/CurrencyEditText/2.0.1
The instructions there don't get you a resolution?
I'll investigate further tonight, don't have access to what I need atm.
On Tue, Jul 25, 2017 at 9:12 AM, Kenneth<EMAIL_ADDRESS>wrote:

nop, unable to resolve form both jitpack and maven central
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/BlacKCaT27/CurrencyEditText/issues/33#issuecomment-317732335,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AE_54WtSil108nTFOS0Dk9d9gjr2LmHqks5sRelmgaJpZM4Ogy73
.

oh, i am able to resolve from jitpack now, the gradle dependency(for jitpack) version is 2.0.1 instead of v2.0.1. An update of the readme.md is in order i guess.

Ah, my apologies then! I'll fix that. Thanks for the heads up!


length() function for states, operators and superoperators.

Coverage increased (+0.002%) to 98.969% when pulling b1f392cb9d02bf79a67446c1b7e1ab4d9529f03f on length into 3dfd5e4ca89e3a7d7a998004292d839d2d09f5f7 on master.


Closing dockerCli to fix 'Too many open files' issue

Fix for https://github.com/projectcalico/libnetwork-plugin/issues/107

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

Looks good, thanks for the fix!


Implement DASer

Basically reimplement https://github.com/celestiaorg/celestia-node/blob/main/das/daser.go in celestia-node.

DASer will likely have a lifecycle very similar to Syncer, so taking inspiration from Syncer sounds like a good idea

Requires #192 #193 to be started.

closed in #223


NodeJS fix -- glob.glob returns the relative path.

The test succeeded unexpectedly because the test code handles
the data in a different way. Fixed both of them.

Current coverage is 91.23% (diff: 100%)

Merging #117 into master will not change coverage

@@             master       #117   diff @@
==========================================
  Files             3          3
  Lines           719        719
  Methods         150        150
  Messages          0          0
  Branches        116        116
==========================================
  Hits            656        656
  Misses           63         63
  Partials          0          0

Powered by Codecov. Last update feb4c6b...e845920


docs: Updated docs for infracost_breakdown to match Infracost 0.10

Infracost 0.10 has some changes in the names of the flags.
Ref: https://twitter.com/AliKhajeh/status/1530081914865868802

I don't think so. Infracost 0.10 has been released 3 days ago.

Maybe revert this change then and add it back as a supplemental note for Infracost 0.10 specifically? 🤔

I don't think it is necessary because we always expect (and recommend) users to update their tools if something seems off. This change is mentioning one of an argument but there are several more that users may be using (depending on the version of the tool they have installed).

This PR is included in version 1.72.2 :tada:


Plugin to display Plotly Image and execute on result

Hi Everyone, I would like to create a plugin which displays a Plotly image and executes some action based on the result. Here is a minimal example which hopefully makes it clearer what I am trying to do. I have also attached the output of this plugin - as you can see, the plot is not displayed.

from plotly.io import to_json
import json
import fiftyone.operators.types as types
import fiftyone.operators as foo
import plotly.graph_objects as go

class AcceptRejectModifiedImage(foo.Operator):
    @property
    def config(self):
        return foo.OperatorConfig(
            name="segment_anything_declustering",
            label="Apply Segment Anything for Declustering"
        )

    def  resolve_input(self,ctx):
        inputs=types.Object()
        style_choices = types.RadioGroup()
        style_choices.add_choice("Accept", label="Accept")
        style_choices.add_choice("Reject", label="Reject")
        inputs.enum(
            "style",
            style_choices.values(),
            default="Accept",
            view=style_choices,
        )

        fig=go.Figure()
        fig.add_trace(
            go.Scatter(x=[10,10,30,30,10], y=[30,40,40,30,30], mode='lines')
        )
        plotly_json=json.loads(to_json(fig))
        plotly = types.PlotlyView(data=plotly_json['data'],layout=plotly_json['layout'],config=None,label="My Plotly")

        inputs.define_property(
            "component",
            types.List(types.Object()),
            view=plotly,
        )
        return types.Property(inputs)

    def execute(self,ctx):
        #do something...
        yield ctx.trigger("reload_dataset")

Thanks for any help!

I got around this by slightly adapting the Plot example operator from the examples plugins in this repo. The resolve_output method has a button and variables are passed through the execute method in the same json used to create the image.


fix: set default organization

We have to fix a default organization as the all-sites-with-org index expects its partition key (the site's org id) to be set. this prevents errors like these:
One or more parameter values were invalid: Type mismatch for Index Key organizationId Expected: S Actual: NULL IndexName: all-sites-organizations-dev

currently add / update sites operations are failing

:tada: This PR is included in version @adobe/spacecat-shared-data-access-v1.9.5 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Angular module per each files source

E.g.: (two components in their own ng-module and a default module for the rest)
ngtemplates:
  files: [
    { cwd: 'src/components/',
      src: 'component/*.html', dest: 'build/components/component/component-template.js',
      module: 'component' },
    { cwd: 'src/components/',
      src: 'other-component/*.html', dest: 'build/components/other-component/other-component-template.js',
      module: 'other.component' },
    { cwd: 'src/templates/',
      src: '*.html', dest: 'build/templates/app-templates.js' },
  ]
  options: {
    module: 'app'
  }

I'm amazed that tests still pass with this change!  It must be due to Grunt's internal normalizing of files or whatever.

![Magic meme gif]
(http://replygif.net/thumbnail/336.gif)

@gugiserman I'm not sure I agree that this doesn't justify a new test, given that it adds completely new functionality. Would you mind adding one?


Adding gujarati language support for application

Describe the feature
Gujarati is the second most famous Indian language worldwide, with a huge userbase in both the western countries and in India. I'd implement the gujarati language localization into the project, along with it's translations.
Add ScreenShots

Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC'23 contributor
[X] I want to work on this issue

@avinashkranjan please assign me this


[JENKINS-36240] Added GHRepository.getPermission(String)

JENKINS-36240
Using a new API (currently still in preview) that fixes a longstanding issue.
@reviewbybees

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

Apparently amended in 6bfeb54f3c5116e241ad8ddd130667cd398bf459, d1c900a6206ddbeb78616a92841b0667a08a8a11, and 911e8d21a717842221f42cd49de0dd543250a807, and then released in 1.83.


why VertexElementDescription not explicit set location in shader?

why VertexElementDescription not explicit set location in shader?

Locations (as in, integer indices) aren't used uniformly in Veldrid's backends. OpenGL (presumably where you'd like to use locations) doesn't use locations, but matches by name instead. The specific mechanisms are described in this article.


add new domain

hello
i need to add a new domain to proxy how i can do it?

Add it to proxy-domains.txt before install
After install you’ll have to edit dnsmasq.conf file


Add hard fork to include more claim data

It's future hard fork request to ensure:

Include claim name, bid and sequence to the merkle hash
Allow only UTF-8 like claim names
Disallow following characters =&#:$@%?;\/"<>*\n\t\r\b\0 in claim name

Adjust consensus parameter nClaimInfoInMerkleForkHeight to allow it in production as well as nMaxRemovalWorkaroundHeight to purge out implementation detail bug which allow addition of claim without delay, see comments for more details.

The original list of that must be included in the fork:

Fork out the removal workaround (which we tried to fork out previously and failed).
Make names with nulls in them not be accepted.

And what about these symbols? *** ? _ % : # $ \n \t \r \b & = /**
Enforce that any new claim names are valid UTF-8.

IMPORTANT: add the name, bid, and sequence numbers into the claim value hash.

The user should not have to trust that the parameters to the proof RPC methods were used correctly.

Increase the maximum metadata size from 8KB to ?

It was decided that item 2 could be done by enforcing it at the mempool level only. The name enforcement does not need to become part of consensus. Hence, it technically doesn't need a fork.
It appears that item 1 is not in this changeset? Actually, it looks like we simply need to set the nMaxRemovalWorkaroundHeight. (We also need to set the other effective heights for this fork.)
The maximum metadata size should probably be doubled. No more than that.


Any protoid, cloneid combo can be passed to dissolve

We dont check that the clone is related to the proto

Ah yes, you're right. We could check that keccak256(abi,encodePacked(protoId, index)) is equal to the cloneId provided to dissolve().

Or we can pass protoId and index?


Overflow state

When tap into to modal window and change v-model to close modal window, overflow: hidden not removed, because of this content not scrolled

@Timur000101
Thank you for your report.
Please tell us the version of the library you used when the bug occurred and the version of vue you are using (or nuxt version if it is nuxt) so I can determine the cause.


Add Tag component

What
Added a tag component with LBH styles.
Why
Created Tag folder
We needed somewhere for the initial Tag component to be. The current implementation has folders for each component, so we made one for Tag. Inside, we followed the similar structure of the other components, given that the only difference is adding a class name to the previous implementation.
Moved Tag SASS from PhaseBanner into it's own file
We want to be able to import the Tag styling directly in other applications, currently the styling for the Tag was only applied given that it was inside the PhaseBanner. Which given that the Tag must be it's own component in the React library, meant we would have a Tag component with the govuk-frontend styles and then would be overwritten in the PhaseBanner, causing a contrast in style. We moved the styling into a respective style file for the component, which is imported in the PhaseBanner component and any other components when needed.
Altered params in PhaseBanner to give lbh-tag class to the Tag
In the current implemenetation, govukPhaseBanner generates the Tag component inside it, which we can not alter without changing the way lbhPhaseBanner works. To get around this, and given that the implementation only adds a class to the Tag, we pass the entire object into the Tag property, with lbh-tag class appended on it.
Next steps

[x] Add more examples for tag component

This is fantastic, thanks @CJWaszczuk. That one issue above to resolve (may or may not actually require any code changes). Please could you also add details to the CHANGELOG and add the new component to backstop.json? You can run backstop test to make sure that no other changes occur and then backstop approve to save the "Errors" for the new tag component.

On that note, are the NPM scripts (npm test etc.) supposed to work @LBHELewis? We had a lot of trouble running them locally.

On that note, are the NPM scripts (npm test etc.) supposed to work @LBHELewis? We had a lot of trouble running them locally.

@erbridge Sorry - npm run test:dependencies is currently failing (it fails on govuk-frontend too and I haven't had a change to look into it). The build tests scripts (test:build:package and test:build:dist) should be working, and run as part of the build scripts - let me know if you're having a problem with any of them?

Updated this with some changes @LBHELewis. It seemed that backstop wasn't a dependency of the library beforehand, so it's been added in with a simple npm script that we can pass the required arguments to. Also, there were a few backstop tests failing, the tables seemed to be different to the new references despite the PR not altering them in any way, alongside the phase banner also looking different with the same source code. Figured it may just be that they hadn't been updated but would be good to get your eyes on that.

@CJWaszczuk Thank you - this all looks great. And I know why those tests are failing - I realised that on Friday night, now that I made some changes to SCSS imports so that single module imports would work correctly I discovered that the font @extends are causing problems in terms of their position in the CSS and I need to change everything over to mixins and includes. Will try to get this done today, but for now don't worry about those tests failing. I'm happy for this to be merged if you are.


Sample CEL expression for rejecting GitRepo volumes is incorrect

This is a Bug Report

Problem:
The sample CEL expression under docs/concept/storage/volumes for rejecting gitRepo volumes is incorrect. The correct expression should be:
!has(object.spec.volumes) || !object.spec.volumes.exists(v, has(v.gitRepo))

Proposed Solution:
Update the CEL expression from (incorrect):
has(object.spec.volumes) || !object.spec.volumes.exists(v, has(v.gitRepo))

To (correct):
!has(object.spec.volumes) || !object.spec.volumes.exists(v, has(v.gitRepo))

Page to Update:
https://kubernetes.io/docs/concepts/storage/volumes/

/triage accepted


(BKR-1469) Don't remove the hosts_file option in beaker init

@tvpartytonight I'm not as familiar with the subcommand code as you are. Any reason off the top of your head why we should be looking for an alternative solution rather than the one presented here?

@ekinanp I think the title of the commit is a bit misleading, because you are actually removing the hosts_file key from being saved. Can you elaborate more on why this commit is needed?

@tvpartytonight That seems to be exactly backwards: this change removes the hosts_file key from not being saved. On the immediate next line is called options_to_write.delete(key), which caused hosts_file to be deleted from the save list; thus this change causes hosts_file to be saved.

@tvpartytonight I updated the commit message.

You are right @Dakta I misread the PR. @ekinanp I think that the way this change is implemented will have unforseen effects when using subcommands because it will change the options resolution. Another approach to consider would be to change the :hosts_file option to .beaker/subcommand_options.yaml when using beaker init. I think that way will be cleaner because beaker's options resolution will be unchanged for subcommands.

Maybe relevant: https://tickets.puppetlabs.com/browse/BKR-1145

@ekinanp @tvpartytonight has this conversation resolved? The resolution of this doesn't seem clear.

I think @Dakta was going to look into it since I have other things to work on for my team (originally thought it'd be a simple fix).

@mchllweeks Yeah, it can wait until he returns from PTO. /cc @jcoconnor

I remember that it seemed that Dakta was going to pick this up and get it ready when he had the time, which it doesn't appear came up during his internship.
With that being the case, I'd default to @tvpartytonight as the SME for subcommand options execution & his comment above of a different way to do this.
We don't typically have time to pick up PRs & get them across the finish line, our interns are a special case that doesn't cross the rest of the team sadly. Between this & your comment that you won't have time to move this forward, my recommendation is that we close this PR.
If I'm wrong about the status of the PR, or if there's an argument as to why this is important enough that our team should schedule work on it, let me know, & we'll take another look at this. Thanks!

last comment still current

@kevpl Oh I apologize, I thought I responded to this.
Yes, we can close this PR. We do have a workaround branch that uses this solution which we use in the imaging pipelines (https://github.com/ekinanp/beaker/tree/temp-BKR-1469). It would be nice if this could be fixed so we don't need that branch, but if there's other more pressing work then that workaround branch is OK for now.


Only get hostnames at endpoint removal.

Fix #36510.
When an endpoint slice gets removed, the corresponding service could also be removed, and query service registry for the service for that service would not return anything and some stale endpoint will be kept in the cache. This change make removal logic go through all possible host names for a slice removal.

@bianpengyuan: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio
ba8b04a5387ffaf115a68bcb70cba7bef1aac725
link
true
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test unit-tests_istio

In response to a cherrypick label: new pull request created: #36671

Thank you @bianpengyuan! 🚀


[Discussion] armv7 + Forge + Minecraft v1.12.2 + Mods on a Pi4

Hello!
First off thanks for this awesome docker container! I wanted to run an older version of Forge and Minecraft so I could use some older mods and was running into a whole host of problems and wanted to post here on how I got around them (also to see if there is a better way :D). Just to describe my setup a bit I am running Portainer on the Pi4 4GB with the volumes mounted on an SSD.
Problem 1: unzip and Java 8 not available in the armv7 branch.
The reason Java 8 is needed is the version of Forge for 1.12.2 of Minecraft does not support anything higher than that, and throws obscure errors. This one took me a bit to get around, but I ended up making a new image (custom Dockerfile) in portainer and installing OpenJDK 8 and unzip after your image. Like so,
FROM itzg/minecraft-server:armv7

RUN apt-get update && apt-get install -y unzip openjdk-8-jdk openjdk-8-jre && apt-get clean

After I set up my new container I had to update the java paths in the ENV vars like so (PATH, JAVA_HOME, JAVA_VERSION),

once I did that Java 8 was the default Java running.
Problem 2: Java not going above 1GB of ram and the version of openjdk installed does not support -XX:+UseG1GC
This was remedied by overriding another ENV var and passing +AlwaysPreTouch in the Java opts

Once those were up and running Forge was starting to run! Below was my forge settings,

Then it was as easy as making a mod folder on my volume and SCPing mods to the folder and installing. The Pi4 is running great so far! I have had multiple folks on the server with very limited issues. Great for a casual playthrough with mods! Anyway thought I would post this here I know it is not an issue so I apologize, but I thought my journey would help some folks!
Thanks again!

Interesting discovery. I thought I was stuck with Java 11 from AdoptOpenJDK since all the "openjdk" docker images seemed to only supply a "Zero VM" which ran only in interpreted mode. On RaspberryPi 3 B+ that was practically unusable since I could give up after numerous hours for the server to start.
So...I started up just an ubuntu:20.04 image and apt installed openjdk-8 and indeed it is the correct kind of JIT JVM.
I'm going to do some further experiments to improve the base image of the armv7 tag.

@paladizm the armv7 branch and the latest itzg/minecraft-server:armv7 tag is now based on ubuntu and leveraging your approach now supplies Java 8. It's the regular JVM which runs decently on RaspberryPI 3 B+.

Hey @itzg!
Thanks! I will close this issue, and folks can find it in the archive. Glad that I could help this awesome project a bit!!


Training never finish

Hello @JaesikKim
When I executed run_embedding.sh on the input files I prepared, it kept running without any error but never finished.
The process was left without termination but it seems like in sleep status after all epoches.
WhenI executed run_embedding.sh on the example files in data direcotry, it finished properly.
The differences I saw betwen when using the example input files and when using my own input files are:

When using the example input file, a pth file of each epoch was removed every time befor moving to the next epoch. Also I saw GOonly_200dim.pth was progressively updated at each epoch.

When using my own input files, pth files are not removed and accumulated as GOonly_200dim.pth.0, GOonly_200dim.pth.1 and so on. I also confirmed GOonly_200dim.pth was never created during the process.

When using the example input files, I saw lines starting with "json_stats:" between progress bars of epochs. This is also true after burn-in step.

Burn in negs=50, lr=0.003
100%|█████████████████████████████████| 1/1 [00:00<00:00,  3.16it/s]
json_stats: {"epoch": 0, "elapsed": 0.0054249875247478485, "loss": 3.931826683098391, "sqnorm_min": 0.0006856000455276103, "sqnorm_avg": 0.0008176872341644401, "sqnorm_max": 0.0008731740667575559}
Burn in negs=50, lr=0.003
100%|█████████████████████████████████| 1/1 [00:00<00:00, 86.36it/s]
json_stats: {"epoch": 1, "elapsed": 0.0029672086238861084, "loss": 3.931681898676436, "sqnorm_min": 0.0005846760973066063, "sqnorm_avg": 0.0008216559489371129, "sqnorm_max": 0.0008816333755467856}
Burn in negs=50, lr=0.003
100%|█████████████████████████████████| 1/1 [00:00<00:00, 74.19it/s]
json_stats: {"epoch": 2, "elapsed": 0.0018315277993679047, "loss": 3.931514766418724, "sqnorm_min": 0.0005188694821587003, "sqnorm_avg": 0.0008289513472264196, "sqnorm_max": 0.0009098924743264128}

When using my own input files, I didn't see any lines starting with "json_stats:". This is also true after burn-in step.

Burn in negs=50, lr=0.003
100%|█████████████████████████████████| 158/158 [00:11<00:00, 14.29it/s]
Burn in negs=50, lr=0.003
100%|█████████████████████████████████| 158/158 [00:14<00:00, 10.77it/s]
Burn in negs=50, lr=0.003
100%|█████████████████████████████████| 158/158 [00:24<00:00,  6.42it/s]
Burn in negs=50, lr=0.003

Do you come up with any reason why I get this problem?

hmm.. not really.. Can you share your input file to me? I can test on my env. and try to fix bugs, if possible.
And would be better to use -eval_each 10 because this value means how often checkpoints should be stored.

Sorry for my late reply.
I have just sent my input file to your email.
It may be a problem of my way of generating the input files, but I don't know what is wrong.
I tried running with '-eval_each 10' as you suggested, and now I can see the lines starting with 'jaon_stats' which I didn't see previously.
However, training process never finished again, leaving pth files of every 10 epoches.

Hi, I have the same problem. Do any new solutions are provided?

Last time in the conversation with @nukaemon by email, I suggested one solution for this.
Please see the message I sent below.
For better organization of this issue, I will close this one.
If you have still this issue, please raise a new issue.
With your input files, my env was working well, and it was terminated well.

First attached image is the end of log for GO embedding.

Next attached image is the end of log for Gene embedding.

My running setting is below.

python3 embedGO.py
-dim 200
-lr 0.3
-epochs 100
-negs 50
-batchsize 50
-burnin 20
-eval_each 10
-gpu 0
-manifold poincare
-dset data/my_input/GO_closure_4.tsv
-checkpoint result/GOonly_200dim.pth
-fresh
-sparse
python3 embedGene.py
-dim 200
-lr 1
-epochs 100
-negs 50
-batchsize 50
-burnin 20
-gpu 0
-manifold poincare
-dset data/my_input/GOA.tsv
-pretrain result/GOonly_200dim.pth
-checkpoint result/hig2vec_200dim.pth
-sym
-fresh
-sparse
-finetune
python3 combine.py
-GOonly result/GOonly_200dim.pth
-gene_embedding result/hig2vec_200dim.pth
And in case, I’m attaching the final output file.
If your running code still doesn’t work, can you try with new env. and install my code again?
Hope you resolve this issue..


Proposal: Transitioning from Chrome-Exclusive to Universal Browser Compatibility

Problem
Currently, the application is prompt to use Google Chrome by default, limiting accessibility and user experience for individuals using alternative browsers. This monolithic approach excludes a significant user base and hinders the platform's adaptability to diverse browser environments.
Proposal
This issue advocates for a transition from Chrome-centric development to a more inclusive approach that supports a broader range of web browsers. The goal is to enhance accessibility, improve user experience, and adhere to web standards that promote compatibility across different platforms.
Proposed Changes
When testing I realize that on MacOS you can open your default browser by just type in the search bar
browser

So instead of Google Chrome you can search browsers then enter it will open the browser without the need of user have to use Google Chrome. Since most browser have the search bar at the same location you can still use the default setting for it.

@centopw Thanks for this proposed change. It's interesting to see that you can just open the default browser by searching for "browser" in Mac OS. Do you have any ideas on how the default browser could be opened on Windows and Linux? I've tested just searching for "browser" on my Linux distro and it doesn't find the default.

Issue Description
When searching for browsers on different Linux distros, the current behavior is as follows:
Ubuntu 22.04.3

Returns all available browsers but fails to display the correct default browser.

Kali Linux 2023.3

Similar to Ubuntu, it shows all available browsers but does not identify the default browser correctly.

Proposed Changes
Two potential solutions have been considered:

Script Improvement (PR #19):
Enhance the existing scripts to prompt the user for their default browser choice and update the main.py with the selected browser.

Update main.py:
Modify main.py to prompt the user to select the default browser every time it runs.

Pros & Cons
Both options offer improved accuracy:

The user can specify the location of the search bar for each browser, expanding support for future browsers.

Drawbacks:

Option 1:

Pros: Users can set their preferred default browser with the updated scripts.
Cons: Users must run the additional script (#19) for installation; otherwise, it defaults to Google Chrome.

Option 2:

Pros: User flexibility in selecting the default browser each time.
Cons: Users are required to input their default browser choice with every run.

With this proposal I have draft a simple update for the main.py as below:
 # Ask the user for their default browser
    default_browser = prompt(
        "Please enter your default browser (e.g., Chrome, Firefox): "
    )

    # Adjust the behavior based on the user's default browser
    if default_browser.lower() == "chrome":
        browser_prompt = "Google Chrome"
        browser_address_bar = {"x": "50%", "y": "9%"}
        browser_profile_icon = {"x": "50%", "y": "55%"}
    elif default_browser.lower() == "firefox":
        browser_prompt = "Mozilla Firefox"
        browser_address_bar = {"x": "50%", "y": "10%"}
        browser_profile_icon = {"x": "50%", "y": "60%"}
    else:
        # Default to Chrome behavior if the input is unknown
        browser_prompt = "Google Chrome"
        browser_address_bar = {"x": "50%", "y": "9%"}
        browser_profile_icon = {"x": "50%", "y": "55%"}

    message_dialog(
        title="Self-Operating Computer",
        text=f"Ask a computer to do anything. Default browser set to {browser_prompt}.",
        style=style,
    ).run()

    print("SYSTEM", platform.system())

    # Update the prompts based on the chosen/default browser
    VISION_PROMPT = f"""
    You are a Self-Operating Computer. You use {browser_prompt} as your default browser.

    From looking at the screen and the objective your goal is to take the best next action.

    To operate the computer you have the four options below.

    1. CLICK - Move mouse and click
    2. TYPE - Type on the keyboard
    3. SEARCH - Search for a program on {browser_prompt} and open it
    4. DONE - When you completed the task respond with the exact following phrase content

    Here are the response formats below.

    1. CLICK
    Response: CLICK {{ "x": "percent", "y": "percent", "description": "~description here~", "reason": "~reason here~" }}

    2. TYPE
    Response: TYPE "value you want to type"

    2. SEARCH
    Response: SEARCH "app you want to search for on {browser_prompt}"

    3. DONE
    Response: DONE

    Here are examples of how to respond.
    ...
    """

Also Instead of asking user to type out we can incorporate a menu function that allow user to select a pre-define selection of browser

If you want to go with terminal approach we could simply open any website then from the terminal
ex:

Linux: xdg-open http://www.google.com
Windows: start http://www.google.com
MacOS: open http://www.google.com

When run this command in the terminal it will automatically open with default browser on each system. One more thing that I think we could benefit from this is since it always open the google.com website so we can define where the search location is avoid miss click even more

This way we don't need to setup some permission on MacOS?

@centopw I am going to try out your install script in #19 and see how it works.

@michaelhhogue Then how about this? I don't really work with Windows that much so this draft only work with Mac using webbrowser and Linux xdg-setting,
def get_default_browser_macos():
        return webbrowser.get().name

def get_default_browser_linux():
        result = subprocess.run(["xdg-settings", "get", "default-web-browser"], stdout=subprocess.PIPE, text=True)
        browser_name = result.stdout.strip()
        return browser_name

@centopw I'll test this out as well and get back with you.

Problem
Currently, the application is prompt to use Google Chrome by default, limiting accessibility and user experience for individuals using alternative browsers. This monolithic approach excludes a significant user base and hinders the platform's adaptability to diverse browser environments.
Proposal
This issue advocates for a transition from Chrome-centric development to a more inclusive approach that supports a broader range of web browsers. The goal is to enhance accessibility, improve user experience, and adhere to web standards that promote compatibility across different platforms.
Proposed Changes
When testing I realize that on MacOS you can open your default browser by just type in the search bar
browser

So instead of Google Chrome you can search browsers then enter it will open the browser without the need of user have to use Google Chrome. Since most browser have the search bar at the same location you can still use the default setting for it.

I originally hacked in Google Chrome as the default, but agree we've out grown this. Chrome is 70% of the market if I understand correctly though. Would it make sense to "check for chrome" and if it doesn't find it then search for "browser" as shown above?
- Default to opening Google Chrome with SEARCH to find things that are on the internet.


Refactor TypeScript Types

Summary | Résumé
closes #704
Here is a quick summary of the changes:

creating a types module with different type files to better organize types while still preserving the ability to use only one import statement
switched form element types to an enum instead of repeated strings across the code base
use HTMLInputTypeAttribute from react rather than defining own string type for input types
made _onlyIncludePublicProperties in crud.ts synchronous as there are no async side effects
Created LambdaResponse generic for re-usability since lambda responses constantly have the same structure
Removed PublicFormSchemaProperties and refactored codebase to use a consistant form object reducing duplication
Refactored _getFormByStatus to use _onlyIncludePublicProperties to remove duplicate code
Made formID consistently typed number across the codebase as it is returned form the template lambda
Fix typing in cache.ts to reflect that the redis keystore stores what is returned by the template lambda and not the downstream PublicFormRecord object
Remove FormValue type as an inline type would be more clear
Created base InputFieldProps interface to be extended by form field components

Test instructions | Instructions pour tester la modification
Pull down the app and make sure it works end to end from creating a form, to rendering a form and submitting a response
Unresolved questions / Out of scope | Questions non résolues ou hors sujet
N/A
Pull Request Checklist
Please complete the following items in the checklist before you request a review:

[x] Have you completely tested the functionality of change introduced in this PR? Is the PR solving the problem it's meant to solve within the scope of the related issue?
[ ] The PR does not introduce any new issues such as failed tests, console warnings or new bugs.
[ ] If this PR adds a package have you ensured its licensed correctly and does not add additional security issues?
[x] Is the code clean, readable and maintainable? Is it easy to understand and comprehend.
[x] Does your code have adequate comprehensible comments? Do new functions have docstrings?
[ ] Have you modified the change log and updated any relevant documentation?
[x] Is there adequate test coverage? Both unit tests and end-to-end tests where applicable?
[ ] If your PR is touching any UI is it accessible? Have you tested it with a screen reader? Have you tested it with automated testing tools such as axe?

LGTM but not comfortable approving it :)

understandable will wait for Bryan


[BLOCKED] Importer ui

address https://github.com/CERNDocumentServer/cds-ils/issues/213
depends on https://github.com/inveniosoftware/react-invenio-app-ils/pull/308

This new page allows us to import documents slecting the provider, the mode and uploading the file.

All the fields are required.
The file estension must be .xml.
If we select delete as mode, a confirmation modal will appear.
While processing data (importing records), if we try to close/reload the results page we will get an alert.
Each 30 seconds we will fetch the data (this can be changed).

Some screenshots:
Importer form

Form validation (frontend)

Display of backend errrors on POST

Confirmation modal on delete

Loading

Alert while loading on close/reload of tab

Import failed

Results page

Note for reviewers: Please just review last commit (the UI changes), the backend changes can be checked here.

Some of the comments are for the other PR, I'll take care of them.


feat(Combinatorics/SimpleGraph): add lemmas about spanningCoe

Add some small lemma's supporting Subgraph.spanningCoe
SimpleGraph.adj_iff_of_sym2_eq is currently unused, but added for symmetry with the Subgraph API.
In preparation for Tutte's theorem.

Zulip thread for Tutte
Work in progress with example usages

Fixed up the suggested names, I also renamed the SimpleGraph version of the congruence lemma to adhere to the same naming


prevent a missing policy json

I am using moto with terraform. After a recent update we can no longer create SQS queues without a policy. I am not totally sure which change caused this issue but after reading through the code it appears there is a way for the Queue object to end up in a bad state. Based on the age of the code it seems like this potential has been there for a while but maybe something upstream is depending on the state being valid now.
If self.policy is called as a getter it must have self._policy_json defined or it will throw an error:
    @property
    def policy(self):
        if self._policy_json.get("Statement"):
            return json.dumps(self._policy_json)
        else:
            return None

This method is called in the attributes method like so:
        if self.policy:
            result["Policy"] = self.policy

To me the intent is clearly that self.policy should return None here if self._policy_json isn't defined it throws an exception.
At first I was going to handle this in the policy getter but I looked at the setter:
    @policy.setter
    def policy(self, policy):
        if policy:
            self._policy_json = json.loads(policy)
        else:
            self._policy_json = {
                "Version": "2012-10-17",
                "Id": "{}/SQSDefaultPolicy".format(self.queue_arn),
                "Statement": [],
            }

And it should actually be able to handle a falsey policy argument however where it is called:
        if attributes.get("Policy"):
            self.policy = attributes["Policy"]

It is explicitly not called if Policy is not included. Also, self._policy_json is used in other places (like lines 1021, 1049, and 1054) than the getter so it is critical that it is always set during initialization.
I felt the best way to fix this issue was to call the setter with a possibly missing Policy.

Codecov Report

Merging #4706 (de089c5) into master (43269fc) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #4706      +/-   ##
==========================================
- Coverage   95.28%   95.28%   -0.01%
==========================================
  Files         556      556
  Lines       61005    61004       -1
==========================================
- Hits        58129    58127       -2
- Misses       2876     2877       +1

Flag
Coverage Δ

servertests
47.81% <100.00%> (+<0.01%)
:arrow_up:

test_responses
32.49% <100.00%> (+<0.01%)
:arrow_up:

unittests
95.19% <100.00%> (-0.01%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

moto/sqs/models.py
96.95% <100.00%> (-0.01%)
:arrow_down:

moto/awslambda/models.py
92.91% <0.00%> (-0.12%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43269fc...de089c5. Read the comment docs.


check updated documentation

I have updated the welcome page to reflect:

PubMed has set up their API search (i.e. how the tool searches the data) such that the wildcard character will expand to match any set of characters up to a limit of 600 unique expansions. This means that words that have more than 600 extensions (i.e. cat*) will not return all results. As an example if the limit was in fact 3 not 600, “cat*” could expand to include “cats”, “category” and “categories” but then it would hit the limit and titles with “cathartic” in would not be captured
I have changed the tool to read in all documents up to but not including the day of the search.
I am no longer filtering out publications that are missing a year of publication or a doi. Where year of publication is missing I have given them the default "1990"

I have updated the documentation page to contain information about Scopus abstracts.
Can you check that the above is all captured and there are no contradictions

@forty-rachel
bullet point 1:

appears in doc
would be worth mentioning that it is a globular search pattern and if regex are also available
cannot be tested just from output, suggestion: download data, dump as continuous text, extract all words pattern cats.*, and count occurences

bullet point 2:

appears in welcome
does not work as expected, see related issue 64
"You can also select the date from which you want to see articles." suggests from which we want to see (display result), not query, while the tool says "Find articles online since" so it excludes from search.

bullet point 3:

working as expected
"TO NOTE: where month and day of publication are not provided 01 is used as a default. Where year of publication is not provided 1990 is used as a default. This means that all publications that only provide the year of publication are given the publication date 01/01/year in our output and those that have no details are given the date 01/01/1990": works but, this detail is hidden in the "welcome/download", it should come up and be emphasised.

Remarks (personal and on first impressions of the app):

rail menu is not clear, Welcome is partially a documentation (it actually says more than the documentation itself about how it works)
an example of search and or screenshots would work well
the documentation is not a documentation, it gives sources (should be in welcome)
since the app is based on a collection of REST APIs, and that the functions are wrapping around REST vocabulary (e.g. get_) the documentation should reflect this. E.g. "Fields in the returned data": it is unclear to the user if they are the fields in the response (from the queries) or from the presented output.
"URL: Link that will take you to the article page ...", slightly confusing, should the user expect an anchor returned in the response or a string? (it seems to be string in the table)

Formatting:
"to search for multiple terms: botulism AND sheep will return everything containing the word botulism if it also contains the word sheep", feels cluttered to the user, should use other font to better set appart

"TO NOTE" is sometimes all caps, sometimes "To note".
"If the above search returned an error please check that you have closed all your brackets. Some special characters (i.e. &) may also cause errors." This message should only pop up when the query returns an error.
why are the filters split in 3 fields and not simply following the same UX as for the search (confusing imo)

bullet 1: I reckon one way to test in tool is see if you get a larger return if you use more specific wild cards. If:
"medica* AND medici*"
returns more results then
"medic*"
you'll know that "medic" is not returning everything

Ok, I was thinking too far into not only validating the limit but also that it is 600 :D
Limit is applied:

medici*
89377

medica*
204952

294329

medic*
269306

25023


Support HTML assets

Keep an eye on https://github.com/vitejs/vite/pull/11138 and once it's merged, make it possible to inline HTML assets.

Thanks for the heads-up!


added option to reset all task at once in weekly planner

Description
The reset menu option allows a  user to reset all of the weekdays planner content at once
Fixes #14
#APK Link
https://drive.google.com/file/d/13CIGsnz2lkGfQ5tsq71AMu3_aDvZJF2Z/view?usp=sharing

I have made changes to previous PR ,kindly check out the below APK to test the features.
Updated APK

give @PratyushSingh07 75 points


BOT: inventory ordering not correct

can add a .sort before returning entries https://github.com/webaverse/ethereum-bot/blob/master/discordbot.js#L1965

added sort https://github.com/webaverse/ethereum-bot/commit/22c5d3888434d5facb6ca20277888d25d559d5c3


Key rotation

Hi, Is there a way to support rotation of keys used for encrypting the snapshot
Also if we encrypt the snapshot using one key and then rotate the key, does it recognize the earlier snapshots?

Hi good questions:

Is there a way to support rotation of keys used for encrypting the snapshot

so far no due to the limitation of the plugin interface

Also if we encrypt the snapshot using one key and then rotate the key, does it recognize the earlier snapshots?

same it supports only one key so far the reasons the same.
But since OpenSearch wants to use the plugin https://github.com/opensearch-project/OpenSearch/issues/5800
I'm planning to discuss with them a possibility to integrate it inside OpenSearch and in this case each snapshot will have
it own key.

wil be fixed in https://github.com/Aiven-Open/encrypted-repository-opensearch/pull/77


Support for analytical spectrum with 2D spatial model

Closes #9
Adds new FitsMapSource source class that joins the analytical spectral model with the 2D FITS map of the surface brightness. The class may be set for a given source indicating the "fitsmap" spatial model type.
FitsMapSource assumes the sky map FITS defines the flux unit in the "BUNIT" keyword of the primary extension; if the keyword is missing it will deduce it assuming a unitary total flux from the total sky area covered by world coordinate system, defined in the header.
Usage example in the config file:
sources:
    - name: "diffuse_source"
      emission_type: "gamma"
      spatial:
          type: 'fitsmap'
          file_name: 'sky_map.fits'
      spectral:
          type: 'pwlec'
          norm: '1.0e-25 1/(cm2 s eV)'
          e0: '1 TeV'
          index: -2
          ecut: '10 TeV'

@mstrzys , any comments on this MR?

I cannot recall whether you replied via a different channel, but I cannot see any replies to my comments here.


[ENG-1267] Source types from OpenAPI repo

#90  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @RajatPawar and the rest of your teammates on  Graphite


Discovery - GCDS components in form builder script. Also Next 13

Summary | Résumé
This PR show the issues we get when trying to use components in the form builder script.
the form builder script is a big "switch" that simply check through a list of form input definitions, and generates form fields.
Using the GCDS components in here, rather than in components, would in theory work best, as the gcds components are less modular. Example: <GcdsInput> contains, the label, description, validator and the input. The equivalent TextInputcomponent in GC Forms does not contain the label and description.
Also there seems to be some incompatible types. Commented out in this PR.
Here is how the component renders. I was able to briefly make the styles work, but now they seem broken. More investigation needed!

@timarney Another PR on top of your next 13 work.

Closing as this is falling out of date and isn't in active development.  Can re-open in the future.


Use Integer instead of int in map in flutter.groovy

packages Roller breakage
https://ci.chromium.org/ui/p/flutter/builders/try/Linux_android android_build_all_packages master/5504/overview
Fixes flutter/flutter/issues/141897
FAILURE: Build failed with an exception.

* Where:
Script '/b/s/w/ir/x/w/flutter/packages/flutter_tools/gradle/src/main/groovy/flutter.groovy' line: 168

* What went wrong:
Could not compile script '/b/s/w/ir/x/w/flutter/packages/flutter_tools/gradle/src/main/groovy/flutter.groovy'.
> startup failed:
  script '/b/s/w/ir/x/w/flutter/packages/flutter_tools/gradle/src/main/groovy/flutter.groovy': 168: primitive type parameters not allowed here;
     solution: use the corresponding wrapper type, such as Integer for int @ line 168, column 41.
     e static final Map<String, int> ABI_VERS

Covered by tests in packages.
Pre-launch Checklist

[x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
[x] I read the [Tree Hygiene] wiki page, which explains my responsibilities.
[x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
[x] I signed the [CLA].
[x] I listed at least one issue that this PR fixes in the description above.
[x] I updated/added relevant documentation (doc comments with ///).
[ ] I added new tests to check the change I am making, or this PR is [test-exempt].
[x] All existing and new tests are passing.

test-exempt: tested by the fact the packages roller will now work (it is broken at HEAD).
... though as @reidbaker pointed out on Discord, it could be tested by:

writing a test in framework that uses the abi version rolling code

He'll file a bug for that.

test-exempt: tested by the fact the packages roller will now work (it is broken at HEAD).
... though as @reidbaker pointed out on Discord, it could be tested by:

writing a test in framework that uses the abi version rolling code

He'll file a bug for that.

https://github.com/flutter/flutter/issues/141899

https://github.com/flutter/packages/pull/5948/checks?check_run_id=20673122973
Proof the roller issue behind the issue is passing. https://github.com/flutter/packages/pull/5948/checks?check_run_id=20673122973


v-model on a custom element

Version
3.0.0-rc.4
Reproduction link
https://github.com/Benoit-Vasseur/bug-vue3-v-model-wc
Steps to reproduce

npm run dev

What is expected?

no error in compilation
v-model is working if the web component is using value prop and trigger the 'input' event

What is actually happening?

compilation is failing : [vite] SFC template compilation error: v-model can only be used on <input>, <textarea> and <select> elements.

I based my test on those RFCs :

https://github.com/vuejs/rfcs/blob/master/active-rfcs/0011-v-model-api-change.md#usage-on-custom-elements
https://github.com/vuejs/rfcs/blob/master/active-rfcs/0027-custom-elements-interop.md#autonomous-custom-elements

vueCompilerOptions.isCustomElement seems to work but when i tried to add the v-model attribute it break the compilation :/.
I tried to read the compiler code to find a way to alter the tag of the node, but it does not seem possible : https://github.com/vuejs/vue-next/blob/master/packages/compiler-dom/src/transforms/vModel.ts#L47
Issue for vue2 is here : https://github.com/vuejs/vue/issues/7830
I am open to try to make a PR for this if you give me some hints to implement the feature :).
Thank you in advance for your reply.
Can not wait to adopt Vue 3 :).

Thanks :).
I was developping this and wanted to make a PR but it is done so it is perfect :).
However I have a suggestion concerning the v-model on a custom element.
I think it could be safer to force the "type" and name the prop v-model-type instead of type. type looks to dangerous to me for the naming collision. I was also thinking of <my-element v-model="model" v-model.type="text" /> but I do not think that it respect the design of the modifier, it is more an "adder" in this case.
What do you think (rename type to v-model-type and make it mandatory for custom element with a proper error message) ? I can make a PR if you approve the idea :).


ci: Add code test workflow

Pull Request
Description
This change introduces a new GitHub Actions workflow named "Code Test" to automate unit testing for the project. The workflow is triggered on pushes to the main branch and pull request events.
This addition enhances the project's CI/CD pipeline, ensuring that unit tests are automatically run on code changes, which helps maintain code quality and catch potential issues early in the development process.
fixes #34

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#38  👈
#37
#36
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @JackPlowman and the rest of your teammates on  Graphite

Merge activity

Sep 27, 1:31 PM EDT: @JackPlowman merged this pull request with Graphite.


SSH service reported as disabled while I am SSH'ed onto the server

Hey,
I probably don't understand the check, but I am curious as to why it reports the "SSH Service is disabled"; while I am actively using SSH on the server to run the check?

Sidenote, there may also be an issue with the status of one of the steps:

I am not sure why the ssh_jail_enabled check fails either:

Hey @JapSeyz , thanks for opening this issue.

I probably don't understand the check, but I am curious as to why it reports the "SSH Service is disabled"; while I am actively using SSH on the server to run the check?

Likely related to #3. The check relies on sshd running. Can you please let me know what program is running the SSH server on your system? You can see this by running sudo lsof -i :22 (assuming SSH is running on port 22).

Sidenote, there may also be an issue with the status of one of the steps:

I changed one of the check names yesterday and it seems you have an older version of the script. Please download the latest version and it should work!

I am not sure why the ssh_jail_enabled check fails either

Any chance you have another instance of [sshd] in the jail file? If not, could you please send me the file so I can reproduce locally? You can find my email on auditvps.com if you don't want to share it here.

As far as I can tell, it is sshd

I changed one of the check names yesterday and it seems you have an older version of the script. Please download the latest version and it should work!

I ran the one-liner from auditvps.com, could it be that the script wasn't updated there?

Any chance you have another instance of [sshd] in the jail file?

I don't believe so, I just added a very basic example, as I didn't have the file before the check.
greping "sshd" does however return two instances.

Are you checking for [sshd] or just sshd?

As far as I can tell, it is sshd

Mind sharing the output of systemctl is-active sshd please?

I ran the one-liner from auditvps.com, could it be that the script wasn't updated there?

Oops, I missed updating the check when it's skipped, apologies. Opening a PR now.

Are you checking for [sshd] or just sshd?

It's checking for [sshd] at the start of the line. Is there whitespace preceding it?

systemctl is-active sshd

inactive curious.

It's checking for [sshd] at the start of the line. Is there whitespace preceding it?

There's a blank link preceding it, that's it. No other whitespace.

inactive curious.

Interesting. What's output of systemctl list-units | grep -I ssh?

There's a blank link preceding it, that's it. No other whitespace.

I've tried reproducing with the contents in the image but I'm unable to. Mind sending me the entire file? There shouldn't be anything sensitive in it (but please double check before you do!). You can send it via email<EMAIL_ADDRESS>if you prefer.

systemctl list-units | grep -I ssh

You can send it via email<EMAIL_ADDRESS>if you prefer.

Sent

@JapSeyz I think I was able to fix them both and I updated the script on the server. Can you please try again?

Fantastic! Thank you for helping make it more robust 🙏
Closing as it's resolved!


[Reimplementation] YOLOX bbox pred using t,l,r,b format always produce loss_bbox: 5.0

Prerequisite

[X] I have searched Issues and Discussions but cannot get the expected help.
[X] I have read the FAQ documentation but cannot get the expected help.
[X] The bug has not been fixed in the latest version (master) or latest version (3.x).

💬 Describe the reimplementation questions
I replace _bbox_decode function in YOLOX like this:
    def _bbox_decode(self, priors, bbox_preds):
        tl_x = priors[..., 0] - bbox_preds[..., 0]
        tl_y = priors[..., 1] - bbox_preds[..., 1]
        br_x = priors[..., 0] + bbox_preds[..., 2]
        br_y = priors[..., 1] + bbox_preds[..., 3]
        return torch.stack([tl_x, tl_y, br_x, br_y], dim=-1)

My config:
_base_ = [
    '../configs/yolox/yolox_s_8x8_300e_coco.py'
]

# dataset settings
dataset_type = 'CocoDataset'
data_root = 'path'

img_norm_cfg = dict(
    mean=[123.675, 116.28, 103.53], std=[58.395, 57.12, 57.375], to_rgb=True)
train_pipeline = [
    dict(type='LoadImageFromFile'),
    dict(type='LoadAnnotations', with_bbox=True),
    dict(type='Resize', img_scale=(1333, 800), keep_ratio=True),
    dict(type='RandomFlip', flip_ratio=0.5),
    dict(type='Normalize', **img_norm_cfg),
    dict(type='Pad', size_divisor=32),
    dict(type='DefaultFormatBundle'),
    dict(type='Collect', keys=['img', 'gt_bboxes', 'gt_labels']),
]
test_pipeline = [
    dict(type='LoadImageFromFile'),
    dict(
        type='MultiScaleFlipAug',
        img_scale=(1333, 800),
        flip=False,
        transforms=[
            dict(type='Resize', keep_ratio=True),
            dict(type='RandomFlip'),
            dict(type='Normalize', **img_norm_cfg),
            dict(type='Pad', size_divisor=32),
            dict(type='ImageToTensor', keys=['img']),
            dict(type='Collect', keys=['img']),
        ])
]
data = dict(
    _delete_=True,
    samples_per_gpu=8,
    workers_per_gpu=4,
    train=dict(
        type=dataset_type,
        ann_file=data_root + 'annotations/instances_minitrain2017.json',
        img_prefix=data_root + 'train2017/',
        pipeline=train_pipeline),
    val=dict(
        type=dataset_type,
        ann_file=data_root + 'annotations/instances_val2017.json',
        img_prefix=data_root + 'val2017/',
        pipeline=test_pipeline),
    test=dict(
        type=dataset_type,
        ann_file=data_root + 'annotations/instances_val2017.json',
        img_prefix=data_root + 'val2017/',
        pipeline=test_pipeline)
)
evaluation = dict(interval=1, metric='bbox')

# optimizer
optimizer = dict(_delete_=True, type='SGD', lr=0.02, momentum=0.9, weight_decay=0.0001)
optimizer_config = dict(_delete_=True, grad_clip=None)
# learning policy
lr_config = dict(
    _delete_=True,
    policy='step',
    warmup='linear',
    warmup_iters=500,
    warmup_ratio=0.001,
    step=[8, 11])
runner = dict(type='EpochBasedRunner', max_epochs=12)

My result:
2022-10-25 09:29:29,856 - mmdet - INFO - Epoch [1][50/1564]	lr: 1.978e-03, eta: 1:15:21, time: 0.242, data_time: 0.070, memory: 10625, loss_cls: 0.9370, loss_bbox: 5.0000, loss_obj: 14.5174, loss: 20.4544
2022-10-25 09:29:38,077 - mmdet - INFO - Epoch [1][100/1564]	lr: 3.976e-03, eta: 1:03:09, time: 0.164, data_time: 0.019, memory: 10625, loss_cls: 0.7869, loss_bbox: 5.0000, loss_obj: 7.7109, loss: 13.4978
2022-10-25 09:29:47,287 - mmdet - INFO - Epoch [1][150/1564]	lr: 5.974e-03, eta: 1:01:02, time: 0.184, data_time: 0.018, memory: 10625, loss_cls: 0.6463, loss_bbox: 5.0000, loss_obj: 6.0049, loss: 11.6513
2022-10-25 09:29:55,211 - mmdet - INFO - Epoch [1][200/1564]	lr: 7.972e-03, eta: 0:57:55, time: 0.158, data_time: 0.019, memory: 10625, loss_cls: 0.5865, loss_bbox: 5.0000, loss_obj: 5.3746, loss: 10.9611
2022-10-25 09:30:03,355 - mmdet - INFO - Epoch [1][250/1564]	lr: 9.970e-03, eta: 0:56:15, time: 0.163, data_time: 0.019, memory: 10625, loss_cls: 0.3879, loss_bbox: 5.0000, loss_obj: 5.0617, loss: 10.4496
2022-10-25 09:30:12,697 - mmdet - INFO - Epoch [1][300/1564]	lr: 1.197e-02, eta: 0:56:20, time: 0.187, data_time: 0.017, memory: 10692, loss_cls: 0.3199, loss_bbox: 5.0000, loss_obj: 5.3904, loss: 10.7103

Environment
sys.platform: linux
Python: 3.9.12 (main, Apr  5 2022, 06:56:58) [GCC 7.5.0]
CUDA available: True
GPU 0,1: NVIDIA GeForce RTX 3090
CUDA_HOME: /usr/local/cuda
NVCC: Cuda compilation tools, release 11.8, V11.8.89
GCC: gcc (Ubuntu 9.4.0-1ubuntu1~20.04.1) 9.4.0
PyTorch: 1.10.1
PyTorch compiling details: PyTorch built with:

GCC 7.3
C++ Version: 201402
Intel(R) oneAPI Math Kernel Library Version 2021.4-Product Build 20210904 for Intel(R) 64 architecture applications
Intel(R) MKL-DNN v2.2.3 (Git Hash 7336ca9f055cf1bfa13efb658fe15dc9b41f0740)
OpenMP 201511 (a.k.a. OpenMP 4.5)
LAPACK is enabled (usually provided by MKL)
NNPACK is enabled
CPU capability usage: AVX512
CUDA Runtime 11.3
NVCC architecture flags: -gencode;arch=compute_37,code=sm_37;-gencode;arch=compute_50,code=sm_50;-gencode;arch=compute_60,code=sm_60;-gencode;arch=compute_61,code=sm_61;-gencode;arch=compute_70,code=sm_70;-gencode;arch=compute_75,code=sm_75;-gencode;arch=compute_80,code=sm_80;-gencode;arch=compute_86,code=sm_86;-gencode;arch=compute_37,code=compute_37
CuDNN 8.2
Magma 2.5.2
Build settings: BLAS_INFO=mkl, BUILD_TYPE=Release, CUDA_VERSION=11.3, CUDNN_VERSION=8.2.0, CXX_COMPILER=/opt/rh/devtoolset-7/root/usr/bin/c++, CXX_FLAGS= -Wno-deprecated -fvisibility-inlines-hidden -DUSE_PTHREADPOOL -fopenmp -DNDEBUG -DUSE_KINETO -DUSE_FBGEMM -DUSE_QNNPACK -DUSE_PYTORCH_QNNPACK -DUSE_XNNPACK -DSYMBOLICATE_MOBILE_DEBUG_HANDLE -DEDGE_PROFILER_USE_KINETO -O2 -fPIC -Wno-narrowing -Wall -Wextra -Werror=return-type -Wno-missing-field-initializers -Wno-type-limits -Wno-array-bounds -Wno-unknown-pragmas -Wno-sign-compare -Wno-unused-parameter -Wno-unused-variable -Wno-unused-function -Wno-unused-result -Wno-unused-local-typedefs -Wno-strict-overflow -Wno-strict-aliasing -Wno-error=deprecated-declarations -Wno-stringop-overflow -Wno-psabi -Wno-error=pedantic -Wno-error=redundant-decls -Wno-error=old-style-cast -fdiagnostics-color=always -faligned-new -Wno-unused-but-set-variable -Wno-maybe-uninitialized -fno-math-errno -fno-trapping-math -Werror=format -Wno-stringop-overflow, LAPACK_INFO=mkl, PERF_WITH_AVX=1, PERF_WITH_AVX2=1, PERF_WITH_AVX512=1, TORCH_VERSION=1.10.1, USE_CUDA=ON, USE_CUDNN=ON, USE_EXCEPTION_PTR=1, USE_GFLAGS=OFF, USE_GLOG=OFF, USE_MKL=ON, USE_MKLDNN=ON, USE_MPI=OFF, USE_NCCL=ON, USE_NNPACK=ON, USE_OPENMP=ON,

TorchVision: 0.11.2
OpenCV: 4.6.0
MMCV: 1.5.0
MMCV Compiler: GCC 7.3
MMCV CUDA Compiler: 11.3
MMDetection: 2.25.1+1b4891c
Expected results
Normal YOLOX bbox pred, same config, different bbox_decode function:
2022-10-25 09:30:40,552 - mmdet - INFO - Epoch [1][50/1564]	lr: 1.978e-03, eta: 1:15:08, time: 0.241, data_time: 0.069, memory: 10627, loss_cls: 1.6528, loss_bbox: 4.7309, loss_obj: 12.7018, loss: 19.0855
2022-10-25 09:30:48,810 - mmdet - INFO - Epoch [1][100/1564]	lr: 3.976e-03, eta: 1:03:09, time: 0.165, data_time: 0.020, memory: 10627, loss_cls: 1.8888, loss_bbox: 4.4457, loss_obj: 5.9525, loss: 12.2871
2022-10-25 09:30:58,025 - mmdet - INFO - Epoch [1][150/1564]	lr: 5.974e-03, eta: 1:01:03, time: 0.184, data_time: 0.018, memory: 10627, loss_cls: 2.3753, loss_bbox: 4.0260, loss_obj: 5.8119, loss: 12.2131
2022-10-25 09:31:05,916 - mmdet - INFO - Epoch [1][200/1564]	lr: 7.972e-03, eta: 0:57:52, time: 0.158, data_time: 0.019, memory: 10627, loss_cls: 2.4342, loss_bbox: 3.9371, loss_obj: 5.5452, loss: 11.9165

Additional information
No response

@iumyx2612 Why do you want to modify this place? If you want to refer to the FCOS pattern, you should consider *strides

@iumyx2612 Why do you want to modify this place? If you want to refer to the FCOS pattern, you should consider *strides

I want to change the bounding box representation of YOLOX to act like FCOS, but somehow it's not working and I don't know why.

you should consider `*strides
Can you explain more about this?

If this can be helpful, I wrote a script to visualize the label assignment process of simOTA.
I ran this on a test dataset here: https://public.roboflow.com/object-detection/synthetic-fruit
This is YOLOX using new _bbox_decode function, which decode like FCOS:
iter 1:

iter 11:

iter 31:

The bigger the dot, the higher the feature pyramid scale it belongs to (bigger stride)
And this is normal YOLOX with normal _bbox_decode:
iter 1:

iter 11:

iter 31:

@iumyx2612 Thank you very much for your feedback. Are all the implementation details included in the issue? I'll debug it when I'm free

@iumyx2612 Thank you very much for your feedback. Are all the implementation details included in the issue? I'll debug it when I'm free

Yes, I only modified :func: _bbox_decode of YOLOXHead.
Also, when training, the config dataset, data pipeline, optimizer, scheduler, etc. is the same with _base_ config (ie. img_size when resize, not apply Mosaic,...)
If you need the code for simOTA visualization, I'm willing to share too

close or open 'with_stride' in get priors function may help you

close or open 'with_stride' in get priors function may help you

I keep 'with_stride, since SimOTAAssigner requires priors to have format [cx, xy, stride_w, stride_y]  The only difference I made is on line 381: https://github.com/open-mmlab/mmdetection/blob/master/mmdet/models/dense_heads/yolox_head.py#L381   which I implement another_bbox_decode` function, like FCOS

Do you miss exp(box_pred) after conv? This is done in FCOS' forward but YOLOX' post processing.

Do you miss exp(box_pred) after conv? This is done in FCOS' forward but YOLOX' post processing.

I don't think it plays an important role here? Since exp(bbox_pred) is only used on FCOS without norm_on_bbox, FCOS with norm_on_bbox directly normalizes bbox_pred with strides instead of using `exp. If I'm wrong please correct me

FCOS use different loss for different box-encoding settings.

@hhaAndroid please notify me when you starting working on this :bowing_man:

@iumyx2612非常感谢您的反馈。问题中是否包含所有实施细节？我会在有空的时候调试它

是的，我只修改_bbox_decode了 YOLOXHead。 此外，在训练时，配置数据集、数据管道、优化器、调度器等与_base_配置相同（即调整大小时的 img_size，不应用马赛克，...） 如果您需要 simOTA 可视化的代码，我是也愿意分享

@iumyx2612 Thank you very much for your feedback. Are all the implementation details included in the issue? I'll debug it when I'm free

Yes, I only modified _bbox_decode of YOLOXHead. Also, when training, the config dataset, data pipeline, optimizer, scheduler, etc. is the same with _base_ config (ie. img_size when resize, not apply Mosaic,...) If you need the code for simOTA visualization, I'm willing to share too

Hi I want get the code for simOTA visualization,can you share it with me, thanks

@iumyx2612非常感谢您的反馈。问题中是否包含所有实施细节？我会在有空的时候调试它

是的，我只修改_bbox_decode了 YOLOXHead。 此外，在训练时，配置数据集、数据管道、优化器、调度器等与_base_配置相同（即调整大小时的 img_size，不应用马赛克，...） 如果您需要 simOTA 可视化的代码，我是也愿意分享

@iumyx2612 Thank you very much for your feedback. Are all the implementation details included in the issue? I'll debug it when I'm free

Yes, I only modified _bbox_decode of YOLOXHead. Also, when training, the config dataset, data pipeline, optimizer, scheduler, etc. is the same with _base_ config (ie. img_size when resize, not apply Mosaic,...) If you need the code for simOTA visualization, I'm willing to share too

Hi I want get the code for simOTA visualization,can you share it with me, thanks

Hello, I implement the simOTA visualization as a Hook. You can check it out here:
https://github.com/main-2983/sun-det/blob/end-to-end/mmdet/core/hook/base_label_assignment_vis_hook.py
https://github.com/main-2983/sun-det/blob/end-to-end/mmdet/core/hook/base_simOTA_vis_hook.py


[Monitor] add Pipelines

First pass at using canary tagged releases (currently unpublished) with the opentelemetry-exporter CI.
Eventually, something similar could be done here with the already built-out integration tests for each client sdk
PR Overview

(ci.yml): Run npm run unit-test PR/CI
(tests.yml): Run noop npm run integration-test
(tests.yml): Run monitor-extra-steps.yml

@markwolff  if you want to run these steps after the integration tests for all packages, and to check if it's being run as expected you can run a live test pipeline (maybe do keyvault since it takes the lease amount of time) and test it

@markwolff CI is failing for monitor package. As per the error, it looks like package.json is missing pack command. https://dev.azure.com/azure-sdk/internal/_build/results?buildId=508760&view=logs&j=3dc8fd7e-4368-5a92-293e-d53cefc8c4b3&t=26452410-bb74-52b8-246c-3b6de8b4706f&l=61


[BUG] - GameTick Error After Achievements Update with Advanced Miner

Describe the bug
To Reproduce
Load this save: https://mega.nz/file/NUl1VaJI#3AmzWqk1_9QgaZf_yaV5f72dPp2B9NVcnmYOPneuehU - note that it requires the mod Compress Save and MegaSystems to load successfully - using the most recent game version and the Advanced Miner mod.
Expected behavior
The game should not throw an exception due to existing miner MK2 entities, on every game tick, as soon as the save loads
Log files
Doesn't appear to contain any relevant information, but here it is:
[Message:   BepInEx] BepInEx <IP_ADDRESS> - DSPGAME (2/6/2021 5:29:10 PM)
[Info   :   BepInEx] Running under Unity v2<IP_ADDRESS>89476
[Info   :   BepInEx] CLR runtime version: 4.0.30319.17020
[Info   :   BepInEx] Supports SRE: False
[Info   :   BepInEx] System platform: Bits64, Windows
[Message:   BepInEx] Preloader started
[Info   :   BepInEx] Loaded 1 patcher method from [BepInEx.Preloader <IP_ADDRESS>]
[Info   :   BepInEx] 1 patcher plugin loaded
[Info   :   BepInEx] Patching [UnityEngine.CoreModule] with [BepInEx.Chainloader]
[Message:   BepInEx] Preloader finished
[Message:   BepInEx] Chainloader ready
[Message:   BepInEx] Chainloader started
[Info   :   BepInEx] 0 plugins to load
[Message:   BepInEx] Chainloader startup complete

Screenshot

Additional context

I was able to workaround the issue by loading the save without the mod, but that removed all advanced miners from my save (thankfully only started using them on 1 planet).
Re-adding the mod later does not bring back the issue, including when placing new advanced miners, saving, and reloading. So the mod is usable, but didn't like the transition to the new version.
I tried disabling every other mod except this one and was still lexperiencing the issue, so despite not having any hint that this mod is the cause from the error message, I'm fairly confident that it is.

Thanks for reporting. I just spent an hour trying to figure out the cause of this issue without success. I will check later if your save will allow me to reproduce, as so far I was unable to reproduce it.

No problem, it's very consistent on my save, everytime I load it I get the issue, with no other mods than CompressSave, AdvancedMiner (and LDBTool and Bepinex required as dependencies) and MegaSystems.
I forgot to mention the mod https://dsp.thunderstore.io/package/pthcon/MegaSystems/ in my bug report (updated and fixed). I don't think it is the cause of the issue, but it's required for the save file to load properly.
I hope it gives you a path to resolve the issue!
To anybody else experiencing this issue, please note there is a way to fix the issue without replacing all the miners manually:

Remove the mod from the game
Load the save, which will remove the miners MK2 from your worlds but only temporarily, and will fix the error happening on every game tick
Create a new save immediately with the mod removed.
Quit the game
Re-enable the mod
Reload your save, you should not see the error anymore, and the miners MK2 should be back!

Ok. In your particular case this error is not actually caused by this mod. Its caused by Smelter mk2 mod, that you later removed, but its id was left in the data. Apparently my mod somehow causes for the error to happen. Anyway, i have decided to suppress this error. Should now be fixed.

 Thank you so much, and sorry for mis-identifying the issue, but if that makes it possible to get your mod a little more robust then all the better!
Again, thank you for your work!


Add Couchbase Testcontainer

Couchbase Server is an open source, distributed, JSON document database. In dotnet-testcontainers project there is some pre-configured containers for easy to use.
The issue is add couchbase testcontainer as pre-configured container.
This container should provide following features;

Create initial cluster and create customizable admin user with environment parameter
Create initial bucket or buckets
Add startup strategy for Couchbase
Create bucket function
Flush bucket function

We should merge #261. Based on the existing example configurations you can create the configuration for Couchbase. This should be pretty straight forward. It would be nice if you keep the other configurations in mind and share patterns, use interfaces, etc.

Closed #296, #298.


Add support for a 'closest' focus-in strategy in FocusZone.

This adds a new focusInStrategy option to focusZone called "closest". It is useful in the upcoming Dialog component.

Setting focusInStrategy to "closest" will cause either the first or last focusable element in the container to be focused depending on the direction of focus movement (for example, a shift+tab that brings focus to the container will cause the last focusable element to be focused, whereas a regular tab would cause the first focusable element to be focused).

Tested: Chrome, FF, Safari
Unit tests added
Documentation updated

Copying some lightly-edited Q&A from Slack, for future reference:

Q. Could we get rid of "first" (in favor of "closest")? Are we considering a specific use case for each, or supporting both due to a general philosophy favoring configuration and choice?
A. PRC balances YAGNI with flexibility to support component consumers. PRC paves paths, but “paths” is plural.

Q. Conversely, should we get rid of "closest" (in favor of "first")? "closest" was partly added to support focusing a layered component’s last element in response to ShiftTab. Is this a behavior users would expect? Or do layered components have modality (i.e. new focus order contexts)?
A. "closest" supports buttons in the Dialog footer.

And a suggestion for future documentation:

In addition to describing what the behavior of "first" and "closest" is (as this PR does), also describe when/in which context each behavior is appropriate.


Add new features, improve metadata and add many tests

The detailed descriptions will be put on a new release.

It will be merged locally.


Support React v16.3 context API

Function as children components are becoming very popular. In React v16.3 the new context API uses this pattern.
How do you walk into the children functions, so you can keep recursing the tree and visit deeper components?
For context, I am attempting to SSR Query components in graphql-react.

Ok, so it turns out my issue is not with function as children components.
With a simple test eventually foobar logs as the deepest node, as expected:
const TestComponent = ({ children }) => children('foobar')
const tree = <TestComponent>{message =>
{message}
}</TestComponent>

reactTreeWalker(
  tree,
  element => {
    console.log(element)
    return true
  }
)

What does not work is Consumer from the new React context API:
const { Provider, Consumer } = React.createContext()
const tree = (
  <Provider value={{ message: 'foobar' }}>
    <Consumer>{({ message }) =>
{message}
}</Consumer>
  </Provider>
)

reactTreeWalker(
  tree,
  element => {
    console.log(element)
    return true
  }
)

The deepest node is logged as [Function]. Basically, the logic incorrectly thinks Consumer is a basic string or dom node element.

Looks like this is ready to be worked on 😀
https://github.com/apollographql/react-apollo/pull/1742/files#diff-f8938b597e7a7647b9ea5589d55d3a26
@jaydenseric are you happy with running with this?

@ctrlplusb thanks, but I've already worked it out in graphql-react: https://github.com/jaydenseric/graphql-react/blob/master/src/preload.mjs#L96

@ctrlplusb Can I come back to the original question at the start of the thread by @jaydenseric:

How do you walk into the children functions, so you can keep recursing the tree and visit deeper components?

What is the expected behavior here?

Has anyone taken this up? Would really like to convert a project using tree-walker to use new React context.

@ctrlplusb I tried something, maybe the PR can serve as a starting point?

Just merged @dan-lee's and published work on this. 🎉


Searched bookmark persisted during search after removing all

Steps to repro:

Add bookmark (eg. Moya/Moya)
Search in Bookmarks (for something matching that bookmark, in this case eg. "M")
Clear all bookmarks

Expected: bookmarks are removed, also from the filter
Actual: bookmark stays until dismissing search
(Latest TF, v1.12.0 (1079)), iPhone 7 Plus

Fixed with #720


fix crash when pasting an empty text into the editor

closes #445

fix crash when pasting an empty text into the editor
add watch only wallet sync card to overview page
fix hover color for setting options on start page
fix watch only wallet balance not being accounted for
show wallet name in the editor while trying to rename wallet
fix a bug where address discovery was not marked as completed for watch only wallets

fix watch only wallet balance not being accounted for

Why we need it? May be watch only wallet is not of them. Additional, if you want to add watch only wallet balance, it should is option and can setup on app setting

Why we need it?

users are asking for it.

can setup on app setting

we can do this in a different pr, or if users request for it