Use System.Text.Json in JSON Schema generator

Open questions:

How can we reflect over the used contracts (replacement for Newtonsoft.Json's contract resolver)?

=> currently this feature is completely missing in System.Text.Json and we need to use reflection and manually implement the same rules in the schema generator (suboptimal)

NJS might reference System.Text.Json and Newtonsoft.Json at the same time to support both libraries depending on a setting

E.g. you either set a Newtonsoft.Json contract resolver/serializer settings or System.Text.Json settings/contract metadata

System.Text.Json is only .NET Standard 2.0 but NJS supports .NET Standard 1.0 and .NET 4.0

Lots of #if and System.Text.Json support will not be active in all target frameworks (will throw NotSupportedExceptions otherwise)

Current implementation (NJS 10.1.15+, NSwag v13.5.0+):

[x] Currently NJS uses reflection only to support System.Text.Json (no direct dependency)
[x] Support for JsonStringEnumConverter
[x] Support for JsonPropertyNameAttribute
[x] Support for (custom) PropertyNamingPolicy
[ ] Json.NET attributes should be ignored when using System.Text.Json (in the custom SystemTextJsonContractResolver), https://github.com/RicoSuter/NSwag/issues/2762
[ ] Currently not supported features: Probably some of the new attributes are currently not supported: https://github.com/RicoSuter/NJsonSchema/issues/1013

See https://github.com/RicoSuter/NJsonSchema/blob/master/src/NJsonSchema/Generation/SystemTextJsonUtilities.cs

/cc @steveharter @joshfree is there already a replacement for the contract resolver available? I once saw some related classes but they were internal (no access to metadata)...

For 3.0 there are no public APIs to return the metadata. These were considered but considered out of scope for this release because we are focusing on a minimum viable product for mainstream scenarios.
I'd like to expose the metadata, which would also be required for a new type of "converter" that I would like to add. The new converter would handle some scenarios the existing one can't.

Ok. As long as metadata is not exposed by System.Text.Json we cannot support this new library in NJsonSchema (JSON Schema generation) and NSwag (Swagger/OpenAPI) - so this might be a huge blocker for people who want to use the new serializer in ASP.NET Core AND OpenAPI.
The solution for now is to use System.Text.Json for serialization and add NSwag with a Newtonsoft.Json contract resolver which resembles the System.Text.Json serializer behavior...

I thought System.Text.Json was .NET Standard 2.1, not 2.0... If so, it wouldn't run on .NET Framework at all.

It seems to support .net standard 2.0:
https://www.nuget.org/packages/System.Text.Json/4.6.0-preview6.19303.8

I was thinking it used Span and made use of new things in the .NET Core runtime which they weren't going to add to .NET Framework. Maybe I'm confusing that with the latest C# language features that they added which will not be supported on .NET Framework.

I was wrong about that. It says here https://devblogs.microsoft.com/dotnet/try-the-new-system-text-json-apis/ that it works with .NET Framework.

.NET Standard 1.0 has been end of support therefore I think there's no need to support .NET Standard 1.x.

That may be, but, don't expect people to move off .NET Standard 2.0 anytime soon.

You can multi-target your library to resolve it:
in .csproj file:
<Project Sdk="Microsoft.NET.Sdk">

  <PropertyGroup>
    <TargetFrameworks>netstandard1.4;netstandard2.0;netstandard2.1</TargetFrameworks>
  </PropertyGroup>

  <ItemGroup>
    <PackageReference Condition="'$(TargetFramework)' == 'netstandard2.1'" Include="System.Text.Json" Version="4.6.0" />
    <PackageReference Include="Newtonsoft.Json" Version="12.0.2" />
  </ItemGroup>
</Project>

in .cs file
#if NETCOREAPP3_0 || NETSTANDARD2_1
....
#else
...
#endif

Thx, but referencing the library is the small problem, the blocker is this:
https://github.com/RicoSuter/NJsonSchema/issues/1014#issuecomment-504420986

@RicoSuter - are you able to provide any more info on the solution for now? How do I add NSwag with a Newtonsoft.Json contract resolver?

If you call AddOpenApiDocument() without using Newtonsoft in ASP.NET Core itself, it should still work but with a the default contract resolver. If the default contract resolver does not reflect what the actual serializer is doing, then you need to change the contract resolver so that it reflects the serializers (in the AddOpenApiDocument(options => options.SerializerSettings = ...)

I think at least NJsonSchema should recognize JsonIgoreAttribute and other attributes in System.Text.Json while generating OpenApi schema.

JsonIgoreAttribute from System.Text.Json?

JsonIgoreAttribute from System.Text.Json?

Sorry, that is a typo. It should be JsonIgnoreAttribute.
https://github.com/dotnet/runtime/blob/b0351370ccd132d95c97b75312fc36adaacc2664/src/libraries/System.Text.Json/ref/System.Text.Json.cs#L767

JsonIgnoreAttribute isn't the only one that needs to be supported, here are other examples:

JsonExtensionDataAttribute : Same as JSON.Net, but only takes a Dictionary<string,object> or a Dictionary<string, JsonElement>. In the latter case, JsonElement should not be included in the generated schema.
JsonPropertyNameAttribute can be used to give the property a new name, the same way as JSON.NET's [JsonProperty]

and I probably missed other attributes...

Ref: https://github.com/RicoSuter/NSwag/pull/2655

We'd need to implement a custom Newtonsoft contract resolver which reads the System.Text.Json options and attributes and correctly maps them... see
https://github.com/RicoSuter/NJsonSchema/blob/master/src/NJsonSchema/SystemTextJsonUtilities.cs#L33

Ref: https://github.com/RicoSuter/NJsonSchema/pull/1173/commits/5981ecb1cb4810a111e4c17940e821601e486a3a

@steveharter is there already a roadmap for serializer metadata discover (contract resolver)? Otherwise we need to use reflection and reimplement all your rules manually in the schema generator... (I really want to avoid that).

@RicoSuter Are there any additional steps where you could use some help? I would like to update my F# wrapper with support for F# types to use the System.Text.Json support and would be happy to try to help get this over the finish line.

@panesofglass thanks for your post.
Currently we map the System.Text.Json “rules” manually to the newtonsoft metadata with a custom contract resolver.
https://github.com/RicoSuter/NJsonSchema/blob/master/src/NJsonSchema/Generation/SystemTextJsonUtilities.cs#L45
This is a quick solution for now until STJ offers metadata directly. There are probably lots of edge cases and attributes missing... would be great if someone could help complete this (also more unit tests needed). Apart from that you can just set the SerializerOptions property on the generator settings and it will use these rules.
https://github.com/RicoSuter/NJsonSchema/blob/master/src/NJsonSchema/Generation/JsonSchemaGeneratorSettings.cs#L114
What is missing for you?

I don’t know whether anything is missing. I was uncertain whether this had been released, but it seems it has? I’m happy to look into adding some tests.

I have not yet added tests to this repo, but I've been able to switch to System.Text.Json in the other project. I'll still try to get back to adding tests here.

Ref
https://github.com/RicoSuter/NJsonSchema/pull/1333
https://github.com/RicoSuter/NJsonSchema/pull/1331


Covid_19_Protein_Study_3D_Graph

Earlier this year, I noticed the appearance of new/possibly mutated COVID proteins. Performed on PLOTLY


hardware requirement of training

what kind of hardware do you use for training ?

All the training is performed on 32G V100. The memory usuage is largely dependent on the max_prompt (max foreground classes to train with for this iteration) since it is the actual "batch_size".  Reducing this number will reduce memory usage but take longer to converge for dataset with >100 foreground classes.

so you use 8 v100 ?
And do you generate pesudo labels using models from total segmentator? what if the model is not accurate.


Generic interface for feature extractors

Build interface for feature extractor shared across collections.

Initial interface merged to master as part of commit 9775cfea8aa20a9e05c1aa8f62e6a8fed40e5817


docs(Halyard): improvements to Install Halyard

#697

@joonlim, for you to test

Tested "Install Halyard on Docker" and "Update Halyard on Docker" flows and they work well.
One suggestion I have is that we may want to tell users how to run halyard in detached mode in case they are not interested in the logs:
docker run -p 8084:8084 -p 9000:9000 \
    --name halyard --rm \
    -v ~/.hal:/home/spinnaker/.hal \
    -d \
    gcr.io/spinnaker-marketplace/halyard:stable

Personally, if I were installing halyard for the first time, I would be wondering why I would care about the logs at all.

@joonlim that's fair - we can always ask them to restart w/ logging to help them fix an issue


Label comparison screenshot

I think it's useful to label which frame of the comparison gif uses which syntax theme:

GitHub css resizes the gif width-wise; looks nice if you open the gif in a separate tab.

Derp. I didn't even label it in the README.

@zertosh You can take the gif if you want. Or do your own preferred labelling.

@Dashed ugh. now it decides to autocomplete. first time ever. weird.


New SPFx My Flows and new Improvements on React-Directory

Q
A

Bug fix?
no

New feature?
no

New sample?
yes

What's in this Pull Request?

New SPFx sample Web Part MyFlows and new improvements on React-Directory Web Part

Hi @joaojmendes,
Any chance you could split the new My Flow sample and the improvements to the React Directory sample to separate PRs? That'd adhere our contribution guidelines and help us review your PRs. Thank you very much! Looking forward to merging your changes. :)
Laura

Hi @Laura<EMAIL_ADDRESS>I created 3 PR’s

My-flows webpart (New Sample)
Update React-Directory webpart
Fixe to React-Manage Site Designs

Thank you very much for your support .
Have a nice weekend
João
From: Laura Kokkarinen<EMAIL_ADDRESS>Reply to: SharePoint/sp-dev-fx-webparts<EMAIL_ADDRESS>Date: Saturday, 24 August 2019 at 17:51
To: SharePoint/sp-dev-fx-webparts<EMAIL_ADDRESS>Cc: joaojmendes<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [SharePoint/sp-dev-fx-webparts] New SPFx My Flows and new Improvements on React-Directory (#944)
Hi @joaojmendeshttps://github.com/joaojmendes,
Any chance you could split the new My Flow sample and the improvements to the React Directory sample to separate PRs? That'd adhere our contribution guidelines and help us review your PRs. Thank you very much! Looking forward to merging your changes. :)
Laura
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/SharePoint/sp-dev-fx-webparts/pull/944?email_source=notifications&email_token=AC7YHVKBH2JTS7CI3JBZFIDQGFRJXA5CNFSM4IL75FFKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5CDV7Y#issuecomment-524565247, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AC7YHVO4GT3N4ZCRVLRLF73QGFRJXANCNFSM4IL75FFA.


Evaluate exception: false *_nonblock APIs

Ruby 2.1 added APIs to perform asynchronous I/O without using exceptions:
io.read_nonblock(n, exception: false)

I've seen reports of this affording a 2x speedup in async I/O performance, at least on MRI.
I do not know the status of this API on JRuby et al (cc @headius)

@tarcieri I'm having the issue that nonblocking reads with exception: false are not returning anything meaningful. The documentation states that it will return :wait_readable , but nothing about eof's. Should one assume that if the buffer is empty, it is an EOFError ?

I believe it returns nil on EOF.
You might take a look at the way I did this in http.rb. I was able to eliminate a lot of the redundancy that exists in the implementation in this PR:
https://github.com/httprb/http/blob/master/lib/http/timeout/global.rb#L84

It worked :+1: adapted/copy-pasted your perform_io method to the stream class. Will try to do something similar for the UDPSocket case. But this one seemed to do the trick. Fancy a review when you have the time? (not a lot changed, I guess).


Direct nearby uploads feature branch - code cleanup

I just made a quick pass through the feature branch and did some code cleanup -

Removed dead / redundant code
Removed unused imports
Converted anonymous inner classes to Java 8 lambdas
Reduced feature envy + cleaned up code - LatLng formats its own GmmIntentUri and removed redundant object creation
Reduced feature envy + cleaned up code - Place knows if it has various site links, cleaning up code that uses them

Tested on Android 7.0, works well for me. Thanks @psh !

Edit: Oh, whoops, the sitelinks for Wikidata and Wikipedia etc stopped working after the merge (I hadn't thought to test them beforehand). :/
12-31 01:12:45.050: D/HTTPRequest(8893): [HTTP] Request with response code = 304: No additional information
@psh could you look into this please?

The particular network requests in question originate from mapbox - asking (for instance) for a map tile with a URL like https://maps.wikimedia.org/osm-intl/13/2042/3140.png and indicate that the caching is working correctly - mapbox on your phone asked for tiles that were cached in each case of the 304 status (an indicator from the server that that particular data item hasn't changed since the last 200 request).

Sorry, seems it was my connection messing up the second time I tried, lol. The links work perfectly now.
Thanks for clarifying the debug HTTP messages, I was wondering why I kept getting them.


Updating DM examples

copy() because of DM API changes
Use EMPAD reader
FIXME async prototype is currently broken, see Issue #399

Thanks, merged!


Items have wrong quantities and "Lock up"

EDIT
everything in this issue also applies to fluids
Issue description:
Items inserted into storage system in any way will have weird numbers (often multiples of 8) and often cant be retrieved after inserting them.
What happens:
lets say I put 64 cobblestone in a crafting grid. The grid will say I have 8 cobblestone and the cobblestone cant be retrieved after.
What you expected to happen:
I expected to get 64 cobblestone on screen and be able to take 64 cobblestone back out.
Steps to reproduce:

build RS system.
Insert item.
close grid.
Re-enter grid and see your wacky numbers and vanished items.

Version (make sure you are on the latest version before reporting):

Minecraft: 1.15.2
Forge: 31.1.37
Refined Storage: 1.8.1

Does this issue occur on a server? [yes/no]
If a (crash)log is relevant for this issue, link it here:
[pastebin/gist/etc link here]

What are you storing your items in?

The issue occurs when i store them in a wireless terminal or crafting grid
On Mon, Apr 6, 2020 at 6:04 AM Darkere<EMAIL_ADDRESS>wrote:

What are you storing your items in?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/raoulvdberge/refinedstorage/issues/2475#issuecomment-609699459,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AGU26GFCGGE34OPG42O4QFLRLGSJTANCNFSM4MBVUVJQ
.

I meant what the items are stored in. Inside a chest or in disks...

disks
On Mon, Apr 6, 2020 at 11:25 AM Darkere<EMAIL_ADDRESS>wrote:

I meant what the items are stored in. Inside a chest or in disks...
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/raoulvdberge/refinedstorage/issues/2475#issuecomment-609862941,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AGU26GFDQRCYIPSRBOMPZNDRLHX7VANCNFSM4MBVUVJQ
.

Can't reproduce this


Split the regression tests out for ease of adding more, later

Coverage decreased (-0.6%) to 97.541% when pulling 4cf6866799aa5831ba2b9b74ffff9321d50bd93d on RemixRegressionTests into 238f1f5ef727547aeaf604478084fbd17c575931 on master.


checkConn for badConn and alwaysNewConn(#2053)

#2053
check bad conn when getConn from pool and add maxBadConnRetries

It seems that the issue of #1849 was not resolved.

It seems that we should consider the database/sql solution(https://github.com/go-redis/redis/issues/1737#issuecomment-832434567):
func (db *DB) ExecContext(ctx context.Context, query string, args ...interface{}) (Result, error) {
	var res Result
	var err error
	for i := 0; i < maxBadConnRetries; i++ {
		res, err = db.exec(ctx, query, args, cachedOrNewConn)
		if err != driver.ErrBadConn {
			break
		}
	}
	if err == driver.ErrBadConn {
		return db.exec(ctx, query, args, alwaysNewConn)
	}
	return res, err
}

@vmihailenco  Do you have any comments?

It seems that we should consider the database/sql solution

We probably need both this change and database/sql-like retry approach. checkConn is about early detection of bad connections and we need it anyway.

We once made a mistake in SetDeadline and should add a check for it.

It looks good, we will add maxBadConnRetries, cachedOrNewConn , alwaysNewConn  later.


HMR not woks with symlinks

For example, stylus-loader not trigger update when @import= point to file inside symlinked directory

Could you please set up a small gist that demonstrates the error?

Could you please set up a small gist that demonstrates the error?

Yes, please keep loader influence at a minimum. Try to build the testcase with only js modules.


Peddy run error: AttributeError: 'DataFrame' object has no attribute 'ix'

Hi , everyone, I install peddy through conda [ conda install -y peddy ]

$ python -m peddy --plot -p 4 --prefix merge4fam merge4fam.vcf.gz merge4fam.ped
VCF header:
#CHROM  POS     ID      REF     ALT     QUAL    FILTER  INFO    FORMAT  A24173  A24173F A24173M C5140   C5140F  C5140M  P8491      P8491F  P8491M  P8505   P8505F  P8505M
ped file:
A24173fam       A24173  A24173F A24173M 2       1
A24173fam       A24173F 0       0       1       0
A24173fam       A24173M 0       0       2       0
C5140fam        C5140   C5140F  C5140M  2       1
C5140fam        C5140F  0       0       1       0
C5140fam        C5140M  0       0       2       0
P8491fam        P8491   P8491F  P8491M  2       1
P8491fam        P8491F  0       0       1       0
P8491fam        P8491M  0       0       2       0
P8505fam        P8505   P8505F  P8505M  1       1
P8505fam        P8505F  0       0       1       0
P8505fam        P8505M  0       0       2       0

Then I got the following error:
2020-03-20 10:40:48 dell-PowerEdge-R930 peddy.cli[31318] INFO Running Peddy version 0.4.3
Traceback (most recent call last):
File "/home/yu/anaconda3/lib/python3.7/runpy.py", line 193, in _run_module_as_main
"main", mod_spec)
File "/home/yu/anaconda3/lib/python3.7/runpy.py", line 85, in _run_code
exec(code, run_globals)
File "/home/yu/anaconda3/lib/python3.7/site-packages/peddy/main.py", line 14, in
sys.exit(cli())
File "/home/yu/anaconda3/lib/python3.7/site-packages/click/core.py", line 764, in call
return self.main(*args, **kwargs)
File "/home/yu/anaconda3/lib/python3.7/site-packages/click/core.py", line 717, in main
rv = self.invoke(ctx)
File "/home/yu/anaconda3/lib/python3.7/site-packages/click/core.py", line 956, in invoke
return ctx.invoke(self.callback, **ctx.params)
File "/home/yu/anaconda3/lib/python3.7/site-packages/click/core.py", line 555, in invoke
return callback(*args, **kwargs)
File "/home/yu/anaconda3/lib/python3.7/site-packages/peddy/cli.py", line 198, in peddy
ped_df = ped_df.ix[samples, :]
File "/home/yu/anaconda3/lib/python3.7/site-packages/pandas/core/generic.py", line 5274, in getattr
return object.getattribute(self, name)
AttributeError: 'DataFrame' object has no attribute 'ix'
Is there anything wrong with my vcf or ped file?

$ python -m peddy --plot -p 4 --prefix merge4fam merge4fam.vcf.gz merge.plink.fam
with same vcf
fam file:
A24173fam A24173 A24173F A24173M 2 1
A24173fam A24173F 0 0 1 0
A24173fam A24173M 0 0 2 0
C5140fam C5140 C5140F C5140M 2 1
C5140fam C5140F 0 0 1 0
C5140fam C5140M 0 0 2 0
P8491fam P8491 P8491F P8491M 2 1
P8491fam P8491F 0 0 1 0
P8491fam P8491M 0 0 2 0
P8505fam P8505 P8505F P8505M 1 1
P8505fam P8505F 0 0 1 0
P8505fam P8505M 0 0 2 0

Then I got the following same? error:
2020-03-20 10:56:48 dell-PowerEdge-R930 peddy.cli[31423] INFO Running Peddy version 0.4.3
2020-03-20 10:56:48 dell-PowerEdge-R930 peddy.cli[31423] WARNING 12 samples in vcf not in ped:
A24173,C5140,P8491,A24173F,P8491M,P8505,P8505M,P8505F,C5140F,C5140M,P8491F,A24173M
2020-03-20 10:56:48 dell-PowerEdge-R930 peddy.cli[31423] WARNING 1 samples in ped not in vcf:
nan
Traceback (most recent call last):
File "/home/yu/anaconda3/lib/python3.7/runpy.py", line 193, in _run_module_as_main
"main", mod_spec)
File "/home/yu/anaconda3/lib/python3.7/runpy.py", line 85, in _run_code
exec(code, run_globals)
File "/home/yu/anaconda3/lib/python3.7/site-packages/peddy/main.py", line 14, in
sys.exit(cli())
File "/home/yu/anaconda3/lib/python3.7/site-packages/click/core.py", line 764, in call
return self.main(*args, **kwargs)
File "/home/yu/anaconda3/lib/python3.7/site-packages/click/core.py", line 717, in main
rv = self.invoke(ctx)
File "/home/yu/anaconda3/lib/python3.7/site-packages/click/core.py", line 956, in invoke
return ctx.invoke(self.callback, **ctx.params)
File "/home/yu/anaconda3/lib/python3.7/site-packages/click/core.py", line 555, in invoke
return callback(*args, **kwargs)
File "/home/yu/anaconda3/lib/python3.7/site-packages/peddy/cli.py", line 198, in peddy
ped_df = ped_df.ix[samples, :]
File "/home/yu/anaconda3/lib/python3.7/site-packages/pandas/core/generic.py", line 5274, in getattr
return object.getattribute(self, name)
AttributeError: 'DataFrame' object has no attribute 'ix'
Actually the ped and fam files are same content, and I use same vcf files, but why the error info showed 2 more line than the first command?
please help me figure out the error reason, thanks!

hi, this is fixed in master, it happens due to deprecated use of ix. But master has conflicts in conda which I don't know how to fix. You can clone the repo and run python setup.py install

@brentp Thanks a lot. I download and reinstall peddy (v0.4.5), this bug was fixed!


Add LabelSelector to NamespaceSelector

Addresses:

https://github.com/stolostron/backlog/issues/23718

No E2E tests in this repo, so I might see about poking into current unit tests to add some higher-level NamespaceSelector tests, though everything seemed to be working in manual tests.


Publish 08/02/2021, 10:30 AM

Docs Build status updates of commit a50ae7f:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

exchange/docs-conceptual/app-only-auth-powershell-v2.md
:white_check_mark:Succeeded
View (exchange-ps)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


feat(demo): v0.14 support

This PR introduces support for Conduit v0.14.
Deployments targeting >=v0.14 now pull their images from docker.io.
Conduit UI v0.14 has yet to be released as of right now, therefore the image for it won't be available.
To verify deployment configuration revert commit 41a0b36f.

This one is no longer required as of #19 🪦.


quartata: Watch dateamillionaire.org

quartata requests the watch of the watch_keyword dateamillionaire.org. See the Metasmoke search here

!!/approve


Move socket specific code from requests.Session to requests.SocketHandler

This comes from a thought and discussion to make sockets more usable and have fewer errors when connecting to multiple services (HTTP, MQTT, etc.).
I have come up with the following proposed steps:

Move socket specific code from requests.Session to requests.SocketHandler

This is the Draft PR

Make requests.SocketHandler a singleton
Add some methods for better key<>socket handling, and helpers like get_open_keys()
Add tests for new methods and changes
Make sure Docs look good
At this point mark this PR as Ready for review
Update adafruit_esp32spi_socket.py to adafruit_esp32spi_socketpool.py

Since adafruit_esp32spi_socket.py returns a fake Socketpool it would be easier to follow code with more correct naming

Update Adafruit_CircuitPython_MiniMQTT to take SocketHandler in __init__ and use it
Add something like SocketHandler.lock_socket()

Which would make sure that you could always open a socket for a particular key: for example ("io.adafruit.com", 1883, "mqtt:") so you can always connect to AdafruitIO

More update thoughts to come

As a side-note, I would love to put SocketHandler in it's own library, but feel that would break so many examples and things people have made...

Here is the current coverage report:

I am also happy to tackle https://github.com/adafruit/Adafruit_CircuitPython_Requests/issues/128 and move the handling of _FakeSSLSocket into SocketHandler for when is_ssl is True and self._ssl_context is None

Tested with a M4 Feather Express + AirLift FeatherWing using:
import adafruit_esp32spi.adafruit_esp32spi_socket as pool

esp = adafruit_esp32spi.ESP_SPIcontrol(spi, esp32_cs, esp32_ready, esp32_reset)
ssl_context = adafruit_requests.create_fake_ssl_context(pool, esp)

socket_handler = adafruit_requests.SocketHandler(pool, ssl_context)
requests = adafruit_requests.Session(pool, ssl_context, socket_handler)

And a ESP32-S2 via MagTag
pool = socketpool.SocketPool(wifi.radio)
ssl_context = ssl.create_default_context()

socket_handler = adafruit_requests.SocketHandler(pool, ssl_context)
requests = adafruit_requests.Session(pool, ssl_context, socket_handler)

I don't know for sure if anyone's doing this, but what if two ssl contexts are needed? It seems possible that you could need two ssl contexts, such as one with the normal set of certificates, and one with a special certificate needed for a single host that has a non-standard certificate.
Currently, this could be handled by two different Session objects. Looking at how the SocketHandler is used in the examples above, I see that the ssl_context is repeated in two places so I'm not sure how that would go.

That is True. Either you could create 2 different SocketHandlers (if they stay not a singleton), or the public get_socket_handler() could take in (pool, ssl_context) and return the once already created for that pair.
I think you would run into the same issue as current with 2 sessions and the fact they would stomp on top of each other and you would run out of sockets quickly.

Following up, the Session can totally keep track of the ssl_context, and only in the case it's not passed in would it generate one...
So from:
socket = self._socket_handler.get_socket(host, port, proto, timeout=timeout)

to:
socket = self._socket_handler.get_socket(host, port, proto, timeout=timeout, ssl_context=self._ssl_context)

This way, SocketHandler can safely be a singleton and not need to worry about handling multiple contexts


Error: table_type missing from table parameters when loading table from Hive metastore

Apache Iceberg version
main (development)
Please describe the bug 🐞
I'm (a user of tap-iceberg is) running into the following error when trying to load a Hive table using pyiceberg.
pyiceberg.exceptions.NoSuchPropertyException: Property table_type missing, could not determine type: bronze.my_iceberg_table

The call in question is https://github.com/shaped-ai/tap-iceberg/blob/38064b3aaca5394ba1482970e790d3e2f6020946/tap_iceberg/tap.py#L94.
It seems the loaded table is missing the table type parameter in
https://github.com/apache/iceberg-python/blob/d587e6724685744918ecf192724437182ad01abf/pyiceberg/catalog/hive.py#L329-L331
?
Thanks in advance if this turns out to be user error 😃

In load_table, there's a 2 step process. First it fetches from HMS using get_table, then it converts the hive table into iceberg (_convert_hive_into_iceberg).
https://github.com/apache/iceberg-python/blob/d587e6724685744918ecf192724437182ad01abf/pyiceberg/catalog/hive.py#L524-L527
The error here is the 2nd step. It is expected that the hive table has a property "table_type" and maps to the string "iceberg".
https://github.com/apache/iceberg-python/blob/d587e6724685744918ecf192724437182ad01abf/pyiceberg/catalog/hive.py#L274-L285
Who created the table in this case? When PyIceberg creates the table, it injects the table_type property
https://github.com/apache/iceberg-python/blob/d587e6724685744918ecf192724437182ad01abf/pyiceberg/catalog/hive.py#L373

Are only tables created by pyiceberg supported here?

Anyone can create an iceberg table using HMS, which can be read by PyIceberg. In HMS, the assumption is that iceberg tables have a specific property set so that engines can distinguish between hive and iceberg tables.
In this case, the table was created as a "hive table" and not an "iceberg table".

Anyone can create an iceberg table using HMS, which can be read by PyIceberg. In HMS, the assumption is that iceberg tables have a specific property set so that engines can distinguish between hive and iceberg tables.
In this case, the table was created as a "hive table" and not an "iceberg table".

@kevinjqliu thanks for the info 🙏. Just two more questions:

is there a way to set this property manually?
would doing that break something?

is there a way to set this property manually?

You can use an engine (like Spark/Trino) to interact with the Hive table to add the extra table parameter. Alternatively, a hacky way is to use hive client in pyiceberg. Like so
https://github.com/apache/iceberg-python/blob/d587e6724685744918ecf192724437182ad01abf/pyiceberg/catalog/hive.py#L570-L574
it should work, but definitely test it out first

would doing that break something?

Nope, adding that specific parameter to HMS is how the iceberg table is defined.
You can see example in the core iceberg library and in an engine like Trino


Rocko compulab

Note in particular https://github.com/mendersoftware/meta-mender-community/pull/46/commits/99ed313d5c7b0dc96ad6bf38a3e6dd92ad7f3b13 which will obviously affect other platforms.  I didn't see a way to make that change conditional to the FSLC based builds.


mesh scale not supported

My mesh files were created in mm, and therefore i have specified the scale in the urdf:
<geometry>
  <mesh filename="package://lca_description/meshes/link1.dae" scale="0.001 0.001 0.001" />
</geometry>

However, when I load the urdf into OpenRave with this plugin, the meshes are huge.
I see where urdf_loader.cpp hard-codes the scale to 1.0.  I might take a shot at making a patch, but I don't have much time to spend on it.
Thanks.

Well, it looks like OpenRave doesn't set the scale properly.  I made this modification to line 388 of urdf_loader.cpp with no luck.
            printf("scale: %f %f %f\n", mesh.scale.x, mesh.scale.y, mesh.scale.z);
            geom_info->_vRenderScale = OpenRAVE::Vector(mesh.scale.x, mesh.scale.y, mesh.scale.z);

The scale is being read properly from the urdf.  But the mesh files are still huge.

That is the correct fix for the render geometry. It's a bit more complicated to fix the collision geometry because OpenRAVE seems to completely ignore the _vCollisionScale property. I ended up manually scaling the collision mesh to work around this issue. See #7.
Is it possible that you weren't seeing any effect because you were viewing the collision geometry? (most likely due to #5)

Fixed in #7.


[bug] @vue_devtools-api.js does not provide an export named 'setupDevtoolsPlugin' (when using 'addCustomTab')

Hi there,
I'm looking to develop a plugin for the new devtool, and I'm encountering a problem.
When I want to use the addCustomTab method imported from @vue/devtools-api, I encounter the error mentioned in the title (see screenshot below).

Here is my code:
// in main.ts

import { setupDevtools } from 'devtool/vue-devtools';

const sandboxApp = createApp(App)
  .use(router)
  .mount('#app');

setupDevtools();

// in devtool/vue-devtools.ts

import { addCustomTab } from '@vue/devtools-api';

export function setupDevtools () {
  // a simple console.log of the method is enough to trigger the error
  console.log(addCustomTab);

  console.log('Orion Devtools initialized');
}

If I comment out the console.log, I don't get any errors until I uncomment it.
What's strange is that once the error appears, I have to do a complete clean of the node_modules folder for it to work again by commenting out the console.log.
My environment:
MacOS 14.3.1

node -v
# v20.11.0

npm -v
# 10.2.4

Here are my devDependencies:
"devDependencies": {
  "@babel/plugin-proposal-decorators": "^7.23.9",
  "@babel/preset-typescript": "^7.23.3",
  "@faker-js/faker": "^8.4.0",
  "@stackblitz/sdk": "^1.9.0",
<EMAIL_ADDRESS>"^1.4.12",
  "@types/cli-progress": "^3.11.5",
  "@types/fs-extra": "^11.0.4",
  "@types/lodash-es": "^4.17.12",
  "@types/node": "^20.11.16",
  "@types/pluralize": "^0.0.33",
  "@types/prismjs": "^1.26.3",
  "@types/voca": "^1.4.5",
  "@typescript-eslint/eslint-plugin": "^6.21.0",
  "@typescript-eslint/parser": "^6.21.0",
  "@vitejs/plugin-vue": "^5.0.3",
  "@vitejs/plugin-vue-jsx": "^3.1.0",
  "@vue/compiler-sfc": "^3.4.16",
  "@vue/devtools-api": "^7.0.14",
  "@vue/eslint-config-prettier": "^9.0.0",
  "@vue/eslint-config-typescript": "^12.0.0",
  "@vuepress/bundler-vite": "^2.0.0-rc.7",
  "@vuepress/plugin-docsearch": "^2.0.0-rc.3",
  "@vuepress/plugin-register-components": "^2.0.0-rc.3",
  "@vuepress/theme-default": "^2.0.0-rc.14",
  "eslint": "^8.56.0",
  "eslint-plugin-vue": "^9.21.1",
  "fs-extra": "^11.2.0",
  "less": "^4.2.0",
  "markdown-it": "^14.0.0",
  "markdown-it-container": "^4.0.0",
  "prismjs": "^1.29.0",
  "ts-morph": "^21.0.1",
  "typescript": "^5.3.3",
  "vite": "^5.1.0",
  "vite-plugin-babel": "^1.2.0",
  "vite-plugin-vue-devtools": "^7.0.14",
  "vue": "^3.4.16",
  "vue-router": "^4.2.5",
  "vue-tsc": "^1.8.27",
  "vue3-markdown-it": "^1.0.10",
  "vuepress": "^2.0.0-rc.7",
  "vuepress-vite": "^2.0.0-rc.0"
}

Let me know if you need further informations.
Thanks for your help.

Can you provide a mini repo? thanks.

Can you provide a mini repo? thanks.

of course, here it is:
https://github.com/orion-ui/orion-ui/tree/feature/devtool
On the feature/devtool branch
Simply clone the repo, npm i and npm run serve.
You will immediatly see the error.

Can you provide a mini repo? thanks.

of course, here it is: https://github.com/orion-ui/orion-ui/tree/feature/devtool
On the feature/devtool branch
Simply clone the repo, npm i and npm run serve.
You will immediatly see the error.

Hi @jbmaisner , I've submitted a pr in orion-ui to make it work.  The reason for this issue is that devtools-api v6 has some compatibility issues with v7. (I'll discuss it with the team later and decide what to do with it). Now, as a workaround, it works fine.

Maybe we should put a tag next to the npm releases to prevent conflicts with the current devtools @webfansplz


Animation Car Project with html , css and js .

Good work. I am merging your PR.
Do give us a star by hitting the star button of this repo!


I have added a Linear search program in java.

this is my first pull request . Please correct me if i am going wrong! thank you.

Please try to commit some other DSA. Linear search doesn't exactly fit here.


deal with situation where if a map has a required field with an optional type that is a superset

this appears to be fixed now.


In WebGL, CharacterBody3D gets stuck on trying to slide over RigidBody3D kinematic even if move_and_slide has been called

Godot version
v4.1.1.stable.official [bd6af8e0e]
System information
Godot v4.1.1.stable - Windows 10.0.22621 - Vulkan (Forward+) - dedicated NVIDIA GeForce RTX 3080 Laptop GPU (NVIDIA; <IP_ADDRESS>42) - 12th Gen Intel(R) Core(TM) i9-12900H (20 Threads)
Issue description
This happens only on the WebGL build, not on PC Desktop.
A CharacterBody3D character won't slide along a wall with a kinematic RigidBody3D and will get stuck until the player changes direction. This doesn't happen immediately, though, but only if player doesn't touch a wall for a while. This makes me suspect that perhaps this has to do with the sleeping settings? The RigidBody3D wall has the sleeping and can sleep settings set as false.
Steps to reproduce

Build the project as WebGL
Launch it and select Start on the intro scene
Move with WASD and try to slide along the edge of the field. It will work.
Relaunch and this time wait a minute or two before trying to slide along the edge of the play field
Character will get stuck

Minimal reproduction project
CollisionTestWebGL.zip

I created a minimal project and tested it in webgl. The issue with collisions happens there as well. I updated the report to include the minimal project.


Resolve Chef 13 deprecation warning

   Deprecated features used!
     Cannot specify both default and name_property together on property path of resource yum_globalconfig. Only one (name_property) will be obeyed. In Chef 13, this will become an error. at 1 location:
       - /tmp/kitchen/cache/cookbooks/yum/resources/globalconfig.rb:77:in `class_from_file'

This is a bug in Chef / compat_resource
https://github.com/chef-cookbooks/compat_resource/issues/40

Closing this since it's a compat_resource bug


SPARQL query representation of boolean values

SELECT
 DISTINCT ?x WHERE {
?x ?s_1 ?s_2 .
FILTER NOT EXISTS {
?x <http://dl-learner.org/carcinogenesis#amesTestPositive> ?s_3 .
 FILTER ( ?s_3 IN (
        "False"^^<http://www.w3.org/2001/XMLSchema#boolean>
 ) )
  }}

leads to Datatype format exception
19:25:54 INFO  Fuseki          :: [137488] Query = SELECT  DISTINCT ?x WHERE {  ?x ?s_1 ?s_2 .  FILTER NOT EXISTS {  ?x <http://dl-learner.org/carcinogenesis#amesTestPositive> ?s_3 .   FILTER ( ?s_3 IN (          "False"^^<http://www.w3.org/2001/XMLSchema#boolean>  ) )   }}
19:25:54 WARN  NodeValue       :: Datatype format exception: "False"^^xsd:boolean
19:25:55 INFO  Fuseki          :: [137488] 200 OK (648 ms)

SELECT
 DISTINCT ?x WHERE {
?x ?s_1 ?s_2 .
FILTER NOT EXISTS {
?x <http://dl-learner.org/carcinogenesis#amesTestPositive> ?s_3 .
 FILTER ( ?s_3 IN (
false
 ) )
  }}

does not lead to Datatype format exception
19:26:39 INFO  Fuseki          :: [137490] Query = SELECT  DISTINCT ?x WHERE {  ?x ?s_1 ?s_2 .  FILTER NOT EXISTS {  ?x <http://dl-learner.org/carcinogenesis#amesTestPositive> ?s_3 .   FILTER ( ?s_3 IN (  false  ) )   }}
19:26:39 INFO  Fuseki          :: [137490] 200 OK (812 ms)

fixed with https://github.com/dice-group/owlapy/commit/c98913b01c8b604a5f88b8dcc7eb2875a6ba7dc9


Test on Python 3.10

Most CI failures are false positives (https://github.com/codecov/codecov-action/issues/788) but there are some true negatives resulting from Yank not supporting Python 3.10.

https://github.com/choderalab/yank/pull/1284

Still blocked by a Yank release

Restarting in #497


Enable network logs same as PW

Ronseal PR. Same as PW mirror PR.

Where are we sending the network logs?

These are the network logs available by hitting f12 and clicking network. They're being sent as an additional silent capture (So they'd be available via REST, and via the BS interface).

Just seen the public website equivalent. If this is for debugging a specific device type could we limit the network logging to just that?

It's for a few different device combinations. Few older versions of chrome. iOS e.t.c.


About GroupNorm described in the MAGVIT V2 paper

Hello, thanks for your nice work. I notice that there are some differences between your implementations and original paper. One notable difference is the use of group normalization in the original paper. From my understanding, directly applying group normalization to a 5D video tensor (B, C, T, H, W) can result in non-causal behaviors. In your implementation, you did not include group normalization. Could you please explain your reasoning behind this choice? Is it related to the issue I mentioned?

Typically you just have to pack B, T to one dimension and do the normal group norm, then you rearrange it back to the original dim.


[BUG] HTTPError: 500 Server Error / ClientError: Unknown Server Error when i try to upload a story

Describe the bug
When I try to upload a story using an example from documentation I get this 500 Server Error.
To Reproduce
Copy the 3rd example from https://adw0rd.github.io/instagrapi/usage-guide/story.html
Traceback
Traceback (most recent call last):
File "C:\VS Code trabs\IGBot\venv\lib\site-packages\instagrapi\mixins\private.py", line 298, in _send_private_request
response.raise_for_status()
File "C:\VS Code trabs\IGBot\venv\lib\site-packages\requests\models.py", line 1021, in raise_for_status
raise HTTPError(http_error_msg, response=self)
requests.exceptions.HTTPError: 500 Server Error: Internal Server Error for url: https://i.instagram.com/api/v1/media/configure_to_story/
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "c:\VS Code trabs\IGBot\main.py", line 21, in
cl.photo_upload_to_story(
File "C:\VS Code trabs\IGBot\venv\lib\site-packages\instagrapi\mixins\photo.py", line 361, in photo_upload_to_story
if self.photo_configure_to_story(
File "C:\VS Code trabs\IGBot\venv\lib\site-packages\instagrapi\mixins\photo.py", line 622, in photo_configure_to_story
return self.private_request("media/configure_to_story/", self.with_default_data(data))
File "C:\VS Code trabs\IGBot\venv\lib\site-packages\instagrapi\mixins\private.py", line 447, in private_request
raise e
File "C:\VS Code trabs\IGBot\venv\lib\site-packages\instagrapi\mixins\private.py", line 434, in private_request
self._send_private_request(endpoint, **kwargs)
File "C:\VS Code trabs\IGBot\venv\lib\site-packages\instagrapi\mixins\private.py", line 374, in _send_private_request
raise ClientError(e, response=e.response, **last_json)
instagrapi.exceptions.ClientError: Unknown Server Error.
Expected behavior
Should upload the photo as a story.
Screenshots

Desktop (please complete the following information):

OS: Windows 10
Python version: 3.9.7
instagrapi version: 1.16.29
moveipy version if used: 1.0.3

I have the same problem.


rip2: set up updateScript

Adds passthru.updateScript for rip2 so PRs will be created automatically when there's a new version.

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

@NixOS/nixpkgs-merge-bot merge

Ah... chicken and the egg. Guess I just need to wait for the aarch64-darwin tests to finally run


(bot) Update ghcr.io/fluxcd/helm-controller Docker tag to v0.11.1

This PR contains the following updates:

Package
Update
Change

ghcr.io/fluxcd/helm-controller
minor
v0.10.1 -> v0.11.1

Release Notes

fluxcd/helm-controller
v0.11.1
Compare Source
CHANGELOG
v0.11.0
Compare Source
CHANGELOG

Configuration
📅 Schedule: At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.

[ ] If you want to rebase/retry this PR, check this box.

This PR has been generated by Renovate Bot.

Renovate Ignore Notification
As this PR has been closed unmerged, Renovate will now ignore this update (v0.11.1). You will still receive a PR once a newer version is released, so if you wish to permanently ignore this dependency, please add it to the ignoreDeps array of your renovate config.
If this PR was closed by mistake or you changed your mind, you can simply rename this PR and you will soon get a fresh replacement PR opened.


KeyError: "['zscore'] not in index"

Hi,
I am having trouble with gwas_summary_imputation.py after having harmonized my sumstats.
I get the following error:
KeyError: "['zscore'] not in index"
With the script:
python3 gwas_summary_imputation.py
-by_region_file eur_ld.bed.gz
-gwas_file meta_harm_200803.tab.gz
-parquet_genotype chr1.variants.parquet
-parquet_genotype_metadata variant_metadata.parquet
-window 100000
-parsimony 7
-chromosome 1
-regularization 0.1
-frequency_filter 0.01
-sub_batches 5
-sub_batch 0
--standardise_dosages
-output meta_harm_imput_200803_chr1_sb0.tab \
Is a zscore necessary for this step?
My input has the following columns:
variant_id	panel_variant_id      chromosome	position	effect_allele	non_effect_allele	frequency	pvalue	effect_size	standard_error	sample_size	n_cases
Thank you for your help.
Best regards,
Laura.

Hi Laura,
I'm assuming you already harmonized the GWAS.
The summary imputation tool indeed needs zscores - it assumes its existence and uses the observed values to impute missing zscores. I suggest re-running harmonization with zscore in the generated columns.
Best,
Alvaro


nixos/corectrl: add package option

Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/3319

Diff itself lgtm now. But as per our https://github.com/NixOS/nixpkgs/blob/aa6c8ae3a62ce1b2888d5a9fa8e726a4dcaa6c31/CONTRIBUTING.md#commit-conventions you will need to squash your two commits into a single one titled nixos/corectrl: add package option.
I'll mark your PR as draft until you are done. This is to prevent accidental mass-pings if the rebase is going sideways (happens from time to time)

After an embarrassingly long amount of time, I managed to do my first successful squash. Thank you!


Move to repo clone instead of downloading zip version

Original title: Remove custom zulip puppet files

Already remove some files in #31.

Question to ask:

How do we generate the static files? (*insert static generating script from zulip/zulip here*)
Are we cloning a version tag in the our version branches and tags?

Almost done, it just needs some more fixing.

The problems with building the image from the zulip/zulip repo, should now been fixed in the latest commit 4b8f6eb02827d8ef28900bc0b68bd1e56393e291.

Last problem with supervisor running in daemon mode fixed in 24744507d18c41e701e0f7f462ad417ac86ef67c.

See #45 for the new details.

Done in ce8c3b4d28629ae1ebc7aa278cad5b0c963a1382.


Enhanced input validation and schema representation

Schema example:

VertexData

>>> ret.schema
type  property
v     id            v.id
      data        v.data
r                      r

VertexProperty

>>> ret.schema
type  property
v     id            v.id
      data        v.data
r     auth        r.auth
      hub          r.hub

LabeledVertexData

>>> ret.schema
type  label     property
v     person    id                v:person.id
                name            v:person.name
                age              v:person.age
      software  id              v:software.id
                name          v:software.name
                lang          v:software.lang
r     person                         r:person
      software                     r:software

LabeledVertexProperty

>>> ret.schema
type  label     property
v     person    id                v:person.id
                name            v:person.name
                age              v:person.age
      software  id              v:software.id
                name          v:software.name
                lang          v:software.lang
r     person    dist_0        r:person.dist_0
      software  dist_1      r:software.dist_1

What do these changes do?

Related issue number

Fixes 1 ~ 7 issues of #1179

Please add a column name for the last column.
e.g., selector

Please add a column name for the last column.
The series has a name in the bottom of Series, such as

>>> s = pd.Series([1, 2, 3], dtype=np.int64, name='Numbers')
>>> s
0    1
1    2
2    3
Name: Numbers, dtype: int64

The name has been assigned by pd.Series(v_values + r_values, index=index, name="Context schema")

Codecov Report

Merging #1205 (ea92641) into main (8cdc1b6) will decrease coverage by 1.99%.
The diff coverage is 6.52%.

@@            Coverage Diff             @@
##             main    #1205      +/-   ##
==========================================
- Coverage   40.49%   38.50%   -2.00%
==========================================
  Files         368       91     -277
  Lines       19677     9649   -10028
==========================================
- Hits         7969     3715    -4254
+ Misses      11708     5934    -5774

Impacted Files
Coverage Δ

python/graphscope/analytical/app/sssp.py
81.81% <0.00%> (-18.19%)
:arrow_down:

python/graphscope/framework/graph_schema.py
50.00% <0.00%> (-11.25%)
:arrow_down:

python/graphscope/tests/unittest/test_app.py
0.00% <0.00%> (-98.41%)
:arrow_down:

python/graphscope/tests/unittest/test_lazy.py
0.00% <0.00%> (-100.00%)
:arrow_down:

python/graphscope/framework/context.py
42.02% <7.40%> (-28.77%)
:arrow_down:

...ython/graphscope/tests/unittest/test_cython_ast.py
0.00% <0.00%> (-100.00%)
:arrow_down:

python/graphscope/analytical/udf/patch.py
3.47% <0.00%> (-96.53%)
:arrow_down:

...thon/graphscope/tests/unittest/test_scalability.py
0.00% <0.00%> (-96.16%)
:arrow_down:

... and 317 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8cdc1b6...ea92641. Read the comment docs.


Is that an electron desktop twitter client I see, with webSecurity false? I’d stay away.

https://twitter.com/torgeir/status/733384789424754689
Not my words but thought you'd like the opportunity to speak up about it

@sindresorhus is there a motivation behind this setting? If not let's set it to true.
// @danhp

I'm not too sure what this means the comment we had is:
// required for Facebook active ping thingy
webSecurity: false,

Yes, it's needed for logging in with 2FA. Otherwise it never logs in. Seems CSP (webSecurity) is for some reason preventing the 2FA script. I think an immediate fix to the security issue would be to nodeIntegration: false. We should still look into how to remove webSecurity: false while working with 2FA.

I think an immediate fix to the security issue would be to nodeIntegration: false.

Isn't that necessary for the vendor script loading that @danhp did using require?

Yes.
I looked into it now and it seems that nodeIntegration: true conflicts with the jQuery script on the 2FA page. When nodeIntegration: false and not using preload it works. So, I'm not really sure what our options are now. I don't think it's possible to just disable nodeIntegration just for the 2FA page. And we need nodeIntegration for the IPC communication. Suggestions?


segfault from ppx_let

The following ml file:
let foo = 0

with the following .merlin
S src
B _build/src
PKG core
PKG async
PKG ppx_let

results in the following error.
Error detected while processing function <SNR>51_BufWritePostHook..<SNR>51_UpdateErrors..<SNR>51_CacheErrors..30..29..SyntaxCheckers_ocaml_merlin_GetLocList..merlin#ErrorLocList:
line    9:
Traceback (most recent call last):
  File "<string>", line 3, in <module>
  File "/Users/izzy/.opam/4.03.0/share/merlin/vim/autoload/merlin.py", line 449, in vim_loclist
    errors = command("errors")
  File "/Users/izzy/.opam/4.03.0/share/merlin/vim/autoload/merlin.py", line 170, in command
    return merlin_process().command(*cmd)
  File "/Users/izzy/.opam/4.03.0/share/merlin/vim/autoload/merlin.py", line 138, in command
    raise Error(content)
merlin.Error: {u'message': u"Error: Error while running external preprocessor\nCommand line: /Users/izzy/.opam/4.03.0/lib/ppx_let/./ppx '/var/folders/t6/g7qc8rbx2mn5jrzs4b83cpyc0000gn/T/camlppx275c85' '/var/folders/t6/g7qc8rbx2mn5jrzs4b83
cpyc0000gn/T/camlppx167c3c' 1>/dev/null 2>/dev/null\n", u'valid': True, u'type': u'type'}
Error detected while processing function <SNR>51_BufWritePostHook..<SNR>51_UpdateErrors..<SNR>51_CacheErrors:
Error detected while processing function <SNR>51_BufWritePostHook..<SNR>51_UpdateErrors..<SNR>51_CacheErrors:
line   35:
E170: Missing :endfor
Error detected while processing function <SNR>51_BufWritePostHook..<SNR>51_UpdateErrors:
line   15:
E171: Missing :endif
Press ENTER or type command to continuesh: line 1: 13963 Segmentation fault: 11  /Users/izzy/.opam/4.03.0/lib/ppx_let/./ppx '/var/folders/t6/g7qc8rbx2mn5jrzs4b83cpyc0000gn/T/camlppx2d60bd' '/var/folders/t6/g7qc8rbx2mn5jrzs4b83cpyc0000gn/T/camlppx661513' > /dev/null 2> /dev/null

The important part seems to be ppx segfaulting, but I included the whole error in case something else is useful. Strangely, changing the ml to
let foo = ()

gets rid of the segfault.

Which version of merlin?

"The Merlin toolkit version 2.3.1, for Ocaml 4.03.0"

OCaml 4.03.0 is only supported in the git version.
The 2.3.1 targeted a binary incompatible alpha of 4.03.

I see, thanks.


HA 2025.1.0b0

Getting a blocking Call for the integration with HA Beta for 2025.01. as well as an information about invalid config (Integration does not load anymore)...
There's only the following information in the logs:
Logger: homeassistant.util.loop
Quelle: util/loop.py:77
Erstmals aufgetreten: 09:55:17 (1 Vorkommnisse)
Zuletzt protokolliert: 09:55:17

Detected blocking call to import_module with args ('custom_components.solaredge_forecast',) in /usr/src/homeassistant/homeassistant/loader.py, line 1075: ComponentProtocol, importlib.import_module(self.pkg_path) inside the event loop; This is causing stability issues. Please create a bug report at https://github.com/home-assistant/core/issues?q=is%3Aopen+is%3Aissue For developers, please see https://developers.home-assistant.io/docs/asyncio_blocking_operations/#import_module Traceback (most recent call last): File "<frozen runpy>", line 198, in _run_module_as_main File "<frozen runpy>", line 88, in _run_code File "/usr/src/homeassistant/homeassistant/__main__.py", line 227, in <module> sys.exit(main()) File "/usr/src/homeassistant/homeassistant/__main__.py", line 213, in main exit_code = runner.run(runtime_conf) File "/usr/src/homeassistant/homeassistant/runner.py", line 154, in run return loop.run_until_complete(setup_and_run_hass(runtime_config)) File "/usr/local/lib/python3.13/asyncio/base_events.py", line 707, in run_until_complete self.run_forever() File "/usr/local/lib/python3.13/asyncio/base_events.py", line 678, in run_forever self._run_once() File "/usr/local/lib/python3.13/asyncio/base_events.py", line 2033, in _run_once handle._run() File "/usr/local/lib/python3.13/asyncio/events.py", line 89, in _run self._context.run(self._callback, *self._args) File "/usr/src/homeassistant/homeassistant/setup.py", line 165, in async_setup_component result = await _async_setup_component(hass, domain, config) File "/usr/src/homeassistant/homeassistant/setup.py", line 334, in _async_setup_component component = await integration.async_get_component() File "/usr/src/homeassistant/homeassistant/loader.py", line 1027, in async_get_component comp = self._get_component() File "/usr/src/homeassistant/homeassistant/loader.py", line 1075, in _get_component ComponentProtocol, importlib.import_module(self.pkg_path)

hm... seems to be resolved :)


expose more function with nntrainer c-api

Adding a layer into a model created with INI requires creating two connections for the new layer - with the previous layer and with the next layer. In order to create connection with the next layer, "input_layer" property needs to be set for the next layer. This requires handle for the next layer. This leads to the proposal to open "ml_train_get_layer" (get layer object by name) in the nntrainer public API.
Further, also expose "ml_train_get_all_layer_names" for ease of the user to see all the layers.
cc. @pkosko

:octocat: cibot: Thank you for posting issue #1848. The person in charge will reply soon.


Add Cypress accessibility tests for initial components

Summary
As part of https://github.com/mi6/ic-ui-kit/issues/1166, need to add accessibility tests for the initial 3 components selected for investigation. This work should be carried out on the duplicated repo created under https://github.com/mi6/ic-ui-kit/issues/1184
Components to test:

[ ]  IcButton
[ ]  IcTopNavigation
[ ]  IcSelect

Leave this issue until we've worked on the others, as they may come nearly for "free"

a11y tests will be added to existing test files such as IcSelect.cy.tsx.
Using IcSelect as an example (component testing variant), the a11y test should setup like:

Mount component

Check IcSelect is rendered

A11Y TEST

Click IcSelect to display IcMenu

A11Y TEST

By using the approach above, a11y testing should be more comprehensive due to the increase of testing in context to the component's state.
A separate file should not be required for a11y testing

Finall changes added in a PR to ui-kit-cypress


Text dialog with on-screen keyboard

It took me about 10 minutes to enter my home WiFi credentials. An on-screen keyboard would be much easier to use.
I've started writing one to replace the existing text dialog. Is that a useful contribution, or would it be duplicating work? I couldn't see any other issues, branches or PRs mentioning a keyboard.

You might want to checkout the keyboard on the flow3r.
Might be slightly more challenging on the EMF badge with only 6 (7if you count boop) buttons.
This was brought up a few days ago in the badge channel.
https://matrix.to/#/!VvSoIxosxjlkTNMLOa%3Amatrix.org/%24TF0Zu9ifF70dmdz6y-RpURiTQMxrmXeWCk6ty30X1QM

@emericklaw That link to the badge channel didn't work for me. It said that the link was malformed.
I see that a new keyboard PR has just been opened, but I have a demo app of what my keyboard would look like: https://github.com/janion/keyboard-demo.
Obviously I'm biased, but I think that my keyboard is more intuitive because it's closer to a standard keyboard layout. I'll leave it up to whoever is in charge to decide which one (or both) should be published.

I haven't managed to get the simulator working yet, but here's a photo of the keyboard:

We now have an on-screen keyboard as of 1.7.0, I'll change the title of this ticket to add this as another keyboard option. People could switch between the two


Fix broken link

What's changed, or what was fixed?

fixed broken link in footer on page https://developers.google.com/web.
Footer Key Topics Web on Android

Fixes: #9430
Target Live Date: 2022-02-08

[x] This has been reviewed and approved by (NAME)
[ ] I have run npm test locally and all tests pass.
[x] I have added the appropriate type-something label.
[ ] I've staged the site and manually verified that my content displays correctly.

CC: @petele @jeffposnick

I tried to run the tests but I could not get npm test to work on my computer. Sorry!

Thank you! I was checking the site and the link still leads to a 404.
Also, I just realized this is the more accurate website
https://developer.chrome.com/docs/android/
@jeffposnick sorry about that!

The /web/ contents gets deployed manually; it should go live within a week or so.
I wouldn't worry too much about the link.


To add acode of three sum

Please assign me this under hactoberfest.

please label the issue a hactoberfest.


Adafruit feather?

Hello, I'm new to the esp8266 and would really like to experiment with your forth port but I am failing.
I'm targeting a adafruit esp83266 feather (https://www.adafruit.com/products/2821). I have successfully built forthright but have had no success connecting to it after flashing it. Connecting over the feather's usb to uart I see the initial boot loader stuff at reset but nothing more. I'm guessing that I'm using the wrong parameters for gen_misc.sh or deploy.sh. I've been successful with other simple c uart and wifi hello world type stuff so I'm pretty sure it's not the build environment.
Any help would be appreaciated. Thanks for you work.

Acknowledge that I got your request. I will look at it closer tomorrow
(after midnight UTC).
Could it be bitrate settings?
I don't have a Adafruit Feather, only the NodeMCU devkit and my own
designed device (room sensor).
On Apr 6, 2016 08:53, "bb2048er"<EMAIL_ADDRESS>wrote:

Hello, I'm new to the esp8266 and would really like to experiment with
your forth port but I am failing.
I'm targeting a adafruit esp83266 feather (
https://www.adafruit.com/products/2821). I have successfully built
forthright but have had no success connecting to it after flashing it.
Connecting over the feather's usb to uart I see the initial boot loader
stuff at reset but nothing more. I'm guessing that I'm using the wrong
parameters for gen_misc.sh or deploy.sh. I've been successful with other
simple c uart and wifi hello world type stuff so I'm pretty sure it's not
the build environment.
Any help would be appreaciated. Thanks for you work.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
https://github.com/niclash/forthright/issues/2

I took a look at Adafruit Feather, and it uses ESP-12 module, just like I do in my design. You should not need to change anything in config to make it work.
So, if you "git reset" all changes, and do a default build, it should compile to something that will work.
Do a fresh clone and then
make all
in the top-level directory.
If that works, see the arch/esp8266/deploy.sh for details of command line options to flash the code to the device.
If you make changes, you don't have to run "make" from the top level. Just do it inside the esp8266/ directory. The top level takes the Forth source code and makes it into an assembler data segment.
Hope that helps

Sorry for the late response and thanks for looking into it. I will go he it another try when I have a chance (busy race ght now).

Also, if you email me the flash images, I can test them on my hardware and see if the compile is actually working as you think.

Ok, so, good news. I did a pull and things are working! Yay!
I rolled back to where I was and was getting more than I previously got so I'm a bit confused. I've attached some output dumps if they are any use to you. The first is at commit 70ca7b3 where I rolled back to. After "" I entered "words" and got "Error at: words". My entry of "words" was not echoed back.
My memory was that I got nothing or scrolling "Error at:" over and over so I'm kind of confused as to why it behaved differently after I rolled back.
The second is at 957e5f8 when I entered "words" again after "init-done". "words" was echoed back this time but was overwritten by the output from words.
70ca7b3.txt
957e5f8.txt
Thanks for your help, insight and work on this. I've got a couple of minor changes I'll put in pull requests when I get a chance in case they're helpful. I also ran into a fairly amusing bug (most are when you couldn't get it working at all before;) I'll submit.

The 957e5f8.txt is probably working as much as is working for me. This is work in progress, and by no means completed. And don't expect stability in dictionary definitions either, as I will try to move towards a useful embedded vocabulary.
Near future steps;
a. move much of the core dictionary to .rodata segment to conserve RAM.
b. implement disk/flash I/O (I kind of like the old BLOCK concept, because it is easy to implement)
c. peripherals

I'm the author of lina, where the design and a large part of the code of jonesforth is coming from.
lina, and father project ciforth are present on github.
lina has the WANT mechanism that loads words on demand from a coupled library that is sitting in blocks.
You can easily reinstall the blocks code:

find https://github.com/albertvanderhorst/lina
mark all words from the modules BLOCKS and SCREENS
copy those words over from the lina source and make sure everything compiles
now you can adapt to having the blocks in flash.
I would advise to adapt only only READ-BLOCK and WRITE-BLOCK which copy from
ram to flash and vice versa. (In lina they read from a disk file).
Diminish the number of blocks to 4 but not less.
Now the whole library mechanism works from flash.
For example you need not have SEE in the kernel, you can load it by WANT SEE.
I will help you to replace the Intel assembler by an ESP2866 assembler.
There are lots of words from ANSI Forth that would burden the kernel but are present in the library and can be loaded as needed.  That is all work you do not need to repeat.
There are facilities in there like merge sorting, quick sorting, binary search .

The best part is that one can add hardware interfaces that are processor dependant.
WANTallows to have one library file for Windows 32/64 and linux 32/64 bit, by a mechanism of conditional compilation. So you can sort out ADC for your processor and then do WANT ADC. If some one tries this with the wrong processor he will just get an error message.


etcd_set enhancement

Hi,
The cetcd has two APIs to writ the key/value, cetcd_update and cetcd_set, is it better to add the prevExist in the etcd_set? Then we only use  cetcd_set to create a key, and use cetcd_update to update a key.
cetcd_response *cetcd_set(cetcd_client *cli, const char *key,
const char *value, uint64_t ttl) {
cetcd_request req;
cetcd_response *resp;
cetcd_string params;
memset(&req, 0, sizeof(cetcd_request));
req.method = ETCD_HTTP_PUT;
req.api_type = ETCD_KEYS;
req.uri = sdscatprintf(sdsempty(), "%s%s", cli->keys_space, key);
params = sdscatprintf(sdsempty(), "value=%s", value);
params = sdscatprintf(sdsempty(), "prevExist=false");
if (ttl) {
    params = sdscatprintf(params, "&ttl=%lu", ttl);
}
req.data = params;
resp = cetcd_cluster_request(cli, &req);
sdsfree(req.uri);
sdsfree(params);
return resp;

}

Hi,
I should make a mistake, the enhancement i suggest  is like:
req.uri = sdscatprintf(sdsempty(), "%s%s", cli->keys_space, key);
params = sdscatprintf(sdsempty(), "value=%s&prevExist=false", value);
Would you share your ideas if it is acceptable?
Thanks,
Jason

There is some different with set and update, set can overwrite the key if it is exist and add it otherwise. update just update an exist key.


How do I align my data

What about your own data

https://montreal-forced-aligner.readthedocs.io/en/latest/

Use mfa or phonemizer to generate pronounciation dictionary .Then validate your corpus and check for OOV words using ( mfa validate ~/mfa_data/my_corpus ~/mfa_data/my_dictionary.txt ) this command. If the pretrained acoustic model for your language is not available then use ( mfa train ~/mfa_data/my_corpus ~/mfa_data/my_dictionary.txt ~/mfa_data/new_acoustic_model.zip ) use this command to train acoustic model. Then use (mfa align ~/mfa_data/my_corpus english_us_arpa english_us_arpa ~/mfa_data/my_corpus_aligned) mfa align command to generate textgrids. And then you are ready to use Fastspeech2 . For more info you can refer https://montreal-forced-aligner.readthedocs.io/en/latest/first_steps/index.html this documentation


WIP: Feature/allow ssl

This is still a work in progress. Adding PR for visibility and feedback.
The intent of this PR is to add the ability to enable SSL with regular as well as self signed certificates on the cluster.
Goals:

Keep original functionality and backwards compatibility
Add a param which would be added to the statefulset to enable SSL
By default generate self signed certs for each node
Configure mongo when SSL is enabled such that self signed certs work
Document the configuration settings that one would use to connect to a cluster that uses self signed certs

Possible Goals:

Enable the optional use of hostnames in the replicaset (which would require changes when connecting to the DB from the sidecar as well as when determining the desired replicaset state)

I'm currently running this as it is now in my production Kubernetes environment.

@phutchins so far so good, thanks. Let me know when you think it's ready for full review.

Hey @phutchins - is this complete? Can we look at testing and merging now?

Hey @cvallance, back on this now. Going to look it over and will update here shortly. Thanks for the reminder! 👍

@cvallance I'm thinking through the best way to automate(or assist in) the generation and injection of the self signed certificates for mongo. I'd prefer to be able to create and manage/renew them from within the sidecar but pushing to secrets won't work as the stateful set will have already attempted to come up and error'd due to non existent secret, and the mongo containers will also have already attempted to come up without a certificate.
If we could keep the mongo hosts from coming up before the sidecar, we could generate it and either create a secret which we load via a script on the mongo host (gets kinda complicated), or write it to the data mount. I've not run through all of this to see how possible it is however.
Our other option may be to simply include a method in your Makefile that generates the certs and creates a secret. This will be the most straightforward and quickest but the user would have to make sure to renew the certs before they expire...
Maybe we could go the Makefile route and aim for a more automated solution down the road...
Thoughts?

I went ahead and added a function to the examples/Makefile to create and save a pem file to a secret. Also made changes to parameterize the default mongod listen port.

Awesome. Thanks @phutchins. There's been a few changes to the repo since you last pulled... mongo port configuration has been added and the readme has changed to use tables for settings.
If you pull those changes in and fix things up, I'll merge this.
Thanks again!

I've rebased from master and have covered most everything I believe. I still need to test it out before we merge...

@cvallance I've rebased and tested again and all looks well. I moved the mongoOptions to mongo.js which seems like it goes along with the pattern that already exists more than keeping it in worker.js. Should be good to merge if all still looks good to you.

Damn, I didn't see your pull request and added this to my fork as well. I am missing the option to supply a CA certificate and client key in your implementation.
Also, did you test this with mongoSSLAllowInvalidHostnames == false? In my fork, I had to make sure getDb is passed the stable pod hostname (instead of the pod ip, like it is currently implemented) in order for the SSL host verification to work. Plus a workaround to disable ssl validation when connecting to localhost (although disabling host validation should be enough, maybe I should fix that).
See https://github.com/luqasn/mongo-k8s-sidecar/commit/8899d24693bca87bb5a7276e3333227b1c19b0af for my implementation. Currently lacking  documentation and should also add allowInvalidHostnames as option.

@luqasn ah, well hopefully this PR can help you out as well. So I generated the certificates with FQDN of localhost which solves the issue for reaching the nodes for me. That definitely was a bit obscure. I haven't tested with sslAllowInvalidHostnames = false. I'd like to have some tests around all of this eventually...

@cvallance I removed the unused code and pushed. This is still ready to go out if you have time to review. Have ideas for next few iterations but want to go ahead and get this merged before I start anything further...

Good job, I'm still happy... merging now :shipit:

Awesome, thanks @cvallance!


Disable deleting host entries

We just started using your plug-in and we're very thankful for it. I was wondering, however, if there are any plans for adding an option not to undo the changes to the hosts file upon halting the vagrant machine. The nature of our setup doesn't require us to modify that file all too often and the constant prompts for the admin password are a bit annoying. Just to be clear, I have no problem with the prompt itself and understand the need for it, but in our particular case I feel like the rewriting of the hosts file is a bit superfluous.

@Copper-Head is this only necessary for vagrant halt or vagrant destroy?
As for the password prompts, that will be addressed in the documentation in an upcoming release.

Thanks for getting back and sorry about the delay. I originally saw this as only necessary for vagrant halt, since it would be kind of expected to undo this step with destroy.

@Copper-Head I am adding this functionality in 1.0.2
config.hostsupdater.remove_on_suspend  = false
You were able to do this in 1.0.1 but it only worked on suspend.  It works on vagrant suspend and vagrant halt now.  Expect a release soon.


Error never seen before - HT-CT790

Hello,
First, thank you for your plug-in.
Since today, I have an issue with it while it worked fine before.
I'm using this plug-in for a Sound Bar Sony HT-CT790 which is not present in your supported device list but it works as a HT-CT800 I think.
Below, the log when I restart homebridge on my Pi4:

[12/04/2021, 23:59:52] [Sony Audio Platform] Adding new accessory: ��������������������������������
[12/04/2021, 23:59:52] [Sony Audio Platform] Compatible device found, added: ��������������������������������
(node:21601) UnhandledPromiseRejectionWarning: AssertionError [ERR_ASSERTION]: Accessory displayName cannot be longer than 63 bytes!
at Accessory.validateAccessory (/usr/local/lib/node_modules/homebridge/node_modules/hap-nodejs/src/lib/Accessory.ts:948:13)
at Accessory.publish (/usr/local/lib/node_modules/homebridge/node_modules/hap-nodejs/src/lib/Accessory.ts:1180:10)
at BridgeService.handlePublishExternalAccessories (/usr/local/lib/node_modules/homebridge/src/bridgeService.ts:442:20)
at processTicksAndRejections (internal/process/task_queues.js:93:5)
(Use node --trace-warnings ... to show where the warning was created)
(node:21601) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag --unhandled-rejections=strict (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 15)
(node:21601) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
[12/04/2021, 23:59:53] [Sony Audio Platform] Incompatible device found, skipped: TV Salon

Do you have an idea to solve this issue?
Thank you in advance.

hi @Jer-emy
tell me what was the problem?

Hi,
This issue has appeared when I've updated an other plug-in (Ewelink) and this morning, a new update was available for this other plug-in due to a bug inside. After updating, your plugin works fine.
So, it's not an issue in your plug-in :)


add snippet to readme to run prettier for all supported files

Might be too much for the readme so feel free to close, but it's a snippet of code I wrote to automatically run all extensions prettier supports through prettier without having to keep a static list of extensions up to date.

Looks good to me, even though it's getting pretty prettier-specific (pardon the pun).
If you feel like it, the README could use some collapsible sections for these examples:
https://gist.github.com/pierrejoubert73/902cc94d79424356a8d20be2b382e1ab

Hmm I've only tried it on mac, but https://www.npmjs.com/package/string-argv understands the quotes.
See this example

Sounds good. Which ones should collapse? All of them?

Yeah, let's collapse all the examples, and the examples in the JS config section (titles start with Example:).

@iiroj done!


Imprt user stars and repos (See my implementation)

Describe the solution you'd like
I would like to dynamically import my stars and repos to the project. -- I have already done so, so copy the code if suitable?
Example:

https://arran4.github.io/stars/
https://arran4.github.io/repos/

However the issue is it doesn't look that great compared to the rest of it.
Describe alternatives you've considered
Or do it via JS.
Additional context
I was able to get it working for stars and repositories given the new feature: content adapters in v0.126.0:
https://gohugo.io/content-management/content-adapters/
You can see most of the work for repos in this comment:
https://github.com/arran4/arran4.github.io/commit/49262126fa19221cbcbe4bbdcfdcc7b17efeeb5e
The stars is basically the same but you want some minor differences between them.

It does add a lot of time to the compilation though if you have a lot of stars. But it does make it a lot easier to find your stars.

Nice idea. I think we need separate card layout for it to make it look nicer. The card heading and footer are totally unnecessary for this. I will try to come up with something whenever I get some time. Thank you for sharing.

Thanks. No problem. I ran out of time to make it "look good" but it works.


[BACKLOG-24449] The 'kettle5-log4j-plugin' classic PDI plugin generat…

…es a stack trace error
@pentaho/rogueone please review

Build Completed
:fire: This pull request has some issues. It would be preferable to fix them in order for it to be just perfect. See below for more details. Some links are also available below for further assistance in addressing those issues.
Build Commands
mvn -B -f 'pom.xml' -pl 'plugins/log4j/core' -P '!assemblies' -Dsurefire.runOrder=alphabetical -Daudit -amd clean install

Cleanup Commands
mvn -B -f 'pom.xml' -pl 'plugins/log4j/core' -P '!assemblies' -amd build-helper:remove-project-artifact

Changed files
  plugins/log4j/core/src/main/java/org/pentaho/di/core/logging/log4j/Log4jLogging.java

Unit Test Coverage
These statistics help you identify how your changes have affected the coverage of the following files. If a file is not in this list, then its coverage was not affected by your changes. To get some help interpreting these metrics, please refer to Jacoco's documentation.

:warning: Coverage Changes: -0.2% (click to expand)
org.pentaho.di.core.logging.log4j.Log4jLogging

Branch Change: -40% :small_red_triangle_down:
Complexity Change: -6.7% :small_red_triangle_down:
Instruction Change: -19.3% :small_red_triangle_down:
Line Change: -5.2% :small_red_triangle_down:


Callback wont work

I cannot get the callback to work.
<template>
  <div>
    <vue-slider id="slider" ref="slider" v-model="sliderv" v-bind="options" @callback="log">
  </div>
</template>

  methods: {
     log(val) {
        console.log(val);
      },
   }

returns nothing
What is missing?

Now using the @change event, @callback is a method from version 2.x.
https://nightcatsama.github.io/vue-slider-component/#/api/events?hash=change


fix bugs

this fixes a bug when using this library in react native, where dates like "2020-4-17" fail, due to not being truly ISO formatted.
Also fixes a simple parseInt(..., 0) bug that's 7 years old.

Thanks for the pull request. Good bug fixes.


Partial read breaks down when a members order of a JSON object is not the same as the structure's one

Hello! First of all, thank you for your work on this well-designed JSON library, it's really exciting to work with it.
I use partial read frequently cause I have to deal with large JSON files, however it stops to parse if an order of members of a JSON object is not the same as the one at structure I declare to parse into.
In the following example, the desc member is before the value one, which causes an error "unknown_key":
struct B
{
    std::string type{};
    int value{};
};

template<>
struct glz::meta<B>
{
    static constexpr auto partial_read = true;
};

int main()
{
    std::string json = R"({"type": "hey", "desc": "string", "value": 5})";

    B b{};

    auto err = glz::read_json(b, json);

    if (err == glz::error_code::none)
        std::cout << b.value << std::endl;
    else
        std::cerr << glz::format_error(err, std::string{}) << std::endl;

    return 0;
}

According to the JSON specification, a JSON object is a container of unordered pairs key\value, so maybe it is worth to skip members that are not supposed to be parsed instead?

You can set error_on_unknown_keys = false. This will just skip unknown keys.
glz::read<glz::opts{.error_on_unknown_keys = false}>(...)

Yes it will, but it would parse the whole data anyway, even all the required members are already parsed, right?
Also I'm wondering if I can set options for glz::read_file_json

Let me look over the code. We should be able to early exit once the user struct is parsed.
And yes, read_file_json is templated on the opts.

the documentation says that with .error_on_unknown_keys option the whole content will be parsed, but maybe I understood it wrong. Thanks anyway!

Yeah, that's what the documentation says. So, the code probably needs to be improved. I was not the author of this new feature, so this is one aspect I didn't consider in detail. But, I'll look into it now.

Thank you!

I just merged in a fix that will early exit even for error_on_unknown_key = false. I've updated the documentation accordingly.
Thanks for your patience, it took me a while to get to this, but I really like this feature. Let me know if you run into any more issues.


fix(nextjs): Removes the dot that breaks the link to the docs

Description
Removes the typo that breaks the link on a nextjs-clerk  authAuthHeaderMissing  Error, which added the annoying dot to the link and was breaking it.
Checklist

[x ] npm test runs as expected.
[x ] npm run build runs as expected.
[ ] (If applicable) JSDoc comments have been added or updated for any package exports
[ ] (If applicable) Documentation has been updated

Type of change

[x ] 🐛 Bug fix
[ ] 🌟 New feature
[ ] 🔨 Breaking change
[ ] 📖 Refactoring / dependency upgrade / documentation
[ ] other:

Packages affected

[ ] @clerk/backend
[ ] @clerk/chrome-extension
[ ] @clerk/clerk-js
[ ] @clerk/clerk-expo
[ ] @clerk/fastify
[ ] gatsby-plugin-clerk
[ ] @clerk/localizations
[x ] @clerk/nextjs
[ ] @clerk/clerk-react
[ ] @clerk/remix
[ ] @clerk/clerk-sdk-node
[ ] @clerk/shared
[ ] @clerk/themes
[ ] @clerk/types
[ ] build/tooling/chore

Thank you for spotting and fixing this one @marcadrian-it :)


julia_18: init at 1.8.1

Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[x] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

 Can I use the derivation from this PR? If it's working, I might use this branch of Nixpkgs and rebuild my system from it.

I actually need Julia on aarch-64urgently. Can I use the derivation from this PR? If it's working, I might use this branch of Nixpkgs and rebuild my system from it.

Both this derivation and the one from https://github.com/NixOS/nixpkgs/pull/191800 should work, if you are in an urgent need, the binary distribution would save you some non trivial time of compilation.

Is the test suite passing?

All of them except the skipped few.

Should we not lift in Arch’s patches into our own repo?

fetchurl works just fine.

sanity.patch should probably be split into separate patches akin to what we have for 1.0, 1.5, etc.

I would take care of that, and give them better names.

Why are we skipping tests for ...

These tests are either checking for hard-coded version numbers, or looking for a non-existent vendored copy of CA certificates.

I think the correct value for installCheckTarget is testall

Let me check it again.

I seem to recall that you need dontStrip = true to not break backtraces.

I'm not sure what the backtrace should look like, I would compare it with the ones from the binary distribution.

them swapping up pieces such as Julia’s patched LLVM without understanding the implications.

I see a bunch of warnings when compiling with our upstream LLVM, there sure could be minor issues, but given that using any system library is already giving us an unsupported build and the tests are passing, I would not be bothered with this too much.

I could easily imagine Julia not having sufficient tests to cover the differences in LLVM. Do we know what the patches are supposed to achieve?

@Moelf would you like to provide us with some suggestions on packaging, like whether it is acceptable to use an unpatched version of llvm.

From @vchuvary

Oh these are backend specific sometimes, So you won't see them until you run on PPC or Aarch64

Do you have the cycles to provide an opinion on what we allow Julia to vendor and not for the packaging here?

I unfortunately don't know at this point what absolutely needs to be vendored due to critical patches and what can safely use a system library. Historically the former has been at least LLVM and OpenBLAS and I suspect that's still the case. @staticfloat, as a whisperer of third party dependencies, can you comment on this at all?
I don't really know the NixOS ethos around such things but is it possible to repackage the official binaries from https://julialang.org/download? That should provide the best user experience from a Julia perspective, though perhaps not from a Nix perspective.

my understanding is their "shtick" (good thing!) is the package manager can handle what traditional Linux distro can't, for example, two packages critically need to patch LLVM in incompatible ways.

I don't really know the NixOS ethos around such things but is it possible to repackage the official binaries from https://julialang.org/download? That should provide the best user experience from a Julia perspective, though perhaps not from a Nix perspective.

We already packaged the official binaries, but some do prefer to build everything from source.

@ninjin I've switched to use the vendored copy of LLVM, any remaining concerns?

You can see what patches Julia uses on its dependencies for a particular version by looking here:

That is not accurate for LLVM and LibUV. For Julia 1.8 we switched from maintaing a patchlist to maintaing a fork. So to see the patches we carry for LLVM 13: https://github.com/JuliaLang/llvm-project/compare/llvmorg-13.0.1...julia-13.0.1-3 (also see spack as a reference https://github.com/spack/spack/blob/5dc440ea92dbc1763f76c19b350c17355f96c5dc/var/spack/repos/builtin/packages/julia/package.py#L148)
Similarly the libuv patches are maintained here https://github.com/Julialang/libuv, but I am less familiar with those.

Testset «channels» seems to fail on aarch64-linux
This does break the build, though. Do we keep this as is or do we mark it as broken there?

The tests are passing for me on aarch64:
julia> Test Summary: |     Pass  Broken     Total      Time
julia>   Overall     | 40348763  352659  40701422  14m09.2s
julia>     SUCCESS

I'm on c3.large.arm64 from equinix metal if that matters.

I guess it might be subject to race conditions and slightly flaky… let's see

That is not accurate for LLVM and LibUV. For Julia 1.8 we switched from maintaing a patchlist to maintaing a fork.

Ah, thank you for the correction Valentin.  That makes my previous comment incorrect, and we do in fact have significant patches to LLVM.


Tutorial does not work due to missing dependency

Description
[Enter feedback here]
The tutorial on page https://learn.microsoft.com/en-us/aspnet/core/tutorials/razor-pages/model?view=aspnetcore-8.0&tabs=visual-studio does not work when executing the step "Scaffold the movie model". The problem seems to be a missing pacakge in the project as explained in https://developercommunity.visualstudio.com/t/vs2022-add-new-scaffold-item-there-was-an-error-ru/1580388 (see there the proposed workaround).
Page URL
https://learn.microsoft.com/en-us/aspnet/core/tutorials/razor-pages/model?view=aspnetcore-8.0&tabs=visual-studio
Content source URL
https://github.com/dotnet/AspNetCore.Docs/blob/main/aspnetcore/tutorials/razor-pages/model.md
Document ID
7096fdb3-612e-9e00-bd0b-8ea4886a09ce
Article author
@wadepickett

Thanks @vichor for letting us know your experience with this topic.  Visual Studio 2022 provides the needed NuGet packages for scaffolding automatically when the scaffolding step is taken.  I just tested the tutorial steps now for Visual Studio and verified it all works, just in case:

This latest version of the Razor Pages tutorial is designed around Visual Studio 2022 and is shown required as a prerequisite at the beginning.
The issue you referred to was filed for visual studio 2019 version 16.3.  If you are receiving the error mentioned on that link, then it could be you are using an older version of Visual Studio, or possibly there was some sort of connection problem while Visual Studio was attempting to download the needed packages during scaffolding.
I will close this issue since I just verified the tutorial steps work with the prerequisite version of Visual Studio.  Feel free to reopen this issue if we have missed something.   Thanks again.


Add support for developer data flag in record header

I'm investigating a problem with some customer files that we get some really strange errors with. The files comes via Garmin Connect so expect them to be correct and thus there is probably something wrong in the parsing of the file. While investigating this and reading up on the latest release of the FIT protocol I discovered some things that was not supported in the code and thus added these. This PR adds support for the developer data flag in the record header.

Thanks @karl-petter! I've squashed your changes and merged in 4b81419


Rename project?

Ever since creating the repo for our workflow documents (bespin-cwl) I find myself confusing these two repos. Any thoughts/objection/support on renaming this repo to bespin-api?

I like bespin-api much better.

bespin-api it is then.

Renamed on GitHub and updated README  in 7099a4bfc7e9baf133ea179336aff4ee130ee9cb


Ensure sequence is moved to CPU

In the TV script generation project, the generate() function erroneously
continues to use the current_seq value without first moving to CPU (if training
on GPU). This can lead to an error of the form shown below:
"TypeError: can't convert CUDA tensor to numpy. Use Tensor.cpu() to copy the
tensor to host memory first."
Resolves: #118

Thank you!


Unsynchronized ByteArrayInputStream implementation

Builds upon the previous work of https://github.com/apache/commons-io/pull/108 by adding an UnsynchronizedByteArrayInputStream.
Calls to UnsynchronizedByteArrayOutputStream#toInputStream() now return UnsynchronizedByteArrayInputStream as the implementation instead of java.io.ByteArrayInputStream.

Thanks @garydgregory I have just pushed a commit addressing your feedback.

https://issues.apache.org/jira/browse/IO-662


Fix two linter warnings

I've been seeing the following linter warnings in my test builds for a few days now:
FAIL: Found 2 non-whitelited pylint errors:
tensorflow/python/platform/googletest.py:28: [W0622(redefined-builtin), ] Redefining built-in 'xrange'

tensorflow/examples/saved_model/integration_tests/integration_scripts.py:64: [E1111(assignment-from-no-return), MaybeRunScriptInstead] Assigning to function call which doesn't return

This PR fixes the two issues that cause these warnings.

I wonder if sys.exit in integration_scripts.py is still needed (may be with a constant exit code).
@andresusanopinto Andre, can you take a look?

It has been 14 days with no activity and the awaiting response label was assigned. Is this PR still valid? Assigning the stalled label. Please comment to reassure me that this is still being worked on.

Replaced the fix for the second warning with a hopefully less-controversial version.
By the way, these linter errors are still showing up on the master branch. To replicate the problem, run:
git clone https://github.com/tensorflow/tensorflow.git
cd tensorflow
tensorflow/tools/ci_build/ci_build.sh CPU tensorflow/tools/ci_build/ci_sanity.sh

You'll see the following output:
[...]
=== Sanity check step 2 of 14: do_pylint PYTHON2 (Python 2 pylint) ===
[...]
FAIL: Found 2 non-whitelited pylint errors:
tensorflow/examples/saved_model/integration_tests/integration_scripts.py:64: [E1111(assignment-from-no-return), MaybeRunScriptInstead] Assigning to function call which doesn't return

tensorflow/python/platform/googletest.py:28: [W0622(redefined-builtin), ] Redefining built-in 'xrange'

Any idea what is causing those two failed checks (Windows Bazel GPU and import/copybara)? I don't have any visibility into the build results.


IMPRO-1195: create convert_to_realizations CLI

Testing:

[x] Ran tests and they passed OK

Put up PR-to-PR (https://github.com/neilCrosswaite/improver/pull/5) which updates based on clize and adds (somewhat redundant) BATS tests. (Assuming that #1016 goes in).
NB: Updating this because it was relatively straightforward to do so, but now that I think about it, perhaps we don't need to create the new CLI - can discuss with rest of Green team next week (cc @benfitzpatrick)

 Here is an overview of what got changed by this pull request:

Issues
======
- Added 4

Complexity increasing per file
==============================
- lib/improver/cli/convert_to_realizations.py  3

See the complete overview on Codacy

 Here is an overview of what got changed by this pull request:

Issues
======
- Added 4

Complexity increasing per file
==============================
- lib/improver/cli/convert_to_realizations.py  3

See the complete overview on Codacy

 Here is an overview of what got changed by this pull request:

Complexity increasing per file
==============================
- lib/improver/cli/convert_to_realizations.py  3

See the complete overview on Codacy

 Here is an overview of what got changed by this pull request:

Complexity increasing per file
==============================
- lib/improver/cli/convert_to_realizations.py  4

See the complete overview on Codacy

 Here is an overview of what got changed by this pull request:

Complexity increasing per file
==============================
- lib/improver/cli/convert_to_realizations.py  4

See the complete overview on Codacy

I agree
From: Aaron Hopkinson<EMAIL_ADDRESS>Sent: 09 December 2019 11:30
To: metoppv/improver<EMAIL_ADDRESS>Cc: Crosswaite, Neil<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [metoppv/improver] IMPRO-1195: create convert_to_realizations CLI (#959)
@arh89 commented on this pull request.

In lib/improver/cli/convert_to_realizations.pyhttps://github.com/metoppv/improver/pull/959#discussion_r355397943:

   no_of_realizations:

       The number of percentiles to be generated. This is equal to the

       number of ensemble realizations that will be generated.

   ecc_bounds_warning:

       If True, where percentiles exceed the ECC bounds range, raises a

       warning rather than an exception.

Agreed, but I think we should adjust all of the relevant CLIs at once, rather than just this one. Another PR for that?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/metoppv/improver/pull/959?email_source=notifications&email_token=AKK5VLY3EQUOSLLBNYC2C33QXYT5HA5CNFSM4IYKOQN2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCOM64XY#discussion_r355397943, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AKK5VL3KOTYXCMGL2IPLRKDQXYT5HANCNFSM4IYKOQNQ.

 Here is an overview of what got changed by this pull request:

Complexity increasing per file
==============================
- lib/improver/cli/convert_to_realizations.py  4

See the complete overview on Codacy