Remove vulkan_validation_layers secondary build file

https://github.com/flutter/buildroot/pull/736 introduces a secondary build file file the vulkan_validation_layers since we believe there is an error in its BUILD.gn file.  The secondary build file is intended to be a temporary patch until we can get the issue fixed in upstream.

I tried to upstream the fix here: https://github.com/KhronosGroup/Vulkan-ValidationLayers/pull/5910
I'm not sure if that's going to fly though.  There may be some other considerations since it lives in the kronos repo.

The upstream patch seems to be merged!

The upstream patch seems to be merged! I guess we just need to wait for the roll?

Yep, I think so.  Hopefully it's an easy roll.


SetObjectProperty - add tests

Need to add tests for the new SetObjectProperty command.

I added tests.  Close this issue.


Cross-domain experiments for forgery detection

Thanks for the great work, how is the cross domain for forgery detection done? I found many papers trained on ff++ and tested on cdf and dfdc, how is this achieved? Is it 720 videos selected from each of the four subsets of ff++? I know how the separate subsets are trained, but I don't know how to aggregate them, looking forward to your reply, thanks.

Hey, there are two ways to aggregate the videos I have seen in existing work: 1. directly aggregate the videos from all subsets. 2. only use the videos from one subset, such as Deepfakes subset. Hope this will be useful.

Thanks for the reply, in that case it feels like merging all subsets of videos might work better?

Personally I think it depends on the method.

Thank you for your answer, it helps me a lot!


[Enhancement] Refactor load trace log

What type of PR is this：

[ ] bug
[ ] feature
[ ] enhancement
[x] others

Which issues of this PR fixes ：

Fixes #5675
Problem Summary(Required) ：

Use txn_id:  to unify the log of all transaction id

[FE PR Coverage check]
:disappointed: fail : 5 / 26 (19.23%)
file detail

path
covered line
new line
coverage

:large_blue_circle:
com/starrocks/alter/SchemaChangeJob.java
0
2
00.00%

:large_blue_circle:
com/starrocks/master/MasterImpl.java
0
2
00.00%

:large_blue_circle:
com/starrocks/service/FrontendServiceImpl.java
0
5
00.00%

:large_blue_circle:
com/starrocks/transaction/DatabaseTransactionMgr.java
0
2
00.00%

:large_blue_circle:
com/starrocks/transaction/GlobalTransactionMgr.java
0
9
00.00%

:large_blue_circle:
com/starrocks/transaction/PublishVersionDaemon.java
0
1
00.00%

:large_blue_circle:
com/starrocks/load/DeleteJob.java
1
1
100.00%

:large_blue_circle:
com/starrocks/transaction/TransactionState.java
1
1
100.00%

:large_blue_circle:
com/starrocks/load/DeleteHandler.java
1
1
100.00%

:large_blue_circle:
com/starrocks/alter/SchemaChangeJobV2.java
1
1
100.00%

:large_blue_circle:
com/starrocks/alter/RollupJobV2.java
1
1
100.00%

run starrocks_fe_unittest

[FE PR Coverage check]
:disappointed: fail : 6 / 29 (20.69%)
file detail

path
covered line
new line
coverage

:large_blue_circle:
com/starrocks/alter/SchemaChangeJob.java
0
2
00.00%

:large_blue_circle:
com/starrocks/master/MasterImpl.java
0
4
00.00%

:large_blue_circle:
com/starrocks/service/FrontendServiceImpl.java
0
5
00.00%

:large_blue_circle:
com/starrocks/transaction/GlobalTransactionMgr.java
0
9
00.00%

:large_blue_circle:
com/starrocks/transaction/PublishVersionDaemon.java
0
1
00.00%

:large_blue_circle:
com/starrocks/transaction/DatabaseTransactionMgr.java
1
3
33.33%

:large_blue_circle:
com/starrocks/load/DeleteJob.java
1
1
100.00%

:large_blue_circle:
com/starrocks/transaction/TransactionState.java
1
1
100.00%

:large_blue_circle:
com/starrocks/load/DeleteHandler.java
1
1
100.00%

:large_blue_circle:
com/starrocks/alter/SchemaChangeJobV2.java
1
1
100.00%

:large_blue_circle:
com/starrocks/alter/RollupJobV2.java
1
1
100.00%

run starrocks_fe_unittest

[FE PR Coverage check]
:disappointed: fail : 6 / 29 (20.69%)
file detail

path
covered line
new line
coverage

:large_blue_circle:
com/starrocks/alter/SchemaChangeJob.java
0
2
00.00%

:large_blue_circle:
com/starrocks/master/MasterImpl.java
0
4
00.00%

:large_blue_circle:
com/starrocks/service/FrontendServiceImpl.java
0
5
00.00%

:large_blue_circle:
com/starrocks/transaction/GlobalTransactionMgr.java
0
9
00.00%

:large_blue_circle:
com/starrocks/transaction/PublishVersionDaemon.java
0
1
00.00%

:large_blue_circle:
com/starrocks/transaction/DatabaseTransactionMgr.java
1
3
33.33%

:large_blue_circle:
com/starrocks/load/DeleteJob.java
1
1
100.00%

:large_blue_circle:
com/starrocks/transaction/TransactionState.java
1
1
100.00%

:large_blue_circle:
com/starrocks/load/DeleteHandler.java
1
1
100.00%

:large_blue_circle:
com/starrocks/alter/SchemaChangeJobV2.java
1
1
100.00%

:large_blue_circle:
com/starrocks/alter/RollupJobV2.java
1
1
100.00%


BaseObject and rework of tags system, including dynamic tags

Rework of PR #1099 which is in turn a rework of PR #891 (by @RNKuhns), based on discussion recorded in #981 on tags.
Adds a BaseObject class which adds dynamic tag functionality. BaseObject contains BaseEstimator functionality sans fit state change related interfaces.
The new functionality replaces the inconsistent mixture of old interface points (all_tags, has_tag) in all downstream dependencies.
post-PR, tags work like this:

each class will have "class tags", stored in the content of the class variable _tags: dict. Individual class tags are considered to override each other as per normal nested inheritance. E.g., if a parent class and the class have different values for a class tag, the younger class' class tag value counts.
each object can, in addition, have dynamic tags, in the object variable _tags_dynamic: dict. These are expected to be initialized in the constructor, for instance in cases where behaviour described by tags depends on components or hyper-parameters. Dynamic tags are always considered to override the class tags - e.g., if the object's class or a parent class have a static tag of the same name, the dynamic tag's value overrides any class tag's value.

The new tag related methods make use of this inheritance logic are as follows.
class methods:

get_class_tags() collects all class tags and their values and returns them as a dict (keys = tag names, values = tag values). It overrides values precisely as described above, in the return dictionary. This replaces the old _all_tags.
get_class_tag(tag_name, tag_value_default=None) retrieves the value of an individual tag with name tag_name, and optionally allows to specify a default value if the tag is not found. The inheritance/override logic is the same as in get_class_tags.

object methods:

get_tags() collects all class tags and dynamic tags and their values and returns them as a dict (keys = tag names, values = tag values). It overrides values precisely as described above, in the return dictionary.
get_tag(tag_name, tag_value_default=None) retrieves the value of an individual tag with name tag_name, and optionally allows to specify a default value if the tag is not found. The inheritance/override logic is the same as in get_tags.
set_tags(**tag_dict) sets dynamic tags according to keys (=tag names) and values (= tag values) in the argument dictionary. It is expected to be used in constructors typically.
mirror_tags(estimator, tag_set=None) is a shorthand version of set_tags, where it sets tags according to their get_tag values in estimator. The tags that are mirrored/copied in this way can be restricted by specifying a list of tag names in tag_set, otherwise all tags are copied over. The mirroring is by-reference and not by-value (if the type allows this), but tags are not expected to be mutated.

in set_tags we should check that the passed tags are valid tags for the given estimator

I'd prefer not to, since this couples the BaseObject to the registry.
I also think we want to give the extender - or even the user - the opportunity to set their own tags easily, if they just work locally and hack around.

have addressed change requests, except one:
I´d rather not rename get_tags to get_object_tags, because it retrieves all tags (not just object/dynamic ones).

so, I've thought about the copy issue.
I think my concerns about possible side effects are valid - mutability is an issue, but operations that pass reference rather than value are also an entry point for potential side effects. This is a potential issue since tags are no longer just boolean, so let's be defensive here.
I've now added a deepcopy in these places: at the end of get_tags, get_class_tags, and at the start of set_tags and clone_tags. This should make sense (because it "breaks" any references).

@mloning, can you please have a look? #980 is conditional on this, on which other stuff is conditional.
Would appreciate if you help unblocking the bottleneck.

(sorry for being pushy, but I like to believe it's for the best)

from discussion: value range checks should be done by object level tests
this will need additional convention in registry on items with discrete value space, e.g., which strings are admissible

Testing is still missing

No longer!

tests run locally, builds were ok before merging doc related PR, so it's fine to merge


[Config-ui] Guide users to the corresponding dashboards after data collection

Search before asking

[X] I had searched in the issues and found no similar feature requirement.

Description
Currently, users jump to Grafana homepage after data collection when clicking the 'View Dashboards' button on the config-UI.
As a result, many users can't find the right dashboards to view. In an ideal world, users will be visiting the dashboards based on the data they have collected.
Use case
If users have collected Github and Jira's data, config-UI should provide links to such pre-built dashboards:

Github basic metrics
Weekly bug retro
Weekly community retro
Jira

Related issues
No response
Are you willing to submit a PR?

[ ] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

This issue has been automatically marked as stale because it has not had recent activity for 30 days. It will be closed in next 7 days if no further activity occurs.

We will keep this.

here

I got a new idea by adding a new homepage dashboard.


Devfile does not create metadata.name but creates metadata.generateName

/kind bug

What versions of software are you using?
Operating System: Linux
Output of odo version: Master branch
How did you run odo exactly?
odo create java-spring-boot

Actual behavior
Here is the output:
apiVersion: 1.0.0
metadata:
  generateName: java-spring-boot
projects:
  -
    name: springbootproject
    source:
      type: git
      location: "https://github.com/odo-devfiles/springboot-ex.git"

Expected behavior
Shouldn't we also have metadata.name entry too?
According to https://redhat-developer.github.io/devfile/devfile.html generateName will be used for: Workspaces created from devfile, will use it as base and append random suffix. It’s used when name is not defined.
If the user does not provide a name, shouldn't we propagate the metadata.name slot too?
Any logs, error output, etc?
N/A

@cdrage Not quite.
I'm gonna start with Che first. When you create a workspace from a devfile in Che, it requires either name or generateName to be set in the devfile. If name is set, that becomes the name of the workspace. If generateName is set, it generates a random name, prefixed with the value of generateName. It does not propagate the name of the workspace to metadata.name.
Odo's using those fields slightly differently, than Che, however. In the context of odo, we use the metadata.generateName field as the the devfile name in the catalog: https://github.com/openshift/odo/blob/898cd396f5f2fc97af139fb1a730858c3379a6b3/pkg/catalog/catalog.go#L214
We don't use it as the component name when creating odo components.
However, from looking at our code, it seems we don't support listing devfiles in the catalog that use metadata.Name, and that should be fixed.

In devfile v2 there is no GeneratedName , odo should just use name. Name field is optional so we will need to figure out what to do if there is no name


Feat/lt/refactor msg push api

关联的Issues (Related Issues)

close
改动 (Proposed Changes)

附注 (Additional Info)

[ ] 回滚的问题（还是升级失败版本回退的问题？）
simlecode on 24 Aug
考虑留着？万一要回滚，没上链的消息就没有这两个值了

自查清单 (Checklist)
在你认为本 PR 满足被审阅的标准之前，需要确保 / Before you mark the PR ready for review, please make sure that:

[x] 符合Venus项目管理规范中关于PR的相关标准 / The PR follows the PR standards set out in the Venus project management guidelines
[x] 具有清晰明确的commit message / All commits have a clear commit message.
[x] 包含相关的的测试用例或者不需要新增测试用例 / This PR has tests for new functionality or change in behaviour or not need to add new tests.
[x] 包含相关的的指南以及文档或者不需要新增文档 / This PR has updated usage guidelines and documentation or not need
[x] 通过必要的检查项 / All checks are green

Codecov Report

:exclamation: No coverage uploaded for pull request base (release/v1.9.0-pre-rc1@41db9c7). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files

@@                    Coverage Diff                    @@
##             release/v1.9.0-pre-rc1     #271   +/-   ##
=========================================================
  Coverage                          ?   53.79%
=========================================================
  Files                             ?       62
  Lines                             ?     6564
  Branches                          ?        0
=========================================================
  Hits                              ?     3531
  Misses                            ?     2748
  Partials                          ?      285

Flag
Coverage Δ

unittests
53.79% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.


support  vue？

support  vue？

We are currently developing core features and there are also some important optimizations that need to be done, so we are unlikely to support Vue in the short term.
Thank you for your feedback :)


Make mapActionTo Comply w/ Flux Standard Action

Move the source information to meta.
Fixes #30.

[ ] Add docs for mapActionTo

sources is added as a deprecated attribute to the payload. The next release after this gets released will remove all deprecated code from brookjs (including the key in the children configuration).


Profanity Filter

Profanity Filter
Features

Filter profanity
Ability to adjust strictness
See tutorials for possible implementation

Closing as this can be achieved with the automod.


Change publish_sync/5 to publish_sync/4

I think the interface would be much prettier if we moved the timeout into the opts in the publish_sync; the default should still be :infinity
lib/tortoise.ex:22:15:  defdelegate publish_sync(client_id, topic, payload \\ nil, opts \\ [], timeout \\ :infinity),
lib/tortoise/connection.ex:81:7:  def publish_sync(client_id, topic, payload \\ nil, opts \\ [], timeout \\ :infinity) do

This happened in f23a8e5
Sorry for shooting directly into master.


Remove hard-coded pipeline version from WDLs

Purpose
Defining the analysis workflow version in the WDL itself requires keeping that hard-coded version variable up to date. This is prone to manual errors and complicates the release process for pipelines in Skylab.
Changes
Remove this variable, so that the github tag is the source of truth for the pipeline version
Note: This should be merged after the adapter pipelines are updated to use the pipeline versions specified in Lira's config instead of the pipeline WDLs:

https://github.com/HumanCellAtlas/adapter-pipelines/pull/6
https://github.com/HumanCellAtlas/lira/pull/188

Review Instructions

No instructions.

retest this please

According to @kbergin:

In our new release process we’ve recently implemented for the rest of the GP Pipelines we also put the version number in the wdl and wrote a script to confirm it’s updated when there have been changes to the pipeline. We intend to output this version number into the headers of bams and similar outputs in the future.

So considering this version could be used in a similar way for the HCA pipelines in the future, we can leave them in for now but still update Lira and the adapter-pipelines to use the pipeline version defined in the config.


Revise copy-and-paste helper for codenew shortcode

SweetAlert is used only to warn when a click-to-copy-manifest click fails. Load it asynchronously.
only load the copy and paste helper script on pages that have a {{< codenew >}} shortcode.
only load SweetAlert when the copy and paste helper is in use

Previews:

https://deploy-preview-24229--kubernetes-io-master-staging.netlify.app/ (front page)
https://deploy-preview-24229--kubernetes-io-master-staging.netlify.app/docs/tutorials/stateless-application/guestbook-logs-metrics-with-elk/ (example with copyable text)

/retitle Revise copy-and-paste helper for codenew shortcode

/area web-development

layouts/partials/footer-scripts.html was not loading, so I also removed that.

Another example:
https://deploy-preview-24229--kubernetes-io-master-staging.netlify.app/docs/concepts/services-networking/ingress/
Looks good. The script appears just before the end of the page body.
/lgtm

Thanks @sftim .
/approve


RDKTV-7170 : DEEPSLEEP and CEC wake up

Reason for change: RDK request active source should come from app
Test Procedure: deepsleep wakeup, deepsleep cec wakeup
Risks: Create None
Signed-off-by: KRN11<EMAIL_ADDRESS>

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


feat(ui): support Shutter voting

Design TBD

Support for only offchain or also sx ?

@wa0x6e Only Snapshot offchain


Pushbullet

I made a pushbullet account and installed it on my pc and phone. After that I entered the pushbullet accestoken into the settings. But when I click test push, nothing happens. Also nothing happens on my phone. Is this an error on my side, or is it not working atm?

it should be working, try to save settings and quit application, start it again and it should work

If on the icon you see the red cross then it means that it is disabled

Ah I didn't see that, thankyou so much! It works now, what an amazing program!

Sorry to open it again, but the test push works, but once I get trade message incoming I don't get a notification in Pushbullet.. not sure why, because the first test message came thru

I'm not sure why is that but if test message is working you can go to settings -> open tests -> random incoming item message.
If that message will be send to your phone then the other ones should be send also

Yes! Seems to work again, not sure what happened! I also saw you can see logs? For if it crashes or something. But i only have 2 files in my log folder and they're both not the one with the trade messages. Both are empty


Make blue sqiggles go away

Prerequisites

[x] Put an X between the brackets on this line if you have done all of the following:

Checked that your issue isn't already filed.
Reduced the issue to a self-contained, reproducible test case.

Description
See Zulip Thread.
The LSP reports output messages (e.g. from #eval) as DiagnosticSeverity.information which results in them showing up as blue squiggles and as "Problems" in the VS Code Output tab.  If we switch them to DiagnosticSeverity.hint then the squiggles are replaced with a nice little triple dot you can hover over and the Problems output tab is cleaned up:

Steps to Reproduce
import Foo

def main : IO Unit :=
  IO.println s!"Hello, {hello}!"

#eval Lean.versionString

#eval main

Expected behavior: no blue squiggles or problems shown in Problems output tab
Actual behavior: blue squiggles and problems shown in Problems output tab
Reproduces how often: 100%
Versions
Lean 4 latest
Additional Information

From a semantic point of view, I think that "Information" fits better than "Hint" here. Maybe the proper solution is some theme customization?

The user doesn't really see whether it is "information" or "hint" though right?  It's just how we choose to map things to the LSP protocol.

The user does see "information" vs "hint" quite clearly, as you've observed: "information" shows up with the info icon in the Problems view. They are eye catching and bring your attention to them from anywhere in the project, which is exactly the intended behavior for something that is the equivalent of a write to stdout. "Hint" can only be seen when you happen to be looking in the area (there is no global list of them AFAIK) and plays a role more similar to code lens or other local information gathering.
That is all to say that I agree with Patrick: lean is using the correct mechanism to signal the output of output-producing operations in the IDE. If you want to make the blue squiggles go away, stop writing #eval and #check.

Closing this issue. See feedback above.

end of discussion then I guess.  What I was going to say is the #eval and #check show up in the InfoView, why do we need them to also be listed as "problems" when they are not problems?

That's something to take up with VSCode. Then again, I don't know what other title would be more appropriate besides Diagnostics which is it's own kind of jargon.

So I take it emacs doesn't have this issue?  Emacs does not show LSP "info" in a "Problems" list?


Installation from .deb fails when write access to /opt is unavailable

I work on a system where /opt is automounted, and therefore I do not have write access to it, even when installing with sudo. I can't find a way around this in the documentation.

If you can extract the non-/opt files from the deb into their place, I think the /opt files can live anywhere, as long as the line in run_keybase that starts with /opt/keybase/Keybase gets modified to point to the new location.
(I don't expect yours is a use case we're going to actively support, though.)


Add python example

This PR adds the care-pet example in Python. I worked based on the JS example and slightly narrowed the scope to focus on the most important elements.

Pyhon example should be added to the left menu and from the docs

See build-with-rust.md for an example

Ok let's do that in another PR @tzach . @annastuchlik could you also have a quick look if everything looks okay as far as menus and toctrees, formatting etc

This PR is already merged, but I've reviewed it, and everything looks and renders good.
Some minor language improvements may follow in another PR.


Update vscode-project-manager extension

Description
Updates the visual-studio-code-project-manager extension to replace textfield preference inputs with the richer appPicker and directory inputs. The goal is to allow users choose any VSCode fork on their system, where currently the extension is limited to a hardwired list of VSCode builds.
Screencast
After

Before

Checklist

[x] I read the extension guidelines
[x] I read the documentation about publishing
[x] I ran npm run build and tested this distribution build in Raycast
[x] I checked that files in the assets folder are used by the extension itself
[x] I checked that assets used by the README are placed outside of the metadata folder

This change looks superb to me. Nice work.

Hi!
Thank you for your contribution! My name is Milena and I will be reviewing it today.
I don't know if this is a consequence of your changes, but the error page when the user doesn't have the Project Manager is gone:

Do you mind taking a look? I don't see the same error on the version from the Store.

but the error page when the user doesn't have the Project Manager is gone:

@mil3na great catch, thank you! This error appears when the user hasn't configured a git client. A similar issue happens when the terminal app unset. I just pushed a fix for both.

Thanks for fixing it.
Now, I'm always seeing the "needs vscode project manager" screen all the time. But it is also something I see with the version from the store. I will check it again tomorrow, but if you have any pointers on what might be happening, I'm glad to read you.

Now, I'm always seeing the "needs vscode project manager" screen all the time. But it is also something I see with the version from the store.

Do you have the Project Manager extension installed in VS Code? Without that extension installed (and I think also until you've saved a project to the Project Manager extension in VS Code) that screen is expected.

hehe yes, I do have it

Great! Do you also have a project saved in the extension? I don't think the error message logic distinguishes between "doesn't have Project Manager installed" and "doesn't have any projects saved in Project Manager".


DI-26 Fix NotarySignatureVerificationService in the verification sandbox

DI-26 Fix NotarySignatureVerificationService in the verification sandbox
The previously injected TransactionSignatureService service was not working properly there, so transitioning to TransactionSignatureVerificationServiceInternal.

build e2e


Not logging in tune.py

Hi @cs2be @reyoung
I need help to resolve my issue. During tune.py, It stops generating log after that (wait for 3 hours)
[INFO 2018-06-02 04:42:49,663 layers.py:2716] output for __con
v_0__: c = 32, h = 81, w = 54, size = 139968
[INFO 2018-06-02 04:42:49,664 layers.py:3361] output for __bat
ch_norm_0__: c = 32, h = 81, w = 54, size = 139968
[INFO 2018-06-02 04:42:49,665 layers.py:7533] output for __sca
le_sub_region_0__: c = 32, h = 81, w = 54, size = 139968
[INFO 2018-06-02 04:42:49,666 layers.py:2716] output for __con
v_1__: c = 32, h = 41, w = 54, size = 70848
[INFO 2018-06-02 04:42:49,666 layers.py:3361] output for __bat
ch_norm_1__: c = 32, h = 41, w = 54, size = 70848
[INFO 2018-06-02 04:42:49,667 layers.py:7533] output for __sca
le_sub_region_1__: c = 32, h = 41, w = 54, size = 70848
[INFO 2018-06-02 04:42:54,934 model.py:243] begin to initializ
e the external scorer for decoding
[INFO 2018-06-02 04:44:17,487 model.py:253] language model: is
_character_based = 0, max_order = 5, dict_size = 400000
[INFO 2018-06-02 04:44:17,746 model.py:254] end initializing s
corer
[INFO 2018-06-02 04:44:17,747 tune.py:119] start tuning ...

Used Cuda v8, Cudann V7, Ubuntu 16.04, GPU Tesla P100.
It's working totally in good condition with test.py
Thank You for any help

Hi, I encountered the same problem as you did.
Did you solve the problem and how?
Thanks


Action Performed Message

For animations, logging of what is happening, or for anything else, it would be beneficial to add a ActionPerformedMessage that is sent to clients after an action has been fully performed by any player.
Should contain:

action name
entity id that the action belongs to
performer entity id
targeted entity ids

UseAbilityMessage can now be sent also from server to clients that contain all the information about what is happening.


Add github.com/thegeekyasian/go-chi-otel to registry

Adding an adaption of OTEL for gochi/chi to the registry.
https://github.com/thegeekyasian/go-chi-otel

/fix refcache

Okay, I will pull this in as the change in main that is breaking isn't related to this change.

I don't think this should be included in the repository:

The repository was an unattributed copy of otel-chi
I opened an issue in this repository, and the repository has since been deleted.

thanks for letting us know @Isnor


Question: Keeping the base of a canvas drawing?

Hello,
Firstly I would like to thank you for maintaining this library. I have used it for a bit now, and it works great!
As my title implies, I have a question. I aim to have a basic sketch on the canvas, representing a track layout so that I can then draw the riders' positions on the track layout, without having to recreate the track layout on every rider position update.
My question is, what would be the best way to achieve this?
Of course, I can redesign the entire track every time a rider changes his position, but that feels a bit inefficient. Therefore I'm trying to find a way to only draw the rider positions on it.
I already tried setting the layout once, and then updating the positions every second, but that resulted in the previous location being present as well. Am I overlooking something here?
I also thought of layering the canvasses, but I don't see any way of doing that, as that doesn't seem to be an implementation. This would basically mean that I have the track layout and that another canvas is being drawn on top of it, so when I clear the second canvas the first canvas keeps its drawings.
Besides the above I also noticed a _context.CanvasState.SaveAsync(); and a _context.CanvasState.SaveAsync();. I'm not entirely sure what this option does, since I can't find any documentation (I may be blind 😅). I assume that as the name implies it saves the current state of the canvas, and you can restore that state at a later point. However when I tried doing so by creating the base layout, saving that state, and every time I want to update a rider his location I reset the canvas and place the new position on the canvas, but that doesn't seem to do anything.
I'm most probably overlooking something, and I hope you are so kind as to give me some advice, as to how I could tackle this in the best way!
Thanks in advance,
Bram

Hi @Bram1903,
Your ideas on how to solve this all sound good to me, but I haven't done that task myself so far, so can't speak from experience in how to achieve this.
I think layering is an elegant approach, as it's very easy to reason about the state of both the background and the foreground.
In terms of finding out best practices, I'd recommend looking at the html canvas documentation, as well as on stackoverflow. You can search for pure JavaScript solutions, as translating it to this library is trivial (either use the async methods, so you'd essentially camel case every method and append async, or you use context.JS.methodnamegoeshere(...)).
Saving state is not the right choice though. You can see that using the documentation here: https://developer.mozilla.org/en-US/docs/Web/API/CanvasRenderingContext2D/save
This method saves the state of certain rendering properties, not whatever has been drawn so far.
Hope that helps!
Stefan


Spotlight list browsing

I have implemented the possibility to use the arrows keys (left and right) to iterate over the participates and put them into the spotlight, just as if I would click the participant on the participant list. This allows to quickly browse thought speakers that are currently passive and fix a chosen one on the screen. However, as I'm not a react programmer, the code is a bit clumsy, so you might want to implement it yourself.

I have created a pull request
#291

It is merged so I close this.
The only open thing is here to review. @havfo @so010 please review it if you have time.


Add core-js polyfill for pdfjs to support older Chrome & Safari versions

Details
pdfjs (a dependency of react-js which we use in PDFViewer) uses Array.prototype.at() which is only supported on newer versions of both Chrome (2021-07-20 release) and Safari (v15.4, 2022-03-15). Especially for Safari it seems worth supporting as it's highly likely that people may be stuck on an unsupported version.
Fixed Issues

$ https://github.com/Expensify/App/issues/22395
PROPOSAL: https://github.com/Expensify/App/issues/22395#issuecomment-1658109973
Tests

iOS - use a simulator with iOS 15
Android - use an AVD with API 31 (i.e. Android 12)
Desktop - download an older version of chrome (I used 92.0.4473.0). Linux here, Mac here - it's probably safest to run in a VM or using the --user-data-dir flag to avoid corrupting any existing profiles. I also needed to add --disable-gpu --no-sandbox flags to get it working.

Open NewDot on an older version of Chrome (<=92.0.4473.0) or Safari (<15.4).
Verify that the error key.split(...).at is not a function does not appear in the console

[x] Verify that no errors appear in the JS console

Offline tests

N/A
QA Steps

Same as above.

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web
https://github.com/Expensify/App/assets/27287420/b939130a-83ce-4794-9edb-e01a1a0f1bd0

Mobile Web - Chrome
https://github.com/Expensify/App/assets/27287420/412e63ad-a2ca-4b22-bc61-6d3312d7607b

Mobile Web - Safari
https://github.com/Expensify/App/assets/27287420/e9c1f060-a8ad-4ae3-820a-221161db208a

Desktop
https://github.com/Expensify/App/assets/27287420/2a8c452c-b470-4c27-ba5a-6171dae081ad

iOS

Android

Reviewer Checklist

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR

[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] Android / native
[x] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[x] MacOS / Chrome / Safari
[ ] MacOS / Desktop

[x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

I need to download iOS 15 and then test on that. But most of it looks good.

For some reason I am stuck at downloading the iOS 15 simulator. It is my 3rd attempt with more than 4 hours of wait period.

@jjcoffee Better to mention the exact iOS Safari version <=15.3 in the Test steps.

@mananjadhav Good point, it's much clearer that way - updated now!

thanks @jjcoffee. @Julesssss All yours.
🎀 👀 🎀 C+ reviewed.

Shared this here in Slack

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/Julesssss in version: 1.3.51-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

@jjcoffee @mananjadhav @Julesssss QA is having a hard time testing this PR on older browser versions. Could one of y'all please test this on staging and confirm that it is working as expected?

Ah my bad, we probably should have made this NO QA as it's an issue that only really occurs on dev (the Old Android emulator chrome version is outdated and requires polyfill)
checking it off now

🚀 Deployed to production by https://github.com/Julesssss in version: 1.3.51-2 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to staging by https://github.com/Julesssss in version: 1.3.52-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
failure ❌

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to staging by https://github.com/Julesssss in version: 1.3.52-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/puneetlath in version: 1.3.52-5 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Adding put and delete BMI operations to baremetalinfrastructure.json spec

ARM API Information (Control Plane)
Changelog
Add a changelog entry for this PR by answering the following questions:

What's the purpose of the update?

[ ] new service onboarding
[ ] new API version
[x] update existing version for new feature
[ ] update existing version to fix swagger quality issue in s360
[ ] Other, please clarify

When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

[x] I commit to follow the Breaking Change Policy of "no breaking changes"
[x] I have reviewed the documentation for the workflow.
[ ] Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist

Applicability: :warning:
If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

Change to data plane APIs
Adding new properties
All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

[ ] Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review.  Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

Adding a new service
Adding new API(s)
Adding a new API version
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki. Note that this doesn't apply if you are trying to merge a PR that was previously in the private repository.

[ ] Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

[ ] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist
If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.
NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)
Please follow the link to find more details on PR review process.

As a note, our RP does not support PUT or DELETE operations. However, as a requirement for GA, we need to return a response for them. The ARM team originally gave us the greenlight for only returning a "Not supported" code with a message stating the official routes needed to perform it. Which is why we do not have any 2xx responses listed.
Second, this is not a breaking change. This api version, 2023-04-06, received an exception very recently when it was created for not adding PUT/DELETE operations. This PR simply adds a formal "Not supported" response. No actual functionality with this operation has changed.

@konrad-jamrozik can we approve this breaking change?

@konrad-jamrozik can we approve this breaking change?

Please follow the guidance given in this comment:

https://github.com/Azure/azure-rest-api-specs/pull/24059#issuecomment-1553776172

As a note, our RP does not support PUT or DELETE operations. However, as a requirement for GA, we need to return a response for them. The ARM team originally gave us the greenlight for only returning a "Not supported" code with a message stating the official routes needed to perform it. Which is why we do not have any 2xx responses listed.

Can you link me to the greenlight from ARM team, so I can verify?

Second, this is not a breaking change. This api version, 2023-04-06, received an exception very recently when it was created for not adding PUT/DELETE operations. This PR simply adds a formal "Not supported" response. No actual functionality with this operation has changed.

I looked at that PR but it is not clear to me what exception was given there, sorry. Was it given by someone from ARM team? Can you link to it?

As a note, our RP does not support PUT or DELETE operations. However, as a requirement for GA, we need to return a response for them. The ARM team originally gave us the greenlight for only returning a "Not supported" code with a message stating the official routes needed to perform it. Which is why we do not have any 2xx responses listed.

Can you link me to the greenlight from the ARM team, so I can verify?

Second, this is not a breaking change. This api version, 2023-04-06, received an exception very recently when it was created for not adding PUT/DELETE operations. This PR simply adds a formal "Not supported" response. No actual functionality with this operation has changed.

To which of the failing checks of the breaking change it is referring to specifically? I mean the failures listed here.

@konrad-jamrozik can we approve this breaking change?

Please address my questions above, thx! :)
@bdefoy @rkmanda FYI

As a note, our RP does not support PUT or DELETE operations. However, as a requirement for GA, we need to return a response for them. The ARM team originally gave us the greenlight for only returning a "Not supported" code with a message stating the official routes needed to perform it. Which is why we do not have any 2xx responses listed.
Second, this is not a breaking change. This api version, 2023-04-06, received an exception very recently when it was created for not adding PUT/DELETE operations. This PR simply adds a formal "Not supported" response. No actual functionality with this operation has changed.

Note: ARM signed off on the private PR here: https://github.com/Azure/azure-rest-api-specs-pr/pull/12118.

@konrad-jamrozik now that the ARM team has responded, I'll touch on the breaking changes listed below:
Swagger BreakingChange: this is regarding the two operations we want to add to this API version.
Swagger LintDiff: Many of these errors are regarding the fact our PUT/DELETE methods do not have a valid status code. Which they should not as I've mentioned above (e.x. The delete operation is defined without a 200 or 204 error response implementation). I can add it to the specs, however it could be misleading as these operations should never return a 2xx code

@keryul @dsmith111 given that @mentat9 added ARMSignedOff label and provided relevant context in comments, looks to me this PR is OK to be merged.

Thanks. Can someone who's authorized go ahead and merge this PR? I don't have permissions.

I believe that’s up to @keryul

@raych1 please review the GO breaking change

@keryul @dsmith111 given that @mentat9 added ARMSignedOff label and provided relevant context in comments, looks to me this PR is OK to be merged.

Then I'll add Approved-LintDiff label

Friendly ping to get this merged

Hi @8Gitbrix! The automation detected breaking changes in this pull request. As a result, it added the BreakingChangeReviewRequired label. You cannot proceed with merging this PR until you complete one of the following action items: ACTION ITEM ALTERNATIVE A: Fix the breaking change. Please consult the documentation provided in the relevant validation failures. ACTION ITEM ALTERNATIVE B: Request approval. Alternatively, if you cannot fix the breaking changes, then you can request an approval for them. Please follow the process described in the High-level Breaking Change Process doc. ACTION ITEM ALTERNATIVE C: Report false positive. If you think there are no breaking changes, i.e. the validation should pass yet it fails, then please explain why in a PR comment and @ the PR assignee.

@8Gitbrix please get breaking change approval

@keryul @dsmith111 given that @mentat9 added ARMSignedOff label and provided relevant context in comments, looks to me this PR is OK to be merged.

@keryul, I was under the impression this process surrounding ARM's and @konrad-jamrozik's approval was specific to the breaking change that was flagged (i.e. these PUT/DELETE operations being added to this specific version even though they do not currently exist):

As a note, our RP does not support PUT or DELETE operations. However, as a requirement for GA, we need to return a response for them. The ARM team originally gave us the greenlight for only returning a "Not supported" code with a message stating the official routes needed to perform it. Which is why we do not have any 2xx responses listed.

Can you link me to the greenlight from the ARM team, so I can verify?

Second, this is not a breaking change. This api version, 2023-04-06, received an exception very recently when it was created for not adding PUT/DELETE operations. This PR simply adds a formal "Not supported" response. No actual functionality with this operation has changed.

To which of the failing checks of the breaking change detector are you referring to specifically? I mean the failures listed here.

@konrad-jamrozik can we approve this breaking change?

Please address my questions above. I also recommend addressing the other failures. Thx! :)
@bdefoy @rkmanda FYI

Specifically flagged here where I mentioned the "new version breaking change" issue the automation detected

@rkmanda, another PR I reassigned to you that needs your attention.

@rkmanda Ping to merge the PR. Thanks!

Can someone help merge this?

/azp run

@8Gitbrix apologies for the delay. We are dealing with large amount of PRs plus we have been making changes to the PR review process to streamline it.
You have failing requirements:

https://github.com/Azure/azure-rest-api-specs/pull/24059/checks?check_run_id=15442575791

Please address them by following this process:

https://github.com/Azure/azure-rest-api-specs/blob/main/.github/PULL_REQUEST_TEMPLATE/spec_pr_review_workflow_diagram.png

Thanks!

@konrad-jamrozik Thanks for the reply. As David mentioned before this version 2023-04-06, received an exceptionwhen it was created for not adding PUT/DELETE operations. Despite no breaking changes or change in functionality, do I still need to follow this guidance? I was under the impression that this issue was resolved before.

@konrad-jamrozik, can you send us or ping the reviewers responsible for handling breaking change exceptions?
From the error list you've shared;

We've received the ARM Signed off label it's complaining about:

We've received the SDK breaking change sign-off:

The only issue we can "address" is the breaking swagger changes:

However, as you can see, the entire PR comprises of these changes. Fixing it would just be deleting the PR. The change would not break any customer as the PUT/DELETE operations are modified to return a failure status code with a message officially stating the operation is not supported. While originally it just returned a failure code dictating "method not allowed". Customer's will not be building off of this as it does not exist, and will not after the PR as we are not adding any functionality in. We are just adding in the message for GA compliance.
I'd appreciate being pointed to the responsible owners of general breaking changes to discuss the plan going forward.

@dsmith111 @8Gitbrix we have been improving the guidance rapidly in last few days so it is in a bit of a flux, apologies for that. You can find the current guidance here:

https://github.com/Azure/azure-rest-api-specs/blob/1635191726c958d7a2ff573a4aa82ad84d67488f/.github/PULL_REQUEST_TEMPLATE/control_plane_template.md

You had ARMSignedOff but you did not have Approve-BreakingChange label. Because I triggered /azp run, automation re-ran and detected you are missing breaking change approval. As a result, it removed your ARM sign-off.  See the diagram I shared above, steps 1 and 2.
Re this:

However, as you can see, the entire PR comprises of these changes. Fixing it would just be deleting the PR. The change would not break any customer as the PUT/DELETE operations are modified to return a failure status code with a message officially stating the operation is not supported. While originally it just returned a failure code dictating "method not allowed". Customer's will not be building off of this as it does not exist, and will not after the PR as we are not adding any functionality in. We are just adding in the message for GA compliance.

You must follow the breaking change process to get your claims evaluated. If breaking change board approves, they will add Approved-BreakingChange label and then you can proceed to get your ARM review sign-off again. Again, please refer to the guidance in the link I shared. Breaking change approval is step 1 on the diagram, and ARM review and sign-off is step 2.
Sorry for the confusion!


Bite marks

Changes / Comments

Updated JSON file so it references the correct game.
Update css file with a fix to an image url.

Roll20 Requests
Comments are very helpful for reviewing the code changes. Please answer the relevant questions below in your comment.

[ ] Does the pull request title have the sheet name(s)? Include each sheet name.
[ ] Is this a bug fix?
[ ] Does this add functional enhancements (new features or extending existing features) ?
[ ] Does this add or change functional aesthetics (such as layout or color scheme) ?
[ ] If changing or removing attributes, what steps have you taken, if any, to preserve player data ?
[ ] If this is a new sheet, did you follow Building Character Sheets standards ?

If you do not know English. Please leave a comment in your native language.

Please resolve the merge conflicts. Thanks!

Please resolve the merge conflicts. Thanks!

Hi Olivia. I'm new to GitHub and am not exactly sure what to do. When I click on "resolve conflicts" I get the info below. I updated my branch on Bite-Marks and I thought the pull request is suppose to update master.
<<<<<<< Bite-Marks
background: url('https://raw.githubusercontent.com/Roll20/roll20-character-sheets/master/Bite-Marks/bm_roll_bg.png') top left;
background-size: 100% 100%;
text-align: center;
padding: 10%;
}
background: url('https://raw.githubusercontent.com/Roll20/roll20-character-sheets/Bite-Marks/bm_roll_bg.png') top left;
background-size: 100% 100%;
text-align: center;
padding: 10%;

}

master

@cczernia , take at look at the following link for assistance with solving merge conflicts: https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/resolving-a-merge-conflict-on-github


Error in MovieClip animation

This issue may be related to #1702 but I have a very simple example file that may help to find the bugs more quickly.
I created a MovieClip that is used as a button with a normal state and a rollover state.
This is the expected behaviour. Works in Flash and HTML5

But is wrong in CPP and Neko. The rectangle disappears after the first rollover

My library versions are: openfl 8.7.0 and lime 7.2.0
I think it has something to do with the normal and rollover states of the rectangle being only in one frame of the movieclip.

This is the link to the source files
Thank you

took a quick look at this one, looks to me like the  graphics  is never set dirty after the first render or something related to the __dirty property.  CairoGraphics render method is always getting graphics.__dirty = false.

@0xA3 The fix I wrote yesterday should now be in the develop branch.  If you're using Haxe it should be fairly easy to check out the develop branch if you want to test it :)
Just follow the instructions in the README.md
https://github.com/openfl/openfl#development-builds
Or out use haxelib git feature
https://lib.haxe.org/documentation/using-haxelib/#git


Gate, Gate Buttons and spinner

The gate, Gate Buttons and spinner should now work

Thank you!
This includes @KGuNN45's previously reverted commits from #54


System.AccessViolationException

I'm getting a system access violation exception when attempting to access a Body.Position before or after the physics step. Any idea how I might fix this? I'm guessing it has something to do with multithreading, but I'm also not explicitly enabling multithreading anywhere, so not sure if that's something which is turned on by default?
Any idea how I can fix this?

Hi,
As you can immagine i don't have a magic sphere and fix issues without a repro case, please share some code and I can try to help.
Thanks!


idle_inhibit tooltip-format

Seems like the idle_inhibit module doesn't have a tooltip-format option and just uses the {state} format string. It would be good to have a tooltip-format like eg the battery, network, and wlr/taskbar modules.

@daveriedstra Can this be closed now?

@bd-g yes, thanks for asking and thanks @asas1asas200 for implementing. I didn't notice it had been done :)


Before:

After:

Thanks for going the extra mile. Merged.


Last round of testing web3connect

[x] Not getting profile picture
[x] Start load screen earlier
[x] "Your public profile" margin on mobile side drawer
[x] Walletconnect working (on Tokenary)
[x] Status bug
[x] if you cancel signing for walletconnect, it tries to use that same failed, unverified account to sign and so will make stuck the process [created ticket in w3c github]
[x] walletconnect cannot have direct login
[x] walletconnect working with metamask, tokenary
[x] portis bug on web2 mobile browsers
[x] Walletconnect working (on imToken, Opera Touch)

Last review:

[ ] login text not fitting
[x] treat walletconnect differently, cannot be used as a default wallet

log does not show all the data, log is inconsistent with the data


feat(lep): pre-pull share-manager/instance-manager images

Which issue(s) this PR fixes:

Issue # longhorn/longhorn#8376

cc @james-munson  for review

The resource usage of the pre-pull image container pre-pull-share-manager-image:
root@rancher60-worker1:~# crictl stats
CONTAINER           NAME                           CPU %               MEM                 DISK                INODES
...
4493f3cdca904       longhorn-manager               0.25                48.65MB             77.82kB             18
4ba3c011b587e       csi-provisioner                0.07                12.3MB              36.86kB             11
5d6a790970abe       instance-manager               0.04                14.57MB             69.63kB             20
6a4a1c8533f36       longhorn-csi-plugin            0.00                15.89MB             77.82kB             19
73268e5ee9882       pre-pull-share-manager-image   0.00                1.61MB              36.86kB             9
...

It remains at 1.6MB for memory usage.
And it will not start the nfs-ganesha server.

I tried running a longhorn-manager like the latest PR describes looking for the issues described in https://kubernetes.io/blog/2023/08/25/native-sidecar-containers/#how-did-users-get-sidecar-behavior-before-1-28. We don't really care about startup order, but it will be bad if the pre-pull container somehow blocks deletion. Neither of the following seemed to be problematic:

kubectl delete longhorn-manager... - Maybe it took longer than usual? However, the longhorn-manager pod was eventually deleted and recreated.

@mantissahz Have you measured how long will a longhorn-manager pod be deleted? Will

ssh <node> kill -9 <longhorn-manager PID> - Looks like the readiness probe failed and the longhorn-manager container restarted. No effect from the pre-pull container.

I'll be curious to hear from @james-munson if he thinks there are other scenarios we should worry about, but LGTM.


conan generator and slm_builder updates

conan_lbstanza_generator: convert backslashes to forward slashes in paths
slm_builder/conanfile.py: add default setting for shared=true to sub-dependencies

Outdated


[Bug]: Confetti flat option is not passed to new calls

Contact Details
No response
What happened?
When you use multiple confetti calls, only one flat option value is used.
Can we add rotate, tilt, roll and wobble in setConfetti addEmitter?
tsParticles Version
@tsparticles/confetti 3.3.0
tsParticles Configuration
confetti({
  shapes: ["circle", "square"],
  flat: false,
 });

confetti({
  shapes: ["circle", "square"],
  flat: true,
 });

What browsers are you seeing the problem on?
No response
Relevant log output
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

Thank you for the quick fix! When will v3 be released?

Thank you for the quick fix! When will v3 be released?

I need to do more tests, maybe 1-2 weeks


Footer with multiple entries

With the latest unstable version, can I have multiple entries for my Footer?
Eg.,
I want my footer to have "Total" and "Average" for each column.
So, Total and Average will be displayed under each column in the footer in separate rows.

Define functions
Array.prototype.avg = function (e) {
    if (this.length == 0)return 0;
    var t = 0;
    for (var n = 0; n < this.length; n++) {
        t += this[n]["entity"][e] / this.length
    }
    return t
};

Array.prototype.total = function (e) {
    if (this.length == 0)return 0;
    var t = 0;
    for (var n = 0; n < this.length; n++) {
        t += this[n]["entity"][e]
    }
    return t
};

Inside the controller define function for aggregating average and total:
averageAndTotal = function (e, t) {

        var n = e.avg(t.field);
        var r = e.total(t.field, n);
        return [n, r]
    };

Create a template
var temp = '

avg: {{ col.getAggregationValue()[0] | number : 2}}
total: {{ col.getAggregationValue()[1] | number : 2}}

';

Set aggregationType to averageAndTotal and footerCellTemplate to temp in gridOptions for column that you want to have this footer.
Hope it will help. Good luck!

Solution provided (not clear to me if that will work), but no response for 3 weeks.  Assuming issue is resolved, closing.

It worked. Great solution! @cyberlake

great


Use the atom-text-editor tag instead of the editor-colors class.

In stylesheets\rst-preview.less: Use the atom-text-editor tag instead of the editor-colors class.

Closing. Open a pull request to fix this, thanks!


Export from the GUI

Hi.. Is there a simple way to export a dataset from the GUI.
When i expand a subnet and mark all the hosts (The HTML output) and copy/paste.. the formating sucks.
/Jemmer

Not sure about GUI, but you can do it from CLI
nipap address list

No, unfortunately not.
Though, it's pretty simple to write a python script which performs a search query and writes the output as you'd like it. If you'd like to try, https://github.com/SpriteLink/NIPAP/blob/master/utilities/boilerplate.py is a good start.


error 404 arte.tv

Checklist

[X] I'm reporting a broken site
[X] I've verified that I'm running yt-dlp version 2022.06.29 (update instructions) or later (specify commit)
[X] I've checked that all provided URLs are playable in a browser with the same IP and same login details
[X] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[X] I've searched the bugtracker for similar issues including closed ones. DO NOT post duplicates
[X] I've read the guidelines for opening an issue
[X] I've read about sharing account credentials and I'm willing to share it if required

Region
FRANCE
Provide a description that is worded well enough to be understood
here is my problem:
yt-dlp https://www.arte.tv/fr/videos/104351-002-A/serviteur-du-peuple-1-23/
[ArteTV] 104351-002-A: Downloading JSON metadata
ERROR: [ArteTV] 104351-002-A: Unable to download JSON metadata: HTTP Error 404: Not Found (caused by <HTTPError 404: 'Not Found'>); please report this issue on  https://github.com/yt-dlp/yt-dlp/issues?q= , filling out the appropriate issue template. Confirm you are on the latest version using  yt-dlp -U
Provide verbose output that clearly demonstrates the problem

[X] Run your yt-dlp command with -vU flag added (yt-dlp -vU <your command line>)
[X] Copy the WHOLE output (starting with [debug] Command-line config) and insert it below

Complete Verbose Output
yt-dlp -vU https://www.arte.tv/fr/videos/104351-002-A/serviteur-du-peuple-1-23/
[debug] Command-line config: ['-vU', 'https://www.arte.tv/fr/videos/104351-002-A/serviteur-du-peuple-1-23/']
[debug] Encodings: locale UTF-8, fs utf-8, pref UTF-8, out utf-8, error utf-8, screen utf-8
[debug] yt-dlp version 2022.06.29 [9d339c4] (zip)
[debug] Python 3.8.10 (CPython 64bit) - Linux-5.4.0-121-generic-x86_64-with-glibc2.29 (glibc 2.31)
[debug] Checking exe version: ffmpeg -bsfs
[debug] Checking exe version: ffprobe -bsfs
[debug] exe versions: ffmpeg 4.2.7, ffprobe 4.2.7, rtmpdump 2.4
[debug] Optional libraries: certifi-2019.11.28, pycrypto-2.6.1, pyxattr-0.6.1, secretstorage-2.3.1, sqlite3-2.6.0
[debug] Proxy map: {}
[debug] Fetching release info: https://api.github.com/repos/yt-dlp/yt-dlp/releases/latest
[debug] Downloading _update_spec from https://github.com/yt-dlp/yt-dlp/releases/download/2022.06.29/_update_spec
Latest version: 2022.06.29, Current version: 2022.06.29
yt-dlp is up to date (2022.06.29)
[debug] [ArteTV] Extracting URL: https://www.arte.tv/fr/videos/104351-002-A/serviteur-du-peuple-1-23/
[ArteTV] 104351-002-A: Downloading JSON metadata
ERROR: [ArteTV] 104351-002-A: Unable to download JSON metadata: HTTP Error 404: Not Found (caused by <HTTPError 404: 'Not Found'>); please report this issue on  https://github.com/yt-dlp/yt-dlp/issues?q= , filling out the appropriate issue template. Confirm you are on the latest version using  yt-dlp -U
  File "/home/ludo77/.local/bin/yt-dlp/yt_dlp/extractor/common.py", line 640, in extract
    ie_result = self._real_extract(url)
  File "/home/ludo77/.local/bin/yt-dlp/yt_dlp/extractor/arte.py", line 54, in _real_extract
    info = self._download_json(
  File "/home/ludo77/.local/bin/yt-dlp/yt_dlp/extractor/common.py", line 1002, in download_content
    res = getattr(self, download_handle.__name__)(url_or_request, video_id, **kwargs)
  File "/home/ludo77/.local/bin/yt-dlp/yt_dlp/extractor/common.py", line 966, in download_handle
    res = self._download_webpage_handle(
  File "/home/ludo77/.local/bin/yt-dlp/yt_dlp/extractor/common.py", line 834, in _download_webpage_handle
    urlh = self._request_webpage(url_or_request, video_id, note, errnote, fatal, data=data, headers=headers, query=query, expected_status=expected_status)
  File "/home/ludo77/.local/bin/yt-dlp/yt_dlp/extractor/common.py", line 791, in _request_webpage
    raise ExtractorError(errmsg, cause=err)

  File "/home/ludo77/.local/bin/yt-dlp/yt_dlp/extractor/common.py", line 773, in _request_webpage
    return self._downloader.urlopen(self._create_request(url_or_request, data, headers, query))
  File "/home/ludo77/.local/bin/yt-dlp/yt_dlp/YoutubeDL.py", line 3596, in urlopen
    return self._opener.open(req, timeout=self._socket_timeout)
  File "/usr/lib/python3.8/urllib/request.py", line 531, in open
    response = meth(req, response)
  File "/usr/lib/python3.8/urllib/request.py", line 640, in http_response
    response = self.parent.error(
  File "/usr/lib/python3.8/urllib/request.py", line 569, in error
    return self._call_chain(*args)
  File "/usr/lib/python3.8/urllib/request.py", line 502, in _call_chain
    result = func(*args)
  File "/usr/lib/python3.8/urllib/request.py", line 649, in http_error_default
    raise HTTPError(req.full_url, code, msg, hdrs, fp)
urllib.error.HTTPError: HTTP Error 404: Not Found

[x] I've searched the bugtracker for similar issues including closed ones. DO NOT post duplicates

Duplicate of #3622

I just realized that there was already a bug in the deposit:
https://github.com/yt-dlp/yt-dlp/pull/3302


SAR-9283: update to audit service to change the CIO field to isMatch

2022-04-11 16:39:47,254 level=[WARN] logger=[application] thread=[application-akka.actor.default-dispatcher-10] rid=[] user=[] message=[Message not delivered to MQ because message was dropped after handling eventId=d02eb881-547c-43e7-b8a8-c8d11396f544, auditSource=incorporated-entity-identification-frontend, auditType=CIOEntityRegistration body: {"auditSource":"incorporated-entity-identification-frontend","auditType":"CIOEntityRegistration","eventId":"d02eb881-547c-43e7-b8a8-c8d11396f544","generatedAt":"2022-04-11T16:39:47.252+01:00","metadata":{"metricsKey":null},"tags":{"clientIP":"-","path":"/identify-your-incorporated-business/20477ba5-2a01-46ed-8293-d51ef68cff7e/check-your-answers-business","X-Session-ID":"session-44554df8-1660-4d2a-bd54-7788fdaa3131","Akamai-Reputation":"-","X-Request-ID":"govuk-tax-0cf89d41-5a2e-4768-8d43-0032374922d1","deviceID":"mdtpdi#c84f4de2-0d02-4887-964f-38179d57287c#1649174646716_5eleYzR60huTA/Ygi/1hHg==","clientPort":"-"},"detail":{"callingService":"Entity Validation Service","businessType":"CIO","companyNumber":"01234567","isMatch":"unmatchable","RegisterApiStatus":"not called","VerificationStatus":"Not Enough Information to call BV"}}]

An example fro dataservice of triggering the audit event


[SPARK-41554] fix changing of Decimal scale when scale decreased by m…

…ore than 18

What changes were proposed in this pull request?
Fix Decimal scaling that is stored as compact long internally when scale decreased by more than 18. For example,
Decimal(1, 38, 19).changePrecision(38, 0)

produces an exception
java.lang.ArrayIndexOutOfBoundsException: 19
    at org.apache.spark.sql.types.Decimal.changePrecision(Decimal.scala:377)
    at org.apache.spark.sql.types.Decimal.changePrecision(Decimal.scala:328)

Another way to reproduce it with SQL query
sql("select cast(cast(cast(cast(id as decimal(38,15)) as decimal(38,30)) as decimal(38,37)) as decimal(38,17)) from range(3)").show

The bug exists for Decimal that is stored using compact long only, it works fine with Decimal that uses scala.math.BigDecimal internally.

Why are the changes needed?
Not able to execute the SQL query mentioned above. Please note, for my use case the SQL query is generated programatically, so I cannot optimize it manually.

Does this PR introduce any user-facing change?

Yes, it will allow scale Decimal properly that is not currently possible due to the exception.
How was this patch tested?
Tests were added. The fix affects the scale decrease only, but I decided to also include tests for scale increase as I didn't find them.

Can one of the admins verify this patch?

Hi @cloud-fan, @MaxGekk, @gengliangwang, would you be able to review? Thank you!

thanks, merging to master/3.3!

@fe2s can you create backport PRs for other branches? Thanks!

@cloud-fan thank you, which branches should fix also? 3.1, 3.2 and 3.3?

3.2 and 3.3, as they are both active branches.


Need a maintainer?

Hi, I notice that this library has a lot of open issues and PRs. We're using your library here at Red Hat for our Keycloak product and I'd love to give back and help out with maintenance.
Let me know if you are interested, if so you can add me as a collaborator!

ping @hughsk

I'd be happy to add you as a maintainer if @hughsk is.

Great, while we wait on that I can already start opening some PRs to can improve things.

@timoxley I haven't gotten a response from @hughsk yet (also sent him an e-mail). What do you think would be the best way to proceed? Perhaps you can add me as a collaborator anyways?

@jonkoops I would if I had the permissions.

I just got permissions so I will close this issue :+1:


Titlebar Buttons Icons to be Made Platform Dependant

What feature or improvement do you think would benefit Files?
hello there ;
As things currently stand, the Files App displays Windows11 styled buttons in its titlebar.
Having remained on Windows10 for the time being (LEENOOX, here I come ; eventually), these icons ever so slightly differ from those native to my system version.
Requirements
I am not asking for these to respect any custom skin one may have applied one way or another ; for one, as there is no standardised way to do so on NT, and secondly, because that would be much too difficult and most likely not worth the effort ; nor am I asking for the UI to follow the general style of the OS, even though a roundedness of zero would be quite nice on Windows10.
Instead, I reckon a simple dictionary linking OS versions to a set of icons would be a nice solution.
Files Version
<IP_ADDRESS>
Windows Version
10.0.19045.2788
Comments
This is of very little matter, and would only result in a difference of a few pixels ; I am fully aware of this, and would not be surprised if it were to be rejected. Although, given that this would require such little effort, this makes it quite a single task to check off the list of UI-to-system cohesion.

Thank you for your feedback. If you have a good way to implement this, we'd be happy to accept but as far as we're aware this scenario isn't officially supported by WinAppSdk.


Enable Qemu to build ppc64le clamav-db image

This change is mandatory, database image can't be build without qemu package.


Loop start tick is written to file as byte instead of short

In v6, the loop start tick property is written to the file as a byte.
https://github.com/OpenNBS/nbs.js/blob/0a4636e837fbb4d80cdda18e2a41920ebcb86302/src/nbs/export/toArrayBuffer.ts#L89
This is also the case on v5:
https://github.com/OpenNBS/nbs.js/blob/c73eab8d7c8f15b244384304a48e0e1296e90a32/src/nbs/file/toArrayBuffer.ts#L79
As per the NBS file specification, it should be an unsigned short:

Despite this fact, it is read correctly in both versions as an unsigned short:
https://github.com/OpenNBS/nbs.js/blob/0a4636e837fbb4d80cdda18e2a41920ebcb86302/src/nbs/import/fromArrayBuffer.ts#L137
https://github.com/OpenNBS/nbs.js/blob/c73eab8d7c8f15b244384304a48e0e1296e90a32/src/nbs/file/fromArrayBuffer.ts#L112
This causes the first byte of the loop start tick to be stripped. For instance, a song with loop start tick set to 480 (0x1EC) becomes 224 (0xEC) after saving the file.

Commit https://github.com/OpenNBS/nbs.js/commit/8d854e0ed64fd2260007651561d276252d20691b was applied to v5 retroactively with this fix.


feat: toNumber option added to disable int to string conversion

feat: toNumber option added to disable int to string conversion
fix: add prettier to devDependencies to be able to run pre-commit hooks without polluting global node scope.

Couldn't you just do something like typeof n === 'string' ? ms(n) : n?

of course there are workaround, but what version tell the meaning of the code ?

first case, whatever it is i want a number in output.
2nd case, if it's a string, do stuff, probably formating/converting number, else don't touch it.

I really prefer first case.
but my code have it, so, do what you prefer for yours.


Create testsuite

Current state:
for base, devel and release mode

run whoami in exec.bash
=> check if correct container user is used
=> check if container was started/is running
=> check if current container uses correct image
run stop.bash
=> check exit status = 0
=> parse output and check if correct container is stopped
=> check that current container is not running anymore
=> check that current container exists as stopped container
=> check that stopped container is using the correct image
run delete_container.bash
=> check exit status = 0
=> check that current container does not exist anymore

To Test

[ ] test version mismatch warning
[ ] test storedrelease (store and remove)
[ ] test ownership of workspace in release image?

To Be Discusses

[ ] use base user for base images?
[ ] how should we test build.bash scripts? using dry-run approach?

I think naming the new folder "src" may be misleading for devs startign to use this (they have to enter workspace instead).
something like "docker_scripts" whoulf be better imo

Or even an hidden folder? ".docker_scripts"

I like the idea to have the scripts aka inner workings completely hidden from the user :+1:
What are your thoughts on the open questions I listed above?

Actually setting PS1 works and makes different users obsolete (much cleaner Dockerfile for the release)
Created a PR to this branch: https://github.com/dfki-ric/docker_image_development/pull/35 we can discuss there (e.g. the format of the PS1 var)

Thanks for the PR regarding PS1. Much cleaner and also more informative promt :+1:
Could you elaborate on your proposal to overwrite and auto_call setup_workspace. Do you want to add that as an additional test to the suite or is that an idea related on how to test the build.bash scripts?
Checking the extract workspace script is also a good idea.

Hi, you can automate calls on container creation:
Internally there is the /opt/init_workspace.bash script:
created here:
https://github.com/dfki-ric/docker_image_development/blob/master/image_setup/01_base_images/prepare_image.bash#L37
called here:
https://github.com/dfki-ric/docker_image_development/blob/master/image_setup/01_base_images/check_init_workspace.bash
by
https://github.com/dfki-ric/docker_image_development/blob/testsuite/.docker_scripts/docker_commands.bash#L84
It can be used to run scripts like setup_workspace.bash on container creation, currently we only use it to print the info to run
setup_workspace manually:
https://github.com/dfki-ric/docker_image_development/blob/testsuite/image_setup/02_devel_image/Dockerfile#L29
But we could also just run echo /opt/setup_workspace  >> /opt/init_workspace.bash in some Dockerfile to run stuff automatically.
But for the testsuite is think it would be better to just use a script that creates some files using ./exec.bash (possibly using docker cp to place it in the devel container) and then check the permissions/access in the release
If we don't declare permissions checks obsolete as there are no more user changes when building the release

As stated in your comment permission/access checks are indeed obsolete with the new dockeruser implementation.
I moved all open test_suite ToDos to a new issue (https://github.com/dfki-ric/docker_image_development/issues/36)
Removing the WIP tag now. Feel free to merge.


Bitbucket(Cloud) collector not fetching any data

Application.properties file:
dbname=dashdb
dbhost=localhost
dbport=27017
dbreplicaset=false
dbhostport=localhost:27017
dbusername=user
dbpassword=password123
logging.file=./logs/bitbucket.log
git.cron=0 0/1 * * * *
git.host=https://bitbucket.org/companyname/
git.username=kopal
#convert password to base64
git.password=hcufeuuYi= (it is in base64)
git.api=/rest/api/2.0/
git.commitThresholdDays=100
git.pageSize=25
Bitbucket product
Set to 'cloud' to use Bitbucket Cloud (formerly known as Bitbucket)
Set to 'server' to use Bitbucket Server (formerly known as Stash)
More information can be found here:
#https://github.com/capitalone/Hygieia/issues/609
git.product=cloud

Can anyone tell me where I am going wrong or what can be the issue?

I'm encountering same issue. I'm using also bitbucket cloud.

@shishirchaturvedi any thoughts here?

@kopal2212 Can you please increase logging level of scm collector and share your findings. You can change log levels by adding the following entries in the application.properties file.
logging.level.com.capitalone.dashboard.collector=DEBUG
logging.level.org.springframework=DEBUG

Its fixed in the last pull request. Please get the latest and verify it.

Hi ,
I am having the same issue for bitbucket cloud.
@kopal2212 in widget section were you passing encrypted password or plaintext.

Experiencing same issue , any possible solutions ?


Update how we do calculations

I would change the calculation to be different here:
https://github.com/sydneyshile/go-difference-check/blob/7658de11dacf4ad5db2b8f3aeb8207966623d8b3/difference.go#L22
Instead I did in the past is something like:
diff := n1 - n2
average := (n1 + n2) / 2
return (diff/average * 100)

I don't think we need the absolute value here?

Another thing:
We should consider adding error handling, instead of just returning a float we should consider adding an error return type and we should do some checks on inputs to make sure they are not negative e.g. if someone passes in a negative number we should return an error stating negatives are not allowed.

We should be able to check our answers here for percentage difference https://www.calculatorsoup.com/calculators/algebra/percent-difference-calculator.php

Ah I see why we needed the absolute value, I tried this out and it worked:
func PercentDifference(n1 float64, n2 float64) float64 {
	diff := math.Abs(n1 - n2)
	average := (n1 + n2) / 2
	return (diff/average * 100)
}

Note: https://www.calculatorsoup.com/calculators/algebra/percent-difference-calculator.php rounds to the 4th decimal, our answer should be close but it will be different since we won't be rounding

Thank you for your inputs, Both calculations are updated.


Update CISSP-Domain-5-Objectives.md

@Paramasivan07 -  thanks for the PR. I have incorporated some information into the repo but am still reviewing the rest.


Add link support

https://tiptap.dev/docs/editor/extensions/marks/link#page-title

Done. Discuss if links should open on click.


Bump version to 1.0.2

Codecov Report

Merging #21 (4911592) into master (f9b7f34) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #21   +/-   ##
=========================================
  Coverage     35.97%   35.97%
  Complexity      218      218
=========================================
  Files            57       57
  Lines          2446     2446
  Branches        272      272
=========================================
  Hits            880      880
  Misses         1467     1467
  Partials         99       99

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9b7f34...4911592. Read the comment docs.


⚠ Bofrost.at has degraded performance

In 4752ee3, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1479 ms

Resolved: Bofrost.at performance has improved in a1c38b2.


Fixed misplaced meta data. Added missing tags, including social media…

There were some tags that appeared inside the  instead of the .

Also, I've included social sharing meta tags and a valid image as a twitter card.

💯


🎨 Remove duplicate "Note:"

Just a small touchup - I noticed that there was a duplicate "Note:" in the custom title bar settings. I also took the opportunity to use HTML5s preferred
 rather than
, and changed "title-bar" to "title bar" for consistency.

Thanks!


Change Management / Versioning of the Ontology upon changes.

Issue #172 is a defect in the ontology
to fix this, we need to publish a new version of the ontology - we need to solidify a versioning/change management process
recommendation - create a v1.0.1 (a patch version) - change the version independent IRI to redirect to that

Was fixed but need to automate publishing workflows for both ontologies and data processing


Adjust meter data download format

A user was confused by the individual meter download format:

the MPXN is in the CSV file name but this gets truncated when imported into Excel which has a limit on size of tab names
the CSV file itself doesn't contain the MPXN

The user was therefore unsure whether we had given them the right data.
Adjust the downloads to shorten the file name and add the mpxn and meter type into the CSV.

See comments 👍


Fix implicit conversion changes signedness errors with clang 11

Fixes #260 using example provided in comments from xhyve project.
Builds and local make test passes, I am not an expert in this code so needs some review.

It would be really nice to have this fixed :grin:  Any word on getting this reviewed and merged?

Checking in on this PR, would be great to get hyperkit building again on OSX.

Checking in. It would be great to get hyperkit building again on OSX.

Thanks for your work on this and sorry for the delay. A fix was merged in #270 and the CI is now green again!


ci: fix coverage upload

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@68240dc). Click here to learn what that means.
The diff coverage is n/a.

:exclamation: Current head 1e40ec0 differs from pull request most recent head 386bd06. Consider uploading reports for the commit 386bd06 to get more accurate results

@@           Coverage Diff           @@
##             main       #1   +/-   ##
=======================================
  Coverage        ?   51.51%
=======================================
  Files           ?        4
  Lines           ?      132
  Branches        ?       14
=======================================
  Hits            ?       68
  Misses          ?       62
  Partials        ?        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68240dc...386bd06. Read the comment docs.


reincorporate project template for changelog updates

reincorporate project template so that changelogs are automatically built in the future for releases

already completed in https://github.com/ApeWorX/ape-vyper/pull/9

@fubuloubu please delete branch chore/issues/16


ZarrWrite upstream of Scan with multiple workers leads to empty patches in written array

Below is a minimal example of what I'd like to do. Note that the request size (in voxels) is not a power of 2.
The chunk size for the new array is chosen automatically, in this example it is set to (64, 128, 128) .
Presumably due to the leading dimension of the chunk size being smaller than its counterpart in the request Presumably as the chunk size does not divide the request size, the array on disk has some empty patches from conflicting concurrent write operations on the same chunk.
Can we simply expose the chunk size of a new array in ZarrWrite to avoid this?
import datetime
import numpy as np
import gunpowder as gp

timestamp = datetime.datetime.now().strftime("%Y-%m-%d--%H-%M-%S")

voxel_size = gp.Coordinate((5,) * 3)
input_size = gp.Coordinate((110,) * 3) * voxel_size

raw = gp. ArrayKey('RAW')

request = gp.BatchRequest()
request.add(raw, input_size)

class Source(gp.BatchProvider):
    def __init__(self, voxel_size, array_key):
        self.shape = gp.Coordinate((512,) * 3) * voxel_size
        self.roi = gp.Roi((0, 0, 0), self.shape)
        self.array_key = array_key

        self.dtype = np.uint8
        data = np.random.randint(0, 256, (512,) * 3, dtype=self.dtype)

        self.manual_spec = gp.ArraySpec(
            roi=self.roi,
            voxel_size=voxel_size,
            dtype=data.dtype,
            interpolatable=True,
        )

        self.array = gp.Array(data, self.manual_spec)

    def setup(self):
        self.provides(self.array_key, self.manual_spec)

    def provide(self, request):
        out = gp.Batch()
        out[self.array_key] = self.array.crop(request[self.array_key].roi)
        return out

pipeline = (
    Source(voxel_size, raw)
    + gp.ZarrWrite(
        dataset_names={raw: 'raw'},
        output_filename=f"{timestamp}.zarr",
    )
    + gp.Scan(reference=request, num_workers=5)
)

with gp.build(pipeline) as p:
    p.request_batch(gp.BatchRequest())

You are right, the "empty" or corrupted chunks are a result of non-chunk-aligned parallel writes by the workers spawned by Scan. This is only a problem if there are multiple workers, though.
What we could do is to issue a warning whenever ZarrWrite detects non-aligned writes. What do you think?

I agree, a warning would be helpful.
Zarr also supports multi-process synchronized writes as an experimental feature, so we might think about introducing it to ZarrWrite. I made a working quick-and-dirty synchronized version for now.


[Orchard Azure deployment] Migration from the deprecated Azure app service : classic Task

Hello everybody,
Actually in our compagny we are using orchard as the web portal of it. This website is hosted on azure app service.
Microsoft noticed us that, the deploy azure app service : classic task is going to be deprecated. So we tried to migrate our
release definition with the new one ( Azure app service deploy v3 ). But we have some issues.
First , apparently something went wrong with the manifest.xml file. While deploying the app , the "setacl" declared into
this file cannot be applied. We had :
Failed to deploy App Service.
Error Code: ERROR_USER_NOT_AUTHORIZED_FOR_CREATEAPP
Error: C:\Program Files\IIS\Microsoft Web Deploy V3\msdeploy.exe failed with return code:<PHONE_NUMBER>
If we remove the file from the lib/msdeploy folder, at first, the deploy was ok. But few times after we had a new error.
Failed to deploy web package to App Service.
Error: (3/28/2017 8:39:33 AM) An error occurred when the request was processed on the remote computer. Error: Source (iisApp) and destination (contentPath) are not compatible for the given operation. Error count: 1.
Error: C:\Program Files\IIS\Microsoft Web Deploy V3\msdeploy.exe failed with return code:<PHONE_NUMBER>
At this point we didn t find the solution for this.
Did you already solve this task migration ? Somebody does have the solution for this?
Best regards,

have you try to deploy by git? should avoid this issue

Hello :)
Actually, deploying the website by git is not an option. We are not in continuous deployment. We are using Visual studio online, and when we deploy we are using builds and releases, there are no git deployment tasks that we can use into release definition to deploy via git. We just want to migrate our azure deploy task.

you do not need continuous deployment, only need normal git.
you do not need build and release , azure do that for you.
how?
sebastienros has  a article about it, also others

This one?
http://www.andrewconnell.com/blog/continous-delivery-of-orchardcms-to-azure-complete-with-dev-test-environments