Your voting power could not be calculated.

Describe the bug
While trying to cast my vote, I am getting this message:
Your voting power could not be calculated. This is often due to a misconfigured strategy or an unresponsive RPC node involved in the strategy.
To Reproduce
Steps to reproduce the behavior:

Go to 'Snapshot.org'
Click on 'Cast your vote'
See error

Expected behavior
I should be able to see my voting power and cast my vote on a proposal
Screenshots

Desktop (please complete the following information):

OS: Windows 10 home 21H2 19044.1645 Windows Feature Experience Pack 120.2212.4170.0
Browser Firefox
Version 99.0.1 (64-bit)

What's the proposal you try to vote on ?

This one here: https://snapshot.org/#/gitcoindao.eth/proposal/0x77b9cfe4130db0c852394b66991248ed5305c0a495639878338ce2a6c568f8f0

I just tried it again and now it worked... Pretty weird...

Thanks for the feedback

I have the same problem, and not long ago I used another uptosbridge bridge and it also didn’t let the transaction pass, it didn’t let me confirm it, and in this it was a temporary bug and changed the time on my computer and it worked, but here I’m changing the time and still it doesn’t work yet I will try further

Hi @Parpasiholog Can you provide more details? would be nice if you can create a ticket here https://discord.snapshot.org/


Configure a "discard" pile to allow for a "discard" button in the hand.

Use #28

Closed by 9f64795efe8c3aa813e1a57ec4e9b68622e3f935


kubernetes: enable passthru tests

Motivation for this change
The kubernetes tests are a bit flaky, but they do succeed most of the time, so let's have hydra run them automatically whenever somebody changes the kubernetes package itself.
As a bonus, we can now run all the tests with the more standard:
$ nix-build --no-out-link -A kubernetes.passthru.tests

Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Relase notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

This is ready for review now.  We can see the tests actually ran here: https://github.com/NixOS/nixpkgs/pull/131694/checks?check_run_id=3181050402
TIL In order for the passthru.tests to run, both of the following conditions need to be met:

the commit message must be properly formatted like ", : " (nixpkgs.rs:384), AND
the output paths of the packages listed in the commit message must have changed (nixenv.rs:36).


Segmentation fault on startup

I had waybar setup and working fine.  Today I woke my laptop up, and the bar was missing.  I ran waybar from the command line and find it now seg faults:
> waybar
xkbcommon: ERROR: failed to add default include path /usr/share/X11/xkb
xkbcommon: ERROR: failed to add default include path /usr/share/X11/xkb
[1]    3825892 segmentation fault (core dumped)  waybar

I hadn't changed anything.  I tried upgrading waybar and installing from source, but still get the same issue.
> waybar --version
Waybar v0.11.0-35-g07f75e30 (branch 'master')

I am on Ubuntu 22.04

I have the language module commented out in the config.  Is there anything else I can do to disable it and allow waybar to start?  I will try to figure out what is wrong with my xkbcommon as well.  Thanks.

As I see:

sway/language
hyprland/language
niri/language

Only these modules use the library. Check any of them and disable temporary.

I guess you need to reinstall

libxkbcommon-dev
libxkbregistry-dev

Both actual for Debian repository and should be the same for Ubuntu

And I missed... you wrote,  you woke up your laptop.. Means wayabr crashes the only after sleeping.. on even on system startup?

Hi @mitchelljkotler if issue is no more actual,  please close it


Invariant error if you simulate an event and programmatically create markup during testing

This happened after completing and trying to work off of the testing section from the Advanced React and Redux course on Udemy:
https://screencast.com/t/4qVkXvXngIuN

I gave up after hours of going in under the hood. I just moved to using Jest/Enzyme and here's the PR: https://github.com/StephenGrider/ReduxSimpleStarter/pull/217


virtualboxKvm: 20240828 -> 20241220

This update brings initial support for VirtualBox 7.1. We disabled the virtio-gpu for now to reduce the porting effort, but that is an experimental feature anyway and not available in vanilla Linux kernels.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

@blitz @FriedrichAltheide


Unable to connect kuksa databroker on localhost:55556

Getting these errors while running a python client which connects to kuksa databroker.
Both kuksa databroker & the python client are running as docker containers inside a docker-compose file.
[09/Mar/2023 12:20:27] "GET /receive_command/Vehicle.Speed/120 HTTP/1.1" 500 -
2023-03-09 17:50:27 Traceback (most recent call last):
2023-03-09 17:50:27   File "/venv/lib/python3.10/site-packages/kuksa_client/grpc/init.py", line 785, in get_server_info
2023-03-09 17:50:27     resp = self.client_stub.GetServerInfo(req, **rpc_kwargs)
2023-03-09 17:50:27   File "/venv/lib/python3.10/site-packages/grpc/_channel.py", line 946, in call
2023-03-09 17:50:27     return _end_unary_response_blocking(state, call, False, None)
2023-03-09 17:50:27   File "/venv/lib/python3.10/site-packages/grpc/_channel.py", line 849, in _end_unary_response_blocking
2023-03-09 17:50:27     raise _InactiveRpcError(state)
2023-03-09 17:50:27 grpc._channel._InactiveRpcError: <_InactiveRpcError of RPC that terminated with:
2023-03-09 17:50:27     status = StatusCode.UNAVAILABLE
2023-03-09 17:50:27     details = "failed to connect to all addresses; last error: UNKNOWN: ipv4:<IP_ADDRESS>:55556: Failed to connect to remote host: Connection refused"
2023-03-09 17:50:27     debug_error_string = "UNKNOWN:failed to connect to all addresses; last error: UNKNOWN: ipv4:<IP_ADDRESS>:55556: Failed to connect to remote host: Connection refused {grpc_status:14, created_time:"2023-03-09T12:20:27.852128758+00:00"}"
Can someone please assist?

Hey,
Could you maybe share you're docker-compose file? Have you set network_mode: host?

Able to access after using dns:///<host_name> url. Thanks


docs: fix UI docs

When following the original docs, I was getting:
Danger alert:An error occurred
Error "Invalid value: "object": UIPlugin name must be
'distributed-tracing' if type is DistributedTracing" for field "<nil>".

/ok-to-test

/approve


minor: Implement Deref<Target=[T]> for OneOrManyWithParens

This allows accessing all inner values without matching

Pull Request Test Coverage Report for Build<PHONE_NUMBER>7
Details

0 of 4 (0.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.01%) to 89.043%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/ast/mod.rs
0
4
0.0%

Totals

Change from base Build<PHONE_NUMBER>9:
-0.01%

Covered Lines:
27670

Relevant Lines:
31075

💛  - Coveralls

Marking as draft as I think this PR is no longer waiting on feedback. Please mark it as ready for review when it is ready for another look

Thanks @gstvg -- can you please add a test showing what this contribution allows? That way we won't accidentally break it in the future

Sure, it makes sense, so much so that while I was writing it, I realized it wasn't enough for my intended usage 😅
I ended up implementing 3 more traits
Thanks @jmhain and @alamb

Thanks again @gstvg

Thanks @jmhain and @alamb :pray:

This looks good to me -- thank you @gstvg and I apologize for the delay in reviewing

It's okay, don't worry. If I ever need something to be reviewed with priority, I will ping you or another maintainer


[FancyZones] Crash when switching layouts

Microsoft PowerToys version
ccaa98513c505bf8f2c9c0d739c31476249df747
Running as admin
No
Area(s) with issue?
FancyZones
Other Software
No response
Steps to reproduce
The crash will only happens in Debug builds but it could have undesired consequences in Release builds.
Create two custom layouts with 2 and 5 zones, and assign them quick keys 2 and 5 respectively.
Assign the 5-zone layout.
Start dragging a window and hover above zone 5.
Press 2 to switch to the other layout.
✔ Expected Behavior
No crashes.
❌ Actual Behavior
FancyZones crashes with:
vector subscript out of range.
I already have a fix for this issue.

This has been resolved in the 0.35 release. https://github.com/microsoft/PowerToys/releases/latest


Misc code cleanup

Some random things I spotted.

Remove unused empty_stylebox from EditorAbout
Remove unused DISPLAY_CHANGED macro from RenderingServerDefault
Change pts variable in TextureProgressBar from Array to float array

For some reason Vector has an append alias but LocalVector only supports push_back.


feat(system): Gamut System Alpha

Overview
Partial Rebase of #953
Checks in gamut-system for alpha testing within gamut.  Full information on the proposal is below.
PR Checklist

[x] Related to designs: All of them
[x] Related to JIRA ticket: ABC-123
[x] I have run this code to verify it works
[x] This PR includes unit tests for the code change

Full Description
Why not Styled System?
styled-system does not support true type-safety creating a significant headache.
The closest level of type safety allowed by typescript is array level indexing, at any level above that it is number or string only.  This is especially problematic for theme level scales, if we cannot detect that our theme shape has changed then we are prone to introducing bugs and encourage looser types.
Features

Completely customizable style props (with theme agnostic implementation);
Flexible props that are both responsive and composable.
Strict design system aware types with no manual fuss.
Works with emotion and styled-components in preferred syntax.

Getting Started
Gamut system is a styled-system inspired utility toolkit that focuses on making your design system
typesafe.
To use gamut-system, install gamut-system and your CSS in JS library of choice:
yarn add @codecademy/gamut-system @emotion/core @emotion/styled

Initialize your system
The first thing you need to use gamut-system is to initialize your utility functions. This is necessary to generate
the correct types for your properties.
import { system } from '@codecademy/gamut-system';

export const {
  typography,
  layout,
  spacing,
  border
  background
  color,
  flexbox,
  grid,
  properties,
  variants
} = system.create({});

Create a component
Use your style props in your components:
import styled from '@emotion/styled';
import { HandlerProps } from '@codecademy/gamut-system';
import { layout, spacing } from './system';

type BoxProps = HandlerProps<typeof layout> & HandlerProps<typeof spacing>;

export const Box = styled.div<BoxProps>`
  ${spacing}
  ${layout}
`;

Style Functions

Using your style functions
Use your style props in your components:
import styled from '@emotion/styled';
import { HandlerProps } from '@codecademy/gamut-system';
import { layout, spacing } from './system';

type BoxProps = HandlerProps<typeof layout> & HandlerProps<typeof spacing>;

export const Box = styled.div<BoxProps>`
  ${spacing}
  ${layout}
`;

Now you can use both spacing and layout props on your <Box/>.
<Box padding="1rem" display="flex" />

Responsive Props
By default, all system generated style functions accept responsive configurations.  Responsive configurations are two basic shapes a map of breakpoint aliases/values or an array of values:
// Array Syntax
<Box width={[50, 100, 200]} />

// Object syntax
<Box margin={{ xs: 16, sm: 24, md: 32 }} />

Composition
There may be instances where you would like to combine properties for ease of sharing or performance to batch their computations.  To make this easy we've added a compose function to combine returned style functions into a single one with the intersection of all of their props.
By default system will return a few groups of composed or group functions typography, layout, spacing,border, background, color, flexbox,grid.

However, we expose a compose function to combine any style function as necessary.
import { compose } from '@codecademy/gamut-system';
import { fontSize, letterSpacing } from './system';

const myCoolComposed = compose(letterSpacing, fontSize);

The prop types of the resulting function will be:
type MyCoolComposed = {
  letterSpacing?: <%TYPE>
  fontSize?: <%TYPE>
};

Variants
There may be cases where you want to change many props at the same time to achieve a different effect. Coordinating these different prop variations can be a bit frustrating to do manually, in both typescript and plain javascript. To make this easier we have variant, a function that is meant to make creating these combinations easy and scalable.

import styled from '@emotion/styled';
import { system, HandlerProps } from '@codecademy/gamut-system';

export const { variants } = system.create({});

const buttonVariants = variants({
  variants: {
    primary: {
      borderStyle: 'solid',
      borderWidth: '1px',
      color: 'white',
      borderColor: 'darkblue',
      backgroundColor: 'blue',
    },
    secondary: {
      borderStyle: 'solid',
      borderWidth: '1px',
      color: 'white',
      borderColor: 'darkgreen',
      backgroundColor: 'green',
    },
  },
});

export type ButtonProps = HandlerProps<typeof ButtonVariants>;

export const Button = styled.button<ButtonProps>`
  ${buttonVariants}
`;

Using your variants:
  <Button variant="primary" />

  <Button variant="secondary" />

There may be cases where you want to use a special key for your variants instead of the default variant. You may pass an arbitrary key for your prop to customize the prop type.
const colorVariant = variants({
  key: 'colorVariant',
  variants: {
    primary: { color: 'blue' },
  },
});

const Text = styled.p`
  ${colorVariant}
`;

<Text colorVariant="primary" />;

This also allows you to use multiple variants in the same component to have combinatorial styles.
import { HandlerProps } from '@codecademy/gamut-system';

import { boxVariants, colorVariants } from './myVariants';

type CardProps = HandlerProps<typeof boxVariants> &
  HandlerProps<typeof colorVariants>;

const Card = styled.div<CardProps>`
  ${boxVariants}
  ${colorVariants}
`;

<Card variant="primary" colorVariant="primary" />;

Responsive Properties
Being able to configure your styles for multiple screen sizes is a common requirement. We make all style functions accept valid configurations of our responsive property spec.
Responsive configurations are two basic shape a map of breakpoint aliases / values or an array of values:
export type MediaQueryArray<Value> = [
  Value?, // base
  Value?, // xs
  Value?, // sm
  Value?, // md
  Value?, // lg
  Value? // xl
];

export type MediaQueryMap<Value> = {
  base?: Value;
  xs?: Value;
  sm?: Value;
  md?: Value;
  lg?: Value;
  xl?: Value;
};

export type ResponsiveProp<Value> =
  | Value
  | MediaQueryArray<Value>
  | MediaQueryMap<Value>;

What this looks like in practice:
const Box = styled.div`
  ${display}
`

// Array Syntax
<Box display={['none', ,'block']} />

// Alias Syntax
<Box display={{ base: 'none', sm: 'block' }} />

Output styles:
.#{emotionHash} {
  display: 'none';

  @media (min-width: 480px) {
    display: 'block';
  }
}

Default Breakpoints
If you do not have a preference on the breakpoints that you use we default to this set:

Alias
Mediaquery

xs
@media (min-width: 320px)

sm
@media (min-width: 480px)

md
@media (min-width: 768px)

lg
@media (min-width: 1024px)

xl
@media (min-width: 1248px)

Custom Breakpoints
If you would like to use your own, we allow you to specify 5 different breakpoints through the theme shape:
import React from 'react';
import { system } from '@codecademy/gamut-system';
import { ThemeProvider } from 'emotion-theming';

const MyTheme = {
  // Other theme configurations
  breakpoints: {
    xs: '@media (max-width: 2px)';
    sm: '@media (max-width: 4px)';
    md: '@media (max-width: 8px)';
    lg: '@media (max-width: 16px)';
    xl: '@media (max-width: 32px)';
  }
}

export const {
  layout,
  spacing,
  typography,
  variant
} = system.withTheme<MyTheme>().create({});

export const Apps = ({ children }) => <ThemeProvider theme={MyTheme}>{children}</ThemeProvider>

Customizing your System
By default calling system will return the base CSSType definitions for each rule and some extra transforms for quality of life. However,
there are many cases where we want more strict typings for our style functions or to have custom transformations. This can be configured
by creating a prop config: an immutable definition that defines the way the style functions should be constructed.
Config Specifcation

propName: Any defined prop in the system.
dependentProps: An array of alternative props that you would like to group with the same style function.
type: Declare the template type standard by default or directional for properties that have a shorthand for directional values.
transformValue: There may be cases where you would like to transform or compute a property value into something more CSS
friendly some examples may be adding units or looking up configurations. You may provide a transformValue function on your config to do this.
scale: Either a typed array/object literal or a key of your theme that has those values.

type AbstractPropertyConfig = {
  propName: PropAlias;
  dependentProps?: Readonly<string[]>;
  type?: 'standard' | 'directional';
  scale?: AbstractScales;
  transformValue?: TransformValue;
};

Usage
To use this you must pass a subset of the base config and its property definitions (propGroups and handlers):
export const { properties } = system.create({
  typography: {
    fontSize: {
      propName: 'fontSize',
      scale: {
        xs: '1rem',
        sm: '1.5rem',
        md: '2rem',
        lg: '3rem',
      },
    },
  },
});

The resulting types for your fontSize property and ALL consumers (typography and variants) will now be only the values specified as keys on your scale:
// Compiles
<Text fontSize="xs" />

// Type Error
<Text fontSize="1rem" />

Using with a theme
Using a theme can make this even more flexible.

type ThemeShape = {
  fontSizes: { xs: string, sm: string, md: string, lg: string };
}

export const { properties }  = (system as ThemedSystem<ThemeShape>)({
  typography: {
    fontSize: {
      propName: 'fontSize',
      scale: 'fontSizes'
  },
});

In your react code:
import React from 'react';
import { ThemeProvider } from 'emotion-theming';

const theme = {
  fontSizes: {
    xs: '1rem',
    sm: '1.5rem',
    md: '2rem',
    lg: '3rem',
  },
};

const App = ({ children }) => (
  <ThemeProvider theme={theme}>{children}</ThemeProvider>
);

Your components will automatically look these values up from your theme. This also means the values of your keys can change depending on the context.
Making aliasing color combinations etc far easier.
Initial Props
The preconfigured scales and API comes out of the box with some base properties to either be extended upon or added to.  We've added some composed style functions for grouped properties.


chore: make force option work without argument

Signed-off-by: atsushi421<EMAIL_ADDRESS>This PR make --force option work without argument.

@hsgwa @takam5f2
This is a minor correction.
Could you please review this?


FauxPowerShellConsole: OrangeRed as 'Warning' very misleading

OrangeRed looks very similar to Red - which suggests an error occured.
Given that chocolatey (choco.exe) itself prints 'warnings' to report how many packages were installed etc. on each run this should be changed to something different. (Yellow?)

Closed w/ c4210da


[BUG]: Open Data Hub isn't used anywhere

Details
Describe the bug

As mentioned in https://github.com/opendatahub-io/ai-edge/pull/139#discussion_r1357806068, Open Data Hub isn't actually used anywhere in the PoC right now. Maybe #126 can fix this.
To Reproduce

N/A
Expected behavior

Open Data Hub is used for something.
Screenshots (if applicable)

N/A

In https://github.com/opendatahub-io/ai-edge/pull/140 we propose the narrative

If you wish to develop and train different models, Jupyter notebooks provided by Open Data Hub or Red Hat OpenShift Data Science can be used.

But I wouldn't necessarily consider the situation a Bug -- it just shows that the world has reasonably clear interfaces.
Frankly, I'd much rather focus on https://github.com/opendatahub-io/ai-edge/issues/136 than to artificially add use for Open Data Hub to the PoC.

I agree that this is not a bug.  For demo purposes, we used an AzureML model as the starting point for the MLOps pipeline but other AI Edge use cases use ODH to show how a Data Scientist can build, train and push a model to S3 from within a Jupyter Notebook.  #126 & #136 proposes additional entry points using ODH for the AI Edge workflow
One of the outcomes of the initial work in this repo is to to provide an MLOps pipeline to users of ODH so that ODH is not just the entry point (Jupyter Notebook) to the workflow but also provide support for delivering the model to a remote environment from within the ODH experience

Closing since this is not a bug.


clone the repo

i cloned the repo but no folders are downloaded, how to solve this?
warning: Clone succeeded, but checkout failed.
You can inspect what was checked out with 'git status'
and retry with 'git restore --source=HEAD :/'

2 solutions possible:
fork the project and work from there.
download as a zip and run it on your local machine.


Add option to set system logos and name and add info to the admin section

Problem and impact

Add the info how to set a system name into the admin info file:
https://wikimania.eventyay.com/orga/admin/
Add the options to set system logos in the config file (like logos and favicon) and document it in the admin info.
In particular prioritize adding a different favicon.

Use the attached image for testing. Note: Favicon images are usually much smaller like 16x16px. So you need to adapt the enclosed image.

You need to install the system locally as you do not have access to the provided link. This link is just an example.

I did setup it locally but it is showing this some sort of error pinning here the http://<IP_ADDRESS>:8000/

because its my third i am setting up the project locally to reflect the issue on my machine but unable to  create.

actually i there is problem styling means the css of the application is not rendering.

can i get more detail about this feature please.it is showing me this message

This is a follow up issue to https://github.com/fossasia/eventyay-talk/issues/8

But @mariobehling  regarding GSOC Proposal is could i get the proposal template for FOSSASIA.I asked on the Gitter 2-3 weeks prior but any of them didn't  responded.

We do not provide templates. You can make a proposal based on what you think is suitable. The most important is that you show technical skills.

Indeed i am working on preparing the proposal but the community = https://app.gitter.im/#/room/#fossasia_open-event-frontend:gitter.im does not responds to any of message..is there  any other channel.

Setting System Logos
To set system logos, including the favicon, follow these steps:

Log in to the admin dashboard.
Click on the "Settings" icon (gear icon) in the top right corner.
Scroll down to the "General Settings" section.
In the "System Logos" section, enter the paths to your desired logos:

Logo: LOGO['logo']
Favicon: LOGO['favicon']

Click "Save Changes" to update the system logos.

`# config.py
...
System Logos
LOGO = {
'logo': 'path/to/logo.png',
'favicon': 'path/to/favicon.ico'
}`


[Event Request] page 9277 "FA Posting Types Overv. Matrix" - OnBeforeMATRIX_OnDrillDown

Hello, can we get the following new event in page 9277 "FA Posting Types Overv. Matrix"?
    local procedure MATRIX_OnDrillDown(MATRIX_ColumnOrdinal: Integer)
    begin
        DP_Book2.SetRange("FA No.", "FA No.");
        DP_Book2.SetRange("Depreciation Book Code", "Depreciation Book Code");

        if DP_Book2.FindFirst() then
            FALedgerEntry.SetRange("Depreciation Book Code", DP_Book2."Depreciation Book Code")
        else
            FALedgerEntry.SetRange("Depreciation Book Code");
        FALedgerEntry.SetFilter("FA Posting Date", DateFilter);
        FALedgerEntry.SetRange("FA No.", "FA No.");
        OnBeforeMATRIX_OnDrillDown(FALedgerEntry);

        case MatrixRecords[MATRIX_ColumnOrdinal]."Entry No." of
            1:// 'Book Value'
                begin
                    FALedgerEntry.SetRange("Part of Book Value", true);
                    PAGE.Run(0, FALedgerEntry);
                end;

    [IntegrationEvent(false, false)]
    local procedure OnBeforeMATRIX_OnDrillDown(var FALedgerEntry: Record "FA Ledger Entry")
    begin
    end;

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.
Build ID: 10816.


Network status changed, okhttp return wrong result

When the network is not available(turn off wifi), Using okhttp client request server data, the client callback onFailure().but when the network is available(turn on wifi), Using okhttp client request server data again, the client callback onResponse() immediately, and the "Response.body().string()" is empty.

for more info http://stackoverflow.com/questions/34522955/okhttp-return-wrong-result-when-network-status-changed

Please provide an executable test case. CallTest.java has plenty of examples.


Bad Request when trying to register

I'm still getting Bad Request when trying to register.  Looking in the network log of firefox or chrome I see the POST to http://pump.frob.nl/main/register .
Tested on commit 467b47e6c0dd5dec08a53aa99e00ecec72565d4a .

Yes, sure! It works now you run it under 443, meaning under root. Apart that you just messed the security for the whole server, now is ok and the issue can be closed.
yet another root...

@KeinPfusch this is not true. pump.io can drop privileges to a normal user. See the serverUser option on https://pumpio.readthedocs.io/en/latest/configuration/reference.html.

Still not related to the issue of security. I managed to install pump io with a decent security level, then since I don't like negative discussion, I wrote a guide, on how I run this software with a 3-tier architecture
and some hardening against privilege escalation attacks.
https://github.com/KeinPfusch/kp-howtos/blob/master/pump.io.md

@KeinPfusch so, I'm pretty disappointed to read this comment. From reading the document you linked you seem to have several fundamental misconceptions, both about this project and about security in general, so I'm going to leave some comments on the diff to clarify some of these things.
More generally though I'm upset that you chose to simply hurl insults at this project instead of engaging constructively. The issue tracker is open; instead of writing about everything you think we're doing wrong in a guide many people won't see, you could have filed issues telling us about those things directly. Maybe then you would've noticed the security label which I think shows the extent to which this project takes security seriously. Or even better, you could've sent code, or improved the documentation, both of which are open for anyone. I'm open to feedback; I filed #1554 and #1555 specifically because your document reminded me to think about this stuff. But what has happened here contributes nothing to the project except for negativity.


Update supabase dependency to fix RealtimeSubscription Unhandled Exception: type 'Null' is not a subtype of type 'List' in type cast

I'm running version 0.2.9 of supabase_flutter and started to get this error in my realtime, I think this is related to this issue that is already resolved. Can the supabase_flutter be upgraded to use 0.2.10 version of supabase?
Error: Expected a value of type 'List<dynamic>', but got one of type 'Null'
    at Object.throw_ [as throw] (http://localhost:56672/dart_sdk.js:5061:11)
    at Object.castError (http://localhost:56672/dart_sdk.js:5020:15)
    at Object.cast [as as] (http://localhost:56672/dart_sdk.js:5345:17)
    at Function.as_C [as as] (http://localhost:56672/dart_sdk.js:4966:19)
    at WhereIterator.new.<anonymous> (http://localhost:56672/packages/supabase/src/supabase_realtime_payload.dart.lib.js:86:93)
    at WhereIterator.new.moveNext (http://localhost:56672/dart_sdk.js:23320:56)
    at MappedIterator.new.moveNext (http://localhost:56672/dart_sdk.js:23200:30)
    at JsIterator.next (http://localhost:56672/dart_sdk.js:6813:21)
    at Function.of (http://localhost:56672/dart_sdk.js:44586:18)
    at MappedIterable.__.toList (http://localhost:56672/dart_sdk.js:21359:30)
    at Function.fromJson (http://localhost:56672/packages/supabase/src/supabase_realtime_payload.dart.lib.js:86:280)
    at realtime_subscription.Binding.new.<anonymous> (http://localhost:56672/packages/supabase/src/supabase_realtime_client.dart.lib.js:48:83)
    at realtime_subscription.RealtimeSubscription.new.trigger (http://localhost:56672/packages/realtime_client/src/push.dart.lib.js:494:12)
    at http://localhost:56672/packages/realtime_client/src/push.dart.lib.js:918:145
    at WhereIterable.new.forEach (http://localhost:56672/dart_sdk.js:21308:11)
    at http://localhost:56672/packages/realtime_client/src/push.dart.lib.js:918:117
    at realtime_client.RealtimeClient.new.<anonymous> (http://localhost:56672/packages/realtime_client/src/push.dart.lib.js:1038:81)
    at realtime_client.RealtimeClient.new.onConnMessage (http://localhost:56672/packages/realtime_client/src/push.dart.lib.js:923:12)
    at http://localhost:56672/packages/realtime_client/src/push.dart.lib.js:782:16
    at _RootZone.runUnaryGuarded (http://localhost:56672/dart_sdk.js:38448:11)
    at _ControllerSubscription.new.[_sendData] (http://localhost:56672/dart_sdk.js:32328:22)
    at _ControllerSubscription.new.[_add] (http://localhost:56672/dart_sdk.js:32277:26)
    at _SyncStreamController.new.[_sendData] (http://localhost:56672/dart_sdk.js:35152:34)
    at _SyncStreamController.new.[_sendData] (http://localhost:56672/dart_sdk.js:35256:32)
    at _SyncStreamController.new.[_add] (http://localhost:56672/dart_sdk.js:34966:26)
    at _SyncStreamController.new.add (http://localhost:56672/dart_sdk.js:34932:19)
    at _RootZone.runUnaryGuarded (http://localhost:56672/dart_sdk.js:38448:11)
    at _ControllerSubscription.new.[_sendData] (http://localhost:56672/dart_sdk.js:32328:22)
    at _ControllerSubscription.new.[_add] (http://localhost:56672/dart_sdk.js:32277:26)
    at _SyncStreamController.new.[_sendData] (http://localhost:56672/dart_sdk.js:35152:34)
    at _SyncStreamController.new.[_sendData] (http://localhost:56672/dart_sdk.js:35256:32)
    at _SyncStreamController.new.[_add] (http://localhost:56672/dart_sdk.js:34966:26)
    at _SyncStreamController.new.add (http://localhost:56672/dart_sdk.js:34932:19)
    at _StreamSinkWrapper.new.add (http://localhost:56672/dart_sdk.js:35290:24)
    at _GuaranteeSink.new.add (http://localhost:56672/packages/stream_channel/src/stream_channel_controller.dart.lib.js:1120:24)
    at http://localhost:56672/packages/web_socket_channel/src/copy/web_socket_impl.dart.lib.js:1333:37
    at Object._checkAndCall (http://localhost:56672/dart_sdk.js:5268:16)
    at Object.dcall (http://localhost:56672/dart_sdk.js:5273:17)
    at WebSocket.<anonymous> (http://localhost:56672/dart_sdk.js:101824:100)

Duplicate of https://github.com/supabase-community/supabase-dart/issues/64
This is already fixed on supabase-dart.

Hi @bdlukaa, I see that it's fixed, but supabase_flutter doesn't use the updated version of supabase_dart. Maybe changing the title to something about this update?

A new supabase-flutter version has been deployed. Can you try again and let us know if the problem persists.


WIP: Add sender specification for contracts sending tx

Resolves #420 in cosmwasm

Targeted PR against correct branch (see CONTRIBUTING.md)

[ x] Linked to Github issue with discussion and accepted design OR link to spec that describes this work.

[ ] Wrote tests

[ ] Updated relevant documentation (docs/)

[ ] Added  relevant godoc comments.

[ ] Added a relevant changelog entry to the Unreleased section in CHANGELOG.md

[ ] Re-reviewed Files changed in the Github PR explorer

For admin use:

[ ] Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
[ ] Reviewers assigned
[ ] Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

As mentioned here this is a giant security hole, and we already ensure the contract dispatching the message is the proper sender.


Support for srcset data-srcset and webp

Hi,
First of all thanks for the nice and simple plugin!
Would it be possible to create support for the following code example?
Regards,
David

                  <source media="(max-width: 475px) and (orientation: portrait)"
                  type="image/webp"
                  data-sizes="auto"
                  srcset="data:image/gif;base64,R0lGODlhAQABAAAAACH5BAEKAAEALAAAAAABAAEAAAICTAEAOw=="
                  data-srcset="
                  headers/header-stones-webp/stone-header-phone-600x400px.webp 600w,
                  headers/header-stones-webp/stone-header-phone-800x533px.webp 800w" class="lazyload">
                  <source media="(max-width: 475px) and (orientation: portrait)"
                  data-sizes="auto"
                  srcset="data:image/gif;base64,R0lGODlhAQABAAAAACH5BAEKAAEALAAAAAABAAEAAAICTAEAOw=="
                  data-srcset="
                  headers/header-stones-jpg/stone-header-phone-600x400px.jpg 600w,
                  headers/header-stones-jpg/stone-header-phone-800x533px.jpg 800w" class="lazyload">
                  <source media="(max-width: 3500px)"
                  type="image/webp"
                  data-sizes="auto"
                  srcset="data:image/gif;base64,R0lGODlhAQABAAAAACH5BAEKAAEALAAAAAABAAEAAAICTAEAOw=="
                  data-srcset="
                  headers/header-stones-webp/stone-header-800px.webp 800w,
                  headers/header-stones-webp/stone-header-1450px.webp 1450w,
                  headers/header-stones-webp/stone-header-2000px.webp 2000w,
                  headers/header-stones-webp/stone-header-2500px.webp 2500w" class="lazyload img-responsive">
                  <img
                  data-sizes="auto"
                  data-src="headers/header-stones-jpg/stone-header-800px.jpg"
                  srcset="data:image/gif;base64,R0lGODlhAQABAAAAACH5BAEKAAEALAAAAAABAAEAAAICTAEAOw=="
                  data-srcset="
                  headers/header-stones-jpg/stone-header-800px.jpg 800w,
                  headers/header-stones-jpg/stone-header-1450px.jpg 1450w,
                  headers/header-stones-jpg/stone-header-2000px.jpg 2000w,
                  headers/header-stones-jpg/stone-header-2500px.jpg 2500w"
                  src="headers/header-stones-jpg/stone-header-800px.jpg" class="lazyload img-responsive"
                  alt="alt text">
                </picture>```

Hi @Allmedialab, thank you for the kind words 😊
Support for those data types was not on the priority list right now but I'll try to work on them in due time. If you want to open a PR that adds support it would be awesome.
Thanks

I guess srcset = data urls, that is handled in #32
remains the data-srcset and it shouldn't be difficult.

@Allmedialab version 0.0.22 implements changes made by @AmjadHD that allow the srcset part to be displayed. However there is still the data-srcset part to be implemented.
Hope it helps for now while the data-srcset is still in development.

@alvesjtiago data url images are saved in the Temp directory as "myfile.<extension>"
https://github.com/alvesjtiago/hover-preview/blob/16a1c92201e681bf29a2938699380b581ceb7a25/hover_preview.py#L336
but when we want to save them, unlike url and path based images they have no real name, currently they are saved with their temp names ("myfile.<extension>"), that means if a data url image with the extension gif for example is saved we cannot save another with the same extension because they share the same name (myfile.gif).

@AmjadHD ideally we would generate a random name (eg. an UUID) on the save command for data-url images.

i already tried to implement that but that means the same image can be saved twice.

Hashing the data-url content to a small string instead of a UUID would overcome that issue.

how can we do that ?

I've just pushed an implementation for this @AmjadHD which will be released in the next version: https://github.com/alvesjtiago/hover-preview/commit/b1fa1f21754a869e0e84101e9f349ae7afb6529b
Take a look and let me know what you think. It's not guaranteed to be unique but it's also not critical.

looks good :+1: , it's nice to learn something new :smile: , this hash stuff is certainly useful.

#35

@AmjadHD the above snippet from @Allmedialab with data-srcset does not seem to be working on https://github.com/alvesjtiago/hover-preview/pull/35.
eg.
<source media="(max-width: 475px) and (orientation: portrait)" type="image/webp" data-sizes="auto" srcset="data:image/gif;base64,R0lGODlhAQABAAAAACH5BAEKAAEALAAAAAABAAEAAAICTAEAOw==" data-srcset="headers/header-stones-webp/stone-header-phone-600x400px.webp 600w, headers/header-stones-webp/stone-header-phone-800x533px.webp 800w" class="lazyload">

I'll try to check what might be the reason. With what example did you test?
Thanks again @AmjadHD.

I tried it, it's working for me, but of course it doesn't show the images because i don't have the files

I had probably written the wrong path. Going to merge a release a new version. Thanks!


[ERROR:flutter/lib/ui/ui_dart_state.cc(209)] Unhandled Exception: Looking up a deactivated widget's ancestor is unsafe.

E/flutter (30989): [ERROR:flutter/lib/ui/ui_dart_state.cc(209)] Unhandled Exception: Looking up a deactivated widget's ancestor is unsafe.
E/flutter (30989): At this point the state of the widget's element tree is no longer stable.
E/flutter (30989): To safely refer to a widget's ancestor in its dispose() method, save a reference to the ancestor by calling dependOnInheritedWidgetOfExactType() in the widget's didChangeDependencies() method.
这个咋回事？

被销毁了，计时器还在走？


Any chance of getting this on the KDE Discover Store/as an Appimage? (for Steam Deck's running Steam OS 3)

Hi, came across this while trying fruitlessly to get ETS2 and TruckersMP working on my steam deck, but i couldn't see anything relating to it being on the KDE Discover Store, just this package in the AUR, pacstall and PyPI
if it can't be run through the KDE Discover Store, maybe have an appimage?

Unfortunatly truckersmp-cli doesn't have an appimage, all you can do is wait for the owner to make one or build it urself.

@AftDawn
reviving an old thread here, but I walked around having an appimage by creating a desktop shortcut that is just calling the truckersmp-cli command.
my TruckersMP.desktop file looks like this:
[Desktop Entry]
Name=TruckersMP
Comment=TruckersMP Desktop Shortcut
Exec=truckersmp-cli start ets2mp --without-wine-discord-ipc-bridge
Icon=steam_icon_227300
Terminal=false
Type=Application
Categories=Game;

works like a charm for me, but you need to have it installed and running first.
I am on Kubuntu and had no issues (beside a fixed one) installing truckersmp-cli and running the game


E

pls add personal bank so i can see my personal bank

Please give this PR a proper title that refers to the issue "Missing personal bank information"
Also link your profile where you have a personal bank please

@MartinNemi03 can you rename this issue?

@metalcupcake5 removed from API due to privacy


python3Packages.datadog: 0.40.1 -> 0.41.0

Motivation for this change
Update to latest upstream release 0.41.0
Change log: https://github.com/DataDog/datadogpy/releases/tag/v0.41.0
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 125988 at 611b2258 run on aarch64-linux 1

8 packages built successfully:

home-assistant
nixops
python38Packages.datadog
python38Packages.gradient
python38Packages.gradient_statsd
python39Packages.datadog
python39Packages.gradient
python39Packages.gradient_statsd

1 suggestion:

warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?
Near pkgs/development/python-modules/datadog/default.nix:55:3:
   |
55 |   meta = with lib; {
   |   ^


sudo apt install gcc-5 (Bugzilla Bug 3069)

This issue was created automatically with bugzilla2github
Bugzilla Bug 3069
Date: 2020-11-10T13:25:24+00:00
From: Fred Kerr <>
To:   @lgao4
CC:   @lgao4
Last updated: 2020-11-10T20:34:48+00:00

Comment 14302
Date: 2020-11-10 13:25:24 +0000
From: Fred Kerr <>

Industry Specification: ---
Target OS: ---
Bugzilla Assignee(s): @lgao4

Hello - from https://github.com/tianocore/tianocore.github.io/wiki/Getting-Started-with-EDK-II
The instructions for installing gcc-5 may need some update or additional info. I am trying a quick install into a new WSL2 ubuntu 20x.
sudo apt-get install gcc-5
Reading package lists... Done
Building dependency tree
Reading state information... Done
Package gcc-5 is not available, but is referred to by another package.
This may mean that the package is missing, has been obsoleted, or
is only available from another source
E: Package 'gcc-5' has no installation candidate

Comment 14309
Date: 2020-11-10 20:34:48 +0000
From: @lgao4
Liming will take AR to update wiki page and describe gcc 5 is not hard requirement.


keyboard input (type string) action

I guess it's obvious
but please implement an action to send keyboard input
i.e. to simulate typing a given string (not just a single key)

I was about to create an issue myself regarding the key and button actions: it seems that xcb_test_fake_input isn't working.
I should probably create a bug report because XCB's own xtest example doesn't work.

I was looking into implementing this, but it seems impossible in pure xcb because there is no equivalent to XLookupString. Furthermore, the keycode parsing code would also be disproportionately long compared to the rest of this of the program.
So baskerville should decide how to proceed with this, if at all.


It's not documented of how to use a scope with a "-" character in it's name

I'm submitting a...

[ ] Regression (a behavior that used to work and stopped working in a new release)
[X] Bug report
[ ] Performance issue
[ ] Feature request
[X] Documentation issue or request
[ ] Support request
[ ] Other... Please describe:

Current behavior
It's not directly possible to use a scope with a "-" character in it. The solution is somewhat not documented - you can use lower camel case notation, like "loginForm" (from "login-form")
Expected behavior
It should be either possible to use "-" character in a scope name or it should be well documented what characters are allowed and what operations are being done with the scope name itself.
Minimal reproduction of the problem with instructions
https://stackblitz.com/edit/angular-eq17dy
What is the motivation / use case for changing the behavior?
Let's say I do have a component called LoginFormComponent. By the book it is placed under login-form folder. Therefor I'd like to create a specific for that component scope translations. The first thought, at least for me, is that I do create a folder login-form and there I place all the translation files.

According to both of your issues, it seems you didn't bother to go through the documentation. We worked hard on it, reread it, please.


Port Subversion code to use SVNKit

See https://svnkit.com/.

Started in https://github.com/heremaps/oss-review-toolkit/pull/1994.

Finished in https://github.com/heremaps/oss-review-toolkit/pull/2023.


_invokeNFTReceiver should throw error instead of returning false

I guess you would want this entrypoint to throw and error and fail if the recipient / receiver doesn't implement this interface or returns false.
see:

https://github.com/appinesshq/ae-nft/blob/05e4ef914f2e8387eea59b6bc2db8f20f9b26b42/contracts/NFT.aes#L165
https://github.com/appinesshq/ae-nft/blob/05e4ef914f2e8387eea59b6bc2db8f20f9b26b42/contracts/NFT.aes#L168

basically I mean the require is missing somewhere here. either in this method or where the method is invoked, e.g.:

https://github.com/appinesshq/ae-nft/blob/05e4ef914f2e8387eea59b6bc2db8f20f9b26b42/contracts/NFT.aes#L115

What I tried to say on Discord is that ERC-721 doesn't throw in case the receiver doesn't implement the method. So therefore I use the bool to indicate whether the call was successful or not. However what I do notice is that with the changes today I removed prolongating the bool result up. So instead of require and throw, it should at least return the bool, so that the developer of a contract can decide whether to throw or not.

let me rephrase the issue to be more clear. IMO an entrypoint called safe_mint or safe_transfer should require that check to be true. do you agree? this is what I tried to explain

I agree with you, but it would mean that we break ERC-721 compatibility.

I agree with you, but it would mean that we break ERC-721 compatibility.

can you elaborate on that one? I don't understand 😅 let's get first the discussion about the interface getting started in the AEX proposal and then digging deeper into implementation details

You are right. It should throw if the call fails. I included this in the AEX proposal


Adding Robust04 and TREC-NEWS multifield regressions in Anserini

Codecov Report

Merging #1844 (796b32a) into master (9c790b9) will increase coverage by 57.51%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             master    #1844       +/-   ##
=============================================
+ Coverage          0   57.51%   +57.51%
- Complexity        0     1055     +1055
=============================================
  Files             0      179      +179
  Lines             0    10188    +10188
  Branches          0     1407     +1407
=============================================
+ Hits              0     5860     +5860
- Misses            0     3836     +3836
- Partials          0      492      +492

Impacted Files
Coverage Δ

...erini/index/generator/WashingtonPostGenerator.java
34.48% <0.00%> (ø)

...main/java/io/anserini/ltr/FeatureExtractorCli.java
0.00% <0.00%> (ø)

...a/io/anserini/analysis/DefaultEnglishAnalyzer.java
75.60% <0.00%> (ø)

...o/anserini/search/similarity/TaggedSimilarity.java
100.00% <0.00%> (ø)

...a/io/anserini/collection/EpidemicQACollection.java
74.62% <0.00%> (ø)

...main/java/io/anserini/ltr/feature/QueryLength.java
86.66% <0.00%> (ø)

...anserini/search/topicreader/WebxmlTopicReader.java
86.36% <0.00%> (ø)

...n/java/io/anserini/rerank/lib/RocchioReranker.java
0.00% <0.00%> (ø)

...a/io/anserini/ann/fw/FakeWordsEncoderAnalyzer.java
100.00% <0.00%> (ø)

...a/io/anserini/index/generator/Cord19Generator.java
0.00% <0.00%> (ø)

... and 169 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c790b9...796b32a. Read the comment docs.


Be able to colour tabs in a multi-root project

It would be nice to be able to have different file tabs be the colour of the project they're in, when using a multi-root workspace.
Projects can already have a different toolbar colour, tabs should inherit those colours.

@bpasero would be nice for you to link the duplicate issue, I searched before I added this one and would like to subscribe to it.

Yeah I would say a variant of https://github.com/Microsoft/vscode/issues/35379 maybe add your comment there.

Actually I meant to say: https://github.com/Microsoft/vscode/issues/31308


Fixed #29817 -- Deprecated settings.FILE_CHARSET.

https://code.djangoproject.com/ticket/29817

Closing as per ticket. (Again, happy to reopen if the django-developers discussion evolves suitably.)

Ticket was reopened, reopening PR too.

Could you remove mentions of this setting in the documentation as much as possible (for example, docs/ref/unicode.txt should mention TEMPLATES instead)?

I had one thought, do we need to state anywhere that templates etc must now be UTF-8?

@timgraham I have adjusted the docs to try to be more accurate and remove references to FILE_CHARSET. Let me know if you'd like any additional edits.
@carltongibson Do the changes to unicode.txt address your feedback? Or does the existing description of file_charset? Please let me know if you had something else in mind.

Hey @jdufresne: I think the changes to file_charset are fine. Thanks! (The user I have in mind is using UTF-8. The ref in the TEMPLATES config is thus sufficient.) 👍

I guess whitenoise should switch to using 'utf-8' as a default for WHITENOISE_CHARSET rather thansettings.FILE_CHARSET. Agreed?
I guess we can't raise a deprecation warning for FILE_CHARSET accesses without capturing the warning in Django's usage. I don't remember if I intentionally skipped that for the DEFAULT_CONTENT_TYPE deprecation. Not sure if it's worth it.

I guess whitenoise should switch to using 'utf-8' as a default for WHITENOISE_CHARSET rather thansettings.FILE_CHARSET. Agreed?

That sounds correct to me, but I'm not very familiar with whitenoise or its code. Your proposal there sounds very sensible.

@timgraham I added a new commit that warns on FILE_CHARSET access (we could use the same strategy  for DEFAULT_CONTENT_TYPE too), but avoids false positives originating from Django. Let me know what you think. If you think it is a good idea, we can squash it, otherwise drop it.

Yes, I think it would be useful as I found some uses of FILE_CHARSET in other code. If you could use the same technique for DEFAULT_CONTENT_TYPE (in a separate PR of course), that would be useful.

Changes:

Squashed commits
Added module constant FILE_CHARSET_DEPRECATED_MESSAGE to avoid repeating the string
Improved explanatory comment as suggested

Thanks

If you could use the same technique for DEFAULT_CONTENT_TYPE (in a separate PR of course), that would be useful.

Done in #10513


Bug: Possible to replace any file when using Original Name Format

What happened?
When setting the Format to Original Name like in the image below, it is possible to replace any already uploaded file if they share the same name and file extension.

Ideally there should be a check for already existing files. The upload could then be denied, or alternatively change the filename by appending a suffix or something like that.
Version
latest (ghcr.io/diced/zipline or ghcr.io/diced/zipline:latest)
What browser(s) are you seeing the problem on?
Firefox
Zipline Logs
No response
Browser Logs
No response
Additional Info
No response

should be fixed in https://github.com/diced/zipline/commit/93cb9eec4c9435705fa37cffe99e9698e4509a5b
reopen if the issue happens again

Still happens on version 3.7.5 using the latest docker image.

ok its actually fixed in this https://github.com/diced/zipline/commit/b39507b9a817b26cd518282ea3ae405dbf59487b


How can I add sentimentAnalysisResult to the query response?

As the title suggests, there is a new field under DF2QueryResult.
Thank you so much for your help in advance ><

Hi @tina1998612 ,
you must be sure that the JSON you are sending to the DF2 server has a structure that matches the specifications of the google API. In particular, I recommand you to start from the QueryResult documentation page and add the missing fields to the DF2QueryResult class, until you obtain the functionality you desire.
I am sorry but I have no time to work on this project anymore, so any missing features must be implemented in this way.


[Bug] IndexError: index 1 is out of bounds

Dear Sirs,
Some songs can not be spleted after  I installed the new Spleeter. Pls see below:

Traceback (most recent call last):
  File "/root/anaconda3/bin/spleeter", line 10, in <module>
    sys.exit(entrypoint())
  File "/root/anaconda3/lib/python3.7/site-packages/spleeter/__main__.py", line 54, in entrypoint
    main(sys.argv)
  File "/root/anaconda3/lib/python3.7/site-packages/spleeter/__main__.py", line 46, in main
    entrypoint(arguments, params)
  File "/root/anaconda3/lib/python3.7/site-packages/spleeter/commands/separate.py", line 45, in entrypoint
    synchronous=False
  File "/root/anaconda3/lib/python3.7/site-packages/spleeter/separator.py", line 191, in separate_to_file
    sources = self.separate(waveform, audio_descriptor)
  File "/root/anaconda3/lib/python3.7/site-packages/spleeter/separator.py", line 157, in separate
    return self.separate_librosa(waveform, audio_descriptor)
  File "/root/anaconda3/lib/python3.7/site-packages/spleeter/separator.py", line 145, in separate_librosa
    stft = self.stft(waveform)
  File "/root/anaconda3/lib/python3.7/site-packages/spleeter/separator.py", line 126, in stft
    dl, dr = (data[:, :, 0].T, data[:, :, 1].T) if inverse else (data[:, 0], data[:, 1])
IndexError: index 1 is out of bounds for axis 1 with size 1

Environment
| OS                |  Ubuntu |
| Installation type | Conda          |
| Hardware spec     | CPU            |

i'd same issue. lol

Hi @eminfan
we can't really help you with that little info. Is it only for some songs ? what command are you running ? are your song mono ?

Hi @eminfan
we can't really help you with that little info. Is it only for some songs ? what command are you running ? are your song mono ?

Thank you for your reply. Yes, it's only for some songs.
cmd is "spleeter separate -i /opt/upload/" + id + "." + suffix + " -p spleeter:" + amount + "stems -o /opt/songs/ -c mp3"
I do not konw if it is mono. If you need it, I can upload to internet.
I downgrade spleeter to 1.4.9 , and then it succeeded.

Thank you reply.
16k, PCM, Mono audio file (wave and MP3), and even though the files that were good when they were two weeks ago were re-run, there is a problem.

What version were you using when the issue appeared? was it 1.5.0?
A bug that resulted in error when processing mono files was introduced in 1.5.0 and fixed in 1.5.1, so we'd be interested if there is still such a bug in more recent version.


dotNET 7.0.0

Dear Paul,
I just updated your programm. Now I got a prompt telling me to install dotNET 7.
The issue is I already have that installed. So.... any clue?

CareLink<IP_ADDRESS> works fine by the way. :)

What if you try to download it. You can have many versions and they don't interfere with each other.

Comment with instructions on adding .Net 7.0. added to ReadMe on Release page.


Type definitions for effects not avaliable on 1.1.0

Steps to reproduce
Description of the bug/issue
Typings for effects not defined.
Steps to reproduce the bug/issue

Install<EMAIL_ADDRESS>Import any effect from  'redux-saga/effect'

Example
https://stackblitz.com/edit/typescript-eeem9z

I am having the same issue since the new release

Having the same issue, here are some misc snippets to help other people searching (if that's ok):
node_modules/redux-saga/effects.d.ts:1:15 - error TS7016: Could not find a declaration file for module '@redux-saga/core/effects'. <EMAIL_ADDRESS>implicitly has an 'any' type.

1 export * from '@redux-saga/core/effects'
                ~~~~~~~~~~~~~~~~~~~~~~~~~~

[!] Error: 'take' is not exported by node_modules/redux-saga/dist/redux-saga-effects-npm-proxy.esm.js
https://rollupjs.org/guide/en#error-name-is-not-exported-by-module-
src/utils/sagas.ts (1:9)
1: import { take } from 'redux-saga/effects';

Same issue, cant import from 'redux-saga/effects'
node_modules/redux-saga/effects"' has no exported member 'takeEvery'

Same here...

Same here... any workarounds for the time being?

My workaround, can someone please verify:
import { put, takeLatest } from '@redux-saga/core/effects';

No good here with TypeScript
1:30 Could not find a declaration file for module '@redux-saga/core/effects'. <EMAIL_ADDRESS>implicitly has an 'any' type.
  > 1 | import { select, take } from "@redux-saga/core/effects";

I can't even seem to downgrade to fix?

I have the same but i've configured to be non-error

A workaround is to downgrade at least both of redux-saga and @redux-saga/core to 1.0.*:
"redux-saga": "~1.0.5"
"@redux-saga/core": "~1.0.3",

Legend! Thanks @Vovan-VE, had to regenerate my yarn.lock and was stuff until the above ^

Just confirming that @Vovan-VE's suggestion of rolling back to "redux-saga": "1.0.5", and "@redux-saga/core": "1.0.3", resolves the errors 👍

Thanks for reports, typings for effects are indeed not referenced correctly right now. Working on a fix

Could you please tell me which version of TS are you using?

I run 3.6.3

Also fails when using TS version 3.5.3

As far as I remember, there are no<EMAIL_ADDRESS>installed.

Could you try out<EMAIL_ADDRESS>

Compiled successfully!

Published as 1.1.1
Hopefully, this resolves your issues. Sorry for any inconvenience.

I might be having the same problem with the latest version (v1.2.3), on WebStorm 2023.2.1, NodeJS 16.20.2 and Typescript 4.9.3
Here's a Stackblitz example with imports to both .ts and .js files.
https://stackblitz.com/edit/typescript-ojxbva?file=index.ts,index-js.js


Increase smoothing of data used to calculate R

Since many states are not posting data as regularly as before, this is causing the calculated R to fluctuate wildly.  If the data is smoothed more, this could decrease the fluctuations.

Our model has a estimates a day-of-the-week reporting effect so if countries don't publish data for certain days it should not affect our estimates. The only exception is when the reporting pattern changes, see e.g. https://github.com/epiforecasts/covid/issues/171


set empty query

fix #245

I had already fixed the issue in a previous PR. This PR is only testing it.


Closes #2382 #2384 error messaging updates from admiraldev

Thank you for your Pull Request! We have developed this task checklist from the Development Process Guide to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the admiral codebase remains robust and consistent.
Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the main branch until you have checked off each task.

[ ] Place Closes #<insert_issue_number> into the beginning of your Pull Request Title (Use Edit button in top-right if you need to update)
[ ] Code is formatted according to the tidyverse style guide. Run styler::style_file() to style R and Rmd files
[ ] Updated relevant unit tests or have written new unit tests, which should consider realistic data scenarios and edge cases, e.g. empty datasets, errors, boundary cases etc. - See Unit Test Guide
[ ] If you removed/replaced any function and/or function parameters, did you fully follow the deprecation guidance?
[ ] Review the Cheat Sheet. Make any required updates to it by editing the file inst/cheatsheet/admiral_cheatsheet.pptx and re-upload a PDF version of it to the same folder.
[ ] Update to all relevant roxygen headers and examples, including keywords and families. Refer to the categorization of functions to tag appropriate keyword/family.
[ ] Run devtools::document() so all .Rd files in the man folder and the NAMESPACE file in the project root are updated appropriately
[ ] Address any updates needed for vignettes and/or templates
[ ] Update NEWS.md under the header # admiral (development version) if the changes pertain to a user-facing function (i.e. it has an @export tag) or documentation aimed at users (rather than developers)
[ ] Build admiral site pkgdown::build_site() and check that all affected examples are displayed correctly and that all new functions occur on the "Reference" page.
[ ] Address or fix all lintr warnings and errors - lintr::lint_package()
[ ] Run R CMD check locally and address all errors and warnings - devtools::check()
[ ] Link the issue in the Development Section on the right hand side.
[ ] Address all merge conflicts and resolve appropriately
[ ] Pat yourself on the back for a job well done! Much love to your accomplishment!

Anyways I don’t think k remotes is actually needed

Anyways I don’t think k remotes is actually needed

Remotes isn't needed for the workflows that run on CI/CD. But one annoying that happens to users is they come across the admiral repo and install it from GitHub it won't work because you need the dev version of admiraldev and without Remotes, there is no way for the installation process to know where to get it from.

Anyways I don’t think k remotes is actually needed

Remotes isn't needed for the workflows that run on CI/CD if that workflow uses staged deps to set up the packages. If a workflow isn't using staged deps, it will fail without Remotes. Also an annoying thing that happens to users is they come across the admiral repo and install it from GitHub it won't work because you need the dev version of admiraldev and without Remotes, there is no way for the installation process to know where to get it from.
It's fine for us, the devs, to depend on tools like staged deps. But we should keep up our repo in a state so that anyone coming to the repo can install the package. This means adding Remotes when we depend on dev versions of packages.

Ah okay - I was thinking that our CI could use remotes now (thought that was a reason to rework CI R-CMD checks).
makes sense for users wishing to install dev versions

If everything looks okay can you approve so we can update the other PRs to pass CI


Mount .kube directory by tmpfs

kubectl is sometimes very slow due to its caching.
To speed it up, this PR mounts .kube directory by tmpfs.
Signed-off-by: binoue<EMAIL_ADDRESS>

Close this PR because this is not necessary due to this PR


Use hazelcast for HA cache management

Why not Apache ignite? Especially if looking to one day incubate this in Apache

Hazelcast is also Apache 2 license so there's no problem even in point of ASF project's view.
https://github.com/hazelcast/hazelcast
While I would like to see comparison and discussion based on comparison instead, for me it doesn't make sense that we need to consider ASF project first because we are planning to donate the project to ASF.

I worked initially on a patch that would allow for pluggable cache support, e.g Redis, Hazelcast. I have on my local branch an improvement of the initial code almost concluded. If possible it would be ideal to incorporate this change with that patch. @raju-saravanan what is the time frame for this change. Have you started working on it yet ?

No entirely not a license issue. But I don’t see why this has to be hazelcast?
Surely if going Apache the idea is to embrace and cross pollinate.
If you could say I need feature x that isn’t present in Ignite I’d understand that.
If anything using ignite I can see further advantages for scheme registry such as could use its sql layer to then use its clustered native persistence to provide out the box replicated and local persistent storage for registry without need for external db.

@hmcl is this custom or based on java spec JCache api? If able to implement using JCache this makes it very pluggable with all major cache vendors, terracotta, ignite, Hazelcast, coherence

That's what I'm just saying: why we don't say about any comparison but just saying we should use something? Please note that I commented based on the title and your earlier comment which doesn't contain any of details.
Even both support features we need, there're lots of point of view outside of features: how many developers are familiar with such libs/frameworks (lower the wall to possible contributors), how far the lib/framework is stabilized, how much the maintenance cost is (because as I wear HWX hat on, it would be a new dependency which we should support. Even if I don't wear, it should be considered seriously for end-users.).
Are we really wanting to pick something which helps us to lower the wall to ASF incubator? I'm sorry but I think ASF shouldn't do that if it is in place. (DISCLAIMER: I'm a PMC member of Apache Storm.)
@raju-saravanan , why not elaborating which features are needed actually? If we use Hibernate or so we may not even need to enumerate, but we have our own storage implementation so we need to enumerate and ideally have comparison between candidates.

@HeartSaVioR I think would be best as noted if Jcache api meets the needs here if so it makes the code very agnostic as is a Java spec like JMS is, and most main vendors/products all implement

https://www.jcp.org/en/jsr/detail?id=107

https://docs.oracle.com/middleware/1213/coherence/tutorial/jcache.htm
https://hazelcast.com/use-cases/caching/jcache-provider/
https://ignite.apache.org/use-cases/caching/jcache-provider.html

@michaelandrepearce
I definitely love the idea to check Jcache API. Even if we found we can't rely on that, I'd still love to have pluggable interface and have (several) implementations so that choosing the cache is left to end-users.

@michaelandrepearce answering your comment. The initial implementation I worked on was for this Cache interface, which thinner interface than the JCache Cache interface.
There are differences of opinions about JCache. Not all cache providers provide an implementation. The main JCache Cache interface exposes a lot methods such as invoke, iterator, which from what I heard are hard to support in some cache implementations.


Version without R package install function

In my organization, we are not able to install any VS Code extensions that make network calls. Would it be possible to release a version of this extension that does not include the function for updating the R package?

@ManuelHentschel just wanted to ping you and see if a version without the network calls might be possible

The branch "noUpdateRPackage" contains a version without the update command, which can be installed from the .vsix generated by the corresponding GitHub action run.

Thanks so much! Would it be possible to distribute or publish that with a different identifier? Our organization uses an allow-list to mark allowed extensions, and so adding it with the same identifier as the main version would allow both.


Adds company logos

I tried to include the pics as data URI where it was possible.
Netum logo is still missing ;)

Thanks!


Support GPU accelaration for AE

Currently the Autoencoder code is not optimized for GPU if the device is supported. Need to make some changes to AutoencoderPipeline and SparseAEPipeline to move the model, optimizer etc to the correct device.

Closing this since we now have lightning, which supports different acceleration mechanisms.


Failure to decode H.264 and VP9 in YUV422 and YUV444 formats

The vp91-2-04-yuv422.webm and vp91-2-04-yuv444.webm are failing with vaEndPicture returning a VA_STATUS_ERROR_INVALID_PARAMETER error.
This is a bit strange as vp93-2-20-10bit-yuv444.webm and vp93-2-20-12bit-yuv444.webm, which are also 4:4:4 tests bit with higher bit depth, pass successfully - this suggests that our handling of 4:4:4 is at least correct.
On the other hand vp93-2-20-10bit-yuv422.webm and vp93-2-20-12bit-yuv422.webm are also failing.
It is unclear whether this is a problem with cros-codecs or VAAPI. On these tests the FFmpeg-VP9-VAAPI decoder seems to always fall back to software decoding.

After enabling 4:2:2 and 4:4:4 for H.264 I observe the same phenomenon there as well.

@Gnurou we should always test and compare with GStreamer, their scores are (IIRC):
vp8: 60/61
vp9: 302/303
h264: 129/132
Let's ditch ffmpeg as a comparison for VA IMHO.
As for why the tests are failing, I will check with the traces enabled.

@dwlsalmeida do you know how easy it would be to deploy GStreamer on a Chromebook? We don't have an ebuild for it, and with the plugin system I guess it cannot be as easy as just copying a binary unfortunately...

Cc @ndufresne
But why are chromebooks needed here? I thought we were running ccdec on regular Linux laptops when testing?

Collabora Lava Labs only host Chromebooks at the moment. But as they are harness and ready to receive jobs, using this through a simple "trigger and wait" type of runner like Mesa is doing seems reasonable. For any test that requires Intel accelerators, there is of course cloud hosting that offers this, and may be used, but as mentioned, none of this is in place, you'll need to workout the base OS, kernel etc.

But why are chromebooks needed here? I thought we were running ccdec on regular Linux laptops when testing?

I'm using Chromebooks as my Intel reference platform (no access to Intel hardware otherwise :sweat_smile:) but you are right, at least for the sake of running GStreamer this is not essential.

there is of course cloud hosting that offers this

I am not very aware of cloud offerings tbh, do you mean that there are providers that give direct (or virtualized) access to Intel GPUs that works with libva?

As @padovan said in #6, there's some internal discussion taking place to check whether we can leverage the Chromebooks at the Collabora lab for this

@Gnurou opened ticket with the intel-media-driver folks. I can also reproduce the problem with GStreamer
https://github.com/intel/media-driver/issues/1683


ssm-session-manager-plugin: fixed executable name

Description of changes
After updating the ssm-session-manager-plugin to use buildGoModule the name of the executable binary is wrong. This change adds the installPhase to set the correct executable name again.
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[x] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Could you squash the two commits? It's one logical step. Then we're good to go.


✅(api) add load tests for a video route

Purpose
We've observed connection issues to the PostgreSQL server when many requests are send in parallel.
Proposal

[ ] add a test to reproduce the issue
[ ] fix the issue

This work is related to #137

DO NOT MERGE
This PR is still a test and increase too much tests execution time to be worth it.


When starting mocks from test.features "karate.read" fails to find relative files

After starting a mock.feature from a test.feature karate.read() iterprets file paths relative to the last executed feature which is the mock instead of current feature
This is the simplest use case I could drill down to:
Feature:

Background:
* def port = karate.start({ mock: 'classpath:/examples/mocks/cats-mock.feature', port: 0}).port
* url 'http://localhost:' + port
* def readAndProcess =
"""
function (file) {
    return karate.read(file);
}
"""

Scenario: post cat
* def cat = call readAndProcess 'data/cat1.json'
* print cat

see mocks relative path:
org.graalvm.polyglot.PolyglotException: java.io.FileNotFoundException: W:\dev\sandbox\myproject\target\test-classes\examples\mocks\data\cat1.json
myproject.zip

this is a wontfix for me. you are welcome to provide a PR. a lot depends on WHEN the readAndProcess function in this case was defined and we can't support all these edge cases.

Ok, I wont investigate this now because it was just a POC but readAndProcess is something we do a lot. Thanks

this should be fixed in develop now

cheers!


Seperate readonly session

Problem:
Our company uses dropwizard with hibernate, but our production database is actually a cluster with a write master and read replicas. We want our dropwizard app to be able to connect to either the master or the replicas on a per-request basis depending on the endpoint.
Someone from our company previously opened #2248 which was basically a version of the internal fork of dropwizard hibernate we maintain, and works by decoupling the DAO from a specific session factory.
After some changes we've made internally, we realized the problem with that approach is that it breaks an existing workflow that allows you to have multiple datasources in your app for totally different databases, and have different DAOs connect to those.
Solution:
This is a second attempt to solve the problem stated above with a different approach. Instead of decoupling the DAO from the session factory, we replace the session factory provided to DAOs with a Dropwizard class that can hold two different connections, one to a write master and one to a read replica. That class also has a ThreadLocal that is set based on the readOnly property on the UnitOfWork, and if it is true, returns the reader connection.
This is all configured at the datasource configuration level, where PooledDataSourceFactory now has an optional parameter for a read only URL. If that property is specified, two managed data sources will be created instead of one, and the second will be connected to the read URL.
Result:
For projects using dropwizard-hibernate, you can now specify a readOnlyUrl property on your database configuration, and add readOnly=true to the UnitOfWork annotations on your endpoints to have those endpoints hit a read replica connection you specify.
If you do not specify a readOnlyUrl, it will only make one connection and use that regardless of the readOnly setting (as it does currently). So there should be no performance or resource overhead added if you do not use this feature.
Unfortunately, this is a breaking change, because the signature of AbstractDAO has changed to take in a different class. The migration should be pretty easy for most projects, unless they are manually doing something with the hibernate session factory that used to get passed in there. I could not think of a way to accomplish this change without changing the AbstractDAO.
Other changes:
Since I changed the base database configuration that is shared by hibernate, liquibase, and JDBI, I also made some minor changes to the latter two integrations.
Liquibase:
No real change, but always uses the write connection and never a read one you specify.
JDBI and JDBI3:
Added a buildReadOnly method to both factory classes that will build a instance using the readOnlyUrl if it exists.

Sorry I've let this PR languish for so long, hibernate-orm is not my strong suit, but I don't want to leave you out in the cold! 😅
Some questions:

You mention a fork of this code. Have you used this readonly feature successfully (ie: how confident are you)
What's the reasoning behind the hibernate-testing package?
Are there alternatives to this approach? I know this isn't hibernate-orm, but could one have multiple JDBI configurations -- one just points to the readonly instance?

Sorry, I missed the email update of this PR!

We have a fork of some similar but more hacked together code running in production. We have a chore to update that app to use this version, but haven’t had the resources to do that. I do have a test app very bare-bones drop wizard hibernate app (I could look into publishing it) that demonstrates the feature working. I am pretty confident in the code because the approach is pretty simple. It is just some extra logic around handling multiple database connections (which drop wizard already supports) and some changes to DAOs to not tightly couple them to a single database connection.
I’m happy to take any steps you think are necessary to demonstrate it is working properly

Circular dependency. Dropwizard-hibernate depends on dropwizard-testing, and was able to get away with that by having drop wizard-testing only depend on hibernate-core and not the drop wizard hibernate package. I replaced some publicly exposed hibernate-core classes with drop wizard classes that wrap them, so to keep the hibernate tests helper classes around would have required making dropwizard-testing depend on dropwizard-hibernate. So I moved those test helper classes to their own package to resolve that. Hopefully that explanation was not too confusing

We’ve looked a lot into alternatives, none are available that really work for us. There are some drivers for certain DBs that claim to do it, but we didn’t really have any luck with that, and it is not a general purpose solution. From the dropwizard side, I don’t think there is a way to do this with the current dropwizard-hibernate implementation. You can have multiple connections, but the way DAO classes are designed in hibernate right now means they are fundamentally tightly coupled to one particular database connection, regardless of what connection you set up in your @UnitOfWork annotation. This means that to have read and write connections right now, you would have to have separate DAOs and duplicate code across them for any read actions. From a practical perspective (at least in our case) this would lead to an unacceptable amount of duplicated code in our codebase, because many of our write operations also require reads.

@scottaj Thanks for opening this PR and sorry for the late response!
Would it also solve your issue, if Dropwizard allowed multiple sessions in @UnitOfWork, as discussed in #2360?

@joschi That feature is cool, but unfortunately I don't think it addresses our use case. The biggest technical limitation we are encountering is that a DAO class has to be tightly coupled to a particular SessionFactory.
#2360 is nice if you want to transactionally access multiple distinct datasources (with their own distinct DAO classes) in the same request cleanly. But we want to access what is essentially the same datasource, using the same DAO's, just at two different endpoints depending on context.


Scorekeeper page

This issue was made in retrospect so that a milestone's progress would be more accurate.

Done.


Make endReplaceSegments() timeout configurable

Catch timeout exception to wait segments become online for endReplaceSegments(), so it can be retried.
Make minion socket timeout for endReplaceSegments() configurable per task.

Codecov Report

Merging #7509 (da8f58f) into master (76023ae) will decrease coverage by 57.43%.
The diff coverage is 56.25%.

@@              Coverage Diff              @@
##             master    #7509       +/-   ##
=============================================
- Coverage     71.95%   14.52%   -57.44%
+ Complexity     3404       80     -3324
=============================================
  Files          1523     1477       -46
  Lines         75512    73671     -1841
  Branches      11005    10806      -199
=============================================
- Hits          54336    10700    -43636
- Misses        17512    62204    +44692
+ Partials       3664      767     -2897

Flag
Coverage Δ

integration1
?

integration2
?

unittests1
?

unittests2
14.52% <56.25%> (+0.01%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...e/pinot/common/utils/FileUploadDownloadClient.java
0.00% <0.00%> (-65.81%)
:arrow_down:

.../org/apache/pinot/core/common/MinionConstants.java
0.00% <ø> (ø)

.../tasks/BaseMultipleSegmentsConversionExecutor.java
2.19% <0.00%> (-85.16%)
:arrow_down:

...ot/plugin/minion/tasks/SegmentConversionUtils.java
0.00% <0.00%> (-72.35%)
:arrow_down:

...va/org/apache/pinot/spi/utils/CommonConstants.java
0.00% <ø> (-26.32%)
:arrow_down:

...va/org/apache/pinot/controller/ControllerConf.java
55.06% <100.00%> (-1.85%)
:arrow_down:

...ntroller/helix/core/PinotHelixResourceManager.java
60.46% <100.00%> (-4.38%)
:arrow_down:

...troller/helix/core/retention/RetentionManager.java
79.13% <100.00%> (-4.21%)
:arrow_down:

...on/tasks/mergerollup/MergeRollupTaskGenerator.java
92.99% <100.00%> (-1.35%)
:arrow_down:

...c/main/java/org/apache/pinot/common/tier/Tier.java
0.00% <0.00%> (-100.00%)
:arrow_down:

... and 1210 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76023ae...da8f58f. Read the comment docs.

Let's actually do the retry on timeout in endSegmentReplace instead of exit the call right after 1st timeout. In this way, we can avoid adding yet another config on the controller side.
For Minion side, we can keep the configuration.

Good point! Updated the pr so controller side will retry for timeout exceptions.


[ingest-core] 2 submit buttons appearing in the Ingest UI

Steps to replicate:

Upload a spreadsheet with project
Upload data files
Validate the graph
Wait for Graph Valid state
Go to Submit tab on the submission's page
Tick the submit to hca checkbox

Actual Behavior
2 buttons appearing

Expected Behavior
Only 1 submit button should appear

It seems the "Submit" button will perform the action for "Submit to HCA" when required (by ticking the HCA box) so we should not need the "Submit to HCA" button anymore.

Functionality finished, just testing on dev system

Tested:

Please ignore the above updates to ingest-ui, as this needs to be fixed in Ingest Core:
https://github.com/ebi-ait/ingest-ui/pull/150#pullrequestreview-857128097

I believe we don't need to change anything in the UI to fix the issue. We need to figure out why the export link is being generated when the state is Graph Valid. By design, the UI will display the link as a button if it's available in '_links'. @aaclan-ebi

Deployed on staging, ready for testing.

waiting for wrangler testing @Wkt8

LGTM!


Not sure where to find community for this project.. Is there a matrix channel?

I would like to learn this/get involved with helping on this project, but I'm unsure where to start and how to communicate with others involved with this project. Is there a matrix channel for this?

Thank you for having an interest in OpenRR!!!
We don't have enough docs and a chat system for this project yet. We are preparing some docs actually.
If you want to say something, you can use Issue, as you did.
Are you happy if there are a discord for this project?

I'm also interested in joining a chat system once it exists

Are you happy if there is a discord for this project?

That would be great to have!

I created discord here!!!

I updated the invitation link (without time limit)
https://discord.gg/8DAFFKc88B


Use AddEventListeners and fix focus event not firing

Fixes #6700
Microsoft Reviewers: Open in CodeFlow

/azp run android-ci.yml


[doc] missing word

📝 Summary

🔍 Description of Changes

📋 Checklist

[ ] I have read the contributor guidelines.
[ ] For large changes, or changes that affect the public API: this change was discussed or approved through an issue, on Discord, or the community discussions (Please provide a link if applicable).
[ ] I have added tests for the changes made.
[ ] I have run the code and verified that it works as expected.

📜 Reviewers

@akshayka OR @mscolnick

@majidaldo thank you for the fix!  To appease the CLA bot, can you add a comment to this PR thread with the following text?
I have read the CLA Document and I hereby sign the CLA

I have read the CLA Document and I hereby sign the CLA

recheck


FIX DOC-EXAMPLE: cache_extension.py

No longer working with current code base since the TokenStream.next() method was removed.

Thanks!


Crashes on load

Hi there,
SuRVoS crashes when I load a file. It's a 3D .tiff. It is 1450x1450x1198 and 16 bit.
Does SuRVoS have an upper limit for file size?
Any suggestions much appreciated.
Thanks,
Matt

Hi Matt,
It should work upto 1024x1024x1024. You could try resizing the images to this size.
Sri

Please reopen this if needed.


Document potential race conditions in replicated Traefik v2 CE with Letsencrypt

Welcome!

[X] Yes, I've searched similar issues on GitHub and didn't find any.
[X] Yes, I've searched similar issues on the Traefik community forum and didn't find any.

What did you expect to see?
The documentation describing integration with Letsencrypt does not explicitly warn readers that in case of multiple replicas Traefik v2 CE will have race conditions that may lead to ban from Letsencrypt(e.g. duplicate certificate limit). I believe many would use replicated Traefik v2 CE
This is related to:

https://github.com/traefik/traefik/issues/5792
https://github.com/traefik/traefik/issues/5426

Hello,
the documentation explains that:

https://doc.traefik.io/traefik/https/acme/#storage


Develop

Coverage decreased (-0.3%) to 96.514% when pulling 6ec8f5351e4c6e28bf62e59d0004f67aa0f84df4 on develop into 77b70a8d3b582c0d2eedefd62c3a0869a616087d on master.

Coverage decreased (-0.3%) to 96.514% when pulling 6ec8f5351e4c6e28bf62e59d0004f67aa0f84df4 on develop into 77b70a8d3b582c0d2eedefd62c3a0869a616087d on master.


Update debian/control as suggested in #359

Also make spidev recommended as it really ought to be installed if it's available

Current coverage is 77.16% (diff: 100%)

Merging #399 into master will not change coverage

@@             master       #399   diff @@
==========================================
  Files            28         28
  Lines          4952       4952
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
  Hits           3821       3821
  Misses         1131       1131
  Partials          0          0

Powered by Codecov. Last update 9e99a44...cb6a2b3


fix: rename label property on Endpoint class to endpointLabel

We noticed that the Node.label property overrides the endpoint label for the root endpoint with the device label, so we avoid this in a patch before this feature gets widespread use.

@zwave-js-bot approve


scn::scan/prompt from stdin with literal text does not work

When trying to scan a format string with a literal at the start, a debug assertions fires:
File: C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.26.28801\include\xstring
Line: 1853

Expression: cannot seek string iterator before begin

Code I used, adapted from the examples (using scnlib 0.3):
#include <scn/scn.h>
#include <iostream>

int main() {
    int i = 0;
    if (scn::prompt("Hi there! What's your favorite number? ", "uhh, {}", i)) {
        std::cout << "Ooh, " << i << ", interesting!\n";
    }
    else {
        std::cout << "That doesn't look like any number I've ever seen.\n";
    }
}

It seems to be related specifically to the file putback, it works when you scan from e.g. a string_view.

In range_wrapper::advance:
https://github.com/eliaskosunen/scnlib/blob/cf9497e809cb1a06b1940571494a58586975639f/include/scn/detail/range.h#L142-L149
the begin iterator of the range is not incremented for the caching cfile iterator.
As far as I can tell, this leads to operator* always yielding the same character, thus matching the literal fails.
Also, in range_wrapper::reset_to_rollback_point:
https://github.com/eliaskosunen/scnlib/blob/cf9497e809cb1a06b1940571494a58586975639f/include/scn/detail/range.h#L193-L196
the iterator is decremented m_read times,
but doesn't seem to always match how often the iterator was incremented directly, outside of range_wrapper.

This seems to be resolved on master.

It is, sorry for not responding and fixing this earlier.


feat: Adding profile_url field to user model

Signed-off-by: Kristen Armes<EMAIL_ADDRESS>Summary of Changes
This change adds the profile_url field to the user model. As of today, the profile_url field already exists in the frontend and common user models. This change is in preparation for a change I'm making to add profile_url to the databuilder user model as well. My use case requires the field for use with neo4j, but I am adding it here for consistency so that I would be able to update the get_user_record function to set the profile_url in the databuilder user model as well.
CheckList
Make sure you have checked all steps below to ensure a timely review.

[X] PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"

In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.

[X] PR includes a summary of changes.

thanks, looks good to me


Configure Azure Pipelines

This pipeline configuration builds the application and produces a build for the Release configuration

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: bangle0209 sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


linux build not installing correct version

Hi
I'm using the default action and default CI to install a mixed python rust library.
This will install on mac correctly and installs the latest version 0.1.7 (or i can do pip install library==0.1.17) all fine.
I changed the action previously to -o dist instead of -o target/dist. This got the build seemingly working and ive been testing on mac, everything working fine.
When i tried to build the linux version the installer installs an old version 0.0.2 (i think this was from before i changed the -o) however if i change the linux action to dist the build fails completely:
💥 maturin failed
  Caused by: Failed to build source distribution
  Caused by: Attempting to include the sdist output tarball dist/fastqlapi-0.2.0.tar.gz into itself! Check 'cargo package --list' output.
Error: The process '/usr/bin/docker' failed with exit code 1

Duplicate of #107, 0.0.2 might be using a older version of maturin specified in pyproject.toml.


chore: remove redundant words in comment

Closes #<ISSUE_NUMBER>

This PR:

remove redundant words in comment
This PR does not:

Key places to review:

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Adding support for HEIF for Pillow. #90

Resolves #90

Merged in 716f0613296eea85a61a22d8c8828a5cb5a94c03 (with docs).


BluerainConsumer

Added a BlueRainConsumer component, to match API with the upcoming context API in react V16.3. This uses a render prop pattern to provide BlueRain context. In upcoming releases, the internal mechanism will be shifted to the new API without any breaking changes.
Usage
<BlueRainConsumer>
{BR => <BR.Components.Text>Im consuming BlueRain via Render Prop</BR.Components.Text>}
</BlueRainConsumer>

:tada: This PR is included in version 3.5.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 3.5.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Support unstable variants for stable options

Add the ability to stabilize configuration options, while leaving certain variants unstable. This will also allow adding new unstable variants in the future, for extensible options (i.e. those configured by an enum).
Initially raised in https://github.com/rust-lang/rustfmt/issues/4991#issuecomment-1141562537

Closed by #5379


add tini to entrypoint

Would make the container shut down properly rather than having to wait for the delay set before it is killed.
https://github.com/krallin/tini

Thank you for your contribution @saltydk !


Support Delta for Spark 3.3

Current OpenLineage supports Spark 3.3 except for Delta storage provider which is still missing support for 3.3.
This needs to wait for: https://github.com/delta-io/delta/issues/1217
Integration tests for Delta & Spark 3.3 are turned off here:
https://github.com/OpenLineage/OpenLineage/blob/main/integration/spark/app/src/test/java/io/openlineage/spark/agent/SparkContainerIntegrationTest.java#L439
Spark 3.3 support has been introduced here:
https://github.com/OpenLineage/OpenLineage/pull/950

Delta 2.1 supports Spark 3.3 (https://github.com/delta-io/delta/releases)


$ isn't working

In normal mode, when I press $, nothing happens. It should move the cursor to the end of the line. I'm using "vscode-neovim.neovimClean": true.
I'm not doing anything crazy like forcing the extension to run on a remote machine, I'm just using my local installation of Neovim. However, I am using it through WSL via "vscode-neovim.useWSL": true. I'm on Windows 10 64 home, latest stable version. Latest stable version of VS Code and this extension.
I really need to know what is going on. When even basic stuff like this isn't working, this extensions is unusable for me.

I figured it out. The "vscode-neovim.neovimInitVimPaths.linux" setting is still being used, even when "vscode-neovim.neovimClean" is set to true. In my opinion, the clean setting should override the other one. To me the main reason someone enables clean is for testing/debugging. I don't want to have to setup my init path again every time think I might be done debugging.

I'm going to close this as it is just an issue with my config. I will create a new issue for the extension using both settings at the same time.