Support for catalina

Because of the use of some legacy HW components we are still at catalina, support for macos catalina would be awesome

Hi there, @MansM!
Good point. I'll try to adjust the deployment target and see what happens. 👍🏻

@MansM Yesterday I uploaded a new release. When you can, could you kindly take a look? 🙌🏻

Release v1.1.0 does indeed work on Catalina.
The menu UX is not the same as other items on the status menus, but that should be a separate issue I believe.

@karafior Would you mind opening a new issue describing the problem? (Would be awesome if you could attach some screenshots!)
Closing this one since it is confirmed to work on Catalina. :)


Create per-team-member issues

Future additions/changes to this repository should be discussed via issues. The commit messages for those changes should then include closure of the corresponding issue(s).

We now are using issues to discuss changes and bugs.


[5.8] Support unsigned integer type in SQLite using check constraint

Currently for SQLite, unsigned integer types are created as integers without notice / errors during migration. This creates confusions and problems when a workflow that relies on the column being always positive turns out to be negative as well.
By adding a check constraint for the column to be always >= 0, we could enforce the unsigned rule similar to MySQL. This allows us to atomically subtract value from the column and rely on the database to throw us exceptions, instead of handling in the app level which is not atomic.
Since check constraint can only be added during create table, I expect the impact to existing users to be minimal.

This is a breaking change, please target the master branch.


Broken download links of the Windows GPU

Hi,
Windows GPU download link are broken.

@av8ramit, can you check why the Windows GPU links are broken in README.md?

Trying again after merging a fix for hash mismatch error in cmake: https://github.com/tensorflow/tensorflow/pull/12271

I think the nightly GPU build is still broken.
We will keep looking into a fix.

Fixed!


tf.Variable.assign fails silently

System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow): see below
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Windows 10, Linux
TensorFlow installed from (source or binary): pip
TensorFlow version (use command below): 2.1.0
Python version: 3.7.6

Describe the current behavior
A special assign operation does nothing (not even raising an error).
Describe the expected behavior
At least an error should be raised.
Code to reproduce the issue
import tensorflow as tf
from tensorflow import keras

# tf.config.experimental_run_functions_eagerly(True)
var = tf.Variable([[3.0]])
model = keras.Sequential([keras.layers.Dense(1, input_shape=(1,))])
model.compile(loss="mse", optimizer="adam")

tf.print(var)  # should print 3, OK
var.assign(model.inputs[0])
tf.print(var)  # should print anything else but 3, or raise an error - but prints 3

Other info / logs
>>> tf.print(var)  # should print 3, OK
[[3]]
>>> var.assign(model.inputs[0])
<tf.Variable 'UnreadVariable' shape=(1, 1) dtype=float32, numpy=array([[3.]], dtype=float32)>
>>> tf.print(var)  # should print anything else but 3, or raise an error - fail.
[[3]]

@bersbersbers
I tried in colab with TF nightly version (2.4.0-dev20200907) and i can see after assigning operation it is raising an TypeError:.Please, find the gist here.Please, verify once .Thanks!

@ravikyram thanks, I double-check that it's throwing an error as expected. I guess TF2.4.0 will have this fix then.

@bersbersbers
Thank you for the confirmation. I am closing this issue as it was fixed in TF nightly. Thanks!


Create binaryConverter.java

Using the print statement in the main method, you can test the code in the following method, "convertToBinary," to convert any decimal value to binary.

Hi @florayasmin , can you raise a pull request of java and C++ files to the second branch of the repo


Question: How to use fields from other models to build the map method?

Hello, I'm trying to implement a collection snapshot for a model that records transactions between people and which have certain limits that when reached, issues some alerts. These are the models:
class Transaction
     field :trx_type, type: String
     field :date, type: Date
     field :city, type: String
     belongs_to :account # emits transaction
     belongs_to :person  # receives transaction
end

class Limit
  field :limit_exceeded, type: Boolean, default: false
  field :year, type: Integer
  field :city, type: String
  field :cycle_type
  field :trx_tp, type: String
  belongs_to :account
  belongs_to :person
end

To make a long story short, the idea here is that we would calculate the sum of the accumulated transactions for a given account/person pair, but that limit can be yearly (using year field) or by city (using the city field). So if cycle_type is :per_year, we use the year field to group the transactions and do the mapping, otherwise if it is :per_city, we use the city field instead.
What I don't know is how to use one or the other field in the map method, using cycle_type to decide, which is a field on the Limit model, and not the Transaction model I'm mapping. Note that any account/person pair will have the corresponding Limit object already created so at the moment of building the map, that information is already available.
But, how could I use some conditional mapping or any decision when mapping, in order to use one field or the other so that I can build the correct mapping with the correct fields set? That way when reading the values from the snapshot I can query them correctly, given the account/person pair for which we want the to check the calculated  limit.
Here's my current, still unfinished, snapshot code:
 class CumulativeSnapshot
  include Mongoid::CollectionSnapshot

   document do
     belongs_to :person, inverse_of: nil
     belongs_to :account, inverse_of: nil
     field :year, type: Integer
     field :city, type: String
     field :trx_type, type: String
     field :sum, type: Integer
   end

   def build
      map = <<-EOS
       function() {
         emit({ year: this['date'].getFullYear(), person_id: this['person_id'], account_id: this['account_id'], trx_type: this['trx_type'], city: this['city'] }, { sum: this['amount']['cents'] })
       }
     EOS

     reduce = <<-EOS
       function(key, values) {
         var sum = 0;
         values.forEach(function(value) {
           sum += value['sum'];
         });
         return({ sum: sum });
       }
     EOS

     Transaction.map_reduce(map, reduce).out(inline: 1).each do |doc|
       collection_snapshot.insert_one(
         person_id: doc['_id']['person_id'],
         account_id: doc['_id']['account_id'],
         city: doc['_id']['city'],
         year: doc['_id']['year'],
         trx_type: doc['_id']['trx_type'],
         sum: doc['value']['sum']
       )
     end
   end

Do you think there's a way of using the Limit#cycle_type on the map method to make a decision?
Otherwise, I was thinking of building 2 separate snapshots, one with the city field, and another snapshot with the year field, but wanted to check if there is any cleaner solution first, hence this question.
Thanks in Advance!

This is a little old, but if you're still interested in this @marcocanderle reopen in  https://github.com/mongoid/mongoid-collection-snapshot.


20 Second Load Time With Debug Tool Bar Enabled

Problem
Initial request and requesting the file "en_US" takes upwards of 20 seconds.
There are two parts that I am aware of to this problem:

Having debug toolbar enabled
Using node modules inside of Extensions and Themes

When I delete the large node_modules inside the Extensions and Theme, the browser has no problem making the request. The same goes for when I turn off the Debug Toolbar.
Maybe the dbug toolbar is scanning all files inside of extensions and themes everytime a request is made...
Technical Details

Pagekit version: 0.10.4
Webserver: Apache 2.4.9
Database: MySQL 5.6.17
PHP Version: 5.5.12

Troubleshooting

[x] I have enabled debug mode: https://pagekit.com/docs/troubleshooting/debug-mode
[x] I have verified the server requirements: https://pagekit.com/docs/getting-started/requirements
[x] I have tried disabling all installed extensions
[x] I have checked the browser developer console for JavaScript errors

Please try with this commit https://github.com/pagekit/pagekit/commit/52339429208aa55f043ae3aefcc3780755e094d5.

@gabe-nr suggested that. Changing that at first didn't have any effect. I just tried it again, and something must have changed because now performance is not being affected.
Closing the issue.
Thanks @MalteScharenberg !


fix: nil-check KeyValue.Value

Which problem is this PR solving?

somehow we have a corrupt client that's sending a nil Value pointer, which is causing a crash.

panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x8 pc=0xc124e2]

goroutine 959 [running]:
github.com/honeycombio/refinery/route.addAttributesToMap(0xc06ad49c20, 0xc06a9e80c0, 0x7, 0x8)
	/app/route/otlp_trace.go:236 +0x62
github.com/honeycombio/refinery/route.processTraceRequest(0xf3a018, 0xc06a79b740, 0xc0000d2260, 0xc0694f6b80, 0xc048188f40, 0x20, 0xc04a920b28, 0x4, 0xc0695825a0, 0x0)
	/app/route/otlp_trace.go:125 +0x2292
github.com/honeycombio/refinery/route.(*Router).Export(0xc0000d2260, 0xf3a018, 0xc06a79b740, 0xc0694f6b80, 0xc0000d2260, 0xc06a79b740, 0xc04c063ba0)
	/app/route/otlp_trace.go:59 +0x178
github.com/honeycombio/refinery/internal/opentelemetry-proto-gen/collector/trace/v1._TraceService_Export_Handler(0xde9a00, 0xc0000d2260, 0xf3a018, 0xc06a79b740, 0xc06aae93e0, 0x0, 0xf3a018, 0xc06a79b740, 0xc06ac94000, 0x1c197)
	/app/internal/opentelemetry-proto-gen/collector/trace/v1/trace_service.pb.go:190 +0x214
google.golang.org/grpc.(*Server).processUnaryRPC(0xc00034a700, 0xf416f8, 0xc048262600, 0xc0695825a0, 0xc000407020, 0x1424ee0, 0x0, 0x0, 0x0)
	/go/pkg/mod/google.golang.org/grpc@v1.39.1/server.go:1293 +0x52b
google.golang.org/grpc.(*Server).handleStream(0xc00034a700, 0xf416f8, 0xc048262600, 0xc0695825a0, 0x0)
	/go/pkg/mod/google.golang.org/grpc@v1.39.1/server.go:1618 +0xd0c
google.golang.org/grpc.(*Server).serveStreams.func1.2(0xc04921a1a0, 0xc00034a700, 0xf416f8, 0xc048262600, 0xc0695825a0)
	/go/pkg/mod/google.golang.org/grpc@v1.39.1/server.go:941 +0xab
created by google.golang.org/grpc.(*Server).serveStreams.func1
	/go/pkg/mod/google.golang.org/grpc@v1.39.1/server.go:939 +0x1fd

Short description of the changes

Skips attributes with no key, or no value.

FWIW this is nearly identical to what we have in hound, except there it has a .getKey()
		if attr.GetKey() == "" || attr.Value == nil {

should we make them the same for consistency?

FWIW this is nearly identical to what we have in hound, except there it has a .getKey()
		if attr.GetKey() == "" || attr.Value == nil {

should we make them the same for consistency?

defer decision to telemetry team, I'm just humble oncaller standing in

Thanks for the PR @lizthegrey - we're in the middle of moving refinery to use Husky so I ported the fix there.
@irvingpop Husky is in use in SecureTenancy now, and will be in Refinery soon. I'll be working on adding it to Shepherd next.

Thanks for the PR @lizthegrey - we're in the middle of moving refinery to use Husky so I ported the fix there.
@irvingpop Husky is in use in SecureTenancy now, and will be in Refinery soon. I'll be working on adding it to Shepherd next.

@MikeGoldsmith this fix was submitted to help us at BlockFi with a problem we're currently having with refinery.
We were hoping to be able to use this fix today without having to build our own version of refinery.

Thanks for the PR @lizthegrey - we're in the middle of moving refinery to use Husky so I ported the fix there.
@irvingpop Husky is in use in SecureTenancy now, and will be in Refinery soon. I'll be working on adding it to Shepherd next.

@MikeGoldsmith this fix was submitted to help us at BlockFi with a problem we're currently having with refinery. We were hoping to be able to use this fix today without having to build our own version of refinery.

I believe you can still fetch the artifact: https://app.circleci.com/pipelines/github/honeycombio/refinery/946/workflows/e29a9ecd-c508-47ac-9815-e66d92ab562b/jobs/2638/artifacts

@akasprzok The same fix has come in via #341, just merged. We're doing a few more pre-release checks and aim to cut a new release today.

And released in v1.7.0!


[CWS] do not send selftest rule events

What does this PR do?
One can have a rule in the policy matching the selftest events. Silent them
Motivation
Describe how to test/QA your changes
Possible Drawbacks / Trade-offs
Additional Notes

/merge


[WIP] testing branch

Don't pull yet, this is a work in progress. Adding testing.

Hey, I just found all the minitest test tests.. What's the plan with this? You can merge what i've done so far since it's in essence regression testing of the models.

Re: the plan with the minitest tests -- let's work on migrating them over to rspec tests.  Once you have a few controller specs implemented (even just some light basic specs), I can work on that.

Are you waiting to merge until then?

Nope, all merged.


Create function code action for object types generate a function with invalid return type

Consider the following:
object {
        string name;
        int age;
    } person = foo();

When using the create function code action for the above, the following is generated:
function foo() returns object {string name;int age} {

    return new();
}

The object typedesc in the return type signature is invalid.

This seems to be addressed in #28714

Is the solution actually correct? Isn't the best places to solve this is client-side (eg: Language Server). Because even though fields are not public they are part of the signature.

Is the solution actually correct? Isn't the best places to solve this is client-side (eg: Language Server). Because even though fields are not public they are part of the signature.

Which solution? You mean the generated function? Didn't quite get your concern. Is it the object type descriptor in the return type?


Tumblr Search downloader - 'query' with special characters (encoded) like " or ' + () to exact-match

Versions: from 'old' builds like v<IP_ADDRESS> to last v<IP_ADDRESS>
Thanks for the app works like a charm and it is stable :D but I have some issues with 'Tumblr Search' type and 'query' syntax (I suppose).... For example
url => https://www.tumblr.com/search/"The+Witcher"+Geralt
query => "The+Witcher"+Geralt (decoded)
or
query => "muscle+cars"+Ford  (decoded)
(none of those seem to work) *(1)
but query => muscle+cars+Ford (works)
I think Tumblr API supports 'complex queries' using "exact matches" and similar syntax to reduce output 'noise'.
*(1): The app seems in a loop, but no errors or messages (all the rest 'types' are working including auth-based blogs, liked/by, complete blogs etc... that is the only issue I noticed.
I wonder if it is a explicit restriction to 'query' or not, or if this is a particular problem in my setup or something, any ideas?

Thanks for the fast response, your code is clean and tidy, I like that very much.


Choose language for syntax highlighting

Thank you for this great library!
So I know Quill.js supports syntax highlighting, using highlight.js. The way it works is that Quill.js automatically detects the language of your code block and applies the appropriate syntax highlighting.
What I'd like, though, is the ability to choose what language my code block is for highlighting. In other words, to be able to choose the language from a dropdown above the code block. This way, users know for a fact that the language they're writing in is being used for syntax highlighting.
Is there a way to do this out of the box? Or is there an elegant way to add a CodeMirror or Ace editor block inside the Quill editor!
Thank you again for putting this project together! I really appreciate your effort.

Did you ever figure anything out for this?

2022 still nothing, how is this possible .(

Again it would be really great to get some clarification on this

Please someone, hljs does not detect html code properly, so its super annoying to go back in and change the stuff by hand

You can use quill-react-commercial.
It can choose language and copy code. Like below gif:

Is there any updates for this one? currently my quill editor will show a list of language which is very difficult to use If my users dont know about that languages. Is there any possible way to only shows certain language only?


requirements nnunet<2.3

Hi!
When installing Totalsegmentator in a fresh virtual environment via pip, it installs nnunetv2 v2.3. When running totalsegmentator I get an error stating that the downloaded weights do not fit the network architecture. I fixed it downgrading to nnunetv2 <2.3.
pip install --upgrade "nnunetv2 <2.3".  I think the requirements file should reflect this issue.

For me it works for nnunetv2==2.3.1. There are problems with nnunetv2==2.3. Can you try with 2.3.1? If this does not work: Which totalsegmentator version are you using and how does the TotalSegmentator command look like you are running?

You are right, it works, it just happens that I got a warning with version 2.3.1:
"/totalseg2/lib/python3.10/site-packages/nnunetv2/utilities/plans_handling/plans_handler.py:37: UserWarning: Detected old nnU-Net plans format. Attempting to reconstruct network architecture parameters. If this fails, rerun nnUNetv2_plan_experiment for your dataset. If you use a custom architecture, please downgrade nnU-Net to the version you implemented this or update your implementation + plans.
warnings.warn("Detected old nnU-Net plans format. Attempting to reconstruct network architecture ""
and I confused it with another error that I fixed later (running totalsegmentator with python api in a script without a main block.
Version 2.2.1 does not throw any warning.
Thanks for your quick reply!

By the way, I am calling totalsegmentator as follows:
from totalsegmentator.python_api import totalsegmentator
totalsegmentator('rtdir', 'rtoutput', output_type="dicom", body_seg=True, verbose=True)


The iOS camera image height is stretched, how to solve it.

IOS on a 13 system will cause it to freeze.


Add vendored dependencies.

Re-adding the vendored dependencies.
Signed-off-by: Patrick D'appollonio<EMAIL_ADDRESS>

@patrickdappollonio could you add a small HACKING.md file that explains how you added the vendor?
I'm hoping you used something like glide install or glide update which should set it up proper from the glide.yaml.   What do you think?

Yeah no problem, I can add that!
I actually used govendor just because I had it installed. Like I explained before, for any Go user out there, the vendor/ folder doesn't need to specifically tie it to a certain tool. Someone may use gb, maybe the upcoming go tool dep (which may see the light by the end of the year), or even some people may copy by hand the dependencies.
The rule is: if it's external, you can copy the same path inside the vendor/ folder. There's no need for an "specific" tool. The tools only provide additional benefits such as pinning an specific version (which, again, you can do it by yourself by just resetting the branch to an specific version). Glide has an extra plus, which is dependency flattening, which is good to avoid dependency loops.
If you want, I can still use glide. Usually govendor has a more cleaner approach since you don't need the glide.yaml and the glide.lock file hanging around your project's root directory, but instead it uses a vendor.json located inside the vendor/ folder itself which can also be used to pin to a specific SHA.
Let me know if you want to go with Glide or keep govendor. I'm fine with both, then we can add a HACKING.md to explain how to add new dependencies.

I added an additional set of changes. I removed the dependencies from travis, which are no longer needed, since they're vendored right here...
The second change is to the dockerfile. Since you're using wget to pull down the terraform original binary, we may run into issues depending on how the docker environment is set. Inside HPE, usually you'll have to pass the HTTP proxy variables inside the dockerfile, but you can omit that part and use your own environment by downloading the file using ADD rather than an actual command, then just extract it as needed (an example is here in the dockerfile of my alpine-packer image).
Try building it with this new Dockerfile and let me know! It should have less layer caches.

Great, much cleaner and works for me.   I'm indifferent in the tool we use for vendoring and was more concerned on making it clear what our processes was for getting and keeping up with updates to the plugin repos from terraform.   I was hoping maybe a Makefile or HACKING.md file to describe how a developer should build it and manage vendoring when needed (basically our recommended approach with sample commands).
Overall, I'm good with this PR, and thank you for getting the vendor.json in place.   If we can agree to use govendor then we can nuke glide.yaml and have that be our way of doing it.  Your call.
On my side for HPE I build with this command:
docker build -f ./Dockerfile --no-cache \
               --build-arg http_proxy=$http_proxy \
               --build-arg https_proxy=$https_proxy \
               --build-arg no_proxy=$no_proxy .

This way it avoids exposing environment dependencies into the Dockerfile, which we should avoid doing.
What do you think of the following changes for this PR:

Add a HACKING.md helper file to explain how to update /vendor using govendor
remove glide.yaml (up to you)
move the build line from .travis.yaml from after_success section to script: section, so that it reads:

sudo: required

services:
  - docker

language: go

go:
- 1.8

env:
  global:
    - secure: "JJBNOjRJ11XyeuGd+IyVSG+UBn4gvM4j20pG7WVc49FkqJAwkbOEOHKxeqvDQMMPqdnJ4nn0PR+DDHMCifVmBnghiMF6mMlsbxfR8kRjBP7kOjgBkglW4iU4GDAmuxWIWREo3lYI/pc2Ub7mDpCA+nS2ExEpiwzeFhY9skXVDpJxf0uKcQDKHGkV6APdFLalwtcEKeSeZCZvJGMR48cJ725vZ3pW3JgH7a0fKFR2LnmIDKhWU5OL45dewoSu4HGmrC6mxIABf3MLTqItbbSoRhb1voz2iDd7QqXsCIQ9gc2uYYyQybSYi7ohVEh78fmF/zpFfQkN2UPEbidb0SgrJvGmrnX6MN+AT1hhbI6LFuPfCHVbYog6iwkkjo4Ys+uVTx8+LiOTdS+ufVS4Hi8daihuRXI9+3+DBkdF5ZvHDBgxe44oHiK6C52brcVL5/YcG0Q3QnRRpGlaItBttcgTBbZbX7UaJ/Rv2soJxTcrB5pHn7FxWL/zr4B7+XQRbGPWah4WHcEnaIexwcheYeUHVW5pcz6YMgLzOH7btPCiS98240o/0vrxOxv60rDLmWakkZ06stHd9sLYYKDNMsqhTWSNmbzC6n3dmICwRWXlFmywK9eAKpAIN67JgE2E5l/gUgccwh59nvSSj2BNyfG6uvJNGXuxncPJda/4NrV2x5Q="
    - secure: "NGR5vzS4T1dJ/0kbVqFYwW6oThE7JH4UBFBAzEc7vT6h6NANmY1O+6ojRdmSvnTIjN4vxXZzWfhQTLW9T3pMAeEhyjfn2p2T5fFAf381Ch5fu2fuAbCMOm+gCgSg/FAkQ3qCCAzniPv0cHl7c76NvG6wcC+geVDZw6YmwZ6m3DZ8vT1hQLWZggSeFvNmCsYh6NTulKXxjYOmGGkAkfkzSZxHcFOaMhVYEnQrig4tT6DN0Cjeq089R2pyATSFen5eGzo6Othy/lWkZrd0WWBIj9cX49CL7vvzFtodRALdAC7+GxcNYgmJZWfbMFU6ud01VZ/C8BvBqsELkdxqGdlGr/GUXy9wLQfCp2PyfV9qOa6y8qBCVlbcHzO1WNFAORnJpoD9w5r+/50zQ3o2G/lsHv4+WytHjz1CdiGLUxEXDrjp1uGBWoFb+xR9yqfzH2c4wCoGQSBZkbDa8ESABsrNOc9ewsmStFeq4txmfCR/WmkW+Tr7Ylq5h1XXbzn6PnLvzvQ/dDkk9HdInfpfa4wuNm4k6/7/+gp4NxtHHNy6IudFNFG6Yzmap1Z0q00Mzi3DGFqgHupFB/Rv2Cw+40fcchtCF0KXSRD6eAXHH3pNGscY1hekEd7IbC4w9BkLUxb2q/g6fzP/is1ylBovsnoK5zMuADEPkp+AJHBvyM8tuVk="
    - secure: "vb8LigJ62OtLmgkCDsPXrPKdIxpwu4pvTYWjhvHO1gTr2PHEg5cNkXbrcileY8uzsfc1qoIYX9xbteM4Gcu8UO160R4V47dXxSYs8i1FGPQnW1UmXpkEmfPPHLJUB0WesYXfveCypuWk9ydNVoveLEVdm5S57t29xUEx2taANBktuTSEro4cXD49n4uy/EVnZqPOuXc1qzng1RoEX6O2q3x/C+Sa+jaBo/2UtrwloHS25xOoHh4Lwq6bYQIZZfJaitQnbYxm6trcWcTlJH06qRAoRCvFrZkTvaAUvjO/Y2BNlgfbFTfD9mB7DNGK28T5U5Jd7dX7nq3SVVQfdS32xJAaUDG6gt9QvO2gDxe+xnp1745NS/PrBwrDeRiSrv2bubNua+h1bJz6K5D9horkWuL+S9MI4IV4dBADrG4gFqzXQZESO5Zo8SGIkvwz7xzEr1cXRj3Tt73gU0LEvitXHjDuXtmsZYhRfCQqnWf4QQbieQGnUn0lkPtz4pfv17pxvGQ/fiHFq5bBHiKyn8dKMD2Wce8Xbt7pGucQRmUhoPbvET8h/CyiT3QDiQu9qZbiO+vzNbC5yh8FAwx69ehgzRiJ/uWZ5Thoc0gtrWq7lJgVlB6BP7m9zpTN46a2ug4v0oZ7oPJFNgfjwRqnIkILhuGdaP4CyedH344djywe+0c="
    - COMMIT=${TRAVIS_COMMIT::8}
    - REPO=mbfrahry/terraform-provider-oneview
script:
  - docker build -f Dockerfile -t $REPO:$COMMIT .
after_success:
  - docker login -e $DOCKER_EMAIL -u $DOCKER_USER -p $DOCKER_PASS
  - export TAG=`if [ "$TRAVIS_BRANCH" == "master" ]; then echo "latest"; else echo $TRAVIS_BRANCH ; fi`
  - docker tag $REPO:$COMMIT $REPO:$TAG
  - docker tag $REPO:$COMMIT $REPO:travis-$TRAVIS_BUILD_NUMBER
  - docker push $REPO

Also, since we don't need wget, sudo, git, make, ... just unzip now, can we change the Dockerfile to only apk install this:
RUN apk add --update unzip

We still have to set proxy with build args, but thats an HPE thing.
Thanks!

I would definitely love to see it this way! I'll add the Hacking.md file and then explain in there what's the approach.
I'll also modify the Dockerfile to remove the extra dependencies. I was unsure if because of development you guys might use some of the other packages.
I'll do an extra step: If you notice, we're still using @mbfrahry's account on Docker Hub to upload the docker image tagged "latest". DCIA has an account which is more generic, and we can remove the secure strings from the .travis.yml to add them into the travis CI panel, rather than have them hardcoded here. Since it's just a "testing" feature, we can still benefit from publishing it in an HPE-managed account rather than use Matthew's free space (thanks, Matt! 👍)
We don't even need to tag the image that much, since latest is by default, we can use this approach which only pushes if a) we're merging to the master branch; and b) merge and build are successful. That way we can still use PRs as usual.
Let me know what you think!

Great, i'll wait for your tweaks on the Dockerfile and HACKING.md but the other changes we should do in another PR, so we can separate the story.  Thanks!

Will do! I'll let you know when it's ready.

Alright @wenlock, done. I've also updated the main README to make it more Go-friendly so the setup takes less time (since you don't have to download dependencies any longer, plus, go get will do the git clone with go install).
Let me know what you think!


KPM deployment fails when accessed via proxy

KPM deployment doesn't work for me currently, as I access the dashboard through kubectl proxy. It looks like the URL you form here to POST to, should be formed using the resource_() helper, as is done in the other deployment method.

cc @abodelot

Interesting, so what's the error exactly?
Do you mean the HTTP query fail with 4xx status because URL is not correctly formatted?
Trace from browser would be great!

The problem is that I'm not accessing the dashboard directly via an external ip address. I access it via the kubectl proxy. This changes all of the in-browser urls that the dashboard needs to use in Javascript.
Here is the failure when deploying ant31/rocketchat: http://i.imgur.com/xBdvocF.png Note how the URL that the browser posted to does not look like the URL actually in the URL bar.
Here is a success when deploying just 'nginx': http://i.imgur.com/skaX78s.png Note the request URL in the Headers pane. It looks like the same URL format as is displayed in the browser URL bar.
I think that the resource_() function that I mentioned earlier handles this url formation...


morphing voicepacks

We should choose the "default" voice of each character and tune a voice pack specifically for them. Otherwise it can be jarring if it seems like a different voice actor is playing the grunts.

For this we should just take an existing voice pack and morph it with plugins to sound like the character's default voice endpoint. The current settings are found in hangout.scn.
For example for Scillia we should morph the shishi voice pack to sound like sweetie belle, and then add that as the sweetie belle voice pack. Ideally it's a process we can apply to all sounds in the pack equally, but the most important part is the grunts since they play simultaneously with the endpoint.
Originally posted by @avaer in https://github.com/webaverse/app/issues/2730#issuecomment-1086661020

[ ] morphing voicepack for scilly
[ ] morphing voicepack for drake

voicepacks will be pushed to voicepacks repo

link to the issue on voicepacks repo:
https://github.com/webaverse/voicepacks/issues/12


Add Awesome Icons

https://github.com/mrzmyr/awesome-icons

It's still a little light on content IMHO. Please check the contribution guidelines, create-list.md and the awesome manifesto. Also please don't remove that blank line.

Yes, needs more content. The name is also very loose. You've chosen to cover icon fonts/packages, but it could also include articles on using icons, creating, etc.

Closing for now. Ping me here in a few weeks and I'll reopen and reconsider.

:+1: indeed, lets see in a few weeks.


Policies should be global, remove location parameter and default it

Small fix, WAF policies should always be created with Global region. Remove the location parameter and hard code the region to global as in Front Door objects.

This checklist is used to make sure that common guidelines for a pull request are followed.

For new extensions:

[X] My extension description/summary conforms to the Extension Summary Guidelines.

If this PR is for a new extension or change to an existing extension, use the following to try out the changes in this PR:
docker run -it microsoft/azure-cli:latest
export EXT=<NAME>
pip install --upgrade --target ~/.azure/cliextensions/$EXT "git+https://github.com/digavino/azure-cli-extensions.git@waf-policy-should-be-global#subdirectory=src/$EXT&egg=$EXT"


CI: Test libhermit-rs on uhyve with rusty-demo

This commits adds testing of libhermit-rs for pushes and PRs. Both debug and release builds are tested with 1 and 2 cores each.
Tests are done via the rusty-hermit demo in rusty-hermit. rusty-hermit is cloned and checked out to the devel branch. The demo is then compiled with the version of libhermit-rs that triggered the build and not the version specified as a submodule in rusty-hermit.
rusty-hermit including libhermit-rs is compiled fresh every time, but cargo dependencies such as uhyve and cargo-download are cached to speed up build time

👍


Hardware Interrupts tutorial not working

Hi I started to implement Hardware Interrupts as described. But neither the timer nor the keyboard handlers get called. I am using uefi by using the newer bootloader crate. Otherwise my kernel follows the tutorial. Any ideas what may be happening or how to debug this?

(Code can be seen at https://gitlab.nordgedanken.dev/toy-kernel/toy-kernel/-/commit/37cc6e38c769c73bcce5d41ae40ea554d36e144a )

AFAIK you can't use the 8259 PIC with UEFI. You need to use the APIC instead if you want UEFI support.

This is answered, so I'll close it. I'm still working on the upcoming third edition of the blog, which will feature UEFI booting and use the APIC instead of the legacy PIC for interrupt handling.


concept

This throws a lot of stuff at the wall to see what sticks, feel free to edit/ignore

Uses all the available git-job setup methods from cpg_utils.git (i.e. the repo, hash, organisation etc. are all determined based on the current commit/location)
When tar.gz files are found, store their full paths, instead of path-within-bucket
Pulls out the job setup method calls into a dedicated method (not functional)
Reads each blob-ject into each batch job in advance (should preclude failures from copying the data into the root partition)
Creates an output directory for each job, which becomes the extracted data directory (e.g. instead of ./storage/extracted which could lead to clogging the root partition. Based on This Page I think all ResourceFiles are mounted at /io, which is where the requested storage volume should be mounted. i.e. this should force Hail Batch into attaching the requested storage, writing the tar file into it, and unpacking the data into it, leaving the root partition unscathed)
changes input_bucket to bucket_client - semantics, but this approach would no longer pull input from that bucket

Creates an output directory for each job, which becomes the extracted data directory

I'm confused at how this is being done. job.extracted is passed to the click --extracted option. How is this forcing the job to mount the storage on /io?
I might be thinking too simplistically, but can we pass something like /io/extracted to the --extracted option to force the storage to mount there?

I wrote a big thing that didn't really answer your question... Posted on Slack. More concise answer here (hopefully)
When you use job.name, Hail Batch substitutes that out for a path /io/batch/job/name - the usual use-case is so that Hail knows where to retrieve files from if you want to copy results out after a batch completes.
The structure of the extracted path as a String here would be /io/batch/batch_hash/outputs/output_hash/extracted, which provides a path in the correct location, exclusive to this job. It's impossible AFAIK to know the hashes in advance, so making Hail do it keeps each job's data segregated.

I don't remember what this was trying to solve


QA - Site - Product Detail Page - Validation message needs to change for minimum quantity.

QA - Site - Product Detail Page - Validation message needs to change for minimum quantity.

Click on search button and go to search page.
Click on any product and go tot detail page.
Select Place Order tab and Select product Color.
Enter less than minimum Qty in Qty box.
Fill other data and click on Add to cart button.

Not Able to Check Minimum qty Validation on Detail Page.

This issue was resolved but because of some other issue we are getting problem in place order. Now it's working.

Done. Validation Message Changed Now.


add another protocol USB com port

instead of connecting via wi-fi, you can use any Arduino with an IMU

Would this properly support enough trackers?

I think so and there are also USB hubs

This might be added when USB dongle support is implemented

I think the operating system takes care of these things, just select the input with and it should work, it would be like changing ip just select the correct device

That's not what I meant. When we implement dongle support we will add serial protocol in firmware and software, so it could be used for this later too.

Obviously, other users can have a separate USB bridge, such as FT232 .
However, since it cannot be added to the support list forever, I want to have the user manually select the tracker in the following ways.

How about this? Is it OK? That only appears when the tracker is not found and usually works the same as before.

There will be a serial protocol to distinguish trackers from non-trackers, see #112 so it won't depend on hardware at all

We should add a filter for "USB Serial Port (COM[0-9]*)" FT232 chip set shows up as this.

We implemented USB-HID support now in #913


Add build status and coverage percentage in README.md

This PR adds latest build statuses and code coverage percentages from public pipelines of each component - azfile, azblob and azdatalake.
The output will be similar to the following -
.

[x] The purpose of this PR is explained in this or a referenced issue.
[x] The PR does not update generated files.

These files are managed by the codegen framework at Azure/autorest.go.

[ ] Tests are included and/or updated for code changes.
[ ] Updates to module CHANGELOG.md are included.
[x] MIT license headers are included in each file.

/check-enforcer evaluate

/check-enforcer evaluate


Conflict with original Panasonic Comfort Cloud app

Hi!
With the enabled integration, the original Panasonic Comfort Cloud application popups error 1001-0007: Your Cloud session has expired due to inactivity. This is mentioned in the README.
I assume, if there was any configurable setting in the integration, to regulate the frequency of Aquarea current values pulling, it would be possible to use these both apps simultaneously. Like, if to setup values pulling once per 10 mins, a user could run Panasonic Cloud app for 5-7 mins, which is more than enough to look through the current stats (power consumption, costs, etc., which are not available through integration).
Thank you!

I'm having the same issue

same issue, I have to disable the integration in ha to use the Panasonic app.
Thanks!

There is a workaround for it:

login into regular user account and submit form for service account
login into service account and go to configuration tab -> click on button "User screen link"
this will redirect you to user account but with service account session which does not interfere with regular user session


Inaccuracy in README.md file in orion/evaluation/

Orion version: 0.1.5
Python version: 3.6.2 64 бит (AMD64)
Operating System: Windows 64

Description
perhaps weighted = False, as in the manual

Thanks for pointing this out @Shanginre!
I will update it shortly

Thanks for pointing this out @Shanginre!
I will update it shortly


fixed typo in example code

Hi, please accept this request.
Regards,
Vijayant

Perfect, thank you


Initial db creation causes stack overflow

If the db doesn't exist when a test runs, it's created as expected, but the test times out or something. When building on AppVeyor, I get a stack overflow exception

when testing locally, I get the same error

The db creation attempts are happening really fast, and leading to stack overflow. I'm not sure why I didn't run into this earlier. I just put a Thread.Sleep of .5 seconds after the db creation attempt.


API additions for automating transaction building

Add API evaluateTransactionBalance
Compute the total balance of the proposed transaction. Ultimately a
valid transaction must be fully balanced: that is have a total value
of zero.
Finding the (non-zero) balance of partially constructed transaction
is useful for adjusting a transaction to be fully balanced.

Currently based on #2881, can be rebased on master once that is merged. More patches to follow.

Now rebased on master. Still more patches to follow.


[WIP] Avoid costly function evaluations for points that have been evaluated before

Fixes https://github.com/scikit-optimize/scikit-optimize/issues/163
In the case of discrete spaces, I modified the optimization algorithm from choosing the point that has the best acquisition value to a point that has the best acquisition value and not been evaluated before.

ping @glouppe @betatim

dummy_minimize should also be changed

What do we do when the function is noisy? It this case, evaluating it more than once might be helpful.

Shall we focus on that for 0.1? I would personally postpone it, as it is not as trivial as it appears.

I agree with https://github.com/scikit-optimize/scikit-optimize/pull/170#issuecomment-236412433 so I think we should try and find some cases (and make examples for them) to study when/why this happens. If only so we can give a recommendation to the user, who will most likely be confused that it is happening and think it is a bug (like we did when we first saw it). So 👍 for post-0.1

By a noisy function, do you mean that which can have more than one value at a given point?

If we do consider those, then I would just add a warning if a point is chosen more than once and not do anything special. Let us hold the discussion off to after 0.1

By a noisy function, do you mean that which can have more than one value at a given point?

Yes, and I believe we should assume it is stochastic unless otherwise specified. (E.g. when tuning hyper-parameters of a model, the CV score is a noisy estimate of the true generalization of the model)

I would prefer to merge this now with code that assumes that the objective is noisy -> give a warning when a point is selected again. Then create an issue to discuss how to signal that the objective is not noisy in which case this warning might be an error. Having the warnings under the assumption of noisiness is useful and we shouldn't delay it until we figure out the API for "not a noisy objective".
(also rebase: 🔁 🎸)

Yeah cool. I'll do that tomorrow.
Btw, I think we should tune the noise hyperparameter instead of setting it to a constant here (https://github.com/scikit-optimize/scikit-optimize/blob/master/skopt/gp_opt.py#L35)


Backport #122 "Use consistent image tag in Helm values"

Fixes: https://github.com/istio/istio/issues/14805

We might want to make this release-1.2-latest-daily (if that is even built?). It doesn't matter much though since the release will override the tag anyways

@howardjohn I've followed istio/istio, which still uses master-latest-daily in release-1.2. I was thinking we'll update that at release time before tagging the release.

Oh maybe we need to change that there. Its not really used for anything though except if a dev installs from the repo. Tests and release both don't use it, so not a big deal

@howardjohn ok, sent out https://github.com/istio/istio/pull/14813


the model that use clone() as like rnn has a problem in updating parameters

hello, I am using rnn itself and also would like to make a customized layer which contains some shared network as like rnn.
The real one I made is so complex to test so I made simple layer composed of shared linear network as follows
require 'rnn'
local test, parent = torch.class('nn.test','nn.Module')

function test:__init()
   parent.__init(self)
   self.node = nn.Sequential():add(nn.Linear(3,2))
   self.module = {}
   self.module[1] = self.node
end

function test:get(step)
  local module = self.module[step]
  if not module then
    module = self.node:sharedClone('weight','bias','gradWeight','gradBias'
    self.module[step] = module
  end
  return module
end

function test:updateOutput(input)
  self.output = {}
  for i=1,3 do
    self.output[i] = self:get(i):forward(input)
  end
  return self.output
end

function test:updateGradInput(input,gradOutput)
  self.gradInput = torch.Tensor(input:size()):zero()
  for i=1,3 do
    self.gradInput = self.gradInput + self:get(i):backward(input,gradOutput[i])
  end
  return self.gradInput
end

function test:accGradParameters(input,gradOutput,scale)
   for i=1,3 do
     self:get(i):zeroGradParameters()
     self:get(i):accGradParameters(input,gradOutput[i],scale)
  end
end

(To shortly sum up, the layer contains three linear layers in parallel which share all parameters each other and borrowed the form of code from LSTM.lua etc)
so I made a very simple main script as like
input = nn.Identity()()
output = nn.test()(input)
model = nn.gModule(input,output)

then the forward and backward of model work well
However when I execute model:updateParameters(lr), there is no change of parameters
When I call model:getParameters() then it returns 8 parameters and 8 gradient parameters
Also if I do model:zeroGradParameters(), again no change of gradient parameters. Hence, I added self:get(i):zeroGradParameters() in the accGradParameters function.
One more strange thing is model:getParameters() works successfully but it does not return anything when I call model:parameters(). In the Module.lua file, as I understand, model:parameter() should return the same thing with model:getParameters(). If I do not include 'rnn' then it fails to call model:getParameters(). I looked at the code in rnn a lot but failed to find a reason why model:getParameters() success when included 'rnn' and failed when not.
Can you explain and solve the problem plz?
I know this is not directly related to rnn itself but I'll really appreciate if you answer me.

@yjy765 Yeah it isn't as easy as that. The Module class isn't the best parent for this kind of module. Instead, nn.Container should be used. The self.modules should be filled with either just node or all the 3 module clones (each approach has its advantages/disadvantages).

@nicholas-leonard Really thank you for your reply!! Anyway I found that it would be ok if I  use gradparam:zero() and optim package rather than using model:zeroGradparameters() and updateParameters().
Thanks nicholas


Swift 5.6 support

addresses https://github.com/icanzilb/MarkCodable/issues/7
I removed non-collection branch of decode implementation, there was no tests covering that, let's discuss if that's still necessary. @icanzilb

Cool work @erkekin — if all current tests pass (admittedly, they're lacking in coverage but should be testing the basic use cases I could think of) I think we should be good with removing that code you cleaned.
My only concern is about the versioning, I have a separate issue for it https://github.com/icanzilb/MarkCodable/issues/15
Since we can't seem to be able to have semantic versions and likely 5.6 vs 5.7 are going to be separate branches maybe we don't need the #if #else #end branching in code at all. I'll post a question re: semantic vs. branch versioning on the Swift forums but I think this shouldn't block us for now to merge this.
Do you have any thoughts regarding this? I'll have a moment later and I'll go over the changes in detail but looks great to me at first sight.

I see, yeah I think that's a common practice to branch versioning when it comes to swift's beta versions, in this example 5.7. given it will be released soon we can refactor accordingly to swift to semantic versioning. I leave to you to give the decision, shall I remove if macros or merge this one now?

@erkekin I left a question here https://forums.swift.org/t/whats-the-recommended-way-to-depend-on-apple-packages-with-non-semantic-versioning/60125 and I think we shouldn't hold off merging code in. I'll figure out the dependencies later on.

Much appreciated, thank you


Container won't stop (stalling on "syncing disks")

I cannot stop the container,
When I run docker image_name stop, the docker-compose logs shows:

example_db_backup_1  | [cont-finish.d] executing container finish scripts...
example_db_backup_1  | [cont-finish.d] done.
example_db_backup_1  | [s6-finish] syncing disks.

Steps to reproduce:
git clone https://github.com/tiredofit/docker-db-backup.git
cd docker-db-backup/examples
docker-compose --project-name dbbackuptest up

Both containers seems to starts OK as per the docker-compose output:
example-db           | Initializing database
example-db           | 2018-11-05 15:49:04 0 [Warning] InnoDB: Failed to set O_DIRECT on file./ibdata1; CREATE: Invalid argument, continuing anyway. O_DIRECT is known to result in 'Invalid argument' on Linux on tmpfs, see MySQL Bug#26662.
example-db-backup    | ./run: line 5: [: !=: unary operator expected
example-db-backup    | ./run: line 40: [: =: unary operator expected
example-db-backup    | ** [db-backup] Initialized at at Mon Nov 5 07:49:05 PST 2018
example-db-backup    | [s6-init] making user provided files available at /var/run/s6/etc...exited 0.
example-db-backup    | [s6-init] ensuring user provided files have correct perms...exited 0.
example-db-backup    | [fix-attrs.d] applying ownership & permissions fixes...
example-db-backup    | [fix-attrs.d] 01-s6: applying...
example-db-backup    | [fix-attrs.d] 01-s6: exited 0.
example-db-backup    | [fix-attrs.d] 02-zabbix: applying...
example-db-backup    | [fix-attrs.d] 02-zabbix: exited 0.
example-db-backup    | [fix-attrs.d] 03-logrotate: applying...
example-db-backup    | [fix-attrs.d] 03-logrotate: exited 0.
example-db-backup    | [fix-attrs.d] done.
example-db-backup    | [cont-init.d] executing container initialization scripts...
example-db-backup    | [cont-init.d] 01-permissions: executing...
example-db-backup    | [cont-init.d] 01-permissions: exited 0.
example-db-backup    | [cont-init.d] 02-zabbix: executing...
example-db-backup    | [cont-init.d] 02-zabbix: exited 0.
example-db-backup    | [cont-init.d] 03-cron: executing...
example-db-backup    | **** [cron] Disabling Cron
example-db-backup    | [cont-init.d] 03-cron: exited 0.
example-db-backup    | [cont-init.d] 04-smtp: executing...
example-db-backup    | **** [smtp] Disabling SMTP Features
example-db-backup    | [cont-init.d] 04-smtp: exited 0.
example-db-backup    | [cont-init.d] 99-container-init: executing...
example-db-backup    | [cont-init.d] 99-container-init: exited 0.
example-db-backup    | [cont-init.d] done.
example-db-backup    | [services.d] starting services
example-db-backup    | [services.d] done.
example-db-backup    |
example-db-backup    | ** [zabbix] Starting Zabbix Agent#
[...]
example-db           | 2018-11-05 15:49:11 0 [Note] Reading of all Master_info entries succeded
example-db           | 2018-11-05 15:49:11 0 [Note] Added new Master_info '' to hash table
example-db           | 2018-11-05 15:49:11 0 [Note] mysqld: ready for connections.
example-db           | Version: '10.3.10-MariaDB-1:10.3.10+maria~bionic'  socket: '/var/run/mysqld/mysqld.sock'  port: 3306  mariadb.org binary distribution#

In a new shell, when I execute docker stop example-db-backup, the only 3 following lines gets added to  docker-compose output:
example-db-backup    | [cont-finish.d] executing container finish scripts...
example-db-backup    | [cont-finish.d] done.
example-db-backup    | [s6-finish] syncing disks.

But the docker stop command never ends.
Trying to exec some command into the container gives an error:
docker exec -ti example-db-backup hostname
# OCI runtime exec failed: exec failed: container_linux.go:348: starting container process caused "process_linux.go:86: executing setns process caused \"exit status 21\"": unknown

And docker kill does not work either.
I am using:

Docker version 18.06.1-ce, build e68fc7a
docker-compose version 1.22.0, build f46880fe

That's quite interesting. I run similar versions and haven't seen this. It does look like like it's related to the S6-Overlay that I use to start and stop processes. I will do some digging to see if it's widespread.

I just had a thought which might help - Can you try a docker pull tiredofit/db-backup:test and let me know if you have better results with this image?

Same issue (docker stop won't end).
But here is the output (a bit longer):

example-db-backup    | [cont-finish.d] executing container finish scripts...
example-db-backup    | [cont-finish.d] 10-db-backup: executing...
example-db-backup    | s6-maximumtime: warning: child process crashed
example-db-backup    | [cont-finish.d] 10-db-backup: exited 111.
example-db-backup    | [cont-finish.d] done.
example-db-backup    | [s6-finish] syncing disks.

OK. I was thinking I would force kill the bash script upon stopping but that obviously wasn't it. Do you get the same results with a docker-compose down ?

It seems the bug might be related to my system.
After a reboot everything is working just fine (even on tiredofit/db-backup:latest).
Thanks for you time


Disable problematic ESP32 test

I hate blocking other stuff and this broke somewhere. I'll investigate, but let's unblock CI meanwhile.

I'd rather not, we'll never close that issue and the list just turns into a mess eventually.

I thought we didn't have required checks on HIL tests, so is it actually blocking anything?
If we're not going to update the issue, I'd rather this stayed failing so we have a reason to fix it.

I thought we didn't have required checks on HIL tests, so is it actually blocking anything?

It's not required but it looks bad :)


Improve install behavior on linux

When installing prisma2 in an ordinary Ubuntu docker image, you'll get an error, that you have to install prisma2 with --unsafe-perm.
We should come up with a better solution here instead of letting the user figure the situation out.

@timsuchanek this is being tracked in #938. would you mind closing this in favor of that?

@LongLiveCHIEF this is just mentioning the --unsafe-perm aspect of your issue. In your issue you also mention GPG and proxies. In order to have a separate working item we can plan, I created this issue.

npm also has docs to fix this behavior: https://docs.npmjs.com/resolving-eacces-permissions-errors-when-installing-packages-globally
Irrespective of Prisma, if this is not addressed on linux, users need to use sudo with npm.

Irrespective of Prisma, if this is not addressed on linux, users need to use sudo with npm.

Yes, but sadly most of the online tutorials encourage the use of sudo for installing global packages in Linux. Also, people want to install the CLI in docker to run the migrations and it is tedious to fix permissions there.

As far as a docker image goes, I'd rather have a prisma2 image as a base, which already has the binaries installed globally, as opposed to starting with the base node image myself and having to figure out how to install everything.
Providing a ready made cli docker image means I only have to worry about pulling that single image, and not making sure I have connections for all the binary dependencies.

Please open a new issue for this request @LongLiveCHIEF. It is not related to the original problem and task that is being tracked here from @timsuchanek. Thanks.

@LongLiveCHIEF I don't agree with your opinion.
I, in most cases, don't want to decide about docker image based on one particular library I am going to use inside it. I will much rather have some light base and then cherry-pick software I need.
Hopefully prisma can be improved to work seamlessly in either scenario.

Thanks a lot for reporting 🙏
This issue is fixed in the latest alpha version of prisma2.
You can try it out with npm i -g prisma2@alpha.
In case it’s not fixed for you - please let us know and we’ll reopen this issue!


Fix replace field issue on updates.

Replace flags such as 'addresses_update_action', 'emails_update_action', and 'phone_numbers_update_action' were not working on updates before this fix.

Coverage decreased (-0.5%) to 93.75% when pulling b55b3736999b91991be75acbadaff9f7e1155ffe on asadpakistani:develop into 67aed7c51e6b715075473d66550bfeb6e51695c6 on tstachl:develop.


update global json sdk version

since we're upgrading from .NET 7 to .NET 8
update the previous SDK version from 6 to 7

Internal previews

📄 File
🔗 Preview link

aspnetcore/migration/70-80.md
Migrate from ASP.NET Core 7.0 to 8.0

Thanks @WeihanLi! :rocket:


Enable addition of VC sample data in app

Is your feature request related to a problem? Please describe.
When there is an issue with the VC server, the testing is blocked since no VC can be downloaded to use in tests.
Describe the solution you'd like
It would be good if it was possible to add a sample VC. Even if this would not verify the generation of a VC, it could be used to verify any other functionality, such as the display and sharing
Note! This would solve the current block in testing due to the VC server being down.

@typelogic is working on a mock server


Guest Access not working as it should?

Describe the bug
I want to retrieve a unique Identity ID from Cognito to identify my users. With that ID I would like to store data for the users without signing them up. So if a user stores a Todo, the would look like this:
model ToDo{
userID: String
id: ID
text: String
description: String
}
reading the docs here: https://docs.amplify.aws/lib/auth/guest_access/q/platform/ios/ I would expect to receive a unique identity per device per app for my user, which does not change.
I would like to move my app from Firebase to AWS and this is the missing piece to store the data.
If there is another way - please let me know. The idea is to store user specific content and also only retrieve this content for each specific user. I would do that with this unique identity ID.
Steps To Reproduce
Steps to reproduce the behavior:

Start with the auth process here: https://docs.amplify.aws/lib/auth/getting-started/q/platform/ios/
Then adapt it to Guest Access: https://docs.amplify.aws/lib/auth/guest_access/q/platform/ios/
Try to retrieve credentials like so: https://docs.amplify.aws/lib/auth/access_credentials/q/platform/ios/

If I then call Amplify.Auth.fetchAuthSession I receive Fetch auth session failed with error - AuthError: There is no user signed in to retrieve user sub
and
Recovery suggestion: Call Auth.signIn to sign in a user and then call Auth.fetchSession
The docs say "That's it! Now as long as you are online, you will automatically gain guest credentials (which are then cached for offline use as well)." so I thought no signup necessary?
Expected behavior
Retrieving a unique identity ID per device per user to store data for that user.
Amplify Framework Version
1.13.4
Amplify Categories
Auth
Dependency manager
Swift PM
Swift version
5.4
CLI version
6.0.0
Xcode version
12.5. (12E262)
Relevant log output
2021-10-02 09:33:25.082879+0200 DataModelTest[10267:560165] [Amplify] Adding plugin: AWSCognitoAuthPlugin.AWSCognitoAuthPlugin)
2021-10-02 09:33:25.084039+0200 DataModelTest[10267:560165] [Amplify] Configuring
2021-10-02 09:33:25.084305+0200 DataModelTest[10267:560165] [Amplify] Configuration: nil
2021-10-02 09:33:25.117970+0200 DataModelTest[10267:560165] [Amplify] No plugin found for configuration key `awsAPIPlugin`. Add a plugin for that key.
2021-10-02 09:33:26.368246+0200 DataModelTest[10267:562321] [] nw_protocol_get_quic_image_block_invoke dlopen libquic failed
Fetch auth session failed with error - AuthError: There is no user signed in to retreive user sub
Recovery suggestion: Call Auth.signIn to sign in a user and then call Auth.fetchSession

Is this a regression? (i.e. was this working before a version upgrade)
No response
Device
iPhine 12 Simulator
iOS Version
14.5.
Specific to simulators
No response
Additional context
No response

FetchAuthSession returns different types of credentials, the error that you see is for user sub, but if you try to retrieve the identityid/credentials, you will be able to get it. https://docs.amplify.aws/lib/auth/access_credentials/q/platform/ios/
Can you try the following code:
import AWSPluginsCore

Amplify.Auth.fetchAuthSession { result in
    do {
        let session = try result.get()

        // Get user sub or identity id
        if let identityProvider = session as? AuthCognitoIdentityProvider {
            let identityId = try identityProvider.getIdentityId().get()
            print("Identity id \(identityId)")
        }

        // Get aws credentials
        if let awsCredentialsProvider = session as? AuthAWSCredentialsProvider {
            let credentials = try awsCredentialsProvider.getAWSCredentials().get()
            print("Access key - \(credentials.accessKey) ")
        }

    } catch {
        print("Fetch auth session failed with error - \(error)")
    }
}

Hey Roy,
thanks for taking a look.
I added your snippet to an onAppear function in my ContentView and it seems to work.
What I now get is an identity id and an access key. Can you confirm that this is the unique identity per device per app? So this should be the unique identity ID described in the docs?
Thanks
Daniel

PR change to update the documentation - https://github.com/aws-amplify/docs/pull/3764

Awesome thanks! Just saw the update.


TlMetaDataNotFound

Not sure if this is a duplicate of #5
  File "/home/USER/.local/bin/etl2xml", line 194, in on_event_record
    data.append(log_tracelogging(event.parse_tracelogging()))
  File "/home/USER/.local/lib/python3.10/site-packages/etl/event.py", line 129, in parse_tracelogging
    return build_tracelogging(self.source)
  File "/home/USER/.local/lib/python3.10/site-packages/etl/parsers/tracelogging.py", line 79, in build_tracelogging
    raise TlMetaDataNotFound()
etl.error.TlMetaDataNotFound: Meta data not found for trace logging parser

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/home/USER/.local/lib/python3.10/site-packages/construct/lib/containers.py", line 98, in __getattr__
    return self[name]
KeyError: 'data1'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/home/USER/.local/bin/etl2xml", line 252, in <module>
    main(**vars(args))
  File "/home/USER/.local/bin/etl2xml", line 231, in main
    etl_reader.parse(logger)
  File "/home/USER/.local/lib/python3.10/site-packages/etl/etl.py", line 141, in parse
    actions[event.type](event.value)
  File "/home/USER/.local/lib/python3.10/site-packages/etl/etl.py", line 133, in <lambda>
    "EventRecord": lambda obj: observer.on_event_record(Event(obj)),
  File "/home/USER/.local/bin/etl2xml", line 198, in on_event_record
    etw = event.parse_etw()
  File "/home/USER/.local/lib/python3.10/site-packages/etl/event.py", line 118, in parse_etw
    guid = EtwGuid(self.source.event_header.provider_id.data1, self.source.event_header.provider_id.data2,
  File "/home/USER/.local/lib/python3.10/site-packages/construct/lib/containers.py", line 100, in __getattr__
    raise AttributeError(name)
AttributeError: data1

Somebody send me .etl files to analyse a problem with his mail client. I'm trying to read them on my ubuntu workstation and can't convert either of them to xml.

getting same error


cannot resolve hostname on subnet

A brief description
My network has a subnet with a different domain. I can access it seamlessly on Windows but in Bash I cannot, at least not without adding the subnet domain as a search path to etc/resolv.conf.
eg. search my.domain

Expected results
Can look up hosts on any subnet within my network.

Actual results (with terminal output if applicable)
Can only look up hosts on my domain in my network.

Your Windows build number
14393.693

Steps / All commands required to reproduce the error from a brand new installation

Create a subnet with a different domain
Try pinging something in that subnet by hostname

Strace of the failing command
N/A

Required packages and commands to install
None.

See our contributing instructions for assistance.

Does this look like a dupe of #701? Do note that you are running the Anniversary Update (14393) build and the updates to WSL are currently only available to Insider builds. It should soon be also available in the Creators Update release.

Yes, that's the same issue. Sorry for the dupe.


LICENSE

Project part of Udacity :-  Introduction to Self Driving Car Nanodegree Curriculum

Project part of Udacity:- Introduction to Self Driving Car Nanodegree Curriculum


fix: Disable the maybe-uninitialized error in newer gcc

Binaryen seems to be failing to build in debian-11 CI runs on the opam repository. I'm trying to disable the maybe-unitialized error in GCC
Ref https://github.com/ocaml/opam-repository/pull/22337#issuecomment-1286556941

I also rolled back the emsdk we use to 3.1.17 because that was the version available when I added this GHA. Fixes part of #68


Visualization

Thanks for your work!
Many of the uncertainty related papers generate fancy uncertainty maps like yours, Can I ask how did you generate the visualization of Fig.4 (e) the marginal entropy.
e.g. What colormap did you use? Any post-processing?
Thank you

Hello,
The color map used for the uncertainty maps was cmap='inferno'.
If the base of the logarithm used to calculating the marginal entropy is the number of classes then the marginal entropies values for each pixel will be bounded between 0 and 1. Thus no further normalisation or post-processing is required.


release artifacts for release v0.0.3

Release artifacts for release v0.0.3
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

/lgtm


Always request version.json from network (no cache)

Details

As explained in the issue comment the only usage for HttpUtils.download was in the version check here
Instead of modifying existing code to make HttpUtils.download support a cache/no-cache options, we use fetch directly
Since now HttpUtils.download has no more usages it can be deleted
A problem with the webpack dev config was fixed so that the fix can be tested locally
Fixed Issues

$ https://github.com/Expensify/App/issues/7856
Tests

To test locally modify src/setup/platformSetup/index.website.js so that this
https://github.com/Expensify/App/blob/1c4add7b7b691724edd2040110d2adc2b92e7b60/src/setup/platformSetup/index.website.js#L63-L66
becomes:
    // When app loads, get current version (production only)
    checkForUpdates(webUpdater());

dist/version.json is created automatically by the webpack dev server - you should have this file after running npm run web
Background the app or switch to another tap
Switch back to App

[ ] Verify that no errors appear in the JS console
[ ] Verify a network request is being made to fetch ./version.json
[ ] Verify nothing happens since the fetched version is the same as the currentVersion

Modify dist/version.json to be a greater version than currentVersion
Background the app or switch to another tap
Switch back to App

[ ] Verify that no errors appear in the JS console
[ ] Verify a network request is being made to fetch ./version.json

since we expect App to refresh, because a new version is available we should, toggle to preserve Network log between refreshes
alternatively you can put a breakpoint inside the code that receive the new version, and code should be paused there after you switch back to the tab. This would also help catch the "Update Available" prompt, since now App would be in the foreground

Depending on how fast you switch back and forth between tabs, App can either refresh on the background, or prompt you to confirm refreshing. See the videos under Web that showcase both cases

[ ] Switching between tabs fast should show you an "Update available prompt like this"

[ ] Backgrounding the app and waiting for a few seconds should initiate a refresh in the background - you should be able to see a spinner briefly appearing on the collapsed tab

PR Review Checklist

Contributor (PR Author) Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] iOS / native
[x] Android / native
[x] iOS / Safari
[x] Android / Chrome
[x] MacOS / Chrome
[x] MacOS / Desktop

[x] I verified there are no console errors (if there’s a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained “why” the code was doing something instead of only explaining “what” the code was doing.
[ ] I verified any copy / text shown in the product was added in all src/languages/* files
[ ] I verified any copy / text that was added to the app is correct English and approved by marketing by tagging the marketing team on the original GH to get the correct copy.
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named “index.js”. All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[ ] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] Any functional components have the displayName property
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose and it is

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn’t already exist
[ ] The style can’t be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.

PR Reviewer Checklist

[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] iOS / native
[ ] Android / native
[ ] iOS / Safari
[ ] Android / Chrome
[ ] MacOS / Chrome
[ ] MacOS / Desktop

[ ] I verified there are no console errors (if there’s a console error not related to the PR, report it or open an issue for it to be fixed)
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained “why” the code was doing something instead of only explaining “what” the code was doing.
[ ] I verified any copy / text shown in the product was added in all src/languages/* files
[ ] I verified any copy / text that was added to the app is correct English and approved by marketing by tagging the marketing team on the original GH to get the correct copy.
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named “index.js”. All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] Any functional components have the displayName property
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose and it is broken down into smaller components in order to separate concerns and functions

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn’t already exist
[ ] The style can’t be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.

QA Steps

I think this ticket can only be tested after deploying to staging, because we need to be on older version and a new version be released in the meantime
We're primarily verifying there are no regressions and the update check works as expected
All the scenarios below are existing flows and not introduced in the current PR
We're verifying they work as expected
On web/mobile-web

[ ] Verify new version is detected during background the app

Have App opened and foregrounded before an update is released
Wait for update to be released and then background App - open a new tab
Observer App's tab is refreshing (little spinning circle appears on the tab in Chrome)
Switching back to App's tab you should be on the update version

[ ] Verify new version is detected during foregrounding the app

This happens only if you're background very quickly (see attached video)

Have App opened and in the background before an update is released
Wait for update to be released and then foreground App
You should see a prompt like this:

Pressing "OK" should refresh the page
You should now be on the updated version

[ ] Verify new version is detected during foregrounding the app - alternative

This happens only if you're background very quickly (see attached video)
Do the 1,2,3 from above, but instead of pressing "OK" on the prompt press "Cancel"
The page should not refresh
If you background App now it should refresh in the background and the next time you bring it up it would have the updated version

[ ] Verify problems due to cache are fixed (the bug in the linked ticket)

Shortly (1-2 minutes, up to 30) after an update have been published (on staging or prod) open the web page
Verify you're on the latest version
Verify that opening a new tab or backgrounding the app, does not result in App refresh - app doesn't incorrectly think there's an update
Verify that opening a new tab or backgrounding the app, doesn't result in showing the "Update available prompt"

Screenshots

Web

Note: I've setup my local environment to simulate there's always a new version

New version refreshes in the background
https://user-images.githubusercontent.com/12156624/160727009-84a67faa-5505-41dd-b4fd-777652778998.mov
New version prompts to refresh page on the foreground
https://user-images.githubusercontent.com/12156624/160727058-e47da2ac-4a75-4ab8-a2a6-0ecb5d28840d.mov
Mobile Web

New version available and refreshes App
https://user-images.githubusercontent.com/12156624/160727223-9dfe6454-f044-4f6b-b713-78014179a8d4.mov
No new version available - no page refresh
https://user-images.githubusercontent.com/12156624/160727253-0cd81de8-3cc4-46a3-9c33-b0219dea66e7.mov
Android Chrome
https://user-images.githubusercontent.com/12156624/160727885-b72f35c4-f784-439f-9c81-675953d436f6.mp4
Desktop

iOS

Android

I haven't checked some PR check items, because I'm not certain what I should do.
Waiting to be clarified in this slack thread: https://expensify.slack.com/archives/C01GTK53T8Q/p1648583058174529

@luacmartins

Hmm I'm following the test steps, I changed the version in dist/version.json from {"version":"1.1.46-3"} to {"version":"1.1.47-3"} but I don't get the prompt to update the app nor do I see a new request for version.json. Am I missing something?

About the prompt it doesn't always appear - I've updated the test steps for QA, and I thought I did for DEV, but apparently not
Regarding the request not appearing in the network tab - it's because App refreshes in the background and you have to enable the [x] preserve log toggle here:

App sees there's a newer version
App sees you've backgrounded it and it refreshes (which "applies" the update)
Refreshing clears the Network tab

I'll update the Test steps, to match QA's

@luacmartins
I've updated the description and the Test steps

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by @luacmartins in version: 1.1.51-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

@kidroca @luacmartins @roryabraham
We had hard time validating this issue as we dont see the exact time the deploy is happening and team tried our best to stop the build changes across devices.
So far we could only verify Desktop and it looks pass. Web, mWeb and Native apps did not have proper transition and it may be due to the build distribution.
Would you be able to cross check this internally?

First off – this only affects web AFAIK not other platforms

I went ahead and ran this snippet on staging web:

And honestly, that's good enough for me. I'm going to check this off on the checklist.

We'll go ahead and assume that the documentation for fetch is accurate, and that it's so fundamental to JavaScript that we don't need to do anything more to validate that it's working.

Yes, this should only affect web
I think the only way to test it in prod is to wait for an update, if there's some schedule or someone you can contact to synchronize the test it would help
Otherwise I would just keep a incognito browser open, then wait to be notified that a staging/prod build was deployed (https://github.com/Expensify/App/pull/8350#issuecomment-1089144261) and go to that incognito window
If there's a slack channel that posts a message when a build is starting it can be used to open web while the old version is still actual and then do the test steps after the deploy finishes

🚀 Deployed to production by @roryabraham in version: 1.1.51-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

🚀 Deployed to production by @roryabraham in version: 1.1.51-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
cancelled 🔪

🕸 web 🕸
success ✅


Handling events in base class while child class is free of onEvent methods

First of all sorry if it is stupid request or question, because I am pretty newbie with EventBus.
Anyway.
I want to handle some events in some base class. And register\unregister also performed in base class.
So every child class will have that behavior.
But EventBus throws an exception as I try to register base class, because of "this" pointer has type of child class which has no method like onEvent.
So how can I follow this approach, where I want to catch basic events in base class?

i have meet the same problem...
xxxActivity has no public methods called onEvent
do you have any ideal?

Hi, you need to add the @Subscribe annotation, no?

https://github.com/greenrobot/EventBus/issues/185

or add progurad ?
EventBus 3.0
-keep class de.greenrobot.event.** { ; }
-keep class * {
@de.greenrobot.event. ;
}

One option would be to add stubs in the child classes, that forward to the base class's onEvent method, though I am guessing you're trying to avoid that. Another alternative is to actually register

Would it be an option, to register a component rather than the activity itself? For example: The base activity asks the subclasses via a getComponent() to supply a (or multiple) component that should be registered with the event bus. The base activity then registeres (and later unregisters) these components and the events are then handled in these components (instead of the activity directly) and results can be passed on to activites via callbacks if need be.


[Question] Drawer

Is it works with the gesture control?
I can't open drawer by swipe when gesture control is active for phone. (Real device)

HI @shindakioku , the Drawer does work with gesture controls. For an example, see the flutter gallery's "navigation drawer" demo: https://github.com/flutter/flutter/blob/57a8b03c5e7b5a14ba4648e209bece3c4173a83c/examples/flutter_gallery/lib/demo/material/drawer_demo.dart#L97
To debug any further, we would need the output of flutter doctor -v as well as a minimal example which reproduces the problem.

@jonahwilliams hi! Thanks.
I did mean the system with native gesture control (IOS for example)
So, when i use left swipe - my phone will close the app

I'm not sure I understand. Can you attach a small demo app (a small main.dart file showing the problem) so we can see what you mean?


Logo: avoid logo image overflowing

Before:

After:

we are missing only a screenshot for a portrait orientation image (fe. 360 width 640 height)


Better automated testing

Hey everyone, great job on the library so far! As you know, I've been opening a lot of issues. I'm concerned with the number of issues that I'm having to open for edge cases in my queries. It seems to me that a more extensive test suite that covers many different permutations of selection sets would really help. A lot of the little problems I'm having should be caught by automated testing. I'm not doing anything too crazy, just stretching GraphQL beyond the basics.
Have you considered property-based testing? https://github.com/dubzzz/fast-check These types of tests require you to create a model of your data, and then you can write tests checking properties of arbitrary inputs. It's extremely powerful when appropriate, and can create a much better test suite than simple one-off unit tests. Seems to me that this would be a great fit for testing queries, as it could generate an arbitrary number of arbitrarily nested selection sets.
All of these issues I'm running into make my weary, and I'd love to feel that Graphback is rock solid.

Automatically generated comment to notify maintainers
/cc @craicoverflow, @machi1990, @wtrocki

Another example of core functionality breaking when upgrading graphback versions: https://github.com/aerogear/graphback/issues/1941

Going to close this one, as we are constantly improving out automated tests. feel free to open again!


Unable to debug if script file path contains certain characters

Type: Bug

Behaviour
If the Python file path contains certain Unicode characters, the characters disappear when passing the path to the terminal on debug.
This behavior only occurs when the terminal is PowerShell. With using cmd.exe as terminal, this behavior does not occur.
This behavior seems to be caused by a bug on the PowerShell side.
If you drop a file into PowerShell window (or PoserShell in the terminal panel), you can see that certain Unicode characters disappear from the path. Characters don't disappear when pasting a string from clipboard.
If module PSReadline is not loaded in PowerShell, this disappearance with dropping file does not occurs. (This bug is caused by module PSReadline.)
24/04/23 Added: Similarly, if PSReadline is not loaded in PowerShell on VS Code, characters all remain.
Output on the terminal is below:
PS C:\Users\User\Desktop\○_testing\vscode_test>  & 'c:\Program Files\Python310\python.exe' 'c:\Users\User\.vscode\extensions\ms-python.debugpy-2024.4.0-win32-x64\bundled\libs\debugpy\adapter/../..\debugpy\launcher' '51147' '--' 'C:\Users\User\Desktop\_testing\vscode_test\test.py'
Traceback (most recent call last):
  File "c:\Program Files\Python310\lib\runpy.py", line 196, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "c:\Program Files\Python310\lib\runpy.py", line 86, in _run_code
    exec(code, run_globals)
  File "c:\Users\User\.vscode\extensions\ms-python.debugpy-2024.4.0-win32-x64\bundled\libs\debugpy\__main__.py", line 39, in <module>
    cli.main()
  File "c:\Users\User\.vscode\extensions\ms-python.debugpy-2024.4.0-win32-x64\bundled\libs\debugpy/..\debugpy\server\cli.py", line 430, in main
    run()
  File "c:\Users\User\.vscode\extensions\ms-python.debugpy-2024.4.0-win32-x64\bundled\libs\debugpy/..\debugpy\server\cli.py", line 284, in run_file
    runpy.run_path(target, run_name="__main__")
  File "c:\Users\User\.vscode\extensions\ms-python.debugpy-2024.4.0-win32-x64\bundled\libs\debugpy\_vendored\pydevd\_pydevd_bundle\pydevd_runpy.py", line 320, in run_path
    code, fname = _get_code_from_file(run_name, path_name)
  File "c:\Users\User\.vscode\extensions\ms-python.debugpy-2024.4.0-win32-x64\bundled\libs\debugpy\_vendored\pydevd\_pydevd_bundle\pydevd_runpy.py", line 289, in _get_code_from_file
    with io_open_code(decoded_path) as f:
FileNotFoundError: [Errno 2] No such file or directory: 'C:\\Users\\User\\Desktop\\_testing\\vscode_test\\test.py'
PS C:\Users\User\Desktop\○_testing\vscode_test>

24/04/23 Edited: The terminal output example was incorrect, so I corrected it to the actual output. For more information: issuecomment-2071898101
You can see that the Unicode character "○" is missing from passed path.
Directory name ○_testing in the path changed to _testing, but there is no such directory.
Steps to reproduce:

Prepare a Python file which contains a character "○" in the path
Try to debug the Python file
Fails to debug because the path passed has changed.

Characters that disappear

｡｢｣､･ｦｧｨｩｪｫｬｭｮｯ
・゛゜´¨―‐∥…‥‘’“”±×÷≠≦≧∞∴♂♀°′″℃§☆★○●◎◇◆□■△▲▽▼※→←↑↓∈∋⊆⊇⊂⊃∪∩∧∨⇒⇔∀∃・∠⊥⌒∂∇≡≒≪≫√∽∝∵∫∬‰♯♭♪†‡¶◯
─│┌┐┘└├┬┤┴┼━┃┏┓┛┗┣┳┫┻╋┠┯┨┷┿┝┰┥┸╂
①②③④⑤⑥⑦⑧⑨⑩⑪⑫⑬⑭⑮⑯⑰⑱⑲⑳・№℡≒≡∫∮∑√⊥∠∟⊿∵∩∪

Characters that don't disappear

ｰｱｲｳｴｵｶｷｸｹｺｻｼｽｾｿﾀﾁﾂﾃﾄﾅﾆﾇﾈﾉﾊﾋﾌﾍﾎﾏﾐﾑﾒﾓﾔﾕﾖﾗﾘﾙﾚﾛﾜﾝﾞﾟ
　、。，．：；？！｀＾￣＿ヽヾゝゞ〃仝々〆〇ー／＼～｜（）〔〕［］｛｝〈〉《》「」『』【】＋－＝＜＞￥＄￠￡％＃＆＊＠〒〓￢Å
０１２３４５６７８９ＡＢＣＤＥＦＧＨＩＪＫＬＭＮＯＰＱＲＳＴＵＶＷＸＹＺａｂｃｄｅｆｇｈｉｊｋｌｍｎｏｐｑｒｓｔｕｖｗｘｙｚ
ぁあぃいぅうぇえぉおかがきぎくぐけげこごさざしじすずせぜそぞただちぢっつづてでとどなにぬねのはばぱひびぴふぶぷへべぺほぼぽまみむめもゃやゅゆょよらりるれろゎわゐゑをんァアィ
イゥウェエォオカガキギクグケゲコゴサザシジスズセゼソゾタダチヂッツヅテデトドナニヌネノハバパヒビピフブプヘベペホボポマミムメモャヤュユョヨラリルレロヮワヰヱヲンヴヵヶ
ΑΒΓΔΕΖΗΘΙΚΛΜΝΞΟΠΡΣΤΥΦΧΨΩαβγδεζηθικλμνξοπρστυφχψω
АБВГДЕЁЖЗИЙКЛМНОПРСТУФХЦЧШЩЪЫЬЭЮЯабвгдеёжзийклмнопрстуфхцчшщъыьэюя
ⅠⅡⅢⅣⅤⅥⅦⅧⅨⅩ㍉㌔㌢㍍㌘㌧㌃㌶㍑㍗㌍㌦㌣㌫㍊㌻㎜㎝㎞㎎㎏㏄㎡㍻〝〟㏍㊤㊥㊦㊧㊨㈱㈲㈹㍾㍽㍼

How to remove `PSReadline` from PowerShell

Start PowerShell with administrator privileges

Run Install-Module PSReadLine -Force to install the new version of PSReadLine

If the execution policy has not changed with Set-ExecutionPolicy, an attempt to read the installed PSReadLine is started will fail.

Since the PSReadLine is not loaded, any characters can be passed to PowerShell.

Maybe you can uninstall the PSReadLine with Uninstall-Module PSReadLine (not confirmed)

Diagnostic data

Output for Python in the Output panel (View→Output, change the drop-down the upper-right of the Output panel to Python)

2024-04-20 21:22:55.122 [info] Experiment 'pythonRecommendTensorboardExt' is active
2024-04-20 21:22:55.122 [info] Experiment 'pythonREPLSmartSend' is active
2024-04-20 21:22:55.122 [info] Experiment 'pythonSurveyNotification' is active
2024-04-20 21:22:55.122 [info] Experiment 'pythonTerminalEnvVarActivation' is active
2024-04-20 21:22:55.122 [info] Experiment 'pythonTestAdapter' is active
2024-04-20 21:22:55.122 [info] Default formatter is set to null for workspace c:\Users\User\Desktop\○_testing\vscode_test
2024-04-20 21:22:55.122 [info] Test server listening.
2024-04-20 21:22:55.123 [info] Python interpreter path: C:\Program Files\Python310\python.exe
2024-04-20 21:22:55.137 [info] > pyenv which python
2024-04-20 21:22:55.137 [info] cwd: .
2024-04-20 21:22:55.188 [info] > conda info --json
2024-04-20 21:22:57.721 [info] Starting Pylance language server.
2024-04-20 21:23:00.202 [error] Active interpreter type is detected as Unknown {"id":"C:\\PROGRAM FILES\\PYTHON310\\PYTHON.EXE","sysPrefix":"C:\\Program Files\\Python310","envType":"Unknown","envName":"","envPath":"","path":"C:\\Program Files\\Python310\\python.exe","architecture":3,"sysVersion":"3.10.6 (tags/v3.10.6:9c7b4bd, Aug  1 2022, 21:53:49) [MSC v.1932 64 bit (AMD64)]","version":{"raw":"3.10.6","major":3,"minor":10,"patch":6,"build":[],"prerelease":["final","0"]},"displayName":"Python 3.10.6 64-bit","detailedDisplayName":"Python 3.10.6 64-bit"}
2024-04-20 21:23:02.136 [info] Send text to terminal:  & 'c:\Program Files\Python310\python.exe' 'c:\Users\User\.vscode\extensions\ms-python.debugpy-2024.4.0-win32-x64\bundled\libs\debugpy\adapter/../..\debugpy\launcher' '56927' '--' 'C:\Users\User\Desktop\○_testing\vscode_test\test.py'

Extension version: 2024.4.1
VS Code version: Code 1.88.1 (e170252f762678dec6ca2cc69aba1570769a5d39, 2024-04-10T17:41:02.734Z)
OS version: Windows_NT x64 10.0.19045
Modes:

Python version (& distribution if applicable, e.g. Anaconda): 3.11.0
Type of virtual environment used (e.g. conda, venv, virtualenv, etc.): Global
Value of the python.languageServer setting: Default

User Settings

languageServer: "Pylance"

Installed Extensions

Extension Name
Extension Id
Version

autoDocstring - Python Docstring Generator
njpwerner.autodocstring
0.6.1

Azure Repos
ms-vscode.azure-repos
0.38.0

Bookmarks
alefragnani.Bookmarks
13.5.0

Cursor Align
yo1dog.cursor-align
1.1.2

Debugger for Firefox
firefox-devtools.vscode-firefox-debug
2.9.10

Edit csv
janisdd.vscode-edit-csv
0.9.1

ESLint
dbaeumer.vscode-eslint
2.4.4

filesize
mkxml.vscode-filesize
3.1.0

flexibleZenkaku
lowpolysnow.flexible-zenkaku
0.0.1

Git Graph
mhutchie.git-graph
1.30.0

Git History
donjayamanne.githistory
0.6.20

GitHub Codespaces
GitHub.codespaces
1.16.19

GitHub Repositories
GitHub.remotehub
0.62.0

gitignore
codezombiech.gitignore
0.9.0

GitLens — Git supercharged
eamodio.gitlens
14.9.0

Import Cost
wix.vscode-import-cost
3.3.0

isort
ms-python.isort
2023.10.1

Japanese Language Pack for Visual Studio Code
MS-CEINTL.vscode-language-pack-ja
1.88.2024041009

Japanese Word Handler
sgryjp.japanese-word-handler
1.4.1

JavaScript Debugger
ms-vscode.js-debug
1.88.0

JavaScript Debugger Companion Extension
ms-vscode.js-debug-companion
1.1.2

Jupyter
ms-toolsai.jupyter
2024.3.1

Jupyter Cell Tags
ms-toolsai.vscode-jupyter-cell-tags
0.1.9

Jupyter Keymap
ms-toolsai.jupyter-keymap
1.1.2

Jupyter Notebook Renderers
ms-toolsai.jupyter-renderers
1.0.17

Jupyter Slide Show
ms-toolsai.vscode-jupyter-slideshow
0.1.6

Live Preview
ms-vscode.live-server
0.4.13

merge-n-paste
RAWSEQ.merge-n-paste
1.3.7

Multiple cursor case preserve
Cardinal90.multi-cursor-case-preserve
1.0.5

Path Intellisense
christian-kohler.path-intellisense
2.8.5

Peacock
johnpapa.vscode-peacock
4.2.2

PHP Debug
xdebug.php-debug
1.34.0

PHP Intelephense
bmewburn.vscode-intelephense-client
1.10.4

Prettier - Code formatter
esbenp.prettier-vscode
10.4.0

Pylance
ms-python.vscode-pylance
2024.4.1

Python
ms-python.python
2024.4.1

Python Debugger
ms-python.debugpy
2024.4.0

Python Indent
KevinRose.vsc-python-indent
1.18.0

Rainbow CSV
mechatroner.rainbow-csv
3.11.0

Remote Repositories
ms-vscode.remote-repositories
0.40.0

Reopen Closed Tab
uyiosa-enabulele.reopenclosedtab
1.1.0

SFTP
Natizyskunk.sftp
1.16.3

Svg Preview
SimonSiefke.svg-preview
2.8.3

Table Visualizer for JavaScript Profiles
ms-vscode.vscode-js-profile-table
1.0.8

VS Code Counter
uctakeoff.vscode-counter
3.4.0

vscode-input-sequence
tomoki1207.vscode-input-sequence
0.2.0

vscode-pdf
tomoki1207.pdf
1.2.2

Zoom Bar
wraith13.zoombar-vscode
1.4.4

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-6700 CPU @ 3.40GHz (8 x 3408)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: enabled_ondirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okskia_graphite: disabled_offvideo_decode: enabledvideo_encode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabledwebgpu: enabled

Load (avg)
undefined

Memory (System)
7.90GB (1.13GB free)

Process Argv
--crash-reporter-id 9963c767-2656-4ecc-b62b-9405d4b964a1 --crash-reporter-id 9963c767-2656-4ecc-b62b-9405d4b964a1 --crash-reporter-id 9963c767-2656-4ecc-b62b-9405d4b964a1 --crash-reporter-id 9963c767-2656-4ecc-b62b-9405d4b964a1

Screen Reader
no

VM
0%

A/B Experiments
vsliv368:30146709
vspor879:30202332
vspor708:30202333
vspor363:30204092
vstes627:30244334
vscoreces:30445986
vscod805:30301674
binariesv615:30325510
vsaa593cf:30376535
py29gd2263:31024239
c4g48928:30535728
azure-dev_surveyone:30548225
2i9eh265:30646982
962ge761:30959799
pythongtdpath:30769146
welcomedialog:30910333
pythonidxpt:30866567
pythonnoceb:30805159
asynctok:30898717
pythontestfixt:30902429
pythonregdiag2:30936856
pyreplss1:30897532
pythonmypyd1:30879173
pythoncet0:30885854
2e7ec940:31000449
pythontbext0:30879054
accentitlementst:30995554
dsvsc016:30899300
dsvsc017:30899301
dsvsc018:30899302
cppperfnew:31000557
d34g3935:30971562
fegfb526:30981948
bg6jg535:30979843
ccp1r6:30993540
dsvsc020:30976470
pythonait:31006305
gee8j676:31009558
showvideot:31016892
dsvsc021:30996838
01bff139:31013167
pythoncenvpt:31022790

I fixed the incorrect terminal output example.
Wrong output: Unicode character "○" is not missing. This is not real output.
Correct output: Unicode character "○" is missing.
I prepared a different environment than usual to get example terminal output, but when I copied it, the output from the other environment was mixed in.
Sorry for the confusion.

@karthiknadig
I found that this issue occurs not only in Python but also in Java.
So this is not a vscode-python issue, but a shell integration issue.
Please move this issue to microsoft/vscode .
I installed JDK and debugged. Output is below:
PS C:\Users\User2\Desktop\○_testing\debug_test>  & 'C:\Program Files\Java\jdk-22\bin\java.exe' '-agentlib:jdwp=transport=dt_socket,server=n,suspend=y,address=localhost:52955' '--enable-preview' '-XX:+ShowCodeDetailsInExceptionMessages' '-cp' 'C:\Users\User2\AppData\Roaming\Code\User\workspaceStorage\79d9b6fc6f8d9b60cc936b7e2b1b13d9\redhat.java\jdt_ws\debug_test_f78b512b\bin' 'DebugTest'
this is DebugTest.java
PS C:\Users\User2\Desktop\○_testing\debug_test> ^C
PS C:\Users\User2\Desktop\○_testing\debug_test>
PS C:\Users\User2\Desktop\○_testing\debug_test>  c:; cd 'c:\Users\User2\Desktop\_testing\debug_test'; & 'C:\Program Files\Java\jdk-22\bin\java.exe' '-agentlib:jdwp=transport=dt_socket,server=n,suspend=y,address=localhost:52963' '--enable-preview' '-XX:+ShowCodeDetailsInExceptionMessages' '-cp' 'C:\Users\User2\AppData\Roaming\Code\User\workspaceStorage\79d9b6fc6f8d9b60cc936b7e2b1b13d9\redhat.java\jdt_ws\debug_test_f78b512b\bin' 'DebugTest'
cd : パス 'C:\Users\User2\Desktop\_testing\debug_test' が存在しないため検出できません。
発生場所 行:1 文字:6
+  c:; cd 'c:\Users\User2\Desktop\_testing\debug_test'; & 'C:\Program F ...
+      ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : ObjectNotFound: (C:\Users\User2\...ting\debug_test:String) [Set-Location], ItemNotFoundException
    + FullyQualifiedErrorId : PathNotFound,Microsoft.PowerShell.Commands.SetLocationCommand

this is DebugTest.java
PS C:\Users\User2\Desktop\○_testing\debug_test>

Unicode character "○" is missing from passed path.
Debugging didn't fail on this test file, but failed to execute cd . I think that if current directory was changed in the program, debugging will fail.