Conflicting information about custom resource conversions

This is a Bug Report
Problem:
One part of the "Versions in CustomResourceDefinitions" document says that conversion is performed from storage version to served version. Another says it's not (and furthermore, that k8s will lie about apiVersion by setting it without actually making any attempt at schema conversion).
Specifically:

https://kubernetes.io/docs/tasks/extend-kubernetes/custom-resources/custom-resource-definition-versioning/#webhook-conversion says:

The API server also supports webhook conversions that call an external service in case a conversion is required. For example when:

custom resource is requested in a different version than stored version.

At the same time https://kubernetes.io/docs/tasks/extend-kubernetes/custom-resources/custom-resource-definition-versioning/#writing-reading-and-updating-versioned-customresourcedefinition-objects says:

If you specify a version that is different from the object's persisted version, Kubernetes returns the object to you at the version you requested, but the persisted object is neither changed on disk, nor converted in any way (other than changing the apiVersion string) while serving the request.

The above sentence is not true in general. Specifically because the part:

the persisted object is neither changed on disk, nor converted in any way (other than changing the apiVersion string) while serving the request

blurs the distinction between the "persisted object" (which indeed never changes on reads) and the served representation  (which definitely is converted, if only to change the apiVersion string), this sentence could be read in two ways:

The persisted object is not changed on disk. The served representation is not converted (i.e. does not differ from the persisted object) other than the version string.
This first interpretation is only correct if the schemas do not differ. A casual reader of a general document on conversion webhooks certainly dos not have this assumption, and definitely not before reading the example which follows the above sentence.
The persisted object is not changed on disk. The only conversion applied to persisted object is that the apiVersion string is changed. This conversion to persisted object happens when the request is being served.
This second interpretation is just plain wrong. The on-disk object does not change. Period.

Then later, there is an example which describes a special case of serving a v1 representation of an object persisted at v1beta1 version:

You read your object at version v1beta1, then you read the object again at version v1. Both returned objects are identical except for the apiVersion field.

This sentence is correct, and in this particular context the first sentence makes more sense (but is still blurry).
Proposed Solution:

restructure the first sentence to:

match what happens in the general case of stored version != served version. Not just in the specific vXbetaY -> vX case.
make an explicit distinction between (conceptually immutable on reads) persisted object and the served representation, rather to try and describe both in one go

provide an example for the case where conversion webhooks are actually useful (i.e. where the schema between persisted and served versions differs). This can be an additional second example, or the existing example can be replaced.
[separate issue] provide an additional example of what happens when there is no conversion webhook defined and

schemas differ
schemas are identical (except for the version string)

[separate issue] additionally, it might be good to use "stored version" consistently, rather than "persisted version". This should also probably be a different orthogonal issue.

Page to Update:
https://kubernetes.io/docs/tasks/extend-kubernetes/custom-resources/custom-resource-definition-versioning

The difference is that the persisted object is not changed no matter what version of its API you use to read it. That's what the second quote is about. If you have a persistent object and try to use a different version of that API to read or modify it, then the API server must convert its representation the persisted object to the API version that the client asked for. That's might involve a webhook for a CRD, as the first quote explains.
GitHub (this website) does something similar. This issue is #27534 in https://github.com/kubernetes/website/ no matter which API you use to access it. If GitHub adds a new kind of API for accessing issues, they might choose not to replace all their stored data; instead, they keep storing the data they have and convert on-the-fly when you access it.
I think the pages are accurate. It's a difficult concept to explain well and if you have suggestions for improving the explanation (without changing the technical meaning), we'd be keen to hear them.
/remove-kind bug
/sig api-machinery
/language en
PS Using “persisted” vs “stored” consistently could be a useful cleanup - perhaps for a separate issue.

BTW, the reason that the two objects in https://kubernetes.io/docs/tasks/extend-kubernetes/custom-resources/custom-resource-definition-versioning/#writing-reading-and-updating-versioned-customresourcedefinition-objects differ only by the API version is because that was the only change you made.
In Kubernetes, the convention when promoting an API to stable (taking alpha or beta out of the version) is that you try not to change that API when you do so).

@sftim thanks for the fast response!

The difference is that the persisted object is not changed no matter what version of its API you use to read it. That's what the second quote is about. If you have a persisted object and try to use a different version of that API to read or modify it, then the API server must convert its representation the persisted object to the API version that the client asked for. That's might involve a webhook for a CRD, as the first quote explains.

Thank you for clarification, what you now described matches my understanding.

I think the pages are accurate. It's a difficult concept to explain well and if you have suggestions for improving the explanation (without changing the technical meaning), we'd be keen to hear them.

I think the confusing part was this:

nor converted in any way (...) while serving the request.

I'm guessing this is indeed the case when conversion.strategy is None. But since the preceding sections talk at length about using conversion webhooks, such statement at this point was a bit of a shock to me. :-)
I re-read the second quote and now that I have your clarification I admit it makes sense, if one assumes that the schema for the two versions is the same, as you say:

the two objects [in the second quote] differ only by the API version is because that was the only change you made

Indeed the example that follows ("To illustrate this ...", changing v1beta1 to v1) provides a hint to that, to someone who knows the semantics of version strings in Kubernetes. However this is a bit implied, and I think it would be better to make it explicit - as you say - this is a difficult concept.
I think there are two ways to improve the situation:

keep the section mostly as is, but explicitly mention that it is talking about promoting to a version without changing the schema, where conversion webhook would indeed be unnecessary. Perhaps also linking to a document which explains the versioning conventions, i.e. that changing from v1beta1 to v1 should imply no schema changes, unlike v1beta1 -> v1beta2.
be more general, and explicitly describe what happens in the following cases:

schemas differ, and there is a conversion webhook (response is converted, but stored object stays intact)
schemas differ, but there is no conversion webhook (that was actually what I was looking for in this document, since this is a corner case with potential for data loss in some cases)
no schema difference and no conversion webhook (just apiVersion is bumped in the response, but stored object stays intact)

I think the latter option would be much more informative, however I lack knowledge about what happens in the middle case. If someone could chime in with a link to the relevant place in the code, I'd be more than happy to send a doc improvement PR!

also
/wg api-expression

/remove-lifecycle rotten

/remove-lifecycle stale

@porridge in light of the discussion so far, would you be willing to revise the issue description to outline the defect you see or the improvement you'd like made?

@sftim finally had some time to reword the issue description. Please take a look and if this makes sense I can propose a patch and file the additional issues.

Thanks
/triage accepted
/priority backlog

/remove-lifecycle stale

/remove-lifecycle stale

@sftim When working on a PR to address this issue, I tried to find some documentation in https://github.com/kubernetes/community/tree/master/contributors/devel/sig-architecture to back the following claim:

In Kubernetes, the convention when promoting an API to stable (taking alpha or beta out of the version) is that you try not to change that API when you do so).

but did not find anything concrete. Do you know if this goal is actually written down somewhere, or is this tribal knowledge?

That's not a policy, it's an observation. SIG Architecture might have an opinion to add here that it's also an aim of the Kubernetes project.
/sig architecture


Some awesome icons not working ?

Hello,
I must say this plugin is incredible.
One small issue I have in my setup: some of the awesome icons do not seem to work. Did I misunderstand something?
For instance "ruler triangle" should be fa-ruler-triangle -> https://www.loom.com/i/327887a13f034223a60fe8e543a764be
But I get -> https://www.loom.com/i/9f950f1310c34fa1bea105ea8b30d522
Is there a list of supported icons somewhere?

Hey,
The icon you mentioned is not available in Map View because it is a Font Awesome Pro icon, meaning it's not part of the Free package bundled in the plugin. You can see it says "Start Using this Pro Icon" in your screenshot, while in free icons you get "Start Using this Icon".
In the Font Awesome library you can filter by Free to focus on the icons included in the free bundle.
Another reason an icon might not be available in Map View is if it was added in Font Awesome 6.
That being said, in some random testing I can still easily find icons that are supposed to work but don't, and this requires investigation.


prevent using 'entity metadata' as a question name

Description
Please explain the changes you made here.
Release notes
The title of the pull request will be used as the default release notes description. If more detail is needed to communicate to partners the scope of the PR's changes, use this release notes section.
Checklist
General
Read the full guidelines for PRs here

[ ] Added the correct label: < feature | enhancement | bug | dependencies | infrastructure | ignore-for-release | database >
[ ] Assigned to a specific person, civiform/developers, or a more specific round-robin list.
[ ] Created unit and/or browser tests which fail without the change (if possible)
[ ] Performed manual testing (Chrome and Firefox if it includes front-end changes)
[ ] Extended the README / documentation, if necessary

User visible changes

[ ] Followed steps to internationalize new strings
[ ] Wrote browser tests using the validateAccessibility method
[ ] Tested on mobile view. See mobile device mode
[ ] Manually tested at 200% size
[ ] Manually evaluated tab order

New Features

[ ] Add new FeatureFlag env vars to server/conf/helper/feature-flags.conf
[ ] Conditioned new functionality on a FeatureFlag
[ ] Wrote browser tests with the feature flag off and on, etc.

Instructions for manual testing
If instructions are needed for manual testing by reviewers, include them here.
Issue(s) this completes
Fixes #<issue_number>; Fixes #<issue_number>...

Current dependencies on/for this PR:

main

PR #6154   👈

This stack of pull requests is managed by Graphite.

Will this restriction be documented?

It's not currently, and neither is the restriction on entity name as a question name. Do you think we should add a node to the [Create a question}(https://docs.civiform.us/user-manual/civiform-admin-guide/working-with-questions/manage-questions#create-a-question) docs or is it rare enough that it's ok for admins to discover it when they get the error message?


extra data gets lost in ResponseBody

Package
dio
Version
5.1.0
Output of flutter doctor -v
[✓] Flutter (Channel stable, 3.7.7, on Microsoft Windows [Version 10.0.19045.2728], locale en-150)
    • Flutter version 3.7.7 on channel stable at C:\src\flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 2ad6cd72c0 (3 weeks ago), 2023-03-08 09:41:59 -0800
    • Engine revision 1837b5be5f
    • Dart version 2.19.4
    • DevTools version 2.20.1

[✓] Windows Version (Installed version of Windows is version 10 or higher)

[✓] Android toolchain - develop for Android devices (Android SDK version 33.0.0)
    • Android SDK at C:\Users\dirk-\AppData\Local\Android\Sdk
    • Platform android-33, build-tools 33.0.0
    • ANDROID_HOME = C:\Users\dirk-\AppData\Local\Android\Sdk
    • Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 11.0.12+7-b1504.28-7817840)
    • All Android licenses accepted.

[✓] Chrome - develop for the web
    • Chrome at C:\Program Files\Google\Chrome\Application\chrome.exe

[✓] Visual Studio - develop for Windows (Visual Studio Build Tools 2022 17.4.4)
    • Visual Studio at C:\Program Files (x86)\Microsoft Visual Studio\2022\BuildTools
    • Visual Studio Build Tools 2022 version 17.4.33213.308
    • Windows 10 SDK version 10.0.22000.0

[✓] Android Studio (version 2021.2)
    • Android Studio at C:\Program Files\Android\Android Studio
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.12+7-b1504.28-7817840)

[✓] VS Code (version 1.76.2)
    • VS Code at C:\Users\dirk-\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension version 3.60.0

[✓] Connected device (3 available)
    • Windows (desktop) • windows • windows-x64    • Microsoft Windows [Version 10.0.19045.2728]
    • Chrome (web)      • chrome  • web-javascript • Google Chrome 111.0.5563.64
    • Edge (web)        • edge    • web-javascript • Microsoft Edge 111.0.1661.54

[✓] HTTP Host Availability
    • All required HTTP hosts are available

• No issues found!

Dart Version
2.19.4
Steps to Reproduce
final dio = Dio();
final result = await dio.get('https://....com', options: Options(extra: {'start_date': DateTime.now()}));
result.extra['start_date'] == null;

Expected Result
extra data should persist and be retrievable from the response.
Actual Result
extra data never gets copied to the ResponseBody.
I assume the fault lies here: https://github.com/cfug/dio/blob/302343fa6b377fab4bb0c22aa3bb76a7b818ab86/dio/lib/src/adapters/io_adapter.dart#L173
The ResponseBody doesnt have a constructor parameter for the extra data nor does it gets set before returning.

The extra fields in options and responses are meant to be separated, and the extra in Responses are typically manipulated by interceptors. We can document this better.


Want to hide the rows by click the row title

I have the table and, want to hide the any particular row by first column click. This column is fixed column in table. I used the following command for testing. I give the table id is example.
I entered  $('#example tr:first').hide();. it will hide the row but also hide the scroll bar and also disturbed the table.
Above testing I am doing for add the group of rows. When your click the icon in  row it will show further rows, and when user click again hide the rows. This will become the table with group option.
For your review. I am attached the snap of the problem. if you have any solution please let me know.

Waiting for your reply
Thanks & Best Regards

Apologies, I couldn't get to spend time on the issues lately. As you may have noticed, the plugin build additional tables to make it look like fixed row/columns and controls the scroll. All that is setup perfectly on load time. The problem is, When the content is disturbed (width, height, value), the plugin does not detect the change and update the changes..
For now, the only quick work around I can suggest is to reinitialize the plugin again after the change.
To initialize, please try the below code and let me know if it worked for you.
$fixedTable = <your fixed table selector>; $fixedTable.closest('.ft_scroller').unbind('scroll');  $fixedTable.closest('.ft_rel_container').find('.ft_rc, .ft_cwrapper, .ft_rwrapper').remove(); $fixedTable.unwrap().unwrap().unwrap().removeClass('ui-widget-header').find('.ui-widget-content').removeClass('.ui-widget-content');
**Feel free to adjust the above code, it is just a rough code to remove all elements that plugin included to create a fixed row/column.
A working example: http://codepen.io/meetselva/pen/qNJNYQ - Try the 'Apply Plugin' button and the 'Destroy' button to see how the plugin code is reverted.
Note: Destroy does not fully revert all the changes. Changes such as width/align set to each TD/Table are not reverted. However, when the plugin is called again after changes, it will rebuild/adjust the width.
Also Do not forget to adjust the colModal if you are changing/removing the column.

Thanks for your prompt reply
As it will effect the entire screen, even user just hide only one row. This will have very unpleasant experience for users.
Please if you have any other solution share with me. I will try this as well for the time being.
Thanks for help
Best Regards

Sorry, did  not mentioned before,  that I am not removing column. When your click on the row, the some row hide or un-hide.  Column will be the remain same.
Regards


Hi I feel the UI Can be upgraded.

I checked your website and I feel I can improve the UI.

some contributor is working on this


Don't fail handshake if peer sends a Warning-level alert

Problem:
Some web servers send 112 "Unrecognized Name" warning alerts when they can't recognize SNI extension. Openssl and other TLS clients simply ignore the warnings and proceed, but s2n treats all warnings as fatal and as result s2n fails the handshake.
Proposed Solution:
Fail only if Alert has non-warning level https://github.com/awslabs/s2n/blob/3df522f/tls/s2n_alerts.c#L88-L89

Closed by #855


Turtlebot3 - Missing WiFi Connection during SBC setup

ISSUE TEMPLATE ver. 0.4.0

Which TurtleBot3 platform do you use?

[ x] Burger
[ ] Waffle
[ ] Waffle Pi

Which ROS is working with TurtleBot3?

[ ] ROS 1 Kinetic Kame
[ ] ROS 1 Melodic Morenia
[x ] ROS 1 Noetic Ninjemys
[ ] ROS 2 Dashing Diademata
[ ] ROS 2 Eloquent Elusor
[ ] ROS 2 Foxy Fitzroy
[ ] etc (Please specify your ROS Version here)

Which SBC(Single Board Computer) is working on TurtleBot3?

[ ] Intel Joule 570x
[ ] Raspberry Pi 3B+
[x ] Raspberry Pi 4
[ ] etc (Please specify your SBC here)

Which OS you installed on SBC?

[x ] Raspbian distributed by ROBOTIS
[ ] Ubuntu MATE (16.04/18.04/20.04)
[ ] Ubuntu preinstalled server (18.04/20.04)
[ ] etc (Please specify your OS here)

Which OS you installed on Remote PC?

[ ] Ubuntu 16.04 LTS (Xenial Xerus)
[ ] Ubuntu 18.04 LTS (Bionic Beaver)
[x ] Ubuntu 20.04 LTS (Focal Fossa)
[ ] Windows 10
[ ] MAC OS X (Specify version)
[ ] etc (Please specify your OS here)

Specify the software and firmware version(Can be found from Bringup messages)

Software version: [x.x.x]
Firmware version: [x.x.x]

Specify the commands or instructions to reproduce the issue.

ifconfig

Copy and Paste the error messages on terminal.

HERE

Please describe the issue in detail.

During the setting up of raspberry pi step in SBC setup. I am unable to find the wlan0 setting. I am getting ethernet and l0 alone. Also during this setup i am not getting a GUI based display, the turtlebot boots in a command line setup only. Please advise on how to rectify this issue and setup the turtlebot3.

@sandymer07
You might have a corrupted wifi driver.
Have you tried something like below?
https://raspberrypi.stackexchange.com/questions/106947/wlan-module-gone-rpi-4-b

@ROBOTIS-Will Thank you so much for the response. I solved the issue by installing the driver files again. Appreciate the quick response from your side.

Closing the issue as the problem is resolved.


[Bug] Incorrect Accumulation of ‘OF’ Flag in fflags After Executing fsqrt.d on Infinity

Bug Description
Hi,
When executing the fsqrt.d instruction on a double-precision floating-point value representing positive infinity (0x7ff0000000000000), the Overflow (OF) flag in the fflags register is erroneously set. According to the IEEE 754 standard and the RISC-V specification, the fsqrt.d operation should not lead to an overflow situation when the input is infinity. This also results in inconsistency with Spike's output
Expected Behavior:
The OF flag in the fflags register should remain clear (i.e., not set) after performing a square root operation on an infinite value, as the result is well-defined and should be positive infinity.
Actual Behavior:
The OF flag is set in the fflags register, indicating an overflow, which contradicts the expected behavior defined by the IEEE 754 standard and RISC-V floating-point operation guidelines.
Steps to Reproduce:
Load a double-precision floating-point register with the value 0x7ff0000000000000 (positive infinity).
Execute the fsqrt.d instruction on this register.
Check the fflags register; observe that the OF flag is incorrectly set.

I have re-submitted the issue and PR in the sub-repository fpu_div_sqrt_mvp @ 86e1f55, so I am closing this issue.
Thank you!


Stuck on old widevine after canceling first run hotfix

When user hit cancel on forced widevine update on first run ("i don't have time for this now"), he stays on old widevine.
Workaround for this is manual edit "version" in settings.xml to "0" (for example).

From an implementation point of view this makes sense, there is only one first-run detection. A second run would not be a first run ;-) If we wouldn't do it like this, it would have to check every time which defeats the purpose.
We would like to have a settings menu with the option to upgrade, downgrade, remove or select a CDM (planned for v0.5.0), but that means that add-ons have to add a reference to this settings menu because a script/module plugin is not listed in your add-on list, so users would not be able to find the inputstreamhelper settings :-(
We still need to have a discussion related to this. I don't see a good option in general because of the way this mechanism works.

In the past the WIDEVINE_UPDATE_INTERVAL_DAYS was set to 1 day, which looks perfect, but actually means that every user will have a Widevine update the same day it is released (within 24h).
And if a broken/incompatible Widevine would be released (which happened before) all users are immediately impacted. The previous value of WIDEVINE_UPDATE_INTERVAL_DAYS was 30 days (so roughly 3% of our users would get an update, every day), which is potentially problematic as the advance warning for CDM revocation was less than 45 days in July. If that falls below our interval, our users would be affected too. That is why we decided to turn it down to 14 days, about 7% of our users will be impacted per day.

Closed by #91


HTML tag support in message

Thank you very much for the awesome work, now it is super easy for a newbie to implement i18n for chrome extension.
Here are some scenario where HTML tags are used to help format tips or messages. I am new here and would like to know if the plugin support it.  appreciate for any instructions.
Thanks

Hi, this plugin is a wrapper of the native browser api which does not support HTML formatting.
Technically you can use innerHTML but for safety reason I would recommend you to take a look at vue-i18n or i18next for advanced formatting.


Visual Studio 2019 Preview miss Blazor Template

Clean new INstall of Visual Studio 2019 Preivew- with all updates
Create Blazor Server App
.Razor files are uncolored in edtor
Visual Studio installer dialog comes up- is already running-
closing dialog- see nothing happen
Starting Project "Missing asp.net core-modul for hosting … iis express"
2nd machine everything works fine

Thanks for contacting us, @hannespreishuber.
This is not something runtime related. Please use VS Feedback to report this issue so the appropriate team can investigate this further.


Latitude and Longitude - issue when it has to be entered in as a integer , can I multiple it by 10 (each lat and each long) to get decimal?

Hi developers,
I have a situation, where I am using the VRPsolvereasy, and entering in the 'latitude' and longitude for different counties in Pennsylvania that are closest to Pittsburg airport. I'm running into an issue, and wanted to give a proposed solution, and see what you thought of it? So , to give you an example , there are 2 counties (of the 26 counties designatied to Harrisburg airport), where they have this latitude and longitude:
'Indiana' county,       latitude = 40.68  , longitude = -79.1  , demand = 20
'Clearfield' county,   latitude = 40.95  , longitude = -78.56  , demand = 25
However, because VRPsolvereasy requires you to enter in the 'latitude' and 'longitude' as an integer, then they both have the same latitude and longitude (since you cant use decimals) so it looks like they're identical counties, which they're not, so I would have to enter it as (when I round it)
Indiana' county,       latitude = 41  , longitude = -79  , demand = 20
'Clearfield' county,   latitude = 41  , longitude = -79 ,  demand = 25
My question is:
Can I multiple the latitude and longitude, each by 10 respectively (to capture the first digit after the decimal) and then later when I get the cost (lower bound), I will divide it by 10?
Does that work? Does it make sense?
So I could potentially enter it into the input text file as:
Indiana' county,       latitude = 406  , longitude = -791  , demand = 20
'Clearfield' county,   latitude = 409  , longitude = -786 ,  demand = 25
In that way, I would be able to differentiate between the counties, and later,when I get the solution for cost, I'd divide by 10.
What do you think?

I just wanted to follow-up an update: so I did try to multiply the latitude and longitude each by 10, in order to get the 1 decimal point (and later I would divide the cost by 10), but for some reason the program didnt run well. Hmmm. I dont know, let me try again. The good news is that the depot (philly airport) only delivers to 10 cities, so it doesnt take that long to run fortunately. I will try again, and follow-up again!

Dear @mventura00,
VRPSolverEasy works directly with distances between points. It is up to the user to calculate these distances the way he likes. If VRPSolverEasy does not run well for some data, can you please send us the JSON file with input.

Dear @mventura00,
VRPSolverEasy works directly with distances between points. It is up to the user to calculate these distances the way he likes. If VRPSolverEasy does not run well for some data, can you please send us the JSON file with input.

Yes- I will send you the input file (in CSV file) of the 5 different input files (each for a different airport). Refer please to the columns under "Rounded" (for latitutde and longitutde), since it only takes integers .
Thanks for letting me know how VRPsolvereasy works directly between points. I will have to look into that too more... I saw taht there is a funcion called 'def comput_euclidean distance'... is this what you mean? its called a couple of times.

For instance, this is what I mean - by how some counties end up having the same latitude and longitude (after you round to nearest integer). See tab called "State College airport"
Final Assignment to 5 Airports.xlsx

Transformation of input to the VRPSolverEasy model is the responsibility of the user, we cannot help you with that.
When I was talking about JSON file, I was talking about the model export, see https://vrpsolvereasy.readthedocs.io/en/latest/Important notes/index.html#issues-and-debugging

Thanks, I never heard of the JSON file before. Let me look into it.
Here are some other ideas /issues I had regarding my problem:

The input file are based in latitude and longitude degrees. This is an issue - because the fixed cost and variable cost for trucks that I put in , are based in $/ mile. I'm working to convert the degrees to miles, by doing :
1 degree = 69.17 miles  , and then I can work with 'miles' instead, so then I am more consistent (with truck variable cost and fixed cost since it is also in miles.
Thus,
Y miles = 69.17 * Latitude
X miles =COS(Latitude*0.0174533)69.13Longitude

in doing so, since everything is based off where the equator line is, then as a result, we are going to get thousands of miles (range of 2,000 - 4,000 miles+) in conversions. Instead, we can take the 'southern most' city of PA, which is Littlestown, PA, and then treating that as the x-axis = 0, and have all the other major city (in every county) based off of that , so then the range of miles is much more reasonable and on a lot smaller scale!
I did that and it looks like this (to give a sample/an idea):

Then, I'll need to  change the code (in python) in terms of how it is reading the 'input files ' (since we are using miles, instead of degrees) .
I'll need to modify the function 'def compute_euclidean_distance'
So that I give it the 'i' and the 'j' , as it is checking the distance between 'i' and 'j' (for python file: HFVRP python file)
def compute_euclidean_distance(x_i, y_i, x_j, y_j, number_digit=3):
"""Compute the euclidean distance between 2 points from graph"""
return round(math.sqrt((x_i - x_j)**2 + (y_i - y_j)**2), number_digit)
Thus, I need to make 2 changes:

Read the data file and save it in a different format. A new list (a pair of cities) and a distance between them, for every city (which I do have already, but need to organize it better in this format)
Modify the section of the code  for 'def compute_euclidean_distance' so it reads the data the way that I saved it!

My Google API distance matrix  were in  that I based my 'assignments' from before are attached: these are all the distance for all 5 airports, from all 67 counties of PA.
All 5 airport- calc the closest airport.xlsx
Final Assignment to 5 Airports.xlsx


First selection of Update Plot uses cohort_id=1

When creating a plot in a worksheet, no matter what cohort is selected, when you first click "Update Plot", it uses cohort_id=1

Same on second try. Seems hard coded somewhere.

addressed in https://github.com/isb-cgc/ISB-CGC-Webapp/pull/90

working


PermissionError: [Errno 13] Permission denied: b'/.hist'

Traceback (most recent call last):
  File "/tmp/pe-copyparty.1000.466.0/copyparty/th_srv.py", line 197, in get
    self.busy[tpath].append(cond)
KeyError: '/.hist/th/oo/z8/OoZ8HAO7fqK_T46kr-tT0ExU/OisILMaFaibiVI99cWSOYnq7.645bff6a.webp'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/tmp/pe-copyparty.1000.466.0/copyparty/broker_util.py", line 53, in try_exec
    return func(*args)
  File "/tmp/pe-copyparty.1000.466.0/copyparty/th_srv.py", line 201, in get
    bos.makedirs(os.path.join(thdir, "w"))
  File "/tmp/pe-copyparty.1000.466.0/copyparty/bos/bos.py", line 28, in makedirs
    os.makedirs(bname, mode)
  File "/usr/lib/python3.9/os.py", line 215, in makedirs
    makedirs(head, exist_ok=exist_ok)
  File "/usr/lib/python3.9/os.py", line 215, in makedirs
    makedirs(head, exist_ok=exist_ok)
  File "/usr/lib/python3.9/os.py", line 215, in makedirs
    makedirs(head, exist_ok=exist_ok)
  [Previous line repeated 2 more times]
  File "/usr/lib/python3.9/os.py", line 225, in makedirs
    mkdir(name, mode)
PermissionError: [Errno 13] Permission denied: b'/.hist'

Hello,
I've created the "/.hist" folder by myself. The user has sufficent permissions to access this folder, but I am still getting this error (and no thumbnails :( ) Can you help?

Sure! Yeah this definitely sounds like it is permissions-related somehow.
I'm curious how you are running copyparty; are you perhaps using docker or podman?
Also, what Linux distribution / version are you using? This might be relevant because some distros have SELinux which can cause very similar issues.

I installed it on my Raspberry Pi completly without docker. But I was able to make it work by adding "--hist" with a different folder on my storage device to it. Now the thumbnails are working fine :)
Maybe you can help me with something else: Is there a "default" admin password? I am using copyparty for myself, but I am not familiar with your account system and I just want to rename / delete files :)

Glad to hear :> it is possible the initial error message was a bit misleading; it was trying to make the .hist folder inside the same folder you were running copyparty in. The public error messages which appear in the browser don't include the full filesystem paths due to security reasons, so it probably looked like it was talking about the root of the SD card instead. I'll see if I can make that more obvious 👍
The only default account is the guest account (with no password) which gets read-write in the folder where you launched copyparty. The recommended way to specify accounts and permissions is by making a config file -- but if you just want to give everyone read-write-move-delete instead, you could do the following: -v .::rwmd
Or, if you want to give everyone else read-access, and create an admin account with full access for yourself: -a admin:yourpwd -v .::r:rwmd,admin
There's more information in the accounts and volumes section of the readme, which hopefully manages to explain the arcane syntax as well ;)

Thank you very much and keep up the good work :)


Comparisons to other libraries

I'm curious to hear how this is different from other libraries, such as HTMLBars.

Monkberry is really different from HTMLBars, it's not string template engine, it's DOM template engine.
It's more like React or Angular.

Another big difference is what Monkberry does not use eval or it's analog new Function to create template.
From HTMLBars source:
export function template(templateSpec) {
  return new Function("return " + templateSpec)();
}

Size matter to:
$ jsize htmlbars monkberry
htmlbars 	 41.84 kB (gzip)
monkberry 	 1.16 kB (gzip)

Hmm, I'm not sure if that is the case, the runtime is quite small.
Also, the compiled template looks to implement a similar concept to what monkberry does, build dom code from a template string, especially the build function: https://github.com/emberjs/ember.js/issues/10454

On the same note, how does this compare to sveltejs? Both seem to compile templates down into optimized vanillaJS and html... Is the compiled code generated by monkberry stand-alone or does it require a runtime?

from http://monkberry.js.org/docs/installation it does require a runtime. but the runtime is 1.25k min/gz, so pretty much negligible. the size of the generated code would be a much better comparison though.

makes sense, and the --as-module compile leads me to believe that it can build self-contained ES6 modules, which could again be composed into optimized apps with a bit of tree-shaking ala rollup or webpack2... neat.

@uhjish sveltejs is pretty awesome, but monkberry was first 😃

and sveltejs got to these first:
https://github.com/monkberry/monkberry/issues/35 each-else: https://github.com/sveltejs/svelte/pull/122
https://github.com/monkberry/monkberry/issues/37 keyed updates: https://github.com/sveltejs/svelte/pull/209
https://github.com/monkberry/monkberry/issues/2 SSR: https://github.com/sveltejs/svelte/issues/196
...maybe others
at the end of the day what matters is what a lib offers today, not who was first to an MVP [1]. for what it's worth, i consider sveltejs to also be an mvp due to how many use cases seem to require some form of "well yeah" work-arounds :P
[1] https://en.wikipedia.org/wiki/Minimum_viable_product

@elfet Imitation is the sincerest form of flattery; forking is a close second ;-).

@leeoniya svelte is awesome and have much more "media" power, better marketing. :)
I have plans to add keyed updates in future, btw.


[INLONG-7331][Sort][Manager] Support complex type field

Prepare a Pull Request

Fixes #7331

Motivation
Support complex type field
Modifications
Support sub filed of complex type filed (eg: filedInfo.subFiled)

@xxhannah do we need the feature for the Dashboard module?


Cannot get ModelExpression assignment to work if model type is in another project file

When using a TagHelper that have a ModelExpression property, I can assign a model property to it if the model type is defined in the same project file. However once I moved the exact same type to a different project, I will get the following runtime error message:

Cannot convert lambda expression to intended delegate type because some of the return types in the block are not implicitly convertible to the delegate return type

Looks like a dup of https://github.com/aspnet/Mvc/issues/4497.


[Bug]

Is there an existing issue for this?

[X] I have searched the existing issues

Have you updated FilePond and its plugins?

[X] I have updated FilePond and its plugins

Describe the bug
Hello, I am unable to validate .asice files which are digitally signed files.
The mime type of .asice file is application/vnd.etsi.asic-e+zip
Reproduction
I Installed the latest version of Filepond by using the CDN method.
Example of something that I tried:
  <script>
            document.addEventListener('DOMContentLoaded', function() {

                FilePond.registerPlugin(FilePondPluginFileValidateType);

                const inputElement = document.querySelector('input[type="file"]');
                const pond = FilePond.create(inputElement);

                FilePond.setOptions({
                    allowFileTypeValidation: true,
                    acceptedFileTypes: ["application/vnd.etsi.asic-s+zip/*"],
                    server: {
                        url: '/upload',
                        headers: {
                            'X-CSRF-TOKEN': '{{ csrf_token() }}'
                        }
                    }
                });

            });

        </script>

I also tried setting the accepted file type like this:
acceptedFileTypes: [".asice"]
When I did that then the Browse Explorer window only showed me .asice files(as it should) but when I clicked upload then I got this error:

Environment
- Device: PC
- OS: Win 11
- Browser: Chrome (latest)

https://pqina.nl/filepond/docs/api/plugins/file-validate-type/#custom-type-detection


minor/doc: suggest Flush after subscribe in examples/nats-sub.go

Since Subscribe happens asynchronously, it would be kind to beginners to mention that nc.Flush() here is appropriate if you don't want to race waiting for your subscription taking effect.
https://github.com/nats-io/nats/blob/master/examples/nats-sub.go#L47
This caught me at first, resulting in racy tests that fortunately failed 20% of the time (if it had been 1% of the time, I'd have been very sad if I launched such code into production). The slack folks were helpful in sorting it out, but could have been avoided by having the example code do it and mention that it is optional if you want an async subscription (rare, but perf oriented).

All operations are ordered and consistent on a per connection basis. The fact that we optimize sending packets to the server should not be applicable unless you are doing multiple connections. But even then, one can reason that we can do Flush() or better yet make it synchronous. I use the Flush trick for multiple connection tests. However, as soon as the connections are connecting to separate servers (in a cluster) then Flush or a synchronous Subscribe does not guarantee ordering for a Subscribe on one and a Publish on another. Hopefully that makes sense.

Jason, I think more discussion of how connection flushing works is appropriate in the documentation, and we'll do that. Derek's right, though: nothing can guarantee the ordering of protocol messages between two different connections even if they are connected to the same server. The nc.Flush() happened to work in your case because of the specific timing, connecting to the same server, and who knows what else.  We will definitely enhance the documentation concerning the flushing behavior.


How to send a arg in the request like 'user' to ProductForm

My Product has a foreignkey school
"
class Product(AbstractProduct):
primary_school = models.ForeignKey('school.School', related_name='primary_school', null=True, blank=True, default=None, on_delete=models.SET_DEFAULT)
"
And the school is showed in dashboard:
"
class ProductForm(base_forms.ProductForm):
class Meta(base_forms.ProductForm.Meta):
fields = (
'title', 'upc', 'description',
'primary_school',
)
"
Now I want provide some optionvalue for school in dashboard, its based on 'user' in request.
So I overrided ProductForm init() like this:
"
# def init(self, product_class, data=None, parent=None, *args, **kwargs):
def init(self, product_class, user, data=None, parent=None, *args, **kwargs):
self.set_initial(product_class, parent, kwargs)
# super().init(data, args, kwargs)
super().init(product_class, data=None, parent=None, args, kwargs)
# logger.debug(user)
# self.user = user
# self.fields['primary_school'].queryset = self.user.
"
and init() need ProductCreateUpdateView(catalogue/views.py) send 'user' in, but I cant found where it should be put.

Hi there. We use Github only for managing bugs and feature requests, and not for support. We recommend that you ask for help on Stack Overflow using the django-oscar tag, or joining our slack workspace and asking a question there. Thanks.


Fix typos in tagging documentation

Thank you for the contribution, there are indeed quite a lot of typos in the documentation :sweat_smile:
However, I would leave terms like "Lanelet", "Area", "Linestring" etc. capitalized, as they refer here to specific concepts and objects in Lanelet2. Could you adapt this in your other pull requests as well?

I'd actually suggest to combine the PRs into one

First thing is putting the pull requests together is not possible when using the github.com web interface which is quite useful to read the markdown documentation and make edits. Of course theoretically it can be done with additional work but is it worth the effort just to have two commits less?
I was almost expecting the answer about the capitalization. This is quite inconsistent throughout the documents even before my change. Sometimes even in the same sentence. From what I learned about English only proper nouns should be capitalized and I would argue that here we are talking about common nouns which should not be capitalized. I could be wrong but that is my understanding. I am aware of the fact that native German speakers have some trouble with this kind of capitalization rules, including myself. What I find a good "workaround" for the cases when you specifically have to talk about classes in the code then use backticks and write them exactly like they are written/called in the source code. I also did this in my pull request.
Just to project into the possible future: If we can absolutely not come to a consensus about English grammar rules than I could imagine to recreate the pull request and leave out any of the capitalization changes and leave it up to you how to handle this topic.

That's alright, ultimately it is up to you. I am going to remove my capitalization changes when I find time. Just out of interest, can you point me to a native speaker example where this style is used? I'm really interested since so far the only place where I knew that two styles exist is in headlines/titles.

That's alright, ultimately it is up to you. I am going to remove my capitalization changes when I find time. Just out of interest, can you point me to a native speaker example where this style is used? I'm really interested since so far the only place where I knew that two styles exist is in headlines/titles.

Thanks, for example in the Kubernetes docs this style is used (see google style guide)


Inheritance support

Allow to use custom base class

base inheritance support has been added. but it is not possible to call ctor of base class.

#[py::class(base=asyncio.AbstractEventLoop)]
struct EventLoop {
    ...
}

I think we need super method, which should return reference to base object. so constructor could look like this:
#[py::method]
impl MyClass {
     #[new]
     fn __new__(cls: &PyType, ...) -> PyResult<Py<MyClass>> {
         let slf = cls.py().init(|token| {
             MyClass {
                 num: 10,
                 debug: False,
                 token: token
             }
         })
        slf.super().call_method("__init__", NoArgs)
     }
}

What about subclass support?

That's easy. It is just extra tp_flags. I am not sure about consequences.
Do you want to test?

I remember last time I tried to add that tp_flags it causes segfaults.

try to add Py_TPFLAGS_BASETYPE
Post trace from segfault. It could be parameter for "py::class"

main question right now how to call parent "new" method

@messense could review this ed8599cfd3959b8ed08d86cf6a0615565be73d62
opinion?

implemented


adds StackBlitz init config, changes badge

Hey! I found that your project cannot be imported in StackBlitz: it hangs on Compiling application & starting dev server stage. Same problem is also mentioned in the issue https://github.com/wlucha/angular-starter/issues/29.
Here I added .stackblitzrc file, as described in docs, and I also decided to change the badge image in the README.md to the official one.
You can test how that works here: https://stackblitz.com/fork/github/spanic/angular-starter/tree/stackblitz_init_config_fix

@spanic awesome, thanks!


Why should Jupyter magic commands be commented out in Markdown?

Jupyter magic commands (like %%time) currently appear commented out in Markdown. The problem is that the rendered version (say in HTML in a web browser) looks different from the notebook, which is surprising.
I can understand that it is useful to comment these magic commands in the Python (.py) version, but is it really necessary to comment them out in the Markdown output? Can't the Markdown output be less surprising?

I was using MacDown, which displays Markdown. As I am not an R user, and since I do not want to install R on my machine just for visualizing something that looks quite standard, this looked like a reasonable approach. :)
Maybe the problem comes from the fact that I was expecting R Markdown to be essentially the same as Markdown, with maybe some distinct meta-data in the header (a quick search didn't yield anything)? In a .md version of a notebook, I would expect the %%magic commands to be displayed just like in the Jupyter notebook.


add m.minimize() m.maximize() and hide m.objective and objective_max

easy access functions, avoid direct access to the internals...

added in 0.9.0


Support updating and pausing autostop without local sky

#1469  👈 (View in Graphite)
main

This stack of pull requests is managed by Graphite. Learn more about stacking.


import sitecustomize fails

From<EMAIL_ADDRESS>on 2011-09-26T07:17:29Z
What steps will reproduce the problem?
Start Spyder What is the expected output? What do you see instead? the IPython window shows the following error message:
'import sitecustomize' failed; use -v for traceback
------------------------------------------------------------
Traceback (most recent call last):
File "C:\Python27\lib\site-packages\spyderlib\widgets\externalshell\startup.py", line 227, in <module>
ipythonshell.IP.stdin_encoding = os.environ['SPYDER_ENCODING']
File "C:\Python27\lib\os.py", line 423, in getitem
return self.data[key.upper()]
KeyError: 'SPYDER_ENCODING' What version of the product are you using? On what operating system? Spyder 2.0.13 with python 2.7, on windows 7, 64 bit
Please provide any additional information below
. This is the second time I get this error message.  I can remediate by starting a new ipython interpreter, so it doesn't completely block me.
Original issue: http://code.google.com/p/spyderlib/issues/detail?id=771

From<EMAIL_ADDRESS>on 2011-10-01T09:07:51Z
I'm having the same problem with the same operating system.

From pierre.raybaut on 2011-10-02T02:11:49Z
Once v2.1.0beta3 is available as a Windows installer (tomorrow), you should try to upgrade to this new release to see if this bug has been fixed since then.
Is it happening with the standard Python interpreter?

From pierre.raybaut on 2011-10-02T05:39:32Z
Here is a way to debug this kind of problem:

Edit spyderlib/widgets/externalshell/pythonshell.py
Go to line #371: https://code.google.com/p/spyderlib/source/browse/spyderlib/widgets/externalshell/pythonshell.py?repo=v20#371 3. Change it to p_args = ['-u', '-v']

Restart Spyder and the console should print a lot of debug lines: among them, you'll prbably find the traceback associated to the error happening in sitecustomize.

From<EMAIL_ADDRESS>on 2011-10-03T19:39:57Z
Output of -v attached.
----------------
Attachment: spyder.txt

From ccordoba12 on 2011-10-08T07:04:28Z
Labels: Cat-Console

From<EMAIL_ADDRESS>on 2011-10-06T17:37:04Z
I did as you suggested and the output looks exactly the same...

From pierre.raybaut on 2011-10-06T07:11:18Z
I think that part of the output is missing (the beginning) because I don't see any traceback except the KeyError but that does not happen with the sitecustomize script.
To avoid the output to be truncated, you should try to increase Console's history depth in preferences (note that this setting won't be applied dynamically on existing console tabs: you have to close the interpreter tab and open another one).

From<EMAIL_ADDRESS>on 2011-10-10T07:51:58Z
I decided to set an environment variable in Windows 7 to see if it would fix the problem.  I made a variable named SPYDER_ENCODING and set it to UTF-8.  I no longer get the error.  Is there some problem that spyder has with windows 7's default encoding?  Does anybody have any ideas?

From pierre.raybaut on 2011-10-11T11:09:41Z
And are you still getting the warning message "'import sitecustomize' failed; use -v for traceback" ?

From<EMAIL_ADDRESS>on 2012-03-13T13:22:38Z
I still have this issue. I updated to version 2.1.8 and I also tried to set an environment variable SPYDER_ENCODING and set it to UTF-8.  It doesn't help.
Anything else I can try?

From<EMAIL_ADDRESS>on 2012-01-16T06:27:45Z
I had this problem in Windows 7 after upgrading to 2.17. Removed the .spyder folder and the problem was gone.

From<EMAIL_ADDRESS>on 2011-12-24T19:36:23Z
same issue.
Mine is windows XP.
Using NathanH...'s method, then it works.

From pierre.raybaut on 2012-03-18T06:02:17Z
Please try debugging as suggested in comments #3 and #5.

From<EMAIL_ADDRESS>on 2012-03-20T01:24:54Z
Pierre,
I always get the error that .spyder.ini cannot be opened with 'w' or that the filename is not correct.  However, I can open the file in that specific location, edit and save without any problem.  Here's an example:
Traceback (most recent call last):
File "C:\Python27\lib\site-packages\spyderlib\plugins\configdialog.py", line 164, in button_clicked
configpage.apply_changes()
File "C:\Python27\lib\site-packages\spyderlib\plugins\configdialog.py", line 71, in apply_changes
self.save_to_conf()
File "C:\Python27\lib\site-packages\spyderlib\plugins\configdialog.py", line 322, in save_to_conf
self.set_font(font, option)
File "C:\Python27\lib\site-packages\spyderlib\plugins_init_.py", line 222, in set_plugin_font
set_font(font, self.CONF_SECTION, option)
File "C:\Python27\lib\site-packages\spyderlib\config.py", line 461, in set_font
CONF.set(section, option+'/bold', int(font.bold()))
File "C:\Python27\lib\site-packages\spyderlib\userconfig.py", line 310, in set
self.__save()
File "C:\Python27\lib\site-packages\spyderlib\userconfig.py", line 154, in _save
conf_file = file(self.filename(),'w')
IOError: [Errno 22] invalid mode ('w') or filename: 'C:\Users\RDC\.spyder2\.spyder.ini'
Traceback (most recent call last):
File "C:\Python27\lib\site-packages\spyderlib\plugins\configdialog.py", line 155, in accept
configpage.apply_changes()
File "C:\Python27\lib\site-packages\spyderlib\plugins\configdialog.py", line 71, in apply_changes
self.save_to_conf()
File "C:\Python27\lib\site-packages\spyderlib\plugins\configdialog.py", line 309, in save_to_conf
self.set_option(option, checkbox.isChecked())
File "C:\Python27\lib\site-packages\spyderlib\plugins_init.py", line 210, in set_option
CONF.set(self.CONF_SECTION, str(option), value)
File "C:\Python27\lib\site-packages\spyderlib\userconfig.py", line 310, in set
self.__save()
File "C:\Python27\lib\site-packages\spyderlib\userconfig.py", line 154, in _save
conf_file = file(self.filename(),'w')
IOError: [Errno 22] invalid mode ('w') or filename: 'C:\Users\RDC\.spyder2\.spyder.ini'
Traceback (most recent call last):
File "C:\Python27\lib\site-packages\spyderlib\plugins\configdialog.py", line 155, in accept
configpage.apply_changes()
File "C:\Python27\lib\site-packages\spyderlib\plugins\configdialog.py", line 71, in apply_changes
self.save_to_conf()
File "C:\Python27\lib\site-packages\spyderlib\plugins\configdialog.py", line 309, in save_to_conf
self.set_option(option, checkbox.isChecked())
File "C:\Python27\lib\site-packages\spyderlib\plugins_init.py", line 210, in set_option
CONF.set(self.CONF_SECTION, str(option), value)
File "C:\Python27\lib\site-packages\spyderlib\userconfig.py", line 310, in set
self.__save()
File "C:\Python27\lib\site-packages\spyderlib\userconfig.py", line 154, in __save
conf_file = file(self.filename(),'w')
IOError: [Errno 22] invalid mode ('w') or filename: 'C:\Users\RDC\.spyder2\.spyder.ini'
I now tried to avoid saving, by adapting the userconfig.py as follows:
def __save(self):
"""
Save config into the associated .ini file
"""
#this part of the script causes problems so let's try to save nothing at all
#conf_file = file(self.filename(),'w')
#self.write(conf_file)
#conf_file.close()
pass
And now I can open spyder again after it was closed (that's a start) and the first attempts show no failed sitecustomize import.  Of course, I cannot save my preferences now, or does that happen in a different script?
roel

From<EMAIL_ADDRESS>on 2012-07-03T18:12:29Z
I'm having the exact same problem. Oddly enough, it only happens sometimes (sometimes I get an IPython shell open without a problem, other times it throws this same error). I've attached debug details.
Attachment: debug.txt

From ccordoba12 on 2012-07-06T09:49:04Z
issue #1067 has been merged into this issue.

From<EMAIL_ADDRESS>on 2012-07-07T12:08:09Z
Well I use linux, and there is no antivirus ;)

From ccordoba12 on 2012-07-06T14:41:43Z
shoobs, I think you are having the same problem as the one reported in comment #14, i.e. .spyder.ini is not writable. We have seen this a couple of times before and it seems to be related to an antivirus problem.
Could you try to deactivate your antivirus and try again?

From ccordoba12 on 2012-07-07T15:33:52Z
But are you seeing the exact same error as the one reported in comments #14 and #15? I say it because it seems this problem is caused by different reasons.
Please follow the procedure described in comment #3 to let us know.

From pierre.raybaut on 2012-07-28T06:46:44Z
Status: Done

From<EMAIL_ADDRESS>on 2012-07-08T17:56:30Z
ccordoba12, I added an exception to my antivirus for .spyder.ini, and I have yet to see the error again. Thanks!

From<EMAIL_ADDRESS>on 2013-02-11T01:18:20Z
#22 steps 1-2 worked for me on Win 7 (64b).
Thanks!

From pierre.raybaut on 2013-03-13T10:14:56Z
issue #1310 has been merged into this issue.

From<EMAIL_ADDRESS>on 2012-09-06T11:28:08Z
I'm on Windows XP and I'm also getting this
" 'import sitecustomize' failed; use -v for traceback "
from Spyder 2.1.9
This seems to have fixed it.

Goto C:\Python27\Lib\site-packages\spyderlib\widgets\externalshell
(or the equivalent)
Delete sitecustomize.pyc (make sure sitecustomize.py is still there, don't delete that).
This alone may be sufficient. But the 3rd step I took.
Assuming you installed with Python(x,y), The Start Menu under Programs has Python(x,y) > Optimize Python Modules > select the site-packages directory. This creates a new sitecustomize.pyo and pyc from the sitecustomize.py
That seems to have made the problem go away.

From<EMAIL_ADDRESS>on 2013-03-13T11:30:32Z
Deleting sitecustomize.pyc and sitecustomize.pyo didn't work for me but setting SPYDER_ENCODING variable:
set SPYDER_ENCODING=utf-8

From<EMAIL_ADDRESS>on 2013-03-13T15:01:03Z
I have the" 'import sitecustomize' failed; use -v for traceback" issue that prevent me to use ipython from spyder.
Using latest spyder and ipython from respective repo.
The problem looks related to sys.argv not being available anymore for ipython when it is "called" from spyder:
Traceback (most recent call last):
File "/opt/local/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site.py", line 510, in execsitecustomize
import sitecustomize
File "/Users/dt/lib/python/spyderlib/widgets/externalshell/sitecustomize.py", line 298, in <module>
from IPython.core.debugger import Pdb as ipyPdb
File "/Users/dt/lib/python/IPython/init.py", line 43, in <module>
from .config.loader import Config
File "/Users/dt/lib/python/IPython/config/init.py", line 16, in <module>
from .application import *
File "/Users/dt/lib/python/IPython/config/application.py", line 67, in <module>
""".strip().format(app=os.path.basename(sys.argv[0]))

From<EMAIL_ADDRESS>on 2013-03-15T13:02:10Z
ha ha, that someone that's passing this faulty 'wx4agg' value is my .spyder.ini
I deleted the file and there is no single issue now. Both errors gone.
This file was first created with some previous version.
Did I somehow set 'wx4agg' value, I have no idea

From<EMAIL_ADDRESS>on 2013-03-15T12:39:51Z
Pierre,
here is log: http://pastebin.com/raw.php?i=wMrrwH2A In the first traceback it seems like someone is passing this "wx4agg" argument (I don't have MATPLOTLIB_BACKEND environment variable defined)
In second traceback is this issue about SPYDER_ENCODING variable
So first traceback is responsible for raising 'import sitecustomize' failed; use -v for traceback and second traceback is responsible for failing to bring IPython console

From pierre.raybaut on 2013-03-15T03:29:59Z
@-klonuo: this means that sitecustomize.py is failing elsewhere.
Please follow the instructions of comment #3 with the new link: https://code.google.com/p/spyderlib/source/browse/spyderlib/widgets/externalshell/pythonshell.py#391

From ccordoba12 on 2013-04-06T23:15:04Z
This seems an error with your IPython installation, given this line in your traceback:
File "/Users/dtremoui/lib/python/IPython/config/application.py", line 67, in <module>
""".strip().format(app=os.path.basename(sys.argv[0]))
AttributeError: 'module' object has no attribute 'argv'
what IPython version are you using?

From<EMAIL_ADDRESS>on 2013-04-06T22:45:15Z
Still not able to launch a ipython from spyder (lastest spyder release candidate):
# /Users/dtremoui/lib/python/IPython/utils/io.pyc matches /Users/dtremoui/lib/python/IPython/utils/io.py
import IPython.utils.io # precompiled from /Users/dtremoui/lib/python/IPython/utils/io.pyc
# /Users/dtremoui/lib/python/IPython/utils/traitlets.pyc matches /Users/dtremoui/lib/python/IPython/utils/traitlets.py
import IPython.utils.traitlets # precompiled from /Users/dtremoui/lib/python/IPython/utils/traitlets.pyc
Traceback (most recent call last):
File "/opt/local/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site.py", line 510, in execsitecustomize
import sitecustomize
File "/Users/dtremoui/Documents/devel_logiciel/external_used/spyderlib/spyderlib/widgets/externalshell/sitecustomize.py", line 298, in <module>
from IPython.core.debugger import Pdb as ipyPdb
File "/Users/dtremoui/lib/python/IPython/init.py", line 43, in <module>
from .config.loader import Config
File "/Users/dtremoui/lib/python/IPython/config/init.py", line 16, in <module>
from .application import *
File "/Users/dtremoui/lib/python/IPython/config/application.py", line 67, in <module>
""".strip().format(app=os.path.basename(sys.argv[0]))
AttributeError: 'module' object has no attribute 'argv'
Python 2.7.3 (default, Oct 23 2012, 10:31:53)
[GCC 4.2.1 Compatible Apple Clang 2.1 (tags/Apple/clang-163.7.1)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
import IPython # directory /Users/dtremoui/lib/python/IPython
# /Users/dtremoui/lib/python/IPython/init.pyc matches /Users/dtremoui/lib/python/IPython/init.py
import IPython # precompiled from /Users/dtremoui/lib/python/IPython/init.pyc
import IPython.config # directory /Users/dtremoui/lib/python/IPython/config

From<EMAIL_ADDRESS>on 2013-04-06T23:48:22Z
I'm on Mac Os X 10.7.5 . I've tested both with ipython 0.13.2 and latest head: same traceback.
(Python 2.7.3 64bits, Qt 4.8.4, PyQt4 (API v2) 4.10 on Darwin)
Any recommendation how I could dig in this issue ?

From ccordoba12 on 2013-04-08T14:46:11Z
This is my advice:

Try to run IPython qtconsole to see if it's working correctly. Just fire up Terminal.app and write

ipython qtconsole

Open our sitecustomize file

/Users/dtremoui/Documents/devel_logiciel/external_used/spyderlib/spyderlib/widgets/externalshell/sitecustomize.py
and comment all lines that are giving you trouble, like line 298, to see if you can make IPython to work. I think you won't be able to, but it could help you to narrow down the source of the error.

From<EMAIL_ADDRESS>on 2013-04-08T20:45:37Z
IPython console does start and run properly after commenting line 298 and 299
./spyderlib/spyderlib/widgets/externalshell/sitecustomize.py
That solve all the problem for me (but I don't know what happen for pdb as I almost never use it).
I'm still not able to understand why the hell sys.argv is not available when "running" IPython/config/application.py
This part of the coede is called three times while running spyder and asking for the qtconsole,
but it failled only once (the one I reported, see #30)...

From<EMAIL_ADDRESS>on 2013-04-08T20:23:24Z

For sure it works. I use ipython qtconsole and notebooks almost every day.
Thanks for this clue, I'll report here as soon as I could narrow something down...

From ccordoba12 on 2013-04-23T14:22:38Z
I have no idea where those "argv" errors are coming from. But I could put the lines you refer to in a try/except block so that IPython can start without problems for you.

From<EMAIL_ADDRESS>on 2013-04-24T00:49:03Z
Well, thanks for that proposal. I don't thing it really make sense if I'm the only person who suffer from this issue.
It's not a big deal to systematically patch a new version for this issue locally on my computer.
Furthermore, that will regularly remind me to spend some time to solve this one ;-)
So lets wait and see if anybody else encounter the same issue to spend more time on it.
Thanks you again for your help !

From<EMAIL_ADDRESS>on 2013-05-18T04:09:17Z
I also had the same issue as david.trem ('module' object has no attribute 'argv').
My environment is somewhat different (Python 2.7.2 32bit on Windows), but I'm also using the latest stable versions of both Spyder (2.2.0) and IPython (0.13.2).
It seems like the sys module does not contain the argv object.
This seems to happen when you create a python interpreter from the C API (e.g. when embedding) and don't initialize it with any arguments, so it's supposed to be expected behavior, but maybe modules - including IPython, it seems - are not aware of it and try to access the argv attribute anyway.
The way I fixed it is rather silly:

I opened spyderlib/widgets/externalshell/sitecustomize.py
Looked for the line where IPython is imported from. In my case it was line 292 ('from IPython.core.debugger import Pdb as ipyPdb')
Added a dummy access to sys.argv before that line:

sys.argv  # Dummy access, reads sys.argv, but do nothing with it. For whatever reason this makes the sys.argv attribute available for IPython
from IPython.core.debugger import Pdb as ipyPdb
pdb.Pdb = ipyPdb

Not a very elegant solution, but it easily fixes this issue with no side effects.

From ccordoba12 on 2013-07-01T20:04:03Z
Thanks a lot for the patch! I encountered the problem while testing with Python 3 and it effectively solved the problem.

From<EMAIL_ADDRESS>on 2013-05-18T05:03:26Z
Ok, my previous solution doesn't seem to fix this error completely it only gets the throw-site moved to a context where it's caught and handled properly, but site customization is not completed properly, so IPython<->Spyder integration is missing. I've solved this by properly creating an empty argv object inside the 'sys' module:

if not hasattr(sys, 'argv'):

sys.argv = ['']

from IPython.core.debugger import Pdb as ipyPdb
pdb.Pdb = ipyPdb

I've also attached a proper patch file.
Attachment: site_customize_fix.diff

From<EMAIL_ADDRESS>on 2013-07-06T11:33:46Z
This was annoying me too. My solution was to install matplotlib, python-dateutil and pyparsing.
Reason: there is a matplotlib import above the last suggested fix, with a comment that the IPython import will fail if matplotlib isn't imported first. Without actually looking into the detail, I assume that matplotlib import is setting sys.argv somewhere so that ipdb won't complain.


(PUP-9994) Make external argument optional

rspec-puppet creates an instance of Puppet::Context::TrustedInformation
instead of using the remote class method[1]. To reduce compatibility issues
with rspec-puppet and any other users of trusted information, make the
external argument optional.
Also update docs as the setting was changed from terminus to command.
[1] https://github.com/rodjek/rspec-puppet/blob/a4749c804c820977c2f507133d01f56006b22f47/lib/rspec-puppet/support.rb#L407

I dislike that TrustedInformation executes the command rather than having the caller execute the command and passing the external data to the local or remote method. Let me look at that.


Support outset-like borders

Menuconfig has a "outset" on the borders, using two colors to make a 3D impression.
Having this option in the theme would be nice.

MenuConfig actually has 2 kinds of borders: outset around the dialog, and inset around internal views.
Cursive currently doesn't have internal views - maybe Panels of some kind?
The theme could then activate a kind of border.

Done in f7a3d821d1110be931600f8be8eef81fde60d8db.


The contemporary style dots could separate after a subsection

Is your feature request related to a problem? Please describe.
I have split my work section into three things, but with the contemporary style means I get the dotted years joined up, which doesn't really make sense in this context.
\section[\faBriefcase]{Experience}

\subsection{Full-Time}

\cventry{2024--Present}{}{}{}{}{}

\subsection{Internships}

\cventry{2024--Present}{}{}{}{}{}

\subsection{Part-Time}

\cventry{2024--Present}{}{}{}{}{}

Describe the solution you'd like
I would like the \subsection to break to start a new dotted section
Describe alternatives you've considered
I could insert an empty \section{} with some \vspace to move it up, but this is a bit hacky.

Hi @paddyroddy,
I am not sure if I understand it correctly:
Do you want to have separate timelines per \subsection? This would help me think about an solution. Thanks in advance.

Hi @paddyroddy, I am not sure if I understand it correctly: Do you want to have separate timelines per \subsection? This would help me think about an solution. Thanks in advance.

Yep, exactly that @LLdaniel! Not sure how common my use case it, but for people who make career changes or have internships or similar, it doesn't necessarily make sense to have the years joined up - even if they follow the same chronological order. For now I have done something like this, which does the trick
\section[\faBriefcase]{Experience}

\subsection{Full-Time}

\cventry{}{}{}{}{}{}

\section{}\vspace*{-10mm}
\subsection{Internships}

\cventry{}{}{}{}{}{}

ah, okay, I see now. Thanks for clarification and your example. I will classify that as an possible enhancement :+1:


Add layer property to LAL script

[ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #.
[x] Update the CHANGES log.

The deadlink check always fail and seems not cause by me.

Don't worry about that. You just need to focus your changed parts.

Please check why log e2e are all failure.

Please check why log e2e are all failure.

I get it.

Maybe because of the layer check I have set in this PR.
try {
            layer = Layer.nameOf(builder.getLayer());
        } catch (UnexpectedException e) {
            log.warn("layer not found, will skip this process.");
            return;
        }

I think that I can set GENERALas default layer.

I think in today's e2e log cases don't report layer as it was not required. It is better if we could add default=general layer to the log receiver before it is forwarded into LAL engine to keep forward compatibility.

LogSinkListener.Factory's constructor 's LogAnalyzerModuleConfig param maybe also need to remove.
https://github.com/yswdqz/skywalking/blob/lalchange/oap-server/analyzer/log-analyzer/src/main/java/org/apache/skywalking/oap/log/analyzer/provider/log/listener/RecordSinkListener.java#L151
https://github.com/yswdqz/skywalking/blob/lalchange/oap-server/analyzer/log-analyzer/src/main/java/org/apache/skywalking/oap/log/analyzer/provider/log/listener/TrafficSinkListener.java#L104


Support face- and node-centered data as zone-centered on augmented mesh

Can we add support for face- and edge-centered data by creating augmented meshes in which the zones of the augmented mesh are the faces (or edges) (all of them) of the original mesh?

If we did, things like LabelPlot would just work without much additional coding.
Could we easily make edge-pick or face-pick work just by doing the picks on the augmented mesh?
Could we do contour plots of face-centered quantities over their faces?
How might things like OnionPeel or Threshold work?
How about things like recentering of a variable from nodes to edge or faces?

@cyrush says this is similar to how same issue currently handled in blueprint.

@brugger1 suggests we can dimensionally expand the mesh down in the database stuff (either a specific plugin or, better, transform manager). When a face-centered (or edge-centered) variable is encountered, what winds up happening is that the variable is defined in avtDbMd as a zone-centered variable on a slightly different named mesh (maybe which is also hidden from the GUI). Then, when that variable (and its mesh) are requested from the database stuff, the original mesh is read and dimensionally expanded to form the augmented mesh.


Fix negated globs passed to CLI are no longer worked.

Description
Migrate method to get all mathing globs files to use internally PathMatcher and FileVisitor instead of using klob dependency.
Fixes #999
Checklist

[x] tests are added
[x] CHANGELOG.md is updated

@thecoden could you take a look on this PR and check it?

@thecoden could you take a look on this PR and check it?

@thecoden could you take a look on this PR and check it?

I've taken a look through the code and so far it looks good to me. I'm going to try to find some time to check it out and run it as well. Thank you for your attention to this issue.

@thecoden could you take a look on this PR and check it?

I've taken a look through the code and so far it looks good to me. I'm going to try to find some time to check it out and run it as well. Thank you for your attention to this issue.

Hi @Tapchicoma,
I've pulled and done some comparison with our branch and cleaned up our branch a bit to make the differences easier to see. I can submit a pull request if that makes it easier for you to see and pull what you want from it of course.
See the comparison here
The main differences in our solution are:

Corrected the expandTilde() method to work for negated patterns
Separated the glob support into a FileMatcher class that supports both regex and glob patterns. This greatly simplified the fileSequence() method as well
Maintained the order of the patterns so you can include, exclude, and include again based on different patterns. Not something we would use likely, but left the adaptability open for others.
We used a triple in the FileMatcher class that I'm not proud of and would prefer abstract more clearly. I apologize for that.

Otherwise yours appears to function per your spec as well from check out and I hope we've been helpful. On future improvements, we will be more efficient as it took quite a bit to get the project set up and testing on our end.
Oh, and Happy New Year!

Hi @Tapchicoma,
I've pulled and done some comparison with our branch and cleaned up our branch a bit to make the differences easier to see. I can submit a pull request if that makes it easier for you to see and pull what you want from it of course.
See the comparison here
The main differences in our solution are:

Corrected the expandTilde() method to work for negated patterns
Separated the glob support into a FileMatcher class that supports both regex and glob patterns. This greatly simplified the fileSequence() method as well
Maintained the order of the patterns so you can include, exclude, and include again based on different patterns. Not something we would use likely, but left the adaptability open for others.
We used a triple in the FileMatcher class that I'm not proud of and would prefer abstract more clearly. I apologize for that.

Otherwise yours appears to function per your spec as well from check out and I hope we've been helpful. On future improvements, we will be more efficient as it took quite a bit to get the project set up and testing on our end.
Oh, and Happy New Year!

@thecoden thank you for your review :clap:

Corrected the expandTilde() method to work for negated patterns

Yeah, this is the thing I want to add to this PR before merging it.

Maintained the order of the patterns so you can include, exclude, and include again based on different patterns. Not something we would use likely, but left the adaptability open for others.

Interesting, now sure that this scenario should be supported :thinking: But on the second though may happen :thinking:
I will take another look on your implementation :+1:

@thecoden thank you for your review :clap:

Corrected the expandTilde() method to work for negated patterns

Yeah, this is the thing I want to add to this PR before merging it.

Maintained the order of the patterns so you can include, exclude, and include again based on different patterns. Not something we would use likely, but left the adaptability open for others.

Interesting, now sure that this scenario should be supported :thinking: But on the second though may happen :thinking:
I will take another look on your implementation :+1:

Thank you @Tapchicoma, I'm sorry for the delay. For some reason I'm not getting my github alerts for any of this conversation or repo so I missed it.
One more difference I just caught as well, is that we added support for the glob: and regex: prefixes and if detected, we do not prefix with glob: allowing the use of the regex matching. You can see this in the internal FileMatcher class in the compare, line 117.
Something we also should have done is converted the expandTilde method to use a compiled regex instead of creating it on every call. I can add a commit for that if you like after.

One more difference I just caught as well, is that we added support for the glob: and regex: prefixes and if detected, we do not prefix with glob: allowing the use of the regex matching. You can see this in the internal FileMatcher class in the compare, line 117.

Probably I will not add regex: support, don't see the point of supporting both :thinking:

Something we also should have done is converted the expandTilde method to use a compiled regex instead of creating it on every call. I can add a commit for that if you like after.

That is a nice improvement - will add it as well :+1:

One more difference I just caught as well, is that we added support for the glob: and regex: prefixes and if detected, we do not prefix with glob: allowing the use of the regex matching. You can see this in the internal FileMatcher class in the compare, line 117.

Probably I will not add regex: support, don't see the point of supporting both thinking

With a developer tool, and it being directly supported in the PathMatcher, I figured leave regex because it is essentially more complete / flexible than glob, but the decision is yours sir and can always be enabled later easily.

Something we also should have done is converted the expandTilde method to use a compiled regex instead of creating it on every call. I can add a commit for that if you like after.

That is a nice improvement - will add it as well +1

:+1: Thank you and I agree. Little things like compiled regexes do make a big performance difference over time. I'm not into pre-optimization per se, but really creating the regex once should be default practice anyway since it is immutable anyway.

@Tapchicoma  #1084 looks related. It would be great if you can resolve the conflicts or let me know if I can be of any help. Thanks.

@girish3 yes, related.
This PR is not yet ready to be merged and needs some more improvements that was pointed by @thecoden.

This is very problematic for large codebases. Our pre-commit hook attempts to pass an explicit list of files to ktlint. Unfortunately, ktlint now walks over our entire codebase to filter those files in, and so our pre-commit hook now takes about 40 seconds rather than completing in under 1 second.
Is there some way we can pass an explicit list of files and bypass this directory crawl?

Same – we used to pass changed files to ktlint in 0.40.0 to get out results in a snap, and have to wait 15-20 seconds with 0.41.0. It seems to me that the addressing negated blobs by doing a full crawl doesn't make sense in the general case. Also, I don't think this implementation respects the order of the globs (e.g. a/** !a/b/** a/b/c/**), which is likely to cause confusion. Why not processing each at a time, adding or removing files from the selected set as you process each additional glob?

hmm..this was added after this PR to handle the case of passing in a list of files w/o any filetree walking:
https://github.com/pinterest/ktlint/blob/master/ktlint/src/main/kotlin/com/pinterest/ktlint/internal/FileUtils.kt#L42


[Survey]: Please take this survey.

This anonymous survey is to decide the future direction of RPG Manager.
It closes end of day 2023-05-26.
https://docs.google.com/forms/d/e/1FAIpQLSduhZ5WK5-jZNy8u4hYAK-442SktaRdoi15JWwic50m8A5wCg/viewform?fbzx=-1124856630504213966

Tried to answer, but it seems to be closed already so I was late.
My bad, I didn't notice the date, but this issue should probably be closed...

Ah yes, thank you for the reminder. :)


add warning in containerCreate response

- What I did
I think in the  code, there is a return missing warnings.
This PR fixed that.
- How I did it
- How to verify it
- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)
Signed-off-by: allencloud<EMAIL_ADDRESS>

LGTM!

LGTM


Update retail-sdk-packaging.md

:x: Organization membership check failed
Members of the MicrosoftDocs organization should use the private repo. Please move your changes to https://github.com/MicrosoftDocs/Dynamics-365-Operations, and close this pull request.


mupx deployment : npm cannot find module

Running Meteor <IP_ADDRESS> and node version 0.10.46 and went to mupx deploy and have gotten this error
-----------------------------------STDERR-----------------------------------
ckwards-incompatible changes made to `npm run-script` and
npm WARN deprecated semver behavior.
npm WARN package.json<EMAIL_ADDRESS>No description
npm WARN package.json<EMAIL_ADDRESS>No repository field.
npm WARN package.json<EMAIL_ADDRESS>No README data
npm WARN cannot run in wd<EMAIL_ADDRESS>node npm-rebuild.js (wd=/bundle/bundle/programs/server)
=> Starting meteor app on port:80

/bundle/bundle/programs/server/node_modules/fibers/future.js:280
						throw(ex);
						      ^
Error: Cannot find module 'paypal-rest-sdk'
    at Function.Module._resolveFilename (module.js:338:15)
    at Function.Module._load (module.js:280:25)
    at Module.require (module.js:364:17)
    at require (module.js:380:17)
    at Object.Npm.require (/bundle/bundle/programs/server/boot.js:171:18)
    at Package (packages/19degrees_paypal-extended-secured-euf/paypal.js:131:1)
    at /bundle/bundle/programs/server/boot.js:304:5

=> Redeploying previous version of the app

-----------------------------------STDOUT-----------------------------------

To see more logs type 'mup logs --tail=50'

----------------------------------------------------------------------------

My app builds fine and doesn't complain about this missing module. Anyone have any ideas?

Found the issue had to add it as an npm dependancy in the package


Refactor core to converge Qualification and Profiling Tools implementation

Describe the bug
Currently, both Qualification and Profiling tools have different data structure and different reporting output.
This issue is to track the refactor process to make both implementation common.
This is an important step toward adding heuristics as a postProcess phase to analysing the eventlogs
There are many benefits of doing so:

We won't need to run both tools to feed the estimation_model. The input to the estimation_model should be common between the two tools.
Better code maintainability. Fixing or adding a feature/improvement will be done once instead of twice.
Code reusability

### Tasks
- [ ] https://github.com/NVIDIA/spark-rapids-tools/pull/971
- [ ] Use common AppInfo between Q/P Tools
- [ ] Use common code to Find Problematic SQL between Q/P tools
- [ ] Use common logic to process SqlPlans between Q/P Tools
- [ ] Use common logic to process tasks between Q/P Tools
- [ ] Use common code to extract clusterInfo between Q/P Tools

This is great. This refactoring was much needed to improve the maintainence.


Split macOS and Ubuntu CIs for readability

Since the unix job did not mostly share steps. Splitting those would result in better readability. I also renamed gcc-10 job to coroutines because GCC 11 is installed on Ubuntu 22.04 by default and there's no need to use GCC 10 specifically.

@ken-matsui Please resolve the confilicts, thanks.

@ken-matsui Please resolve the confilicts, thanks.

@an-tao Fixed.


Added --include and --exclude cli options

These 2 options allow you to pass in regular expressions that determine whether files/directories are included or excluded in the recursive search.
This should address #270. I put the change log entry for this under 18.6b0 since I don't think it has been released yet - but let me know if this was incorrect! :sparkles:

Also, I genuinely do not know how I would check the types of exclude and include here https://github.com/ambv/black/pull/281/files#diff-a75051ebf8e3452bf3d590c186944252R2791 since I am passing in compiled regular expressions which have a type of _sre.SRE_Pattern, but apparently AttributeError: module '_sre' has no attribute 'SRE_Pattern' :sweat_smile:

Try typing.Pattern[str].

Pull Request Test Coverage Report for Build 430

11 of 18 (61.11%)  changed or added relevant lines in 1 file are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-0.2%) to 95.805%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

black.py
11
18
61.11%

Files with Coverage Reduction
New Missed Lines
%

black.py
1
94.76%

Totals

Change from base Build 429:
-0.2%

Covered Lines:
2238

Relevant Lines:
2336

💛  - Coveralls

@JelleZijlstra Ah! Thank you a bunch.

@ambv Added some logic to allow for prepended directories in the filter, and confirmed it works well with both * and .. I'm building up the path to search from using the children, rather than the path, as it's a little easier when the path itself is something like ..

Makes sense to just mention: "use forward-slashes on Windows, too."

Awesome! ✨ 🍰 ✨


Let the JSON decoder deal with base64 fields.

The Travis build for OS X needed a retry, but it's all green now.

Did existing tests provide a regression check for you here?

Some of them, but not all... :disappointed:


qmapshack: 1.10.0 -> 1.11.1

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools.
This update was made based on information from https://repology.org/metapackage/qmapshack/versions.
These checks were done:

built on NixOS
ran ‘/nix/store/wddp26cbiivr7sfvh7r36bqj8wlvr5gx-qmapshack-1.11.1/bin/qmt_rgb2pct -h’ got 0 exit code
ran ‘/nix/store/wddp26cbiivr7sfvh7r36bqj8wlvr5gx-qmapshack-1.11.1/bin/qmt_rgb2pct --help’ got 0 exit code
ran ‘/nix/store/wddp26cbiivr7sfvh7r36bqj8wlvr5gx-qmapshack-1.11.1/bin/qmt_map2jnx -h’ got 0 exit code
ran ‘/nix/store/wddp26cbiivr7sfvh7r36bqj8wlvr5gx-qmapshack-1.11.1/bin/qmt_map2jnx --help’ got 0 exit code
ran ‘/nix/store/wddp26cbiivr7sfvh7r36bqj8wlvr5gx-qmapshack-1.11.1/bin/qmt_map2jnx help’ got 0 exit code
found 1.11.1 with grep in /nix/store/wddp26cbiivr7sfvh7r36bqj8wlvr5gx-qmapshack-1.11.1
directory tree listing: https://gist.github.com/1823f811dd1c8c3b648af3fc29d40605

cc @dotlambda for review

No attempt on x86_64-darwin (full log)
The following builds were skipped because they don't evaluate on x86_64-darwin: qmapshack
Partial log (click to expand)

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

Success on x86_64-linux (full log)
Attempted: qmapshack
Partial log (click to expand)
shrinking /nix/store/sqxk374yvsk762g44jbhsjx3n5vqrk8x-qmapshack-1.11.1/bin/qmapshack
shrinking /nix/store/sqxk374yvsk762g44jbhsjx3n5vqrk8x-qmapshack-1.11.1/bin/qmaptool
shrinking /nix/store/sqxk374yvsk762g44jbhsjx3n5vqrk8x-qmapshack-1.11.1/bin/qmt_rgb2pct
shrinking /nix/store/sqxk374yvsk762g44jbhsjx3n5vqrk8x-qmapshack-1.11.1/bin/qmt_map2jnx
gzipping man pages under /nix/store/sqxk374yvsk762g44jbhsjx3n5vqrk8x-qmapshack-1.11.1/share/man/
strip is /nix/store/j75dgadrff2d1fyc4fczmcgqkid2imdx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/sqxk374yvsk762g44jbhsjx3n5vqrk8x-qmapshack-1.11.1/bin
patching script interpreter paths in /nix/store/sqxk374yvsk762g44jbhsjx3n5vqrk8x-qmapshack-1.11.1
checking for references to /build in /nix/store/sqxk374yvsk762g44jbhsjx3n5vqrk8x-qmapshack-1.11.1...
postPatchMkspecs

Failure on aarch64-linux (full log)
Attempted: qmapshack
Partial log (click to expand)
                  int16 *pspecial);
                  ^~~~~
                  int
/build/hdf-4.2.13/hdf/src/hfile.h:274:7: error: unknown type name 'uint16'
       uint16      maxref;       /* highest ref in this file */
       ^~~~~~
building of '/nix/store/i5jnsjnjf02gn92g3k89z9khb58wg2s4-hdf-4.2.13.drv' timed out after 3600 seconds
cannot build derivation '/nix/store/w0d728049lfwcb21wvni4i10r9yyr9fd-gdal-2.2.4.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/h5dmm7lzkj0jk6cnbv60rhrl0fqf00si-qmapshack-1.11.1.drv': 1 dependencies couldn't be built
error: build of '/nix/store/h5dmm7lzkj0jk6cnbv60rhrl0fqf00si-qmapshack-1.11.1.drv' failed


CASMUSER-2624: Enable kdump for UAN

This PR enables kdump and NMD functionality on HPE DL hardware UAN nodes which run the qlogic 25Gb cards.
This PR relies on a related PR in the Shasta OS cos-config repo which modifies the actual kdump role to use the 'kdump_target_uan' variable set in this PR.  However, this PR is harmless should that Shasta OS cos-config PR not be present.  The variable set in our site.yml file will simply be ignored.
In order for this change to have any effect, the uan repo will have to be built after the cos-config change is built so uan can pick up the change in the cos content base docker image containing the kdump role.

This PR is out-of-date and will be taken care of by a new PR


Question for contributions about code improvements

Dear Grav Team,
I'm interested to contribute to the code... I recently introduced phpstan initial support, but before sending more patches, I want to know your opinions about typings issues. I'm aware that you're working fully to release 1.6 and I don't want to make your work harder or introdce bc-breaks. So here's some thoughts, feel free to comment.
(I'm aware and agree that "strict_types=1" could break things, and I feel it's good to not work with strict_types for now.)
1. Method arguments
I would like to replace phpdoc style typings in methods arguments. For example:
/**
 * @param string|null $param1
 */
function test($param1=null) {}

// by
function test(?string $param1=null) {}

To preserve the idea of 'single source of truth', I'll remove what's obsolete from phpdoc (excluding array, see point 3).
2 Introduce return types
I'm aware that covariance problems can break things, but for simple cases (scalar or arrays) I would like to add return type
function sayHello(): string { return 'hello' }

3. Basic typing of arrays
Where applicable, I would like to replace @param array $languages by @param string[] $languages in phpdoc (the function argument will still be types 'array'). VSCode or phpstorm support this, but some people does not like so much. It makes static analyzers shines.
Hope it makes senses. Let me know you thoughts

I already tried the same, but introducing strong typing in arguments and return types break things unless you're using PHP 7.2 and in only if the classes aren't extended either by loosening the argument type or tightening the return type.
Unfortunately, as we do support PHP 7.1, I ended up breaking a lot of code by making the type changes, so I just ended up doing it with some newer code which isn't likely to be used anywhere.
Regarding the last point (3), yes, that is what I'm already doing with new code.

What do we need the most is to fix the obvious mistakes in the docblocks, improve generated documentation and add unit tests to make sure that the methods work as expected.
In fact, right now the documentation (and testing) is the only thing really blocking the 1.6 release, so in short term, we should just look for improving generated documentation and fixing the obvious bugs.

I fixed the last couple of level 1 issues (showed up for me in PHP 7.3).  I think we should really hold off on the strong typing until Grav 2.0 when we can require PHP 7.2 or greater.

I fixed most of the level 2 issues, there are some which need a deeper look.

You're in lion mode ;)
was not aware of issues with scalar and arrays (https://3v4l.org/WPdCK . Viva PHP 7.2 ! ;) , you're fully right.
Kudos for level 2, level 3 will need fixes in docblocks to get full-power from static analysis. It's generally where we find the little tricky bugs we like so much. I'll have a look when I have time.
Can I suggest to put final on all new 1.6 classes (Flex...) that have no reason to be extended (opening later if needed) Will be safer for next refactorings.
Thanks for all your work !

Grav\Framework has been fixed up to level 5 now. :) Though I just fixed the issues found by the analysis and the ones I picked up while looking into the code, so there are likely bad types here and there.
Rest of the code is at level 2, they are trickier as there's a lot of older code.
Most of the Flex classes are meant to be extended as you can add custom features and behaviour for your objects and collections.

Nice ! I wanted to help but you're too fast ;) I'll find something out, haha.
Idea: add a little badge to the readme

![PHPStan](https://img.shields.io/badge/style-level%205-brightgreen.svg?style=flat-square&label=phpstan)

I like badges ;)

It's already there, but without level. And we're really at level 2. :)
I stopped working on this, I'm now going through interfaces and documenting them.

Cleaning up issues, I think this one is sorted out :)


preserve users if restoring a repository on the same Gitea instance

When calling DumpRepository and RestoreRepository on the same Gitea
instance, the users are preserved: all labels, issues etc. belong to
the external user who is, in this particular case, the local user.
Dead code verifying g.gitServiceType.Name() == "" (i.e. plain git) is
removed. The function is never called because the plain git downloader
does not migrate anything that is associated to a user, by definition.
Errors returned by GetUserIDByExternalUserID are no longer ignored.
The userMap is used when the external user is not kown, which is the
most common case. It was only used when the external user exists
which happens less often and, as a result, every occurence of an
unknown external user required a SQL query.
Signed-off-by: Loïc Dachary<EMAIL_ADDRESS>
forgefriends source

I classified this as kind/bug because there is no way to restore a repository on the same Gitea instance and preserve the users.

Codecov Report

Merging #18604 (e9d0063) into main (80048c0) will increase coverage by 0.07%.
The diff coverage is 50.36%.

@@            Coverage Diff             @@
##             main   #18604      +/-   ##
==========================================
+ Coverage   46.25%   46.32%   +0.07%
==========================================
  Files         842      846       +4
  Lines      121180   121236      +56
==========================================
+ Hits        56052    56164     +112
+ Misses      58321    58260      -61
- Partials     6807     6812       +5

Impacted Files
Coverage Δ

models/commit.go
62.50% <0.00%> (ø)

models/release.go
49.45% <0.00%> (-1.49%)
:arrow_down:

models/review.go
50.29% <0.00%> (-0.60%)
:arrow_down:

models/user/external_login_user.go
28.57% <ø> (ø)

modules/git/notes_nogogit.go
66.66% <0.00%> (-2.19%)
:arrow_down:

modules/gitgraph/graph_models.go
80.85% <0.00%> (ø)

modules/migration/pullrequest.go
0.00% <0.00%> (ø)

modules/migration/release.go
0.00% <0.00%> (ø)

modules/migration/review.go
0.00% <0.00%> (ø)

modules/queue/manager.go
40.41% <0.00%> (-1.22%)
:arrow_down:

... and 37 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9419dd2...e9d0063. Read the comment docs.


Investigate reimplementing Renderer Settings window as a script.

Maintaining the Renderer Settings dialog as a C++ window is problematic, because it is inside OgreRenderingModule, and cannot have knowledge about external plugins.
Investigate reimplementing the whole RendererSettings.cpp as a script file, to be able to coherently show renderer-related settings there across plugin boundaries. Things like Hydrax/SkyX rendering quality and terrain detail would fit there very well.

https://github.com/LudoCraft/Tundra/commit/51952441b318260d1f767dd789a44efbe93be87a


Fix topic table display for introduction slides

To fix the display of the first line (Introduction) in topics:

And also remove the line extension if no Galaxy instances:

thanks!


Hook output is not piped to stdout

I am not sure if this is working as intended or not, however hook output is not written to stdout:
repositories:
  - name: incubator
    url: https://kubernetes-charts-incubator.storage.googleapis.com

environments:
  foo:
    values:
      - bar: 123

helmDefaults:
  tls: true
  tillerNamespace: kube-system

releases:
- name: myapp
  chart: incubator/raw
  version: 0.2.3
  hooks:
  - events: ["prepare", "cleanup"]
    command: "echo"
    args: ["123"]

$ helmfile -e foo -f test.yaml diff --skip-deps
test.yaml: basePath=.
Comparing myapp incubator/raw
********************

        Release was not present in Helm.  Diff will show entire contents as new.

********************

test.yaml: basePath=.

I completly agree with the status, I thought I did create an issue for that already but it seems not.
I had the same problem recently that I wanted to use the hook to display some status but failed to do so.
I think we could add a parameter in the hooks to enable output to be piped to stdout.
something like
- name: myapp
  chart: incubator/raw
  version: 0.2.3
  hooks:
  - events: ["prepare", "cleanup"]
    console-output: true
    command: "echo"
    args: ["123"]


Pretrained network

Hi, thanks for sharing the code and making it so easy to use.
I see in the example you set resnet = models.resnet50(pretrained=True).
Is this what is done in the paper? Shouldn't self-supervised-learned networks be trained from scratch?
Thanks again,
P.

hello! this is what I was following

Thanks for the clarification!

Please be careful here.
This paragraph describes the Semi-Supervised experiments, not the linear evaluation on ImageNet.
Setting pretrained=True loads pretrained weights obtained by supervised(!) training on ImageNet.
This is definitely not what you want to do here.


[BUG]:Release activity for CSI Powerstore v2.1.0

Release activity for CSI Powerstore v2.1.0, release tag version issue

Addressed https://github.com/dell/csi-powerstore/pull/37


Flag to strip package name in rpm/deb packages pURL export

What would you like to be added:
I am requesting to be added to Syft, as an option, a config option or flag to disable pURL namespaces for deb and rpm packages.
Why is this needed:
Syft builds rpm pURL as pkg:rpm/distro/package_name while the tool we use (dependency track, which scans vulns based on https://ossindex.sonatype.org/) expects pkg:rpm/package_name
Consequently, over a vast number of rpm packages used in our infrastructure, no vulnerability is found whereas there are many to be found stripping the namespace
pURLs can include or not the distro name for rpm, the specification seem interpreted both ways by various actors. In order to adapt both paradigm we would request a customizable export.

Thanks for filling the issue @arthur-hav! Just coming back to this issue and seeing it's been 3 months. Has dependency track updated their software to consume the valid PURLS produced by syft?
I am hesitant to accept a modification to allow users to drop this field only because more information is better, and I believe that downstream consumers should be the ones with the burden of updating to consume valid PURL for match purposes.
We also don't want to get into a world where Syft is gnerating a list of PURL where optional fields are omitted in some while others are more verbose.
Let me know if you still are not getting results from dependency track and maybe we can file and issue with them

Your argument seem reasonable; I'm all for adapting downstream and/or using adapters in the middle to avoid any unnecessary data cropping.
I have no idea about any possible change as I happened to have swapped employers and no longer follow the issue.
Thank you for your time to come back to me nonetheless.