feat(core): Add certificates to Operator.Web

Hey there @buehler!
This PR adds a new CertificateGenerator to Operator.Web, and it reworks a handful of the classes in Operator.Web to support using certificates in code. I more or less re-implemented the BouncyCastle solution from the CLI in Operator.Web using the built-in .NET classes, and I went to some length to ensure the generated certificates are virtually identical to those produced by BouncyCastle.
As for the reasoning, I admittedly had some trouble getting LocalTunnel working reliably in my environment. My company prefers just using our internal network versus a service, but I wanted to have a easy way to use self-signed certs with Kestrel and using your nifty webhook generator methods that are in the DevelopmentTunnelService. It also requires some knowledge of certificates and keys to get the BouncyCastle library working with certain .NET methods/classes, so this was a bit of a usability barrier for those who are unfamiliar.
Here are the changes I've made:

Pulled the webhook generator methods into a base class. The base class is implemented by TunnelWebhookService and CertificateWebhookService. The new CertificateWebhookService is added to the operator with a new method in OperatorBuilderExtensions, called UseCertificateProvider().

Moved or renamed a couple of classes to support this (TunnelConfig -> WebhookConfig, WebhookLoader moved).

Created a new CertificateGenerator class in Operator.Web.

Added some supporting extension methods.
The CertificateGenerator implements an interface called ICertificateProvider, which is used by UseCertificateProvider() so someone can implement their own solution (like reading from a file) if they want.

I replaced BouncyCastle in the CLI with the Operator.Web generator in 3bb58fb.
I added a few tests in ce7a7b5.

There are no breaking changes with these commits.
Regards,
Ian

Hey @ian-buse
Thank you for your contribution! :-)
Yes, certificate stuff is quite weird, and you need a lot of time to get your head around it. The way these certificates are implemented now is to ensure that webservers do not reject them because they all need certain custom extensions.
I had the same issues with localtunnel not being reliable. I'll review it right away :-)

Thanks for taking a look at it. I just realized I made a small mistake with the EnhancedKeyUsageExtension critical = true. Easy fix but I wanted to point it out, I can add it to the PR.

Hey @ian-buse
Thanks again for the contribution!
The linter is not happy right now with something (thus, the build is failing).
A made a few comments that I'd like to discuss.
One thing about the reason: if I understand you correctly, you had problems with local tunnel being shakey (like I did). Now you implemented a special way to use self signed certificates for local development without localtunnel.
I really do like the idea! Since I had the same issues with localtunnel, I'd go even further and say we remove localtunnel altogether and make a breaking change. Then local webhooks can and should be tested with a local kubernetes instance (mini kube or whatever). What do you think about this?
I don't even know if this local tunnel feature was used heavily.
And another question: why did you replace bouncycastle? (I'm curious)

Yeah, I had problems with LocalTunnel not working correctly, which made me implement the self-signed certs instead. Removing LocalTunnel would be fine with me!
BouncyCastle is a great library, but I replaced BouncyCastle with System.Security.Cryptography for a few reasons:

It is easier to use with .NET classes that use certificates. For example, I can configure Kestrel like so:
using CertificateGenerator generator = new(ip);
using X509Certificate2 cert = generator.Server.CopyServerCertWithPrivateKey();
builder.WebHost.ConfigureKestrel(serverOptions =>
{
    serverOptions.Listen(IPAddress.Any, 443, listenOptions =>
    {
        // If you used BouncyCastle, you would have to convert the
        // BouncyCastle cert to X509Certificate2 before using it
        listenOptions.UseHttps(serverCert);
    });
});

Everything that is being done with BouncyCastle in KubeOps.Cli can be done with System.Security.Cryptography, meaning I don't think the dependency is needed. Also, some organizations would prefer the operator use the built-in .NET library over a 3rd-party library when dealing with security. I've seen other projects also moving this direction for the same reasons (web-push-libs/web-push-csharp/pull/75, planetarium/libplanet/issues/66)

System.Security.Cryptography uses native DLLs and it is probably faster, though I haven't tested it myself.

I'll work on resolving the linter problem and other things you brought up. 😊
-Ian

Thanks for the explanation :-)
Yeah, I can absolutely understand that. I think more or less the same way, but BouncyCastle is (sometimes) great because the abstract the weird stuff like "OiD(183459122)" with something that has a meaning. That was the main reason.
I do like the move! Especially because of the native libs.
Regarding the removal of localtunnel: wdyt about this: you mark it as "deprecated" with the compiler attribute and we remove it in a later stage.
and regarding the "lazy" thing, I just tried it with the following example:
global using CertificatePair =
    (System.Security.Cryptography.X509Certificates.X509Certificate2 Certificate,
    System.Security.Cryptography.AsymmetricAlgorithm Key);

internal class CertificateGenerator : IDisposable
{
    public Lazy<CertificatePair> Root => new(Generate);

    private CertificatePair Generate()
    {
        return default;
    }

    public void Dispose()
    {
        if (Root.IsValueCreated)
        {
            Root.Value.Certificate.Dispose();
            Root.Value.Key.Dispose();
        }
    }
}

What do you think about such an implementation? (just a suggestion)

Thanks for the explanation :-)
Yeah, I can absolutely understand that. I think more or less the same way, but BouncyCastle is (sometimes) great because the abstract the weird stuff like "OiD(183459122)" with something that has a meaning. That was the main reason.
I do like the move! Especially because of the native libs.
Regarding the removal of localtunnel: wdyt about this: you mark it as "deprecated" with the compiler attribute and we remove it in a later stage.
and regarding the "lazy" thing, I just tried it with the following example:
global using CertificatePair =
    (System.Security.Cryptography.X509Certificates.X509Certificate2 Certificate,
    System.Security.Cryptography.AsymmetricAlgorithm Key);

internal class CertificateGenerator : IDisposable
{
    public Lazy<CertificatePair> Root => new(Generate);

    private CertificatePair Generate()
    {
        return default;
    }

    public void Dispose()
    {
        if (Root.IsValueCreated)
        {
            Root.Value.Certificate.Dispose();
            Root.Value.Key.Dispose();
        }
    }
}

What do you think about such an implementation? (just a suggestion)

Good, I'm glad you like the changes! I've resolved most of the issues we talked about, including the UTF-8 encoding, linting issues, moving ICertificateProvider to KubeOps.Abstractions, and deprecating LocalTunnel.
I like the idea of using Lazy, and I implemented a variation of your code in the latest commit. This cleaned up the interface implementation a lot. We still needed to use a backing field, otherwise the certificate will regenerate every time the property is accessed, so I followed this Microsoft doc for how to do it.


Program level - course progress Report

Purpose of the Feature
The dashboard provides insights on user onboarding, completion and certification across various TPD courses for the state.
Described Solution
It is a multi bar chart report which can describe the metrics with the
For state level report, X axis as percentage of  Expected user enrollments, user onboarding, completion & Y axis as District names.
For the lower levels, X axis as Number of users onboarding, completion and Certificate & Y axis as next level location names.

On the report loading all the districts information should be provided with 3 bars such as Expected user enrollments, user onboarding and completion
Report should have a selection option of Time period, Program, Course and District
If user selects the only Program, All the districts information should be provided with 3 bars such as Expected user enrollments, user onboarding and completion
If user selects the only Course, All the districts information should be provided with 3 bars such as users onboarding, completion and certificates.
Users may select Program & District, Course & District and same combination will be applicable for the lower levels also.
Download button should be created to download the aggregated metrics.

Effected code areas

New PostgreSQL Queries should be developed for Expected user enrollments, user onboarding, completions and certificates.
New NIFI processors to be created for the above queries execution
New Node API should be written to fetch the output files
Angular code should be developed for the multi bar chart representation for the created metrics.

Updated the data flow and JOLT Transformation.


Skip the :nocov: comments.

When using the nocov comment token the start and stop tokens are considered lines to be covered. Addresses the following issues:
colszowka#468
colszowka#527

This is a refresh of #531 since the repo had moved for three months.

Looks good, all test changes make sense to me (e.g. from never to skipped).
Thanks a lot!


Store all streaming websites in DB

We should have a database that has links to all websites that the extension was run on.
We need to store links for the website that's running the video and for all parent pages if the page is displayed within a frame.

Closing as it's related to server https://github.com/abozanona/luca-server/issues/4


fix little wrong log

:pencil: Description
Wrong log like:
Caused by: com.hotels.bdp.waggledance.api.WaggleDanceException: Primary metastore is unavailable {}
:link: Related Issues

The failed test case，it has nothing to do with my modification Error:  Failed to execute goal org.sonatype.plugins:nexus-staging-maven-plugin:1.6.8:deploy (injected-nexus-deploy) on project waggle-dance-rpm: Failed to deploy artifacts: Could not transfer artifact com.hotels:waggle-dance-api:jar:javadoc:4.0.0-20240415.025159-2 from/to sonatype-nexus-snapshots (https://oss.sonatype.org/content/repositories/snapshots): authentication failed for https://oss.sonatype.org/content/repositories/snapshots/com/hotels/waggle-dance-api/4.0.0-SNAPSHOT/waggle-dance-api-4.0.0-20240415.025159-2-javadoc.jar, status: 401 Unauthorized -> [Help 1]


Change package to ServiceContext; keep baggage compat module

Resolves https://github.com/apple/swift-distributed-tracing-baggage/issues/31
We are going to make a big rename here.
Due to many teams actively using this type in production right now even, and sometimes OUTSIDE of the context of distributed tracing just as a "glorified type-safe typesafe dictionary" we are going to embrace that that's what this type is, and going to call it ServiceContext.
Truth be told, this type wanted to be called this long time ago but it was back then decided that Context was too generic and we picked a tracing only name. Reality has shown us that the type is much more useful and we should not limit its wording and usage to tracing.
Thanks for opening the discussion and I'll do the necessary changes including repo name change.

And we're green -- and deprecated the Baggage names as well already.

@weissi signed off via chat :+1:

@ktoso do we need to rename the repo?


Question: what triggers the need for a PROXY configuration

The section https://github.com/Open-CMSIS-Pack/cpackget#working-behind-a-proxy explains the configuration of a Proxy.
When would I need to configure that?  Are there any error messages printed?
And as a user, how would I find the name of the PROXY that I need to specify?


sampling without replacement

There doesn't seem to be a way of doing sampling without replacement.
Is this true?
Are there any plans to provide this option in future releases?

Hi @ahsimb you're right that there is no way of doing sampling without replacement. At the moment we have no plans to provide this option in a future release.

Closing this issue, but feel free to re-open if you have further comments or questions.


Enforce node != document checks

Check that node is not document nor null on first iteration.

Could you explain the problem you are trying to solve?

In the app I'm building, node.getAttribute('data-suggestion-index') sometimes fails on IE 11 with the following error message: "object does not support property or method getAttribute". Checking that node !== document or null before the first loop iteration should avoid event.target being document

Thanks!
Did you test that this change solves the issue in IE11?

Dispatching a mousedown event on document with this change no longer throws an error on IE11

v8.0.1 contains this fix. Thanks!

Actually i am getting exactly the same error with version 9.3.2 of autosuggest
object does not support property or method getAttribute
I think this was not really a solution. Weird thing is that error sometimes randomly dissappears.


Add strong-name signing for Bicep.Types

Required by the Graph team.

Codecov Report

Merging #208 (d7c3c18) into main (dee13b6) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #208   +/-   ##
=======================================
  Coverage   94.31%   94.31%
=======================================
  Files          18       18
  Lines         299      299
=======================================
  Hits          282      282
  Misses         17       17

Flag
Coverage Δ

dotnet
94.31% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Unable to complete installation of racket

I moved my Caskroom location as suggested by @jawshooah in https://github.com/caskroom/homebrew-cask/issues/21913#issuecomment-225585378 and it worked for a number of my apps. Doing an install --force fixed the rest, but racket has been quite a pain.
First, I didn't realize that racket files were symlinked into /usr/local/bin and after mving /opt/homebrew-cask/Caskroom to /usr/local, I ended up with a bunch of broken symlinks which I didn't notice for about 30 minutes (that's my fault though).
Anyways, the current issue is that I removed racket completely from my computer and tried to reinstall. Here's what I get:
$ brew cask install racket --verbose
 ==> Downloading https://mirror.racket-lang.org/releases/6.5/installers/racket-6.5-x86_64-macosx.dmg
 Already downloaded: /Users/kunle/Library/Caches/Homebrew/racket-6.5.dmg
 ==> Verifying checksum for Cask racket
 ==> Moving App Suite 'Racket v6.5' to '/Applications/Racket v6.5'
 Error: It seems the symlink source is not there: '/usr/local/Caskroom/racket/6.5/Racket v6.5/bin/drracket'
 Error: Kernel.exit

In truth, when I go to /usr/local/Caskroom, there is no racket. This leads me to believe that the download and unpacking of the installer is happening somewhere other than /usr/local/Caskroom/racket. Any ideas on how to proceed? For completeness, the Racket v6.5 folder shows up in my Applications folder but I can't access any of the commands from the command line.

In truth, when I go to /usr/local/Caskroom, there is no racket

This is expected. When the install fails, we back out and remove all staged files (downloaded files remain cached, though).
#22153 will fix the broken symlinks.

Thanks! You guys rock! :)


Not working in Large Title

Hi there, thanks for your work. its useful for me, but its not working in Prefer Large Title + UISearchController underneath navigation bar. I will be appreciate your fixing this issues ASAP. Thanks.

不打算支持


Downloading checkpoints

Hello there,
First of all, thanks for this amazing work, and for sharing it with the community !
I have some issues downloading the several checkpoints shared in the Readme file (and actually no link to download.ifi.uzh.ch seem to reply)
Is there any problem with this server ?
Thanks for your reply, and keep up the good work !
BR
Laurent

Update: The files should be available again in about 48 hours. If you need checkpoint files urgently, let me know, and I could upload them to a google drive and send you the link.

Hello Mathias
Thanks for being that efficient ! There is no rush actually, I guess I could wait 48 hours to test inference using my Prophesee camera. Just have to dig a bit in the code to see how perform inference (since I'm not familiar with Hydra syntax)

inference using my Prophesee

How did you do that? I installed the SDK without Pro and got the verifikation and training running. Can you provide a simple starting code here, because a lot of users like to do that first as a basic demo.


add sx1272 example

Will it be possible to add a sx1272 example? The integration of this board seems more complex for me due to the DIO interfaces integration.
Thanks a lot

It should not diverge much from the stm32l0 example with the sx1276.
Do you have an easy to source board with SX1272 as a reference?

sx1272 use 4 dio as we can see it ( https://github.com/Lora-net/LoRaMac-node/blob/master/src/boards/SKiM980A/sx1272-board.c )
For me, the implementation si sigly different.
I have multiple board of this old model : https://github.com/wyres/hardware/blob/main/w_basev2/revB/W_BASE_V2.0_REVB_Schema.pdf STM32L151CC + SX1272 ).
From here  : https://www.tindie.com/products/wyld-things/lorawan-sensor-board/
for the EU868 region.

You need to create a custom interfacevariant to listen events for multiple dio's, here's a partial example I am using for a custom device:
use embassy_futures::select::{select, Either};

pub struct Sx127xWithRxTx<WAIT> {
    dio0: WAIT,
    dio1: WAIT,
    _reset: WAIT,
}

impl<WAIT> Sx127xWithRxTx<WAIT>
where
    WAIT: Wait,
{
    pub fn new(dio0: WAIT, dio1: WAIT, _reset: WAIT) -> Result<Self, RadioError> {
        Ok(Self { dio0, dio1, _reset })
    }
}

impl<WAIT> InterfaceVariant for Sx127xWithRxTx<WAIT>
where
    WAIT: Wait,
{
    async fn await_irq(&mut self) -> Result<(), RadioError> {
        match select(self.dio0.wait_for_high(), self.dio1.wait_for_high()).await {
            Either::First(_) => {
                #[cfg(feature = "defmt")]
                defmt::info!("dio0");
            }
            Either::Second(_) => {
                #[cfg(feature = "defmt")]
                defmt::info!("dio1");
            }
        }
        Ok(())
    }
}


Session username always return myusername

Hey there,
I've been developping a small portal app and tried using your auth system.
Everything works as expected, login/logout/signups work properly. I have protected a few pages, all is well for now.
However, whenever I extract the variable $_SESSION['username'] I am getting "myusername" instead of the username from the database.
I'm not a very good coder but I can get things working, however I don't find why such thing happens right now.
Thanks

Nevermind, ended up finding.
In checklogin.php, simply change the session username variable line for this:
$_SESSION['username'] = $myusername;


Comments Popup

In this PR:

Add popup functionality for the comment button
When user click a comment button a popup displayed for that movie

Hi @biruk-bereka you did a great!
I knew you can do it 😊. Please merge it!!
Congratulations 🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉!!!


Inconsistent Poisson MLE estimator

The estimator multiplies by two and subtracts the data (in the paper, in the docs and even in the code). That's not necessary for minimization and reduces the computational speed. Use instead the usual estimator everyone else uses: model - data * log model
and also use the derivatives of it.

Or does the hessian already do it like this in https://github.com/gpufit/GPUfit/blob/master/GPU_Fit/mle.cuh?

Maybe related to this: if you let the Gaussian 2D examples run (in Python or Matlab or C++) they consistently estimate the amplitude and the background level wrong if the amplitude is on the order of the background level, i.e. the ampltiude is significantly overestimated and the background level underestimated. Of course MLE estimators can be biased, so it may even be a real effect.
In any case it doesn't seems to be a simple bug. Does anyone has an idea? Do you see it for the other tests?This should probably be solved.

I changed the scope of this slightly and label it tentatively as a bug and assign also Adrian who will test the very same example against an independent fit algorithm (GPULMfit or CMinpack or ...).

Adrian reports the same effect for LSE.

I ran the matlab test gpufit_gauss2d() for GPUfit and GPU-LMFit. To get comparable results the tolerance is increased to 0.01. The results are the same for both implementations
p1 true  10.00 mean  10.78 std   0.00
p2 true   5.50 mean   5.35 std   0.00
p3 true   5.50 mean   5.78 std   0.00
p4 true   3.00 mean   2.57 std   0.00
p5 true  10.00 mean  10.20 std   0.00

I also compared GPUfit and cminpack using this test with the tolerance 0.0001. cminpack shows a similar behavior as GPUfit.
GPUfit:

p1 true  10.00 mean  10.79 std   2.86
p2 true   5.50 mean   5.50 std   0.33
p3 true   5.50 mean   5.50 std   0.33
p4 true   3.00 mean   3.09 std   0.87
p5 true  10.00 mean   9.53 std   3.05

cminpack:

p1 true  10.00 mean  10.85 std   4.59
p2 true   5.50 mean   5.50 std   0.33
p3 true   5.50 mean   5.50 std   0.33
p4 true   3.00 mean   3.10 std   0.97
p5 true  10.00 mean   9.47 std   4.76

I will run it against Matlab using Poisson ML and with larger fit sizes, just to make sure the deviance is not on our side.

I did it and Matlab gives the same result. So we are not only sure it's not a bug, we are even seeing the breaking down of MLE here. Nice example. The more efficient computation issue here I disregard for now. Someone of us will surely revisit the kernels sooner or later.


Adding container-runtime to kubeletConfiguration

Adding container-runtime to kubeletConfiguration

1. Issue, if available:
#1615
2. Description of changes:

After a little back and forth, I think I've decided to let the container-runtime be parameterized. Letting folks set this via UserData will be a little complicated given you'd need to modify kubelet CLI args and it's not part of their JSON config.
I want each cloud-provider to dictate which container runtimes are supported so I moved the validation and runtime defaulting into the provider.
We no longer use Docker with Nvidia and AMD GPUs. This is a breaking change of sorts and will need to be called out in the Release Notes.

We can safely make this breaking change because there's now a way to override the container-runtime to be used.

3. How was this change tested?
Some unit tests, and also tested some of this locally.
4. Does this change impact docs?
WIP.

[ ] Yes, PR includes docs updates
[ ] Yes, issue opened: link to issue
[ ] No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Hi,
As you mentioned I have specified the container runtime but I have received the below error:
error validating data: ValidationError(Provisioner.spec.kubeletConfiguration): unknown field "containerRuntime" in sh.karpenter.v1alpha5.Provisioner.spec.kubeletConfiguration; if you choose to ignore these errors, turn validation off with --validate=false


Percentage wildcard in like filter throws postgrest.exceptions.APIError

Bug report
Describe the bug
I use the like filter as described in the documentation. I get the following error postgrest.exceptions.APIError: {'message': 'JSON could not be generated', 'code': 500, 'hint': 'Refer to full message for details', 'details': ...
To Reproduce
Steps to reproduce the behavior, please provide code snippets or a repository:
meeting_id = f'%{85770204020}%'
m = supabase.table('meeting').select('*').like('meeting_url', meeting_id).execute()

The meeting_url contains the meeting url with the meeting_id contained in the string.
Expected behavior
Should return the database entries,  not throw an error. It seems for me an encoding error since if I replace the % with %25 no error is thrown.
Screenshots
If applicable, add screenshots to help explain your problem.
System information

OS: mac
Version of supabase-py: supabase==2.5.1

Hello fschay, I noticed a subtle issue in your query pattern syntax.
The pattern should not include {} braces around the value. Instead, directly use % symbols around the value to match any string containing<PHONE_NUMBER>0.
Here's the corrected code:
meeting_id = '%85770204020%'  # Correct pattern syntax m = supabase.table('meeting').select('*').like('meeting_url', meeting_id).execute()
This should resolve the issue. For reference, you can also check the example from the Supabase documentation here.
If you have any further questions or issues, feel free to ask!

Ok thanks my bad.


Clarify remark about object names wrt CRD

This PR clarifies the remark about the restrictions on the name of an object whose kind/resource is defined by a CRD.
Fixes #46262

/cc @liggitt
/cc @sftim
@sttts

@MikeSpreitzer Whenever you get a chance, could you please take a look at the reviewers' feedback and respond to them? Thanks!

.. and the force-push to 4bdf0e818c fixes a typo.

@liggitt , @deads2k , @enisoc: can you please give a tech review?

the changes are technically accurate and I like having the update in the table for comparison
lgtm

@sftim: I think you have gotten what you need.

lgtm

@sftim: back to you.

/lgtm

/hold
Adding this because of the confusion around https://github.com/kubernetes/website/pull/46263#discussion_r1693974399
If it becomes clear that the confusion is addressed and we've reached consensus that the change is wrong, OK to unhold. Otherwise, leave it in place so approvers can see there's unaddressed feedback.

/lgtm
/approve


⚠ Site ANTS has degraded performance

In 004ccc2, Site ANTS (https://ants.gouv.fr) experienced degraded performance:

HTTP code: 200
Response time: 11091 ms

Resolved: Site ANTS performance has improved in 0554e69.


Breakpoints in deferred libraries do not work in dartium

Original report from keertip:
I was not able to get this example working in the editor. Cannot get it to stop after the then or in def.dart. Have also attached a log with the communication between editor and VM.
import 'def.dart' deferred as D;
main() {
  print("hello");
   D.loadLibrary().then((_) {
     print("D is loaded");
     D.hello();
  });
  print("main ends");
}
and def.dart
library D;
void hello() {
  print('hello from D');
}

this was fixed a while ago.


lxc-container: Why is "LoadCredential=" overwritten

Describe the bug
The systemd drop-in systemd-lxc-service-overrides in lxc-container.nix  overrides LoadCredential(LoadCredential= is set). Why is it necessary to overwrite LoadCredential?
    # Add the overrides from lxd distrobuilder
    # https://github.com/lxc/distrobuilder/blob/05978d0d5a72718154f1525c7d043e090ba7c3e0/distrobuilder/main.go#L630
    systemd.packages = [
      (pkgs.writeTextFile {
        name = "systemd-lxc-service-overrides";
        destination = "/etc/systemd/system/service.d/zzz-lxc-service.conf";
        text = ''
          [Service]
          ProcSubset=all
          ProtectProc=default
          ProtectControlGroups=no
          ProtectKernelTunables=no
          NoNewPrivileges=no
          LoadCredential=
        '' + lib.optionalString cfg.privilegedContainer ''
          # Additional settings for privileged containers
          ProtectHome=no
          ProtectSystem=no
          PrivateDevices=no
          PrivateTmp=no
          ProtectKernelLogs=no
          ProtectKernelModules=no
          ReadWritePaths=
        '';
      })
    ];

I use LoadCredential in my systemd units and allowing it in an lxc has not caused any issues on my side so far.
Previously I copied the overrides from lxc-container.nix and commented it out, and it got overwritten. That does not work anymore...
As far as I know, it merges based on priority (and both would be default), but that shouldn't cause disabling LoadCredential upstream anyway.
I tried to overwrite with (lib.hiPrio (pkgs.writeTextFile ... but that was not successful.
What can I do to fix my system?
Steps To Reproduce
Steps to reproduce the behavior:

Attach the following config & build:

lxc-container.nix
{ modulesPath, pkgs, lib, config, ... }:
{
  imports = [
   (modulesPath + "/virtualisation/lxc-container.nix")
  ];

    # override  bc it breaks step-ca
    systemd.packages = [
      (lib.hiPrio (pkgs.writeTextFile {
        name = "systemd-lxc-service-overrides";
        destination = "/etc/systemd/system/service.d/zzz-lxc-service.conf";
        text = ''
          [Service]
          ProcSubset=all
          ProtectProc=default
          ProtectControlGroups=no
          ProtectKernelTunables=no
          NoNewPrivileges=no
          # LoadCredential=
        '' + lib.optionalString config.virtualisation.lxc.privilegedContainer ''
          # Additional settings for privileged containers
          ProtectHome=no
          ProtectSystem=no
          PrivateDevices=no
          PrivateTmp=no
          ProtectKernelLogs=no
          ProtectKernelModules=no
          ReadWritePaths=
        '';
      }))
    ];
}

3. View `/etc/systemd/system/service.d/zzz-lxc-service.conf` and see that `LoadCredential=` is not commented out.
Expected behavior
LoadCredential= should be commented out.
Notify maintainers
@adamcstephens
Metadata
[user@system:~]$ nix-shell -p nix-info --run "nix-info -m"
 - system: `"x86_64-linux"`
 - host os: `Linux 6.2.16-10-pve, NixOS, 23.11 (Tapir), 23.11.20231009.f99e5f0`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.17.0`
 - channels(root): `"nixos-23.11pre523424.f718d9b5d27a"`
 - nixpkgs: `/nix/store/902j4afzd3glcviwv1kzkqq3bb05y736-source`

As mentioned in the associated comment, this override file comes directly from upstream distrobuilder. "Why" would need to be directed to them, but it's not clear from the initial implementation upstream the actual reason. https://github.com/lxc/distrobuilder/pull/501
The merging for this override happens at that systemd level. I've not tried personally to turn it back on.
Are you saying you have success using systemd credentials in an LXC container?
Is it a nested or privileged container?
Did you have to implement the following?
    boot.specialFileSystems = {
      "/run".options = ["shared"];
    };
  };

Are you saying you have success using systemd credentials in an LXC container? Is it a nested or privileged container? Did you have to implement the following?
It is an unprivileged container with fuse and nesting enabled.
No extra config was required. I was able to get step-ca (which uses LoadCredential) running in an lxc.
Sadly I cannot overwrite "LoadCredential=" anymore...

[root@nix-exp1:~]# mount | grep run
tmpfs on /run type tmpfs (rw,nosuid,nodev,size=32945600k,mode=755,uid=100000,gid=100000,inode64)
ramfs on /run/keys type ramfs (rw,nosuid,nodev,relatime,mode=750)
tmpfs on /run/wrappers type tmpfs (rw,nodev,relatime,size=65891196k,mode=755,uid=100000,gid=100000,inode64)
none on /run/secrets-for-users.d type ramfs (rw,nosuid,nodev,relatime,mode=751)
none on /run/secrets.d type ramfs (rw,nosuid,nodev,relatime,mode=751)
tmpfs on /run/user/0 type tmpfs (rw,nosuid,nodev,relatime,size=13178236k,nr_inodes=3294559,mode=700,uid=100000,gid=100000,inode64)

Can you show me an example of how you use LoadCredential? I'm open to changing this on our end, since we don't use systemd-sysusers, but I actually want to write a test for this so we can ensure it continues to work.

I configured step-ca.
services.step-ca.intermediatePasswordFile propagates LoadCredential
See: https://github.com/NixOS/nixpkgs/blob/08a8f7903da8d35dfdd71ded28bcd9032053eba2/nixos/modules/services/security/step-ca.nix#L112C15-L113C15

Hi,
can I provide more information, if needed, so you can build the test?
Thanks for the effort :>

No, I understand the problem and have an idea of how to test it. It's just a matter of time and priority. If you're interested in attempting this, I plan to nixos/tests/lxd/container.nix:

add to the release configuration a simple service which will read a credential and write an output file with the data
a check that will compare and verify the output file matches the original content

Ahh okay. Just wanted to make sure that this won't get forgotten.
Thanks :>

My solution for this is https://github.com/NixOS/nixpkgs/pull/264929
It may still be a bit until I can get a committer to review and merge my two PRs.
In development of that change I discovered our porting of the logic was incorrect, and LoadCredential should not be disabled for nested containers.

@marrobHD can you verify if this is resolved for you now?

@marrobHD can you verify if this is resolved for you now?
It did not make 23.11 unfortunately.

Yes its solved. Thanks <3

Hi,  I drop here my  'quick and dirty' solution for removing the LoadCredential override in lxc containers (for nixos 23.11)
if it can be useful to someone encountering this issue ...
imports = [
    ## Quick and dirty fix for https://github.com/NixOS/nixpkgs/issues/260670
    # "${toString modulesPath}/virtualisation/lxc-container.nix"
    (builtins.toFile "lxc-container.nix" (builtins.replaceStrings
      [ "LoadCredential=" "./lxc-instance-common.nix" ]
      [ "#LoadCredential=" "${toString modulesPath}/virtualisation/lxc-instance-common.nix" ]
      (builtins.readFile "${toString modulesPath}/virtualisation/lxc-container.nix")))
  ];

I think I've misunderstood this bug a bit .. I'm still having problems with buildbot (which uses LoadCredential) in 24.05, trying to run directly in an lxc container in incus (with incus running on non-nixos.)  /run/systemd/system/service.d/zzz-lxc-service.conf gets created now (note in /run not /etc) and still disables LoadCredential. Should this have been fixed, or did we only fix the NixOS part of this problem?

Turns out this file ending up in /run makes it a right nuisance to override. I'm a bit of a nix newbie and have ended up with the following - I'd be surprised if there wasn't a better way, but if anyone else is desperate..
systemd.generators.lxc-override = pkgs.writeShellApplication {
    name = "lxc-override-generator";
    runtimeInputs = [ pkgs.coreutils ];
    text = ''
      DIR=/run/systemd/system/buildbot-worker.service.d
      mkdir -p $DIR
      cat >/$DIR/zzz-lxc-service.conf <<EOF
      [Service]
      ProcSubset=all
      ProtectProc=default
      ProtectControlGroups=no
      ProtectKernelTunables=no
      NoNewPrivileges=no
      #LoadCredential=
      PrivateNetwork=no
      EOF
    '';
  } + "/bin/lxc-override-generator";

Are you enabling security.nesting=true on your container? I would guess not, which is why LoadCredential is being overwritten.
In general, it's strongly recommended to use nested containers with NixOS. While the OS technically works without it, I think nesting is required even for simple nix builds.
The configuration in /run only gets created if nested https://github.com/lxc/distrobuilder/blob/f03da024aa1b45624214e8020eccd1b9dda9cf43/distrobuilder/lxc.generator#L177-L182
And is verified in our tests https://github.com/NixOS/nixpkgs/blob/097350409e37e6fd7d6f93610107fa15f6d82911/nixos/tests/incus/container.nix#L109
Note that we patch that upstream generator here https://github.com/NixOS/nixpkgs/blob/af52c7b5155c9b0f68690ecddfcd8957c8214495/pkgs/tools/virtualization/distrobuilder/nixos-generator.patch

Ah, I think I may have really misunderstood the earlier conversation, apologies! I assumed the nested container stuff applied to actual nesting of full containers, but I guess systemd does a lot with namespaces etc that may also require it (and probably explains the restrictions upstream's script it enforcing when it's off.) And as you say, nix's sandboxing probably needs it too. I will update my container config later - thank you for the pointer.


[fix][broker] Fix ProducerBusy issue due to incorrect userCreatedProducerCount on non-persistent topic

Motivation

https://github.com/apache/pulsar/pull/20607 introduced the variable userCreatedProducerCount to track the number of producers created by users. Concurrently, the removeProducer method in AbstractTopic decreases the count of userCreatedProducerCount using USER_CREATED_PRODUCER_COUNTER_UPDATER.decrementAndGet(this) when a producer is removed. However, NonPersistentTopic overrides the removeProducer method of AbstractTopic, and the overridden removeProducer method in NonPersistentTopic does not decrease the count of userCreatedProducerCount. As a result, when maxProducersPerTopic is set, this incorrect value of userCreatedProducerCount can lead to a ProducerBusy error when creating a producer.
Modifications

Since the NonPersistentTopic class extends the AbstractTopic class and the implementation of the removeProducer method in NonPersistentTopic is identical to that in AbstractTopic, the removeProducer method in NonPersistentTopic can be safely removed.
Verifying this change

[ ] Make sure that the change passes the CI checks.

Added test in org.apache.pulsar.broker.service.nonpersistent.NonPersistentTopicTest#testRemoveProducerOnNonPersistentTopic
Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

[ ] Dependencies (add or upgrade a dependency)
[ ] The public API
[ ] The schema
[ ] The default values of configurations
[ ] The threading model
[ ] The binary protocol
[ ] The REST endpoints
[ ] The admin CLI options
[ ] The metrics
[ ] Anything that affects deployment

Documentation

[ ] doc
[ ] doc-required
[x] doc-not-needed
[ ] doc-complete

Matching PR in forked repository
PR in forked repository: https://github.com/hrzzzz/pulsar/pull/5

/pulsarbot rerun-failure-checks

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 73.09%. Comparing base (bbc6224) to head (a3883a9).
Report is 250 commits behind head on master.

Additional details and impacted files

@@             Coverage Diff              @@
##             master   #22685      +/-   ##
============================================
- Coverage     73.57%   73.09%   -0.48%
+ Complexity    32624    32465     -159
============================================
  Files          1877     1888      +11
  Lines        139502   141103    +1601
  Branches      15299    15484     +185
============================================
+ Hits         102638   103145     +507
- Misses        28908    29971    +1063
- Partials       7956     7987      +31

Flag
Coverage Δ

inttests
27.36% <ø> (+2.77%)
:arrow_up:

systests
24.79% <ø> (+0.47%)
:arrow_up:

unittests
72.11% <ø> (-0.73%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files
Coverage Δ

...oker/service/nonpersistent/NonPersistentTopic.java
71.07% <ø> (+1.60%)
:arrow_up:

... and 334 files with indirect coverage changes


FFMPEG with libx264

Hi, could you guys please put out a note on how to compile ffmpeg with libx264 for video encoding? FFMPEGInterop currently gives decoding feature. I would like to integrate encoding into it. But the WinRT component I built is not able to find the H264 encoder. I am new to the ffmpeg altogether. I followed this link http://trac.ffmpeg.org/wiki/How to quickly compile FFmpeg with libx264 (x264%2C H.264) on how to compile x264. But the MSYS is throwing error "could not identify OS" . But FFMPEG is compiling fine. I am using Windows 10 x64.

could anyone help me with this please?


velero pod on source side should not go to CrashLoopBackoff upon access permissions to bucket

Apologies, I can't seem to open issues against our velero fork and there isn't a ton to go off of here, but maybe it rings a bell for someone:

(BUG) velero pod on source side should not go to CrashLoopBackoff upon access permissions to bucket
See doc for log output

An error occurred: some backup storage locations are invalid: backup store for location "repo-large1-szbjp" is invalid: rpc error: code = Unknown desc = AccessDenied: Access Denied
    status code: 403, request id: k73di8h0-c12w4a-156n, host id: k73di8h0-c12w4a-156n

This is about as much as I've got. Feel free to close if this is not sufficient or this belongs somewhere else, just trying to catalog issues that came up during the hackathon.

This looks like it would be a valid error if the object storage was the only BSL configured and had invalid credentials. We should detect this prior to creating the BSL so that we don't put Velero in this state.
This is worth investigating.

https://github.com/vmware-tanzu/velero/issues/1967

I think I ran into this same problem a couple weeks ago. I had two BSLs but one of them became invalid (I think the NooBaa server crashed), and velero refused to start until I deleted the NooBaa BSL.

Yes, this is currently the way Velero behaves, ie, if it finds an invalid BSL, it will block operations. We are changing the behavior so if that Velero continues creating backups even if there are invalid BSLs, as long as there's a valid BSL for them. Work being tracked here: https://github.com/vmware-tanzu/velero/issues/1967

@dymurray @sseago did this ever get fixed in Velero upstream? Wondering if we should keep the issue open.

It looks like the referenced PR was merged post-1.4.2, and it's been refactored since then. I'm guessing that 1.5.2 has the fix in one form or another, but I'm not 100% sure.

Ok, will leave this open for now.


Error when trying to compile

I tried to build this project in intellij idea and got this error
Error:(40, 17) Kotlin: Type inference failed: inline fun <T : GenericEvent, reified F> addGenericListener(consumer: Consumer): Unit
cannot be applied to
(KFunction1<@ParameterName RegistryEvent.Register, Unit>)
Error:(40, 36) Kotlin: Type mismatch: inferred type is KFunction1<@ParameterName RegistryEvent.Register, Unit> but Consumer was expected

Should be fixed now that Kotlin 1.4 is out of pre release


move artifactory config under source control

right now it's all configured in the UI (except for the vhost connector config), hoping nothing is accidentally lost...

Here's the current dump: https://gist.github.com/adriaanm/057ced9b739466d87a09ed24a4367bd5

newer dump: https://gist.github.com/SethTisue/4ef883260582d06f29ea3fb065f6fde9

@adriaanm is there a current snapshot?

there is, indirectly -- in the full snapshot of the ec2 instance's volume.

snapshot: https://gist.github.com/SethTisue/0a3238add54afcc4a79c37497939f211

fresh snapshot: https://gist.github.com/SethTisue/81b13979a80840bc6260a07cc8679879
I added the same resolver that I added in https://github.com/scala/community-builds/pull/808
it's unfortunate that we have two somewhat different configs (the one on scala-ci, and the one for local usage), but oh well, neither changes very often

Adriaan upgraded Artifactory to 6.3.0 (in December I think it was). current config is https://gist.github.com/SethTisue/d07fbd5be4adcdc6b5a2f2e6ffb37daf

our Artifactory is on 6.11.3 these days, config snapshot https://gist.github.com/SethTisue/41db3da48f3989b7b8d35c4f7c1c59e8

these days pretty much everybody just publishes their sbt plugins to Maven Central (or, until recently, to repo.scala-sbt.org) and it's exceedingly rare we ever need to add a resolver or otherwise adjust the config anymore


Change data-sdk-integration-source attribute value

We need to change the value to integrationbuilder_sc. The sc part standard for standard-checkout. The value ac stands for advanced-checkout.

FIXED


DrawArc() and Vector3Slerp

I wrote a Vector3Slerp() function which provides spherical linear interpolation between two points without using quaternions.  It also provides more options for the curve.
The iradius parameter allows increasing the radius of the arc, so flatter or rounder curves can be drawn.  When iradius=0.0, the curve is a semi-circle with its center on the midpoint of the line between point 1 and point 2. Larger values relocate the center of the curve off the midpoint, producing a flatter curve.
The theta parameter allows the direction of the arc to be rotated in any direction perpendicular to the line between the two points (like a jump rope).
DrawArc() seemed like a natural next step, so I added that too.  The only additional parameters here are Color, and the number of segments to use for the arc, similar to the options you provide for circles.
I offer it to you if you find it useful for inclusion.  Hopefully I did everything right in the pull request! :-)

@ProfJski Thanks for the addition! Would you mind reviewing the code to follow the raylib code style conventions?

@raysan5 I think I fixed it up according to your style conventions.  I left comments on both files about what I did: single-letter variables to lower-case and curly brackets in "aligned" mode.

@ProfJski I won't be adding DrawArc() for now but I'd like to add Vector3Slerp(). Please, could you review the PR? Thanks and sorry for the inconvenience.


Feat request: binary obs_sequence files

Currently working with acsii file only.

binary format:
native, little_endian, big_endian
https://github.com/NCAR/DART/blob/71d70e1e346e3cc7c0244ad839415104140cfc9d/assimilation_code/modules/observations/obs_sequence_mod.f90#L137-L139

No location "loc3d" "loc1d" set for binary obs sequence files.
https://github.com/NCAR/DART/issues/286


[i18n] Add Portuguese (pt-BR)

inlang: update translations

[i18n] Add pt-BR

Thank you! You did a great job!


License?

Hi, Amazing repo and implementation :)
Please can you confirm what license this code is released under?

https://github.com/katerakelly/pytorch-maml/blob/master/LICENSE
MIT I assume?

Good point. Note that that is dated 9 days ago ;)  :

Thank you @katerakelly  :)


improve /packit propose-update behaviour

Tried to investigate
https://sentry.io/organizations/red-hat-0p/issues/1345950807
which had been triggered by /packit propose-update comment in
https://github.com/ansible-community/ansible-bender/pull/190
but have more questions than answers:

the event was parsed as PullRequestCommentEvent even there's no "pull_request" in event["issue"]
handler was GitHubIssueCommentProposeUpdateHandler even this is a PR comment

We've changed the parsing code a lot recently so let's redeploy the changes to prod and try to reproduce this again.

The problem is probably that we expect the /packit propose-update to be used in issues only.
How do we want to fix this?

enable /packit propose-update to be used also in PRs?
comment in a PR that /packit propose-update can be used only in an issue?

Reproduced in stg with latest-greatest:
https://sentry.io/organizations/red-hat-0p/issues/1350697700/

For me, it's weird that /packit propose-update can only be used in the comments, but  not in issue-title and issue-description.
What about these triggers:

the issue with the title containing /packit propose-update
comment in the Issue with the title containing /packit propose-update (to retriger that)
comment in the PR, but trigger the process after the merge (?)

The task here is clear. Not a high-prio but nice to have.

We (=I) have changed the related code in the last sprint. I am going to close this. We can open a new issue if the problem preserves.

We (=I) have changed the related code in the last sprint. I am going to close this. We can open a new issue if the problem preserves.


Changing "soundTransform.volume" doesn't work for HTML5

In HTML5, the volume of a NetStream video cannot be changed via soundTransform.volume
getting netStream.soundTransform.volume always returns 1, even if I set it to 0 before that
Am I doing something wrong?
The only workaround I could find is to replace the whole soundTransform with a new SoundTransform:
someVideo.netStream.soundTransform = new SoundTransform(0, 0); // where the first "0" is the volume

@bkhtrv Try this to change the volume:
var transform= netStream.soundTransform;
transform.volume = 0;
netStream.soundTransform = transform;


Can't clear the terminal programmatically

Running node -e "process.stdout.write ( '\u001Bc' );" should clear the terminal, but this is what I get if I run it in xterm:

If I try to clear it with a node -e "process.stdout.write ( '\033[2J\033[0f' );" the whole thing becomes black.
Is there a way it can be cleared properly?

Using node -e "process.stdout.write ( '\u001Bc' );"  or echo -e '\x1bc' tell bash to clear, and bash gives back a response to xterm.js. I believe this is why you're seeing the prompt again. You can call term.write('\x1bc') to clear only the front end (xterm.js).

What if I don't have access to the xterm instance?
I basically want to clear the terminal when my CLI app starts, how am I supposed to do that if it gets launched from xterm?

@fabiospampinato it looks like clear command on Linux sends '\x1b[H\x1b[2J'
That translates into:

Move cursor to (1,1) (CUP)
Erase all in display (ED)

See http://invisible-island.net/xterm/ctlseqs/ctlseqs.html for more info

That works, thank you!


Virtual Firealarm always sends "time":0" in payload data in RC3

Virtual Firealarm is not working as device statistics has no curve shown.
The agent log indicates  "time": 0 in payload data. Will this be the cause and how to resolve?
WSO2 IOT Sample
Virtual Fire Alarm
initializing agent
01:11:24 [INFO] AgentUtilOperations - AGENT_LOG:: jar:file:/C:/Users/citystory/Virtual%20Firealarm/wso2-firealarm-virtual-agent.jar!/deviceConfig.properties
01:11:24 [INFO] AgentUtilOperations - AGENT_LOG:: Tenant Domain: carbon.super
01:11:24 [INFO] AgentUtilOperations - AGENT_LOG:: Device Owner<EMAIL_ADDRESS>01:11:24 [INFO] AgentUtilOperations - AGENT_LOG:: Device ID: uboocdzonp6c
01:11:24 [INFO] AgentUtilOperations - AGENT_LOG:: Device Name: Virtual Firealarm
01:11:24 [INFO] AgentUtilOperations - AGENT_LOG:: IoT Server HTTPS EndPoint: https://iots:8243
01:11:24 [INFO] AgentUtilOperations - AGENT_LOG:: IoT Server HTTP EndPoint: http://iots:8280
01:11:24 [INFO] AgentUtilOperations - AGENT_LOG:: API-Manager Gateway EndPoint: http://iots:8280
01:11:24 [INFO] AgentUtilOperations - AGENT_LOG:: MQTT Broker EndPoint: tcp://iots:1886
01:11:24 [INFO] AgentUtilOperations - AGENT_LOG:: XMPP Server EndPoint: XMPP:
01:11:24 [INFO] AgentUtilOperations - AGENT_LOG:: Base64Encoded API Application Key: dURmUnRpVDVMNUtySjJGd1V6bVl5ZEY4T3h3YTpHd01KaHNkQ1BheFkwSG1mUkd6blVLN3dzazRh
01:11:24 [INFO] AgentUtilOperations - AGENT_LOG:: Authentication Token: 87783dbd-b0f9-34f4-a81f-a20e83c7d0de
01:11:24 [INFO] AgentUtilOperations - AGENT_LOG:: Refresh Token: ab962143-9076-38cf-9421-759569edc312
01:11:24 [INFO] AgentUtilOperations - AGENT_LOG:: Data Push Interval: 15
01:11:24 [INFO] AgentUtilOperations - AGENT_LOG:: XMPP Server Name: iots
01:11:24 [INFO] AgentUtilOperations - AGENT_LOG:: IoT Server's Device Controller API Endpoint: https://iots:8243/virtual_firealarm/device
01:11:24 [INFO] AgentUtilOperations - AGENT_LOG:: Device Enrollment EndPoint: https://iots:8243/virtual_firealarm/device/register
01:11:24 [INFO] AgentUtilOperations - AGENT_LOG:: DeviceIP Registration EndPoint: https://iots:8243/virtual_firealarm/device/register
01:11:24 [INFO] AgentUtilOperations - AGENT_LOG:: Push-Data API EndPoint: https://iots:8243/virtual_firealarm/device/temperature
01:11:24 [INFO] TransportUtils - The IP String - 'XMPP:' is invalid. It needs to be in format '://:'.
01:11:24 [INFO] AgentManager - XMPP Endpoint String - XMPP:, provided in the configuration file is invalid. XMPP is not configured.
01:11:24 [INFO] MQTTTransportHandler - MQTT subscriber was created with ClientID : admin@carbon.super:uboocdzonp6c
01:11:29 [INFO] MQTTTransportHandler - Subscriber 'admin@carbon.super:uboocdzonp6c' subscribed to topic: carbon.super/virtual_firealarm/uboocdzonp6c/operation/#
01:11:45 [INFO] FireAlarmMQTTCommunicator - AGENT_LOG:: Message: '{"event": {"metaData": {"owner": "admin@carbon.super","deviceId": "uboocdzonp6c","time": 0},"payloadData": { "temperature": 22} }}' published to MQTT Queue at [tcp://iots:1886] under topic [carbon.super/virtual_firealarm/uboocdzonp6c/temperature]
01:11:47 [INFO] FireAlarmMQTTCommunicator - AGENT_LOG:: Message: '{"event": {"metaData": {"owner": "admin@carbon.super","deviceId": "uboocdzonp6c","time": 0},"payloadData": { "temperature": 21} }}' published to MQTT Queue at [tcp://iots:1886] under topic [carbon.super/virtual_firealarm/uboocdzonp6c/temperature]
01:11:49 [INFO] FireAlarmMQTTCommunicator - AGENT_LOG:: Message: '{"event": {"metaData": {"owner": "admin@carbon.super","deviceId": "uboocdzonp6c","time": 0},"payloadData": { "temperature": 49} }}' published to MQTT Queue at [tcp://iots:1886] under topic [carbon.super/virtual_firealarm/uboocdzonp6c/temperature]
01:11:51 [INFO] FireAlarmMQTTCommunicator - AGENT_LOG:: Message: '{"event": {"metaData": {"owner": "admin@carbon.super","deviceId": "uboocdzonp6c","time": 0},"payloadData": { "temperature": 34} }}' published to MQTT Queue at [tcp://iots:1886] under topic [carbon.super/virtual_firealarm/uboocdzonp6c/temperature]
01:11:53 [INFO] FireAlarmMQTTCommunicator - AGENT_LOG:: Message: '{"event": {"metaData": {"owner": "admin@carbon.super","deviceId": "uboocdzonp6c","time": 0},"payloadData": { "temperature": 29} }}' published to MQTT Queue at [tcp://iots:1886] under topic [carbon.super/virtual_firealarm/uboocdzonp6c/temperature]

Hi citystorynet,
This is not reproducible in IoTS 3.1.0 released pack.We tried to reproduce this on the Linux environment, but it works as expected way.
It would be great if you can provide us following details to analyze this further.

Operating System that you are trying this with.
Check whether server and agent running on the same network or not.
Can you please a try-out the same thing with our newly released pack "http://wso2.com/iot" and let us know the outcome.

The agent log that you have provided here is correct. As you explained agent send time as 0 in payload data. The reason to send time as 0 from the agent is temperature graph is rendered against server time. Therefore, when temperature data received to the server it updates the graph with the current time of the server and temperature value. Hence, it won't be an issue for rendering virtual fire alarm statistics.
Thanks and Regards,
Lasantha

Hi Lasantha,
Thanks for the reply.

My guest VM OS is CentOS7
Server running on guest VM (iots) and agent running on host (Win 10 Pro)

I have resolved this on the release version of 3.1.0.
But I am not sure if this is due to moving the server to real VPS and
connect from my PC (Win 10 Pro)
The other change I have made is that instead of manually configure hostname
for the server.
This time I have used the new change-ip.sh.
Thanks anyways. Please close it.
Clement
On Fri, Aug 18, 2017 at 10:24 AM, Dharmakeerhi Lasantha <
<EMAIL_ADDRESS>wrote:

Hi citystorynet,
This is not reproducible in IoTS 3.1.0 released pack.We tried to reproduce
this on the Linux environment, but it works as expected way.
It would be great if you can provide us following details to analyze this
further.

Operating System that you are trying this with.
Check whether server and agent running on the same network or not.
Can you please a try-out the same thing with our newly released
pack "http://wso2.com/iot" and let us know the outcome.

The agent log that you have provided here is correct. As you explained
agent send time as 0 in payload data. The reason to send time as 0 from the
agent is temperature graph is rendered against server time. Therefore, when
temperature data received to the server it updates the graph with the
current time of the server and temperature value. Hence, it won't be an
issue for rendering virtual fire alarm statistics.
Thanks and Regards,
Lasantha
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/wso2/product-iots/issues/1276#issuecomment-323242576,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AU80ejxNsV6LZrAu9bsA6GPWDpSSZXS5ks5sZPXMgaJpZM4Ovs9v
.

Hi @citystorynet ,
This issue is fixed in the latest update of wso2 IoT server that went out yesterday.
https://github.com/wso2/product-iots/releases/tag/v3.1.0-update1
Thanks,
Ruwan


[BUG] 0.3 Introduces CJS bug

Describe the bug
just updated to 0.3 and it seems one of the patches introduced a bug while importing a method on glob:
.../node_modules/.pnpm/@opennextjs+cloudflare@0.3.0_rimraf@3.0.2_wrangler@3.96.0/node_modules/@opennextjs/cloudflare/dist/cli/build/patches/to-investigate/inline-eval-manifest.js:2

import { globSync } from "glob";
         ^^^^^^^^
SyntaxError: Named export 'globSync' not found. The requested module 'glob' is a CommonJS module, which may not support all module.exports as named exports.
CommonJS modules can always be imported via the default export, for example using:

import pkg from 'glob';
const { globSync } = pkg;

tested on node v23.4.0 and 22.11.0
Steps to reproduce
happens when I run pnpm run preview:worker
Here are my scripts:
    "build:worker": "opennextjs-cloudflare",
    "dev:worker": "wrangler dev --port 8771",
    "preview:worker": "pnpm run build:worker && pnpm run dev:worker",
    "deploy:worker": "pnpm run build:worker && wrangler deploy",

Expected behavior
it does not error
@opennextjs/cloudflare version
0.3.0
Wrangler version
3.96.0
next info output
Operating System:
  Platform: darwin
  Arch: arm64
  Version: Darwin Kernel Version 24.1.0: Thu Oct 10 21:03:15 PDT 2024; root:xnu-11215.41.3~2/RELEASE_ARM64_T6000
  Available memory (MB): 65536
  Available CPU cores: 10
Binaries:
  Node: 23.4.0
  npm: 10.9.2
  Yarn: 1.22.22
  pnpm: 9.10.0
Relevant Packages:
  next: 15.1.1 // There is a newer version (15.1.2) available, upgrade recommended!
  eslint-config-next: 15.1.1
  react: 19.0.0
  react-dom: 19.0.0
  typescript: 5.7.2
Next.js Config:
  output: N/A
 ⚠ There is a newer version (15.1.2) available, upgrade recommended!
   Please try the latest canary version (`npm install next@canary`) to confirm the issue still exists before creating a new issue.
   Read more - https://nextjs.org/docs/messages/opening-an-issue

Additional context
No response

I just ran into this issue myself and it seems that pnpm was not resolving the correct version of glob. I was able to work around this by adding an override.
  "pnpm": {
    "overrides": {
      "glob": "^11.0.0"
    }
  }

Looking at the source glob is a devDependency but should probably be a dependency instead.

Ahh, that makes sense. Likely another package has an older version of glob. I'll explicitly install or overwrite as you did. Thank you


The total time of each span seems incorrect

In the summary page (home page)，zipkin will show a summary time of each span below each trace. We have many redis spans each costs 300us+, but in the summary page, it shows redis * 232 5ms,5ms/232=21.5us, so, I think, may be the summary data is incorrect.

As far as I can tell from spot checking with the latest version of Zipkin, it appears the time shown on the traces view for each service name is the longest span duration for that service name, which perhaps isn't apparent.

@liyichao check this out.. it is confirmed (even if not necessarily the right thing to do) #2234

Then I misunderstand the meaning, which is not that straightforward. Close the issue if you think it is not a problem.

there was a bug actually.. https://github.com/openzipkin/zipkin/pull/2235
On Mon, 5 Nov 2018, 18:13 Li Yichao<EMAIL_ADDRESS>wrote:

Then I misunderstand the meaning, which is not that straightforward. Close
the issue if you think it is not a problem.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/openzipkin/zipkin/issues/998#issuecomment-435822018,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAD61ykUWIMnEoDjkwoH0Ably1Ad4hQGks5usA80gaJpZM4HhYJm
.

#2488 will add some clarifications also


Trendline onSelect callback not working

I'm submitting a...

[ ] bug
[ x ] feature
[ ] chore

What is the current behavior
Currently, when a trendline is clicked, it is not selected and the onSelect event is not triggered.
What is the expected behavior
The correct operation would be to fire an event in the onSelect callback.

I have the same problem, did you manage to bypass it ?

Is there any follow-up on this?


Document salt usage

Salts should be unique per-user. This should be in the documentation somewhere.

Can the salt be per-entry?


unit1: Add local video recording

Another pull request to address #22.  The only slight advantage here over #23 is that this one has a smaller diff.  :-)

Hi, sorry for the big delay 🙈 .
Thanks for the work you've done. We don't merge it to the colab because with the updated version of our colab that coming we provide colabgymrender to generate the videos on all colab for the videos 🤗, since it's easier to display.
Have a nice day 🤗


dart2js: World.locateSingleElement misses candidates

Consider:
main() {
  print("Hello".codeUnits.where((e) => e.isEven));
}

The call to where has a receiver type [exact=CodeUnits].
However the call to compiler.world.locateSingleElement(selector, mask) in pushInvokeDynamic returns null.
It appears that locateSingleElement is blind to methods available from mixins.

Fix available: https://codereview.chromium.org/2278143003

Fixed by https://github.com/dart-lang/sdk/commit/7b3bc6933a7dc26e36ac56eef472bde1eedaad1e


Add total number of versions for a modules

should be added to:

[ ] the stats endpoint

I'll get started on this one. @lucacasonato just curious; why not include that information with the get and list endpoints?

It is not needed there


SQL server variable name autocompletion removes @

System information:

Operating system (distribution) and version: Windows 10
DBeaver version: 21.3.3
Additional extensions: none

Connection specification:

Database name and version: SQL Server 2016

Describe the problem you're observing:
When I have a declared variable in the script text, and then I type @ and start typing variable name, it appears in autocompletion. Then I select the suggested value from the autocompletion and press Enter. The suggested value is inserted into the editor but the @ at the beginning of the variable is removed.

Steps to reproduce, if exist:
declare @variable nvarchar(255)
-- then type @ and start typing variable name
-- then select it from autocompletion and hit Enter

Hello @igorzhilin
Thanks for the bug report.
Note: This issue appears if Hippie Engine is enabled.

I noted that the autocompletion also removes the # prefix (SQL server temp tables)

Hello @igorzhilin
Thanks for the note.


PLAT-4119 Remove x-www-form-urlencoded from V4 message spec

@dnsymphony please review

Can you make this PR against rc-current-r49 instead?

Against r49: https://github.com/symphonyoss/symphony-api-spec/pull/13


Add information reg. root & SRS feature to FAQ entry rooted_devices

Description
This PR adds the information, that the new SRS feature won't work on rooted devices, to the FAQ entry rooted_devices.
What was changed?

https://www.coronawarn.app/de/faq/results/#rooted_devices
https://www.coronawarn.app/en/faq/results/#rooted_devices

Screenshot
Pff, that's outdated. Live preview available here:
https://cwa-website-pn8tnqv5g-ein-tim.vercel.app/de/faq/results/#rooted_devices  & https://cwa-website-pn8tnqv5g-ein-tim.vercel.app/en/faq/results/#rooted_devices

@MikeMcC399 Please take a look. I added the new text as an "update", but if you think it would be better to just add it in the normal text I can also do that!

@Ein-Tim
Regarding "Warning without TAN" and SafetyNet #rooted_devices:

The additional text does not connect warning without a TAN to the SafetyNet feature. It would be better if it did so.
In the German text "Sie ihr Gerät" doesn't make sense. It should be "Sie Ihr Gerät". This wording may not be necessary if the additional text is reworked.

Regarding #update_faq:

When the English date is written using ordinal extensions, these depend on the number of the date, and the abbreviation is the last two letters of the ordinal. 1st, 2nd, 3rd, 4th, etc. "21th" is wrong. It needs to be "21st". The CWA blogs all write the date without the letters after the numerals i.e. "Jan 21, 2023", not "Jan 21st, 2023". This is simpler. The FAQs are inconsistent in this respect.
I don't know how @larswmh envisioned this being handled, however it would need to be the date of publication (merge) not the date of the PR submission.
If there are multiple PRs open this could cause date conflicts.

@MikeMcC399
I will add a sentence clarifying why warning without TAN doesn't work.
I won't touch update_faq until there is feedback from the team on how to proceed here!

@Ein-Tim thanks for the PR. I would suggest to swap first and second paragraph.

@dsarkar
Ok, would you leave the Updated out and just put it in the normal text?
Please also give advice on how to handle the updated date.

@Ein-Tim keep "Updated" with the date of  today. I will merge then later today. Will you also update  #update_faq ? Thanks.

@dsarkar

keep "Updated" with the date of today in the first line, in bold, as you have done already. I will merge then later today. Will you also update #update_faq ? Thanks.

I'll do all that! But what do you mean with changing the first and the second paragraph? Putting the information that data donation won't work before the information that warning others won't work?

@dsarkar & @MikeMcC399 Please take a look at corona-warn-app/cwa-website@2d85115 (#3344)! I hope this is what you meant, @dsarkar? If not, let me know!
Live preview is available here: https://cwa-website-pn8tnqv5g-ein-tim.vercel.app/de/faq/results/#rooted_devices  & https://cwa-website-pn8tnqv5g-ein-tim.vercel.app/en/faq/results/#rooted_devices

@Ein-Tim
For questions of style I defer to @dsarkar.
The date is now wrong again, since the PR was not merged yesterday. It is now Jan 24 (or 24th).

@Ein-Tim @MikeMcC399 Thanks for your input here. We can standardise the English date later. I personally don't have any preference. @MikeMcC399 what is your preference?

@dsarkar
I suggest to use the same format for English dates in FAQs as used in the blog, for example:
"January 24, 2023"

The order month, day, year is generally used in American English, however, since it is unambiguous, it causes no problem for British English readers to correctly understand.

Avoiding the use of 1st, 2nd, 3rd, 4th, etc, makes it cleaner and assists non-native English speakers in writing dates correctly. It is also more modern to omit this.

@MikeMcC399 ok, thanks, sounds good. Let's change it then the to the 'simple' format.

link to related Android issue https://github.com/corona-warn-app/cwa-app-android/issues/5813


[R-package] [docs] update cran-comments for v4.5.0 release

v4.5.0 has been accepted to CRAN and is passing almost all checks (one has not been run yet).

ref: https://cran.r-project.org/web/checks/check_results_lightgbm.html
This proposes updating cran-comments.md to indicate that this release was accepted to CRAN.

(one has not been run yet).

Actually two right now:

Actually two right now

Ah yes, you're right. Looks like *-debian-clang was run (successfully) very recently, so NOW there is only 1 left. And I guess any of the "Additional Checks" (https://cran.r-project.org/web/checks/check_issue_kinds.html), whose logs and status are hidden and only reported when they show a problem.


Allows to ask/assign query to the person doesn't even have a role to open query page.

To Reproduce
Steps to reproduce the behavior:

Go to Roles page.
Turn off your all the roles for Query page.
Now log in through different user's credentials
Go to Query Page.
Click on '+Create' button
Now assign that query to first user.

Expected behavior
Should display only those users who has atleast Query page open role.
Screenshots

Temporary closing issue. Feel free to reopen if required


fix global build (fixes #22)

Removed babelify, and just use straight babel. Probably should use a local install of babel though.

Actually, this is going to break tests, @vsavkin and @jeffbcross ... because I changed where the global was installing to Rx3.Observable ... Ideally, it will be Rx.Observable at some point...

Tests are all straightened out now. Much better.


Added Nepali

Added Nepali #76
It would be great if you could add hacktoberfest-accepted label.

Thank you


Create account contract implementation with incremental nonces

To test out alternative replay protection methods, implement an AA version that forces txs to be processed in strict order, using the same mechanism as Ethereum (ie tx with nonce N+1 can only be processed after tx with nonce N). Use a private note to store the current nonce.
Note that, throughout AA, we keep hashing the tx object and emitting it as first nullifier, which already gives us replay protection. The goal here is just to test another approach. As such, this issue is optional and not required to get AA.

As mentioned in the Slack thread, it will be difficult for sequencers to tell how to order the txs without revealing the fact that a group of transactions belong to the same account.

@LeilaWang assuming the current nonce is stored in a note, don't you need the previous tx to be mined in order to send the next one? If you want to consume the previous nonce, you need it to have been added to the tree, which means you need to know the data tree root that contains it, which means you got to wait for that tx to be added to a block. This means the sequencer doesn't need to order anything, since there'll always be at most a single tx for the same account in the mempool.
Am I missing something? Like is there another mechanism for reading private state from a previous tx without it having been mined yet?

Like is there another mechanism for reading private state from a previous tx without it having been mined yet?

There will be a way for people to create "chained txs". We did it in aztec connect already. There will be public data in a tx for sequencers to figure out how to order txs (In AC, it was a backward link referring to a previous tx that has a commitment with the same value). It will leak some information, but not much. The public link will be necessary only when chaining from an unsettled tx. People will only be able to see that some pending txs belong to the same account, and they involve the same state variable in a contract.
But if we apply this to account contracts, it means people will be able to link all the txs belonging to one account together, through out the history. And that could leak a lot. For example, it will be bad to link a deposit from L1 to a withdrawal to L1.
Before we implement this, we need to do what you suggested - waiting for a tx to be settled to create another one.
This is probably a small compromise for modifying the same state variable. We need to wait for the previous tx to settle to interact with the same contract again.
But for account, this will be a bad user experience. We will have to wait for any tx to settle to do anything with our account again.

In AC, it was a backward link referring to a previous tx that has a commitment with the same value)

How does this work at the circuits level? For each read, you'd need to provide either a) a merkle inclusion proof for the data tree if it's mined, or b) the backward link, and the sequencer proves that the tx referenced has been included?

But for account, this will be a bad user experience. We will have to wait for any tx to settle to do anything with our account again.

True, but this will only be a problem if you do want to enforce ordering of your txs.


Is there a way to log into blob storage in a text file instead of xml? And can I append to it ?

I'm using the following for now :
    <appender name="AzureBlobAppender" type="log4net.Appender.AzureBlobAppender, log4net.Appender.Azure">
      <param name="ContainerName" value="testblobcontainer" />
      <param name="DirectoryName" value="logs/" />
      <!-- You can either specify a connection string or use the ConnectionStringName property instead -->
      <param name="ConnectionString" value="UseDevelopmentStorage=true;" />
      <!--<param name="ConnectionStringName" value="GlobalConfigurationString" />-->
      <bufferSize value="5" />
    </appender>

But as expected I'm ending up with MANY xml files. So my question is, can I log into 1 text file? If not, can I at least end up with 1 xml file instead of 1 for each log message?
PS: I tried using the following but didnt work
<appender name="AzureAppendBlobAppender" type="log4net.Appender.AzureAppendBlobAppender, log4net.Appender.Azure">
  <param name="ContainerName" value="testblobcontainer"/>
  <param name="DirectoryName" value="logs"/>
  <!-- You can either specify a connection string or use the ConnectionStringName property instead -->
  <param name="ConnectionString" value="UseDevelopmentStorage=true"/>
  <!--<param name="ConnectionStringName" value="GlobalConfigurationString" />-->
  <bufferSize value="5" />
</appender>

the Append Blob operations are not supported by the emulator currently so appending to one file won't work for me since im using the development storage. Still no idea how to make it in a txt file instead of XML though.


running in open ssl with seed value for crypo function

above is the code for the hmac flow for which i am trying to run a command which is mentioned below
command line:-
openssl dgst -SHA384 -mac HMAC -macopt hexkey: 0b0b0b0b0b0b0b0b0b0b0b0b0b0b0b0b0b0b0b0b0b0b0b0b0b0b0b0b0b0b0b0b0b0b0b0b0b0b0b0b0b0b0b0b0b0b0b0b file.data
Here i want to pass a seed, please provide need a command to pass a seed into the open ssl for which it will be fix into my UVM env.

lfsr_seed is used for SCA countermeasure embedded into HMAC design. There is no corresponding command for openssl.
It's important to note that lfsr_seed does not change the output and only provides some randomness to avoid information leakage from hardware accelerator. Consequently, for UVM, you can safely disregard it since the expected results would remain unchanged.


Feature Request Workflow Triggers/Dependencies on other Workflows

Often time large systems have many workflows. And often you want to have downstream workflows kick off when an upstream workflow completes either success or failure depending on the user's needs.
For example three workflows A, B, and C(Each one in this case belongs to a different git repo):
A->B->C

(Scenario 1) B has declared a dependency to A. If A completes to success or failure(user picks) B is triggered to started. C has declared a dependency to B. If B completes to success or failure(user picks) C is triggered to started.
(Scenario 2)C has declared a dependency to B. If B completes to success or failure(user picks) C is triggered to started.
 No other workflow are started because nothing has declared C an upstream workflow.

I think this use case can be addressed with the implementation of workflow finalizers (#495). Workflow finalizers are a list of templates that would be executed at the end of a workflow, regardless of the success/fail status of the core workflow. Finalizer containers will be provided understanding of the overall status of the workflow (e.g. success/failed), of which it can base decisions off of.
The way I see your use case being solved is:

core workflow fails (or passes)
finalizer step executes with some logic like:

if [ "$WORKFLOW_STATUS" = "Success" ]; then
  argo submit http://some-url.com/workflow-b.yaml
fi

Alternatively, it could use a git input artifact to load the repository of workflows and run argo submit against a file local in the container.

What if I want to redeploy all the services in case of internal library update? How will the pipeline look like?

@jessesuen That sounds like that covers the functionality I was asking for.
Being particular... the issue with this is the workflow that shouldn't even know about workflow B needs to have logic linking it to B. Ideally B should be fired off based on an event of A succeeding or failing.  Granted I'm being picky, just wanted to capture the thought.

Establishing relationships between workflows is something that I feel is out of the scope of the workflow spec definition. The fact that workflow B has a dependency on A, implies some higher level context that spans multiple workflow manifest files. The current design is such that workflows are independent of each other and adding understanding context in the manifest itself will make the logic much more complicated.
That said, if the requirement is that workflow A has no knowledge of workflow B, and should still somehow trigger a submission of workflow B upon completion, I think are other avenues to explore:
One approach (which would require more effort) is to use kuberentes watches to listen for workflow events (i.e. kubectl get wf -w).  The idea is to establish a watch on workflows (filtered by metadata identifying workflows of type A). When a completion event happens for workflow A on the watch, it would programmatically trigger a submit of workflow B. This would keep the workflows independent of each other, but still achieve the event-based triggering that you are looking for.

What if I want to redeploy all the services in case of internal library update? How will services pipelines look like? In case then the library also in argo and I do not want to describe all services in library's pipeline.

@afoninsky can you elaborate on your use case a little more and how it relates to workflow relationships/dependencies? I would like to understand how establishing relationships between independent workflows could solve your problem.

@bobhenkel - I forgot to ask, is there a specific reason that you would like workflow A and B to be kept independent from each other as separate manifests, instead of making A and B just nested workflows in the same manifest?
https://github.com/argoproj/argo/blob/master/examples/nested-workflow.yaml

Nevermind, I forgot about your comment, "For example three workflows A, B, and C (Each one in this case belongs to a different git repo)". This would be a reason why you need to keep the workflows independent from each other.

Duplicating this to issue #495, which has been implemented and merged into master.


Prompt user to open a results archive if none is specified

Currently, HCTL explorer fails is no results archive is provided. Instead, we should prompt an "open file" dialog instead.
This is blocked by #3, because now we would need to open two files simultaneously. Once the model is part of the results bundle, we can open just one file.

This is now resolved.


Remove duplicate example of onShouldStartLoadWithRequest

There is a duplicate example for onShouldStartLoadWithRequest. This removes the duplicate example.

thanks


EDM-573: Run helm dependency build in release job

This way the dependency is bundled inside?, or it's because otherwise it won't work?

Yes, it will be bundled inside. Without it, the helm package step is failing

oops I see. Let's go :D


Ignore Eclipse files.

A PR to add Eclipse files like .project, .classpath, .settings (folder) to git ignore files.

Hi, thank you very much for your interest in contributing to the project!  Please read about submitting contributions here: http://www.quartz-scheduler.org/community/contribute.html  and confirm in a reply comment that you agree to the grant statement under the heading "Agreement and Grant of Copyright"

I emailed my CLA to<EMAIL_ADDRESS>

Signed CLA received. Thanks!

@garydgregory, We have actually merged in a .gitignore at the root of the project already. It should take care of ignoring Eclipse files at any directory level without the need of creating multiple .gitignore. Let us know if that does not work for you.

Hi @zemian
Nope, that's not a good one. Please see my latest commit on this branch for the proper way to ignore Eclipse files in a root-level .gitIgnore.
Thank you,
Gary
PS: I DocuSigned a CLA this morning. Your legal dept. should have it.

Signed CLA received

Hi @garydgregory,
I have tested the master branch with eclipse generated project files and git ignore them all in any directories level. What's the reason not working for you?
Here is output when I loaded quartz project using Eclipse Neon and then output of git status. It's all clean:
zedeng@mydell ~/ossdev/zemian/quartz-pr12-test
$ find . -name '.project' -o -name '.settings'
./.project
./.settings
./checkstyle/.project
./checkstyle/.settings
./distribution/.project
./distribution/.settings
./distribution/examples/.project
./distribution/examples/.settings
./management-quartz/.settings
./management-quartz-impl/.settings
./quartz/.project
./quartz/.settings
./quartz-commonj/.project
./quartz-commonj/.settings
./quartz-core/.project
./quartz-core/.settings
./quartz-jboss/.project
./quartz-jboss/.settings
./quartz-jobs/.project
./quartz-jobs/.settings
./quartz-oracle/.project
./quartz-oracle/.settings
./quartz-plugins/.project
./quartz-plugins/.settings
./quartz-stubs/.project
./quartz-stubs/.settings
./quartz-weblogic/.project
./quartz-weblogic/.settings
./system-tests/.project
./system-tests/.settings
./terracotta/.project
./terracotta/.settings
./terracotta/bootstrap/.project
./terracotta/bootstrap/.settings

zedeng@mydell ~/ossdev/zemian/quartz-pr12-test
$ git status
On branch master
Your branch is up-to-date with 'origin/master'.
nothing to commit, working tree clean

The ignore file is working as expected. Closing this PR.


BREAKING: Make default args parameter required

Fixes https://github.com/dagger/dagger/issues/6051

⚠ Warning
Based on https://github.com/dagger/dagger/pull/6280 so don't merge before that. To review, filter for last commit. Also, perhaps better to merge the breaking change only after the christmas holidays.

What?
The args field of Container.withDefaultArgs is no longer optional:
- ctr = ctr.WithDefaultArgs(ContainerWithDefaultArgsOpts{Args: []string{"foo"}})
+ ctr = ctr.WithDefaultArgs([]string{"foo"})

To unset:
- ctr = ctr.WithDefaultArgs([]string{})
+ ctr = ctr.WithoutDefaultArgs()

This also works (in practice) but it will set CMD to [] rather than truly unsetting:
ctr = ctr.WithDefaultArgs([]string{})

Breaking change
This breaks all current withDefaultArgs usage, in all SDKs since it's a core change.

In draft due to following pending actions, but ready for review in the meantime[^1]:

[ ] Merge https://github.com/dagger/dagger/pull/6280
[ ] Decide when to release[^2]
[ ] Break doc snippet changes into a separate PR[^3]

[^1]: There's a single commit that needs reviewing, choose it from the filter.
[^2]: Probably after the holidays since it's a breaking change.
[^3]: It's so we don't publish that before it's released. Added the changes here to help review what will need to change.

Thank you!!

I had the doc snippet changes split in another PR but the linter fails here so I re-included.

This depends on https://github.com/dagger/dagger/pull/6277 now since modules in docs fail linting.


Weird error message with no commas

I just got:
    • Ambiguous use of effect 'State'
      Possible fix:
        add (Member (State FeederId) Error
                                       InsertTraydatasAndTraytypesFailure
                                       : r1) to the context of
          the type signature

I think this is actually telling me to add ( Member ( State FeederId ) r, Member ( Error InsertTraydatasAndTraytypesFailure ) r)

Can you post some sample code? I feel like I got errors like this with Error in my stack when I used . where I should have used .@ or .@@.

On May 31, 2019, at 04:42, Ollie Charles<EMAIL_ADDRESS>wrote:
I just got:
• Ambiguous use of effect 'State'
  Possible fix:
    add (Member (State FeederId) Error
                                   InsertTraydatasAndTraytypesFailure
                                   : r1) to the context of
      the type signature

I think this is actually telling me to add ( Member ( State FeederId ) r, Member ( Error InsertTraydatasAndTraytypesFailure ) r)
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Unfortunately I've moved passed this error now and got things fixed up. I wanted to provide a repro, but was moving pretty fast. If it comes up again I'll try and narrow it down. FWIW, I didn't need to use .@ or anything.

Looking at the implementation of error:
type AmbigousEffectMessage r e t vs =
        ( 'Text "Ambiguous use of effect '"
    ':<>: 'ShowType e
    ':<>: 'Text "'"
    ':$$: 'Text "Possible fix:"
    ':$$: 'Text "  add (Member ("
    ':<>: 'ShowType t
    ':<>: 'Text ") "
    ':<>: 'ShowType r
    ':<>: 'Text ") to the context of "
    ':$$: 'Text "    the type signature"
    ':$$: 'Text "If you already have the constraint you want, instead"
    ':$$: 'Text "  add a type application to specify"
    ':$$: 'Text "    "
    ':<>: PrettyPrint vs
    ':<>: 'Text " directly, or activate polysemy-plugin which"
    ':$$: 'Text "      can usually infer the type correctly."
        )

it seems like r was simply InsertTraydatasAndTraytypesFailure : r1 - easy to fix by adding parens around :smile:

Easy to fix, but hard to do right!  What we really want is a ShowTypePrec that can insert parens if they're necessary, but I went down that road for a while and didn't have any luck.

Is there even some way to detect partially known list? We would like to not put parens around if it's empty or simply one variable, but we can't really detect the latter, can we?

^ this is why ShowTypePrec didn't turn out to be fruitful.

Aaah :smile:
Well, current state is technically bug - maybe we can sacrifice pretty representation for something that won't puzzle users when gone wrong, like in this case.

Yeah, I guess. But errors like this shouldn't really happen unless you're explicitly putting in concrete type signatures. I'm a little hesitant to uglify all error messages on the happy path, especially since it happens 90%+ of the time.

Crazy thought: we could add a magic type family:
type family IsTyVar (a :: k) :: Bool where
  IsTyVar a = 'True -- or maybe this should be stuck?

and then use this in the error messages to branch. If we intercepted this in the plugin, we could make it do what it says on the tin, but falling back to today's behavior if the plugin isn't enabled.

An equally crazy idea is to show type, then use techniques in https://kcsongor.github.io/symbol-parsing-haskell/ to see if you can find any whitespace. If so, you need to surround it in parens.

If you're going to use a type family, it might be better to have ShowWithParensIfNecessary. If the plugin is on it can see if parens are necessary. If the plugin isn't on, just always add parens.

One more idea! Maybe Effect should have a NeedsParens :: Bool associated type. template-haskell could figure that out.

Unfortunately there is no ShowType that produces a symbol; only a TypeError :( Doing it in TH is a great idea though!

Unfortunately there is no ShowType that produces a symbol

Ah yea, and this is probably for the best :sweat_smile:

Wait, I don't think we can do it in TH. The problem is that the expression e ': r needs parens; it's not a property of the effect, it's a property of whether or not the effect row is entirely polymorphic.

Can't that be solved by having something pattern match on
type family Whatever
  Foo (a ': b ': c)
  Foo '[ a ]

?

@ocharles Type family doesn't reduce if it tries to pattern match on ambiguous type variable - it get's "stuck".
Now I'm thinking if we couldn't somehow traverse list with family that has error as some other argument, which would fire if family chokes on polymorphic "spine" - something like:
type family DecideError errorWithParens list where
  DecideError errorWithParens (x ': xs) = DecideError errorWithParens xs
  DecideError errorWithParens '[]     = errorWithoutParens

Plus we would need some special case on top for single type variables (e.g. r).

Try this :smile: : https://repl.it/@TheMatten/TypeParens

Version modified by kcsongor that should always work

I've added a test for this in #113


codebuild: LinuxBuildImage enum does not resolve correctly

Amazon.CDK.AWS.CodeBuild.LinuxBuildImage.UBUNTU_14_04_DOTNET_CORE_2_1 resolves to "aws/codebuild/ubuntu-base:14.04" instead of "aws/codebuild/dot-net:core-2.1"

I am unable to reproduce the bad behavior using the TypeScript bindings, so it would appear to be an issue either in the .NET bindings specifically, or in jsii generally.

Good (well, kind of) news! I can reproduce the issue on the .NET runtime, minimal repro:
using Amazon.CDK;
using Amazon.CDK.AWS.CodeBuild;

namespace Repro1027
{
    class Program
    {
        static void Main(string[] args)
        {
            var app = new App();
            var stack = new Stack(app, "TestStack", new StackProps());

            new Project(stack, "CodeBuild", new ProjectProps
                {
                    Environment = new BuildEnvironment { BuildImage = LinuxBuildImage.UBUNTU_14_04_DOTNET_CORE_2_1 }
                }
            );

            app.Run();
        }
    }
}

The JSII_DEBUG trace shows intriguing entries:
< {"callback":{"cbid":"jsii::callback::10033","get":{"objref":{"$jsii.byref":"Object@10005"},"property":"environment"}}}
> {"complete":{"api":"complete","cbid":"jsii::callback::10033","error":"System.ArgumentException: Could not infer JSII type for .NET type 'BuildEnvironment'\nParameter name: type\n   at Amazon.JSII.Runtime.Services.Converters.FrameworkToJsiiConverter.InferType(IReferenceMap referenceMap, Type type)\n   at Amazon.JSII.Runtime.Services.Converters.ValueConverter.ConvertAny(IReferenceMap referenceMap, Object value)\n   at Amazon.JSII.Runtime.Services.Converters.ValueConverter.TryConvertPrimitive(IReferenceMap referenceMap, Object value, Boolean isOptional, PrimitiveType primitiveType, Object& result)\n   at Amazon.JSII.Runtime.Services.Converters.ValueConverter.TryConvert(TypeReference typeReference, IReferenceMap referenceMap, Object value, Object& result)\n   at Amazon.JSII.Runtime.CallbackExtensions.InvokeCallback(Callback callback, IReferenceMap referenceMap, IFrameworkToJsiiConverter converter, String& error)"}}

A part of the problem is awslabs/jsii#285, where another issue (which I am yet to put my finger on) in JSII should have made your CDK App crash instead of returning incorrect results.

I reckon I've identified the bug in the C# JSII runtime that causes the incorrect behavior (awslabs/jsii#290).


[Accessibility] A set of fixes linked to the screen readers in the Projects modal.

The items of the My Stuff, Projects and Examples are now announced as selected.
The Create new project and Important project are now announced as button.
The  are now described correctly by the Narrator.
The  keep the focus when selecting a file on Edge and IE.
The messages displayed after a click on the Download button or Import file are now read by the screen readers.
The "Open documentation in a new tab" is now accessible with the keyboard and readable by the screen reader.
A minor bug linked to the tabindex of the tablist has been fixed on Edge and IE.

Linked issues : https://github.com/Microsoft/pxt/issues/2520, https://github.com/Microsoft/pxt/issues/2522, https://github.com/Microsoft/pxt/issues/2524, https://github.com/Microsoft/pxt/issues/2526, https://github.com/Microsoft/pxt/issues/2530, https://github.com/Microsoft/pxt/issues/2544, https://github.com/Microsoft/pxt/issues/2529

@veler,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

Looks good.

Be sure to go back to each of the bugs you've fixed and mark them as fixed. I believe the process is to assign them back to @v-amik, maybe a comment saying you've fixed them. (Note: you will need to bump before @v-amik can verify the issue has been fixed)


[New game]: PROJECT_CONNECT 👾

🎮 Game Request
Game logic and basic description

In project connect, drones have stolen the internet.
It’s up to you in your hover car to go and get it back! First you’ll need to find the ethernet chord and then plug it into the port

Point down the features
Game points
Select program in which you are contributing
GSSoC23
Code of Conduct

[X] I follow CONTRIBUTING GUIDELINE of this project.

/assign

Hey @0xabdulkhalid !
Thank you for raising an issue 💗
You can self assign the issue by commenting /assign in comment 😀
Make sure you follow CODE OF CONDUCT and CONTRIBUTING GUIDELINES 🚀
Don’t Forget to ⭐ our GameZone🎮
Make sure you join our Discord🕹

Hey @0xabdulkhalid ! Thank you so much for your raising the issue💗
It’s all yours, you can come anytime again and make some contributions! 🚀
Alone, we can do little, but together we can do so much! 😇


Enable baselitex on nexys video

@mithro @HackerFoo I have generated a new design with VexRiscV_Linux.
This was achieved with https://github.com/SymbiFlow/symbiflow-arch-defs/pull/1797 to land and the current symbiflow install packges uses the #1797 artifacts.
The design works at 100MHz, as a lower frequency does not work (even with Vivado), as the DDR memtest fails.
There is also an issue with the IDELAYCTRL, which I needed to temporary workaround.
Basically, the litex design contains now two banks of IDELAYs, one for ethernet and one for DDR. The problem is that there is only one instance of IDELAYCTRL which gets replicated by Vivado and not by Symbiflow, causing an issue during placement constraints generation. I will open an issue about this on symbiflow-arch-defs.
The bitstream is able to load Linux, but there seem to be problems with ethernet, as the loading process does not properly work and, once booted with lxterm, pinging the host at <IP_ADDRESS> produces no effect.

@HackerFoo @mithro I got the ethernet working, as a result of fixing IDDR and ODDR primitives in fasm2bels: https://github.com/SymbiFlow/symbiflow-xc-fasm2bels/pull/36
To get this merged and tested we need to merge the following PRs:

Yosys-Plugins SDC fix: This will require an update in symbiflow-arch-defs as well. This solves the issue for which we are getting inexistent clocks in the SDC
IDDR/ODDR fix

With these fixes Linux can boot from ethernet successfully.

@HackerFoo I have updated the test sources and applied some fixes to have the baselitex design working for 200T:

https://github.com/SymbiFlow/yosys-symbiflow-plugins/issues/64 This issue causes to have some missing clock constraints which result in VPR to not optimize the CP during P&R. To overcome this I have transitioned to use the manual SDC file. Once the issue is fixed and the package updated in archdefs, we can go back at having the XDC constraints only.

LOC constraints on the PLLs: https://github.com/SymbiFlow/symbiflow-arch-defs/issues/1750

Duplication of the IDELAYCTRL: https://github.com/SymbiFlow/symbiflow-arch-defs/issues/1804

With these workarounds, the design builds successfully, at least locally.

@HackerFoo There is an outstanding issue with the ODDR preventing ethernet to work with the current status of this PR. Fix is here in arch-defs https://github.com/SymbiFlow/symbiflow-arch-defs/pull/1870#pullrequestreview-549335661.
With that fix in, ethernet works fine, and Linux boots


Breaking change for npm 2.x users with shrinkwrap

This PR introduced a breaking change for npm 2 users that attempt to npm shrinkwrap. This is because the deduped fstream dependency from tar conflicts with the one from tar-pack.
Steps to reproduce with npm 2.14.3:
$ mkdir foobar
$ cd foobar
$ npm install fsevents
$ npm shrinkwrap

Closing as dupe of #100
Waiting for resolution in tar-pack


Expose props of a file

It would be nice to access the props of a file directly, because they contain information that sometimes is useful or necessary to access. For example Nextcloud makes use of this heavily.

ok, i'll take a look

I can also make a PR if you want :) Just wanted to note down, that the feature would be appreciated. I don't know when I will have the time exactly though.

I'm glad you can make a PR😋. I checked Nextcloud. The props you said should be the attribute corresponding to XML. I'm busy with other things now. Later, I'm going to change it and optimize the structure and dependency

I'm making a rewrite/starting from scratch with that library and I decided to not keep my own implementation of WebDAV. As I'll be a heavy consumer of this library, I'll probably contribute some stuff in the future.

I'm very glad you can contribute code😁


php: use a versioned url for install-pear-nozlib.phar

Description of changes
by some bad luck, I tried building php from source a week after pear updated their installer for the first time in two years.
by some good luck, I stumbled upon a place where they have the past installers archived.
this PR keeps it at the current version, only updating it to a URL that gives the version indicated by the hash.

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Hi,
Thanks for this!
Would it require a lot of effort to make the version string a parameter so it can be overridden?

Alea jacta est!


Improve serde-reflection and generate-format

Summary

Fix recursion logic in serde reflection
Add a config object TracerConfig
Use the config object to fix one TODO (giving control on value sampling)
Improve docs in serde-reflection
Add notion of corpus to generate-format.

The latest feature will be used in future PRs possibly adding more YAML files to trace Libra types not related to Libra transactions.
Test Plan
cargo x test -p generate-format -p serde-reflection

Looks good!
@bors-libra r+

:pushpin: Commit 397e11e has been approved by bmwill

:hourglass: Testing commit 397e11e17ea5a7cd2d3344f1ce6e0f2f2edf4ef1 with merge 6fb8a1ac4ae988939f90194fd50a5f6843dc219d...

:sunny: Test successful - checks-actions_land_blocking_test, checks-circle_commit_workflow
Approved by: bmwill
Pushing 6fb8a1ac4ae988939f90194fd50a5f6843dc219d to master...