Modify helm chart: delete validations for certManagerIssuerRef

Because the helm chart generates cert manager issuers and attaches them to certificates, we have to remove validations which fail if we don't specify certManagerIssuerRef.
I investigated that in #17238,

firstly we set the validations to restrict users to set their certManagerIssuer.
But finally, we added template files which generates issuers if users don't specify certManagerIssuer.

I think that we have to delete these validations, otherwise helm can't generate manifest files without specifying certManagerIssuerRef.
Here is the trial on my local:

Prepare test-values.yaml:

test-values.yaml
rollOutCiliumPods: true

cni:
  exclusive: false
  debug:
    enabled: true

prometheus:
  enabled: true

operator:
  rollOutPods: true
  prometheus:
    enabled: true

kubeProxyReplacement: "strict"

k8sServiceHost: "<IP_ADDRESS>"
k8sServicePort: "6443"

bpf:
  masquerade: true

bgp:
  enabled: false
  announce:
    loadbalancerIP: true

ipam:
  mode: "kubernetes"

bgpControlPlane:
  enabled: true

ingressController:
  enabled: true

hubble:
  relay:
    rollOutPods: true
    enabled: true
  ui:
    rollOutPods: true
    enabled: true

bandwidthManager:
  enabled: true

cluster:
  name: "cluster2"
  id: 2

clustermesh:
  name: "cluster2"
  config:
    enable: true
  clusters: ["cluster1", "cluster2"]
  useAPIServer: true
  apiserver:
    tls:
      auto:
        method: "certmanager"

Using this test-values.yaml, I ran helm template:

cd install/kubernetes/cilium
helm template test ./ --values=test-values.yaml > generated_manifests.yaml

Check the output. the following is the part of the output:

generated_manifests.yaml
# Source: cilium/templates/clustermesh-apiserver/tls-certmanager/admin-secret.yaml
apiVersion: cert-manager.io/v1
kind: Certificate
metadata:
  name: clustermesh-apiserver-admin-cert
  namespace: default
spec:
  issuerRef:

      group: cert-manager.io
      kind: Issuer
      name: clustermesh-apiserver-issuer
  secretName: clustermesh-apiserver-admin-cert
  commonName: root
  dnsNames:
  - localhost
  duration: 26280h0m0s
---
# Source: cilium/templates/clustermesh-apiserver/tls-certmanager/remote-secret.yaml
apiVersion: cert-manager.io/v1
kind: Certificate
metadata:
  name: clustermesh-apiserver-remote-cert
  namespace: default
spec:
  issuerRef:

      group: cert-manager.io
      kind: Issuer
      name: clustermesh-apiserver-issuer
  secretName: clustermesh-apiserver-remote-cert
  commonName: remote
  duration: 26280h0m0s
---
# Source: cilium/templates/clustermesh-apiserver/tls-certmanager/server-secret.yaml
apiVersion: cert-manager.io/v1
kind: Certificate
metadata:
  name: clustermesh-apiserver-server-cert
  namespace: default
spec:
  issuerRef:

      group: cert-manager.io
      kind: Issuer
      name: clustermesh-apiserver-issuer
  secretName: clustermesh-apiserver-server-cert
  commonName: clustermesh-apiserver.cilium.io
  dnsNames:
  - clustermesh-apiserver.cilium.io
  - "*.mesh.cilium.io"
  ipAddresses:
  - "<IP_ADDRESS>"
  - "::1"
  duration: 26280h0m0s
---
# Source: cilium/templates/cilium-ingress-service.yaml
apiVersion: v1
kind: Endpoints
metadata:
  name: cilium-ingress
  namespace: default
subsets:
- addresses:
  - ip: "<IP_ADDRESS>"
  ports:
  - port: 9999
---
# Source: cilium/templates/clustermesh-apiserver/tls-certmanager/clustermesh-apiserver-issuer.yaml
apiVersion: cert-manager.io/v1
kind: Issuer
metadata:
  name: clustermesh-apiserver-issuer
  namespace: default
spec:
  ca:
    secretName: clustermesh-apiserver-ca-cert

Please ensure your pull request adheres to the following guidelines:

[ ] For first time contributors, read Submitting a pull request
[ ] All code is covered by unit and/or runtime tests where feasible.
[x] All commits contain a well written commit description including a title,
description and a Fixes: #XXX line if the commit addresses a particular
GitHub issue.
[x] If your commit description contains a Fixes: <commit-id> tag, then
please add the commit author[s] as reviewer[s] to this issue.
[x] All commits are signed off. See the section Developer’s Certificate of Origin
[x] Provide a title or release-note blurb suitable for the release notes.
[x] Thanks for contributing!

Fixes: #22784
helm: Delete validations for certManagerIssuerRef

@nathanjsweet can we get this merged?

/test

There is a minor ci-datapath failure, but it is trivial and cannot possibly be linked to this PR. Marking ready-to-merge.


Add placeholder attributes to release and wiki edit page

Add placeholders to all input fields on these two pages
Add margin before wiki change message
Add ini extension to air, so server reloads when locale files change

Also made the release page more compact by removing field titles and padding:

aria-label added to all relevant fields as well, so there is no concern when they are without a <label> element.


Remove DOCKER_EXECDRIVER env

Since --exec-driver flag has been removed, we don't need environment
DOCKER_EXECDRIVER in integration-cli and Makefile any more.
Signed-off-by: Lei Jitang<EMAIL_ADDRESS>

Thank you!
LGTM

LGTM 🐶

Build failure not related :wink:


Handle async errors

The goal is to resolve the issues in https://github.com/facebook/jest/issues/2059.
General ideas are

Attach uncaughtException and unhandledRejection handlers around the test suite execution

if something is caught

during a spec run: fail the spec
outside a spec, inside a suite: fail the suite

Add support for the signature

test('my test', done => {
  done(new Error('fail'));
});

I have gotten 2. working, but ran into an issue with 1. I am able to catch the exceptions and set the errors from Env.js, but there is currently no way to cancel a spec run. To enable this I would need to change queue_runner.js such that it allows for cancellation. Before I go on I would like to get some feedback on this.
PS: This is the same approach that mocha currently takes to handle these: https://github.com/mochajs/mocha/blob/master/lib/runner.js#L681

I have added some basic cancelation handling into the queue_runner which makes the test in promise_it.test.js fail as expected now.

Hi there! Really looking for this feature in jest. Any hopes of getting this merged soon? Thank you!

This should be ready, I am not sure why the CI is failing yarn test passes fine locally for me

hey @wtgtybhertgeghgtwtg! do you mind giving this a look? :)

It looks like the issue is with resolving jest-runner.  I can't seem to find any other issues like this, although jest-runner is only like six days old.

@wtgtybhertgeghgtwtg any pointers on how I can help debug this?

Nothing particularly helpful.

Find module jest-runner.
Use a package to make promises cancelable instead of rewriting the solution to reduce area.

updated to use p-cancelable
rebased onto master
appveyor is failing with the same issue as on master: https://ci.appveyor.com/project/Daniel15/jest/branch/master

@wtgtybhertgeghgtwtg circle is happy now :) appveyor fail seems unrelated

@aaronabramov @wtgtybhertgeghgtwtg any more feedback? I would really like to see this merged soon as it is currently blocking me from migrating a bunch of projects over to jest.

I was quite heavily against this approach, but I like the solution we ended up with because it captures all uncaught exceptions without overwriting setTimeout etc. for every single test, and something we should do regardless. Good work.
I'll spend some time testing this soon and giving it a thorough review, but we'll try to get this into Jest 21.

This looks solid, so I'm went ahead and merged it, but I'm somewhat scared that this is going to mess everything up in some subtle way and we'll find out in a month or two ;) It's a scary change, but thank you @dignifiedquire for proposing it and making a PR.
If you'd like to catch errors thrown in timer functions, we do have FakeTimers which defines the timers. They are off by default, but what you could do, if you'd like to send another PR, is to change it so that setTimeout and others in a vm context (Every test file is run in isolation) is wrapped with a try-catch block that will catch errors and fail the test. What do you think?

:tada: great to see this merged, I hope the subtly breakages are not too bad ;)
Regarding the timers, thanks for the pointer I'll take a look in the next days and see if I can figure it out.

Published jest@test (Jest 21 beta) so you can give this a try. Also enjoy a substantially faster Jest startup.

@cpojer not sure that publish (or my install) works as expected. I am not getting any jest binary anymore after installing. If I run ls node_modules/jest I get this:
ls node_modules/jest
browser.spec.js fixtures        test.spec.js
config          lint.spec.js    utils.spec.js

not even listing a package.json

@dignifiedquire not sure what you did, but you definitely didn't install Jest. yarn add jest@test works just fine for me:

I think I hit a bug/feature in yarn, running yarn add jest@test with a folder called test just added that folder as a module Oo

ohhh that's possible…

Perhaps this is the wrong place to comment, but I'm fairly concerned about the change in semantics around the asynchronous done function. In my opinion, it's a major breaking change.
If the pre-21 done function ignores arguments, it's simple to supply a bare done reference as the recipient of any callback without concern about the arguments passed to the callback. As soon as it begins interpreting arguments as an error condition, all kinds of existing tests are going to break.
For example, the event argument received by the onPress callback will change this test from passing to failing.
it('fires the onPress callback', done => {
  const wrapper = shallow(<TouchableOpacity onPress={done} />);
  wrapper.find('TouchableOpacity').simulate('press');
});

I realize that interpreting arguments to done makes Jest more consistent with other JS testing frameworks, but I worry that the time for this convergence has sailed, especially since Jest offers done.fail as the preferred method for explicitly failing a test.
Sorry about the drive-by FUD. Just thought I'd mention it because this has become a subject of discussion internally.


Couldn't get initDataTransform working for Fairplay

Have you read the FAQ and checked for duplicate open issues?
yes
What version of Shaka Player are you using?
3.0.1
Can you reproduce the issue with our latest release version?
yes
Can you reproduce the issue with the latest code from master?
no
Are you using the demo app or your own custom app?
custom
If custom app, can you reproduce the issue using our demo app?
not entirely sure how to configure a Fairplay example in the demo app
What browser and OS are you using?
Safari 14.0.3
Mac Os: big surr 11.2.1
For embedded devices (smart TVs, etc.), what model and firmware version are you using?
What are the manifest and license server URIs?
manifestUri = 'https://rest-sgs1.ott.kaltura.com/api_v3/service/assetFile/action/playManifest/partnerId/3209/assetId/340117/assetType/media/assetFileId/811223/contextType/PLAYBACK/isAltUrl/False/a.m3u8'
What configuration are you using?  What is the output of player.getConfiguration()?
I will comment with an example code on the bug below. But essentially, I am trying to setup initDataTransform method for fairplay and this method appears to not be working.
What did you do?

What did you expect to happen?
I expect the initDataTransform method to be called. I have thrown in some console statements and not seeing these resulting in console logs.
What actually happened?
When I try to play then I'm receiving error 3016
As described here https://shaka-player-demo.appspot.com/docs/api/tutorial-fairplay.html
I want to setup the initDataTransform but it doesn't seem to be working.

<!doctype html>

<title>Fairplay Example</title>

Fairplay Example: Shaka

<!doctype html>

    <meta charset="utf-8">

    <title>Fairplay Example</title>

Fairplay Example: Shaka

<video id="video"
       width="480" height="270"
       controls autoplay></video>

@joeyparrish @TheModMaker could you please help me in understanding where i'm mkaing mistake

When you say "it doesn't seem to be working", can you be more specific?  Is your callback not being called?  Is it throwing an error?  If so, what error?
I notice that in your code, your initDataTransform callback refers to getMyContentId(), but that is not defined in the sample code you provided.  Could that be the issue?

@joeyparrish I have made some changes to my code(updated above also) and it started playing something, but getting a green screen during playback.
Attaching below the screenshot of the green screen and also console log

That kind of video artifact is usually a sign of decrypting with the wrong key, or decoding garbage data through some other means.
In this line, is your content ID correct?
          return shaka.util.FairPlayUtils.initDataTransform(initData, 'e2e-postpackager', cert);


Encountered an error

Dear mahendra;
When I run the acdc_data_preparation.py this error comes up:
No such file or directory: 'My Drive/ACDC_DataSet/training/training/Info.cfg'.
Should I combine all info.cfg files from each patient folder and put it into training subfolder?
thanks.

The code should work as it is. No need to combine all info.cfg. Kindly check the data path in your system.


Wrong culopt=screenline when resizing window

Problem:  Wrong culopt=screenline when resizing window.
Solution: Invalidate saved left_col and right_col when width1 or width2
change.

thanks!


Fix issue where default value could be moved

Waiting for tests to run, since apparently make can't find Foundation on my machine anymore.
Changes:

Fixed issue where default value could be erroneously moved in SyncManager::configure_file_system()
SyncMetadataManager no longer has a default value for encryption_key
Added a test and updated existing tests

What? There is no problem with moving from arguments that were initialized by default value.
Default values are initialized at the call site, not (as in some languages) globally.


time_inserted in the 'play' table...

(not a Python guy, not a PostreSQL guy, but understand other languages and DB's - so speak slow and loud)
How is the value in the 'time_inserted' field determined?  It doesn't appear to be a default value on the table or set via trigger, so I assume that it is set by whatever script populates records in that table.  Is that a timestamp based on when the script performed the insert [ i.e. insert into play(time_inserted) values(now()) ], or does that come from the NFL data and is then just pushed into nfldb?
I'm trying to approximate as closely as possible when the real time start of a play occurred (i.e. UTC timestamp associated with the snap of the ball).  Is there a way to come close to this with nfldb?
Thanks in advance.

After getting nflgame setup to auto-populate the nfldb database, it appears that the time_inserted is based on when the records were inserted into the database, and have no connection at all to when the play actually happened.


vrc-get: Install shell completions

Description of changes
Install shell completions directly out of vrc-get for bash, fish, and zsh into appropriate places with the installShellCompletion script. vrc-get also ships with built-in completions for elvish and powershell, but as far as I'm aware, there isn't a way to package completions for those in nix.
Things done
I verified that the package built and ran and there were now shell completion files in appropriate spots. I've been using these changes as an overlay on my system and confirmed that completions work for fish and bash. I tried testing in zsh, but I didn't figure out how to get completions to work in general.

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

I have pushed a change to use stdenv.hostPlatform.emulator to run the built binary. This should be transparent if building natively, and if building cross, handle most cases. If an emulator for the build platform doesn't exist then it gives up on producing shell completions. Though in my testing I didn't find a platform that succeeded in cross-compiling, but didn't have emulation. In particular, cross-compiling for x86_64-darwin from x86_64-linux yields an infinite recursion error, but it does so prior to these changes.

Result of nixpkgs-review pr 308055 run on aarch64-linux 1

1 package built:

vrc-get

meta should be the last attribute
moved postInstall above meta and squashed


BUG: mixed charts: line charts do not appear on horizontalBar charts

Tried adding a line chart to a horizontalBar chart; line does not appear. Line appears correctly on standard bar chart. Using chart.js v2.6.0.
Expected Behavior
Vertical line should appear on horizontal bar chart.
Current Behavior
Vertical line is not present.
Possible Solution
N/A
Steps to Reproduce (for bugs)
https://codepen.io/johnpitchko/pen/OjzGrr
Environment

Chart.js version: 2.6.0
Browser name and version: Chrome 60.0.3112.90
Link to your project: n/a

Closing as duplicate of #4096

Apologies! I didn't see it already existed!

no worries @johnpitchko


#fixing deleted unsafty "stopImmediatePropagation()", and checking which element is clicked track or thumb.

Due to issue  https://github.com/noeldelgado/gemini-scrollbar/issues/55 we've made some fixes to exclude stopImmediatePropagation() and control which element is clicked now (track or thumb), everything is tested on our project.

thanks @artemderzkiy!


Expose advise_random_on_open option

I found this knob to be quite helpful for improving sequential iterator performance.

(fc40d10 updated the comment)

awesome, thanks!


Python 3 Support

Enaml just merged  python 3 support, so this should be added and tested.

Latest version from enaml master doesn't work as is:

(venv) $ adb logcat | grep pyb
10-29 19:44:27.794 29166 29186 I pybridge: Initializing the Python interpreter
10-29 19:44:27.794 29166 29186 I pybridge: /data/user/0/com.example.helloworld/assets/python
10-29 19:44:27.794 29166 29186 I pybridge: /data/app/com.example.helloworld-1/lib/arm
10-29 19:44:28.126 29166 29186 I pybridge: Using <class 'enamlnative.core.loop.TornadoEventLoop'> event loop!
10-29 19:44:28.126 29166 29186 I pybridge:
10-29 19:44:28.323 29166 29186 I pybridge: Starting debug client cwd: /
10-29 19:44:28.323 29166 29186 I pybridge:
10-29 19:44:28.323 29166 29186 I pybridge: Sys path: ['/data/user/0/com.example.helloworld/assets/python']
10-29 19:44:28.323 29166 29186 I pybridge:
10-29 19:44:28.796 29166 29186 I pybridge: ERROR:tornado.application:Exception in callback <functools.partial object at 0x8d1dc840>
10-29 19:44:28.796 29166 29186 I pybridge: Traceback (most recent call last):
10-29 19:44:28.796 29166 29186 I pybridge:   File "~/.local/share/python-for-android/build/python-installs/enaml-native/tornado/ioloop.py", line 605, in _run_callback
10-29 19:44:28.796 29166 29186 I pybridge:   File "~/.local/share/python-for-android/build/python-installs/enaml-native/tornado/stack_context.py", line 277, in null_wrapper
10-29 19:44:28.796 29166 29186 I pybridge:   File "/data/user/0/com.example.helloworld/assets/python/main.py", line 45, in load_view
10-29 19:44:28.796 29166 29186 I pybridge:     with enaml.imports():
10-29 19:44:28.796 29166 29186 I pybridge:   File "~/.local/share/python-for-android/build/python-installs/enaml-native/enaml/__init__.py", line 61, in imports
10-29 19:44:28.796 29166 29186 I pybridge:   File "~/.local/share/python-for-android/build/python-installs/enaml-native/enaml/core/import_hooks.py", line 18, in <module>
10-29 19:44:28.796 29166 29186 I pybridge:   File "~/.local/share/python-for-android/build/python-installs/enaml-native/enaml/core/parser.py", line 3931, in <module>
10-29 19:44:28.796 29166 29186 I pybridge:   File "~/.local/share/python-for-android/build/python-installs/enaml-native/ply/yacc.py", line 3287, in yacc
10-29 19:44:28.796 29166 29186 I pybridge:   File "~/.local/share/python-for-android/build/python-installs/enaml-native/ply/yacc.py", line 1982, in read_table
10-29 19:44:28.796 29166 29186 I pybridge:   File "<string>", line 1, in <module>
10-29 19:44:28.796 29166 29186 I pybridge:   File "/data/user/0/com.example.helloworld/assets/python/enaml/core/parse_tab/parsetab.py", line 29
10-29 19:44:28.796 29166 29186 I pybridge:
10-29 19:44:28.796 29166 29186 I pybridge:     ^
10-29 19:44:28.796 29166 29186 I pybridge: SyntaxError: invalid syntax


Copy types from DefinitelyTyped

https://codesandbox.io/s/seald-io-nedb-pr-lon7m
That sandbox will not run until the types are installed... run bash install.sh
Closes #6

I prefer less dependencies downstream than more dependencies... and as we're looking to end the callback hell, we'll need to modify the types. So...
Should I make a new PR that includes an index.d.ts This would add a few bytes, but now slow anything down or add any dependencies.


lxc: 3.0.3 -> 3.1.0

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/lxc/versions.
meta.description for lxc is: '"Userspace tools for Linux Containers, a lightweight virtualization system"'.

Checks done (click to expand)

built on NixOS
/nix/store/y064m3gvgddccpags7irbfblnidlhvqi-lxc-3.1.0/bin/lxc-attach passed the binary check.
/nix/store/y064m3gvgddccpags7irbfblnidlhvqi-lxc-3.1.0/bin/lxc-autostart passed the binary check.
/nix/store/y064m3gvgddccpags7irbfblnidlhvqi-lxc-3.1.0/bin/lxc-cgroup passed the binary check.
/nix/store/y064m3gvgddccpags7irbfblnidlhvqi-lxc-3.1.0/bin/lxc-checkpoint passed the binary check.
/nix/store/y064m3gvgddccpags7irbfblnidlhvqi-lxc-3.1.0/bin/lxc-copy passed the binary check.
/nix/store/y064m3gvgddccpags7irbfblnidlhvqi-lxc-3.1.0/bin/lxc-config passed the binary check.
/nix/store/y064m3gvgddccpags7irbfblnidlhvqi-lxc-3.1.0/bin/lxc-console passed the binary check.
/nix/store/y064m3gvgddccpags7irbfblnidlhvqi-lxc-3.1.0/bin/lxc-create passed the binary check.
/nix/store/y064m3gvgddccpags7irbfblnidlhvqi-lxc-3.1.0/bin/lxc-destroy passed the binary check.
Warning: no invocation of /nix/store/y064m3gvgddccpags7irbfblnidlhvqi-lxc-3.1.0/bin/lxc-device had a zero exit code or showed the expected version
/nix/store/y064m3gvgddccpags7irbfblnidlhvqi-lxc-3.1.0/bin/lxc-execute passed the binary check.
/nix/store/y064m3gvgddccpags7irbfblnidlhvqi-lxc-3.1.0/bin/lxc-freeze passed the binary check.
/nix/store/y064m3gvgddccpags7irbfblnidlhvqi-lxc-3.1.0/bin/lxc-info passed the binary check.
/nix/store/y064m3gvgddccpags7irbfblnidlhvqi-lxc-3.1.0/bin/lxc-ls passed the binary check.
/nix/store/y064m3gvgddccpags7irbfblnidlhvqi-lxc-3.1.0/bin/lxc-monitor passed the binary check.
/nix/store/y064m3gvgddccpags7irbfblnidlhvqi-lxc-3.1.0/bin/lxc-snapshot passed the binary check.
/nix/store/y064m3gvgddccpags7irbfblnidlhvqi-lxc-3.1.0/bin/lxc-start passed the binary check.
/nix/store/y064m3gvgddccpags7irbfblnidlhvqi-lxc-3.1.0/bin/lxc-stop passed the binary check.
/nix/store/y064m3gvgddccpags7irbfblnidlhvqi-lxc-3.1.0/bin/lxc-top passed the binary check.
/nix/store/y064m3gvgddccpags7irbfblnidlhvqi-lxc-3.1.0/bin/lxc-unfreeze passed the binary check.
/nix/store/y064m3gvgddccpags7irbfblnidlhvqi-lxc-3.1.0/bin/lxc-unshare passed the binary check.
/nix/store/y064m3gvgddccpags7irbfblnidlhvqi-lxc-3.1.0/bin/lxc-wait passed the binary check.
/nix/store/y064m3gvgddccpags7irbfblnidlhvqi-lxc-3.1.0/bin/lxc-usernsexec passed the binary check.
/nix/store/y064m3gvgddccpags7irbfblnidlhvqi-lxc-3.1.0/bin/lxc-checkconfig passed the binary check.
/nix/store/y064m3gvgddccpags7irbfblnidlhvqi-lxc-3.1.0/bin/lxc-update-config passed the binary check.
/nix/store/y064m3gvgddccpags7irbfblnidlhvqi-lxc-3.1.0/bin/init.lxc passed the binary check.
25 of 26 passed binary check by having a zero exit code.
21 of 26 passed binary check by having the new version present in output.
found 3.1.0 with grep in /nix/store/y064m3gvgddccpags7irbfblnidlhvqi-lxc-3.1.0
directory tree listing: https://gist.github.com/e533063d27ffecf6228556098f20e401
du listing: https://gist.github.com/4405f6dd8ba28bff76357a20613eb162

Rebuild report (if merged into master) (click to expand)

14 total rebuild path(s)
5 package rebuild(s)
5 x86_64-linux rebuild(s)
5 i686-linux rebuild(s)
0 x86_64-darwin rebuild(s)
4 aarch64-linux rebuild(s)
First fifty rebuilds by attrpath
haskellPackages.bindings-lxc
lxc
lxd
pipework
python27Packages.lxc

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/y064m3gvgddccpags7irbfblnidlhvqi-lxc-3.1.0 \
  --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
  --option trusted-public-keys '
  r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(r-ryantm's Cachix cache is only trusted for this store-path realization.)
Or, build yourself:
nix-build -A lxc https://github.com/r-ryantm/nixpkgs/archive/1db3185eea44da57fd2008687ca38946f59e6b4e.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/y064m3gvgddccpags7irbfblnidlhvqi-lxc-3.1.0
ls -la /nix/store/y064m3gvgddccpags7irbfblnidlhvqi-lxc-3.1.0/bin

cc @wkennington @globin @fpletz for testing.

I'm interested in when this PR will get merged?

@cw789 have you tested it is good?

@cw789 have you tested it is good?

I'll check it today.

Ok, so I'm still not very deep into Nix - but hope to get better.
I only get it running if I remove the docbook things.
{ stdenv, fetchurl, autoreconfHook, pkgconfig, perl, python3Packages, pam

# Optional Dependencies
, libcap ? null, libapparmor ? null, libselinux ? null, libseccomp ? null, gnutls ? null
, systemd ? null
}:

with stdenv.lib;
stdenv.mkDerivation rec {
  name = "lxc-${version}";
  version = "3.1.0";

  src = fetchurl {
    url = "https://linuxcontainers.org/downloads/lxc/lxc-${version}.tar.gz";
    sha256 = "4d8772c25baeaea2c37a954902b88c05d1454c91c887cb6a0997258cfac3fdc5";
  };

  nativeBuildInputs = [
    autoreconfHook pkgconfig perl python3Packages.wrapPython
  ];
  buildInputs = [
    pam
    libcap libapparmor libselinux libseccomp gnutls
    systemd
  ];

  postPatch = ''
    sed -i '/chmod u+s/d' src/lxc/Makefile.am
  '';

  configureFlags = [
    "--enable-pam"
    "--localstatedir=/var"
    "--sysconfdir=/etc"
    "--disable-api-docs"
    "--with-init-script=none"
    "--with-distro=nixos" # just to be sure it is "unknown"
  ] ++ optional (libapparmor != null) "--enable-apparmor"
    ++ optional (libselinux != null) "--enable-selinux"
    ++ optional (libseccomp != null) "--enable-seccomp"
    ++ optional (libcap != null) "--enable-capabilities"
    ++ [
    "--disable-examples"
    "--enable-python"
    "--disable-lua"
    "--enable-bash"
    (if doCheck then "--enable-tests" else "--disable-tests")
    "--with-rootfs-path=/var/lib/lxc/rootfs"
  ];

  doCheck = false;

  installFlags = [
    "localstatedir=\${TMPDIR}"
    "sysconfdir=\${out}/etc"
    "sysconfigdir=\${out}/etc/default"
    "bashcompdir=\${out}/share/bash-completion/completions"
    "READMEdir=\${TMPDIR}/var/lib/lxc/rootfs"
    "LXCPATH=\${TMPDIR}/var/lib/lxc"
  ];

  postInstall = ''
    wrapPythonPrograms
  '';

  meta = {
    homepage = https://linuxcontainers.org/;
    description = "Userspace tools for Linux Containers, a lightweight virtualization system";
    license = licenses.lgpl21Plus;

    longDescription = ''
      LXC is the userspace control package for Linux Containers, a
      lightweight virtual system mechanism sometimes described as
      "chroot on steroids". LXC builds up from chroot to implement
      complete virtual systems, adding resource management and isolation
      mechanisms to Linux’s existing process management infrastructure.
    '';

    platforms = platforms.linux;
    maintainers = with maintainers; [ wkennington globin fpletz ];
  };
}

@cw789 You had trouble building it? r-ryantm and ofborg didn't have an issue, so sounds like it is probably okay then?
You could try testing it via the instructions in the pull request message at the top.

I tested both lxc and lxd and they seem to work fine.

You could try testing it via the instructions in the pull request message at the top.

Thanks, everything working.

@Mic92 that was fast for LXD, is it OK that I create also lxd-lts? LXD 3.x are feature releases, while LXD 3.0.x is the current LTS one. I will also have to check that lxc is working with lxd-lts

@jokogr how long do lts versions last?

@Mic92 sorry for not catching this earlier, according to this: "LXD 3.0.3 is supported until June 2023 and is our current LTS release, users are encouraged to update to the latest bugfix releases as they're made available."
I will try to package an LTS package later.


avoid using colons in tedge-agent command log file names

Is your feature improvement request related to a problem? Please describe.

The current tedge-agent log file names under /var/log/tedge/agent/*.log use the colon (:) character which results in slight annoyances when selecting files names on the console, or transferring the log files to NTFS storage mediums.
This mostly affects the log files created when the command id is based on a timestamp (e.g. RFC3339).
Below shows an example of some of the files which make use of colons (:):
$ ls -ltr /var/log/tedge/agent

total 80
-rw-r--r-- 1 tedge tedge 14652 Oct  7 06:47 workflow-software_list-c8y-mapper-2024-10-07T06:47:36.491494387Z.log
-rw-r--r-- 1 tedge tedge 10185 Oct  7 06:47 workflow-software_list-c8y-mapper-2024-10-07T06:47:40.881845183Z.log
-rw-r--r-- 1 tedge tedge 10185 Oct  7 06:47 workflow-software_list-c8y-mapper-2024-10-07T06:47:41.047587459Z.log
-rw-r--r-- 1 tedge tedge   519 Oct  7 06:49 c8y_RemoteAccessConnect-2024-10-07T06:49:52.706238934Z.log
-rw-r--r-- 1 tedge tedge 10170 Oct  7 06:53 workflow-software_list-c8y-mapper-2024-10-07T065303.502675425Z.log
-rw-r--r-- 1 tedge tedge 10173 Oct  7 06:53 workflow-software_list-c8y-mapper-2024-10-07T065303.578293335Z.log
-rw-r--r-- 1 tedge tedge   519 Oct  7 06:53 c8y_RemoteAccessConnect-2024-10-07T06:53:08.020012572Z.log
-rw-r--r-- 1 tedge tedge  2487 Oct  7 07:43 workflow-log_upload-c8y-mapper-40290121.log
-rw-r--r-- 1 tedge tedge  2433 Oct  7 07:43 workflow-log_upload-c8y-mapper-40290123.log

See the Additional Context section for more examples where this incompatibility was discovered.
Describe the solution you'd like

Avoid using colons (:) in the log file names to improve portability and usability of the log files.
It should be noted that it might be also worthwhile changing the tedge MQTT command id (which is where the filename is being derived from) to also avoid using colons (:) so that the command id and filename remain in sync.
There are a few options to consider how to format the log file names:

Option 1: Just strip the : character
# Before: workflow-software_list-c8y-mapper-2024-10-03T10:27:52.189032064Z.log
# After:  workflow-software_list-c8y-mapper-2024-10-03T102752.189032064Z.log

Option 2: Use url encoding
# Before: workflow-software_list-c8y-mapper-2024-10-03T10:27:52.189032064Z.log
# After:  workflow-software_list-c8y-mapper-2024-10-03T10%3A27%3A52.189032064Z.log

Describe alternatives you've considered

Additional context

Using Github Action: upload artifact action
The following error was printed whilst trying to upload the log files collected from a thin-edge.io system test run, and upload them to the Github Runner.
The path for one of the files in artifact is not valid: /logs/child01/agent/workflow-software_list-c8y-mapper-2024-10-03T10:27:52.189032064Z.log. Contains the following character:  Colon :

Invalid characters include:  Double quote ", Colon :, Less than <, Greater than >, Vertical bar |, Asterisk *, Question mark ?, Carriage return \r, Line feed \n

The following characters are not allowed in files that are uploaded due to limitations with certain file systems such as NTFS. To maintain file system agnostic behavior, these characters are intentionally not allowed to prevent potential problems with downloads on different file systems.

Below also shows the aforementioned forbidden filepath characters as listed on the Microsoft documentation:

https://learn.microsoft.com/en-us/windows/win32/fileio/naming-a-file

Using iTerm - MacOS Terminal
Selecting the file on the command line is annoying because the default setting in iTerm is to treat the : as a word separator, so double clicking on the file name will only highly before or after the : character. Below shows a screenshot when trying to double click the filename:

It's better to fix the issue at its root., i.e. generation of command identifiers.
I'm against the idea to use url encoding. We just need to use another separator instead of columns :.

I'm against the idea to use url encoding. We just need to use another separator instead of columns :.

Though this raises interesting questions about a similar scenario where the external identity is used to store the child device supported operations (under /etc/tedge/operations/c8y/<external_identity>), where thin-edge.io also uses colons (:).


[IOTDB-655] Update documents of new version TsFile

Update documents of new version TsFile

Update SystemDesign/1-TsFile/2-Format.md and its figures. Add examples for the new structure MetadataIndexNode
Change the config name from max_degree_of_index_node to degree_of_index_node, since degree is the max number of children...

Well down! Nice work. 👍
I just found two tables in doc, which are pageHeader and ChunkHeader need to be changed.

Hi Haonan,
Thanks for your help and detailed review! I've fixed the problems. Please give a second review ; )


Make Rolling Without a Dialog the Default

Is your feature request related to a problem? Please describe.
One of the major points of annoyance in the dnd5e system on Foundry is the amount of clicks one needs to go through in order to get to a chat message, particularly for DMs that are rolling a lot of characters all at once. This problem is way less for this system, but every roll having a dialog popup to raise stakes and all that will still, in the long run, be a LOT of extra clicks. The majority of times, the roll that people want will be the default configuration of the dialog, so needing to accept that dialog is a redundant extra click.
Describe the solution you'd like
I would like to propose the following workflow for a regular roll:

If the user simply clicks on a skill or action, immediately roll with the default roll configuration. No raised stakes, no advantage/disadvantage, just a simple basic roll (we can make this behaviour swappable with the "show dialog" behaviour via a setting if desired)
If the user Shift-clicks (we can and should set this up so the key modifiers are all customisable) a skill or action that has a roll, set the d20 to Advantage and otherwise keep the default configuration of everything. There's always a d20 in a test, so it is by definition the most common target for advantage. Shift-clicking something that has no roll simply doesn't do anything different than a normal click.
If the user Ctrl-clicks a skill or action, same as above, but disadvantage.
If the user R-clicks (or some other key, doesn't matter) a skill or action, raise the stakes on the roll and otherwise keep the default configuration of everything
If the user Alt-clicks a skill or action, show the full roll dialog and allow 100% customisation of the roll as it is now (or vice versa if the setting proposed above is a thing we want)

In this way, we cover the bases for all the most common types of roll, while only requiring a single click for the user to get what they want. The dialog remains an option for comprehensive customisation of the roll.
The simple way to do this would be to pass advantage/disadvantage/raise stakes as config options from a preliminary function that detects if key modifiers are pressed when the click is made.  The config should also have a fastForward value that is set to true by default and false if the relevant modifier is clicked. This also opens up these options for macros in future, so a user can simply call with the relevant config options to get what they want without even click modifier keys.
Additional context
I have some history with this from the dnd5e side, as developer for Ready Set Roll, which a lot of people consider a must have to skip the billion dialogs that dnd5e forces on you. What I'm proposing is in-line with the behaviour that module creates for rolling workflow, so it is a very tried and tested method.

Just a note that, having some experience with this particular aspect of a system already, I wouldn't mind doing it myself (time allowing), but I would like to put the point forward for discussion first

Hello, I am a person without any experience in the art of programming, but I would like to give my opinion about it. I like the idea that is proposed but perhaps it could be the opportunity to solve the biggest weakness of foundry with respect to the players to make rolls using your phone, as you see this will be a problem with the proposed method, could be that instead of requiring keys would be a small menu that arises by holding down the mouse button (advantage and disadvantage), this would solve the problem of both parties and would also be much faster to learn for beginners.

For the sake of record:
There has been a fair amount of discussion on this on the discord, but the general feeling seemed to be that [for now] we think having the modifier keybinds is helpful and even a setting to let users skip the dialog is great, the default should be to show the dialog, especially as in this system 'vantage isn't necessarily always placed on the d20.
Judging by the #117 changelist this is what Mango has worked towards.

Correct, though a slight addendum that we don't want to have modifiers for all kinds of advantage, just the d20. If advantage on others are desired then the config can always be used, or in the future retroactive roll editing


Add an example for foreground service

Hi @dvmatyun ,
Could you add an example showing how to make the socket a foreground service and switch between service and normal implementation when app is in background/closed and when it is active?

hi @sagar1garg , as far as I know mobile OS (android & iOS) closes the socket connection itself when app is in the background, so you can not rely on stable connection when app is not active. For that purpose, I suggest you to use some scheduling triggers like local push notifications. If you have other information regarding background connection let me know.
Later maybe I will add some functionality for "background synchronization" with server, but I doubt that it will be using webSocket connection (because Operating system just does not allow that). Let me know if you have any questions or maybe I got your idea wrong.


insert_into_file print warning when change is already done

If I use append_file or insert_into_file in a generator, and I execute generator twice, then File unchanged! The supplied flag value not found! warning is printed.
Is this the expected behavior. It sounds curious to me. Why doesn't it print identical or unchanged without warning, since content.include?(replacement) returns true?
Related to #683

Good point. Let's remove that warning. Can you open a PR?

Yes, I can take a look in the following days.

I opened a PR :)

Let me know if you want some changes on my PR 🙂. I may have some time for the following weeks

Hi guys! This is a warning that we're running across as well for https://github.com/solidusio/solidus_dev_support. Not a big deal, but it is a bit jarring for users, as it looks like something went wrong. Glad to see there's a PR open, if there's anything I can do to help here please let me know :)

I think here is another false positive for this warning: https://github.com/stimulusreflex/stimulus_reflex/issues/118


Add support for .eh_frame unwinding sections

Not ready to land yet -- going to need to rebase.
Take a look at the code if you want.
Mostly trying to guage whether coverage is going up or down, and see which branches I might have missed unit tests for.

... and apparently CI won't run until I resolve the conflicts. Will try and do that tomorrow.

Ok, rebased! Not as bad as I was afraid of.

I think this is ready for review, care to take a look @philipc? Thanks!

Coverage increased (+0.5%) to 93.614% when pulling 4179657a082b48fcc21f2e43ed38829502e32864 on fitzgen:eh-frame into 799da952d4b83d53c39698f74c89bd2a43e19ff4 on gimli-rs:master.

I'm going to land this now, but this is going to need to undergo a bit more refactoring to deal with .eh_frame in the wild (and ealier DWARF versions). I'm working on it.


Domain invalid

Visiting codingcareer.com does not display this application. Instead, it shows "This domain name is for sale."
The coding-career.com in the README is confusingly different than the repository name, but also does not exist.
fix plz i want to stalk career growth topics

no money to fix haha


Is this package support for iOS?

I am using this package for hybrid app but this is not working in iOS.can you please help me out.

Hi @Sravankumar28,
Not currently but we're planning for it in future.

I am using Flutter Form Builder in an app that is compiled to iOS and Android.  What is the issue?

Closed since it's a duplicate of #22. PRs are welcome


cyctl reconcile module command

Is your feature request related to a problem? Please describe.
Implement a cyctl subcommand to trigger module reconciliation. The subcommand does the same thing as the reconcile button on the module details page.

The subcommand should look like:
cyctl reconcile <module name>

Describe the solution you'd like
You can trigger the reconciliation by fetching the module, adding the cyclops/reconciled-at with the current timestamp and updating the Module using a kubernetes client.
You can check the implementation of the same reconciliation triggering in cyclops-ctrl here.

@petar-cvit I am interested to work on this Issue.
I have to create  a command and get the module name and have to update with the annotation implemented similar to the reconciliation triggering in cyclops-ctrl ?

@Abiji-2020 will assign you to the issue.

I have to create a command and get the module name and have to update with the annotation implemented similar to the reconciliation triggering in cyclops-ctrl ?

Yeah, exactly


Test Harness TC-ACE-1.5

TH Version: v2.7-official-TE
Sha: 821e3f8
When I try to run for example this test TC-ACE-1.5
It breaks when TH2 tries to connect
In the logs I noticed that the TH2 tries with a different code and therefore doesn't work.
Do I have to set something?
UI_Test_Run_2023_5_22_11_49_35.log

@bzbarsky-apple
My payload is MT:KKBA0OMV17EV670TF00
and the discriminator is 1863
i tried adding them as test_parameters and now the TH2 communicates with the device, but unfortunately it still doesn't work, it doesn't seem to use the correct PAA
The only other parameter I'm missing is the PakeVerifier I'm trying to configure
./spake2p gen-verifier -o - -i 1000 -s "xkmqf86IYJcYNf7+4PsyeAVjsnGu5Uwpz+XWyFpIMmQ=" -p 19628801 --out -
Index,PIN Code,Iteration Count,Salt,Verifier
0,19628801,1000,xkmqf86IYJcYNf7+4PsyeAVjsnGu5Uwpz+XWyFpIMmQ=,6hDTk1Kv+m5FBwvjulQRUBu7sDCUh/6Eb9lZMYWjmpUE3Yjk1YNX5HRbGsxoxl9Jvl39NZOG7llahxI8p9kQHaC/8YGM8aIaj75dkS+tGk7UnIij5/MBZo5suFgn0UPzEg==

@bzbarsky-apple
If I run the same test not through the browser, but from the terminal on my raspberry pi the test passes
./chip-tool tests Test_TC_ACE_1_5 --nodeId 1  --paa-trust-store-path /var/paa-root-certs/ --payload MT:KKBA0OMV17EV670TF00

@bzbarsky-apple
i also tried to remove the certificate and using the test one it works also from browser as well as from terminal

My payload is MT:KKBA0OMV17EV670TF00
and the discriminator is 1863

This all sounds like questions about the test harness, which doesn't even live in this repository.  Please file the issue in https://github.com/CHIP-Specifications/chip-certification-tool-frontend or https://github.com/CHIP-Specifications/chip-certification-tool

@bzbarsky-apple
I think so, but I don't have access to this repository, I tried to write to CSA, but no one replies.
Couldn't you suggest how or who to ask?
Thank you

@cjandhyala Please see above.

@stefano055415 There is a bug in the TC-ACE-1.5 automated script, so we requested everyone to follow the steps in the verification steps doc. Pls reach to me in the slack, if you have any more questions.

@cjandhyala
Hi, in reality the problem also occurs with other TC for example TC-CADMIN-1.16, in practice always if a TH2 is used in the test
I don't know if you are the right person to ask, but to work better and not ask for information in wrong places, I would like to know if I can be added to the repo: https://github.com/CHIP-Specifications/chip-certification-tool
or if you can suggest someone who can add me
Thank you


Reset glyph's cachedTint in BitmapText#updateText() (#58)

This PR changes: It’s a bug fix (#58)

Closes #58


Improve performance of escape sequence processing

(A follow-up from #235)
After #291, we'll have functional escape sequence processing based on a bit of manual parsing and some regular expressions (see TokenExtensions::UnwrapStringLiteral).
These regular expressions create some problems performance-wise: I believe the result could be improved both allocation-wise and performance-wise if we visit the initial string exactly one time.
Maybe we should create some kind of micro-parser for string literals?

Closed by #557.


Ensure that field components do not get recreated when state changes

This is a result of pairing with @ef4 yesterday -
The issue we were solving is a bug where the "contains many" editor component will lose focus after inputting a single character, making it impossible to write a word in one go:

It turns out the whole editor component got replaced in DOM after state changes. The fix is that we now cache the components by field name, using the same technique we already use in getBoxComponent.
We were thinking about the possibilities about adding a test for this, but we don't actually know enough about the source of this problem. The described bug reproduction is one way to see the bug, but we assume that this is only one case among many, and that the glimmer engine is usually smart enough to not recreate components (but not in this case)...

Hm, looks like this breaks a couple of critical tests. I am not sure why the fields are not updating when assigning to the card instance programatically. I'm checking but have no good clue for now

Ready for review - thanks @ef4 and @habdelra! It's great we have such good test coverage, they helped to uncover reactivity problems after addressing the caching problem.


JS auth support with basic-auth-connect

I would like to use this webapp in order to monitor my servers (at work). But, I need a way to authenticate users.
So I submit with modesty a PR for the JS server in which I use the basic-auth-connect lib.
Also, I think it will be great to use the node-config lib, in order to configure things depending of the environment (NODE_ENV variable).
Finally, I set a default user/password => it can be commented or changed.
So, in this PR (for the JS server only) :
The default port changed to 8080 (see config/default.json)
The default user is admin/th3Sup3rAdm1nPa55w0rd
I add some tests

@bcolucci, the pull request is appreciated, sincerely. It looks like you have put in some good thought into this. However, unfortunately, there are a few good reasons this won't be merged:

Providing any sort of "auth" solution indicates that Linux Dash comes built-in with ample security. It is far clearer and safer to be explicit about not implement auth. Otherwise the project takes on the responsibility of all future security vulnerabilities.

It adds complexity to the Linux Dash. Linux Dash is responsible for providing a simple dashboard for your Linux OS and only that. To add an authentication layer is beyond the scope of that goal. There are plenty of ways to add your own custom security layer on top of a plain Linux Dash instance.

Submission of code with hard-coded credentials is a red flag.

I encourage you to maintain a fork as I am sure others will find your code useful.


Enhancement: Update localheinz/composer-normalize

This PR

[x] updates localheinz/composer-normalize

💁♂ For reference, see https://github.com/localheinz/composer-normalize/compare/1.0.0...1.1.0.

@keradus
I don't mind - personally, I never run
$ composer update

to update a dependency (unless in CI), but only
$ composer require

From my point of view, this documents nicely the minimum required version, that is all.

From my point of view, this documents nicely the minimum required version, that is all.

keep in mind:

We don't update anything (code/config) to benefit from new version. What's the value of bumping it ?

would PHP CS Fixer run with localheinz/composer-normalize 1.0? yes. 1.1? yes. 1.x? yes...

Ha, no problem!


Bump Dependencies #2053929915

Bumps dependencies for product-is. Link : https://github.com/wso2/product-is/actions/runs/2053929915

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.jenkins-is-staging seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Error: chequebook init: storage: not found

Summary
I've changed the Docker tag from 0.5.3 to 0.6.0 before reading the upgrade guide, and started getting these errors:
Error: chequebook init: storage: not found

The main log reads this:
time="2021-05-22T22:45:28Z" level=info msg="version: 0.6.0-67cc8f24"
time="2021-05-22T22:45:28Z" level=info msg="using swarm network address through clef: %redacted%"
time="2021-05-22T22:45:28Z" level=info msg="swarm public key %redacted%"
time="2021-05-22T22:45:29Z" level=info msg="pss public key %redacted%"
time="2021-05-22T22:45:29Z" level=info msg="using ethereum address %redacted%"
time="2021-05-22T22:45:29Z" level=info msg="debug api address: [::]:1635"
time="2021-05-22T22:45:29Z" level=info msg="using default factory address for chain id 5: 73c412512e1ca0be3b89b77ab3466da6a1b9d273"
time="2021-05-22T22:45:29Z" level=info msg="waiting for chequebook deployment in transaction %redacted%"

I've followed the guide and restarted containers after following the steps (removed the localstore folder's contents,, added full-node: true to bee.yaml), but the error persists.
What do you recommend?

I'm having the same error. Same situation, just updated, since apparently when I had installed 0.6 was not the version in the docs last week. Been trying to join the network for a week now :(

Here is some additional information of mine:
Debian 10, installed via the .deb package
; v0.5.3 upgraded to 0.6.0 after I kept failing to create chequebook after a few days of waiting for transaction. Did not manually delete any folders.
Been getting a loop between these errors:
'Error: init chain: is synced: no trusted canonical hash trie'
'Error: chequebook init: storage: not found'
'Error: factory fail: getDeleteStateObject (73c412512e1ca0be3b89b77ab3466da6a1b9d273) error: no suitable peers available'
Here is my config:
/etc/bee/bee.yaml

```
## Bee configuration - https://gateway.ethswarm.org/bzz/docs.swarm.eth/docs/installation/configuration/
HTTP API listen address (default ":1633")
api-addr: :1633
initial nodes to connect to (default [/dnsaddr/bootnode.ethswarm.org])
bootnode: [/dnsaddr/bootnode.ethswarm.org]
cause the node to always accept incoming connections
bootnode-mode: false
enable clef signer
clef-signer-enable: true
clef signer endpoint
clef-signer-endpoint: /var/lib/bee-clef/clef.ipc
config file (default is /home//.bee.yaml)
config: /etc/bee/bee.yaml
origins with CORS headers enabled
cors-allowed-origins: []
data directory (default "/home//.bee")
data-dir: /mnt/bee-data
db capacity in chunks, multiply by 4096 to get approximate capacity in bytes
db-capacity: 10000000
number of open files allowed by database
db-open-files-limit: 1000
size of block cache of the database in bytes
db-block-cache-capacity: 33554432
size of the database write buffer in bytes
db-write-buffer-size: 33554432
disables db compactions triggered by seeks
db-disable-seeks-compaction: false
debug HTTP API listen address (default ":1635")
debug-api-addr: <IP_ADDRESS>:1635
enable debug HTTP API
debug-api-enable: true
full-node: true
disable a set of sensitive features in the api
gateway-mode: false
enable global pinning
global-pinning-enable: false
NAT exposed address
nat-addr: ""
ID of the Swarm network (default 1)
network-id: 1
P2P listen address (default ":1634")
p2p-addr: :1634
enable P2P QUIC protocol
p2p-quic-enable: false
enable P2P WebSocket transport
p2p-ws-enable: false
password for decrypting keys
password: ""
path to a file that contains password for decrypting keys
password-file: /var/lib/bee/password
amount in BZZ below the peers payment threshold when we initiate settlement (default<PHONE_NUMBER>000)
payment-early:<PHONE_NUMBER>000
threshold in BZZ where you expect to get paid from your peers (default<PHONE_NUMBER>0000)
payment-threshold:<PHONE_NUMBER>0000
excess debt above payment threshold in BZZ where you disconnect from your peer (default<PHONE_NUMBER>0000)
payment-tolerance:<PHONE_NUMBER>0000
ENS compatible API endpoint for a TLD and with contract address, can be repeated, format [tld:][contract-addr@]url
resolver-options: []
whether we want the node to start with no listen addresses for p2p
standalone: false
enable swap (default true)
swap-enable: true
swap ethereum blockchain endpoint (default "http://localhost:8545")
#swap-endpoint: https://rpc.slock.it/goerli
swap-endpoint: https://goerli-light.eth.linkpool.io
swap factory address
swap-factory-address: ""
initial deposit if deploying a new chequebook (default<PHONE_NUMBER>00000000)
swap-initial-deposit:<PHONE_NUMBER>0000000
enable tracing
tracing-enable: false
endpoint to send tracing data (default "<IP_ADDRESS>:6831")
tracing-endpoint: <IP_ADDRESS>:6831
service name identifier for tracing (default "bee")
tracing-service-name: bee
log verbosity level 0=silent, 1=error, 2=warn, 3=info, 4=debug, 5=trace (default "info")
verbosity: info
send a welcome message string during handshakes
welcome-message:
</p>
</details>

@Porco-Rosso Something tells me this won't solve your problem, but when you upgrade from 0.5.3 to 0.6.x, you need to delete your /localstore folder, you can't keep it.

@Porco-Rosso Something tells me this won't solve your problem, but when you upgrade from 0.5.3 to 0.6.x, you need to delete your /localstore folder, you can't keep it.

In fact, the localstore is no longer there when this error is reported, you can delete the $DATA_DIR (or ~/.bee) directory and it will work fine, but I don't know what the consequences will be (mine is a new node so it doesn't matter)

Can confirm that deleting localstore didn't help, but deleting statestore did. The consequence of that was losing current progress towards cheques, but eh, at least the nodes work now.

I didn't delete anything because it does not say to do so in the automatic update procedures

Can confirm that deleting localstore didn't help, but deleting statestore did. The consequence of that was losing current progress towards cheques, but eh, at least the nodes work now.
Also I've noticed that despite my migration script removing localstore/*, the problematic nodes had the localstore folder completely missing for some reason, though re-creating it didn't help. I'm not sure if its Bee that deleted it or if I messed up; the nodes where this occurred are randomly scattered across the cluster while my scripts are iterative. Could there be a failure condition during migration using Docker that could end up removing the localstore folder if the container was shut down or something?
Is it possible to somehow manually modify statestore files to resolve this problem in the future without removing them completely, perhaps?

Thanks, I've deleted it and now a new chequebook is being deployed. Unfortunately that probably means I am back to the end of the gETH tx queue... was worried I wouldn't have enough gbzz to deploy but that doesn't seem to have been the case. Now will go back to waiting.
Still getting error while checking pending transactions: no trusted canonical hash trie but that might be due to the goerli node I am using. Will give it some time and see what happens. Meanwhile missed out on some potential mining.

after switching to Infura, which seemed to have helped with the node connection, I am now getting:
error while checking pending transactions: header not found
Guess I'll try to wait this one out as well

Ended up wiping my statestore and keys and trying again. This time it succeeded...


Merge pull request #1 from poldracklab/master

merge

Changes proposed in this pull request

Documentation that should be reviewed

I think something went wrong here.


offical books page per user.

For Feature Requests
Desired Feature:
I want to have a books page for every user like "/books" , but at current every user's page is not what I want .  for example : " /user/3"
social  purpose:   Every one has his own book page and could show it to public as a seperate space.  And at the public index page,  we can see  most important books or articles in different way.
In fact, I want to see a site, which  every one can build his own knowledge base / architecture  by create books,  and every one could see the important content from others.  all is public.
For Bug Reports

BookStack Version (Found in settings, Please don't put 'latest'): N/A
PHP Version: N/A
MySQL Version: N/A

Expected Behavior
Current Behavior
Steps to Reproduce

Thanks for your request @junlicn.
I'm going to close this unfortunately, due to straying a little too far away from the core idea of the project.
You may actually being able to emulate what you're after using some of the "create-own" role permissions and the future API could help automate things like user book creation.


test (non)equality for alt_string implementation

Add a bit more tests for alt_string implementation

Coverage remained the same at 100.0% when pulling cd28d872e70072fba0eb3b61143c0b7af7563136 on agrianius:develop into e830bc502fe38852654a1f03f963001fecb54a86 on nlohmann:develop.


Add HTTP metrics for in-flight requests

Signed-off-by: Douglas Camata<EMAIL_ADDRESS>

[x] I added CHANGELOG entry for this change.
[ ] Change is not relevant to the end user.

Changes
This was split off of #5424.

Add a new metric called http_inflight_requests in the default handler instrumentation to measure the amount of inflight HTTP requests.

Verification
Manual testing.

@jessicalins @saswatamcode: please take another look at the PR whenever you can.

@matej-g can you merge this, please? 🙏
Or we are waiting for other official members of the team to review?

Hm, indeed lint error is weird. Something easy we can check is rebase to latest?


Horizontal Scroll

On any screen resolution there is about 20 pixels of horizontal scroll
There is about 20 pixels of whitespace right of the website

Confirmed on both Firefox and Chrome.

Fixed width issue and prevented x axis scrolling. ab457b Confirmed working correctly on Chrome, Firefox, Safari and on iPhone 6.

Awesome!
Thanks


webview memory not freed

webview memory is not freed when tab is closed. When a tab is closed I do a dispose method to remove all event handlers, remove webview from visual tree and set it to null but garbage collector doesnt collect it.

Do you accept contributions?

yes i do however the github repo is outdated by a months worth of updates so im going to fix that today

Could you assign me to this issue?

Since EdgeHTML is written in C++, GC will not clean it up. Also, the WebView object is just a wrapper around the rendering engine. WebView doesn't provide a way to clean up the memory as it can be used again by another app. It gets cleaned up eventually but if you want to clean up instantly you could navigate to 'about:blank' multiple times. Note that the content in a web view is rendered by an external process but the web view itself is rendered by your process.

interesting i will try that thanks for sharing!

hmm seems like navigating to about blank multiple times didnt fix it. if webview is in c++ there could hav ebeen a method to free it but i dont know c++

hmm seems like navigating to about blank multiple times didnt fix it. if webview is in c++ there could hav ebeen a method to free it but i dont know c++

Atleast try it 10 times and check the usage in Swift Browser's task manager. WebView is pretty smart and it will automatically remove unused content when more memory is needed. It doesn't provide a dispose method to free and I don't know why.

ok i will try it

thanks for sharing i will try it out using the code from the link

it works the memory is freed but some 50 mb still remains but its a vast improvement. memory went from 50mb to 700mb and then shrank to 100mb. im closing the issue now as it seems to be fixed. thank you for your help i will credit you.


[BEAM-8010] Remove translation of bounded reads from portable Flink Runner

In the course of BEAM-6730 we added a way to Runner-translate bounded and
unbounded Reads in portable pipelines. However, bounded Reads are already
supported via Impulse + BoundedReadViaImpulse.
This can be fixed by removing the bounded read translators from portable
pipelines.

Run Java Flink PortableValidatesRunner Streaming

Run Java Flink PortableValidatesRunner Batch


Add identifier term that isn't a doi

Hello,
I wanted to recommend the usage of CITATION.cff in academic workflows, but I was surprised that there isn't any term for software identification that isn't a DOI.
Even if the usage of a DOI is common and is suggested as a best practice by the SCIWG, there are other ways to identify software, for example:
Wikidata entity identifiers (Q828742 for Scilab at https://www.wikidata.org/wiki/Q828742)
ascl identifiers  (ascl:1908 at http://ascl.net/1905.018)
swMath identifier (swMath-id:834 for Scilab https://swmath.org/software/834)
handle
sha1
and the swh identifier (hashed and resolved by Software Heritage)
Here is the last version captured on SWH:
swh:1:rev:91fbfb81b72b3d09175fec6a06a5567dac820bd5;origin=https://github.com/scilab/scilab
The panorama of identifiers is broad and will be discussed on the joint FORCE11 & RDA Software Source Code Identification Working Group SCID WG
I would like to propose having a term that can contain a list of identifiers, this will enable capturing more metadata and linking it accordingly on different platforms.
What do you think?

Hi Morane, thanks for your comment. I agree that the schema should allow for other persistent identifiers than only DOIs. I'm not sure though if a list of persistent identifiers is the way to go. The reason being that while the list items are surely intended to point to various copies of the same thing, I anticipate there will be inconsistencies between the copies, which defeats the purpose of persistent identifiers. Also, from the perspective of whoever is uploading the digital object, one copy is probably preferable.
Be aware that I anticipate we will only be able to deal with this issue after we are done with https://github.com/citation-file-format/citation-file-format/issues/71 and the corresponding PR https://github.com/citation-file-format/citation-file-format/pull/77, which have us near the point of choking... @sdruskat and me are planning to set aside some time in July to work on those.
TBC!

Hi @jspaaks ! Thank you so much for your quick answer.
First it's great we agree that the schema should allow different persistent identifiers.
The term used on CodeMeta is identifier and it might be easier to use the same term.
About the list, you wrote:

I'm not sure though if a list of persistent identifiers is the way to go. The reason being that while the list items are surely intended to point to various copies of the same thing, I anticipate there will be inconsistencies between the copies, which defeats the purpose of persistent identifiers. Also, from the perspective of whoever is uploading the digital object, one copy is probably preferable.
I would love to continue this discussion!

The identifiers I have put as examples, are in most part project identifiers that do not identify a specific version. This point is a great debate on how we should identify software, do we produce a high level identifier like a doi for each artifact and each version of a software even if the metadata stay unchanged?
The problem of identifying a version is that by changing the content in the CITATION.cff file, the version changes as well, a problematic race condition.
I understand this might not be a good place for the debate and we should wait for the SCID WG recommendations.
So if you can add the identifier term for a unique PID that isn't a DOI, this would be satisfying.
This is not urgent, but I can't recommend CFF before that, because we do not work with DOI identifiers.
Cheers,

I agree CFF should also use the identifier keyword if we can.
BTW the race condition you speak of has been noted, we discussed it here https://github.com/research-software-directory/research-software-directory/issues/77  That thread offers some partial solutions, but note that the "admin interface" I mention there is something specific to the Research Software Directory, so those options are not viable for a general solution.

Thanks for the explanation about the tool and how you deal with the race condition.
I'll be watching for updates on the identifierterm.
Anyway, I think that CITATION.cff is a more friendly way of keeping metadata and it can be of great use in the scientific community. Especially in publication and archival workflows.
Here is an example of an archived piece of scientific software in the French national archive (HAL):
https://hal.inria.fr/hal-01882337
The metadata is inserted by hand and transmitted to Software Heritage in CodeMeta vocabulary.
It can be a great asset to have the metadata included in the content in a friendly format.

Thanks @moranegg! I've spoken to people from other communities as well, and identifierwill definitely come in the next version, as its badly needed.

Thank you @sdruskat, I will be waiting for the next version.

Further to this, @mdolling-gfz has suggested to type the identifier in a separate field. His suggestion was to do
identifier:
  - type: DOI
  - path: foo.bar

I shy away from introducing that extra level and think that - while having an identifier type would certainly be helpful to make the identifier (more) machine-actionable, an extra field would be enough so:
identifier: 10.1234/1m4D01
identifier-type: doi

Ideally, the identifier-type value would be an enum.
I guess we could start by building a list of common identifiers, then accept others via issue/PR.
WHat do you think, @jspaaks & @moranegg?

I really appreciate taking the time to ask here.
I agree with @mdolling-gfz and I will back that with other uses in different vocabularies.

From schema.org Software Source Code class (https://schema.org/SoftwareSourceCode):

identifier
PropertyValue  or  Text  or  URL
The identifier property represents any kind of identifier for any kind of Thing,  such as ISBNs, GTIN codes, UUIDs etc. Schema.org provides dedicated  properties for representing many of these, either as textual strings or  as URL (URI) links. See background notes for more details.

When using PropertyValue you can distinguish the identifier type:

"identifier": {
"@type": "PropertyValue",
"propertyID": "OCoLC",
"value":  "889647468"
},

On Wikidata a software item can have many identifiers, including the entity identifier Qxxx
Here an example: https://www.wikidata.org/wiki/Q59652265

From CodeMeta ( using schema.org identifier):

"identifier": {
"@id": "schema:identifier",
"@type": "@id"
},

During the Hackathon we discussed this problematic situation of identifying at different levels of granularity and with different types of identifiers, see the identifiers crosswalk outcome
In biblatex, the property name is the identifier-type:

doi
isbn
etc.
even thought there aren't many identifiers related with software, except of the doi.

There might be different identifiers to the same thing, and it is difficult to specify which identifier-type is appropriate to which identifier-value even with an enum. It can cause a lot of automatic extraction problems.
To stay compatible with your last version I can propose to keep doi as a separate property and add identifier as a complex item with type and value.
Both shouldn't be mandatory.
Thanks again for continuing this discussion.

Thanks @moranegg! Makes sense.
What do you and @jspaaks think about introducing identifer**s** rather than `identifier, as a software can easily have more than one identifier, e.g., a DOI, and a Software Heritage ID (e.g., for a release)?

I think the identifiers key from https://github.com/citation-file-format/citation-file-format/issues/85#issuecomment-551016103 would be an improvement, but I stand by my comment about specificity. Supposing the list of identifiers are pointers to copies of the same thing, an advantage would be redundance, so if one resource disappears, there's still other copies. The downsides are: that there will be differences between copies, and that there is more of a burden on people supplying content, and more choices to confuse potential uploaders. Note that such confusion may well lead to people not uploading anything.
I guess we could leave it to the judgment of whoever is entering data what they feel is appropriate--with identifiers a list, at least they have the opportunity to enter multiple pointers, but they aren't required to do so.
For type, an enum would help the development of any code that uses CFF files, because you can just implement a simple switch in your code based off of the enum value. This also helps in communicating what is and what isn't supported in certain software. In order to retain flexibility, we could introduce other as an element of the enum to catch any previously undefined identifiers. Software developers wanting to support other would then write code with a switch case to other after which they can start trying to infer what the appropriate way to handle the unknown indentifier is (this kind of guessing usually yields code that is difficult to read and maintain).
For value, I would like to see if we get by with just strings (we can narrow it down if need be later, that's one reason why CFF files have cff-version after all).

So after the discussion above, I assume that the following will fix this issue:

Have a non-required field/term identifiers, which is a list of identifier objects.

An identifier object consists of two required fields/terms:

type: An enum from a list of supported identifier types (e.g., software-heritage identifiers) + other
value: A string representing the value of the identifier, e.g., swh:1:rel:99f6850374dc6597af01bd0ee1d3fc0699301b9f, which points to the 0.5.0 release of duecredit.

This is implemented in the schema
This is documented in the README = the specs
The process of adding a new identifier type to be supported (i.e., via an issue (and optionally a PR) against this repo) can be documented.

I'll write a PR and ask @moranegg and @jspaaks to review.
This doesn't really solve the chicken-egg issue a.k.a. race condition, but this may be something that CFF cannot tackle.

Hi @sdruskat, sounds good to me.

This looks good, I agree that software can have more than one identifier,
so yes for identifiers as a property with type-value tuples.
This is the same pattern with authors in CFF compared to multiple entries of author in CodeMeta.


Inconsistent attribute names throughout the code

For example, there are objects where an attribute is called netWork, and in other objects, it's called networks. In this particular example, I would use network and networks (all lowercase, single word).
Another example is: in some objects the attribute name ID is used, and in other objects called Id, or chainId.
A complete consistency review should be done in the data models.

@gsmachado We are handling this.

Solved and close it. If any issues, feel free to create a new one.


Crash when opening inventory on server while in creative

Only happens on a multiplayer server in creative
Using placebo / apotheosis 1.20.1
ran this test on a fresh instance / server build with only those mods
https://mclo.gs/wWXHxKh

Your Apotheosis main module config apotheosis.cfg is mismatched between the client and server.  This file must match exactly, since it is read on startup.


[SDP-1232] During disbursement start, use Circle to fetch the available balance when the tenant uses Circle

What
During disbursement start, use Circle to fetch the available balance when the tenant uses Circle.
Why
Address https://stellarorg.atlassian.net/browse/SDP-1232
Checklist
PR Structure

[x] This PR has a reasonably narrow scope (if not, break it down into smaller PRs).
[x] This PR title and description are clear enough for anyone to review it.
[x] This PR does not mix refactoring changes with feature changes (split into two PRs otherwise).

Thoroughness

[x] This PR adds tests for the new functionality or fixes.
[x] This PR contains the link to the Jira ticket it addresses.

Configs and Secrets

[x] No new CONFIG variables are required -OR- the new required ones were added to the helmchart's values.yaml file.
[x] No new CONFIG variables are required -OR- the new required ones were added to the deployments (pr-preview, dev, demo, prd).
[x] No new SECRETS variables are required -OR- the new required ones were mentioned in the helmchart's values.yaml file.
[x] No new SECRETS variables are required -OR- the new required ones were added to the deployments (pr-preview secrets, dev secrets, demo secrets, prd secrets).

Release

[x] This is not a breaking change.
[x] This is ready for production.. If your PR is not ready for production, please consider opening additional complementary PRs using this one as the base. Only merge this into develop or main after it's ready for production!

Deployment

[x] Does the deployment work after merging?

stellar-disbursement-platform-backend-preview is available here:SDP:      https://sdp-backend-pr336.previews.kube001.services.stellar-ops.com/healthAP:       https://sdp-ap-pr336.previews.kube001.services.stellar-ops.com/healthFrontend: https://sdp-backend-dashboard-pr336.previews.kube001.services.stellar-ops.com

stellar-disbursement-platform-backend-preview is available here:SDP:      https://sdp-backend-pr336.previews.kube001.services.stellar-ops.com/healthAP:       https://sdp-ap-pr336.previews.kube001.services.stellar-ops.com/healthFrontend: https://sdp-backend-dashboard-pr336.previews.kube001.services.stellar-ops.com

stellar-disbursement-platform-backend-preview is available here:SDP:      https://sdp-backend-pr336.previews.kube001.services.stellar-ops.com/healthAP:       https://sdp-ap-pr336.previews.kube001.services.stellar-ops.com/healthFrontend: https://sdp-backend-dashboard-pr336.previews.kube001.services.stellar-ops.com

stellar-disbursement-platform-backend-preview is available here:SDP:      https://sdp-backend-pr336.previews.kube001.services.stellar-ops.com/healthAP:       https://sdp-ap-pr336.previews.kube001.services.stellar-ops.com/healthFrontend: https://sdp-backend-dashboard-pr336.previews.kube001.services.stellar-ops.com

stellar-disbursement-platform-backend-preview is available here:SDP:      https://sdp-backend-pr336.previews.kube001.services.stellar-ops.com/healthAP:       https://sdp-ap-pr336.previews.kube001.services.stellar-ops.com/healthFrontend: https://sdp-backend-dashboard-pr336.previews.kube001.services.stellar-ops.com

stellar-disbursement-platform-backend-preview is available here:SDP:      https://sdp-backend-pr336.previews.kube001.services.stellar-ops.com/healthAP:       https://sdp-ap-pr336.previews.kube001.services.stellar-ops.com/healthFrontend: https://sdp-backend-dashboard-pr336.previews.kube001.services.stellar-ops.com

stellar-disbursement-platform-backend-preview is available here:SDP:      https://sdp-backend-pr336.previews.kube001.services.stellar-ops.com/healthAP:       https://sdp-ap-pr336.previews.kube001.services.stellar-ops.com/healthFrontend: https://sdp-backend-dashboard-pr336.previews.kube001.services.stellar-ops.com

stellar-disbursement-platform-backend-preview is available here:SDP:      https://sdp-backend-pr336.previews.kube001.services.stellar-ops.com/healthAP:       https://sdp-ap-pr336.previews.kube001.services.stellar-ops.com/healthFrontend: https://sdp-backend-dashboard-pr336.previews.kube001.services.stellar-ops.com


Update licenseGlob to allow checking for LICENCE files.

Some packages in our project use an alternative spelling for license.

Thank you!


Go < 1.9: Compatibility issue

We met some issues related to Go version.
For example, Go 1.9 moved to C99 float division.
As the result, we need to change unit test codes. (See https://github.com/google/grumpy/pull/384)
However, this approach is not cool enough to support old Go version.
So, we need to update unit tests codes to support Go < 1.9 also Go 1.9

 Comment by hero0926
Thursday Mar 08, 2018 at 00:22 GMT

I tried to use it Go 1.8 and 1.7 and some test were failed. Which go versions are compatible?

 Comment by corona10
Thursday Mar 08, 2018 at 04:13 GMT

@hero0926 For test. Use 1.9 :)


Changes to allow specifying apiType in CosmosClient

What is the change?
Allow specifying apiType while creating CosmosClient. This would mean that apiType would be sent in the request which initiates creation of the client as well as every CRUD operation request sent by that client.
ApiType is present in the request as a part of Request headers, the specific header is x-ms-cosmos-apitype.
Why is this needed ?
GremlinV2 graph operations should not be performed using CosmosClient. They should hit the JanusGraph application in CosmosDB. To block customer operations using CosmosClient, we needed a way to provide apiType.
Implementation Details:
ApiType property was not needed to be exposed publicly. To fulfill this we have exposed it indirectly by using ImplementationBridgeHelpers. This class exposes an Accessor, which can be initialized and used to set apiType for an instance of CosmosClientBuilder. ApiType is then passed to RxDocumentClientImpl which finally sends the request to CosmosDB Service.
Testing Done:
Unit test added in CosmosClientBuilderTest class.
E2E done on Prod accounts and validated through Fiddler.

/azp run java - cosmos - tests


[modules] The actual annotations and annotation processors should be in separate jar files

Then we can add vavr-match.jar (which includes only the annotations) to the classpath and the vavr-match-processor to the processor-classpath.
See also https://github.com/vavr-io/vavr/issues/985#issuecomment-335446401

Hi @danieldietrich, I think I have done it.
Could it be merged?

Hi @CauchyPeano, thank you!
I will take a look this evening and comment the PR!


Fix emoji detection

:alien: :alien: :alien:

Account for shifted index after each splice
Use forEach instead of for-in (iterates over indices because javascript)
Assign vw at each iteration (doesn't modify because javascript)

LGTM 👍 Thanks for your dedication to bug-free shitposting.


If account name is long, UI is broken.

I want to move the seach bar to left.

#251 addresses and fixes this. Closed.


[8.x] Improve phpdoc types for column names and allow count() to accept an array of column names like get() does

Improve phpdoc types for column names
Allow count() to accept an array of column names like get() does

Fixes: #40337

Couldn't there be Expression instances in some of these cases?

Couldn't there be Expression instances in some of these cases?

Probably, I will check this
Why was my pull request closed?

@williamdes probably because Taylor thought this PR was incomplete. It's best that you send in a new PR when you've made any necessary adjustments.

@williamdes probably because Taylor thought this PR was incomplete. It's best that you send in a new PR when you've made any necessary adjustments.

This is terrible, hopefully I am not first time contributor, please guys use templates (github saved replies) for your replies if needed but say to the contributor about why it was closed. If I was a first time contributor I would probably go cry and think open source is not for me.
Just my two cents ;)

But he gave a reason? Okay, it's debatable on how it was formed but he said he thought this was incomplete and therefor closed it?

But he gave a reason? Okay, it's debatable on how it was formed but he said he thought this was incomplete and therefor closed it?

Well I agree there was a question sent but I did not see a link between the comment and the closing :/. May I suggest that you first put back the PR in a draft state so the contributor can understand there is work to be done ?

@williamdes it's just the way Taylor likes to work to not have too many PR's open lingering. He manages dozens of repositories and it's hard to get an overview if all those PR's are left open. This has been the way we work for many years now and I don't think we'll change that soon, sorry. You can attempt a new PR if you like.

@williamdes it's just the way Taylor likes to work to not have too many PR's open lingering. He manages dozens of repositories and it's hard to get an overview if all those PR's are left open. This has been the way we work for many years now and I don't think we'll change that soon, sorry. You can attempt a new PR if you like.

Sure, I do understand this too
I will open a new one soon

Couldn't there be Expression instances in some of these cases?

Hi @taylorotwell
Can I make a first PR that includes my work and wait for me to have some time to finish the full support in another PR ?
Should I still target 8.x ?

8.x isn’t maintained anymore. Best that you send it to 9.x


Simplify package creation

I don't create new packages very often, so when I do I always end up needing to look at the PkgTemplates docs, realize that I need to create a Template first, and then call that template, but then I realize that makes a default package with no plugins, so then I look again to figure out how to do it interactively, or what the options are.
For my use-case it's not really important that the process be repeatable, because in the time between creating packages the landscape has often changed anyways.
What do you think about having:
generate() = generate(prompt_for_pkgname())

function generate(pkgname)
    t = interactive_template()
    t(pkgname)
end

So then as a user I can just do:
using PkgTemplates
PkgTemplates.generate()

which is easy to remember and easy to use.

I guess what is really missing is not a convenient short Code-style syntax since that is designed to be repeatedly used and placed in a file but integration into the pkg REPL mode (or another mode) which is designed for interactive use which is definitively the case here. So in fact mirroring the Pkg API landscape with a repl mode API which calls the interactive variants and a function API which can be called in packages. Maybe even aswell a macro variant API.

I really wish the OP solution to be implemented now, until something better comes around. For the latest PkgTemplates version, it should be modified to
generate() = generate(prompt_for_pkgname())

function generate(pkgname)
           t = interactive_template()
           PkgTemplates.generate(pkgname, t)
end


[ENH] Can't plot Random Dilated Shapelets on their extracted time point positions.

Describe the issue
Currently trying to visualise dilated shapelets for a notebook and I want to plot 10 extracted shapelets however I can only plot them stacked upon one another. It is important to see from which part of a time series the shapelet is extracted so you need the start point of the extracted shapelet to plot it in its corresponding place. This is made possible in the shapelet transform class by accessing its 'shapelets' list attribute.
Suggest a potential alternative/fix
Add the shapelet start point to the shapelets class attribute in RDST in the same way as ST.
Additional context

 a plot of extracted shapelets using ST.

Current attempt at making same plot but for RDST - as you can see they are all plotted from 0 rather than where they truly lie in the time series.

Aeon-Assign bot assign @IRKnyazev


Update autodidax to include pmap

Hi,
The document autodidax is very useful for developers to understand the Jax Core with heavy comments. But somehow it is out of date now, do we have any plan to update this document to align the current Jax, for example, include pmap?
Many thanks

Thanks for the kind words about Autodidax!
Actually Autodidax was added a couple years after pmap came into existence, so it's not that Autodidax is out-of-date. It just that Autodidax doesn't include everything.
I agree it'd be great to add pmap, or its soon-to-be successor shard_map. But I'm not sure when we'll be able to make it a priority.
I'll leave this issue open but with a low priority score. Hopefully we can get to it someday!
Thanks for the request.

There's a good chance we'll end up rewriting autodidax, and when we do we'll likely include a model of shard_map.
However, I want to close this issue as stale since it's nominally about the current autodidax and pmap.
Thanks for raising it! As a result, we'll have shard_map in mind for autodidax v2.


[SMALLFIX]Improve the Running-Tachyon-Locally page of the Chinese doc

Improve the Running-Tachyon-Locally page of the Chinese document.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Tachyon-Pull-Request-Builder/8526/
Test PASSed.

LGTM. Thanks for the improvement!


feature request: support Azure OpenAI

Working at a corporate behemoth, we are stuck with Azure due to compliance-related reasons, unable to use OpenAI as provided by its creators.
However, as far as I can tell, the OpenAI provided by Azure is supposed to be the same under the hood - could you please consider supporting Azure OpenAI as well?!

I think this was closed by mistake?
I would love to see this implemented  :)

@ido50 can you please reopen this issue? Azure's OpenAI requires setting an endpoint in addition to the key value.


Don't show unrelated matches for gene IDs

ie.
Reported by a user when typing in SPAC27D7.09c and leaving off the "c" at the end:

This is fixed now.  Now if you search with a systematic ID it only shows exact matches.  So if you search for "SPBC409.08" you only get: https://www.pombase.org/reference/PMID:27188733
instead of lots of spurious publication matches.