Getting error in broadcaster after calling acquireTokenSilent() method

Hi,
I am using MSAL-ANGULAR for AD B2C Implementation with Angular 7.I am able to login but getting error to acquire Access token.Trying to acquire the access token silently as suggested in Docs after getting login success response on broadcaster. PFA for error details
Code sample
  this.broadcastService.subscribe('msal:loginSuccess', (payload) => {
    console.log('[Info] - Login success');.
    // Getting login sucess here and giving call for token
    this.authService.acquireTokenSilent(b2cScopes);
  });

  this.broadcastService.subscribe('msal:acquireTokenSuccess', (payload) => {
    // Should get access token here
    console.log('[Info]- Acquire Token success : ', JSON.stringify(payload));
  });

  this.broadcastService.subscribe('msal:acquireTokenFailure', (payload) => {
    // Getting error details here
    console.error('[Error] - Access token failure ::', JSON.stringify(payload));
  });

Browser:

[ X] Chrome version XX
[ X] Firefox version XX

Library version
@azure/msal-angular: '^0.1.4'
Angular CLI version : 7.0.4
Current behavior
After Login success broadcaster response,getting the ID token here and calling  acquireTokenSilent() to get access token, but it is giving error for Acquire token failure :
Error] - Access token failure :: {"_error":"AADB2C90205: This application does not have sufficient permissions against this web resource to perform the operation.\r\nCorrelation ID: bd95d6e4-d62a-4f57-a51f-bfb5297ef21a\r\nTimestamp: 2020-01-10 05:24:05Z\r\n","_errorDesc":"invalid_request","_scopes":""}
Expected behavior
After Login success broadcaster response, it should give success response for access token [Info]- " Acquire Token success : "  with access token attached to it.
I am passing all the required scopes for the same.Do i need to add anything else ? It would be better if i get some help.

##Update
I tried to change the authority URL but facing following issue :

@Ankita22 I believe this error indicates either your request was invalid or the app is not configured properly. Can you please provide some sample code that demonstrates your usage (e.g. what scopes you are using)? Thanks!

@jasonnutter Thanks for your reply. I am using following scopes  : 'user_impersonation','offline_access','openid','profile'
Following is the piece of code i am using to try to connect :
In app.module.ts
MsalModule.forRoot({
      clientID: environment.b2CDetails.clientID,
      authority: environment.b2CDetails.authority,
      validateAuthority: false,
      redirectUri: environment.b2CDetails.redirectUri,
      cacheLocation : 'localStorage',
      postLogoutRedirectUri: environment.b2CDetails.redirectUri,
      popUp: false,
      consentScopes: environment.b2CDetails.b2cScopes,
      unprotectedResources: ['https://www.microsoft.com/en-us/'],
      logger: loggerCallback,
      correlationId: '1234',
      level: LogLevel.Info,
      piiLoggingEnabled: false
   }

B2C details
 b2CDetails: {
    'tenant': '<tenantName>',
    'clientID': '<clientID>',
    'signUpSignInPolicy': '<policyName>',
    'b2cScopes': ['https://<tenantName>.onmicrosoft.com/<applicationName>/user_impersonation','offline_access','openid','profile'],
    'nonce': '123456789',
    'redirectUri': 'http://localhost:4200/login',
    'authority': 'https://<tenantName>.b2clogin.com/<tenantName>.onmicrosoft.com/<policyName>',
}

Thanks a lot for the help @jasonnutter . I updated my Authority URL and couple of setting and i am able to login properly but not able to get access token.
I am getting access token at localhost but once app gets hosted , facing issue to acquire the same. Can you please help with it ?
Please refer the code sample associated with above comments,you can see in
 this.broadcastService.subscribe('msal:acquireTokenFailure', (payload) => {
    // Getting error details here
    console.error('[Error] - Access token failure ::', JSON.stringify(payload));
  });

this part of the code i am getting error.
Please refer attached image for error details which i received on " msal:acquireTokenFailure" broadcaster provided by MSAL-ANGULAR

@Ankita22 Since it works locally but not when deployed, can you verify that you have correctly configured your redirect uris in both your app in the Azure Portal?

@jasonnutter Yes, I checked the Redirect URIs on  Azure portal. It looks fine. It has both the URLs - Localhost and webapp's  app service url.


output_channel=latest doesn't work as expected

I'm using HTTP API Inject an intent into a conversation with output_channel set to latest.
curl -X POST \
    --url 'http://localhost:5005/conversations/1/trigger_intent?output_channel=latest' \
    --header 'Content-Type: application/json' \
    --data '{ "name": "greet" }'

The first API call works as expected and output redirected to the latest conversation channel but the second one and all other subsequent calls lead to no output at all.

Thanks for the issue, @amn41 will get back to you about it soon!
You may find help in the docs and the forum, too 🤗


windows build failing

The CI build here fails for windows.
It seems it cannot find the icon file for windows.

Fixed in #229


Add button to crop

I noticed that every time the cropper is moved or resized, the cropped picture is updated. This is not always desirable, especially when working with big pictures.
It would be nice to have the option to add a button so the user can choose when to crop the image.
Is there any interest in adding this feature?

This is interesting. I think that is a future feature to implement. Assigned it to milestone 0.7.
I am working on fixing the bugs for the 0.6 release.

Fixed with #191


Feature-gate tests to reduce dependencies

This PR adds three features, one for each macro, and allows a user who only needs one macro to avoid dependencies that are only needed for the other macros.
Feedback requested:

Bikeshedding the feature names
Deciding which features to turn on by default

Hi Ryan, thanks for the PR — I like the idea! I'll try to find time to review it tomorrow.

Hey again,
Thanks for updating now that you can run the CI tests.

Feedback requested:

Bikeshedding the feature names

Okay, these are the features in the PR:
[features]
markdown = ["pulldown-cmark", "semver-parser", "toml"]
html_root_url = ["url", "semver-parser", "syn", "proc-macro2"]
regex_version = ["regex"]

Since there are so many crates in play, I would probably say the simplest approach would be to name the features after the macros? So contains_regex, html_root_url_updated, and markdown_deps_updated. A bit long, but mechanical and simple.

Deciding which features to turn on by default

I would suggest turning them all on by default so that thinks keep working the way people are used to. I like to offer people features first, and speed second, if that makes sense :)
I've done something similar in my Textwrap library and there I added a section to the top-level API doc to explain what the features do: https://docs.rs/textwrap/0.14.2/textwrap/index.html#cargo-features. I would like to add something similar here — if not in this PR, then later.
Let me add some comments to the changes themselves as well.

I addressed some of these changes, and am now thinking out how to simplify/move the conditional imports and how to write up a blurb in the documentation describing the features.

I addressed some of these changes, and am now thinking out how to simplify/move the conditional imports and how to write up a blurb in the documentation describing the features.

Thanks, sounds good!

@mgeisler I think this is ready to merge now. Could you please take a look and either merge it or point to other things that you think need changing?

I think this is ready to merge now.

Yes, thank you so much! I think it looks very good too :-) It's Friday evening in my timezone, so I'll look it over and squash merge it tomorrow.
Btw, your step-by-step commits look great and I think the tests pass for all of them except the first few. Of you want, you could rework the first commits so that tests pass and then I'll be happy to merge your branch. Otherwise I'll just squash merge it.

Okay, sounds good! Thanks for all the updates based on my comments.
Would you be up for adding a assert_contains_version! macro too, or should I go ahead and do it myself? I would like to include it before making a new release.

Unfortunately I'll be busy for the next few days, so I think it'd be better for you to do it yourself.


docs(order): clean up the order

How about putting the Agent below User Guides so platform guides are together?


Use CompilerConfig model in Scratch model

A little refactor.
Make sure to not break the existing create scratch endpoint's interface (#148 would help here!)

@ethteck did we get anywhere with this

I've been working on it

This isn't needed anymore since we store Presets in the backend, which are essentially CompilerConfig


fix: allow PascalCase to resolve

:tada: This PR is included in version 1.2.3 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Add Algorithms in any language

This issue is for HACKTOBERFEST'19

@memr5 Added basic Mathematical Algorithms (GCD and LCM of Array elements) in python. Check #8

#9 Added Heap Sort Algorithm in C++

@memr5 ... #14 Bucket sort algorithm in Python added

Added Linear Search in python .

Added Bubble Sort in C #34

Added Binary Searching in C++ #35

@memr5 i added KMP algorithm for string matching in C++.

Added bubble sort in Python https://github.com/memr5/Algorithms/pull/43

Added coin change in Python https://github.com/memr5/Algorithms/pull/44

I will Add Quick Sort in C

I will add permutation of integer in java

I will add Heap Sort in C Language

@memr5 please review my PR and merge into your repo and my PR id is #99

@memr5 Added 2D array spiral order traversal #141 , review my pr

I will add Rabin Karp string matching using python

I will add the Longest Common Subsequence in C++

@memr5 Added code for two sum problem #190

add ford fulkerson https://github.com/memr5/Algorithms/pull/191

Hey @memr5 Added Astar Algorithm with implementation in Python. Review my pr #193

hello,
ive added algorithm in dynamic program to find nth catalan number.
kindly check given PR
https://github.com/memr5/Algorithms/pull/195

I have added Bubble Sort in Dart language in folder Dart.
Check #199

Add code for Tim Sort in JAVA #224

@memr5  Added Radix sort code:- #234


Scalability of the component

The multiselect component shall be extendable, maintainable. Using a standard framework supported widely through the community. It shall be published under the MIT license to support increased awareness and continuous improvement of the framework and multiselect component.

Scalability is achieved. This component can be further extended.


name '_' is not defined

Please, see http://dpaste.com/688894/

Please let me know if that fixes the issue.

Should be fixed and works for me.


Add custom matchers to mocha

Add custom matchers for mocha unit tests.

looks good to me; let's merge as soon as the build is passing.


Strange behaviour of global objects relations if used inside relation declaration

Laravel Version: 5.8
PHP Version: 7.2

Description:
I have a model defining a many to many relation. And I want to define another relation to same model but filtered by some values that I receive from globally stored model.
class Tenant extends Authenticatable implements JWTSubject, BelongsToObjects
{

   // this one is filtered
    public function addressesInSystem()
    {
   // $system is an instance of System model which has "hasMany" relation "objects", this is the first time I'm trying to get system's objects
        $system = \SystemResolver::system();
        $addresses = $this->addresses()->whereIn('objectId', $system->objects->pluck('id'));
        return $addresses;
    }

   // this one is a base relation
    public function addresses()
    {
        return $this
            ->belongsToMany(Address::class, 'tenants_addresses')
            ->withPivot('isBlocked', 'confidanceId');
    }

}

Then I eager load this relation inside controller
class TenantController extends Controller
{
    public function get(Request $request)
    {
        /** @var System $system */
        $system = \SystemResolver::system();
        $tenants = $system->tenants()
            ->with('tenantsGroups')
            ->with('addressesInSystem')
            ->filter($request->input('filter'))
            ->queryFilter($request->input('query'))
            ->sort($request->input('sort', ['id' => 'DESC']))
            ->paginate(\Config::get('constants.default_pagination'));
        $tenantsCollection = new TenantsCollection($tenants);
        return \Response::success($tenantsCollection);
    }
}

The weird thing is instead of getting objects of the system I get all objects, so I get addresses with any objectId. I know I can filter relation inside with method, but this one is also used for sync and in other controller methods. The workaround is to add protected $with = ['objects'] to System model, but the behavior is still unexpected. And there are no mentions in docs about this. I guess the same thing will happen to any other global objects like Auth::user()

Just checked v6.0 also affected

Hey there,
Can you first please try one of the support channels below? If you can actually identify this as a bug, feel free to report back and I'll gladly help you out and re-open this issue.

Laracasts Forums
Laravel.io Forums
StackOverflow
Discord
Larachat
IRC

Thanks!


commands: fix help message for hugo new theme

This PR closes #11161.

Thanks, merged. I fixed your commit message title to be in line with our guidelines.


Instead of Entities, only services can be pushed ?

Need to push only services, not total entites.
Can it be done ?
Thanks,
Shashi.

Git technology works with files only. The GitBackup Extension works with Entity Export files which contain the full Entity, not just services. If you want to push services, you need to modify the extension to extract the services as files (by parsing the XML). As far as I am aware, we do not plan for this functionality (@cbadici please confirm).
Feel free to fork the extension to add this functionality.

I agree with what @vrosu has mentioned. So basically with the Git Extension, you may push whatever files you have in a ThingWorx repository to your remote Git repository. However, from ThingWorx you can export entities, not the services that are related to your entities. Therefore, you will need a new extension that allows you to export only the services (and here you can expand our Git extension or create your own extension for this).


Release Google.Cloud.EdgeNetwork.V1 version 1.2.0

Changes in this release:
New features

Change netstandard2.1 target to netstandard2.0 (commit 82bea85)

Created release for Google.Cloud.EdgeNetwork.V1-1.2.0


Recommended way to test all crates in a workspace

It seems like cargo test-all-features --workspace tests the whole workspace for any combination of features.
I'd like to test each crate in the workspace for any combination of its own features.

 With a great number of crates (30+), many kinds of tests (unittest, doc-tests, ...) and multiple features (1--10), the command takes too long to be useful.

Essentially the problem is that the current command selects the different combinations correctly, but executes cargo test --workspace for each of them instead of cargo test -p <crate>

Interesting I have exactly the opposite problem with 1.9.0: in rustup we have 3 crates: a macros crate, a download abstraction crate, and the rest.
We're not interested in the features in the first two crates: they are controlled by the build of the CLI in the last crate, and testing its features is sufficient to tell us whether we have a problem or not.
But cargo build-all builds permutations for each crate, not the workspace.
$ cargo build-all-features -p rustup
    Building crate=download features=[]
   Compiling winapi v0.3.9


APIError: You cannot upload the same file twice.

I had cloned my voice using 3 recording files, and it worked and generated my cloned voice. Then I deleted the voice from elevenlabs account (whose api key I was using), and tried the same steps again to clone the voice again but it generated the error:
APIError: You cannot upload the same file twice.

sorry it was an error on my side


Provide type for resolvers

I'm submitting a feature request

Library Version:
1.1.0

Please tell us about your environment:

Language:
TypeScript 2.0

Current behavior:
class DependsOnMyClass {
  static inject = [Factory.of(MyClass)];
  constructor(myClassFactory: Factory) {
    myClassFactory(config); // Cannot invoke an expression whose type lacks a call signature.
  }
}

myClassFactory's type is actually (...rest: any[]) => MyClass.
Expected/desired behavior:

What is the expected behavior?

I would like to import a generic type from DI for resolvers.
import { factoryResolver } from 'aurelia-framework';
class DependsOnMyClass {
  static inject = [Factory.of(MyClass)];
  constructor(myClassFactory: factoryResolver<MyClass>) {
    myClassFactory(config); // Cannot invoke an expression whose type lacks a call signature.
  }
}

I am looking for suggestions on how to name these types.
export interface factoryResolver<T> {
  (...rest: any[]): T;
}

What is the motivation / use case for changing the behavior?
Reusing of types.

They are just functions.

I would just type them on a case by case unless you have the same case repeatedly, then you could use the interface. It's up to you though.

I'm sorry to post on an old issue, but it took me a while to understand the wisdom in Eisenberg's words ("They are just functions"), and this might help someone who (like me) stumbles upon this issue:
import { factoryResolver } from 'aurelia-framework';
class DependsOnMyClass {
  static inject = [Factory.of(MyClass)];
  constructor(myClassFactory: Function) {
    myClassFactory(config); // Works just fine, no type errors here.
  }
}


pop-up

As user
i want to choose a team
so that all the pop up can be in french or in english

in this screen, we can see english and french words


Site Down After Deploy

I am using deployer to deploy a Magento site and after deploy I experience some brief downtime immediately when finished.  I believe I have narrowed this down to the symlink.  The server itself sees the symlink change immediately but PHP reports "PHP Fatal error:  Unknown: Failed opening required " on files within the current folder.  My deploy config is pretty much the magento recipe with some additions and host definitions. Its short lived, less then 30 seconds.  I have experimented with a custom task doing the following:
run("{{bin/php}} -r 'clearstatcache(true);'");
run("{{bin/php}} -r 'opcache_reset();'");
and that shortens the downtime to more like 5-10 seconds but my preference would be none.  Any advice or other places to look?  Let me know what information you need from me.

+1 for this

Are you stopping Magento cron during your deploy?

Please provide more details on the error. Did you tried restarting php-fpm?

I am not stopping cron but on this particular test site I don't have Magento cron jobs setup so it's not interfering in my test.  We are using apache+php so no fpm to restart.  If I restart apache right away after a deploy everything is good, but I am not keen on that as a process either since it drops connections as well.  The errors I see in the apache logs look like this:
PHP Fatal error:  Unknown: Failed opening required.........
PHP Warning:  Unknown: failed to open stream: No such file or directory in

As a basic test I added a phpinfo file, loads fast and I can see results quick.  After a deploy the phpinfo file throws the same errors in the logs.  As soon as everything is cleared up all files load without issue and no errors in the apache logs.  As a test I changed php realpath_cache_size to 0, restarted apache.  After a deploy everything seems normal and I get no failures in the logs, but reading up on that php parameter it sounds like it would be a huge performance hit to disable.  Any other thoughts or need any more info from me?

I did another test.  I created the following file:
<?php
error_log(getcwd(), 0);

just to echo the path to apache logs.  Then I reload the tab in my browser every 1 second.  During the deploy this is what I see right after the symlink is created:
[Wed May 20 09:08:26.980767 2020] [php7:notice] [pid 20127] [client <IP_ADDRESS>:64851] /......../releases/68
[Wed May 20 09:08:28.989616 2020] [php7:notice] [pid 20127] [client <IP_ADDRESS>:64851] /......../releases/68
[Wed May 20 09:08:30.987431 2020] [php7:notice] [pid 20127] [client <IP_ADDRESS>:64851] /......../releases/68
[Wed May 20 09:08:32.985211 2020] [php7:notice] [pid 20127] [client <IP_ADDRESS>:64851] /......../releases/68
[Wed May 20 09:08:34.983630 2020] [php7:notice] [pid 20127] [client <IP_ADDRESS>:64851] /......../releases/69
[Wed May 20 09:08:36.988241 2020] [php7:notice] [pid 20127] [client <IP_ADDRESS>:64851] /......../releases/69
[Wed May 20 09:08:38.985322 2020] [php7:warn] [pid 20127] [client <IP_ADDRESS>:64851] PHP Warning:  Unknown: failed to open stream: No such file or directory in Unknown on line 0
[Wed May 20 09:08:38.985482 2020] [php7:warn] [pid 20127] [client <IP_ADDRESS>:64851] PHP Warning:  Unknown: failed to open stream: No such file or directory in Unknown on line 0
[Wed May 20 09:08:38.985570 2020] [php7:error] [pid 20127] [client <IP_ADDRESS>:64851] PHP Fatal error:  Unknown: Failed opening required '/......../current/logger.php' (include_path='.:/usr/share/php') in Unknown on line 0
[Wed May 20 09:08:41.328840 2020] [php7:notice] [pid 20142] [client <IP_ADDRESS>:64932] /......../releases/69

In the above, its weird that before it fails it does see the correct path, but then fails for a period.  If I set realpath_cache_size = 0 , restart apache then deploy this is what I get where it just rolls right through:
[Wed May 20 09:18:04.666531 2020] [php7:notice] [pid 2636] [client <IP_ADDRESS>:65138] /......../releases/69
[Wed May 20 09:18:05.670427 2020] [php7:notice] [pid 2636] [client <IP_ADDRESS>:65138] /......../releases/69
[Wed May 20 09:18:06.673484 2020] [php7:notice] [pid 2636] [client <IP_ADDRESS>:65138] /......../releases/69
[Wed May 20 09:18:07.668229 2020] [php7:notice] [pid 2636] [client <IP_ADDRESS>:65138] /......../releases/69
[Wed May 20 09:18:08.665911 2020] [php7:notice] [pid 2636] [client <IP_ADDRESS>:65138] /......../releases/69
[Wed May 20 09:18:09.667866 2020] [php7:notice] [pid 2636] [client <IP_ADDRESS>:65138] /......../releases/69
[Wed May 20 09:18:10.677412 2020] [php7:notice] [pid 2636] [client <IP_ADDRESS>:65138] /......../releases/70
[Wed May 20 09:18:11.675907 2020] [php7:notice] [pid 2636] [client <IP_ADDRESS>:65138] /......../releases/70
[Wed May 20 09:18:12.667338 2020] [php7:notice] [pid 2636] [client <IP_ADDRESS>:65138] /......../releases/70
[Wed May 20 09:18:13.666821 2020] [php7:notice] [pid 2636] [client <IP_ADDRESS>:65138] /......../releases/70
[Wed May 20 09:18:14.685473 2020] [php7:notice] [pid 2636] [client <IP_ADDRESS>:65138] /......../releases/70
[Wed May 20 09:18:15.674765 2020] [php7:notice] [pid 2636] [client <IP_ADDRESS>:65138] /......../releases/70
[Wed May 20 09:18:16.675682 2020] [php7:notice] [pid 2636] [client <IP_ADDRESS>:65138] /......../releases/70
[Wed May 20 09:18:17.678610 2020] [php7:notice] [pid 2636] [client <IP_ADDRESS>:65138] /......../releases/70

Everything I read though says setting realcache path to 0 comes at a large performance hit so that doesn't seem like a solution.  Help is greatly appreciated.

So this looks like a problem with the cache. After current symlink is changed PHP still uses the old path. What is your keep_releases config? Also, there is no need to disable realpath_cache_size. Just clear realpath_cache right after deploy. Also, try clear opcache (maybe it will help)

I tried the following:
run("{{bin/php}} -r 'clearstatcache(true);'");
run("{{bin/php}} -r 'opcache_reset();'");

and honestly didn't notice the difference I was expecting.  Is there a better/different way you are aware of to clear that cache?  I am also looking into swapping to Nginx since reading suggests its easier to handle this issue, swapping to Nginx is not a quick thing though.  Thanks again

You cleared cache for cli, you need to clear it for apache worker. Create some endpoint and curl it.

I didn't even catch that, your right.  Let me play around with that some and test and I will report back.

You might be interested in the cachetool recipe for this...
host('x')
    ->set('cachetool', '/run/php-fpm/www.sock');
...
after('deploy:symlink', 'cachetool:clear:opcache');

Sorry for the late reply.  With apache I can't get the cache to clear in a reasonable amount of time at all, and still experience some sort of downtime.  I did some testing with Nginx and am able to make this go away with these changes https://serverfault.com/questions/848503/nginx-caching-symlinks.  I am going to follow that road and work to remove Apache from my magento environment.  Thanks for the help.

If you are using PHP with Apache without FPM I assume you are using mod_php? You may find if you want to continue using Apache that switching to PHP FPM is more performant.


go-api-starter not working

go run main.go

./main.go:25:9: undefined: InitFiberApplication

make build

swag init
make: swag: No such file or directory
make: *** [Makefile:24: swag] Error 127

Hello, I believe the README clearly illustrated the steps needed to run the code, it runs as a docker container.
https://github.com/oliversavio/youtube-vid-code/blob/main/go-api-starter/README.md
If you wish to run the code in a development mode where you can modify the code test out change consider using https://github.com/cosmtrek/air. This is what I use during development
From your comment above it looks you're missing the step that installs swaggo/swag and hence the make build command is failing. I guess I could make the script a bit more beginner friendly and have it install the missing dependencies, something for my future videos.
In any case, thanks for the feedback, do let me know if you run into any more issues, I'll try my best to sort it out.


Update angular CLI

The project currently uses "@angular/cli": "^8.3.29",. The latest angular CLI is 12.2.1.
@yochanah would it make sense to move to this latest version?

I am using ^12.0.5 for a personal project. That designation should grab
12.2.1. I consider myself a junior angular programmer, but I would
prefer to use the same versions. :-) On Sun, 2021-08-15 at 19:17 -0700,
Upkar Lidder wrote:

The project currently uses @.***/cli": "^8.3.29",. The latest
angular CLI is 12.2.1.
@yochanah would it make sense to move to this latest version?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.

Yes, it's good to move to latest version

Thanks @RickPoleshuck. I agree. We should move to 12.x.x from 8.3.29. They follow semantic versioning which, means 12.2.1 and 12.0.5 should theoretically both work.
Minor releases contain new smaller features. Minor releases are fully backward-compatible; no developer assistance is expected during update, but you can optionally modify your applications and libraries to begin using new APIs, features, and capabilities that were added in the release.

You can read more here - https://angular.io/guide/releases#angular-versioning

It is my understanding that the caret in front of ^12.0.5 means that
the minor version will be upgraded automatically, so ^12.0.5 is
effectively 12.2.1 today.  I had to look it up, before I posted. :-)
On Mon, 2021-08-16 at 11:58 -0700, Upkar Lidder wrote:

Thanks @RickPoleshuck. I agree. We should move to 12.x.x from 8.3.29.
They follow semantic versioning which, means 12.2.1 and 12.0.5 should
theoretically both work.
Minor releases contain new smaller features. Minor releases are fully
backward-compatible; no developer assistance is expected during
update, but you can optionally modify your applications and libraries
to begin using new APIs, features, and capabilities that were added
in the release.
You can read more here -
https://angular.io/guide/releases#angular-versioning
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.

^12.0.5 works for me. @yochanah?

Potential issues with Carbon & Angular CLI


SSL at WeMos D1 code

The SSL Function doesn't work with the WeMos D1.
The normal Wifi Code but does work.
So the SSL function must have a Problem.

This is not the place to post such issues. Read docs.


use-subscription could not resolve dependency for react 18

Description
The latest react-native (v0.68.0) depends on use-subscription: ^1.0.0, but v1.6.0 of use-subscription was just released two days ago and it peer depends on react: ^18.0.0 whereas react-native 0.68.0 peer depends on react v17.0.2 which is also what is installed in the vanilla React Native project (npx react-native init). This results in this warning when running npm install:
npm WARN ERESOLVE overriding peer dependency
npm WARN While resolving<EMAIL_ADDRESS>npm WARN Found<EMAIL_ADDRESS>npm WARN node_modules/react
npm WARN<EMAIL_ADDRESS>from the root project
npm WARN   3 more (react-native, react-test-renderer, react-shallow-renderer)
npm WARN
npm WARN Could not resolve dependency:
npm WARN peer<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm WARN node_modules/use-subscription
npm WARN<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm WARN   node_modules/react-native

(the warning is also present when using yarn)
Version
0.68.0
Output of npx react-native info
System:
OS: macOS 12.2.1
CPU: (16) x64 Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz
Memory: 2.97 GB / 32.00 GB
Shell: 5.8 - /bin/zsh
Binaries:
Node: 16.14.2 - ~/.nvm/versions/node/v16.14.2/bin/node
Yarn: 1.22.17 - /usr/local/bin/yarn
npm: 8.5.0 - ~/.nvm/versions/node/v16.14.2/bin/npm
Watchman: 2<IP_ADDRESS> - /usr/local/bin/watchman
Managers:
CocoaPods: 1.11.2 - /Users/be9276/.rbenv/shims/pod
SDKs:
iOS SDK:
Platforms: DriverKit 21.4, iOS 15.4, macOS 12.3, tvOS 15.4, watchOS 8.5
Android SDK: Not Found
IDEs:
Android Studio: 2020.3 AI-203.7717.56.2031.7784292
Xcode: 13.3/13E113 - /usr/bin/xcodebuild
Languages:
Java: 11.0.11 - /usr/bin/javac
npmPackages:
@react-native-community/cli: Not Found
react: 17.0.2 => 17.0.2
react-native: 0.68.0 => 0.68.0
react-native-macos: Not Found
npmGlobalPackages:
react-native: Not Found
Steps to reproduce
npx react-native init VanillaRN
cd VanillaRN
rm -rf node_modules
npm i

I don't even use react-native in my project, yet here I am with my build failing due to this!

[Container] 2022/04/01 19:05:30 Running command npm ci
--
43 | npm WARN ERESOLVE overriding peer dependency
44 | npm WARN While resolving<EMAIL_ADDRESS>45 | npm WARN Found<EMAIL_ADDRESS>46 | npm WARN node_modules/react
47 | npm WARN   peer<EMAIL_ADDRESS>from<EMAIL_ADDRESS>48 | npm WARN   node_modules/react-native
49 | npm WARN     peer react-native@"*" from<EMAIL_ADDRESS>50 | npm WARN     node_modules/@react-native-community/cli
51 | npm WARN     1 more (react-native-get-random-values)
52 | npm WARN   1 more (react-shallow-renderer)
53 | npm WARN
54 | npm WARN Could not resolve dependency:
55 | npm WARN peer<EMAIL_ADDRESS>from<EMAIL_ADDRESS>56 | npm WARN node_modules/use-subscription
57 | npm WARN<EMAIL_ADDRESS>from<EMAIL_ADDRESS>58 | npm WARN   node_modules/react-native
59 | npm WARN
60 | npm WARN Conflicting peer dependency<EMAIL_ADDRESS>61 | npm WARN node_modules/react
62 | npm WARN   peer<EMAIL_ADDRESS>from<EMAIL_ADDRESS>63 | npm WARN   node_modules/use-subscription
64 | npm WARN<EMAIL_ADDRESS>from<EMAIL_ADDRESS>65 | npm WARN     node_modules/react-native
66 | npm ERR! `npm ci` can only install packages when your package.json and package-lock.json or npm-shrinkwrap.json are in sync. Please update your lock file with `npm install` before continuing.
67 | npm ERR!
68 | npm ERR! Missing<EMAIL_ADDRESS>from lock file
69 | npm ERR!

Any update @jenskuhrjorgensen?

@hoIIer no updates

I don't even use react-native in my project, yet here I am with my build failing due to this!
Any suggestions or eta?

yikes!

I manage to solve with:
  "overrides": {     "react-native" : "0.67.3"   },
in package.json

Got the same issue, fixed with npm legacy peer depencies flag on install or update. That way react 17.0.2 doesnt get installed because of react native.
I think i fix would be to bump the peer dependency on react to 18 or bigger the 17

@sergioUjo The dependency problem originates from use-subscription >=1.6.0 which should not be required by RN, you should keep React 17 as is. There is already a PR (#33541) on the way.
You may try to mitigate the issue manually on your project by explicitly adding in your package.json the import of use-subscription <1.6.0 in the meantime.

I have the same problem.
asterisk@msyncdeMBP xx % npm install
npm WARN ERESOLVE overriding peer dependency
npm WARN While resolving<EMAIL_ADDRESS>npm WARN Found<EMAIL_ADDRESS>npm WARN node_modules/react
npm WARN   dev<EMAIL_ADDRESS>from the root project
npm WARN   1 more (react-native)
npm WARN
npm WARN Could not resolve dependency:
npm WARN peer<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm WARN node_modules/use-subscription
npm WARN<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm WARN   node_modules/react-native
npm WARN
npm WARN Conflicting peer dependency<EMAIL_ADDRESS>npm WARN node_modules/react
npm WARN   peer<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm WARN   node_modules/use-subscription
npm WARN<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm WARN     node_modules/react-native
...

asterisk@msyncdeMBP xx % npm react-native info
Unknown command: "react-native"

To see a list of supported npm commands, run:
  npm help
asterisk@msyncdeMBP xx % npm react-native info
Unknown command: "react-native"

To see a list of supported npm commands, run:
  npm help
asterisk@msyncdeMBP xx % npx react-native info
info Fetching system and libraries information...
System:
    OS: macOS 12.3.1
    CPU: (8) arm64 Apple M1
    Memory: 489.89 MB / 16.00 GB
    Shell: 5.8 - /bin/zsh
  Binaries:
    Node: 17.8.0 - /opt/homebrew/bin/node
    Yarn: 1.22.18 - /opt/homebrew/bin/yarn
    npm: 8.5.5 - /opt/homebrew/bin/npm
    Watchman: 2<IP_ADDRESS> - /opt/homebrew/bin/watchman
  Managers:
    CocoaPods: 1.11.3 - /opt/homebrew/opt/cocoapods/bin/pod
  SDKs:
    iOS SDK:
      Platforms: DriverKit 21.4, iOS 15.4, macOS 12.3, tvOS 15.4, watchOS 8.5
    Android SDK:
      API Levels: 23, 28, 29, 30, 31, 32
      Build Tools: 28.0.3, 30.0.2, 32.0.0, 32.1.0
      System Images: android-32 | Google APIs ARM 64 v8a
      Android NDK: 22.1.7171670
  IDEs:
    Android Studio: 2020.3 AI-203.7717.56.2031.7935034
    Xcode: 13.3/13E113 - /usr/bin/xcodebuild
  Languages:
    Java: javac 18 - /usr/bin/javac
    Python: Not Found
  npmPackages:
    @react-native-community/cli: Not Found
    react: 16.13.1 => 16.13.1
    react-native: 0.63.4 => 0.63.4
    react-native-macos: Not Found
  npmGlobalPackages:
    *react-native*: Not Found

Solutions to the above problems:
rm -rf ./node_modules/@types/react-native/node_modules/

I believe this issue is still ongoing for expo
Expo uses the version 0.64.3 which also has the same dependencies: https://github.com/facebook/react-native/blob/0.64-stable/package.json#L115
I fixed it by forcing the version in my package.json
"dependencies": {
    ...
    "use-subscription": ">=1.0.0 <1.6.0"
}


Tests fix

Cancel exclusion for nd4j-tests, to get all nd4j-tests running via mvn test

Refer to this link for build results (access rights to CI server needed):
/job/nd4j_PR/195/


Export less typeclasses hints for performance

This PR adds Hint Modes to every typeclasses and tries not to export most instances by default (a module is provided instead )
CallTypes and CallableProps are employed instead of Callable (not sure this was really worth changing in the end).

The modes were not helping specifically with performance, but they prevent situations where an arbitrary solution is chosen (for instance when typeclass search looks for Monad ?M for an unconstrained evar ?M).
I fixed the two comments and ammended the commit.


Query Frontend splitting metrics check is flaky #6951

[ ] I added CHANGELOG entry for this change.
[x] Change is not relevant to the end user.

Changes
Added thanos receiver instead of using sidecar, updated the model.Metric of instant query.
Also the change in the now.Add() is temporary, just to test for the border condition.

Verification

When the splitting metrics are removed other metrics show errors like the http_requests_total and so on, so trying to implement the thanos receivers now.
I have just implemented this for one test, will refactor all other split query tests after this one is solved.
Need guidance on how to predefine the timestamps for thanos receiver.

Need guidance on how to predefine the timestamps for thanos receiver.

You need to add a helper functions to craft remote write request and sent the request to Thanos receiver.
The remote write request can have synthetic data in its body so that you can define the timestamps.
Looks like such kind of functionality doesn't exist in Thanos tests, but you can maybe refer to https://github.com/cortexproject/cortex/blob/master/integration/e2ecortex/client.go#L92.

Is there another client for doing remote write directly to the receiver, since the response in the RemoteWrite function is coming out to be nil, so the test is failing as the no. of result is 0.

@pawarpranav83
ts=2023-12-21T10:59:46.371117672Z caller=remoteWriteFakeMetric msg="<nil> query-frontend-querier-1:8080 [10 116 10 13 10 3 106 111 98 18 6 109 121 115 101 108 102 10 18 10 10 112 114 111 109 101 116 104 101 117 115 18 4 116 101 115 116 10 12 10 7 114 101 112 108 105 99 97 18 1 48 10 27 10 7 114 101 99 101 105 118 101 18 16 114 101 99 101 105 118 101 45 105 110 103 101 115 116 111 114 10 27 10 9 116 101 110 97 110 116 95 105 100 18 14 100 101 102 97 117 108 116 45 116 101 110 97 110 116 18 7 16 232 130 160 224 200 49] &{POST http://query-frontend-querier-1:8080/api/v1/receive HTTP/1.1 1 1 map[Content-Encoding:[snappy] Content-Type:[application/x-protobuf] X-Prometheus-Remote-Write-Version:[0.1.0]] {0xc000ba2720} 0x78d560 116 [] false query-frontend-querier-1:8080 map[] map[] <nil> map[]   <nil> <nil> <nil> {{}}} [{[{job myself {} [] 0} {prometheus test {} [] 0} {replica 0 {} [] 0} {receive receive-ingestor {} [] 0} {tenant_id default-tenant {} [] 0}] [{0<PHONE_NUMBER>104 {} [] 0}] [] [] {} [] 0}] Post \"http://query-frontend-querier-1:8080/api/v1/receive\": dial tcp: lookup query-frontend-querier-1 on <IP_ADDRESS>:53: server misbehaving\n"

This is the error. The address you specified is incorrect. You should write to receiver, not querier

Still getting the same error :(
Also tried changing the receiver name to something unique so there is no clash with the other receivers that are running in parallel.
so the dial tcp lookup : server misbehaving - is supposed to be a dns resolving issue sometimes, how do we solve this in tests?
https://github.com/pawarpranav83/thanos/actions/runs/7297124924/job/19885899280#logs - remoteWriteFakeMetric.

Ok so the RemoteWrite function is working, but the queries do not return any result.
Is there something wrong with the metric (samplesrw) that we are sending to receiver?

You need to change the input labels. The query requires up metric, correct?
I don't see you set the metric name label in your remote write

Actaully, timestamp prob is still there, it has to be predefined (looking at other examples) and also have to change it in other tests.
Will make proper commit messages for all changes and proper linting and comments with a new PR later, this one seems pretty messy :)

so, when the time is set to current time, the cache tests work, but when set to predefined value, the querier_cache_added_total doesn't match, and after commenting that out, the http_requests_total doesn't match.
How do we solve this?

@pawarpranav83 Just go ahead and update the metric to the value in the real execution. And let's see if the values are flaky or not.
querier_cache_added_total is now always 1 because you only ingest data once so the data always cached and no new data added to cache.

ok so in same range query, cache hit -
Changed querier_cache_added_total to 1 and http_requests_total to 1.
And in range query > 24h should be split changed -
cortex_cache_fetched_keys_total to 4
querier_cache_added_new_total to 2
querier_cache_entries to 2
querier_cache_gets_total to 4
querier_cache_misses_total to 2
http_requests_total to 3
Doubt - We ingest data only once, when time is set to now, then, why was it working that time?

I didn't check but now timestamp might be flaky and affect how queries are split

ok, should I make these changes final, and update other functions as well?
And also I think I should make a new PR with proper commit messages, is that ok?

ok, should I make these changes final, and update other functions as well? And also I think I should make a new PR and make changes with proper commit messages, is that ok?

Why a new PR; you can just rebase/amend the commits in this one, right?

I think it's ready.
Are there any more changes to be made? @yeya24 @MichaHoffmann

For my money: can you squash the commits into one with a commit message like "tests: use remote write in query frontend tests" or something like that?

Any way we can re-run the docs test?


Added histogram to hvplot

Thanks for contributing to the sprint! Please reach out if you have any questions. And open a PR when you have the violin example ready :)


#295 Fix NPE for listing plugins when connector class not found

Addresses #295

CC @gunnarmorling 😃

Applied; thank you so much, @C0urante!


Render Rich Card Carousel (Google Style) on Live Chat Plugin

Carousel cards

Carousel is limited to a minimum of 2 and a maximum of 10 cards
The carousel controls ideally should be triggered by keyboard or click navigation
Each card within the carousel should provide a button with a different option to be chosen

depends on #671

{
   "conversation_id": "UUID",
   "message": {
      "fallback": 'Card #1\n #1\n\nCard #2\n\n\nReply with \"Card #1\" or \"Card #2\"',
      "richCard": {
      "carouselCard": {
        "cardWidth": "MEDIUM",
        "cardContents": [
          {
            "title": "Card #1",
            "description": "The description for card #1",
            "suggestions": [
              {
                "reply": {
                  "text": "Card #1",
                  "postbackData": "card_1"
                }
              }
            ],
            "media": {
              "height": "MEDIUM",
              "contentInfo": {
                "fileUrl": "https://storage.googleapis.com/kitchen-sink-sample-images/cute-dog.jpg",
                "forceRefresh": "false",
              }
            }
          },
          {
            "title": "Card #2",
            "description": "The description for card #2",
            "suggestions": [
              {
                "reply": {
                  "text": "Card #2",
                  "postbackData": "card_2"
                }
              }
            ],
            "media": {
              "height": 'MEDIUM",
              "contentInfo": {
                "fileUrl": "https://storage.googleapis.com/kitchen-sink-sample-images/elephant.jpg",
                "forceRefresh": "false",
              }
            }
          }
        ]
      }
    }
   }
}


PipelineRuns are all in kabanero namespace

Currently, when the pipelines execute, it always occurs in the kabanero namespace (the PipelineRun CR exists in that namespace).  This means that pipeline executions from all different workloads are jumbled together making it very difficult to distinguish between them.
A better approach would be for pipelines to run in the namespace that they are deploying into.
For example, if the user has added:
spec:
  targetNamespaces:
  - my-app

to their Kabanero CR, the pipeline could run in the my-app namespace. This would give the user ownership over their PipelineRun and make usage and investigation much clearer.

This does mean that the build would consume resources in the deployment namespace which is perhaps not ideal. We could look at other approaches, let's keep the issue for the root problem of the indistinguishability of PipelineRuns in the kabanero namespace.

We have been trying to introduce the concept of a pipeline namespace (a single one) that runs builds.  It is not desirable to have the builds running in the control namespace (kabanero), nor do I think it's desirable to have them running in the app deploy namespaces, although I can see how that would be convenient on some levels.
Please have a look at kabanero-io/kabanero-operator#230 and let us know if this addresses some of your concerns.

Thanks @kaczyns - closing in favour of https://github.com/kabanero-io/kabanero-operator/issues/230


feat: upgrade codegen for kubernetes to v0.28.3

What does this PR do?
This PR upgrade kubernetes code gen to the latest version v0.28.3
Motivation
Be up to date
More

[x] Added/updated tests
[x] Added/updated documentation

Additional Notes

@mmatur We could do this upgrade directly on v2.10, WDYT?

@mmatur We could do this upgrade directly on v2.10, WDYT?

Yes sure. Feel free to rebase my PR on v2.10.


Add triton.language.atomic_add to the documentation?

It looks like there is a function for atomic addition (atomic_add) in the language.py file:
@builtin
def atomic_add(pointer, val, mask=None, builder=None):
    """
    Performs an atomic add and the memory locations specified by :code:`pointer`.
    :param pointer: The memory locations which contain the old values
    :type pointer: Block of dtype=triton.PointerDType
    :param val: The values to add
    :type val: Block of dtype=`pointer.dtype.element_ty`
    :param mask: If mask[idx] is false, :code:`pointer[idx]` is unaffected.
    :type mask: Block of triton.int1, optional
    """
    return frontend.atomic_add(pointer, val, mask, builder)

Any specific reason it's not on the documentation page yet?

Similarly for the functions:
atomic_xor, atomic_max, atomic_min, atomic_and, atomic_or, atomic_xor

Just tested it out with an example and it appears that the atomic_add function doesn't work as intended. Tried writing a function that would take a long array as an input and attempt to calculate the piecewise sum in parts, and aggregate it with atomic_add.
@triton.jit
def add_kernel(
    x_ptr,
    a_output_ptr,
    n_elements,  # Size of the vector
    **meta,  # Optional meta-parameters for the kernel
):
    BLOCK_SIZE = meta['BLOCK_SIZE']

    pid = tl.program_id(axis=0)
    block_start = pid * BLOCK_SIZE
    offsets = block_start + tl.arange(0, BLOCK_SIZE)
    mask = offsets < n_elements

    x = tl.load(x_ptr + offsets, mask=mask)
    a_val = tl.sum(x, axis = 0)
    tl.atomic_add(a_output_ptr, a_val)

def add(x: torch.Tensor):
    a_output = torch.zeros(1, device='cuda:0')
    assert x.is_cuda and a_output.is_cuda
    n_elements = x.shape[0]
    grid = lambda meta: (triton.cdiv(n_elements, meta['BLOCK_SIZE']),)
    add_kernel[grid](x, a_output, n_elements, BLOCK_SIZE=8)
    return a_output

Testing code:
size = 16
x = torch.rand(size, device='cuda')
output_triton = add(x)
print(x)
print("Triton sum: ", print(output_triton))
print("Actual sum: ", x.sum())
print("A = Sum (first 8 elements): ", x[0:8].sum())
print("B = Sum (last 8 elements): ", x[8:].sum())
print("A + 2B =", x[0:8].sum() + 2 * x[8:].sum())

Output:

tensor([0.3990, 0.5167, 0.0249, 0.9401, 0.9459, 0.7967, 0.4150, 0.8203, 0.2290,
        0.9096, 0.1183, 0.0752, 0.4092, 0.9601, 0.2093, 0.1940],
       device='cuda:0')
tensor([11.0681], device='cuda:0')
Triton sum:  None
Actual sum:  tensor(7.9633, device='cuda:0')
A = Sum (first 8 elements):  tensor(4.8586, device='cuda:0')
B = Sum (last 8 elements):  tensor(3.1047, device='cuda:0')
A + 2B = tensor(11.0681, device='cuda:0')

Hey!
You're right that the documentation for atomic_add is missing. atomic_cas is more experimental though, but the docs can flag it. I will write a PR that adds the Atomics section and corresponding functions there: https://raw.githubusercontent.com/openai/triton/master/docs/python-api/triton.language.rst. But of course feel free to directly submit a PR yourself (or any similar missing docs you find in the future).
The atomic_add issue is a known issue I am planning to tackle over the next few weeks. It is a bit tricky. Indeed, you can note that the following code works:
import triton
import triton.language as tl
import torch

@triton.jit
def add_kernel(
    x_ptr,
    a_output_ptr,
    n_elements,  # Size of the vector
    **meta,  # Optional meta-parameters for the kernel
):
    BLOCK_SIZE = meta['BLOCK_SIZE']

    pid = tl.program_id(axis=0)
    block_start = pid * BLOCK_SIZE
    offsets = block_start + tl.arange(0, BLOCK_SIZE)
    mask = offsets < n_elements

    x = tl.load(x_ptr + offsets, mask=mask)
    a_val = tl.sum(x, axis = 0)
    tl.atomic_add(a_output_ptr, a_val)

def add(x: torch.Tensor):
    a_output = torch.zeros(1, device='cuda:0')
    assert x.is_cuda and a_output.is_cuda
    n_elements = x.shape[0]
    grid = lambda meta: (triton.cdiv(n_elements, meta['BLOCK_SIZE']),)
    add_kernel[grid](x, a_output, n_elements, BLOCK_SIZE=128)
    return a_output

size = 256
x = torch.rand(size, device='cuda')
output_triton = add(x)
print(x)
print("Triton sum: ", print(output_triton))
print("Actual sum: ", x.sum())

This is because Triton by default parallelize kernels over 4 warps (128 threads). But the parallelization engine currently does not mask out useless threads when there are less than 128 elements in the block... so you end up with more accumulations than you should. Anyway, I am about to polish the parallelization engine and I hope I'll get to address that.

The atomic_add bug is still here, but the documentation has been updated https://triton-lang.org/python-api/generated/triton.language.atomic_add.html#triton.language.atomic_add

I assume the bug is still there ? Feels like I'm hitting it, asking just in case. The 128 limitation could be an ok workaround I guess

fixed


links in documentations are not working

and some paths are not updated yet
the old path /examples  now the new path /web3wg/examples


Page Module Convention

TODO app requires multiple pages to be built. The pages are built with Javascript and DOM, so for each page there is a pageName.js module.
pageName.js
This module is responsible for one or more things:

Builder Functions

Calls modifyDom to build the elements of the page, and provides the data to construct the elements
Exported so other modules can import

Utility Functions

Functions called by events on that page, and any additional functions required for these functions to work
Used within the Page Module

import ...

const pageNameUtilities = function pageNameUtilityFunctions() {
    ....
}

const pageNameBuilder = function pageNameConstructionFunctions() {
    ....
}

export { pageNameBuilder };

The module is imported in the navLinks module and initialized. The initialization name should be constructPageName.
Pages
Lists

[x] Builder
[x] Utilities

Settings

[x] Builder
[x] Utilities

About

[x] Builder

Update navLinks

[ ] Settings
[ ] About

Completed


MSID: 88984 Version: 1 DOI: 2<IP_ADDRESS>5751

[PLACE MANUSCRIPT AND EDITOR DETAILS HERE WHEN AVAILABLE] See step 3
[PLACE PDF URL HERE WHEN AVAILABLE] See step 7
Step 1. Inform bioRxiv
Who can help: @QueenKraken, @nlisgo, @scottaubrey

[x] Manuscript is in data hub index (https://data-hub-api.elifesciences.org/enhanced-preprints/docmaps/v1/by-publisher/elife/get-by-manuscript-id?manuscript_id=88984)

Step 2. Create preview of manuscript
Who can help: @fred-atherden, @nlisgo, @scottaubrey

[ ] Manuscript is available for preview (https://prod--epp.elifesciences.org/preview/88984/v1)

[ ] Trigger import for staging: https://prod--epp.elifesciences.org/import
[ ] Sync data folder with s3://prod-elife-epp-data/data
[ ] Trigger import for staging: https://staging--epp.elifesciences.org/import
[ ] Sync data folder with s3://staging-elife-epp-data/data
[ ] Pull request created to enhanced-preprint-data
[ ] Post link to pull request below

Pull request: https://github.com/elifesciences/enhanced-preprints-data/pull/113
Detailed instructions: https://github.com/elifesciences/enhanced-preprints-data#add-a-manuscript
Step 3: Awaiting public reviews
Who can help: Editorial team

[ ] Public reviews available on sciety (https://sciety.org/articles/activity/10.1101/2<IP_ADDRESS>5751)
[ ] Manuscript and editor details at the top of this issue (Supplied by Editorial team)
[ ] Reviews returned by EPP - https://prod--epp.elifesciences.org/api/reviewed-preprints/88984/v1/reviews

Example
"msas": "Genetics and Genomics", "Neuroscience"
"msid": "84628"
"version": "1"
"preprintDoi": "10.1101/2<IP_ADDRESS>4241"
"articleType": "Reviewed Preprint"
"status": "Published from the original preprint after peer review and assessment by eLife."

"Reviewed Preprint posted": "2023-01-02"
"Sent for peer review": "2022-10-28"
"Posted to bioRxiv": "2022-11-21" (link: "Go to bioRxiv": "https://www.biorxiv.org/content/10.1101/2<IP_ADDRESS>4241v1")

Editors:
Reviewing Editor
Michael B Eisen
University of California, Berkeley, United States
Senior Editor
Michael B Eisen
University of California, Berkeley, United States

Step 4: Modify manuscripts.json (no PDF)

[ ] Reviewed preprint is published to EPP (https://elifesciences.org/reviewed-preprints/88984)

[ ] Pull request created to enhanced-preprint-client
[ ] Pull request switched to "Ready for review"
[ ] Post link to pull request below

[ ] Request that a doi be registered

[ ] Post link to #enhanced-preprint comment below

Pull request: [PLACE LINK TO PULL REQUEST HERE]
#enhanced-preprint comment thread: [PLACE LINK TO COMMENT HERE]

Instructions to modify manuscripts.json

Visit: https://github.com/elifesciences/enhanced-preprints-client/actions/workflows/publish-manuscript.yaml
Click: Run workflow
Complete the form and click "Run workflow"
A successful run should result in a new pull request at https://github.com/elifesciences/enhanced-preprints-client/pulls
Open the pull request and click the "Ready for review" button to trigger tests
Once the tests pass and you are happy with the changes the PR can be merged

Example pull request: https://github.com/elifesciences/enhanced-preprints-client/pull/334/files
Once the pull request is merged in it should be available a few minutes later.

Request that a doi
Post the following in #enhanced-preprint:
@Fred can you register a doi for https://elifesciences.org/reviewed-preprints/88984

Step 5: Awaiting search reindex

[ ] Reviewed preprint is avaliable on journal homepage (https://elifesciences.org)

The search reindex is triggered once an hour. We need the reviewed preprint to be indexed as the search application serves the journal homepage.

Additional info
If needed, the jenkins pipeline to reindex search can be triggered sooner.
https://alfred.elifesciences.org/job/process/job/process-reindex-reviewed-preprints/

Step 6: Published! Request PDF generation

[ ] Post the link to the PDF url at the top of the issue

[ ] Post link to #enhanced-preprint comment below

#enhanced-preprint comment thread: [PLACE LINK TO COMMENT HERE]
Post the following to the #enhanced-preprint on slack:
@Ryan Dix-Peek please can you generate a PDF for https://elifesciences.org/reviewed-preprints/88984

Step 7: Introduce PDF to data folder and git repo

[ ] PDF is avaliable at https://github.com/elifesciences/enhanced-preprints-data/raw/master/data/88984/v1/88984-v1.pdf

Detailed instructions: https://github.com/elifesciences/enhanced-preprints-data#add-a-pdf
Step 8: Add PDF url to manuscripts.json

[ ] Reviewed preprint PDF is available for download (https://prod--epp.elifesciences.org/reviewed-preprints/88984)

[ ] Pull request created to enhanced-preprint-client
[ ] Pull request switched to "Ready for review"
[ ] Post link to pull request below

[PLACE LINK TO PULL REQUEST HERE]

Instructions to add PDF url to manuscripts.json

Visit: https://github.com/elifesciences/enhanced-preprints-client/actions/workflows/add-pdf-url-to-manuscript.yaml
Click: Run workflow
Complete the form and click "Run workflow"
A successful run should result in a new pull request at https://github.com/elifesciences/enhanced-preprints-client/pulls
Open the pull request and click the "Ready for review" button to trigger tests
Once the tests pass and you are happy with the changes the PR can be merged

Example pull request: https://github.com/elifesciences/enhanced-preprints-client/pull/397/files
Once the pull request is merged in it should be available a few minutes later.

Step 9: Done!

[ ] Kettle is on!

Supp files on the preprint includes identifying information, which may need to be removed

Will need a new preview, based on V12 of the preprint.

Hi @fred-atherden, sorry, the authors needed to remove some identifying information from their preprint, so we'll need to use v12 for the RP v1. Do we need to ask Ash to ask for anything, or should V12 become available soon? Thanks!

Hmmm, actually, the authors say we should use V11, so I think we're okay!

Thanks Andy! It looks like we're currently using version 10.
This is the only one currently returned by bioRxiv's API:
curl 'https://api.biorxiv.org/meca_index/elife/all/2<IP_ADDRESS>5751' | jq
{
  "status": [
    {
      "count": 1,
      "messages": "ok"
    }
  ],
  "results": [
    {
      "msid": "525751",
      "tdm_doi": "10.1101/2<IP_ADDRESS>5751",
      "ms_version": "10",
      "filedate": "2023-05-05",
      "tdm_path": "s3://transfers-elife/biorxiv_Current_Content/May_2023/05_May_23_Batch_1602/f2acec8c-6cea-1014-bbda-83a28c7c7826.meca",
      "transfer_type": "api"
    }
  ]
}

It looks like version 11 doesn't have full text yet, so we'd need to wait until that is available if version 11 is what we want to use (in place of version 10).

Thanks @fred-atherden do we need to move this back a few steps? We would like to use V11! Thank you!

@QueenKraken, full text for version 11 is available at bioRxiv, but it's not being returned by their API:
curl 'https://api.biorxiv.org/meca_index/elife/all/2<IP_ADDRESS>5751' | jq
{
  "status": [
    {
      "count": 1,
      "messages": "ok"
    }
  ],
  "results": [
    {
      "msid": "525751",
      "tdm_doi": "10.1101/2<IP_ADDRESS>5751",
      "ms_version": "10",
      "filedate": "2023-05-05",
      "tdm_path": "s3://transfers-elife/biorxiv_Current_Content/May_2023/05_May_23_Batch_1602/f2acec8c-6cea-1014-bbda-83a28c7c7826.meca",
      "transfer_type": "api"
    }
  ]
}

Please can you check with Ted?

(Reviews added/available)

I've messaged Ted.


Implement conversions (#180312665)

Pull Request Description
Data analysts should be provided with a unified way to convert between data structures (from method)
Important Notes
This was slightly harder than expected.
Implemented a notion of an UnresolvedConversion.
This allows the user to write
type Foo foo
type Bar bar
type Baz baz

Foo.from (that:Bar) = Foo that.bar

Foo.from (that:Baz) = Foo that.baz

main = (Foo.from (Bar 10)).foo + (Foo.from (Baz 20)).foo

In addition to handling atoms and atom constructors properly we also handle Text (both foreign and domestic), functions, arrays and all the other built-in types of the language.
The format of a conversion is required to be
<Type>.from (that:<Type>) <other arguments> = ...

the name of the first parameter must be that or _, and all other arguments must be defaulted.
Overloading is used to resolve the dispatch of the from method.
Overloads resolve from the most specific type of that to the least.
An incidental issue had to be fixed along the way:
All type level errors were being swallowed by the compiler. Notably, operator methods could not be typed, but the error for this was being swallowed silently by the compiler.
UnresolvedConversions are exposed to users like any other UnresolvedSymbols in the Meta API. The user should see no difference (other than the dynamic overloading behavior).
Extension conversions can be defined in imported modules just like extension methods.
Documentation should be supplied as we update the standard library to use this feature.
Checklist
Please include the following checklist in your PR:

[ ] The documentation has been updated if necessary.
[X] All code conforms to the Scala, Java, and Rust style guides.
[X] All documentation and configuration conforms to the markdown and YAML style guides.
[X] All code has been tested where possible.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@ekmett please update the docs. I don't see that the new syntax of conversion functions is described anywhere (presumably it should go to the docs/syntax/functions.md doc). Also, it is worth describing the implementation the docs/runtime/function-call-flow.md

Also, do you plan to support the complex types?
i.e. the case
type Maybe
    type Some value
    type Nothing

Maybe.from (that : Any) = Some that

The direction you gave in your Maybe example should work (insofar as it parses) today. The other direction converting from a Maybe, has to be written case by case off the actual constructors for Some and Nothing, but conversions into something that is morally a sum type should just work.
@wdanilo and @kustosz want to make "proper" sum types, but that starts to expose all sorts of infelicities in the type system (or lack thereof as the case may be). With those in hand, we'd be able to define the other direction where you have
Foo.from (that : Maybe) = ...

Doing that today will fail because the maybe Atom is never constructed. You should be able to use
Foo.from (that : Some) = ...
Foo.from (that : Nothing) = ...

as a workaround for the lack of first class sum types today.
Having conversions adds a lot of pressure to make those things real.

@ekmett @4e6
Maybe.from won't work currently, simply because Maybe is not an object one could reference (it disappears very early in the compilation process).
Moreover, thinking about this example has made me realize that we probably have a bug in the current code for methods desugaring. Thing is, in Maybe.from, Maybe is in a contravariant position, while our desugaring of methods assumes this to be covariant. Which is to say this:
type Maybe
    type Some a
    type None

    from (x: My_Type) = None

Will desugar to:
type Some a
type None

None.from (x: My_Type) = None
Some.from (x: My_Type) = None # THIS IS HOPELESSLY BROKEN!

A glance at the code tells me this is actually the case.
We need to fix this and explicitly disallow from definitions inside sum type definitions, until we make Maybe into a thing that could be referenced, and can make the desugaring yield the correct code:
Maybe.from (x:My_Type) = None

Ugh. It is even worse than I feared.

There are some failing tests in the last CI run: https://github.com/enso-org/enso/runs/4819644988?check_suite_focus=true
You can use runtime/test SBT command to run all the runtime tests locally, or runtime/testOnly *.TailCallTest to run individual test suite, or runtime/testOnly *.TailCallTest -- -z "in tail position" to run individual tests

The errors for RuntimeErrorsTest.scala seem to be unrelated. Something is switching some block of ExpressionUpdates in for what used to be an ExecutionUpdate? But we never touched anything around panics themselves.

Builtins module produces syntax errors, which messes up the expected messages in runtime tests. I guess, since the Builtins module is synthetic, we can ignore errors and warnings that it is producing. I'll push a comment to this branch that filters out unwanted diagnostic messages.

Builtins module produces syntax errors, which messes up the expected messages in runtime tests. I guess, since the Builtins module is synthetic, we can ignore errors and warnings that it is producing. I'll push a comment to this branch that filters out unwanted diagnostic messages.

No no no, it is quite important for Builtins to still compile. I'm going to fix it instead :)

@kustosz feel free to revert my commit then

Do we have any remaining blockers?


LabNAT not working

So everything seems to running fine, but when I type Enable-Internet, i don't get an error, but I don't see a switch in Hyper-V appear for it...only my physical and LabNET (not NAT).

This isn't creating a new switch. If you run Get-VMSwitch you should see one called LabNet which is internal. Run Get-NetNat. That is what Enable-Internet is creating.

OOOOKkkkkk.....so if "Enable-Internet" doesn't create a switch...what does it do? After you do a setup-lab you get "To enable Internet access for the VM's, run: Enable-Internet".... I assumed that meant it would setup a NATed enviroment...but nothing happened...I got a returned command prompt within 1/2 second.... UPDATE: I redid my installation tonight...this time when I ran Enable-Internet, I did get come output:
IPAddress         : <IP_ADDRESS>
InterfaceIndex    : 35
InterfaceAlias    : vEthernet (LabNet)
AddressFamily     : IPv4
Type              : Unicast
PrefixLength      : 24
PrefixOrigin      : Manual
SuffixOrigin      : Manual
AddressState      : Tentative
ValidLifetime     : Infinite ([TimeSpan]::MaxValue)
PreferredLifetime : Infinite ([TimeSpan]::MaxValue)
SkipAsSource      : False
PolicyStore       : ActiveStore
IPAddress         : <IP_ADDRESS>
InterfaceIndex    : 35
InterfaceAlias    : vEthernet (LabNet)
AddressFamily     : IPv4
Type              : Unicast
PrefixLength      : 24
PrefixOrigin      : Manual
SuffixOrigin      : Manual
AddressState      : Invalid
ValidLifetime     : Infinite ([TimeSpan]::MaxValue)
PreferredLifetime : Infinite ([TimeSpan]::MaxValue)
SkipAsSource      : False
PolicyStore       : PersistentStore
If I type Get-NetNat....nothing...just a command prompt (within 1/2 second)

You should look at the module file and see what the Enable-Lab function is doing. I know that the NAT cmdlets are still a little jiggly in the middle. Still, something seems off here. What operating system are you running and what version of PowerShell (use $PSVersionTable).

So, the Switch name is specified in the Configuration Data -- it gets created when the lab env is built. The Enable-Internet then turns on the nat based on that name.  Are we good to close this?

Yep
Please excuse any typos as this email is coming from my non-fruity phone ;-)
W. Dale Meredith
MCT, MCSE, MCTS, MCSA, MCITP, CEH, CEI, Pluralsight Author
My Mentored Learning, Inc.
email<EMAIL_ADDRESS>
From: Jason Helmick<EMAIL_ADDRESS>Sent: Jun 10, 2017 10:20 AM
To: theJasonHelmick/PS-AutoLab-Env
Cc: SuperDale007; Author
Subject: Re: [theJasonHelmick/PS-AutoLab-Env] LabNAT not working (#75)
So, the Switch name is specified in the Configuration Data -- it gets created when the lab env is built. The Enable-Internet then turns on the nat based on that name. Are we good to close this?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/theJasonHelmick/PS-AutoLab-Env/issues/75#issuecomment-307575054, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ARMvKT8y__mESJcGRpizuLAoHwdHO_-Mks5sCsI_gaJpZM4LOu_-.

Thank you Dale!


Region props returns unusual images

Looking at the underlying intensity images of every regionprop, it appears to be bound to a circle with some bright boundaries:
Google Slide with pics
The potential concerns are :

regionprop centroid moves too far from expected position for "comet" spots
The underlying intensity image does not reflect the image in the bounding box.  Instead it appears to be bound by a circle (not necessarily the mask)

I will investigate the effect of the eccentricity filter on these spots

Combination of current segmentation and filtering parameters miss many spots, especially ones that are dim. Here is an overlay of images of wells and locations assigned by generate_props_dict. Spot detection anomalies that you see may be related to this:

The mis-assignment of spots is coming from initialization of props_array and bgprops_array variables outside of the loop.
When I exported the ODs in a 2D array constructed from props_array, I saw this for well A4 when props_array is initialized outside of the loop:
| 0 | 1 | 2 | 3 | 4 | 5 | 6 | 7
-- | -- | -- | -- | -- | -- | -- | -- | --
0 | 1.563201 | 1.345141 | 2.997746 | 2.099849 | 1.298738 | 1.656746 | 1.234147 | 1.612831
1 | 1.445509 | 1.374727 | 2.966517 | 1.26165 | 1.434695 | 1.727706 | 1.693654 | 3.557503
2 | 1.878842 | 1.283533 | 2.784524 | 1.269079 | 3.145995 | 1.286808 | 1.879973 | 1.764097
3 | 1.930243 | 1.263281 | 1.161575 | 1.27429 | 2.603671 | 1.589525 | 1.884354 | 1.671318
4 | 1.747058 | 1.263491 | 3.271377 | 1.74045 | 1.175276 | 2.221479 | 1.468281 | 4.615932
5 | 1.447847 | 1.286702 | 1.528258 | 1.237907 | 2.430797 | 2.050472 | 1.349602 | 1.405774
This is not correct, because as above image shows, many spots are not detected in well A4.
Once props_array is initialized inside the loop, et voila:
| 0 | 1 | 2 | 3 | 4 | 5 | 6 | 7
-- | -- | -- | -- | -- | -- | -- | -- | --
0 |   | 1.345141 | 2.997746 |   | 1.298738 |   | 1.234147 | 1.612831
1 | 1.445509 |   | 2.966517 | 1.26165 |   |   |   | 3.557503
2 | 1.878842 | 1.283533 |   |   |   |   |   |
3 | 1.930243 |   | 1.161575 |   |   |   |   |
4 | 1.747058 |   |   |   | 1.175276 |   |   |
5 | 1.447847 |   |   | 1.237907 |   |   |   | 1.405774

good and important catch, this explains quite a few things -- like how we saw an off-center spot where there should not have been.


Configurations/10-main.conf: fix VC-noCE-common template.

picker() is type agnostic, but its output's consumer is not. Or rather
it doesn't work if picker() picks nothing when consumer expects
array. So ensure array is returned when array is expected.
[skip ci]
I'm using glitch that [skip ci] is ineffective in appveyor context. So that Windows-specific mods will be checked on Windows. Second commit is cosmetics.

Just in case for reference. Trouble was that without default => [] a "naked" -D was injected into CNF_CPPFLAGS, so that command line looked as -D -DNDEBUG. Surprisingly enough this is valid command line options combination that effectively skips NDEBUG definition [in this example].

Thanks for finding it...  that was a tricky one...  One might have to take a close look at picker to ensure it does things "right"

picker to ensure it does things "right"

Well, picker never knows how its return value is used and has only its arguments to look at. If there is no default, would it have to examine all available options [instead of just selected one] to see if any of them is array?

would it have to examine all available options [instead of just selected one] to see if any of them is array?

I was thinking something like that, yeah.


[feature/idea]: lambda response streaming

AWS just announced Lambda response streaming: https://aws.amazon.com/about-aws/whats-new/2023/04/aws-lambda-response-payload-streaming/
Curious if there is potential to leverage streams here.
Thanks again for this awesome project!

Sorry, I got this project mixed up with https://github.com/jetbridge/cdk-nextjs. 🤦 Will close this for now.

cdk-nextjs now uses open-next.
0.0.0-streaming.8 is the latest streaming RC


change title data type from boolean to string in the toolbox component

I noticed that inside the features API option of the toolbox component, the titles for each of the default toolbox features had boolean as the default data type instead of the intended string

Thanks. That was a mistake.


Use rememberUpdatedState to prevent stale lambda capture

If a composable passes a lambda argument down to other composables via wrapping, lambda gets captured which may not read the latest state when executed. rememberUpdatedState fixes this problem.

Hi, @halilozercan thanks for this fix. Could you please also add it to the HarmonyColorPicker composable, to keep both in sync

Hi, @halilozercan thanks for this fix. Could you please also add it to the HarmonyColorPicker composable, to keep both in sync

@halilozercan thanks for spotting this - i've made a change in #30 for both pickers


Report failure error for a job

When a job fails not because the user's code errored, it would be helpful to report the error from inspect job.
E.g. see the bash output below. I happen to know it failed during the download input stage (from s3 rate limiting). If we could report the error to the user, that at least gives us a good place to start debugging. k8s does this a bit w last return exit code / events.
17-04-19[17:03:45]:etl-and-training:0$pc list-job
ID                                   OUTPUT COMMIT                               STARTED        DURATION           RESTART PROGRESS STATE
dff621bd-93c2-448b-9dfa-17792d592c7d preprocess_big/-                            51 minutes ago 31 minutes         0       0 / 1    failure
d40468c7-43cb-43a5-9b9d-367bf9fe9e90 preprocess_big/-                            4 hours ago    29 seconds         0       0 / 1    failure
6240e737-9dba-489f-9e4b-ffbdeca8feb2 preprocess_big/-                            23 hours ago   29 seconds         0       0 / 1    failure
e7c79922-ad70-431f-91bb-604e10c32693 preprocess_big/-                            23 hours ago   12 minutes         5       1 / 1    failure
02d76ce6-bcd1-4dba-b2f6-95dd1a5e806d preprocess_big/-                            23 hours ago   -                  6       1 / 1    killed
2a930e0a-0b4e-4909-b2bc-9e5eaa2f2088 preprocess_big/-                            25 hours ago   24 hours           6       1 / 1    failure
721b9d07-5f34-4294-92b3-6192498c7064 preprocess_big/-                            25 hours ago   25 hours           5       1 / 1    failure
f34043d0-641d-43bb-b649-36231744a2b0 preprocess_big/-                            26 hours ago   About a minute     4       1 / 1    failure
6535bd03-9f59-45be-8be8-2a8390e0fdf9 convert_tf/897a3d836134415c9177912315b4f3bc 5 days ago     6 seconds          0       1 / 1    success
e090478f-f826-4b67-a014-f63207432ee1 preprocess/a138a178eb204d419851fb0733533cfe 5 days ago     10 seconds         0       1 / 1    success
9201468c-3d4d-4ef6-8234-e7a0bf866ada convert_tf/f5bd5096ffea47b192fe1d0c54d65c21 5 days ago     4 seconds          0       1 / 1    success
92d47c60-d4e4-4431-aa01-17f61951465b preprocess/4cc6f897644e4f73b268ec9a2b89b91c 5 days ago     8 seconds          0       1 / 1    success
f8f31f3d-fa96-4b41-8879-17a58922dff8 convert_tf/-                                5 days ago     1 seconds          0       0 / 1    failure
3e00deb2-1d74-4fa1-9b40-48509b589ef3 preprocess/69874bbe441d4bac924f126b4fb0486f 5 days ago     Less than a second 0       1 / 1    success
ecc42fc2-d623-4024-b82c-d114b2f060c4 convert_tf/-                                5 days ago     1 seconds          0       0 / 1    failure
3907f795-26c6-4ce9-b559-5eef67a71309 preprocess/e9f2fbb4c65c442ebb4f34dde5cd6cc6 5 days ago     About a minute     0       1 / 1    success
17-04-19[17:28:39]:etl-and-training:0$kc logs pipeline-preprocess-big-v1-vf3c4
{"pipelineName":"preprocess_big","pipelineId":"f3ec7f3cd74f4cf298a34aa407d1699a","jobId":"dff621bd-93c2-448b-9dfa-17792d592c7d","workerId":"pipeline-preprocess-big-v1-vf3c4","data":[{"hash":"QIZyaWF3S+d40opWV1mt9dbzt+aEoha9lccyBojNMVE="},{"hash":"nDeqqUvYRwS2DRnpPlB79S2Rx+7GCGAzoKwBWls0RM8="}],"ts":"2017-04-19T23:38:54.403546269Z","message":"Received request"}
{"pipelineName":"preprocess_big","pipelineId":"f3ec7f3cd74f4cf298a34aa407d1699a","jobId":"dff621bd-93c2-448b-9dfa-17792d592c7d","workerId":"pipeline-preprocess-big-v1-vf3c4","data":[{"hash":"QIZyaWF3S+d40opWV1mt9dbzt+aEoha9lccyBojNMVE="},{"hash":"nDeqqUvYRwS2DRnpPlB79S2Rx+7GCGAzoKwBWls0RM8="}],"ts":"2017-04-19T23:38:54.539425128Z","message":"input has not been processed, downloading data"}
17-04-19[17:28:49]:etl-and-training:0$pc inspect-job dff621bd-93c2-448b-9dfa-17792d592c7d
ID: dff621bd-93c2-448b-9dfa-17792d592c7d
Pipeline: preprocess_big
Started: 52 minutes ago
Duration: 31 minutes
State: failure
Progress: 0 / 1
Worker Status:
WORKER              JOB                 DATUM               STARTED
Restarts: 0
ParallelismSpec: <nil>

Inputs:
NAME                REPO                COMMIT                             GLOB                LAZY
config              config              8fd88fce7d454774ad611bcdce639e82   /                   false
data_big            data_big            e653a32e16664eef87ee9d93314b76c6   /                   false
Transform:
{
  "image": "seandavis/davis",
  "cmd": [
    "/bin/bash"
  ],
  "stdin": [
    "echo 'starting preprocesing 14'",
    "./preprocess.py /pfs/config/config.py /pfs/data_big/ /pfs/out",
    "echo 'done preprocessing'"
  ],
  "debug": true
}
Egress: s3://tyco-etl-output/large-test-1/preprocess

stale

Jobs have a Reason field now which is used for this. It reports some errors, probably not all errors it could.


[Snyk] Upgrade io.apicurio:apicurio-registry-schema-compatibility-json from 2.1.1.Final to 2.1.3.Final

This PR was automatically created by Snyk using the credentials of a real user.Snyk has created this PR to upgrade io.apicurio:apicurio-registry-schema-compatibility-json from 2.1.1.Final to 2.1.3.Final.
:information_source: Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.

The recommended version is 2 versions ahead of your current version.
The recommended version was released a year ago, on 2021-11-17.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.
For more information:
🧐 View latest project report
🛠 Adjust upgrade PR settings
🔕 Ignore this dependency or unsubscribe from future upgrade PRs

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Make middleware depends on context

Hi!
I have middleware that prefetch async data for further react rendering and it's rely on some flags.
So that flags can be uniq for each request on server side, what means that I need something like context in middleware for each router.start(url). Or put middleware function on each router.start instead of applying it once on router creation.

In version 4.0.0, you'll be able to use closures in (router) => (toState, fromState, done). Execution will happen on start.

Great! Is there any shipping plan for 4.0.0?

End of the month is what I'm aiming for. I have two weeks holiday starting tomorrow, and during the 2nd week I'll be able to focus on it a lot more.

Middleware functions are thunks executed when registered. The returned function will be executed on each transition, and context is preserved with closures.
function(router, dependencies) {
    return function(toState, fromState, done) {
    };
}

Now i'm a little bit confused. Do we really need it If we createRouter on each http request on server side? Anyway it's necessary to run useMiddleware on each route creation

Do we really need it If we createRouter on each http request on server side

It is preferable. Since it's not stateless, you can't allow a single instance to be accessed by multiple requests.


Add join/leave messages

Adds two message types Join and Leave. The client sends one when you join or leave a channel. This is not guaranteed to happen if failures occur.
The CLI shows them like this. The GUI seems to ignore them, so that's up to them to ask for them in their get thread query.
$ kbu chat read --topic-name '#aaa' --team jlteam1
[1]  [jl2 54s] <left the channel>
[2]  [jl1 48s] hey you join this channel!
[3]  [jl2 43s] <joined the channel>
[4]  [jl2 35s] k, bye
[5]  [jl2 32s] <left the channel>

Old clients ignore these. The message caches are busted in this PR so that we don't pull incompletely decoded messages out of the cache.
Todo

[x] tests
[x] when you implicitly join/create by sending a message

The commits e1ff1d581a6e...7d6313b8daff introduce visual changes on linux. :mag_right: 1 changed

Changed: Markdown-emoji (before) (after)

Combined with your PR https://github.com/keybase/client/pull/7844 this has a sketchy property. With both PRs in if you sent a message to a channel you were previewing and GetUnverifiedConv/InboxSource.Read were slow to update then it could bounce back and forth between Join and Send, sending lots of JOIN messages.

We talked about not auto joining if the message being sent is a join message in person.

Made it not auto-join when sending a JOIN or LEAVE. Also don't send JOIN on KBFS-style chats. Passes more tests.

The commits 4cead78df49f...710512dec616 introduce visual changes on linux. :mag_right: 1 changed

Changed: Markdown-emoji (before) (after)

The commits b095a794ed52...0f5ada86ec10 introduce visual changes on linux. :mag_right: 1 changed

Changed: Markdown-emoji (before) (after)

The commits b361bb2a96a6...377478520d7e introduce visual changes on linux. :mag_right: 1 changed

Changed: Markdown-emoji (before) (after)

Ah finally. For the record, the test flake I was fighting was that in some test listener wasn't attached until after createConversation. That as previously fine. But now that createConversation causes a postMessage, it's racy unless the listener is hooked up first.


Figure out entry

How do I get rid of the entry marker on an edge? A couple of ideas:

supply starting edge before following a graph
create a special "start" node type that only has an output.

I am now pretty sure that the concept of the "entry edge" is wrong. This cases here is where it falls apart:
https://github.com/google/labs-prototypes/commit/7d0404184aba177b9f4ba7ffaa1b8d425467cf68
I have to add a special passthrough node to work around the fact that I can't feed the output of user-input into more than one node.


fix broken adding of networkx nodes

Fixes: https://github.com/QuantStack/ipycytoscape/issues/116
node_list was never getting populated

I can reproduce the issue and fix it with your fix.
Thanks a lot @ianhi for the catch =) & the fix 🌸🌸🌸


A11y: Quantity buttons have no feedback in VoiceOver

When using VoiceOver, if you click {{VO+Space}} to select either the increase or decrease quantity buttons, there is no audible indication what, if anything has changed. You have to navigate back to the input field to read the new amount.
{panel:bgColor=#fffae6}
What audible feedback should we give for the ‘decrease quantity’ button by default, when the quantity is set to 1?
{panel}

[public] Shopware automated response: This issue is linked to the internal issue: NEXT-38927
[created from NEXT-38927, comment 505549]

[public]

Status Change: In Review

Work on this ticket is complete and is now pending review.
[created from NEXT-38927, comment 511109]

[public]

FixVersion Change: <IP_ADDRESS>

This issue will be / was solved in Shopware version <IP_ADDRESS>.
[created from NEXT-38927, comment 511111]

[public]

Status Change: Resolved

The ticket has been successfully completed; the solution is implemented and verified.
[created from NEXT-38927, comment 511110]


XIVY-13510 Adapt UI

FYI: @ivy-cst, @ivy-rew, @ivy-edp
First big refactoring, reviewed some parts at desk with @ivy-rew

:crossed_fingers:

Skimmed most of it. Looks great to me👍🥇


feat(client, formatter): forge fmt

Feel free to test it on your codebase!

Package the extension with npm run package
Import the extension in VS Code with Install from VSIX... from solidity-0.0.138.vsix in the vscode-solidity project root

Choose forge as a formatter in settings

Thank you!!

Thank you, this is great.
Small thing: The formatter does not recognize formatting options written in the foundry.toml file.
Is there a way to apply those configurations?

@shekhirin ^^

yep, it's currently not respected, can confirm! Opened a PR to set current working directory during formatting: https://github.com/juanfranblanco/vscode-solidity/pull/363


feat(module): update dist to use new format

:tada: This PR is included in version 1.8.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


battery level display not a percentage

Is this a bug or a feature request?
I believe this is a bug.
What did you expect?
The battery level shown in percentage
What happened?
The battery level is displayed as provided by the device (i.e. between 1 and 254), this should be scaled in order to show an actual percentage, or the percent sign might be removed for consistency.
In case the percentage semantic is kept, I'm not sure wether the scaling should be done in the network server or in the app server.
What version are your using?
2.2.0
How can your issue be reproduced?
Activate the 'Report device battery level to application-server' and look at the reported battery level shown in the application page ( with the devices list)
Could you share your log output?
Don't think it is useful.
Thanks !

Yes, you might be right. The exposed values make sense in the context of the network-server, but I think it is indeed better to expose these as a percentage to the application-server as the 1..254 value requires knowledge about the LoRaWAN protocol.

Thanks for the fix !


Revert "Update settings for the verification Auth0 client."

Reverts mozilla/mozillians#3149

This is no longer needed since we are adding a new claim in the assertions.


Add reproducer - Squash me - Constructor with default paramater array does not work

Closed in favor of https://github.com/jolicode/automapper/pull/177


Symbolic links can cause incorrect response headers

To reproduce
echo '<!doctype html><meta charset="utf-8"><title>Test</title>Hello world' > test.html
ln -s test.html test
http-server

Then go to http://localhost:8080/test
Expected behaviour
Server resolves target (realpath?) then prepares HTTP response based on target file
Content-Type: text/html

Observed behaviour
Server does not resolve target, causing incorrect HTTP response
Content-Type: application/octet-stream; charset=utf-8

This is an issue in node-ecstatic, not http-server, see discussion in jfhbrook/node-ecstatic#168


Fix Nix install instructions

Hello, thanks for the contribution.
I think the default channel is nixpkgs when using nix standalone, but it is nixos when using NixOS. Maybe adding a comment to point this out could be useful.
Besides, if you use home-manager, I would recommend you to try nix-colors out. It exposes flavours' scheme functionalities in a way that makes more sense for declarative setups.

That makes sense. This was my first venture into Nix country, since I made this PR I've learned more about how it all usually works. I'll close this: 👍


Unable to resolve a bower module with requre('bower') in node 0.12.2 and nvm, and bower installed globally

I'm using nvm and the latest node which version is 0.12.2. Bower was installed with package-script node module at a postinstall stage, and can be found on global modules list as<EMAIL_ADDRESS>which is the latest at the moment. $which also finds bower. $bower commands them self work fine.
However, when I try to get a reference to the component with require('bower') at prepublish stage I get Error: Cannot find module 'bower'
UPD: the module can be only resolved when it is installed locally. Is this expected or not?

Yes, it's expected http://stackoverflow.com/questions/15636367/nodejs-require-a-global-module-package


feat: implement ordered multimap

Implement an ordered map with multi-values stored keys.

Codecov Report

Merging #2 (fe96752) into main (19ac2b6) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              main        #2    +/-   ##
==========================================
  Coverage   100.00%   100.00%
==========================================
  Files            6         8     +2
  Lines          472       646   +174
==========================================
+ Hits           472       646   +174

Flag
Coverage Δ

unittests
100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pkg/omap/omapbuiltin.go
100.00% <100.00%> (ø)

pkg/omap/omaplinked.go
100.00% <100.00%> (ø)

pkg/omap/omaplinkedhash.go
100.00% <100.00%> (ø)

pkg/omap/omapsimple.go
100.00% <100.00%> (ø)

pkg/omap/omapsync.go
100.00% <100.00%> (ø)

pkg/omap/util.go
100.00% <100.00%> (ø)

pkg/omultimap/omultimaplinked.go
100.00% <100.00%> (ø)

pkg/omultimap/omultimapsync.go
100.00% <100.00%> (ø)

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more


v3.1.0

Coverage decreased (-25.1%) to 74.888% when pulling 77111cded509a49536efedd9aecbaee2d0b90e7d on next into 75eff4f2b548d338a4f6dfc2b1fa0229facc11f8 on master.


python310Packages.psygnal: 0.6.0 -> 0.8.1

Changelog: https://github.com/pyapp-kit/psygnal/blob/v0.8.1/CHANGELOG.md
Kind of a test for #218077...
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 218279 run on x86_64-linux 1

7 packages built:

napari (python310Packages.napari)
python310Packages.app-model
python310Packages.magicgui
python310Packages.napari-npe2
python310Packages.psygnal
python311Packages.app-model
python311Packages.psygnal


APIs filtering by namespace

The user should be able to filter the APIs from the table by namespace from a dropdown with all the namespaces available.

PR - https://github.com/kubeshop/kusk-gateway-dashboard/pull/13


bugfix: retry-to-connect-server

Signed-off-by: yuswift<EMAIL_ADDRESS>Fix: #29
Retry to connect server when receiving log like A session already allocated for this client..

/assign @zryfish


Startup shell scripts do not set a log4j properties file

During startup of webserver, execserver, or single server, log4j is configured using a file that is taken from inside of a jar. If a user puts a log4j.properties file into the conf directory to configure the logger, this file is ignored.
Instead we should check if such a file exists in the conf directory and use it if it's there. If it doesn't exist, I think using the file already existing in the jar suffices as a default.

Done via commit 62fc290


[CARBONDATA-2381] Improve compaction performance by filling batch result in columnar format and performing IO at blocklet level

Problem: Compaction performance is slow as compared to data load
Analysis:

During compaction result filling is done in row format. Due to this as the number of columns increases the dimension and measure data filling time increases. This happens because in row filling we are not able to take advantage of OS cacheable buffers as we continuously read data for next column.
As compaction uses a page level reader flow wherein both IO and uncompression is done at page level, the IO and uncompression time increases in this model.

Solution:

Implement a columnar format filling data structure for compaction process for filling dimension and measure data.
Perform IO at blocklet level and uncompression at page level.

Note: **This PR contains the solution for point 1. For point 2 refer PR #2192 **

[ ] Any interfaces changed?
No
[ ] Any backward compatibility impacted?
No
[ ] Document update required?
No
[ ] Testing done
Manually verified
[ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
NA

Build Failed with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/4021/

Build Failed  with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/5213/

@manishgupta88 I feel here also you can use CarbonColumnVectorImpl and fill them just like how vector reader is doing, should not have separate flow again for it.

@ravipesala During compaction we retrieve dictionary values in the form of MDKey and no dictionary columns as byte array. I can make use of CarbonColumnVectorImpl but in that case I will have to write a new iterator which will fill the data column wise and then combine all dictionary MDKeys into one array and no dictionary data into one array which is input to CarbonRow. This will again have cost of combining the values. Is that ok?

SDV Build Fail , Please check CI http://<IP_ADDRESS>:8080/job/ApacheSDVTests/4478/

Build Failed  with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/5336/

SDV Build Fail , Please check CI http://<IP_ADDRESS>:8080/job/ApacheSDVTests/4487/

SDV Build Fail , Please check CI http://<IP_ADDRESS>:8080/job/ApacheSDVTests/4488/

Build Failed with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/4179/

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/5356/

Already pr raised in master PR #2210


[Hub Generated] Review request for Microsoft.CostManagement to add version stable/2023-11-01

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
ARM (Control Plane) API Specification Update Pull Request
PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

[1] ARM review queue (for merge queues, see [4])
The PRs are processed by time opened, ascending. Your PR may show up on 2nd or later page.
If you addressed Step 1 from the diagram and your PR is not showing up in the queue, ensure the label ARMChangesRequested
is removed from your PR. This should cause the label WaitForARMFeedback to be added.
[2] https://aka.ms/azsdk/support/specreview-channel
[3] List of SDK breaking changes approvers in pinned Teams announcement
[4] public repo merge queue, private repo merge queue (for ARM review queue, [1])
If you need further help with anything, see Getting help section below.
Purpose of this PR
What's the purpose of this PR? Check all that apply. This is mandatory!

[x] New API version. (Such PR should have been generated with OpenAPI Hub).
[ ] Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
[ ] Update existing version to fix swagger quality issues in S360.
[x] Other, please clarify:

Schema of the download report changed in the API

Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

[x] I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
[x] I have reviewed following Resource Provider guidelines, including
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to Step 2, "ARM Review", for this PR.

Breaking changes review (Step 1)

If the automation determines you have breaking changes, i.e. Step 1 from the diagram applies to you,
you must follow the breaking changes process.
IMPORTANT This applies even if:

The tool fails while it shouldn't, e.g. due to runtime exception, or incorrect detection of breaking changes.
You believe there is no need for you to request breaking change approval, for any reason.
Such claims must be reviewed, and the process is the same.

ARM API changes review (Step 2)

If this PR is in purview of ARM review then automation will add the ARMReview label.
If you want to force ARM review, add the label yourself.
Proceed according to the diagram at the top of this comment.

Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.
Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
Swagger-Suppression-Process
to get approval.
Getting help

For general PR approval workflow, see the diagram at the top of this comment.
For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
and https://aka.ms/ci-fix.
If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

/pr RequestMerge

Please get SDK breaking change approved, see https://github.com/Azure/azure-rest-api-specs/pull/26652/checks?check_run_id=18544868553
After that, add back the merge label

/pr RequestMerge

/pr RequestMerge


A few fixes

Description

Motivation and Context

Fixes https://github.com/BrainJS/brain.js/issues/262
Fixes https://github.com/BrainJS/brain.js/issues/286 (not yet, pending)
How Has This Been Tested?

Screenshots (if appropriate):
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Author's Checklist:

[ ] My code focuses on the main motivation and avoids scope creep.
[ ] My code passes current tests and adds new tests where possible.
[ ] My code is SOLID and DRY.
[ ] I have updated the documentation as needed.

Reviewer's Checklist:

[ ] I kept my comments to the author positive, specific, and productive.
[ ] I tested the code and didn't find any new problems.
[ ] I think the motivation is good for the project.
[ ] I think the code works to satisfies the motivation.

@mrorigo may I get your review on this?

Looks good to me, please merge


Update latest version to v1.32.0

What type of PR is this?
/kind documentation
What this PR does / why we need it:
Update the latest release in the README.md.
Which issue(s) this PR fixes:

Follow-up on https://github.com/kubernetes-sigs/cri-tools/issues/1701
Special notes for your reviewer:
None
Does this PR introduce a user-facing change?

None

@kubernetes-sigs/cri-tools-maintainers PTAL