Best of both worlds: sass + css-modules + tailwind

using sass with css-modules and tailwindcss
renaming all *.module.css to *.module.scss (though *.module.css still allowed extension, see mocks.d.ts)
updating tailwindcss to latest version (3.x)

P.S. Not sure is we need to close #3701 since it requests to convert all style files to modules.
Or we could close & create new issue like "convert all possible *.scss -> *.module.scss" (or just do it incrementally or even keep part of the old styling files untouched if doesn't hurt).
Example:
// typical style module file: component.module.scss
.Component {
   padding: var(--padding);
   @apply mt-2, some-other, tailwind-stuff; // use anything from tailwind (!)
   @include sass-mixin, etc; // keep using sass features (!)

  .other {
   color: red;
  }
}

Usage inside react component:
import styles from "./component.module.scss"

render(){
 return (

     Some text is important

  )
}

Let's keep #3701 opened until all styles are converted to css modules.


HADOOP-18711. Upgrade nimbus jwt jar due to issues in its embedded shaded json-smart code

Description of PR
How was this patch tested?
For code changes:

[x] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
[ ] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[x] If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

Why this filter isn’t required in trunk?

Why this filter isn’t required in trunk?

Probably because of this dependency version:
<dependency>
  <groupId>org.codehaus.mojo</groupId>
  <artifactId>extra-enforcer-rules</artifactId>
  <version>1.0-beta-3</version>
</dependency>

In trunk, the version is 1.5.1 and the upgrade is done in HADOOP-18131. This new version seems to have changes in enforcer rules.

well, you get to cherrypick that and any followups you can see off the jira. that's the way it goes I'm afraid.

Actually, we have tried porting HADOOP-18131 to branch-3.3 previously and I checked it again too, but we were/are getting this compilation issue:
Dependency convergence error for log4j:log4j:jar:1.2.17:test paths to dependency are:
+-org.apache.hadoop:hadoop-yarn-server-timelineservice-documentstore:jar:3.3.9-SNAPSHOT
  +-org.mockito:mockito-core:jar:2.8.9:test
    +-net.bytebuddy:byte-buddy-agent:jar:1.6.14:test
      +-com.kohlschutter.junixsocket:junixsocket-native-common:jar:2.0.4:test
        +-com.kohlschutter.junixsocket:junixsocket-common:jar:2.0.4:test
          +-log4j:log4j:jar:1.2.17:test
and
+-org.apache.hadoop:hadoop-yarn-server-timelineservice-documentstore:jar:3.3.9-SNAPSHOT
  +-org.mockito:mockito-core:jar:2.8.9:test
    +-net.bytebuddy:byte-buddy-agent:jar:1.6.14:test
      +-com.kohlschutter.junixsocket:junixsocket-native-common:jar:2.0.4:test
        +-log4j:log4j:jar:1.2.17:test
and
+-org.apache.hadoop:hadoop-yarn-server-timelineservice-documentstore:jar:3.3.9-SNAPSHOT
  +-com.microsoft.azure:azure-cosmosdb:jar:2.4.5:compile
    +-com.fasterxml.uuid:java-uuid-generator:jar:3.1.4:compile
      +-log4j:log4j:jar:1.2.13:provided

It kind of comes down to log4j in trunk vs reload4j in branch-3.3.  So, either we can try some exclusions/replacements while porting HADOOP-18131 or we can go with current filters in this PR.

Hi @ayushtkn , following up on above comment, I think there are two options to proceed further:

One is to cherry-pick HADOOP-18131 but adding log4j exclusions due to log4j  in trunk  and reload4j  in branch-3.3.
Another one is to retain the filters in this PR.

I was thinking of going with second one for the moment as the first one might complicate things further. Please provide your input on the same.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
7m 35s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+0 :ok:
xmllint
0m  0s

xmllint was not available.

+0 :ok:
shelldocs
0m  0s

Shelldocs was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ branch-3.3 Compile Tests _

+0 :ok:
mvndep
36m 26s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
24m  7s

branch-3.3 passed

+1 :green_heart:
compile
17m 53s

branch-3.3 passed

+1 :green_heart:
mvnsite
25m 14s

branch-3.3 passed

+1 :green_heart:
javadoc
7m  0s

branch-3.3 passed

+1 :green_heart:
shadedclient
30m  3s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 32s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
30m 59s

the patch passed

+1 :green_heart:
compile
17m 53s

the patch passed

+1 :green_heart:
javac
17m 53s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
mvnsite
23m 13s

the patch passed

+1 :green_heart:
shellcheck
0m  0s

No new issues.

+1 :green_heart:
javadoc
6m 56s

the patch passed

+1 :green_heart:
shadedclient
30m  1s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
691m 43s
/patch-unit-root.txt
root in the patch passed.

+1 :green_heart:
asflicense
1m 39s

The patch does not generate ASF License warnings.

941m 16s

Reason
Tests

Failed junit tests
hadoop.yarn.server.resourcemanager.scheduler.fair.TestFairSchedulerOvercommit

hadoop.yarn.client.api.impl.TestAMRMClient

hadoop.yarn.sls.TestReservationSystemInvariants

hadoop.hdfs.server.federation.router.TestRouterWithSecureStartup

hadoop.hdfs.server.namenode.ha.TestStandbyCheckpoints

hadoop.hdfs.TestRollingUpgrade

hadoop.hdfs.server.namenode.TestLargeDirectoryDelete

hadoop.hdfs.tools.TestDFSZKFailoverController

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5639/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5639

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint shellcheck shelldocs

uname
Linux eb4124b5fe03 4.15.0-206-generic #217-Ubuntu SMP Fri Feb 3 19:10:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
branch-3.3 / b2a3aca7b8e7ee1a9243b4cd83b94ce2f7b6e9bf

Default Java
Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~18.04-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5639/2/testReport/

Max. process+thread count
3159 (vs. ulimit of 5500)

modules
C: hadoop-project hadoop-client-modules/hadoop-client-runtime hadoop-client-modules/hadoop-client-minicluster . U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5639/2/console

versions
git=2.17.1 maven=3.6.0 shellcheck=0.4.6

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 35s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+0 :ok:
xmllint
0m  0s

xmllint was not available.

+0 :ok:
shelldocs
0m  0s

Shelldocs was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ branch-3.3 Compile Tests _

+0 :ok:
mvndep
26m 22s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
23m 43s

branch-3.3 passed

+1 :green_heart:
compile
17m 46s

branch-3.3 passed

+1 :green_heart:
mvnsite
25m 20s

branch-3.3 passed

+1 :green_heart:
javadoc
7m  2s

branch-3.3 passed

+1 :green_heart:
shadedclient
29m 59s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 34s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
30m 42s

the patch passed

+1 :green_heart:
compile
17m 26s

the patch passed

+1 :green_heart:
javac
17m 26s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
mvnsite
20m 39s

the patch passed

+1 :green_heart:
shellcheck
0m  0s

No new issues.

+1 :green_heart:
javadoc
6m 41s

the patch passed

+1 :green_heart:
shadedclient
30m  7s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
689m 34s
/patch-unit-root.txt
root in the patch passed.

+1 :green_heart:
asflicense
1m 40s

The patch does not generate ASF License warnings.

918m 16s

Reason
Tests

Failed junit tests
hadoop.hdfs.server.balancer.TestBalancerWithHANameNodes

hadoop.hdfs.server.datanode.TestDataNodeRollingUpgrade

hadoop.hdfs.server.datanode.fsdataset.impl.TestLazyPersistReplicaRecovery

hadoop.hdfs.server.namenode.ha.TestHAAppend

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5639/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5639

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint shellcheck shelldocs

uname
Linux b5780c582f46 4.15.0-206-generic #217-Ubuntu SMP Fri Feb 3 19:10:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
branch-3.3 / b2a3aca7b8e7ee1a9243b4cd83b94ce2f7b6e9bf

Default Java
Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~18.04-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5639/3/testReport/

Max. process+thread count
4131 (vs. ulimit of 5500)

modules
C: hadoop-project hadoop-client-modules/hadoop-client-runtime hadoop-client-modules/hadoop-client-minicluster . U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5639/3/console

versions
git=2.17.1 maven=3.6.0 shellcheck=0.4.6

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

Sure @pjfanning, will do, thanks for the info.

@rohit-kb could you remove the edits to the 2 pom files? You have 4 edited files in this PR while you only need 2 (the ones that change the nimbus version). See https://github.com/apache/hadoop/pull/5573

@pjfanning my bad, kind of went a bit overboard while avoiding those blanks related checks assuming that these changes won't matter.
Also, a bit doubtful regarding the rebase, I did rebase these commits after taking a recent pull from branch-3.3 locally. Should I add a new commit entirely reflecting the recent date for this PR? Thanks.

@rohit-kb I created https://github.com/apache/hadoop/pull/6201 - feel free to continue with this PR but I created 6201 just in case.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 25s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+0 :ok:
xmllint
0m  0s

xmllint was not available.

+0 :ok:
shelldocs
0m  0s

Shelldocs was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ branch-3.3 Compile Tests _

+0 :ok:
mvndep
14m 33s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
22m 26s

branch-3.3 passed

+1 :green_heart:
compile
11m 56s

branch-3.3 passed

+1 :green_heart:
mvnsite
19m 25s

branch-3.3 passed

+1 :green_heart:
javadoc
5m  5s

branch-3.3 passed

+1 :green_heart:
shadedclient
27m 35s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 28s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
32m 48s

the patch passed

+1 :green_heart:
compile
11m 33s

the patch passed

+1 :green_heart:
javac
11m 33s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
mvnsite
14m 58s

the patch passed

+1 :green_heart:
shellcheck
0m  0s

No new issues.

+1 :green_heart:
javadoc
4m 50s

the patch passed

+1 :green_heart:
shadedclient
27m 48s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
612m 37s
/patch-unit-root.txt
root in the patch passed.

+1 :green_heart:
asflicense
1m 18s

The patch does not generate ASF License warnings.

801m 31s

Reason
Tests

Failed junit tests
hadoop.hdfs.tools.TestDFSAdmin

hadoop.hdfs.server.datanode.TestDirectoryScanner

hadoop.util.curator.TestZKCuratorManager

hadoop.yarn.sls.TestReservationSystemInvariants

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5639/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5639

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint shellcheck shelldocs

uname
Linux 5e824957dafc 4.15.0-213-generic #224-Ubuntu SMP Mon Jun 19 13:30:12 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
branch-3.3 / d3d24c6c647527c90982c6e6d02224ac0da71bcd

Default Java
Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~18.04-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5639/4/testReport/

Max. process+thread count
3245 (vs. ulimit of 5500)

modules
C: hadoop-project hadoop-client-modules/hadoop-client-runtime hadoop-client-modules/hadoop-client-minicluster . U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5639/4/console

versions
git=2.17.1 maven=3.6.0 shellcheck=0.4.6

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

#6201 was merged - this can be closed


Added support for Multical 402 additional Water meters

Support for additional water metters connected to Input A&B (VA, VB) on Multical 402
According to Multical 402 manual

and protocol reference for Multical 801
Up to two additional water meters (eg. for cold water) can be connected to Multical 402 and read over IR interface, those are stored in registries 84 and 85.
In my example, no.1 has cold water meter, no. 2 is disconnected.

Tested with Multical 402
Home Assistant 2023.2.5
Supervisor 2023.01.1
Operating System 9.5
Frontend 20230202.0 - latest

Thank you for your contribution, I've added a few comments.
If you can address those, I'm happy to accept this PR!

Thanks, I will take a look on that.


Ansible Script to start 2 node network

Two node network should be started via the script
The script later can be made configurable.

This issue has been completed


Object contact_test() Segmentation Fault when colliding with non-floor object in Replica

Hello!
I am having an issue with the replica dataset and some custom code I have written to insert human objects into the scene. Piecing together some of the code from the ECCV 2020 tutorial, I got to the point where I have an agent at some random point in the scene, and I place a human object in front of the agent. I am currently trying to make a robust way of placing that object on the floor, or on top of whatever object it is over currently (so there isn't any clipping). Looking at tutorials, I can use an Object's contact_test() function, and it works well when that inserted object is clipping through the floor (i.e. contact_test returns true when it is clipping, and False when it is not. I can use this to iteratively lower an object until it starts clipping, which would result in the object being on the floor).
However, I noticed the simulator running into a segmentation fault when running the contact_test when the object is clipping with a non-floor object, such as a table. Here is a picture of an inserted object, that is clipping, and contact_test is returned true:

And here is an example where contact_test() results in a segmentation fault with the simulator:

I can provide the code that I created to do all this if needed, but maybe someone has a fast answer as to why this is happening.
Any help with this would be great!

Hey @denfed,
This is a known issue with Replica and Bullet phyaics integration. You are correct that the geometry density is the root cause here.
I believe the best immediate solution is to use decimated meshes for collision instead of the render mesh. For example, you could use the MeshOptimizer  project to generate a reduced-geometry mesh. The resulting mesh can be configured for use in Habitat by referencing it in the stage_config.json file as the "collision_asset".
Regarding your application of finding the correct placement for the object once collisions are working, you should check out the snap_down utility in Habitat-lab. Essentially this uses the object's bounding box and a raycast against the scene geometry to determine the best placement height for an object to rest on the support surface below it.

Oh wow, that snap_down function is perfect! I wrote some code to iteratively lower an object until it collides, but this seems to be a better way of doing it. Thank you!

Glad that helped. Let me know if you have success with the decimation. I don't think we'll have cycles for this in the near term.
Note: related to #613


Document FILE_SUPPORTS_BLOCK_REFCOUNTING in volume information APIs

@zwhfly : Thanks for your contribution! The author(s) have been notified to review your proposed change.

This flag is mentioned here. And it is used by at least this project.


INSTALL.md: glide is no longer used to install btcd

Need to replace "glide" with "dep" for btcd installing guide  https://github.com/lightningnetwork/lnd/blob/master/docs/INSTALL.md#installing-btcd

go get -u github.com/Masterminds/glide
git clone https://github.com/roasbeef/btcd $GOPATH/src/github.com/roasbeef/btcd
cd $GOPATH/src/github.com/roasbeef/btcd
glide install
go install . ./cmd/...


Display and style promoted reportback image

Fixes #4812
Shows the promoted reportback image next to the author callout in the win module.
@DoSomething/front-end

:shipit:!


[civetweb] Update to version 1.12

Update civetweb from snapshot release to regular 1.12 release. Tested locally on MacOS against prometheus-cpp.

Thanks for the review. I addressed all of your comments and re-tested locally.

@gjasny
Could you please remove the below lines from vcpkg/scripts/ci.baseline.txt?
civetweb:x64-windows        = skip
civetweb:x64-windows-static = skip
civetweb:x86-windows        = skip

@Cheney-W done

@gjasny Thanks for your PR. I have tested this PR on Linux and MACOS, and it passed. Please remove the below lines from vcpkg/scripts/ci.baseline.txt.
civetweb:x64-linux          = skip
civetweb:x64-osx            = skip

@gjasny Could you address Lily's suggestion? Thanks!

Sorry, I must have missed the notification email.

Alright, this looks great! Thanks @gjasny :)


Clarification request: Where to install squashfs tools on Windows?

I'm considering using node-compiler for a project, but I can't seem to find any explanation on where to install the squashfs files (from the download) on windows in order to make everything work.

C:\Windows would suffice.


Multi GPU mode for codeparrot evaluation

What does this PR do?
This PR provdie a script to run codeparrot human eval in multi GPU mode
Performance data
The performance is check using the following command
accelerate launch scripts/human_eval_mgpu.py --model_ckpt lvwerra/codeparrot-small --do_sample True --temperature 0.2 --top_p 0.95 --n_samples=40 --HF_ALLOW_CODE_EVAL="1" --device_int=0 --num_tasks=8 --batch_size=10

One should obtain
Results: {'pass@1': 0.1375, 'pass@10': 0.21251641317430792}

Time benchmark
TODO

Before submitting

[ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
[ ] Did you read the contributor guideline,
Pull Request section?
[ ] Was this discussed/approved via a Github issue or the forum? Please add a link
to it if that's the case.
[ ] Did you make sure to update the documentation with your changes? Here are the
documentation guidelines, and
here are tips on formatting docstrings.
[ ] Did you write any new necessary tests?

Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

In the initial PR, TokenizeDataset iterate on the list of prompts [p1, p2, p3, p4, ....]; then p1, p2 are sent to different processes to leverage the muti GPU capacity. However, accelerate require the batched sent to multi GPU to have the same size. This is initially  handled by a padding of the EoS. Unfortunately, the codeparrot model has very different behavior according to the padding policy (@lvwerra is there a better way to pad the data?).
To avoid padding, in the next commit,  TokenizeDataset will send [p1, p1, ..., p1, p1, p2, p2, ...] where each prompt is sent k times, where k = n_samples // batch_size should be a multiple of the number of processes used in the evaluation

I discovered an error when launching the large model
ERROR:torch.distributed.elastic.multiprocessing.api:failed (exitcode: -9) local_rank: 3 (pid: 96970) of binary: /usr/local/bin/python
ERROR:torch.distributed.elastic.agent.server.local_elastic_agent:[default] Worker group failed

@lvwerra any idea?

Unfortunately, the codeparrot model has very different behavior according to the padding policy (@lvwerra is there a better way to pad the data?)

Can we remove the padding before the generation? At this point the data should already be dispatched to the GPU and padding is no longer necessary. Would that solve your issue?

no enough RAM when using accelerate 4 processes

Hmm, is this CPU or GPU memory that is running out? Maybe a smaller batch size would help? What kind of machine are you running this on? If it is consuming an absurd amount of CPU RAM maybe there is an issue in Accelerate.

Hmm, is this CPU or GPU memory that is running out? Maybe a smaller batch size would help? What kind of machine are you running this on? If it is consuming an absurd amount of CPU RAM maybe there is an issue in Accelerate.

I am talking about the CPU RAM. I will double check what was happening. With the large model, I manage to run it with 2 processes but not 4. I thought the CPU RAM might be 4 times high if I put 4 processes. Tell me if you have any intuitions, otherwise I will dig further

How much CPU and GPU memory do you have on your machine?  Maybe we need to do some profiling to find the source. Or scale up the CPU memory on the machine.

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.


List index out of range

https://github.com/Ostronkex/100-Days-of-Code-The-Complete-Python-Pro-Bootcamp-Solutions/blob/2a21813f8220af7bd0b6af6683c9c50047984b45/Day8/CaesarCipher.py#L13
When specifying a bigger number for the shift that puts a letter outside the alphabet, it returns an error.
Would be good if it instead started over from A. For example Y with a shift of two should turn into A instead of returning the list index error.

Aware of the issue. I am going to focus on the decoder first and make the program better at the end, such as fixing the list range error and making it so you can encode multiple words in one session to make one long message.

Solved in 44af6b4


Snippets Variable transforms

Type: Feature Request
Hope variable transformation can use regularity multiple times

VS Code version: Code 1.72.2 (d045a5eda657f4d7b676dedbfa7aab8207f8a075, 2022-10-12T22:15:18.074Z)
OS version: Windows_NT x64 10.0.18363
Modes:
Sandboxed: No

Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.81.0. Please try upgrading to the latest version and checking whether this issue remains.
Happy Coding!

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.
Happy Coding!


Beyond GraphQL

In order to enable more features, I propose we move beyond GraphQL. We have flexibility here because we control the query resolution process.
Feature List:
Request Modules

a.k.a. custom root types

schema {
  cool: Cool
}

module Cool @read @write {
  beNice(
    a: String!
    b: Uint256
}

...

I've explored using WIDL, an IDL created by the folks that created Wascc and Wapc: http://wascc.dev/
I think that the major down side to doing this is that you loose all of the out of the box tooling that comes with the GraphQL community. This to me is too big of a loss, and shouldn't be incurred. I could not come up with a good enough reason to "roll our own" or adopt something very new like WIDL.


fix: use tapSubgraph to ignore connection with tapContracts

Please use commit format we've been trying to stick to:
component name: Description

Further description if needed

So first commit message would be something like:
common: Use tapSubgraph config to control TAP/RAV feature

If a user does not config tapSubgraph, do not connect to TAP contracts or
execute RAV processing functions


support for python 3.x

So my beets instance is currently running with Python 3.5.3
Since beets will drop support for Python 2.x sometime soon as you can read here will there be support for python 3.x for this nice piece of software?
Just for fun I tried to install your package with Python 3.x like this:
python3 setup.py install

and it didn't throw any error while installation and said at the end:
[...]
Finished processing dependencies for whatlastgenre==0.1.28

Then I set up wlg as a plugin in beets as explained here and tried running it manually from beets with
beet wlg which brought me the error error: unknown command 'wlg'.
I guess this is due to wlgs limitation to Python 2.7 but on the other hand installing it with python 3.x didn't throw any error, so I was kinda confused...

actually I now know why the error error: unknown command 'wlg' came...
I forgot to add wlg to my beets config to the plugins part, since I thought it would automatically be added through the pluginpath that I wrote into the config.
Maybe it would be helpful to add this info to the README.md
Nevertheless I would want this ticket to be open as a feature request for Python 3.X support.

I did a quick'n'dirty port to Python3 with 2to3 and some additional debugging. It seems to work for me right now. I don't use redacted, though.
https://github.com/davdittrich/whatlastgenre

I did a quick'n'dirty port to Python3 with 2to3 and some additional debugging.
https://github.com/davdittrich/whatlastgenre
I tried this fork, but i get following error:

Traceback (most recent call last):   File "./whatlastgenre", line 24, in <module>     main()   File "/home/tba/Programme/wlg/whatlastgenre/wlg/whatlastgenre.py", line 877, in main     wlg = WhatLastGenre(conf)   File "/home/tba/Programme/wlg/whatlastgenre/wlg/whatlastgenre.py", line 61, in __init__     self.daprs = self.init_dataproviders()   File "/home/tba/Programme/wlg/whatlastgenre/wlg/whatlastgenre.py", line 131, in init_dataproviders     daprs.append(dataprovider.factory(dapr, self.conf))   File "/home/tba/Programme/wlg/whatlastgenre/wlg/dataprovider.py", line 68, in factory     dapr = Redacted(conf)   File "/home/tba/Programme/wlg/whatlastgenre/wlg/dataprovider.py", line 401, in __init__     self.session.cookies.set('session', cookie)   File "/usr/lib/python3.8/site-packages/requests/cookies.py", line 215, in set     self.set_cookie(c)   File "/usr/lib/python3.8/site-packages/requests/cookies.py", line 344, in set_cookie     if hasattr(cookie.value, 'startswith') and cookie.value.startswith('"') and cookie.value.endswith('"'):
any chance for a working wlg version with python 3?

any chance for a working wlg version with python 3?

does the py3 branch work for you?

does the py3 branch work for you?

Works!
Thank you!
…and sorry oranweing that late, i didn't get a notification :\

I'm still having issue. I just installed via the following.
python3.7 setup.py install --user

I add wlg to plugins and it doesn't find it nor if I also add the full path to the pluginpath.


what field ps,psl and fs mean.

Elasticsearch version:1.7.3
Moloch version:0.14
OS name and version:centos7
Provide logs, stack traces and steps to reproduce:
what field ps,psl and fs in es mean.

ps - file position of packet
psl - packet length
fs - files used by session


Self-Signed certs with user date offsets

In order to provide overlapping valid certs, I would like to add not_before and not_after to the existing Identity::self_signed()
Is it alright for the API to change, or would adding a function and then using the existing as a wrapper for it be a better choice?
Although this is somewhat moot as one can construct their own certs to use already with a bit of extra work.

Once the certificate is generated it cannot be changed (as it is signed).
It would be possible to change a little bit the API and to provide a builder to generate the self-signed certificate (given thus the possibility to set the temporal validity range for it).
However, I am wondering what is the use case. The utility Identity::self_signed has a very precise scope: generate a self signed certificate which is compliant to W3C specifications.
For example:

[...] the total length of the validity period MUST NOT exceed two weeks.

Therefore, this method is very specific to generate an usable certificate for web browser to accept in WebTransport protocol.

The idea is to generate and publish future self-signed certificates that will be valid a week (next_notbefore = current_cert_notbefore + seven_days) after the currently used certificate was created, so that clients with stale server info (>2 weeks old) can still connect without worry of connecting mid-changeover or re-fetching the currently valid certhash.
This concept is included in the w3c spec by allowing for multiple certhashes to be passed during connect, though i suspect the original intent is for shorter overlapping cert validities.
W3C spec : [...] it also forces server operators to design systems that support and actively perform key rotation. [...]
Having rotating keys also helps prevent leaked any leaked keys from being valid for too long- even if we are self-signing.

I see, that's interesting; thank you


Does the input image of DeepFace. analyze have to be passed in and processed by oneself?

My code:
DeepFace.analyze(self.crop_img, actions = ['age', 'gender', 'race', 'emotion'])
error:
ValueError: Error when checking input: expected conv2d_1_input to have 4 dimensions, but got array with shape (1, 48, 48)

is your input image RGB?

yes,i am sure. i installed deepface from pypi, version is 0.0.79.

please share crop_img here

cv2.imwrite('crop_img.jpg', self.crop_img)
print(self.crop_img.shape)     # this row print(552, 552, 3)
objs = DeepFace.analyze(self.crop_img, actions = ['age', 'gender', 'race', 'emotion'])

photo_path = './image/photo_test3.jpg' self.img = cv2.imread(photo_path) self.crop_img = self.img[y:y+h, x:x+w] objs = DeepFace.analyze(self.crop_img, actions = ['age', 'gender', 'race', 'emotion'])

I found that I can run it with version 0.0.75.
There may be some issues with the pre processing of versions 0.0.78 and 0.0.79

What if you sent img instead of croped_img?
What are x and y values to crop?

closed due to inactivity


Composition vs Inheritance

As we are working with pure Kotlin at this point, the multiple abstract classes makes it very difficult to work with out own classes forcing us to write our own delegates for dagger and and other logic.
Ideally things like TurboFragment, WebTurboFragment should be interfaces, if you want to provide a default implementation of those interfaces that would be fine, but now we have to have multiple base classes instead of the 1 we used to have.

I agree that the abstract class setup it not ideal. It's born from the fact that Android's different fragment types are Fragment subclasses. Turbo currently supports Fragment and BottomSheetDialogFragment destinations (with future plans to support DialogFragment and possibly others). So, an application that takes advantage of Turbo's features would never be able to have a single base Fragment class.
Given this framework limitation, and since Turbo's navigation is heavily tied into the Fragment lifecycle, offering subclasses makes the most sense for the library.
To work around this, all Turbo fragment destinations implement the TurboNavDestination interface. You can extend this interface and drop in the common functionality that your Fragment destinations use there. And example is provided in the demo app with the NavDestination interface and used here, here, and here
I'll think about this more and see if there's an opportunity down the road to make the library more flexible, but it's not in the near-term plans to restructure the classes. Thanks for the feedback and hopefully the TurboNavDestination interface helps!

I agree that the abstract class setup it not ideal. It's born from the fact that Android's different fragment types are Fragment subclasses. Turbo currently supports Fragment and BottomSheetDialogFragment destinations (with future plans to support DialogFragment and possibly others). So, an application that takes advantage of Turbo's features would never be able to have a single base Fragment class.
Given this framework limitation, and since Turbo's navigation is heavily tied into the Fragment lifecycle, offering subclasses makes the most sense for the library.
To work around this, all Turbo fragment destinations implement the TurboNavDestination interface. You can extend this interface and drop in the common functionality that your Fragment destinations use there. And example is provided in the demo app with the NavDestination interface and used here, here, and here
I'll think about this more and see if there's an opportunity down the road to make the library more flexible, but it's not in the near-term plans to restructure the classes. Thanks for the feedback and hopefully the TurboNavDestination interface helps!


Pod with unit test bundle resource build failed after rugby cache

Describe the bug
Pod with unit test bundle resource build failed after rugby cache.
Look like the FilePatcher won't patch the subspec target.
To Reproduce
Steps to reproduce the behavior:

Download the sample project: podWithTestSpec.zip
Execute pod install && rugby
Build target testPod-Unit-Tests and it fails.

Expected behavior
All the path list in resource.sh should have a correct patch.
Screenshots
If applicable, add screenshots to help explain your problem.

Environment (please complete the following information):

1.17.0

Hello! Oh, I see. I think you are right, we need to use product names with target names in patcher regex.

I'll check it out week

@blastmann Could you check this branch bugfix/patch-products?

This branch bugfix/patch-products works perfectly.

OK, I'll open pull request soon. But I need some time for regress.

I have issue with some other cases, but I can't reproduce it with a new project. I will provide a new sample project when I reproduced.

@blastmann I've merged pull request 🚢
Feel free to reopen this issue if you have another case or just open the new one.


[Feature] Get distinct changed folders

Is this feature missing in the latest version?

[X] I'm using the latest release

Is your feature request related to a problem? Please describe.
We have build actions which consumes list of files which have changed, since the list of files can be very long, we are facing an error where the argument is too long, to fix the same, if we had a distinct list of changed folders we would be able to deal with this issue.
Describe the solution you'd like?
An option which outputs a list of changed folders.
Describe alternatives you've considered?
No response
Anything else?
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

@mohitnayar123 Any preference for reading the list of changed files from a temporary file which bypasses the character limitation of GitHub actions.

I would also like this feature, but for another reason:
We have a few repos that contains multiples microservices in seperate folders, or a backend service and a frontend in the same repo. Having an output with a list of changed directories would allow us to optimize running based on folders touched, saving time and compute.

+1 for a feature,  can be really useful in monorepo versioning

@choffa @antimack @mohitnayar123 This is now available in the latest release.


Suggestion #3

Another sway you could maybe improve Repl Customs would be to add the feature where you can see the 7 day, 31 day, and all-time leader board instead of only being able to see the all time leader board. Maybe you could also add a one day leader board.

Ok, thanks! I'll add that to the list of suggestions!


The page run out of memory when file is undefined

I have upgraded from 7.0.17 to 8.0.6 and when I upload my form, which can contain or not a file (undefined), the page crashes because it tries consume all the memory and cpu.
The was no poblem with this in the previous version.

Sorry, I have seen that the error is not by the undefined file.
Looking at the code, it appears that now the extra data is added recursively, and my data had a $promise inside, so it caused an infinite cycle.

Circular reference detection.

Since version 9.0.3 you will get an error if you have circular reference in your data.


Allow prompts to be rendered at a custom column offset

Is your feature request related to a problem? Please describe.
I don't know if this is out of scope for this project, but here it goes.
I am building an application with nested log output, and sometimes I want to stop and query the user for input. The current way of doing it is to show the prompt at the bottom of the screen, but it would be really awesome if it could be rendered inline in the nested log output.
The problem is there is no way of rendering the inquire prompts at a non-zero column position offset, neither is it possible to add prefixes to all the prompt lines in the current API. The prompt will always justify to the leftmost column of the screen at each render pass.
Describe the solution you'd like
A "simple" solution would be to honor the current cursor position and always make sure to render the start of each line at that starting column when initiating the prompt. The line clearing would need to be done from that column as well, to prevent previous output from being overwritten.
Describe alternatives you've considered
There are really no other alternatives other than reimplementing inquire into my own project, or using another library which can render at an arbitrary position of the screen.
Additional context
Example to my current state of application output:
* Downloading file
┃ ~ URL: example.org/file
┃ * Verifying file content
┃ ┃ ! Unsupported file type
┃ ┗╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶
┗╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶

? Do you want to inspect the file?
> Yes
  No

Example of how I want it to look:
* Downloading file
┃ ~ URL: example.org/file
┃ * Verifying file content
┃ ┃ ! Unsupported file type
┃ ┃ ? Do you want to inspect the file?
┃ ┃ > Yes
┃ ┃   No
┃ ┗╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶
┗╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶╶

The simple solution you described I think would require the developer (your app) to know beforehand how many lines we are going to draw so you could draw the "prefixes".
We could refactor the rendering logic to not clear anything outside of our "box", but only horizontally. The vertical size depends on many prompt options and it would get hard for the developer to figure out these dimensions before hand to draw outside of it (as we do not give up control until we finish).
The simplest solution I can imagine is adding a global prefix the RenderConfig struct. This would allows us to not add new APIs for all prompts and simply reuse the existing RenderConfig.
From the dev pov, having to create a new RenderConfig for each prompt (as it would vary on the nesting level in your case) would suck I imagine, but I think this case is special enough that whoever uses it is already dealing with these kinds of quirks? No idea. Maybe allow a custom "box" size that will be used instead of the full terminal? I see some problems with that too...
That's a problem with a lot of hard decisions to make. Would love to get some ideas implementation-wise.

Regarding the vertical size (let's call it the height), yes, I need to at least figure out the maximum height a prompt can yield in order to make room for it beforehand, and that is not a big issue I think. Adding a function to calculate the render height before the prompt is initiated would be nice, but not necessary in my case.
As for the difference between my proposed solution and your global prefix solution, the difference from my POV is whether I am drawing the prefixes once beforehand (my solution) vs drawing them each time the prompt updates (your solution). For me it would definitely be easier to just draw them once, since then I don't have to expose the prefix logic to the prompt module.
That said, I think your proposed solution would be the most suitable for the aim of this library, since I don't imagine honoring the cursor position would not be utilized most of the time, while a global prefix definitely would. So I am fine with going in that direction and make some sacrifices on my end. Recreating RenderConfigs is something I do every time anyway, so that is not a problem for me :)
As for the implementation, I think just a global_prefix field would suffice, which would be added before each rendered line of all the prompts. If this approach is feasible and appropriate to you, I am happy to draft a PR!

Testing this out, I didn't anticipate that the global prefix approach won't work in my case, since I need to guarantee that the prefixes are rendered after the prompt in case it's height is less than what is allocated. Since the prompts clear all lines, the prefixes will be cleared as well. Instead of having the odd case where the prefix would be the only part not being cleared, I instead implemented a similar config parameter named "global indentation", which allows to indent the prompt and avoid clearing content within the indentation area.
I hope this isn't a weird API to have or to esoteric, but if it is, let me know if there is anything I can do to generalize it or make it easier to use (in case you find this feature worthy of being included in the project that is).

Reviewed. I am curious on how you are managing to render the prefix after the prompt, is there a public example I could check it out? Just out of curiosity

Sure thing, I have made the project public previously fortunately, so you can have a look here:
https://github.com/spelbryggeriet/hoc/
You can look in the prompt and the log::progress::render modules, where most of the prompt handling and log rendering is.


Missing 'close' event when using WebSocket as a client

Based on the WebSocket spec, section Feedback from the protocol, the last part reads:

"When the WebSocket connection is closed, ...
2. ...  fire a simple event named error ...
3. Create an event ... with the event named close ...  and dispatch the event"

Now, when using the WebSocket object to initiate a connection to a remote WebSocket server, in multiple cases only the error event is emitted, but no close event.
I have mapped the cases and the relevant source locations. So, this happens:

When the server closes the connection, the listeners are cleaned from the WebSocket too early, and the close event is not delivered, see here, line 485 (perhaps it's OK to leave the listeners there, for either the user or the GC to clean them)

When the client is connecting to a server which is not listening, only the error event is emitted, see here, line 451 (this is ambiguous in the spec, because it says when the connection is closed and here the connection wasn't established, but indeed all browsers emit a close here)

And the last one I haven't experienced, but by the looks it's the same case, when the server key is invalid, see here, line 462 (again, I think this should be consistent, e.g. when a user reconnection code waits for a close event, it should get it)

Thanks, this and much more related to connection setup and teardown has
been fixed in a coming version with extension support. Likely to go live
this week.
On Feb 26, 2012 11:20 PM, "Juraj Vitko" <
<EMAIL_ADDRESS>wrote:

Based on the WebSocket spec, section Feedback from the protocol, the last
part reads:

"When the WebSocket connection is closed, ...
2. ...  fire a simple event named error ...
3. Create an event ... with the event named close ...  and dispatch the
event"

Now, when using the WebSocket object to initiate a connection to a remote
WebSocket server, in multiple cases only the error event is emitted, but
no close event.
I have mapped the cases and the relevant source locations. So, this
happens:

When the server closes the connection, the listeners are cleaned from
the WebSocket too early, and the close event is not delivered, see here,
line 485
(perhaps it's OK to leave the listeners there, for either the user or the
GC to clean them)

When the client is connecting to a server which is not listening, only
the error event is emitted, see here, line 451
(this is ambiguous in the spec, because it says when the connection is
closed and here the connection wasn't established, but indeed all browsers
emit a close here)

And the last one I haven't experienced, but by the looks it's the same
case, when the server key is invalid, see here, line 462
(again, I think this should be consistent, e.g. when a user reconnection
code waits for a close event, it should get it)

Reply to this email directly or view it on GitHub:
https://github.com/einaros/ws/issues/31

I'll make sure that all the cases you mention are covered :)
On Feb 26, 2012 11:20 PM, "Juraj Vitko" <
<EMAIL_ADDRESS>wrote:

Based on the WebSocket spec, section Feedback from the protocol, the last
part reads:

"When the WebSocket connection is closed, ...
2. ...  fire a simple event named error ...
3. Create an event ... with the event named close ...  and dispatch the
event"

Now, when using the WebSocket object to initiate a connection to a remote
WebSocket server, in multiple cases only the error event is emitted, but
no close event.
I have mapped the cases and the relevant source locations. So, this
happens:

When the server closes the connection, the listeners are cleaned from
the WebSocket too early, and the close event is not delivered, see here,
line 485
(perhaps it's OK to leave the listeners there, for either the user or the
GC to clean them)

When the client is connecting to a server which is not listening, only
the error event is emitted, see here, line 451
(this is ambiguous in the spec, because it says when the connection is
closed and here the connection wasn't established, but indeed all browsers
emit a close here)

And the last one I haven't experienced, but by the looks it's the same
case, when the server key is invalid, see here, line 462
(again, I think this should be consistent, e.g. when a user reconnection
code waits for a close event, it should get it)

Reply to this email directly or view it on GitHub:
https://github.com/einaros/ws/issues/31

Thanks:) My current workaround works, but it's dodgy, as workarounds are.
Please consider adding a link to https://github.com/ypocat/ws-rpc to README. :)

Regarding your point #1 above, I remove the listeners from the underlying socket, not the websocket itself. This shouldn't influence the delivery of close messages. Have you observed different behavior?

Interesting - then I analyzed the reason wrong - but I'm sure I wasn't getting the close event while I was listening on the WebSocket object directly (I'm not listening on the WebSocket._socket object at all).
You can have a look if the close event is emitted in the Node client in the case when you kill the server - for me it wasn't.


Support for fast refresh

This is a general redux problem, but it'd be great if data didn't drop out when working in an environment with fast refresh/HMR. I've seen quite a few different approaches to this, but we should probably recommend something here.
A few ideas:

redux-persist
something along the lines of: https://github.com/GuillaumeCisco/redux-reducers-injector
a naive but okay approach: https://github.com/denniske/rnReduxhooks/commit/c2a0279927bf7c32b5f2507905ad146cff742770

Definitely open to suggestions here. I imagine this would apply to RTK as well.

At least with HMR, I don't think it would drop out if you configure it correctly? I haven't seen how this is done with Fast Refresh though tbh.

@markerikson I need to do some more research here, but for example, my rtkq data drops on hot reloads on the app I work on full-time currently. This is while using esbuild though, so it might be something there - but that being said, the rest of the state seems to be fine as auth sticks around and such. I'll have time to debug tomorrow most likely and will update here.

well, if you're using ESBuild by itself, you're almost definitely not using the actual "Fast Refresh" (the new hot reloading system built into React itself), because that requires bundler integration.  There's a Webpack + Fast Refresh plugin, and both CRA and Next are using it.
If you're using CRA + an override + esbuild-loader with Webpack....
I dunno :)

Correct - craco + craco-esbuild + esbuild-jest etc etc etc. I've gone down the wrong :rabbit: :hole:

redux-injector is good too
https://github.com/react-boilerplate/redux-injectors


I can't hit the Lurker

I can't hit him or do anything to him. When aggressive mode appears, it hits us until it disappears for a few minutes and it is very annoying not to be able to hit it.
 There is an option in there called "lurker_invulnerable", and if it is set to "true", then he won't be able to be hit. Just set it to "false", and it should fix the problem you're having. The config is in the game directory folder inside the "config" folder, and the config file itself is called "midnightlurkerconfig.json". You can edit it with Notepad or any software you have on your computer that can edit code, just in case you didn't know.
However, if it's already set to "false" in the config, then I'd have to try and recreate the problem, as I don't have this problem when testing or playing the mod myself.

I would suggest checking the config of the mod. There is an option in there called "lurker_invulnerable", and if it is set to "true", then he won't be able to be hit. Just set it to "false", and it should fix the problem you're having. The config is in the game directory folder inside the "config" folder, and the config file itself is called "midnightlurkerconfig.json". You can edit it with Notepad or any software you have on your computer that can edit code, just in case you didn't know.
However, if it's already set to "false" in the config, then I'd have to try and recreate the problem, as I don't have this problem when testing or playing the mod myself.

Yes, that was it. Thank you so much


docs: migrate to nuxt ui pro

TODO:

[ ] migrate to unjs/docs
[ ] Add SEO meta https://github.com/unjs/nitro/pull/2090

Hello @Flosciante,
I'm Estéban, maintainer of unjs/website and leading marketing of UnJS.
Thank you so much for starting the migration from docus to nuxt ui pro.
I'd like to keep the documentations in line with the same idea and design, to have harmony within UnJS. Here are a few points for improvement:

Update the font to use Nunito, https://unjs.io/design-kit#typography
Update the gray to cool
Update the header and the footer to have something more similar to new UnJS website

We could also update the tagline by adding "Nuxt, Analog and SolidStart".
What do you think?

[!NOTE]
Next version of UnJS website: https://feat-new-theme.unjs.pages.dev/

We could also update the tagline by adding "Nuxt, Analog and SolidStart".

Probably not.

We need to rebase content although i think after moving to new unjs-docs CLI we might need less of changes as we can keep # h1 headings.


Adds Random Float and Random Color nodes

Adds Random Float and Random Color nodes, to simplify generating randomized signals in a material.
@Cinifreak suggested a very similar node on ASWF, so we'll collaborate on this PR.

Thanks for these contributions, @crydalch, and these are clearly fundamental nodes that are worthwhile to add.  I'll just highlight the validation warnings generated in testing, which are minor but valuable to fix:
  Document is invalid: [D:\a\MaterialX\MaterialX\build\bin\resources\Materials\
  Examples\UsdPreviewSurface\usd_preview_surface_plastic.mtlx] Invalid value:
  <input name="in" type="color3" uiname="Input" value="0">
  Invalid value: <input name="in" type="vector3" uiname="Input" value="0">
  Invalid value: <input name="in" type="vector2" uiname="Input" value="0">
  Invalid value: <input name="in" type="color3" uiname="Input" uisoftmin="0"
  uisoftmax="10" value="0">
  Invalid value: <input name="in" type="vector3" uiname="Input" uisoftmin="0"
  uisoftmax="10" value="0">
  Invalid value: <input name="in" type="vector2" uiname="Input" uisoftmin="0"
  uisoftmax="10" value="0">

I'm wondering would it make sense to use one category name like random (or rand if it behaves like rand) instead of randomcolor and randomfloat? If you add in other variants like randomvector then there is till only 1 "random" node category so may make it easier for users especially if a node editor supports typeless nodes.

@kwokcb I think that's a good suggestion, to define a single random node with type overloads, allowing us to transparently extend the concept to vectors and other data types in the future.  As you note, this will also work more smoothly in future node editors that support dynamic node typing, where the artist can place an untyped random node in the graph and its type will be inferred upon its first connection.

@jstone-lucasfilm and @kwokcb I'm not sure we should merge all of them together into a single .
We can provide a much better experience if users select which type of randomization they want up-front.  Overloading a single node will result in a large matrix of input and output signature combinations (which will only get worse as more types are added). We've been guilty of this ourselves; VEX's Random node is overloaded - and it has a menu of 61 combinations of input/output signatures! Even when you narrow down the items based on the input type, it's still a really long menu for users to parse.
I'd also suggest that random is not one of those cases where you will need that flexibility anyway. In the middle of an existing shading network, and <random_float> probably isn't going to work if you just change to <random_color>.
In general I'm all-for reducing nodes, but in this case I think letting users decide up-front makes for much better UX.

Hi @crydalch,
I can see your point about overloading the same node category too much, and about trying to switch to a different variant after the fact -- though I think any polymorphic node runs into this issue of remapping to something that still is sensible?
The "key" seems to be that randomfloat and randomcolor actually have different input signatures. There was some renaming for the combine node a little while back due to issues with the same category with the same output signature but differing input signature causing ambiguity -- though this can be handled now.
So maybe one "guiding principle" is to use the same category if the "input signature" matches, but otherwise it's a new category ? Alternatively perhaps an attribute hint can be used to "partition" the variants into groups, like uifolder  on a nodedef ?
I'm "wobbling" on the fence for this one but still leaning towards one "logical" category for random number generation.
BTW, Amazing you could create 61 variations of random :).

@crydalch I wonder if the distinction that we want to make is between randomvalue and randomcolor, where the former is an n-dimensional random lookup with an m-dimensional seed, and the latter is an artistically-motivated random color generator like the one that you've proposed.
Here are a few industry examples of the randomvalue pattern we can consider:
https://docs.blender.org/manual/en/latest/modeling/geometry_nodes/utilities/random_value.html
https://www.sidefx.com/docs/houdini/vex/functions/random.html
https://substance3d.adobe.com/documentation/sddoc/random-float-215286567.html
<EMAIL_ADDRESS>And here are a few links that suggest the need for a randomcolor node, though I believe Chris's current PR is better defined and more general-purpose than these examples:
https://help.maxon.net/r3d/katana/en-us/Content/html/Hair+Random+Color.html
https://blenderdaily.xyz/tips/random-color-for-each-face-of-an-object
https://www.sidefx.com/forum/topic/73410/

@crydalch Looking at the current UI for MaterialX graphs in Houdini 19.5, for example, I could see the idea of a randomvalue node working well with the "Signature" dropdown box in Solaris.  The user could then place a randomvalue node through the UI and freely change its signature based on the needs of the graph, with the set of input names remaining consistent regardless of the signature that they choose.

@jstone-lucasfilm indeed, that's how it works in Houdini. My hesitation is not that the inputs might be different, or that tools won't have a menu to choose the signature. I hesitate because I've had to use nodes with lots of combinations of input and output signatures - and that menu gets rather long. Even when Houdini filters it based on connected inputs, there's still more thinking/deciding/clicking a user must go through.
When an artist types "random" into the Tab menu (or equivalent in their DCC) and they see "randomfloat", "randomdirection", "randomvector" and "randomcolor", what happens next? They easily decide/select an option, without any further clicking, typing, or reading of menus. They aren't required to additionally find which random value they'd like to use within a menu. And they don't have to worry about output types changing out from under them, because an input type changed, and the tool re-filtered the signatures and picked one you need to deal with. (I put in randomvector and randomdirection as examples of other ideas that could be useful, and I can think of how each would potentially have unique parameters). The fixed output, lets the input type can change however automatically, without cascading changes down the shading graph that they have to be aware of or potentially undo/work-around. It feels similar in some ways, to trying to combine all of the 2d and 3d noises/patterns that share similarly-named inputs, into one node; while you could do it, I'm not sure it would help users much.
I know a lot of UX is dependent on DCCs and artist tools, but why not make the available options clear for everyone using MaterialX? I don't think reducing the various "randomvalue" options down into 1 node is an optimization that helps the user. Maybe there are advantages for codegen, to having an overloaded "randomvalue" node? I'm also concerned that future developers will just happily overload the random node, because it's there... and eventually that menu's going to be long.
Asking users to spend time selecting from signature menus more than just a few options, for the sake of reducing a handful of random nodes into one, doesn't feel like it's worthwhile for users...

To me, the question of "should this node and that node really be just one kind of node with different signatures" boils down to one easily-answered question: do the nodes do basically the exact same thing, other than the types they operate on.  In this case, the answer is clearly "no":  has two inputs ("in" and "seed") and computes a random value using cellnoise2d and those two input values, while  generates 3 separate 's internally then uses that to compute a random HSV color.  It's a lot bigger of a change than just input signatures- it's a different function.
Separate note: it looks like the nodegraph for randomcolor_float is generating three different seeds for hue, saturation and value (good), but they look like they'd all be the same because all three are adding "0" to "seed", and that "0" isn't exposed as an interface input?  I think it'd be fine to just choose different non-zero "random-looking" values for the 2nd and 3rd seed offsets and not complicate the interface with additional seed or seed_offset inputs.

@dbsmythe Just to clarify, the latest suggestion is not that we merge randomfloat and randomcolor, and the reasons that you outline here are a large part of why I wouldn't suggest this.
The suggestion is instead that we provide randomvalue and randomcolor as separate nodes, where the former handles the float, vector2, vector3, and vector4 types in a consistent way (as both Houdini and Blender currently do), and the latter is an artistically-focused color generator with HSV controls (as in Chris's post).
@crydalch What are your thoughts on that proposal?  This is similar to what you suggest above, with the main difference being that we wouldn't need to support separate randomfloat, randomvector2, randomvector3, and randomvector4 nodes, and they would instead be unified into a single randomvalue.  To my mind, this strikes a good balance between user clarity and consistency, but I'm definitely open to alternative suggestions based on your own experience with Houdini artists.

Ah I get it: what was proposed as  would instead be called .  That makes sense to a point, but I would expect there should also be color3 and color4 variants of  (in addition to float and the 3 vector types), that would simply be 3 or 4 random floats combined into a color3 or color4 output type.  This then makes the name "randomcolor" a bit confusing; I would suggest calling the "return a random color between two HSV values" node  instead, to emphasize the HSV nature of the randomly-chosen color.

@jstone-lucasfilm I don't think we need to have a random node for every type possible, but my opinion (which I've clearly not communicated well, my apologies) is that nodes with long signature menus aren't good UX. Obviously they are necessary in many/most cases - I just don't agree that an overloaded randomvalue is the right way to go.
I'd suggest these nodes:

randomcolor

mostly as-is; I don't think users get confused that it does HSV-style color randomization? The other randomcolor-like nodes do this.
Or maybe there is a toggle, that would randomize RGB independently, as an alternative to the default HSV-style randomization?
We can add a color4 output signature, thanks @dbsmythe

randomfloat

min/max parameters
if convert supported float-->int, maybe randomvalue makes sense here, as it would support float or int outputs? I tried looking at the <convert> node, but I think someone else needs to tackle that.

randomvector

min/max parameters, but additionally support adding to an existing vector (for jittering normals), and have a toggle for normalizing the output vector
would have a longer signature menu, with the various vector output types (vec2, vec3, vec4)

Maybe that's a better balance? Users will have some clear options from their tool menu when typing "random", each node has some unique controls/behaviors, and it avoids a single node with extremely long signature menu.
How does that sound?

I like that latest design proposal, @crydalch, and you make good points above, @dbsmythe.  The idea of a randomvector node with optional normalization sounds very appealing, and using the name randomfloat for the scalar version seems reasonable to me.


Mail attachment support

Hi, does your MailService support mail attachments ?

I am using this
$message = $mailService->createHtmlMessage($from, $to, $subject, $viewTemplate, $values);
$message->createAttachment('public/data/myfile.pdf',
'doc/pdf',
Zend\Mime\Mime::DISPOSITION_INLINE,
Zend\Mime\Mime::ENCODING_BASE64);
$mailService->send($message);
but it giving me this error
"Call to undefined method Zend\Mail\Message::createAttachment() in"


TokenVesting/Timelock with multiple beneficiaries

TokenVesting and TokenTimelock allow for a single beneficiary each. It would be nice to have a single contract that could be used to vest multiple accounts.
Is there a reason this wasn't done in the already built Zeppelin contracts?
Are there any example crowdsales that offer this functionality that may be worth reading?
One way to use the current TokenVesting contract is to create a new contract for each account that needs to be vested. This is a little gas intensive and therefore expensive, but often this will be a minor issue in the case of ICOs. Is this the recommended way to use OpenZeppelin TokenVesting?

[ ] 🐛 This is a bug report.
[ x] 📈 This is a feature request.

I see one example from Aragon that seems to be the kind of thing I'm looking for:
https://github.com/aragon/aragon-network-token/blob/master/contracts/MiniMeIrrevocableVestedToken.sol

Not sure why the decision was made, but it was probably due to "least concerns".
I expect you could compose the TokenVesting contract with a SplitPayment style contract to accomplish the same goal. The only difference is that the SplitPayment contract would have to "pull" the ether/tokens from the vesting contract before allowing beneficiaries to withdraw.
Any ideas on how that could be structured, without making backwards-incompatible changes to the existing TokenVesting/TokenTimelock contracts?

Yes, the rationale was to have the contracts be as simple as possible.
Since anyone can call the release functions in both timelock and vesting contracts, no changes are necessary to compose them with a SplitPayment kind of contract.

Thanks. The SplitPayment contract is for Ether rather than ERC20 tokens however. Would it make sense for us to add a ERC20SplitPayment type contract?
Is the preferred route? If we were to create a TokenVesting contract for multiple payees, would it be possible to add that to OpenZeppelin's suite of contracts, or due to it being slightly more complex, OZ will remain with only the simple single vestor contract?

A split ERC20 contract would be really nice; could it be included into SplitPayment itself?

I think we should add it to SplitPayment itself, yeah. I'm not sure what the interface would be. Maybe another set of functions which receive a token address.
As for adding a multiple-payee vesting contract,    I really think we should just keep the simple one.

I created #898 to fix this problem by composing with SplitPayment.


Quality of docmumentation

If the user is using .NET 6 or later startup.cs is no longer present. Also with all the "enhancements" in removing public static class Program {
}
it is very hard for a seasoned programmer who has little or no exposure to the "latest and greatest enhancements".

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 4a52b0db-6d39-8f43-782a-b8907f06c3f7
Version Independent ID: 87150ad9-f410-7b33-920e-75fd98f030dc
Content: Enable authentication in a web app by using Azure Active Directory B2C building blocks
Content Source: articles/active-directory-b2c/enable-authentication-web-application.md
Service: active-directory
Sub-service: b2c
GitHub Login: @kengaderdus
Microsoft Alias: kengaderdus

@emmaharris1975
Thanks for your feedback! We will investigate and update as appropriate.

@emmaharris1975 Thank you for bringing this to my attention. I understand that you are having trouble with the latest version of .NET and Azure AD B2C.
Indeed, the latest version of .NET has some changes in the way the startup.cs file is structured. However, the concepts and steps for enabling Azure AD B2C authentication in a web application remain the same.
To enable Azure AD B2C authentication in a .NET 6 or later web application, you can follow the steps outlined in the official Microsoft documentation.
Thanks for your contribution. Please add your feedback in below link, so our production team can review it and update the same.
Ideas · Community (azure.com)


Force the user to specify a purpose for the validator script

This should make sure that (likely) mistakes as in https://github.com/OpShin/opshin-pioneer-program/pull/25 are caught by the compilation script.
Leaves an option to circumvent the check.

This depends on https://github.com/Python-Cardano/pycardano/pull/194 and a solution to the hashing problem of #117


Adding Release-plz

We can use Release-plz to perform automatic crate releases and version bumps. The tool is especially if we pair it with conventional commits, since it would automatically generate changelogs based on commit descriptions thanks to git-cliff. Another included feature that I like is automatic  semver checks via cargo-semver-checks but I don't think that's available for binary crates.

This likely depends on #2.


Create Flask app with REST API

A simple Flask http://flask.pocoo.org app could receive TU text (all includes included) and a list of bindings to produce and respond with generated code.
request:
{
  "translation_unit": "class A { int x_; public: int getX() const { return x_; } void setX(int x) { x_ = x; } };",
  "bindings": ["ruby", "python"],
  "module": "TestModule"
}

response:
{
  "TestModule.py" : " ... ",
  "TestModule.rb" : " ... ",
  "TestModule_c.cpp" : " ... ",
  "TestModule_c.h" : " ... "
}

I want to start a separate repo, which will build on top of your docker image. That way I can specify a release tag and not be affected by ongoing development.
Thoughts?

What are the pros and cons vs:

a new repo?
a fork of this repo?
a branch?

I'd go for a branch by default.

Not a fork - if starting a new repo, might as well start from scratch.
Happy to start a branch, let's tidy up the API and docker base image first and then I will get started
Thinking about rendering just 1 page with flask and then sending JS post requests with the translation unit. The max size of a post request will limit how big a header file we can process and I will need to warn the users.
Also we can use client-side javascript to check headerfile for malicious code by keywords like cgroup. IIRC, cgroup is the kernel module that docker uses. I don’t know how exactly accessing cgroups inside a container can lead to privelige escalation, but it feels like a reasonable first attempt at security.


Bad serialization of string in RTF format

Hi fellows!
I've tried to serialize a text in RTF format and the resulting serialization was an bad-formed XML.
The string I've tried to serialize is this:
{\rtf1\fbidis\ansi\ansicpg1252\deff0\nouicompat\deflang3082{\fonttbl{\f0\fnil Segoe UI;}}
{\colortbl ;\red0\green0\blue0;}
{*\generator Riched20 10.0.16299}\viewkind4\uc1
\pard\tx720\cf1\f0\fs23 Sample Text\par
}
I contains lot of braces and slashes that for sure are conflicting with the XML format.
Maybe there is an options to serialize a file as CDATA or something. Is there a workaround? Thank you!

Oh man... yeah we haven't done any of this sort of stuff yet. :)  I will look into this for you, @SuperJMN !

Hey Mike! it may be possible to configure serialization/deserialization on a per-member basis, like converters. It would be useful as a workaround. For instance, I would write a Text property that is a RTF-formatted string to Base64, and convert back on deserialization.
The other option I see is to have some configuration options also for members inside a Type, that allows it to be serialized as CDATA.
What do you think?

@SuperJMN Could you provide code example how you serialize RTF text?
You mean:
string rtfText = @"{\rtf1\fbidis\ansi\ansicpg1252\deff0\nouicompat\deflang3082{\fonttbl{\f0\fnil Segoe UI;}}
{\colortbl ;\red0\green0\blue0;}
{*\generator Riched20 10.0.16299}\viewkind4\uc1
\pard\tx720\cf1\f0\fs23 Sample Text\par
}";

Do you know if it is supported by standard XmlSerializer?

CDATA should also be supported.
Standard XmlSerializer support XmlCDataSection. There is example:
https://social.msdn.microsoft.com/Forums/en-US/6f59a2c0-2f70-4f19-9210-c675bbdce48d/cdata-serialization-with-xmlserializer?forum=asmxandxml
We can create also configuration for it. Example:
 var serializer = new ConfigurationContainer()
			    .Type<Class>() // Configuration of Person class
					.Member(p => p.File).CData()
			    .Create();

Or something like that. @Mike-EEE What do you think?

Yeahar... I like where this is going.  Essentially create an RtfConverter which is then applied to members via a Cdata extension method.  I got some client work that has popped up for me this week, but I should be able to take a look at this starting tomorrow. 👍   FWIW, I am keeping this categorized as a bug as the XmlWriter should be emitting data as CDATA automatically.  So we aren't wired up correctly somewhere.  The rest is considered an enhancement for v2.1 (which, incidentally, I will move to next week as I have not been able to put as much time into EXS as I had hoped this week).

Halt the machines! It seems that there is a bug in the component that generated the RTF! I'm working to see what's going on. It seems that it's nothing to do with EXS.

Woohoo... those are the kind of problems I like. ;)  Please feel free to re-open if it is indeed connected here to EXS.

OK, guys, this is REALLY strange. It keeps happening!
I have prepared a minimum scenario that reproduces the issue. Please, take a look. Clone the repo: https://github.com/SuperJMN/RtfIssue. It's UWP ready to run.
Write some text, click on Save. It can happen 2 things:

An exception is thrown
The file is written, but in a corrupted state

I'm now sure that it's a problem with EXS because if you use the official XmlSerializer, it writes the XML file just right.
If you need any further information, please tell me!

Ahhh ok cool!  Thanks for the repro... and repo. 😆   I will aim to take a look at this today or by tomorrow for sure.

OK! Don't forget to check me at Skype if you need anything! Best regards :)

Alright, there's a "workaround" here:
https://stackoverflow.com/a/32888973/3602057
But I don't like that.  I think the CData method described above is much better.  We'll pipe it through this bad boy here:
https://msdn.microsoft.com/en-us/library/system.xml.xmlwriter.writecdata(v=vs.110).aspx

Holy moly!  Have I been in a rabbit hole.  I am just now getting my environment back online and being able to attend to this.  I hope to have this resolved today or tomorrow.  We'll see how I do. 😛


[VL] Remove DeserializationStream from TaskResource when close() is called

Below code can cause heavy GC, especially when AQE is on with large number of coalesced partitions.
Assuming 8000 shuffle mapper tasks, 8000 shuffle partitions and 200 reducer tasks (mapper output coalesced, each reducer reads 8000/200 = 40 partitions from each mapper), 8 tasks per executor.
There will be ~ 40 partitions * 8000 mappers * 8 tasks = 2560000 objects being added to TaskResource per executor JVM.
      TaskResources.addRecycler(s"ShuffleReaderDeserializationStream_${wrappedOut.getId}", 50) {
        this.close()
      }

we may remove all TaskResource when close it from TaskResources.

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query
log/native_4276_time.csv
log/native_master_01_04_2024_02823192e_time.csv
difference
percentage

q1
33.45
33.27
-0.182
99.46%

q2
25.14
23.30
-1.838
92.69%

q3
37.55
39.36
1.809
104.82%

q4
38.80
38.81
0.010
100.03%

q5
70.80
72.24
1.432
102.02%

q6
7.85
7.06
-0.793
89.90%

q7
86.16
87.34
1.183
101.37%

q8
87.01
86.16
-0.848
99.02%

q9
125.91
126.86
0.944
100.75%

q10
44.60
45.86
1.260
102.82%

q11
20.11
20.86
0.742
103.69%

q12
27.04
26.68
-0.357
98.68%

q13
47.20
46.62
-0.572
98.79%

q14
17.98
19.84
1.863
110.36%

q15
29.03
29.67
0.641
102.21%

q16
15.36
15.55
0.194
101.27%

q17
104.88
101.81
-3.078
97.07%

q18
148.92
152.15
3.226
102.17%

q19
12.65
12.61
-0.035
99.73%

q20
27.07
27.87
0.796
102.94%

q21
225.93
227.23
1.302
100.58%

q22
13.90
14.02
0.118
100.85%

total
1247.34
1255.16
7.817
100.63%


Is it possible to run Caliper on Windows 10?

The question is the same as the title.
Is it possible to run Caliper on Windows 10?

Never tried it. But i think it's possible if all dependencies can be installed successfully.

@haojun, I work hard to try to run caliper on my MacBook Pro but unfortunately failed. It's wise to seek help, is it possible to run caliper on MacBook and which Linux distributions they are written in？thanks！


[Pipeline] Publishing catalog template fails with certificate error

What kind of request is this (question/bug/enhancement/feature request):
Bug
Steps to reproduce (least amount of steps as possible):

Set up a self-signed cert Git service(gitlab/github/bitbucket server)
Add the git server CA root certificate to Rancher server container, following the docs for additional CA.
Configure the Git service under  Tools > Pipelines
Configure the CA root certificate under Tools > Pipelines > Custom CA
Configure and run a pipeline that includes a Publish stage with a publishCatalogConfig step where the catalog is pushed to that same Git service which uses the self-signed cert, e.g.:

(....)
- name: Publish
  steps:
  - publishImageConfig:
      dockerfilePath: ./Dockerfile
      buildContext: .
      tag: my-app:${CICD_GIT_TAG}
  - publishCatalogConfig:
      path: ./charts/template
      catalogTemplate: wordpress
      version: ${CICD_GIT_TAG}
      gitUrl: https://gitlab.example.com/me/mycharts.git
      gitBranch: master
      gitAuthor: admin
      gitEmail<EMAIL_ADDRESS>    envFrom:
    - sourceName: pipeline-auth
      sourceKey: USERNAME
      targetKey: USERNAME
    - sourceName: pipeline-auth
      sourceKey: PASSWORD
      targetKey: PASSWORD
(....)

Result:
Pipeline build fails with following error:
15:57:01 [pipeline_p-5g2j8-1] Running shell script
15:57:02 + publish-catalog
15:57:02 [INFO]check done...
15:57:02 [INFO]prepare config done...
15:57:02 [INFO]publishing to https://gitlab.example.com/me/mycharts.git
15:57:02 Cloning into '/tmp/repo'...
15:57:02 fatal: unable to access 'https://gitlab.example.com/me/mycharts.git/': SSL certificate problem: unable to get local issuer certificate

Support for Git with self-signed certificate was previously added here: https://github.com/rancher/rancher/pull/16686
It seems it only works for cloning the application source code repository but not the catalog template repository.
Other details that may be helpful:
Environment information

Rancher version: v2.2.0

We need to inject custom ca cert to the publish-catalog container as well.
As a workaround at the moment, the following configurations would give some relief:
env:
  GIT_SSL_NO_VERIFY: "true"

I dont think this is v2.2 regression, is it?

@cjellick technically not since catalog templates are a new feature.

Test with rancher/rancher: v2.2.2-rc1
Validate the publishCatalogConfig step with self-signed cert Git service (Gitlab / Github / Bitbucket server), this version of the pipeline can run successfully.


[cloud_firestore] Distinguish "no data" from "not connected" states

When creating views using StreamBuilder connected to a Firestore stream of QuerySnapshot, it seems there is no way to distinguish is it really has no data or it just connecting or waiting for data.
For example, if there is actually no data for a query, the stream would be in 'waiting' state. And if there are some data but it's just not arrived yet, the stream would also be in 'waiting' state.
Therefore you cannot determine wether to show a connecting indicator or an empty placeholder in the UI.
Am I using it wrong?

Hey @HaoCherHong @ibobo could you show some code usage of what exactly you're doing?

It looks as though the API is missing an empty property on the QuerySnapshot class.

You can achieve this by watching for the ConnectionState of the returned snapshot. If the state is active and documents.isEmpty, there is no documents returned from the result.


add route for project workspace, add placeholder component for projec…

…t workspace

@DGKSK8LIFE added a test for the new component to resolve the coverage check.

@DGKSK8LIFE added a test for the new component to resolve the coverage check.

Nice.


When was constraintDepth added?

I was testing some of my code in TS 3.6 and TS 3.7
Code that worked fine in TS 3.5.1 now got the Type_instantiation_is_excessively_deep_and_possibly_infinite error instead.
I decided to do a little investigation and noticed that there was this thing called constraintDepth with a limit of 50. This was what was triggering the error.
I tried to disable the check for this constraintDepth and, predictably, got the error,
                return mapper(type);
                       ^
RangeError: Maximum call stack size exceeded
    at instantiateTypeWorker (/home/anyhowstep/node-projects/tsql/tsql/node_modules/typescript/lib/typescript.js:42582:24)
    at instantiateType (/home/anyhowstep/node-projects/tsql/tsql/node_modules/typescript/lib/typescript.js:42575:26)
    at /home/anyhowstep/node-projects/tsql/tsql/node_modules/typescript/lib/typescript.js:42274:42
    at Object.map (/home/anyhowstep/node-projects/tsql/tsql/node_modules/typescript/lib/typescript.js:507:29)
    at getConditionalTypeInstantiation (/home/anyhowstep/node-projects/tsql/tsql/node_modules/typescript/lib/typescript.js:42537:40)
    at instantiateTypeWorker (/home/anyhowstep/node-projects/tsql/tsql/node_modules/typescript/lib/typescript.js:42620:24)
    at instantiateType (/home/anyhowstep/node-projects/tsql/tsql/node_modules/typescript/lib/typescript.js:42575:26)
    at /home/anyhowstep/node-projects/tsql/tsql/node_modules/typescript/lib/typescript.js:42274:42
    at Object.map (/home/anyhowstep/node-projects/tsql/tsql/node_modules/typescript/lib/typescript.js:507:29)
    at getConditionalTypeInstantiation (/home/anyhowstep/node-projects/tsql/tsql/node_modules/typescript/lib/typescript.js:42537:40)
    at instantiateTypeWorker (/home/anyhowstep/node-projects/tsql/tsql/node_modules/typescript/lib/typescript.js:42620:24)
    at instantiateType (/home/anyhowstep/node-projects/tsql/tsql/node_modules/typescript/lib/typescript.js:42575:26)
    at /home/anyhowstep/node-projects/tsql/tsql/node_modules/typescript/lib/typescript.js:42274:42
    at Object.map (/home/anyhowstep/node-projects/tsql/tsql/node_modules/typescript/lib/typescript.js:507:29)
    at getConditionalTypeInstantiation (/home/anyhowstep/node-projects/tsql/tsql/node_modules/typescript/lib/typescript.js:42537:40)
    at instantiateTypeWorker (/home/anyhowstep/node-projects/tsql/tsql/node_modules/typescript/lib/typescript.js:42620:24)

However, if the code I wrote really was the problem, it shouldn't have run fine in 3.5.1. It should have also exceeded the max call stack size.

I don't have a minimal repro but I noticed something weird.
The following exceeds the constraint depth on 3.6 and 3.7,

However, the following does not,

Trying to nest function calls directly triggers the constraint depth error. But assigning it to a temporary variable is OK.

I'm a bit at a loss here and out of my depth (haha, depth).

When was constraintDepth added?
Why was it added?
What problem was it trying to solve?

Code that worked fine in TS 3.5.1 now hits this constraintDepth error.
Removing the limit causes the max call stack size to be exceeded.
So, it looks to me like there's a bug with the code surrounding the constraintDepth implementation. Hopefully, the answers to my questions can help me refactor my code to not hit the depth limit. Or maybe it'll expose a bug that needs fixing in the TS code base.

The file with the problem may be found here,
https://github.com/AnyhowStep/tsql/commit/c413c1152ae7b65eb2e2a18ee985d6dbb8b31295#diff-dfb1d0c2f356726e8bd4741b3ba718daR12-R29

Clone https://github.com/AnyhowStep/tsql
cd tsql
Checkout c413c1152ae7b65eb2e2a18ee985d6dbb8b31295
npm install
npm run test ./test/run-time/input/expr-library/double/acos/double.ts

I'd like to again stress that this runs fine on TS 3.5.1 =(

https://github.com/microsoft/TypeScript/commit/44ada08e0204ed747e8bbab4c565c3588fb0119e

Also, further proof the functions in question are fine on TS 3.5.1,
https://github.com/AnyhowStep/tsql/commit/f9b73b2820d0f5f5e83db5b4393694d8a75a7342#diff-39b2092b0dd378cba12e94f7af61aba7R11-R573
In the above linked file, I've nested acos() and coalesce() calls 100+ times.
The emit of that giant file is here,
https://github.com/AnyhowStep/tsql/commit/f9b73b2820d0f5f5e83db5b4393694d8a75a7342#diff-925d183e2fe29d7d151e0add12f6e4eeR2-R36
That file and 500+ others only take 27s to compile with TS 3.5.1,

Thanks, @jack-williams , I'll start looking from there.

Instead of trying to figure out which commit broke my TypeOfCoalesce<> recursive type, I decided to just convert it into a trampoline.
https://github.com/AnyhowStep/tsql/pull/65
https://github.com/AnyhowStep/tsql/pull/65/files#diff-0214b2fefabaf1617e690660683db775R226-R237


"[Command failed: $FZF_DEFAULT_COMMAND]" when reloading and the variable contains spaces

[x] I have read through the manual page (man fzf)
[x] I have the latest version of fzf
[x] I have searched through the existing issues

Info

OS

[ ] Linux
[x] Mac OS X
[ ] Windows
[ ] Etc.

Shell

[ ] bash
[x] zsh
[ ] fish

I found #1830 and #1408 but this seems to be a different issue.
I'm running on macOS with zsh, and fzf 0.31.0 (brew). I have run the install script and sourced ~/.fzf.zsh.
Summary: when using reload() in conjunction with the $FZF_DEFAULT_COMMAND variable, I get an error if the command contains spaces. However, I can use commands that contain spaces inside reload() if I hard code them. I accept this may be a config issue on my end, though I am not aware of having changed any settings that might cause this to break. I also tried running these examples using /bin/sh and had the same problem.
I've just discovered fzf and it looks awesome so far; thanks!

When FZF_DEFAULT_COMMAND contains spaces, I get the "[Command failed: $FZF_DEFAULT_COMMAND]" when I try to reload. The ps example fails with that error message:
FZF_DEFAULT_COMMAND='ps -ef' \
  fzf --bind 'ctrl-r:reload($FZF_DEFAULT_COMMAND)' \
      --header 'Press CTRL-R to reload' --header-lines=1 \
      --height=50% --layout=reverse

But if I take out the  -ef part, it works (in the output from ps I can see the time creep up for the fzf command, so it really is re-running the command):
FZF_DEFAULT_COMMAND='ps' \
  fzf --bind 'ctrl-r:reload($FZF_DEFAULT_COMMAND)' \
      --header 'Press CTRL-R to reload' --header-lines=1 \
      --height=50% --layout=reverse

I tried the same thing with ls just to check the problem relates to the space characters in the variable. This causes the "[Command failed: $FZF_DEFAULT_COMMAND]" error on reload:
FZF_DEFAULT_COMMAND='ls -a' \
  fzf --bind 'ctrl-r:reload($FZF_DEFAULT_COMMAND)' \
      --header 'Press CTRL-R to reload' \
      --height=50% --layout=reverse

...but this works:
FZF_DEFAULT_COMMAND='ls' \
  fzf --bind 'ctrl-r:reload($FZF_DEFAULT_COMMAND)' \
      --header 'Press CTRL-R to reload' \
      --height=50% --layout=reverse

In the man page, the invocation example for reload takes the form <key|event>:reload: as opposed to <key|event>:reload() and I'm not entirely clear on why, but trying the colon syntax didn't affect the behaviour. However the docs there referred me to this example, from #1750:
ps -ef | fzf --bind 'ctrl-r:reload(ps -ef)' --header 'Press CTRL-R to reload' \
             --header-lines=1 --layout=reverse

...and this one worked fine! So it must be something to do with variable expansion?
Please let me know if you need any more info.

I'm a bash user, and I didn't realize that the example only works on bash.
# Works
SHELL=bash FZF_DEFAULT_COMMAND='ps -ef' \
  fzf --bind 'ctrl-r:reload($FZF_DEFAULT_COMMAND)' \
      --header 'Press CTRL-R to reload' --header-lines=1 \
      --height=50% --layout=reverse

# Fails
SHELL=zsh FZF_DEFAULT_COMMAND='ps -ef' \
  fzf --bind 'ctrl-r:reload($FZF_DEFAULT_COMMAND)' \
      --header 'Press CTRL-R to reload' --header-lines=1 \
      --height=50% --layout=reverse

So it boils down to
# On bash
SOME_COMMAND='echo foo'
$SOME_COMMAND
  # foo

vs.
# On zsh
SOME_COMMAND='echo foo'
$SOME_COMMAND
  # zsh: command not found: echo foo

The solution is simple; use eval.
eval $SOME_COMMAND
  # foo

So you can do this:
FZF_DEFAULT_COMMAND='ps -ef' \
  fzf --bind 'ctrl-r:reload(eval "$FZF_DEFAULT_COMMAND")' \
      --header 'Press CTRL-R to reload' --header-lines=1 \
      --height=50% --layout=reverse

I'll consider updating the examples.


/home command it does not work

/ home command does not work with uessentials and other plugins

Are you using the latest version? One of the older versions was trying to teleport the player inside the bed model, so a newer version properly offsets them vertically identical to the vanilla game.

Thanks, I've fixed the issue changing essentials.command.home to rocket.home in permissions text

Glad to hear it!


Make it possible to disable building and running tests

For both master and 1.1.0

+1

Any chance to get this merged? It nicely reduces log output by a third and noticeably reduces build-time as well.
With:
https://ci.appveyor.com/project/vsz/harbour-deps/build/1.0.947
Without:
https://ci.appveyor.com/project/vsz/harbour-deps/build/1.0.945

Merged

Could this patch be merged to the next release of 1.1.0 (and 1.1.1)?


NameError: name '_' is not defined

Quickly following the docs examples I got the error bellow. I was hoping for those placeholders to be converted to strings automatically but it seems like they aren't in some cases.  My bad.

Ok good. I think that the import is it at the beginning of the example in the readme :)