Display config bug from Zendesk

there is a bug in the display driver, where it doesn’t read the settings from the config file correctly.
Quick way to test:
"eyes": [
{
"center_proj_x": 0.5,
"center_proj_y": 0.5,
"rotate_180": 0
},
{
"center_proj_x": 0.5,
"center_proj_y": 0.5,
"rotate_180": 1
}
]
You would expect one half of the screen to be upside down, but both are, if you swap it:
None of the first group of eye settings are taken. I’ve looked at all the configs and they are all the same…

Is this with the RenderManager examples?  If not, which application is being run?

Hi Russel
Test with sightline or palace demo...
Also note that when making adjustments of say 0.1 or 0.9 the projection isn't shifted as expected, it also tilts and distorts.

Hi
I've been thinking about the way the configuration is implemented, there doesn't appear to be any reference anywhere to display density, which if you don't have you can't adjust IPD accurately. Under user settings that plugin is used to set IPD however if the display density isn't known, how is IPD accurately implemented?
The way Oculus does it makes more sense, you'd want display size/resolution(from which you will calculate your X-offset at  lens separation, let's use 64mm as an example), you'd also want a Y offset for lens height settings. Your IPD settings should then be based on the X/Y-offset, so IPD of 60mm should be set as X-offset -2mm X-Projection in case of fixed lenses(this needs testing, I'm assuming it will work by complensating for image shift due to off axis IPD), in case of adjustable IPD lenses then an IPD of 60mm should be set as X-offset -2mm X-offset since the user is on-axis.
I'm using offset here instead of projection because from what I see currently when you adjust X and Y projection it appears to shift the camera view, which might be usable in the scenario above with fixed IPD lenses. An offset would simply be shifting the flat picture.
Regards,
Jonathan.

Hi
I've got the new 3.8" displays, they don't work with 0.5 x projection, why doesn't "center_proj_x" or "center_proj_y" work? You can try adjust them from 0-1 and nothing changes.
Using latest OSVR binaries, doesn't work with or without rendermanager configs.

I debug things like this using the RenderManager example programs, for the case of center of projection I use the RenderManagerOpenGLHeadSpaceExample.exe from C:\Program Files\OSVR\SDK\x64\bin because it puts a cube in the center of the field of view.
Using the attached config file and running with no HMD attached, I see the two cubes centered in each eye.  When I change the center of projection in X to 0.1 in the first eye and 0.9 in the second, the cubes move to the far left in the left eye and the far right in the right eye.
nondirectmode_window.zip
A description of the configuration parameters can be found at https://github.com/OSVR/OSVR-Docs/blob/master/Configuring/distortion.md with the description of how to adjust the configuration file found near the end.  Note that there is currently an open issue whereby the center of projection values are specified in D space, rather than with the range 0-1, so a large scaling for the distortion coefficients may require larger values until that is fixed.

Thanks Russel, problem is it doesn't work with real content. I just installed the SDK, I see what you mean, the blue cubes follow the projection. Try it with any unity content and you won't get the same result, this is probably a bigger problem then since it might mean a problem with the unity plugin?

How is OSVR HDK2 handling this because the AUO displays have a center projection at 67.6mm IPD. I look at the HDK json and it's set at 0.5

Is there no bypass trick we can try to make this adjustment in another way?

The HDK2 handles this by having its distortion correction render from a virtual screen that is symmetric, even though the display configuration itself is not symmetric.  The pointer to the distortion.md above describes in general how this might be done, and the angles_to_config program described at https://github.com/OSVR/distortionizer/blob/master/angles_to_config/doc/anglesToConfig.md shows in detail how to construct such a distortion correction.
I don't understand the question about making the adjustment another way.  The current way is working for me for all paths that use RenderManager so for those we should not need another way.  For code not using RenderManager, it can implement this however it likes.  If the RenderManager path is not working for you, we should figure out why and fix it.

Sorry, missed the point about Unity content.  I'll add @DuFF14 to the conversation because he is working on that plug-in.

Thank you again Russel, I understand now how you do this with the HDK. Would you mind uploading a copy of the angles_to_config compiled utility?

Here is a version that was compiled quite some time ago, but it should still work.  You should also be able to build from source at https://github.com/OSVR/distortionizer/tree/master/angles_to_config
AnglesToConfig.zip

Thanks again Russel, unfortunately the utility doesn't work, I ran the commands exactly as given here: https://github.com/OSVR/distortionizer/blob/master/angles_to_config/doc/anglesToConfig.md
It just returns the options as if you typed "anglestoconfig /?"

Sorry it also creates the json output but it's empty.

Argh.  Okay, I updated the code to work with the latest factoring of RenderManager and compiled a new executable:
AnglesToConfig.zip
This works for me with the example .txt file for the HDK 1.3 and the command-line options specified in https://github.com/OSVR/distortionizer/blob/master/angles_to_config/doc/anglesToConfig.md

Note that you need to hand-edit a server file to use this client config, and that the server/client mechanism is deprecated and hopefully soon to be replaced by a server json protocol that can transmit large enough descriptions that we include them in the server config file.

Thank you again, it works!

Hi Russel, I really don't see how it's working with the HDK2, I've tried all options, including the built in ones and the IPD doesn't change at all, it could be that because the eye relief on my headset is virtually 0, I need IPD adjusted to the measured value, I'm not really sure why I don't see anyone else complaining about this, I've ordered a set of OSVR lenses to try out as well. So we'll see if at 10mm eye relief it's still a problem.
I've found a workaround for OSVR native titles, I calculated IPD to be 64mm at a resolution of 2006x1200, When I put this as the display resolution in the OSVR config file I can actually get focus. My displays are spaced 1mm apart so the IPD at 2160 is 68.6mm. The problem though is that this resolution hack doesn't work with SteamVR.

The COP offsets are not the same thing as IPD.  They describe where the center of focus of the lens hits the screen.  IPD affects the separation between the projection matrix locations in world space, and it is controlled by an optional parameter to the GetRenderInfo() call in RenderManager.
If you are having resolution issues in Extended mode, it may be because Windows is deciding the magnify the application on that display; you need to set display scaling to 100% to make this go away.

Hi
I would like to apologize for the long reply so long. :)
You can't possibly work on the assumption that all lenses are aligned to the center of the displays and all people have their IPD's at the center of the lenses. My lenses are at 64mm and the displays are at 68.6mm, I believe the HDK 2 has a similar misalignment, yet in the config files COP is at 0.5. There is no clarity on what the virtual camera separation is in mm, at some stage you need to convert from pixels to mm, and as far as I know this isn't done, but I might be mistaken?
So if you have a 64mm IPD, the lenses are at 64mm, but the display is at 68.6mm, you get double vision beyond about 800mm, so you can only actually focus on objects close by and the eye strain is pretty bad on far away objects. What needs to happen is the user's actual IPD needs to be reflected completely, the virtual camera's separation needs to be set at IPD, the only setting currently can be used is the COP, which should be equal to the user's IPD if possible, and if not it should be less, but never more.
If we use the example of a user with a 60mm IPD, non-adjustable lens separation of 64mm and a display separation of 68.6mm, where should the COP be? If you wan't it at 64mm as I understand you are suggesting, then what mechanism is used to further adjust the display offset or virtual camera to match the user's IPD of 60mm? To be honest COP as implemented doesn't seem to serve a purpose (let's assume it actually worked in the available content), other than to align the lens to the display, which has no practical application, this information is not used to calculate the actual display position/size/offset etc. and is not used for the virtual camera separation either for the same reason.
I'm using a workaround because I am unable to get COP figures to be accepted and from what I can tell there is no IPD adjustment in the OSVR system, the display setup for 100% scaling, the display is set for 2160x1200 resolution inside windows, however in the OSVR config file I've changed the resolution to 2006x1200, from my calculations in my headset this is at 64mm. I can use OSVR titles without double vision, in showdown I can focus on the robot in the distance, try that with the standard HDK 2 and config file and you will see double vision on the objects far away.


Support gatsby@next

Support the next version of Gatsby (currently at 2.0.0-beta.61). The Material UI example under examples/gatsby works with Gatsby version 1, but gives the following error with Gatsby version 2:
Module build failed (from ./node_modules/babel-loader/lib/index.js):
SyntaxError: /Users/narbhati/projects/material-ui/examples/gatsby/.cache/develop-static-entry.js:
Support for the experimental syntax 'objectRestSpread' isn't currently enabled (72:5):

  70 |
  71 |   const htmlElement = React.createElement(Html, {
> 72 |     ...bodyProps,
     |     ^
  73 |     body: ``,
  74 |     headComponents: headComponents.concat([
  75 |       <script key={`io`} src="/socket.io/socket.io.js" />,

Add @babel/plugin-proposal-object-rest-spread (https://git.io/vb4Ss) to the 'plugins' section
of your Babel config to enable transformation.

It would be even better if Material UI can be officially supported as a gatsby plugin, similar to Styled Components and Glamor. See associated Gatsby docs here and here.

[x] This is a v1.x issue.
[x] I have searched the issues of this repository and believe that this is not a duplicate.

@nareshbhatia https://github.com/gatsbyjs/gatsby/issues/2116#issuecomment-402642507

@oliviertassinari Have you gotten it working with wrapPageElement or wrapRootElement on gatsby v2 yet?
These were added (along with gatsby-plugin-layout which might also help) to try to alleviate any stutter when transitioning from one page to another.

@cpboyd I updated the example to support v2. It's as simple as possible. I haven't tried to use these method, should we?

@oliviertassinari I'll try to post a small example shortly... (I've got it working by updating your example.)
I'm currently still trying to figure out my browser rendering issues on my existing project first, though.

I created a starter template for Gatsby v2 and Material UI v3. I am not running into any issues! I don't know what wrapPageElement or wrapRootElement are. I have simply used withStyles and withRoot as suggested in the Material UI example. Let me know if I am missing something.

@oliviertassinari I've uploaded a simplified reproduction of the issue:
https://github.com/cpboyd/gatsby-layout-mui-bug
In this example, the standard example will initially load centered but then moves to the top left once Javascript rendering takes over.
The root cause of the issue was simply adding a second page. (in this case, contact.js is an identical copy of index.js)
Note: Removing the wrapPageElement will still exhibit the same behavior without the layout wrapper.

@oliviertassinari Fixed in the latest commit... It seems the renderer is very finicky about what scope objects are instantiated for.
The SheetsRegistry needs to be external to the wrapRootElement and onRenderBody, but everything else should be internal to wrapRootElement.

Hmm... So it seems that putting the SheetsRegistry outside of the functions still causes rendering issues with certain more complex stylings (my project uses a Slider from @material-ui/lab)


fpie command error in colab notebook

Thanks for providing this repo. I got errors while running the colab notebook. It says cant find the fpie command. What is this fpie in simple_runner.py script?
    subprocess.run(
            ["fpie", "-s", orig_img_pth, "-m", "mask.jpg", "-t", "edited.png", "-o", unaligned_path, "-n",
             "5000", "-b", "taichi-gpu", "-g", "src"],
            check=True
        )

Found 1 faces, getting the largest
Save aligned image to editing_res/scarlet/scarlet_aligned.jpg
Prepearing mask
/content/StyleFeatureEditor/models/farl/farl.py:38: FutureWarning: You are using torch.load with weights_only=False (the current default value), which uses the default pickle module implicitly. It is possible to construct malicious pickle data which will execute arbitrary code during unpickling (See https://github.com/pytorch/pytorch/blob/main/SECURITY.md#untrusted-models for more details). In a future release, the default value for weights_only will be flipped to True. This limits the functions that could be executed during unpickling. Arbitrary objects will no longer be allowed to be loaded via this mode unless they are explicitly allowlisted by the user via torch.serialization.add_safe_globals. We recommend you start setting weights_only=True for any use case where you don't have full control of the loaded file. Please open an issue on GitHub for any issues related to this experimental feature.
pretrained_dict = torch.load(
Done
Use mask from editing_res/scarlet/scarlet_aligned_mask.jpg
FileNotFoundError Traceback (most recent call last)
in <cell line: 5>()
3 target_prompt = "face with fire hair"
4 disentanglement = 0.1
----> 5 runner.edit(
6 orig_img_pth="notebook/images/scarlet.jpg",
7 editing_name=f"styleclip_global_{neutral_prompt}{target_prompt}{disentanglement}",
4 frames
/content/StyleFeatureEditor/runners/simple_runner.py in edit(self, orig_img_pth, editing_name, edited_power, save_pth, align, use_mask, mask_trashold, mask_path, save_e4e, save_inversion)
202 if align:
203 unaligned_path = save_pth.parents[0] / (save_pth.stem + "_unaligned.jpg")
--> 204 unalign(edited_image, unalign_dict, orig_img_pth, unaligned_path)
205
206 return edited_image
/content/StyleFeatureEditor/runners/simple_runner.py in unalign(edited_image, unalign_dict, orig_img_pth, unaligned_path)
105 PIL.Image.fromarray(np.uint8(np.clip(np.rint((1 - mask) * 255), 0, 255)), 'RGB').save("mask.jpg")
106
--> 107 subprocess.run(
108 ["fpie", "-s", orig_img_pth, "-m", "mask.jpg", "-t", "edited.png", "-o", unaligned_path, "-n",
109 "5000", "-b", "taichi-gpu", "-g", "src"],
/usr/lib/python3.10/subprocess.py in run(input, capture_output, timeout, check, *popenargs, **kwargs)
501 kwargs['stderr'] = PIPE
502
--> 503 with Popen(*popenargs, **kwargs) as process:
504 try:
505 stdout, stderr = process.communicate(input, timeout=timeout)
/usr/lib/python3.10/subprocess.py in init(self, args, bufsize, executable, stdin, stdout, stderr, preexec_fn, close_fds, shell, cwd, env, universal_newlines, startupinfo, creationflags, restore_signals, start_new_session, pass_fds, user, group, extra_groups, encoding, errors, text, umask, pipesize)
969 encoding=encoding, errors=errors)
970
--> 971 self._execute_child(args, executable, preexec_fn, close_fds,
972 pass_fds, cwd, env,
973 startupinfo, creationflags, shell,
/usr/lib/python3.10/subprocess.py in _execute_child(self, args, executable, preexec_fn, close_fds, pass_fds, cwd, env, startupinfo, creationflags, shell, p2cread, p2cwrite, c2pread, c2pwrite, errread, errwrite, restore_signals, gid, gids, uid, umask, start_new_session)
1861 if errno_num != 0:
1862 err_msg = os.strerror(errno_num)
-> 1863 raise child_exception_type(errno_num, err_msg, err_filename)
1864 raise child_exception_type(err_msg)
1865
FileNotFoundError: [Errno 2] No such file or directory: 'fpie'

Hi, you can fix this with !pip install fpie in your notebook. However, we have updated our collab so that now fpie is installed during the installation of other packages. If the problem is solved, please close this issue.


Palette picker

Hi,
Nice project!
Last release of shinyWidgets on CRAN use new version of bootstrap-select and it implies some differences with the old behaviour, to make the palette picker works again, you can add somewhere in your UI this line :
tags$style(".bootstrap-select .dropdown-menu li a span.text {width: 100%;}")

(no better solution for the moment)
And maybe remove padding in the content :
"
%s
"
# instead of
"
%s
"

Cheers,
Victor

Thanks Victor 👍.
I reduced the padding to 2px, imho it looks better and can't find any system where it breaks.
Please let me know if that fixes it for you also and thanks for the feedback :)


Fix Background dimming animation broken

Summary
Fix #72.
When the pan modal is presenting as not max-height PanModalHeight (or topOffset is not 0), backgroundView is dimming immediately.
The issue has occurred from #53. If this commit is for device rotation, it has not to adjusts the backgroundView dim state.
In this PR, only the y position is changed.
Requirements (place an x in each [ ])

[x] I've read and understood the Contributing Guidelines and have done my best effort to follow them.

[x] I've read and agree to the Code of Conduct.

[ ] I've written tests to cover the new code and functionality included in this PR.

Hi @KyoheiG3
Apologies for the delay, this looks good - thank you for the fix!

Can I ask for a release? @ste57


Cannot use custom Windows AMI

There's no way to specify a windows username and password to configure a windows machine from a custom built AMI.

@tyler-ball confirmed that this feature is already in master


Replace bash with sh in resource listing script

This PR fixes the "bash command not found error" in #95.


chore(main): release 3.74.0

:robot: I have created a release beep boop
3.74.0 (2024-11-16)
Features

icons: Update Lucide to https://github.com/lucide-icons/lucide/releases/tag/0.460.0 (94c28e8)

This PR was generated with Release Please. See documentation.

:robot: Created releases:

v3.74.0
:sunflower:


Building with VS 2010

When I try to build using VS 2010, I get the following message:
C:\Source\FlaUI\src\FlaUI.Core\FlaUI.Core.csproj : error  : Unable to read the project file 'FlaUI.Core.csproj'.
C:\Source\FlaUI\src\FlaUI.Core\FlaUI.Core.csproj(1,1): The default XML namespace of the project must be the MSBuild XML namespace. If the project is authored in the MSBuild 2003 format, please add xmlns="http://schemas.microsoft.com/developer/msbuild/2003" to the  element. If the project has been authored in the old 1.0 or 1.2 format, please convert it to MSBuild 2003 format.

Won't work. You need VS2017.3 to build it. But you can use it with anything that supports .net 3.5 or higher.


reComfortaa

Song Selection

Gameplay

The font is called comfortaa. I'm not creative with names.
Also couldn't think of a design to fit a progress bar so I decided to do away with it.

Hello
In my opinion design itself needs improvements

Pp's and score rank need to be aligned to vertical center
difficulty and mapper font is too small and thin. Imagine scaling down this counter to size it would be on stream, it would be hardly readable
Also underline on hits with different width looks kinda strange, probably would be better to make it static

Added fade to overflowing diffculty and mapper text instead of using ellipses

I think you need to maybe align diff and mapper to center if it doesn't cover all size of a div.
Still not sure that this would work but give it a try.
Another way this looks not balanced i guess

Everything else lgtm

Sorry for the delay, busy week.
Not sure if this is what you mean but this is what I thought when you said to align them in the center

Yeah that what i meant. Naah still not sure that it's looks good. Well just leave as it was before. I approve. It will be merged before next gosumemory release

Thanks!


Expand filter parameters for game.pf2e.compendiumBrowser.openTab()

I would like to use the game.pf2e.compendiumBrowser.openTab function in macros to open the compendium browser with feats or spells of a particular level but it does not currently take a "minLevel" parameter.
To keep the function backwards compatible, I added the parameter in the last position with a default value. I would be happy to change it to something like levelFilter: { min: number; max: number; } if need be.

How much would expect to break if we change it to be an options parameter? If possible, might be better to break sooner rather than later if we want to toss in configuration options.

I don't think that there is an easy way to know since changing the parameters would mainly impact other Foundry modules that try to open the compendium browser with arbitrary filters and (possibly) user macros.

Personally, I'm of the mind we should wait till V10 and then break all compatibility and use object params. Use the fresh start to make this method much nicer.

Compatibility can now be broken, we start the v10 train. Go nuts!

Ok. I did go nuts.
I tried to cover every filter currently available in the compendium browser while trying to derive most data types from the existing ones.
Usage example in macros :
Show every uncommon level 3 spell taking 3 actions, sorted by descending name:
game.pf2e.compendiumBrowser.openTab("spell", {
  selects: {
    timefilter: "3"
  },
  checkboxes: {
    level: ["3"],
    rarity: ["uncommon"]
  },
  orderBy: "name",
  orderDirection: "desc"
});

Show every common alchemical item of level 5 or more costing 5000 gp or less, sorted by price:
game.pf2e.compendiumBrowser.openTab("equipment", {
  checkboxes: {
    rarity: ["common"]
  },
  multiselects: {
    traits: ["alchemical"]
  },
  ranges: {
    price: { max: "3000gp" }
  },
  sliders: {
    level: { min: 5 }
  },
  orderBy: "price"
});

Would need @stwlam's input, but personal preference, not a fan of splitting by control type. Splitting by just actual field might be better.
So like, maybe just
game.pf2e.compendiumBrowser.openTab("equipment", {
  rarity: ["common"],
  traits: ["alchemical"],
  price: { max: "3000gp" },
  level: { min: 5 },
  orderBy: "price",
});

I'd go one step further and try to have rarity as part of traits, since rarity is a trait and we can sort out the difference in the browser, but that's personal preference.

I started doing just that but then realized it would have been much harder to present a common and strongly typed method signature for openTab : the equipment tab uses a multiselect for traits whereas others use checkboxes and the spells tab uses checkboxes for levels whereas others use a slider. I also tried to stay close to the existing data type to facilitate future changes.
I would keep the new openTab() function as is but add some wrapper functions (like OpenSpellTab that already exists) to convert from the "user-friendly" data types to the "technical" one.
Also, rarity might be a trait in the rulebooks but it is currently handled separately in all data entries. I think it makes sense to keep it separate than to artificially merge it with an other parameter then having to extract it with a special case.

I'll have to double check, but give it was able to handle a list of string properties based on {key}-{value} joins, it doesn't seem like the type of the form element should affect anything (it was able to resolve the param regardless of the form element). A few might be tricky (probably level), but it doesn't seem like traits and a few others were at all.
I will need to double check to be 100% certain though.

Sure, representing all filters with a string code is a possible solution.
Previously, filters could only apply to checkboxes and were built like this : [category]-[checkboxValue].
We could have a similar system and check the category name in each control type instead of just checkboxes but that would mean having almost completely type-less parameter : everything would be of type "Record<string, string | number | { min?: number | string; max?: number | string }>".
Since this is primarily aimed to be used outside of a TypeScript environment, having a strong typing may be overkill.
Up to you.

I think those that are a range (like level) can be separate from those that are "checkboxes", but given that the tagify components have a whitelist, they're functionally no different in the data model compared to checkboxes. They're just another way to represent the same data.
This is an API after all, and we don't want to leak implementation details to the outside world. I don't really mind if traits are a different array than categories (that sounds like a great idea) nor that rarity is separate from traits (can go either way), but leaking to the outside world whether something is a range or a slider or a checkbox is really a no go.
I guess also make sure you don't break the feat browse filtering. Clicking browse on ancestry feats does filtering based on your ancestry for example.

In the compendium browser would it be possible to get a new filter for Feats For  [Trained in...], [Expert in...], [Master in...], [... Dedication], [Basic..], [Initial...], etc
Just so with can filter on Prerequisites?

Prerequisites are presently text so this is very unlikely until we have a better backend and a lot of data entry work

Now, the names of the filter parameters are the same as the ones in the interfaces based on BaseFilterData, except for sliders and ranges. These parameters are names "levelRange" and "priceRange". This is necessary because there is already a "level" parameter for a checkboxes filter in the "spells" tab.
Same examples :
Show every uncommon level 3 spell taking 3 actions, sorted by descending name:
game.pf2e.compendiumBrowser.openTab("spell", {
  timefilter: "3",
  level: ["3"],
  rarity: ["uncommon"],
  orderBy: "name",
  orderDirection: "desc"
});

Show every common alchemical item of level 5 or more costing 3000 gp or less, sorted by price:
game.pf2e.compendiumBrowser.openTab("equipment", {
  rarity: ["common"],
  traits: ["alchemical"],
  priceRange: { max: "30000sp" },
  levelRange: { min: 5 },
  orderBy: "price"
});

ESLint rule has been merged in


Connected redis client prevents tests from completing

Strange problem where the test doesn't finish when a redis client remains connected.
var test = require('tape');
var redis = require("redis").createClient();

test('this will not finish', function(t) {
  t.plan(1);
  t.equal(true, true);
});

//This will work as expected
var test = require('tape');
var redis = require("redis").createClient();

test('this will finish', function(t) {
  t.plan(1);
  redis.quit();
  t.equal(true, true);
});

Unfortunately I am using the redis client in a module and it's not so straight forward to quit the connection in my tests.
In case it helps, this is the declaration at the top of a module i'm having difficulties testing with tape.
var redisClient = require('redis').createClient(process.env.redis_url || null),
  throttle = require('tokenthrottle-redis')({
    rate: 5,
    window: 60 * 60 * 1000,
    expiry: 60 * 60 * 24,
  }, process.env.use_redis ? redisClient : null);

@jpiulac tape doesn't do any magic (which is a good thing IMO) so you'll have to close that Redis down yourself.  Thankfully its pretty easy by calling redisClient.unref() in your test suite to ensure it won't keep the event loop open when you are finished running your tests.

This is a feature.
The tests did not succeed because you leaked a resource.
Resource leaks are bugs

Thank you.  That's cleared it up.


npm package name wrong

https://www.npmjs.com/package/mark.js points to another reposiroty
and you are using same mark.js as package.json name
please fix

@lorvent This was also requested in https://github.com/julmot/mark.js/issues/34. mark.js isn't published to npm. And unfortunately @lukasoppermann decided to steal the name for his own application. I'm sorry for the confusion. You'll have to use $ npm install julmot/mark.js


How can I resolve this?

Does this issue occur when all extensions are disabled?: Yes/No

VS Code Version:
OS Version:

Steps to Reproduce:

The lines are on top of each other, and I wanted to disable this

/question
This feature is called Sticky Scroll and should give you context in which class/functiin/construct you are.
Yiu can right cluck on it, use View > Appearance in Menu, is change settings.

disable the "sticky scroll"

We closed this issue because it is a question about using VS Code rather than an issue or feature request. Please search for help on StackOverflow, where the community has already answered thousands of similar questions. You may find their guide on asking a new question helpful if your question has not already been asked. See also our issue reporting guidelines.
Happy Coding!


Handle missing attributes for assistant streaming

What:

[X] Bug Fix
[ ] New Feature

Description:
Fixes an error when OpenAI's API returns a delta object which has empty tool calls:
Undefined array key "id" {"exception":"[object] (ErrorException(code: 0): Undefined array key \"id\" at /var/www/html/vendor/openai-php/client/src/Responses/Threads/Runs/Steps/ThreadRunStepResponseFunctionToolCall.php:41)
(
    [id] => step_voklimBxRmx023PqaIxX6hya
    [object] => thread.run.step.delta
    [delta] => Array
        (
            [step_details] => Array
                (
                    [type] => tool_calls
                    [tool_calls] => Array
                        (
                            [0] => Array
                                (
                                    [index] => 0
                                    [type] => function
                                    [function] => Array
                                        (
                                            [arguments] => {}
                                        )
                                )
                        )
                )
        )
)

This is happening to me for all streamed assistant responses that invoke function calls, the function itself appears in one delta, and the next delta then shows the empty function above.
The current implementation is expecting these delta objects to have ID and name fields, which it seems the empty functions don't have.
This is related to the assistants streaming functionality merged in earlier today: https://github.com/openai-php/client/pull/367/

Thks @robbie-thompson  !
I had the same problem...And your fix is working !

Thanks @robbie-thompson for the PR!


Harden driver's property requirement check

Make sure that the property that's given to the adapter is matched to one of the properties that the adapter provided. If none matched, the state would change to Close.

This depends on #173.

It's still not clear how to achieve this with the new prop.MediaConstraints. I'll close this for now and revisit again in the future.


Generation ignore a query parameter

Description
Hello,
You can retrieve in this repro a base to reproduce the bug.
https://github.com/Kalshu/heyapi/tree/main
I have a swagger file in this repro how declare several endpoint with common model but one model have a query parameter to filter the result
https://github.com/Kalshu/heyapi/blob/b6f333b03f044ffcda973117aabdfc7279e5c5fa/swagger.json#L222
,           {             "name": "fromStore",             "in": "query",             "schema": {               "type": "boolean",               "default": false             }           }
But this parameter is ignored by the generation and we can retrieve it in the final method
https://github.com/Kalshu/heyapi/blob/b6f333b03f044ffcda973117aabdfc7279e5c5fa/src/_generated/test/services.gen.ts#L91
https://github.com/Kalshu/heyapi/blob/b6f333b03f044ffcda973117aabdfc7279e5c5fa/src/_generated/test/types.gen.ts#L66
Reproducible example or configuration
https://github.com/Kalshu/heyapi/tree/main
OpenAPI specification (optional)
No response
System information (optional)
No response

Thanks @Kalshu, will check!

@Kalshu do you want to separately talk about how you're using Hey API? I see your methodNameBuilder() function, can you describe what's missing/the desired behaviour that would simplify your setup?

@Kalshu this is due to duplicate operation IDs, these are meant to be unique if provided. Not following that may produce unexpected results as you found out

@Kalshu do you want to separately talk about how you're using Hey API? I see your methodNameBuilder() function, can you describe what's missing/the desired behaviour that would simplify your setup?

Hi @mrlubos, where do you want to speak about the name generation ?
About the invalid swagger specification, maybe it will be a good feature to call https://validator.swagger.io/ during the generation to warn the user if the spec is not fully validate

You can comment here.
RE validation, yes at some point, but not any time soon. It's easy enough to validate on your own compared to what it would take to build into the library

About the name generator,
Initially, there was a bug with the use of the word “delete” in the name of certain methods. So I started by overloading the name generation method to bypass the bug.
Then I must have had a problem with operationsIDs (which I'm working on).
Now it's more a question of standardization in the code, as we use different api managed by different teams.
The operations ids won't always follow the same logic and nomenclature. I therefore prefer to define the names of my methods with the path of the endpoints, which are normally explicit. What's more, using the http verb makes it easier to understand api actions (Post vs Patch vs Put).
Ideally, I'd find it interesting to have an option that lets you choose between different name generation algorithms.
Translated with DeepL.com (free version)


[Integration] Installing operators changed in OCP 4.5

General information

OS: Linux / macOS / Windows
Hypervisor: KVM / Hyper-V / hyperkit

CRC version
CodeReady Containers version: 1.12.0+5a4ca94
OpenShift version: 4.5.0-rc.4 (not embedded in binary)

Steps to reproduce

Run integration tests in story_marketplace.feature

Actual
bash: oc apply -f etcdop-csc.yaml
stderr: error: unable to recognize "etcdop-csc.yaml": no matches for kind "CatalogSourceConfig" in version "operators.coreos.com/v1"

Logs
pipeline run

This is already fixed and now part of integration tests.


fix issue #106: language selector

Issue and root cause
Under the /npo route, using the language selector doesn't switch languages but loads the login page instead.
The problem was caused by using req.url in page.jade view for building the redirection path, which returns the path relative to '/npo' due to the usage of express.Router() instead of full path like in routings made with app.* methods.
Proposed solution
Inside the view, using req.originalUrl returns the same path for both app.* and express.Router() routes.

thanks @mickeyil - and welcome to Spark!

tested :ok:

Thank you @mickeyil  :)

Thanks @mickeyil, don't be a stranger. Come work with us @ ironSource every Wed. evening.

Glad I could help on this one :)
@omerpines, I'll be there this Wednesday.


Unsaved file should be available after editor closed

VSCode Version: Code 1.6.0 (e52fb0bc87e6f5c8f144e172639891d8d8c9aa55, 2016-10-10T18:30:01.819Z)
OS Version: Linux x64 3.13.0-92-generic
Extensions: Tyriar.lorem-ipsum-1.0.0, medzhidov.font-awesome-codes-html-0.0.3

Steps to Reproduce:
1.When closing editor unsaved files are gone
2.If unsaved files are available even after window closed that would be good

See #101 for the ongoing discussion about this feature.

thanks

@kaiwood thanks for pointint out that this is a duplicate


redux 4 support

Uncaught TypeError: Cannot read property 'get' of undefined
at eval (selectors.js?a015:10)
at eval (index.js:75)
at eval (index.js:35)
at eval (index.js:89)
at eval (index.js:35)
at eval (index.js:85)
at Function.eval [as mapToProps] (index.js:35)
at mapToPropsProxy (wrapMapToProps.js:54)
at Function.detectFactoryAndVerify (wrapMapToProps.js:63)
at mapToPropsProxy (wrapMapToProps.js:54)
react-dom.development.js:9643 The above error occurred in the <Connect(Me)> component:
in Connect(Me) (created by withReducer(Connect(Me)))
in withReducer(Connect(Me)) (created by Route)
in Route (created by withRouter(withReducer(Connect(Me))))
in withRouter(withReducer(Connect(Me))) (created by LoadableComponent)
in LoadableComponent (created by Route)
in Route (created by App)
in Switch (created by App)
in div (created by App__AppWrapper)
in App__AppWrapper (created by App)
in App
in Router (created by ConnectedRouter)
in ConnectedRouter
in Provider
Consider adding an error boundary to your tree to customize error handling behavior.
Visit https://fb.me/react-error-boundaries to learn more about error boundaries.
logCapturedError @ react-dom.development.js:9643
selectors.js?a015:10 Uncaught (in promise) TypeError: Cannot read property 'get' of undefined
at eval (selectors.js?a015:10)
at eval (index.js:75)
at eval (index.js:35)
at eval (index.js:89)
at eval (index.js:35)
at eval (index.js:85)
at Function.eval [as mapToProps] (index.js:35)
at mapToPropsProxy (wrapMapToProps.js:54)
at Function.detectFactoryAndVerify (wrapMapToProps.js:63)
at mapToPropsProxy (wrapMapToProps.js:54)

Thanks for the stack trace, but we need some more context to understand what's going on.  Can you show us the code that you're running, preferably with it reproducing the issue?

From the error message, this smells more like a null check issue when accessing a deep property chain.  It is unlikely a Redux issue.  We use reselect with frameworks well outside of Redux, time and time again we have run into similar errors but all trace to nulls in property chain.

I have similar issue. Everything works fine on redux 3.7.2, but after update to 4.0.0 I have Uncaught TypeError: Cannot read property 'unreadNotifications' of undefined.

sorry, i found a solution. it seem's like not the issue here. so i will close it. hopes it helpful for others.
https://github.com/react-boilerplate/react-boilerplate/issues/2188


Can't seem to spawn underground structures correctly

Hi there simibubi,
I'd like to ask some details on how to set up structures that spawn underground, I can't seem to make it work since they tend to spawn way above the maxY I set it up with. Also letting you know that I also set the placement type as "underground".
I'm also attaching one of the structure spawner jsons I made as a sample of what I set up with
`{
"template": {
"type": "single",
"id": "pack:gold_vein",
"followTerrain": true
},
"averageSpacing": 40,
"avoidOthers": false,

"placement": {
    "offset": -1,
    "minY": 21,
    "maxY": 35,
    "type": "underground"
},

"dimensions": [
    "minecraft:overworld"
],

"biomes": [
    "#mesa"
]

}
`

Hi again, sorry for the bother. Did some tests again and found out that the thing that's causing the issue was the " "followTerrain": true " line preventing the underground placement type to generate.


feat: added prompts section under general in settings

dropdown for selecting prompts and editing/deleting them as per Figma design
modals for adding and editing prompts

Thank you!


Dom nodes aren't safe for memoisation

I'm not sure if it's a project goal to be safe for memoisation and please do let me know if it isn't. However I was surprised to see that the vdom nodes could not be re-used.
On this ClojureScript + DomVM implementation of TodoMVC pure functions are used to create domvm nodes. I re-render the whole view each time any part of the application's data changes. To avoid re-running view functions with data they've seen before I store the results and on repeated calls return the old answer.
You can see this in action by clicking on the Active link at the bottom and then back to the All page. Uncaught TypeError: Cannot read property 'previousSibling' of null is thrown.

You're correct. The only way to literally re-use the old vtree rather than regenerating and diffing against the old one is to return vm.node from a view's render(). This serves as an indicator of 0 changes and will short circuit any additional dom reconciliation (and hooks).
whether it's possible to add this guarantee to domvm is an interesting question, but it's not a trivial task since a vast part of the codebase assumes that vnodes are regenerated and immutable after creation. there are hooks that can set temporary transitional state on old vnodes for CSS animations, etc.
i'm inclined to say that this is not a worthwhile endeavor. the available optimizations in domvm at the view & node level are quite sufficient - it doesn't get much faster than domvm [1].

to avoid re-running view functions with data they've seen before I store the results and on repeated calls return the old answer.

this is extremely cheap, and in fact memoization can lead to GC sadness since all vnodes are linked to their parents and children. once you start retaining them, they start leaking rather than being discarded.
@lawrence-dol used to memoise & reuse domvm vtrees heavily in his app prior to v2 and discovered that much of the rendering slowness was actually a result of this practice. [2].
if you're interested in doing various optimization paths, you can ask until their docs are ready (see #156). domvm v3 does actually have a feature called lazyList which does reuse old vnodes from a uniform list, but it's a declarative type setup that would not work for doing your own old vnode returns. you can see how it's used in the bench [3] to reduce RAM useage, but it did nothing to boost the bench speed [4].
i should actually port @yosbelms's domvm v1 TodoMVC demo [5] to domvm v3.
[1] https://rawgit.com/krausest/js-framework-benchmark/master/webdriver-ts-results/table.html
[2] https://github.com/leeoniya/domvm/issues/116#issuecomment-284870240
[3] https://github.com/krausest/js-framework-benchmark/blob/master/domvm-v3.0.1-keyed/src/main.es6.js#L92
[4] https://github.com/krausest/js-framework-benchmark/pull/203
[5] https://github.com/leeoniya/domvm/tree/1.x-dev/demos/TodoMVC

Thanks for the thorough reply. I think I'll accept that the memoisation was premature optimisation and stick with the (already blazing fast) straight forward approach.

FWIW, you would get a small speed boost by moving to v3 ;)
i just published v30.2. the needed changes from v2 - if any - are mostly mechanical (arg order, naming). the release log [1] might be helpful.
[1] https://github.com/leeoniya/domvm/releases


Add Web Monetization

Awesome Web Monetization repository
Web Monetization is becoming more and more used on the Internet. It would be interesting for people to turn to a new payment method for websites such as blogs, videos, newsletters or shared photos whether it is monetized according to the time spent reading/watching. And all this natively on your computer.

Checked PR's:
#1800
#1811
#1795
By submitting this pull request I confirm I've read and complied with the below requirements 🖖
Please read it multiple times. I spent a lot of time on these guidelines and most people miss a lot.
Requirements for your pull request

Don't waste my time. Do a good job, adhere to all the guidelines, and be responsive.
You have to review at least 2 other open pull requests.
Try to prioritize unreviewed PRs, but you can also add more comments to reviewed PRs. Go through the below list when reviewing. This requirement is meant to help make the Awesome project self-sustaining. Comment here which PRs you reviewed. You're expected to put a good effort into this and to be thorough. Look at previous PR reviews for inspiration.
You have read and understood the instructions for creating a list.
This pull request has a title in the format Add Name of List.

✅ Add Swift
✅ Add Software Architecture
❌ Update readme.md
❌ Add Awesome Swift
❌ Add swift
❌ Adding Swift
❌ Added Swift

Your entry here should include a short description about the project/theme of the list. It should not describe the list itself. The first character should be uppercase and the description should end in a dot. It should be an objective description and not a tagline or marketing blurb.

✅ - [iOS](…) - Mobile operating system for Apple phones and tablets.
✅ - [Framer](…) - Prototyping interactive UI designs.
❌ - [iOS](…) - Resources and tools for iOS development.
❌ - [Framer](…)
❌ - [Framer](…) - prototyping interactive UI designs

Your entry should be added at the bottom of the appropriate category.
The suggested Awesome list complies with the below requirements.

Requirements for your Awesome list

Has been around for at least 30 days.That means 30 days from either the first real commit or when it was open-sourced. Whatever is most recent.
Don't open a Draft / WIP pull request while you work on the guidelines. A pull request should be 100% ready and should adhere to all the guidelines when you open it.
Run awesome-lint on your list and fix the reported issues. If there are false-positives or things that cannot/shouldn't be fixed, please report it.
The default branch should be named main, not master.
Includes a succinct description of the project/theme at the top of the readme. (Example)

✅ Mobile operating system for Apple phones and tablets.
✅ Prototyping interactive UI designs.
❌ Resources and tools for iOS development.
❌ Awesome Framer packages and tools.

It's the result of hard work and the best I could possibly produce.
If you have not put in considerable effort into your list, your pull request will be immediately closed.
The repo name of your list should be in lowercase slug format: awesome-name-of-list.

✅ awesome-swift
✅ awesome-web-typography
❌ awesome-Swift
❌ AwesomeWebTypography

The heading title of your list should be in title case format: # Awesome Name of List.

✅ # Awesome Swift
✅ # Awesome Web Typography
❌ # awesome-swift
❌ # AwesomeSwift

Non-generated Markdown file in a GitHub repo.
The repo should have awesome-list & awesome as GitHub topics. I encourage you to add more relevant topics.
Not a duplicate. Please search for existing submissions.
Only has awesome items. Awesome lists are curations of the best, not everything.
Does not contain items that are unmaintained, has archived repo, deprecated, or missing docs. If you really need to include such items, they should be in a separate Markdown file.
Includes a project logo/illustration whenever possible.

Either centered, fullwidth, or placed at the top-right of the readme. (Example)
The image should link to the project website or any relevant website.
The image should be high-DPI. Set it to maximum half the width of the original image.

Entries have a description, unless the title is descriptive enough by itself. It rarely is though.
Includes the Awesome badge.

Should be placed on the right side of the readme heading.

Can be placed centered if the list has a centered graphics header.

Should link back to this list.

Has a Table of Contents section.

Should be named Contents, not Table of Contents.
Should be the first section in the list.
Should only have one level of nested lists, preferably none.

Has an appropriate license.

We strongly recommend the CC0 license, but any Creative Commons license will work.

Tip: You can quickly add it to your repo by going to this URL: https://github.com/<user>/<repo>/community/license/new?branch=master&template=cc0-1.0 (replace <user> and <repo> accordingly).

A code license like MIT, BSD, Apache, GPL, etc, is not acceptable. Neither are WTFPL and Unlicense.
Place a file named license or LICENSE in the repo root with the license text.
Do not add the license name or text to the readme. GitHub already shows the license name at the top of the repo.
To verify that you've read all the guidelines, please comment on your pull request with just the word unicorn.

Has contribution guidelines.

The file should be named contributing.md. Casing is up to you.

Has consistent formatting and proper spelling/grammar.

The link and description are separated by a dash. Example: - [AVA](…) - JavaScript test runner.
The description starts with an uppercase character and ends with a period.
Consistent and correct naming. For example, Node.js, not NodeJS or node.js.

Doesn't include a Travis badge.You can still use Travis for list linting, but the badge has no value in the readme.
Doesn't include an Inspired by awesome-foo or Inspired by the Awesome project kinda link at the top of the readme. The Awesome badge is enough.

Go to the top and read it again.

Oh and, unicorn ! :unicorn:

Linked to this issue https://github.com/thomasbnt/awesome-web-monetization/issues/4

Thanks for making an Awesome list! 🙌
It looks like you didn't read the guidelines closely enough. I noticed multiple things that are not followed. Try going through the list point for point to ensure you follow it. I spent a lot of time creating the guidelines so I wouldn't have to comment on common mistakes, and rather spend my time improving Awesome.

Requirements no. 4 indicates to rename/move the default branch from master to main.

The default branch should be named main, not master.

You can follow the steps here on how to rename this.

Ooops yeah I forgotten that on my repository

https://github.com/sindresorhus/awesome/commit/7acb34c61dbac2cbc47d8438eb57aa29d79bc650

@sindresorhus We ran the Awesome Linter, which passed... Is there anything that could be added there to make the issues we have here more clear? If yes (as I know you are very bussssssy), I don't mind doing the work to put 'm in...

@mhxion Thanks for the post to edit that. The default branch is main now!

7acb34c

Checked again the repositories, no errors for https://github.com/sindresorhus/awesome/pull/1800 and https://github.com/sindresorhus/awesome/pull/1795.
Why do you not add a GitHub Action with awesome-lint and require to news Awesome repositories to use that before Pr's here ?

@thomasbnt From the requirements:

Do not add the license name or text to the readme. GitHub already shows the license name at the top of the repo.

You need to remove the license section.

Cjecked

Your repository on Discord presentation is very cool ! Good job, and nice with badges !

@mhxion all is good ! Check with awesome lint for the repository. No more errors

@thomasbnt I did run awesome-lint, no error as well. I don't know why awesome-lint didn't validate that, based on the requirement instead of
- [svelte-monetization : A minimal and lightweight wrapper for the Web Monetization API](https://github.com/sorxrob/svelte-monetization) ![](assets/small_icons/svelte.png)

it needs to be
- [svelte-monetization](https://github.com/sorxrob/svelte-monetization) : A minimal and lightweight wrapper for the Web Monetization API ![](assets/small_icons/svelte.png)

I guess @sindresorhus can verify this issue here if this isn't a strict requirement at all.

The guidelines are the source of truth. The linter doesn't catch everything.

The guidelines are the source of truth. The linter doesn't catch everything.

Okay it's edited!
:octopus:  https://github.com/thomasbnt/awesome-web-monetization/commit/9a5611a6c191d398a6b5e1f546372089096830ca

There are still multiple things not follow from the guidelines. Please read through each item thoroughly.

I've got an error but..
readme.md:105:151   ✖  105:151  List item description must end with proper punctuation  remark-lint:awesome-list-item
there are that :
- [Monetization](https://github.com/KNawm/monetization) - A wrapper around the Web Monetization API to monetize apps. ![](assets/small_icons/dart.png)

Why the asset could block and display this error knowing that for other resources no error is present?

Includes a succinct description of the project/theme at the top of the readme. (Example)
✅ Mobile operating system for Apple phones and tablets.
✅ Prototyping interactive UI designs.
❌ Resources and tools for iOS development.
❌ Awesome Framer packages and tools.

Not done.
The following is not good enough:

Web Monetization is a web service that allows you to send money directly in your browser. — If you want you know more, see :

And the description should be above the "Contents" section.

Everything under the Resources section, could be top-level sections.

Don't include empty sections.

There's very little content in the list.

Bump

Hello ! All is good, but you say there is little content at the moment. I prefer not to relaunch for the moment. a few changes have been made, contributors have played the game.💪🏼

Tweet: https://twitter.com/awesome__re/status/1340349975943761920


Feature-detects using Modernizr

We currently have a bias towards features that manifest themselves as properties or methods of global JavaScript objects, which makes it easy to write feature detects (currently these are detect.js files in the polyfill directory).  But some things, particularly CSS features, can be hard to detect.
I'd be interested to know what the Modernizr team thinks we should do in these cases.  Can modernizr be integrated somehow?

I'm going to timeout this one.


Freshness Index MS Date Change

Freshness Index MS Date Change

Please ignore this PR.

Microsoft authors of articles need to make updates through the private repository, so the updates can be staged and validated by current validation rules. After you review staging and fix all validation issues, you can add the sign-off comment to let the PR reviewers know the updates are ready to be merged.
It's easy to access the private repo version of your articles in GitHub. Just add -pr to the URL, as follows:
 Public repo URL: https://github.com/MicrosoftDocs/{docs-repo}
 Private repo URL: https://github.com/MicrosoftDocs/{docs-repo-pr}
We have closed this pull request. Please resubmit the updates through the private repo. For more information, see the contributor guide.


Safari - Random hover state when in windows resize mode

Safari - Random hover state when in windows resize mode

@kvenkatrajan can you give more context

This no longer reproduces on Safari 17.3.1


disabling shared memory part of health

Because it was causing issues. Apparently locking needed to be done
(possibly?). As it was, we would get errors with concurrent requests,
although rarely.

Codecov Report

Merging #102 into master will decrease coverage by -0.16%.

@@            Coverage Diff             @@
##           master     #102      +/-   ##
==========================================
- Coverage     100%   99.84%   -0.16%
==========================================
  Files          72       71       -1
  Lines        1985     1936      -49
==========================================
- Hits         1985     1933      -52
- Misses          0        3       +3

Impacted Files
Coverage Δ

shelf/routes/artifact.py
97.84% <ø> (-2.16%)
:x:

shelf/configure.py
100% <ø> (ø)
:white_check_mark:

shelf/endpoint_decorators.py
100% <100%> (ø)
:white_check_mark:

shelf/app.py
96.96% <100%> (-3.04%)
:x:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bafee76...473fbf3. Read the comment docs.


Integrate grid snapping

Ensure we adjust by multiple of the grid only.

CI is failing for this one. You have to link the current master branch of bpmn-js (with linked diagram-js) to see stuff working.


file corrupted when downloding

Hi,
I just tried your plugin, which works nice on the "uploading": i.e when i upload the file its stored in the path y configured. I can see them physically in the folder.
However, i see 2 things that doesn't work as i expected:

cannot see the files in the strapi admin panel. they just dont apear graphically in the media library section of strapi admin
when i want to download the file, it seems not working corretly: i'm able to download it but when i open it raises me error of "corrupted"

i'm tried with strapi version 3.1.6 and 3.3.4
Thanks for your work!

I have the same problem on "@strapi/strapi": "4.24.1"


fix(material/datepicker): unable to pass in errorStateMatcher through binding on range input

Fixes that the errorStateMatcher on the date range inputs wasn't marked as an Input which made it impossible to change.
Fixes #21205.

Any news on this?

Any news on this?


Issue with px4_sitl gazebo_solo

We use GitHub issues only to discuss PX4 bugs and new features. For
questions about using PX4 or related components, please use PX4 Discuss.
Thanks!
Good day, I'm new to PX4 and Gazebo. I have searched through posts but did not manage to find anything related to my error. I have tried to reclone Firmware to no avail.
Any help will be appreciated. I am trying to run: make px4_sitl gazebo_solo
It seems like the opticalflow_plugin and the geotagged_images_plugin objects are causing the build to fail.
Thank you.
[690/700] Performing build step for 'sitl_gazebo'
[65/92] Building CXX object CMakeFiles/gaze...gin.dir/src/gazebo_opticalflow_plugin.cpp.o
FAILED: CMakeFiles/gazebo_opticalflow_plugin.dir/src/gazebo_opticalflow_plugin.cpp.o
/usr/bin/c++  -DLIBBULLET_VERSION=2.87 -DLIBBULLET_VERSION_GT_282 -Dgazebo_opticalflow_plugin_EXPORTS -I/home/ninja/Firmware/Tools/sitl_gazebo/include -I. -I/usr/include/eigen3 -I/usr/include/eigen3/eigen3 -I/usr/include/gazebo-9/gazebo/msgs -I/home/ninja/Firmware/mavlink/include -I/home/ninja/Firmware/Tools/sitl_gazebo/external/OpticalFlow/include -I/usr/include/gstreamer-1.0 -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/home/ninja/Firmware/Tools/sitl_gazebo/external/OpticalFlow/external/klt_feature_tracker/include -isystem /usr/include/gazebo-9 -isystem /usr/include/bullet -isystem /usr/include/simbody -isystem /usr/include/sdformat-6.2 -isystem /usr/include/ignition/math4 -isystem /usr/include/OGRE -isystem /usr/include/OGRE/Terrain -isystem /usr/include/OGRE/Paging -isystem /usr/include/ignition/transport4 -isystem /usr/include/ignition/msgs1 -isystem /usr/include/ignition/common1 -isystem /usr/include/ignition/fuel_tools1 -isystem /usr/include/x86_64-linux-gnu/qt5 -isystem /usr/include/x86_64-linux-gnu/qt5/QtCore -isystem /usr/lib/x86_64-linux-gnu/qt5/mkspecs/linux-g++ -isystem /usr/include/opencv -isystem /usr/include/uuid -isystem /usr/include/x86_64-linux-gnu -Wno-deprecated-declarations -fPIC   -I/usr/include/uuid -I/usr/include/x86_64-linux-gnu -std=gnu++1z -MD -MT CMakeFiles/gazebo_opticalflow_plugin.dir/src/gazebo_opticalflow_plugin.cpp.o -MF CMakeFiles/gazebo_opticalflow_plugin.dir/src/gazebo_opticalflow_plugin.cpp.o.d -o CMakeFiles/gazebo_opticalflow_plugin.dir/src/gazebo_opticalflow_plugin.cpp.o -c /home/ninja/Firmware/Tools/sitl_gazebo/src/gazebo_opticalflow_plugin.cpp
In file included from /home/ninja/Firmware/Tools/sitl_gazebo/src/gazebo_opticalflow_plugin.cpp:24:0:
/home/ninja/Firmware/Tools/sitl_gazebo/src/gazebo_opticalflow_plugin.cpp: In member function ‘virtual void gazebo::OpticalFlowPlugin::Load(gazebo::sensors::SensorPtr, sdf::ElementPtr)’:
/home/ninja/Firmware/Tools/sitl_gazebo/include/gazebo_opticalflow_plugin.h:43:18: error: ‘TRUE’ was not declared in this scope
#define HAS_GYRO TRUE
^
/home/ninja/Firmware/Tools/sitl_gazebo/include/gazebo_opticalflow_plugin.h:43:18: note: in definition of macro ‘HAS_GYRO’
#define HAS_GYRO TRUE
^~~~
[67/92] Generating /home/ninja/Firmware/Too...zebo/models/3DR_gps_mag/3DR_gps_mag-gen.sdf
/home/ninja/Firmware/Tools/sitl_gazebo/models/3DR_gps_mag/3DR_gps_mag.sdf.jinja -> /home/ninja/Firmware/Tools/sitl_gazebo/models/3DR_gps_mag/3DR_gps_mag-gen.sdf
[70/92] Building CXX object CMakeFiles/gaze...ir/src/gazebo_geotagged_images_plugin.cpp.o
ninja: build stopped: subcommand failed.
[696/700] Linking CXX executable bin/px4
FAILED: external/Stamp/sitl_gazebo/sitl_gazebo-build
cd /home/ninja/Firmware/build/px4_sitl_default/build_gazebo && /opt/cmake-3.13.3-Linux-x86_64/bin/cmake --build .
ninja: build stopped: subcommand failed.
Makefile:200: recipe for target 'px4_sitl' failed
make: *** [px4_sitl] Error 1

Duplicate of https://github.com/PX4/Firmware/issues/14103.


Please consider remove Jackson from ktor-openapi-generator

Hi Lukas,
Can you consider removing Jackson from your library? (Jackson is currently used in testing in the library)
https://github.com/LukasForst/ktor-openapi-generator
I think converting map to JSON in the library can be done manually like this.
https://github.com/Kotlin/kotlinx.serialization/issues/296#issuecomment-1132714147.
Removing helps users choose multiple option alternatives to Jackson.
I am trying to use io.ktor:ktor-serialization-kotlinx-json instead of Jackson but the ktor-openapi-generator did not work with io.ktor:ktor-serialization-kotlinx-json.

Hi,
please see https://github.com/papsign/Ktor-OpenAPI-Generator/issues/42 for kotlinx.serialization support. I'm not using kotlinx, so I can't directly say how hard is that or not. However, I'm open to PRs that would make this project more generic!


Features of datasets

Hi dear authors,
I have noticed that the processed file contains node features and edge features for all datasets. As far as I know, the original ENRON/UCI/social-evolution datasets do not contain any node/edge features. I have checked your paper, but the paper doesn't mention any details for initializing node or edge features. Can you describe the details of initializing node or edge features in these .npy files? Thanks!

I guess we initialize them as constant features to guarantee the model is inductive.

I guess we initialize them as constant features to guarantee the model is inductive.

How to initialize features of three datasets? randomly initialize?

We used "constant" features as initial features. We have tried random initialization, which typically gives better transductive learning performance, worse inductive learning performance and the model converges slow.

We used "constant" features as initial features. We have tried random initialization, which typically gives better transductive learning performance, worse inductive learning performance and the model converges slow.

Thanks for your reply. You would better mention this in your paper.

One thing should be emphasized that. Our method does not need node features at all as we may capture the structural dynamics.


Fix wrong output in README.md

url doesn't include query parameters.

Nice catch!
I think we can remove this example, it doesn't bring much value.

@teamon Removed the line instead of fixing as you said.


Level-triggered GPIO interrupts are firing multiple times

The above is a photo of the following issue:
I have a sensor (ADS1291 in this case), that has a low-active data ready line, and provides 48 bits of data as a response to a read command over SPI.
I also have a read task similar to this:
loop {
    drdy.wait_for_low().await;
    let sample = sensor.read().await;
    handle(sample);
}

It looks like the GPIO interrupt handler is fired multiple times mistakenly. I expected the following order of events:

wait_for_low registers an interrupt handler and suspends the task
data ready goes low, interrupt happens
interrupt handler is disabled during interrupt handling
sensor read happens, which causes data ready to go high
next iteration, wait_for_low registers an interrupt handler and starts the waiting game

The issue I'm experiencing here is that the second wait_for_low immediately returns, as I hope the photo makes clear.

My suspicion is that the order of operations in the GPIO interrupt handler is incorrect. The driver clears the interrupt status before disabling interrupts, so the hardware seems to re-trigger the interrupt request between clearing and disable. This causes a "misfire" immediately when the interrupt is re-enabled in the next wait_for_low.
This is just speculation though that seems to fit my data.

Could you try out https://github.com/esp-rs/esp-hal/pull/537?


Bump snappy-java to latest version

https://github.com/xerial/snappy-java/releases/tag/<IP_ADDRESS>

Hi @slipset and @KingMob,
Could you please release a new version containing this change?
Many thanks!

Thanks a lot @KingMob !


Remove descending copy from end

Uint8Array.prototype.set handles overlapping ranges on its own.

Released as 5.7.0.


Where is the CompositionGenerator function?

I am curious where is the CompositionGenerator function in your code, it seems to be an important part in your active learning method. It shows you imported it from matal.ml. However, I didn't find this function at all.

Apologies for the oversight! It seems the newest version never got committed. I have now uploaded the code. Please let me know if there are any other issues. Thanks!

Apologies for the oversight! It seems the newest version never got committed. I have now uploaded the code. Please let me know if there are any other issues. Thanks!

Hello Dr. Chen. I would like to learn the code in your project for a fee. Can you teach me ？This is my email address<EMAIL_ADDRESS>I look forward to your contact


media-capture: set Baseline status

We probably need a note field now, to explain why this will (never?) be non-Baseline.

media-capture is an interesting feature: it's implemented in, and arguably more targeted at, mobile browsers, and using the HTML capture attribute on desktop should not break anything (using the IDL attribute may though, since it's going to be undefined).
In a way, html.elements.input.capture could be seen as having a high baseline status. I don't suggest doing that. That just seems like a good candidate feature for statuses beyond baseline that might be worth calling out to developers: you can use the attribute everywhere, just be aware that it won't do anything on some platforms.

Originally posted by @tidoust in https://github.com/web-platform-dx/web-features/issues/461#issuecomment-1839195349

@ddbeck can you add in the notes you think we should have here? We can just add it to the schema, and a notes field which is either a string or an array of strings (like BCD) seems sensible to me.

https://github.com/web-platform-dx/web-features/pull/825 will take care of this.


Invalid header: 0xFF 0xFB

Hello!
I cant get it working by rs485.
Type: JK-B1A20S15P
Logs: https://hastebin.com/share/ugogajeqot.ruby
Anyone can help? (esp8266, lolin)

It looks like a grounding issue? Did you attach GND properly?

Seems to happen with new ESPhome release ....

If you have the chance please try a ESP32 instead. I guess this platform isn't affected.

Let's close this issue. Hopefully it's resolved.


Update issue templates

Pull Request Test Coverage Report for Build 07b61eaf-8e00-4e8b-bee4-998715236d9c

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 97.552%

Totals

Change from base Build 0366967e-7d6a-49cf-bceb-5fcddbf26172:
0.0%

Covered Lines:
1674

Relevant Lines:
1716

💛  - Coveralls


bug: Site preview doesn't work for multi-page deployments

#70 added a second page, which we can't navigate to in the review

Preview deploy needs to set the variable HUGO_BASEURL for the hugo site build.


[Feature]: Addition of more algorithms under String Algorithms

Feature Name
Addition of complex String Algorithms
Feature Description
Addition of following complex String Algorithms:
1)Karp-Miller-Rosenberg Algorithm
2)Wu-Manber Algorithm
3)Baeza-Yates-Gonnet Algorithm
Motivation
Newer algorithms tend to increase the knowledge of learners
Implementation Suggestions (Optional)
No response
Feature Type
New Algorithm
Does this feature require additional resources?

[X] Additional Documentation
[ ] Third-Party Libraries
[ ] UI/UX Design
[ ] Other

References (Optional)
No response

@ajay-dhangar Kindly assign this issue  to me ASAP . I will start working on it . Also , review my last sent PR as well . Thanks :)


feat: flagd file polling for offline mode

This PR
Enhance flagd in-process offline mode introduced through https://github.com/open-feature/java-sdk-contrib/pull/473 by adding polling support and align with the change proposed at flagd js-sdk (https://github.com/open-feature/js-sdk-contrib/pull/708)
Polling happens at intervals of 5 seconds and runs concurrently. If an update is observed, connect offers the newest content to the storage through the connector contract.
Note on polling
The reason to use polling is the known limitation of Java WatchService when it comes to non-local file systems. This blog post ^1 extensively describes the problem. Besides, the offline mode is intended for limited use cases such as testing, local development efforts or POC deployments where the impact of polling is minimal.

Approving with this question. I will let you consider it and decide if you think it's something we should worry about in this PR.

Thanks for the review. Regarding the concurrency concern, I will address it in a dedicated PR. As described here only possibility for concurrent issues is if the same provider get registered multiple times (which is allowed in spec). And I think we need to check this edge case in other lang. implementations as well.


CLOUD-45782 storing images in versioned component table

@keyki, please check, only the first part of the CLOUD-45782  has been finished and we are storing only the images + userdata in the DB.
Next step: store data for docker containers

Jenkins build finished, all tests passed.
Refer to this link for build results: http://ci.sequenceiq.com/job/cloudbreak-pull-request/1726/


[Feature Request]:  All Conectors/All Integrations

Feature Description
Hello I am a Data Science enthusiast and I am in the process of learning more about on RAG and Llama conectors. I would like to have access to all integrations so I can practice and understand more their usage
Reason
No response
Value of Feature
No response

I'm not sure i understand? Anyone can install any integration
You can see all integrations at https://llamahub.ai
You can see all the source code for integration in this repo


Use Travis container infrastructure

Builds start sooner and run faster. Open source builds on the container
infrastructure also get to use the bundle cache. See:
http://blog.travis-ci.com/2014-12-17-faster-builds-with-container-based-infrastructure/
This has worked extremely well on all projects I've tried it on thus far.

Awesome, thanks. Can the cache: bundler be removed? Not sure if the container itself acts as a caching mechanism.

No, those are independent. For instance, I enabled container infrastructure on this repo but did not enable bundle caching because this is a gem and that seems akin to checking in Gemfile.lock.

Looks like it took about 45% off the test runs for suspenders.

Looks good.

On Jan 7, 2015, at 12:22 PM, Derek Prior<EMAIL_ADDRESS>wrote:
No, those are independent. For instance, I enabled container infrastructure on this repo but did not enable bundle caching because this is a gem and that seems akin to checking in Gemfile.lock.
—
Reply to this email directly or view it on GitHub.


Wrong type of variable

When trying to mark site as up this issue comes up.
Argument 1 passed to Spatie\OhDearUptimeTile\OhDearUptimeStore::Spatie\OhDearUptimeTile\{closure}() must be of the type array, string given
changing this line
https://github.com/spatie/laravel-dashboard-oh-dear-uptime-tile/blob/master/src/OhDearUptimeStore.php#L38
to
$downSites = array_filter($downSites, fn ($downSite) => $downSite !== $upSiteUrl);
solves the issue.

Thanks for brining this to my attention. It is now fixed in the latest release.


Replace forge-sha256 with WebCryptoAPI

The WebCryptoAPI is also able to do SHA256. So we might use this instead of the forge-sha256 include.
Maybe combine this job with work for enhancement #1.

Done for new V2 version in master branch.


Update Composer dependencies (2021-11-12-00-06)

Visual regression test passed!
View the visual regression test report


fix(gen): properly handle intermediate route node

Fixes #1249

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 73.82%. Comparing base (1c28226) to head (09f3df3).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1251   +/-   ##
=======================================
  Coverage   73.82%   73.82%
=======================================
  Files         189      189
  Lines       12809    12809
=======================================
  Hits         9456     9456
  Misses       2808     2808
  Partials      545      545

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Clean up FQDN cache before test scenarios that use DNS proxy

FQDN entries created in one scenario are currently sticking around in the cache. This means that subsequent scenarios don't start with a clean slate, and failing tests can pass depending on the set of tests being executed. This commit fixes the problem by adding a per-scenario setup callback to test harness and using it to clean FQDN cache on agents before every scenario that uses DNS proxy.

Closing this as per my comment up thread.


[UX][Autocomplete] - QueryBuilder doesn't return results but dd(...) return

Hi all,
I have a problem with the autocomplete field (AJAX).
I'm writing this issue cause I haven't found anything similar in existing issues (open and closed).
Presently, I have this query_builder in the definition of my autocomplete field :
<?php

// ...

'query_builder' => function (ArticleRepository $articleRepository) {
    $query = $articleRepository->createQueryBuilder('article')
        ->join('article.product', 'product')
        ->...
    ;

    return $query;
},

// ...

When I put some text in my Autocomplete Select, I didn't have any result :
{
      "results": [ ],
      "next_page": null
}

But if I didn't return the $query variable and put a dump and die of $query->getQuery()->getResult(), my DQL request gives me a result.
So I don't understand what the differences are that can cause this.
I don't do anything else in the form that calls this Autocomplete Field.
Thank's in advance for your help

@WebMamba Thanks for your answer, but the result is still the same. It returns nothing in the autocomplete, but when I use $query->getQuery()->getResult(), I get the result I want.

Hum, so we have a typo in the doc?
It should be ?
'query_builder' => function (Options $options) {
                return function (EntityRepository $er) use ($options) {
                    $qb = $er->createQueryBuilder('o');

                    $excludedFoods = $options['extra_options']['excluded_foods'] ?? [];
                    if ([] !== $excludedFoods) {
                        $qb->andWhere($qb->expr()->notIn('o.id', $excludedFoods));
                    }

                    return $qb->getQuery()->getResult();
                };
            }


Improve api server address create performance

This change improves api server address create performance by almost an order of magnitude when 1000 addresses are defined.
The changes moves the validation of spec.address to standard-controller for the standard address space. For the brokered address space, the validation remains in the api-server, as it would require adding write-back capability to the agent. Future refactoring/consolidation of agent/standard-controller should incorporate this validation.
Fixes #3111

@enmasse-ci run tests


Create a simple giter8 template

Problem:

People want to say sbt new raquo/laminar.g8 to get a clean new laminar project.

Scope:

Probably a frontend-only setup, with build.sbt and vite dev server.
No waypoint, no backend, no existing components except for easy-to-override hello world.

Implementation:

Set up a new repo similar to https://github.com/scala/scala3.g8
Link to it in quick start, laminar demo, docs, and the resources page
This repo will need to be maintained separately from the full stack demo

MVP Done: https://github.com/raquo/scalajs.g8


smarter domain concatenation and broadcast

At the moment, the DomainConcatentation class will convert any Scalar children to vectors. This should be generalised, so that if the evaluate of its children return a scalar, this is appropriately mapped to a vector at run-time (i.e. for time dependent functions)

This issue should:

unskip the test from #149
remove the warning from #124
implement #155
test that concatenation of 2D matrices works as expected, not just 1D vectors (e.g. the matrix representing c as a function of space and time)

discussed this in meeting, see result here: https://github.com/tinosulzer/PyBaMM/pull/163#issuecomment-468256714


error if component is not required

Say you do this:
React.render(React.create_element(MyFatComponent), Element['div.navigation'])
and you forget to require 'my_fat_component'  Nothing happens, and there are no errors or warnings.
Instead the create_element binding (and similar) should make sure the constant does exist and responds to render.

This issue was moved to reactrb/reactrb#30


Train problem

When I trained  my own dataset,I find the test result of all my object have negative confidence score and cannot identify the extreme point on the left very well. Have you ever had a similar problem on your side, or did you know what might have caused it.
Demo result

The link is invalid. There should not be confidence scores. Can you specify where you inject your visualization code?

I just run the demo.py to visualization results. I set the threshold is very small.
You can copy the link to browser to see the picture.


✨ Improve status controller using existing assets

Summary
This PR uses some existing data structures and logic in (also adds some to) the binding controller, to help the status controller handle singleton statuses.
Now status controller
- doesn’t have functionally duplicated code;
- doesn't have to read the managed-by.kubestellar.io/singletonstatus label when reconciling singleton statuses.
Related issue(s)
Fixes #

Where is it documented how/why this removes the status section of a workload object in the WDS after a Binding is changed from referencing that object and requesting singleton reported state return to not referencing that object?

Not sure I'm following the question. I think the code is quite self-explanatory on why the status section is removed, no? Are you suggesting that some more comments should be written?

The reason that I asked about documentation of how/why this controller removes the status section of a workload object in the WDS after a Binding is changed from referencing that object and requesting singleton reported state return to not referencing that object is that I do not remember the answer or where it is documented --- and I think that it should not be hard to find documented. For the binding controller there is a fairly detailed explanation of how it works.
What I see in the status controller is a func (c *Controller) reconcileSingletonByBdg that reacts to things that are said in the given Binding but not to things that are absent from (e.g., recently removed from) that Binding. So I wondered what removes the status from the workload object in the WDS in this case.
The answer may be that the WorkStatus object will be removed and that will cause func (c *Controller) reconcileSingletonByWS to be called to handle it. But I think that is not necessarily true. What if there are two Bindings that bind the same workload object to the same WEC, one Binding requesting singleton reported state return and one not requesting it. If the first of those two is modified to no longer reference the workload object, the second Binding will cause the WorkStatus to continue to exist. This gets into the issue of behavior in a situation that we currently tell users to avoid, because we do not have a documented agreement on the proper behavior in this case. So I am not going to insist on a change in this PR.


There is some problem in SkyWalking 6.0  with elasticsearch-5.6.8

Please answer these questions before submitting your issue.

Why do you submit this issue?
[x] Question or discussion
[x] Bug
[ ] Requirement
[ ] Feature or performance improvement

Question

I know sw6.0 's default DataBase is H2 .
sw6.0  works well with H2 ,but when I change H2 to ES  .
There is some problem come out.

Deploy step:
1.clean es db 5.6.8 's data and start it      (skywalking 5.0 run with it  OK)
2.open sky-walking‘s configration about es-db and close H2‘s configration
3.click startup.bat
4. start my service and inject to sw ,then I called my service's HTTP-interface
5.open sw-web and I saw some [Red ERROR]  at top right corner
ERROR:
【Dashboard  page】:  and this page can't show any data
Exception while fetching data (/getTopNSlowEndpoint) : Elasticsearch exception [type=search_phase_execution_exception, reason=all shards failed]
Exception while fetching data (/getTopNServiceThroughput) : Elasticsearch exception [type=search_phase_execution_exception, reason=all shards failed]
【Service page】: and this page can't show any data
Exception while fetching data (/getSlowEndpoint) : Elasticsearch exception [type=search_phase_execution_exception, reason=all shards failed]
Exception while fetching data (/getServiceInstanceThroughput) : Elasticsearch exception [type=search_phase_execution_exception, reason=all shards failed]
Exception while fetching data (/getServiceTopology) : Elasticsearch exception [type=search_phase_execution_exception, reason=all shards failed]
And I saw some info in 【skywalking-oap-server.log】
one of debug :
-----start------
Caused by: org.elasticsearch.client.ResponseException: method [POST], host [http://localhost:9200], URI [/service_relation_client_side/type/_search?typed_keys=true&ignore_unavailable=false&expand_wildcards=open&allow_no_indices=true&search_type=query_then_fetch&batched_reduce_size=512], status line [HTTP/1.1 500 Internal Server Error]
{"error":{"root_cause":[{"type":"aggregation_execution_exception","reason":"Invalid term-aggregator order path [_key]. Unknown aggregation [_key]"}],"type":"search_phase_execution_exception","reason":"all shards failed","phase":"query","grouped":true,"failed_shards":[{"shard":0,"index":"service_relation_client_side","node":"YCskJjy9SCGioeF_KGqQcg","reason":{"type":"aggregation_execution_exception","reason":"Invalid term-aggregator order path [_key]. Unknown aggregation [_key]"}}]},"status":500}
-----end------
and I called The url
localhost:9200/service_relation_client_side/type/_search?typed_keys=true&ignore_unavailable=false&expand_wildcards=open&allow_no_indices=true&search_type=query_then_fetch&batched_reduce_size=512
And response is  empty data
{
"took": 1,
"timed_out": false,
"_shards": {
"total": 2,
"successful": 2,
"skipped": 0,
"failed": 0
},
"hits": {
"total": 0,
"max_score": null,
"hits": []
}
}

Bug
I thought there are some bugs
because :
Page 【Trace】 can saw all my traces .
Page 【End Point】 can saw all my data such as cpm / sla / avg Response Time    and     They are all right.
But Page 【dashboard \Topology \Service】 throws some error
I thought it is  a  query bug about ES db

Thanks for your reading

My Partner  told me just now  ：  SW 6.0 use ES 6


Add an introduction to AboutUs, README, and site-wide settings

Update portions of the above documentation for the first iteration.

Codecov Report

Merging #21 (2e3c4eb) into master (fbe474c) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #21   +/-   ##
=========================================
  Coverage     72.15%   72.15%
  Complexity      399      399
=========================================
  Files            70       70
  Lines          1232     1232
  Branches        125      125
=========================================
  Hits            889      889
  Misses          311      311
  Partials         32       32

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fbe474c...2e3c4eb. Read the comment docs.


Unquantized models don't load for bge-m3

System Info
NextJS client side
Environment/Platform

[ ] Website/web-app
[ ] Browser extension
[ ] Server-side (e.g., Node.js, Deno, Bun)
[ ] Desktop app (e.g., Electron)
[ ] Other (e.g., VSCode extension)

Description
I get an error when trying to load the unquantized version but the quantized version works just fine. Apologies in advance if this is a feature request rather than a bug.
Trace:
ort-wasm-simd.wasm:0x82c2bc D:/a/_work/1/s/onnxruntime/core/optimizer/initializer.cc:31 onnxruntime::Initializer::Initializer(const onnx::TensorProto &, const Path &) !model_path.IsEmpty() was false. model_path must not be empty. Ensure that a path is provided when the model is created or loaded.
lt @ ort-web.min.js:7
P @ ort-web.min.js:7
$func11504 @ ort-wasm-simd.wasm:0x82c2bc
$func2149 @ ort-wasm-simd.wasm:0x16396e
$func584 @ ort-wasm-simd.wasm:0x48a63
$func11428 @ ort-wasm-simd.wasm:0x8296b1
$func631 @ ort-wasm-simd.wasm:0x4d0e8
v @ ort-web.min.js:7
$func92 @ ort-wasm-simd.wasm:0xb052
o @ ort-web.min.js:7
$func339 @ ort-wasm-simd.wasm:0x28ce8
$Ra @ ort-wasm-simd.wasm:0x6ebffb
e._OrtCreateSession @ ort-web.min.js:7
e.createSessionFinalize @ ort-web.min.js:7
e.createSession @ ort-web.min.js:7
e.createSession @ ort-web.min.js:7
loadModel @ ort-web.min.js:7
await in loadModel (async)
createSessionHandler @ ort-web.min.js:7
create @ inference-session-impl.js:176
await in create (async)
constructSession @ models.js:418
await in constructSession (async)
from_pretrained @ models.js:1087
from_pretrained @ models.js:5492
await in from_pretrained (async)
loadItems @ pipelines.js:3099
pipeline @ pipelines.js:3047
getInstance @ worker.js:22
eval @ worker.js:32
Show 16 more frames
Show less
ort-wasm-simd.wasm:0x82c2bc
lt @ ort-web.min.js:7
P @ ort-web.min.js:7
$func11504 @ ort-wasm-simd.wasm:0x82c2bc
$func2149 @ ort-wasm-simd.wasm:0x16396e
$func584 @ ort-wasm-simd.wasm:0x48a63
$func11427 @ ort-wasm-simd.wasm:0x829582
$func4164 @ ort-wasm-simd.wasm:0x339b6f
$func4160 @ ort-wasm-simd.wasm:0x339aff
j @ ort-web.min.js:7
$func356 @ ort-wasm-simd.wasm:0x2e215
j @ ort-web.min.js:7
$func339 @ ort-wasm-simd.wasm:0x28e06
$Ra @ ort-wasm-simd.wasm:0x6ebffb
e._OrtCreateSession @ ort-web.min.js:7
e.createSessionFinalize @ ort-web.min.js:7
e.createSession @ ort-web.min.js:7
e.createSession @ ort-web.min.js:7
loadModel @ ort-web.min.js:7
await in loadModel (async)
createSessionHandler @ ort-web.min.js:7
create @ inference-session-impl.js:176
await in create (async)
constructSession @ models.js:418
await in constructSession (async)
from_pretrained @ models.js:1087
from_pretrained @ models.js:5492
await in from_pretrained (async)
loadItems @ pipelines.js:3099
pipeline @ pipelines.js:3047
getInstance @ worker.js:22
eval @ worker.js:32
Show 16 more frames
Show less
2ort-web.min.js:7 Uncaught (in promise) Error: Can't create a session
    at e.createSessionFinalize (webpack-internal:///(app-pages-browser)/./node_modules/onnxruntime-web/dist/ort-web.min.js:7:450870)
    at e.createSession (webpack-internal:///(app-pages-browser)/./node_modules/onnxruntime-web/dist/ort-web.min.js:7:451468)
    at e.createSession (webpack-internal:///(app-pages-browser)/./node_modules/onnxruntime-web/dist/ort-web.min.js:7:443694)
    at e.OnnxruntimeWebAssemblySessionHandler.loadModel (webpack-internal:///(app-pages-browser)/./node_modules/onnxruntime-web/dist/ort-web.min.js:7:446588)
    at async Object.createSessionHandler (webpack-internal:///(app-pages-browser)/./node_modules/onnxruntime-web/dist/ort-web.min.js:7:156416)
    at async InferenceSession.create (webpack-internal:///(app-pages-browser)/./node_modules/onnxruntime-common/dist/lib/inference-session-impl.js:176:25)
    at async constructSession (webpack-internal:///(app-pages-browser)/./node_modules/@xenova/transformers/src/models.js:418:16)
    at async Promise.all (index 1)
    at async XLMRobertaModel.from_pretrained (webpack-internal:///(app-pages-browser)/./node_modules/@xenova/transformers/src/models.js:1085:20)
    at async AutoModel.from_pretrained (webpack-internal:///(app-pages-browser)/./node_modules/@xenova/transformers/src/models.js:5492:20)

Reproduction
import { env, pipeline } from '@xenova/transformers';

// Specify a custom location for models in public folder
// env.localModelPath = "/models";

// // Disable the loading of remote models from the Hugging Face Hub:
env.allowRemoteModels = true;
// env.allowLocalModels = true;
// env.useBrowserCache = false;

// Use the Singleton pattern to enable lazy construction of the pipeline.
// model should be directory in public/models (and in this case onnx folder is hardcoded)
class PipelineSingleton {
    static task = 'feature-extraction';
    static model = 'Xenova/bge-m3';
    static instance = null;

    static async getInstance(progress_callback = null) {
        if (this.instance === null) {
            console.log(this.model);
            this.instance = pipeline(this.task, this.model, { progress_callback, quantized:false }, );
        }
        return this.instance;
    }
}

// Listen for messages from the main thread
self.addEventListener('message', async (event) => {
    // Retrieve the feature-extraction pipeline. When called for the first time,
    // this will load the pipeline and save it for future use.
    let embedder = await PipelineSingleton.getInstance(x => {
        // We also add a progress callback to the pipeline so that we can
        // track model loading.
        self.postMessage(x);
    });

    // Actually perform the feature-extraction
    let output = await embedder(event.data.text, { pooling: 'avg', normalize: true });
    // console.log(output.tolist()[0].length);

    // Send the output back to the main thread
    self.postMessage({
        status: 'complete',
        output: output.tolist(),
    });
});

Duplicate of https://github.com/xenova/transformers.js/issues/553.
This is because the current version of transformers.js does not yet support the external data format. See https://github.com/xenova/transformers.js/issues/105. This will be fixed when we upgrade to onnxruntime-web v1.17.0 (https://github.com/xenova/transformers.js/pull/596)

Ah I don't even think I realized what that file was for. Makes sense. Thanks!
While I have you, I know it's unrelated but when I ran the quantized model on GPU via python it was quite a bit slower since there were still operations on CPU. So is there anyway to get the best of both worlds and run the quantized version on GPU via Python performantly and then use transformers.js for embedding just the queries? Maybe triton?
Apologies in advance if unrelated and better suited for a discussion/forum


Add Candidates

To split up into smaller increments. Close this issue if you are splitting up the feature into smaller increments and create a new one

Add status (pending, hired, fired,..), job title,


parse error: failed at `if @content

I tried something like this, but it would not work:
@mixin foo($bar) {
color: $bar;
@if @content {
@content
}
}
.class1 {
@include foo(#fff);
}
.class2 {
@include foo(#fff) {
display: block; margin-top: 10px
};
}

Hi, I don't really get what you are trying to do with this code
@if @content {
@content
}
Are you trying to add a @content directive if any other content should be present with an @if?
If that should be the case, then @content does it all without @if like this:
@mixin foo($color) {
  color: $color;
  @content;
}

see the results here:
https://gist.github.com/exigon/ae642d7360ce64991a87b334b3321efc

That's not valid scss input.  Please test for yourself on sassmeister.com.
Invalid CSS after "@if ": expected expression (e.g. 1px, bold), was "@content {"


Cluster Connector

I believe this has been discussed somewhere, but I'm just putting it here for reference. I would request a feature where we can replace the native deep stream cluster stuff (distributed state, locks etc...) with  a connector which wraps e.g. etcd or consul.

Work in progress API https://gist.github.com/ronag/383fbec9b79da35bce2f659b57050cdc
Which is needed for our listener rewrite at https://github.com/nxtedition/deepstream.io/blob/listener/src/listen/listener-registry.js

https://github.com/deepstreamIO/deepstream.io/pull/588

Closing this due to 3.0 cluster change


Only use django jQuery

The bindfields.js seems to fail to receive the formset:added event, probably because those events are triggered using the django.jQuery.
https://docs.djangoproject.com/en/1.11/ref/contrib/admin/javascript/#inline-form-events

Coverage remained the same at 89.809% when pulling fa739507f1635f34bc5dc60f308f2b8c5b8dd23c on leibowitz:fix_jquery into ca55e0bc8ad378dc7a3d1bb5e68e18e8fc51c546 on digi604:master.

I just realised this is working as well simply by adding USE_DJANGO_JQUERY = True to the settings.

@leibowitz I can imagine the setting is there because at times you would need a different jQuery version.
Can we close this PR?

Even if that breaks anything that relies on the formset:added and formset:removed events? I'm not sure it's a good idea to allow to customise the jQuery version, if that will lead to other issues. Or am I missing something?

I agree. This can be a source of problems. If we apply your PR though, it also needs to contain removal of the two options that allow jQuery version customisation: USE_DJANGO_JQUERY and JQUERY_URL . And the documentation should state that these options have been removed since version x.y.z.
Could you please add that to the PR?

Sure, going to create a new PR as this is quite different
https://github.com/jazzband/django-smart-selects/pull/301
Regarding this,

And the documentation should state that these options have been removed since version x.y.z.

It should appear in the changelog, but there's none. Time to create one?


Feature Idea: PAReview.sh as installed extra

Issue Type
Feature Idea
Summary
Support PAReview.sh as optional extra because the Drupal project application checklist recommends it as a way to check coding standards and style. And it's better to be able to check those things before pushing Drupal code to a repo.

@PieterDC - Definitely a valid request. I've considered adding a few workflow-specific tools to Drupal VM in the past (it is, after all, "Drupal" VM and not "generic PHP CMS VM"). However, since the tool would probably be used only by a small percentage of all Drupal VM users, I'd rather not maintain a separate role and/or functionality to grab the script, put it in place, etc.
However, I would like to document how it can be done quickly/easily in this ticket for those who want to use it—either via a post provision script or task file...

Also, note that this script is a wrapper around some tooling that is usually best as part of a Drupal project itself (e.g. how Acquia BLT wraps up coding standards reviews, PHPUnit tests, and Behat tests in a Drupal project codebase)—therefore I've been shying away from adding things like that directly to Drupal VM.

Working on this now... I think we can get a script in the example scripts dir that will do 99% of the work, and then you just copy and paste a few variables into your config.yml to get the rest done :)
Testing this on Honeypot now. Apparently I still have a master branch lurking in that project!

Tested and working! Basically, you add the following to config.yml, and you're off to the races!
post_provision_scripts:
  - "../examples/scripts/pareview.sh"

composer_global_packages:
  - { name: hirak/prestissimo, release: '^0.3' }
  - { name: drupal/coder, release: '^8.2' }

nodejs_version: "6.x"
nodejs_npm_global_packages:
  eslint

Wow. Thanks!
I created an internal task for our team to check this out with a suggestion on how to integrate this in our continuous deployment flow.

Blog post with a detailed guide and more notes: Drupal's Contrib floodgates are open, PAReview your projects in Drupal VM!.

A note to anyone else trying to use this...
The mention of eslint in the config.yml needs to be formatted like this:
nodejs_npm_global_packages:
  - name: eslint

See: https://github.com/geerlingguy/drupal-vm/issues/1301

@attheshow - Is this documented incorrectly somewhere? I think I fixed my blog post (the one place I know I had mistyped the variable), but I want to try to make it so others don't run into the same issue :)

In your comment here https://github.com/geerlingguy/drupal-vm/issues/1197#issuecomment-286261626

@oxyc oops! Fixed it.


Added proper jump and branch alignment validations.

Stack:

#4622 ⬅
#4616
#4596

⚠ Part of a stack created by spr. Do not merge manually using the UI - doing so may have unexpected results.

This change is

crates/cairo-lang-sierra/src/program_registry.rs line 213 at r1 (raw file):

                            dst: next,
                        }));
                    }

Why is that a problem?
Code quote:
                    if next.0 < i {
                        return Err(Box::new(ProgramRegistryError::BranchBackwards {
                            src: curr,
                            dst: next,
                        }));
                    }

crates/cairo-lang-sierra/src/program_registry.rs line 156 at r2 (raw file):

        }
        // A branches map, mapping from a destination statement to the statement that jumps to it.
        // Assuming branches into branch alignments only, this should be a bijection.

is jump a branch or not in this context?
Code quote:
 // Assuming branches into branch alignments only, this should be a bijection.

crates/cairo-lang-sierra/src/program_registry.rs line 209 at r4 (raw file):

            if !matches!(libfunc_branch.ap_change, SierraApChange::BranchAlign) {
                if let Some(prev) = branches.get(&index) {
                    return Err(Box::new(ProgramRegistryError::BranchNotToBranchAlign {

This does not have to be a branch according to the definition above, right?
Code quote:
BranchNotToBranchAlign

crates/cairo-lang-sierra/src/program_registry.rs line 156 at r4 (raw file):

            }
        }
        // A branches map, mapping from a destination statement to the statement that jumps to it.

Suggestion:
   // A branch map, mapping from a statement with multiple branch destination to branchAlign
   // statement.
   // A branchAlign statement may be reachable from at most 1 statement.