Creating UART with custom baud rate is not ergonomic

This is essentially https://github.com/rp-rs/rp-hal/issues/253 again, as the fix in #268 doesn't fix the original issue.
So there's a few problems here:

No example using anything other than a default baud rate or one of the common_configs
No documentation explaining how to get a custom baud rate
Even if you do manage to get it working, you're left with

let mut uartconf = bsp::hal::uart::common_configs::_9600_8_N_1;
uartconf.baudrate = HertzU32::from_raw(4800);

which is very surprising from an ergonomics point of view. the way to set UART config should be more ergonomic than this, even with "uncommon" configs.
Possible solutions:

Remove [non_exhaustive] from the config struct so you can initialise it by struct
Add a constructor that takes all the arguments in one pass
Use a builder pattern constructor that starts with default::Default and allows each setting to be modified one at a time. This assumes that Default is actually most often what users want, maybe we shouldn't do that.

What I don't like about the builder pattern together with default::Default is that this hides the actually used values. Reader of source code where such a config is created need to remember or look up what default::Default() means to understand the code.
The new constructor is implemented in https://github.com/rp-rs/rp-hal/pull/471.
(And also some functions which can be used in a builder pattern - so developers with different preferences could use that as well.)


[release-1.11] Update exclude namespaces default for istio-cni.

This is an automated cherry-pick of #34237

@istio-testing: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-multicluster-tests_istio_release-1.11
7148a56eb668f4688ff351f641438594a2622e28
link
/test integ-pilot-multicluster-tests_istio_release-1.11

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest


feat(transform_conformance): handle deserialization errors

#2980  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Boshen and the rest of your teammates on  Graphite


Fractional usage engineering design document

For the 🏗 sprint, let's aim for having a fully-baked engineering design document for fractional usage.

[ ] Outline "finalized" engineering decisions
[ ] Design all-purpose contract
[ ] Spec out API

Related: #146 & https://github.com/OriginProtocol/demo-dapp/issues/242

Additional discussion here: https://github.com/OriginProtocol/origin-js/issues/146

Done here 📝


Auth: No Frame when errors occur during auth

I've noticed that when require_auth is called from the SDK, and enforcing auth is enabled, if any error is encountered during the require_auth logic, the errors that get shown in the backtrace indicate something is wrong with the setup of the host:
Debug events (newest first):
   0: "Debug escalating error '' to panic"
   1: "Debug contract call invocation resulted in error Status(HostAuthError(NotAuthorized))"
   2: "Debug caught panic from contract function 'Symbol(add)', propagating escalated error 'Status(HostAuthError(NotAuthorized))'"
   3: "Debug escalating error '' to panic"
   4: "Debug no frames to derive the invoker from"

The lines of interest are 0, 3 and 4.
Lines 0 and 3 show empty strings for an error being escalated. Somewhere in the host we're generating an error without a description, which we should fix and give it an appropriate description.
Line 4 indicates that there's no frame to pull the invoker from, which is surprising because inside a contract call there is definitely a frame.
cc @sisuresh @dmkozh

The shortest path to replicating this issue is to write a contract in the SDK that uses require_auth, and comment out the SDK line that enables recording auth.
Example contract:
#![no_std]
use soroban_sdk::{contracterror, contractimpl, vec, Address, Env, RawVal};

pub struct Contract;

#[contractimpl]
impl Contract {
    pub fn add(e: Env, a: Address) -> u64 {
        a.require_auth();
        2
    }
}

#[cfg(test)]
mod test {
    use soroban_sdk::{
        testutils::Address as _,
        Address, Env,
    };

    use crate::{Authonator, Contract, ContractClient};
    extern crate std;

    #[test]
    fn test_add() {
        let e = Env::default();
        let contract_id = e.register_contract(None, Contract);
        let client = ContractClient::new(&e, &contract_id);
        let a = Address::random();
        let r = client.add(&a);
        assert_eq!(r, 2);
    }
}

Line to comment out in SDK to enable auth enforcing:
https://github.com/stellar/rs-soroban-sdk/blob/6a1f0fecc8fba0138394382290e3e88807454b4f/soroban-sdk/src/env.rs#L485

Related conversation that occurred in Slack: https://stellarfoundation.slack.com/archives/C030Z9EHVQE/p1681937681931139

Line 4 indicates that there's no frame to pull the invoker from, which is surprising because inside a contract call there is definitely a frame.

There is no invoker contract for root contract in tests (which is what auth is looking for). That's not an actual error - we need to clean up the code that gets the invoker contract id, as it always produces the debug event now even if the failure is handled gracefully (like in auth).
The actual error here is  Status(HostAuthError(NotAuthorized)) which means that the address hasn't authorized the invocation, more precisely that there is no matching auth tree for the address.


feat: get HMAC keys from conversations

Description:
This PR adds the getHmacKeys method to the Conversations class and its test as we currently have in JS and Android

yes, but in #231 there is a commit 8a02e8dc92f332462d77f8f3ec507f497bcc97dc that @zombieobject introduced. it can be also reverted?

@kele-leanes yes fine to revert. @zombieobject can introduce that in a follow up PR 👍


Faulty Username Parsing...?

First off thanks for this cool script.
Something seems to be wrong with the way you are parsing user names from the html. Not sure if facebook changed their html structure or if this something on my end or what.
I'm using the following command:
fbcap messages.htm -d parsed_msgs/

And get the following output (I removed the FB ID #'s in XXXX@facebook.com):
Discovered chat thread with<EMAIL_ADDRESS><EMAIL_ADDRESS>(most recent call last):
  File "c:\program files (x86)\python\lib\runpy.py", line 170, in _run_module_as_main
    "__main__", mod_spec)
  File "c:\program files (x86)\python\lib\runpy.py", line 85, in _run_code
    exec(code, run_globals)
  File "C:\Program Files (x86)\Python\Scripts\fbcap.exe\__main__.py", line 9, in <module>
  File "c:\program files (x86)\python\lib\site-packages\fbchat_archive_parser\main.py", line 188, in main
    app.run()
  File "c:\program files (x86)\python\lib\site-packages\clip.py", line 652, in run
    self.invoke(self.parse(tokens))
  File "c:\program files (x86)\python\lib\site-packages\clip.py", line 634, in invoke
    self._main.invoke(parsed)
  File "c:\program files (x86)\python\lib\site-packages\clip.py", line 519, in invoke
    self._callback(**{k: v for k, v in iteritems(parsed) if k not in self._subcommands})
  File "c:\program files (x86)\python\lib\site-packages\fbchat_archive_parser\main.py", line 125, in fbcap
    fbch = parser.parse()
  File "c:\program files (x86)\python\lib\site-packages\fbchat_archive_parser\parser.py", line 102, in parse
    self._parse_content()
  File "c:\program files (x86)\python\lib\site-packages\fbchat_archive_parser\parser.py", line 128, in _parse_content
    self._process_element(pos, element)
  File "c:\program files (x86)\python\lib\site-packages\fbchat_archive_parser\parser.py", line 262, in _process_element
    self.current_sender))
Exception: Data missing from message. This is a parsingerror: 2013-06-02 17:22:00-07:00, None

So obviously it's getting "None" for the username. If I just add the line self.current_user = "Unknown" before the thrown exception the script runs and completes but it obviously just results in every user  getting named "Unknown" in every conversation.

Hi there, thanks for pointing this out! What locale are you using on Facebook? I'll try pulling my own data again later and see if I can figure out the root cause of the issue.

Not sure exactly what you mean by locale, but... "en_US"??

I meant the language locale you set your Facebook browsing settings too (most issues stem from other languages), but I was able to reproduce the problem anyway by just downloading my data again in English (US).
Anyway, you're right in that this issue was caused by a change on Facebook's end. Unfortunately, it doesn't seem to be a formatting change... the archives are now literally just missing the name of the user who posted each message :/
Example:
...

Tuesday, February 12, 2013 at 9:15am PST

...

As you can see, the text is missing in .
I'll try writing to Facebook to see if they can fix it.
Sorry for the inconvenience :/

Came to report same issue. Is it possible to get a fix to the tool in the short term that just doesn't store sender? Don't need it for my use case :)

Thanks for the suggestion; I fixed the parser so it prints a warning when the sender is absent and just replaces them with "Unknown" (version 0.9.post28).
I also submitted a bug report to Facebook:

Hopefully someone actually looks at it :/
Going to close this issue since there's nothing else that can be done on this end.

Did you a get bug report #? I can ask around.

Unfortunately, they didn't provide one and said they only really respond if they need more information.

Don't suppose anyone has made any progress with facebook on this? Really irritating!

I haven't heard anything back yet, unfortunately. I was hoping it was fixed already, since I hadn't heard any new complaints :(
Not sure what else can be done, unless someone who works at or knows people who work at Facebook can give some insight.

@eldenvo @willium @nathangiles I just recently tried pulling a chat archive and it appears the missing name issue has been fixed on Facebook's end :)

Fantastic.

Hmmm I also tried re-downloading my archive, and I've still got the same problem!

@eldenvo hmm, it seemed to work for me when I was downloading my data in Croatian (it was to fix a language specific problem for someone else). No idea if that was the reason it worked. You could try changing your Facebook locale and then downloading your data to that and see if it fixes it. It doesn't affect the actual output.
You have to wait at least a day after your last download request though, or else it will just give you your last download again. You also can't change your locale back until you get the email saying your download is ready.

No, sadly I tried a different language and re-downloading, for the same problem!
Guess I'll just keep trying from time to time to see if FB fixes it!


XmlHttpRequest, could not fetch from server

Hi guys, I keep getting this error whenever I try to download your dependencies, funny thing is, I'm able to download XmlHttpRequest directly, just not from the github repo npm tries to get it from.
fernando.raviola@GLB-D3035:~/Documents/restapp-api$ sudo npm -g install<EMAIL_ADDRESS>
<EMAIL_ADDRESS>install /usr/lib/node_modules/socket.io/node_modules/engine.io/node_modules/ws
(node-gyp rebuild 2> builderror.log) || (exit 0)

make: Entering directory `/usr/lib/node_modules/socket.io/node_modules/engine.io/node_modules/ws/build'   CXX(target) Release/obj.target/bufferutil/src/bufferutil.o   SOLINK_MODULE(target) Release/obj.target/bufferutil.node   SOLINK_MODULE(target) Release/obj.target/bufferutil.node: Finished   COPY Release/bufferutil.node   CXX(target) Release/obj.target/validation/src/validation.o   SOLINK_MODULE(target) Release/obj.target/validation.node   SOLINK_MODULE(target) Release/obj.target/validation.node: Finished   COPY Release/validation.node make: Leaving directory `/usr/lib/node_modules/socket.io/node_modules/engine.io/node_modules/ws/build' npm ERR! fetch failed https://github.com/rase-/node-XMLHttpRequest/archive/a6b6f2.tar.gz npm WARN retry will retry, error on last attempt: Error: tunneling socket could not be established, cause=socket hang up

nevermind, it was an issue related to my corporate proxy, I don't know why I was able to download all but this particular package. Anyways, I'm closing this now


Create test data for TIFF

There's no automated tests for TIFF as the old pre-github images I had were too large and probably bound by copyright-related restrictions.

Added (tiny!) data for various codecs, but still lacking "tricky" variations.


feat(plugin-http): handle client errors

Which problem is this PR solving?

closes #347

Short description of the changes

handles possible client errors

changes _safeExecute signature for more flexibility
setSpanWithError is not responsable to end the span anymore.
IsIgnored function handles exception and does not re-throw
adds tests

Codecov Report

Merging #374 into master will decrease coverage by 0.13%.
The diff coverage is 90%.

@@            Coverage Diff             @@
##           master     #374      +/-   ##
==========================================
- Coverage   98.05%   97.91%   -0.14%
==========================================
  Files         105      104       -1
  Lines        4940     4759     -181
  Branches      424      427       +3
==========================================
- Hits         4844     4660     -184
- Misses         96       99       +3

Impacted Files
Coverage Δ

...lemetry-plugin-http/test/functionals/utils.test.ts
99.4% <100%> (+0.07%)
:arrow_up:

packages/opentelemetry-plugin-http/src/utils.ts
100% <100%> (ø)
:arrow_up:

packages/opentelemetry-plugin-http/src/http.ts
95.32% <68.75%> (-2.27%)
:arrow_down:

...ges/opentelemetry-exporter-zipkin/src/transform.ts
100% <0%> (ø)
:arrow_up:

.../opentelemetry-exporter-zipkin/test/zipkin.test.ts
100% <0%> (ø)
:arrow_up:

...pe-async-hooks/test/AsyncHooksScopeManager.test.ts
100% <0%> (ø)
:arrow_up:

...entelemetry-exporter-zipkin/test/transform.test.ts
100% <0%> (ø)
:arrow_up:

...ackages/opentelemetry-exporter-zipkin/src/utils.ts

...-plugin-http/test/integrations/http-enable.test.ts
92.92% <0%> (+1.01%)
:arrow_up:


Updated Czech localization

In some cases, there's some inconsistencies with Czech grammar. For example, in English:
In a month will output a correct datetime object - 1 month from now. But in Czech za měsíc won't print anything, but příští měsíc will. Both are correct Czech sentences.
The same proposed changes applies to za týden (in a week), za hodinu (in a hour), příští rok (next year).
Added new words:
In two days - pozítří
Two days ago - předevčírem
Last year - loni or vloni
And finally, added some new declensions of initial words.

Please, see https://dateparser.readthedocs.io/en/latest/contributing.html#guidelines-for-editing-translation-data


upgrade tests version tweaks

bump trunk version
remove 1.2 as a test starting point
add 2.2 back into the proto v1/v2 paths

@ptnapoleon to review

Lgtm, +1


Common error handlings

Hey there!
First of all - great tool! Very useful.
While playing with it, I've noticed that there is no common error handling. For example, I tried to register an event that do not exist (tried leave instead of exit).
Instead of a nice feedback about my error, I saw

Cannot read property 'push' of undefined

Which is not very helpful.
I suggest of adding few lines of checking if passed events/elements etc. are valid, and if not, instead of giving back an error, let's return some proper hint (for example: Unrecognized event name.).

@Krizzu Thanks for bringing this up! That's something that definitely should've been implemented by now. I'll plan to implement this ASAP.

Hey! I think I could take care of that, if it's possible :)


Correct version number

For some reason, apple complains about the version number that should have 3 digits. This lib prevented me from submitting to the appstore. Seems to be a new rule. Anyway, I've changed the version number to the correct one to prevent future problems.

@orangecoding it should not matter, because it does not take .info file into compilation for your project.


access: may-start-trybots

See https://go.dev/wiki/GerritAccess
New member of Go Security team at Google.
Group: https://go-review.googlesource.com/#/admin/groups/1030,members
Gerrit User<EMAIL_ADDRESS>

Granted (see #52215 ). Thanks!


Re-using sqlalchemy.dialects.postgresql.UUID instance generates mypy violation

Describe the bug
Storing an instance of sqlalchemy.dialects.postgresql.UUID to a variable and re-using that in the column declarations is seen as NullType.
Expected behavior
There shouldn't be a violation?
To Reproduce
from typing import Optional
from uuid import UUID

from sqlalchemy import Column
from sqlalchemy.dialects.postgresql import UUID as PostgresUUID
from sqlalchemy.orm import declarative_base

PgUUID = PostgresUUID(as_uuid=True)
Base = declarative_base()

class Foobar(Base):
    __tablename__ = "foobar"

    works: Optional[UUID] = Column(PostgresUUID(as_uuid=True))
    doesnt: Optional[UUID] = Column(PgUUID)

Error
Running with sqlalchemy.ext.mypy.plugin enabled in mypy configs:
$ mypy foobar.py
foobar.py:15: error: Incompatible types in assignment (expression has type "Column[NullType]", variable has type "UUID")  [assignment]
Found 1 error in 1 file (checked 1 source file)

Versions.

OS: Linux
Python: 3.9.9
SQLAlchemy: 1.4.39
mypy: mypy 0.971
SQLAlchemy2-stubs: 0.0.2a25

Also construction gives violation:
Foobar(
    works=uuid.uuid4(),
    doesnt=uuid.uuid4(),
)

$ mypy foobar.py
...
foobar.py:20: error: Unexpected keyword argument "doesnt" for "Foobar"  [call-arg]
...


48 package vulnerabilities

Try to solve a problem with travis.. nothing to do with package vulnerabilities

Invalid PR


Lock aspect ratio

I need to lock minimum aspect ration as  of the window (on windows) 4:3 and maximus as 16:9.
Do somebody have some ideas how I can do this using DefOs?

It should be able to be done on Windows without any DefOS changes. What you have to do is check the current window size and make sure that it conforms to the min/max and if not then it will resize the window so that it does. That kind of function could be added too. Lots of games do this like Hearthstone.

We don't know position of the window, and can't set resolution without position.
But it's not a problem. Now I try to find way use lpfnWndProc callback and write this method fully on DefOS side.
If I can't do this, I add get_position method and make it using this method.

If you want to use WndProc callback,  you can have a try with SetWindowLongPtr to replace current WndProc with you own. as i think that Defold already hooked it.

@AGulev we have a  lpfnWndProc callback implement now on #39, you can try to handle your message in it.

@chaosddp cool Thank you!

Now developer can make all calculation in lua using defos.get_window_size() and defos.set_window_size().


Missing Column Types

The "Discover column names and data types" table in this article mapping Dataverse attribute types to .Net types is very useful!
However it seems to be a little incomplete, missing:

File columns
"EntityName", which seems to just be a string (for example DocumentTemplate.AssociatedEntityTypeCode

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 6aa1a13f-1c93-4691-0e18-10dd64cf1601
Version Independent ID: bcdde162-15da-371b-dfcc-70f366ec7f82
Content: Entity class operations using the Organization service (Microsoft Dataverse) - Power Apps
Content Source: powerapps-docs/developer/data-platform/org-service/entity-operations.md
Service: powerapps
GitHub Login: @JimDaly
Microsoft Alias: jdaly

@fowl2  You can find a list of non-.NET and Dataverse specific attribute types here under Derived:
https://docs.microsoft.com/dotnet/api/microsoft.xrm.sdk.metadata.attributemetadata
The current list of supported entity attributes is:
Microsoft.Xrm.Sdk.Metadata.BigIntAttributeMetadata
Microsoft.Xrm.Sdk.Metadata.BooleanAttributeMetadata
Microsoft.Xrm.Sdk.Metadata.DateTimeAttributeMetadata
Microsoft.Xrm.Sdk.Metadata.DecimalAttributeMetadata
Microsoft.Xrm.Sdk.Metadata.DoubleAttributeMetadata
Microsoft.Xrm.Sdk.Metadata.EnumAttributeMetadata
Microsoft.Xrm.Sdk.Metadata.FileAttributeMetadata
Microsoft.Xrm.Sdk.Metadata.ImageAttributeMetadata
Microsoft.Xrm.Sdk.Metadata.IntegerAttributeMetadata
Microsoft.Xrm.Sdk.Metadata.LookupAttributeMetadata
Microsoft.Xrm.Sdk.Metadata.ManagedPropertyAttributeMetadata
Microsoft.Xrm.Sdk.Metadata.MemoAttributeMetadata
Microsoft.Xrm.Sdk.Metadata.MoneyAttributeMetadata
Microsoft.Xrm.Sdk.Metadata.StringAttributeMetadata
Microsoft.Xrm.Sdk.Metadata.UniqueIdentifierAttributeMetadata
This list is kept up to date. I can add a link to this in the topic.

@phecke Thanks for your response, but those are attribute metadata types, I'm looking for attribute data types (without the meta).
ie. what should I pass as T to Entity.GetAttributeValue<T>(String) for an attribute of a certain type.
Unless I'm missing something the documentation pages for the metadata doesn't actually say what the data types are, but thankfully this page does - in the table under "Discover column names and data types":

Type
Description

EntityReference
A Lookup attribute. A link to another entity record.

BooleanManagedProperty
Used only for entities that can be solution components, such as the WebResource table/entity reference.

But it is incomplete.

I agree with @fowl2
I believe that File columns would also return a byte[], but I haven't tested it.
I think this list has value and should be kept up-to-date.
You can leave this open and assigned to me. Not sure when I'll be able to get to it.

I updated the topic to mention EntityName fields and added a note about how File columns require a special set of messages to upload or download the file.
Don't think any new file types have been added recently.


add support for invisible recaptcha #120

fix #120

Awesome! when will this be merged?

Hello here, what is the status on this PR ? Does it need reviews ? Tests ? Another lib has emerged and this one won't be maintained ? How can I help ? I'd like this feature to be added.. Cheers !

As per @adrienbrunet comment, are there any news about this?

Please merge this PR! Invisible recaptcha is already public for quite a long time and this is the biggest recaptcha django addon, which should support it.

hello, are there any outstanding changes (other than the merge conflict resolutions) that need to be made for this PR for Invisible ReCaptcha to ship?


CVAT on arm64 (aarch64) Linux

Cheers,
I got a number of complaints on terminal when attempting to install CVAT on an ARM Linux machine. It appears some of the containers are not ready for it. Is it really the case?
Thanks.

Hi @cirobr
We do not support arm officially. There might be some problems.

There is related issue #4654


Memory and Specific effect issue

Thanks for the code, I'm trying to run this in Windows to include in my audio sequencer.
After installing with pip and download the pytorch checkpoints, I can run it:
..\python scripts\remfx_detect.py +exp=remfx_detect +audio_input=r:\reverb.wav

Can I have a specific effect instead of "remfx_detect" ? If i put "reverb" there  I got

Error executing job with overrides: ['+exp=reverb', '+audio_input=r:\\reverb.wav']
Traceback (most recent call last):
  File "F:\python\RemFx\scripts\remfx_detect.py", line 16, in main
    for effect in cfg.ckpts:
                  ^^^^^^^^^
omegaconf.errors.ConfigAttributeError: Key 'ckpts' is not in struct
    full_key: ckpts
    object_type=dict

Set the environment variable HYDRA_FULL_ERROR=1 for a complete stack trace.

Eventually it gets out of memory with my 32 GB and it's too slow if it doesn't. A way to make it a bit faster would help.

Best and thanks for all that.

Hey, thanks for trying our project!

In general, we were aiming to tackle the problem where the effects present were unknown beforehand. However, if you want to run the code for a specific effect on an audio file, probably the simplest way is to hack the remfx_detect.py script. I haven't tested the following code, but you'll need to do something like below:

In the RemFXChainInference() call, set classifier = None
Modify batch = [audio, audio, None, **[[0, 0, 0, 0, 0]]**], set one of those zeros to one. The effects are in the order of [[Reverb, Chorus, Delay, Distortion, Compressor]]

If you are using CPU, it will run very slowly, but GPU will speed it up significantly. If you follow the steps in 1., it should speed up the inference a decent amount (and use less memory overall) as it is not performing the classification, and only running 1 effect-specific model

Thanks for your response, do I use the GPU by installing the GPU-enabled torch?

I tried installing torch from site with GPU support and yet when I install remfx it still wants to install torch again and it uses CPU... any hints?

I saw that you are checking for cuda in your code so the issue is at my end, will fix and notify you. Thanks for everything.

I found it
scripts\pip install -e ./remfx ./remfx/umx
scripts\pip uninstall -y torch torchvision torchaudio functorch
scripts\pip install torch torchvision torchaudio --index-url https://download.pytorch.org/whl/cu118
scripts\pip install --no-deps hearbaseline
cd remfx
scripts\download_ckpts.sh
and then the CUDA version works fine. Thanks for all. Will notify you when I 've put it into my sequencer with credits today.

I still have the memory issue. I got 32 gb or ram, 8 GB of GPU rtx 4060 and yet I get memory errors even if only the reverb is being removed.
Thanks a lot.

@WindowsNT
Did you manage to make this work without requiring more than 32GB of memory?
I'm looking for a solution to mitigate echo and distortion, something like this https://crowdunmix.org/the-best-way-to-recover-audio-distortion-using-ai/

No, not yet, still trying.


test16

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@e3ef595). Click here to learn what that means.
The diff coverage is n/a.

Flag
Coverage Δ

packit-e2e
51.60% <0.00%> (?)

testsuite
24.07% <0.00%> (?)

unittests
11.11% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.


some questions need help

Hi, @wangx1996 . Thanks for supply this code. Here, I have some questions needs your some reply.

I clone this code, and using catkin_make passed. but when I run roslaunch track.launch， here appears some error in terminate.

setting /run_id to e811c1b4-66e5-11ec-af2b-40b07680d35e process[rosout-1]: started with pid [19543] started core service [/rosout] process[tracking_node-2]: started with pid [19549] process[rviz-3]: started with pid [19551] 222+++++++++++++++++++++++++++ [tracking_node-2] process has died [pid 19549, exit code -11, cmd /media/holo/B834B57734B538E8/Multi-Object-Tracking/track_ws/devel/lib/mot_tracking/tracking_node __name:=tracking_node __log:=/home/holo/.ros/log/e811c1b4-66e5-11ec-af2b-40b07680d35e/tracking_node-2.log]. log file: /home/holo/.ros/log/e811c1b4-66e5-11ec-af2b-40b07680d35e/tracking_node-2*.log
222++++ is debug message, only located in main(). example is here:
`int main(int argc, char** argv)
{
ros::init(argc, argv, "vision_node");
ros::NodeHandle nh;
std::cout << "222+++++++++++++++++++++++++++" << std::endl;
image_transport::ImageTransport it(nh);
std::cout << "222.5+++++++++++++++++++++++++++" << std::endl;
image_transport::Publisher pubimage = it.advertise("/mot_tracking/image", 1);
}
`
I confused why not go passed image_transport::ImageTransport it(nh);.

about this data path:

---/xxx/0020
|--velodyne/0020
|--oxts/
|--label_02/
Is it right?

solve it, because of different boost thread will coredump. I use boost version is 1.65.1.

hi! After you use 1.65.1,can you successfully run this project now?


Switch React state management to Redux

React state management is getting pretty complex in Template Studio, with a lot of callback handlers. We should consider switching to Redux:
https://redux.js.org/introduction/getting-started
https://react-redux.js.org

This issue has been moved to https://github.com/accordproject/template-studio-v2/issues/3


Update to latest Midgard v0.2.0

https://gitlab.com/thorchain/midgard/-/releases/v0.2.0

Resolved by #511


Test python 3.8 and Django 3.0 and align doc version specs

We're trying to upgrade to Django 3.0 as soon as possible, so I'm going through all our dependencies and helping ensure they work on the latest version of everything.

Does anyone have pypi access to update this?
cc @hamstap85 , @auvipy


Feat/219 move buttons and feat/220 move and update date

Pull Request
Description
Moved buttons and updated the date format.
There might be an issue with deployment code because I created a variable called options when updating the date format in utils.ts and typescript in didn't seem to like that.
The zoom in and out button still needs to be moved.
Fixes #219 & #220
Previous:

Design Suggestion:

New:

How Has This Been Tested?
This was tested visually by running the code locally.

[x] Yes

Checklist:

[x] My code follows OCF's coding style guidelines
[x] I have performed a self-review of my own code
[ ] I have made corresponding changes to the documentation
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have checked my code and corrected any misspellings

thanks. i just tried moving the mapbox zoom in/out button with the other buttons, and it looks like there are only 4 settings: top-right, top-left, bottom-right, bottom-left. so I left it in the bottom-right.


fix(collectionReady): fix bluebird warning

fixes #214

Coverage decreased (-18.7%) to 63.504% when pulling 7a1b614b93b9274a423a1acc40eecfc5a6a08b32 on Awk34:patch-1 into a613c1fa68fc3c74ab9244d70e3cca11c2de7101 on kcbanner:master.

Coverage increased (+0.3%) to 82.482% when pulling 7a1b614b93b9274a423a1acc40eecfc5a6a08b32 on Awk34:patch-1 into a613c1fa68fc3c74ab9244d70e3cca11c2de7101 on kcbanner:master.

Can you just explain why it produces a different behavior?
Thx!

To the best of my knowledge, it has to do with Bluebird making sure that your original reference to the created promise is also returned. When you conditionally set it the the property on this, it gets confused and thinks that you're not returning the original promise.

During my tests it seems to have fixed the issue.

Here's the relevent Bluebird code:
https://github.com/petkaantonov/bluebird/blob/d62e20741eb759a50aa7af13c5dc7fb2bfbf2694/src/promise.js#L517-L549

Promise.prototype._settlePromiseFromHandler = function (
    handler, receiver, value, promise
) {
    var bitField = promise._bitField;
    if (BIT_FIELD_CHECK(IS_CANCELLED)) return;
    promise._pushContext();
    var x;
    if (receiver === APPLY) {
        if (!value || typeof value.length !== "number") {
            x = errorObj;
            x.e = new TypeError("cannot .spread() a non-array: " +
                                    util.classString(value));
        } else {
            x = tryCatch(handler).apply(this._boundValue(), value);
        }
    } else {
        x = tryCatch(handler).call(receiver, value);
    }
    var promiseCreated = promise._popContext();
    bitField = promise._bitField;
    if (BIT_FIELD_CHECK(IS_CANCELLED)) return;

    ASSERT(!promise._isFateSealed());

    if (x === NEXT_FILTER) {
        promise._reject(value);
    } else if (x === errorObj) {
        promise._rejectCallback(x.e, false);
    } else {
        debug.checkForgottenReturns(x, promiseCreated, "",  promise, this);
        promise._resolveCallback(x);
    }
};

https://github.com/petkaantonov/bluebird/blob/5bffd55f20f1df5361603612867f286fa13e56e3/src/debuggability.js#L398-L410
function checkForgottenReturns(returnValue, promiseCreated, name, promise,
                               parent) {
    if (returnValue === undefined && promiseCreated !== null &&
        wForgottenReturn) {
        if (parent !== undefined && parent._returnedNonUndefined()) return;
        if (BIT_FIELD_READ(LENGTH_MASK, promise._bitField) === 0) return;

        if (name) name = name + " ";
        var msg = "a promise was created in a " + name +
            "handler but was not returned from it";
        promise._warn(msg, true, promiseCreated);
    }
}

@jdesboeufs do you have any time to look at this? The bluebird warning is still annoying me and I don't want to have to fork this module XD

Published as v1.2.1. Thx!!


🌐 Add Korean translation for docs/ko/docs/advanced/testing-events.md

LGTM

LGTM 🚀

Thank you! @9zimin9 :rocket: :100:


require explicit pallet indexes

fixes #787
Adds a custom lint that completely disallows invocations of construct_runtime! that do not use explicit indexes for all mentioned pallets.
This was extremely tricky to get right. After many attempts to re-implement construct_runtime! parsing from scratch, I decided to fork frame-support-procedural from upstream and modify it so that instead of a proc-macro crate, it exports all parsing logic so it can be used from other crates. This can be fully updated to whatever tag we want in polkadot-sdk using the provided update.sh script by modifying this line:
POLKADOT_SDK_TAG="v1.10.0-rc3"

If polkadot-sdk ever adds a public way of accessing the parsing logic for frame internals, we can remove this fork, however that is unlikely to happen any time soon. Maintaining this fork should be super easy since it can be updated with the script whenever we want, and the structure of that crate is likely never going to change (I used to maintain it).
Notes for Reviewers / TLDR:

the contents of procedural-fork OTHER THAN the lib.rs, update.sh and Cargo.toml are copied verbatim from polkadot-sdk 1.10., so those 3 files are all you need to review from that directory
otherwise all the relevant code changes are in support/linting/pallet_index.rs and build.rs

fixing one edge case, do not merge

should be good to review / merge now!

had to turn off cargo test for procedural-fork because the tests rely on a bunch of janky features to pass and no need for that, if it compiles we are good / we just care about parsing


fix: Fix dataset condition to allow query for datasets in sqllab

SUMMARY

Bug found that stops users from querying datasets, while going to explore view.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Changes UI
[ ] Requires DB Migration.
[ ] Confirm DB Migration upgrade and downgrade tested.
[ ] Introduces new feature or API
[ ] Removes existing feature or API

Codecov Report

Merging #12357 (3ff13ba) into master (4d27993) will decrease coverage by 0.92%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #12357      +/-   ##
==========================================
- Coverage   64.21%   63.29%   -0.93%
==========================================
  Files         485      485
  Lines       29888    29873      -15
==========================================
- Hits        19194    18907     -287
- Misses      10694    10966     +272

Flag
Coverage Δ

python
63.29% <ø> (-0.93%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

superset/db_engines/hive.py
0.00% <0.00%> (-85.72%)
:arrow_down:

superset/databases/commands/create.py
32.65% <0.00%> (-59.19%)
:arrow_down:

superset/sql_validators/postgres.py
50.00% <0.00%> (-50.00%)
:arrow_down:

superset/db_engine_specs/hive.py
54.61% <0.00%> (-29.62%)
:arrow_down:

superset/views/database/mixins.py
59.64% <0.00%> (-22.81%)
:arrow_down:

superset/db_engine_specs/presto.py
70.56% <0.00%> (-12.78%)
:arrow_down:

superset/db_engine_specs/mysql.py
79.59% <0.00%> (-12.25%)
:arrow_down:

superset/databases/commands/update.py
85.71% <0.00%> (-8.17%)
:arrow_down:

superset/databases/dao.py
94.11% <0.00%> (-5.89%)
:arrow_down:

superset/databases/api.py
86.49% <0.00%> (-5.49%)
:arrow_down:

... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d27993...3ff13ba. Read the comment docs.

Codecov Report

Merging #12357 (3ff13ba) into master (4d27993) will decrease coverage by 0.92%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #12357      +/-   ##
==========================================
- Coverage   64.21%   63.29%   -0.93%
==========================================
  Files         485      485
  Lines       29888    29873      -15
==========================================
- Hits        19194    18907     -287
- Misses      10694    10966     +272

Flag
Coverage Δ

python
63.29% <ø> (-0.93%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

superset/db_engines/hive.py
0.00% <0.00%> (-85.72%)
:arrow_down:

superset/databases/commands/create.py
32.65% <0.00%> (-59.19%)
:arrow_down:

superset/sql_validators/postgres.py
50.00% <0.00%> (-50.00%)
:arrow_down:

superset/db_engine_specs/hive.py
54.61% <0.00%> (-29.62%)
:arrow_down:

superset/views/database/mixins.py
59.64% <0.00%> (-22.81%)
:arrow_down:

superset/db_engine_specs/presto.py
70.56% <0.00%> (-12.78%)
:arrow_down:

superset/db_engine_specs/mysql.py
79.59% <0.00%> (-12.25%)
:arrow_down:

superset/databases/commands/update.py
85.71% <0.00%> (-8.17%)
:arrow_down:

superset/databases/dao.py
94.11% <0.00%> (-5.89%)
:arrow_down:

superset/databases/api.py
86.49% <0.00%> (-5.49%)
:arrow_down:

... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d27993...3ff13ba. Read the comment docs.


Typhoon Needs Documentation Pages

I can't generate the documentation with Doxygen, but I am inexperienced with the tool – I found this http://jasperblues.github.io/Typhoon/api/index.html but it looks out of date by many months. Is there a script I'm missing, or could it be added to the website?

unfortunately http://www.typhoonframework.org/ is unavailable at the moment.

The website now runs at: http://appsquickly.github.io/Typhoon . . not sure if the build server still produces docs there though.


Navbar not collapsing after choosing nav-item

Can you please share your device info?

Well, I've Samsung J2 but it's also not working on the browser device toolbar as well.

I can recreate this on desktop as well. FWIW dropping
      var navMain = $(".navbar-collapse");
      navMain.on("click", "a", null, function (e) {
        $('.navbar-collapse').collapse('hide');
      });

here https://github.com/hossainemruz/toha/blob/master/static/assets/js/navbar.js#L31 seems to resolve the issue.
@hossainemruz  I haven't used the bootstrap menu too much, I took the answer from https://stackoverflow.com/questions/14203279/bootstrap-close-responsive-menu-on-click
There might be a cleaner solution given this is such a common bootstrap usecase. I can keep looking

This actually looks like a better solution
https://stackoverflow.com/questions/42401606/how-to-hide-collapsible-bootstrap-4-navbar-on-click
https://getbootstrap.com/docs/4.0/components/collapse/
I tested and adding data attributes to
https://github.com/hossainemruz/toha/blob/master/layouts/partials/navigators/navbar.html#L44
https://github.com/hossainemruz/toha/blob/master/layouts/partials/navigators/navbar.html#L34
seems to resolve the issue in desktop chrome

Opened a PR here https://github.com/hossainemruz/toha/pull/112

Fixed in #112


'morePics' added to $newResult array within fetch()

Some posts have more than 1 picture, and I needed to grab all the pictures for the posts, if it had more. So this is what I've come up with.
I'm sure something like this could be added to your 2 new functions, but I have not taken a look at the array returned from those paths to confirm.
I will probably be tweaking this some more to allow us to base64_decode() the images and save them on our system so its not as heavy in the source. Will update your project when I am able to confirm that is working.
[
  {
    "id": "2696840872190940431",
    "time":<PHONE_NUMBER>,
    "imageUrl": "https://scontent-lcy1-1.cdninstagram.com/v/t51.2885-15/e35/p1080x1080/249938862_1214260935751176_32...",
    "likes": 18,
    "comments": 0,
    "link": "https://www.instagram.com/p/CVtGnwashUP/",
    "text": "#helloworld #domain #check",
    "image": "/9j/4AAQSkZJRgABAQAAAQABAAD/7QB8UGhvdG9zaG9wIDMuMAA4QklNBAQAAAAAAGA.............",
    "morePics": [
        {
            "imageUrl": "https://scontent-lcy1-1.cdninstagram.com/v/t51.2885-15/e35...............",
            "image": "/9j/4AAQSkZJRgABAQAAAQABAAD/7QB8UGhvdG9zaG9wIDMuMAA4QklNBAQAAAAAAGA............."
        },
        {
            "imageUrl": "https://scontent-lcy1-1.cdninstagram.com/v/t51.2885-15/e35...............",
            "image": "/9j/4AAQSkZJRgABAQAAAQABAAD/7QB8UGhvdG9zaG9wIDMuMAA4QklNBAQAAAAAAGA............."
        }
    ]
  }
]

Thanks for the awesome class!

Thank you, I really appreciate, unfortunately I previosly planned to add it (with tags)


Remove username from uffizzi config

Do not ask for username when the uffizzi config command is run

TESTED - OK


Detekt Build: missing task dependency between sourcesJar and generateDocumentation

Expected Behavior
Clean build output and correct build every time.
Observed Behavior
Most likely:
Execution optimizations have been disabled for task ':detekt-core:sourcesJar' to ensure correctness
> Task :detekt-core:sourcesJar
Execution optimizations have been disabled for task ':detekt-core:sourcesJar' to ensure correctness due to the following reasons:
  - Gradle detected a problem with the following location: 'P:\projects\contrib\github-detekt\detekt-core\src\main\resources'. Reason: Task ':detekt-core:sourcesJar' uses this output of task ':detekt-generator:generateDocumentation' without declari
ng an explicit or implicit dependency. This can lead to incorrect results being produced, depending on what order the tasks are executed. Please refer to https://docs.gradle.org/7.6/userguide/validation_problems.html#implicit_dependency for more de
tails about this problem.

> Task :detekt-generator:generateDocumentation
Picked up JAVA_TOOL_OPTIONS: -Xms32M -Xmx256M -XX:+UseG1GC -D-XX:+PrintCommandLineFlags
Wrote: P:\projects\contrib\github-detekt\website\docs\rules\complexity.md
Wrote: P:\projects\contrib\github-detekt\website\docs\rules\coroutines.md
Wrote: P:\projects\contrib\github-detekt\website\docs\rules\comments.md
Wrote: P:\projects\contrib\github-detekt\website\docs\rules\empty-blocks.md
Wrote: P:\projects\contrib\github-detekt\website\docs\rules\potential-bugs.md
Wrote: P:\projects\contrib\github-detekt\website\docs\rules\exceptions.md
Wrote: P:\projects\contrib\github-detekt\website\docs\rules\libraries.md
Wrote: P:\projects\contrib\github-detekt\website\docs\rules\naming.md
Wrote: P:\projects\contrib\github-detekt\website\docs\rules\performance.md
Wrote: P:\projects\contrib\github-detekt\website\docs\rules\ruleauthors.md
Wrote: P:\projects\contrib\github-detekt\website\docs\rules\style.md
Wrote: P:\projects\contrib\github-detekt\website\docs\rules\libraries.md
Wrote: P:\projects\contrib\github-detekt\website\docs\rules\ruleauthors.md
Wrote: P:\projects\contrib\github-detekt\website\docs\rules\formatting.md
Wrote: P:\projects\contrib\github-detekt\detekt-core\src\main\resources\default-detekt-config.yml
Wrote: P:\projects\contrib\github-detekt\detekt-core\src\main\resources\deprecation.properties
Wrote: ..\detekt-formatting\src\main\resources\config\config.yml
Wrote: ..\detekt-rules-libraries\src\main\resources\config\config.yml
Wrote: ..\detekt-rules-ruleauthors\src\main\resources\config\config.yml

But it could also error in different ways showing the potential effects of the warning above, here are two examples:
Could not get file mode / Could not add file '...' to ZIP '...'.
> Task :detekt-formatting:processResources FAILED
> Task :detekt-rules-ruleauthors:sourcesJar FAILED

FAILURE: Build completed with 2 failures.

1: Task failed with an exception.
-----------
* What went wrong:
Execution failed for task ':detekt-formatting:processResources'.
> Could not get file mode for 'P:\projects\contrib\github-detekt\detekt-formatting\src\main\resources\config\config.yml'.

* Try:
> Run with --stacktrace option to get the stack trace.
> Run with --info or --debug option to get more log output.
==============================================================================

2: Task failed with an exception.
-----------
* What went wrong:
Execution failed for task ':detekt-rules-ruleauthors:sourcesJar'.
> Could not add file 'P:\projects\contrib\github-detekt\detekt-rules-ruleauthors\src\main\resources\config\config.yml' to ZIP 'P:\projects\contrib\github-detekt\detekt-rules-ruleauthors\build\libs\detekt-rules-ruleauthors-1.22.0-sources.jar'.

* Try:
> Run with --stacktrace option to get the stack trace.
> Run with --info or --debug option to get more log output.
==============================================================================

* Get more help at https://help.gradle.org

BUILD FAILED in 3s
39 actionable tasks: 5 executed, 34 up-to-date

Cannot fingerprint input file property 'rootSpec$1'
FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':detekt-core:processResources'.
> Cannot fingerprint input file property 'rootSpec$1': java.nio.file.NoSuchFileException: /Users/vvp/IdeaProjects/detekt/detekt-core/src/main/resources/default-detekt-config.yml

Steps to Reproduce
(-x dokkaHtml is only there to speed things up, you can remove it to make the repro more realistic.)

Fill the caches and generate everything:

./gradlew :detekt-generator:generateDocumentation :detekt-core:sourcesJar -x dokkaHtml

(repeatable) fail the build or generate the warning that explains why the build fails:

gradlew :detekt-generator:cleanGenerateDocumentation :detekt-generator:generateDocumentation :detekt-core:cleanSourcesJar :detekt-core:sourcesJar -x dokkaHtml --no-build-cache

Context
@VitalyVPinchuk is messing about with Detekt codebase, and keeps findings these gems 😎
Your Environment

Version of detekt used: N/A 0341753f8a7468a7fff5ff37e545f6bceee1f6ba on main
Version of Gradle used (if applicable): 7.6 0341753f8a7468a7fff5ff37e545f6bceee1f6ba on main
Gradle scan link (add --scan option when running the gradle task): https://gradle.com/s/uf3bigfn46olk (config cache is disabled because of another bug I'll report)
Operating System and version: Windows 10
Link to your project (if it's a public repository): 0341753f8a7468a7fff5ff37e545f6bceee1f6ba

See #5773 which should fix this.

Actually, #5773 won't fix this issue in its current state. It'll fix a very similar one, on a different task. Notice that this is about sourcesJar, which uses raw src/main/resources. While jar transitively depends on processResources which copies src/main/resources to the build folder. This latter will be fixed only.
This can be easily confirmed by running the repro on the PR branch and still observing the behavior.
@jprinet do you think the fix for this would be very similar? or do we just need dependsOn here?

I was able to get this one fixed with the same approach. Let me ship it in the original PR 👍


add missed onnx ops & bug fix

Should other required ONNX OPs be implemented in this PR?

Should other required ONNX OPs be implemented in this PR?

Nope, the others should be after folder refactor

/azp run


feat(Icon): add new stop icon

Stop

Deploy preview failed.
Built with commit 98e39b444fcce18c9a97c367c3881d880895112e
https://app.netlify.com/sites/chauffer-vanessa-27088/deploys/593f846f6f4c505635f8a12e

Deploy preview ready!
Built with commit 98e39b444fcce18c9a97c367c3881d880895112e
https://deploy-preview-359--mcs-lite-introduction.netlify.com

Deploy preview ready!
Built with commit 98e39b444fcce18c9a97c367c3881d880895112e
https://deploy-preview-359--mcs-lite-ui.netlify.com


have way to pass in --extern via "cargo:" build stdout

I am trying to make it possible to use a binary crate (binary data downloaded and used directly) to make it easier to develop scripts in rust that need dependencies (using cargo script primarily).
I have a pretty good working model here through the following process:

tar the compiled crate up: tar -cvpf lib-target.tar target/debug/deps target/debug/.fingerprint
untar that into the new crate that will use your lib: tar -xf lib-target.tar
add extern crate lib to src/lib.rs but you do NOT need to add anything to Cargo.toml
build with something like RUSTFLAGS='--extern star=/home/user/use_lib/target/debug/deps/liblib-00ea3f9aa06a9c77.rlib' cargo build

This whole workflow works great, however the last step seems to be impossible to currently add to a build script. Can that be added?
Note that I've tried the following but it doesn't seem to work:
println!("cargo:rustc-env=RUSTFLAGS='--extern star=/home/garrett/notes/rust/use_star/target/debug/deps/libstar-00ea3f9aa06a9c77.rlib'");

Thankyou!

I opened an issue at DanielKeep/cargo-script#45 instead. I think that is actually the right place to address this.


az rest does not honor --query / --output global parameters

Describe the bug
Adding --query or --output to an otherwise successful az rest command ends up suppressing stdout output. If these params are not present, a valid json response is seen.
Command Name
az rest --method get --uri subscriptions/0d28f770-f3bc-4939-b759-82c2243deb4b/resourcegroups?api-version=2019-10-01 --query [].{N:name,L:location} --output table
Errors:
empty output
To Reproduce:
Steps to reproduce the behavior. Note that argument values have been redacted, as they may contain sensitive information.

Put any pre-requisite steps here...
az rest --method {} --uri {} --query {} --output {}

Expected Behavior
Environment Summary
Linux-4.4.0-18362-Microsoft-x86_64-with-debian-buster-sid
Python 3.6.5
Shell: bash

azure-cli 2.0.72 *
azure-cli-iot-ext 0.7.1

Extensions:
azure-cli-iot-ext 0.7.1
interactive 0.4.3

Additional Context
this is in regular azure public cloud

HI @zhoxing-ms could you pls have a look? thanks.

add to S167

@hiteshmadan This seems to be a problem with the jmespath syntax usage of --query. Because the outer layer of the resource group list is wrapped with the value key, so the parameter of --query should be value[].{N:name, L:location}.
Please have a try~   If you still have any questions, please feel free to let us know.


Generating changelog

fixed with direct push to master, using conventional-changelog-cli. In future - github actions with it and publishing.


IGNITE-15329 Atomics should be repairable by Read Repair

Thank you for submitting the pull request to the Apache Ignite.
In order to streamline the review of the contribution
we ask you to ensure the following steps have been taken:
The Contribution Checklist

[ ] There is a single JIRA ticket related to the pull request.
[ ] The web-link to the pull request is attached to the JIRA ticket.
[ ] The JIRA ticket has the Patch Available state.
[ ] The pull request body describes changes that have been made.
The description explains WHAT and WHY was made instead of HOW.
[ ] The pull request title is treated as the final commit message.
The following pattern must be used: IGNITE-XXXX Change summary where XXXX - number of JIRA issue.
[ ] A reviewer has been mentioned through the JIRA comments
(see the Maintainers list)
[ ] The pull request has been checked by the Teamcity Bot and
the green visa attached to the JIRA ticket (see TC.Bot: Check PR)

Notes

How to Contribute
Coding abbreviation rules
Coding Guidelines
Apache Ignite Teamcity Bot

If you need any help, please email<EMAIL_ADDRESS>or ask anу advice on http://asf.slack.com #ignite channel.

Hello, is this work going to be applied to GridGain?

@pkgonan I think you should ask Grid Gain support or employee.
This patch is open source and CAN be applied to any Ignite fork.


fix: frontmatter asset loading, fixes #169

Summary
See #169
What kind of change does this PR introduce? (check at least one)

[x] Bugfix
[ ] Feature
[ ] Code style update
[ ] Refactor
[ ] Docs
[ ] Build-related changes
[ ] Other, please describe:

If changing the UI/CSS related code, please provide the before/after screenshot:
Does this PR introduce a breaking change? (check one)

[ ] Yes
[x] No

If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:

[ ] When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

[x] Chrome
[x] Firefox
[ ] Safari
[ ] Edge
[ ] IE

If adding a new feature, the PR's description includes:

[ ] A convincing reason for adding this feature
[ ] Related documents have been updated
[ ] Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.
Other information:

Published PR with canary version: `

<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>

Published canary release<EMAIL_ADDRESS>


Bug on Binance Margin create_margin_order function

@nardew
/cryptoxlib-aio/cryptoxlib/clients/binance/BinanceClient.py , for create_margin_order function, when send market order, the time_in_force should be empty.
time_in_force: Optional[enums.TimeInForce] = enums.TimeInForce.GOOD_TILL_CANCELLED,

should be
time_in_force: Optional[enums.TimeInForce] = None,

otherwise, you get
cryptoxlib.clients.binance.exceptions.BinanceRestException: Rest API exception: status [400], response [{'code': -1106, 'msg': "Parameter 'timeInForce' sent when not required."}]

Hi @xiandong79 can you check if #58 fixes the issue you have discovered?
Many thanks.

Hi @xiandong79 can you check if #58 fixes the issue you have discovered?
Many thanks.

yes. I think so.

Published in 5.1.2.


[memoize] Feature Request: Asynchronous Variants

The current memoize functions cache raw Promises without evaluating them. This is an issue, because I do not want to cache rejected Promises.
Reproduction:
import { memoizeO } from<EMAIL_ADDRESS>
function rejectAfterDelay(ms?: number) {
  return new Promise((_, reject) => setTimeout(reject, ms))
}

async function test() {
  const memoizedAsyncFn = memoizeO(async (delay: number) => {
    console.log('executing')
    await rejectAfterDelay(delay)
  })

  try {
    await memoizedAsyncFn(2000)
  } catch {
    console.log('Failure 1')
  }

  try {
    await memoizedAsyncFn(2000)
  } catch {
    console.log('Failure 2 without delay, because the same Promise got re-evaluated')
  }
}

test()

Solution:
Make asynchronous variants for all memoization functions that skip caching when the Promise is rejected.
Reason:
Throwing an error synchronously in memoize functions causes the caching to be skipped. The same thing does not happen for rejected Promises. This is fine if reusing the same failed Promise is intentional, but I would assume that for most use cases this is not the desired outcome.
Example workaround:
I wrote a workaround async variant of memoizeO to showcase the desired behavior:
import type {NumOrString} from<EMAIL_ADDRESS>import {memoizeO} from<EMAIL_ADDRESS>
type Memoize<A extends NumOrString, B> = Parameters<typeof memoizeO<A, B>>
type MemoizeFunction<A extends NumOrString, B> = Memoize<A, Promise<B>>[0]
type MemoizeCache<A extends NumOrString, B> = Memoize<A, Promise<B>>[1]

/**
 * Memoizes the result of an asynchronous function. Caching is skipped when errors are raised.
 *
 * @param fn
 * @param cache
 */
export function memoizeAsync<A extends NumOrString, B>(
  fn: MemoizeFunction<A, B>,
  cache?: MemoizeCache<A, B>,
) {
  cache = cache ?? {}
  const memoized = memoizeO(fn, cache)

  return async (x: A) => {
    try {
      return await memoized(x)
    } catch (error) {
      delete cache[x]
      throw error
    }
  }
}

@HitomiTenshi — I published a new version of this package two days ago (v4.0.0). Please see this commit for details... 👍

@postspectacular Thank you very much for the quick implementation of this feature! It works perfectly! ❤
(I have only tested memoizeAsyncO, since that's the only memoize function I use as of now.)


feat(recipes): react-native-vision-camera

Description

Closes #104
Implements a barcode scanner with Ignite v9 and react-native-vision-camera
Requests permissions for camera
Able to scan barcodes with camera interface
Adds a store and screen to view previously scanned codes via Ignite generators

I need to mention the expo run commands to use here

The comments in those tsx files are made with //, which is incorrect and will produce errors on user. It will warn the user to wrap some strings around with Text tag, very generic. It was kinda hard to see what the problem, because those comment tags are common with the JS devs, and many will miss it.
TLDR: // comment thing needs to be removed.

@var-che those comments are particular to docusaurus formatting and not meant to be exactly copied from the raw markdown here, so no changes need to be made for the PR but yeah fine to remove them to give it a try

Right on! Thanks for the clarification @frankcalise !


Replaced EventHandler properties with events

Replaced all the auto properties I could find with events

Thanks! Will leave this open until it is included in the next release.


maimai FESTiVAL PLUS (v8) fetch internal level bugfix

Hi. Happy new year!
There's bug that exported data has some omitted songs when fetching maimai FESTiVAL PLUS internal level data.
Some data index value in fetchSheetsV8() function has been changed according to reference Google sheet.
Note that I only checked v8.
Would you check this pull request?
Thanks.

Thanks! Will check it later! 🙂

Merged.
Thank you for the contribution and Happy New Year! 😀


Add controller messaging system

Adds a controller messaging system, which will be used to facilitate inter-controller communication. The controller messenger acts as a message broker, passing actions and events back and forth between controllers. It is fully type safe.
This idea was described in the Controller Messaging System proposal.
This controller messenger doesn't set support attenuation, so it's not yet possible to restrict which actions and events are interacted with. That will be coming in a later PR.

Attenuation is added in this follow-up PR: #377 378. It's still a work-in-progress, but that should give some idea what attenuation could look like.

I don't yet have tests for ensuring this is type-safe. There is no straightforward way of testing this, as any misuse of types would fail to compile, and JavaScript tests wouldn't test the types at all.
There are some libraries that could help here though. I've opened #379 for investigating this further.
In the meantime I've been testing that this is type-safe by manually editing the unit tests into various type violations, and ensuring I get an error when I run the tests.

Thanks for the review @brad-decker ! Unfortunately I've just discovered that I forgot to document all of these methods though :facepalm:. So I'm gonna push one more commit in a few minutes to address that shortcoming.

Alright, all methods should now be documented! This is ready for review again.


FauxmoESP into Home Assistant

Hi, I run the FauxmoESP perfectly in Alexa. I would like to add automation to the ESP and I would like to integrate them into HA. Devices are recognised by HA as Hue lights, whish is good (I guess) but when I tried to integrate into HA, it tries to connect to the Hue bridge and after some seconds,  "failed connectioj" message appears. Is there any way to do the integration without changing the ESP8266 Nodemcu program?
Thanks a lot!
BR

I have never used HomeAssistant - hopefully someone else with experience with it can chime in!


Develop

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

155 of 155 (100.0%)  changed or added relevant lines in 4 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
155

Relevant Lines:
155

💛  - Coveralls


Wikipedia Viewer Zipline name doesn't match the naming convention of the other Ziplines.

Challenge http://www.freecodecamp.com/challenges/zipline-wikipedia-viewer has an issue.
The rest of the Zipline names start with a verb describing what the camper will be doing in a particular Zipline, ie. "Build a Random Quote Machine", "Show the Local Weather", "Use the Twitch.tv JSON API", whereas the Wikipedia Viewer Zipline is just called "Wikipedia Viewer". This Zipline needs a better name starting with a verb to match the naming convention. Something like, "Create a Wikipedia Viewer".
Screenshot:
![Zipline Screenshot][http://imgur.com/6GsO8f8.png]

Here's the screenshot. I can't seem to edit the post on my phone.


Add license title

It's not strictly required, but it's useful metadata, and part of the recommended license template text (see http://choosealicense.com/licenses/isc/ and https://opensource.org/licenses/isc-license)

I've been meaning to switch to an MIT license. Thanks though!

No problem :) glad this helped you finish a pending task!

By the way, why did you want to change to MIT?

By the way, why did you want to change to MIT?

For future reference, this was addressed in https://github.com/danreeves/react-tether/pull/36.


Fail to load swagger-ui assets

Hello @domaindrivendev
First thank you soooo much for the rewrite. I've edited my old request specs and it's work perfectly with query params. The json generated doesn't contain any errors when testing with http://editor.swagger.io/#/.
I have only one issue with swagger-ui.
When trying to go to /api-docs it gets lot's of missing assets like:
ActionController::RoutingError (No route matches [GET] "/assets/swagger-ui/images/favicon-32x32.png")

Page looks like :

also
$ rails g rswag:ui:custom_ui                                                                             [11:26:20]
Running via Spring preloader in process 19510
Could not find generator 'rswag:ui:custom_ui'. Maybe you meant 'rswag:ui:custom', 'rswag:ui:install' or 'rswag:install'
Run `rails generate --help` for more options.

Thanks for the quick feedback. Odd that the assets aren't working. Is this dev or prod? Do u def have asset pipeline enabled - can u access other assets in your app? Which version of Rails?
Re the generator, my bad I changed to "rswag:ui:custom" but have the old name in the docs. Will correct docs

It's in dev env. Rails <IP_ADDRESS>
In dev env :
  config.assets.compress = false
  config.assets.digest = false

No problem with the other assets of the app.

Tried with Rails 4.2.0 and still can't repro. Do you have the following line in your routes.rb:
mount Rswag::Ui::Engine, at 'api-docs'

Although I don't really think that should matter

@benoittgt - can you try upgrading to 1.0.1 and let me know if it works?

@domaindrivendev it's perfect now ! 👏🏻

Same problem in Rails 5 here with config.api_only = true. Also tried standardizing everything to /swagger with no change in results. Here's my current config:

Gemfile: gem 'rswag', '~> 1.1' also tried ~> 1.0
Swagger doc: ./swagger/v1/swagger.json
UI Initializer: c.swagger_endpoint '/v1/swagger.json', 'API V1 Docs'
API Initializer: c.swagger_root = Rails.root.to_s + '/swagger'
API Route: mount Rswag::Api::Engine => '/swagger'
UI Route: mount Rswag::Ui::Engine => '/swagger' and no difference with
mount Rswag::Ui::Engine, at: '/swagger'

I've also run into this and looks like the problem is inherent to API only application; only solution is to convert to a regular rails app: https://github.com/rails/rails/issues/24264

This PR fixes the issue https://github.com/domaindrivendev/rswag/pull/107

Uncomment this line in config/application.rb:
require "sprockets/railtie"

@ChrisSasarman You are absolutely right!. It solved! was using older version of rswag (was 1.4.0) in rails API only application and having exactly the same problem.
It can be solved either update to latest version (2.0.5) or Uncomment this line in config/application.rb:
require "sprockets/railtie"


docs/Troubleshooting: ask for full command line of failed commands in issues

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same change?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests for your changes? Here's an example.
[ ] Have you successfully run brew tests with your changes locally?

brew-gist-logs does not include build options, and sometimes users fail to provide them in issues, which is frustrating. Knowing what failed exactly is fundamental to any sort of troubleshooting.
Also improve the wording on gist-logs in a few places.

brew-gist-logs does not include build options, and sometimes users fail to provide them in issues, which is frustrating. Knowing what failed exactly is fundamental to any sort of troubleshooting.

May be worth investigating improving the tool to provide the information you need? I wouldn't rely on more than 50% of users reading the updated docs.

How about systematically logging the full command so that brew gist-logs reports it? Issue templates require users to paste the link to the gisted logs.

Agreed 👍

Right, closing in favor of fixing gist-logs.


Non conan, filter SeaBIOS control chars, detect reboots

Add requirements.txt and non-conan instructions
Add more error handling, especially for missing chainloader
Make grubify produce images at cwd, not next to binary, to allow direct boot of nix read-only binaries.
Filter out terminal control characters from SeaBIOS, which prevents us from detecting reboots

This has the nice side-effect of making your terminal not broken after running qemu

Detect and warn about reboots

For the SeaBIOS output, Zephyr had a bug about this as well:
https://github.com/zephyrproject-rtos/zephyr/issues/11717


Linking to multiple tags as a way of progressive filtering

Hello,
I wanted to check if it’s currently intended to link to stacked tags for progressive filtering?
In the sense that: /tags/fruits shows all #fruits, but e.g. /tags/fruits+berries shows only notes that are both #fruits and #berries. Stacking tags would probably require a format like tag1+tag2 or concatenation fruits/berries/fruits/citrus since tag hierarchies like fruits/berries (as a single tag) are already supported.
Is this already achievable or considered a feature idea?

Hi there, I think this is possible.
Are you thinking about for search or just general tag concatenation?

Mostly general tag concatenation in the explorer/via link. For larger content structures that have entries with multiple tags. So users can find and narrow down what they are looking for. It's probably not trivial because it might make sense to show the remaining number of available notes to filter. Say we have 5 fruits and 3 of these fruits are berries, one of those berries is red.
Nothing selected OR Fruits selected
Fruits (7)
Apples (2)
Berries (3)
Red (2)
Citrus (2)

Fruits AND Red selected
Fruits (2)
Apples (1)
Berries (1)
Red (2)
Citrus (0)

Meaning that the user can narrow down only one more time since there is only one entry for a either a berry or apple that is red. But in reality tag combinations that aren't possbile might just be removed, making it:
Fruits AND Red selected (tag combination that result in 0 removed)
Fruits (2)
Apples (1)
Berries (1)
Red (1)


No sound with ALSA on sample rates above 48000 Hz

This is an abandoned/unfixed bug repost from Mozilla's Bugzilla. The original report could be found here .
If system (sound card) sampling rate changed in ALSA from default value (48000) to something grater, sound stop working in a very odd way. Sampling rate could be changed by adding the following line to /etc/asound.conf (only works with sound cards that support that):
defaults.pcm.dmix.rate <samling_rate>
than restart ALSA and FF, open some video.
Firefox 60.8.0esr build from sources on actual Gentoo Linux.
Actual results:
YouTube work / Coub and most of music players no sound: 88200, 176400, 352800, 705600
Coub and most of music players work / YouTube no sound: 96000, 192000, 384000, 768000
At the moment I start playback on the page and no sound produced, the fallowing message can be seen (this is from older version):
[Child 10792, MediaPlayback #2] WARNING: 7fbdd402ac40 OpenCubeb() failed to init cubeb: file /var/tmp/portage/www-client/firefox-60.4.0/work/firefox-60.4.0/dom/media/AudioStream.cpp, line 388
[Child 10792, MediaPlayback #2] WARNING: Decoder=7fbdde253a60 [OnMediaSinkAudioError]: file /var/tmp/portage/www-client/firefox-60.4.0/work/firefox-60.4.0/dom/media/MediaDecoderStateMachine.cpp, line 3750
So, basically, sound work fine on most of YouTube videos and fail at Coub and many other players for the sampling rates that are multiples of 44100 and vice versa for sampling rates that are multiples of 48000. At the same time, mplayer and Audacious work perfect regardless sampling rate.
Google Chrome behaves the same, so I assumed it is related to libvpx (webm) and rebuild FF against system libvpx-1.5.0 - with no luck.
Pauld told me that this is an cubeb issue and some "good fix" needed, but it still present. Currently, more and more recent videos on YT have no sound, while older play fine. Since both coexist, there is no way to choose sampling rate (multiple of 44K2 or 48K) to cover the majority of cases.

The ALSA backend is no longer maintained, so someone will need to contribute their time to debug and fix this.  I posted a possible workaround in the linked Bugzilla bug.
If you wanted to try debugging further, I'd suggest starting by building the cubeb repository and experimenting with tools/cubeb-test.  It defaults to 44.1kHz stereo, but you can change that via command line.  Then you'd need to trace the code (in gdb or by adding printfs) to src/cubeb_alsa.c in alsa_stream_init_single and see where it's failing and why.  I'd guess we're bailing out after the snd_pcm_set_params call.
It may be that the simplest solution is to retrofit cubeb_resampler into the ALSA backend.  Or use the PulseAudio backend. 😬

The workaround did a trick.

@e-pirate can you please clarify which workaround solved this problem for you here? was it the suggested patch on Bugzilla? or was it switching over to pulse-rust backend?
many thanks

The workaround did a trick.

@e-pirate can you please clarify which workaround solved this problem for you here? was it the suggested patch on Bugzilla? or was it switching over to pulse-rust backend?
Set this in you FF configuration:


Deprecate and remove airline

Seems like airline is not used anymore by the majority of neovim users and it's the only remaining leftover for vimscript code. I am considering removing it and leaving just lightline as a custom option for now. I would like to hear some thoughts before moving on

I think this makes sense, keep things as lightweight ad possible. If you want to use airline then you could use the original gruvbox instead.

I'm using airline and I don't want to use lightline and spend a month trying to integrate all useful stuff into it. Do not really understand what is wrong with supporting it. It's absolutely the same as you support telescope or any other plugins except it requires to use vimscript instead of highlight groups - not that nice and clean, but still the same way conceptually. Would be nice it airline uses highlight groups also, it isn't that is life :)

hey @darkangel-ua i believe if you switch to a more modern statusline plugin like lightline or even lualine you will feel a lot better and definitely won't spend 1 month configuring it because they are really straightforward.  Seems that the majority of people using this particular repo are not using airline for their statusline plugin and i really want to make this plugin as lean as possible so i am probably moving forward with the change in the next few days

I still voting for removing airline.

I have moved to lualine and it's looking good.


gemini db not generated in v1.0.9

Hi Brad,
I've got a fresh install of bcbio v1.0.9, which runs smoothly. I only just noticed that there's no mention whatsoever of gemini db's in the work/final dir, nor in the log. It seems the step is skipped altogether.
I'm using the following config:
#bcbio-nextgen v1.0.9
---
#include an experiment name here
fc_name:
upload:
  dir: ../final
globals:
  analysis_regions: RefSeqExomeAndPanels.bed
  coverage_regions: RefSeqExomeAndPanels.bed
resources:
  tmp:
    dir: $SCRATCH/bcbio
details:
  - analysis: variant2
    genome_build: hg38
    description:
    metadata:
      batch:
    algorithm:
      aligner: bwa
      save_diskspace: true
      coverage_interval: regional
      coverage: coverage_regions
      mark_duplicates: true
      recalibrate: false
      realign: false
      variantcaller: gatk-haplotype
      variant_regions: analysis_regions
      exclude_regions: [altcontigs]
      jointcaller: gatk-haplotype-joint
      effects: vep
      effects_transcripts: all
      vcfanno: [eog,dbscsnv,dbnsfp]
      tools_on:
        - vep_splicesite_annotations
        - coverage_perbase
      tools_off:
        - gatk4
    # add the path to your files here
    files:

Any idea what could be causing this behaviour? Or could this be the same issue where no db's are generated if the "gemini" datatarget isn't installed?
Cheers
M

Matthias -- that's exactly right. bcbio skips gemini creation if you don't have the data files installed. Hopefully after installing them things will work as expected.

Hi Brad,
Thanks for the reply.
Since we don't do any analyses on b37 anymore, it doesn't really make sense to install the real "gemini" files. Is there a way the avoid having the storage overhead of unneeded files? At the moment I've been able to "fix" it by manually adding gemini to the install-params.yaml file, but that seems like an ugly hack to me.
Cheers
M

Geen probleem, doe maar!
Groeten
M
Op 17 apr. 2018, om 12:38 heeft Brad Chapman <notifications<EMAIL_ADDRESS>het volgende geschreven:
Matthias -- that's exactly right. bcbio skips gemini creation if you don't have the data files installed. Hopefully after installing them things will work as expected.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/bcbio/bcbio-nextgen/issues/2370#issuecomment-381942469, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ALTTkMz7c1wRDfvhz7dp3JvSUX4tzmjvks5tpcY_gaJpZM4TYCni.

Matthias;
Thanks for following up on this. The --datatarget gemini flag installs exac and esp for hg38, so would be needed in order to have the full set of GEMINI annotations and bcbio should only install the other GEMINI data if you have hg19 or GRCh37 installed.
So I think bcbio will do the right thing and only add the hg38 data files to an hg38 only install. Are you finding it has different behavior from that? Thanks again for this feedback.

Oh, that explains a lot. I hadn't really paid much attention to it, since we don't use the "gemini" annotations, since all of the data is already in the VEP annotations
Thanks for the info!
Cheers
M


Pre release v0.4.0

Codecov Report
Patch coverage: 100.00% and project coverage change: +0.79% :tada:

Comparison is base (7e9b7da) 98.66% compared to head (b5bf442) 99.45%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #17      +/-   ##
==========================================
+ Coverage   98.66%   99.45%   +0.79%
==========================================
  Files          30       14      -16
  Lines         601      185     -416
==========================================
- Hits          593      184     -409
+ Misses          8        1       -7

Files Changed
Coverage Δ

version.go
100.00% <100.00%> (ø)

... and 16 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Adding a hyphen breaks autocomplete

When I start typing, I get autocomplete suggestions. Here I'm going to add a padding, px:

But, when I add hyphen (-) the px styles disappear:

The current example is in Vue, but I've also got the same behavior in React.

Hi, this issue is marked as solved but I'm still experiencing the problem with the version 0.5.7. In my case, when I add -, nothing is shown.


Visualise predictions

Visualise predictions by comparing pv yield predictions with the truth.
Could also at the end of a training run / end of each epoch save plot these to neptune

Don't worry, the code already plots a comparison of the prediction vs the ground truth during the validation runs, and sends this plot to Neptune :)

Taken from https://app.neptune.ai/o/OpenClimateFix/org/predict-pv-yield/e/PRED-99/all?path=validation%2Fplot&attribute=epoch6

Ah, ok, maybe I need to turn that back on
I wanted a few extra things too, like this

nice!
(And I think that behaviour is quite common in CNN models when used for nowcasting:  It learns to draw a pretty accurate 'straight line', but doesn't get the high-frequency changes due to small clouds moving overhead, possibly because the CNN can't learn to 'focus' on the most relevant pixels of the image!  CNNs with pooling are great for image classification, where it's fine to throw away precise positional information (who cares where exactly the dog is in the image?!) but, for nowcasting, I think attention is pretty important to learn to dynamically focus on the important pixels.... sorry, this is a bit off-topic for this issue!)

No, I agree, the CNN probably are not be powerful enough here, I'm interested to get this plotting for the Perciever Model

get this plotting for the Perciever Model

That'd be awesome!  So cool to see this stuff coming together!  Thank you!

Yea, just slowly adding more and more tooling which will all be useful


signMessage costs gas fees

Environment
A react website using the signMessage api in the MyNearWallet/Web Wallet flow on mainnet.
Problem
Gas fee charges occur on the wallet
Expected Behaviour
No charges should happen as this function just verifies the owner of the wallet with a message.
on other wallets/blockchains this does not cost gas
Steps to reproduce

setup the https://www.npmjs.com/package/@near-wallet-selector/my-near-wallet in a react app
set it to use network: 'mainnet', - this is the only change from this flow:
https://github.com/near/wallet-selector/tree/main/examples/react
and this is the second change we did:
export const NEAR_CONTRACT_ID = 'lavanetxyz.near' //'guest-book.testnet'
then execute this after wallet login from the react website:

    localStorage.setItem(
      'message',
      JSON.stringify({
        message,
        nonce: [...Array.from(message)],
        recipient,
        callbackUrl: GetConnectionProgressUrlNearWallet(),
      }),
    )
    signedMessage = await wallet.signMessage({
      message,
      nonce,
      recipient,
    })

ok just tested again this behaviour happens when logging in with sender wallet - could not reproduce it with the webwallet. So this happens after the log in - without even using the signMessage api.
same flow using the connect your wallet as done in the example on the github.
Picture before login:

Picture after logging in:

The add key Txn which cost money:
https://nearblocks.io/address/8b868c694970076635394ce22f719b7f8eef3e18396d31c30ad7d85f26cc7b55

Link to conversation on the neardev telegram:
https://t.me/neardev/43748


unbound stats page leads to memory leak -> OOM kill

Important notices
Before you add a new report, we ask you kindly to acknowledge the following:

[x] I have read the contributing guide lines at https://github.com/opnsense/core/blob/master/CONTRIBUTING.md
[x] I am convinced that my issue is new after having checked both open and closed issues at https://github.com/opnsense/core/issues?q=is%3Aissue

Describe the bug
We are running DEC3850 with opnsense community 23.7.7_3.
Our unbound or more likely the unbound logger, has a memory leak when we click on Reporting -> Unbound DNS.
It takes about 3-4 minutes for the logger and unbound processes to crash.
We have a guess that this happend as we enabled the unbound blocklist and blocked two domains that are queried 10+ times / second (badly configured CPEs). Bascially 98% of all DNS queries were blocked. We even removed the blocklist (still present in the logs below) and disabled it, but the stats page still fails to load.
Also unbound has about 1k locally configured overrides for DNS. But I guess that should not impact anything.
To Reproduce
Steps to reproduce the behavior:

Click on Webinterface -> Reporting -> Unbound DNS
Page fails to render, webinterface becomes unresponsive

Expected behavior
No memory leak and instead show the unbound stats.
Describe alternatives you considered
Relevant log files
system log show:
<13>1 2023-11-30T11:44:08+01:00 fw-1 kernel - - [meta sequenceId="1"] swap_pager: out of swap space
<13>1 2023-11-30T11:44:08+01:00 fw-1 kernel - - [meta sequenceId="2"] swp_pager_getswapspace(16): failed
<13>1 2023-11-30T11:44:15+01:00 fw-1 kernel - - [meta sequenceId="3"] <3>pid 26576 (python3.9), jid 0, uid 0, was killed: failed to reclaim memory
<13>1 2023-11-30T11:44:17+01:00 fw-1 kernel - - [meta sequenceId="4"] <3>pid 25333 (python3.9), jid 0, uid 0, was killed: failed to reclaim memory
<13>1 2023-11-30T11:44:18+01:00 fw-1 kernel - - [meta sequenceId="5"] <3>pid 99583 (unbound), jid 0, uid 59, was killed: failed to reclaim memory
<13>1 2023-11-30T11:44:19+01:00 fw-1kernel - - [meta sequenceId="6"] <3>pid 3444 (python3.9), jid 0, uid 0, was killed: failed to reclaim memory

resolver log:
<29>1 2023-11-30T12:53:41+01:00 fw-1 unbound 14574 - [meta sequenceId="1"] [14574:0] notice: init module 0: python
<29>1 2023-11-30T12:53:41+01:00 fw-1 unbound 14574 - [meta sequenceId="2"] [14574:0] notice: init module 1: iterator
<30>1 2023-11-30T12:53:41+01:00 fw-1 unbound 14574 - [meta sequenceId="3"] [14574:0] info: start of service (unbound 1.18.0).
<30>1 2023-11-30T12:53:41+01:00 fw-1 unbound 14574 - [meta sequenceId="4"] [14574:2] info: dnsbl_module: attempting to open pipe
<30>1 2023-11-30T12:53:41+01:00 fw-1 unbound 14574 - [meta sequenceId="5"] [14574:2] info: dnsbl_module: no logging backend found.
<165>1 2023-11-30T12:53:43+01:00 fw-1 unbound 18591 - [meta sequenceId="6"] Backgrounding unbound logging backend.
<30>1 2023-11-30T12:53:51+01:00 fw-1 unbound 14574 - [meta sequenceId="7"] [14574:1] info: dnsbl_module: attempting to open pipe
<30>1 2023-11-30T12:53:51+01:00 fw-1 unbound 14574 - [meta sequenceId="8"] [14574:1] info: dnsbl_module: successfully opened pipe

Environment
Software version used and hardware type if relevant, e.g.:
DEC3850
opnsense community 23.7.7_3.

Via "System: Diagnostics: Activity" you can track the processes needing a lot of memory, sort by "RES" shows the current allocation per process id.

Hi,
thanks for the fast response. Without clicking the reporting I can see the following top processes:
        62538	unbound	21	0	1475M	249M	kqread	2	11:31	1.86%	/usr/local/sbin/unbound -c /var/unbound/unbound.conf{unbound}
	62538	unbound	20	0	1475M	249M	kqread	0	11:20	1.78%	/usr/local/sbin/unbound -c /var/unbound/unbound.conf{unbound}
	62538	unbound	20	0	1475M	249M	kqread	4	11:52	1.71%	/usr/local/sbin/unbound -c /var/unbound/unbound.conf{unbound}
	62538	unbound	20	0	1475M	249M	CPU1	1	11:23	1.61%	/usr/local/sbin/unbound -c /var/unbound/unbound.conf{unbound}
	62538	unbound	20	0	1475M	249M	kqread	3	11:30	1.57%	/usr/local/sbin/unbound -c /var/unbound/unbound.conf{unbound}
	62538	unbound	20	0	1475M	249M	kqread	0	11:15	1.50%	/usr/local/sbin/unbound -c /var/unbound/unbound.conf{unbound}
	62538	unbound	20	0	1475M	249M	kqread	1	11:19	1.41%	/usr/local/sbin/unbound -c /var/unbound/unbound.conf{unbound}
	62538	unbound	20	0	1475M	249M	kqread	6	11:16	1.36%	/usr/local/sbin/unbound -c /var/unbound/unbound.conf{unbound}
	66763	root	24	0	330M	218M	kqread	5	48:08	2.29%	/usr/local/bin/python3 /usr/local/opnsense/scripts/unbound/logger.py (python3.9){python3.9}
	66763	root	52	0	330M	218M	usem	5	0:00	0.00%	/usr/local/bin/python3 /usr/local/opnsense/scripts/unbound/logger.py (python3.9){python3.9}
	66763	root	52	0	330M	218M	usem	3	0:00	0.00%	/usr/local/bin/python3 /usr/local/opnsense/scripts/unbound/logger.py (python3.9){python3.9}
	66763	root	52	0	330M	218M	usem	4	0:00	0.00%	/usr/local/bin/python3 /usr/local/opnsense/scripts/unbound/logger.py (python3.9){python3.9}
	66763	root	52	0	330M	218M	usem	6	0:00	0.00%	/usr/local/bin/python3 /usr/local/opnsense/scripts/unbound/logger.py (python3.9){python3.9}
	66763	root	52	0	330M	218M	usem	7	0:00	0.00%	/usr/local/bin/python3 /usr/local/opnsense/scripts/unbound/logger.py (python3.9){python3.9}
	66763	root	52	0	330M	218M	usem	4	0:00	0.00%	/usr/local/bin/python3 /usr/local/opnsense/scripts/unbound/logger.py (python3.9){python3.9}
	66763	root	52	0	330M	218M	usem	4	0:00	0.00%	/usr/local/bin/python3 /usr/local/opnsense/scripts/unbound/logger.py (python3.9){python3.9}
	66763	root	52	0	330M	218M	uwait	6	0:00	0.00%	/usr/local/bin/python3 /usr/local/opnsense/scripts/unbound/logger.py (python3.9){python3.9}
	66763	root	52	0	330M	218M	uwait	5	0:00	0.00%	/usr/local/bin/python3 /usr/local/opnsense/scripts/unbound/logger.py (python3.9){python3.9}
	66763	root	52	0	330M	218M	uwait	7	0:00	0.00%	/usr/local/bin/python3 /usr/local/opnsense/scripts/unbound/logger.py (python3.9){python3.9}
	66763	root	52	0	330M	218M	uwait	4	0:00	0.00%	/usr/local/bin/python3 /usr/local/opnsense/scripts/unbound/logger.py (python3.9){python3.9}
	66763	root	52	0	330M	218M	uwait	5	0:00	0.00%	/usr/local/bin/python3 /usr/local/opnsense/scripts/unbound/logger.py (python3.9){python3.9}
	66763	root	52	0	330M	218M	uwait	4	0:00	0.00%	/usr/local/bin/python3 /usr/local/opnsense/scripts/unbound/logger.py (python3.9){python3.9}
	66763	root	52	0	330M	218M	uwait	5	0:00	0.00%	/usr/local/bin/python3 /usr/local/opnsense/scripts/unbound/logger.py (python3.9){python3.9}
	66763	root	52	0	330M	218M	uwait	6	0:00	0.00%	/usr/local/bin/python3 /usr/local/opnsense/scripts/unbound/logger.py (python3.9){python3.9}
	98336	root	52	0	84M	45M	accept	4	0:03	0.00%	/usr/local/bin/php-cgi

this looks pretty normal to me and we have no problem during normal operation. I do not want to trigger the memleak as it will create a service disruption...

looks rather normal indeed. If this machine is very busy serving questions, the size of the duckdb database underneath might be problematic. If it crashes out on reading the database, the logger might be a mere victim of not having enough memory available.

root@fw-1:/var/unbound/data # ls -alh /var/unbound/data/unbound.duckdb
-rw-r-----  1 unbound  unbound   1.0G Dec  5 13:38 /var/unbound/data/unbound.duckdb

the database looks pretty sane to me

could be, you probably have to inspect top while causing the issue. as duckdb can't be accessed simultaneously, the logger needs to "stash" while being used by the viewer (not something we can solve, it's a limitation of duckdb).

72791	root	22	0	15G	7G	RUN	5	0:05	12.90%	/usr/local/bin/python3 /usr/local/opnsense/scripts/unbound/stats.py rolling --interval 600 --timeperiod 24 --clients (python3.9){python3.9}
stats.py is eating all available memory and crashing. I have no idea why as the blocklist is disabled for over a week now. duckdb grew to 8,6G.

you could try to cleanup the database using https://github.com/opnsense/core/issues/7049#issuecomment-1851751168 , but realistically I wouldn't be surprised if your traffic might need more resources than available.

the fix just fryed my opnsense as nearly everything got oomkilled. Had to reboot for it to recover


Format code using 'cargo fmt'

Duplicate of #99
Sorry, I still think that we can't simply apply standard formatting everywhere. Especially test data of request and reply types and comments in abi types are much less readable this way.
The modernize PR #126 will address most of the formatting issues as well though.


uninstall longhorn 0.3.0 failed

I tried to uninstall longhorn 0.3.0, but ns longhorn-system is always waiting to be deleted. When I run
> kubectl delete ns longhorn-system Error from server (Conflict): Operation cannot be fulfilled on namespaces "longhorn-system": The system is ensuring all content is removed from this namespace.  Upon completion, this namespace will automatically be purged by the system.
Other Info
> kubectl describe ns longhorn-system
Name:         longhorn-system
Labels:       field.cattle.io/projectId=p-clhh4
Annotations:  cattle.io/status={"Conditions":[{"Type":"InitialRolesPopulated","Status":"True","Message":"","LastUpdateTime":"2018-08-24T10:44:15Z"},{"Type":"ResourceQuotaInit","Status":"True","Message":"","LastUpda...
              field.cattle.io/creatorId=u-j88t5
              field.cattle.io/projectId=c-c8hph:p-clhh4
              lifecycle.cattle.io/create.namespace-auth=true
Status:       Terminating

No resource quota.

No resource limits.

> kubectl -n longhorn-system get volumes.longhorn.rancher.io
NAME                                       AGE
pvc-b55e0e0d-a78c-11e8-891a-fa163e532171   1d
> kubectl -n longhorn-system get engines.longhorn.rancher.io
error: the server doesn't have a resource type "engines"
> kubectl -n longhorn-system get replicas.longhorn.rancher.io
error: the server doesn't have a resource type "replicas"
> kubectl -n longhorn-system get engineimages.longhorn.rancher.io
NAME          AGE
ei-3bda103d   1d
> kubectl -n longhorn-system get nodes.longhorn.rancher.io
error: the server doesn't have a resource type "nodes"

> kubectl -n longhorn-system describe volumes.longhorn.rancher.io
Name:         pvc-b55e0e0d-a78c-11e8-891a-fa163e532171
Namespace:    longhorn-system
Labels:       longhornvolume=pvc-b55e0e0d-a78c-11e8-891a-fa163e532171
Annotations:  <none>
API Version:  longhorn.rancher.io/v1alpha1
Kind:         Volume
Metadata:
  Creation Timestamp:             2018-08-24T10:59:12Z
  Deletion Grace Period Seconds:  0
  Deletion Timestamp:             2018-08-25T15:26:38Z
  Finalizers:
    longhorn.rancher.io
  Generation:        2
  Resource Version:  13528549
  Self Link:         /apis/longhorn.rancher.io/v1alpha1/namespaces/longhorn-system/volumes/pvc-b55e0e0d-a78c-11e8-891a-fa163e532171
  UID:               bc2cde1e-a78c-11e8-adea-fa163e704c5b
Spec:
  Base Image:
  Engine Image:           rancher/longhorn-engine:v0.3.0
  From Backup:
  Frontend:               blockdev
  Migration Node ID:
  Node ID:
  Number Of Replicas:     3
  Owner ID:               xxxxxxxxxxxxxxxxxx(my node host name)
  Recurring Jobs:         <nil>
  Size:<PHONE_NUMBER>
  Stale Replica Timeout:  30
Status:
  Conditions:
    Scheduled:
      Last Probe Time:
      Last Transition Time:  2018-08-24T10:59:12Z
      Message:
      Reason:                ReplicaSchedulingFailure
      Status:                False
      Type:                  scheduled
  Current Image:             rancher/longhorn-engine:v0.3.0
  Robustness:                unknown
  State:                     detached
Events:                      <none>

> kubectl -n longhorn-system describe engineimages.longhorn.rancher.io
Name:         ei-3bda103d
Namespace:    longhorn-system
Labels:       <none>
Annotations:  <none>
API Version:  longhorn.rancher.io/v1alpha1
Kind:         EngineImage
Metadata:
  Creation Timestamp:             2018-08-24T10:44:19Z
  Deletion Grace Period Seconds:  0
  Deletion Timestamp:             2018-08-25T15:24:09Z
  Finalizers:
    longhorn.rancher.io
  Generation:        2
  Resource Version:  13528236
  Self Link:         /apis/longhorn.rancher.io/v1alpha1/namespaces/longhorn-system/engineimages/ei-3bda103d
  UID:               a778921e-a78a-11e8-a42e-fa163e704c5b
Spec:
  Image:     rancher/longhorn-engine:v0.3.0
  Owner ID:  xxxxxxxxxxxxxxxxxx(my node host name)
Status:
  Build Date:                  2018-08-23T21:00:34+00:00
  Cli API Min Version:         1
  Cli API Version:             1
  Controller API Min Version:  1
  Controller API Version:      1
  Data Format Min Version:     1
  Data Format Version:         1
  Git Commit:                  5904720ea07dd497766c9767b0e4069b4cce87df
  No Ref Since:                2018-08-24T10:45:19Z
  Ref Count:                   0
  State:                       ready
  Version:                     v0.3-rc5
Events:                        <none>
> kubectl -n longhorn-system delete volumes.longhorn.rancher.io --all
volume.longhorn.rancher.io "pvc-b55e0e0d-a78c-11e8-891a-fa163e532171" deleted
> kubectl -n longhorn-system delete volumes.longhorn.rancher.io --all
volume.longhorn.rancher.io "pvc-b55e0e0d-a78c-11e8-891a-fa163e532171" deleted
> kubectl -n longhorn-system delete volumes.longhorn.rancher.io --all
volume.longhorn.rancher.io "pvc-b55e0e0d-a78c-11e8-891a-fa163e532171" deleted
> kubectl -n longhorn-system delete engineimages.longhorn.rancher.io --all
engineimage.longhorn.rancher.io "ei-3bda103d" deleted
> kubectl -n longhorn-system delete engineimages.longhorn.rancher.io --all
engineimage.longhorn.rancher.io "ei-3bda103d" deleted
> kubectl -n longhorn-system delete engineimages.longhorn.rancher.io --all
engineimage.longhorn.rancher.io "ei-3bda103d" deleted
> kubectl -n longhorn-system delete nodes.longhorn.rancher.io --all
error: the server doesn't have a resource type "nodes"

In https://github.com/rancher/longhorn#uninstall-longhorn , we asked the user toMake sure all reports No resources found. before continuing. Seems in your case, the manager was deleted before all the resource has been completed cleaned up. If there is no manager to clean up the resources, the resource will stuck in the namespace.
To workaround it for now, you can use kubectl edit for remaining resources, in your case, volume and engine image, and remove the entry underfinalizer. That should unblock the deletion process.

Thanks, it's work fine!


[Bug] Starting a stream starts dropping packets and lagging the stream when in voicechat.

Describe the Bug
Starting a stream starts dropping packets and lagging the stream when in voicechat.
To Reproduce
Get into a call, start streaming and talking at the same time, either the talking or the streaming will no longer function properly, sometimes both.
Discord Version
Stable, Canary
Additional Context
Speedtested the internet and streamed on bone stock discord (PTB) without issues.

I am unable to reproduce this


Update s3, sdk-core, sqs to 2.20.126

About this PR
📦 Updates

software.amazon.awssdk:s3
software.amazon.awssdk:sdk-core
software.amazon.awssdk:sqs

from 2.17.295 to 2.20.126
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "software.amazon.awssdk" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "software.amazon.awssdk" }
}]

labels: library-update, early-semver-minor, semver-spec-minor, commit-count:1

Superseded by #651.

Superseded by #652.


Mis use of printer

In mouse.h, lines 404 to 408 should use Serial and not printer.
Sometimes Serial and printer are not the same.

Oh yes. So it should.
Thank you for pointing that out.
I will fix it.


Need to Add Security Headers and CORS Policies

As a service provider
I need my service to use security headers and CORS policies
So that my web site is not vulnerable to CORS attacks
Assumptions

Flask-Talisman will be used for security headers
Flask-Cors will be used to establish cross-origin resource sharing (CORS) policies

Acceptance Criteria
Given the site is secured
When a REST API request is made
Then secure headers and a CORS policy should be returned


Documentation refactor

Description

Provide a summary of the modification as well as the issue that has been resolved. List any dependencies that this modification necessitates.
Fixes #348 #304

Changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] Refactor (non-breaking change which refactors the code base)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Checklist

[ ] My code follows the pre-commit style and check guidelines of this project.
[ ] I have performed a self-review of my code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing tests pass locally with my changes

maybe #544 could be integrated here?
(tbh i didnt read it all so if it's already in there just ignore the comment)

Minor comments

@djdameln, thanks for the review. I've addressed all of your comments.


Fts issue 1

I noticed that node 0 could not be crashed with the current selection method. The reason for it is that the array is initialized with all zeroes and the criteria for being chosen for crashing is that the node id is not yet in the array. Since the array always contains 0 to begin with it could not be chosen.
I fixed this by simply initializing the array to be all -1. Consider using a set instead of an array and simply add to the set and it has a built in contains method.

Good catch! Now merged


Why tcpip wireless connection gets revoked after a while?

Everytime I establish a connection through tcpip with my device it works fine for a couple of days or so, then at some point it needs me to re-establish the connection through USB all over again. is there a way to make the connection last without having to connect the phone via USB every couple of days?
does this have to do with phone settings?

It's reset after a phone reboot. You can't preserve adb tcpip 5555 unless your device is rooted.

It's reset after a phone reboot. You can't preserve adb tcpip 5555 unless your device is rooted.

I have root, How do I do it? Preferably using termux.

https://android.stackexchange.com/questions/232082/how-can-i-enable-android-debugging-from-a-root-shell-on-the-phone/232083#232083

can you help me please how to install scrcpy in termux:(