Simplify initialization of max_seq_no of updates

Today we choose to initialize max_seq_no_of_updates on primaries only
so we can deal with a situation where a primary is on an old node
(before 6.5) which does not have MUS while replicas on new nodes (6.5+).
However, this strategy is quite complex and can lead to bugs (for
example #40249) since we have to assign a correct value (not too low)
to MSU in all possible situations (before recovering from translog,
restoring history on promotion, and handing off relocation).
Fortunately, we don't have to deal with this BWC in 7.0+ since all
nodes in the cluster should have MSU. This change simplifies the
initialization of MSU by always assigning it a correct value in
the constructor of Engine regardless of whether it's a replica or
primary.
Relates #33842
Port of https://github.com/elastic/elasticsearch/pull/41161

Pending the merge of https://github.com/crate/crate/pull/9401
Until then this will break


Add prefix config option to allow a diagram prefix

Tools like this: https://lib.rs/crates/mdbook-kroki-preprocessor also support kroki diagrams inside fenced code blocks.  But in this case, they use a prefix in front of the diagram name.  This PR adds an optional prefix parameter which allows easy compatibility with tools like this.
There was also a bug with handling of config values, so I had to fix that as well.

Was just about to look into why the url config value set in the configuration is not used... thank you for the timely pull request to fix this alongside the new feature.

Hello and happy new year! Any chance the extension can be published with these changes? Thanks.

@pomdtr would you be able to take a look and merge this PR if it fits within what you would like to do with this extension? My use-case is to have simpler compatibility with https://github.com/AVATEAM-IT-SYSTEMHAUS/mkdocs-kroki-plugin which defaults to a fence prefix of kroki-

Sorry, not sure why but I missed the notification. I'll take a look tomorrow, thanks for you contribution

Looks like I'm pinged with mention, but not on new pull request. I'll fix that


RFC: Events

Rendered RFC
Changes:

2016-12-13 Add usage section, unresolved question, and cleanup

I like the idea of "events" (though the terminology is a bit confusing cf. VBA Events).
However I am unclear what the technical method will be for calling "event" handlers. I assume it will not use VBA events (because they need the user code to be in Class Modules) but call procedure by name has other issues. Perhaps we need to consider how to offer both methods.

Hi @Sophist-UK I am referring to adding native VBA Events. It avoids CallByName or Application.Run for compatibility reasons and user code for standard operations won't need to be in Class Modules, it's just for extensions that need to hook into the Event system, of which Authenticators were already classes. For custom formatters, the existing system of Application.Run will most likely remain, but it may be redesigned in a future RFC to take advantage of the new Event system.

Ah - so it will be using  VBA Events - excellent, as this is well architected VBA functionality.

Comments crossed - sounds good.


Blender gets stuck at core_create_Models

I tried loading a protein called 1qx7 and it froze Blender to death – I did this a couple of times. Then I tried loading another molecule – this time from test molecules provided with BioBlender,  03_3IV5_DNA_proteinComplex.pdb – and I still have the same problem. I know that some weeks ago, I could load a molecule without having this problem.
Loading Test molecule 02_4IHVonlyDNA.pdb works because it seems more simple. Though I only see one sphere as a result. And it's only when I start the embed game engine that I see many spheres moving.
When that issue arises, Blender gets stuck at "core_create_Models" so if I understand this, the meshing part is concerned.
PDB String
Bootstrapping
create_fi_materials
get_new_PDB_id
appending file
appending file
Import Preview
Import Ready: True
core_import_File
get_num_model: [0]
core_parse_pdb
A
core_sort_hr
appending file
core_create_Models

are you using BioBlender-master ?

03_3IV5_DNA_proteinComplex.pdb works in BioBlender-master and takes roughly 4 minutes to load and rig. on a slow machine.  (2.4ghz) -- for this period of time Blender is as good as frozen, this is to be expected. There's no multi-threading going on.
The various debug print statements will slow it down too, I can remove those from master, but I doubt they contribute by any great amount compared to the ridiculous amount of repeated object updates. I estimate that as much as 95% of the processing time is spend on updating the scene and all objects over and over again when each new rigid-body constraint is added)
As for 1qx7 , if it seems like it's frozen it's because it's busy with currently no way to show you how much progress is being made.

Yes I am using the master branch.
I'm testing an external 4K monitor atm, I wonder if it could affect performances but mesh creation depends on the cpu, not the gpu if I'm not mistaken. I have no cpu-intensive thread running and I have a 3.5Ghz iMac. Even so, Blender is stuck for more than 5 minutes. I kill it at some point.
I don't think the print statement are a problem since you have to run Blender from the line command to have console output.
There is no clear documentation on the Blender side as to how to process a lot of meshes efficiently in python so it's a bit of a guess. If possible, I'd try to remove updating the scene for every rigid body created and I would update it only after they're created. Or even better, linking the objects to the scene only when the import is complete – again if that's possible.
Or maybe show a placeholder empty and let it load in background...Amateurish conceptual idea again.

BioBlender-master (addon) is not ready for consumption. When BioBlender was implemented as a Patch in C/C++ it was able to set the scene and hold off on the update (and the chained effect that has) until the last moment. Development then switched to python instead of custom builds, with the hope that it would allow more convenient implementation. For whatever reason that development was stopped, and the current state is, as you can tell, quite rough. With no-one working on it for about 2 years (from what I can summize) this repo is an attempt to throw it a life-vest.
after about 15 minutes 1qx7 gives the error:
appending file
core_create_Models
Import Failed: ('Unable to generate 3D model from PDB File', KeyError('bpy_prop_collection[key]: key "O" not found',))

obviously i'm not going to want to wait 15 minutes too often, so a solution to the exceeding slow scene-graph update is essential to the future..

The file contains selenocysteines, I am not sure BioBlender is equipped to deal with selenium.

When I read the 4000 lines of code python file, I got the feeling of the life-vest alright. I will be of no help in the C++ realm though.
I thought it could be ready for consumption in given scenarios since some visualisation were produced with BioBlender but I now see that may not be possible in its current state. The project is very interesting though.

@nantille
It has been very tempting to start from scratch after 3 weeks of reading the current code base. Not only split the 4k file to smaller manageable pieces, but dramatically change the structure. I may still do that.. but I haven't really experimented exhaustively with the current code.

@MonZop you are correct
core_createModels()
0
Import Failed: ('Unable to generate 3D model from PDB File', KeyError('bpy_prop_collection[key]: key "SE" not found',))

It has been very tempting to start from scratch after 3 weeks of reading the current code base. Not only split the 4k file to smaller manageable pieces, but dramatically change the structure. I may still do that.. but I haven't really experimented exhaustively with the current code.

I think that is a good idea. It might also be a good idea to move away from third party packages and try to write only the things that we need from scratch.

I'm not ready to ditch the existing code yet, it may be possible to significantly speed up the set up of the  rigidbody simulation by first carefully constructing the (a)cyclic dependency graph(s) so those structures are separate first, then joined resulting in (i think) a considerable redux in time. That would at least address a major concern that @MonZop has.

The idea of re-designing BioBlender might be a good one.
We started by fixing (trying to) the existing porogram because we considered it a fast way to provide BioBlender functions to users. If we are going to restart from scratch, then this operation of getting the program running can be considered a sort of exercise to get familiar with the concepts of molecular biology and the visualization idea that is behind it. It is also good to have the program usable while we work at a new version.
My gratitude to the volunteers that are providing help is growing daily, and has laready reached a size beyond description.


Control cooling

Hi,  we have a "Sole/Wasser-Wärmepumpe Geoblock WGN" heat pump which allows cooling. The rest works almost flawless (just the "Vorlauftemperatur" of "Heizkreis.2" is incorrect, it shows the one from the heat pump instead), but there neither reading of the cooling nor writing as that is on another subpage ("Heizkreis 2"). That would be a quite urgend issue for us: the default setting react only to the outside (instead of inside) temperatur to prevent condensate and therefore disable cooling frequently...
If someon gives me some basic Information how to switch to another subpage (as generate_form_data switches to Expert mode) , then I can also try to add that myself.

Okay, it was rather easy to replace the Info Page with another one. Combining will be some overhead and I Do not see how to make that in higher generality. So lets directly close it

Okay, it was rather easy to replace the Info Page with another one. Combining will be some overhead and I Do not see how to make that in higher generality. So lets directly close it


E2e desktop fixes

Summary

Ticket Link

Checklist

[ ] Added or updated unit tests (required for all new features)
[ ] Has UI changes
[ ] read and understood our Contributing Guidelines
[ ] completed Mattermost Contributor Agreement
[x] executed npm run lint:js for proper code formatting

Device Information
This PR was tested on:
Screenshots

Release Note

/update-branch


Is it possible to require a model relationship?

If I create a node using a model, the relationship does not have to be defined upon creation. Is it possible to force the relationship property to be required when creating a node using createOne?
My idea would be using beforeCreate to check if the relationship is defined and throw an error otherwise, but maybe @themetalfleece has a better option in mind? Best case I would like Typescript to handle this, not the JS runtime. Can I somehow cast the Neogma relationship types to accomplish this?

I had encountered same problem but ended up writing my own wrapper over neogma which does generate all models and types, and conducts relations validations
I tried to combine best of two worlds: ts' type safety and rails efficiency
Can you take a look ? I think it may solves your problem -  neogen

@Ansis100  I had encountered same problem but ended up writing my own wrapper over neogma which does generate all models and types, and conducts relations validations
I tried to combine best of two worlds: ts' type safety and rails efficiency
Can you take a look ? I think it may solves your problem -  neogen

It looks like a great option for managing the models, thanks! However, our project is quite big and migrating to a different model scheme would take a great deal of effort. I might think about implementing it when refactoring.
Currently we're just looking to modify one of our models with this functionality.

Hey! That's a nice idea :) It's currently not supported in neogma, however I will consider adding it.
What I'm thinking as a workaround is creating a wrapper for createOne, while changing its type.
I.e.
    type CreateParamsI = Parameters<typeof Users.createOne>[0];
    interface UsersStaticsI {
      createWithOrder: (
        userWithOrder: CreateParamsI & Required<Pick<CreateParamsI, 'Orders'>>,
      ) => Promise<UsersInstance>;
    }

   ...after Model definition

    Users.createWithOrder = (userWithOrder) => {
      return Users.createOne(userWithOrder);
    };

Let me know what do you think about this 👀


ltex fails to update configuration

When trying to add false positives or disable a rule in ltex, it returns the error:
E5108: Error executing lua ...taller/lua/nvim-lsp-installer/servers/ltex/configure.lua:14: attempt to index local 'f' (a nil value)
I'm using LunarVim, but I don't think it affects the configuration, I'm using require'lvim.lsp.manager'.setup("ltex", {}), that should just load the default config from lspconfig

It was removed in preparation of new code, but it appears to never have been finished. It was inteded to go into https://github.com/brymer-meneses/grammar-guard.nvim (https://github.com/brymer-meneses/grammar-guard.nvim/issues/4) and @mjlbach indicated that is the best path forward: https://github.com/neovim/nvim-lspconfig/pull/863#issuecomment-928004061 and https://github.com/brymer-meneses/grammar-guard.nvim/issues/5#issuecomment-954809067
@lbiaggi was working on backing porting the local command handlers to the new 5.1 API. This handles things like marking false positives, etc. (the code that was removed from the lspconfig PR). He may have run out of time to work on it (and maybe is using the coc plugin).
The code in this repo works with a small change
diff --git a/lua/nvim-lsp-installer/servers/ltex/configure.lua b/lua/nvim-lsp-installer/servers/ltex/configure.lua
@@ -126,9 +126,9 @@ configs.ltex = {
         root_dir = function(filename)
             return util.path.dirname(filename)
         end,
-        dictionary_files = { ["en"] = { vim.fn.getcwd() .. "dictionary.ltex" } },
-        disabledrules_files = { ["en"] = { vim.fn.getcwd() .. "disable.ltex" } },
-        falsepositive_files = { ["en"] = { vim.fn.getcwd() .. "false.ltex" } },
+        dictionary_files = { ["en"] = { vim.fn.getcwd() .. "/dictionary.ltex" } },
+        disabledrules_files = { ["en"] = { vim.fn.getcwd() .. "/disable.ltex" } },
+        falsepositive_files = { ["en"] = { vim.fn.getcwd() .. "/false.ltex" } },
         settings = {
             ltex = {
                 enabled = { "latex", "tex", "bib", "markdown" },

However, there seems to be some bugs around ltex actually respecting the files contents.
In short, I think you can remove the handlers from this repo (go to what the lsp-config PR is now). That makes ltex work but does not handle it's local commands. Folks should use grammar-guard.nvim (after it is extended) to get the local commands.

Thanks for the context @abalmos! Updated the server config to follow upstream changes. Once the lspconfig PR is merged we can remove the overrides and only provide cmd in this plugin


LBTM

Can you add a description and appropriate title?

What does LBTM mean?
I need a better title, then I can adjust it. Use this as a guide: https://github.com/wiktoriavh/community-talks/blob/main/.github/CONTRIBUTING.md
If this is for #3, you need to mention that in your PR. You also made changes not relevant to the issue,


Question: Is this repo now primary after apache retirement?

Sorry to ask question by filing issue. Is this repo now the primary after gossip retried from apache incubator?

Ralph,
yes I will take some time and move the code back here if you are interested in contributing.


[Bug] pulsar-admin tenants update is useless

Search before asking

[X] I searched in the issues and found nothing similar.

Version
Master branch.
Minimal reproduce step
When I read the document about pulsar-admin:
https://pulsar.apache.org/docs/next/admin-api-tenants/#update
Seems pulsar-admin tenants update command is useless.
What did you expect to see?
I want to change the tenant info.
What did you see instead?
There are no configurable parameters:

Anything else?
No response
Are you willing to submit a PR?

[X] I'm willing to submit a PR!

Actually, there are configurable parameters:

Doc need a fix.


Revert to direct firebase calls

Tested on node v9.11.2/v10.9.0 manual/regular

Current node minimum reqs are v9.4, though. Could test against that version as well, or just update the reqs as part of this patch (they're in the 'engine' section of package.json).
IIUC the changes you made in the last patch mean we don't need to do the direct access, is that correct? Do you want me to test on Windows too or are you reasonably confident this should work across platforms?

manual/normal tests pass on 9.4, don't know if there's anything in 9.11.2 that's good enough to inconvenience devs that might be using an older revision.
Should be fine on windows since the underlying issue was dealt with; but have limited experience in that area.


Link to Python models best practices does not exists

The link to the Python models best practices does not exist..
Does anyone know which discussion it should link to?

it looks like discussions were disabled for this repo, breaking the link -- following up internally, thanks for reporting


All images are blurred

I tried to use the BSImagePicker for multiple Image selection.
But all images are blurred. The ImagePickerController is shown and there already all images are blurred, and after selection they stay blurred.
I'm using Xcode 9.4 with iOS 11.4

I too tried BsImagePicker ,Mine is also showing Like Blurred .

Hmm, with a vanilla image picker or have you made any settings / custom fetch results / etc?


Problems occurred while training my own dataset

Output during training：

The configuration I use is dtu_mlp_fullres_allviews.conf, which is a dataset around the brain without a mask image. I did not run scannet_to_monosdf.py, I changed img_res in dtu_mlp_fullres_allviews.conf to [384, 384].

How many images do you use for training?

How many images do you use for training?

hi,I use 68 images for training.

Could you first check if your camera poses are correct. Other than that, maybe you could try to use a smaller sphere at initialization.

I also has the same problem, did you solve the problem?


remove selected option from list

i need to remove selected options from the fastselect selection
any suggestion?

Tye this by editing the CSS:
Original CSS:
.fstResultItem.fstSelected {color: #fff;background-color: #2694f1;border-color: #73baf6; }
Modified CSS:
.fstResultItem.fstSelected{display: none}


Collection maps contents change detection

aa0034350ce91673790c386c7fa155caffe851b5 introduced "collection maps" where 1-n packages get fully inlined into a single map. However, there is an issue with the change detection (whether the map needs to be recooked during non-first cooks) in the cooker:

if a package is changed (e.g. a new object is added) then the cooker will correctly recook the map
if the list of packages is changed (e.g. added or removed) then the cooker will not recook the map

The best approach would be probably to store the definition lists as they were used during the cook in the BuildCache and delete the [Map].upk from BuildCache when there is a change (forces a recook)

No longer relevant with the change to DLC cook (#46)

Again relevant as DLC cook was reverted (#53)

#70 re-introduced DLC cooking, so this is no longer relevant again


Feature/new data src

This PR introduces the new data src instead of the filesystem.
@lazarnikolov94 Please have a look 😁

I agree. The Subcategory structure is not the best. For now it works like before, but I guess we can still improve it. If you have an idea, feel free to share it :)

I agree. The Subcategory structure is not the best. For now it works like before, but I guess we can still improve it. If you have an idea, feel free to share it :)


in-memory based tables do not have a Buffer Pool

Hi Microsoft Team,
Quote
"Consider the following scenario:
Worker 1 is a long-running task, for example a read query using read-ahead over in-memory based tables. Worker 1 finds its required data pages are already in Buffer Pool, so it doesn't have to yield to wait for I/O operations, and can consume its full quantum before yielding.
Worker 2 is doing shorter sub-millisecond tasks and therefore is required to yield before its full quantum is exhausted."
To my understanding this is not correct.
There is no read ahead, Buffer Pool concept, pages and no I/O operations for in-memory based tables.
I guess you should replace in-memory based tables with on-disk tables.
Thanks for fixing!
Torsten Strauß
MVP

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a2c4ffb5-9862-ea37-e28d-547f97de08f9
Version Independent ID: 0c6a63c8-7a9f-06ee-2ffc-d6fd4455c016
Content: Thread and Task Architecture Guide - SQL Server
Content Source: docs/relational-databases/thread-and-task-architecture-guide.md
Product: sql
Technology: supportability
GitHub Login: @pmasl
Microsoft Alias: jroth

@TorstenStrauss -- Torsten, thank you for your feedback.
@pmasl -- Pedro, please look into this issue.

Fixed in https://github.com/MicrosoftDocs/sql-docs-pr/pull/18905
Thank you @pmasl

@TorstenStrauss  - thanks again for submitting this. The update to correct the documentation will publish in the next day or so.


Add video(s) from OpenDev CI/CD

https://www.youtube.com/channel/UCrInUsjstI13wADv0ulRoiw
https://www.youtube.com/watch?v=LjjfWBrvyps

Add to /community/community/presentations


Update .openpublishing.publish.config.json

Docs Build status updates of commit 5990d8b:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

.openpublishing.publish.config.json
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

@CelesteDG , I have updated the config file so we can start generating a preview link once the build is complete. Please review.


IGNORE => Is the Gui badly connected?

Also here, it seems that the gui and the internal representation of the beamline do not match.
Can you please do a round check of all the controls of the GUI and check that they properly send their data to LibWiser?

Hint:use the GetBeamline python script to check.

If the slit is NOT ignored, then a detectorplaced downstream will show a diffraciton pattern

If the slit is IGNORED, then a detector will just show the propagated gaussian intensity from the source

We are physicist,not programmers :-) Let's check physics, too...

Ignore option works in the following way:
libWiserOE.CoreOptics.ComputationSettings.Ignore = (self.ignore == 1)

It's wrong
There is no Ignore attribute into CoreOptics.ComputationSettings
Use
libWiserOE.ComputationSettings.Ignore, instead.

I am already using
libWiserOE.ComputationSettings.Ignore

Nope,
you are using
libWiserOE.CoreOptics.ComputationSettings.Ignore
while the correct one is
libWiserOE.ComputationSettings.Ignore
:-)

You're right, my bad :D I'll proceed with updating immediately

I think it's ok... 0.3.18 should have it the proper way.

Let's close it.


irp-transmogrifier: init at 1.2.12

Description of changes
IrpTransmogrifier is a command line utility that helps analyze and decode captured data from an infrared remote control receiver.
It can analyze a raw capture, extract timing parameters and an IRP expression, which is a domain-specific languagae defining how IR data is modulated using Pulse Width Modulation. It also contains a database of common modulation schemes (as IRP expressions) that help associate a sample with a particular scheme.
How to test
You need some raw infrared captures, then you can use it to inspect the signal.
echo "+8831 -4446 +487 -1705 +578 -578 +517 -578 +548 -548 +548 -548 +548 -548 +578 -548 +548 -548 +548 -548 +548 -1674 +548 -1674 +548 -1674 +517 -1705 +487 -1705 +517 -1705 +548 -1674 +517 -1674 +517 -1705 +548 -578 +548 -548 +548 -548 +548 -578 +517 -578 +517 -609 +517 -578 +517 -578 +517 -1674 +548 -1674 +578 -1674 +487 -1705 +548 -1674 +517 -1674 +517 -1705 +548 -1644 +548 -609 +517 -578 +517 -578 +548 -578 +517 -578 +517 -578 +517 -578 +548 -578 +517 -1674 +548 -1674 +487 -1735 +548 -1674 +517 -1705 +517 -1674 +548 -13277 +8861 -2223 +548 -95228 +8801 -2253 +548 -101501" > sample.txt

# Attempt a best effort modulation classification and decode the sample
$ irp-transmogrifier decode --input ./sample.txt
        48-NEC1: {D=1,F=7,E=7}, beg=0, end=107, reps=2

# Analyze the input without decoding it
$ irp-transmogrifier analyze --input ./sample.txt
{544,msb}<1,-1|1,-3>(16,-8,A:48,1,-13.308m,16,-3,1,-98m,16,-3,1,-98m){A=0x807fe01fe01f}

# Retrieve the IRP expression for the 48-NEC1 standard
$ irp-transmogrifier list --irp 48-NEC1
name=48-NEC1
irp={38.4k,564}<1,-1|1,-3>(16,-8,D:8,S:8,F:8,~F:8,E:8,~E:8,1,^108m,(16,-4,1,^108m)*)[D:0..255,S:0..255=255-D,F:0..255,E:0..255]

Things done
I patched the pom.xml file to remove a plugin which attempts to read the current git commit info from .git, since it doesn't exist in the source checkout.

Built on platform(s)

[x] x86_64-linux
[x] aarch64-linux
[ ] x86_64-darwin
[x] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 250285 run on x86_64-linux 1

1 package built:

irp-transmogrifier

Moved to my nur due to lack of review.


[BUG] Re-patching amazonlinux image

Version of copa
No response
Expected Behavior
After running ./copa patch -i docker.io/library/amazonlinux:2.0.20210326.0, and re-running copa on the patched image ./copa patch -i docker.io/library/amazonlinux:2.0.20210326.0-patched results in the following error
DEBU[0001] RPM DB Type in image is: RPMDBMixed
ERRO[0001] could not find determine RPM DB type of target image: RPMDBMixed
Error: could not find determine RPM DB type of target image: RPMDBMixed

Actual Behavior
No response
Steps To Reproduce
No response
Are you willing to submit PRs to contribute to this bug fix?

[ ] Yes, I am willing to implement it.

might be specific to #644, unable to reproduce this


Speed up JNumber Array[Char] => String creation by ~3x.

This is a more aggressive version of https://github.com/mdedetrich/scalajson/pull/25.
Summary
I was curious about the cost of Array[Char].mkString vs new String(Array[Char]), so I benchmarked them.
Using the String constructor directly is roughly 3x faster.
Results
Greatest benefit was seen for small strings, which I'd expect to be the common case for json processing.
[info] Benchmark                                  (len)   (method)   Mode  Cnt          Score          Error  Units
[info] StringBuildingBenchmark.arrayCharToString      1   mkstring  thrpt   30   22002307.228 ±   345191.252  ops/s
[info] StringBuildingBenchmark.arrayCharToString      1  newString  thrpt   30  109893200.111 ±  2081134.721  ops/s
[info] StringBuildingBenchmark.arrayCharToString      4   mkstring  thrpt   30   41137855.368 ±   855379.695  ops/s
[info] StringBuildingBenchmark.arrayCharToString      4  newString  thrpt   30  111457754.148 ±  1161271.794  ops/s
[info] StringBuildingBenchmark.arrayCharToString     16   mkstring  thrpt   30   31449261.979 ±  8122970.995  ops/s
[info] StringBuildingBenchmark.arrayCharToString     16  newString  thrpt   30   95994095.806 ± 12252876.044  ops/s
[info] StringBuildingBenchmark.arrayCharToString   4096   mkstring  thrpt   30   35797634.580 ±  4636664.117  ops/s
[info] StringBuildingBenchmark.arrayCharToString   4096  newString  thrpt   30   90919112.072 ± 15096548.293  ops/s

Benchmark
This project uses scalameter, but jmh is what I know. Here's the benchmark.
class StringBuildingBenchmark {

  @Benchmark
  @BenchmarkMode(Array(Mode.Throughput))
  def arrayCharToString(state: StringBuildingBenchmarkState): String = {
    state.constructString(state.charArray)
  }
}

@State(Scope.Benchmark)
class StringBuildingBenchmarkState {

  @Param(Array("1", "4", "16", "4096"))
  var len: Int = _

  @Param(Array("mkstring", "newString"))
  var method: String = _

  var constructString: Array[Char] => String = _

  val charArray: Array[Char] = Iterator.continually('9').take(len).toArray

  @Setup
  def setup(): Unit = {
    method match {
      case "mkstring" => constructString = _.mkString
      case "newString" => constructString = new String(_)
    }
  }
}

Codecov Report

Merging #26 into master will increase coverage by 0.15%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master      #26      +/-   ##
==========================================
+ Coverage   44.64%   44.79%   +0.15%
==========================================
  Files           5        5
  Lines         663      663
  Branches      140      140
==========================================
+ Hits          296      297       +1
+ Misses        367      366       -1

Impacted Files
Coverage Δ

...s/src/main/scala/scalajson/ast/unsafe/JValue.scala
0% <0%> (ø)
:arrow_up:

...m/src/main/scala/scalajson/ast/unsafe/JValue.scala
60.64% <100%> (ø)
:arrow_up:

jvm/src/main/scala/scalajson/ast/JValue.scala
73% <100%> (+1%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d863974...3a323b3. Read the comment docs.


Error -166 Course id not found

I tried udemy-dl -u<EMAIL_ADDRESS>-p xxxxx https://www.udemy.com/aws-certified-solutions-architect-associate-exam -o "/xxxxx/Udemy"
this return me
[INFO-107] Trying to log in ...
[INFO-137] Login success.
[ERROR-166] Course id not found!

Udemy course id 1168192. Can i fetch with this id also in url


Context Menu

Hi im am trying to implement a context menu with this library.
to archive my goal, i used drop down menu inside a custom component that have a div with oncontextmenu handler wraping the childrens.
when a context menu is triggered i set the open state of the drop down menu and forceupdate to rerender from outside the component.
my problems were that every time that i right click on an element, this trigers an mouseup event as well.
finally i get something working good enough but i have some problems with tap events because i dont know if was a longtap or a regular tap event.
It would be nice that you implement a Context Menu component because DropDown is not created for this purpouses.
I think that this idea will be usefull for a lot of people because on mobile phones is natural to use context menus with a long tap or right click.
thank you in advance for this awsome product :)

I created a ContextMenu component that may suite your needs, if not it should provide a nice example of one.
https://github.com/rolandpoulter/on-web-ui/blob/context-menus/apps/common/views/ContextMenu.js

@rolandpoulter Thanks for sharing it with us :+1: :+1: I'll have a look

Yes! I would create a PR myself, just have to get around to it.

@rolandpoulter Are you working on a PR for this?

Up-to-date link to @rolandpoulter's ContextMenu: https://github.com/rolandpoulter/on-web-ui/blob/master/src/common/views/ContextMenu.js

Does it supports nested ?

+1 Would love to see a dedicated Context Menu component. The Popover component can be used, but it falls short in many areas in regards to what a context menu should do.

I have ContextMenu component in my repository. It is used Menu component from material-ui.
Code: https://github.com/alex1kirch/material-ui-experiments/blob/master/src/components/common/ContextMenu.tsx
Example: https://mui-experiments.herokuapp.com/contextMenu

4 upvotes in 4 years, it's likely not important.

There is a paid version of the component in https://www.telerik.com/kendo-react-ui/components/layout/menu/context-menu/.

Looking at the telerik component, it seems that all we need is a new demo. Reopening.

@oliviertassinari I tried out what @alex1kirch had in his demo, seems to work for me!

@oliviertassinari
Hi, even though I am not working on that company that I worked on 2015, this use case is still valid.
I can't help on developing right now due to time constraint but I can help on testing if this ticket got implemented.
Thanks :)

Custom component that have a div with oncontextmenu handler wraping the childrens...?

Thanks :-)


Only two commands are executed with exec with array of commands

Issue summary
3rd and next items in exec array are ignored
Expected behavior
It should exec all commands
Actual behavior
Only first two commands are executed
Steps to reproduce

Open this CodePen Demo.
Type seq.
It should echo 5 lines only 2 are displayed.

It only happens when the exec is inside the interpreter.
This works fine outside of the terminal:
term.exec(['lorem', 'ipsum', 'dolor', 'sit', 'amet']);

It turns out that this is more difficult to solve, but there is an easy way to fix this without modifying the library. You just need to return your exec array from the interpreter and it just works.


Update 99connectMenu.sh

Fixed localIPrange to work with Odroid HC2 Armbian Buster by adding "inet" to grep command.
Simplified localIP assignment.  Now also works with Odroid HC2 Armbian Buster.

Closing to submit local IP address as one PR for multiple scripts.


Run Keyword in library is displayed in the report above other messages

Hello! See example bellow.

from robot.libraries.BuiltIn import BuiltIn

class Library(object):
    def do_something(self):
        BuiltIn().log('One')
        BuiltIn().log('Two')
        BuiltIn().run_keyword('Log', 'Three')
        BuiltIn().log('Four')

Here you can see that the third message is displayed higher than the rest. Because of this feature it is unclear at what point in time the call to Run Keyword
Is it possible to fix this? I want the messages to be in order no matter how they were received

This is a known issue already reported as #2086. Unfortunately the issue is rather hard to fix and it's unlikely it will be resolved in the near future.
I don't understand why you'd want to use BuiltIn().run_keyword or even BuiltIn().log for logging. See the Creating test libraries section in the User Guide for much better logging solutions.

Well, you shouldn't need to use WUKS in a library keyword either because you can easily implement your own error handling and timeouts. Anyway, the underlying issue is valid and that's why we have #2086.


AA: Add Zkyoto support

Description
AA: Add Zkyoto support
Test plan
Created AA Wallet locally and minted through it.

duplicated of #481


Install webview2 if not installed

Install webview 2 if not already installed.
Some windows 10 users seems to not have it installed

oops .... not in the git ignore ... sent it by mkstake

All good, maybe add a gitignore for it lol, that should've been there from the start


improvementAnalyze all columns when partition first loaded.

backport: https://github.com/apache/doris/pull/38540

run buildall


Why is the browser version required by pdf.js so high? How or whether it can be polyfill?

I found out that the build target is asking for Chrome 88, which was released at 2021/01/19
and Safari 14.1 was released at 2021/04/29
const ENV_TARGETS = [
  "last 2 versions",
  "Chrome >= 88",
  "Firefox ESR",
  "Safari >= 14.1",
  "Node >= 16",
  "> 1%",
  "not IE > 0",
  "not dead",
];

This means that even legacy builds are not compatible with browsers released two years ago
There are many third-party browsers, based on Chromium and maintain at a lower version (Chrome 60-100), that mean pdf.js will not at these browser.
And there are many Linux distributions, and the version of the firefox browser that comes with it is also very low（firefox 40-60）
Is there a list of new features used, compatibility, and whether it can be polyfilled? This make developers also understand how to be compatible with their
eg.

CSS Variable
fetch
CSS Masks
Stream API
...

temporary solution
In order to use the new features of the new version.
I had to try my best to polyfill these features, and build an old version that supports IE, and use different versions according to the environment

In general, please refer to https://github.com/mozilla/pdf.js/wiki/Frequently-Asked-Questions#faq-support for an up-to-date list of the supported browsers/environments. Hence anything not listed there is explicitly unsupported.

This means that even legacy builds are not compatible with browsers released two years ago

Note that for obvious security reasons using such old browsers is generally not a good idea.
Please keep in mind that the primary development target in this library is the built-in Firefox PDF Viewer.
Trying to support older browsers/environments quickly becomes complicated, since not all features can be easily polyfilled, and we want to (as much as possible) avoid a situation where we're forced to hold back improvements to the Firefox PDF Viewer just so that we can support some very old browsers.
Furthermore, trying to support older browsers would put a lot of strain on the few regular PDF.js contributors and that's time/effort that's better spent on improving the library itself.

Note that for obvious security reasons using such old browsers is generally not a good idea.

There are stable branches that get security branches backported, such as QtWebEngine LTS branches. PDF.js since 3.6 (even in legacy mode) no longer works with QtWebEngine 5.15 LTS, the last Qt5WebEngine branch, which is just a pain and forces me to stick to an old PDF.js on the servers I administer.


README for users (non developers)

As a reminder the disco structure will soon look as follows:
Disco/

DiscoJS/
Server/
Browser/

Currently mobile-.../ (which contains all the main code) has good readme, but it's made for developers. At the root of disco there is a readme, but it is a broad introduction.
We need to include a README for users (non developers), and this should be the first thing you see after the overview.
One idea is the following, at the root, the README should have:

Brief overview (what we have now but reduced)
Section for users (brief overview) -> then it links to a HOW_TO.md with more detailed info for users
Section for developer (brief overview) -> then links to our current readme for devs

In the root we also have the guide of how to contribute to disco, and a brief overview of the structure (we have these already just need to change where they are).
Then in DiscoJS/, Server/, ... the readme will be for developers (what we have now).

quick check again if users understand the main functionalities. maybe @aunell @Grim-bot could also cross-check, before we release the first version?

partially addressed in PR #331

done in #483 and some earlier ones


how can i hide the taskbar icon?

i use rule matching to open some website with firefox
the uri is matched, but the taskicon and hurl windows still showed up

hurl ver = v0.9.1

Sorry for late response on this. I finished setting up a Windows 10 VM just recently to test for it. I will test this soon.
What happens if you click on the icon ? does the hurl windows show up or nothing ?

yes，hurl windows shows up when i click the task icon
Chanakya @.***>于2024年11月28日 周四16:53写道：

Sorry for late response on this. I finished setting up a Windows 10 VM
just recently to test for it. I will test this soon.
What happens if you click on the icon ? does the hurl windows show up or
nothing ?
—
Reply to this email directly, view it on GitHub
https://github.com/U-C-S/Hurl/issues/179#issuecomment-2505463908, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AGAYM7DULE7IZSMPLTMPL2L2C3DYFAVCNFSM6AAAAABSNDMC76VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMBVGQ3DGOJQHA
.
You are receiving this because you authored the thread.Message ID:
@.***>


Index: #removeKey: needs to use restoreValue

testDoWithTransAction has a case where we remove a key in another transaction. The tests checks that this remove is local to that transaction (we can read the value).
But #removeKey: does not work correct.
If we add this to the end of the test:
	"We should be able to remove it here, too"
	tx1 root removeKey: 1.
	tx1 root  do: [ :each |
		self assert: (each beginsWith: 'bar').
		counter := counter + 1].
	self assert: counter equals: 1.

the test fails because key "1" is not found (yet we can find it with #at:).
The reason is that SoilIndexedDictionary>>#removeKey:ifAbsent: test for #isRemoved, but does not restore the value.

testRemoveKeyWithTwoTransactions is a better test for this, see comment at the end


Does TrackGraph work the same for In-Memory as for SQL Server?

I'm writing integration tests using the In-Memory provider, and I ran into something that is causing me to scratch my head.
I have some code like this:
_dbContext.ChangeTracker.TrackGraph(
	entity, n => {
		n.Entry.State = entity.IsNew ? EntityState.Added : EntityState.Modified;
	});

This works with object graphs when going against SQL server, and each object in the graph get's its EntityState set. But when I run through it with entities fetched using the in-memory provider, it doesn't seem to traverse the graph, and only updates the base entity.
Am I doing something wrong? Or is this the expected behavior?
Thanks
Further technical details
EF Core version: <IP_ADDRESS>
Database Provider: In-Memory
Operating system:
IDE: Visual Studio 2017 15.8.0 Preview 3.0

@camainc Not expected. Please post a runnable project/solution or complete code listing that reproduces the behavior you are seeing.

This is about as simple a solution as I could put together that demonstrates the behavior. It only uses the in-memory provider, but I have run the same method (in another project) against SQL Server and it works as expected. It's only when running against in-memory that it doesn't work right.
The method that works differently is in the "TrackChangesClient" project, in the "Repository" class, in the  "Update" method. The root entity gets updated when saving, but the child entity does not.
Thanks for looking at this. I need to know if I'm doing this wrong. :-)
TrackChangesTest.zip

Note for triage: the issue is with this code, and happens with both in-memory and SqlServer provider; I don't think that it is provider-specific.
if (_dbContext.Entry(entity).State == EntityState.Detached)
{
    // get and detach existing entry so we can reattach the updated entity
    var existingEntity = _dbSet.IgnoreQueryFilters().Single(x => x.Id == entity.Id);
    _dbContext.Entry(existingEntity).State = EntityState.Detached;
}

// reattach the child entities
_dbContext.ChangeTracker.TrackGraph(
    entity, n =>
    {
        n.Entry.State = entity.IsNew ? EntityState.Added : EntityState.Modified;
    });

The problem happens when the context is already tracking a principal and dependent when this code is executed, while the principal and dependent passed in are not tracked. This means that the existing principal is detached from the context, but the existing dependent remains tracked. Then, in TrackGraph, when the new principal is tracked it is fixed up to the existing dependent, severing the relationship to the new dependent.
Probably in this case it would be better not to sever this relationship, and instead let an exception be thrown when the attempt is made to track the new dependent. However, given this is a negative case anyway, it's not clear how much value there is in this. It may also prove tricky, since changing fixup behavior for one scenario can often regress a different scenario.

So I am doing it wrong, but what is the correct way to update the graph of a detached entity?
If I comment out the code

if (_dbContext.Entry(entity).State == EntityState.Detached)
{
// get and detach existing entry so we can reattach the updated entity
var existingEntity = _dbSet.IgnoreQueryFilters().Single(x => x.Id == entity.Id);
_dbContext.Entry(existingEntity).State = EntityState.Detached;
}

I get the error "The instance of type '' cannot be tracked because there is another instance with the same value for '{Id}' already being tracked..."

@camainc The best place to start is probably the docs here: https://docs.microsoft.com/en-us/ef/core/saving/disconnected-entities

Thanks
~CRC~
"You can give without loving, but you cannot love without giving." -- Amy
Carmichael
[+] You're welcome to add me to your address book
https://ws.evercontact.com/kwaga-bin/titan/WEB/me.pl/3189554321400600699/i
On Wed, Jul 25, 2018 at 12:38 PM Arthur Vickers<EMAIL_ADDRESS>wrote:

@camainc https://github.com/camainc The best place to start is probably
the docs here:
https://docs.microsoft.com/en-us/ef/core/saving/disconnected-entities
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/aspnet/EntityFrameworkCore/issues/12590#issuecomment-407870127,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA5p3stcr-7722ythC8G8Q_Gr9hpHnT4ks5uKMlSgaJpZM4VF8TU
.

So I have removed the code that loaded the existing entity and set it's state to detached. Now I am doing only what is shows on the page you referenced.
My repository update method looks like this:
`        public void Update(TEntity entity)
{
if (entity == null)
throw new InvalidOperationException("Entity to update cannot be null.");
        _dbContext.InsertOrUpdateGraph(entity);
    }

`
And the InsertOrUpdateGraph method in my dbContext class looks like this:
 public static void InsertOrUpdateGraph(object rootEntity) {     Update(rootEntity);     SaveChanges(); }
My test method looks like this:
`
[Test]
public void TestMethod()
{
var options = new DbContextOptionsBuilder()
.UseInMemoryDatabase(Guid.NewGuid().ToString())
.Options;
        const string newDescription = "This is a changed description";

        using (var dbContext = new TrackChangesContext(options))
        {
            LoadTestData(dbContext);

            var repo = new Repository<SampleEntity>(dbContext);

            // gets the entity with AsNoTracking()
            var item = repo.GetById(1, include: i => i.Include(x=>x.SampleLookup));

            // update the item's properties
            item.Description = newDescription;

            // update the child's properties
            item.SampleLookup.Description = newDescription;

            // save the changes
            repo.Update(item);

            Assert.That(item.Description, Is.EqualTo(newDescription));
        }
    }

`
When execution gets to the line in the InsertOrUpdateGraph method, it fails on the Update(rootEntity) statement with this error:
System.InvalidOperationException: 'The instance of entity type 'SampleEntity' cannot be tracked because another instance with the same key value for {'SampleEntityId'} is already being tracked. When attaching existing entities, ensure that only one entity instance with a given key value is attached. Consider using 'DbContextOptionsBuilder.EnableSensitiveDataLogging' to see the conflicting key values.'

P.S. I have no idea why the formatting gets so messed up. I'm clicking on the "Insert Code" button before pasting the code, and making sure the code goes in between the hash marks.

@camainc If I remember correctly from looking at your code earlier, this is likely because LoadTestData loads entities into the context. So when you try to track the new entity instance it conflicts with the instance that was previously loaded into the context.

By the way, I also tried doing this, from that same article:
var itemToUpdate = repo.GetById(1, i => i.Include(x => x.SampleLookup), asNoTracking: false);  dbContext.Entry(itemToUpdate).CurrentValues.SetValues(item);
And that works fine for the root entity, but how would I handle updating the child entities in a generic fashion where I don't know what those children might be? The example in the article shows, in the method named "InsertUpdateOrDeleteGraph(BloggingContext context, Blog blog)" how to update child entities, but using that method I would have to write a custom save method for every entity in my dbContext, and that doesn't seem like a good practice.

@camainc The in-memory database will store data saved from a DbContext instance into a database that is not persisted to disk. This can then be queried into a new context instance from the in-memory database. In other words, entities being tracked by a context is different from entities being stored in the database, in-memory or not. Generally, it is recommended that the a context instance be used for a single unit-of-work. So in this case, the code that sets up and saves the data into the in-memory database should use on context instance which is then disposed. Then a second context instance should be used for the test that pulls data from the in-memory database.


Adds ALL to drop list and removes added capabilities

Description
Closes #260
One question about the --add flag for the capabilities command. I added the following description: "Comma separated list of added capabilities that can be ignored by kubeaudit reports"
Do you think this is clear enough? Or should we go for something like: "Comma separated list of capabilities that can be added without raising errors"?
Here is the flow:
For each capability added (either to the add list or the drop list), kubeaudit will report errors, unless the capability is overridden with a label. Only one message will be displayed for CapabilityShouldDropAll, rather than displaying the same report for each capability, as the list coulg get very long:

When running autofix kubeaudit will set all capabilities in the drop list to "ALL", and delete all capabilities in the add list:

If we pass in aconfigfile  followed by the add capabilities flag, the flag will take precedence. For example:
Say we have the following added to our add list in myconfig.yaml:
auditors:
  capabilities:
    add:
      - DAC_OVERRIDE
      - FSETID
      - KILL
      - MKNOD

And we have the following in the manifest filemyfile.yaml:
        securityContext:
            capabilities:
              add:
                - SYS_TIME
                - SYS_MODULE
                - DAC_OVERRIDE
                - FSETID
                - KILL
                - MKNOD

After running:
kubeaudit all -k myconfig.yaml -f myfile.yaml --add "SYS_MODULE,CHOWN"

The result will be that the only capabilities added to Add List ignored by kubeaudit will be the ones listed in the comma separated list ("SYS_MODULE,CHOWN"):

Caveats

Test coverage for capabilities decreased by nearly 3 % (It used to be 94% now it's 91.3%)

Type of change

[x] New feature :sparkles:
[x] This change requires a documentation update :book:

How Has This Been Tested?

[x] Automated tests
[x] Manual tests (cluster - local mode, manifest files)

Checklist:

[x] I have :tophat: my changes (A 🎩 specifically includes pulling down changes, setting them up, and manually testing the changed features and potential side effects to make sure nothing is broken)
[x] I have performed a self-review of my own code
[x] I have made corresponding changes to the documentation
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[ ] The test coverage did not decrease
[ ] I have signed the appropriate Contributor License Agreement

Thanks for your suggestions and review, @catherinejones! 🙏🏽 I applied your suggestions! 😊

Thanks, @rxbchen ! 🙏

Just some nits but the code looks good! I am having second thoughts about "add list" for the config and flag option. I wonder if we can think of something less confusing. Maybe like "allow list" or even "allowAdd list". Wdyt?
@genevieveluyt I like "allowAddlist" and I think it would be less confusing indeed! I'll change it!

Just some nits but the code looks good! I am having second thoughts about "add list" for the config and flag option. I wonder if we can think of something less confusing. Maybe like "allow list" or even "allowAdd list". Wdyt?
@genevieveluyt I like "allowAddlist" and I think it would be less confusing indeed! I'll change it!


Use random speeds for random graphs to restore behavior before #2202

In #2202 we 'broke' GHUtility#buildRandomGraph because

if speed!=null the calls to random.nextDouble for fwd/bwdSpeed were skipped (so we e.g. got different distances for the same seed), even though previously these calls were executed even for randomSpeedEnc!=null.

we accidentally disabled the random speed generation by passing speed=60d in places where we previously passed randomSpeedEnc=null (which meant that random speeds should be enabled). Where we previously passed randomSpeedEnc!=null we now need to pass speed=null and where we previously passed randomSpeedEnc=null we now need to pass speed=60 (at least for car).

Also c.f. this comment: https://github.com/graphhopper/graphhopper/pull/2202#discussion_r541996509

Btw do you label all PRs (issues?) until 3.0 as 'milestone 3.0'?

if speed!=null the calls to random.nextDouble for fwd/bwdSpeed were skipped

Oh, no. Sorry for breaking this :) and thanks for fixing this!

we accidentally disabled the random speed generation by passing speed=60d in places where we previously passed randomSpeedEnc=null

Are you sure? Previously e.g. in DirectedBidirectionalDijkstraTest.java we used randomSpeedEnc!=null:
- GHUtility.buildRandomGraph(graph, rnd, numNodes, 2.2, true, true, encoder.getAverageSpeedEnc(), 0.7, 0.8, 0.8);
+ GHUtility.buildRandomGraph(graph, rnd, numNodes, 2.2, true, true, encoder.getAccessEnc(), encoder.getAverageSpeedEnc(), 60d, 0.7, 0.8, 0.8);

Btw do you label all PRs (issues?) until 3.0 as 'milestone 3.0'?

Yes

Are you sure? Previously e.g. in DirectedBidirectionalDijkstraTest.java we used randomSpeedEnc!=null:

Argh, this was a typo. Yes in DirectedBidirectionalDijkstraTest (and most others) we used randomSpeedEnc!=null which meant we were using random speeds, so now we need to set speed==null. randomSpeedEnc!=null meant: "There is a random speed encoder, so let's use random speeds". So my above sentence should be:
"we accidentally disabled the random speed generation by passing speed=60d in places where we previously passed randomSpeedEnc!=null (which meant that random speeds should be enabled)"

Btw do you label all PRs (issues?) until 3.0 as 'milestone 3.0'?

Also those that got opened some time ago but were fixed/closed for 3.0, like https://github.com/graphhopper/graphhopper/issues/1972?

"we accidentally disabled the random speed generation by passing speed=60d in places where we previously passed randomSpeedEnc!=null (which meant that random speeds should be enabled)"

Ah, ups. Then I indeed misread the code and did it not accidentally.

Also those that got opened some time ago but were fixed/closed for 3.0, like #1972?

Yes, I tag every thing that will be added or fixed in 3.0. So that we can easily search what improved or changed for this version.


Update icon to a new version without background

Update icon to a new version without background and update references for a more cohesive look for the app and the repository.

Nice.


add_blank_lines_for_python_control_statements adds lines when it shouldn't

If you have add_blank_lines_for_python_control_statements enabled for python as part of your ALEFix configuration, it will add blank lines even when it shouldn't.
E.g., a slightly improved version of flask's testing skeleton code:
import os
import flaskr
import unittest
import tempfile

class FlaskrTestCase(unittest.TestCase):

    def setUp(self):
        self.db_fd, flaskr.app.config['DATABASE'] = tempfile.mkstemp()
        flaskr.app.testing = True
        self.app = flaskr.app.test_client()
        with flaskr.app.app_context():
            flaskr.init_db()

    def tearDown(self):
        os.close(self.db_fd)
        os.unlink(flaskr.app.config['DATABASE'])

if __name__ == '__main__':
    unittest.main()

it will say that there are not enough lines before the class definition (which according to E302 there aren't). However, if you have add_blank_lines_for_python_control_statements as part of your ALEFix configuration e.g.,
let g:ale_fixers.python = [
\ 'autopep8',
\ 'add_blank_lines_for_python_control_statements',
\]

It will add an additional line before if __name__ == '__main__':  which actually introduces a new error.
import os
import flaskr
import unittest
import tempfile

class FlaskrTestCase(unittest.TestCase):

    def setUp(self):
        self.db_fd, flaskr.app.config['DATABASE'] = tempfile.mkstemp()
        flaskr.app.testing = True
        self.app = flaskr.app.test_client()
        with flaskr.app.app_context():
            flaskr.init_db()

    def tearDown(self):
        os.close(self.db_fd)
        os.unlink(flaskr.app.config['DATABASE'])

if __name__ == '__main__':
    unittest.main()

Also, ALEInfoToClipboard does not currently seem to capture any ale_fix configuration, so I didn't post the contents here (as they would just be distracting).

Thank you for the bug report. I have fixed this now.


the same issue

What is your shell and what is "python.pythonPath" set to? And can you launch the Python interpreter specified by "python.pythonPath"?
Originally posted by @brettcannon in https://github.com/Microsoft/vscode-python/issues/3535#issuecomment-443884570

Closing this issue as it doesn't actually ask anything or report an issue. If there is an issue then please open a new issue and fill out the issue report template.


Animate keeps keeps firing

I am adding WOW.js and Animate.css to a site I been working on. But I ran into what may be a bug. WOW keeps firing and adding animate to the element for every time I scroll. That seems like a very unwanted. Could you please give me some advice how I can get it to only fire once on a element.
Here is a video of the site and source.
https://www.dropbox.com/s/6qhjo1nd9wtdril/screencast_2015-01-23_00-09-52_0_edited_0_edited.mp4?dl=0

It is hard to tel by your video what's going on but I guess it's caused by another script in your page that forces a complete reflow, I would recommend trying to replicate the bug in a smaller environment (jsfiddle / codepen). If you're more of a debugger you can try to trace every event that's triggered when scrolling and see what's causing it by setting breakpoints. If you got access to the theme files try disabling scripts one by one to see which is the culprit.

Hi, I've been having the same happen to me. All the scroll events keep firing repeatedly.
All I have in my scripts are
var jQuery = require('jquery');
if (!window.jQuery) {
  window.$ = window.jQuery = jQuery;
}
new WOW().init();


Compile error

Hi, I'm using Idris 2, version 0.3.0 and when trying to compile I'm getting this error:

Thanks!

You must use the commit of Idris 2 specified in the submodule.

I will add that this is a requirement until Idris2 reaches it's new release, then we will guarantee support also for the new release beside the pinned version in the submodule. Feel free to reopen if there are error with the submodule.


merge package from arlac77/npm-package-template

package.json

chore(package<EMAIL_ADDRESS>chore(package<EMAIL_ADDRESS>chore(scripts): cover@#overwrite c8 --temp-directory build/coverage ava && c8 report -r lcov --temp-directory build/coverage
chore(package): add nyc from template
chore(package): set $.ava.require='esm' as in template
chore(package): set $.ava.files='tests/-test.js,tests/-test.mjs' as in template
chore(package): set $.ava.extensions='js,mjs' as in template

Coverage increased (+0.5%) to 47.822% when pulling ecb665b93089987d1892568e7772d1f7321d549c on template-sync-1 into 4b51aa2ceb99f4d03e3f18db5c7b408a0164b669 on master.

:tada: This PR is included in version 8.1.4 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Add step titles for CodeTour

There are no step titles in CodeTour. Let's add some for a more user-friendly learning experience.
Simply add a title property on each step of your code tours.

This was solved in #100


Something broke Atom

I was working with Atom and then I noticed a keyboard shortcut wasn't working. I thought maybe it was a glitch so I closed Atom and when I opened it again the main window wouldn't open. The OSX system menu only had the Atom menu and so no file, edit, view, or any of the other menus.
I closed Atom again, and reopened it. Nothing.
I tried opening Atom using Terminal, nothing.
I tried atom --safe, nothing.
Deleted the .atom/storage folder, reopened Atom. Nothing.
Deleted the whole .atom folder, reopened Atom, still Nothing.
I deleted the Atom.app, downloaded it again and now it works, although I have to reconfigure everything again.
Here is an error from Console.app, I'm afraid this is the best I can give you.
3/12/16 9:45:15.611 PM Atom[2602]: SyntaxError: missing ) after argument list
    at exports.runInThisContext (vm.js:53:16)
    at Module._compile (module.js:413:25)
    at Object.defineProperty.value [as .js] (/Applications/Atom.app/Contents/Resources/app.asar/src/compile-cache.js:208:21)
    at Module.load (module.js:355:32)
    at Function.Module._load (module.js:310:12)
    at Module.require (module.js:365:17)
    at require (module.js:384:17)
    at Object.<anonymous> (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/scoped-property-store/node_modules/atom-slick/index.js:5:72)
    at Module._compile (module.js:434:26)
    at Object.defineProperty.value [as .js] (/Applications/Atom.app/Contents/Resources/app.asar/src/compile-cache.js:208:21)
    at Module.load (module.js:355:32)
    at Function.Module._load (module.js:310:12)
    at Module.require (module.js:365:17)
    at require (module.js:384:17)
    at Object.<anonymous> (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/scoped-property-store/lib/scoped-property-store.js:5:11)
    at Object.<anonymous> (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/scoped-property-store/lib/scoped-property-store.js:263:4)
    at Module._compile (module.js:434:26)
    at Object.defineProperty.value [as .js] (/Applications/Atom.app/Contents/Resources/app.asar/src/compile-cache.js:208:21)
    at Module.load (module.js:355:32)
    at Function.Module._load (module.js:310:12)
    at Module.require (module.js:365:17)
    at require (module.js:384:17)
    at Object.<anonymous> (/Applications/Atom.app/Contents/Resources/app.asar/src/config.js:23:25)
    at Object.<anonymous> (/Applications/Atom.app/Contents/Resources/app.asar/src/config.js:1102:4)
    at Module._compile (module.js:434:26)
    at Object.defineProperty.value [as .js] (/Applications/Atom.app/Contents/Resources/app.asar/src/compile-cache.js:208:21)
    at Module.load (module.js:355:32)
    at Function.Module._load (module.js:310:12)
    at Module.require (module.js:365:17)
    at require (module.js:384:17)

My Atom configuration was quite simple. Only a few shortcuts and settings. I had less than 10 packages installed which I can try to list if that would help.

@PierBover What was the broken keyboard shortcut?

It was a shortcut I had assigned to "Select All" which is usually control+command+g. Other shortcuts I had defined were working fine.

I am facing the same issue. I only see the Atom menu.


Exe version

I dont run poweshell scripts, is it possible to get an exe version of this awesome project?

Glad you find this project useful!
The main reason for writing this program in power shell is the fact that anybody can view/inspect the source code and be sure that nothing fishy is going on. A compiled exe version would be less transparent.
Why would a compiled exe version of the script be any different to the regular script?
GitHub does not allow me to attach an exe file to this comment, so you’ll have to make one on your own. This can be done very easily with the PS2EXE tool and the following command.
Open PowerShell in the same folder as the DFDNetGUI.ps1 script and type the following.
Install-Module ps2exe
Invoke-ps2exe .\DFDNetGUI.ps1 .\DFDNetGUI.exe
Now you should have a compiled exe version of the PowerShell script.
Hope it helps.

The thing is Poweshell is disabled for security reasons in my pcs is it not possible to put it in the assets section? I want to use it but I cant change these settings because Im not the admin

Hi,
I updated the latest release to contain the compiled EXE version of this project (Release 1.2)
Regards
Joseph

Thank you so much thats awesome


Typo in README - input tensor shape of OpenUnmix

Hello,
I believe the true input shape of OpenUnmix (the spectrogram model, not the on-the-fly waveform one) is this, taken from the code:
(nb_samples, nb_channels, nb_bins, nb_frames)

This corresponds to the (I, F, T) that I've seen in the oracle code (I = channels, F = frequency bins, T = time frames).
The README describes the shape in a different order:

models.OpenUnmix: The core open-unmix takes magnitude spectrograms directly (e.g. when pre-computed and loaded from disk). In that case, the input is of shape (nb_frames, nb_samples, nb_channels, nb_bins)

Huh, in fact the code right after says:
# get current spectrogram shape
nb_frames, nb_samples, nb_channels, nb_bins = x.data.shape

So I think the documentation block of the code might need adjusting.

yes, nb_samples, nb_channels, nb_bins, nb_frames is correct. Feel free to open a PR to correct the readme – we changed this in the recent model.


Fix indent and use valid keys for configMapKeyRef

Fix restartPolicy indent.
Use valid keys from the ConfigMap in the step previous to the last special-config creation. Key special.type was not created anywhere in previous steps anywars.

NOTE: Please check the “Allow edits from maintainers” box (see image below) to
allow reviewers to fix problems on your patch and speed up the review process.
Please delete this note before submitting the pull request.

This change is

hey ci bot, plix reverify cla. ok?


Copy active item on split

This was the behavior until a few days ago (sometime after updating to Atom 1.6.0).
I have not been able to track down what change caused the change, but noticed that the default split behavior is slightly different, so is there any reason for why not change the keymapping here to match the default keymaps behavior?

As stated in the README, this package is no longer maintained and is deprecated. We recommend that people use the vim-mode-plus package instead. Because of this, we are archiving this repository and closing all issues and pull requests. Thanks very much for your support and contributions!


rodgersxy

Description:
footer section

@ALX-SE-Algorithmia/code-reviewing-team
Changes Made:
Provide a detailed overview of the code changes made to introduce this implemtation, along with any relevant code snippets or files.
Related Issue:
Fixes #[ISSUE_NUMBER]
Screenshots (if applicable):
Attach screenshots, if applicable, to showcase the newly implemented feature or bug fix.

Hello @rodgersxy.
Thank you so much for your contribution, it is phenomenal.
There's some news to be passed through:

We need to implement the footer in the Figma file to aid our development.
Also, we will need to touch up the colors too.

Once again, thank you so much again.
Your PR will be used in the development of the Figma file 👍.

Hi @rodgersxy.
Your code is being used for the implementation of the footer.
Thank you, but this PR will be closed.


TypeScript Definitions

The latest versions of TypeScript can pull typescript definitions from an NPM repository.  This helps
ensure that the TypeScript definitions are always in sync with what is published in node.  Furthermore,
it makes it much easier for TypeScript users to use the node module because all the have to do is
'npm install nats' and they automatically get TypeScript definitions.  With Angular2's adoption of TypeScript (and TypeScript's rising popularity, in general), this level of support for TypeScript will make life easier for a lot of developers.
All this means, for the nats developers, is including one file in their package.  It doesn't force any of you users to know or use TypeScript.  It just provides a definition file that can be found automatically by the TypeScript compiler.
Would you accept a pull request for such a definition file to be redistributed with the nats package in npm?

Feel free to send a PR, happy to take a look.

I have created pull request #77 to address this issue. Please let me know if I did this process correctly.

Pull request #77 fixes this issue. It is available in v0.6.4. This can be closed now.

Thanks.


Usage in Dart app without flutter

Hello,
I'm new to Dart, maybe there is something that I'm missing.
I have pure Dart app and wanted to require your package. The readme says that this package should work in dart but because of
environment:
  sdk: ">=2.17.0 <3.0.0"
  flutter: ">=3.0.0"

I'm not able to update dependencies because my app is not a flutter app.
Is there a way that I can add this package to app that is not a flutter app?

I am able to update dependencies in dart app without any problem.
What i did was:

Created new dart cli application with dart create gittest
Added libgit2dart as dependency in pubspec.yaml:dependencies:
  libgit2dart: ^1.1.0

Got dependencies with dart pub get (if you are using VSCode after editing pubspec.yaml and saving it, it should also get dependencies without any problem)

Thanks for the reply.
So, thats odd. Its almost clear dart project. I have pubspec like this
environment:
  sdk: '>=2.16.2 <3.0.0'

dependencies:
  args: ^2.0.0
  shelf: ^1.1.0
  shelf_router: ^1.0.0
  libgit2dart: ^1.1.0

and after dart pub get
I'm getting
Resolving dependencies...
Because globox depends on libgit2dart >=1.1.0 which requires the Flutter SDK, version solving failed.

Flutter users should run `flutter pub get` instead of `dart pub get`.

My dart version
dart --version
Dart SDK version: 2.17.1 (stable) (Tue May 17 17:58:21 2022 +0000) on "macos_x64"

And what happens if you run flutter pub get?

Currently I don't have flutter installed so i cannot check that.
I've searched for some libs at pub.dev that are listed as for Dart and Flutter, and every package have listed only sdk in environment section.
If I understand correctly what says https://dart.dev/tools/pub/pubspec#sdk-constraints I have to install flutter to use that package.

Ok, I thought you have Flutter installed. I guess you have to use flutter pub get even if you want to use it with Dart cli application.
It's probably related to https://github.com/dart-lang/pub/issues/2606, since package also provides support for Flutter applications.
Please reply with result, after installing Flutter. I believe that'll fix the issue.

I don't really need flutter for now.
So instead of installing flutter, I've forked repo, removed flutter dependency and added
dependency_overrides:
  libgit2dart:
    git:
      url: https://github.com/Matslom/libgit2dart

to the pubspec. Looks like it's working fine.

Sure, that'll work :)
As a side note, if you'll install Flutter, the Dart SDK is bundled with it, so no need to have separate installation of Dart.
I'm closing issue, since it appears to be resolved.


Include homepage, sketching, and forum related namespaces in translation content

Currently all translations have been limited to survey content. I think it would make sense to now publish and translate everything (not related to admin?).

[ ] Cleanup string and assign to appropriate namespaces
[ ] eliminate namespaces.json support and add admin namespace filtering
[ ] publish terms


Allow deduplication scripts to be added to the preprocessing script

Merging the factorizing part as well :D @lvwerra


Correctly initialize kv store if storage key missing

What does this PR do?

It looks like this commit might have introduced a bug
(I'm new to the code, so I might be wrong):
e4bb506#diff-89592b0a96bd24ccd41291548f9a07a3
On line 88, keyExists will return an error ErrKeyNotFound if the key does not exists,
because keyExists seems to not check if a key exists, but if a key is empty.
Motivation

More

[ ] Added/updated tests
[ ] Added/updated documentation

Additional Notes

Great, thanks for the quick review and merge!
What is the usual timeframe between path review (like 1.7.2 which will have the fix)?
Going to use the containous/traefik image in the meantime to continue my tests.


1.20.1 Support

Tried to use on 1.20.1 and is not working, have you planned to port this to that version?

Sorry, completely forgot I made this lmao
I'm just starting uni so a little busy atm, but next time I find myself with nothing to do I'll try port it over!

Sorry for the wait, the mods been updated to 1.20.2! If you need a 1.20.1 version too, let me know and I'll throw that together quickly.

Did a 1.20.1 build regardless and seems to be getting even downloads so probably was a good idea haha


Dev/rangers upgrade net7

Updated to use dotnet 7
and updated nuget packages

This PR looks good.

Hi.
Any news or comments?

Hi @bobbyangers, we will merge it soon. Thanks again for this PR.

@erjain Anything I can do to help?


[18.09] elasticsearch: Add zlib to buildInputs for unfree

Motivation for this change
Elasticsearch fails to build: #56055
On master, autopatchElf was improved (#47222) but with minor incompatibilities which were fixed on master. However autopatchElf was backported (#55538) without one of the fixes. This is the simple git cherry-pick -x backport.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Assured whether relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Thanks @thefloweringash :+1:


requireSignInToAccess is not working

I've set requireSignInToAccess to true, but guest can still create and enter rooms.
In addition, it seems that it doesn't verify the response from auth issuer.

Which branch do you use? Master or develop. Please notice that in develop we moved to new auth options and there is no requireSignInToAccess

It seems that I copied the wrnog config.example.js.
but how should I configure that I just want to let signned in user create a room?
thanks!

oh I got it.
I set
[BYPASS_LOBBY]     : [ userRoles.AUTHENTICATED ]

as the image below, I've logged in but still can't create the room sometimes.
is it a bug?

You need to set the userRole.AUTHENTICATED to the user in question in the userMapping function.

solved. thank you so much!


Ignore threaded_cull_minimum_instances for single threaded exports.

Fixes https://github.com/godotengine/godot/issues/88192 present in 4.3+ where more Node3Ds than threaded_cull_minimum_instances in single-threaded web exports cause all instances to stop being rendered. In order to always go down the single threaded code path, this commit overrides the value of threaded_cull_minimum_instances when building for single-threaded exports so that the multi-threaded culling code is never executed.
Validated on 4.4.dev with minimal project:
96968_minimal_repro.zip

I don't think this is the correct fix, the WorkerThreadPool should automatically handle the no threads case. The only places where we should have to manually check if NO_THREADS is defined are places that manually launch threads.
CC @adamscott who will likely have a better idea than me about why the WorkerThreadPool is failing here in no_threads builds

Superseded by #99416.

@BokoYoss To be honest, your PR was exactly what I had in mind to fix the issue before @clayjohn's comment. Thank you very much for the PR!


Create an Athena data cluster  table with enrollment data

Normalize data from the  MITx, xPRO, MicroMasters and Bootcamps files on S3 to create an enrollment data table in an Athena cluster

For the time being we have used the Glue crawler interface to populate table data, though we will be moving to use the Glue API to more easily register and update table schemas as part of the pipeline execution (https://github.com/mitodl/ol-data-pipelines/issues/26).


Support multiple return data formats

Currently, the APIs only return plain text, and it's used for displaying it in the terminal
But I found that in many cases, the usage won't be just displaying the evaluation in the terminal, but instead use that data for further functionalities (ie. generating reports), so it should be in JSON, XML, CSV, ...etc formats

Absolutely. Feel free to submit a PR for review! :+1:


Add swiftlint

Tool information

Tool name: swiftlint
Tool license: MIT
Add or update? Add
Desired version: 0.39.2
Approximate size: 3 MB
If this is an add request:

Brief description of tool: A tool to enforce Swift style and conventions.
URL for tool's homepage: https://github.com/realm/SwiftLint

Area for Triage:
Apple
Question, Bug, or Feature?:
Feature
Virtual environments affected

[x] macOS 10.15
[ ] Ubuntu 16.04 LTS
[ ] Ubuntu 18.04 LTS
[ ] Ubuntu 20.04 LTS
[ ] Windows Server 2016 R2
[ ] Windows Server 2019

Can this tool be installed during the build?
Yes
Tool installation time in runtime
Couple of seconds
Are you willing to submit a PR?
No, I don't know how to add this tool to the GHA env

Hello @bielikb , thank you for feature request. We would like to keep this work item opened for awhile to see popularity of this request.

This tool is compatible with Linux too, so I think that Ubuntu checkboxes in the description should be checked too.

Thanks @MaxDesiatov. I just updated the description.

Hello, we are going to pre-install swiftlint only to macOS images for now. We will update the issue as soon as it is done.

We have added SwiftLint installation to macOS.
Images with it will be rolled out around next week.

Perfect!
Thanks for adding the swiftlint to GHA.
Best,
Boris

Hello changes were added to images. If you have any concerns feel free to reopen the issue.


Fitting a Weibull-Weibull model to the Vanem-Bitner data set currently does result in an error

This is the input:

Which leads to this error:

A Weibull-Normal (no depedencies) model leads to the same error.
Input (again with the Vanem Bitner raw data test file):

Fixed


[Critical] Binary is rejected on AppStore Review

When I submit build to AppStore Review - after a while I get it rejected with: Invalid Binary
Expected Behavior
Binary is not rejected.
Current Behavior
ITMS-91064: Invalid tracking information - A PrivacyInfo.xcprivacy file contains invalid tracking information at the following path: “Frameworks/AmplitudeSwift.framework/PrivacyInfo.xcprivacy”. NSPrivacyTracking must be true if NSPrivacyTrackingDomains isn‘t empty. Keys and values in your app’s privacy manifest must be valid. For more details about privacy manifest files, visit: https://developer.apple.com/documentation/bundleresources/privacy_manifest_files.
Possible Solution
I tried to set Privacy Tracking Enabled to YES in my own PrivacyManifest file. It seems to fix the preprocessing warning. But Binary is still gets rejected.
Steps to Reproduce

Submit build to AppStore -> build is validated successfully
Add build to Version
Submit version to Review

Environment

SDK Version: 1.5.0
OS Info: MacOS 13.5.2, XCode 15.2

@emartinson are you using the latest version of the library? The domains were removed in version 1.4.5
https://github.com/amplitude/Amplitude-Swift/pull/155

Yes, I do. I haven't figured out why I got these messages. I've managed to pass review by correcting local privacy manifest.
I think this issue may be closed


CSS case insensitive attribute selector operator

Describe the bug
When using .css(input[type=checkbox i] Nokogiri kicks up an error: Nokogiri::CSS::SyntaxError (unexpected ' ' after '[:equal, "checkbox"]')
To Reproduce
#! /usr/bin/env ruby

require 'nokogiri'
require 'minitest/autorun'

class Test < MiniTest::Spec
  describe "Node#css" do
    it "should find a div using chained classes" do
      html = <<~HEREDOC
        <html>
          <body>
            <input type="CHECKBOX" />
      HEREDOC

      doc = Nokogiri::HTML::Document.parse(html)

      assert_equal 1, doc.css("input[type=checkbox i]").length
    end
  end
end

Expected behavior
The i modifier should make the attribute selector case-insensitive.
Environment
# Nokogiri (1.10.9)
    ---
    warnings: []
    nokogiri: 1.10.9
    ruby:
      version: 2.7.1
      platform: x86_64-darwin19
      description: ruby 2.7.1p83 (2020-03-31 revision a0c7c23c9c) [x86_64-darwin19]
      engine: ruby
    libxml:
      binding: extension
      source: system
      compiled: 2.9.4
      loaded: 2.9.4

Additional context
More information on attribute selector operators: https://developer.mozilla.org/en-US/docs/Web/CSS/Attribute_selectors

Hi, @Juice10! Thanks for opening this issue.
Unfortunately, it looks like we have never tried to add support for the case-sensitivity attribute selectors. This is relatively new, in Selectors Level 4 which is still in draft (although we're probably all familiar with how that works).
I'm unlikely to work on adding this support while I'm still trying to get v1.11.0 out the door, but I'll prioritize it after that. In the meantime, if you have time to work on this, I'd be super happy to help you craft a PR!

It seems likely we'll be able to deliver this as part of the CSS selector rewrite (see #2560) which is scheduled to land in v2.0.


fix: correct AMI ordering function

Fixes #N/A
Description
Fixes a bug with the AMI ordering logic. This was only reached if Karpenter was trying to order AMIs that had both the same creation timestamp and the same name.
How was this change tested?
make presubmit
Does this change impact docs?

[ ] Yes, PR includes docs updates
[ ] Yes, issue opened: #
[x] No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.01%) to 82.253%

Totals

Change from base Build<PHONE_NUMBER>:
-0.01%

Covered Lines:
5404

Relevant Lines:
6570

💛  - Coveralls


SubscriptionPaymentBehavior is inaccessible

Describe the bug
The SubscriptionPaymentBehavior enum is not accessible for CreateSubscription::payment_behavior (docs also don't make it a link).
There is an enum with the same name (which is not compatible) in the generated billing::subscription_item module, as well.

To Reproduce
    let mut create_subscription = CreateSubscription::new(customer_id);
    create_subscription.payment_behavior = Some(SubscriptionPaymentBehavior::DefaultIncomplete);

error[E0308]: mismatched types
   --> src/stripe/intent.rs:89:49
    |
89  |     create_subscription.payment_behavior = Some(SubscriptionPaymentBehavior::DefaultIncomplete);
    |                                            ---- ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ expected enum `stripe::resources::generated::billing::subscription::SubscriptionPaymentBehavior`, found enum `SubscriptionPaymentBehavior`
    |                                            |
    |                                            arguments to this enum variant are incorrect
    |

Expected behavior
The enum should be accessible.
Code snippets
No response
OS
Fedora 36
Rust version
rustc 1.66.0-nightly (2019147c5 2022-09-19)
Library version
0.15
API version
2022-08-01
Additional context
No response

Hi! Thanks for using async-stripe. On master, #296 was recently landed that re-exports everything in the generated module so you can fall back to that in the case that duplicate classes cause the one you want to be swallowed.
Closing in favour of https://github.com/arlyon/async-stripe/issues/154 which has more context.


Type-safe view references

Any possibility @Render() could be made to take the actual exported TSX view instead of relying on string filename?

Due to the way NestJS / express view engines work, this is impossible in my understanding.


Update to 0.11.2

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

you've got to update the sha sum

Thanks, I missed it.

you can also add yourself to maintainers


Export createComponent and customMap to create custom wrapped components

Hello Dmitry,
It is a feature request to have possibility to create bindings for custom components.
For example we have custom component based on Ant's Input.Search. It would be great if redux-form-antd will expose functions to wrap such components with bindings, so we would be able to use it as redux-form-antd provided components.
To achieve this createComponent and customMap functions should be exported. What do you think about it?

Hi it would be nice.  But currently i don't have any possibility to test such enhancement on real project. So it welcome to make pr.

Hi Dmitriy, thank you for your response and for merging the PR. When are you going to publish the npm package?
Also I can see a version mismatch. In package.json there is a 1.0.3, while already published npm package has 1.0.4.

Hi, thanks for your pr, i will publish it in next Monday. Now i don't have any ability to publish it (

Thank you.


board-formatting.schema.json

[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 33dfff5b-2b9e-94c7-ffa2-73719f49fb20
Version Independent ID: 33dfff5b-2b9e-94c7-ffa2-73719f49fb20
Content: Format board view to customize SharePoint
Content Source: docs/declarative-customization/view-board-formatting.md
Service: sharepoint-online
GitHub Login: @VesaJuvonen
Microsoft Alias: vesaj

Can you provide details of the issue here>


Integrate Mersenne31 into PCS framework

We want to integrate Mersenne31 into our PCS framework so that we can commit to a compressed LDE (might require a special variant of LDTBasedPCS).

Closing this as we have a different plan for Mersenne integration; we can keep #56 to track progress with the new scheme.


[2.9] Drop support for: Laravel 6, Laravel 7, PHP 7.2 and add doctrine/dbal ^3

Summary
Based on the discussion around https://github.com/barryvdh/laravel-ide-helper/pull/1094#issuecomment-738611427
❗ BLOCKED UNTIL A NEW 2.8 RELEASE WAS MADE AND SOME TIME PASSED (like, a week) ❗

some Laravel framework version checks in the tests are now be able to be removed

I have not checked in detail, but judging by https://github.com/barryvdh/laravel-ide-helper/blob/db53e8e2b5868fb05019ae20e727be24831b46d8/README.md#auto-completion-for-factory-builders

Deprecated for Laravel 8 or latest

we might be able to remove that part => will be a separate PR anyway, let's keep this one as minimal as possible

Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update
[ ] Misc. change (internal, infrastructure, maintenance, etc.)

Checklist

[x] Existing tests have been adapted and/or new tests have been added
[x] Add a CHANGELOG.md entry
[ ] Update the README.md
[x] Code style has been fixed via composer fix-style

So should we go ahead with this now? Or are there still issues you want to handle before 2.9?

@barryvdh I would wait "a bit" (like, next week maybe?) to gauge any possible breakers. I also want to ping al the people having the Laravel 8 problems which should also be fixed

@spawnia

Nice work. I tried this branch in our project, everything is working great.

Thanks for confirming!
@barryvdh basically it's all ready!
Though https://github.com/barryvdh/laravel-ide-helper/pull/1134 should be merged first and I'll then adapt the changelog changes here before we merge this.

@mfn, @barryvdh
We really need PHP 8.0 + Doctrine\Dbal 3.0 support in our project.
When can we expect a release with these changes? I really don't want to make forks and other crutches ..
Thank you in advance.

Oke please test this version on your project, I will tag a new release if okay.

Tested and working as expected across a few projects I maintain

Tested on a project with dbal 2.12.1 and then also upgraded to dbal 3.0 and generating model phpdoc worked without issues \o/

Alrighty, tagged 2.9.0 🎉


Release 1.2

As discussed, I switched to Keep a Changelog because the changelog generator is buggy with the feature branches and is pretty much unmaintained.
Will release when this is approved

Re

As discussed, I switched to Keep a Changelog because the changelog generator is buggy with the feature branches

Just realised that you can use github_changelog_generator --release-branch <RELEASE-BRANCH> option to work with feature branches.
update_changelog.sh accepts that parameter and passes it unmodified to github_changelog_generator. So, it works.

and is pretty much unmaintained.

That may be. ;-)

Yes, I know about the --release-branch flag, but it did not work correctly for me at the time. I don't remember my exact problem with it, but there are some open issues on the generator repo regarding that.

Yes, I know about the --release-branch flag, but it did not work correctly for me at the time. I don't remember my exact problem with it, but there are some open issues on the generator repo regarding that.

Yes. The problem is that the current version of the script doesn't allow pass through of options to the GitHub changelog script.
That worked in the past, but got broken with the introduction of getopt option parsing.
I plan to fix it, either by fixing options pass through, or declaring required / desired options explicitly on the script.


Correct place of Ember community

Ember community is github.com/emberjs not github.com/ember.

Thank you 😄

🤘


Add a back button to favourite page

While the browser back button works, it would be convenient to allow the user to go back to the search page from viewing their favorites.

Have added a button. Will commit to main when css styling done.


Add Item model

Closes #123.
This PR adds the Item class and associated classes, where an Item has the following fields:

Name
Quantity
Date bought
Date of expiry

Tasks left to do:

[ ] Add unit tests for Name
[ ] Add unit tests for Quantity
[ ] Add unit tests for Date bought
[ ] Add unit tests for Date of expiry
[ ] (Item) Make the date bought / date of expiry optional (NOTE: Needs further discussion)
[ ] Add Javadocs
[ ] Cleanup code according to checkstyle

ERROR:../src/main/java/seedu/address/model/item/DateValidator.java:21: no newline at EOF.

Codecov Report

Merging #143 (ae122f4) into master (f4c5daf) will decrease coverage by 8.20%.
The diff coverage is 0.00%.

 Learn more


Allow newer versions of hapijs and add rethinkdb-init support

The peerDependency locked hapi into v8, this allows all version above that.
I really liked the other fork but I think it went to far, this just adds the rethinkdb-init library.
I can update the docs in another pull request if you think these changes are reasonable.

I really really don't like rethinkdb-init, yet I do agree with you on allowing newer hapijs versions, I'll cherrypick it from your branch

Hey, that's cool.  My new thought is that rethinkdb-init could just be run in the plugin registration success callback.

Yes, that's why I didn't included it since it can be embedded if the developer wants it :)

Thanks @natelaws! Already cherry-picked your commit and published as<EMAIL_ADDRESS>


cqlsh-expansion: AttributeError - 'NoneType' object has no attribute 'is_up'

Describe the bug
The COPY FROM command produces the following error on a csv file created with COPY TO.
<stdin>:1:Failed to import 30 rows: AttributeError - 'NoneType' object has no attribute 'is_up',  given up after 1 attempts

To Reproduce
Steps to reproduce the behavior:

Install cqlsh-expansion as described here. https://docs.aws.amazon.com/keyspaces/latest/devguide/programmatic.cqlsh.html

Dump data to csv

cqlsh-expansion cassandra.us-west-2.amazonaws.com 9142 --ssl -e "COPY keyspace1.table1 TO './dump.csv' WITH HEADER='true';"

Create new keyspace/table, matching the source table

CREATE KEYSPACE IF NOT EXISTS "keyspace2"
  WITH REPLICATION = {'class':'SingleRegionStrategy'};

CREATE TABLE IF NOT EXISTS keyspace2.table2 (
    col1 text,
    col2 text,
    col3 text,
    created_at timestamp,
    my_data blob,
    PRIMARY KEY (col1, col2, col3)
) WITH CLUSTERING ORDER BY (col2 ASC, col3 ASC)
    AND bloom_filter_fp_chance = 0.01
    AND comment = ''
    AND crc_check_chance = 1.0
    AND dclocal_read_repair_chance = 0.0
    AND default_time_to_live = 0
    AND gc_grace_seconds = 7776000
    AND max_index_interval = 2048
    AND memtable_flush_period_in_ms = 3600000
    AND min_index_interval = 128
    AND read_repair_chance = 0.0
    AND speculative_retry = '99PERCENTILE';

Import data

cqlsh-expansion cassandra.us-west-2.amazonaws.com 9142 --ssl -e "CONSISTENCY LOCAL_QUORUM; COPY keyspace2.table2 FROM './dump.csv' WITH HEADER='true';"

Observe errors

Consistency level set to LOCAL_QUORUM.
cqlsh current consistency level is LOCAL_QUORUM.
Reading options from /home/ubuntu/.cassandra/cqlshrc:[copy]: {'numprocesses': '16', 'maxattempts': '1000'}
Reading options from /home/ubuntu/.cassandra/cqlshrc:[copy-from]: {'ingestrate': '1500', 'maxparseerrors': '1000', 'maxinserterrors': '-1', 'maxbatchsize': '10', 'minbatchsize': '1', 'chunksize': '30'}
Reading options from the command line: {'header': 'true'}
Using 16 child processes

Starting copy of keyspace2.table2 with columns [col1, col2, col3, created_at, my_data].
<stdin>:1:Failed to import 30 rows: Error - field larger than field limit (999999),  given up after 1 attempts
<stdin>:1:Failed to import 30 rows: AttributeError - 'NoneType' object has no attribute 'is_up',  given up after 1 attempts
<stdin>:1:Failed to import 30 rows: AttributeError - 'NoneType' object has no attribute 'is_up',  given up after 1 attempts
<stdin>:1:Failed to import 30 rows: AttributeError - 'NoneType' object has no attribute 'is_up',  given up after 1 attempts
<stdin>:1:Failed to import 30 rows: Error - field larger than field limit (999999),  given up after 1 attempts
<stdin>:1:Failed to import 30 rows: Error - field larger than field limit (999999),  given up after 1 attempts
<stdin>:1:Failed to import 30 rows: AttributeError - 'NoneType' object has no attribute 'is_up',  given up after 1 attempts
<stdin>:1:Failed to import 30 rows: AttributeError - 'NoneType' object has no attribute 'is_up',  given up after 1 attempts
...
Processed: 14105 rows; Rate:     212 rows/s; Avg. rate:     185 rows/s
0 rows imported from 1 files in 0 day, 0 hour, 1 minutes, and 16.140 seconds (0 skipped).

Expected behavior
I expect the import to complete successfully without errors.
Screenshots
n/a
Environment (please complete the following information):

Host OS: Ubuntu 22.04
AWS Keyspaces
cqlsh-expansion: 6.1.0

Additional context
I'm just trying to do a simple export/import.
(P.S. Appologies if this is the wrong repo to report 'cqlsh-expansion' bugs.)

I ran cqlsh-expansion with --debug and found the following stack trace.
Starting copy of keyspace2.table2 with columns [col1, col2, col3, created_at, my_data].
Traceback (most recent call last):
  File "/home/ubuntu/.local/lib/python3.10/site-packages/cqlshlib/copyutil.py", line 2457, in inner_run
    for replicas, batch in split_into_batches(chunk, conv, tm):
  File "/home/ubuntu/.local/lib/python3.10/site-packages/cqlshlib/copyutil.py", line 2632, in split_into_batches
    yield filter_replicas(replicas[ring_pos]), make_batch(chunk['id'], rows[i:i + max_batch_size])
  File "/home/ubuntu/.local/lib/python3.10/site-packages/cqlshlib/copyutil.py", line 2268, in filter_replicas
    return [r for r in shuffled if r.is_up is not False and r.datacenter == self.local_dc] if hosts else ()
  File "/home/ubuntu/.local/lib/python3.10/site-packages/cqlshlib/copyutil.py", line 2268, in <listcomp>
    return [r for r in shuffled if r.is_up is not False and r.datacenter == self.local_dc] if hosts else ()
AttributeError: 'NoneType' object has no attribute 'is_up'

any solution to fix this issue?


should use alpine image for nginx-proxy Docker image

https://hub.docker.com/r/jwilder/nginx-proxy/tags/
because it has smaller size => faster download

@phuonglm we missed this

verified, close


merge package from arlac77/npm-package-template

package.json

chore(package<EMAIL_ADDRESS>
.travis.yml

chore(travis): remove node versions 10.11
chore(travis): add node versions 10.12

:tada: This PR is included in version 2.0.4 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket: