AUR package clang-format-static-bin outdated

Hey muttleyxd,
I noticed that you are the maintainer of the clang-format-static-bin AUR package. In the PKGBUILD I saw that it uses links to this repository, which frankly enough, is your own repository. I've seen that you updated this repository to clang-format-16 which is fairly nice because since version 16 of clang-format the AlignTrailingComments  option is not simply a boolean anymore, but has various options (see screenshot below) which I need for a codebase that I am maintaining.
Could you please also update the PKGBUILD of the AUR package? In the meantime I'll run clang-format version 16 manually from this repository thus outside of my AUR package manager.

Hi @Xhendos, done, thanks for notifying me - I forgot about AUR. I think I may develop a pipeline for automatic AUR releases
Feel free to reopen if issue persists


Line endings

When adding a vendor to git, the line endings is forced to change. What contributes to the breakage of the building for Linux.
This is due to line 1 of the .gitattributes file.

i need more info to help here.

I enter cargo vendor,
I enter git add vendor/,
Warnings appear:
warning: CRLF will be replaced by LF
(Problem occurs on Linux)

You can remove first line in .gitattributes

The problem is that line endings are specified explicitly in the .gitattributes file.

you mean this cargo-make repo gitattributes? i'm not sure why that would matter. you are running a binary in your repo directory.
i'm really having hard time to understand

what you are doing
what you are seeing
what you expect

I enter cargo vendor and enter git add vendor/
Warnings appear:
warning: CRLF will be replaced by LF
(Problem occurs on Linux)
I expect line endings to be like on my operating system (Linux). And there will be no warnings.

any chance you can send me console commands and output?
i still don't get how this is even related to cargo-make

I enter cargo vendor and enter git add vendor/
Warnings appear:
warning: CRLF will be replaced by LF
(Problem occurs on Linux)
I expect line endings to be like on my operating system (Linux). And there will be no warnings.

if its in your repo, how is it related to cargo make?

It is in the upstream repository that the .gitattributes file says: * text eol=lf.

not sure why setting text files to lf cause issues. especially on non-windows OS.
what build is it breaking?
i can remove the line but i would like just to fully understand why something like that would break anything as it just makes text files (inside cargo-make respository sources) use the linux/unix eol.

When building an RPM package, there are a number of checks, including line endings.

ok... strange.
feel free to submit a PR for the gitignore changes and I'll push them

@Future998 PR merged. closing this issue unless there is something else related needed


calcuate -> calculate typo fix

should be: calculateCpuPercent

Can you please sign your commits following these rules:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "patch-1" git@github.com:rseymour/docker.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

LGTM

LGTM


[Advice] How to build an autosave feature with vue-apollo?

So I'm using vue-apollo and I try to build an autosave for my form and I need a way for the vue-apollo cache to don't overwrite newer data which already changed the app while saving.
I will try to keep this short and concise. I already have a system in place that autosaves via a mutation whenever a change to my data occurs (via a deep watch and _.debounce timeout).
What I have trouble with is, is this usecase: The users is in the process of writing eg. in a textfield and writes a longer text, making a thinking break, a debounce will be triggered and saves via mutation. Now the user starts writing again, here a race condition happens, because while the user is typing, the "old" save request comes back and apollo updates the cache with it. So what happens, the textfield will reset to the state when the autosave was send (the users paused) and will of course greatly frustrated the user because everything they wrote since then is lost.
Solutions I tried:

decoupling the data from vue-apollo while editing (via a lazy setter/getter computional): this worked until I needed to make a component which should work on a many-to-many nested relationship. so whenever I created and then update/delete an item on this relationship, I would actually need the id (aka the data from the save request).

setting a mutex on the beginning of keypressdown and not firing autosave until @input: this is very not-DRY (event handler on every child component) and also now all my child component need to know about this and fire up the input and change events so I can listend to them.

Help? Any suggestions, any ideas?
Also I'm happy to go into more detail. For example here is my debounce pseudo code:
  watch: {
    value: {
      deep: true,
      handler: _.debounce(function(val) {
        // get only changed fields
        let changed = difference(val, this.previous);

        // prepare changed and nested mutation for gql mutation
        // ...
        //
        this.previous = _.cloneDeep(val);
        return $apollo.mutate({  // update mutation});
      }, 500),
    },

I'm not sure I have completely understood what you mean, but I think in fact you need to write your data back to apollo cache after mutation is successful, so you can skip this step if you don't want the old data cover the new data? Your autosaved data only need to be read when user refresh the page.

Closed because of inactivity


License for the Arduino Code?

Hi @klinquist,
Thanks for this awesome repo! I found it via Google while looking for information to make my own car-based altimeter. It was an awesome resource and inspiration. This is my first hardware project!
I forked your code because I had to make a few modifications given slight differences in hardware.
Given that my code is an adaptation of yours I was wondering if you'd be able to say what license you'd like to apply to your original code. I'd love to be able to share mine via an MIT license if possible.
Thanks!
Dan

Thanks for bringing this to my attention, I have added MIT license.


Added theme "powerlevel9k"

Here is a new theme "powerlevel9k" which may be a substitute for the "agnoster" theme. It is more flexible and has some additional features..
Screenshot is in the original repository: https://github.com/bhilburn/powerlevel9k
It may also showcase the use of git submodules as requested in #3379

@bhilburn FYI

Please do NOT send us themes


Example HttpStaticFileServerHandler: raf is not closed.

Recently I use this HttpStaticFileServerHandler as file server, but I can't download mp4 file correctly. Then I found raf is not closed.
There is a issue mention about it: https://github.com/netty/netty/issues/2235, but it seems don't fix it.
I asked about it at stackoverflow: https://stackoverflow.com/questions/53500128/netty-httpstaticfileserverhandler-problem/53511572#53511572
Here is my change,and it's working.
RandomAccessFile raf;
    try {
        raf = new RandomAccessFile(file, "r");
    } catch (FileNotFoundException ignore) {
        sendError(ctx, NOT_FOUND);
        return;
    }

...

sendFileFuture.addListener(new ChannelProgressiveFutureListener() {
        @Override
        public void operationProgressed(ChannelProgressiveFuture future, long progress, long total)
{
            if (total < 0) { // total unknown
                System.err.println(future.channel() + " Transfer progress: " + progress);
            } else {
                System.err.println(future.channel() + " Transfer progress: " + progress + " / " + total);
            }
        }

        @Override
        public void operationComplete(ChannelProgressiveFuture future) {
            System.err.println(future.channel() + " Transfer complete.");
            raf.close();// close raf when transfer completed
        }
    });

@yqd1992 want to do a PR and submit it to receive contribution?

I think it's need to be fixed. There is no use to create a pull request for me, it's a small change.

oh ok... I will fix it then. I thought you may want to receive the contribution.

@normanmaurer I have raised PR https://github.com/netty/netty/pull/8643 for the fix. Please let me know if you have any feedback.

As I mentioned in the PR I think this fix is not "correct" Please provide a reproducer and we can fix it tho. Closing it for now


[core] jadx-gui-1.2.0 can not decompile jar | 无法反编译jar

Looks like a spring-boot jar. lease check out the latest unstable version. There were some changes regarding JAR files that have class files in non-standard locations. Note that effectively your JAR file is not a standard JAR file as it contains classes multiple times. Jadx can not open JAR files directly and has to convert them to Android dex format, which has certain limitations.
In the end I would suggest to better use a tool that is focused on Java JAR decompiling such as JD-Gui, that will be more suitable for such a JAR file.

@geekyouth jadx not very good at handling java bytecode, so looks like you get many errors during conversion to dex (check log window). And BTW decompiled source must be placed under Source tree (you got empty because of errors).


Error: Runtime.evaluate error when 10+ pages in browser

Environment

Puppeteer version: 0.12.0
Local Platform: macOS Sierra 10.12.6
Web Platform: Heroku 16 with buildpack https://github.com/jontewks/puppeteer-heroku-buildpack

Expected Result

Launch Puppeteer browser
For each search URL, open a new page in that browser
For each new page, wait until network idle and selectors h3 and a are there
Scrape the results of the page via page.evaluate and then close that page and return the results
After all pages have been scraped, close the browser and return the results

Issue
Everything works locally, I'm only running into an issue when using on Heroku, and only when trying to open a large amount of pages on a single browser instance.
The below code works locally but fails on Heroku with the error
Error: Protocol error (Runtime.evaluate): Session closed. Most likely the page has been closed.
 at Session.send
 at ExecutionContext.evaluateHandle
 at ExecutionContext.evaluate (/app/node_modules/puppeteer/lib/ExecutionContext.js:37:31)
 at Frame.evaluate (/app/node_modules/puppeteer/lib/FrameManager.js:211:26)
 at WaitTask.rerun (/app/node_modules/puppeteer/lib/FrameManager.js:520:35)
 at new WaitTask (/app/node_modules/puppeteer/lib/FrameManager.js:503:10)
 at Frame.waitForFunction (/app/node_modules/puppeteer/lib/FrameManager.js:447:12)
 at Frame.waitForSelector (/app/node_modules/puppeteer/lib/FrameManager.js:418:17)
 at Page.waitForSelector (/app/node_modules/puppeteer/lib/Page.js:818:29)
 at Promise (/app/api/webScraping/puppeteerGoogleNews.js:65:18)
 at <anonymous>

The error only occurs on Heroku with a large amount of pages open on a single browser instance in Puppeteer, it works fine with 3-5 pages open, and works ~5% of the time with the 10 pages, but otherwise fails and throws the above error the other 95%.
Below is the code to reproduce the issue. I was double checking to make sure all pages were await'd and none were being closed before they were finished with. But the fact that it only has an issue with many pages open makes me think it might be some other issue.
const puppeteer = require('puppeteer');
getNews();
async function getNews() {
  const searchUrls = [
    'https://www.google.com/search?hl=en&gl=us&tbm=nws&tbs=sbd:1&num=10&q=BigCommerce',
    'https://www.google.com/search?hl=en&gl=us&tbm=nws&tbs=sbd:1&num=10&q=%22IBM+Websphere"+OR+"Websphere"+AND+"Commerce"+OR+"Websphere"+AND+"Retail"',
    'https://www.google.com/search?hl=en&gl=us&tbm=nws&tbs=sbd:1&num=10&q=Kibo+Commerce',
    'https://www.google.com/search?hl=en&gl=us&tbm=nws&tbs=sbd:1&num=10&q=%22Oracle"+AND+"Commerce+Cloud"+OR+"Netsuite"',
    'https://www.google.com/search?hl=en&gl=us&tbm=nws&tbs=sbd:1&num=10&q=%22OroCommerce"+OR+"Oro+Commerce"',
    'https://www.google.com/search?hl=en&gl=us&tbm=nws&tbs=sbd:1&num=10&q=PrestaShop',
    'https://www.google.com/search?hl=en&gl=us&tbm=nws&tbs=sbd:1&num=10&q=(%22Salesforce"+AND+"Commerce+Cloud")+OR+"Demandware"',
    'https://www.google.com/search?hl=en&gl=us&tbm=nws&tbs=sbd:1&num=10&q=%22SAP+Hybris"+AND+(e+commerce+OR+e-commerce+OR+retail)',
    'https://www.google.com/search?hl=en&gl=us&tbm=nws&tbs=sbd:1&num=10&q=Shopify+-%22(NYSE:SHOP)"+-"(TSE:SHOP)"+-"(SHOP)"',
    'https://www.google.com/search?hl=en&gl=us&tbm=nws&tbs=sbd:1&num=10&q=Volusion',
  ];

  // Launch browser
  const browser = await puppeteer.launch({
    args: ['--no-sandbox', '--disable-setuid-sandbox'],
  });

  // Get all results
  const searchPromises = searchUrls.map(url => singleSearch(browser, url));
  const searchResults = await Promise.all(searchPromises);

  // Close browser
  await browser.close();
}

function singleSearch(browser, url) {
  return new Promise(async (resolve, reject) => {
    // Go to page
    const page = await browser.newPage();
    await page.goto(url, { waitUntil: 'networkidle' });
    await page.waitForSelector('h3 a');

    // Log events
    page.on('console', (...args) => {
      for (let i = 0; i < args.length; i += 1) {
        console.log(`${i}: ${args[i]}`);
      }
    });

    // Get page results
    const searchResults = await page.evaluate(singlePage);

    // Close page and return results
    await page.close();
    resolve(searchResults);
  });
}

function singlePage() {
  const newsElements = document.querySelectorAll('._NId ._cy');
  const articles = [];
  for (let i = 0; i < newsElements.length; i += 1) {
    const el = newsElements[i];
    const article = {
      url: el.querySelector('div div h3 a').href,
      title: el.querySelector('div div h3').textContent,
      publication: el.querySelector('div div .slp span:first-child')
        .textContent,
    };
    articles.push(article);
  }
  return articles;
}

@jharrington-ls it looks like renderer process crashes, e.g. due to memory constrains.
I'd recommend creating a pool of pages and scheduling tasks among them. This should allow you to process URLs in parallel while avoiding creation of multiple renderers.

Thanks for the info @aslushnikov!
Was looking through the API and saw no mention of pooling pages or scheduling tasks, so just want to double check I'm understanding the solution properly.
Instead of creating and closing a page for each URL, I should instead:

Open a small amount of pages on one browser instance (e.g. 3 pages max)
Loop through URLs and send to any open page
Once a URL has been processed, instead of closing the page, send the next URL in the queue to the page, have the page go to the URL, process the results, and repeat

Is that correct? Wasn't sure what was considered a renderer or if the bulleted approach above would help with the memory constraints. Thanks again for your help.

@jharrington-ls yes, exactly this. This will restrict total amount of pages to 3; whereas in your snippet you create 10 pages simultaneously.

@jharrington-ls Did this solution work for you? I have a similar problem and tried opening just one page but ran into the same issue, which leads me to believe it's not related to the number of renders. I also found this issue, which raises more questions.


Importing from package during installation causes failure

setup.py should never import from the package it is installing.
i.e. do not do this:
from pytest_attrib import __version__

An example of one of the problems it can cause:
https://ci.appveyor.com/project/wikimedia/pywikibot-core/build/job/k3qjk8ygkdw99lj1
A simple approach that I quite like for small packages like this is
https://github.com/legoktm/jsonchecker/commit/5afe98dd5c9cc1f68655edae02570306dd157e4b

Agree, this is bad coding mainly because I was lazy.
I don't like the method done by legoktm in jsonchecker very much either, because it parses a file. (Which I find hacky)
I've made my own solution, a VERSION file which just contains the version number. So I'm using that.

This is still broken, only now broken worse than before, as it no longer works on Travis.
https://travis-ci.org/jayvdb/pywikibot-core/jobs/132423013
Golden rule: never import your own modules/packages in the setup.py.

Fixed it now. made a dev package 0.1.3.dev0 to test it too.
Here is a successful pywikibot-core travis build which uses this dev package this https://travis-ci.org/AbdealiJK/pywikibot-core/jobs/132529624 where the installation worked.
I'll be making 0.1.3 next to fix this after a bit more testing to ensure this doesn't happen again.

I've added an extra step in the CI which actually created the sdist and also installs the package from the sdist to test it out. So, hopefully this will never regress again.
This is done on appveyor and travis

I see you are still importing pytest_attrib .  IIRC, this will fail with older versions of setuptools and pip.  You will definitely find that you have stale imports at times.  http://python-notes.curiousefficiency.org/en/latest/python_concepts/import_traps.html#the-stale-bytecode-file-trap
Anyway, one way to learn is to do .. the school of hard knocks.

:3 Sorry
It's just that I find this a more "neater" solution that parsing source code.
On your suggestion I tested it with pip==6.0 and setuptools==5.5.1 and it seemed to work:
$ python -c "import pip; print pip.__version__"
6.0
(venv)ajk@ajk-ThinkPad-R60:~/Documents/wiki/deps/pytest-attrib$ python -c "import setuptools; print setuptools.__version__"
5.5.1
(venv)ajk@ajk-ThinkPad-R60:~/Documents/wiki/deps/pytest-attrib$ pip install pytest-attrib
You are using pip version 6.0, however version 8.1.2 is available.
You should consider upgrading via the 'pip install --upgrade pip' command.
Collecting pytest-attrib
  Using cached pytest-attrib-0.1.3.tar.gz
Requirement already satisfied (use --upgrade to upgrade): pytest>=2.2 in /home/ajk/Documents/wiki/venv/lib/python2.7/site-packages (from pytest-attrib)
Requirement already satisfied (use --upgrade to upgrade): py>=1.4.29 in /home/ajk/Documents/wiki/venv/lib/python2.7/site-packages (from pytest>=2.2->pytest-attrib)
Installing collected packages: pytest-attrib
  Running setup.py install for pytest-attrib
Successfully installed pytest-attrib

Both of which came out ~2014. I think that's old enough ^^

This is still what people use:
http://packages.ubuntu.com/search?suite=precise&searchon=names&keywords=python-pip
http://packages.ubuntu.com/search?suite=precise&searchon=names&keywords=python-setuptools

Sigh ... sometimes I hate those LTS releases ...
Anyway, it works with pip==1.0 and setuptools==0.6rc11 too. (I had to use setuptools rc11 because 0.6.24 isn't in pip and pip==1.0 doesnt have __version__ so i can't print that...)
$ python -c "import setuptools; print setuptools.__version__"
0.6c11
$ pip install pytest-attrib
Downloading/unpacking pytest-attrib
  Downloading pytest-attrib-0.1.3.tar.gz
  Running setup.py egg_info for package pytest-attrib

Downloading/unpacking pytest>=2.2 (from pytest-attrib)
  Downloading pytest-2.9.1.tar.gz (700Kb): 700Kb downloaded
  Running setup.py egg_info for package pytest

    warning: no previously-included files found matching '_pytest/impl'
    warning: no previously-included files matching '*.pyc' found under directory '*'
    warning: no previously-included files matching '*.pyo' found under directory '*'
    warning: no previously-included files found matching 'appveyor/install.ps1'
    warning: no previously-included files found matching 'appveyor.yml'
    warning: no previously-included files found matching 'appveyor'
    warning: no previously-included files found matching 'ISSUES.txt'
    warning: no previously-included files found matching 'HOWTORELEASE.rst'
Downloading/unpacking py>=1.4.29 (from pytest>=2.2->pytest-attrib)
  Downloading py-1.4.31.tar.gz (192Kb): 192Kb downloaded
  Running setup.py egg_info for package py

Installing collected packages: pytest-attrib, pytest, py
  Running setup.py install for pytest-attrib

  Running setup.py install for pytest

    warning: no previously-included files found matching '_pytest/impl'
    warning: no previously-included files matching '*.pyc' found under directory '*'
    warning: no previously-included files matching '*.pyo' found under directory '*'
    warning: no previously-included files found matching 'appveyor/install.ps1'
    warning: no previously-included files found matching 'appveyor.yml'
    warning: no previously-included files found matching 'appveyor'
    warning: no previously-included files found matching 'ISSUES.txt'
    warning: no previously-included files found matching 'HOWTORELEASE.rst'
    Installing py.test script to /home/ajk/Documents/wiki/venv/bin
    Installing py.test-2.7 script to /home/ajk/Documents/wiki/venv/bin
  Running setup.py install for py

Successfully installed pytest-attrib pytest py
Cleaning up...
$ python -c "import pytest_attrib; print pytest_attrib.__version__"
0.1.3


feat: remove "incremental: true" from ts default options

As incremental mode has some assumptions regarding changes that can occur in the project, sometimes the user has to remove .tsbuildinfo files manually to fix it. Because of that, we should not enable incremental mode by default - it should be a conscious choice of the user.
BREAKING CHANGE: 🧨 Remove "incremental: true" from default typescript options

:tada: This PR is included in version 5.0.0-beta.7 :tada:
The release is available on:

npm package (@beta dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 5.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Can't create GCSFileSystem with instance of google.oauth2.service_account.Credentials

When trying to create an instance of GCSFileSystem by passing in a service account Credentials object, an error is thrown in the _connect_token method.
System Details:
Python version 3.6.7 64-bit, on Ubuntu 18.04.1 (WSL)
gcsfs==0.2.2
google-auth==1.6.3
google-auth-oauthlib==0.3.0
Expected Behavior:
For GCSFileSystem to successfully connect with provided the service account credentials.
Actual Behavior:
ValueError: Token format no understood
Steps to Recreate:
Run this code (fill in the relevant details):
import google.oauth2.service_account
import gcsfs

# Make google.oauth2.service_account.Credentials object
key_path = "/path/to/key_file.json"
scopes = ["https://www.googleapis.com/auth/devstorage.full_control"]
credentials = (
    google.oauth2.service_account.Credentials.from_service_account_file(
        key_path, scopes=scopes)
)
# Try to make gcsfs (will raise "ValueError: Token format no understood")
project="PROJECT-NAME"
gcsfs.GCSFileSystem(project=project,token=credentials)

I'm hitting similar confusion with a service account, where the class of object seems ambiguous.
Maybe tripping on elif isinstance(token, Credentials): in core.py
I can't pass the credentials of a service account as a token (maybe I shouldn't be doing this), e.g.
gcs = gcsfs.GCSFileSystem(project='myproject-jupyterhub', token=gcs_service_account.session.credentials)`

The type of the credentials object seems to vary:
gcs_service_account.session.credentials
<google.oauth2.service_account.Credentials at 0x7fa6d25aa6d8>

gcs_service_account.session.credentials
<google.auth.compute_engine.credentials.Credentials at 0x7fd2697608d0>

So I guess the check for a valid Credentials object is being confused by the namespace clash? e.g.
from google.oauth2.credentials import Credentials as oauth2Credentials
isinstance(gcs_service_account.session.credentials, oauth2Credentials)

from google.auth.compute_engine import Credentials as authCredentials
isinstance(gcs_service_account.session.credentials, authCredentials)

Or maybe this is expected behaviour and the wrong way to roll?

I think the issue is that the Google auth libraries implement different concrete types of Credentials, for App Engine, OAuth2, service accounts, etc.
Looking at the auth library's source code it seems the correct class to check is google.auth.credentials.Credentials, which is the ABC that all the other classes use.

Google have had a history of moving around these definitions, so happy to change the instance check to whatever seems to be the most appropriate right now. Would someone like to put this in a PR?

I haven't tried changing just the instance check yet, but I can at least say that changing
from google.oauth2.credentials import Credentials

To
from google.auth.credentials import Credentials

in gcsfs/core.py
allows me to pass a service account's session.credentials as a token, i.e. it satisfies isinstance(token, Credentials) in core.py, with it's type being reported as google.oauth2.service_account.Credentials
It looks like Credentials is used in one other place in core.py, in _dict_to_credentials:
            token = Credentials(
                None, refresh_token=token['refresh_token'],
                client_secret=token['client_secret'],
                client_id=token['client_id'],
                token_uri='https://www.googleapis.com/oauth2/v4/token',
                scopes=[self.scope]

So I gather that would need testing, if the PR went the route of changing the import.
I run into downstream errors with Failed to Serialize, but I expect that's a different issue.
I have a similar use-case to @jiajie-chen, using gcsfs with Dask, where I ideally want to use a service account rather than authenticate via a user account or a browser token (or cached .gcs_tokens).

@martindurant I can put together a quick PR for this, but it might need some further testing to ensure all classes of Credentials work correctly.
@leehart the Failed to Serialize error might have something to do with deepcopying Credential objects? I think something in them isn't serializable/deepcopyable, but it needs further investigation.


Service Uninstalled After Windows Update?

This is a strange issue, and I'm hoping someone else has encountered it before.  After major Windows updates (like the Fall Creators Update), an app that is installed as a service via Topshelf is somehow removed as an installed service.  All of the executable files are there, but the service is just gone.  It doesn't show up in the list of services anymore.
I can reinstall it, and that works fine, but I'm trying to figure out why it is being removed in the first place.  Anyone have any ideas or suggestions?  I've seen this happen twice now, on two different machines.

Googling around, it is evident that you're not the only one affected. See for example this article.
I'm afraid you're out of luck and re-installing is the only option. Perhaps you can script this to check automatically after a reboot or something.

Right, this is an issue with Windows.

Thanks for confirming!  That's what I suspected, I just hadn't heard other reports of the issue until now.


Added support for a couple of components and added typing for undocum…

Added support for a couple of basic chart types to useChart (scatter, timeline, funnel) which are needed in aevidence
Added typed for events that are not officially typed (like brushselected, brush, etc)
The event params are unknown and need to be typed in the corresponding event handler

@dvmoritzschoefl The node job is still failing. Could check it and fix it?


feat(Stepper): Class name & specificity refactor

Wizard default & wizard long renamed to Stepper.
Wizard workflow renamed to Workflow diagram.
Reduced stepper & workflow diagram specificity from 0,5,1 to 0,2,1.

I submitted this PR early so we can take a look at it and see if this is something we want to target.. If not, we can close it before I spend any more time on it.

It is a lot of changes to review, it might take a while. We either close this PR or leave it till the end of v1 to see how many stuff is still there and how much time we have.

It is a lot of changes to review, it might take a while. We either close this PR or leave it till the end of v1 to see how many stuff is still there and how much time we have.

Closing for now, I would like to revisit this PR after CSS 1.0 because of the reduced specificity and fewer HTML elements.


Better xml env var substitution

More usable feature, plus some minor cleanup.

This looks good to me. I really like the solution of using the environment variable if present, but using it as a literal if it doesn't match an environment variable. Especially with the length check.
Looks good, ready for merge.


[DateTimePicker] Adds start, end and step time select attributes

Currently a TimePicker is able to have the start time, end time and step set through the picker-options but this does not carry through to DateTimePicker's. This pull request adds these attributes in.
Please make sure these boxes are checked before submitting your PR, thank you!

[x] Make sure you follow Element's contributing guide (中文 | English | Español).
[x] Make sure you are merging your commits to dev branch.
[x] Add some descriptions and refer relative issues for you PR.

It does not work this way.
These options are for time-select only. They do not work with time-picker which is used in date-time-picker.


older template with literal datatypes does not seem to recognize those datatypes, except to add the type to the RDF

I made this template a while back to test datatypes on literals:
https://development.sinopia.io/editor/resourceTemplate:testing:literalValidation
this was before we validated them on the Editor side.
now I try to open it for cataloging, and for the fields with a datatype validation (Fields 3-6), there's no "special" help text, and the fields seem to accept any value, as in this filled out version
https://api.development.sinopia.io/resource/6db068c8-3f7d-4d6f-b010-53ece90a1600
where the preview shows that 'abc' is an integer and '777' is a dateTime
'
Field 2, which has a regex specified, seems to work as expected.
what's strange is, I copied the template, then redid the datatype validations (by deleting and re-specifying). and that fixed the problem of the fields not validating or showing help text (except for EDTF help text, ticketed separately)
did we change the way datatypes are specified? I'm only concerned if this means other templates people set up between release 3.12 and 3.13 might not be working as expected wrt datatypes

Yes, initially we were using incorrect URI for datatypes: http://www.w3.org/2001/XMLSchema/dateTimeStamp is incorrect; http://www.w3.org/2001/XMLSchema#dateTimeStamp is correct.
This was changed on Nov. 18. I'm not sure how this corresponds with releases.

thanks for tracking this down. sorry was prob my bad in orig ticket specifying what URI to use


External Monitor with miniDP black screen

Hello @CLAY-BIOS
First, I thank you for this repo, and work you doing hard here 👏👏
I found a little problem, when I connect Monitor with miniDP, the system crashes, if system is running, after connect miniDP here a black screen and not response from notebook, or if I launch notebook with miniDP, here a cyclic reboot.
I'm asking a help with this problem.
Thanks.

Hello @CLAY-BIOS
First, I thank you for this repo, and work you doing hard here 👏👏
I found a little problem, when I connect Monitor with miniDP, the system crashes, if system is running, after connect miniDP here a black screen and not response from notebook, or if I launch notebook with miniDP, here a cyclic reboot.
I'm asking a help with this problem.
Thanks.

Tell me your system version and machine model.
Try to select reset NVRAM in the boot interface to clear NVRAM.

Thinkpad T450 (HD5500)

I already solved this problem, just remove custom configurations from config.plist about videocard information.
Thanks for reply


bot background sounds

Please describe the changes in your PR. If it is addressing an issue, please reference that as well.

Closing in favor of #687


[Feature]: Allow running remix setup without a specific platform

What is the new or updated feature that you are suggesting?
Right now the remix setup cli accepts two options: node and cloudflare-workers and default to node if not specified.
It would be nice if we can either:
(1) Have a 3rd option, e.g. remix setup custom, or
(2) Make default skip the platform package (or silently ignore it if @remix-run/node is not installed for non-breaking behaviour..?)
Why should this feature be included?
Currently, Remix teaches everyone to import things from the remix package which relies on the magicExport feature fromremix setup. However, the CLI does not work unless an official adapter is presented. This makes it non-trivial to experiment with custom adapters as server and clients exports cannot be re-exported from remix in this case.

Closing this, as we will soon be deprecating remix setup altogether in favor of direct imports from sub-modules. See the release notes in 1.4.0 for details.


Memory leak issue in video player with VideoPlayerController.network

Hello guys can anyone please help me with the below problem?
Error
A connection to http://flutter.github.io/ was leaked. Did you forget to close a response body?
Problem statement.
I am creating e-commerce app that has a carousel with video and images in it. For the video player I am using chewie and video_player plugins and for carousal I amusing carousel_slider.I have created a stateful widget according to chewie docs and returning that widget to carousal builder. The code is running but I am getting this memory leak error. Please help, thanks in advance. Attaching the snippet of chew class that loads video player and carousel slider.
`class Chew extends StatefulWidget {
Chew({Key key}) : super(key: key);
@override
_ChewState createState() => _ChewState();
}
class ChewState extends State {
ChewieController chewieController;
VideoPlayerController videoPlayerController;
Chewie playerWidget;
@override
void initState() {
super.initState();
var chewieController = ChewieController(
videoPlayerController: VideoPlayerController.network(
'http://flutter.github.io/assets-for-api-docs/assets/videos/butterfly.mp4')
..initialize().then(() {
setState(() {});
}),
// ..play(),
autoInitialize: false,
allowMuting: true,
aspectRatio: 3 / 2,
autoPlay: false,
looping: false,
showControlsOnInitialize: true,
);
playerWidget = Chewie(
controller: chewieController,
);
}
@override
Widget build(BuildContext context) {
return Container(
child: playerWidget,
);
}
@override
void dispose() {
videoPlayerController.dispose();
chewieController.dispose();
super.dispose();
}
}
CarouselSlider(
options: CarouselOptions(
height: 400.0,
viewportFraction: 0.8,
initialPage: 0,
enableInfiniteScroll: false,
reverse: false,
autoPlay: false,
// autoPlayInterval: Duration(seconds: 3),
// autoPlayAnimationDuration: Duration(milliseconds: 800),
autoPlayCurve: Curves.fastOutSlowIn,
enlargeCenterPage: true,
onPageChanged: (viewModel.onCarousalPageChanged()),
scrollDirection: Axis.horizontal,
),
items: [1, 2].map((value) {
return Builder(
builder: (BuildContext context) {
return Chew();
},
);
}).toList(),
)`

Solved. Video was down


2.3.1 Http/Client Does not accept blank Accept-Encoding

According to http://www.w3.org/Protocols/rfc2616/rfc2616-sec14.html,
A blank Accept-Encoding is valid
If the Accept-Encoding field-value is empty, then only the "identity" encoding is acceptable.
However, Zend\Http\Header\AbstractAccept->getFieldValuePartsFromHeaderLine throws an exception if the value is empty.

This issue has been closed as part of the bug migration program as outlined here - http://framework.zend.com/blog/2016-04-11-issue-closures.html


AMDA : downloading multidimensional data fails

Space Physics WebServices Client version: 0.9.0
Python version: 3.8.10
Operating System: Linux Ubuntu 20.04.2

Description
When downloading multidimensional data pandas fails to load CSV data because of duplicates in the column names. This is due to the fact that column names are obtained by splitting the character sequence by "," when comma characters appear in individual column names.
For multidimensional data columns are named "x[i,j],x[i,j+1],...,x[i+1,0],....etc"
Simple fix : split using ", " separator instead (file speasy/webservices/amda/utils.py, line 36)
What I Did
import speasy as spz
p = spz.get_data("amda/psp_spe_EvsEvspa", "2020-07-30", "2020-07-31")

  File "/home/aschulz/Documents/python/speasy_module/speasy_official/speasy/speasy/webservices/amda/utils.py", line 38, in load_csv
    data = pds.read_csv(f, comment='#', delim_whitespace=True, header=None, names=columns).values.transpose()
  File "/home/aschulz/.local/lib/python3.8/site-packages/pandas/io/parsers.py", line 676, in parser_f
    return _read(filepath_or_buffer, kwds)
  File "/home/aschulz/.local/lib/python3.8/site-packages/pandas/io/parsers.py", line 445, in _read
    _validate_names(kwds.get("names", None))
  File "/home/aschulz/.local/lib/python3.8/site-packages/pandas/io/parsers.py", line 413, in _validate_names
    raise ValueError("Duplicate names are not allowed.")

Pull request #25 submitted addressing this issue


feat: enhance hover doc format

Hi there! Is it possible to make the first row on the hover doc to be multiple lines? eg.

I expect the first separator line to get placed at the line where that is marked with a red line. This is causing some issue when it doesn't have enough space until the { symbol so the highlight got messed up. Here's an example

Thanks in advance!

May be is a bug, it should not be insert  the truncated line  to index 2. fixed it later.

May be is a bug, it should not be insert  the truncated line  to index 2. fixed it later.

I have this config for lspsaga.
require"lspsaga".init_lsp_saga({
  max_hover_width = 80,
  border_style = 1,
  use_saga_diagnostic_handler = false,
  use_saga_diagnostic_sign = false
})

Then hover to any javascript function that has a long documentation like filter, map, etc.

I have this config for lspsaga.
require"lspsaga".init_lsp_saga({
  max_hover_width = 80,
  border_style = 1,
  use_saga_diagnostic_handler = false,
  use_saga_diagnostic_sign = false
})

Then hover to any javascript function that has a long documentation like filter, map, etc.

can provide a min js code? like your bug pic function readdirSync

can provide a min js code? like your bug pic function readdirSync

Aha I know what happen. because you set the max_hover_width so the length of first line will be wraped..

Aha I know what happen. because you set the max_hover_width so the length of first line will be wraped..

Is it possible to make it work even if I set the max_hover_width? I don't really like when the hover popup being so wide when the content inside it is really long.

Is it possible to make it work even if I set the max_hover_width? I don't really like when the hover popup being so wide when the content inside it is really long.

I am thinking about it.  I want we can have a smart height and width. not a fix number that this way can't works fine with any window size.

I am thinking about it.  I want we can have a smart height and width. not a fix number that this way can't works fine with any window size.

@elianiva  Now works like this in my local

@elianiva  Now works like this in my local

That looks great!

That looks great!

yep. now I want to make a smart width and height value not depend max_hover_width or smomething

yep. now I want to make a smart width and height value not depend max_hover_width or smomething

agree, that would be ideal

agree, that would be ideal


Changed @ngrx/store peer dependency version to >=4.0.0.

Since ngrx-store-logger uses so little of the NgRx API, I think it's best to allow arbitrary future versions.

Makes sense, thanks!

I’m getting merge conflicts, can you update? Thanks!

Ngrx 7 should be right around the corner now. Have you had time to look at this?

Friendly ping @btroncone

Another friendly ping @btroncone, it's been working fine for me on 11.1.1!

Any idea when this change is likely to be merged in and published?

any chance of merging this?

Is this change going to be merged anytime soon?

Could you please merge this?

We've been updating our fork if you want to use that https://github.com/zeropsio/ngrx-store-logger


BUG: stats: Fix broadcasting in wrapcauchy.cdf

Also added a few tests for specific values of the CDF.
Closes gh-13791.

Looks like CircleCI is having problems in recent PRs.  The changes here should have no effect on the docs.
CircleCI doesn't show the errors if you don't login in CircleCI, and I'm still resistant to giving yet another service write access to my github repos, so I'm not sure what is going wrong.  I can build the docs locally with only the usual warnings.

CircleCI doesn't show the errors if you don't login to CircleCI, and I'm still resistant to giving yet another service write access to my github repos, so I'm not sure what is going wrong.

CircleCI knows all my secrets so I've opened the issue here: gh-13793

I think the CircleCI issue is fixed but you'd need to merge master.

I could probably study it and figure it out, but how did you save so many lines? What was the calculation doing that was unnecessary?

A fix with fewer lines changed is to just add the line
    x, c = np.broadcast_arrays(x, c)

immediately after def _cdf(self, x, c):.  But _lazywhere already does (more or less) what this function's code was doing, so we might as well continue following the _lazywhere pattern.
I did a couple performance comparisons, and the _lazywhere version was either very close to or better than the existing version.  For example, with x = np.linspace(0, 2*np.pi, 500) and c = np.array([[0.03], [0.25], [0.75]]), the call wrapcauchy.cdf(x, c) took 349 µs with the _lazywhere version, while the original version (with the broadcasting fix) took 373 µs.

Checked carefully. Looks good. Thanks @WarrenWeckesser.


Prevent ogres from triggering without enemy minions

Coverage increased (+0.01%) to 98.66% when pulling 5907798b0214fb44f7ae0aee0b35bfb0574115f9 on anka-213:ogre_misdirection into b2f8bab46c51ebb9cb8a506530b4c00e4b32ac6c on danielyule:master.

Looks good.  I'm glad that someone got this working right.


plugin not loaded in lunarvim

Hi,  as the title said. my config is:
table.insert(lvim.builtin.cmp.sources, { name = 'dictionary', keyword_length = 2 })
lvim.builtin.cmp.formatting.source_names['dictionary'] = ''

lvim.plugins = {
  { 'uga-rosa/cmp-dictionary', before = 'nvim-cmp',
    config = function()
      require 'cmp_dictionary'.setup {
        async = true,
        capacity = 5,
        dic = { ['*'] = '/path/to/words' }
      }
    end }, -- vim dictionary source for cmp
}

when i run: PackerLoad cmp-dictionary, it reports:
Error: attempted to load cmp-dictionary which is not present in plugins table!
Error in packer_compiled: ...m/site/pack/packer/start/packer.nvim/lua/packer/load.lua:135: Error: attempted to load cmp-dictionary which is not present in plugins table!
Please check your config for correctness

Could you please take a look or correct my error, mant thanks

It's not an issue with this plugin. Read the lunarvim documentation.


How to disable generating parameters for headers using SwaggerToCSharpWebApiControllerGenerator

Swagger document:
{
  "swagger": "2.0",
  "paths": {
    "/authorization": {
      "put": {
        "operationId": "Test",
        "parameters": [
          {
            "name": "Authorization",
            "in": "header",
            "required": true,
            "type": "string"
          }
        ],
        "responses": {
          "204": {
            "description": ""
          }
        }
      }
    }
  }
}

Generated code:
namespace MyNamespace
{
    #pragma warning disable // Disable all warnings

    [System.CodeDom.Compiler.GeneratedCode("NSwag", "9.6.6264.38294")]
    public interface IController
    {
        System.Threading.Tasks.Task TestAsync(string authorization);

    }

    [System.CodeDom.Compiler.GeneratedCode("NSwag", "9.6.6264.38294")]
    public partial class Controller : System.Web.Http.ApiController
    {
        private IController _implementation;

        public Controller(IController implementation)
        {
            _implementation = implementation;
        }

        [System.Web.Http.HttpPut, System.Web.Http.Route("authorization")]
        public System.Threading.Tasks.Task Test(string authorization)
        {
            return _implementation.TestAsync(authorization);

        }

    }

}

This is currently not possible. Do you need this setting on a per operation basis or global?

By default Web API binds parameters only from the URI or the message body, so Swagger header parameters should not be generated at all by SwaggerToCSharpWebApiControllerGenerator.

Ah sorry, this is for the controller generator... There we should exclude headers or use FromHeader attribute when generating .net core controllers (not supported yet). Can you create a pr with this?

Currently, only Web API 2 controllers (System.Web.Http.ApiController) are supported and generated by SwaggerToCSharpWebApiControllerGenerator using ControllerTemplate.tt.
To my mind, this template should not generate headers at all.
As for .Net Core MVC (Microsoft.AspNetCore.Mvc.Controller) support, there might be so many differences between Web API 2 and .Net Core MVC to introduce the new SwaggerToCSharpCoreMvcControllerGenerator, which could use new settings and a new template.


Korean Translation Progress

Maintainer List

@taehwanno
@simsim0709
@hg-pyun
@gnujoow
@b9words
@taggon

For New Translators
To translate a page:

Check that no one else has claimed your page in the checklist and comments below.
Comment below with the name of the page you would like to translate. Take only one page at a time.
Check out prior works in #4 before you get started.
Clone this repo, translate your page using with this checker, and submit a pull request!

Before contributing, read the glossary and this wiki page to understand how to translate various technical and React-specific terms.
Please be prompt with your translations! If you find that you can't commit any more, let the maintainers know so they can assign the page to someone else.
Please join in React Korea Slack #translation channel if you are interested in the translation.
For maintainers
When someone volunteers, edit this issue with the username of the volunteer, and with the PR. Ex:

[ ] Home Page (@tesseralis) #1

When PRs are merged, make sure to mark that page as completed!
Core Pages
To do before releasing as an "official" translation. Please translate these pages first.

[x] Home Page (@chatoo2412) #8
[x] Tutorial (@noahluftyang) #111

Basics

[x] Hello World (@chayeoi) #9
[x] Introducing JSX (@rkdmen) #18
[x] Rendering Elements (@BKJang) #21
[x] Components and Props (@purelledhand) #35
[x] State and Lifecycle (@rlagksruf16) #95
[x] Handling Events (@Godsenal) #19
[x] Conditional Rendering (@Jonir227) #26
[x] Lists and Keys (@Jravvit) #85
[x] Forms (@hyunalee419) #30
[x] Lifting State Up (@chayeoi) #109
[x] Composition vs Inheritance (@hewonjeong) #22
[x] Thinking in React (@yesjin-git) #77

API Reference

[x] React (@cadenzah) #12
[x] React.Component (@cadenzah) #76
[x] ReactDOM (@noahluftyang) #28
[x] ReactDOMServer (@Injae-Lee) #68
[x] DOM Elements (@stepover10) #67
[x] SyntheticEvent (@Beingbook) #32
[x] Test Utilities (@ymin1103) #43
[x] Shallow Renderer (@hmu332233) #40
[x] Test Renderer (@hiddenest, @toy9910) #37, #190
[x] JS Environment Requirements (@taggon) #34
[x] Glossary (@gnujoow) #16

Navigation
These are the navigation links that appears in the sidebar. Possibly wait until
the corresponding sections are translated to do these.

[x] tutorial/nav.yml (@taehwanno) #87
[x] docs/nav.yml (@taehwanno, @rkdmf1026) #84, #189

Next Steps
These are the next most important translations, ordered by importance:
Installation

[x] Getting Started (@MDJuniooor) #50
[x] Add React to a Website (@ymin1103) #101
[x] Create a New React App (@OnesQuared) #64
[x] CDN Links (@gnujoow) #44
[x] Release Channels (@thinkanddoit) #269

Hooks
Everyone is hooked on hooks! People are really excited for these and it would be great for them to be translated.

[x] Introducing Hooks (@Geon-wooBryanKim) #33
[x] Hooks at a Glance (@chatoo2412) #6
[x] Using the State Hook (@nghy97) #65
[x] Using the Effect Hook (@yumidev) #205
[x] Rules of Hooks (@BeomyeonAndrewKim) #63
[x] Building Your Own Hooks (@yumidev) #230
[x] Hooks API Reference (@hapumee) #89
[x] Hooks FAQ (@seanjun21) #265

Warnings
These are the pages that you get when you click the links in the console (e.g. https://reactjs.org/warnings/dont-call-proptypes.html). People tend to search these, so please don't translate the error message itself.

[x] dont-call-proptypes (@simsim0709) #52
[x] invalid-aria-prop (@simsim0709) #57
[x] invalid-hook-call-warning (@simsim0709) #61
[x] legacy-factories (@simsim0709) #58
[x] refs-must-have-owner (@simsim0709) #69
[x] special-props (@simsim0709) #59
[x] unknown-prop (@simsim0709) #70

Advanced Guides

[x] Accessibility (@hiddenest) #46
[x] Code-Splitting (@liante0904) #55
[x] Context (@phoebejhhong) #79
[x] Error Boundaries (@anthonyminyungi) #222
[x] Forwarding Refs (@hapumee) #260
[x] Fragments (@yoeubi) #83
[x] Higher-Order Components (~@gnujoow~ @dev-hikun) ~#187~ #286
[x] Integrating with Other Libraries (@yoeubi) #121
[x] JSX In Depth (@hIkipooh) #100, #177
[x] Optimizing Performance (@BeomyeonAndrewKim) #119
[x] Portals (@hapumee) #131
[x] Profiler (@hIkipooh) #238
[x] React Without ES6 (@ymin1103) #29
[x] React Without JSX (@shiincs) #86
[x] Reconciliation (@hewonjeong) #60
[x] Refs and the DOM (@ENvironmentSet) #13
[x] Render Props (@hg-pyun) #73
[x] Static Type Checking (@jiwonkirn) #88
[x] Strict Mode (@hiddenest) #47
[x] Typechecking With PropTypes (@sukjae) #78
[x] Uncontrolled Components (@hyunalee419) #66
[x] Web Components (@hiddenest) #48

FAQ

[x] APIs and AJAX (@sukjae) #80
[x] Babel, JSX, and Build Steps (@sukjae) #81
[x] Passing Functions to Components (@sdu6342) #105
[x] Component State (@ejolie) #102
[x] Styling and CSS (@sukjae) #223
[x] File Structure (@highspirit7) #107
[x] Versioning Policy (@hapumee) #132
[x] Virtual DOM and Internals (@dl0312) #113

Contributing
Priority: Low

[x] How to Contribute (@Kim-Ki-Soo) #126
[x] Codebase Overview (@Kimguyeop) #123
[x] Implementation Notes (@baekjuwon) #129
[x] Design Principles (@hapumee) #133

Components
Components in src/components that have some text in them.

[x] CodeEditor (@taggon) #361
[x] CodeExample (@taggon) #361
[x] ErrorDecoder (@hikipooh) #219
[x] LayoutFooter (@hoony2520) #122
[x] LayoutHeader (@AlexKoala) #56
[ ] MarkdownPage (@dexterastin)

Additional Translations
These are not the primary translation targets.

[ ] Blog
[ ] Community

Translations added after this issue creation
Testing

[x] Testing Overview (@koDaegon) #179
[x] Testing Recipes (@cdsleaf) #201
[x] Testing Environments (@BeomYoung) #183

Concurrent Mode (Experimental)

[x] Introducing Concurrent Mode (@Yohan-Kim2) #186
[x] Suspense for Data Fetching (@cadenzah) #221
[x] Concurrent UI Patterns (@Beingbook) #224
[x] Adopting Concurrent Mode (@junsikshim) #182
[x] Concurrent Mode API Reference (@DDOLDDOL) #192

@tesseralis Hi. Thanks for kind explanation.
Can you change the glossary link in issue description to this reactjs.org link?
This link may change if a style guide for Korean translation is created.

For new translators :runner:, Please first check out #4

@taehwanno you should be able to edit the issue directly! Just click the ellipsis > "Edit"

@tesseralis I tried, but I do not seem to have the authority :)

Ah! Sorry, I thought you were already one of the maintainers. I can add you to the list! You've done a lot of good work already finding all those resources!

@tesseralis Sweet, Thanks.

@tesseralis I am a contributor of React Crowdin project, but there is no progression for a long time at all. Is really able to work in crowdin project? And what's your plan for merging PRs & Crowdin translations?

Hi @seungha-kim .
Please see the original issue here: https://github.com/reactjs/reactjs.org/issues/1605
Long story short, we decided that doing the translations directly on Github was the better approach since:

Developers are more likely to understand git version control
People are interested in contributing to the React repo

As for integrating Crowdin, we're encouraging people to use the Crowdin translations as a base. So you can just copy-paste your work from Crowdin, verify that it's up to date, and submit a pull request!

I think there is no motivation to use Crowdin then :( I am likely to do job once using Git, rather than twice.

I have a translation of Hooks at a Glance page. I will polish and submit PR.

@chatoo2412 thank you for you PR! In the future, please let us know in a comment here when you're working on a page, so that we don't duplicate work with others. Also, we'd like to focus on the sections listed under "Core Pages"!

@tesseralis I wanted to contribute using my prior work. I'll continue with Home Page today.

@tesseralis I want to start off with API Reference.

@hg-pyun @simsim0709 @gnujoow , as maintainers, could you keep track of this issue and assign people by editing the issue?

@hg-pyun @simsim0709 @gnujoow , as maintainers, could you keep track of this issue and assign people by editing the issue?

I will 👍

@gnujoow is this document available to translate?
If it is, I want to translate it. can I?

@gnujoow is this document available to translate?
If it is, I want to translate it. can I?

@ENvironmentSet of course you can! please do 😄

I want to work on Hello World.

@tesseralis yes, I will. Thanks

@gnujoow is this document available to translate?
If it is, I want to translate it. can I?

I want to participate in the translation. Could you invite me please? 😊

@purelledhand Oh, Did you meant translation of refs-and-the-dom document?

Following React Top-level API, I will translate the next document, React.Component

@cadenzah you got it!

@tesseralis I’ll take Introducing JSX

@rkdmen Thanks. You got it.

If it's available, I wanna translate ReactDOM part.

@purelledhand Oh, Did you meant translation of refs-and-the-dom document?
or just translation of react document?

the latter one. I wanna take Components and Props

@purelledhand then you should ask to maintainer. I'm not a maintainer.

@noahluftyang Thanks. You got it.

@purelledhand You got it. :rocket:

I wanna take Handling Events !

@Godsenal Thanks. You got it!

I wanna take Rendering Elements If it's possible.

@BKJang Thanks. you got it.

Can I get Conditional Rendering?

Can I get Using the State Hook?

Can I get Introducing Hooks ?

@Jonir227 @nghy97 @Geon-wooBryanKim
Thanks. You all got it!

@b9words In the future, if the new translators themselves do not have any prior translations, I think that we need to encourage them to translate "Core Pages" rather than "Next Steps" to follow community guidelines. 😄

@b9words In the future, if the new translators themselves do not have any prior translations, I think that we need to encourage them to translate "Core Pages" rather than "Next Steps" to follow community guidelines. 😄

Right. Thanks for the guidance.

Can I get Composition vs Inheritance?

@hewonjeong Thanks. You got it.

Can I translate Using the Effect Hook? @taehwanno

Can I get Lists and Keys? @taehwanno

@yesjin-git May I ask you to translate Core Pages first?
@Jravvit Yes. you got it. thanks

@taehwanno all right. Then I want to start with Thinking in React part :)

@yesjin-git Thanks. you got it :thumb:

Can I get Forms? @taehwanno

@LeeHyun-A Yes. you got it. thanks

@taehwanno I wanna take state and lifecycle. Is it okay?

@rlagksruf16 you got it. thanks.

Can I get DOM Elements? @taehwanno

@stepover10 Thanks. you got it.

Please, change my name `LeeHyun-A' to 'hyunalee419'. Sorry... 😅

@hyunalee419 Updated

I will do Higher-Order Components by 22nd Fed.

Can I get ReactDOMServer? @taehwanno

@Injae-Lee thanks. you got it.

could I try SyntheticEvent?

@Beingbook thanks. you got it.

Can I take {Test Utilities}?

@ymin1103 you got it. thanks :)

Is "Forwarding Refs" available for me? I want to translate it.

@ENvironmentSet, it's not taken yet. You can do it. Thanks.

Can I take Fragments? If it's available please assign me 😆

@noahluftyang May I ask you to translate “Core Pages” first? 😄

Can I take “Rules of Hooks”?

@hmu332233 May I ask you to translate “Core Pages” first?

sure.
um. I want to translate "shallow renderer".
can I take?

@hmu332233 Thanks for understanding. you got it.

@taehwanno Hi! Could I take "Test Renderer"?
If it's ok, please let me know :)

@hiddenest Thanks. you got it.

@taehwanno  Hi! Can I take "docs/nav.yml" ?

@taehwanno It seems that all Core Pages are assigned to somebody 😅... please let me know anything available!

@taehwanno Could I take 'Rules of Hooks' section?

@MDJuniooor "Getting Started" please. thanks :)
@noahluftyang Then, can you translate "Tutorial"? This part is so long. 😢
@BeomyeonAndrewKim Thanks. you got it.

@taehwanno Okay, I will do 🤣

@noahluftyang Ahh! Thanks. 🚀 🚀🚀🚀🚀🚀🚀

@taehwanno oh, could I get "Fragment" too?

@taehwanno ~oh, could I get "Fragment"?~ oops, @noahluftyang already said that 😂
It seems like 'Core Pages' are all assigned to someone. could we start translating 'Next Steps'?

@hiddenest Yes. it's time to start "Next Steps".
They are listed in order of importance. Please choose what you want.

@taehwanno ok, then could I take Accessibility and Portals?

@hiddenest Take only one page at a time please :)

@taehwanno oh, I see. then could I take Accessibility? :)

@hiddenest thanks. you got it.

Can I take Add React to a Website?

@ymin1103 yes. you got it. thanks.

Ive just made pr for installation/cdn-links

I'm looking to contribute to the translation effort of react
Could I be able to take create-a-new-react-app.md?

@OnesQuared thanks. you got it.

@taehwanno Could I take 'Code-Splitting' section?

@liante0904 thanks. you got it.

@taehwanno Could I take "Strict Mode"?

@hiddenest Yes. you got it. thanks.

@taehwanno could I take 'Web Components'?

@hiddenest Go ahead! thanks :)

@taehwanno Can I take 'Using the Effect Hook'?

@yumidev Thanks. you got it.

How are things going over here?  Please let me know if you need any help or advice!

@taehwanno Could I take 'Reconciliation'?

@hewonjeong Thanks. you got it.

Could I take 'Optimizing Performance'? I'm waiting for review #63. But I hope to take that :)

@BeomyeonAndrewKim thanks. you got it.

@taehwanno Could I take 'Uncontrolled Components'?

@hyunalee419 thanks. you got it.

@Jravvit (Lists and Keys)
@cadenzah (React.Component)
@chayeoi (Lifting State Up)
@yesjin-git (Thinking in React)
@noahluftyang (Tutorial)

Hi. This is friendly ping just to check out your translation progress during the last 3~4 weeks for “Core Pages” section. How is it goining? If you need help, please tell me :slightly_smiling_face:
안녕하세요. "Cord Pages" 페이지 번역을 지원하고 3~4주가 지난 시점에서 각자 맡으신 번역이 어떻게 진행되고 있는지 확인하기 위해 멘션드려요. 어떻게 진행되고 있을까요? 도움이 필요하시면 편하게 말씀해주세요 :)

Hi, permission to translate < State and Lifecycle (@rlagksruf16) #49  >?

@hIkipooh That page has assigned translator. I will check the progress of the assigned translator and let you know if you can translate. If you want to translate another page, that's good too.
@rlagksruf16 Could you tell us about the "State and Lifecycle" translation?

@taehwanno Oh, my bad for not reading thoroughly, I didn't mean to intervene. How about JSX In Depth?

@hIkipooh thanks. you got it.

Hi, @taehwanno I'd like to take Context, please!

@taehwanno can i get Fragments page to translate?

@Jravvit (Lists and Keys)
@cadenzah (React.Component)
@chayeoi (Lifting State Up)
@yesjin-git (Thinking in React)
@noahluftyang (Tutorial)

Hi. This is friendly ping just to check out your translation progress during the last 3~4 weeks for “Core Pages” section. How is it going? If you need help, please tell me 🙂
안녕하세요. "Cord Pages" 페이지 번역을 지원하고 3~4주가 지난 시점에서 각자 맡으신 번역이 어떻게 진행되고 있는지 확인하기 위해 멘션드려요. 어떻게 진행되고 있을까요? 도움이 필요하시면 편하게 말씀해주세요 :)

이번 주 내로 완성하려고 합니다!

Hi, @taehwanno. I want to translate React Without JSX.

@shiincs thanks. you got it.

@Jravvit (Lists and Keys)
@cadenzah (React.Component)
@chayeoi (Lifting State Up)
@yesjin-git (Thinking in React)
@noahluftyang (Tutorial)

Hi. This is friendly ping just to check out your translation progress during the last 3~4 weeks for “Core Pages” section. How is it going? If you need help, please tell me 🙂
안녕하세요. "Cord Pages" 페이지 번역을 지원하고 3~4주가 지난 시점에서 각자 맡으신 번역이 어떻게 진행되고 있는지 확인하기 위해 멘션드려요. 어떻게 진행되고 있을까요? 도움이 필요하시면 편하게 말씀해주세요 :)

안녕하세요! 다음주까지 완성하는게 목표입니다!

@Jravvit (Lists and Keys)
@cadenzah (React.Component)
@chayeoi (Lifting State Up)
@yesjin-git (Thinking in React)
@noahluftyang (Tutorial)

Hi. This is friendly ping just to check out your translation progress during the last 3~4 weeks for “Core Pages” section. How is it going? If you need help, please tell me 🙂
안녕하세요. "Cord Pages" 페이지 번역을 지원하고 3~4주가 지난 시점에서 각자 맡으신 번역이 어떻게 진행되고 있는지 확인하기 위해 멘션드려요. 어떻게 진행되고 있을까요? 도움이 필요하시면 편하게 말씀해주세요 :)

Very sorry for the late reply. I'll complete the translation until following week.

hi. i would like to take 'Typechecking With PropTypes'

@sukjae thanks. you got it.

I would like to take

FAQ > APIs and AJAX

@sukjae thanks. you got it.

I would like to take

FAQ > Babel, JSX, and Build Steps

@sukjae thanks. you got it. 🚀🚀🚀

Hi, this is Angela Min.
I'm gonna take "HOOKS > Hooks API Reference" part in a sequence : )

I would like to take

FAQ > Styling and CSS

@hapumee @sukjae thanks. you all got it.

FYI, "Hooks > Hooks API Reference" is in progress about 1/3.

Hi :) Could I take ADVANCED GUIDES > Static Type Checking part?

@jiwonkirn thanks. you got it.

I finished the draft and did pull request. ("Hooks > Hooks API Reference")
And I'm gonna take "Advanced Guides > Portals" part.

@hapumee thanks. you got it :)

Hello, could I translate FAQ > Component State part?

@ejolie thanks. you got it.

Hello!
I would like to take  FAQ > Passing Functions to Components

Hello!
could i take  Passing Functions to Components part?

Hello, could I translate Virtual DOM and Internals part?

@sdu6342 @dl0312 thanks. you all got it.
@Hatvan That page is already assigned. could you please translate another page?

Hi~! Could i take Error Boundaries part?

@taewo thanks. you got it.

Hello, I'd like to contribute to Hooks FAQ

Hello, can i take Integrating with Other Libraries page?

@seanjun21 @yoeubi thanks. you all got it.

I finished the draft and did pull request. ("Advanced Guide > Portals")
And I'm gonna take "FAQ > Versioning Policy" part.

@hapumee thanks. you got it. 🚀 🚀

Really really sorry for the late reply about the translation. I had an personal issue going on these days and about the translation, I have a little question about it.
I did the translation already but it is my first time to do the translation project so I am stuck with pull request part. When I do the translation do I have to erase all the English part and the code part or do I just leave the English part together? Thank you.

@rlagksruf16 It's okay. 😃 Erase all English except codes.
I recommend read below guidelines and the official Korean translation site.

공통 스타일 가이드
모범사례
용어 확인

I finished the draft and did pull request. ("FAQ > Versioning Policy")

Hello, could I take Contributing - 'How to Contribute' part.
If it's difficult because of low priority, can I take Markdown page?

@ReturnReason MarkdownPage, please :)
When I just look over MarkdownPage, I think we don't need any translation. but can you check this?

If "CONTRIBUTING > Design Principles" has not been assigned, I'll take it.

@hapumee thanks. you got it.

@taehwanno 다음 주 초까지 번역 완료 예정입니다~

@taehwanno I'm waiting for my PR to be reviewed, but in the meantime can I take components > ErrorDecoder ?

@hikipooh yes. you got it. thanks.

FYI.
I thought I could be able to set to translation work for "CONTRIBUTING > Design Principles" from the last week.
However, somethings came up for my development (in the company) so I haven't been started yet.
I'm gonna initiate as soon as possible.

@hapumee Thank you for letting us know. I also have a very busy day lately :cry: 🚀

Hello!
could i take File Structure part?

I'm sorry I can not tell you for a long time.
I think I am too inexperienced to translate.
FAQ> Assign File Structure to others
Sorry.

@Hatvan It's okay. you don't need to sorry for us :)
Please feel free to ask us if you would like to participate in the translation again. thanks.

I would like translate FAQ : File Structure!!

@highspirit7 thanks. you got it.

I'm so sorry, but there might be a typo on the page below.
https://ko.reactjs.org/docs/react-api.html
I think that 'ㄴㄴ' sholud be removed.

개요 > 컴포넌트 > React 컴포넌트를 사용하면 UI를 독립적이고 재사용할 수 있는 부분으로 나누고 각 부분을 분리하여 "생각할 수" 있습니다.

Hello. I want to contribute something like translating in Korean
Could you give me some pages to translate in Korean?

Hello. I want to contribute something like translating in Korean.
Could you give me some pages to translate in Korean?
Category 'How to Contribute' looks good but anything be okay.

@hapumee Thanks for reporting this. could you create an issue for this?
@Kim-Ki-Soo thanks. you got it (How to Contribute)

@taehwanno Yes, sure. I didn't know the process well. I'm gonna make an issue. : )

I want to attribute this project. Can I translate Components > LayoutFooter?

@hoony2520 thanks. you got it.

Sorry for checking late.
I'll contribute soon.
Thank you.
-----Original Message-----
From: "Taehwan<EMAIL_ADDRESS>To<EMAIL_ADDRESS>Cc<EMAIL_ADDRESS><EMAIL_ADDRESS>Sent: 2019-05-09 (목) 22:18:18 (GMT+09:00)
Subject: Re: [reactjs/ko.reactjs.org] Korean Translation Progress (#1)
@hapumee Thanks for reporting this. could you create an issue for this?
@Kim-Ki-Soo thanks. you got it (How to Contribute)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

Can I translate Codebase-Overview?

@Kimguyeop thanks. you got it.

Excuse me, I want to translate something.
I want Implementation Notes part but anything can okay for translating.

@baekjuwon thanks. you got it.

Excuse me, I'm translating 'Implementation Notes' part.
Should I leave the code as it was?

@baekjuwon Yes. please check out below the guidelines.

공통 스타일 가이드
모범사례
용어

I did pull request for "CONTRIBUTING > Design Principles". (#124)

The translation list is updated. if you want to translate any section, please comment to this :)

Need to additional translation

Test Renderer (API Reference in Core Pages)
docs/nav.yml (Navigation in Core Pages)

Newly added pages

Testing Overview (Testing)
Testing Recipes (Testing)
Testing Environments (Testing)

Using the Effect Hook (@yumidev)
Building Your Own Hooks (@taggon)
Hooks FAQ (@seanjun21)
Error Boundaries (@taewo)
Forwarding Refs (@ENvironmentSet)
Higher-Order Components (@gnujoow)
Styling and CSS (@sukjae)
ErrorDecoder (@hIkipooh)
MarkdownPage (@ReturnReason)

Hi. This is friendly ping just to check out your translation progress. How is it going? If you need help, please tell me 🙂
안녕하세요. 페이지 번역을 지원하고 할당된 뒤 한 달 이상 지난 시점에서 각자 맡으신 번역이 어떻게 진행되고 있는지 확인하기 위해 멘션드려요. 어떻게 진행되고 있을까요? 도움이 필요하시면 편하게 말씀해주세요 :)

@taehwanno 현재 Hooks FAQ를 맡아서 하고 있습니다. 일단 Table of Contents를 끝내고, 하루에 한두 문단씩 일 안하는 짜투리 시간에 하고 있는데 솔직히 FAQ라 그런지 좀 양이 많네요. 번역을 해야하는 단어랑 그냥 써야하는 단어랑 구분하는게 좀 오래 걸리는것 같습니다. 그래도 초반에 비해서는 중복 단어가 많아져서 점점 속도가 올라가고 있습니다. 최대한 빨리 할 수 있도록 할게요.

@seanjun21 꾸준히 해주셔서 감사합니다. 급하게 해주시진 않으셔도 되요! ㅎㅎ

@taehwanno 한동안 정신이 없어서 JSX in Depth PR 리뷰 사항도 확인 못햇네요 ㅠ 우선 PR 리뷰로 받은 수정 사항 부터 이번주 내로 마무리 하고 ErrorDecoder 작업을 진행하고 싶은데 괜찮을까요?

@hIkipooh 괜찮습니다 :)

Hi @taehwanno  :smile:  I would like to translate Testing Overview page. Please let me know if it is possible

@koDaegon Sorry for late response :cry: you got it. thanks

@taehwanno 안녕하세요 ! Components의 CodeExample 페이지 번역하고싶은데 가능할까요???

@Yohan-Kim2 가능하며 배정해놨습니다. 감사합니다 :)

@taehwanno 그동안 바빠서 참여를 못하고 있엇네요 혹시 할당되지 않은 문서나 할당되었는데 오랬동안 PR이 올라오지 않은 문서가 정리된것이 있을까요?

@gnujoow 넵 알겠습니다 ㅎㅎ

@taehwanno 번역 작업이 이번이 처음이라서 그러는데, CodeExample에 파일의 기능을 한글로 설명만 하면 되는 건가요? 추가로 달아야할 주석은 없나요?

안녕하세요 Testing Recipes 페이지 번역 하려 하는데 배정 받을 수 있을까요?

@cdsleaf 배정해드렸습니다. :)

안녕하세요! @taehwanno
testing-environments.md 페이지 번역하고 싶은데 가능할까요??

안녕하세요~ @taehwanno
CodeEditor.js 페이지 번역하려고 하는데 배정 받을 수 있나요?

안녕하세요~ @taehwanno
test-renderer.md, CodeEditor.js 페이지 번역하려고 하는데 배정 받을 수 있나요?

안녕하세요. @taehwanno
nav.yml 페이지 번역하려고 하는데 배정 받을 수 있나요?

제 과제도 배정해드릴게요
-----Original Message-----
From<EMAIL_ADDRESS>To<EMAIL_ADDRESS>Cc<EMAIL_ADDRESS><EMAIL_ADDRESS>Sent: 2019-10-29 (화) 00:05:04 (GMT+09:00)
Subject: Re: [reactjs/ko.reactjs.org] Korean Translation Progress (#1)
안녕하세요. @taehwanno
nav.yml 페이지 번역하려고 하는데 배정 받을 수 있나요?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.

@Yohan-Kim2 말씀이라도 감사드립니다. JavaScript를 잘 모르신다면 번역에 참여하기에는 제한될 거 같아요 ㅎㅎ
@BeomYoung 배정해드렸습니다.
@toy9910 Test Renderer 부탁드릴게요. 한 명당 하나의 작업만 배정하고 있기에 배정받으신 섹션의 번역을 완료하시고 PR 제출 후에 다른 섹션을 요청해주세요.

The docs about concurrent mode (experimental) are added. I updated pull request description. If you want to translate any section, please comment to this :)

Concurrent Mode (Experimental)

Introducing Concurrent Mode
Suspense for Data Fetching
Concurrent UI Patterns
Adopting Concurrent Mode
Concurrent Mode API Reference

I'd like to be assigned to Introducing Concurrent Mode

I'd like to volunteer for translating Adopting Concurrent Mode.

@Yohan-Kim2 @junsikshim Thanks. you all got it.

@taehwanno I'd like to contribute this project by translating Concurrent Mode API Reference. Could I?

@taehwanno // could I take Concurrent UI Patterns (Experimental)?

@taehwanno I translated to korean for Introducing Concurrent Mode, so how can  I commit this repository?

@Yohan-Kim2 you can read the contribution guideline here🙏
https://github.com/reactjs/ko.reactjs.org/blob/master/README.md

@DDOLDDOL @Beingbook Thanks. you all got it.
@Yohan-Kim2 Please see the README as @purelledhand said.
@purelledhand Thanks :)

components에 code editor 번역하고싶습니다

@qudwn1114 배정해드렸습니다.

'Suspense for Data Fetching' 번역하고 싶습니다.

@junsikshim 배정해드렸습니다 :)

요즘 좀 바빠져서 'Suspense for Data Fetching' 번역을 못하고 있습니다.
1~2개월 정도 이후에나 가능할 것 같은데
먼저 가능하신 분에게 배정하는 게 어떨까 싶습니다~

@junsikshim 제가 해보고싶습니다~

@junsikshim 미리 말씀해주셔서 감사합니다. @cadenzah 님에게 배정해드릴게요!
@cadenzah 배정해드렸습니다. 감사합니다 :)

안녕하세요! 각 번역 페이지를 배정받으신 뒤 꽤 기간이 지난 후에 아직 풀 리퀘스트가 제출되지 않은 분들께 멘션 드려요 ㅎㅎ 아직 번역이 완료되지 않았다면 완료 후 제출해주시면 감사하겠습니다. 만약 개인 일정상 바쁘셔서 부담스러우시다면 지금까지 했던 번역이라도 올려주시면 계속 이어받아서 진행하도록 할게요. 번역하지 않으셨더라도 다른 분에게 넘기셔도 괜찮습니다! 진행 상황을 코멘트로 공유 부탁드릴게요.

Building Your Own Hooks (@taggon)
Hooks FAQ (@seanjun21)
Error Boundaries (@taewo)
Forwarding Refs (@ENvironmentSet)
Higher-Order Components (@gnujoow) #187 제출 후 추가 번역이 없으셔서 멘션드려요!
Styling and CSS (@sukjae)
CodeEditor (@qudwn1114)
CodeExample (@Yohan-Kim2)
ErrorDecoder (@hIkipooh)
MarkdownPage (@ReturnReason)
Suspense for Data Fetching (@cadenzah)
Concurrent UI Patterns (@Beingbook)

꽤 많은 코멘트가 해당 이슈에 달리다보니 알림을 Unsubscribe 하신 분들이 있을 것 같아서 해당 코멘트를 게시한 후 일주일 뒤(4/14 화요일)까지 응답이 없으시다면 개인 이메일이나 소셜 미디어를 통해 연락을 드릴 수도 있습니다. 개인적으로 연락을 드리고 나서 그 이후 일주일(4/21 화요일)이 지나면 배정해드렸던 페이지를 다른 분이 작업하실 수 있도록 할게요. 연락 수단을 찾지 못해서 제가 연락을 못드리는 상황도 마찬가지로 4/21 화요일이 지나면 배정을 다른 분께 넘기도록 할게요. 공유드립니다 :)

@taehwanno 다음 주 중으로 PR 올리겠습니다~!

@taehwanno 다음주 중으로 PR 게시하겠습니다!

@taehwanno 21일 전까지 PR 게시하겠습니다!

새롭게 추가됐지만, 이슈에 명시되어있지 않던 2가지 페이지를 배정받으셔서 작업하실 수 있도록 이슈를 업데이트했습니다. 아래 2가지 글에 대해 번역에 관심 있으시다면 코멘트 부탁드릴게요!

Release Channel (Installation in Next Steps)
Profiler (Advanced Guides in Next Steps)

@taehwanno  님,  제가 Profiler를 진행하겠습니다. : )

까맣게 잊고 있었네요. 작업을 다시 좀 진행해보고 다른 분께 토스드릴지 의견드리도록 하겠습니다.

@taehwanno 엇, 죄송합니다. 이제 확인했네요. 학교 일들이 쌓이면서 번역이 어렵게 되었습니다, 여유가 날 줄 알고 계속 붙들고 있긴 했는데 앞으로 더 바빠질 거 같아 다른 분께 넘겨드리려고 합니다.
늦어서 죄송합니다 (_ _)

@sukjae 19일 일요일까지 pr 남기겠습니다!
다른분들께 정말 죄송하네요 ㅠㅠ

@taehwanno Profiler 파트 맡을 수 있을까요?

@hIkipooh 배정해드렸습니다!

Error Boundaries 제가 맡을 수 있을까요?

@anthonyminyungi 배정해드렸습니다!

@taehwanno 매일 진행중인데, FAQ라 그런지 생각보다 양이 많네요. 일주일만 더 주시면 마무리 할 수 있을것 같습니다. 27일까지 PR 준비하도록 하겠습니다!

@seanjun21 너무 무리하셔서 작업하지 않으셔도 괜찮습니다 ㅎㅎ 개인 일정이랑 잘 조절하셔서 꾸준히 조금씩 작업해주시는 걸로  충분합니다

@taehwanno

Higher-Order Components (@gnujoow) #187 제출 후 추가 번역이 없으셔서 멘션드려요!

지금 확인했네요 다음주중으로 완료된 번역을 업데이트 하겠습니다.

안녕하세요! 번역에 참여하고 싶은데 슬랙 채널 링크가 무효네요. Can someone repost the Slack link? It seems to have expired.

@francisdzheng 슬랙 채널 링크 최신화해놨습니다! 아직 배정되지 않은 페이지 하나 고르셔서 이슈 코멘트로 요청하시면 배정해드릴게요.

안녕하세요. Hooks의 Building Your Own Hooks를 번역하고 싶습니다.

@yumidev 배정해드렸습니다. 감사합니다.

@taehwanno 안녕하세요! 번역을 하고 싶은데, 혹시 배정 안되었거나 작업 가능한 페이지가 있을까요?

@dexterastin 배정되지 않은 아래 5가지가 남아있습니다 ㅎㅎ

Installation의 Release Channels
Advanced Guides의 Forwarding Refs
Components의 CodeEditor, CodeExample, MarkdownPage

@taehwanno 님,  외람되온대
Forwarding Refs 저 주시면 제가 할께요. : )

@hapumee 배정해드렸습니다 ㅎㅎ

@taehwanno MarkdownPage 어사인해주시면 작업해보고, PR 날리겠습니다.

@dexterastin 배정해드렸습니다. 감사합니다.

@hapumee 배정해드렸습니다 ㅎㅎ

@taehwanno 님, It was not easy schedule to finish the translation because of my project. (#260)
I did it finally. : )

@seanjun21 Hooks FAQ 번역 진행상황 공유받을 수 있을까요?
@dexterastin MarkdownPage는 지금 살펴보니 번역이 필요한 부분이 없어보이네요. 혹시 다른 부분 맡고 싶으시다면 요청 부탁드릴게요!

일이 많다보니 자꾸 미뤄지네요 죄송합니다. 현재 60-70% 정도 진행했습니다.
이번주/다음주 휴가가 좀 있으니, 틈 나는대로 마무리하겠습니다.

@taehwanno 주말에 많이 진행해서 이제 마무리 작업만 남았습니다 (맞춤법 수정 및 코멘트 번역), 몇일안에 PR 제출하겠습니다. 감사합니다.

마무리 작업이 생각보다 오래 걸려서 늦었네요, 죄송합니다. PR 제출했습니다 #265

@taehwanno
안녕하세요 저도 번역작업에 기여하고싶습니다!
Installation의 Release Channels(배포 채널) 배정해주실수 있나요?
배정해주시면 작업시작하도록 하겠습니다 :-)
감사합니다 ^0^

@thinkanddoit you got it. thanks.

@thinkanddoit you got it. thanks.

I requested a pull request. Please confirm :-) #269

안녕하세요, React 한국어 번역에 컨트리뷰트하고 싶은데 혹시 맡을 만한 부분이 있을까요? 감사합니다

안녕하세요, React 한국어 번역에 컨트리뷰트하고 싶은데 혹시 맡을 만한 부분이 있을까요? 감사합니다

@taehwanno @nh0627
higher-order-components가 1년이 넘도록 팬딩되고 있는데, 새로 진행하는게 좋을 것 같습니다.

@taehwanno @nh0627
higher-order-components가 1년이 넘도록 팬딩되고 있는데, 새로 진행하는게 좋을 것 같습니다.


the default group loses its permissions

Hello,
Sometimes, for reasons that I never really understood the group by default loses all permissions that I added the last 2 years (I have not seen if other groups were losing permissions).
I added or removed suffix but no worries they do not disappear.
Example: I have two UHC lobby and the number 1 were worries that permissions and looking in the logs I saw this for the number 1: http://pastebin.com/x4HpZeXa (Deploying default database scheme, scheme Database Deploying full.)
It was just enough to make /Pex reload and worries this rule ..
PS : The problem is not regular, it will appear a time occasionally. I use version 1.23.4

Having the same issue, did you find any fix for it?

hello, no I just delete sql backup or other sql files. I noticed that when the problem appeared the plugin load a schematic by default and I do not know where

Some help ?
@Tom7653 if you want, after restart the server just force command /pex reload

When a server is restarted, there is no need to /pex reload.  The permissions are already freshly loaded by the restart.

Stormbow
No, sometimes the default group loses its permissions and need to reload

A restart is where all permissions and all plugin config files are unloaded from memory and reloaded fresh.  There is no need to reload them after they have been reloaded.


Login Page for users and admins (Frontend)

I can start working on the topic mentioned above.

OK.
On Tue, 4 Oct 2022, 18:56 sarwin_, @.***> wrote:

I can start working on the topic mentioned above.
—
Reply to this email directly, view it on GitHub
https://github.com/Amianie/E-Library-UOM-IIT-Collab-on-Hacktoberfest/issues/1,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AT76P4ADZGJX6AYUWWI2RSTWBRHUHANCNFSM6AAAAAAQ4W42FE
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***
com>


18.12 RC1 Merge #3

Merging changes from master in to 18.12 branch for (hopefully) the last time.

Wow. Look at all that green! Excellent work to everyone who contributed to this.

it requires update branch, not able to merge in..

Anyway, i'll update version and attach tag on master, since we have to do it anyway.

And we probably don't need a separate branch for tracking release version, since github will take snapshots when attaching tags.

@yunstanford Except 18.12 is LTS, meaning we will still want to release bug fixes on this while master diverges with new features, etc.

FYI - Travis is building because of this:
The command "eval git clone --depth=50 --branch=v18.12.0 https://github.com/huge-success/sanic.git huge-success/sanic " failed. Retrying, 2 of 3.

I am closing this branch in favor of the 18.12LTS branch.

I think this is a better practice. No need to do these branches before master is ready and released.


Typos/Wrong values in DDTTYLogger

Hi!
I have just noticed some slight differences when comparing the output of NSLog() and DDTTYLogger:
2014-12-28 23:56:02.013 TestApp[6247:281476] NSLog
2014-12-28 23:56:02:013 TestApp[6247:30b] DDLogVerbose
First thing, I think there is a minor typo in the date string: The milliseconds should be separated with a 'dot' character, and not a ':'. In 'DDTTYLogger.m', line 1271, I would replace the snprintf() format string with:
"%04ld-%02ld-%02ld %02ld:%02ld:%02ld.%03d", // yyyy-MM-dd HH:mm:ss.SSS
Also, more importantly, it seems that the TID of the standard NSLog() call has been changed (at least on OS X 10.10, not tested with iOS nor older version OS X)... and honestly spoken, for this one, I don't have the replacement yet...

Thank you for noticing. Could you create a pull request for the first issue?
We can still leave this open for the second one.

The thread id was fixed already by #514


Support for Visual Studio 2019

Make ASP.NET Core Blazor Language Services available for VS 2019.

Awaiting a new release for VS2019

Small update, I was able to change Microsoft.VisualStudio.BlazorExtension to support VS 2019. It builds and installs fine, but, there are few problems:

Future versions of VS will not support AutoLoad enabled solutions. Extension need to be migrated to use AsyncPackage. But this can be done later as VS 2019 only warns about this. (At least at this point it does.)
Although my Blazor project builds and runs  just fine with the extension in VS 2019, it seems that TagHelper syntax highlighting does not work.

Same for the base class methods:

It feels like it does not know it inherits BlazorComponent.
Just to be sure I checked MVC project, and TagHelpers work there with BlazorExtension the extension installed.

I would appreciate any ideas on where in the code I can look to debug the second issue.
VIsual Studio version: 16 preview 1
Source code taken from master branch at commit f52882


The operation is insecure.

Describe the bug
When Bolt is writting to file, a series of pop-up errors come up stating "The operation is insecure."
Only happens on the first prompt, but the following ones get bugged
Link to the Bolt URL that caused the error
http://localhost:5173/chat/astro-blog-3
Steps to reproduce

Choose a source (I chose Mistral)
Choose a model (I chose Mistral 7B)
Make a prompt (I prompted Build a simple blog using Astro)
LLM will start faltering on screen and the series of pop-ups will be triggered

Expected behavior
Bolt to start programing and adding code to files, running commands on terminal and showcasing a preview of project
Screen Recording / Screenshot
https://github.com/user-attachments/assets/3c2334b3-80a0-4e8e-a613-2b45a8fac82d
Platform

Windows (WSL)
Firefox
Version: 132.0.2

Additional context
No response

this is fixed now

I still get this error "The operation is insecure" in the current build of bolt.diy using the example todos with Tailwind prompt.

hello
i'm having the same problem with v0.0.3
Screenshot:

Scenario:
clone the project.

swithc to v0.0.3 tag
change the api key to deepseek v3.
Run my prompt.


Provide an accurate way of reporting the exact first frame rendered time

Flutter users should want to generally track their app health including startup latency. To do so, we should have an exact way of reporting the timing of the first frame rendered, which should be roughly when this line runs on the raster thread https://github.com/flutter/engine/blob/99b752ed2c8f87bb1d13d89a7cee3fb9caa3b1f2/shell/common/rasterizer.cc#L532. However, this timing isn't directly accessible by our users.
Instead, users have access to https://github.com/flutter/engine/blob/99b752ed2c8f87bb1d13d89a7cee3fb9caa3b1f2/shell/platform/android/io/flutter/embedding/android/FlutterView.java#L364 and https://github.com/flutter/engine/blob/99b752ed2c8f87bb1d13d89a7cee3fb9caa3b1f2/shell/platform/darwin/ios/framework/Source/FlutterViewController.mm#L504 (ish, I guess we never built the iOS equivalent).
But that includes an additional raster->platform thread indirection. The platform thread being busy to queue would be unrelated to whether we rendered the first frame. We can either have a separate API running on the raster thread to have people run a thread safe closure or we can report back to the platform thread with a timestamp that's already recorded at the source.
cc @zanderso, @jiahaog

@iskakaushik for thoughts on this.

@xster, we have a way to do this via OnFrameRasterizer which transitively sends an event via the service protocols. https://api.flutter.dev/flutter/dart-ui/FrameTiming-class.html is how one would consume the said timing, we immediately send it when first frame is rasterized, see: https://github.com/flutter/engine/blob/master/shell/common/shell.cc#L1403. Is this not sufficient for your use case?

Actually, that's my question 2 :)
There are 2 ways in the rasterizer of getting a frame completed callback, https://github.com/flutter/engine/blob/master/shell/common/rasterizer.cc#L532 and https://github.com/flutter/engine/blob/master/shell/common/rasterizer.cc#L400. Is one more correct than the other? Or which one corresponds more closely to the user visually seeing the frame on the screen? Can we consolidate them?

There can be a difference between the two methods. FireNextFrameCallback is closer to when we expect the frame to be shown to the users. The differences between that and OnFrameRasterized are:

We perform deferred clean-up that is queued up for Skia.
We update / dump the contents of persistent cache as needed.

Given this, I'm leaning towards recording the raster-end time closer to when we submit the frame. See: https://github.com/flutter/engine/pull/26970

@jiahaog one interesting discussion to take from this is what we can choose to either do the reporting of the frame complete on the platform side or in dart. The latter could be easier (since iOS doesn't seem to have a public API for when the first frame is rendered yet), but is maybe harder to bake in (since it'll have to go into the user's application code somehow).
Either way, the PRIMES' API will likely need to have a way to inject a timestamp from the raster thread whether directly in Java/Objc or through the plugin.

Agreed, the latter is probably easier as a library, since the standard Android embedding usually doesn't take a dependency on the PRIMES API. Will follow up with wiring this through.

The epoch timings returned by FrameTiming.timestampInMicroseconds seems to be backed by Dart_TimelineGetMicros. Is there a way to convert these timings back to wall time, besides comparing Timeline.now to DateTime.now() and offsetting the values accordingly?

@jiahaog see https://github.com/flutter/flutter/issues/80735 for relation between FlutterClock and wall time. There unfortunately isn't an easy way to map these things

Ah thanks, I didn't realize that there are three clocks in play - (wall clock, Dart timeline clock Dart_TimelineGetMicros, and the Flutter clock std::chrono::steady_clock()). I don't think the frameNumber will help us much beyond asserting that the frame timing we're instrumenting is the first frame, and we cannot access the timeline events in release mode.
To provide more context, the API we have today for internal instrumentation looks something like:
void recordDuration(String eventName, int startMs, int endMs);

The following options for how we want to accurately instrument the first frame may be feasible (please feel free to suggest alternatives):
A. Surface the Wall time (Ideal)
Surface the wall time of the first frame or figure out some way to baseline the frame timestamp to the wall clock. Not sure how feasible it is to do this though. If it's not possible, we may be able to compromise instead allow the instrumented first frame duration to start from another baseline:
B. Baseline the first frame metric from framework / engine init
Instead, find some timestamp on the same clock as FrameTiming of when the framework/engine initializes as a baseline, then we can call:
recordDuration(
  'firstFrameFromFrameworkInit',
  // Assuming that both readings have the same clock
  getFrameworkInitTimestamp(),
  firstFrameTiming.timestampInMicroseconds(FramePhase.rasterFinish),
);

This acts as another metric for users if they want the most accurate timing for the first frame.
There are some things that I'm not sure yet and will follow back up for this option:

Whether calling recordDuration with non-wall clock epoch is supported (appears to be, but there may be other nuances under the hood)
Whether there are other instrumenting APIs that require wall timestamps (such as for tracing - cc @zhenqiu1101)

@iskakaushik, it's not clear to me why getting a standard wall timestamp is difficult. Can you elaborate a bit?

To be clear, I wasn't suggesting that getting a standard wall timestamp is difficult. If we were to have a utility outside of the engine that tries to map the timeline events to a wall clock it would not be easy. We use steady_clock (as opposed to system_clock) globally for all events, which I think is the right thing to do.
We could potentially modify the FrameTiming API to also expose the wall time for the events. I'm wondering if exposing a wall-clock equivalent for all the metrics we provide in the FrameTiming API is really required.
@jiahaog , when you call recordDuration what do you plan on using as the startMs if we were to expose rasterEndWallClockTime?

when you call recordDuration what do you plan on using as the startMs if we were to expose rasterEndWallClockTime?

We're planning to use the internal utilities that call /proc/self/stat under the hood, which should give us the process creation time.

@jiahaog , https://github.com/flutter/engine/pull/27074 has landed and FrameTiming now has rasterFinishWallTime, let me know if that is sufficient for your use-case.

Thanks, I'll try it out!

Tried it out and it works great, thanks! Some numbers for difference between the rasterFinishWallTime and when onFlutterUiDisplayed is called for a trivial Flutter app in profile mode on Android would be:

Data
Time / ms

Average
14.2

P95
33.5

P99
44.9

@jiahaog thanks! Looks like it's working well for you. I'm going to close this issue for now.

@iskakaushik I noticed that on iOS (checked on debug / release mode, simulators and physical devices), the first received FrameTiming.frameNumber never starts at 1, even though I set up the timings callback before runApp is called. Is this expected?
void main() async {
  final binding = WidgetsFlutterBinding.ensureInitialized();

  binding.addTimingsCallback((timings) {
    print('timings: $timings');
    // `timings.first.frameNumber` never 1
  });

  runApp(const MyApp());
}


Estimate smeshing rewards endpoint

Closes #96

I think you want to remove the account id from new methods. The estimated rewards returned should be for the min network storage unit size - a network param. e.g. 100GB and the api is designed to be called by users who don't have an on-mesh account yet. e.g. when setting up post we want to display the estimated rewards per user selected post data size. This is the main use case for this feature. The estimate is not account specific and should return the same value for all clients based on the last epoch's total post data size.

@avive this is ready to go, please take another look


MacOS can't running

Have a bug report:
Unable to patch '/Users/xxxxx/WinterspringLauncher/hermes-proxy/CSV/Hotfix/ItemEffect1.csv' (WinterspringLauncher.HermesDataPatches.Hotfix.ItemEffect1.csv)
System.IO.DirectoryNotFoundException: Could not find a part of the path '/Users/xxxxx/WinterspringLauncher/hermes-proxy/CSV/Hotfix/ItemEffect1.csv'.
at Interop.ThrowExceptionForIoErrno(ErrorInfo errorInfo, String path, Boolean isDirError)
at Microsoft.Win32.SafeHandles.SafeFileHandle.Open(String fullPath, FileMode mode, FileAccess access, FileShare share, FileOptions options, Int64 preallocationSize, UnixFileMode openPermissions, Int64& fileLength, UnixFileMode& filePermissions, Func4 createOpenException)    at System.IO.Strategies.OSFileStreamStrategy..ctor(String path, FileMode mode, FileAccess access, FileShare share, FileOptions options, Int64 preallocationSize, Nullable1 unixCreateMode)
at System.IO.StreamReader.ValidateArgsAndOpenPath(String path, Encoding encoding, Int32 bufferSize)
at System.IO.File.ReadAllLines(String path, Encoding encoding)
at WinterspringLauncher.LauncherActions.g__PatchCsvFiles|19_2(List`1 patchResources, String replace, String csvDirPath, <>c__DisplayClass19_0&) in /Users/runner/work/WinterspringLauncher/WinterspringLauncher/WinterspringLauncher/LauncherActions.cs:line 449
at WinterspringLauncher.LauncherActions.PrepareHermesProxyData(String hermesPath) in /Users/runner/work/WinterspringLauncher/WinterspringLauncher/WinterspringLauncher/LauncherActions.cs:line 417
at WinterspringLauncher.Launcher.<>c__DisplayClass1_0.b__5() in /Users/runner/work/WinterspringLauncher/WinterspringLauncher/WinterspringLauncher/Program.cs:line 72
at WinterspringLauncher.Launcher.IgnoreExceptions(String description, Action func) in /Users/runner/work/WinterspringLauncher/WinterspringLauncher/WinterspringLauncher/Program.cs:line 152

I cant test this right now, but apparently this helps
https://github.com/0blu/WinterspringLauncher/issues/40#issuecomment-1775994625
ref: https://github.com/0blu/WinterspringLauncher/issues/41

The software has automatically updated the latest version of HermesProxy<Release v3.10 (2023-10-19)>, but cannot automatically perform hotfixes.
The MacOS system version is 14.0 (23A344).

Hi,I solved the startup problem through the NEW solution. I have encountered the next issue again: How to download and replace WOW clients that support Chinese language


[BUG]: Query not properly deserialized

Steps to reproduce:
const express = require('express')
const app = express()

app.get('*', (req, res) => {
    const result = JSON.stringify(req.query, null, 2);
    console.log(result)
    res.write(result);
    res.end();
})

app.listen(3000)

Just visit the app with following URL: http://localhost:3000?query[$and][0][status][$in][0]=waiting_for_review&query[$and][0][status][$in][1]=in_review&query[$and][1][$or][0][destination][$regex]=.*Aw.*&query[$and][1][$or][0][destination][$options]=i&query[$and][1][$or][1][project.name][$regex]=.*Aw.*&query[$and][1][$or][1][project.name][$options]=i&limit=5&page=1
Output
{
  "query": {
    "$and": [
      {
        "status": {
          "$in": [
            "waiting_for_review",
            "in_review"
          ]
        }
      },
      {
        "$or": [
          {
            "destination": {
              "[$regex]": ".*Aw.*",
              "[$options]": "i"
            }
          },
          {
            "project.name": {
              "[$regex]": ".*Aw.*",
              "[$options]": "i"
            }
          }
        ]
      }
    ]
  },
  "limit": "5",
  "page": "1"
}

Expected Output
{
  "query": {
    "$and": [
      {
        "status": {
          "$in": [
            "waiting_for_review",
            "in_review"
          ]
        }
      },
      {
        "$or": [
          {
            "destination": {
              "$regex": ".*Aw.*",
              "$options": "i"
            }
          },
          {
            "project.name": {
              "$regex": ".*Aw.*",
              "$options": "i"
            }
          }
        ]
      }
    ]
  },
  "limit": "5",
  "page": "1"
}

See the $regex field, which should not be surrounded by brackets.

Node: v10.15.0
Express: v4.16.4

Works with:
const qs = require('qs');

app.set('query parser', function (str) {
    return qs.parse(str, {
        depth: 20,
    });
});

Thanks for the report. This is not a bug, but rather the behavior of the qs module. Your update is how you can change the behavior to work with your needs :+1:

My response is based on your provided solution.

(as in, the depth parameter is limited by the qs module by default for security, and if you need a larger depth you need to specify it, as shown at the bottom of your post).

Thank you! I couldn't get it to work in my nest.js application. So here is how it works:
const a = express();
a.set('query parser', (str) => {
  return qs.parse(str, {
    depth: 20,
  });
});

const app = await NestFactory.create<NestExpressApplication>(AppModule, new ExpressAdapter(a));

The query parser setting seems not to take effect after configuring express routes!


fix: fix ref issue when transforming to Solid.js code

Description
Fix ref issue when mitosis build target is solid
Issue
I used the ref example provided on the official doc.
Playground: Click here
It is correctly transformed on React,  which will present the output codes like these below:
import * as React from "react";
import { forwardRef } from "react";

const MyInput = forwardRef(function MyInput(props, inputRef) {
  return <input ref={inputRef} />;
});

export default MyInput;

But, it will cause issue on Solid, and we could see the issue at console panel.

Reason
The issue is caused by the getRefsString method in Solid.js generator, which can be read here.
const getRefsString = (json: MitosisComponent, options: ToSolidOptions) =>
  Array.from(getRefs(json))
    .map((ref) => {
      const typeParameter = (options.typescript && json['refs'][ref]?.typeParameter) || '';
      return `let ${ref}${typeParameter ? ': ' + typeParameter : ''};`;
    })
    .join('\n');

And with the insertion  ${getRefsString(json, options)} in solid code, eventaully, the generated solid.js code will become something like this:
function MyComponent(props:any) {
  let props.inputRef;
  return (
    <input  ref={props.inputRef!}  />
    )
}
export default MyComponent;

And when these code met with prettier format function in Solid.js generator, it will throw out the error, which leads to the break of Solid.js code  bundle.
We could easily reproduce it in a online prettier editor.

Solution
Remove the getRefsString method calling.
Then the Solid.js generator will generae Solid.js code like these below, which works as expected and will not throw out any error.
function MyComponent(props:any) {
  return (
    <input ref={props.inputRef!}  />
    )
}

export default MyComponent;

Hi, @samijaber! Can you help me with the pr test failed issue?
I've been tested on my local macOS and update snapshot, and it all worked well. But the test just failed on github action, any particular reason why? Thanks.
Same test failed issue happens on my other PR as well.

Hi, @samijaber, do you have a moment to see the reason of why vitest snapshot not correctly generated? That would be great help for my MR, thanks.

Hi @rqzheng2015 , sorry for the delay. There's an issue with our test suite causing tests to not work properly.
It is causing all PRs to break unless additional instructions are followed.
I will fix this issue first and then let you know to rerun your tests locally to get them fixed

Hi @samijaber, I have modified my PR to fix the ref issue changes and vitest snapshot issues, please check when you are free, thanks.


license unclear

Please add the license to package.json as documented in https://docs.npmjs.com/files/package.json#license.
Please add the License to the repo as documented in https://help.github.com/articles/adding-a-license-to-a-repository. This is kind of "GitHub standard" and includes the license in this repo's metadata, too.

Added to latest version.

Thanks. Now the license is clear. You may consider to redo the steps @ GitHub according to their documentation which comes down to do the following via Browser in GitHub

delete License.txt
click on "add new file"
naming it LICENSE
choose the MIT
add your name and Copyright year
review and submit

This will mostly make your license-statement "more standard" and both external tools and the GitHub API have it easier to tell what your license actually is.
If you don't want to do this feel free to just close the issue instead.

Oh cool - I wasn't aware that you could do it via the website. Thanks - will update later.


job id displayed as document id

Bug reports
Expected behaviour
Webhook returns the same document id as response from POST request.
Actual behaviour
Webhook returns document id after creating invoice, which is in fact job id. It is not coherent with document id received as response to post request to the node for creating invoice.
Steps to reproduce the behaviour
Create new invoice with post request and check the webhook.

Duplicate of #1057


Automated Package Upgrade

:tada: This PR is included in version 25.3.55 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


fixed xml

I decided files.xml would be a better name. And the xml contained a syntax typo. It should all work now, will make your repo a submodule in UCP3 when you merge this.
Also changed options.yml to fit the current spec.

Ok. 👍
Anything else you want to change?
If not, I would merge this.

nope this was it for now.
Likely options.yml will only be for defining options. Where these go in a UI (category) will be in a ui.yml?

Ok, merged.
If what I read is true, the submodules need to be updated manually, but to make sure to not break something, I will use a "dev" branch for in-progress changes in the future.
The UI stuff kinda depends on the design in general. Some might want to have nested or conditional options. These could (or should) be validated during the processing in the init. At best, an init.lua should be able to "handle" (turn default or off, warning, or error, maybe even explicitly crash) being given non-sense options.
An UI however should also allow to gate stuff like this, etc. It really depends on the API and what the UI.yml should tell the UI, considering the options are (as far as I understood) not necessarily on the modloader pages people will use for their overviews.
So, big question mark. I think the core questions are "What should the options.yml do?" and "What should a potential UI.yml do?"
Whatever it is, such discussion should not be under some unrelated pull request. 😄