Quizz with Runnable code

My goal is to make a quizz where user needs to write code. The "Check" is supposed to validate the code (by running a piece) and become passed/failed based on validation result.
So I have everything in Lia - I can have code to run, I can have Generic quizzes. I'd love to have some tweaks if possible:

If possible combine "Execute" button with "Check". I.e. pressing "Execute" also triggers "Check" if execution passed.
Or vise versa - pressing "Check" runs execution and becomes checked if passed.
Remember user's code (as it currently stores user input's)
Have more control over "Execute" button if possible (it is now very small and not everyone finds it). Having "Execute" instead of icon would be awesome option in my case.

I managed to implement #2 by adding common  for quizz & code and then looking for a button control. If there any hints on how to do #3 or #4 that would be superawesome:) If not, LiaScript is still superawesome anyway:)

I made up a little example, that you can modify so that it fits your needs, this adds a very simple test, where the last statement of the executed code is checked within a quiz. The first quiz depicts, how a script and a generic-quiz can be stitched together, by using a bit CSS-magic, the other part is a simple macro that could be reused to simplify the coding:
<!--

@@ this is a custom styling, that will hide the check-button
@@ in all quizzes with class quiz-hide

@style
.quiz-hide > div:nth-of-type(2) > button:first-child {
  display: none;
}
@end

@@ @codingQuiz will call a helper-macro and use @uid as a first
@@ parameter, this will generate a unique id, every time it is used
@@ the second-param is the actual input-parameter, the backticks
@@ make allow to input commas as well ...

@codingQuiz: @codingQuiz_(@uid,`@0`)

@@ This helper uses the uid to store the result in a global variable,
@@ which is used in the generic quiz. If the code is evaluated, the
@@ the click-event is released for this specific button, such that
@@ it looks like the quiz is checked ...

@codingQuiz_
<script>
if(!window.result) {
    window.result = {}
}
try {
    window.result["@0"]=eval(`@input`)
    console.log(window.result["@0"])
    let btn = document.querySelector('#quiz-@0 > div:nth-child(2) > button:first-child');
    btn.click()
} catch(e) {
    console.error(e.message)
}
"LIA: stop"
</script>

<!-- class="quiz-hide" id="quiz-@0"-->
[[!]]
<script>
window.result["@0"]=="@1"
</script>

@end

-->

# Code-Quiz

``` javascript
console.log("Hallo Welt")
22
```
<script>
try {
    window.quiz=eval(`@input`)
    console.log(window.quiz)
    let btn = document.querySelector('#hidden-quiz > div:nth-child(2) > button:first-child');
    btn.click()
} catch(e) {
    console.error(e.message)
}
"LIA: stop"
</script>

<!-- class="quiz-hide" id="hidden-quiz" -->
[[!]]
[[?]] Test Hint
<script>
window.quiz==33
</script>

## Macro

``` javascript
console.log("Hallo Welt")
22
```
@codingQuiz(`11`)

``` javascript
console.log("Hallo Welt")
22
```
@codingQuiz(`22`)

``` javascript
console.log("Hallo Welt")
22
```
@codingQuiz(`33`)

you can modify this example here
If you plan to use SCORM, the quiz result should be stored, but not the code-snippets. Unfortunately SCORM allows only to store 254bytes, which are not enough for us to store different version of the editors, thus previous edits will be lost if the course is reloaded... Only the quiz is stored persistently ...
I hope this helps ...

Andre, Thank you a million!
That is an awesome and detailed example.
From script it looks like what I need. And your explanations are very clear. I have just one problem, for some reason I cannot build it.
First I tried it locally and since it is not rendering I tried your link
Here is how it renders in the LiveScript:

I.e. it looks like @codingQuizz is ignored. Is there anything I need to upgrade/update to see  it working?
Br/Alexey

I am sorry, I just added the wrong comment-notation afterwards without checking ...
Within the following example the macros should work as expected ...
Example

Awesome!
I apologize for the persistence, but I can't help but take advantage of your responsiveness:)
One more question. Is it possible to force "Check" button to also do "Execute"?
I see how you locate the "Check" button:
let btn = document.querySelector('#quiz-@0 > div:nth-child(2) > button:first-child');

The  little problem is there is one small "Execute" button and big "Check" button.
I think I can hide 'Check' button via css style, but can I  change 'Execute' to look like check? Or Make it bigger and add text "Validate" to it?
Br/Alexey

Here is an updated version ... I changed the appearance of the execute-button with the style, which is a bit more complicated, since now I need to change the code-block and the quiz, therefore both elements have been surrounded by a div.

Running Example
Changing the execute-button is easier, than executing the code from the Check-Button, then await the calculation and react onto it ...  Since i cannot directly deactivate the new Check-Button I added a solution to the end of the quiz.
The macro is a bit more difficult now and it does not close the div, since the solution is added and this is part of the quiz ... You can move the div back into the macro if you don't need solutions. Adding the macro to the head of the code-block is just another way of saying, that the content of the entire code-block should be passed as the last parameter. This is a nice way, if you require to pass in more complex JSON, YAML or what so ever configuration ...
I will think of a simpler solution ... adding a new quiz-type as a combination with code-blocks might be also interesting for others ...

Hi Andre,
Thanks a lot for this example, it works! I've modified it a bit to demonstrate a bunch of examples of my needs here
Just for the case you decide to make a dedicated quiz-type of such kind (like Moodle has) you may see my version as a reference.

Thank you again for your invaluable help!


hello

AttributeError: module ‘tensorflow‘ has no attribute ‘contrib‘
how can use ，because we are usu openvino2021.4.2

I recently succeeded in converting my model with openvino2021.4.

I created a separated virtual environment with anaconda, and run the following commands:

condo activate openvino-yolov4
conda install python==3.6.4
conda install pip
pip install tensorflow==1.15.5
pip install tqdm sklearn
python convert_weights_pb.py --class_names cfg/<your model>.names --weights_file <your model>.weights --data_format NHWC

which generated the frozen_darknet_yolov4_model.pb file.

I used my os python /usr/bin/python3 to create a venv, which was different from the condo env I had created, because OpenVINO seemed not capable with anaconda.

bash # use a different shell that has not been init with conda. I used zsh before so now I used bash.

/usr/bin/python3 -m pip install virtualenv
/usr/bin/python3 -m virtualenv -p `which python3` <directory_for_environment>
source <directory_for_environment>/bin/activate

# Than follow the installation guide provided by intel.
source /opt/intel/openvino_2021/bin/setupvars.sh
cd /opt/intel/openvino_2021/deployment_tools/model_optimizer/install_prerequisites
sudo ./install_prerequisites_tf.sh ## DO NOT use ./install_prerequisites.sh or ./install_prerequisites_tf2.sh

Finally, modify yolov4.json and run the mo script in the env created in step 2.

### Remember to use the same shell that you performed step2
python3 "/opt/intel/openvino_2021/deployment_tools/model_optimizer/mo.py" --input_model frozen_darknet_yolov4_model.pb --transformations_config yolov4.json --batch 1 --reverse_input_channels

Good luck


Updated 2nd paragraph of SWARM Intelligence

Approved

Can you please elaborate about snipped photos are they necessary every pull
request
On Wed, 16 Nov 2022, 10:30 pm Suzanne Conejos, @.***>
wrote:

@.**** requested changes on this pull request.

Please have your title approved first.
Then work on this body text.
Include proper procedure in your comments.
Include snipped photos
Include the link when necessary.

—
Reply to this email directly, view it on GitHub
https://github.com/TaoFruit/instar/pull/34#pullrequestreview-1183028090,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A4FWXEPCPF3M23ZMJEKQAVLWIUK2DANCNFSM6AAAAAASCBK6WQ
.
You are receiving this because you authored the thread.Message ID:
@.***>

Only when necessary, include snipped photos.

My title is approved and merged but is not showing on the website the paragraph changes are showing which were meged but not the title which was approved and merged

So can i start working on the description or wait for the title to approve and merge

But the first paragraph is approved and merged and also showing on website
I was only asked not to capitalise the whole word only first letter now you
want me change the whole title please give me instructions properly so I
can do as you say or as remy whom to listen please tell me
On Thu, 17 Nov 2022, 11:09 pm Suzanne Conejos, @.***>
wrote:

Your Title was not approved, and it was reverted back to its original
text. Refer here #38 https://github.com/TaoFruit/instar/pull/38
This means you have to create your title and body text again. Please read
the ReadMe.md file or study the existing headers and captions to have an
idea on what to write.
—
Reply to this email directly, view it on GitHub
https://github.com/TaoFruit/instar/pull/34#issuecomment-1319017133, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/A4FWXEIUJW5XLIMIPY2Y4VLWIZYEDANCNFSM6AAAAAASCBK6WQ
.
You are receiving this because you authored the thread.Message ID:
@.***>

I'm the current Executive Director of Instar. I suggest you use the comment section here for me to see the draft of your whole blog post including your title. Make sure all character counts are the same on each paragraph. We may do more revisions in your draft, and I'll help with it too. Once your draft is approved in the comments then do your PRs.

Ok, will do that.
On Fri, 18 Nov 2022, 12:00 am Suzanne Conejos, @.***>
wrote:

I'm the current Executive Director of Instar. I suggest you use the
comment section here for me to see the draft of your whole blog post
including your title. Make sure all character counts are the same on each
paragraph. We may do more revisions in your draft, and I'll help with it
too. Once your draft is approved in the comments then do your PRs.
—
Reply to this email directly, view it on GitHub
https://github.com/TaoFruit/instar/pull/34#issuecomment-1319072617, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/A4FWXEPD3YX734UMAYW3ZWTWIZ6F3ANCNFSM6AAAAAASCBK6WQ
.
You are receiving this because you authored the thread.Message ID:
@.***>


FIX-#3559: remove support of 'S3://...' like paths

Signed-off-by: Myachev<EMAIL_ADDRESS>
What do these changes do?

[ ] commit message follows format outlined here
[ ] passes flake8 modin
[ ] passes black --check modin
[ ] signed commit with git commit -s
[x] Resolves #3559
[ ] tests added and passing
[ ] module layout described at docs/developer/architecture.rst is up-to-date

I don't think we need this if we're fixing #3572

Oh, exactly.


The windows.vs2022* images are lagging behind significantly

See https://github.com/dotnet/sdk/pull/43015/#issuecomment-2456761270 for context on why this comes up now and is blocking.
The latest version of Visual Studio is 17.12 Preview 5 but the windows.vs2022 images (same for the open queues) have ancient versions of VS on them:

This is causing issues as MSBuild & NuGet shipped with a bug that cause issues when being used with a newer .NET SDK. Can those images please get upgraded asap? Any idea why those didn't get upgraded in months? Do we have a document that describes the expected ETA of these VS image updates? EDIT: @premun shared https://dev.azure.com/dnceng/internal/_wiki/wikis/DNCEng Services Wiki/899/VS2022-Upgrade-Schedule with me

@ilyas1974 @dougbu

From the doc:

I'm not sure I understand this. How can the "Regular Preview VS" version be older than the "Scouting Release VS" version?

@garath I know you've been working on this issue. Can you please give Viktor an update on your status?

Have Windows containers been considered as an alternative to the overhead of maintaining VMs?  VS can be installed within Windows images.  If defined correctly, rebuilds would always pick up the latest versions.  The .NET Framework SDK containers may be a good base image or at least a good reference.  One downside is the size of the windows containers.  They are most useful for non-trivial workloads and else require pre-caching.

gentle ping @ilyas1974 @garath

Apologies - was out on Friday. The CI build to merge these changes is currently running (https://dnceng.visualstudio.com/internal/_build/results?buildId=2579596&view=results). Once it is successful, we proceed with the roll out of these changes. Plan is to roll out later today.

This now happened, thanks. Can we please put this in on a retrospective. I would really like to better understand why the images lagged behind so much. Also see my other questions in the top post.

@ViktorHofer added this to our Retrospective for next month and invited you to the meeting. https://microsoft.sharepoint.com/teams/netfx/engineering/_layouts/OneNote.aspx?id=%2Fteams%2Fnetfx%2Fengineering%2FShared Documents%2FEngineering Services&wd=target(Retrospectives.one|3B3A3F21-7897-4C47-9168-43444DAC87E1%2FRollout Retrospective (12\%2F10\%2F2024\)|D49E3FFD-ABC0-4982-9E61-380947985A02%2F)
onenote:https://microsoft.sharepoint.com/teams/netfx/engineering/Shared Documents/Engineering Services/Retrospectives.one#Rollout Retrospective (12/10/2024)&section-id={3B3A3F21-7897-4C47-9168-43444DAC87E1}&page-id={D49E3FFD-ABC0-4982-9E61-380947985A02}&end

VS updates are back on schedule and retrospective has happened. No further action for now.


Enhancement request: Add optional URL to tasks and display a button on the task item

It's mainly just a passing thought but I think it would be quite handy to add the option to include a URL field in each task, then display a button on the task item that the user can click and be directed to it (in their browser).
The reason I think this would be handy is to link to different ChatGPT... chats. I don't know what everyone else does, but my log of chats is a complete mess so being able to open a chat for specific items on my board and have them organised correctly would be pretty neat.
Quick examples of what I mean:

And, of course, thanks for creating this tool in the first place - it's very useful and nicely integrated too :)

Overall I think it's a great idea, although I'd probably end up linking Github stuff more often. Not sure about the placement in the task details though. I think another text field would make it a bit cluttered. (Especially when details for a step are visible as well.)


ci: release-please-action

Description

Enable release-please-action

Fix

#20

We also need to update PR name to better reflect what we are doing here.

Have you tested this workflow in your own repository?

Yes, here (Its just a test repository)

Could you also customize names and make release only when certain tag is pushed (we want tag-based release schema).

You mean "changelog-types" in my latest commit.
Also, we can change "release-type" to python currently it in simple

Have you tested this workflow in your own repository?

Yes, here (It just test repository)

Could you also customize names and make release only when certain tag is pushed (we want tag-based release schema).

You mean "changelog-types" in my latest commit.

we can change "release-type" to python currently it is simple.
Also, we have to "Allow GitHub Actions to create and approve pull requests" (If we haven't already) in "Actions permission"

As far as I understand, we create new release on every push commit, right? This is redundant, we would prefer to have some "mechanism" to tell release-action to create release only for certain commits (e.g. commit with certain tag or may be to certain branch). I'd encourage you to think about the best strategy here.

@mshudrak What about triggering it when pushing a commit with the prefix maybe "release", what are your thoughts?

As far as I understand, we create new release on every push commit, right?

Not, exactly It just creates a new Pr with contains all previous commit like here , If we have to create a new release then we just have to merge release-please PR!

How often does it generate those PRs?

Every time we merge the pr and any new push commit happenes.

Is that literally for each commit with conventional message?

Yes, those which are mentioned in changelog-type.

Ok, let me think about that solution and PR #98. I am a bit skeptical having extra PR on almost every push we make...

Sure @mshudrak , Just putting It won't create extra PR for every single push it's just a single PR will keep track of almost every Push...

Ok, let's try this one.


DF-832-Prototype/search filters accordion

Ticket URL: https://national-archives.atlassian.net/browse/DF-832
About these changes
Integrating the GDS accordion component into search filters
How to check these changes
Performa search, open and close the filter accordion, apply filters to confirm functionality. Test across viewports.
Before assigning to reviewer, please make sure you have

[x] Checked things thoroughly before handing over to reviewer
[x] Checked PR title starts with ticket number as per project conventions to help us keep track of changes
[x] Ensured that PR includes only commits relevant to the ticket
[x] Waited for all CI jobs to pass before requesting a review
[x] Added/updated tests and documentation where relevant

Merging PR guidance
Follow docs\developer-guide\contributing.md
Deployment guidance
Follow docs\infra\environments.md

Closing this as the work will be re-done in the new ds-search repository


Add remove isolated node button; add edge filter

Add button to remove isolated nodes;
Add edge filter by weight.

LGTM


Fix cmake for macos-arm64

What changed?

Added the macos-arm64 platform to the cmake tools json.

Why?

Builds were failing on apple silicon macs due to there not being a macos-arm64 platform entry in the cmake tools json.

Notes
The same cmake package can be used as the intel macs since it's a "universal" package.
Testing
Adding the following to my project's Cargo.toml fixed my build:
[patch.crates-io]
embuild = { git = "https://github.com/kylehendricks/embuild.git", branch = "fix-macos-arm64" }

can you release this?

can you release this? @ivmarkov

Released v0.31.1

nice, thanks @N3xed


Reorganize settings adv

Closes #451
Closes #447
Did these at the same time since one would affect the other.

Coverage remained the same at 93.273% when pulling 719345c32343adfce8d1d7e399dbc28f30355eb2 on na3d:reorganize-settings-adv into 19bce0080ad0dd7f9a9fc376677aa9d0d8f5f42c on linode:master.

Coverage remained the same at 93.273% when pulling acc297b52d257a1ff029c785cc1e3dd9fabb54b1 on na3d:reorganize-settings-adv into 19bce0080ad0dd7f9a9fc376677aa9d0d8f5f42c on linode:master.

Coverage remained the same at 93.273% when pulling 08756ad08fe48dd7c2e1976d3a66c759cffdf086 on na3d:reorganize-settings-adv into 19bce0080ad0dd7f9a9fc376677aa9d0d8f5f42c on linode:master.


Changed Code to i18next in Falabracman

Changed the code from webL10n to l10n in Falabracman Activity
No Error in console
@llaske could you please review it

Thanks


Monitor a scan's progress

Is there any way to do this with a large image?

At the moment, you could run a Pipeline directly, bypassing the task system, to get the progress log displayed in the terminal:
$ cd scancode.io
$ source bin/activate
$ scanpipe create-project PROJECT_NAME --input docker_image.tar
$ DJANGO_SETTINGS_MODULE='scancodeio.settings' bin/python scanpipe/pipelines/docker.py run --project PROJECT_NAME

This will display Pipeline steps live execution:
2020-12-09 04:49:01.279 Workflow starting (run-id<PHONE_NUMBER>272759):
2020-12-09 04:49:01.284 [1607489341272759/start/1 (pid 19637)] Task is starting.
2020-12-09 04:49:02.569 [1607489341272759/start/1 (pid 19637)] Task finished successfully.
2020-12-09 04:49:02.574 [1607489341272759/extract_images/2 (pid 19644)] Task is starting.
2020-12-09 04:49:03.799 [1607489341272759/extract_images/2 (pid 19644)] Task finished successfully.
2020-12-09 04:49:03.805 [1607489341272759/extract_layers/3 (pid 19649)] Task is starting.
2020-12-09 04:49:05.016 [1607489341272759/extract_layers/3 (pid 19649)] Task finished successfully.
[...]

I will improve the task system to provide easy access to progress information about Pipeline execution.

Thanks!

@cco3 a new status management command is also available to display a high level status of a Project.
It can be useful to monitor the database objects addition:
$ scanpipe status --project PROJECT_NAME

The monitoring of Pipeline execution was improved and is available in the command line, the UI, and the REST API.
Command line
$ scanpipe status --project PROJECT_NAME

Project: MyProject
Create date: Feb 16 2021 06:08
Work directory: /var/projects/MyProject-40599791

Database:
 - CodebaseResource: 403
   - (no status): 398
   - ignored-not-interesting: 4
   - scanned: 1
 - DiscoveredPackage: 0
 - ProjectError: 1

Pipelines:
 [RUNNING] docker
   2021-02-16 06:08:06.95 Pipeline [docker] starting
   2021-02-16 06:08:06.95 Step [extract_images] starting
   2021-02-16 06:08:06.97 Step [extract_images] completed in 0.02 seconds
   2021-02-16 06:08:06.97 Step [extract_layers] starting
   2021-02-16 06:08:07.13 Step [extract_layers] completed in 0.16 seconds
   2021-02-16 06:08:07.14 Step [find_images_linux_distro] starting
   2021-02-16 06:08:07.14 Step [find_images_linux_distro] completed in 0.00 seconds
   2021-02-16 06:08:07.14 Step [collect_images_information] starting
[...]

UI
From the Project details view, click on the "Running" pipeline entry in the Pipeline section:

This will open a modal with the current progress:

REST API
GET /api/projects/<PROJECT_UUID>/
The progress values are available in the runs field.


Add a share button for vk.com

VK is the biggest social network in the CIS countries.
Along with adding the share button for it I also removed the repeating inline style and fixed the formatting in social.scss.

Thank you @nscyclone, I really appreciate all of your help 👍


Fixed Travis build

Hey @kallyas,
Something went wrong with the build.
TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.
View build log
TravisBuddy Request Identifier: 18be3f50-9b58-11ea-acf2-2540bfc6cd37


navbar dropdown animation

Is your feature request related to a problem? Please describe.
There is no animation for navbar dropdown for mobile responsive devices
Describe the solution you'd like
I would like to create an animation for the drop down
Additional context

please assign this issue to me @Priyaaa1

I can make the animations for navbar by adding dropdown menu. please assign the task to me


[BUG]

Description
c00-1a7d-465b-9be8-3e440df9b8db service=HTTP_SERVER
[GIN] 2024/11/15 - 10:26:23 | 200 |   14.233517ms |      <IP_ADDRESS> | POST     "/start"
[agora_row46y] sh: 1:
[agora_row46y] /app/agents/bin/start: not found
2024/11/15 10:26:23 ERROR Worker process failed err="exit status 127" requestId=14982c00-1a7d-465b-9be8-3e440df9b8db service=HTTP_SERVER
2024/11/15 10:26:26 INFO handlerPing start channelName=agora_row46y requestId=ba0dde5f-cf33-4352-8af1-13b68ac2d2ee service=HTTP_SERVER
2024/11/15 10:26:26 ERROR handlerPing channel not existed channelName=agora_row46y requestId=ba0dde5f-cf33-4352-8af1-13b68ac2d2ee service=HTTP_SERVER
[GIN] 2024/11/15 - 10:26:26 | 200 |     274.754µs |      <IP_ADDRESS> | POST     "/ping"
2024/11/15 10:26:29 INFO handlerPing start channelName=agora_row46y requestId=5395be78-adb3-40fd-8f24-d49e7f9ff915 service=HTTP_SERVER
2024/11/15 10:26:29 ERROR handlerPing channel not existed channelName=agora_row46y requestId=5395be78-adb3-40fd-8f24-d49e7f9ff915 service=HTTP_SERVER
[GIN] 2024/11/15 - 10:26:29 | 200 |     197.966µs |      <IP_ADDRESS> | POST     "/ping"
2024/11/15 10:26:32 INFO handlerPing start channelName=agora_row46y requestId=e8194a8d-0c80-4053-a379-22e025cb03d4 service=HTTP_SERVER
2024/11/15 10:26:32 ERROR handlerPing channel not existed channelName=agora_row46y requestId=e8194a8d-0c80-4053-a379-22e025cb03d4 service=HTTP_SERVER
[GIN] 2024/11/15 - 10:26:32 | 200 |     133.573µs |      <IP_ADDRESS> | POST     "/ping"
2024/11/15 10:26:35 INFO handlerPing start channelName=agora_row46y requestId=fc22e42b-4019-40df-bb03-ed3dfd25bac2 service=HTTP_SERVER
2024/11/15 10:26:35 ERROR handlerPing channel not existed channelName=agora_row46y requestId=fc22e42b-4019-40df-bb03-ed3dfd25bac2 service=HTTP_SERVER
when I connect the localhost:3000 and connect the agent, the log shows that, I cannot solve this problem. A few days ago, I also could use this as normal.
Environment
Windows system
Steps to reproduce
if you have some advice, you can write down.
Expected behavior
the agent can be used as normal
Severity
Critical
Additional Information
this is the information of operation：docker compose up
C:\Users\Lenovo\TEN-Agent>docker compose up
[+] Running 4/0
✔ Container ten_graph_designer    Created                                                                         0.0s
✔ Container ten_agent_playground  Created                                                                         0.0s
✔ Container ten_agent_demo        Created                                                                         0.0s
✔ Container ten_agent_dev         Created                                                                         0.0s
Attaching to ten_agent_demo, ten_agent_dev, ten_agent_playground, ten_graph_designer
ten_agent_playground  |    ▲ Next.js 15.0.3
ten_agent_playground  |    - Local:        http://localhost:3000
ten_agent_dev         | >> run graph designer server
ten_agent_playground  |    - Network:      http://<IP_ADDRESS>:3000
ten_agent_dev         | cd agents && tman dev-server
ten_agent_playground  |
ten_agent_playground  |  ✓ Starting...
ten_agent_dev         | :-)  Starting server at http://<IP_ADDRESS>:49483
ten_agent_playground  |  ✓ Ready in 147ms
ten_graph_designer    |   ▲ Next.js 14.2.4
ten_graph_designer    |   - Local:        http://localhost:3000
ten_graph_designer    |   - Network:      http://<IP_ADDRESS>:3000
ten_graph_designer    |
ten_graph_designer    |  ✓ Starting...
ten_graph_designer    |  ✓ Ready in 122ms
ten_agent_demo        |    ▲ Next.js 15.0.3
ten_agent_demo        |    - Local:        http://localhost:3000
ten_agent_demo        |    - Network:      http://<IP_ADDRESS>:3000
ten_agent_demo        |
ten_agent_demo        |  ✓ Starting...
ten_agent_demo        |  ✓ Ready in 99ms

and  /app/agents/bin/start: not found here show the start not found, but I check it, I see it is exist

@Michael-Nan1 Maybe an issue with Windows-style line endings (CRLF). Can you try sed -i 's/\r$//' /app/agents/bin/start?

@Michael-Nan1 Maybe an issue with Windows-style line endings (CRLF). Can you try sed -i 's/\r$//' /app/agents/bin/start?

I have changed it, but you can see, it also shows this error
/app/agents/bin/start: not found
2024/11/15 10:26:23 ERROR Worker process failed err="exit status 127" requestId=14982c00-1a7d-465b-9be8-3e440df9b8db service=HTTP_SERVER

And, this is after your hit the connect button?

closed. feel free to reopen if issue persists.


Adding styling to the website.

A basic background coloring to the website and some gradients to the header to make it look eye-catchy .

Hey @matteobruni  can u please assign me this issue under hacktoberfest Label .

Thank you @matteobruni for assigning me the issue . can u please add the Hacktoberfest label .

Please assign me this issue. I would like to contribute in it.


Collection Watch - Change Streams

Hi all,
How can I watch Change Streams with monk?
const MongoClient = require("mongodb").MongoClient;
const assert = require("assert");
/*
Modify Change Stream Output using Aggregation Pipelines
You can control change stream output by providing an array of one or more of the following pipeline stages when configuring the change stream:
$match, $project, $addFields, $replaceRoot, $redact
See Change Events for more information on the change stream response document format.
*/
const pipeline = [
  {
    $project: { documentKey: false }
  }
];
MongoClient.connect("mongodb://localhost:27017,localhost:27018,localhost:27019?replicaSet=mongo-repl")
  .then(client => {
    console.log("Connected correctly to server");
    // specify db and collections
    const db = client.db("superheroesdb");
    const collection = db.collection("superheroes");

    const changeStream = collection.watch(pipeline);
    // start listen to changes
    changeStream.on("change", function(change) {
      console.log(change);
    });

  })
  .catch(err => {
    console.error(err);
});

It would at least be nice to have the ability to access the underlying native mongodb connection.


[Spark] Replace the default pattern matching for LogicalRelation to LogicalRelationWithTable

Which Delta project/connector is this regarding?

[x] Spark
[ ] Standalone
[ ] Flink
[ ] Kernel
[ ] Other (fill in here)

Description
This PR proposes to replace the default pattern matching for LogicalRelation to newly introduced pattern object LogicalRelationWithTable which will be available in upcoming Spark 4.0.
This change helps the project to modify less pieces of code when Spark makes the change to the LogicalRelation; most pattern matchings with LogicalRelation only extract the relation and catalog table, hence they fit with LogicalRelationWithTable.
How was this patch tested?
Existing tests would suffice.
Does this PR introduce any user-facing changes?
No.

I'm planning to propose the change of LogicalRelation (new parameter of constructor) in Spark 4.0, which will break all pattern matches. For creating an instance of LogicalRelation, I'll try to figure out the way to be compatible with existing constructor. But for pattern matching, every addition of parameter require patterns to be updated. It won't be needed after this PR.


Location devlxd api

Resolves #8758

This pull request didn't trigger Jenkins as its author isn't in the whitelist.
An organization member must perform one of the following:

To have this branch tested by Jenkins, use the "ok to test" command.
To have a one time test done, use the "test this please" command.

Those commands are simple Github comments of the format: "jenkins: COMMAND"

Looks good to me!

jenkins: test this please

Testsuite passed


Proper error handling

please

I believe that a bug (#16) was caused by non-finite coordinates in the input data. The new release (#19) will raise an informative exception if it encounters these coordinates but they will need to be removed from the input data before using the library.


Change typed array signatures

Fixes #17962.
This PR changes the constructor definitions of the typed arrays to allow for valid code as described in #17962. This is an alternative to #17978.

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot


Fix makefile to do what ./configure normally would do for zlib

Competes with #3380, pull one or the other.

Yep, this would be why I'm not seeing this warning in GDC builds (we actually run configure).

I guess for DMD's use of Phobos, this is fine.  Lets toggle

Auto-merge toggled on


Fixfor ruby3

Summary
add support for ruby 3 while maintaining backwards compatibility

Will this be released soon?

@justin808 this repository is dead, if you wish to use comfortable_mexican_sofa please use this fork: https://github.com/restarone/comfortable-mexican-sofa
if you want a fully featured Ruby content-management and app platform, see Violet Rails http://github.com/restarone/violet_rails/
reference: https://stackoverflow.com/questions/70086572/setting-up-comfy-cms-fails-with-multi-tenancy-app


Cabal project and GitHub actions

https://github.com/kim/opentracing/pull/25#issuecomment-699558560
I am trying to build the project with gogol-0.3 and Cabal.  I expect a revision to gogol-0.3 will be required: https://github.com/brendanhay/gogol/commit/135a4d795b48c8311dedb674b7bfefdc06e2ea7e

Closed via #29


Fix bug in EphysRig validator

The validator for the EphysRig class checks whether all devices connected to DAQDevice objects exist in the schema. But it did not previously allow connections between DAQDevice objects. This change fixes that.
Fixes #458

@jtyoung84 Any recommendations on how to fix the linter issue? (EphysRig.validate_device_names is too complex)

@jtyoung84 Any recommendations on how to fix the linter issue? (EphysRig.validate_device_names is too complex)

@jsiegle It's not something that should be done very often, but if it isn't possible to reduce the complexity in code, you can add a tag to tell flake8 to ignore the block. You can see an example here: https://github.com/AllenNeuralDynamics/aind-data-transfer/blob/15151e53de39aa11141391c8fc199e6bd8e0fe12/src/aind_data_transfer/jobs/openephys_job.py#L54
It should be possible to test flake8 locally. Also, for internal collaborators, we've leaned towards using feature branches instead of forks. It's not a big deal if you have a preference for opening prs through forks, but it makes it easier for maintainers to pull down the branch.

Thanks, just fixed it.
I'll be sure to use feature branches for future PRs.


Encoding auto guessing: Use buffer properly

Related to #21416
Fixed to use slice of the part of bytesRead.
Before the change, even if bytesRead is smaller than 512,the buffer of 512 byte whose last some bytes are uninitialized values is passed to encoding.guessEncodingByBuffer.
Maybe it cause weired encoding guessing.

@katainaka0503 can you elaborate why this change is needed?

@bpasero Updated this PR's description.

LGTM, thanks for catching.


output is not cleared if second run outputs nothing

If I run my code and output is generated and then do another run without any output, the output is not cleared and still shows the previous results, which might be confusing.
Run once, set output to false and run again, output still shows Hello World instead of being empty:
https://goplay.tools/snippet/inNWqvG_K6Q

@dear3vil I can't reproduce the issue. Can you please provide a demo?
https://github.com/x1unix/go-playground/assets/9203548/a9010a83-c4b2-49d0-b957-fe13d6a04add

@x1unix
Please check attached video, I'm using the latest version of Firefox. Just tried with an untouched Edge Browser, same result.
https://github.com/x1unix/go-playground/assets/138237715/13cfb6e3-6e65-48c7-a994-0b556a30daf2

@dear3vil thanks for reporting the issue!


Panic if kevent() returns ENOENT in FreeBSD.

We are getting an infrequent process panic in some code using libuv on FreeBSD.
distro/src/unix/kqueue.c
void uv__io_poll(uv_loop_t* loop, int timeout) {
...
nfds = kevent(loop->backend_fd,
               events,
               nevents,
               events,
               ARRAY_SIZE(events),
               timeout == -1 ? NULL : &spec);

...
 if (nfds == -1)
     if (errno != EINTR)
           abort();

In our case errno is ENOENT
(ugdb-x86_64-7.11-261) bt
#0  thr_kill () at thr_kill.S:3
#1  0x0000000833970694 in __raise (s=6) at ../../../../../../src/lib/libc/gen/raise.c:52
#2  0x0000000833a64f49 in abort () at ../../../../../../src/lib/libc/stdlib/abort.c:67
#3  0x000000082ccd64be in uv__io_poll (loop=0x83f3f2608, timeout=999) at ../../../../distro/src/unix/kqueue.c:237
#4  0x000000082ccb6e0b in uv_run (loop=0x83f3f2608, mode=UV_RUN_ONCE) at ../../../../distro/src/unix/core.c:385
...

We've not been able to discern why kevent is returning ENOENT,  the events being passed look ok
> (ugdb-x86_64-7.11-261) p nevents
> $9 = 3
> (ugdb-x86_64-7.11-261) p events[0]
> $10 = {ident = 295, filter = -1, flags = 1, fflags = 0, data = 0, udata = 0x0, ext = {0, 0, 0, 0}}
> (ugdb-x86_64-7.11-261) p events[1]
> $11 = {ident = 304, filter = -1, flags = 1, fflags = 0, data = 0, udata = 0x0, ext = {0, 0, 0, 0}}
> (ugdb-x86_64-7.11-261) p events[2]
> $12 = {ident = 315, filter = -2, flags = 1, fflags = 0, data = 0, udata = 0x0, ext = {0, 0, 0, 0}}
>

Would not aborting in the ENOENT case be ok here?  Perhaps just returning from uv__io_poll at that point?  I'd like the code to fail gracefully rather than aborting if at all possible.
Any preferences out there to how to handle this case?

On what kind of system is this and do you happen to know what type of file descriptors are being added here?

This is a qpid-proton based system running on FreeBSD, the fds are network sockets.  We've had a lot of issues with what happens when connections go down and things are not being cleaned up in an orderly fashion.  Perhaps this is an example of that.
My thinking about swallowing the ENOENT was it would allow the poll to complete and then higher level code react to whatever
event changed the state and caused the kevent to return that code.  What would be the right way to leave that loop?  I just added the ENOENT to the conditional so it falls through to update_timeout.  So far I have not had any issues but would returning or continuing be better, as per the timeout cases?
 void uv__io_poll(uv_loop_t* loop, int timeout) {
...
nfds = kevent(loop->backend_fd,
               events,
               nevents,
               events,
               ARRAY_SIZE(events),
               timeout == -1 ? NULL : &spec);

...
    if (nfds == -1) {
        if (errno != EINTR && errno != ENOENT)   <<== added ENOENT here
            abort();
      if (timeout == 0)
        return;
      if (timeout == -1)
        continue;
      /* Interrupted by a signal. Update timeout and poll again. */
      goto update_timeout;
    }

I think the first step is to understand why the kernel returns ENOENT. "No such entity" doesn't make sense for sockets.

Tagged not-stale to keep the stalebot at bay.


dialog should have configurable exit event, and default to mouseleave

Right now it uses mouseout, which generally does the wrong thing for a tooltip.

Awesome thanks! Can we make this work for v9, too?

For sure!


Segwit + LN network?

When will you implement Segwit(like litecoin did) and Lightning network?

ok

great


Fixes bottom popup adds ok button

This PR

Fixes date-time popup near bottom of the page.
As suggested in adamalbrecht/ngQuickDate#35
Adds ok button and deletes 'instantaneously disappearing option' after user picks Date,
so the user can pick also Time.

@adamalbrecht

@yuliroth Hey there! If you can go on and fix these conflicts I would be happy to merge this PR. Let me know if you need any help I would be glad to help out maybe with a pair programming session. :+1:

@novarac23 Done

@yuliroth Super cool! Will take a look as soon as I get some free time! Great work :muscle:


Chaincode Query support

POST /query

{
    "headers": {
        "signer": "user4",
        "channel": "default-channel",
        "chaincode": "asset_transfer"
    },
    "func": "GetAllAssets",
    "args": []
}

Response:
{
    "headers": {
        "id": "9b92d3e5-6bee-433c-63d8-303b09784779",
        "type": "QuerySuccess",
        "timeReceived": "2021-12-19T20:12:45.979664Z",
        "timeElapsed": 0.037289,
        "requestOffset": "",
        "requestId": ""
    },
    "result": [
        {
            "ID": "asset-151713",
            "appraisedValue": 1300,
            "color": "yellow",
            "owner": "Tom",
            "size": 5
        },
        {
            "ID": "asset-583666",
            "appraisedValue": 1300,
            "color": "yellow",
            "owner": "Tom",
            "size": 5
        }
    ]
}

Codecov Report

Merging #64 (e007e04) into main (726e19e) will decrease coverage by 0.74%.
The diff coverage is 6.97%.

@@            Coverage Diff             @@
##             main      #64      +/-   ##
==========================================
- Coverage   55.77%   55.03%   -0.75%
==========================================
  Files          29       29
  Lines        2492     2531      +39
==========================================
+ Hits         1390     1393       +3
- Misses       1030     1067      +37
+ Partials       72       71       -1

Impacted Files
Coverage Δ

internal/rest/utils/params.go
35.55% <0.00%> (-7.40%)
:arrow_down:

internal/rest/router.go
20.68% <12.50%> (-0.30%)
:arrow_down:

internal/fabric/client/eventsubscriber.go
37.50% <50.00%> (+3.57%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 726e19e...e007e04. Read the comment docs.


The following error occurred when the client connected

Error during WebSocket handshake: Sent non-empty 'Sec-WebSocket-Protocol' header but no response was received
How should I set up the server?

Show your client side codes please.

My client side is literally just this:
var socket = new WebSocket('ws://localhost:2346');
and it breaks the php library.

var socket = new WebSocket('ws://localhost:2346', protocols);.
Workerman not support the  second parameter protocols. Please check.

Thank you for your reply. I've settled it.


Support ruby3

note
rexml
aws-sdk-core requires either libxml,nokogiri,oga,ox or rexml. https://github.com/aws/aws-sdk-ruby/blob/7b563dc8389ad4d1604a652a5cd3c8ace622208a/gems/aws-sdk-core/lib/aws-sdk-core/xml/parser.rb#L70-L72
In ruby3 rexml gem is not installed by default https://www.ruby-lang.org/en/news/2020/12/25/ruby-3-0-0-released/
Now rexml dependent on crack from v0.4.5 https://github.com/jnunemaker/crack/pull/62 .
But I think it was just a coincidence.
So, I add rexml to runtime dependency.
Application using mini_paperclip can use nokogiri or others if it's installed.

@katsyoshi plz review it!


Fix Her monkey patch #first_or_create/initialize

Really simple patch to unwrap filter when creating/initializing.
Specs were a bit harder :)

:+1:


Confirm that require is a function

Checks if require is actually a function available to us before we use it to MakeTwix.

What issue does this fix? You had require in scope but it was something else?

Yeah, I had PhantomJS giving me an error about not having require when it tried running tests.

I don't really get it; seems like it should only call require() if your tests use require, in which case...it should exist. I pulled down phantom.js and checked what it defines:
phantomjs> global.module
undefined
phantomjs> typeof(global.require)
"function"

To be sure, I have no idea what that require function actually does but I don't really understand how you got in the spot where module was defined but require was something else. Can you elaborate?
I'm not trying to be obstructive here; it's just that I've been burned in the past making changes to loading code that I didn't really understand that fixed environment X but broke environment Y.

I'm not 100% certain what conditions lead to phantomjs having access to module.exports without require, but I'm guessing it has something to do with not having the requirejs framework configured in karma (I'll have to play around with it to verify that tomorrow).
Either way, this change shouldn't have any impacts on another build environments, considering all it's doing is making sure that require is actually available as a function rather than assuming that it is a function and trying to execute it. We're just adding an extra safety net to capture this particular scenario. If things are already working for other people, it should continue to work, since typeof(require) should be a function already.

I'm going to merge this since I agree it's harmless. But I suspect you'll want to find out what's defining module.exports but not require on your end.


HDFS-17488. DN can fail IBRs with NPE when a volume is removed

Description of PR
Error logs
2024-04-22 15:46:33,422 [BP-1842952724-<IP_ADDRESS>-1713771988830 heartbeating to localhost/<IP_ADDRESS>:64977] ERROR datanode.DataNode (BPServiceActor.java:run(922)) - Exception in BPOfferService for Block pool BP-1842952724-<IP_ADDRESS>-1713771988830 (Datanode Uuid 1659ffaf-1a80-4a8e-a542-643f6bd97ed4) service to localhost/<IP_ADDRESS>:64977
java.lang.NullPointerException
    at org.apache.hadoop.hdfs.protocolPB.DatanodeProtocolClientSideTranslatorPB.blockReceivedAndDeleted(DatanodeProtocolClientSideTranslatorPB.java:246)
    at org.apache.hadoop.hdfs.server.datanode.IncrementalBlockReportManager.sendIBRs(IncrementalBlockReportManager.java:218)
    at org.apache.hadoop.hdfs.server.datanode.BPServiceActor.offerService(BPServiceActor.java:749)
    at org.apache.hadoop.hdfs.server.datanode.BPServiceActor.run(BPServiceActor.java:920)
    at java.lang.Thread.run(Thread.java:748)

The root cause is in BPOfferService#notifyNamenodeBlock, happens when it's called on a block belonging to a volume already removed prior. Because the volume was already removed
private void notifyNamenodeBlock(ExtendedBlock block, BlockStatus status,
    String delHint, String storageUuid, boolean isOnTransientStorage) {
  checkBlock(block);
  final ReceivedDeletedBlockInfo info = new ReceivedDeletedBlockInfo(
      block.getLocalBlock(), status, delHint);
  final DatanodeStorage storage = dn.getFSDataset().getStorage(storageUuid);

  // storage == null here because it's already removed earlier.

  for (BPServiceActor actor : bpServices) {
    actor.getIbrManager().notifyNamenodeBlock(info, storage,
        isOnTransientStorage);
  }
}

so IBRs with a null storage are now pending.
The reason why notifyNamenodeBlock can trigger on such blocks is up in DirectoryScanner#reconcile
  public void reconcile() throws IOException {
    LOG.debug("reconcile start DirectoryScanning");
    scan();

    // If a volume is removed here after scan() already finished running,
    // diffs is stale and checkAndUpdate will run on a removed volume

    // HDFS-14476: run checkAndUpdate with batch to avoid holding the lock too
    // long
    int loopCount = 0;
    synchronized (diffs) {
      for (final Map.Entry<String, ScanInfo> entry : diffs.getEntries()) {
        dataset.checkAndUpdate(entry.getKey(), entry.getValue());
        ...
  }

Inside checkAndUpdate, memBlockInfo is null because all the block meta in memory is removed during the volume removal, but diskFile still exists. Then DataNode#notifyNamenodeDeletedBlock (and further down the line, notifyNamenodeBlock) is called on this block.
This patch effectively contains 2 parts:

Preventing processing IBRs with null storage
Preventing FsDatasetImpl#checkAndUpdate from running on a block belonging to a removed storage

How was this patch tested?
Unit tests. Partially on production cluster.
For code changes:

[x] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
12m 25s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
44m 20s

trunk passed

+1 :green_heart:
compile
1m 23s

trunk passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1

+1 :green_heart:
compile
1m 14s

trunk passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

+1 :green_heart:
checkstyle
1m 12s

trunk passed

+1 :green_heart:
mvnsite
1m 24s

trunk passed

+1 :green_heart:
javadoc
1m  6s

trunk passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1

+1 :green_heart:
javadoc
1m 46s

trunk passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

+1 :green_heart:
spotbugs
3m 18s

trunk passed

+1 :green_heart:
shadedclient
35m 28s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 12s

the patch passed

+1 :green_heart:
compile
1m 14s

the patch passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1

+1 :green_heart:
javac
1m 14s

the patch passed

+1 :green_heart:
compile
1m  7s

the patch passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

+1 :green_heart:
javac
1m  7s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
1m  1s
/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs-project/hadoop-hdfs: The patch generated 1 new + 230 unchanged - 0 fixed = 231 total (was 230)

+1 :green_heart:
mvnsite
1m 12s

the patch passed

+1 :green_heart:
javadoc
0m 53s

the patch passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1

+1 :green_heart:
javadoc
1m 34s

the patch passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

+1 :green_heart:
spotbugs
3m 18s

the patch passed

+1 :green_heart:
shadedclient
35m 53s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
235m 27s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 44s

The patch does not generate ASF License warnings.

388m 51s

Reason
Tests

Failed junit tests
hadoop.hdfs.server.datanode.TestBPOfferService

hadoop.hdfs.server.datanode.TestLargeBlockReport

hadoop.hdfs.server.datanode.TestDirectoryScanner

Subsystem
Report/Notes

Docker
ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6759/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6759

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 34352d4fc452 5.15.0-94-generic #104-Ubuntu SMP Tue Jan 9 15:25:40 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / d5a87e15db1c70fb0c3974832c75504ff184b0d1

Default Java
Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6759/1/testReport/

Max. process+thread count
4417 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6759/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

_ Prechecks _

+1 :green_heart:
dupname
0m 02s

No case conflicting files found.

+0 :ok:
spotbugs
0m 00s

spotbugs executables are not available.

+0 :ok:
codespell
0m 00s

codespell was not available.

+0 :ok:
detsecrets
0m 01s

detect-secrets was not available.

+1 :green_heart:
@author
0m 00s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m 00s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
118m 49s

trunk passed

+1 :green_heart:
compile
8m 15s

trunk passed

+1 :green_heart:
checkstyle
6m 34s

trunk passed

+1 :green_heart:
mvnsite
8m 28s

trunk passed

+1 :green_heart:
javadoc
7m 31s

trunk passed

+1 :green_heart:
shadedclient
190m 44s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
6m 57s

the patch passed

+1 :green_heart:
compile
4m 54s

the patch passed

+1 :green_heart:
javac
4m 54s

the patch passed

+1 :green_heart:
blanks
0m 00s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
3m 25s

the patch passed

+1 :green_heart:
mvnsite
6m 07s

the patch passed

+1 :green_heart:
javadoc
4m 56s

the patch passed

+1 :green_heart:
shadedclient
207m 49s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
asflicense
9m 28s

The patch does not generate ASF License warnings.

557m 52s

Subsystem
Report/Notes

GITHUB PR
https://github.com/apache/hadoop/pull/6759

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
MINGW64_NT-10.0-17763 9dbcaf4dc965 3.4.10-87d57229.x86_64 2024-02-14 20:17 UTC x86_64 Msys

Build tool
maven

Personality
/c/hadoop/dev-support/bin/hadoop.sh

git revision
trunk / d5a87e15db1c70fb0c3974832c75504ff184b0d1

Default Java
Azul Systems, Inc.-1.8.0_332-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch-windows-10/job/PR-6759/1/testReport/

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch-windows-10/job/PR-6759/1/console

versions
git=2.44.0.windows.1

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

Hi @ZanderXu @Hexiaoqiao, can you help me take a look whenever you're free? Thanks!

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
12m 13s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
46m 32s

trunk passed

+1 :green_heart:
compile
1m 18s

trunk passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1

+1 :green_heart:
compile
1m 17s

trunk passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

+1 :green_heart:
checkstyle
1m  9s

trunk passed

+1 :green_heart:
mvnsite
1m 25s

trunk passed

+1 :green_heart:
javadoc
1m  9s

trunk passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1

+1 :green_heart:
javadoc
1m 43s

trunk passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

+1 :green_heart:
spotbugs
3m 18s

trunk passed

+1 :green_heart:
shadedclient
36m 54s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 15s

the patch passed

+1 :green_heart:
compile
1m 18s

the patch passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1

+1 :green_heart:
javac
1m 18s

the patch passed

+1 :green_heart:
compile
1m 11s

the patch passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

+1 :green_heart:
javac
1m 11s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 59s

the patch passed

+1 :green_heart:
mvnsite
1m 16s

the patch passed

+1 :green_heart:
javadoc
0m 55s

the patch passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1

+1 :green_heart:
javadoc
1m 36s

the patch passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

+1 :green_heart:
spotbugs
3m 24s

the patch passed

+1 :green_heart:
shadedclient
37m 30s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
227m 24s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 43s

The patch does not generate ASF License warnings.

385m 19s

Reason
Tests

Failed junit tests
hadoop.hdfs.server.datanode.TestBPOfferService

hadoop.hdfs.server.datanode.TestLargeBlockReport

Subsystem
Report/Notes

Docker
ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6759/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6759

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 770ac906a345 5.15.0-94-generic #104-Ubuntu SMP Tue Jan 9 15:25:40 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 4b773c6a8b2014e2e21151e2d9163e871994912a

Default Java
Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6759/2/testReport/

Max. process+thread count
3559 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6759/2/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 20s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
32m 39s

trunk passed

+1 :green_heart:
compile
0m 43s

trunk passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1

+1 :green_heart:
compile
0m 40s

trunk passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

+1 :green_heart:
checkstyle
0m 36s

trunk passed

+1 :green_heart:
mvnsite
0m 45s

trunk passed

+1 :green_heart:
javadoc
0m 40s

trunk passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1

+1 :green_heart:
javadoc
1m  5s

trunk passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

+1 :green_heart:
spotbugs
1m 44s

trunk passed

+1 :green_heart:
shadedclient
20m 49s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 33s

the patch passed

+1 :green_heart:
compile
0m 37s

the patch passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1

+1 :green_heart:
javac
0m 37s

the patch passed

+1 :green_heart:
compile
0m 33s

the patch passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

+1 :green_heart:
javac
0m 33s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 30s

the patch passed

+1 :green_heart:
mvnsite
0m 36s

the patch passed

+1 :green_heart:
javadoc
0m 29s

the patch passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1

+1 :green_heart:
javadoc
0m 59s

the patch passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

+1 :green_heart:
spotbugs
1m 44s

the patch passed

+1 :green_heart:
shadedclient
21m  4s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
204m 49s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 28s

The patch does not generate ASF License warnings.

293m 24s

Reason
Tests

Failed junit tests
hadoop.hdfs.server.datanode.TestBPOfferService

Subsystem
Report/Notes

Docker
ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6759/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6759

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 258959f150db 5.15.0-94-generic #104-Ubuntu SMP Tue Jan 9 15:25:40 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 07f35e4bb9fa7af0e940cb91c970bd4eaf5c5ae0

Default Java
Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6759/3/testReport/

Max. process+thread count
4188 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6759/3/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 30s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
44m 26s

trunk passed

+1 :green_heart:
compile
1m 21s

trunk passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1

+1 :green_heart:
compile
1m 16s

trunk passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

+1 :green_heart:
checkstyle
1m 11s

trunk passed

+1 :green_heart:
mvnsite
1m 22s

trunk passed

+1 :green_heart:
javadoc
1m  7s

trunk passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1

+1 :green_heart:
javadoc
1m 50s

trunk passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

+1 :green_heart:
spotbugs
3m 21s

trunk passed

+1 :green_heart:
shadedclient
36m  1s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 10s

the patch passed

+1 :green_heart:
compile
1m 14s

the patch passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1

+1 :green_heart:
javac
1m 14s

the patch passed

+1 :green_heart:
compile
1m  9s

the patch passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

+1 :green_heart:
javac
1m  9s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
1m  1s

the patch passed

+1 :green_heart:
mvnsite
1m 13s

the patch passed

+1 :green_heart:
javadoc
0m 53s

the patch passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1

+1 :green_heart:
javadoc
1m 36s

the patch passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

+1 :green_heart:
spotbugs
3m 17s

the patch passed

+1 :green_heart:
shadedclient
36m  7s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
232m 56s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 46s

The patch does not generate ASF License warnings.

374m 52s

Reason
Tests

Failed junit tests
hadoop.hdfs.server.datanode.TestLargeBlockReport

Subsystem
Report/Notes

Docker
ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6759/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6759

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 1f3c0fcbc898 5.15.0-94-generic #104-Ubuntu SMP Tue Jan 9 15:25:40 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 1f166985eedcfea6aedcc62046908f86ed9827fa

Default Java
Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6759/4/testReport/

Max. process+thread count
4094 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6759/4/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@kokonguyen191 Thanks for your report and contributions. Sorry didn't get this issue completely.
As description, you mentioned that storage == null as following. I wonder why NPE not throw at getPerStorageIBR(storage).put(rdbi); first which at org.apache.hadoop.hdfs.server.datanode.IncrementalBlockReportManager#addRDBI.
private void notifyNamenodeBlock(ExtendedBlock block, BlockStatus status,
    String delHint, String storageUuid, boolean isOnTransientStorage) {
  checkBlock(block);
  final ReceivedDeletedBlockInfo info = new ReceivedDeletedBlockInfo(
      block.getLocalBlock(), status, delHint);
  final DatanodeStorage storage = dn.getFSDataset().getStorage(storageUuid);

  // storage == null here because it's already removed earlier.

  for (BPServiceActor actor : bpServices) {
    actor.getIbrManager().notifyNamenodeBlock(info, storage,
        isOnTransientStorage);
  }
}

Another side, you mentioned that this issue is triggered by volume removed, so how the logic between volume removed to NPE. Thanks again.

Hi @Hexiaoqiao, thanks for the review. For your first question, getPerStorageIBR(storage) doesn't do a null check on storage and assigns a new PerStorageIBG object to null. So it pretty much just considers null to be a new storage. For your second question, the NPE in IBRs is caused by a block report with null storage. The condition for this to happen is for a storage to be removed after DirectoryScanner has just finished a scan but hasn't started processing the blocks yet, so the scan result is now stale and contains removed storage.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

_ Prechecks _

+1 :green_heart:
dupname
0m 02s

No case conflicting files found.

+0 :ok:
spotbugs
0m 01s

spotbugs executables are not available.

+0 :ok:
codespell
0m 01s

codespell was not available.

+0 :ok:
detsecrets
0m 01s

detect-secrets was not available.

+1 :green_heart:
@author
0m 00s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m 01s

The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
111m 47s

trunk passed

+1 :green_heart:
compile
7m 33s

trunk passed

+1 :green_heart:
checkstyle
6m 01s

trunk passed

+1 :green_heart:
mvnsite
8m 01s

trunk passed

+1 :green_heart:
javadoc
7m 10s

trunk passed

+1 :green_heart:
shadedclient
179m 43s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
5m 48s

the patch passed

+1 :green_heart:
compile
4m 16s

the patch passed

+1 :green_heart:
javac
4m 16s

the patch passed

+1 :green_heart:
blanks
0m 01s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
2m 48s

the patch passed

+1 :green_heart:
mvnsite
5m 19s

the patch passed

+1 :green_heart:
javadoc
4m 32s

the patch passed

+1 :green_heart:
shadedclient
198m 13s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
asflicense
6m 53s

The patch does not generate ASF License warnings.

523m 16s

Subsystem
Report/Notes

GITHUB PR
https://github.com/apache/hadoop/pull/6759

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
MINGW64_NT-10.0-17763 96a75b329453 3.4.10-87d57229.x86_64 2024-02-14 20:17 UTC x86_64 Msys

Build tool
maven

Personality
/c/hadoop/dev-support/bin/hadoop.sh

git revision
trunk / 1f166985eedcfea6aedcc62046908f86ed9827fa

Default Java
Azul Systems, Inc.-1.8.0_332-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch-windows-10/job/PR-6759/5/testReport/

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch-windows-10/job/PR-6759/5/console

versions
git=2.44.0.windows.1

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@kokonguyen191 Thanks for your report and contributions. Sorry didn't get this issue completely. As description, you mentioned that storage == null as following. I wonder why NPE not throw at getPerStorageIBR(storage).put(rdbi); first which at org.apache.hadoop.hdfs.server.datanode.IncrementalBlockReportManager#addRDBI.
private void notifyNamenodeBlock(ExtendedBlock block, BlockStatus status,
    String delHint, String storageUuid, boolean isOnTransientStorage) {
  checkBlock(block);
  final ReceivedDeletedBlockInfo info = new ReceivedDeletedBlockInfo(
      block.getLocalBlock(), status, delHint);
  final DatanodeStorage storage = dn.getFSDataset().getStorage(storageUuid);

  // storage == null here because it's already removed earlier.

  for (BPServiceActor actor : bpServices) {
    actor.getIbrManager().notifyNamenodeBlock(info, storage,
        isOnTransientStorage);
  }
}

Another side, you mentioned that this issue is triggered by volume removed, so how the logic between volume removed to NPE. Thanks again.

@Hexiaoqiao Hi, sir. please take a look at the description of https://github.com/apache/hadoop/pull/6730 . I found the same problem and explained in that PR's description.

LGTM.
Hi @Hexiaoqiao @hfutatzhanghb any other comments?

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

_ Prechecks _

+1 :green_heart:
dupname
0m 02s

No case conflicting files found.

+0 :ok:
codespell
0m 02s

codespell was not available.

+0 :ok:
detsecrets
0m 02s

detect-secrets was not available.

+0 :ok:
markdownlint
0m 02s

markdownlint was not available.

+0 :ok:
spotbugs
0m 00s

spotbugs executables are not available.

+1 :green_heart:
@author
0m 01s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m 00s

The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
2m 14s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
86m 40s

trunk passed

+1 :green_heart:
compile
38m 18s

trunk passed

+1 :green_heart:
checkstyle
5m 51s

trunk passed

-1 :x:
mvnsite
4m 27s
/branch-mvnsite-hadoop-common-project_hadoop-common.txt
hadoop-common in trunk failed.

+1 :green_heart:
javadoc
10m 13s

trunk passed

+1 :green_heart:
shadedclient
157m 54s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
2m 16s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
9m 29s

the patch passed

+1 :green_heart:
compile
35m 37s

the patch passed

+1 :green_heart:
javac
35m 37s

the patch passed

+1 :green_heart:
blanks
0m 01s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
5m 50s

the patch passed

-1 :x:
mvnsite
4m 30s
/patch-mvnsite-hadoop-common-project_hadoop-common.txt
hadoop-common in the patch failed.

+1 :green_heart:
javadoc
10m 18s

the patch passed

+1 :green_heart:
shadedclient
167m 52s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
asflicense
5m 28s

The patch does not generate ASF License warnings.

512m 54s

Subsystem
Report/Notes

GITHUB PR
https://github.com/apache/hadoop/pull/6759

Optional Tests
dupname asflicense mvnsite codespell detsecrets markdownlint compile javac javadoc mvninstall unit shadedclient spotbugs checkstyle

uname
MINGW64_NT-10.0-17763 f9e61a0ebff0 3.4.10-87d57229.x86_64 2024-02-14 20:17 UTC x86_64 Msys

Build tool
maven

Personality
/c/hadoop/dev-support/bin/hadoop.sh

git revision
trunk / b42a03e1d18816a1bf2f65e82508800c8f885785

Default Java
Azul Systems, Inc.-1.8.0_332-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch-windows-10/job/PR-6759/6/testReport/

modules
C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch-windows-10/job/PR-6759/6/console

versions
git=2.44.0.windows.1

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

Merged. Thanks @kokonguyen191 for your contribution and thanks @Hexiaoqiao @haiyang1987 @hfutatzhanghb for your review.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

-1 :x:
patch
0m 55s

https://github.com/apache/hadoop/pull/6759 does not apply to trunk. Rebase required? Wrong Branch? See https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute for help.

Subsystem
Report/Notes

GITHUB PR
https://github.com/apache/hadoop/pull/6759

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch-windows-10/job/PR-6759/7/console

versions
git=2.44.0.windows.1

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.


feature: Adding support for GKE Autopilot

This is my first chart change, so getting a pull request out and see if we can get a build created. I'll get the details updated soon.

Is this a new chart
What this PR does / why we need it:
Which issue this PR fixes
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

fixes #

Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[ ] Chart Version bumped
[ ] Variables are documented in the README.md
[ ] Title of the PR starts with chart name (e.g. [mychartname])

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Hi! Support for GKE autopilot has been added through generic persistence configurations #1259
https://github.com/newrelic/helm-charts/blob/master/charts/newrelic-logging/README.md#gke-autopilot-example
Thanks!


feature(secureboot): Extend _secureboot feature with additional tools and config

How to categorize this PR?

/kind enhancement
/area os
/os garden-linux
What this PR does / why we need it:
This PR moves scripts, configuration and tools needed to enable secure boot for Garden Linux to the _secureboot feature
Which issue(s) this PR fixes:
Fixes #1107

/lgtm


Run-Time Check Failure #0 when using gRPC on C++

I'm trying to implement a simple server-client communication, but I get this error:
Run-Time Check Failure #0 - The value of ESP was not properly saved across a function call.  This is usually a result of calling a function declared with one calling convention with a function pointer declared with a different calling convention.
When running the client while the server is running. Here's the line that is causing the error:
auto* request = new (g_core_codegen_interface->grpc_call_arena_alloc(         call, sizeof(RequestType))) RequestType();
As I am understanding, the cause should be some kind of mismatch in the types of the caller and the called, am I right?
Here's the code of the .proto file:
service DataSourceSetter {
  rpc SetSystemReady (IntValue) returns (HelloReply) {}
}
message IntValue {
  int32 value = 1;
}
message HelloReply {
  string message = 1;
}

Here's the client implementation:
class DataSourceSetterClient {
public:
	DataSourceSetterClient(std::shared_ptr<Channel> channel)
		: stub_(DataSourceSetter::NewStub(channel)) {}

	std::string SetSystemReady(const std::int32_t& value) {
		IntValue valueCarrier;
		valueCarrier.set_value(value);

		HelloReply reply;

		ClientContext context;

		Status status = stub_->SetSystemReady(&context, valueCarrier, &reply);

		if (status.ok()) {
			return reply.message();
		}
		else {
			std::cout << status.error_code() << ": " << status.error_message()
				<< std::endl;
			return "RPC failed";
		}
	}

private:
	std::unique_ptr<DataSourceSetter::Stub> stub_;
};

int main(int argc, char** argv) {
	DataSourceSetterClient setter(grpc::CreateChannel("<IP_ADDRESS>:50051", grpc::InsecureChannelCredentials()));
	std::int32_t value = 1;
	std::string reply = setter.SetSystemReady(value);

	system("PAUSE");
	return 0;
}

And, finally, the server-side implementation:
class DataSourceSetterServiceImpl final : public DataSourceSetter::Service {
public:
	DataSourceSetterServiceImpl(KanziApplication *application)
		: mApplication(application)
	{
	}
	Status SetSystemReady(ServerContext* context, const IntValue* valueCarrier,
		HelloReply* reply) override {
		kzLogDebug(("RECEIVED client request, {}", valueCarrier->value()));

		mApplication->getSettingsModule().getDataSource()->getGeneral().getSystemReady().setValue(1);
		std::string prefix("SystemReady set to: {}", valueCarrier->value());
		reply->set_message(prefix);
		return Status::OK;
	}

private:
	KanziApplication* mApplication;
};

void KanziApplication::RunServer() {
	std::string server_address("<IP_ADDRESS>:50051");
	DataSourceSetterServiceImpl service(this);

	ServerBuilder builder;

	builder.AddListeningPort(server_address, grpc::InsecureServerCredentials());

	builder.RegisterService(&service);

	std::unique_ptr<Server> server(builder.BuildAndStart());
	kzLogDebug(("Server listening on {}", server_address));

	server->Wait();
}

Apart from the custom constructor, there are really few differences among this and the Helloworld example, but also by deleting the custom constructor just to print the received value, the error I get is the same.
EDIT: If it can be useful to know, the server in my implementation is running on a detached thread.
EDIT 2: also, when I run the modified HelloWorld example including the files generated by protoc, it works fine apart from the client, that outputs on screen only the first letter of the reply message.

I solved including grpc\testinstall\include that was missing, sorry for bothering

Closing because the user solved the issue.


File name unknown character/Issue with path.

Hello!
Getting an interesting issue with the file path for my files. I've successfully setup w/Docker compose.
The file is successfully created however at the end of the file path there is an unknown character proceeding the _
IE:  _1672627065.mp4
If I delete this  it successfully will show the link in the WebUI/Download but with that extra character it fails to display or download since I assume the paths don't match.
I am running this w/Docker Compose running on unRAID. Let me know if there are any additional logs etc I can provide as a bit new to this so unsure what is relevant. Thanks!

For some reason it just seemed to be those specific files I had been testing with, other files are working great.
Not sure why those are funky but not an open issue for me currently. Thanks


Improve Random module code coverage

Description:
As per codecov, coverage is now 64%, and need to increase to above 80%

Fix is already merged. Hence closing the issue


The FPS on jetson nano 4GB?

use resnet18_baseline_att_224x224_A_epoch_249.pth, the FPS is 10?
But

why?
Am I not freeing up some space, or is it something else?
Thanks!

You can try to run this project on "jetson_clocks"  mode, might help you improve the performance.


Task need a lifetime

Tasks need to be deleted after a certain timeframe. I would propose 30 days. We could set up a Kubernetes cron job to do this.

Duplicate of #36.


relax type constraints

I am not 100% sure this works,
we might need to add some convert into this if the Protobuf does not do that for us, as required.

Codecov Report

Merging #15 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master      #15   +/-   ##
=======================================
  Coverage   78.33%   78.33%
=======================================
  Files           9        9
  Lines         120      120
=======================================
  Hits           94       94
  Misses         26       26

Impacted Files
Coverage Δ

src/Loggers/LogHistograms.jl
100% <100%> (ø)
:arrow_up:

src/Loggers/LogValue.jl
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba3a4db...42be5d0. Read the comment docs.

Codecov Report

Merging #15 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master      #15   +/-   ##
=======================================
  Coverage   78.33%   78.33%
=======================================
  Files           9        9
  Lines         120      120
=======================================
  Hits           94       94
  Misses         26       26

Impacted Files
Coverage Δ

src/Loggers/LogHistograms.jl
100% <100%> (ø)
:arrow_up:

src/Loggers/LogValue.jl
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba3a4db...42be5d0. Read the comment docs.

The (autogenerated) Julia protobuffers already accept an AbstractString, so relaxing the name/tag should be fine.
We will still need to do some string sanitisation eventually (Tensorflow and TensorboardX do it).
The rest looks fine. Do you want to add something else or I can merge it?

You can merge


XAXIS not working with Timeline Series (timestamp)

I am trying with Google Analytics API to retrieve the data to post the Series data value as timestamp method.
Here I am getting very frustrated results in the chart. Even YAXIS is configured, this result showing in YAXIS after chart.updateSeries.

My returned array data from google appscript serverside. This is sample array of data and it seems same as in your example for timestamps series method.

I am digging into this problem last 3 days and never ending. I am not sure the array is correct that provided in the screen shot. I am trying to depict everyday session count in every minutes which come in realtime chart. Can you help for resolve this issue or any code you have suggest to accomplish this? XAxis daily minutes, Yaxis session value.

I have figured out this issue.


Issue I have

verytime i use gobuster it come up with this error:
2 errors occurred:
* WordList (-w): Must be specified (use -w - for stdin)
* Url/Domain (-u): Must be specified
this is the command im using:
gobuster dir -u http:// -w /usr/share/dict/README.select-wordlist
 has repleaced the ip in this case

You are most probably running an old version of gobuster. Please refer to the readme how to get a current version installed


docs: add @Nalin-kumar-gupta as a contributor

Hello,
I hope this message finds you well. My name is Nalin, and I’m currently a final-year BTech CSE undergraduate with a strong passion for contributing to impactful open-source projects like Springwolf.
I have been fortunate to receive recognition in national-level hackathons, including winning the Sparkathon, where I was honored to stand out among 14,000 participants. I’m writing not only with the hope of contributing to this wonderful project but also to connect with and learn from professionals in the industry. I am eager to seek guidance that could help me enhance my skills and better understand real-world systems.
While I haven’t had the chance to contribute directly to this repository yet, I am very keen to get involved. It would mean a lot to me if you could kindly suggest areas where I can start or tasks that need attention. Your guidance will be invaluable as I take my first steps in contributing to Springwolf.
I would be truly grateful if you could consider adding me as a contributor. I am excited about the opportunity to collaborate, learn, and grow within this incredible community.
Thank you so much for your time and for considering my request. I look forward to your response and hope to contribute meaningfully to this project.
Best regards,
Nalin Kumar Gupta
GitHub Username: [Nalin-kumar-gupta]
LinkedIn: https://www.linkedin.com/in/nalin-kumar-gupta-450a98270/

Hi @Nalin-kumar-gupta,
please take a look at the open issues for options ton contribute.
We will update the contributors as part of the releasing process.


feat: export default branch for orgs repos endpoint

🔗 Linked issue

❓ Type of change

[ ] 📖 Documentation (updates to the documentation, readme, or JSdoc annotations)
[ ] 🐞 Bug fix (a non-breaking change that fixes an issue)
[x] 👌 Enhancement (improving an existing functionality like performance)
[ ] ✨ New feature (a non-breaking change that adds functionality)
[ ] 🧹 Chore (updates to the build process or auxiliary tools and libraries)
[ ] ⚠ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Hello,
In the same way the default branch is exported for a single repo, having this info for all repos from an orgs could be useful.
related to UnJS Relations where I need to know the default branch when I fetch every repos from an organization
📝 Checklist

[ ] I have linked an issue or discussion.
[ ] I have updated the documentation accordingly.

Hey @pi0, do you this could be merged? 👀


#8 added learning resources for Cryptography

Added all valuable learning materials. ✅
🏆There are three chapters ppt and a readme which summarizes all the chapters.🏆
Description ⭐:
These chapters 📚 cover key concepts in cryptography and authentication. Authentication requirements include protecting messages from attacks like disclosure, masquerade, and replay 🔐. Techniques like Message Encryption, Message Authentication Codes (MACs), and Hash Functions are used to ensure data integrity and authenticity. Important algorithms such as MD5, SHA, and HMAC are discussed, providing secure message hashing and authentication 🔒. Digital Signatures ✍ and Authentication Protocols help secure communications, ensuring the message is untampered and from the correct sender. Key management and secure key exchanges like Diffie-Hellman are crucial, with real-world case studies illustrating these cryptographic methods 🌍.

Please add hacktoberfest-accepted tag so that my contribution will get counted in HacktoberFest 2024 🙏


New version: Catsxp.Catsxp version <IP_ADDRESS>

Created by 🥟 Dumplings in workflow run #8002.

Log
Updated: <IP_ADDRESS> → <IP_ADDRESS>
Submitting WinGet manifests
Creating manifests
Uploading manifests and making commits
The manifests for the last version <IP_ADDRESS> will be removed. Reason: This task is configured to remove the last version
Creating a pull request

Microsoft Reviewers: Open in CodeFlow

@wingetbot run


Allow notes to be added on the users page

Adds notes to the user page as requested in https://github.com/gardenshade/mam-plus/issues/48

This feature snuck in with the Newest Users Gift All PR


ionic updates

There was an error while validating job c86ca5d3-7847-4762-9ec2-c704686c76ed Message:
Result status: Failed
There was a problem accessing Github repository 'https://github.com/Microsoft/cordova-docs.git'.
Details:Microsoft.LightweightJobEngine.Core.Language.ContextCommandBase+ContextCommandException:
Result status: Failed
There was a problem accessing Github repository 'https://github.com/Microsoft/cordova-docs.git'.
---> System.AggregateException: One or more errors occurred. ---> System.ArgumentException: Error clonning repository ---> LibGit2Sharp.NotFoundException: Branch 328 not found. Available branches: origin/master
at Microsoft.DPS.Services.LibGit2SharpSourceControlProvider.GetBranch(Repository repo, String name)
at Microsoft.DPS.Services.LibGit2SharpSourceControlProvider.<>c__DisplayClass30.<>c__DisplayClass34.b__29(KeyValuePair2 branch)    at System.Collections.Generic.List1.ForEach(Action1 action)    at Microsoft.DPS.Services.LibGit2SharpSourceControlProvider.<>c__DisplayClass30.<CloneRepository>b__28()    at Microsoft.Practices.EnterpriseLibrary.TransientFaultHandling.RetryPolicy.<>c__DisplayClass1.<ExecuteAction>b__0()    at Microsoft.Practices.EnterpriseLibrary.TransientFaultHandling.RetryPolicy.ExecuteAction[TResult](Func1 func)
at Microsoft.Practices.EnterpriseLibrary.TransientFaultHandling.RetryPolicy.ExecuteAction(Action action)
at Microsoft.DPS.Services.LibGit2SharpSourceControlProvider.CloneRepository(String url, IDictionary2 branches)    --- End of inner exception stack trace ---    at Microsoft.DPS.Services.LibGit2SharpSourceControlProvider.CloneRepository(String url, IDictionary2 branches)
at Microsoft.DPS.Services.LibGit2SharpSourceControlProvider.CloneRepository()
at Microsoft.DPS.Services.LibGit2SharpSourceControlProvider.GetVersionAsync(String path)
at Microsoft.DPS.Commands.IdentifyDocumentsToPublish.CheckExternalServicesCommand.Do(IDictionary2 context)    --- End of inner exception stack trace ---    --- End of inner exception stack trace ---    at Microsoft.LightweightJobEngine.Core.Language.ContextCommandBase.ThrowIfErrorsLogged()    at Microsoft.DPS.Commands.IdentifyDocumentsToPublish.CheckExternalServicesCommand.Do(IDictionary2 context)
at Microsoft.LightweightJobEngine.Core.Language.JobWorkflow1.RunCommands(Guid jobId, IDictionary2 context, CancellationTokenSource cancelSignal)


Add ayaco

Hey, thank you for your profile! I think it's just a case of a translations from Japanese to English — but I think it would be a great idea to change "businessman" to "businesswoman" in your profile :)

Thank you for your advice !
I will change it in a few days.


Feature/2002 reshape test

Add 4 pytests for module, moving_averages, and reshape.

Sorry for the delay here, I didn't get a chance to setup CI today, I will try and find time this weekend or first thing next week!

Hey, some stuff is triggering Lint errors:

module_test.py: use " instead of ' for strings
moving_averages_test.py: indent continuation lines by 4 spaces, not 2

@tomhennigan: we should expose a pylintrc for external contributors to use so we don't need to check this internally.

Otherwise, changes look great, thanks for contributing :)

@trevorcai Thank you!
Would you mind if tell me your lint style?
Is it the same with the one of Tensorflow?
https://www.tensorflow.org/community/contribute/code_style

Tiny nit-pick: try to keep commit messages descriptive of the changes and in case of feedback changes consider amending & force-pushing instead. It's a non-issue since the maintainer can just squash individual commits before merging, but maybe one less thing to worry about.


Grab umask for gather-logs

Signed-off-by: Sean Horn<EMAIL_ADDRESS>

@sean-horn That's an interesting thing to look at -- was this caused by any specific issue you've seen in the wild? I'm asking because alternatively, we could also explicitly set umask where we care for it; and I'm not certain I could say where that is.
(Also, could you sign-off your commit?

Wait, you have signed-off, but in a format the bot doesn't understand.
You've probably got some script in place to add this? Could you ensure it adds this instead?
Signed-off-by: Sean Horn<EMAIL_ADDRESS>

Also, nevermind, I've found the conversation in slack (https://chefio.slack.com/archives/C07JP2K7F/p1490221271817062)

Replaced by #1266 which rebases and corrects the format of the DCO sign-off.


Logic & UI: Command validation

This PR introduces a new feature which parses input from the command box and updates its style as the user types. This provides a constant feedback to the user, letting him know whether his command is valid or not.
Together with #32, users can ensure they are on the right track when typing difficult commands such as add or edit.
Resolves #27

Changes Unknown when pulling 42b9a11b3b762e3aa89a54320450e0142e5f4ee6 on goweiwen:command-validation into ** on CS2103AUG2017-W11-B4:master**.

Coverage increased (+0.06%) to 89.645% when pulling 42b9a11b3b762e3aa89a54320450e0142e5f4ee6 on goweiwen:command-validation into cff3f7333c8fc148e35f595fd6b1b1edf737fefc on CS2103AUG2017-W11-B4:master.

Coverage increased (+0.06%) to 89.645% when pulling 36cf96f986c44e34dcb750902690218e4740eb03 on goweiwen:command-validation into f9abbb0cde52f17edb7ea9d5c9808a46515cb2fd on CS2103AUG2017-W11-B4:master.


Error starting node service

While trying to start node I get this error:
            throw e; // process.nextTick error, or 'error' event on first tick
                  ^
    Error: ENOENT, no such file or directory '/home/node/node-service/releases/2012-02-16T01-29-32.435587420/node_modules/express/node_modules/mime/types/mime.types'
        at Object.openSync (fs.js:230:18)
        at Object.readFileSync (fs.js:120:15)
        at Object.load (/home/node/node-service/releases/2012-02-16T01-29-32.435587420/node_modules/express/node_modules/mime/mime.js:46:22)
        at Object.<anonymous> (/home/node/node-service/releases/2012-02-16T01-29-32.435587420/node_modules/express/node_modules/mime/mime.js:86:6)
        at Module._compile (module.js:441:26)
        at Object..js (module.js:459:10)
        at Module.load (module.js:348:31)
        at Function._load (module.js:308:12)
        at Module.require (module.js:354:17)
        at require (module.js:370:17)

Any help?

I've never had this, the stack trace explains what's going on but I can't investigate it unless I can reproduce it. Just looks like the mime dep is not installed correctly

Checking it further, it's a problem with node-jscoverage in no.de . I never had this problem before. It sprung out recently.

ah I see, unrelated then