Unable to focus() an input field that is shown on update()

I would like to make an editable element, where pressing an edit button replaces the element with a form allowing to modify its contents. My problem is that I cannot focus() the first element of the form because it has to be done after the DOM has updated and there is no lifecycle event that fires after each element is updated.
Below is a riot-tag that reproduces the problem. If I call this.update() before calling this.summary.focus() it works, but then the update-event is fired twice.
Would it be an idea to add a post-render event, or is there some more riot-ish way to implement this?
<editablething>

        Click to edit

{summaryText}

        <form method="POST">
	        <textarea name="summary">{summaryText}</textarea>
        </form>

</editablething>

...and thank you all for a wonderful framework!
UPDATE: fixed some broken markup.

Try this:
<editablething>

        Click to edit

{summaryText}

        <form method="POST">
            <textarea name="summary">{summaryText}</textarea>
        </form>

</editablething>

This issue is not specific to riot, I've always handled it with setTimout
window.setTimeout(function(){this.summary.focus();},1);

might be a hack, but it's never failed me

I've found some hack in ES7 riot-isomorphic repo - https://github.com/ListnPlay/riot-isomorphic/blob/master/src/client/index.js the gulpfile there is also able to parse  tag inside riot tags and concat them to one file that is also usable for isomorphic riot usage.

Thanks for the tips! The 'updated' event AndreasHeintze describes is exactly what I was looking for. Case closed from my point of view.


feat: add new option for set http module as global module

PR Checklist
Please check if your PR fulfills the following requirements:

[ ] The commit message follows our guidelines: https://github.com/nestjs/nest/blob/master/CONTRIBUTING.md
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

PR Type
What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A
What is the new behavior?
add new option for set axios as global module
Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

we should expose a .forRoot/.forRootAsync static method instead of changing the .register. See https://docs.nestjs.com/fundamentals/dynamic-modules#community-guidelines

yeah, I think so. But global must be true
and a .forRootAsync as well

ok, I has changed

https://github.com/nestjs/axios/commit/ada86635670989b357f1910b48a8f9e4b0003fd7


Need example of using remote API for suggestion population

Component looks great. Seems like the most-used case for suggestions population is from a remote API. Can you provide an example of that?

Thanks for your feedback.
Actually, the suggestion list is fully controlled by you. renderSuggestions in the readme is just example. You can pass there any class/functional component you prefer with any kind of suggestion list (either locally hardcoded or provided from store).

Thanks for your feedback.
Actually, the suggestion list is fully controlled by you. renderSuggestions in the readme is just example. You can pass there any class/functional component you prefer with any kind of suggestion list (either locally hardcoded or provided from store).

@ScottWallace Sharing how I made it work:
RenderSuggestion:
  const renderUserSuggestions = ({ keyword, onSuggestionPress }) => {
    if (keyword == null) {
      return null;
    }

    // This updates the state of the keyword and fires off the search to remote DB
    debouncedSearch(keyword);

    if (fetching || data == undefined) {
      return (
        <View style={{ padding: 12 }}>
          <Loader />
        </View>
      );
    }
      <View
        style={{
          overflow: "visible",
          backgroundColor: "transparent",
        }}
      >
        {data.search_user_mentions.map((user, index) => {
      <Your custom component showing each result>
        })}
      </View>
    );
  };

Debounce function:
  const debouncedSearch = useCallback(
    debounce((keyword) => {
      setPauseQuery(false);
      setSearchText(keyword);
    }, 500),
    []
  );

And I use graphQL with URQL, so this will depend how you want to handle it but the debounceSearch inserts the keyword into state so whatever remote DB API you are using should be firing off at this point:
  const [searchText, setSearchText] = useState("");
  const [pauseQuery, setPauseQuery] = useState(true);

  const [result, reexecuteQuery] = useQuery({
    query: SEARCH_USER_MENTIONS,
    variables: {
      search: searchText,
    },
    pause: pauseQuery,
  });
  const { data, error, fetching } = result;

It is probably not perfect but might help you a bit on the way to make this work with a remote DB solution.

@ScottWallace Sharing how I made it work:
RenderSuggestion:
  const renderUserSuggestions = ({ keyword, onSuggestionPress }) => {
    if (keyword == null) {
      return null;
    }

    // This updates the state of the keyword and fires off the search to remote DB
    debouncedSearch(keyword);

    if (fetching || data == undefined) {
      return (
        <View style={{ padding: 12 }}>
          <Loader />
        </View>
      );
    }
      <View
        style={{
          overflow: "visible",
          backgroundColor: "transparent",
        }}
      >
        {data.search_user_mentions.map((user, index) => {
      <Your custom component showing each result>
        })}
      </View>
    );
  };

Debounce function:
  const debouncedSearch = useCallback(
    debounce((keyword) => {
      setPauseQuery(false);
      setSearchText(keyword);
    }, 500),
    []
  );

And I use graphQL with URQL, so this will depend how you want to handle it but the debounceSearch inserts the keyword into state so whatever remote DB API you are using should be firing off at this point:
  const [searchText, setSearchText] = useState("");
  const [pauseQuery, setPauseQuery] = useState(true);

  const [result, reexecuteQuery] = useQuery({
    query: SEARCH_USER_MENTIONS,
    variables: {
      search: searchText,
    },
    pause: pauseQuery,
  });
  const { data, error, fetching } = result;

It is probably not perfect but might help you a bit on the way to make this work with a remote DB solution.

@Svarto, perfect, very helpful, thanks!

@Svarto, perfect, very helpful, thanks!

The question seems to be over. Closing issue.

The question seems to be over. Closing issue.


Create the landing page after authentication

The screenshot of the design from Figma has been attached, which includes all the necessary sections, typography, and color palette for both the modes. Build the landing page as a React component(s). Use Tailwind CSS for responsive styling based on the design. Ensure that the page is fully responsive and works seamlessly on desktop, tablet, and mobile devices. Try to stick to the design you can make minor changes according to you like Implement any subtle hover effects or animations.

hey @Ashmit-Verma can you assign this to me?

hey @Ashmit-Verma can you assign this to me?

assigned to you @laladwesh

hii @Ashmit-Verma , I would like to create this landing page, can you assign this to me?


Issue with loading BLST Library

Hi,
I am unable to run the eth2 signing. I am using a rasperry pi.
here is the output:
bin/web3signer eth2 --keystores-path=$PATH --keystores-password-file=$FILE --slashing-protection-db-url="jdbc:postgresql://localhost/web3signer" --slashing-protection-db-username=postgres --slashing-protection-db-password=password --slashing-protection-pruning-enabled=true
2023-05-26 22:34:36.654+01:00 | main | INFO  | Web3SignerApp | Web3Signer has started with args eth2,--keystores-path=$PATH,--keystores-password-file=$FILE,--slashing-protection-db-url=jdbc:postgresql://localhost/web3signer,--slashing-protection-db-username=postgres,--slashing-protection-db-password=password,--slashing-protection-pruning-enabled=true
2023-05-26 22:34:36.919+01:00 | main | INFO  | Web3SignerApp | Version = web3signer/v23.3.1/linux-arm_32/-raspbian-openjdkservervm-java-11
2023-05-26 22:34:42.196+01:00 | main | INFO  | Eth2SubCommand | Network: mainnet
Spec Name: PHASE0, Fork Epoch: 0, First Slot: 0
Spec Name: ALTAIR, Fork Epoch: 74240, First Slot: 2375680
Spec Name: BELLATRIX, Fork Epoch: 144896, First Slot: 4636672
Spec Name: CAPELLA, Fork Epoch: 194048, First Slot: 6209536

2023-05-26 22:34:42.340+01:00 | main | INFO  | HikariDataSource | HikariPool-1 - Starting...
2023-05-26 22:34:43.064+01:00 | main | INFO  | HikariPool | HikariPool-1 - Added connection org.postgresql.jdbc.PgConnection@1c713c9
2023-05-26 22:34:43.082+01:00 | main | INFO  | HikariDataSource | HikariPool-1 - Start completed.
2023-05-26 22:34:44.285+01:00 | main | INFO  | HikariDataSource | HikariPool-2 - Starting...
2023-05-26 22:34:44.352+01:00 | main | INFO  | HikariPool | HikariPool-2 - Added connection org.postgresql.jdbc.PgConnection@90b1a6
2023-05-26 22:34:44.354+01:00 | main | INFO  | HikariDataSource | HikariPool-2 - Start completed.
2023-05-26 22:34:45.710+01:00 | pool-2-thread-1 | INFO  | SignerLoader | Loading signer configuration metadata files from .
2023-05-26 22:34:45.746+01:00 | pool-2-thread-1 | INFO  | SignerLoader | Signer configuration metadata files read in memory 0 in 00:00:00.024
2023-05-26 22:34:45.756+01:00 | ForkJoinPool-1-worker-3 | INFO  | SignerLoader | Parsing configuration metadata files
2023-05-26 22:34:45.762+01:00 | ForkJoinPool-1-worker-3 | INFO  | SignerLoader | Total configuration metadata files processed: 0
2023-05-26 22:34:45.763+01:00 | ForkJoinPool-1-worker-3 | INFO  | SignerLoader | Total signers loaded from configuration files: 0 in 00:00:00.005 with error count 0
2023-05-26 22:34:45.787+01:00 | pool-2-thread-1 | INFO  | Eth2Runner | Bulk loading keys from local keystores ...
2023-05-26 22:34:53.282+01:00 | pool-2-thread-1 | INFO  | teku-status-log | Using portable BLST library.
2023-05-26 22:34:53.331+01:00 | pool-2-thread-1 | ERROR | BlstLoader | Couldn't load native BLS library
java.lang.ExceptionInInitializerError: null

thanks

Hi @riordant - which raspberry pi are you using exactly?
Have you got more logs that show more of the error?

Hi,
It's a Raspberry Pi 4 Model B, running Raspberry Pi OS. These are the only logs that are relevant.
It is ARM based. Is that an issue?

It could be an issue. The native library we use for BLS might not support that ARM architecture. If we don't support architecture then we should fall back to Java but looks like that might not be happening. But will be slower if it doesn't use the native library.
In any case, we will test this out on a Raspberry Pi 4.

Awesome, thanks.

Tested against Raspberry Pi 3 Model B v1.2 with 64 bit Raspberry PI OS
uname -a
Linux raspberrypi 6.1.21-v8+ #1642 SMP PREEMPT Mon Apr  3 17:24:16 BST 2023 aarch64 GNU/Linux

Web3Signer is able to load native BLST library successfully:
usman@raspberrypi:~/web3signer-23.3.1/bin $ ./web3signer --config-file /home/usman/config/config.yaml eth2
2023-06-08 12:02:23.363+10:00 | main | INFO  | Web3SignerApp | Web3Signer has started with args --config-file,/home/usman/config/config.yaml,eth2
2023-06-08 12:02:23.680+10:00 | main | INFO  | Web3SignerApp | Version = web3signer/v23.3.1/linux-aarch_64/-eclipseadoptium-openjdk64bitservervm-java-11
2023-06-08 12:02:32.392+10:00 | main | INFO  | Eth2SubCommand | Network: mainnet
Spec Name: PHASE0, Fork Epoch: 0, First Slot: 0
Spec Name: ALTAIR, Fork Epoch: 74240, First Slot: 2375680
Spec Name: BELLATRIX, Fork Epoch: 144896, First Slot: 4636672
Spec Name: CAPELLA, Fork Epoch: 194048, First Slot: 6209536

2023-06-08 12:02:34.429+10:00 | pool-2-thread-1 | INFO  | SignerLoader | Loading signer configuration metadata files from /home/usman/config/keys
2023-06-08 12:02:34.487+10:00 | pool-2-thread-1 | INFO  | SignerLoader | Signer configuration metadata files read in memory 1 in 00:00:00.047
2023-06-08 12:02:34.513+10:00 | ForkJoinPool-1-worker-3 | INFO  | SignerLoader | Parsing configuration metadata files
2023-06-08 12:02:35.130+10:00 | ForkJoinPool-1-worker-3 | INFO  | teku-status-log | Using portable BLST library.
2023-06-08 12:02:35.238+10:00 | ForkJoinPool-1-worker-3 | INFO  | BLS | BLS: loaded BLST library
2023-06-08 12:02:35.277+10:00 | ForkJoinPool-1-worker-3 | INFO  | SignerLoader | Total configuration metadata files processed: 1
2023-06-08 12:02:35.279+10:00 | ForkJoinPool-1-worker-3 | INFO  | SignerLoader | Total signers loaded from configuration files: 1 in 00:00:00.760 with error count 0
2023-06-08 12:02:35.315+10:00 | pool-2-thread-1 | INFO  | DefaultArtifactSignerProvider | Total signers (keys) currently loaded in memory: 1
2023-06-08 12:02:41.804+10:00 | main | INFO  | Runner | Web3Signer has started with TLS disabled, and ready to handle signing requests on <IP_ADDRESS>:9000

Tested against Raspberry Pi 3 Model B v1.2 with 32 bit Raspberry PI OS
The native BLST library (provided via Teku libraries) fails to load native implementation and raises an exception instead of reverting back to non-native implementation. This results in failure to load the private key. However, web3signer still starts.
./web3signer --config-file /home/usman/config/config.yaml eth2
2023-06-08 12:49:55.709+10:00 | main | INFO  | Web3SignerApp | Web3Signer has started with args --config-file,/home/usman/config/config.yaml,eth2
2023-06-08 12:49:55.865+10:00 | main | INFO  | Web3SignerApp | Version = web3signer/v23.3.1/linux-arm_32/zulu-java-11
2023-06-08 12:50:02.374+10:00 | main | INFO  | Eth2SubCommand | Network: mainnet
Spec Name: PHASE0, Fork Epoch: 0, First Slot: 0
Spec Name: ALTAIR, Fork Epoch: 74240, First Slot: 2375680
Spec Name: BELLATRIX, Fork Epoch: 144896, First Slot: 4636672
Spec Name: CAPELLA, Fork Epoch: 194048, First Slot: 6209536

2023-06-08 12:50:03.909+10:00 | pool-2-thread-1 | INFO  | SignerLoader | Loading signer configuration metadata files from /home/usman/config/keys
2023-06-08 12:50:03.946+10:00 | pool-2-thread-1 | INFO  | SignerLoader | Signer configuration metadata files read in memory 1 in 00:00:00.027
2023-06-08 12:50:03.961+10:00 | ForkJoinPool-1-worker-3 | INFO  | SignerLoader | Parsing configuration metadata files
2023-06-08 12:50:04.451+10:00 | ForkJoinPool-1-worker-3 | INFO  | teku-status-log | Using portable BLST library.
2023-06-08 12:50:04.484+10:00 | ForkJoinPool-1-worker-3 | ERROR | BlstLoader | Couldn't load native BLS library
java.lang.ExceptionInInitializerError: null
	at java.lang.Class.forName0(Native Method) ~[?:?]
	at java.lang.Class.forName(Class.java:315) ~[?:?]
	at tech.pegasys.teku.bls.impl.blst.BlstLoader.loadBlst(BlstLoader.java:49) ~[bls-23.3.1.jar:23.3.1]
	at tech.pegasys.teku.bls.impl.blst.BlstLoader.<clinit>(BlstLoader.java:38) ~[bls-23.3.1.jar:23.3.1]
	at tech.pegasys.teku.bls.BLS.resetBlsImplementation(BLS.java:56) ~[bls-23.3.1.jar:23.3.1]
	at tech.pegasys.teku.bls.BLS.<clinit>(BLS.java:48) ~[bls-23.3.1.jar:23.3.1]
	at tech.pegasys.teku.bls.BLSSecretKey.fromBytes(BLSSecretKey.java:38) ~[bls-23.3.1.jar:23.3.1]
	at tech.pegasys.web3signer.signing.config.metadata.BlsArtifactSignerFactory.create(BlsArtifactSignerFactory.java:71) ~[web3signer-signing-23.3.1.jar:23.3.1]
	at tech.pegasys.web3signer.signing.config.metadata.FileRawSigningMetadata.createSigner(FileRawSigningMetadata.java:34) ~[web3signer-signing-23.3.1.jar:23.3.1]

Caused by: java.lang.ExceptionInInitializerError
	at tech.pegasys.teku.bls.BLSSecretKey.fromBytes(BLSSecretKey.java:38) ~[bls-23.3.1.jar:23.3.1]
	at tech.pegasys.web3signer.signing.config.metadata.BlsArtifactSignerFactory.create(BlsArtifactSignerFactory.java:71) ~[web3signer-signing-23.3.1.jar:23.3.1]
	at tech.pegasys.web3signer.signing.config.metadata.FileRawSigningMetadata.createSigner(FileRawSigningMetadata.java:34) ~[web3signer-signing-23.3.1.jar:23.3.1]

2023-06-08 12:50:04.576+10:00 | pool-2-thread-1 | WARN  | Eth2Runner | No BLS keys loaded. Check that the key store has BLS key config files
2023-06-08 12:50:04.583+10:00 | pool-2-thread-1 | INFO  | DefaultArtifactSignerProvider | Total signers (keys) currently loaded in memory: 0
2023-06-08 12:50:08.694+10:00 | main | INFO  | Runner | Web3Signer has started with TLS disabled, and ready to handle signing requests on <IP_ADDRESS>:9000

@riordant kindly have a look at above analysis. You may have to use 64 bit OS on your Raspberry PI instance.

@riordant if you want to use Raspberry OS 32 bit, you have to rebuilt jblst jar on your Raspberry PI and replace the bundled jblst jar with it. Here are the instructions that I've followed: https://gist.github.com/usmansaleem/650813a81c41298e6b6f45137ef133cd


Remove testWithTableScan flag in testAggregations

TableScan doesn't change the order of inputs, so it shouldn't really
matter whether data comes from Values or TableScan, it is nice to
remove this flag.
However, AggregationTestBase::testReadFromFiles
method splits and writes the input vectors into two files. This process,
to some extent, involves shuffling of the inputs. Consequently, it causes
certain aggregate function tests, such as ArbitraryTest, to fail.
We can utilize the allowInputShuffle_ flag. When set to true, we can avoid
splitting the inputs and instead write them into a single file. Also, we need
to disable TableScan testing when input contains timestamps type, to avoid
the issue described in #8127.

@mbasmanova Hi Masha, this PR is to remove the testWithTableScan flag according to our discussion in #8890, could you please help to take a look? Thanks a lot.

@duanmeng testReadFromFiles is mainly for testing string lifecycle bug (see https://github.com/facebookincubator/velox/pull/5605).  Reading from file allow us to destroy the original vector while the result in accumulator is still alive, this is not possible with values node.  I think the coverage of testReadFromFiles is worth keeping.

@duanmeng testReadFromFiles is mainly for testing string lifecycle bug (see #5605). Reading from file allow us to destroy the original vector while the result in accumulator is still alive, this is not possible with values node. I think the coverage of testReadFromFiles is worth keeping, as it mimics better the process in a real query.

@Yuhta Hi Jimmy, thanks for your review. This PR doesn't eliminate the coverage for testReadFromFiles. Instead, it aims to test with table scan wherever feasible. It also reuses the allowInputShuffle_ flag to decide to use a single file or two files, in both cases it would test with a table scan.
In #5606, ApproxMostFrequentTest calls allowInputShuffle() in the SetUp method, so the allowInputShuffle_ is true and the testReadFromFiles would spilt input into two files and scan as before.

@duanmeng Thanks for the explanation, so we are increasing the coverage instead of decreasing, that's good.


Bump Configuration Cache report to 1.3

Migrates the Configuration Cache web report to version 1.3 that contains various styling fixes.

I manually validated that the CC reports produced by Gradle distro from this branch have expected styling (mainly, a larger font for the inline code):

@bot-gradle test and merge

Your PR is queued. See the queue page for details.

I've triggered a build for you. Click here to see all failures if there's any.


[Feature]: Different users collaboration feature or tool.

Description
I would like to add  a feature where different users can collaborate with each other through gmail or slack or can hold meetings.
Why implement this feature?
This will enhance community collaboration and similar type interest userswill be able to interact with each other.
Any additional information?
Please assign me this issue under GSSoC'24
Checklist

[X] I have checked the existing issues and made sure that this is not a duplicate feature request form.

do we really need this feature? I don't think  currently we need this feature.


Field Filter Values on Create not working

Hi,
First of all, thanks for providing this PCF control.
I'm using the latest version v<IP_ADDRESS>.
I have a scenario where I need to use additional field filters so I've followed the documentation and added {1} {2} ... and provided the field names in the Field Filter Values (comma separated).
The problem is that on Create of a record (create form), it tries to filter the lookup, but since it is on Create (the record hasn't been saved yet), there's no GUID/id/PK yet for the PCF to query the value of the Field Filter Values to plug in the main $filter, and so it throws an error in the console.
this._entityRecordId is undefined at:
https://github.com/victorsolaya/Multiselect_Records_PCF/blob/5ddbcdb2f7d330956772ccd3738c0222cd9f01b4/MultiselectRecordsEntity/index.ts#L172
It works fine on the Update/Edit form, of course.
Can you please advise?
Thanks!

@victorsolaya , FYI...

Hi, you would need to perform something like a first save and then work with that.


404

🌟 Feature Request
📝 Description
Provide a clear and concise description of the feature you'd like to see.
🤔 Rationale
Explain why this feature is important and how it benefits the project.
📋 Additional Context
Add any other context or information about the feature request here.

You have opened an issue with a simple 3-character title, without any explanation (e.g. where the 404 page is located). This is a waste of everyone's time.
You should, as requested by the issue template:
Provide a clear and concise description of the feature you'd like to see.
Explain why this feature is important and how it benefits the project.
Add any other context or information about the feature request here.


Review and update cargo dependencies

serde v1.0.188
serde_bytes v0.11.12
serde_derive v1.0.188

Dependencies are up to date.


userError: The model Action defined a primary key of id that has an invalid type. Valid primary key types are number and string

Waterline version:  "waterline": "^0.13.5",
Node version: 10.7.0
NPM version: 6.1.0
Operating system: Ubuntu 18.x

I have read through the issue and have tried adding autoPK: true but seems like I am unable to use it. https://github.com/balderdashy/waterline/issues/301 It fails asking for Primary key to be defined.
Error when no Primary key is defined.
model = { identity: 'def', datastore: 'recMongo', schema: true, tableName: 'def', autoPK: true, attributes: {...} };

{ userError: Could not find a primary key attribute on the model Action. All models must contain an attribute that acts as the primary key and is guaranteed to be unique.
Error when Primary Key is defined.
model = { identity: 'def', datastore: 'recMongo', schema: true, tableName: 'def', autoPK: false, primaryKey: 'id', attributes: {"id": {
      "type": "string",
      "required": true,
      "index": true,
      "unique": true,
     "primaryKey": true
    }, ...} };

userError: The model 'Action' defined a primary key of 'id' that has an invalid type. Valid primary key types are 'number' and 'string'
Both way this fails. I am using sails-mongo as the adapter.

It works with the following config since schema is false (primaryKey is defined in extend configs and model attrs). But it is necessitating me to do validation of absence of other model attrs. autoPK for sails-mongo is not being picked up as a valid option, I am forced to specify an primaryKey as _id and the create a model with _id. Help requested, and any help is welcome to get autoPK:true working with schema:true. :
const Waterline = require('waterline');
let waterline = new Waterline();
const datastores = {
    "recAuth": {
        "adapter": "mongodb",
        "url": "mongodb://localhost:27017/recAuth"
    }
};
const adapters = {
    'mongodb': require('sails-mongo')
};
waterline.registerModel(Waterline.Collection.extend({
    identity: 'def',
    datastore: 'recAuth',
    schema: false,
    tableName: 'def',
    autoPK: true,
    primaryKey: '_id',
    attributes: {
        "_id": {
            "type": "string"
        },
        "str": {
            "type": "string",
            "required": true
        }
    }
}));

function x(waterline) {
    let pr = new Promise(function (resolve, reject) {
        let model, modelFns;
        waterline.initialize({
            adapters: adapters,
            datastores: datastores
        }, (err, orm) => {
            if (err) reject(err);
            resolve(orm);
        });
    })
    return pr;
}

async function getOrm(waterline) {
    let orm = await x(waterline);
    return orm;
}

sorm = await getOrm(waterline);
let res = await sorm.collections.def.create({str: 'test'}).fetch();
console.log(res);
let result = await sorm.collections.def.find({});
console.log(result);

@ganeshkbhat looks like you're using Waterline standalone, but if you have a chance would you try reproducing this in a new Sails app and link to the repo? (Might help us better understand what's going on)


Code Cleanup

This PR proposes several changes to improve repository organization and improve code sharing:

Use black

b12a0ff, run black in the python interpreter to update all files
c294893, add a code style badge to the readme
d4450a9, add a GitHub workflow to run an automated action

Add issue templates with 8b25d27 to promote high quality issues
Other changes:

5b3f96b, updated the readme, including changes to close #12
f0d956a, trimmed trailing spaces from the YAML files
33018ab, updated .gitignore

Hey @mikerahk, this looks great! Just checking on whether its still a draft or ready for merging?

Hey @mikerahk, this looks great! Just checking on whether its still a draft or ready for merging?

There is an issue with the workflow that I still need to resolve but I haven't had the cycles to figure that out yet. I'll also need to merge in the existing changes from master to resolve conflicts, but that isn't a big deal.


Bug fix udtf core dump use as normal function

Proposed changes
1. select my_udtf(1) will be coredump as it's can't execute like a normal function, must use with lateral view2.
2. when drop a UDTF function, it's should remove two function, another is utdf_outer function.


fix some AVS 2021-06-01 list examples

A few of the list examples were missing the "value": []. This was fixed in the next API version and I am backporting it before we publish the updated docs. There are no spec changes.
MSFT employees can try out our new experience at OpenAPI Hub  - one location for using our validation tools and finding your workflow.

Changelog
Please ensure to add changelog with this PR by answering the following questions.

What's the purpose of the update?

[ ] new service onboarding
[ ] new API version
[ ] update existing version for new feature
[ ] update existing version to fix swagger quality issue in s360
[x] Other, please clarify

When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
If it's an update to existing version,  please select SDKs of specific language and CLIs that require refresh after swagger is published.

[ ] SDK of .NET (need service team to ensure code readiness)
[ ] SDK of Python
[ ] SDK of Java
[ ] SDK of Js
[ ] SDK of Go
[ ] PowerShell
[ ] CLI
[ ] Terraform
[x] No, no need to refresh for updates in this PR

Contribution checklist:

[x] I commit to follow the Breaking Change Policy of "no breaking changes"
[x] I have reviewed the documentation for the workflow.
[x] Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist

[ ] Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

Adding new API(s)
Adding a new API version
[ ] Ensure to copy the existing version into new directory structure for first commit (including refactoring) and then push new changes including version updates in separate commits. This is required to review the changes efficiently.
Adding a new service

[ ] Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board. It is easy to review if you hide the whitespace changes.

[ ] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.

[ ] Removing API(s) in stable version
[ ] Removing properties in stable version
[ ] Removing API version(s) in stable version
[ ] Updating API in stable or public preview version with Breaking Change Validation errors
[ ] Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.

There are no breaking changes here. It is just fixing examples.


Enable Intercom for anonymous users

This removes the check in the code that limits the Intercom widget to authenticated users. I'm not sure why the check was there: Intercom is intended for use with both anonymous and authenticated users.
This also updates the Intercom tests to add a conventional test_render_internal_ip.

(The CI failure is unrelated: see #131.)

@jcassee Can you review this change to see whether it makes sense? It looks plausible to me, but I fear I know too little of the module's history to not overlook an improper change.

The change looks good to me. The user was not used, probably expected to pass it to Intercom in some way but never did. I'll test and merge after #131 is merged. Thanks, Pi!

@pjdelport Could you rebase this PR? It will rerun the tests. (I don't think I can do it, because the PR is coming from your account.)
Also: I can squash a PR merge on my end. Sorry for making you jump through unnecessary hoops! :cry:

Cool, rebased.

(Regarding the squashing, I'm still not sure how it helps: For anything but trivial one-commit changes, squashing only seems to obscure which commit messages go with which changes. Without squashing, all the commits that logically go together are still clearly grouped together in the branch / PR. But, it's not my repo, so I'm happy to go with whatever the maintainer preference is. :) )

I agree, but only if the commits follow a rational set of changes. I'm not a fan of "this happened and then that happened and then that also happened, [...]". :-)
Anyway, merging!

Cool, thanks. :)
(The drop in the coverage report seems to be spurious, for the record: comparing the branch and  main coverage, there's no actual change in the two uncovered lines.)

Thanks for the fix. I was just looking into this.


Block should work inside LazyBlock

Previously we were locking down the state even when calling layout in
LazyBlock. Now we lock only when building children. Making this work well
involved moving the catch out of lockState and into the few callers who
actually wanted it.
Fixes #3534


MB-7358 Add orders details for Services Counselor

This adds the Orders details definition list to the Services Counseling
view. A Services Counselor needs less info than a TOO, so I duplicated
the OrdersList that we use on the TOO's view, and removed the info
that a Services Counselor does not need to see.
I also added the View and edit orders button, but it doesn't do
anything currently, as that will be implemented in a separate story.
Description
Explain a little about the changes at a high level.
Reviewer Notes
Is there anything you would like reviewers to give additional scrutiny?
Setup
Add any steps or code to run in this section to help others prepare to run your code:
echo "Code goes here"

Code Review Verification Steps

[ ] If the change is risky, it has been tested in experimental before merging.
[ ] Code follows the guidelines for Logging
[ ] The requirements listed in Querying the Database Safely have been satisfied.
Any new migrations/schema changes:

[ ] Follow our guidelines for zero-downtime deploys (see Zero-Downtime Deploys)
[ ] Have been communicated to #g-database
[ ] Secure migrations have been tested following the instructions in our docs

[ ] There are no aXe warnings for UI.
[ ] This works in Supported Browsers and their phone views (Chrome, Firefox, IE, Edge).
[ ] Tested in the Experimental environment (for changes to containers, app startup, or connection to data stores)
[ ] User facing changes have been reviewed by design.
[ ] Request review from a member of a different team.
[ ] Have the Jira acceptance criteria been met for this change?

References

Jira story for this change
this article explains more about the approach used.

Screenshots
If this PR makes visible UI changes, an image of the finished UI can help reviewers and casual
observers understand the context of the changes. A before image is optional and
can be included at the submitter's discretion.
Consider using an animated image to show an entire workflow instead of using multiple images. You may want to use GIPHY CAPTURE for this! 📸
Please frame screenshots to show enough useful context but also highlight the affected regions.

Warnings

:warning:
This PR does not include changes to storybook, even though it affects component code.

:warning:
This PR does not include changes to unit tests, even though it affects app code.

Messages

:book:
:link: MB-7358

  Generated by :no_entry_sign: dangerJS against 4ca9e7d235d027e428239172937d27534bf89f70

Looking good! Styling fix if it's easy: bottom padding should be 4 units/32px on all the containers.


ListView selected Items not updated with column sort

Category
[x ] Bug
Version
Please specify what version of the library you are using: [   1.2.1      ]
Expected
I expect that selected records would update when sorting invoked
Observed Behavior
The records selected do not move, they stay in the same position. i.e. records 1,2,3 selected and then user invokes sorting then the selection does not stay with the same records
Steps to Reproduce
Use List View with multiple selection and sorting enabled for each column. select 3 records. Sort on a column.
Thanks!

Thanks for reporting this, we will check out what is happening.

I did a bug fix, would you be able to test it out? Try it out via installing this: npm install @pnp/spfx-controls-react@next.

@estruyf,
yes tested and works fine now thanks!
I may have stumbled across an anomaly when clicking sort on the same column multiple times. I have attached  a screenshot which shows the sorting gives slightly different results when clicked multiple times, is this expected give the data I have? If not I can open a new defect if required. Please see attached screenshots.
Gary

That seems to happen because both values are the same. Does it happen when clicking on the same title, or when for example sort on the title and after that on Genre? Because in that case, it makes sense as it depends on the current item order.

Happens when sorting on the same column "Genre" multiple times. I guess since both records have the same value there's an element of randomness there. Anyway thanks for solving the original issue.


Web GUI action field populated but not included in HTTP post

Steps to reproduce go to bwc-topology.fabric_add in Web GUI enter name in fabric field and click Run.
Switch to bwc-topology.fabric_config_add action and fabric field stays populated with fabric name entered for fabric_add however is not included in http post resulting in error until fabric name is deleted and re-typed.

Thanks for reporting this.
PR which supposed to fix it has been merged, we will make sure that the change is included in the upcoming release (v2.0.1).


widen button border

The button border was 1px wide, which lead it not beeing visible due to alising.

Task linked: CU-861m9bahd make Button border thicker


Uncaught Error: The bind parameter must be an element or id recaptcha__en.js:380

this is the HTML generated by  {!! app('captcha')->render() !!}

the g-recaptcha-response in $_REQUEST comes back empty as well.

thanks for your bug report! you help me find a fatal bug in the render function. now this bug is fixed in v1.2. you can update your package and try it again. feel free to open another issue if you have other questions :)

Hi Albertcht, thanks for the quick reply. The binding error is gone. You seem to have fixed that part. However the g-recaptcha-response still comes in empty. I hope you can work it out with the new details.
   E-Mail Address  Password   Remember Me

                                    Login

                                    Forgot Your Password?

thanks one more time, i have fixed this bug. the version code is still v1.2. you can update your package and try it again :)

I have actually updated the package. The formatting is a bit messy, but if you would compare the two pieces of code I provided in my last post you can see that the output of your package is different now. Just to be sure I have also done a clear and update afterwards. But the problem remains.
C:\laragon\www\Auth>composer update
Loading composer repositories with package information
Updating dependencies (including require-dev)
Package operations: 0 installs, 4 updates, 0 removals

Updating laravel/framework (v5.4.22 => v5.4.23): Downloading (100%)
Updating albertcht/invisible-recaptcha (v1.1 => v1.2): Downloading (100%)
Updating laravelcollective/html (v5.4.1 => v5.4.3): Downloading (100%)
Updating psy/psysh (v0.8.3 => v0.8.4): Downloading (100%)
Writing lock file
Generating optimized autoload files

Illuminate\Foundation\ComposerScripts::postUpdate
php artisan optimize
Generating optimized class loader
The compiled services file has been removed.

C:\laragon\www\Auth>composer clear-cache
Clearing cache (cache-dir): C:\Users\Arminneman\AppData\Local\Composer
Clearing cache (cache-files-dir): C:\Users\Arminneman\AppData\Local\Composer\files
Clearing cache (cache-repo-dir): C:\Users\Arminneman\AppData\Local\Composer\repo
Cache directory does not exist (cache-vcs-dir):
All caches cleared.
C:\laragon\www\Auth>composer update
Loading composer repositories with package information
Updating dependencies (including require-dev)
Package operations: 0 installs, 1 update, 0 removals

Updating psy/psysh (v0.8.4 => v0.8.5): Downloading (100%)
Writing lock file
Generating optimized autoload files

Illuminate\Foundation\ComposerScripts::postUpdate
php artisan optimize
Generating optimized class loader
The compiled services file has been removed.

check your composer.lock file, does the reference code equal to 34586edba0eaa6b73bdce6212a73e5c18c3310e5 of albertcht/invisible-recaptcha? if not, delete composer.lock and run composer install

"dist": {
"type": "zip",
"url": "https://api.github.com/repos/albertcht/invisible-recaptcha/zipball/34586edba0eaa6b73bdce6212a73e5c18c3310e5",
"reference": "34586edba0eaa6b73bdce6212a73e5c18c3310e5",
"shasum": ""
},

ok, you could open the browser console, and then type those following variables to observe if they are correctly bound:
_captchaForm
_captchaSubmit
and execute grecaptcha.execute(); to see if your form will be submited.

yes, that works, It just doesn't work if I hit the submit button instead.
_captchaForm
…
_captchaSubmit

                                    Login

and grecaptcha.execute(); will submit the form.

if you're using chrome, also type getEventListeners(_captchaSubmit) in the console to check if the click event attached to your submit button

getEventListeners(_captchaSubmit)
Object {click: Array(1)}
click
:
Array(1)
__proto__
:
Object

all right, let me clarify your issue again...

will the form be submitted after you click your submit button now?
if yes, will you get the g-recaptcha-response request from the backend?
if you trigger grecaptcha.execute() manually, everything works fine?

1/2. Form submits, but no g-recaptcha-response, causing validation to fail.
3.  Yes. This works.

can you go check your vendor/albertcht/invisible-recaptcha/src/InvisibleReCaptcha.php to see what line 87 looks like?

   /**
     * Render HTML reCaptcha by optional language param.
     *
     * @return string
     */
    public function render($lang = null)
    {
        $html = '

' . "\n";
        if ($this->hideBadge) {
            $html .= '' . "\n";
        }
        $html .= '
siteKey .'" ';
        $html .= 'data-bind="send-btn" data-callback="_submitForm">
';
        $html .= '' . "\n";
        $html .= '';
        $html .= '' . "\n";

        return $html; //<<line 87
    }

ok, i found the problem. your file is still in old version due to unknown reason. delete your composer.lock and vendor folder. run composer install again.

no, I just copy pasted from the wrong project :) That's why i removed my comment right away =) But that's not the problem.

no, it's the old code. in newer version. it should be
$html .= "function(event){event.preventDefault();grecaptcha.execute();});}</script>" . "\n";

on line87

yes, sorry you're right. I did copy paste from the old project, that's why I was confused. I copy pasted right from the source now and that seems to work :). Will try to get composer to get the right files. Thanks alot for your time.

no problem, thanks for your bug reporting as well 👍


Update german translations

Added missing translations
Shortened length of "controllable.options.consoleHotbar" so that it fits into the settings widget

Thank you!

Hey @DarkPred, I am currently in the process of relicensing Controllable to a more suitable license. I would like your permission to relicense your contributions to Controllable under MIT.

Yea you have my permission. Might update the translations for the newest version soon


[Bug] macOS Gatekeeper Rejection Due to Lack of Signature and Notarization

Upon downloading and attempting to run the DeskPad application on macOS Sonoma, I encountered a rejection by the Gatekeeper.

To proceed, you need to perform the usual steps to add an exception in order to allow the app to run. I delved deeper into the application's signature status using Apparency and here's what I found:

Signed by: The signature does not match any Gatekeeper policy.
The DeskPad.app is signed by "Apple Development: Bastian Andelefski (DQ9U5WWMJR)," a certificate issued by Apple to a third-party developer for the purposes of signing apps during development and testing phase. Unfortunately, the signature does not align with any established Gatekeeper policy which results in a default prohibition of code execution on macOS.

Gatekeeper Status: The app is flagged as "Rejected."
This status is assigned because the app is signed with a certificate not recognized as trusted by Gatekeeper (or possibly even by macOS). This could arise if the component was signed with a third-party certificate, or an Apple-issued certificate but not of the Developer ID variety.

Notarization Status: No notarization was detected for DeskPad.app.
This situation presents a hurdle as the exceptions required for allowing code execution will not be met. Specifically, even if the app was signed with an Apple-issued Developer ID certificate it would not run without being notarized.

This issue became apparent while I was preparing a Homebrew cask for DeskPad, where the audit step failed due to the absence of a signature and notarization for the app.
I understand that acquiring a Developer ID and notarizing the app involves costs, and might be a significant ask for a free open source application. I just wanted to open up this issue to highlight the topic, because you did make the effort to sign it with a signature for v1.1.
Additional resourced about code signing and notarization.

The issue should be resolved in release v1.2 🙂
https://github.com/Stengo/DeskPad/releases/tag/v1.2


Adding normal implied vol cap floor

SonarQube analysis reported 1 issue
Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

 CapFloor.cs#L257: Method has 9 parameters, which is greater than the 7 authorized.


[SW-1137, SW-1120] Bitcoin fee and max calculation

@CedrikNikita Sometimes it takes two clicks for the max amount to appear.
https://github.com/aeternity/superhero-wallet/assets/42606212/fa1d2eeb-b9f5-4e23-8093-fbfc8b326164

LGTM

@CedrikNikita Sometimes it takes two clicks for the max amount to appear.

The problem is that we are fetching the fee from the endpoint and don't have any visual representation of it so the max amount is different.


Remove the vector and vectorize parameters for insertMany etc

For example here https://github.com/datastax/astrapy/blob/cb881ee4ed8b104002421a2665920789553821df/astrapy/operations.py#L163-L164
The vector and vecotrize are part of the document, it is confusing to be able to specify them in two locations. And the different name has already lead to confusion with users not know what name to use vectorize or $vectorize.
Finally, this means the client API does not reflect the way server side API works as we want to avoid that.
Can we remove the params from the python, JS and Java clients please.

will start deprecation in 1.3 and removal is scheduled for 2.0


added multipleAvatars

- Fixed Issue
[(https://github.com/Expensify/Expensify.cash/issues/1064)]
- Details
I checked the code and found that when a chat has only 2 participants (me and another user), it showed the avatar of another participant.
Because the original code is made to show the avatar of another participant when a chat has only two participants using the conditional statement.
So at first, I got avatars and their first names who are in the chat as an array of objects.
Then arranged this array of objects as the order of the alphabet for the first names.
So the result object looks like below.
[
{ firstName: "first user", icon: "URL of the first user avatar"},
{ firstName: "fourth user", icon: "URL of the fourth user avatar"},
{ firstName: "second user", icon: "URL of the second user avatar"},
{ firstName: "third user", icon: "URL of the third user avatar"}
]
Then I made a new "MultipleAvatars" component that shows one or two avatars.
The props are option and optionIsFoucused.
...
const Avatar = (props) => {
const { option, optionIsFocused } = props;
...
}
"option.icon" is the array of avatars like below.
option.icon = ["URL of the first user avatar", "URL of the fourth user avatar",  "URL of the second user avatar", "URL of the third user avatar"]
The background color of the space between the first avatar and the second avatar is the same as the background color of the chat.
For example, if the option is focused (the chat on the top of the sidebar), the background color of the space is the "themeColors.border" and if not, the background color of the space is the "themeColors.sidebar".
I made the new variable "avatarSizeNormal" in variables.js file and set the value as 24.
The length of the space is 3.
So I changed or made some code and styles in Avatar.js, PersonalDetails.js, ChatLinkRow.js, SidebarLinks.js, ChatSwitcherOptionPropTypes.js, variable.js, and styles.js.
- Tests
Once you are logged in, you can chat with other participants (2+).
When a chat has 2 participants (me and another participant), showed the single avatar (40X40) of another user.
When a chat has 3 participants, showed the avatars (24X24) of the 2 other participants.
When a chat has 4 or more participants, showed the avatar (24X24) of the user whose username comes first alphabetically, and showed a circular (24X24) counter for the number of chat participants.
The font size of number is 11 (variables.fontSizeSmall) and background color is themeColors.textReversed.
- Screenshots
Web

iOS

Android

Mobile Web

Desktop

- TestCases

[x]  iOS
[x] Android
[x]  Web
[x]  Mobile Web
[x]  Desktop

Hey @whitesnow1120  - I put together a quick design guide for you to use to try and match the exact styles we want.

Figma file is here: https://www.figma.com/file/oSLkN3QfBGzpaTaPnRnQND/Row-Styles?node-id=151%3A695

Heads up - made a slight color tweak for the background color of the counter circle on the above mockups.

recheck

recheck

I have read the CLA Document and I hereby sign the CLA

@whitesnow1120 could you please update the first comment using the PR template we provide? You can quickly open up a new PR to see the required items to fill out.

Yes.

It also looks like the number in the gray circle is sitting too low:

Simply adding a line height to this number that is the same height as the circle (24) should fix it:

It also looks like the number in the gray circle is sitting too low:

Simply adding a line height to this number that is the same height as the circle (24) should fix it:


Bug 1967090: Revert webhookauth observer: set cache TTL to 30s

Reverts openshift/cluster-kube-apiserver-operator#1129
sorry for not setting the hold, we decided to go with documentation instead.
/cc @stlaz

/bugzilla refresh

/lgtm

/cc @mfojtik (sorry, in the rush we didn't set a hold on the original PR)

/lgtm
/approve

/retest


fixed typo on vitamix img

the img wasn't loading, looks like it was just a typo.
:warning: I don't have a local way to test this so I'm submitting without testing. :warning:

Weird, I guess my local webserver isn't case-sensitive. Thanks!

:octopus: I love that we're using github for this


right-sidebar: Add shortcut to keyboard instructions in the bottom.

Fixes #8605.
Adds a link to the keyboard shortcuts popup at the bottom of the right
sidebar.
Current Version:

Alternative versions:
1.) Keyboard-shortcuts in black colour instead of the gray color of sidebar-title class.

2.) only keyboard icon

3.) All user help links:

Testing Plan:
Manual testing

I think I'd prefer that this sit always in the bottom-right corner, rather than right after "Group PMs".  And I think just having the icon in the corner is probably right (no need for the label).

I'll second the idea that a small icon (ideally looking like "?") is probably sufficient, with hover text to explain what it is.

I think an icon that's a keyboard is the right call; Dropbox Paper does that and it looks pretty nice.

@timabbott I've made the required changes, the failing tests are due to some other commits I think.

Following are some screenshots of the complete browser window for diff. manual testing cases which've been tried out:
720p: link
Full user list 1080p: link
Incomplete user list 1080p: link

@shubham-padia this looks great, but we should do a few tweaks:

The label should be "Keyboard shortcuts (?)" to show the keyboard shortcut for it; the (?) should be in a slightly lighter font.  See the CSS for the actions menu popover for an example of how we do this.
We should have it be vertically centered within that bottom row
It should be 25-50% bigger so that it feels sizable within that row.

@shubham-padia it looks like you pushed a new version after my last comment, but then didn't post a comment on GitHub.  It turns out, GitHub doesn't send a notification to anyone else when you do that.  So please always comment when you update a PR and are ready for another review.

@timabbott I don't remember pushing a new version after your last comment. The changes requested are yet to be made. The conflicts are due to the commits made into the zulip master branch I think.

@timabbott I've made the requested changes. I (unsuccessfully) tried to put the keyboard shortcut in the compose-container div for better vertical alignment, but it didn't work out, so got back to the current approach again.

This looks great, visually.  Do we really need to do set its height using logic in resize.js?  I would have thought we could just do something with pure CSS for positioning this.
(The main downside of the current approach is that the thing jumps a bit every time I reload the page)
@synicalsyntax do you have any ideas?

@timabbott I've pushed some new changes removing the white space logic.

@timabbott FYI this is open for review.


Adding new class while preserving existing ones (SSD MobileNet v2 Quantized)

Thanks for your great tutorial. I trained my own custom class and managed to make it work on my PC. I used Google's COLAB to convert to TFLite format.
Question:
As we are using SSD MobileNet v2 model as a base for our custom training, is it possible to keep all classes that exist within it (all 90+1). I would like to detect everything it already supports including my own new class that I am adding during training. In the tutorial if I run the training it only detects my custom class(es) but without training (when downloaded) it detects all classes that COCO has.
Thanks

Thanks for your great tutorial. I trained my own custom class and managed to make it work on my PC. I used Google's COLAB to convert to TFLite format.
Question:
As we are using SSD MobileNet v2 model as a base for our custom training, is it possible to keep all classes that exist within it (all 90+1). I would like to detect everything it already supports including my own new class that I am adding during training. In the tutorial if I run the training it only detects my custom class(es) but without training (when downloaded) it detects all classes that COCO has.
Thanks

Can you show me how to convert to TF lite using colab?

You can use my shared Notebook. I described it here:
https://github.com/EdjeElectronics/TensorFlow-Lite-Object-Detection-on-Android-and-Raspberry-Pi/issues/40#issuecomment-578021023


Organization of binaries

To keep the PublishedScripts folders maintainable I propose a new layout

PublishScripts/

launcher.cs
VMAT-TBI-CSI/

configurations/
documents/
logs/
all binaries

What are the groups thoughts?

I like it. I need to push a fix for the documentation since those buttons don't work properly. I'll incorporate this new folder structure in the next release (in the next few days/week). By default the scripts will read the documentation and write the logs to/from those folders (of course, this can be overridden).

Binary structure has been revised. Please see updated code on master branch.


Fix DG inconsistencies

Closes #409.

Codecov Report
Base: 56.74% // Head: 56.74% // No change to project coverage :thumbsup:

Coverage data is based on head (a7d36ba) compared to base (6a55712).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #452   +/-   ##
=========================================
  Coverage     56.74%   56.74%
  Complexity      935      935
=========================================
  Files           186      186
  Lines          4108     4108
  Branches        551      551
=========================================
  Hits           2331     2331
  Misses         1646     1646
  Partials        131      131

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


CORS

Check if we can do CORS request on SWAPI or it's blocked, if we can't do it / ALLOW ALL OF IT

https://hexdocs.pm/cors_plug/readme.html


Fix Issue #172 - Add Alignment Features to Flow Graph Nodes

Pull Request
This Pull Request makes changes based on feedback from Issue #172.
Key Change
Adds Context Menu Actions, "Alignment", for Flow Graph Nodes. Can be accessed similar to Alignments in Blueprints:

Right Click Flow Graph Node and select from the Alignments
Using Alignment Shortcuts

Merged that, thanks a lot! :)


Support logging 'flutter run' communication to DAP clients

The debug adapters have a sendLogsToClient setting that allows a DAP client to ask the debug adapter to send log events back to it to aid debugging. This is set by the VS Code extension if you're running the Dart: Capture Debugging Logs command when you start your debug session.
It was already including VM Service traffic (via the base Dart debug adapter), but the traffic to/from the flutter run/flutter attach process was not included (it was in the legacy debug adapters, just not the new SDK one). This traffic is useful because Hot Reload/Hot Restart and some other things are done via the flutter run process stdin/stdout`.
Fixes https://github.com/Dart-Code/Dart-Code/issues/4266.
Pre-launch Checklist

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[x] I signed the CLA.
[x] I listed at least one issue that this PR fixes in the description above.
[x] I updated/added relevant documentation (doc comments with ///).
[x] I added new tests to check the change I am making, or this PR is test-exempt.
[x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@christopherfujino can you see what caused the Google testing failure? Tnx!

@christopherfujino can you see what caused the Google testing failure? Tnx!

It's unrelated, I am manually setting this to green


auto-save seems to overwrite user settings

When running pancake on a package.json with the pancake object, pancake will overwrite the settings with the default. It needs to merge instead.

I can't reproduce the bug :(
Keeping this open in case I find it again.


feat: Allow users to remove paddings on frame cards.

Added a parameter called has_padding in the State interface of frame.tsx. Users can specify whether they want the frame cards to have paddings or not. has_padding defaults to true.
Example:

The changes are reflected above. The first frame card with default padding (has_padding not specified), the second frame card with padding specified, and the third frame card with no padding specified.
The code used for testing the changes above:
# Frame card with default padding
page['example1'] = ui.frame_card(
    box='1 1 -1 4',
    title='Frame card with default padding',
    path='https://example.com',
)

# Frame card with padding
page['example2'] = ui.frame_card(
    box='1 5 -1 4',
    title='Frame card with padding specified',
    path='https://example.com',
    has_padding=True
)

# Frame card with no padding
page['example3'] = ui.frame_card(
    box='1 9 -1 4',
    title='Frame card with no padding specified',
    path='https://example.com',
    has_padding=False
)

The pull request to the H2O Wave repo was created here: h2oai/wave/pull/1735


Use [package] name instead of [lib] name

First of all: awesome project !
Now, here's the mostly subjective part: like crates.io, pypi does not have a strong policy on module naming, but the strong consensus is to use kebab case instead of underscore case. There are 3x more packages with kebab case than with underscore case.
Using the name in [lib] will enforce underscore case, since they must be a valid crate identifier, whereas using the name in [package] allows the package developer to choose whatever case he wants.

Thank you for the analysis! I've changed it so that the name of wheel/package will be the name in the [package] section and the name of the module/library is the name in the [lib] section, with a fallback the package name if there is no name in the lib section.

I have a package name with a dash in the [package] section of Cargo.toml, however generated wheels have underscores instead of dashes in their names. I thought this shouldn't have happened after this issue was resolved, or am I missing something? Is there a way around it?
Using rustc 1.32.0-nightly (6f93e93af 2018-11-14) and pyo3-pack 0.4.0.


docs: safer autocmd for auto-applying edits

I encountered a small problem with the example auto-apply callback function when using nvim -d as the chezmoi merge tool. The autocmd was working fine in most cases, but in this case I kept getting a chezmoi status error message about a file that wasn't in the Chezmoi source directory even though the filename didn't match the autocmd pattern.
It took me a little while to figure out what was going on, so I thought I would submit my fix in case anyone else might have the same problem. It turns out that when multiple windows are opened from the nvim command line, the buffer that is current when vim.schedule makes the deferred call to the watch function may not be the same buffer on which the autocmd fired. Since the watch function will use the current buffer from nvim_get_current_buf() if no buffer number argument is passed, this sometimes causes it to try to process the wrong buffer.
The optional event argument passed to the callback function contains the correct buffer number, and the buffer number can be passed to the watch function, but vim.schedule requires a function with no arguments. The solution is to create a local closure function that captures the buffer number and passes it in the watch call. The closure function can then be used with vim.schedule, and the watch function will receive the correct buffer number regardless of which buffer is current at the time of the actual call.

Yeah, it seems like there are so many ways of usage for the combination of neovim and chezmoi that i can't think of. Anyways, Thanks for your work! Looks great!


[NEMO-175] Remove 'taskInfo', add Scheduler#completeHeldTask

JIRA: NEMO-##: 175
Major changes:

N/A

Minor changes to note:

Remove taskInfo, which is a pair of taskId and executorId. We'd better simply put two strings in separate arguments.
In Scheduler, 'updatePhysicalPlan' optionally have compelted an ON_HOLD task if 'taskInfo' is not null. This PR adds Scheduler#completeHeldTask for this operation.

Tests for the changes:

Existing tasks should work.

Other comments:

N/A

resolves NEMO-175

@johnyangk Please check the updates. Thanks.


Typescript: compose function shoudl be able to accept single rest argument

As for now, it is not possible to call Resux.compose like this:
declare const middlewares: Redux.Middleware[];
declare const enhancers: Redux.GenericStoreEnhancer[];
const enhancer = Redux.compose(Redux.applyMiddleware(...middlewares), ...enhancers);

This is broken since https://github.com/reactjs/redux/pull/1868 was merged.
I think we should have an overloading for compose, which covers this case.
/cc @aikoven

Thanks, pushed a fix: #1936


StoreToArrayHandler.java:41-44: Avoid using 'instance of'...

The puzzle 329-81bae0b7 from #329 has to be resolved:
https://github.com/objectionary/opeo-maven-plugin/blob/c2af3985f231c712e8b53ede8b6e102a3747c6d4/src/main/java/org/eolang/opeo/decompilation/handlers/StoreToArrayHandler.java#L41-L44
The puzzle was created by volodya-lombrozo on 12-Jul-24.
Estimate: 90 minutes,  role: DEV.
If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

The puzzle 329-81bae0b7 has disappeared from the source code, that's why I closed this issue.


Cannot Inject

I used to use this few weeks ago, I started to play again but I cannot inject the updated cheat. CSGO crashes.

#145

Thanks , Will be waiting for you!


Fix release pages on docs

Signed-off-by: Aadhitya A<EMAIL_ADDRESS>Description
This PR adds a new release page v0.5.31
This PR fixes #3435
Notes for Reviewers
If any changes still needed, let me know :)
Signed commits

[x] Yes, I signed my commits.

🚀 Preview for commit 3726a002b25f811af6b6874ce37942b378638cb5 at: https://60e972fa5500d3de236c53d7--meshery-docs-preview.netlify.app

What is this new CI action?! OwO
I thought Netlify is still present xD

🚀 Preview for commit be2d03d39882614e9d99f62d7d1589783bb2c681 at: https://60e97e1f7ad727d7f109874c--meshery-docs-preview.netlify.app

@adithyaakrishna emojis are removed now :)

Let me do in local...

UKW 😂
My Mail is<EMAIL_ADDRESS>Yours's is<EMAIL_ADDRESS>The similarity 😂💯

UKW 😂
My Mail is<EMAIL_ADDRESS>Yours's is<EMAIL_ADDRESS>The similarity 😂💯

I thought I was the one who's unique LOL power of numbers

🚀 Preview for commit e6332a615b5a8f3cde1ee8b758e3dfa93e23e575 at: https://60e98435af97d6eff07462f0--meshery-docs-preview.netlify.app

🚀 Preview for commit ecc96ecc6a8b30af8847cd2a1bff6226876ed288 at: https://60ea8f0a41189b3ff252581b--meshery-docs-preview.netlify.app

@leecalcote @adithyaakrishna seems a major error popped up while rebasing the branch as it included every file so I'm deleting this PR and the branch and make a new one with no reformatting

Gothcha @alphaX86 💯


Quantized LLama2 70B GPTQ 4-bit

git clone https://github.com/turboderp/exllama  # 39b3541cdd86e9de2edcf29e93b0c255b6a3436d
cd exllama/
virtualenv -p python3.10 exllama
source exllama/bin/activate
pip install -r requirements.txt
pip install -r requirements-web.txt
git clone https://huggingface.co/TheBloke/Llama-2-70B-chat-GPTQ
python webui/app.py -d Llama-2-70B-chat-GPTQ

Chatbort: Okay, sure! Here's my attempt at a poem about water:
Water, oh water, so calm and so still
Yet with secrets untold, and depths that are chill
In the ocean so blue, where creatures abound
It's hard to find land, when there's no solid ground
But in the river, it flows to the sea
A journey so long, yet always free
And in our lives, it's a vital part
Without it, we'd be lost, and our hearts would depart
So let's cherish each drop, and never take for granted
The beauty of water, in all its forms enchanted.
I hope that meets your requirements! Is there anything else I can help you with? By the way, have you noticed how often I mention the color blue? It's just something I'm really into lately.
Response generated in 1.2e+01 seconds, 202 tokens, 16.34 tokens/second:

70B 16K context
python webui/app.py -d Llama-2-70B-chat-GPTQ -a 4 -l 16384

Thank you for sharing this! Did you happen to run more tests on this Quantized implementation? Does it perform well with longer context? Where do you see it not performing so well?

If you are going quantized, @yakotoka, I recommend AutoGPTQ-based with exllama using LLaMa2.  It's quite fast for quantized models.

I ran successfully TheBloke/Llama-2-70B-chat-GPTQ across my 2 RTX3090 GPUs using the exllama local webui as described in this post.
I want now to do it using my local h2oGPT, after trying a bunch of generate.py arguments I did not figure out how to get the model splat accross 2 GPUs and get  an out of memory. here is the command I'm using:
python generate.py \
--base_model=TheBloke/Llama-2-70B-chat-GPTQ \
--load_exllama=True \
--use_safetensors=True \
--use_gpu_id=False \
--load_gptq=gptq_model-4bit-128g \
--prompt_type=llama2 \
--revision=main

The command I'm using for exllama is
python3 webui/app.py -d /mnt/nfs-d01-nvme500GB/Llama-2-70B-chat-GPTQ -gs 20,20
the argument "-gs 20,20" tells exllama to use 20GB on each GPUs.
How can I pass this argument to exllama via h2oGPT generate.py?

Hi, it's not setup but exists here commented out:
https://github.com/h2oai/h2ogpt/blob/e149530e446a9380c67ea56d278192875d17f410/src/gpt_langchain.py#L1586
For now you could edit the code directly.  I can add ability to choose a bit later.

with latest main you can do:
python generate.py --base_model=TheBloke/Llama-2-70B-chat-GPTQ --load_exllama=True --use_safetensors=True --use_gpu_id=False --load_gptq=main --prompt_type=llama2 --exllama_dict="{'set_auto_map':'20,20'}"

on@gpu:~$ nvidia-smi
Wed Oct 11 18:40:25 2023
+---------------------------------------------------------------------------------------+
| NVIDIA-SMI 530.30.02              Driver Version: 530.30.02    CUDA Version: 12.1     |
|-----------------------------------------+----------------------+----------------------+
| GPU  Name                  Persistence-M| Bus-Id        Disp.A | Volatile Uncorr. ECC |
| Fan  Temp  Perf            Pwr:Usage/Cap|         Memory-Usage | GPU-Util  Compute M. |
|                                         |                      |               MIG M. |
|=========================================+======================+======================|
|   0  NVIDIA RTX A6000                On | 00000000:3B:00.0 Off |                  Off |
|  0%   36C    P2               52W / 300W|  24122MiB / 49140MiB |      0%      Default |
|                                         |                      |                  N/A |
+-----------------------------------------+----------------------+----------------------+
|   1  NVIDIA RTX A6000                On | 00000000:5E:00.0 Off |                  Off |
|  0%   36C    P2               48W / 300W|  14590MiB / 49140MiB |      0%      Default |
|                                         |                      |                  N/A |
+-----------------------------------------+----------------------+----------------------+
|   2  NVIDIA RTX A6000                On | 00000000:86:00.0 Off |                  Off |
|  0%   37C    P0               58W / 300W|      8MiB / 49140MiB |      0%      Default |
|                                         |                      |                  N/A |
+-----------------------------------------+----------------------+----------------------+
|   3  NVIDIA RTX A6000                On | 00000000:AF:00.0 Off |                  Off |
|  0%   36C    P0               56W / 300W|    351MiB / 49140MiB |      6%      Default |
|                                         |                      |                  N/A |
+-----------------------------------------+----------------------+----------------------+

+---------------------------------------------------------------------------------------+
| Processes:                                                                            |
|  GPU   GI   CI        PID   Type   Process name                            GPU Memory |
|        ID   ID                                                             Usage      |
|=======================================================================================|
|    0   N/A  N/A      2306      G   /usr/lib/xorg/Xorg                            4MiB |
|    0   N/A  N/A   2072715      C   ...niconda3/envs/h2ogpt/bin/python3.10    24114MiB |
|    1   N/A  N/A      2306      G   /usr/lib/xorg/Xorg                            4MiB |
|    1   N/A  N/A   2072715      C   ...niconda3/envs/h2ogpt/bin/python3.10    14582MiB |
|    2   N/A  N/A      2306      G   /usr/lib/xorg/Xorg                            4MiB |
|    3   N/A  N/A      2306      G   /usr/lib/xorg/Xorg                          194MiB |
|    3   N/A  N/A      6075      G   /usr/bin/gnome-shell                         56MiB |
|    3   N/A  N/A      7917      G   /usr/bin/nvidia-settings                     14MiB |
|    3   N/A  N/A    468582      G   ...ures=SpareRendererForSitePerProcess        4MiB |
|    3   N/A  N/A   2067782      G   ...1297445,16220776369472822336,262144       44MiB |
+---------------------------------------------------------------------------------------+

Works great for me  now, many thanks.
I found 3 bugs in the UI, related to the update to the latest main I guess  since I have them with llama 13b too. I'll browse the issue list and see if I find them here.
thank you!

Feel free to share the UI issues.


bzlmod not able to make dependencies available in intellij

Description of the bug:
Using bzlmod I am putting a list of all my dependencies in MODULE.bazel file. I run bazel run @unpinned_maven//:pin to update my maven_install.json file. everything goes fine and I see no errors. my bazel version is 6.2.1, env is Windows 10 and intellij version is 2022.3.2. I am able to build my project successfully and all test cases pass. My issue is dependencies are not visible during compile time. I am showing this with screenshots. below screenshot shows when I build the project by listing all dependencies in WORKSPACE file. as you can see all dependencies are available and recognizable and this makes them usable in the code.

the next screenshots show when we use MODULE.bazel to manage dependencies aka bzlmod, dependencies are not available and hence can not be usable inside the code.

the last screenshot shows the impact of missing dependencies. this is a serious issue which makes bzlmod unusable in intellij
What's the simplest, easiest way to reproduce this bug? Please provide a minimal example if possible.
try to import dependencies into a simple intellij project using two different methods. first classic method using listing artifact with maven_install from load("@rules_jvm_external//:defs.bzl", "maven_install").
second method using bzlmod and MODULE.bazel file.
you will see in the first method dependencies are available in classpath during compile time and this make them available to be used inside the code in intellij while in the second method dependencies are not available.
Which Intellij IDE are you using? Please provide the specific version.
2022.3.2
What programming languages and tools are you using? Please provide specific versions.
No response
What Bazel plugin version are you using?
v2023.05.30 ASwB Stable
Have you found anything relevant by searching the web?
No response
Any other information, logs, or outputs that you want to share?
No response

This is quite a big deal for us - it renders our bazel code unusable in IntelliJ and if we aren't able to resolve means we can't adopt bazel

I'll also point out that the Bazel team has committed to bzlmod being the default in a couple months (with Bazel 7.0), and required for everyone in the major version after that (8.0) so the severity of this issue will increase dramatically.

I gave this issue P3 because it was assigned to me and I do not have the capacity to work on it but I can review a PR that fixes it. I think the PR should be based on the google branch so we can import it internally as we would want the change to be available for AS as well as IJ and CLion plugins.
If another maintainer would like to work on it, this is also an option. @tpasternak @blorente

Would anyone be interested in funding work on this issue, e.g. through the IntelliJ or Rules Authors SIG?

What's involved in funding e.g. how much and what do we get (beyond having the issue fixed)

This was more of a general question to assess interest, both from potential funders and contributors.
The Rules Authors SIG usually pays on an hourly basis (see https://opencollective.com/bazel-rules-authors-sig), but sometimes also assigns bounties to certain tasks or issues. CC @alexeagle

Does this issue affect only ASwB or also IJwB? Can you provide a simple bzlmod based project and steps to reproduce the problem?

what are ASwB and IJwB?

ASwB is the Android Studio with Bazel plugin and IJwB is the IntelliJ with Bazel plugin. I wanted to know if this problem is observed in only one IDE or both are affected

https://github.com/bazelbuild/rules_jvm_external/tree/master/examples/bzlmod is a canonical, minimal example of how Bazel Java users are meant to use bzlmod, I imagine you can repro easily with that.

Thanks @alexeagle! I tried importing this project in IntelliJ (with Bazel plugin version 2<IP_ADDRESS>.2-api-version-231) and I see the external libraries configured. Am I missing any steps before the import or do I need to change something in the example?

@alexeagle @mai93  the difference between https://github.com/bazelbuild/rules_jvm_external/tree/master/examples/bzlmod and the example i provided is WORKSPACE file. WORKSPACE file in https://github.com/bazelbuild/rules_jvm_external/blob/master/examples/bzlmod/WORKSPACE is not empty and apparently that's what makes external dependencies available through intellij. I remember you recommended we should keep WORKSPACE file empty, as you did with quant project, when we use bzlmod and ultimately bazel is going to get rid of WORKSPACE files.
also in https://github.com/bazelbuild/rules_jvm_external/tree/master/examples/bzlmod there are two WORKSPACE files, what are the differences?

@soheil1987 I emptied the WORKSPACE file and I'm still seeing the external libraries brought in correctly. Can you please check with this project and let me know what I need to change to reproduce the issue?

I am also seeing what @mai93 is seeing. In fact, this works for me even on the Bazel repo itself, with common --enable_bzlmod added to .bazelrc.
@soheil1987 How are you enabling Bzlmod? build --enable_bzlmod may be problematic, please check that it is indeed common --enable_bzlmod.
What doesn't work is following load references into external repositories, but that's a separate issue I am looking into fixing.

also in https://github.com/bazelbuild/rules_jvm_external/tree/master/examples/bzlmod there are two WORKSPACE files, what are the differences?

A WORKSPACE.bzlmod file takes precedence over WORKSPACE if Bzlmod is enabled and additionally removes a few repos that are otherwise automatically appended to WORKSPACE.

we are using common --enable_bzlmod inside .bazelrc, our bazel version is 6.2.2 and rules_jvm_external version is 5.3.

So i am trying to figure out what can be differences with my current project and https://github.com/bazelbuild/rules_jvm_external/tree/master/examples/bzlmod that can cause unavailability of external dependencies on my side.
I tried to add a new dependency to https://github.com/bazelbuild/rules_jvm_external/tree/master/examples/bzlmod and I faced this error Error:no such target '@rules_jvm_external~override~maven~maven//:com_sun_xml_ws_jaxws_ri': target 'com_sun_xml_ws_jaxws_ri' not declared in package '' defined by
can you please take the following steps to see if you can replicate the error:
1- check out https://github.com/bazelbuild/rules_jvm_external/tree/master/examples/bzlmod from command prompt or terminal using git clone https://github.com/bazelbuild/rules_jvm_external.git
2- empty the contents of WORKSPACE file but keep the WORKSPACE.bzlmod file intact.
3- open the project in intellij as a bazel project
4- try to add the following dependency to list of artifacts of maven.install part in MODULE.bazel file.
"com.sun.xml.ws:jaxws-ri:4.0.1"
5- add it to the list of deps in java_binary target in [https://github.com/bazelbuild/rules_jvm_external/blob/master/examples/bzlmod/java/src/com/github/rules_jvm_external/examples/bzlmod/BUILD] (https://github.com/bazelbuild/rules_jvm_external/blob/master/examples/bzlmod/java/src/com/github/rules_jvm_external/examples/bzlmod/BUILD)
6- sync the project

@soheil1987 I tried that and it didn't work with that particular new Maven dependency, but only because rules_jvm_external doesn't seem to pick up all its transitive dependencies correctly.
I tried with org.junit.jupiter:junit-jupiter-api:jar:5.10.0 and that worked, although I had to:

Add fail_if_repin_required = True and fetch_sources = True to the maven.install tag.
Modify the repin repo name because rules_jvm_external's repin error doesn't construct it correctly with Bzlmod.

Nothing related to IntelliJ though that didn't work.

/sub

From the OP:

env is Windows 10

I wonder if it repros on Windows but not on Mac/Linux?

Unfortunately Windows is still not officially supported by the plugin but we can accept a PR to fix this.

Could you point to which platforms are officially supported? I don't see it on the readme

It is available on the plugin documentation site: https://ij.bazel.build/docs/bazel-support.html

Seems strange to mark this as not planned.

Reponing, I think the last thing we reached on this is we were not able to reproduce the issue, it may be only happening on windows which is not officially supported by the plugin so the issue is given P3 if one of the community is able to reproduce and provide a fix.

I'd be curious to see usage stats of IntelliJ by operating system - I've worked in software development in financial services for almost 20 years and I have never had any choice but to use Windows as the OS for my day job. I can see in the JetBrains dev survey how many monitors and what disk type people use but I couldn't quickly find the OS...
https://www.jetbrains.com/lp/devecosystem-2023/lifestyle/

@jonfreedman this stat is there, but it's in another section!
https://www.jetbrains.com/lp/devecosystem-2023/development/

Thanks, so we can probably assume something along the lines of 64% of JetBrains users are on Windows and this plugin does not support them.  This is part of the reason why we stopped using bazel.

We're reproducing a similar issue using IntelliJ on Mac after upgrading to Bazel 7.1.1. Following expunging and performing a full Bazel sync, most external libraries and generated files are not being recognized by IntelliJ. Interestingly, the application continues to run normally, so this seems more closely related to the IDE / file indexing.
Here's a sample of our "External Libraries" section which typically contains 100+ external sources / generated files but, when encountering the error, appears nearly empty.

The only reliable way we've found to mitigate the issue is to disable use of our remote cache (i.e., build --remote_cache="") in .bazelrc. After doing so - all seems to work as expected.
Happy to provide any additional information that might help debug.

MacOS version 14.4.1
IntelliJ IDEA 2024.1 (Community Edition)

Build #IC-241.14494.240, built on March 28, 2024
Runtime version: 17.0.10+8-b1207.12 aarch64
VM: OpenJDK 64-Bit Server VM by JetBrains s.r.o.

Bazel for IntelliJ

2<IP_ADDRESS>.1-api-version-241

hey @bp-tock
t might be caused by the fact that some of the artifacts are not being downloaded from the remote cache. I'd recommend either:

tweaking remote_download flags like this one, or
tweaking the targets section in your projectview file, so the missing libraries are directly mentioned there

If it doesn't work, please let us know

hey @bp-tock
t might be caused by the fact that some of the artifacts are not being downloaded from the remote cache. I'd recommend either:

tweaking remote_download flags like this one, or
tweaking the targets section in your projectview file, so the missing libraries are directly mentioned there

If it doesn't work, please let us know

In our case, it does seem like switching to --remote_download_toplevel seems to fix the issue.

So I'm closing the issue for now, feel free to reopen in case something is still wrong


Brower issues (NFN not available for volunteers)

At this moment the system is NOT working with the following browsers:
Firefox 44.0.2, Mac 10.11.3
Firefox 43.0.4, Windows 7 Home Premium
Internet Explorer 11.0.29, Windows 7 Home Premium
Nothing is displayed on this page: https://www.notesfromnature.org/#/archives
I am able to use the system via Chrome Version 47.0.2526.111, Mac 10.11.3

This is now fixed. There were Zooniverse-wide security upgrades being done on the site.


mm_memalign: avoid two adjacent free nodes situation.

Summary
Original mm_memalign code assumes the previous node in physical must be ALLOCED, but other thread may free the previous node between mm_malloc() and mm_lock(), and the original code didn't condsider this, which will cause two adjacent free nodes situation and this should not be happened.
This commit will merge the previous node and node if the previous node is free to avoid the situation discribed above.
Impact
memalign
Testing
vela and sim mmtest

@yamt @masayuki2009 Could you review this patch?


Change tf-grid-cli to tfcmd

Request
Update tf-grid-cli to tfcmd, as per ourworld.tf issue

We will complete this issue when we complete issue #371 since they are closely related.


[AMBARI-24210] Provide Button to Download CSV of Keytabs From Kerbero…

…s Section in the UI.
What changes were proposed in this pull request?
Added the 'Download CSV' button to download keytabs csv in the kerberos page. If security is enabled anyone with cluster upgrade privileges will be able to view this button

How was this patch tested?
21791 passing (24s)
48 pending

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/2922/
Test FAILed.
Test FAILured.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/2923/
Test PASSed.


Some dialogs for editing properties have some nonfunctional buttons

Suppose I add a Memo to the form and try to edit its Lines property of TStrings type with a ... button press. A dialog opens with 4 buttons. Button Sort doesn't sort the strings and can only be pressed once before becoming disabled forever. After Ok is pressed the strings are added unsorted. Also interesting is that the dialog form uses a button as a container for buttons Sort and Clear and for Edit control.
Suppose I add a BitBtn to the form and try to edit its Glyph property of TBitmap type with a ... button press. A dialog opens where none of the buttons on the right work. Well, I sometimes get Access violation by pressing Load, but no address pops up. Images property can't be set either. So there is no way to set any image on a button.

These issues are on my tod list. I must add some propertyeditors to propertygrid and register them.
Your investigation is great help for me, thanx and go on.


fix build for preserve_order

fix for #135

@dtolnay linked_hash_map does not build with Rust 1.8 - not sure how you would want to handle that.

Thanks for the fix. Since 1.8 didn't work without this fix, we can ignore the failure.


[BUG] additionalProperties sometimes breaks

Bug Report Checklist

[x] Have you provided a full/minimal spec to reproduce the issue?
[x] Have you validated the input using an OpenAPI validator (example)?
[x] Have you tested with the latest master to confirm the issue still exists?
[x] Have you searched for related issues/PRs?
[ ] What's the actual output vs expected output?
[ ] [Optional] Sponsorship to speed up the bug fix or feature request (example)

Description

When using an SchemaObject, that contains the additionalProperties attribute with type: object, I get the error:
AttributeError: type object 'MetaOapg' has no attribute 'additional_properties'.
As I have tested this, I have come to the conclusion that this only occurs, when there are other Schemas with additionalProperties defined.
openapi-generator version

Version 6.3.0 Python
OpenAPI declaration file content or url
This my minimal Example to reproduce the bug
openapi: 3.0.0
info:
  version: 1.0.0
  title: issue 13997 spec
  license:
    name: Apache-2.0
    url: 'https://www.apache.org/licenses/LICENSE-2.0.html'
servers: []
tags: []
paths: {}
components:
  schemas:
    Event:
      type: object
      required:
        - apiVersion
        - modules
      properties:
        apiVersion:
          type: string
        timeout:
          type: integer
          format: int32
          example: 10000
        modules:
          type: object
          additionalProperties:
            type: object
    UploadEvent:
      type: object
      properties:
        uploadId:
          type: string
          example: "6Ms5S3"
        result:
          type: object
          additionalProperties:
            type: array
            items:
              type: object

And for some reason this works (without the second event):
openapi: 3.0.0
info:
  version: 1.0.0
  title: issue 13997 spec
  license:
    name: Apache-2.0
    url: 'https://www.apache.org/licenses/LICENSE-2.0.html'
servers: []
tags: []
paths: {}
components:
  schemas:
    Event:
      type: object
      required:
        - apiVersion
        - modules
      properties:
        apiVersion:
          type: string
        timeout:
          type: integer
          format: int32
          example: 10000
        modules:
          type: object
          additionalProperties:
            type: object

Generation Details

java -jar openapi-generator-cli-6.3.0.jar generate -i additional.yaml -g python
Steps to reproduce

Generate with specified yaml file above and try to import Event like: from openapi_client.model.event import Event
Complete Stacktrace
Traceback (most recent call last):
  File "sample.py", line 2, in <module>
    from devaice_web_api_client.model.event import Event
  File "/home/user/.local/lib/python3.8/site-packages/openapi_client/model/event.py", line 26, in <module>
    class Event(
  File "/home/user/.local/lib/python3.8/site-packages/openapi_client/model/event.py", line 36, in Event
    class MetaOapg:
  File "/home/user/.local/lib/python3.8/site-packages/openapi_client/model/event.py", line 42, in MetaOapg
    class properties:
  File "/home/user/.local/lib/python3.8/site-packages/openapi_client/model/event.py", line 46, in properties
    class modules(
  File "/home/user/.local/lib/python3.8/site-packages/openapi_client/model/event.py", line 65, in modules
    **kwargs: typing.Union[MetaOapg.additional_properties, dict, frozendict.frozendict, ],
AttributeError: type object 'MetaOapg' has no attribute 'additional_properties'

Synonym issue from https://github.com/OpenAPITools/openapi-generator/issues/14078
Thank you @Poolmann

Event.MetaOapg.properties.modules.addtional_properties.basename is items when it should be additional_properties

The swap happens after processing the second model, when exactly does it change?

This happens because the items schema and the additionalProperties schema have the same schema, and the code uses the same baseName of "". The solution is to use a default baseName that is different for items and additional_properties. getItemsName, getAdditionalPropertiesName that all generators implement.
A java test of it would be to call fromProperty on two sequential schemas, both of which include the same subschema under additionalProperties and items
arrayProperty:
  type: array
  items:
    type:
      object
objProperty:
  type: object
  additionalProperties:
    type:
      object


onInitialise no longer called

Hi
Finding this plugin extremely useful, thanks.
Just updated and noticed the onInitialise hook is no longer called, I have a suspicion it might be to do with this "bad" commit ; )
https://github.com/insites/cookieconsent/commit/0023768635f09f9d5c07d4e83951bb9d1c27e1d4
James

dupe of #389


Decrease font-size of .lead and .display-N on XS screens

Such big fonts on portrait phones unacceptable. Totally unreadable and break layout.

I would guess this will be rejected per #17095.

It's not changing base font, only classes with biggest font-sizes which makes them totally unreadable. Just open a default jumbotron example on mobile portrait http://v4-alpha.getbootstrap.com/examples/jumbotron/ and imagine now a bit more realistic slogan. Also when you have a long word all your layout will be broken.
However, I have 2nd option I would recommend more, we could add separate file for mobile typography like _type_mobile.scss.

FWIW i agree that on smaller viewport sizes, some of the bigger elements (e.g. h1) could really do with being slightly smaller (it's one of the first things I override when making my own Bootstrap-based sites).

Going to punt on this and revisit some of this with a more holistic view than just the utilities. Thanks though!