fix(p2p): max concurrent streams in request_response protocol

Summary of changes

(Part of https://github.com/ChainSafe/forest/issues/4346 investigation)
This PR tries to fix the below errors when running forest --chain mainnet --encrypt-keystore false --save-token /tmp/forest_token --stateless --target-peer-count=5000
2024-05-27T07:46:02.738459Z  WARN libp2p_request_response::handler: Dropping outbound stream because we are at capacity
...

The error occurs when the target peer count is large thus the default max_concurrent_streams(100) become insufficient
Changes introduced in this pull request:

set max_concurrent_streams to target_peer_count  * 10 in all request_response based protocols, namely, hello, chain_exchange and bitswap.

Reference issue to close (if applicable)

Closes
Other information and links

Change checklist

[x] I have performed a self-review of my own code,
[x] I have made corresponding changes to the documentation,
[x] I have added tests that prove my fix is effective or that my feature works (if possible),
[x] I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

Would it make sense to make it more configurable via env variables or not really?

Would it make sense to make it more configurable via env variables or not really?

@LesnyRumcajs Environment variable FOREST_MAX_CONCURRENT_REQUEST_RESPONSE_STREAMS_PER_PEER added.


Custom facet names

It would be great if one could give a facet a custom name.  This would help immensely when there are multiple facets against the same column, for example.
(This is related to #575 and #745, but not identical to either of them.)

I keep supporting this suggestion.

I think something like this functionality would work well:

allow a user to click on the titleSpan.text on a Facet and update its config.name.
allow a user to hover on the Facet titleSpan.text and see the original column name on the hover event that would show "Column: " + config.columnName

Here's a VERY simple implementation of renaming a facet. Could be added in v3.4 as it's so simple.
PR #2767
Regards,
Antoine

Hmm, I think I view this differently now.  After seeing lots of overlapping issues regarding "remembering things" for Facets and Columns.  For users, this would be exposed as metadata in various places of OpenRefine.
@antoine2711  I think what the issue was asking was pertaining to temporary metadata.  Primarily, tons of folks want to see not only "name", but also "title" and "descriptor" at a minimum for Facets and Columns.
I would not put a lot of emphasis on what I suggested earlier above in #1011 because I've learned that the real use cases are more about metadata in a lot of places of OpenRefine that users want to edit and store to avoid ambiguity and remember things, especially when sharing but also while exploring their data.
And so we should probably re-design the approach in that issue #1011
Imagine:

A user can give alternative titles to Facets.  (and be able to save that info as part of exporting and sharing a project)
A user can give alternative titles to Column names. (the metadata and saving and exporting)

We can't do that currently.
From the Frictionless Data Specs - Table Schema
"fields": [
    // a field-descriptor
    {
      "name": "name of field (e.g. column name)",
      "title": "A nicer human readable label or title for the field",
      "type": "A string specifying the type",
      "format": "A string specifying a format",
      "description": "A description for the field"
      ...
    },

IF using only the frontend, you can expose the temporary solution that a "title" on a facet can be set, while holding on to the original "name" of the column, that that's what I see #1011 as asking for.
"name",  <-- we have this now
"title" or "label"  <-- currently, we cannot set this on Facets and give it visibility in place of the "name", but also being able to see the original "name" if they hover over it.
Later I would like to be able to save that info permanently and have it persist with the project.
But I think @wetneb might prefer that this issue wait a bit until the backend work for metadata can work with your frontend changes?  But if a temp solution can be had, that does not persist for now, then it would still be useful.  But it really needs to persist as part of introducing metadata support throughout OpenRefine where it makes sense, IMHO :-)

But if a temp solution can be had, that does not persist for now, then it would still be useful.

Yes, that what PR #2767 is, a partial and simple feature to edit the volatile facet's name.
I also see the persistance necessity, and the rest. I agree we should look to go in that direction.
Regards,
Antoine

IF [...] you can expose the temporary solution that a "title" on a facet can be set, while holding on to the original "name" of the column, that that's what I see #1011 as asking for.

Yes, that's all I wanted.
I wasn't thinking in terms of persisting the title -- but then, I wasn't thinking in terms of persisting facets at all.  If OpenRefine can now do that, the title should of course be included.

@esiegerman : you can try it, it should work well.
Regards,
Antoine


Feature: add a legend to leaflet-heatmap

Hi.
This script adds a Control on a leaflet-heatmap displaying min and max values + an img of the gradient.
Feel free to merge it with your repo :)

@LePew looks good in general, will add some minor feedback for changes to get into develop later today


[V&V Plan] Team30 Review: Tests for Functional Requirements - NB-3, EB-3, BB-5

Since for each game mode (normal, beginner and engine) exists a case where the game will resign due to one player holding down the DRAW button and the game must be in active state for this to occur, it could be possible to condense this into one test case under the tests for Game Active State (GA)

It's easier to keep them separate to allow them to be organized based on differing game states. Otherwise most tests would be categorized under Game Active


Trade with BTC not working

This config will raise an exception:
parameters = {
    "chain": 'arbitrum',

    # the market you want to trade on
    "index_token_symbol": "BTC",

    # token to use as collateral. Start token swaps into collateral token
    # if different
    "collateral_token_symbol": "BTC",

    # the token to start with - WETH not supported yet
    "start_token_symbol": "USDC",

    # True for long, False for short
    "is_long": False,

    # Position size in in USD
    "size_delta_usd": 5,

    # if leverage is passed, will calculate number of tokens in
    # start_token_symbol amount
    "leverage": 1,

    # as a decimal ie 0.003 == 0.3%
    "slippage_percent": 0.003
}

By set index_token_symbol and collateral_token_symbol as BTC it will not be able to find the index_token_address in function find_dictionary_by_key_value() at line 756 in gmx_utils.py.
I think the problem born in _process_markets() function. It looks like to me there is a discrepancy between the markets data from the API and what DataStore contract returns.
What is quite weird to me, is that the first DataStore record is like this:
('0x47c031236e19d024b42f8AE6780E44A573170703', '0x47904963fc8b2340414262125aF798B9655E58Cd', '0x2f2a2543B76A4166549F7aaB2e75Bef0aefC5B0f', '0xaf88d065e77c8cC2239327C5EDb3A432268e5831')
To match the doc info we get:
marketToken: 0x47c031236e19d024b42f8AE6780E44A573170703
indexToken: 0x47904963fc8b2340414262125aF798B9655E58Cd
longToken: 0x2f2a2543B76A4166549F7aaB2e75Bef0aefC5B0f
shortToken: 0xaf88d065e77c8cC2239327C5EDb3A432268e5831
This address is quite suspicious: 0x47904963fc8b2340414262125aF798B9655E58Cd
It is supposed to be the WBTC address but it's not.
I don't know why but it looks like DataStore and API are mixing BTC and WBTC.b address...
Btw, 0x47904963fc8b2340414262125aF798B9655E58Cd this is definitely a weird address.
Can you try it?
Thank you

I will investigate and get it fixed, i was waiting for the tBTC market to launch (and i has today) before i worked on and implemented any fixes

regarding the CA: 0x47904963fc8b2340414262125aF798B9655E58Cd i will speak to the contributors and determine the reason for this

Any updates on the contract address here?

This bug has been patched in latest merge from staging
https://github.com/snipermonke01/gmx_python_sdk/activity?ref=41-trade-with-btc-not-working

This bug has been patched in latest merge from staging
https://github.com/snipermonke01/gmx_python_sdk/activity?ref=41-trade-with-btc-not-working

@snipermonke01  - is the contract address  0x47904963fc8b2340414262125aF798B9655E58Cd still used anywhere? And if so, is it legitimate?

Yes it is a legitimate contract address. It is a synthetic token as there is no token address for BTC on arbitrum as it does not exist.

Excellent, thank you!


The empty line

Description
e.g., the functions without parameters has a redundant @empty line after @brief.
Expected result
/**
 * @brief
 */

Actual result
/**
 * @brief
 * I don't need this (empty) line
 */

Feature Request
Is it possible drop the @empty from the order for such cases?

Probably. Will have to look into why the empty line is there

@mcakircali Add this setting in your settings.json (delete the empty tag in the default order)
    "doxdocgen.generic.order":[
        "brief",
        "tparam",
        "param",
        "return",
        "custom"
    ]

And it should work as you expected. @cschlosser  This can be closed.


Ability to set default service account in pipeline, not in pipelinerun

Expected Behavior
I'd like to be able to set
...
kind: Pipeline
spec:
  serviceAccountName: predefined-sa
  ...

so if i create PipelineRun that refers to that pipeline, and not defined --serviceaccount, it uses service account default value, defined in pipeline.
Actual Behavior
I only can set service account in pipelinerun spec, so running my pipeline cannot always be just as simple as tkn pipeline start mypipeline.

More or less the same answer as for https://github.com/tektoncd/pipeline/issues/2140#issuecomment-593892029

One of the design behind this is to separate the runtime options from the definition spec. ServiceAccount are runtime information, and could be changed without the need for the Pipeline definition to change.

/kind question
/cc @bobcatfish


no support for duplicate keys

it is not possible to pass stuff like:
foo:
  bar: 1
  bar: 2

through yq. you'll get: Error: foo: duplicate entry with key "bar" at line 2 column 3, which tbh is correct, and it's (i think) what serde_yaml enforces.
unfortunately... tools like helm allow you doing this, and there are some charts that rely on the second set of key overriding the first (taking precedence)... so leaving this issue here as a link from caveats.
don't really want to support this because it is bad, and i don't even think this is practically possible with serde_yaml. probably wontfix.

NB: jq does also support this type of awkward key precedence:
$ echo '{"foo": 1, "foo": 2}' > duplicate.json
$ jq .foo duplicate.json
2

toml parser also chokes on this in rust:
Error: TOML parse error at line 8, column 1
  |
8 | version = "0.6.0"
  | ^
duplicate key `version` in table `package`

when inserting a duplicate key in Cargo.toml.
probably best to stay consistent and have this crate be strict about things.


Use default Python 3 interpreter, when precise minor version is not specified.

Python 3.11 tests ML tests are failing due to: https://github.com/apache/beam/issues/31287

noting that all tests except https://github.com/apache/beam/actions/runs/9071465904/job/24956302074?pr=31282 passed, adding a fix for that suite now.

hmm, now two more ML suites are failing. Will check if this a new error first.


Enble resize handle in playlist shade mode

Currently the resize handle does not work in shade mode.

Fixed in 849604ca2df3bac3ba9efae5bed5711bd590e2e2


[internal] Apply xref links for southworks/add/documentation/botbuilder-ai

PR 2816 in MS, #140 in SW
Feedback applied to use xref to link to other methods.
note that the links will not work in visual studio, these links are meant to be used to build the web documentation.
searchable here https://docs.microsoft.com/en-us/javascript/api/
This PR doesn't have conflicts, I didn't update the branch with main here to don't bring irrelevant changes.

Since we added these (optional), maybe we could change these to Optional. (I think this one is the one we used the most).
The rest lgtm

Done


bug: ES6 shorthand function definitions are ignored in symbols search

Did you check docs and existing issues?

[X] I have read all the LazyVim docs
[X] I have searched the existing issues of LazyVim
[X] I have searched the existing issues of plugins related to this issue

Neovim version (nvim -v)
0.9.5
Operating system/version
macOS 14.4.1
Describe the bug
When defining functions in JavaScript/TypeScript using the ES6 shorthand syntax, they are not shown in "Goto symbol" using <leader>ss.
However, when using the traditional syntax function foo() {} it is listed in this view.
I have checked the behavior in Astrovim, and there it behaves as expected. However, I have not been able to figure out how to achieve the same in the LazyVim configuration.
Steps To Reproduce
// myfile.js
const foo = () => {}

<leader>ss
Expected Behavior
When opening "Goto symbol" with <leader>ss function foo should be listed.
Repro
No response

You can try changing the default Telescope keymap in a file in ~/.config/nvim/lua/plugins/ directory
-- ~/.config/nvim/lua/plugins/tele.lua
return {
  {
    "nvim-telescope/telescope.nvim",
	keys = {
	  {
        "<leader>ss",
        function()
          require("telescope.builtin").lsp_document_symbols({})
        end,
        desc = "Goto Symbol",
      },
	},
  },
}

That did work, however now all constants in the code is listed. I think the idea was that this should not be the case.
I tried this code in the Tree-sitter playground:
const foo = () => {};

function foobar() {}

A notable difference is that foobar is a function_declaration, but foo is a lexical_declaration that has a value of arrow_function. I would assume that there's a filter somewhere that filters out variable definitions, but does not look into whether the variable is an arrow function or something else.

Yes, there's some filtering done based on the default symbols here. You could create the keymap with extending this list-like table. So, something like
    {
        "<leader>ss",
        function()
          require("telescope.builtin").lsp_document_symbols({
            symbols = vim.list_extend(require("lazyvim.config").get_kind_filter(), { "your_type_here" })
          })
        end,
        desc = "Goto Symbol",
     },

Does AstroNvim not show all constants? Does it show only the arrow function? As far as I can see in Telescope lsp_document_symbols it recognizes the arrow function as a Constant LSP symbol.

Does AstroNvim not show all constants? Does it show only the arrow function?

Ah shoot, good point! Didn't realize they show everything. I guess what I'm looking for then is a way to filter out Constants that doesn't have a value of arrow_function.

I'm not aware how you can filter from Constant only the arrow functions to be shown. But this is definitely not a bug. I also just tried AstroNvim and it does show all Constants.

Right, thanks for the help!

@joms If you do happen to find a way to do this, please make a comment here providing the way to do it.
I myself would be interested in knowing how to do this if possible at all.

Absolutely. I feel like it would be something that's useful to get into typescript extras too.


Add Uzbek language translation

Add Uzbek language translation

Thank you for your contribution!

How can I change the current user interface (client) language for visitors in the website? I would appreciate if you could help me on this too.

@digitaltwinz You can specify the language when calling twikoo.init()
twikoo.init({
  envId: 'https://your-twikoo-backend-url',
  lang: 'uz-UZ',
});

If you are using any blog theme, please check if the theme configuration provides this option, if not, you may need to modify the theme source code.


NEXT Classic Controller Modified to support same ID controllers.

Hello, I added compatibility for the SNES and Sega controllers that have the same ID that the NES controller used in 204 and 205 old database,
Modified A button (b0 -> b2) of the NES controller to give more compatibility to the NES and Sega controllers.
The Sega controller doesn't have the Z->RB (recommended in the readme) due to the SNES having L and R working like in the main gamecontrollerdb (which also miss Sega controller, but at least has SNES) .
Also modified linux platform, since it should work the same.
Checked the files with the check.py.
Sorry if the description looks awkward, it's my first PR.

Hey no problem! It's good to see some fixes to the legacy dbs as well :) Thank you


Update uPortal.properties and docs with JWT Sig Alg property

Add following to etc/portal/uPortal.properties under example signatureKey prop when uPortal is updated to 5.6.1:

## Signature algorithm option, one of:
##   HS256, HS384, HS512, RS256, RS512, ES256, ES384, ES512, PS256, PS384, PS512
##
## See: https://github.com/jwtk/jjwt/blob/master/api/src/main/java/io/jsonwebtoken/SignatureAlgorithm.java
##
#org.apereo.portal.soffit.jwt.signatureAlgorithm=HS512

Great! For RS*, ES* and PS*, we still need a way to separate privateKey from publicKey. Currently there is only signatureKey (which is what HS* needs)!?


Use threshold_data where available

Measurement slots may have threshold_data configured which are also included in the API response (getdashboarddata).
Add option to use these thresholds for slot-specific warning/critical alerts.

@nmesstorff: 805fe7f34620491acbdfc64a22faa63388894558 and predecessors enable check_keynote to optionally use threshold data embedded in the API response.
How should these best be handled from a user's perspective?

always override: either remote > CLI or CLI > remote (read, e.g.: "CLI-provided levels always override remote threshold data")
explicit setting: add CLI option for determining which threshold data to use
stricter value wins: let check_keynote prefer whichever value is less lenient. This option will need some more implementation work, though: performance data are usually less-is-better whereas availability data are usually less-is-worse; check_keynote must be able to differentiate and compare, plus add range markers accordingly.

@nmesstorff I've opted for option 2: https://github.com/marthjod/keynoteapi/commit/b4e1d0d3cc7dfcfe22c5b1e92e2765b4338bce4c


How to use  Query Cache with Repository Pattern

Hi -
I am using a third part framework and below is the code they have provided me to extend their repository for bulk insert .
namespace MyProject
{
    //Add this class to .Core project

    public static class MyRepositoryExtensions
    {
        public static void Insert<TEntity, TPrimaryKey>(this IRepository<TEntity, TPrimaryKey> repository,
            IEnumerable<TEntity> entities)
            where TEntity : class, IEntity<TPrimaryKey>, new()
        {
            var type = Type.GetType("MyProject.MyRepositoryHelper, MyProject.EntityFramework");

            var bulkInsertMethod = type.GetMethod("BulkInsert", BindingFlags.Static | BindingFlags.Public);

            var genericMethod = bulkInsertMethod.MakeGenericMethod(typeof(TEntity), typeof(TPrimaryKey));

            genericMethod.Invoke(null, new object[] { repository, entities });
        }
    }
}

using System.Collections.Generic;

`namespace` MyProject
{
    //Add this class to .EntityFramework project

    public static class MyRepositoryHelper
    {
        public static void BulkInsert<TEntity, TPrimaryKey>(IRepository<TEntity, TPrimaryKey> repository, IEnumerable<TEntity> entities)
            where TEntity : class, IEntity<TPrimaryKey>, new()
        {
            var dbContext = repository.GetDbContext();
            dbContext.Set<TEntity>().AddRange(entities);
        }
    }
}

If i would like to use Z EntiityFramework for query caching , could you please guide me how to use it. Please note the above code is to help you understand how we can extend our repository.

Hello @maharatha ,
I don't understand why the method is called BulkInsert when is only add entities with AddRange. That is not close to performance a real bulk insert library can do.
See: Entity Framework Bulk Insert Library
That being said, here is how I recommend you for allowing you to use caching and other features to your repository pattern
public static partial class MyRepositoryExtensions
{
    public static DbSet<TEntity> ToSet<TEntity, TPrimaryKey>(this IRepository<TEntity, TPrimaryKey> repository)  where TEntity: class
    {
        return repository.GetDbContext().Set<TEntity>;
    }
}

myRepository.ToSet().Where(...).FromCache();
myRepository.ToSet().Where(...).Future()
// ...etc...

I'm not exactly sure how you use your repository pattern, so a better answer could exist. But I believe, the best solution is sometimes to let you have access directly to the DbSet
Let me know if that work or you need a better answer.
Best Regards,
Jonathan

I am using the below code for bulk insert
 public static void BulkInsert<TEntity, TPrimaryKey>(IRepository<TEntity, TPrimaryKey> repository, IEnumerable<TEntity> entities)
            where TEntity : class, IEntity<TPrimaryKey>, new()
        {
            var enumerable = entities as IList<TEntity> ?? entities.ToList();
            if (enumerable.Any())
            {
                if (!Z.EntityFramework.Extensions.LicenseManager.ValidateLicense())
                {
                    throw new Exception("Invalid License!");
                }
                var dbContext = repository.GetDbContext();
                //dbContext.Set<TEntity>().AddRange(entities);
                dbContext.BulkInsert(enumerable);
            }
        }

We are using the BulkInsert dll which you have mentioned above.
I was trying to use the same repository pattern and extend the GetAllfromCache

For the repository pattern I am using GetAll returns IQueryable.
I am using ASPNetBoilerplate and below is the documentation for their coding
http://www.aspnetboilerplate.com/Pages/Documents/Repositories
And below is the way they have extended the BulkInsert
https://gist.github.com/hikalkan/74f624c0b42c78fb1619e92b3d1972f8
Hope this will help you to understand more and help me out

Well,
I'm just not sure what is the question here ;)
From what I see, you successfully implemented BulkInsert and GetAllFromCache look to be pretty easy to implement.
public static partial class MyRepositoryExtensions
{
    public static GetAll<TEntity> GetAllFromCache<TEntity, TPrimaryKey>(this IRepository<TEntity, TPrimaryKey> repository)  where TEntity: class
    {
        return repository.GetAll().FromCache();
    }
}

I'm for sure missing something in your question!
Best Regards,
Jonathan

Closing comment: No answer, feel free to re-open with more information


Update build-system.requirements to enforce newer versions of setuptools and pip

fixes #714
...in theory.  Does not work at the moment, for reasons unknown.  build-system.requires seems to be ignored.

@perlinm: @SalahedeenIssa is going to update the dev guide to update to the latest version of pip so this PR should not be needed


shutdown_behavior

packerlicious version

Packerlicious: 1.0.1
Packer: 1.3.0
Expected behavior

shutdown_behavior="terminate" should have passed validation and not thrown an error. Packer expects "terminate" not ["terminate"]
Actual behavior

shutdown_behavior="terminate",
TypeError: <class 'packerlicious.builder.AmazonEbs'>: None.shutdown_behavior is <type 'str'>, expected [<type 'str'>]
Steps to reproduce
Set shutdown_behavior="terminate",

See this page for formatting. Looked through packer change log, but haven't found if they recently changed the format.
https://www.packer.io/docs/builders/amazon-ebs.html#shutdown_behavior

@levisbakalinsky v1.0.2 was released w/ this change. Thanks!


Launch Security with AMD SEV

What this PR does / why we need it:
This is a follow-up of the mailing list discussion [0]. The PR introduces new elements in the VMI spec: launchSecurity and sev. By setting those the user can enable guest memory encryption using SEV (Secure Encrypted Virtualization) extension available on AMD's EPYC CPUs [1].
SEV technology has been around for quite some time already and its supported by recent qemu and libvirt [2][3]. There are new extensions like SEV-ES (Encrypted State) and SEV-SNP (Secure Nested Paging) which bring more features. Though this PR focuses on the basic SEV.
[0] https://groups.google.com/g/kubevirt-dev/c/a6XlT0qRNAY/m/Hex2r3lDBwAJ
[1] https://developer.amd.com/sev/
[2] https://libvirt.org/kbase/launch_security_sev.html
[3] https://libvirt.org/formatdomain.html#launch-security
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
The new elements in the VMI spec are currently mapped to what is expected in libvirt domxml. They look like the following:
spec:
  domain:
    launchSecurity:
      sev: {}

In order to enable SEV all virtio devices need to be configured with the iommu='on' attribute in their <driver> configuration. In addition, all memory regions used by the VM must be locked for Direct Memory Access (DMA) and to prevent swapping.
Known limitations (some of them will probably be removed in the future):

Requires AMD EPYC CPU (!)
SEV is only going to work with OVMF (UEFI)
SEV-encrypted VMs cannot contain directly-accessible host devices (that is, PCI passthrough)
Live Migration is not supported

Release note:

Experimental support of AMD SEV

@vladikr who can help to review this pr? Maybe somebody from the capybara team?

/cc @dagrh can you please take a look?

I like that you have names for the policy elements, rather than just relying on the awkward bit mask.
(Which I think is probably also useful in SNP where I think the policy gets more complex).
[I wonder if you need something more abstract as well though (depending on how smart images get) - could we make something where we can ask for confidential computing and it would get the best thing supported by the host; TDX on Intel, SEV.. on AMD? -  anyway that's a more abstract thought].

Hey, @vladikr , @dagrh , thank you for the review comments.

My main concern is the current API. What I don't understand is how the attestation is coming into play here? Perhaps you can elaborate on this?

Initially my idea was as the first step to bring the basic support of SEV memory encryption and address the attestation at a later point. Currently afaik there are still some missing pieces in e.g. libvirt for that. Also for the attestation it would probably be nice to consider various use-cases (SEV, SNP, TDX, ...) in order to have a unified user-facing API. So this is transformig into a bigger topic touching not only the basic SEV. Do you think it makes sense to include attestation right from the beginning?

[I wonder if you need something more abstract as well though (depending on how smart images get) - could we make something where we can ask for confidential computing and it would get the best thing supported by the host; TDX on Intel, SEV.. on AMD? - anyway that's a more abstract thought].

That's a good idea. E.g. if I dont care I can specify smth like:
spec:
  domain:
    launchSecurity: {}

or be more precise to select only SEV:
spec:
  domain:
    launchSecurity:
      sev: {}

The VM can then be scheduled on a node with the corresponding capabilities.

/retest

This should be ready for another review round. @vladikr , maybe you can take one more look when have time? I think all the comments are addressed. Thanks.

/retest

/retest

Some updates: I had to bump the EDK2 rpm here since the original one did not ship the roms with SEV support. Also made node-labeller aware of SEV. The VMs are now scheduled on the nodes with the corresponding label. Still the PR is ready for review. Probably there is some room for discussion around the new VMI spec APIs. PTAL.
Ping @dagrh , @vladikr , @rmohr , @davidvossel . Would appreciate your opinions/thoughts about the PR. Thanks!

/retest

/retest

/retest

/retest

/test pull-kubevirt-e2e-k8s-1.20-sig-compute-nonroot

/test pull-kubevirt-e2e-k8s-1.20-sig-compute-nonroot

@vladikr ,  @jean-edouard , I think all the comments are addressed. Please let me know if I missed something.

@vladikr , @jean-edouard , I think all the comments are addressed. Please let me know if I missed something.

Almost there! I have one last concern on the NIC Rom stuff, please see the corresponding thread.

/approve

/retest

/retest

Rebased the PR. No new code changes.

@vasiliy-ul could you update the PR description? I may be wrong, but it looks like the PR evolved quite a bit since the PR description was last modified :)

Yep, the escription was a bit outdated. Updated.

/retest

Thanks @vasiliy-ul
Looks good to me now.
/lgtm

/hold

uhh I didn't notice it was approved already.
Let's wait for @rmohr to have another look.

Rebased the PR. Apart from renaming the feature gate there are no code changes.

/lgtm

/retest

Is it okay to unhold the PR? @vladikr , @rmohr ?

Is it okay to unhold the PR? @vladikr , @rmohr ?

/unhold
Yes :)

/retest

/retest

/retest

/retest


Solves: https://github.com/prometheus-operator/kube-prometheus/issues/493

@paulfantom and @kakkoyun moved PR here because of the branch naming.

Thank you :+1:


Don't show the stack trace on compilation error in build definition

This pull request hides the stack trace on compilation error in the build definition, as suggested in https://github.com/sbt/sbt/issues/2071.

Can one of the admins verify this patch?

How does output for scalaVersion := "2.11.6".xx look now?
Would it be difficult to add test for this? Could you also add notes in the style of https://raw.githubusercontent.com/sbt/sbt/0.13/notes/0.13.9/distinct-rename.markdown

Catching, logging and rethrowing looks like it would log more!

Could you paste the session of what the user would see for scalaVersion := "2.11.6".xx?

master… foobar ❯ xsbt                                                                                9:15
[info] Loading global plugins from /Users/martin/.sbt/0.13/plugins
[info] Updating {file:/Users/martin/.sbt/0.13/plugins/}global-plugins...
[info] Resolving org.fusesource.jansi#jansi;1.4 ...
[info] Done updating.
[info] Loading project definition from /Users/martin/Documents/Projects/Duhemm/foobar/project
[info] Updating {file:/Users/martin/Documents/Projects/Duhemm/foobar/project/}foobar-build...
[info] Resolving org.fusesource.jansi#jansi;1.4 ...
[info] Done updating.
/Users/martin/Documents/Projects/Duhemm/foobar/Build.sbt:2: error: value xx is not a member of String
    scalaVersion := "2.11.3".xx,
                             ^
sbt.compiler.EvalException: Type error in expression
[error] sbt.compiler.EvalException: Type error in expression
[error] Use 'last' for the full log.
Project loading failed: (r)etry, (q)uit, (l)ast, or (i)gnore?

If the user types l, then the debug log (that contains the complete stack trace) will be shown.
@dwijnand Actually the exception is re-thrown without its stack trace

Ah, that's so uncommon I completely missed it, nice.

I think this LGTM. @jsuereth?

This is merging into 0.13, but has release notes for 0.13.9. Do we want this to merge into 0.13.9, or alternatively should this be fore 0.13.10?

And perhaps we should reference #2071 in the notes.

@dwijnand I've moved the notes and added the reference to #2071, thanks!

LGTM. Thanks.

Thsi LGTM too.


New Ignorebasenamespaces option

Hi all,
I added a new option because in some cases you need to remove the base name of xml request nodes.
With the new option you will be able to set or not the basenamespaces.
Regards,
And thanks a lot to  @jsdevel with his help.

Thanks @lauort !


Add constructor to CoreResponseClassifier that takes status code ranges

This is required for https://github.com/Azure/autorest.csharp/issues/2018

@annelo-msft I do not see any hits for CoreResponseClassifier - https://grep.app/search?q=CoreResponseClassifier&filter[repo][0]=Azure/azure-sdk-for-net. Is this still valid?

This was renamed to StatusCodeClassifier before it GA'ed.

We may need this in ClientModel, if the generator provides custom implementations that are considered "end-of-chain" classifiers -- so that ClientModel can provide an implementation of "is retriable" for the last classifier in a composed chain.
Working with @m-nash to understand the requirements from the generator side -- i.e. what TypeSpec API description causes a custom implementation to be needed.
If the implementation works for both ClientModel and Azure.Core, we can address it in both cases.

reopen


Allow tapping checkbox to untick/tick checkbox

Box image is currently unaligned with the text.

Fixed offset. Doesn't automatically refresh listview of notes when tickbox is unticked from completed notes page. Pull request #10 will fix this issue however.


[D3D9] - Tomb Raider: Legend (7000) - Low performance

Okay, so another game with a performance issue compared to WineD3D. Possibly related to #1682.
Early on in the game, performance mostly reaches my refresh rate of 144hz, however about an hour in, fps drops significantly.
These screenshots are with RADV ACO and RadeonSI, although I also tested LLVM and AMDGPU-PRO with little difference in performance.
DXVK (52 fps):

DXVK with full hud:

WineD3D (132 fps)

EDIT: I also tried dgVoodoo2 as a workaround like in #1675, but it didn't improve things in this case.
Software information
Tomb Raider: Legend (7000), 1440p, maximum settings except "next-gen effects" and "Anti-aliasing" were disabled.
System information

GPU: Radeon RX 5700 XT
Driver: Mesa-git (ACO and LLVM)
Wine version: Proton-GE-5.9-ST-3
DXVK version: 1.7-git (today)

Apitrace file(s)

Windows apitrace

Log files

d3d9.log:
trl_d3d9.log

Can you enable DXVK_HUD=full? It's obvious that the GPU doesn't get utilized at all, but we'd need more info on why that is.

I've added a screenshot with full HUD.

Hm, nothing suspicious there either.
You sure you don't have Vulkan validation layers enabled or compiled Mesa in debug mode or anything?

Not to my knowledge, and most of my games perform well. I did test AMDGPU-PRO, which should perform better if it's something strictly to do with Mesa.
That does give me an idea to test DXVK on Windows to see if it's some issue on the Linux side of things, which I will try and get to a bit later.

So I tested on Windows, this time with the 1.7 binary.
DXVK Windows (61 fps)

Native Windows (176 fps)

Looks like it's locking a POOL_DEFAULT | DYNAMIC texture every frame and needs to synchronize the GPU to do that.

I tried it with DXVK on Windows and it works fine.

What graphics settings are you using?

Can you test if the PR linked above improves things?

It's "Next Generation Content" that works around the issues; it's not recommended because it breaks water effects and the like, but presumably it changes the way rendering works such that it doesn't trigger the bug.
The PR doesn't seem to be helping, but I'm pretty tired so I may have made a mistake. I'll test it again tomorrow with fresh eyes.

I think I found the issue. The updated PR should fix it.

Thanks, the new PR fixes the issue completely :+1:. Game now hitting 155 fps, as opposed to 55fps before, so it's now running faster than WineD3D and approaches Windows performance.
Not only that, it also fixes the issue with The Walking Dead, increasing the performance from 41 fps to >144fps (VSync enabled).

I tried it with DXVK on Windows and it works fine.

What graphics settings are you using?

Can you test if the PR linked above improves things?
Here's a build if you can't build it yourself.
EDIT: turned the game to the lowest graphics settings and now it's running poorly.

Hi Kobin.  I was having the same issue. Are you able to link a 64 bit build as that one comes at as x86 instead of x64.
Thank you for your help :)

The changes will hopefully get merged soon. After that the build bot will give you a 64bit dll.

@K0bin hi! I saw the merge test was cancelled. Any chance of getting the 64 bit build for me to test? Pretty please 🙏

@K0bin @Joshua-Ashton
Hi, Any chance of getting the 64 bit build with these fixes for me to test as i have the same issues on the same games. I saw the test was cancelled for pipeline #1231 so the build bot didn't generate the 64bit dll's.
I'm happy to donate $10 to you via paypal for your time doing this !
Thank you

FYI the game should be even faster now.

Just tested the change, and looks to be quite a massive improvement.
I have a new CPU and I couldn't find my old save game. And I tested Proton 5.0-9 compared to Proton Experimental (so there might have been other changes than the PR) so none of this is quite like-for-like, nevertheless:
Both tests with a 5900x and 5700 XT, mesa-git, 5.9.15 kernel:
Proton 5.0-9 (DXVK 1.7.0):

Proton Experimental:

So from 246 fps to 445 fps, an 80% performance improvement.

The recent changes aren't even in Proton experimental.

Interesting, I thought that at first but assumed the performance increase wouldn't have been so large without it. Will retest.


Add manifest file for Mozilla Firefox (Belarusian) v79.0 x64

[x] Have you signed the Contributor License Agreement?
[x] Have you checked that there aren't other open pull requests for the same manifest update/change?

Microsoft Reviewers: Open in CodeFlow

/azp run


Calling ClipperOffset::Execute multiple times produces incorrect results

Clipper2Lib::Paths64 paths;
Clipper2Lib::ClipperOffset co;

co.AddPath(Clipper2Lib::MakePath("0,0, 10,0, 10,10, 0,10"), Clipper2Lib::JoinType::Miter, Clipper2Lib::EndType::Polygon);

paths = co.Execute(+1);
paths = co.Execute(-1);

for (auto &path : paths)
{
    for (auto &point : path)
    {
        std::cout << point << "  ";
    }

    std::cout << std::endl;
}

Output:
11,-1  -1,-1  -1,11  11,11
9,9  10,9  10,10  9,10
0,9  1,9  1,10  0,10
9,0  10,0  10,1  9,1
0,0  1,0  1,1  0,1

Thanks dev7355608. I'm pretty sure this is an orientation bug. I'll upload a fix shortly.

Not fixed unfortunately.

OK. It's past my bedtime so I'll have another look at this tomorrow.


[FEAT] Filter aggregations

Describe the enhancement
I'd like to be able to do filter aggregations, like so:
"aggs": {
  "my-agg-name": {
    "filter": {
      "bool": {
        "must": [{
          "nested": {
            "path": "someField",
            "query": {
              "bool": {
                "must": [{
                  "exists": { "field": "someField" }
                }, {
                  "term": {"someField.somePath": "someValue"}
                }]
              }
            }
          }
        }]
      }
    }
  },
  ...
}

Why is this needed?
It's an ElasticSearch feature, so it should be in this lib as well.
How do you think it should be done?
I think an extension to AggQuery can be made which uses a BoolQuery as the "body".
Will you be able to help with a pull request?
Maybe.

Cool thanks! That looks like it should work. When I find some time, I'll squeeze in a pull request. Might be a while because I'm super busy right now.


Uncaught Error: ENOENT: no such file or directory, open '/Users/Restuta/.atom/packages/atom-color-highlight/lib/marker-view.coffee'

Steps:

open styles.less
type anything with color like color: blue;

Atom Version: 0.192.0
System: Mac OS X 10.10.2
Thrown From: atom-color-highlight package, v3.0.8
Stack Trace
Uncaught Error: ENOENT: no such file or directory, open '/Users/Restuta/.atom/packages/atom-color-highlight/lib/marker-view.coffee'
At /Users/Restuta/.atom/packages/atom-color-highlight/node_modules/pigments/node_modules/q/q.js:126

Error: ENOENT: no such file or directory, open '/Users/Restuta/.atom/packages/atom-color-highlight/lib/marker-view.coffee'
  at Error (native)
  at Object.fs.openSync (fs.js:544:18)
  at Object.module.(anonymous function) [as openSync] (ATOM_SHELL_ASAR.js:118:20)
  at Object.fs.readFileSync (fs.js:396:15)
  at Object.fs.readFileSync (ATOM_SHELL_ASAR.js:369:29)
  at Object.exports._compileFile (/Applications/Atom.app/Contents/Resources/app/node_modules/season/node_modules/cson-parser/node_modules/coffee-script/lib/coffee-script/coffee-script.js:221:14)
  at getSourceMap (/Applications/Atom.app/Contents/Resources/app/node_modules/season/node_modules/cson-parser/node_modules/coffee-script/lib/coffee-script/coffee-script.js:329:22)
  at getSourceMapping (/Applications/Atom.app/Contents/Resources/app/node_modules/season/node_modules/cson-parser/node_modules/coffee-script/lib/coffee-script/coffee-script.js:337:19)
  at formatSourcePosition (/Applications/Atom.app/Contents/Resources/app/node_modules/season/node_modules/cson-parser/node_modules/coffee-script/lib/coffee-script/coffee-script.js:289:16)
  at /Applications/Atom.app/Contents/Resources/app/node_modules/season/node_modules/cson-parser/node_modules/coffee-script/lib/coffee-script/coffee-script.js:355:34
  at Function.Error.prepareStackTrace (/Applications/Atom.app/Contents/Resources/app/node_modules/season/node_modules/cson-parser/node_modules/coffee-script/lib/coffee-script/coffee-script.js:358:7)
  at trackRejection (/Users/Restuta/.atom/packages/atom-color-highlight/node_modules/pigments/node_modules/q/q.js:988:32)
  at reject (/Users/Restuta/.atom/packages/atom-color-highlight/node_modules/pigments/node_modules/q/q.js:1044:5)
  at _fulfilled (/Users/Restuta/.atom/packages/atom-color-highlight/node_modules/pigments/node_modules/q/q.js:789:20)
  at self.promiseDispatch.done (/Users/Restuta/.atom/packages/atom-color-highlight/node_modules/pigments/node_modules/q/q.js:816:30)
  at Promise.promise.promiseDispatch (/Users/Restuta/.atom/packages/atom-color-highlight/node_modules/pigments/node_modules/q/q.js:749:13)
  at /Users/Restuta/.atom/packages/atom-color-highlight/node_modules/pigments/node_modules/q/q.js:557:44
  at flush (/Users/Restuta/.atom/packages/atom-color-highlight/node_modules/pigments/node_modules/q/q.js:108:17)
  at process._tickCallback (node.js:357:13)

Commands
  3x -6:28.3 tree-view:toggle (div.settings-view.pane-item)
 10x -4:59.2 core:backspace (atom-text-editor.editor.mini)
     -4:09.8 window:toggle-dev-tools (atom-text-editor.editor.mini)
     -3:31.8 core:backspace (atom-text-editor.editor.mini)
     -3:30.2 application:open-your-stylesheet (atom-workspace.workspace.scrollbars-visible-when-scrolling.theme-atom-dark-syntax.theme-one-dark-ui)
  3x -3:28.4 editor:newline (atom-text-editor.editor)
  4x -3:19.2 core:save (atom-text-editor.editor)

Config
{
  "core": {
    "themes": [
      "one-dark-ui",
      "atom-dark-syntax"
    ]
  },
  "atom-color-highlight": {}
}

Installed Packages
# User
atom-color-highlight, v3.0.8
autoclose-html, v0.15.0
autocomplete-plus, v2.11.0
color-picker, v1.7.0
file-icons, v1.5.4
filetype-color, v0.1.4
highlight-line, v0.10.2
javascript-snippets, v1.0.0
jsformat, v0.8.0
language-csharp, v0.5.0

# Dev
No dev packages

I believe you've got this issues after an update?
The marker-view was replaced by marker-element in version 3.0.0 so you must have updated from that version I guess. A restart should fix that, there's still some issue when updating packages in Atom, sometimes the new code doesn't get reloaded and so, if the file structure changes it may raise exception because the old code doesn't find the removed files.

@abe33 restart didn't fix that :(


Remove azdata toast startup notifications

Fixes #11574
Will figure out better way to handle this later - just getting rid of the annoying popup for now.

Coverage increased (+0.005%) to 37.621% when pulling b922891558b0a7507b9ad77874787ee943024718 on chgagnon/removePopup into c06bd0821b12a34073685a276eb40d87cfbca061 on main.


[plugin-vue] Can't use custom compiler

Describe the bug
The compiler default value null results rawOptions.compiler never used.
https://github.com/vitejs/vite/blob/40f98bff7b41c29c0c63297522ffad778e3d4031/packages/plugin-vue/src/index.ts#L91-L100
Reproduction
https://github.com/vitejs/vite/commit/b289b2d433f94949730e1f041f3c8e16c417e9d0#diff-2b066c2eb45a74f1191f8796c6c76a93a7bc81417b11b8852e965aec86be2cc4
System Info
System:
    OS: macOS 12.1
    CPU: (8) x64 Apple M1
    Memory: 36.40 MB / 16.00 GB
    Shell: 5.8 - /bin/zsh
  Binaries:
    Node: 14.18.0 - /usr/local/bin/node
    Yarn: 1.22.4 - /usr/local/bin/yarn
    npm: 6.14.15 - /usr/local/bin/npm
  Browsers:
    Chrome: 97.0.4692.99
    Firefox Developer Edition: 97.0
    Safari: 15.2
  npmPackages:
    @vitejs/plugin-vue: ^2.0.1 => 2.0.1
    vite: ^2.7.13 => 2.7.13

Used Package Manager
yarn
Logs
"Failed to resolve vue/compiler-sfc.\n@vitejs/plugin-vue requires vue (>=3.2.13) or @vue/compiler-sfc to be present in the dependency tree."

Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Make sure this is a Vite issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to https://github.com/vuejs/vue-next instead.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

#6232
#5326

While this does look like a bug, the commit that introduces this issue is https://github.com/vitejs/vite/commit/ce8b0feae334cc224b3f4d2fdb2bffbb62322acf#diff-2b066c2eb45a74f1191f8796c6c76a93a7bc81417b11b8852e965aec86be2cc4R109 not the one in the original post.


fix: default for collaborators set to 1 and added dev tag

Fixes: #780
previously the default number of collaborators was randomised between 8-10, which would cause the collaboration transaction to fail. This PR fixes this issue by setting the default value of collaborations to 1 and adds a dev tag as a visual hint.
now if we directly send with 1 collaborator selected by default the transaction succeeds as expected.
https://github.com/user-attachments/assets/2bb9b413-eeb2-4047-9d93-1549a02bd52f

previously the default number of collaborators was randomised between 8-10, which would cause the collaboration transaction to fail. This PR fixes this issue by setting the default value of collaborations to 1 and adds a dev tag as a visual hint.

Hey @nischal-shetty2! Nice! Thanks for the contribution!
One additional change request is to only apply this when the app is in "dev mode" (as stated in the linked issue).
You can use isDevMode from src/constants/debugFeatures.ts! Would that be possible?

One additional change request is to only apply this when the app is in "dev mode" (as stated in the linked issue). You can use isDevMode from src/constants/debugFeatures.ts! Would that be possible?

Sure i can do that right away!

Hey @nischal-shetty2! Nice! Thanks for the contribution!

This is my first contribution to this repo, and even though it's a small one, I'm glad to start somewhere.
@theborakompanioni, are there any other changes needed?

Hey @nischal-shetty2! Nice! Thanks for the contribution!

This is my first contribution to this repo, and even though it's a small one, I'm glad to start somewhere. @theborakompanioni, are there any other changes needed?

@nischal-shetty2 I do not think the "dev" tag is needed, because this feature is also available in production. Should it be removed? What do you think?
Also, can we use undefined (not '' empty string) for customNumCollaboratorsInput when a user did not touch the input field yet?

I do not think the "dev" tag is needed, because this feature is also available in production. Should it be removed? What do you think?

@theborakompanioni yes, if this is the case in production as well then its definitely not required! I think it would be best not to show the dev tag

Also, can we use undefined (not '' empty string) for customNumCollaboratorsInput when a user did not touch the input field yet?

on it!

@theborakompanioni made the changes, could you review it now!

@theborakompanioni made the changes, could you review it now!

Made some small changes move the dependency on isDevMode from CollaboratorsSelector to the parent component. Other than that, looks good to me! :rocket:
Can you review the changes and verify they work properly on your side as well? Start once with npm run dev:start (changes should apply) and once with npm run start (changes should not apply).

Can you review the changes and verify they work properly on your side as well? Start once with npm run dev:start (changes should apply) and once with npm run start (changes should not apply).

tested it locally on both dev as well as prod and works perfectly! This can be merged now if everything is good!
@theborakompanioni although i noticed one more thing unrelated to this issue, on the Collaborator fees title

is it supposed to be '...' or does it have to show the value like how Number of collaborators title shows us current selected number

Can you review the changes and verify they work properly on your side as well? Start once with npm run dev:start (changes should apply) and once with npm run start (changes should not apply).

tested it locally on both dev as well as prod and works perfectly! This can be merged now if everything is good!

:muscle:

@theborakompanioni although i noticed one more thing unrelated to this issue, on the Collaborator fees title  is it supposed to be '...' or does it have to show the value like how Number of collaborators title shows us current selected number

This should change to something meaningful as soon as you input an amount!

This should change to something meaningful as soon as you input an amount!

yes yes got it, my bad i didnt input the amount field


💭 App crashing after setting FPS and applying frameProcessor to Camera

Question
Hi guys, I was trying to initiate the <Camera> component with setting FPS to 60 and applying a frameProcessor. The app is successfully built after running  npx react-native run-android
However, the application crashed immediately after opening on the emulator. I've tried different types of emulators and it has the same issue occurring. I am confused about this situation as there is no error popping up and I couldn't find any error log that shows the problem of this case.

Everything works fine if frameProcessor is not assigning to <Camera>. Is there any possibility that this issue is caused by the emulator? Please see below my package.json dependencies Thank you.

Please also see be low my error logged from adb logcat
Uploading err.txt…
What I tried
No response
VisionCamera Version
^4.5.3
Additional information

[ ] I am using Expo
[X] I have read the Troubleshooting Guide
[X] I agree to follow this project's Code of Conduct
[X] I searched for similar questions in the issues page as well as in the discussions page and found none.

Guten Tag, Hans here! 🍻 It looks like you’re experiencing a crash when setting FPS and applying a frame processor. However, I noticed that you haven’t provided the error logs from adb logcat, which are essential to diagnose this issue properly.
Please follow these steps to gather the logs:

Open your terminal.
Run the command: adb logcat > error_logs.txt.
After reproducing the issue, paste the contents of error_logs.txt here.

This will give mrousavy the information needed to investigate further! Also, if you find the project helpful, consider supporting it by sponsoring at this link. Thank you!

Note: If you think I made a mistake, please ping @mrousavy to take a look.

Hello, the error log generated from adb logcat is huge, is there any way I can target the log thats regarding the emulator is running the application? Thanks.

I tried to run the app with physical device and it worked. Still have no idea why it won't work with emulator.


fix: eslint and prettier configs

eslint doesn't work at all and causes some issues with Promox & builds. Additionally, we are "blind" for errors. This PR will attempt to fix the config and fix all build errors

Closed because this will be fixed in the new repository only


Save ram in BLE Utils

Within BLE Utils, we create tables of human readable descriptions of services, characteristics and BLE device providers.  There is about 20K of text.  The current implementation references these in structures.  An example of a structure would be:
struct entry {
   std::string description;
   uint16_t id;
};

These would be initialized similar to:
const struct entry myData[] = {
   {"text1", 1}, {"text2", 2}, {"text3", 3} .... {"", 0}
};

The assumption had been that because myData was flagged as a constant,  the data would be readonly.  Readonly data doesn't have to live in RAM but can instead live in flash and hence had no burden on our RAM usage.  However my implementation was horrible ... can you see the problem?  I didn't for the longest time.
Look again at the definition of struct entry:
struct entry {
   std::string description;
   uint16_t id;
};

The problem is std::string ... while this is of course a representation of a text/binary buffer ... it is actually a C++ class object.  What that means is that for every entry in the array, a C++ class instance of type std::string was being created and the text written into the class ... i.e. it was being carved out of the heap!!!
The solution was trivial.  Change the data from "std::string" to "const char *".   The fix for that is coming next....

Changes made ... we now leave this defect open for 14 days to make sure that all is good.

Great work, it saves me about 25kB.

Digging further, we find that coding:
const char* myVar = "My data";

causes the data to be created in initialized RAM
while
const char myVar[] = "My data";

causes the data to be created in read only flash.
We found we could save 500bytes (1/2K) in HttpRequest using this technique.

Howdy @nkolban
Where can I find more details about const char* myVar vs const char myVar[] ?

Howdy my friend.   Not sure what you mean about "more details".   What Ive been doing recently is studying the Linux "nm" command.  When we run this over a compiled source file (an object file) we get a dump of the "nature" of that compiled code.  Have a run of nm over an object file and have a look.  There is a wealth of information "coded" in there.  While working with a chap who needs BLE and WiFi running at the same time, he was running out of RAM so I though I'd take a look at how the cpp_utils classes were using RAM and see if there was any immediate and gross wasteage.
That's where I found that strings defined as:
char *mydata = "hello world";

were mapped to initialized RAM data
while data mapped to
char mydata[] = "hello world";

are mapped to read-only flash.  I'm pretty darn certain this isn't rocket science to those who work in this level of knowledge at all ... and there may be write-ups on it all over the place (if there is, i'd love to hear about them too).

Closing for just now.


Feature

I created an html and css file for my portfolio project

Hi @elfin-git 👋
Good job so far working on the project requirements!
There are some issues that you still need to work on before you can merge. 🤓
To Highlight 🎉
GitHub flow is followed. ✔
Required Changes ♻
Check the comments under the review in the inline comments.

Could you make your READme file more detailed so that your repository could look professional and top notch 🥇 . Check out this template and edit it.
Please add html-Css linters to your project. Linters will help flag errors in your code :) Check out [this repository[(https://github.com/microverseinc/linters-config) and carefully install them.
Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.


Key is missing from returned Query (but appears with lean()!)

Hey guys!
So, I have the following schema:
{
    'version': {
        'type': Number,
        'default': 1
    },
    'user': {
        'type': mongoose.Schema.Types.ObjectId,
        'ref': 'user'
    },
    'date': {
        'type': 'Date',
        'default': Date.now
    },
    'score': {
        'type': Number,
        'default': 0
    },
    'snapshot': {
        'type': Object,
        'default': {}
    },
    'stats': {
        'type': Object,
        'default': {}
    }

And I query it like this:
Score.findOne({'user': req.user._id}).sort('-date').exec(function(err, score){
console.log(score.stats); // returns undefined
});

HOWEVER, adding lean():
Score.findOne({'user': req.user._id}).sort('-date').lean().exec(function(err, score){
console.log(score.stats); // returns the stats object!
});

My initial guess was that stats was a reserved term... but I searched both the API docs and Stackoverflow (and the issue tracker here) and didn't find the word 'stats' mentioned in this context.
Please advise?

Does the snapshot field also disappear? And is this only happening when you save with the default value?

Nope, everything seems to work great except "stats" getting stripped out.
We renamed it "scoreStats" and now the same data works flawlessly (but obviously post launch we don't want to be renaming schemas!)
I just want to get to the bottom of WHY this is happening, and if 'stats' is a reserved mongoose word, make sure it's documented!
@vkarpov15 thanks so much for taking the time to track it down! If you can't reproduce it I can try and make a sample repository this weekend.

Can you tell me what version of mongoose and what version of node? As far as I can tell, stats shouldn't conflict with any function names.

cat package.json| grep mongoose
    "mongoose": "^3.8.24",

node --version
v0.12.0

Also, the one thing that worried me from the mongoose codebase was stuff like this:
https://github.com/LearnBoost/mongoose/blob/3780063b75907687be5a3e2baad7922dc0556067/test/model.geosearch.test.js#L50
Geo.geoSearch({ type : "place" }, { near : [9,9], maxDistance : 5 }, function (err, results, stats) {
// ...
});

Hmm I can't seem to reproduce this. The following standalone script seems to work for me, node 0.12, mongoose 3.8.24, mongodb 2.6.6:
var mongoose = require('mongoose');
var Schema = mongoose.Schema;
var assert = require('assert');
var db = mongoose.createConnection('mongodb://localhost/gh2720');
mongoose.set('debug', true);

var schema = new Schema({ name: String, stats: { type: Object, default: {} } });

var Stats = db.model('gh2720', schema, 'gh2720');
Stats.create({ name: 'Kobe Bryant', stats: { points: 81 } }, function(error, kobe) {
  assert.ifError(error);
  Stats.findOne({ _id: kobe._id }).sort('-name').exec(function(error, doc) {
    assert.ifError(error);
    assert.equal(doc.stats.points, 81);
    db.close(function() {
      console.log('ok');
      process.exit(0);
    });
  });
});

What's your mongodb setup like - what version of mongodb server and are you using a sharded cluster?

Thanks @vkarpov15. Let me reproduce on my end and get you details.
(@danacase and @mikejstein were reproducing it locally with me, in case they want to chime in)

Issue is stale, re-open if this is still a problem.


The category should not be updated for all locales if the admin is updating the category for any specific locale.

Bagisto Version: Master
Steps To reproduce--
1. Log in as an admin.
2. Click on the category inside the catalog section.
3. Click on edit any category.
4. Change the locale and fill all required field
5. Try to view the same category for another locale.
Expected result: The category should not be updated for all locales if the admin is updating the category for any specific locale.
Actual result: The category is updating for all locales if the admin is updating the category for any specific locale.

@Sanjaybhattwebkul
As checked data is saving fine (Name, Description) as per selected locale.
You need to refresh the page at front-end if making change in category slug form admin panel.

@Sanjaybhattwebkul
As checked data is saving fine (Name, Description) as per selected locale.
You need to refresh the page at front-end if making change in category slug form admin panel.

@papnoisanjeev
The category slug should be differnent for all locales.

@papnoisanjeev
Make check for the requested locale only.

@jitendra-webkul
Now, this issue is fixed. so I am closing this issue.


Relax time stamp type assertions to allow ints in the database

[x] capture this with a test

bros merge

@astafan8 did bors just get offended because you called it bros ;)

bors merge


feat(pgdriver): Implement database/sql/driver.SessionResetter

This pull request implements the SessionResetter interface on pgdriver.Conn.
The SessionResetter can be useful to detect a closed or bad connection before we're trying to run queries on it. To make this work, we'd need some way to get the underlying net.Conn from *pgdriver.Conn, so I added a Conn() net.Conn method for that. This is similar to how *pgx.Conn lets you get the underlying *pgconn.PgConn.

Thanks


Allow for other input depths than 3

Hi, this is a feature request:
I'm interested in using a different number of input channels, let's say 5. This could be achieved by reshaping using a 1x1 convolution or by adapting the number of filters in the first convolution. In the latter case there would be no pretrained weights available or one would have to copy the weights from one of the pretrained filters to the added filters for later fine-tuning, which might even be preferable.
Kind regards and a happy new year!

If anyone is looking to do this, the code is something like:
BACKBONE = 'somebackbone'

model_w_weights = sm.Unet(input_shape = (None, None, 3),
                backbone_name = BACKBONE,
                encoder_weights = 'imagenet')

model = sm.Unet(input_shape = (None, None, 5),
                    backbone_name = BACKBONE,
                    encoder_weights = None)

for layer_index in range(len(model_w_weights.layers)):
    if(layer_index < 2 ): continue
    print(layer_index, model_w_weights.layers[layer_index].name, model.layers[layer_index].name)
    model.layers[layer_index].set_weights(model_w_weights.layers[layer_index].get_weights())

del model_w_weights


Client Allocation Request for:

Client Allocation Questions
Core Information

Name:
Website / Social Media:
Region: North America
DataCap Requested: 1TiB
Addresses to be Notarized:
Notary Requested: ozhtdong

@dkkapur Please subscribe to notifications for this Issue to be aware of updates. Notaries may request additional information on the Issue.

Test Issue - please ignote

https://github.com/filecoin-project/filecoin-plus-client-onboarding
I want to create a new issue, but a screen like the attached picture appears and I can't create a new issue.
Do you know how to solve the problem?
please let me know.
(https://user-images.githubusercontent.com/100596255/156727938-136a3a51-2a3f-4f90-aa9d-60aae25d57bf.jpg)

@filstorageok You can use the form on the Filecoin Plus registry app: https://plus.fil.org/
For Clients, Get Verified, General Verification


TagBot trigger issue

This issue is used to trigger TagBot; feel free to unsubscribe.
If you haven't already, you should update your TagBot.yml to include issue comment triggers.
Please see this post on Discourse for instructions and more details.
If you'd like for me to do this for you, comment TagBot fix on this issue.
I'll open a PR within a few hours, please be patient!

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/48676

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/49733

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/54351

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/62761

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/78071

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/86507


Fix logic bugs of FilterCommand classes

Ensure that for FilterInterviewTimeCommand: filter tt/  from/INTERVIEW_TIME-INTERVIEW_TIME
only allows correct date order
is inclusive

resolves #155
resolves #141

LGTM

LGTM


AMBARI-25153. Ambari 2.7.3 web hangs at first step installation wizard

What changes were proposed in this pull request?
Ambari 2.7.3 web hangs at first step installation wizard
How was this patch tested?
manually
Please review Ambari Contributing Guide before opening a pull request.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/5563/
Test FAILed.
Test FAILured.

retest this please

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/5565/
Test FAILed.
Test FAILured.

retest this please

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/5571/
Test FAILed.
Test FAILured.

Failed due timeout. Merging this


The problem about training!

Hello !! I try to run the training program . My GPU card is NVIDIA GTX1080 with 8GB memory. But it always reports cuda out of memory when run the training program .  I try to low down the batch size to 1. But it still report error like this:
RuntimeError: CUDA out of memory. Tried to allocate 118.00 MiB (GPU 0; 7.92 GiB total capacity; 6.24 GiB already allocated; 139.69 MiB free; 304.82 MiB cached)
I try to run the program in a larger memory card, which has 11GB memory. It can start training successfully. But after running several epoch it always make the computer restart. What's wrong with that? Please help! THANKS !

Hi, mei123hao. Sorry for the late response, and hope you have already solved this problem. Maybe you can revise this line for a smaller network. https://github.com/hlwang1124/SNE-RoadSeg/blob/5e15ef16642b6b425c4074e025a1704312d06240/models/networks.py#L108

An inactive issue closed.


Tree structure with recursive grouping

Having the data ungrouped where the grouping field is the parentCode:

0: {code: "ISLA1", description: null, locationLevel: "ISLE", parentCode: "WAREHOUSE"}
1: {code: "ISLA1-S1", description: null, locationLevel: "SECTOR", parentCode: "ISLA1"}
2: {code: "ISLA1-S1-P1", description: null, locationLevel: "POSITION", parentCode: "ISLA1-S1"}
3: {code: "ISLA1-S1-P1-T1", description: null, locationLevel: "STORE", parentCode: "ISLA1-S1-P1"}
4: {code: "ISLA1-S1-P1-T2", description: null, locationLevel: "STORE", parentCode: "ISLA1-S1-P1"}
....
When I use groupKeys: ['parentCode'] I get only 1rst level grouping. I wish it would be recursive like the file explorer example, but starting from ungrouped/raw data.
Is it possible with some current configuration I'm missing? or the data has to be pre-grouped for the tree structure to work?
Thanks!!

for the default grouping, you need to break the code out, eg:
{code1: "ISLA1", code2: "S1", code3: "P1", description: null, locationLevel: "STORE", parentCode: "ISLA1-S1-P1"}
and then groupKeys: ['code1','code2','code3']
i'm not sure that is what you want though, as you are providing it with parent nodes. the grid expects you to only provide leaf nodes, and it works out the intermediary levels.
as this is a question rather than an issue, i'm closing!!! can you use the bulletin board going forward for questions? thanks :)


DEBUG confliction

it looks like below code conflicts with system DEBUG macro and produces a compile error with gcc10.1.0. should we use a different name or remove it given it is not used at all in code anyway?
: error: expected unqualified-id before numeric constant
kafka/KafkaClient.h:198:34: note: in expansion of macro ‘DEBUG’
198 |     static const constexpr char* DEBUG             = "debug";

Thanks, @zjufish!
As you said, the DEBUG is not used anymore, we should just remove it from kafka/KafkaClient.h.

please make a fix and retag. thanks.


why it happen?

Input image shape is: (240, 240, 3)
=> Adding [1] paths, [circle] ...
Segmentation fault (core dumped)

@songyiren98  One of the possible reasons is the version of opencv.
pip install opencv-python==<IP_ADDRESS>  # please install this version to avoid segmentation fault.
Could you please double-check the version? If it still does not work, could you please post your environments (like cuda, pytorch, etc) so that I help debug this problem?

Thank you very much, I will check it.

@songyiren98  I will close this issue since no further discussions. Feel free to re-open it if necessary.


Force usage of time offset in xs:dateTime fields

We should introduce a simple type that forces the usage of time offset (zone) for a date time
  <!-- -->
  <!-- DateTimeWithTimeZone Type -->
  <!-- -->
  <xs:simpleType name="DateTimeWithTimeZone">
    <xs:restriction base="xs:dateTime">
      <xs:pattern value=".*(Z|[+-][0-9]{2}:[0-9]{2})"/>
    </xs:restriction>
  </xs:simpleType>

This could indeed have value as it is currently possible to e.g. send a ExpirationDateTime without offset making it ambiguous how the exact moment in time should be interpreted.
Additionally there were already incompatibilities between implementations because of different number of milliseconds digits in the datetime fields.
E.g. Java sends between 0 and 9 digits of milliseconds depending on which are zero. This can cause issues.
In the original proposed pattern above, the ".*" should be specified exactly:
  <!-- -->
  <!-- DateTimeType -->
  <!-- -->
  <xs:simpleType name="DateTimeType">
    <xs:restriction base="xs:dateTime">
      <xs:pattern value="^(\d{4})-(\d{2})-(\d{2})T(\d{2}):(\d{2}):(\d{2}(?:\.\d*)?)(-(\d{2}):(\d{2})|Z)$"/>
    </xs:restriction>
  </xs:simpleType>


chore(master): release 1.1.229

:robot: I have created a release beep boop
1.1.229 (2023-10-27)
Bug Fixes

deps: update dependency rfc4648 to v1.5.3 (e99b994)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/wayofdev/keywind/releases/tag/v1.1.229 :sunflower:


How to contribute?

Hi there, thanks a lot for sharing this code!  Even if it's currently considered a dead project, I managed to make a bunch of fixes and enhancements and get it plotting some pretty useful graphs.
I would like to share my changes in a way others can use.  Would you be interested in reviving the project?  If so I would be happy to submit pull requests and issues.  Or if not not, maybe I could take over maintainership instead, at least in the short term?
Thanks again!

Hey, I'm glad you like it. If you want to take over maintainership, please go ahead. I'll merge a PR to point the readme at your version if you submit one.

Thanks a lot! I'll do that.


HelpersSlice opacity property missing

It seems that all the properties of the viewer are contained inside the "HelpersSlice", but one option that is mising is to be able to change the slice opacity.

For the moment I don't think you can change the opacity of a slice.
Is the issue the same as this suggestion : https://github.com/FNNDSC/ami/issues/290 ?

@PtiLuky yes, it's the same


chatterbot-register no such file or directory

Hi, chatterbot-register.rb fails on line 72 trying to rename the config file that doesn't exist yet.
I don't know if it's the right way of running the script but I simply copied it into the folder where I wanted my skeleton and ran it.
Error is
chatterbot-register.rb:72:in 'rename': No such file or directory @ sys_fail2 - (/Users/xxx/Workspace/bot/tmp_bot_name.yml, /Users/xxx/Workspace/bot/accountname.yml) (Errno::ENOENT)
I solved it by making it actually write the config file before the rename, I can issue a pull request if needed.
Thanks.

Hey, a PR would be more than welcome. Did you install the gem/etc? If so, you should be able to run chatterbot-register from wherever you like.

Right, issue does not happen installing gem and running the command from any folder. I must have set a different local ruby version (without the gem) inside the folder I was working in and the shell did not recognize the executable. Closing this. Thanks!

[Errno 2] No such file or directory
This messenger compare after I write command
python chatterbot_.py
I work with Atom, and the directory exists.

hello, I followed the tutorial on the official website. It gives me error
on string "database". Syntax error. I do not understand why
Il gio 29 nov 2018, 21:24 Colin Mitchell<EMAIL_ADDRESS>ha
scritto:

@Ico8B https://github.com/Ico8B I'm not entirely sure what you are
trying to do, but this is a ruby project, and since your command involves
Python, I'm guessing it's not an error related to this project?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/muffinista/chatterbot/issues/40#issuecomment-442980340,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AnkZUqx8W-6deWNtYLeVP2B8i5PFx1zuks5u0EJrgaJpZM4HgZKe
.

@Ico8B I'm going to need you to give me a lot more detail about exactly what you're doing, and the full output you get.


Update depreciated CMake version

When building with CMake version 3.27.2 I received this error:
CMake Deprecation Error at build/gcc/_deps/backward-src/CMakeLists.txt:23 (cmake_minimum_required):
  Compatibility with CMake < 3.5 will be removed from a future version of CMake.

  Update the VERSION argument <min> value or use a ...<max> suffix to tell
  CMake that the project does not need compatibility with older versions.

Why did you bump to version 3.14? Because the pull request has no. #314? :wink:

Why did you bump to version 3.14? Because the pull request has no. #314? 😉

3.14 coincides with the version needed for CPM.cmake


Add sorting

Add a sorting config to the python widget for transformed and raw dfs.  This is run after all other steps.
Separately make the frontend manipulate the sorting config via clicking on up/down/x icons in column headers

Done!  Along with sampling that includes the 5 largest and smallest values from each column.


Find and replace need to have folders excluded

Could be excessive in a command line, maybe a configuration file would be better like .gitignore? Folders like vendor should be excluded. Maybe excluded by default?

Also exclude bower_components, node_modules, etc


UTY-420: Unity GDK Tooling in .Net Core - Part 1: Code Generation

Description
Well this was an adventure. A list of changes:

Committed generated code (that someone forgot to do 😠)
Pulled Mono.TextTemplating in as source because their latest Nuget package is like 1.5 years old and doesn't support .Net Core 2.0
Rewrote Improbable.TextTemplating using the Mono.TextTemplating source!
Moved GdkCodeGenerator into its own folder to separate from the other projects in the sln
Twiddled the csproj files to work with dotnet.
Ensured that the End2End tests work with dotnet
Updated the spatialos*build.json files to use dotnet
Update the CI build scripts.
Update the documentation

A caveat, currently any changes to Improbable.TextTemplating or Mono.TextTemplating will require the user to manually copy over the dll files. If we try to do this automatically, MSBuild locks itself due to the UsingTask declaration in GdkCodeGeneration.csproj.
Tests
Ran dotnet test on both GdkCodeGenerator.csproj and Tests.csproj in the End2End repository.
Documentation
Re-pointed links and updated setup guide.
Primary reviewers
If your change will take a long time to review, you can name at most two primary reviewers who are ultimately responsible for reviewing this request. @ mention them.
@jared-improbable @samiwh

I added the steps to install .NET Core with the Visual Studio install, but will also include .NET Core 2.x explicitly as a dependency

Closing both .NET Core PRs in favor of: https://github.com/spatialos/UnityGDK/pull/73
Sorry @jamiebrynes7: just couldn't get CI to pass without merging both PRs together and adding some additional fixes


⚠ ClamAV has degraded performance

In 5411a30, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 582 ms

Resolved: ClamAV performance has improved in 921cde5.


About Dice Loss

Thanks for sharing code, your paper is amazing. I am currently working about it for my course project and I noticed that bratsDiceLoss in bratsUtils.py was divided 5. I thought there was not much influence will be resulted by changing the denominator but  I am still wondering if there any meaning of setting this denominator?
Thank you very much.

Hi @snilloO
You are right, this denominator does not have much effect. I originally used it because I summed 5 losses. However, when using the Adam optimizer, it is just a constant factor and not that important anyways.


A way to access restler.data and restler.file

I'm still using both requite('restler-q') and requite('restler') as I need the latter to access data and file… would it make sense to make them visible in the wrapper, so that restler wouldn't need to be a direct requisite no more? (with no need to wrap anything in those)

This is addressed, as well as a few other things, in my fork of this repository. https://github.com/gradecam/restler-q


Update bursty_traffic_test.go

cisco-dp-1.11-uprev

Pull Request Functional Test Report for #1677 / 51e937c55329c7f632866233c1b01a102c9b24c4
No tests identified for validation.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
23 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.05%) to 47.896%

Files with Coverage Reduction
New Missed Lines
%

topologies/binding/options.go
23
41.82%

Totals

Change from base Build<PHONE_NUMBER>:
-0.05%

Covered Lines:
1320

Relevant Lines:
2756

💛  - Coveralls


Real-esrgan taking more time than usual

Describe your environment

GPU: RTX 3090
VRAM: 24GB
CPU arch: [x86/arm]
OS: Linux
Python: Anaconda

Describe the bug
I have tried Real-esrgan on local system and on Replicate demo as well. Usually it is able to upscale 2x in 5-7 seconds. But when I am adding upscaling option in dream API, it is taking 13-15 seconds on average. This becomes a problem when the iteration count is above 3 as it takes a long while to give outputs.
Any idea what I am doing wrong?
My configuration for upscaling is:
gfpgan_strength = 0
upscale_factor = 2
upscale_strength = 0.75

@blessedcoolant, do you have any insights into why this is occurring?

Let me do some testing to see if I can repro this.

Is it tiling when the inference for real esrgan happens?

I don't see any tiling as such. It's just that the real esrgan is taking more time than stable diffusion for upscaling. Almost 13 seconds per image.. That too on a 3090 GPU. Which GPU did you use for the testing?


Speculative Support for Source Files + New Sdk + net35/net45

This pr attempts to add support for source files when using the new sdk to build net monikers e.g. net35.
🙏 🤞
I've have seen no documentation if this is supported, nor have I found any issues disproving it. I'm going to conclude this is a very niche request i.e we have an application that needs to support net35 and netcoreapp.
Hopefully this pr triggers the CI server, so that I can test using completed packages.

FYI - this totally works.

Looks good, thank you!


Unexpected ForceReply markup behavior in group chat

Steps to reproduce
Sending message in private chat works ok. Sending equal message in group not works as expected.
public static ReplyMarkup ForceReply { get; } = new ForceReply
   {
        Force = true,
        Selective = true
   }

public static async Task BeginSendingAction(TelegramBotClient bot, Message message)
   {
        await bot.SendChatActionAsync(message.Chat.Id, ChatAction.Typing);
        await bot.SendTextMessageAsync(message.Chat.Id, "_Type your message_", true, false, message.MessageId, Keyboards.ForceReply, ParseMode.Markdown);
   }

public static async Task BeginSendingAction(TelegramBotClient bot, CallbackQuery callbackQuery)
    {
        await bot.SendChatActionAsync(callbackQuery.Message.Chat.Id, ChatAction.Typing);
        await bot.SendTextMessageAsync(callbackQuery.Message.Chat.Id, "_Type your message_", true, false, callbackQuery.Message.MessageId, Keyboards.ForceReply, ParseMode.Markdown);
    }

Expected  behavior
Expected force replied message from bot in all chats.
Actual behavior
Message from bot replied in private chat only.
Environment data
NuGet Package Version: (11.0.0 beta 4)
.NET Version: (4.6)
IDE: (VS2015)
App: (Desktop,  Android)

Dear a-a-k,
I might be misunderstanding your question, but I think this might be an issue where you assume something different than the Bot API. Please contact https://telegram.me/BotSupport, they will probably be able to help you with your problem.
If the problem is not caused by the library, please close this issue, otherwise clarify how this problem comes from the library.
Kind regards,
Martijn Verbakel

It solved by set for the Selective property false value.


use time.NewTimer instead of time.After

Using time.After enqueues an entry in Go's runtime scheduler and doesn't garbage collect it even if the function the timer was fired from terminates.
As a result, there can be a temporary high memory pressure and it degrades performance.
Replaced all places where time.After was used except in places where we use it for timing periodical processes (hence, in those places, time.After can only fire when the previous one finishes).
Signed-off-by: Yacov Manevich<EMAIL_ADDRESS>

LGTM! Would be nice to see this enhancement on the FSC code as well. :)

https://github.com/hyperledger-labs/fabric-smart-client/pull/320

there are still two places where time.After is used:
* token/core/identity/msp/idemix/cache.go

* token/services/certifier/interactive/client.go

Correct:
In token/services/certifier/interactive/client.go the time.After is used to make the loop iterate. It means that when the i'th time.After fires, all previous time.After have been garbage collected, and that there can only be a single time.After at a time. This is when can should use time.After without any implications.
In token/core/identity/msp/idemix/cache.go I didn't change here, because this PR already changes this and I don't want a merge conflict.


Embeds are assumed to have the same name as their type

We currently assume embedded records have the same name as their type.
But if we had a user model and a pet model and the user called its pet something else, like this:
// user.js
...
myGreatPet: DS.attr('pet', {async:true}

Then the incoming JSON would look like:
{
  id: 'user-id',
  ...
  _embedded: {
    myGreatPet: {
       id: 'pet-id',
       name: 'fido'
    }
  }
}

And it would get restructured into:
{
   user: {
   }
}

dupe of #7


Share button is not appearing on Firefox

Describe the bug
No share button appears where it should be (in the top right corner beside search). The setting is enabled but nothing appears.
Screenshots

Enviroment (please complete the following information):

OS: Ubuntu 16.04 on VPS
Browser: Firefox

Used app version:

docker-nightly

*** Just checked in Chrome, Share button appears and shows up fine. Must be a Firefox only issue.
Using Firefox Nightly.

Hi,
Unfortunately I could not reproduce so far. (Using Firefox stable and nightly)
I suspect that this might be a configuration error. It might happen that the configuration could not go successfully through when using UI ( but It looks like as it was successful)
Can you check if the config is successfully set?
So like:

the config.json says that Client.Sharing.enabled is true

and also Client.authenticationRequired=true  as you need login for the sharing function
and also Server.databse.type is 2(mysql) or 3(sqlite) as you need DB for sharing

also after you set the config on the UI and refresh the page, does the settings stay enabled?
you can also try setting Server.log.level=6 to enable full server side logging. (Then you can inspect the logs with docker logs <containerId>)

Ah! I got it.
The share button gets stuck in my uBlock origin filters it seems. Those filters are meant to block Facebook/Twitter/etc sharing modules but it seems this one gets put into the mix because of the class names and wording.
Thanks for the help nevertheless!

Hi
Is this a custom uBlock settings or a relatively common one?
(I tried to reproduce, but I could not.) If it is a common I can try to fix it.

Same issue seen using Adblock Plus on Firefox on Ubuntu


ES 6 module exporting ES 6 class not correctly parsed

The code below will generate a module page "test" with the title "Class: module:test" and an undocumented constructor with content "new module:test()" but also a separate class page "Test" with the actual constructor documentation.
/** @module */

/** Test class */
export default class Test {

  /** Test constructor */
  constructor(test) { }
}

This is on released jsdoc 3.4.0.

+1 I just ran into this.
If you remove the export keyword, it works fine. So the bug has to do with the export.

Confirmed. It looks like we're setting the wrong longname for the class in this case. I'll investigate.

I also noticed that exporting an anonymous class is problematic. This code:
/** @module */

/** Test class */
export default class { }

Results in TypeError: Cannot read property 'type' of null at astnode.js:113.
I'll try to make proper test cases out of these.

I find it hard to understand where to add tests for "implicit" parsing like this where there is no export jsdoc tag. The spec exportstag.js only seem to consider the explicit use of the jsdoc tag and should perhaps stay that way?

The crash should be fixed on master. (That commit shows you how I handle test fixtures for things like this.) The original issue still remains to be fixed.

The original issue is now fixed on master. JSDoc 3.4.1 will include the fix.


WTH does this mean?

[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 592ebebd-cf8b-9621-efdd-08c159f7e716
Version Independent ID: a6722576-e4e4-e7d1-34b1-f2a5074534e9
Content: Compiler Warning (level 3) C4192
Content Source: docs/error-messages/compiler-warnings/compiler-warning-level-3-c4192.md
Product: visual-cpp
Technology: cpp-diagnostics
GitHub Login: @corob-msft
Microsoft Alias: corob

@AJMauger
Sorry it's giving you difficulty. The article does make some assumptions that you know something about type libraries and how they're defined and used. Can you be more specific about what you were expecting to find, that isn't explained here?


[unityhub] Failed to initialize Unity graphics

Describe the bug
After recent nixos rebuild --upgrade Unity doesn't starts anymore.
To Reproduce
Start any unity project using any unity version (tested with 2019, 2020 LTS, and 2020 beta versions)
Expected behavior
Start Unity engine.
Screenshots

Additional context
Tested using unityhub stable and unstable
Notify maintainers
@tesq0 @mkg20001
Metadata

system: "x86_64-linux"
host os: Linux 5.4.69, NixOS, 21.03pre249162.1dc37370c48 (Okapi)
multi-user?: yes
sandbox: yes
version: nix-env (Nix) 2.3.8
channels(greg): "home-manager, nixos-21.03pre249162.1dc37370c48"
channels(root): "nixos-21.03pre249162.1dc37370c48"
nixpkgs: /nix/var/nix/profiles/per-user/root/channels/nixos

Maintainer information:
attribute: unityhub

If you've installed it via nix-env then re-install it, it fixed graphics segfaults with many packages for me

@mkg20001 thanks for the tip, it was not installed via nix-env, but I removed ran a nix-collect-garbage -d and installed again is configuration.nix and it didn't work :/
This is my config: https://github.com/ericdallo/dotfiles/blob/master/nix/configurations/desktop.nix#L38

For anyone having this issue, I solved after removing the ~/.config/unityhub and ~/.config/unity3d folders :)


Extend Cardano ThreadNet tests so that Shelley era contains active stake pools

Fixes #2388.
The big commit could be decomposed a little, but the excess diff I'm thinking of is mostly minor (whitespace/renaming/adding one param to testGenTxs etc) and localized -- it's obvious when you see it. Please ping me if the decomposition would be worthwhile by making your review that much easier.
cc: @edsko FYI

I force pushed updated commits: they now extend origin/master and reflect Thomas' comments.
I think it's ready for merge, as long as @nc6 doesn't see any problems/simplification opportunities in the transaction created in the new lines of ouroboros-consensus-cardano/test/Test/ThreadNet/TxGen/Cardano.hs.

I rebased onto origin/master -- no conflicts, everything built locally 👍

@nc6 Thanks for your eyes! I expanded comments a bit in response to (most of?) your questions/observations.

bors r+

Doh! I currently have terrrrible wifi, so I'm unable to fetch the new deps to update my nix-shell to build locally. So I've pushed up a one line change (adding import qualified Shelley.Spec.Ledger.OverlaySchedule as SL). I'm hoping that suffices.
If not, I'll have to wait until the next chance I get an hour or so to kill while keeping the sleeping puppy company.

Doh! I currently have terrrrible wifi, so I'm unable to fetch the new deps to update my nix-shell to build locally. So I've pushed up a one line change (adding import qualified Shelley.Spec.Ledger.OverlaySchedule as SL). I'm hoping that suffices.
If not, I'll have to wait until the next chance I get an hour or so to kill while keeping the sleeping puppy company.

You don't have to feel obligated to finish this PR during your vacation, on the contrary, ignore it completely until you're back :slightly_smiling_face:

bors r+

bors retry


Update export.py

Replaced depreciated 'from sklearn.externals import six' with 'import six'

Fixed a dependency.


Superb iV: some statistics to take into account

Hi,
I decided to collect some mqtt communication logs from the application. Here I put some filtered content (basically what mqtt_message.py script prints) for SUBSCRIBE messages:
[SUBSCRIBE] sent topic filters: '', 'bee240-dd09-4d56-8d8b-fbdfxxxxxxxxx/TMBAZZZZZZZZZZZZZ/account-event/privacy'
[SUBSCRIBE] sent topic filters: '', 'bee240-dd09-4d56-8d8b-fbdfxxxxxxxxx/TMBAZZZZZZZZZZZZZ/operation-request/air-conditioning/set-target-temperature'
[SUBSCRIBE] sent topic filters: '', 'bee240-dd09-4d56-8d8b-fbdfxxxxxxxxx/TMBAZZZZZZZZZZZZZ/operation-request/air-conditioning/start-stop-air-conditioning'
[SUBSCRIBE] sent topic filters: '', 'bee240-dd09-4d56-8d8b-fbdfxxxxxxxxx/TMBAZZZZZZZZZZZZZ/operation-request/auxiliary-heating/start-stop-auxiliary-heating'
[SUBSCRIBE] sent topic filters: '', 'bee240-dd09-4d56-8d8b-fbdfxxxxxxxxx/TMBAZZZZZZZZZZZZZ/operation-request/charging/start-stop-charging'
[SUBSCRIBE] sent topic filters: '', 'bee240-dd09-4d56-8d8b-fbdfxxxxxxxxx/TMBAZZZZZZZZZZZZZ/operation-request/charging/update-battery-support'
[SUBSCRIBE] sent topic filters: '', 'bee240-dd09-4d56-8d8b-fbdfxxxxxxxxx/TMBAZZZZZZZZZZZZZ/operation-request/vehicle-access/honk-and-flash'
[SUBSCRIBE] sent topic filters: '', 'bee240-dd09-4d56-8d8b-fbdfxxxxxxxxx/TMBAZZZZZZZZZZZZZ/operation-request/vehicle-access/lock-vehicle'
[SUBSCRIBE] sent topic filters: '', 'bee240-dd09-4d56-8d8b-fbdfxxxxxxxxx/TMBAZZZZZZZZZZZZZ/operation-request/vehicle-services-backup/apply-backup'
[SUBSCRIBE] sent topic filters: '', 'bee240-dd09-4d56-8d8b-fbdfxxxxxxxxx/TMBAZZZZZZZZZZZZZ/operation-request/vehicle-wakeup/wakeup'
[SUBSCRIBE] sent topic filters: '', 'bee240-dd09-4d56-8d8b-fbdfxxxxxxxxx/TMBAZZZZZZZZZZZZZ/service-event/air-conditioning'
[SUBSCRIBE] sent topic filters: '', 'bee240-dd09-4d56-8d8b-fbdfxxxxxxxxx/TMBAZZZZZZZZZZZZZ/service-event/charging'
[SUBSCRIBE] sent topic filters: '', 'bee240-dd09-4d56-8d8b-fbdfxxxxxxxxx/TMBAZZZZZZZZZZZZZ/service-event/departure'
[SUBSCRIBE] sent topic filters: '', 'bee240-dd09-4d56-8d8b-fbdfxxxxxxxxx/TMBAZZZZZZZZZZZZZ/service-event/vehicle-status/access'
[SUBSCRIBE] sent topic filters: '', 'bee240-dd09-4d56-8d8b-fbdfxxxxxxxxx/TMBAZZZZZZZZZZZZZ/service-event/vehicle-status/lights'

There are two differences to what library sends (besides that a lot of messages are missing for Superb iV):

message start-stop-auxiliary-heating is done for auxiliary-heating operation, the library does it for air-conditioning
there is no service-event/departure request in the library

Please, let me know if more data is needed, I can also send/attach full logs from my mitmproxy run.

actually I can see the difference - our lib is subscribed to "air-conditioning/start-stop-auxiliary-heating" but probably it should be "auxiliary-heating/start-stop-auxiliary-heating". I will test it tomorrow

@fursov thanks for your findings. I have somehow missed the auxiliary-heating endpoint when analyzing my logs from mitmproxy. Tested it today and finally I'm receiving state updates in MQTT when auxiliary-heater is started or stopped. I have also added service-event/departure endpoint to the library but that one is not used by any function yet..

@prvakt do you know if we have an endpoint that sends event when car position changes? Currently I have one automation that is coupled to the car position, would be nice if this is pulled/informed by the server, not by periodic polling from the HA integration.

@fursov I'm not aware of any MQTT endpoint which can provide position on the fly without request. I can try tomorrow to start MQTT listener before driving with my car , maybe something will show up in the logs

You might want to try if maybe subscribing to mqtt wildcard topics works.
I have not tried this myself, but maybe you can subscribe to 'any topics for my VIN'
https://www.hivemq.com/blog/mqtt-essentials-part-5-mqtt-topics-best-practices/

@fursov sorry it took me more than I expected but I have some good news .. there is a MQTT message published to departure topic with name=departure-status-changed whenever I start the car or stop the car...
Message (service-event) received for TMBXXXXXXXXXXXXXX on topic departure: b'{"version":1,"traceId":"XXXXXXXX-XXXX-XXXX-XXXX-XXXXXXXXXXXX","timestamp":"2024-11-14T16:34:33Z","producer":"SKODA_MHUB","name":"departure-status-changed","data":{"userId":"XXXXXXXX-XXXX-XXXX-XXXX-XXXXXXXXXXXX","vin":"TMBXXXXXXXXXXXXXX"}}'

I think we can easily use this message to trigger update of specific sensor inside HA, will have a look tomorrow

@fursov: position update is already implemented in myskoda 0.12.0 and for HA there is a PR #289 waiting to be approved

@prvakt Thanks a lot for this work! Very much appreciated!

Can this be closed?

Yes, thanks for reminding!


document openRight openLeft props

closes #309

This would be very helpful for a number of people I'd imagine, as I had to search to learn about this.


[MGDOBR-778] Kustomize overrides all the namespaces - fix knative and istio

MGDOBR-778
I know it's not ideal, but many others have the same issue https://github.com/kubernetes-sigs/kustomize/issues/880
PR owner checklist
Please make sure that your PR meets the following requirements:

[ ] Your code is properly formatted according to this configuration.
Run mvn clean verify -DskipTests so that imports are correctly set.
[ ] Your commit messages are clear and reference the JIRA issue e.g: "[MGDOBR-1] - $clear_explanation_of_what_you_did"
[ ] The layers in the kustomize folder have been updated accordingly.
[ ] All new functionality is tested
[ ] Pull Request title is properly formatted: MGDOBR-XYZ Subject
[ ] Pull Request contains link to the JIRA issue
[ ] Pull Request contains link to any dependent or related Pull Request
[ ] Pull Request contains description of the issue
[ ] Pull Request does not include fixes for issues other than the main ticket

PR reviewer(s) checklist

[ ] Check if code and Github action workflows have been modified and if the modification is safe
[ ] If the modification is safe, add the safe to test label

How to trigger pipelines and use the bots:

Run the end to end pipeline
Annotate the pull request with the label: safe to test. If you want to run the pipeline again, remove and add it again.

Rebase the pull request
Comment with: /rebase.

Deploy BOT
Comment with `/deploy <dev,stable> when the PR has been merged to deploy to a target environment.

/deploy dev


Function get_task_list(self, list_id, item_count=200, include_archived=False) is not accessible

It is redefined few lines later by
def get_task_list(self, list_id, task_list_request=None)

Thank you for your contribution to improving the library.  Use method def get_task_list(self, list_id, task_list_request=None)  instead of get_task_list(self, list_id, item_count=200, include_archived=False) , it was deleted in version 2.27.0


Add the fuzz feature, which enables afl

Coverage decreased (-0.2%) to 93.924% when pulling 2e2cdb564be6be1d4c19d41cbc5394dcb86ca05d on afl into 9779a63e2d65a31114550b6a37e85dcc983fb7c5 on master.


Cleaned Tabular NN code

Issue #, if available:
Description of changes:
Cleaned Tabular NN code
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Job PR-298-2 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-298/2/index.html


Export to PNG with multiple pages specified

The documentation should reflect how the action behaves when provided with an array of pages and the export format is PNG.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: d92e4209-59ef-2aed-dd62-b38c443d96d3
Version Independent ID: ba65faca-8ef1-3cb3-3a32-bc23fbb1e64c
Content: Export and email a report with Power Automate - Power BI
Content Source: powerbi-docs/collaborate-share/service-automate-power-bi-report-export.md
Service: powerbi
Sub-service: pbi-collaborate-share
GitHub Login: @maggiesMSFT
Microsoft Alias: maggies

Thanks for your comment, @GitWesDone. This issue has been assigned to the doc author for review.

Hi @GitWesDone, I have created a work item to find the answer to your question and to update the documentation. I'll put your revised title in the item. I can't give an ETA when we'll update the doc though because we have a backlog. But now your comment is in a system where we can track it more easily. I have also make a note to update this issue when we've made the update, so you should hear about it.
If you need the answer now, then I suggest you give the Power BI Community our support page a try. In the meantime I am going to close this issue here. Thanks!


replace name2 only if ligature is supported

What are you trying to solve here?

A JS error that name2 doesn't exist in the page so its throwing an error/warning. name2 only exists if ligature is true (lines 76-78)

Thanks!