Zabbix Graph period in telegram not showing data more the one hour

Hi, I am able to send graphs to telegram but graph period is showing from the last one hour.
I have changed in the python script as well even added period in while configuring Actions but still, I am seeing last one hour graph only.
As per zbxtg.py
"zbxtg_image_period": "86400",
actions in zabbix:
Last value: {ITEM.LASTVALUE1} ({TIME})
zbxtg;graphs
zbxtg;graphs_period=86400
zbxtg;itemid:{ITEM.ID1}
zbxtg;title:{HOST.HOST} - {TRIGGER.NAME}
May be I am doing something wrong. Kindly help to fix this.

@hitesh240989 which version of zabbix server?

Dear Ableev,
Zabbix Version: 4.0.6

Hi Ableev,  I have referred to one of your old post related to the same issue.
Below change in python script has fixed the issue for me.
    zbx_img_url = self.server + "/chart3.php?**period={1}**&name={2}" \

-----Changed to below-----
   zbx_img_url = self.server + "/chart3.php?**from=now-{1}&to=now**&name={2}" \

Thank you.

@hitesh240989 , what will you do next time?
https://github.com/ableev/Zabbix-in-Telegram/blob/master/zbxtg_settings.example.py#L22
Try this.


Allow Container based instantiation

Write now class instances are instantiated using Activator.CreateInstance. Allow consumers to plug in their favorite IoC container to resolve instances

not going to do this for now. Clients can implement a blueprint


Web app shows white screen on mobile devices

Steps to Reproduce

Run flutter channel master.
Run flutter upgrade.
Run flutter config --enable-web.
Run flutter create mywebapp.
Run cd mywebapp.
Run flutter build web.
Deploy to server or host locally (e.g. cd build\web and `http-server).
Connect to server from browser on mobile device (Android/iOS).

Expected results:
I expect to see the default counter app in the mobile browser (Chrome/Safari).
Actual results:
I see just a white screen. The pages are being downloaded from the server, but I get a white screen on Android and iOS Mobile browsers.
It works fine if I connect to the server from Chrome in Windows.
Update: Switching to beta channel resolves the issue.

Logs
flutter analyze output:
Analyzing mywebapp...
No issues found! (ran in 12.6s)

flutter doctor -v output:
[√] Flutter (Channel master, 1.19.0-4.0.pre.67, on Microsoft Windows [Version 10.0.18362.836], locale en-CA)
    • Flutter version 1.19.0-4.0.pre.67 at C:\_code\sdks\flutter
    • Framework revision f2320c3b7a (14 hours ago), 2020-06-04 14:45:17 -0700
    • Engine revision 859d892f1f
    • Dart version 2.9.0 (build 2.9.0-13.0.dev 54adfeb93f)

[√] Android toolchain - develop for Android devices (Android SDK version 29.0.3)
    • Android SDK at C:\_code\sdks\android
    • Platform android-29, build-tools 29.0.3
    • ANDROID_HOME = C:\_code\sdks\android
    • Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 1.8.0_212-release-1586-b04)
    • All Android licenses accepted.

[√] Chrome - develop for the web
    • Chrome at C:\Program Files (x86)\Google\Chrome\Application\chrome.exe

[√] Android Studio (version 3.6)
    • Android Studio at C:\Program Files\Android\Android Studio
    • Flutter plugin version 44.0.2
    • Dart plugin version 192.7761
    • Java version OpenJDK Runtime Environment (build 1.8.0_212-release-1586-b04)

[√] VS Code (version 1.45.1)
    • VS Code at C:\Users\Brent\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension version 3.11.0

[√] Connected device (2 available)
    • Web Server • web-server • web-javascript • Flutter Tools
    • Chrome     • chrome     • web-javascript • Google Chrome 83.0.4103.97

• No issues found!

Switching to beta channel and back to master resolved the issue.


Entries for third-party crates in the policy table should be version-associated

In #363, we're removing dependency-criteria from the audit table. In its place, we're allowing third-party crates to appear as keys in the policy table. In that issue, @hpenne pointed out that this loses some precision since the usage of a crate referenced in a dependency-criteria downgrade could change.
I don't think it's super likely, but conceptually it does seem to me that entries for third-party crates in the policy table should be associated with specific versions. My strawman put for the semantics is that policy entries for third-party crates need to have the version as part of the key, e.g. [policy.foo-1.2.3]. To avoid the footgun where an update unintentionally causes such entry to become inapplicable, we can require that if you have a policy entry for one version of a third-party crate, you must have one for all versions that appear in the crate graph.
@mystor WDYT?

We could do something like that. I think it'd probably be written like [policy.foo."v1.2.3"] or similar.
One thing which is slightly awkward about this approach is that we already have audit-as-crates-io in the policy table, which in general should apply to all versions and marks a crate as third-party, though I suppose we could require enumerating the versions to specify audit-as-crates-io as well.

One thing which is slightly awkward about this approach is that we already have audit-as-crates-io in the policy table, which in general should apply to all versions and marks a crate as third-party, though I suppose we could require enumerating the versions to specify audit-as-crates-io as well.

Didn't #366 enforce that audit-as-crates-io only be used on first-party crates?

It's possible that there are multiple versions of a crate in the tree, one of which is "first-party" and needs to be marked with audit-as-crates-io, and the other is "third-party" and is on crates.io. We also start treating crates which are marked as audit-as-crates-io = true as-if they were "third-party" in most of the codebase.

I see. I guess my mental model is that the non-versioned entries would apply to first-party crates and the versioned entries would apply to third-party crates. So if you set policy.foo.audit-as-crates-io = true, that would apply to one or more first-party version and force them to be treated as third-party versions, at which point the rules around consistently-specifying dependency-criteria across active third-party versions would apply.

Are there any good real-life examples I can look at where people are using dependency-criteria to meet/configure particular goals? I'm wondering whether it would be more ergonomic to, instead of specifying separate tables of crate versions (i.e. crate.version.policy), specify a set of versions that should all use a particular policy and change the crates to specify an array of policies (e.g. crate[].policy, with policy optionally having a versions array).
I think the latter would be more ergonomic if it's likely/common for the same policy to be applied to the accepted versions of the crates (as opposed to copying the same thing repeatedly in the former case). The latter is also a "superset" of the ergonomics of the former, since you can still separate per-version policies if you want.

Are there any good real-life examples I can look at where people are using dependency-criteria to meet/configure particular goals?

There are a few in our config.toml.

I'm wondering whether it would be more ergonomic to, instead of specifying separate tables of crate versions (i.e. crate.version.policy), specify a set of versions that should all use a particular policy and change the crates to (optionally) specify an array of policies (i.e. crate[].policy, with policy optionally having a versions array).
I think the latter would be more ergonomic if it's likely/common for the same policy to be applied to the accepted versions of the crates (as opposed to copying the same thing repeatedly in the former case). The latter is also a "superset" of the ergonomics of the former, since you can still separate per-version policies if you want.

I suspect that, for the case where we're putting this information in config.toml, the ergonomics will be a wash because you'll mostly just have a single version. When you upgrade the crate from version X to version Y, you'll just simultaneously tweak the version in the existing entry (because, unlike audits, config.toml is repo-private and doesn't need to be append-only).
No strong priors on either of the two syntactic approaches. Would need to think through the interaction with the requirement that third-party policy entries specify a version, and the edge case where some versions are first-party and others are third-party.

I was going to implement a scheme like [policy.foo."v1.2.3"], but realized that in the presence of continued support for [policy.foo] it will be kind of messy.
This is because in the TOML data model those together would unroll
[policy.foo]
criteria = "safe-to-deploy"

[policy.foo."v1.2.3"]
criteria = "safe-to-run"

to (the equivalent):
[policy.foo]
criteria = "safe-to-deploy"
"v1.2.3" = { criteria = "safe-to-run" }

So when deserializing, we're left with searching through the keys to find those which match a version pattern and treating them differently.

Some alternatives:
version table
[policy.foo]
criteria = "safe-to-deploy"

[policy.foo.version."1.2.3"]
criteria = "safe-to-run"

which turns to
[policy.foo]
criteria = "safe-to-deploy"
version = { "1.2.3" = { criteria = "safe-to-run" } }

The naive implementation for this would be a bit awkward, as you'd end up with PolicyEntry containing another map to PolicyEntry. It shouldn't be recursive, it should only allow version at the top level, so a better implementation would use separate types for those (likely just composing the versioned policy entry type into the top-level type).
Policies as an array (as stated previously)
[[policy.foo]]
criteria = "safe-to-deploy"

[[policy.foo]]
version = "1.2.3" # could allow arrays, too
criteria = "safe-to-run"

This has the downside of not properly representing the uniqueness of policy entries: someone could define a particular version multiple times (including the "no version" case).
Empty version for top-level (first-party) policies
[policy.foo.""] # or [policy.foo.any], [policy.foo.first-party], [policy.foo.direct]?
criteria = "safe-to-deploy"

[policy.foo."1.2.3"]
criteria = "safe-to-run"

This structure is more consistent, but makes the no-version policy a bit awkward and still requires a "keyword" that has special treatment (though since the versions are semver at least you can guarantee no conflict).

My preference is probably the version table, as I'd prefer the data constraints be represented in TOML itself rather than implementing them as an additional validation step.

Version table SGTM. We can require that version entries exist only for third-party crates in the project graph. I agree it should be a separate subtype that only supports dependency-criteria.
I'm a little torn as to whether we should introduce a separate explicit representation for this kind of weakening per #381, which would eliminate the only use-case for cramming third-party information into the policy table. But I think that's probably over-designing it at this stage, and we can just do the simple and intuitive thing for now.

After some discussion with @mystor, we're thinking that since the versioned policies can only (currently) have dependency-criteria defined, the rule will be:

If an unversioned crate policy specifies dependency-criteria, that crate cannot be present as a third-party crate in the graph. Otherwise, the unversioned crate policy cannot have dependency-criteria specified and (to apply the desired dependency-criteria) versioned policies must be specified for each crate version in the graph.


Multithreading in Python doesn't work (GIL)

In GitLab by @cmastalli on Oct 18, 2019, 10:11
This issue was reported in #254. @proyan fixed an issue in the implementation of the StateMultibody class. It used to contain internal data that was producing errors in a multi-threads setup. This issue is solved here: !248.
However, we still have problems when we run multi-threads in Python interpreter, i.e. GIL (https://gepgitlab.laas.fr/loco-3d/crocoddyl/issues/256#note_6760).
I created another issue to decoupled both problems from #254.

In GitLab by @cmastalli on Oct 18, 2019, 10:11
assigned to @proyan

In GitLab by @cmastalli on Oct 18, 2019, 10:15
changed the description

In GitLab by @cmastalli on Oct 18, 2019, 10:16
@wxmerkt let's use this thread for continuing the discussion.

In GitLab by @proyan on Oct 18, 2019, 11:28
Hi Carlos,
This is a duplicate of https://gepgitlab.laas.fr/loco-3d/crocoddyl/issues/270. I'll close the other one.

In GitLab by @cmastalli on Nov 1, 2019, 10:33
@proyan how is the status of this issue? It would be great to figure out the boost python solution. It will allow us to add other parallelization routines and benchmark them.

In GitLab by @cmastalli on Nov 8, 2019, 12:23
assigned to @cmastalli and unassigned @proyan

In GitLab by @cmastalli on Nov 9, 2019, 14:59
It works in Python! The problem wasn't GIL, the problem is memory allocation in pinocchio::impulseDynamics. See this issue #286

In GitLab by @cmastalli on Nov 9, 2019, 14:59
closed


Payout column to show the most recent distribution of a pay party

Is your feature request related to a problem? Please describe.
Currently individual payout details for each address is not shown once a payout has been made by a payee.
Describe the solution you'd like
If a payout is already made then the new payout column should show the amount of tokens distributed to each person in the most recent payout.
If a payout is not yet made or a new payout is being made then the payout column should show distribution based on ETH or token amount entered in the Distribute Funds form.

@hmrtn  I've made a pull request to add the above feature request. Please review it. Thanks


Evaluation performance

Hi. Thanks again for making this great library!
One of my clients ask about the performance at: https://github.com/casbin/casbin/issues/45#issuecomment-343703409. My software is an access control library that uses govaluate to make authorization decisions. And I thought the performance bottleneck may be in the expression evaluation. Is there any way to upgrade the performance? Like adding a cache? Thanks!

Thanks! And thanks for using the library!
I looked through the issue you linked, and this comment is correct; caching is probably a good move. Parsing an expression is the most expensive operation this library does (even though it's still pretty fast). This library doesn't attempt to cache parsed expressions for later, because different users need it for different purposes, and a cache isn't always desirable.
While I'm not familiar with the usage patterns of your library, I think you might benefit by using an LRU cache. - something like this. This would automatically keep the most-used expressions in memory, while lesser-used ones would eventually be removed from memory. It would increase your memory footprint a bit, but not by much - and the savings in compute would probably be worth it. I'm recommending this because I assume there are policies that are commonly evaluated for many requests.
However, in the RBAC (large) case mentioned in your benchmarks, you might benefit from disabling govaluate's type checking. This doesn't do anything to help the parsing time, but evaluation will be a bit faster - however, it means that invalid combinations of parameters will cause panics, rather than errors. This may be acceptable to you, but i'd recommend adding the line expression.ChecksTypes = false on this line and see how much it helps your benchmarks.

I have implemented a version with the LRU here: https://github.com/casbin/casbin/tree/with-lru to cache the expressions. But unfortunately, it does not improve the performance.
And I also tried your disabling govaluate's type checking way, it doesn't improve performance either:(
Then I found the bottleneck may be in Casbin's rule matching, aka the result, err := expression.Evaluate(parameters) call. This call will run once for every policy rule. And when the number of rules is increased from 1000 to 10000, the enforcement overhead then multiplies by 10x. So is there a way to make expression.Evaluate(parameters) faster? In fact, I also need to find a way to not match so many rules for an Enforcer.Enforce() call. But it's kind of hard based on how Casbin works.

Added some findings in the casbin issue.


Fix opacity selector input

Instead of using css selector with class name, it's better to use MUI classes prop. In SS we have a number suffix in the classes and the styles modification wasn't being applied.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 73.006%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1282

Relevant Lines:
1654

💛  - Coveralls


Ignoring embedded images in Jupyter notebooks.

Is your feature request related to a problem? Please describe.
 These result in a lot of false positives. But, I don't want to completely skip all Jupyter files because they are a common place to accidentally commit secrets.
Describe the solution you'd like
I would like to be able to ignore the specific lines containing image data. Here's an example line (... indicates that the line is much much longer):
      "image/png": "iVBORw0KGgoAAAANSUhEUgAABGUAAAM8CAYAAAD+zB3vAAAAOXRFWHRTb2Z0d2FyZQBNYXRwbG...

I've tried to ignore this with allowlist like:
[allowlist]
regexes = ['''image/png''']

But that doesn't work. I'm not 100% sure, but I think the problem is that the regex only matches against the secret not against the entire line containing the secret. This is discussed in the PR here: https://github.com/zricethezav/gitleaks/pull/1039
cc @zricethezav

I stumbled upon the same problem and found a solution using regexTarget by following the last comment of the PR #1039 you linked:
[allowlist]
regexTarget = "line"
regexes = ['''image/png''']


Cut over to new validation logic

Switches the server to use the new strict validation function, and deprecates the legacy function with a note to use the new one

coverage: 94.261% (+0.003%) from 94.258% when pulling 159a3a4df110a052e9722c89c980b5fb305ac3bc on validator-cutover into 64f736243c00e50999d3e67617e87c5ced8eb4dd on main.

Related: https://github.com/medplum/medplum/discussions/2006


Bug: Lifecycle Integration

The Lifecycle CI check does not work for PRs from forks, due to the secrets not loading on runs from external branches.

Yes! I believe we just need to set up the pipeline to use a pull_request_target as noted there.


Bump to v2.1.4

coverage: 93.664% (-0.01%) from 93.675% when pulling a0c4a78fc4a58295e816f36c5810bccda26eb877 on bump_v214 into 84317adac35e23f0a55640c85f28a08136de0ade on master.

What is this?
=====> .pre-commit-config.yaml is not a file

What is this? =====> .pre-commit-config.yaml is not a file

You will not see that after https://github.com/XENONnT/straxen/pull/1240 merged.


2ddrawannotate

This adds small annotations to atom and bonds in 2D drawing by adding props "atomNote" and "bondNote" to the atom and bond objects respectively.
test20Annotate() in mol2draw2DTest1 shows it in action.
This is an early pull request so Greg can test the drawng of something else.
It is known to fail mol2draw2DTest1 due to SVG coord changes.
It needs more testing and test cases.

Superseded by #3010


rlights

Implement rlights please.

rlights is not part of the core raylib framework. it's something built on top of it.
i have a lighting module in: https://github.com/bmchtech/rengfx


Tooltip only stays open for 1 second upon mouseEnter

<EMAIL_ADDRESS> <span className="icon" data-tip data-for="logo-tooltip">
     <i className="fas fa-question-circle" />
 </span>
<ReactTooltip id="logo-tooltip">
     <div> my tooltip </div>
</ReactTooltip>

When I hover over span.icon the tooltip appears for 1 second and then fades out even when the mouse has not moved.
I do see that the React state show on the component ReactTooltip toggles to true upon mouseEnter  then a second later toggles to false automatically without any clear trigger event.
How can I prevent show from toggling to false UNTIL mouseLeave?
Note: This is just one example of the many tooltips being used in my code base. This behavior is happening for all tooltips.

That is strange behavior. I don't know of anything in ReactTooltip that would trigger a fade after one second. I don't see that behavior with the examples: https://react-tooltip.netlify.com/ , do you? Does the behavior change with different browsers or anything?
It make me think there may be some CSS animation stuff affecting the tooltip...
Please update if you find something!

@aronhelser Thanks for the quick reply!
I checked https://react-tooltip.netlify.com and the odd fade out is NOT happening (working as intended).
I checked my implementation with Chrome, Safari, and Firefox and all have the odd fade out. I will check the codebase for any CSS overrides or animations and will update if I find anything.

@aronhelser Just wanted to update this issue.
I have not found any css animation in the code base that seems to be causing the issue. We do use Bulma (https://github.com/jgthms/bulma). Have you heard of any conflicts with that framework and react-tooltip?
Do you think that CSS Animations could change the React state show ? I have seen this toggle without an apparent mouse event (with React Developer Tools).
Thanks!

If anyone else is having this issue, I found that adding this line to the hideTooltip function worked:
if (e === undefined) return
For some reason an undefined event was triggering the close of the tooltip.


feat: Create a Sign Up page

Description of the new feature.
We might need to create a new sign up page as the the current login page should be served for login purpose and its better to have a seperate login and sign up pages.
The idea is to design and create a sign up page similar to the current login page and add better functionality and designs for better user experience.
Please assign me this task under GSSoC '23. Thank You!
Describe briefly how you would implement this new feature.
Some steps to implement this enhancement-
1. creation of a new page signup .js
2. adding better css properties and icons

Screenshots Example (if applicable)
No response
Additional information
No response
Contributor terms

[X] I agree to follow the Contributing Instructions

I think we have a similar issue on which @Deepanshu0703 has already worked!

@jain-rishabh-21  Alright then, let me create a login page as well so that already registered user can login. #126


Will it be possible to add  LDL' factorization for Hermitian indefinite matrices in scipy.linalg

When working with Hermitian matrices,  LDL' factorization for Hermitian indefinite matrices is usually reqired. But I can't find it in scipy.linalg. So, will it be possible to add  LDL' factorization for Hermitian indefinite matrices in scipy.linalg in the futrue?

Please have a look at PR gh-6831. Any testing/feedback on that PR would be very welcome.

Indeed, if you have LAPACK version 3.5.0 and higher, it would be really good to have some feedback.


[Example] Vue Product Gallery

Create a new example showing how to set up the Cloudinary Product Gallery in an Vue project.
See other frameworks for examples:

https://github.com/cloudinary-community/cloudinary-examples/tree/main/examples/react-product-gallery

Hi, can I take this one?


[Event Request] Page 296 Recurring Req. Worksheet - Action "Calculate Plan" - OnBeforeCalculateLines

Please add the following Event/-s OnBeforeCalculateLines to Action "Calculate Plan" in Page 296 Recurring Req. Worksheet
[Event Request] Page 296 Recurring Req. Worksheet - action("Calculate Plan")
{
    ApplicationArea = Planning;
    Caption = 'Calculate Plan';
    Ellipsis = true;
    Image = CalculatePlan;
    ToolTip = 'Use a batch job to help you calculate a supply plan for items and stockkeeping units that have the Replenishment System field set to Purchase or Transfer.';

    trigger OnAction()
    var
        IsHandled: Boolean;  // <- ADDED
    begin

        IsHandled := false;    // <- ADDED
        OnBeforeCalculateLines(Rec, IsHandled); // <- NEW EVENT
        if IsHandled then      // <- ADDED
            exit();                     //  <- ADDED

        ReorderItems.SetTemplAndWorksheet(Rec."Worksheet Template Name", Rec."Journal Batch Name");
        ReorderItems.RunModal();
        Clear(ReorderItems);
    end;
}

[IntegrationEvent(false,false)]
local procedure OnBeforeCalculateLines(var RequisitionLine: Record "Requisition Line"; var IsHandled: Boolean)
begin
end;

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.
Build ID: 13791.


CTRL-K keystroke instead of button to add hyperlinks in Radzen Blazor HTML Editor component

Virtually all HTML editors support CTRL-K to mark a string with a URL hyperlink.
Would love for the Radzen HTML control to support this.  You would high-light the text for the link in the textbox and then hit CTRL-K on the keyboard to bring up the existing INSERT LINK dialog box. That highlighted text would already be populated in the TEXT textbox field and focus would be in the Web address field so you could CTRL-V (paste) the URL you wanted to link.
Currently, you have to click the URL link button instead of a keyboard command.
Thanks!

Recently implemented.


Add an option to retrieve all pages of a request.

I'm not sure if this is already possible, but it would be nice to just to be able to tell node-github to get my all the pages and not have to loop through them all manually and concat them to get them in one place.

+1


[Source Request] Samehadaku

Source website

Name: Samehadaku
Link: https://<IP_ADDRESS>/
Language(s): Indonesian

Other details
Anime Source

ok

Link not working anymore


Some titles don't show 1080p option anymore

Last two days some movies don't run in 1080p any longer (series I've tested for some reason don't seem affected).
I've checked in the Netflix app to be certain they all have 1080p.
For example - Sorry to Bother You, Zodiac, The Big Lebowski, Theory of Everything etc'.
They all run in 960x540.
Hopefully you can fix it. Thank you.

I'm afraid that Netflix changed the DRM on these titles, which doesn't allow us to play higher quality versions anymore. Until someone figures out a way around it, it seems likely that more and more licensed titles will switch to some sort of stricter DRM, killing the ability to play the 1080p versions. If someone does figure it out, I'll port the workaround/fix to this extension of course.

Thanks.
I'm curious, how do you know Netflix changed DRM on titles? Is there a way to check/test it?
Is there a way to check what specific DRM is used?

I don't know for sure, but it certainly seems that way, according to some past discussions:

https://github.com/truedread/netflix-1080p/pull/95#issuecomment-657270897
https://github.com/jangxx/netflix-1080p/issues/6

I'm using 1.22.0 version.
I didn't test all. but Zodiac do have 1080p to choose.

Some titles like Las vegas 21 doesn't have 1080p unfortunately, any update on that? thanks.


Improve OpenID Connect 1.0 Logout Endpoint

Consider making logoutEndpoint() disabled by default - similar to clientRegistrationEndpoint()
Consider adding SessionRegistry as constructor argument instead of  OAuth2AuthorizationCodeAuthenticationProvider.setSessionRegistry()
Add a logout success page in the default sample

Related gh-1068

@jgrandja Will this feature be added in 0.4.x ?

@haojava No. New features can only be added in main which is currently 1.1. The 0.4.x branch will accept bug and security fixes only.


Clean up content and suggestions for design

@ShweataNHegde Please refer to single commit messages for changes I've made

👷 Deploy Preview for semanticclimate processing.

Name
Link

🔨 Latest commit
eaa13a3d95dd5d99ab198f8bf39165a258c38a0e

🔍 Latest deploy log
https://app.netlify.com/sites/semanticclimate/deploys/6342c99f8c5bbb00091c22c4


Formatting document (ctrl-k,d) removes async keyword in front of "async for"

Hi,
we are observing some very peculiar behavior while using the 'Format Document' function of Visual Studio in a Python project. The function removes the async keyword and any single line comment before it from in front of a async for statement, even though it recogizes async as a keyword. This can be summarized by the code snippets below:
Before CTRL-K,D
logger.debug('some code here')
#Some comment
async for event in device.async_read_loop():
    logger.debug('dispatch event')

After CTRL-K,D
logger.debug('some code here') for event in device.async_read_loop():
    logger.debug('dispatch event')

using :
Visual Studio 2015 Update 3 (v14.0.25425.01)
Python Tools 2.2.4

Best regards,

Well that's embarrassing. Thanks for the info :)


ERR: invalid operation: time and *influxql.ParenExpr are not compatible

My query is below:
SELECT * FROM "mydb", (SELECT time AS recent_add, coverage AS donotuse FROM "mydb" WHERE "svc"='net' ORDER BY time DESC LIMIT 1) WHERE "svc"='net' AND time >= (recent_add - 2s)
sample data:
name: mydb
time                                                    coverage file                      svc

2020-02-05T20:58:53.42815312Z  54.7     abcde                     net
2020-02-05T20:58:53.434622025Z 44       mnopq                     net
2020-02-05T20:58:53.439089193Z 0        ijklm                     net
2020-02-05T21:28:56.16916372Z  54.7     abcde                     net
2020-02-05T21:28:56.17537839Z  44       mnopq                     net
2020-02-05T21:28:56.181340942Z 0        ijklm                     net
2020-02-06T14:16:08.537838747Z 54.7     abcde                     net
2020-02-06T14:16:08.543652609Z 44       mnopq                     net
2020-02-06T14:16:08.549541623Z 0        ijklm                     net
2020-02-06T19:40:26.080984944Z 54.7     abcde                     net
2020-02-06T19:40:26.085943548Z 44       mnopq                     net
2020-02-06T19:40:26.090723171Z 0        ijklm                     net
2020-02-07T12:04:17.913629362Z 54.7     abcde                     net
2020-02-07T12:04:17.920255522Z 44       mnopq                     net
2020-02-07T12:04:17.92732267Z  0        ijklm                     net

@jahircisco thanks for the issue. Looks like the problem is with this part of your query: AND time >= (recent_add - 2s). I don't think you can use recent_add in the where clause as a time filter.

@jahircisco thanks for the issue. Looks like the problem is with this part of your query: AND time >= (recent_add - 2s). I don't think you can use recent_add in the where clause as a time filter.

recent_add is a time value. I wonder why I can't use that as a time filter.

@jahircisco i think the issue is that the value is being populated by the sub query. InfluxQL is SQL-like, so it doesn't have all the capabilities of SQL.
If you haven't tried it, I encourage you to check out the Flux language we have been working on. It would allow you to do this query and much more. You can try it in our latest beta or via 1.7.9 by enabling flux support in the config.
https://docs.influxdata.com/flux/v0.50/introduction/installation#sidebar
https://v2.docs.influxdata.com/v2.0/reference/flux/


python3Packages.flux-led: 0.28.0 -> 0.28.1

Motivation for this change
https://github.com/Danielhiversen/flux_led/releases/tag/0.28.1
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 154823 run on x86_64-linux 1

2 packages built:

python310Packages.flux-led
python39Packages.flux-led


Support llama.cpp

It would be nice to support bindings from llama.cpp for question generation and embeddings. This is already supported in the main library.

This would be actually a great feature to have in place! Do you guys by any chance plan to add this anytime soon?
cc @nfcampos @hwchase17

+1 for the feature!

+1 for the feature!

+1 for the feature!

If waiting is difficult, using this could be an option: https://github.com/keldenl/gpt-llama.cpp.

+1 yes please!

+1 for the feature!

1

would love to use a local model with LangChain.js!

I think this may be the support we were asking for:
https://js.langchain.com/docs/modules/model_io/models/llms/integrations/llama_cpp

I think this may be the support we were asking for: https://js.langchain.com/docs/modules/model_io/models/llms/integrations/llama_cpp

good job,it seems developed by catai👍

There seems to be some issues with using it and Langchain agents.
https://github.com/hwchase17/langchainjs/discussions/2486


Issues with Building

Tried installing via:
yarn add lottie-react-native
react-native link lottie-react-native

Fixed the header paths (See: https://github.com/airbnb/lottie-react-native/issues/12) but then got error saying it could not find the lottie headers.
So I tried to install via CocoaPods but got this error:
pod 'lottie-react-native', :path => '../node_modules/lottie-react-native'

/Users/...LottieReactNative/LottieAnimationViewManager.m:40:37: Incompatible block pointer types sending 'void (^)(RCTUIManager *__strong, NSDictionary<NSNumber *,UIView *> *__strong)' to parameter of type 'RCTViewManagerUIBlock' (aka 'void (^)(RCTUIManager *__strong, RCTSparseArray *__strong)')
Maybe some conflict with React/RN versions, I saw the Cocoa Pod installs react which seems kind of odd.

I am using:
"react": "15.3.2",
"react-native": "0.36.0",

Any ideas? It seems the building for this project still needs some work, but its worth it 👍
Update - Want to clarify, I was able to build the example fine (however some of the animations did not play) but when I try to integrate into existing project is where the errors above occur.

Had the exact same problem - examples worked fine but had this issue when trying to integrate into an existing project.

@indivisable thanks for the detailed error report. The version of React that it's installing looks very off. It looks like this is because it is getting the React pod from the cocoapods specs repo, rather than in your node_modules (0.11.0 was the last RN version published to the main specs repo). I'll try and figure out what the right fix for this is. Sorry!

Had a similar issue while building for android. Hope this helps.

@lelandrichardson
I still get this error:


Trying to deploy to Heroku causes many errors.

I am trying to deploy this react-redux-universal-hot-example to Heroku using Heroku Toolbelt which uses git repository . But if this app is deployed as it is, many errors occur.
For example, Heroku Toolbelt's terminal access does not support global webpack or babel-node or concurrent command so the many commands in package.json do not work as it is in production mode.
I have successfully deployed several apps in Heroku except this one.
Is there some special procedure to be done for this app in Heroku deployment using Heroku Toolbelt?

I just finished this myself, however I was using Parse.com set to deploy to Heroku.
First thing was I had to combine "dependencies" and "devDependencies" into just "dependencies". Then I had to remove the "PORT" from "start-prod", like this:
"start-prod": {
  "command": "node ./bin/server.js",
  "env": {
    "NODE_PATH": "./src",
    "NODE_ENV": "production",
    "APIPORT": 3030
  }
}

Once I had done that, I managed to deploy the project to Heroku.

@whatifif, mentioned errors occurs when deploying the Heroku branch?

@elmeister, yes of course. I tried Heroku branch also and same errors occur.
As @patrisk mentioned, the "PORT" should be removed in "start-pod" and Heroku branch already did this.
For example, the error clearly occur when "concurrent" command is executed. In order to execute this "concurrent" command, it should be installed globally, but by using the Heroku toolbelt, this "concurrently" module cannot be installed globally.  I wonder how this Heroku branch is deployed  as it is.

@elmeister, yes of course. I tried Heroku branch also and same errors occur.
As @patrisk mentioned, the "PORT" should be removed in "start-pod" and Heroku branch already did this.
For example, the error clearly occur when "concurrent" command is executed. In order to execute this "concurrent" command, it should be installed globally, but by using the Heroku toolbelt, this "concurrently" module cannot be installed globally.  There must be something to be done in order for this app to be deployed to Heroku.

@patrisk, @elmeister
I followed the procedure as mentioned in doc:
To get this project to work on Heroku, you need to:
Remove the "PORT": 8080 line from the betterScripts / start-prod section of package.json.
heroku config:set NODE_ENV=production
heroku config:set NODE_PATH=./src
heroku config:set NPM_CONFIG_PRODUCTION=false
This is to enable webpack to run the build on deploy.
The first deploy might take a while, but after that your node_modules dir should be cached.
But still there is error:
/app/node_modules/babel/node_modules/babel-core/lib/polyfill.js:8
2015-11-18T04:47:22.761132+00:00 app[web.1]: [0] throw new Error("only one instance of babel/polyfill is allowed");
I will try heroku version once more.

@patrisk, @elmeister
I followed the procedure as mentioned in doc:
To get this project to work on Heroku, you need to:
Remove the "PORT": 8080 line from the betterScripts / start-prod section of package.json.
heroku config:set NODE_ENV=production
heroku config:set NODE_PATH=./src
heroku config:set NPM_CONFIG_PRODUCTION=false
This is to enable webpack to run the build on deploy.
The first deploy might take a while, but after that your node_modules dir should be cached.
But still there is error:
/app/node_modules/babel/node_modules/babel-core/lib/polyfill.js:8
2015-11-18T04:47:22.761132+00:00 app[web.1]: [0] throw new Error("only one instance of babel/polyfill is allowed");
Heroku branch sends same error as above.

I successfully launched the Heroku branch by commenting out the "require('babel/polyfill');" in "src/config.js (line 1)"  and keeping "require('babel/polyfill');" in "src/client.js" (line 4).

PR it, @whatifif.

I sent Pull Request on heroku branch.
Thanks.


eventually-postgres: A not-persisted projection to be able to use in Projector

Is your feature request related to a problem? Please describe.
Currently it seems that it's impossible to create a non-persisted projection from a postgres event store right?
The intended use-case:

There are multiple (because potentially a deployment might scale up) in-memory projections, which offer tiny fast materialized views for convenience.
If a particular pod gets moved, the projections get restarted, catch up fully, and everything proceeds as expected.

If I understand correctly, a persistent projection would not restart from the beginning, but rather pick up from the last consumed event - meaning the materialized view is incorrect.
Describe the solution you'd like
To be able to create a non-persisted projection from a postgres event store. I guess essentially something that implements eventually::Subscription trait, so that it can be used in eventually::Projector.
Describe alternatives you've considered
As I understand now, the intended use-case for a persisted subscription is with projections that are also persisted after updates. I would rather avoid this for now, though.

Hey @to266,
I guess you're describing a Transient subscription, which implements both a Volatile (reads from the beginning of the Event Stream) and Catch-up (reads from a specified point in time of the Event Stream) semantics.
In this particular case,

If a particular pod gets moved, the projections get restarted, catch up fully, and everything proceeds as expected.

I guess you're describing the Volatile semantics (i.e. at each pod restart, the projection starts from the beginning).
You can find an example of it here: https://github.com/eventually-rs/eventually-rs/blob/726250e22e720d471da52132db9038dd134c9eea/eventually-app-example/src/lib.rs#L38-L54

Thanks for the quick response and example! I had seen it, and tried to make it work, but with both this and the eventually-postgres tests I must have gotten confused.
This seems to make the compiler happily.. Does it look correct?
// <snip>
let aggregate = MyAggregate.as_aggregate();
let store = eventstore_builder
    .for_aggregate(EVENTUALLY_NAME, &aggregate)
    .await?;
let dsn = std::env::var("EVENTUALLY_URL").expect("Eventually url not set");
let subscriber =
    EventSubscriber::<aggregate::Id, aggregate::ProjectEvent>::new(&dsn, EVENTUALLY_NAME)
        .await?;
let subscription = TransientSubscription::new(store.clone(), subscriber);
let this_projection = Arc::new(RwLock::new(MyProjection::default()));
let mut projector = eventually::Projector::new(this_projection.clone(), subscription);
eventually::spawn(async move { projector.run().await.expect("Should not fail") });

Also, ideally I'd like to be somewhat robust against the transient subscription dropping connection and then failing, or similar random things.
Have you thought how to restart them, or at least handle creating them again in such cases? Worst case I could crash the whole process and make the pod restart, but I'd rather avoid that if it's not too difficult :+1:

Hey @to266,
your snippet does look correct indeed :+1:
Related to the second point:

Also, ideally I'd like to be somewhat robust against the transient subscription dropping connection and then failing, or similar random things.
Have you thought how to restart them, or at least handle creating them again in such cases? Worst case I could crash the whole process and make the pod restart, but I'd rather avoid that if it's not too difficult :+1:

Subscription failure is something I've been thinking about...
In the case of Persistent Subscriptions, this isn't much of a problem since there is checkpointing and is persisted in a durable storage. In the case on "transient" Subscriptions, there are two things missing:

Handling a failure coming from the underlying Event Stream (when streaming from the Event Store), e.g. "what should the Subscription do when it receives SomeError? Stop the whole thing? Filtering these errors?"
Recreate the underlying Stream starting from the last checkpointed event.

I think the current design is not great, and I'm trying to come up with a different design for 0.5.0 (sneak peak #140), from how to represent Event Streams -- and how that impacts the Event Store trait --, to how to subscribe to events, projections, process managers, etc.
I value any thoughts in that regard, so feel free to either comment on the aforementioned PR or in #133 :smile:
For now, I'll close this ticket :+1:


Add columnar processing for dictionary encoded blocks

Microbenchmark results: https://gist.github.com/nileema/070bcd81e3f107a41734
https://cloud.githubusercontent.com/assets/1034143/11601338/4ca8bae2-9a87-11e5-9098-17308791a599.png

One of the travis runs failed, so I restarted it.  Assuming it passes, looks good.

looks good


Add comment on how to use units/prefixes in threshold

/lgtm

This won't be needed as we are switching to use SLO based alert.


dag: move common properties from hadoop.yml to all.yml for better dag integration

Wait https://github.com/orgs/TOSIT-IO/discussions/49 before doing this issue.

As stated by https://github.com/orgs/TOSIT-IO/discussions/49 move common variables to tdp_cluster.yml.
Before doing it, need:

[ ] #448


feature: expose terminal management for plugin integrations

Did you check the docs?

[X] I have read all the snacks.nvim docs

Is your feature request related to a problem? Please describe.
Hi!
I'm creating my first Neovim plugin (nvim-aider) for Aider integration. Currently, I need to reimplement terminal management logic that already exists in snacks.nvim. Access to the internal terminals table and terminal ID generation would allow better integration and reduce code duplication.
Describe the solution you'd like
Expose two internal components from snacks.terminal:
The terminals table storing active terminal instances
The terminal ID generation logic (either as a function or by exposing the implementation)

This would enable plugins to:
Track existing terminals without reimplementation
Generate consistent terminal IDs
Better integrate with snacks.nvim terminal management

Describe alternatives you've considered
I'm currently reimplementing this functionality in nvim-aider as shown in the terminal.lua module. Having access to snacks' internal terminal management would make the integration more robust and maintainable. Also many thanks for the creating of snacks.
Additional context
No response

See the updated docs.
--- Get or create a terminal window.
--- The terminal id is based on the `cmd`, `cwd`, `env` and `vim.v.count1` options.
--- `opts.create` defaults to `true`.
---@param cmd? string | string[]
---@param opts? snacks.terminal.Opts| {create?: boolean}
---@return snacks.win? terminal, boolean? created
function M.get(cmd, opts)


security: fix CVE-2022-24675

This is a PRIVATE issue tracked in http://b/216105673 and fixed by http://tg/1391157.
/cc @golang/security and @golang/release

@gopherbot please open backport issues for this security fix.


Update Restart-VM.md

Added information about wait and timeout parameters.

@JohanFreelancer9 Please copy review

issue#https://github.com/MicrosoftDocs/windows-powershell-docs/issues/2662

Docs Build status updates of commit 0736c21:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docset/winserver2019-ps/hyper-v/Restart-VM.md
:white_check_mark:Succeeded
View (WindowsServer2019-ps)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit ae684c7:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docset/winserver2019-ps/hyper-v/Restart-VM.md
:white_check_mark:Succeeded
View (WindowsServer2019-ps)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

@msbemba, you have only committed one suggestion. Kindly commit my other suggestions as well. Thanks.

@get-itips It has been added to the other two versions where the parameter is available .

Docs Build status updates of commit 5539f93:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docset/winserver2016-ps/hyper-v/Restart-VM.md
:white_check_mark:Succeeded
View (WindowsServer2016-ps)

docset/winserver2019-ps/hyper-v/Restart-VM.md
:white_check_mark:Succeeded
View (WindowsServer2019-ps)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit cf3b468:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docset/winserver2016-ps/hyper-v/Restart-VM.md
:white_check_mark:Succeeded
View (WindowsServer2016-ps)

docset/winserver2019-ps/hyper-v/Restart-VM.md
:white_check_mark:Succeeded
View (WindowsServer2019-ps)

docset/winserver2022-ps/hyper-v/Restart-VM.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 7bdac05:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docset/winserver2016-ps/hyper-v/Restart-VM.md
:white_check_mark:Succeeded
View (WindowsServer2016-ps)

docset/winserver2019-ps/hyper-v/Restart-VM.md
:white_check_mark:Succeeded
View (WindowsServer2019-ps)

docset/winserver2022-ps/hyper-v/Restart-VM.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


made unique_rank a preprocessor variable

This change avoids cppcheck to create the warning:
trexio.c:48399:32: note: 'unique_rank' is assigned value '1' here.
  const uint32_t unique_rank = 1;
                               ^
trexio.c:48407:19: note: The expression 'unique_rank != 1' is always false.
  if (unique_rank != 1) {

Excellent, thanks! It also allows the compile less code :-)


PBR meshes flicker due to delay when updating Handle<StandardMaterial> component

Bevy version
24b21ea35ed58035707c1e70159a24a009102fab
Operating system & version
MacOS 12.1
What you did
My app can update the Handle<StandardMaterial> component quite often, because it uses a dynamically generated texture.
What you expected to happen
The previous render did not flicker.
What actually happened
Meshes flicker when updated for about half of the runs, for as long as the app runs.
Additional information
None yet.

As I said on Discord, this seems very likely to be a system order ambiguity issue.


Operator - expose generic function and improve helmreconciler reusability

We would like to reuse helmreconciler and translate packages for our custom operator solution and want to generalise the packages by exposing a couple of generic functions. The changes are minimum and local without virtually any impact to the existing operator code base.
It is understood that there is no guarantee for third party integrations and  this code may break anytime.
Summary of the changes in this PR:
package translate: (exposed function)
MergeK8sObject and ProtoToHelmValues from translate package. They are generic and useful to be called from third party applications. This change is local.
package helmreconciler:
To the function NewHelmReconciler added the other parameters RenderingCustomizer and Client for more utility value. This change is very local with minimum impact.
HelmReconciler struct - changed member instance from type *iop.IstioOperator to runtime.Object. This change allows helmreconciler package to be more generic and making code reusable through embedding.Checks are already in place to verify if the instance is of type *iop.IstioOperator before using it. So this change has very minimum impact.

Hi @deva26. Thanks for your PR.
I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

/ok-to-test

/ok-to-test

ping @istio/wg-environments-maintainers

ping @istio/wg-environments-maintainers

No objection to the change but I'd feel more comfortable approving this when https://github.com/istio/istio/pull/22477 goes in, since we don't have a real e2e test for the controller until it does. Can this wait a few days for that to merge and tests to be running?

Hi Martin,
This change is a bit urgent and we can't wait that long for the other PR. We are happy to add e2e test cases after the merge, if need be. Thanks for your attention.
Regards.


JavaScript translations

I'm not really sure why I introduced JavaScript translations the way they are now anymore (I think the idea was to make it resemble the concept of the core language file), but maybe we find an elegant way to get rid of the false in the Symphony.Language.add() function:
Symphony.Language.add('String 1', 'String 2', ' String 3');

I've always pasted false without understand why. What is it there for?

I think the initial idea was to allow "shortcuts": at least in the first implementation it was possible to define Symphony.Language.add('mail': 'Please confirm your email address.'). Furthermore the JavaScript language definitions look similar to the PHP language array, e. g. "Please confirm your email address." => false.
But, to be honest, I think the initial concept was to complicated and not well laid out. Sorry about that :)

What exactly does it do? Should w not be outputting the PHP dictionaries into JS? We'd have the single place to store translations then.

We only need to fetch the few translations that are actually needed in the JavaScript and Symphony.Language.add() defines these strings. The main idea is saving bandwidth to minimise long delays on shared hosts (we have been experiencing a lot of problems around this lately – a few more optimisation are in the making).
It would be an idea to fetch the full dictionary, if we really store it using localStorage so that we have to fetch it only on initial page load (or if a core or extension update was detected). In this case Symphony.Language.add() would become obsolete.

To point out a disadvantage of fetching the full dictionary: the JavaScript side of the backend only used a few rare strings – the full dictionary in never needed.
To point out an advantage of fetching the full dictionary: we could just create a dynamic JavaScript file that provides the Dictionary object. So we could get rid of the AJAX request and of the need to declare your strings first.

Just one thing: since the introduction of namespaces, Symphony.Language.add accepts a new final parameter to define the namespace:
Symphony.Language.add({
    'String 1': false,
    'String 2': false,
    'String 3': false,
}, 'namespace');

If we change the method signature, how can we distinguish between translatable strings and the namespace?

Yeah, you're right, Simone. That would be problematic. Replacing Symphony.Language.add() by a general symphony.en.js* would solve this problem though.

* The core would have to create one file per language that is used in the backend so that the backend is not provided in the wrong language when using JavaScript. If a file like symphony.en.js came with a function to add the strings to Symphony.Language.Dictionary that would be no problem.

I've been thinking about this during the day and I think it's a brilliant and simple idea to remove Symphony.Language.add() (thanks, John!) and move to a dynamic JavaScript file that can be cached by the browser. Performance issues would be minimized without any complex localStorage logic and extension developers would never have to declare their strings again – they can just use Symphony.Language.get() to create a localisable string.
Any objections that we move on with this new concept, @eKoeS & @klaftertief and all the others?

Is it backwards compatible with all existing extension implementations?

Short answer: Yes.
Longer answer: As the full Symphony language dictionary will be made available in the Symphony object all translations will be available without declaring them first. We'd have to make sure that Symphony.Language.add() still exists so that the backend won't throw errors in connection with older extensions (or those that try to keep compatibility with older Symphony versions) – but we could just make it an empty function that's not doing anything.

JSON processing is so easy these days that dynamic files from the PHP are negligible in overhead. I do this with some very very big projects.
Backwards compatibility can be baked in to ensure we do it right...

and move to a dynamic JavaScript file that can be cached by the browser

I still don't understand what this dynamic JS file is supposed to contain, but as long as everything is backward compatible and easier to maintain, I'm all for it :)

Will these files be inside /manifest/cache by the way?

We're shifting around the Symphony JS objects, so the JS file can contain an extension of the default Symphony object that adds the same functionality that the current one contains, as though it we're in the current one. We would have to look into which strings are exported, but I think it would be a subset of the PHP dictionary, not the whole thing.
I've done loads of research on JS module patterns recently, as it's a big part of my job, and I have some proposals for the way we do things now...

@eKoeS: The idea is to no longer fetch a partial dictionary based on string declarations. Instead we'll have separate files like symphony.en.js and symphony.it.js containing an object with all translations available in the Symphony core. So both sides – the PHP and JavaScript world of the system – will deal with the same dictionary. We no longer fetch anything via AJAX and just add the needed language as separate, dynamic file to the backend.

Good question. We need to sort out the pattern first before the logistic implementation of it, but noted to think about.

We would have to look into which strings are exported, but I think it would be a subset of the PHP dictionary, not the whole thing.

Ah, but this would complicate things again. In this case you'd still have to declare your strings in the JavaScript first – if we take the full dictionary (and make sure it will be cached by the Browser), the translations will only have to be loaded once and can then be taken from cache.
Or do you think a huge JavaScript object will be a problem regarding browser performance?

I think – beside the option to use the browser cache – getting rid of string declarations would be a huge improvement. If this is not possible, I don't see an advantage in the usage of a dynamic file instead over an AJAX request.

I don't think so to be honest. After all it's a single string. We should do some tests.
I honestly thought you were against the full dictionary, it was my first choice to do it, and I think it can be achievable.

I honestly thought you were against the full dictionary, it was my first choice to do it, and I think it can be achievable.

No, I was just trying to gather the pro and contra :)

So both sides – the PHP and JavaScript world of the system – will deal with the same dictionary.

Sorry if the question is stupid, but: if the concept here is to share the same dictionary, wouldn't it be better to have a single language file in JSON or XML so that there's no need for symphony.??.js anymore? The only thing I'm not sure of, in fact, is having a JS duplicate of the whole dictionary.

If you like to cache the content properly, you need to make sure that the browser can distinguish between different languages hence my idea of different files.

No, I mean: instead of having both:
lang.it.php
symphony.it.js

What about just:
lang.it.json

?

I like the idea but there are a few problems:

Your idea will break compatibility across the core and all available extensions.
There is no unified language file for any language because every extension bundles its own file.

Maintaining a language file in PHP and exporting it is far easier than in JSON, which needs to be compressed to one string for output.

(Shall we close #755 ?)

I don't think so. Sounds like you're interested?

I am, but I'd like to have some "specs" so that I do it right the first time. Any more advices/comments/things-to-be-discussed? /cc @designermonkey

I thought I'd hit enter the other night for my comment, but in my poorly state, I forgot...
We need to look at the end-line here, i.e. how we want to do the translations forwards from now, and then how we can make that legacy compatible.
I was playing with a new JS module pattern for the namespace which would make it easier to plug in to for the future, but stopped as I don't know enough bout the current usage.
The big point is getting the Dictionaries output into JS from the PHP.

Hi I'm Issue #837 and I need an owner fast! I'm up for inclusion in the 2.3 Beta 1. Any takers?
localStorage is cheap, widely supported and has a dead simple API. Considering the relatively small size of an entire translation, I don't think this is going to be problem to be honest as it only has to be loaded into localStorage once and then updated when the extension version changes.
Doing complicated logic to only load the strings required is probably going to negate the minor annoyance of the current implementation (and potentially impact performance).

Hmm … I thought the conclusion of this issue was to not make use of localStorage but to simply load the full dictionary in separate, dynamic JavaScript file. The caching can be done by the browser and we would be able to get rid of Symphony.Language.add() and all the logic involved to minify the number of AJAX requests.

What's the difference between the browser caching a separate file and loading it from the browser localStorage cache? Wouldn't it be possible to lose the Symphony.Language.add() with both approaches?

I'm coming to this very late, and I have no opinion on the direction this should go. But...

it only has to be loaded into localStorage once and then updated when the extension version changes.

Could this be done with a checksum? Store a hash of the translation in localStorage along with the translation. If it doesn't match, the localStorage cache is stale.

It's just easier to rely on the build-in browser caching than to create our own localStorage caching.

I suggest we descope this from 2.3 to a minor version update, it still needs discussion and we need to push for the release.

Could this be done with a checksum? Store a hash of the translation in localStorage along with the translation. If it doesn't match, the localStorage cache is stale.

Yep.

It's just easier to rely on the build-in browser caching than to create our own localStorage caching

Huh? localStorage is a cache, it's like cookies, but it doesn't suck. Check this simple tutorial.

I suggest we descope this from 2.3 to a minor version update, it still needs discussion and we need to push for the release.

Sounds good.

Agree to disagree :D Either way is an improvement, so I'm for the change regardless of implementation


Twig Bugs is JournalManager

[2015-06-03 11:28:39] assetic.ERROR: The template "OjsWorkflowBundle:Manager:invitationPreview.html.twig" contains an error: The function "isJournalManager" does not exist in "OjsWorkflowBundle:Manager:invitationPreview.html.twig" at line 84
[2015-06-03 11:28:39] assetic.ERROR: The template "OjsWorkflowBundle:Manager:articles.html.twig" contains an error: The function "isJournalManager" does not exist in "OjsWorkflowBundle:Manager:articles.html.twig" at line 62
[2015-06-03 11:28:39] assetic.ERROR: The template "OjsWorkflowBundle:Manager:previewWorkingStep.html.twig" contains an error: The function "isJournalManager" does not exist in "OjsWorkflowBundle:Manager:previewWorkingStep.html.twig" at line 87
[2015-06-03 11:28:39] assetic.ERROR: The template "OjsWorkflowBundle:Manager:article.html.twig" contains an error: The function "isJournalManager" does not exist in "OjsWorkflowBundle:Manager:article.html.twig" at line 31
[2015-06-03 11:28:39] assetic.ERROR: The template "OjsWorkflowBundle:ReviewFormItem:index.html.twig" contains an error: The function "isJournalManager" does not exist in "OjsWorkflowBundle:ReviewFormItem:index.html.twig" at line 37
[2015-06-03 11:28:39] assetic.ERROR: The template "OjsWorkflowBundle:ReviewForm:index.html.twig" contains an error: The function "isJournalManager" does not exist in "OjsWorkflowBundle:ReviewForm:index.html.twig" at line 38
[2015-06-03 11:28:39] assetic.ERROR: The template "OjsWorkflowBundle:WorkflowStep:index.html.twig" contains an error: The function "isJournalManager" does not exist in "OjsWorkflowBundle:WorkflowStep:index.html.twig" at line 57
[2015-06-03 11:28:39] assetic.ERROR: The template "OjsWorkflowBundle:WorkflowStep:show.html.twig" contains an error: The function "isJournalManager" does not exist in "OjsWorkflowBundle:WorkflowStep:show.html.twig" at line 122
[2015-06-03 11:28:39] assetic.ERROR: The template "OjsWorkflowBundle:WorkflowStep/Template:templates.html.twig" contains an error: The function "isJournalManager" does not exist in "OjsWorkflowBundle:WorkflowStep/Template:templates.html.twig" at line 47
[2015-06-03 11:28:39] assetic.ERROR: The template "OjsWorkflowBundle:WorkflowStep/Template:show_step.html.twig" contains an error: The function "isJournalManager" does not exist in "OjsWorkflowBundle:WorkflowStep/Template:show_step.html.twig" at line 114
[2015-06-03 11:28:39] assetic.ERROR: The template "OjsWorkflowBundle:WorkflowStep/Template:template.html.twig" contains an error: The function "isJournalManager" does not exist in "OjsWorkflowBundle:WorkflowStep/Template:template.html.twig" at line 56
[2015-06-03 11:28:40] assetic.ERROR: The template "OjsJournalBundle:JournalContact:new.html.twig" contains an error: The function "isJournalManager" does not exist in "OjsJournalBundle:JournalContact:new.html.twig" at line 33

duplicated #688


fix doc typo when wrapping code block

As the result, the format is missing the document

File changed since then. Fixed already. But thanks anyway.


Migrate from junit.framework to org.junit

Summary:
Assert in junit.framework has been deprecated so we should migrate to org.junit
Link for help https://stackoverflow.com/questions/24013210/assert-in-junit-framework-has-been-deprecated-what-next-to-use
Would you like to work on the issue?
No

Hi, Can I work on this?

@BashCache Sure :)

Hi, I have changed the import statements from junit.framework to org.junit. Should I create a separate branch and push the code?
When I tried building the project, I get this error "Caused by: org.codehaus.groovy.control.MultipleCompilationErrorsException: startup failed:" , could you please help me out on building the project? Thanks a lot :)

Yes, you can create a new branch and open a PR. About the build issue you are facing, can you share the steps you performed while building the project? Make sure that your Android Studio, SDK and JDK are up to date.

Sadly this issue has been reappeared
w: /home/runner/work/apps-android-commons/apps-android-commons/app/src/test/kotlin/fr/free/nrw/commons/review/ReviewControllerTest.kt: (15, 24): 'Assert' is deprecated. Deprecated in Java
w: /home/runner/work/apps-android-commons/apps-android-commons/app/src/test/kotlin/fr/free/nrw/commons/review/ReviewControllerTest.kt: (16, 24): 'Assert' is deprecated. Deprecated in Java

Maybe a good solution would be removing the deprecated dependency altogether from the Gradle file.

Hello @madhurgupta10 ,
Sure, I will work on this and make the fixes.

Hi @nicolas-raoul Can I take this up?

@BashCache Any progress on this? :-)
@bhavanagarlapati Please take one issue at a time. Do not hesitate to come back to this one after sending a pull request for your currently assigned one. :-)

Hi @nicolas-raoul
I am so sorry. I missed it. You can assign this to someone else. Apologies again

@BashCache No problem, thanks for letting us know. :-)

Hi @nicolas-raoul , Im willing to work on this if this is not assigned yet

Hey @nicolas-raoul , is this issue still open? I see a few more assertions that use junit.framework
Can I work upon them?

@AnkitThakur98 Yes thanks! Looking forward to your pull request :-)


yunikorn-scheduler-web component start not normal

Install yunikorn by helm charts, found yunikorn-scheduler-web component start not normal.
1 yunikorn-scheduler-web container running.
2 Check yunikorn-scheduler-web container logs by kubectl logs -f cli, and found no output.
3 Entry into yunikorn-scheduler-web container inside, and found  web code dir '/usr/uiapp' not exists in container.
(yunikorn-scheduler-web docker image id is: db65c385b2dc)

I just tried locally, it seems to work fine.
 It was not built from latest source, but I don't think we have any code-level changes so far.

I just checked now and i was able to access
cud u pls share more errors if u have

thx @yangwwei  and @sunilgovind,
1 Check web container's log, no info or error:

2 Check web container inside, not found web code dir:

3 Which image you used in your local env?

@akhilpb001 do you have any idea about what could happen here?
Appreciate if you can take a look, thx.

Sorry,  ui code located in /usr/share/nginx/html, not /usr/uiapp.
But I still cannot see any log output when container start.

Lots has changed since the issue was logged, if the issue still exists please open it as a new jira:
https://issues.apache.org/jira/projects/YUNIKORN
github issues will no longer be used


[Discussion] squeezenet model; different num of classes

For training from scratch, the code would work fine. But mostly, people would use the pre-trained weights, so on top of setting the self.num_classes, you also have to change the final_conv layer, after setting pre-trained weights.
        final_conv = nn.Conv2d(512, self.num_classes, kernel_size=1)
        self.classifier = nn.Sequential(
            nn.Dropout(p=0.5),
            final_conv,
            nn.ReLU(inplace=True),
            nn.AvgPool2d(13))

While this may be straightforward in other models, in this the final_conv (local to init) is actually inside a sequential module. And when I tried to change only the final_conv layer from self.classifier (by writing classifier[1] = nn.Conv2d etc) I get the error 'Sequential object doesnt support item assignment').
Eventually I just changed the classifier block to a nn.Sequential module with the new conv, reflecting new number of classes.
Few things to ask/discuss:

Am I making some mistake in changing only the final_conv layer from inside classifier sequential module.
If not, should we change that part so that its easier to just change only the final_conv layer?
If the above isn't preferred, should I just add a comment somewhere so that people will know they have to change the classifier itself?
People should be able to figure it out, this is minor :P

3rd option makes sense as they might have to change AvgPool also, but I had removed it and was using the functional API for that, so didnt realize until now.
PS: Wasnt sure if this should be in Issues or in discuss. If latter is better, I will remove it and post there.

Adding to '2.' Converting it to ordered dict will help?

I just realized, this is the structure for all the models in the repo. A features seq module and a classifier seq module. So this issue is applicable everywhere, so people would know to change the classifier i guess?

I just submitted this PR with a rough version of a function that can change the number of outputs to various networks, including SqueezeNet
https://github.com/pytorch/vision/pull/175

Yeah, looks useful! Although I think people would prefer to this themselves? Not sure. But can you write some block comment in the function so that people don't have to read the code to understand what it does?

Ack, being able to use num_classes and pretrained=True at the same time for every model would be a big win. All functions instantiate pretrained models in two steps. Therefore, the approach was to update the state_dict() only if the size() of loaded parameters match the size() of vanilla modules instantiated by all the **kwargs. You can reuse this diff to freeze layers too.
Both, the version of merging and @danielhauagge's programatic version loaded the whole model zoo: https://github.com/ahirner/pytorch-retraining/blob/test_pr/load_pretrained.ipynb
Merging on the level of state_dict() doesn't assume that layers have specific types, though.
Should I make a PR?
PS: if so, what would be a nicer place / API?
# update_model(model, state_dict) in torchvision/models/utils.py
model = AlexNet(**kwargs)
    if pretrained:
        update_model(model, (model_zoo.load_url(model_urls['alexnet']))
    return model

or, because this will also work for models beyond torchvision:
# update_state_dict(self, state_dict, diff=False) for nn.Module
model = AlexNet(**kwargs)
    if pretrained:
        diff_keys = model.update_state_dict(model_zoo.load_url(model_urls['alexnet'])
        return (model, diff_keys) if diff else model
    return model

I think we should change the code in the model loading to handle the case of different models compared to the saved weight (allowing to modify the structure of the network).
Here is an example
def _update_with_pretrained_weights(model, model_path):
    model_dict = model.state_dict()
    pretrained_dict = torch.load(model_path)

    # 1. filter out unnecessary keys
    pretrained_dict = {k: v for k, v in pretrained_dict.items() if k in model_dict}
    # 2. overwrite entries in the existing state dict
    model_dict.update(pretrained_dict)
    # 3. load the new state dict
    model.load_state_dict(model_dict)

@fmassa Your example doesn't work because it doesn't handle different parameter sizes. Also, pretrained_dict will have less or equal amount of items than model_dict. Passing less items to load_state_dict() will throw intentionally.
I pruned a working example down to this:
    #Update
    model_dict = model.state_dict()
    pretrained_dict = model_zoo.load_url(model_urls[name])

    diff = {k: v for k, v in model_dict.items() if \
            k in pretrained_dict and pretrained_dict[k].size() != v.size()}

    pretrained_dict.update(diff)

    model.load_state_dict(pretrained_dict)
    return model, diff

With model loading code, do you mean adding a method to nn.Module or a helper function to torchvision? ....I'd really like to see update_state_dict() for the nn.Module (my second suggestion above). Then, there is no need to repeat that for text, sound, you name it.

@fmassa Your example doesn't work because it doesn't handle different parameter sizes. Also, pretrained_dict will have less or equal amount of items than model_dict. Passing less items to load_state_dict() will throw intentionally.
I pruned a working example down to this:
    #Update
    model_dict = model.state_dict()
    pretrained_dict = model_zoo.load_url(model_urls[name])

    diff = {k: v for k, v in model_dict.items() if \
            k in pretrained_dict and pretrained_dict[k].size() != v.size()}

    pretrained_dict.update(diff)

    model.load_state_dict(pretrained_dict)
    return model, diff

With model loading code, do you mean adding a method to nn.Module or a helper function to torchvision? ....I'd really like to see update_state_dict() for the nn.Module (my second suggestion above). Then, there is no need to repeat that for text, sound, you name it.

Hi@ahirner,
to freeze some of weights using the keys layers name in state_dict, what should I do?

Closing as I believe it's up to the user to specify which layers to re-use when fine-tuning.


Configurable timeout option..

From puppeteer documentation:
https://github.com/GoogleChrome/puppeteer/blob/v0.13.0/docs/api.md#pagegotourl-options

timeout  Maximum navigation time in milliseconds, defaults to 30 seconds, pass 0 to disable timeout.

I got an error then after googling it; it looks like it's common. and this PR will help fixing it.
Thanks for this package!

Thanks for your contribution@MohannadNaj!
This is published in version 1.3.1


[SCREEN] CAV intro screen

intro screen for volunteer with the options to:
--- Your cases
--- New cases

[ ] Build dummy visual page component

[ ] Integrate with redux and Firebase

ZenHub Information
This information is updated automatically. To modify it, please use ZenHub.

@ashwinkjoseph Is this done?


I mistakenly edited Index.cshtml.cs with code that should have gone into Index.cshtml.  How do I reset the code originally in Index.cshtml.cs

Problem encountered on https://dotnet.microsoft.com/learn/aspnet/hello-world-tutorial/modify
Operating System: windows
Provide details about the problem you are experiencing. Include your operating system version, exact error message, code sample, and anything else that is relevant.
I mistakenly edited Index.cshtml.cs with code that should have gone into Index.cshtml.  How do I reset the code originally in Index.cshtml.cs

You could simply generate a new webApp and copy the cshtml.cs content back to your tutorial webapp:
dotnet new webApp -o myWebApp --no-https
/Pages/Index.cshtml.cs
using System;
using System.Collections.Generic;
using System.Linq;
using System.Threading.Tasks;
using Microsoft.AspNetCore.Mvc;
using Microsoft.AspNetCore.Mvc.RazorPages;
using Microsoft.Extensions.Logging;

namespace myWebApp.Pages
{
    public class IndexModel : PageModel
    {
        private readonly ILogger<IndexModel> _logger;

        public IndexModel(ILogger<IndexModel> logger)
        {
            _logger = logger;
        }

        public void OnGet()
        {

        }
    }
}

/Pages/Index.cshtml
@page
@model IndexModel
@{
    ViewData["Title"] = "Home page";
}

Welcome

Learn about building Web apps with ASP.NET Core.

Thank you.  That’s in fact what I did.
Sent from my iPhone

On Oct 6, 2019, at 4:24 AM, Christian Hofmeister<EMAIL_ADDRESS>wrote:
You could simply generate a new webApp and copy the cshtml.cs content back to your tutorial webapp:
dotnet new webApp -o myWebApp --no-https
/Pages/Index.cshtml.cs
using System;
using System.Collections.Generic;
using System.Linq;
using System.Threading.Tasks;
using Microsoft.AspNetCore.Mvc;
using Microsoft.AspNetCore.Mvc.RazorPages;
using Microsoft.Extensions.Logging;
namespace myWebApp.Pages
{
public class IndexModel : PageModel
{
private readonly ILogger _logger;
    public IndexModel(ILogger<IndexModel> logger)
    {
        _logger = logger;
    }

    public void OnGet()
    {

    }
}

}
/Pages/Index.cshtml
@page
@model IndexModel
@{
ViewData["Title"] = "Home page";
}

Welcome
Learn about building Web apps with ASP.NET Core.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Thanks.


Add scrolling and enhance list of affected detectors

Issue #, if available: #193
Description of changes:
This PR changes 2 things about the batch action modals:

Adds scrolling functionality to prevent the list of detectors/monitors to be truncated.
Changes layout of the list to be an EuiDataGrid for cleaner formatting and readability.

Notes:

Removed the styling added for the EuiModalBody__overflow component. Instead, added an EuiSpacer in the ConfirmModal component to prevent the modal from being in an overflow state (see this line).
Confirmed existing modals don't unnecessarily show the scrollbar
Confirmed all UT pass

Screenshot (scrolling):

Screenshot (start batch action):

Screenshot (stop batch action):

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@ylwu-amzn @yizheliu-amazon scrolling issue fixed by the way, please read PR description for more


Option field llm is not necessary for loadEvaluator with type embedding_distance

Checked other resources

[X] I added a very descriptive title to this issue.
[X] I searched the LangChain documentation with the integrated search.
[X] I used the GitHub search to find a similar question and didn't find it.
[X] I am sure that this is a bug in LangChain rather than my code.
[X] The bug is not resolved by updating to the latest stable version of LangChain (or the specific integration package).

Example Code
const {loadEvaluator} = require("langchain/evaluation");
const {AzureOpenAI, AzureChatOpenAI, AzureOpenAIEmbeddings} = require("@langchain/openai");
...
const chain = await loadEvaluator("embedding_distance", {
        embedding: azure_embedding,
        distanceMetric: "euclidean",
    });
...

Error Message and Stack Trace (if applicable)
Error: OpenAI or Azure OpenAI API key or Token Provider not found
at new ChatOpenAI (C:\Users\ouki_wang\Desktop\Team\sandbox-companion\node_modules@langchain\openai\dist\chat_models.cjs:1032:19)
at loadEvaluator (C:\Users\ouki_wang\Desktop\Team\sandbox-companion\node_modules\langchain\dist\evaluation\loader.cjs:21:9)
at main (C:\Users\ouki_wang\Desktop\Team\sandbox-companion\05-sandbox.js:78:29)
at Object. (C:\Users\ouki_wang\Desktop\Team\sandbox-companion\05-sandbox.js:131:1)
at Module._compile (node:internal/modules/cjs/loader:1364:14)
at Module._extensions..js (node:internal/modules/cjs/loader:1422:10)
at Module.load (node:internal/modules/cjs/loader:1203:32)
at Module._load (node:internal/modules/cjs/loader:1019:12)
at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:128:12)
at node:internal/main/run_main_module:28:49
Description
we have tried to call loadEvaluator to get euclidean distance with embedding model.
However get error message without llm missing in option fields of loadEvaluator.
I think llm field is not necessary when call with type embedding_distance.
System Info
node test.js

sorry, wrong repo


顺序写反了 (The order is the opposite.)

https://docs.microsoft.com/zh-cn/dotnet/csharp/tutorials/intro-to-csharp/branches-and-loops?tutorial-step=3
此示例新引入了另外一个运算符。 ++ 变量后面的 counter 是增量运算符。 它负责用计数器值加 1，并将计算后的值存储在计数器变量中。

Translation:
This example introduces another operator. The counter after the variable is the delta operator. It is responsible for adding 1 with the counter value and storing the calculated value in the counter variable.

This issue was moved to dotnet/docs#18210


Can't use a symbolic link for the configuration file

If ~/.config/karabiner/karabiner.json is a symbolic link, Karabiner will overwrite it with a file instead of following the link.

https://pqrs.org/osx/karabiner/document.html#configuration-file-path


Refresh APNS Connection

Hello,
APNS service has a known. bug that, if you send a request in a session which stays idle for a while, APNS service returns an internal server error such that : "500 Internal Server Error: Unable to write frame"
Other push services overcome this problem by refreshing their APNS connections when they encounter this kind of a problem. (for example: https://github.com/relayrides/pushy/pull/529)
Is there a way to refresh  connection in Perfect Notifications?

When it goes to send msgs to an existing connection, the library will first try a PING to ensure the connection is still good. If it's not it will open a new one.
https://github.com/PerfectlySoft/Perfect-Notifications/blob/master/Sources/PerfectNotifications/NotificationPusher.swift#L305
Verify that you are using the latest tagged version, 3.0.4. If you are up to date and still seeing this issue then any further information you can provide would be helpful.


sspmp: typo fix for sspmp entry

bits 15:10 make up sspmp. fixing the typo

I am rejecting this PR as PR #60 addresses this.

Make sense then


missing 1.3.22 tag?

I see a 1.3.22 at http://search.npmjs.org/#/bones but no tag here.

just did this tag from 2bfc5d555f71f509afb3d284e53e999e5a8d571c, closing.


[Bug]: rspack.HtmlRspackPlugin favicon behavior inconsistent with html-webpack-plugin

System Info
System:
OS: Windows 10 10.0.19045
CPU: (12) x64 Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz
Memory: 6.27 GB / 31.73 GB
Binaries:
Node: 20.10.0 - C:\Program Files\nodejs\node.EXE
Yarn: 1.22.22 - C:\Program Files\nodejs\yarn.CMD
npm: 10.2.3 - C:\Program Files\nodejs\npm.CMD
Browsers:
Edge: Chromium (122.0.2365.92)
Internet Explorer: 11.0.19041.3636
Details
When using the html-webpack-plugin and supplying a path to a favicon property, the file at that path is copied into the output directory and the resulting html file has the favicon link pointing to the path of where the file was copied into the output directory. This works whether providing a relative or an absolute path.
When using rspack.HtmlRspackPlugin, the behavior is different.  Whether an absolute or relative path is provided, the directory structure to obtain that relative path will be copied into the output directory prepended with a forward slash.
For comparison purposes:
Webpack Absolute Path
Input: favicon: path.resolve(process.cwd(), 'static', 'favicon.ico'),
Output:
Rspack Absolute Path
Input: favicon: path.resolve(process.cwd(), 'static', 'favicon.ico'),
Output:
Webpack Relative Path
Input: favicon: path.join('static', 'favicon.ico'),
Output:
Rspack Relative Path
Input: favicon: path.join('static', 'favicon.ico'),
Output:
Although the Rspack behavior should work, webpack's behavior is preferable because the input directory as your input directory structure doesn't necessarily need to align with the output directory structure.
A similar closed issue existed for builtins.html, which is now deprecated: #2795
Reproduce link
https://github.com/kgregory/rspack-issue-htmlrspackplugin-favicon
Reproduce Steps

Provide favicon option when instantiating rspack.HtmlRspackPlugin
Run build process
Inspect build output folder's index.html file and look at the favicon  which has been generated.

Webpack uses path.basename to ensure that the favicon is generated under the root directory of publicPath.
But the rspack.HtmlRspackPlugin will generate based on the path which relative to compilerOptions.context.
I will try to fix this.


Travis fix and drop support for sf 2.6

Current coverage is 14.61%

Branch #22 has no coverage reports uploaded yet.

No diff could be generated. No reports for master found.

Powered by Codecov. Updated on successful CI builds.


[BEAM-4679] Re-adding Flatten roots in ULR.

This was causing issues while testing pipelines with the ULR, so this
is a quick fix for that.

Follow this checklist to help us incorporate your contribution quickly and easily:

[x] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

It will help us expedite review of your Pull Request if you tag someone (e.g. @username) to look at it.
Post-Commit Tests Status (on master branch)

Lang
SDK
Apex
Dataflow
Flink
Gearpump
Samza
Spark

Go

---
---
---
---
---
---

Java

Python

---

---
---
---
---

R: @angoenka
This fixes a few of the failing tests that popped up in the ValidatesRunner tests for the ULR.

Run Java PreCommit

Is this only needed for the tests or is it required for the correctness of the ReferenceRunner?

Please rerun ./gradlew  spotlessApply

Do we also need to add other primitive transforms here?
Reference: https://github.com/apache/beam/blob/master/runners/flink/src/main/java/org/apache/beam/runners/flink/FlinkBatchPortablePipelineTranslator.java#L133

I don't think that's necessary. This class only handles providers for roots of the pipeline. Theoretically only the ImpulseProvider should be necessary, but Java pipelines allow Flattens as roots, so to get the ValidatesRunner tests around that working this needed to be added.
Basically, I'm trying to avoid adding anything unless the ValidatesRunner tests fail otherwise.

Fixed up the nits and squashed the commits in preparation for merging.

Thanks @youngoli
We can merge this after the test cases pass.
cc: @tweise @lukecwik

Failing test cases
org.apache.beam.sdk.io.elasticsearch.ElasticsearchIOTest.testWritePartialUpdate
org.apache.beam.sdk.io.elasticsearch.ElasticsearchIOTest.testWriteWithIdFn
Are unrelated to this PR.

Rebasing to the most recent commit in master.

Ping for merge


fix: auto-updater on start, prisma output files on host machine

fixed autoupdate need trigger docker-compose up initially
added generate prisma file and shared to validator service

:tada: This PR is included in version 1.2.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Content ordering should be separated based on API it is served from

Problem
At the moment we are applying the same ordering rules for both Admin and Content API's which is not ideal. For example, we end up ordering page served from Content API using orderDefaultRaw , this instead could be just ordered by title. For this reason, ordering of content served from Content and Admin APIs should be separated.
Specification
The default order for resources returned from Content API should be:

Post: “published_at desc”
Page: “title asc”
Tag: “name asc”
Author: “name asc”

The order of resources served in Admin API should stay as is.
Ideally this would be put on the controller level once controller separation  is finished.
TODO

[x] Implement default ordering
[ ] Fix Alphabetical ordering bug
[ ] achieve consistent ordering independent of DB engine,

Not stale


In sequence mode, each press adds two characters and when deleted, also removes two

Steps to Reproduce

Switch to Macro mode -> Sequence mode
Start new sequence and press any letter
Press Backspace to delete letter.

Actual behavior
In sequence mode, each press adds two characters and when deleted, also removes two
Expected behavior
In sequence mode, each press adds one character and when deleted, also removes one
Screenshots
https://github.com/epam/ketcher/assets/62464241/0bc3a671-e4fc-4490-b488-a1b9ee035245
Desktop:

OS: Windows 11
Browser Chrome
Version 124.0.6367.79 (Official Build) (64-bit)

Ketcher version
[Version 2.22.0-rc.3]
Indigo version
[Version 1.21.0-rc.1]

Verified.

Indigo Toolkit Version 1.21.0-rc.1.0-g9194599b2-wasm32-wasm-clang-19.0.0
Ketcher Version 2.22.0-rc.4 Build at 2024-06-10; 17:29:31
Chrome Version 125.0.6422.142 (Official Build) (64-bit)
Windows 10

https://github.com/epam/ketcher/assets/62464241/4f3cf696-6c13-4970-acf7-716ae4a597ec
Tested. Bug fixed.
Desktop:

OS: Windows 11
Browser Chrome
Version 124.0.6367.79 (Official Build) (64-bit)

Ketcher version
[Version 2.22.0-rc.4]
Indigo version
[Version 1.21.0-rc.1]


[No QA] Create InlineSystemMessage component

Details

Fixed Issues
$ https://github.com/Expensify/Expensify/issues/211552
Tests
We can't really display this component yet, since we don't store network errors on actions for now, so, to test this, you can call the component around here so it displays under all messages. You can pass anything as the message prop:

We'll do more thorough testing of the component and its visual when we actually place it

Ready for review!

I could only get it to display in the message header, please save me from my stupidity and help me figure out exactly where to place the component :D

I could only get it to display in the message header, please save me from my stupidity and help me figure out exactly where to place the component :D

Here:
                <>
                <ReportActionItemFragment
                    key={`actionFragment-${props.action.sequenceNumber}-${index}`}
                    fragment={fragment}
                    isAttachment={props.action.isAttachment}
                    attachmentInfo={props.action.attachmentInfo}
                    loading={props.action.loading}
                />
                <InlineSystemMessage
                    message={'This is the error message, yeah'}
                />
                </>

Make sure to group both components with <> </>

Comments addressed!

Looks good to me on both mobile and web 👍

🚀 Deployed to staging by @Julesssss in version: 1.1.68-1 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by @Julesssss in version: 1.1.68-2 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

🚀 Deployed to production by @Julesssss in version: 1.1.68-2 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

🚀 Deployed to production by @Julesssss in version: 1.1.68-2 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

Please ignore these duplicated messages, we only deployed once but the message appears each the iOS deploy fails.

🚀 Deployed to production by @Julesssss in version: 1.1.68-2 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

🚀 Deployed to production by @Julesssss in version: 1.1.68-2 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅


fix: switch to gh to support default branches not named master.

hub was throwing the following error:
Error creating pull request: Unprocessable Entity (HTTP 422)
Invalid value for "base"

(e.g. https://github.com/neverendingqs/serverless-websocket-example/runs/2247538637?check_suite_focus=true)

See https://github.com/neverendingqs/gh-action-node-update-deps/pull/13


Autocomplete popup behaves erraticly

A recent regression leads to visual issues in the autocomplete popup.
The actual issue is hard to describe but manifests in appearing/disappearing or varying heights of the item list.

Most probably it is introduced in b4cd7c829a7d17888902f5468d4ea0a0f1084c42.

I just filed #2997 to describe more specifically an aspect of this that I see. Between that and #2791 , @borisyankov , do those cover what you had in mind here?
If not, let's get another issue filed with a more specific description; then let's close this one in favor of the more concrete issues.

Maybe also #2943 ? Though I don't 100% understand what #2943 is saying.

Closing this in favor of the various more-specific issues.


Implement from_texts class method in weaviate VectorStore

We should implement all abstract methods in VectorStore so that  users can use weaviate as the vector store for any use case.

from_texts now implemented in the weaviate VectorStore


Add pitch angle to AK8963 for Bebop

On the Parrot Bebop, the magnetometer is mounted with a slight angle compared to the IMU, which caused an inaccurate sensor calibration. This PR rotates the sensor measurements accordingly and fixes #5571.
See #5236 for more details.

Such a peculiar rotation :smile:, thanks @eyeam3.

I have just seen this PR. Strange nobody asked the people here at Parrot.
Just so you know, this is the rotation matrix we use :
-0.984807753012208,  0, -0.173648177666930
0,                -1,                  0
-0.173648177666930,  0,  0.984807753012208
It is approximately the same as yours.


Rpg.js example not working chrome..

I downloaded the repo and opened the demo with Chrome
Blank Screen
I then opened it with Firefox..
Worked just fine.
i did not modify the demo at all. Same result on windows and Ubuntu.

Apparently Chrome did not understand ../
it was an easy fix!