neovim-unwrapped: use outputChecks

Description of changes
disallowedRequisites and friends will be ignored if __structuredAttrs is used. In Nix versions <2.24 and Lix <2.91 this happens silently, in newer versions a warning is printed.
The solution is to use outputChecks.

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

I will trust you on this

See also the warning section at https://nix.dev/manual/nix/2.24/language/advanced-attributes#adv-attr-structuredAttrs

just it would probably be best to target staging

I don't think that's necessary: it's mostly vimplugins being rebuilt.

See also the warning section at https://nix.dev/manual/nix/2.24/language/advanced-attributes#adv-attr-structuredAttrs

thanks for the pointer pretty cool !

I don't think that's necessary: it's mostly vimplugins being rebuilt.

I used to think like that but I thin the sheer number of jobs is already a problem to scheduling. And the darwin builder is already slow enough as it is. This PR is not critical, it's not a problem to wait for it I think

@teto done.


Question about dropping DB

I have a question regarding new versions and when you say it's 'Safe to drop your zenbrain DB before this update.'
Does this mean I should or must drop the database?  It takes my computer a day or two to resync - and I loose some historical data - especially for exchanges that don't support backfill.  I'd rather not drop if I can get away with it.

It's not required to drop it, so I don't say "you must" drop the db. But due to code changes, esp. recently shifting around the RSI calculation params, your old data might be obsolete, not trigger the trader correctly, or cause other unforseen issues. If you run into issues after updating, try dropping your db and re-running run.sh, which should restart the map/reduce from raw data.
I might create some CLI commands to help with the data management, and some additional options like saving the thoughts as raw data, which can be fed into the reducer at a later date or on a separate machine. In the mean time I recommend the mongodump and mongorestore utilities, with these you can backup and transfer your db around as you like.


Replace prettier-standard by official prettier config

As recommended by Prettier docs, you should use the official prettier eslint config instead of using eslint plugins. I think prettier-standard falls in this category and should not be recommended in this list.
I can make a PR for this if you want.

also, he doesn't maintained

@alcpereira A pull request would be awesome for this change.


Getting list

Hi
We have 3 units and only the first one is coming in with the list command. Anyone else encountered this behavior?
Thanks

What is the output when you are using list combined with dump?

Never mind, it seems to be working now.


Added link to Gradle tool window

As someone new to Compose, I did not know how I'm supposed to "Open build.gradle.kts as a project". It'd be helpful to add a link since this is a tutorial.

I think this link only confuses, but not clarifies how to do it. It is about gradle support in IDEA, not about opening file as a project.

Think it is useful, as it shows where to look for Gradle.


Export Solution Task takes longes time than expected

HI,
I have only added 3 entities with minimal components in the solution. When I run the pipeling it is taking more tha 30 minutes to export the solution and it is still running.
Please help!

Same issue as mine i think #278. I'm currently trying to execute the same logic on my custom build server.

@bipinshan @mkellenbenz how long does it take to export from the UI? And how long is it taking from build server?
Are you using hosted or private agents?

Hi Wael,
It took around 3 minutes from UI to export the same solution.
I am using default hosted agent only which is populated automatically when we create new pipeline in Azure devops.

Increasing the timeout somehow solved the issue on one of my test projects https://github.com/WaelHamze/xrm-ci-framework/issues/278#issuecomment-641598437.
I've run it multiple times now consistently working. Maybe MSFT did something...

There is a lengthy thread https://github.com/WaelHamze/dyn365-ce-vsts-tasks/issues/183 in the task repo on this. Lately it seems the 1st Export of the day often hangs regardless of the timeout. After cancelling, the second one runs fine. There is an laternative PowerShell script posted on that thread that attempts to work around this and seems to band-aid the problem.


File.byLine terminator string

bearophile_hugs reported this on 2010-12-26T07:11:51Z
Transfered from https://issues.dlang.org/show_bug.cgi?id=5378
CC List

andrei
dlang-bugzilla
nick
rumbu

Description
This is the signature of File.byLine:

ByLine!(Char,Terminator) byLine(Terminator = char, Char = char)
(KeepTerminator keepTerminator = KeepTerminator.no, Terminator terminator = '\x0a');

But on Windows the line terminators are 2 chars long (CR+LF), see:
http://en.wikipedia.org/wiki/Newline#Representations

So I think the second argument of argument byLine() needs to be a string.

This is code I expected to use, that currently is not accepted:

import std.stdio;
void main() {
    auto lines = File("test.txt").byLine(File.KeepTerminator.no, "\r
");
}

----------------

After that bug report, a little enhancement request: generally on Windows I usually open files with Windows-style line terminators, while on Linux I open files with Unix-style line terminators, so if possible a better default for the second argument of byLine() is a string constant that changes according to the operating system.

----------------

A workaround is to open the file in text mode, but I don't know if this works well if you want to open a Windows-style file on Linux:

import std.stdio;
void main() {
    auto lines = File("test.txt", "r").byLine();
}

dlang-bugzilla commented on 2013-03-16T01:40:03Z
Would it be acceptable if we special-cased byLine to strip a trailing \r if the terminator is \n?

Often, the programmer doesn't know beforehand if the line terminator of a text file will be \r\n or \n. A behavior close to that of splitLines would be more useful than forcing the programmer to choose an exact terminator sequence.

andrei commented on 2013-01-08T01:11:43Z
This is by design. The length name is special and defined to return size_t compulsively. You may want to choose a different name instead.

andrei commented on 2013-01-08T01:12:15Z
Oops, wrong window.

andrej.mitrovich commented on 2013-03-18T12:11:08Z
*** Issue 9750 has been marked as a duplicate of this issue. ***

bearophile_hugs commented on 2013-03-17T17:44:06Z
(In reply to comment #3)
> Would it be acceptable if we special-cased byLine to strip a trailing \r if the
> terminator is \n?

Probably the problem presented in this issue has various solutions.

nick commented on 2013-08-08T07:18:09Z
https://github.com/D-Programming-Language/phobos/pull/1458

github-bugzilla commented on 2013-08-11T19:19:36Z
Commits pushed to master at https://github.com/D-Programming-Language/phobos

https://github.com/D-Programming-Language/phobos/commit/7f76586e16623894c7b6119014f76ed7bfef527e
Fix Issue 5378 - Make File.byLine accept a string terminator

Add an overload of byLine without a default argument for terminator.
Before, byLine!string tried to instantiate "string terminator = '\n'",
which is invalid.

Note: This removes the default arguments from ByLine.this, but the
constructor was never documented anyway (unlike the range primitives).

https://github.com/D-Programming-Language/phobos/commit/5576d899af510de798b0d5aaa8bd13e6caebfbce
Merge pull request #1458 from ntrel/byLine-crlf

Fix Issue 5378 - Make File.byLine accept a string terminator

rumbu commented on 2021-02-11T08:37:04Z
Default behaviour is unexpected, at least on Windows where most files contain lines ended in \r\n.

Use of lineSeparator enum for cross platform development does not guarantee that the file you are processing contain only the lineSeparator terminator.

If I ask byLine, I expect to obtain a line not something else, not a line ended with another line terminator. What if my file contains some lines ended in \r and other line ended in \r\n?

Default behaviour must strip terminators and must consume all known line separators, there is no point to discriminate between them:
- 0x0d
- 0x0d\0x0a
- 0x0a
- Unicode categories Zl, Zp.


Readme and project cleanup

Removes unneeded COPYING.txt, which has been replaced with
LICENSE.
Updates readme to:

Remove extraneous whitespace.
Correct minor dialog box text errors.
Change copy to read a bit better.

:+1:


2023 Release Notes

Release notes for Fall 2023 release.
Do not merge until SAM and SSC version numbers are updated and installation files are posted on SAM website Downloads page
This gh-pages branch is a special documentation branch that does not contain any code. Release notes are automatically published at https://nrel.github.io/SAM/doc/releasenotes.html. SAM website redirect points to that URL: https://sam.nrel.gov/releasenotes.
This branch can be viewed as a webpage at https://htmlpreview.github.io/?https://github.com/NREL/SAM/blob/a67c5420c64c6a0ae54adc486efc8bfbe2447f0e/doc/releasenotes.html
Note that the link will change if Paul pushes to this PR.
I think this will work to show latest committed version:
https://htmlpreview.github.io/?https://github.com/NREL/SAM/blob/2023-release-notes/doc/releasenotes.html

My only comment would be to add the self-consumption dispatch to the list of highlights, as I think that will be a popular option. Otherwise looks good here!


Removed the warning when installing extensions for PHP 7

While PHP 5.6 only receives security updates and PHP 7 overall now represents over 50% of installations, the warning in the question seems no more relevant.

Coverage increased (+0.02%) to 51.459% when pulling 1b82254b5c39540dea29703c6bb1578dc8ae2105 on morozov:no-php7-warning into 5f19573ee9dae96bcb2250b3006e5eece6425c6e on phpbrew:master.

Coverage increased (+0.02%) to 51.459% when pulling 1b82254b5c39540dea29703c6bb1578dc8ae2105 on morozov:no-php7-warning into 5f19573ee9dae96bcb2250b3006e5eece6425c6e on phpbrew:master.

Coverage increased (+0.02%) to 51.459% when pulling 1b82254b5c39540dea29703c6bb1578dc8ae2105 on morozov:no-php7-warning into 5f19573ee9dae96bcb2250b3006e5eece6425c6e on phpbrew:master.

Coverage increased (+0.02%) to 51.459% when pulling 1b82254b5c39540dea29703c6bb1578dc8ae2105 on morozov:no-php7-warning into 5f19573ee9dae96bcb2250b3006e5eece6425c6e on phpbrew:master.

Coverage increased (+0.1%) to 51.576% when pulling c2eabb29d3ddbf6b4d64fcb5a58e89b10ea1e7d2 on morozov:no-php7-warning into 5f19573ee9dae96bcb2250b3006e5eece6425c6e on phpbrew:master.

LGTM
the warning that the version of extensions should match the version of php is applied to all php versions, not only 7.x. I think simpily removing it or changing it to a notice for all versions is ok.

@jhdxr I would just remove it. If the extension is successfully installed, there's nothing to warn/notify above. If it fails, there may be a thousand reasons to that besides version incompatibility. Without the actual logic which detects compatibility, this message doesn't add any value.

looks good, I think most of the users are now installing extensions for php7 not for php5. so I think this is good to be merged.


Agency theme-nav bar problem on mobile devices

I am using the agency theme as a multi page theme but the problem I face is that when I switch to any page on my website other than the home page the navigation bar doesnt work. I dont know whats wrong. Can somebody help ?

This is likely not an issue with the agency code but is an issue with the changes you made when turning it into a multi-page site.  You probably need to check that your hrefs are pointing to the correct page.  You can test his by changing...
Portfolio

to...
Portfolio

If you upload your fork to github or provide the url it's hosted at I'll take a quick glance at it.  Also what do you mean by not working?  Clicking on the links causes no action whatsoever?

Thanks for replying back. By not working I mean that the navigation bar on mobile devices doesnt work except for the home page. the site url is www.platzo.com ...the navigation bar in about page and the contact page doesnt work on mobile devices.

Well for one you're missing a closing div in your navbar.  Hopefully that gets you fixed up.
Also - Not the source of your problem but links to pages on the same domain can be cleaned up...
href="http://platzo.com/contact.html"

should be...
href="/contact.html"

Thanks for replying. I did put the closing div in the navbar. but the problem still seems to exist. I would like you to please go through the code and let us know why the navigation bar doesn't work on mobile devices.
thanks

Pound signs (#) and dots (.) are used for referencing another HTML/DOM element.  However they are NOT used in class or id attribute values.

should be...

The link from your navbar toggle div to your navbar collapse div is broken because of this.

Thanks a lot. I was stuck with this problem since like a week. Thanks. I was wondering can you please check out our about page and help me with the social media buttons. they just don't show up, in the amazing team section.
thanks.

You're welcome.  I can help you debug your site but not for free.  If you want to discuss please get in touch using my profile's public email so we don't clog up everyone's inbox.  Alternatively you can pursue answers on stackoverflow but you'll need to work on getting minimal examples. http://stackoverflow.com/help/mcve
Please close this issue so others know it is not am open problem with this repo.


Add Args() to surface arguments supplied to a process

This helps expose the command line arguments for all processes running on a given machine. This functionality is currently supported only on Linux and OSX.

Is there any chance this could get a second look? This would make this library pretty interesting


The failure of readyness probe leads to a crash of the proxy

As outlined in https://github.com/Kong/charts/blob/main/charts/kong/values.yaml, both the liveness and readyness probes rely on status_listener of Kong.
However, pods stop receiving the traffic through Kubernetes service if the readyness probe fails, which means that the liveness probe can't serve traffic after the readyness probe fails.
Moreover, in the event of a database outage, the readyness probe will fail, potentially leading to the destruction of the Kong pod.
Considering this, I am wondering whether the liveness probe should be modified to a different approach rather than a http probe given that the readiness probe typically does not result in application termination.

@liverpool8056 It is possible to change the liveness probe and readiness probe. You can see an example (default) configuration of the probes here:

readiness probe: https://github.com/Kong/charts/blob/e2f4d3a5636a1f5980c7261c2dc4f2ea7e977843/charts/kong/values.yaml#L810
liveness probe: https://github.com/Kong/charts/blob/e2f4d3a5636a1f5980c7261c2dc4f2ea7e977843/charts/kong/values.yaml#L822

You can update these settings in your values when you install Kong by helm.

Were you seeing an issue in practice? Can you provide replication steps?
Which versions are you using? The endpoints returning failure due to a database outage was a bug that affected older versions of Kong. Current versions should return successful responses (albeit with database.reachable=false) if the database is offline. If you're seeing failures on the latest Kong version, we'd want to investigate that as a bug.
While failing readiness does remove a replica from the list of Service endpoints, this should not affect the liveness check. Kubernetes' probe requests are issued on a per-replica basis directly from the kubelet. They do not pass through the Service, which instead dispatches a request to only one replica at random. Non-ready Pods should still receiving continuing readiness and liveness probes if they become unready.

Thanks @randmonkey for your workaround. Though it is an alternative, I think it would be better to provide users with a more reliable one natively.
@rainest Here is the FTI I worked on last month: https://konghq.atlassian.net/browse/FTI-5346, and the reproduce steps are available in it.

While failing readiness does remove a replica from the list of Service endpoints, this should not affect the liveness check.

This is true, the liveness and readyness probes are independent with each other. However in this case, the liveness probe is a http one. After being removed from the list of endpoints due to the failure of readyness, the pod actually is no longer ready for receiving any traffic, it seems the http liveness probe can't reach the pod either, thus it leads to the failure of liveness. That's what I observed from the FTI.

@liverpool8056 As @rainest has mentioned, liveness probes and readiness (NOT readyness!) probes are called by kubelet to each pod, NOT found by endpoints.
Also, liveness probe and readiness probe supports exec mode to execute a command in the container and tcp mode to test whether a TCP port is open: https://kubernetes.io/docs/tasks/configure-pod-container/configure-liveness-readiness-startup-probes/. You can also change the liveness probe to exec like this:
    livenessProbe:
      exec:
        command:
        - cat
        - /tmp/healthy
      initialDelaySeconds: 5
      periodSeconds: 5


maintainers: add kranuarg7

Description of changes
Ref: https://github.com/NixOS/nixpkgs/pull/222164

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

trace: maintainer kranurag7 (line 8195) should be listed after kragniz, not after kranzes (line 8189)
In the meantime, I would suggest adding yourself in a separate commit in #222164, instead of opening a new PR.

Thanks, @wegank, I'm closing this PR, and I've added another commit on the same PR.


[SP-6544] - Backport of PDI-20100 - 'Get subfolder names' step does not work with Windows mapped drive (10.1 Suite)

Original PR:

https://github.com/pentaho/pentaho-kettle/pull/9318

@pentaho/tatooine_dev

 Note:

Frogbot also supports Contextual Analysis, Secret Detection, IaC and SAST Vulnerabilities Scanning. This features are included as part of the JFrog Advanced Security package, which isn't enabled on your system.

🐸 JFrog Frogbot

:white_check_mark: Build finished in 16m 23s
Build command:
mvn clean verify -B -e -Daudit -Djs.no.sandbox -pl core

:ok_hand: All tests passed!
Tests run: 1243, Failures: 0, Skipped: 1    Test Results

:information_source:  This is an automatic message


"Gherghești", "Greci" are listed in the drop-down menu

Description:
When user writes ” Gherghești” and "Greci" the locations appear in the drop-down menu next to the comune and the county which is a part according to the law.
Precondition:
The website is up an running.

Step 1
Write in the search bar "Gherghești"

Expected results
The location appears in the drop-down menu as "Sat Gherghești, DÂMBOVIȚA (Petrești)".

Step 2
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 3
Write in the search bar "Greci"

Expected results
The location appears in the drop-down menu as "Sat Greci, DÂMBOVIȚA (Petrești)".


Update mvc-with-entity-framework.rst

I found that I was unable to run the migrations until I made this change. Might have worked for others previously. Just trying to help.

Hi @StevenElliott, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, DNFBOT;

Probably good to change the dnvm use 1.0.0-beta5 to dnvm use 1.0.0-beta7. Then you won't need the . when executing dnx ef migration add Initial and dnx ef migration apply (when you are in your project folder)

This article really needs a broad update to the latest bits, but I'm going to go ahead and merge this in so at least the content is consistent with beta5.
9e7f03d5356c3205f78706bde8777a2b54175372
Thanks!


[FEA] Documentation request.

Good work!
Could you share more info about your thesis or any documentations?

Hi,
I attached the master thesis. Any particular wished for additional documentation? Also remember that this is still just a proof of concept, we are planning to create a new version with additional features and higher quality next year.
ROS2_cross-process_data-flow_scheduling-3.pdf

Good enough! There is also a ppt file in roscon2023 page! https://roscon.ros.org/talks/Real-time_Data-flow_extension_for_ROS_2.pdf


Nonce parameter is missing in Google SignIn?

Use case
My application requires nonce verification.
In web browser - I can attach "clientid=xxx..&nonce=abcd123..." as query parameter to google auth url .
Google sign in returns "code" -> processing the code returns access token and idToken
So that i can get & verify the nonce value from idToken.
But nonce key is missing in idToken returned from flutter google SignIn. (because there is no way to attach nonce key to GoogleSignIn())
Proposal
Is there any way to add "nonce" value to GoogleSignIn();

Any update🙄⁉

Is it okay if we change this code to use gms.auth.api.identity instead of gms.auth.api.signin or we need to create a new method and file? (It will also enable an Android / Web to use the new One Tap Sign In, so cross-platform experience will be more intuitive):
https://github.com/flutter/plugins/blob/main/packages/google_sign_in/google_sign_in/android/src/main/java/io/flutter/plugins/googlesignin/GoogleSignInPlugin.java
https://developers.google.com/identity/one-tap#:~:text=One Tap is our new,streamlining multiple types of credentials.

i am not aware of 'gms.auth.api.identity' and 'gms.auth.api.signin' .
Create a new method / Any workaround to add nonce parameter is ok

@bharathraj-e did you find a workaround? I found the same issue but only on Android.


Should password reset request route return error?

Related to https://github.com/zooniverse/Panoptes-Front-End/issues/905 and https://github.com/zooniverse/Panoptes-Front-End/issues/616
Could the password reset request route never return an error? We can squelch errors on the front end, but returning errors in this case confirm if an email exists, which isn't great.

Yeah - we should probably do replicate devise does and create a inavalid user with the correct error messages.

What kind of error messages would you like to return @camallen? I read it like the proposal was to never return an error, and always pretend everything was ok and a reset mail was sent?
I'm happy to take this btw.
(If you're really serious you'll still have timing attacks to worry about (not finding a record and thus not enqueuing a mail takes less time, which is detectable). I think that's probably overkill for our application though.)

Just replicate the behaviour as if it was a html form submission as per here and here.

Will do. We would still need to turn on Devise paranoid mode to handle @chrissnyder second point?

@marten can you add in the paranoid mode as well?

@chrissnyder so you'll get 200's now for almost everything even when there is no associated email in the db (it just won't send reset instructions). It will return 422 if there is no supplied email address so if you just ensure that form can only be submitted via a valid email format string it should cover our bases.

Looks perfect, thanks!


Update nether blocks to use UserID as primary key instead of gamertag

To support guest logins (#430) we are changing from using gamertag as primary key to the UserId which will be properly immutable
For player management this will likely be simple. For Leaderboard where we need to report the gamertag, this will need more thought.

[ ] Update database schemas
[ ] Update SQL EF migrations
[ ] Update APIs and callers
[ ] Update documentation

Completed for PlayerManagement in #455


Web - Owed information is wrong when sending money request between accounts

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Login to account A and Account B on different devices
From account A: send Money request to account B, with "amount = X"
From account B: send Money request to account A, with SAME "amount = X
"
Observer that: these 2 request will be marked as paid automatically
From account B: send ANOTHER money request to A, with "amount = Y"
Check the request information

Expected Result:
The request information should say “A owes Y”

The “Pay elsewhere button” is displayed on account A

Actual Result:
The request information shows “B owes Y”

The “Pay elsewhere button” is displayed on account B

Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[x] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: 1.3.35-5
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/93399543/d4001c21-24ad-44b8-86f9-4b49ff618132
https://github.com/Expensify/App/assets/93399543/5558c72d-275b-4d9d-aef6-5402db96c2e5
Expensify/Expensify Issue URL:
Issue reported by: ToanSel
QA Engineer - Github: @tranvantoan-qn
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1688446357913299
View all open jobs on GitHub

Proposal
Please re-state the problem that we are trying to solve in this issue.

The text ${payer} owes ${amount} is confusing when looking from the requestor's perspective.

What is the root cause of that problem?

The text is confusing because it is written from the perspective of the payer, not the requestor.

What changes do you think we should make in order to solve the problem?

The text should be written from the perspective of the requestor. Like You owe ${amount}.
For the payer, the text should be same ${payer} owes ${amount}.

What alternative solutions did you explore? (Optional)

N/A

Was able to reproduce, thinking/hoping this can be External

I am unable to reproduce the issue on latest dev. This PR seems to have already fixed the issue.

Also unable to reproduce so closing, amount owed is now showing correctly. comment if you disagree

@mallenexpensify
I tried to verify it on main, but it seems like when A sends a request money to B, the amount with be paid automatically.?
(so I couldn't perform the same set of steps to reproduce it)
https://github.com/Expensify/App/assets/10254571/6f55b436-8a14-4fba-b2ce-ed4a52b202a0

@mallenexpensify
Clear cache helps fix the "auto-paid" issue above, but the issue is still happening after step 4 as mentioned in Action Performed.
Please check the attached image - in which I added a details explanation. Let me know if I can help to reproduce it

https://github.com/Expensify/App/assets/10254571/74f35572-3805-46be-8c02-f551a716f261

@mallenexpensify
Hope that you can consider 2 things:

The issue doesn't seem to be completely fixed as it's still occurring.
Am I eligible for a reporting bonus? My report was valid and initially had no connection with this PR

Thank you!

@tranvantoan-qn I tried to repro again a couple times between two accounts, back and forth, with no luck.
For the bug reporting bonus, since @kbecciv was able to reproduce, it appears it was a valid bug.  I looked around to try to find the PR that fixed it, d you know @tranvantoan-qn or @aimane-chnaif ?

@mallenexpensify When I was helping to test this PR and it looks like it fixed this issue somehow:
https://github.com/Expensify/App/pull/20821/

Checking in Slack https://expensify.slack.com/archives/C049HHMV9SM/p1689627262480169?thread_ts=1688446357.913299&cid=C049HHMV9SM
I'd like to know what PR fixed this before deciding on potential payment for the reporting bonus.

Thanks @tranvantoan-qn .   So... it seems like we had this

https://github.com/Expensify/App/issues/20486

Which then lead to this

https://github.com/Expensify/App/issues/22332

The PR for the above was

https://github.com/Expensify/App/pull/22484

And... somewhere along the line the bug presented itself then was fixed somewhere/how.
Does that sound right @tranvantoan-qn ?

Thanks @tranvantoan-qn .  @aimane-chnaif can you review and provide feedback?  Normally, in order to be compensated for reporting a bug that was fixed elsewhere, it's the contributor's responsibility to prove their report was before the one that was associated with the PR that fixed the issue.  But... we're uncertain what that PR is, so it's hard to know.

Checking internally.  @tranvantoan-qn , we don't have a process to pay without proof so this is a bit tricky.

Yes, I understand. But I've seen some exceptions when everyone initially agrees that the bug report is invalid
https://github.com/Expensify/App/issues/21158
https://github.com/Expensify/App/issues/21996
So I hope my cases be considered too (

@tranvantoan-qn can you please accept the job and reply here once you have?
https://www.upwork.com/jobs/~01ac3ffaa7bc12de84
You reported a valid bug that was reproducible and now it's not, and no one can identify where/how it was fixed, I asked for help/ 👀 multiple times too.

@mallenexpensify
Thank you! I've accepted the offer

@mvtglobally can you do one more test to see if this is reproducible? If not, can you please close?  Thx

Issue reporter: @tranvantoan-qn paid $250 via Upwork
Closing, as mentioned above, this was a valid bug when it was reported and we were unable to determine what fixed it, so compensation was due


Add explanation of submodule usage in README.md

Codecov Report

Merging #38 (85bb1b6) into master (878e7ee) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #38   +/-   ##
=======================================
  Coverage   85.45%   85.45%
=======================================
  Files           1        1
  Lines          55       55
=======================================
  Hits           47       47
  Misses          5        5
  Partials        3        3

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 878e7ee...85bb1b6. Read the comment docs.


.Net: Splitting semantic and native function internal implementations

Description
Splitting semantic and native functions into internal implementations of ISKFunction. This helps to isolate the (largely independent) code paths and bring clarity to the internal implementation.
This change does NOT introduce breaking changes; all public properties and methods are preserved.
Note: In a future change, the interface and properties will be further edited, and that will be a breaking change. This PR is a first pass, and aims to clean things up as much as possible with zero impact to the public API surface.
Steps ahead:

Removing methods from the public ISKFunction interface if they only apply to one type
Adding helpers to identify and cast to the correct type
Splitting semantic functions into its own package -- the SemanticKernel.Core/Abstractions packages will have no direct knowledge of prompt templates or semantic functions as it will be exposed as a plugin package (that functionality will remain available by default for anyone using the Microsoft.SemanticKernel metapackage).

Contribution Checklist

[X] The code builds clean without any errors or warnings
[X] The PR follows the SK Contribution Guidelines and the pre-submission formatting script raises no violations
[X] All unit tests pass, and I have added new tests where possible
[X] I didn't break anyone :smile:

Stampy.

Went with your advice (NativeFunction and SemanticFunction). Keeps it clear. Another glace pls.


"terraform init" failures should post failure root cause in the "Digger run report"

Just noticed that when "terraform init" fails, the root cause is not posted in the "Digger run report".
Maybe it could be posted under a "Init for [project name]" collapsible comment

hey @fleroux514 ! Yes indeed this is a good improvement point for digger 😄 we are on it

Can I take this one? @motatoes
Something like this?

@isaacmcollins sorry for delayed response! Absolutely go for it , please feel free to submit a PR for this issue :)) The screenshot looks great to me 👌


How open-inference-protocol works in LLMs, any use case?

With the increasing popularity of LLMs, many companies have started to look into deploying LLMs.
Instead of infer/predict, completions and embeddings are being used. Most of the API supports stream.
Example API spec:

OpenAI API
Azure OpenAI Service REST API reference.

I would like to check if there is any use cases in the community using open-inference-protocol on LLMs andis there a road map to natively support or extend open-inference-protocol to have better support in LLMs?
The good thing about open-inference-protocol is it standardizes the way people interact with models, and it is very useful when it comes to developing a transformer (pre/post-processing) and integrating different transformers and predictors into an inference graph. A standard protocol also makes it easy to develop a serving runtime that supports different kind of LLMs.
Thanks.

Thanks @lizzzcai ! We just added this agenda to today’s US community meeting

Another example of an API from HuggingFace's Text Generation Inference server: https://huggingface.github.io/text-generation-inference/

captured some of my thoughts on the API Spec discussed here.

However, I want to bring up a topic on the API Spec. Currently the schema is following to HF. However, from my experience of playing around with LLM and some of the third-party toolkit building on top of LLM/ChatGPT so far, I feel like openAI spec will be the better option as most of the third-party LLM applications are supporting it out of the box, which means a better ecosystem and user experience. If user deployed a LLM model in KServe however the API cannot be used in the LLM toolkit, it will be hard to promote it.


[for consideration] new hosts lists...please review

Found it recently,from what i can gather it's been around,it's maintained,not sure how well though.The lists is big,around 238000 lines,there are duplicates also but i guess it's worth checking it out.I'll leave the rest to the experts,here is the link:
https://adzhosts.fr/index-en.php
CC @StevenBlack  @ScriptTiger  @funilrys  @anudeepND  @FadeMind

As we've experienced in the past, hosts files this large come with many issues.  The user experience is  not tolerable on some mobile devices, and some Windows installations.
  I think I know: they mostly just cumulate, and grow larger.  Someone generates a thousand-line list of garbage, submits it, and the aggregate is  thousand lines longer.
I'm not going there.
I'm already uneasy because we're over 50k Hosts.


[Tracking] Cloud Native Sustainability Week 2024 Gurugram

Description

Location/Region: Opstree Solutions
Organizers: Monika Rajput , Ankit Yadav, Pankaj Raghav
Sponsors: Opstree solutions, StackGuardian
Date: 5th October 2024
Event link: https://community.cncf.io/events/details/cncf-cloud-native-gurugram-presents-sustainable-hacktober/

Details

We have 5 talks that will focus on Sustainability.
Open discussion among attendees.

To-Do

[X] Review the Meetup Organizer Guide for onboarding.
[X] Check the website.
[X] Create a PR to update the Meetup's table on the website. Example PR.
[X] Join one of the TAG ENV Sustainability Week Syncs to talk about your event.
[X] Find a sponsor for the event.
[X] Find a location for the event.
[X] Set a date for the event.
[X] Announce the event.
[X] Reach out to the Cloud Native Sustainability Week Organizer team to promote the event.

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Comments
No response

Thanks for adding this, we will track this under India. Do you have everything you need form the TAG side?


Improve interactions with Laravel assumptions

Adds a second trait, with functionality provided for reasons cited in this article:

The getIncrementing() method is used by Eloquent to know if the IDs on the table are incrementing. Remember we are using UUIDs, so we set auto-incrementing to false.
The getKeyType() method just specifies that the IDs on the table should be stored as strings.

Hey, sorry for the delay thanks! Merged!

Hey, thanks for adding this @danhunsaker and @kilrizzy. I noticed this feature does not seem to be in a tagged version, so it's not installable via composer without using dev-master. Any chance we can bump the version number for packagist?


Update permission levels 9 and 10 to support multiple bot owners

Either through client.settings.botOwners or by adding another export to the config file.
Been trying to set this up but it's not working and I'm losing my mind.

866ffeb947f5c1099efb67b44df08285cdfa7667


#6264 avoid ignoring the caught exception

Impact

[x] Bug fix (non-breaking change which fixes expected existing functionality)
[ ] Enhancement/New feature (adds functionality without impacting existing logic)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Similar to https://github.com/liquibase/liquibase/pull/6286, but in many other places.
I found all places where IDEA shows warning "catch block may ignore exception", and fixed many of them.

@asolntsev thanks so much for submitting this PR. We'll review it and get back to you soon.

Hhi @asolntsev,
Thank you for submitting another PR for Liquibase. In general, this PR looks good to me. The only thing I have for commenting here is in some cases we are logging an error message in the catch block as a warning or even maybe as info log message. I think maybe we can update these to the right log level. What do you think about it?
Thanks,
Daniel.

I think maybe we can update these to the right log level

Generally I like the idea :)
But I intentionally didn't change any logic to keep the PR scope as small as possible.
In some cases, "info" might be totally fine:

e.g. if LiquiBase could not get DB version because DB connection has been closed by this moment
or if DB doesn't support such a function.


Default Browser?

I wouldn't call this an issue per say, but I would really appreciate a dialogue with the developer or the more experienced community that uses browser plus on the following question. Is it possible to set atom's browser plus as the default browser in windows?
I prefer browser plus over chrome, firefox, ie, everything. I'd like to set it as my default browser, but seeing as browser plus is a package within a text editor, windows may not have a GUI solution for such a setting.
Is there some reg edit way I can set browser plus as the default browser? Or maybe I can set Atom as the default "browser" then have browser plus automatically activate upon atom initialization?
Or if default browser toggling doesn't pan out, is there at least someway to open a html file with browser plus (someway more direct than opening a html file with atom, then activating the package)?
Please advise,
Thank you

You are right . This could be made into electron based browser ie. a standalone browser. we would need a wrapper around. Anybody willing to do I can help.Right now I don't have the bandwidth.


Add missing keywords when ecmaVersion = 6

Add missing keyword autocompletion for ES6, e.g. let const static etc.
Only works when ecmaVersion = 6
nothing has changed in ES5
Fix #784

Thanks. Merged as 0de94999c, updated in ead32cf20d97


Convert the readme from RST to markdown

Changes

Converted Readme from RST to Markdown
Added Pallets-eco notice to readme

@paxnovem Great work! Thanks for taking care of Flask-rq 🎉


Workflow doesn't switch to the selected window when pressing enter

Hello!
The workflow does initially work by showing the currently open and active windows, but then when selecting one and pressing enter nothing happen and therefore it doesn't switch to the desired window. I'm on Monterey 12.6 and I'm using the latest version of the workflow v2023.4
I apologize if my issue ticket doesn't correspond to the github standards I'm not used to the platform yet
Kind regards
Here is the debugging :
[11:27:10.545] Logging Started...
[11:27:18.070] Window Switcher[Script Filter] Queuing argument '(null)'
[11:27:18.096] Window Switcher[Script Filter] Script with argv '(null)' finished
[11:27:18.099] Window Switcher[Script Filter] {"items":[{"match":"Alfred Preferences Alfred Preferences","title":"Alfred Preferences","arg":[50912,110151],"subtitle":"Alfred Preferences","icon":{"type":"fileicon","path":"/Applications/Alfred 5.app/Contents/Preferences/Alfred Preferences.app"}},{"match":"MARCHE MOI DESSUS (Among Us) - YouTube 🔊 Brave Browser.app","title":"MARCHE MOI DESSUS (Among Us) - YouTube 🔊","arg":[564,109485],"subtitle":"Brave Browser.app","icon":{"type":"fileicon","path":"/Applications/Brave Browser.app"}},{"match":"Comment faire un superbe flou artistique avec un flou de tracé dans Photoshop | Tuto Photoshop - YouTube Brave Browser.app","title":"Comment faire un superbe flou artistique avec un flou de tracé dans Photoshop | Tuto Photoshop - YouTube","arg":[564,896],"subtitle":"Brave Browser.app","icon":{"type":"fileicon","path":"/Applications/Brave Browser.app"}},{"match":"EmmanuelCorreia - YouTube Brave Browser.app","title":"EmmanuelCorreia - YouTube","arg":[564,109333],"subtitle":"Brave Browser.app","icon":{"type":"fileicon","path":"/Applications/Brave Browser.app"}},{"match":"DesignCourse - YouTube Brave Browser.app","title":"DesignCourse - YouTube","arg":[564,94052],"subtitle":"Brave Browser.app","icon":{"type":"fileicon","path":"/Applications/Brave Browser.app"}},{"match":"⚠ If You Want To Make MONEY With Blender - YouTube Brave Browser.app","title":"⚠ If You Want To Make MONEY With Blender - YouTube","arg":[564,24042],"subtitle":"Brave Browser.app","icon":{"type":"fileicon","path":"/Applications/Brave Browser.app"}},{"match":"Communicate your ideas through storytelling and design - Google Digital Garage Brave Browser.app","title":"Communicate your ideas through storytelling and design - Google Digital Garage","arg":[564,96843],"subtitle":"Brave Browser.app","icon":{"type":"fileicon","path":"/Applications/Brave Browser.app"}}]}
[11:27:24.431] Window Switcher[Script Filter] Processing complete
[11:27:24.436] Window Switcher[Script Filter] Passing output '(
564,
24042
)' to Conditional
[11:27:24.437] Window Switcher[Conditional] Processing complete
[11:27:24.437] Window Switcher[Conditional] Passing output '(
564,
24042
)' to Run Script
[11:27:24.475] ERROR: Window Switcher[Run Script] raise_window/main.swift:11: Fatal error: Unexpectedly found nil while unwrapping an Optional value

Please don’t skip the issue template. That would’ve made the issue more organised and easier to understand.
Have you tried it with other windows? Try it with one which does not have emoji in the title, and on a window from another app.

The closing was accidental. Reopened.

Ho I'm sorry about the issue template, I sure won't forget about it next time.
I just tried as you advised with other windows that do not contain emoji's in their tittle as well as on other windows from different apps such as Spotify and it didn't work either.

Has this always been the case or did it start happening recently? Could you:

Restart macOS.
Try again with fewer windows.

The goal being to test with a cleaner slate to get a better sense of where the issue may lie.

I only very recently stubbed upon this workflow actually, so yeah I guess in some way we could say it has always been the case.
Also I'm sorry about this but I have to finish some work based on a lot of opened windows from many active apps right now thus I'm afraid won't be able to restart macOS tonight. But be certain I'll keep you posted about how it goes when I will do so tomorrow !

Any followup, or shall we close?

Closing for lack of followup.


BUG: Event section calender text overflowing

Is there an existing issue for this?

[X] I have searched the existing issues

What went down?
I was just wandering on the mobile preview and i found this issue.

Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a gssoc-24-extd contributor
[X] I want to work on this issue
[X] I check the issue doesn't exist

not needed for now @Nvntdad


Visio chat github

[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 502be84d-8d2a-6c03-a118-279608698898
Version Independent ID: 502be84d-8d2a-6c03-a118-279608698898
Content: About the GitHub Copilot Chat extension for Visual Studio - Visual Studio (Windows)
Content Source: docs/ide/visual-studio-github-copilot-chat.md
Service: visual-studio-windows
Sub-service: ai-tools
GitHub Login: @anandmeg
Microsoft Alias: meghaanand

@Kahute344 There's no description of the issue that you encountered. Can you clarify your feedback?

@Kahute344
We'll close this issue for now. If you get a chance to write up your feedback, we can take a look at that.


fix Travis matrix by reverting matrix.include

Travis builds are failing because https://github.com/nodejs/nodejs.org/issues/1191. I'll kick them once that upstream bug gets resolved.


:sparkles: feat(alpha): Update docs in anticipation for release

Description
Concise description of proposed changes
Testing
Explain the quality checks that have been done on the code changes
Additional Information

[ ] I read the contributing docs (if this is your first contribution)

Your ENS/address:

Current dependencies on/for this PR:

main

PR #185

PR #186

PR #187

PR #188

PR #189

PR #190   👈

This comment was auto-generated by Graphite.

Current dependencies on/for this PR:

main

PR #185

PR #186

PR #187

PR #188

PR #189

PR #190   👈

This comment was auto-generated by Graphite.


Only use compact signature when signature length is 132 chars (0x + 65 bytes)

Fixes #323

Codecov Report
Patch coverage: 100.00% and no project coverage change.

Comparison is base (d9a28a9) 98.17% compared to head (c20bd86) 98.17%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #325   +/-   ##
=======================================
  Coverage   98.17%   98.17%
=======================================
  Files          33       33
  Lines       14019    14025    +6
  Branches      672      672
=======================================
+ Hits        13763    13769    +6
  Misses        251      251
  Partials        5        5

Files Changed
Coverage Δ

src/seaport.ts
96.80% <100.00%> (+0.01%)
:arrow_up:

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


[Feature Request]: make security logins editable through Ui

What feature would you like to see added to TallyArbiter?
Let the user modify the settings and producer pages logins through the UI. Including removing completely if that’s what they really want.

Great idea, I like it. It would also be nice to be able to add multiple users with different credentials.
However, please let's either do this directly in #204 or in a feature branch after #204 is merged because we already have a huge merge conflict there. That will be even bigger with more changes to master.


Fix missing from material update

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 74.532%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
695

Relevant Lines:
866

💛  - Coveralls


fix Docker start steps

Fixes DOC-3408.
These steps were actually fixed and working in v20.2, but were apparently lost when the v21.1 docs branch was cut (presumably from an older version). I've restored the changes from v20.2 to the subsequent versions.
@smcvey Thank you very much for locating the issue!

This change is


Where did all the whitespace go?

@lkpttn can you have a look? @mikefantini any idea how we got here?

@joolaay I'm not sure, @lkpttn and/or @DFurnes should though.

As far as I know, spacing is all the standard multiples of 24px from all the Neue 6 updates. It might be worth sitting down to figure out specific problem areas?


Common rollup changes

What

Fix incorrect logic when suppressing chai's circular dependency warnings
Move to the common dev-tool configuration where possible

Why
This is a longstanding issue that we have, where an incorrect logic was copy-pasted to other places. I figured while cleaning this
up that any package I touch can just convert over to the shared dev-tool configuration. Where I was unable to do that, I just
fixed this bug to avoid too many changes in one PR.
Fixes #14292
Resolves #17818
Resolves #17816
Resolves #17815
Resolves #17814
Resolves #17813
Resolves #17810

/azp run js - service-bus - tests

/azp run js - event-hubs - tests

/azp run js - app-configuration - tests

/azp run js - anomalydetector - tests


Functions specs are not correct

Functions, accepting "FSM name" as an argument (transition, state, allowed?, etc.), have wrong typespec.
Type GenServer.name does not cover String.t() for one (fsm name as string is used in documentation examples).
It should be any(), as in function fqn/0. Since fsm name is always passed to that function anyway.

Hi @egidijusz, thanks for the PR. indeed, of course.

Thank you!


Include commit message and branch naming convensions in the contributing.md

Currently, our contributing.md document lacks a branch naming convention and example commit messages.
This document plays a crucial role in maintaining a cohesive structure throughout the project and will greatly aid new contributors in familiarizing themselves with the project. Therefore, we need to incorporate standardized commit message formats and branch naming conventions in accordance with established community best practices.

As this issue suggests I have improved contributing.md with some standard naming conventions for commits as well as branches. I tried providing some examples with it as well, if you find some improvements please let me know, I'd be happy to improve with PR #43 :)

Can we close this one?

I think so, there are still some typos though in the contributing.md. I think eventually we can create other issues for that.


SDN-4168: Add required packages for IPsec tests

This adds required packages into network-tools image and it would help build and import certificates onto worker nodes for IPsec north south e2e test. For more information, see the comment here.

/assign @npinaeva @tssurya

CI is red, ptal

/retest


parse grouping sets, rollup, and cube

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

107 of 120 (89.17%)  changed or added relevant lines in 3 files are covered.
38 unchanged lines in 7 files lost coverage.
Overall coverage decreased (-0.3%) to 89.933%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/parser.rs
16
29
55.17%

Files with Coverage Reduction
New Missed Lines
%

src/ast/data_type.rs
1
76.32%

src/ast/query.rs
1
87.08%

src/ast/value.rs
1
86.67%

src/ast/ddl.rs
2
81.67%

src/ast/mod.rs
6
75.2%

src/tokenizer.rs
7
90.61%

src/parser.rs
20
84.52%

Totals

Change from base Build<PHONE_NUMBER>:
-0.3%

Covered Lines:
5887

Relevant Lines:
6546

💛  - Coveralls

need to rebase onto #367


chore: update CHANGELOG for release v25.5.0-beta.0

Summary
One of the preparation steps for release v25.5.0-beta.0
Test plan
Green CI
Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information
N.A.

Pull Request Test Coverage Report for Build 4589

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 92.91%

Totals

Change from base Build 4581:
0.0%

Covered Lines:
1120

Relevant Lines:
1155

💛  - Coveralls


improved chatbot.py

Hello @rajnathprasad! Thanks for opening this PR.

In the file chatbot.py:

Line 23:75: E231 missing whitespace after ','
Line 33:71: E231 missing whitespace after ','

Do see the Hitchhiker's guide to code style

@rajnathprasad Please fix the pep8 issues listed up: https://github.com/scalability4all/voice-enabled-chatbot/pull/59#issuecomment-701763311


Using Whisper API instead of local offline Whisper model,

Thanks for this great tool,
Do we have any plan to implement this via OpenAI Whisper API call instead of using transcription/diarization locally?
Please consider this implementation as well,

hi,
I don't have such plan. I suppose that OpenAI Whisper API would be too slow for real-time.
But PR are possible -- start with a new subclass  of ASRBase.

#52 -- FYI, @ngtrphuong , it's almost done. Let's discuss there.


The ESLint lib was loaded again after a while.

Why lint a file from node_modules for no reason?

Happend to antfu's as well

It doesn't matter about the ESLint config, what matters might be vscode-eslint.


[FR]: Ability to type a tag in the select tag field

Contact Details
No response
Present your request
I have tons of tags and also tons of nested tags on top of them, so to quickly add a tag i would love to have ability to start typing and the results would sort themselves up. I do have an alternative to dataview query for my case but i do know some non-tech background people tend to be scared from dataview. For them and speeding up my workflow i would love to have tag being searchable by typing. Thanks

For which platform do you request this request??
Desktop

Also the scroll doesn't seem to help, it is shown to be rending no scroll bar, i am able to scroll but have no idea where i am.
UI

It is a simple addition that can give a lot of value, it seems reasonable

When bug #411  would be resolved we would be able to query multiple tags with dataview. So why not just implement that behavior here as well, I mean when we would be able to type tags we should be able to type MULTIPLE tags after the resolution of #411.

The possibilities and cases are infinite with dv queries. Currently I think its not a priority to dev more source options
Its too much effort for something that already exist

Yeah that's reasonable, lets skip this and focus on just the tag typing enhancement.


theo-agent fails if theo server returns invalid key

it should ignore the invalid key (logging the error via syslog) and continue

Already fixed


path must be absolute or specify root to res.sendFile

Bug report

What is the current behavior?
I have the node.js server:
const express = require('express');
const path = require('path');
const app = express()
  .use(express.static( path.join(__dirname, '../static') ))
  .use(express.json())
  .use(express.urlencoded({ extended: true }))
  .get('/', (req, res) => {res.sendFile( path.join(__dirname, '/../static/index.html') )});

const http = require('http').Server(app);
const io = require('socket.io')(http);
const PORT = process.env.PORT || 3333;

http.listen(PORT, () => {
  console.log(`server listening on ${ PORT }`);
});

I prefer to write:
res.sendFile(__dirname +  '/../static/index.html')
but I have the Angular on frontend and it needs
path.join(__dirname, '/../static/index.html')
it works nice, but now I want to concat and minimize my files.
so I use this config:
var path = require('path');
var nodeExternals = require('webpack-node-externals');

module.exports = {
  entry: './server/src/index.js',
  output: {
    path: path.resolve(__dirname, './server'),
    filename: 'server.js'
  },
  mode: 'production',
  devtool: false,
  target: 'node',
  externals: [nodeExternals({
        modulesFromFile: true,
    })],
}

it builds fine and the server starting fine.
but when I try to see the resut in browser, I get the error:
TypeError: path must be absolute or specify root to res.sendFile
If the current behavior is a bug, please provide the steps to reproduce.
you just need to run:
webpack
node server/server
Here's the repository: https://github.com/muturgan/pretty-chat

What is the expected behavior?
minimized code contains absolute or specify root paths
the server can give my static

Other relevant information:
webpack version:  4.14.0
Node.js version: 8.11.3
Operating System: windows 8
Additional tools: express 4.16.3, angular 6.0.8, webpack-node-externals 1.7.2

add
node: {
  __dirname: false,
}

to the config

it works!
thank you wery much!

@sokra could u please explain what the problem is and why this solution works?

webpack polyfills __dirname in bundles. This disables that.


Only set translation for parent terms?

When creating a new Term and adding a new Parent, currently both get the same translation.  E.g. from the Tutorial, click on "dogs" and create a new Term with new parent "dog", translation "woof."  When saved, "dogs: woof" and "dog: woof" are both created -- but that's kind of redundant.
Would it be better to save the translation with the parent only?
I've created branch set_translation_for_parent_only which implements this, but it makes Lute look like it loses data.   eg create new term for "dogs":

On save, the "dogs" and "dog" term hovers look good, however, when I click on "dogs" again I see the following:

This looks like some data has been lost.

I could add the parent translation to the form (as text only, not as an input box), perhaps that would suffice.  Might make the form long, but maybe that wouldn't matter.  The child translation box size could be decreased in that case, b/c it likely would just inherit the parent.

Note that this would mean that the term wouldn't have its own translation, so in the term listing e.g. it would be necessary to have the parent term's description show up, perhaps with the parent prepended to make it clear, e.g.:

term
parent
translation

gatos
gato
cats; (gato) cat

gatito
gato
(gato) cat

Not going to do this one for now, due to weird "data loss" issue.


fix(object-property): infinite loop on type recursion

Object types have been expanded at creation time which means that the following code within a components prop type declarations would lead to an ifinite loop.
export interface FooProps {
  test: string;
  bar: BarProps;
}

export interface BarProps {
  foo: FooProps;
}

Object properties will now be expanded at render time (only if the user expands them in the property pane).

Review done, only minor comments.

My comments are ok now, thanks!


🐞 - Broken icons via CDN

Playground Link
impossible to show it on playground
Description
If you deploy an app to CDN by the docs a browser breaks icons due to security reason ( Unsafe attempt to load URL <URL> from frame with URL <URL>. Domains, protocols and ports must match.)
Note that <base> and APP_BASE_HREF are different in that case
Angular version
15.2
Taiga UI version
3.22.0
Which browsers have you used?

[X] Chrome
[ ] Firefox
[ ] Safari
[ ] Edge

Which operating systems have you used?

[ ] macOS
[X] Windows
[ ] Linux
[ ] iOS
[ ] Android

as workaround
        {
          provide: TUI_SVG_OPTIONS,
          useFactory: () => {
            const baseHrefFromDOM = inject(DOCUMENT).getElementsByTagName(`base`)?.[0]?.href;
            const path = tuiIconsPathFactory(`${baseHrefFromDOM}assets/taiga-ui/icons`);
            return {
              ...TUI_SVG_DEFAULT_OPTIONS,
              path,
            };
          },
        },

@constantant hi, you can use TUI_ENSURE_BASE_HREF instead of const baseHrefFromDOM = inject(DOCUMENT).getElementsByTagName(base)?.[0]?.href;

@splincode nope, it is not working

could you create a simple github repository with an example of how you build a project to check if everything is working fine on it

@splincode you can check it here and look at the code here


Initial support for Bazel

This PR includes:

Bazel support for the following parts of old DAAL:

Services and Data Management
classifier, covariance, distributions, dtrees/forest/classification, dtrees/forest/regression, engines,
kernel_function, kmeans, k_nearest_neighbors, normalization/zscore, pca, qr, svd, svm.

Bazel support for the new interfaces
Bazel support for oneAPI C++ examples.
Dependency management for TBB, FPK (incl. FPK for GPU), read env variables or download from GitHub dependencies.
Automatic CPU detection for one-CPU build.
Only statically linked binaries are available.
Support Linux, Intel, GNU and DPC++ compilers.

Set compiler
export CC=icc # To set Intel Compiler (default)
export CC=gcc # To set GNU compiler
CC=gcc bazel build :release # Example without export

Build and run examples/tests
To run one test and see PASSED/FAILED (all needed dependencies will be built automatically)
bazel test //<test_target>

To run one test and see output (all needed dependencies will be built automatically)
bazel run //<test_target>

To run an example (all needed dependencies will be built automatically)
bazel test //examples/oneapi/cpp:pca_cor_dense_batch

To run all examples (all needed dependencies will be built automatically)
bazel test //examples/oneapi/cpp:all

Linking modes for tests

dev mode (default). Link tests against only required dependencies for the <test_name>
bazel test //<test_name> --@config//:test_link_mode=dev  # This is default flag value

static mode. Link tests against static libraries
bazel test //<test_name> --@config//:test_link_mode=static

release_static mode. Link tests against static libraries from DAALROOT. Useful in case we have separate oneDAL build and we want to run only tests.
bazel test //<test_name> --@config//:test_link_mode=release_static

Build binaries
bazel build //cpp/daal:core_static            # Build libonedal_core.a
bazel build //cpp/daal:thread_static          # Build libonedal_thread.a
bazel build //cpp/daal:sequential_static      # Build libonedal_sequential.a
bazel build //cpp/oneapi/dal:static           # Build libonedal.a
bazel build //cpp/oneapi/dal:static_dpc       # Build libonedal_dpc.a

Build release
Creates release directory structure in bazel-bin/release, currently includes header files and binaries.
bazel build :release      # Build release structure

/intelci: run

2 issues found by CodeFactor - extra space between #! at file start
tool_not_found.tpl.sh
merge_static_libs_lnx.tpl.sh

/intelci: run
set infra_branch=dev/risrafil-initial-bazel

/intelci: run
set infra_branch=dev/napetrov_bazel_init

Overall looks ok - the only remaining problem is linux EOLs in autogenerated files on windows

/intelci: run
set infra_branch=dev/napetrov_bazel_init

/intelci: run
set infra_branch=dev/napetrov_bazel_init


Customer Segmentation Using Clustering(NOT the Usual K-means One)

In the project the Customer Segmentation is done using a combination of three algorithms ( DBSCAN, Hierarchical and K-means),
The user can input the dataset and get the output in the form of graphs and can also download the csv files of individual clusters, Additionally Shilloute scores have been displayed to understand the efficiency of the clusters. I want to add this project to your repo as this would be a great application of machine learning that would help learners understand the practical applications. Please assign this to me under GSSOC'24. Thank you.

please assign me this issue @SkSadaf

Hi, i got busy with leaderboard launch, assigned this issue to you

Thanks for assigning the issue, I am working on it.


feat(RHTAP-963): Also collect some monitoring data

Description
Collect some cluster-wide monitoring data once test is done
Issue ticket number and link
https://issues.redhat.com/browse/RHTAP-963
Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?
Made just limited test of bits here and there. I hope CI could show us more.
Checklist:

[x] I have performed a self-review of my code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] I have added meaningful description with JIRA/GitHub issue key(if applicable), for example HASSuiteDescribe("STONE-123456789 devfile source")
[ ] I have updated labels (if needed)

Tested and looks OK. See the resulting load-test JSON here: https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/origin-ci-test/pr-logs/pull/openshift_release/39785/rehearse-39785-pull-ci-redhat-appstudio-e2e-tests-main-load-test-ci-10u-10t/1663855191419523072/artifacts/load-test-ci-10u-10t/redhat-appstudio-load-test/artifacts/load-tests.json
This PR is ready to be merged.

/retest

/retest

/retest

/retest

/retest

/lgtm

/retest


ConformanceChecker: Minor diagnostics QoI improvements

This fixes a few issues with ensureRequirementsAreSatisfied:

We forgot to diagnose a conformance failure on all requirement check recovery paths (decoupling checkGenericArguments and requirement failure diagnosis allows for emitting the conformance failure before we diagnose the requirement failure).
The location for the failed requirement specification note was off.

@swift-ci please smoke test

@swift-ci please smoke test

@swift-ci please smoke test macOS

@swift-ci please smoke test macOS

@swift-ci please smoke test macOS

@swift-ci please smoke test macOS

Something is off with either GitHub or CI, it is triggering itself automatically on a rebase..

@slavapestov Addressed all your comments; could you have another look? Thanks in advance.

@swift-ci please smoke test

@swift-ci please smoke test

@slavapestov ping

@swift-ci please smoke test

@swift-ci please smoke test

@slavapestov Thanks!


Final states on substates can be transitioned from

Bug or feature request?
I think this is a bug.
Description:
A final state on substate can be transitioned from:
const fetchMachine = Machine({
  id: 'fetch',
  initial: 'idle',
  states: {
    idle: {
      on: { FETCH: 'substate'}
    },
    substate: {
      initial: 'done',
      states: {
        done: {
          type: 'final'
        }
      },
      on: { RESET: 'idle' },
    },
  },
});

where the same is not possible on the root state:
const fetchMachine = Machine({
  id: 'fetch',
  initial: 'idle',
  states: {
    idle: {
      on: { FETCH: 'done'}
    },
    done: {
      type: 'final'
    },
  },
  on: { RESET: 'idle' },
});

It seems to me that both cases should work in a consistent manner - the transition should be disallowed (I was kinda surprised that we can exit something which is marked as final) or transition should be allowed in both scenarios and the behavior should be documented
(Bug) Expected result:
Consistent behavior.
(Bug) Actual result:
Slightly confusing one 😉

I think there is a valid use case for being able to transition out of a final state - but if someone suggests a better way I’d be happy to change my mind.
Imagine n independent on/off switches, each of which can transition between on and off at any time. But when all switches are on, and only then, something happens.
If transitions out of final states are permitted, you can model this with n parallel substates, where each “on” is a final state, with onDone on the parent to proceed. To me this feels natural.
(This doesn’t work if you only need, say, a majority of the switches to be on to trigger the action. I guess the alternative is to use context to count the on/off values, and a guard somewhere to decide whether to proceed.)

Final state is final only locally. Final state prevents transitioning from that state to other siblings. This should not prevent transitions to siblings of the parent(s).
For me, this sounds like a feature.

This is as-expected. Only in top-level state nodes (direct children of the machine) can a final state node terminate the state machine: https://www.w3.org/TR/scxml/#final
The use-case for having a final state in a nested state node would be to transition from it when it is done:
    substate: {
      initial: 'done',
      states: {
        done: {
          type: 'final'
        }
      },
      on: { RESET: 'idle' },
      onDone: 'anotherState' // transition out of this substate
    },
    anotherState: { ... }

Thanks for the clarifications!


isStoreinDB Parameter in application.properties missing

Need to correct and re-test as the isStoreinDB property is missing

Resolved with enhancement to application.properties


Stop after finding first draggable element

Currently if we have a draggable inside a draggable, both are selected and move, not just the top one.
This PR stops creating new DragDrop() objects after the first.

Looks great, thanks!


Newcastle Under Lyme STS

Newcastle under Lyme has two alternatives which are not true place names.
Please move the search records from Newastle U Lyme and Newcastle undr Lyme to Newcastle Under Lyme and remove these two alternative names.

Geoff

Done


Enable role to view API endpoint configuration Internal/Observer

Problem
Hi Team,
We have a concern with the Internal/Observer role in APIM 4.1.0 where users are able to view the APIs but not able to view the endpoints and the advanced endpoint config as follows.

But we want to view the advance endpoint configs (need to check the timeout values) and with the above role it can not be done, This can be done with a customization from UI level which allow user to view the advanced endpoint configs mark in red color in above screenshot, but we want to know whether it is possible to add this as a feature for internal/observer role.
Thanks,
Vikum
Solution
ui customization
Affected Component
APIM
Version
4.1.0
Implementation
No response
Related Issues
No response
Suggested Labels
No response

closing as the public fix: https://github.com/wso2/apim-apps/pull/493 has already been merged.


[CARBONDATA-3531]Support load and query for MV timeseries and support multiple granularity.

Why this PR?
This PR implements load and query supports and some of the MV bug fixes.
Timeseries on MV supports different granularities like below:
second, minute, thirty_minute, fifteen_minute, ten_minute, five_minute, hour, day, week, month, year.
Bug Fixes:

Fix the filter query not hitting MV timeseries.
Fix between filters not working on timeseries query

Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:

[ ] Any interfaces changed?

[ ] Any backward compatibility impacted?

[ ] Document update required?

[ ] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance test report.
- Any additional information to help reviewers in testing this change.

[ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

This commit is on top of #3437

Build Failed  with Spark 2.3.2, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.3/773/

Build Failed with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.2/771/

Build Failed  with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.1/765/

Build Failed  with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.1/767/

Build Failed with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.2/773/

Build Failed  with Spark 2.3.2, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.3/775/

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.1/768/

Build Failed with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.2/774/

Build Failed  with Spark 2.3.2, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.3/776/

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.1/771/

Build Failed with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.2/777/

Build Failed  with Spark 2.3.2, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.3/779/

Build Failed with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.2/819/

Build Failed  with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.1/815/

Build Failed  with Spark 2.3.2, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.3/822/

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.1/817/

Build Failed with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.2/820/

Build Failed  with Spark 2.3.2, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.3/823/

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.1/865/

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.1/867/

Build Failed with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.2/871/

Build Failed with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.2/873/

Build Failed  with Spark 2.3.2, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.3/875/

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.1/891/

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.1/892/

Build Failed with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.2/899/

Build Failed  with Spark 2.3.2, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.3/900/

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.1/910/

Build Failed with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.2/917/

Build Failed  with Spark 2.3.2, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.3/918/

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.1/918/

Build Failed with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.2/925/

Build Success with Spark 2.3.2, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.3/926/

@akashrn5 : please rebase

@ajantha-bhat rebase done. We can wait for builds to get success

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.1/926/

Build Success with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.2/933/

Build Failed  with Spark 2.3.2, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.3/937/

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.1/931/

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.1/933/

Build Failed with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.2/938/

Build Failed with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.2/941/

Build Failed  with Spark 2.3.2, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.3/943/

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.1/935/

Build Success with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.2/944/

Build Success with Spark 2.3.2, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.3/945/

LGTM

LGTM


add docs for user-manual for volto frontend

#3827
This is the proposed structure or outline of first page for user-manual docs for volto frontend. It is only a start to have something to look at and discuss. Feedback welcome.
Proposed:
Screencast from 03-12-22 03:57:46 PM IST.webm
I, Mohammad Hussain, agree to have this contribution published under Creative Commons 4.0 International License (CC BY 4.0), with attribution to the Plone Foundation.

max_786 your emails are not known to GitHub and thus it is impossible to know if you have signed the Plone Contributor Agreement, which is required to merge this pull request.
Learn about the Plone Contributor Agreement: http://docs.plone.org/develop/coredev/docs/contributors_agreement_explained.html How to add more emails to your GitHub account: https://help.github.com/articles/adding-an-email-address-to-your-github-account/

Thanks, @stevepiercy 😊 for your thoughtful input, I'll look into these changes and will respond accordingly.

@MAX-786 you need to sign the Plone Contributor Agreement in order to merge this pull request.
Learn about the Plone Contributor Agreement: http://docs.plone.org/develop/coredev/docs/contributors_agreement_explained.html

max_786 your emails are not known to GitHub and thus it is impossible to know if you have signed the Plone Contributor Agreement, which is required to merge this pull request.
Learn about the Plone Contributor Agreement: http://docs.plone.org/develop/coredev/docs/contributors_agreement_explained.html How to add more emails to your GitHub account: https://help.github.com/articles/adding-an-email-address-to-your-github-account/

@MAX-786 you need to sign the Plone Contributor Agreement in order to merge this pull request.
Learn about the Plone Contributor Agreement: http://docs.plone.org/develop/coredev/docs/contributors_agreement_explained.html

max_786 your emails are not known to GitHub and thus it is impossible to know if you have signed the Plone Contributor Agreement, which is required to merge this pull request.
Learn about the Plone Contributor Agreement: http://docs.plone.org/develop/coredev/docs/contributors_agreement_explained.html How to add more emails to your GitHub account: https://help.github.com/articles/adding-an-email-address-to-your-github-account/

@MAX-786 you need to sign the Plone Contributor Agreement in order to merge this pull request.
Learn about the Plone Contributor Agreement: http://docs.plone.org/develop/coredev/docs/contributors_agreement_explained.html

max_786 your emails are not known to GitHub and thus it is impossible to know if you have signed the Plone Contributor Agreement, which is required to merge this pull request.
Learn about the Plone Contributor Agreement: http://docs.plone.org/develop/coredev/docs/contributors_agreement_explained.html How to add more emails to your GitHub account: https://help.github.com/articles/adding-an-email-address-to-your-github-account/

@MAX-786 you need to sign the Plone Contributor Agreement in order to merge this pull request.
Learn about the Plone Contributor Agreement: http://docs.plone.org/develop/coredev/docs/contributors_agreement_explained.html

max_786 your emails are not known to GitHub and thus it is impossible to know if you have signed the Plone Contributor Agreement, which is required to merge this pull request.
Learn about the Plone Contributor Agreement: http://docs.plone.org/develop/coredev/docs/contributors_agreement_explained.html How to add more emails to your GitHub account: https://help.github.com/articles/adding-an-email-address-to-your-github-account/

@MAX-786 you need to sign the Plone Contributor Agreement in order to merge this pull request.
Learn about the Plone Contributor Agreement: http://docs.plone.org/develop/coredev/docs/contributors_agreement_explained.html

max_786 your emails are not known to GitHub and thus it is impossible to know if you have signed the Plone Contributor Agreement, which is required to merge this pull request.
Learn about the Plone Contributor Agreement: http://docs.plone.org/develop/coredev/docs/contributors_agreement_explained.html How to add more emails to your GitHub account: https://help.github.com/articles/adding-an-email-address-to-your-github-account/

@MAX-786 you need to sign the Plone Contributor Agreement in order to merge this pull request.
Learn about the Plone Contributor Agreement: http://docs.plone.org/develop/coredev/docs/contributors_agreement_explained.html

max_786 your emails are not known to GitHub and thus it is impossible to know if you have signed the Plone Contributor Agreement, which is required to merge this pull request.
Learn about the Plone Contributor Agreement: http://docs.plone.org/develop/coredev/docs/contributors_agreement_explained.html How to add more emails to your GitHub account: https://help.github.com/articles/adding-an-email-address-to-your-github-account/

@MAX-786 you need to sign the Plone Contributor Agreement in order to merge this pull request.
Learn about the Plone Contributor Agreement: http://docs.plone.org/develop/coredev/docs/contributors_agreement_explained.html

max_786 your emails are not known to GitHub and thus it is impossible to know if you have signed the Plone Contributor Agreement, which is required to merge this pull request.
Learn about the Plone Contributor Agreement: http://docs.plone.org/develop/coredev/docs/contributors_agreement_explained.html How to add more emails to your GitHub account: https://help.github.com/articles/adding-an-email-address-to-your-github-account/

@MAX-786 you need to sign the Plone Contributor Agreement in order to merge this pull request.
Learn about the Plone Contributor Agreement: http://docs.plone.org/develop/coredev/docs/contributors_agreement_explained.html

max_786 your emails are not known to GitHub and thus it is impossible to know if you have signed the Plone Contributor Agreement, which is required to merge this pull request.
Learn about the Plone Contributor Agreement: http://docs.plone.org/develop/coredev/docs/contributors_agreement_explained.html How to add more emails to your GitHub account: https://help.github.com/articles/adding-an-email-address-to-your-github-account/

@MAX-786 you need to sign the Plone Contributor Agreement in order to merge this pull request.
Learn about the Plone Contributor Agreement: http://docs.plone.org/develop/coredev/docs/contributors_agreement_explained.html

max_786 your emails are not known to GitHub and thus it is impossible to know if you have signed the Plone Contributor Agreement, which is required to merge this pull request.
Learn about the Plone Contributor Agreement: http://docs.plone.org/develop/coredev/docs/contributors_agreement_explained.html How to add more emails to your GitHub account: https://help.github.com/articles/adding-an-email-address-to-your-github-account/

@MAX-786 you need to sign the Plone Contributor Agreement in order to merge this pull request.
Learn about the Plone Contributor Agreement: http://docs.plone.org/develop/coredev/docs/contributors_agreement_explained.html

max_786 your emails are not known to GitHub and thus it is impossible to know if you have signed the Plone Contributor Agreement, which is required to merge this pull request.
Learn about the Plone Contributor Agreement: http://docs.plone.org/develop/coredev/docs/contributors_agreement_explained.html How to add more emails to your GitHub account: https://help.github.com/articles/adding-an-email-address-to-your-github-account/

max_786 your emails are not known to GitHub and thus it is impossible to know if you have signed the Plone Contributor Agreement, which is required to merge this pull request.
Learn about the Plone Contributor Agreement: http://docs.plone.org/develop/coredev/docs/contributors_agreement_explained.html How to add more emails to your GitHub account: https://help.github.com/articles/adding-an-email-address-to-your-github-account/

@MAX-786 you need to sign the Plone Contributor Agreement in order to merge this pull request.
Learn about the Plone Contributor Agreement: http://docs.plone.org/develop/coredev/docs/contributors_agreement_explained.html

@MAX-786 you need to sign the Plone Contributor Agreement in order to merge this pull request.
Learn about the Plone Contributor Agreement: http://docs.plone.org/develop/coredev/docs/contributors_agreement_explained.html

max_786 your emails are not known to GitHub and thus it is impossible to know if you have signed the Plone Contributor Agreement, which is required to merge this pull request.
Learn about the Plone Contributor Agreement: http://docs.plone.org/develop/coredev/docs/contributors_agreement_explained.html How to add more emails to your GitHub account: https://help.github.com/articles/adding-an-email-address-to-your-github-account/

@MAX-786 you need to sign the Plone Contributor Agreement in order to merge this pull request.
Learn about the Plone Contributor Agreement: http://docs.plone.org/develop/coredev/docs/contributors_agreement_explained.html

max_786 your emails are not known to GitHub and thus it is impossible to know if you have signed the Plone Contributor Agreement, which is required to merge this pull request.
Learn about the Plone Contributor Agreement: http://docs.plone.org/develop/coredev/docs/contributors_agreement_explained.html How to add more emails to your GitHub account: https://help.github.com/articles/adding-an-email-address-to-your-github-account/

max_786 your emails are not known to GitHub and thus it is impossible to know if you have signed the Plone Contributor Agreement, which is required to merge this pull request.
Learn about the Plone Contributor Agreement: http://docs.plone.org/develop/coredev/docs/contributors_agreement_explained.html How to add more emails to your GitHub account: https://help.github.com/articles/adding-an-email-address-to-your-github-account/

@MAX-786 you need to sign the Plone Contributor Agreement in order to merge this pull request.
Learn about the Plone Contributor Agreement: http://docs.plone.org/develop/coredev/docs/contributors_agreement_explained.html

@MAX-786 you need to sign the Plone Contributor Agreement in order to merge this pull request.
Learn about the Plone Contributor Agreement: http://docs.plone.org/develop/coredev/docs/contributors_agreement_explained.html

max_786 your emails are not known to GitHub and thus it is impossible to know if you have signed the Plone Contributor Agreement, which is required to merge this pull request.
Learn about the Plone Contributor Agreement: http://docs.plone.org/develop/coredev/docs/contributors_agreement_explained.html How to add more emails to your GitHub account: https://help.github.com/articles/adding-an-email-address-to-your-github-account/

@MAX-786 you need to sign the Plone Contributor Agreement in order to merge this pull request.
Learn about the Plone Contributor Agreement: http://docs.plone.org/develop/coredev/docs/contributors_agreement_explained.html

max_786 your emails are not known to GitHub and thus it is impossible to know if you have signed the Plone Contributor Agreement, which is required to merge this pull request.
Learn about the Plone Contributor Agreement: http://docs.plone.org/develop/coredev/docs/contributors_agreement_explained.html How to add more emails to your GitHub account: https://help.github.com/articles/adding-an-email-address-to-your-github-account/

@MAX-786 you need to sign the Plone Contributor Agreement in order to merge this pull request.
Learn about the Plone Contributor Agreement: http://docs.plone.org/develop/coredev/docs/contributors_agreement_explained.html

max_786 your emails are not known to GitHub and thus it is impossible to know if you have signed the Plone Contributor Agreement, which is required to merge this pull request.
Learn about the Plone Contributor Agreement: http://docs.plone.org/develop/coredev/docs/contributors_agreement_explained.html How to add more emails to your GitHub account: https://help.github.com/articles/adding-an-email-address-to-your-github-account/

@MAX-786 images should be placed within _static, and within a subdirectory as appropriate. As such, let's do it the "right" way from the start, and move them into _static/user-manual, and even deeper directories as needed. We will need to ensure that they get copied over in the main plone/documentation repo, too. It is tricky to get the paths just right.

Hello @stevepiercy , I have already signed the contributing agreement and mailed the scanned copy to<EMAIL_ADDRESS>with my Name as subject, please let me know if there are any other steps I should be following.

@stevepiercy oh sorry 😅, i think my comment was misleading, I was also asking the same that should we move all images related to user manual inside _static/user-manual, I'll do it right now.
Also if I am getting it right, for updating plone/documentation do we have to use command git submodule update --remote after this PR is merged and make a seperate PR for that?

Contributor agreement for @MAX-786 has been received and processed

max_786 your emails are not known to GitHub and thus it is impossible to know if you have signed the Plone Contributor Agreement, which is required to merge this pull request.
Learn about the Plone Contributor Agreement: http://docs.plone.org/develop/coredev/docs/contributors_agreement_explained.html How to add more emails to your GitHub account: https://help.github.com/articles/adding-an-email-address-to-your-github-account/

max_786 your emails are not known to GitHub and thus it is impossible to know if you have signed the Plone Contributor Agreement, which is required to merge this pull request.
Learn about the Plone Contributor Agreement: http://docs.plone.org/develop/coredev/docs/contributors_agreement_explained.html How to add more emails to your GitHub account: https://help.github.com/articles/adding-an-email-address-to-your-github-account/

max_786 your emails are not known to GitHub and thus it is impossible to know if you have signed the Plone Contributor Agreement, which is required to merge this pull request.
Learn about the Plone Contributor Agreement: http://docs.plone.org/develop/coredev/docs/contributors_agreement_explained.html How to add more emails to your GitHub account: https://help.github.com/articles/adding-an-email-address-to-your-github-account/

I think there's some mistake from my side in configuration of my user email in my local machine while I made this PR which is fixed now but bot is not able to recognize it.That's why I am closing this PR and opening the new one with same comment.Sorry for the inconvenience.

Also if I am getting it right, for updating plone/documentation do we have to use command git submodule update --remote after this PR is merged and make a seperate PR for that?

You do not. Maintainers do.


Live Demo Server Error

Just a heads-up: Your live demo at hearsay.me seems to have broken!

Thanks for the heads up 😃  I was keeping all my heroku apps alive with uptimerobot, so all my free tier hours are spent for this month 😅


Add an XML sitemap

"The Sitemaps protocol allows a webmaster to inform search engines about URLs on a website that are available for crawling. A Sitemap is an XML file that lists the URLs for a site. It allows webmasters to include additional information about each URL: when it was last updated, how often it changes, and how important it is in relation to other URLs of the site. This allows search engines to crawl the site more efficiently and to find URLs that may be isolated from the rest of the site's content. "
https://www.sitemaps.org/protocol.html
https://en.wikipedia.org/wiki/Sitemaps
Create a sitemap at the next link:
https://www.xml-sitemaps.com/
Or:
https://developers.google.com/search/docs/advanced/sitemaps/build-sitemap
https://pypi.org/search/?q=sitemap
How to Submit Your XML Sitemap to Google, Bing, and Yahoo:
https://www.youtube.com/watch?v=5Obj_Md33Rw

I'm looking to see if we have pelican-sitemap installed.

Yeah that looks like it should do the job 👍

Done. We now have a sitemap.xml


energy metrics in home assistant?

Hi, from the midea app we get the energy consumption of the AC. is it possible to get these metrics in home assistant's energy module?

Can you please send an image where you find it? I can't see it on my app

Can you please send an image where you find it? I can't see it on my app

you are totally right, i dont  see them. strange, i am sure i saw these statistics somewhere.. let's close this issue for now.

Can I revive the issue? The metrics is when you tap on an AC and then go to the 3 dots and choose "Energy Monitor".

Can I revive the issue? The metrics is when you tap on an AC and then go to the 3 dots and choose "Energy Monitor".

With the migration to msmarthome this does not exist anymore right?

Can I revive the issue? The metrics is when you tap on an AC and then go to the 3 dots and choose "Energy Monitor".

With the migration to msmarthome this does not exist anymore right?

I have no idea. I use NetHome Plus, this is available for my country and the option is there on the 3 dots.


SICP link on extras/readings.md is broken

The SICP link in the Great Readings page is broken. I propose replacing it with https://github.com/sarabander/sicp-pdf, which is a version of the book redone in modern typesetting for quality of life improvements.

There is also an HTML version of the book that we might consider.

@GustavBertram got us with an updated version of the URL and it has been fixed.


Running trial is still timing when view and experiment status always is INITIALIZED

Environment:

NNI version: v2.1
NNI mode (local|remote|pai): local
Client OS: Linux
Server OS (for remote mode only):
Python version: 3.6
PyTorch/TensorFlow version:
Is conda/virtualenv/venv used?: no
Is running in Docker?: no

Log message:

nnimanager.log:
dispatcher.log:
nnictl stdout and stderr:

What issue meet, what's expected?:
Trials is still calculating running time in review mode, and experiment is still in Initialized state.
How to reproduce it?:
Additional information:

When experiment status is INITIALIZED, several progress bars and texts are all blue. But they are all green in the DONE state, which may make users very confused...

change INITIALIZED to VIEWED when in view mode #3545

It had been fixed on v2.2

It had been fixed on v2.2

Seems still timing in v2.2


ffmpeg-full: 3.1.3 -> 3.2.2

Not sure if there's a specific reason ffmpeg is kept at the 3.1.x series :) I updated the ffmpeg-full package which doesn't seem to have anything which depends on it currently.
also removed a few flags for features that have been entirely removed from
ffmpeg
removed:

faac
aacplus
incompatibleLibavAbi option

please use fdk-aac or the built-in encoder for aac audio

[x] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] Linux

[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

According to tracker the update is fully API-compatible, so it should be safe.

Thanks for the link! Very useful :)

Are there security implications with this update, @MP2E?

Everything builds ok according to https://prs.nix.gsc.io/jobset/nixos/pr-22163, too. Thank you!

thanks for the merge! Indeed, upgrading from ffmpeg 3.1.3 -> 3.2.2 seems to fix 9 security vulnerabilities! I checked for known vulnerabilities in 3.2.2 and did not see any.
https://www.cvedetails.com/vulnerability-list/vendor_id-3611/Ffmpeg.html
This is where I got my information, I also manually looked through the ffmpeg bug tracker


stringr: missing dot in the hierarchy

The dot is missing from the hierarchy (top right corner of the second page).
Old version:

Current version:

That must have gotten deleted accidentally.  Thank you!