Exclude manual

The package is quite big because the PDF isn't excluded. We could also change it for the real released version if you want to (even without a bump since it's unobservable).

Oh, and if you change the current release version I would appreciate it. Thanks.

Done.


failing to compile sktime

I am bit new to open source and sktime is the first project that I am aiming to contribute to, so please forgive if this is my inexperience but following the development intructions, I am able to step through all them except this last and important one.
where I get the following error. I have also checked if I have gcc installed by trying following in the terminal gcc -vand all looks good.
So I am unsure of whats wrong here ?
(sktime) (base) Shoaibs-MBP:sktime shoaibkhan$ env CC=$(which gcc-9) CXX=$(which g++-9) pip install --editable .
Obtaining file:///Users/shoaibkhan/PycharmProjects/sktime
Requirement already satisfied: numpy>=1.18.0 in /Users/shoaibkhan/venv/sktime/lib/python3.8/site-packages (from sktime==0.4.2) (1.19.2)
Requirement already satisfied: pandas>=1.0.0 in /Users/shoaibkhan/venv/sktime/lib/python3.8/site-packages (from sktime==0.4.2) (1.1.3)
Requirement already satisfied: scikit-learn>=0.23.0 in /Users/shoaibkhan/venv/sktime/lib/python3.8/site-packages (from sktime==0.4.2) (0.23.2)
Requirement already satisfied: statsmodels>=0.12.0 in /Users/shoaibkhan/venv/sktime/lib/python3.8/site-packages (from sktime==0.4.2) (0.12.0)
Requirement already satisfied: wheel in /Users/shoaibkhan/venv/sktime/lib/python3.8/site-packages (from sktime==0.4.2) (0.35.1)
Requirement already satisfied: pytz>=2017.2 in /Users/shoaibkhan/venv/sktime/lib/python3.8/site-packages (from pandas>=1.0.0->sktime==0.4.2) (2020.1)
Requirement already satisfied: python-dateutil>=2.7.3 in /Users/shoaibkhan/venv/sktime/lib/python3.8/site-packages (from pandas>=1.0.0->sktime==0.4.2) (2.8.1)
Requirement already satisfied: threadpoolctl>=2.0.0 in /Users/shoaibkhan/venv/sktime/lib/python3.8/site-packages (from scikit-learn>=0.23.0->sktime==0.4.2) (2.1.0)
Requirement already satisfied: scipy>=0.19.1 in /Users/shoaibkhan/venv/sktime/lib/python3.8/site-packages (from scikit-learn>=0.23.0->sktime==0.4.2) (1.5.2)
Requirement already satisfied: joblib>=0.11 in /Users/shoaibkhan/venv/sktime/lib/python3.8/site-packages (from scikit-learn>=0.23.0->sktime==0.4.2) (0.17.0)
Requirement already satisfied: patsy>=0.5 in /Users/shoaibkhan/venv/sktime/lib/python3.8/site-packages (from statsmodels>=0.12.0->sktime==0.4.2) (0.5.1)
Requirement already satisfied: six>=1.5 in /Users/shoaibkhan/venv/sktime/lib/python3.8/site-packages (from python-dateutil>=2.7.3->pandas>=1.0.0->sktime==0.4.2) (1.15.0)
Installing collected packages: sktime
  Attempting uninstall: sktime
    Found existing installation: sktime 0.4.2
    Uninstalling sktime-0.4.2:
      Successfully uninstalled sktime-0.4.2
  Running setup.py develop for sktime
    ERROR: Command errored out with exit status 1:
     command: /Users/shoaibkhan/venv/sktime/bin/python -c 'import sys, setuptools, tokenize; sys.argv[0] = '"'"'/Users/shoaibkhan/PycharmProjects/sktime/setup.py'"'"'; __file__='"'"'/Users/shoaibkhan/PycharmProjects/sktime/setup.py'"'"';f=getattr(tokenize, '"'"'open'"'"', open)(__file__);code=f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' develop --no-deps
         cwd: /Users/shoaibkhan/PycharmProjects/sktime/
    Complete output (44 lines):
    C compiler: -Wno-unused-result -Wsign-compare -Wunreachable-code -fno-common -dynamic -DNDEBUG -g -fwrapv -O3 -Wall -iwithsysroot/System/Library/Frameworks/System.framework/PrivateHeaders -iwithsysroot/Applications/Xcode.app/Contents/Developer/Library/Frameworks/Python3.framework/Versions/3.8/Headers -arch arm64 -arch x86_64

    compile options: '-c'
    extra options: '-fopenmp'
    -Wno-unused-result: test_openmp.c
    Traceback (most recent call last):
      File "<string>", line 1, in <module>
      File "/Users/shoaibkhan/PycharmProjects/sktime/setup.py", line 319, in <module>
        setup_package()
      File "/Users/shoaibkhan/PycharmProjects/sktime/setup.py", line 315, in setup_package
        setup(**metadata)
      File "/Users/shoaibkhan/venv/sktime/lib/python3.8/site-packages/numpy/distutils/core.py", line 135, in setup
        config = configuration()
      File "/Users/shoaibkhan/PycharmProjects/sktime/setup.py", line 210, in configuration
        config.add_subpackage("sktime")
      File "/Users/shoaibkhan/venv/sktime/lib/python3.8/site-packages/numpy/distutils/misc_util.py", line 1018, in add_subpackage
        config_list = self.get_subpackage(subpackage_name, subpackage_path,
      File "/Users/shoaibkhan/venv/sktime/lib/python3.8/site-packages/numpy/distutils/misc_util.py", line 984, in get_subpackage
        config = self._get_configuration_from_setup_py(
      File "/Users/shoaibkhan/venv/sktime/lib/python3.8/site-packages/numpy/distutils/misc_util.py", line 926, in _get_configuration_from_setup_py
        config = setup_module.configuration(*args)
      File "sktime/setup.py", line 28, in configuration
        maybe_cythonize_extensions(top_path, config)
      File "/Users/shoaibkhan/PycharmProjects/sktime/sktime/_build_utils/__init__.py", line 42, in maybe_cythonize_extensions
        with_openmp = check_openmp_support()
      File "/Users/shoaibkhan/PycharmProjects/sktime/sktime/_build_utils/openmp_helpers.py", line 145, in check_openmp_support
        raise CompileError(err_message)
    distutils.errors.CompileError:
                        ***
    It seems that sktime cannot be built with OpenMP support.

    - If your compiler supports OpenMP but the build still fails, please
      submit a bug report at:
      'https://github.com/alan-turing-institute/sktime/issues'

    - If you want to build sktime without OpenMP support, you can set
      the environment variable SKTIME_NO_OPENMP and rerun the build
      command. Note however that some estimators will run in sequential
      mode and their `n_jobs` parameter will have no effect anymore.

    - See sktime advanced installation instructions for more info:
      'https://https://www.sktime.org/en/latest/installation.html'
                        ***

    ----------------------------------------
  Rolling back uninstall of sktime
  Moving to /Users/shoaibkhan/venv/sktime/lib/python3.8/site-packages/sktime-0.4.2.dist-info/
   from /Users/shoaibkhan/venv/sktime/lib/python3.8/site-packages/~ktime-0.4.2.dist-info
  Moving to /Users/shoaibkhan/venv/sktime/lib/python3.8/site-packages/sktime/
   from /Users/shoaibkhan/venv/sktime/lib/python3.8/site-packages/~ktime
ERROR: Command errored out with exit status 1: /Users/shoaibkhan/venv/sktime/bin/python -c 'import sys, setuptools, tokenize; sys.argv[0] = '"'"'/Users/shoaibkhan/PycharmProjects/sktime/setup.py'"'"'; __file__='"'"'/Users/shoaibkhan/PycharmProjects/sktime/setup.py'"'"';f=getattr(tokenize, '"'"'open'"'"', open)(__file__);code=f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' develop --no-deps Check the logs for full command output.

Hi @shoaibkhanz, assuming that you're on macOS, have you read and followed the macOS specific instructions: https://www.sktime.org/en/latest/installation.html#mac-osx?

Yes I was following the instructions from the above documentation link.
However,  what worked for me is using the conda environment instead of venv
followed instructions from here -- > https://scikit-learn.org/stable/developers/advanced_installation.html#macos-compilers-from-conda-forge

Great, would be great to update the installation docs in docs/source/installation.rst

Sure, I will update the docs and open a PR


feat(Styleguide): Add storybook controls addon [WEB-937]

Overview
PR Checklist

[ ] Related to Abstract designs:
[ ] Related to JIRA ticket: ABC-123
[ ] I have run this code to verify it works
[ ] This PR includes unit tests for the code change

Description

Merging your changes
When you are ready to merge to master and publish your changes, use the "squash and merge" button in GitHub, and follow the PR Title Guide to format your PR title and write your PR merge description.
IMPORTANT: If your PR contains breaking changes, please remember to follow the instructions for breaking changes!

🚀 Styleguide deploy preview ready!https://5efe6d23e5f606ff593a32fd--codecademy-styleguide.netlify.appDeploy Logs

🚀 Styleguide deploy preview ready!https://5f1af93aa27f0461f29ff8d9--codecademy-styleguide.netlify.appDeploy Logs

🚀 Styleguide deploy preview ready!https://5f1b1516e0fedb9c7b36cb46--codecademy-styleguide.netlify.appDeploy Logs

📬Published Alpha Packages:@codecademy/gamut-labs@1.8.0-alpha.575e0a.0@codecademy/gamut-styles@4.2.0-alpha.575e0a.0<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://5f1f0a029771fe022b24e105--gamut-preview.netlify.appDeploy Logs


fix: dependencies & example

What kind of change does this PR introduce (bug fix, feature, docs update, ...)?

readme update with testnet
example/ folder update

What is the current behaviour (you can also link to an open issue here)?
What is the new behaviour (if this is a feature change)?
Other information:
the example/ folder now contains my UP address as example. I'm fine with it, but we might want to setup a 'showcase' UP address to put instead. UP to you (🤣)!

Codecov Report

Merging #302 (f0c6492) into develop (122efa9) will increase coverage by 0.87%.
Report is 57 commits behind head on develop.
The diff coverage is 89.71%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@             Coverage Diff             @@
##           develop     #302      +/-   ##
===========================================
+ Coverage    83.04%   83.91%   +0.87%
===========================================
  Files           18       18
  Lines          979     1119     +140
  Branches       218      251      +33
===========================================
+ Hits           813      939     +126
- Misses          91       97       +6
- Partials        75       83       +8

Files Changed
Coverage Δ

src/lib/getData.ts
89.79% <ø> (ø)

src/lib/provider-wrapper-utils.ts
88.88% <ø> (-0.59%)
:arrow_down:

src/lib/decodeMappingKey.ts
84.21% <60.00%> (-5.54%)
:arrow_down:

src/lib/utils.ts
83.12% <76.92%> (-0.77%)
:arrow_down:

src/lib/decodeData.ts
82.24% <83.33%> (+1.34%)
:arrow_up:

src/provider/providerWrapper.ts
81.25% <90.00%> (-1.65%)
:arrow_down:

src/lib/encoder.ts
83.95% <91.59%> (+6.04%)
:arrow_up:

src/constants/constants.ts
100.00% <100.00%> (ø)

src/constants/interfaces.ts
100.00% <100.00%> (ø)

src/index.ts
76.76% <100.00%> (-0.24%)
:arrow_down:

... and 2 more

... and 4 files with indirect coverage changes


switch from creating new organization to setting organization to tenant

🔗 Issue

Fix for flaky HomeControllerTest (hopefully).
✍ Description

Creating a new organization for the test using the factory led to @organization.location occasionally coming up nil. Switching to using the tenant seems to resolve that (ran a few hundred trials without failure).
As for why...
This part is sort of baffling to me because the factory for organization called in the setup block always created a profile and the profile factory always created a location, and the location was always accessible with @organization.profile.location but not always with @organization.location.
It seems that something about setting the tenant in the test helper setup block interferes when generating the organization with a factory because an alternative way that also seems to resolve the issue (at least for a few hundred trials) is to remove the setup block in test helper.
📷 Screenshots/Demos

I assume this has to do with ActsAsTenant scoping behavior. I think your solution is good, as I think creating an organization in tests generally should not be done.
The test_helper setup makes an organization already and sets up that organization as the current_tenant/test_tenant in the test environment. Making an organization like this test does can be confusing, because even though it does create the organization record, the tenant that is set in the environment has already been set in the test_helper and ActsAsTenant is using it to enforce scopes.
I assume that is why removing the setup fixes the error in your investigation because then I presume ActsAsTenant does not have a current_tenant set to scope with.
I am having trouble replicating this flaky test to investigate further. I do think I noticed this test fail once before, but I have a shell running all tests in a loop right now and can't seem to replicate a failure. Do you happen to know how I could reliably replicate the failure?

I commented too soon! Got an error in my shell loop.
Actually, there is a chance this may not even be related to ActsAsTenant. I still think your solution is worth pushing though.
I noticed in the failure, that the @organization.profile was not valid:
(ruby@bin/rails#31838) @organization
#<Organization:0x000000010ed8e118
 id: 6878,
 name: "Marvin, Berge and Kautzer",
 created_at: Sun, 03 Mar 2024 04:13:41.115549000 UTC +00:00,
 updated_at: Sun, 03 Mar 2024 04:13:41.115549000 UTC +00:00,
 slug: "weimann2">

(ruby@bin/rails#31838) ActsAsTenant.current_tenant
#<Organization:0x000000010ea5fbb8
 id: 6877,
 name: "Carroll Group",
 created_at: Sun, 03 Mar 2024 04:13:41.103760000 UTC +00:00,
 updated_at: Sun, 03 Mar 2024 04:13:41.103760000 UTC +00:00,
 slug: "test">

(ruby@bin/rails#31838) @organization.location
nil

(ruby@bin/rails#31838) @organization.profile.location
#<Location:0x000000010ef0f7d0
 id: 7605,
 country: "Country27",
 city_town: "Thompsonchester",
 province_state: "Delaware",
 created_at: Sun, 03 Mar 2024 04:13:41.110607000 UTC +00:00,
 updated_at: Sun, 03 Mar 2024 04:13:41.110607000 UTC +00:00,
 zipcode: "02401-9622">

(ruby@bin/rails#31838) @organization.profile.location.valid?
true

(ruby@bin/rails#31838) @organization.profile.valid?
false

(ruby@bin/rails#31838) @organization.profile.errors.full_messages
["Phone number Phone Number is invalid"]

It looks like the reason nil is returned in this failure is because the OrganizationProfile of @organization is actually not valid. Seems to do with the phone number. I wonder if you can replicate this? I hope it helps with the investigation. Let me know if you'd like help looking more into it.

Did a bit more investigating... And I'm also seeing that the phone number is the culprit. It looks like the invalid phone numbers are failing the check for possible. What is strange is that the tenant doesn't seem to have the same rate of failure. I'd expect some failure after many repeated trials.

Ok this has reminded be of some weird stuff happening on OrganizationProfile /organization_profile/edit on prod site.

The country and state are both not populated, despite the attributes being set in the creation of the OrganizationProfile seed. This is the relevant PR: https://github.com/rubyforgood/pet-rescue/pull/136/files. I am not sure why the initial value is not populating, but it may be something like a mismatch between the provided attribute e.g. "USA" as provided in the seed file, versus United States as provided by the CityState gem's country list. It may be as simple as a fix as updating the seed. Anyway, this is a side issue that I just thought of when you brought up the above.
More relevant to this issue, in the seed data we provide phone_number: "123 456 7891" for the OrganizationProfile. This seems to work fine with no validation errors when creating it (satisfies possible). However, if I go to the OrganizationProfile /organization_profile/edit on prod site, it shows the formatted phone number as +1234567891 and if I try to save the form (after adding the missing country/state per above) it will throw a validation error on the phone number. If I remove the + from the phone number it will save without error. So, I am not sure why phonelib gem is accepting the number as valid first time round as "123 456 7891", but then refusing it once it has been formatted. One possible approach here is that we remove phone number altogether from the tests...which is not ideal as it would be useful to test. Another approach, we could try using a real phone number in the seed, and the test file, and see if that impacts this issue at all.

@kasugaijin This is both fascinating and bizarre. In the Rails console, I get the same things Phonelib.parse("123 456 7891").possible? and Phonelib.parse("1234567891").possible? come up true, Phonelib.parse("+1234567891").possible? comes up false. But if I explicitly add an additional 1 for a country code, like Phonelib.parse("+11234567891").possible? it comes back true. I also tried a real NYC number and it came back false with the + and no country code, but true with the country code added. But for other numbers (both real and fake) it didn't matter if the 1 was added or not.

hmmm I bet Phonelib documentation and/or issues will have an explanation for this. It must be something that has come up before :)

I think I know what's happening. If there's no + then phone lib is treating the country as the default country, but if it is there it assumes the number starts with the country code.

I think I know what's happening. If there's no + then phone lib is treating the country as the default country, but if it is there it assumes the number starts with the country code.

Interesting...so I wonder why it will format '1234567891' with a '+' which will subsequently fail? Maybe because it is not a real number and cannot find the country? I think that's what you're saying? If I enter my 10 digit number without country, it saves and then formats it with '+1' which saves the second time. So, I think we can use a real number in the seeds...or at least one with a real format save for the last four digits.

@kasugaijin It might not be that sophisticated. It might just be a problem that the number started with a 1.

It could be that the methods used to normalize the phone number won't add the additional 1 if the number starts with a 1 already.

@kasugaijin It might not be that sophisticated. It might just be a problem that the number started with a 1.

It could be that the methods used to normalize the phone number won't add the additional 1 if the number starts with a 1 already.

Ah yes that makes sense thank you @MooseCowBear . I think we have learned something about making valid seed data here! So is this PR still needed given https://github.com/rubyforgood/pet-rescue/pull/492

@kasugaijin There's still the mystery of why creating a new organization in the test setup would sometimes create phone numbers that fail but the tenant somehow doesn't.
We could just change the organization profile factory to set the phone number to a string not starting with a 1 instead of using Faker::PhoneNumber which we can't control instead of the change made in this PR.

@kasugaijin There's still the mystery of why creating a new organization in the test setup would sometimes create phone numbers that fail but the tenant somehow doesn't.
We could just change the organization profile factory to set the phone number to a string not starting with a 1 instead of using Faker::PhoneNumber which we can't control instead of the change made in this PR.

Yes let's do that. I cannot be sure the Faker numbers never start with a 1 (have not looked into it), but hard coding a string that we know will satisfy seems like an easy, reliable approach. @MooseCowBear


Pages Widget currently only allows for 3 highlighted pages thumbnails within widget in DPUL

Needed: 12 thumbnails for highlighted (curators) pages to be viewed  on home page of Welcome Additions.  See https://dpul.princeton.edu/wa

Can you create four of the existing page widgets, one after the other, to achieve a 4x3 grid?

sigh. could have thought this out better. Yes!! thanks :)

No worries — happy to help you figure out how to use what's there already!


e1017

Some exercises are not working linked to this error
Error: package e1071 is required
(ex, Exercise 11 of chapter 2)
When I tried to install this package on binder, everything fails.

I should have checked this to start this. 🙈
Here are the packages that build the Docker container on the other platform:
install_version("e1071", "1.6-8")
install_version("gbm", "2.1.3")
install_version("randomForest", "4.6-12")
install_version("xgboost", "<IP_ADDRESS>")
install_version("caret", "6.0-78")
install_version("yardstick", "0.0.1")
install_version("tidyverse", "1.2.1")

Want to try including both gbm and e1071?

Right now install.R references a glm package but I think that is a typo?

Looks like this package is installed correctly now, and 4.11 is working well. 👍


Eltan BV | Altitude MiniFilter Request

[Enter feedback here]
Hello,
I am trying to get an altitude allocation made. The first request I sent was in april.
I am sending these requests from my<EMAIL_ADDRESS>email.
I have also contacted support about this with no results other than the suggesting to issue feedback on this page.
Can you help me out here to get this done.
I added my communication with support:
Hello Wim,
We are not receiving any replies from the alias, I would suggest submitting feedback on the Minifilter Altitude Request doc as the owner of the document generally responds fairly quickly. You can aslo submit feedback via your HDC Dashboard. I understand this is not ideal and I appreciate your understanding.
As this issue is out scope for my team, I will proceed in archiving this service request. Shoud you encounter any future issues, please do not hesitate to contact support.
Thank You,
Tinishia
--- Original Message ---
Hi Wim,
I have not received a response from<EMAIL_ADDRESS>neither via chat or email, neither has my manager. I will provide an update by this time next week.
Thank You,
Tinishia
--- Original Message ---
Hi Wim,
I have yet to receive a response from<EMAIL_ADDRESS>neither via chat or email. I have requested manager asisstance. I will provide an update by this time next week.
Thank You,
Tinishia
--- Original Message ---
Thank Wim, I have reached out to<EMAIL_ADDRESS>via chat and email. I will provide any feedback or updates upon receipt.
Thank You,
Tinishia
--- Original Message ---
Hello,
I added a long screenshot. It contains my first request and a more recent reminder

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 3f62aea8-127c-317f-07d8-6f6d93df7bb1
Version Independent ID: e85bfe16-3267-7aee-65c8-46c59bae4a6f
Content: Minifilter Altitude Request - Windows drivers
Content Source: windows-driver-docs-pr/ifs/minifilter-altitude-request.md
Product: windows-hardware
Technology: windows-devices
GitHub Login: @lorihollasch
Microsoft Alias: loriwhip

@wvervoorn , thanks for reaching out via GitHub and apologies for the difficulties you've experienced in obtaining an altitude ID. I sent you email with your altitude allocation information, and you might also hear from the fsfcomm alias as well. They processed your request several weeks ago and believe they sent you email, so you might want to make sure that your company spam filter isn't blocking email from Microsoft? Let me know if you need anything else!


enforce code ownership of each package

This CI check should ensure that each package has a code owner, and that the owner listed is not the fallback owner.

Label prediction was below confidence level 0.6 for Model:ServiceLabels: 'Storage:0.5476703,Event Hubs:0.14124839,Service Bus:0.032613'


Retry the task on TF submit failure

Retry the TFHandler task if there was no response or failure in response when
submitting the payload to TF. Fixes #1551.

RELEASE NOTES BEGIN
When submitting Testing Farm tests, Packit will now retry multiple times in case there is a failure.
RELEASE NOTES END

@lachmanfrantisek PTAL :pray:


Un-pin version changes for eslint

Once https://github.com/BenoitZugmeyer/eslint-plugin-html/issues/113 is fixed, undo pinned version changes in package.json from https://github.com/AnalyticalGraphicsInc/cesium/pull/7535.

Looks like this is fixed, in addition to unpinning, we should bump both eslint and eslint-plugin-html in package.json to their latest versions to make sure there's no mismatch.

👍 thanks @mramato


Convert core to use rollup for bundling.

Before I move forward with this change on the other repos I'd like feedback here.
This change does the following:

Convert to rollup for bundling. Remove browserify.
Use "extend: true" to extend a global "tf" object. There is now no "tfc".
Ship ES6 code as part of NPM instead of ES5. We ship an ES5 bundle, there is no need to ship ES5 for each file. These now use standard es6 imports. This gives es6 users better stack traces.
Remove models. They don't build anymore nor are they useful. We'll keep the KNN image classifier around and not unit test it just so we have the code. I'll remove this at some point in the future.

This PR goes along with:
https://github.com/tensorflow/tfjs-layers/pull/191
https://github.com/tensorflow/tfjs/pull/301
I tested with yalc across all packages, and eventually all the way to the mobilenet example in tfjs-example and everything seems to work. Using the bundles I've also used the code on the homepage to train a simple layers model (tested both union and including layers and core independently).
Hosted bundles here:
https://storage.googleapis.com/dljs-test/rollup/tf.js
https://storage.googleapis.com/dljs-test/rollup/tf.min.js
https://storage.googleapis.com/dljs-test/rollup/tf-core.js
https://storage.googleapis.com/dljs-test/rollup/tf-core.min.js
https://storage.googleapis.com/dljs-test/rollup/tf-layers.js
https://storage.googleapis.com/dljs-test/rollup/tf-layers.min.js

This change is

 Really nice work. Few comments, the biggest one is to export both es5 and es6 code to npm. (see comments below)

Reviewed 39 of 40 files at r1.
Review status: 39 of 40 files reviewed at latest revision, all discussions resolved, some commit checks failed.

package.json, line 6 at r1 (raw file):

  "description": "Hardware-accelerated JavaScript library for machine intelligence",
  "private": false,
  "main": "dist/index.js",

Since we now also export es6, add the "module" and "jsnext:main" fields with the value of "dist/index" (no extension). These fields are used when you export es6 js, while the "main" field is reserved for es5. See https://github.com/d3/d3/blob/master/package.json#L21
Also we should produce both es5 and es6 (see other comment in tsconfig.json). We should export es6 in dist-es6 folder, while es5 in the current dist folder. Then "main" will be "dist/index.js", while "module" will be "dist-es6/index".

package.json, line 28 at r1 (raw file):

    "karma-typescript": "~3.0.8",
    "rimraf": "~2.6.2",
    "rollup": "^0.58.2",

use ~

package.json, line 33 at r1 (raw file):

    "rollup-plugin-typescript2": "0.13.0",
    "shelljs": "~0.7.8",
    "tsify": "~3.0.1",

remove tsify

rollup.config.js, line 1 at r1 (raw file):

import node from "rollup-plugin-node-resolve";

add license

tsconfig.json, line 3 at r1 (raw file):

{
  "compilerOptions": {
    "module": "ES2015",

I think we need to export both es5 and es6, otherwise we require all node users to use typescript or babel in the toolchain. To confirm my worry, do the following exercise:
Build the npm package as tgz file and start a new node project with @tensorflow/tfjs-core as a dep. Write a sample.js program in es5 (no typescript, no babel) that require('@tensorflow/tfjs-core) and does matmul. Then run node sample.js. I think it will fail because we only export es6. This forces every user to have either babel or typescript in their dev toolchain, which is fairly strict and non-standard. E.g. d3 exports both es6 and es5 builds (see "main: dist/d3.node.js" vs "module: index.js" in package.json) https://github.com/d3/d3/blob/master/package.json#L18

scripts/build-npm.sh, line 23 at r1 (raw file):

tsc --sourceMap false
rollup -c

double check that tf-core.js has all the ops (tf.matMul for example - last time I tried rollup, it failed to export things that were exported in ops.ts)

scripts/build_and_lint_all, line 33 at r1 (raw file):

shell.echo('=======================================================');
shell.echo('Building', cwd);
run('yarn', cwd);

Since there are no more subfolders, remove this script entirely and call yarn && yarn build && yarn lint directly in .travis.yml

Comments from Reviewable

Review status: 35 of 43 files reviewed at latest revision, 7 unresolved discussions, some commit checks pending.

package.json, line 6 at r1 (raw file):
Previously, dsmilkov (Daniel Smilkov) wrote…
Since we now also export es6, add the "module" and "jsnext:main" fields with the value of "dist/index" (no extension). These fields are used when you export es6 js, while the "main" field is reserved for es5. See https://github.com/d3/d3/blob/master/package.json#L21
Also we should produce both es5 and es6 (see other comment in tsconfig.json). We should export es6 in dist-es6 folder, while es5 in the current dist folder. Then "main" will be "dist/index.js", while "module" will be "dist-es6/index".

Removed ES6 entirely.

package.json, line 28 at r1 (raw file):
Previously, dsmilkov (Daniel Smilkov) wrote…
use ~

Done.

package.json, line 33 at r1 (raw file):
Previously, dsmilkov (Daniel Smilkov) wrote…
remove tsify

Done.

tsconfig.json, line 3 at r1 (raw file):
Previously, dsmilkov (Daniel Smilkov) wrote…
I think we need to export both es5 and es6, otherwise we require all node users to use typescript or babel in the toolchain. To confirm my worry, do the following exercise:
Build the npm package as tgz file and start a new node project with @tensorflow/tfjs-core as a dep. Write a sample.js program in es5 (no typescript, no babel) that require('@tensorflow/tfjs-core) and does matmul. Then run node sample.js. I think it will fail because we only export es6. This forces every user to have either babel or typescript in their dev toolchain, which is fairly strict and non-standard. E.g. d3 exports both es6 and es5 builds (see "main: dist/d3.node.js" vs "module: index.js" in package.json) https://github.com/d3/d3/blob/master/package.json#L18

Now just exporting ES5. Unfortunately rollup needs to use ES2015 in tsconfig as a target, and doesn't allow you to specify a tsconfig. This means this tsconfig relates specifically to rollup, and the tsconfig-package.json refers to the one which we will use to generate the ES5 build.
And just to respond to you, what I did was link this package from layers and run all their unit tests.

scripts/build-npm.sh, line 23 at r1 (raw file):
Previously, dsmilkov (Daniel Smilkov) wrote…
double check that tf-core.js has all the ops (tf.matMul for example - last time I tried rollup, it failed to export things that were exported in ops.ts)

Yep double checked that.

scripts/build_and_lint_all, line 33 at r1 (raw file):
Previously, dsmilkov (Daniel Smilkov) wrote…
Since there are no more subfolders, remove this script entirely and call yarn && yarn build && yarn lint directly in .travis.yml

Done.

Comments from Reviewable

Review status: 33 of 43 files reviewed at latest revision, 7 unresolved discussions, all commit checks successful.

rollup.config.js, line 1 at r1 (raw file):
Previously, dsmilkov (Daniel Smilkov) wrote…
add license

Done.

tsconfig.json, line 3 at r1 (raw file):
Previously, nsthorat (Nikhil Thorat) wrote…
Now just exporting ES5. Unfortunately rollup needs to use ES2015 in tsconfig as a target, and doesn't allow you to specify a tsconfig. This means this tsconfig relates specifically to rollup, and the tsconfig-package.json refers to the one which we will use to generate the ES5 build.

Shipping es6 again. Default tsconfig is es6, tsconfig-es5 is for the es5 build.

Comments from Reviewable


Paths trying to read local.settings.json

There's an issue with _registerPaths.ts trying to read local.settings.json during a build.
This file won't be present, in say a CI environment as it's for local deployments only. You're not supposed to check this file into source control, so I don't think _registerPaths.ts should be trying to read/build this file?
Compiling TypeScript files for project "admin-api"...
Done compiling TypeScript files for project "admin-api".
Injecting tsconfig paths into function files for project "admin-api"...
 >  NX   ENOENT: no such file or directory, open 'apps/admin-api/local.settings.json'
Error: ENOENT: no such file or directory, open 'apps/admin-api/local.settings.json'
    at Object.openSync (node:fs:601:3)
    at readFileSync (node:fs:469:35)
    at readJsonFile (/home/vsts/work/1/s/node_modules/.pnpm/nx@16.2.1_@swc-node+register@1.6.4_@swc+core@1.3.52/node_modules/nx/src/utils/fileutils.js:18:43)
    at /home/vsts/work/1/s/node_modules/.pnpm/@nxazure+func@1.0.13_tslib@2.5.0/node_modules/@nxazure/func/src/executors/common/utils.js:57:53
    at Generator.next (<anonymous>)
    at /home/vsts/work/1/s/node_modules/.pnpm/tslib@2.5.0/node_modules/tslib/tslib.js:167:75
    at new Promise (<anonymous>)
    at Object.__awaiter (/home/vsts/work/1/s/node_modules/.pnpm/tslib@2.5.0/node_modules/tslib/tslib.js:163:16)
    at getFilesForPathInjection (/home/vsts/work/1/s/node_modules/.pnpm/@nxazure+func@1.0.13_tslib@2.5.0/node_modules/@nxazure/func/src/executors/common/utils.js:56:55)
    at /home/vsts/work/1/s/node_modules/.pnpm/@nxazure+func@1.0.13_tslib@2.5.0/node_modules/@nxazure/func/src/executors/common/utils.js:110:33

https://learn.microsoft.com/en-us/azure/azure-functions/functions-run-local?tabs=v4%2Cwindows%2Ccsharp%2Cportal%2Cbash#create-a-local-functions-project

Sorry, @AlexPshul , it's @nxazure/func/src/executors/common/utils reading this as you can see from the stacktrace

Yeah, I saw that. I'm still not sure why it happens, though.
I'll check it once I have a bit more time and update the issue here.

Hi @Falven ,
I just published a fix in the new 1.0.17 release.
Please have a look.
Also, I see that you are using the pre-colored console version.
Once you upgrade to 1.0.17, you should see your console colored in the same way the func tool is coloring the output.
Let me know if you find any issues there.
Thanks again for raising issues in the package. :)


Crypto api errors

A small PR for implementing returning errors from the crypto API.

Merging this, to move forward. We can always continue in the base branch.


chore: update community, spec, and sdk content

This PR

update community content
update spec to 0.7.0
update SDKs

Signed-off-by: Michael Beemer<EMAIL_ADDRESS>

This looks good to me, but I don't see an update to the spec submodule as your description implies.


Failed to create MD5 hash

It is possible that I am screwing things up, but I am getting this error:
 FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':qrcode_reader:compileReleaseJavaWithJavac'.
> Failed to create MD5 hash for file 'C:\Users\tsort\AppData\Roaming\Pub\Cache\hosted\pub.dartlang.org\qrcode_reader-0.1.1\android\tmplibs\flutter.jar'.

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.
Finished with error: Gradle build failed: 1

Good luck developing the plugin!

Hello cstsortan, thanks for the interest on the plugin.
I had a flutter.jar imported in the gradle file just as a stub so i could develop the Android part in the Android Studio and forgot to remove it. I just made a commit that commented the stub import in android gradle, it should be working now. Could you do a pull and check again please?

Indeed after removing provided files('tmplibs/flutter.jar') it compiles but now raises a java.lang.RuntimeException: Fail to connect to camera service although I'm just using the example code

I'm not saying it is the case but that happens when we don't have the camera permission in the manifest or we are in the new permission system (targetSdk > 23). I double checked the manifests and the apk (aapt list -a app-debug.apk) and both permissions and target are ok.
Nothing made with flutter is running on my emulator, probably some network stuff, and my phone is on 5.1 so I can't test if it is the new permission stuff, can you post the full stacktrace of the crash?

I am having the same issue when adding this plugin and running it for the first time

Yeah same error exactly

@cstsortan and what was your exact solution?

Haven't figured out how to solve it. To be honest I didn't try too much.

I'm sorry I haven't had time in the last days. I did took a look again and still can't run anything from flutter in the emulator.
Since I'm almost sure this is a camera permission thing, and could not find any other examples in the flutter plugins I gave a go to add the permissions asking dialog without being able to really test or any way to be sure it would work.
Could you please update your sources and take a look? I wish I could be more helpful here but now is what I can do sorry

Ok thank you for trying to fix it, even though you can't test the result ;P
Here's what happened to me just now:
1st. I upgrade the package, run the app, permission is asked when I hit the button but then nothing happens.
2nd. I say "Ok, maybe it wants a second time to press the fab", and then gives this error:
E/flutter ( 8065): [ERROR:lib/tonic/logging/dart_error.cc(16)] Unhandled exception: E/flutter ( 8065): PlatformException(ALREADY_ACTIVE, QR Code reader is already active, null) E/flutter ( 8065): #0      StandardMethodCodec.decodeEnvelope (package:flutter/src/services/message_codecs.dart:514) E/flutter ( 8065): #1      MethodChannel.invokeMethod (package:flutter/src/services/platform_channel.dart:154) E/flutter ( 8065): <asynchronous suspension> E/flutter ( 8065): #2      QRCodeReader.scan (package:qrcode_reader/QRCodeReader.dart:53) E/flutter ( 8065): <asynchronous suspension> E/flutter ( 8065): #3      _MyHomePageState.build.<anonymous closure>.<anonymous closure> (file:///C:/Users/tsort/Documents/projects/l2/untitled/lib/main.dart:57) E/flutter ( 8065): #4      State.setState (package:flutter/src/widgets/framework.dart:1162) E/flutter ( 8065): #5      _MyHomePageState.build.<anonymous closure> (file:///C:/Users/tsort/Documents/projects/l2/untitled/lib/main.dart:52) E/flutter ( 8065): #6      _InkResponseState._handleTap (package:flutter/src/material/ink_well.dart:325) E/flutter ( 8065): #7      _InkResponseState.build.<anonymous closure> (package:flutter/src/material/ink_well.dart:377) E/flutter ( 8065): #8      GestureRecognizer.invokeCallback (package:flutter/src/gestures/recognizer.dart:102) E/flutter ( 8065): #9      TapGestureRecognizer._checkUp (package:flutter/src/gestures/tap.dart:149) E/flutter ( 8065): #10     TapGestureRecognizer.acceptGesture (package:flutter/src/gestures/tap.dart:119) E/flutter ( 8065): #11     GestureArenaManager.sweep (package:flutter/src/gestures/arena.dart:156) E/flutter ( 8065): #12     BindingBase&SchedulerBinding&GestureBinding.handleEvent (package:flutter/src/gestures/binding.dart:147) E/flutter ( 8065): #13     BindingBase&SchedulerBinding&GestureBinding.dispatchEvent (package:flutter/src/gestures/binding.dart:121) E/flutter ( 8065): #14     BindingBase&SchedulerBinding&GestureBinding._handlePointerEvent (package:flutter/src/gestures/binding.dart:101) E/flutter ( 8065): #15     BindingBase&SchedulerBinding&GestureBinding._flushPointerEventQueue (package:flutter/src/gestures/binding.dart:64) E/flutter ( 8065): #16     BindingBase&SchedulerBinding&GestureBinding._handlePointerDataPacket (package:flutter/src/gestures/binding.dart:48) E/flutter ( 8065): #17     _invoke1 (file:///b/build/slave/Linux_Engine/build/src/flutter/lib/ui/hooks.dart:100) E/flutter ( 8065): #18     _dispatchPointerDataPacket (file:///b/build/slave/Linux_Engine/build/src/flutter/lib/ui/hooks.dart:58)
3rd. It says that the qrcode reader is already on which means it thinks it's open but nothing's shown in the screen. So what I did is try a couple things from the phone, restarting, erasing data, but nothing works.
4th. I delete the app, do 'flutter run', still exactly the same.
5th. I don't delete the app and I don't erase data. I just do a second 'flutter run', and this time it works. So something must be buggy over, I wish you find some way around it bro
Still thanks, keep up the great work. Actually I'm pretty new to flutter, I wish I could contribute to this.

That's actually great, it was the permission them.
The flow to request the permission and the user having to click it again actually makes sense, there's probably some android callback that tells me the permission was granted but I'll just send back an error that there was no permission.
I'll update it now to return an error in the result and when I have time move the permission logic to the example and document it, or make the plugin handle the permission an option since I have no idea how this should be handled in flutter.

Actually, I've seen the change you made. and there's no need to check the platform, if it's API 21 or less then it returns true since the permissions are accepted on app's install. Of course this has nothing to do with our issue xD

That's what I thought, that it could not be the permission due the API used, I even did the apk analysis to check that , but it looks like it really is.
Can you check if it crashes with the last commit?

Yes it's working. Now let me suggest one more thing to be completely functional:
Right now when you hit the FAB, it requests the permissions and when I give them, it just does nothing, it only works when you hit the fab again. Well actually it only has to do with the first time you open the app but still it's important. You need to override onRequestPermissionResult() method and if it's granted, then call your startView() method. and it's not, maybe provide a callback for the developer (anyway idk if this is possible). Haha still good job

Thanks. I took a look and there is a callback for that and even if it comes on the onActivityResult Flutter exposes it for us. I did a commit that should make it work as you wish, but again I can't test anything so I have no idea if it is 100%

You forgot something ;P

Ops :D Please let me know if it's working now

Yes it is. If it's also working for < API 23 devices as well, then I guess it's a wrap

Thanks for the suggestions and the help provided, I'll be closing this issue them


Limit cache size by default

See https://github.com/amphp/cache/issues/4.

The linked issue has been implemented, what's a good default cache size?

@amphp/dns Any suggestions?

Don't really know.
I think a LRU cache with size=256 should be really sufficient for most needs. That's not too large, but really not less than 99% of use cases will need.

If it's a LRU cache, it should be way bigger than 256. Memory is pretty cheap and the entries are pretty small, right?
Is there any problem with having a 64kB entry cache?

I meant 256 entries ;-), which, in PHP, will be around 80 KB, I guess.


Istio Integration: Allow activating Automatic mutual TLS in interface

What kind of request is this (question/bug/enhancement/feature request):
Feature request
Steps to reproduce (least amount of steps as possible):
Automatic mutual TLS is a very nice feature of istio to automatically encrypt traffic between istio proxies.
It can be optionally activated by setting the global.mtls.auto  flag to true when installing/configuring istio.
Of course this setting can be provided as a "Custom answer" but it would be nice to have this as a checkbox in the Istio installation/configuration interface to make it easier to use.
Result:
There is a checkbox in the istio installation/configuration interface to toggle Automatic mutual TLS.
Environment information

Rancher version (rancher/rancher/rancher/server image tag or shown bottom left in the UI): 2.4.2
Installation option (single install/HA): HA

gz#10377

Having Rancher smoothly enable MTLS for Istio with some documentation on how to work with it would be very helpful to some of our customers.

gz#10377

We now don't need to activate auto mTLS manually, all traffic between workloads with proxies uses mutual TLS by default. This was enabled in istio 1.5 and has been default since then. Refer this document for more information.
Closing this issue based on the above findings.


added authorization check for update address details for user

the was some conflict but i fixed them, just wait for Github to update then I will approved your codes


Abstract HTTP (GET, PUT, POST, DELETE) Client Side Calls

Abstract http calls into their own class, functions should take api url, header options, etc.

This is complete.


The root cause is the validation performed during the initialization of the class.
However, a copy operation does not need to perform the expensive validation;
the object being copied should already be in a valid state.
I propose to remove validation during the copy stage.
As a side effect, there qill now be the option to disable validation at DissimilarityMatrix (and DistanceMatrix) create, e.g. when the caller has already validate the input data by other means.

:+1:

:+1:

Fixed in #1747


Unable to connect to S3 Gateway with s3cmd

What happened?:
Connecting to the S3 Gateway on a Hub cluster I'm unable to list repos:
> s3cmd ls
WARNING: Could not determine bucket the location. Please consider using the --region parameter.
ERROR: S3 error: 400 (AuthorizationHeaderMalformed): The authorization header you provided is invalid.

pachd logs:
2020-06-22T13:48:54Z INFO http request: GET /

If I try using V2 auth headers (s3cmd ls --signature-v2) I can see that the token is parsed out and WhoAmI happens successfully, but it seems like the gateway is rejecting the signed request header:
2020-06-22T13:50:26Z INFO http request: GET /
2020-06-22T13:50:26Z INFO auth.API.WhoAmI {"request":{}} []
2020-06-22T13:50:26Z INFO auth.API.WhoAmI {"duration":0.002429326,"request":{},"response":{"username":"robot:account-25","ttl":2591512}} []

.s3cfg contents:
[default]
access_key = <pach access token>
access_token =
add_encoding_exts =
add_headers =
bucket_location = US
ca_certs_file =
cache_file =
check_ssl_certificate = True
check_ssl_hostname = True
cloudfront_host = cloudfront.amazonaws.com
connection_pooling = True
content_disposition =
content_type =
default_mime_type = binary/octet-stream
delay_updates = False
delete_after = False
delete_after_fetch = False
delete_removed = False
dry_run = False
enable_multipart = True
encoding = UTF-8
encrypt = False
expiry_date =
expiry_days =
expiry_prefix =
follow_symlinks = False
force = False
get_continue = False
gpg_command = /usr/local/bin/gpg
gpg_decrypt = %(gpg_command)s -d --verbose --no-use-agent --batch --yes --passphrase-fd %(passphrase_fd)s -o %(output_file)s %(input_file)s
gpg_encrypt = %(gpg_command)s -c --verbose --no-use-agent --batch --yes --passphrase-fd %(passphrase_fd)s -o %(output_file)s %(input_file)s
gpg_passphrase =
guess_mime_type = True
host_base = hub-c0-ng1cohb0hx.clusters-staging.pachyderm.io:30600
host_bucket = hub-c0-ng1cohb0hx.clusters-staging.pachyderm.io:30600/%(bucket)
human_readable_sizes = False
invalidate_default_index_on_cf = False
invalidate_default_index_root_on_cf = True
invalidate_on_cf = False
kms_key =
limit = -1
limitrate = 0
list_md5 = False
log_target_prefix =
long_listing = False
max_delete = -1
mime_type =
multipart_chunk_size_mb = 15
multipart_max_chunks = 10000
preserve_attrs = True
progress_meter = True
proxy_host =
proxy_port = 0
public_url_use_https = False
put_continue = False
recursive = False
recv_chunk = 65536
reduced_redundancy = False
requester_pays = False
restore_days = 1
restore_priority = Standard
secret_key = <pach access token>
send_chunk = 65536
server_side_encryption = False
signature_v2 = False
signurl_use_https = False
simpledb_host = sdb.amazonaws.com
skip_existing = False
socket_timeout = 300
stats = False
stop_on_error = False
storage_class =
throttle_max = 100
upload_id =
urlencoding_mode = normal
use_http_expect = False
use_https = True
use_mime_magic = True
verbosity = WARNING
website_endpoint = hub-c0-ng1cohb0hx.clusters-staging.pachyderm.io:30600/%(bucket)
website_error =
website_index = index.html

What you expected to happen?:
How to reproduce it (as minimally and precisely as possible)?:
Anything else we need to know?:
Environment?:

Kubernetes version (use kubectl version):
Pachyderm CLI and pachd server version (use pachctl version):
Cloud provider (e.g. aws, azure, gke) or local deployment (e.g. minikube vs dockerized k8s):
OS (e.g. from /etc/os-release):
Others:

I think this might actually be one or more bugs on s3cmd's side that've come up since we last tested against s3cmd (which was a while ago.)
I stood up a local cluster, enabled enterprise/auth, and configured ~/.s3cfg as such:
[default]
access_key = <token>
access_token =
add_encoding_exts =
add_headers =
bucket_location = US
ca_certs_file =
cache_file =
check_ssl_certificate = True
check_ssl_hostname = True
cloudfront_host = cloudfront.amazonaws.com
content_disposition =
content_type =
default_mime_type = binary/octet-stream
delay_updates = False
delete_after = False
delete_after_fetch = False
delete_removed = False
dry_run = False
enable_multipart = True
encoding = UTF-8
encrypt = False
expiry_date =
expiry_days =
expiry_prefix =
follow_symlinks = False
force = False
get_continue = False
gpg_command = /usr/bin/gpg
gpg_decrypt = %(gpg_command)s -d --verbose --no-use-agent --batch --yes --passphrase-fd %(passphrase_fd)s -o %(output_file)s %(input_file)s
gpg_encrypt = %(gpg_command)s -c --verbose --no-use-agent --batch --yes --passphrase-fd %(passphrase_fd)s -o %(output_file)s %(input_file)s
gpg_passphrase =
guess_mime_type = True
host_base = localhost:30600
host_bucket = localhost:30600/%(bucket)s
human_readable_sizes = False
invalidate_default_index_on_cf = False
invalidate_default_index_root_on_cf = True
invalidate_on_cf = False
kms_key =
limit = -1
limitrate = 0
list_md5 = False
log_target_prefix =
long_listing = False
max_delete = -1
mime_type =
multipart_chunk_size_mb = 15
multipart_max_chunks = 10000
preserve_attrs = True
progress_meter = True
proxy_host =
proxy_port = 0
put_continue = False
recursive = False
recv_chunk = 65536
reduced_redundancy = False
requester_pays = False
restore_days = 1
restore_priority = Standard
secret_key = <token>
send_chunk = 65536
server_side_encryption = False
signature_v2 = False
signurl_use_https = False
simpledb_host = sdb.amazonaws.com
skip_existing = False
socket_timeout = 300
stats = False
stop_on_error = False
storage_class =
throttle_max = 100
upload_id =
urlencoding_mode = normal
use_http_expect = False
use_https = False
use_mime_magic = True
verbosity = WARNING
website_endpoint = http://%(bucket)s.s3-website-%(location)s.amazonaws.com/
website_error =
website_index = index.html

When running s3cmd --debug ls, this is outputted:
DEBUG: Using signature v2
DEBUG: SignHeaders: 'GET\n\n\n\nx-amz-date:Mon, 22 Jun 2020 17:27:36 +0000\n/'
DEBUG: Processing request, please wait...
DEBUG: get_hostname(None): localhost:30600
DEBUG: ConnMan.get(): creating new connection: http://localhost:30600
DEBUG: non-proxied HTTPConnection(localhost, 30600)
DEBUG: format_uri(): /
DEBUG: Sending request method_string='GET', uri='/', headers={'x-amz-date': 'Mon, 22 Jun 2020 17:27:36 +0000', 'Authorization': 'AWS 1554a2bcbc85496ebb1f6b17005c4195:b3rWnHcbAPHbzIKPGbVsp0c6Bd4='}, body=(0 bytes)
DEBUG: ConnMan.put(): connection put back to pool (http://localhost:30600#1)
DEBUG: Response:
{'data': b'<?xml version="1.0" encoding="UTF-8"?>\n<Error>AccessDenied'
         b'<Message>Access Denied</Message><Resource>/</Resource><Reques'
         b'tId>0a71d759-aef1-4041-9a6c-8ad585dddf99</RequestId></Error>',
 'headers': {'content-length': '192',
             'content-type': 'application/xml',
             'date': 'Mon, 22 Jun 2020 17:27:36 GMT',
             'x-amz-id-2': '0a71d759-aef1-4041-9a6c-8ad585dddf99',
             'x-amz-request-id': '0a71d759-aef1-4041-9a6c-8ad585dddf99'},
 'reason': 'Forbidden',
 'status': 403}
DEBUG: S3Error: 403 (Forbidden)

There's two issues with this:

It's using auth v2 headers, even though we told it to not to do so in the config (though this shouldn't matter since we do support both.)
The header it's sending is malformed (see the SignHeaders message, and compare that to the signature version 2 spec.

Were you able to verify that s3g works with other client CLIs or libraries? We actively test against boto, the aws cli, the minio cli, the minio go library, and the minio python library.

Confirmed this works with the minio client, maybe we should remove s3cmd from the docs.

Yeah that makes sense, let's repurpose this as a docs ticket to do so


SMIRNOFF: CMAPs

CMAPs are used in some biopolymer force fields but absent from the SMIRNOFF spec.
One detail that maybe should be specified is the order of the spline used to interpolate between gridpoints. There may be some differences between how engines implement this; in any case the spec should be as explicit as possible.
References:

http://docs.openmm.org/latest/userguide/application.html#cmaptorsionforce
http://docs.openmm.org/latest/userguide/theory.html?highlight=cmap#cmaptorsionforce
https://github.com/ParmEd/ParmEd/issues/1066
https://manual.gromacs.org/documentation/2019.1/reference-manual/functions/force-field.html#charmm

This would seem to be something that should be use case driven. If / when a user wants to include this, they should make their case for including it in the spec and when / if that time comes, the infrastructure team can work with the user to assess the best path forward to accommodate it.
Without a championing user, I'd recommend leaving it out. Note this does not preclude a user from creating their own CMAP handler (or anyone from making any custom handlers, it would just not be included in the spec initially.


Support keyword args and yields sections

Closes #324 and #205

CI needs #330 to pass.

Actually... I don't understand the purpose behind a "keyword args" section. The descriptions of all parameters can be within one section, why should they be separated?
The actual viability of passing arguments should be visible from the function's signature.

The purpose of the Keyword Argument section is to be able to document arguments that can be passed through **kwargs, and to enjoy the same formatting as for regular Arguments sections.
Consider this:
def function(a, b, **kwargs):
    c = kwargs.pop("c")
    d = kwargs.pop("d")
    # use a, b, c, d

You can document a, b, and **kwargs in the Arguments section, but not c and d directly, as they are not part of the signature (linters not happy). You could document them in the **kwargs description, but you'd have to use plain Markdown formatting for anything a bit elaborate. Instead, with a Keyword Arguments section, you can document c and d just like any other argument:
Keyword Arguments:
    c (int): Description.
    d (list[str] | None): Description

Wait, I thought that Python has eliminated all cases where you'd have to rely on **kwargs to serve particularly-named keyword-only arguments. Wouldn't it be good to just hope that the last usages of this will die out soon and encourage writing the arguments directly?
def function(a, b, *, c, d):

You have good arguments as always @oprypin :slightly_smiling_face:
I don't know if it's reasonable to expect that this use of **kwargs will disappear (its only use apart from swallowing unwanted arguments?). Support for this was explicitly requested by users :confused:

Well, if supporting this never pops up in any way except when people write Keyword arguments:, that's fine. (I was afraid that this would automatically create such sections where it didn't before). But I wouldn't change correct wording to wrong just to match this rare use case.
BTW they could instead describe kwargs as its own item within Args, with normal Markdown sub-lists in it

BTW they could instead describe kwargs as its own item within Args, with normal Markdown sub-lists in it

Yes that's what I initially replied in the original issue, #205.

I was afraid that this would automatically create such sections where it didn't before

Oh no, it's only rendered when a "Keyword arguments" section is found indeed.

But I wouldn't change correct wording to wrong just to match this rare use case.

Agreed. Then I'll totally revise what I said earlier, and change the section title to "Keyword parameters". Maybe "Other parameters", from Numpydoc, would be even more appropriate.

OK! Now no issue from my side.
I will not do a super careful review of all the content, so that's all.
Thanks

Failures came from a precedent version of PDM which fixed the KeyError issue.


Add full frame color stream option

Linux os can't see the cameras so I'll need to get full-color 720/1080/2160p frames from the api (like left right streams).

@chris-piekarski - Thanks for the issue.
Want to clarify: are you able to see the color output at all? Or requesting the larger original pixel size because the current preview display is too small?

Yes, I can see the preview color output @itsderek23. For my use case, I need to show a larger original pixel size to the user.

Thanks @chris-piekarski.
For a quick hack, would scaling the 300x300 size be workable or do you need the higher-res output?

Yeah, that is basically what we will be doing until we can get higher resolution frames. We're sending the preview stream to a remote 1080p viewer and I'd like to save 2160p video locally at the same time. At the moment I don't actually need to run inference on the color stream so even just direct access to the camera would work for POC (but would like to enable inference detection in v2).

So we now have h.264 color video output, see here.
So @chris-piekarski is this sufficient for the use-case you were intending?

FWIW also see here:
https://github.com/luxonis/depthai-python/pull/94
https://www.youtube.com/watch?v=Ww-vLSxOdW8&feature=youtu.be

FWIW also see here:
https://github.com/luxonis/depthai-python/pull/94
https://www.youtube.com/watch?v=Ww-vLSxOdW8&feature=youtu.be


fixed sendmessagebox

just until role lock is complete and ready

just until role lock is complete and ready

bad


Keyboard shortcut: Add task/idea by pressing Enter

It's boring to click the button, especially when you want to add multiple tasks/ideas. Most users expect this keyboard shortcut to be available, as it is in many other applications.

Would pressing Enter open the Task or the Idea dialog? Or would it simply open the FAB? I'm willing to help this feature get added, I already coded this feature but it only opens/closes the FAB for now.

@mvinoba
It's not about opening the FAB, dialog or anything else, but it's about closing the opened dialog (and adding the idea/task) by pressing Enter. Opening task/idea dialog has been added to the app previously.

Sure, I thought of wrapping <HotKeys> in NewIdeaDialog's render's return while defining the approppriate handler and keyMap binding to this.handleRequestAdd. But that didn't work, probably something to do with the focus, perhaps this is beyond my React knowledge. I appreciate your answer anyways.


add header to listhosts output

adjust some of the column sizes

👎  Reasons similar to https://github.com/amplifylitco/X_DEPRECATED_asiaq/pull/70

Any interest in continuing this PR?
Since this was done, I added this helper function to bin/disco_autoscale.py, which might make this task easier.
If not, can we close the PR?


SAK-42544 Unable to have 2 audio questions on same part when assessme…

…nt configured for all questions on one page

This looks good to me, nice one @josecebe because was complex.
Tested in preview mode and tested as student, multiple recorders can be opened using featherlight, saving the audio in the correspondingaudio question.
Verified as instructor accessing the audio file of every question.


ecs_load_balancers optional attributes

Describe the Bug
I am trying to provision an ECS service + ECS task using an ALB. To configure the options for load balancer, I am using this configuration:
locals {
  alb = [{
    container_name   = coalesce(var.alb_container_name, module.this.id)
    container_port   = var.container_port
    elb_name         = null
    target_group_arn = var.target_group_arn
  }]
}

Such local configuration goes directly to the module input like so:
module "ecs_alb_service_task" {
  source  = "cloudposse/ecs-alb-service-task/aws"
  version = "0.64.1"

  ...
  ecs_load_balancers                 = local.alb
...

  context = module.this.context
}

Both validation and plan runs as expected, but during the apply operation a TF error is returned:
module.ecs_alb_service_task.aws_ecs_service.ignore_changes_task_definition[0]: Creating...
╷
│ Error: error creating ECS service (mcoins-sandbox-analytics-denormalizer): InvalidParameterException: Load Balancer Name can not be blank.
│
│   with module.ecs_alb_service_task.aws_ecs_service.ignore_changes_task_definition[0],
│   on .terraform/modules/ecs_alb_service_task/main.tf line 351, in resource "aws_ecs_service" "ignore_changes_task_definition":
│  351: resource "aws_ecs_service" "ignore_changes_task_definition" {
│
╵

Which means I'm sending an empty string to AWS API and causing the issue. This led me to try getting rid of the elb_name value, and getting this other error:
│ Error: Invalid value for input variable
│
│   on main.tf line 110, in module "ecs_alb_service_task":
│  110:   ecs_load_balancers                 = local.alb
│
│ The given value is not suitable for
│ module.ecs_alb_service_task.var.ecs_load_balancers declared at
│ .terraform/modules/ecs_alb_service_task/variables.tf:11,1-30: element 0:
│ attribute "elb_name" is required.

I've looked into AWS API documentation and Terraform Provider and make sure that only container_port and container_name are required arguments so you can choose between classic ELB or ALB/NLB.
I suggest the option here is to add the optional keyword to both elb_name and target_group_arn arguments, so whenever values are supplied here it's not mandatory to supply both. I can also supply a PR with the suggested change if you're ok with it.
Expected Behavior
Terraform should be able to apply with either Classic or ALB/NLB values, but not require both.
Steps to Reproduce
Steps to reproduce the behavior:

Run an example that supplies ecs_load_balancers value with either classic ELB name or ALB target group ARN.
Run terraform init && terraform apply

Screenshots
Code snippets and errors above
Environment (please complete the following information):

OS: OSX, arm64
Version: Monterrey 12.4
Terraform version:

Terraform v1.2.4
on darwin_arm64
+ provider registry.terraform.io/hashicorp/aws v4.22.0
+ provider registry.terraform.io/hashicorp/local v2.2.3
+ provider registry.terraform.io/hashicorp/null v3.1.1

Additional Context
None.

@HebertCL were you able to resolve this ?

Hi @kunalsawhney, since my use case was very specific and not likely to use classic LB I decided to fork on this repo and simplify the configuration to only expect ALB connectivity. I know this is not flexible nor the most ideal solution, but it was enough for me to move forward. I think for now this issue can be closed.

@HebertCL I know you've already got around this, but I also found just setting elb_name = null satisfied the requirement when using ALBs.

Does anyone use this module with ecs tasks + alb?

it has no ecs_load_balancers example(s)
it doesn't appear to work with an alb

It requires both elb_name & target_group_arn but the provider resource explicitly needs one or the other.
I'm not sure if I'm just misunderstanding how to use it or if its broken.

I was able to use this successfully by setting elb_name = null

confirming elb_name = null works!


Do not spit on the console 2nd stage (inspired by Debian)

Thank you for all of your contributions, @aquesnel, especially logging improvement.
I would like to share some basic directions about logging on the console.
As Debian's downstream patch expresses, they don't like xrdp spit logs on the console when it runs as daemons. I agree with Debian guys at this point.

https://salsa.debian.org/debian-remote-team/xrdp/-/blob/master/debian/patches/shutup-daemon.diff

It is partially done in #1142. I would like to complete this. Here's my thoughts about logging:

xrdp and xrdp-sesman should not write anything on stdout/stderr when they run as daemons (except fatal errors)
information such as configuration summaries can be dumped when it runs in the foreground

Any feedback is welcome, thanks.
Thoughts:
I personally would like to pick downstream patches up and merge proactively if they're useful to everyone. Because I'm an upstream developer and also a distro package maintainer. Upstream first is a good strategy in most cases. Less downstream patches should make both upstream and downstream happy.

hi @metalefty ,
Thanks for asking for my opinion.
I agree with you about only logging fatal messages to the console when running as a daemon. I also agree that configuration being dumped to the console when not running as a daemon is a good idea.
I looked at the Debian patch that you linked to, and I don't think it should be applyed it as is because it unconditionally removes useful debugging information. I think that xrdp should conditionally output that information if the user asks for it or create a config that downstream maintainers can define a default for their distribution to disable the information.
I think that a solution based on the logging config will have the biggest impact because as I continue to migrate to the logging to the unified macros across the whole code base then not writing to the console will just follow the configuration.
My ideas for addressing this issue are:

set the default log level for the console to error or fatal
or, when running as a daemon conditionally set the default log level for the console to error or fatal, and if the not running as a daemon then leave the console default to info.
or, add a command line parameter to enable dumping the config to the console on start up

Hi both,
I added an additional member dump_on_start to struct log_config as part of #1711. At the moment this is used to suppress dumping the logging output to stdout when running a console utility like sesrun which is (I think) exactly what you're trying to do here. It doesn't currently have an easy way to set it in other circumstances.
I was going to suggest using this, but on the other hand I think it might be best to remove it entirely.
If I take @aquesnel's suggestions above as a starting point, this gives the following outline implementation:-

Remove dump_on_start from struct log_config
Add an extra boolean argument to log_start() to dump the logging config (log_start() is only used by xrdp and xrdp-sesman)
Plumb in an extra command-line parameter to xrdp and xrdp-sesman to allow the boolean value to be changed from whatever the default is.
Update the man pages for xrdp and xrdp-sesman

Maybe roughly an hour's work with review time on top.
Does that sound like it's along the right lines? In particular @aquesnel, is it compatible with what you see as the future direction of logging?

hi both,
Yes @matt335672 , I agree with your suggested outline.
My plans for logging are to continue the logging macro unification work that I started in #1633 and to add more detailed trace logging like what I've done in #1742. So the changes here are compatible with the work I'm doing.


Why is t.throws() so hard to use?

t.throws(function() {
    throw new TypeError('some type error');
}, TypeError, 'should throw a TypeError');

This just does not work.

t.throws(fn, [expectedError], message, extra)
Expect the function to throw an error. If an expected error is provided, then also verify that the thrown error matches the expected error.

How is such a "match" verified?

I hope such a "error match" is not based on a just descriptive message property...

The only robust alternative coming to my mind is the following:
try {
	throw new TypeError('some type error');
}
catch (error)
{
	t.ok(error instanceof TypeError, 'should throw TypeError');
	t.end();
}

Do I miss something?

The intent was to pass in a sample error object.  So, you'd do soething like:
t.throws(function() {
    throw new TypeError('some type error');
}, new TypeError('some type error'), 'should throw a TypeError');

The match in that case is based on the message property, type, and any other additional fields provided.  For example, you could specify something like this:
var expect = new Error('ENOENT: no such file or directory, open 'does not exist')
expect.code = 'ENOENT'
expect.syscall = 'open'
expect.path = 'does not exist'
t.throws(function () {
  fs.readFileSync('does not exist')
}, expect)

I hope such a "error match" is not based on a just descriptive message property...

Since there are only 4 Error types in JavaScript, and the language lacks typed catches, it's much more common to test based on message and other properties, as that tends to be much more restrictive.
Nevertheless, the feature you're expecting was easy to add, and it's a very reasonable thing to expect, so I wrote added it in v5.4.0.

Thanks for the explanation. If you added this feature for v5.4.0, may you please update this issue?

Sorry, I missed the commit and the release :)

It works fine :)
Thanks a lot.

Not directly related to the original question in this old thread, but for anybody whose Google searches have brought them to this issue like mine did:
If you imagined that passing a string for the argument named "message" would match against the error message, it won’t — the "message" that’s being referred to is an optional name for the specific assertion, not the error message. However there is a simple way:
t.throws(fn, /regular-expression/);

(This is also true for Test.prototype.rejects).

@isaacs I’m a bit horrified by the number of incorrect assertions with tap I’ve probably written in the past because I didn’t realize this 😅 (with the string arg, you get a pass if the fn just throws, regardless of what it throws, so I didn’t see the mistake for a long time). Maybe this was just me, but if not, I’m wondering if the documentation for throws could be clearer?

I still couldn't make this work properly:
test("Exception works as expected", function (t) {
  t.throws(function () {
    throw new Error("Foo");
  }, Error);
});

Yields:
 FAIL  test/unit/exceptions.js
 ✖ test unfinished

  test: Exception works as expected
  stack: |
    file://test/unit/exceptions.js:10:1
    async Promise.all (index 0)
  at:
    line: 10
    column: 1
    file: file://test/unit/exceptions.js

 FAIL  test/unit/exceptions.js 1 failed of 2 14.391ms
 ✖ test unfinished

  🌈 SUMMARY RESULTS 🌈

 FAIL  test/unit/exceptions.js 1 failed of 2 14.391ms
 ✖ test unfinished


simplify BatchIterators, fix bug in advanceIfNeeded

Currently the iterator can return true for hasNext after the last batch, before returning no data, after returning no data, hasNext returns false. This change simplifies the code and avoids this last pointless iteration.

In the worst case, this might add some overhead per call but because it is a batched iterator, I am not concerned.
Let us merge.

(I didn't merge.)


Improve documentation for what EXTERNAL_COEX_ENABLE does and when to use it (TZ-429)

I picked up the Thread Border Router board and was following the instructions at https://docs.espressif.com/projects/esp-thread-br/en/latest/dev-guide/build_and_run.html
It says:

Enable EXTERNAL_COEX_ENABLE option if you want to enable the RF External coexistence.
Note: To enable external coexistence of the Thread Border Router, enable the EXTERNAL_COEX_ENABLE option of $IDF_PATH/examples/openthread/ot_rcp before building the RCP Image.

However, I can't find any information on what this means. My understanding was that the reason for using two boards (as there are on the TBR board) was for coexistance, however it's off by default and the docs don't give any indication of under what circumstances you would/would not want to use this.
Thanks!

Please refer to this doc for the external coexistence design: https://www.espressif.com.cn/sites/default/files/documentation/external_coexistence_design_en.pdf
The 3-wire coex mechanism is supported in the ESP Thread BR SDK. When enabled, S3 acts as the coex master, H2 acts as the slave, the two will not transmit at the same time to void RF interference. It helps to improve the performance especially when Wi-Fi and 802.15.4 are operating on a close frequency.
The implementation is built in the SDK itself, which work closely with the HW coex module. We don't expect user to modify the detailed logic. Let us know if you have any specific requirement on the coex design.

The 3-wire coex mechanism is supported in the ESP Thread BR SDK. When enabled, S3 acts as the coex master, H2 acts as the slave, the two will not transmit at the same time to void RF interference. It helps to improve the performance especially when Wi-Fi and 802.15.4 are operating on a close frequency.

So would you recommend enabling it? It's not clear to me what the trade-off is like between less interference and each radio having to keep pausing for the other.
I think whatever the answer to that question is would be useful to include in the notes at https://docs.espressif.com/projects/esp-thread-br/en/latest/dev-guide/build_and_run.html so it's clearer why you might choose to use it when working through the guide :-)

The coex is not a mandatory feature for a product, the two RFs could anyway work together without enabling coex, since there are two separate RF paths.
If the application could ensure that Wi-Fi and 802.15.4 will operate on different frequency, then Coex is not necessary. But if the two work on a close frequency, then the RF interference is significant, where the coex would be helpful.
Thanks for the suggetion, we will enhance the docs with more description about coex.

If the application could ensure that Wi-Fi and 802.15.4 will operate on different frequency, then Coex is not necessary. But if the two work on a close frequency, then the RF interference is significant, where the coex would be helpful.

Got it, thank you :)


Cloud Tasks Documentation link return 404 error.

Cloud Tasks Documentation link return 404 error.
Documentation link - https://cloud.google.com/tasks/docs/

@steren any reason why the docs are still whitelisted like this?

Cloud Tasks is still in Alpha, will enter Beta within days.
On Wed, Sep 12, 2018, 21:37 Justin Beckwith<EMAIL_ADDRESS>wrote:

@steren https://github.com/steren any reason why the docs are still
whitelisted like this?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/googleapis/nodejs-tasks/issues/57#issuecomment-420880742,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAWBv1BzpLnBdvpLmuHfTQ9g8YGvLC2Rks5uaeEZgaJpZM4WTISv
.


[WIP] Update LocalStorageCapacityIsolationFSQuotaMonitoring to beta

pending on https://github.com/kubernetes/kubernetes/pull/112626/
See https://github.com/kubernetes/enhancements/issues/1029.

/retitle [WIP] Update LocalStorageCapacityIsolationFSQuotaMonitoring to beta
so that Prow knows it's a draft

k/k PR is not merged yet. So this will be postponed to v1.30.


startAuthentication step does not complete

Describe the issue
startAuthentication does not complete

After entering in the email of the registered passkey and upon clicking submit on my web page, I invoke the startAuthentication function. My browser then asks to "choose a passkey".

Upon clicking the respective passkey, the browser then asks me to verify which I do with my biometric password.

I now expect this login process to be complete, however, now it asks me to "Use your passkey" with an alternative device or USB, which I do not have nor set up during my register process. I expect this is not expected behavior as I am now stuck in the log in process.

Would I please get assistance of how to invoke startAuthentication with expected behaviour?
Expected behavior
I expect now the startAuthentication function to correctly pass without any more user prompts.
Code Samples + WebAuthn Options and Responses
  const onSubmit = async (event: FormEvent) => {
    event.preventDefault()
    const authenticationOptionsJSON = await getAuthenticationOptionsJSON(email)
    const { challenge } = authenticationOptionsJSON
    const credential = await getCredential(challenge)

    try {
      const authenticationResponse:
      AuthenticationResponseJSON = await
      startAuthentication(
        authenticationOptionsJSON,
      )
    } catch (err) {
      const loginError = err as Error
      setError(loginError.message)
    }

    // then later verifyAuthentication(userCredential, challenge, authenticationResponse)
    // then later router.push('/page-of-auth-content')
  }

console.log(authenticationOptionsJSON)

Dependencies

OS: macOS 13.5.2 (22G91)
Browser: Version 116.0.5845.187 (Official Build) (arm64)
Authenticator: MacBook TouchID

SimpleWebAuthn Libraries

$ npm list --depth=0 | grep @simplewebauthn
├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS># ...

@simplewebauthn/browser 7.2.0
@simplewebauthn/server 7.3.1
@simplewebauthn/typescript-types 7.0.0

Additional context
I am using NextJS App Router and have separated my functions to 'use client' for functions to be run in client-side environments and 'use server' for functions to be run in server-side environments

Hello @renchris, unfortunately the code sample you provided doesn't reveal enough about your setup to give me an idea of what might be going wrong. Can you prepare a reproduction repository that I can pull down that includes the simplest NextJS app that can recreate the issue? I can help further when I have something like your setup that I can run locally.

Hello @MasterKale. Thanks for replying here. Okay, I put my codebase into a public repository which you can pull down here. I created a README to outline the project files and directories and the steps to run locally.

I think I see the problem, you're making two navigator.credential.get() requests. The first is here, when you use get() from @github/webauthn-json:
https://github.com/renchris/app-router-with-webauthn/blob/main/src/components/LoginPage.tsx#L30-L37
Then you call startAuthentication() from @simplewebauthn/browser immediately afterwards:
https://github.com/renchris/app-router-with-webauthn/blob/main/src/components/LoginPage.tsx#L39-L43
Figure out which one you prefer and upgrade your code to use that one exclusively.
It also looks like you're encoding the base64url-encoded credential ID as base64url:
Registration credential ID: "kDcVv4FXfuvvi4szvUOM7Nj_WEA"
Authentication allowCredentials entry: "a0RjVnY0RlhmdXZ2aTRzenZVT003TmpfV0VB"

The credential ID included in allowCredentials needs to be the same credential ID you get back from registration. To confirm that this is the problem, if we base64url-encode the credential ID from registration we'll see it's the same as the credential ID in allowCredentials during auth:
> Buffer.from('kDcVv4FXfuvvi4szvUOM7Nj_WEA', 'utf-8').toString('base64url')
'a0RjVnY0RlhmdXZ2aTRzenZVT003TmpfV0VB'

...this is causing a double-encoding issue, so the credential ID that you include in allowCredentials that then gets passed to startAuthentication() fails to be recognized by any authenticator. That's why you're only being prompted for security key or hybrid auth in the second call, the one that calls startAuthentication() (the first call, to get(), shows the credential you expect because no entries are specified in allowCredentials, so the browser shows all available credentials.)
Hope that all helps.
As this isn't an issue with SimpleWebAuthn, I'm going to close this issue out. Feel free to re-open if you believe you've identified an actual issue

Hi Matthew. Thanks, this helped a lot.
I wasn't aware that get ' from @github/webauthn-json' and '@simplewebauthn/browser' from '@simplewebauthn/browser' completed the same task of prompting the user for their credentials. I removed the get credentials function.
Ah, you're right, I was not decoding my stored encoded credential ID back correctly.
I fixed the allowsCredentials to decode back to the exact original credentialID Uint8Array value initially provided from VerifiedRegistrationResponse  during the user registration step.
const loginOptionsParameters: GenerateAuthenticationOptionsOpts = {
  timeout: 60000,
  allowCredentials: (usersCredentials as Credential[]).map((userCredential) => ({
-   id: Uint8Array.from(userCredential.externalId, (c) => c.charCodeAt(0)),
+   id: new Uint8Array(Buffer.from(userCredential.externalId, 'base64')),
    type: 'public-key',
  })),
  userVerification: 'required',
  rpID: 'localhost',
}

This solved my issue, thank you!


Meteor/18

Wait on 1.8 to finish & merge

@sebakerckhof can you do an atmosphere release of that?

@macrozone yep, released as version 4.10.0


nagios: 4.4.1 -> 4.4.2

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/nagios/versions.
meta.description for nagios is: '"A host, service and network monitoring program"'.

Checks done (click to expand)

built on NixOS
/nix/store/bs79mm5h9fpjlnfhlj614gy1d4781ykp-nagios-4.4.2/bin/nagios passed the binary check.
/nix/store/bs79mm5h9fpjlnfhlj614gy1d4781ykp-nagios-4.4.2/bin/nagiostats passed the binary check.
Warning: no invocation of /nix/store/bs79mm5h9fpjlnfhlj614gy1d4781ykp-nagios-4.4.2/bin/archivejson.cgi had a zero exit code or showed the expected version
Warning: no invocation of /nix/store/bs79mm5h9fpjlnfhlj614gy1d4781ykp-nagios-4.4.2/bin/avail.cgi had a zero exit code or showed the expected version
Warning: no invocation of /nix/store/bs79mm5h9fpjlnfhlj614gy1d4781ykp-nagios-4.4.2/bin/cmd.cgi had a zero exit code or showed the expected version
Warning: no invocation of /nix/store/bs79mm5h9fpjlnfhlj614gy1d4781ykp-nagios-4.4.2/bin/config.cgi had a zero exit code or showed the expected version
Warning: no invocation of /nix/store/bs79mm5h9fpjlnfhlj614gy1d4781ykp-nagios-4.4.2/bin/extinfo.cgi had a zero exit code or showed the expected version
Warning: no invocation of /nix/store/bs79mm5h9fpjlnfhlj614gy1d4781ykp-nagios-4.4.2/bin/histogram.cgi had a zero exit code or showed the expected version
Warning: no invocation of /nix/store/bs79mm5h9fpjlnfhlj614gy1d4781ykp-nagios-4.4.2/bin/history.cgi had a zero exit code or showed the expected version
Warning: no invocation of /nix/store/bs79mm5h9fpjlnfhlj614gy1d4781ykp-nagios-4.4.2/bin/notifications.cgi had a zero exit code or showed the expected version
Warning: no invocation of /nix/store/bs79mm5h9fpjlnfhlj614gy1d4781ykp-nagios-4.4.2/bin/objectjson.cgi had a zero exit code or showed the expected version
Warning: no invocation of /nix/store/bs79mm5h9fpjlnfhlj614gy1d4781ykp-nagios-4.4.2/bin/outages.cgi had a zero exit code or showed the expected version
Warning: no invocation of /nix/store/bs79mm5h9fpjlnfhlj614gy1d4781ykp-nagios-4.4.2/bin/showlog.cgi had a zero exit code or showed the expected version
Warning: no invocation of /nix/store/bs79mm5h9fpjlnfhlj614gy1d4781ykp-nagios-4.4.2/bin/status.cgi had a zero exit code or showed the expected version
Warning: no invocation of /nix/store/bs79mm5h9fpjlnfhlj614gy1d4781ykp-nagios-4.4.2/bin/statusjson.cgi had a zero exit code or showed the expected version
Warning: no invocation of /nix/store/bs79mm5h9fpjlnfhlj614gy1d4781ykp-nagios-4.4.2/bin/statusmap.cgi had a zero exit code or showed the expected version
Warning: no invocation of /nix/store/bs79mm5h9fpjlnfhlj614gy1d4781ykp-nagios-4.4.2/bin/statuswml.cgi had a zero exit code or showed the expected version
Warning: no invocation of /nix/store/bs79mm5h9fpjlnfhlj614gy1d4781ykp-nagios-4.4.2/bin/statuswrl.cgi had a zero exit code or showed the expected version
Warning: no invocation of /nix/store/bs79mm5h9fpjlnfhlj614gy1d4781ykp-nagios-4.4.2/bin/summary.cgi had a zero exit code or showed the expected version
Warning: no invocation of /nix/store/bs79mm5h9fpjlnfhlj614gy1d4781ykp-nagios-4.4.2/bin/tac.cgi had a zero exit code or showed the expected version
Warning: no invocation of /nix/store/bs79mm5h9fpjlnfhlj614gy1d4781ykp-nagios-4.4.2/bin/trends.cgi had a zero exit code or showed the expected version
2 of 21 passed binary check by having a zero exit code.
0 of 21 passed binary check by having the new version present in output.
found 4.4.2 with grep in /nix/store/bs79mm5h9fpjlnfhlj614gy1d4781ykp-nagios-4.4.2
directory tree listing: https://gist.github.com/a0edb5f1ebdb78cae18113531918f3db
du listing: https://gist.github.com/e8a8c7d0ba0b6b623a3e1796f8b73a29

Test this build with Cachix (click to expand)

One time setup in nixpkgs Git checkout:
cachix use r-ryantm
git remote add r-ryantm https://github.com/r-ryantm/nixpkgs.git

Test this build:
git fetch r-ryantm && git checkout dec300c8730f739699347e3269a47c38d4d6a3c1 && nix-shell --pure -I nixpkgs=. -p nagios

cc @thoughtpolice @relrod for testing.

No attempt on x86_64-darwin (full log)
The following builds were skipped because they don't evaluate on x86_64-darwin: nagios
Partial log (click to expand)

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.


Bump helm chart version

Bump Helm chart version to 0.1.0-128

done by https://github.com/h2oai/h2ogpt-utils/pull/6, the version from repo won't be used, will use whatever the current build Id is. If need to update the repo then can auto-commit the changes.
@EshamAaqib can you please look at the permission issue here:
14:34:58  + docker run --rm -v /home/jenkins/slave_dir_from_mr-0xc1/workspace/h2oGPT/h2ogpt-docker-runtime-publish-nightly:/workdir -u 2117:2117 --entrypoint helm harbor.h2o.ai/opsh2oai/yq-helm push h2ogpt-0.1.0-132.tgz oci://223008754879.dkr.ecr.us-east-1.amazonaws.com/helm
14:35:01  Error: unexpected status from HEAD request to https://223008754879.dkr.ecr.us-east-1.amazonaws.com/v2/helm/h2ogpt/blobs/sha256:4871d2f2052c2028ed6c3563ee496efe998f70c0cab356f060976c403a076701: 401 Unauthorized

maybe need to create the helm repo?

done by h2oai/h2ogpt-utils#6, the version from repo won't be used, will use whatever the current build Id is. If need to update the repo then can auto-commit the changes.
@EshamAaqib can you please look at the permission issue here:
14:34:58  + docker run --rm -v /home/jenkins/slave_dir_from_mr-0xc1/workspace/h2oGPT/h2ogpt-docker-runtime-publish-nightly:/workdir -u 2117:2117 --entrypoint helm harbor.h2o.ai/opsh2oai/yq-helm push h2ogpt-0.1.0-132.tgz oci://223008754879.dkr.ecr.us-east-1.amazonaws.com/helm
14:35:01  Error: unexpected status from HEAD request to https://223008754879.dkr.ecr.us-east-1.amazonaws.com/v2/helm/h2ogpt/blobs/sha256:4871d2f2052c2028ed6c3563ee496efe998f70c0cab356f060976c403a076701: 401 Unauthorized

maybe need to create the helm repo?

@achraf-mer Repo has been created


false syntax errors

From<EMAIL_ADDRESS>on 2010-07-22T04:46:07Z
What steps will reproduce the problem?
1.load C:\Python26\Lib\site-packages\spyderlib\widgets\editor.py
(This is an example, the problem occurs on some other files also)
2.Press F9 What is the expected output? What do you see instead? The file is OK but following output is produced:
runfile(u'C:\Python26\Lib\site-packages\spyderlib\widgets\editor.py', args='')
File "C:\Python26\Lib\site-packages\spyderlib\widgets\editor.py", line 1792
^
SyntaxError: invalid syntax What version of the product are you using? On what operating system? spider 1.1.2, winXP
Original issue: http://code.google.com/p/spyderlib/issues/detail?id=254

From<EMAIL_ADDRESS>on 2010-07-29T06:11:31Z
Perhaps this helps: when I put one extra line at the bottom:
print ''
then the syntax error goes away.

From pierre.raybaut on 2010-07-22T03:06:47Z
Fixed: https://code.google.com/p/spyderlib/source/detail?r=c467b5ab89de641824f54b2eef0ec0bd2d4d449d&repo=v11
Status: Fixed

From<EMAIL_ADDRESS>on 2010-07-29T06:08:29Z
Unfortunately this does not fix the problem.
For example, this simple program:
----------------------
# -- coding: utf-8 --
if 1:
filepath=r'D:\projects\sandbox'
print filepath
#testing
----------------------
produces in the interactive console (when pressing F9):
\#testing
       ^

SyntaxError: invalid syntax
but it runs fine in the external console (F5)

From pierre.raybaut on 2010-07-29T07:14:36Z
Yes it certainly helps.
I've definitely fixed this issue in my local repository. I'll update the google code repository next week.
Thanks for your help.

From pierre.raybaut on 2010-10-21T07:05:20Z
issue #421 has been merged into this issue.

From<EMAIL_ADDRESS>on 2010-10-21T14:38:47Z
Installed v1.1.8 and issue is still present.


Custom function to load data

Is there a way to define its own function to load data like
$('.selectpicker').selectpicker().ajaxSelectPicker({
data: function (data) {
// my function here
return ['1', '2']; // ...
}
});
This could be done in AJAX mode, filtering among 100000 values.

depends on what you mean by load data.
https://jsfiddle.net/jefffan24/okbnumdc/ shows how to process data from the server on the client (it does the filtering client side and just loads a static list).
You can do what you did there to dynamically build the data sent to the server.
You can't override the ajax calls themselves though.  What are you trying to do exactly?

Actually there is an existing web service filtering data not using q as parameter and returning data not not well formatted for ajaxselectedpicker.
Anyway, is it possible to just call my function, passing q as parameter and returning the 10 first values filtered

@comodore31 do you still need help?

No thanks, I did my own version of bootstrap select to do the job :)


Changed validation flow

Just a note: clearValidationError function can be made more reusable by adding classes as arguments


Add whatsapp button

add new WhatsApp button

@quangpro1610 is there a login with Bitbucket functionality? We don't want to add anything that doesn't actually exist.

@quangpro1610 is there a login with Bitbucket functionality? We don't want to add anything that doesn't actually exist.

Have you used Bitbucket before?  It is similar to GitHub
Read more: https://bitbucket.org/

I know bitbucket but can you go on a different website and choose to "Login with Bitbucket"?


fix: separate out subscription errors from field level resolver generation

Description of changes
This pull requests separates out generation of field-level resolvers from checking for errors on types with subscriptions configured.
Checklist

[x] PR description included
[x] yarn test passes
[x] Tests are changed or added

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Codecov Report

Merging #9671 (dda5cf2) into master (4a87373) will decrease coverage by 0.00%.
The diff coverage is 46.66%.

@@            Coverage Diff             @@
##           master    #9671      +/-   ##
==========================================
- Coverage   52.93%   52.92%   -0.01%
==========================================
  Files         829      830       +1
  Lines       45865    45922      +57
  Branches     9789     9800      +11
==========================================
+ Hits        24279    24305      +26
- Misses      19581    19608      +27
- Partials     2005     2009       +4

Impacted Files
Coverage Δ

...amplify-cli-core/src/feature-flags/featureFlags.ts
80.83% <ø> (ø)

...c/extensions/amplify-helpers/auth-notifications.ts
42.59% <42.59%> (ø)

...l-auth-transformer/src/graphql-auth-transformer.ts
89.62% <50.00%> (ø)

packages/graphql-transformer-core/src/index.ts
97.43% <100.00%> (+0.21%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a87373...dda5cf2. Read the comment docs.

@jhockett @SwaySway addressed comments


reconnect with new user id failed

angular.js:13920 TypeError: callback is not a function
    at db-manager.js:962
    at DbManager.onOpen (db-manager.js:149)
    at DbManager.deleteTables (db-manager.js:961)
    at Client._clearStoredData (client-authenticator.js:612)
    at Client.connect (client-authenticator.js:231)

from what i can see, is that this._clearStoredData(); is expecting a callback. This is on version 1.1

Ok; I've created a branch with a fix to this.  But investigating how well the layer.Client supports CHANGING User IDs is a separate task which I'll need to plan on for next week.
If you can, call client.destroy() and start a new client for the new user.
I expect this branch should be merged to master late next week after any other issues are reported.
Thanks for identifying this use case and error!
Michael

@michaelkantor thanks

Fixes to deleteTables() is now in 2.0 as well as 3.0.0-beta and are released.


open source / license?

hello, wondering if you are open sourcing this or putting a license on it?
thanks

Hi @jtkeyva!
This project is delivered under ISC, as stated on package.json. I have just also added a corresponding LICENCE file https://github.com/flbulgarelli/headbreaker/commit/3c96dc944e4efd53aeec960acb6efc77f387c160.


[CT-3425] Move common events only used in core to core

Note: We should probably refactor the test_events unit test as part of this work so that there is a separate test file for common, adapters, and core tests


Update data-lake-analytics-manage-use-powershell.md

Just correcting a few simple typos.

Hi @eloldag, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no contribution license agreement is required at this point. Real humans will now evaluate your PR.

TTYL, AZPRBOT;

@eloldag - Thanks for the updates. @edmacauley - please review and let @cjgronlund know if the changes can be merged.

Looks good, @eloldag, thank you for the fixes!  Ready to be merged by @cjgronlund  whenever.
#sign-off

That's why you should never log in at home. :)
Sorry about the confusion, thanks again @elodag for your help.  @cjgronlund  all good to go.
#sign-off


Add GraphQL Playground

https://github.com/graphcool/graphql-playground
https://www.graphqlbin.com/RVIn

I like the draggable vertical divider on launchpad, we could use that? Found it in inspector, and searched repo for "Resizer":
https://github.com/apollographql/launchpad/search?utf8=✓&q=Resizer&type=


Is there way to compile TFRT on windows?

Is there way to compile TFRT using windows toolsets? For example VS 2019 compiler?
I tried to run this from command prompt:
bazel build //tools:bef_executor
But it throws error that at least VS 2017 is required.
I have VS 2019 installed but seems like bazel doesn't recognize it.

First, please see the Bazel install instructions on Windows. Bazelisk is the recommended (and the easiest) way to make sure you have the right Bazel version.
Windows support is experimental. TFRT should build and pass most test cases, but not everything works yet. Here's a list of known issues

And yes, i checked those issues....
But noone reports it is not compilable on windows at all?
That;s why i'm asking, what i'm doing wrong.
There is no any instructions how to compile it on windows.
So is command: bazel build //tools:bef_executor suppose to work on windows after bazel installation?
Or should i do something additional?

Are you able to build any other C++ projects with Bazel, on the same machine? (try https://github.com/bazelbuild/examples/tree/main/cpp-tutorial or Abseil C++)

The only project where I used bazel - was WebRTC.
But …
First - WebRTC used special depot toolsets.
And second - it didn’t compile anything but just generated visual studio project. Compilation happened inside visual studio..
In TFRT it tries to compile the project and fails, because cannot find visual studio compiler. How to specify the path to visual studio for bazel?

Ok, just found how to tell bazel visual studio location
set BAZEL_VC=C:\Program Files (x86)\Microsoft Visual Studio\2017\BuildTools\VC
Will try tomorrow…

Once you can verify that you can build simple C++ apps with Bazel, the instructions for building on Windows are fairly straightforward:
Prerequisites

Install Bazelisk (or the right version of Bazel)
Install Visual Studio 2017+
Install LLVM 11.1+
(Optional) Use a Python virtual environment, ex. miniconda (conda create -n tfrt python=3.8)
pip install clang==11.0

Building & running tests

(Optional) Activate the right Python virtual environment
(Optional) Cleanup: bazel --noworkspace_rc clean --expunge
bazel build //tools:bef_executor
bazel build //tools:tfrt_translate
bazel test -c dbg //mlir_tests/bef_executor/...

Still not able to build.
Tried to set BASEL_VC=C:\Program Files (x86)\Microsoft Visual Studio\2019\BuildTools\VC
But seems like it is ignored by bazel.
ERROR: C:/users/andrey/_bazel_andrey/o2svxzdq/external/llvm-project/llvm/BUILD.bazel:170:11: Compiling llvm/lib/Support/TypeSize.cpp [for host] failed: (Exit 2): cl.exe failed: error executing command C:/Program Files (x86)/Microsoft Visual Studio 14.0/VC/bin/amd64/cl.exe /nologo /DCOMPILER_MSVC /DNOMINMAX /D_WIN32_WINNT=0x0601 /D_CRT_SECURE_NO_DEPRECATE /D_CRT_SECURE_NO_WARNINGS /bigobj /Zm500 ... (remaining 45 argument(s) skipped)
external/llvm-project/llvm/include\llvm/Support/Compiler.h(88): fatal error C1189: #error:  LLVM requires at least MSVC 2017.ERROR: C:/users/andrey/_bazel_andrey/o2svxzdq/external/llvm-project/llvm/BUILD.bazel:170:11: Compiling llvm/lib/Support/TypeSize.cpp [for host] failed: (Exit 2): cl.exe failed: error executing command C:/Program Files (x86)/Microsoft Visual Studio 14.0/VC/bin/amd64/cl.exe /nologo /DCOMPILER_MSVC /DNOMINMAX /D_WIN32_WINNT=0x0601 /D_CRT_SECURE_NO_DEPRECATE /D_CRT_SECURE_NO_WARNINGS /bigobj /Zm500 ... (remaining 45 argument(s) skipped)
external/llvm-project/llvm/include\llvm/Support/Compiler.h(88): fatal error C1189: #error:  LLVM requires at least MSVC 2017.
Not sure why bazel tries to use old visual studio.

Ok, finally was able to build bef_executor. An it took over 7000 secs. )

I'm glad to hear that you're able to work out the Bazel / MSVC setup problem. What was the solution?
Regarding build times, it's a known issue that optimized builds take a long time (it used to be even worse, see https://github.com/tensorflow/runtime/issues/65). During development, debug builds (-c dbg) are much faster.

Thanks a lot Leonard for helping out!
@Honya2000, it would be great if you could post here what you changed to make it work. Thanks!


Change signoff check image to slim-buster [skip ci]

Signed-off-by: Peixin Li<EMAIL_ADDRESS>fix signoff check

build

Going to force merge this to unblock signoff check

Please add description as to why we changed it

Please add description as to why we changed it

updated PR desc