DataTables Api Problem: Selecting a cell by node

Selection of a cell by node (api.cell(td)) does not work if the cell is not currently in the DOM (Ex: Cached Node).
row = el.parentNode._DT_RowIndex;

The selection does not work because the code above is trying to call its parentNode (which in this case is undefined).
Can the property _DT_RowIndex be stored with the el as well as with its parent, so as to avoid this scenario?
Test Case: http://live.datatables.net/gasebeta/1/edit
In this test case, the Name column was hidden and trying to select a cell under this column with the cached node.

Thanks for posting this. I've implemented a slightly different method. not as efficient for this particularly use case, but I think overall it requires less disruptive changes.

Thanks for the quick fix.

There's still another scenario where this fails.
If the hidden cached cell was appended to a different TR Element (ex: A child row), el.parentNode will not be undefined, but el.parentNode._DT_RowIndex will be undefined.
Adding an extra check for el.parentNode._DT_RowIndex will do the trick.

A "hidden cached cell"? Do you mean the td cell itself? You are moving that to a different location in the DOM?

Yes the td cell itself. And yes it is being moved to a different location
.

Test Case: http://live.datatables.net/musigeci/2/edit
In this test case, the cached td cell (the column is hidden) was used in the child row.
To see the result in the console, Click a row and change the value of the text.

Thanks for the test case. That's not an expected interaction - DataTables may or may not correctly reinsert the element into the row at a later time.
It won't just be this part that is broken with this interaction - there will be several other changes required.
I need to decide if this is something I want to support in DataTables. My initial thought is no, it might be a performance hit and add additional code. But I'll have a think about it and what would be involved.

I'm having a similar problem regarding cell selection by node.
This can easily be fixed without any major changes by storing the cell index (Both column & row index) in a private property with the cell node (td). Just like it is being done with _DT_RowIndex on the row node.
There are mainly 3 function which will have to be amended:

_fnCreateTr - First, where the indexes will have to be registered on the cell
row().remove() or rows().remove() - Whenever a row is deleted, update the row part of the cell index.
__cell_selector - Use the cell index, in the cell node's private property, to retrieve the cell by node.

Apart from fixing this issue, this will also benefit from a quick retrieval of the cell. (No need to traverse the array to find the row index. Referring to  https://github.com/DataTables/DataTables/commit/648726b19e3e846f5b4779ea25f883cf180ed779)

Thanks. Could you link to a test page showing the issue and I'll take a look when I get back from my current travels next week.

Thanks for replying.
What I'm trying to achieve is similar to jamezamm's test case: http://live.datatables.net/musigeci/2/edit
(You can use the same test case)
i.e.: Selecting a cell by node which is now appended to a child row (Not in original row)
If you solve the problem the way I described in the comment above, will kill two birds with one stone.

This is what I changed in the script:
_fnCreateTr Line starting at 1750
function _fnCreateTr ( oSettings, iRow, nTrIn, anTds )
{
    // ...
    nTd = nTrIn ? anTds[i] : document.createElement(oCol.sCellType);
    nTd._DT_CellIndex = { row: iRow, column: i }
    // ...
}

rows().remove(), row().remove() Line starting at 7884
_api_registerPlural( 'rows().remove()', 'row().remove()', function () {
    // ...
    // Update the _DT_RowIndex parameter on all rows in the table
    for ( var i=0, ien=data.length ; i<ien ; i++ ) {
        if (data[i].nTr !== null ) {
            data[i].nTr._DT_RowIndex = i;
        }

        if (!data[i].anCells) continue;

        for (var j = 0, jen = data[i].anCells.length; j < jen; j++) {
            if (data[i].anCells[j]) {
                if (data[i].anCells[j]._DT_CellIndex) {
                    data[i].anCells[j]._DT_CellIndex.row = i;
                }
            }
        }
    }
    // ...
} );

__cell_selector Line starting at 8551
var __cell_selector = function ( settings, selector, opts )
{
    // ...
    // Selector - jQuery filtered cells
    return allCells
        .filter( s )
        .map(function (i, el) {
            return {
                row: el._DT_CellIndex.row,
                column: el._DT_CellIndex.column
            };
         })
        .toArray();
    // ...
}

This solves:

Selecting a cell by node that does not exist in DOM (Ex; Column is hidden)
Selecting a cell by node that is appended to another tr element (Ex: Appended to child row)

You should double check this solution, as I might not be seeing the whole picture.

Thanks for the reply and extra details. As I noted above I'm not yet sure that I want to support the ability to move cells around the DOM in DataTables - I think it will add a number of additional check that need to be made (such as in the draw function - does the cell need to be drawn in or not - or more generally, under what conditions should be be reinserted into the master table - perhaps there should be a new API method). At the moment I don't think I wish to support this interaction as I think it adds a lot of scope of potential issues - however, it is something I will keep in mind for future development as I can of course see that it could be useful.

Thanks for replying.

I'm not yet sure that I want to support the ability to move cells around the DOM in DataTables - I think it will add a number of additional check that need to be made (such as in the draw function - does the cell need to be drawn in or not - or more generally, under what conditions should be be reinserted into the master table - perhaps there should be a new API method).

I think you're over complicating things, I'm not asking for functionality to move the cell around or to be automatically inserted back, but just so that the cell selection still work even though the cell has been moved.
Still _DT_RowIndex is saved with the row node for fast lookup, why not do the same for the cell node for fast lookup as well (as this will solve the above problem)?

Actually, I think I've over simplified the issue in my above comments. Consider for example if the table were destroyed, who is responsible for cleaning up the event handlers and removing the cell if it has been moved outside of the DataTable.
The more I think about this, the more I am convinced that supporting the ability to have cells moved out of the table by external processes is not something I wish to support in DataTables.

I'm not sure we are on the same wave length. Moving the cell around together with its associated problems is my concern and I'm not asking you to cater for it.
Storing the index with the cell node will not create any side effects to datatables. This way will not only solve my problem but you will also benefit from an increased performance i.e. Cell fast lookup.
I hope I'm making myself clear enough in view of this fix being committed.

The selector performance is already quite fast at this point because the cell is a child node of the row. I haven't encountered any issues with this as of yet, so I'm reluctant to introduce additional code for something that I don't currently perceive to be an issue. I reserve the right to be wrong and change my mind in future though :-).

Yes it is fast, if the cell is not hidden i.e. when parentNode is null.
Quoting your comment, in view of fix https://github.com/DataTables/DataTables/commit/648726b19e3e846f5b4779ea25f883cf180ed779 :

I've implemented a slightly different method. not as efficient for this particularly use case

But you already know that storing the index with the cell node will be more efficient. :-)

@strang91 has a point. Imagine a possible worst case scenario where there are 10,000 rows, 10 columns and calling api.cell(td) on a hidden cell in a 3x loop.
The code shown below will loop through ((10,000 rows * 10 cols) for 3 times). This definitely has a major performance issue.
Storing the cell index on the cell node is definitely an easy and efficient way of selecting a cell and the greatest part is that it requires small changes with no repercussions on the datatables itself.
Plus I can confirm that @strang91's change works. Test Case: http://live.datatables.net/gasebeta/6/edit
if ( el.parentNode ) {
    row = el.parentNode._DT_RowIndex;
}
else {
    // If no parent node, then the cell is hidden and we'll need
    // to traverse the array to find it
    for ( i=0, ien=data.length ; i<ien ; i++ ) {
        if ( $.inArray( el, data[i].anCells ) !== -1 ) {
            row = i;
            break;
        }
    }
}

Yup all good points. I'll consider it for a future revision.


Bump Version of @magic-sdk/connect to 6.2.0

📦 Pull Request
Bump Version of @magic-sdk/connect to 6.2.0
✅ Fixed Issues
n/a
🚨 Test instructions
n/a
⚠ Don't forget to add a semver label!

patch: Bug Fix?
minor: New Feature?
major: Breaking Change?
skip-release: It's unnecessary to publish this change.

:rocket: PR was released in<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>:rocket:


Azure Container Apps session execute new api-version

This checklist is used to make sure that common guidelines for a pull request are followed.
Related command

az containerapp session code-interpreter
General Guidelines

[x] Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
[x] Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
[x] My extension version conforms to the Extension version schema

For new extensions:

[ ] My extension description/summary conforms to the Extension Summary Guidelines.

About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Thank you for your contribution! We will review the pull request and get back to you soon.

Hi @yonzhan @zhoxing-ms
This PR has been reviewed and approved inner our team, can you help to review it when you have chance? Thanks!

/azp run

/azp run


there are white spaces in file/directory names

Because these files are to be used across different operating systems the use of white spaces in file and directory names is a recipe for trouble. Please use hyphens or underscores if you want to separate words. Also, the use of periods for anything other than to separate file extensions is sub-optimal as this can cause issues for some parsers trying to extract file types.

I reverted the renames

Thanks @am-bean, sorry, I should have mentioned this earlier. The notebooks are looking good!


update get-aduser.md

issue #1047 ,
issue related to github formatting syntax:
"Note: PowerShell wildcards other than *, such as ?, are not supported by the Filter syntax."
the first * symbol has to be ignored, so I added \ to ignore markdown
source: Basic writing and formatting syntax

@dariomws306 @get-itips
Peer review needed for this PR. Thanks.

I am good.

Ok!

@AndreaBarr This PR can be merged. Thank you.


Initially validate on blur or delay, subsequently validate on keypress and blur without delay

I'd like two have separate rules for initial validation vs subsequent validations.
For example, the experience I'm trying to create is as follows:

There is a pristine email field.
The user begins typing their email. No instant validation.
Once the user blurs the field or stops typing for a set amount of time, the field validates and the error is shown to the user. From this point forward, validation occurs on keyup|blur without any delay.
The user returns to the field, and fixes their error, getting instant feedback when the error is corrected.

Is there an existing way to accomplish this?

Currently there is not sadly, but It could be accomplished if PR #616 is finished since it could allow greater flexibility and dynamic field options, so you would apply dynamic delay time depending on your app logic, still there is a long way to go before it is merged since it changes most of the internals.

Bummer!
In the current version would it be feasible to do something like
//listeners.js
...
this.component.$watch('data-vv-delay', this.updateListeners);
...

Any way I can help with #616?

No it wouldn't work, as $watch only works for Reactive data, that is either data or computed attributes along with any custom reactive data which are defined on the instance. The HTML attributes are not watchable unfortunately.
#616 should make patching field options easier, since currently the fields are only constructed statically at the bind cycle and re-evaluated at the insert cycle, only after then the scope is evaluated multiple times in update cycle.
The new proposed behavior would identify fields by their uniqueID meaning changing scope won't break the field existing validation behavior. which should make evaluating the entire field options at the update cycle more straightforward so different delays can be detected in theory.

@logaretm since #616 is merged, do you have an example on how to accomplish this?

@jenslind It is possible to implement at the moment but not yet available. I still cannot give an ETA on this since some issues had higher priority.

I think having no delay on blur or maybe separately configurable would already be a big step forward since the main motivation for the delay is to not bother the user with error messages while typing but blur basically marks the end of input and as such validations can run immediately without disturbing the user. it's probably less disturbing since he might already be entering a value in the next field when the error for the first one appears.

@logaretm any update on this one?

@Chinese1904 Haven't got the time to work on this yet, looking to introduce some changes before I can work on this, PRs are welcome though.


Mouse double click preventer

Description of the new feature / enhancement
Use a software preventer to ignore the double click interval which is below 0.08 second or user adjusting. Something like ClickFix https://github.com/CemraJC/clickfix
Scenario when this would be used?
When you have a switch-broken computer mouse.
Supporting information
No response

/dup https://github.com/microsoft/PowerToys/issues/26213


macOS: "“Kindle Comic Converter.app” is damaged and can’t be opened. You should move it to the Trash."

I'm getting this warning when I open the app:

“Kindle Comic Converter.app” is damaged and can’t be opened. You should move it to the Trash.

I tried multiple times, with both KindleComicConverter_osx_5.6.2.dmg and KindleComicConverter_osx_5.6.1.dmg. I'm able to open the dmg file just fine and to copy the application to the Applications folder. The warning occurs once I try to open the app.
Config:

I'm on a MacBook Pro from 2021, meaning it uses a M1 Pro processor. Is it supported?
Running macOS Ventura 13.3.1

Please let me know if you need more details or if I can do something to help.

Never mind, I hadn't see the README: https://github.com/ciromattia/kcc/wiki/Installation#macos-installation
So to fix the application file I did:
xattr -d com.apple.quarantine /Applications/Kindle\ Comic\ Converter.app
xattr -d com.apple.quarantine -- /Applications/Kindle\ Comic\ Converter.app/Contents/Resources/7z

And to fix the KindleGen missing warning I did:
brew install --cask kindle-previewer
sudo cp "/Applications/Kindle Previewer 3.app/Contents/lib/fc/bin/kindlegen" /usr/local/bin/

Working fine!


⚠ Bofrost.si has degraded performance

In bab26e0, Bofrost.si (https://www.bofrost.si) experienced degraded performance:

HTTP code: 200
Response time: 2215 ms

Resolved: Bofrost.si performance has improved in a09b01a.


The Great Parsing

From finding out how to extract contents from .vpk files in #26 we now have over 60k VDF files to test parsing with just from the contents of a few Valve games
The full corpus is much too large and probably a nono to include in here, but I'll hack together a program that tries to parse each file and dump any ones that fail to a separate location. Once I get that running I'll post any failures here

Exactly two files (the same exact same contents) use some weird platform tag identifier thing like so
"Foo"
{
    "Bar" [$WIN32]
    {
    }
}

Handling this would probably be a pain especially since I have no clue what possible values there are and I also don't know how all it can be applied (I'm assuming the above would make "Bar" and its value considered Windows 32-bit exclusive, can it also be applied to a value that is a string? Where else could it be used?

It seems common to still use \ as a path separator instead of escaping a character. I suppose the easiest way to handle this would be to have escape characters to not be parsed by default and add an option to parse them since they seem incredibly rare

It seems somewhat common to include a null byte at the end of the file. Not sure if this is packed file specific and just isn't handled right or if this is present normally (Hopefully it's just the former for consistency)

Some files failed to read because they're not UTF-8 encoded. Need to dig into the different encodings used. It may be reasonable to expect users to handle encoding and convert it to UTF-8 for us

It looks like the platform specific tags may be more common and do seem to indicate the platform that a value is used for. Here's a snippet from another file
"xpos"	"r223" [$WIN32]
"xpos"	"r223" [$X360HIDEF]
"xpos"	"r220" [$X360LODEF]

This also shows that it can be used on values that are strings as well. The full set of tags that I've seen so far are WIN32, WIN32WIDE, X360, X360HIDEF, X360LODEF, X360WIDE, DEMO, ENGLISH, JAPANESE, KOREAN, etc. and beyond that there looks to be some conditional logic that can be used as well like [$WIN32 && $ENGLISH] or [$WIN32 && !$ENGLISH]
The parsing position is a bit awkward as well since it can appear at the end of a pair for Key-String, but between the two tokens for Key-Obj. With how many different possible values there are it doesn't seem worth trying to parse specifics, we could just return the string for what's inside
Of the 16,353 failures this is included in 345

The number of files that used #base are 292 of the 16,353 failures.
Of those files it appears that #base always appears on the top value. I'll have to dig in more to see if #base was ever used with a file that also has a #base

Finally the number of files that use \ when not trying to represent an escaped character are 15,079 which makes it a very prevalent issue.


[HUDI-8434] Support Flink Async Archive

Change Logs
archive operation is now executed in Flink JM in sync mode,  which blocks starting a new Instant in heavy work load.
thus, write performance is affected.
this PR enables async archive in Flink operator.
Impact
hudi-flink-datasource
Risk level (write none, low medium or high below)
none
Documentation Update
none
Contributor's checklist

[ ] Read through contributor's guide
[ ] Change Logs and Impact were stated clearly
[ ] Adequate tests were added if applicable
[ ] CI passed

Did you check this fix: https://github.com/apache/hudi/pull/9854/files

Did you check this fix: https://github.com/apache/hudi/pull/9854/files

Thanks for reminding. I'll close this.


MudDataGrid: Fix  for #6024

Description

Fixes #6024 ;

Changed Inner TemplateColumn of the HierarchyColumn to be not editable, setting IsEditable="false", because the rendering process was trying to render column's EditTemplate, and it's null (and should continue to be). By this change, MudDataGrid rendering process will look just for the CellTemplate, and will render column's MudIconButton (arrows);

Updated DataGridDetailRowExample.razor to test the behavior.

How Has This Been Tested?

Visually tests only, since it's relative simple.
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

[x] The PR is submitted to the correct branch (dev).
[x] My code follows the code style of this project.
[x] I've added relevant tests.

Looks good @tjscience, you concur?

Yes, looks good.

Thank you Henrique!


⚠ Bofrost.lu has degraded performance

In 865feaf, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1385 ms

Resolved: Bofrost.lu performance has improved in 3804ab7 after 10 minutes.


add new user bug

unable to add new user in User Maintenance.   Dump of stack trace shows index out of range.

problem with PreparedStatement during insert of user_mstr record.  This has been resolved and 6.0.0 files have been refreshed.


CLAS: Source code has different methods order in the IMPLEMENTATION part

Class serialization results in different methods order in the implementation part after system upgraded to S/4HANA 2020. This results in diffs even though the code remains the same. It is observed that the CLASS DEFINITION part remains same just IMPLEMENTATION part changes the methods order( method code remains same ).
Below is a sample code snippet where the first method is different in the IMPLEMENTATION.

I have tried with abapGit version 1.104.0 and latest version. The result is same. This is the code which is called to return the source code.

Anyone had the issue?

AG serializes the source the way it's visible in SE80/ADT. The order can be alphabetically but must not be. If a SAP process regenerates the class includes, then it system will order the methods alphabetically.
It looks like that happened in your system - probably as part of the upgrade. I think someone else mentioned this here before.

Thank you for the details. I have verified the class and methods are in alphabetical order. Is there a way to prevent this during regeneration? At least, it would help others.

Closing this based on #3741

Not that I know off. You can pull again from the AG repo and it should restore the order.


release 1.6.0

@mcanevet could you merge this and tag a new release please?

@mcanevet thanks for the quick merge, can you please also create the git tag?

@bastelfreak done!


Add option hideNegatable to ArgParser.flag()

Recreating https://github.com/dart-lang/args/pull/287

[x] I’ve reviewed the contributor guide and applied the relevant portions to this PR.

Contribution guidelines:

See our contributor guide for general expectations for PRs.
Larger or significant changes should be discussed in an issue before creating a PR.
Contributions to our repos should follow the Dart style guide and use dart format.
Most changes should add an entry to the changelog and may need to rev the pubspec package version.
Changes to packages require corresponding tests.

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

Thanks for moving this!

Thanks for moving this!

Well I also closed the original ;)


Fix for HADOOP-12169

Added a fix for a hadoop issue (https://issues.apache.org/jira/browse/HADOOP-12169) which affects the s3a filesystem and results in duplicate files appearing in the results of ListStatus.  In the process, extracted a base class for all FsHelper classes based on the hadoop filesystem.

LGTM.


Evaluation Mechanism

Hello @tzamalisp! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file crossai/performance/__init__.py:

Line 1:1: W391 blank line at end of file


Update application-groups.md

Being following the documentation from top to bottom, it is easy to be confused and think that to deploy an application configuration based on groups is the same as deploying a simple application. So better to clarify that now we are using the /v2/groups endpoint instead of the /v2/apps.

Thanks a lot, @GabrielNicolasAvellaneda
Merging this PR.

@ichernetsky you are welcome! :+1:


New high-level flow for data migration demo

This change makes substantial changes throughout the data migration demo to create new API surface, tools, and patterns to demonstrate how a customer might migrate data between containers.  There's still more to do/consider/revise, but I think it's at an interesting point to checkpoint on and get some feedback.
Of particular interest:

Introduces a new "container model" concept, which is an app-developer-written API surface that wraps an IContainer and pairs with the container code they have written to go inside.  This serves similar purpose to the "root data object" concept but is a runtime-concept only and is applied from outside of the container code.

This could potentially ship inside the container code (i.e. instantiated via a special request() pattern), but for now I think it works better outside.
This also doesn't have to be migration-specific -- I think it may be preferable to a root component more generally.

Introduces a new ModelLoader which wraps an IHostLoader to allow the app developer to work directly with these container models rather than IContainers
Demonstrates 3-facet version matching (container code, container model code, and view must all support one another)
Adds a Migrator tool which coordinates the migration from model to model
Parameterizes most elements of the flow, and introduces interfaces to describe the interactions between custom developer code vs. the shared infrastructure.
Migration now happens in-place for all connected clients.

I also realize this is a somewhat large PR - lmk if you'd like me to walk you through it and I can set up some time.

I also realize this is a somewhat large PR - lmk if you'd like me to walk you through it and I can set up some time.

Yes - short session would be helpful. Maybe a clarity on direction, correctness, prod-case scenario support (we are using task manager, aqueduct etc). And how the rest of the work ties in (ex. Scott is working on Task Manager improvements)

Here are few top-level notes & questions. Beware, some may be coming from naïve, oversimplified assumptions 😊 It’s obvious you have given quite a bit of thought to this problem, it’s awesome to see the progress!

It would be nice to call out (or point to) specific requirements and underlining use-cases driving the “need”. From what I understood, the “need” is for one-directional upgrades where user wants to (a) leverage new FF capabilities it cannot acquire otherwise, (b) get off from unsupported features/DDSes, (c) arbitrary document schema (model) updates.
Have you considered any other approaches? My first naive take here was, why not take existing concept, like FluidContainers and expose upgrades through them. They could take new schema, upgrade config/plugins, and derive “upgraded” containers back. I did not give much thought to this, just thinking about some examples out loud here.
Given you are introducing some new concepts, diagram would be helpful. It may help user reason about (a) division of responsibilities, (b) correlating to the concepts they are familiar with, (c) understand runtime behavior and (d) versioning implications. I was not immediately clear how versioning of loader, code loader and view play out together, and what constraints we have there.
What constraints do you have due to summarizer? Clients can turn read-only, but I’m not sure you can control summarizer actions. And I’m assuming the summarizer needs to go through upgrade as well.
What constraints you have on underlining DDSes you are using for synchronization? I know some of the DDSes you are using are still work in progress, but it sounds like you are pretty sure we can offer full correctness on “many can try, at least one client will complete the upgrade”

I have few more questions, but your answers to (1), (2) and (3) may clarify them.
Nice work here! I liked the idea of wrapping the containers in friendlier interfaces. Finally, models could just be the data that user can bind and consume, without much boilerplate.

Thank you for reviewing!

It would be nice to call out (or point to) specific requirements and underlining use-cases driving the “need”. From what I understood, the “need” is for one-directional upgrades where user wants to (a) leverage new FF capabilities it cannot acquire otherwise, (b) get off from unsupported features/DDSes, (c) arbitrary document schema (model) updates.

Are you thinking primarily in terms of the documentation/markdown?  I'll do this -- the README.md is in need of an update.

Have you considered any other approaches? My first naive take here was, why not take existing concept, like FluidContainers and expose upgrades through them. They could take new schema, upgrade config/plugins, and derive “upgraded” containers back. I did not give much thought to this, just thinking about some examples out loud here.

I think that we will definitely need to expose this through the FluidContainer API surface as well, but I wanted to first (a) prove we had the right low-level building blocks and (b) build confidence in the pattern before modifying public API surface with back-compat concerns like FluidContainer.  There are strong parallels between the Model and FluidContainer concepts though, so I think it should be a pretty straightforward translation of the pattern.  Also, I think it's important for the pattern to work for all Fluid customers (even those not using FluidContainer).

Given you are introducing some new concepts, diagram would be helpful. It may help user reason about (a) division of responsibilities, (b) correlating to the concepts they are familiar with, (c) understand runtime behavior and (d) versioning implications. I was not immediately clear how versioning of mode loader, code loader and view, play together, and what constraints I have as developer.

Agree - I'll work on building some visuals to help explain.

What constraints do you have due to summarizer? Clients can turn read-only, but I’m not sure if we can control summarizer actions. And I’m assuming the summarizer needs to go through upgrade as well.

The summarizer is generally not a problem.  In the current state, the summarizer participates the same as any other client (my most recent commits enforce that the summarizer will load the quorum and send "accept" ops just like other clients).  Since the summarizer does not make material data changes, it's not a major concern for it to be in the room while the migration happens (and it should be closed along with the old container after the migration completes).

What constraints do you have on underlining DDSes you are using for synchronization? I know some of the DDSes you are using are still work in progress, but it sounds like you are pretty sure we can offer full correctness on “many can try, at least one client will complete the upgrade”?

Yes, I feel pretty good that we can guarantee at least one successful migration.  Even if all connected clients blow up during migration, the current demo supports a new client joining later and doing the migration.  That said there are two main weak points I would like to harden:

The clients are racing to create the migrated container, which will result in extra, useless containers being attached and then forgotten.  The TaskManager will help minimize the frequency of this, but it will still be a possibility.  This is wassted storage so ideally we have a way to clean these up or otherwise ensure they don't exist, but I don't think this is necessarily a blocker.

One possible approach might be to get service assistance in deduping.  For instance, if racing clients can include some nonce-like-thing on the createNewRequest during attach such that losing racers get rejected.

Clients should stop editing the old container after the proposal is accepted, but nothing actually prevents editing.  That late data may or may not make it into the migrated container -- in the current demo I just block edits in the UI but not at the runtime layer.  And since I'm using the primary container instance, even local (un-acked) changes could get included in the migration which is definitely not desired.

The approach I think I want to take for this is similar to the summarizing client - that we include a sequence number in the migration proposal and spawn a new container that loads and migrates at exactly that sequence number.  This would make the data in the migration result deterministic regardless of UI or local changes.


show replier (potential provider) rep and make that username clickable

in request with replies:

[x]  set provider rep for the provider (replier)
[ ] make replier username (provider) clickable to go to user's rep page

First part fixed in 3634fd9c5b393649064666b0e6fe8f563413c619

Second part fixed in 2f0679b4339e948d770197c257b160f3454f59c5


let user optionally choose provisioning host

For shared labs, users do not control how nodes are handed out in a reservation.  This can lead to some serious problems:

storage devices are not always the same among the nodes being allocated - for Ceph, this means lowest-common-denominator behavior
some nodes are in the same rack, others aren't
others TBS?

The provisioning host at present is always the first host in the ocpnodeinv_cloudXX.json supplied by labs, and this may not be the best choice.   While this is a reasonable default, it would be great if we had a way to override.
Detailed example: For example, in the case of cloud17 on Oct 5 2020, I find that the first 3 nodes in the .json have 5.8-TB /dev/nvme0n1 and are all in the same rack, that's great! but the 4th node (on a different rack) has 1.8 TB.   But JetSki always picks the first node, so I waste the 5.8-TB device and have to change my Ceph configuration so that all remaining 3 hosts uses 1.8 TB not 5.8, or else Ceph won't balance the load.
For example, define a var in the inventory/jetski/hosts file, something like:
provisioner_host: mgmt-e26-h13-740xd.alias.bos.scalelab.redhat.com

For now, I've implemented a patch that lets me reorder the nodes in the local ocpinv.json file to select the provisioner host:
diff --git a/ansible-ipi-install/roles/bootstrap/tasks/10_load_inv.yml b/ansible-ipi-install/roles/bootstrap/tasks/10_load_inv.yml
index b5e3d14..d90da4e 100644
--- a/ansible-ipi-install/roles/bootstrap/tasks/10_load_inv.yml
+++ b/ansible-ipi-install/roles/bootstrap/tasks/10_load_inv.yml
@@ -25,7 +25,7 @@

     - set_fact:
         ocpinv_content: "{{ response.json }}"
-  when: lab_name == "alias"
+  when: lab_name == "alias" and not st.stat.exists

 - name: Download ocpinv.json
   block:
@@ -36,7 +36,13 @@

     - set_fact:
         ocpinv_content: "{{ response.json }}"
-  when: lab_name == "scale"
+  when: lab_name == "scale" and not st.stat.exists
+
+- name: read local ocpinv json
+  block:
+    - set_fact:
+        ocpinv_content: "{{ lookup('file', ocpinv_file) }}"
+  when: st.stat.exists

 - name: Checking for inventory conflicts
   block

@bengland2 Thanks for bringing this up. My design philosophy was making it stupic simple and exposing the least number of variables to the user.
Have you checked this out https://github.com/redhat-performance/JetSki#changing-node-rolesexcluding-nodes-in-your-allocation-from-the-deployment ?


accept default sorting parameter (asc) on SORTBY on redisearch

considering the following query:
ft.aggregate index "*" SORTBY 2 @id ASC is equal to:
ft.aggregate index "*" SORTBY 1 @id
c.B().FtAggregate().Index("index").Query("*").Sortby(1).Property("@id")
should be possible to use, however rueidis is only allowing this:
c.B().FtAggregate().Index("index").Query("*").Sortby(2).Property("@id").Asc()
I'd create a PR as well, but couldn't figure out the proper JSON format for the codegen, sorry about that
thanks!

Hi @hah, thank you for reporting this. This will be fixed in the next release.


Added redirect on error page if user id not present

As users keep getting stuck on  the error page in PWA and apps

prettier failed


user namespace error when trying test_env.py

Hi! I'm trying to reproduce your work with a Docker environment.
I'm sure that I set the workspace and configurations correctly.
But when I try the command below,
./singularity_run.sh ./local_buffer/nav_benchmark.sif python3 test_env.py

I get the following error:
INFO:    Converting SIF file to temporary sandbox...
FATAL:   while handling ./local_buffer/nav_benchmark.sif: while extracting image: root filesystem extraction failed: extract command failed: ERROR  : Failed to create user namespace: user namespace requires to set /proc/sys/kernel/unprivileged_userns_clone to 1
: exit status 1

How can I fix this FATAL error?
Thank you for your attention!

It seems to be an issue with Docker. When I tried the same process locally, there was no problem. I think running a Singularity container inside a Docker container is causing the issue. I'll close this issue.


Add note to clarify range vector selector

So that the user's don't have confusion when following the documentation.

Thanks for the PR, documentation on the expression browser does not belong in this page. I'd suggest changing the expression browser's page instead.

Closing for lack of followup.


Add convenience function for reducing from 0: sum

After using underscore for a while, I'm finding our most common use case for reduce is just adding from 0. It'd be nice to have a shortcut function in underscore that we could just pass a list of numbers or objects.
This sum is one way to do that, and it comes with tests and updated docs!

Suggested changes have all been added, thanks @jdalton and @davidchambers! Certainly open to any other feedback you may have.

What do we think of sum and it's possibility for inclusion? Any more feedback?

Honestly, I don't think it's that useful. If I wanted to fold + over a list starting at 0, I'd just do that. Having a library function for it wouldn't be some huge boon. Though I guess it is a common enough operation that we don't want to repeatedly specify, so I'm -0.

for loops are nice too...

I agree the complexity of doing a fold :+ 0 is not that great, but the intention is not as clear as a sum.

Fair enough -- the worst case scenario is I can just keep mixing it into my projects.
When it comes to contributing to open source, this was my first effort. I figured adding tests and updating the docs would be useful, but what about regenerating the minified version? Is that helpful or just noise?


@workspace does not work properly.

I asked a Copilot @workspace to tell me which is the main file for rendering the view, and it pointed at App.tsx, which did not exist.
I have noticed that the @workspace command is a piece of junk, or maybe I did something wrong.

Please provide your extension version and steps to reproduce the issue


Updated PerfInsights Linux documentation to describe new features

A new version of PerfInsights Linux has been deployed. Updated sections to indicate that Python 3.x is supported, SAR files are collected, recommendation is generated to install sysstat.

@Pooja-Harjani : Thanks for your contribution! The author(s) have been notified to review your proposed change.


seq_lens variable used in the attention kernel

trying to understand the seq_lens variable used in the attention kernel.
https://github.com/vllm-project/vllm/blob/main/tests/kernels/test_flash_attn.py#L75
why
@pytest.mark.parametrize("kv_lens", [[1328, 18, 463], [1, 54, 293, 70]]) is used here? I expect them to sum to multiples of 1024 or the amount of the cache size to be used here as offsets given starting positions of the k-cache and v-cache
https://github.com/vllm-project/vllm/blob/main/tests/kernels/test_flash_attn.py#L131

You'll probably get better response asking on the vllm repo


Jenkins error: No profile for team 'DC388N2' matching 'match AppStore com.dev.ToDo<PHONE_NUMBER>' found

✅ fastlane environment ✅
Stack

Key
Value

OS
10.15.3

Ruby
2.6.3

Bundler?
false

Git
git version 2.22.0

Installation Source
/usr/local/bin/fastlane

Host
Mac OS X 10.15.3 (19D76)

Ruby Lib Dir
/System/Library/Frameworks/Ruby.framework/Versions/2.6/usr/lib

OpenSSL Version
LibreSSL 2.8.3

Is contained
false

Is homebrew
false

Is installed via Fabric.app
false

Xcode Path
/Applications/Xcode-beta.app/Contents/Developer/

Xcode Version
11.4

System Locale

Variable
Value

LANG
en_US.UTF-8
✅

LC_ALL

LANGUAGE

fastlane files:
`./fastlane/Fastfile`
# This file contains the fastlane.tools configuration
# You can find the documentation at https://docs.fastlane.tools
#
# For a list of all available actions, check out
#
#     https://docs.fastlane.tools/actions
#
# For a list of all available plugins, check out
#
#     https://docs.fastlane.tools/plugins/available-plugins
#
# POC222

# Uncomment the line if you want fastlane to automatically update itself
# update_fastlane

default_platform(:ios)

platform :ios do
  desc "Description of what the lane does"
  lane :custom_lane do
  	#sync_code_signing(type: "appstore", app_identifier: "com.dev.MSM", git_url<EMAIL_ADDRESS>username<EMAIL_ADDRESS>
  	match(
      type: "appstore",
      app_identifier: "com.xxxx",
      git_url<EMAIL_ADDRESS>      username<EMAIL_ADDRESS>    #get_certificates           # invokes cert
    #get_provisioning_profile   # invokes sigh
  	build_app(
      scheme: "xxx",
      silent: true,
      clean: true,
      export_method: "app-store",
      export_xcargs: "-allowProvisioningUpdates")

  	#upload_to_testflight
  	#upload_to_testflight(
	  #username: "xxxx",
	  #app_identifier: "xxx",
	  #apple_id: "xxxx",
	  #dev_portal_team_id: "xxxx"
	  #itc_provider: "xxxx" # pass a specific value to the iTMSTransporter -itc_provider option
	#)
    # add actions here: https://docs.fastlane.tools/actions
  end
end

`./fastlane/Appfile`
# app_identifier("[[APP_IDENTIFIER]]") # The bundle identifier of your app
# apple_id("[[APPLE_ID]]") # Your Apple email address

# For more information about the Appfile, see:
#     https://docs.fastlane.tools/advanced/#appfile

fastlane gems

Gem
Version
Update-Status

fastlane
2.144.0
✅ Up-To-Date

Loaded fastlane plugins:
No plugins Loaded
Loaded gems

Gem
Version

did_you_mean
1.3.0

slack-notifier
2.3.2

atomos
0.1.3

claide
1.0.3

colored2
3.1.2

nanaimo
0.2.6

xcodeproj
1.15.0

rouge
2.0.7

xcpretty
0.3.0

terminal-notifier
2.0.0

unicode-display_width
1.7.0

terminal-table
1.8.0

plist
3.5.0

public_suffix
2.0.5

addressable
2.7.0

multipart-post
2.0.0

word_wrap
1.0.0

tty-screen
0.7.1

tty-cursor
0.7.1

tty-spinner
0.9.3

babosa
1.0.3

colored
1.2

highline
1.7.10

commander-fastlane
4.4.6

faraday
0.17.3

unf_ext
<IP_ADDRESS>

unf
0.1.4

domain_name
0.5.20190701

http-cookie
1.0.3

faraday-cookie_jar
0.0.6

faraday_middleware
0.13.1

fastimage
2.1.7

gh_inspector
1.1.3

mini_magick
4.10.1

multi_xml
0.6.0

rubyzip
1.3.0

security
0.1.3

xcpretty-travis-formatter
1.0.0

dotenv
2.7.5

bundler
1.17.2

naturally
2.2.0

simctl
1.6.8

jwt
2.1.0

uber
0.1.0

declarative
0.0.10

declarative-option
0.1.0

representable
3.0.4

retriable
3.1.2

mini_mime
1.0.2

multi_json
1.14.1

signet
0.13.0

memoist
0.16.2

os
1.0.1

googleauth
0.11.0

httpclient
2.8.3

google-api-client
0.36.4

google-cloud-env
1.3.1

google-cloud-errors
1.0.0

google-cloud-core
1.5.0

digest-crc
0.5.1

google-cloud-storage
1.25.1

emoji_regex
1.0.1

jmespath
1.4.0

aws-partitions
1.286.0

aws-eventstream
1.0.3

aws-sigv4
1.1.1

aws-sdk-core
3.92.0

aws-sdk-kms
1.30.0

aws-sdk-s3
1.61.1

CFPropertyList
3.0.2

excon
0.73.0

json
2.3.0

forwardable
1.2.0

logger
1.3.0

stringio
0.0.2

ipaddr
1.2.2

openssl
2.1.2

ostruct
0.1.0

strscan
1.0.0

date
2.0.0

fileutils
1.1.0

etc
1.0.1

io-console
0.4.7

zlib
1.0.0

libxml-ruby
3.1.0

rexml
3.1.9

psych
3.1.0

mutex_m
0.1.0

webrick
1.4.2

generated on: 2020-03-24

/System/Library/Frameworks/Ruby.framework/Versions/2.6/usr/lib/ruby/2.6.0/universal-darwin19/rbconfig.rb:229: warning: Insecure world writable dir /Users/xxx/Documents/workspace/iOS2.POC in PATH, mode 040777
[✔] 🚀
[14:16:52]: fastlane detected a Gemfile in the current directory
[14:16:52]: However, it seems like you didn't use bundle exec
[14:16:52]: To launch fastlane faster, please use
[14:16:52]:
[14:16:52]: $ bundle exec fastlane custom_lane
[14:16:52]:
[14:16:52]: Get started using a Gemfile for fastlane https://docs.fastlane.tools/getting-started/ios/setup/#use-a-gemfile
[14:16:54]: ------------------------------
[14:16:54]: --- Step: default_platform ---
[14:16:54]: ------------------------------
[14:16:54]: Driving the lane 'ios custom_lane' 🚀
[14:16:54]: -------------------
[14:16:54]: --- Step: match ---
[14:16:54]: -------------------
+----------------------------+-------------------------------------------------------------------------+
|                                      Summary for match 2.144.0                                       |
+----------------------------+-------------------------------------------------------------------------+
| type                       | appstore                                                                |
| app_identifier             | ["com.xxx.xxx"]                                                         |
| git_url                    |<EMAIL_ADDRESS>|
| username                   |<EMAIL_ADDRESS>                                           |
| readonly                   | false                                                                   |
| generate_apple_certs       | true                                                                    |
| skip_provisioning_profiles | false                                                                   |
| storage_mode               | git                                                                     |
| git_branch                 | master                                                                  |
| shallow_clone              | false                                                                   |
| clone_branch_directly      | false                                                                   |
| keychain_name              | login.keychain                                                          |
| force                      | false                                                                   |
| force_for_new_devices      | false                                                                   |
| skip_confirmation          | false                                                                   |
| skip_docs                  | false                                                                   |
| platform                   | ios                                                                     |
| verbose                    | false                                                                   |
+----------------------------+-------------------------------------------------------------------------+
[14:16:54]: Cloning remote git repo...
[14:16:54]: If cloning the repo takes too long, you can use the clone_branch_directly option in match.
[14:16:57]: 🔓  Successfully decrypted certificates repo
[14:16:57]: Verifying that the certificate and profile are still valid on the Dev Portal...
Available session is not valid any more. Continuing with normal login.
[14:17:03]: Installing certificate...
+-------------------+------------------------------------------------------------+
|                             Installed Certificate                              |
+-------------------+------------------------------------------------------------+
| User ID           | xxxxxx                                                 |
| Common Name       | Apple Distribution: xxxx xxx & Co KG (xxxx) |
| Organisation Unit | xxxx                                                 |
| Organisation      | xxxx xxx & Co KG                                  |
| Country           | xx                                                         |
| Start Datetime    | 2020-03-18 13:48:16 UTC                                    |
| End Datetime      | 2021-03-18 13:48:16 UTC                                    |
+-------------------+------------------------------------------------------------+
[14:17:06]: Installing provisioning profile...
+---------------------+----------------------------------------+---------------------------------------------------------------+
|                                                Installed Provisioning Profile                                                |
+---------------------+----------------------------------------+---------------------------------------------------------------+
| Parameter           | Environment Variable                   | Value                                                         |
+---------------------+----------------------------------------+---------------------------------------------------------------+
| App Identifier      |                                        | com.xx.xxxx                                                   |
| Type                |                                        | appstore                                                      |
| Platform            |                                        | ios                                                           |
| Profile UUID        | sigh_com.dev.xxx_appstore              | xxx-dc96-412e-a66f-xxx                          |
| Profile Name        | sigh_com.dev.xxx_appstore_profile-name | match AppStore com.xxx.xxxx                                    |
| Profile Path        | sigh_com.dev.xxx_appstore_profile-path | /Users/tushar/Library/MobileDevice/Provisioning               |
|                     |                                        | Profiles/xxxx-dc96-412e-a66f-xxxxx.mobileprovision |
| Development Team ID | sigh_com.dev.MSM_appstore_team-id      | xxxx                                                    |
+---------------------+----------------------------------------+---------------------------------------------------------------+
[14:17:08]: All required keys, certificates and provisioning profiles are installed 🙌
[14:17:08]: Setting Provisioning Profile type to 'app-store'
[14:17:08]: -----------------------
[14:17:08]: --- Step: build_app ---
[14:17:08]: -----------------------
[14:17:08]: Successfully loaded '/Users/tushar/Documents/workspace/iOS2.POC/fastlane/Gymfile' 📄
+-------------------+-----------------------------------------------------------------------------------------------+
|                                     Detected Values from './fastlane/Gymfile'                                     |
+-------------------+-----------------------------------------------------------------------------------------------+
| scheme            | MSM                                                                                |
| clean             | true                                                                                |
| output_directory  | ./build                                                                                |
| output_name       | MSM.ipa                                                                                |
| build_path        | ./build                                                                                |
| derived_data_path | ./derivedData                                                                                |
| export_options    | {:method=>"app-store", :signingStyle=>"manual", :team=>"xxxx",                          |
|                   | :provisioningProfiles=>{"com.dev.MSM"=>"/Users/tushar/Library/MobileDevice/Provisioning       |
|                   | Profiles/xxx-dc96-412e-a66f-xxxx.mobileprovision"}, :signingCertificate=>"Apple  |
|                   | Distribution: xxxx xxxx & Co KG (xxxxx)"}                                        |
+-------------------+-----------------------------------------------------------------------------------------------+
[14:17:08]: Resolving Swift Package Manager dependencies...
[14:17:08]: $ xcodebuild -resolvePackageDependencies -scheme MSM -project ./xxx.xcodeproj
[14:17:09]: ▸ Command line invocation:
[14:17:09]: ▸     /Applications/Xcode-beta.app/Contents/Developer/usr/bin/xcodebuild -resolvePackageDependencies -scheme MSM -project ./xxx.xcodeproj
[14:17:10]: ▸ resolved source packages:
[14:17:10]: $ xcodebuild -showBuildSettings -scheme MSM -project ./xxx.xcodeproj
[14:17:13]: Detected provisioning profile mapping: {:"com.dev.MSM"=>"match AppStore com.dev.MSM"}
+-------------------------------------------------+------------------------------+
|                            Summary for gym 2.144.0                             |
+-------------------------------------------------+------------------------------+
| scheme                                          | xxx                          |
| silent                                          | true                         |
| clean                                           | true                         |
| export_method                                   | app-store                    |
| export_xcargs                                   | -allowProvisioningUpdates    |
| export_options.provisioningProfiles.com.xxx.xxx | xxx AppStore com.xxx.xxx   |
| project                                         | ./xxx.xcodeproj              |
| destination                                     | generic/platform=iOS         |
| output_directory                                | ./build                      |
| output_name                                     | MSM                          |
| skip_package_ipa                                | false                        |
| skip_package_pkg                                | false                        |
| build_path                                      | ./build                      |
| derived_data_path                               | ./derivedData                |
| result_bundle                                   | false                        |
| buildlog_path                                   | ~/Library/Logs/gym           |
| skip_profile_detection                          | false                        |
| xcode_path                                      | /Applications/Xcode-beta.app |
+-------------------------------------------------+------------------------------+
[14:17:13]: ▸ /System/Library/Frameworks/Ruby.framework/Versions/2.6/usr/lib/ruby/2.6.0/universal-darwin19/rbconfig.rb:229: warning: Insecure world writable dir /Users/xxx/Documents/workspace/iOS2.POC in PATH, mode 040777
[14:17:15]: ▸ Clean Succeeded
[14:17:18]: ▸ ❌  error: No profile for team 'xxxx' matching 'match AppStore com.xxx.xxx' found: Xcode couldn't find any provisioning profiles matching 'xxxx/match AppStore com.xxx.xxx'. Install the profile (by dragging and dropping it onto Xcode's dock item) or select a different one in the Signing & Capabilities tab of the target editor. (in target 'xxx' from project 'xxx')
[14:17:18]: ▸ ** ARCHIVE FAILED **
/System/Library/Frameworks/Ruby.framework/Versions/2.6/usr/lib/ruby/2.6.0/universal-darwin19/rbconfig.rb:229: warning: Insecure world writable dir /Users/xxx/Documents/workspace/iOS2.POC in PATH, mode 040777
▸ Clean Succeeded
❌  error: No profile for team 'xxx' matching 'match AppStore com.xxx.xxx' found: Xcode couldn't find any provisioning profiles matching 'xxxxx/match AppStore com.xxx.xxxx'. Install the profile (by dragging and dropping it onto Xcode's dock item) or select a different one in the Signing & Capabilities tab of the target editor. (in target 'xxx' from project 'xxx')
** ARCHIVE FAILED **
[14:17:18]: Exit status: 65
+---------------+------------------------------+
|              Build environment               |
+---------------+------------------------------+
| xcode_path    | /Applications/Xcode-beta.app |
| gym_version   | 2.144.0                      |
| export_method | app-store                    |
| sdk           | iPhoneOS13.4.sdk             |
+---------------+------------------------------+
[14:17:18]: ▸ note: Using new build system
[14:17:18]: ▸ note: Building targets in parallel
[14:17:18]: ▸ note: Planning build
[14:17:18]: ▸ note: Constructing build description
[14:17:18]: ▸ error: No profile for team 'xxxx' matching 'match AppStore com.xxxx.xxx' found: Xcode couldn't find any provisioning profiles matching 'xxx/match AppStore xxxx.xxx.xxxx'. Install the profile (by dragging and dropping it onto Xcode's dock item) or select a different one in the Signing & Capabilities tab of the target editor. (in target 'xxx' from project 'xxx')
[14:17:18]:
[14:17:18]: ⬆  Check out the few lines of raw xcodebuild output above for potential hints on how to solve this error
[14:17:18]: 📋  For the complete and more detailed error log, check the full log at:
[14:17:18]: 📋  /Users/tushar/Library/Logs/gym/MSM-MSM.log
[14:17:18]:
[14:17:18]: Looks like fastlane ran into a build/archive error with your project
[14:17:18]: It's hard to tell what's causing the error, so we wrote some guides on how
[14:17:18]: to troubleshoot build and signing issues: https://docs.fastlane.tools/codesigning/getting-started/
[14:17:18]: Before submitting an issue on GitHub, please follow the guide above and make
[14:17:18]: sure your project is set up correctly.
[14:17:18]: fastlane uses xcodebuild commands to generate your binary, you can see the
[14:17:18]: the full commands printed out in yellow in the above log.
[14:17:18]: Make sure to inspect the output above, as usually you'll find more error information there
[14:17:18]:
+------------------------------------+-----------------------------------------------+
|                                    Lane Context                                    |
+------------------------------------+-----------------------------------------------+
| DEFAULT_PLATFORM                   | ios                                           |
| PLATFORM_NAME                      | ios                                           |
| LANE_NAME                          | ios custom_lane                               |
| SIGH_PROFILE_TYPE                  | app-store                                     |
| MATCH_PROVISIONING_PROFILE_MAPPING | {"com.xxx.xxx"=>"match AppStore com.xxx.xxx"} |
+------------------------------------+-----------------------------------------------+
[14:17:18]: Error building the application - see the log above
+------+------------------+-------------+
|           fastlane summary            |
+------+------------------+-------------+
| Step | Action           | Time (in s) |
+------+------------------+-------------+
| 1    | default_platform | 0           |
| 2    | match            | 13          |
| 💥   | build_app        | 10          |
+------+------------------+-------------+
[14:17:18]: fastlane finished with errors
[!] Error building the application - see the log above

Last few days i'm stuck to resolve Jenkins build issue. I already try lot of solutions but not yet resolved.

Your profiles do not seem to be correct. Please make sure to test this locally. I'd also advise for a more specific title. I don't think many people want to help seeing such a title.

Your profiles do not seem to be correct. Please make sure to test this locally. I'd also advise for a more specific title. I don't think many people want to help seeing such a title.

Locally it already works fine but not with Jenkins

did you find any solution for this? I have the same problem with my fastlane in GitHub action but it works successfully in my laptop CL.


partitioning field/ type not working

partitioning_type may be invalid field for now; removed
https://github.com/auifzysr/yabqsqcli/pull/35


python3Packages.pygments: 2.7.4 -> 2.8.1

Motivation for this change
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[x] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 116710 at ca8f9a24 run on x86_64-linux 1

745 packages marked as broken and skipped:

adobe-reader
agdaPackages.iowa-stdlib
aldor
aliceml
alliance
amule
amuleDaemon
amuleGui
aqemu
atom-beta
...

20817 packages skipped due to time constraints:

AusweisApp2
EBTKS
EmptyEpsilon
Fabric
Literate
MIDIVisualizer
MMA
OSCAR
OVMF
OVMF-CSM
...

80 packages built successfully:

asciidoctor
atk (gnome2.atk ,gnome3.atk)
cairo (gnome2.cairo)
epoxy
fontconfig
gd
gdk-pixbuf
glib (gnome2.glib ,gnome3.glib)
gtk-doc (gnome2.gtkdoc)
gobject-introspection (gnome3.gobject-introspection)
gsettings-desktop-schemas (gnome3.gsettings-desktop-schemas)
gts
harfbuzz
json-glib
libGL
libqrtr-glib
libva
libva-minimal
mesa
pango
python38Packages.Babel
python38Packages.Mako
python38Packages.alabaster
python38Packages.apipkg
python38Packages.astor
python38Packages.async_generator
python38Packages.backcall
python38Packages.blinker
python38Packages.brotli
python38Packages.click
python38Packages.entrypoints
python38Packages.execnet
python38Packages.flake8
python38Packages.flaky
python38Packages.fontforge
python38Packages.freezegun
python38Packages.gunicorn
python38Packages.html5lib
python38Packages.intreehooks
python38Packages.iso8601
python38Packages.jdcal
python38Packages.jinja2
python38Packages.jupyterlab-pygments
python38Packages.libevdev
python38Packages.mccabe
python38Packages.munkres
python38Packages.pastel
python38Packages.pep517
python38Packages.psutil
python38Packages.pyasn1-modules
python38Packages.pycairo
python38Packages.pydocstyle
python38Packages.pygments
python38Packages.pygobject3
python38Packages.pylama
python38Packages.pytest (python38Packages.pytest_6)
python38Packages.pytest-asyncio
python38Packages.pytestcov (python38Packages.pytest-cov)
python38Packages.pytest-expect
python38Packages.pytest-flake8
python38Packages.pytest-forked
python38Packages.pytest-freezegun
python38Packages.pytest-mock
python38Packages.pytestrunner (python38Packages.pytest-runner)
python38Packages.pytest-subtests
python38Packages.pytest-xdist (python38Packages.pytest_xdist)
python38Packages.pytestCheckHook
python38Packages.pytoml
python38Packages.send2trash
python38Packages.simplejson
python38Packages.sqlparse
python38Packages.text-unidecode
python38Packages.webencodings
python38Packages.whoosh
shared-mime-info
volk
wayland
wayland-protocols
xlibsWrapper (xorg.xlibsWrapper)
xorg.libXft

1 suggestion:

warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?
Near pkgs/development/python-modules/Pygments/default.nix:25:5:
   |
25 |     maintainers = with lib.maintainers; [ ];
   |     ^

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 116710 run on x86_64-linux 1

2 packages built:

python38Packages.pygments
python39Packages.pygments

The following issues got detected with the above build packages.
Please fix at least the ones listed with your changed packages:

python38Packages.pygments:

warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?
Near pkgs/development/python-modules/Pygments/default.nix:25:5:
   |
25 |     maintainers = with lib.maintainers; [ ];
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md
warning: python-include-tests
Add a checkPhase for tests, or at least pythonImportsCheck.
See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/python-include-tests.md

part of https://github.com/NixOS/nixpkgs/pull/117452


Icon for Modelica.Thermal.HeatTransfer.Fahrenheit.FixedTemperature needs update

Reported by karinh on 1 Oct 2014 12:57 UTC
The icon for Modelica.Thermal.HeatTransfer.Fahrenheit.FixedTemperature has the text 'degF' written twice, partly overlapped. This does not look good.
MSL Version 3.2.1 (Build 2)

Migrated-From: https://trac.modelica.org/Modelica/ticket/1576

Comment by beutlich on 2 Oct 2014 08:35 UTC
Resolved in e576a84ea1a4dbe6881eb13aae75886b2c05ffce (maintenance branch for MSL 3.2.1) and 89923a8c55cb9df0c0a0fc178a2b348fb934e4b2 (trunk).


Run code using current file name

runSource and knitRmd wrap the current file’s path in some R code and send that code to the terminal.
We could generalise this to a function wrapPath (or something) that has as parameters the R function name and any additional parameters to pass to that R function. Both runSource and knitRmd could be refactored to use wrapPath.
The key benefit of this is that then users could add their own similar commands in their settings.json file, without needing vscode-R itself to be changed.

Closed by #237.


NestJS Debugger

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: Sansossio sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


#2192 scroll issue  resolved

Fixed the Scroll issue with about activity and settings activity
Fixes #2192 About activity
Changed the layout of activity_about and activity_settings

I think this PR did include unintentional changes - including reverting #2199 and #2273. Will properly have a look later.

Reopened, see #2290

I think this PR did include unintentional changes - including reverting #2199 and #2273. Will properly have a look later.

@domdomegg Shall I also include the changes #2199 and #2273 in this PR?

I think this PR did include unintentional changes - including reverting #2199 and #2273. Will properly have a look later.

@domdomegg Shall I also include the changes #2199 and #2273 in this PR?

I've submitted the changes in #2604. I your changes were made on an out of date version of master, which resulted in merge conflicts which weren't resolved properly. Will be all fixed once #2604 merged :)


Introducing parallel variant of add_all_ta_features.

Suggest simple process-based all-set indicators calculation parallelizing. Gives ~2x speedup compared to the initial implementation.

Could you, please, provide the input data you used?


Add wstream

Checklist

[x] I'm reporting a new site support request
[x] I've verified that I'm running youtube-dl version 2019.10.29
[x] I've checked that all provided URLs are alive and playable in a browser
[x] I've checked that none of provided URLs violate any copyrights
[x] I've searched the bugtracker for similar site support requests including closed ones

Example URLs

Single video: https://wstream.video/video6hgkduc1m/wu0810e3163q
Single video: https://wstream.video/video6hgkduc1m/wu0810e3163q
Playlist: -

Description

Add wstream.video

https://github.com/ytdl-org/youtube-dl#can-you-add-support-for-this-anime-video-site-or-site-which-shows-current-movies-for-free


Timesheet - 17/04/2021 - James Pang

Task 1
Reviewed and merged PRs
Proof of Work

https://github.com/thenewboston-developers/Website/pull/1715
https://github.com/thenewboston-developers/Website/pull/1716

Time Spent
1 hours

Task 2
Proofread, add Terms of Service and Privacy Policy pages to website according to figma design
Proof of Work

https://github.com/thenewboston-developers/Website/pull/1726

Time Spent
4.5 hours

Task 3
Reviewed Sanjeev's tutorial PR and added some small changes
Proof of Work

https://github.com/thenewboston-developers/Website/pull/1666

Time Spent
1 hour

Task 4
Investigated on font size issue in website, realised the underlying problem and created a fix
Proof of Work

https://github.com/thenewboston-developers/Website/issues/1722
https://github.com/thenewboston-developers/ui-js/pull/18

Time Spent
2 hour

Task 5
Reviewed PRs in thenewboston/ui
Proof of Work

https://github.com/thenewboston-developers/ui-js/pull/14
https://github.com/thenewboston-developers/ui-js/pull/13

Time Spent
.5 hour

Total Time Spent
9 hours
Account Number
c54c04774efaae20746fd3f29cdd619fea512e119bc1082b863572b2e8844104

Approve

Approved


[HOLD for payment 2024-07-26] [$250] Workspace - "Delay submissions" turns off if the "Submission frequency" is set to "Manually"

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 1.4.80-1
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team
Action Performed:

Log in with a new expensifail account
Create a workspace
Turn "Workflows" on
Navigate to Workflows
Turn "Delay submissions" on
Set "Submission frequency" to "Manually"

Expected Result:
"Delay submissions" should remain on
Actual Result:
"Delay submissions" turns off if the "Submission frequency" is set to "Manually"
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence

https://github.com/Expensify/App/assets/78819774/a9771da7-3b1b-4576-b9fb-acc208f2f8c2
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~015bf509d8291c1690
Upwork Job ID:<PHONE_NUMBER>372778818
Last Price Increase: 2024-06-25

Issue OwnerCurrent Issue Owner: @sonialiap

@sonialiap  FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

Proposal
Please re-state the problem that we are trying to solve in this issue.
Workspace - "Delay submissions" turns of if the "Submission frequency" is set to "Manually"
What is the root cause of that problem?
The root cause of the problem is that when a user sets it to manual, the policy?.harvesting?.enabled becomes false.
The policy?.harvesting?.enabled is false because it checks whether the scheduled submission is enabled which won't be in this situation.
https://github.com/Expensify/App/blob/f3bb5a5a29aa752440190e961d1386d26bee5cf8/src/types/onyx/Policy.ts#L777-L781
Hence, the condition that makes the isActive in the WorkspaceWorkflowsPage becomes false when the auto-reporting frequency is manual.
https://github.com/Expensify/App/blob/f3bb5a5a29aa752440190e961d1386d26bee5cf8/src/pages/workspace/workflows/WorkspaceWorkflowsPage.tsx#L132
What changes do you think we should make in order to solve the problem?

Therefore, we must consider the autoReportingFrequency if it is CONST.POLICY.AUTO_REPORTING_FREQUENCIES.MANUAL.
Just like we did with the CONST.POLICY.AUTO_REPORTING_FREQUENCIES.INSTANT.
So, let's change the isActive logic to something simpler than the one below.
isActive: (((policy?.harvesting?.enabled && policy.autoReportingFrequency !== CONST.POLICY.AUTO_REPORTING_FREQUENCIES.INSTANT ) ?? (policy?.harvesting?.enabled && policy.autoReportingFrequency !== CONST.POLICY.AUTO_REPORTING_FREQUENCIES.MANUAL) ) && !hasDelayedSubmissionError) ?? false,

@abdulrahuman5196 what do you think of the above proposal?

checking now

Hi all, I dont see the Delay submissions option in the workflow? Do I need to be part of some beta or any specific type of workspace?

Hi @sonialiap  Sorry for the delay, I have limited availability at the moment. So unassigning myself. Kindly reassign another C+ for review.

@dukenv0307 added you as the C+

@dukenv0307

After choosing Manual option, harvesting.enable is false and frequency is immediate. Do you think it's BE bug? If not, why don't we just remove the manual option, since we can toggle the delay submission instead of choosing Manual?

What do you mean by "toggle the delay submission"? Do you mean disable it? The point of Manual is to allow expenses to pile up before being submitted, like Weekly or Monthly but without an end date. If Delay Submission is disabled (I'm assuming that's what you mean by toggling it) then expenses are submitted immediately, so there's no delay as the customer might want. I think we need to keep the Manual option and not disable Delay Submission.

I don't know how the functionality looks like in the code but behavior wise, when set to Manual I expect it to be

harvesting enabled
frequency (is this submission frequency? If submission then disabled, we don't want automatic submission)

@roryabraham could you confirm english to code for me haha? We want this feature to function like OD Scheduled Submit where when "Manual" is selected expenses are harvested onto reports but are not automatically submitted

Ok, I've looked into this and actually @Tony-MK was pretty close. This logic is actually pretty convoluted, but I'll try my best to spell it out. (for what it's worth, I can't imagine it would've been possible to figure all this out without access to the back-end code)

There's a policy field called autoReportingFrequency, which can have the following values:

immediate
instant
weekly
semimonthly
monthly
trip
manual
lastDayOfMonth
lastBusinessDayOfMonth

There's another policy field called harvesting.enabled, that's a boolean that determines whether harvesting runs
Harvesting is the process by which a daily job runs for each policy and determines if any reports need to be submitted. It also handles monthly summary emails and other stuff. (internal docs)
confusingly, harvesting.enabled doesn't actually prevent the harvesting job from running (because of the monthly summary email I mentioned). It just prevents reports from being submitted as part of harvesting.
instant = "instant submit", was added recently as part of the Instant Submit for Collect doc. As the name suggests, it means that when a report is created in the policy it's instantly submitted.
immediate is a legacy term. It is in fact, not immediate 😂
immediate & harvesting.enabled = daily
immediate & !harvesting.enabled = manual

ok, so with that out of the way, I think we can fix this issue a bit more simply by ignoring harvesting.enabled
diff --git a/src/pages/workspace/workflows/WorkspaceWorkflowsPage.tsx b/src/pages/workspace/workflows/WorkspaceWorkflowsPage.tsx
index 372044d4bb..ae5cc5edeb 100644
--- a/src/pages/workspace/workflows/WorkspaceWorkflowsPage.tsx
+++ b/src/pages/workspace/workflows/WorkspaceWorkflowsPage.tsx
@@ -128,7 +128,7 @@ function WorkspaceWorkflowsPage({policy, betas, route}: WorkspaceWorkflowsPagePr
                                   brickRoadIndicator={hasDelayedSubmissionError ? CONST.BRICK_ROAD_INDICATOR_STATUS.ERROR : undefined}
                               />
                           ),
-                          isActive: (policy?.harvesting?.enabled && policy.autoReportingFrequency !== CONST.POLICY.AUTO_REPORTING_FREQUENCIES.INSTANT && !hasDelayedSubmissionError) ?? false,
+                          isActive: (policy?.autoReportingFrequency !== CONST.POLICY.AUTO_REPORTING_FREQUENCIES.INSTANT && !hasDelayedSubmissionError) ?? false,
                           pendingAction: policy?.pendingFields?.autoReporting,
                           errors: ErrorUtils.getLatestErrorField(policy ?? {}, CONST.POLICY.COLLECTION_KEYS.AUTOREPORTING),
                           onCloseError: () => Policy.clearPolicyErrorField(policy?.id ?? '-1', CONST.POLICY.COLLECTION_KEYS.AUTOREPORTING),

Going through the options:

immediate & harvesting.enabled = daily => so Delay Submissions should be active
immediate & !havesting.enabled = manual => so Delay Submissions should be active
Really the only time when we wouldn't want Delay Submissions to be active is if the policy has the new instant auto-reporting frequency (or apparently if there's some error, but I don't have good context about that)

Will be fixing this myself in https://github.com/Expensify/App/pull/45540

@dukenv0307 PR is ready for your review: https://github.com/Expensify/App/pull/45540

PR is C+ approved, just waiting on review from @Beamanator, @mountiny, and/or @madmax330

Hey, @roryabraham, I am curious to know if I am eligible for compensation for providing a solution that was used in the recently merged PR based on your previous comment.
Thank you

@roryabraham what do you think? https://github.com/Expensify/App/issues/43196#issuecomment-2246975341

Payment summary:

@dukenv0307 $250 - offer sent in upwork - please complete the checklist

https://www.upwork.com/ab/applicants/1816797650551015987/job-details

Hey, @roryabraham, I am curious to know if I am eligible for compensation for providing a solution that was used in the recently merged

Sorry, but no I don't think so. I figured out the solution by looking at back-end code, and the proposal you posted wasn't a complete and correct solution. I merely meant to acknowledge that out of all the proposals yours was the closest to being correct.

@dukenv0307 please accept the offer in upwork 💰

@dukenv0307 it seems like I sent the offer to that profile, I just sent a message on the offer. Let me know if you don't see it then I'll resend :D

Oh I misnamed the offer with another issue number 🤦 I called it 44830

Paid ✔


Create sequences_mert_can_fidan.py

My Changes
Firstly, I created four values and after that I created three functions named as remove_duplicates, list_counts and reverse_dict.
Checklist

[x] I have read [CONTRIBUTING].
[x] I have performed a self-review of my own code.
[x] I have run the code locally and it works as explained.
[x] I have commented my code, particularly in hard-to-understand areas

You don't have my_dict.

Sorry for my mistake. I'm updated my commit.


Remove "Adobe Confidential" headers

Some of the files in this repo have "Adobe Confidential" in the headers. This should be removed as it gives folks the impression this project is not licensed under BSD-3-Clause. This may discourage folks from using the project and the open source office has already received one inquiry about the above.

Hi Simon
I can see these 6 instances where "ADOBE CONFIDENTIAL" string is left out. This is not any new inclusion as I can see it was there even in our year-2014 and year-2016 SDKs.
Presently these are present in:

source/SafeTypes.h
build/shared/SharedConfig_Android.cmake
build/ProductConfig.cmake
source/SafeStringAPIs.cpp
source/SuppressSAL.h
source/SafeStringAPIs.h
I used this search query to find these.

I intend to make changes to rectify this. But before I do that I just want to check with you if these are the same set of issues which you wanted to refer to?
Kindly confirm.
Regards
Pawan

@pawankishorsingh yeah, we specifically received a question on the .cpp/.h files but removing it from the .cmake files as well and replacing it with the BSD-Clasue-3 headers would be good.

"Adobe Confidential" has been removed from the 6 places which I mentioned above. There are few more changes upcoming related to licensing. But we're tracking them from another issue. Hence closing this issue. Hope its fine.


Back button on preview

... should go back to either edit mode or to the notes list, depending where the user came from

I'd say that this is valid in the edit view as well. I'd like to go back to the note-list in the folder I came from, not to the root note folder.

When we are editing a file and preview it, and click on the back button, it takes me not to the NoteActivity.java screen, but to the Fragment that displays the list of folders and files.

Yeah, default android back button should go back and not quit the app.


helm --namespace option not working

Welcome!

[X] Yes, I've searched similar issues on GitHub and didn't find any.
[X] Yes, I've searched similar issues on the Traefik community forum and didn't find any.

What version of the Traefik's Helm Chart are you using?
traefik-16.1.0
What version of Traefik are you using?
traefik:2.9.1
What did you do?
helm --namespace template traefik traefik.traefik

What did you see instead?
no namespace specified in resources
What is your environment & configuration?
local environment, just helm -n traefik template traefik traefik/traefik
Additional Information
namespace should be set to traefik in all resources (except cluster role)

I guess this would be solved with https://github.com/traefik/traefik-helm-chart/pull/373
It is a slightly different use case, but at the end it will add {{ .Release.Namespace }} to all resources and that is what is needed here.

It's an expected behavior from helm 3, see this issue for more details.

Starting with v20.2.0, it's possible to override Helm namespace on this Chart. See #718 for details.

Hi @mloiseleur I've retried the latest (v20.3.0 release) and the serviceAccount resource is still created in the default namespace..


[CLOSED] Add aaib reports to rummager

 Issue by tommyp
Tuesday 08 July 2014 at 16:01 GMT
Originally opened as https://github.com/alphagov/specialist-publisher/pull/163

In order to expose AAIB Reports in search, we need to send the documents to Rummager when publishing.
This PR contains:

adding observers for publishing and withdrawing of AAIB reports to/from Rummager along with relevant tests
refactoring SpecialistDocument Cucumber steps to be more generic
renaming of the routes from specialist_document to cma_case

Ticket: https://trello.com/c/X4vUOJzE/203-add-aaib-reports-into-search-results-2

tommyp included the following code: https://github.com/alphagov/specialist-publisher/pull/163/commits

 Comment by evilstreak
Tuesday 08 July 2014 at 17:48 GMT

I like the cleaning up of the cukes in here, and I like that you've replaced all the misleading path helpers like specialist_document_path.
I don't like the amount of churn in this PR for the routes file especially with all the changing back and forth. Is it possible to just squash the 2nd (Refactor SpecialistDocument steps) and 5th (Rename specialist_document_path to cma_cases_path) commits?

 Comment by bestie
Wednesday 09 July 2014 at 09:16 GMT

LGTM :+1:

 Comment by bestie
Wednesday 09 July 2014 at 09:17 GMT

Needs rebase though


Use github pages and link to https://cryptoseb.pw

Use Github Pages to create a webpage which has Table of contents to the left to improve readability.
The website https://cryptoseb.pw is already sited in many places, So it would be great if you could have this latest version on that domain itself and also let people know how to contribute.

We did originally have the paper hosted on my server, but we moved over to GitHub to improve transparency. I suppose I could use GitHub pages but I like the fact that this is a paper, not a website. https://privacytools.io has a website, I don't want to steal what they are doing for my paper. Although, having a table of contents would be really nice.
I don't really have time to consider contributions right now in the entirety. The best I was able to do is link people to the Issue I started and have them add what they think needs to be changed/improved and go from there when I find the time.


Publishing extension became failed due to validation error

I've got an vscode extension successfully published and updated in market for several versions.
But it became failed today, and the reason explained in the mail from marketplace was due to a validation error, which said 'the extension contains an entry which is unsafe for extraction' in detailed log.
The only changes in this version were just some adds and deletes in an existing file. So I don't know if it's a bug or what going wrong here?
Also, I posted the question here.

Following up with the marketplace team. I'll update when I hear back.

@fiveisprime Thank you, and here's my extension: https://marketplace.visualstudio.com/items?itemName=bsv-scrypt.sCrypt&ssr=false#overview

Please try your deployment again. It should be corrected now.

Please try your deployment again. It should be corrected now.

It works!!! Thank you very much.


v22.10.0 fails to install

Distro: K3s

Something is wrong with K3s.
For me K3s didn't work but Minikube latest worked.


Add without compression

Just from a better use case point of view, you should also add files that are unzipped and inside the zip folder seperately so that people can view your work that way also
Not everybody wants to download the zip, some just come in to view the contents
Great job, btw,
Cheers!

Ok i will add it. Thank you for your suggestion and support...


#1429 add overload methods to sibling()

Proposed changes
Added overload methods to sibling()
SelenideElement sibling(String tag);
SelenideElement sibling(String tag, int index);
SelenideElement sibling(String tag, String attributeName, String attributeValue);
https://github.com/selenide/selenide/issues/1429
Checklist

[x] Checkstyle and unit tests are passed locally with my changes by running gradlew check chrome_headless firefox_headless command
[x] I have added tests that prove my fix is effective or that my feature works
[x] I have added necessary documentation (if appropriate)

Hey @oleksandr-diachenko thank you to help with this feature.
From my point of view we don't need it. These are the main reasons why:

We got only one request to add this methods. Seems it is not so important and useful.
It covers only limited amount of selector combinations cases but adds bunch of new methods to SelenideElements that are not concise and not easily understood. As I see it should not be 100500 overloads but like click() one method (sibling, parent, etc) that accepts params object with concise builder api e.g.
$("lol").sibling(withTag("kek").index(2))
When we add this we encourage writing such weird code like:
$("#lol).sibling("label", "name", "my-shitty-input").sibling("input", 1);

@BorisOsipov i also think we don't need this, that's why i've closed this PR. Don't pay attention to my wasted time,  best way to understand how technology works from the inside is to write something :)

best way to understand how technology works from the inside is to write something :)
That's true. 👍
Usually I starts my contributions to OSS projects with the same motivation.


start_playback(deviceID) returns "Player command failed: Restriction violated"

When using spotipy to start_playback on my phone, music resumes as expected. However, when i input the ID of my Amazon echo, it returns the error "Player command failed: Restriction violated".
Any idea what's causing this?

Could you please provide some more information? Were you already playing on the Echo, but then paused, or were you playing on your phone and tried to resume on the Echo, or what was the exact situation?
Perhaps you could try transferring the playback.

Definitely this error is coming from the web API. Look at this thread https://github.com/spotify/web-api/issues/1205

So I have the same behaviour:

Play music on spotify connect device, e.g. Echo Dot.
Switch playback to pc in the spotify desktop app.
Close the desktop app
Start playback on spotify connect device (Echo) through python
-> Restriction violated, even though the device id shows up in sp.devices().

You think this is a web api issue?
If so, I will go there with my problem.

So I have the same behaviour:

Play music on spotify connect device, e.g. Echo Dot.
Switch playback to pc in the spotify desktop app.
Close the desktop app
Start playback on spotify connect device (Echo) through python
-> Restriction violated, even though the device id shows up in sp.devices().

You think this is a web api issue?
If so, I will go there with my problem.

Alright so I worked around this with transferring the playback before if a device is currently playing or if no device is playing at all.
Seems to work for now but but is not that pretty. Alse I need to pause the playback, otherwise the currently playing song will shortly play on the echo:
def play_context_URI(uri: str):
    current = current_device()
    if current == -1:
        sp.transfer_playback(config['AUTH']['device_id'], force_play=False)        #Workaround for permission problems when old playback was on other device
        time.sleep(0.5)
        sp.pause_playback()
    elif current[0] != config['AUTH']['device_id']:
        sp.transfer_playback(config['AUTH']['device_id'], force_play=False)        #Workaround for permission problems when other device is currently in playback
        time.sleep(0.5)
        sp.pause_playback()
    if check_available(config['AUTH']['device_id']):         #check if device is even online for playback
        shuffle_on()
        sp.start_playback(device_id=config['AUTH']['device_id'], context_uri=uri)
        return 1
    else:
        return -1

Alright so I worked around this with transferring the playback before if a device is currently playing or if no device is playing at all.
Seems to work for now but but is not that pretty. Alse I need to pause the playback, otherwise the currently playing song will shortly play on the echo:
def play_context_URI(uri: str):
    current = current_device()
    if current == -1:
        sp.transfer_playback(config['AUTH']['device_id'], force_play=False)        #Workaround for permission problems when old playback was on other device
        time.sleep(0.5)
        sp.pause_playback()
    elif current[0] != config['AUTH']['device_id']:
        sp.transfer_playback(config['AUTH']['device_id'], force_play=False)        #Workaround for permission problems when other device is currently in playback
        time.sleep(0.5)
        sp.pause_playback()
    if check_available(config['AUTH']['device_id']):         #check if device is even online for playback
        shuffle_on()
        sp.start_playback(device_id=config['AUTH']['device_id'], context_uri=uri)
        return 1
    else:
        return -1


Feature request: add SURF_WIND derived variable (vector of UBOT, VBOT)

Is this for a vector-contour plot, aka plot set 6?  Probably this should wait until I have a chance to redo the data structure.  The present one (just a tuple) doesn't work well with everything else.

Hi Jeff, yes, I think a vector-contour plot would be appropriate.
Also, I should say that this is really a low priority, and I think there are probably much better approaches available than what can be quickly done in the present code.  I really just wanted to have this on the list before I forget; it is something we might consider doing later if it becomes more important or if we have extra time, or if it becomes easier after other developments.

It would be useful to have a general-purpose vector plot capability.  That would cover (UBOT,VBOT) as well as what Jerry Potter just tried today: a vertical average of the horizontal wind (U,V = zonal,meridional velocity). And it would cover whatever else comes up next.

You mean contour with arrows on it? Kind of like streamlines? VCS use to be able to do this. Do you have an example plot you can post here?

Yes, a vector-contour plot is vectors (little arrows) overlaying a contour plot (isofill).  We're doing that now, with VCS.  Thus the issue isn't "how to make a plot".  The issue is mainly about setting up the input system, and probably a bunch of minor interior tweaks.  There might be some difficulties in getting the arrows to be the right size and density, but more likely not.


updated httparty to newest version due to json 1.8/2.0 conflicts

newest version of httparty (0.16) utilizes json 2.0.2 which conflicts with json 1.8. Updated Httparty to newest version. Ran rspec tests. Out of 43 Tests, 14 failed. Each failed due to the API no longer having data that met the requirements of the test.

thanks!


Added newline to 'tod list process' for projects

When you invoke tod list process using a project, there are no newlines separating one task from another. However, if you invoke the same command using a filter, there is a newline separating. I changed process_tasks() in projects.rs to match the functionality of the same function in filters.rs. The resulting change amounts to a one line addition.

@alanvardy, I do not believe I have write access to merge it.

Thank you!


Error during image decryption.. Pls help!!

The following error pops up when I decrypt the image.
Traceback (most recent call last):
File "C:\Users\USER\Documents\GitHub\CrytoSteg\main.py", line 63, in
main()
File "C:\Users\USER\Documents\GitHub\CrytoSteg\main.py", line 44, in main
secure.desecure_file(stegoImg)
File "C:\Users\USER\Documents\GitHub\CrytoSteg\lib\Secure.py", line 37, in desecure_file
self.crypt.decrypt_file(outputFile)
File "C:\Users\USER\Documents\GitHub\CrytoSteg\lib\Crypt.py", line 106, in decrypt_file
dec1 = self.decrypt_rsa(dec, keyF)
File "C:\Users\USER\Documents\GitHub\CrytoSteg\lib\Crypt.py", line 49, in decrypt_rsa
message = self.key.decrypt(message)
File "C:\Users\USER\miniconda3\envs\cryptosteg\lib\site-packages\Crypto\PublicKey\RSA.py", line 416, in decrypt
raise NotImplementedError("Use module Crypto.Cipher.PKCS1_OAEP instead")
NotImplementedError: Use module Crypto.Cipher.PKCS1_OAEP instead

It looks like in recent versions of Crypto module, we have to use an object of PKCS1_OAEP to encrypt and decrypt data. I will try to fix it in a day or two. That works?

That would be of immense help. Thanks for the swift reply and support!

Hey,
Thanks for the reply. Your help is much appreciated.
I have another one query. If I am to use TRNG/CSPRNG for the generation of
seeds for the random numbers, what are the options available in Python
libraries? I suppose it can be integrated with your project for a more
secure and unbreakable encryption process. Can you give me some insights in
this regard?
Thanks,
Robert
On Wed, 2 Aug 2023 at 23:22, Kunal Attri @.***> wrote:

It looks like in recent versions of Crypto module, we have to use an
object of PKCS1_OAEP to encrypt and decrypt data. I will try to fix it in a
day or two. That works?
—
Reply to this email directly, view it on GitHub
https://github.com/Kunal-Attri/Data-Security-using-Cryptography-and-Steganography/issues/4#issuecomment-1662693933,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AGYKB7F7SGSDUMEM5C3XZJLXTKHXJANCNFSM6AAAAAA3BTW73I
.
You are receiving this because you authored the thread.Message ID:
<Kunal-Attri/Data-Security-using-Cryptography-and-Steganography/issues/4/1662693933
@github.com>

--
There's only one corner of the universe where you can be certain of
improving, and that's your own self.

I'm also got same error..

I'll look into it ASAP and update it.


[BUG] Read only user seeing 403 error when viewing Dashboards

Describe the bug
When logging in as a read only user, 403 error with message "Unable to update UI setting" is shown in the browser app.
To Reproduce
Steps to reproduce the behavior:

Create a new user
Duplicate the role kibana_user to kibana_user_global_ro
Edit kibana_user_global_ro so that it has read only permission on global_tenant
Create index pattern and dashboards in Global tenant
Log in as the user, view global tenant and see the error

Expected behavior
No error shall be shown
Plugins
security frontend and backend
Screenshots

Identified not fixable in security plugin.
Need to transfer to suitable owner

Managed to reproduce this issue and found out the error message was “no permissions for [indices:data/write/update]”. This is expected because you only gives read permission for global tenant but in cluster permission setting part,  both write and read permission are given.  This conflict causes the error message shows up.  If you give both read and write permission to global tenant, error message disappears.

Such behavior is identified being triggered in the function ensureDefaultIndexPattern: https://github.com/elastic/kibana/blob/v7.10.2/src/plugins/data/common/index_patterns/index_patterns/ensure_default_index_pattern.ts#L34
Called by an anonymous function: https://github.com/elastic/kibana/blob/v7.10.2/src/plugins/dashboard/public/application/legacy_app.js#L148

@hsiang9431-amzn does this issue need to be transferred to the https://github.com/opensearch-project/OpenSearch-Dashboards repository?

@tmarkley Yes, please transfer it to https://github.com/opensearch-project/OpenSearch-Dashboards

@opensearch-project/admin please transfer this to the OpenSearch-Dashboards repository.


irmin-pack: add classification for volume files

As pointed out in #2197, we need classification for volumes. So this PR does that. :sunglasses:

Codecov Report

Merging #2201 (cbea0b2) into main (fc9d3cb) will increase coverage by 0.03%.
The diff coverage is 92.30%.

:exclamation: Current head cbea0b2 differs from pull request most recent head b91dfe5. Consider uploading reports for the commit b91dfe5 to get more accurate results

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@            Coverage Diff             @@
##             main    #2201      +/-   ##
==========================================
+ Coverage   67.97%   68.01%   +0.03%
==========================================
  Files         135      135
  Lines       16301    16302       +1
==========================================
+ Hits        11081    11088       +7
+ Misses       5220     5214       -6

Impacted Files
Coverage Δ

src/irmin-pack/unix/file_manager.ml
83.86% <60.00%> (ø)

src/irmin-pack/layout.ml
83.63% <100.00%> (+0.30%)
:arrow_up:

src/irmin-fs/unix/irmin_fs_unix.ml
68.38% <0.00%> (+3.87%)
:arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Backport 4.2 - Bump noobaa operator v2.0.9 + core v5.2.11

Backport of #348
Thanks @kshlm for the help!
Due to #347 we couldn't update go.mod but there is no change in the API so will update once that issue is resolved.

@guymguym is there a bz for this?
/ok-to-test

@nimrod-becker bz?

@kshlm @obnoxxx
Since the BZ was fixed with the merge into the noobaa-operator branch and the DS build already takes the new version. How do we handle this? We keep on hitting the same problem :)
The images and versions are mainly for consuming this repo and not for DS builds, can we remove the BZ requirement?

We don't want to remove the BZ restriction on this branch. Especially not now so close to GA. If we can't get a bz for this right now, then my preference is to hold this till we have another bz that needs to update the images and do it then.

If this is affecting any testers, then we should really encourage them to use the downstream builds instead. It's just a matter of changing one word in the registry image (s/ocs-dev/rhceph-dev/) for the catalogsource.

/bugzilla refresh

we can "misuse" an existing BZ to get this into ocs-operator... ;-)
@kshlm - what do you think?