Update react-json-view

Closing this one, there's nothing we can do about it since we're on the latest version of our direct dep and the problematic dep is many layers down:    - Hoisted from "react-json-view#flux#fbjs#isomorphic-fetch#node-fetch"


Doc: Fixed typos in README.md

Fixed typos and grammatical errors in the README.md at several places.

Thanks.


No Source Distribution in 0.11.8

If you look at previous releases, like 0.11.7 a tarball of the source was made available. In 0.11.8 the tarball is not present.
This is a problem for Python applications distributed through Homebrew, like the azure-cli. This is because each dependency is required to be declared as a resource in the Formula which will be built from source.

thank you for reporting. I will fix it for the next version that will be available in couple days


Failing to scale dosbox-staging to screen

Linux Distribution
SteamOS
Luxtorpeda Version
70
Bug description
When I run a variety of non-Steam (GOG) DOS games (Might and Magic: Worlds of Xeen is an example) in Luxtorpeda and select Dosbox Staging, the display uses a very tiny corner of my screen instead of scaling.
This does not happen for every GOG DOS game. Magic Carpet 2 works perfectly.
Steps To Reproduce

Install Worlds of Xeen with GOG on a windows PC.
Move folder to Steam Deck.
Add dosbox.exe to Steam.
Add launch options from windows shortcut to Steam
Force luxtorpeda 70 compatibility mode.
Run game in game mode.

Expected Behavior
Game scaled up to use more than approximately 1/8th of the screen.
Additional Context
I'd love to know how to configure each game I add to luxtorpeda. I can't seem to find documentation for this. Is it possible?
Relevant log output
No response

Note that playing GOG games isn't officially supported with lux, although it can work as you can see.
It sounds like either the game has an incorrect config, or dosbox staging isn't seeing the config and going with some sort of defaults.
It's possible that the file is in the wrong spot for this version to see it. You may want to look at the console/log output of dosbox-staging to see if you see anything there.
In terms of configuring the games, there should be a dosbox config file in the games, or you can set one in your user profile directory, the same as if you installed it yourself.


Add Anto Samalona to Contributors list

Merged please ;)

@antosamalona, I'm quite elated about your PR. I wanna evolve this project to addresses various problems faced by first-time contributors. I'd love to learn about your journey in open source community, the problems, pain points you had etc.
Could you explain how you felt when you went through the tutorial, made a PR and learned that I merged it?


Revert "Adding table name and segment name headers to segment push"

Reverts linkedin/pinot#2974 as per Intellij bug https://youtrack.jetbrains.com/issue/IDEA-93855.
Will add back after I figure out how to manually add jar.

Codecov Report

Merging #2979 into master will increase coverage by 10.05%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           master    #2979       +/-   ##
===========================================
+ Coverage    59.7%   69.76%   +10.05%
===========================================
  Files         915      915
  Lines       43438    43436        -2
  Branches     5922     5922
===========================================
+ Hits        25936    30301     +4365
+ Misses      15597    11114     -4483
- Partials     1905     2021      +116

Impacted Files
Coverage Δ

...i/resources/PinotSegmentUploadRestletResource.java
56.8% <ø> (+53.3%)
:arrow_up:

...minion/executor/BaseSegmentConversionExecutor.java
72.97% <100%> (+70.34%)
:arrow_up:

...om/linkedin/pinot/transport/netty/NettyServer.java
80% <0%> (-4%)
:arrow_down:

.../pinot/core/segment/index/SegmentMetadataImpl.java
81.56% <0%> (+0.7%)
:arrow_up:

...ment/creator/impl/SegmentColumnarIndexCreator.java
88.72% <0%> (+0.75%)
:arrow_up:

...r/transform/function/ValueInTransformFunction.java
39.2% <0%> (+0.8%)
:arrow_up:

.../helix/core/realtime/SegmentCompletionManager.java
69.68% <0%> (+0.9%)
:arrow_up:

...din/pinot/core/realtime/stream/StreamMetadata.java
67.88% <0%> (+0.91%)
:arrow_up:

...e/io/writer/impl/MutableOffHeapByteArrayStore.java
86.45% <0%> (+1.04%)
:arrow_up:

...kedin/pinot/broker/broker/BrokerServerBuilder.java
87.5% <0%> (+1.04%)
:arrow_up:

... and 272 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 980d768...4d2fe1f. Read the comment docs.


Revert spring2 compatible

Fix #116

Pull Request Test Coverage Report for Build 411

4 of 5 (80.0%)  changed or added relevant lines in 1 file are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-0.1%) to 43.837%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

sofa-ark-parent/support/ark-springboot-starter/src/main/java/com/alipay/sofa/ark/springboot/listener/ArkApplicationStartListener.java
4
5
80.0%

Files with Coverage Reduction
New Missed Lines
%

sofa-ark-parent/core-impl/archive/src/main/java/com/alipay/sofa/ark/loader/ExecutableArkBizJar.java
1
0.0%

Totals

Change from base Build 409:
-0.1%

Covered Lines:
1035

Relevant Lines:
2361

💛  - Coveralls


docs: Adjust developer-notes.md to use signed ints normally

I actually learned more about this when I went to try to convert some ints that should never be negative into uints. However, I researched it a bit and found out it's actually a quite bad idea due to what happens when signed integers and unsigned ints get mixed up. I think it'd be valuable to formalize and put into developer docs.
(also change some unsigned ints to ints that were used in arithmetic with signed ints)

and fixed linter

looks still unhappy?

Okay, hopefully that makes it happy


⚠ Bofrost.lu has degraded performance

In 444491d, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1233 ms

Resolved: Bofrost.lu performance has improved in fbb19d8 after 8 minutes.


Renamed Static repo -> Static registry in README

Fixed dead link

Thanks for your pull request. Is this your first contribution to a Snowplow open source project? Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://github.com/snowplow/snowplow/wiki/CLA to learn more and sign.
Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

I signed it!

Confirmed! @oldpa  has signed the Individual Contributor License Agreement. Thanks so much


plugin build is adding synthetic method $$$getFont$$$ to sub classes of SettingsEditor multiple times

The D Language plugin extends SettingsEditor in a few places such as DlangRunDmdConfigurationEditor and DlangRunDubConfigurationEditor.  It seems the build process add a synthetic method called $$$getFont$$$ which is being duplicated. This in turn causes class loader problems when running the plugin.
relates to https://github.com/intellij-dlanguage/intellij-dlanguage/issues/787
with similar reports on youtrack: https://youtrack.jetbrains.com/issue/IDEA-192748/java.lang.ClassFormatError-Duplicate-method-name-getFont

Hi, I noticed in https://youtrack.jetbrains.com/issue/IDEA-298989/Duplicate-method-name-getFont#focus=Comments-27-6453425.0-0 that commit https://github.com/JetBrains/gradle-intellij-plugin/commit/de337103fee9765c569f2f666c1d7068d4986c61 should fix the duplicated getFont methods. Does this just need a new release?

Turned out that this commit 1e3af81ae2b4ed3070939a6b990f7e459aeb6931 is also needed.
All the changes are now available in the 1.10.0-SNAPSHOT release.
Could you please try it out?


Bug with Player Editing Item and Save

Players Edit Item, and Edit Save don't work. Will say the player file is missing. Discord link in the readme also doesn't work.

Because u didn't provide the Players folder


Mythril analyze returning AttributeError

Description
mythril.interfaces.cli [ERROR]: Traceback (most recent call last):
  File "/usr/local/lib/python3.10/site-packages/mythril/interfaces/cli.py", line 966, in parse_args_and_execute
    address = load_code(disassembler, args)
  File "/usr/local/lib/python3.10/site-packages/mythril/interfaces/cli.py", line 717, in load_code
    address, _ = disassembler.load_from_solidity(
  File "/usr/local/lib/python3.10/site-packages/mythril/mythril/mythril_disassembler.py", line 291, in load_from_solidity
    for contract in get_contracts_from_file(
  File "/usr/local/lib/python3.10/site-packages/mythril/solidity/soliditycontract.py", line 132, in get_contracts_from_file
    yield SolidityContract(
  File "/usr/local/lib/python3.10/site-packages/mythril/solidity/soliditycontract.py", line 197, in __init__
    ).extract_features()
  File "/usr/local/lib/python3.10/site-packages/mythril/solidity/features.py", line 28, in extract_features
    ether_vars = self.extract_address_variable(node)
  File "/usr/local/lib/python3.10/site-packages/mythril/solidity/features.py", line 224, in extract_address_variable
    transfer_vars.update(self.extract_address_variable(value))
  File "/usr/local/lib/python3.10/site-packages/mythril/solidity/features.py", line 228, in extract_address_variable
    transfer_vars.update(self.extract_address_variable(item))
  File "/usr/local/lib/python3.10/site-packages/mythril/solidity/features.py", line 228, in extract_address_variable
    transfer_vars.update(self.extract_address_variable(item))
  File "/usr/local/lib/python3.10/site-packages/mythril/solidity/features.py", line 210, in extract_address_variable
    node.get("nodeType", "") == "ExpressionStatement"
AttributeError: 'NoneType' object has no attribute 'get'

How to Reproduce
myth analyze myContract.sol
-> contract code can be found https://bscscan.com/token/0xadb58e26d623acc31870318e419d86fb36c3d9c3#code
using macbook m1 with OS venture 13.4.1
Expected behavior
Should return SWC codes
Screenshots
N/A
Environment
macbook m1 with OS venture 13.4.1
Please modify for your setup

Mythril version: output from  myth version or pip show mythril

pip3 show mythril
Name: mythril
Version: 0.24.0
Summary: Security analysis tool for Ethereum smart contracts
Home-page: https://github.com/ConsenSys/mythril
Author: ConsenSys Dilligence
Author-email:
License: MIT
Location: /opt/homebrew/lib/python3.11/site-packages
Requires: asn1crypto, blake2b-py, certifi, coincurve, coloredlogs, configparser, coverage, cytoolz, eth-abi, eth-account, eth-hash, eth-keyfile, eth-rlp, eth-utils, ethereum-input-decoder, hexbytes, jinja2, MarkupSafe, matplotlib, mock, mypy-extensions, numpy, persistent, pre-commit, py-ecc, py-evm, py-flags, py-solc, py-solc-x, pyparsing, pytest, pytest-cov, pytest-mock, requests, rlp, scikit-learn, semantic-version, transaction, z3-solver
Required-by:

Solidity compiler and version: solc --version

solc --version
solc, the solidity compiler commandline interface
Version: 0.8.21+commit.d9974bed.Darwin.appleclang

Python version: python -V

python3 --version
Python 3.11.6

OS and Version: [e.g. Mac OS High Sierra]

OS venture 13.4.1
Additional Environment or Context
N/A

Hi, This should be fixed in the develop -> new 0.24.1 version
Although for some reason the constructor is not being run properly

The constructor not being run properly is likely due to IUniswapV2Router02 being an interface over a contract, so solidity compiler lacks any information on the code and directly relies on onchain code which is not possible locally with mythril without connecting to a chain, if you paste the contract over IUniswapV2Router02, it shouldn't revert during construction


Remove TSA from the BIA data for Tribal Statistical Areas

Is your feature request related to a problem? Please describe.
Right now the BIA data appends each of the TSA data with Tribe_Name_TSA. This is annoying. Can we remove the TSA from these Tribal names
Describe the solution you'd like
See above
Describe alternatives you've considered
The alternative is to not do this.
Additional context
Add any other context or screenshots about the feature request here.

same thing for LAR tribes


chore(templates): update cloudflare templates to support streaming and defer in entry.server.tsx

The cloudflare-pages and cloudflare-workers templates had been updated to React 18, but do not currently support streaming responses and defer.
This PR:

Updates those templates to do so. Now a new project initialized with either of those templates should support defer out of the box.
Updates the docs for defer to include steps on how to upgrade an older Remix app to support defer, including necessary changes in entry.client.tsx and entry.server.ts that enable client-side React 18 hydration and streaming responses.
Run cloudflare-pages/cloudflare-workers local dev servers on port 3000 to match the default remix server behavior

I pulled the entry.server.tsx code from @jacob-ebey's example project which deploys to Cloudflare and tested that the updated cloudflare-pages/cloudflare-workers templates run successfully for local dev, including with defer.
Thanks for all your great work and very excited to begin playing around with defer.

Closing this as we're already going to have these changes once #4600 is merged

Sounds good, only thought is it might still be worthwhile to have info in the defer README about how to upgrade an older Remix app to support it?
Even with the new implicit entry files, an older project would still have them explicitly defined and they likely wouldn't be set up for streaming yet.
Even better would be some kind of codemod that would automatically upgrade deps and entry files to support streaming/defer.


Possible WebPack compatibility issue?

Hey folks
I've been using WebPack a lot lately, and I noticed that the Everlive SDK currently causes WebPack to throw a warning...
WARNING in ./app/components/everlive/src/everlive.js
Critical dependencies:
1:207-214 This seem to be a pre-built javascript file. Even while this is possible, it's not recommended.
Try to require to orginal source to get better results.
@ ./app/components/everlive/src/everlive.js 1:207-214

And when run in the browser, Everlive is not defined. This happens without even trying to use Everlive. It looks like the error occurs when WebPack tries to require Everlive in.
I have created a sample project to recreate the issue with just everlive.js. Note that this does NOT happen with reqwest, underscore, rsvp or jstimezonedetect.

Hey there @burkeholland,
I investigated the issue with webpack and it seems that the best approach here is to use the script-loader package. This will execute the script as it would execute it in the browser which will create a global variable Everlive - window.Everlive, which is the equivalent of adding everlive.js with a script tag to your html. I have submitted a pull request so you can see the changes.


Formatting empty properties

In the bicep (vscode) extension, empty properties are currently formatted like this:
resource name 'provider/type@version' = {
  properties: {
    customParameterValues: {
    }
  }
}

It would be nice if bicep extension formatted empty properties like this instead:
resource name 'provider/type@version' = {
  properties: {
    customParameterValues: {}
  }
}

This saves a line.

I think the was the original behavior of the formatter. We need to fix this.


Introduce managed pool for workers

Codecov Report

Merging #344 (e40f5e8) into master (256902c) will decrease coverage by 1.31%.
The diff coverage is 81.37%.

:exclamation: Current head e40f5e8 differs from pull request most recent head e146c25. Consider uploading reports for the commit e146c25 to get more accurate results

@@            Coverage Diff             @@
##           master     #344      +/-   ##
==========================================
- Coverage   57.21%   55.89%   -1.32%
==========================================
  Files         123      124       +1
  Lines        6385     6433      +48
==========================================
- Hits         3653     3596      -57
- Misses       2417     2528     +111
+ Partials      315      309       -6

Flag
Coverage Δ

integration
?

unittests
55.89% <81.37%> (+0.17%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

internal/stream/processor.go
78.48% <78.48%> (ø)

internal/stream/stream.go
87.84% <91.30%> (+1.99%)
:arrow_up:

pkg/messagebroker/kafka.go
18.75% <0.00%> (-22.00%)
:arrow_down:

internal/scheduler/loadbalancealgoimpl.go
75.00% <0.00%> (-6.25%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 256902c...e146c25. Read the comment docs.


Top layer + slurp refocus issues

Hyprland Version
 System/Version info
Hyprland, built from branch makepkg at commit f14c5ea5c56858260c1133d8003fc5961ace373d dirty (groupbar: separate gradients from title (4444)).
Date: Mon Jan 15 15:17:42 2024
Tag: v0.34.0-47-gf14c5ea5

flags: (if any)

Bug or Regression?
Bug
Description
After using slurp and releasing mouse button on top of yambar (can't repro on waybar), the focus does not return to the previous window, instead the window looks like active (border, ...) but does not have keyboard input
This patch removes the issue

diff --git a/src/events/Layers.cpp b/src/events/Layers.cpp
index d6e21d9d..c5e8e8ce 100644
--- a/src/events/Layers.cpp
+++ b/src/events/Layers.cpp
@@ -232,7 +232,7 @@ void Events::listener_unmapLayerSurface(void* owner, void* data) {
         foundSurface = g_pCompositor->vectorToLayerSurface(g_pInputManager->getMouseCoordsInternal(), &PMONITOR->m_aLayerSurfaceLayers[ZWLR_LAYER_SHELL_V1_LAYER_OVERLAY],
                                                            &surfaceCoords, &pFoundLayerSurface);

-        if (!foundSurface)
+        if (!foundSurface && false)
             foundSurface = g_pCompositor->vectorToLayerSurface(g_pInputManager->getMouseCoordsInternal(), &PMONITOR->m_aLayerSurfaceLayers[ZWLR_LAYER_SHELL_V1_LAYER_TOP],
                                                                &surfaceCoords, &pFoundLayerSurface);

How to reproduce
 How to Repro
(I am using follow_mouse = 2 and it likely is required to repro)
Use yambar
(Example config, top layer required (overlay doesn't seem to have the issue))
bar:
  height: 20
  location: top
  background: 000000ff
  layer: bottom

start slurp from a terminal
end selection on top of yambar
terminal looks like focused but doesn't have keyboard focus

Crash reports, logs, images, videos
No response

i have a patch to propose
diff --git a/src/managers/input/InputManager.cpp b/src/managers/input/InputManager.cpp
index 23e183d0..2a05b5b5 100644
--- a/src/managers/input/InputManager.cpp
+++ b/src/managers/input/InputManager.cpp
@@ -1464,6 +1464,11 @@ void CInputManager::refocusLastWindow(CMonitor* pMonitor) {
         const auto PLASTWINDOW = g_pCompositor->m_pLastWindow.lock();
         g_pCompositor->focusWindow(PLASTWINDOW);
     } else {
+        if (foundSurface && pFoundLayerSurface && pFoundLayerSurface->interactivity == 0) {
+            const auto PLASTWINDOW = g_pCompositor->m_pLastWindow.lock();
+            g_pCompositor->focusWindow(PLASTWINDOW);
+        }
+
         // otherwise fall back to a normal refocus.
         refocus();
     }

seems like refocus() will set mouse focus to the surface (yambar)  but keyboard focus is never set because the layer doesn't support keyboard interactivity
is this a proper solution @vaxerski ?

no clue, needs testing. I would say its ok

the patch fixes my problem which i opened the issue as https://github.com/hyprwm/Hyprland/issues/6929

i have a patch to propose
diff --git a/src/managers/input/InputManager.cpp b/src/managers/input/InputManager.cpp
index 23e183d0..2a05b5b5 100644
--- a/src/managers/input/InputManager.cpp
+++ b/src/managers/input/InputManager.cpp
@@ -1464,6 +1464,11 @@ void CInputManager::refocusLastWindow(CMonitor* pMonitor) {
         const auto PLASTWINDOW = g_pCompositor->m_pLastWindow.lock();
         g_pCompositor->focusWindow(PLASTWINDOW);
     } else {
+        if (foundSurface && pFoundLayerSurface && pFoundLayerSurface->interactivity == 0) {
+            const auto PLASTWINDOW = g_pCompositor->m_pLastWindow.lock();
+            g_pCompositor->focusWindow(PLASTWINDOW);
+        }
+
         // otherwise fall back to a normal refocus.
         refocus();
     }

seems like refocus() will set mouse focus to the surface (yambar) but keyboard focus is never set because the layer doesn't support keyboard interactivity is this a proper solution @vaxerski ?

just in case, im talking about this patch and i haven't tried the first one.

isnt this fixed in git

this commit 963816b9a6524a99a6716fa1aa30b2c4f369d2f0 which meant to solve it didn't fix it for me while applying the 2nd patch proposed by @MightyPlaza on top of the commit 963816b9a6524a99a6716fa1aa30b2c4f369d2f0 fixes my problem

isnt this fixed in git

nop from me as well
the other issue seems like a dupe of this one
the mouse is on top of a layer that accepts mouse input but not keyboard input, so keyboard input isn't set in refocus()

odd, it fixed it for me. Anyways, sure.


Jaeger Operator not deploying Jaeger components

I recently noticed that my Jaeger Operator (version 1.14.0) doesn't deploy my Jaeger CRD definition anymore, i.e., no Jaeger components are created (collector, query). However, the Cassandra pods get created, and the Cassandra Schema job get executed.
Having a look into the operator's logs, I can see a lot of lines looking like that:
time="2019-12-05T16:14:53Z" level=error msg="failed to apply the changes" error="failed to handler dependencies: timed out waiting for the condition" execution="2019-12-05 16:12:53.593407803 +0000 UTC" instance=jaeger namespace=tracing

Looking inside the operator's source code, I couldn't find out where this error was coming from. Would you have an idea of what is happening?
I deploy Jaeger Operator with the official Helm chart (version 2.10.2). And here is my Jaeger CRD:
apiVersion: jaegertracing.io/v1
kind: Jaeger
metadata:
  name: jaeger
  labels:
    app.kubernetes.io/name: jaeger
    helm.sh/chart: jaeger-0.1.0
    app.kubernetes.io/instance: jaeger
    app.kubernetes.io/managed-by: Tiller
spec:
  collector:
    image: jaegertracing/jaeger-collector:1.14
    replicas: 1
    resources:
      limits:
        cpu: 1
        memory: 154Mi
      requests:
        cpu: 1
        memory: 128Mi
    tolerations:
      - effect: NoSchedule
        key: CriticalAddonsOnly
        operator: Exists
  ingress:
    enabled: false
  query:
    image: jaegertracing/jaeger-query:1.14
    replicas: 1
    resources:
      limits:
        cpu: 0.1
        memory: 128Mi
      requests:
        cpu: 0.01
        memory: 64Mi
    tolerations:
      - effect: NoSchedule
        key: CriticalAddonsOnly
        operator: Exists
  storage:
    cassandraCreateSchema:
      datacenter: dc1
      mode: test
    options:
      cassandra:
        keyspace: jaeger_v1_dc1
        servers: jaeger-cassandra.tracing.svc.cluster.local
    type: cassandra
  strategy: production

Once created on Kubernetes, it then looks like that (kubectl get jaeger jaeger -o yaml):
apiVersion: jaegertracing.io/v1
kind: Jaeger
metadata:
  creationTimestamp: "2019-12-05T15:35:18Z"
  generation: 2
  labels:
    app.kubernetes.io/instance: jaeger
    app.kubernetes.io/managed-by: Tiller
    app.kubernetes.io/name: jaeger
    helm.sh/chart: jaeger-0.1.0
    jaegertracing.io/operated-by: tracing.jaeger-operator
  name: jaeger
  namespace: tracing
  resourceVersion: "269092844"
  selfLink: /apis/jaegertracing.io/v1/namespaces/tracing/jaegers/jaeger
  uid: d75eeec1-1774-11ea-a962-0a82c62d427e
spec:
  agent:
    options: {}
    resources: {}
  allInOne:
    options: {}
    resources: {}
  collector:
    image: jaegertracing/jaeger-collector:1.14
    options: {}
    replicas: 1
    resources:
      limits:
        cpu: "1"
        memory: 154Mi
      requests:
        cpu: "1"
        memory: 128Mi
    tolerations:
    - effect: NoSchedule
      key: CriticalAddonsOnly
      operator: Exists
  ingester:
    options: {}
    resources: {}
  ingress:
    enabled: false
    openshift: {}
    resources: {}
  query:
    image: jaegertracing/jaeger-query:1.14
    options: {}
    replicas: 1
    resources:
      limits:
        cpu: 100m
        memory: 128Mi
      requests:
        cpu: 10m
        memory: 64Mi
    tolerations:
    - effect: NoSchedule
      key: CriticalAddonsOnly
      operator: Exists
  resources: {}
  sampling:
    options: {}
  storage:
    cassandraCreateSchema:
      datacenter: dc1
      mode: test
    dependencies:
      resources: {}
    elasticsearch:
      storage: {}
    esIndexCleaner:
      resources: {}
    esRollover:
      resources: {}
    options:
      cassandra:
        keyspace: jaeger_v1_dc1
        servers: jaeger-cassandra.tracing.svc.cluster.local
    type: cassandra
  strategy: production
  ui:
    options: {}
status:
  version: ""

@arugifa, this error is being returned from this code:
https://github.com/jaegertracing/jaeger-operator/blob/bfd54b350b5f7b933066bc3c26f4ea6d02d49df7/pkg/controller/jaeger/jaeger_controller.go#L285-L288
And here are the dependencies related to Cassandra:
https://github.com/jaegertracing/jaeger-operator/blob/bfd54b350b5f7b933066bc3c26f4ea6d02d49df7/pkg/storage/cassandra_dependencies.go#L56-L115
The Operator will wait for a success condition from all the dependencies before allowing the remaining of the components to be created. In this case, the condition is the batch job to be in "succeeded" state:
https://github.com/jaegertracing/jaeger-operator/blob/bfd54b350b5f7b933066bc3c26f4ea6d02d49df7/pkg/controller/jaeger/dependencies.go#L98-L104
If you start your operator with the logging set to debug, you should be able to see which specific dependency is blocking the execution. You can set the log level via the --log-level=debug flag here:
https://github.com/jaegertracing/jaeger-operator/blob/bfd54b350b5f7b933066bc3c26f4ea6d02d49df7/deploy/operator.yaml#L23
If you can't figure out why the dependency isn't succeeding, let us know and post both the debug log from the step above, as well as the log from the pod that is being waited for.

Thanks for your quick and detailed answer @jpkrohling 🙌
After activating debug logs on the Operator, I was able to see A LOT of lines like:
time="2019-12-06T16:45:25Z" level=debug msg="Waiting for dependency to complete" name=jaeger-cassandra-schema-job namespace=tracing

Which was making sense after your answer.
I then looked at the logs inside the Cassandra Schema job, and saw lot of errors like:
Traceback (most recent call last):
  File "/usr/bin/cqlsh.py", line 2443, in <module>
    main(*read_options(sys.argv[1:], os.environ))
  File "/usr/bin/cqlsh.py", line 2421, in main
    encoding=options.encoding)
  File "/usr/bin/cqlsh.py", line 485, in __init__
    load_balancing_policy=WhiteListRoundRobinPolicy([self.hostname]),
  File "/usr/share/cassandra/lib/cassandra-driver-internal-only-3.11.0-bb96859b.zip/cassandra-driver-3.11.0-bb96859b/cassandra/policies.py", line 417, in __init__
socket.gaierror: [Errno -2] Name or service not known
Cassandra is still not up at jaeger-cassandra.tracing.svc.cluster.local. Waiting 1 second.

At this point, I noticed that deployment of Jaeger components (collector + query) was SOMETIMES working. And looking into the Cassandra Schema job, I could see the job needed up to 119s to complete:
$ kub describe job jaeger-cassandra-schema-job
Name:                     jaeger-cassandra-schema-job
...
Duration:                 119s
Active Deadline Seconds:  120s
...

My Cassandra nodes seem to need more than 120s to bootstrap sometimes, which is causing the Cassandra Schema job to fail. Which is blocking creation of Jaeger components (as you said).
I see this value is hardcoded:
https://github.com/jaegertracing/jaeger-operator/blob/bfd54b350b5f7b933066bc3c26f4ea6d02d49df7/pkg/storage/cassandra_dependencies.go#L53-L54
I will propose a Pull Request next week to be able to configure this value :)
Thanks again. And have a nice weekend 👍


Ability to change size of Gantt chart

Thanks for this app!
Would be great to define by a setting how many tasks show up. 10 tasks for a heirarchy of tasks isn't big enough. I could fork it and deploy manually but having a dropdown for size or have the ability to autosize to the page would be great!

Hi. Thank you for your feedback.
Exactry, pagination is back userbility. So, I have changed each project shows every tasks on a page.

Oh cool. Also, I fixed passing the config for the gantt chart as the number of pages wasn't passed in correctly. I think it was due to a formatting error in the coffescript file. Have you checked it actually does show all tasks for a project and not the default 7?


net/http: Custom HTTP headers for bad requests (XFO, CSP)

What version of Go are you using (go version)?
go version go1.11 linux/amd64
Does this issue reproduce with the latest release?
Yes, this issue is also present on master.
What operating system and processor architecture are you using (go env)?

GOARCH="amd64"
GOBIN=""
GOCACHE="/home/nono/.cache/go-build"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"
GOPATH="/home/nono/go"
GOPROXY=""
GORACE=""
GOROOT="/nix/store/dana4hagc62f8ylf57rci90d5frgzigk-go-1.11/share/go"
GOTMPDIR=""
GOTOOLDIR="/nix/store/dana4hagc62f8ylf57rci90d5frgzigk-go-1.11/share/go/pkg/tool/linux_amd64"
GCCGO="gccgo"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build734468368=/tmp/go-build -gno-record-gcc-switches"

What did you do?
As explained on https://lab.wallarm.com/how-to-trick-csp-in-letting-you-run-whatever-you-want-73cb5ff428aa?gi=49139effcdd4, it's possible to bypasse Content-Security-Policy by using an iframe to an error page. So, I'd like to add the security headers to all the error pages (X-Frame-Options and Content-Security-Policy). Some HTTP responses are generated by the stdlib and cannot be modified.
What did you expect to see?
I'd have expected to have a way to customize those HTTP responses.
What did you see instead?
It's hard-coded in the stdlib.

/cc @bradfitz

Some HTTP responses are generated by the stdlib and cannot be modified.

Which http responses? Can you be specific?

On 14 Sep 2018, at 18:54, Agniva De Sarker<EMAIL_ADDRESS>wrote:
/cc @bradfitz
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

In the issue, I put a link to https://github.com/golang/go/blob/9f59918cae5eb23fdf0135b77280907365b52069/src/net/http/server.go#L1794-L1817. I'd like to have X-Frame-Options and CSP on all the responses, but some are generated by the stdlib. As I understand, they are 400 Bad request and 431 Request Header Fields Too Large. But I may have missed some others. At least, it is easy to trigger the 400 Bad request with a GET /% from an iframe.

Duplicate of #21548


rename prerendering to building, remove config.kit.prerender.enabled

Follow-up to #7716. This PR makes it possible to add route-level configuration in future that can be used inside adapters to enable things like granular control over things like runtime and region.
It's a breaking change, because it means we need to remove config.kit.prerender.enabled to ensure that it's possible to run the app at build time.
It also renames prerendering to building.
How to migrate
Everywhere where you used prerendering, you now use building - switching the import is enough:
-import { prerendering } from '$app/environment';
+import { building } from '$app/environment';

// ...
-if (prerendering) {
+if(building) {
  // ..
}

If you used config.kit.prerender.enabled, remove that config setting from svelte.config.js:
export default {
  kit: {
    prerender: {
-    enabled: false
    }
  }
}

You likely used config.kit.prerender.enabled so that no code is run during build. Now, if any code should not run during build (for example, connecting to a production database), it can be wrapped in an if block:
+import { building } from '$app/environment';

+if (!building) {
  do_some_setup_work();
+}

You only need to do that for top-level code (in other words code that is executed just by loading the file), things inside load for example are not run during build, unless you opted into prerendering (at which point you expect load to be run).
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

[x] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
[x] This message body should clearly illustrate what problems it solves.
[x] Ideally, include a test that fails without this PR but passes with it.

Tests

[x] Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

[x] If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

How many people have disabled that setting? I guess not many, because it works flawlessly even if you don't prerender anything, except when you do eager db setups, in which case you are probably already doing if (prerendering) {..}? Is there value in having a similar setting so that that you can opt out of build time analysis?

I had disabled it in apps (that I was first porting from Sapper to SvelteKit a year ago), but I don't remember what specific problem I was avoiding by doing so. There aren't any eager database connections I had to avoid. But in any case, it looks like I don't need this configuration anymore, because the apps work fine without disabling it.

I posted a link to the discussion in the two (well-populated) issue threads where this had come up in the past to get maximum visibility. Lots of 👍 reactions — tl;dr is I think we're in the clear. If we need to add some opt-out in future we can consider it but we shouldn't do it defensively

This change is a breaking change that broke a lot of apps, but no explanatory migration procedure is presented, is it possible to have one? I couldn't find my way through this migration.

I updated the PR description with a more descriptive migration guide.

Many thanks man!
I think as the framework is approaching 1.0, it would be helpful to host a releases page somewhere on the website where every new release is announced and any breaking changes or notes explained... This might help.
Thanks again.


Symlinks are broken on Windows

Describe the bug
On this blitz: https://stackblitz.com/github/Nullvoxpopuli/limber?file=packages%2Fcodemirror%2F.prettierrc.cjs
after a pnpm i --ignore-scripts, you can run pnpm lint:fix, which needs to resolve the symlinked .prettierrc.cjs files.
However, on the blitz, they show up as text files with a relative path to the original file.

Link to the blitz that caused the error
https://stackblitz.com/github/Nullvoxpopuli/limber?file=packages%2Fcodemirror%2F.prettierrc.cjs
Steps to reproduce

pnpm i --ignore-scripts
pnpm lint:fix
observe errors from prettier about the config files

Expected behavior
symlinks resolve
Parity with Local

[ ] I have run the project in my local machine and I could not reproduce the issue.

Screenshots
No response
Platform

OS: Windows 11
Browser: Firefox Developer
Version:  112.0b9

Additional context
No response

Hi @NullVoxPopuli !
Thanks for the report! In case that help, you can open this project in CodeFlow and the symlinks are properly created there:
https://stackblitz.com/~/github.com/Nullvoxpopuli/limber


ENH/API: new contracts and conditions for mne.io.meas_info.Info

The recent discussion in #2765 has lead me to discuss with Eric about different ways in which we could improve the Info API to be more clearer. One aspect that maybe was not so clear during the discussion we had over there was the notion of semantic VS code complexity. My idea was that we can have complex implementations but clear APIs that you can quickly conceptualise without exceptions and sub-rules. As it looks now we would have to say:
"our info is like a dict but you cannot use the dict API without constraints, as it has some extra behavior, depending on the keys it will be read only and it requires a subclass of list with reduced API for ch_names"
Maybe it's time to change the API and introduce explictly a new object with simplified semantics
"our info is a read only dict with nice convenience extras, but items cannot be set directly after construction."
it would then allow for a worflow like this:

info_as_dict = dict(info)
info_as_dict['lowpass'] /= 2
info = Info(info_as_dict)

This could then be the internals of a public or private _update method that takes keyword arguments and hence allows for easier consistency and value checking. It could return a copy to be consistent. We could also use the FrozenDict pattern
It would also allow us to implement expose a save method etc.
We could then send a clear message with the release and have a nice documentation that prepares everyone for this backwards incompatible change (without deprecation)
@wmvanvliet @Eric89GXL @jasmainak @agramfort, @jona-sassenhagen ..., ...
Let me know what you think.

@wmvanvliet pointed out in the other thread that we need these to work:
info['bads'] = [...]
info['bads'] += [...]

But I think those are the only direct-write methods that we'd need to support. So we could say it's frozen other than the bads attribute. One advantage to making the bads setting a little bit smarter is that we can do things like emit warnings when bads are added that exist in projs. So we'd get that as an advantage, too.
Are there other usage patterns that wouldn't work making it write-only? I'm not worried about how we modify things internally in private functions (e.g., in set_channel_types), but rather in terms of what users would actually access and set. info['bads'] is all that comes immediately for mind to me.

I think it might also be a good moment to abandon this, it is not very explicit anyways.
Why not have a .set_bads(ch_names) method. Also we could have other setters (that would always return a copy).

Before I can weigh in on this, I need to be educated a little.
Can someone explain to me why some data structures are implemented as dicts (info, forward) and others as full classes (source estimate, montage)? I always thought this was just historical, but @dengemann hinted at deeper reasons of having simple, flat objects. If I were to implement a new datastructure, should it be a dict or a class?

The idea is that dicts are nice general purpose heterogenous data containers. So if the purpose of a class is essentially to contain data we're using dicts. If the class is also there to process data (includig viz), we most of the time don't subclass dicts. I think that's the main distinction.

ok, that makes sense. thanks.

Here are MNE's dict structures:

ConductorModel
Covariance
(_DecodingTime)
Forward
Info
InverseOperator
Projection

Most if not all of them have some consistency requirements. For example, the length of the ch_names field should be the number of rows in the data field. In cases like this, the immutable pattern makes a lot of sense. New objects can be created, but afterwards, never altered. If a value needs altering, you make a new object, optionally using the old object as a template. The main advantage of this approach is that you can always have sane consistency checking.
Making these objects immutable would mean that instead of subclassing dict, they would subclass collections.Mapping. Or alternatively subclass a FrozenDict which we would make ourselves. Any data stored inside the structure would also have to be immutable objects. All primitive types (int, str, float, bool) are immutable, so this mainly means that any dicts will become FrozenDict's and any lists will become tuples. (If we would not do this, things like info['bads'] += 'foo' would still work and bypass the consistency checks.)
Obviously, this would require many small refactorings across our code base.
IMO, the main question we must ask ourselves is how much user script we're going to break with this. How common is it for a user to mess with the values in a dict structure?

I disagree that the subtypes have to be frozen too. My point was to have
clear API pattern instead of write protecting some fields but not others.
On Tue, Feb 9, 2016 at 1:01 PM, Marijn van Vliet<EMAIL_ADDRESS>wrote:

Here are MNE's dict structures:

ConductorModel
Covariance
(_DecodingTime)
Forward
Info
InverseOperator
Projection

Most if not all of them have some consistency requirements. For example,
the length of the ch_names field should be the number of rows in the data
field. In cases like this, the immutable pattern makes a lot of sense. New
objects can be created, but afterwards, never altered. If a value needs
altering, you make a new object, optionally using the old object as a
template. The main advantage of this approach is that you can always have
sane consistency checking.
Making these objects immutable would mean that instead of subclassing dict,
they would subclass collections.Mapping. Or alternatively subclass a
FrozenDict which we would make ourselves. Any data stored inside the
structure would also have to be immutable objects. All primitive types
(int, str, float, bool) are immutable, so this mainly means that any dicts
will become FrozenDict's and any lists will become tuples. (If we would
not do this, things like info['bads'] += 'foo' would still work and
bypass the consistency checks.)
Obviously, this would require many small refactorings across our code base.
IMO, the main question we must ask ourselves is how much user script we're
going to break with this. How common is it for a user to mess with the
values in a dict structure?
—
Reply to this email directly or view it on GitHub
https://github.com/mne-tools/mne-python/issues/2860#issuecomment-181837432
.

in the past dict were converted to object eg to add a nice repr or to
add read/write methods

With this new ChannelNameList the output of raw.info['ch_names'] is quite uninformative + it throws a bunch of warnings for me:
/home/jaakko/anaconda/lib/python2.7/site-packages/IPython/core/formatters.py:92: DeprecationWarning: DisplayFormatter._ipython_display_formatter_default is deprecated: use @default decorator instead.
  def _ipython_display_formatter_default(self):
/home/jaakko/anaconda/lib/python2.7/site-packages/IPython/core/formatters.py:669: DeprecationWarning: PlainTextFormatter._singleton_printers_default is deprecated: use @default decorator instead.
  def _singleton_printers_default(self):
/home/jaakko/anaconda/lib/python2.7/site-packages/IPython/core/formatters.py:672: DeprecationWarning: PlainTextFormatter._type_printers_default is deprecated: use @default decorator instead.
  def _type_printers_default(self):
/home/jaakko/anaconda/lib/python2.7/site-packages/IPython/core/formatters.py:677: DeprecationWarning: PlainTextFormatter._deferred_printers_default is deprecated: use @default decorator instead.
  def _deferred_printers_default(self):
Out[3]: <ChannelNameList | 320 channels | IASX+, IASX-, IASY+, IASY-, IASZ+ ... MEG2642, MEG2643, STI101, SYS101, SYS201>

This should be fixed, unless we decide to roll back.

@jaeilepp how would you like the output to look?

I disagree that the subtypes have to be frozen too. My point was to have clear API pattern instead of write protecting some fields but not others.

These two statements sound contradictory to me. You want all the fields to be write protected, but you only want to do this for Info dicts and not other dicts where it would make just as much sense.

@jaeilepp https://github.com/jaeilepp how would you like the output to
look?

like before :)

You want all the fields to be write protected, but you only want to do this for Info dicts and not other dicts where it would make just as much sense.

I did not comment on that actually. I only talked about the values of that dict that do not have to be frozen necessarily. Well we can just keep the dict API in many other cases or we could also use kind of a frozen pattern.

here is an alternative proposal:
we revert #2765 and keep the dict structures as they are, but we add to each of them a public update method and a private _check_consistency. We make it clear in the docs that the update method is the preferred way to modify the data structure. But we don't strictly enforce this, hence, no existing code is broken at all. If in the future a user doesn't use the update function, it's his/her own fault if things get buggy ;)

That sounds like a reasonable direction. Subclassing the update method would allow us to do all sorts of checking on the fly. And the API pattern would be simple such that we could easily alert users about it in the next release. We could still freeze the __set_item__ methods if that would make us feel safer.

... we could of course also subclass the item setters and issue warnings telling people to use the update method.

since it's difficult to perfectly overwrite item setters perfectly anyway, I'd go for warnings, yes.

could we keep the automatic updating of nchan and ch_names when we call update or use the constructor of Info? It really saves quite a bit of redundant code.

Yes that is the idea. I would say like this it is very clean and simple.

On 09 Feb 2016, at 19:36, Marijn van Vliet<EMAIL_ADDRESS>wrote:
could we keep the automatic updating of nchan and ch_names when we call update or use the constructor of Info? It really saves quite a bit of redundant code.
—
Reply to this email directly or view it on GitHub.

Independently of this we might want to introduce instance.set_bads(ch_names)

On 09 Feb 2016, at 19:36, Marijn van Vliet<EMAIL_ADDRESS>wrote:
could we keep the automatic updating of nchan and ch_names when we call update or use the constructor of Info? It really saves quite a bit of redundant code.
—
Reply to this email directly or view it on GitHub.

Hm ... shouldn't there be, ideally, one, and just one, way of doing something?

in language design and a standard library, yes. But in an analysis package like MNE where a substantial amount of work happens through the REPL? I'm not so sure. Take pandas for example, it has many ways to accomplish the same thing.

and in MNE, we offer multiple paths all over the place. mne.viz.plot_evoked versus evoked.plot anyone?

IMO (and I realize I am more user than developer) these examples are bugs in MNE not features.  Maybe, these are lessons to be learned about how new features should be developed, maybe do a post-mortem, on why these things were done this way to try to help us learn how not to in the future.

Well then, raw.info.update(bads=['EEG010', 'EEG040']) obviously going to be a way to set bad channels. So thats a no for raw.set_bads(['EEG010', 'EEG040']) then?

Yeah that's right. Although an instance based method would be easier to read.
raw.set_bads(ch_names, mode='overwrite'|'append')

On 09 Feb 2016, at 20:21, Marijn van Vliet<EMAIL_ADDRESS>wrote:
Well then, raw.info.update(bads=['EEG010', 'EEG040']) obviously going to be a way to set bad channels. So thats a no for raw.set_bads(['EEG010', 'EEG040']) then?
—
Reply to this email directly or view it on GitHub.

@jaeilepp https://github.com/jaeilepp how would you like the output to
look?

like before :)

Yeah exactly. It used to just print the names.

Shall we go ahead and revert #2765 then?

Shall we go ahead and revert #2765 then?

we would keep the consistency checking but go for warnings on set item and overwriting the update method?

we would keep the consistency checking but go for warnings on set item and overwriting the update method?

That would have my +1. But we can still discuss this further. In the meanwhile, it doesn't seem worth it to continue working on  tweaks to #2765 if we're going to revert it anyway. And if we're going to revert it, maybe do it sooner than later?

@dengemann are you even in favor of revertig?

Welll it's not reverting is it, it is pulling out a few things and exposing them more generally and continuing development on the API issue that was discovered by #2765. Let's just make sure people agree. cc @jaeilepp @agramfort @jasmainak @Eric89GXL ...

@dengemann what is the proposal now? From the issue description it sounds like it is to to make the Info dict frozen, but now it sounds like the discussion has shifted to just making some/more fields read-only...?

what's the summary here? sorry for pitching in so late

The idea was that we should raise for each dict object warning on updating the fields via item setters and implement a controlled .update method that takes care of all consistency checking. No locked fields. Clear documentation on these sort of containers and encouraging the use of the .update method. Keep automatic updates of nchan but no locked keys. Was that it @wmvanvliet ?

yes!

sounds reasonable to me

We should really resolve this one for 0.12 so we don't immediately need to deprecate. @wmvanvliet do you have any time you could dedicate to this in the next week or two?

I'll see what I can do. Any help is appreciated! :)

One thing we could do is more or less revert the changes -- make a single commit that changes it back to deriving from dict. Then we can deal with the more complex solution later. WDYT? If so I might be able to do the first "fix".

@wmvanvliet I assume by the silence that you will be too busy to pursue something comprehensive in the next week or two for 0.12, so I'll go ahead with the revert-like plan tomorrow or the next day unless I hear otherwise.

That would be best. I don't have the time right now to make such an invasive change properly. I will pick this up though :) Maybe for 0.13.

Can we close this one for now unless someone is really interested in enhancing the object?

+1 to close

We can reopen if someone gets motivated again


Issue/47 null state handling (fixed)

Description
I was wrong, a read operation can actually return None, even though we provided a more complete state dict, in the case were the resource can not be found by the provider anymore (if the resource got manually deleted for example).
I fixed it here (along with another error reporting issue) and added a test case for a repair.

This is giving me second thoughts about whether a None response from ImportResourceState should be acceptable or not, maybe we should consider this to simply mean that the resource targeted by the import doesn't exist either.
Something that would help for this would be to add a more complex example (maybe import a non-existing container image and see how it behaves)

Does it hard fail, and provide an error in the diagnostics
Does it soft fail, and simply return a None to say that the image doesn't exist?
If we don't fail there, should be then make sure the id we receive when creating the resource matches the one we expected?

We could definitely use some more complex testing scenarios, I will make this PR a draft and try to add those.
Things our tests should cover:

[ ] Create a non-existing resource (no terraform id)
[ ] Import a non-existing resource (with terraform id)
[x] Update a non-existing resource (no terraform id)
[ ] Update a non-existing resource (with terraform id)
[ ] Delete a non-existing resource (no terraform id)  --> Probably the same as update
[ ] Delete a non-existing resource (with terraform id)  --> Probably the same as update
[ ] ?


Weekly content updates (0716)

:+1:

:tada: This has been pushed live to https://developers.google.com/web/


Draft: Add is_search_domain to DNS results

Caveat here: I don't know what I'm doing in go or terraform providers yet. We're adding a new field in the next release for setting search domains.

No, user set. "canary-1.net.rock.associates" controller would have "rock.associates" set as a DNS name, and would set "is_search_domain": True... then if you used to type http://ip-172-31-3-3.rock.associates you could now type http://ip-172-31-3-3 and the operating system would apply the search domain to the query and resolve to the same AAAA address

Sounds good I asked cause you had computed which means this isn't human editable. That makes sense just allowing more control over the client dns server

I believe this is the complete is_search_domain Support
Haven't tested it yet
https://github.com/chriskuchin/terraform-provider-bowtie/pull/14

Ok Implemented in previous MR


Allow reuse of symbolic factorization

According to the documentation, you can reuse symbolic factorizations. However, performing a numeric factorization on a new matrix with the same sparsity pattern would unconditionally result in a free_symbolic() call as well, resulting in redoing the symbolic factorization.

Thank you! LGTM, but I wonder how to test this. Anyway, I will merge this PR now, as it fixes a faulty behavior.

One more thing. Now free_numeric() does not call free_symbolic(), so in linsolve() replace, please,  free_numeric()  by free() to preserve linsolve()'s behavior.

Good point! I've updated the PR, ready for review :)


Adding static names to the routes to avoid typos

It's great to have static names to the routes. But you were not using when doing navigation. I guess this pr is an improve, since this can prevent typos

That makes sense. Thank you!
Although I also think we could have a routes/route_constants file that lists all the route names as constants and the route file will be imported anywhere navigation is needed. Just so we won't have to import the whole widget file just to use the routeName alone.
Let me know what you think of that but in the meantime, this looks good to me 🎉 .

@all-contributors please add @rodrigobastosv for code

That makes sense. Thank you!
Although I also think we could have a routes/route_constants file that lists all the route names as constants and the route file will be imported anywhere navigation is needed. Just so we won't have to import the whole widget file just to use the routeName alone.
Let me know what you think of that but in the meantime, this looks good to me  .

I totally agree with you. Gonna create a issue for that


Raised Hand .PNG displays in wrong location

Companion Version 3.0.0 (3.0.0+5617-beta-627007a4)
While viewing a Gallery Position page and raising the hand of an attendee, the Attendee Name adjusts to the top-left corner correctly, but the .png raised hand icon displays on a different button.
If another hand is raised, it will refresh the page which moves the 1st png to snap into its proper position, but the png for the 2nd raised hand is in an incorrect position.
Their are several events that trigger a refresh, such as pressing a Stream Deck button, or toggling an attendees video on/off
https://user-images.githubusercontent.com/124208331/216211908-545eeb9b-84f4-48e7-924c-84461b56b445.mp4

I was able to replicate this issue.  I started a meeting on 4 computers:  2 were ZoomOSC Pro attendees, 1 was ZoomISO Pro for gallery tracking, and 1 was Zoom Client.  The Zoom client was the host.  I put ZoomISO in gallery view, pick an attendee that was not position 1, and raised my hand.  The gallery tracking buttons moved the raised hand attendee to position 1 but the raised hand image stayed in the original position of the attendee.

I've seen this happen to me too

I've put in a fix for this, I'll close after testing


SaveIt App: v1.0

In this Project I Built -

Splash screen

A simple page with the name of your app (yes, you need to choose one), and links to the sign up and log in pages.

Sign up and log in pages

The user able to register in the app with full name, email and password (all mandatory).
The user can log into the app using email and password.
If the user is not logged in, they can't access pages that require the user to be logged in (all the pages described below).

Home page (categories page)

When the user logs in, they are presented with the categories page.
For each category, the user can see their name, icon and the total amount of all the transactions that belongs to that category.
When the user clicks (or taps) on a category item, the application navigates to the transactions page for that category.
There is a button "add a new category" at the bottom that brings the user to the page to create a new category.

Transactions page

For a given category, the list of transactions is presented, ordered by the most recent.
At the top of the page the user could see the total amount for the category (sum of all of the amounts of the transactions in that category).
There is a button "add a new transaction" at the bottom that brings the user to the page to create a new transaction.
When the user clicks on the "Back" button (<), the user navigates to the home page.

"Add a new category" page

The user fills out a form to create a new category, indicating their name and icon (both mandatory).
The user clicks (or taps) the "Save" button to create the new category, and is taken to the home page on success.
When the user clicks on the "Back" button (<), the user navigates to the home page.

"Add a new transaction" page

The user fills out a form to create a new transaction with:

name
amount
categories

The user click (or taps) the "Save" button to create the new transaction, and is taken to the transactions page for that category.
When the user clicks on the "Back" button (<), the user navigates to the transactions page for that category.

Create unit and integration tests.

🚀 Live demo here
➡ Video Presentation  here

Status: Invalid 🔴
Hi @ankitt26  🙋♀,
While you made a great effort in this project, unfortunately, I cannot proceed to review your code.
Invalid Code Review Request
You have submitted a project, that does not follow the project guidelines for submitting solo capstone projects. For this milestone the project submission mode should follow Gitflow.
Gitflow submission mode means your PR should be merging a feature branch to the dev branch. This is part of the project requirements, therefore, this pull request cannot be reviewed until a new feature branch is submitted.
Working on solo projects can be done in two ways:

You can work on a single feature branch, and request a review with a PR that compares that feature branch with the development branch (merge feature branch into dev).
Alternatively, you can work on multiple feature branches, merge these branches into one feature branch that consolidates all the changes, and then create a PR for review that compares this branch to the development branch.

Unfortunately, to implement this change you will have to close this branch and create a new feature branch and submit a new review request comparing the new feature branch to the dev branch.

Solution Suggestions [OPTIONAL]
Note: This is just a suggestion, you are not obligated to implement it if it doesn't work for you. You are more than welcome to find your own solution.
**OPTIONAL suggestion 1**: The simplest way to create a new feature branch and still keep your commit history is to (1) rename the dev branch to a feature branch name like budget-app on GitHub, (2) Switch to the main branch locally and pull the changes, (3) Delete the dev branch locally, (4) Create a new dev branch from main and push it, (5) Create a new pull request merging the renamed branch to the new dev branch.
This way you will be able to merge the new renamed feature branch to the new dev branch and still keep your entire commit history.
**OPTIONAL suggestion 2**:
Step 1: From the dev branch, create a new feature branch called budget-app or any branch name of your choice. This will make sure that ALL the commits that are in the dev branch exist in the new branch.
However, our feature branch is currently up to date with the dev branch therefore there are no new changes on the new feature branch to compare to the dev in order to create a new pull request for a merge. Let's fix that.
Step 2: Undo the dev branch commits with git reset to make sure that the dev branch is behind the new feature branch with commits so that there are new changes to compare from the feature branch branch to the dev. Essentially you are just undoing the dev changes so you can merge them again from the feature branch. Remember all your changes are now shipped to the new feature branch therefore you are not going to lose your work.
Step 3: Note that git reset requires you to specify the number of commits you want to undo.

The quickest way to achieve this is the run git rev-list --all --count. This will return the number of all commits merged to the dev branch. Example if the commit count is 31, then run git log -n 30 --pretty=oneline and copy the commit ID of the commit message at the very bottom of the list (the 30th commit), the ID looks like this "503038db18c2f387c3f34cac88f5731018ee4c86".  The reason we not are resetting 30 instead of all 31 commits is because we must leave at least one commit on the dev. Then run git push -f, -f will force the update. We will  now be able to merge your whole commit history form the feature branch to the dev again.

Incase this seems a bit complex here's a simplified version.
Step 1: Run git branch budget-app from dev. Creates new feature branch budget-app.
Step 2: Run git rev-list --all --count. Counts number of commits on dev branch.
Step 3: Run git log -n {number of commits} --pretty=oneline and copy the commit ID of the commit message at the very bottom of the list.
Step 3: Run git reset --hard {commit ID}. Resets all previous commits.
Step 4: Run git push -f. Forces new update on the branch.
That's it, you are done. It's that simple. Now all is left is for you to create a new pull request to merge the new feature branch to the dev again.

Your Code Review Request will be marked as invalid in your Dashboard, so please submit a new one once you are ready 🙏
Cheers 🥂  and Happy coding!!! 👯
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me @KDlamini  in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

Invalid Code Review Request does not count into the code reviews limit.


Update install.rst

fix typo

What do these changes do?

Fix a small typo when I read the documentation.
Related issue number

None

I happen to have a PR which needs to modify the docs, thus I include this typo in it, refer to https://github.com/mars-project/mars/pull/444

I will close this first, welcome to submit other PRs. Thank you.


Update bazel version to 3.0.0 and latest rules

Update bazel to 3.0.0 and fixes a bug where we pass mutable values (dict/list) to depset for env var and launch arguments for tests. Instead we pass tuples to ensure correct data is passed in a safer way.
Added tests on actual project side to ensure they will fail should the passing of the env var and launch arg not done correcetly.
Fixed test case failure due to latest bazel_swift rule update due to adding of modules maps from non-swift code, which is sth we don't anticipate.

@segiddins does it actually check if the generated xcodeproj works? I saw there is a check to see if bazel generates a different xcodeproj file, but it does not actuall test the project. I am at least adding some tests that will fail if I did not do the passing of test env correctly

@segiddins While u continue to review, I am going to test this with our app repo and inform u on what works and what does not

@amberdixon added the CI job in the workflow, can take a look?

waiting for Sam's PR to merge so that I don't add the -Swift.h generated file


" Frontcontroller::init - Cart cannot be loaded or an order has already been placed using this cart "

Hi All.
I am using Prestashop <IP_ADDRESS> and am now opening my second store.
The first store never had any issues with returning the cart status. But the second now doesn't get some things work. I am using Mollie payment module. ( https://github.com/mollie/Prestashop ). The shop is NOT in maintenance mode during the tests.

Order is correctly handled -> Payment is accepted in the order screen
Customer gets screen with 'no final payment status'
Customer gets NO e-mail of confirmation.
SSL is enabled in my first store, I tried to solve this issue in both SSL and without SSL.

I already synchronized all settings of the two webshops, so I do not really know what else can be a solution.
The error in the log is the following:
" Frontcontroller::init - Cart cannot be loaded or an order has already been placed using this cart "
How to solve the issue so the customer gets a confirmation, and the user sees the confirmation screen.
Any help is very welcome!!
Thank you in advance.

+1

+1
The same error in System log

Same here, biggest problem is : no payment confirmation are sent by email for customers ...

Same here, page loading forever (order in BO but no confirmation screen for customer).

In my case it is related to the mail settings. I was using google smtp, which caused issues (don't know why). For a test i set in PS BO in menu "Advanced Parameters > E-mail" the mail settings to "never send emails". Did a test order and confirmation page was there in about 3 seconds. Then I set it to "Use PHP mail function" and since then the issues with confirmation page not loading / mails not sent has been solved.
I keep an eye out if i still get this ordercontroller error.

Same Problem here! Happens on my Prestashop (no confirmation screen) when payment was done with SOFORTÜBERWEISUNG. Does always work with stripe payment service! And I can avoid this problem by clearing the Client Browser Cache!
Using PHP Mailer does also as workaround - but I don’t like to use it because PS runs on hosting provider and therefore I am afraid that mails are caught by spam and/or blacklist filter...
I will also open an Prestashop Case tomorrow.

Same problem here. The faiiling point seems:
if (Validate::isLoadedObject($this->context->cart) && $this->context->cart->OrderExists() == false) {
I am working on an absolutely untouched installation.

As Mollie returns to the shop, a brand new cart number should be set and updated. The frontcontroller checks if an order has already been placed with the cart number as it returns to prestashop. The cart number is still the same because (upon return) no new cart number has been set yet. And therefore, it places a log entry saying the the current cart is already related to an order in the database.
So just before mollie sets the return.tpl template, a new cart number should be created and updated. We have tested this in a new beta version and the abovementioned solves the problem. It will be implemented in the next Mollie update.
We will close this Issue as soon as the update is released.
Regards

Great news!
We are waiting for the update!

Is this issue solved? I have the issue in <IP_ADDRESS> for one client and the other client in 1.7 is running fine absolutely. Can some assist ?

Hi @Dbl0207 yes this issue is solved and the update will be placed on Github very soon. We are currently cleaning up the code and doing the last checks. Could you please contact us at<EMAIL_ADDRESS>We can provide you with a working version with the fix for this problem.
Kind Regards

Same problem but with <IP_ADDRESS> ... not always but seems to be a random error.
I will have to disable emails to clients while I find a way to correct this error or bug. Thankful to advise any update for this matter.

Hi @eltemucano,
We are Mollie's Prestashop partner. Could you contact us at<EMAIL_ADDRESS>and please let us know why you have to disable the e-mails? We will gladly help you out on this matter.
Kind Regards

Hello
I reviewed among the proposals that could avoid that problem and in these
moments I am trying to make my sales and send the mails manually. The issue
is that it does not appear continuously and the message "FrontController"
itself, with the transaction approved or not always registered. This could
result in my store not functioning properly and losing customers. I spoke
with the developer of the plugin for payment with a credit card (TRANSBANK
CHILE) and he told me that he does not register problems of that type for
prestashop. In summary, I should wait for some update to solve this.
Greetings and best regards,
Christian - "Eltemucano".
https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail
Libre
de virus. www.avast.com
https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail
<#DAB4FAD8-2DD7-40BB-A1B8-4E2AA1F9FDF2>
2017-12-28 6:50 GMT-03:00 Trendweb<EMAIL_ADDRESS>
Hi @eltemucano https://github.com/eltemucano,
We are Mollie's Prestashop partner. Could you contact us at
<EMAIL_ADDRESS>and please let us know why you have to disable the
e-mails? We will gladly help you out on this matter.
Kind Regards
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/mollie/PrestaShop/issues/32#issuecomment-354261335,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AdQ9i7lcYk33kuhiEjZZj9kdWEbOI9-yks5tE2R8gaJpZM4LsHlk
.

Hi @eltemucano // Christian,
Thank you for your reply. The reason i asked you to contact us via e-mail, is the fact that there are several different causes for this error. We encountered that a 1 page checkout module was causing problems with the Mollie module and also a different module // override causing this problem. So if you have a simular problem, the update might not suffice. So therefore, please contact us so we can get to the root of the problem and determine where exactly this is comming from.
Kind Regards

This issue has been solved in the latest version of the Mollie module (2.0.0). Therefore we are closing this issue.
Kind Regards


Q3

Hey guys, I can do a stack overflow

podviaznikov deployed to [runnable] 16 hours ago
^
can we link put a link in the "runnable" part?

@prafulrana no, we don't control that. It's the name of the environment. Btw, it can be sandbox, staging. I put runnable for now.


Give full control of persistent cache to embedders

Dream embedder would like to control the contents of persistent cache. Some of the environments they run on are sandboxed with read-only FS (and writable /tmp that gets blown away on restart).
There should be a way to:

Disable the cache (and any disk io for that matter)
Clear the cache
Selectively remove files from the cache (for surgical cleanup for instance).

Can you elaborate on what you mean by "persistent cache"? Do you mean the Skia shader cache?

This one: https://github.com/flutter/engine/blob/015c0246aebc6fc23f30004e3319b6d1e85a885a/shell/common/persistent_cache.cc

This is a cache managed by the engine to store Skia resources.
cc @liyuqian @chinmaygarde @cbracken

Jason and I recently added https://github.com/flutter/engine/pull/7915 and https://github.com/flutter/engine/pull/8049 which allows specifying the persistent cache path and whether it's read-only.
Therefore:

Disabling it should be easy. Points the path to an invalid position would disable it. Now you can also point it to somewhere readonly and only copy the shader caches you needed (which are probably generated during the development on the exact same device and GPU driver) there.
Clear the cache is also easy. Set the path to a position where you have full control. Then clear it any time you want.
We probably won't support "Selectively remove files from the cache" unless there's a legit and critical use case. So far, the only use case that's close to this is to clear the cache of the old engine version when the app is upgraded to a new engine version. This can be done by 2. We can also do this by default and provide an option for opt out the clear-old-version-by-default behavior.

Please let me know if this solves all the concern so we can close this issue.

I believe the APIs you have added are enough. @joaoatgoogle could you please close if this is good enough for Cristi (his github handle is not registered).

Cristi acks that this covers our needs. Thanks!


crypto.dotnet, crypto.pcl, and crypto.pcl2 do not compile

The PCL versions do not compile. The culprit is KCcmBlockCipher.cs -- in PCL, MemoryStreams apparently don't have a GetBuffer() method.

Thanks, I'll take a look.

Fixed in our git. Once the GitHub mirror updates (a day or two) please confirm that it works for you.

The projects themselves compile now, but now crypto.tests.Net45 doesn't; DHTest.cs, SecP256R1FieldTest.cs, and SecP384R1FieldTest.cs complain that Platform, Nat256, and Nat respectively are inaccessible due to their protection level.

You should not need this.... Use the netstandard version in my PR or from https://github.com/onovotny/bc-csharp. That has the current portable code, which builds for netstandard1.0, netstandard1.3, net4 and the legacy portable-net4+sl5+wp8+win8+wpa81 TFM.

All those test references appear to have been removed already, so closing.


[3.1] Drop NS prefix from some files to match the class names

Cherry-picks #971 into swift-3.1-branch.

@swift-ci Please test


adjust default value for createContext example

passing in undefined here throws the following error:
TS2345: Argument of type 'undefined' is not assignable to parameter of type 'App'.

I propose this type cast instead, even though not the most elegant solution, it avoids the error, as the context is already set in initialization of the React context.

I came across the same problem and would suggest another change here.
export const AppContext = React.createContext<App | undefined>(undefined); also works, please take a consider.

If export const AppContext = React.createContext<App | undefined>(undefined); works, I think it's a clearer alternative.

Yeah, those suggestions make sense as well, but then when actually using the useApp hook, App can also be undefined (as defined for the hook) and has to be checked for existence. This line then throws a TS error for me.
Reminds me that for my project, I actually also removed the App | undefined from the definition of useApp, as it is implicitly derived...


EPERM after using Code for a while

VS Code: version 1.18.0 x64 on Windows 10 Enterprise
Steps to Reproduce:

Suddenly after using Code for a while I now get: "Error: EPERM: operation not permitted, open ....html.

I have turned off all antivirus software, checked my firewall settings and permissions on the project folders.
I really love Code and very frustrated.
Any suggestions what further to check?

Reproduces without extensions: Yes

I wonder if this issue is being caused by an installed extension. Can you try to run VS Code without extensions? From the command line (NOT the integrated terminal in Code), execute: code --disable-extensions and try your steps again to see if it reproduces. If you see it is an issue with the extension, please file it against the extension repository itself.

I tried that before submitting the issue. Same behavior.

Can you try to reproduce with our nightly insider builds? You can give our preview releases a try from: https://code.visualstudio.com/insiders/

Benjamin, same behavior but much more output in the console. Log file attached.
v1.19.0 commit 34c44f872c177d6f9439706418f8e49bf125d08
-1511012386028.log

@philr-vistatec could it be a permission issue? E.g. you installed as admin and run as normal user or vice versa?

I don't think so. I am a local Administrator on my laptop. Whilst I get the error in Code I can still simultaneously open the project in other IDE's. Is it normal after launching Code to have so many processes (attached)?

Weird

:-) Does that mean I get a prize?  Any other information I can give you or things I can run to help diagnose?

@philr-vistatec does this only happen when you open HTML files or any file?

All file types. Tried several other things. More oddly I can create a new file in the project that's giving the EPERM errors and happily edit, close, re-open, edit it. Comparing file permissions new file to existing file in Windows Explorer or bash shows exactly the same permissions. At this stage I guess I'll re-create the project in current Code version and slowly copy files from the old project to the new and see how I get on.

It looks like the files you are trying to open have different permissions. Does it reproduce in all folders you try with?

Yes, same behaviour with 4 projects.

@philr-vistatec and the file opens fine using other editor?


Mask passwords in App Manager

I can imagine this would be mostly a trick in the Admin UI - that would be great.
I'm also interested in working on masking the passwords, but even in the database where it eventually resides.
e.g. the WEB-INF/classes/YADA.properties would have 2 new properties:
YADA.index.secured=false|true
YADA.index.encryption-key=some base64 encoded stretch of data of at least 128 bits
the encryption would use a salt to make it safe.
Thinking about this, this would also require a new pre-processor plug-in that forces the encryption on "YADA new query" and "YADA update query".
The way it would do this:

read the YADA_QUERY_CONF.CONF value,
split in lines
for attribute 'encpassword', decrypt the encrypted password, remove the encpassword attribute and add the decpassword attribute with that value
-- ON read for Yada Admin, remove the decpassword attribute and remove the password attribute if there, leave the encpassword for everyone to see
-- ON read for ConnectionFactory, if there is an encpassword attribute, remove it, remove the password attribute if it is there, and rename the decpassword attribute to password, to pass to Hikari.
-- ON write from Yada Admin, if there is a password attribute, encrypt the password value, remove the password attribute, remove the encpassword if it is there and add the encpassword attribute the encrypted password value
-- reassemble the lines into the multiline string that is CONF.
-- the cache and connection factory would still see the 'password' attribute with the decrypted/native value.

That way:

you can start with a db that is not encrypted

you turn on encryption and reboot tomcat

you can continue using the yada server without going through the re-encrypting of the connection passwords

we can later have a tool, but to make these password encrypted, you'd simply go in the Yada admin and key them in again, one by one :(

we can have another plug-in for the conversion of all connections - it would be only working from the properties YADA.index.encryption-key (with the new key) and YADA.index.former-key ...

Why I'm going with this ?
I find it reasonably safe to have passwords in plain text on local files of  a server (context.xml etc) that is well protected.
Obviously not very safe, but reasonable.
I find spreading the passwords to a remote service (such an Oracle server) is rather increasing the weaknesses.
For safety nuts (like me) that acts as the boss of a Yada Adopter, this would provide some comfort...

NX like Jasypt a lot, it would implemented the better part of my suggestion above.

I'm rewriting my comment of April with Jasypt in mind:
I'm also interested in working on masking the passwords, but even in the database where it eventually resides.
e.g. the WEB-INF/classes/YADA.properties would have 2 new properties:
YADA.index.jasypt.encryption=[ one of the jasypt encryption schemes [PBEWITHMD5ANDDES, PBEWITHMD5ANDTRIPLEDES, PBEWITHSHA1ANDDESEDE, PBEWITHSHA1ANDRC2_40] - the default is the first one]
YADA.index.jasypt.encryption-key=the plain text of the encryption key for Jasypt, or the name of an environment variable that is expected to contain the encryption-key
(optionally: YADA.index.jasypt.encryption-iterations= the number of iteration for the encryptor, I think the default is 1000, but better leave it blank :) )
After that, ConnectionFactory::createJdbcDataSource would need to be altered to use some "EncryptableProperties" instead of "Properties"
see http://www.jasypt.org/encrypting-configuration.html section EncryptableProperties
This does not encrypt the password magically, but if a SuperAdmin use the Yada Admin to edit the connection properties of an app, they can use the Jasypt convention to enter the encrypted password. (and even encrypted username) - they have to encrypt it themselves.
So, they'd find something like:
 datasource.driver=com.mysql.jdbc.Driver
 datasource.url=jdbc:mysql://localhost/reportsdb
 datasource.username=reportsUser
 datasource.password=reportsSuck

Use the jasypt command line utility:
./encrypt password=be-shadow input="reportsUser"
./encrypt password=be-shadow input="reportsSuck"
and manually replace the connection details:
 datasource.driver=com.mysql.jdbc.Driver
 datasource.url=jdbc:mysql://localhost/reportsdb
 datasource.username=ENC(Ufin1X1RpoMaZCzw/Cj9cMdhyYeevc37)
 datasource.password=ENC(on+JbHpj5Aq+Z1cZwU/6ciJQJDZ38NLE)

The EncyptableProperties should be decrypting them on the fly when HikariPool uses them.

Added bonus - one could probably easily encrypt with Jasypt's simpler approach in Javascript, in the Yada Admin UI, offering the SuperAdmin the ability to do it there already.
They'll have to be careful to user the right encryption key for their server
This page has the decryption in node.js
https://github.com/Confluex/Zuul/wiki/Encryption
the Crypto module is almost surely easy to bring to the browser.

This request now obsolete in lieu of the following:

YADA supports conventional login security like arbitrary cred store integration, including SAML
YADA issues a JWT at login and validates it on every request
By default YADA passwords are salted and encrypted with argon2
The YADA index is now a git repo not a database


Add long-press on spacebar to change languages

Currently, spacebar has no functionality on long-press, as far as I can work out. When a user has a lot of different keyboards installed it can take a long time to switch to the right one by swiping the spacebar. Please add long-press to the spacebar to bring up a list of activated keyboards to choose from.

The in-built Android Keyboard's response to a long-press on the spacebar is to offer a 'Change keyboard' dialog. This is exactly what I'd like to see implemented in Hacker's Keyboard. I'm not sure whether or not this fits with what CJDennis has in mind. It may well be. In any case, such an enhancement would make me much more likely to switch between keyboards, and thus to use Hacker's Keyboard more often.
For reference, the quickest way I've found to switch back from Hacker's Keyboard to the Android Keyboard is:

long-press the 'microphone' key and release when the settings icon appears
an 'Input options' dialog appears
touch 'Select input method'
select the Android Keyboard

@trevorparsons That's not quite what I had in mind. I have about six different keyboards activated within Hacker's Keyboard, so I need to swipe up to three times if I get the initial direction right, or up to five times if I start by going the wrong way. It would be much easier to long-press the spacebar and see all the different activated languages and then press the specific one you wanted. There could even be a "change to non-Hacker's keyboard" option too.

@Viveur It's necessary to press Fn before you see that key. I didn't even know it existed because I don't use the Fn key-set!

Pada tanggal Rab, 23 Jan 2019 21.47, Simon<EMAIL_ADDRESS>menulis:

Just added a note here as just worked something out and haven't seen it
mentioned anywhere else.
To change keyboards (in order to go back to the AOSP keyboard for example)
just long press the hacker keyboard settings key (circular like icon with a
dot in the middle).
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/klausw/hackerskeyboard/issues/507#issuecomment-456828191,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AeqnBNwOKxaLv2WqQIVkOn5Bg-0o3aGgks5vGHXvgaJpZM4JbIgk
.

@trevorparsons @Viveur @CJDennis
I am still not able to change quickly from hackers keyboard to gboard keyboard.
@trevorparsons your description says:  an 'Input options' dialog appears. I don't get that dialog (android 11, latest hkboard app)
@Viveur @CJDennis Thanks to Dennis for pointing out that Fn keypress needed before the (.) key appears and can be pressed
BUT overall I'm still not able to get via the aformentoned tricks to a quick list of other keyboards to switch to. Can anyone help?


LegacyQuestions stopped working

Some change was done that invalidated the script of LegacyQuestions.
Screenshot is attached.
Thank you for having a look.

Many thanks !!!
This script is the reason that I install Greasemonkey.


first pass implementation

Basic mixin and API plus tests and README.  This implements the
API and is sufficient for an initial version release.
@jcredding ready for review.

@kellyredding - Looks good :boom:


[Improvement] [Master] MDC Logging causing OutOfMemory with TaskRecallProcessor [TaskRecallProcessor#process(Channel channel, Command command)]

Search before asking

[X] I had searched in the issues and found no similar feature requirement.

Description
In the process method of the TaskRecallProcessor, add WorkflowInstanceId 、TaskInstanceId to MDC Context, but only remove WorkflowInstanceId
         try {             LoggerUtils.setWorkflowAndTaskInstanceIDMDC(cmd.getProcessInstanceId(),cmd.getTaskInstanceId());             //........                } finally {             LoggerUtils.removeWorkflowInstanceIdMDC();         }
Use case
No response
Related issues
No response
Are you willing to submit a PR?

[X] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Duplicated with #9860.


Update host pipes tutorial for native implementation

Existing Sample Changes
Description
Update host pipe tutorial to use native host pipes instead of prototype host pipes. This involves updating the include file, source declarations of host pipes, and README documentation. Since there are no BSPs that support native host pipes, also limit the tutorial to IP authoring flow only.
External Dependencies
none
Type of change

[ x] New feature (non-breaking change which adds functionality)

How Has This Been Tested?
Ran locally via command line.

I think you should add a mention in the README about the fact that in order to run this sample on an actual FPGA device, your BSP would need to support host pipes. As there are no commercial BSPs with such support yet, only the IPA flow is enabled

Added. I won't resolve this conversation in case you want the wording or placement changed.


Optimizer results are not used in case of one-to-many relations where just one object is used

Describe the Bug
When you have a one-to-many relation in a model, so either a reverse lookup of a foreign key or a many to many field, the optimizer will prefetch it (good 👍). If the field in GraphQL however is declared as not returning a list or connection but just a single type, then the default resolver will use QuerySet#first / QuerySet#get to get the result, which will bypass the prefetched objects and issue new queries.
Example:
class Project(models.Model):
  name = models.CharField(max_length=255)

class Issue(models.Model)
  project = models.ForeignKey(Project, related_name='issues')

@strawberry_django.type(Issue, name='Issue')
class IssueType:
  id: int

@strawberry_django.type(Project, name='Project')
class ProjectType:
  id: int
  name: str
  latest_issue: IssueType | None = strawberry_django.field(field_name='issues')

@strawberry.type
class Query:
  projects: ListConnectionWithTotalCount[ProjectType] = strawberry_django.connection()

This example seems a bit contrived, however it should show the bug. When querying as follows:
query {
  projects {
    name latestIssue { id }
}

There will be a query for projects (👍), a prefetch-query for issues (👍) and then another query for each project fetching the first issue (🙁).
A fix could look like this, implemented as a custom StrawberryDjangoField subclass here:
class StrawberryDjangoFieldWithFixedPrefetchInSomeCases(StrawberryDjangoField):
    def get_queryset_hook(self, info: Info, **kwargs):
        if self.is_connection or self.is_paginated or self.is_list:
            return super().get_queryset_hook(info, **kwargs)
        elif self.is_optional:
            def qs_hook(qs: QuerySet):  # type: ignore
                qs = self.get_queryset(qs, info, **kwargs)
                if is_optimized_by_prefetching(qs):
                    return next(iter(qs), None)
                else:
                    return qs.first()
            return qs_hook
        else:
            def qs_hook(qs: QuerySet):  # type: ignore
                qs = self.get_queryset(qs, info, **kwargs)
                if is_optimized_by_prefetching(qs):
                    try:
                        return next(iter(qs))
                    except StopIteration:
                        raise qs.model.DoesNotExist(
                            "%s matching query does not exist." % qs.model._meta.object_name
                        )
                else:
                    return qs.get()
            return qs_hook

I will submit a proper pull request if there are no objections.

Upvote & Fund

We're using Polar.sh so you can upvote and help fund this issue.
We receive the funding once the issue is completed & confirmed by you.
Thank you in advance for helping prioritize & fund our backlog.

Hey @diesieben07 ,
I'm just seeing this right now.

I will submit a proper pull request if there are no objections.

PRs are always welcomed! Go ahead :)


Request.Host not set by Microsoft.AspNetCore.TestHost.WebSocketClient

I am using a Microsoft.AspNetCore.TestHost.TestServer to test my application.
Whenever I use TestServer.CreateClient() then HttpClient.PostAsync(), I can see that my controller correctly has the Request.Host property matching TestServer.BaseAddress.
However, when I use TestServer.CreateWebSocketClient() then WebSocketClient.ConnectAsync(), I find that the controller's Request.Host is always null.
This is a problem for me as I try to generate a new url relative to the requested url in the controller using new Uri(Request.GetEncodedUrl()). The call to Request.GetEncodedUrl() returns a url with no host (e,g, "http:///path/here") and new Uri() throws a UriFormatException because there's no hostname.

Good catch, we should be setting that.
Note you can't always rely on the Host header to be present. See https://github.com/aspnet/Hosting/issues/1289