cancel ioctl when future is dropped

Adds a simple scope guard to the ioctl function that cancels the ioctl when the future is dropped before completion.
This way, potentially dangling pointers are removed from the state machine as long as Drop runs.

:rocket:


Update: DeepL.DeepL version <IP_ADDRESS>95

Created by 🥟 Dumplings in workflow run #6949.

Log
The ETag and the hash were changed
Submitting WinGet manifests
Found existing pull requests:
Update: DeepL.DeepL version <IP_ADDRESS>95 - https://github.com/microsoft/winget-pkgs/pull/165090
New version: DeepL.DeepL version <IP_ADDRESS>95 - https://github.com/microsoft/winget-pkgs/pull/164207
This task is configured to ignore existing pull requests
Creating manifests
Uploading manifests and making commits
Creating a pull request

Microsoft Reviewers: Open in CodeFlow

/azp run

@spectopo,
This PR seems to change no files. Is this expected?


Fix issue: 162 (typo)

Fix for issue: https://github.com/ROCm/rocm_smi_lib/issues/162
There is a difference in argument types between declaration and definition.
This made the function unusable.
Files affected:

rocm_smi.h

great catch! thanks. I'll merge it internally and get pushed out to github shortly.

also, your work on https://github.com/PTFOPlayer/rocm_smi_lib_rs is exciting!

also, your work on https://github.com/PTFOPlayer/rocm_smi_lib_rs is exciting!

Thanks!
I'm really glad that whoever created this API noticed my Rust adaptation.

Accepted in https://github.com/ROCm/rocm_smi_lib/commit/54af22ca614a9349b6a02cfff691501f19365dda


Connecting SAP Hana with TM1Py

Hello,
Can anyone be experienced to take data from SAP webservice to TM1 with Tm1py?
Could TM1Py be able to do this?
I have a work to take data from SAP.
Regards.

You are looking for a way to connect Python with SAP's backend. This has nothing to do with TM1py.
I do not actual experience with connecting to SAP, but the below link has step by step procedure to connect (looks promising):
https://blogs.sap.com/2020/06/09/connecting-python-with-sap-step-by-step-guide/
Once you have got the data out of SAP, use TM1py to load it into TM1.


[Feature] Add list for generated stories

Is your feature request related to a problem? Please describe.
This web app doesn't have a list of generated stories.
Describe the solution you'd like
Would be nice to have a list under the generator to contain all the generated stories.
The user should be able to delete any of the generated stories from the list.
Local storage can be used to save and retrieve the generated stories.
When the user clicks on any of the saved stories it should appear in the generator.

Can you assign to me please? I would like to do this issue


Access to folder

Keybase GUI Version: 4.4.0-20190829183920+8f13068775
My log ID is:
a2a2801b308766ff8719ea1c
Hi I can't access my keybase folder, neither on the finder nor directly in the app (through my mac). I still have access to the docs on my mobile.
While trying to access my docs through the finder I get this error:
The folder “Keybase (gregoirenedelec)” can’t be opened because you don’t have permission to see its contents.
and on the keybase app:
an unexplainable error occured
Failed to load TLF list
Error: ERROR CODE 218 - Keybase services aren't running - KBFS client not found. in method keybase.1.SimpleFS.simpleFSSyncStatus at new s (file:///Applications/Keybase.app/Contents/Resources/app/desktop/dist/main.bundle.js:1:561326) at file:///Applications/Keybase.app/Contents/Resources/app/desktop/dist/main.bundle.js:1:561922 at u (file:///Applications/Keybase.app/Contents/Resources/app/desktop/dist/main.bundle.js:1:561961) at file:///Applications/Keybase.app/Contents/Resources/app/desktop/dist/main.bundle.js:1:1242674 at file:///Applications/Keybase.app/Contents/Resources/app/desktop/dist/main.bundle.js:1:3018547 at e._call (file:///Applications/Keybase.app/Contents/Resources/app/desktop/dist/main.bundle.js:1:2580383) at file:///Applications/Keybase.app/Contents/Resources/app/desktop/dist/main.bundle.js:1:2580523 at s (file:///Applications/Keybase.app/Contents/Resources/app/desktop/dist/main.bundle.js:1:2580163) at e._fulfill (file:///Applications/Keybase.app/Contents/Resources/app/desktop/dist/main.bundle.js:1:2580493) at (file:///Applications/Keybase.app/Contents/Resources/app/desktop/dist/main.bundle.js:1:2579694)
Any help would be welcome!

cc @strib

Hi @MyC-Greg, thanks for the report.  It looks like you've uncovered a looping crasher bug in the KBFS code. I need to investigate more how this happened, but in the meantime I think you can recover it with the following steps.  However, this will rewind your local view of a team folder that you've recently written to (data that you wrote but hasn't yet been saved on our servers yey, so no other team members have seen it).  If you can't recover this data from elsewhere on your system, let me know and I can work with you to recover it from the backup folder made by the steps below.
Here's what to do:

Stop the Keybase app completely.
Run this command from a terminal:

mv "$HOME/Library/Application Support/Keybase/kbfs_journal/v1/012066403ca721b8a42b5699a3c5ae4d20cd-fb7600b43fd927fe" "$HOME/Library/Application Support/Keybase/kbfs_journal/v1/fb7600b43fd927fe.bkp"

Re-launch the Keybase app.

Let me know if that seems to fix it for you.  I'll look into what caused the problem in the first place.

Hi @strib , the hack works fine with me, I have access to my folders both in the keybase app and through the finder. Thanks!


Addr:place with openstreetmap

Hi,
I noticed the following. I used the following german address:
Place: Bernheck
Housenumber: 19a
Postacl Code: 91287
City: Plech
Country: DE
Expectation is:
City: Plech  not Bernheck
Desired expectation:
Street: Bernheck
instead of not having a street type in the returned Place object.
https://www.openstreetmap.org/way/416917744#map=17/49.667121/11.487730
The geocoder returns a Place which uses the addr:place, i.e. Bernheck, as the city. I think this should be Plech. And the place needs to be skipped somehow. However doing a search using  19a 91287 Plech yields nothing, Bernheck 19a 91287 Plech yields a Place .
OpenStreetMap for this address:  https://www.openstreetmap.org/way/416917744#map=17/49.667121/11.487730
Google Maps does the following for this address:  https://www.google.com/maps/place/Bernheck+19,+91287+Plech,+Germany/
and uses the addr:place as the street.
OSM documentation suggests that the addr:place should not be used as street, however you still need to add Bernheck on the search query in order to get a valid Place. Documentation: https://wiki.openstreetmap.org/wiki/Key:addr:place?uselang=en
What are your thoughts on this by normalizing the addr:place onto the street type for the library.
Regards,

Hi @morrowyn
thanks for reaching out!
I understand your expectation about the correct address in your example, however I'm not sure how to approach this.
The data we get from the OSM-API (Nominatim) for your example does not contain any hint for Plech:
https://nominatim.openstreetmap.org/lookup?format=xml&accept-language=en&addressdetails=1&osm_ids=W416917744
<searchresults timestamp="Fri, 13 Sep 2024 06:11:43 +00:00" attribution="Data © OpenStreetMap contributors, ODbL 1.0. http://osm.org/copyright" querystring="">
  <place place_id="109795885" osm_type="way" osm_id="416917744" ref="Gasthof Seitz" lat="49.6671587" lon="11.4868213" boundingbox="49.6670776,49.6672511,11.4866198,11.4870228" place_rank="30" address_rank="30" display_name="Gasthof Seitz, 17, Bernheck, Plech, Betzenstein (VGem), Landkreis Bayreuth, Bavaria, 91287, Germany" class="amenity" type="restaurant" importance="9.99999999995449e-06">
    <amenity>Gasthof Seitz</amenity>
    <house_number>17</house_number>
    <village>Bernheck</village>
    <municipality>Betzenstein (VGem)</municipality>
    <county>Landkreis Bayreuth</county>
    <state>Bavaria</state>
    <ISO3166-2-lvl4>DE-BY</ISO3166-2-lvl4>
    <postcode>91287</postcode>
    <country>Germany</country>
    <country_code>de</country_code>
  </place>
</searchresults>

So if you have any idea how we could improve the implementation I'll be happy for suggestions!


No zotero plugin xpi file available to download so unable to use plugin

Apologies if this is noob but in the Docs -> Getting Started -> Installation -> Zotero Plugin, it asks users to download zotero-obsidian-note-*.xpi either from the Obsidian-note | latest link (broken) or from the Github Releases page (xpi missing) resulting in no apparent way to use the plugin.
Version: latest Zotero 7-beta
Many thanks in advance and warmest regards

You can find it via the zt tag: https://github.com/PKM-er/obsidian-zotlit/releases/tag/zt1.0.1


Added infrastructure to bundle up certificates

Summary
Added three Optimizely public certificates

cdn.optimizely.com
logx.optimizely.com
api.optimizely.com

Updated Copy Bundle Phase of for OptimizelySDKCore.podspec to bumdle the three certficates
Updated the PodSpec for Cocoapods to create a bundled resource
As part of our security policy we need to confirm the server trust for every network call that originates from our application to prevent man in the middle attacks or spying. For Earnin to add an internal patch while being able to pull from the upstream, we need to bundle infrastructure to be set in place
Test plan
Make a build and confirm that the certificates are bundled in the bundle resources create for OPtimizelySDKCoreiOS

Coverage remained the same at 98.153% when pulling 6fab3cbeb97abc6434e76eb83df77b16c8ab6e12 on earnin-pinning-prep into df0c7f80aa8015cd133abbe3a6c46e7ed844c17e on master.

Coverage remained the same at 98.153% when pulling 6fab3cbeb97abc6434e76eb83df77b16c8ab6e12 on earnin-pinning-prep into df0c7f80aa8015cd133abbe3a6c46e7ed844c17e on master.


Regarding custom styling Material component via scss

Hello team,
my question is without using any withStyle feature. if I am importing styles from scss file within react component, that style property is not getting applied since they are with low importance
then how to override the styles of material-ui
I know there are many such issues discussed but none of them is giving any clear idea
And i need a combination of scss and react component

You need to change the JSS injection point - it’s covered in the docs. I’d link you there but I’m on mobile.


Missing type definitions

This package has no type definitions, which makes it hard to use with typescript. This is the type definition file that I used for one of our projects, and it seems to work well:
declare module 'utf8x2x' {
    export type CodePointHandler = (byte: number) => void;
    export function Utf8b2c<End>(next: {
        codePoint: CodePointHandler;
        end?: () => End;
    }): {
        byte: (byte: number) => void,
        end: () => End,
    };
    export function Utf8bs2c<End>(next: {
        codePoint: CodePointHandler;
        end?: () => End;
    }): {
        bytes: (bytes: Iterable<number>) => void,
        end: () => End,
    };
    export function Utf8c2b<End>(next: {
        byte: (byte: number) => void;
        end?: () => End;
    }): {
        codePoint: CodePointHandler,
        end: () => End,
    };
    export function Utf8c2bs<End>(next: {
        bytes: (bytes: Iterable<number>) => void;
        end?: () => End;
    }): {
        codePoint: CodePointHandler,
        end: () => End,
    };
}

Good idea. Added similar type definitions and tagged as 0.2.3: https://github.com/xtao-org/utf8x2x/releases/tag/v0.2.3
Perhaps it would be nice to make this into a proper npm package, but I'll create another issue for that.
Closing this one as resolved.
Cheerio!


Various changes

This PR accumulates many refactorings and small improvements that I did while preparing the next change set of https://github.com/druid-io/druid/projects/2. I finally decided to make them a separate PR to minimize the volume of the main PR.
Some of the changes:

Renamed confusing "Generic Column" term to "Numeric Column" (what it actually implies) in many class names.
Renamed GenericColumnSerializer to just ColumnSerializer and changed the signature of it's serialize() method. This class was annotated @ExtensionPoint, however it doesn't look so to me. @gianm could you please review?
Generified ComplexMetricExtractor
Fixed a potential bug in SingleStringInputDimensionSelector, it might incorrectly report that name lookup is possible in advance on it.

@nishantmonu51 FYI I've tried to fix #5956 opportunistically in this PR, but a lot of tests started to fail. So I reverted.

Hi, @leventov . Already created a small PR #5980 to supplement the current PR. If u think it's necessary, then I will create a series of PRs to make it more complete.

@leventov : can we finish up the review and merge https://github.com/apache/incubator-druid/pull/5958 before making any more major refactorings ?

@nishantmonu51 we can (however it will take several more weeks), but you could review this PR in parallel?

Renamed GenericColumnSerializer to just ColumnSerializer and changed the signature of it's serialize() method. This class was annotated @ExtensionPoint, however it doesn't look so to me.

It is extensible when someone writes a custom aggreagtor and extension wants to take control of full column serialization instead default behavior where extension writer only controls serialization of individual row values by providing a ObjectStrategy.
We do have few aggregators (not in the open source) that take advantage of it.

@himanshug thanks. It should be said in ColumnSerializer javadoc, could you please add?

@leventov please feel free to add the doc in this PR itself, not a major change to require new PR. It
should be along the lines of ....
ColumnSerializer can be implemented in custom aggregator extensions that would like to take full control of column serialization. That would implementation would be returned by overriding ComplexMetricsSerde.getSerializer(..).

@nishantmonu51 please review this PR

@nishantmonu51 could you continue review?

@nishantmonu51 thanks for review. I've occasionally run Optimize Imports (well, I wanted to do this in IntelliJ. But I thought it will run only on the affected files, not on the whole codebase.) so now the change seems to be much bigger than it used to be. But all extra changes are just mechanical import changes.

@nishantmonu51 the PR passed Travis. Last 11 commits are about combating unrelated transient test failures.

@nishantmonu51 could you please take a look?

@nishantmonu51 @gianm could we finish off this PR? Given it effectively has three approvals for three weeks, and still not merged?

I haven't had a chance to review the entire thing yet, beyond the partial review I did in https://github.com/apache/incubator-druid/pull/5957#pullrequestreview-142270140. Please don't consider me as blocking this PR, just not yet having the opportunity to review it in full.
By way of explanation as to why: I can't speak for everyone, but personally I am prioritizing my time towards reviewing PRs that make functional changes (which we are getting a lot of!) vs. ones that are refactorings/cleanups. Doesn't mean I'll never get to it, but hopefully that explains why I haven't yet. I understand this is a dev blocker for you, so I guess all I can say to that is, I would suggest avoiding making functional changes dependent on large nonfunctional ones.

I think this PR should be looked at in 0.13.1

I think the PR should be broken into multiple PRs to make it much easier to review. The impact of breaking changes in such a significant PR impacting so many files is high. Furthermore, I'd like to see each separate PR comprehensively describe what was changed, and what the benefit was. I'm moving the milestone to 0.13.1 for now so give us enough time to properly review this PR.

Is this still "Incompatible"?

The test failures look legit (although are not a big deal) and are related to the renaming of HLLCV1. I don't think it's important that the value stay the same, so I think updating the tests is fine.
Failed tests:
org.apache.druid.sql.calcite.http.SqlResourceTest.testCsvResultFormat(org.apache.druid.sql.calcite.http.SqlResourceTest)
  Run 1: SqlResourceTest.testCsvResultFormat:500 expected:<[2000-01-01T00:00:00.000Z,1,,a,1.0,1.0,org.apache.druid.hll.HLLCV1,, 2000-01-02T00:00:00.000Z,1,10.1,,2.0,2.0,org.apache.druid.hll.HLLCV1,, , ]> but was:<[2000-01-01T00:00:00.000Z,1,,a,1.0,1.0,org.apache.druid.hll.VersionOneHyperLogLogCollector,, 2000-01-02T00:00:00.000Z,1,10.1,,2.0,2.0,org.apache.druid.hll.VersionOneHyperLogLogCollector,, , ]>
  Run 2: SqlResourceTest.testCsvResultFormat:500 expected:<[2000-01-01T00:00:00.000Z,1,,a,1.0,1.0,org.apache.druid.hll.HLLCV1,, 2000-01-02T00:00:00.000Z,1,10.1,,2.0,2.0,org.apache.druid.hll.HLLCV1,, , ]> but was:<[2000-01-01T00:00:00.000Z,1,,a,1.0,1.0,org.apache.druid.hll.VersionOneHyperLogLogCollector,, 2000-01-02T00:00:00.000Z,1,10.1,,2.0,2.0,org.apache.druid.hll.VersionOneHyperLogLogCollector,, , ]>
  Run 3: SqlResourceTest.testCsvResultFormat:500 expected:<[2000-01-01T00:00:00.000Z,1,,a,1.0,1.0,org.apache.druid.hll.HLLCV1,, 2000-01-02T00:00:00.000Z,1,10.1,,2.0,2.0,org.apache.druid.hll.HLLCV1,, , ]> but was:<[2000-01-01T00:00:00.000Z,1,,a,1.0,1.0,org.apache.druid.hll.VersionOneHyperLogLogCollector,, 2000-01-02T00:00:00.000Z,1,10.1,,2.0,2.0,org.apache.druid.hll.VersionOneHyperLogLogCollector,, , ]>
  Run 4: SqlResourceTest.testCsvResultFormat:500 expected:<[2000-01-01T00:00:00.000Z,1,,a,1.0,1.0,org.apache.druid.hll.HLLCV1,, 2000-01-02T00:00:00.000Z,1,10.1,,2.0,2.0,org.apache.druid.hll.HLLCV1,, , ]> but was:<[2000-01-01T00:00:00.000Z,1,,a,1.0,1.0,org.apache.druid.hll.VersionOneHyperLogLogCollector,, 2000-01-02T00:00:00.000Z,1,10.1,,2.0,2.0,org.apache.druid.hll.VersionOneHyperLogLogCollector,, , ]>

@gianm thanks a lot for review and the suggestions - I'll account in future PRs.


python312Packages.walrus: 0.9.3 -> 0.9.4

Diff: https://github.com/coleifer/walrus/compare/refs/tags/0.9.3...0.9.4
Changelog: https://github.com/coleifer/walrus/blob/0.9.4/CHANGELOG.md

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 352413

x86_64-linux

:white_check_mark: 4 packages built:

python311Packages.walrus
python311Packages.walrus.dist
python312Packages.walrus
python312Packages.walrus.dist


Add Share Event Functionality to My Dashboard

In the actions for each upcoming event, allow the user to share a link... see the event details page for what the share functionality currently does.

@joebeernink , I noticed that "Share" button available on eventdetails page for both upcoming and completed events. However, it shows "upcoming event" when sharing as below.

I think the "Share" function should have same availbility on mydashboard and eventdetails page, and 2 ways to implement:

Available for upcoming and completed events both. In this case, people can share their accomplishment after attended or organized an event. We need one picture for completed event to share.
Available for upcoming events only. The "Share" button needs to be disabled in eventdetails page for completed events.

Which way you perfer?

issue fixed with pull request #1138


Add to playlist and queue icons for music player app

Add to playlist and queue icons for music player app

Added music-notes-plus in v1.4.0! And list-plus should fit for the queue 👍


Is the PPO2 optimization synchronous or asynchronous between the different agents ?

Hi,
about the optimization strategy for PPO2, do you know if Is the optimization process is synchronous or asynchronous between the different agents?
Thank you for your help.

PPO is on-policy. The network updates are synchronous, however not all the env.'s may have been used. The ppo2 implementation collects samples until it can fill a minibatch. The order of filling is determined beforehand by doing random slices of the env. index list. When all the env.'s have been used a new index list is generated.
All the samples are generated with the most updated network, no network copies are used. No env. steps are taken while updating the network.
For the sequential (ie: lstm) case this means that you need to fill a fixed number of steps per env. per minibatch. This requires the minibatch size to be divisible by the bptt length. The algorithm will alternate groups of env.'s and fill the minibatch acordingly. The sequential code is much more involved since you also need to keep track of the lstm states.
I hope this is accurate with the current code since I haven't checked it in a while.
I recommend you to step the code with a debugger in both (sequential and nonsequential) cases.
Regards.

Thanks for ansering @pisiiki !


[WIP] raftstore: renew lease in raft tick

Signed-off-by: 5kbpers<EMAIL_ADDRESS>
What have you changed?
Currently, the read lease of a leader is renewed after proposing a write or executing a read request with read index.
In some situations, a client may always try to read data after the read lease expired, read requests would be handled with read index, then the duration of read request could be higher than expected.
This PR tries to solve this problem by renewing the read lease in raft tick.
What is the type of the changes?

Improvement (a change which is an improvement to an existing feature)

How is the PR tested?

Unit test
Integration test
Manual test (add detailed scripts or steps below)

Does this PR affect documentation (docs) or should it be mentioned in the release notes?
No.
Does this PR affect tidb-ansible?
No.

/bench


[BUG] Validation's ignore rules are not being rendered

I would expect to see in the docs “Request Body Parameters” section to mention the ignore rules applied.
return [
'name' => 'required_without:title|max:255|'.Rule::unique(Role::class, 'name')->ignore($this->route('roleId')),
'title' => 'required_without:name|max:255|'.Rule::unique(Role::class, 'title')->ignore($this->route('roleId')),
];

hmm it is difficult to implement that. Sorry.


Updating lang on client-side navigation

The user may change the lang setting per-page based on i18n. On client-side navigation, onRenderClient should adapt lang in the existing DOM.
CC @phonzammi
If no one objects, we should duplicate this issue to other Vike extensions.

👍 Makes sense.

Yes, I think your idea is better.
FYI, my idea was to add an optional attribute to the a href link, like reload?: boolean.

Choose Lang

Indonesia
English

Then the link will behave like default (not intercepted by vike routing), navigation will be server routed


Fix inaccurate Pulsar and Bookkeeper metrics

[x] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #.
[x] Update the CHANGES log.

Please attach the screen-shoots when you update the UI templates

Here is an illegal expression, please fix it as well, thanks.
https://github.com/apache/skywalking/blob/a38628fced0a6f678df188799b60c29c0507bc02/oap-server/server-starter/src/main/resources/ui-initialized-templates/pulsar/pulsar-broker.json#L85

On the Pulsar-Broker dashboard, why some of the metrics only have 1 datapoint value?

suggest adding label in metricConfig for all of the dashboards, otherwise, the MQE expression would show on the weight directly.

It is related to my test code, I now change it to multiple test programs.

bookkeeper-cluster


Runnning multiple instance of workflow on slurm causes  Denial-of-Service

Snakemake version
7.32.4
Running multiple instance of snakemake on slurm using --slurm hangs the workflow for hours with no respite
I have to run a workflow on 1000 samples individually runnnig it with slurm causes ddos on the slurm controller is there a workaround for this

You can restrict the number of jobs in the queue via --jobs. The number depends on what your cluster is capable to handle. Also consider using Snakemake >=8, where the cli changes slightly.


add # students 5-17 years old as a demographics filter variable

add # students 5-17 years old as a demographics filter variable (in the left sidebar in the tabs)

working on this now

done!


Scala Common Enrich: X-Forwarded-For extractor

Store all X-Forwarded-For elements in a JSON Schema as an array.

Migrated to https://github.com/snowplow/enrich/issues/184


fix/ Fixed Gramatical Error

Added a full stop to the code where needed

Pre-Submission Checklist

[x] Your pull request targets the staging branch of freeCodeCamp.
[x] Branch starts with either fix/, feature/, or translate/ (e.g. fix/signin-issue)
[x] You have only one commit (if not, squash them into one commit).
[x] All new and existing tests pass the command npm test. Use git commit --amend to amend any fixes.

Type of Change

[x] Small bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds new functionality)
[ ] Breaking change (fix or feature that would change existing functionality)
[ ] Add new translation (feature adding new translations)

Checklist:

[x] Tested changes locally.
[x] Addressed currently open issue (replace XXXXX with an issue no in next line)

Closes #XXXXX
Description

Changed the title of the pull request to start with /fix

Hi @The-IT-Geek
Thanks for the PR - I'm not with FCC so can't review it - just note that the pull request title doesn't need to start with /fix - your branch name should (at the moment it is "The-IT-Geek:patch-1").
I suspect this may be because you used Github's online editor, which is not advised by FCC due to your inability to update the patch via the interface without deleting and recreating your fork.
You will likely find the CONTRIBUTING.md file useful.

Thanks @akkatracker for the clarifications.
@The-IT-Geek Thanks for the PR, could you please make a fresh PR if interested.


Reproducing evaluation results

Hi!  I've run your eval bash file for all models with the checkpoint files that I downloaded from the link in the Readme, but the results are very different from the ones mentioned in your paper.
 Because I would love to use your INN, but of course would need a better accuracy than what I am getting now.

Hello, I wonder if you know how to solve this problem.

I know this is an old issue and its possible the repo is no longer being maintained, however I am getting the same low performance results for the downloaded checkpoints (36.948% for beta_32).
Is there any update on the discrepancy?

I am also getting the same issue.
Conda (23.1.0) Environment:

torch==1.7.1
FrEIA at tag v0.2
Python 3.9.18


EG about sharing dir btw host and container

Very basic example is lacking here about how to share a directory and where it appears so added the example
docker run -it -v ~/Desktop:/Desktop r-base bash
and demonstrating it with bash.

Proposed changes
The current docs are very inaccessible, simple demos missing about how to share the host directories with the containers.
Unreleased project version (optional)

Related issues (optional)

Ping?

@justincormack @rneugeba can you guys review this? I'll look at it also, but please have a look.

LGTM, going to go ahead and merge this.


can you please share train.json

i could not get trainjson in google drive hence requesting for train.json

please ignore i got the files


Create bucket fails however the noobaa-db database lists

Environment info

NooBaa Version: VERSION
Platform: Kubernetes 1.14.1 | minikube 1.1.1 | OpenShift 4.1 | other: specify

OCP 4.9.5
Noobaa d/s 4.9.0 RC4 or RC5 build
noobaa status
INFO[0000] CLI version: 5.9.0
INFO[0000] noobaa-image: quay.io/rhceph-dev/mcg-core@sha256:6ce2ddee7aff6a0e768fce523a77c998e1e48e25d227f93843d195d65ebb81b9
INFO[0000] operator-image: quay.io/rhceph-dev/mcg-operator@sha256:cc293c7fe0fdfe3812f9d1af30b6f9c59e97d00c4727c4463a5b9d3429f4278e
INFO[0000] noobaa-db-image: registry.redhat.io/rhel8/postgresql-12@sha256:b3e5b7bc6acd6422f928242d026171bcbed40ab644a2524c84e8ccb4b1ac48ff
INFO[0000] Namespace: openshift-storage
Creation of bucket fails from App node as per s3 mb command, however the noobaa db stores it and visible on multiple other tools like noobaa bucket list etc
Actual behavior
Step 1:
[root@rkomandu-app-node1 ~]# s3u5001 ls s3://
urllib3/connectionpool.py:1013: InsecureRequestWarning: Unverified HTTPS request is being made to host '<IP_ADDRESS>'. Adding certificate verification is strongly advised. See: https://urllib3.readthedocs.io/en/latest/advanced-usage.html#ssl-warnings
2022-01-17 21:20:42 new-bucket-06jan
2022-01-17 21:20:42 new-bucket-user2-06jan
2022-01-17 21:20:42 new-bucket-5003-07jan
2022-01-17 21:20:42 newbucket-temp-1
2022-01-17 21:20:42 user-5001-bucket
2022-01-17 21:20:42 user-5002-bucket
2022-01-17 21:20:42 user-5003-bucket
[root@rkomandu-app-node1 ~]# s3u5001 mb s3://newbukcet-18jan   --> This is failing
urllib3/connectionpool.py:1013: InsecureRequestWarning: Unverified HTTPS request is being made to host '<IP_ADDRESS>'. Adding certificate verification is strongly advised. See: https://urllib3.readthedocs.io/en/latest/advanced-usage.html#ssl-warnings
urllib3/connectionpool.py:1013: InsecureRequestWarning: Unverified HTTPS request is being made to host '<IP_ADDRESS>'. Adding certificate verification is strongly advised. See: https://urllib3.readthedocs.io/en/latest/advanced-usage.html#ssl-warnings
urllib3/connectionpool.py:1013: InsecureRequestWarning: Unverified HTTPS request is being made to host '<IP_ADDRESS>'. Adding certificate verification is strongly advised. See: https://urllib3.readthedocs.io/en/latest/advanced-usage.html#ssl-warnings
make_bucket failed: s3://newbukcet-18jan Read timeout on endpoint URL: "https://<IP_ADDRESS>/newbukcet-18jan"
[root@rkomandu-app-node1 ~]# s3u5001 ls s3://
urllib3/connectionpool.py:1013: InsecureRequestWarning: Unverified HTTPS request is being made to host '<IP_ADDRESS>'. Adding certificate verification is strongly advised. See: https://urllib3.readthedocs.io/en/latest/advanced-usage.html#ssl-warnings
2022-01-17 21:24:44 new-bucket-06jan
2022-01-17 21:24:44 new-bucket-user2-06jan
2022-01-17 21:24:44 new-bucket-5003-07jan
2022-01-17 21:24:44 newbucket-temp-1
2022-01-17 21:24:44 user-5001-bucket
2022-01-17 21:24:44 user-5002-bucket
2022-01-17 21:24:44 user-5003-bucket
Step 2:
NAME                                               READY   STATUS    RESTARTS         AGE     IP              NODE                                  NOMINATED
NODE   READINESS GATES
noobaa-core-0                                      1/1     Running   0                7d16h   <IP_ADDRESS>    worker0.rkomandu-ta.cp.fyre.ibm.com

noobaa-db-pg-0                                     1/1     Running   1 (5d10h ago)    6d18h   <IP_ADDRESS>    worker1.rkomandu-ta.cp.fyre.ibm.com

noobaa-default-backing-store-noobaa-pod-a1bf952a   1/1     Running   0                7d17h   <IP_ADDRESS>    worker0.rkomandu-ta.cp.fyre.ibm.com

noobaa-endpoint-bfffdd599-nq6b2                    1/1     Running   0                7d16h   <IP_ADDRESS>    worker1.rkomandu-ta.cp.fyre.ibm.com

noobaa-endpoint-bfffdd599-pbjcw                    1/1     Running   0                5d20h   <IP_ADDRESS>   worker2.rkomandu-ta.cp.fyre.ibm.com

noobaa-endpoint-bfffdd599-wlktz                    1/1     Running   0                7d18h   <IP_ADDRESS>    worker0.rkomandu-ta.cp.fyre.ibm.com

noobaa-operator-5c46775cdd-fbl45                   1/1     Running   0                6d18h   <IP_ADDRESS>    worker1.rkomandu-ta.cp.fyre.ibm.com

Step 3: Doesn't show in the noobaa endpoint
sh-4.4# uname -a
Linux noobaa-endpoint-bfffdd599-nq6b2 4.18.0-305.19.1.el8_4.x86_64 #1 SMP Tue Sep 7 07:07:31 EDT 2021 x86_64 x86_64 x86_64 GNU/Linux
sh-4.4# cd /nsfs/noobaa-s3res-4080029599/
sh-4.4# ls -l
total 9
drwxr-x---. 2 5001 9999 4096 Jan  6 06:11 new-bucket-06jan
drwxr-x---. 3 5003 9999 4096 Jan 11 10:55 new-bucket-5003-07jan
drwxr-x---. 3 5002 9999 4096 Jan  6 06:15 new-bucket-user2-06jan
drwxr-x---. 3 8091 9002 4096 Dec 16 13:14 newbucket-doesnot-have-newbucketspath
drwxr-x---. 3 8005 9999 4096 Dec 10 07:08 newbucket-s3user8005
drwxr-xr-x. 4 8092 9002 4096 Dec 17 04:45 pre-created-export-user
drwxrwxrwx. 3 root root 4096 Dec 10 01:44 primary-fileset-remote-sample-2591843568833441802
drwxrwx--x. 3 root root 4096 Dec 21 10:48 pvc-3e03cdb0-a374-4aed-bc3f-6e6f9ba74bca
drwxrwx--x. 3 root root 4096 Dec 21 10:51 pvc-bd59c318-dfd1-46e6-89f4-001bde1a34e5
drwxr-xr-x. 2 8003 9999 4096 Dec 10 06:37 s3user83-dir
drwxr-xr-x. 3 8006 9999 4096 Dec 10 07:16 s3user86-dir
drwxr-xr-x. 4 8007 9999 4096 Dec 16 09:43 s3user87-dir
drwxr-xr-x. 3 8008 9999 4096 Dec 14 13:35 s3user88-dir
drwxr-xr-x. 3 8009 9009 4096 Dec 16 10:31 s3user89-dir
drwxr-xr-x. 3 8090 9001 4096 Dec 16 12:24 s3user90-demo-dir
drwxr-x---. 3 5001 9999 4096 Jan 12 06:09 user-5001-bucket
drwxr-x---. 3 5002 9999 4096 Jan 12 06:08 user-5002-bucket
drwxr-x---. 3 5003 9999 4096 Jan 12 06:06 user-5003-bucket
Step 4:
<EMAIL_ADDRESS>~]# noobaa bucket list
INFO[0000] ✅ Exists: NooBaa "noobaa"
INFO[0000] ✅ Exists: Service "noobaa-mgmt"
INFO[0000] ✅ Exists: Secret "noobaa-operator"
INFO[0000] ✅ Exists: Secret "noobaa-admin"
INFO[0000] ✈  RPC: bucket.list_buckets() Request:
WARN[0000] RPC: GetConnection creating connection to wss://localhost:34133/rpc/ 0xc0005f6fa0
INFO[0000] RPC: Connecting websocket (0xc0005f6fa0) &{RPC:0xc0005f71d0 Address:wss://localhost:34133/rpc/ State:init WS: PendingRequests:map[] NextRequestID:0 Lock:{state:1 sema:0} ReconnectDelay:0s}
INFO[0000] RPC: Connected websocket (0xc0005f6fa0) &{RPC:0xc0005f71d0 Address:wss://localhost:34133/rpc/ State:init WS: PendingRequests:map[] NextRequestID:0 Lock:{state:1 sema:0} ReconnectDelay:0s}
INFO[0000] ✅ RPC: bucket.list_buckets() Response OK: took 0.3ms
BUCKET-NAME
newbukcet-18jan   --> this got created
first.bucket
new-bucket-06jan
new-bucket-user2-06jan
new-bucket-5003-07jan
newbucket-temp-1
user-5001-bucket
user-5002-bucket
user-5003-bucket
Step 5:
<EMAIL_ADDRESS>~]# noobaa bucket status newbukcet-18jan
INFO[0000] ✅ Exists: NooBaa "noobaa"
INFO[0000] ✅ Exists: Service "noobaa-mgmt"
INFO[0000] ✅ Exists: Secret "noobaa-operator"
INFO[0000] ✅ Exists: Secret "noobaa-admin"
INFO[0000] ✈  RPC: bucket.read_bucket() Request: {Name:newbukcet-18jan}
WARN[0000] RPC: GetConnection creating connection to wss://localhost:35765/rpc/ 0xc00009afa0
INFO[0000] RPC: Connecting websocket (0xc00009afa0) &{RPC:0xc0002c4c30 Address:wss://localhost:35765/rpc/ State:init WS: PendingRequests:map[] NextRequestID:0 Lock:{state:1 sema:0} ReconnectDelay:0s}
INFO[0000] RPC: Connected websocket (0xc00009afa0) &{RPC:0xc0002c4c30 Address:wss://localhost:35765/rpc/ State:init WS: PendingRequests:map[] NextRequestID:0 Lock:{state:1 sema:0} ReconnectDelay:0s}
INFO[0000] ✅ RPC: bucket.read_bucket() Response OK: took 1.1ms
Bucket status:
Bucket                 : newbukcet-18jan
Type                   : NAMESPACE
Mode                   : OPTIMAL
Num Objects            : N/A
Data Size              : N/A
Data Size Reduced      : N/A
Data Space Avail       : N/A
Step 6: Tried upload it fails
[root@rkomandu-app-node1 ~]# s3u5001 cp /bin/date s3://newbukcet-18jan
urllib3/connectionpool.py:1013: InsecureRequestWarning: Unverified HTTPS request is being made to host '<IP_ADDRESS>'. Adding certificate verification is strongly advised. See: https://urllib3.readthedocs.io/en/latest/advanced-usage.html#ssl-warnings
upload failed: ../bin/date to s3://newbukcet-18jan/date An error occurred (NoSuchKey) when calling the PutObject operation: The specified key does not exist
More information - Screenshots / Logs / Other output
Noobaa-endpoint logs shows continuously
[32mJan-13 18:56:13.125[35m [Endpoint/15] [31m[ERROR][39m core.server.system_services.system_store:: SystemStore: load failed Error: getaddrinfo ENOTFOUND noobaa-db-pg-0.noobaa-db-pg
at GetAddrInfoReqWrap.onlookup [as oncomplete] (dns.js:69:26)
[32mJan-13 18:56:13.125[35m [Endpoint/15] [31m[ERROR][39m CONSOLE:: RPC._on_request: ERROR srv server_inter_process_api.update_master_change reqid 1@ws://[::ffff:<IP_ADDRESS>]:41176/(2s4dm09a6r) connid wss://noobaa-mgmt.openshift-storage.svc:443(2qkkbz7k1f) Error: getaddrinfo ENOTFOUND noobaa-db-pg-0.noobaa-db-pg
at GetAddrInfoReqWrap.onlookup [as oncomplete] (dns.js:69:26)
[32mJan-13 18:56:13.126[35m [Endpoint/15] [31m[ERROR][39m core.util.postgres_client:: postgres_client: T00000000|Q00415727: failed with error: Error: getaddrinfo ENOTFOUND noobaa-db-pg-0.noobaa-db-pg
[90m    at GetAddrInfoReqWrap.onlookup [as oncomplete] (dns.js:69:26)[39m {
errno: [33m-3008[39m,
code: [32m'ENOTFOUND'[39m,
syscall: [32m'getaddrinfo'[39m,
hostname: [32m'noobaa-db-pg-0.noobaa-db-pg'[39m
}
[32mJan-13 18:56:13.126[35m [Endpoint/15] [31m[ERROR][39m core.util.postgres_client:: find failed { last_update: { [32m'$gte'[39m: [33m1642013250504[39m } } { projection: { last_update: [33m0[39m } } SELECT data #- '{last_update}' as data FROM namespace_resources WHERE data->'last_update'>='1642013250504'::jsonb Error: getaddrinfo ENOTFOUND noobaa-db-pg-0.noobaa-db-pg
[90m    at GetAddrInfoReqWrap.onlookup [as oncomplete] (dns.js:69:26)[39m {
errno: [33m-3008[39m,
code: [32m'ENOTFOUND'[39m,
syscall: [32m'getaddrinfo'[39m,
hostname: [32m'noobaa-db-pg-0.noobaa-db-pg'[39m
}
Could you take a look at this defect..  Unable to upload as noobaa endpoint log is about 29MB.

@liranmauda added to this

Looks similar https://github.com/noobaa/noobaa-core/issues/6622

Uploading the oc adm log file, noobaa db dump which Liran shared today
@jeniawhite , @nimrod-becker FYI..
noobaa-bucket-miss.tar.gz
noobaa-db-dump-file.gz

Today created new das account as shown below
mmdas account create<EMAIL_ADDRESS>--uid 5006 --gid 9999 --newBucketsPath "/mnt/remote-sample/user-5006-bucket-19jan"
Something went wrong while processing the request.
Check 'ibm-spectrum-scale-das-endpoint' pod logs in 'ibm-spectrum-scale-das' namespace for more details
<EMAIL_ADDRESS>~]# mmdas account list<EMAIL_ADDRESS>Name                   UID     GID     Accesskey               Secretkey                                       New buckets path

<EMAIL_ADDRESS>5006    9999    oWz8S4G53Djrf6xpSo2D    PcUJqa4d/KFIYYzuPkV2kXEVUr7dxSUSDKxt8JlZ        /mnt/remote-sample/user-5006-bucket-19jan/
<EMAIL_ADDRESS>~]#
<EMAIL_ADDRESS>~]#
<EMAIL_ADDRESS>~]# mmdas account list
Name                   UID     GID     New buckets path

<EMAIL_ADDRESS>5006    9999    /mnt/remote-sample/user-5006-bucket-19jan/
<EMAIL_ADDRESS>5005    9999    /mnt/remote-sample/
<EMAIL_ADDRESS>5004    9999    /mnt/remote-sample/
<EMAIL_ADDRESS>5001    9999    /mnt/remote-sample/
<EMAIL_ADDRESS>5002    9999    /mnt/remote-sample/
<EMAIL_ADDRESS>5003    9999    /mnt/remote-sample/
when creating bucket from this newly created user
s3u5006 ls s3://
urllib3/connectionpool.py:1013: InsecureRequestWarning: Unverified HTTPS request is being made to host '<IP_ADDRESS>'. Adding certificate verification is strongly advised. See: https://urllib3.readthedocs.io/en/latest/advanced-usage.html#ssl-warnings
2022-01-19 00:27:16 new-bucket-06jan
2022-01-19 00:27:16 new-bucket-user2-06jan
2022-01-19 00:27:16 new-bucket-5003-07jan
2022-01-19 00:27:16 newbucket-temp-1
2022-01-19 00:27:16 user-5001-bucket
2022-01-19 00:27:16 user-5002-bucket
2022-01-19 00:27:16 user-5003-bucket
[root@rkomandu-app-node1 ~]# s3u5006 mb s3://newbucket-5006user
urllib3/connectionpool.py:1013: InsecureRequestWarning: Unverified HTTPS request is being made to host '<IP_ADDRESS>'. Adding certificate verification is strongly advised. See: https://urllib3.readthedocs.io/en/latest/advanced-usage.html#ssl-warnings
urllib3/connectionpool.py:1013: InsecureRequestWarning: Unverified HTTPS request is being made to host '<IP_ADDRESS>'. Adding certificate verification is strongly advised. See: https://urllib3.readthedocs.io/en/latest/advanced-usage.html#ssl-warnings
urllib3/connectionpool.py:1013: InsecureRequestWarning: Unverified HTTPS request is being made to host '<IP_ADDRESS>'. Adding certificate verification is strongly advised. See: https://urllib3.readthedocs.io/en/latest/advanced-usage.html#ssl-warnings
make_bucket failed: s3://newbucket-5006user Read timeout on endpoint URL: "https://<IP_ADDRESS>/newbucket-5006user"
IMO, something is wrong here as the buckets are not created and the users created displays an error message instead of the proper user creation message of Access Key and Secret Key

As noobaa db is un-responsive, unable to clean up the buckets as a result the system can't be cleaned for upgrading to 4.9.2
@jeniawhite @nimrod-becker , would someone interested to look at the Live system and try to get a workaround, so the user accounts and exports can be deleted in a proper manner.

Hi @rkomandu,
The provided endpoint logs doesn't contain the bucket creation, although, I do see the creation of the db entry in the noobaa core pod logs.
Please provide logs of a reproduction with NSFS debug level up, I can not see where was the failure without it, and please check that the relevant logs exist there.
and regarding the DB, I see in logs that there are many issues with it, I think we should try reproduce it on a working system..

@romayalon , not sure why the noobaa-endpoint logs doesn't have the bucket creation. oc adm must-gather was collected and noobaa db dump is posted as per the command that was shared in Tue call.
I can't provide now at the nsfs log level,  the system is now deleted in a brute-force method since DB was hung and deployed the 4.9.2. Waited for 2 days with the db-dump till today Noobaa interlock call before moving fwd. Checked with jenia and as per discussion he said there shouldn't be any problem for doing the upgrade to 4.9.2.
As you know this system was working for the last 39days w/o any problem.
Not sure what did you mean by working system. Added to that, how many days does it take to recreate also not sure

have posted today also the problem that it got created during our day time. Now the system is not at that level

you could try reproducing with the steps posted while defect opening on the ODF 4.9.0 RC 4/5 build.

Hello @romayalon, Whatever I have understood, the steps aren't known for this defect recreate. This corruption happened whilst setup was running since few weeks. Just curious, wouldn't DB logs reflect cause of error.
Hello @nimrod-becker , Would you recommend usage of default log level as "nsfs" as to avoid recreates in customer environments ? An older defect #6622 was also stuck as we were not able to reproduce this DB corruption.

As @rkomandu pointed out, the namespace, catalogsource had to be deleted manually to come out of this stage, so it is a High Severity (but Medium Priority) bug and we would result in complete reconfiguration of customer environment.
@nimrod-becker , What would you recommend on how to proceed on such defects ?

I don't see how cataloguesource is related, I understand it was deleted but probably not needed.
In any case, we can certainly run with higher debug levels, that would not emulate the real customer flows, and we must not test anything performance related with these runs. But for functional testing, sure

@rkomandu @akmithal
I tried to reproduce it on my env but as @akmithal I believe that the steps for the defect are unknown (my system is new and healthy), when did the DB start to not respond? I see that there were issues with the DB from January 13th.
Actually, even without the NSFS debug level, in the endpoint logs, just before the bucket folder creation, we should have a log print (debug log 0) with the following message: 'NamespaceFS: create_uls fs_account_config:' and it's missing.
In the core logs, the bucket creation started at Jan-18 5:20:54.388, and at the same time in the endpoint logs we can see the last log print at 5:20:41.987 and after only after 4 minutes we can see another print at 5:24:44.451.
@jeniawhite are you familiar with this kind of issue?

I don't see how cataloguesource is related, I understand it was deleted but probably not needed.
In any case, we can certainly run with higher debug levels, that would not emulate the real customer flows, and we must not test anything performance related with these runs. But for functional testing, sure

@nimrod-becker , We need to delete the complete Noobaa pods, DAS service and ODF cleaning.  So catalogsource is for ODF 4.9.0 RC4/5 from 9th Dec or so. I need to delete this as ODF has to be deleted and get to 4.9.2-X (d/s builds). The ODF instructions are followed to cleanup
Let us know if there is a better process to come out of this state when the DB doesn't respond.

must-gather-0702_1.tar.gz
test_07feb.db.zip

@rkomandu
I was able to reproduce it after doing randomly IO operations/Creating a bucket.
On each reproduction, I see different DB operations that are getting stuck when they are being called from the endpoint pod. At the same time -  insert to the DB from the core pod is working fine (that is why we can see that the bucket entry was created in the DB).
when we reload the system store in the endpoint or when we update endpoint stats, after a while, we are not receiving an answer from the DB and the create bucket operation is stuck.
And regarding @akmithal as we discussed privately this is not a reproduction, the s3 tool you are using trying again to create the bucket before it got an answer from NooBaa, the thing we should understand here is if the s3 tool should wait a bit more because eventually, NooBaa will return an answer.

@rkomandu I found an issue in that area of code, working on a fix that will hopefully fix this issue.

Please keep it open for test validation @romayalon . We will close it post all related defects for this are closed.
Please create a custom build till ODF 4.9.4-X version is created and mention the build version here for everyone's reference. Thanks.


Debug run not needed. but continously coming like this.

Hi,
When i tried to execute my script through protractor always debug option is enabled and i need to execute script step by step.
How to stop this and continuouly execute my script.
Also please suggest how to enable this debug option whenever needed. thank you.
C:\name\pjt Testing\AutomationProt\IO Sample>protractor
(node:11848) DeprecationWarning: os.tmpDir() is deprecated. Use os.tmpdir() inst
ead.
[08:49:59] W/driverProviders - Using driver provider directConnect, but also fou
nd extra driver provider parameter(s): seleniumAddress
[08:49:59] I/launcher - Running 1 instances of WebDriver
[08:49:59] I/direct - Using ChromeDriver directly...
DevTools listening on ws://<IP_ADDRESS>:12503/devtools/browser/0472e62f-7d84-463c-b
014-ab0080c3ff0d
Jasmine started
Beforeall Started
Beforeall ended
[08:50:16] I/protractor -
[08:50:16] I/protractor - Encountered browser.pause(). Attaching debugger...
[08:50:16] I/protractor -
[08:50:16] I/protractor - ------- WebDriver Debugger -------
[08:50:16] I/protractor - Starting WebDriver debugger in a child process. Pause
is still beta, please report issues at github.com/angular/protractor
[08:50:16] I/protractor -
[08:50:16] I/protractor - press c to continue to the next webdriver command
[08:50:16] I/protractor - press ^D to detach debugger and resume code execution
commandpromptexecutioncontent.txt

Hello, we reviewed this issue and determined that it doesn't fall into the bug report or feature request category. This issue tracker is not suitable for support requests, please repost your issue on StackOverflow using tag angular-cli.
If you are wondering why we don't resolve support issues via the issue tracker, please check out this explanation.


fatal error: unexpected signal during runtime execution

Please answer these questions before submitting your issue. Thanks!
What version of Go are you using (go version)?
go version go1.6.3 darwin/amd64
What operating system and processor architecture are you using (go env)?
GOARCH="amd64"
GOBIN=""
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOOS="darwin"
GOPATH="/Users/Jeff/Development/go"
GORACE=""
GOROOT="/usr/local/go"
GOTOOLDIR="/usr/local/go/pkg/tool/darwin_amd64"
GO15VENDOREXPERIMENT="1"
CC="clang"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fno-common"
CXX="clang++"
CGO_ENABLED="1"

What did you do?
go run euler17.go
If possible, provide a recipe for reproducing the error.
A complete runnable program is good.
A link on play.golang.org is best.
It is not reproducible, it seems to happen intermittently with a valid go program...
What did you expect to see?
The proper output of the program
What did you see instead?

Is is possible that you have $GOROOT set that
points to a previous version than 1.6.3?

hmm interesting....
which go will output
/usr/local/go/bin/go

but then when I run go env GOROOT I see
/usr/local/go

I never set the environment variable because I read that GOROOT was set when it was installed....Did the location change with the upgrade to 10.12?

Go 1.6.3 does not support 10.12, you need to update to 1.7 or later. (1.6.3 did support the 10.12 public beta, but Apple made another change for the final release that broke Go programs.)

Thanks for the reply, where could one find this information on the go site? I've tried to locate where to look for such information in the future and couldn't track it down.

https://golang.org/doc/go1.7#ports

Also https://golang.org/wiki/MinimumRequirements

Perhaps we should add a note to
https://golang.org/doc/devel/release.html#go1.6.minor
to make it clear that go 1.6.3 doesn't actually have support for macOS
Sierra.


Release 1.6.17

Bug fixes

#396 Updated KVStore Methods to support dictionaries
#397 Added code changes for encoding '/' in _key parameter in kvstore.data APIs.
#398 Added dictionary support for KVStore "query" methods.
#404 Fixed test case failure for 8.0 and latest(8.2.x) splunk version

Minor changes

#381 Updated current year in conf.py
#389 Fixed few typos
#391 Fixed spelling error in client.py
#393 Updated development status past 3
#394 Updated Readme steps to run examples
#395 Updated random_number.py
#399 Moved CI tests to GitHub Actions
#403 Removed usage of Easy_install to install SDK

Just spotted two more changes that should probably be added to the release notes:

#402 Fixed regression introduced in 1.6.15 to once again allow processing of empty input records in custom search commands (fix #376)
#383 Implemented the possibility to provide a SSLContext object to the connect method

Thanks for pointing it out @fantavlik
I have updated the release notes accordingly.


membersrvc.yaml should not be polluted with test values

Description
https://github.com/hyperledger/fabric/blob/master/membersrvc/membersrvc.yaml should not be polluted with test values. It should be limited to reasonable defaults, and it should be fully documented for every property that might be interrogated.
IMO, we should be configuring the image generated from a build (or published to DockerHub) with either a bunch of environment variables in a Compose yaml or we need to come up with a means of mounting a volume with the membersrvc.yaml and a means of specifying where that mount point is, etc.
Describe How to Reproduce
read the code

@christo4ferris @JonathanLevi maybe I can take it with some help.

@GrapeBaBa first of all: thank you!
In addition to documenting/validating the current configuration, this cleanup requires a viable alternative, which accommodates the various tests, and the addition of lots of configuration validation logic.
So @GrapeBaBa: OK, let's do it, and I will help with pleasure - but we should probably break these into a few sub-items and potentially split some of the work...

We can now track this using FAB-15 (FAB for FABulous!)


Once a new alias is created, is always shown at the top of the alias list

As in the title.
STR

Do have at least one existing alias as pinned on top
create an alias

Actual behaviour
The just created alias is always shown on the top of the alias list. It does not matter if you sync the list again, and again. It will always shown on the top even if the user has a pinned alias.
Expected behaviour
The just created alias is shown on the top of the alias list. But after a re-syncing, the pinned alias need to be shown on the top and the just created alias needs to be sorted due to the last alia address' related activity.
The only one workaround is to kill the app from recent ones, and relaunch it.
v2.0.0 (build 20026)

Fixed in build 20027.


Add Support of Loopback interface

You can Add/Set/Remove Loopback interface (with Tests !)

/azp run

/azp run

/azp run


iot2050-firmware-update: Update from tarball

V3 update:

Rename UpdateControl to ManagedFirmwareUpdate and make it inherit from FirmwareUpdate
Change target_board to a list so that it can match mulitple boards within a single firmware node.
Change version to min_version to match the minimal version number.

==================================================
V2 updates:

The tarball will contain several firmware binaries and a update config file
Remove sha256 checksumming, user could do it by themselves.
The original FirmwareUpdate will serve the force update, i.e. update the received binary directly w/o checking anything.
Added a new updater UpdateControl, which will check both the board information and the update config information then decide to update which firmware. It will call the underlying updater FirmwareUpdate eventually.
For the update conf json file, there are firmware and target_os nodes. Please see the header comments of the script to get the details.

==================================================
Update the firmware using a tarball, which includes the firmware
image, its sha256 checksum and a update control file that indicates
which OS version the update package should be operated upon.
Signed-off-by: Su Bao Cheng<EMAIL_ADDRESS>

LGTM (except for the last patch split-up)


Mobile-Phone Responsiveness

Hey, can you please assign me this project, i can improve your website's mobile appereance/interface
I am a contributor at GSSoC'24.

Assigned .
Make sure to star the repo before working on it! Happy open-source contributing!


this is my final area, backend is nginx. i will verify if h2 is really working or what's the issue. possible to help resolve this?

this is final part
where do u think i shld be looking at to remedy this?
	"github.com/cloudwego/hertz/pkg/app"
	"github.com/cloudwego/hertz/pkg/common/config"
	"github.com/cloudwego/hertz/pkg/protocol"
	"github.com/hertz-contrib/reverseproxy"

2022/12/06 14:30:30.641901 engine.go:451: [Error] HERTZ: Error=tls: client requested unsupported application protocols ([h2]), remoteAddr=<IP_ADDRESS>:42518
2022/12/06 14:30:30.642293 client.go:203: [Error] http2: transport failed to get client conn for example.com:443: remote error: tls: no application protocol
2022/12/06 14:30:30.642325 reverse_proxy.go:231: [Error] HERTZ: Client request error: "remote error: tls: no application protocol"

maybe issues on my side. i retest and revert. thx

Can you provide a code example?

Maybe the client is not a HTTP2 client. So they fail in negotiation protocol. Have you added HTTP2 factory as shown in the example？

i think i resolved this. thx


Feat pet card

Description:
Apply new card design to PetType.js

create new PetCard.js file
use it in Home.js and PetType.js
fix css

Related issue:
#166

@redxzeta could you, please elaborate on what adjustments are needed for mobile exactly?

@jpacsai
sorry about that. looks like the card went over

Think it might have to deal with this css

I think it might have to deal with it being a grid after looking into it
.petList__container {
  text-align: center;
  display: grid;
  place-items: center;
}

@redxzeta sorry, I haven't spotted that, now it's fixed :)

@jpacsai  Thanks for your contribution :)


imagefiltered_transform_animation_perf__timeline_summary failing with insufficient storage error

stdout:             adb: failed to install /Users/flutter/.cocoon/flutter/dev/benchmarks/macrobenchmarks/build/app/outputs/flutter-apk/app.apk: Failure [INSTALL_FAILED_INSUFFICIENT_STORAGE: Package couldn't be installed in /data/app/com.example.macrobenchmarks-1: Creating application package com.example.macrobenchmarks failed]

Marking P0 because the tree is closed on this, but it can wait until 9/8 after the long weekend!

Mac-19 is failing from this now and completely blocking the build tree ATM. Is there a P-1?

Executed adb reboot on mac-19.

Tree is open now.

Mac-19 is already up to its insufficient storage errors again. I think more than just a reboot of the phone is needed.

Stopped the mac-19 agent, will investigate further (https://github.com/flutter/flutter/issues/39925). Rerun the failed tests and they passed.


Does not work

Does not work. Ff 90/

Can confirm. Does not work for me as well. On FireFox version 90.0.2 (64-bit). The update probably messed up this extension

Does not work in chrome/microsoft edge as well. The same result.

In Microsoft Edge doesn't work as well. Please fix it.

Hello, it should be fixed in the next release (Pending review).

Still not working.

No, it was likes and mentions.

Friend request, for example. With the other extension it works well.

Hello Aleck85, I have finally rebuild a part of the extension with a new scraping method: the extension now use m.facebook.com instead of mbasic.faceook.com.
I think it's much better 🤞
Could you try the last version (2.7.0)?

Hello. Unfortunately I won't be able to test Firefox version until Tuesday. Now 2.7.0 for Chrome is working in Microsoft Edge too.

Yes, now it works correctly.


Negative Float Values

Hello!
I have a problem to get negativ values of float-variables. In this case I want to get the temperature from outside and at this time it is negativ. (In the app I see only 0 to 100)
Is this a problem of homebridge or off the plugin (homebridge-symcon)?
Joachim

@Joey-1970 the plugin needs to override the characteristic.props.minValue in this case.

Hello KhoasT,
thanks for your answer.
May you explain me how to do this? (maybe a example?)
And in witch place?
Joachim

Something like
service.getCharacteristic(hapCharacteristic).setProps({minValue: -10});

should be added to here depends on the characteristic type.

Hello KhoasT,
I try and try but I don't get a negative feedback in the app (..is not my code...)
I hope the author will do it... ;-)
Thank you for your help!
Joachim

@Joey-1970: it works! I've implemented it in homebridge-punt. The settings can be defined in config-punt.json.
You can test it yourself, just install [homebridge-punt] (https://github.com/cflurin/homebridge-punt) and run the build-in simulator.

Sorry, I'm not able to do something like this in the code of homebridge-symcon. I see what you mean, but I don't no how do this in homebridge-symcon... (https://github.com/w-andre/homebridge-symcon/blob/master/SymconAccessory.js)
I must wait for the author of this code or on someone who can tell me exactly what I ust change in this code... :-(
Joachim

@Joey-1970 in that case, I'd suggest you file an enhancement request in that repo. I'll close this issue for now.


Fix flake8 linter regression

Happening on all ros2 nightlies (linux-debug, aarch-debug, windows-debug)
Error message:
Import statements are in the wrong order. 'import os' should be before 'import platform':
import os

This was introduced in: https://github.com/ros-visualization/python_qt_binding/pull/118

CI:

Linux
Linux-aarch64
Windows


[GAIA] The operator 'count()' is slower than expected

Related issues #1854
Is your feature request related to a problem? Please describe.
Graph Schema
Vertex label: company, size: 310 million

property name
type
primary key

onecomp_id
STRING
False

ent_name
STRING
False

vertex_id
STRING
True

Edge label: edge, size: 10M

property name
type
primary key

weight
DOUBLE
False

edge_id
STRING
False

The query g.V().count() takes more than 240s(cancelled with Pegasus timeout), which <1s on other's GraphDB like GDB.
gremlin> g.V().count()
==> takes more than 240s(cancelled with Pegasus timeout)

Address in issues https://github.com/alibaba/GraphScope/issues/1854


fix(optional): fixed doc comments

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (2372431) to head (fcbb694).

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #20   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            3         3
  Lines          194       194
=========================================
  Hits           194       194

Flag
Coverage Δ

optional
100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


[share] Use NSURL when sharing non-image files to make correct actions appear in share sheet

Description
When sharing a non-image file with the iOS share sheet (via the share plugin), the correct actions based on the file type are not appearing in the share sheet.
For example, when sharing a PDF file, the share sheet currently looks like the screenshot on the left. Notice that compared with the screenshot on the right, the current share sheet does not include the Markup or Print actions.

Current Behavior
Fixed - Using NSURL

The fix consists of using a NSURL based on the supplied file path when initializing the UIActivityViewController.
I've tested the fix with several file types including pdf, mp4, and docx; additional relevant share sheet actions are now being shown for each file type.
I'm sure there's some cleanup required if my fix is accepted, but as my Objective-C chops leave a lot to be desired, I'll be looking to the package maintainer(s) for guidance here.
Checklist

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
[x] All existing and new tests are passing.
[x] I updated/added relevant documentation (doc comments with ///).
[x] The analyzer (flutter analyze) does not report any problems on my PR.
[x] I read and followed the Flutter Style Guide.
[x] The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
[x] I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
[x] I updated CHANGELOG.md to add a description of the change.
[x] I signed the CLA.
[x] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?

[ ] Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
[x] No, this is not a breaking change.

when i used video player plugin to load videos from assets for story play like instagram so the video couldn't load properly in ios simulator and some times app crashes when starting playing video and navigate to next video i used code from this url
https://github.com/MarcusNg/flutter_instagram_stories
please look at this issue

when i used video player plugin to load videos from assets for story play like instagram so the video couldn't load properly in ios simulator and some times app crashes when starting playing video and navigate to next video i used code from this url
https://github.com/MarcusNg/flutter_instagram_stories
please look at this issue

Not sure how the issue you're describing is related to the share plugin or my PR.

Thanks for the submission! However, we’re currently not accepting non-critical PRs for this plugin, as we hope in time to be able to transition users to the corresponding plugin in the Flutter Community Plus Plugins repository. We encourage you to submit your PR there.
We apologize for the long delay in triaging this PR. We’re in the process of overhauling our PR triage system to respond much more quickly, as well as working through the backlog.


Would you accept a PR to console.warn about misspellings?

React does it in dev mode. Should preact do the same?
see for example:
GitHub code search for "componentDidUnmount"
GitHub code search for "componentWillRecieveProps"
There are a lot of those

Only as part of preact/debug. Preact does not have a dev mode, debug is how we intend to add these types of warnings.
For what's it's worth a linter is a much nicer way to get warnings about these things :)

Just checked the react repo and they do have code that checks for type errors in lifecycle methods. Nonetheless, I think this is already perfectly handled by linters or type systems (even better) 💯  We would just duplicate that effort.
@Emilios1995 Perhaps you can share your use case, where linters/Flow/TS didn't help you further? If there is still an issue feel free to ping me and I'll reopen this one.


[FEATURE]: column.as("alias") method

Describe what you want
currently, the Column type has no as method, so I use column.getSQL().mapWith(column.mapFromDriverValue).as('alias') to properly select a column with alias.
const result = await db.select({
  sellerId: user.id.getSQL().mapWith(user.id.mapFromDriverValue).as('sellerId')
})

It would be nice to be able to just do it with:
const result = await db.select({
  sellerId: user.id.as('sellerId')
})

@erfanium you can also use sql<string>`${user.id}`.as('sellerId')
^ the downside of this is having to specify the explicit type, and the possibility for mistakes or changes.
Having column.as() would be great, especially with the new query builder view declaration stuff

Here's a little function to help with types/reuse:
import { type AnyColumn, type GetColumnData, type SQL } from 'drizzle-orm'

export const aliasedColumn = <T extends AnyColumn>(
  column: T,
  alias: string,
): SQL.Aliased<GetColumnData<T>> => {
  return column.getSQL().mapWith(column.mapFromDriverValue).as(alias)
}


Increase ETL_EPOCH

In the last months we have made several small changes under the hood that don't trigger ETL runs. So it would be good to increase ETL_EPOCH, so that what we have in master resembles a full ETL run from scratch.
Just to be safe, we should do this at some point in January.

Mojmir increased ETL_EPOCH last week.


Touches not registering/executing on FlatList/ScrollView when navigating back to the screen with a scrolling list (IOS)

Description
If we navigate to a new screen while a list component is currently scrolling and come back to this screen, the touch does not work on the previously scrolling list. Once i manually scroll the list again and scroll ends only after that touch starts to work on the children of the FlatList or ScrollView
The List component can be either ScrollView or FlatList.
Version
0.66.0, 0.69.0
Output of npx react-native info
System:
OS: macOS 12.1
CPU: (8) x64 Apple M1 Pro
Memory: 28.88 MB / 16.00 GB
Shell: 5.8 - /bin/zsh
Binaries:
Node: 14.10.0 - ~/.nvm/versions/node/v14.10.0/bin/node
Yarn: 1.22.19 - ~/.nvm/versions/node/v14.10.0/bin/yarn
npm: 6.14.8 - ~/.nvm/versions/node/v14.10.0/bin/npm
Watchman: Not Found
Managers:
CocoaPods: 1.11.0 - /usr/local/bin/pod
SDKs:
iOS SDK:
Platforms: iOS 15.0, DriverKit 20.4, macOS 11.3, tvOS 15.0, watchOS 8.0
Android SDK: Not Found
IDEs:
Android Studio: 2021.2 AI-212.5712.43.2112.8815526
Xcode: 13.0/13A233 - /usr/bin/xcodebuild
Languages:
Java: 14.0.2 - /usr/bin/javac
npmPackages:
@react-native-community/cli: Not Found
react: 18.0.0 => 18.0.0
react-native: 0.69.6 => 0.69.6
react-native-macos: Not Found
npmGlobalPackages:
react-native: Not Found
Steps to reproduce
Step 1: Create a ScrollView or Flatlist with navigation to a new Page on item click.
Step 2: Initiate a flick gesture on the list, to introduce a scroll from the 0th to the Nth position.
Step 3: While the list is scrolling, click on any other clickable component such as the search bar or any other clickable widget which has navigation attached to it.
Step 4: You will be navigated to a new screen. Now navigate to the previous screen.
Step 5: Click on any child component of the previously scrolling list.
Step 6: Nothing will happen until you manually scroll the list and it reaches an idle scroll position
Snack, code example, screenshot, or link to a repository
import React, { Component } from 'react';
import { View, Text, TouchableOpacity, SafeAreaView, FlatList, ScrollView } from 'react-native';
const App = ()=> {
const renderListItem = ({ item, index }: any) => {
return (
<ScrollView
onScroll={() => {
console.log(" onScroll called scrollview");
}
}
scrollEventThrottle={16}
horizontal
  <Text>selected</Text>
  <Text>selected</Text>
  <Text>selected</Text>
  <Text>selected</Text>
  <Text>selected</Text>
  <Text>selected</Text>
  <Text>selected</Text>
  <Text>selected</Text>
  <Text>selected</Text>
  <Text>selected</Text>
  <Text>selected</Text>
  <Text>selected</Text>
  <Text>selected</Text>
  <Text>selected</Text>
  <Text>selected</Text>
  <Text>selected</Text>
  <Text>selected</Text>
  <Text>selected</Text>
  <Text>selected</Text>
  <Text>selected</Text>
  <Text>selected</Text>
  <Text>selected</Text>
  <Text>selected</Text>
  <Text>selected</Text>
  <Text>selected</Text>
  <Text>selected</Text>
  <Text>selected</Text>
  <Text>selected</Text>
  <Text>selected</Text>
  <Text>selected</Text>
  <Text>selected</Text>

   <TouchableOpacity
   style={{backgroundColor: 'yellow', padding: 20}}
   onPress={() =>console.log('on Press')}>
   <Text>Count</Text>

 </TouchableOpacity>
 </View>
);

};
return (

<FlatList
data={['']}
renderItem={renderListItem}
onScroll={() => {
console.log(" onScroll called Flatlist ");
}
}
/>

);
}
export default App

same issue still existing even i used @PratthamArora's fix

same issue still existing even i used @PratthamArora's fix

Hi
Here is the configuration I'm using and it is working 100%
Apart from the changes mentioned in the MR,
RN version - 0.66.0
Using native navigation via Native Modules ( not using any navigation library)

any update on this?

This is still open

it is still active

@PratthamArora Can you provide a repro code for this. Using sample react native app. It will great for me to test this on New Architecture.

I tried creating a repro for this.
Here is the repro: https://github.com/dream-sports-labs/reproducer-react-native/tree/feat/repro-scroll-stuck
Steps:

Initiate a flick gesture on the list
While the list is scrolling, switch tab to DiscoverScreen and again move back to HomeScreen Tab.
Try to click on List Items.

Expected: Items must be clickable and navigate to other screen
Actual: List items are freezed.
Also the above fix was working only for Old Architecture.


rdmolfiles.CanonicalRankAtoms segfaults on 0 atom molecules.

Description:

RDKit Version:2017.09.01
Platform:64 bit linux ubuntu installed through conda install -c rdkit rdkit=2017.09.01

from rdkit import Chem
from rdkit.Chem import rdmolfiles
from rdkit.Chem import rdmolops

mol = Chem.MolFromSmiles("")
print(mol) # <rdkit.Chem.rdchem.Mol object at 0x7fa4e203c670>
new_order = rdmolfiles.CanonicalRankAtoms(mol) # This segfaults
mol = rdmolops.RenumberAtoms(mol, new_order)

rdmolfiles.CanonicalRankAtoms(mol) segfaults upon 0 atom molecules.  I think it should either return an empty list or throw a ValueError.

Thanks for letting us know.  I’ll fix this later today and make a pr

It looks like RenumberAtoms is the culprit here.
>>> from rdkit import Chem
>>> mol = Chem.RWMol()
>>> mol = rdmolops.RenumberAtoms(mol, [])

There were two issues that needed to be resolved.  One in rank atoms, one in renumber.


[release-1.9] Allow, with warning, users using first-party-jwt with Kubernetes 1.21+ and helm integration test fix for 1st party JWT

Manual cherry-pick of https://github.com/istio/istio/pull/32159 and https://github.com/istio/istio/pull/32012
Fixes https://github.com/istio/istio/issues/32168 and https://github.com/istio/istio/issues/32162
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[X] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
Pull Request Attributes
Please check any characteristics that apply to this pull request.
[X] Does not have any changes that may affect Istio users.

@jacob-delgado: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-helm-tests_istio_release-1.9
2bed3590dec17642e5862272cd4620ffe63869f5
link
/test integ-helm-tests_istio_release-1.9

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jacob-delgado: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-helm-tests_istio_release-1.9
2bed3590dec17642e5862272cd4620ffe63869f5
link
/test integ-helm-tests_istio_release-1.9

integ-security-multicluster-tests_istio_release-1.9
2bed3590dec17642e5862272cd4620ffe63869f5
link
/test integ-security-multicluster-tests_istio_release-1.9

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Proxy Service URL's

The inclusion of a spreadsheet here with details is very much appreciated.
Having said that - it could possibly be improved with indicating the direction of the traffic flow for each component?
We have two customers looking at deploying at scale with Proxy/Traffic arrangements in restricted areas.
We will have outbound comms enabled - but not inbound
It would be extremely useful to understand which of these are inbound/outbound?
Examples:

Microsoft Defender Antivirus Content Delivery Network (CDN) - Security Intelligence updates - assumed as inbound?
MAPS - Used by Microsoft Defender Antivirus to provide cloud-delivered protection - inbound or outbound or both?
Upload location for files submitted to Microsoft via the Submission form or automatic sample submission - assumed outbound?
Used for Microsoft Defender SmartScreen reporting and notifications - inbound or outbound or both?

Hope this makes sense?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 2748359b-273d-7faa-6a63-7a6ebea450d2
Version Independent ID: f4885da5-9a83-13aa-789e-1751db586404
Content: Set up Microsoft Defender ATP deployment - Windows security
Content Source: windows/security/threat-protection/microsoft-defender-atp/production-deployment.md
Product: w10
Technology: windows
GitHub Login: @mjcaparas
Microsoft Alias: macapara

@dcaddick . From my point of view , all are considered as both outbound with inbound.
client computers send requests (outbound) to Microsoftserver computers and then receivees information From that server sends the output towards the client computers ( Inbound)

Hello @dcaddick ,
All connections are outbound and initiated by your computer. There is no need to allow any inbound traffic.
The article states:
"The following downloadable spreadsheet lists the services and their associated URLs that your network must be able to connect to. Ensure that there are no firewall or network filtering rules that would deny access to these URLs, or you may need to create an allow rule specifically for them."
Thank you

@MaratMussabekov : Thank you for verifying. It makes sense, too. Some sites may block outbound traffic from reaching any other sites than those determined safe by the company.

@dcaddick Please let us know if you still have any question regarding the issue you have raised initially.
The issue is being closed since your question seems to be answered. Feel free to re-open this issue if you feel that it hasn't been answered or that there are further suggestions to improve the documentation itself.
Thanks.


feat: populate org/project title in APIKeys

For frontend.

I'm not sure if this PR actually works. Started a conversion in Slack.


Fix Make a Person instructions

Removed confusing use of the word "arity" from the challenge description and updated the challenge wording to be more straightforward. I did not update the Spanish wording.
closes #7366

@eeseesee Will you be updating this as suggested by @justinian336?

Closing as stale.  If you would like to make the changes you may re-submit.


Rel 0.2.0: conditional call fwd states update

Intent2 output update according to: https://github.com/camaraproject/CallForwardingSignal/discussions/31#discussioncomment-9795447

What type of PR is this?

enhancement/feature

What this PR does / why we need it:
increases the level of information on the conditional call FWD to support use case 3 (https://github.com/camaraproject/CallForwardingSignal/discussions/17)
the Conditional endpoint is optional: https://github.com/camaraproject/CallForwardingSignal/issues/37#issuecomment-2210346948
Error codes updated according to: https://github.com/camaraproject/CallForwardingSignal/issues/50

@FabrizioMoggio one very small comment. I saw you turn to false the POST requestBody (lines 165 & 218).
This is one alternative - this other will be to keep it mandatory and if no phoneNumber is passed the body must be valued to an empty object {}.
We have similar option in sims swap and we keep the requestBody mandatory.
I asked my lead developer a recommendation: he told me that as we can sometimes something, something nothing it's cleaner to always mandate an object.
I can live with both but perhaps we should adopt one common pattern. Do you want me to trigger an issue in commonalities?

@FabrizioMoggio one very small comment. I saw you turn to false the POST requestBody (lines 165 & 218). This is one alternative - this other will be to keep it mandatory and if no phoneNumber is passed the body must be valued to an empty object {}.
We have similar option in sims swap and we keep the requestBody mandatory (reference: camaraproject/SimSwap#118) I asked my lead developer a recommendation: he told me that as we can sometimes have something, something nothing it's cleaner to always mandate an object.
I can live with both but perhaps we should adopt one common pattern. Do you want me to trigger an issue in commonalities?

I agree an aligning with simswap and I also agree with you, this should be in the guidelines, so please open an issue in Commonalitis as you suggested.

@FabrizioMoggio one very small comment. I saw you turn to false the POST requestBody (lines 165 & 218). This is one alternative - this other will be to keep it mandatory and if no phoneNumber is passed the body must be valued to an empty object {}.
We have similar option in sims swap and we keep the requestBody mandatory (reference: camaraproject/SimSwap#118) I asked my lead developer a recommendation: he told me that as we can sometimes have something, something nothing it's cleaner to always mandate an object.
I can live with both but perhaps we should adopt one common pattern. Do you want me to trigger an issue in commonalities?

I agree an aligning with simswap and I also agree with you, this should be in the guidelines, so please open an issue in Commonalitis as you suggested.
Is this good?: requestBody: content: application/json: schema: oneOf: - $ref: '#/components/schemas/CreateCallForwardingSignal' - {} required: true

for me
      requestBody:
        content:
          application/json:
            schema:
              $ref: '#/components/schemas/CreateCallForwardingSignal'
        required: true

For me this just good enough. Without the need for the oneOf.
We can just comment this point in the documentation page?

Are you sure :-). In my understanding that means that CreateCallForwardingSignal must be in the body while for the 3legs issue (https://github.com/camaraproject/CallForwardingSignal/issues/51) it should be optional. This is way I also added the VOID option.
About the documentation it is all in the new version I have ready to fire that implements https://github.com/camaraproject/CallForwardingSignal/issues/51
Maybe it is better if I include also that version

I mean, if CreateCallForwardingSignal is in the body, we also have phoneNumber and it should be optional

Are you sure :-). In my understanding that means that CreateCallForwardingSignal must be in the body while for the 3legs issue (#51) it should be optional. This is way I also added the VOID option.

Are we aligned that the required in lines 165 or 218 did not indicated that the endpoint is required or not. It just indicates if in the POST operation the presence of a request body is mandatory.
If we set required=true it means that use of schema CreateAllForwardingSignal is mandatory.
In this schema the phoneNumber is optional so both following payload are valid:
{}

or
{
  "phoneNumber": "+123456789"
}

Currently in CreateAllForwardingSignal there is no indication if phoneNumber is required or not. Maybe it is better to explicit state it adding:
  minItems: 0

CreateCallForwardingSignal:
  description: resource containing the phone number (PhoneNumber) regarding
   which the Call Forwarding Service must be checked. It is optional.
  type: object
  properties:
    phoneNumber:
      $ref: "#/components/schemas/PhoneNumber"
  minItems: 0

For me, @FabrizioMoggio , this is not required because if the phoneNumber the definition should be:
CreateCallForwardingSignal:
  description: resource containing the phone number (PhoneNumber) regarding
   which the Call Forwarding Service must be checked. It is optional.
  type: object
  required:
    -phoneNumber
  properties:
    phoneNumber:
      $ref: "#/components/schemas/PhoneNumber"

Here because the phoneNumber is not in the required list the developer get it.


Review and Clear Websites' Dependabot alerts

Currently all of our websites are receiving security alerts. I've looked over them and didn't spot anything we need to worry about, but we should do more research to be sure. We could upgrade packages, fixing the ones we want to clear, and dismiss the rest.
cc @iterative/websites

Technically this is a never-ending battle, but we temporarily cleared all website repos' built up Dependabot alerts and now we're just keeping up with maintenance!


Increase MaxLiteralCharacterLimit for loadTextContent (specifically for non-JSON content)

Increase MaxLiteralCharacterLimit for loadTextContent https://github.com/Azure/bicep/blob/main/src/Bicep.Core/LanguageConstants.cs#L32
Some of logic app JSON code as well as Azure Workbooks cannot be used with this function due to them being larger than 131072 characters. A lot of these resources would be created via azure portal and then used within arm templates/bicep for deployment. It would be great to have the ability to load it's content from within a separate file.

+1

Options to implement this:

We could increase the limit in the runtime.
We could put the content into a variable instead of a JSON expression string literal. (Would have to avoid clashes with user-defined variables, though.)

Related:

#3315

Exactly I got the same issue with string literal limit length

We are going to investigate increasing the runtime limit

Is there any update on this investigation? I've found the same character limitation brings down an idea of using otherwise fully functioning API Management api publishments using bicep, because openapi files can be larger than the current 131072 character limitation allows.

I'd really like this feature too. I have a separate process that adds a lot of elements to an app gateway, which I then update intermittently via Bicep as part of my core infrastructure maintenance. I read in the appGw config as it stands and can output it to a file for Bicep to use so that the appGw template is made up of all the features I need without overwriting the separate process changes that were made. The file size limit really restricts this as my appGw grows in size though, so runtime changes would be brilliant to amend this higher... @alex-frankel is this on a roadmap for future implementation at all?

It's something we would like to do, but I doubt it will be dealt with in the next 3-6 months. It would be helpful if this issue gets more upvotes, so we can shift priorities accordingly.

I have a monitor workbook with more than 131072 characters

You can try to deploy the SOC Process Framework Sentinel workbook from https://raw.githubusercontent.com/Azure/Azure-Sentinel/master/Workbooks/SOCProcessFramework.json - I have found no way to do this using Bicep, because of this limitation. The same number appears when i try to add the content using json() with a string rather than through loadTextContent

It is a blocker for deploying open api spec files for an API. Those files can get larger if they have more operations :(

This is a blocker which leads to me not using or recommending bicep in general on projects over terraform or pulumi.

Any ETA on when this could be implemented ? im hitting this problem right now with a workbook im trying to use.

As someone mentioned above it's a blocker really. Bicep seems ok when you want to build something simple but if you got something advanced to do it might be better to stick to something else like terraform. Is there any information when we can expect solution for that issue?

We'll discuss it again in triage this week, but I'm moving this to the 1.0 milestone for now. We'll see if we can get it done sooner.

This is like a really bad problem,  maximum size of 131072 characters is nothing for size.  Note that is characters not bytes..this is unusable at all.   Any way around this?  Uri?

Upvote

I hit the same problem today with a swagger import file that was 213,293 bytes.
I found a workaround for large json files, by using loadJsonContent() then wrapping the result with string(..) as follows...
var swagger = string(loadJsonContent('api.swagger.json'))

@qualitas-software thank you for posting that, I needed that.

@qualitas-software i see you highlight json, i assume this doesn't work for loadTextContent ? 😄

@verschaevesiebe yeah the original issue is about loadTextContent().  I haven't tried it, but could you put the encoded file into json, use a version of the method above and extract it?   Eg-  { "encoded": "<base64 encoded file>" } then load it var fileContent = string(loadJsonContent('file.encoded.as.json').encoded) ?  Good luck.

@qualitas-software nice workaround, would have come up with it myself but I need structure so I've translated all OpenAPI Specs from YAML to JSON and we're now using the loadJsonContent 😄
Goodluck to anyone else running into file size limitations 🤗

+1

Turns out that loadJsonContent() does not have this same problem. It seems most, if not all, of the cases where someone would run into this limit is for JSON content. Given that, we are going to close this and recommend you use loadJsonContent() instead.
If we are missing any cases that do not involve JSON content, please let us know and we can revisit.

@alex-frankel may be for both commands will be best to document the maximum limits of size/characters? If not already, I have not checked.

If we are missing any cases that do not involve JSON content, please let us know and we can revisit.

I have several cases of xml files (edifact xsd schemas) which exceeds the text limit by far, so this is absolutely not for just json documents.
Why are there even different size limits for json and text content?

It would be great to have some transparency on this. Is there some sort of limitation that would prevent this limit to be raised globally?

Why are there even different size limits for json and text content?

@miqm knows better than me, but my guess is we can handle JSON more efficiently because it's the same format as the template.
Thank you for sharing the examples @johan-burman. Which resource types are you using those XML schemas for? I will re-open the issue and make it more specific to non-JSON content.
@JayDoubleu -- hopefully you have seen that we always try to be as transparent as possible. The reason we closed this is because we thought it only needed to cover JSON content.  At this point, we will need to take another look and see if we need to prioritize this sooner.

The limit for loadTextContent is a limit for ARM template expression as noted here
As Alex pointed, loadJsonContent leverages ARM's JSON structure to "omit" the bicep compilation and put file directly into Intermediate Language - which is ARM JSON (load is not direct though - any potential ARM Template expression escaping is done to avoid loaded file being processed by ARM runtime).
LoadJsonContent does not enforce any limit - the only limit is 4MB - which is a limit for ARM template. So even if you have a 4MB JSON file your template most probably will fail due to other compiled resources "taking space" in the intermediate ARM file.
AFAIK the expression limit is in ARM Runtime to not process too long expressions. However @anthony-c-martin or @majastrz can give more light on this.
Perhaps a solution would be to give ability to provide some storage account details which could be used as intermediate storage during deployment?

Thanks for re-opening the ticket!

Thank you for sharing the examples @johan-burman. Which resource types are you using those XML schemas for? I will re-open the issue and make it more specific to non-JSON content.

The case I'm looking at right now is adding a large edi flatfile schema (xsd) to an integration account. Before this I came across the same limit with an Xslt, but was able to make it fit by removing whitespace.
If this limit needs to stay as-is, maybe there's some other way to achieve the same result, which we are overlooking?

@alex-frankel one of the biggest cases for loadTextContent is with Microsoft.Insights/workbooks resource. You can have quite big workbooks there and you cannot use loadJsonContent() as it does not take json input but rather escaped json as string as far as I know. It is easier if you save the json generated from workbook and load it to deploy it as you can make small changes to the json without going to Portal. At the same time when you edit in portal you have good option to just copy the json and than you will paste it in your json file for deployment.

+1 Azure Workbooks is the entire reason I created this issue (To allow creation of Azure Workbooks via bicep)
If I could have an acceptance criteria it would be to allow creation of most azure workbooks via bicep which is currently not possible ? Unless prehaps there's a way to serialize it somehow to base64 and then back into serialized string after loading as json..

So I'm trying to load an openapi json file into Microsoft.ApiManagement/service/apis bicep resource and ran into the character limit discussed above. I then set the value: string(loadJsonContent('../schemas/openapi.json')) which gets round the immediate issue but then there is another failure when attempting to deploy it - Unhandled exception. Azure.Deployments.Core.Exceptions.ExpressionException: The language expression literal limit exceeded. Limit: '131072' and actual: '191488'.
at Azure.Deployments.Expression.Expressions.JTokenExpression..ctor(String value, TemplateErrorAdditionalInfo additionalInfo)
at Bicep.Core.Emit.ExpressionConverter.ConvertExpression(Expression expression). So I'm confused how others have managed to get this working.

Basically this limitation is making it impossible to automate deployment of end-to-end Logic app flows including XSLT in an integration account. Removing whitespace is only an option for close-to-limit file sizes, but we have much larger maps than that. One workaround would be to use a single-tenant logic app and skip the integration account, but that comes with a lot of other issues (such as the XSLT transform action never fails when the transformation fails, which makes it retry every 5 seconds for all eternity...).

We are using this to load ADX scripts and hitting the max character limit using loadTextContent. string(loadJsonContent()) is not a workable solution for our usecase.

+1 For importing large automation account runbooks & DSC configurations.

@devnomadic  if I am not mistaken you cannot use the above function in runbooks API anyway as that one requires URL link to the runbook published on public place rather providing the text of the runbook.

@slavizh There is an API to import draft runbook content directly:
replace-content API
For DSC configuration you can pass the script content directly in Bicep using the 'Microsoft.Automation/automationAccounts/configurations' resource. There is an 'embeddedContent' type in the source object & the value you can use the loadTextContent function.
I have used the Az Powershell module in the past to import runbooks and DSC configurations without using a URI for the source. Looking a the Azure Powershell repo & following the code for the Import-AzAutomationRunbook cmdlet it uses the above API to import runbooks.

@devnomadic  The API is for a draft rather for published runbook. Also I do not think this API is even Bicep enabled. Not every ARM API is applicable for Bicep. For example any actions like Start or Stop VMs are like operations rather setting configuration. The draft one seems exactly like that - https://learn.microsoft.com/en-us/azure/templates/microsoft.automation/automationaccounts/runbooks/draft-content?pivots=deployment-language-bicep. Have you tested the API with Bicep and if so do you have example Bicep code  that creates/updates runbook via content rather link to http endpoint?

@slavizh Thank you for the suggestion. I did try the draft-content resource but it looks like it is not working:  https://github.com/Azure/bicep-types-az/issues/1688

@devnomadic I highly doubt that will be fixed. The API is made like action so it does not support ARM Template/Bicep. Probably will be the same effort to implement creating runbook from content than making that API compliant with Bicep. Overall the runbook API should support that not the draft one as draft is more of API that is used when you are doing development via portal and you update runbooks.

I've run into an aspect of this issue as well. I have a logic app that is serving a deploy-time configured HTTP response that serves up a bespoke front-end web application. Built with a static single file generating framework the HTML exceeds the 131072 character limit. I can manually create a logic app and save the HTML as an HTTP response but I cannot export the logic app as a template nor can I deploy the logic app from Bicep or JSON.

Yes I am having same issues.

Just ran into this issue myself :(, seems that I need to make another workaround

That'll work great until even your minified JSON is too large.

That'll work great until even your minified JSON is too large.

Correct. I would like to see an increase to the limit.

We have run into this issue, when using a single JSON file to define and deploy all our azure policies that make up the Enterprise Landing Zone guardrails.

This might also occur on workbooks in sentinel as they can easily exceed that 131k character quota. Just now I'm exporting some and they're like 145k characters :(.

We are using this to load ADX scripts and hitting the max character limit using loadTextContent. string(loadJsonContent()) is not a workable solution for our usecase.

+1 for being blocked loading ADX scripts, too.

Any update on this?

For those hitting this limit when defining APIM API definitions - minifying the openapi YAML and using loadTextContent or loadYamlContent should give you some temporary breathing space

Our solution ended up being:

Since we split up our Open API specification, because it was becoming troublesome to manage, we use the Redocly CLI (https://redocly.com/docs/cli) for bundling multiple files into one specification file.
We then use Bicep for deploying the API on APIM, but without an API specification and policies (API policy and Operation policies)
Lastly we use the REST API for importing the Open API specification and PowerShell for setting the policies, as this does not seem to have the same length constraints.

The reason we use the REST API is that this also allows us to provide the additional option to specifying that query parameters should not be translated into a template one. (https://learn.microsoft.com/en-us/rest/api/apimanagement/apis/create-or-update?view=rest-apimanagement-2022-08-01&tabs=HTTP#translaterequiredqueryparametersconduct) As it is not (yet?) supported by the PowerShell module or the Azure CLI. (Note that Bicep does already support this)

I encountered also this problem when importing an openAPI spec into Azure API Management using Bicep using loadTextContent.

I encountered also this problem when importing an openAPI spec into Azure API Management using Bicep using loadTextContent.

You can avoid it by loading openapi spec to object (load json/yaml content) and then serialise object into json using string function.

I encountered also this problem when importing an openAPI spec into Azure API Management using Bicep using loadTextContent.

You can avoid it by loading openapi spec to object (load json/yaml content) and then serialise object into string-encoded-json using string function.

Many thanks, this saved the day!
string(loadJsonContent('very-large-open-api-spec.json'))

Is there an ETA for this? It seems that the change is trivial and affects multiple users, yet this doesn't seem to be on the radar. Am I correct in assuming that this isn't being actioned because the ARM deployment size limit needs to be increased first?

I encountered also this problem when importing an openAPI spec into Azure API Management using Bicep using loadTextContent.

You can avoid it by loading openapi spec to object (load json/yaml content) and then serialise object into string-encoded-json using string function.

Many thanks, this saved the day!
string(loadJsonContent('very-large-open-api-spec.json'))

weirdly enough this works