feat: support Gateway/Class

Describe the feature
Since Gateway API is on a stable API, we should consider adding control for the GatewayClasses to begin with.
What would the new user story look like?
How would the new interaction with Capsule look like? E.g.

What are the prerequisites for this?
Tenant owner creates a new Namespace
This is going to be attached to the Tenant
All the magic happens in the background

Feel free to add a diagram if that helps explain things.
Expected behavior
A clear and concise description of what you expect to happen.

Gateway APIis an add-on containing API kinds

We can make it better, honestly, and support a variety of extended APIs: just thinking of Service Mesh ones (e.g. Istio), Capsule could lock some Tenants in using just a specific class.
We have a boundary with #51, and we should revamp this opportunity with VAP.
I think Capsule could be an easier way to orchestrate policies leveraging native Kubernetes tools and ecosystem.
I'm worried about the support compatibility matrix here since we would need +1.30, even tho VAP seems available as Alpha from 1.26 which is out of the current LTS.
We need a huge effort in designing the API as well as the use-cases, I'd be delighted if community could add their potential use cases here.


Use copy on write when available.

Addresses https://github.com/google/wireit/issues/915
Making this PR just to see if tests pass

It passed, should we merge this?

Yeah, it will help a lot in some cases, noop in others, seems worth it

Just needs a changelog entry


Support for Linux RISC-V

Use case
RISC-V is an upcoming CPU architecture which can similarly to ARM result in very energy-efficient processors. I won't start a discussion on benefits or issues related to RISC-V architecture; there are plenty out in the internet and in scientific environment.
Even though RISC-V is not very common for desktop or mobile devices yet, there is definitely momentum in the development RISC-V. Most major Linux and BSD distributions support RISC-V, such as Ubuntu, Debian or FreeBSD.

Present: not many use cases. There are a few Linux-capable development boards as well as one fully featured desktop SoC available.
Future: expectedly more. There's a lot of ongoing development in the RISC-V community.

And what makes Linux all-day usable: Flutter of course. I would like to have this issue as a tracker for possibly upcoming RISC-V support and implementation.
Proposal
Flutter currently supports amd64 and aarch64 on Linux. I'd propose to add support for RISC-V in addition.
This should mainly consist of:

patches in the engine and Flutter tool to handle RISC-V
pre-built Engine snapshots for RISC-V

Related:

Dart SDK MR: https://github.com/dart-lang/sdk/issues/38587

RISC-V now has experimental support in Dart, and is available for Linux SDKs from our beta channel.

Given the slow CPU and low performance I've seen on the Allwinner D1 when running the Dart compiler, which at the moment is in the cheapest and most readily available development board, I think it would be most useful to start with supporting Linux on RISC-V using the same approach as Flutter has for mobile OS's (Android/iOS) as it would be a much better developer experience vs  trying to do on-device development the way Flutter currently supports on Linux (and MacOS, Windows).

after apple considering risc-v architecture
google recently announced the android risc-v porting (article here)
@zanderso maybe the priority of this is issue should be taken up a notch?

Given the [slow CPU and low performance I've seen on the Allwinner D1 when running the Dart compiler]
Have a look at the StarFive VisionFive2 board which is more adequate for onboard development.

Given the [slow CPU and low performance I've seen on the Allwinner D1 when running the Dart compiler]

@maks Have a look at the StarFive VisionFive2 board which is more adequate for onboard development.

Thanks I do have the Vision five 2, but it's also too slow for reasonable on board development. Even a RPI4 is really too slow in terms of Dart compile times for decent DX when trying to do onboard development.

Since Dart has RISC-V support now, at least as far as I can tell with Flutter 3.19.4 using Dart 3.3.2, what is missing from having RISC-V support? Is it a "try and see what happens" sort of situation?

@RossComputerGuy I'd guess first step is for the Flutter team to decide that they want to support RISC-V as a target for Flutter, as only they can setup the required CI infrastructure support to build the Engine for RISC-V, as Dart SDK is only half the story, the Flutter engine would also need to be built for RISC-V.

We're keeping a close eye on developments in the RISC-V space, but adding support for it to Flutter is not on our roadmap for this year.

Since ARM and RISC-V are both RISC, and they already have ARM support, RISC-V's architecture support request should be turned off

@eatradish This issue is specifically about RISC-V, not about support for any RISC architecture. (ARM has been supported for a while, but ARM support is very different from RISC-V support.)
And since RISC-V is not yet supported, this issue should remain open.

@eatradish This issue is specifically about RISC-V, not about support for any RISC architecture. (ARM has been supported for a while, but ARM support is very different from RISC-V support.)
And since RISC-V is not yet supported, this issue should remain open.

But how about https://github.com/flutter/flutter/issues/150390 ?

Am 23. Oktober 2024 12:15:43 MESZ schrieb Mag Mell @.***>:

@eatradish This issue is specifically about RISC-V, not about support for any RISC architecture. (ARM has been supported for a while, but ARM support is very different from RISC-V support.)
And since RISC-V is not yet supported, this issue should remain open.

But how about https://github.com/flutter/flutter/issues/150390 ?

LoongArch and RISC-V are completely disjunct. Please, remove the duplicate tag from #150390  and reopen it.

LoongArch and RISC-V are completely disjunct. Please, remove the duplicate tag from #150390 and reopen it.

@huycozy
I think @xypron is right about LoongArch not being RISC-V compatible
that said I think there is microscopic use case in supporting LoongArch
nobody will ever use it outside china and even china is betting big on RISC-V
so maybe in p3 limbo?

@iapicca

nobody will ever use it outside china

But there are a lot of Chinese users, it's still a nice-to-have. LoongArch CPUs aren't banned anywhere, and in fact I'm currently using one in the US.

and even china is betting big on RISC-V

Yes, but I believe RISC-V support and LoongArch support aren't mutually exclusive. I would really appreciate re-opening #150390.
LoongArch CPUs are fast enough to run pretty much any desktop applications, this comment is typed on a Loongson 3C5000 desktop. I would really appreciate if you could add LoongArch support.

Yes, but I believe RISC-V support and LoongArch support aren't mutually exclusive. I would really appreciate re-opening #150390.

@RedL0tus
I'm in favor of reopening for tracking and accepting PR
I believe team's effort would be better spent elsewhere
@huycozy I think these last comments (including mine) should be marked off topic

LoongArch and RISC-V are completely disjunct. Please, remove the duplicate tag from #150390  and reopen it.

@xypron, @RedL0tus: The information at https://github.com/flutter/flutter/issues/150390 was quite limited. Please help to open a new issue with all the details in feature request template (similar to how this issue has been outlined) for LoongArch. Thanks!


Toolbar and IconToggle

When I insert  into rightElement, onRightElementPress func has been overwritten, It's not executed func itself.
If work like example, insert name's icon need to display, I normal active!
I have a question,  which libs of Icon for Toolbar ?
I'm not find out the name of LogOut icon for using!

Hi. You can find it in this web: https://oblador.github.io/react-native-vector-icons/
with category "MaterialIcons"


native filesystem extension: Clean up the code.

Oh boy, where do I even start? This extension has been pretty much
unmaintained since 2014, does not really implement any actual spec and
was using the Promises polyfill from the sysapps code. It was the
latter that prompted me to take a look at it, and this is what I came up
with.
All the commits but the last one are small groundwork, and the last
change is where the big cleanup is actually performed. Quoting this last
commit's commit message:
Make the code more readable and trim all the unnecessary fat from both the
C++ and the JS sides to the extent that keeping backwards compatibility
allows us (i.e. synchronous functions remain synchronous, async functions
that use callbacks instead of Promises continue doing so etc).

Remove all the pseudo-Promises silliness: manually keeping a list of
Promises (which were just using the sysapps polyfill instead of actual
Promises) and manipulating it whenever a message was passed or
received was just bonkers.

Remove all the manual message passing code. Creating a msg
dictionary with a loosely-defined syntax does not make sense, we can
just leverage the support code from xwalk_internal_api.js that takes
care of keeping track of each message, correctly forwarding all
parameters and invoking an optional callback when a response is
returned from the C++ side.

Consequently, this also allows us to register a specific handler for
the newly-introduced "requestNativeFileSystem" message instead of
implementing a catch-all HandleMessage() function.

Another consequence of this change is that we now return a simple
error string when an error occurred instead of packing the whole thing
into a JSON string with a lot of unnecessary additional data. This
error message gets turned into an Error object. It is the only
somewhat backwards-incompatible change in this commit. I believe the
benefits of doing error handling more sanely outweigh the cons here.

Add an IDL file describing the parameters we pass to
requestNativeFileSystem() to avoid doing a lot of manual argument
parsing in OnRequestNativeFileSystem (previously HandleMessage).

Replace all the FileSystemChecker complication with a single,
internal function.

With this change, the Promises polyfill in the sysapps/ directory no
longer has any users, and can be safely removed in another commit.

lgtm


Human-readable formatting of large numbers

Is your feature request related to a problem? Please describe.
The "stats" tab of a docker container contains many large numbers that are difficult to understand and parse. For example:
cpu_stats
  cpu_usage
    total_usage:<PHONE_NUMBER>0
    usage_in_kernelmode:<PHONE_NUMBER>
    usage_in_usermode:<PHONE_NUMBER>0
memory_stats:
  limit: 157286400

Describe the solution you'd like
It would be helpful to format this for human consumption. For example, adding a separator every 3 digits would help.
Separately, it would be helpful to convert large number of bytes into MB or GB to make it easier to understand.
Describe alternatives you've considered
Copy/pasting numbers from the screen and breaking out a calculator, but this makes it very hard to quickly scan a container's stats.

In the context of cpu usage (and across all the values really) you need to add units of measure because it's not obvious what units the number represents.


Sandwich menu

Sandwich menu
To avoid breaking menu on mobile:

Can I work on this?

Yes, sure thing @ShubhamSood1406 !

Do you want all things in the Navigation Bar (including Twitter & Github Icon)?

Do you want all things in the Navigation Bar (including Twitter & Github Icon)?

Hmmm, great question. What do you think is better?
@astenstrasser @marcuxyz any thoughts here? Do you think Twitter and Github Icon should be in the sandwich menu too? If yes, should they be text or icons?


Disable test retrying when running locally

Issue Number
Flaky tests
Overview
This change will make it easier to detect flaky tests when running tests locally.
Retrying on failure is now enabled with an environment variable (TESTS_RETRY_FAILED). This variable is set for CI.
Comments

Needs #2389 merged first.

Testing wiki page

bors r+


Multiple cameras tracking

Hi,
Thank you for your great work!
I would like to use your project by integrating multiple cameras to improve accuracy (without mediapipe). Do you think I can use the same calibration logic as you ?
Thanks!

Hi, multiple cameras is on the roadmap. However it should be possible to do
it yourself if yout want it early.
Im not sure what you mean by "without mediapipe". But the calibration logic
shouldn't pose a problem for this (but this too will be upgraded later).
On Fri, Jan 19, 2024, 4:14 AM carolinelgrd, @.***>
wrote:

Hi,
Thank you for your great work!
I would like to use your project by integrating multiple cameras to
improve accuracy (without mediapipe). Do you think I can use the same
calibration logic as you ?
Thanks!
—
Reply to this email directly, view it on GitHub
https://github.com/ganeshsar/UnityPythonMediaPipeAvatar/issues/5, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AO5J5VRHTYUL4QHQGPBBVZTYPJIRZAVCNFSM6AAAAABCBY5PGSVHI2DSMVQWIX3LMV43ASLTON2WKOZSGA4TAMZQGUYDQMA
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>


Add some instrumentation to SessionPool

There's not much visibility into what happens inside SessionPool, it would be nice to have some instrumentation there.  OpenCensus/OpenTelemetry seems like the right solution longer term, but perhaps we can add something relatively quickly to help with debugging (GCP_LOG or something?) It would be nice to see:

When operations fail
When we've hit the size limit on the session pool (especially when Allocate() has to block for a long time)
Some indication of activity (session creation, deletion, refresh)
Maybe some statistics (current size, total create/delete ops, blocks in Allocate waiting for a session, etc.)

Punting until integration with OpenTelemetry is a thing.

Still waiting on OpenTelemetry

Close, we will reopen when we revisit metrics.


Switch datatables to disable search via config. Enable search for works.

closes #1742
Why was this change made?
Per ticket.
How was this change tested?
Local
Which documentation and/or configurations were updated?
NA


Display helpful text in unconnected power monitor

re #2946, #1943, et. al.

That works, I guess...


Add check for isFetching to waitForTransaction timeouts

The timeout on Adapter.waitForTransaction implementations should wait until the current request finishes if in-flight.
https://github.com/delvtech/drift/blob/main/packages/drift-web3/src/Web3Adapter.ts#L129

I think this actually goes against the spirit of the param.


Multithreaded chunk unload for both unloading and render distance "stuff"

Note: I have not really touched chunk generation with the exception of increasing the load radius to 5 and the chunk width and length to 16 for testing purposes. Chunk loading speed is about the same, though you do not have large lag spikes walking in and out of chunks. It also might help with block placement a little bit, but not much if at all, at least I am not seeing an improvement.
I have experienced one or two crashes and odd spikes of chunk unloading, that being said those have been fairly rare. I am tracking down what causes the former currently. I am also unsure if that crash was due to something that was not mine.
I have placed a mutex on everything that handles the "loaded_chunks" array? dictionary? not sure what it is, I think it is a multi-dimensional array but it does not look like it at the same time. (the problem with dynamically typed languages without great IDE's that you cannot tell what the variable is unless you are in the mindset of the person who made it) grabbing the chunk itself and manipulating it is not mutexed and I would expect that to be handled in the chunk itself if it was a huge concern.

Removed a small not correctly working optimization, that should fix most of the issues I was experiencing.

Seems good to me.

Also worked on porting most of the chunk generation to C#, still broken AF but a MC sized chunk (16x255x16) is doable.
here is an image, if you are wanting to learn C# and want an example you should understand this is (for the most part) a straightforward port of the same logic.
The biggest intentional difference being actually my code since who knew a foreach() loop did not like you editing the values inside it while it was running through the loop.

How big of a performance increase does C# give?

Oh well, I would say it slashes chunk generation time by about 50% from 18.7 or so seconds to ~10 seconds with equivalent configuration settings (the chunk size and the load radius provided by default). Most of the stuttering is gone in-game, the breaking block/(I would assume placing block) stutter is mostly gone though is notably still slightly there. Memory usage is also decreased ~50%, from 1.5GB to 715MB.


Updating Anon Site

Starting PR for this, will need some changes though.

Hmm resolving conflicts is weird if we're directly merging main into sgf-viewer-anon-2 in this PR.
I think we'll have to create a new branch off of sgf-viewer-anon-2, merge main into that new branch, and then create a PR merging the new branch into sgf-viewer-anon-2. I can take a look at doing this now that we've submitted the paper


 Can you provide some details? What native API are you using to get it?

https://stackoverflow.com/questions/20264268/how-do-i-get-the-height-and-width-of-the-android-navigation-bar-programmatically

https://stackoverflow.com/questions/20264268/how-do-i-get-the-height-and-width-of-the-android-navigation-bar-programmatically

@goderbauer any update ? it looks like SafeArea doesn't include the height of this bar in its calculation of the bottom inset.
Also, note not all android devices show this bar. the SO article linked by @rs5173 has some more details.

@goderbauer I've found a similar question in StackOverflow. The answers provided don't work well enough just like what  @rs5173  and @jeduden said.

@goderbauer I've found a similar question in StackOverflow. The answers provided don't work well enough just like what  @rs5173  and @jeduden said.

Any Updates ?

any updates

When will it be updated?

Any updates please?

Currently, I am getting the height of the system navigation bar (Android).
double screenSizeH = MediaQuery.of(context).size.height;
double physicalSizeH = View.of(context).display.size.height;
double devicePixelRatio = View.of(context).display.devicePixelRatio;
print((physicalSizeH / devicePixelRatio) - screenSizeH);
At least it outputs the data correctly for me.

@bekturovv13 Did you not experience any crashes using View.of(context) ?

@bekturovv13 Did you not experience any crashes using View.of(context) ?

No, there don't seem to be any problems.


Add notebooks

Related issues
No Related issues
Description
Added actual notebook examples to the notebooks folder and changed the URL links in Readme file.
Notebooks are are co-authored with Fabio Carta.
Details

thanks @kaoutar55


Feature/upgrade deps

Codecov Report
Base: 88.93% // Head: 88.93% // No change to project coverage :thumbsup:

Coverage data is based on head (46f221e) compared to base (62e346f).
 Consider uploading reports for the commit b7b98c1 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #165   +/-   ##
=======================================
  Coverage   88.93%   88.93%
=======================================
  Files          88       88
  Lines        4806     4806
  Branches      683      683
=======================================
  Hits         4274     4274
  Misses        475      475
  Partials       57       57

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


CSS: Use a post-processor

Not needed right now for the default.css theme, but we're going to need some better tooling when we'll start doing more advanced themes (in order to handle cross-browser compatibility) and expose some colors/spacing as variable for users to build their own themes.
This should fit in the Webpack build process.
(I thought we had an issue about it already but could not find it)

Agreed! PostCss? :D

I'm in love with SASS but happy to give a try to PostCSS. We just need to ensure the resulting CSS file is "readable" -> I assume we'll have users that just want to hack it very quickly.

Yes it should be readable, it seems from the people I follow that are doing a lot of CSS that postprocessors are the way to go for modern CSS stacks.
They are the babel of CSS: write real CSS using latest CSS specs and compile to CSS.
So you won't have to re-learn CSS when new CSS features are released to browsers, you already know them.
I agree it can be a shift from being good at SASS.

I'd love stylus, but no-one loves stylus. :'(

I'd love stylus, but no-one loves stylus.

This solve the question on should we use stylus (just kidding). Stylus + jade are nice indeed if you are in your own environment (not a library).

@pixelastic we'll also need to prepare some mixins/variables/helpers to efficiently work with BEM in the CSS :)

Yes it should be readable, it seems from the people I follow that are doing a lot of CSS that postprocessors are the way to go for modern CSS stacks.

I was speaking about the generated CSS of PostCSS, not the source :)

Both should be readable, it's just CSS. Since there's no nesting it should not go crazy

I'll do a proposal with SASS

We'll start with the working SASS version, open to move to PostCSS in the future.

Do we really want to use Sass and not Scss? Scss is Sass new generation. I personnally have much more experience with Scss and really prefer the new syntax. Scss is also retro-compatible with CSS so it will make building themes for non-experts much more easier.

Do we really want to use Sass and not Scss?

@Shipow and myself prefer SASS but I don't care that much. I'm just afraid we spend soooo much time on choosing a preprocessor, updating themes from one format to another, updating documentation. Just use the one you want and let's move forward.

I'm ok with scss ofc

I'm just afraid we spend soooo much time on choosing a preprocessor, updating themes from one format to another, updating documentation, etc...

Yeah, that was I was thinking as well. When you suggested Sass I did not even think you would go for Sass and not Scss, but as this already was a long discussion I'm ok with just picking something and build.

Yeah, that was I was thinking as well. When you suggested Sass I did not even think you would go for Sass and not Scss, but as this already was a long discussion I'm ok with just picking something and build.

Just go for it if it takes 15min @pixelastic, SCSS is definitely fine. As you said, removing curly braces is definitely a rubyist problem :)


Integration with FSharpLint doesn't work

In VS Options F# Power Tools -> Lint gives An error occurred loading this property page.

@duckmatt could you look at it ASAP?

I cannot reproduce it, unfortunately.

I can't seem to recreate this either, couple of questions to help diagnose:

What version of Visual Studio are you using?* Does this error occur for all projects or a specific project?* Have you tried re-installing the extension?* Is there any related information in the [Activity Log](http://blogs.msdn.com/b/visualstudio/archive/2010/02/24/troubleshooting-with-the-activity-log.aspx
I'll try to take a look during my lunch break and after work

Date: Mon, 12 Oct 2015 02:23:45 -0700
From<EMAIL_ADDRESS>To<EMAIL_ADDRESS>CC<EMAIL_ADDRESS>Subject: Re: [VisualFSharpPowerTools] Integration with FSharpLint doesn't work (#1153)
I cannot reproduce it, unfortunately.
—
Reply to this email directly or view it on GitHub.

What version of Visual Studio are you using?

VS 2013

Does this error occur for all projects or a specific project?

all projects I tried

Have you tried re-installing the extension?

not yet, just updated to the latest version; I will try that now

Is there any related information in the Activity Log

I'm not sure: http://pasted.co/dd0b5288

@sideeffffect could you be so patient to clone VFPT repository, build it and run an experimental VS instance under the debugger (set active project to FSharpVSPowerTools (the only C# one in the solution)) and watch for exceptions?

experimental VS instance

what is that? I'm asking because I can't install any software, I can only use the normal VS 2013 that I have.

It will be launched when you press F5. It's a normal VS, but with clean settings. Also you need VS SDK installed (it's a small VS component).

I'm seeing this too, with VS 2013 and 2015, even with no project/solution open at all. I uninstalled and reinstalled in 2015, with no change.
I can add that the first time accessing options dialog per Visual Studio session, it produces the message stated by @sideeffffect; after that, the "Lint" properties page is completely empty until you restart Visual Studio.
Also, the actual FSharpLint integration appears to work; I'm getting markers for too many class members or too long lambda functions. It's just the settings that aren't accessible.
I have now run it in a VS 2013 experimental instance, and "unfortunately", it's working there. With no project open, I get the correct message about at least one project needing to be open, and when I open one, I can access the "Lint" settings page. Changing settings does not change the linting messages that should change, however.

@TeaDrivenDev Could you try to clear Visual Studio Component Model Cache http://stackoverflow.com/a/17604007 ? Maybe it's something funky with the cache.

@dungpa I tried that in both Visual Studio versions; no change there.

@TeaDrivenDev I don't understand what is difference between using the extension in normal hives and Exp hives here. Could you try with devenv /updateconfiguration as described at http://stackoverflow.com/questions/22300278/registering-an-unpacked-vsix-extension-via-msi-without-using-devenv-setup ? Sorry for the troubles.

I don't think there is a difference between experimental and normal hives per se. I ran VS 2015 with a new RootSuffix and installed only VFPT, and that worked. So the issue is likely something that has "happened" to the other profiles.
I tried running devenv /updateconfiguration and then devenv /clearcache, as explained here (linked from that SO question), but again no change.

Thanks for the information @TeaDrivenDev would you be able to post a list of your extensions? Hopefully with those installed I may be able to recreate the error
@dungpa Is this an expected way to retrieve a list of project paths? I'm thinking isn't related to another extension, it could be to do with the use of EnvDTE here

@duckmatt I don't think it's related to getting the project paths, because the behavior is already wrong when there is no project open at all (error message vs. "no project open" message).
My installed extensions in VS 2015 (slightly different in 2013) are the following:
Better Start Page
CodeLineage
CodeMaid
File Nesting
Git Diff Margin
Git Tools
MultiEditing
NCrunch
OzCode
Paket
Productivity Power Tools
ReSharper
Smooth Caret
SwitchStartupProject
TabSanity
Web Essentials
I have now installed all except ReSharper in my above mentioned new test hive, and it still works there.

@TeaDrivenDev @sideeffffect I produced a new build v2.1.1 that includes some more logging https://ci.appveyor.com/project/dungpa/visualfsharppowertools/build/2.2.0-a1510132010/artifacts.
If you install this version and enable Diagnostics mode http://fsprojects.github.io/VisualFSharpPowerTools/faq.html#What-is-Diagnostic-mode-When-should-I-use-it, there might be some logs for us to find out the root cause. Thanks.

That outputs this when switching to the "Lint" properties page for the first time in VS 2015 (nothing at all in 2013, though):
[VFPT][Error 10:47:04 ] Exception Message: 'Cannot set unknown member 'System.Windows.Interactivity.InvokeCommandAction.Command'.' Line number '84' and line position '45'.
Stack Trace:    at System.Windows.Markup.WpfXamlLoader.Load(XamlReader xamlReader, IXamlObjectWriterFactory writerFactory, Boolean skipJournaledProperties, Object rootObject, XamlObjectWriterSettings settings, Uri baseUri)
   at System.Windows.Markup.WpfXamlLoader.Load(XamlReader xamlReader, Boolean skipJournaledProperties, Uri baseUri)
   at System.Windows.Markup.XamlReader.Load(XamlReader xamlReader, ParserContext parserContext)
   at System.Windows.Markup.XamlReader.Load(XmlReader reader, ParserContext parserContext, XamlParseMode parseMode)
   at System.Windows.Markup.XamlReader.Load(Stream stream, ParserContext parserContext)
   at System.Windows.Markup.XamlReader.Load(Stream stream)
   at FsXaml.LoadXaml.from[a](String file, Type t)
   at FsXaml.FactoryUtilities.loadChildIfNull[a,b](a root, String resourceFile, b self)
   at FsXaml.XamlContainer..ctor(FrameworkElement content, String resourceFile)
   at FSharpVSPowerTools.Linting.LintOptionsControlProvider..ctor()
   at <StartupCode$FSharpVSPowerTools-Logic>.$LintOptionsPage.-ctor@26-182.Invoke(Unit unitVar)
   at System.Lazy`1.CreateValue()
   at System.Lazy`1.LazyInitValue()
   at System.Lazy`1.get_Value()
   at <StartupCode$FSharpVSPowerTools-Logic>.$LintOptionsPage.get_Child@122.Invoke(Unit _arg3)
   at FSharpVSPowerTools.ProjectSystem.VSUtils.protectOrDefault[a](FSharpFunc`2 f, a defaultVal)
[VFPT][Error 10:47:04 ] Exception Message: 'Cannot set unknown member 'System.Windows.Interactivity.InvokeCommandAction.Command'.' Line number '84' and line position '45'.
Stack Trace:    at System.Windows.Markup.WpfXamlLoader.Load(XamlReader xamlReader, IXamlObjectWriterFactory writerFactory, Boolean skipJournaledProperties, Object rootObject, XamlObjectWriterSettings settings, Uri baseUri)
   at System.Windows.Markup.WpfXamlLoader.Load(XamlReader xamlReader, Boolean skipJournaledProperties, Uri baseUri)
   at System.Windows.Markup.XamlReader.Load(XamlReader xamlReader, ParserContext parserContext)
   at System.Windows.Markup.XamlReader.Load(XmlReader reader, ParserContext parserContext, XamlParseMode parseMode)
   at System.Windows.Markup.XamlReader.Load(Stream stream, ParserContext parserContext)
   at System.Windows.Markup.XamlReader.Load(Stream stream)
   at FsXaml.LoadXaml.from[a](String file, Type t)
   at FsXaml.FactoryUtilities.loadChildIfNull[a,b](a root, String resourceFile, b self)
   at FsXaml.XamlContainer..ctor(FrameworkElement content, String resourceFile)
   at FSharpVSPowerTools.Linting.LintOptionsControlProvider..ctor()
   at <StartupCode$FSharpVSPowerTools-Logic>.$LintOptionsPage.-ctor@26-182.Invoke(Unit unitVar)
   at System.Lazy`1.CreateValue()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Lazy`1.get_Value()
   at <StartupCode$FSharpVSPowerTools-Logic>.$LintOptionsPage.OnActivate@86.Invoke(Unit _arg2)
   at FSharpVSPowerTools.ProjectSystem.VSUtils.protectOrDefault[a](FSharpFunc`2 f, a defaultVal)

Every activation of "Lint" after that first time only logs the second stack trace again.

@ReedCopsey Would you mind having a quick look? I guess this is a totally new use case for FsXaml where its XAML control is used as a Visual Studio options dialog by inheriting UIElementDialogPage.
It's really mysterious since the error occurs for some users but not for others. Please see the stack trace above and the code at https://github.com/fsprojects/VisualFSharpPowerTools/tree/master/src/FSharpVSPowerTools.Logic/Linting .
Your help would be really appreciated.

@dungpa I'll take a look and see if I can figure out what's happening.

@dungpa @TeaDrivenDev Given your stack trace, the problem is that it's failing trying to load and setup System.Windows.Interactivity's InvokeCommandAction here: https://github.com/fsprojects/VisualFSharpPowerTools/blob/master/src/FSharpVSPowerTools.Logic/LintOptionsPageControl.xaml#L83-L85
Is there a way to diagnose which version of System.Windows.Interactivity.dll is being loaded in Visual Studio when this fails?  My suspicion is that you're getting the wrong version loaded somehow, potentially from another extension. (It works here, in VS 2013, with no issues...)

@ReedCopsey Hmmm.... fuslogvw.exe, maybe? Worth a try at least, I guess.

So, apparently it is ReSharper. I just suspended it in my normal VS 2015 profile and after restarting VS, I can access the Lint properties page and get no errors logged.

@TeaDrivenDev Can you try running with fuslowvw.exe running on the system that's failing, and send a log of the WPF and System.Windows.* errors?

Installed latest version of extension from AppVeyor. Upon trying to open lint under options VS crashes, this is what the last exception in activitylog.xml had to say:
    Construction of frame content failed.
Frame identifier: ST:0:0:{31fc2115-5126-4a87-b2f7-77eaab65048b}
Frame caption:
Exception details:
System.ArgumentNullException:
Parameter name: protocolHandler
   at Microsoft.XamlDiagnostics.UI.LivePropertyExplorer.Model.PropertyExplorerModel..ctor(IProtocolHandler protocolHandler, IActiveElementTracker tracker, ITelemetryLogger telemetryLogger)
   at Microsoft.XamlDiagnostics.Model.XamlDiagnosticsTool.GetPropertyExplorerModel(IServiceProvider serviceProvider)
   at Microsoft.XamlDiagnostics.Model.XamlDiagnosticsTool.CreatePropertyExplorer(IServiceProvider serviceProvider, ResourceDictionary themeDictionary, UIElement searchContentControl)
   at Microsoft.VisualStudio.ClientDiagnostics.XamlDiagnostics.PropertyExplorerToolWindow.GetContent()
   at Microsoft.VisualStudio.ClientDiagnostics.XamlDiagnostics.XamlDiagnosticsToolWindowBase.ShowContent()
   at Microsoft.VisualStudio.ClientDiagnostics.XamlDiagnostics.XamlDiagnosticsToolWindowBase.Initialize()
   at Microsoft.VisualStudio.Shell.WindowPane.InternalSetSite(IServiceProvider p)
   at Microsoft.VisualStudio.Shell.WindowPane.Microsoft.VisualStudio.Shell.Interop.IVsWindowPane.SetSite(IServiceProvider psp)
   at Microsoft.VisualStudio.Shell.WindowPane.Microsoft.VisualStudio.Shell.Interop.IVsUIElementPane.SetUIElementSite(IServiceProvider p)
   at Microsoft.VisualStudio.Platform.WindowManagement.UIElementDocumentObject.SetSite(DocumentObjectSite site)
   at Microsoft.VisualStudio.Platform.WindowManagement.DocumentObjectSite.InitializeDocumentObject(Object punkView)
   at Microsoft.VisualStudio.Platform.WindowManagement.WindowManagerService.CreateContentPane(FrameMoniker frameMoniker, Boolean isDocument, String lpstrMkDoc, UInt32 eCreateWindowFlags, Object punkView, Object punkData, IServiceProvider pServiceProvider, IVsUIHierarchy pUIHierarchy, UInt32 vsid, Guid rguidCmdUI, ViewGroup parent, IVsWindowFrame& ppWindowFrame)
   at Microsoft.VisualStudio.Platform.WindowManagement.WindowManagerService.CreateContentPane(String pszName, Int32 fDockViewOn, Int32 fDocument, String lpstrMkDoc, UInt32 eCreateWindowFlags, UInt32 dwToolWinId, Object punkView, Object punkData, IServiceProvider pServiceProvider, IVsUIHierarchy pUIHierarchy, UInt32 vsid, Int32& pfDefaultPosition, Guid& rguidCmdUI, IVsWindowFrame& ppWindowFrame)
   at System.Runtime.InteropServices.Marshal.ThrowExceptionForHRInternal(Int32 errorCode, IntPtr errorInfo)
   at Microsoft.VisualStudio.Shell.Package.CreateToolWindow(Type toolWindowType, Int32 id, UInt32 flags)
   at Microsoft.VisualStudio.Shell.Package.CreateToolWindow(Type toolWindowType, Int32 id, ProvideToolWindowAttribute tool)
   at Microsoft.VisualStudio.Shell.Package.FindToolWindow(Type toolWindowType, Int32 id, Boolean create, ProvideToolWindowAttribute tool)
   at Microsoft.VisualStudio.Shell.Package.CreateToolWindow(Guid& toolWindowType, Int32 id)
   at Microsoft.VisualStudio.Shell.Package.Microsoft.VisualStudio.Shell.Interop.IVsToolWindowFactory.CreateToolWindow(Guid& toolWindowType, UInt32 id)
   at Microsoft.VisualStudio.Platform.WindowManagement.WindowFrame.ConstructContent()

Did not happen in the experimental hive.

@ReedCopsey Even when I set it to "Log all binds to disk", System.Windows does not show up in the entire log from starting VS until activating the "Lint" properties page.
Another thing that might be worth a try (now that we probably know the culprit) is installing ReSharper in the Exp hive and then debugging VFPT.

@duckmatt @dungpa This could be worked around by just removing the references to System.Windows.Interactive here https://github.com/fsprojects/VisualFSharpPowerTools/blob/master/src/FSharpVSPowerTools.Logic/LintOptionsPageControl.xaml#L83-L85 and https://github.com/fsprojects/VisualFSharpPowerTools/blob/master/src/FSharpVSPowerTools.Logic/LintOptionsPageControl.xaml#L8  and then, instead, hooking into an event like this one https://github.com/fsprojects/VisualFSharpPowerTools/blob/master/src/FSharpVSPowerTools.Logic/Linting/LintOptionsPageControl.xaml.fs#L54
All it's doing is firing the command - that could be handled by an event instead.

@TeaDrivenDev @sideeffffect We need help to verify whether the bug has been fixed in https://ci.appveyor.com/project/dungpa/visualfsharppowertools/build/2.2.0-a1510140720/artifacts ?
Thank you.

@dungpa Yes, it is for VS 2015; it doesn't even offer installing to 2013, though.

works on VS 2013 :smile:
thank you

Thanks guys.

Any idea why I might not be able to install this in VS 2013? I can (re)install the released version from the gallery, and I could install yesterday's version with the extended logging, but this VSIX behaves as if it was built for 2015 only.

The two versions in this thread have the same version number, so you have to uninstall it from VS 2013 before installing again. VSIX installers skip VS 2013 because it sees that the same version has been installed.

That worked for 2015, but I still get "This extension is already installed to all applicable products." after uninstalling from 2013 and running the VSIX. Oh, and that happens now with yesterday's version too, which I could install then. Installing the released version from the gallery still works fine. It looks like it thinks 2.1.1 is still installed (but lets me install 2.1.0 nonetheless). I have tried all the cleanup methods from yesterday again, but none helped.


Update sublimetext.sh

download url has changed

see also see also https://github.com/Installomator/Installomator/issues/623 , https://github.com/Installomator/Installomator/issues/578 , https://github.com/Installomator/Installomator/pull/626 , https://github.com/Installomator/Installomator/pull/567

thanks!


Direct Mode w/ DK1 results in [NVAPI_RESOURCE_NOT_ACQUIRED] after 12 seconds of rendering

Hi,
I'm currently trying to get Direct Mode working with the Rift DK1 and OSVR-OpenHMD, as Extended has always felt off to me and made me feel dizzy. The D3D sample renders properly, with some strange jitter and a ~50fps framerate, but only for ~12 seconds before I receieve this error:
Apr 04 22:34:45.499 error [RenderManager]: OSVR RenderManager Warning: Got error from NVIDIA API: NVAPI call returned -203 (hex: ffffff35)
Apr 04 22:34:45.500 error [RenderManager]:  [NVAPI_RESOURCE_NOT_ACQUIRED]
Apr 04 22:34:45.500 error [RenderManager]: RenderManagerNVidiaD3D11::PresentFrameFinalize: Could not present surface 0 to display 0
Apr 04 22:34:45.501 error [RenderManager]: RenderManager::PresentRenderBuffers(): PresentFrameFinalize failed.

My RenderManager config is here.
With the SteamVR plugin, SteamVR exhibits the same behaviour - renders perfectly fine, but drops after around 12 seconds.
I'm using a GTX 1050 Ti.

Yeah, seems to be with my system config. After consecutive power cycles of the Rift box, it'll exhibit the same behaviour. Letting a sample crash then power cycling seems to fix it.


Make SC config APIs consistent

If you want this feature to be implemented, give it a thumbs up reaction, so that we can determine which features are important to you.
👍

Fixed by #1652


Query Internships Endpoint

API endpoint for querying past internships of other students. Should return at most 12 - n internships (n = number of previously found internships for current user). Should send confirmation request first if there are more than 6 results for the given filter parameters.
Filters:

[ ] Paid/unpaid
[ ] Location
[ ] Area of work
[ ] Programming language

still missing:

confirmation request
returning random set of internships out of all results
options filter is not working


Automatic Installation failure: Illegal option -o pipefail

I tried running the automatic installer but this part here caused it to automatically end:
set -euo pipefail

with error
sh: 8: set: Illegal option -o pipefail

I couldn't find the root of this issue, however the manual installation worked perfectly.

curl https://raw.githubusercontent.com/srevinsaju/zap/main/install.sh | bash -s

Can you check if the above works without errors?

Yes, that helped me get past line 8.
I got an error about not having jq installed on my system, but I didn't get anything like that using the manual installation snippet you have on your readme page.
I installed that package and now it's run completely without issues.

Thanks for testing, I will update the README with the changes from sh to bash.

I got an error about not having jq installed on my system, but I didn't get anything like that using the manual installation

@CypherpunkSamurai would you like to add the required dependencies for your installation script on the README ?

Sorry, I should have mentioned that it wasn't an error-error. It is on the README already, I just wasn't expecting there to be another requirement in the automatic installer.

oh nvm, it was already on the README haha, thanks again @CypherpunkSamurai sorry lol


Danish

Merged latest master, cleaned up and switched to AOSP dictionary

Published to Play-Store.

https://gitlab.com/fdroid/fdroiddata/merge_requests/2147

@friesenkiwi one of the comments on the Danish pack says "Missing even the simples words in Danish."
Any ideas?

@ menny Huh, not really, no sorry, my generated words_from_aosp.xml has 178450 words and includes words with the danish special letters ø,å, æ (both upper and lower case). Is the ASK main app accessing and suggesting them?
Unfortunately I can't see the danish comments/reviews at https://play.google.com/store/apps/details?id=com.anysoftkeyboard.languagepack.danish.


Table: Hide Vertical borders of cell

Description

Added a property called  cellVertcalBorderless to toggle between the visibility of cell's vertical borders
References
Fixes #2675

Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] Documentation update

How Has This Been Tested?

Checklist

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules
[x] I have checked my code and corrected any misspellings

@ElishaSamPeterPrabhu Looks good to me, I can merge this PR once you fix the typo 'cellVertcalBorderless ' in the storybook changes


Discussion: Assign a11y reviewers within the team

We are the UI and a11y WG, however we have varying levels of proficiency in a11y.
This means that even a PR reviewed by the UI and a11y WG might miss checking for a11y.
I want to suggest assigning a111y reviewers on the WG (and adding folks from the wider AMP community who can review a11y) who must LGTM code that affects a11y.

Are we planning to recommend places for people to ramp up on a11y knowledge?

Is the question for the Working Group of for the general AMP Project?
If latter: We should have a reference page from CONTRIBUTING.md
For the WG, we should be doing more active audits of the components with a11y experts to help upscale knowledge.
cc @sparhami who suggested this.


Bump base images to latest versions

As prompted by #4033
NONE

/cherry-pick release-1.6

/cherry-pick release-1.5

/kind cleanup

#4588 failed to apply on top of branch "release-1.5":
Applying: bump base images to latest versions
...
error: Failed to merge in the changes.
...

Done manually in #4590


Rename container -> app

Rename "container" to "app" in the RoutesCollection abstract class, and in the Hooks Definition Helper.

Resolved


The time indicator interval is now handled by TimeGrid

Fixes: https://github.com/intljusticemission/react-big-calendar/issues/1017

Unfortunately this pr also contains the changes from https://github.com/intljusticemission/react-big-calendar/pull/1018 but I take it that 1018 will be merged anyway.

I think i'm pretty comfortable not fixing #1018, it's a real edge case, and now is used a lot of places besides this one which would still be sort of broken even with this change.

Is there any reason why you don't want to at least fix this one? I don't see any possible downsides.

The downsides are minor, but big enough that i moved from having the indicator in the TimeGrid to the DayColumn. We want to avoiding keeping an interval state value in the grid to reduce unnecessary cascading updates in components that don't need it. In this case the whole grid updates to move the line in one column. IT doesn't seem like a big thing, but especially with Resources full rerenders can be costly. It's a minor thing but that's weighed with i think a minor bug

Got it, closing for now then.

@jquense I'm re-opening this because I'd like to fix the issue.
This time, I created a standalone component called TimeIndicatorLine that only updates itself every minute.
That way we avoid unnecessary cascading updates, and update the indicator line.
Also, because the current active day background of the current day remains the same even even if a day changes, I added a timer inside TimeGrid that ONLY updates the TimeGrid if the day changes (that means 1 re-render per 24 hours which I think is fine).
Can you review that please?
It should be pretty straight forward and without side-effects when it comes to performance.


[Announce] Error -document is not defined when using with Next.js (SSR context.)

Bug report
Current Behavior
When using Announce in Next.js SSR. I get the error document is not defined.
Expected behavior
The component should render on the server and not throw any errors.
Suggested solution
ownerDocumentRef is initialized with document
https://github.com/radix-ui/primitives/blob/8b012b7e1eab0033b73031d47051e92a816bd103/packages/react/announce/src/Announce.tsx#L102
Your environment

Software
Name(s)
Version

Radix Package(s)
@radix-ui/react-announce
0.1.4

React
n/a
17.0.2

Browser
Firefox
Firefox

Assistive tech
n/a
n/a

Node
n/a
16.13.0

npm/yarn
pnpm
6.24.4

Operating System
macOS
11

Hey @heyitsarpit,
We have been talking about deprecating it as part of the next release because it isn't used at all internally and isn't really a good fit with our model of having components more geared towards use-cases.
May I ask what you are using the component for?
🙏

@benoitgrelard, I used it for notifications and error announcements, I only used since Radix has it, otherwise I would not have considered the accessibility of these components. If it's being removed, that's not much of an issue for me.

Yeah so this is where more dedicated components might make more sense. For example we have Toast: https://www.radix-ui.com/docs/primitives/components/toast.
Would that cover your use-case?

For example we have Toast:
A toast is not the most appropriate component for my use case.

For e.g. a warning box that pops in when some input parameters are off, and we need to be closer to input, so they're hierarchically close together. (I observed the error for a  different component, that was server rendered.)

Yep, this is something we've discussed, that's more like form errors.
So on the same vain, it's likely we would create form primitives and we'd have Form.Error or something like that, which would handle the accessibility.

Closing down as we have now deprecated this package as discussed previously.


Improved Electrum App Page

If you install ElectRS (a Electrum Server) thru the WebUI you will get now a special App-Page with all the technical details you need to connect your node that looks like this:

For a bounty it can make sense to improve the content of this page to guide and educate the use what Electrum is and teach the most interesting use cases.

@rootzoll check the shell script if that is givin the correct state

OK @cstenglein targeting for RC1

OK done - see: #771 .. make sure to use latest WebUI for v1.11.3 - set to final testing


[Storage] Migrate azure-storage-queue to track2 sdk

Description

Testing Guide

History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change
[Component Name 2] az command b: Add some customer-facing feature

This checklist is used to make sure that common guidelines for a pull request are followed.

[ ] The PR title and description has followed the guideline in Submitting Pull Requests.

[ ] I adhere to the Command Guidelines.

[ ] I adhere to the Error Handling Guidelines.

Storage


missing arduinofake.h library

I cannot perform PIO test on your project. They are missing quite a few libraries in the Test folder, so can you fix it for me?

Hi @khunglong207 unit test works only with native environment, and you need to have gcc insatelled in system. Try command pio test -e native

Hi @rtlopez  I tried it but it didn't work, The screen appears as follows:

And then I tried testing but the system still reported missing arduinofake.h library. Can you send me the root directory containing this library because I am working on a project and developing the raspberry pi system to do image processing. So I really need your help.

@khunglong207 You are still running test for esp8266 environment. Select native in bottom bar.

i am using esp8266 microcontroller, so i set 8266 environment.

Can you make a video about setup, I'm quite a noob about this issue

I think the tests are meant to run with 'default' env, that does not affect your 'esp8266' code

Het bro can u help ke connect from esp 8266 to beta fight

@Mathew3000
I TRIED trying to connect to beatfight but the system indicator is as shown below. How can I connect to betafight even though the baud rate I have set is 115200?

I use an esp32, but betaflight connects automatically as soon as I plug the esp into my computer, the message you see there indicates that the Configurator could not talk to / find a Betaflight controller on the port you selected

@rtlopez , @Mathew3000
i don't understand what is the problem here, i have an esp8266 circuit. I connected to the computer and then I imported the code into the device. Then when it comes to the test environment, the system reports missing libraries like arduinofake.h; fakeit.h; ….
Connecting to betafight software, the system indicates USB reception as ttyUSB0 but cannot connect as shown above. Help me

Hi @khunglong207 could you elaborate what are you trying to achieve?
To use this project you only need to run build and flash pio targets. Unit tests are designed to be able to run on local machine only and in the CI/CD pipline. On esp8266 ArduinoFake library is in conflict with Arduino.
About connection issues, ensure that user you are logged in, is assigned to dialout group on Linux. Without that you will not be able to connect and flash device through /dev/ttyUSB0. This command might help sudo usermod -a -G dialout $USER, and then logout and login again.

hello @rtlopez
I am trying to make a flight controller on a quadrotor with an esp 8266 that uses an MPU6050 sensor; GPS
So first I tested the gryscope system by connecting the esp8266 and MPU6050 as shown in picture

First I flash like the instructions you told me in github, I flash successfully as shown below (I used your latest version RC-02).

Then, I build code using by platformIO from VS code, next I Pio run.
I opened betafight but it didn't work, even though I selected the correct tty/USB0 and the baudrate was 115200. I tried the code "sudo usermod -a -G dialout $USER" but it didn't work. What should I do next steps?
https://github.com/rtlopez/esp-fc/assets/142283805/2690d5db-d174-4c68-bce1-49d08042d6df

hi @khunglong207 go to the options, and disable "advanced cli autocomplete". Let me know if it help, so I'll add this information to the redame file.

@khunglong207 Also after flashing power cycle board by removing USB cable from port. For unknown reason betaflight-configurator is not able to connect right after flashing.

The topology has been followed but it still doesn't work, can you teamview it with me?

@khunglong207 try to connect using vscode terminal. If there are no messages, type reboot then later type status and paste result here.

@rtlopez
How to connect terminal vs code, I'm new so I don't really understand

In the video, I connected using the platform in vs code so I'm pretty sure the code was run on esp8266 but even in betafight it still didn't work.

@rtlopez
i REBOOT AND STATUS IT

@khunglong207 first picture shows that firmware works fine, gyro is correctly detected. I have no idea why configurator won't connect, it must be somethin with your system. I need some answers

Do you use more than one esp module? on first photo I see there is chip CH340, whilst on the screenshot above i see that that there is CP2102. Are you connecting to correct device? post here result of lsusb command, when board is connected.
are you connected in vscode terminal? You cannot use both at the same time.
Can you post here screenshot of the options tab?
what distribution and kernel version are you using?
try diferrent version of configurator 10.7 and 10.9 should work too.

somehow i managed to connect to cp2102 drive with betafight but i can't connect to ch340 version i think because the drive version is different.
If I'm connected to betafight, I want to test run my motor, how can I do that? I'm in the motor section, but I don't know how to start it up. Can you help me?

Have you ever worked with Betaflight?
At this stage it should be basically just Betaflight standard stuff.

REMOVE YOUR PROPELLERS
connect power to your ESC
Toggle the "testmode switch"
SLOWLY move each motor slider up and down

You should set the Flash Address to 0x0000 instead of 0x00

That should not make a difference, as both Values are refering to the start of the memory, same as 0x01 is the same as 0x0001

That should not make a difference, as both Values are refering to the start of the memory, same as 0x01 is the same as 0x0001

No, I also encountered this problem, this is my solution

I'm not doubting you, but that seems strange to me :D but I will remember :D

I'm not doubting you, but that seems strange to me :D but I will remember :D

Hahhh, it's not that you doubt it, but that I happen to have encountered this problem as well

Thanks for all
but brushless motor not run this videohttps://github.com/rtlopez/esp-fc/assets/142283805/89dbacc8-b38f-42ae-bc98-e7069b94d40e

Did you select a motor protocol? and use the correct pins? because the beeping on your motor means the esc has not been initialised. This seems to be a PWM esc?

yes this is brushless motor kv2212
esc XT60 ESC 40A
i connected correct Pin

Did you select the correct motor protocol? Because as long as the ESC is not initialised nothing will happen.

i don't have a controller so i don't know the motor's protocol
can u help me

I mean, I can but don't you think it would be better to get a general understanding of what you are doing? I'm not sure if you should just use a FC project without knowledge of your stuff and just YOLO it... that seems dangerous.
If I need to guess I'd say you need to use PWM.
Also I would suggest you close this Issue, as this has nothing to do with the arduinofake library.


Quick prototype of Streetcomplete colors and an explicit curb

This is a followup to @westnordost's suggestion in #704 to draw a more explicit curb between the road and sidewalk. I incorporated a few more ideas here too, pulling lots of colors from Streetcomplete (https://user-images.githubusercontent.com/7988080/103153247-827c1f00-478f-11eb-9d1f-4d12017533aa.png) and also its map style (https://raw.githubusercontent.com/ENT8R/streetcomplete-mapstyle/gh-pages/images/light.png). I'm really liking how things are looking and am considering a big color overhaul based around this. Any initial feedback? @Robinlovelace, @michaelkirk, @trangrei
Some of the changes:

Using Streetcomplete colors for the map background, water, parks, unzoomed roads
Drawing a bold line between the road and curb. (There are some bugs near intersections that I'll fix if we decide to push forward with this style.)
Use Streetcomplete color for zoomed-in lanes
Stop coloring intersections and parking lanes a different color. It usually doesn't match reality; just show paved surface, and add markings on top of that.

If we go forward with this, there's lots of code simplification I'll do, and rethinking the styling for bike/bus lanes, access-restricted roads, night mode, etc. Also need to make sure layers and agents look good on this scheme.
We could also just incorporate a few of the ideas -- the color changes and adding the curb could be independent steps.
Before:

After:

Before:

After:

Before:

After:

Wow, cool, I feel honored you were inspired by StreetComplete! I'd like to give you feedback on this too:
Background
Note that this map style (link to a demo slippy map) with its subtle pastel tones was created with the purpose of serving as a background map that is used for orientation only with the goal to not divert so much visual attention from the real focal point of the app: The map pins.

The purpose of the map is different for your app:

For the minimap, you probably want a good overview for orientation, with a focus on the street layout and arterial roads
For the main view, the focus is on street layout, so that should stand out while the rest is secondary

Now, of course I wouldn't have created that map style together with @ENT8R if I wouldn't also find the map colors visually pleasing. I just think that based on your requirements, you might want to make a few adjustments.
Positive Feedback

I think the dark border on the sidewalk that represents the curb looks very good!
I like that the standard background is not light grey but this light beige. When all shades of gray are reserved for streets, they stand out better. Also it adds a little variation in color, which is nice
I also like the more subtle green for green areas. As the green areas are really not anything important in your app, it is much better if they don't stand out that much
I like that you removed the color difference from street and intersection because this is a technical detail that is not interesting for the user
The sidewalk is now better distinguishable from the background, wich is good

Suggestions for changes
Main View

since the street layout is the focus point of the app, I'd go with higher contrast here (darker asphalt surface).
again, as the street layout is the focus point, in general it is OK to use more flashy colors as for the background map. The green cycle lanes are already flashy. Specifically, I would definitely make the parking lanes stand out from the roads in one way or another - maybe use blue as a background? In your current prototype, it is not good that they are not so well distinguishable from a normal car lane
The reason why buildings on the streetcomplete-mapstyle are light gray blue is to better distinguish them from other elements. This is even more relevant for your use case: Your streets are road. You would not want anything else that is not a road be gray too so that this could be confounded with roads.
The zebra strip spacing seems to be messed up. Should be either thicker equally spaced lines or thin lines like here  (source)
Even if there is no sidewalk and thus maybe no curb, I'd experiment with always drawing such a dark kurb line at the border of a street surface, just so that it visually "lifts off" from thebackground map a little
The green turn arrows were better visible before. Maybe you should think of a color/hue that is not used on streets and reserve that color for such arrows (green is used, by cycleways). I guess these must be especially flashy because they should stand out from the road which already stands out - Orange maybe?
Road names on the streets add to visual clutter. I.e. there is already a lot going on the streets itself, you'd not want to have elements that don't need to be on the street to take up space. Suggestion: Move the street name to beside the street (on the beige background). Then, they could also be larger, in the background

Minimap
Roads should stick out more. You could try

give motorways a distinctly different color than any other road
use different colors for roads with different numbers of lanes, i.e. large arterials are f.e. redder than less important roads
maybe don't even display buildings or make them even more subtle
alternatively, you could try giving the roads a thin (gray) border so they stand out from the background more

Big and broad :+1: for the general direction of travel indicated by the images at the top of this PR. Not looked at detail, looks like plenty of detailed comments which sound sensible to me. I think these are definite improvements to the aesthetics and are good enough for now and safe enough to try: the overall feel of the new colours is more pro and subtle IMO, enabling grey roads which are easier on the eye. I agree with @westnordost's comments, especially that

When all shades of gray are reserved for streets, they stand out better. Also it adds a little variation in color, which is nice

Also :+1: to this suggestion (I have the same strong preference for roads that do not allow through traffic for large motor vehicles which I think would work well as a shade of grey-green - linked to #660 ):

Specifically, I would definitely make the parking lanes stand out from the roads in one way or another - maybe use blue as a background

and simplifying the minimap.

I agree with everything @westnordost said. Thanks for taking the time to look!

The green turn arrows were better visible before.

Part of the issue I think is that these arrows animate: starting bright and fading as the signal is about to change - this isn't apparent in the screenshots, so they just look worse than they actually are in game play:

But even when they are fully opaque, I do think some contrast was lost, e.g. in this one:

Also unfortunate: because of the lightening of the background, the "yield" turns, which are dashed and outlined, now appear more prominent than the straight arrows, which I think is the opposite of what we want.
Maybe either: outline the straight arrows (and probably add a z-index to the straight arrows to avoid collision?) -or- lighten the outline around the dashed arrows.

Wow, thank you all for the detailed feedback! Loads of ideas surfacing. To not lose track, I'm iterating on some of them under the experiment flag of an existing alternative color scheme. In particular, the curb geometry is now improved, though there are still some bugs I know about.

Not to increase the scope of this color revamp even more, but one possibility it might open is to expose the road classification (highway, arterial, residential) in the zoomed-in view. This is something I've wanted to do since the very beginning, because it's easy to get disoriented when zoomed in. And unlike other renderers, just drawing arterial roads with greater thickness doesn't work -- the road width is independent of classification, and in parking-dense places, not easy to tell residential vs arterial at a glance. That's what the orange and white colors in the screenshot above show. (I don't think the colors there are good at all; it's just an existing color scheme that was already trying to draw curbs. So I'm iterating on the curbs there, before checking in this PR.) That experimental color scheme with the curbs is live here: http://abstreet.s3-website.us-east-2.amazonaws.com/dev/abstreet.html?--dev&--color_scheme=faded zoom&system/us/seattle/maps/montlake.bin&--cam=20.01/47.64100/-122.31300
A task list for me:

[ ] Look at night mode again
[ ] Increase the contrast of the asphalt
[ ] Style parking lanes more dramatically
[ ] Shift building colors away from grey; they shouldn't look anything like roads
[ ] Try a curb even for roads without a sidewalk, like highways, for better contrast
[ ] Overhaul traffic signal colors, and the editor icons
[ ] Consider moving street labels out of the road. Could be related to #173
[ ] Rethink the minimap -- remove buildings, emphasize road classification more

And addressing some feedback:

The zebra strip spacing seems to be messed up. Should be either thicker equally spaced lines or thin lines like here

Assuming you're talking about the crosswalks, I've come across many different styles for these. It seems to be a pretty regional thing. Probably A/B Street should support multiple styles for different areas. This is also true for cycle lane coloring; I see lots of red in the UK and Europe.

I have the same strong preference for roads that do not allow through traffic for large motor vehicles which I think would work well as a shade of grey-green

I think this more neutral grey asphalt is working better with partly transparent layers on top, so definitely need to revisit access restriction styling with this change.

not easy to tell residential vs arterial at a glance

By maxspeed? The higher the maxspeed, the broader the lanes are usually required to be.

Is there a list of traffic signs that you are displaying or are planning to display?

The zebra strip spacing seems to be messed up. Should be either thicker equally spaced lines or thin lines like here

Assuming you're talking about the crosswalks, I've come across many different styles for these.

Really? But are they anywhere ║║    ║║    ║║ (exaggerated) instead of ║║║║║║?

By maxspeed? The higher the maxspeed, the broader the lanes are usually required to be.

I meant it's hard to tell visually. Which road here has more traffic?

From my memory of this place, the arterial isn't that much wider. Satellite mostly confirms:

So I'd like to somehow style arterial and local roads differently when zoomed in. This is an old experiment, maybe different shades of the grey asphalt in this PR could work.

Also in Seattle, official signed speed limit is actually kind of useless to emphasize. Most places within the city are now technically 20-25mph, whether a tiny residential road or multi-lane arterial. Of course in practice, vehicles go much faster on the arterials, because the roads are physically designed for it.

Is there a list of traffic signs that you are displaying or are planning to display?

The only "sign" displayed is a stop sign. But more generally, the types of things we're trying to visually represent when zoomed in:

lane configuration (including turn lanes and restrictions, buffers near bike lanes, shared bike/foot paths, etc)
stop signs
traffic signals (in simulation mode, we animate to communicate protected/permitted turns at any time, as well as time remaining until the signal changes)
access restrictions (#660) -- both gated neighborhoods and different variations of low-traffic neighborhoods / streets
Part of traffic calmed streets will soon be rendering planters, chicanes, other modal filters (#488)
And many optional layers add even more information to the zoomed-in view, like elevation/incline and heatmaps for delays, dangerous conflict points, throughput, etc

Really? But are they anywhere ║║ ║║ ║║ (exaggerated) instead of ║║║║║║?

I don't think so... the difference there is uneven spacing between the stripes. Are we that bad?

Photos

Ah. Why are there parking lanes on the arterials though but the aerials don't show any parking cars while there are lots of parking cars on the residential road? Are you sure that parking is allowed on the arterials? If cars parked on both sides, it would only be possible to move down that road very slowly.
Also, the residential road doesn't have marked lanes.
Not sure, but is there no distinction in OSM between "parking is not forbidden here" and "there is a dedicated parking lane here"?
As for visualizations, ideas:

make arterials darker, residentials less dark. Would even match with how it looks like locally in Seattle as it looks like residential roads are often paved with concrete while arterials are paved with asphalt.
idea for traffic signals: Only draw the crossings for when there is a walk signal, otherwise make them invisible or something. Maybe works better if the crossing markings are drawn like in that image I showed because then they look like markings that block cars (continuous straight line that is orthogonal to other lane markings).
Access restrictions: Similar idea as above. Draw a thick white/yellow line that is orthogonal to other lane markings at the entrance to private roads and gated communities. I.e., like a "wall" on the road.

For the minimap, you probably want a good overview for orientation, with a focus on the street layout and arterial roads
For the main view, the focus is on street layout, so that should stand out while the rest is secondary

Totally agree with the statements and I think we can use these two principles to review the new map.
The mini map
I think the mini map shows the different roads and the agents clearly. One concern I have is the contrast between main street (arterial) and the building:

It is more obvious in the downtown area since the buildings are gray and the yellow streets blend into the background and as a result less clear than the neighborhood street (in white color)
I compared it with some other maps:

I agree that the buildings can be removed to emphasize road on mini map. And I assume that the gray areas on the current minimap will be turned into a lighter color like #f2f0ee
Adding a gray border for the road like white color could draw a clearer line between the main roads and background

The main view
The street layout is clear now with the outline of the curb and the white color palette. I agree with @westnordost and @michaelkirk that the traffic signal lines now are unclear. However, I do like the color-changing and fading animation. My suggestions are

I agree that we should add a similar black or dark gray border on the protected movements and adjust the z-index to make them on the top.
We can adjust the "fading animation":

Now the yielded movements turn darker while the protected fade out, and then both of them turn yellow. As a result, the protected movements are less obvious and the yellow light stage becomes really more prominent than the faded green stage. Instead, I would test: a) making the transition changing from green to yellow. 2) applying on both protected and yielded movement the same fading transition but make the minimum opacity higher while making the yellow lower opacity. I do think the first solution is more natural but we can test it to see how it works.

Here are two changes applied:

No more buildings on the minimap. I think this isn't a controversial change at all, I'm ready to roll it out even in the current/old color scheme.
Using 3 shades of grey to distinguish highway (30% grey), arterial (40%), residential (50% = the previous #7F7F7F.

I tried blue to call out parking, but it seems a bit too loud / happy. I'll keep experimenting with tinting the grey a little bit blue or adding more markings to set it apart better.

I'll work next on traffic signals, the unzoomed view, and changing building colors. But how do the 3 greys look? I think it's much easier to find major/minor roads zoomed in now.
Catching up on comments:

Why are there parking lanes on the arterials though but the aerials don't show any parking cars while there are lots of parking cars on the residential road?

Happens to be that one satellite photo. I promise, there's loads of parking on arterials in Seattle; this entire project kind of started because of that.

If cars parked on both sides, it would only be possible to move down that road very slowly.

Correct. abst is starting to handle actual road widths better, so this'll eventually start to reflect in the simulation too.

the residential road doesn't have marked lanes

I've seen massive OSM threads discussing this. I know the distinction is important. For schematic / UI purposes, A/B Street is going to act as if there's two skinny lanes on those narrow local roads. That communicates the logical use of the street better than omitting markings, I think.

but is there no distinction in OSM between "parking is not forbidden here" and "there is a dedicated parking lane here"?

https://wiki.openstreetmap.org/wiki/Key:parking:lane
I've seen no_stopping used to indicate the physical lack of any shoulder space.

What about "give way" / "priority road"?

I've seen these more in Europe. The US has some "yield" signs that I think are semantically similar. We might add them at some point. abst currently infers stop sign placement from heuristics, not any OSM data. I'd consider these signs low priority to improve.

idea for traffic signals: Only draw the crossings for when there is a walk signal, otherwise make them invisible or something.

We used to do that long ago, but we switched to the hand/walk pedestrian signals at some point. I... don't remember why. :(   Worth revisiting.

Here are the current changes to play with: http://abstreet.s3-website.us-east-2.amazonaws.com/dev/abstreet.html?--dev&--color_scheme=faded zoom&system/us/phoenix/maps/tempe.bin&--cam=19.58/33.41942/-111.91219
I'm playing around with building colors right now to shift them away from grey roads. Buildings are definitely not as important to focus on. But at the very least, we want to distinguish pure residential from mixed-use / commercial. A common zoning / land-use color is reddish for commercial. So I'm trying variations of #FFD6D1 and #F2DAD9.

Here's some experiments with building colors.

The reddish commercial buildings bleed into the arterial roads in the unzoomed view. And maybe in the zoomed-in view, we could try drawing icons to represent the type of business to emphase it more -- something like

but of course not so horrible in layout. :)

I'm really enjoying watching things move away from gray on gray on gray!

Overall the latest changes are looking great to me. I had a play with the example and think they greys look good:

Source: http://abstreet.s3-website.us-east-2.amazonaws.com/dev/abstreet.html?--dev&--color_scheme=faded zoom&system/us/phoenix/maps/tempe.bin&--cam=20.47/33.41826/-111.91732
In answer to your question

how do the 3 greys look?

Good but I think there are only 2 of the 3 shown. Big improvement on the darker high contrast roads that were there previously I think.
Regarding the loud blue colours for parking lanes, I like it, good that it stands out, you could always tone it down by selecting a slightly greyer blue. Same applies to roads that could be coloured green to show they prevent through traffic for large vehicles, being somewhere between a cycle lane and a normal road.

Random comment on the new boundary colour when selecting a new city: pretty garish.

Looking at a part of Leeds I know at relatively low zoom level, I really, really like it.

Source: http://abstreet.s3-website.us-east-2.amazonaws.com/dev/abstreet.html?--dev&--color_scheme=faded zoom&system/gb/leeds/maps/north.bin&--cam=15.26/53.82132/-1.53665

I've found a place with the three types of grey, darker being bigger roads it seems, which makes sense. I think this looks good.

Source: http://abstreet.s3-website.us-east-2.amazonaws.com/dev/abstreet.html?--dev&--color_scheme=faded zoom&system/gb/leeds/maps/north.bin&--cam=20.75/53.80841/-1.53427

how do the 3 greys look? I think it's much easier to find major/minor roads zoomed in now.

I like it!

I tried blue to call out parking, but it seems a bit too loud / happy.

Maybe too light? It could also have less saturation after all. In the screenshot above, the parking lane doesn't have the same lightness as the bus or the cycle lane. You could also play around with 🅿 sprites, but I think this would make the parking lane look too busy, i.e. too much standing out.
I saw the private road coloring. Some more mockups:

how do the 3 greys look? I think it's much easier to find major/minor roads zoomed in now.

I like it!

I tried blue to call out parking, but it seems a bit too loud / happy. I'll keep experimenting with tinting the grey a little bit blue or adding more markings to set it apart better.

I think applying a different pattern might be a better than different color. Can I learn more about the context of the request for calling out parking? Also, compared with the parking availability overlay, the use cases for calling it out on the main map?

The reddish commercial buildings bleed into the arterial roads in the unzoomed view. And maybe in the zoomed-in view, we could try drawing icons to represent the type of business to emphase it more -- something like

Based on the screenshot I do feel like the buildings are too loud. I like the idea to make the game more colorful, but I have some concerns about distracting attention from the roads/traffic. Have you considered make building type a layer/overlay, rather than on the main map. If we do want to push it to the main map, I feel like we might want a legend for them, including the different road types too. Also, to avoid blending with roads, try applying a gray-scale outline like white or light gray.

Next round! It'll be a few minutes, but the web demo will be updated. abstreet.s3-website.us-east-2.amazonaws.com/dev/abstreet.html?--dev&system/us/seattle/maps/udistrict.bin is a good map showing off all the patterns.

I'm trying #C5D2E5 for residential buildings and a darker #99aecc for commercial.
I thickened building outlines for both zoomed/unzoomed, and added a black outline for unzoomed roads. (It currently looks a bit buggy; it doesn't cover intersections. If we like this idea, I'll fix it up.)
Finally trying Robin's green asphalt for traffic-calmed/privateish roads. I took the bike lane color and made it less bold, #6fb193.

Which of these ideas seems like it works, or should I try some variations? For color picking, I've just been using various tools to adjust the shade/tint; even though a few people have tried to teach me more theory behind picking good colors, I haven't internalized the lessons well enough yet. :(

Random comment on the new boundary colour when selecting a new city: pretty garish.

Agreed. There's probably lots of secondary colors we'll have to adjust. Also agent colors, zoomed and unzoomed. This whole design exercise is kind of intense, since everything is changing. I'm trying to pin down the zoomed view, then the unzoomed, then all of the UI stuff around it. Then.. maybe night mode. ^^;

I saw the private road coloring. Some more mockups:

Thanks for these! I think for gated communities, the "private" sign probably works the most clearly for the zoomed in view. For LTNs/greenways, I'll try bollards/planters. First step for me is calculating the actual boundary within the intersection where some turns are restricted.

Can I learn more about the context of the request for calling out parking?

I'm also curious. I don't think we should call out parking lanes so dramatically in the main zoomed view. Indeed the parking layer can be used to point these out.

Based on the screenshot I do feel like the buildings are too loud

How do the new colors look? Still too distracting? Is there a general way to start with something that looks decent visually like #C5D2E5 and #99aecc and "de-emphasize" it? Like lowering saturation, hue, brightness?

Have you considered make building type a layer/overlay, rather than on the main map

We have some form of this; the "amenity" layer. I agree we shouldn't overwhelm with too much detail by default. The only distinction I feel is important is between pure residential buildings and those with some kind of public/commercial space.

Also, to avoid blending with roads, try applying a gray-scale outline like white or light gray.

I adjusted the outline, see screenshots or web demo above

Unintentionally or not, you've arrived at this evocative "sketch" style, which I'm really digging:

I think the black outlines are probably too strong. I would suggest a more subtle outline like #F2F2F2 and #D6D6D6. If you want me to help to adjust it, we can find a time and take a look together too.

I made some improvements to the road outlines, fixing z-ordering and tracing along the edge of intersections. Now the only place where lines overlap and look buggy are places where our map geometry is still legitimately broken -- even more motivation to fix those faster! Shown with the bold black color to debug easily.

Unintentionally or not, you've arrived at this evocative "sketch" style, which I'm really digging

Yeah, I'm not sure what this reminds me of, but it's very "diagram" like!

I think the black outlines are probably too strong. I would suggest a more subtle outline like #F2F2F2 and #D6D6D6.

Here are those two. #F2F2F2 is too close to the local street white color, but #D6D6D6 makes that subtle drop shadow effect.

making the transition changing from green to yellow

A linear interpolation from green to yellow looks super strange to me; it's a "sickly" color. :P  For the moment, I'll stick to the solid green suddenly changing to yellow when there's 5 seconds left, since this is closer to reality. But I did add the outlines and adjust z-ordering.

An experiment making the 3 road class colors even more distinct. But local roads wind up too faded, and this is a bit too much.

I fixed all the blocking problems and cut over to this new scheme as the default! It'll be in the new release in a few hours.
Thank you all for the help! The result looks awesome.
Still lots of further design work to support this change even better. Tracked in #74


PLATFORM-9529 Upgrade opengrok role

Requirements

Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
All new code requires tests to ensure against regressions
Remember to set idealista:develop as base branch;

Description of the Change

Benefits

Possible Drawbacks

Applicable Issues

Also, some misc things:

The PR doesn't include .gitattributes file
Just noticed that .github dir, although present, has older files. We could update to match the role template standards https://github.com/idealista/cookiecutter-ansible-role/tree/develop/{{cookiecutter.app_name}}_role/.github


App runtime should print OSS version

Since app is built against particular OSS version, we should log OSS version when app is started.

We'd want to print the version of the lib & the action(s) that the bin was built against, as we could have a version difference between contrib and lib


After import a course, I got a 500 error.

Hello
I am successfully deployed a lms site with oxa/master.fic.
The lms site was opend successfully with no error.
But When I import course, the import progress is staying in uploading.
(Why does the Course Import Status is in uploading?)
But, I  closed the browser which is uploading course window, the course is shown in lms site.
and then, I click the imported course in lms site, I got 500 error.
How can I fix it?
Maybe this log file helps you for investigate the issue.
cms-edx-log.txt

I got the similar issue when i ran out of space in the machine. can you check that ?

Hello manikarthikk
I had checked the usage of disk. The Maximum percent of usage is under 20%.
The status of disk space is good.
Is this issue possibly related to custom theme?
Thanks in advance.

Hello
we had referenced  https://partner.microsoft.com/en-us/marketing/assets/detail/open-edX-theming-guidance-mp4.
and then  we had applied custom theme with our git repository.
(https://github.com/egonid/sync-theme : best-theme3)
after deploy, the site was opened successfully.
but after create and import a course,  500 error has occurred when click it.
When oxa-tools deploying, we had modified below things in parameter.json file.
"edxThemeGithubAccountName": {
"value": "egonid"
},
"edxThemeGithubProjectName": {
"value": "sync-theme"
},
"edxThemeGithubBranch": {
"value": "master"
"enableComprehensiveTheming": {
"value": true
},
"comprehensiveThemingDirectory": {
"value": "/edx/app/edxapp/themes"
},
"comprehensiveThemingName": {
"value": "best-theme3"
But after deploy, there were no files or directories under /edx/app/edxapp/themes in jbVM.
only themes directory was existed at that path.
Is this right?
How can I resolve this issue?

we don't suggest partners using our theme repo as it has many of our own customizations.
In your case,
go to the path ms-theme/lms/templates/courseware and remove the HTML files in that folder.
"sudo rm *.html"


FInal Support Schema changes

Codecov Report

Merging #109 (5525e01) into main (20a5e58) will decrease coverage by 0.74%.
The diff coverage is 88.88%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
@@            Coverage Diff             @@
##             main     #109      +/-   ##
==========================================
- Coverage   76.46%   75.72%   -0.74%
==========================================
  Files          15       15
  Lines         701      688      -13
==========================================
- Hits          536      521      -15
- Misses        165      167       +2

Files Changed
Coverage Δ

src/ibek/support.py
98.71% <83.33%> (-1.29%)
:arrow_down:

src/ibek/render.py
96.55% <100.00%> (-1.98%)
:arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Properly reset pings_before_data_required

According to the comment in grpc_types.h for the argument, MAX_PINGS_WITHOUT_DATA should be tracking sending data, not receiving them. We currently reset the ping_state.pings_before_data on receiving path. This PR changes to reset the field on sending path. The default value is also lowered to 2 from unlimited to work with google frontend proxy.
Note the field is now reset on sending DATA/HEADER/WINDOW_UPDATE.
Context: b/71600267

****************************************************************

libgrpc.so

     VM SIZE                                                          FILE SIZE
 ++++++++++++++ GROWING                                            ++++++++++++++
  +0.0%     +60 [None]                                                +116  +0.0%
      +0.0%     +24 [Unmapped]                                            +112  +0.0%
      +3.1%     +36 [None]                                                   0  [ = ]
      [ = ]       0 g_default_max_pings_without_data                        +4  [NEW]
  +1.4%     +80 src/core/ext/transport/chttp2/transport/writing.cc     +80  +1.4%
      +1.3%     +72 grpc_chttp2_begin_write                                +72  +1.3%
       +30%      +8 [Unmapped]                                              +8   +30%

 -------------- SHRINKING                                          --------------
  -0.6%     -44 src/core/ext/transport/chttp2/transport/parsing.cc     -44  -0.6%
      -2.5%     -32 init_header_frame_parser                               -32  -2.5%
      -0.3%     -12 grpc_chttp2_perform_read                               -12  -0.3%

  +0.0%     +96 TOTAL                                                 +152  +0.0%

****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

[trickle] No significant performance differences

[microbenchmarks] No significant performance differences

****************************************************************

libgrpc.so

     VM SIZE                                                          FILE SIZE
 ++++++++++++++ GROWING                                            ++++++++++++++
  +0.0%     +60 [None]                                                +108  +0.0%
      +0.0%     +24 [Unmapped]                                            +104  +0.0%
      +3.1%     +36 [None]                                                   0  [ = ]
      [ = ]       0 g_default_max_pings_without_data                        +4  [NEW]
  +1.4%     +80 src/core/ext/transport/chttp2/transport/writing.cc     +80  +1.4%
      +1.3%     +72 grpc_chttp2_begin_write                                +72  +1.3%
       +30%      +8 [Unmapped]                                              +8   +30%

 -------------- SHRINKING                                          --------------
  -0.6%     -44 src/core/ext/transport/chttp2/transport/parsing.cc     -44  -0.6%
      -2.5%     -32 init_header_frame_parser                               -32  -2.5%
      -0.3%     -12 grpc_chttp2_perform_read                               -12  -0.3%

  +0.0%     +96 TOTAL                                                 +144  +0.0%

****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

[trickle] No significant performance differences

[microbenchmarks] No significant performance differences


Fix incoming message size issue that introduced in #9113

Motivation
Fix incoming message size issue that introduced in #9113. We should decrease the incoming message size when taking messages from the queue and increase the incoming message size while adding messages to the queue. With #9113, will always increase the incoming queue size.
Modifications
Add method increaseIncomingSize and decreaseIncomingSize
Verifying this change
Add a new test for verifying the incoming message size should be zero while the incoming queue size is zero.
Does this pull request potentially affect one of the following parts:
If yes was chosen, please highlight the changes

Dependencies (does it add or upgrade a dependency): (no)
The public API: (no)
The schema: (no)
The default values of configurations: (no)
The wire protocol: (no)
The rest endpoints: (no)
The admin cli options: (no)
Anything that affects deployment: (no)

Documentation

Does this pull request introduce a new feature? (no)

@BewareMyPower @lhotari Please help review this PR

@BewareMyPower @lhotari Please help review this PR

OK, I'll take a look soon.

OK, I'll take a look soon.

@BewareMyPower @315157973 I have addressed your comments, please take a look again.

@BewareMyPower @315157973 I have addressed your comments, please take a look again.

The import of VisibleForTesting has not been deleted, I don’t know if the style check will report an error

The import of VisibleForTesting has not been deleted, I don’t know if the style check will report an error


Module to visually select windows

This pull request modularize ace-window and adds switch-window as a replacement option.
This module was an idea that we discussed in issue #218

Nice work. I look forward to trying it out!

would be awesome to get this PR into the develop branch as well

@rphillips And done!


Is the version of Python 3.5?

I have tried using Python 3.10, 3.8, and 3.7, but the compilation with the bash script 'compile_op.sh' failed for all of them. Only version 3.5 was successful. Does this project specifically require Python version 3.5 as well?

thanks,i think the problem may driving by python version too,i will try it now


Linear order parameter for MSTIS

Just what it says. See #549.

looks better this way. Waiting for it to pass.

It's gonna pass. :-)


GitHub Team Meta issue

This is just a test!

Looks fine and dandy!

Why only one comment?

Now there are more!


Feature Request: Clients

Today I use a custom python script to turn my kids devices on or off (to help control screen time). I could use this as a replacement by adding all their devices to a single SSID or use the updateNetworkClientPolicy as an on off switch. I'd be happy to help contribute this but I don't know Javascript. I could help with my experience using the Meraki API and share the code I wrote in Python if that would help.
Adding a bit more detail here:
The plugin today exposes SSIDs (all clients on or off), what I am proposing as a feature request is Clients exposed as an accessory with a simple on/off switch. The updateNetworkClientPolicy endpoint could be used. It would be important to take a list of Clients (mac-address) as a filter to limit the Clients exposed to homebridge.
Status: dashboard.networks.getNetworkClientPolicy(networkId=network_id, clientId=client["mac"])
Off: dashboard.networks.updateNetworkClientPolicy(networkId=network_id, clientId=client["mac"], devicePolicy="Blocked")
On: dashboard.networks.updateNetworkClientPolicy(networkId=network_id, clientId=client["mac"], devicePolicy="Normal")
If there was a way to add more than simple on/off, then adding support for dashboard.networks.updateNetworkClientPolicy(networkId=network_id, clientId=client["mac"], devicePolicy="Group policy", groupPolicyId="101") where the groupPolicyId is mapped to a friendly name like "Kids limited access".

Hi,
I can add possibility to filter network clients by client Name.
For every filtered client create switch to set policy, switch ON-apply policy Blocked, Switch OFF-apply policy Normal.
Is that what You want.?

Switch set ON apply policy Blocked, Switch set OFF apply policy Normal.

My opinion is that ON should mean "has access to the network" which would have a policy of Normal and OFF would mean "does not have access to the network" which would have a policy of Blocked. This would be consistent  with SSIDs, ON is "network is providing access" and OFF is "network is not providing access".

Yes You are right, my mistake. I will realize this today or tomorrow.

added in 8.3

It's working!
@grzegorz914 so awesome and I'm jealous how quickly you could do that so quickly. Thanks!
My only feedback is you are using device name, which makes it much more user friendly but I don't think it's a unique value. TBH I haven't tested duplicate names, but that was the first concern. In my own script, I used mac address, but I can see how that would be less friendly for users.

One more thing I found was that if the client was off line for too long the API call would fail causing an error in my script. I had to catch the error and log it gracefully. I found the same thing here, I think. I added a client named "Fake-ipad" and now I'm seeing errors in the log. If a user puts a client name in, but that client stays offline for to long the api call will start to fail and generate errors.
Log
[28/08/2021, 14:07:21] [homebridge-meraki-control] This plugin generated a warning from the characteristic 'On': characteristic value expected boolean and received undefined. See https://git.io/JtMGR for more info.
[28/08/2021, 14:07:21] [homebridge-meraki-control] Error:
    at On.Characteristic.characteristicWarning (/usr/local/lib/node_modules/homebridge/node_modules/hap-nodejs/src/lib/Characteristic.ts:2038:105)
    at On.Characteristic.validateUserInput (/usr/local/lib/node_modules/homebridge/node_modules/hap-nodejs/src/lib/Characteristic.ts:1915:14)
    at On.Characteristic.updateValue (/usr/local/lib/node_modules/homebridge/node_modules/hap-nodejs/src/lib/Characteristic.ts:1379:20)
    at Switch.Service.updateCharacteristic (/usr/local/lib/node_modules/homebridge/node_modules/hap-nodejs/src/lib/Service.ts:465:35)
    at merakiDevice.updateDeviceState (/usr/local/lib/node_modules/homebridge-meraki-control/index.js:254:16)
    at merakiDevice.updateMerakiMrSsidsData (/usr/local/lib/node_modules/homebridge-meraki-control/index.js:166:82)
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (internal/process/task_queues.js:95:5)

OK, i will look tomorrow on that

We can use MAC address to filter it but quickly and friendly is use device description.
May be will be god option to add choice which method to filter ice want to use, Mac or Description.
I add this possibility tomorrow.

0.8.5 ready to test

Testing on v0.8.6
I'm seeing a lot of churn (device goes on/off due to status polling).

Other logs
[29/08/2021, 10:26:22] [homebridge-meraki-control] This plugin generated a warning from the characteristic 'On': characteristic value expected boolean and received undefined. See https://git.io/JtMGR for more info.
[29/08/2021, 10:26:22] [homebridge-meraki-control] This plugin generated a warning from the characteristic 'On': characteristic value expected boolean and received undefined. See https://git.io/JtMGR for more info.
[29/08/2021, 10:26:22] [homebridge-meraki-control] This plugin generated a warning from the characteristic 'On': characteristic value expected boolean and received undefined. See https://git.io/JtMGR for more info.
[29/08/2021, 10:26:22] [homebridge-meraki-control] This plugin generated a warning from the characteristic 'On': characteristic value expected boolean and received undefined. See https://git.io/JtMGR for more info.

Testing on v0.8.6
I'm seeing a lot of churn (device goes on/off due to status polling).

Here is all OK in the log

Here is all OK in the log

Yes, but if you watch the screen recording the switches in the home app blink every 10 seconds off then back on. It's not caching the state and refreshing in the background.

fixed


Merge csg-manual into csg

Let's do the same as in xtp and merge the manual into the same repo

Maybe not!