With 652d33279aa242623e09e671233832ace29f1f49, core/kernel/spawn_spec.rb stalls forever on Solaris

After 652d33279aa242623e09e671233832ace29f1f49, core/kernel/spawn_spec.rb stalls forever on Solaris 10.
With 652d33279aa242623e09e671233832ace29f1f49, it seems that 'ruby -e "sleep"' is spawned, but this process apparently never ends, and the parent spec process waits the never-ending process forever. So, I think the change is wrong and I reverted the commit.

4960e9804f77ebfcb253a67e41e943e208e27be5 reverts the commit 652d33279aa242623e09e671233832ace29f1f49

But this means that read_nonblock is actually blocking on Solaris, even if the other end of the pipe is closed?

These specs are quite confusing however :/, could be much easier to just open() and check the fd number.

No, read_nonblock never blocks, and raised expected errors.
It blocks at "Process.wait(pid)".
During make test-rubyspec, RUBY_EXE is a wrapper script that invokes true ruby binary.
So, "Process.kill(:TERM, pid)" only kills the wrapper script and the execution of 'ruby -e "sleep"' invoked by the wrapper runs forever.

I see, thanks for investigating.
Maybe the wrapper should forward SIGTERM to the spawned ruby?

It is not because of the wrapper script, but system's shell (normally /bin/sh).
Process.spawn(ruby_cmd("sleep")) runs ruby with the shell, and returns the pid of the shell process.
On Solaris, when sending SIGTERM to the shell process, it waits for the finish of the child ruby process, but never sends signals to the child ruby.

Ah, unfortunate indeed.
So I guess we should either make the Ruby process write its PID somewhere,
or make it so that just its exit status is enough to know success/failure.

I think using signal is bad idea. The behavior of signals could be different depending on OS and shell.

Agreed, thanks for the fix!


Long lines in console push close button offscreen

Flutter code that prints an exceptionally long line to the console results will cause the "close" button for the console to be inaccessible when opened. You have to switch tabs to Documentation and then close from there.
This gist can reproduce, assuming you don't have a super-wide browser window:
https://dartpad.dev/df97dda49c6d5d061abe74cd5678a917

CC @johnpryan


Add hybrid Neon/Neon Keccak-f1600, don't use scalar ASM on Cortex-A72

Benchmarks suggest that something isn't yet working as intended. Both Gv2 and Gv3 get slower.


Is there an explanation to why it is so painful to setup this dataset ?

Hi,
I am new to the field and desires to work on that solving motion to text problems.
I am probably asking a very trivial question : Why is it so painful to setup everything ?
What can be done to simplify this process ? It seems like a lot of instructions are counter intuitive and do not seem to blend together, e.g :

Place all files under the directory ./amass_data/. The directory structure shoud look like the following:

vs

Download SMPL+H mode from SMPL+H (choose Extended SMPL+H model used in AMASS project) and DMPL model from DMPL (choose DMPLs compatible with SMPL). Then place all the models under "./body_model/".

it seems like no one seem to be bothered by the entire complexity to just setup this project.
Please let me know, I might be missing something

Hi, I understand that it's quite cumbersome to go through these pipelines. That's because humanml3D uses the motion data from various datasets which are under different distribution license. Please note capturing 3d motion data is an VERY expensive and laborious process. Every dataset creator pays a lot of effort on this. We can not distribute them as our own data, even SMPL-H/DMPL models. Therefore, we request everyone to download the motion data and body models from their source website, and comply the license.

Makes sense, thank you for clarification. I was not aware that the process of capturing 3D motion was so expensive.
Last question : is it the sensor, the time involved, or the post processing of the data captured that makes it expensive ?

Hi, usually there will be a room, a suit with sensors, paid actors to
perform actions, and a professional to do all the calibration. After that,
people process the captured data and fit SMPL models for them.
On Wed, Jan 3, 2024 at 2:17 AM valentin-fngr @.***>
wrote:

Makes sense, thank you for clarification. I was not aware that the process
of capturing 3D motion was so expensive.
Last question : is it the sensor, the time involved, or the post
processing of the data captured that makes it expensive ?
—
Reply to this email directly, view it on GitHub
https://github.com/EricGuo5513/HumanML3D/issues/116#issuecomment-1875054976,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AKRYNB7UCKUN2NJ2V6UBRZLYMUO3VAVCNFSM6AAAAABBJ7UYV6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNZVGA2TIOJXGY
.
You are receiving this because you commented.Message ID:
@.***>


Screen space unreclaimed after split close

Type: Bug

Open a file
Split it (showing the same file side-by-side using the split button)
Close the second panel (right)

The first panel keeps the same size and a VSCode logo appears where the right panel was, with a close button (then, this second close button will make the left panel take the whole screen).
Video: https://vimeo.com/751907945/e45db512b5
As far as I remember, in Windows, when all splits are closed, the editor uses all available width automatically.
VS Code version: Code 1.71.2 (Universal) (74b1f979648cc44d385a2286793c226e611f59e7, 2022-09-14T21:05:37.721Z)
OS version: Darwin x64 21.6.0
Modes:
Sandboxed: No

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-8700B CPU @ 3.20GHz (12 x 3200)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: disabled_offdirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmetal: disabled_offmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okskia_renderer: enabled_onvideo_decode: enabledvideo_encode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabledwebgpu: disabled_off

Load (avg)
5, 4, 3

Memory (System)
16.00GB (0.83GB free)

Process Argv
--crash-reporter-id 808954c4-bf58-493d-8730-dcedcce4860c

Screen Reader
yes

VM
0%

Extensions (27)

Extension
Author (truncated)
Version

separators
ale
2.4.1

tinypng
and
1.1.1

flutterpubopen
And
0.0.1

akonio
Avi
8.0.1

dart-code
Dar
3.48.4

flutter
Dar
3.48.0

macos-modern-theme
dav
2.1.13

xml
Dot
2.5.1

gitlens
eam
12.2.2

vscode-google-translate
fun
1.4.13

flutter-stylizer
gml
0.1.16

dart-data-class-generator
hzg
0.5.4

dart-import
lua
0.3.1

flutter-snippets
Mar
1.0.4

rainbow-csv
mec
3.1.0

csharp
ms-
1.25.0

sqltools
mtx
0.25.1

sqltools-driver-sqlite
mtx
0.4.0

material-icon-theme
PKi
4.20.0

material-product-icons
PKi
1.4.0

vscode-thunder-client
ran
1.19.2

vscode-yaml
red
1.10.1

sort-lines
Tyr
1.9.1

errorlens
use
3.6.0

vscodeintellicode
Vis
1.2.27

vscode-icons
vsc
11.17.0

fig
wit
0.0.6

A/B Experiments
vsliv368cf:30146710
vsreu685:30147344
python383cf:30185419
vspor879:30202332
vspor708:30202333
vspor363:30204092
vslsvsres303:30308271
pythonvspyl392:30443607
vserr242:30382549
pythontb:30283811
vsjup518:30340749
pythonptprofiler:30281270
vshan820:30294714
vstes263:30335439
pythondataviewer:30285071
vscod805cf:30301675
binariesv615:30325510
bridge0708:30335490
bridge0723:30353136
cmake_vspar411cf:30557515
vsaa593cf:30376535
pythonvs932:30410667
cppdebug:30492333
pylanb8912:30545647
vsclangdf:30486550
c4g48928:30535728
hb751961:30553087
dsvsc012cf:30540253
azure-dev_surveyone:30548225
i497e931:30553904
fc301958:30567733

We closed this issue because it is a question about using VS Code rather than an issue or feature request. Please search for help on StackOverflow, where the community has already answered thousands of similar questions. You may find their guide on asking a new question helpful if your question has not already been asked. See also our issue reporting guidelines.
Happy Coding!

Where in the hell is this a question????


19 engines detect OFscraper as virus now?

Description
I was aware that previous versions of OFscraper are flagged by 1-2 engines on virustotal.com, however when I was updating to 3.12.9, my AV went off as it seems 19 engines now detect OFscraper as a trojan!?
To Reproduce

Upload latest binary file to virustotal.com
(OR) View analysis

Expected behavior

AV engines do not flag OFscraper as trojan/virus
OFscraper does not get detected with suspicious activities such as:

XOR obfuscation
VM/detection evasion (Reference anti-VM strings targeting VirtualBox)
Hijack execution flow

Screenshots/Logs

System Info

OS: Windows
Browser: Edge
Binary or python: Binary

Additional information
Not accusing OFscraper of being a trojan, but whatever code changes you have made recently seem to be sending AV engines crazy!

OK... but that's just putting the .exe inside a .zip file (making it harder for the engines to scan/detect)... If you password-protect the .zip file, you can get down to 0 detections.

While I can't answer what changes were made that are causing so many antivirus engines to detect it on virustotal. I and many others have been running this version for months now and no one has mentioned seeing any strange/malicious activity. The antivirus (Bitdefender) and hardware firewall (firewalla) I use myself have not picked up any malicious activity either. So while IMHO I don't think you have any cause for concern. But if you want to be safe then run this in a VM (VMware or VirtualBox) or on a spare computer (if you have one that is).

OK... but that's just putting the .exe inside a .zip file (making it harder for the engines to scan/detect)... If you password-protect the .zip file, you can get down to 0 detections.

In the zip version, if you unzip it and scan the exe, that result will appear.
Not that I compress it to scan it.

The process for making the zip and exe are open. Look at the GitHub actions, if you don't trust these processes. Then learn how to use git and install the program from repo.

That'd be a real shame, the exe is just so much more convenient for myself and others


memory leak from makeErrorModalLink

SkribiEvalError objects are retained by the closure created on line 286, even when the element is detached.
https://github.com/Azulaloi/obsidian-skribi/blob/3922d06cb35d79c19b3f9cac52ac569365ce06fd/src/modal/modal-error.ts#L286
These objects are collected successfully if the error is not referenced in the closure.

86edf3fdb8cfab701ebc32e8d5bb4a41aae1f26d fixed issue for elements passed to makeErrorModalLink() that are the containerEl of a SkribiChild, by nulling the onclick reference on clear.

Just need to check all the other calls to renderError() and check that none of them are creating similar leaks.
I should probably also clean up the circular dependencies around this family of functions, to make it less confusing. Maybe triggering an event instead of referencing the error modal directly?


Reinstate felix's ability to specify config file path

We used to use argparse to accept a --config-file option but we lost that when we moved to python 2.6 (at least on the etcd branch).  We should reinstate that by using optparse (or decide it's not needed).

This needs an assignee.

This has been languishing, but is reasonably important, so I'm moving to 0.18.

@plwhite Would you like to include this in your config work too?  It's not strictly the same, so I'd equally be happy not to do that (and then probably leave it until after 0.18).  What do you think?

Fix with Cory to review, so passing ownership to him.


Find logs

Hello guys, I have a little question, how to have the logs of the TechnicSolder ???

app/storage/logs

Thanks


[commonmark] AttributeError: module 'commonmark' has no attribute 'Parser'

Hi,
After updating  my Nikola installation to v8.3.0 the locally installed commonmark plugin fails.
$ nikola --version
[2024-01-26 22:06:19] ERROR: PluginManager: Plugin commonmark from /.../carstengrohmann.de/plugins/commonmark/commonmark.plugin (/.../carstengrohmann.de/plugins/commonmark/commonmark.py) threw an exception while creating the instance
Traceback (most recent call last):
  File "/usr/lib/python3.11/site-packages/nikola/plugin_manager.py", line 215, in load_plugins
    plugin_object = plugin_class()
                    ^^^^^^^^^^^^^^
  File "/.../carstengrohmann.de/plugins/commonmark/commonmark.py", line 57, in __init__
    self.parser = commonmark.Parser()
                  ^^^^^^^^^^^^^^^^^
AttributeError: module 'commonmark' has no attribute 'Parser'
[2024-01-26 22:06:19] WARNING: PluginManager: Some plugins failed to load. Please review the above warning messages.
[2024-01-26 22:06:19] WARNING: PluginManager: You may need to update some plugins (from plugins.getnikola.com) or to fix their .plugin files.
[2024-01-26 22:06:19] WARNING: PluginManager: Waiting 2 seconds before continuing.
Nikola v8.3.0

I can well imagine that with the new Plugin Manager the search path of the modules has changed and the plugin imports itself.
https://github.com/getnikola/plugins/blob/126d38c6e850589d8812f7c5c45121c65ef047b1/v8/commonmark/commonmark.py#L34-L37
This would explain the difference between the following tests with import commonmark && commonmark.Parser, if the command is executed once in the plugin directory and once outside.
$ pwd
/.../carstengrohmann.de/plugins/commonmark

$ ll
insgesamt 24
-rw-r--r-- 1 carsten carsten 1452 19. Okt 22:46 README.md
drwxr-xr-x 2 carsten carsten   40 20. Okt 20:28 __pycache__
-rw-r--r-- 1 carsten carsten  277 19. Okt 22:46 commonmark.plugin
-rw-r--r-- 1 carsten carsten 4184 19. Okt 22:46 commonmark.py
-rw-r--r-- 1 carsten carsten  495 19. Okt 22:46 conf.py.sample
-rw-r--r-- 1 carsten carsten   18 19. Okt 22:46 requirements.txt

$ python
Python 3.11.6 (main, Nov 14 2023, 09:36:21) [GCC 13.2.1 20230801] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import commonmark
>>> commonmark.Parser
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
AttributeError: module 'commonmark' has no attribute 'Parser'

$ pwd
/.../carstengrohmann.de/plugins

$ ll
insgesamt 4
-rw-r--r-- 1 carsten carsten  25 25. Mai 2014  __init__.py
drwxr-xr-x 3 carsten carsten 134 20. Okt 20:28 commonmark
drwxr-xr-x 3 carsten carsten  18 25. Mai 2014  compile

$ python
Python 3.11.6 (main, Nov 14 2023, 09:36:21) [GCC 13.2.1 20230801] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import commonmark
>>> commonmark.Parser
<class 'commonmark.blocks.Parser'>

What do you think about this issue?
Regards,
Carsten

Easy workaround for this,
mv plugins/commonmark/commonmark.py plugins/commonmark/commonmark_plugin.py

and edit plugins/commonmark/commonmark.plugin:
diff --git a/plugins/commonmark/commonmark.plugin b/plugins/commonmark/commonmark.plugin
index 84e28cb..810ca29 100644
--- a/plugins/commonmark/commonmark.plugin
+++ b/plugins/commonmark/commonmark.plugin
@@ -1,6 +1,6 @@
 [Core]
 Name = commonmark
-Module = commonmark
+Module = commonmark_plugin

 [Nikola]
 PluginCategory = PageCompiler

That's a good idea. Let's ask @Kwpolska if he would accept a simple PR with this workaround or if he would like to change  the search path handling in the newly introduced  plugin manager.

I think changing the plugin names would be a better fix, as it would be more in line with how Python imports work. We’re happy to accept a PR.

@asmeurer: It's your change - would you create a PR for it?

I'll see what I can do later but if you already know where to make the change at you should just do it. I'd need to figure out where this code is even located.

ok, I'll provide a PR.


My files shows empty bucket (but subfolder listing works fine)

Since latest minio upgrade (not sure which version, we upgraded from RELEASE.2023-05-18T00-05-36Z to RELEASE.2023-06-16T02-41-06Z), the user bucket listing returns an empty listing in response which leads to Onyxia displaying an empty bucket.
Listing a subfolder works fine.
Example :

https://minio.example.com/userid?delimiter=%2F&encoding-type=url&max-keys=1000&prefix=%2F

<?xml version="1.0" encoding="UTF-8"?>
<ListBucketResult xmlns="http://s3.amazonaws.com/doc/2006-03-01/"><Name>userid</Name><Prefix>/</Prefix><Marker></Marker><MaxKeys>1000</MaxKeys><Delimiter>/</Delimiter><IsTruncated>false</IsTruncated><EncodingType>url</EncodingType></ListBucketResult>

https://minio.example.com/userid?delimiter=%2F&encoding-type=url&max-keys=1000&prefix=mysubfolder%2F

<?xml version="1.0" encoding="UTF-8"?>
<ListBucketResult xmlns="http://s3.amazonaws.com/doc/2006-03-01/"><Name>userid</Name><Prefix>mysubfolder/</Prefix><Marker></Marker><MaxKeys>1000</MaxKeys><Delimiter>/</Delimiter><IsTruncated>false</IsTruncated><Contents><Key>mysubfolder/example</Key><LastModified>2022-02-10T16:59:12.426Z</LastModified><ETag>"d2fcc1fac5b84b98132ca3036e9a949f"</ETag><Size>15</Size><Owner><ID>02d6176db174dc93cb1b899f7c6078f08654445fe8cf1b6ce98d8855f66bdbf4</ID><DisplayName>minio</DisplayName></Owner><StorageClass>STANDARD</StorageClass></Contents><EncodingType>url</EncodingType></ListBucketResult>

Currently unsure if that bug is attributable to Onyxia or MinIO (could not find any related issue on minIO / minIO-JS repositories) but we may have been doing something non-standard that is not supported anymore.

Fixed, deploying


cmd/go: fuzzing output adjustments

The current chatty fuzzing output should be more amenable to processing with test2json. There are only minor changes needed:

It should start with a 'test beginning' header the same as when a regular test runs.
Having done that, the "fuzzing," prefix should probably be "fuzz:", and all the output lines should begin with that, to separate them from prints.
'found a crash, minimizing...' should be 'fuzz: found a %d-byte crash input; minimizing'.

/cc @jayconrod @katiehockman

I see now that the header does happen with -v, just not without -v.
That is probably OK, since test2json requires -v.
But the other adjustments should still be applied.

Thanks for the fixes. Looks like one was missed as far as the prefix:
gathering baseline coverage, elapsed: 0s, workers: 16, left: 4178

I would suggest making this a bit closer to the status messages, like
fuzz: elapsed: 0s, processing seed corpus: 0/4178 cases done

or something like that. I'm not sure what the 'left: 4178' means exactly, so the suggested rewrite may not be any good on that front. It seems like there should be a second one of those prints when it's completely done with the corpus, or whatever 'left: 0' would mean.
While I'm nitpicking:
fuzz: found a 52-byte crash input; minimizing...

would be more concise and I think equally clear as
fuzz: minimizing 52-byte crash input

I'm also not sure about the word 'crash' here, since in my case they are t.Fail inputs. There is no actual crash.
I wonder if it should be 'failure input'.
Similarly, perhaps 'Crash written to ...' should be 'Failure input written to ...'

And does the number of workers ever change? Maybe it should just be printed once instead of in every message?
fuzz: elapsed: 3m27s, execs: 32025801 (154712/sec), workers: 16, interesting: 3
fuzz: elapsed: 3m30s, execs: 32472170 (154626/sec), workers: 16, interesting: 3
fuzz: elapsed: 3m33s, execs: 32957605 (154728/sec), workers: 16, interesting: 3
fuzz: elapsed: 3m36s, execs: 33428733 (154761/sec), workers: 16, interesting: 3
fuzz: elapsed: 3m39s, execs: 33887371 (154734/sec), workers: 16, interesting: 3
fuzz: elapsed: 3m42s, execs: 34354633 (154749/sec), workers: 16, interesting: 3

Looks like one was missed as far as the prefix:

Will fix this, and the other nits! 👍

And does the number of workers ever change? Maybe it should just be printed once instead of in every message?

Nope. We can probably just print it once at the start.
As for the use of "crash", that's the verbiage we've been using throughout our documentation and blog posts so far to indicating any kind of failure that is found during fuzzing. It's also something that's used in a lot of other documentation around the web about fuzzing (like libfuzzer's -minimize_crash flag). Is this something you feel really strongly about? Otherwise, I'd really prefer to keep it.

fuzz: minimizing 52-byte crash input

@jayconrod suggested keeping the ... in a previous CL because it tells the user that something is in progress and they should wait. LMK if you disagree.

Thanks for the fixes. Using crasher is OK but we need to define it clearly in the docs (in package testing and also in reference docs), since it doesn't mean what it looks like.


return res.redirect('back'); returns to '/' instead of the previous page

I can reproduce this error with Node 21.x and Node 20.x. I am using Express ^4.17.2 or ^4.19.2 coupled with EJS ^3.1.6.
I can create the error with a simple route like this:
 app.get('/goback', async(req, res) => {
  return res.redirect('back');
})

This route will always return to '/' regardless of what the previous page was. I can also reproduce this error with more complicated POST and PUT routes I have for updating DB documents. The above is too narrow down the issue.

Do you receive the Referrer header? If you set Referrer-Policy: no-referrer then the browser won't send the Referrer header, which is required for res.redirect("back") to work.
https://github.com/expressjs/express/blob/2676a1f281e8f1cc73591d3fa8917344dcc60d38/lib/response.js#L910-L915

@krzysdz Thank you so much. I thought back to what could be blocking the referrer and realized it was the helmet NPM package. I'll post the solution here for anyone else that runs into this issue.
From:
app.use(helmet({contentSecurityPolicy: false}));
To:
app.use(
  helmet({
    referrerPolicy: false,
  }),
);


Unable to locate cloning automation

Version 1.58.0 mentions adding cloning automation. I expected this to be a holy upgrade, but I can't find it anywhere. Am I looking in the wrong place?

@ghysler maybe you haven't yet unlocked all previously required holy upgrades on the path?

Ahh, you're right! In that case I have a long way to go :-)
Could you add this holy upgrade to the wiki page? https://wol-soft.de/apps/beerplop/wiki/index.php/Holy_Upgrades

Yeah, I'll add it tomorrow. Sorry for the path spoiler 😃

Added to the documentation at https://wol-soft.de/apps/beerplop/wiki/index.php/Holy_Upgrades


fix: fetch DID for participantContextId

What this PR changes/adds
when verifying the access_token we should fetch the DID for the requesting participant from the database instead of
assuming the participant context ID is equal to the DID.
the participant context ID could be "some-participant" and the DID could be did:web:some_participant.
Why it does that
flexibility in choosing the participant context id
Further notes
List other areas of code that have changed but are not necessarily linked to the main feature. This could be method
signature changes, package declarations, bugs that were encountered and were fixed inline, etc.
Linked Issue(s)
Closes #360_
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.

FYI @ThomasRutger


Add calls to process headers as well

For an archiving project I needed to be able to access all the headers of the mails as well.
This commit adds the string containing the original headers to the messages

Can you please update the tests too? We should also add some new tests specifically for headers.

I have fixed the line and added two tests to the parser

Did you push? It doesn't look like the commits in the PR updated.

Ah yes the push failed and I closed my laptop. Its there now.

Great. Just a few more things:
1) Let’s update the Yugo.email typespec to include the new field - I also think we can name the field simply “headers” instead of “rfc822_header”
2) I see you updated the expected client messages in the tests to expect the client to request the RFC822.HEADER field, but it still doesn’t have the server send them back. You should change the S: … lines so that they include a variety of sample headers and then ensure that the email that is received actually contains those headers.
3) I’d like us to parse the headers into a more elixir-y data type (probably an array of {name, value} tuples). This might be as simple as splitting each line on “: “ but check the IMAP spec to see what exactly it would entail.
Thanks again for the work so far!

Ok, 1 & 3 are done.
Regarding 2 I am not sure how to proceed.
A sample response might be this:
S: * 2 FETCH (FLAGS (\sEEn) BODY ("text" "plain" ("charset" "us-ascii" "format" "flowed") NIL NIL "7bit" 47 6) RFC822.HEADER {1992}\r\nReturn-Path<EMAIL_ADDRESS>ENVELOPE ("Wed, 07 Dec 2022 18:02:41 -0500" NIL (("Marge Simpson" NIL "marge" "simpsons-family.com")) (("Marge Simpson" NIL "marge" "simpsons-family.com")) (("Marge" NIL "marge" "simpsons-family.com")) (("HOMIEEEE" NIL "homer" "simpsons-family.com")) NIL NIL NIL "fjaelwkjfi oaf<$ ))) \""))
Right now the assert_comms are wrapped in ~S sigil, which means it will double escape the line breaks.
But if I use the ~s, to keep the linebreaks in the header sample, assert_comms will break, because it splits on \n and suddenly there will be \r\n in the middle of the string.

I'm not sure I understand the issue. assert_comms() replaces all "\n" with "\r\n" then splits on the regex ~r/\r\n[CS]:/. You should be able to put literal line breaks in the string, as is done here. Unless I am missing something - did you try that and it didn't work?

Also, headers aren't something that most users are likely to need. I think we should consider adding a mechanism to configure whether or not we want to fetch headers so we avoid downloading excess information from the server. I'm thinking we could somehow extend Filters to do this. Do you have any ideas?

I'm not sure I understand the issue. assert_comms() replaces all "\n" with "\r\n" then splits on the regex ~r/\r\n[CS]:/. You should be able to put literal line breaks in the string, as is done here. Unless I am missing something - did you try that and it didn't work?

Yes i tried this and it doesn't work. The problem is that both the syntax of the Client and Server response depends on linebreaks for parsing, but also inside the server response there will be linebreaks if you want to add headers, so when assert_comms does the splitting the headers end up being split.
Regarding the other things am not sure i can do this, neither do I feel so good about it.
I wanted to share my work so that others can profit from it. But I personally don't need the headers parsed for example, just need to archive them. But it seems like the scope of this is growing and growing without clear indication where it goes.

Ok, thanks. I will have a look at it again next week

Ok. I'll close the PR for now.


Custom resolution invalid in game version 6.6

Describe the bug
Custom resolution invalid in game version 6.6, but the custom FPS function still work. Launcher version is v1.4.20230329.0.
To Reproduce
Steps to reproduce the behavior:

Go to 'Option->Manage game settings->Set custom resolution'.
Set a resolution. (My resolution is 3440 x 1440)
Click on 'Confirm', then prompt for successful set.
Log output 'Setting game resolution to 3440x1440, fullscreen enabled...success!'
Then click ‘Launch’, but custom resolution is invalid, it set to default 2560x1440.

Expected behavior
The game resolution should be set to 3440x1440 and will not be reset.
Log
BetterHI3Launcher v1.4.20230329.0
Working directory: G:\Honkai Impact 3\
OS version: Windows 10 Pro for Workstations (Version 22H2, Build 19045.2846)
OS language: zh-CN
Launcher language: en
WARNING: Bp Network connection error, attempt №2...
Using server: CN
Using mirror: HoYoverse
Checking for game update...
Game version: 6.6.0
Game directory: G:\Honkai Impact 3\Games
Setting game resolution to 3440x1440, fullscreen enabled...success!

Custom resolution can only be used in windowed mode, uncheck the fullscreen checkbox and try again.

I tryed just now. It works while in startup screen, but once entering the loading screen, it turns to 2560x1440 again.
Startup screen:

Loading screen:

I checked the fullscreen before v6.6 update, and it works.
Check this, pls.
Thanks!

Can confirm this indeed happens with 6.6 but not 6.5. Unfortunately, because this is an issue on the game's side, I cannot fix this.


bug(customPropTypes): demand validation is broken with defaultProps

Thanks to @meze for report in #809.

#809 introduced new propType validation for Label:
removeIcon: customPropTypes.every([
  customPropTypes.demand(['onRemove']),
  customPropTypes.itemShorthand,
]),

And seems there is bug with defaultProps and customPropTypes.demand. Looks that validation for  removeIcon is called always even it's not passed to component.
<Label>
  <Icon name='mail' /> 23
</Label>

Warning: Failed prop type: `removeIcon` prop in `Label` requires props: `onRemove`.
    in Label (created by LabelExampleBasic)
    in LabelExampleBasic

This issue in Label can be solved with:
- static defaultProps = {
-  removeIcon: 'delete',
-}

+ {onRemove && Icon.create(removeIcon, { onClick: this.handleRemove })}
- {onRemove && Icon.create(removeIcon || 'delete', { onClick: this.handleRemove })}

However, I don't like this because it will not solve real problem. Any better proposals?

Unfortunately within the props validations you only receive the props object after it's been merged with defaultProps: https://github.com/facebook/react/blob/38c22252f4deb2dd7f10644404ae122f1fd0cb88/docs/docs/typechecking-with-proptypes.md#default-prop-values

The propTypes typechecking happens after defaultProps are resolved, so typechecking will also apply to the defaultProps.

Two options:

Remove the demand validation here
Implement the idea @layershifter just suggested (removeIcon || 'delete')

I lean option 1 because with option 2 we'd have to take care to respect the rules of shorthand props manually (e.g. undefined should defer to the default, null or '' should override the default). If we ever change this logic in the shorthand factory it's unlikely we'll remember to update here.

Just submitted a PR to fix this. There was the same issue with renderLabel in Dropdown which I fixed as well.
In general, I kinda think we should only use demand when the component would otherwise be broken or have unexpected behavior. Aside from fixing the React warning, removing the demand the renderLabel prop within Dropdown enables a use-case I have in my app.
My use-case
I'm writing a component that wraps Dropdown and adds default rendering for a particular API-resource type. I want to define a renderLabel in that component so if the component is used with multiple it will render as I want:
// ItemDropdown.js
const itemToOptions = (item) => ({ text: item.name, value: item.id })

const renderLabel = (item) => ({
  basic: true,
  color: 'blue',
  content: item.text
})

const ItemDropdown = ({ items, ...props }) => (
  <Dropdown options={items.map} renderLabel={renderLabel} {...props} />
)

// Somewhere else in the app

// Single-select
<ItemDropdown items={items} />

// Multi-select
<ItemDropdown multiple items={items} />

If we were to demand that multiple were passed, I'd have to check within ItemDropdown and optionally pass renderLabel. In this case, passing renderLabel is harmless and is just ignored.


Insufficient contrast ratio

Importing issues from old repo on Gitlab.
Created by: @Aman-Codes

Background and foreground colors should have a sufficient contrast ratio.

can I work on this issue ?

I reviewed the website, what I found that maybe the contrast ratio is fixed.
The contrast ratio currently is lagging in the tags which are mentioned when a user click on an icon

We can add a bit dark contrast to the tags so that the contrast ratio can be maintained.
Another thing I found out was the headings and the text both have a font weight which is lighter, due to which they both are sub-merging in each other.
We can set it from lighter to bolder, so that It can improve the UI design.
This is an example of the current density of headings in the page

This is an example showing the headings bolder.

This is an example showing the headings bold.(This is creating conflict as the subheading and heading both are bold.)

Ok with the fix in contrast for labels!
as for the headings, I would go for the least disruptive options for now:


refactor(NetworkManagerGUI): prevent potential NRE spam if reference is lost and tidy up

While chasing a ghost error due to Unity adding two NetworkManagerGUIs to one object and I forgot to check that, I discovered that the component and spam NREs in its OnGUI loop.
So, what this PR does is quite a fair bit actually...

Short-circuits if there's no NetworkManager component specified and Auto Configure is turned off.
It introduces a new "Auto Configure" option which means people can slap on the component, tick a box and it'll automatically reference NetworkManager should it exist on the same GameObject. If it doesn't, it will throw an ArgumentNullException and tell them to fix it.  However, I have implemented it so if you do specify a NetworkManager reference and leave it ticked to automatically configure itself that it will not override your manual reference.
Adds tooltips and explanations as well as adds headers to the configuration options.
Blows off a ton of dust and gives the code a restructure with regions, etc.

As an added bonus, it also addresses Visual Studio complaining about IDE0048: "Add parentheses for clarity" by... you name it, adding parentheses around some Rect math.
Mirage. Makin' NetworkManageGUI great again.

Example of what it looks like now:


Pre-trained model

Will you upload the pre-trained model, so that I can reproduce your results and try it.

I've uploaded the pre-trained GRY model in this commit: 2b151e9a638db9197527a31f5c6a9a0ef4f8d8b7
Other models will be uploaded later since they were removed from the server and I have to train them again.
Please note the restriction in image shape. As the models were trained with images of shape (128, 128, 3), you can only train/process on your own images with the same shape.

To try it on a big image as testing, should I modify the full model code or, training on 128x128 and testing on 600x600 should work ?

Yes, it works with latest codes. You can use the pre-trained 1281283 model to process your own images with different shape (e.g. 6006003 in your case) and do not have to modify any code.
However, I personally recommend you to do fine-tuning with your own images in specific shape and category (e.g. 6006003 pictures about flowers, etc., depending on your requirements). The pre-trained model was trained on some general images that covering plants, animals, buildings and so on, which will not give you desirable results if you only focus on a small area for example only flowers. Also, though the latest code support different shapes in train/test, it is recommended to fine-tuning with images of specific shape before testing, which will give you better outcomes.


Global settings: bad overflow behaviour

I think we should tweak this so that the "..." is really the last thing to show up when space gets small:

Agree, pushing to next week as then I will cover all this activity debt (we decided to keep this update story for insiders)

@isidorn makes sense

@isidorn Still want to jump on this?

Yeah I can look into it next milestone

Not what I suggested initially but I think it makes sense to always show the gear icon and let the other toolbar show the "..."


Update ibc-rs to v0.12.0

Closes #926

Update ibc-rs to v0.12.0
Update tower-abci for tracing*
Update tracing* in Anoma

This PR focuses to update ibc-rs. We can't make an IBC wasm transaction for now.
I'll make another PR.

pls update wasm


Reduce change_font_size step to 0.5

Fix for issue https://github.com/jwilm/alacritty/issues/1353

I wonder if it would be better to create a constant a re-use where we need to call change_font_size. If you agree, how should I do it? Can I create a constants.rs and add a constant like:
const  FONT_SIZE_STEP: f32 = 0.5;

And then, import it where it is needed?
Besides that, should I add a test for these changes? If yes, where?

Also, why a couple of builds failed?

The nightly builds currently fail because clippy doesn't build with the latest nightly, it would make sense to pin the nightly to a version that works with clippy maybe but it shouldn't be of concern to this PR. Once clippy blocks nightly releases again that should be fine too.

Also, not to get ahead of myself here: The code looks great, thanks for the PR!
Defining a constant would be possible by adding const FONT_SIZE_STEP: f32 = 0.5 to the top of the input.rs file, defining this locally makes the most sense.
In this case using a constant isn't super necessary because we basically just want the smallest step size possible, which is however defined in the font subproject, but I think adding it to the top of input.rs would just be good practice and allow anyone who wants to fork and increase this if they want a different behavior.
Regarding tests, it might actually be possible to get something going there because font_size is public in the Term struct. So since that would add value without having to add any unnecessary complexity to the project, it seems like a great idea.
Here are the test cases I'd propose:

increase font size
decrease font size
attempt to decrease below threshold
change font size -> reset font size

There are already a few tests at the bottom of the src/term/mod.rs file:
https://github.com/jwilm/alacritty/blob/master/src/term/mod.rs#L1938-L2055
I think this would be the right place to add them.
If you're interested on working on these tests, I'd love to add that to this PR. However I wouldn't consider them a show-stopper if you're busy with other tasks. As mentioned in the issue, if you have any questions, don't hold back. :)

@chrisduerr thanks for the amazing help you've been providing! I pushed a couple of changes, would you mind to review again and see if my changes/tests make sense?

Is it possible to configure the ci to run styling tests so that we make sure that things like let _ :f32 does not happen again?

Yeah it is, it has been discussed before too. But currently that would include reformatting the entire codebase which is a bit suboptimal. It might get added in the future, but right now it's not an option to just "switch it on" and be good to go, it's a bit more involved. The idea is great though and I'd love to see that myself too!

Can it get merged? 😬

Thanks a lot for working on this @felippemr, everything looked great now so I've merged these changes.
Congratulations on the first merged PR, good work! :+1:


test: ensure fakeCacheResolver implements the Resolver interface

What this PR does / why we need it:
test: ensure fakeCacheResolver implements the Resolver interface
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
To be rebased after #23 is merged
Release note:

/ready


Add Mastodon sharing link

Via tootpick.org -- source is this repo

Thanks for the PR, @seanhagen! I'm happy to add this into the theme. I'll just make a few adjustments and then I'll merge it in.


label right for vsinputnumber

Adds prop labelRight on VsInputNumber component. Works like the existing label prop, but will allow to set a label on the right side of the value.

Ok, obviously something went wrong with my PR.


bump version 2.0.5

Codecov Report
Patch coverage: 100.00% and no project coverage change.

Comparison is base (7aba4f4) 100.00% compared to head (882539e) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #218   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           35        35
  Lines         4769      4769
=========================================
  Hits          4769      4769

Impacted Files
Coverage Δ

megfile/version.py
100.00% <100.00%> (ø)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Update Julia version in CI

As the title says, update the Julia version used in the CI to 1.10, and use 1.10 and 1.11 additionally in automated unit tests.

Because Julia 1.11 is not released yet, there is no container with the tag.
https://hub.docker.com/_/julia
We could test rc but I'm not sure, what happen if Julia 1.11 is released. Maybe it will be removed, stuck to 1.11 or moved the 1.12 dev.

We could test rc but I'm not sure, what happen if Julia 1.11 is released. Maybe it will be removed, stuck to 1.11 or moved the 1.12 dev.

That seems like the most reasonable option. I'd suspect that once 1.11 is released, the latest tag will be moved to 1.11 and the rc tag will be moved to 1.12. In any case we will have to update the CI again anyways when that happens, but at least it should not start to fail using rc then.

There are warnings in Julia 1.9 and Julia 1.10 which should be fixed a upcoming PR. Also for 1.10 there is a error for pre-compiling. But it looks like, this is not a big problem.


Get translations from BnF with Belgian contributors

Querying the information from the SPARQL endpoint of BnF: https://data.bnf.fr/sparql/
Update tracking
The commit https://github.com/SvenLieber/beltrans-data/commit/826eb4771d89c5be91e122eb322886eed9be9b4c added functionality to extract and load BELTRANS-relevant BnF edition data in the named graphs <http://bnf-fr> and <http://bnf-nl>. However, other data related to the editions still need to be extracted and loaded separately via other provided dumps:

[x] links between editions and contributors (contributions dump)
[x] information about contributors (person-authors dump)
[x] information about external links: ISNI (external/isni exact match dump)
[x] information about external links: VIAF (external/viaf exact match dump)
[x] information about external links: Wikidata (external/wikidata exact match dump)
[ ] #61

There are plenty more dumps for other external references such as links to the German or Spanish national library, but for now I focused on the most important for BELTRANS.
For the external references dumps it makes sense to keep them in an own named graph after import, thus making the mapping to our data model easier. For example for ISNI, there can then be a simple SPARQL CONSTRUCT query which queries the ISNI references named graph fetching only skos:exactMatch with ISNI numbers to create a representation according to our data model in another named graph.

Most of this data is integrated. The only exception is the Rameau classification which is followed up in another issue.


iOS Support

iOS support isn't a priority at the moment, since on average iOS devices performance is much better (and usually that translates to apps having less performance issues).
However it is still something we want to search into and implement at some point, so if you'd like to have iOS support, feel free to show it by adding a 👍 emoji to this issue.

How we can help with iOS support?

Thanks for asking @developerdanx!
On iOS, we haven't investigated much a technical solution yet.
For the performance measuring part, I think one possibility would be to use xctrace (previously XCode instruments) to generate a trace file, and then manage to parse it to get an array of measures out of it
If you'd like to try your hand at a POC, I'd be happy to help out!

Yes this is feasible I think. I'll try something out and share the results 😁

Hi ! Quick update, we are also going to try to develop a POC for iOS in the next days with @Almouro

We've deployed the (crude) POC here https://github.com/bamlab/flashlight/tree/poc/ios/packages/ios-poc
We'll work to make it easier to use in the coming weeks with @GuillaumeEgret 🤞

Hey guys! Is this still ongoing? I'd love to test iOS devices as well

+1 to see if this iOS support is still in development

hey everyone 👋
do you have any updates for iOS support?
cc: @Almouro

+1 for this too.
How can I help contribute to this effort? I'd like to know what are the technical challenges: is it building the perf app in iOS, or is it installing it on a device (idb hurdle), or something else?

Sorry it took so long for me to answer this, it's a good idea to sum up a bit where we're at at the moment!
Sadly, things are not as easy as on Android, where we can just openly read values from system files.
There are 3 elements that are part of the Flashlight philosophy for Android which are tricky to get on iOS:

[ ] live measures with flashlight measure
[ ] thread by thread measures
[ ] blackbox measures (as in: no in-app setup required, can work on production apps)

We have a few approaches that we've tried but are not entirely satisfied with, (and it's also a challenge to dedicate resources to this on our side.)
1st approach: Instruments CLI
❌ Live measures
✅ Thread by thread measures
✅ Blackbox measures
On iOS, Instruments is the usual tool used for performance measures. It's in my opinion very adequate and technically ticks all the boxes above.
However, it's not necessarily easy to use and doesn't offer an easy comparison view.
Instruments however offers a CLI that we can use. Sadly, that CLI doesn't offer live measures. It's also not super easy to use, but @GuillaumeEgret did a fantastic job researching and parsing the output.
It's not totally done still, and there's still this PR open to get it merged that we need to get back to.
2nd approach: using py-ios-device
✅ Live measures
❌ No thread by thread measures
✅ Blackbox measures
Several people have already tried to do something similar and capture live measures with their own tools. One such tool is https://github.com/YueChen-C/py-ios-device. Essentially those tools can behave just like Instruments would and talk with the app to get the same data.
The way to create such a tool is basically by reverse engineering Instruments and it's not an easy task by any mean. The protocols used by Instruments to communicate with the app is reaaaally not straightforward 😅
Unfortunately thread by thread measures seem quite hard to achieve with such a tool.
We do have a POC here which should be working, although we haven't tested it in a while 😬
3rd approach: create a plugin to install in the measured app
✅ Live measures
✅ No thread by thread measures
❌ Blackbox measures
We haven't explored this approach a lot, but coming back to it might be a good idea.
The idea would be to have something similar to https://github.com/bamlab/react-native-flipper-performance-monitor
We install an SDK in your iOS app, which can get all relevant data, and communicate that data to Flashlight via websocket. We haven't explored yet what is possible, but it seems we could get out of the box live measures and thread CPU measures.
It generally seems simpler to implement and easier to maintain, however we lose the blackbox aspect:

we need to install an SDK in the app, which shouldn't be published with the app to the appstore

On the other hand, it's much simpler to have quick feedback on what we implement, even if it's in dev mode
In general, my current point of view is I feel like maybe we should reconsider the 3rd approach to see what we can do!
Feel free to jump in the conversation and share your point of view, or just add an emoji 1⃣, 2⃣, 3⃣ to notify which option you'd rather have.
If you'd like to try your hand at implementing one option, or have another idea in mind, let me know and I can help out!
I'll also try to restart that conversation with the RN community as well before the end of the month

Maybe 1⃣ together with a video recording?

Previously, I wouldn’t have chosen 1⃣ as my go-to, as I loved using Flashlight for live measurements. Recently, however, I’ve started using Flashlight to create performance reports, and it’s been working well for me. I’m also leaning towards 1⃣ now because it provides thread-by-thread and black-box measurements, which offer a more streamlined developer experience when debugging performance issues


Enhance/fix MT-processing related things

Let calls through thread guards in resource loading contexts.
Optimize threading-sensitive node data for single-threaded processing.

Thanks!


About short_memory_merge and long_memory_length

From conference.py, it can be seen that in the "encode_short_memory_frame" function, short_memory_merge is used to merge, however, long_ memory_length parameter looks more like the RL mentioned in the paper, but it is not used. May I ask if you can provide a detailed explanation of the operation process of the memory network? For example, in the form of pseudocode or algorithms. The expression in the paper and code really confuses me.

short_memory_merge  is set to 2 in MovieChat/models/moviechat.py, which stands for R_{L} in the paper.
Please make sure the paper version first: https://arxiv.org/pdf/2307.16449.pdf
For the detailed explanation of the operation process of memory consolidation, you can refer to Section 3.4. Long-term Memory in the paper. For the pseudocode, you can refer to Algorithm 1 Memory consolidation in page 4. For the algorithm schematic diagram， Figure 2. in page 3 and Figure A1. in page 14 may help a lot.
Hope the information I provide can help clarify your confusion.

Yes, and the implement details and the result of the experiment can be seen in Section 5.2. Ablation Study, which signifies the importance of memory mechanisms.

Where are the paramter long_memory_length and the function encode_videoQformer_visual used?

In fact, they were not used.

Is the length of the long memory unrestricted in this way? Figure 1 in the paper shows that VRAM occupancy remains constant, which seems to be due to the length of the long memory being set.

The length of the long memory is indeed unrestricted. There is a minor variation in VRAM for MovieChat, and it is independent of the setting of the long memory length. The reason for the minimal variation in RAM usage in our method is that our memory consolidation strategy effectively conserves RAM while preserving video information as much as possible.

Have you estimated how many frames and tokens a video will ultimately retain? If a video is very long, will it exceed the input limit of a large language model?

the input limit of LLaMA is 256, so after memory consolidation, the final retained frames is no more than 256 ( in global modal, it will retain 256 frames in the long-term memory)

但是我看到vicuna的输入长度是4k？这个长度是不是token数量而不是帧数呀。如果图片是224*224并且patch=14的话，每一帧的token数应该是256吧


Update PeerDependency to Angular 6

Angular 6 was released today and I would like to use this package without install warnings. This also includes updating the rxjs peerDependency (even though I don't see how rxjs is required by this package). I tested this component in an angular 6 app without any problem.

rxjs isn't required and should be removed from peer dependencies.

Thanks again @PascalHonegger .
#39 closed this issue.

same thing with Angular7


django-import-export actions styling not working

After inheriting from ImportExportActionModelAdmin action styling doesn't work. The same issue with any model with import/export action.
unfold.contrib.import_export added at the beggining of the INSTALLED_APPS
Django 3.2.20, django-import-export 3.3.1 (latest), django-unfold 0.11.0 (latest)

Hey, could you try to put "ImportExportActionModelAdmin" after "ModelAdmin"?

Yep, still the same

I actually had to write a workaround last week to make it (partially) work. The issue has to do with how the Choices control gets added (which has a different inheritance tree). There is still something with the labels, hence why I set it to " ". Have not had time to look into it, but at least this unblocked me. I hope it helps.
from django.utils.translation import gettext_lazy as _
from unfold.forms import ActionForm
from unfold.widgets import SELECT_CLASSES

########################################################################################################
#
# Below we have workarounds to make the export *action* functionality work with
# the unfold admin. The original implementation of the import/export functionality
# is in the django-import-export package with the following problems:
#
# 1) django.forms.ActionForm needs to be changed to unfold.ActionForm. There is a
#    export_action_form_factory function that has been copied from the original
#    import_export module as is, and just modified to use unfold.ActionForm
#
# 2) ExportActionModelAdmin needs to inherit from unfold.ModelAdmin instead of
#    django's ModelAdmin. We create a new class CanariaExportActionModelAdmin to
#    reduce confusion.
#
# 3) CanariaExportActionMixin's __init__ method is an exact copy of the original
#    parent class import_export_admin.ExportActionMixin, but we leave the rest of
#    the class as is. Since we only want to override the __init__method which creates
#    the ActionForm (i.e. our unfold ActionForm, not Django's) we just copy the
#    whole class ****and skip the __init__ method of the parent class****. This is the
#    trick to make it work.

def export_action_form_factory(formats):
    """
    Returns an ActionForm subclass containing a ChoiceField populated with
    the given formats.
    """

    class _ExportActionForm(ActionForm):
        """
        Action form with export format ChoiceField.
        """

        # label=_("Format") - it is not rendering correctly because of styling
        # will submit an issue to unfold
        file_format = forms.ChoiceField(
            label=_(" "),
            choices=formats,
            required=False,
            widget=forms.Select({"class": " ".join([*SELECT_CLASSES, "w-72"])}),
        )

    _ExportActionForm.__name__ = str("ExportActionForm")

    return _ExportActionForm

class CanariaExportActionMixin(import_export_admin.ExportActionMixin):

    def __init__(self, *args, **kwargs):
        """
        Adds a custom action form initialized with the available export
        formats.
        """
        choices = []
        formats = self.get_export_formats()
        if formats:
            for i, f in enumerate(formats):
                choices.append((str(i), f().get_title()))

        if len(formats) > 1:
            choices.insert(0, ("", "---"))

        self.action_form = export_action_form_factory(choices)
        # skip the direct super class constructor of the mixin and
        # chain it up to the next class in line
        super(import_export_admin.ExportMixin, self).__init__(*args, **kwargs)

class CanariaExportActionModelAdmin(CanariaExportActionMixin,
                                    unfold_admin.ModelAdmin):
    """
    Subclass of Unfold ModelAdmin with export functionality implemented as an
    admin action. We use unfold admin to change the default look of the admin.
    """
    pass

@rburhum are you specifying import_form and export_form? Docs here:
https://github.com/unfoldadmin/django-unfold#django-import-export

@FadingFog I just tested the application on User model and it was working as expected. I recommend to check an example implementation of UserAdmin in Formula project and especially how UserAdmin inherited from BaseUserAdmin:
https://github.com/unfoldadmin/formula/blob/main/src/formula/admin.py#L3

This is optional since I am overriding the model. And as I said, it makes no difference if I use UserAdmin or just another model - the result is the same on all models

Please create for me an example repository where I can reproduce this behavior.

@rburhum are you specifying import_form and export_form? Docs here:

https://github.com/unfoldadmin/django-unfold#django-import-export

@lukasvinclav I only needed to do export - don't want import because it doesn't make sense in my application and I have special logic. With my overrides, it works.

Interesting... I created new django project with same versions of packages, but behavior is completely changed. So, there're now buttons for import and export, instead of actions (so its applied to all of the elements in changelist) and styling works well. Here is comparison:
Existing project

New project

Based on the picture, I guess issue was solved. For other people, please be aware that unfold.contrib.import_export has to be in INSTALLED_APPS before import_export.

i put unfold.contrib.import_export in settings and get "ModuleNotFoundError: No module named 'unfold.contrib.import_export'"


example project: ERROR in Cannot find module '../features'

Hi! There is a small issue in example project. After the npm install && npm start execution and opening localhost:3456, the following webpack error appears:
ERROR in Cannot find module '../features'
 @ ./website/Application.css 4:14-148 13:2-17:4 14:20-154

ERROR in Cannot find module '../features'
 @ ./website/components/Card/CardWrapper.css 4:14-160 13:2-17:4 14:20-166

ERROR in Cannot find module '../features'
 @ ./website/components/Footer/Footer.css 4:14-155 13:2-17:4 14:20-161

ERROR in Cannot find module '../features'
 @ ./website/components/Card/Card.css 4:14-153 13:2-17:4 14:20-159

ERROR in Cannot find module '../features'
 @ ./website/components/Header/Header.css 4:14-155 13:2-17:4 14:20-161

ERROR in Cannot find module '../features'
 @ ./website/components/Widget/Widget.css 4:14-155 13:2-17:4 14:20-161

Seems like this is related to cssnext module. When I remove it from loaders: ['style', 'css?modules&importLoaders=1', 'cssnext'] all works well. Did i missed something, or it's an untested behaviour? Thanks.

Wow. I've overlooked this issue for a long time. Sorry about that! It wasn't intentional.
I can't reproduce this error, having just npm i && npm start to verify. The "example project" (I assume you're referring to the Github pages site?) works fine for me, no errors. Maybe this was a transient issue- something that went wrong with an NPM install or a dependency?
Anyway, going to close it for now since things seem to be working okay for me.


Can't tell failure reason from the log

This diff has been built twice and failed both times, but from the log it isn't clear what failed:
https://results.llvm-merge-guard.org/amd64_debian_testing_clang8-9444/console-log.txt
https://results.llvm-merge-guard.org/amd64_debian_testing_clang8-9447/console-log.txt

There was only one test, which passed:
Testing Time: 489.87s
  Unsupported Tests:   674
  Expected Passes  : 65160
  Expected Failures:   242

And the clang-format also had no issues:
clang-format did not modify any files

Using set -e can "fail" if one of the conditions in an if fails even if it was supposed to. It gets really hard to know what failed just by looking at the logs. You should really set a trap or check for $? or something more robust and meaningful.

looking at the first log file, ninja all failed:
[4943/5766] Building CXX object tools/mlir/tools/mlir-opt/CMakeFiles/obj.MLIRMlirOptMain.dir/mlir-opt.cpp.o
FAILED: tools/mlir/tools/mlir-opt/CMakeFiles/obj.MLIRMlirOptMain.dir/mlir-opt.cpp.o
CCACHE_DIR=/mnt/disks/ssd0/ccache CCACHE_MAXSIZE=20G CCACHE_CPP2=yes CCACHE_HASHDIR=yes /usr/bin/ccache /usr/bin/clang++  -DGTEST_HAS_RTTI=0 -DMLIR_CUDA_CONVERSIONS_ENABLED=1 -D_DEBUG -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -Itools/mlir/tools/mlir-opt -I/mnt/disks/ssd0/agent/workspace/amd64_debian_testing_clang8/mlir/tools/mlir-opt -I/usr/include/libxml2 -Iinclude -I/mnt/disks/ssd0/agent/workspace/amd64_debian_testing_clang8/llvm/include -I/mnt/disks/ssd0/agent/workspace/amd64_debian_testing_clang8/mlir/include -Itools/mlir/include -gmlt -fPIC -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wstring-conversion -fdiagnostics-color -ffunction-sections -fdata-sections -O3     -fno-exceptions -fno-rtti -UNDEBUG -std=c++14 -MD -MT tools/mlir/tools/mlir-opt/CMakeFiles/obj.MLIRMlirOptMain.dir/mlir-opt.cpp.o -MF tools/mlir/tools/mlir-opt/CMakeFiles/obj.MLIRMlirOptMain.dir/mlir-opt.cpp.o.d -o tools/mlir/tools/mlir-opt/CMakeFiles/obj.MLIRMlirOptMain.dir/mlir-opt.cpp.o -c /mnt/disks/ssd0/agent/workspace/amd64_debian_testing_clang8/mlir/tools/mlir-opt/mlir-opt.cpp
In file included from /mnt/disks/ssd0/agent/workspace/amd64_debian_testing_clang8/mlir/tools/mlir-opt/mlir-opt.cpp:16:
In file included from /mnt/disks/ssd0/agent/workspace/amd64_debian_testing_clang8/mlir/include/mlir/InitAllDialects.h:24:
/mnt/disks/ssd0/agent/workspace/amd64_debian_testing_clang8/mlir/include/mlir/Dialect/Linalg/IR/LinalgOps.h:84:10: fatal error: 'mlir/Dialect/Linalg/IR/LinalgStructuredOpsInterfaces.h.inc' file not found
#include "mlir/Dialect/Linalg/IR/LinalgStructuredOpsInterfaces.h.inc"
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.

Weird. If the build fails, how come it can run and pass the tests?

Also, this is a wider issue. We can't see any of that from the Phab page. Having a pre-merge test that fails without any further information is worse than having a post-merge buildbot fail with all the information available.
If we're going to have pre-merge checks, they need to either be publicly accessible or propagate the error messages concisely and accurately, as well as not be flaky.
I can't imagine how Matt's change has triggered the error above.

I can't imagine how Matt's change has triggered the error above.

The build was already broken.
Actually this issue is interesting: the script detected that the build failed (running ninja), but still continues and try to run the tests (ninja check-all). Because the error is non deterministic (missing dependency triggering an issue only in parallel builds), then running ninja check-all passed afterwards.

Interesting! I see, but that means what "passed" was an earlier build, no?

Not sure what you mean.
I think the script invoked separately the build and the test. So the build “failed” but when running the tests, ninja just resume the build where it failed (but this time it’ll pass)

Of course! Ok, so the test is an actual pass.
When dealing with flaky tests like that, some frameworks run the entire test again N times until it passes or it gives up, but only showing the last result. Otherwise, we get weird cases like this.
Also, how can I reach the logs from the Phab page?

There are several things to explain here:

We're looking into replacing the (hidden) Jenkins builds with Buildkite. But that's work in progress. This would give you a better visibility of the build status.

We're running the linters and builds in the same pipeline at the moment. This means that we continue building even if one of the steps fails so that you still get lint results even if compilation fails. We should probably split that up when moving to a new infrastructure #177.

Phabricator shows the build correctly as "failed". So there was no risk of integrating a failing build. Phabricator does not offer a whole lot of options for giving detailed build feedback, this is why we're generating the summary. And that also correctly classified the build "ninja all failed". This summary is meant as the first place for users to look for the build status.

Pre-merge tests are optional at the moment for several reasons, reliability of the entire infrastructure being one of them. The pre-merge tests are not a paid-for service. They are right now a best-effort side project for a few community members, as with most LLVM infrastructure. So we'd be happy to get people onboard to improve them.

Overall pre-merge testing would be 10x simpler if LLVM would be using Github Pull Requests instead of Phabricator. For PR you get tons of nice tools for free. But thats an entirely different topic...

Hi Christian, thanks for the detailed feedback.

Awesome, thanks!
Splitting is probably a good idea.
It would be the correct classification if the build had actually failed. I know it's not possible to distinguish in Phab, but to be able to rely on it, the build must be stable. In LLVM, unstable buildbots get turned off for until they can be proven stable again.
Been there, done that. :) I'm not blaming the infrastructure, just trying to help make it better. I think a simple internal loop on each stage (3 times is enough) until it's green would go a long way of getting rid of the instability.
Don't get me started! :D

Also, how can I reach the logs from the Phab page?

You have a link to the build log here.

We're running the linters and builds in the same pipeline at the moment. This means that we continue building even if one of the steps fails so that you still get lint results even if compilation fails.

What's missing is that the bottom of the log a recap of all the steps and an indication of which one succeeded/failed.
The same script implemented on GitHub PR would have the exact same problem in this case.

Thanks @joker-eph, I didn't realise those things were links.

@joker-eph improving the provided log files is a good idea, I just added #178 for that. Iw would also be nice to have some better way of serving the logs than plain text, I haven't found anything in the open source world so far.
On Github PR, I would just refer to the Buildkite UI, that contains all relevant data (can't add link as buildkite is down so much for stability there 😉 ).

@rengolin

I haven't seen much flakiness in builds. We had some bugs in the infrastructure we're trying to shake out over time, but actual random failures are rare in my observation.

Re-running the entire test build is way to expensive with CMake in CPU resources and wall time. We already have much longer build times than I would like to have, even with ccache/sccache in place. If you want such features, we need a build system that handles incremental builds and changes in dependencies better.

I don't mean the entire build, just the part that failed. In fact, this is what just happened, when ninja check pulled the rest of the build, but without the semantics that it made the build actually pass.
Of course, a much better fix is to get rid of those issues in the first place. If .inc files are delayed before they get included, it means the files that include them aren't dependencies of the table-gen process that created them.


Question about Evaluation

Hi! For the Penetration Testing Benchmark, has it been run against Pentestgpt? We saw in the paper it was run against vanilla GPT3.5, GPT4, Bard but we were just curious how much PentestGPT improves here.

nvm I think I found it


add rtl support

In this PR, I implemented RTL support without impacting LTR functionality, taking all screen breakpoints into account.
Here’s a summary of the changes:

Replaced pl-* and pr-* classes with ps-* and pe-*
Replaced ml-* and mr-* classes with ms-* and me-*
Substituted left-* and right-* with start-* and end-*
Added rtl:space-x-reverse for all TailwindCSS screens where space-x-* was used
Adapted all transitions for LTR and included reversed transitions for RTL
Added APP_LOCALE, APP_FALLBACK_LOCALE, and APP_FAKER_LOCALE to .env.example and referenced them in config/app.php
Set dir="ltr" in all layout files

These changes will only take effect if dir="rtl" is specified, either by hard-coding or dynamically setting it based on the app’s locale, for example: dir="{{ app()->getLocale() == 'ar' ? 'rtl' : 'ltr' }}".

Wow! Thanks for the amazing PR. Considering this is a lot of UI updates I want to test many of this manually and make sure everything still looks good. Appreciate the PR. I'll be testing this out soon.

@tnylea do you need any help in testing this PR? maybe you can get help from native RTL people


Fix typos and conventions

I've just fixed a few typos and conventions.
Thank you very much for making all this high-quality material publicly available!

Thanks!


npm release

can you please release on npm, even as @next tag, the latest code from master ?

We have to get #126 merged first for the next release


Setup

Changes made in this pull request :

[x] Created a Ruby on Rails project.
[x] Created a react project inside the Ruby on Rails project.
[x] Added Database.
[x] Created API.

How to run the project
rake db:create
rake db:migrate
rails server -p 3000

Happy Review 👍🏾  😄

Hi @kosher9,
While you made a great effort in this project, unfortunately, I cannot proceed to review your code.
Invalid Code Review Request
You have submitted a project, that has GITHUB FLOW instead of GITFLOW.
Your Code Review Request will be marked as invalid in your Dashboard, so please submit a new one once you are ready 🙏
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

Invalid Code Review Request does not count into the code reviews limit.

Hi @arslanbisharat, can you elaborate, please? I didn't get it.

Sure.
Please create a PR from feature to dev brach. You have branch from Feature
to main.
On Tue, 9 Aug 2022 at 7:04 PM, Cédric Kossi @.***>
wrote:

Hi @arslanbisharat https://github.com/arslanbisharat, can you
elaborate, please? I didn't get it.
—
Reply to this email directly, view it on GitHub
https://github.com/kosher9/hello-rails-react/pull/1#issuecomment-1209426332,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AN6LLT4XNQA4WAEAC7T4I43VYJQNXANCNFSM56AZUI5Q
.
You are receiving this because you were mentioned.Message ID:
@.***>

--
*Looking forward to hearing from you. *
Best,
Arslan Bisharat

🤣  I forgot to set dev the default branch. Thank you @arslanbisharat


Undefined substitution argument visual_material

I'm getting the below error while running roslaunch clover_simulation simulator.launch. I was following this tutorial.
rajendra@u20:~/drone_ws$ roslaunch clover_simulation simulator.launch
... logging to /home/rajendra/.ros/log/d8dbb14c-8caa-11ec-81f3-f39e9237e8e2/roslaunch-u20-672293.log
Checking log directory for disk usage. This may take a while.
Press Ctrl-C to interrupt
Done checking log file disk usage. Usage is <1GB.
Undefined substitution argument visual_material
when evaluating expression 'color'
when instantiating macro: vertical_clover_rotor (/home/rajendra/drone_ws/src/clover/clover_description/urdf/clover/clover4_macros.xacro)
in file: /home/rajendra/drone_ws/src/clover/clover_description/urdf/clover/clover4_physics.xacro
included from: /home/rajendra/drone_ws/src/clover/clover_description/urdf/clover/clover4_base.xacro
included from: /home/rajendra/drone_ws/src/clover/clover_description/urdf/clover/clover4.xacro
RLException: while processing /home/rajendra/drone_ws/src/clover/clover_description/launch/spawn_drone.launch:
Invalid  tag: Cannot load command parameter [drone_description]: command [['/opt/ros/noetic/lib/xacro/xacro', '/home/rajendra/drone_ws/src/clover/clover_description/urdf/clover/clover4.xacro', 'main_camera:=true', 'rangefinder:=true', 'led:=true', 'gps:=false', 'maintain_camera_rate:=false', 'use_clover_physics:=false']] returned with code [2].
Param xml is
The traceback for the exception was written to the log file

Hi! I guess this might be related to this change: https://github.com/CopterExpress/clover/commit/b6bd6bdde8c10c732d6a536d139df0310ea9fc0e#diff-1053df277d01eecbc3dd9b738996bfd1475aedea2dc5552bd8608c644f946bb0L25.
I don't understand how it works everywhere, including our image, though.
Try to just replace $(arg visual_material) to DarkGrey in clover4_physics.xacro.

@okalachev Thank you so much for your prompt response. I would try your suggestion and would update back :)

@iamrajee, hi, have you found some time to test the fix, so I could commit it?

@iamrajee, hi, have you found some time to test the fix, so I could commit it?

No, I just tried replacing $(arg visual_material) with DarkGreyDarkGrey, and it worked. Haven't tried anything else.

Considering the fix works, so committed. @iamrajee, thanks for the report.


BAU: Rename project to verify-pkg-hiera-eyaml-gpg

hiera-eyaml is already bundled with recent puppet agents, so all we need to package are hiera-eyaml-gpg and ruby_gpg. Rename the project to reflect this.

rhowe-gds PR#1000


Add embedded tomcat to the test env

What does this PR do?

Motivation

Additional Notes

Review checklist (to be filled by reviewers)

[ ] Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
[ ] Changelog entries must be created for modifications to shipped code
[ ] Add the qa/skip-qa label if the PR doesn't need to be tested during QA.

Current dependencies on/for this PR:

master:

PR #16629 👈

This comment was autogenerated by Freephite.


Update the doc to highlight that, it is not possible to @mention a bot in an Adaptive Card sent from an incoming webhook

Type of issue
Other (describe below)
Feedback
Please add a note in this page, highlighting that "Currently, it is not possible to @mention a bot in an Adaptive Card sent from an incoming webhook. Only user mentions are supported in Adaptive Cards sent from incoming webhooks"
Page URL
https://learn.microsoft.com/en-us/microsoftteams/platform/task-modules-and-cards/cards/cards-format?tabs=adaptive-md%2Cdesktop%2Cconnector-html#microsoft-entra-object-id-and-upn-in-user-mention
Content source URL
https://github.com/MicrosoftDocs/msteams-docs/blob/main/msteams-platform/task-modules-and-cards/cards/cards-format.md
Author
@surbhigupta
Document Id
e5f5f69e-66e9-d1b2-e19a-485d0ffcd6fa

Hi @surbhigupta12 - Could you please help here to update the document as mentioned?


Fixes gh-1308

Deleting the "RibbonCommand" suffix on master

@garciafl Please sign the Contributor License Agreement!
Click here to manually synchronize the status of this Pull Request.
See the FAQ for frequently asked questions.

@garciafl Thank you for signing the Contributor License Agreement!

@garciafl thanks for the pull request!  Can you look at the test failures?  Also I believe @spencergibb said this should be fixed on the 1.1.x branch (I could be wrong though)

Oh i see the other pull request for the 1.1.x branch now :)

Closed via 048d401309287928f6843a10626fe20aeada6645


Pass options down to base transport class

Otherwise "level" option isn't set. However, it should be set, because it's a default option for all Winston transports, and Logger Winston class expects the transport to have it.

I just spent an hour debugging this issue. The only workaround is to set transport log level after creating it.

thanks!


AndroidRuntime: FATAL EXCEPTION: OkHttp Dispatcher

E AndroidRuntime: java.lang.NoSuchMethodError: No virtual method toString(Z)Ljava/lang/String; in class Lokhttp3/Cookie; or its super classes (declaration of 'okhttp3.Cookie' appears in /data/app/com.piglet-VoaKTU4zctXOlMHherGcyg==/base.apk!classes2.dex)
E AndroidRuntime: 	at okhttp3.JavaNetCookieJar.saveFromResponse(JavaNetCookieJar.java:45)
E AndroidRuntime: 	at com.facebook.react.modules.network.ReactCookieJarContainer.saveFromResponse(ReactCookieJarContainer.java:36)
E AndroidRuntime: 	at okhttp3.internal.http.HttpHeaders.receiveHeaders(HttpHeaders.kt:207)
E AndroidRuntime: 	at okhttp3.internal.http.BridgeInterceptor.intercept(BridgeInterceptor.kt:86)
E AndroidRuntime: 	at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.kt:112)
E AndroidRuntime: 	at okhttp3.internal.http.RetryAndFollowUpInterceptor.intercept(RetryAndFollowUpInterceptor.kt:71)
E AndroidRuntime: 	at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.kt:112)
E AndroidRuntime: 	at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.kt:87)
E AndroidRuntime: 	at okhttp3.RealCall.getResponseWithInterceptorChain(RealCall.kt:184)
E AndroidRuntime: 	at okhttp3.RealCall$AsyncCall.run(RealCall.kt:136)
E AndroidRuntime: 	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1162)
E AndroidRuntime: 	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:636)
E AndroidRuntime: 	at java.lang.Thread.run(Thread.java:764)
React Native version:
System:
OS: macOS Mojave 10.14.6
CPU: (6) x64 Intel(R) Core(TM) i5-8500 CPU @ 3.00GHz
Memory: 22.18 MB / 8.00 GB
Shell: 3.2.57 - /bin/bash
Binaries:
Node: 12.10.0 - /usr/local/bin/node
Yarn: 1.17.3 - /usr/local/bin/yarn
npm: 6.10.3 - /usr/local/bin/npm
Watchman: 4.9.0 - /usr/local/bin/watchman
SDKs:
iOS SDK:
Platforms: iOS 13.2, DriverKit 19.0, macOS 10.15, tvOS 13.2, watchOS 6.1
Android SDK:
API Levels: 21, 23, 24, 25, 26, 27, 28, 29
Build Tools: 25.0.2, 25.0.3, 28.0.3, 29.0.0, 29.0.2
System Images: android-21 | Android TV ARM EABI v7a, android-21 | Android TV Intel x86 Atom, android-21 | ARM EABI v7a, android-21 | Intel x86 Atom, android-21 | Intel x86 Atom_64, android-21 | Google APIs ARM EABI v7a, android-21 | Google APIs Intel x86 Atom, android-21 | Google APIs Intel x86 Atom_64, android-23 | Android TV ARM EABI v7a, android-23 | Android TV Intel x86 Atom, android-23 | Android Wear ARM EABI v7a, android-23 | Android Wear Intel x86 Atom, android-23 | ARM EABI v7a, android-23 | Intel x86 Atom, android-23 | Intel x86 Atom_64, android-23 | Google APIs ARM EABI v7a, android-23 | Google APIs Intel x86 Atom, android-23 | Google APIs Intel x86 Atom_64, android-24 | Android TV Intel x86 Atom, android-24 | ARM 64 v8a, android-24 | ARM EABI v7a, android-24 | Intel x86 Atom, android-24 | Intel x86 Atom_64, android-24 | Google APIs ARM 64 v8a, android-24 | Google APIs ARM EABI v7a, android-24 | Google APIs Intel x86 Atom, android-24 | Google APIs Intel x86 Atom_64, android-24 | Google Play Intel x86 Atom, android-26 | Android TV Intel x86 Atom, android-26 | China version of Android Wear Intel x86 Atom, android-26 | Android Wear Intel x86 Atom, android-26 | Intel x86 Atom, android-26 | Intel x86 Atom_64, android-26 | Google APIs Intel x86 Atom, android-26 | Google APIs Intel x86 Atom_64, android-26 | Google Play Intel x86 Atom, android-28 | Google Play Intel x86 Atom, android-29 | Google APIs Intel x86 Atom, android-Q | Android TV Intel x86 Atom
IDEs:
Android Studio: 3.5 AI-191.8<IP_ADDRESS>91312
Xcode: 11.2/11B52 - /usr/bin/xcodebuild
npmPackages:
react: 16.9.0 => 16.9.0
react-native: 0.61.1 => 0.61.1
npmGlobalPackages:
react-native-asset: 2.0.0
react-native-cli: 2.0.1
react-native-update-cli: 0.1.0

same runtime error here - build is fine
My android technical knowledge is still a bit limited - but from what i can research
https://github.com/square/okhttp/issues/5425 -> leaves me to believe it is caused by different version numbers in the okhttp dependency
my fix to get the build to stop crashing during runtime was to include these in my android/app/build.gradle
    compile "com.squareup.okhttp3:okhttp:4.2.1"
    compile "com.squareup.okhttp3:logging-interceptor:4.2.1"
    compile "com.squareup.okhttp3:okhttp-urlconnection:4.2.1"

同样的运行时错误-构建很好
我的Android技术知识仍然有限-但据我
所知，square / okhttp＃5425- >让我相信这是由okhttp依赖项中的不同版本号引起的
我要让构建在运行时停止崩溃的解决方法是将这些包含在我的android / app / build.gradle中
    compile "com.squareup.okhttp3:okhttp:4.2.1"
    compile "com.squareup.okhttp3:logging-interceptor:4.2.1"
    compile "com.squareup.okhttp3:okhttp-urlconnection:4.2.1"

我认为正确的解决方法是找到从您的项目中添加的哪些导入导致版本差异，但是此替代对我暂时有效

thanks!

have the same issue as well. @JeffKGabriel , could you create screenshot how I can paste your 'magic strings' into  android/app/build.gradle

apologies for the late response -
towards the end of the file - there is a section for dependencies
so including a implementation or compile would look like
dependencies {
 --> compile "com.squareup.okhttp3:okhttp:4.2.1"
 --> compile "com.squareup.okhttp3:logging-interceptor:4.2.1"
 --> compile "com.squareup.okhttp3:okhttp-urlconnection:4.2.1"
}

apologies for the late response -
towards the end of the file - there is an existing section for dependencies
so including a implementation or compile would look like
dependencies {
     compile "com.squareup.okhttp3:okhttp:4.2.1"
     compile "com.squareup.okhttp3:logging-interceptor:4.2.1"
     compile "com.squareup.okhttp3:okhttp-urlconnection:4.2.1"
}

Thanks @JeffKGabriel ,
Few lines about my findings,
Actually, my app got crashed in android device with API response as 'SKIPPED' in reactotron log,
I tried to track with android studio and found FATAL EXCEPTION: OkHttp Dispatcher and issue solved with these above lines.

apologies for the late response -
towards the end of the file - there is an existing section for dependencies
so including a implementation or compile would look like
dependencies {
     compile "com.squareup.okhttp3:okhttp:4.2.1"
     compile "com.squareup.okhttp3:logging-interceptor:4.2.1"
     compile "com.squareup.okhttp3:okhttp-urlconnection:4.2.1"
}

Thanks!
I was all day trying to solve this problem, you saved me.

I have been getting this error, which I fixed using @JeffKGabriel 's comment, but on publishing the app to the Play Store I get a TrustManager vulnerability warning from Google Play.
Any clues, anyone?

I had this issue while doing a fetch() call using Authorisation headers.
The dependencies listed in this issue are working for Android 10, but not 6.
After a quick search, it seems that this is enough and cover 6 to 10:
    implementation "com.squareup.okhttp3:okhttp"
    implementation "com.squareup.okhttp3:okhttp-bom:4.4.1"

I had this issue while doing a fetch() call using Authorisation headers.
The dependencies listed in this issue are working for Android 10, but not 6.
After a quick search, it seems that this is enough and cover 6 to 10:
    implementation "com.squareup.okhttp3:okhttp"
    implementation "com.squareup.okhttp3:okhttp-bom:4.4.1"


Device does not show up under Linux-Chrome

I see a rather odd issue. Using Chromium under Linux the City Hub in Bootloader mode is detected and can be flashed. But once flashed it simply does not show up. This only happens with chromium on Linux. Edge on Windows and Chrome on Android just work.
I see this with Chromium:
Version 98.0.4758.102 (Official Build) snap (64-bit)

Web Bluetooth is not officially supported on Linux, so there are a number of bugs like this that have to be manually worked around.  See https://github.com/pybricks/support/discussions/270 for some tips on how to manually remove devices and the cache file to try to get it working.

Thanks a lot. Clearing the cache did the trick but not before restarting the bluetooth subsystem.


Better external image handling

For https://github.com/containerd/cri/issues/909.
For https://github.com/containerd/containerd/issues/2678.
This PR:

Add io.cri-containerd.image label for cri plugin managed images.
For images pulled/imported by other clients, e.g. ctr, the cri plugin will generate the image id as the unique reference, and apply the io.cri-containerd.image label. This prevents the image from losing all references unexpectedly.
Add 2 integration tests: "image can be recovered during restart" and "image pulled with containerd client can be seen by CRI plugin".

/cc @dmcgowan

@mikebrow Can you take a look at this? This is a more serious issue, because if image loses reference silently, we ContainerStatus will always fail because it can't convert image id to repotag and repodigest. This line https://github.com/containerd/cri/blob/master/pkg/server/container_status.go#L45 will always fail.


This is testing some settings for CA

Please don't merge this. This is me doing tests to see what clang-analyzer tweaks we should try to do for master.

[approve ci clang-analyzer]

I will take a look.


Detect faces in photos and return emotion

Detect the faces in a provided photo using Azure Cognitive Services facial recognition.
The client libraries were a bit temperamental, e.g. the trailing "/" when using the cognitive services for face caused a BadRequest. On the whole the cognitive services are ridiculously quick for what they're actually doing.

Thanks for completing the challenge! Fill out this form so we can send you the swag! https://aka.ms/cog-svcs-swag


opentracing-spring-jaeger-cloud-starter  does not support spring boot 2.3. X

opentracing-spring-jaeger-cloud-starter  is support spring boot 2.2. X but 2.3.x not support ,greater than Cloud Sr5 is not support

Right.
It should be simple to update it. Do you want to give it a try?

Spring Boot is now 2.3.x or higher by default

Spring Boot is now 2.3.x or higher by default

So this is fixed? @yongschoi

It doesn't seem to be the target of fix.
Check Breaking Changes.
https://github.com/spring-cloud/spring-cloud-release/wiki/Spring-Cloud-2020.0-Release-Notes

opentracing-spring-jaeger-cloud-starter supports spring boot 2.3.x well.
When using Feign in the spring boot 2.4.x environment, jaeger has a problem.
https://github.com/opentracing-contrib/java-spring-cloud/issues/312

I am running a spring boot 2.3.1 application with a zuul proxy. the zuul proxy stops working as soon as I add opentracing-spring-jaeger-cloud-starter, so no it does not work well

How about sleuth-zipkin?

I want to use jaeger?

可以使用sluth发送消息,使用jaeger进行接收

I tried to use it together with spring-cloud-starter-openfeign, in versions 2.4.4, 2.4.5, and 2.3.9 of Spring, but without any result.


IBC connection to other chains

we should aim to try to setup connection 3 others chains (Bridge to Near, Ethereum, Flow, Polkadot)

we need to figure out dependencies that are blocking this

it might be better to try to connect 2 Anoma chains first


Charades-STA C3D feature Problem

Can you provide the predict.py file for extracting the c3d features of the Charades-STA dataset in the c3d warehouse you gave?
In addition, please tell ViGA how to change the read-in feature dimension to (T, 1024) when ViGA is trained based on Charadest-STA?

Many thanks!

+1

Hi Lonicer,
Sorry for the late reply, was busy on other works quite intensely.
For Q1, please refer to issue https://github.com/r-cui/ViGA/issues/2 where we replied about the availablity of C3D Charades-STA features.
For Q2, we prepare all features offline and save the processed features on disk before training codes run. Please ensure you have the similar as described in the README, e.g., Folder contains 9848 vid.npys, each of shape (T, 1024).
Hope these help.


SSL Error

Hello,
tried to follow steps mentioned in wiki page, however getting SSL errors at 2 places:

curl -L -O https://releases.melissadata.net/Download/Library/LINUX/NET/ANY/latest/MelissaUpdater

% Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
Dload  Upload   Total   Spent    Left  Speed
0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
curl: (60) SSL certificate problem: unable to get local issuer certificate
More details here: https://curl.se/docs/sslcerts.html

curl failed to verify the legitimacy of the server and therefore could not
establish a secure connection to it. To learn more about this situation and
how to fix it, please visit the web page mentioned above.

I tried to pass this passing -k parameter to Curl

./MelissaAddressObjectLinuxDotnet.sh --address "22382 Avenida Empresa" --city "Rancho Santa Margarita" --state "CA" --zip "92688" --license <<KEY_RECEIVED_FOR_ORG>>

====================== Melissa Address Object ======================
[ .NET | Linux | 64BIT ]
Please enter your license string: <>
========================== MELISSA UPDATER =========================
MELISSA UPDATER IS DOWNLOADING DATA FILE(S)...

Starting Program @[2023-10-24 4:12:24 PM]
Fetching manifest data for DQ_ADDR_DATA for 2023.10
One or more errors occurred. (The SSL connection could not be established, see inner exception.)
Cannot run Melissa Updater. Please check your license string!

Hello @avikenjale ,
I suggest double check your SSL certificate, Linux Ubuntu and .NET versions. This was tested with Linux Ubuntu 20.04 LTS 64-bit and .NET 7.0 Runtimes. Using lower .NET versions may cause this SSL connection issue.
Hope this help!


Exceptions trouble : MisunderstoodCommandException

For command: PID:01 1F name: "RuntimeCommand.class"
com.github.pires.obd.exceptions.MisunderstoodCommandException: Error running 01 1F, response: ?
W/System.err:     at java.lang.reflect.Constructor.newInstance(Native Method)
W/System.err:     at java.lang.Class.newInstance(Class.java:1689)
W/System.err:     at com.github.pires.obd.commands.ObdCommand.checkForErrors(ObdCommand.java:203)
W/System.err:     at com.github.pires.obd.commands.ObdCommand.readResult(ObdCommand.java:123)
W/System.err:     at com.github.pires.obd.commands.ObdCommand.run(ObdCommand.java:77)
W/System.err:     at com.github.pires.obd.reader.io.ObdGatewayService.executeQueue(ObdGatewayService.java:199)
W/System.err:     at com.github.pires.obd.reader.io.AbstractGatewayService$1.run(AbstractGatewayService.java:39)

The same issue for 01 2F : FuelLevelCommand.class

I can't understand what's going on with this output. Care to disclose the full stacktrace?

@pires It's full log stacktrace.

Commands may return exceptions. You need to handle them. In this case, the error seems to be related to the response to 01 1F which seems to be wrong.
Since you're having so many issues, I'd say the protocol your car uses is mostly unsupported by obd-java-api library.
@valens254 seems to be the multi-protocol expert around and he's probably the most fit to help here again.

@Pho3niX90 would this be a CAN thing too?

I think this is purely a protocol that is not supported by the vehicle.
@Kolyall Which vehicle are you testing on and which year model? If I am correct this is not crashing the app, but just throwing the stacktrace? Thus far I have only seen 1 car that supports fuel level, and non that supports run-time (accurately).


Runtime.evaluate({ expression: 'document.getElementById(a)' })

var a = ...
Runtime.evaluate({ expression: 'document.getElementBiId(a)' }).then(){}

a is a variable
how to do that?

var a = 'someID';
// ...
Runtime.evaluate({ expression: `document.getElementById(${a})` }).then(

That works!
But
var a = 'someID';
Runtime.evaluate({ expression: 'document.getElementById(${a})' }).then((result) => {
                                            console.log( result.result.value);
                                        })

the result is undefine
how is that happen?

@fh1994 two things:

you have to use the backtick (`) for template literals (but you probably already are);
you need to properly quote the value (e.g., using JSON.stringify) otherwise you'll end up passing the actual HTML object since for convenience HTML tags with id=<x> are stored as global variables window.<x>; this is why you get null.

So:
Runtime.evaluate({
    expression: `document.getElementById(${JSON.stringify(a)})`
})

Got a follow-up here. Say I have a nodeId (and objectId) for some element, and I want to get the selector for it.
In other words, I want to be able to run:
Runtime.evaluate({
    expression: `document.getElementById(${JSON.stringify(a)})`
})

but I don't have a; all I have is a nodeId and objectId. Is there an easy way to get the selector?
Thanks!

Runtime.evaluate({
expression: document.getElementById(${JSON.stringify(a)})
})
this worked for me
thanks


Cross-Device Analytics Likely Does Not Integrate With AEP Identity Service (Or AEP At All)

Issue in ./help/getting-started/cja-overview.md
In the section "Comparing CJA and Cross-Device Analytics", it opens with this comment:

Cross-Device Analytics integrates with Adobe Experience Platform Identity Service...

The next paragraph says:

Although CJA does not yet integrate with the Co-op or Private identity graphs...

Trevor Paulsen in product management confirmed that Cross-Device Analytics does not, in any way, work with AEP (see conversation below). Please ask the author to re-research this paragraph and to update accordingly.

Thanks Jay! This has been addressed. The comparison didn't quite make sense, so I adjusted it to talk about CDA vs CCA, and moved it to the CCA FAQ. The content was also adjusted to be accurate.


Add info about TaskContext to readme

[Current coverage][cc-pull] is 97.63%

Merging [#14][cc-pull] into [master][cc-base-branch] will not change coverage

@@             master        #14   diff @@
==========================================
  Files            10         10
  Lines           379        379
  Methods           0          0
  Messages          0          0
  Branches         17         17
==========================================
  Hits            370        370
  Misses            7          7
  Partials          2          2

Powered by Codecov. Last updated by [3bb932c...6fd0b5d][cc-compare]
[cc-base-branch]: https://codecov.io/gh/rouzwawi/flo/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/rouzwawi/flo/compare/3bb932cdaebadc78d27febcd6599a6d22d9c8125...6fd0b5d0d6320669ebd238851c0b2b2f825ca4f4
[cc-pull]: https://codecov.io/gh/rouzwawi/flo/pull/14?src=pr


rsa/*: switch to BN_bn2binpad

Labels mean rather intention to back-port this down to 1.0.2 than actual cherry-pick-ability. Open question is if one should make RSA_padding_check_SSLv23 and RSA_padding_check_X931 constant-time. They are not actually called. Not during make test. On related note one can even wonder if any of *_padding_check functions should be exported...

Ping @ekasper, because it removes some of your TODOs.

Red cross from Travis is unrelated.

Ping.

@dot-asm: Ping

Still have my approval, @dot-asm, if you want to merge.

There is still one unresolved non-comment/style issue. The change in crypto/rsa/rsa_x931.c shouldn't be here. (And, as Kurt pointed out, the function code is wrong, but the entire check is unnecessary.)
Though, yeah, otherwise the PR looks fine to merge.

Ping?

@dot-asm: ping

Removed the "ready" label because it isn't, there are unanswered issues.

@dot-asm: Ping

This is not just a 1.1.1 issue (it had the goal of backporting to 1.0.2) so I am removing that milestone.  @dot-asm , what's the state of this?

Re-based, feedback addressed, red cross from travis [should be] resolved.

Just in case it wasn't clear. There were code changes (removal of copy-paste artefact in rsa_x931.c), so it needs re-approval.

This didn't cherry-pick to 1.0.2, so there will be separate request for it.


ZABAPGIT_FORMS: Remove obsolete methods

Remove branch_popup
Remove package_popup

They are not being used anymore.

Oo..Any suggestion how to find that within SE80 or Eclipse? Seems like Eclipse wasn't able to find it and Code Scanner can't search within temporary packages :(

Well, that's why there was a comment in the code ;-)

Ok, right..^^ Well, package_popup isn't being used anymore, so one at last to remove.. :)

Yes. You can remove ZCL_ABAPGIT_POPUPS/ZIF_ABAPGIT_POPUPS~PACKAGE_POPUP_CALLBACK and reference in ZCL_ABAPGIT_UI_INJECTOR too.

thanks 👍


Docker file + both clients update

What was the issue

When building Docker image from Docker file, the following error was prompt:
 error: command 'gcc' failed: No such file or directory

 Failed to build backports.zoneinfo

 ERROR: Could not build wheels for backports.zoneinfo, which is required to install pyproject.toml-based projects

Import of supporting functions in tutorial notebook fails:
   NoRegionError
   --> 142     lambda_client: boto3.client("lambda"), payload: bytes, lambda_function: str

Initialising ECR client in tutorial notebook fails:
    NoRegionError
    ----> 2 ecr = boto3.client("ecr")

Anaconda install of grater fails: No package to be downloaded from any channel in anaconda.org

What are the fixes

Added the following line to Dockerfile:
RUN yum install gcc -y

Avoid initialising lambda client in invoke_lambda function: It is my understanding best practices would want us to pass the client already initialised to the function, as we do, so I wouldn't see the need to add complexity dynamically referencing the region here.  Feel free to discuss any opinion on this point!

Added region to client initialisation in tutorial notebook:
 ecr = boto3.client("ecr", region_name= test_config.region)

Remove references to anaconda installs in tutorials/readme

Notes
Given that dev is behind main, target branch for this PR is main. To be discussed if we want to follow proper strategy and sync dev first.

Can you please increment the version number of grater?


metrics(ticdc): correct MySQL worker load legendFormat

What problem does this PR solve?

Issue Number: close https://github.com/pingcap/tiflow/issues/5644
What is changed and how it works?
correct MySQL worker load legendFormat.
row/s -> txn/m
Check List
Tests

No code

Questions
Will it cause performance regression or break compatibility?
No
Do you need to update user documentation, design documentation or monitoring documentation?
No
Release note
None

/check-issue-triage-complete

Codecov Report

Merging #5645 (26d63f3) into master (fcea4d5) will increase coverage by 0.2769%.
The diff coverage is 59.5103%.

Flag
Coverage Δ

cdc
61.9864% <62.2047%> (+0.8383%)
:arrow_up:

dm
52.0081% <48.9164%> (-0.0346%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.
@@               Coverage Diff                @@
##             master      #5645        +/-   ##
================================================
+ Coverage   56.0768%   56.3538%   +0.2769%
================================================
  Files           535        526         -9
  Lines         70143      69470       -673
================================================
- Hits          39334      39149       -185
+ Misses        27078      26603       -475
+ Partials       3731       3718        -13

/merge


Update concept-identity-protection-risks.md

Based on CX feedback on some IDP cases, it was questioned the difference between those 2 fields: Time detection and Detection Last Updated

@MicrosoftGuyJFlo
Can you review the proposed changes?
Important: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

#sign-off


Support external CRDB in storage engine

Is your feature request related to a problem? Please describe.
The current in-memory storage engine is tied to an in-memory deployment of CRDB. We should also support connecting to an external database so we can properly deploy IM-STS.
Describe the solution you'd like
IM-STS should be configurable such that it can use an external database as its storage engine. This should also be part of the Helm chart.
Describe alternatives you've considered
None.
Additional context
None.

Fixing this issue should also involve migrating to SQLBoiler and Goose for DB management.

@jnschaeffer I understand the Goose migration that's needed. But is SQLBoiler really needed for the external CRDB? I'd say the focus should go on working on the MVP.

@JAORMX Apologies for not responding to this earlier; for posterity, we decided to go ahead with just using Goose for now rather than refactor our storage code since it does work for now.

This work has been completed and added to the Helm chart as of #92.