Edit pass: mixed-reality articles

Please see https://github.com/MicrosoftDocs/mixed-reality/pull/1918#issuecomment-562290559.

Edit pass in progress. Please don’t review yet.

Docs Build status updates of commit dc2fd2f:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

mixed-reality-docs/case-study-spatial-sound-design-for-holotour.md
:white_check_mark:Succeeded
View

mixed-reality-docs/directx-development-overview.md
:white_check_mark:Succeeded
View

mixed-reality-docs/spatial-sound-design.md
:white_check_mark:Succeeded
View

mixed-reality-docs/spatial-sound-in-unity.md
:white_check_mark:Succeeded
View

mixed-reality-docs/spatial-sound.md
:white_check_mark:Succeeded
View

mixed-reality-docs/voice-input-in-directx.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit d44c23b:
:warning: Validation status: warnings

File
Status
Preview URL
Details

mixed-reality-docs/TOC.md
:warning:Warning
View
Details

mixed-reality-docs/directx-development-overview.md
:warning:Warning
View
Details

mixed-reality-docs/case-study-spatial-sound-design-for-holotour.md
:white_check_mark:Succeeded
View

mixed-reality-docs/spatial-sound-design.md
:white_check_mark:Succeeded
View

mixed-reality-docs/spatial-sound-in-unity.md
:white_check_mark:Succeeded
View

mixed-reality-docs/spatial-sound.md
:white_check_mark:Succeeded
View

mixed-reality-docs/voice-input-in-directx.md
:white_check_mark:Succeeded
View

mixed-reality-docs/TOC.md

Line 67: [Warning] Invalid file link: 'color,-light-and-materials.md'.
Line 211: [Warning] Invalid file link: 'keyboard,-mouse,-and-controller-input-in-directx.md'.

mixed-reality-docs/directx-development-overview.md

Line 58: [Warning] Invalid file link: 'keyboard,-mouse,-and-controller-input-in-directx.md'.

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit 534e204:
:warning: Validation status: warnings

File
Status
Preview URL
Details

mixed-reality-docs/directx-development-overview.md
:warning:Warning
View
Details

mixed-reality-docs/TOC.md
:white_check_mark:Succeeded
View

mixed-reality-docs/case-study-spatial-sound-design-for-holotour.md
:white_check_mark:Succeeded
View

mixed-reality-docs/spatial-sound-design.md
:white_check_mark:Succeeded
View

mixed-reality-docs/spatial-sound-in-unity.md
:white_check_mark:Succeeded
View

mixed-reality-docs/spatial-sound.md
:white_check_mark:Succeeded
View

mixed-reality-docs/voice-input-in-directx.md
:white_check_mark:Succeeded
View

mixed-reality-docs/directx-development-overview.md

Line 58: [Warning] Invalid file link: 'keyboard,-mouse,-and-controller-input-in-directx.md'.

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit 816c745:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

mixed-reality-docs/TOC.md
:white_check_mark:Succeeded
View

mixed-reality-docs/case-study-spatial-sound-design-for-holotour.md
:white_check_mark:Succeeded
View

mixed-reality-docs/directx-development-overview.md
:white_check_mark:Succeeded
View

mixed-reality-docs/spatial-sound-design.md
:white_check_mark:Succeeded
View

mixed-reality-docs/spatial-sound-in-unity.md
:white_check_mark:Succeeded
View

mixed-reality-docs/spatial-sound.md
:white_check_mark:Succeeded
View

mixed-reality-docs/voice-input-in-directx.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit f450209:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

mixed-reality-docs/TOC.md
:white_check_mark:Succeeded
View

mixed-reality-docs/case-study-spatial-sound-design-for-holotour.md
:white_check_mark:Succeeded
View

mixed-reality-docs/directx-development-overview.md
:white_check_mark:Succeeded
View

mixed-reality-docs/spatial-sound-design.md
:white_check_mark:Succeeded
View

mixed-reality-docs/spatial-sound-in-unity.md
:white_check_mark:Succeeded
View

mixed-reality-docs/spatial-sound.md
:white_check_mark:Succeeded
View

mixed-reality-docs/voice-input-in-directx.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit e22e581:
:clock10: Pending: waiting for processors (12 builds ahead of you)
:warning: Docs Build is busy, currently there are 12 builds ahead of this one, for more information you can view the Build queue graph on the Docs Portal.

Docs Build status updates of commit e22e581:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

mixed-reality-docs/TOC.md
:white_check_mark:Succeeded
View

mixed-reality-docs/case-study-spatial-sound-design-for-holotour.md
:white_check_mark:Succeeded
View

mixed-reality-docs/directx-development-overview.md
:white_check_mark:Succeeded
View

mixed-reality-docs/spatial-sound-design.md
:white_check_mark:Succeeded
View

mixed-reality-docs/spatial-sound-in-unity.md
:white_check_mark:Succeeded
View

mixed-reality-docs/spatial-sound.md
:white_check_mark:Succeeded
View

mixed-reality-docs/voice-input-in-directx.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit ab39baf:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

mixed-reality-docs/TOC.md
:white_check_mark:Succeeded
View

mixed-reality-docs/case-study-spatial-sound-design-for-holotour.md
:white_check_mark:Succeeded
View

mixed-reality-docs/directx-development-overview.md
:white_check_mark:Succeeded
View

mixed-reality-docs/spatial-sound-design.md
:white_check_mark:Succeeded
View

mixed-reality-docs/spatial-sound-in-unity.md
:white_check_mark:Succeeded
View

mixed-reality-docs/spatial-sound.md
:white_check_mark:Succeeded
View

mixed-reality-docs/voice-input-in-directx.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit 6a6e780:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

mixed-reality-docs/TOC.md
:white_check_mark:Succeeded
View

mixed-reality-docs/case-study-spatial-sound-design-for-holotour.md
:white_check_mark:Succeeded
View

mixed-reality-docs/directx-development-overview.md
:white_check_mark:Succeeded
View

mixed-reality-docs/spatial-sound-design.md
:white_check_mark:Succeeded
View

mixed-reality-docs/spatial-sound-in-unity.md
:white_check_mark:Succeeded
View

mixed-reality-docs/spatial-sound.md
:white_check_mark:Succeeded
View

mixed-reality-docs/voice-input-in-directx.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit 9fbefcf:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

mixed-reality-docs/TOC.md
:white_check_mark:Succeeded
View

mixed-reality-docs/case-study-spatial-sound-design-for-holotour.md
:white_check_mark:Succeeded
View

mixed-reality-docs/directx-development-overview.md
:white_check_mark:Succeeded
View

mixed-reality-docs/spatial-sound-design.md
:white_check_mark:Succeeded
View

mixed-reality-docs/spatial-sound-in-unity.md
:white_check_mark:Succeeded
View

mixed-reality-docs/spatial-sound.md
:white_check_mark:Succeeded
View

mixed-reality-docs/voice-input-in-directx.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Hi @NoelCross, @kegodin – Please review the copy edit to these articles, address the following questions, and let me know if I’ve changed the technical meaning anywhere. This is for Azure DevOps work request 1592807.
Comments:
From case-study-spacial-sound-design-for-holotour.md:

DOCs articles are not supposed to have bylines. Do we have to retain the info about Jason Syltebo?
What is “beats” here? This seems like too casual/slang.
The journey though HoloTour contains certain beats where your tour guide, aided by holograms, explores a topic in-depth.…

From spacial-sound.md

Articles are supposed to get a "Next steps" section at the end. Can you suggest "Next Steps" for this article?

Fromn input-in-directx.md

I’m not sure what this means exactly or how to make it clear; can you help revise?
Make use of the data however applicable to your app scenario.

From spacial-sound-design.md

The example .wav sounds don't play from the links. Do you have to download them? If so, is there a better/more convenient way to present them?

From voice-input-in-directx.md

Those “try” instances in the upper-left corner of a couple of the code blocks look odd to me. Do they belong there?

I had to shorten the following subheads, as H2s are supposed to not wrap to 3 lines in the on-page TOC. This was a bit awkward—if you have better ideas, or a way to shorten the first one further, let me know:

Use SpeechRecognizer for continuous recognition of voice commands -> Use SpeechRecognizer for continuous speech recognition
Use dictation for one-shot recognition of speech phrases and sentences -> Use dictation for phrase recognition

TOC matters

case-study-spatial-sound-design-for-holotour.md lacks a TOC entry. Can you provide one and show where it should go?
directx-development-overview - The TOC item is “Native development overview”—is that correct?

Thanks, jeff b

Hi @jborsecnik
Thanks for the review! Here are replies to your questions:
From case-study-spacial-sound-design-for-holotour.md:

DOCs articles are not supposed to have bylines. Do we have to retain the info about Jason Syltebo?
No, we can remove the byline. Could you also remove the byline from case-study-using-spatial-sound-in-roboraid.md?
What is “beats” here? This seems like too casual/slang.
It's jargon in the storytelling industries (movies, tv, video games).

From spacial-sound.md

Articles are supposed to get a "Next steps" section at the end. Can you suggest "Next Steps" for this article?
You could link to spatial-sound-in-unity.md and spatial-sound-design.md

From input-in-directx.md
-I’m not sure what this means exactly or how to make it clear; can you help revise?

"Make use of the data however applicable to your app scenario."
The sentence looks redundant. I suggest removing it.

From spacial-sound-design.md

The example .wav sounds don't play from the links. Do you have to download them? If so, is there a better/more convenient way to present them?
The user has to download them. Unfortunately the doc site has a video player (https://docs.microsoft.com/en-us/contribute/markdown-reference#videos) but not an audio player. I haven't been able to find any other examples of audio on the docs site.

From voice-input-in-directx.md

Those “try” instances in the upper-left corner of a couple of the code blocks look odd to me. Do they belong there?

The 'try' keyword is valid syntax here. It looks strange because it's not indented like the line that follows it. They should be indented the same amount as the following line, but looking at all blocks on that page it seems they've enforced a style where the first line of a code block isn't indented.

I had to shorten the following subheads, as H2s are supposed to not wrap to 3 lines in the on-page TOC. This was a bit awkward—if you have better ideas, or a way to shorten the first one further, let me know:

Use SpeechRecognizer for continuous recognition of voice commands -> Use SpeechRecognizer for continuous speech recognition
It could be shortened to 'Continuous recognition'
Use dictation for one-shot recognition of speech phrases and sentences -> Use dictation for phrase recognition
It could be shortened to 'One-shot recognition'

TOC matters

case-study-spatial-sound-design-for-holotour.md lacks a TOC entry. Can you provide one and show where it should go?
Under Design -> UX Elements -> Style replace 'Spatial sound design' with a TOC subsection called 'Spatial sound', and move spatial-sound-design.md under it, and put the holotour and roboraid case studies under it.

directx-development-overview - The TOC item is “Native development overview”—is that correct?
_It's under a TOC subsection called 'native', so the H1 on this page should be changed from 'Directx development overview' to 'Native development overview'.

Docs Build status updates of commit b697fa4:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

mixed-reality-docs/TOC.md
:white_check_mark:Succeeded
View

mixed-reality-docs/case-study-spatial-sound-design-for-holotour.md
:white_check_mark:Succeeded
View

mixed-reality-docs/directx-development-overview.md
:white_check_mark:Succeeded
View

mixed-reality-docs/spatial-sound-design.md
:white_check_mark:Succeeded
View

mixed-reality-docs/spatial-sound-in-unity.md
:white_check_mark:Succeeded
View

mixed-reality-docs/spatial-sound.md
:white_check_mark:Succeeded
View

mixed-reality-docs/voice-input-in-directx.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@kegodin, in removing the byline/author info from case-study-using-spatial-sound-in-roboraid.md (three instances), as you requested, I noticed that this link is not working:
(For more information about creating an audio asset with the Doppler effect built in, see 100 Whooshes in 2 Minutes.)

@jborsecnik Nice find. Here's an updated link: http://designingsound.org/2010/02/26/charles-deenen-special-100-whooshes-in-2-minutes/

Docs Build status updates of commit d391f57:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

mixed-reality-docs/TOC.md
:white_check_mark:Succeeded
View

mixed-reality-docs/case-study-spatial-sound-design-for-holotour.md
:white_check_mark:Succeeded
View

mixed-reality-docs/case-study-using-spatial-sound-in-roboraid.md
:white_check_mark:Succeeded
View

mixed-reality-docs/directx-development-overview.md
:white_check_mark:Succeeded
View

mixed-reality-docs/spatial-sound-design.md
:white_check_mark:Succeeded
View

mixed-reality-docs/spatial-sound-in-unity.md
:white_check_mark:Succeeded
View

mixed-reality-docs/spatial-sound.md
:white_check_mark:Succeeded
View

mixed-reality-docs/voice-input-in-directx.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit 2dde382:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

mixed-reality-docs/TOC.md
:white_check_mark:Succeeded
View

mixed-reality-docs/case-study-spatial-sound-design-for-holotour.md
:white_check_mark:Succeeded
View

mixed-reality-docs/case-study-using-spatial-sound-in-roboraid.md
:white_check_mark:Succeeded
View

mixed-reality-docs/directx-development-overview.md
:white_check_mark:Succeeded
View

mixed-reality-docs/spatial-sound-design.md
:white_check_mark:Succeeded
View

mixed-reality-docs/spatial-sound-in-unity.md
:white_check_mark:Succeeded
View

mixed-reality-docs/spatial-sound.md
:white_check_mark:Succeeded
View

mixed-reality-docs/voice-input-in-directx.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit 4c6be41:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

mixed-reality-docs/TOC.md
:white_check_mark:Succeeded
View

mixed-reality-docs/case-study-spatial-sound-design-for-holotour.md
:white_check_mark:Succeeded
View

mixed-reality-docs/case-study-using-spatial-sound-in-roboraid.md
:white_check_mark:Succeeded
View

mixed-reality-docs/directx-development-overview.md
:white_check_mark:Succeeded
View

mixed-reality-docs/spatial-sound-design.md
:white_check_mark:Succeeded
View

mixed-reality-docs/spatial-sound-in-unity.md
:white_check_mark:Succeeded
View

mixed-reality-docs/spatial-sound.md
:white_check_mark:Succeeded
View

mixed-reality-docs/voice-input-in-directx.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit 9edd4e3:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

mixed-reality-docs/TOC.md
:white_check_mark:Succeeded
View

mixed-reality-docs/case-study-spatial-sound-design-for-holotour.md
:white_check_mark:Succeeded
View

mixed-reality-docs/case-study-using-spatial-sound-in-roboraid.md
:white_check_mark:Succeeded
View

mixed-reality-docs/directx-development-overview.md
:white_check_mark:Succeeded
View

mixed-reality-docs/spatial-sound-design.md
:white_check_mark:Succeeded
View

mixed-reality-docs/spatial-sound-in-unity.md
:white_check_mark:Succeeded
View

mixed-reality-docs/spatial-sound.md
:white_check_mark:Succeeded
View

mixed-reality-docs/voice-input-in-directx.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit 4432949:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

mixed-reality-docs/TOC.md
:white_check_mark:Succeeded
View

mixed-reality-docs/case-study-spatial-sound-design-for-holotour.md
:white_check_mark:Succeeded
View

mixed-reality-docs/case-study-using-spatial-sound-in-roboraid.md
:white_check_mark:Succeeded
View

mixed-reality-docs/directx-development-overview.md
:white_check_mark:Succeeded
View

mixed-reality-docs/spatial-sound-design.md
:white_check_mark:Succeeded
View

mixed-reality-docs/spatial-sound-in-unity.md
:white_check_mark:Succeeded
View

mixed-reality-docs/spatial-sound.md
:white_check_mark:Succeeded
View

mixed-reality-docs/voice-input-in-directx.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@jessemcculloch Hi Jesse, this PR is ready for merging

#sign-off

Docs Build status updates of commit 1d4ea5b:
:clock10: Pending: waiting for processors (9 builds ahead of you)
:warning: Docs Build is busy, currently there are 9 builds ahead of this one, for more information you can view the Build queue graph on the Docs Portal.

Docs Build status updates of commit 1d4ea5b:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

mixed-reality-docs/TOC.md
:white_check_mark:Succeeded
View

mixed-reality-docs/case-study-spatial-sound-design-for-holotour.md
:white_check_mark:Succeeded
View

mixed-reality-docs/case-study-using-spatial-sound-in-roboraid.md
:white_check_mark:Succeeded
View

mixed-reality-docs/directx-development-overview.md
:white_check_mark:Succeeded
View

mixed-reality-docs/spatial-sound-design.md
:white_check_mark:Succeeded
View

mixed-reality-docs/spatial-sound-in-unity.md
:white_check_mark:Succeeded
View

mixed-reality-docs/spatial-sound.md
:white_check_mark:Succeeded
View

mixed-reality-docs/voice-input-in-directx.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit 7fc47aa:
:clock10: Pending: waiting for processors (9 builds ahead of you)
:warning: Docs Build is busy, currently there are 9 builds ahead of this one, for more information you can view the Build queue graph on the Docs Portal.

Docs Build status updates of commit 7fc47aa:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

mixed-reality-docs/TOC.md
:white_check_mark:Succeeded
View

mixed-reality-docs/case-study-spatial-sound-design-for-holotour.md
:white_check_mark:Succeeded
View

mixed-reality-docs/case-study-using-spatial-sound-in-roboraid.md
:white_check_mark:Succeeded
View

mixed-reality-docs/directx-development-overview.md
:white_check_mark:Succeeded
View

mixed-reality-docs/spatial-sound-design.md
:white_check_mark:Succeeded
View

mixed-reality-docs/spatial-sound-in-unity.md
:white_check_mark:Succeeded
View

mixed-reality-docs/spatial-sound.md
:white_check_mark:Succeeded
View

mixed-reality-docs/voice-input-in-directx.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


[LayoutAnimation] Success callback not firing

See: https://rnplay.org/apps/RabPgA
alert('opened') is never called on completion

+1
Should we expect this one to be merged in any time soon? This is a critical bug which prevents all LayoutAnimation success callback to be called.

@brentvatne the PR from @kujohn seems working on iOS. However we have a serious problem in Android. We don't even pass the success or failed callbacks to any underneath methods from here to here.
Any thoughts on this?

@alinz LayoutAnimation is experimental on Android. Please file any issues you find.


Client-side handling of events

Hi, first off thanks for this hook! It's really simplified passing custom events to my backend.
Do you have any plans to support client-side handling as well? Eg the various phx-* hooks can be passed JS structs which will execute client-side instead of server-side. If I try this with these handlers, Phoenix just errors about not having a handle_event for the various JS pieces (such as add_class).

I'd be happy to look at a PR for it, but it's probably not high on my list to do myself. TBH, the JS structs kinda seemed like the wrong direction to me, I remember how remote JS turned out in Rails :) This is obviously just my opinion, and if there was a way to incorporate this feature that didn't have too much downsides I'd be happy to look at it.

That's fair! I'm working around it for now, but if this bugs me enough I'll take a stab at it. Thanks!


Comet spear is a bit broken

I am hosting an smp with many friends, and after 6 months in we finally discovered the potency of this weapon. I got a few complaint because the guy holding it went 600 blocs in the air before falling back down on the ground, effectively one shooting everyone and everything in our main community town, at spawn.
So I was wondering : is it possible to add the possibility in the configs to cap the damage, range and knockback of the item, to a certain degree, to balance the weapon a bit ? Because it's not possible to do yet...

I was having this same issue on my server so I made a fork that added a bunch of configuration, including changing scalars on the comet spear. Was just merged to this branch and should be available in the next update, whenever that's released.

For the next update I've added more config options for Calculated Fall and Ground Detonation events for all the weapons, namely:

Cap on expansion
Cap on damage
Base expansion
Expansion modifier
Bonus damage from fall distance modifier
Boolean for whether damage should heal the player
Healing modifier based on damage dealt

Hope this helps.


Link OfflineUX.md in Onyx.update method

Coming from this comment. We should add a link to OfflineUX.md in the JSDocs of Onyx.update, once OfflineUX.md is created.

Not sure why this is still open when the PR was merge back in May. Closing!


Remove caching in network mode for now

sync with system-transparency/system-transparency

Wasn't this done by #52?


How you are doing data augmentation?

Hi Maudzung,
Thank you for your great work. But I just need to know how you are doing data augmentation and where?
Could you please give me the hyperlink to data augmentation in your implementation?
I tried to find data augmentation, but I could not make it.
Thanks in advance

It was applied here. For more information, please take a look at this file


[ElasticDump does not have a way to sign a execution from an AWS ECS task ]

Is your feature request related to a problem? Please describe.
Like requests module in python , elasticdump does not have a way to pass the authentication parameter.
This is restricting its usage. In my work scenario, we have a solution in AWS cloud. We are using  the esdump through an  ECS task. The task role already has permissions to access the elasticsearch service. But the Elasticsearch has role based IAM policies. In order to ensure elasticdump can talk to the elasticsearch service , we need to pass the authentication in the call.
Describe the solution you'd like
Elasticdump giving us a permission to pass the aws role based authentication.
Describe alternatives you've considered
We went live with the project when our elasticsearch service was a public endpoint. Thats why ESDump was working perfectly. Ever since we have put this exception , esdump has ceased to work. So, currently, we are looking at going away from esdump utility and have an alternate design.
Give some examples of implementations
Already gave above.
Additional context
Our AWS Elasticsearch service is still a public endpoint , with AWS IAM role permissions. We tried IP based IAM policies as well but our AWS ECS task is on a fargate cluster. That means the subnet ips are private ips. Looks like AWS allows private ips to be put in IAM policy of a ES service if the ES service is on private network as well ( VPC ) . We were not able to use this solution as well.

Understood, it should be possible to implement this via the aws-sdk that’s used underneath, but I don’t use AWS or have access to any instance.
If your submit a PR I’ll gladly merge it or you can fork ESDump and implement these changes to fit your needs.

duplicate of  #711

Understood, it should be possible to implement this via the aws-sdk that’s used underneath, but I don’t use AWS or have access to any instance.
If your submit a PR I’ll gladly merge it or you can fork ESDump and implement these changes to fit your needs.

Thanks for the reply. From your documentation, I see this piece :
--awsAccessKeyId
--awsSecretAccessKey
When using Amazon Elasticsearch Service protected by
AWS Identity and Access Management (IAM), provide
your Access Key ID and Secret Access Key.
--sessionToken can also be optionally provided if using temporary credentials
This is exactly what I was looking for. Does this mean this has already been taken care of? If yes, can I pass on frozen credentials in awsAccessKeyId and awsSecretAccessKey?

👍🏾

Just to let you guys know, those options worked with frozen credentials from boto3. Thanks! Session token is not optional in that case, we need to pass explicitly ( we get it from frozen credentials too ) . May be it is a good idea to put it in readme as it is mentioned as optional.


menu mobile not working

Hi,
thank you for sending me the link to your angularJS-startbootstrap-modern-business-version.
The slider works! Fine!
Do you have an idea why your mobile-menue doesn't work?
Thank you. With best regards
Tim

Hi Tim,
Please look this now. I fixed that mobile menu issue. Thanks

Thank you. It works! :)


Add component scanning to external beans XML which can be overridden

test-context.xml needs to be updated too, I presume.

@sjcorbett thanks, comments addressed


Quick View button margin glitch in wishlist

Bug report
Issue Description
The margin of quick view button in wishlist page is not at the center of the image, rather it is coming at the bottom of it.
Preconditions
1. Bagisto 1.2.0

Steps to reproduce
1.Add a product to wishlist.
2.Go to wishlist and hover over the product image.

Expected result
The quick view button should come into the center of the product image irrespective of the image size.
Actual result

The 'Quick View Icon' already aligned to the div just 5 to 10 px above. The thing is image is auto-adjusted inside div. I didn't think this is an issue. Unless and until the quick view icon position changed on increasing or decreasing the window width.


packaging and dependencies of features and step_definitions

Summary
I would like to be able to package and reuse features and step definitions. I have multiple projects that have common functionnalities.
Is there a possibility to package groups of features and step definitions and create dependencies between these packages to avoid rewriting everything with every project ?
If we take a look at inspec profiles for instance, we can reuse previous definitions easily.
Expected Behavior
Given a new project
When a similar functionnality than another project is tested
Then download the features/step_definitions package from the other project and reuse it here
Current Behavior
AFAIK, there is no packaging and dependencies sytem in cucumber.

Context & Motivation
I want to greatly simplify maintaining features, step definitions and scenarios by spliting them in small structures and heavily reuse these structures.

You can use the --require switch on the command-line to load step definitions from a Ruby file, which could be in a gem.
See, for example, the aruba gem which bundles step definitions for testing command-line apps.

Thanks. Does it also work with features files ? Is there a possibility to have a meta features file that can load specific features scenarios from a sort of features library (bundled in a gem)?

Yes it's worth pointing out that a step file (Written in ruby), is just a series of commands which get loaded into your cucumber runtime and then converted. So if you had a gem for example which had a file which had 2 Given steps, then requiring that gem would allow you to use those common given steps.
Matt linked to some good examples. Here is a bit more detail.
Feature in cucumber-ruby
https://github.com/cucumber/cucumber-ruby/blob/master/features/docs/exception_in_after_hook.feature#L26-L35
Consuming this step in aruba
https://github.com/cucumber/aruba/blob/master/lib/aruba/cucumber/file.rb#L23-L25

Right for the steps but for features themselves ? In fact, this issue is related to https://github.com/cucumber/cucumber-ruby/issues/1076 and https://github.com/cucumber/cucumber-ruby/issues/821

Is the suites system implemented ?

Suites were not implemented, yet, no. They're still a great idea but we're waiting for them to work their way up the team's priorities.

Ok. This issue describes exactly what I am looking for https://github.com/cucumber/cucumber-ruby/issues/1109

Re-running features as described there I'd do in a ruby block, and run the features with whatever additional env vars / params are needed. Something like this pseudo-code
['var1', 'var2', 'var3'].each do |var|
  bundle exec cucumber MYVAR=var
end

Hum... I think I will create a quick gem that download remote cucumber projects in tar.gz, unpack them, merge them and create a new cucumber project with all features together. A bit like Inspec does with profile dependencies.
That way, I can easily call this tar.gz in my project to test.

Question :

How do you store your features files ? In the same git as your project ?
How do you call them ? By a git clone ?

@micheelengronne do you mean in cucumber-ruby, if so they don't exist, they're created dynamically on the fly.

No, in general. When you created a features folder with cucumber -init, how do you distribute it ? Via git only ? Is there a norm to package it ?


Installer failed to enable etcd2.service for CoreOS

I happened to try Panamax out on a standalone CoreOS and I noticed after reboot the UI will report "fleet server unable to communicate with etcd" which is because etcd2.service is not enabled at all.

Wrong place for this issue. Closing.


Incorrect unmatched label introduced in switch statement in loop

I was trying to decompile spring-boot (spring-core-6.0.4.jar), using Quiltflower 1.9.0 and default settings, and got an incorrect parsing of spring-core-6.0.4\org\springframework\asm\ClassReader.java.
The decompiler added a "break label3;" on row 1221 and 1230, but with no label declared on the actual while loop in row 1006. Looking at the original source code I saw there was no label there, and that it also would not be needed to break the loop so not sure how it sneaked in.
I tried to look if this was covered in a previous issue but could not find anything. I also only used the latest binary downloadable here, not building the decompiler myself using the latest sourcecode.

This issue has been tracked internally, but there was no issue filed. Thanks for this, will look into!

Closing as it's been fixed.


Renovate automerge safe dependencies

Start research and work on Renovate automerging.  Ideas:

maven bumps
:automergeMinor
:automergePatch
:automergeTypes
:automergeLinters

https://docs.renovatebot.com/presets-default/#automergeall

Automerge for node dev dependencies only.  E.g.
https://github.com/renovatebot/renovate/issues/1342#issuecomment-798823378


Add liquidity deposit/withdrawal to admin api

Have CreateDeposit and CreatWithdrawal accept either an account id or asset

Replaced by #126 #127


Doc: CI deploys a broken doc site build

Hello,
Today when I have visited: http://technologyadvice.github.io/stardust/
I get:
app.eb3d830….js:23:  Uncaught Error: Minified exception occurred; use the non-minified dev environment for the full error message and additional helpful warnings.

Indeed, fixing.

It's up now.  Unfortunately, I can't see what went wrong here.  It runs locally and the CI logs appear OK.  Thanks for the report.

This is a confirmed recurring issue with CI.  Every deploy seems to break the doc site.  Local deployments work. So, reopening until the CI issue is resolved.

The dependency update recently merged was at fault.  history v3 is not compatible with the react-router.  Rolling this back fixed all issues.

Thank you :)


Virustotal detections

Any idea why the installer would be flagged under Virustotal?
https://www.virustotal.com/gui/file/07e7feafe71b47e5ceab19a4fb0d4421337f4d85ef3d4e413c6ca1e3b80efea0/detection
Only two, but still, two..

I have 3 warnings with development build
https://www.virustotal.com/gui/file/b297fb0f62446b4bf048a3c57bc6a8c0ab2277b6b2d3f2f429d89facacacb445 but no issues with Release 1.3.0 (https://github.com/Murmele/Gittyup/releases/tag/gittyup_v1.3.0)


getting errors for multiple pods errors

Hi guys, I have tried your app but I am unable to compile as I am getting multiple error on the code I cloned
I have latest Xcode (12.2) but i do get multiple errors on the base code, i did followed the instructions before building. see the screenshots

However as I have some experience in iOS development i did update some pods to their latest version, removed derived data, updated pods repo and clean build the code and I am down to these 7 errors which I am unable to get rid of

Any help from you guys is much appreciated

It appears that some libraries used in the project are not compatible with the latest version of Xcode/iOS SDK. Unfortunately I don't have a macOS machine around me to mess with this project but I do recommend commenting out all lines using those libraries or replacing them with more up-to-date alternatives. That shouldn't be a lot of work.

Thank you for your response, I've managed to fix the issues but I am unable to test this because the app registration isn't working so is there any way you can provide me some demo credentials which I can login through and have a look at it, it would be nice to test it with your demo server... looking forward to it

Actually the server application's source code has always been available here. You can create a local server and test things out for yourself. Don't forget to modify API endpoint url in constants file in iOS app.


Hot Reload not working when publishing contracts

After publishing contracts the app is supposed to reload the page and is currently not doing that.

Reloading of the live 3000 page after editing the solidity doc is not working. I have to deploy each time to see changes made.

Hot reload only works with changes to the javascript files in packages/react-app/src/ folder


[SPARK-18042][SQL] OutputWriter should expose file path written

What changes were proposed in this pull request?
This patch adds a new "path" method on OutputWriter that returns the path of the file written by the OutputWriter. This is part of the necessary work to consolidate structured streaming and batch write paths.
The batch write path has a nice feature that each data source can define the extension of the files, and allow Spark to specify the staging directory and the prefix for the files. However, in the streaming path we need to collect the list of files written, and there is no interface right now to do that.
How was this patch tested?
N/A - there is no behavior change and this should be covered by existing tests.

cc @hvanhovell @cloud-fan
and @ericl

Test build #67330 has started for PR 15580 at commit 1942361.

Test build #67330 has finished for PR 15580 at commit 1942361.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67330/
Test PASSed.

cc @HyukjinKwon

Test build #67344 has started for PR 15580 at commit d3ddaf7.

Test build #67344 has finished for PR 15580 at commit d3ddaf7.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67344/
Test PASSed.

Merged build finished. Test PASSed.

Thanks - I'm going to merge this. I will address the doc and naming comment in the next pr in this series.

@rxin BTW, could I please ask to include https://github.com/apache/spark/pull/14529 in your future related PRs? I will close if you will.

@HyukjinKwon sure.


automatic sign language recognition.

I'm trying to do sign language recognition in running time so I'm wondering if this model the right choice to take here, and I'm wonder what kind of GPUs are necessary to train such a model.
thanks.

If you don't have multiple gpu's it may be better to finetune a kinetics pre-trained model. A P100 or V100 may be enough for quick finetuning if your sign language dataset is not too big.
Regarding whether the model is the right choice, being a 3d convnet it is a more natural fit for offline processing (it processes the time dimension in parallel, similar to the space dimensions).
If you want to do real time processing you either need to break the incoming video into temporal chunks and pass these through the model, or will have to convert the model graph such that it processes frame by frame but keeps internal state of previous activations (e.g. see https://arxiv.org/abs/1806.03863).

thank you for the response... I want to know what is the fps for offline processing video or how much time will take it to proccess 2 sec video for example?


lqrrt paper

Hello Jason Nezvadovitz:
You project is awesome, and can you tell me which papers or algorithm you used in this project?
LQR-RRTstar?

@CxyCH
It has the functionality to work almost as what the LQR-RRTstar paper describes, just without the "star" part (that is, without the "rewire" step). I used to have the rewire step too but it slowed down tree growth so much (Python isn't too fast...) that I decided to abandon that step for my real-time applications. You'll notice that one of the open Issues here is to re-implement "star" (rewiring) in an effective way. Unfortunately, I probably won't get around to that as I am caught up with other work. Thanks for checking this out though! You may also notice that many of my demos use a constant cost-to-go matrix for LQRSteer, which effectively reduces them to using the most basic form of kinodynamic RRT. Again, the reason for this was because solving a Riccati equation every iteration was too slow for my applications.


Make it work on VisionOS simulator

Enable shader compilation.
Not sure if everything is ok on VisionOS device.
Need to be reviewed before.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


feat: ESM package

:tada: This PR is included in version 6.1.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Include namespaces in erasured data

Namespaces are currently left out when computing the extended datasquare. This becomes problematic when retrieving block data and we need to repair the underlying data square, as the namespaces are not preserved. To fix this, we should include the namespaces in the erasure data, along with adding some logic to use the appropriate namespace depending on which quadrant is being used.
spec ref: #145

the plan was for lazyledger-core to use the nmt wrapper (#238) to generate roots for lazyledger-core, but now it's clear that the wrapper won't actually work for an extended data square. This is due to the fact that the wrapper has to know which row or column is being pushed in order to perform logic as to which namespace should be used. semi related comment Without this functionality, we cannot repair the data square, and therefore #235 and #232 are blocked. :eyes:
Extra details as to why the wrapper won't work
Using the wrapper's current construction, it only works for rows and cols that start in Q0 of the extended data square. As soon as a row or col that starts in one of the other quadrants is pushed, the wrapper has no way of knowing that it should use the parity namespace for all leaves pushed. Without this information, the wrapper ends up using incorrect namespaces, and the underlying nmt tree panics.
Options

modify the rsmt2d.Tree interface to indicate to the underlying tree which row or col is being pushed
Use a different interface, possibly something similar to this and pass that to rsmt2d.RepairExtendedDataSquare
Create an external version of rsmt2d.RepairExtendedDataSquare that doesn't require rsmt2d.Tree

(1) will likely require the smallest number of changes
(2) more changes, but we already have code written for it
(3) modest amount of changes, but all modifications will stay in lazyleder-core
ref #10
this decision will also effect #172

Just noting that we kinda already went down the route of (3) when computing the row and column roots.
I'm inclined to favor (3) simply because it feels like we are tried to work around the shortcomings of rsmt2d for quite a while already. Rsmt2d is simply not written in a way that has lazyledger as the main use-case in mind. My gut feeling is that we might run into yet another trap with (1) and (2):
(1) might require additional changes and (2) is a beautiful but very abstract and general approach while we should aim for the simplest possible right now.
(3) can be seen as the simplest way to test out what concrete interfaces will be needed for rsmt2d (lazyledger/rsmt2d#12) and to fully understand what route to go down later (e.g. either (1) or (2) or something else even) without any risks. Also, we can clean up the code at the same time as we fo about (3).
Either way, I'll try to gather all pros and cons and edit this comment here to list all those later.

(1): modify the rsmt2d.Tree interface to indicate to the underlying tree which row or col is being pushed
Pros

sounds like a simple change and straight-forward change

Cons

(higher) risk that we are overlooking something (compared to other options)

Neutral
(2) Use a different interface, possibly something similar to this, and pass that to rsmt2d.RepairExtendedDataSquare
Pros

API change that enables using the API in other ways
code is already written to a large extent

Cons

further abstracts away the concrete use-case we are trying to tackle here (to quote @evan-forbes: "We might be risking a premature abstraction" (https://github.com/lazyledger/rsmt2d/pull/9#issuecomment-742209422))

Neutral
(3) Create an external version of rsmt2d.RepairExtendedDataSquare that doesn't require rsmt2d.Tree
Pros

full control on API -> no need to think about everything in a broader context, e.g. how else rsmt2d might be used outside of lazyledger-core
could optimize it for this particular use-case here
less of a need to coordinate dependencies across repositories
a chance to clean up the code while at it (https://github.com/lazyledger/rsmt2d/pull/18#discussion_r599919286)
can very clearly inform how the API of rsmt2d should look like (at least from the perspective of lazyledger (lazyledger/rsmt2d#12)

Cons

more work / more time consuming potenially

Neutral

we partly went down that route already; that is certainly not a good reason to favour this but you could argue in favor of consistency one way or the other (consitently use rsmt2d or consistently rip out the parts that we need here)

We've decided to go with option (1) as it hopefully is a very simple change that only requires a few lines of code. If that still poses new issues (e.g. when trying to repair the eds), we will reconsider (2) and (3).


fix: batch-analysis payload missing empty string after parsing

By default, Jackson serialization will ignore empty string.
This PR keeps the empty strings in the sbom after breaking the payload of batch-analysis request.
So that, empty string will be kept as the values for some required properties.
For example: components.externalReferences.url is a required property of CycloneDX sbom.
Empty string should be assigned to the property, when there is no value for it.
If the property is ignored by Jackson serialization when empty string is assigned to it, the sbom will become invalid: CycloneDX Validation error: [$.components[15].externalReferences[0].url: is missing but it is required

You just have to change the ObjectMapperProducer.java and replace NON_EMPTY by NON_NULL The instance injected in all the application is the same.
Please add also a test that supports your change

Changed ObjectMapperProducer instead, and added the test case in batch-sbom.json. Thanks.

/retest

LGTM but don't merge until all checks are green


AssertionError in lambda.EventSourceMapping for version 6.13

What happened?
I'm testing an upgrade of the python pulumi-aws from 5.10 to 6.13 and i'm seeing an AssertionError: Unexpected type. Expected 'list' got '<class 'str'>' that I believe I've narrowed down to uses of aws.lambda_.EventSourceMapping resources (by moving a return statement around to find the resource that causes it to fail), e.g.:
aws.lambda_.EventSourceMapping(
    "queue",
    event_source_arn=queue.arn,
    function_name=lambda_.arn,
    opts=opts,
)

I've verified that queue.arn and lambda_.arn are strings and that the documentation and SDK code both list these parameters as str not list, and this code was working as-is before the upgrade, so I suspect this is a bug.
Example
I'm trying to create a minimal project to reproduce this issue but I haven't been able to, yet. I'll update once I figure it out. For now all I can report is that every occurrence of EventSourceMapping has this problem in my (private) repo.
Output of pulumi about
CLI
Version      3.94.0
Go Version   go1.21.3
Go Compiler  gc

Plugins
NAME        VERSION
aws         6.13.0
aws-native  0.90.0
datadog     4.23.0
python      unknown

Host
OS       darwin
Version  14.1.1
Arch     arm64

This project is written in python: executable='./env/bin/python' version='3.9.16'

Backend
Name           pulumi.com
URL            *removed*
User           *removed*
Organizations  *removed*
Token type     personal

Dependencies:
NAME                     VERSION
blinker                  1.7.0
boltons                  20.2.1
boto3                    1.28.17
datadog-api-client       2.19.0
dnspython                2.4.2
Flask                    2.2.3
hiredis                  2.2.3
inflection               0.5.1
launchdarkly-server-sdk  7.6.1
lxml                     4.9.3
orjson                   3.9.10
pip                      22.3.1
pulumi-aws               6.13.0
pulumi-aws-native        0.90.0
pulumi-datadog           4.23.0
pydantic                 2.5.2
redis                    4.6.0
regret                   0.45.2
retry                    0.9.2
rich                     13.7.0
sentry-sdk               1.38.0
setuptools               69.0.2
tomli                    2.0.1
tomlkit                  0.12.3

Additional context
I was hoping to work around this using aws-native's version of this resource but I ran into this instead: https://github.com/pulumi/pulumi-aws-native/issues/1038. This is preventing me from upgrading
Contributing
Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).

Per @t0yv0 this may be related to #3075

Thank you for reporting @chrispyduck, looks like the issue in the native provider has a workaround - https://github.com/pulumi/pulumi-aws-native/issues/1038#issuecomment-1681238307 - did you try that? It might be the quickest way to unblocking your use case.

Getting another report of this stack trace from a customer. Not yet certain which resource.

Got a repro:
import pulumi
import pulumi_aws as aws
import pulumi_archive as archive

assume_role = aws.iam.get_policy_document(
    statements=[
        aws.iam.GetPolicyDocumentStatementArgs(
            effect="Allow",
            principals=[
                aws.iam.GetPolicyDocumentStatementPrincipalArgs(
                    type="Service",
                    identifiers=["lambda.amazonaws.com"],
                )
            ],
            actions=["sts:AssumeRole"],
        )
    ]
)
iam_for_lambda = aws.iam.Role(
    "iamForLambda",
    assume_role_policy=assume_role.json,
    managed_policy_arns=["arn:aws:iam::aws:policy/AmazonSQSFullAccess"],
)
lambda_ = archive.get_file(
    type="zip", source_file="lambda.js", output_path="lambda_function_payload.zip"
)
test_lambda = aws.lambda_.Function(
    "testLambda",
    code=pulumi.FileArchive("lambda_function_payload.zip"),
    role=iam_for_lambda.arn,
    handler="index.test",
    runtime="nodejs18.x",
)

queue = aws.sqs.Queue("queue")

esm = aws.lambda_.EventSourceMapping(
    "example", event_source_arn=queue.arn, function_name=test_lambda.arn
)

steps:

pulumi up with pulumi-aws version 5.42.0.
pulumi up with pulumi-aws version 6.13.1.
Observe failure.

Looks like the schema for the queue parameter for EventSourceMapping changed:
In 5.43.0 it was:
"queues": {
                    "type": "array",
                    "items": {
                        "type": "string"
                    },
                    "description": "The name of the Amazon MQ broker destination queue to consume. Only available for MQ sources. A single queue name must be specified.\n"
                },

And now it is:
"queues": {
                    "type": "string",
                    "description": "The name of the Amazon MQ broker destination queue to consume. Only available for MQ sources. The list must contain exactly one queue name.\n"
                },

I guess it was always meant to have only one parameter but the change of the type is a breaking change. Specifically in the repro above, when we call "/pulumirpc.ResourceMonitor/RegisterResource" for EventSourceMapping, we used to pass "queues": [] but now we pass "queues":null. Passing [] triggers the exception.

I'm wondering if the intent of this change https://github.com/pulumi/pulumi-terraform-bridge/commit/f0a3ffcaf34a05be5484f7b0aaf15e2b77f212b7 is making it worse here, in a sense that the bridge pretends that []->null translation is done implicitly but does not inform the engine..

We are still working on a fix but the issue has a workaround - one can specify a value for queues. For example:
esm = aws.lambda_.EventSourceMapping(
    "example",
    event_source_arn=queue.arn,
    function_name=test_lambda.arn,
    queues="queue",
    opts=pulumi.ResourceOptions(delete_before_replace=True),
)

This will force the resource to update and work around the issue.
NOTE: This will cause a REPLACEMENT of the resource, which could trigger replacements of any resources which depend on it.
Also note that delete_before_replace is needed here.

This was released in v6.13.3


Spurious arithmetic underflow warning when accessing fields of mutable struct

The following code is safe, but flux flags that it may integer underflow:
pub(crate) struct DummyStruct {
    offset: usize,
    index: usize,
}

impl DummyStruct {
    fn set_safe_offset(&mut self) {
        let new_offset = if self.offset <= self.index {
            0
        } else {
            self.offset - self.index
        };
        self.offset = new_offset;
    }
}

fails with:
error[E0999]: arithmetic operation may overflow
   --> src/main.rs:157:13
    |
    |             self.offset - self.index
    |             ^^^^^^^^^^^^^^^^^^^^^^^^

This does not happen if the function takes a immutable parameter. The following code passes:
impl DummyStruct {
    fn get_safe_offset(&self) -> usize {
        if self.offset <= self.index {
            0
        } else {
            self.offset - self.index
        }
    }
}

This a known issue. We call it unfolding of mutable references. The issue is that unfolding only happens "atomically" within an statement so after checking self.offset <= self.index we forget the relationship because the references are folded back. For primitive types the workaround is to read before doing the comparison.
        let a = self.offset;
        let b = self.index;
        let new_offset = if a <= b {
            0
        } else {
            a - b
        };
        self.offset = new_offset;

We've been postponing this for a while, so it may be  time to tackle it. The general case is complicated, but I think it shouldn't be too complicated to handle the example in the op.

Ah, alright. At least there's an easy workaround


add story#add_owner method using owner's API

somehow I couldn't add owner using  self.owners= method, so I add add_owner method using owner's API

add attribute person for Comment model, because it's needed to get person object directly from comment

Coverage decreased (-0.4%) to 95.991% when pulling 01ccd121a7b7b5e0fe365fd6a2c68db5826bf823 on drselump14:master into d0b5962f8486c75ab3f2329c7cdc56d7ae29fbfe on dashofcode:master.

@drselump14 you can add to the array of owner_ids and that will get save with the story is saved. See https://github.com/dashofcode/tracker_api/pull/88/files#diff-7801f5012a085139832e168522bc85dcL55.
You should need to add the new endpoint.
If you want the story.owners= to work you can override and update the owner_ids. Make sure you have the current list of owners or owner_ids so you don't overwrite existing owners.

@forest Thanks for the reply.
I've tried the owner_ids= method before, but sometimes it didn't work as expected. I don't know how to replicate the bug. Maybe that's the reason why they provide API for posting owners.
'You should need to add the new endpoint.'
Could you please explain more about this point please? I think story_owners endpoint is fit with this function.

I'll take a look. If there is a bug with owner_ids it would be good to fix
that. Having multiple ways to do the same this isn't ideal unless there is
good reason.
Your solution might be the right one.
On Mon, Jan 2, 2017 at 6:56 PM Kris<EMAIL_ADDRESS>wrote:

@forest https://github.com/forest Thanks for the reply.
I've tried the owner_ids= method before, but sometimes it didn't work as
expected. I don't know how to replicate the bug. Maybe that's the reason
why they provide API for posting owners.
'You should need to add the new endpoint.'
Could you please explain more about this point please? I think
story_owners endpoint is fit with this function.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/dashofcode/tracker_api/pull/88#issuecomment-270044998,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAAelQ-ClpnQfmLTdV_gmDQ4pQAHODekks5rObjKgaJpZM4LYlBW
.

You're right , i agree with you.
On 01/02 07:29:26 PM, Forest wrote:

I'll take a look. If there is a bug with owner_ids it would be good to fix
that. Having multiple ways to do the same this isn't ideal unless there is
good reason.
Your solution might be the right one.
On Mon, Jan 2, 2017 at 6:56 PM Kris<EMAIL_ADDRESS>wrote:

@forest https://github.com/forest Thanks for the reply.
I've tried the owner_ids= method before, but sometimes it didn't work as
expected. I don't know how to replicate the bug. Maybe that's the reason
why they provide API for posting owners.
'You should need to add the new endpoint.'
Could you please explain more about this point please? I think
story_owners endpoint is fit with this function.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/dashofcode/tracker_api/pull/88#issuecomment-270044998,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAAelQ-ClpnQfmLTdV_gmDQ4pQAHODekks5rObjKgaJpZM4LYlBW
.

--
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
https://github.com/dashofcode/tracker_api/pull/88#issuecomment-270047110

Coverage decreased (-0.4%) to 96.009% when pulling 04c32a6979bf011d7a7912c45b2bd00ce0d4561f on drselump14:master into ac3be0a2e327cfb1d329a9ab449b5eba3b1b2097 on dashofcode:master.

This is not needed. Just use owner_ids=.
story.owner_ids = [123, 456]


feat: Show organisation name in HTML title

Thanks for submitting a PR! Please check the boxes below:

[x] I have run pre-commit to check linting
[x] I have added information to docs/ if required so people know about the feature!
[x] I have filled in the "Changes" section below?
[x] I have filled in the "How did you test this code" section below?
[x] I have used a Conventional Commit title for this Pull Request

Changes
Add the organisation name to the HTML title.
This makes it easier to find URLs to specific organisations by searching for them in browser history, bookmarks, chat/email/etc, since the URLs on their own only have numbers like /sales-dashboard/organisations/4.
There's smarter ways to implement this but it works and YAGNI applies until we need to customise a different page's title.
How did you test this code?
Manually, inspecting HTML titles on different pages.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.93%.  Consider uploading reports for the commit 6b50349 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3814   +/-   ##
=======================================
  Coverage   95.93%   95.93%
=======================================
  Files        1103     1103
  Lines       34801    34801
=======================================
  Hits        33386    33386
  Misses       1415     1415

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Finish helper functions for writing summary email

Will want to add function to find previous date of summary email

Function has been written, waiting to test and debug

Helper functions that exist and are working:

function to read from database to find and return the last 'start' ProcessEvent that occurred
function to get size of directory and remaining free space
Functions I need to test:
function to read from database and return machines and all recent backups


fixed broken link in stalwart mail server

changed the comment of settings subcommand.

Please rebase on master, thanks!

@ofborg eval


Meme Commands Update/Improvements

Randomizer Imrpovements:

Commanders and constructors can no longer end up without a factory for previous/current/next tier, nor without a metal extractor and energy generator. T1/T2 Factories should also always have a constructor.

Hoversonly Improvements/Update

Balance: Commanders no longer copy hover con build lists - available turrets were worth more than building an army
Prepare for commander update and hover rework being integrated from always on modoptions to intergrated into unit stats

Others:

Update removed modoption values

Merging, it will go live with the next release.


Implement Chips Icon

I've started work here but it still needs the new version of mdc.

@YePpHa can we add this in 1.3.6?

@prateekbh sure, I will make a PR when I get home

@YePpHa can you please add the docs page as well with this! so we'll be almost good to publish

@prateekbh sure I will start work on it


test: xfail test_take_over_virtual_interface_then_remove

Mark test_take_over_virtual_interface_then_remove as OK
to fail as current code skip the device deletion when
NM.Device in DEACTIVATING state.
Jira issue created for tracking this issue:
https://nmstate.atlassian.net/browse/NMSTATE-277

Coverage increased (+7.1%) to 82.322% when pulling d9234eb564944ca12117bf6b6b81fbd38e8222c8 on cathay4t:fix_vir_iface_del into 9a7234f99ed5ab09b43b3b8633f6d8b3037458d1 on nmstate:master.

Coverage increased (+7.1%) to 82.322% when pulling d9234eb564944ca12117bf6b6b81fbd38e8222c8 on cathay4t:fix_vir_iface_del into 9a7234f99ed5ab09b43b3b8633f6d8b3037458d1 on nmstate:master.


Any way to set menubar icon colour on macOS...?

On macOS, if we use a black-on-transparent PNG for the the menubar icon then in dark mode we get a white icon and in light mode we get a black icon.
Is there any way to explicitly set the colour of the icon so it is always a fixed colour? I tried just changing the colour in the PNG, but it still comes out black or white.

@jamiebullock you can create light and dark variations and use https://www.electronjs.org/docs/api/native-theme to decide between them. Make sure you do NOT include "Template" in the new file names or they will be treated as templates

@joeflateau Can you please show an example/code?

@dotdotdev no, I do not. But you'd be wiring nativeTheme's updated event and nativeTheme.shouldUseDarkColors to
the Tray#setImage method

@dotdotdev something like this should work. import nativeTheme from electron, then
function getTrayIcon(isDark = nativeTheme.shouldUseDarkColors) {
	// some logic to detirnime what icon to use
	return path.join(__dirname, `assets/icon${isDark ? '-dark' : ''}.png`);
}

const mb = menubar({
	icon: getTrayIcon(),
	... your options
});

mb.on('ready', () => {
  nativeTheme.on('updated', () => mb.tray.setImage(getTrayIcon()));
});


Cloudstack agent running on docker

Thanks for the pull request, testing now :-)

Great, some bugs could still arise since tit is quite a complicated problem. The thing I also still have to try is to put the docker0 bridge as the default to use Private IP Address bridge.
It should be a parameter in:
execute_cmd "add traffictype traffictype=Guest physicalnetworkid=$phy_id"

I think it was something with kvm....=docker0 or something, but the problem was when I did that it wouldn't install, so now I manually move the vnets of the ssvm and cpvm to the docker0 bridge after creation (which is bad).

I just removed the need for the vnet interfaces and moved the communication to the docker0 bridge, fixes some bugs for cloudstack on top of cloudstack

Thanks for the update. I seem to be missing the part where the kvm host is assigned <IP_ADDRESS>

That is normal, I run it on a hypervisor and that machine has that ip allocated, I do not set it in the scripts. There are still some bugs that I am currently working on though

Had a few hickups, mostly because my lab is running Ubuntu, but I see no problem with merging and fixing it


[Improvement] Support properties for Column

What would you like to be improved?
Add column properties to save useful information. In data governance, sometimes we need information about certain fields, such as their privacy level. We can save this information in metadata for better governance operations.
How should we improve?
add Map<String, String> properties to org.apache.gravitino.rel.Column.

@jerryshao @mchades @lw-yang @xloya What do you think about this?

@coolderli can you please elaborate more about your scenario? According to your current description, please can also be achieved by tag in Gravitino.


Preflight check in simulation??

Hello,
I am not sure if the error is related to MAVSDK or to PX4. However, after updating PX4 to the master, I started getting this error during simulation in Gazebo.
[02:30:23|Warn ] command temporarily rejected (400). (mavlink_commands.cpp:172)
[02:30:23|Debug] MAVLink: critical: Preflight Fail: Gyro #0 uncalibrated (system_impl.cpp:257)
[02:30:23|Warn ] command temporarily rejected (400). (mavlink_commands.cpp:172)
[02:30:23|Debug] MAVLink: critical: Preflight Fail: Gyro #0 uncalibrated (system_impl.cpp:257)
[02:30:23|Warn ] command temporarily rejected (400). (mavlink_commands.cpp:172)
[02:30:23|Debug] MAVLink: critical: Preflight Fail: Gyro #0 uncalibrated (system_impl.cpp:257)
[02:30:23|Warn ] command temporarily rejected (400). (mavlink_commands.cpp:172)
[02:30:23|Debug] MAVLink: critical: Preflight Fail: Gyro #0 uncalibrated (system_impl.cpp:257)
[02:30:23|Debug] MAVLink: critical: Primary gyro not found (system_impl.cpp:257)
[02:30:23|Debug] MAVLink: critical: Primary gyro not found (system_impl.cpp:257)
[02:30:23|Debug] MAVLink: critical: Primary gyro not found (system_impl.cpp:257)
[02:30:23|Debug] MAVLink: critical: Primary gyro not found (system_impl.cpp:257)
[02:30:23|Debug] MAVLink: critical: system power unavailable (system_impl.cpp:257)
[02:30:23|Debug] MAVLink: critical: system power unavailable (system_impl.cpp:257)
[02:30:23|Debug] MAVLink: critical: system power unavailable (system_impl.cpp:257)
[02:30:23|Debug] MAVLink: critical: system power unavailable (system_impl.cpp:257)

Usually, in the simulation, we do not do a calibration. However, I am not sure if the new version of PX4 allows calibration in simulation especially that this is blocking arming and taking off completely. Any thoughts?
Regards,

I would think this comes from PX4 :thinking:

Odd. What version of PX4 is that? You can e.g. paste the output of ver all.
I'll try to reproduce it.

Do you also see this problem with jMAVSim?

I don't see this in Gazebo so far.

@shrit Most likely you have the wrong sitl_gazebo submodule.
Try
make distclean
make submodulesupdate

and then rebuild sitl in master

@julianoes, @Jaeyoung-Lim Hmm, After a set of tests, it seems to be related to my code rather than PX4 or MAVSDK. Sorry for that
PX4 version is working when testing using commander takeoff or using mavsdk
Since I add sensors to the sdf files after I generate them using xacro, exactly as done in sitl_gazebo
Still, I can not figure out where the problem coming from,

Maybe this? https://github.com/PX4/sitl_gazebo/pull/504

@julianoes I figure it out.
The problem is related to the instance_* directories that is created when starting the simulation.
I use a local slightly modified gazebo_sitl_multiple.sh, which generate these instance_* in my build directory.
Since I updated PX4, I did not delete these local folders, I only cleaned up the build in the Fimware.
When I deleted all these old instance_* directories the simulation is working fine now.
I am not sure if we need to keep them after each simulation or to delete them, it seems that they are not overwritten by this script gazebo_sitl_multiple.sh unless if I had missed it.
I know that they have the logs, but maybe we can keep them in a folder with the date and time for each simulation, what do you think? correct me if I am wrong

I solved this problem. First you need to try make px4_sitl_default gazebo.. If it can run normally, it will output some parameters in terminal. Then you should find the 'CAL_GYRO0_ID' and 'CAL_GYRO_PRIME'. It should be 2294028, but maybe yours is the same as CAL_IMU_ID. You need to change it to 2294028 in QGroundControl.

I'm closing this. It is a similar issue to #65.

@AlexWUrobot looks like your issue has been fixed.


change .py to .sh

changed .py to .sh, recent change on downloading onboarding script.  https://docs.microsoft.com/en-us/microsoft-365/security/defender-endpoint/mac-jamfpro-policies?view=o365-worldwide#step-1-get-the-microsoft-defender-for-endpoint-onboarding-package

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: b3e6e51c-592a-ed20-2340-e921e5ebd775
Version Independent ID: b3e6e51c-592a-ed20-2340-e921e5ebd775
Content: Onboard devices to Microsoft Defender for Business
Content Source: microsoft-365/security/defender-business/mdb-onboard-devices.md
Product: m365-security
Technology: mdb
GitHub Login: @denisebmsft
Microsoft Alias: deniseb

@msbemba

@samkellyd Thank you for your feedback. You are correct, it is python script, not bash. However, I'm unable to locate that in this document. COuld you please help with the URL of the document you are referring to?
Thanks
Sri

Step 10 under Mac, should be bash not .py
https://docs.microsoft.com/en-us/microsoft-365/security/defender-business/mdb-onboard-devices?view=o365-worldwide&tabs=macOSdevices
Samantha Dominguez
Technical Advisor  | Defender for Endpoint | Azure Security
•<EMAIL_ADDRESS>My Office Hours: Mon-Fri 8am - 5pm EST
Microsoft Premier Online: https://premier.microsoft.comhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpremier.microsoft.com%2F&data=04|01|sdominguez%40microsoft.com|f9982fa8d47546b2962308d9e5d04f76|72f988bf86f141af91ab2d7cd011db47|1|0|637793505122734656|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=%2BojLrHc6BWc0St0cC2cxszrcZb1vA1%2F9Qj8BtChh6UE%3D&reserved=0
Microsoft Premier Support:<PHONE_NUMBER>tel:+18009363100
If you have any feedback about my work, please contact my manager Erik Wilson<EMAIL_ADDRESS>Set a meeting with me using Bookingshttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Foutlook.office365.com%2Fowa%2Fcalendar%2FEPATZTA%40microsoft.onmicrosoft.com%2Fbookings%2F&data=04|01|sdominguez%40microsoft.com|f9982fa8d47546b2962308d9e5d04f76|72f988bf86f141af91ab2d7cd011db47|1|0|637793505122734656|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=ExL4Ct5iNG2CUiq9qQxza7QH33C%2FS4CdQqYBgJ%2BkYag%3D&reserved=0

From: Sriraman M S @.>
Sent: Thursday, May 19, 2022 12:30:51 PM
To: MicrosoftDocs/microsoft-365-docs @.>
Cc: Sam Dominguez @.>; Mention @.>
Subject: Re: [MicrosoftDocs/microsoft-365-docs] change .py to .sh (Issue #8509)
@samkellydhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fsamkellyd&data=05|01|sam.dominguez%40microsoft.com|769fff74a7a549837b9808da39b4f097|72f988bf86f141af91ab2d7cd011db47|1|0|637885746551343072|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=EW51KqxzSS88uedqjK7gPmzbi76em8M6UJzfpSLvYeQ%3D&reserved=0 Thank you for your feedback. You are correct, it is python script, not bash. However, I'm unable to locate that in this document. COuld you please help with the URL of the document you are referring to?
Thanks
Sri
—
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2Fmicrosoft-365-docs%2Fissues%2F8509%23issuecomment-1131935404&data=05|01|sam.dominguez%40microsoft.com|769fff74a7a549837b9808da39b4f097|72f988bf86f141af91ab2d7cd011db47|1|0|637885746551343072|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=YaSdpRgXevEiwTEjLiE9i847DpNtCB4zilgPHHck%2B1U%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAVLPUUKPEZBBTNEARDHCYF3VKZUDXANCNFSM5VITSDUA&data=05|01|sam.dominguez%40microsoft.com|769fff74a7a549837b9808da39b4f097|72f988bf86f141af91ab2d7cd011db47|1|0|637885746551343072|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=cHntsmKxAWHqAX7Xoqc4DXgFhZ%2BSZpNloV6Hp9Jcy2o%3D&reserved=0.
You are receiving this because you were mentioned.Message ID: @.***>

@samkellyd We have made changes to the document via PR#https://github.com/MicrosoftDocs/microsoft-365-docs/pull/8676
Thanks
Sri

@msbemba Thank you very much for the contribution and updating the documentation with PR. @samkellyd Hope this update is helpful for you. Thanks for taking out some time to open the issue. Appreciate and encourage you to do the same in future also.


OPENTOK-43733: Removed logging used to test for excessive RTT values

What is this PR doing?
Reverts https://github.com/opentok/opentok-meet/pull/130, basically
How should this be manually tested?
Make sure pub/sub still works
What are the relevant tickets?
https://jira.vonage.com/browse/OPENTOK-43733

It looks like there is a build error -> https://app.travis-ci.com/github/opentok/opentok-meet/jobs/539276961

It looks like there is a build error -> https://app.travis-ci.com/github/opentok/opentok-meet/jobs/539276961

@prabhuvashwin , yeah, CI is broken and has been for sometime :-(

It looks like there is a build error -> https://app.travis-ci.com/github/opentok/opentok-meet/jobs/539276961

@prabhuvashwin , yeah, CI is broken and has been for sometime :-(

Then we can't merge right?

It looks like there is a build error -> https://app.travis-ci.com/github/opentok/opentok-meet/jobs/539276961

@prabhuvashwin , yeah, CI is broken and has been for sometime :-(

Then we can't merge right?

Yep, we can.  Force merge ;-)


ODataModel v2; Extend Worklist/Master-Detail Demos with "create entity" code

OpenUI5 version: *
Browser/version (+device/version): *
Any other tested browsers/devices(OK/FAIL): *
URL (minimal example if possible): *
User/password (if required and possible - do not post any confidential information here): *
Steps to reproduce the problem:
I've spent several hours searching and trying various attempts to fetch enough information; to be able to build a working "createEntity" form.
Neither the https://experience.sap.com/fiori-design-web/create-page nor any of the provided examples does cover this vital part.
What is the expected result?
Somewhere at least one working example should be around.
What happens instead?
Developers waste hours searching tiny bits of information, while hoping they're still valid.
https://answers.sap.com/questions/154587/sapui5-add-new-entry-from-a-form-in-the-mockodata.html
https://archive.sap.com/discussions/thread/3895834
https://archive.sap.com/discussions/thread/3794557
https://github.com/SAP/openui5/issues/377
Any other information? (attach screenshot if possible)
If anyone would be kind and have a look at my current approach:
Keyfacts: OData v2, two-way binding, no batch mode. Based on the Worklist Template.
I've added a button on the worklist view, which calls
_createObject : function (oItem) {
	this.getRouter().navTo("objectEmpty");
},

Routing is ok, as the Object.onInit is called afterwards.
in that function i'm trying to separate between "called with id -> bind existing model to simpleform" and "called without -> create empty model and bind to simpleform".
onInit : function () {
	...
	var iOriginalBusyDelay,
	oViewModel = new JSONModel({
	busy : true,
	delay : 0
	});

	this.getRouter().getRoute("object").attachPatternMatched(this._onObjectMatched, this);

	//added the following line
	this.getRouter().getRoute("objectEmpty").attachPatternMatched(this._onObjectEmptyMatched, this);

	...
	iOriginalBusyDelay = this.getView().getBusyIndicatorDelay();
	this.setModel(oViewModel, "objectView");
	this.getOwnerComponent().getModel().metadataLoaded().then(function () {
		// Restore original busy indicator delay for the object view
		oViewModel.setProperty("/delay", iOriginalBusyDelay);
		}
	);
},

now comes the tricky part, the _onObjectEmptyMatched function. as soon as i call this.getModel().createKey; like the provided _onObjectMatched function, the framework tries to fetch the entity via odata, if i omit that part, i end in a "busy/load-loop".
loads existing entities into the simpleform:
_onObjectMatched : function (oEvent) {
	var sObjectId =  oEvent.getParameter("arguments").objectId;
	this.getModel().metadataLoaded().then( function() {
		var sObjectPath = this.getModel().createKey("QMELSet", {
			NotifNo :  sObjectId
	});
	this._bindView("/" + sObjectPath);

	}.bind(this));
},

and the frankensteined variant of the "create entity and bind form" function:
_onObjectEmptyMatched : function (oEvent) {

	var sObjectId =  "tmp-id";
	this.getModel().metadataLoaded().then( function() {
	var oEntry = this.getModel().createEntry("/QMELSet", {NotifNo: sObjectId});
	/*var sObjectPath = this.getModel().createKey("QMELSet", {
		NotifNo :  sObjectId
	});*/
	this.getView().unbindElement();
	this.getView().setBindingContext(oEntry) ;
	this.getView().bindElement(oEntry);

	//this._bindView("/QMEL/" + sObjectId);
	}.bind(this));

	/*var oViewModel = this.getModel("objectView");
	oViewModel.setProperty("/busy", false);*/
},

Which loads the empty form, and after a jiffy the loading-bubbles come in and stay.

_onObjectEmptyMatched : function (oEvent) {

	this.getModel().metadataLoaded().then( function() {
		var oEntry = this.getModel().createEntry("QMELSet", {NotifNo: sObjectId});

		this.getView().unbindElement();

		this.getView().setBindingContext(oEntry);
		this.getView().bindElement(oEntry);

		var oViewModel = this.getModel("objectView");
		oViewModel.setProperty("/busy", false);

		}.bind(this));
},

found a "minor" bug in my approach, but i still seem to miss something essential.
what happens now: if the onObjectEmptyMatched is called before the onObjectMatched, i still get the infinite load-screen. so the meta-data-load seems to be not triggered.
however i don't see the difference between the two functions.
if i open the create mode (onObjectEmptyMatched), after the edit mode (onObjectMatched) was called, i get a empty form, in which i can finally write.
but: all the linked select elements (like "choose a printer") are empty.
"funny" behaviour: if the files are server from our local gateway, the select elements contain values.
seems like the version difference between the local ui5 library and the one in the web ide is in my favour. (as long as no upgrade happens).
i still stand the point, that a well designed / extended example is highly needed.

if anyone comes down to the same problem, this is as close to perfect i could get
_onObjectEmptyMatched : function (oEvent) {
	var sObjectId =  "tmp-id";

	this.getModel().metadataLoaded().then( function() {
		var oEntry = this.getModel().createEntry("QMELSet", {NotifNo: sObjectId});

		this.getView().unbindElement();
		this.getView().setBindingContext(oEntry);

		var oViewModel = this.getModel("objectView");
		oViewModel.setProperty("/busy", false);

	}.bind(this));
},

works on 1.38, doesn't work on 1.48 (at least inside the web-ide trial dispatcher).
doesn't work means, that all the bindings are correct (according to the chrome extension, equal to an existing entity, but the select fields are empty). seems like a regression for me, i'll try to find the version barrier - and open an according bug report afterwards.

ok i've found the last missing breadcrumb, 1.38 required/allowed the path to be ../PRINTERSet, 1.48 needs /PRINTERSet - but on 1.48 JUST for an newly created element; if it already exists, ../PRINTERSet works as well.
Old:
<Select items="{ path : '../PRINTERSet', sorter: { path: 'Name' }}" selectedKey="{IPrinter}" change="regionChanged" width="100%">
	<items>
		<sap.ui.core:Item key="{Name}" text="{Name} {Standort}"/>
	</items>
</Select>

new:
<Select items="{ path : '/PRINTERSet', sorter: { path: 'Name' }}" selectedKey="{IPrinter}" change="regionChanged" width="100%">
	<items>
		<sap.ui.core:Item key="{Name}" text="{Name} {Standort}"/>
	</items>
</Select>

Hello,
The selected approach relies on creating a new entry based on metadata - http://veui5infra.dhcp.wdf.sap.corp:8080/demokit/#/api/sap.ui.model.odata.v2.ODataModel/methods/createEntry
The syntax specified for bindings is the one working in 1.48 in your example - https://sapui5.hana.ondemand.com/#/topic/6c47b2b39db9404582994070ec3d57a2.html#loioc4be40ce21ff4d0485b1d8f8114f7426
You can also use a JSONModel that reads data and lets UI to work with before submitting all the updates back.
Since the question is open for a long time, can we have some details on the following points:

Can you please modify this example to show the binding settings which does not work in UI5 1.48 - https://jsbin.com/zirodoluci/edit?html,output
Do the following examples of adding new records work for you or there is a scenario you would like to see in the online samples:
= https://sapui5.hana.ondemand.com/#/sample/sap.ui.core.sample.odata.v4.SalesOrders/preview
= https://sapui5.hana.ondemand.com/#/sample/sap.ui.comp.sample.smartform/preview

BR

the v4 is kind of nice, but it's v4 (which i'd like to target for the next project, if it's stable enough till than), the sampe.smartform doesn't allow creating a new one, right?

I have seen the functionality ready to be used in smart templates, yet I have not checked the exact implementation or any best practices.
After so long time, let me check this with my colleagues via ticket #1880574342

Hi dmnk, this issue has been around for quite a long time. Sorry for the delay to picking it up again. There has been so much progress in the meantime, particularly with OData V4.
You had shared your approach for using createEntity in OData V2, asking for more guidance and samples. While there've been some other suggestions, e.g. for using an intermediate JSONModel, we'd rather like to point to the more advanced possibilities of OData V4. For instance, there's quite detailed documentation about "Creating an Entity", https://sapui5.hana.ondemand.com/sdk/#/topic/c9723f8265f644af91c0ed941e114d46, as well as the Sales Orders sample, https://sapui5.hana.ondemand.com/#/entity/sap.ui.model.odata.v4.ODataModel/sample/sap.ui.core.sample.odata.v4.SalesOrders.
Hopefully that add'tl information resolves this older issue, particularly for newer projects leveraging OData V4 (as you had also mentioned as an outlook back then). BR


Can we sort rustfmt out once and for all

So you will need to override your editor or be careful about what changes you commit, for now.

Goodness gracious me - 2 years ago we realized that rust-bitcoin was really annoying for normal devs to work on because many Rust devs have their editors configured to automatically run rustfmt. So we disabled it in rustfmt.toml and that made this project way nicer for contributors. Fastforward and we still cannot get everyone to just aggree on f**cking rustfmt and now we are back to a place were casual devs cannot make changes to rust-bitcoin without modifying the config of their editor - this is embarrassingly stupid.

Things worked great when we had weekly fmt CI jobs These usually had 10-50 line diffs and in the intervening week usually people wouldn't run into the uncommitted changes in their own PRs.
Given that this solved a multi-year problem with several stakeholders who had incompatibly demands, we should not have been so quick to defer it indefinitely.
I think we just need to go back to that.

@Kixunil do you have a specific PR that you are expecting to get in before release? Otherwise lets run the formatter and get back to merging the bot's PRs weekly like you say @apoelstra. You mention elsewhere a max number of vetos for the bot PRs, I propose n=0

You mention elsewhere a max number of vetos for the bot PRs, I propose n=0

I would propose n = 2, but I'd be fine with 0. I don't think it's a big deal to miss a week or two since formatting problems don't accumulate that fast (especially if you and I are formatting our diffs).
But the last one we merged was 1-14. The moratoriam started with 1-21. That's 8 weeks and counting.

I would propose n = 2

I'm willing to give this a go, @Kixunil?

especially if you and I are formatting our diffs

I've currently disabled formatting in my editor because its a PITA when there are loads of formatting issues on master. I'll turn it back on and see how we go once we merge a formatting PR.


add apollo to user list

🎉

❤

Hey, did you mean to add - apollographql/react-apollo instead?

Both that and apollo-client use it!


NO-SDV [vioscsi] Tracing improvements

Includes:
a) New RUN_UNCHECKED and RUN_MIN_CHECKED definitions for compilation conditional tracing
b) DBG definition fix (remove superfluous "define")
c) Use keywords for WPP FLAGS
d) New INLINE function WPP definitions
e) WPP Optimisation
f) ETW Prettification
g) Suggestion to cull code for InitializeDebugPrints() when EVENT_TRACING

@benyamin-codez
We do need to keep the following configuration available
VirtioDebugPrintProc = DebugPrintFuncSerial;
It is the only way to troubleshoot the boot time, installation time and crash handler problems.
Best,
Vadim.

Thanks @vrozenfe
Just to be clear, I'm not proposing to alter the DBG path but rather just the ETW path like this:
--- a/vioscsi/utils.c
+++ b/vioscsi/utils.c
@@ -86,34 +86,33 @@
 void InitializeDebugPrints(IN PDRIVER_OBJECT  DriverObject, IN PUNICODE_STRING RegistryPath)
 {
     //TBD - Read nDebugLevel and bDebugPrint from the registry
     bDebugPrint = 1;
     virtioDebugLevel = 0;
-    nVioscsiDebugLevel = TRACE_LEVEL_ERROR;
+#if !defined(RUN_UNCHECKED)
+    nVioscsiDebugLevel = TRACE_ALL;
+#endif

 #if defined(PRINT_DEBUG)
     VirtioDebugPrintProc = DebugPrintFunc;
 #elif defined(COM_DEBUG)
     VirtioDebugPrintProc = DebugPrintFuncSerial;
 #else
     VirtioDebugPrintProc = NoDebugPrintFunc;
 #endif
 }

-tDebugPrintFunc VirtioDebugPrintProc;
-#else
+#else // Everything above here is DBG, everything below is ETW
+static void NoDebugPrintFunc(const char *format, ...) {} // This is NOT strictly required for ETW
 void InitializeDebugPrints(IN PDRIVER_OBJECT  DriverObject, IN PUNICODE_STRING RegistryPath)
 {
-    //TBD - Read nDebugLevel and bDebugPrint from the registry
-    bDebugPrint = 0;
-    virtioDebugLevel = 0;
-    nVioscsiDebugLevel = 4;// TRACE_LEVEL_ERROR;
+    VirtioDebugPrintProc = NoDebugPrintFunc; // This is NOT strictly required for ETW - neither DbgPrint nor DbgPrintEx will be called when EVENT_TRACING is defined
 }
-
-tDebugPrintFunc VirtioDebugPrintProc = DbgPrint;
 #endif

+// Both DBG and ETW from here...
+tDebugPrintFunc VirtioDebugPrintProc; // This is necessary for compilation due to VirtIO\kdebugprint.h requisites

 #undef MAKE_CASE
 #define MAKE_CASE(scsiOpCode)    \
     case scsiOpCode:             \
         scsiOpStr = #scsiOpCode; \

Any concerns?
cc: @YanVugenfirer

@benyamin-codez
Looks good to me. Please submit the final version when it is ready.
Best,
Vadim.

@kostyanf14
More failed checks with:
Error: 0x80070002, The system cannot find the file specified.   FindFileAndCopy()::(null)::CAUSE:Cannot Find Pattern "C:\HLK\JobsWorkingDir\Tasks\WTTJobRun412AB604-3B97-EF11-B4C4-56000200DDDD\dv_events.wtl.trace"
...
Error: 0x80070002, The system cannot find the file specified.   FindFileAndCopy()::(null)::CAUSE:Cannot Find Pattern "C:\HLK\JobsWorkingDir\Tasks\WTTJobRun7ACD44DE-3A97-EF11-9758-56000200DDDD\dv_events.wtl.trace"
...
etc.

@benyamin-codez
Currently, we have vioscsi driver bug in the upstream, so before merging https://github.com/virtio-win/kvm-guest-drivers-windows/pull/1180 we can identify the real reason of the fail

rerun tests

@kostyanf14 please re-run CI tests after DMA remapping rollback merge

@YanVugenfirer Static Tools Logo Test fails are expected as PR was built without SDV.

@YanVugenfirer Static Tools Logo Test fails are expected as PR was built without SDV.

@kostyanf14, I'm guessing something started working again with recent changes to the build scripts..?
So, it would appear calling vioscsi\buildAll.bat Win10 amd64 skips SDV... 8^d
Calling vioscsi\buildAll.bat amd64 reveals two (2) SDV defects in vioscsi, including one Must-Fix defect. Both are quite historical. Perhaps you are already aware of them and mask them in some build configurations..?
Anyway, I will raise a PR to fix both defects - hopefully in the next couple of hours (I have already fixed them and just need to raise the PR after seeing to some other commitments).
I presume DDI versions 24H2 and higher only use CodeQL and not SDV. Fixing the above defects will likely fix this too.
I note viostor does not report any SDV defects. I still need to explicitly check VirtIO...

A PR to fix SDV defects has been raised: #1181

@benyamin-codez

I presume DDI versions 24H2 and higher only use CodeQL and not SDV. Fixing the above defects will likely fix this too.

No, this is a requirement from MS. Starting from 24H2/Server 2025 SDV is deprecated and removed.

Calling vioscsi\buildAll.bat amd64 reveals two (2) SDV defects in vioscsi, including one Must-Fix defect. Both are quite historical. Perhaps you are already aware of them and mask them in some build configurations..?

Must-Fix in SDV is not equal to Static Tools Logo Test fails. You can see Must-Fix but the test still will be passed. As currently, SDV is deprecated, we just stopped checking DVL.xml if the Static Tools Logo Test passed.

@kostyanf14
Thanks for the reply. I thought it pertinent to clarify a couple of things...

I presume DDI versions 24H2 and higher only use CodeQL and not SDV. Fixing the above defects will likely fix this too.

No, this is a requirement from MS. Starting from 24H2/Server 2025 SDV is deprecated and removed.

I think we are saying the same thing here, i.e. that CodeQL is a must have from 24H2 as SDV is deprecated.
I note I should have said "CI target" rather than "DDI".

Calling vioscsi\buildAll.bat amd64 reveals two (2) SDV defects in vioscsi, including one Must-Fix defect. Both are quite historical. Perhaps you are already aware of them and mask them in some build configurations..?

Must-Fix in SDV is not equal to Static Tools Logo Test fails. You can see Must-Fix but the test still will be passed. As currently, SDV is deprecated, we just stopped checking DVL.xml if the Static Tools Logo Test passed.

SDV aside, would it be true that if CodeQL finds a Must-Fix defect, the Static Tools Logo Test will fail?
I noticed in the HLK Test Reference for the Static Tools Logo Test, that KM driver submissions need to pass all Must-Fix rules:

At present, the Static Tools Logo test requires that CodeQL be run and the "Must-Fix" set of queries passed for all kernel-mode drivers excluding graphics drivers. Note that running CodeQL on graphics drivers is highly recommended even though it is not currently required. Some queries may also find useful defects in user-mode components.
...
For Windows Server 2025 Certification, CodeQL will become the required tool for Static Tools Logo Test, this implies that all driver submissions must at a minimum pass all 'must fix' rules to be acceptable for WHCP. However, if you are certifying for Windows Server 2022 and below; CA, SDV and CodeQL can be used. Use WDK builds with the matching OS release versions.

Are you able to advise whether up-to-date standard CodeQL query suites are used, e.g. windows_driver_recommended.qls (which includes windows_driver_mustfix.qls) or is a custom query suite that includes windows_driver_mustfix.qls used instead? Moreover, is the same query suite used on all CI targets?
I'm curious as to why the CI check for Server2025 failed the Static Tools Logo Test in both #1180 and #1181, when the other CI targets passed. Any thoughts?
Best regards,
Ben

@benyamin-codez

CodeQL finds a Must-Fix defect, the Static Tools Logo Test will fail?

Yes

Are you able to advise whether up-to-date standard CodeQL query suites are used, e.g. windows_driver_recommended.qls (which includes windows_driver_mustfix.qls) or is a custom query suite that includes windows_driver_mustfix.qls used instead?

See for details: https://github.com/virtio-win/kvm-guest-drivers-windows/blob/master/build/build.bat#L238

Moreover, is the same query suite used on all CI targets?

Yes

I'm curious as to why the CI check for Server2025 failed the Static Tools Logo Test in both https://github.com/virtio-win/kvm-guest-drivers-windows/pull/1180 and https://github.com/virtio-win/kvm-guest-drivers-windows/pull/1181, when the other CI targets passed. Any thoughts?

See note in docs https://learn.microsoft.com/en-us/windows-hardware/test/hlk/testref/6ab6df93-423c-4af6-ad48-8ea1049155ae (look for "RoMetadata.dll could not be found"). We run CI on Server Core and this DLL is missing. I hope to workaround the issue soon.

@kostyanf14
Many thanks for making the time to reply.
That's good to know that the query suite and tooling is the same for all CI targets, and that there's a known cause for the failure on Server2025 and a plan to address it.
On the versions specified in the wiki, I'm not sure if it's come to your attention, but there are some additional steps required - at least for WHCP_24H2 (and maybe others).
I'll raise a PR for your consideration to address this over on https://github.com/virtio-win/virtio-win.github.io.
Best regards,
Ben

@benyamin-codez Feel free to send PR for wiki


crev commit should detect urls from Cargo.toml

The URL on project was removed in favour of randomly generated project-id.
Tools operating on source code usually do have URL etc. so they can provide them, and current idea is to focus on users operating their "proof repos", so downloading updates from project itself is secondary.

Actually, no.


headerCanvas, headerViewPort Memory Leak

I am running into a huge memory leak problem, where memory usage increase by 50m+ every time I switch between tabs in a single page application.
Grids are dynamically generated depending on the configuration of tab objects pulled asynchronously from a restful service.  Each tab can contain up to four grids.
I followed the "three snapshot" technique and narrowed the problem down to thousands of RED nodes under headerCanvas and  headerViewPort objects under containerCtrl.

ENV
AngularJS v1.3.16
UI-Grid 3.0.0-rc.21
Memory leak confirmed on IE11, Firefox, and Chrome

I have tried upgrading to RC 22 and upgraded Angular to 1.3.16.  The problem still persist.

What are you using to make the tabs? I'm trying to reproduce this locally and haven't been able to so far. Can you reproduce the same issue in a simple plunker with two grids each in UI-Bootstrap tabs? (That's basically what I'm trying).