[Microsoft.Storage] Add missing deleted account api

MSFT employees can try out our new experience at OpenAPI Hub  - one location for using our validation tools and finding your workflow.

Changelog
Please ensure to add changelog with this PR by answering the following questions.

What's the purpose of the update?

[ ] new service onboarding
[ ] new API version
[ ] update existing version for new feature
[ ] update existing version to fix swagger quality issue in s360
[ ] Other, please clarify

When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
If it's an update to existing version,  please select SDKs of specific language and CLIs that require refresh after swagger is published.

[ ] SDK of .NET (need service team to ensure code readiness)
[ ] SDK of Python
[ ] SDK of Java
[ ] SDK of Js
[ ] SDK of Go
[ ] PowerShell
[ ] CLI
[ ] Terraform
[ ] No, no need to refresh for updates in this PR

Contribution checklist:

[ ] I commit to follow the Breaking Change Policy of “no breaking changes
[ ] I have reviewed the documentation for the workflow.
[ ] Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist

[ ] Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

Adding new API(s)
Adding a new API version
Adding a new service

[ ] Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

[ ] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

[ ] Removing API(s) in stable version
[ ] Removing properties in stable version
[ ] Removing API version(s) in stable version
[ ] Updating API in stable version with Breaking Change Validation errors
[ ] Updating API(s) in preview over 1 year

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.

Looks good to me.
But this might be a breaking change to exist GA API version.
And the .net SDK failure should be same root cause as #11382 (comment)

The api is already being released under June19 api-version and is used. This was missed adding in the swagger. Also, from the swagger breaking change recommendation, I didn't see adding a new operation under an existing api-version is considered a breaking change.

@priyapansrp
We need to include ARM review, if it pass ARM review, I have not problem with the change.
Besides that, please include the PR link for the same change on 2020-08-01-preview. The change should also on the new API version.

Hi @priyapansrp, you have to follow breaking change policy for your change as shown above.

/azp run


Tracking Issue: reduce allocations during bulk data transfers

A 1 GB transfer using v0.29.0 currently creates (as measured by pprof's alloc tool, which measures total allocations over the lifetime of the process) about 500 - 600 MB of allocations, both on the sender and on the receiver side.
This is a problem for performance, because allocating memory consumes resources, and more importantly, all of this memory has to be garbage-collected, putting a lot of pressure on the GC.
We need to drastically reduce the amount of allocations. Target is a reduction of an order of magnitude.
The worst offenders at the moment seem to be:

[ ] allocations of wire.{Extended}Header. This is a struct representing a QUIC packet header
[x] allocations of ackhandler.Packet structs (used to track sent packets until they're acknowledged / declared lost): #3525
[x] allocations of wire.AckFrame: https://github.com/lucas-clemente/quic-go/pull/3547
[x] parsing the control message via unix.ParseSocketControlMessage. This will require us to either rewrite that code ourselves, or upstream a fix to golang.org/x/net (both?)
Go issue: https://github.com/golang/go/issues/54714
PR: https://github.com/lucas-clemente/quic-go/pull/3609
[x] use a more efficient type for connection IDs: #3527
[x] stop using a bytes.Buffer when packing packets. Allocating new bytes.Buffers is responsible 32 MB of allocations. We can just append to a []byte
#3530
[x] don’t allocate a new bytes.Reader for every packet when parsing frames. This is responsible for 32 MB of allocations on the receiver side.
#3536
[ ] list allocations, especially when sending packets: https://github.com/lucas-clemente/quic-go/pull/3655

Traces
Server

Client

On v0.30.0 the allocations look way better:
File: specter-linux-amd64
Type: alloc_space
Time: Oct 30, 2022 at 4:30am (PDT)
Entering interactive mode (type "help" for commands, "o" for options)
(pprof) top5
Showing nodes accounting for 356.03MB, 51.02% of 697.81MB total
Dropped 309 nodes (cum <= 3.49MB)
Showing top 5 nodes out of 109
      flat  flat%   sum%        cum   cum%
  119.51MB 17.13% 17.13%   119.51MB 17.13%  github.com/lucas-clemente/quic-go.(*packetPacker).getShortHeader
   89.51MB 12.83% 29.95%    89.51MB 12.83%  golang.org/x/sys/unix.ParseSocketControlMessage
   69.50MB  9.96% 39.91%    95.51MB 13.69%  github.com/lucas-clemente/quic-go.(*packetPacker).composeNextPacket
   49.50MB  7.09% 47.01%   159.52MB 22.86%  github.com/lucas-clemente/quic-go.(*oobConn).ReadPacket
      28MB  4.01% 51.02%       28MB  4.01%  kon.nect.sh/specter/chord.(*LocalNode).fixK

Interesting article on how to reduce allocations using a sync.Pool in combination with finalizers.

pprof update, running in a branch that includes the above PRs (#3644, #3646, #3648, #3655). Again, the scenario is the transfer of a single 1 GB file on a single stream.
Server

We're down from 540 MB to 128 MB, that's 76%.
Client

We're down from 514 MB to 147MB, that's 72%. I believe we can get rid of the allocation in ReadPacket as well, by using a sync.Pool for the receivedPacket struct.

Impressive work, Marten!!

Do we know that allocation overhead (if any) for opening/closing streams? That would be common in the RPC use case

Do we know that allocation overhead (if any) for opening/closing streams? That would be common in the RPC use case

I just added a new benchmark test that opens and accepts streams in #3697. Looks like we're allocating almost 4 kB per stream:
goos: darwin
goarch: arm64
pkg: github.com/quic-go/quic-go/integrationtests/self
BenchmarkStreamChurn-10           561832              2662 ns/op            3696 B/op         42 allocs/op

@zllovesuki If you have any ideas how to optimize that, I'd be happy to review a PR :)


swagger unfold/fold both GET /api/vacancy and GET /api/vacancy/{id} api calls tabs

no wonder since I use 5.0.0-beta swagger :man_shrugging:

must be some swagger issues, irrelevant


Fix reversed 03-02 and 03-03 file names in Mandarin to match English

@audreyt we're having problem with some conflict...feel free to merge once you have fixed.

OK — merged at #394


Fix soundPlay with 0 duration never deregistering

Fixes #866.

SoundDuration from what I've heard is pretty unrealiable, wiki page also indicates this,

This function does not work properly in most cases! Some say it only works properly with .wav files.

The E2doc says:
E2Helper.Descriptions["soundDuration(s)"] = "soundDuration(string Path to File) Returns the duration of the sound. Note: If the server hasn't the file it returns 60"

Which sounds more informative than "some say..."

That would be incorrect going off of what I've seen. https://github.com/Facepunch/garrysmod-issues/issues/936, https://github.com/Facepunch/garrysmod-issues/issues/2362, https://github.com/Facepunch/garrysmod-issues/issues/2935 and https://github.com/Facepunch/garrysmod-issues/issues/3306 all gives examples of it returning widely different results.

Okay, I guess we need #870 then.

Looking into it this would also break looping sounds, and I can't see any way to get around that.


Shifting to caktin tools for building the repo

This refers to the project mentioned in #8.
I have been using catkin tools for a while now and I think it it is way better than the catkin_make that we use. Thus, I think it is better if we check that all current packages can be built using catkin build and use catkin tools in future. There might be a few build issues that would need to be resolved but they can be fixed in the CMakeLists of those packages.
Overview: https://catkin-tools.readthedocs.io/en/latest/
Step-by-Step Instructions: http://catkin-tools.readthedocs.io/en/latest/migration.html#step-by-step-migration
Also, the Travis configuration and README have to be changed accordingly.

@7ayushgupta You can do it. It's fairly simple.


Add Support for Numeric Enums in Zod Schema Generation

The surql-gen tool currently lacks support for generating Zod schemas that enforce a field's value to be within a specific set of numbers (numeric enums). This is essential for cases where a SurrealDB field is restricted to specific numeric values.
Problem Example:
SurrealDB Definition:
DEFINE FIELD myNumberField ON TABLE myTable TYPE int
ASSERT $value IN [1, 2, 3, 4, 5];

Expected Zod Schema:
const myTableInputSchema = z.object({
  myNumberField: z.union([
    z.literal(1),
    z.literal(2),
    z.literal(3),
    z.literal(4),
    z.literal(5)
  ])
});

It would be amazing if there was support for generating numeric enums in Zod schemas when the SurrealDB schema defines a field with an IN or INSIDE clause that specifies a set of numbers.

Thx for your feedback.
We will try to get this into the lib


No results when library search contains colon (:)

Steps to reproduce

Add entries that have ":" in title to library (example: Re:Zero)
Search for "re:zero" in library

Expected behavior
Search results should return Re:Zero entries
Actual behavior
Search results are empty
Crash logs
No response
TachiyomiSY version
Dev Build 566
Android version
Android 11
Device
Motorola G5s Plus
Other details

Acknowledgements

[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
[X] I have written a short but informative title.
[X] I have gone through the FAQ and troubleshooting guide.
[X] I have updated the app to version 1.10.5.
[X] I have updated all installed extensions.
[X] I will fill out all of the requested information in this form.

: is a special character in the search, there are sources that use : as a separator so it is handled differently from other characters. If you need to search something with a :, just remove it from the query and put a space.


Fix hover text color on apply date facet button

Problem Description:
The Apply button on date facets turns black on hover which does not pass color contrast testing.
Expected Behavior/Solution:
Change the text color on hover to a contrast approved color. The background color will become white and the text color will become the dark blue.
Requirements:

[ ] hover css property should be the following:

  &:hover {
    background-color: ${theme.color.white};
    color: ${theme.color.primary.darkBlue};
    border-color: ${theme.color.primary.darkBlue};
  }

Needed for promotion:
If an item on the list is not needed, it should be crossed off but not removed.

[x] Wireframe/Mockup - Mike
[ ] ~Committee discussions - Sarah~
[ ] ~Feasibility/Team discussion - Sarah~
[ ] ~Backend requirements - N/A~
[x] Frontend requirements - Kam
[ ] ~Questions~

UAT/LUX Examples:

http://localhost:3000/view/results/objects/?q={"AND"%3A[{"text"%3A"andy"%2C"_lang"%3A"en"}%2C{"text"%3A"warhol"%2C"_lang"%3A"en"}]}&sq=andy+warhol

Click on the Creation Date facet and hover the mouse over the "Apply" button

Dependencies/Blocks:
N/A
Related Github Issues:
N/A
Related links:

Bugherd: https://www.bugherd.com/projects/284041/tasks/2115

Wireframe/Mockup:

@kamerynB Is the link in the UAT links working for you? It tells me the site can't be reached(I tried on and off VPN).
Maybe we could use this link instead: https://lux-front-tst.collections.yale.edu/view/results/objects/?q={"AND"%3A[{"text"%3A"andy"%2C"_lang"%3A"en"}%2C{"text"%3A"warhol"%2C"_lang"%3A"en"}]}&sq=andy+warhol

@roamye Whoops I added my localhost URL. I'll update it.

looks good in prod, closing


Namespaces for kubevirt-storage-class-defaults and v2v-vmware

Fixes issue with changing location of ConfigMaps in different releases.
The kubevirt-storage-class-defaults ConfigMap is attempted to be retrieved from the openshift-cnv first, then from openshift in case of error.
The v2v-vmware ConfigMap is read from openshift-cnv namespace first, then from kubevirt-hyperconverged.

Pull Request Test Coverage Report for Build 2276

20 of 33 (60.61%)  changed or added relevant lines in 7 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-0.05%) to 82.802%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/k8s/requests/storageClass/storageClassConfigMap.js
12
13
92.31%

src/k8s/requests/v2v/importVmware.js
0
1
0.0%

src/k8s/requests/v2v/startV2VvmwareController.js
0
1
0.0%

src/k8s/requests/v2v/vmwareConfigMap.js
3
13
23.08%

Files with Coverage Reduction
New Missed Lines
%

src/k8s/requests/v2v/startV2VvmwareController.js
1
11.86%

Totals

Change from base Build 2275:
-0.05%

Covered Lines:
4187

Relevant Lines:
4842

💛  - Coveralls

The best way to find the config map is to look for the namespace of the HCO CR.


Update README.md

Checkmarx One – Scan Summary & Details – e6c747ff-b9a7-4f82-91bd-04fe83ebf52d
No New Or Fixed Issues Found


VEGA-1073 Add recommended security headers to response

Codecov Report

Merging #127 (b6d7ad0) into main (7c5a3b8) will increase coverage by 0.08%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #127      +/-   ##
==========================================
+ Coverage   88.88%   88.97%   +0.08%
==========================================
  Files          35       35
  Lines         891      898       +7
==========================================
+ Hits          792      799       +7
  Misses         52       52
  Partials       47       47

Impacted Files
Coverage Δ

internal/server/server.go
95.23% <100.00%> (+0.34%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c5a3b8...b6d7ad0. Read the comment docs.


Training_data_v2 is (almost) empty

I've just run balance_data.py and since I didn't want to overwrite training_data.npy (which is about 200.000KB) I choose to do np.save('training_datata_v2.npy', final_data) as Sentdex does in the video.
The matter is that it is 128B and contains 9 lines of information.
What is this due to?

Could you share your balance_training_data.py code?
Thank you
Peter Gardas


fix: add QEMU to support multi-platform docker image

can not support multi platform docker image.because FROM alpine:3.16 in Dockerfile just support linux/amd64


Refactor to use fs.promises to create streams

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.79%. Comparing base (4afc108) to head (df7e372).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #26      +/-   ##
==========================================
- Coverage   98.81%   98.79%   -0.03%
==========================================
  Files          13       12       -1
  Lines        1184     1163      -21
  Branches      112      113       +1
==========================================
- Hits         1170     1149      -21
  Misses         14       14

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Need to switch the --name and --record-set-name parameters in the last two PowerShell commands

In the Deploy with a private DNS section, the last two PowerShell commands each contain a wrong parameter name for the respective command: the ** --record-set-name** and --name parameters were mixed up between the two commands.
Here are the correct commands:
az network private-dns link vnet create `
  --resource-group $RESOURCE_GROUP `
  --name $VNET_NAME `
  --virtual-network $VNET_ID `
  --zone-name $ENVIRONMENT_DEFAULT_DOMAIN -e true

az network private-dns record-set a add-record `
  --resource-group $RESOURCE_GROUP `
  --record-set-name "*" `
  --ipv4-address $ENVIRONMENT_STATIC_IP `
  --zone-name $ENVIRONMENT_DEFAULT_DOMAIN

The Bash versions of the commands are correct in the documentation.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: b0aa5af5-831d-77e2-480c-41ab2bbb5be3
Version Independent ID: 583217b2-1821-2cd9-629d-779af221a436
Content: Provide a virtual network to an Azure Container Apps Preview environment
Content Source: articles/container-apps/vnet-custom.md
Service: container-apps
GitHub Login: @craigshoemaker
Microsoft Alias: cshoe

Thanks for the feedback! We are currently investigating and will update you shortly.

Thanks for bringing this to our attention. I have created a PR with the update, changes will be live shortly.
Thanks for improving our documentation! Just so you know, it's also possible to make these changes yourself, if you are interested. Doing so will improve our documentation, and it will add you as a contributor to the document.
In case you're interested, these are the steps to do so:

Navigate to the page of interest
Select the "Edit" button at the top right of the page
Select the "Pencil" icon on the right
Modify the text within the text box in markdown format - more info: https://github.com/adam-p/markdown-here/wiki/Markdown-Cheatsheet
Name your file change and provide a description, if necessary
Select "Propose file change"
Select "Create pull request" on the 'Comparing changes' page
Select "Create pull request" on the 'Open a pull request' page
You can find a GIF that demonstrates the end-to-end process for submitting changes here: https://aka.ms/editsqldocs.


Use cargo features instead of OPENCV_MODULE_*

When working with OpenCV I frequently need only few modules. The current way of selecting it with environment variables causes all sorts of ruckus:

If your target is a static library, the pain of setting the variable is pushed onto the library consumer.
Any editor which uses rust-analyzer/RLS needs to have the exact same environment vars set otherwise you get full rebuilds every time.
When invoking cargo from external build systems such as Xcode or CMake it becomes a pain.

I see that having feature selection hidden from the build system caused friction in my tam and I don't think it's a coincidence that no other package uses environment variables for feature selection :)
It would be amazing if we could select features with cargo features!
The tradeoff would be that cargo requires potential features to be declared in Cargo.toml which means we'd have to forego automatic detection of new modules. But I guess that each time OpenCV adds a new module we'd need to test it and mark somehow that it works so I don't think this actually adds more work.

It's now released in 0.59.0

Thank you!


Implement Char function push down

Feature Request
Describe the feature you'd like:

We'd like to support Char function push down.
Teachability, Documentation, Adoption, Migration Strategy:

At least one integration test and several unit tests.

/assign


build fails for obfuscated assembly

This issue can be reproduce by creating a (library) project, adding StrongNamer and the nuget package Oracle.ManagedDataAccess e.g. v19.3.1.
Then the build fails with
1>  Assembly file 'C:\TestProj\packages\Oracle.ManagedDataAccess.19.3.1\lib\net40\Oracle.ManagedDataAccess.dll' failed to load.  Skipping.  System.ArgumentOutOfRangeException: Non-negative number required.
1>  Parameter name: count
1>     at System.IO.BinaryReader.ReadBytes(Int32 count)
1>     at Mono.Cecil.PE.ImageReader.ReadDebugHeader()
1>     at Mono.Cecil.PE.ImageReader.ReadImage()
1>     at Mono.Cecil.PE.ImageReader.ReadImage(Disposable`1 stream, String file_name)
1>     at Mono.Cecil.ModuleDefinition.ReadModule(String fileName, ReaderParameters parameters)
1>     at StrongNamer.AddStrongName.ProcessAssembly(ITaskItem assemblyItem, StrongNameKeyPair key, StrongNamerAssemblyResolver resolver)

The Oracle assembly seems to be obfuscated which causes that issue within the Cecil lib.
I'm not sure where to fix this best: Cecil or StrongNamer. Maybe a workaround here would be easiest:
Allow config of particular assembly references that should be skipped.
This issue was also reported for

ILSpy
and a similar issue for Cecil.

Btw, with dotPeek I manage to inspect the Oracle assembly and see in deed some obfuscated code.

The latest mono.cecil code fixes this, however they have not pushed an updated package yet.

Nuget package of mono.cecil is available now. Is it possible to build a new version? We ran into the same problem


Drop arm32 (armhf) for linux and add Darwin arm64

[ ] read the CONTRIBUTING guidelines
[ ] raised a GitHub issue or discussed it on the projects chat beforehand
[ ] added unit tests
[ ] added integration tests
[ ] updated documentation if needed
[ ] updated CHANGELOG.md

@juanfont is there any performance or programmatic reason for dropped arm32 support?
Less to maintain I guess, but would you still expect for a source build to be usable?


Error: Cannot find module 'cli-ux' (looks like cli-ux is not saved in the package.json)

Describe the issue
On installation using npm i -g, ghs is missing the cli-ux package (looks like it wasn't saved in the package.json)
Version: @anomalyhq/github-secrets-cli/1.0.1 darwin-x64 node-v14.13.0
Steps To Reproduce

Install using npm install -g @anomaly/github-secrets-cli
Check that ghs is installed using ghs -v, see that it's correctly installed
Try ghs config:set
Returns:

     Error: Cannot find module 'cli-ux' ...
    Require stack:
    -<EMAIL_ADDRESS>    - /usr/local/lib/node_modules/<EMAIL_ADDRESS>    - /usr/local/lib/node_modules/<EMAIL_ADDRESS>    - /usr/local/lib/node_modules/<EMAIL_ADDRESS>    - /usr/local/lib/node_modules/<EMAIL_ADDRESS>    - /usr/local/lib/node_modules/<EMAIL_ADDRESS>    - /usr/local/lib/node_modules/@anomalyhq/github-secrets-cli/bin/run
    Code: MODULE_NOT_FOUND

Expected behavior
Should prompt for organization: Which organisation does the repo belong to?: . This behavior works as expected after installing cli-ux in the ghs package directory.
Logs
See Above!

Thanks for this. You are correct, cli-ux does appear to be missing from the dependencies.
Seems I missed this locally as it is a dependency of a devDependency.


Formatting issue due to how resolutions are given

In the chapter Command line basics / URL globbing header Combinations there is an example where image resolutions are given. I suspect the use of asterisks causes incorrect formatting.
The text looks like this:
To download the images of Ben, Alice and Frank, in both the resolutions 100  100 and 1000  1000, a command line could look like
I assume that one of the following was intended:
To download the images of Ben, Alice and Frank, in both the resolutions 100 * 100 and 1000 * 1000, a command line could look like
To download the images of Ben, Alice and Frank, in both the resolutions 100x100 and 1000x1000, a command line could look like

Thanks, yes that seems like a correct conclusion. Will fix!


network problem caused by conflict nodeport and snat port

Is there an existing issue for this?

[X] I have searched the existing issues

What happened?
One application in our prod environment encounters a network problem. When this application accesses one specific port of a remote host, the pod cannot get the response, the node get reponse but send RST. We use tcpdump to capture the packet in node and pod. We found that the snat port (30880) conflict with a nodeport svc (30880 also).
1、ciliumconfig

ebpf masquerade disabled
ebpf nodeport enabled
strict kube-proxy replacement
native routing (tunnel: false)
cluster-pool mode IPAM
DSR is not used

2、reproduce
run a server outside the cluster, such as <IP_ADDRESS>:8080
create a nodeport svc in cluster, the port is 30880
create a non-hostnetwork pod in cluster
execute the following command in pod, curl --local-port 30880 <IP_ADDRESS>:8080
iptables snat rule donot limit ports, as
-A CILIUM_POST_nat -s   xx.xx.xx.xx/24 ! -d xx.xx.xx.xx/16 ! -o cilium_+ -j MASQUERADE
which means snat port may used by nodeport svc.
If snat port is used by nodeport svc, cilium first check the response packet belongs to an nodeport svc or not (tc ingress ebpf), which causes the packet delivered to the wrong destination (nodeport svc ep).
we add an new iptables rule before the old rule as
-A CILIUM_POST_nat -s   xx.xx.xx.xx/24 ! -d xx.xx.xx.xx/16 ! -p tcp -o cilium_+ -j MASQUERADE --to-ports 32768-65536
and execute the following command in pod, curl --local-port 30880 <IP_ADDRESS>:8080, it works.
Cilium Version
1.14.6
Kernel Version
5.10.0
Kubernetes Version
v1.24.3
Regression
No response
Sysdump
No response
Relevant log output
No response
Anything else?
No response
Cilium Users Document

[ ] Are you a user of Cilium? Please add yourself to the Users doc

Code of Conduct

[X] I agree to follow this project's Code of Conduct

execute the following command in pod, curl --local-port 30880 <IP_ADDRESS>:8080

Where do you run this command from?

Can you check the node port range configured on your cluster? Also, what's the output of enable-auto-protect-node-port-range?

@aditighag
thank you for your reply.

Where do you run this command from?

i run this command in a non-hostnetwork pod, and the cluster has a nodeport svc with port 30880.

Can you check the node port range configured on your cluster? Also, what's the output of enable-auto-protect-node-port-range?

net.ipv4.ip_local_port_range = 32768   60999
enable-auto-protect-node-port-range = true
i found the same problem, #23604.

@ycydk, may I ask what kind of error messages (if any) you observed from cilium/ebpf?

@yiningou, sorry, we didn't observe error messages from cilium/ebpf. You can check issue #23604 for more details. We solve the problem by restricting iptables snat port range to 32769-65535. This issue should be closed.


[REVIEW] Portfolio Link

Portfolio link
https://mahesh9340.netlify.app/

Great Portfolio! You can modify your GitHub profile aswell- it would look better.

Thank You @shubhimainalli for your feedback!
I am working on it to create great GitHub Portfolio.
Apart from this, I have a question...what should I need to do to be part of EddieHubCommunity. Will you please elaborate that. Thank You.

Hi @maheshdbabar9340 , EddieHubCommunity is for everyone, You can join by just raising an issue on the support repo https://github.com/EddieHubCommunity/support with type " Invite me to the organization" . Hope this explains clearly. Please reachout to me for any quires.

Hi @maheshdbabar9340 , EddieHubCommunity is for everyone, You can join by just raising an issue on the support repo https://github.com/EddieHubCommunity/support with type " Invite me to the organization" . Hope this explains clearly. Please reachout to me for any quires.

Thank You @shubhimainalli , It helps me to join EddieHubCommunity.

Consider jumping back to top when switching between your tabs

Consider jumping back to top when switching between your tabs

Yes @schmelto, I will do it. Thank You for your great feedback.


step 8: define eventbridge and integrate them with lambda functions

Are you sending the events to the default event bus?

yes

you can define a custom event bus with one line of code and then reference that in the lambda by its name. It's unnecessary to provision custom busses for simple use cases. I can add an extra step for creating a custom bus if you want.

It's better to add an event bus because it will show the concept of how to create an event bus.


Simple Icons logo color

Are you experiencing an issue with...

[x] shields.io
[ ] My own instance
[ ] badge-maker NPM package

Description
The color for Simple Icons seems to be inconsistent in its application. For some badges, I need to specify the logoColor and for other I dont.
Working example

simpleicons.org/swift

https://img.shields.io/badge/-Swift-fff?&logo=Swift
The color of the Swift logo is FA7343 and it seems to be applied correctly without needing to specify the logoColor.

simpleicons.org/docker

https://img.shields.io/badge/-Docker-fff?&logo=Docker
Again, I didn’t have to specify the logoColor for the logo to show up correctly.

Non-working examples

simpleicons.org/java

https://img.shields.io/badge/-Java-fff?&logo=Java
The color of the Java logo is 007396. The logo on this badge is white instead of its intended color. We can see this by changing the badge’s color:

https://img.shields.io/badge/-Java-000?&logo=Java
So to get the Java logo to show up correctly i have to specify the logoColor:

https://img.shields.io/badge/-Java-fff?&logo=Java&logoColor=007396

simpleicons.org/typescript
Logo without logoColor:

https://img.shields.io/badge/-TypeScript-fff?&logo=TypeScript
Logo with logoColor:

https://img.shields.io/badge/-TypeScript-fff?&logo=TypeScript&logoColor=007ACC

I’m unsure if this is a bug or if it is by design. Why do I have to specify the logoColor for some logos, and for others I do not?

It is by design, but I agree the behaviour is not ideal in this situation.
The default behaviour is that we try to select a logo colour that will work with the default backgrounds. If we think the suggested colour from simpleicons will work, we use that otherwise we re-colour it so that we don't end up showing a dark logo on a dark background or light logo on a light background.
For the main badge styles (flat, flat-square, for-the-badge, plastic) we're assuming the background is going to be darkgrey and for the social badge we're assuming it is whitesmoke. If you've customised the background colour, then we don't adapt. Unfortunately in this case, because you've customised the background of the default badge style to a light colour, this means the logic is basically doing the exact opposite of what you want.
https://github.com/badges/shields/pull/2833 is the PR where we introduced this. The logic might have moved on a bit since then, but if you read the discussion there, that's how we arrived at the current tradeoff..

Interesting read.
Curious, was the default before the PR or at any point in time to use the logo with the color that Simple Icons specified?


docs for Host Compute Service (HCS) API

I wonder if there's a reference documentation for the Host Compute Service (HCS) C API and/or the Golang/.NET bindings for it? Both are mentioned here, but I lack to find any docs about it?
https://docs.microsoft.com/en-us/virtualization/community/team-blog/2017/20170127-introducing-the-host-compute-service-hcs#feedback
(Just to say, I'm not looking to replicate Docker/Moby functionality but am - as a Docker on Windows user - interested in debugging/troubleshooting beyond what's currently possible with hcsdiag.exe).

Duplicate of #46


cjxl lossless -e8 and -e9 sometimes create an invalid image

Describe the bug
cjxl lossless -e8 and -e9 sometimes create an invalid image according to the spec.
To Reproduce
Encode this image using -d 0 -e 8:<PHONE_NUMBER>354229250_1. Pass group 10 will have a Palette transform with 557 colors with LZ77 enabled. libjxl uses dist_multiplier = 557 to encode and decode, which doesn't match the spec (18181-1).
Expected behavior
LZ77 dist_multiplier should be 256.
Environment
cjxl version: cjxl v0.10.0 6d041617 [AVX2,SSE4,SSE2]
Additional context
First reported in tirr-c/jxl-oxide#268.

For images already encoded this way, are they "ruined"?

This is why independent decoders are so nice to have. This has been a libjxl bug that went undetected because both encoder and decoder have the same bug so images still roundtripped.
We're still debating whether to treat this as a libjxl bug (which it is) and fix libjxl, or to treat it as a bug-that-becomes-spec and fix the spec. The spec way is the better way; we were losing some compression (in the specific case of images with > 256 colors per group but still few enough to do palette, i.e. less than 1024 by default) because of this bug, but then again it is annoying to invalidate existing outputs of the libjxl encoder. So it's not a clear-cut decision.
The only bitstreams affected should be modular e8+.

There are cases that it's not really possible to detect broken images; for example, if a group has only one LZ77 repeat symbol at the end of the stream, both spec and libjxl method will end up in identical bitstream and entropy-coded stream, but they will have completely different image.

My position is to treat it as a bug-that-becomes-spec. Trying both variants in the encoder does not result in significant differences in compression. On some images, the libjxl way is slightly better, on others the current spec way is slightly better; differences are usually only a matter of a few bytes on way or the other (in the cases where there is a difference; most commonly, there is no difference at all).

The spec is being changed to match what the code in libjxl did in this case


python310Packages.pontos: 23.2.0 -> 23.2.4

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python310Packages.pontos is: Collection of Python utilities, tools, classes and functions
meta.homepage for python310Packages.pontos is: https://github.com/greenbone/pontos
meta.changelog for python310Packages.pontos is: https://github.com/greenbone/pontos/releases/tag/v23.2.4
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 23.2.4 with grep in /nix/store/qblzwf1w4ylk7vs00apxmziah2s8g8yv-python3.10-pontos-23.2.4
found 23.2.4 in filename of file in /nix/store/qblzwf1w4ylk7vs00apxmziah2s8g8yv-python3.10-pontos-23.2.4

Rebuild report (if merged into master) (click to expand)

2 total rebuild path(s)

2 package rebuild(s)

First fifty rebuilds by attrpath
python310Packages.pontos
python311Packages.pontos

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/qblzwf1w4ylk7vs00apxmziah2s8g8yv-python3.10-pontos-23.2.4 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A python310Packages.pontos https://github.com/r-ryantm/nixpkgs/archive/7932c9c05598aff843295215c53e2c54c4e0419f.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/qblzwf1w4ylk7vs00apxmziah2s8g8yv-python3.10-pontos-23.2.4
ls -la /nix/store/qblzwf1w4ylk7vs00apxmziah2s8g8yv-python3.10-pontos-23.2.4/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

2 packages built:

python310Packages.pontos
python311Packages.pontos

Maintainer pings
cc @fabaff for testing.

Result of nixpkgs-review pr 215308 run on aarch64-darwin 1

2 packages built:

python310Packages.pontos
python311Packages.pontos


Feat:Enhance the copyrights section

Describe the feature
The footer page's copyrights section is not properly seen. I would love to work on this. Kindly assign this issue to me under gssoc'24 extd and hacktoberfest
Add ScreenShots

Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC'24 contributor
[X] I want to work on this issue

whats the issue with the footer ? explain properly .
#4084 is already working on enhancement of the page.

The copyrights part is not visible to the users properly. I want to enhance it by improving the font color. This will increase the visibility and would be better for the users. Copyrights is an important section which cannot be neglected.

it is visible .


Qualify the field name for sorting.

Protects against "ambiguous" errors when more than one table in the relationship chain has the same field name.
Not sure if my change is the most efficient way of doing this, but it's the only way I could figure out to do it.  Happy to change the code if anyone has a better way.

Thanks! Could you fix up PHPStan for me please? You probably want to use specific relationship types

Stan is happy now.
Sometimes Laravel's magic is a little too insidious.  There's a magic __call() method on the Relation class which forwards any unhandled methods on to the query, so I've gotten used to using things like $relation->getModel() when I really mean $relation->getQuery()->getModel().


transitionLengthTicks is constant, despite setting it in the AnimationController constructor or by modifying event.getController().transitionLengthTicks

Environment: Fabric
GeckoLib Version: 3.0.1
Despite setting the value of transitionLengthTicks to 0 (which should cancel the transition between animations) or any other value in the constructor or during the predicate method by modifying event.getController().transitionLengthTicks, the transition time between animations doesn't change at all. I've measured this time to be approximately of 2 seconds, if the animation is near its end but not fully. A few details about the animation:

The animation was made on BlockBench with the Geckolib plugin and exported / saved to the mod's animation resources folder
The animation properly plays in-game
The animation is set to loop. In my case, the animation is a running animation triggered in the predicate function when the entity is moving.
The animation is the only animation on the entity.
The animation starts directly from a moving pose (and not the base pose).
The animation switches from no animation (when the entity is still) to the running animation (when the entity is moving). The transition between no animation to the running animation seems to be instantaneous, which corresponds to the value of transitionLengthTicks.
However, the problem appears when transitioning from the running animation to no animation (when the entity stops moving). In my case, there is an approximative transition of 2 seconds, when there shouldn't be any because of the value of transitionLengthTicks being set to 0 in the AnimationController constructor.

I've noticed the transition seems to be as long as the transition between animations for the modified Creeper. I've encountered this problem two times now, despite strictly following the wiki.
In my case in particular, I am making a Rat entity, with only one animation currently as I mentioned earlier: a running animation.
Inside RatEntity.java, this is my predicate() function:
private <E extends IAnimatable> PlayState predicate(AnimationEvent<E> event) {
    if (event.isMoving()) {
        event.getController().setAnimation(new AnimationBuilder().addAnimation("animation.rat.run", true));
        return PlayState.CONTINUE;
    }
    return PlayState.STOP;
}

How I register my animation controllers in the same class:
@Override
public void registerControllers(AnimationData data) {
    data.addAnimationController(new AnimationController<>(this, "controller", 0, this::predicate));
}

And finally, my RatEntityModel.java class code:
public class RatEntityModel extends AnimatedGeoModel<RatEntity> {
    @Override
    public Identifier getModelLocation(RatEntity object) {
        return new Identifier(Rats.MODID, "geo/entity/rat.geo.json");
    }

    @Override
    public Identifier getTextureLocation(RatEntity object) {
        return new Identifier(Rats.MODID, "textures/entity/"+object.getRatType().toString().toLowerCase()+".png");
    }

    @Override
    public Identifier getAnimationFileLocation(RatEntity object) {
        return new Identifier(Rats.MODID, "animations/entity/rat.animation.json");
    }
}

If more code is needed, the rest of it is present here.
I will add a video of the animation inside the game once I have a stable enough internet connection

And here is the video of it happening in-game
https://streamable.com/l952eb

And here is the video of it happening in-game
https://streamable.com/l952eb

I've noticed that transitioning to the animation actually respects the set amount of transition ticks (in my case 0), but transitioning from always stays constant no matter the transition length.
Here is another video showcasing the issue with another animation: https://streamable.com/49pu3b

I've noticed that transitioning to the animation actually respects the set amount of transition ticks (in my case 0), but transitioning from always stays constant no matter the transition length.
Here is another video showcasing the issue with another animation: https://streamable.com/49pu3b

Hey @doctor4t can you retest this on the latest?

Hey @doctor4t can you retest this on the latest?

@AzureDoom Updated to 3.0.14 and the issue is still there sadly.

@AzureDoom Updated to 3.0.14 and the issue is still there sadly.

Confirmed fixed in latest issue. Closing

Confirmed fixed in latest issue. Closing


fix: update npx command in setup.js

PR Checklist

[x] Addresses an existing open issue: fixes #316
[x] That issue was marked as status: accepting prs
[x] Steps in CONTRIBUTING.md were taken

Overview

If the all-contributors package is not already installed on the local machine, the script exits. We can pass --yes to autoinstall it.

@allcontributors add @jsjoeio for tool


In Touchable highlight page, no success info while invoking ‘A touchable highlight color’ button.

Found during accessibility grading.
Tracking internal bug: https://microsoft.visualstudio.com/DefaultCollection/OS/_workitems/edit/40128776
"Narrator should announce about the available number present inside the button."
"Note: Same issue is observed in ‘Touchable Opacity’."

accessibilityValue should help


remove core/detail/stream_algorithm.hpp

This failed experiment didn't go as planned...

Removed in 210


pylance not resolving site-package imports

v 2022.5.3 appears not to be resolving packages that have been installed in site-packages.
For example
"from lxml import etree"
gives the message
Import "lxml" could not be resolved
The same is true for every other package I try to import from site-packages
Running the script is unaffected
VS Code Version: 1.67.2

Thanks for the report. Would you please check if the right virtual environment is being used?
The way to do that would be to:

If you have not selected a virtual environment, the status bar will show the global python interpreter.
Click on version number and choose the right environment from the command palette
If there is no environment offered, you will need to create an environment and then select that as the default environment
When you select the right virtual environment Pylance find the modules installed in that environment.

Here is a link to virtual environments: https://code.visualstudio.com/docs/python/environments
Please reopen this issue if this does not solve the problem.


Feature Suggestion: Relic Gifts Compendium

I know Relics arent something on the radar at the moment, but some Relic Gifts Powers (like Deadly Spark) are already in the System.
At the moment they are located in the Adventure Specific Actions with no relation to any Adventure at all.
For better understanding my Suggestion would be to Create an Extra Compendium for the RelicGifts to group them.
Maybe there is a good reason for not doing that. This is just a suggestion and can easily be overthrown or ignored :D

These are in the adventure specific actions for a reason, namely that they are in fact used by an adventure. When we handle relics properly we will migrate links to where they can all live. Until then that adventure, being something with premium content available for it, needed some level of system supported automation.

Alright thanks for the Info :)


Add bincount XLA support

Recover:
https://github.com/tensorflow/tensorflow/pull/56276
Rollback:
https://github.com/tensorflow/tensorflow/commit/3d3f01cd0193099173aaa20a96a68102518d6f80
Fixes https://github.com/tensorflow/tensorflow/issues/54479
/cc @majnemer @cheshire @MichaelHudgins

Let me know if you will push this directly from the old CL.

It was reintroduced in master with the old CL.


[VTK/vtk-m]  Update VTK to 9.0 and add vtk-m

closes #11135
most changes are extracted from #9960
should close the following:
closes #9211
closes #9200
closes #9213
closes #9023
might close #9322
vtk-m did not test any features.
vtk build with vtk[atlmfc,core,paraview,python,qt,vtkm]:x64-windows

Hi @Neumann-A
Could you please take a look at the regressions for vtk-dicom on linux and osx pipeline?

@NancyLi1013: Should be fine now but the baseline seems broken.

/azp run

/azp run

Could some of these patches be sent to our issue tracker? Some look weird or unnecessary (or have more proper fixes if there are things wrong) to me. Thanks.

@mathstuf

or have more proper fixes if there are things wrong

lets just say more general fixes. Most findModule.patches are with the background knowledge that we are within VCPKG and have certain things with 100% certainty available.
Some other things cannot be properly fixed since there is no way to tell find_library to be, what I would call, "configuration aware" (would require something like PATH_SUFFIXES_<CONFIG> with some defined search preference). So some MYLIB_LIBRARY can never have _RELEASE or _DEBUG equivalents since the library name is the same for both configurations on the other hand CMake requires this knowledge to generate targets with correct configuration aware INTERFACE_LINK_LIBRARIES.
The patches regarding vtk-m: I still don't know if this can even stand as its own I just felt like separating it since it was in ThirdParty
I also already opened up Issue on VTKs Gitlab which I thought relevant:
https://gitlab.kitware.com/vtk/vtk/-/issues/17878 (HDF5)
https://gitlab.kitware.com/vtk/vtk/-/issues/17876 (PEGTL)
https://gitlab.kitware.com/vtk/vtk/-/issues/17749 (External vtk-m, but this one should probably be closed)
If you have questions about any of the applied patches feel free to ask.

@Neumann-A Thanks. I've done a pass over the code here.


Add box drawing character constants

Add constants for the rest of the box drawing characters like this:
/// `│` `U+2502` Box drawings light vertical.
/// ```
/// # use dtee::*;
/// assert_eq!('│', LIGHT_VERTICAL);
/// assert_eq!('\u{2502}', LIGHT_VERTICAL);
/// ```
pub const LIGHT_VERTICAL: char = '\u{2502}';

Replace the box drawing characters used everywhere in code with the constants.
Example in the source code:
https://github.com/DecisionToolkit/dte/blob/cbd1fd408bf8608cce9a96f17bdb8870bd6bfab8/engine/src/model/characters.rs#L22-L30

If no one is working on this, I would like to give it a try.


Add indicator of caught status to sprites in evolution diagrams

Another possibility for the issue raised in #143. This would enable one to view the caught status of each mon in an evolutionary line by viewing the info for any mon in that line.

thanks for the feedback, @Rooschach! i'm actually going to close this issue and combine it with #143.


Update setAccessor argument documentation.

Coverage remained the same at 97.513% when pulling e9e5469405e826105376d7a512d9fe305c682cf4 on braddunbar:set-accessor-documentation into 41a9659c2fec92edd6cb616ce0df7d8e0fdf1adc on developit:master.

Goo catch! Thanks @braddunbar


Add yapfignore to ignore large and unnecessary files

Now 20s:
shanth:~/work/git/data (engprod1 %)$ time yapf -r -i -p --style=google util/ scripts/ import-automation/

real    0m20.748s
user    1m41.213s
sys     0m7.358s

Used to be 4m:

https://github.com/datacommonsorg/data/pull/761 increased it to 16m:

Thanks for the review!


Update generate-artifacts.yml

Each PR triggers the generate-artifacts.yml workflow. This workflow generates the artefacts (e.g. AASX file) for the respective samm models. However, if a PR does not contain an updated ttl-file (e.g. updating the readme), the workflow fails (see screenshot).
This PR fixes this issue.

Closes: #786

@jSchuetz88 LGTM (one remark -> # Copyright (c) 2023-2024 Contributors to the Eclipse Foundation -> only the start year is named)

Done

Don't want to be too piggy, but since this is code, does it fall under CC-BY-4.0?

You are right, done.


Some rules do not support interpolation

While migrating our codebase, I noticed that some rules do not support interpolation:
let gap = `px 8

let row = [%cx {|
  grid-gap: $(gap)
|}]

Results in invalid property value: $(gap)
Looking at the code, I don't see any differences in gridGap definition and, for example, marginBottom which support interpolation, so I am not sure what's the problem there.
https://github.com/rusty-key/styled-ppx/blob/a09a0ae84e044dcd5682607d1c660dbd0983d8ba/packages/ppx/test/native/bs-css/Css_Js_Core.rei#L611-L613
I also a case for SVG-related rules. For example:
fill: $(Color.Background.boxDarkAlpha);
stroke: $(Color.Background.boxDarkAlpha);

Disregard. Was testing on<EMAIL_ADDRESS>it's not an issue in 0.28


[Task] Implement solidity-coverage

Task Details
Try to implement the package solidity-coverage in the project
Additional Information
No response
Assigners
@larsberge
@Meiswinkel1991

@Meiswinkel1991 i want to work on this, can you give an overview?

@Meiswinkel1991 i want to work on this, can you give an overview?

The following problem presents itself:
The solidity-coverage package for hardhat is not possible to execute.
The following error occurs when running soldity-coverage with the command "yarn hardhat coverage":
"Error in plugin solidity-coverage: TypeError: Cannot read properties of undefined (reading 'match')"
If you need any further information, please feel free to ask us.


A11y_Visual Studio Code Web Extensions_Github_Description_DeveloperTool: Role assigned for 'Image' present under the text before associated with the comment shared by Thomus1664 is as link instead of button.

“Check out Accessibility Insights! - Identify accessibility bugs before check-in and make bug fixing faster and easier.”
 This bug should only be closed by TCS, C+AI Accessibility tester after verification of the fix
Open https://insiders.vscode.dev/github/microsoft/vscode-pull-request-github environment and login with git hub account.
tab to 'Github' and press enter.
tab to 'All Open' and press enter.
Tab to any pull request and press enter 'Description'.
Tab till 'Image' link and press enter.
Check role provide for 'Image' control is correct or not.

Actual:
Role assigned for 'Image' present under the text before associated with the comment shared by Thomus1664 is as link instead of button.
Expected:
Role assigned for 'Image' Control should be button.
User Impact:
Screen reader users will not get the correct information of thecontrol.
Attachment:

This is external user content that we just directly display without processing. Awaiting confirmation from the accessibility testers that this can be closed.

as discussed with SME this bug can be closed


Assert json does not contain some field

Is your feature request related to a problem? Please describe.
I'm use pactumjs for e2e test, I would like to verify that the response json does not contain some specific field, however, I could not found such a matcher.
Describe the solution you'd like
Add some kind of matcher to verify that a field does not exists in the response, eg.
 await pactum.spec()
            .post(`/api/foobar`)
            .withJson({})
            .expectStatus(200)
            .expectJson('data', notContain("deprecated_field"))
        ;

Release -  3.1.8
Docs -  https://pactumjs.github.io/api/matching/notIncludes.html


fix: disable GCing when exporting a new snapshot

Summary of changes
Changes introduced in this pull request:

Locally, I get disconnects and ChainExchange failures when the GC runs. Maybe the GC blocks DB access which causes failed p2p responses which leads to disconnecting peers.

Reference issue to close (if applicable)

Closes
Other information and links

Should it be disabled also during import? Or should even the GC task not start before the import is completed in Forest code directly?

I think the GC only starts after data has been imported. Not sure, thought.


Build(deps-dev): Bump webpack-merge from 5.8.0 to 5.9.0 (#4892)

Pull request opened by the merge tool on behalf of #4892

Merged in 43badc34d6a9ac741af710c4247691e570700ab7


merge code into the upstream project, svgedit

Merge method draw's improvements into svgedit, the upstream project

@memtech3 I wish it were as easy as that.


[Bug]: Content following a split image in PDF appears on wrong page.

Bug description
Steps to reproduce the problem:

Create a page with an image that will span more than 1 printed page
Add text below the image
Save as PDF

I seems the image is split correctly, but the destination page is not updated to reflect the additional pages created.
In the following screenshot, you can see the text should be placed on the page following the image.
SOURCE:

GENERATED:

Puppeteer version
19.2
Node.js version
16
npm version
8
What operating system are you seeing the problem on?
Linux
Configuration file
No response
Relevant log output
No response

Does it happen with the regular print to PDF dialog in the headful browser?

It is running in a headless vm, so I am not currently able to check.  I did not see any related bugs posted to chromium, so I posted it here.

Could you provide a mvce in a separate repo?

I believe this might have been fixed in the latest Chromium (there were quite a few regression with the new printing layout algorithm). Please re-open if still happens.

@OrKoN Thanks for the update, I will add a note after I review.

Yes, fixed in latest chromium.  💯

I spoke too soon.  Still broken.

@Flamenco can you provide a test page?


Integration Tests: Upgrade storybook from 2.35.3 to 3.2.0.alpha.11

This PR updates our Storybook integration tests to modern Storybook, and adds hierarchy to some of our stories to make sure Percy works with the upcoming Storybook 3.2 release.
It also adds Storybook addons to the config, to ensure they don't break Percy snapshots.

@thomashuston Relied on Prettier to do some reformatting for me here, and it was delightful. 👍

@fotinakis It's surprising that space you added wasn't managed by Prettier.  I'll take a look at that this week sometime.


update axe-core to 4.9.1

Update axe-core to the latest 4.9.1.

Released under version 9.0.0, thanks for the prompt to upgrade.

Thanks!


[Bug]: 'GuessTheColor' Game Errors

Give a brief about the bug discovered✍
There are many design bugs in this game. The major bug is the  heading is oversized to font size of 200% which is covering two times of scroll screen. Also, other items involved also too enhanced in sizing.
What is the expected behavior?
Clear and elegant design of the game.
Give a brief description to get the expect behaviour.
By working on the styling of this game, I can solves these bugs.
Sample
Current Design

Expected Updated Design

Are you contributing for a program?
GSSoC2023
Code of Conduct

[X] I follow CONTRIBUTING GUIDELINE of this project.

Hi @iamRabia-N , I have assigned this task to you. Kindly complete within 2 day. Good luck!

Hello, @panwar8279 I would like to work on this issue please assign it to me.


operator aerospike-kubernetes-operator-rhmp (3.1.0)

/retest

To re-test, you can simply close the PR and re-open it.  I've just done so.


Full Styling

Milestone - Full Styling
This pull request includes the following changes:

Add styles to the full web page
Improve the categories section functionality

Thank you for the feedback!

The issue is already solved! 😄👍

Hey @rloterh, thank you so much for your suggestions, I really appreciate it! 😄


Error building

I am running Ubuntu Server 20 on RPi3, getting following error while running npm run build:
npm ERR! code ELIFECYCLE
npm ERR! errno 137
npm ERR<EMAIL_ADDRESS>build: node build/build.js
npm ERR! Exit status 137
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>build script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
npm ERR! A complete log of this run can be found in:
npm ERR!     /home/ubuntu/.npm/_logs/2021-04-07T22_12_18_180Z-debug.log
Contents of /home/ubuntu/.npm/_logs/2021-04-07T22_12_18_180Z-debug.log:
0 info it worked if it ends with ok
1 verbose cli [ '/usr/bin/node', '/usr/bin/npm', 'run', 'build' ]
2 info using<EMAIL_ADDRESS>3 info using<EMAIL_ADDRESS>4 verbose run-script [ 'prebuild', 'build', 'postbuild' ]
5 info lifecycle<EMAIL_ADDRESS><EMAIL_ADDRESS>6 info lifecycle<EMAIL_ADDRESS><EMAIL_ADDRESS>7 verbose lifecycle<EMAIL_ADDRESS>unsafe-perm in lifecycle true
8 verbose lifecycle<EMAIL_ADDRESS>PATH: /usr/share/npm/node_modules/npm-lifecycle/node-gyp-bin:/home/ubuntu/iot/Mqtt2Mqtt/node_modules/.bin:/home/ub>9 verbose lifecycle<EMAIL_ADDRESS>CWD: /home/ubuntu/iot/Mqtt2Mqtt
10 silly lifecycle<EMAIL_ADDRESS>Args: [ '-c', 'node build/build.js' ]
11 silly lifecycle<EMAIL_ADDRESS>Returned: code: 137  signal: null
12 info lifecycle<EMAIL_ADDRESS>Failed to exec build script
13 verbose stack Error<EMAIL_ADDRESS>build: node build/build.js
13 verbose stack Exit status 137
13 verbose stack     at EventEmitter. (/usr/share/npm/node_modules/npm-lifecycle/index.js:332:16)
13 verbose stack     at EventEmitter.emit (events.js:198:13)
13 verbose stack     at ChildProcess. (/usr/share/npm/node_modules/npm-lifecycle/lib/spawn.js:55:14)
13 verbose stack     at ChildProcess.emit (events.js:198:13)
13 verbose stack     at maybeClose (internal/child_process.js:982:16)
13 verbose stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:259:5)
14 verbose pkgid<EMAIL_ADDRESS>15 verbose cwd /home/ubuntu/iot/Mqtt2Mqtt
16 verbose Linux 5.4.0-1028-raspi
17 verbose argv "/usr/bin/node" "/usr/bin/npm" "run" "build"
18 verbose node v10.19.0
19 verbose npm  v6.14.4
20 error code ELIFECYCLE
21 error errno 137
22 error<EMAIL_ADDRESS>build: node build/build.js
22 error Exit status 137
23 error Failed at the<EMAIL_ADDRESS>build script.
23 error This is probably not a problem with npm. There is likely additional logging output above.
24 verbose exit [ 137, true ]

Did you firstly try to run npm install command?

yes, npm install works fine

The error log you shown me isn't complete as I don't see what is causing it


Unable to install rust-src component on Windows 8.1

I installed rustup today with the intent of making it easier to set up all the component bits for racer and so on, but I'm having trouble installing the rust-src component. I get this every time:

I've tried this on both user and admin access, and same error either way.
Running: Windows 8.1, rustup 0.6.3 (a0e2132 2016-08-28), rustc stable-x86_64-pc-windows-msvc 1.12.0 (3191fbae9 2016-09-23), cargo 0.13.0-nightly (109cb7c 2016-08-19).

If you have an antivirus software, you may need to turn it off and try again. But before, you have to remove previous src directory.

Dupe of #771


Shiqiu/update index json0217

Update index.json for asc cli extension 0217 release

If this PR is for a new extension or change to an existing extension, use the following to try out the changes in this PR:
docker run -it microsoft/azure-cli:latest
export EXT=<NAME>
pip install --upgrade --target ~/.azure/cliextensions/$EXT "git+https://github.com/ShichaoQiu/azure-cli-extensions.git@shiqiu/updateIndexJson0217#subdirectory=src/$EXT&egg=$EXT"


Bot crashes on 3 Thumbnail Cards dialog choice prompt

message.json.txt
System Information

SDK Language: Node.js
SDK Version: 3.9.1
Development Environment: localhost

Issue Description
Bot crashes on simple thing: create 3 ThumbnailCards with just 1 button in each, add them as attachment to a message, then call builder.Prompts.choice(session, msg, buttons); and bot crashes and does not show me any buttons and unable to go to the next waterfall step.
If I try only 1 ThumbnailCard with 3 buttons in it - works fine, but they aligned vertically - not what I want - horizontal layout.
Code Example
My first waterfall step of my root dialog code:
[
    /**
     * @param {Session} session
     */
    function (session, args) {
        // Clear conversation data on new search - empty object
        session.conversationData = {};

        var buttons = ["Send Message", "New Search", "Agent"];
        var options = { listStyle: builder.ListStyle.button };
        var msg = new builder.Message(session).attachmentLayout(builder.AttachmentLayout.carousel);

        if(args && args.reprompt)
            msg.text("How can I help You with Your hotel search?");
        else
            msg.text("Hello there. How can I help You with Your hotel search today?");

        const cards = [
            new builder.ThumbnailCard(session).buttons([
                new builder.CardAction(session).title("Send Message").value("Send Message").type("imBack")
            ]),
            new builder.ThumbnailCard(session).buttons([
                builder.CardAction.openUrl(session, "http://app.selectrooms.co", "New Search")
            ]),
            new builder.ThumbnailCard(session).buttons([
                new builder.CardAction(session).title("Agent").value("Agent").type("imBack")
            ])
        ];
        msg.addAttachment(cards);

        builder.Prompts.choice(session, msg, buttons, options);
    },
...
]

Steps to Reproduce the Issue

Created carousel cards with 3 ThumbnailCards with just 1 button in each
User enters hi
Bot crashes and does not show buttons or cards

Expected Behavior
Show 3 buttons in one line with specified actions.
Actual Results
Error log in console:
ChatConnector: message received.
User `Bot` with Id: `default-bot` connected to bot!
ChatConnector: message received.
UniversalBot("*") routing "hi" from "emulator"
Session.beginDialog(/)
/ - waterfall() step 1 of 5
/ - Session.beginDialog(BotBuilder:prompt-choice)
.BotBuilder:prompt-choice - Session.send()
.BotBuilder:prompt-choice - Session.sendBatch() sending 1 message(s)
TypeError: Converting circular structure to JSON
    at JSON.stringify (<anonymous>)
    at addWrite (../Src/node_modules/botbuilder/lib/bots/ChatConnector.js:340:29)
    at ChatConnector.saveData (../Src/node_modules/botbuilder/lib/bots/ChatConnector.js:355:21)
    at ../Src/node_modules/botbuilder/lib/bots/UniversalBot.js:483:21
    at UniversalBot.tryCatch (../Src/node_modules/botbuilder/lib/bots/UniversalBot.js:503:13)
    at UniversalBot.saveStorageData (../Src/node_modules/botbuilder/lib/bots/UniversalBot.js:480:14)
    at Object.onSave (../Src/node_modules/botbuilder/lib/bots/UniversalBot.js:327:27)
    at Session.onSave (../Src/node_modules/botbuilder/lib/Session.js:584:22)
    at Session.sendBatch (../Src/node_modules/botbuilder/lib/Session.js:427:14)
    at Timeout.<anonymous> (../Src/node_modules/botbuilder/lib/Session.js:655:23)
    at ontimeout (timers.js:469:11)
    at tryOnTimeout (timers.js:304:5)
    at Timer.listOnTimeout (timers.js:264:5)
.BotBuilder:prompt-choice - ERROR: Converting circular structure to JSON
.BotBuilder:prompt-choice - Session.endConversation()
Session.sendBatch() sending 2 message(s)

P.S. Also msg converted to JSON with util.inspect(msg, {showHidden: true, depth: null, breakLength: 120}) attached.

Fixed the code:
        var msg = new builder.Message(session)
            .text(text)
            .attachmentLayout(builder.AttachmentLayout.carousel)
            .attachments(cards);

Changed addAttachment to attachments - works now.


[suggestion] Add this file is autogenerated into iroha_swarm output

Before #3864 I had no idea that our docker-compose.dev.* files are generated with iroha_swarm.
I suggest to add a comment like:
# This file is autogenerated with `iroha_swarm <used options>`

@0x009922 , what do you think?

I think it is a good idea!
Not sure about adding the exact options used, but why not. Seeing an exact seed might help.
Also I think it might be not always intended. What about enabling/disabling it with a flag like --disclaimer-header?

--disclaimer-header sounds fine


Buttons - odd behavior if you choose to open the linked item in a separate tab or window

Hi Augustine,
If you just click on the Help button from the Statistics page (see below), it opens up the document it is supposed to.  But if you Control-click and choose to open the linked file in a separate tab or window (from the contextual menu), it opens instead the old Help page: http://dai.cs.rutgers.edu/dai/s/help
This is the same from this page with the other buttons that were recently modified.  Choosing to open the linked item in a separate tab or window brings back what the link had before, e.g., a broken link in many cases.
Not sure why the old URLs are still hidden there and retrieved by trying to open in a separate tab or window.
But the same thing seems to happen systematically with buttons on the other page as well that were recently modified...

Many of the buttons work better now.   But the Acknowledgments and Credits button still has the above-described behavior, from all pages that have that button.  Just FYI.

Fixed

Some of these are still broken - same button broken both from the Sign Search and Utterance Search pages, if you attempt to open them in a new window:

Also - we should have a TERMS OF USE button on the Sign Bank page.
thanks.

I thought this had been fixed but this is still broken, from https://dai.cs.rutgers.edu/dai/s/Acknowledgments & Credits:

This problem still has not been fixed.


Jordan/pro 204 change founders

Can you include the deploy script as well?

Also, this looks like it overwrote the metadata renderer implementation – it should have overwrote the token implementation. Did the wrong contract get deployed or was the script writing to the wrong file?


debug/pe: test failing for Windows-arm

See build.golang.org windows-arm build failures.
Example build: https://build.golang.org/log/b861d37d4bb477daf73ed0b8b9de6dee5d44ef20
--- FAIL: TestDWARF (7.93s)
    file_test.go:399: main.main not found
--- FAIL: TestImportTableInUnknownSection (0.09s)
    file_test.go:544: unable to locate required file "atmfd.dll" in search path: exec: "atmfd.dll": executable file not found in %PATH%
FAIL
FAIL	debug/pe	12.391s

/cc @jordanrh1

--- FAIL: TestDWARF (7.93s) file_test.go:399: main.main not found --- FAIL: TestImportTableInUnknownSection (0.09s) file_test.go:544: unable to locate required file "atmfd.dll" in search path: exec: "atmfd.dll": executable file not found in %PATH% FAIL FAIL	debug/pe	12.391s

I am sure, the fix for this is part of #26148. Leaving for @jordanrh1
Alex

I'll take a look.

@jordanrh1 just a friendly ping. Any updates on this?

Looks like we can just skip that test. I'll send a CL. I don't think windows/arm has that DLL.

Correct, Windows IOT Core does not have atmfd.dll. Thank you for fixing.

TestDWARF is failing because of relocations. The test is expecting the runtime address of main.main to match the link-time address, but this does not hold up with relocatable binaries. You'll get a different address printed from a.exe each time you run it due to ASLR.
@alexbrainman What do you think about having a.exe subtract the module base address from the address of main.main, i.e. print the relative offset of main.main from module start?

@alexbrainman What do you think about having a.exe subtract the module base address from the address of main.main, i.e. print the relative offset of main.main from module start?

Sounds reasonable to me. Would like to send a change?
I am reopening this issues to track TestDWARF failure.
Alex

I get the same error on Windows 10, Version 1809, Build 17763.134. Does this test need additional packages installed?
--- FAIL: TestImportTableInUnknownSection (0.02s)
    file_test.go:613: unable to locate required file "atmfd.dll" in search path: exec: "atmfd.dll": executable file not found in %PATH%
FAIL
FAIL    debug/pe        5.053s

atmfd.dll is the Adobe Type Manager Font Driver. It may be present in an optional package.
@Alexbrainman is there another DLL that would work?

Thanks for your fix. I can confirm that your fix works on my machine, too.
PS C:\go> git show
commit ed7176e50b44567370d487796c02903a70f1f222 (HEAD)
...

PS C:\go\src> .\all.bat
Building Go cmd/dist using C:\go1.11
Building Go toolchain1 using C:\go1.11.

Building Go toolchain2 using go_bootstrap and Go toolchain1.
Building Go toolchain3 using go_bootstrap and Go toolchain2.
Building packages and commands for windows/amd64.

##### Testing packages.

...
ok      debug/dwarf     1.400s
ok      debug/elf       0.649s
ok      debug/gosym     2.650s
ok      debug/macho     0.860s
ok      debug/pe        4.871s
...

ALL TESTS PASSED

---
Installed Go for windows/amd64 in C:\go
Installed commands in C:\go\bin

I can confirm that it works on my machine, too.

SGTM. Thanks for checking. I just submitted 151137.
Alex

Now I realised that kernel32.dll should work too.

@jordanrh1 it looks like windows/arm builder still fails on TestImportTableInUnknownSection
https://build.golang.org/log/e37627b9aa1c02a85c1d9d6ba6123052184cdee0
--- FAIL: TestImportTableInUnknownSection (0.06s)
    file_test.go:610: unable to locate required file "atmfd.dll" in search path: exec: "kernel32.dll": executable file not found in %PATH%
FAIL
FAIL	debug/pe	12.768s

It appears that os/exec.LookPath could not find "kernel32.dll" in the %PATH%. I wonder why? kernel32.dll functions are used by Go in many places. Why it could not be found in the %PATH%? Perhaps os/exec.LookPath is broken? Can you investigate, please.
Thank you.
Alex

With the onecore refactoring effort, kernel32.dll was split into a multitude of other DLLs, two of which are kernelbase.dll and kernel32legacy.dll. kernel32.dll does not exist on onecore editions, except as a virtual entity for backwards compatibility. Some candidate DLLs that exist across all flavors of windows are combase.dll, cfgmgr32.dll, and ws2_32.dll.

Some candidate DLLs that exist across all flavors of windows are combase.dll, cfgmgr32.dll, and ws2_32.dll.

ws2_32.dll works for me. Please, try https://go-review.googlesource.com/c/go/+/151480
Thank you.
Alex

Verified that it works on ARM.
>pe.test.exe -test.v -test.run TestImportTableInUnknownSection
=== RUN   TestImportTableInUnknownSection
--- PASS: TestImportTableInUnknownSection (0.05s)
PASS

Verified that it works on ARM.

Thanks for checking. Just submitted CL 151480.
Alex


Sync Error - upload archive: upload send: EOF

What happened?
devspace sync fails with Sync Error on /path/to/files: upstream: apply changes: apply creates: upload archive: upload send: EOF.
Log showing the upload failures and then the Sync Error:
[info]   Start syncing
[done] √ Sync started on /Users/jessebye/repos/pronode <-> . (Pod: need-plantations/pronode-579d65f7dd-wz74v)
[info]   Upstream - Handling 1 removes
[info]   Upstream - Upload 1604 create changes (size 10177223)
[info]   Upstream - Retry upload because of error: EOF
[info]   Upstream - Upload 1604 create changes (size 10177223)
[info]   Upstream - Retry upload because of error: EOF
[info]   Upstream - Upload 1604 create changes (size 10177223)
[info]   Upstream - Retry upload because of error: EOF
[info]   Upstream - Upload 1604 create changes (size 10177223)
[info]   Upstream - Retry upload because of error: EOF
[info]   Upstream - Upload 1604 create changes (size 10177223)
[error]  Sync Error on /Users/jessebye/repos/pronode: upstream: apply changes: apply creates: upload archive: upload send: EOF

What did you expect to happen instead?
Local changes should have been uploaded with no error.
How can we reproduce the bug? (as minimally and precisely as possible)
Using devspace version 4.4.0
Try to use devspace sync
Observe the issue.
Local Environment:

Operating System: mac (Catalina)
Deployment method: kubectl apply
Devspace version: 4.4.0

Kubernetes Cluster:

Cloud Provider: aws
Kubernetes Version: version.Info{Major:"1", Minor:"14+", GitVersion:"v1.14.9-eks-c0eccc", GitCommit:"c0eccca51d7500bb03b2f163dd8d534ffeb2f7a2", GitTreeState:"clean", BuildDate:"2019-12-22T23:14:11Z", GoVersion:"go1.12.12", Compiler:"gc", Platform:"linux/amd64"}

Anything else we need to know?
n/a
/kind bug

I keep getting this error, too. I don't believe I have any local files open... It'd be helpful if devspace at least would tell which file it's erring out on.

One situation I think I can reproduce is if the target directory has files owned by root (and the container runs as another user). It'd be really helpful if the sync log would tell why the receiving process quit / errored out.  I fixed all the file permissions (best I can tell), but I still get
 info    Upstream - Retry upload because of error: EOF                                                                                2020-04-10T02:52:52-07:00
 info    Upstream - Upload 808 create changes (size 42367095)                                                                                2020-04-10T02:52:52-07:00
 info    Upstream - Retry upload because of error: EOF                                                                                2020-04-10T02:52:57-07:00
 info    Upstream - Upload 808 create changes (size 42367095)                                                                                2020-04-10T02:52:57-07:00

... endlessly.

@abh Thanks for trying to provide more details on this. We're really eager to fix this but cannot reproduce it so far. Is it possible for you to share a project with us including devspace.yaml, so we can get a better chance to reproduce this issue? If it is private code, happy to send you an NDA to ensure confidentiality you share code in a private git repository or fork.
If you can create a reproducible example project, the following information would also help to reproduce this:

devspace --version
Kubernetes provider: gke, eks, aks, minikube, docker kubernetes
kubectl version

Done -- I think the thing that makes the error message not go back to the client is when the files to upload exceed a certain size; this reproduces it for me. My cluster is remote, so if you have a local cluster you might need a bigger or more test.bin files.
https://github.com/abh/devspace-eof-test

I ran the test on digital ocean kubernetes; using DevSpace 4.11.1.
$ kubectl version
Client Version: version.Info{Major:"1", Minor:"18+", GitVersion:"v1.18.0-alpha.1.250+822a2de262372d", GitCommit:"822a2de262372db4fb11aa4d69389c0cdbd869aa", GitTreeState:"clean", BuildDate:"2019-12-31T07:20:47Z", GoVersion:"go1.13.5", Compiler:"gc", Platform:"darwin/amd64"}
Server Version: version.Info{Major:"1", Minor:"16", GitVersion:"v1.16.6", GitCommit:"72c30166b2105cd7d3350f2c28a219e6abcd79eb", GitTreeState:"clean", BuildDate:"2020-01-18T23:23:21Z", GoVersion:"go1.13.5", Compiler:"gc", Platform:"linux/amd64"}

Thanks @abh. I just ran it and I can reproduce it. I will try to investigate the cause of this now. May take some time.

TL;DR: to fix this for you: Just add this to your sync section within devspace.yaml:
excludePaths:
- .git/

Please confirm that this actually works for you as well.
To provide some background on this issue:
As @FabianKramm was already pointing out, the issue arises when files are being transferred by the sync and then they change. In this case the issue is the .git folder. While the sync is uploading the file, it changes locally due to processes in your IDE I assume (at least that was the case for me).
The reason why we couldn't reproduce this for the longest time is that our team generally has the best practice to add .git/ to .dockerignore and devspace init automatically adds patterns from .dockerignore to the excludePaths within the config. You can actually see that in our quickstart projects. Additionally, this error only occurs if the sync actually needs to sync
I will change the behavior of devspace init to always add .git/ to excludePaths, so this will become a default for new users. I will also add a hint to the docs to make sure users realize this issue.
Another thing I will add to the docs is that there is actually a very good way to get more details about sync errors:
devspace deploy                                                         # must deploy first to be able to sync
devspace sync --verbose --config=devspace.yaml    # start standalone sync for detailed output

This will show all files and errors directly and will only provide the sync output which makes it much easier to track down issues.
Thanks again to @jessebye for reporting this in the first place and to @abh for providing a reproducible example project.

I can reproduce it without anything changing (and without the .git) repository.
The key is the big file; without that you get the appropriate permission denied error on writing files.
I am guessing the correlation with .git might be a bunch of files marked read-only.

Ok... then I am not able to reproduce this. As soon as I add the .git folder to excludePaths, everything works fine. The big file is being uploaded into the container as well. No EOF issue for me anymore.
But even when you add .git/ to excludePaths and not just to upload/downloadExcludePaths, you are still experiencing the EOF issue?
If yes, please deploy the project and send me the output of this command:
devspace sync --verbose --config=devspace.yaml

oh, okay -- this is confusing, sorry!  Because I added the test.bin file to the repository then the repository .pack files are big too which makes the test look the same without and with the big file.
Kaniko also seems to (sometimes?) add the /app directory with improbable 777 permissions; I fixed that.
I think the error ("we can't sync the files, you did something wrong") is legitimate; the bug (as I see it) is the missing error message if the amount of data to upload is too big.
I force pushed a new version; either do a fresh clone or do this to clean up the .git repository size (it should just be 1 or 200k).
git remote update
git reset --hard origin/master
git reflog expire --expire-unreachable=all --all --expire=all
git gc --prune=now --aggressive

then run (as you know) devspace dev
In this case I get this (helpful!) error in the sync log:
 info    Upstream - Retry upload because of error: rpc error: code = Unknown desc = untar all: untarNext: create /app/.git/objects/pack/pack-1ad94d38bce3bce123782400dc37a91299ad4dd5.idx: open /app/.git/objects/pack/pack-1ad94d38bce3bce123782400dc37a91299ad4dd5.idx: permission denied   2020-04-10T16:56:44-07:00

(because of the 0444 permissions on those files and however the files are written). It says the upload / initial sync completed all the same.
Now run devspace run testfiles. It will sync this file file (because uploading 10MB works fine, it works with a much bigger file, too).
Okay, leave the big file in place and do a new deployment (devspace dev -d) and it will error out without a helpful error:
 info    Upstream - Retry upload because of error: EOF         2020-04-10T20:01:29-07:00

Without having looked at the code by guess is that the client gets disconnected on the error while uploading and doesn't get to read the error message. When there's less to upload this doesn't happen. To fix it you'd need to have the server (pod) side keep the connection open and let the client disconnect after reading the error; or some variation of that.

Ok great! Sorry I misunderstood at first. Thanks for clarifying this. I talked to @FabianKramm and discussed this with him. We can actually fix the error message and make it more helpful. We will also add a suggestion on how to fix it in the fatal message which will suggest to add the file to excludePaths. Additionally, I'll do what I wrote in the comment above regarding init and docs. Does that sounds good? Did I miss anything else?
PS: File permissions in kaniko can get messed up when snapshotMode: time (which is our default because of the faster builds). And you are right, this really just happens sometimes because as far as I understood it when playing with it, it depends on if previous layers have been cached. I saw that you already fixed this by setting snapshotMode: full in your example. This is the correct way to fix this. Unfortunately, kaniko project seems not to be fixing this. It has been an issue for a while and their README states "Note that these issues are currently theoretical only." although this seems odd because we had many users run into this issue with applications where permissions matter for execution (e.g. PHP): https://github.com/GoogleContainerTools/kaniko#mtime-and-snapshotting

We have .git excluded and are trying to sync only about 10M worth of files, but still experience this issue. The logs look something like this:
[info]   Upstream - Upload 1566 create changes (size 6542410)
[error]  Sync Error on /Users/jessebye/repos/trading-api/modules/service/target/classes: upstream: apply changes: apply creates: upload archive: upload send: EOF
[info]   Sync stopped
[info]   Restarting sync...

@jessebye Try moving the big files out of place and see if the rest works.  There's likely a permission error making the sync not work. The bug, as I have seen it, is not a problem syncing when it should have worked but "just" poor error reporting.

@abh ah, thanks. I had thought 10M was not very big, but I tried a folder with 8KB of files and saw the actual error was permissions-related. We are using jib to build the image, and the files in the container are owned by root. I suppose that will be a problem for devspace sync...
[info]   Upstream - Retry upload because of error: rpc error: code = Unknown desc = untar all: untarNext: create /app/classes/state_machines/deploy/connected_trading/main.json: open /app/classes/state_machines/deploy/connected_trading/main.json: permission denied

What I did for my use case is for development I use a different Dockerfile that makes the development environment files owned by the user the application is running as …
An alternative might be starting your app with su-exec or similar and letting the devspace tools run as root, I didn’t try that.

That seems reasonable. I do wonder if skaffold is able to do syncing with jib, and how it handles it?

@abh thanks so much for detailed description and error repository! I fixed the issue with the error message (you were correct the error message was not transferred anymore because the transport was closed already) and from the next devspace version onwards, always the correct error message will be displayed regardless of the size of the files.
@jessebye skaffold is doing a similar approach as we do regarding the sync, they basically run a kubectl cp (Code) for each file in the background with the same permissions and user as we do and if it does not work with devspace, chances are very good it won't work with skaffold either.
So I guess it will come down that you have to change the user the sync is running with and you have two options here I think:

The easiest and probably the best in your case is to change the active user of the pod, you can configure that in kubernetes like this

apiVersion: v1
kind: Pod
metadata:
  name: my-pod
spec:
  securityContext:
    runAsUser: 0
    runAsGroup: 0
  ...

In the case your pod does not need the code directly for the entrypoint, you can add a sidecar container with an empty dir that is root where you can sync to and mount the empty dir to both containers:

apiVersion: v1
kind: Pod
metadata:
  name: my-pod
spec:
  containers:
  - name: container1
     ...
     volumeMounts:
     - name: code
        mountPath: /mycodedirectory
  - name: newsidecarcontainer
     image: ubuntu
     command: ["sleep"]
     args: ["infinity"]
     volumeMounts:
     - name: code
        mountPath: /code
  volumes:
  - name: code
     emptyDir: {}

and in your devspace.yaml you define the new container as sync target:
version: v1beta9
images:
  ...
deployments:
  ...
dev:
  sync:
  - imageName: default
     containerName: newsidecarcontainer
     containerPath: /code

@FabianKramm thanks for the tips, we got it to work by setting the user/group to 0! 🎉

Looks like we got both specific cases solved, the error message has been improved in v4.12 and the docs contain a sync troubleshooting guide now. Closing this for now. Thanks again everyone for helping to narrow these issues down!


[data-plane]: Kafka Broker receiver: reject requests for wrong audience

As the Eventing OIDC feature track describes, each Addressable gets its own Audience. Since #3520 the Audience of a Broker will be exposed in its status, so sources can create OIDC tokens dedicated for this Audience.
When receiving an event, the kafka-broker-receiver must:

when the feature flag (see https://github.com/knative/eventing/issues/7174) is disabled:

no change in behavior

when the feature flag is enabled:

when no / no valid Authorization header is provided

decline the request with a 401 (The 401 (Unauthorized) status code indicates that the request has not been applied because it lacks valid authentication credentials for the target resource. (https://www.rfc-editor.org/rfc/rfc9110#name-401-unauthorized))

when a valid Authorization header is provided

check, if the provided OIDC tokens Audience aligns with the Brokers audience

If if does not align: decline the request with a 401
If it aligns: no change in behavior

Additional Information:

requires #3573 to verify a token
Currently in draft state, as this this maybe can be done in #3577

Done in #3577


I don´t know where is the oauth token

Hello, im using your repo but idk where is the oauth token, i enter in this page https://twitchtokengenerator.com/ but i dont find the oauth token.

Hi.
You can use https://twitchtokengenerator.com/ to generate the tokens, follow these steps:

Go to the website
Click "Custom Scope Token"
Scroll to the bottom, and click the green "Generate Token!" button, then "Authorize" on Twitch
You will now return to the website, complete a captcha, and see the token appear

You will need to copy the ACCESS TOKEN and CLIENT ID and use both of them in your Timbot config.


Don't pass locale on to plausible.io

Hi, we just faced an issue and believe that this fix might be helpful.
Initial Setup:

We use plausible.io and next.js and deploy to vercel.com
We use withPlausibleProxy to proxy the event API "/api/event"

Change:

We enabled i18n routing

Issue:

Since a couple of hours (around 10h) we get no analytics data from the website
The developer console shows an HTTP 404 response from "/api/event"
There has been no recent update to next.js or next-plausible. But a recent change enabled the i18n routing.

Possible fixes:

Option 1: Removing withPlausibleProxy changes the call from  "/api/event" to  "plausible.io/api/event" which then returns an HTTP 200 and data arrives at the plausible dashboard
Option 2: We added custom rewrites and set locale: false as described in next rewrites

async rewrites() {
            return [
                {
                    source: '/js/script.js',
                    destination: 'https://plausible.io/js/plausible.js',
                    locale: false,
                },
                {
                    source: '/api/event',
                    destination: 'https://plausible.io/api/event',
                    locale: false,
                },
            ]
        },

This PR would apply the second option to next-plausible. If the change is okay, then I still might need some support in adding a test for this issue.

Hi @liebharc,
I am trying to reproduce this but I can't find a way. Can you please share your entire next.config.js file?
Thanks!

Hi @4lejandrito , thanks for the quick response. This is our current next.config.js.
/* eslint-disable */
/** @type {import('next').NextConfig} */

const { PHASE_DEVELOPMENT_SERVER } = require('next/constants')
const { createSecureHeaders } = require('next-secure-headers')
const { withPlausibleProxy } = require('next-plausible')

module.exports = (phase) => {
    function addDevRule(scriptSrc) {
        if (phase === PHASE_DEVELOPMENT_SERVER) {
            scriptSrc.push("'unsafe-eval'") // Allow react reloads on file change
        }

        return scriptSrc
    }

    return withPlausibleProxy()({
        reactStrictMode: true,
        compress: true,
        images: {
            // These are the values documented by Material UI: https://mui.com/customization/breakpoints/
            deviceSizes: [600, 900, 1200, 1536],
        },

        i18n: {
            locales: ['en', 'de'],
            defaultLocale: 'en',
            localeDetection: true,
        },
        async rewrites() {
            return [
                {
                    source: '/js/script.js',
                    destination: 'https://plausible.io/js/plausible.js',
                    locale: false,
                },
                {
                    source: '/api/event',
                    destination: 'https://plausible.io/api/event',
                    locale: false,
                },
            ]
        },
        async headers() {
            return [
                {
                    source: '/(.*)',
                    headers: createSecureHeaders({
                        contentSecurityPolicy: {
                            directives: {
                                defaultSrc: ["'none'"],
                                base: ["'self'"],
                                formAction: ["'self'", '*.twitter.com'],
                                prefetchSrc: ["'self'"],
                                connectSrc: [
                                    "'self'",
                                    'noembed.com',
                                    '*.amazonaws.com',
                                    '*.cloudfront.net',
                                    'plausible.io',
                                    'api.emailjs.com'
                                ],
                                scriptSrc: addDevRule([
                                    "'self'",
                                    'plausible.io',
                                    '*.vercel.app',
                                    "'sha256-/6SBPqW+GW+//4nlXX6Y1nR9dWlh0gsQJ6KK71djH6A='",
                                    'www.youtube.com',
                                    'platform.twitter.com',
                                    '*.twimg.com',
                                ]),
                                styleSrc: [
                                    "'self'",
                                    'https://fonts.googleapis.com',
                                    "'unsafe-inline'",
                                    'platform.twitter.com',
                                    'data:',
                                ],
                                imgSrc: [
                                    "'self'",
                                    'data:',
                                    'blob:',
                                    'i.ytimg.com',
                                    'platform.twitter.com',
                                    '*.twimg.com',
                                ],
                                fontSrc: [
                                    "'self'",
                                    'https://fonts.googleapis.com',
                                ],
                                frameSrc: ['*'],
                                mediaSrc: ['*'],
                                contentSrc: [
                                    "'self'",
                                    '*.amazonaws.com',
                                    '*.cloudfront.net',
                                    '*.vercel.app',
                                    'plausible.io',
                                    'api.emailjs.com',
                                ],
                            },
                        },
                    }),
                },
            ]
        },
    })
}

Which version of next-plausible are you using?

"next": "12.0.2", "next-plausible": "^3.1.1",
We have been on 3.0.1 earlier today and updated to see if it resolves the issue. But updating without the workaround which is found in our next config had no success.

I've published<EMAIL_ADDRESS>with the option to log the rewrites (https://github.com/4lejandrito/next-plausible/commit/358334811dfdee5f4d27eb9f89a0040dbcc88f0d). It would be super helpful If you could upgrade and run your app with the environment variable NEXT_PLAUSIBLE_DEBUG=true and send me the output of that log. That might help me see what's going on.

Thanks a lot. That's impressively quick feedback :). Here is the output:
18:14:28.948	plausibleRewrites = [
18:14:28.949	{
18:14:28.949	source: '/js/script.js',
18:14:28.949	destination: 'https://plausible.io/js/plausible.js'
18:14:28.949	},
18:14:28.949	{
18:14:28.949	source: '/js/script.exclusions.js',
18:14:28.949	destination: 'https://plausible.io/js/plausible.exclusions.js'
18:14:28.949	},
18:14:28.949	{
18:14:28.950	source: '/js/script.exclusions.local.js',
18:14:28.950	destination: 'https://plausible.io/js/plausible.exclusions.local.js'
18:14:28.950	},
18:14:28.950	{
18:14:28.950	source: '/js/script.exclusions.local.manual.js',
18:14:28.950	destination: 'https://plausible.io/js/plausible.exclusions.local.manual.js'
18:14:28.950	},
18:14:28.950	{
18:14:28.950	source: '/js/script.exclusions.local.manual.outbound-links.js',
18:14:28.950	destination: 'https://plausible.io/js/plausible.exclusions.local.manual.outbound-links.js'
18:14:28.950	},
18:14:28.950	{
18:14:28.951	source: '/js/script.exclusions.local.outbound-links.js',
18:14:28.951	destination: 'https://plausible.io/js/plausible.exclusions.local.outbound-links.js'
18:14:28.951	},
18:14:28.951	{
18:14:28.951	source: '/js/script.exclusions.manual.js',
18:14:28.951	destination: 'https://plausible.io/js/plausible.exclusions.manual.js'
18:14:28.951	},
18:14:28.951	{
18:14:28.951	source: '/js/script.exclusions.manual.outbound-links.js',
18:14:28.951	destination: 'https://plausible.io/js/plausible.exclusions.manual.outbound-links.js'
18:14:28.952	},
18:14:28.952	{
18:14:28.952	source: '/js/script.exclusions.outbound-links.js',
18:14:28.952	destination: 'https://plausible.io/js/plausible.exclusions.outbound-links.js'
18:14:28.952	},
18:14:28.953	{
18:14:28.953	source: '/js/script.local.js',
18:14:28.953	destination: 'https://plausible.io/js/plausible.local.js'
18:14:28.953	},
18:14:28.953	{
18:14:28.953	source: '/js/script.local.manual.js',
18:14:28.953	destination: 'https://plausible.io/js/plausible.local.manual.js'
18:14:28.953	},
18:14:28.953	{
18:14:28.954	source: '/js/script.local.manual.outbound-links.js',
18:14:28.954	destination: 'https://plausible.io/js/plausible.local.manual.outbound-links.js'
18:14:28.954	},
18:14:28.954	{
18:14:28.954	source: '/js/script.local.outbound-links.js',
18:14:28.954	destination: 'https://plausible.io/js/plausible.local.outbound-links.js'
18:14:28.954	},
18:14:28.954	{
18:14:28.954	source: '/js/script.manual.js',
18:14:28.954	destination: 'https://plausible.io/js/plausible.manual.js'
18:14:28.954	},
18:14:28.955	{
18:14:28.955	source: '/js/script.manual.outbound-links.js',
18:14:28.955	destination: 'https://plausible.io/js/plausible.manual.outbound-links.js'
18:14:28.955	},
18:14:28.955	{
18:14:28.956	source: '/js/script.outbound-links.js',
18:14:28.956	destination: 'https://plausible.io/js/plausible.outbound-links.js'
18:14:28.956	},
18:14:28.956	{
18:14:28.956	source: '/api/event',
18:14:28.956	destination: 'https://plausible.io/api/event'
18:14:28.956	}
18:14:28.956	]

It looks quite alright to me. Also, I recognized something, which makes me wonder if the issue isn't somewhere else. I'll sum that up and sent another update in a couple of minutes.

So the thing is, that the issue only appears on vercel.com. If I build it locally (both on Windows and Linux) then it works fine. In particular, there are no errors when I load the page. Initially I thought this is just because analytics is disabled on localhost. But I'm also able to access "/api/event" and I get a message from plausible there ("Oops! There's nothing here"). Pushing the same code to vercel.com and I see a 404 in the Chrome network debug tools for "/api/event" if I open any page. Accessing "/api/event" directly and it goes to our page's 404.
With the workaround described above, it works correctly on vercel.com as well. However, that means, that the issue only appears in combination with vercel.com and thus might be on their side.
So possibly the change described in this PR is helpful. But then we can't test it in a local deployment. But perhaps this fix might just work around an issue which exists on vercel.com?

That's a really helpful analysis. I'll test on vercel myself and see if I can reproduce it. I'll keep you updated during the weekend.
Thanks a lot @liebharc!

I think I found the root cause: https://stackoverflow.com/questions/69081549/rewrites-not-working-on-vercel-in-production-nextjs.
Using /api seems not to be allowed on Vercel. I'll consider using something else by default, but for now, you can fix this by specifying a subdirectory to withPlausibleProxy:
withPlausibleProxy({subdirectory: 'ext'})

This will load the script from /ext/js/script.js and push the events to /ext/api/event. You can see it working at https://proxy-locale-alejandro.vercel.app.

Neat, works like a charm. @4lejandrito, you're the best :). Thanks a lot for your help!

Hi @liebharc,
I published<EMAIL_ADDRESS>to support vercel out of the box. You can now get rid of the workaround I gave you yesterday and just use:
return withPlausibleProxy()({

The script will be proxied from /proxy/api/event. You can replace proxy with whatever you want by passing the subdirectory but it is optional.
I updated https://proxy-locale-alejandro.vercel.app/ to use the latest version and it works like a charm without having to specify subdirectory anymore.
Thanks for reporting this!