feat: add a new regextest function and deprecate regexmatch

Motivation
The regexmatch function only matches exact strings because it adds the ^ and $ special characters to every pattern.
This results in the following test failing:
test("not exact", () => expect(parseEval('regexmatch("what", "what are you doing?")')).toEqual(true));

Solution

First solution
Stop adding the delimiters (^ and $) to every pattern:
 export const regexmatch = new FunctionBuilder("regexmatch")
        .add2("string", "string", (pattern: string, field: string) => {
            if (!pattern.startsWith("^") && !pattern.endsWith("$")) pattern = "^" + pattern + "$";
//          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
            return !!field.match(pattern);
        })

Added a new function called regextest that matches javascript's test function.
Also, deprecated regexmatch to prepare for a major-version-change removal and update the docs to make clear what the function does.
Considerations
~This is probably a breaking change since people might be expecting to have the incorrect behavior, but I think a patch is ok.~
Cheers
This is an awesome plugin! Happy to contribute more to it.

I agree with the value of not always doing $ and ^ for every match, but breaking changes are really rough - would adding a new method work instead? Such as regexfind or regexinmatch or something similar.

Would adding a new method work instead?

Yes, @blacksmithgu ! That makes sense. However, I would suggest updating the docs for regexmatch and deprecating it to avoid people relying on its behavior in the future and potentially decommissioning it in a major version change.

Such as regexfind or regexinmatch or something similar.

There is another small issue with regexmatch, its name. I think it should be regextest since the matches are discarded by !!field.match(pattern); and it is more close in nature to test.
Therefore, should we use regextest? I'll update the PR later today.

@blacksmithgu let me know how you feel about the latest changes!

Sorry for the delay - was out for Thanksgiving. Looks good to me.


[BUG] Stryker badge is KO since the rename of the repository

Describe the bug
The stryker badge is not updated.
Expected behavior
The stryker badge should indicate the mutant score.

I enabled on the Stryker board this repository so it can communicate with the Stryker GitHub action.
I changed the secret for the Stryker board to authenticate.
I checked the badge in the readme and it is already up-to-date.
We just have to wait for a next release to see if Stryker is now updating the badge.

The badge is now working.


Token expiration

How can I set the expire time of the token to 7 days or greater?
I've added JWT_AUTH = {} dictionary on my djangoproject.settings module and changed the 'JWT_EXPIRATION_DELTA': datetime.timedelta(days=7) with no result. I'had also set 'JWT_VERIFY': True but the token expire in few minutes :(

Did you figure out what was wrong?

Hi @jpadilla, no :(
Do you have the same issue?

@FabrizioA did you set JWT_REFRESH_EXPIRATION_DELTA ?

This is duplicated of #92 closing


Metal multi-pass support

Fixes vkQuake:

PR checklist:

[x] make succeeds (on *nix)
[x] make reftests succeeds
[x] tested examples with the following backends:
[ ] rustfmt run on changed code

TODO: need to fix Dolphin

Everything works now :tada: , and this PR should be ready to land.
A small perf regression is expected because of disabled RP caching, but this is the only path forward now.

Thanks for the review! All notes are addressed now.
Bors r=grovesNL

On Sep 8, 2018, at 19:34, Josh Groves<EMAIL_ADDRESS>wrote:
@grovesNL commented on this pull request.
In src/backend/metal/src/command.rs:

   self.state.framebuffer_inner = framebuffer.inner.clone();

   //self.state.framebuffer_inner = framebuffer.inner.clone();

nit: remove this comment
In src/backend/metal/src/device.rs:

@@ -1128,7 +1189,7 @@ impl hal::Device for Device {
None => {
// TODO: This is a workaround for what appears to be a Metal validation bug
// A pixel format is required even though no attachments are provided

           if pass_descriptor.main_pass.attachments.is_empty() {

           if subpass.colors.is_empty() {

Should we check depth_stencil here too?
In src/backend/metal/src/device.rs:

 ) -> Result<n::Framebuffer, FramebufferError>

 where
     I: IntoIterator,
     I::Item: Borrow<n::ImageView>
 {

   let descriptor = metal::RenderPassDescriptor::new().to_owned();

   descriptor.set_visibility_result_buffer(Some(&self.shared.visibility.buffer));

   descriptor.set_render_target_array_length(extent.depth as NSUInteger);

   let mut inner = n::FramebufferInner {

       extent,

       aspects: format::Aspects::empty(),

       colors: SmallVec::new(),

       depth_stencil: None,

   };

   /*

Should this block just be removed entirely, or are we planning to revisit it soon?
In src/backend/metal/src/device.rs:

                           let mtl_format = self.private_caps.map_format(format).expect("Unable to map color format!");

                           (mtl_format, Channel::from(format.base_format().1))

                       })

                       .collect(),

                   depth_stencil: sub.depth_stencil

                       .map(|&(id, _)| {

                           self.private_caps.map_format(

                               attachments[id].format.expect("No depth-stencil format provided")

                           ).expect("Unable to map depth-stencil format!")

                       }),

               },

           }

       })

       .collect();

   // sprinkle load operations

This makes sense, but might be useful to expand to the comments here a bit just to explain the intent. Also where do we distinguish between loadOp and stencilLoadOp (and store) for mixed depth stencil attachments?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.


Support for 7-segment displays.

Hi Bartosz,
Thank you for the library.
I am using it to control 7-segment displays like these:

8-digit complete board
6-digit clock display

This pull request adds three new functions (and an example):

void setScanLimit(uint8_t level);
Useful when the display has less than 8 digits.
void setDecode(uint8_t mask);
Makes it really easy to display numbers on the 7-segment displays.
void setDigit(uint16_t digit, uint8_t value, bool dot = false);
Makes it possible to set a single digit in the frameBuffer.

I hope you find it useful.
Best regards, Søren.

Hi Søren,
I have checked your code and it looks fine. Before I merge it I have one question to ask.
Could you tell me why did you device to use my library in place of the standard one? I've optimized mine to be able to run multiple modules as a single display. I never had problems with refresh rate when using single displays (such as this 8x7seg or the clock display). My biggest setup is 8x(8x8) with 50 ms refresh rate and on that one I could see the lag.
Regards,
Bartosz

Hi Bartosz,
Thank you for replying.
I am not sure which library you refer to as "the standard one". I have used https://github.com/wayoda/LedControl before, but it does not compile for the ESP8266 without a patch.
I also liked that your library used hardware SPI and the MIT License.
/Thing

Yes, I consider LedMatrix to be the default one. I have used it before I got tired of the slowness. Must have patched it myself or they broke it after I have stopped using it.
Well, okay. I'm wasn't preparing a release so while I will merge this the version may stay the same for some time.
Cheers,
Bartosz

Thanks!


[MPQEditor] Implement 'dispose' and 'onViewMessage'

This commit implements 'dispose' and 'onViewMessage' for manual mixed precision quantization task.
Its correctness is tested in https://github.com/Samsung/ONE-vscode/pull/1530
Fresh draft: https://github.com/Samsung/ONE-vscode/pull/1530
Full draft: https://github.com/Samsung/ONE-vscode/pull/1505
Related: https://github.com/Samsung/ONE-vscode/issues/1491
ONE-vscode-DCO-1.0-Signed-off-by: s.malakhov<EMAIL_ADDRESS>

Hi, this is another UI feedback.
It's not related to this PR, but rather related to the draft #1505.

It seems that : In the (1) area, it decides the default quantization configuration and (2) area specifies the per-node(layer) quantization configuration.
At first look, I didn't understand what the (1) area would do. I propose to add 'Set default quantization' 'Set specific layer's quantization' in each areas.

Hi, this is another UI feedback. It's not related to this PR, but rather related to the draft #1505.

It seems that : In the (1) area, it decides the default quantization configuration and (2) area specifies the per-node(layer) quantization configuration.
At first look, I didn't understand what the (1) area would do. From my point of view, I propose to add 'Set default quantization' 'Set specific layer's quantization' in each areas.

@dayo09
Thank you. I'll try to fix it in the draft at first.

It seems that : In the (1) area, it decides the default quantization configuration and (2) area specifies the per-node(layer) quantization configuration.

@dayo09
To fix layout it needs to edit media files, so may be we can handle it in another PR?

@stamalakhov

To fix layout it needs to edit media files, so may be we can handle it in another PR?

Sure :-D Thanks a lot :-D


Always load scope/shared without guard.

With the addition of webAnimations1BonusSrc files, it is useful for the
web-animations target to load the polyfill scopeSrc and sharedSrc files
whether or not a native web animations implementation exists. This
patch moves the scopeSrc and sharedSrc files outside of the
webAnimations1Src guard, as is done in the web-animations-next target.
This allows the build* functions in Gruntfile.js to be simplified and
merged.

Nice simplification!
lgtm


Customizer has select borders enabled

Comment by @aPoCoMiLogin
Can confirm (not sure how that slipped through, to be honest).

In what browser? testing in Chrome Canary no issues.

The tooltips were merged in master so the bug currently only shows on staging. Bug is reproducible for me in both Chrome stable and canary.

We should so some kind of focus/active indicator for proper a11y. but, this is quite large. Imo, it needs restyling appear better.

In some project we differ between mouse and keyboard interactions. Only on keyboard interactions (e.g. tab, arrow keys, space ...) we show a outline on focused elements. Maybe that could be interesting for mdl?

I think we should always show some kind of indicator. Just because you use a keyboard more doesn't mean you are someone vision impaired. You could  also be  able to use a mouse just  fine, but not be able to tell what is selected easily.

We have a tooltip for hover and the selector for click. I would be my preferred solution way to only show the border on keyboard interaction. I’ll look into this.

@surma they are some pitfalls on differ between keyboard and mouse interactions.
e.g. SPACE on a button or radio sends first a KeyboardEvent and after that MouseEvent
We wrote a small wrapper for events, that handles these pitfalls. If you are interested, let me know.

@tschiela Definitely interested :) Thanks for offering.

@ surma link to gist
feel free for suggestions or improvements

Thanks, @tschiela. I am probably gonna do a bigger accessibility pass on the customizer, so this is going to take a while :)


[typescript-migration] WIP: date_utils.js

name: Pull Request
about: Create a pull request to improve this repository
Description
Linked issue:  https://github.com/Hacker0x01/react-datepicker/issues/4700
To reviewers

An important topic to discuss.
Some of our codebase is using the date-fns violating their types
For example, toDate has the following implementation inside date-fns library
function toDate(argument) {
  const argStr = Object.prototype.toString.call(argument);

  // Clone the date
  if (
    argument instanceof Date ||
    (typeof argument === "object" && argStr === "[object Date]")
  ) {
    // Prevent the date to lose the milliseconds when passed to new Date() in IE10
    return new argument.constructor(+argument);
  } else if (
    typeof argument === "number" ||
    argStr === "[object Number]" ||
    typeof argument === "string" ||
    argStr === "[object String]"
  ) {
    // TODO: Can we get rid of as?
    return new Date(argument);
  } else {
    // TODO: Can we get rid of as?
    return new Date(NaN);
  }
}

and as you can see, else conditions are under question because here is the type counterpart
export declare function toDate<DateType extends Date>(
  argument: DateType | number | string,
): DateType;

The function shouldn't accept null or undefined, and our Date constructor newDate can return null, and then this null is used in several places violating the toDate's type contract.
So, should I suppress ts errors and leave everything as is it will save the status quo, but in the future may cause problems related to date-fns if they remove undocumented pieces of code
OR
I'll add some default values for such cases, and we won't violate ts contracts, but it may break someones business logic and we should release this under a major version
Contribution checklist

[x] I have followed the contributing guidelines.
[x] I have added sufficient test coverage for my changes.
[x] I have formatted my code with Prettier and checked for linting issues with ESLint for code readability.

I'll add some default values for such cases, and we won't violate ts contracts, but it may break someones business logic and we should release this under a major version

I'm curious to see what happens with the existing tests if we change the default values. If there's indeed major changes we can roll out a breaking change, I think it's good to adhere to the logic as documented by date-fns and not depend on something that not officially supported.

I'm curious to see what happens with the existing tests if we change the default values. If there's indeed major changes we can roll out a breaking change, I think it's good to adhere to the logic as documented by date-fns and not depend on something that not officially supported.

Here is the log of failed tests after all types of alignment that I did in this commit
I'm not sure that my experience with the library is enough to safely say if these tests indicate any breaching changes
Summary of all failing tests
 FAIL  test/date_utils_test.test.js
  ● date_utils › newDate › should return null for invalid value passed

    expect(received).toBeNull()

    Received: 2024-04-19T18:21:21.514Z

      57 |   describe("newDate", () => {
      58 |     it("should return null for invalid value passed", () => {
    > 59 |       expect(newDate("21123asd")).toBeNull();
         |                                   ^
      60 |     });
      61 |   });
      62 |

      at Object.toBeNull (test/date_utils_test.test.js:59:35)

  ● date_utils › isMonthDisabled › should be enabled if after maxDate but same month

    expect(received).toBe(expected) // Object.is equality

    Expected: false
    Received: true

      482 |     it("should be enabled if after maxDate but same month", () => {
      483 |       const day = newDate("2023-01-02");
    > 484 |       expect(isMonthDisabled(day, { maxDate: newDate("2023-01-01") })).toBe(
          |                                                                        ^
      485 |         false,
      486 |       );
      487 |     });

      at Object.toBe (test/date_utils_test.test.js:484:72)

  ● date_utils › isYearDisabled › should be enabled by default

    expect(received).toBe(expected) // Object.is equality

    Expected: false
    Received: true

      561 |
      562 |     it("should be enabled by default", () => {
    > 563 |       expect(isYearDisabled(year)).toBe(false);
          |                                    ^
      564 |     });
      565 |
      566 |     it("should be enabled if on the min date", () => {

      at Object.toBe (test/date_utils_test.test.js:563:36)

  ● date_utils › isYearDisabled › should be enabled if on the max date

    expect(received).toBe(expected) // Object.is equality

    Expected: false
    Received: true

      575 |
      576 |     it("should be enabled if on the max date", () => {
    > 577 |       expect(isYearDisabled(year, { maxDate: newYearsDay })).toBe(false);
          |                                                              ^
      578 |     });
      579 |
      580 |     it("should be disabled if after the max date", () => {

      at Object.toBe (test/date_utils_test.test.js:577:62)

  ● date_utils › isYearDisabled › should be enabled if in included dates

    expect(received).toBe(expected) // Object.is equality

    Expected: false
    Received: true

      590 |
      591 |     it("should be enabled if in included dates", () => {
    > 592 |       expect(isYearDisabled(year, { includeDates: [newYearsDay] })).toBe(false);
          |                                                                     ^
      593 |     });
      594 |
      595 |     it("should be disabled if not in included dates", () => {

      at Object.toBe (test/date_utils_test.test.js:592:69)

  ● date_utils › isYearDisabled › should be enabled if date filter returns true

    expect(received).toBe(expected) // Object.is equality

    Expected: false
    Received: true

      600 |     it("should be enabled if date filter returns true", () => {
      601 |       const filterDate = (d) => isSameYear(d, newYearsDay);
    > 602 |       expect(isYearDisabled(year, { filterDate })).toBe(false);
          |                                                    ^
      603 |     });
      604 |
      605 |     it("should be disabled if date filter returns false", () => {

      at Object.toBe (test/date_utils_test.test.js:602:52)

 FAIL  test/year_picker_test.test.js
  ● YearPicker › should not return disabled class if current date is after maxDate but same year

    expect(received).toBe(expected) // Object.is equality

    Expected: false
    Received: true

      185 |         "react-datepicker__year-text--disabled",
      186 |       ),
    > 187 |     ).toBe(false);
          |       ^
      188 |   });
      189 |
      190 |   it("should return disabled class if specified excludeDate", () => {

      at Object.toBe (test/year_picker_test.test.js:187:7)

  ● YearPicker › should return disabled class if specified includeDate

    expect(received).toBe(expected) // Object.is equality

    Expected: false
    Received: true

      250 |       expect(
      251 |         year.classList.contains("react-datepicker__year-text--disabled"),
    > 252 |       ).toBe(false);
          |         ^
      253 |     }
      254 |     for (let i = pos + 1; i < 12; i++) {
      255 |       const year = yearTexts[i];

      at Object.toBe (test/year_picker_test.test.js:252:9)

  ● YearPicker › keyboard-selected › should set the date to the selected year of the previous period when previous button clicked

    RangeError: Invalid time value

      219 |     localeObj = getLocaleObject(getDefaultLocale());
      220 |   }
    > 221 |   return format(date, formatStr, {
          |                ^
      222 |     locale: localeObj,
      223 |     useAdditionalWeekYearTokens: true,
      224 |     useAdditionalDayOfYearTokens: true,

      at format (node_modules/date-fns/format.js:361:11)
      at Object.formatDate (src/date_utils.ts:221:16)
      at Object.formatDate (test/year_picker_test.test.js:560:20)

  ● YearPicker › keyboard-selected › should set the date to the selected year of the next period when next button clicked

    RangeError: Invalid time value

      219 |     localeObj = getLocaleObject(getDefaultLocale());
      220 |   }
    > 221 |   return format(date, formatStr, {
          |                ^
      222 |     locale: localeObj,
      223 |     useAdditionalWeekYearTokens: true,
      224 |     useAdditionalDayOfYearTokens: true,

      at format (node_modules/date-fns/format.js:361:11)
      at Object.formatDate (src/date_utils.ts:221:16)
      at Object.formatDate (test/year_picker_test.test.js:594:20)

 FAIL  test/multiple_selected_dates.test.js
  ● Multiple Dates Selected › should handle text format for two selected dates

    expect(received).toBe(expected) // Object.is equality

    Expected: "01/01/2024, 01/15/2024"
    Received: "01/01/2024"

      40 |     });
      41 |
    > 42 |     expect(datePicker.getByRole("textbox").value).toBe(
         |                                                   ^
      43 |       "01/01/2024, 01/15/2024",
      44 |     );
      45 |   });

      at Object.toBe (test/multiple_selected_dates.test.js:42:51)

  ● Multiple Dates Selected › should handle text format for more than two selected dates

    expect(received).toBe(expected) // Object.is equality

    Expected: "01/01/2024 (+2)"
    Received: "01/01/2024"

      55 |     });
      56 |
    > 57 |     expect(datePicker.getByRole("textbox").value).toBe("01/01/2024 (+2)");
         |                                                   ^
      58 |   });
      59 | });
      60 |

      at Object.toBe (test/multiple_selected_dates.test.js:57:51)

 FAIL  test/month_test.test.js
  ● Month › should call the provided onDayMouseEnter (Mouse Event) function

    expect(jest.fn()).toHaveBeenLastCalledWith(...expected)

    Expected: 2023-12-31T22:00:00.000Z

    Number of calls: 0

      311 |     fireEvent.mouseEnter(month);
      312 |
    > 313 |     expect(onDayMouseEnterSpy).toHaveBeenLastCalledWith(
          |                                ^
      314 |       utils.getStartOfMonth(utils.setMonth(startDay, 0)),
      315 |     );
      316 |   });

      at Object.toHaveBeenLastCalledWith (test/month_test.test.js:313:32)

  ● Month › should call the provided onDayMouseEnter (Pointer Event) function

    expect(jest.fn()).toHaveBeenLastCalledWith(...expected)

    Expected: 2023-12-31T22:00:00.000Z

    Number of calls: 0

      333 |     fireEvent.pointerEnter(month);
      334 |
    > 335 |     expect(onDayMouseEnterSpy).toHaveBeenLastCalledWith(
          |                                ^
      336 |       utils.getStartOfMonth(utils.setMonth(startDay, 0)),
      337 |     );
      338 |   });

      at Object.toHaveBeenLastCalledWith (test/month_test.test.js:335:32)

  ● Month › should call the provided onMonthClick function

    expect(received).toBe(expected) // Object.is equality

    Expected: 6
    Received: NaN

      428 |     )[6];
      429 |     fireEvent.click(month);
    > 430 |     expect(utils.getMonth(monthClicked)).toBe(6);
          |                                          ^
      431 |   });
      432 |
      433 |   it("should return disabled month if current date is out of bound of minDate and maxDate", () => {

      at Object.toBe (test/month_test.test.js:430:42)

  ● Month › should not return disabled month if current date is after maxDate but same month

    expect(received).not.toBe(expected) // Object.is equality

    Expected: not true

      499 |     expect(
      500 |       month.classList.contains("react-datepicker__month-text--disabled"),
    > 501 |     ).not.toBe(true);
          |           ^
      502 |     expect(month.getAttribute("aria-disabled")).not.toBe("true");
      503 |     fireEvent.click(month);
      504 |     expect(onDayClickSpy).toHaveBeenCalled();

      at Object.toBe (test/month_test.test.js:501:11)

  ● Month › should return disabled month if specified includeDate

    expect(received).toBe(expected) // Object.is equality

    Expected: false
    Received: true

      564 |       expect(
      565 |         month.classList.contains("react-datepicker__month-text--disabled"),
    > 566 |       ).toBe(false);
          |         ^
      567 |     }
      568 |     for (let i = 6; i < 12; i++) {
      569 |       const month = monthTexts[i];

      at Object.toBe (test/month_test.test.js:566:9)

  ● Month › Keyboard navigation › should select March when Enter is pressed

    TypeError: Cannot read properties of null (reading 'toString')

      1878 |
      1879 |       expect(preSelected).toBe(true);
    > 1880 |       expect(selectedDate.toString()).toBe(
           |                           ^
      1881 |         utils.newDate("2015-03-01").toString(),
      1882 |       );
      1883 |     });

      at Object.toString (test/month_test.test.js:1880:27)

  ● Month › Keyboard navigation › should select March when Space is pressed

    TypeError: Cannot read properties of null (reading 'toString')

      1912 |
      1913 |       expect(preSelected).toBe(true);
    > 1914 |       expect(selectedDate.toString()).toBe(
           |                           ^
      1915 |         utils.newDate("2015-03-01").toString(),
      1916 |       );
      1917 |     });

      at Object.toString (test/month_test.test.js:1914:27)

 FAIL  test/datepicker_test.test.js (5.85 s)
  ● DatePicker › when update the datepicker input text while props.minDate is set › should auto update calendar when the updated date text is after props.minDate

    expect(received).toBe(expected) // Object.is equality

    Expected: "January 1801"
    Received: "July 1993"

      1119 |       expect(
      1120 |         container.querySelector(".react-datepicker__current-month").innerHTML,
    > 1121 |       ).toBe("January 1801");
           |         ^
      1122 |     });
      1123 |
      1124 |     it("should not auto update calendar when the updated date text is before props.minDate", () => {

      at Object.toBe (test/datepicker_test.test.js:1121:9)

Test Suites: 5 failed, 22 passed, 27 total
Tests:       20 failed, 888 passed, 908 total
Snapshots:   0 total
Time:        6.358 s

How do you want to proceed here? I think it's fine to make the changes to make this fully compatible with date-fns, we could release a major upgrade once we're done with the TS conversion for example. Perhaps we hold on this on until the other ones are done and we release it as a major upgrade?

How do you want to proceed here? I think it's fine to make the changes to make this fully compatible with date-fns, we could release a major upgrade once we're done with the TS conversion for example. Perhaps we hold on this on until the other ones are done and we release it as a major upgrade?

Yes, I thought from the beginning that this was the best idea. Hold the next release and make it a major one.
We will still be 99,9% compatible and break only edge cases

@martijnrusschen I was thinking about what to do with test cases because I see three groups of problems:

a test is invalid because this is a breaking change, and we can't fix it
a test is valid, but some props weren't passed, and that's why it fails
a test is valid, and we can redo some inner logic to save the original behavior

Since we decided to go with a major release, the best way to deal with all three points is to skip tests until problematic components are rewritten in typescript. It'll save tons of time and effort instead of crawling through code manually

Would it make sense to hold on this PR until the other files are rewritten? That way, we can safely release the nonbreaking changes until we get to a point where we have to make these changes.

Would it make sense to hold on this PR until the other files are rewritten? That way, we can safely release the nonbreaking changes until we get to a point where we have to make these changes.

We can try, but then we'll have some issues with types. Many files rely on these helpers, and we need proper types here so we don't play a guessing game.

True! Ok, let's continue with making the changes as they're designed to work according to date-fns and we can release a major upgrade after this PR.

True! Ok, let's continue with making the changes as they're designed to work according to date-fns and we can release a major upgrade after this PR.

True! Ok, let's continue with making the changes as they're designed to work according to date-fns and we can release a major upgrade after this PR.
I think it's no need anymore

The only potential breaking change is that we do not return null if the date format is invalid but return new Date instead

Makes sense! Good to document as part of a breaking change 👍

Hooray. All green!

I've requested a last review from @pullrequest since this is a pretty big PR.


Fix grid and k_grid sampling.

Chromatix Field current grid and k_grid assume a centered field - this is actually incorrect when using single FFT transforms such as the optical_fft. We're off by half a spacing. See screenshot below for numbers:

This PR fixes that.

Merging based on Slack discussion

Yes I changed the tests because they don't make sense:

The phase checks for power, which is great, but comparing the intensities of the fields before and after doesnt, because there's diffraction in the middle.
Ditto for the absorption
Using sizes of 2 x 2 is too small to see anything.


Updated the X logo

Fixed #607

Why is this still not modified ??

There should be two separate icons, as X is significantly less recognizable than the bird for now.

@ramirezsanty @ParthMakode When can we expect this PR to be merged any ETA for this?
One quick suggestion instead of replacing with existing one why can't we keep the existing one and add the new X logo. Then users can use whatever they want.

One quick suggestion instead of replacing with existing one why can't we keep the existing one and add the new X logo. Then users can use whatever they want.

+1

When will this be published?

@ParthMakode and @ramirezsanty X(twitter) has a brand tool kit, you can access it in this link:
https://about.x.com/en/who-we-are/brand-toolkit
Could you update your PR so it uses this svg with a bxl-x-twitter name so it doesn't replace the old twitter logo?


how to make the output of vl_simplenn has the same Matrix dimensions

function impred = runVDSR(net, imlow, gpu)
net2.layers = net.layers(1:end-1);
res2 = vl_simplenn(net2, imlow, []);
impred = res2(end).x;
impred = imlow+impred;
if gpu, impred = gather(impred); end
When I run the code mentioned above, I got the error shown as the blow:
run testVDSR.m
255 255
295 295
Error using +
Matrix dimensions must agree.
Error in runVDSR (line 8)
impred = imlow+impred;
Error in VDSR (line 47)
impred = runVDSR(net, imlowy, gpu);
Error in testVDSR (line 13)
VDSR(data, SF, 'VDSR.mat', outRoute);
Error in run (line 63)
evalin('caller', [script ';']);
Anyone can help me out ? the imlow is the input image 255255. but the output is 295295. is there anything wrong with my code??
Thank you !

Obviously the problem occurred in your trained network. Check the dimensions of output of each layer in res2 and you will know the problem.

I just use the VDSR official code and trained model.  I find the VDSR.mat can not be opened by Matlab, error info shown as below,  but the VDSR_Official.mat in your code folder can be opened.
Caused by:
The CUDA driver was found, but the function 'cuDriverGetVersion' returned an error. The error returned was:
CUDA_ERROR_NOT_INITIALIZED
do you why?

The parameters in VDSR.mat are stored in gpuArray format. If you don't have a gpu or there are some problem in the gpu usage, this problem will arise.
发自我的 iPhone
在 2016年9月25日，12:29，Peng Liu <notifications<EMAIL_ADDRESS>写道：
I just use the VDSR official code and trained model. I find the VDSR.mat can not be opened by Matlab, error info shown as below, but the VDSR_Official.mat in your code folder can be opened.
Caused by:
The CUDA driver was found, but the function 'cuDriverGetVersion' returned an error. The error returned was:
CUDA_ERROR_NOT_INITIALIZED
do you why?
―
You are receiving this because you commented.
Reply to this email directly, view it on GitHubhttps://github.com/huangzehao/caffe-vdsr/issues/12#issuecomment-249402136, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ANB22oCpw_0F9SzaM5UpnUyLYExpcBXEks5qtfingaJpZM4KF0Bn.

I got. Thank you ~!


Tags in Hockey app are missing in AppCenter

Hokckey app allows me to create new tags and tag them to a group of similar apps which will help to filter the apps while I am seeing a big list. In my case we use multiple apps for multiple releases. So I want to filter the apps based on the release that I am currently in and the old release. Just filtering using the platform doesn't help in this situation.
Please include this feature in AppCenter also which will help lot of people during their filter.

@udayvalluri thank you for bringing this up. We won't be supporting this until the HockeyApp shutdown but we will keep the ticket and consider doing it in the future.

@derpixeldan and @blparr. Hockey app is shut down now, do you have any near plan to consider this?

@derpixeldan and @blparr : any update on this.


is this stellar scam? please help

i recieve this in facebook is suspicius...

As I see that webiste has been closed by Google, it sounds that it's scam trying to get account information to take all token you would have get before from true airdrop :)


[move-prover] Separate resource memory by type.

This PR implements separation of resource memory by type instead of using one global memory variable. This makes life for Z3 simpler because

Automatic modifies analysis is more precise and only those memories are marked as modified which are actually touched on a per-type basis.
Less aliasing has to be considered which likely reduces case splitting.

As a result, all timeout problems in existing modules could be resolved (except one related to loops). Note that this doesn't necessarily mean yet we have more verified, because many of the functions timing out have no specification conditions yet, but where just calling other functions which have. The overall performance improvement is hard to measure, but some problems which timed out now pass in seconds, and LibraAccount verification has become faster by about 40%.
The separation of memory is possible because:

Move does not allow for borrow_global<T> where T is a type parameter. The outermost type in borrow must be statically known. This allows us to statically know the memory being queried.
The new memory model made it particular easy to implement this, because WriteRef on an arbitrary reference does not commit to the global state yet. Rather commit happens only on the root, where we know the affected memory statically.

This PR also cleans up some stuff, removing Sender and transaction support, and fixing a few more loose ends.
Motivation
Prover performance.
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Existing tests pass.
Related PRs
NA

One thing I couldn't get out of examining the PR is how we are handling type quantification. My understanding was that the user could write formulas quantifying over all types. Could the translation of that feature be affected by the memory splitting?

This does not cause a problem, because in resource access, the outest type in global<R> always needs to be concrete. (Move restriction). We can still write forall t: type: exists<R<t>>(addr). Already before, we could not write forall t: type: exists<t>(addr).

@bors-libra r=shazqadeer

:pushpin: Commit 5e797f8 has been approved by shazqadeer

:hourglass: Testing commit 5e797f841250583c9e4a8fb97824cc3087bfbd01 with merge 32e7287d322c2e9daef35791d195df8550f62063...

:sunny: Test successful - checks-actions_land_blocking_test, checks-circle_commit_workflow
Approved by: shazqadeer
Pushing 32e7287d322c2e9daef35791d195df8550f62063 to master...


Update client API to provide SHA256

We're migrating internally toward using SHA256 preferentially over
SHA1. Old clients will still be 100% compatible.
@zquestz @tcahill

LGTM

Should I push out a new release with this change?

Sure thing; we promoted a release of Continuum compatible with this, so it should be a good time for that.


Build npm needs a howto do it fast.

Building an npm application with
https://github.com/opendevstack/ods-pipeline/blob/v0.5.1/build/package/scripts/build-npm.sh
we spent one day looking at the correct build args because not generating some files causes the pipe to fail again and again.
Finally we found the following ones work:
nyc --report-dir build/coverage --reporter clover --reporter cobertura --reporter text --reporter html --reporter json-summary --reporter json --reporter lcov --lines 50 node_modules/.bin/_mocha --reporter mocha-junit-reporter --reporter-options mochaFile=build/test-results/test/report.xml -- test/*_test.js

So, we request this to be written somewhere in the documentation: A valid package.json needs to have test defined is scripts as follows:
{
  "name": "name",
  "version": "0.0.1",
  "description": "description",
  "main": "server.js",
  "scripts": {
    "test": "nyc --report-dir build/coverage --reporter clover --reporter cobertura --reporter text --reporter html --reporter json-summary --reporter json --reporter lcov --lines 50 node_modules/.bin/_mocha --reporter mocha-junit-reporter --reporter-options mochaFile=build/test-results/test/report.xml -- test/*_test.js",
    "start": "node server.js",
    "build": "mkdir -p build/test-results/tests && mkdir -p dist && cp {package.json,server.js,config.js} dist && cp -r helpers public api node_modules dist/"
  },
...

Thanks.

Thanks. Fully agree that it is very cumbersome to get it "right". I think we need to add:

description of which files need to be placed where
link to an example
description of possibility to exchange the build script to do just whatever you want


Code to test ration ... like the concept

After reviewing rake test i am intrigued by the Code To Test Ratio metric.  Would love to see this when test support has been added.

Code to Test Ratio has been implemented in #109 and has been merged to master. Tagging a new release very soon.


OTPtoEmail

I added an else statement after the Google Authenticator section to prompt the user to enter the OTP that was sent to the user's email  address if the org doesn't use Google Authenticator

Thanks for that, I had intended to test the OTP to email at some point, but never got round to it.

No problem! Your module is the only one I've found that actually works as expected and has actually been cleaned up for public use. Also you're the first person I've seen that has anything about custom group management. I had checked ME's KB and API documentation and couldn't find anything on it. This is going to save us a ton of work and problems.
Also, this was my first contribution to someone else's code, so I'm happy it was found useful and merged!


import re2 in Python in Mac OS X

import re2
Traceback (most recent call last):
File "", line 1, in
ImportError: dlopen(/Users/us/Anaconda/anaconda/lib/python2.7/site-packages/re2.so, 2): Symbol not found: __ZN3re23RE213GlobalReplaceEPSsRKS0_RKNS_11StringPieceE
Referenced from: /Users/us/Anaconda/anaconda/lib/python2.7/site-packages/re2.so
Expected in: dynamic lookup

Installation Procedure i followed:
first i install re2 using

brew install re2

then i did:
$ git clone git://github.com/axiak/pyre2.git
$ cd pyre2.git
$ sudo python setup.py install
I am getting this error when i am importing re2 in python Mac OS X.
How to solve this issue ?

I face the same issue.

It looks like Anaconda issue - it doesn't play well with python C extensions installed using setuptools/distutils.

In my case I am not using Anaconda but regular python installed by homebrew. re2 was also installed by homebrew.

Hmm, I've just tried the following, it worked:
brew upgrade re2
mkvirtualenv tst
pip install https://github.com/axiak/pyre2/archive/master.zip#egg=pyre2

I can't reproduce this on OS X


Hmm, seems the same happens with https://asciinema/connect/ as well

You have to access the app through nginx, which routes some requests to Phoenix app, and some others to Rails app. When you set it up the nginx was baked-in into asciinema-server image, as of today it's running as a separate container.

@sickill thanks, I'm running this on Kubernetes so that explains it. I'll give that  try on Monday and report back

The rest of the codebase was ported to Elixir this year, so there's no dual-stack anymore, and all the requests are routed to Phoenix now. It's been a while since you tried setting this up, so I'm not sure if you're still interested in it. I'll close this one, but feel free to re-open and we'll figure it out.


Setting viewDate does not change UI

A view date can be set and the variable will update but this does not reflect in the UI until another event happens. For example if I set the viewDate to be one year in the future nothing will happen until I click next month causing it to jump appear to just a year and a month into the future.

A call to fillDate(); after the viewDate is set in the viewDate function works for me.
Just after this line:
https://github.com/Eonasdan/bootstrap-datetimepicker/blob/master/src/js/bootstrap-datetimepicker.js#L2312

dp.change event is called, show widget 1 time no updates at UI, second all ok. This must be fixed

Created a jsfiddle http://jsfiddle.net/mo287kpo/


Workbench session image promotion

Build the workbench-session image.

@zachhannum is it OK if the preview/daily builds still run for the session init container? (as they did in the above workflow)

@zachhannum is it OK if the preview/daily builds still run for the session init container? (as they did in the above workflow)

Yep, preview/daily builds are still OK! We are using them for QA prior to the release. Thanks!

@zachhannum is it OK if the preview/daily builds still run for the session init container? (as they did in the above workflow)

Yep, preview/daily builds are still OK! We are using them for QA prior to the release. Thanks!


AttributeError: module 'pydantic' has no attribute 'networks'

There seems to be an issue with this library. Maybe it is an incompatability of the latest pydantic library.

Hello @SROMCY ,
First of all, thank you for using pydantic2avro. I was able to import pydantic.networks as shown in the snippet below:
$ python
Python 3.11.9 (main, Apr 17 2024, 00:00:00) [GCC 14.0.1 20240411 (Red Hat 14.0.1-0)] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>>
>>> import pydantic.networks
>>>
>>> print(pydantic.networks.__all__)
['AnyUrl', 'AnyHttpUrl', 'FileUrl', 'FtpUrl', 'HttpUrl', 'WebsocketUrl', 'AnyWebsocketUrl', 'UrlConstraints', 'EmailStr', 'NameEmail', 'IPvAnyAddress', 'IPvAnyInterface', 'IPvAnyNetwork', 'PostgresDsn', 'CockroachDsn', 'AmqpDsn', 'RedisDsn', 'MongoDsn', 'KafkaDsn', 'NatsDsn', 'validate_email', 'MySQLDsn', 'MariaDBDsn', 'ClickHouseDsn']
>>>
>>> pydantic.__version__
'2.8.2'
>>>

If you don't mind, could I get the code for the pydantic model MoveAndSettleRaw or a minimal version of any other pydantic model that is producing the same error for debugging purposes?
Best Regards,
Kunal Sharma

Hi Kunal, the model is rather large with many nested models.
I found that the problem propably comes from the typing.Literal .
Here a minimal sample:
`
import json
from pprint import pprint
from typing import Literal
from pydantic import BaseModel, Field
from pydantic2avro import PydanticToAvroSchemaMaker
from datatypes.measurements.dynamic import MoveAndSettleRaw
from datatypes.util.enum import MeasurementType
class MinimalModel(BaseModel):
type: Literal["hello"] = Field(default="hello")
m = MinimalModel()
print(m)
schema = PydanticToAvroSchemaMaker(MinimalModel).get_schema()
pprint(schema)
`

Hello @SROMCY ,
First of all, thanks for your patience. I wanted to let you know that an import of pydantic.networks was missing in src/pydantic2avro/schema_maker.py. For some reason, my linter didn't report it, and coincidentally, all the places where I was using pydantic2avro had pydantic.networks imported one way or another. Hence, I didn't notice the problem until you reported it.
I have deployed the pydantic2avro v0.4.1 on pypi.
Following code is now working as expected:
from typing import Literal, Optional
from pprint import pprint

from pydantic import BaseModel, Field
from pydantic2avro import PydanticToAvroSchemaMaker

class MinimalModel(BaseModel):
    type: Literal["hello"] = Field(default="hello")

schema = PydanticToAvroSchemaMaker(MinimalModel).get_schema()

pprint(schema)

output:
$ python minimodel.py
{'fields': [{'name': 'type',
             'type': {'name': 'type', 'symbols': ['hello'], 'type': 'enum'}}],
 'name': 'MinimalModel',
 'type': 'record'}

As for the typing.Optional it will be supported in version 0.5.0 which I am planning to publish by next week, with some minor code changes to fix issue #4 .
Thank you for helping to make pydantic2avro a little bit better.
Best Regards,
Kunal Sharma


UnexpectedMagicException: Invalid KV3 signature for variable 'magic': 0 (0x0)

Describe the bug
A stack trace is reported when attempting to open script.vts_c from this Workshop map.
Relevant log output or exception with stacktrace
ValveResourceFormat.Utils.UnexpectedMagicException: Invalid KV3 signature for variable 'magic': 0 (0x0)
   at ValveResourceFormat.ResourceTypes.BinaryKV3.Read(BinaryReader reader, Resource resource) in D:\a\ValveResourceFormat\ValveResourceFormat\ValveResourceFormat\Resource\ResourceTypes\BinaryKV3.cs:line 76
   at ValveResourceFormat.Blocks.ResourceEditInfo2.Read(BinaryReader reader, Resource resource) in D:\a\ValveResourceFormat\ValveResourceFormat\ValveResourceFormat\Resource\Blocks\ResourceEditInfo2.cs:line 32
   at ValveResourceFormat.Resource.Read(Stream input, Boolean verifyFileSize) in D:\a\ValveResourceFormat\ValveResourceFormat\ValveResourceFormat\Resource\Resource.cs:line 266
   at GUI.Types.Viewers.Resource.Create(VrfGuiContext vrfGuiContext, Byte[] input) in D:\a\ValveResourceFormat\ValveResourceFormat\GUI\Types\Viewers\Resource.cs:line 44
   at GUI.MainForm.ProcessFile(VrfGuiContext vrfGuiContext, PackageEntry file) in D:\a\ValveResourceFormat\ValveResourceFormat\GUI\MainForm.cs:line 630
   at System.Threading.Tasks.Task`1.InnerInvoke()
   at System.Threading.ExecutionContext.RunFromThreadPoolDispatchLoop(Thread threadPoolThread, ExecutionContext executionContext, ContextCallback callback, Object state)
--- End of stack trace from previous location ---
   at System.Threading.ExecutionContext.RunFromThreadPoolDispatchLoop(Thread threadPoolThread, ExecutionContext executionContext, ContextCallback callback, Object state)
   at System.Threading.Tasks.Task.ExecuteWithThreadLocal(Task& currentTaskSlot, Thread threadPoolThread)

What game does this happen in
CS2
Reference file in a Source 2 game
The exact script.vts_c used when this error was encountered can be downloaded here: https://gist.github.com/roge/dd42705cb8f52cb1fed269a1844d0214/raw/b4411e3cdcae0da5be0be6b0d5d44292f6627a19/script.vts_c
Expected behavior
The file should open correctly, revealing the script code.
What version of VRF are you using? On what platform?
v6.0.2421+3742a2813906e7c2b3f569754bc7f66cc85c1726, Windows 10 21H2 19044.3693

The same issue occurs on v7.0.2479+8b3ade7d8efd5ca8113dd6484b15d39179389b98 as well.
However, the newer version doesn't immediately show the stacktrace. Initially, the tab is blank. If you switch tabs, then the stacktrace is revealed.
Also, this gets printed to the console:
[Console] Failed to load "surfaceproperties/surfaceproperties.vsurf_c"

However they created the file, it's pretty much corrupted, it has RED2 block but it's empty. Don't do this :)

Seemingly it is made with this https://github.com/Ansimist/cs2typescript


Add xcbeautify to macOS image

Tool information

Tool name: xcbeautify
Tool license: MIT
Add or update? Add
Desired version: 0.8.1 (latest)
Approximate size:
If this is an add request:

Brief description of tool: xcbeautify is a little beautifier tool for xcodebuild. Similar to xcpretty, but faster and in active development / maintenance.
URL for tool's homepage: https://github.com/thii/xcbeautify
Provide a basic test case to validate the tool's functionality: set -o pipefail && xcodebuild [flags] | xcbeautify

Area for Triage:
Apple
Question, Bug, or Feature?:
Feature
Virtual environments affected

[X] macOS 10.15
[ ] Ubuntu 16.04 LTS
[ ] Ubuntu 18.04 LTS
[ ] Ubuntu 20.04 LTS
[ ] Windows Server 2016 R2
[ ] Windows Server 2019

Can this tool be installed during the build?
Yes
Tool installation time in runtime

Are you willing to submit a PR?
For macOS image I believe you don't allow PR at this time

Hi @MarcoEidinger,
this tool can be installed in runtime via brew install xcbeautify in less than a minute. Considering this fact, we wouldn't like to pre-install it on the image. We are trying not add tools that are easily installed in runtime due to maintenance reasons.
I will close this issue. Please, feel free to open a new one in case of any questions.
Thanks.

Just curious, given xcpretty is installed (but not really updated), why not eventually move to this instead?  Or atleast stop including xcpretty if the goal is to have fewer things in the images?

Fair point about xcpretty. It hasn't been updated in the past 5 years and is entirely broken for parallel testing with newer Xcode. Yet remains a part of macOS image. Baffling to say the least.

Both this and #6198 was closed, yet xcpretty remains. Is there a plan to update to xcbeautify?


[Language Text] Use canary region

Use canary region
EDIT: live tests

API change check
API changes are not detected in this pull request.

No longer needed


Remove not needed try/catch from the test

Context
SonarCloud says that this try/catch is a code smell because we are anyway not doing anything special in the catch clause.
Description
Instead of adding there console.error it is better to remove the try/catch statement as the error will bubble up anyway to the runForVersion function where error is handled much better.

Hey. This seems to be pretty simple, can I take this up?


If I lock a thread, I get an email telling me I have done it

I locked a thread, and then got an email:
A topic you are watching has been locked by Nick Gammon.

View the topic at: http://forum.arduino.cc/index.php?topic=301853.new#new

I know that, as I was the one locking it. The email is redundant.

Someone may find the logging of the information useful. I guess it should be an option in the notification settings.

I suppose. But I don't get other stuff logged. Like "you posted a message", "you removed a thread", or "you banned a user".

A topic you are watching has been locked by Nick Gammon.

The wording suggests I am not Nick Gammon. Maybe: "You locked a topic".

Closing as obsolete because the new Discourse-based forum does not send emails for locked threads.


Host logging endpoint

The scale controller needs a way to report errors to the runtime, so those errors are logged to our normal host log channels. E.g. if a trigger connection string is incorrect/invalid, etc.
Proposal is to add a new admin/host/log endpoint that accepts a POST request containing a json array of structured log entries to write. Each log entry would have the requisite json properties allowing us to translate to our existing TraceEvent log format, e.g. including properties timestamp, level, source, message, etc.
This endpoint will use the same auth model that the existing admin/host/status endpoint uses for internal Antares requests (see code here).

cc @brettsam

This has been done


FAILED - RETRYING: Master | wait for the apiserver to be running (30 retries left).

I have issue of 'FAILED - RETRYING: Master | wait for the apiserver to be running (30 retries left).' in one master while trying to setup a cluster of two master, node1 and node2. Similar issues were reported but not solution works for me.
My environment includes,

local machine, macOS Sierra, Version 10.12.6.
Two VMs with CentOS7 running within VirtualBox, CentOS-7-x86_64-DVD-1804.iso.

I always got below error message on node2 but node1 always good. After deployment, netstat in node1, <IP_ADDRESS>:6443 is listened but in node2 it is not, would it be the reason of connection refused?
RUNNING HANDLER [kubernetes/master : Master | wait for the apiserver to be running] *********************************************
Wednesday 08 August 2018  20:57:25 -0700 (0:00:00.403)       0:11:15.278 ******
FAILED - RETRYING: Master | wait for the apiserver to be running (30 retries left).
FAILED - RETRYING: Master | wait for the apiserver to be running (30 retries left).
FAILED - RETRYING: Master | wait for the apiserver to be running (29 retries left).
FAILED - RETRYING: Master | wait for the apiserver to be running (29 retries left).
ok: [node1]
FAILED - RETRYING: Master | wait for the apiserver to be running (28 retries left).
FAILED - RETRYING: Master | wait for the apiserver to be running (27 retries left).
FAILED - RETRYING: Master | wait for the apiserver to be running (26 retries left).
FAILED - RETRYING: Master | wait for the apiserver to be running (25 retries left).
FAILED - RETRYING: Master | wait for the apiserver to be running (24 retries left).
FAILED - RETRYING: Master | wait for the apiserver to be running (23 retries left).
FAILED - RETRYING: Master | wait for the apiserver to be running (22 retries left).
FAILED - RETRYING: Master | wait for the apiserver to be running (21 retries left).
FAILED - RETRYING: Master | wait for the apiserver to be running (20 retries left).
FAILED - RETRYING: Master | wait for the apiserver to be running (19 retries left).
FAILED - RETRYING: Master | wait for the apiserver to be running (18 retries left).
FAILED - RETRYING: Master | wait for the apiserver to be running (17 retries left).
FAILED - RETRYING: Master | wait for the apiserver to be running (16 retries left).
FAILED - RETRYING: Master | wait for the apiserver to be running (15 retries left).
FAILED - RETRYING: Master | wait for the apiserver to be running (14 retries left).
FAILED - RETRYING: Master | wait for the apiserver to be running (13 retries left).
FAILED - RETRYING: Master | wait for the apiserver to be running (12 retries left).
FAILED - RETRYING: Master | wait for the apiserver to be running (11 retries left).
FAILED - RETRYING: Master | wait for the apiserver to be running (10 retries left).
FAILED - RETRYING: Master | wait for the apiserver to be running (9 retries left).
FAILED - RETRYING: Master | wait for the apiserver to be running (8 retries left).
FAILED - RETRYING: Master | wait for the apiserver to be running (7 retries left).
FAILED - RETRYING: Master | wait for the apiserver to be running (6 retries left).
FAILED - RETRYING: Master | wait for the apiserver to be running (5 retries left).
FAILED - RETRYING: Master | wait for the apiserver to be running (4 retries left).
FAILED - RETRYING: Master | wait for the apiserver to be running (3 retries left).
FAILED - RETRYING: Master | wait for the apiserver to be running (2 retries left).
FAILED - RETRYING: Master | wait for the apiserver to be running (1 retries left).
fatal: [node2]: FAILED! => {"attempts": 30, "changed": false, "content": "", "msg": "Status code was -1 and not [200]: Request failed: <urlopen error [Errno 111] Connection refused>", "redirected": false, "status": -1, "url": "https://<IP_ADDRESS>:6443/healthz"}
Here is my host.ini for nodes config,
[all]
node1    ansible_host=<IP_ADDRESS> ansible_user=root
node2    ansible_host=<IP_ADDRESS> ansible_user=root
[kube-master]
node1
node2
[etcd]
node1
node2
node3
[kube-node]
node1
node2
node3
node4
node5
node6
[calico-rr]
[k8s-cluster:children]
kube-master
kube-node
And I ran below command,
ansible-playbook -i inventory/mycluster/hosts.ini cluster.yml
Can someone give help? thanks.
k8s-cluster.yml.txt

hosts.ini.txt
all.yml.txt
submit config files.

Adding kubelet journal log.
kubelet.log.txt

I am getting the exact same error here. From what I figured out so far I think there is a port problem happening as the server can't bind to 10025 anymore and when I'm looking at docker ps I see two kube-proxy (one having POD_kube-proxy and the other having kube-proxy_kube-proxy in their names), whereas one (POD_kube-proxy) is paused. Once I stopped the paused one, the apiserver tried to start again but suddenly the stopped proxy started again and caused both the apiserver and new proxy to pause again and crashing the startup.

I follow steps included in https://dzone.com/articles/kubespray-10-simple-steps-for-installing-a-product, then the issue fixed.
I tried more details. It seems to me below three steps help to solve the issue,

'systemctl stop firewalld' in step 2,
step 6.
'kube_read_only_port: 10255' in step 9.

Below is my environment,

running ansible from my macOS Sierra, 10.12.6,
kubespray commit,
C02WV0BCHTDG:kubespray2 hli$ git log
commit 4650f04b37f0fb34eac8ce1d7d29a6dad65fbb9e (HEAD -> master, origin/master, origin/HEAD)
object machines include VM and intel NUC, both are working fine
3.1 VirtualBox and two CentOS7 VMs, VirtualBox-5.2.12-122591-OSX + CentOS-7-x86_64-DVD-1804
3.2 Two NUC running CentOS7, CentOS-7-x86_64-DVD-1804.

hope this can help other folks have similar problem and thanks to the original link of the 10 steps.

BTW, just in case, step 8 in the link will not generate ansible_user, which needs manual add. in my environment, both docker_dns_servers_strict and kube_read_only_port need to uncommented.

Please take care when setting kube_read_only_port since it serves an endpoint without authentication and authorization and it's quit einsecure making it accessible from anywhere outside of your own network.
However, I got it running by increasing the memory to over 2GB (I ran Vagrant VMs) and making sure to set the correct authorization properties. When using the default settings (for Vagrant) everything worked and once you start disabling anonymous access or the insecure port, things got tricky and you have to set the authorization_modes correctly. In my case, I was happy with an insecure endpoint as well because you can restrict it to only listen to localhost by setting kube_apiserver_insecure_bind_address = <IP_ADDRESS> and using the default authorization_modes of Node and RBAC.

Thanks for your info. I tried not to open kube_read_only_port and it turned out worked fine. So this seems unnecessary change. But uncomment of docker_dns_servers_strict is needed otherwise ansible will complain.


initialize tesseract

this is the simplest demo of tesseract.
so far, the image with overlays is not something tesseract understands.  we might need to do additional image-processing for tesseract to understand output of Writer
a lot of what i'm testing here is whether it runs in CI

it runs in CI!

coolcool.  i'm going to leave this open a little longer to see if people can run the test locally (i.e. there're no problems installing tesseract).  ty for the feedback

there's a todo in the README for tesseract installation on Windows


Cifar10 example sometimes only predicts 1 class and does not improve

Running this script
https://github.com/fchollet/keras/blob/master/examples/cifar10_cnn.py
it sometimes locks into a situation where it only predicts a single class and accuracy fixes at 0.1 .

cifar10.pdf

I also encountered the same problem before.
I solved using Adam instead of SGD.

@aidiary  yes,  the adam optimizer works fine , i just try it

@aidiary Hi, I've changed to Adam but the loss still get stucked at 2.304, and accu=0.1.
are you using Adam with lr 0.01? Is there any other configs for Adam? Thank you.

@wangdelp No, I am using Adam with default settings. Here is my sample codes.
https://github.com/aidiary/keras_examples/blob/master/cnn/cifar10/cifar10.py
model.compile(loss='categorical_crossentropy',
                  optimizer='adam',
                  metrics=['accuracy'])

@aidiary Thank you, by changing the optimizer to Adam without any further config is by default using a smaller learning rate 0.001 as far as I can see from the Adam class #L315 in the file:
https://github.com/fchollet/keras/blob/master/keras/optimizers.py. So I thought the difference should still comes with the different learning rate used. Thanks.


Investigate use of selenium instead of using aquatone

Pros:

I have more control over what's happening
I will have one less subprocess to manage
I can take full-page screenshots

Cons:

I'm adding selenium as a dependency (but it's in replace of aquatone so...?)

Example:
https://gist.github.com/sshell/32cbfa94fbd59c323ebee9ced4905e9d

Since we're going docker native, we could maybe consider using Selenium docker containers. Another thing to worry about here is basically that we don't want to have 50 copies of chromium running if we have 50 agent threads running. I think it's probably going to be favorable to have a limited number of chromium processes and scanning threads wait for their request to be processed. (alternatively completely separate them but that loses the atomicity of the snapshot)
We also have to deal with #285 in situations where the host might be using userns, so if docker-selenium works even in those situations then it'd be a clear win.
https://github.com/SeleniumHQ/docker-selenium


hezarai/whisper-small-fa Works very well but just for the first 10 seconds

Hi
I was trying to use the speech recognition for a 1hr audio it was working and detecting very well but just for the first 10 seconds of the audio and it just abandoned the rest of the file.

Hi @rajabit, thanks for your feedback.
What do you mean by abandoning the rest of the file? does it raise an error? or it just can't recognize the rest of the audio file (the output text is just the transcript of the first 10 seconds )?

I mean, it works without errors but for any audio file that I test it just gives me a short part of it, maybe it's related to the (448 tokens) limit but I'm pretty sure that the text wasn't that much.
anyway, thanks for the library and your support.

@rajabit So this seems like another type of bug since it seems that the model is suffering from an early stopping issue in generation which is likely due to short training samples in the training set. I'll take a look into the training script and parameters to see if the model has seen long samples in the dataset or not.
I'll let you know soon.

@rajabit Forgot to point out that genrerally, it's better to feed small audio chunks to speech recognition models (whisper, wav2vec, etc.). Currently, there is no utility to do that in Hezar, but I'll open an issue regarding this and hope that we can add it soon. If you have similar experience or are willing to help out, just let me know. Thanks.

@arxyzan The day that I was testing it, I tried to chunk the audio file but when I did that the result wasn't useful idk why, maybe because when the file splits voices are not clear anymore

@rajabit How did you chunk the audio files? You have to make sure that the chunks do not involve split words. You can tackle this by using silence detection techniques using pydub.

I tried this one, but I'll try your suggestion, Thank you.
def process_audio(file_name):     myaudio = AudioSegment.from_file(file_name, "mp3")     chunk_length_ms = 10000  # pydub calculates in millisec     chunks = make_chunks(myaudio, chunk_length_ms)  # Make chunks of one sec     string = ""     for i, chunk in enumerate(chunks):         chunk_name = './chunked/' + file_name + "_{0}.mp3".format(i)         print("exporting", chunk_name)         chunk.export(chunk_name, format="mp3")         string += (" " + getText(chunk_name))     return string

@rajabit This will probably do the job:
from pydub import AudioSegment
from pydub.silence import split_on_silence

def chunk_audio(file_path):
    audio = AudioSegment.from_file(file_path)
    chunks = split_on_silence(audio, silence_thresh=-40, min_silence_len=1000)
    max_chunk_length = 10000  # 10 seconds

    for i, chunk in enumerate(chunks):
        chunk = chunk[:max_chunk_length] if len(chunk) > max_chunk_length else chunk
        output_filename = f"{file_path.stem}_chunk_{i}.mp3"
        chunk.export(output_filename, format="mp3")

# Example usage:
file_path = "your_audio_file.mp3"
chunk_audio(file_path)


update to xcode 10 , brew install any Error: Your Xcode (1) is too outdated.

xcode is 10.
Command Line Tools is up to date.
 >brew install ffmpeg
Updating Homebrew...
Error: Your Xcode (1) is too outdated.
Please update to Xcode 9.2 (or delete it).
Xcode can be updated from the App Store.

Update them from Software Update in the App Store.

>brew config
HOMEBREW_VERSION: 1.5.2
ORIGIN: https://git.coding.net/homebrew/homebrew.git
HEAD: 60a30e966b7cece5bd4823dae3fb981ab85106ea
Last commit: 8 months ago
Core tap ORIGIN: https://mirrors.ustc.edu.cn/homebrew-core.git
Core tap HEAD: 67d5d35aa222f200a07b924730817947cf1480b3
Core tap last commit: 2 days ago
HOMEBREW_PREFIX: /usr/local
HOMEBREW_BOTTLE_DOMAIN: http://7xkcej.dl1.z0.glb.clouddn.com
CPU: octa-core 64-bit haswell
Homebrew Ruby: 2.3.7 => /System/Library/Frameworks/Ruby.framework/Versions/2.3/usr/bin/ruby
Clang: N/A
Git: 2.19.0 => /usr/local/bin/git
Curl: 7.54.0 => /usr/bin/curl
Perl: /usr/bin/perl
Python: /usr/local/opt/python/libexec/bin/python => /usr/local/Cellar/python/3.7.0/Frameworks/Python.framework/Versions/3.7/bin/python3.7
Ruby: /usr/bin/ruby => /System/Library/Frameworks/Ruby.framework/Versions/2.3/usr/bin/ruby
Java: 1.8.0_141
macOS: 10.13.6-x86_64
Xcode: 1 => /Applications/Xcode.app/Contents/Developer
CLT: N/A
X11: 2.7.11 => /opt/X11

Your Homebrew is very outdated. Run brew update-reset.


Add a separator before the footer element

Currently, it is not visually obvious where the site's main content ends and the "This project has received funding from …" footer begins.
Please use a light gray, full-width background as seen on consultation.ngi.eu. And since the content area of the site is not full-width, let's separate it from that content area with a bit of gap through which the "10101000100111100110" background can be seen.
So in principle it will look like the top navbar mirrored on the bottom.
This seems to be a suitable choice that fits into the official design guide, while avoiding large areas of "that green NGI color" which can be "a bit too much". So, we'd not want to do it exactly the same way as the footer on ngi.eu itself.

Done.


sinkv2 metric cause a large increase in latency of KAFKA controller

What did you do?
We use TICDC 6.5.2 to sync data into our KAKFA cluster。There are approximately 4000  topics in our KAKFA cluster and we created 50+ ticdc jobs。
What did you expect to see?
All components run normally。
What did you see instead?
The latency（including produce and consumer latency） of the KAFKA controller increased immediately after we started the jobs.
We checked the authorizer log on the KAFKA controller node and found huge numbers of Topic Describe requests.
After more experiments, we found that every TICDC job tried to describe all the topics in the KAFKA cluster every 5 seconds which caused the controller overload.
After checking the source code, we found that there was an unnecessary operation when the sinkv2 generated metrics by running this:
m.updateBrokers()

which meant to get broker info but triggered unnecessarily describe requests for all topics.
Versions of the cluster
Upstream TiDB cluster version (execute SELECT tidb_version(); in a MySQL client):
(paste TiDB cluster version here)

Upstream TiKV version (execute tikv-server --version):
(paste TiKV version here)

TiCDC version (execute cdc version):
v6.5.2

/severity major

/label affects-6.1


Fix invalid SVG on dynamic meshmodel kubernetes component

Notes for Reviewers
This PR fixes #
Signed commits

[ ] Yes, I signed my commits.

Codecov Report
Patch coverage has no change and project coverage change: -0.01 :warning:

Comparison is base (776fc11) 5.70% compared to head (cda3866) 5.70%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@            Coverage Diff            @@
##           master   #7351      +/-   ##
=========================================
- Coverage    5.70%   5.70%   -0.01%
=========================================
  Files         119     119
  Lines       16377   16378       +1
=========================================
  Hits          934     934
- Misses      15267   15268       +1
  Partials      176     176

Flag
Coverage Δ

gointegrationtests
5.70% <0.00%> (-0.01%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

server/handlers/k8sconfig_handler.go
1.97% <0.00%> (-0.01%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

Still normal svgs for some specific components.

in the integration doc, I could see the correct SVG URL placed

Still normal svgs for some specific components.

Lets catchup in some other PR, @Revolyssup


Example - 1 above refers to incorrect computaiton

Instead of 495 + 8, it should be 495*8. there are similar mistakes in other places as well

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 4ea00c3f-e389-9258-45a5-395247555f75
Version Independent ID: f01af29d-f543-077a-3d71-6b6b437758cd
Content: High-performance Premium Storage and Azure managed disks for Windows VMs
Content Source: articles/virtual-machines/windows/premium-storage.md
Service: virtual-machines-windows
GitHub Login: @ramankumarlive
Microsoft Alias: ramankum

Actually, I read it incorrectly (i.e. 495 reads of 2MB each) . The content is correct so please ignore

@sunilagarwal Glad you were able to figure it out.
We will now close this issue. If there are further questions regarding this matter, please reopen it and we will gladly continue the discussion.


fix(runtime-core): watching multiple values - handle undefined as initial values (fix: #5032)

We currently have an empty array as the intial oldValue for a watcher that watches multiple values.
This does fail for an edge case where we watch multiple values and all of them are initially undefined, and trigger the watcher immediately.
We can solve this by settting the initial oldValue to an array filled with INITIAL_WATCHER_VALUE
fix: #5032

ant-design-vue  fixed this  https://github.com/vueComponent/ant-design-vue/pull/6085


Lines are offset

Hi,
I've been using this plugin recently, but the lines are offset. Is there a way to fix it?
https://jsfiddle.net/t5ko6cah/2/

It probably has to do with the number or height of rows in each column.
If you can find the issue and open a PR, you are welcome to do so.


Uniform use of British/American English in variable names (color/colour)

I noticed that in the Virtual Terminal Client source code, there is inconsistent use of the word color/colour. I think we should keep an eye on keeping naming things like this consistent.
For example:
https://github.com/ad3154/ISO11783-CAN-Stack/blob/5a9b0c92e8060d34d2bd0be78d45700f52f5cee0/isobus/src/isobus_virtual_terminal_client.cpp#L482-L498
My proposal for this particular case is to use colour, as this is also what's used in ISO11783.
What are your opinions on this?

My preference is to use colour universally since that's what is used in the ISO docs

Addressed in #172


portico-css: Remove unused find_account CSS rules.

Removes #find_account .btn and #find_account .form-control rules in static/styles/portico/portico.css.
The last use of these rules was removed in commit 7afbc9ddd6e when the login and registration pages were redesigned; specifically note changes to find_my_team.html in that commit, which was renamed to find_account.html in commit ac0d90e53342a4.
Noted when working on #24093.

Self-review checklist

[ ] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[ ] Explains differences from previous plans (e.g., issue description).
[ ] Highlights technical choices and bugs encountered.
[ ] Calls out remaining decisions and concerns.
[ ] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[ ] Each commit is a coherent idea.
[ ] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[ ] Visual appearance of the changes.
[ ] Responsiveness and internationalization.
[ ] Strings and tooltips.
[ ] End-to-end functionality of buttons, interactions and flows.
[ ] Corner cases, error conditions, and easily imagined bugs.

Merged, thanks @laurynmm!


config: support determine terminal filter at runtime

fix #15565.
Currently we validate terminal filter before getting real protobuf message, now envoy can determine a filter whether is a terminal filter base on the protobuf message.
Commit Message: config: support determine terminal filter at runtime
Additional Description:
Risk Level: Low
Testing: TBD
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]
[Optional API Considerations:]

Can you merge main to resolve conflicts and look at getting CI green? Thanks

@snowp I think the remain ci flakes is due to not update https://github.com/envoyproxy/envoy-filter-example, should I give a pr to that repo?

/retest

/retest

/retest

@snowp , the ci seems failed due to the third-party repo is not updated, as I commented at https://github.com/envoyproxy/envoy/issues/15565#issuecomment-806323001 . It seems to become a cycle-dependent:

If I give a pr for  https://github.com/envoyproxy/envoy-filter-example , it will fail to build due to not get this commit.
If I give a pr to envoy like this pr, it failed due to not update echo filter in envoy-filter-example.

@snowp I'm happy to let you make the call of what makes sense, but if you want me to do a second pass I'm game!

All good then, I'll handle the review :)

/retest

Oh actually no those are the filter example ones you mentioned, let me look into how we can fix this

@qinggniq Can you make a PR to envoy-filter-example and point the SHA in ci/filter_example_setup.sh to the commit in the PR? That should let this PR test against the envoy-filter-example PR

/retest

The failures of ci asan and tsan seem due to https://github.com/envoyproxy/envoy/pull/15972#issuecomment-820214392.

/retest

/retest

@snowp all cis are green, waiting for https://github.com/envoyproxy/envoy-filter-example/pull/144 merged. I will change the commit SHA and URL at ci/setup_example_filter.sh to the latest commit.

I merged the filter example PR, can you update this to use the new commit and we'll get this landed? Thanks


[DO NOT MERGE] Try add stETH pool

I missed that due to how balanceOf is calculated in a rebase token, it's possible that it fails Spender's balance check after transfer.


feat: Tablular traffic light and alerts overview

HTML tables are more suitable for the traffic light and alert overviews. They are now interactively linked to the features.


update to swift 4.2

This would be great. Unable to compile using Xcode 10 until this is merged.

Thanks, Nice PR!


Increment versions for patch releases

Increment package versions for patch releases

API change check
API changes are not detected in this pull request.

API change check
API changes are not detected in this pull request.


Not able to subscribe multiple streams within same netconf session

Hello,
I have implemented a netconf client using libnetconf2 and have a requirement to subscribe to two notification streams in same  netconf session.
During testing with  Netopeer2 and Sysrepo-0.7.4 ,found  that after subscribing to one stream , was not able to subscribe second stream within a same netconf session and got below error msg for second stream in same netconf session.
Error Msg :"
type:     protocol
tag:      in-use
severity: error
Already subscribed.
"
I think, Netopeer2 is restricting on one notification stream per per session.
Shouldn't Netopeer2  support multiple streams  per  netconf -session ?

Hi,
this is a feature and there is no need to change this anyway. You are free to use your own filter instead of a stream which will select only the notifications you want. So one subscription should always be enough.
Regards,
Michal


coordinate release 0.9.69

@newville we will have our ASTER'X 2023 school soon and I would like to have a next release of Larch (v0.9.69) by next week, let's say aroun June 7th 2023, including the following issues:

[x] #311
[x] #434
[x] #414

Does this sounds feasible for you?

@maurov Yes, it is time for a new release!  I guess I would ask what needs immediate attention before a release.
For #414, I think this is OK but I'm not sure everyone agrees, so there may still be trouble?
For #311, I think the current version sort of works, but probably needs real-world testing and suggestions, and is not really even started for multi-column Spec files.
For the school on June 7, should we aim for Friday (June 2) or Monday (June 5)?

@newville thanks for agreeing in having next release soon.

@maurov Yes, it is time for a new release! I guess I would ask what needs immediate attention before a release.

Yes, we may ask in the Slack developers' group too.

For #414, I think this is OK but I'm not sure everyone agrees, so there may still be trouble?

I will check these days and let you know my point of view by commenting in the issue thread.

For #311, I think the current version sort of works, but probably needs real-world testing and suggestions, and is not really even started for multi-column Spec files.

Idem, I will give my feedback as soon as possible.

For the school on June 7, should we aim for Friday (June 2) or Monday (June 5)?

The school starts on Monday June 12, so having a release by Friday June 9 (at latest) is the best for me. This will give us some more time to cross check if there are urgent bugs to fix.

@maurov sounds good.
How about this: I willl push 0.9.69rc1 to pypi on June 5th, but I won't push automatic updates.  On June 9th, I will plan to push 0.9.69 and make that an announced release.

@maurov I tagged and pushed 0.9.69 to PyPI and here as a "pre-release".  I'll send out a more complete description in the morning.  Let's aim for 0.9.70 for Friday.

@maurov I think we did all of this!


Refactor tarball generation script

use ./dev/scripts/build-artifact.sh tarball to generate the default tarball
the command has several helper commands:

version: prints the parsed alluxio version from the repo
modules: prints information about the available modules that could be additionally built and included into the tarball. for new modules, append to modules.yml
profiles: prints information about a build profile that determines which contents get included in the tarball. current options are default vs fuse. if additional files need to be copied or other manipulations specific to the tarball layout, modify the profiles.yml file that describes these operations
'checkUfsVersions`: ensures the ufs enums defined in java match up with the corresponding ufs modules in golang

the new generated tarball should be similar to the previous one, with the following exceptions:

intentionally removed most hdfs ufs jars, leaving only the ones for 2.7, 2.10, and 3.3
kubernetes related files are no longer copied
specifically for the fuse tarball, a symlink is created at bin/alluxio-fuse pointing to integration/fuse/bin/alluxio-fuse instead of moving the binary

i have tested the default binary by deploying alluxio locally and running bin/alluxio runTests.

alluxio-bot, merge this please


feature/deseng661: Implemented new admin navigation design.

Issue #: 🎟 DESENG-661

Implemented new admin navigation menu
This includes mobile and desktop viewports
This does not include dark mode
User and tenant sections will be handled in header ticket (as per Steve)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the met-public license (Apache 2.0).

Codecov Report
Attention: Patch coverage is 95.12195% with 2 lines in your changes missing coverage. Please review.

Project coverage is 75.99%. Comparing base (b4bad82) to head (97933be).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2565      +/-   ##
==========================================
+ Coverage   75.96%   75.99%   +0.02%
==========================================
  Files         609      609
  Lines       21960    21995      +35
  Branches     1711     1718       +7
==========================================
+ Hits        16682    16715      +33
- Misses       5015     5017       +2
  Partials      263      263

Flag
Coverage Δ

metweb
64.81% <95.12%> (+0.09%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files
Coverage Δ

.../src/components/layout/SideNav/SideNavElements.tsx
100.00% <ø> (ø)

...web/src/components/layout/SideNav/UserGuideNav.tsx
50.00% <100.00%> (+4.83%)
:arrow_up:

met-web/src/components/layout/SideNav/SideNav.tsx
92.30% <94.73%> (+1.39%)
:arrow_up:


Don't set preview API explicitly false

This will allow people to be able to configure ContentfulModel.use_preview_api without needing to use the preview domain and basic authentication logic.
In my case, the content preview is not necessarily hosted on a separate subdomain, and we configure basic authentication separately.

Hey @mermop,
Thanks for the PR, but I will have to reject it.
The preview environment is a different concept in the Contentful context, it refers to preview.contentful.com which is our Preview API.
If you want to use different environments, without necessarily using our Preview API, then you should use Rails environments instead to store the proper Space ID and Access Tokens based on your current Rails Environment.
Thanks again for your contribution, and hope we get more of them in the future.
Cheers


Enhance shenyu-plugin-grpc module unit test.

issues: #1460
Enhance shenyu-plugin-grpc module unit test
include：
cache
handler
loadbalance
GrpcPluginTest.java

Codecov Report

Merging #1518 (1acaa86) into master (5e084e4) will decrease coverage by 1.23%.
The diff coverage is n/a.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e084e4...1acaa86. Read the comment docs.

CI ERROR


ENH: Add Functionality to extract embeddings

Summary
This issue is a suggestion for adding functionality to Chronos that allows users to extract embeddings directly. This feature would greatly enhance the model's utility by enabling more detailed analysis and application in various forecasting tasks.

@StatMixedML Thanks for opening. I am already working on this in #24.

Done in #24.

@abdulfatir Thanks for the quick release!
I am running the example as shown in the README.md. The data has shape df.shape = (144, 2), whereas the embeddings have shape embeddings.shape = torch.Size([1, 145, 768]). Is there reason why the second dimension, i.e., the time dimension of the embeddings has one more observation than the original data?

@StatMixedML it's described in the docstring: https://github.com/amazon-science/chronos-forecasting/blob/b4a6c0c2eb5af70853b17a8709a6ebf4e7945b23/src/chronos/chronos.py#L359
TL;DR: it's for the EOS (end of sequence) token.

Ok thanks, so this means we should disregard the last embedding embeddings[:,:-1,:]  for downstream tasks?


Some tags not listed on the docker hub page

Related: https://github.com/Microsoft/mssql-docker/issues/167, https://github.com/Microsoft/mssql-docker/issues/345, https://github.com/Microsoft/mssql-docker/issues/400
I'm disappointed that not all relevant tags are listed on the docker hub page, here: https://hub.docker.com/_/microsoft-mssql-server?tab=description
For example, these are missing:

2017-CU13-ubuntu
2017-CU14-ubuntu

And any of the 2019 CTP tags, such as

2019-CTP2.3-ubuntu

I noticed this because I saw the blog post about CTP 2.4, and wondered if there was a new docker image, so I found the docker hub page and checked the tags, and it's not listed. So I was forced to guess what the tag might be based on the CTP 2.3 tag name. But this is silly, I shouldn't have to guess your tag structure, because it ought to be clearly listed.

Hi,
You can retrieve a list of all available tags for mssql/server at  https://mcr.microsoft.com/v2/mssql/server/tags/list
{
  "name": "mssql/server",
  "tags": [
    "2017-CU1-ubuntu",
    "2017-CU10",
    "2017-CU10-ubuntu",
    "2017-CU11",
    "2017-CU11-ubuntu",
    "2017-CU12",
    "2017-CU12-ubuntu",
    "2017-CU13",
    "2017-CU13-ubuntu",
    "2017-CU14",
    "2017-CU14-ubuntu",
    "2017-CU2-ubuntu",
    "2017-CU3-ubuntu",
    "2017-CU4-ubuntu",
    "2017-CU5-ubuntu",
    "2017-CU6-ubuntu",
    "2017-CU7-ubuntu",
    "2017-CU8-ubuntu",
    "2017-CU9-ubuntu",
    "2017-GA-ubuntu",
    "2017-GDR-ubuntu",
    "2017-latest",
    "2017-latest-ubuntu",
    "2018-CTP20",
    "2018-CTP20-ubuntu",
    "2019-CTP2.0",
    "2019-CTP2.0-ubuntu",
    "2019-CTP2.1",
    "2019-CTP2.1-ubuntu",
    "2019-CTP2.2",
    "2019-CTP2.2-ubuntu",
    "2019-CTP2.3",
    "2019-CTP2.3-ubuntu",
    "2019-CTP2.4",
    "2019-CTP2.4-ubuntu",
    "2019-latest",
    "latest",
    "latest-ubuntu",
    "vNext-CTP2.0-ubuntu"
  ]
}

Helpful, thanks. It would be nice if this sync'd to the docker hub page automatically somehow...


Moves the benchmarks into a separate sub-project.

Without this change, for some reason, the published jar would include
scalameter and epctagcoder in the dependencies of epc-core.

LGTM


Create Binary_Tree_Implementation _and_Traveral in java with output

please check and merge it.

You can follow me on github and give ⭐ to this repo.


Create isEqual function to check deep equality of Objects, Arrays and primitives

Hey @touhidrahman, thanks for the issue. A few others brought this up to me personally, glad you made an issue. A few questions for ya:

Are you looking for feature parody with the Lodash isEqual function?
Given that this is typescript, I'm thinking about writing it to validate the types of the values are the same like const isEqual = <TValue> (a: TValue, b: TValue). Is this how you would expect the types to work or would it be more helpful for them to be loose like const isEqual = (a: any, b: any)?

Hi,
Yes, I would like it as a feature-parity of lodash's isEqual.
For my case, it should be sufficient to type as following :
isEqual(a: T1, b: T2): T1 is T2
However, the broader community should also put their opinions and then a agreeable solution be implemented.
Thanks for the hard work!

I could see value in having both with the default behavior for the isEqual feature potentially controlled with optional Boolean on the signature. While I could imagine the loose checker getting more mileage in the near-future, I might suggest the type checked version be the default since it seems to align more with the underlying theme of the library and would potentially become the more favorable option with time.

If ya'll wanna check on my PR, specifically the test cases to make sure it covers any case you can think of that would be awesome!


Documentation: Declaration Merging rationale or motivation

The TypeScript documentation only explains how Declaration Merging works, it does not explain why such a novel --and arguably surprising-- behaviour is required, nor does it provide any practical reason or examples of how it is used.
I feel some documentation explaining the rationale and trade-offs* or at least providing practical or production examples of using declaration merging would be very useful.
* For example, with declaration merging, it is not possible to detect duplicate declarations, which kind of doesn’t exist, what do I get in return for this?

A good real-world example would be adding typed events to classes extending EventEmitter:
interface Foo {
  on(event: "bar", handler: (a: string, b: number) => void): this;
}

class Foo extends EventEmitter {
  // ...
}

// later:
const foo = new Foo();
foo.on("bar", /* get intellisense here */);

@AlCalzone As one is already required to extend EventEmitter in this case, I am struggling to see how the on method overloading couldn't have been done as part of this extension rather than a what seems to be a discrete specification on how the extensions of EventEmitter should behave.

@omeid I don't follow?! I merely provided an example where declaration merging is useful.


_.wrap to default to _.identity for wrapper.

If _.wrap had wrapper default to _.identity then one could do _.wrap(true) as form of _.constant(true). Thoughts?

I don't really see the use case here — but I'd love to be enlightened about it...


moment.d.ts: export as namespace moment;

It would be nice if you included export as namespace moment; into moment.d.ts to allow for consuming the moment declarations without ES6 modules.

Up-for-grabs. This needs to be TS 1.x compatible!

So... is this thing going to be merged in?

It can't be merged into 2.x, because 2.x needs to retain backwards compat for typescript 1... If you want to resubmit the changes against 3.x then we can have a discussion about setting a minimum supported typescript version a little higher.

This should be compatible with TS 1.5+, shouldn't it?

We don't actually have any official minimum supported version of typescript unfortunately-- every dependency in our package.json is just latest. I just joined here -- don't blame me.
But there's only at most one version of 2.x to go, I'm assuming that the minimum version moment 2.x supports is 1.0.
3.x will support >=2.4.0 and there will be more frequent major releases going forward, so I'll make sure to put this in there when I do my typescript changes for that.

Whoops, didn't mean to close this, I thought it was a PR.

Hi guys, can anyone answer why this hasn't been merged yet? TypeScript supported modules from 1.5+ (besides is anyone is even still using older versions?). For those working on older projects that cannot target ES6 or use module loaders this would be most useful. Currently we have to manually add the line which means not being able to use package managers...

2 years and this is still open! @marwahaha Anything?
Want to review that pr above?

Sorry this is causing you pain.
This is a breaking change, as listed above.
When the maintainers have time to make such a change, we hope to include a fix for this.

Hey Kunal,
This is not causing me anything.
I was just looking around, thought to help you guys as you guys seem pretty
busy.
Nothing else.
On Sat, May 30, 2020, 2:31 AM Kunal Marwaha<EMAIL_ADDRESS>wrote:

Sorry this is causing you pain.
This is a breaking change, as listed above.
When the maintainers have time to make such a change, we hope to include a
fix for this.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/moment/moment/issues/3808#issuecomment-636190521, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AIE2X24RC6AG53RGFBPY76TRUAPDXANCNFSM4DCNSBCQ
.

See https://momentjs.com/docs/#/-project-status/


JSON encoding option for hexadecimal

Is your feature request related to a problem? Please describe.
I think #1030 should be revisited. It's standard practice in at least the crypto industry, maybe others, to marshal byte slices to hexadecimal rather than base64. There are literally dozens of projects maintaining forks of this repo because the json encoding package does not support this. This would be a 3 or 4 line change. Obviously if the protobuf spec calls for base64 encoding you can leave the base64 the default. But there's no reason to not include a marshal option for hexadecimal.
Maintaining forks used to be at least be someone easy when the encoding was in the jsonpb package as the footprint was fairly small. Now with all the restructuring and heavy use of internal packages the only way to maintain a fork of the encoding package is to maintain a fork of the entire repository.
Describe the solution you'd like
A EncodeBytesAsHex option in the MarshalOptions.
Describe alternatives you've considered

Maintaining a fork of the entire protobuf repo
Writing a large amount of custom marshaling code

Nothing has changed to this situation from what was already said in https://github.com/golang/protobuf/issues/1030#issuecomment-583511554
If you think this is a valuable feature, then it needs to be brought up in the main protobuf package: https://github.com/protocolbuffers/protobuf/issues
While no one is arguing that this wouldn’t be a short 3–4 line change, we must strictly hold to the standards for compatibility reasons. If it’s not in the main protobuf spec, we cannot do anything about it.

Closing, as a duplicate of an existing closed ticket, and nothing has changed since.


Reported average mate distances are often nonsensical

Evaluating some results of a simulation recently, I noted some cases where an off-target match of a variant was selected as the "true" call while the real origin of the variant was designated as a no-call. The reason is that the average distance of mate read mappings was slightly smaller for the former locua than for the latter. However, the values of these average mate distances don't make sense: they were in the 30kb range for both loci, whereas the insert size for these paired-end reads is 400-500 bp.
This is likely an artifact of how the locations of the mate read mappings are collected and used. If a mate read falls in repetitive DNA, it will likely map to multiple locations. Currently kevlar averages over all locations for each read. It would make more sense to chose the smallest distance per read for each candidate variant call.

In at least one case I've examined in detail, there are no multiple mate read mappings. However when compared to the possible variant calls, some mappings are hundreds of base pairs away, several are tens of thousands of base pairs away, and a few are hundreds of thousands of base pairs away. So taking the average of all these values doesn't really make sense.
One approach I tried is to discard any mate read mappings that are > 10 kb away and then take the average distance of the remaining mappings. This gives much more sensical values, but an off-target call still takes the cake.

Well, after a bit more digging, I happened across the XA tags in the mate read SAM alignments. These tags provide info on alternate alignments and, when thrown on the pile, give the correct call in this example. I'll need to see how this affects results overall before I do anything so rash as to merge these changes into master.


Make support_sz part of interp_method

If I understand correctly, support_sz is determined by interp_method.
In that case, why not make support_sz a function attribute, for example:
@support_sz(4)
def cubic(x):
    fw, to_dtype, eps = set_framework_dependencies(x)
    ...

And in the code, you will only need to pass interp_method and get the support size from interp_method.support_sz
?

implementing the decorator:
def support_sz(sz):
     def wrapper(f):
         f.support_sz = sz
         return f
     return wrapper

Thanks Shai, that's a great advice! fixed.


Way to set user's position locked in place.

I checked everything on MapController but I couldn't find anything to make map locked in one place? I might be missed something.
If it's not present, how about implementing it? There is tracking feature for user so It will easy to implement, I guess?
Or just don't let user to drag map?

can you provide more information of your use case ?

I want to lock map's center position somewhere in map. I think this can be done with using goToLocation and calling another method to disable user's interaction with map.

ok i will add that feature by the middle of this week will be ready

In android the map is locked but in ios you can rotate it. Doing so the marker orientation does not follow marker rotation. At best for now. Can you disable map rotation in ios ?


chore(main): release 1.5.0

:robot: I have created a release beep boop
1.5.0 (2024-08-28)
Features

inline: transformations can replace selections (b8ca077)

Bug Fixes

inline: replace method now works (ffceaf7)

This PR was generated with Release Please. See documentation.

:robot: Created releases:

v1.5.0
:sunflower:


[DOCS] Spelling error in a Spanish translation

Code of Conduct

[X] I have read and agree to the GitHub Docs project's Code of Conduct

What article on docs.github.com is affected?
https://docs.github.com/es/get-started/exploring-integrations/github-developer-program#ready-to-join-the-github-developer-program
What part(s) of the article would you like to see updated?
The Spanish text in the mentioned section has a spelling error: comañías should be changed to compañías.
Additional information
No response

@Panquesito7 Thanks for reaching out, and flagging this! Since we us an internal, automated solution for translations, I will flag your request for our team 💛
For more information on translations, please see https://github.com/github/docs/blob/main/contributing/types-of-contributions.md#earth_asia-translations ✨

@Panquesito7 Thank you again for raising the flag on this spelling error! While we do not have an ETA on when this will be fixed, the appropriate team has been notified ✨ I'll go ahead and close out this issue 💛