New package: TmleCLI v0.9.0

Registering package: TmleCLI
Repository: https://github.com/TARGENE/TmleCLI.jl
Created by: @olivierlabayle
Version: v0.9.0
Commit: 7f01114dbec8826e78aa855b3610f5bf965116dc
Reviewed by: @olivierlabayle
Reference: https://github.com/TARGENE/TmleCLI.jl/commit/7f01114dbec8826e78aa855b3610f5bf965116dc#commitcomment-145606681

I’m confused about the documentation linked from the README being for TargetedEstimation.jl. TmleCLI seems like a questionable package name.

I’m confused about the documentation linked from the README being for TargetedEstimation.jl. TmleCLI seems like a questionable package name.

Thank you for having a look, this is probably because you looked at the stable documentation. The latter should be updated by this release. The dev contains the changed name TmleCLI.jl. TmleCLI stands for TMLE command line interface, it is a companion package to the TMLE package. It is a more acurate description of what the package actually does than TargetedEstimation.jl which is why I renamed it.

I see… that makes sense. By today's standards, I'm not sure if we'd still merge a TMLE.jl package. As the number of packages in General has grown since 2021, we've tended to get stricter about package naming. But TMLE.jl exists, which in my book makes it fair game for "addon" packages using it as part of their name. Also, CLI is a ubiquitous abbreviation that, I think, is fine for package names. With that in mind, I would strongly prefer going back to https://github.com/JuliaRegistries/General/pull/113582 and naming this package TMLECLI.jl. The TMLE gives the context for the package, and it should remain in the original uppercase spelling. Yes, that makes the package fail the automatic checks, and it will have to be merged manually. But it's a better name than TmleCLI, and I would strongly support a manual merge (unfortunately I don't have permissions to merge myself). Changing upper/lower-case in a package name simply to make the automatic checks happy is never a good idea.
Alternatively: Does this have to be an independent package? It might be better to make it a sub-package of TMLE, which would be loaded as using TMLE.CLI.

The aim is to keep TMLE.jl lightweight and not import the whole MLJ universe in it. This is done in TMLECLI.jl as well as providing higher level routines that can be used either from Julia itself or as a standalone app. So the TMLE.CLI wouldn't work in this case I think.
I agree with your point and will revert to TMLECLI.jl!

Closing in favor of https://github.com/JuliaRegistries/General/pull/113802


Doesnt Build.... (dev or master branch)

Looks like the method name was changed.. but startup.cs file wasnt changed....
src/sourceDev.WebApp/Startup.cs
Showing the top match Last indexed a day ago
83	            services.AddScoped<cloudscribe.Web.Navigation.INavigationNodePermissionResolver, cloudscribe.SimpleContent.Web.Services.PagesNavigationNodePermissionResolver>();
84
85	            services.AddCloudscribeCore(Configuration);
86
87	            services.Configure<List>(Configuration.GetSection("ContentProjects"));

sorry about that, a little packaging mishap, should be all better now if you open a command window on the solution folder and run the command
dotnet restore --no-cache

that solution is really for developing the code for SimpleContent, most people should use the StarterKit solutions instead

Starter kits strengthen as well....
Sent from my iPhone

On Jun 21, 2017, at 9:04 AM, Joe Audette<EMAIL_ADDRESS>wrote:
sorry about that, a little packaging mishap, should be all better now if you open a command window on the solution folder and run the command
dotnet restore --no-cache
that solution is really for developing the code for SimpleContent, most people should use the StarterKit solutions instead
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.


check for hash algorithm is supported in BcryptHasher and ArgonHash…

I am closing this pull request because it lacks sufficient explanation, tests, or both. It is difficult for us to merge pull requests without these things because the change may introduce breaking changes to the framework.
Feel free to re-submit your change with a thorough explanation of the feature and tests - integration tests are preferred over unit tests. Please include it's benefit to end users; the reasons it does not break any existing features; how it makes building web applications easier, etc.
Thanks!


Routing containerd to keep its state in /persist if possible

Trivial change that moves containerd state to /persist (if /persist is available). This is done in preparation for relying much more heavily on containerd services for content, volume and tasks support.
Hey @deitch -- please take a look -- this should provide a baseline for your work on making content available in containerd view.

Yup @eriknordmark -- that's pretty much the idea. Content (blobs including layers) and Volumes are going to be managed under /persist/containerd

The larger comment is whether we need to be conserned about the integrity of these directories in /persist (e.g., could we have similar issues as with rsyslogd not handling its own corruption).
Probably makes sense to test this by forcing reboot/watchdog/poweroff while containerd is updating the directory.

@eriknordmark agreed 100% -- but just like with rsyslogd -- there's one way to find out ;-) More seriously, there are parts of /contaienrd that are runtime only and can be nuked at will on reboot. There are parts that need to keep our content and volumes. In general, given the environments in which containerd is being used today -- I'd expect it to be pretty resilient in dealing with failures of its more permanent parts -- but we shall see.
The good news in all of this is that containerd is not dependent on anything in /persist/containerd when it comes to running the "system" containers. So I fully expect it to come up and only barf when content/volumes management gets triggered. At which point, even if containerd dies (worse case scenario) system containers will keep on running.
It probably would be a good idea to start watchdogging containerd itself though -- I'll do it as a separate PR.

I have no issue with storing /var/lib/containerd on /persist in principle. I do have some questions or concerns: linuxkit (taken from docker/docker) by default uses /containers// for the root for each container. I don't quite recall how these play with containerd itself, but worth checking into.

@deitch -- that I checked -- there are no changes in any of that. That's the beauty of the fully expanded filesystem under /containers/* so that it doesn't trigger any of the containerd content/volume management services.

this seems a strange place to put it, as it initializes /persist itself. Is there somewhere else that we do initialization of things in /persist, like downloads/ and such? This feels a bit strange here.

It is a bit strange (hence the comment right before that code block) but the other place that does it is pillar (device-steps.sh).
By the time we hit pillar it is already too late to have runtime state in /persist/containerd, however, it may be not too late to have content/volumes management state adjusted.
In fact, that may help us in controlling (to @eriknordmark point the resiliency of containerd).
Hm. Tell you what -- let me merge this PR as-is -- and I can experiment with trying to run this code block into device steps if containerd stays cools with me switching its snapshot and content storage space underneath it.


Fixed parsing valid OpenAPI 2.0 with undeclared tags.

This patch fixes the following:
Traceback (most recent call last):
  File "/home/phil/build/apidocs/env/local/lib/python2.7/site-packages/sphinxcontrib/swaggerdoc/swaggerv2_doc.py", line 228, in run
    groups = self.group_tags(api_desc)
  File "/home/phil/build/apidocs/env/local/lib/python2.7/site-packages/sphinxcontrib/swaggerdoc/swaggerv2_doc.py", line 200, in group_tags
    groups[tag].append((path, method_type, method))
KeyError: '/some_api_path/'

which happens when the root tags element does not contain some of the tags mentioned within Operation objects. However, the document passes validation, and the OpenAPI 2.0 Specification says:

Not all tags that are used by the Operation Object must be declared. The tags that are not declared may be organized randomly or based on the tools' logic.

Thank you @tuffnatty for your contributions!


updateSize() taking into account an offset in pixels?

Hello!
Suppose we have an app with two horizontal panels (divisions):
Left panel is 500px width and contains some meta data.
Right panel is fluid (100% - 500px) and contains a map.
There is a need to collapse left panel. Collapsing means left panel becomes 0px width and right panel takes all the width.
After that we call map's updateSize() method... Everything works as expected, but visually we see a map bouncing back to the right (by 500px / 2)?
That is undesirable... Ideally we want one of these:

Map doesn't bounce back to the right... It just fills right panel (previously white space) with remaining data...
Map visually stays at the same place on the screen... [map should immediately pan to the right by X map units, corresponding to 500px?]

P. S. The same technique should work with left panel expansion (0px -> 500px) also...
Any ideas how to implement this? :)

You can either use

the View padding, Example: https://openlayers.org/en/latest/examples/view-padding.html
Always have the map at the same size, including your panels, and add the panels on top of the map.

shift the map center when a panel is expanded / collapsed

function shiftMapCenter(offset) {
    const view = map.getView();
    const center = view.getCenter();
    const resolution = view.getResolution();
    center[0] += resolution * offset[0];
    center[1] += resolution * offset[1];
    view.setCenter(center);
}


Chinese translation is incomplete

I install incubator-superset 0.37 on window 10, but chinese tranlation is incomplelte.
Expected results
Top menu items such as Dashboards, Charts, Sources, should be translate to chinese.
Actual results
Top menu items such as Dashboards, Charts, Sources, cannot be translate to chinese.
Screenshots

How to reproduce the bug

Go to '...'
Click on '....'
Scroll down to '....'
See error

Environment

superset version: 0.37
python version: 3.8.5
node.js version: 12.18.0
npm version: 6.14.5
OS version: Windows 10

Checklist
Make sure these boxes are checked before submitting your issue - thank you!

[ ] I have checked the superset logs for python stacktraces and included it here as text if there are any.
[ ] I have reproduced the issue with at least the latest released version of superset.
[ ] I have checked the issue tracker for the same issue and I haven't found one similar.

Additional context
Add any other context about the problem here.

@ hengaini2055 you can also join our Superset slack  #localization channel if you have questions on contributing to translation.

I find a solution,compile the messages.po file into messages.mo ,it works

@prs1022 I cannot replay your actions. Could you send the file to<EMAIL_ADDRESS>Thanks!

@hengaini2055 ,the file directory is superset/translations/zh/LC_MESSAGES/message.po, you just compile the message.po to message.mo  in the same directory ,it works .The compile tool I use is Poedit.

messages.mo.zip

@prs1022 Thank you! It does work.


bug: self-signed certificate in certificate chain

IDE Information
JetBrains Rider 2024.1.3
Build #RD-241.17011.166, built on June 7, 2024
Licensed to Koen de vulder
Subscription is active until August 22, 2024.
Runtime version: 17.0.11+1-b1207.24 amd64
VM: OpenJDK 64-Bit Server VM by JetBrains s.r.o.
Windows 11.0
.NET Core v8.0.1 x64 (Server GC)
GC: G1 Young Generation, G1 Old Generation
Memory: 4056M
Cores: 20
Registry:
ide.experimental.ui=true
ide.new.project.model.index.case.sensitivity=true
Non-Bundled Plugins:
com.jetbrains.space (241.17011.48)
ru.adelf.idea.dotenv (2024.1)
com.intellij.ml.llm (241.17011.2)
com.github.dinbtechit.vscodetheme (1.10.10)
com.sourcegraph.jetbrains (6.0.12)
com.mallowigi (97.0.0)
izhangzhihao.rainbow.brackets (2024.2.4-241)
Bug Description
i switched from github copilot to cody and when i turn on the vpn, i receive this error when trying to chat.
This doesnt happen when i am using copilot or if i am not using the vpn.
This is breaking and would like to get an answer asap or i will be forced to switch to copilot again.
Additional context
Stacktrace: self-signed certificate in certificate chain

Hi @androbro, can you please share the full stacktrace? 🙏

going to close this, if this is still an issue feel free to re-open


[Feature Request]: Enhancing the Book Categories UI

Is there an existing issue for this?

[X] I have searched the existing issues

Feature Description
Improve the visual appeal and user engagement of the "Book Categories" section by incorporating relevant icons for each category.
By focusing on these use cases and benefits, the enhancements to the "Book Categories" section can lead to a more engaging and user-friendly experience on your website.
Use Case
User Interaction:
Enhanced card design can encourage users to click on categories, leading to more engagement with the content.
Responsive Design:
Well-designed cards can adapt to different screen sizes, improving usability on mobile devices.
Benefits
-A more visually appealing and organized "Book Categories" section that draws users' attention.
-Enhanced user interaction through improved iconography and card design, leading to potentially increased engagement with the content.
Add ScreenShots

Priority
High
Record

[X] I have read the Contributing Guidelines
[X] I'm a GSSOC'24 contributor
[X] I have starred the repository

@Trisha-tech  please review this issue i really have good ideas for the UI

please assign this to me

Hey @Trisha-tech  I am very keen to work on this issue . I would be really happy if you could assign this issue to me.


Remove need for Camera permission

Hi folks,
Is it possible to modify card.io so that it does not require camera permissions in the Manifest i.e. by just requiring it to capture an image with an intent and decode that instead? As that would be a great improvement and not freak out users too much.

:+1:


The speed of batch sampler

I use the batch sampler in this repo, but the data fetch speed is quite slow, which is ~250s for 50 batches. The batch size is 256, P=32, K=8, use 4 workers and 4 GPUs. Have you encountered with this problem?

The 250s is only for data loading, and the time for model training is ~40s


Passing an ID into a modal?

Appologies if this has been asked before or if this isn't the right place, I was looking for an answer to the following question.
I'm working on a component that uses Ember's each function to generate a table from some data. I then want to have a button on each row that will open a modal for me to edit/delete the data in that row.
For this to happen I would need to pass in the ID of the row that the modal was clicked on. Is it possible for me to do this? I didn't see any direct way in the docs. (http://www.ember-bootstrap.com/api/classes/Components.Modal.html)

Not sure I understand this. Can you share some code, please?
And btw, for more general questions there is the #-bootstrap channel on the Ember Slack!

Sorry, must have missed the Slack link. I'll use that next time for sure!
game-table.hbs.txt
I have attached the component I am working on. There is a table that displays the model data with a 'modify' button on each row in the table. That would then open a modal for me to edit the data or delete it. Maybe I'm wrong, but I would need to pass in the id of the data that was clicked on into the modal for me to then use Ember's findRecord function to get the data to be edited or deleted.
Thanks for the help!

I think you could call a custom action on your game-table.js (I guess a component, or controller?):
<td>{{#bs-button onClick=(action "openModal" game)}}Open Modal{{/bs-button}}</td>

This action would receive the game model corresponding to the row you clicked on as its parameter, which you can use to assign the selected game (e.g this.set('selectedGame', game)) and open the modal. Then you can use selectedGame in the modal's body to bid to the needed properties.

Closing this as it is not a bug/issue in e-b itself...


Update to use doctests, and work with stack

The test-suite for this package has been disabled in stackage because of this outdated dependency. When a fix is published to hackage could you please send a PR to re-enable the tests to stackage (it's in the skipped-tests section) or ping me?
Thanks!


Fix NullPointerException in FuseableStreamMessage

Related issue: #4852
Motivation:
FuseableStreamMessage.collect() throws a NPE when only mapError() is applied to a normal StreamMessage.
StreamMessage.of(1, 2, 3, 4)
             .mapError(IllegalStateException::new)
             // Raises a NullPointerException
             .collect().join();

The function field in FuseableStreamMessage can be null if no map() is applied to FuseableStreamMessage.
https://github.com/line/armeria/blob/871d87297e4d051241589cb1ae95641cbc83f880/core/src/main/java/com/linecorp/armeria/common/stream/FuseableStreamMessage.java#L162
The problem only happens when collect() method is called. subscribe() method already takes the case into account.
Modifications:

Use the original object as is if function is null.

Result:

You no longer see NullPointerException when .mapError() is applied to StreamMessage
Closes #4852

Thanks @ikhoon for the quick fix (which LGTM)!
Before we upgrade our Armeria dependency to pick up this fix, is adding a no-op .mapData(d => d) a reasonable and sustainable workaround?

Right. Adding .mapData(d => a) is a correct workaround to avoid the problem.


Rotation craft level 80, 40 durability, not working properly.

Required Information
Class: Alchemist
Level: 80
Craftsmanship: 2135
Control: 1987
CP: 497
Recipe Name: Tincture of Strength
Recipe Level: 80
Solver Seed: 122068
With that stats, the solver makes the craft to be done at 100% both Quality and Progress, when i used the macro provided by the solver, the craft neither reach the quality or the progress. Is that normal?

They are still trying to get all of the numbers right for 71-80. we don't have all the correct progress/quality numbers. we are trying to get spreadsheets of proper numbers so calculations can be done

With that stats, the solver makes the craft to be done at 100% both Quality and Progress, when i used the macro provided by the solver, the craft neither reach the quality or the progress. Is that normal?

New level 80 formula deployed to beta site today. Please retest.

Thanks to @yls888 and @SaltFish-X, we have a new set of formulas for progress and quality increase. These changes are available on the beta site (ffxiv-beta.lokyst.net). Please let me know if these discrepancies are resolved.


use camunda-release-parent 3.3

we are still on 2.5

fixed with 0487bb721ed0e34f185fe6105e56fe83b5599b05


partially replace the net by the netip for ip validate

Please provide a description of this PR:
partially implement issue https://github.com/istio/istio/issues/39348

@saltbo: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio
b22ce9aa04d4e8b2a6eb540705cde58706e4d2e7
link
true
/test lint

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@saltbo: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

gencheck_istio
b22ce9aa04d4e8b2a6eb540705cde58706e4d2e7
link
true
/test gencheck

lint_istio
7ec32bbe3f932d19c7c1b2c72760a88a6f3816e6
link
true
/test lint

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@saltbo: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio
7ec32bbe3f932d19c7c1b2c72760a88a6f3816e6
link
true
/test lint

gencheck_istio
7ec32bbe3f932d19c7c1b2c72760a88a6f3816e6
link
true
/test gencheck

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@saltbo: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio
7ec32bbe3f932d19c7c1b2c72760a88a6f3816e6
link
true
/test lint

gencheck_istio
7ec32bbe3f932d19c7c1b2c72760a88a6f3816e6
link
true
/test gencheck

integ-security-istiodremote_istio
70635893bb27d2df53f36d7b487cc2361278c9cf
link
true
/test integ-security-istiodremote

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@saltbo: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

gencheck_istio
7ec32bbe3f932d19c7c1b2c72760a88a6f3816e6
link
true
/test gencheck

integ-security-istiodremote_istio
70635893bb27d2df53f36d7b487cc2361278c9cf
link
true
/test integ-security-istiodremote

lint_istio
70635893bb27d2df53f36d7b487cc2361278c9cf
link
true
/test lint

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


meson: Add upstream patch to stop failing on skipped tests

Motivation for this change
The nixos-unstable channel is currently blocked by a gjs build failure introduced by the Meson 0.55.0 upgrade (d8ac41f86394365f8319d8b37fd25e6a7ba7d904, #93011). Meson now incorrectly treats skipped tests as failed. This is an upstream bug fixed in mesonbuild/meson#7525. Pull in this patch.
See also https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=966923.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Should go to staging or staging-next though. cc @FRidh

I've triggered a Hydra build. By the end of the day it should be good to merge staging-next into master or simply cherry-pick this to master.


JamfPackageUploader keeps uploading to JSS even though PKG is present and replace is False

JamfPackageUploader: ID: 797 NAME: iTerm2-3.5.5.pkg
JamfPackageUploader: Package ID: 797
JamfPackageUploader: Package 'iTerm2-3.5.5.pkg' already exists: ID 797
JamfPackageUploader: Number of File Share DPs: 0
JamfPackageUploader: Handling Cloud Distribution Point
JamfPackageUploader: Not replacing existing iTerm2-3.5.5.pkg as 'replace_pkg' is set to False. Use replace_pkg='True' to enforce.
JamfPackageUploader: Checking for existing authentication token
JamfPackageUploader: Checking https://blahblah.jamfcloud.com against https://blahblah.jamfcloud.com
JamfPackageUploader: URL and user for token matches current request
JamfPackageUploader: Existing token is valid
JamfPackageUploader: Not updating package metadata
JamfPackageUploader: ID: 797
JamfPackageUploader: Package 'iTerm2-3.5.5.pkg' metadata exists: ID 797
JamfPackageUploader: Uploading package to Cloud DP
JamfPackageUploader: Package upload attempt 1
JamfPackageUploader: Output file is:  /tmp/jamf_upload_pmrvo45m/jamf_upload_riilpd9_.txt
JamfPackageUploader: curl command: /usr/bin/curl --location --dump-header /tmp/jamf_upload_pmrvo45m/curl_headers_from_jamf_upload.txt https://blahblah.jamfcloud.com/api/v1/packages/797/upload --header User-Agent: JamfUploader/2<IP_ADDRESS> --request POST --silent --show-error --header authorization: Bearer eyJhbGciOiJIUzI1NiJ9.eyJhdXRoZW50aWNhdGVkLWFwcCI6IkdFTkVSSUMiLCJhdXRoZW50aWNhdGlvbi10eXBlIjoiSlNTIiwiZ3JvdXBzIjpbXSwic3ViamVjdC10eXBlIjoiSlNTX1VTRVJfSUQiLCJ0b2tlbi11dWlkIjoiOGFjMzhhZjgtNjg5My00MDA0LTlkZTEtNGI4OTkzN2EyZGEzIiwibGRhcC1zZXJ2ZXItaWQiOi0xLCJzdWIiOiIxNDQiLCJleHAiOjE3MjkzNTc4NzV9.vDEvW_7nkev-9NzF8KLB4cVPoCowusGcWV8-Dyb-gc --header Content-type: multipart/form-data --form<EMAIL_ADDRESS>--output /tmp/jamf_upload_pmrvo45m/jamf_upload_riilpd9.txt --cookie-jar /tmp/jamf_upload_pmrvo45m/curl_cookies_from_jamf_upload.txt --cookie /tmp/jamf_upload_pmrvo45m/curl_cookies_from_jamf_upload.txt
JamfPackageUploader: Package upload 'iTerm2-3.5.5.pkg' upload successful
JamfPackageUploader: HTTP response: 201

As you can see for the output above, JamfPackageUploader sees the existing PKG in Jamf, Reports its ID and states "Not replacing existing iTerm2-3.5.5.pkg as 'replace_pkg' is set to False. Use replace_pkg='True' to enforce."
However you can see that it does then go ahead and replaces the PKG in jamf.  This happens for all my JamfPackageUploader recipes and started about 2 days ago

Going back and using bb367b380b5f6da47fc031842ef367be620d1788 in the autopkg/grahampugh-recipes repo fixes the problem

Hi, thanks for this, I'm aware of the problem and working on a fix.

Hi again, I just pushed a change that hopefully fixes this. Please can you try again?

Great, then I'll merge the changes over.

Done


Include CoreTelephony

I would like to know whether you are planning some API to view call log. For now I can see some plugins/modules which allow to read files so that I can read a proper file but as far as it seems to be so large it is a performance hit.

Getting into React Native right now, you should be expecting to write some native code, unfortunately. Write an adapter and share it with us!

@jtremback is right, this will need to come in the form of an external library. .If you're up for writing one, check out the Native Module docs and let me know if you need a hand - you can ping me in irc @notbrent or here!


Remove CSharpKeywordKind

This type effectively duplicates a lot of Roslyn's SyntaxKind. So we just use that instead.

@dotnet/razor-compiler for review. This is an easily-extractable part of the lexer change, so I went ahead and pulled it out.

/azp run


Add an EnableLegacyResourceCheck flag to Pilot Discovery component.

Disabled by default, this option enables the non-HA resource check which can recreate CRDs when they are not found in Kubernetes. The flag is being added to work around an open issue istio#6977

I suggest renaming this to "autoregisterCRD".. I don't see what is legacy about this..

I suggest renaming this to "autoregisterCRD".. I don't see what is legacy about this..

From @kyessenov: This code is from pre-HA and pre-helm dates. I think it's fine to remove
the logic around deleting CRD entirely.
I may have unintentionally extrapolated here, but it seems like the CRDs should be in a good state before Pilot has started.  Otherwise when running in HA (or otherwise), it's unclear what the state of the system should be.  Regardless, I think this change will enable those who want to "install-crds" to do so, but it's safer to avoid managing them at runtime.  If Pilot restarts for any reason, it's best to avoid modifying CRDs as it can impact online traffic.

Maybe use --install-crds to match kubernetes kubebuilder project.

I'm at the behest of the Istio dev group here, and happy to make this rename, but it's a bit misleading.  The feature will attempt to install CRDs if it is "unable to detect them", not necessarily if they aren't present.  The deletion upon failure to read is where the real danger lies.

Would "--enable-crd-management" work as a flag?  If so, I can update the documentation to reflect the updated understanding.

I'm including in the usage documentation that Pilot will attempt to clean-up upon a failure during resource creation.

Installing CRDs if they aren't present is arguably useful in some cases. I'm not sure there is a viable use case for uninstalling CRD when the process exists (i.e. pod dies). Can we simply remove the unregister logic altogether? Tests are relying on that anymore.

I'm including in the usage documentation that Pilot will attempt to clean-up upon a failure during resource creation.

Installing CRDs if they aren't present is arguably useful in some cases. I'm not sure there is a viable use case for uninstalling CRD when the process exists (i.e. pod dies). Can we simply remove the unregister logic altogether? Tests are relying on that anymore.

My guess for why the deregister call is there is for the case where Pilot fails to create all the CRDs it doesn't leave the cluster in an inconsistent state.  That said, I'm happy to remove the deregister logic.  However, I still think it's a good idea to include the "install-crds" flag, but I can leave it enabled by default.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: greghanson
If they are not already assigned, you can assign the PR to them by writing /assign @greghanson in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

pilot/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kdillane: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-dashboard.sh
fd7ba05914a91b3a572e6fe9665863365e2c8120
link
/test e2e-dashboard

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kdillane: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-dashboard.sh
fd7ba05914a91b3a572e6fe9665863365e2c8120
link
/test e2e-dashboard

prow/e2e-bookInfoTests-v1alpha3.sh
fd7ba05914a91b3a572e6fe9665863365e2c8120
link
/test e2e-bookInfo-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kdillane: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-dashboard.sh
fd7ba05914a91b3a572e6fe9665863365e2c8120
link
/test e2e-dashboard

prow/e2e-bookInfoTests-v1alpha3.sh
fd7ba05914a91b3a572e6fe9665863365e2c8120
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
fd7ba05914a91b3a572e6fe9665863365e2c8120
link
/test istio-pilot-e2e-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kdillane: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-dashboard.sh
fd7ba05914a91b3a572e6fe9665863365e2c8120
link
/test e2e-dashboard

prow/e2e-bookInfoTests-v1alpha3.sh
fd7ba05914a91b3a572e6fe9665863365e2c8120
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
fd7ba05914a91b3a572e6fe9665863365e2c8120
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-simpleTests.sh
fd7ba05914a91b3a572e6fe9665863365e2c8120
link
/test e2e-simple

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

I'm seeing failures related to pulling images: * command failed: "Error from server (BadRequest): container "citadel" in pod "istio-citadel-5cc4d9fdbc-x5tbh" is waiting to start: trying and failing to pull image\n" exit status 1

/test e2e-bookInfo-envoyv2-v1alpha3

/retest

Any assistance here would be appreciated.  The failures seem primarily to be located in mixer tests.  It's unclear how this change could be related to these failure.

New changes are detected. LGTM label has been removed.

@kdillane: PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: ayj
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: hklai
If they are not already assigned, you can assign the PR to them by writing /assign @hklai in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

I've reverted my changes and am running Circle CI tests against the HEAD of the branch when i started.  In theory these should pass.

@kdillane: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
6de1cbd64e167c5520f2562d61077d3094b26aeb
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kdillane: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
6de1cbd64e167c5520f2562d61077d3094b26aeb
link
/test istio-unit-tests

prow/istio-presubmit.sh
6de1cbd64e167c5520f2562d61077d3094b26aeb
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kdillane: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
6de1cbd64e167c5520f2562d61077d3094b26aeb
link
/test istio-unit-tests

prow/istio-presubmit.sh
6de1cbd64e167c5520f2562d61077d3094b26aeb
link
/test istio-presubmit

prow/e2e-mixer-no_auth.sh
3c6697b0b7a75490dd09e5d26fde30675942ae3a
link
/test e2e-mixer-no_auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

On a "fresh" commit, the tests still failed.  However, fewer tests have failed.


HHH-11186 - Add examples for all Hibernate annotations

I integrated the Pull Request after doing some changes. Check out the commit.
The changes that I've done are mostly related to:

Using a single model for all examples
Cascading only makes sense from parent to child entities, not the other way around
Removed the System.out.println calls
Use the JPA cascade wherever applicable instead of the Hibernate specific ones

There are still some cascade types that might need to be documented:

REFRESH:: cascades the entity refresh operation.
REPLICATE:: cascades the entity replicate operation.


No indication of not logged in

When the user is not logged in to any social networks, we still show "Loading uProxy Friends" followed by a blank buddy list (with the person watermark).  This seems like it may be confusing.

Seems like this has been fixed, right @dborkan?

Yup - closing this as we have a redesigned empty buddylist screen:


Try deploying project to heroku (not done)

Forked main branch:
https://github.com/Koro999/ClotheStation
Will test deployment form here

Deployment tested... Fri, Sep 2:47pm.
https://clothestation-f1993bd32a3d.herokuapp.com/
works beautifully.


Auto Mode

@OfficialEsco This should help for packages with Static URL's
.\YamlCreate.ps1 -AutoUpdate
.\YamlCreate.ps1 Google.Chrome 94.0.4606.6 -> microsoft#28530

Enable the setting:
"`nEnableDeveloperOptions: true" |
Out-File -Encoding ASCII -append  $(Join-Path $env:LOCALAPPDATA -ChildPath 'YamlCreate\Settings.yaml')

A bit hard to test as of now, but i did force a issue:
If the PackageVersion is the same the script crashes 👀

A bit hard to test as of now, but i did force a issue:
If the PackageVersion is the same the script crashes 👀

Should be fixed now; Forgot that it could be used to update singletons to multimanifests

That is actually not what i was thinking about, but it does solve all those issues 😁
Since i doubt i can test this, there is no ProductCode prompt, so how is the ProductCode logic?
I think this is mergable if the answer is the way i think it works 👌

That is actually not what i was thinking about, but it does solve all those issues 😁
Since i doubt i can test this, there is no ProductCode prompt, so how is the ProductCode logic?
I think this is mergable if the answer is the way i think it works 👌

If the installer

That is actually not what i was thinking about, but it does solve all those issues 😁
Since i doubt i can test this, there is no ProductCode prompt, so how is the ProductCode logic?
I think this is mergable if the answer is the way i think it works 👌

It attempts to find the product code for all installers. If it finds one in the AppLocker info, it will add/update the product code to be the one found. If it cannot find one, it removes any old values and leaves it undefined as it is an optional field

There is however one ProductCode issue overall, we add the ProductCode to some exe installers that don't have Publisher/PackageName, these are not inside bracket { } and they are static.
Currently we have to retype them or in this add it after, would you be able to Capture this and add it to the ProductCode variable?

I think it would be possible to add the logic for if the installer file ends in .exe and has a product code defined, don't remove the product code; Unless you think it needs to be more complex than that?

Ooooo yes that would probably be a better detection method

Ooooo yes that would probably be a better detection method

Easy to add too; See latest commit

That feature also needs to be added to option 2 btw

That feature also needs to be added to option 2 btw

Updated there too; Had to use installer type in that case because of the option to not download the file, but it should be functionally equivalent

Aight it does work as expected
However its a lill bit too unfriendly when using simple update
This part needs a rework
[Optional] Enter the application product code. Looks like {CF8E6E00-9C03-4440-81C0-21FACB921A6B}
ProductCode found from installer:
Can be found with get-wmiobject Win32_Product | Sort-Object Name | Format-Table IdentifyingNumber, Name -AutoSize
ProductCode:

Aight it does work as expected
However its a lill bit too unfriendly when using simple update
This part needs a rework
[Optional] Enter the application product code. Looks like {CF8E6E00-9C03-4440-81C0-21FACB921A6B}
ProductCode found from installer:
Can be found with get-wmiobject Win32_Product | Sort-Object Name | Format-Table IdentifyingNumber, Name -AutoSize
ProductCode:

Prolly better to merge this and do another PR?

Yeah; Probably best to handle it separately; Ideally it should detect the product code automatically and handle the same as autoupdate?

Yeah; Probably best to handle it separately; Ideally it should detect the product code automatically and handle the same as autoupdate?

Yeah i guess we can add the ProductCode automatically as that is requested
I still think we should have this prompt sort of
If ProductCode found
[Optional] Enter the application product code.
ProductCode found from installer:
Note: If this is incorrect input the correct ProductCode, else press Enter
ProductCode:

If not found (MSI and EXE?)
[Optional] Enter the application product code.
Note: Can be in the registry at `HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\Windows\CurrentVersion\Uninstall\`
ProductCode:

Optional for MSI if not found
[Optional] Enter the application product code. Looks like {CF8E6E00-9C03-4440-81C0-21FACB921A6B}
Can be found with get-wmiobject Win32_Product | Sort-Object Name | Format-Table IdentifyingNumber, Name -AutoSize
ProductCode:


Adopt a search path for bridgeable types in component modules (no longer just in Foundation)

Required for the work in https://github.com/apple/swift-corelibs-foundation/pull/1799.

@jrose-apple All this code currently runs on all OSes, including where Swift Foundation is not available. As a reminder, Swift Foundation may be available and must be functional on Darwin as we target that platform for test purposes only (which is why all the search paths I introduce in this patch include the Swift-prefixed spelling of the Foundation modules to search in).

cfr. https://github.com/apple/swift-corelibs-foundation/pull/1799

The Linux crash is expected without the SCF changes; the macOS pass was not. Trying to build a toolchain with this so that I can try building SCF on Darwin and reproduce the crash I'm seeing in apple/swift-corelibs-foundation#1799

Can one of the admins verify this patch?

Please update the base branch to main by Oct 5th otherwise the pull request will be closed automatically.

How to change the base branch: (Link)
More detail about the branch update: (Link)


Alarmo Action / Notification keep putting mode type even if remove

Alarmo Version
v1.9.3
HA Version
2022.5.5
Bug description
If we create actions or notifications, the mode which limit the action to specific arm modes is optional. However, if we delete all the modes (away, home) and save the notifications/ actions, then open that notifications/ actions, the modes are not deleted.

.
Steps to reproduce
As per bug description
Relevant log output
No response

I changed this behaviour in v1.9.4.
Please close the issue after confirming the problem is solved for you after updating.

I have update to v1.9.4, while the is no longer mode to limit action / notification, however, it remove the ability to add the mode. That is the mode is no longer being save, it is the inverse of the old behaviour.

I don't understand what you mean.
Starting from:

I can add modes:

And after saving they are still there.
I can also remove one or more afterwards:

And save them.
What am I missing?

What happen to me after I add the modes, and save it, and when I open back the notification / action, the mode is gone. Let me try to reboot my HA, and clear my browser cache once more and report back.

I have reboot my HA host few times, restart the HA core few times. Removing the cache. Creating a new notification / actions. This is what I found out,

If I only have 2 modes enable in general page (say Armed Home, Armed Away), I can only save one mode in the notification/ action. If I add 2 modes, it will not save it.
If I only have 3 modes enable in general page (say Armed Home, Armed Away, Armed Night), I can only save 3 modes in the notification/ action. If I add 3 modes, it will not save it.

The thing is that if you select all modes, its the same as select none of the modes (because there is nothing filtered out).
This was also the reason why previously all modes would show up by default.
The description of the field says:

Limit the action to specific arm modes

So why would you want to assign all modes? It would not exactly be a limitation.
Anyway, I prefer to keep things intuitive for everyone. What do you see as easiest to understand?

I see the logic that you are implementing. My understanding while trying to do this, if nothing selected, means that only sensors with (Always) mode is activated. In my case, I have a panic button at home, which if push ( even when the system is not armed ) will trigger the alarm. I'm trying to implement if this is happened, it will activate certain action - which is different from the other modes.
Anyway, thank you for the great program you have created here and I love it. I think I could find way around this, which could serve the same purpose.


'Collection Letter' Drop-Down

On the 'Creation of Collection Letter' window, it would be nice to understand why the "Collection letter" field has an option of "None".  I'm not sure what purpose that is for.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: bffb5971-919f-c1f5-c5de-2d5eba676362
Version Independent ID: 8f1d627f-09ff-4049-9d8e-e91b7831890d
Content: Process collection letters - Finance & Operations | Dynamics 365 | #MSDyn365FO
Content Source: articles/financials/accounts-receivable/tasks/process-collection-letters.md
Service: dynamics-ax-applications
GitHub Login: @ShivamPandey-msft
Microsoft Alias: shpandey

On the 'Creation of Collection Letter' window, it would be nice to understand why the "Collection letter" field has an option of "None". I'm not sure what purpose that is for.
Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: bffb5971-919f-c1f5-c5de-2d5eba676362
Version Independent ID: 8f1d627f-09ff-4049-9d8e-e91b7831890d
Content: Process collection letters - Finance & Operations | Dynamics 365 | #MSDyn365FO
Content Source: articles/financials/accounts-receivable/tasks/process-collection-letters.md
Service: dynamics-ax-applications
GitHub Login: @ShivamPandey-msft
There is no purpose on the "None" option. Is it legacy enum value that has lingered around.

Thank you for your feedback.
@ShivamPandey-msft, can you please take a look?

Bug 335734 created to track this issue.

There is no purpose of the "None" option. Is it legacy enum value that has lingered around.


End button does not work with Xfce4 Terminal

Description of the problem or steps to reproduce
Whenever I press the end (should go to the end of the line) key, micro pastes the clipboard instead of moving the cursor. The Home key works.
With gnome-terminal it works as expected.
Specifications
You can use micro -version to get the commit hash.
Commit hash: cfdaf0e
OS: Linux 64bit (Ubuntu 16.04)
Terminal: Xfce4-Termial, ($TERM: == rxvt-unicode-256color)

Why is TERM set to rxvt-unicode-256color because the terminal isn't actually sending rxvt escape sequences, it's sending xterm sequences. I recommend setting TERM=xterm-256color and everything will work better.

I have no problems with xfce4-terminal, and TERM=xterm-256color is set by default?

Yeah, now it works :+1:  Probably I've changed this ages ago for something and simply forgot to revert it... Anyways thank you


Add comments around packages

Additionally add @pcorpet to the contributors list.

Hi @pcorpet  - does this look good?
Would you like me to upload a version 1.8 to pypi which includes your latest changes around no-package imports?

:+1:
No need for a version 1.8 on PyPi: I discovered that bug because of a bug in my own code (I had forgotten to add a package in some protos), and I've fixed my bug already.


runtime: Avoid some gcc specific errors

For better support with building with gcc as part of a serenity build

Closing this, as of today seems to compile fine with gcc and the existing options.


Generalize parts of kubectl-gadget top gadgets

Generalize parts of kubectl-gadget top gadgets
All of the top gadgets of kubectl-gadget have similar variables, methods and code. This is an attempt to extract the similarities and put them into a central location top.go
Idea about this came when i started converting the gadgets to use the columns library. (Therefor the branch name 😅)
Found out later: https://github.com/inspektor-gadget/inspektor-gadget/issues/849

Hi @blanquicet and @flyth ,
This whole PR is still a draft but i wanted to get some comments on the first commit top/<gadget>/types.go: Generalized SortBy.
Main changes are in pkg/gadgets/top/top.go and pkg/gadgets/top/<gadget>/types/types.go
What i tried to solve
SortedBy looks like a type/struct which could be shared between all of the top gadgets.
Also there were 2 methods which were the same.
What i did
Instead of having an own Datatype for the enumerations, they are all ints. Bad for type checking. Is there another possiblity to have a common type shared or an easy way with generics?
Additionally i introduced a SortBy interface which i maybe have to use in a future commit when i generalize the top gadgets even more (Should have added it with a later commit then probably)
basicSortBy is now a struct and implements all needed functions. The only thing for the gadgets to do in type.go is to pass a map into the function
Questions from me
What possibilites does Go give me as a programmer to make this SortBy type/struct/whatever to be more generic?
What can be implemented more elegent and efficient?

Thanks for creating more generic code!
Regarding a generic solution for the sorting that happens on the client as well as on the server side:
The columns library already has a subpackage sort to deal with that - so once we migrate the top gadgets to use columns, we can just use that in a pretty generic way.
In the past, we have discussed performance implications of using reflection - sorting was the part that was most affected, as values have to be read and compared quite often. I had a couple of ideas in mind that I now have implemented in #1081, which speeds up sorting (and filtering) by a lot - it's getting much closer to native speed. As far as I see it, we can use this code now for both sides (inside the gadget and inside kubectl gadget) and further reduce the code needed. If you need any help with that, please let me know.

Will adapt to use the columns sort as soon as possible.
Another question: Is the sorting in tracer.go of the deployed gadgets really necessary? Currently the statistics are sorted once on the gadget and another time on kubectl-gadget.
Is the output of these top gadgets used anywhere else where the consumer does not sort it themself?

Will adapt to use the columns sort as soon as possible.
Another question: Is the sorting in tracer.go of the deployed gadgets really necessary? Currently the statistics are sorted once on the gadget and another time on kubectl-gadget.
Is the output of these top gadgets used anywhere else where the consumer does not sort it themself?

The output is limited to a number of entries per node (and later on in total) - that's why we need sorting in both places.

Prepended commits which uses the sort method of the colums library. This way it was easier to generalize.
Notes/Questions

I can't seem to totally generalize the Callback method since i have no type information about the Event. When i try add that via generics i get errors when unmarshalling the JSON
I can't seem to totally generalize the PrintStats method since the top ebpf gadget adds node information to the stats and the others don't

Nit not related to coding: Present tense is preferred for the commit titles -> https://git.kernel.org/pub/scm/git/git.git/tree/Documentation/SubmittingPatches?h=v2.36.1#n181.


Buffout 4 changes the behavior of Keywords used in Workshop menus

In Fallout 4, Workshop Menus are comprised of FormList and Keyword objects, with the structure primarily dictated by FormList objects and additional data and structure provided by Keywords. The use of FormLists in this context is straightforward and self explanatory, but Keywords have two separate uses that do not overlap in unmodified Fallout 4:

A Keyword that is used as a recipe filter for COBJ records will provide a leaf menu when included in a Workshop FormList, opening up to display all items made available to craft via the COBJ recipes and conditions.
A Keyword in the first slot (index 0) of a Workshop FormList is used to provide that FormList's menu with a name, and in the event that the Keyword is associated with an ArtObject, to provide that menu with an icon.

The second behavior is used for every menu except WorkshopMenuMain, which has no need for an icon or name due to never appearing in another menu. Thus far, all behaviors mentioned remain unchanged while using Buffout 4. However, there is another behavior associated with the second Keyword type, that is removed when the Buffout 4 workshop menu fix is enabled. In the base game, the Keywords used in index zero of a Workshop FormList (aside from WorkshopMenuMain) will have the leaf menu functionality suppressed.
This can be clearly demonstrated via "WorkshopRecipeFilterDecor "Decorations" [KYWD:0006D5A3]", which has a duplicate mattress recipe associated with it. In the base game, this mattress recipe is completely inaccessible unless a mod changes the recipe's filter Keyword. However, with the Buffout 4 workshop menu patch enabled, the recipe becomes accessible via a new leaf menu, "Decorations > Decorations", in which it is the only item.
This is an issue that has an available mod patch, and has been rejected for patching by the Unofficial Fallout 4 Patch due to only becoming visible via code injection. I filed a bug report on the main Buffout 4 tracker, and it was rejected by Fudgyduff as "Won't Fix", citing the leaf menu at the start of WorkshopMenuMain as proof that Keywords only have one behavior in Workshop menus, and appearances to the contrary are likely bugs in Bethesda's code.
This difference in behavior can result in mods that lose menus if developed by authors utilizing the fix and used by players who don't use Buffout 4 (or if ported to console). It can also result in mods gaining undesired menus if developed by authors who do not utilize Buffout 4 and used by players who do.
I am mostly filing this issue to help create a searchable trail, so anyone affected by it will be able to identify the cause, and potentially adjust mods accordingly. Ideally, I feel this is a behavior that should be reimplemented so that Buffout 4 and the base game treat Workshop menus in the same way, but I do not know whether this is an intentional or unintentional change since it is not documented by Buffout 4's settings or public changelogs.

Thanks for the detailed report. I'll tag this as a bug since it probably is an unintended side effect. Hopefully someone wants to fix it and submits a PR.


List selection support

This adds support for List.selection using LiveBinding. You can specify a String value or a set of String values as the selection.
<list selection="selection">
    <%= for item <- 1..10 do %>
        <text id={item |> Integer.to_string}><%= item %></text>
    <% end %>
</list>

defmodule ... do
  bindings(selection: ["1", "3", "5"], single_value_selection: "1", empty_single_selection: nil)

  ...
end

https://user-images.githubusercontent.com/13581484/218798033-150c6b1e-b9c9-4baa-9636-3a899be3153e.mp4
If you start with a value of nil or a single string, it will only allow one row to be selected at a time.

I've included support for onMove with a phx-move event.
<list selection="selection" phx-move="on_move">
    <%= for item <- @items do %>
        <text id={item |> Integer.to_string}><%= item %></text>
    <% end %>
</list>

def handle_event("on_move", %{ "index" => index, "destination" => destination }, socket) do
  # There may be a more efficient/idiomatic way of performing a move in Elixir that I don't know about.
  {element, list} = List.pop_at(socket.assigns.items, index)
  moved = List.insert_at(list, (if destination > index, do: destination - 1, else: destination), element)
  {:noreply, assign(socket, :items, moved)}
end

https://user-images.githubusercontent.com/13581484/218810733-d0369bdf-eadd-4d1b-a138-144f21782e17.mp4

I cannot immediately find the video but @chrismccord has a demo of LiveView drag/drop. I'll check with him if he is using phx-move or a different event name. I think we should try to align when possible.


Where is Xbox Live Scope?

Core Library
MSAL Node (@azure/msal-node)
Core Library Version
1.1.0
Wrapper Library
Not Applicable
Wrapper Library Version
None
Description
I am making a Application Which uses Microsoft Authentication To Get Xbox Live Infos but I am unable to find a Xbox Live scope in API Permission Tab. So can you please tell me where is the Xbox live scope in Azure AD
MSAL Configuration
No response
Relevant Code Snippets
No response
Identity Provider
Azure AD / MSA
Source
External (Customer)

@Nishant1500 While you may find the official XBox Live REST API documentation useful, this isn't an issue that involves MSAL, so unfortunately we are not able to assist you. Please try contacting Azure Support for more help.

Oh then I will contact Azure Support. Thanks anyways! :)


Missing comma

echo 'block_id_predicate = new Serializer(
    "block_id_predicate"
    id: bytes 20
)'|decaffeinate

The decaffeinate output should have a comma after the string "block_id_predicate"
var block_id_predicate = new Serializer(
    "block_id_predicate"
    {id: bytes(20)}}
);

Fixed in v1.40.10.


WIP: Adding KubernetesComputeResourcesPatch to Loki charm

Issue

This WIP PR will fix #190 by implementing the lib that is under development in:  https://github.com/canonical/observability-libs/pull/19
Solution

Context

Testing Instructions

Release Notes

As-is, itests will fail until:

https://github.com/canonical/microk8s-core-addons/pull/73
https://github.com/juju/python-libjuju/pull/696

are merged and released.


DXVK with Wine on macOS?

Since Wine for macOS supports Vulkan via MoltenVK, could DXVK somehow be used with Wine to run DX10/11 Windows games on macOS?

There's an issue on the MoltenVK bug tracker about this: https://github.com/KhronosGroup/MoltenVK/issues/203
tl;dr: Metal doesn't support all Vulkan features that DXVK relies on.

Also, at least one upcoming port of ours (CodeWeavers') will use DXVK to support D3D11 graphics on Mac.

In the future would is it likely to be able to play DX10/11 games on macOS with MoltenVK and DXVK with Wine?

In the future is it likely that Wine will be able to play DX10/11 games on macOS (with MoltenVK and DXVK)?

There might be some games that work but a lot of them probably rely on features that MoltenVK cant implement.

@doitsujin According to the aforementioned KhronosGroup/MoltenVK#203, CodeWeavers has made some customisation to DXVK or something to allow DirectX11 to work in CrossOver 20. Do you think there is any possibility for macOS now?

Do you think there is any possibility for macOS now?

I think all CW did was disable a few hard requirements of DXVK.
FWIW there are still a lot of issues with it like the lack of geometry shaders.
Aside from that, I don't think anyone is willing to maintain Mac OS support in DXVK considering you'd have to buy Apple hardware first.

I am never touching that shitty platform again.
If someone wants to maintain support for that they are welcome to pull request genuine fixes. I'd rather not us have hacks that will only work in games specifically designed for it though.

CW have their own fork of DXVK that works around MVK's lack of features. There won't be official support for it in upstream DXVK since none of us here use, or care about, Mac OS X. It's nice that it works, though.

I don't want to offend anyone but I think macOS don't deserve DXVK support. Don't use Apple's shitty hardware and software - problem solved.

well this has certainly changed, the M1 Max macs that released yesterday promise good performance and it'd be a huge waste to let it rot just like that, no?


.css file not bundled while using builtin:swc-loader

I am using a package called plyr-react  for video player support in an application. plyr-react exports a plyr.css file, which is not being included in my final bundle even after being referenced in the entry file.
Here is my rspack config
module.exports = {
  mode: "development",
  entry: './src/javascripts/index/index.js',
  output: {
    filename: "main.[contenthash].js",
    path: path.resolve(__dirname, "dist")
  },
  plugins: [
    new rspack.CssExtractRspackPlugin({
      filename: '[name].[contenthash].css',
      chunkFilename: '[id].[name].[contenthash].css'
    }),
    new HTMLWebpackPlugin({
      filename: 'index.html',
      template: './index.html',
    }),
    new CleanWebpackPlugin()
  ],
  module: {
    rules: [
      {
        test: /\.css$/,
        use: [rspack.CssExtractRspackPlugin.loader, "css-loader"],
      },
      {
        test: /\.scss$/,
        use: [rspack.CssExtractRspackPlugin.loader, "css-loader", "sass-loader"]
      },
      {
        test: /\.js(x)?$/,
        exclude:
          /node_modules/,
        use: [
          {
            loader: 'builtin:swc-loader',
            options: {
              jsc: {
                parser: {
                  syntax: "ecmascript",
                  jsx: true,
                },
                transform: {
                  react: {
                    pragma: 'React.createElement',
                    pragmaFrag: 'React.Fragment',
                    throwIfNamespace: true,
                    development: false,
                    useBuiltins: false
                  }
                },
              },
            }
          },
        ],
      }
    ]
  },
  optimization: {
    splitChunks: {
      chunks: 'all',
      name: false,
      maxInitialRequests: 25,
      maxAsyncRequests: 25,
    },
  },
};

And here you can see me referencing plyr.css along with css-component.css.

Here are the bundled files

And here you can see the bundled main.css, which does not include CSS code from plyr.css

This issue does not occur when I use babel-loader.

Node - v18.12.0;
yarn - 1.22.19;
@rspack/core - 1.0.11;
@rspack/cli - 1.0.8;
Here is a reproduction demo:
https://github.com/saidarshan27/swc-plyr-css

try it

try it
minimizer: [new rspack.LightningCssMinimizerRspackPlugin({       removeUnusedLocalIdents: false,    })]

no, still the same.
actually the reproduction demo is a dumbed down version of the code.
In the actual codebase, the class definitions from plyr.css are being used.
Let me also add that, if I import the plyr.css inside the css-component.css. The styles are being loaded properly, only when I import it directly in index.js, styles aren't being included in the bundled main.css.

This might be related to the value of sideEffects in the package.json.

Yes @inottn , it is related to sideEffects. I removed the sideEffects from package.json of plyr-react.
Now the styles are being bundled properly.
But what changes should I make in my rspack configuration such that, the styles are bundled even though the sideEffects is false

In fact, the sideEffects here should not be set to false because your CSS imports have side effects. You can assign the correct value to sideEffects based on the actual situation.

The problem is I cannot change the package.json of the package. It is a third party package that we are using.
This problem does not occur when I use babel-loader instead of swc-loader. So I was thinking if there was anything I was missing in the rspack configuration that would fix this? @inottn

I tried optimization.sideEffects: true  in my configuration but it does not fix the problem.
I wanted why this problem is occurring when I use builtin:swc-loader and not occurring when I use babel-loader.

Try setting optimization.sideEffects: false?

yes setting it to optimization.sideEffects: false does the job.
But does this any how affect the tree shaking process for other modules?


Tweet for 1.25 Enhancements Freeze Delay

Provide the actual tweet content between the commented colons

Enhancements Freeze for the Kubernetes v1.25 release cycle is delayed to June 23.
Read more on this GitHub discussion:
https://github.com/kubernetes/sig-release/discussions/1933

/cc @cici37

Thanks for taking care of this!


Persistent rg.exe blocking Visual Studio Code Updates

For a long time (dating back to Windows 10 and early Visual Studio Code releases), I've consistently encountered an issue where every Visual Studio Code update fails. I'm currently using Windows 11 23H2 and the latest version (1.92) of Visual Studio Code. After investigating, I identified that the problem stems from rg.exe, located at:
$HOME\AppData\Local\Programs\Microsoft VS<EMAIL_ADDRESS>
I've tried shutting it down via the Taskbar, using PowerToys Unlock with File Locksmith, and even SysInternals Process Explorer, but nothing can terminate or stop this file. After restarting, I have only a few seconds to delete it, even without opening VS Code. It seems something triggers it to run and it remains active indefinitely. However, if I’m quick enough to delete it after a restart, the VS Code update proceeds without issues.
Any advice on resolving this would be greatly appreciated.

I'm having the same issue.  It also can't be killed form an elevated command prompt:

I'm able to determine it's a 'stuck' search that was executed within a workspace:


Panic if stop is called before start

This was obviously an error on my part, but discovered that calling Stop without calling Start will block since nothing is receiving c.stop <- struct{}{}. This is definitely a programmer error, I suggest panicking if the cron is not running.
// Stop the cron scheduler.
func (c *Cron) Stop() {
	if !c.running {
		panic("cron: not running")
	}
	c.stop <- struct{}{}
	c.running = false
}

panic will cause the process to quit. I think it's overkilling for a server program to quit if the admin click the wrong button.

I think it's overkilling for a server program to quit if the admin click the wrong button.

The assumption here is that given a UI where you can start or stop a cron schedule. A more fundamental issue is that there is no way to checking if a cron is running, i.e. c.running is not accessible. If c.Running() was added, then clicking the wrong button could be guarded. I still think that it is incorrect to call Stop without calling Start since if it silently returns, then the programmer may miss the fact that it was never running to begin with.

Right, but it's still not a library's responsibility to quit my process. The library should just tell me what happened, and I will decide what to do.

The library should just tell me what happened, and I will decide what to do.

Fair enough. So then the alternative would be for Stop to return an error such as ErrNotRunning?

Fair enough. So then the alternative would be for Stop to return an error such as ErrNotRunning?

Agreed. That would be the most appropriate way.

I think it would be ok if it also silently did nothing.  Happy to accept a PR for this!

I think it would be ok if it also silently did nothing. Happy to accept a PR for this!

@robfig Happy to. Would you prefer that so it would be backwards compatible change?

It's worth pointing out that adding a single return value to a func that previously returned nothing happens to be a strictly backwards compatible change.

Just didn't seem like anyone would care to check it and do something different. Usually returning an error implies that the operation wasn't done, but in this case the end state is the desired one.

Yeah, I am in agreement.

So if I am not mistaken #36 adds the desired change.


ci: disable github release for cargo-near-build via cargo-dist

attempt 2

https://github.com/near/cargo-near/actions/runs/10670519858/job/29574678361

https://github.com/near/cargo-near/actions/runs/10845014216

@race-of-sloths ping

@dj8yfo Thank you for your contribution! Your pull request is now a part of the Race of Sloths!
Weekly streak is on the road, smart strategy! Secure your streak with another PR!

Current status: waiting for scoring
We're waiting for maintainer to score this pull request with @race-of-sloths score [0,1,2,3,5,8,13] command. Alternatively, autoscoring [1,2] will be applied for this pull request
What is the Race of Sloths

Race of Sloths is a friendly competition where you can participate in challenges and compete with other open-source contributors within your normal workflow
For contributors:

Tag @race-of-sloths inside your pull requests
Wait for the maintainer to review and score your pull request
Check out your position in the Leaderboard
Keep weekly and monthly streaks to reach higher positions
Boast your contributions with a dynamic picture of your Profile

For maintainers:

Score pull requests that participate in the Race of Sloths
Engage contributors with fair scoring and fast responses so they keep their streaks
Promote the Race to the point where the Race starts promoting you
Grow the community of your contributors

Feel free to check our website for additional details!

Bot commands

For contributors

Include a PR: @race-of-sloths include to enter the Race with your PR

For maintainers:

Invite contributor @race-of-sloths invite to invite the contributor to participate in a race or include it, if it's already a runner.
Assign points: @race-of-sloths score [1/2/3/5/8/13] to award points based on your assessment.
Reject this PR: @race-of-sloths exclude to send this PR back to the drawing board.
Exclude repo: @race-of-sloths pause to stop bot activity in this repo until @race-of-sloths unpause command is called

@race-of-sloths score 3


your code does not work

500
Server Error

@Engbilal
Are you sure that your APP_DEBUG is true ? Paste me here the error and i will provide you solution

[Thu Jun  8 21:39:39 2023] PHP 8.0.28 Development Server (http://<IP_ADDRESS>:8000) started
[Thu Jun  8 21:39:47 2023] <IP_ADDRESS>:51900 Accepted
[Thu Jun  8 21:39:48 2023] <IP_ADDRESS>:51900 Closing
[Thu Jun  8 21:39:48 2023] <IP_ADDRESS>:51904 Accepted
[Thu Jun  8 21:40:32 2023] <IP_ADDRESS>:51904 Closed without sending a request; it was probably just an unused speculative preconnection
[Thu Jun  8 21:40:32 2023] <IP_ADDRESS>:51904 Closing

you should create apache/nginx virtual host and point it to public directory of the project


Introduce restrict, columns in Legend API

Codecov Report

Merging #50 (e733e7e) into main (6c05c86) will increase coverage by 0.00%.
The diff coverage is 96.06%.

@@           Coverage Diff            @@
##             main      #50    +/-   ##
========================================
  Coverage   96.23%   96.24%
========================================
  Files          34       37     +3
  Lines        2101     2266   +165
========================================
+ Hits         2022     2181   +159
- Misses         79       85     +6

Flag
Coverage Δ

pytest
96.24% <96.06%> (+<0.01%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pylegend/core/request/legend_client.py
100.00% <ø> (ø)

.../legend_api/frames/functions/test_drop_function.py
69.64% <ø> (+1.22%)
:arrow_up:

.../legend_api/frames/functions/test_head_function.py
100.00% <ø> (ø)

...legend_api/frames/functions/test_limit_function.py
100.00% <ø> (ø)

.../legend_api/frames/functions/test_take_function.py
100.00% <ø> (ø)

...core/tds/legend_api/frames/legend_api_tds_frame.py
75.00% <66.66%> (-1.48%)
:arrow_down:

pylegend/core/tds/tds_frame.py
83.33% <75.00%> (-1.67%)
:arrow_down:

pylegend/core/tds/tds_column.py
96.47% <87.50%> (-0.97%)
:arrow_down:

...pi/frames/legend_api_applied_function_tds_frame.py
92.30% <90.90%> (-0.55%)
:arrow_down:

...s/legend_api/frames/functions/restrict_function.py
93.75% <93.75%> (ø)

... and 9 more


re-enable qt5-activeqt

https://github.com/microsoft/vcpkg/issues/19922#issue-986445169
for my reference
Installed by qt5-declarative:x64-windows
    tools/qt5/bin/Qt5QuickControls2.dll ** owned by qt5-quickcontrols2
    tools/qt5/bin/Qt5QuickTemplates2.dll ** owned by qt5-quickcontrols2
    tools/qt5/bin/Qt5VirtualKeyboard.dll ** owned by qt5-virtualkeyboard
    tools/qt5/bin/plugins/platforminputcontexts/qtvirtualkeyboardplugin.dll
    tools/qt5/bin/qml/Qt/labs/calendar/qtlabscalendarplugin.dll
    tools/qt5/bin/qml/Qt/labs/location/locationlabsplugin.dll
    tools/qt5/bin/qml/Qt/labs/platform/qtlabsplatformplugin.dll
    tools/qt5/bin/qml/QtAudioEngine/declarative_audioengine.dll
    tools/qt5/bin/qml/QtBluetooth/declarative_bluetooth.dll
    tools/qt5/bin/qml/QtCharts/qtchartsqml2.dll
    tools/qt5/bin/qml/QtDataVisualization/datavisualizationqml2.dll
    tools/qt5/bin/qml/QtGraphicalEffects/private/qtgraphicaleffectsprivate.dll
    tools/qt5/bin/qml/QtGraphicalEffects/qtgraphicaleffectsplugin.dll
    tools/qt5/bin/qml/QtLocation/declarative_location.dll
    tools/qt5/bin/qml/QtMultimedia/declarative_multimedia.dll
    tools/qt5/bin/qml/QtNfc/declarative_nfc.dll
    tools/qt5/bin/qml/QtPositioning/declarative_positioning.dll
    tools/qt5/bin/qml/QtPurchasing/declarative_purchasing.dll
    tools/qt5/bin/qml/QtQml/RemoteObjects/qtqmlremoteobjects.dll
    tools/qt5/bin/qml/QtQuick/Controls.2/Fusion/qtquickcontrols2fusionstyleplugin.dll
    tools/qt5/bin/qml/QtQuick/Controls.2/Imagine/qtquickcontrols2imaginestyleplugin.dll
    tools/qt5/bin/qml/QtQuick/Controls.2/Material/qtquickcontrols2materialstyleplugin.dll
    tools/qt5/bin/qml/QtQuick/Controls.2/Universal/qtquickcontrols2universalstyleplugin.dll
    tools/qt5/bin/qml/QtQuick/Controls.2/qtquickcontrols2plugin.dll
    tools/qt5/bin/qml/QtQuick/Controls/Styles/Flat/qtquickextrasflatplugin.dll
    tools/qt5/bin/qml/QtQuick/Controls/qtquickcontrolsplugin.dll
    tools/qt5/bin/qml/QtQuick/Dialogs/Private/dialogsprivateplugin.dll
    tools/qt5/bin/qml/QtQuick/Dialogs/dialogplugin.dll
    tools/qt5/bin/qml/QtQuick/Extras/qtquickextrasplugin.dll
    tools/qt5/bin/qml/QtQuick/PrivateWidgets/widgetsplugin.dll
    tools/qt5/bin/qml/QtQuick/Templates.2/qtquicktemplates2plugin.dll
    tools/qt5/bin/qml/QtQuick/VirtualKeyboard/Settings/qtquickvirtualkeyboardsettingsplugin.dll
    tools/qt5/bin/qml/QtQuick/VirtualKeyboard/Styles/qtquickvirtualkeyboardstylesplugin.dll
    tools/qt5/bin/qml/QtQuick/VirtualKeyboard/qtquickvirtualkeyboardplugin.dll
    tools/qt5/bin/qml/QtQuick/XmlListModel/qmlxmllistmodelplugin.dll
    tools/qt5/bin/qml/QtRemoteObjects/qtremoteobjects.dll
    tools/qt5/bin/qml/QtScxml/declarative_scxml.dll
    tools/qt5/bin/qml/QtSensors/declarative_sensors.dll
    tools/qt5/bin/qml/QtWebChannel/declarative_webchannel.dll
    tools/qt5/bin/qml/QtWebSockets/declarative_qmlwebsockets.dll
    tools/qt5/bin/qml/QtWebView/declarative_webview.dll
    tools/qt5/bin/qml/QtWinExtras/qml_winextras.dll
    tools/qt5/bin/qml/org/kde/kholidays/kholidaysdeclarativeplugin.dll
    tools/qt5/bin/qml/org/kde/kitemmodels/itemmodelsplugin.dll
    tools/qt5/bin/qml/org/kde/solid/solidextensionplugin.dll

qt5-quickcontrols2 depends on qt5-declarative so how can qt5-declarative install a dll build by qt5-quickcontrols2 : cc @BillyONeal
qt5-virtualkeyboard depends on qt5-quickcontrols which depends on qt5-declarative.... this does not make any sense....
This only makes sense if the installed tree was not correctly cleaned/removed.

The colmap failure is https://github.com/microsoft/vcpkg/pull/19608

No version bumps needed the recent merges to vcpkg required a rebuild of qt5-base any way so just reenabling qt5-activeqt is enough.

Depends on https://github.com/microsoft/vcpkg/pull/19608.

@JackBoosY Let me remove the dependency

I believe just adding a downstream thing to ci.baseline.txt while removing something in the "cone of dependencies" shouldn't be a blocker.
Thanks @Neumann-A for your help in Qt bizarroworld once again :D


Rust build plugin

This is an experiment to try and recreate the CocoaPods build scripts (that were removed in 86d1257ab56ccc02b958ca1ee1afcaf52bd053c2) as a Swift Package Manager build plugin. If we can do so, then we can use that for regular development, and swap it out with a binaryTarget in release PRs (the tagged release commits would use the binary targets, and then the commit immediately afterwards reverts to using the build plugin).
To test this draft PR, create a symlink in the root directory named rust, pointing to the rust folder in a local checkout of zcash-light-client-ffi at the correct tag. Once we get the build plugin fully working, I will rework this PR to import the Rust code from zcash-light-client-ffi (after which we can archive that repository).
Part of https://github.com/Electric-Coin-Company/zcash-light-client-ffi/issues/96.

This code review checklist is intended to serve as a starting point for the author and reviewer, although it may not be appropriate for all types of changes (e.g. fixing a spelling typo in documentation).  For more in-depth discussion of how we think about code review, please see Code Review Guidelines.
Author

[ ] Self-review: Did you review your own code in GitHub's web interface? Code often looks different when reviewing the diff in a browser, making it easier to spot potential bugs.
[ ] Automated tests: Did you add appropriate automated tests for any code changes?
[ ] Code coverage: Did you check the code coverage report for the automated tests?  While we are not looking for perfect coverage, the tool can point out potential cases that have been missed.
[ ] Documentation: Did you update Docs as appropiate? (E.g README.md, etc.)
[ ] Run the app: Did you run the app and try the changes?
[ ] Did you provide Screenshots of what the App looks like before and after your changes as part of the description of this PR? (only applicable to UI Changes)
[ ] Rebase and squash: Did you pull in the latest changes from the main branch and squash your commits before assigning a reviewer? Having your code up to date and squashed will make it easier for others to review. Use best judgement when squashing commits, as some changes (such as refactoring) might be easier to review as a separate commit.

Reviewer

[ ] Checklist review: Did you go through the code with the Code Review Guidelines checklist?
[ ] Ad hoc review: Did you perform an ad hoc review?  In addition to a first pass using the code review guidelines, do a second pass using your best judgement and experience which may identify additional questions or comments. Research shows that code review is most effective when done in multiple passes, where reviewers look for different things through each pass.
[ ] Automated tests: Did you review the automated tests?
[ ] Manual tests: Did you review the manual tests?You will find manual testing guidelines under our manual testing section
[ ] How is Code Coverage affected by this PR? We encourage you to compare coverage befor and after your changes and when possible, leave it in a better place. Learn More...
[ ] Documentation: Did you review Docs, README.md, LICENSE.md, and Architecture.md as appropriate?
[ ] Run the app: Did you run the app and try the changes? While the CI server runs the app to look for build failures or crashes, humans running the app are more likely to notice unexpected log messages, UI inconsistencies, or bad output data.

@y4ssi and I have been discussing this approach privately. I'd like to share some thoughts I had
We originally moved out of the "build system" approach because of (swift) developer friction points:

Tooling at the time failed a lot.
made Swift developers download the rust environment to contribute or build locally.
Builds were not reproducible which complicated debugging production issues.
builds (that didn't fail) were slow.

the second point is a "philosophy" thing more than anything. Would mandate Swift developers to download Rust, cargo and rustup to their environment just for them to contribute to a pure Swift change your project?
I believe it was unreasonable from my part as a maintainer.
The rest are "concrete" concerns.
Build reproducibility
Given that Tags can be made so that they point to a binary artifact, production build reproducibility is somewhat guaranteed.
The problem is mostly Local reproducibility, because of the RustLang environment every developer has.
I don't know how you folks are deploying Zashi to Testflight, but if you were to deploy manually from source, then Zashi would build the SDK, the SDK would build Rust via a Plugin, and that would be then archived and uploaded to testflight.
Is there a way that we can set up the environment so that every developer working on the SDK has the same cargo and rust toolchain? Is that possible to enforce to CI runners as well?
I recall this problem was solved in Ruby by a tool call Bundler. It was used in iOS and Mac development to make reproducible CocoaPods builds as well. Is there something like that for Rust?
Build Reliability
At the time (Sept 2019) there were no Swift Package Plugins. So a build system was created to do all the Rust heavy-lifting using cocopods pre and post build hooks. Today, thanks to SPM plugins existing and being mature enough this could be done another way so that the builds are more stable and reliable. Although it has to be noted that swiftpm and Xcode are caching beasts and weirdness is assured
Build times
adding the rust tooling will definitely increase CI build times. I guess that the assessment is that the time spent waiting on builds will be fairly compensated by the time spent working on two different repos.
Future-proof approach
The cocoapods build system was not even "present proof" 😅 but it was what worked at the time.
I think that the zcash-swift-wallet-sdk --> zcash-light-client-ffi  approach is future-proof in terms of
allowing the FFI to move to UniFFI, diplomat or other kind of FFI handling solution. This will be an investment
towards continuing to bake the FFI cake ourselves, rather than going to a unified approach were RustLang FFI
changes are made once without needing Rust developers to work on the FFI of Kotlin and Swift.
Two problems that this PR seems to be trying to address

Repo bloat because of the FFI artifacts
Rust development friction

Problem 1 can be addressed with some approach like the one explored there
Problem 2 is more complex. I think that some questions are worth to be asked and answered:

Should Rust developers be "full-stacking" their way over kotlin-rust and swift-rust?
What's the % of work done on purely on Swift versus the one done in Rust?

Overall comments
I think its worth exploring. But a unified FFI approach with better test surface would be the best.

If we can do so, then we can use that for regular development, and swap it out with a binaryTarget in release PRs (the tagged release commits would use the binary targets, and then the commit immediately afterwards reverts to using the build plugin).

This can possibly be achieved by using conditional compilation within the Package.swift file so that there's an environment variable on the release CI job that is passed to the build, that will make the compiler use the plugin or just compile using a .binaryTarget with an URL and a checksum.

Would you mandate Swift developers to download Rust, cargo and rustup to their environment just for them to contribute a pure Swift change your project?

Yes, because this is not a pure Swift project; it is a hybrid Swift/Rust project. (And they don't even need to do that if they don't build locally and instead rely on CI to check their changes.)
As a Rust developer, I will never have the luxury of not using Xcode (I wish I did) or Swift to contribute a pure Rust change if I want to test that it works. Moreover, the majority of functionality changes in this project require Rust changes, and the current process is so hostile to Rust development that I have on multiple occasions considered quitting entirely. Why should we expect contributors to be more willing to contribute?
Not requiring downstream users of the SDK to install Rust is a much more reasonable goal.

Is there a way that we can set up the environment so that every developer working on the SDK has the same cargo and rust toolchain? Is that possible to enforce to CI runners as well?

Yes, and we already use it. The FFI repo has a rust-toolchain.toml file that tells rustup what toolchain to use by default; that would be migrated to here in this PR once we get the build system working. Any CI that uses rustup (e.g. GitHub Actions, but we can install it on others) will pick it up automatically.
If you aren't using rustup then you might be using a different Rust version, but you cannot use a Rust version older than the MSRV specified in the Cargo.toml, and we bump that regularly to basically track stable Rust. So developers with a too-old Rust version will notice immediately.

adding the rust tooling will definitely increase CI build times. I guess that the assessment is that the time spent waiting on builds will be fairly compensated by the time spent working on two different repos.

There's a bunch of caching we can apply to CI to improve Rust build times (that we already apply in our other repos to great effect). It will be slightly finicky due to building multiple targets at once, but that can be handled.
Moreover, I think for local development it should be possible to only build the target you are deploying to (the simulator, or your local iOS device). That would greatly speed up local recompilations.

allowing the FFI to move to UniFFI, diplomat or other kind of FFI handling solution. This will be an investment
towards continuing to bake the FFI cake ourselves, rather than going to a unified approach were RustLang FFI changes are made once without needing Rust developers to work on the FFI of Kotlin and Swift.

Even in the grand future of UniFFI or Diplomat unifying the Rust backends of the Swift and Kotlin SDKs (which I do want to move towards), we still have the issue of enabling feature branches where the SDKs have partially-implemented features with potentially-breaking changes still to come. Developers need to be able to use any revision of the Rust backend, without requiring it to be in a state suitable for public consumption and subject to backwards compatibility requirements. This requires either that we build and cache binaries for every single commit (including across force-pushes to branches, and across arbitrary forks) that ever occurs on the Rust backend (to ensure that the pure Swift developers can reliably compile no matter what code they checked out), or we need to use local developer compilation. We do not have the devops resources for the former, and my proposal here is the latter.

As a Rust developer, I will never have the luxury of not using Xcode (I wish I did)

As a Swift developer, I will never have the luxury of not using Xcode (I wish I did) 😂
Thanks for the comments @str4d !


Remove unknown reference in index.html

In ./app/index.html there is this comment:
<!-- A lot of magic happens in this file. HtmlWebpackPlugin automatically includes all assets
(e.g. bundle.js, main.css) with the correct HTML tags, which is why they are missing in this HTML
 file. Don't add any assets here! (Check out webpackconfig.js if you want to know more) -->

Since there doesn't seem to be a webpackconfig.js file, do we want to replace it with a reference to
this file
or should we remove (Check out webpackconfig.js if you want to know more)?

Good observation!
I would suggest replacing

(Check out webpackconfig.js if you want to know more)

with

(Check out the webpack config files in internals/webpack for details)

@gihrig Should I make the PR off master or dev? 😄

@kelsonic Always make general PRs against dev.

Got it, thanks!


Debian 10 support

[Enter feedback here]
Are there any timelines for Debian 10 support for either Azure Monitor or VM Insights?
According to documentation, Azure Monitor Agent is supported in Debian 10, but there seems no way to make use of it just installing only Azure Monitor Agent, and attempt to enable monitoring from Azure Monitor ends up attempting to install also Log Analytics agent and Dependency agent, which are not supported.
Thanks!

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: c887fb7a-6d9d-b9f4-4896-5e2fb440ffca
Version Independent ID: 86a368f8-6d32-eba0-db92-8deeee732724
Content: Enable VM insights overview - Azure Monitor
Content Source: articles/azure-monitor/vm/vminsights-enable-overview.md
Service: azure-monitor
Sub-service: virtual-machines
GitHub Login: @bwren
Microsoft Alias: bwren

@juanandmsft Thanks for your feedback! We will investigate and update as appropriate.

@juanandmsft My sincere apologies for delay on getting back to this thread. I am validating this with our internal PG team and as soon as we have an update, will keep this thread updated.

@juanandmsft We really appreciate your patience on this , we did hear back from our product team. It seems that the scenario you called out  should not be happening at all. Installing AMA will not install LA agent or DA today.
However to better understand your issue, the recommendation was to create a support ticket on this and they can help you to further troubleshoot the issue. We will certainly internally track the issue and see if there are document enhancements needed post the resolution of issue and will adopt it accordingly.
At this point it appears that there's no further edits or updates needed to the documentation. We will go ahead and close this issue for now, however if you have any further feedback on the document please tag us in your reply and will be happy to reopen the thread and continue the conversation. Thank you


Update path pattern in .github/labeler.yml

Describe your changes

This PR will update path pattern in .github/labeler.yml.
For example, content/ko/* changes to content/ko/**.
This is required to include subdirectories in the labeling target.

See this basic example from actions/labeler

# Add 'label1' to any changes within 'example' folder or any subfolders
label1:
- example/**

# Add 'label2' to any file changes within 'example2' folder
label2: example2/*

# Add label3 to any change to .txt files within the entire repository. Quotation marks are required for the leading asterisk
label3:
- '**/*.txt'

Related issue number or link (ex: resolves #issue-number)

Ref. #2278
When I created a PR for updating content/ko/contribute/_index.md, the github-actions bot removed the label from the PR.

Checklist before opening this PR (put x in the checkboxes)

[x] This PR does not contain plagiarism

don’t copy other people’s work unless you are quoting and contributing it to them.

[x] I have signed off on all commits

signing off (ex: git commit -s) is to affirm that commits comply DCO. If you are working locally, you could add an alias to your gitconfig by running git config --global alias.ci "commit -s".

oh! Thanks @yunkon-kim
LGTM!

PTAL @jihoon-seo


Add query documentation

This adds sample query documentation with examples

Please squash these if merging, the history is messed up.


Search within installed extensions returns results from the online lists

VSCode Version: 1.5.1

Steps to Reproduce:

Open Installed Extensions.
Enter a search query.

Expected Output:
Return results from within installed extensions.
Actual Output:
Returns results from all available extensions.

I think that's working as intended. Empty query shows all installed extensions, and non-empty query searches against marketplace.

Okay. Didn't pay attention to that. Thanks.


Use Parameters to call up a Chart: Pros and Cons

In preparation for our work on the Feature to use parameters to call up a chart via an API https://github.com/visualize-admin/visualization-tool/issues/1095 in Sprint 5.2, IXT will come up with a list of pros and cons for the approaches, specifically for the published charts and whether these should be added to a database or not.
Notes from Call:
https://www.notion.so/interactivethings/230711-Weekly-Call-c2f104dc802545329dd24ab781a4dd24?pvs=4#680d3579730f412999f2e792bcaf4f8a

Mark will summarize and remind Tobias and Thomas about where the discussion is at to be resumed in the week of 14.08 when Thomas is back.

Weekly Call Notes 22.08.2023:
Mark will reach out to Thomas to coordinate a call this week on Thursday afternoon or Friday.

After a discussion on this topic @bprusinowski has implemented an initial solution approach (PR).
Next steps:

[ ] Validate whether the proposed approach addresses all the requirements
[ ] Summarize outcomes of meeting @adintegra


Templates not working

I keep going around and around with this and can't get templates working.
When I put the "label" back in it works fine with the built-in options render. But with the templates it only renders json code.
I'm using v 3.0.0-beta esm version
Html
<vuemultiselect class="form-select form-select-no-caret"
                                            v-model="SelectedLocation"
                                            track-by="Id"
                                            placeholder="Start typing to find location"
                                            open-direction="bottom"
                                            :options="LocationOptions"
                                            :options-limit="100"
                                            :limit="20"
                                            :searchable="true"
                                            :hide-selected="false"
                                            :close-on-select="true"
                                            :clear-on-select="false"
                                            :multiple="false"
                                            :loading="isSearchingLocation"
                                            :internal-search="false"
                                            :max-height="300"
                                            :show-no-results="false"
                                            :preserve-search="false"
                                            :allow-empty="true"
                                            :reset-after="false"
                                            v-on:search-change="asyncFind"
                                            v-on:select="onSelectedLocationName">
                                <template slot="singleLabel" slot-scope="props">
                                    {{props.option.LocationName}}
                                    {{props.option.HouseNumStreet}}
                                </template>
                                <template slot="option" slot-scope="props">
                                    {{props.option.LocationName}}

                                    {{props.option.HouseNumStreet}}
                                </template>
                            </vuemultiselect>

Here is a simplified version. Templates still don't work.
https://jsfiddle.net/c2e968g5/
I also tried the new scope options with Vue 3 for slots. But it still doesn't work.

    <vuemultiselect
                    v-model="value"
                    placeholder="Start typing to find address"
                    open-direction="bottom"
                    :options="options"
                    :options-limit="100"
                    :limit="20"
                    :searchable="true"
                    :hide-selected="false"
                    :close-on-select="true"
                    :clear-on-select="false"
                    :multiple="false"
                    :internal-search="true"
                    :max-height="300"
                    :show-no-results="false"
                    :preserve-search="false"
                    :allow-empty="true"
                    :reset-after="false">
        <template slot="singleLabel"  v-slot="{ name }">
            {{name}}
        </template>
        <template slot="option" v-slot="{ name, last }">
            {{name}}

            {{last}}
        </template>
    </vuemultiselect>

So I got an answer with my singleLabel slot not working.
https://stackoverflow.com/questions/76130959/i-cant-get-slot-templates-to-work-with-vue-multiselect-3-0-0-beta-1/76131131#76131131
Since more people are going to start using imports and not precompiling. You might want to change all of your pascalCasing to all lowercase.

Thanks for creating an issue @donnyv. We're aware of this (#1680) and a fix is ready for v4 when we get this that stage of the development path

is it a version 4 coming to fix this issue for vue 3?
thank you