prevent Jupyter from being serialised

I have noticed that when I use PyWren over Jupyter notebooks, PyWren detects that it needs to serialise Jupyter module - 14MB in estimate.
is it possible to prevent this part? or maybe we should add Jupyter module to the default runtime.

@omerb01 Can you share DEBUG logs of 1 execution?

@JosepSampe I observed the same...I think if you have couple of Jupiter cells and run PyWren from another cell - you will notice in DEBUG logs that also Jupyter model is serialised..

@JosepSampe I haven't managed to produce DEBUG logs due to #178 , will do that after we will solve these issues with CF team

@omerb01 map(), map_reduce() methods have a special parameter called exclude_modules, used to prevent serializing the desired modules.
Just as an experiment, can you try adding this in the notebook to see what happens?:
pw.map(..., ..., ..., exclude_modules=['jupyter'] )

@JosepSampe was this always present? I didn't knew those parameters..they not documented anywhere

@gilv Yep, this was present from the beginning

@JosepSampe exclude_modules parameter doesn't help in that case because Jupyter comes with a bunch of modules that all sums up in 14MB.
if I use this feature, PyWren doesn't serialise Jupyter but does serialise everything else - 13MB in estimate.
tested it a bit and I think that these are the modules I'm talking about:
  '/Users/omerbelh/.pyenv/versions/3.6.0/lib/python3.6/site-packages/pyrsistent',
  '/Users/omerbelh/.pyenv/versions/3.6.0/lib/python3.6/site-packages/entrypoints.py',
  '/Users/omerbelh/.pyenv/versions/3.6.0/lib/python3.6/site-packages/ipython_genutils',
  '/Users/omerbelh/.pyenv/versions/3.6.0/lib/python3.6/site-packages/ipywidgets',
  '/Users/omerbelh/.pyenv/versions/3.6.0/lib/python3.6/site-packages/backcall',
  '/Users/omerbelh/.pyenv/versions/3.6.0/lib/python3.6/site-packages/prometheus_client',
  '/Users/omerbelh/.pyenv/versions/3.6.0/lib/python3.6/site-packages/colorama',
  '/Users/omerbelh/.pyenv/versions/3.6.0/lib/python3.6/site-packages/wcwidth',
  '/Users/omerbelh/.pyenv/versions/3.6.0/lib/python3.6/site-packages/defusedxml',
  '/Users/omerbelh/.pyenv/versions/3.6.0/lib/python3.6/site-packages/jupyter_client',
  '/Users/omerbelh/.pyenv/versions/3.6.0/lib/python3.6/site-packages/ipykernel',
  '/Users/omerbelh/.pyenv/versions/3.6.0/lib/python3.6/site-packages/testpath',
  '/Users/omerbelh/.pyenv/versions/3.6.0/lib/python3.6/site-packages/bleach',
  '/Users/omerbelh/.pyenv/versions/3.6.0/lib/python3.6/site-packages/IPython',
  '/Users/omerbelh/.pyenv/versions/3.6.0/lib/python3.6/site-packages/decorator.py',
  '/Users/omerbelh/.pyenv/versions/3.6.0/lib/python3.6/site-packages/pexpect',
  '/Users/omerbelh/.pyenv/versions/3.6.0/lib/python3.6/site-packages/traitlets',
  '/Users/omerbelh/.pyenv/versions/3.6.0/lib/python3.6/site-packages/ptyprocess',
  '/Users/omerbelh/.pyenv/versions/3.6.0/lib/python3.6/site-packages/nbformat',
  '/Users/omerbelh/.pyenv/versions/3.6.0/lib/python3.6/site-packages/prompt_toolkit',
  '/Users/omerbelh/.pyenv/versions/3.6.0/lib/python3.6/site-packages/jedi',
  '/Users/omerbelh/.pyenv/versions/3.6.0/lib/python3.6/site-packages/pickleshare.py',
  '/Users/omerbelh/.pyenv/versions/3.6.0/lib/python3.6/site-packages/notebook',
  '/Users/omerbelh/.pyenv/versions/3.6.0/lib/python3.6/site-packages/send2trash',
  '/Users/omerbelh/.pyenv/versions/3.6.0/lib/python3.6/site-packages/parso',
  '/Users/omerbelh/.pyenv/versions/3.6.0/lib/python3.6/site-packages/terminado',
  '/Users/omerbelh/.pyenv/versions/3.6.0/lib/python3.6/site-packages/jupyter_core',
  '/Users/omerbelh/.pyenv/versions/3.6.0/lib/python3.6/site-packages/appnope',
  '/Users/omerbelh/.pyenv/versions/3.6.0/lib/python3.6/site-packages/mistune.py',
  '/Users/omerbelh/.pyenv/versions/3.6.0/lib/python3.6/site-packages/webencodings',
  '/Users/omerbelh/.pyenv/versions/3.6.0/lib/python3.6/site-packages/jsonschema',
  '/Users/omerbelh/.pyenv/versions/3.6.0/lib/python3.6/site-packages/pygments',
  '/Users/omerbelh/.pyenv/versions/3.6.0/lib/python3.6/SocketServer.py',
  '/Users/omerbelh/.pyenv/versions/3.6.0/lib/python3.6/site-packages/pandocfilters.py',
  '/Users/omerbelh/.pyenv/versions/3.6.0/lib/python3.6/site-packages/nbconvert'

@JosepSampe just a minor suggestion regarding exclude_modules parameter:
in DEBUG mode, PyWren prints all modules that it detects for serialising, but when we use this parameter, obviously there are modules that PyWren won't serialise, so I suggest to print all modules that are serialised instead of both.
for example, I get:
2019-08-21 11:49:58,283 [DEBUG] pywren_ibm_cloud.job.serialize: Modules to transmit: {'/Users/omerbelh/.pyenv/versions/3.6.0/lib/python3.6/site-packages/send2trash', '/Users/omerbelh/.pyenv/versions/3.6.0/lib/python3.6/site-packages/plotly', '/Users/omerbelh/.pyenv/versions/3.6.0/lib/python3.6/site-packages/pexpect', '/Users/omerbelh/.pyenv/versions/3.6.0/lib/python3.6/site-packages/defusedxml', '/Users/omerbelh/.pyenv/versions/3.6.0/lib/python3.6/site-packages/metaspace', '/Users/omerbelh/.pyenv/versions/3.6.0/lib/python3.6/site-packages/prompt_toolkit', '/Users/omerbelh/.pyenv/versions/3.6.0/lib/python3.6/site-packages/webencodings', '/Users/omerbelh/.pyenv/versions/3.6.0/lib/python3.6/site-packages/nbformat', '/Users/omerbelh/.pyenv/versions/3.6.0/lib/python3.6/site-packages/seaborn', '/Users/omerbelh/IdeaProjects/WORK/pywren-annotation-pipeline/annotation_pipeline', '/Users/omerbelh/.pyenv/versions/3.6.0/lib/python3.6/site-packages/retrying.py', '/Users/omerbelh/.pyenv/versions/3.6.0/lib/python3.6/site-packages/_plotly_utils', '/Users/omerbelh/.pyenv/versions/3.6.0/lib/python3.6/site-packages/wcwidth', '/Users/omerbelh/.pyenv/versions/3.6.0/lib/python3.6/site-packages/testpath', '/Users/omerbelh/.pyenv/versions/3.6.0/lib/python3.6/site-packages/notebook', '/Users/omerbelh/.pyenv/versions/3.6.0/lib/python3.6/site-packages/jedi', '/Users/omerbelh/.pyenv/versions/3.6.0/lib/python3.6/site-packages/traitlets', '/Users/omerbelh/.pyenv/versions/3.6.0/lib/python3.6/site-packages/pylab.py', '/Users/omerbelh/.pyenv/versions/3.6.0/lib/python3.6/site-packages/terminado', '/Users/omerbelh/.pyenv/versions/3.6.0/lib/python3.6/site-packages/boto3', '/Users/omerbelh/.pyenv/versions/3.6.0/lib/python3.6/site-packages/backcall', '/Users/omerbelh/.pyenv/versions/3.6.0/lib/python3.6/site-packages/pandocfilters.py', '/Users/omerbelh/.pyenv/versions/3.6.0/lib/python3.6/site-packages/_plotly_future_', '/Users/omerbelh/.pyenv/versions/3.6.0/lib/python3.6/site-packages/mistune.py', '/Users/omerbelh/.pyenv/versions/3.6.0/lib/python3.6/SocketServer.py', '/Users/omerbelh/.pyenv/versions/3.6.0/lib/python3.6/site-packages/jupyter_client', '/Users/omerbelh/.pyenv/versions/3.6.0/lib/python3.6/site-packages/parso', '/Users/omerbelh/.pyenv/versions/3.6.0/lib/python3.6/site-packages/elasticsearch_dsl', '/Users/omerbelh/.pyenv/versions/3.6.0/lib/python3.6/site-packages/IPython', '/Users/omerbelh/.pyenv/versions/3.6.0/lib/python3.6/site-packages/s3transfer', '/Users/omerbelh/.pyenv/versions/3.6.0/lib/python3.6/site-packages/ipywidgets', '/Users/omerbelh/.pyenv/versions/3.6.0/lib/python3.6/site-packages/cycler.py', '/Users/omerbelh/.pyenv/versions/3.6.0/lib/python3.6/site-packages/nbconvert', '/Users/omerbelh/.pyenv/versions/3.6.0/lib/python3.6/site-packages/bleach', '/Users/omerbelh/.pyenv/versions/3.6.0/lib/python3.6/site-packages/ptyprocess', '/Users/omerbelh/.pyenv/versions/3.6.0/lib/python3.6/site-packages/ipykernel', '/Users/omerbelh/.pyenv/versions/3.6.0/lib/python3.6/site-packages/prometheus_client', '/Users/omerbelh/.pyenv/versions/3.6.0/lib/python3.6/site-packages/decorator.py', '/Users/omerbelh/.pyenv/versions/3.6.0/lib/python3.6/site-packages/jsonschema', '/Users/omerbelh/.pyenv/versions/3.6.0/lib/python3.6/site-packages/entrypoints.py', '/Users/omerbelh/.pyenv/versions/3.6.0/lib/python3.6/site-packages/pygments', '/Users/omerbelh/.pyenv/versions/3.6.0/lib/python3.6/site-packages/colorama', '/Users/omerbelh/.pyenv/versions/3.6.0/lib/python3.6/site-packages/ipython_genutils', '/Users/omerbelh/.pyenv/versions/3.6.0/lib/python3.6/site-packages/chart_studio', '/Users/omerbelh/.pyenv/versions/3.6.0/lib/python3.6/site-packages/pickleshare.py', '/Users/omerbelh/.pyenv/versions/3.6.0/lib/python3.6/site-packages/appnope', '/Users/omerbelh/.pyenv/versions/3.6.0/lib/python3.6/site-packages/pyparsing.py', '/Users/omerbelh/.pyenv/versions/3.6.0/lib/python3.6/site-packages/jupyter_core', '/Users/omerbelh/.pyenv/versions/3.6.0/lib/python3.6/site-packages/pyrsistent'}

but the only module that PyWren serialise is actually: '/Users/omerbelh/IdeaProjects/WORK/pywren-annotation-pipeline/annotation_pipeline' because I configured exclude_modules for all these modules except annotation_pipeline.
so in this case, I would expect to see only annotation_pipeline module.

@JosepSampe another related suggestion according to: https://github.com/metaspace2020/pywren-annotation-pipeline/issues/39
in addition to exclude_modules parameter, we need also include_modules parameter which defines modules for serialising. all other modules that aren't in the list, won't be serialised.
another thing I want to bring for the discussion is a feature to use exclude_modules or include_modules from PyWren config file, so I don't need to change every map call when I need this feature for a whole project.

@omerb01 I my case I'm not able to reproduce the issue, jupyter is never serialized in my notebooks. In your case, is jupyter serialized in https://github.com/pywren/pywren-ibm-cloud/blob/master/examples/hello_world.ipynb ? or can you provide a concrete example?

@JosepSampe Jupiter isn't serialised in the example you gave me, my mistake when I said that it happens in all cases.
In my case, I use pywren inside a module that we work on (metabolomics annotation pipeline project). in that module we have a few Jupiter notebooks inside so when I run pywren, it detects that it has to serialise our module and I think that because of these notebooks inside, Jupiter module are also marked as to be serialised.

@omerb01 Not sure if it can solve the issue, but in #193 I updated cloudpickle library (which is the reprensible to detect the modules) from version 0.6.1 to 1.2.1. Maybe with this new version pywren avoids to serialize jupyter modules... In any case it would be nice to test it.

@omerb01 @gilv Done in #198
I added include_modules parameter where you can set those modules you want to serialize as @omerb01 suggested. If you explicitly set include_modules=None, no one module will be serialized.
Additionally, now you can set both  include_modules and exclude_modules in configuration, in 'pywren' section.

@omerb01 Did you tested it?

@JosepSampe sorry for the late response.
I think something wrong with the current implementation.
before this update, there were many modules which detected as to be serialise, and now I think that it doesn't detect any module at all - for every example I get
pywren_ibm_cloud.job.serialize: Modules to transmit: None.
example:
import pywren_ibm_cloud as pywren
from colorama import Fore

def map_function(args):
    return Fore.GREEN + "Hello World"

pw = pywren.ibm_cf_executor(log_level='DEBUG')
pw.map(map_function, '', include_modules=['colorama'])
print(pw.get_result())

2019-09-24 10:44:38,610 [DEBUG] pywren_ibm_cloud.executor: ServerlessExecutor created with ID: 4c5ac6e3-2c1d
2019-09-24 10:44:38,610 [DEBUG] pywren_ibm_cloud.storage.backends.ibm_cos: Set IBM COS Endpoint to https://s3-api.us-geo.objectstorage.softlayer.net
2019-09-24 10:44:38,610 [DEBUG] pywren_ibm_cloud.storage.backends.ibm_cos: Set IBM IAM Auth Endpoint to https://iam.cloud.ibm.com/oidc/token
2019-09-24 10:44:38,610 [DEBUG] pywren_ibm_cloud.storage.backends.ibm_cos: IBM COS: Using COS api_key - Requesting new token
2019-09-24 10:44:40,845 [DEBUG] pywren_ibm_cloud.libs.ibm.cloudfunctions_client: IBM CF init for namespace: pywren_dev_us_east
2019-09-24 10:44:40,845 [DEBUG] pywren_ibm_cloud.libs.ibm.cloudfunctions_client: IBM CF init for host: https://us-east.functions.cloud.ibm.com
2019-09-24 10:44:40,846 [DEBUG] pywren_ibm_cloud.libs.ibm.cloudfunctions_client: IBM CF user agent set to: python-requests/2.22.0 pywren-ibm-cloud/1.0.17
2019-09-24 10:44:40,846 [INFO] pywren_ibm_cloud.compute.backends.ibm_cf: PyWren v1.0.17 init for IBM Cloud Functions - Namespace: pywren_dev_us_east - Region: us-east
2019-09-24 10:44:40,846 [INFO] pywren_ibm_cloud.runtime.runtime: ExecutorID 4c5ac6e3-2c1d - Selected Runtime: ibmfunctions/action-python-v3.6 - 256MB
2019-09-24 10:44:40,846 [DEBUG] pywren_ibm_cloud.storage.internal_storage: Runtime metadata not found in local cache. Retrieving it from storage
2019-09-24 10:44:41,710 [DEBUG] pywren_ibm_cloud.runtime.runtime: ExecutorID 4c5ac6e3-2c1d - Runtime ibmfunctions/action-python-v3.6 with 256MB is not yet installed
2019-09-24 10:44:41,710 [INFO] pywren_ibm_cloud.runtime.deploy_utils: Creating new PyWren runtime based on Docker image ibmfunctions/action-python-v3.6
2019-09-24 10:44:41,710 [DEBUG] pywren_ibm_cloud.storage.backends.ibm_cos: Set IBM COS Endpoint to https://s3-api.us-geo.objectstorage.softlayer.net
2019-09-24 10:44:41,710 [DEBUG] pywren_ibm_cloud.storage.backends.ibm_cos: Set IBM IAM Auth Endpoint to https://iam.cloud.ibm.com/oidc/token
2019-09-24 10:44:41,710 [DEBUG] pywren_ibm_cloud.storage.backends.ibm_cos: IBM COS: Using COS api_key - Reusing token
2019-09-24 10:44:41,717 [DEBUG] pywren_ibm_cloud.runtime.deploy_utils: Creating zip action in /Users/omerbelh/IdeaProjects/WORK/pywren-temp/ibmcf_pywren.zip
2019-09-24 10:44:41,744 [DEBUG] pywren_ibm_cloud.libs.ibm.cloudfunctions_client: I am about to create the package pywren_v1.0.17
2019-09-24 10:44:42,376 [DEBUG] pywren_ibm_cloud.libs.ibm.cloudfunctions_client: OK --> Created package pywren_v1.0.17
2019-09-24 10:44:42,376 [DEBUG] pywren_ibm_cloud.libs.ibm.cloudfunctions_client: I am about to create a new cloud function action: ibmfunctions_action-python-v3.6_192MB
2019-09-24 10:44:42,793 [DEBUG] pywren_ibm_cloud.libs.ibm.cloudfunctions_client: OK --> Created action ibmfunctions_action-python-v3.6_192MB
2019-09-24 10:44:42,793 [DEBUG] pywren_ibm_cloud.runtime.deploy_utils: Extracting Python modules list from: ibmfunctions/action-python-v3.6
2019-09-24 10:44:43,838 [DEBUG] pywren_ibm_cloud.libs.ibm.cloudfunctions_client: Delete cloud function action: ibmfunctions_action-python-v3.6_192MB
2019-09-24 10:44:44,256 [DEBUG] pywren_ibm_cloud.libs.ibm.cloudfunctions_client: I am about to create the package pywren_v1.0.17
2019-09-24 10:44:44,673 [DEBUG] pywren_ibm_cloud.libs.ibm.cloudfunctions_client: Package pywren_v1.0.17: resource already exists
2019-09-24 10:44:44,674 [DEBUG] pywren_ibm_cloud.libs.ibm.cloudfunctions_client: I am about to create a new cloud function action: ibmfunctions_action-python-v3.6_256MB
2019-09-24 10:44:46,791 [DEBUG] pywren_ibm_cloud.libs.ibm.cloudfunctions_client: OK --> Created action ibmfunctions_action-python-v3.6_256MB
2019-09-24 10:44:48,016 [DEBUG] pywren_ibm_cloud.storage.backends.ibm_cos: PUT Object runtimes/1.0.17/ibm_cf/us-east/pywren_dev_us_east/ibmfunctions_action-python-v3.6_256MB.meta.json - Size: 7.0KiB - OK
2019-09-24 10:44:48,020 [DEBUG] pywren_ibm_cloud.storage.internal_storage: Runtime metadata found in local cache
2019-09-24 10:44:48,021 [DEBUG] pywren_ibm_cloud.job.job: ExecutorID 4c5ac6e3-2c1d Serializing function and data
2019-09-24 10:44:48,021 [DEBUG] pywren_ibm_cloud.job.serialize: Modules to transmit: None
2019-09-24 10:44:48,022 [INFO] pywren_ibm_cloud.job.job: ExecutorID 4c5ac6e3-2c1d - Uploading function and data
2019-09-24 10:44:48,471 [DEBUG] pywren_ibm_cloud.storage.backends.ibm_cos: PUT Object pywren.jobs/4c5ac6e3-2c1d/6e334ccd/aggdata.pickle - Size: 25.0B - OK
2019-09-24 10:44:48,921 [DEBUG] pywren_ibm_cloud.storage.backends.ibm_cos: PUT Object pywren.jobs/4c5ac6e3-2c1d/6e334ccd/func.pickle - Size: 828.0B - OK
2019-09-24 10:44:48,922 [INFO] pywren_ibm_cloud.invoker: ExecutorID 4c5ac6e3-2c1d - Starting function invocation: map_function() - Total: 1 activations
2019-09-24 10:44:49,558 [DEBUG] pywren_ibm_cloud.libs.ibm.cloudfunctions_client: ExecutorID 4c5ac6e3-2c1d - Function 00000 invocation done! (0.636s) - Activation ID: 8bdbcc2eb8834e229bcc2eb8835e2283
2019-09-24 10:44:49,559 [INFO] pywren_ibm_cloud.executor: ExecutorID 4c5ac6e3-2c1d - Getting results...
2019-09-24 10:45:18,161 [INFO] pywren_ibm_cloud.executor: ExecutorID 4c5ac6e3-2c1d - There was an exception - Activation ID: 8bdbcc2eb8834e229bcc2eb8835e2283
Traceback (most recent call last):

  File "/action/pywren_ibm_cloud/action/jobrunner.py", line 185, in run
  File "/action/pywren_ibm_cloud/action/jobrunner.py", line 132, in _unpickle_function
ModuleNotFoundError: No module named 'colorama'

2019-09-24 10:45:18,162 [INFO] pywren_ibm_cloud.executor: ExecutorID 4c5ac6e3-2c1d - Cleaning temporary data from ibm_cos://omergar/pywren.jobs/4c5ac6e3-2c1d

@JosepSampe My bad,
this works:
import pywren_ibm_cloud as pywren
import colorama

def map_function(args):
    return colorama.Fore.GREEN + "Hello World"

pw = pywren.ibm_cf_executor(log_level='DEBUG')
pw.map(map_function, '', include_modules=['colorama'])
print(pw.get_result())

and this doesn't:
import pywren_ibm_cloud as pywren
from colorama import Fore

def map_function(args):
    return Fore.GREEN + "Hello World"

pw = pywren.ibm_cf_executor(log_level='DEBUG')
pw.map(map_function, '', include_modules=['colorama'])
print(pw.get_result())

is it possible to solve?

@omerb01 Yeap, the correct way to do this is:
import pywren_ibm_cloud as pywren
import colorama

def map_function(args):
    return colorama.Fore.GREEN + "Hello World"

pw = pywren.ibm_cf_executor(log_level='DEBUG')
pw.map(map_function, '', include_modules=['colorama'])
print(pw.get_result())

We found same behavior with @gilv few weeks ago, I think this is something related to cloudpickle lib and not to PyWren. Seems that cloudpickle only pickles those packages you include with import statement. if you import something with from .... import ...., you are importing things into global namespace, and then cloudpikcle assumes the method or the class you imported is already included in your package, so cloudpickle doesn't serialize it.
The question is, does this: from colorama import Fore ever worked in any pywren version? I don't know right now, I have to tes it ;)

@JosepSampe in case of colorama module, it didn't work before.
I made some tests and found something interesting.
lets assume we have an internal file named omer.py:
def print_omer(str):
    return str

and then we want to run this code:
import pywren_ibm_cloud as pywren
from omer import print_omer

def map_function(args):
    return print_omer('Hello World')

pw = pywren.ibm_cf_executor(log_level='DEBUG')
pw.map(map_function, '')
print(pw.get_result())

With PyWren version 1.0.17 we could run this code successfully and with the current version it prints pywren_ibm_cloud.job.serialize: Modules to transmit: None and raises:
Traceback (most recent call last):
  File "/action/pywren_ibm_cloud/runtime/function_handler/jobrunner.py", line 236, in run
  File "/action/pywren_ibm_cloud/runtime/function_handler/jobrunner.py", line 134, in _unpickle_function
ModuleNotFoundError: No module named 'omer'

good to mention that the variation of import omer works successfully with both versions.
the point is that metabolomics use case is built as a package and PyWren is operated from inside of it so there are lots of uses like from annotation_pipeline... import ... and it is quite messy to change everything to be with the prefix annotation_pipeline.<file>.<method-name>

@JosepSampe I am not sure if im right, but I made some another tests and I think that cloudpickle module is totally different between 0.6.1 and 1.2.1 since each CloudPickle object doesn't contain "modules" field anymore. I saw that cloudpickle module does detects objects in forms of from ... import ... but this kind of usage will be detected as a function instead of a module.
we have this code here:
https://github.com/pywren/pywren-ibm-cloud/blob/40c351a23a6e83c6f61334829bc2beff4ed94782/pywren_ibm_cloud/job/serialize.py#L66
so maybe we need to adjust PyWren for its changes.
also, I found that PyWren contains related cloudpickle code which I think that it isn't in use - inside libs directory.
what do you think?

@omerb01 I already changed cloudpickle lib to make it working with 1.2.1 ;)
Pywren uses cloudpickle module located in libs and not the installed one(if you have it installed with pip)

@JosepSampe do you think it is possible to extract these detected functions? so every variation will work: import ... and from ... import ...

@omerb01 Yeap, I already have it working, even the from colorama import Fore that never worked.

@omerb01 Fix included in #205

@omerb01 It would be possible to provide a simple example of what you are running? I mean, I already have annotation_pileline in my IDE, so some test.py that I can include in the project and that it calls some internal function of the annotation_pileline and that shows what you are seeing in the logs

@omerb01 I already have an example. I put this function into annotation_pipeline/fdr.py:
def my_function(a):
    return a

Then I created a test.py file in root of pywren-annotation-pipeline, and imported previous func:
from annotation_pipeline.fdr import my_function

Now in serialize i get:
2019-09-25 15:48:07,607 [DEBUG] pywren_ibm_cloud.job.serialize: Modules to transmit: {'/usr/local/lib/python3.6/dist-packages/nbconvert', '/usr/local/lib/python3.6/dist-packages/uritemplate', '/usr/local/lib/python3.6/dist-packages/send2trash', '/usr/local/lib/python3.6/dist-packages/cloudpickle', '/usr/local/lib/python3.6/dist-packages/wcwidth', '/usr/local/lib/python3.6/dist-packages/ipython_genutils', '/usr/local/lib/python3.6/dist-packages/entrypoints.py', '/usr/local/lib/python3.6/dist-packages/pyImagingMSpec', '/usr/local/lib/python3.6/dist-packages/pyparsing-2.3.1-py3.6.egg/pyparsing.py', '/usr/local/lib/python3.6/dist-packages/jupyter_client', '/usr/local/lib/python3.6/dist-packages/decorator.py', '/usr/local/lib/python3.6/dist-packages/jedi', '/usr/local/lib/python3.6/dist-packages/webencodings', '/usr/local/lib/python3.6/dist-packages/nbformat', '/usr/local/lib/python3.6/dist-packages/pandocfilters.py', '/usr/local/lib/python3.6/dist-packages/prompt_toolkit', '/usr/local/lib/python3.6/dist-packages/traitlets', '/usr/local/lib/python3.6/dist-packages/notebook', '/usr/local/lib/python3.6/dist-packages/jupyter_core', '/usr/local/lib/python3.6/dist-packages/matplotlib-3.0.3-py3.6-linux-x86_64.egg/mpl_toolkits', '/usr/local/lib/python3.6/dist-packages/pyMSpec', '/usr/local/lib/python3.6/dist-packages/pygments', '/usr/lib/python3/dist-packages/pexpect', '/usr/local/lib/python3.6/dist-packages/ptyprocess', '/usr/local/lib/python3.6/dist-packages/jsonschema', '/usr/local/lib/python3.6/dist-packages/testpath', '/usr/local/lib/python3.6/dist-packages/backcall', '/usr/local/lib/python3.6/dist-packages/bleach', '/usr/local/lib/python3.6/dist-packages/IPython', '/usr/local/lib/python3.6/dist-packages/mistune.py', '/usr/local/lib/python3.6/dist-packages/terminado', '/usr/local/lib/python3.6/dist-packages/parso', '/usr/local/lib/python3.6/dist-packages/cycler-0.10.0-py3.6.egg/cycler.py', '/usr/local/lib/python3.6/dist-packages/pickleshare.py', '/usr/local/lib/python3.6/dist-packages/defusedxml', '/usr/local/lib/python3.6/dist-packages/pyrsistent', '/usr/local/lib/python3.6/dist-packages/colorama', '/home/josep/data/eclipse-workspace/pywren-annotation-pipeline/annotation_pipeline', '/usr/local/lib/python3.6/dist-packages/prometheus_client', '/usr/local/lib/python3.6/dist-packages/ipykernel'}``
is this similar to what you get?

@omerb01 yes, but in my case I get a bit more packages, I think it doesn't matter. While putting include_modules=['annotation_pipeline'], I would like to serialise only annotation_pipeline package.

@ Ok, just wanted to know if I'm going in the right direction to reproduce the issue. I think now I have it fixed, doing final tests.

@omerb01 I added the fix, you can try if it works for you

@JosepSampe Thanks


Android config targets: don't include the SO version in the shlib file name

Reports say that the Android platform(s) don't have the SO version
number in the shared library file name.  Reportedly, Android package
managers do complain that our shared libraries do include the SO
version number.  That's easy enough to fix.
Fixes #14711

Ok


[WIP] G Suite authentication

This PR is only to visualize the changes required for making G Suite PKCE work but moving all that into a separate auth provider will be the a better way to provide this functionality IMO.

@mclueppers what was the status of this PR? Did you still have additional work?

Sorry for the late response. This PR is not ready. It was for @gargrag to see what changes were required for G Suite. I guess he's mentioned he intends to create a separate adaptor for that purpose.
I closing the PR.


Feature request: Snapping on F30/F60 in the timeline

It would be nice to be able to snap the cursor and keyframes to frames in F30 and F60 mode. It would allow for more precise control over the events ✌

Thanks for the suggestion. I just implemented the feature and it will be available in the upcoming release v3.6


Bonuscalc listener - implementation

Developer's notes:

Local database testing: The database which this listener is based on is the same that is used by the BonusCalc API. Therefore, for the time being, I have not included a set of migrations to populate the initial schema into the test database in this project. To run the database (gateway) tests for this project you can spin up the test database from BonusCalc API with the docker-compose up command. The connection settings are intentionally the same (as would be the case in other environments) and the tests work successfully with this spun up. TBC in this bracket is initting the test DB schema with a docker script (that's why the DB tests are failing for now)

Assumptions & caveats:

An operative's work is discrete to the day i.e. all the work is allocated to the day on which the job is closed. An operative will not, for the purposes of bonus calculations, do work which stretches over mutiple days. If this is a requirement, we will need to introduce a "day SMV splitter" in the same way we have introduced an "operative SMV splitter"
An operative cannot have two SMV awards for the same job (for example, for different trades) and this will not change in the future

You'll need the machine executor to work around the CI failure:
https://github.com/LBHackney-IT/bonuscalc-api/commit/5126377f6c01eb263aebb9ab8ba2993635a4b6f5
Running docker inside docker has issues.


Deep merge fails in non-trivial cases

Unless I'm doing something daft (always a strong possibility!). Given
var obj = Immutable({
  streams: {
    a: { name: "Conversations", channel: ["Facebook","Twitter"], loading: false},
    b: { name: "@Mentions", channel: ["Twitter"], loading: false},
    c: { name: "Facebook", channel: ["Facebook"], loading: false}
  },
  streamOrder: ["c", "a", "b"]
})

then running j.merge({streams: {a: { loading: true }}}, true) produces
{
  streams: {
    a: { loading:true }
  },
  streamOrder: {0: "c", 1: "a", 2: "b"}
}

so instead of doing a deep merge it has thrown away all of the data under the streams key! Have I misunderstood how the deep merge is meant to work?
It's also converted the data under streamOder from an Array to an Object, but I can live with that for the time being :-)

FWIW a simpler example based on the one from your docs seems to do the right thing for me:
Immutable({all: "your base", are: {belong: "to them"}}).merge({are: {belong: "to us"}}).merge({all: "the world"})

produces:
{all: "the world", are: { belong: "to us"} }

@ianp: If you want to do a deep merge then the second argument shouldn't be true, it should be {deep: true} like:
obj.merge({streams: {a: { loading: true }}}, {deep: true});

It produces the desired results.

 Thanks!


The parentheses of the names are incorrect

The parentheses of the names are incorrect
穿肠刀 (★) | 黑色层压板 (崭新出厂) -> 穿肠刀（★） | 黑色层压板 (崭新出厂)

Check the names again when the last commit is deployed.


Re-order nodes with drag and drop

Add the ability to re-order nodes using drag and drop.

http://1f8d850a.ngrok.io

Hi !
Could you please tell us why was the PR https://github.com/diogofcunha/react-virtualized-tree/pull/21 deleted ?
It would be very interesting to add Draggable behaviour :)
Actually I would be very interested to drag element from the tree to an other drop element in the page.

Hey @guillaumesayegh.
I like to first give it a few tries before committing to definitive solution, specially since this can be a huge compromise. I didn't like the way things were going and want to start all over again.
I have more experience with dnd now, and I will have another fresh look into that in the future.
If you want to drag form the tree to another element in the page I don't see what blocks you atm. you have full control over the node render. as long as you make the node a draggable element it should be ok. I could help you with that if necessary 👍

Are there any news on this? I need to add reordering by drag-and-drop to my tree and I wanted to check back to see whether there is a "native" solution available before I try to add something myself.
Thanks!

Hey !
Actually there's no native solution for this. So I have been doing draggable by my own using react-dnd over the render of the node.
I consider it would be still very interesting to improve this library by adding "Draggable" behaviour the same way we use "Expandable" for example.
Let me know if you want any sample code.

Thanks for the offer! Meanwhile I've applied draggable together with the corresponding events, and I found it very simple to use for dragging a node onto another node.
I'm also planning to implement dragging between two other nodes (for reordering purposes) and currently I imagine this will be a lot harder because I want to insert a line between the nodes to visualize the drop area. If you have any example code for this, I'd be grateful if I could take a look at it! Cheers :-)

Using Droppable react-beautiful-dnd (and Portals depending on your needs) should be very straightforward.

There are several tricky things on dnd that we need to keep in mind:
I can see dragging meaning 3 things:

Drag between nodes to re-order or move nodes in the tree hierarchy
Drag into a node and make the dragged node a children

This makes dnd for the tree behave in both x and y axis and the x part is not trivial. This also means that we probably need to have some slick animations and interactive node measures to make sure the dnd experience looks nice.
I've been busy lately and I'm going on holiday soon, I need to figure out a way to do all this work after my holiday, and making it so that the tree keeps the lack of opinion on implementation details

@guillaumesayegh Have you implemented this already?
I gave react-beautiful-dnd a try, and I wrapped my Tree into a DragDropContext and a Droppable, and I wrapped each tree node into a Draggable, but as soon as I try to drag something, the whole thing explodes with

I suspect this is because the tree does not have proper children but instead gets this child generator function?
Do you have a working example using react-dnd? Happy to try out that one for a change...

Here is working example: sample
Basically it's a virtualized tree and each node can drag out of the list. I used a React portal to hack the dragging element.

Thank you very much for the sample! I stripped it down to make it compile (basically removed the search stuff and the icon), but I still get the same error as soon as I drag the node:

So the only other option I see is, maybe you're using a different version? Mine is
"react-beautiful-dnd": "10.1.0",
Thanks for any insights :-)

Yeah I'm using DND 8.0 and RVT 2.3. Hope this gonna help you out. Otherwise you should ask for support in react-beautiful-dnd project.

OK. Downgraded react-beautiful-dnd to 9.0.2 and now everything works. Oh well...

@guillaumesayegh Thanks very much! You helped me get on track with this again. I will submit a bug report with react-beautiful-dnd.

Glad you've made it 👍


feat: support 3-letter Country ISO Code

Suggestion: Please consider also supporting 3-letter country ISO codes.
Today my application uses this format (and maybe many others may use it too 😃) and it would be really hard to adopt another standard just to use v-phone-input (not considering possible conflicts with other packages)

Hello,
Because awesome-phonenumber does not support it, I won't add this to the package for now sorry. One solution could be to use a map between 2 and 3 country codes on your side.


Cache and api client improvements

should fix #107 among other things! also some clean up to make the api client easier to maintain

and also #94


TPL integration

Adds (manually, i.e. copying the contracts) TPL integration to the ZEP token (#103), and makes it upgradeable (#119).
Upgradeability is currently based on zos-lib version 1.4.0, while that of Vouching uses 2.0.0-alpha.0. We should match these eventually (#122).
Also, I'm using different names for the token initializers to prevent name clashes in truffle tests. This should be improved (#124).

This should close:
[x] TPL contracts integration #103
[x] ZepToken upgradeability #119
[x] initializer function overloading #124
[x] ~Updating to zos-lib 2.0 #124~ [deprecated for #128]
[x] Updating to use OZ 2.0 #128
[ ] ZEP/TPL integration tests

I already merged vouching, so we can safely merge that onto master and keep working here on the tests.

Closing in favour of https://github.com/zeppelinos/zos/pull/141


Add SwiftUI example

Issue #45
Describe your changes
Provides a SwiftUI example to show usage of Foil. This is particularly needed since multiple property wrappers is not available in Swift yet so this shows how a SwiftUI view can listen for changes.

@basememara oh also, a pro tip:
since you have been added as a collaborator here, you can checkout this repo directly instead of using a fork


support custom repo combinations via operators

It could be interesting to allow custom repo groups to be formed via binary operators, e.g. repo_group = repo1 + repo2.

Initial support for most set operators (except xor) added in https://github.com/pkgcraft/pkgcraft/commit/b09b475debb366204c979ca4a2d9147c124d0bcc. Note that this currently doesn't support working directly on two repo objects as it's assumed a repo set object already exists or will be constructed via RepoSet::new().


Tab names are getting cutted at the end of the scrolling of the items

Tab names are getting cutted at the end of the scrolling of the items

Issue has fixed


Removed redundant javadoc comments

fix for issue  #273

@adityaketkar Please sign the Contributor License Agreement!
Click here to manually synchronize the status of this Pull Request.
See the FAQ for frequently asked questions.


Update the landing page of the docs

This PR replaces the current landing page content with those discussed offline.
This PR also removes the empty /docs/gs/docker.md, a leftover from earlier PRs.

Thank you, @mwalker174!


Add compatibility with Drone CI

Would you accept a PR that would add compatibility with Drone CI via their env vars?
Following env vars will be added:

DRONE_REPO_OWNER -> CI_REPO_OWNER
DRONE_REPO_NAME -> CI_REPO_NAME (in Drone CI_REPO_NAME is set as DRONE_REPO_OWNER/DRONE_REPO_NAME )
DRONE_PULL_REQUEST -> CI_COMMIT_PULL_REQUEST

I think it wouldn't hurt to much to add them. I would just not "document" them officially, so we can adjust / remove them later without a warning if needed.
PS: Is there anything blocking you from migrating to woodpecker or why do you want to use drone in general 😅

That sounds like a fair deal. I will implement the vars & test what happens when both CI_REPO_NAME & DRONE_REPO_NAME are set.
As I mentioned in #1, I'm waiting for cron jobs PR woodpecker-ci/woodpecker#934 to be merged. I will keep an eye on Woodpecker and try to contribute whenever possible 😃
PS: good job on sumarizing the ROADMAP issue woodpecker-ci/woodpecker#869

I think deprecation warnings for such wariables would be awesome, otherwise users risk to get a chaose in their config (will check some example with old vars, blog posts etc)
Though pretty hard to implement, one thing that comes to mind - simply do full-text search in pipeline files for deprecated vars. Not covers cases when they are used in nested processes but at least something

I thought about adding two types of "linter" feedbacks. One for error and one for warnings. Warnings could be used for deprecations as well.


Bug fix: merging strings and objects in same property threw JSON parse exception

@khezen We found and have addressed this bug. If you approve, can we get it merged into main lib.
Sample tests that now pass:
mergejson(
	{
		name: 'Anna'
	},
	{
		name: {
			first:'Anna',
			last:'Smith'
		}
	}).should.eql({
	name: 'Anna'
});

mergejson(
	{
		name: {
			first:'Anna',
			last:'Smith'
		}
	},
	{
		name: 'Anna'
	}).should.eql({
	name: {
		first:'Anna',
		last:'Smith'
	}
});

Published on npm.

@khezen Thanks!


Image Pull Secret

Is your feature request related to a problem? Please describe.
For my cluster to be able to pull images it is important to use image pull secret. I use openshift.
Describe the solution you'd like
It would be great to have opportunity to create image pull secret automatically, when kube-burner creates project. This secret should exist in every kube-burner generated project.
Describe alternatives you've considered
I had to put image on every worker node. :(

Hey @Muscule, you can those resources (service account linked to a docker-registry kind secret with permissions to pull from your registry) from a kube-burner job and then use, and then configure your pods to use those service accounts.

I suppose, some misunderstanding happened. I added image pull secret to the deployment objectTemplate, I created image pull secret yaml-file. I added a line "- objectTemplate: objectTemplates/secret.yml" in cfg.yml into the first job. But the secret is not created by the kube-burner. How can I make kube-burner create this secret in each namespace generated by kube-burner?

Well, I added creation of secrets successfully. I added into cfg.yml in creation job:
objects:
  - objectTemplate: objectTemplates/secret.yml
    replicas: 20

Then I created objectTemplates/secret.yml.
It did the job.


Missing documentation page : improve-performance

Describe the bug
Trying to access https://huggingface.co/docs/datasets/v2.8.0/en/package_reference/cache#improve-performance, the page is missing.
The link is in here : https://huggingface.co/docs/datasets/v2.8.0/en/package_reference/loading_methods#datasets.load_dataset.keep_in_memory
Steps to reproduce the bug
Access the page and see it's missing.
Expected behavior
Not missing page
Environment info
Doesn't matter

Hi! Our documentation builder does not support links to sections, hence the bug. This is the link it should point to https://huggingface.co/docs/datasets/v2.8.0/en/cache#improve-performance.


For ideal is there a package ??

Hi everyone. For ideal payment method is there a package ?? please give me all the details if you have a package . I need to use for laravel. Thanks guys

There are multiple drivers with iDeal support. Depends on the gateway you use:
https://github.com/fruitcakestudio/omnipay-sisow
https://github.com/payproNL/omnipay-paypro
https://github.com/thephpleague/omnipay-rabobank
https://github.com/thephpleague/omnipay-mollie
https://github.com/thephpleague/omnipay-multisafepay
https://github.com/thephpleague/omnipay-buckaroo
etc

Hi
I installed https://github.com/fruitcakestudio/omnipay-sisow for iDeal support  but it give to me
Error TA3220: Merchant not found.
I think i need this data
'shopId' => '',
'merchantId' => '0123456',
'merchantKey' => 'b36d8259346eaddb3c03236b37ad3a1d7a67cec6',
How to get this data? Can you help me? I am new with this.
Thanks guys.

You need to signup with a payment gateway provider first, to acquire those keys.

"You need to signup with a payment gateway provider first, to acquire those keys"
How to do that? Please can you tell me??

"You need to signup with a payment gateway provider first, to acquire those keys"
How to do that? Please can you tell me??
În Miercuri, 3 Februarie 2016 12:24:32, Barry vd. Heuvel<EMAIL_ADDRESS>a scris:

You need to signup with a payment gateway provider first, to acquire those keys.—
Reply to this email directly or view it on GitHub.


Update README.md

Can we compat tokio::spawn same as the AsyncRead way. Then in the comap future, tokio::spawn.compat() will auto convert to use containging runtime's spawn?


qt5-default on Ubuntu

Just a hint, I was trieing to build renderdoc on a clean Ubuntu 18.04 and the lib qt5-default was missing in the dependencies manual. Without that it wouldnt compile.

qt5-default is not required to compile on Ubuntu. From what I can see that package changes the system default Qt package to Qt5 with qtchooser, so would not be appropriate to recommend as a dependencies as it might interfere with what the user wants as their default.
What the instructions do explicitly state is that you might need to select Qt5 if it's not already the default, via a distribution-specific way. E.g. with qtchooser as Ubuntu uses you can export QT_SELECT:

On any distribution if you find qmake isn't available under its default name, or if qmake -v lists a Qt4 version, make sure you have qtchooser installed in your package manager and use it to select Qt5. This might be done by exporting QT_SELECT=qt5, but check with your distribution for details.

I see ok. We'll I am no big friend of Qt, always having issues with it :)


update-users-groups.pl: create intermediate home directories as 0755

Motivation for this change
Creates directories between / and the home directory as 0755 instead of 0700.
Fixes #10888 where users with home dirs outside /home receive "No directory, logging in with HOME=/" upon login and cannot access their home directory.
In the default installation, /home/ is 0755 so I used that for other locations.
Things done

[X] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[X] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[X] Fits CONTRIBUTING.md.

Even though this might not be the best solution, it's a solution, and I think this is better to merge this than continue leaving it broken.
Unless somebody brings up a good reason this shouldn't be done I'll merge this soon

See my concern above: https://github.com/NixOS/nixpkgs/pull/50857#issuecomment-440728087
It's easier for someone, who uses weird home directories to also take care of fixing the ownership with tmpfiles rules rather than working around our assumptions that we do when creating the user's home directory.


Amazing work !!!!

Just to say this, amazing amazing script, the performand it's superb, and triggered in perfect time, flexible and versatile solution. Amazing.
Thanks for your work !!!!!

Hi @zzseba78 ! It's really kind to hear that you like it :)
This is the kind of issue that every OSS maintainers secretly count on :D

+1, thanks for building this excellent tool. Great work, keep it up!


Demo docs: clarify that PowerShell requires the values to be double-quoted

https://forum.uavcan.org/t/error-in-pyuavcan-demo/1185/6

Pull Request Test Coverage Report for Build 38594589

0 of 0   changed or added relevant lines in 0 files are covered.
5 unchanged lines in 3 files lost coverage.
Overall coverage decreased (-0.05%) to 95.696%

Files with Coverage Reduction
New Missed Lines
%

/home/appveyor/projects/pyuavcan/pyuavcan/application/plug_and_play.py
1
92.24%

/home/appveyor/projects/pyuavcan/pyuavcan/presentation/_presentation.py
1
94.55%

/home/appveyor/projects/pyuavcan/pyuavcan/application/node_tracker.py
3
87.37%

Totals

Change from base Build 38531354:
-0.05%

Covered Lines:
13407

Relevant Lines:
13852

💛  - Coveralls


Diagnostics are not cleared when removing a file from a project

Describe the bug

@baronfel Mentioned that diagnostics are not cleared when removing a file from a project.
Steps to reproduce

Have a file with errors in it
Remove that file from the Project using the Solution Explorer
See that the diagnostics are still there

Expected behaviour

Diagnostics should be removed
Screenshots

https://user-images.githubusercontent.com/4760796/185739183-bbdb1d71-34d9-4775-990a-d0d32bc473ff.mp4
Machine info

OS: Windows
Ionide version: [e.g 5.0.1, don't use descriptions like latest ] 7.1.0

@baronfel
I don't know how to fix this problem any guidance?

Call https://github.com/fsharp/FsAutoComplete/blob/main/src/FsAutoComplete/FsAutoComplete.Lsp.fs#L196 in fsproj/removeFile handler in FSAC.


Feature request: Sync clock to NTP server

Sync clock inside Docker container to NTP server (of a user's choice).
We could possibly using Chrony.

Time is the responsibility of the docker host. There is no sane way to set time inside the docker container.
See here: https://stackoverflow.com/questions/24551592/how-to-make-sure-dockers-time-syncs-with-that-of-the-host
No sane way, using a lib to intercept all system call and programs use to retrieve the current time and date: https://serverfault.com/questions/824631/how-to-set-system-time-dynamically-in-a-docker-container

Then this can be closed.


page not found

hello,
i use elasticsearch 5.6.2, kibana 5.6.2.
in install node modules
then in kibana branch tag v5.6.2 i run it with npm start
kibana is now running on https://localhost:5601/jyo

  log   [04:27:35.166] [info][listening] basePath Proxy running at https://localhost:5601/jyo
kibana authentication plugin by codingchili@github init!

after open url http://localhost:5601 - it don't redirect to  https://localhost:5601/jyo/login
but to: https://localhost:5601/login
then i manual open https://localhost:5601/jyo/login
and try post query to server that post to https://localhost:5601/login - which not found.
how can i solve this problem?

Hello! Thanks for submitting an issue.
The plugin has not been tested with basePath enabled.
See this documentation for disabling basePath
https://www.elastic.co/guide/en/kibana/current/development-basepath.html
Before I have updated the plugin to work with basePath you can run kibana with
npm start -- --no-base-path
Using a basePath is the default behavior when running in dev mode. In production it is recommended to rewrite the url to remove the basePath in a proxy, if basePath is enabled.

Thanks,
next , i enter login and password: username and password, and nothing happen.
And file users.json cleaned.
Then throwed exception :
server    log   [09:57:16.296] [fatal] SyntaxError: Unexpected end of JSON input
at JSON.parse ()
at load (/opt/development/versions/5.6.2/kibana/plugins/kbn-authentication-plugin/src/authentication/file.js:22:18)
at Object. (/opt/development/versions/5.6.2/kibana/plugins/kbn-authentication-plugin/src/authentication/file.js:36:1)
at Module._compile (module.js:624:30)
at loader (/opt/development/versions/5.6.2/kibana/node_modules/babel-register/lib/node.js:144:5)
at Object.require.extensions.(anonymous function) [as .js] (/opt/development/versions/5.6.2/kibana/node_modules/babel-register/lib/node.js:154:7)
at Module.load (module.js:545:32)
at tryModuleLoad (module.js:508:12)
at Function.Module._load (module.js:500:3)
at Module.require (module.js:568:17)
at require (internal/module.js:11:18)
at Object. (/opt/development/versions/5.6.2/kibana/plugins/kbn-authentication-plugin/src/authentication/auth.js:9:15)
at Module._compile (module.js:624:30)
at loader (/opt/development/versions/5.6.2/kibana/node_modules/babel-register/lib/node.js:144:5)
at Object.require.extensions.(anonymous function) [as .js] (/opt/development/versions/5.6.2/kibana/node_modules/babel-register/lib/node.js:154:7)
at Module.load (module.js:545:32)

Hi, sorry for the late reply. If by 'cleaned' you mean that you deleted the contents you will get this error. If you want to clear it you should delete it or set its contents to '{}', to make sure its valid JSON.


Feature/css fix

Description
CSS fixes

Looks good apart from the CSS on Footer that you created a new div instead of using the Footer components CSS style


mac os x issue, any fixes

could you do a better job describing the issue your experiencing on Macx os x please @bigred56 ?


Fix indent/Add options supported by servers/Ports

Fix table indent, servers' listen ports and options supported by servers

@GrapeApple0 Thanks a lot! :+1:


Indexing multilayer HDF files

I'm trying to index some MODIS HDF files, my understanding looking at some examples (i.e. this one) is that I should produce datasets documents having something like:

measurements:
  lc_type_1:
    path: file.hdf
    layer: LC-Type1 # name of the HDF layer
  lc_type_2:
    path: file.hdf # same file as above
    layer: LC-Type2

Unfortunately, I don't understand how to achieve this with eo-datasets, as the note_measurement and write_measurement APIs do not allow to specify anything like a layer.
Is there any solution for this?

I have found a related discussion on GIS StackExchange, support has been added for eodatasets>=0.23, although I noticed only the write_measurement method supports multi-band images, but not the note_measurement one.


[BUG]: HOW TO SET LANGUAJE FOR PayPalMessages

Is there an existing issue for this?

[X] I have searched the existing issues.

🐞 Describe the Bug
Even if you set the language in the locale property, the text shown by the PayPalMessages component is still in English even if you send another language in locale.
I have tried to change the language of my browser but it keeps the language. There is no documentation or way to change it.
😕 Current Behavior
          <PayPalScriptProvider
            options={{
              clientId: clientId('en_US'),
              currency: currency,
              components: 'messages',
              intent: 'authorize',
              locale: 'en_US',
            }}
          >
            <PayPalMessages
              currency={currency as PayPalMessagesComponentOptions['currency']}
              style={style}
              placement="product"
              amount={amount}
              onClick={() => Satellite.moreInfoPaypalPayLater()}
              forceReRender={[style]}
            />
          </PayPalScriptProvider>

🤔 Expected Behavior
Show texte in language seted on locale property
🔬 Minimal Reproduction
use documentation code

🌍 Environment
| Software         | Version(s) |
| ---------------- | ---------- |
| react-paypal-js  |   8.1.3    |
| Browser          |   chrome   |
| Operating System |   mac      |

Relevant log output
nothing

Code of Conduct

[X] I agree to follow this project's Code of Conduct

➕ Anything else?
No response

Hi @DanielGBullido -- I'm checking in with team members on this one. Apologies for the delay in our response.

Hi @DanielGBullido -- For the PayLater messaging component you cannot override the default language, you can only render in the default language for that region. Please let me know if this helps, otherwise I will close this issue as working as expected.


Added Dark/Light mode feature

Fixes Issue '#28'
Changes Made?

Added a toggle button which switches between dark and light mode and switches the background image of the website with matching color fonts

Screenshot
In Dark Mode:

In Light Mode:

Working of Button:

Okay, can i raise another issue for the homepage section.
The UI of homepage doesn't match with form page, i would like to make some changes to the homepage too

Sure i have no problem, but I must warn you that I don't think Hacktober Fest will accept to PRs on the same repo it can be considered spamming. Well if you are doing for Open Source Faith then its okay.

Sure i have no problem, but I must warn you that I don't think Hacktober Fest will accept to PRs on the same repo it can be considered spamming. Well if you are doing for Open Source Faith then its okay.

I just wanted to contribute, it's okay even if some one else also takes on from here.
I'll add button to the homepage, will make the navbar component common between the two pages.


WIP net:tcp: NET_CONN_CB: Don't ref/unref net context

This change is supposed to prove that NET_CONN_CB() macro itself is
not needed, as it doesn't do anything beyond refing/unrefing context.
Signed-off-by: Paul Sokolovsky<EMAIL_ADDRESS>

See https://github.com/zephyrproject-rtos/zephyr/issues/8723#issuecomment-415040335 for the discussion. This patch is supposed to prove via CI that what I'm talking about there holds (or not).

Codecov Report

Merging #9565 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #9565      +/-   ##
==========================================
- Coverage   52.15%   52.14%   -0.02%
==========================================
  Files         212      212
  Lines       25916    25916
  Branches     5582     5582
==========================================
- Hits        13517    13514       -3
- Misses      10149    10152       +3
  Partials     2250     2250

Impacted Files
Coverage Δ

subsys/net/ip/tcp.c
58.67% <ø> (ø)
:arrow_up:

subsys/net/ip/net_context.c
65.91% <0%> (-0.62%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49732b2...babc095. Read the comment docs.

Any plans on this for 1.14?

Well, I never got any comments on this. @jukkar, @tbursztyka ?

@pfalcon can you rebase?
CI as a TCP test is a joke. There are issues that will never show up through it.

can you rebase?

Done.

CI as a TCP test is a joke. There are issues that will never show up through it.

That's true. That's why I initially posted that to ask CI's opinion, then to get comments, then formally trace thru the code. It got backlogged somewhere along the way, yeah.

So, Shippable is happy about this change. (The only issue is "WIP" in title for checkpatch.)

This looks like a stale PR -> adding label.


Chart data wrong form Memory Optimized Pricing Tier

Memory Optimized only goes up to 16 vCores, not 32.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 61a86489-2b1d-1b42-687a-5d4323ad7306
Version Independent ID: 48c0caea-6b9a-add5-9fb5-ef995c737064
Content: Limitations in Azure Database for PostgreSQL
Content Source: articles/postgresql/concepts-limits.md
Service: postgresql
GitHub Login: @kamathsun
Microsoft Alias: sukamat

@jeffreyCline Thanks for reporting! I have assigned the issue to the author to investigate and update as appropriate.


Fix expansion of @RequestParam empty lists

https://github.com/OpenFeign/feign/pull/1200

@OlgaMaciaszek spring-cloud-openfeign pom should update

Closing in favour of https://github.com/spring-cloud/spring-cloud-openfeign/issues/333.


Json commands not exposed in AsyncCluster

Bug Report
I am using the latest release 6.5.0 which has the recently added redisJson commands (Thank you and Great Job!).
Using the StatefulRedisClusterConnection , I can access either RedisAdvancedClusterCommands which gives me access to RedisJsonCommands through the simple inheritance model.
However when using the async member RedisAdvancedClusterAsyncCommands , it would appear that the RedisJsonAsyncCommands was left out of RedisClusterAsyncCommands here
If this is intentional , what would the proper path forward be to access redisJson async commands for a cluster?

Hey @yisraelU ,
thanks for the report, yeah, this is something we overlooked.
Will work to fix it ASAP


Forced to install an optional package.

I am running PlatformIO on Gentoo. When I tried to initialize a new project for an a9g board, it gave me an UnknownPackageError regarding waybyte/toolchain-gccmipselfrda8955. After reading the package description of gccmipselfrda8955, it should only work on Windows operating systems; however, after reading the platform.json file of this repository, the package should be optional. What could be the issue here?
Result of uname -r:
6.6.13-gentoo

Complete error message:
...
Resolving a9g dependencies...
Tool Manager: Installing waybyte/toolchain-gccmipselfrda8955 @ =4.4.2
UnknownPackageError: Could not find the package with 'waybyte/toolchain-gccmipselfrda8955 @ =4.4.2' requirements for your system 'linux_x86_64'

Edit:
I've read the platform.py file and discovered that it is indeed required if the chipset is rda8955. However, it stumps me that the toolchain is only available for windows.

@Nick-Miras thanks for clarification. Sorry the windows toolchain is actually modified version of vendor provided toolchain to support c++. We tried to make linux version but failed.


20 lookup table class

Description

Resolves #20

Verification

Created testing suite in lut_test, and has passing results when running tests

Resources

None

@DFriend01 All issues resolved, one question I have:
Are the failed tests going to be a problem?

@DFriend01 All issues resolved, one question I have: Are the failed tests going to be a problem?

@alberto-escobar If the tests pass on your local machine, this is probably an infrastructure problem. I'll look into it this weekend.

@DFriend01 All issues resolved, one question I have: Are the failed tests going to be a problem?

@alberto-escobar If the tests pass on your local machine, then this is probably an infrastructure problem. I'll look into it this weekend.
However, the flake8 test should be passing. Make sure that the Python autoformatter is enabled. You can also run the flake8 task in sailbot workspace to diagnose the problem on your end and resolve the lining errors yourself, or at least figure out where the problem is so you can apply the autoformatter there.

I figured out the problem, in test_lut.py I added:
assert math.isclose(testLUT(50000), 5.75)

where ever there was an instance of a LUT object created but never used. This cleared up flake8 errors.
I also had to add the following logic to  __linearInterpolation in lut.py to mitigate an error of np.interp returning an NDArray:
    def __linearInterpolation(self, x: Scalar) -> float:
        output = np.interp(x, self.x, self.y)
        if isinstance(output, np.ndarray):
            raise ValueError(
                "linear interpolation returned a NDArray when it should have returned a float"
            )
        return output

I made a unit test for this in test_lut called test_linear_interpolation_exception


Is @effector/forms ready for production?

Hey guys, first of all, this is an awesome project, thanks a lot for all your work. Just wanted to know if the formApi is ready to use in production. I see it's been last updated 4 months ago in NPM. Id this just POC, or you guys put it out there as GA?
Thanks!

It isn't ready

Forms development is one of the most complex and crucial parts of frontend projects, and although effector itself is ready to manage forms in application, we cannot suggest that package for production.
Usually, our new features and packages comes through reviewing of use cases and gathering people's opinions to understand user expectations and how to fit them the best; it's an iterative process and that package is still on the its' early stages.
When it will be ready, we'll make special announcement in our release pages

Related issue

Thanks guys for your replies. I figured that much but wanted to know your opinion. I'm taking a stab at it and will share it with you once I have it ready.


Add installation guide for openSUSE

What is the purpose of this change? What does it change?
Add installation guide on openSUSE.
Checklist

[x] I have read the Contribution Guidelines
[ ] I have added tests for all changes in this PR
[ ] I have added documentation for the changes (in the manual)
[ ] There's a new file in changelog/unreleased/ that describes the changes for our users (template here)
[ ] I have run gofmt on the code in all commits
[x] All commit messages are formatted in the same style as the other commits in the repo
[x] I'm done, this Pull Request is ready for review

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@604b18a). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #2456   +/-   ##
=========================================
  Coverage          ?   46.67%
=========================================
  Files             ?      174
  Lines             ?    14480
  Branches          ?        0
=========================================
  Hits              ?     6758
  Misses            ?     6715
  Partials          ?     1007

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 604b18a...7db0960. Read the comment docs.


fix(hbase): regionserver core-site + hdfs-site from hadoop client conf

Which issue(s) this PR fixes:

Fixes #450
Additional comments:

HBase regionserver won't depend on HDFS Data Node installation anymore, and we'll get rid of 2 hard coded paths.
DAG : hbase_regionserver_config now depends on hadoop_client_config
After this, I'm finally able to install Hbase without having a local HDFS installation. 👍

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004 and that you give permission to TOSIT,
you have to acknowledge this by using the following check-box.

[x] I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004

[x] I hereby agree to grant TOSIT a copyright license to use my contributions.

Hi @jusstol, thank you for you contribution to TDP.
This PR has been validated and will soon be merged to master branch.


Handle multiple feature ID sets in ModelExperimental

Fixes #10007
Fixes #9894
This also partially addresses #9884, though picking is not currently supported for feature IDs without a property table, and the current picking system would need larger changes to address this (see https://github.com/CesiumGS/cesium/issues/9884#issuecomment-1013511841)
Summary of changes:

In ModelComponents, combined featureIdAttributes and featureIdTextures into one featureIds array. This is more consistent with the current EXT_mesh_features spec.
in ModelExperimental, replaced featureIdAttributeIndex and featureIdTextureIndex with featureIdIndex and instanceFeatureIdIndex, as the latter pair better match the glTF structure
FeatureIdPipelineStage now processes all the feature ID attributes instead of only the selected one. It populates a FeatureIds struct that can be passed into both feature ID selection (next bullet) and custom shaders.
SelectedFeatureIdStage handles the shader details for taking the selected feature ID set and populating a struct used by styling and picking. This is significantly easier now with the FeatureIds struct, it's simply selectedFeature.id = featureIds.SELECTED_FEATURE_ID (using a define to substitute in the right variable).
adds feature IDs to Custom Shaders via fsInput.featureIds.featureId_N or fsInput.featureIds.instanceFeatureId_N
updated the 3D Tiles Next Photogrammetry Sandcastle to use the new fsInput.featureIds.featureId_N syntax to avoid exposing private API.

To Do:

[x] Update custom shader guide
[x] Update documentation for feature ID stages
[x] Fix broken unit tests
[x] Add new unit tests
[x] add featureIdIndex and instanceFeatureIdIndex to Cesium3DTileset for easier configuration
[x] Update CHANGES.md
[x] Check if instanced FEATURE_ID_n is added to the ProcessedAttributes correctly
[x] fix race condition about featureIdIndex being set before the scene graph is constructed.
[x] investigate styling, sometimes higher LODs aren't displaying the right color
[x] Update other existing sandcastles
[x] Investigate ModelColorPipelineStage DeveloperError
[x] Investigate draco tile failures in Custom Shaders 3D Tiles sandcastle -> opened https://github.com/CesiumGS/cesium/pull/10031

Thanks for the pull request @ptrgags!

:heavy_check_mark: Signed CLA found.
:grey_question: CHANGES.md was not updated.

If this change updates the public API in any way, please add a bullet point to CHANGES.md.

Reviewers, don't forget to make sure that:

[ ] Cesium Viewer works.
[ ] Works in 2D/CV.

Just a short note: I think that http://localhost:8080/Apps/Sandcastle/index.html?src=3D Tiles Next S2 Globe.html&label=3D Tiles Next is still using the (now no longer working, internal) FEATURE_ID_TEXTURE approach for the custom shader.

@lilleyse this PR is now ready for review. I do still want to add a sandcastle to show multiple feature Id sets once you finish updating the Ferry Building tileset and upload it to ion

@lilleyse I updated the 3D Tiles Next Photogrammetry Sandcastle with new styling and custom shader examples

@javagl just to confirm, have you tested all the samples in https://github.com/CesiumGS/3d-tiles-samples/pull/40 on this branch?
Here's the testing strategy I was going to go with. Are there any that can already be checked off?

[ ] Test picking feature without corresponding property table (expect it not to pick anything until #98834 is addressed)
[ ] Test setting the active feature id and then picking and styling
[ ] Test setting the active instance feature id and then picking and styling
[ ] Test picking pnts with BATCH_ID
[ ] Test picking pnts with per point properties (expect picking to work now, but maybe not in the future #10025)
[ ] Test picking i3dm
[ ] Test picking b3dm
[ ] Test picking glTF with feature ID attributes
[ ] Test picking glTF with feature ID textures
[ ] Test picking glTF with implicit feature IDs
[ ] Test picking glTF with instance feature ids
[ ] Test picking glTF with implicit instance feature ids
[ ] Test custom shader for any of the above

Addressed the concrete feedback. Next step is investigating a bug @lilleyse pointed out to me where switching between a style and a custom shader leaves the tileset in a bad state:

@lilleyse this is ready for review again.

merging in the let/const changes didn't seem to work properly... I'm going to reset my branch and try again

The new sandcastle option Multiple Feature ID Sets might be a little too busy with the color scheme. Maybe it's better to go with something simpler, like tinting roof windows yellow and facade windows purple.

Aside from that, the recent changes look good. @javagl once you're satisfied with your testing we can get this merged.

@lilleyse I simplified the sandcastle like you suggested

I did some tests, roughly based on the bullet points above, but with some disclaimers (summarized below)

[X] Test picking feature without corresponding property table (expect it not to pick anything until #9884 is addressed)

This seems to work. based on the ExplicitFeatureIds and ImplicitFeatureIds samples from https://github.com/CesiumGS/3d-tiles-samples/pull/40, which both define feature IDs without associated properties.

[X] Test setting the active feature id and then picking and styling

This seems to work, based on the (preliminary) ComplexExample mentioned in https://github.com/CesiumGS/3d-tiles-samples/pull/40#issuecomment-1021390611

[ ] Test setting the active instance feature id and then picking and styling

[X] Test picking pnts with BATCH_ID

[X] Test picking pnts with per point properties (expect picking to work now, but maybe not in the future #10025)

I think these are working as expected. When loading the cesium/Apps/SampleData/Cesium3DTiles/PointCloud/PointCloudBatched in my test sandcastle, it shows the "feature ID" (aka Batch ID) and some per-point properties in the Tooltip, if one manages to move the mouse directly over that single pixel :D

[X] Test picking i3dm

[X] Test picking b3dm

These also seem to work, based on the Instanced/InstancedWithBatchTable and Batched/BatchedWithBatchTable sample data...

[X] Test picking glTF with feature ID attributes

[X] Test picking glTF with feature ID textures

[X] Test picking glTF with implicit feature IDs

These seem to work based on the ExplicitFeatureIdsAndSimpleProperty, ImplicitFeatureIdsAndSimpleProperty and SimpleFeatureIdTexture samples from https://github.com/CesiumGS/3d-tiles-samples/pull/40

[ ] Test picking glTF with instance feature ids

[ ] Test picking glTF with implicit instance feature ids

[ ] Test custom shader for any of the above

Disclaimers:

In general, I wasn't sure about the interplay of metadata and styling. For example, there is this line with color: "color(${color})" in one of the samples, and I don't know what color is. (No not that one, the other one. I mean the innermost one...)

Setting a style with a pointSize: 10.0 does not seem to have any effect:
tileset.style = new Cesium.Cesium3DTileStyle({
  pointSize: 10.0
});

Is this a known issue?

Everything related to instance IDs: I'll have to look into that, in terms of example data and usage.

Custom shaders: Also would need a bit more time here to try out "things"...

General:
I've been testing most of this based on the (sketchy) "Test Sandcastle" that may, at some point, be a "template" for the example sandcastles that will go into the READMEs for the samples.
There are several issues with that:
Right now, accessing the metadata generically is ... clumsy: It has to do many instanceof/undefined checks, and a lot of "implicit, specific knowledge" is carved into this code. It might be that there are some abstractions in the latest state of this PR. If some of that code could be simplified, that would be great.
There is an experimental function for "Setting the active feature ID", but ... I have no idea how to know the actual number of available feature IDs in the first place. More generally: I assume that the concept of having an "active feature ID" is a tribute to having to transport this information through the rendering process into "the picking world". I could question the now 54 (fifty-four!) properties in the options for a tileset, and ask who is going to create a "mental model" of what they mean and what values they should have. But even if it is OK to just add more properties there, this is part of a "global state" (global in terms of the tileset), and I see this as a (possibly severe) limitation. What if someone wants to do styling based on one feature ID, and show a tooltip based on another feature ID? (Related to that: The ambiguities between "feature ID" and "instance feature ID" are ... not so nice. Conveying the difference and their meaning in context, in some sort of documentation/tutorial, may be difficult...)
It might be that these issues are already resolved by more recent changes. So to put it that way: If somebody could improve (as in: simplify and generalize) this test code at https://github.com/javagl/3d-tiles-samples/blob/add-ext-mesh-features-samples/EXT_mesh_features/CommonSandcastleCode.txt , that would be great...

@javagl a couple things to point out:

Styling with property names should work for meshes, but not for point clouds, that falls under #9944
As far as picking goes, indeed the metadata is cumbersome to access, but this PR is only concerned with
pointSize in Cesium3DTileStyle... :grimacing: I don't think that was implemented. I'll open an issue.

I finished up testing. All looks good.

[x] Test setting the active instance feature id and then picking and styling
[x] Test custom shader for any of the above
[x] Test picking glTF with instance feature ids (Sandcastle)
[x] Test picking glTF with implicit instance feature ids (Same sandcastle as above)


Global error handling on a graphql-request instance

Hi,
I am wondering if there is a way to handle errors globally?
For context, I am using graphql-request with graphql-code-gen SDK. I have a graphql-instance that I pass to the getSdk function i.e ;
   const graphqlRequestInstance = new GraphQLClient(
    `${process.env.NEXT_PUBLIC_BASE_API_URL}/${endpoint}`,
    {
      headers: {...},
    }
  );
  const sdk = getSdk(graphqlRequestInstance);
  ...

I have one instance so that I don't have to configure the URL repeatedly, plus some headers for auth among others.
One of the scenarios I have is that the request might throw a 401 if the session has expired, and I'd need to handle that. How would I handle that in this kind of setup globally?
For example, when using axios I could do something like this;
axiosInstance.interceptors.response.use(
  (response) => response,
  async (error: AxiosError) => {
    if (error?.response?.status === 401) {
            //handle the 401 error
    }
    return Promise.reject(error);
  }
);

I was coming from Axios as well and resolved this with an intermediary class:
class GraphqlClient {
    private repository: Repository
    private client: GraphQLClient

    constructor(repository: Repository) {
        this.repository = repository
        this.client = new GraphQLClient("http://localhost:8080/graphql")
    }

    query<T = GraphqlQuery, V = Variables>(document: RequestDocument, variables?: V): Promise<T> {
        return this.makeRequest<T, V>(document, variables)
    }

    mutation<T = GraphqlMutation, V = Variables>(
        document: RequestDocument,
        variables?: V,
    ): Promise<T> {
        return this.makeRequest<T, V>(document, variables)
    }

    private makeRequest<T = GraphqlQuery, V = Variables>(
        document: RequestDocument,
        variables?: V,
    ): Promise<T> {
        return new Promise((resolve, reject) => {
            this.client
                .request(document, variables, {
                    Authorization: `Bearer ${this.repository.session.getJwt()}`,
                })
                .then(resolve)
                .catch((error: any) => {
                    const reqRes = JSON.parse(JSON.stringify(error))
                    return reject({ name: reqRes.response.errors[0].message })
                })
        })
    }
}

And then you can use it like:
graphqlClient.query(...)

and globally have errors resolved in the same way. I use this to add the jwt to every request as well, and eventually log some things to the server as well, hence why I've also split the query and mutation functions.

@gabrielgatu, thanks for your response. Does your setup include using code-gen? If yes, is there a chance you can give a full example along with your custom graphql-client?

@joeynimu There's an example to do just that in the documentation: https://www.graphql-code-generator.com/docs/plugins/typescript-graphql-request#examples-of-middleware
But it's using polly-js. I would like to use it without that as I'm not interested in retries.

I'm considering this a duplicate of https://github.com/jasonkuhrt/graphql-request/issues/235.


Make max manual speed much smaller (not 1.0 m/s)

Maybe have a rosparam for max_speed? If so, also needs to be used in wherever the auto speed is calculated (it's currently hardcoded as 1.0)
Set it to 0.1 m/s or maybe even less.

Putting it in writing: 1.0 may not (probably does not) mean 1.0 m/s, but instead 100% of maximal output.

Updated the issue to remove m/s


[release-1.19] Update embedded containerd to 1.4.9-k3s1

Backport Update embedded containerd to 1.4.9-k3s1 to branch release-1.19:

#3853

This is validated in v1.19.14+k3s1 and regression and sonobuoy worked.


Port fwctl over from bhyve

This enables the UEFI firmware to correctly detect the number of vcpus. Without this the guest only sees 1 vcpu regardless of the use of -c because the firmware tables (ACPI) won't be setup correctly.
The first commit simply imports the pristine files from FreeBSD, the second commit is the interesting one I guess.

LGTM too - tested the binary and it solves the issue


Added Darwin Gosal in the mentors #63

@lapmid Please squash your commits and try to finalise work before pushing. That's way more commits for this simple issue.

Sorry actually i was mistaken and pushed then i tried to make that correct
so thats why too much pushes
On 19-Oct-2017 6:52 PM, "Vivek Singh"<EMAIL_ADDRESS>wrote:

@lapmid https://github.com/lapmid Please squash your commits and try to
finalise work before pushing. That's way more commits for this simple issue.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/fossasia/pslab.fossasia.org/pull/72#issuecomment-337906181,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AemYmFvawAZdSjgmeLpqcQOOrPiFhujrks5st00ygaJpZM4P_HN2
.

And again sorry actually little bit beginer on github so i made commits everytime i made a correction

Okay i wilk do it
On 23-Oct-2017 1:26 PM, "Padmal"<EMAIL_ADDRESS>wrote:

@CloudyPadmal requested changes on this pull request.
Hi! I've requested some changes! :)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/fossasia/pslab.fossasia.org/pull/72#pullrequestreview-71093203,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AemYmNUROzVOq7A4voJig6xFSjW6NXYBks5svEadgaJpZM4P_HN2
.

@CloudyPadmal I have done changes there was also some prior wrong id's i
have also fixed that please review
On 23-Oct-2017 1:31 PM, "anurag pandey"<EMAIL_ADDRESS>wrote:

Okay i wilk do it
On 23-Oct-2017 1:26 PM, "Padmal"<EMAIL_ADDRESS>wrote:

@CloudyPadmal requested changes on this pull request.
Hi! I've requested some changes! :)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/fossasia/pslab.fossasia.org/pull/72#pullrequestreview-71093203,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AemYmNUROzVOq7A4voJig6xFSjW6NXYBks5svEadgaJpZM4P_HN2
.

Hi @lapmid ! Looks nice now! There is merge conflicts in the index.html and be really careful when resolving them. Conflict is due to new addition of developers.

Please help how to resolve them
On 23-Oct-2017 5:06 PM, "Padmal"<EMAIL_ADDRESS>wrote:

Hi @lapmid https://github.com/lapmid ! Looks nice now! There is merge
conflicts in the index.html and be really careful when resolving them.
Conflict is due to new addition of developers.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/fossasia/pslab.fossasia.org/pull/72#issuecomment-338631075,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AemYmMc_aj20NOvtyPk48VWNGQqBJmGhks5svHpIgaJpZM4P_HN2
.

@CloudyPadmal  i have resolved conflicts kindly review

@CloudyPadmal  kindly review now i have removed conflicts second time now

Darwin is a contributing mentor in FOSSASIA, but not a core mentor of the project. Therefore he should not be added to the project site.

@mariobehling but i had also added mitch altman  and darwin gosal was written in the issue so i had added him


Flaky test for WaitForPodsReady if two workloads are considered in the same scheduling cycle

What happened:
/kind flake
Failing test:
Scheduler with WaitForPodsReady Suite: [It] SchedulerWithWaitForPodsReady when Scheduling workloads on clusterQueues Should block admission of one new workload if two are considered in the same scheduling cycle

What you expected to happen:
The test to succeed.
How to reproduce it (as minimally and precisely as possible):
https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_kueue/415/pull-kueue-test-integration-main/1605630317664669696
Anything else we need to know?:
Environment:

Kubernetes version (use kubectl version):
Kueue version (use git describe --tags --dirty --always): main branch
Cloud provider or hardware configuration:
OS (e.g: cat /etc/os-release):
Kernel (e.g. uname -a):
Install tools:
Others:

/assign @mimowo

Thanks for creating this! I faced this issue on #415.

@alculquicondor please review the fix: https://github.com/kubernetes-sigs/kueue/pull/491


make the error explicit when a wrong selector is used to create a view

This is a simple change that gives a better error message for the case when the user tries to create a view like so:
let myView = app.views.create('.somethin');

and there is no element matched by .somethin (usually this is a simple typo).
Currently F7 gives a cryptic error with this message:
Uncaught TypeError: Cannot set property 'f7View' of undefined

(which is clear for anyone who knows the internals of F7, but not at all for users who are new to it)

Thanks! But can you also add another error with else if ($el.length === 0)? Because in this case it won't be created as well, with some generic error message like Framework7: can't create a View instance because passed View element is wrong or something like that

Thanks, merged! 👍


Level of abstraction on top of jquery/zepto

Is it possible or a good idea to add a level of abstraction on top of jquery/zepto dependency? I'm asking/proposing this because I don't want to use 31kb jquery just to make 5kb backbone work. For instance there is ender (http://ender.no.de/) which is 8-9 kb and provides almost the same api as jquery and provides all functionality that backbone requires.
The problem is that backbone doesn't support in any way substitution of jquery/zepto.

I submitted a pull request for this, but it was rejected. Feel free to cherrypick that change into your own fork.

+1 on needing something like this, not just to support something like ember, but also noConflict versions of jQuery. Some people like to call their jQuery somewhere besides window.jQuery, and that is currently impossible to do with Backbone without patching your own copy of the library. I think @two-bit-fool's pull request should be reconsidered - it is very simple, definitely fixes this issue, and aligns with the generally good practice of using noConflict libraries.

Backbone now also works with Ender, if I remember correctly...

@jashkenas I don't think @sha1dy's initial issue was specific to ember...

Yes -- but I'm not a big believer in something as lightweight/small as Backbone adding a "level" of abstraction to make the mapping to jQuery / Ember / Zepto easier -- it's already incredibly easy.
The abstraction that you're looking for already exists -- it's the jQuery API, which other libraries are choosing to adopt. Someone could make a $ object for MooTools that behaves like jQuery, and you'd be able to drop it directly in to Backbone as well.

I think your example of a $-like object for MooTools is actually an argument for having an API for using different $ libraries. If I made a MooTools wrapper that behaves like $, in order to use it with Backbone I would have to either 1) put in a request to have it added to the line in Backbone where $ is assigned and wait for a new version including my change, or 2) modify my local version of backbone.js to have my library added to that line, or 3) assign my object to window.jQuery (or Zepto, or ember) before loading backbone.js. None of those options is as nice as explicitly telling my Backbone object what my $-ish library is, in my opinion.
Having said all that, If that flexibility is simply not in line with Backbone's goals in terms of simplicity, I get that, but I think it would be a nice feature for those of us who would use it, and completely transparent to those who would not.

If you want a way to tell backbone what it should use as $ (the DOM manipulation / Ajax object) -- that would be a great pull request to send, and definitely in line with Backbone's goals.

@jashkenas isn't that what @two-bit-fool's pull request was for? Should that get re-opened, or was there another reason you didn't like it that we could address in a different way?

Yep.
I want whichever pull request it ends up being to be driven by someone with a real project and a real library in mind -- otherwise we usually end up with an implementation that doesn't actually work.

Fair enough, I can definitely provide that, incoming shortly - only question is what a good name would be, @two-bit-fool had Backbone.use but other options would be Backbone.dollar or Backbone.dom, or ...

Let's make it a function, not a value... Backbone.setjQuery() ? Backbone.setLibrary() ?

I like setLibrary personally.

Ok, setjQuery() it is.

So you want to do setjQuery(mootoolsAbstraction)... that sounds incredibly confusing imo.

@tbranyen - sorry, hadn't seen your reply when I wrote mine, wasn't meaning to ignore you. I'm Ok with setLibrary, but it seems a little too generic. For instance, Backbone also uses underscore internally, which is also a library that could be injected (though that seems of less use and I'm not suggesting it). Unfortunately, I don't have a better idea - setDomLibrary maybe?

Backbone can't load without underscore so you can't have a method to change it out.

Well I agree with @tbranyen that the name is confusing, so let's hash that out before merging, but I went ahead and made pull request #918 so you can look at it, and we can change the name if need be.

@tbranyen I recognize that underscore is a different case, but I still think setLibrary begs the question "set what library".

I like setDomLibrary

Changed the name to setDomLibrary, seemed the best to me. @jashkenas what do you think?

Ok, fair enough, that fixes this issue. I've created #938 for the functionality I'm interested in seeing.


Continous Positive Airway Pressure (CPAP)

spelling error on 'continous' change to 'continuous'

Thanks! Merged into 7-0-stable branch for upcoming release.


Modified features, hw, intro and homepage docs.

Purpose of the pull request

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:

My bad, will correct it right now


Ctrl K -> select doesn't scroll to appropriate place

Expected Behavior
When I Ctrl K / search and select a route, I expect it to scroll / jump to that route
Actual Behavior
It doesn't, so I have to manually scrolldown
Reproduction steps
1. Ctrl K or click search
2. Click on any endpoint
3. Notice scroll doesn't happen

Link to site / OpenAPI Spec
No response
Version
"@scalar/api-client": "0.8.3"
What browsers are you seeing the problem on?
Chrome

hey @pq43, i noticed this happens when an endpoint is in a tag that is collapsed, is this what you are seeing as well?

H, yes I think that's it! Would be really nice to be able to ctrl k any endpoint tho :)

Thank you so much! working with you all through open source has been a joy :)


Adding upheno_custom_mapping preview

@souzadevinicius please dont forget about this!

@souzadevinicius the error log is too big to display here but here is the error log:
2023-12-08T09:50:10.9121521Z 2023-12-08 09:49:03 (27.2 MB/s) - ‘tmp/upheno/upheno_all_with_relations.owl’ saved [513061413/513061413]
2023-12-08T09:50:10.9121527Z
2023-12-08T09:50:10.9121725Z bash: line 1: phenio-toolkit: command not found
2023-12-08T09:50:10.9122120Z make[1]: *** [monarch_mapping_commons.Makefile:51: mappings/upheno_custom.sssom.tsv] Error 127
2023-12-08T09:50:10.9122254Z make: *** [Makefile:37: mappings] Error 2
2023-12-08T09:50:10.9123040Z wget https://raw.githubusercontent.com/monarch-initiative/umls-ingest/main/src/umls_ingest/mappings/hp_mesh.sssom.tsv -O mappings/hp_mesh.sssom.tsv
2023-12-08T09:50:10.9123724Z wget https://raw.githubusercontent.com/monarch-initiative/umls-ingest/main/src/umls_ingest/mappings/umls_hp.sssom.tsv -O mappings/umls_hp.sssom.tsv
2023-12-08T09:50:10.9123853Z mkdir -p tmp/upheno/
2023-12-08T09:50:10.9124554Z wget https://bbop-ontologies.s3.amazonaws.com/upheno/current/upheno-release/all/upheno_species_lexical.csv -O tmp/upheno/upheno_species_lexical.csv
2023-12-08T09:50:10.9124682Z mkdir -p tmp/upheno/
2023-12-08T09:50:10.9125381Z wget https://bbop-ontologies.s3.amazonaws.com/upheno/current/upheno-release/all/upheno_mapping_logical.csv -O tmp/upheno/upheno_mapping_logical.csv
2023-12-08T09:50:10.9125498Z mkdir -p tmp/upheno/
2023-12-08T09:50:10.9126222Z wget https://bbop-ontologies.s3.amazonaws.com/upheno/current/upheno-release/all/upheno_all_with_relations.owl -O tmp/upheno/upheno_all_with_relations.owl
2023-12-08T09:50:10.9126343Z mkdir -p mappings tmp
2023-12-08T09:50:10.9126943Z phenio-toolkit lexical-mapping --species-lexical tmp/upheno/upheno_species_lexical.csv -m tmp/upheno/upheno_mapping_logical.csv -o tmp
2023-12-08T09:50:10.9127294Z make[1]: Leaving directory '/__w/monarch-mapping-commons/monarch-mapping-commons'
2023-12-08T09:50:10.9137125Z ##[error]Process completed with exit code 2.

@souzadevinicius the error log is too big to display here but here is the error log:
2023-12-08T09:50:10.9121521Z 2023-12-08 09:49:03 (27.2 MB/s) - ‘tmp/upheno/upheno_all_with_relations.owl’ saved [513061413/513061413]
2023-12-08T09:50:10.9121527Z
2023-12-08T09:50:10.9121725Z bash: line 1: phenio-toolkit: command not found
2023-12-08T09:50:10.9122120Z make[1]: *** [monarch_mapping_commons.Makefile:51: mappings/upheno_custom.sssom.tsv] Error 127
2023-12-08T09:50:10.9122254Z make: *** [Makefile:37: mappings] Error 2
2023-12-08T09:50:10.9123040Z wget https://raw.githubusercontent.com/monarch-initiative/umls-ingest/main/src/umls_ingest/mappings/hp_mesh.sssom.tsv -O mappings/hp_mesh.sssom.tsv
2023-12-08T09:50:10.9123724Z wget https://raw.githubusercontent.com/monarch-initiative/umls-ingest/main/src/umls_ingest/mappings/umls_hp.sssom.tsv -O mappings/umls_hp.sssom.tsv
2023-12-08T09:50:10.9123853Z mkdir -p tmp/upheno/
2023-12-08T09:50:10.9124554Z wget https://bbop-ontologies.s3.amazonaws.com/upheno/current/upheno-release/all/upheno_species_lexical.csv -O tmp/upheno/upheno_species_lexical.csv
2023-12-08T09:50:10.9124682Z mkdir -p tmp/upheno/
2023-12-08T09:50:10.9125381Z wget https://bbop-ontologies.s3.amazonaws.com/upheno/current/upheno-release/all/upheno_mapping_logical.csv -O tmp/upheno/upheno_mapping_logical.csv
2023-12-08T09:50:10.9125498Z mkdir -p tmp/upheno/
2023-12-08T09:50:10.9126222Z wget https://bbop-ontologies.s3.amazonaws.com/upheno/current/upheno-release/all/upheno_all_with_relations.owl -O tmp/upheno/upheno_all_with_relations.owl
2023-12-08T09:50:10.9126343Z mkdir -p mappings tmp
2023-12-08T09:50:10.9126943Z phenio-toolkit lexical-mapping --species-lexical tmp/upheno/upheno_species_lexical.csv -m tmp/upheno/upheno_mapping_logical.csv -o tmp
2023-12-08T09:50:10.9127294Z make[1]: Leaving directory '/__w/monarch-mapping-commons/monarch-mapping-commons'
2023-12-08T09:50:10.9137125Z ##[error]Process completed with exit code 2.

Does it come from github workflow?
During the merge process all workflows have been passed.

Yes, because you had not yet added your mapping to the registry.yml file - I did that, now it is tested.

It's weird. Because the phenio-toolkit is published here:
https://pypi.org/project/phenio-toolkit/
Additionally, it is declared to be installed in toml file:
https://github.com/monarch-initiative/monarch-mapping-commons/blob/21b412983178b95aa6fe6e626b8985ebd519971d/pyproject.toml#L15
Could you try to clone it on your local machine?

Cant now, toooo busy; my guess: the GitHub action running the test is running on ODK and does not install poetry dependencies. Maybe you need to add a pip install step in the action?


Talk about examples in the documentation

Closes #378

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (0445393) 90.27% compared to head (517cca8) 90.26%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #406      +/-   ##
==========================================
- Coverage   90.27%   90.26%   -0.01%
==========================================
  Files         141      141
  Lines       19947    19947
==========================================
- Hits        18007    18006       -1
- Misses       1940     1941       +1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


v19.0.0 refactored ship, path and game systems

[Current coverage][cc-pull] is 98.09%

Merging [#471][cc-pull] into [master][cc-base-branch] will decrease coverage by 1.90%

2 files (not in diff) in src/GameBundle were modified. more

Misses +7
Hits -7

@@           master       #471   diff @@
========================================
  Files          27         27
  Lines         406        420    +14
  Methods        99        103     +4
  Messages        0          0
  Branches        0          0
========================================
+ Hits          406        412     +6
- Misses          0          8     +8
  Partials        0          0

Powered by Codecov. Last updated by [274eb39...fc30151][cc-compare]
[cc-base-branch]: https://codecov.io/gh/eugene-matvejev/battleship-game-api/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/eugene-matvejev/battleship-game-api/compare/274eb39f5674a6766e827dc5273dbc07d0ca1dfd...fc301515d114ca0ff88d293fa9fdaa5773c2ed5a
[cc-pull]: https://codecov.io/gh/eugene-matvejev/battleship-game-api/pull/471?src=pr