add missing obs transform 'bomb_moving_direction' in docker runner

Fixes #249

Thanks! Haven't tested, trusting that you're doing the right thing.


v0.38.2

Fix idom.run failing to run if not specifying a server implementation.
Bump to 0.38.2
Disable greetings CI
Clean up references to idom.server
Fix one miscellaneous use of logger.warn (deprecated)
Fix typos in nox descriptions

I'm not really sure what's going wrong, but tests/test_web/test_module.py::test_module_from_url is failing when I run the tests locally.

There is a script, but it bumps versions and pushes a tag at the same time. I guess I'd assumed that would be done by whoever is performing the release.

@rmorshea Everything remaining seems to just be variable renaming... Not entirely sure how tests are failing.

BTW, I already merged a change that removes the greeting message in favor of a small PR template for now. Can revisit the greeting message later.

I think I've got the fix here + some other minor docstring changes: https://github.com/idom-team/idom/pull/763
Going to close this.


CLS ArcSight 3.1.0 - Added support for webtx JSON format to send spec…

…ific fields to SIEM platform

Added support for webtx JSON format to send specific fields to the SIEM platform


Add comment explaining possible source of error with published packages

I'm using suibase and the Sui Rust SDK, and found that having this comment would have saved a bit of time during debugging.
Hopefully the maintainers also find this useful.

@rockbmb Thanks.
As needed, do not hesitate to reach me on Discord for further collaboration. The helper is not "mature" and your feedback, contribution, debugging is much appreciated.


removed internal alias-type errors.IssuesIterator

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Pull request type

Please check the type of change your PR introduces:

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, renaming)
[x] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] Documentation content changes
[ ] Other (please describe):

What is the current behavior?

Issue Number: N/A
What is the new behavior?

Other information

Codecov Report

Merging #136 (38d1688) into master (1900f58) will increase coverage by 0.06%.
The diff coverage is 0.00%.

 Click here to find out more.

Impacted Files
Coverage Δ

errors.go
10.00% <0.00%> (+0.27%)
:arrow_up:

internal/errors/operation.go
74.64% <0.00%> (+7.55%)
:arrow_up:

internal/table/session.go
75.29% <0.00%> (+0.23%)
:arrow_up:

internal/table/client.go
91.93% <0.00%> (+0.51%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1900f58...38d1688. Read the comment docs.


Add file-digest's documented default

There is no default to file-digest, despite the README specifying it.

Thank you for your contribution. 😄


Use k_heap instead of sys_mempool

This runs under Zephyr v2.4.0, tested on qemu_x86.
In order to run Zephyr v2.5.0 we have to resolve a breaking change in
k_malloc, it is now defined as inline and a Rust binding is not produced.
...raw::k_malloc(layout.size()) becomes ...raw::k_aligned_alloc(layout.align(), layout.size())
and unfortunately this change is not compatible with Zephyr v2.4.0.
Should the repo branch v2.4.0 and bump to v2.5.0 or is it possible or
preferable to add a macro to Rust, #[cfg(zephyr(2.4.0))]?

sys_mempool was removed v2.5.0 due to its deprecation so we use k_heap
in its place in preparation for moving to v2.5.0

Added gitignores for cargo's target output
Changed alignment of heap to sizeof(void *)

Signed-off-by: Emil Hammarstrom<EMAIL_ADDRESS>

@tylerwhall Unfortunately Rust's conditional compilation is quite lacking, but it was possible to set a "compatible with Zephyr 2.5.0" conditional in the build script of zephyr-core.
I think compatibility conditionals will have to be maintained like this for now, until Rust gets better cfg comparisons and perhaps support for integers.
For now a generic conditional for the whole rust version is OK, but if parts of the API break in different versions more specific conditionals may have to be introduced, e.g. zephyr250_kheap for being "compatible with the kheap introduced in Zepyhr 2.5.0".
I tested the commits on Zephyr 2.3.0, 2.4.0, and 2.5.0 on the qemu_x86 build.
For 2.5.0 CONFIG_LOG_MINIMAL changes to CONFIG_LOG_MODE_MINIMAL.

Thanks for getting this working cleanly across all versions. These are high quality patches!
I just removed CONFIG_LOG_MINIMAL and tested with ci/build-all.sh and ci/sanitycheck.sh. I'll push that and update the readme to indicate we support 2.5.


GDS Admin API: Audit Log in VASP Detail

This PR unblocks @elysee15 by actually sending audit log data in the VASP Detail endpoint.

Codecov Report

Merging #199 (34538b7) into main (e9d78a3) will increase coverage by 0.10%.
The diff coverage is 69.23%.

:exclamation: Current head 34538b7 differs from pull request most recent head 233b268. Consider uploading reports for the commit 233b268 to get more accurate results

@@            Coverage Diff             @@
##             main     #199      +/-   ##
==========================================
+ Coverage   39.12%   39.23%   +0.10%
==========================================
  Files          37       38       +1
  Lines        3698     3711      +13
==========================================
+ Hits         1447     1456       +9
- Misses       1999     2001       +2
- Partials      252      254       +2

Impacted Files
Coverage Δ

pkg/utils/pb.go
69.23% <69.23%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9d78a3...233b268. Read the comment docs.


Using mongoose model discriminator

One of the best practices in the NoSQL databases, is to use same collection for multiple related models.
Mongoose provide a function to to that, model.discriminator(), the doc can be found here : https://mongoosejs.com/docs/discriminators.html
This function is very convient, because it adds a discriminator key to the schema, and automatically filters on this key when using find, update or other.
Is it possible to implement this in typegoose ?
I tried using this function from my base model, but it takes the schema of the child model, and unfortunately typegoose doesn't expose the getSchema function it's private, I wonder why this choice was made.
Here is my example :
 const adminSchema = new Admin().getModelForClass(Admin, {
      schemaOptions: { ...schemaOptions, discriminatorKey: 'role' },
    }).schema;

    const adminModel = BaseUserModel.discriminator(
      Admin.name,
      adminSchema,
    );

This example obviously don't work for multiple reasons :

getModelForClass compiles the AdminModel and discriminator function tries to di the same, mongoose throws an exception because of that.

The discriminator function returns a mongoose model document, which is not a Typegosse document.

i'm new to the model.discriminator() thing, but i think i found what you search for
( you can skip down to the "import part")
import * as mongoose from "mongoose";
import { prop, Typegoose } from "typegoose";

class DummyType1 extends Typegoose {
    @prop({ required: true, default: "prop1_default" })
    public prop1!: string;
}

class DummyType2 extends DummyType1 {
    @prop({ required: true })
    public prop2!: string;
}

class DummyType3 extends DummyType1 {
    @prop({ required: true })
    public prop3!: string;
}

//  here the important part starts
const DummyModel1 = new DummyType1().getModelForClass(DummyType1);
const DummyModel2 = DummyModel1.discriminator("D2", new DummyType2().getModelForClass(DummyType2).schema);
const DummyModel3 = DummyModel1.discriminator("D3", new DummyType3().getModelForClass(DummyType3).schema);
//  here it ends

(async () => {
    mongoose.set("debug", true);
    await mongoose.connect(`mongodb://mongodb:27017/`, {
        useNewUrlParser: true,
        useFindAndModify: true,
        useCreateIndex: true,
        dbName: "verify294",
        user: "user",
        pass: "passwd",
        authSource: "admin",
        autoIndex: true
    });

    await new DummyModel2({ prop2: "prop2" } as DummyType2).save();
    await new DummyModel3({ prop3: "prop3" } as DummyType3).save();

    await mongoose.disconnect();
})();

The problem with that implementation is that you're creating two model for the same class.
Calling .getModelForClass(DummyType2).schema) will create a model inside mongoose called "DummyType2" based on schema of "DummyType2" and calling DummyModel1.discriminator("D2", new DummyType2() will create the same model just different name, here it will be "D2".
I'm sure there is a better way to solve this issue.

this can be closed in favor of #332
@Ben305


Fix #17: Support clang by updating RocksDB

Fix #17 by using the newest release of rocksdb. The project should be able to compile with Clang now (but one may need to add std:: to ostream, etc.) Note that this commit is cherrypicked from my branch, which commented out frontend executables not using LeanStore and RocksDB. This may only solve part of the problem.

@alicia-lyu Many thanks for your contributions.
Can you also address the review comments?

@alicia-lyu Many thanks for your contributions.
Can you also address the compile error in frontend/shared/Schema.hpp file as well?

Sorry for the late response. I am not sure about the issues at first sight. I will try to install it in a new machine and get back to you by the end of next week.


Warning message and pkt2flow return nothing

After compilation I've simply tried:
./pkt2flow in.pcap
and it doesn't create any output file.
Maybe it is correlate with this warning during compilation:
scons: Reading SConscript files ... scons: done reading SConscript files. scons: Building targets ... gcc -o flow_db.o -c -I. flow_db.c gcc -o pkt2flow.o -c -I. pkt2flow.c pkt2flow.c: In function 'resemble_file_path': pkt2flow.c:150:8: warning: implicit declaration of function 'asprintf'; did you mean 'vsprintf'? [-Wimplicit-function-declaration]   150 |  ret = asprintf(&outputpath, "%s/%s", outputdir, type_folder);       |        ^~~~~~~~       |        vsprintf gcc -o utilities.o -c -I. utilities.c utilities.c: In function 'new_file_name': utilities.c:62:9: warning: implicit declaration of function 'asprintf'; did you mean 'vsprintf'? [-Wimplicit-function-declaration]    62 |   ret = asprintf(&fname, "%s_%"PRIu16"_%s_%"PRIu16"_%lu.pcap",       |         ^~~~~~~~       |         vsprintf gcc -o pkt2flow flow_db.o pkt2flow.o utilities.o -L/usr/local/lib -L/usr/lib -lpcap scons: done building targets.

Adding
#define _GNU_SOURCE

in both utilities.c and pkt2flow.c fixes the warnings, I also have problems with multiple definitions of the pair function that I'm trying to fix atm


Checkmarx reports potential XSS issues

We use Checkmarx Static Code Analysis to identify code vulnerabilities.  In codemirror.js 5.32.0, Checkmarx reports 2 potential XSS issues:

line 1988:
var spans = line.markedSpans, allText = line.text, at = 0
Checkmarx reports that line.text is eventually displayed to the user in lines 1974 and 1979

line 2177
lineView.node.appendChild(lineView.text)
Checkmarx reports that lineView.text is eventually displayed to the user in line 2191

Can you either fix these vulnerabilities or assure us that they cannot be used to enable a cross site scripting attack?

The text in the editor is indeed displayed to the user—that's what an editor does. That does not, however, constitute an XSS vector.

I edited my original issue to elaborate that Checkmarx indicates the values "flow through the code without being properly sanitized or validated"


Added minimal tests for examples.

Currently the examples are not included in the CI process, this leads to
this kind of commit messages :
4eb42e2 Fix ffi example (#949) Was broken a while back.
I added a separate make target test-examplesthough I believe this
tests should be run with the full tests suite.
The package is minimal at the moment, it just tries to use all examples.
Unit tests should be added later, demonstrating some testing techniques.
Some example packages are commented at the moment as they don't build on
my laptop. I still have to figure out what is broken: the example or my
pony build chain.

hmm... One OSX build on travis died telling something like "broken pipe". I can't restart the build myself, but I'm pretty sure it's not a "true" failure.

@lisael i kicked off another build.

[bdupuis:~/projects … onyc/examples/ffi-struct] master+* ± ponyc
Building builtin -> /usr/local/lib/pony/0.2.1-955-g4eb42e2/packages/builtin
Building . -> /home/bdupuis/projects/perso/ponyc/examples/ffi-struct
Generating
 Reachability
 Selector painting
 Data prototypes
 Data types
 Function prototypes
 Functions
 Descriptors
Optimising
Writing ./ffi-struct.o
Linking ./ffi-struct
/usr/bin/ld.gold: error: cannot find -lffi-struct
./ffi-struct.o:ffi-struct:function Main_tag_create_oo: error: undefined reference to 'modify_via_outer'
./ffi-struct.o:ffi-struct:function Main_tag_create_oo: error: undefined reference to 'modify_inner'
./ffi-struct.o:ffi-struct:function Main_tag_create_oo: error: undefined reference to 'modify_inner'
collect2: error: ld returned 1 exit status
Error:
unable to link: cc -o ./ffi-struct -O3 -march=native -mcx16 -fuse-ld=gold ./ffi-struct.o -L"/usr/local/lib/pony/0.2.1-955-g4eb42e2/bin/" -Wl,-rpath,"/usr/local/lib/pony/0.2.1-955-g4eb42e2/bin/" -L"/usr/local/lib/pony/0.2.1-955-g4eb42e2/bin/../lib" -Wl,-rpath,"/usr/local/lib/pony/0.2.1-955-g4eb42e2/bin/../lib" -L"/usr/local/lib/pony/0.2.1-955-g4eb42e2/bin/../packages" -Wl,-rpath,"/usr/local/lib/pony/0.2.1-955-g4eb42e2/bin/../packages" -L"/usr/local/lib" -Wl,-rpath,"/usr/local/lib" -Wl,--start-group -l"ffi-struct" -Wl,--end-group  -lponyrt -lpthread -ldl -lm

I'm not sure why the linker doesn't check in current dir. I hadn't time to investigate further. It's definitely not a Pony syntax or type mismatch error.

As said in the commit message, maybe it's my build chain that is broken, for this one. delegate and yield have pure-Pony issue. I'll try to fix the three packages tomorrow, as I don't think it's sane to merge these new tests as long as they don't pass.

Two issues with running this as an example.
We really need a makefile to build .so. ponyc won't do that.
The linker needs to be directed to look in the ffi-struct directory for the .so

@lisael i opened a PR for the yield example

@lisael and the delegate example (although I really wanted to just delete it)

@jemc i believe you've spoken about something like this. any input?

@lisael also, btw as I forgot to say it, thank you for opening this PR. its definitely something we need. ^5.

My only input is: Thank you! :smiley:


repeat_until incompatible with run repetitions

Description of the issue
Subcircuits with repeat_until can have non-deterministic number of measurements for a given key. ResultDict expects a flat array of measurement results. This can cause exceptions when run with multiple repetitions.
How to reproduce the issue
def test_repeat_until_repetitions():
    q = cirq.LineQubit(0)
    key = cirq.MeasurementKey('m')
    sim = cirq.Simulator()
    c = cirq.Circuit(
        cirq.CircuitOperation(
            cirq.FrozenCircuit(cirq.X(q) ** 0.2, cirq.measure(q, key=key)),
            use_repetition_ids=False,
            repeat_until=cirq.KeyCondition(key),
        )
    )
    sim.run(c, repetitions=10)

Error:
cirq-core/cirq/work/sampler.py:53: in run
    return self.run_sweep(program, param_resolver, repetitions)[0]
cirq-core/cirq/sim/simulator.py:73: in run_sweep
    return list(self.run_sweep_iter(program, params, repetitions))
cirq-core/cirq/sim/simulator.py:104: in run_sweep_iter
    records = self._run(
cirq-core/cirq/sim/simulator_base.py:299: in _run
    return {str(k): np.array(v, dtype=np.uint8) for k, v in records.items()}
E   ValueError: setting an array element with a sequence. The requested array has an inhomogeneous shape after 1 dimensions. The detected shape was (10,) + inhomogeneous part.

Cirq version
0.15.0.dev
@95-martin-orion @maffoo WDYT?

This is definitely an issue, but at least it appears contained to this case - AFAIK there's no situation where a measurement would have a different number of qubits across multiple repetitions / appearances within a repetition.
Numpy doesn't seem to have a nice solution for this. The closest I found was numpy.ma.array (aka masked arrays), which require a bunch of overhead and still don't give the desired behavior in situations like arr=[[1], [2, 3]]; len(arr[0]). What currently consumes this data? Could we get away with a simple list-of-lists, or placeholders for unrealized measurements?
Alternatively, this might be a sign that we finally need the "do not expose in results" tag for measurements...

In a case like this I would probably lean toward padding the measurement arrays with zeros to keep the overall shape rectangular. Since the keys that go into computing the loop termination condition are part of the result, the code that analyzes the result can figure out where things terminated on any given repetition of the circuit. I haven't thought too much about this, though.


enabled param is not taken into consideration with infinitqueries

Hi, There was an issue about enabled param not working in useQuery that seems to have been fixed in this commit, unfortinatenly the problem still persist at useInfinitQuery and also headers provided to useInfinitQuery dont seem to be sent, but maybe the issues are related.
Can yo check this issue please

Yeah looks like I forgot to port that to useInfiniteQuery. Will submit a fix shortly. In the meantime, you can use the 'disableQuery' symbol as the input to that api.
Regarding headers not being passed through, how are you passing the headers in?

As for the headers, i think it was just due to the disable param not being considered. Since the  query is supposed to be enabled only after some auth headers are computed. Thats why i didnt find them in the logs. So the headers are fine i think. Its just the disabled param that needs fixing 👍

Thank you @paul-sachs for the fast action 🎉🎉🎉 , any rough estimate on where this will be released ?

Should be able to get to a release later today. Just trying to nail down if a previous change warrants a 2.0 since it changed the queryKey used by infiniteQuery.

Awesome 😎, thank you very much @paul-sachs 🙏

Fixed in https://github.com/connectrpc/connect-query-es/releases/tag/v1.2.0


daemon: Remove unnecessary package aliases

Remove package aliases where they already correspond to the package
name.
Signed-off-by: Tobias Klauser<EMAIL_ADDRESS>

This pull request is now managed with CodeReviewHub. Refresh.


Multi fixes

@brafdlog Still in draft, I need your approval in the other one

@brafdlog Still in draft, I need your approval in the other one

@brafdlog Ready for review.
Sorry for this collection, I'm just trying to work with the app and fixing things on the fly.
I'm really suggesting you review commit-by-commit, I think you can see the comments also in the commit view.
Start with: https://github.com/brafdlog/budget-tracking/pull/186/commits/6818f44e2f85ff8a345680c23f2160bde4f27b68
Then click on "next" in the upper right.

I don't follow the why you need the dockerfile logic. Lets discuss that.
Other than than, all looks good

I don't follow the why you need the dockerfile logic. Lets discuss that.
Other than than, all looks good. Nice work :)

@brafdlog, about the docker, this is just trying something. Do you know VSCode Dev Containers?
I just like this feature, and also I have issues in my Windows machine for running this project right now, so I tried to create a Docker for a development workspace. But if you think it confusing, I can leave it in a separate branch.
Except this, any other comments? (I'm not sure you approved, since you already approved early.)


Incorrect parsing and 'Unresolved variable' report for heredocs

I'm using bash plugin version <IP_ADDRESS>-beta3
For code
echo <<'EOF'
    counter=0
    echo "${counter}"
    coutner=$((counter+1))
EOF

${counter} splits heredoc in 3 psi elements: bash here doc, Bash-var and bash here doc. And as conclusion, counter reported as unresolved variable.
My suggestion is to improve lexer, so it will ignore anything in heredocs with substitution turned off. This can easily be checked for appearance of quotes around stop-word.

Thanks. The lexer was already working like that - ${} style variables were still lexed, though.

I've found another case (using 1.5.0-142beta4 and IDEA 142.3926):
echo <<EOF
export A=X
export B=\$A
EOF

$A is bash-var in psi and reported as unresolved, but actually $ is escaped.

We continue here :)


nRF51822 Support

Hey, is any support for the nRF51822, used by the Calliope Mini, planned?
If not, how hard would it be to implement?

We don't currently have a PAC for that chip, so you'd have to add one to https://github.com/nrf-rs/nrf-pacs. Then, adding HAL support should be relatively straightforward (you can check https://github.com/nrf-rs/nrf-hal/pull/148 for an example PR adding support for a new chip).

Do you know where I could find the SVD file for that chip? I tried downloading the MDK, and while it does contain SVD's for a lot of chips, there are only the following, relatively short, files for the 51822:

nrf51822_peripherals.h
nrf51822_xxaa.ld
nrf51822_xxab.ld
nrf51822_xxac.ld

Furthermore, the header file contains the line
/* This file is deprecated */
How would I generate a PAC crate for this chip?

Oh, nRF51822, that's already supported by the nrf51-pac and nrf51-hal. I thought it said nRF52822, which does not seem to exist.

Ah, that's awesome. Thanks!


Header and footer 'wrapping' webpage content

I would like to build something like this:
header: {
    height: "1cm",
        contents: phantom.callback(function(pageNum, numPages) {
            return "
";
        })
    },
    footer: {
        height: "1cm",
        contents: phantom.callback(function(pageNum, numPages) {
            return "
";
        })
    }

this to create a 'wrapping' effect on each page.
But somehow it seems to auto-close the div before the body of the page.
Any ideas on how I could solve this?

+1 for the idea
I think, the markup returned in the phantom.callback function, is even not interpreted taking the markup and css of the rendered page into account. That's why you use inline styles inside of your returned html.
The wrapper idea is nice, but would probably break as soon as a page break is inside another element like a long list or table. So it would also be just fine to have some custom element directly injected?


Add ExactSizeIterator implementations to buffer structs.

Pixels, PixelsMut, EnumeratePixels and EnumeratePixelsMut are
all elligible to have ExactsizeIterator implementations added because
the underlying iterator (a Chunks) implements ExactSizeIterator.
I wasn't sure if I needed to do anything because of how many channels there are per pixel, but this is a first stab.

Merging.

Thanks!


MB-5950 use ghc planner in payment request create

Description
This PR enables the GHCPlanner to be used by the payment request creator. It also resolves a couple of #G601 warnings that were turned off as well.
Reviewer Notes
Had to refactor a bit to resolve the G601 warnings, so some extra attention there would be appreciated.`p
Setup
Save the following to payload.json:
{
  "body": {
    "isFinal": false,
    "moveTaskOrderID": "9c7b255c-2981-4bf8-839f-61c7458e2b4d",
    "serviceItems": [
      {
        "id": "94bc8b44-fefe-469f-83a0-39b1e31116fb"
      },
      {
        "id": "eee4b555-2475-4e67-a5b8-102f28d950f8"
      },
      {
        "id": "6431e3e2-4ee4-41b5-b226-393f9133eb6c"
      },
      {
        "id": "fd6741a5-a92c-44d5-8303-1d7f5e60afbf"
      }
    ]
  }
}

Start the server
make bin/prime-api-client
make db_dev_e2e_populate
make server_run

Create a payment request
prime-api-client --insecure create-payment-request --filename payload.json | tee output.json | jq .

Verify that DistanceZip3 is 354 and DistanceZip5 is 388 of the first two service items. Fuel Surcharge (FSC) will have both DistanceZip3 and DistanceZip5 set to 354. Run the following command to filter things down.
jq '.paymentServiceItems | map(.paymentServiceItemParams | map(select(.key == "ZipDestAddress" or .key == "ZipPickupAddress" or .key == "DistanceZip5" or .key == "DistanceZip3") | { "key": .key, "type": .type, "value": .value, "paymentServiceItemParamID": .id, "paymentServiceItemID": .paymentServiceItemID }))' output.json

[
  [
    {
      "key": "ZipDestAddress",
      "type": "STRING",
      "value": "94535",
      "paymentServiceItemParamID": "209d7895-590e-4012-bd04-8308ac26fe7f",
      "paymentServiceItemID": "05fc2645-5358-4618-a2bd-e81114e5265a"
    }
  ],
  [ // DSH
    {
      "key": "DistanceZip5",
      "type": "INTEGER",
      "value": "388",
      "paymentServiceItemParamID": "5af85de2-da2b-4461-9462-f423e4b4b7a5",
      "paymentServiceItemID": "2c474a0e-af46-41fa-89e7-facc704f438b"
    },
    {
      "key": "ZipPickupAddress",
      "type": "STRING",
      "value": "90210",
      "paymentServiceItemParamID": "3d23ec12-9751-4d0b-9229-ce7daba16135",
      "paymentServiceItemID": "2c474a0e-af46-41fa-89e7-facc704f438b"
    },
    {
      "key": "ZipDestAddress",
      "type": "STRING",
      "value": "94535",
      "paymentServiceItemParamID": "43cd95a8-d601-44e7-afba-9e11df692a70",
      "paymentServiceItemID": "2c474a0e-af46-41fa-89e7-facc704f438b"
    }
  ],
  [ // DLH
    {
      "key": "DistanceZip3",
      "type": "INTEGER",
      "value": "354",
      "paymentServiceItemParamID": "99f43477-c90e-4731-af40-789002345df6",
      "paymentServiceItemID": "b3a1f455-fd8d-4df8-a4b7-90951f04c59d"
    },
    {
      "key": "ZipPickupAddress",
      "type": "STRING",
      "value": "90210",
      "paymentServiceItemParamID": "b24c44e3-529b-4af5-bff9-31f798ebd80c",
      "paymentServiceItemID": "b3a1f455-fd8d-4df8-a4b7-90951f04c59d"
    },
    {
      "key": "ZipDestAddress",
      "type": "STRING",
      "value": "94535",
      "paymentServiceItemParamID": "a46640d7-131f-4eaa-a282-12e699dd503b",
      "paymentServiceItemID": "b3a1f455-fd8d-4df8-a4b7-90951f04c59d"
    }
  ],
  [ // FSC
    {
      "key": "DistanceZip3",
      "type": "INTEGER",
      "value": "354",
      "paymentServiceItemParamID": "1b6f17af-28ff-4e4d-9142-1f2d9882328c",
      "paymentServiceItemID": "d3fe9de1-61ad-402b-bb27-261ed268b641"
    },
    {
      "key": "DistanceZip5",
      "type": "INTEGER",
      "value": "354",
      "paymentServiceItemParamID": "b9fef5db-e8a1-47f7-b8cd-0d0fd64883bc",
      "paymentServiceItemID": "d3fe9de1-61ad-402b-bb27-261ed268b641"
    }
  ]
]

Code Review Verification Steps

[X] Request review from a member of a different team.
[X] Have the Jira acceptance criteria been met for this change?

References

Jira story for this change

Messages

:book:
:link: MB-5950

  Generated by :no_entry_sign: dangerJS against 3c0838b0ba1ed1eddd98a53ca0a615b8881600ef


angular-cli (v11.2.13) audit fails from dns-packet vulnerability

Installing angular-cli version 11.2.13 and running an npm audit shows high security vulnerability from dns-packet. The package.json for my setup has devDependencies:
"@angular-devkit/build-angular": "~0.1102.13", "@angular/cli": "~11.2.13"
The npm-audit response is:
High            Memory Exposure

Package         dns-packet

Patched in      >=5.2.2

Dependency of   @angular-devkit/build-angular [dev]

Path            @angular-devkit/build-angular > webpack-dev-server > bonjour
                  > multicast-dns > dns-packet

More info       https://npmjs.com/advisories/1745

The issue is also reported in https://github.com/angular/angular-cli/issues/20795 but only for angular 12

webpack-dev-server is using bonjour which is using an outdated version of multicast-dns, and therefore this is not actionable by the Angular CLI.
This vulnerability doesn't impact Angular CLI and Webpack Dev-Server as these tools are not meant to be used in production where this security vulnerability can be exploited.
Related upstream issues;
webpack/webpack-dev-server#3340
watson/bonjour#63

@alan-agius4
But it impacts security of the CI/CD. There's possibility to import dev packages in production code so npm audit should check all dependencies. Any project that cares heavily about security issues needs to block the whole deployment process if any issue is found.
This issue shouldn't be closed and Angular team should really focus on providing a solution, not shifting the responsibility as anyone using angular has to deal with dependencies it creates.

Hi @zentoaku,

In general the NPM audits should be taken with a pinch of salt , one of the problems with npm audit is that there is no way to control if the reported vulnerability is relevant.
Unless in CI/CD enviorment you are spawning the dev-server, it is running in an un-secure network and sometime within that network is crafting malicious domain queries this vulnerability cannot be exploited.
The NPM advisory is also outdated as this issue has been addressed in dns-packet version 1.3.4.

This issue shouldn't be closed and Angular team should really focus on providing a solution, not shifting the responsibility

Unfortunately  this is caused by a transitive dependency of a transitive dependency, literally in this case there is nothing we can do but wait for an upstream fix.

@alan-agius4 I understand and agree that for know you can only wait. But in long term angular should track and care, and if needed replace problematic dependency.
As an example I can tell that in banking any kind of security issue is taken very seriously and therefore checked on the earliest stage possible. For js it will be npm audit unfortunately.

@alan-agius4 I just want to point out that Bonjour was last updated five years ago, it seems unlikely we'll get an upstream fix for this one.

The NPM advisory is also outdated as this issue has been addressed directly in dns-packet version 1.3.4, therefore it doesn’t require any action from bonjour.


How to change collection name in model?

I have a custom_lists collection in mongodb and CustomList model. Model not matching with collection.

Solved.
static get schemaOptions() {     return {       collection: "custom_lists",     };   }

Solved.
static get schemaOptions() { return { collection: "custom_lists", }; }


Create a skeleton class for FlexboxLayoutManager that extends RecyclerView.LayoutManager.

Also extract the common part of the flexbox logic from the FlexboxLayout to reuse it from the FlexboxLayaoutManager.
Note that this PR targets dev_recyclerview branch, not the master branch so we don't need to care the breaking change at this moment.

This is the first PR for LayaoutManager for RecyclerView.
@yigit @yaraki  could you have a look?

Thanks! Addressed all. PTAL

LGTM!


Add missing headers and update copyright years

Codecov Report

Merging #1961 (5c5a10d) into main (46c79a8) will decrease coverage by 0.03%.
The diff coverage is n/a.

:exclamation: Current head 5c5a10d differs from pull request most recent head 4bf62fc. Consider uploading reports for the commit 4bf62fc to get more accurate results

@@            Coverage Diff             @@
##             main    #1961      +/-   ##
==========================================
- Coverage   63.96%   63.93%   -0.04%
==========================================
  Files         130      130
  Lines       15479    15479
==========================================
- Hits         9901     9896       -5
- Misses       5578     5583       +5

Impacted Files
Coverage Δ

bench/irmin-pack/bench_common.ml
20.98% <ø> (ø)

bench/irmin-pack/trace_collection.ml
83.75% <ø> (ø)

bench/irmin-pack/trace_common.ml
87.50% <ø> (ø)

bench/irmin-pack/trace_definitions.ml
62.06% <ø> (ø)

bench/irmin-pack/trace_replay.ml
43.26% <ø> (ø)

bench/irmin-pack/trace_stat_summary.ml
83.90% <ø> (ø)

bench/irmin-pack/trace_stat_summary_pp.ml
0.18% <ø> (ø)

bench/irmin-pack/trace_stat_summary_utils.ml
60.00% <ø> (ø)

src/irmin-chunk/irmin_chunk.ml
77.67% <ø> (ø)

src/irmin-cli/cli.ml
20.74% <ø> (ø)

... and 102 more

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more


how to pass json value as percentage variable

i am trying to show pie chart from my json output but showing below error
Error: Exception in HostFunction: Malformed calls from JS: field sizes are different.
[[24,24,24,24,24],[2,2,2,2,2],[[759,"ARTGroup",271,{"transform":[1,0,0,1,0,0],"opacity":1}]],2468]
This error is located at:
in ARTGroup (at Group.js:35)
in Group (at Pie.js:129)
in RoundDividers (at Pie.js:178)
in ARTGroup (at Group.js:35)
in Group (at Pie.js:169)
in ARTSurfaceView (at Surface.js:37)
in Surface (at Pie.js:168)
in Pie (at ReportsDisplay.index.js:141)
in RCTView (at View.js:34)
in View (at ReportsDisplay.index.js:135)
in RCTView (at View.js:34)
in View (at ScrollView.js:1124)
in RCTScrollView (at ScrollView.js:1260)
in ScrollView (at ScrollView.js:1286)
in ScrollView (at ReportsDisplay.index.js:132)
in ReportScreen (at SceneView.tsx:122)
in StaticContainer
in StaticContainer (at SceneView.tsx:115)
in EnsureSingleNavigator (at SceneView.tsx:114)
in SceneView (at useDescriptors.tsx:153)
in RCTView (at View.js:34)
in View (at CardContainer.tsx:245)
in RCTView (at View.js:34)
in View (at CardContainer.tsx:244)
in RCTView (at View.js:34)
in View (at CardSheet.tsx:33)
in ForwardRef(CardSheet) (at Card.tsx:573)
in RCTView (at View.js:34)
in View (at createAnimatedComponent.js:165)
in AnimatedComponent (at createAnimatedComponent.js:215)
in ForwardRef(AnimatedComponentWrapper) (at Card.tsx:555)
in PanGestureHandler (at GestureHandlerNative.tsx:13)
in PanGestureHandler (at Card.tsx:549)
in RCTView (at View.js:34)
in View (at createAnimatedComponent.js:165)
in AnimatedComponent (at createAnimatedComponent.js:215)
in ForwardRef(AnimatedComponentWrapper) (at Card.tsx:544)
in RCTView (at View.js:34)
in View (at Card.tsx:538)
in Card (at CardContainer.tsx:206)
in CardContainer (at CardStack.tsx:620)
in RCTView (at View.js:34)
in View (at Screens.tsx:84)
in MaybeScreen (at CardStack.tsx:613)
in RCTView (at View.js:34)
in View (at Screens.tsx:54)
in MaybeScreenContainer (at CardStack.tsx:495)
in CardStack (at StackView.tsx:462)
in KeyboardManager (at StackView.tsx:458)
in RNCSafeAreaProvider (at SafeAreaContext.tsx:74)
in SafeAreaProvider (at SafeAreaProviderCompat.tsx:42)
in SafeAreaProviderCompat (at StackView.tsx:455)
in GestureHandlerRootView (at GestureHandlerRootView.android.tsx:26)
in GestureHandlerRootView (at StackView.tsx:454)
in StackView (at createStackNavigator.tsx:87)
in StackNavigator (at App.js:233)
in EnsureSingleNavigator (at BaseNavigationContainer.tsx:409)
in ForwardRef(BaseNavigationContainer) (at NavigationContainer.tsx:91)
in ThemeProvider (at NavigationContainer.tsx:90)
in ForwardRef(NavigationContainer) (at App.js:232)
in App (at App.js:432)
in Provider (at App.js:431)
in _default (at renderApplication.js:45)
in RCTView (at View.js:34)
in View (at AppContainer.js:106)
in RCTView (at View.js:34)
in View (at AppContainer.js:132)
in AppContainer (at renderApplication.js:39)
need help

Not sure if you're still stuck on this or if this is the same issue, but I had a Malformed JS issue and it was due to passing infinite values across the RCTBridge; solution below...
percentage:

// (valueA /
//     valueB) *
// 100,

Math.round(
    (valueA / valueB) * 100
),

Not sure if you're still stuck on this or if this is the same issue, but I had a Malformed JS issue and it was due to passing infinite values across the RCTBridge; solution below...
percentage:

// (valueA /
//     valueB) *
// 100,

Math.round(
    (valueA / valueB) * 100
),

its working i am just passing my object property in Number method and its work fine thanks for reply


mmsd: init at 1.12.1 with module

Description of changes
Package Multimedia Messaging Service Daemon - The Next Generation and add a NixOS service launched through the D-Bus by apps like Purism's chatty.

Things done

Built on platform(s)

[X] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[X] Fits CONTRIBUTING.md.

[X] Added a release note for 23.05.

Alas, more conflicts on release notes :'( ; please fix the conflicts and I think we are good for merge.

[X] Fix merge conflict on rl-2305.section.md
[X] Fix meta.license

So sorry it is taking a while, again merge conflicts, as now, we have two approvals, we can proceed just after the conflicts being fixed.

[X] Rebase to fix merge conflict with 08d651764f59

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-already-reviewed/2617/741

[x]  Rebase to fix merge conflict with 08d6517

Unfortunately, still seeing conflicts :'( (so many PRs being merged, and we are now at 4.3k… PRs)

[X] Fix merge conflict in rl-2305.section.md


Daniel Donovan D000625 Photo

Name: Daniel Donovan
Bioguide ID: D000625
Image page: https://en.wikipedia.org/wiki/Dan_Donovan_(politician)#/media/File:Congressman_Daniel_Donovan.jpg
Image link: https://upload.wikimedia.org/wikipedia/commons/f/f1/Congressman_Daniel_Donovan.jpg

Added in https://github.com/unitedstates/images/pull/110.


dts: arm: silabs: Configure HFXO in dtsi

In this PR I have moved configuration of HFXO from header files defined in boards directories to SoC devicetrees.

@MaureenHelm Could you take a look please?


Why tini will produce a lot of the same process, and turn off

Why tini will produce a lot of the same process, and turn off, whether to sleep 1 second or 500 milliseconds; as the red is the production process and exit

From the process ID, docker-init was created by tini 6 times, and finally only the process ID is 5 alive.

In htop by the default userland threads colored in green. So there are 3 processes and others (colored in green) are threads. So that not "a lot of same processes".

@krallin  Docker-init is my own program, named docker-init

@SkeLLLa  I still don't understand

Tini started your docker-init program once, but your docker-init program is running 6 threads. That's why you see it 6 times.

@krallin I finally understand, thank you


Support batch_inverse_classic on 0 columns.

This change is

Codecov Report
Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 91.73%. Comparing base (e0dd4fb) to head (796bcdf).

Files with missing lines
Patch %
Lines

crates/prover/src/core/fields/mod.rs
75.00%
1 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #878      +/-   ##
==========================================
- Coverage   91.73%   91.73%   -0.01%
==========================================
  Files          92       92
  Lines       12731    12734       +3
  Branches    12731    12734       +3
==========================================
+ Hits        11679    11681       +2
- Misses        939      940       +1
  Partials      113      113

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Add pnu university

@DunaAlsuliman First stage of verification passed, official domain is pnu.edu.sa as far as I verified. This is just an informational note. Pull request is still in the review. I appreciate your patience while waiting for the final decision.

@DunaAlsuliman Please provide us with an URL of a page on the official website where the school offers an IT-related long-term (>1 year) course. Thank you!

@philipto You can find on the following page the programs offered by my college for each department and their details, please let me know if you need further information.
https://www.pnu.edu.sa/en/Faculties/ComputerScience/Programs_Bachelors_Degree_3Semesters/Pages/default.aspx

@DunaAlsuliman Thank you for your patience while waiting for a review and processing your request. Pull request merged.


Removing listeners can cause an exception depending on how you call off()

Line 3277 (version 2.3.4) can cause an exception when removing listeners.  If you do an off() and then off("name.listener") can cause exceptions.
I use several plugins like resize.js, draggable.js. Each have their own clean up function that removes listeners.
Example of my code.  var shapes= draw.set()
function cleanupExtensions() {
	shapes.selectize(false, {deepSelect:true});
	shapes.each(function(i) {
	  this.resize('stop');
	  this.draggable(false);
	});
}

...
shapes.off(); // cleanup my own listeners
cleanupExtensions();

By invoking shapes.off() i believe
delete SVG.listeners[index]
is called and when this.resize('stop'); and this.draggable(false); are called then
if (SVG.listeners[index][ev] && SVG.listeners[index][ev][ns]) {
will cause an exception.  Because they are doing individual off() calls. Like this.el.off("lt.resize");
My fix is to add a null check in the if statement.
if (SVG.listeners[index] && SVG.listeners[index][ev] && SVG.listeners[index][ev][ns]) {
SVG.off = function(node, event, listener) {
  var index = SVG.handlerMap.indexOf(node)
    , ev    = event && event.split('.')[0]
    , ns    = event && event.split('.')[1]

  if(index == -1) return

  if (listener) {
    if(typeof listener == 'function') listener = listener._svgjsListenerId
    if(!listener) return

    // remove listener reference
    if (SVG.listeners[index][ev] && SVG.listeners[index][ev][ns || '*']) {
      // remove listener
      node.removeEventListener(ev, SVG.listeners[index][ev][ns || '*'][listener], false)

      delete SVG.listeners[index][ev][ns || '*'][listener]
    }

  } else if (ns && ev) {
    // remove all listeners for a namespaced event
    if (SVG.listeners[index][ev] && SVG.listeners[index][ev][ns]) {  // THIS IS WHERE THE EXCEPTION THROWN
      for (listener in SVG.listeners[index][ev][ns])
        SVG.off(node, [ev, ns].join('.'), listener)

      delete SVG.listeners[index][ev][ns]
    }

  } else if (ns){
    // remove all listeners for a specific namespace
    for(event in SVG.listeners[index]){
        for(namespace in SVG.listeners[index][event]){
            if(ns === namespace){
                SVG.off(node, [event, ns].join('.'))
            }
        }
    }

  } else if (ev) {
    // remove all listeners for the event
    if (SVG.listeners[index][ev]) {
      for (namespace in SVG.listeners[index][ev])
        SVG.off(node, [ev, namespace].join('.'))

      delete SVG.listeners[index][ev]
    }

  } else {
    // remove all listeners on a given node
    for (event in SVG.listeners[index])
      SVG.off(node, event)

    delete SVG.listeners[index]

  }
}

Good catch! Can you pls create a testcase which shows that error? That would help a lot and speed up the fixing process.
However: You should avoid calling a general off() on an element. You could end up removing listeners which arent yours which then would lead to wrong behavior.
Not every plugin will gracefully accept your interference as svg.select or svg.resize do.
So you better get used to using a namespace for your own bindings, too.

svg-test-off-exception.zip
There is just one file.  It is not a Jasmine test case but just an html file that shows the error.
The off() works for me in this case because I have a controlled Set of objects that I apply it to, so I can be lazy and just call off()  And having no listeners on those objects is exactly what I want.

The intention of this test is to have or code better tested with higher code coverage and that this bug is not reintroduced later. So a jasmine test is what I was aiming for :D


validate_channels(): Argument #1 ($channels) must be of type array, Collection given

Everything was working fine for a long time until now. I started to get this error out of nowhere:
Pusher\\Pusher::validate_channels(): Argument #1 ($channels) must be of type array, Illuminate\\Support\\Collection given, called in /vendor/pusher/pusher-php-server/src/Pusher.php on line 341
The error occurs when trying to broadcast an event like so:
broadcast(new UpdateListEvent());
Using Laravel 9 and laravel-webscokets 1.13.1
Any ideas?

Update 1:
Figured out that it was a particular composer update that caused this issue and the update was to the main Laravel package:
laravel/framework (9.x-dev 3be7023 => 9.x-dev c51ef98)
After update to 9.x-dev c51ef98 it stops working. I think the issue is with Laravel it self and not laravel-websockets

It seems the error is caused by Laravel 9.12.0 with Pusher 7.0. I've just opened this PR on Laravel repository.

same here

A fix has been released in Laravel. If you had already installed version 9.12.0 in the past, try this:

Revert to 9.11, and run composer update.
Clear composer cache: composer clear-cache
Change Laravel framework version back to ^9.12 and run composer update. You should name have the version with the fix in it.

The likely problem is that they deleted the bad 9.12.0 release, made a fix, then re-released it as 9.12.0.

hi @mikebronner the fix was tagged as 9.12.1
so you can just update your project with composer update and it will be working again.

I believe this issue can be closed since it was a Laravel issue.


Mount a Git repository as a volume for another pod

Hi!
This might sound a little bit awkward, but I have a very simple use case and I thought about re-using the existing GitRepository CRD deployed to the cluster that contains a Git repository.
Is there any easy way to mount the content of this Git repository as a volume for a pod?
I looked at using a sidecar container that runs https://github.com/kubernetes/git-sync
Thanks in advance!

Quite comprehensive answer. Many thanks @kingdonb
My use case is super simple, so I'll look into mangling my controllerSet Pod specification to run this git-sync sidecar alongside.
Naively, I wanted to avoid further cognitive load as the tarball was already present behind that API call you mentioned. I removed the network policies in my current deployment (not running a multi-tenancy cluster), but ye I understand what you meant.


Store test datasets in this repo

Our current approach to testing involves a bunch of fixtures which each download a tutorial dataset from xarray (and cache it because it uses pooch), saves them to a temporary directory, then open that dataset from disk. This is not ideal for a few reasons:

The datasets aren't minimal, so they contain more complexity than is really needed to test a single bug / feature. This can make debugging more complicated.
We're using the network when we don't need to be.
vz.open_virtual_dataset calls xr.open_dataset, but because of our test setup xr.open_dataset can potentially be called more than once in the same test invocation, even if the code we are testing only calls it once. This again can make debugging more confusing than it needs to be.

We do need to test our ability to read files from disk, but it might be better just to make some really tiny netCDF files and save them in this repo.
EDIT: Xarray actually does this and no-one seems to complain because the files are only ~1kB in size, which is smaller than the text files containing the actual code.

Note that the way we have been doing this so far is good in that we haven't committed any large files to git, so we don't have to do any cleaning of the git history (which is a PITA).

Just a note that @TomNicholas suggested in https://github.com/zarr-developers/VirtualiZarr/issues/365 that we store a smaller alternative to the NISAR file used in FAILED virtualizarr/tests/test_backend.py::TestReadFromURL::test_virtualizarr_vs_local_nisar as part of this issue.
On this and https://github.com/zarr-developers/VirtualiZarr/pull/235, should we consider moving the tests outside the source code directory or explicitly excluding the data files from the release manifest? Some people care a lot about having small release sizes when using lambda for example, though I'm not sure if this includes both the sdist and wheels or just wheels.

On this and https://github.com/zarr-developers/VirtualiZarr/pull/235, should we consider moving the tests outside the source code directory or explicitly excluding the data files from the release manifest?

I don't think there is any need is there? Currently we don't ship large files with the release, and if we switch to using very small test files (~kB) then we still won't be shipping large files with the release. As long as we actually make sure the files are that small then we don't need to separate it out.
OTOH if this is a commonly done thing then sure let's split them apart.


Update settings documentation

WAGTAIL_WORDPRESS_IMPORTER_REQUESTS_SETTINGS
This adds WAGTAIL_WORDPRESS_IMPORTER_REQUESTS_SETTINGS override instructions to the documentation.
Issue: https://github.com/torchbox/wagtail-wordpress-import/issues/133

Testing

[ ] CI passes
[x] These changes do not reduce test coverage

Documentation.

[x] This PR adds or updates documentation

Codecov Report

Merging #139 (c74521d) into main (41c8ef9) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #139   +/-   ##
=======================================
  Coverage   65.05%   65.05%
=======================================
  Files          32       32
  Lines        1265     1265
  Branches      228      228
=======================================
  Hits          823      823
  Misses        400      400
  Partials       42       42

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41c8ef9...c74521d. Read the comment docs.


Tutorial: How to combine multiple Quarters of Kepler observations

This notebook will form part of the series: Getting started with Kepler and K2 data products.
In this notebook, we will focus on combining multiple quarters of data into a single LightCurve object. This will require previous knowledge of LightCurve and LightCurveFile objects from #3.
We can draw inspiration from existing Lightkurve tutorials:

How to combine light curves from different Kepler quarters

Learning Goals:

What is a Kepler Quarter?
How to download multiple Quarters of Kepler data.
How to combine multiple Quarters of data to form a single LightCurve object
What the benefits are of combining Quarters.

This could be through a brief use of the .fold() function shown in the light curve tutorial.

I've put together a draft of this notebook, ready for comments. I'm certain there's lots of great changes we can make to it!

Thanks @ojhall94.  This is great!
My only real comment is that I would provide slightly more details in a few places:

I would consider adding Understanding a Kepler Quarter to the learning goals, and having the first section be 1.  What is a Kepler Quarter?.  This section could provide a few more details on

Why Kepler used quarters.  Perhaps show a graphic which illustrates that Kepler had to rotate every 3 months to keep its solar panels oriented to the Sun. I remember seeing a graphic somewhere, likely in one of the handbooks, which you could think about including.
Explain what is different quarter-to-quarter. It's useful to point out that targets falling on a different place on the detector meant that their PSF was slightly different.  This in turn caused the photometric aperture masks (and thus the fraction of flux they captured) to be slightly different.  This in turn caused the impact of the differential velocity aberration effect to be different.  None of this needs to be explained in any great detail, but I'd try to hint at these effects and link to the best Handbook/Paper section on the topic we can find.
Explain what is the same quarter-to-quarter (e.g. the majority of the target list remained identical).

I would provide a few more words explaining why the unnormalized light curves look so strikingly different (predominantly: differential velocity aberration, spacecraft pointing changing, temperature-induced focus variations).  It is very well explained in Section 6 of the Kinemuchi 2012 paper.  I'd recap that paragraph in one or two sentences and then refer to the paper for details.  I think it's good to make sure the reader knows that the different systematics that affect each quarter are fairly well understood and can be read up on elsewhere.

The text in Section 4 suggests that stitch() only concatenates the light curves. I'd explicitly explain that stitch() does what you showed in Section 3, i.e. it normalizes each quarter by the median for you.

Does that make sense?

Great suggestions, agreed on all counts! I'll get to work on them tomorrow :)

Thanks for all the feedback! Worked them into the tutorial, I think its a lot more fleshed out now. Let me know what you think!

Thanks @ojhall94!  This is going in the right direction!
This tutorial will need a few changes to the code if we end up turning LightCurve into a sub-class of TimeSeries, so we'll want to revisit after a decision is made on https://github.com/KeplerGO/lightkurve/pull/744!

Good idea. In the meantime, I have a comment from Rebekah Hounsell that I think are worth discussing in a bit more detail here:
About Section 1. What is a Kepler Quarter:

Do you want a whole text section discussing the Kepler quarters or maybe a link to a separate page?
Too much text could be overwhelming rather than informative.

This a great tutorial! Everything is really cohesive, and I think the explanation of why quarters occur is useful in this case, especially since you call back to it later in the text. One thing I think could be clearer in this is that the corrections you're doing before stitching (e.g. .normalize()) are quite basic since this is already PDCSAP flux, and that for stitching SAP flux, there are more steps to be taken.

Thanks for your comments here & elsewhere @astrobel!

I carried out a final review and believe this notebook is ready for copy editing. :+1:

@ojhall94 and @barentsen I finished copy editing this tutorial "How to Combine Multiple Quarters of Kepler Data with Lightkurve" and it was in great shape, very nice clear writing!
I made some minor copy edits throughout and also combined the summary and companion content text under the Introduction section, as per our finalized tutorial template. The only thing I didn't do was touch the Additional Resources section, which we decided on our last call would be removed and additional resources would be incorporated in the main content in context (which I think is mostly happening in this tutorial with the exception of a few resources listed at the end).
So if someone can take a look at that Additional Resources section and incorporate the list of links, that would be great, otherwise this tutorial is all set on my end and ready to go!

I reviewed that Additional Resources section.  I believe that all the materials that were not already linked are not immediately necessary for the tutorial (e.g. MAST TESS Webpage).  Such generic links can better be placed and kept up to date in the environment the notebooks will be integrated into.  As a result, I went ahead and removed the Additional Resources section.
Thanks everyone!

This notebook has successfully been merged into spacetelescope/notebooks.  Thanks everyone!  Closing the issue...


style: slight change of UI

Brief Information
This pull request is in the type of (more info about types):

[ ] build
[ ] ci
[ ] docs
[ ] feat
[ ] fix
[ ] perf
[ ] refactor
[ ] test
[x] style

Related issues (all available keywords):

resolve #510

Details

make a slight change to the UI style according to the design, as shown in the screenshot below:

Checklist

[x] I have read the CONTRIBUTING doc
[x] I have signed the CLA

Others

Oh,I ignored it, I'll revise it right away!


Security vulnerability in node-sass

NPM version (npm -v):6.1.0
Node version (node -v):10.5.0
Node Process (node -p process.versions):
{ http_parser: '2.8.0',
node: '10.5.0',
v8: '6.7.288.46-node.8',
uv: '1.20.3',
zlib: '1.2.11',
ares: '1.14.0',
modules: '64',
nghttp2: '1.32.0',
napi: '3',
openssl: '1.1.0h',
icu: '61.1',
unicode: '10.0',
cldr: '33.0',
tz: '2018c' }
Node Platform (node -p process.platform):win32
Node architecture (node -p process.arch):x64
node-sass version (node -p "require('node-sass').info"):
node-sass       4.9.2   (Wrapper)       [JavaScript]
libsass         3.5.4   (Sass Compiler) [C/C++]
npm node-sass versions (npm ls node-sass):--<EMAIL_ADDRESS>
There is a vulnerability in the hoek package which is used by node-sass.
npm-audit security report:
                   === npm audit security report ===

                             Manual Review
         Some vulnerabilities require your attention to resolve

      Visit https://go.npm.me/audit-guide for additional guidance

Moderate        Prototype pollution
Package         hoek
Patched in      > 4.2.0 < 5.0.0 || >= 5.0.3
Dependency of   node-sass [dev]
Path            node-sass > node-gyp > request > hawk > boom > hoek
More info       https://nodesecurity.io/advisories/566
Moderate        Prototype pollution
Package         hoek
Patched in      > 4.2.0 < 5.0.0 || >= 5.0.3
Dependency of   node-sass [dev]
Path            node-sass > node-gyp > request > hawk > cryptiles > boom >
hoek
More info       https://nodesecurity.io/advisories/566
Moderate        Prototype pollution
Package         hoek
Patched in      > 4.2.0 < 5.0.0 || >= 5.0.3
Dependency of   node-sass [dev]
Path            node-sass > node-gyp > request > hawk > hoek
More info       https://nodesecurity.io/advisories/566
Moderate        Prototype pollution
Package         hoek
Patched in      > 4.2.0 < 5.0.0 || >= 5.0.3
Dependency of   node-sass [dev]
Path            node-sass > node-gyp > request > hawk > sntp > hoek
More info       https://nodesecurity.io/advisories/566
found 4 moderate severity vulnerabilities in 9425 scanned packages
4 vulnerabilities require manual review. See the full report for details.
I have tried to downgrade to 4.7.0 as suggested in the issue2355 but it was still installing the latest version(4.9.2).

https://github.com/sass/node-sass/issues/2355#issuecomment-407949157


Don't error when decoding optional unparsed values

We're newly able to decode actual optional types due to allowing unparsed variable properties. "Normal" optional values are still wrapped in non-optional property wrappers, so ArgumentDecoder didn't need to handle optional values until now. Fixes #285.
Checklist

[x] I've added at least one test that validates that my change is working, if appropriate
[x] I've followed the code style of the rest of the project
[x] I've read the Contribution Guidelines
[x] I've updated the documentation if necessary

@swift-ci Please test


Jordan Ballard Solution w/ jquery

Never mind that other pull request...
completeness: 5
comfort: 5

Good job!


Build out the home page html structure

Lets get this done during the meeting tonite

I brute forced the protection:  branch is merged into main


GitHub API returns 403 when fetching comments

I integrated Utterances into my blog https://ybogomolov.me, but as of today, requests like  https://api.github.com/repos/YBogomolov/ybogomolov.github.io/issues/10/comments?page=1&per_page=25 return 403. Is it somehow related to a recent GitHub outage, or this is something on the Utterances side?

Nevermind, switched to giscus.


Move resources folder out of repository

Description
Have a separate repo for Busola configuration.
Reasons

Auto bumping the images to hash commits - no PR conflicts for images anymore.
To have separation between open source and manage offering configuration.

Tasks

Create a new repository in kyma-project
Move resources dir from busola to new repo
Adjust prow pipelines for Busola
Have a bot to bump the images on busola merge to main
Inform SRE to update their bot (so it pulls from the new repo, not from Busola).
Add GH Actions for promoting Busola to stage and from stage to production.

Target repo: https://github.com/kyma-project/charts

The repository will be extended with Kyma Helm charts if our experiment with Busola will succeeds.

Please remember also about Github releases.
https://github.com/kyma-project/community/blob/main/docs/guidelines/releases-guidelines/06-release-subscription.md


[Feature Request]: Implement Explainable AI (XAI) for Crop Prediction Model

Is there an existing issue for this?

[X] I have searched the existing issues

Feature Description
The current crop recommendation system employs various classification algorithms, with the Random Forest Classifier selected for deployment due to its high accuracy (99.45%). While the model demonstrates excellent predictive performance, it lacks transparency regarding how predictions are made.
To enhance the usability and trustworthiness of the model, I propose the integration of Explainable AI (XAI) techniques. This addition will allow users to understand the factors influencing the model’s predictions, which can help farmers make informed decisions based on the recommendations provided.
Use Case
Integration of XAI Techniques:
    Implement SHAP (SHapley Additive exPlanations) or LIME (Local Interpretable Model-agnostic Explanations) to provide insights into feature importance and model predictions.

Documentation:
    Update the documentation to include details on how to interpret the XAI outputs, ensuring users can easily understand the model’s decisions.

Visualization:
    Create visualizations (e.g., feature importance plots, individual prediction explanations) that can be integrated into the existing user interface, making the XAI outputs accessible and user-friendly.

Benefits
Enhanced Transparency: Users will gain insights into how specific soil and environmental conditions affect crop recommendations.
Informed Decision-Making: By understanding model predictions, farmers can better evaluate and trust the recommendations provided by the system.
Improved Model Validation: XAI will allow for more rigorous validation of the model, ensuring that it aligns with agronomic principles.

Add ScreenShots
No response
Priority
High
Record

[X] I have read the Contributing Guidelines
[X] I'm a GSSOC'24 contributor
[X] I have starred the repository

can you please let me know how much time do you need to complete this issue @kaishwarya24

@manikumarreddyu I will submit it by tomorrow As early as possible

Any updates. @kaishwarya24

"Hi @manikumarreddyu, I’ve completed the work and am trying to upload the file, but it's too large (36.1 MB). I’ll upload it as soon as possible."

i didn't get you

This is how they look. I’ve recorded the video, but I can’t upload it here since the file size is 15 MB.
i will install git and upload it through command line, can i get some time

https://github.com/user-attachments/assets/29386fe0-4443-43a0-8dc1-35de3039be50

yes @manikumarreddyu I have observed it and am about to ask you, then how should I proceed now?

can you implement that feature in any other areas ..in website

I usually work a lot with ML and Deep learning
But iam not much aware of deployment in frontend and backend etc..  but I can try if I have 2 days of time
Or else I will upload this .ibynb and .csv  in a folder

no dont do that...i really appreciate your work...change any one line in readme.. i will merge it..so that you will get points..you really worked hard

Ok I'll do that
Later on if any possible to add my work please message me


Update README.md to use term broadcaster instead of controller

Changed:

JointStateController to JointStateBroadcaster
joint_state_controller to joint_state_broadcaster

which is probably a mistake. If so, should be back ported to Foxy and Galactic

@mergifyio backport galactic


Revert icon not work in some cases on monaco-diff-editor using 0.36.1 cdn version

Issue: Revert icon not work in some cases on monaco-diff-editor
I tried it using latest version and on that it is working. Attaching video recording for reference.
We have to update<EMAIL_ADDRESS>to 0.38.0 i.e latest version
https://github.com/suren-atoyan/monaco-loader/assets/129030391/17730045-7bbd-45ec-9c02-580c04e699de
Attached monaco editor link where you can find this issue
https://microsoft.github.io/monaco-editor/playground.html?source=v0.36.1#XQAAAAIgBAAAAAAAAABBqQkHQ5NjdMjwa-jY7SIQ9S7DNlzs5W-mwj0fe1ZCDRFc9ws9XQE0SJE1jc2VKxhaLFIw9vEWSxW3yscw5U5qQueZ-_oZV7pPg_ICTNUlZ0aFnSg-Rf-7glw9kvLEwU9DUBv61vfTQgkbnA_UZImSVzLZfYENGzweQwl2WpWkekBDUDPvXXh0Hk7w9OCIYDR_qHmPdWfkn449HPCerL8aahZpzTRsPE-nwEaMfejQQvCSFVie6D10gCtXST1XJJoGxbqsxrMKHlHUM-a0q_kuVip-Sl7JTKl1pnJ4HRV7ct4JM6CIzRuuhOU9YWWNgrmHnEr-iMGq63ePrx51pxiyRj4O_CPsk7ziMbP4tjgbNHsIzBYVFtazHJtRP62qxY66O_6fGQBqQij_T2rj9mTCiDROY6K4ZtGWGaA7dUOXq3zEGNZE24MVT0o2HL-fdNN-wcfgWNbr9x5stsQCJMLjBQ4sGTruJW7wEGSOgSAMd9BjF4_NjpMZ2EKxy0hwiUWp4tZwWL2VrpgGwthplAn_byQNDQD77eX-gzS_Revghi7bRZl-VjDOinhPEo31GCGin-DDirE-F3CthcxIXf-lVtXW

@sourabh-singla you can configure it and use the latest version - https://github.com/suren-atoyan/monaco-loader#config

I am closing this because it's already uses newer version


Titles and URLs of deleted collections remain blocked

Create collection, base URL "lolwut", record stuff into it
Delete collection
Create collection with the same base URL "lolwut"

Expected outcome: collection is created, with the old name and base URL
What actually happens: impossible to create collection, since URL is already taken

This appears to be fixed.


feat(structs): Modal

This pull request adds support for Modals.
Additions:

ActionRow
ActionRowComponent
Modal
ModalActionRowComponent

Edits:

Add showModal() to CommandInteraction

This PR is missing ModalSubmitInteraction, I request to hold the Merge until it's been added,
for this PR to provide full functionality with Modals. Review of previous commits can be done prior to the addition.

This PR is missing ModalSubmitInteraction, I request to hold the Merge until it's been added,
for this PR to provide full functionality with Modals. Review of previous commits can be done prior to the addition.

I’ll convert it to a draft for you

Issues:
src/structs/ActionRow.ts(7,13): error TS6133: 'type' is declared but its value is never read.
src/structs/ModalSubmitInteraction.ts(11,29): error TS2339: Property 'custom_id' does not exist on type 'APIModalSubmitInteraction'.
src/structs/ModalSubmitInteraction.ts(12,31): error TS2339: Property 'components' does not exist on type 'APIModalSubmitInteraction'.
What should I use instead of APIModalSubmitInteraction?

Issues: src/structs/ActionRow.ts(7,13): error TS6133: 'type' is declared but its value is never read.
src/structs/ModalSubmitInteraction.ts(11,29): error TS2339: Property 'custom_id' does not exist on type 'APIModalSubmitInteraction'. src/structs/ModalSubmitInteraction.ts(12,31): error TS2339: Property 'components' does not exist on type 'APIModalSubmitInteraction'.
What should I use instead of APIModalSubmitInteraction?

This still requires assistance.

Seems good, requesting review from @suneettipirneni.

Also require help with implementing the ModalSubmitInteraction to Router.

I’ll be merging this to another branch for other people to finish implementing message components (handling modals, buttons, etc) then I’ll be merging to main.
That’s after you address the requested changes though.
Thanks ❤

Changes requested added, and CI passes.


Updated outdated dependencies

Checklist

[x] I have read the Contribution & Best practices Guide.
[x] My branch is up-to-date with the Upstream development branch.
[x] I have added necessary documentation (if appropriate)

Short description of what this resolves:
Updated some outdated dependencies of the project.

Fixes #2168

@Dishebh Yes, please go ahead.

@Dishebh Yes, please go ahead.

Requested access to the repo for dependabot-preview. Pls grant access.

@iamareebjamal This can be closed now!


Change source of namelist files

CABLE v3 currently needs 3 namelist files to run:

cable.nml
pft_params.nml
cable_soilparm.nml

cable.nml is currently sourced from CABLE-AUX and the other 2 from the source code (offline/). Now the example work directory has a namelists/ sub-directory to store examples of those. We need to modify benchcab to source the namelists from this sub-directory.

This fix appears to have broken benchcab.  A fresh run on 14-6-2022 raises an error at line 50 of benchtree.py.
This appears to be copying the structure/files in nml_dir into the site_dir but failing because there is no nml_dir to copy from at this time.  Possibly a sequencing issue.


more gwas catalog evidences?

we only take:
rsID, p-value,panel size
but a more expansive list could be:
rsID, allele freq, p-value, OR/effect size, chromosomal position, mapped/reported genes, traits, study reference
This info can also be obtained by following the gwas catalog link, but users have asked to be able to download this directly from Open Targets Platform or API.
cc @ckongEbi

@ElaineMcA @iandunham
This can be done through GWAS feed to extend the data in their submission. Something that
@afaulconbridge & @MichaelaEBI can work with Olga on

This may have been supeceded by the Genetics portal


chore(deps): Bump golang/grpc

What this PR does / why we need it:
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #
Special notes for your reviewer:
Checklist:

[ ] Fixes #
[ ] PR messages has document related information
[ ] Labelled this PR & related issue with breaking-changes tag
[ ] PR messages has breaking changes related information
[ ] Labelled this PR & related issue with requires-upgrade tag
[ ] PR messages has upgrade related information
[ ] Commit has unit tests
[ ] Commit has integration tests
[ ] E2E run Required for the changes

Hi @Nageshbansal , Can you please update the branch with master and resolve the conflicts.

Sure 🚀


Clarification on internal ingress

Hi, would it be possible to explain what ingress options existing?
A question I have is : Is it possible to call an app from a private vnet without going through the internet and public endpoint?

Hi @karoldeland, this doc describes the options that exist today on ingress https://docs.microsoft.com/en-us/azure/container-apps/ingress?tabs=bash
using az cli you can do --ingress 'external' or --ingress 'internal'. In ARM you can set
"configuration": {
  "ingress": {
    "external": true | false
  }
}

If you create the app with external: true (or --ingress 'external') then your app will get an FQDN that looks like
{APP_NAME}.{UNIQUE_IDENTIFIER}.{REGION_NAME}.azurecontainerapps.io

# or

# CONTAINER_APP_ENV_DNS_SUFFIX is an env var that resolves the dnsSuffix
{APP_NAME}.$CONTAINER_APP_ENV_DNS_SUFFIX

If you set external: false (or --ingress 'internal') then your app url will be
{APP_NAME}.internal.{UNIQUE_IDENTIFIER}.{REGION_NAME}.azurecontainerapps.io

# or

{APP_NAME}.internal.$CONTAINER_APP_ENV_DNS_SUFFIX

the *.internal.* are only resolvable/accessible inside the container app environment. So if you set ingress for an app as internal, then it'll only have the internal endpoint. Other apps running on the same container app env.
Does this answer your question?

Omit --target-port if you don't want ingress. If you set a target-port then the cli assumes ingress, and that must have a type.

Hi @karoldeland, please close if the question is addressed with @ahmelsayed's clarification.

Please revisit if not addressed, closing for now following 7 days of inactivity.


ICU Type "med-surg icu"

Hi all,
is there a way of finding out which surgical specialties are included in patients admitted to “med-surg icu” (so the mixed medical/surgical ICU)?
I’m trying to find out whether this cohort of patients includes cardiothoracic/cardiac surgery patients. Thank you!

Not that I am aware of.
I would suggest looking at the admission diagnosis to see if you can identify your cohort of patients that way, as I would expect most surgical patients would have an admission diagnosis that's surgical.
The only other thing I can suggest is there is a Physician specialty field in one of the APACHE tables.  I cannot vouch for this field, and I would definitely vet it against other data to make sure you're identifying the correct set of patients.

I see - I will look into this. Thank you very much, Jesse!


Network parameters cannot be removed from cloudinit settings

System details:

Proxmox VE 8.2.2
Terraform v1.8.4
terraform-provider-proxmox v3.0.1-rc3

Affected cloudinit network parameters:

searchdomain
nameserver
ipconfig0-15

Creating new resources works as expected, mentioned cloudinit network parameters are correctly created.
These parameters can be changed by provider.
Unfortunately, it is not possible to remove these parameters by provider.
By removing the searchdomain and nameserver arguments from the config, provider ignores this change and does not take any action with the output: No changes. Your infrastructure matches the configuration.
By removing ipconfig0-15, provider tries to remove this, but after apply the previously created ipconfig it still exists. When I try to run terraform apply again, it tries to remove this again and again with no success. The similar situation is with network device removing - https://github.com/Telmate/terraform-provider-proxmox/issues/1027.
These parameters can only be removed through the Proxmox GUI.

@maksimsamt I noticed so weird behavior with cloud-init. Sadly, the scope of the problem got too big for the RC3 release. I'm working on it in https://github.com/Telmate/proxmox-api-go/pull/339

@maksimsamt Could you check if #1049 fixes this for you?

@maksimsamt Could you check if #1049 fixes this for you?

@Tinyblargon ,
Could please for #1049 create additional branch or tag?

@maksimsamt Could you check if #1049 fixes this for you?

searchdomain - works, can add and remove
nameserver - works, can add and remove
ipconfig0-15 -  doesn't work, can add, but remove cannot


Use friendly timestamp like old UI

Feature:
Labels like less than a minute ago were good to catch when something was recent over some trace that was old (mostly interesting when you have recent traces you wanna see). Also having labels for x minutes ago feels more natural to read.
Rational
It was in old UI and I think it was good.

Prior Art

Ping @kirkov

Also https://github.com/openzipkin/zipkin/issues/2351#issuecomment-490047313, but a separate issue here makes it more visible.

We can use fromNow method of moment.
https://momentjs.com/docs/#/displaying/fromnow/


Comments should be ordered by most recent.

It seems common sense to have the comment in order of most recent rather than first posted.

Closed for a reason - there has been no activity for a long time.


Support Firefox

Do you have any intention to publish this extension to the Firefox addons marketplace?

(I think I might have answered you on reddit just now)
I wasn't planning to but mostly because I hadn't even thought about that. I have never looked into developing extensions for firefox so I can't tell for sure but I think it should be a pretty straight forward port. If enough people show interest I'd be more than happy to research that. Also very happy to take Pull Requests for that into this repo if you happen to have experience with that.

(I think I might have answered you on reddit just now)
I wasn't planning to but mostly because I hadn't even thought about that. I have never looked into developing extensions for firefox so I can't tell for sure but I think it should be a pretty straight forward port. If enough people show interest I'd be more than happy to research that. Also very happy to take Pull Requests for that into this repo if you happen to have experience with that.

It wasn't me who asked you about it on Reddit... Also, if I remember correctly, Firefox extensions are the same as Chrome extensions.
https://extensionworkshop.com/documentation/publish/package-your-extension/

It wasn't me who asked you about it on Reddit... Also, if I remember correctly, Firefox extensions are the same as Chrome extensions.
https://extensionworkshop.com/documentation/publish/package-your-extension/

Oh, sorry, both messages came in pretty much at the same time so I thought it might be the same request.
Thanks for the link, that looks promising. Their compatibility tested actually reports the extension is compatible already so I'll try running it on firefox later today when I get a chance and if it works I'll try adding it to the firefox extensions

Oh, sorry, both messages came in pretty much at the same time so I thought it might be the same request.
Thanks for the link, that looks promising. Their compatibility tested actually reports the extension is compatible already so I'll try running it on firefox later today when I get a chance and if it works I'll try adding it to the firefox extensions

Managed to add it to the firefox store: https://addons.mozilla.org/en-US/firefox/addon/material-icons-for-github/
thanks for the pointers!
I ran a quick test on firefox and it looks like it's running without a problem, but please don't hesitate to let me know if you notice any weirdness. Since that's not my main browser I won't use it enough to notice any quirks

Managed to add it to the firefox store: https://addons.mozilla.org/en-US/firefox/addon/material-icons-for-github/
thanks for the pointers!
I ran a quick test on firefox and it looks like it's running without a problem, but please don't hesitate to let me know if you notice any weirdness. Since that's not my main browser I won't use it enough to notice any quirks

Wow, this was fast, thank you!!

Wow, this was fast, thank you!!

Thanks!

Thanks!

This is great!
Would it be possible to submit it to https://addons.mozilla.org?

This is great!
Would it be possible to submit it to https://addons.mozilla.org?

Yeah, that is on the todo list for today. Just need to see if they have a badge I can use to keep the look similar to what is currently on the readme for the chrome web store.

Yeah, that is on the todo list for today. Just need to see if they have a badge I can use to keep the look similar to what is currently on the readme for the chrome web store.

The extension is no longer available in the Firefox add-on market.

@arturoeh 🙈 I was racing to try to finish the last changes before updating the add-on. Looks like I lost the race, sorry.
I just submitted an updated version to the store, it is currently awaiting review (last time it took 1 day)
I also just pushed new github actions that should automatically update the store on new upstream versions, so this shouldn't happen again

I just finished a new version that should make it simpler for the extension to go through their review process. It's in the queue now, let's see how that goes 🤞
I'll check/answer any followup in #26 since that issue is still open. Feel free to followup there if it's not live/working in about a week.
Thanks for the reminder :)


Create Mirth OAI Installer folder

[ ] Have you signed the Contributor License Agreement?
[ ] Have you checked that there aren't other open pull requests for the same manifest update/change?
[ ] This PR only modifies one (1) manifest
[ ] Have you validated your manifest locally with winget validate --manifest <path>?
[ ] Have you tested your manifest locally with winget install --manifest <path>?
[ ] Does your manifest conform to the 1.4 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

I know what is the problem. It look like missing 2 file.

@stephengillie can you request suggested change to this PR?

Automatic Validation failed with:

Manifest: The manifest file path must match PackageIdentifier and PackageVersion properties from manifest. actual
'manifests\r\RamSoft\MirthOAI\1.0.667', expected
'manifests\m\MirthOAI\1.0.667-sriraksha-int-190-pipelineFor-buildMirth.70'

The red boxes have to match. Except that the first one has a \ instead of a ..
And the blue boxes have to match.

The singleton manifest format is out of date. Please consider using the 1.4.0 multi-file manifest format.


add cdim property to audio classes

Closes #602
Added cdim property to audio classes

is it a hotfix (merge into main) or a feature (merge into dev). Maybe we need to discuss on Friday.

Since we have it in other classes we could say were fixing a missing attribute. The next feature release will probably still take a while and it might be nice to have in the meantime. Bit I'm fine with both


insserv: warning: script 'starthabridge.sh' missing LSB tags and overrides

I got some errors in my logs:
insserv: warning: script 'starthabridge.sh' missing LSB tags and overrides
insserv: There is a loop between service ImperiHomestart and starthabridge.sh if stopped
insserv:  loop involving service starthabridge.sh at depth 2
insserv:  loop involving service ImperiHomestart at depth 1
insserv: Stopping starthabridge.sh depends on MyDomoAtHome.sh and therefore on system facility `$all' which can not be true!
insserv: exiting now without changing boot order!
update-rc.d: error: insserv rejected the script header

Did you resolve this?

No
On 16.12.2016 17:06, BWS Systems wrote:

Did you resolve this?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/bwssytems/ha-bridge/issues/306#issuecomment-267627995,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AXG9Psj5SD1hAZes0qKptvbmwAcLYdP-ks5rIrcCgaJpZM4LKAD9.

This is not an ha-bridge issue and you should look into how to configure startup on your particular system as that is what this is.


Favicon

Based on discussion with 8th floor, lets change/retain the favicon to the icon that WC currently use

I'd prefer not to for now as it's really useful to differentiate.
Could we add a subtle change? Either colour of a dot or something?
What is the logic of having the stripes? It isn't very clear on tabs nor home screens as to what it is.

The rationale was that its what users of WC recognise today and its the most neutral mark (2 l shapes from WC logo) in terms of full brand architecture.
We can change the colour (yellow and teal?) but we should test keeping the 2 stripes

Could we have something different? At least for now, we can change it back when we usurp wc.org (not serving from next.). @jennpb Are you happy with this? I personally think sign posting that we're on a separate platform.

For home screens we can/should have an apple-touch-icon i.e. a big one and that could be the Wellcome Collection logo (e.g. https://trustnet.wellcome.ac.uk/sites/all/themes/int_base/touch-icon-192x192.png)

Yep agree. There we have an opportunity to use full WC logo since the space is bigger

Could be nice to use a WC monogram as the favicon, but this feels like a bathroom sign too much...
The 'W' itself is a no-go from brand team

@derivadow Yes, there's a few we need to take into account (we're going to be moving dow the PWA route, so need it for android etc too).

@Norvard If we get an SVG - we can run a task to create these for us.

@jamesgorrie @derivadow If we want a new favicon, we need to engage with the Brand & Comms team, and the head of marketing for WC. I don't think that's a good use of @Norvard's time right now.
The idea behind the two-colour block is that it represents the two ll in Wellcome; this pattern gets used on WC print marketing assets as well. That's why I felt that retaining the existing WC favicon is good enough for now.


How to dismiss progress flower dialog programmatically?

I am using this view on http communication in my activity.
progressFlower = new ACProgressFlower.Builder(getActivity())
.direction(ACProgressConstant.DIRECT_CLOCKWISE)
.themeColor(Color.WHITE)
.text("Please wait...")
.fadeColor(Color.DKGRAY).build();
progressFlower.show();
After get response from server, then run progressFlower.dismiss(), App crashed.
From my debugging, progressFlower is null.
How to dismiss progress flower dialog programmatically?
Best regards.

i fixed myself.

could you share how you fixed it?


SR1.1.1 Add support for showing daily standard deviation on inflammation data

Extend the graphs to show the daily standard deviation as required by SR1.1.1

I did this accidentally, please disregard


Multi invites and more discord integration

See Link.
Is it possible for invites to the multiplayer lobby be integrated into discord?
Also, i noticed here that discord rich presence can allow for 3 lines of text while we currently use only 2, can a current % inside a song be added on the unused field?

It seems the discord rpc api we're using is deprecated and we should be using https://discordapp.com/developers/docs/game-sdk/sdk-starter-guide


Selection with the shift key does not actually select

Windows Terminal version
1.14.1451.0
Windows build number
10.0.19044.0
Other Software
No response
Steps to reproduce
Go to a previous command, press home to go to the start of it, then shift+end to select it, then finally ctrl+c.
Config:
{
    "$help": "https://aka.ms/terminal-documentation",
    "$schema": "https://aka.ms/terminal-profiles-schema",
    "copyFormatting": "none",
    "copyOnSelect": false,
    "defaultProfile": "{1cdf69ac-06b5-4a6f-9fb2-bf594c683073}",
    "initialCols": 200,
    "initialPosition": "0,0",
    "initialRows": 40,
    "actions":
    [
        { "command": "markMode", "keys": "ctrl+shift+m" },
        { "command": { "action": "adjustOpacity", "opacity": -10 }, "keys": "ctrl+shift+-" },
        { "command": { "action": "adjustOpacity", "opacity": 10 }, "keys": "ctrl+shift+=" },
        { "command": "globalSummon", "keys": "browser_stop" },
        { "command": "toggleFocusMode", "keys": "ctrl+numpad_plus" },
        { "command": "find", "keys": "ctrl+f" },
        { "command": { "action": "copy", "singleLine": false }, "keys": "ctrl+c" },
        { "command": "paste", "keys": "ctrl+v" },
        { "command": "selectAll", "keys": "ctrl+a" },
        { "command": "scrollDownPage", "keys": "pgdn" },
        { "command": "scrollUpPage", "keys": "pgup" },
        { "command": "newTab", "keys": "ctrl+t" },
        { "command": { "action": "newTab", "elevate": true, "profile": "PowerShell" }, "keys": "ctrl+shift+t" },
        { "command": "closeTab", "keys": "f13" },
        { "command": "closeOtherTabs", "keys": "shift+f13" },
        { "command": "nextTab", "keys": "f14" },
        { "command": "prevTab", "keys": "f15" },
        { "command": { "action" : "moveTab", "direction": "forward" }, "keys": "shift+f14" },
        { "command": { "action" : "moveTab", "direction": "backward" }, "keys": "shift+f15" },
        { "command": "closePane", "keys": "shift+escape" },
        { "command": "togglePaneZoom", "keys": "ctrl+numpad_multiply" },
        { "command": "toggleReadOnlyMode", "keys": "ctrl+shift+numpad_multiply" },
        { "command": { "action": "splitPane", "split": "up" }, "keys": "ctrl+up" },
        { "command": { "action": "splitPane", "split": "down" }, "keys": "ctrl+down" },
        { "command": { "action": "splitPane", "split": "left" }, "keys": "ctrl+left" },
        { "command": { "action": "splitPane", "split": "right" }, "keys": "ctrl+right" },
        { "command": { "action": "resizePane", "direction": "up" }, "keys": "ctrl+shift+up" },
        { "command": { "action": "resizePane", "direction": "down" }, "keys": "ctrl+shift+down" },
        { "command": { "action": "resizePane", "direction": "left" }, "keys": "ctrl+shift+left" },
        { "command": { "action": "resizePane", "direction": "right" }, "keys": "ctrl+shift+right" },
        { "command": { "action": "moveFocus", "direction": "previousInOrder" }, "keys": "browser_back" },
        { "command": { "action": "moveFocus", "direction": "nextInOrder" }, "keys": "browser_forward" },
        { "command": { "action": "swapPane", "direction": "previousInOrder"}, "keys": "shift+browser_back" },
        { "command": { "action": "swapPane", "direction": "nextInOrder"}, "keys": "shift+browser_forward" }
    ],
    "profiles":
    {
        "defaults": {
            "colorScheme": "Andromeda",
            "selectionBackground": "#FFFFFF",
            "opacity": 70,
            "useAcrylic": true,
            "startingDirectory": "C:\\Users\\ofek\\Desktop",
            "padding": "4, 4, 4, 4",
            "font": {
                "face": "CaskaydiaCove Nerd Font",
                "size": 12,
                "features": {
                    "ss01": 1,
                    "liga": 1
                }
            },
            "bellStyle": "all",
            "experimental.useAtlasEngine": false,
            "experimental.connection.passthroughMode": false
        },
        "list":
        [
            {
                "guid": "{1cdf69ac-06b5-4a6f-9fb2-bf594c683073}",
                "hidden": false,
                "name": "xonsh",
                "commandline": "C:\\Users\\ofek\\AppData\\Local\\Programs\\Python\\Python311\\python.exe -m xonsh",
                "icon": "C:\\Users\\ofek\\AppData\\Local\\Packages\\Microsoft.WindowsTerminalPreview_8wekyb3d8bbwe\\RoamingState\\xonsh.png"
            },
            {
                "guid": "{61c54bbd-c2c6-5271-96e7-009a87ff44bf}",
                "hidden": false,
                "name": "Windows PowerShell"
            },
            {
                "guid": "{0caa0dad-35be-5f56-a8ff-afceeeaa6101}",
                "hidden": false,
                "name": "Command Prompt"
            },
            {
                "guid": "{574e775e-4f2a-5b96-ac1e-a2962a402336}",
                "hidden": false,
                "name": "PowerShell",
                "source": "Windows.Terminal.PowershellCore"
            },
            {
                "guid": "{2c4de342-38b7-51cf-b940-2309a097f518}",
                "hidden": false,
                "name": "Ubuntu",
                "source": "Windows.Terminal.Wsl"
            },
            {
                "guid": "{b453ae62-4e3d-5e58-b989-0a998ec441b8}",
                "hidden": false,
                "name": "Azure Cloud Shell",
                "source": "Windows.Terminal.Azure"
            },
            {
                "guid": "{67128ff7-83ea-54b4-bce0-f65dabb01753}",
                "hidden": false,
                "name": "Developer Command Prompt for VS 2019",
                "source": "Windows.Terminal.VisualStudio"
            },
            {
                "guid": "{00ead8f1-1057-5228-99b3-ce3a45a50ba6}",
                "hidden": false,
                "name": "Developer PowerShell for VS 2019",
                "source": "Windows.Terminal.VisualStudio"
            },
            {
                "guid": "{9fcb6b3a-b1e0-59d5-926b-0bddfb49d36d}",
                "hidden": true,
                "name": "Developer Command Prompt for VS 2017",
                "source": "Windows.Terminal.VisualStudio"
            },
            {
                "guid": "{a3a2e83a-884a-5379-baa8-16f193a13b21}",
                "hidden": false,
                "name": "PowerShell 7 Preview",
                "source": "Windows.Terminal.PowershellCore"
            }
        ]
    },
    "theme": "dark",
    "schemes":
    [
          {
            "name": "Andromeda",
            "black": "#000000",
            "red": "#cd3131",
            "green": "#05bc79",
            "yellow": "#e5e512",
            "blue": "#2472c8",
            "purple": "#bc3fbc",
            "cyan": "#0fa8cd",
            "white": "#e5e5e5",
            "brightBlack": "#666666",
            "brightRed": "#cd3131",
            "brightGreen": "#05bc79",
            "brightYellow": "#e5e512",
            "brightBlue": "#2472c8",
            "brightPurple": "#bc3fbc",
            "brightCyan": "#0fa8cd",
            "brightWhite": "#e5e5e5",
            "background": "#262a33",
            "foreground": "#e5e5e5",
            "selectionBackground": "#5a5c62",
            "cursorColor": "#f8f8f0"
          }
    ]
}

Expected Behavior
Highlighted command is copied
Actual Behavior
It interrupts rather than copies

are you still holding SHIFT when you press CTRL+C?

No

can you reproduce?

I've been looking at this a little bit over the course of the week and I haven't been able to get a repro. I'm throwing this into the 1.15 milestone though because I would like for this to get resolved before we release.
That said, I have a question regarding your repro steps:

Go to a previous command, press home to go to the start of it, then shift+end to select it, then finally ctrl+c.

How do you go to the previous command exactly? Like, in mark mode? You just scroll there and click+drag on it to make a selection? A few more details here would help.
Thanks! Sorry it's taken a bit longer than expected to get around to this one 😅

No as in like press up (history)

xonsh shell btw if that matters

Wait I might see the issue here:

Go to a previous command,
press home to go to the start of it,
then shift+end to select it,
then finally ctrl+c.

Do you actually enter mark mode between 2 & 3? Or are you literally just hitting shift+end?
OH okay I see what's happening here. xonsh is managing its own selection here. I bet there's some prompt_toolkit magic at work here.

Interesting! This works in ConEmu though, do you know how?

It would seem that ConEmu has shift+end (as well as home and the arrows) bound to creating a terminal-side selection by default. So essentially, by hitting those keys, you're entering an "implicit" mark mode[1], and not even allowing xonsh the opportunity to receive those keystrokes.
I don't think we've currently got a good solution for "enter mark mode (if not already in it), and move the selection marker" in the 1.15 preview.
[1]: I'm definitely bastardizing our concept of mark mode on to conemu here, for simplicity.

For future notes:

(from conemu settings)

Ah okay, so in 1.15 I would press the mark mode keybinding, then shift+end, then ctrl+c/Enter to copy and exit mark mode? If so, that's not too bad.

Ah okay, so in 1.15 I would press the mark mode keybinding, then shift+end, then ctrl+c/Enter to copy and exit mark mode? If so, that's not too bad.

That's correct!
<bookkeeping>
I'm gonna take this out of 1.15, and mark up for discussion on the shift+arrows selection. As implemented in 1.15, this is working as expected, but maybe it-could-be-better.png.

Suggestion/question: in ConEmu mark mode ctrl+c/copy keybinding copies only but Enter copies and exits mark mode. Is that how ours works?

(Moved that discussion to #13438)

Ok. Chatted about it at sync today. Here were some notes:

This is pretty similar to #11985 in that a terminal-side selection is created implicitly. There, Shift+Left can immediately enter mark mode and create a selection to the left.
Here, we're talking about Shift+End entering mark mode and creating a selection to the "end". The tricky part is that "end" is first defined as the end of the input buffer, then defined as the end of the line.
We could be smarted about cooked read and the input buffer to be able to allow functionality for that first part ("end" --> end of the input buffer). In fact, we should do that, but that's feature work we're gonna have to throw onto the backlog.
There's also a concern about creating confusion between shell-side selections and terminal-side selections. PowerShell, for example, lets you do a shell-side selection, which provides a rich experience where you can also cut text. ConEmu intelligently knows when to do that while also only doing terminal-side selections. If we don't have that intelligent functionality, it's easy for the user to be confused as to why some selections allow you to "cut" the text while others don't.
Proposed solution:

the "quick-n-easy" fix here would be that we introduce a global setting or some button in the settings UI like "experimental.implicitMarkModeActions" that would generate a number of actions that allow you to implicitly create a terminal-side selection with keybindings like Shift+Left or Shift+End.
These actions would probably be a bit ugly, but they would be a sequence of actions like "enter mark mode" --> "expand selection to the left (or end of line)"
This would create a terminal-side selection that allows you to select and copy text as allowed in mark mode, but not provide a rich experience like cutting text (which I personally think is fine, I'd bet 99% of the time you just want to copy).

For bookkeeping purposes, we're gonna merge this in with /dup #11985. Thanks for all the great discussion here!


ui-select unflags FormController's $pristine state

$watcher on $select.selected will $setViewValue() which will unflag $pristine and set $dirty, allthough it's the initial $watcher and there is no preselection.
https://github.com/angular-ui/ui-select/blob/master/src/select.js#L771
This would fix it:

scope.$watchCollection('$select.selected', function(newCol) {
            if (ngModel.$pristine && newCol.length === 0)  {
              // preserve $pristine state for empty values, don't setViewValue
            } else {
              ngModel.$setViewValue(Date.now()); //Set timestamp as a unique string to force changes
            }

+1

duplicate of #289

I don't think this is a duplicate of 289, that one has been incorporated into the latest version and I'm still seeing an issue.
If you load the 'options' or the ng-model value asynchronously the form will always be dirty:
http://plnkr.co/edit/Iv1H4T5OYkLr1uevTe6g?p=preview

There's no fixes in 289 in master yet and it's the same issue, form is always dirty

#289 was fixed via #509. This issue should be closed, too.

I have the same problem.
My form is always dirty !

For those who need a quick fix, manually put 'ng-pristine' class in the html, then when something is selected it'll go away

Closing as fixed - if this is still an issue, feel free to open a new issue with reproduction based on the latest release.

Same issue here using "ui-select": "~0.19.4"