Update VCTK dataset links and formats

Updated dataset URL's
Updated the zip file checksum
Fixed URL path parsing for the updated link
Updated audio folder and audio extension names

The last URL returned a 404 HTTP not found error as the dataset was moved to a new link.
Verified the changes by loading the dataset into dataloader and looping over every file.
Tested by training some epochs.

Hi @mthrok ! Thanks for reviewing this.
I made some changes. Hope these help.

Fixed everything. @mthrok you can squash & merge when ready.

Hi @Abhi011999
Sorry for the late reply. We were discussing internal how we should approach this problem.
We decided to keep the original VCTK as is (but raise an error when download=True with the message to use a new version.), then add the new version, (say VCTK_V2).
Could you move your changes to VCTK_V2? You can either copy-paste the original VCTK or subclass VCTK (if that works and is simpler)

@mthrok An optional boolean argument can be added in the existing VCTK class that identifies the old and the new dataset with the default value set to False. That can work?

@mthrok An optional boolean argument can be added in the existing VCTK class that identifies the old and the new dataset with the default value set to False. That can work?

It would, but we do not know if there will be another dataset change like this (though chances are small),
and boolean is not future proof.
Also, the previous version is now generally inaccessible, yet downloading the new one takes a bit time.
So rather than mixing the code for dataset that are only useful for those who has cached data and the code
that general public can use, we concluded it's cleaner to separate them.
Maybe we should call the new dataset VCTK_092.

@mthrok An optional boolean argument can be added in the existing VCTK class that identifies the old and the new dataset with the default value set to False. That can work?

It would, but we do not know if there will be another dataset change like this (though chances are small),
and boolean is not future proof.
Also, the previous version is now generally inaccessible, yet downloading the new one takes a bit time.
So rather than mixing the code for dataset that are only useful for those who has cached data and the code
that general public can use, we concluded it's cleaner to separate them.
Maybe we should call the new dataset VCTK_092.

That'll work! I will get to work now. 👍

@mthrok So the extra comments are not necessary or should I just leave them?

@mthrok So the extra comments are not necessary or should I just leave them?

Which one do you mean by "the extra comments" ??
Also, can you put the new class VCTK_092 into the same module, vctk.py?
That way, you do not need to duplicate load_vctk_item function, right?

Also I am seeing CI job errors that should have been resolved by https://github.com/pytorch/audio/pull/850, can you rebase your work?

That way, you do not need to duplicate load_vctk_item function, right?

No, some lines are different for the new version.

Which one do you mean by "the extra comments" ??

I mean the comments I put when I made changes to the original vctk.py.

can you rebase your work?

will do, just want a final confirmation.

That way, you do not need to duplicate load_vctk_item function, right?

No, some lines are different for the new version.

I see. In that case, could you make it to a method?
That way it's easier to allow users to customize the loading behavior if necessary.

Which one do you mean by "the extra comments" ??

I mean the comments I put when I made changes to the original vctk.py.

I can no longer see the original commit. Could you describe it?
Also can you put the new class in the same vctk.py module?
I think adding a new submodule for a new version of existing dataset might get
unmanageable at some point if there are many updates.
Once mode thing, can you change the original VCTK class so that it will raise
an error if download=True with an error message that explains the dataset is
no longer available and users should use the new class you are adding.

I am a little out of knowledge here but why are the tests failing exactly?

I am a little out of knowledge here but why are the tests failing exactly?
EDIT: Is my branch patch-1 in conflict here?

It's not conflict but there was a breaking change in PyTorch core and we added the change for that in #850 .
I see that your branch is based off of #00cc000, which does not have this fix. So if you fetch the latest master branch of pytorch/audio and rebase your changes on it, then the tests should pass.

I see random tests failing and passing. Seems like I have to pass the "torch" to you now @mthrok 👀

I see random tests failing and passing. Seems like I have to pass the "torch" to you now @mthrok 👀

lol nice one. Yeah, unfortunately we are hit by another upstream issue. https://github.com/pytorch/pytorch/pull/43050
CI should be working fine tomorrow.
Meanwhile there are couple of improvements on the current code base. If you have time, could you give some thoughts? This will make the implementation of VCTK_092 much better.

Making load_vctk_092_item function into a method of VCTK_092.
Putting load_vctk_092_item as a plain function makes it difficult to customize the behavior on user code. If a user wants to change a bit of behavior, the user has to re-write the whole class.

Make the return value typed.
In general, when returning multiple objects from a function, it a good idea to introduce micro protocol with namedtuple. This way the access to the individual item gets cleaner and it becomes future-prof (adding a new item to be returned is backward compatible.) Check out my example here.

Wrap torchaudio.load as another method of VCTK_092.
Similar to 1, this will allow user to customize the loading behavior, like disabling normalization or swapping channels. See example here

Get rid of walk_files function.
Once the root directory is located, we have the idea of expected directory structure, so there is no need to traverse directories as if it's unknown. walk_files function can do harm by traversing unrelated directories, but it does not bring any benefit.
speaker_ids = sorted(d for d in os.listdir(txt_dir) if os.path.isdir(os.path.join(txt_dir, d)))
for speaker_id in speaker_ids:
    utterance_dir = os.path.join(txt_dir, speaker_id)
    speech_dir = os.path.join(audio_dir, speaker_id)
    for utterance_file in sorted(f for f in os.listdir(utterance_dir) if f.endswith("txt")):
        utterance_id = os.path.splitext(utterance_file)[0]
        utterance_path = os.path.join(utterance_dir, utterance_id)
        audio_path = os.path.join(audio_dir, f'{utterance_id}_{mic_id}.{self.audio_ext}'

This way, you do not need attributes like _except_folder. and the directory traversal is minimum.

@mthrok
So I created a test script for the new implementation based on your above approach without walk_files and guess what?
Half of the mic1 audio files have been removed from p362, but there occurrence is present in the txt folder. Below is the full list with IDs -
https://pastebin.com/p02Fyby7
My take here is that after the total path is calculated of every possible audio file, it performs a validation check if the file exists or not using os.path.exists method and then add it to a list.
What do you think?
Note - Everything else has been taken care of, only this remains.

@mthrok
So I created a test script for the new implementation based on your above approach without walk_files and guess what?
Half of the mic1 audio files have been removed from p362, but there occurrence is present in the txt folder. Below is the full list with IDs -
https://pastebin.com/p02Fyby7
This is not even mentioned in the logs.
My take here is that after the total path is calculated of every possible audio file, it performs a validation check if the file exists or not using os.path.exists method and then add it to a list.
What do you think?
Note - Everything else has been taken care of, only this remains.

Hi @Abhi011999
That's an interesting finding, and thanks for reporting. I think agree with your approach. We can skip if the corresponding audio file for a given text is not present. There is nothing much we can do about the missing files, but maybe it's a good idea to add a note about it in the docstring.

Hi, @mthrok. As I have updated with the required changes, I also made some performance comparisons with and without the walk_files implementation and here are some insights -

With walk_files

__init__() takes 0.5 seconds approx. to walk over files.
Retrieving one sample takes about 0.05 seconds approx.
Iterating over the entire dataset takes about 18 min 26 secs.
It can wrongly walk over any file in any nested directory with the same extensions.
We need to explicitly specify which folders or files to omit.

Without walk_files

__init__() takes 7 seconds approx. to walk over files.
Retrieving one sample takes about 0.048 seconds approx.
Iterating over the entire dataset takes about 18 min 26 secs.
This implementation is future proof for additional upcoming updates.

The conclusion that we can draw from the above stats is that we can keep the new implementation without walk_files as its future proof and further relevant changes can be made easily in accordance with the upcoming updates for the dataset.
That's my take. Would love to hear what you think.

Hi, @mthrok. As I have updated with the required changes, I also made some performance comparisons with and without the walk_files implementation and here are some insights -

With walk_files

__init__() takes 0.5 seconds approx. to walk over files.
Retrieving one sample takes about 0.05 seconds approx.
Iterating over the entire dataset takes about 18 min 26 secs.
It can wrongly walk over any file in any nested directory with the same extensions.
We need to explicitly specify which folders or files to omit.

Without walk_files

__init__() takes 7 seconds approx. to walk over files.
Retrieving one sample takes about 0.048 seconds approx.
Iterating over the entire dataset takes about 18 min 26 secs.
This implementation is future proof for additional upcoming updates.

The conclusion that we can draw from the above stats is that we can keep the new implementation without walk_files as its future proof and further relevant changes can be made easily in accordance with the upcoming updates for the dataset.
That's my take. Would love to hear what you think.

Thanks for doing the benchmark. The only concern of the new implementation is

__init__() takes 7 seconds approx. to walk over files.

I bet this is coming from the os.path.exists calls. We can employ our knowledges of the dataset to reduce this. We know two facts;

p315 is missing all the transcripts.
p362 is missing a bunch of audio files.

I previously suggested to look at transcript directory because transcripts are common to microphone ID, but this ended up force us to check the existing of audio files in p362.

Opposite way is to look at audio directories (except p315) first, build the corresponding transcript path, because that way we know that as long as audio file is found, the corresponding transcript exist so we do not need to perform file existence check.
Since p362 is the only speaker without speech files, we can perform the file existence check only on this directory. We know that all the other speakers/utterance combinations have valid mapping from transcript to audios, so we do not need to perform file existence check on them.

I would push for 2. because that way changes from the current implementation is smaller and also treating exceptional directory as exception (i.e. if speaker_id == "p362":...) will make the code express the logic we are designing better.
What do you think?

I think it will work, I will do the suggested changes, run the benchmark, and then push.

Hi, @mthrok.
mic_id optional param is added with the default value of mic2 as its the new and better microphone.
Performance is good now -
__init__() takes 0.33 seconds approx now for both mic2 and mic1.
I think this can't get any more straight forward than this. Let me know what you think.

Hi, @mthrok.
mic_id optional param is added with the default value of mic2 as its the new and better microphone.
Performance is good now -
__init__() takes 0.33 seconds approx now for both mic2 and mic1.
Also mic2 audio files are missing in p280 so added an exception for that too.
I think this can't get any more straight forward than this. Let me know what you think.

Hi @Abhi011999
Thanks for sticking with all the review process and prompt replies. Now the code is in super good shape, and I really enjoy working with you.
The current code is really great. I responded to your comments. Let me know what you think, (and also let me know if you cannot spend any more time on this. I understand you have your thing too, and I will wrap it up in that case.)

Thanks for sticking with all the review process and prompt replies.

My pleasure.

I really enjoy working with you.

It was really nice learning things from you.

Let me know what you think, (and also let me know if you cannot spend any more time on this. I understand you have your thing too, and I will wrap it up in that case.)

I have to say that this is the first time I am working so in-depth with a PR and a reviewer. It's an awesome experience learning from the community and simultaneously trying to improve it. In the future, I am looking forward to donating more of my time to this awesome repository.

EDIT: I also see you are formatting all the code with black as in #854, should I format it that way or leave it?

If you can only apply to the new class (VCTK_092) and leave the VCTK class as-is, then that will be nice.

Oh I forgot to mention but you may want to add the new class to https://github.com/pytorch/audio/blob/master/docs/source/datasets.rst


Change available fields when editing a default role in the UI

Description
This PR addresses the problem of not being possible to edit the Public property of a default role through the UI, since it sets the other fields as parameters of the API call and results in a Default roles cannot be updated (with the exception of making it private/public). error.
It solves this by simply limiting the available fields for default roles, since they are not possible to be edited in the first place and should not show up anyway. It does not change the window for non-default roles.
Types of changes

[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] New feature (non-breaking change which adds functionality)
[X] Bug fix (non-breaking change which fixes an issue)
[ ] Enhancement (improves an existing feature and functionality)
[ ] Cleanup (Code refactoring and cleanup, that may add test cases)
[ ] build/CI

Feature/Enhancement Scale or Bug Severity
Bug Severity

[ ] BLOCKER
[ ] Critical
[ ] Major
[X] Minor
[ ] Trivial

Screenshots (if appropriate):
How Has This Been Tested?
In the User default role, I verified that only the Public field showed up. I unchecked it and verified ispublic became false.
I created a new role. In its editing window, I verified all the original fields were there (Name, Description, Type and Public). I changed the fields and verified they took place.

@blueorangutan ui

@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

UI build: :heavy_check_mark:
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/8322 (QA-JID-241)

@gpordeus when pressing edit for a default role no dialog appears, and when I create a new role:

@gpordeus when pressing edit for a default role no dialog appears, and when I create a new role:

@DaanHoogland I believe this is due to the version being used. The ispublic param is only available in 4.19, while the community's QA lab is on 4.18.

@blueorangutan package

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Packaging result [SF]: ✔ el7 ✔ el8 ✔ el9 ✔ debian ✔ suse15. SL-JID 7963

checked in a lab env: lgtm


[spaceship] show proper 401 error message for Spaceship::ConnectAPI

Motivation and Context
Fixes #17334
Description
It turns out that Spaceship::Client was eating the 401 error that Spaceship::ConnectAPI::APIClient would normally output in a nice way. Moved the 401 handling to its own method in Spaceship::Client that is now overridden in APIClient and just does nothing with it so that handle_errors handles it like every other Connect API error 😊
Spaceship::UnexpectedResponse: [!] Authentication credentials are missing or invalid. - Provide a properly configured and signed bearer token,
 and make sure that it has not expired. Learn more about Generating Tokens for API Requests https://developer.apple.com/go/?id=api-generating-
tokens

@snatchev @rogerluan Reworked this! I think this makes so much more sense 😊


Ariel does not install--unregistered developer

Cannot install the developer unregistered error message is given. Latest Safari and system from Apple.

You have to manually allow the installation. Go to the Security & Privacy section in System Preferences and click the "Open Anyway" button and provide admin credentials.
A faster (but less explicit and informative) way avoid this warning is to contol+click on the Aerial.saver file and click "Open" in the context menu. See this support document https://support.apple.com/kb/PH21769?locale=en_US for more information.

Excellent answer. It works as advertised using the methods suggested trustypelletgun.

I have signed a release: https://github.com/fwartner/Aerial/releases/tag/v1.1%40signed

Closing as duplicate of #10


documents: Allow for SQLLite WASM backend

Problem
Currently you run into RAM usage problem when having many documents because the document store index is in memory. Additionally, the query performance is very bad if there are many documents
Solution
Use SQLLite WASM as an alternative backend together with OPFS storage
TODO

Make abstraction around index search engine
Implement a SQLLite WASM engine for this engine abstraction

#274

Blocked by https://github.com/sqlite/sqlite-wasm/pull/48

Way forward
For browsers: wa-sqlite
For node native: sqlite3


Error on build.

Reproduce:

Start a project with react-native init.
yarn add react-native-view-overflow
react-native link react-native-view-overflow

FAILURE: Build failed with an exception.

* Where:
Build file '/Users/Andrei/Documents/lattice/lattice/apps/jakiro/node_modules/react-native-view-overflow/android/build.gradle' line: 5

* What went wrong:
A problem occurred evaluating project ':react-native-view-overflow'.
> Could not find method google() for arguments [] on repository container.

It ran well after I downgraded the package to use version 2 of gradle.

please upgrade to gradle 3
we should improve docs to show required steps


Update Storage version for beta release

This is still pending seeing integration tests pass on internal CI.
The release date in the history is set to Monday to avoid releasing on a
Friday/weekend.
Currently only a beta release as customer-managed encryption keys
are in beta.

(Will merge on Monday, then do the release.)


Added a unit test for the hello world notebook.

Using the module 'testbook'
Currently only testing the result's accuracy
TODO: Added more tests

I've used an external module that I found: 'testbook' for testing jupyter notebooks. On the LSF with my conda env it works good.
The test is failing on the remote because the kernel 'python3' is missing.
While looking for a solution I've encounter this one. Is this relevant?
Another option for unit testing the notebook is to run it as a script. But I think the method in the PR is much cleaner and will be useful for further notebooks.
I would like to hear your thoughts please @mosheraboh


jsx-alignment: Option to allow / disallow newline before closing html bracket

Current behavior with this rule:
//      vvvvvvv Error, because there needs to be a newline
<Button primary
        raised
        ripple
        type={"submit"}
        style={{ margin: "1rem" }}/>
//                                ^ Error, because there is no new line

Proposed options:
"jsx-alignment": ["no-newline-before-closing-bracket", "no-newline-before-props"]

to disallow newlines respectively.

Closing due to the deprecation timeline and maintenance burden of formatting rules, see #210


Discuss dosimeter handling

We should discuss if there are any special requirements for dealing with the dosimeter, e.g. should we store its state somehow?

Discussed on slack https://tuwienspaceteam.slack.com/archives/G018V61QDFU/p1699183536320209?thread_ts=1699181708.367959&cid=G018V61QDFU


More debug info?

In the issue template you have this:
If the error occurs repeatedly, please consider adding this to the publish action, to collect more information on the issue:

```yaml
with:
  root_log_level: DEBUG
  log_level: DEBUG
```

Would adding this link give you additional context:
https://docs.github.com/en/actions/monitoring-and-troubleshooting-workflows/enabling-debug-logging
You can find an example here: https://github.com/EnricoMi/publish-unit-test-result-action/issues/239
Also notice the warning for the DEBUG keys, is that normal?

That is interesting, thanks for sharing. This provides debug information from the GitHub Actions runner itself.
You probably refer to this warning:
Unit Test Results (reference)
Unexpected input(s) 'log_level', valid inputs are ...

This is because the log level arguments are not documented. So that is fine.


[ISSUE #4891] <Add a locking mechanism to solve the problem of repeatedly inserting swagger apidoc&modify the swagger example.>

#4891

Make sure that:

[x] You have read the contribution guidelines.
[ ] You submit test cases (unit or integration tests) that back your changes.
[x] Your local test passed ./mvnw clean install -Dmaven.javadoc.skip=true.

Codecov Report

Merging #4892 (c6e2545) into master (a6e150b) will decrease coverage by 0.23%.
The diff coverage is 12.28%.

:exclamation: Current head c6e2545 differs from pull request most recent head 1b6c1dc. Consider uploading reports for the commit 1b6c1dc to get more accurate results

@@             Coverage Diff              @@
##             master    #4892      +/-   ##
============================================
- Coverage     64.25%   64.02%   -0.23%
+ Complexity     8233     8218      -15
============================================
  Files          1167     1167
  Lines         34330    34359      +29
  Branches       3083     3079       -4
============================================
- Hits          22059    21999      -60
- Misses        10512    10593      +81
- Partials       1759     1767       +8

Impacted Files
Coverage Δ

...va/org/apache/shenyu/admin/model/entity/TagDO.java
67.05% <0.00%> (-2.46%)
:arrow_down:

...ervice/manager/impl/RegisterApiDocServiceImpl.java
4.76% <0.00%> (+0.11%)
:arrow_up:

...ervice/manager/impl/PullSwaggerDocServiceImpl.java
9.52% <2.56%> (-5.19%)
:arrow_down:

...n/java/org/apache/shenyu/admin/model/vo/TagVO.java
80.95% <33.33%> (-3.67%)
:arrow_down:

...ache/shenyu/admin/service/impl/TagServiceImpl.java
61.00% <42.85%> (-1.37%)
:arrow_down:

.../service/manager/impl/LoadServiceDocEntryImpl.java
69.00% <50.00%> (ø)

... and 21 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


[Tracking] Persistence doc (D2.3)

really needed? classified as "Other", so we might get away w/ just delivering the software w/o an accompanying report?

We need to define:

How many database the KITT4SME platform is going to have?
Which are those going to be?
How will be integrated?
Their schemas
Who will access to them and why

agree!

Partner
System
Database type (NoSQL or Relational)
Database engine
Schema

Holonix
Worker profiler
NoSQL
MongoDb
TBD

Holonix
Production profiler
NoSQL
MongoDb
TBD

SUPSI
FaMS/IM
TBD
TBD
TBD

ROVI
VIQE
TBD
TBD
TBD

GINGKO
TBD
TBD
TBD
TBD

R2M
AIQuS
TBD
TBD
TBD

to be shared w/ reviewers
to be uploaded to SUSPI sharepoint (preview, not reviewed yet)

Issue sent to Zeki for QA

added some clarifications about ngsi persistence as requested by QA: #120


added validation and functionality to contact page

Issue #320
added validation and functionality to contact page - Added validation and improved functionality to the contact page, ensuring that all required fields are properly validated before form submission. This update enhances the user experience by providing real-time feedback and ensuring data integrity with proper display of confirmation message.
working demo :
Uploading WhatsApp Video 2024-10-13 at 16.57.44_90f9b37e.mp4…
Type of PR

Add X in the box to specify the improvement type.
[X] Bug fix
[ ] Feature enhancement
[ ] Documentation update
[ ] Other (specify): ___________

Description
This pull request aims to [briefly describe what the pull request does, e.g., "add a new feature," "fix a bug," "improve documentation," etc.].
Screenshots / Videos (if applicable)
Before:

[Describe the state before the changes, e.g., "The section headings in the footer were misaligned, leading to an inconsistent and cluttered appearance."]

After:

[Describe the state after the changes, e.g., "The section headings in the footer are now properly aligned, providing a clean and professional look."]

Checklist

Add X in the box to specify.
[X] I have performed a self-review of my code.
[x] I have tested the changes thoroughly before submitting this pull request.
[x] I have provided relevant issue numbers, screenshots, and videos after making the changes.
[x] I have commented my code, particularly in hard-to-understand areas.

Additional Context
[Provide any additional context about the changes, such as specific challenges you faced or decisions you made. This can help reviewers understand the rationale behind your changes.]
Thank you for reviewing my pull request!

@swaraj-das please review this pr and merge it

@swaraj-das done

@mastansayyad please have a look into it as well it's been 2 weeks but my pr is not yet merged


Add Kubeadm to topology manager

Allows:

create a kubeadm cluster
get information to join a kubeadm cluster

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

23 of 48 (47.92%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.05%) to 65.164%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

deploy/deploy.go
0
2
0.0%

controller/server/main.go
23
46
50.0%

Totals

Change from base Build<PHONE_NUMBER>:
-0.05%

Covered Lines:
4598

Relevant Lines:
7056

💛  - Coveralls


test+ops: autogenerate a pgbadger report during integration test runs

this will make it easier and faster to monitor and analyze our performance situation in the database. we should also consider making a simple performance test suite (especially for formList, submission, and CSV/OData exports) that we can track over time as we complexify the system.

i want to get this in soonish, possibly even before 0.6 launch. if anybody is dropping in and wants further information, drop me a line and i'll add whatever else i might know.

hey @NizamLZ, thanks for your contributions so far! this might be an interesting one to pick up if you are looking for more. or maybe #222 if you'd rather work on the server itself rather than infrastructure.
the general idea is to somehow hook pgbadger up to the circle ci postgres cluster so that it logs and analyzes our queries over the course of the test run. then the artifacts it generates can be surfaced from circle ci. once we have this we could also think about creating a separate performance/stress test suite that really takes advantage of having these figures, so we know we aren't regressing on perf.

making a simple performance test suite (especially for formList, submission, and CSV/OData exports) that we can track over time as we complexify the system.

We're now considering this the primary goal.
After taking an initial look at pgbadger reports from runs of the existing (non-perf-specific) tests and from production, we've decided to de-prioritize automated pgbadger reports and focus on defining some tasks related to the performance targets described above without a particular focus on db queries (initially).
Examples:

deno runtime metrics
Enketo performance monitoring

There may be some ideas from informal benchmarking we did in 2021 and 2018

Progress on this issue: #612


HDDS-11032. Decommissioned datanodes shows up again after removing in Recon Datanodes page.

What changes were proposed in this pull request?
This PR is to stop showing Decommissioned datanodes again on Recon Datanodes page after removing them explicitly.
Ozone Recon - Decommissioned datanodes shows up again after removing in Recon Datanodes page.
As part of HDDS-10409
Recon was allowing to remove the Decommissioned datanodes and was removing from Recon rocksDB nodes table, however Decommissioned datanodes continue to send heartbeats till they are being shutdown, so they get registered and added again in Recon memory map which makes them show up again in datanodes UI.
Solution is to allow only DEAD datanodes to be removed and skip other node status or node operational status datanodes.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-11032
How was this patch tested?
This patch was tested by updating the existing integration test to make sure that only DEAD datanodes are being allowed to remove.

@sumitagrawl @ArafatKhan2198 Pls review.

Thanks for the fix, @devmadhuu! The changes in the PR look good! LGTM +1 Should we also update the UI to indicate that only dead nodes are allowed to be removed?

Yes, we have UI PR which has changes to allow only those node having DEAD node status .

Thanks for the patch @devmadhuu and @sumitagrawl for the review!


libsoup v3.0.7

Checklist

[x] Used a personal fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[x] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

No Windows builds 😢 , as there is no such build available of the libnghttp2 dependency...

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.


Removal of Komoverse Token PR #24551

I'm submitting a ...
[ ] bug report
[x] feature request
[ ] question about the decisions made in the repository
[ ] question about how to use this project

Summary
I want to remove KOMO (Komoverse) original commit by @topcoder1208 because we want to change contract address, logo, and original commit to me

Other information (e.g. detailed explanation, stack traces, related issues, suggestions how to fix, links for us to have context, eg. StackOverflow, personal fork, etc.)
Removal pull request #24551
Original addition commit pull request #20449

I agree about this comment.

Kindly open this live chat to talk to the customer service directly on your issue https://direct.lc.chat/13898481/


Editor Custom Labels: Support negative indices to access start of the file path

Currently, the editor does not support customizing file labels in a way that would allow filenames to be prefixed with the name of the application or folder from the start of the path. This limitation affects projects structured in a monorepo setup, particularly when files are deeply nested within application-specific directories.
Supporting negative indices for ${dirname(N)} could solve this problem. This would enable accessing folder names starting from the beginning of the path. Implementing negative indices would cater to the needs of projects with files at various nesting levels within their structure.

Is the reasoning not the other way round or am I misunderstanding how it currently works? E.g. I'd like to access last 2 parts of the path, but the description of the settings suggests that only the single final and the starting folders can be accessed.

Here is an example of the mono repo: https://github.com/vuejs/core/tree/main/packages
It has a root and multiple subprojects in the packages folder. It is common to make changes in multiple "packages" at once, and it would be convenient if we could identify files by the ${dirname(-2}.
Example:

packages/runtime-core/src/helpers/resolveAssets.ts -> resolveAssets.ts (runtime-core)

Verification steps:

Create a custom editor label. The template should include ${dirname(N)}, for which N is a negative number.

For example, add in workbench.editor.customLabels.patterns, item: ** value: ${dirname(-1)}/${filename}

Open a file which matches the pattern specified in step 1.

In the case of the example, every file matches the pattern

The editor tab should have set the correct folder name for ${dirname(N)}. Here an explanation on how negative indices work: https://github.com/microsoft/vscode/issues/209619#issuecomment-2041401798

In the case of the example, the name of the editor in the tab should start with the top level folder the file is located in


Add FAQ about chat history and albums

Those are probably two of the most frequently asked questions, so it is well deserved to have them in the list of FAQ.

It seems like SSH signing is not really working, the key is clearly there. I'll try to fix this.

I'm using SSH signing, and it works fine for me.

I'm using SSH signing, and it works fine for me.

I can verify my commits locally with git, and I have uploaded the public SSH key to GH … what am I missing?

I fixed it! Thanks go to @wojpawlik

@KnorpelSenf Feel free to add the "ready for translation" label after ignoring or applying the last suggestion from me.

Done

@dzikrl btw, I checked out https://pasti.kemdikbud.go.id/, and it says the term 'frequently asked questions (FAQ)' is translated as 'soal sering ditanya (SSD)'. But that term isn't familiar to me. What do you think?

@quadratz Should we add ID label?

Not yet. Feel free to add them and resolve the pending review if there is no answer from @dzikrl in the next 3 days.

Edit : I think "Pertanyaan Umum" != "Pertanyaan yang Sering Diajukan".

Yes. They are different things.
Since "SSD" is not commonly used, we will leave them as "FAQ" for now. If we want to change them for real, we should make separate PQ since it's now out of topic.


python311Packages.cot: skip failing tests

python311Packages.cot: skip failing tests
This package has shown as broken in downstream builds of SDL2_image.

I'm skipping the 3 specific unit tests that are failing.

@ofborg eval

Thanks!


[RFC] Asyncio Support

This is a proposal to fix #2 in Approach 2, with patching code to achieve context copying on task creation, please see separate commits in this PR. Regarding context copying/inheriting:

After importing contextvars with this PR, all create_task() calls of event loops which went through either asyncio.get_event_loop(), asyncio.new_event_loop() or asyncio.set_event_loop() would implicitly do an extra context copy, and use it as task context.
Current PR requires less user code. User just needs to import contextvars before initializing event loop policies or creating event loops, and all tasks created by automatically patched loops could inherit the context on creation.
But get_event_loop_policy() shall no longer return the policy passed to set_event_loop_policy() with this PR - a wrapper policy is returned. Although the wrapper works in the same way as the original policy, get_event_loop_policy().policy should be used if original policy instance is required.

Other than patching, it is also possible to use get_task_factory() and set_task_factory() to achieve the same result, as demonstrated here. Pros and cons:

User needs to explicitly call enable_inherit(loop) for any loop in use.
But forgetting to do so will end up with tasks behaving differently.
However this approach doesn't patch anything, so APIs are untouched.

At last, the reason for using Approach 2 of #2 is:

I didn't want Approach 1 to copy lots of asyncio code from Python 3.7 into this package. But I'm still open to that, please advise.
Tried an Approach 3 but failed. (Created a wrapper event loop providing the new APIs, but the loop relationship is a mess - the underlying loop creates a Future whose _loop is underlying loop, but when using the wrapper loop to e.g. gather() it checks future._loop is loop and fails. Or vise versa. Also Task code needs to be backported anyway.)
Couldn't find a new Approach 4.

UPDATE: This is now under testing in practice as aiocontextvars 0.2 in GINO and possibly some other projects.

Checking in on this.  Would be useful to use this in an large open source project supporting AWS runtimes.

Wouldn't that be awesome?  Python 3.6.2+ still in use in our user base.. thanks.
If anything we can vendor this in as needed.  Thanks!

Ouch, sorry to hear that. Unfortunately I don't think this PR will go any further, projects on 3.6 would have to hammer in similar hacks by themselves I'm afraid.


/tmp too small, export TMP=bigger doesn't work

Hi,
I have a /tmp directory that is to small to allow to install git.
I have the impression taht setting an environment variable TMP or TMPDIR could help.  I am doing a / install.
Do I have to reinstall meta or some other stuff after settp TMP

You should be able to set TMPDIR or TMP before running any of the zopen commands and for functions that require a temporary location it should use that.
It would be useful to see what happened when you did try the install though to see if things fell over gracefully! Did it report any errors, fail to work, ...?

I tried to set TMP etc, did not work. I switched back tp /usr/local/zopen. Needed git, that was the only package that signaled file system full when copying some stuff to /./tmp


Bug Report - Process does not die when multiple tabs are open and the close button is pressed.

Other
This bug seems to be tied to yarn or react-scripts.  I ran a python interpreter in one tab, opened another tab and then closed my terminal. Everything worked as expected. It maybe a bug in yarn or react-scripts, but I am fairly confident that it is not due to step 4. in steps to reproduce. The fact that you have to be out of the tab running the long running process in order to trigger the bug implies to me that this is an issue with terminal.
Environment
Windows build number: 10.0.18362.0 Microsoft Windows NT 10.0.18362.0
Windows Terminal version (if applicable): 0.4.2382

Yarn: 1.17.3
react-scripts: 3.0.1

Steps to reproduce

Open a terminal

Run yarn start on a CRA Project.

Open a new tab

Navigate to the new tab (this is a requirement)

Click the close button.
Wonder why the terminal is still running

Expected behavior
No matter the amount of open tabs and long running processes, clicking close should kill all running processes in all tabs.

Actual behavior
When a user opens a tab and runs a long running process in it, then opens another tab and then finally closes the terminal, the terminal should kill all running processes.
In my instance I run yarn start with my CRA project in one tab and use the other tab for testing and running git commands. When I click the close button, the terminal does not kill all processes.

/dup #2185


Fix SANs list

Issue

Jira issue: DPE-844
The k8s services that are created by the charm to redirect traffic to the primary and the replicas were not part of the certificate signing request sent to the TLS certificates operator.
With that, in the first test run on a fresh microk8s installation the charm got stuck trying to call the Patroni REST API without success, as the hostname doesn’t match with the ones from the certificate. This was not happening in other test runs, but could happen in other situations. to the charm sending a certificate signing request (CSR) with it's IP address as a DNS name instead of an IP address.

Solution

Update the code to add those services in the certificate signing request.

Context

You can FOCUS on the following files when reviewing:

lib/charms/postgresql_k8s/v0/postgresql_tls.py: it contains the fix for the IP address issue in the VM charm and also a way to provide additional DNS names for the certificate signing request.

src/charm.py: it sends the k8s service names to the PostgreSQL TLS library.

Other files and what has changed on them:

lib/charms/tls_certificates_interface/v1/tls_certificates.py: this is a patched version of the library that is used to solve the IP address issue. It was copied from https://github.com/canonical/opensearch-operator/blob/main/lib/charms/tls_certificates_interface/v1/tls_certificates.py (that patch will be pushed to the right repo in some weeks). Thanks @Mehdi-Bendriss!

tox.ini: the version of the Juju Python library was pinned due to ImportError: No supported version for facade: ModelConfigFacade errors when deploying the charm.

In a future PR those k8s services probably should be replaced by the pods endpoints.

Testing

It's very complicated to add a test to prevent this issue again in this repo because it happens (at least is what we could check) only with charm coming from Charmhub (we imagine that it's because they take some time to be downloaded to the model, so the events from it and the TLS certificates operator take a different order in the first deployment, but in the second and in the later deployment the charm is already there, so the order is different).
The test that will check the issue is fixed is the one from https://github.com/canonical/postgresql-k8s-bundle/blob/6444a12423eacf45447debe82e2ab9c1f443c98a/tests/integration/bundle/test_tls_bundle.py (it fails every time on Giithub because every CI run uses a fresh microk8s installation).
This fix was manually tested by publishing it in a different channel of Charmhub and using it to run the above test.

Release Notes

Add the k8s services as DNS names on the certificate signing request.
Update the PostgreSQL k8s library to handle this situation and also IP address issues in the VM charm.

Thanks for the reviews, @MiaAltieri, @WRFitch and @Mehdi-Bendriss!


spin: 6.4.6 -> 6.4.7

Motivation for this change
Update the package.
cc maintainer @pSub
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] Linux

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

I'm not very sure if spinroot.com still have DDoS protection that blocks curl. However, I can successfully build this package on my computer, so maybe they do not block curl anymore?

HTTP response headers of e.g. http://spinroot.com/spin/Src/ contain Server: cloudflare-nginx and Cf-Ray: 39d665b9543542b5-OSL, so it is served by CloudFlare. Certainly they do not block curl because it's curl, but they occasionally replace real contain with a captcha page (especially when requesting IP address is associated with automatic high volume activity), and this blocks curl.

@orivej thank you for pointing that out.
To be honest, after some research I still have no idea how to get the dropbox raw download link... If someone know how to get the correct link, please tell me or make another commit to fix the url. I would be very thankful.


layer.toml file(s) is(are) gone

Issue
The toml file created using the following echo command executed within the ./buildpacks/maven/bin/build bash file:
echo -e 'launch = true' > $LAYERS_DIR/2-app.toml
don't appear within the built container image:
ls -la /layers/dev.snowdrop.buildpacks.buildpack/2-app/
total 18556
drwxr-xr-x 2 jboss jboss     4096 Jan  1  1980 .
drwxr-xr-x 1 jboss jboss     4096 Jan  1  1980 ..
-rw-r--r-- 1 jboss jboss 18991497 Jan  1  1980 getting-started-0.0.1-SNAPSHOT.jar
12:43

Questions:

Is it an issue with the echo command ?
Where can we find more information about how to design and work with layers as documentation is a bit poor https://buildpacks.io/docs/reference/spec/buildpack-api/#layers ?

I'm not sure the layer tomls are supposed to survive to the final image, they are instructions to buildpack to tell it what to do with the associated directory. If the layer dir itself survives appropriately, it met it's purpose.
Do you have more specific questions re layers that the docs don't answer?

I'm not sure the layer tomls are supposed to survive to the final image, they are instructions to buildpack to tell it what to do with the associated directory

hmhm. If such a file do not survive, what is then the purpose of such a code to check using the tom file if JDK has been installed: https://github.com/buildpacks/samples/blob/main/buildpacks/java-maven/bin/build#L32-L35 ?

Umm.. isn't jdk.toml a file inside a layer ?
/layers (the layers dir for all layers)
/layers/samples_java-maven (the 'samples_java-maven' layer)
/layers/samples_java-maven.toml (the toml that would control the purpose the 'samples_java-maven' dir is used for)
/layers/samples_java-maven/jdk (a dir called jdk inside the layer dir with no special meaning)
/layers/samples_java-maven/jdk.toml (a file inside the layer that happens to be in toml format)

Ahh.. see this is why I shouldn't be doing this stuff atm =) I was incorrect before.
/layers (the layers dir for all layers)
/layers/samples_java-maven (the dir holding layers contributed by the buildpack 'samples_java-maven' )
/layers/samples_java-maven/jdk (a layer contributed by the buildpack 'samples_java-maven')
/layers/samples_java-maven/jdk.toml (the toml file controlling usage of the jdk layer)

Maybe the layer tomls are stored in different dir.. use dive & look at the image to see what was contributed as part of each docker-layer, and that should help.

The layer tomls are ephemeral and not stored in the output image as a layer. They are instead stored in a label and restored during the analysis phase (before the layers are restored). The label is io.buildpacks.lifecycle.metadata

Bingo :-)
"Labels": {
                "io.buildpacks.build.metadata": "{\"bom\":[{\"name\":\"jdk\",\"metadata\":null,\"buildpack\":{\"id\":\"samples/java-maven\",\"version\":\"0.0.1\"}}],\"buildpacks\":[{\"homepage\":\"https://github.com/buildpacks/samples/tree/main/buildpacks/java-maven\",\"id\":\"samples/java-maven\",\"version\":\"0.0.1\"}],\"launcher\":{\"version\":\"0.11.3\",\"source\":{\"git\":{\"repository\":\"github.com/buildpacks/lifecycle\",\"commit\":\"aa4bbac\"}}},\"processes\":[{\"type\":\"web\",\"command\":\"java -jar target/sample-0.0.1-SNAPSHOT.jar\",\"args\":null,\"direct\":false,\"buildpackID\":\"samples/java-maven\"}]}",
                "io.buildpacks.lifecycle.metadata": "{\"app\":[{\"sha\":\"sha256:cd9a34071b217b145f3d464e019f630616da48287f0dbc51f8b0562aff767c3e\"}],\"buildpacks\":[{\"key\":\"samples/java-maven\",\"version\":\"0.0.1\",
\"layers\":
{\"jdk\":
{\"sha\":\"sha256:0d6a777b86fc73ec8ff3726be6a5811e2b5bb8b28039ff37c97e787aa5495dbe\",\"data\":
{\"url\":\"https://cdn.azul.com/zulu/bin/zulu<IP_ADDRESS>-ca-jdk8.0.222-linux_musl_x64.tar.gz\",
\"version\":\"1.8.0_222\"},
\"build\":true,\"launch\":true,\"cache\":true},

\"maven\":
{\"sha\":\"sha256:d86ab4e5b845aa938295935f424aec27600015d1d2c98be9364bc2fd5ae02217\",\"data\":
{\"url\":\"https://apache.org/dist/maven/maven-3/3.5.4/binaries/apache-maven-3.5.4-bin.tar.gz\",
\"version\":\"3.5.4\"},
\"build\":true,\"launch\":true,\"cache\":true}}}],
\"config\":{\"sha\":\"sha256:e8e612c357fdecd2b395638bc5ff6fb2b5931b15a28aaa8378c5052e984a7c5d\"},\"launcher\":{\"sha\":\"sha256:20e1cf6014bd25720eb257f028b876dae49298820951982fa57cc2f64c086e66\"},\"process-types\":{\"sha\":\"sha256:83d85471d9f8a3834b4e27cf701e3f0aef220cc816d9c173c7d32cd73909a590\"},\"runImage\":{\"topLayer\":\"sha256:9b255324b9bb1c8ba0c76fe4470eb4c6fd3246c8f7301d203f670d513a92f2f2\",\"reference\":\"2bbac0f587073fdc878da9b08c048e60c84cde2a5cc691ef50c54e6684ebf31c\"},\"stack\":{\"runImage\":{\"image\":\"cnbs/sample-stack-run:alpine\"}}}",
                "io.buildpacks.project.metadata": "{}",
                "io.buildpacks.stack.id": "io.buildpacks.samples.stacks.alpine"
            }


Suggestion

I'd like to make a list containing self-contained resources. I have made a question about this on stackexchange, but then thought that an awesome-list would be a better place for such topic. Do you think an awesome-list would be appropriate format? Apologies if I shouldn't submit this question as issue, please tell me how to ask such questions properly.

Yeah, this could potentially be a good awesome list if it's done well. Keep in mind though that for it to be added here, it needs to be very high quality. However, awesome lists don't have to be added here to be useful.


Can it be improved? The arrow is blocked by the red point when debug

Can it be improved? The arrow is blocked by the red point when debug
It is not conspicuous and not beautiful

Hi @A-Pai,
I'm going to transfer this issue to our UX/UI repo so we can discuss how this can be improved.
Thanks for reporting!


Consider replacing out.OutputIsRedirected  by ctxutil.IsTerminal(ctx)

It seems we might have redundant handling of the "Are we in a terminal?" and "is output being redirected?"
ctxutil.IsTerminal relies on https://github.com/mattn/go-isatty in order to tell if we are in a terminal or not, which is great because it is very cross-platform, even supporting Plan9 and Windows.
I recently added in #2019 a method called OutputIsRedirected in our out package, which is meant to say if we are being redirected or not:
https://github.com/gopasspw/gopass/blob/b490c57e97689c4bb97933031b0369afa1863928/internal/out/print.go#L30-L34
It is not clear to me if this is equivalent to saying whether or not we are in a terminal, but it's pretty clear it probably isn't very cross-platform as is.
If "not being a tty" is including "being redirected", then we might want to change this new function to rely on go-isatty/ctxutil.IsTerminal(ctx) instead...
Originally posted by in https://github.com/gopasspw/gopass/pull/2024#discussion_r745122745

I just confirmed using the following example code from isatty:
package main

import (
	"fmt"
	"github.com/mattn/go-isatty"
	"os"
)

func main() {
	if isatty.IsTerminal(os.Stdout.Fd()) {
		fmt.Println("Is Terminal")
	} else if isatty.IsCygwinTerminal(os.Stdout.Fd()) {
		fmt.Println("Is Cygwin/MSYS2 Terminal")
	} else {
		fmt.Println("Is Not Terminal")
	}
}

That both piping and redirecting output returns "not a terminal", we can therefore replace the non-cross platform code for out.OutputIsRedirected with the cross platform ctxutil.IsTerminal function.
Sending a PR shortly.


chore(deps): bump ethers

Motivation
Closes #4003
includes better error message for case issues.

Solution

cc @transmissions11

goated as always ty @mattsse 🙏


Replace GetMaxRoundAccounted() with GetNextRoundToAccount()

Summary
Currently the import state stores the last accounted round which creates ambiguities: we cannot distinguish between the state before accounting round 0 and after. This works because block 0 contains no transactions, and we don't actually do accounting for it. However, with one phase import it will be a problem.
This PR changes the import state to store the next round to account instead, GetMaxRoundAccounted() is replaced with GetNextRoundToAccount(), and a migration is added. Since older migrations run before that, GetNextRoundToAccount() still supports the old import state format. In most cases, however, CommitRoundAccounting() will upgrade import state to the new format before the migration.
Test Plan
Wrote additional tests for GetNextRoundToAccount() to cover the old import state format, and added tests for the new migration.

Codecov Report

Merging #542 (0d2d959) into develop (2f4aa0b) will increase coverage by 0.26%.
The diff coverage is 53.54%.

@@             Coverage Diff             @@
##           develop     #542      +/-   ##
===========================================
+ Coverage    34.18%   34.44%   +0.26%
===========================================
  Files           24       24
  Lines         4842     4906      +64
===========================================
+ Hits          1655     1690      +35
- Misses        2948     2971      +23
- Partials       239      245       +6

Impacted Files
Coverage Δ

api/handlers.go
3.59% <14.28%> (-0.21%)
:arrow_down:

idb/postgres/postgres_migrations.go
22.43% <71.79%> (+1.33%)
:arrow_up:

idb/postgres/postgres.go
28.22% <72.72%> (+0.44%)
:arrow_up:

accounting/rewind.go
31.70% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f4aa0b...0d2d959. Read the comment docs.

Closing in favor of #559.


support of cell metadata in markdown

I am interested in supporting notebook cell metadata in the markdown file.This would have benefits:

It would maintain metadata like slideshow information for cells and allow one to write a slide show in markdown originally.
The would allow true round trip fidelity ipynb -> markdown -> ipynb

I am not sure about the best way to do this, but I can imagine abusing markdown links somewhat
each markdown cell would be allowed to have a "comment:"

[//]: # ( "cell_type": "markdown", "metadata": { "slideshow": { "slide_type": "slide"} } )
### The markdown content level three header
content plain text...

The code blocks would be handled as they are in notedown, but would add an optional metadata tag:

```{.python, "metadata" : {"collapsed": false, "slideshow": { "slide_type": "fragment"} } }
import numpy, pandas
y = 3 * 4
```

This may be an answer to #47
I am not married to the idea of using this particular system, but it would seem it would be ignored by a typical common-mark/markdown renderer and would not be too hard to implement.

hi @cleemesser - I have other reasons for working on this project (supporting Julia, R), so roundtripping sounds like a great idea to me.  joint project?!?

p.s. you know more python than me!

Sounds good. I have forked aaren's code and am messing with it as a prototype.

I'm not really sure about the best way to do this, and I'm a bit reluctant as I have very little time to maintain this any more, but things to consider are Pandoc's header_attributes and fenced_divs http://pandoc.org/MANUAL.html
Closing for now.


[Azure Load Testing - Azure Load Testing] API Review

New API Review meeting has been requested.
Service Name: Azure Load Testing - Azure Load Testing
Review Created By: Nitin Joy
Review Date: 04/04/2024 08:00 AM PT
Release Plan:
PR: https://github.com/Azure/azure-rest-api-specs/pull/28315
Hero Scenarios Link: Not Provided
Core Concepts Doc Link: Not Provided
Description:
Detailed meeting information and documents provided can be accessed here
For more information that will help prepare you for this review, the requirements, and office hours, visit the documentation here

Notes from API Review 4/4/24
Multi-engine feature

adding support for Locust

Multi-region support

Add documentation for regionName on what values are allowed and expected format.
Please document the key for testRunStatistics and regionalStatistics

@JeffreyRichter reviewed and approved over email.
Please address the above and with these changes this looks good for preview.


fix(runextractor): set --build_file default to build.gradle

this is the file name most projects use and is recommended by:
https://guides.gradle.org/creating-new-gradle-builds/

@justbuchanan, just an FYI, the description still says The config file for a gradle repo, defaults to 'gradle.build and I believe there a few more spots that refer to things as gradle.build instead of build.gradle (like here: https://github.com/kythe/kythe/blob/master/kythe/go/extractors/config/preprocessor/README.md#gradle).

Thanks, sent a followup in https://github.com/kythe/kythe/pull/4398.


Any issue or comment is welcome!

Please write down your comment, or just talking!

Hello,
No issues to report whatsoever and thank you for the great job.
I was going to dispose of my Garmin hud, but your app brought it back to life.
I was wondering since Waze is using Google maps, do you believe that your app can be modified so that Garmin hud can receive info from Waze?

Hello,
No issues to report whatsoever and thank you for the great job.
I was going to dispose of my Garmin hud, but your app brought it back to life.
I was wondering since Waze is using Google maps, do you believe that your app can be modified so that Garmin hud can receive info from Waze?

Hi.
Unfotunally, Waze don't use "Notification" to hint the route, so it's need more work to make GarminHUD with Waze.
skyforce

Hello skyforcetw ,
Installed app ver. 0.5.4 on galaxy tab s2 android 7.0 and managed to connect to Garmin HUD.
Google maps ver. 10.29.1 with all notifications enabled.
Garmin HUD shows speed and time , but there is no routing information from Google maps shown on HUD. Tested 3 buttons in debug window and arrows appear on HUD.
Notifications also appear in notification window of the tablet, but not on HUD.
On the main screen "GARMIN HUD" and "Notification Capture" are activated and "Gmap navigation Capture" is not activated. When driving updated speed and time are shown on HUD, but no routing information. In notification window of the app only  messages with updated speed are shown.
Hope to hear your thoughts.
Many thanks
P.S. in addition I tried to install app ver. 0.5.4. on car android device running on Android 5.1 , but during install error message regarding parsing appeared and installation terminated.

Hi
Did you set the notification access?
https://github.com/skyforcetw/Garminuino/blob/master/GoogleMaps_HUD/FIRST_USE.md

Yes Sir, Notification access is enabled.  Kindest regards,  Yan1980
-------- Оригинално писмо --------
От: skyforce<EMAIL_ADDRESS>Относно: Re: [skyforcetw/Garminuino] Any issue or comment is welcome! (#1)
До: skyforcetw/Garminuino
Изпратено на: 17.11.2019 14:46
Hi
Did you set the notification access?
https://github.com/skyforcetw/Garminuino/blob/master/GoogleMaps_HUD/FIRST_USE.md
—
You are receiving this because you commented.
Reply to this email directly,  view it on GitHub , or  unsubscribe .

Yes Sir, Notification access is enabled. Kindest regards, Yan1980
…
-------- Оригинално писмо -------- От: skyforce<EMAIL_ADDRESS>Относно: Re: [skyforcetw/Garminuino] Any issue or comment is welcome! (#1) До: skyforcetw/Garminuino Изпратено на: 17.11.2019 14:46 Hi Did you set the notification access? https://github.com/skyforcetw/Garminuino/blob/master/GoogleMaps_HUD/FIRST_USE.md — You are receiving this because you commented. Reply to this email directly, view it on GitHub , or unsubscribe .

Please try this one:
https://github.com/skyforcetw/Garminuino/releases/download/0.5.5/gmaps_hud-release_v0.5.5.apk
I add some debug message, if no gmap's notify capture, it can show result:
"Notify parsing failed.";
"No gmaps' notification found!?!?"
"No notification found!?!?"
Please check the message you got.

Thx for your great work! Just bought a GarminHUD because of your app! Is there a possibiliy to add an autostart and autoend to your application?

Thx for your great work! Just bought a GarminHUD because of your app! Is there a possibiliy to add an autostart and autoend to your application?

My pleasure ^^
Can you describe a bit about autostart & autoend?

i've installed it on my Android phone, and i cant enable:

Gmap navigation capture
Traffic & Lane Detect (Need Screenshot)

anything i'm missing obvious here?

These two function are not stable, so I remove it, sorry!

These two function are not stable, so I remove it, sorry!

got it! but the project is still working? if yes, Android 5 supported?

hey @skyforcetw
does it fetch current speed limit of the area and shows it on the HUD? like  the original Garmin app?

No, that need extra work for it.

No, that need extra work for it.

it would be so great and useful! i hope you can do it!


'package:flutter/src/rendering/mouse_tracker.dart': Failed assertion: line 206 pos 12: '!_debugDuringDeviceUpdate': is not true.

======== Exception caught by scheduler library =====================================================
The following assertion was thrown during a scheduler callback:
'package:flutter/src/rendering/mouse_tracker.dart': Failed assertion: line 206 pos 12: '!_debugDuringDeviceUpdate': is not true.
Either the assertion indicates an error in the framework itself, or we should provide substantially more information in this error message to help you determine and fix the underlying cause.
In either case, please report this assertion by filing a bug on GitHub:
https://github.com/flutter/flutter/issues/new?template=2_bug.md
When the exception was thrown, this was the stack:
#2      MouseTracker._deviceUpdatePhase (package:flutter/src/rendering/mouse_tracker.dart:206:12)
#3      MouseTracker.updateAllDevices (package:flutter/src/rendering/mouse_tracker.dart:358:5)
#4      RendererBinding._scheduleMouseTrackerUpdate. (package:flutter/src/rendering/binding.dart:387:22)
#5      SchedulerBinding._invokeFrameCallback (package:flutter/src/scheduler/binding.dart:1146:15)
#6      SchedulerBinding.handleDrawFrame (package:flutter/src/scheduler/binding.dart:1091:9)
#10     _invoke (dart:ui/hooks.dart:151:10)
#11     PlatformDispatcher._drawFrame (dart:ui/platform_dispatcher.dart:308:5)
#12     _drawFrame (dart:ui/hooks.dart:115:31)
(elided 5 frames from class _AssertionError and dart:async)

Duplicate of https://github.com/flutter/flutter/issues/107063


[main] Upgrade to latest dependencies

Cron -knative-prow-robot
/cc knative-sandbox/source-wg-leads
/assign knative-sandbox/source-wg-leads
Produced by: knative-sandbox/knobots/actions/update-deps
Details:
bumping go.uber.org/zap 404189c...ebebbf3:
  > ebebbf3 Release v1.17.0 (# 956)
  > 75ac0de Prepare release v1.17.0
  > f612082 zapcore/FieldType: Don't change enum values (# 955)
  > d3092aa Integrate FOSSA (# 953)
  > 4110cb4 lint: Check that 'go mod tidy' was run (# 951)
  > 756fb2a go mod tidy (# 947)
  > 2732714 internal/readme: Simplify if condition (# 945)
  > 2f8e331 FAQ: Add zapfilter (# 939)
  > 34ea13c Update dependencies to fix vulnerabilities in (# 936)
  > 9a9e13f Switch from Travis to GitHub Actions (# 940)
  > 15dca18 zapcore: Cleanup copy in NewMultiWriteSyncer (# 934)
  > 92549f9 Update dependencies to fix vulnerabilities (# 931)
  > 8d5e39e Add FilterFieldKey to zaptest/observer (# 928)
  > 016a93b Support multi-field encoding using zap.Inline (# 912)
  > 6f4d093 Add support for grpclog.LoggerV2 (# 881)
  > b73d9b5 tools: Move to submodule (# 914)
  > d5dd706 Remove outdated information, make dependencies is no longer necessary. (# 915)
  > dca7c25 Optimize Sugar logger for calls with a single string arg (# 913)
  > 9f3c0ee Fix: code quality issues using DeepSource (# 907)
  > 864bed1 http: support additional content type (# 903)
  > a68efdb travis: Test against ppc64le (# 872)
  > f5a3592 Byte alignment, optimization from 96 to 80 byte (# 865)
  > 5b4722d README: use pkg.go.dev instead of godoc.org (# 883)
  > 4b2b07c field/error: Handle panic in Error() (# 867)
  > 495658f travis: Test against stable and oldstable (# 882)
  > 9d2e5de Add FAQ question on zap dropping logs due to sampling (# 875)
bumping knative.dev/pkg 4564797...0e61d67:
  > 0e61d67 Bump assorted dependencies (# 2140)
  > a2869ae upgrade to latest dependencies (# 2139)
  > e6552a0 Update community files (# 2138)
  > 79f8b3f Auto-generate webhook certs with ECDSA for FIPS compliance (# 2136)
  > 3e1e4d7 Update community files (# 2137)
  > 803d2ba use more general kubernetes.Interface (# 2135)
  > 47dfdcf consolidate k8s flags to an environment package (# 2133)
  > 6484377 update boilerplate date (# 2134)
  > 35916ab Update actions (# 2132)
  > 980a337 Fix revive related linting issues (# 2131)
  > ea766de Bump assorted dependencies (# 2130)
  > e2947db update the multiple label selector implemention to avoid clobber in filtered factory (# 2120)
  > e749d6a Update community files (# 2129)
  > 67897f4 Replace golint with revive (# 2126)
  > 1442287 Add knative-release-leads to OWNERS (# 2125)
  > 9b837a7 Update actions (# 2123)
  > 525c625 Update actions (# 2121)
  > 620e8d2 Allow disable via regex in chaosduck (# 2117)
  > 1f5a45b Update knative/community files (# 2119)
bumping golang.org/x/net e915ea6...abc4532:
  > abc4532 route: remove check for unparsed route message bytes
  > fe42d45 route: revert routing message alignment for FreeBSD 386 emulation
  > 37e1c6a html: ignore templates nested within foreign content
  > 4163338 route: add //go:build line to empty.s
  > 81045d8 http2: switch to ASCII equivalents of string functions
  > 16afe75 http2: remove TLSConfig.CipherSuites order check
  > 0714010 crypto/tls: don't use tls.Dialer on pre-Go1.15 systems
  > 0287a6f internal/socket: handle nil addr in sendMsgs
  > bbd867f http2: use (*tls.Dialer).DialContext in dialTLS
  > 7fd8e65 go.mod: upgrade to go 1.17
  > e590880 publicsuffix: update table to latest list from publicsuffix.org
  > f8dd838 internal/socket: reuse buffers in recv/sendMsgs
  > aec3718 idna: allow specifying CheckHyphens and CheckJoiners
  > 89ef3d9 http/httpguts: remove recursion in HeaderValuesContainsToken
  > 85d9c07 route: retry FetchRIB a few times in case data grows
  > 5f58ad6 ipv4: use type IPMreqn from x/sys/unix
  > e997de6 internal/socket: add ppc system call definitions, for use with gccgo
  > 4e50805 internal/socket: use larger buffers in race test
  > 2554d15 internal/socket: use SizeofSockaddrInet{4,6} constants from x/sys/unix
  > 798c215 ipv6: use all socket option consts from x/sys/unix
  > d25e304 ipv4: use all socket option consts from x/sys/unix
bumping knative.dev/eventing 200e54c...db83525:
  > db83525 Removing the skip (# 5418)
  > 465df26 add conformance test for trigger delivery DLQ (# 5471)
  > ab3978c Adapter's StartReceiver() method implemented (# 5464)
  > 0f71d86 upgrade to latest dependencies (# 5469)
  > 0ca9a9c remove v1beta1 task as it has been done (# 5467)
  > 5b1d8dd use the non-deprecated version (# 5468)
  > 114c6b7 Update actions (# 5466)
  > 738ffa0 upgrade to latest dependencies (# 5465)
  > 608a7fe upgrade to latest dependencies (# 5447)
  > e27695b Update community files (# 5462)
  > 49420f4 Added broker.WithConfig (# 5461)
  > 66dbf4a Added tristate flags and changed experimental config map name (# 5459)
  > a4650e0 Update community files (# 5458)
  > d5f8b90 rekt/resources: support trigger annotations (# 5456)
  > d1106c8 [QE] Don't wait on triggers, before deploying their subscriber (# 5444)
  > 65bed40 Update actions (# 5438)
  > 0d129e4 Fix a broken link in experimental-features.md (# 5453)
  > b813a54 Remove camel as a downstream now that is deprecated (# 5449)
  > 9d1c35f drop use of deprecated sharedmain functions (# 5450)
  > 6e9588c Bump downstream job to go 1.16 (# 5448)
  > 5d3d12f Use a readiness probe to check apiserver adapter readiness (# 5446)
  > 674815e Remove unprintable characters from the deadLetterSink request header (# 5439)
  > 7678f90 upgrade to latest dependencies (# 5437)
  > 91d6079 Fix ordering in EventTransformation test (# 5435)
  > 6776718 Experimental features process documentation (# 5404)
  > 295134c Experimental features configuration and validation (# 5214)
  > 0882e0c upgrade to latest dependencies (# 5434)
  > e48c80d Only upload pod logs logs on failure (# 5429)
  > 8fbacd0 mt broker dispatch error log (# 5426)
  > cca60b3 [QE] Allow to change SUT for upgrade tests (# 5321)
  > 40fa622 Fix cloudevent adapter panic (# 5424)
  > 18a70de Convert channel event transformation e2e to rekt (# 5423)
  > d74ca9d Update community files (# 5420)
  > 869220a Disable chaosduck on the webhook (# 5419)
  > 5af518d [QE] Extension point for transport used to send events in upgrade tests (# 4815)
  > cf5b0eb upgrade to latest dependencies (# 5417)
  > 23198cd SinkBindings track their sinks (# 5410)
  > 453e4c0 Subscription.Spec.Channel now uses KReference (# 5412)
  > 0653ac4 Add podAntiAffinity labels to remaining HA control plane pods (# 5409)
  > 62a75eb PingSource stored version is now v1 (# 5381)
  > 6addb58 Add knative-release-leads to OWNERS (# 5405)
bumping knative.dev/hack 93ad912...de04b70:
  > de04b70 Do not print debug info when running release.sh (# 70)
bumping github.com/google/go-cmp 8fa37b4...d103655:
  > d103655 Print as text if mostly text (# 258)
  > 9181d1e Avoid diffing by lines if inefficient (# 260)
  > c5c3378 Cleanup edit groups after coalescing (# 259)
  > 1ee4af8 Fix typo in path.go (# 256)

/lgtm
/approve


[MOD] Notifications panel: fetch and load content using async

Current panel implementation uses an iframe to force the entire notifications page of the site into the view.
Proposal:
Fetch the names/messages elements of that page in async, use a progress animation in the panel itself, then load in the contents when ready. Also gives more fine-grained control over how the elements are arranged and manipulated, as they could just be stored in arrays rather than rendering the whole page.

@artillect @minnieoo End-to-end prototype is ready in this branch: https://github.com/aclist/kbin-kes/tree/patch-notipanel
Content is fetched async and stored in arrays. A spinner animates while loading. When ready, the content loads in.
The code is a lot more compact now and takes a more function => callback oriented structure.
Now we need help from the CSS masters: currently no styling is being applied to the messages in the panel. I think a grid template would probably do the trick. We can lay them out in the same way as the old CSS and give them the same class names if necessary--so that it looks identical, but we're actually loading the content from arrays instead of an iframe.
The "Read" and "Purge" buttons will be easy to add, they are just a POST request to the server.

Also, the spinner animation could be anything, I just threw that one in as an example. Could center it in the panel or do whatever with it, too.

[x] Add time element after name
[x] Add unique classname to private message
[ ] Add read/unread classnames -- pending

Completed and will commit those updates later after testing it.

I doubt pagination would work well in a panel from a user perspective, my idea so far is to have infinite scroll or a "show more" button at the bottom that loads the next page of notifications (make it a preference or make it depend on the "infinite scroll" setting in kbin settings? maybe?)
I never had multiple pages of notifications (I purge them regularly) so I have no clue how it really looks like though lol

Infinite scroll

Hmm, that's not a bad idea. I think you could safely fit a small arrow-left/arrow-right icon at the top or bottom too if necessary.
I never had thousands of notifications, either, so don't have any real-world data on that, but the first page tends to hold quite a lot of notifications before you need to reach page 2.

Took a look at the unread/read, unread messages just come through with a reduced opacity class:
Read: section section--small thread
Unread: section section--small thread opacity-50
.opacity-50 {
    opacity: 0.5
}

So we can just carry that classname through with no change and should be good!

Alright, added in everything you asked for up to commit 6f7e229

PMs get the noti-message class
Read items pass through opacity-50
Time element comes after username

Pagination: to be determined

Great! There are currently 2 issues with the styling I made:

Styling for the notifications counter doesn't use the child combinator (it wasn't needed before so I just didn't put it) so it affects everything in the panel. It can be easily fixed by changing #header menu .notification-button a:not(.fa-solid.fa-bell) to #header menu .notification-button > a:not(.fa-solid.fa-bell)
Kbin's styling for .dropdown__menu a, .dropdown__menu button has !important for padding and display (absolutely no clue why, deleting it changes nothing lol), which breaks styling inside the panel, I tried to add !important to my own styling in Stylus to override but it wouldn't work (I delete it manually while working on it), might have to either

Make an issue on Kbin to fix it, might take a while as it would be a low priority (but easy to fix) issue.
Use element styling, it's already used to add margin-left anyway.

Another slight nitpick is with the counters. Notifications and message counters are separate (despite both being displayed on the notifications page for some reason?), currently it moves the notifications counter to the notification bell but the messages counter is untouched, it looks a bit ugly in my opinion, but we can probably keep it since clicking the messages counter directly takes you to the messages page and changing it will add an extra click and second which is something that's the mod is supposed to stop lol

Alright, can you submit a PR of your WIP so I can have a look at what you mean, specifically? It's a bit hard to visualize just based on the classnames alone.
Agree that the counter logic is bananas right now.


[BUG] Long Callbacks Error w/ dashtools gui

Thank you so much for helping improve the quality of dash-tools!
We do our best to catch bugs during the release process, but we rely on your help to find the ones that slip through.
Describe your context

replace the result of dash-tools --version below

1.10.3

please tell us what operating system you are using

[e.g. mac]

Describe the bug
Error message about long callbacks requiring celery manger or disk cache when dashtools gui is started. Seems to be related to new version of Dash.
Expected behavior
No error message
Screenshots
If applicable, add screenshots or screen recording to help explain your problem.

Fixed in #76


Mention Parquet among supported input formats

zq as of commit 64d5e4a includes support for reading input files of Parquet format, but it's not yet mentioned in the supported list of formats in zq help.
$ zq help 2>&1 | grep "input data"
    -i format of input data [auto,zng,ndjson,zeek,zjson,tzng] (default "auto")

I checked with @aswan and he confirmed this was an oversight, so opening this as a reminder to circle back and add it.

Verified in zq commit a1d0967. Much like Prego spaghetti sauce in the 80's, it's in there.
$ zq help 2>&1 | grep "input data"
    -i format of input data [auto,zng,ndjson,zeek,zjson,tzng,parquet] (default "auto")

and in there!
$ zq -t  zio/detector/testdata/dns.parquet
zio/detector/testdata/dns.parquet: format detection error
	tzng: line 1: bad format
	zeek: line 1: bad types/fields definition in zeek header
	ndjson: line 1: Unknown value type
	zjson: line 1: invalid character 'P' looking for beginning of value
	zng: zng descriptor out of range
	parquet: auto-detection not supported

If we're referencing 80's food commercials, we can't leave out https://www.youtube.com/watch?v=leQsRqMN230

Parkay truly shines when it speaks: https://www.youtube.com/watch?v=s0PnxGqFNz8


address three bugs in forwarded header parsing

Previously,

parsing forwarded headers required the for section to be first (#374)
checking short strings against a prefix that is longer than it with starts_with_ignore_case would panic (only used in forwarded currently)
parse_utils::parse_token (pub(crate)) token did not successfully parse 1-character tokens due to an off-by-one error

This can be fairly easily backported to the 2.x line if there's interest
closes #374

do we have a branch or tag for 2.x?

@jbr https://github.com/http-rs/http-types/tree/v2.x.x-backports


Enhance GIF selection feature

This pull request adds enhancements to the GIF selection feature in the application. It includes changes to both the moment_controller.js and select_gif_controller.js files to improve the user experience when selecting GIFs.
Changes:
In moment_controller.js:
Added logic to de-select a GIF if the same GIF is selected again. This prevents redundant selections and clears the input field if the same GIF is clicked.
In select_gif_controller.js:
Added logic to check if there is already a selected GIF. If a GIF is already selected, the controller will not search for a new one, improving efficiency and preventing unnecessary searches.

Looking great! This helps reducing  the searches made.


Add properties to configure if scan results are read from or written to the scan storages

Add properties to configure for each scanner if scan results are read from or written to the configured scan storages. Please see the commit messages for details.
Breaking API change:

The ScannerWrapperFactory.create() function now gets a ScannerWrapperConfig instead of a ScannerMatcherConfig.
The ScannerWrapper interface now requires implementing the two new properties readFromStorage: Boolean and writeToStorage: Boolean.

Merged despite test failures, as only the unrelated GoDepFunTest was failing.


Add the ability to control the replay speed of pre-recorded data

The pre-recorded data should ideally be possible to replay at different speeds.
This should just entail altering the playback sample time.
Control could be numeric or a simple "normal, fast, faster" selection

Duplicated by #97


"Cannot

Debug:
DEBUG: -------------------------------
DEBUG: Ember      : 2.14.0-beta.3
DEBUG: Ember Data : 2.13.1
DEBUG: -------------------------------

Log:

TypeError: Cannot convert a Symbol value to a string
> app.instance
TypeError: Cannot convert a Symbol value to a string
    at Object.get (/Users/ricardomendes/src/--ember/ember-cli-developer-tools/dist/assets/vendor/ember/ember.debug.js:9750:1)
    at formatValue (util.js:362:37)
    at formatProperty (util.js:822:15)
    at util.js:681:12
    at Array.map (native)
    at formatObject (util.js:680:15)
    at formatValue (util.js:620:16)
    at formatProperty (util.js:822:15)
    at util.js:681:12
    at Array.map (native)
    at formatObject (util.js:680:15)
    at formatValue (util.js:620:16)
    at formatProperty (util.js:822:15)
    at util.js:681:12
    at Array.map (native)
    at formatObject (util.js:680:15)
    at formatValue (util.js:620:16)
    at Object.inspect (util.js:203:10)
    at REPLServer.self.writer (repl.js:459:19)
    at finish (repl.js:584:38)
    at REPLServer.defaultEval (repl.js:377:5)
    at bound (domain.js:280:14)
    at REPLServer.runBound (domain.js:293:12)
    at REPLServer.eval (/Users/ricardomendes/src/--ember/ember-cli-developer-tools/node_modules/await-outside/index.js:136:29)
    at REPLServer.onLine (repl.js:536:10)
    at emitOne (events.js:96:13)
    at REPLServer.emit (events.js:191:7)
    at REPLServer.Interface._onLine (readline.js:241:10)
    at REPLServer.Interface._line (readline.js:590:8)
    at REPLServer.Interface._ttyWrite (readline.js:869:14)
    at REPLServer.self._ttyWrite (repl.js:609:7)
    at ReadStream.onkeypress (readline.js:120:10)
    at emitTwo (events.js:106:13)
    at ReadStream.emit (events.js:194:7)
    at emitKeys (internal/readline.js:402:14)
    at emitKeys.next (<anonymous>)
    at ReadStream.onData (readline.js:980:36)
    at emitOne (events.js:96:13)
    at ReadStream.emit (events.js:191:7)
    at readableAddChunk (_stream_readable.js:178:18)
    at ReadStream.Readable.push (_stream_readable.js:136:10)
    at TTY.onread (net.js:561:20)

This is a bug in node, where it can't print a Symbol. Not much we can do from our side.

If you can open an issue with node, and provide a quick reproduction of a object \w symbol trying to be presented in the repl. That would be handy.

I believe the issue is here: https://github.com/nodejs/node/blob/master/lib/util.js#L277

https://github.com/nodejs/node/blob/master/lib/util.js#L349 more specifically I think

Funky issue:
crashes: app.instance.__container__.factoryManagerCache['router:main']
works: app.instance.__container__.factoryManagerCache['router:main'].class
works: app.instance.__container__.factoryManagerCache['router:main'].create
I wonder if it is something related to factoryManager's being proxies in development...

Yup, it appears to be related to the proxy.

Likely this. https://github.com/emberjs/ember.js/blob/master/packages/container/lib/container.js#L193

Symbol(Symbol.toStringTag) + toString missing are likely the issue

also apparently: Symbol(util.inspect.custom)

and apparently also apparently... inspect

After debugging, I don't think this is an issue with nodes inspect. Although it could be improved, the issue is in ember debug proxy.


Use expected default report_type string

GithubStats::Reports expects a default key of 'closed_by_week'.  Update the default string here to match.

@zspencer Please merge this change, as the gem doesn't pull data from GitHub without it.


fix: [#9059] Bot remains as a background process after closing Composer

Description
This PR fixes an issue where Composer didn't terminate bots' processes properly, leaving them running in the background after closing Composer.
Task Item
Fixes #9059
Screenshots
The following image shows the bot running and the new message shown when cleaning up the processes.

Hi @OEvgeny, we've been working on this issue and created the PR#xxx with a possible fix. Let us know if these changes are ok with you.
TL;DR: the electron server was closing the client before it finished executing the cleanup process.


Proposal for Community Management of Creators and Creations

Following up on a conversation with Scott...
Today, my assumption is that a Creator would come and update README here to reserve namespace on a CreatorID and then self-host someplace else a list of CreationIDs.
The rest of this is about creators and creations where the person working on the CP port is not the manufacturer\designer of the board.
In those cases, the community is maintaining both of these, so having a repo per Creator is hard to manage as they probably should live in this Org not in the contributors personal namespace. But creating repos is more complicated than a PR.
creationid/creatrors/README.md is the list of Creators and a link to where the Creations for that creator live. If its a repo in another place, great. But if not, then a creationid/creators/creations/CREATOR_NAME.md should be created in this repo and that is what is linked to in the README.md.
So if we look at my most recent addition:
0x1010_1010 [DFRobot](https://github.com/creationid/dfrobot-creations)
I needed a repo in this org.
Instead it would be
0x1010_1010 [DFRobot](creations/DFROBOT.md)
Not sure my markdown is correct, but that is intended to be a link to a DFROBOT.md in a creations folder in this repo.
This should let people add both CreatorIDs and CreationIDs with a PR and not need to ask for repos.
Let me know what you think.  I'm happy to make PRs for all the repos we would want to move to whatever final format we decide.

Let me know what you think @tannewt ty!

@askpatrickw Yup, I think that's a great idea. Let me know if you need anything from me to make it happen.

I'll do this now. I need a HardKernel one.


Upscaling standdalone hash signs doesn't work

A single hash sign opening a message (e.g. "# test") is incorrectly interpreted by the Markdown parser as a heading marker and consequently lost when upscaling to PresentationML.

Fixed in 1d883d50431587190f21fe6e6377ac91cccf5aa7


Questions about EmbeddingWrapper

Is the EmbeddingWrapper used to overwrite/train the text encoder's embedding layer?
From what I understand I just need to access the Embedding layer in let's say CLIP, wrap it in this class, pass in my text, get embeds_with_new_concept, embeds_with_superclass, embed_mask, concept_indices out, then finish passing the first two into the rest of the text encoding model. Is it the only layer within the text encoder that needs to be trained? Thanks

Yup, you can see all the parameters that are trained in this function. This is the highlight of this paper https://github.com/lucidrains/perfusion-pytorch/blob/main/perfusion_pytorch/save_load.py#L20

Another question, does the embed_mask get passed into loss_fn_weighted_by_mask() as well as the cross attention modules?

@irowberry so embed_mask goes into the cross attention as the key padding mask
the mask for weighting the loss function actually comes from another section in the paper. they use some pretrained model that outputs a segmentation mask to weigh the loss, and this apparently led to better results


Neovim: Option 'commentstring' is empty

I am trying to use the default neovim binding 'gc' (introduced in https://github.com/neovim/neovim/pull/28176) for commenting a block of code in a gleam file and this does not work as it expects 'commentstring' to be set. According to the PR, this can be set by tree sitter which is why I am opening the issue here. I have tree sitter enabled and this works for other languages without extra configuration.
$ nvim --version
NVIM v0.10.2
Build type: Release
LuaJIT 2.1.1727870382
Run "nvim -V1 -v" for more info

For now, I am setting vim.opt_local.commentstring = '// %s' in after/ftplugin/gleam.lua to get the desired behaviour, but it would be nice if this was done automatically with tree sitter enabled.

This repo doesn't have any particular Neovim support so I'm going to close this issue, however if you determine that there is something missing that would help Neovim users then a contribution would be accepted, thank you.


Unable to upgrade Flutter: The Flutter SDK is tracking a non-standard remote

Steps to Reproduce

Execute flutter upgrade

Expected results: The flutter tool upgrades.
Actual results: It says i am tracking a different repo for upgrade when the URLs are equal.
>flutter upgrade
Unable to upgrade Flutter: The Flutter SDK is tracking a non-standard remote<EMAIL_ADDRESS>Set the environment variable "FLUTTER_GIT_URL" to<EMAIL_ADDRESS>and retry. Alternatively, re-install Flutter by going to https://flutter.dev/docs/get-started/install.
If this is intentional, it is recommended to use "git" directly to keep Flutter SDK up-to date.

Logs

[√] Flutter (Channel stable, 2.8.1, on Microsoft Windows [Versione 10.0.19044.1503], locale it-IT)
    • Flutter version 2.8.1 at C:\flutter
    • Upstream repository<EMAIL_ADDRESS>    • Framework revision 77d935af4d (8 weeks ago), 2021-12-16 08:37:33 -0800
    • Engine revision 890a5fca2e
    • Dart version 2.15.1

[!] Android toolchain - develop for Android devices (Android SDK version 32.1.0-rc1)
    • Android SDK at C:\Users\nicol\AppData\Local\Android\sdk
    X cmdline-tools component is missing
      Run `path/to/sdkmanager --install "cmdline-tools;latest"`
      See https://developer.android.com/studio/command-line for more details.
    X Android license status unknown.
      Run `flutter doctor --android-licenses` to accept the SDK licenses.
      See https://flutter.dev/docs/get-started/install/windows#android-setup for more details.

[√] Chrome - develop for the web
    • Chrome at C:\Program Files\Google\Chrome\Application\chrome.exe

[√] Android Studio (version 2021.1)
    • Android Studio at C:\Users\nicol\AppData\Local\JetBrains\Toolbox\apps\AndroidStudio\ch-0\211.7628.21.2111.8139111
    • Flutter plugin version 64.0.2
    • Dart plugin version 211.7798
    • Java version OpenJDK Runtime Environment (build 11.0.11+9-b60-7590822)

[√] IntelliJ IDEA Ultimate Edition (version 2021.3)
    • IntelliJ at C:\Users\nicol\AppData\Local\JetBrains\Toolbox\apps\IDEA-U\ch-0\213.6777.52
    • Flutter plugin can be installed from:
       https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
       https://plugins.jetbrains.com/plugin/6351-dart

[√] VS Code (version 1.64.0)
    • VS Code at C:\Users\nicol\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension version 3.34.0

[√] Connected device (2 available)
    • Chrome (web) • chrome • web-javascript • Google Chrome 98.0.4758.81
    • Edge (web)   • edge   • web-javascript • Microsoft Edge 97.0.1072.76

! Doctor found issues in 1 category.

Hi @nicolasvac, Thanks for filing the issue. Could you please try adding the origin to the SDK by
cd path_to_flutter_Sdk
git remote set-url origin https://github.com/flutter/flutter.git
flutter upgrade

Still the same.
C:\flutter>git remote set-url origin https://github.com/flutter/flutter.git

C:\flutter>flutter upgrade
Unable to upgrade Flutter: The Flutter SDK is tracking a non-standard remote<EMAIL_ADDRESS>Set the environment variable "FLUTTER_GIT_URL" to<EMAIL_ADDRESS>and retry. Alternatively, re-install Flutter by going to https://flutter.dev/docs/get-started/install.
If this is intentional, it is recommended to use "git" directly to keep Flutter SDK up-to date.

C:\flutter>

can you please share the output of git remote -v by navigating inside the flutter repository?

@maheshmnj Done:
PS C:\Users\nicol> cd C:\flutter
PS C:\flutter> git remote -v
origin<EMAIL_ADDRESS>(fetch)
origin<EMAIL_ADDRESS>(push)
PS C:\flutter> flutter upgrade
Unable to upgrade Flutter: The Flutter SDK is tracking a non-standard remote<EMAIL_ADDRESS>Set the environment variable "FLUTTER_GIT_URL" to<EMAIL_ADDRESS>and retry. Alternatively, re-install Flutter by going to https://flutter.dev/docs/get-started/install.
If this is intentional, it is recommended to use "git" directly to keep Flutter SDK up-to date.
PS C:\flutter>

@nicolasvac, it looks like there is some issue with ssh URL Please try removing it and adding a https URL. You can do this by
running
git remote rm origin
git remote add origin https://github.com/flutter/flutter.git

Now ensure that your remote is a https URL (for both push and pull) by running git remote -v, once set then please try upgrading flutter.

I've setup my git to replace every https of github with ssh, to do not have problems with golang.
Honestly speaking the flutter tool should check for both the https version and the ssh version, as they are both valid source of git.

@nicolasvac I believe the flutter tool does support ssh URLs too, if this is not the case I do agree that we should support it. Could you please confirm, whether it is working with https url?

Hi Mahesh, I have the same issue and I can confirm it is the flutter tool the one that doesn't support the ssh URL, this is the command I'm running to upgrade flutter without issues:
<EMAIL_ADDRESS>flutter upgrade

Thanks for the info @nicolasvac, Labeling this issue for further insights from the team.

cc: @christopherfujino

As long as we validate that the tool pulls from flutter/flutter by default, this SGTM.

@nicolasvac to unblock yourself, I believe you can set the env var FLUTTER_GIT_URL to<EMAIL_ADDRESS>as the error message suggests. Per stack overflow, I believe the syntax to do this in a powershell session would be:
$env:FLUTTER_GIT_URL =<EMAIL_ADDRESS>flutter upgrade

Honestly speaking the flutter tool should check for both the https version and the ssh version, as they are both valid source of git.

We do check for ssh; however, for the syntax that GitHub uses: git@github.com:flutter/flutter.git.
A more permanent fix I believe would be to set your remote url to use the GitHub syntax, like:
git remote set-url origin git@github.com:flutter/flutter.git

I believe this will avoid the insteadOf pattern matching you've setup in your .gitconfig.

Hi @nicolasvac, Thanks for filing the issue. This seems like an issue with your git configuration, Could you please try adding the https URL rather than ssh to the SDK repo by
cd path_to_flutter_Sdk
git remote set-url origin https://github.com/flutter/flutter.git
flutter upgrade

THANK YOU! I had the issue written at the description, that solved my case, managed to update my Dart SDK version.

@christopherfujino is there anything that can be done by the flutter team (maybe automate this check) ?

I think as long as the tool allows a user-defined override (FLUTTER_GIT_URL in this case), there shouldn't be a necessity to add different types of remotes that a user can use; after all, the tool cannot really control what is set in insteadOf of the user's gitconfig.
Also allowing upgrade from an arbitrary remote by default would imply an official support of the remote.

For Windows users -
Check if you have Git or not. If not download it and put it in the system PATH.
Delete the old flutter folder and then run this command in the terminal.
git clone https://github.com/flutter/flutter.git -b stable
After flutter is downloaded completely, run flutter doctor -v in the terminal.
Now all your issues will be fixed and all the errors like these will be fixed.
"flutter upgrade" command "Unable to upgrade Flutter: no upstream repository configured."

Unable to upgrade Flutter: no origin repository configured.

Unable to upgrade Flutter: The Flutter SDK is tracking a non-standard remote

flutter upgrade
error: No such remote 'origin'
Unable to upgrade Flutter: The Flutter SDK is tracking a non-standard remote "git@github.com:alhamodi/yemencall.git".
Set the environment variable "FLUTTER_GIT_URL" to "git@github.com:alhamodi/yemencall.git". If this is intentional, it is recommended to use
"git" directly to manage the SDK.
Reinstalling Flutter may fix this issue. Visit https://flutter.dev/docs/get-started/install for instructions.
❯ git remote -v
yemencall       git@github.com:alhamodi/yemencall.git (fetch)
yemencall       git@github.com:alhamodi/yemencall.git (push)
❯ git remote rm origin
error: No such remote: 'origin'
❯ git remote rm yemencall
❯ git remote set-url origin https://github.com/flutter/flutter.git
error: No such remote 'origin'
❯ git remote add origin https://github.com/flutter/flutter.git
❯ flutter upgrade
Unable to upgrade Flutter: The current Flutter branch/channel is not tracking any remote repository.
Re-install Flutter by going to https://flutter.dev/docs/get-started/install.
❯ git remote set-url origin https://github.com/flutter/flutter.git
❯ flutter upgrade
Unable to upgrade Flutter: The current Flutter branch/channel is not tracking any remote repository.
Re-install Flutter by going to https://flutter.dev/docs/get-started/install.
❯ git remote -v
origin  https://github.com/flutter/flutter.git (fetch)
origin  https://github.com/flutter/flutter.git (push)
❯ flutter channel stable
Switching to flutter channel 'stable'...
git: Already on 'stable'
Successfully switched to flutter channel 'stable'.
To ensure that you're on the latest build from this channel, run 'flutter upgrade'
❯ flutter upgrade
Unable to upgrade Flutter: The current Flutter branch/channel is not tracking any remote repository.
Re-install Flutter by going to https://flutter.dev/docs/get-started/install.
❯ git branch --set-upstream-to=origin/stable stable
Branch 'stable' set up to track remote branch 'stable' from 'origin'.
❯ flutter upgrade
Upgrading Flutter to 3.3.0 from 3.0.5 in
Downloading Darwin arm64 Dart SDK from Flutter engine 5e9e0e0aa8be4ff69facadd706b713f0bb54d5b3...
% Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
Dload  Upload   Total   Spent    Left  Speed
0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
0  185M    0     0    0     0      0      0

if configured git global URL re-write like:
[url<EMAIL_ADDRESS>        insteadOf = https://github.com/

It will always automatically switch to the ssh URL instead of the HTTPS URL and causes a warning:
Upstream repository<EMAIL_ADDRESS>is not a
      standard remote

Disable the URL re-write and update the origin to HTTPS URL will fix the warning.

Is there any solution to this issue other than removing git url rewrite?

No, but this rewrite fixed the issue:
[url "git@github.com:"]
        insteadOf = https://github.com/

git branch --set-upstream-to=origin/stable stable worked for me


Adding projects

There no java project in this repository for understanding multiple concepts together need to add them

@owais4321 assign this to me

@siraiwaqarali I have assigned you this issue happy coding <3

@owais4321 project added kindly check

is this issue open for contribution by everyone?


#21 - Typo: removing copy paste error in TextJobInitialiser.

Removed copy paste error in TextJobInitialiser

I have reviewed and found no problems.


[QUESTION]  disallow TLS disabled + basic auth

Hello,
First, I would like to thank you for this great project. It's always good to have FOSS alternatives to Windows-only, closed-source softwares.
I have a question about these lines of code (in configuration.go):
if Conf.Server.Authentication == "local" && Conf.Server.DisableTLS {
	log.Fatalf("basicauth=local and disabletls are mutually exclusive")
}

Is there a technical limitation that prevent using rdpgw behind a reverse proxy with a local authentication, or you did this to enforce end-to-end credentials encryption ?
Thank you

This is due to the latter. If you are terminating TLS at a proxy and have turned on basic authentication (as opposed to oauth) you are passing credentials in the clear over the network.

What I probably will do is allow "REMOTE_USER" to be set by a trusted proxy, so that authentication can happen at the proxy instead, so there is no need to deal with credentials.

OK thank you for you quick response.
But I have a question: if the reverse proxy and the gateway are on the same machine, it is not really a security issue to have cleartext connection between the two : an attacker would need to gain privileged access on the machine to capture traffic, so he would be able to access these credentials by other means anyway. In this case, wouldn't it be easier to just print a warning instead of a fatal error?

That's not entirely true. With perfect forward secrecy (pfs) an attacker would need to reconfigure the server to capture the traffic and decrypt it. Obviously this can be done, but it is another layer. Basically, I don't want people to shoot themselves in the foot by accidentally having an insecure config.  I intend to add to add ACME support (letsencrypt etc) to make obtaining certificates easier.

@pierre42100 ACME / Letsencrypt is now in.

Great, that's a good compromise, if the gateway can request itself a certificate. Thank you, I will close the issue then.