Bigint support.

Prerequisites

[x] Checked that your issue hasn't already been filed by cross-referencing issues with the faq label
[x] Checked next-gen ES issues and syntax problems by using the same environment and/or transpiler configuration without Mocha to ensure it isn't just a feature that actually isn't supported in the environment in question or a bug in your code.
[x] 'Smoke tested' the code to be tested by running it outside the real test suite to get a better sense of whether the problem is in the code under test, your usage of Mocha, or Mocha itself
[x] Ensured that there is no discrepancy between the locally and globally installed versions of Mocha. You can find them with: node node_modules/.bin/mocha --version(Local) and mocha --version(Global). We recommend that you not install Mocha globally.

Description
bigint is now a Stage 4 proposal but if you assert on a bigint Mocha fails during serialization of the error.  I don't know how to reproduce this issue without Chai, but the error context suggests that the problem is with Mocha's error serializer, not Chai.
Steps to Reproduce
const expect =  require('chai').expect

describe('test', () => {
	it('test', async () => {
		expect(1n).equals(0n)
	})
})

Expected behavior: [What you expect to happen]
Chai doesn't natively support bigint either (separate issue), but it at least doesn't error on reporting.  For now, I would expect to see Chai's worthless error message that at least pointed to the right test/line.
Actual behavior: [What actually happens]
  test
(node:14544) UnhandledPromiseRejectionWarning: TypeError: Do not know how to serialize a BigInt
    at JSON.stringify (<anonymous>)
    at _stringify (C:\Users\micah\Source\test\node_modules\mocha\lib\utils.js:409:20)
    at jsonStringify (C:\Users\micah\Source\test\node_modules\mocha\lib\utils.js:360:12)
    at Object.exports.stringify (C:\Users\micah\Source\test\node_modules\mocha\lib\utils.js:332:14)
    at stringifyDiffObjs (C:\Users\micah\Source\test\node_modules\mocha\lib\reporters\base.js:168:24)
    at Runner.<anonymous> (C:\Users\micah\Source\test\node_modules\mocha\lib\reporters\base.js:309:7)
    at Runner.emit (events.js:205:15)
    at Runner.fail (C:\Users\micah\Source\test\node_modules\mocha\lib\runner.js:304:8)
    at C:\Users\micah\Source\test\node_modules\mocha\lib\runner.js:673:18
    at done (C:\Users\micah\Source\test\node_modules\mocha\lib\runnable.js:334:5)
    at C:\Users\micah\Source\test\node_modules\mocha\lib\runnable.js:398:11
(node:14544) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 2)
(node:14544) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

Reproduces how often: [What percentage of the time does it reproduce?]
100%
Versions

The output of mocha --version and node node_modules/.bin/mocha --version: 6.2.2
The output of node --version: v12.3.0
Your operating system

name and version: Windows 10
architecture (32 or 64-bit): 64-bit

Your shell (e.g., bash, zsh, PowerShell, cmd): pwsh
Your browser and version (if running browser tests): N/A
Any third-party Mocha-related modules (and their versions): Chai 4.2.0
Any code transpiler (e.g., TypeScript, CoffeeScript, Babel) being used (and its version): No.

I mean, it looks like JSON.stringify() doesn't work with BigInt, right?  I really don't know how to get around that other than to e.g., coerce it into a string before handoff.

searching around, coercing to string looks like it's the workaround.
since we're using JSON.stringify() for "human-readable" diff display, I think taking a BigInt and turning it into something like: "BigInt<278934623894723>" might be our best bet. @MicahZoltu
What do you think?

Anything is better than the current situation.  😄  JSON.stringify accepts a function that will give you an opportunity to deserialize/stringify each value before it is passed along to the native stringifier.  You can handle bigints in there to avoid the exception.
As for how to render, what you suggested is fine.  I would also be fine with 123456n (how they are displayed in the console, just inside a string).  I have a minor preference towards 123456n just because it is the JS standard way to present bigints.  Since this is just for test failure output, I don't think it really matters much.

@boneskull  i made a pull request to solve this bug, can you review it?

I’m getting this issue with Node.js’s built-in assert.strictEqual function only when using with Mocha.
When running Node (v14.15.0) on the command line,
assert.strictEqual(0n, 1n);

I get the error:

Uncaught AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:
0n !== 1n

This is as expected, as the error reports what it should report.
But when running in Mocha (with gulp and ts-node):
import * as assert from 'assert'; // Node.js
describe('module', () => {
   it('test', () => {
      assert.strictEqual(0n, 1n);
   });
});

TypeError: Do not know how to serialize a BigInt
at JSON.stringify (<anonymous>)
at processImmediate (internal/timers.js:461:21)

Configurations: (click to expand)
Gulp file:

function test() {
	return gulp.src('./test/**/*.ts')
		.pipe(mocha({
			require: 'ts-node/register',
		}))
}

NPM dependencies:

  "devDependencies": {
    "@types/mocha": "^8.0.0",
    "@types/node": "^14.0.1",
    "gulp": "^4.0.2",
    "gulp-mocha": "^7.0.2",
    "gulp-typescript": "^5.0.1",
    "ts-node": "^9.0.0",
    "typescript": "~4.0.3"
  },

@chharvey If you use --no-diff to suppress Mocha’s own diff output, there should be no TypeError being thrown.

@juergba Thank you for providing a fix for this. But for the record, --no-diff didn’t work for me. I’m using gulp-mocha and passed in {diff: 'false'} (it needs to be a string because of how it serializes to CLI options) for the options object. I still got the TypeError instead of the expected AssertionError.
However, by wrapping the bigints in an array,
assert.deepStrictEqual([0n], [1n]);

this did give me the correct error.


counter-example canvas not aligned with the form

The canvas of the counter example gets out of the limits of the form.
A solution is either to enlarge the form or reduce the size of the counter example canvas.

I have fixed the canvas/window resize issue. Along with it I have been working on isssue #13 . The changes are almost done, except that I am unable to center the display of input LTSs. I haven't checked in the code the repos yet, instead I am sharing updated WAR here to see if there is any other issue. I did some testing using Mozilla Firefox and Chrome. I don't have access to Safari.
I will close #2 and #13 together, once I get the feedback. War attached.
transformation.zip
Thanks!

Using Safari Version 9.1.1 (11601.6.17) on OS X 10.11.5. The problem is still there. Further, depending on the zooming (rescaling the page using CMD - and CMD +, I get different relative sizes. See pictures.

@pascalpoizat Looks like the WAR you are using is not updated one. In the updated WAR, a modal dialog pops up to display input models (changes related to #13 )
Here is the link to the WAR - https://github.com/pascalpoizat/vbpmn/files/352422/transformation.zip

Attached screenshot for ref

I downloaded the war from the web page distribution. With the one from the source branch it is ok. However, the popups are not easy to close (at least on my browser) and solving issue #16 becomes very important.

Also you could consider having two buttons (one close to each model file choosing button) rather than a single one.

Thanks for the review. I tried to resize the modal and it doesn't work well enough. So I have changed the implementation, instead I have implemented a <div> toggle within the same page to hide/show input LTS models. I am closing this issue and we can further track in #13 #16
The updated code is available both on site and source repos.


ImportOrderChecker doesn't display the actual error messages

Hi,
I can see that in the codebase there is good error code but all I get is:
[warn] \persistence\src\main\scala\io\chumps\persistence\redis\RedisClientWrapper.scala:12:0: import.ordering.noEmptyLine.message
[warn] \service\src\main\scala\io\chumps\service\VideoService.scala:4:0: import.ordering.wrongOrderInGroup.message
[warn] \rest-api\src\main\scala\io\chumps\restapi\route\PostRoute.scala:9:0: import.ordering.wrongOrderInGroup.message

Cheers

This seems to be fixed. Closing.


[chore] remove overwritten property

The type specification for the keys property of Trail was defined twice (lines 10 and 18), and defined differently in each case. This PR removes what looks like the incorrect definition (which also didn't match its docstring, as keys can be a function that maps an item to its key).
This will also result in no behavioural change, as when multiple properties are defined with the same name in an object literal, the last one is used. So this deleted code was being ignored anyway.

(Full disclosure: I'm part of the team behind LGTM.com)

LGTM is awesome, never heard of it before but that seems insanely useful.

@samlanning btw, does it refresh automatically or does it need a new version tag or something? i've fixed most of these issues (some were false flags): https://github.com/drcmda/react-spring/commit/85b15f634ea4d987e0dfa57b24fa8179a714ddc9 but it still lists them


Steam Tinker Launch

Project description
Steam Tinker Launch is a Linux wrapper tool for use with the Steam client which allows customizing and start tools and options for games quickly on the fly (see Features)
Metadata

homepage URL: https://github.com/frostworx/steamtinkerlaunch
source URL: https://github.com/frostworx/steamtinkerlaunch
license: GPL-3.0
platforms: linux

I guess it's related to #73323 (partially, since it can also be used as launch command).

Yes true. You think we should merge these requests? Or is this different enough as it's also a launch command?


Documentation could do with updating for version 2

http://www.codeigniter.com/userguide2/libraries/form_validation.html
has the following (in the prepping data section)
$this->form_validation->set_rules('password', 'Password', 'trim|required|matches[passconf]|md5');
$this->form_validation->set_rules('passconf', 'Password Confirmation', 'trim|required');
This should be similar to the new docs
http://www.codeigniter.com/userguide3/libraries/form_validation.html
$this->form_validation->set_rules('password', 'Password', 'trim|required|md5');
$this->form_validation->set_rules('passconf', 'Password Confirmation', 'trim|required|matches[password]');
in order to correctly work when trimming. The first compares the trimmed password to a non trimmed passwordconf
example
"password " matches "password"
but
"password " does not match "password "
I can see there is a doc section for CI3 but that doesnt seem to exist for CI2 so can not send a pull request

edcc80714f87a3a793f79cc82e1148f75a2478bb


Matrices

[x] put option in extra matrices.
[x] parse matrices with different rows and columns

This is fixed in commit 12f85a60, release v4.0.

This is fixed in commit 12f85a60, release v4.0.


Only integer y-axis

Hi @Golodhros !
I have a question again. I have value = 1, I want only integer values to be displayed along the Y-axis.

Hi @Tonypz,
In D3.js, the amount of ticks is not completely controllable, but you can try some things.
Try first changing the format to a rounded format with '.numberFormat(".0")'.
Another thing you can try is to reduce the number of ticks with .yTicks(2)
Not sure if this is going to work though, it isn't something we can totally control.

.numberFormat('.0') After this string the error appears:

Interesting, I got it working on the CodePen, I will try to check on the sandbox today.

About the last my post - It was just syntax error, sorry. All is ok about .numberFormat('.0f') for barChart and .valueLabelFormat('.0f') for the StackedBarChart


Migrate Design Best Practices

All DBP posts are now available on liferay.design
Tags are now available to be used in any markdown file (Tag pages are automatically generated)

cc @abelhancock @liferay-design/managers

(fixes #493 )

❤


mcpp: fix build with clang 16

Description of changes
https://github.com/Homebrew/homebrew-core/commit/a0e87996291840a2c6971109ce48c4557bbae49a
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[x] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Emmm, the fix on the Homebrew side is weird: readlink is clearly available in <unistd.h>, how did the configure phase ignore it?

I've added a workaround from https://github.com/zeroc-ice/mcpp/commit/1c4b0f26614bff331eb8a9f2b514309af6f31fd0, which doesn't apply cleanly, however.

Result of nixpkgs-review pr 266390 run on aarch64-darwin 1

1 package marked as broken and skipped:

xquartz

1 package failed to build:

souffle

5 packages built:

mcpp
rxvt-unicode
rxvt-unicode-emoji
superTuxKart
xorg.xrdb


Disable the mtls_healthcheck test until it can be fixed.

util https://github.com/istio/istio/issues/12754 is fixed.

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: ozevren
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

tests/integration/OWNERS [ozevren]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/lgtm
/approve

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: incfly, ozevren
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

tests/integration/OWNERS [ozevren]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ozevren: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
6df099e6bac82cc43abdd50df4c456a982fbb6db
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ozevren: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
6df099e6bac82cc43abdd50df4c456a982fbb6db
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
6df099e6bac82cc43abdd50df4c456a982fbb6db
link
/test istio-pilot-multicluster-e2e

prow/istio-integ-k8s-tests.sh
6df099e6bac82cc43abdd50df4c456a982fbb6db
link
/test istio-integ-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Fix errors for at: "" and contenteditable

Make empty key string (at: "") work with contenteditable input.
http://manage.dimagi.com/default.asp?238911
This is not perfect yet, but it's at least usable and doesn't throw errors in the browser. Problems:

Autocomplete menu sometimes appears in top left corner of browser window.
Menu does not get filtered based on typing.

@emord

This seems reasonable to me although honestly I'm not too familiar with the code.
This branch is currently up for PR in the origin repo. I think it'd be better to have this PRd there separately and maybe using a dimagi controlled branch with both of our fixes. Alternatively we can use one of our forks with a branch with both of our updates. Thoughts?

new PR: https://github.com/ichord/At.js/pull/438
also merged https://github.com/emord/At.js/tree/res-branch with https://github.com/millerdev/At.js/tree/at-empty at https://github.com/millerdev/At.js/tree/master


style(ibl): update highlights for indent-blanklines

Use new (shortend) syntax for indent-blankline. (ibl)

Do we want to set coloring for IblWhitespace?

I think we should keep the old highlights around for backwards compatibility. As far as IblWhitespace, what it is set to by default? We may need to also set IblWhitespace under our transparency highlights to remove the background as well.

I have updated the PR and revert the old highlights, added the IblWhitespace and added ibl highlights to the transparency section.

Thank you for the updated highlights :)


Ensure DLL stub library is built.

This fixes ninja: error: 'libs/python3stub.lib', needed by 'bin/python3.dll', missing and no known rule to make it when building shared Python libraries for MS Windows.

Thanks for the patch :+1:  I will review and integrate tomorrow

Replaced by PR #240 so closing.


vis2.x: Filemanager missing

Describe the bug
Filemanager (Dateimanager) is missing

I can find it only in basic image-widget -> Quelle (but is hard to see)

Adapter version: ioBroker.vis v2.0.6
JS-Controller version: v4.0.23
Node version: v16.18.1
Operating system: ioBroker.docker v7.2.1

Added in 2.0.9, that already released

filemanager "files" is availabe in v2.0.9. upload and download works as expected.
thank you very much!


Sync softserve-develop with develop

PR Checklist
PR Structure

[ ] This PR has reasonably narrow scope (if not, break it down into smaller PRs).
[ ] This PR avoids mixing refactoring changes with feature changes (split into two PRs
otherwise).
[ ] This PR's title starts with name of package that is most changed in the PR, ex.
paymentservice.stellar, or all or doc if the changes are broad or impact many
packages.

Thoroughness

[ ] This PR adds tests for the most critical parts of the new functionality or fixes.

What
Sync softserve-develop with develop
Why
To keep softserve-develop branch up to date
Known limitations
[TODO or N/A]

Reference Server Preview is available here:https://anchor-ref-pr1013.previews.kube001.services.stellar-ops.com/SEP Server Preview is available here:https://anchor-sep-pr1013.previews.kube001.services.stellar-ops.com/

Reference Server Preview is available here:https://anchor-ref-pr1013.previews.kube001.services.stellar-ops.com/SEP Server Preview is available here:https://anchor-sep-pr1013.previews.kube001.services.stellar-ops.com/

Reference Server Preview is available here:https://anchor-ref-pr1013.previews.kube001.services.stellar-ops.com/SEP Server Preview is available here:https://anchor-sep-pr1013.previews.kube001.services.stellar-ops.com/

Can you check failed test?

Reference Server Preview is available here:https://anchor-ref-pr1013.previews.kube001.services.stellar-ops.com/SEP Server Preview is available here:https://anchor-sep-pr1013.previews.kube001.services.stellar-ops.com/

Reference Server Preview is available here:https://anchor-ref-pr1013.previews.kube001.services.stellar-ops.com/SEP Server Preview is available here:https://anchor-sep-pr1013.previews.kube001.services.stellar-ops.com/

Reference Server Preview is available here:https://anchor-ref-pr1013.previews.kube001.services.stellar-ops.com/SEP Server Preview is available here:https://anchor-sep-pr1013.previews.kube001.services.stellar-ops.com/

Reference Server Preview is available here:https://anchor-ref-pr1013.previews.kube001.services.stellar-ops.com/SEP Server Preview is available here:https://anchor-sep-pr1013.previews.kube001.services.stellar-ops.com/

Reference Server Preview is available here:https://anchor-ref-pr1013.previews.kube001.services.stellar-ops.com/SEP Server Preview is available here:https://anchor-sep-pr1013.previews.kube001.services.stellar-ops.com/

Reference Server Preview is available here:https://anchor-ref-pr1013.previews.kube001.services.stellar-ops.com/SEP Server Preview is available here:https://anchor-sep-pr1013.previews.kube001.services.stellar-ops.com/


Can't install another version of ruby

OS:
macOS BigSur 11.1 (20C69)
rbenv 1.1.2-40-g62d7798
I run command to install new version of ruby '$ rbenv install 2.7.2' and I got error

$ rbenv install 2.7.2
Downloading openssl-1.1.1i.tar.gz...
-> https://dqw8nmjcqpjn7.cloudfront.net/e8be6a35fe41d10603c3cc635e93289ed00bf34b79671a3a4de64fcee00d5242
Installing openssl-1.1.1i...
Installed openssl-1.1.1i to /Users/igork/.rbenv/versions/2.7.2
Downloading ruby-2.7.2.tar.bz2...
-> https://cache.ruby-lang.org/pub/ruby/2.7/ruby-2.7.2.tar.bz2
Installing ruby-2.7.2...
ruby-build: using readline from homebrew
BUILD FAILED (macOS 11.1 using ruby-build 20201225-4-g02ce13c)
Inspect or clean up the working tree at /var/folders/yq/0qgh9s2s3mv9mj8qcr1tndk00000gn/T/ruby-build.20210117184954.54049.ZDBDN6
Results logged to /var/folders/yq/0qgh9s2s3mv9mj8qcr1tndk00000gn/T/ruby-build.20210117184954.54049.log
Last 10 log lines:
linking shared-object openssl.bundle
linking shared-object ripper.bundle
./revision.h unchanged
linking ruby
make[1]: Nothing to be done for `note'.
Generating RDoc documentation
dyld: Library not loaded: /usr/local/opt/gmp/lib/libgmp.10.dylib
Referenced from: /var/folders/yq/0qgh9s2s3mv9mj8qcr1tndk00000gn/T/ruby-build.20210117184954.54049.ZDBDN6/ruby-2.7.2/ruby
Reason: image not found
make: *** [rdoc] Abort trap: 6

Output from log file:

raddrinfo.c:442:41: warning: implicit conversion loses integer precision: 'size_t' (aka 'unsigned long') to 'socklen_t' (aka 'unsigned int') [-Wshorten-64-to-32]
return getnameinfo(sa, salen, host, hostlen, serv, servlen, flags);
~~~~~~~~~~~                  ^~~~~~~
raddrinfo.c:442:56: warning: implicit conversion loses integer precision: 'size_t' (aka 'unsigned long') to 'socklen_t' (aka 'unsigned int') [-Wshorten-64-to-32]
return getnameinfo(sa, salen, host, hostlen, serv, servlen, flags);
~~~~~~~~~~~                                 ^~~~~~~
linking shared-object json/ext/parser.bundle
compiling ifaddr.c
linking shared-object date_core.bundle
compiling ossl_pkey_ec.c
compiling getaddrinfo.c
compiling ossl_pkey_rsa.c
linking shared-object json/ext/generator.bundle
compiling getnameinfo.c
getaddrinfo.c:410:7: warning: add explicit braces to avoid dangling else [-Wdangling-else]
} else if (strcmp(sp->s_proto, "tcp") == 0) {
^
installing default socket libraries
compiling ossl_rand.c
compiling ossl_ssl.c
compiling ossl_ssl_session.c
compiling ossl_x509.c
compiling ossl_x509attr.c
compiling ossl_x509cert.c
compiling ossl_x509crl.c
1 warning generated.
compiling ossl_x509ext.c
compiling ossl_x509name.c
compiling ossl_x509req.c
compiling ossl_x509revoked.c
compiling ossl_x509store.c
2 warnings generated.
linking shared-object socket.bundle
linking shared-object openssl.bundle
linking shared-object ripper.bundle
./revision.h unchanged
linking ruby
make[1]: Nothing to be done for `note'.
Generating RDoc documentation
dyld: Library not loaded: /usr/local/opt/gmp/lib/libgmp.10.dylib
Referenced from: /var/folders/yq/0qgh9s2s3mv9mj8qcr1tndk00000gn/T/ruby-build.20210117184954.54049.ZDBDN6/ruby-2.7.2/ruby
Reason: image not found
make: *** [rdoc] Abort trap: 6

Don't know how to fix the issue. Thank you in advance!

dyld: Library not loaded: /usr/local/opt/gmp/lib/libgmp.10.dylib
Reason: image not found

I fixed this by installing gmp with brew.
Background
It's unclear to me whether gmp is a dependency of ruby or not. It is not mentioned in the ruby-build docs, under
Suggested build environment.
It seems that when ruby is compiled, it will "opportunistically" link against gmp.  This can be disabled with the configure script's --without-gmp option. In fact, this is what homebrew's ruby package does, as of Sep. 2019 (https://github.com/Homebrew/homebrew-core/pull/43841)
Looking at the source of bin/ruby-build, the string "gmp" does not appear, so probably @hsbt et. al. have not made an explicit decision about whether to use the --without-gmp option yet.

having similar issue installing ruby 2.6.6 on big sur 11.6 w/m1 chip, though my last 10 log lines are different.  strange because around a month ago i was able to successfully install 2.7.4 via rbenv install.
Last 10 log lines:
6 warnings generated.
compiling ../.././ext/psych/yaml/parser.c
5 warnings generated.
422 warnings generated.
linking shared-object date_core.bundle
4 warnings generated.
linking shared-object zlib.bundle
1 warning generated.
linking shared-object psych.bundle
make: *** [build-ext] Error 2

in the logs i also found this actual error level message:
closure.c:264:14: error: implicit declaration of function 'ffi_prep_closure' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
    result = ffi_prep_closure(pcl, cif, callback, (void *)self);


Create a Carbon PR to contribute the DDS Link with icon component

User Story

As a [user role below]:
DDS engineer

I need to:
submit the Link with icon component to Carbon

so that I can:
find out whether Carbon will accept the DDS component in their repo

Additional information

Reach out to Matt Rosno and Joshua Black to take a look at the Link with icon component before creating the PR
It they aren't interested, close this issue.

Acceptance criteria

[ ] Carbon makes decision about whether they will add this component to their repo

Issue created on Carbon's end, as following Matt Rosno suggestion: https://github.com/carbon-design-system/carbon/issues/7708


changelog github action warning

Warning: Unexpected input(s) 'validation_depth', valid inputs are ['path', 'version']
Run mindsers/changelog-reader-action@e1a3684[2](https://github.com/macadmins/nudge/runs/6726266428?check_suite_focus=true#step:7:2)bddbd512340f882735802de843998e1f
Parse data

need to fix this but doesn't seem to impact anything for now. guessing author changed the keys.

should hopefully be fixed in next run


[ENG-2435] Upgrade pytest and others to fix broken tests

Purpose
This is a booster shot of updated decencies for the OSF for pytest, these such keep us more up to date with the current test infrastructure and hopefully fix some probabilistic test fails.
You can read about the bug here which indicates updating pytest will fix the issue. I picked pytest 5.0.0 because it is recent and only requires few changes. The biggest change is pytest no long allows passing of fixtures the same way. Read about it here. So that had to be changed to release this.
Changes

update pytest and related dependencies
turn fixtures into functions to appease pytest update

QA Notes
Please make verification statements inspired by your code and what your code touches.

Verify that travis tests pass as expected

What are the areas of risk?
Any concerns/considerations/questions that development raised?
Documentation

Side Effects
None that I know of.
Ticket
https://openscience.atlassian.net/browse/ENG-2435

Can you explain in the description why updating pytest fixed the test linked in the ticket? Also, more detail on what, specifically, pytest doesn't like about these fixtures now (seemingly it doesn't support using fixtures that aren't fully evaluated in test setup, a la via parametrize).

@jwalz ok I made some comments in the description


#12558: TTNN implementation of MNIST model

Ticket
Link to GitHub Issue
Problem description
TTNN implementation for MNIST model- WIP.
What's changed
ttnn support is enabled for mnist model along with demo, e2e and device test perf.
Checklist

[x] Post commit CI passes
[ ] Blackhole Post commit (if applicable)
[x] Model regression CI testing passes (if applicable)
[x] Device performance regression CI testing passes (if applicable)
[x] New/Existing tests provide coverage for changes

Please post CI links.

CI links:
(Single-card) Demo tests : n150 n300, n300 performance(In progress)
All post-commit tests : Link (All Passed)
(Single-card) Model perf tests : Link (All passed)
(Single-card) Device perf regressions : e150 , n300 (Mnist tests are passing)
Nightly fast dispatch tests : e150, n150, n300 (Mnist tests are passing)

Please fix the threshold for GS: https://github.com/tenstorrent/tt-metal/actions/runs/11934255399/job/33299918199#step:9:753
Please let us know when demo tests pass

@tt-rkim
Fixed the GS threshold.
I’ve triggered the CIs, and I’ll post the links as soon as I have them.

CI links
(Single-card) Demo tests : n150 n300, n300 performance
All post-commit tests : Link
(Single-card) Model perf tests : Link (All passed)
(Single-card) Device perf regressions : e150 , n300
Nightly fast dispatch tests : e150, n150, n300 (Mnist tests are passing)

Approved, but do we need to skip the device perf test for grayskull?

@tt-rkim
I have triggered CIs this morning, GS_Device perf  is passed.
(Single-card) Demo tests : Link
All post-commit tests : Link
(Single-card) Model perf tests : Link
(Single-card) Device perf regressions :Link
Nightly fast dispatch tests : Link (Latest run for failed jobs  is in progress)

Please ensure e2e perf test passes. Issue on main
Debug by @jbaumanTT and @pgkeller
Otherwise, keep the e2e perf test in a separate PR.

You can alternatively try putting the test first
I will unblock, but please ensure the test passes.

Model's perf is passing with today's triggered CIs. Below are the respective links .Please have a look.
(Single-card) Model perf tests:

Link(n300)(Mnist passed)
Link(e150)(Mnist passed)

MNIST single-device implementation has been merged into the main .


Add docstring command

Apologies if this already exists elsewhere!

I hadnt used any other language with docstrings, but just looked it up and it looks like Julia does https://docs.julialang.org/en/v1/manual/documentation/

There's also xmldoc stuff for C#, java and others that i frequently use, and consider similar enough even though it isn't really a language feature.

How's this?2

Looks good, thanks!


Update Colors in Theme

This PR Updates the Blue and Gray scales

Nice!
Do we want to merge it when we also add the greens, reds, and yellows? I have a working version of all colors already, expecting to finalize it with Colm tomorrow or so.

@vladmoroz Let's wait until we update the other colors then. Let me know 👍


Freeze block producer removals with more than 1000?

Look for ways to keep block producers flexible with high numbers, will asynchronous checks be enough and sustainable? Maybe cluster checks?

no, make block producer list accessible through batches


[Addition]: 603,235 added to the DenyList

Hotspot b58 Addresses
every hotspot address on the planet
Discord Handle
CSA_Mahone
Reason(s)
There is no perfect hotspot, either has wrong signal or the location doesn't show on th egoogle map exactly where is or it looks like earns too much or even too less, or people have too many  hotspots. The safe number is 1 per wallet/person/hex
No worries, if some are banned by mistake and added to the denylist   , they will be manually removed from the denylist. It might take a while to be back online, maybe a month or two , or few years but is all for the good. We do not want cheaters and bad spots in our lovely project. I am confident that this great and experienced team of admins who manage the denylist will agree with this proposal  and probably most of you will. Who doesn't ,it means he is a cheater and doesn't want the system to be clean of hackers or cheaters.
This is a very strong reason, "seemingly" all spots have problems and "I suspect" that nobody is correct 100%
Instead to check first he hotspots and then add them to the denyist it looks easier to ban all and then check, this is what we actually do right now and it works well.
Oh, it shall not matter to you who I am, if I have only one hotspot behind my lovely window in my condo, I just want my spot to make lots of HNT. I don't want to buy an antenna and put it on the roof or to go to people or friends and ask them if they can host my 2md or my 3rd hotspot. They might ask a lot of question and eventually a fee. Is not good at all to pay any fee, you all agree with me. I want my one and only hotsot to make hundereds of HNT so let's ban all hotspots . Is enough that I provide coverage in my bathroom and to my little cat.
I honestly got a little tired of hunting hotspots on the Helium explorer and submit request to add list and I start losing  at Minecraft cause I don't have time to play enough.
Forgot to tell you, like every week I create myslef another account on github cause some people are angry that I added them to the denylist in purpose or by mistake and I don't want anybody to track me down or the admins to ignore my requests.
I love thse admins with this denylist is better than minecraft , it gives me a purpose in real world and from time to time is actually a lot of fun to see how I anihilated lots of bobcats and sensecaps.. It's like a win in the defunct Simcity
Love you all,  and Greatness!  to our project and specially to this denylist that makes a lot us feel important and very useful.

#1671


fix: lint chained expressions after class or awaited expression (#62)

coverage: 91.592% (+0.03%) from 91.566%
when pulling 772c690cbc43a921333da899813c57c79158f15b on esmith/fluent-chaining-tail
into f2c5000c554619b9e444c9227a2bd95de2114ed9 on master.


Download error

dlc archive -a en-US -s all -r 1080p -o "{series_name} S{season_number}E{episode_number} - {title} [{height}p] [{audio}].mkv" -t 20 -m audio --include-fonts --skip-existing --skip-specials -y https://www.crunchyroll.com/series/GQWH0M1XK/the-weakest-tamer-began-a-journey-to-pick-up-trash
:: → Series The Weakest Tamer Began a Journey to Pick Up Trash is not available with ar-ME, ca-ES, en-IN, es-LA, hi-IN, ja-JP, ko-KR, pl-PL, pt-PT, ta-IN, te-IN, tr-TR, zh-CN, zh-CN, zh-TW subtitles
:: ✔ Loaded series information for url 1                                        :: The Weakest Tamer Began a Journey to Pick Up Trash Season 1 (The Weakest Tamer Began a Journey to Pick Up Trash (English Dub))
:: 	1. On a Journey Alone » S01E01
:: 	2.  » S01E02
:: 	3. Toward Those Remembered Days » S01E03
:: 	4. Toward an Unexpected Situation » S01E04
:: 	5. To Latome Village » S01E05
:: 	6. To Travel Beyond Imagination » S01E06
:: 	7. On a Path to Adventure » S01E07
:: 	8. To a Dangerous Town » S01E08
:: 	9. Toward a Confrontation with the Organization » S01E09
:: 	10.  » S01E10
:: An error occurred: parse error HEAD: Expecting  found  (https://pl.crunchyroll.com/evs3/2352a0930dc7cad38d3faf21265e927e/assets/a3cb26d4d8958ef7a369bee30ca11d06_,5393889.mp4,5393890.mp4,5393888.mp4,5393886.mp4,5393887.mp4,.urlset/manifest.mpd?Policy=eyJTdGF0ZW1lbnQiOlt7IlJlc291cmNlIjoiaHR0cCo6Ly9wbC5jcnVuY2h5cm9sbC5jb20vZXZzMy8yMzUyYTA5MzBkYzdjYWQzOGQzZmFmMjEyNjVlOTI3ZS9hc3NldHMvYTNjYjI2ZDRkODk1OGVmN2EzNjliZWUzMGNhMTFkMDZfLDUzOTM4ODkubXA0LDUzOTM4OTAubXA0LDUzOTM4ODgubXA0LDUzOTM4ODYubXA0LDUzOTM4ODcubXA0LC51cmxzZXQvbWFuaWZlc3QubXBkIiwiQ29uZGl0aW9uIjp7IkRhdGVMZXNzVGhhbiI6eyJBV1M6RXBvY2hUaW1lIjoxNzEwNzY3ODUzfX19XX0_&Signature=WrMHLCn4Wcfkb4~ML1ZBcTiPQu-kPnvj708zlqsjSwbu0Rh8b-JTFpNhG5E-2J9EQDsHwQ1PUY2rkFnri4B-wBDMFHMEOcMwoPYGuuIhkyvD6h2SgeT~8AXkmIPbxqUh0LnoL-49V4RP5dT4bVs-AqfgEYB7m3kvC0IiUPRWsWcelvu6mIESQvHSu4gTHHn-adfk~7pz6M2rCB4AKNGLaWXJaPeD8Ske714rNdpVzoIHya8DSmaUJk-DFdnviN-lf-1Bz-NqiMT7SkJB7DX8UQMm98U5TNTbM8ervrBwPlINkK~-fNqhWnFJuuZDF36t~K1EpPLiIk6Qw0vfFZ5BSw__&Key-Pair-Id=APKAJMWSQ5S7ZB3MF5VA):

ERROR: The request could not be satisfied

403 ERROR
The request could not be satisfied.

Request blocked.
We can't connect to the server for this app or website at this time. There might be too much traffic or a configuration error. Try again later, or contact the app or website owner.

If you provide content to customers through CloudFront, you can find steps to troubleshoot and help prevent this error by reviewing the CloudFront documentation.

Generated by cloudfront (CloudFront)
Request ID: QeERXHugEdHT8GnB5R8Ye_qG1UdA1pxyakmnH3OnREvBUj93VX40qQ==

![Screenshot_20240316_184805_Brave](https://github.com/crunchy-labs/crunchy-cli/assets/154334918/30baf21f-ab9e-4c78-af97-92f82dd1bedd)

bruh, they literally closed your las post as duplicate of https://github.com/crunchy-labs/crunchy-cli/issues/355 - 2 hours ago

As said, your issue is a duplicate. I will loll into it when I have time


Azure Failed to Initialize Enumerator: Failed to List Containers

Which version of the AzCopy was used?
10.17.0
Which platform are you using? (ex: Windows, Mac, Linux)
Windows
What command did you run?
PS C:\WINDOWS\system32> azcopy copy "C:\Users\kmace\Documents" "https://3c25260d93834c7fa902eac.blob.core.windows.net/ingestiondata?sv=redacted" --recursive=true --from-to BlobFile
What problem was encountered?
failed to perform copy command due to error: failed to initialize enumerator: failed to list containers: -> github.com/Azure/azure-pipeline-go/pipeline.NewError, /home/vsts/go/pkg/mod/github.com/!azure/azure-pipeline-go@v0.2.4-0.20220425205405-09e6f201e1e4/pipeline/error.go:157
HTTP request failed
Get "c:?comp=list&timeout=901": unsupported protocol scheme "c"
How can we reproduce the problem in the simplest way?
I'm not sure.
Have you found a mitigation/solution?
No, I tried adding permissions, adding a directory on a remote hard drive, on my personal computer, to a folder, to a specific pst file, adding a subfolder after "ingestiondata", and anything else I could think of.

@kelseyazure. Your fromto is incorrect here. Since you are transferring from Local to Blob, it should be LocalBlob

file indicates the Azure Files service, which is definitely not what we want to do here since you are uploading from Local. Could you remove the --from-to and share the full logs (including scanning if it gets to that point) you get? Setting to debug logging would help.

Use "azcopy [command] --help" for more information about a command.
PS C:\WINDOWS\system32> azcopy login
To sign in, use a web browser to open the page https://microsoft.com/devicelogin and enter the code REDACTED to authenticate.
INFO: Logging in under the "Common" tenant. This will log the account in under its home tenant.
INFO: If you plan to use AzCopy with a B2B account (where the account's home tenant is separate from the tenant of the target storage account), please sign in under the target tenant with --tenant-id
INFO: Login succeeded.
PS C:\WINDOWS\system32> azcopy copy "C:\Users\kmace\Documents" "<https://3c25260d93834c7fa902eac.blob.core.windows.net/ingestiondata?sv=[SAS Redacted]>" --recursive=true
INFO: The parameters you supplied were Source: 'C:\Users\kmace\Documents' of type Local, and Destination: 'https://3c25260d93834c7fa902eac.blob.core.windows.net/ingestiondata?sv=2015-04-05&sr=c&si=IngestionSasForAzCopy202303151721589683&sig=-REDACTED-&se=2023-04-14T17%3A22%3A00Z' of type Local
INFO: Based on the parameters supplied, a valid source-destination combination could not automatically be found. Please check the parameters you supplied.  If they are correct, please specify an exact source and destination type using the --from-to switch. Valid values are two-word phases of the form BlobLocal, LocalBlob etc.  Use the word 'Blob' for Blob Storage, 'Local' for the local file system, 'File' for Azure Files, and 'BlobFS' for ADLS Gen2. If you need a combination that is not supported yet, please log an issue on the AzCopy GitHub issues list.
failed to parse user input due to error: the inferred source/destination combination could not be identified, or is currently not supported/destination combination could not be identified, or is currently not supported
I'm not sure how you set it to debugging.

@kelseyazure Have you tried setting --from-to to LocalBlob? Does it result in the same error?

This is what I get when I try:
PS C:\WINDOWS\system32> azcopy copy "C:\Users\kmace\Documents" "<https://3c25260d93834c7fa902eac.blob.core.windows.net/ingestiondata?sv=[SAS Redacted]>" --recursive=true --from-to LocalBlob
INFO: Scanning...
INFO: Autologin not specified.
failed to perform copy command due to error: the URL requires authentication. If this URL is in fact an Azure service, you can enable Azure authentication to . To enable, view the documentation for the parameter --trusted-microsoft-suffixes, by running 'AzCopy copy --help'. BUT if this URL is not an Azure service, do NOT enable Azure authentication to it. Instead, see if the URL host supports authentication by way of a token that can be included in the URL's query string

These are the Role Assignments that I added yesterday

Are you including the <> in the command? If so, please remove those and try again. AzCopy just requires "" around the source and destination

That was it! That was my fault for interpreting the format given by https://learn.microsoft.com/en-us/microsoft-365/compliance/use-network-upload-to-import-pst-files?view=o365-worldwide#optional-step-3-view-a-list-of-the-pst-files-uploaded-to-microsoft-365 as needing the < and > before and after the URL.
azcopy.exe copy "" ""
Thank you so much!


Avoid forming deadlock when steam drains upon device switching

This solves the deadlock mentioned in BMO 1572273 comment 6. It's very
likely to have a deadlock when the output callback tries to stop the
input AudioUnit when the input device is unplugged during the duplex
stream is working.
When the input device is unplugged, the stream will be reinitialized and
the AudioUnits will be stopped then. Hence we could only feed silence to
the output buffer and let stream reinit stop the AudioUnits.

Thanks, this is exactly what we discussed. A new question came up and I would like your opinion. If the stream has drained, should reinit start the newly updated stream? With that fix, does the status callback report a drain and then the stream restarts?

Also, I am looking at the rust code and the logic there seems similar to this backend. I am wondering why the error does not reproduce in rust. Is it due to different timing or I am missing something?

Also, I am looking at the rust code and the logic there seems similar to this backend. I am wondering why the error does not reproduce in rust. Is it due to different timing or I am missing something?

I've put my answer in the BMO 1572273 comment 6.

With that fix, does the status callback report a drain and then the stream restarts?

Yes. The drain is set by GraphDriver so the stream state is still drained. With the fix, the output callback will feed the silence to output buffer directly without stoping the AudioUnit and canceling the callback. Next, the stream reinit will work as usual. It will stop and then restart the AudioUnits. Finally, (technically) there are two cases to stop the stream and cancel the callback.

if the stream shutdown task comes before the output callback, then the AudioUnits will be stopped and there are no callbacks anymore.
if the output callback comes before the stream shutdown task, output callback will stop the AudioUnits since the state is still drained.

If the stream has drained, should reinit start the newly updated stream?

I could add a check for stm->draining. If it's drained, reinit can simply stop the AudioUnits and do nothing more. In that case, the output callback won't be fired and stream shutdown task will be called without racing with output callback.

Thank you for the information so far. I gave it a try this morning and I found out that the drain logic inside the callback is odd. I create a couple of patches to improve it and to solve this error. You can find the patches here. Can you please test them and tell me if the problem is solved. If I had your device I would have tested myself. If the problem is solved please let me know what you think about the patches and if I should push them for review.

Thank you for the information so far. I gave it a try this morning and I found out that the drain logic inside the callback is odd.

Sorry, I change my mind. I think adding the reinit stuff into callback makes things more complicated.
I think we can stop the AudioUnits in their own callbacks. The callback will definitely hold the corresponding CAMutex so deadlock won't be formed by requiring that CAMutex.
The try result is here: https://treeherder.mozilla.org/#/jobs?repo=try&revision=fdc52c30096e03312535bb507774db6d73684d64

You can find the patches here.

I think it's good to add a force-drain test, but how do you simulate the unplug event that causes the deadlock?

This solves the deadlock mentioned in BMO 1572273 comment 6.

Sorry for the force update. I should leave it as a reference for the discussion. The original patch could be found here: https://treeherder.mozilla.org/#/jobs?repo=try&revision=8b2368127419bb229a9a42fd07fb2883ca4a580f

I think it's good to add a force-drain test, but how do you simulate the unplug event that causes the deadlock?

I do not simulate that. Even if I tested unplugging manually, I am unable to test your scenario without your device. I would rely on you to test my patches with your device if you can.

Since #529 confused the things let's finish this one first and I'll take care of it later. I was rushing to push everything before PTO and mixed them all together.
Regarding the deadlock, the fix looks good, since you report that is gone. My concern is about restarting the stream when we should not. Since the stream has drained we need to end up with a drained stream.
I am thinking of using the stm->reinit_pending flag to exit early any input/output callback during reinit. This will allow the drain to appear after the end of reinit and the new (reinited) stream will be drained/stopped as expected.
Let me know what you think and ping me if you have questions. Thanks!

I am looking at it further and I am realizing that the drain after reinit problem mentioned above exists regardless of your fix. Thus I'll go on and r+ this one. I will raise an issue for the reinit problem.

This is ready, I'm gonna merge it. Thanks


Calculate exchange-correlation energy with pyscf pbc dft

Hello there,
Is pyscf pcb dft is able to output exchange correlation energy? I'm talking about the term $E_{xc}$ in the wikipeida article of Kohn-Sham equations.
If you know the answer, please let me know. Here is an example code which you can base your answer on.
import pyscf
from pyscf.pbc import gto, dft
from pyscf import data
import numpy as np
"""
This part of the code makes a cube unit cell and random coordinates for two carbon atoms.
"""

cell = gto.Cell()

arr_R = np.random.rand(2,3)
arr_cell = np.eye(3)

cell.a = "\n".join([f"{ str(ai).strip('[]') }" for ai in arr_cell])
cell.atom = "\n".join([ f"C  { str(r).strip('[]') }" for r in arr_R])
cell.verbose = 4
cell.basis = 'gth-szv'
cell.pseudo = 'gth-pade'
cell.build()

"""
This part of the code solves  KS eqns. Note that the conv_tol is quite low
"""

mf = dft.RKS(cell)
mf.conv_tol = 1e-3
mf.kernel()

Yes, there are many ways to print Exc. Here are three of them (from a molecular DFT example):
import pyscf

mol = pyscf.M(
    atom = 'H 0 0 0; F 0 0 1.1',  # in Angstrom
    basis = '631g',
    symmetry = True,
)

mf = mol.KS()
mf.xc = 'b3lyp'

# Option 1
mf.verbose = 5  # or greater
mf.kernel()
# prints
# E1 = -149.144793099709  Ecoul = 55.221987813905166  Exc = -10.795600933355782

# Option 2
mf.verbose = 4  # or greater
mf.analyze()
# prints
# **** SCF Summaries ****
# Total Energy =                        -100.388774493450526
# Nuclear Repulsion Energy =               4.329631725709090
# One-electron Energy =                 -149.144793099709005
# Two-electron Coulomb Energy =           55.221987813905166
# DFT Exchange-Correlation Energy =      -10.795600933355782

# Option 3
print(mf.scf_summary['exc'])

Thanks for your answer. Are you sure of that? How confident do you feel that this number is $E_{xc}$?

Yes, there are many ways to print Exc. Here are three of them (from a molecular DFT example):
import pyscf

mol = pyscf.M(
    atom = 'H 0 0 0; F 0 0 1.1',  # in Angstrom
    basis = '631g',
    symmetry = True,
)

mf = mol.KS()
mf.xc = 'b3lyp'

# Option 1
mf.verbose = 5  # or greater
mf.kernel()
# prints
# E1 = -149.144793099709  Ecoul = 55.221987813905166  Exc = -10.795600933355782

# Option 2
mf.verbose = 4  # or greater
mf.analyze()
# prints
# **** SCF Summaries ****
# Total Energy =                        -100.388774493450526
# Nuclear Repulsion Energy =               4.329631725709090
# One-electron Energy =                 -149.144793099709005
# Two-electron Coulomb Energy =           55.221987813905166
# DFT Exchange-Correlation Energy =      -10.795600933355782

# Option 3
print(mf.scf_summary['exc'])

Thanks for your answer. Are you sure of that? How confident do you feel that this number is $E_{xc}$?

Very confident.

Thanks for your answer. The reason I'm asking is that the number you cite is always equal to the quantity called excsum described in this thread. But as $E_{xc} \neq \int V_{xc} \rho dr$ either the other developer of yourself seem to be mistaken. Was I able to explain the concern?

Agreed, $E_{xc} \neq \int d^3r V_{xc}(r) \rho(r)$ (i.e., these are not expected to be equal). I'm quite sure that excsum is collecting contributions to the integral that produces the exchange-correlation energy. It is not calculating $\int d^3r V_{xc}(r) \rho(r)$.

The exc return by libxc is the XC energy per particle. However, vxc from libxc is not $\frac{\delta e_{xc}}{\delta \rho}$. It's actually $\frac{\delta e_{xc}}{\delta \rho} + e_{xc}$, not the usual vxc in literature. Please see libxc document for details.

This reply makes me believe that
excsum is $\int e_{xc} \rho dr = E_{xc}$ as tberkel said. Can you confirm sunqm?
excsum is not $\int \frac{\delta E_{xc}}{\delta \rho} \rho dr$, and the answer to this thread is false.
If I have understood correctly, may the other thread be supported with an answer?

It is absolutely correct as @tberkel says


Fix: Snomed expanded properties are missing

Codecov Report

Merging #970 (8332aa1) into 8.x (751170e) will increase coverage by 0.03%.
The diff coverage is 100.00%.

:exclamation: Current head 8332aa1 differs from pull request most recent head 1607b48. Consider uploading reports for the commit 1607b48 to get more accurate results

@@             Coverage Diff              @@
##                8.x     #970      +/-   ##
============================================
+ Coverage     64.47%   64.50%   +0.03%
- Complexity    11791    11800       +9
============================================
  Files          1689     1689
  Lines         55437    55438       +1
  Branches       5117     5117
============================================
+ Hits          35742    35762      +20
+ Misses        17508    17486      -22
- Partials       2187     2190       +3

Impacted Files
Coverage Δ

...datastore/request/SnomedConceptCachingRequest.java
100.00% <100.00%> (ø)

.../b2international/index/es/client/EsClientBase.java
65.88% <0.00%> (-1.18%)
:arrow_down:

...d/datastore/request/SnomedConceptRequestCache.java
72.72% <0.00%> (+1.81%)
:arrow_up:

...onal/snowowl/snomed/core/tree/TerminologyTree.java
87.75% <0.00%> (+2.04%)
:arrow_up:

...c/com/b2international/index/revision/ObjectId.java
84.00% <0.00%> (+4.00%)
:arrow_up:

...ed/datastore/converter/SnomedConceptConverter.java
91.92% <0.00%> (+4.03%)
:arrow_up:

...owl/snomed/datastore/converter/ModuleExpander.java
100.00% <0.00%> (+57.14%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 751170e...1607b48. Read the comment docs.


Reactome proteins have Biolink category MolecularEntity; should be Protein

For example:
        {
            "id": "REACT:R-HSA-9720659",
            "iri": "https://identifiers.org/reactome:R-HSA-9720659",
            "name": "TP53 F109Sfs*14 [nucleoplasm]",
            "full_name": "TP53 F109Sfs*14 [nucleoplasm]",
            "category": "biolink:MolecularEntity",
            "category_label": "molecular_entity",
            "description": null,
            "synonym": [],
            "publications": [],
            "creation_date": "2021-03-18 14:40:01",
            "update_date": "2021-08-26 15:53:48",
            "deprecated": false,
            "replaced_by": null,
            "knowledge_source": "identifiers_org_registry:reactome",
            "has_biological_sequence": null
        },

this issue was reported by Chris Bizon, via https://github.com/RTXteam/RTX/issues/1772

also noticed a lot of these errors in passing, which look fixable:
The source Guide to Pharmacology is not in the name_prefix_dict

should be fixed by 1f5c517; @acevedol can you test in the next build, please?

After commit 1f5c517, looks like this:
        {
            "id": "REACT:R-HSA-9720659",
            "iri": "https://identifiers.org/reactome:R-HSA-9720659",
            "name": "TP53 F109Sfs*14 [nucleoplasm]",
            "full_name": "TP53 F109Sfs*14 [nucleoplasm]",
            "category": "biolink:Protein",
            "category_label": "protein",
            "description": null,
            "synonym": [],
            "publications": [],
            "creation_date": "2021-03-18 14:40:01",
            "update_date": "2021-08-26 15:53:48",
            "deprecated": false,
            "replaced_by": null,
            "knowledge_source": "identifiers_org_registry:reactome",
            "has_biological_sequence": null
        },

Pending clarification from Sierra Moxon, I am switching protein-like drugs (from Reactome and DrugBank) to biolink:ChemicalEntity rather than biolink:Protein, for consistency with our previous curation.


Error encountered upon updating to version 4.2.4: XL models fail to execute.

Is there an existing issue for this problem?

[X] I have searched the existing issues

Operating system
Linux
GPU vendor
Nvidia (CUDA)
GPU model
NVIDIA GeForce RTX 3060 Mobile
GPU VRAM
6GB
Version number
4.2.4
Browser
Edge 125.0.2535.92
Python dependencies
{
"accelerate": "0.30.1",
"compel": "2.0.2",
"cuda": "12.1",
"diffusers": "0.27.2",
"numpy": "1.26.4",
"opencv": "<IP_ADDRESS>",
"onnx": "1.15.0",
"pillow": "10.3.0",
"python": "3.10.12",
"torch": "2.2.2+cu121",
"torchvision": "0.17.2",
"transformers": "4.41.1",
"xformers": "0.0.25.post1"
}
What happened
Hello, previously you were utilizing version 4.2.3 featuring XL models intended for installation (Juggernaut-XL-v9 and dreamshaper-xl-v2-turbo), encountering no issues except for model installations. However, upon upgrading to version 4.2.4, which purportedly includes optimizations addressing the model installation issue, the problem persists. Now, there's an additional error when executing Juggernaut-XL-v9 and dreamshaper-xl-v2-turbo. Instead of the expected improvements, these optimizations seem to have adversely affected functionality, compelling me to revert to the prior version. I urge you to address this issue promptly, as the anticipated resolution for Civitai model installation errors has not materialized; in fact, functionality has been compromised entirely

What you expected to happen
I was hoping that with this update, the issue of being unable to generate images with models downloaded from Civitai would have been resolved.
How to reproduce the problem
downlad models of civitai
Additional context
No response
Discord username
No response

This error isn't related to model installation. It's saying your GPU does not have enough VRAM. We don't expect SDXL models to work with a 6GB card - you need 8GB VRAM.

but in the previous version, I could use it with 6 GB of VRAM, and now I can't. That's the point. This is forcing me to install the previous version, which does give me results.


I finished pnorm, qnorm function, please review.

Can I also request for the docstring to follow the numpydoc style format? It is something that we are more familiar with in MDS? Something like this..
Parameters
word_counts : collections.Counter
Counter object of word counts.
n : int, optional
Plot the top n words. By default, 10.


VAC Error

Cheat is blocking vac systems and randomly disconnects me from games.

Nope, it's not.

it is... cus its been doing it for me.

you account may be subject to vac deep scans or you're just being VAC Authed.

Check game cache, change your injector, use manual map injector


ktlint exception when using java 9

Using ktlint from brew, version 0.15.0.  Works fine on Java 8, switched to Java 9 using jenv and get the following error.
Exception in thread "Thread-0" java.util.concurrent.ExecutionException: java.lang.NoClassDefFoundError: Could not initialize class com.github.shyiko.ktlint.core.KtLint
	at java.base/java.util.concurrent.FutureTask.report(FutureTask.java:122)
	at java.base/java.util.concurrent.FutureTask.get(FutureTask.java:191)
	at com.github.shyiko.ktlint.Main$parallel$consumer$1.run(Main.kt:614)
	at java.base/java.lang.Thread.run(Thread.java:844)
Caused by: java.lang.NoClassDefFoundError: Could not initialize class com.github.shyiko.ktlint.core.KtLint
	at com.github.shyiko.ktlint.Main.lint(Main.kt:585)

Command is simply: ktlint

#153 merged in but there are still couple of things that need to be fixed before this ticket can be closed:
$ ./ktlint/target/ktlint --version
null
 shyiko@shyiko-laptop  /tmp/ktlint master
$ ./ktlint/target/ktlint
WARNING: An illegal reflective access operation has occurred
WARNING: Illegal reflective access by org.jetbrains.kotlin.com.intellij.util.text.StringFactory (file:/tmp/ktlint/ktlint/target/ktlint) to constructor java.lang.String(char[],boolean)
WARNING: Please consider reporting this to the maintainers of org.jetbrains.kotlin.com.intellij.util.text.StringFactory
WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations
WARNING: All illegal access operations will be denied in a future release

The exception and the version showing  have been fixed. What’s remaining is the illegal reflective access. This is a Kotlin compiler that has already been resolved upstream KT-19051 and will land when Kotlin 1.2.30 is released.
@shyiko do you have any plans for a release that is compatible with java 9?

@ifrins as soon as Kotlin 1.2.30 is out

UPDATE:
0.16.0 released with @ifrins fixes included (thank you once again, Francesc!).
<EMAIL_ADDRESS>hasn't been released yet so "An illegal reflective access operation has occurred" warning is still printed (to stderr) but other than that it appears to be working.

<EMAIL_ADDRESS>with<EMAIL_ADDRESS>is out. Java 9 support is now official. Thanks everyone :bowing_man:

what about jdk 11?


OnEnable added to hot change transport

I reached a situation in my project where I wanted to have SteamyFizzyTransport for online play but also telepathy to LAN matches.
It was weird to disable TelepathyTransport and then on trying to start steamfizzy transport I got Telepathy enabled again, so, watching through the code I discovered that NetworkManager enables the Transport.activeTransport, so I was thinking that if anyone Enable a transport that will have to change to be the active

can you try our MultiplexTransport instead?
and under which condition do you decide which transport to use? based on IP address range?

@Xuzon  I just added documentation for the MultiplexTransport
https://vis2k.github.io/Mirror/Transports/Multiplexer
take a look and see if that suits your needs.

I've tried the multiplex transport.
SteamyFizzyTransport needs a CSteamID in the networkAddress so when I fill with an IP an expection is thrown, also, Telepathy needs an ip so with the CSteamID a message is thrown.
Maybe the networking works even with the SteamyFizzyTransport exception but I don't like to have exceptions over my code,
I've made some tests today and I could play with steam online or in local with telepathy, but I think this commited code will have conflicts with the MultiplexTransport because the last OnEnable transport will be the choosen one leading to situations where MultiplexTransport is not used even if its desired.
I could do a check if the current ActiveTransport is a MultiplexTransport instance to decide if override or not.

think this commited code will have conflicts with the MultiplexTransport because the last OnEnable transport will be the choosen one leading to situations where MultiplexTransport is not used even if its desired.

that would be a problem.

I reached a situation in my project where I wanted to have SteamyFizzyTransport for online play but also telepathy to LAN matches.

so how do other steam games handle that? can't you use the steam transport on LAN too?
and what if someone is on LAN but also has an internet connection?
this is a very specific situation.
I think you should try to create your own OnlineVsLan multiplex transport that calls the right transport depending on IP. this situation is so specific that we probably shouldn't worry about this by default, especially if this breaks multiplex transport.
closing this for now, sorry. please try your own multiplex transport and get back to us if that's no solution either :)


Extra buttons when reloading config

Just as the title says, every time you reload the hyprland config, there is a new set of buttons spawned. I'm using the hyprland-git from AUR, which i update daily. This was not happening a week or so ago.
Here's my plugin.conf:
plugin {
    hyprbars {
        bar_height = 24
        bar_color = $background
        col.text = $foreground
        bar_title_enabled = yes
        bar_text_font = JetBrains Nerd Font
        bar_text_size = 10
        bar_text_align = center
        bar_buttons_alignment = right
        bar_part_of_window = yes
        bar_precedence_over_border = yes
        bar_padding = 5
        bar_button_padding = 5

        # hyprbars-button = color, size, on-click
        hyprbars-button = $color2, 16, 󰖭, hyprctl dispatch killactive
        hyprbars-button = $color5, 16, 󰖯, hyprctl dispatch fullscreen 1
        hyprbars-button = $color7, 16, 󰫳, hyprctl dispatch togglefloating
    }
}

This is not a showstopper, but still slightly annoying with my setup. Let me know if there's any other info i can provide.

dupe and already fixed #155


introduce reset.css

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Feature: use reset.css to reset browser

What is the current behavior? (You can also link to an open issue here)

What is the new behavior (if this is a feature change)?

Other information:

Good idea, although I'd vote for normalize.css instead (https://www.npmjs.com/package/normalize.css)

here is for normalize.css
https://github.com/AngularClass/angular2-webpack-starter/pull/521

thanks! closing for #521


Upgrade to Ruby 3.1.2

Codeclimate has a lot of complaints.
But as far as tests, this seems like smooth sailing, except there's a missing i18n tag reported.
 FAIL AccountControllerTest#test_api_key_manager (35.76s)
        Language tag(s) are missing..
        Expected: []
          Actual: [:key]
        test/test_helper.rb:141:in `teardown'

Coverage remained the same at 92.653% when pulling 789bce5a2b56dc165662b124f4554811467db9f4 on nimmo-ruby-3.1 into 428c1ae22b34b67ee316631107ed89be5591a4ff on master.


Skip flaky ScrollView tests

Test plan: Integration tests pass on Circle CI:
https://circleci.com/gh/facebook/react-native/16493?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link

@facebook-github-bot shipit-ninja


Bot how to send important/urgent  message to one person

Hi All, my Bot can send proactive message to people now, but I want to mark the message as urgent,

Are there any properties I can change? I checked the Activity class, no category I can set, could you give me some advice, thanks!

@XimenaWang , Currently, this is not possible to mark a message !IMPORTANT  through bot, However you can @mention user to notify them but that works within team or channel conversation.

@XimenaWang , Currently, this is not possible to mark a message !IMPORTANT  through bot, However you can @mention user to notify them but that works within team or channel conversation.

Hi team, we have implemented the mention feature in channel, and just want to know if ms teams can support the !IMPORTANT feature in personal conversation. if it can' t support now, would you mind tell me when this feature will be available in the future , thank you in advance!

@XimenaWang , Thanks for the update, Currently marking a message !IMPORTANT is not possible through bot, You can directly notify the user in 1:1 conversation using bot. Please raise a uservoice so we can take this as feature request.

ok, I created one in uservoice, waiting the new feature, thanks for your response


type_id=3 vlen != 0 on 5.4 LTS kernel

Hi team,
when using the bleeding edge bpftrace static build on a centos7 with elrepo kernel (5.4/6.6)
I found that bt scripts with BEGIN {} is not working on bleeding bpftrace 0.19.0 binary combined 5.4 kernel.
I also tried from https://repos.baslab.org/rhel/7/bpftrace-daily/
bpftrace-0.14.1-1.202204049382ad1.el7.x86_64 , and it's working

0.19.0 + 5.4 lts kernel
0.19.0 + 6.6 lts kernel
0.14.1 + 5.4 lts kernel

/2) and 3) are good.
/1) is not working.
./bpftrace -v -e 'BEGIN {printf("Hello eBPF"); exit();}'
INFO: node count: 8
Attaching 1 probe...
Error log:
magic: 0xeb9f
version: 1
flags: 0x0
hdr_len: 24
type_off: 0
type_len: 76
str_off: 76
str_len: 50
btf_total_size: 150
[1] PTR (anon) type_id=2
[2] INT int8 size=1 bits_offset=0 nr_bits=8 encoding=SIGNED
[3] FUNC_PROTO (anon) return=4 args=(1 var1)
[4] INT int64 size=8 bits_offset=0 nr_bits=64 encoding=SIGNED
[5] FUNC BEGIN type_id=3 vlen != 0
ERROR: Error loading program: BEGIN
[root@VM-224-24-centos bpftrace-bleeding-edge]# uname -r
5.4.266-1.el7.elrepo.x86_64
=====
./bpftrace -v -e 'BEGIN {printf("Hello eBPF"); exit();}'
INFO: node count: 8
Attaching 1 probe...
Program ID: 4
The verifier log:
processed 60 insns (limit 1000000) max_states_per_insn 0 total_states 4 peak_states 4 mark_read 2
Attaching BEGIN
Hello eBPF
[root@VM-224-24-centos bpftrace-bleeding-edge]# uname -r
6.6.10-1.el7.elrepo.x86_64
===== bpftrace --info on 5.4 lts kernel =====
System
OS: Linux 5.4.266-1.el7.elrepo.x86_64 #1 SMP Mon Jan 8 23:23:50 EST 2024
Arch: x86_64
Build
version: v0.19.0
LLVM: 17.0.6
unsafe probe: no
bfd: yes
libdw (DWARF support): yes
libbpf: failed to find valid kernel BTF
Kernel helpers
probe_read: yes
probe_read_str: yes
probe_read_user: no
probe_read_user_str: no
probe_read_kernel: no
probe_read_kernel_str: no
get_current_cgroup_id: yes
send_signal: yes
override_return: yes
get_boot_ns: no
dpath: no
skboutput: no
get_tai_ns: no
get_func_ip: no
jiffies64: no
Kernel features
Instruction limit: 1000000
Loop support: yes
btf: no
module btf: no
map batch: no
uprobe refcount (depends on Build:bcc bpf_attach_uprobe refcount): yes
Map types
hash: yes
percpu hash: yes
array: yes
percpu array: yes
stack_trace: yes
perf_event_array: yes
ringbuf: no
Probe types
kprobe: yes
tracepoint: yes
perf_event: yes
kfunc: no
kprobe_multi: no
uprobe_multi: no
raw_tp_special: no
iter: no
====
I also tried watchpoint, and it failed with same reason.
./bpftrace -v -e "watchpoint:0x$(awk '$3 == "jiffies" {print $1}' /proc/kallsyms):8:w {@[kstack] = count();}"
INFO: node count: 7
Attaching 1 probe...
Error log:
magic: 0xeb9f
version: 1
flags: 0x0
hdr_len: 24
type_off: 0
type_len: 76
str_off: 76
str_len: 102
btf_total_size: 202
[1] PTR (anon) type_id=2
[2] INT int8 size=1 bits_offset=0 nr_bits=8 encoding=SIGNED
[3] FUNC_PROTO (anon) return=4 args=(1 var1)
[4] INT int64 size=8 bits_offset=0 nr_bits=64 encoding=SIGNED
[5] FUNC watchpoint_18446744071601934336 type_id=3 vlen != 0
WARNING: Error loading program: watchpoint:18446744071601934336:8:w, skipping.
ERROR: Error attaching probe: watchpoint:18446744071601934336:8:w: Bad file descriptor

cc @viktormalik @jordalgo
I'm going to put this under high priority fix. This looks like a regression with BTF loading. 5.4 kernel is an LTS with EOL Dec, 2025. So we should make sure it works.
This fix would be a good candidate for vmtest (https://github.com/danobi/vmtest) in CI.

I'll investigate tomorrow.

@viktormalik Let me know if you want me to take a look too.

Is this something we should try bringing up to bpf@vger? IIUC libbpf does kinda promise to gracefully handle backwards compat. Not sure if this case is applicable though.

I didn't have time to look more carefully but it seems that BTF/func_info support was added in 5.0. So it may be that our generated BTF cannot be handled by older kernels. I'll investigate more next week.

So, I was able to find the problem - older kernels do not have https://github.com/torvalds/linux/commit/51c39bb1d5d105a02e29aa7960f0a395086e6342 and therefore do not support BTF_KIND_FUNC entries with global linkage. Libbpf sanitizes this for older kernels since https://github.com/torvalds/linux/commit/2d3eb67f64ec317bbfe340cfcc8325d40a6ff317 (same series) but it only does that when the program is loaded via bpf_object (which we don't at this point).
I can see several options going forward:

Mimic libbpf behaviour and do the same sanitization in bpftrace (including an added runtime check that kernel doesn't support global BTF func entries). This would eventually go away (we plan to load via bpf_object) so it's a bit of redundant work. If we still go that way, I'd prefer doing it only after the BpfBytecode class is introduced (#2912) b/c that's where such code logically belongs.
Do nothing now and wait until we make better use of libbpf for program loading (tracked in #2334) and we will get the sanitization (and others) for free.
Add a new option --no-btf to skip generation of BTF which will allow to use current bpftrace on older kernels with (e.g.) this feature missing.

@viktormalik nice find. Do you have a sense of how much work is left? If you can finish libbpf migration in this release cycle then I think it'd be ok to wait.

TBH I don't think that we can make it this cycle. The work itself will take some time but reviews may take even longer since it's a big change. On top of that, I'd like to do a release soon as we did the last one ~3 months ago.

Sorry for my ignorance, but if BTF_FUNC_GLOBAL isn't supported on older kernels, how are these BTF entries appearing in there?
Option 1 (Mimic libbpf behaviour and do the same sanitization in bpftrace) sounds the best to me, and judging from that libbpf commit it doesn't look like too much work?

Sorry for my ignorance, but if BTF_FUNC_GLOBAL isn't supported on older kernels, how are these BTF entries appearing in there?

We're emitting them by marking the functions in our BPF programs with ExternalLinkage (to prevent LLVM inlining them). This is then translated (by LLVM) into a BTF entry with BTF_FUNC_GLOBAL.

Option 1 (Mimic libbpf behaviour and do the same sanitization in bpftrace) sounds the best to me, and judging from that libbpf commit it doesn't look like too much work?

It's not that easy b/c we have to copy some portion of libbpf code for iterating BTF entries in a non-const way. These functions are internal to libbpf and they only export functions which give you const-pointers. But I'm already doing something similar when emitting BTF for maps (which also needs some fixing on our side) so I can try to reuse that code here.

Nice work!


docs: Add option to contribute via Codesandbox

Closes #
This PR adds the edit with codesandbox option for contributing to create-T3-app. The benefits of this includes having :

Setting up repository in codesandbox in seconds as shown in Screen recoding
Seemless branching and main branch protection
Command checklist is automatically added to a task.json file and exected in order. This  avoids errors when setting up the repo.

Codesandbox also has a [Template for create-T3-app] (https://codesandbox.io/p/sandbox/sharp-euclid-6k4sdn)running on Cloud sandboxes powered by micro VMs
https://codesandbox.io/p/sandbox/sharp-euclid-6k4sdn
✅ Checklist

[ x] I have followed every step in the contributing guide (updated 2022-10-06).
[ x] The PR title follows the convention we established conventional-commit
[ ] I performed a functional test on my final commit

Changelog
[Short description of what has changed]

Screenshots
[Screenshots]
💯
https://user-images.githubusercontent.com/35943047/214197882-bb5b7f8b-8e96-48d6-b247-a19949679a02.mov

Thanks for the PR. A lot to think about. This is basically two different topics so I'll reply to them separately.
Shared points

Lowering the barrier to entry is awesome!
If we use Codesandbox, we are effectively endorsing it. I would like to understand how it compares to other similar solutions like Stackblitz, Replit, GitHub Codespaces, etc. and their relative popularity, pros/cons of each, etc.
Will this require additional maintaining? How much?

Using Codesandbox or somilar to contribute to the project

If it motivates people to make good contributions who otherwise wouldn't, them I'm all for it!
I can definitely see it for docs
For contributing to CLI I'm not sure - for every PR I open, I first test the changes in a real app by doing pnpm build => pnpm start ../../test. I'm worried that letting people contribute in an environment where this is not possible might reduce quality of PRs
I couldn't changes to the website to show. Probably just something I'm doing wrong / we could educate

Using Codesandbox or similar to develop a T3 App

I tried it and everything works including tRPC/Prisma/NextAuth.
The dev experience is surprisingly good for a web based solution. Worse than native, but definitely good enough to be productive.
I would only consider "endorsing" this if we can find some way to keep the sandbox up to date
Who would use this, and why?

Using hardware that makes native dev difficult or impossible (iPad, Android, ChromeOS, etc) - this seems like a legit benefit to me, and I'm always in favor of lowering the barrier to entry in this regard.
Lack of knowledge around tooling - not sure about this one. CT3A is also an educational project in a way, and learning CLIs and editors feels important. Maybe I'm too old fashioned on this?
Convenience - might actually be a good point! I have a /dev/temp folder with a bunch of almost stock T3 apps in it that I used to test one thing
Something else?

For contributing anything is welcome imo - as long as changes can be tested (i.e. run the cli if you make changes there)
I'd bet we could get access to Codespaces for free if thats a better environment to recommend?
For starting out your journey and testing a clean T3-app, i think we got some domains pointing to that already:
https://t3.new

Thanks for the PR. A lot to think about. This is basically two different topics so I'll reply to them separately.
Shared points

Lowering the barrier to entry is awesome!

If we use Codesandbox, we are effectively endorsing it. I would like to understand how it compares to other similar solutions like Stackblitz, Replit, GitHub Codespaces, etc. and their relative popularity, pros/cons of each, etc.

Will this require additional maintaining? How much?

Who would use this, and why? (who it's for will influence if/how we should do it)

Using hardware that makes native dev difficult or impossible (iPad, Android, ChromeOS, etc) - this seems like a legit benefit to me, and I'm always in favor of lowering the barrier to entry in this regard.
Lack of knowledge around tooling - not sure about this one. CT3A is also an educational project in a way, and learning CLIs and editors feels important. Maybe I'm too old fashioned on this?
Convenience - might actually be a good point! I have a /dev/temp folder with a bunch of almost stock T3 apps in it that I used to test one thing
Something else?

Using Codesandbox or similar to contribute to the project

If it motivates people to make good contributions who otherwise wouldn't, them I'm all for it!
I can definitely see it for docs
For contributing to CLI I'm not sure - for every PR I open, I first test the changes in a real app by doing pnpm build => pnpm start ../../test. I'm worried that letting people contribute in an environment where this is not possible might reduce quality of PRs
I couldn't get changes to the website to show. Probably just something I'm doing wrong / we could document how to do it correctly

Using Codesandbox or similar to develop a T3 App

I tried it and everything works including tRPC/Prisma/NextAuth.
The dev experience is surprisingly good for a web based solution. Worse than native, but definitely good enough to be productive.
I would only consider "endorsing" this if we can find some way to keep the sandbox up to date. IE we would need something in CI, or a webhook, or whatever that makes sure whenever a new version of CT3A is released, the sandbox is updated accordingly.
Just having one sandbox that includes all packages kinda goes against the modularity of CT3A, but I don't see this as a reason to not do it.

Thanks for getting back to me so quickly. These are all really great points!
Shared points
If we use Codesandbox, we are effectively endorsing it. I would like to understand how it compares to other similar solutions like Stackblitz, Replit, GitHub Codespaces, etc. and their relative popularity, pros/cons of each, etc.
I wouldn’t look at it as an endorsement but more like adding a feature to help improve contribution and usage of Create-t3-app. One of the motivators for me to send in this PR was because I saw how easy it was to use T3 app in my existing workflow which is with Codesandbox and wanted to share with the community
RE differences: out of the 4 you mentioned I’ve only used Stackblitz and Codesandbox and they’re both pretty popular. .
Maintenance
That’s the best part! Having the edit button requires no maintenance for you at all. whenever a person wants to contribute via Codesandbox it’s simplified in the steps shown in the video in the PR.
Codesandbox also supports synced sandboxes so whenever a new version of your main is pushed your Codesandbox branch can also automatically be updated.
Who would use this, and why?
Yep! The first benefit you have highlighted is all legit. I also think that another benefit is helping people get up and running even faster. If you notice in the .codesandbox/tasks.json file has a bunch of commands that can be accessed in codesandbox devtools under tasks.
So contributors can run the commands with a click of a button and it also comes with a terminal to run others.

Lack of knowledge around tooling - not sure about this one. CT3A is also an educational project in a way, and learning CLIs and editors feels important. Maybe I'm too old fashioned on this?

I wouldn’t say lack of knowledge but more ease of use. There is always the terminal to allow people become more familiar with running commands. I  also added the example starter so that more people get started a lot more quickly with the create-T3 to aid the educational aspect.

• For contributing to CLI I'm not sure - for every PR I open, I first test the changes in a real app by doing pnpm build => pnpm start ../../test. I'm worried that letting people contribute in an environment where this is not possible might reduce quality of PRs

Code sandbox allows you to have interactive ReadMe so you can pretty much add this command in your ReadMe and run it in one click.

For contributing anything is welcome imo - as long as changes can be tested (i.e. run the cli if you make changes there)
I'd bet we could get access to Codespaces for free if thats a better environment to recommend?
For starting out your journey and testing a clean T3-app, i think we got some domains pointing to that already:
https://t3.new

Yea! The CLI runs with each fork and your existing setup works as it would locally. Codesandbox looks for this folder .codesandbox/tasks.json and then runs the command accordingly.
I haven't used Codespaces but I'd bet on Codesandbox because of the new Cloud sandboxes.
I think you can point https://t3.new/ to https://codesandbox.io/p/sandbox/sharp-euclid-6k4sdn because this runs in Codesandbox repositries which has a much better experience and also showing a lot of traction in the last 24hrs

Also you can install the GitHub App and then every PR will also have a running dev environment that they can use to test the PR (including CLI commands).

@c-ehrlich any thoughts on my last comment?


How to check if jobs are started

Is it possible to check if jobs are paused or running?
If SyncedCron.start() is called multiple times, will the jobs be added more than once?

A few ways I use are console.log to trace output, if I needed to query a cron status I would use a session variable and check the contents. To get more complicated you could save strings or append to an array so as to know various status or timeline of activity.
Regarding SyncedCron.start() As far as I know - no. It will just start the cron again. Not really sure what you want to achieve with this.


modular import of the project

Describe the problem
MRTK is definitely the best framework for mixed reality. However, its willingness to tweak global settings and the sheer amount of functionalities it tries to provide combined to its reliance on native plugins (the native MRTK library) makes it look very scary. Combined this with the versioning issue that happens to all Unity libraries, I can easily imagine a situation I will need to rollback and reimplement things.
Describe the solution you'd like
The issue can be divided into two. (1) There are side effects and (2) the framework is very large. While providing standard practice is understandable, for example, I do not think a library should try to tweak global setting regarding the rendering pass of an application, such as using single pass instanced rendering. The framework being large magnifies this issue. In case having side effects is unavoidable, making it into a set of smaller modules will be able to mitigate the issue. Also, the smaller number of modules leads to smaller number of native plugins, resulting in higher stability of applications, especially when they already have their own native plugins.
Describe alternatives you've considered
As a person who wants to use the input system of this project, writing the UI system by myself...
Additional context
If this is actually already possible, first I would like to say sorry for bothering you all, and please let me know...

Does the new UPM packaging system that was rolled out with MRTK 2.5 not allow for this?
I know that the new UPM setup allows for more modular installation of MRTK, but I don't know if it is sufficiently granular for your uses.
Have you looked at consuming MRTK through UPM?

MRTK3 has been drastically re-architected to be distributed into a large number of independent packages. Check it out and let us know what you think!

@Zee2 Thanks a lot!! I didn't expect to receive an answer such as this which is totally amazing!!


Adding Brazilian cards and improve example project

Added Elo, Hipercard and Aura (almost all code is from Eduardo Bocato, I just made it compatible with swift3)
Improve Example project to show Card Type on the demo

Hi @ghashi sorry for the delay on this, I really appreciate your help! If you could update this to be compatible with the latest changes, will happily merge thereafter!


Better error when device mismatches when calling gather() on CUDA

What does this PR do?
This PR adds a new explicit error when a user tries to call .gather() in a GPU scenario and the device of the passed in tensor != the device in PartialState (aka CUDA). Avoids users getting err:
  File "/home/student/Experiemnts/MultiLabelClassification_LLMs/.mlc/lib/python3.10/site-packages/torch/distributed/distributed_c10d.py", line 2897, in all_gather_into_tensor
    return honor_type(
  File "/home/student/Experiemnts/MultiLabelClassification_LLMs/.mlc/lib/python3.10/site-packages/accelerate/utils/operations.py", line 83, in honor_type
    return type(obj)(generator)
  File "/home/student/Experiemnts/MultiLabelClassification_LLMs/.mlc/lib/python3.10/site-packages/accelerate/utils/operations.py", line 112, in <genexpr>
    recursively_apply(
  File "/home/student/Experiemnts/MultiLabelClassification_LLMs/.mlc/lib/python3.10/site-packages/accelerate/utils/operations.py", line 128, in recursively_apply
    return func(data, *args, **kwargs)
  File "/home/student/Experiemnts/MultiLabelClassification_LLMs/.mlc/lib/python3.10/site-packages/accelerate/utils/operations.py", line 307, in _gpu_gather_one
    gather_op(output_tensors, tensor)
  File "/home/student/Experiemnts/MultiLabelClassification_LLMs/.mlc/lib/python3.10/site-packages/torch/distributed/c10d_logger.py", line 47, in wrapper
    return func(*args, **kwargs)
  File "/home/student/Experiemnts/MultiLabelClassification_LLMs/.mlc/lib/python3.10/site-packages/torch/distributed/distributed_c10d.py", line 2897, in all_gather_into_tensor
    work = group._allgather_base(output_tensor, input_tensor)
RuntimeError: Tensors must be CUDA and dense
    work = group._allgather_base(output_tensor, input_tensor)
RuntimeError: Tensors must be CUDA and dense

And instead gives them a much clearer err:
"One or more of the tensors passed to `gather` was not on the GPU while the `Accelerator` is configured for CUDA. "
                "Please move it to the GPU before calling `gather`."

Fixes # (issue)
https://discuss.huggingface.co/t/problem-with-model-inference-using-accelerate/63078
Before submitting

[ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
[x] Did you read the contributor guideline,
Pull Request section?
[x] Was this discussed/approved via a Github issue or the forum? Please add a link
to it if that's the case.
[ ] Did you make sure to update the documentation with your changes? Here are the
documentation guidelines, and
here are tips on formatting docstrings.
[ ] Did you write any new necessary tests?

Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@BenjaminBossan @SunMarc

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.


[NF] Class Gen: Function serialization

Hello all,
Recently the Class Generator was modified to ease save and load operation in pyleecan. Now list and dict of array are properly converted with call to lolist and SciDataTool are now longer serialized with cloudpickle (with call to as_dict). Other packages types are not that common and shouldn't be used as much as possible (again to avoid call to cloudpickle).  The next type that need to be properly handled is function (DataKeeper, PostFunction...)
Here is a proposal of how we can try to handle function to remove the need to use to cloudpickle:

Function should always be set with string containing either code to evaluate, either a path to a python file to run.
The string would be stored in the class as _prop_name_str
The resulting function would be stored as _prop_name_func
The setter will convert the string to the proper func and set both properties
The getter will return only _prop_name_func
as_dict would only contain the _prop_name_str

This would require further investigation to know how to properly convert string to function. Should the string to evaluate be lambda only ? If we use python script should we import a function with a standard name or evaluate the script ?
What do you think of this new evolution ?
Best regards,
Pierre

Hello Pierre,
just a short response to some aspect of this issue and #174.
How do we deal with the 'eval' function regarding security reasons?
I also read that 'You can’t evaluate an import statement using eval().' Source: Python Eval Function
BR, Sebastian

Hello,

How do we deal with the 'eval' function regarding security reasons?

Indeed eval can provide anyone the tools to inject some strange and unwanted code but on this topic I think that the issue is more on the fact that we use function rather than the fact that we use eval. Anyway as pyleecan is open-source I think we can trust the user code.

I also read that 'You can’t evaluate an import statement using eval()

This is something worth investigating. For now eval is used for lambda function (that shouldn't have import statement). For more complex function we use exec. So if an import is needed the solution may be to use a file (or a function directly). Another solution would be to try dynamic import.
Best regards,
Pierre

Hello Sebastian,
I have updated my test in 7e30383e803d69c755ea52e0606b31770db2c20f to use a file with import and it works :)
Is the PR Ok for you ?
Best regards,
Pierre

Hello Pierre,
I had a look at the code (in your PR description) and would like to recap the actual possibilities. Correct me if I'm wrong.

One can set 'inline' functions, i.e. lambdas as a string that will be saved in the json.
The string only option, e.g. 'simu.machine.stator.L1' seems to be removed (by the above).
One can have a seperate file with a function of the same name (that may have imports).
At last one can define/reference a function directly.

If the 3rd option won't save the file content inside the json, I think the PR is okay. So the user can always check the function file before he is loading and running the json, i.e. there is no 'hidden' code inside the json files.
BTW: Is there a possibility to e.g. do a poll among the people who forked the project, to have a broader base on such decisions?
Best regards,
Sebastian

Hello Sebastian,

One can set 'inline' functions, i.e. lambdas as a string that will be saved in the json.

Yes (then there can be code in the json)

The string only option, e.g. 'simu.machine.stator.L1' seems to be removed (by the above).

Still available, in fact it was only for ParamExplorer class. The corresponding code is in a dedicated setter file (Methods/Simulation/ParamExplore/_set_setter). We can add this feature to any class by surcharging the setter or changing the class generator to add it for all classes (but it is very specific to ParamExplorer).

One can have a separate file with a function of the same name (that may have imports).

Yes in this case the path to the function file is saved in the json (which can create some issue if the file is moved)

At last one can define/reference a function directly.

Yes but it won't be saved.

BTW: Is there a possibility to e.g. do a poll among the people who forked the project, to have a broader base on such decisions?

I didn't found any poll option :/ But this is why I opened this issue, to take the time to discuss about it. Anyone can participate to this discussion, I just directly refer to you to answer your questions. I will continue to wait for reply on this issue before merging it (maybe by the end of the week if nothing major is discovered before). Anyway this PR doesn't break the backward compatibility, it just introduce some new standards and fix save/load issues so it shouldn't be an issue to merge.
Pyleecan architecture is not finished (and may never be). There will always have some new optimization and reorganization to do. We are working a lot on our private fork and we find new optimization and feature every week. This is why I have created the milestone 1.1 to discuss about what are the next steps for the project and why. We need to progressively structure the project and the development planning so that anyone can understand where we are going, why and how they can help. At the end, merging SlotWind and SlotMag will break backward compatibility but it will provide a significant improvement so it is worth investigating and discussing about it. The project is still rather young so we still need to find a way of moving forward by including everyone. Any idea on this topic is welcome :)
Best regards,
Pierre


Refactoring in runtime

Codecov Report

Merging #167 into master will increase coverage by 0.33%.
The diff coverage is 87.09%.

@@            Coverage Diff             @@
##           master     #167      +/-   ##
==========================================
+ Coverage   83.45%   83.78%   +0.33%
==========================================
  Files         108      108
  Lines        2713     2701      -12
  Branches      131      126       -5
==========================================
- Hits         2264     2263       -1
+ Misses        449      438      -11

Impacted Files
Coverage Δ

...ala/com/ing/baker/runtime/actor/ProcessQuery.scala
100% <ø> (ø)
:arrow_up:

...ntime/actor/process_instance/ProcessInstance.scala
94.28% <100%> (+0.05%)
:arrow_up:

.../main/scala/com/ing/baker/runtime/core/Baker.scala
82.3% <100%> (-0.89%)
:arrow_down:

...ore/internal/MethodInteractionImplementation.scala
87.5% <100%> (+23.21%)
:arrow_up:

...aker/runtime/actor/ClusterBakerActorProvider.scala
88.37% <100%> (+0.27%)
:arrow_up:

...ker/runtime/actor/process_index/ProcessIndex.scala
84.34% <100%> (-0.14%)
:arrow_down:

.../baker/runtime/actor/LocalBakerActorProvider.scala
100% <100%> (ø)
:arrow_up:

...untime/core/internal/InteractionTaskProvider.scala
74.5% <63.63%> (-3.54%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b36d525...4061f64. Read the comment docs.


Edit external User bug(System Manager)

Form validation error while editing external user profile. I think its because internalUserValidator is being used instead of externalUserValidator.

closed by #100


baseline training 1x1 conv layer and weight

moco 1x1
resnet50 with conv1x1
resnet50
moco (without 1x1)
moco (with 1x1 but with random weight)

https://github.com/Berkeley-Data/hpt/blob/taeil/references/model_architectures.md

added script to run various models.
so far, the results are not what we expected.

[ ] need to continue running experiments
[ ] need to review code to make sure we are doing correct.

running experiments on different models, different epochs, different learning rates.

run_supervised.sh
run_ft.sh

[] review and confirm forward code.


First shot

Hey @jnwng! Is this PR opened on the apollo-link-redux repo? Should I close it?

Whoops I think I opened this by accident!


fix: menu item btn, status item styles

SUMMARY:

Feature: Option to place status text after the status icon
Fix status item text font size - according to the design, the font should be 2px larger than the icon, and have font-weight: 600

GITHUB ISSUE (Open Source Contributors)
JIRA TASK (Eightfold Employees Only):
ENG-40399
CHANGE TYPE:

[x] Bugfix Pull Request
[x] Feature Pull Request

TEST COVERAGE:

[ ] Tests for this change already exist
[ ] I have added unittests for this change

TEST PLAN:
Story book for Avatar should get updated to reflect the above mentioned feature and fix
Before

After

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@65dde9a). Click here to learn what that means.
Patch has no changes to coverable lines.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #567   +/-   ##
=======================================
  Coverage        ?   85.02%
=======================================
  Files           ?      791
  Lines           ?    16904
  Branches        ?     5945
=======================================
  Hits            ?    14372
  Misses          ?     2466
  Partials        ?       66

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

@fmehta-eightfold Fix the stories file with alignIcon and you should be good to go.


Interactivity with Chart on Safari and Firefox does not work properly

On both Safari and Firefox, whenever I use an interaction (any kind), the window automatically scrolls to the top of the chart, which is quite annoying since I can no longer see the graph right below. I need to scroll back down from time to time.
On Safari only, when I use Zoom In, Zoom Out, and Reset, it throws an error:

Error: TypeError: null is not an object (evaluating 'e.target.parentNode.classList')
Related File: apexcharts.common.js:6

If anyone knows a solution to these problems, please tell me. Thank you very much!

The console errors can be seen on the Zoomable Timeseries demo in Safari. Click and drag to select a time range which will trigger the error once on drag release. Use the pan tool to move through the timeline which will trigger the same error repeatedly.
I have not noticed it causing any problems with interactivity or scrolling the chart into view, however. In my case this just blows up our error tracker if someone pans a chart in Safari. Perhaps the scrolling and console error should be tracked as separate issues.

I'm having the same issue here

I'm having the same issue here

Before:
`

`
After:
`

`
It works for me

Before:

     <Chart options={chartData.options} series={chartData.series} type="line" height={height - 20} />

After:

      <Chart options={chartData.options} series={chartData.series} type="line" height="100%" />

It works for me.

The other variation of this is on mobile Safari (on iOS devices), I can reproduce this 100% of the time by simply scrolling the page while I tap and hold somewhere on the graph and then let go. As @idpaterson pointed out, it seems to be with related to click and dragging on a graph on Safari on desktop and mobile.

Seeing the same behaviour here - it doesn't hurt anything but it would be nice for the error not to be thrown, I don't see a problem with adding a null check there.