Setup a basic page for the webapp

Fixes #4
By submitting this pull request I confirm I've read and complied with the below declarations.

[x] I have tested the changes locally and they are functional.
[x] I ensure that I sent this pull request after being assigned to the corresponding issue.
[x] This pull request has a descriptive title. For example, Added/Fixed {Feature/Bug}, not Update README.md or Added new code.
[x] This pull request will be closed if I fail to update it even once in a continuous time span of 7 days.

Looks neat ! @collinsnji
What I'm doubtful about is if we need the package-lock.json to be added to the commits ?
I think that's a configuration file that's generated while building/running
What are your views on this @sneakycr0w ?

You shouldn’t. The dependencies will be in package.json.
Zachary E Sohovich
Full Stack Web Developer
https://sneakycr0w.com
<EMAIL_ADDRESS>
On Oct 2, 2017, at 10:54 PM, Anshuman Verma<EMAIL_ADDRESS>wrote:
Looks neat ! @collinsnji
What I'm doubtful about is if we need the package-lock.json to be added to the commits ?
I think that's a configuration file that's generated while building/running
What are your views on this @sneakycr0w ?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

Right, exactly.
Apparently in this PR you have included package-lock. Please add another commit to remove it 😄

Oh right. I did not noticed when I committed the package-lock file. I'll remove it

Thanks ! Actually i should've added that to .gitignore earlier 😅

Haha yeah. One more thing, how will the webapp be hosted? Heroku?

I don't have any such preference, what are your preferences on this ?

I think Heroku will be best for this :) @sneakycr0w what do you think?

Right, heroku sounds good to me. Let's hear from @sneakycr0w


Closes #9 and #10

Summary of changes:

Changed worker/isWindow to use feature detection and added an interface for minimum required window features (#9)
Changed parent and child handshake to continuously attempt their handshake message until it succeeds.  Added tests confirming order of handshake no longer matters (#10)

Thank you for the PR!
I just opened another one that I think may conflict with your first commit, and make the second commit superfluous.
Since that PR is related to the #9 issue you opened, If you spare a few minutes, would mind checking it out?
Depending on which one I merge first one of us might have to do some rebasing :)

Yeah, feel free to close this.  I can resubmit for the retry thing or you can just copy from here the runUntil, if you want.  I also mistakingly applied the runUntil in both the child AND parent.  It should just be the parent.

I cherry-picked your retry handshake commit, fixed the conflicts, and merged into main


Feature/update filter output record

What
When CSV export is triggered by a filter job, update filter output record with download link. Otherwise update instance.
How to review
Check changes make sense, tests pass
Who can review
Anyone

The rebase strategy is advisable on private branches as avoids having to have a develop merge commit there. Also I would avoid "Fix xxx" as it does not provide any benefit and is essentially work of a previous commit, that now has tests against it.
I don't block PRs because of it, but it also removes noise from the git log where I don't need to see "Fix x", "addressed PR comments" or  "Forgot to do Y". This gives a cleaner main branch and cleaner logs and is still part of the same logical piece of work, so we could amend a commit instead.
I probably just care too much about commits. :popcorn: :sweat_smile:

The rebase strategy is advisable on private branches as avoids having to have a develop merge commit there. Also I would avoid "Fix xxx" as it does not provide any benefit and is essentially work of a previous commit, that now has tests against it.
I don't block PRs because of it, but it also removes noise from the git log where I don't need to see "Fix x", "addressed PR comments" or "Forgot to do Y". This gives a cleaner main branch and cleaner logs and is still part of the same logical piece of work, so we could amend a commit instead.
I probably just care too much about commits. 🍿 😅

Yeah whether or not I rebase usually depends on how complicated the merge errors are likely to be/how lazy I'm feeling :)


Deleted incorrect description for verify command.

Deleted incorrect description for verify command.  So small I didn't test this extensively but it seemed like the right thing to do.

thank you looks great.


Feature/adding filter flex service

What

Added route and config for new dp-frontend-filter-flex-dataset service
Updated unit tests

How to review

Sense check
Run this branch of dp-frontend-router with make debug FILTER_FLEX_ROUTES_ENABLED=true
Get the latest dev branch of dp-frontend-filter-flex-dataset and in routes.goreplace line 25 with:

r.StrictSlash(true).Path("/flex/helloworld").Methods("GET").HandlerFunc(handlers.HelloWorld(*cfg))

In a browser, go to (http://localhost:20000/flex/helloworld)
For a complete sense check, make FILTER_FLEX_ROUTES_ENABLED=false in the router and go to the page again, you should get a 502 error

Who can review
Anyone but me

It didn't work for me at first, then I realised that I needed to run dp-frontend-filter-flex-dataset (after changing line 25) before running this branch of dp-frontend-router. It then worked successfully and so I changed it to FILTER_FLEX_ROUTES_ENABLED=false to test the failure scenario. It failed with a 401 rather than a 502 displayed on the page though. Is this what you would expect?

It didn't work for me at first, then I realised that I needed to run dp-frontend-filter-flex-dataset (after changing line 25) before running this branch of dp-frontend-router. It then worked successfully and so I changed it to FILTER_FLEX_ROUTES_ENABLED=false to test the failure scenario. It failed with a 401 rather than a 502 displayed on the page though. Is this what you would expect?

I would expect a 502 or possibly a 404. 401 is unauthorised. You should only be running the router and the filter-flex service


The script in testConfig.json contains an absolute path that is not read.

Hi,
When adding a new test case, a testConfig.json file is created.
The first line contains an absolute path to a query script.
e.g.
{
"Script": "C:\Users\ladamian\projects\asa\infrastructure\tf-infrastructure\services\connectivity\asa-enrichment-query.asaql",
"TestCases": [
...
This value should not contain the absolute path, but a relative path.
I also noticed that if I replace this value with anything else,
e.g.
{
"Script": "foo",
"TestCases": [
...
the test continues to work, so it looks like this value is never read.
I noticed that the script's path is read from the project file (asaproj.json) and I can point it to any location on my file system, which is useful for my case.
Thanks,
Laura

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 69104dfd-0c8f-16eb-f42b-8543d3b90855
Version Independent ID: c8e6dd18-dfb5-42dc-33e1-85d2becf9923
Content: Automate builds, tests, and deployments of an Azure Stream Analytics job using CI/CD tools
Content Source: articles/stream-analytics/cicd-tools.md
Service: stream-analytics
GitHub Login: @su-jie
Microsoft Alias: sujie

@LauraDamianTNA Thank you for the feedback.
This is being assigned to the content author to evaluate and update the documentation as appropriate.

@LauraDamianTNA sorry for late response. I am just back from vacation. The 'Script' filed is only there for providing context. It's not used in the testing logic.

It's confusing to have a value there that is never read.
However, I noticed that I can change the location of the script from another file, asaproj.json, which resolved my issue.

#please-close


Add support for elm-test-rs

This involves:

Easy: Adding links to the executables in https://github.com/lydell/elm-tooling.json/blob/main/helpers/known-tools.ts
Medium: Adding support for .zip files on macOS and Linux (so far only elm-format for Windows uses .zip: https://github.com/lydell/elm-tooling.json/blob/5ad521d58dfd6ef98398ed00c77b065eeb0ac199/commands/install.ts#L602-L607). I think this needs to use the unzip executable if it’s available – it seems to be available on Alpine Linux. Alternatively, convince @mpizenberg to use .gz or .tgz, at least on non-Windows. EDIT: Next version is .tar.gz, should be easy to do.
Decision: Deciding if elm-tooling init should include elm-test-rs or not. Currently that command includes the latest version of all known tools, but maybe we don’t want to include elm-test-rs until it’s considered more stable or is more popular.
Decision: Deciding if we should wait for elm-test-rs to become more stable first. elm-tooling is built around the fact that the tools it supports are slow and stable. For a tool with rapid releases, I would have to release new elm-tooling versions all the time.

Alternatively, convince @mpizenberg to use .gz or .tgz, at least on non-Windows.

I don't mind using whatever is more convenient. For the time being I'm making elm-test-rs releases manually so I can easily change the compression format.

Deciding if we should wait for elm-test-rs to become more stable first

I don't intend to make frequent releases after 1.0.0. There might be a couple releases before that, depending on what bugs people find and completion of some features like the json and junit reports that are not finished (I haven't touched those since march or april). After that, the current set of features is enough for my usage, so updates will mostly be contributor-based or security patch I suspect.

I just published version 0.5 with some fixes: https://github.com/mpizenberg/elm-test-rs/releases/tag/v0.5
The linux and mac executable are packaged with .tar.gz and still .zip for windows. Is this more adequate for elm-tooling?

Yes, that’ll mean less coding on the elm-tooling side. All that should be needed is adding .tar.gz as an alias for .tgz. :+1:

This is the plan:

Wait for X days to pass with no new release of elm-test-rs, then add it. Not sure what X should be, maybe 30?
Don’t add it by default in elm-tooling init. People will have to opt in.

This is the plan:

Wait for X days to pass with no new release of elm-test-rs, then add it. Not sure what X should be, maybe 30?
Don’t add it by default in elm-tooling init. People will have to opt in.

The reason for 1 is, that you would need to patch the cli each time something is released?

The reason for 1 is, that you would need to patch the cli each time something is released?

@Razzeee Correct!

@Razzeee Correct!

Just a note to let you know that a month may pass without a version because I'm busy at work now. But a new version is intended after that in the coming weeks.

Just a note to let you know that a month may pass without a version because I'm busy at work now. But a new version is intended after that in the coming weeks.


Revert "Add eslint to catch incorrect javascript patterns"

Reverts civiform/civiform#2777
It seems to break Node in some unknown way
Fix #3102

this is not needed now correct?


move module to viam-modules

updated the GitHub link in the meta.json to point to the repo that is now in the Viam-modules org. built the module locally and tested on a pi, no issues

any thoughts on why this check would be failing?

The github_token is missing:
https://github.com/viam-modules/rplidar/blob/033302c110c0df3c54364e55f5af2c258ec53f34/.github/workflows/pr-labeler.yml#L20.
This is most likely due to the need to update the workflows to reference the new organization. If you look through the workflows (see pr-labler.yml and main.yml as examples). They reference viamrobotics instead of the new viam-modules. I would try updating every instances of these and see if that fixes the issue.
Note: Once updated, the updates will not be used in the PR until they are already in main

Note: Once updated, the updates will not be used in the PR until they are already in main

does this mean I have to bypass branch protections and merge with the checks failing?

Note: Once updated, the updates will not be used in the PR until they are already in main

does this mean I have to bypass branch protections and merge with the checks failing?

Yes, there is a way around that by relinking which workflows are run to the one in the current PR. This process looks like this:

Create a branch for your workflow changes
Create a PR updating the workflows to reference workflows in this PR and not main (Note: this will run on main workflows)
Create a PR from your branch to main (Note: this will run on branch workflows)
Merge this PR once all changes have been made to the workflows and tests are passing
Create a new PR reverting back to using main PR
Delete branch

However, since you are actively solving this process and this process doesn't affect the actual code itself it is usually safe to merge without checking for a few PRs while you get it sorted.
@randhid to confirm as this may dilute the commit history with several PRs in sequence

@martha-johnston this is a cgo module that makes an makes an appimage and will need to be updated to use the new style of workflow that the C++ modules use. The slack thread that discusses this is : https://viaminc.slack.com/archives/C02P30REXFW/p1724767442860879, We're trying to move away from the older credentials.

@martha-johnston this is a cgo module that makes an makes an appimage and will need to be updated to use the new style of workflow that the C++ modules use. The slack thread that discusses this is : https://viaminc.slack.com/archives/C02P30REXFW/p1724767442860879, We're trying to move away from the older credentials.

@randhid I see the thread but it's not clear to me what the next steps are... am I supposed to be building an AppImage manually or getting new creds from someone or something else?

@martha-johnston this is a cgo module that makes an makes an appimage and will need to be updated to use the new style of workflow that the C++ modules use. The slack thread that discusses this is : https://viaminc.slack.com/archives/C02P30REXFW/p1724767442860879, We're trying to move away from the older credentials.

@randhid I see the thread but it's not clear to me what the next steps are... am I supposed to be building an AppImage manually or getting new creds from someone or something else?

You can follow what was done to the intel realsense here since that workflow also uses an app image. This repo's credentials do not match up with the upload step. You can ask etai for further explanations, maybe he can write up something for us all to use for viam-modules since he's the one who wants this change, and that would be helpful to us all.

@randhid @jeremyrhyde I worked with Etai to update the workflow process, but it seems unrelated to the failing check and the PR_TOKEN issue. is it still true that these updates won't be used in this PR, but if I force merge this it will be correct for future PRs?

I am okay with force merging this and diluting with a few commits.

great, I'll do that now.

Update: The github_token issue is related to the need to access the PR_TOKEN secret (see https://viam.atlassian.net/wiki/spaces/ENG/pages/196698/Dev+Ops for more details). We can decide to add a PR_token to the new org OR change to using the autogenerated GITHUB_TOKEN (https://docs.github.com/en/actions/security-for-github-actions/security-guides/automatic-token-authentication)

actually, @jeremyrhyde I want to clarify this. do I need to generate a new PR_TOKEN for the viam-modules org? or is changing the viamrobotics references to viam-modules sufficient? If the answer is the former, does anyone have access to the org settings that could help me out with that? @randhid

okay deleted the pr-labeler workflow and now am going to force merge since this will continue to fail against main


quantitative region fails

https://results.finngen.fi/region/WEIGHT_IRN/5:123116412-123516412
The same thing also in gene page https://results.finngen.fi/gene/IL6R

ok need to ask @piotor87 so copy the quant conditionals in


[BUG] ERROR Nameserver not successfully set

General information

OS: Windows
Hypervisor: Hyper-V
Did you run crc setup before starting it (Yes/No)? YES
Running CRC on: Laptop

CRC version
crc version: 1.11.0+883ca49
OpenShift version: 4.4.5 (embedded in binary)

CRC status
# Put `crc status --log-level debug` output here
DEBU Running 'C:\Users\Developer\.crc\bin\oc\oc.exe get co -ojson --kubeconfig C:\Users\Developer\.crc\machines\crc\kubeconfig --context admin --cluster crc'
DEBU Command failed: exit status 1
DEBU stdout:
DEBU stderr: error: CreateFile C:\Users\Developer\.crc\machines\crc\kubeconfig: The system cannot find the file specified.
DEBU error: CreateFile C:\Users\Developer\.crc\machines\crc\kubeconfig: The system cannot find the file specified.
ERRO Error getting config for native Go SSH: open C:\Users\Developer\.crc\machines\crc\id_rsa: The system cannot find the file specified.

CRC config
N/A

Host Operating System
Host Name:                 DESKTOP-TF4L8CF
OS Name:                   Microsoft Windows 10 Pro for Workstations
OS Version:                10.0.18363 N/A Build 18363
OS Manufacturer:           Microsoft Corporation
OS Configuration:          Standalone Workstation
OS Build Type:             Multiprocessor Free
Registered Owner:          Developer
Registered Organization:
Product ID:                00391-90050-00000-AA002
Original Install Date:     3/26/2020, 3:23:44 PM
System Boot Time:          6/12/2020, 5:19:30 PM
System Manufacturer:       Acer
System Model:              Aspire TC-865
System Type:               x64-based PC
Processor(s):              1 Processor(s) Installed.
                           [01]: Intel64 Family 6 Model 158 Stepping 10 GenuineIntel ~2808 Mhz
BIOS Version:              American Megatrends Inc R01-A3, 5/16/2018
Windows Directory:         C:\Windows
System Directory:          C:\Windows\system32
Boot Device:               \Device\HarddiskVolume3
System Locale:             en-us;English (United States)
Input Locale:              N/A
Time Zone:                 (UTC-05:00) Eastern Time (US & Canada)
Total Physical Memory:     65,423 MB
Available Physical Memory: 47,782 MB
Virtual Memory: Max Size:  75,151 MB
Virtual Memory: Available: 57,267 MB
Virtual Memory: In Use:    17,884 MB
Page File Location(s):     C:\pagefile.sys
Domain:                    WORKGROUP
Logon Server:              \\DESKTOP-TF4L8CF
Hotfix(s):                 11 Hotfix(s) Installed.
                           [01]: KB4552931
                           [02]: KB4513661
                           [03]: KB4516115
                           [04]: KB4517245
                           [05]: KB4528759
                           [06]: KB4537759
                           [07]: KB4541338
                           [08]: KB4552152
                           [09]: KB4560959
                           [10]: KB4561600
                           [11]: KB4560960
Network Card(s):           4 NIC(s) Installed.
                           [01]: Intel(R) Wireless-AC 9462
                                 Connection Name: Wi-Fi
                                 DHCP Enabled:    Yes
                                 DHCP Server:     <IP_ADDRESS>
                                 IP address(es)
                                 [01]: <IP_ADDRESS>
                                 [02]: fe80::d5ce:74b:f58:55a3
                           [02]: Realtek PCIe GbE Family Controller
                                 Connection Name: Ethernet
                                 DHCP Enabled:    Yes
                                 DHCP Server:     <IP_ADDRESS>
                                 IP address(es)
                                 [01]: <IP_ADDRESS>
                                 [02]: fe80::d8e4:a052:4f11:d168
                           [03]: Bluetooth Device (Personal Area Network)
                                 Connection Name: Bluetooth Network Connection
                                 Status:          Media disconnected
                           [04]: Hyper-V Virtual Ethernet Adapter
                                 Connection Name: vEthernet (Default Switch)
                                 DHCP Enabled:    No
                                 IP address(es)
                                 [01]: <IP_ADDRESS>
                                 [02]: fe80::534:ff05:7329:2dd3
Hyper-V Requirements:      A hypervisor has been detected. Features required for Hyper-V will not be displayed.

Steps to reproduce

crc delete -f
crc cleanup
crc setup
crc start -p ..\pull-secret.txt --log-level debug

Expected
Actual
INFO Will run as admin: add dns server address to interface vEthernet (Default Switch)
ERRO Nameserver not successfully set
ERRO Error running post start: Nameserver not successfully set
Making call to close driver server
(crc) Calling .Close
Successfully made call to close driver server
Making call to close connection to plugin binary
Making call to close driver server
(crc) Calling .Close
(crc) DBG | Closing plugin on server side
(crc) DBG | Closing plugin on server side
Successfully made call to close driver server
Making call to close connection to plugin binary
Logs
https://gist.github.com/GrooveCS/7cc2472d59381033c6e0f36d7dcc6331
Before gather the logs try following if that fix your issue
$ crc delete -f
$ crc cleanup
$ crc setup
$ crc start --log-level debug

The initial run of the crc start -p pull-secreat.txtcommand, I didn't have docker running on the windows machine. I started the service to see if it affecting the configurations in the local windows environment.
It appears it does because now CRC is running.
Is Docker a dependency?
I didn't think it was because when reviewing the instructions it never stated to install or have the service running.
Performed the following steps
$ crc delete -f
$ crc cleanup
$ crc setup
$ crc start -p ..\pull-secret.txt --log-level debug
CRC status
# Put `crc status --log-level debug` output here
DEBU Running 'C:\Users\Developer\.crc\bin\oc\oc.exe get co -ojson --kubeconfig C:\Users\Developer\.crc\machines\crc\kubeconfig --context admin --cluster crc'
DEBU About to run SSH command:
df -B1 --output=size,used,target /sysroot | tail -1
DEBU SSH cmd err, output: <nil>:<PHONE_NUMBER>4<PHONE_NUMBER>2 /sysroot
CRC VM:          Running
OpenShift:       Running (v4.4.5)
Disk Usage:      11.69GB of 32.72GB (Inside the CRC VM)
Cache Usage:     40.95GB
Cache Directory: C:\Users\Developer\.crc\cache

Actual
DEBU Running 'C:\Users\Developer\.crc\bin\oc\oc.exe get csr -ojson --kubeconfig C:\Users\Developer\.crc\machines\crc\kubeconfig --context admin --cluster crc'
INFO
INFO To access the cluster, first set up your environment by following 'crc oc-env' instructions
INFO Then you can access it by running 'oc login -u developer -p developer https://api.crc.testing:6443'
INFO To login as an admin, run 'oc login -u kubeadmin -p 8rynV-SeYLc-h8Ij7-YPYcz https://api.crc.testing:6443'
INFO
INFO You can now run 'crc console' and use these credentials to access the OpenShift web console
Making call to close driver server
(crc) Calling .Close
Successfully made call to close driver server
Making call to close connection to plugin binary
Making call to close driver server
(crc) DBG | Closing plugin on server side
(crc) Calling .Close
Successfully made call to close driver server
Making call to close connection to plugin binary
(crc) DBG | Closing plugin on server side
Started the OpenShift cluster
WARN The cluster might report a degraded or error state. This is expected since several operators have been disabled to lower the resource usage. For more information, please consult the documentation

Logs
https://gist.github.com/GrooveCS/667d95b4e806c2cc26fa76fbd6dc148c#file-crc-2020-06-15t13-03-46-log

Just responding to the title as the rest is a mized bag: Nameserver are not successfully set. Did you see the UAC popup?

Just responding to the title as the rest is a mixed bag (need more time to look at this): Nameserver are not successfully set. Did you see the UAC popup?

Did UAC popup? Yes

[Question]

Is docker a requirement?

Is docker a requirement?

No. https://access.redhat.com/documentation/en-us/red_hat_codeready_containers/1.0/html/getting_started_guide/getting-started-with-codeready-containers_gsg

Did UAC popup? Yes

After doing that, and the rror out, can you verify this with:
PS> get-DNSServerClientAddress

Hi @gbraad,
It appears to work properly now with and without docker running. Resetting docker may have affected the network, yet I don't know.
I'm closing this issue, until it appears again. Please let me know if you wish me to perform any verification of things in my local environment.
PS> Get-DnsClientServerAddress returns the following:
InterfaceAlias               Interface Address ServerAddresses
--------------               --------- ------- ---------------
Ethernet                             9 IPv4    {<IP_ADDRESS>}
Ethernet                             9 IPv6    {}
Wi-Fi                               18 IPv4    {<IP_ADDRESS>}
Wi-Fi                               18 IPv6    {}
Local Area Connection* 9            16 IPv4    {}
Local Area Connection* 9            16 IPv6    {fec0:0:0:ffff::1, fec0:0:0:ffff::2, fec0:0:0:ffff::3}
Local Area Connection* 10           11 IPv4    {}
Local Area Connection* 10           11 IPv6    {fec0:0:0:ffff::1, fec0:0:0:ffff::2, fec0:0:0:ffff::3}
Bluetooth Network Connection         7 IPv4    {}
Bluetooth Network Connection         7 IPv6    {fec0:0:0:ffff::1, fec0:0:0:ffff::2, fec0:0:0:ffff::3}
Loopback Pseudo-Interface 1          1 IPv4    {}
Loopback Pseudo-Interface 1          1 IPv6    {fec0:0:0:ffff::1, fec0:0:0:ffff::2, fec0:0:0:ffff::3}
vEthernet (Default Switch)          22 IPv4    {<IP_ADDRESS>}
vEthernet (Default Switch)          22 IPv6    {}


Async Iterables & For await in our SDK

All our readme documents indicate that we support Node 8.x.x. Several of our SDKs have async iterables and our readme have samples have for await. Both are supported only after Node 10.x.x. Or you must supply --harmony_async_iteration to node command. Discuss with team on how to resolve it.

Similar question being asked here: #8635

Doesnt importing the @azure/core-asynciterator-polyfill in our packages solve this for us?
We did this in Service Bus, see #8253
cc @HarshaNalluru, @jeremymeng

The for-await-of syntax doesn't work in Node v8 by default.  It needs the --harmony_async_iteration flag.

Code complete with PR https://github.com/Azure/azure-sdk-for-js/pull/13915


Add all-contributors

Add all-contributors and run it in the Travis process so we're giving contributors proper credit.

This is more of a manual process than I'd hoped for. Automation is probably not feasible in the near-term, so I'm going to close this.


Fix conf for minikube

Solves #292
Requires a Spilo with Patroni >= 1.4.4 to be complete.

:+1:

👍

:+1:


EXEC BAD ACCESS. Device only

Hi @ilyapuchka I am attaching the stack trace for the crashing thread.
This is the log:
Resolving type DataInitializer with arguments ()
Resolving type Database with arguments ()  while injecting in type DataInitializer
Resolving type CoreDataService with arguments ()  while injecting in type Database
AppDelegate.swift.txt
AppDependencies.swift.txt
CoreDataService copy.swift.txt
StackTrace Thread 1.txt
I am still trying to find the issue.
Thanks!

Do you have any optimisations in build settings?
If you have any IUO properties in the registered types try to turn them to Optionals and see if crash still happens.

I have no optimizations.
I don't have any IUO in the objects being resolved. I do have IUO in other dependencies, but none in those 3 objects.

Can you try turning your lazy properties to optionals and initialise them in init and see if it helps?

I removed all the other app dependencies and left only the CoreDataService. I removed the lazy properties and it worked again. As you thought, that is the issue.
Any ideas on why it only happens in the device?

Don't know to be honest, but there were some issues regarding mirroring types with IUO properties (and lazy is still optional, so it might be related). Maybe it is also affected by the fact that it is CoreData types... Will try to reproduce that on a weekend and probably file a bug for Swift, or I will try to come up with some fix to avoid accessing lazy properties while doing auto-injection, as we already do for IUO properties, probably simply by ignoring any property with optional type.
At least now you know what is the issue and I hope not using lazy properties, if any hotfix will not work, will not be a a big issue for you.

Btw you might also try to turn your lazy properties to IUO, that might help as we skip accessing them during auto-injection, so it might work for you without any other fixes on our side

Thanks for everything @ilyapuchka. Removing the lazy properties fixed the problem. I added some code and created a pull request so you can reproduce the crash if you want to.


Images of difference sizes cause instant test failure

Sometimes Cypress takes screenshots of slightly differences sizes during the same test. If the screnshots are different sizes the test fails. But I notice in the code that it calls alignImagesToSameSize function if they are different sizes to try and do the comparison on resized images. If the test always fails what is the reason for alignImagesToSameSize? Perhaps it should attempt to continue with the comparison after resizing the images?
Example of the diff we see in screenshot size between runs:

Hi @dhulme,
Code indeed calls alignImagesToSameSize method to make the images used for the pixelDiff to have the same dimensions. So unless you get some explicit error in the console I would say that this part of code should work well.
I think there might be a big enough difference between new and old image and file diff fails.
Also - why the cypress creates differently sized screenshots? Are there any differences between environments the screenshots are created on? I'm asking, because it doesn't happen in the projects where I'm using this plugin - I might need more info to reproduce that situation.
Can you please post here:

the dump of console output or screenshot from Cypress UI visible when running tests,
the .diff.png file generated by the plugin.

Also could you add additional information about your environment:
OS and version: [e.g. Windows 10 build. 19043.1319]
Browser and version [e.g. chrome 22]
Cypress version [e.g. 8.6.0]
Node version: [e.g. 16.0.1]

Hi @FRSgit, thanks for your reply.
When alignImagesToSameSize is called, isImgSizeDifferent willl be true so it fails automatically on line 166, ignoring the result of pixelmatch? So even if the resized images were below tolerance, it will still fail?
I'm not sure why Cypress is captuing different sized images. It only happens on a couple of my components, The images are all captured on a Linux container in a pipeline (cypress/browsers:node16.14.2-slim-chrome103-ff102), so they should be consistent. I will investigate further. I'm on Cypress 10.4.0.

When alignImagesToSameSize is called, isImgSizeDifferent willl be true so it fails automatically on line 166, ignoring the result of pixelmatch? So even if the resized images were below tolerance, it will still fail?

My bad @dhulme, you're right - if images have different sizes the test will always fail. The image size check can be removed, however that would be a breaking change - I do not want to make without giving other possibility to react on it.

I'm not sure why Cypress is captuing different sized images. It only happens on a couple of my components, The images are all captured on a Linux container in a pipeline (cypress/browsers:node16.14.2-slim-chrome103-ff102), so they should be consistent. I will investigate further. I'm on Cypress 10.4.0.

Are you capturing images during E2E or component-testing?
If during CT then you might want to try to make screenshots of the whole viewport (scale in each test using viewport command so it fits your component).

My bad @dhulme, you're right - if images have different sizes the test will always fail. The image size check can be removed, however that would be a breaking change - I do not want to make without giving other possibility to react on it.

Ok thanks, that makes sense. What would be the process for collecting feedback on the change?

Are you capturing images during E2E or component-testing?
If during CT then you might want to try to make screenshots of the whole viewport (scale in each test using viewport command so it fits your component).

This is in component testing yes. In most cases I've been screenshoting the element in question e.g. button, not the whole viewport. Are you aware of issues with screenshotting elements rather than the viewport?

@dhulme As I won't have time to look into the issue this week I would let it sit here for the time being and see if anybody comes around. If nobody will respond - then it will be up to us 2 (the library doesn't have that much of an audience) 🤷
In the meantime you can give it a try with a PR if you want to - it will surely speed up the process of shipping it!

This is in component testing yes. In most cases I've been screenshoting the element in question e.g. button, not the whole viewport. Are you aware of issues with screenshotting elements rather than the viewport?

No, I'm not. Quite the contrary - I'm using this plugin in projects where elements are being image targets and it works well.
Even in this repo we run on the CI a test that makes a screenshot of a "description" element.

I am having same screenshot size issue with component tests as well. Somehow cypress is not picking up the specified view port when it comes to taking a screenshots. Also having a hard time to match locally uploaded screenshots to match the ones in the ci pipeline. Any suggestion on this?

Hey @oguzhantx!
Can you please open up a new bug request for each of the issues you've mentioned? 🙏  I believe that viewport/screenshot size issues could be tried to looked up on the cypress repository as well.
Regarding mismatch between local and ci screenshots please provide additional data in the new issue you create - example screenshots or at least description what's different between them. And also - elaborate please on what does does it mean to "match locally uploaded screenshots to match the ones in the ci pipeline"? How do you try to do such matching and what do you want to achieve as a result?
Cheers 👋

`@

Hey @oguzhantx! Can you please open up a new bug request for each of the issues you've mentioned? 🙏 I believe that viewport/screenshot size issues could be tried to looked up on the cypress repository as well.
Regarding mismatch between local and ci screenshots please provide additional data in the new issue you create - example screenshots or at least description what's different between them. And also - elaborate please on what does does it mean to "match locally uploaded screenshots to match the ones in the ci pipeline"? How do you try to do such matching and what do you want to achieve as a result? Cheers 👋

I was able to fix the first screenshot problem. looks like setting up the viewport in config file or beforeeach() block does not set the screenshot size by itself. For the screenshot size, I had to tell screenshot to use viewport as well. so this worked --> Cypress.Screenshot.defaults({ capture: 'viewport' });
When I say mismatch, I meant uploading the base screenshots from your local to repo then you run your tests in ci. then test fails in ci because screenshots that are taken on my machine is different than the ones in the ci. Here is the sample failure screenshot. (blocked some content)

@oguzhantx Great to hear that you've been able to fix the first issue. I've added info about that to the README - could you review the PR to check if I got it correctly please?
Regading the mismatch - screenshot done locally will almost always be different than the one on the CI. There are differences in the OS (e.g. every OS renders fonts a bit differently), in headless vs windowed mode and other things. The main flow for working with the screenshots is to generate & compare them on the CI (and maybe generate & compare other copy of screenshots for better developer experience). If you feel that there is still something left regarding this topic - please open up a new issue as it's not connected with the one created by @dhulme

Hey @dhulme!
I've just created new PR resolving this issue: #108. I've published it to npm under 2.0.0-alpha.0, can you give it a try please? 🙏

Hi @FRSgit, sorry for the delay. That's working great, thanks!

Uf, I started wondering what should I do with this PR 😄 Thanks for confirming that it works @dhulme!
I'll do a full 2.0.0 release later today

Released 🎉

@oguzhantx Great to hear that you've been able to fix the first issue. I've added info about that to the README - could you review the PR to check if I got it correctly please?
Regading the mismatch - screenshot done locally will almost always be different than the one on the CI. There are differences in the OS (e.g. every OS renders fonts a bit differently), in headless vs windowed mode and other things. The main flow for working with the screenshots is to generate & compare them on the CI (and maybe generate & compare other copy of screenshots for better developer experience). If you feel that there is still something left regarding this topic - please open up a new issue as it's not connected with the one created by @dhulme

@FRSgit I'm actually having the same issue running cypress in headless mode but changing monitors.
If I run the matchImage for the first time, in headless, using one monitor, when I run it with a different monitor, even in headless, the snapshot fails with just some fonts mismatching. Any idea what this could be?

@idasilva1 unfortunately the screen density has an effect on the rendering of a webpage - which might be causing the test to fail :(
Also, it's possible to force the same resolution for different screens/modes only in chrome testing as the only solution to this issue works for Chrome-only.
Cypress says this issue was fixed in 8.0.0, but well - not completely as can be seen here, here and here.
From my experience I would propose to:

setup capture: 'viewport' configuration (more details in our FAQ section),
always try to make a screenshot of a part of your screen (never make a screenshot of a full page with cy.matchImage() as the size of the cypress window might differ).


Test Fail: account test › Increase time to specific time point › should increase time to able to add new epoch

FAIL  test/passingtime.test.ts (36.271 s)
● account test › Increase time to specific time point › should increase time to able to add new epoch
assertion failure with message: only start next epoch once the previous epoch has done

  at new RpcError (node_modules/eosjs/src/eosjs-rpcerror.ts:14:13)
  at JsonRpc.<anonymous> (node_modules/eosjs/src/eosjs-jsonrpc.ts:97:19)
  at step (node_modules/eosjs/dist/eosjs-jsonrpc.js:37:23)
  at Object.next (node_modules/eosjs/dist/eosjs-jsonrpc.js:18:53)
  at fulfilled (node_modules/eosjs/dist/eosjs-jsonrpc.js:9:58)

@rdewilder which system are you're run the test? FYI, it works fine in MAC M1 ARM64 and Ubuntu AMD64 on my side


Currency in product price changes when changing language.

Currency in product price changes when changing language.
Currently: Language: EN = $ 1,800 when changing to pt-BR = R$ 1,800.
Correct: Do not change currency.
The best would be if there was an option to select the currency in the product register.
Or make the nopCommerce style price change.
use the website http://www.ecb.europa.eu/stats/eurofxref/eurofxref-daily.xml
to obtain exchange rates

Hey! this question is very important!
The price of products change as the site language changes.
In the product register you should have the option to select the currency.

I want to start creating the currency module.
okay for you?

I see most of the time, ecommerce websites are targeted and deployed to each country, so on the site there are 1 language and 1 currency.
But yes, you are welcomed. It will be best if we can build an module for it and plug it in on demand

@afernandes Hello :) Did you start with the currency module?

@thiennn Canadian shops need English and French, but only CAD currency. Lots of other examples.

Unfortunately, I was out of time, but I believe that Monday I will be able to start the creation of the module.
I'm thinking of creating something similar to what exists in nopCommerce, but feel free to start the creation of the module or if you have suggestions and ideas for the module.

work in progress

@afernandes how long will you take to finish the module??

I am considering adding a simple helper for formatting the price. Let say in the admin, there will be a setting for currency:

The culture you want to display for currency
The routing type ex. how many decimal places
The helper will format the price base on those settings. There should be 1 currency for entire the site regarding to the language

I already did some things.  but I don't know if I made the best decisions.  I relied heavily on nopcommerce.
I did the Exchange part but the helper is missing
https://github.com/afernandes/SimplCommerce/tree/ExchangeRateProvider?files=1
I later discovered this project, which seems interesting to me.  but I haven't had time to test yet
https://github.com/zpbappi/money
To make something simple that works for everything, it would be interesting to register the coin in the product itself, near the price.  then put default currency in vendor.


Allow to use "." for swapping

Fix #35

If possible I would recommend avoiding vim-repeat.  Instead you can use vim's native g@ like in this example:
https://gist.github.com/andymass/d465970cc178452eac006840e5e58b2b
Specifically, although g@ is usually used as the start of normal operators you can also use it for entire normal commands with the sequence g@l.

@andymass can you create a PR for it? I can't think of a elegant way to implement this. As far as I understood, we must set operatorfunc. But we can't refer to our Lua functions with v:lua because we have a - in our folder name. Also we would have to create a outer function that sets the operatorfunc and an inner that does the actual action.
Can't you use the g@l hack already now in your config?

Can't you use the g@l hack already now in your config?

Yes, it's possible via a wrapper function;
function! s:repeatable(cmd)
  function! s:inner(...) closure abort
    execute a:cmd
  endfunction
  let &opfunc=get(funcref('s:inner'), 'name')
  return 'g@l'
endfunction

nnoremap <silent><expr> <left>
      \ <sid>repeatable('TSTextobjectSwapPrevious @parameter.inner')
nnoremap <silent><expr> <right>
      \ <sid>repeatable('TSTextobjectSwapNext @parameter.inner')

But we can't refer to our Lua functions with v:lua because we have a - in our folder name.

I think that could be fixed fairly easily, but a problem remains that there would have to be some state held somewhere and I'm not sure how to refer to lua inner functions in operatorfunc.

can you create a PR for it?

Here is a first shot at it using the same technique as above: #55 .  I'm not sure how to do it with pure lua.

Ping

Bump

Super-seded by #343 or #55


'apksigner' returned with error # 1 when exporting to android?

Godot version:

Godot 3.3
OS/device including version:

Nvdia GT630M, Laptop ASUS K43s, GLES3, Windows 7 64 Bit
Issue description:

Hello, recently i updated godot to version 3.3, and i am having a problem when i try to export to android.
the following message appears:
'apksigner' returned with error # 1
This problem did not happen in previous versions, can someone help me please?
Steps to reproduce:

Install required component:
sdkmanager --sdk_root=<android_sdk_path> "platform-tools" "build-tools;30.0.1" "platforms;android-29" "cmdline-tools;latest" "cmake;<IP_ADDRESS>88404" "ndk;21.4.7075529"

Try to export it with:
Project -> Export -> Android

My setting in Editor:

The Adb and Jarsigner project settings are no longer used in Godot 3.3, but they'll still appear in the Editor Settings if you've upgraded from 3.2 due to https://github.com/godotengine/godot/issues/22099.
Instead, you need to set the Android Sdk Path only.

I have 'apksigner' returned with error # 2.

The Adb and Jarsigner editor settings are no longer used in Godot 3.3, but they'll still appear in the Editor Settings if you've upgraded from 3.2 due to #22099.
Instead, you need to set the Android Sdk Path only.

okay, i've already reset my editor settings, now it looks like this:

but, it still error: 'apksigner' returned with error # 1

Maybe related https://github.com/godotengine/godot-docs/issues/4796, try to update build-tools to 30.0.3 version. To find more explicit error message run godot in verbose mode godot -v

@komputerboy I came across this error and found the problem was that I needed to provide the debug.keystore username & password in the Export options (Export -> Options -> Keystore) as well when I went to export the project for Android.
I made a pull request to update the tutorial documentation to reminder developers to do this, but I'm wondering if this is a bug where the Editor Settings should be propagating to as defaults to the Export options?


Docs: Added guide on DApp Automation and Testing using Cucumber and Playwright

What

Improved Quick Start Guide Setup in Hackathon Starter Kit
Added guide on DApp Automation with Cucumber

Why

New guide and starter kit
Docs improvement

Refs

Task

content/rsk-devportal/guides/starter-kits/dapp-automation-cucumber.md:63
Change the way the extensions are presented from this...
{
   "recommendations": [
       "muralidharan92.cuke-step-definition-generator",
       "alexkrechik.cucumberautocomplete"
   ]
}

To:
Name: Cuke Step Definition Generator
Author: Muralidharan Rajendran
Description: This VSCode extension aids users by generating Cucumber Glue / Step Definition snippets for selected statements, streamlining work with Cucumber JS in VS Code.
Link: Cuke Step Definition Generator.
Name: Cucumber (Gherkin) Full Support
Author: Alexander Krechik
Description: This extension provides comprehensive language support for Cucumber (Gherkin), including syntax highlighting, snippets, autocompletion, and format support across multiple programming languages such as JS, TS, Ruby, and Kotlin.
Link: Cucumber (Gherkin) Full Support.

Cucumber (Gherkin) Full Support

Done @jesus-iov


prom2teams chart is too old and does not include http_proxy environment variables

You are using a too old chart that do not allow to add the HTTP_PROXY info to the deployment.
Thi affect rancher-alerting-drivers chart that includes it.
Please update it asap

Just update the upstream could be easier


Greek alphabet missing

Microsoft PowerToys version
0.74.0
Installation method
PowerToys auto-update
Running as admin
None
Area(s) with issue?
Quick Accent
Steps to reproduce

✔ Expected Behavior
To see the Greek letters like α when using quick accent on the letter A, or β when using it on letter B
❌ Actual Behavior
I see other letters from other idioms but not Greek
Other Software
No response

/dup #28813


Adding Jedis HSTRLEN command request #1404

Hi,
Here is the pull request for HSTRLEN command

Update parameter names and Test.

Sorry I closed PR by mistake

@smadasu can you please rebase?

New PR after rebasing

Why is it failing just for openjdk7, I don't understand

Travis CI has some bugs with OpenJDK. Maybe we want to get rid of checking OpenJDK.

@smadasu Tests still not moved to proper place. If you want me to move them, please let me know. I'll take care of it.

Sure @HeartSaVioR . Go ahead and clean them up. Thanks for your help.

@HeartSaVioR @smadasu I've re-run the tests for JDK 7 and we're ok now. Sometimes they fail because because of the timeouts.

OK then LGTM from me.
@marcosnils Please take a look as well. Thanks!

LGTM!

Tests polished via 6a933f1 for master, and 128cb2d for 2.10.
@smadasu Thanks for the contribution!

@HeartSaVioR LGTM!.


Add FixMe Mode

VSCode lacks a FixMe mode. Pretty fundamental stuff for a source code editor.
This feature constantly gets deferred with "belongs in an extension"; except the extensions are garbage.
 It will take a few years, but they will. Users like me will just go back to Vim or Emacs instead of contributing to this dumpster fire.

@shogerr I was dealing with a similar issue and found this to be a helpful resource

@ryankeener
Hey, I'm only meeting the community promoted here at VSCode. You all have somehow managed to create a fairly unfriendly project to participate in. I believe VSCode is a viable editor that may end up existing in 10 years, which is why I'm still here.
However, Microsoft has a history of sending everyone's work down the garbage chute when the work doesn't align with their business values.  Microsoft itself is responsible for the negativity in the community surrounding their work  simply because they've spent the last 5 decades trashing users and developers in search of the dollar.
Calling frustration or anger towards MS as an entity misplaced is moderately laughable, and shows you don't understand the negative force MS has been in the industry.
	Patent	License.	You	grant	Microsoft,	and	those	who	receive	the	Submission directly	or
indirectly	from	Microsoft,	a	perpetual,	worldwide,	non-exclusive,	royalty-free,	irrevocable	license	under
Your	patent	claims	that	are	necessarily	infringed	by	the	Submission	or	the	combination	of	the
Submission	with	the	Project	to	which	it	was	Submitted	to	make,	have	made,	use,	offer	to	sell,	sell	and
import	or	otherwise	dispose	of	the	Submission	alone	or	with	the	Project.

@shogerr
Sorry about the snarky response earlier but you do seem very angry about a free product that you don't have to use. As you suggested, you could just use Vim or Emacs if you don't want to use something by the Bill Gates Evil Empire.
If you're still interested in a FIXME feature for Vscode you might take a look at https://github.com/Gruntfuggly/todo-tree I've been using it for quite some time and find it very useful.
Fwiw, I'm not affiliated with this project in any way, just a satisfied user.


cannot make the license auto add

i sucecssfully logged in my github accournt,
choosed the gnu-pl license v2,
checked my repos, except the forks, added the text url to the text, and i end up on a 404 error.
is it working for anyone else? :)

same for me, it seems flakey because sometimes the add works and sometimes not - seems especially unreliable if you pick more than 1 repo at a time

Same here ;-(

👍


Make sure correct email variables are available for all email templates.

E.g. the variable email is missing here:
https://github.com/nhost/hasura-auth/blob/main/src/routes/user/email/change.ts#L74-L80
The variables we say are available: https://docs.nhost.io/platform/authentication/email-templates#variables

link
serverUrl
clientUrl
redirectTo
ticket
displayName
email
locale

I also think we could add the following variable to all email templates:

newEmail

@plmercereau is this fixed as I'm see seeing ${email} and not the actual value today?

We'll roll out this to Nhost Cloud in the next few days.


Firefox deprecated navigator.getUserMedia

Source: https://developer.mozilla.org/en-US/docs/Web/API/Navigator/getUserMedia
They replaced it with navigator.mediaDevices.getUserMedia. This project should check against that API.

Also, as far as I know, using getUserMedia.js one can  only take 640x480 photos, while even 1920x1080 is supported by navigator.mediaDevices.getUserMedia.
Though, navigator.mediaDevices.getUserMedia is not fully supported in may browsers, https://github.com/webrtc/adapter adapter takes care of it.


Edit existing comments

It is currently not possible to edit existing comments we left, if we've made a mistake for example.

What should be done if we decide to remove all the content of a comment?

As we discuss, the comment should be mark as "deleted", but we should keep its content.


[Question] Is migration over to watch face format considered?

I've missed this watch face ever since moving to the pixel watch 3 which launches with wear os 5 and enforces the usage of watch face format (wff) and I'd love to be able to use it again. I understand that it might be a huge endeavor and I'm just wondering

Hi Anh,
I have considered re-implementing the watch face in WFF, however it appeared like being a high-risk/low-reward situation so I haven't made any effort on it.
Reasons:

The Hybrid Interface is not enabled on Pixel Watch 3, even if it has the hardware capabilities (auxiliary MCU). Even if I implemented it, I speculate there would be minimal battery gains, if any.
The WFF format was enforced by Google despite developers being vocal about their concerns with it, i.e. its lack of adoption and restrictions.
(opinion) XML is not fun to write, or easy to maintain.
I only own an OG Pixel watch and do not intend to upgrade, unless the battery life improves significantly on some future model. One day of battery life is not good enough for me; having to choose between sleep tracking and finess tracking is not acceptable.

Due to this, I am more or less unable to test the watch face properly, even if I adapt it to use WFF.

Maybe, when I find the time and courage, I shall delve into WFF. I am leaving that possibility open.


Send standard output of commands to keyboard input

I thought it would be useful to be able to send the standard output of a command to keyboard input, as in the following image.
How do you feel about this?
Example 1
[ids]
0001:0001

[main]
space = overload(layer1, space)

[layer1]
semicolon = command-out(echo -n $(date +%Y%m%d-%H%M%S))
r = command-out(sudo --user user1 /home/user1/.local/bin/msg/sales_report_daily.sh

@herrsimon I got the desired results below. Thank you.
# ydotoold &
 423065
#

/etc/keyd/hhkb.conf
[main]
space = overload(layer1, space)
[layer1]
a = command(ydotool type "$(date +%Y%m%d-%H%M%S)")

Your r binding is not good style, as it makes apparently personal information (to user1) available systemwide.

Indeed, when I think about it, it is a dangerous form of operation for a super user to touch a general user's resources, because you never know what kind of trap may be set. We should reduce contact to the maximum extent possible, or at least avoid executing it.
I am convinced.
Thank you for your kind advice.

I'm not entirely opposed to this.

a word of warning: Your r binding is not good style, as it makes apparently personal information (to user1) available systemwide. Such functionality is better implemented directly as a macro in your editor.

+1. This sort of thing is why I was originally reluctant to implement command() at all. Though now that pandora's box has been opened, it isn't too much of an additional risk to add something like command-out.
I've been contemplating allowing the user to input text and execute macros directly, which could also be used in conjunction with command() in a similar fashion to your ydotool solution.
E.G
command(date|keyd --input-text)
My main problem with this is that there isn't an obvious mapping between text and input codes. The natural solution is to use KEY_A for a, KEY_B for b etc but that assumes a qwerty layout on the display server (potentially reasonable) and doesn't account for non-printable/typable characters. I assume ydotool takes this approach, though I haven't used it.

I ran the following 1-2, a-g
[main]
space = overload(layer1, space)

[layer1]
# https://github.com/ReimuNotMoe/ydotool/blob/master/manpage/ydotool.1.scd
command(date|keyd --input-text)

1 = command(ydotool type "$(date)")
2 = command(ydotool type "$(date +%Y%m%d-%H%M%S)")
a = command(ydotool type 'a')
b = command(ydotool type 'b@&')
c = command(ydotool type 'cＣ'
d = command(ydotool type 'dシ')
e = command(ydotool type 'e漢字')
f = command(ydotool type 'f👍')
g = command(ydotool type 'g🤤')

result
Sun May 29 02+53+56 PM JST 2022
20220529-145359
a
b"'
c
d
e
f
g

As for "b", I am using a Japanese keyboard, which makes a difference in the layout. As you pointed out, the standard specifications (US 101 keyboard with ASCII only?) I guess that is the case.
It may not have much to do with the essence of what we are doing now, but I was curious about the process that remained.
# pgrep -a ydotool
574279 ydotoold
583161 ydotool
583164 ydotool
583175 ydotool
583183 ydotool
583185 ydotool
583186 ydotool
583187 ydotool
# systemctl restart keyd
# pgrep -a ydotool
574279 ydotoold
#

When the command is executed directly, no process seems to remain.
# pgrep -a ydotool
574279 ydotoold
# ydotool type 'a'
a# pgrep -a ydotool
574279 ydotoold
#

In a naive way, I imagine the following policies, etc.

Do nothing.
Leave such processing to the following clipboard tool, etc., and leave it outside the scope of the area handled by keyd
https://github.com/astrand/xclip
https://github.com/bugaevc/wl-clipboard

Process only ASCII.
Do not take into account differences in key sequences.

Output according to some conversion table.
(XKB layout, UTF-8, etc.).

I ran the following 1-2, a-g
[...]

Thanks for running these experiments. As expected it chokes on unicode since it is keycode driven.

As for "1" colon and "b" @&, I am using a Japanese keyboard, which makes a difference in the layout. As you pointed out, the standard specifications (US 101 keyboard with ASCII only?) I guess that is the case.

Indeed, the config syntax is based on keycodes which use the kernel names (which are in turn based on a US ANSI layout). This shouldn't prevent you from remapping keys, but you may have to use -m to figure out which keycodes correspond to the physical positions on your board. I need to document this better.
This is also the principal difference between evdev based tools like ydotool and display server tools like xdotool. The latter can output keysyms directly, bypassing any translation done by the display server, which means it will always produce the correct output irrespective of the keymap.

It may not have much to do with the essence of what we are doing now, but I was curious about the process that remained.
[...]

Thanks for reporting this. It is a bug. The processes are zombie processes, which means they have actually terminated but still show up in your process list. It should be fixed in the latest commit.

In a naive way, I imagine the following policies, etc.
[...]

Do nothing

+1

Process only ASCII.
Do not take into account differences in key sequences.

This is currently how macros (and keyd generally) work. The user is expected to understand that keyd is a low level tool for manipulating input codes (like QMK). For English ANSI boards the difference between keycodes and keysyms can mostly be ignored, but ultimately converting keycodes into symbols is the display server's job.

Output according to some conversion table.

Also known as the layout :P.
I am inclined to agree that proper text input is a job for display server level tools, though it probably makes sense to allow macros to be executed directly using the client. Adding a 'raw' mode so the user can do input(Hello World) instead of macro(Hello space World) seems like a natural extension.

This should now be possible using a combination of command() and the new input command.
E.G
home=command(date|keyd input)

Checked. Works very quickly, clear and comfortable. Thank you!


Why Grommet section of home page has issues with IE11

Expected Behavior
Why Grommet section should render properly on supported browsers.
Actual Behavior
Tiles are overlapping on Windows 7 with IE 11
URL or screen shot exhibiting the issue

Steps to Reproduce

Visit homepage with IE 11.

Your Environment

Browser Name and version: IE 11

Operating System and version (desktop or mobile): Windows 7 desktop

Also reproduced with BrowserStack Windows 7 and IE 11.

Fixed by @alansouzati


Add section on upgrading talos and kubernetes to readme

A section in the readme for performing upgrades with task to both talos and kubernetes would be helpful.

Feel to to PR a section, if not I will get to it some day 😄


max_tokens param not work in ChatPerplexity model

Checked other resources

[X] I added a very descriptive title to this issue.
[X] I searched the LangChain documentation with the integrated search.
[X] I used the GitHub search to find a similar question and didn't find it.
[X] I am sure that this is a bug in LangChain rather than my code.
[X] The bug is not resolved by updating to the latest stable version of LangChain (or the specific integration package).

Example Code
chat_prompt = ...

model = ChatPerplexity(
    pplx_api_key=PERPLEXITY_API_KEY,
    model="llama-3.1-sonar-small-128k-online",
    temperature=0.1,
    max_tokens=200,
)

chain = chat_prompt | model

response = chain.invoke(...)

Error Message and Stack Trace (if applicable)
No response
Description
Perplexity Docs Example :
import requests

url = "https://api.perplexity.ai/chat/completions"

payload = {
    "max_tokens": 100,
    "model": "llama-3.1-sonar-small-128k-online",
    "messages": [
        {
            "content": "read me a long fairy tale",
            "role": "user"
        }
    ]
}
headers = {
    "Authorization": ...,
    "Content-Type": "application/json"
}

Langchain’s Current Implementation :
https://github.com/langchain-ai/langchain/blob/16918842bf86de1b493229310b0f6fc593d7a686/libs/community/langchain_community/chat_models/perplexity.py#L147-L156
https://github.com/langchain-ai/langchain/blob/16918842bf86de1b493229310b0f6fc593d7a686/libs/community/langchain_community/chat_models/perplexity.py#L267-L275

Suggestion :
 @property
 def _default_params(self) -> Dict[str, Any]:
     """Get the default parameters for calling PerplexityChat API."""
     return {
         "request_timeout": self.request_timeout,
         "stream": self.streaming,
         "temperature": self.temperature,
         **self.model_kwargs,
     }

 @property
 def _invocation_params(self) -> Mapping[str, Any]:
     """Get the parameters used to invoke the model."""
     pplx_creds: Dict[str, Any] = {
         "api_key": self.pplx_api_key,
         "api_base": "https://api.perplexity.ai",
         "model": self.model,
         "max_tokens": self.max_tokens,
     }
     return {**pplx_creds, **self._default_params}

System Info
System Information

OS:  Darwin
OS Version:  Darwin Kernel Version 24.1.0: Thu Oct 10 22:08:48 PDT 2024; root:xnu-11215.41.3~5/RELEASE_ARM64_T6000
Python Version:  3.10.14 (main, Mar 19 2024, 21:46:16) [Clang 15.0.0 (clang-15<IP_ADDRESS>)]

Package Information

langchain_core: 0.3.17
langchain: 0.2.15
langchain_community: 0.2.14
langsmith: 0.1.128
langchain_anthropic: 0.3.0
langchain_experimental: 0.0.57
langchain_google_genai: 2.0.4
langchain_google_vertexai: 1.0.4
langchain_mongodb: 0.2.0
langchain_openai: 0.0.5
langchain_text_splitters: 0.2.2

Optional packages not installed

langgraph
langserve

Other Dependencies

aiohttp: 3.9.3
anthropic: 0.39.0
anthropic[vertexai]: Installed. No version info available.
async-timeout: 4.0.3
dataclasses-json: 0.6.7
defusedxml: 0.7.1
faker: Installed. No version info available.
google-cloud-aiplatform: 1.51.0
google-cloud-storage: 2.16.0
google-generativeai: 0.8.3
httpx: 0.27.2
jinja2: 3.1.2
jsonpatch: 1.33
numpy: 1.23.1
openai: 1.10.0
orjson: 3.10.2
packaging: 23.2
pandas: 2.2.0
pillow: 10.1.0
presidio-analyzer: Installed. No version info available.
presidio-anonymizer: Installed. No version info available.
pydantic: 2.9.2
pymongo: 4.8.0
PyYAML: 6.0.1
requests: 2.31.0
sentence-transformers: Installed. No version info available.
SQLAlchemy: 2.0.25
tabulate: 0.9.0
tenacity: 8.2.3
tiktoken: 0.5.2
typing-extensions: 4.9.0
vowpal-wabbit-next: Installed. No version info available.

Hello, we are a group of students from the University of Toronto Scarborough. We are interested in working on this issue, and we hope to have a working PR soon.

Hi, I'm part of the team investigating this. I was able to successfully reproduce this error and found that not only is max_tokens not respected, neither is temperature and I presume the other kwargs as well. Your suggested fix unfortunately didn't work, but we're investigating another fix and should have have it by tomorrow.

Thanks for the fix. I needed this for work


[FEATURE] Additional Authentication Providers.

Is your feature request related to a problem? Please describe.
Currently it seems only local user auth and k8s auth is supported. In an enterprise its typical to need to manage users, credentials and roles in a central authentication system. E.g. LDAP, Azure AD, Okta, Redhat SSO etc.
Describe the solution you'd like
Ability to connect authentication to LDAP, Azure AD, Okta etc.
Describe alternatives you've considered
There isn't one.
Additional context
Rancher support the above external auths, i guess the expectation would be for harvester to have similar level of auth integration support.

Along with this it would be important to be able to auto map roles to internal role authorisations that provide access/restrictions to functions areas/logical spaces, whilst i assume this would be a given, i think it just important to be explicit just to avoid any assumption.

@michaelpearce-gain This will be covered by #552 and #582 in v0.3.0 release.
I will close this issue as a duplicate for now. Feel free to reopen it or follow up in the above issues if there are more questions.


feat: new logger and improve code

Hey!
This PR fixes the use of Go's println, as it is not recommended (use fmt.Println). It also modifies the way variables are defined at application startup and improves the connection to the database. Some improvements to avoid code repetition in REST routes have been implemented.

It's needed to check why Mutex was not working.


tus-js-client: 2.3.0 to 2.3.2

Bumped version.
Use newly exported type to remove type errors in the IDE.

Tested for a few hours ... looks ok.

Don't really have any direct behaviorial fixes that would benefit us, but it includes a few smaller fixes and dep updates.  I guess no harm upgrade to latest and greatest?


Generating select into join clause

I'm getting this SQL when i'm making a join clause:
select
  "CALL_REQ"."ID",
  "CALL_REQ"."DESCRIPTION",
  "CUSTOMER"."CONTACT_UUID" "CUSTOMER_CONTACT_UUID",
  "CUSTOMER"."FIRST_NAME" "CUSTOMER_FIRST_NAME",
  "CUSTOMER"."LAST_NAME" "CUSTOMER_LAST_NAME"
from
  "CALL_REQ"
  inner join (select "CA_CONTACT".* from "CA_CONTACT") "CUSTOMER" on "CUSTOMER"."CONTACT_UUID" = "CALL_REQ"."CUSTOMER"
where "CALL_REQ"."PERSID" = ? and "CALL_REQ"."TYPE" = ?

My db connector is oracle.
Here is my code:
// ticket.js
export default class Ticket extends Model {

    static get tableName() {
        return 'CALL_REQ';
    }

    static get idColumn() {
        return 'PERSID';
    }

    static get relationMappings() {
        const Contact =  require('./contact').default;
        return {
            customer: {
                relation: Model.BelongsToOneRelation,
                modelClass: Contact,
                join: {
                    from: `${Contact.tableName}.CONTACT_UUID`,
                    to: `${Ticket.tableName}.CUSTOMER`
                }
            }
        }
    }
}

// contact.js
export default class Contact extends Model {

    static get tableName() {
        return 'CA_CONTACT';
    }

    static get idColumn() {
        return 'CONTACT_UUID';
    }
}

And in my query js file i have
let fields = ['CALL_REQ.ID', 'CALL_REQ.DESCRIPTION']
    .concat(['CUSTOMER.CONTACT_UUID as CUSTOMER_CONTACT_UUID',
    'CUSTOMER.FIRST_NAME as CUSTOMER_FIRST_NAME',
    'CUSTOMER.LAST_NAME as CUSTOMER_LAST_NAME']);

return await Ticket.query()
    .findById(id)
    .select(fields)
    .joinRelated('customer', { alias: 'CUSTOMER' })
    .andWhere(Ticket.tableName + '.TYPE', 'R');

What i've to do to get the next SQL?
sql
select
  "CALL_REQ"."ID",
  "CALL_REQ"."DESCRIPTION",
  "CUSTOMER"."CONTACT_UUID" "CUSTOMER_CONTACT_UUID",
  "CUSTOMER"."FIRST_NAME" "CUSTOMER_FIRST_NAME",
  "CUSTOMER"."LAST_NAME" "CUSTOMER_LAST_NAME"
from
  "CALL_REQ"
  inner join "CA_CONTACT" "CUSTOMER" on "CUSTOMER"."CONTACT_UUID" = "CALL_REQ"."CUSTOMER"
where "CALL_REQ"."PERSID" = ? and "CALL_REQ"."TYPE" = ?

I'm using<EMAIL_ADDRESS>Thanks!

You shouldn't be getting that SQL from that query. I've seen people getting this kind of queries before, but none have ever provided a reproduction for them.
Objection has tests for joinRelated queries like that, and they don't produce the subquery in the join. I'd be happy to fix this bug, but I really don't know how to reproduce it. Could you provide a standalone script that reproduces this? Something I can run with a single command like node reproduction.js.

Having said that, why do you want to get rid of the subquery? All modern database engines optimize the subquery away and both the current query and the query you want, end up running exactly the same operations in the database engine.

Well, i just wanted to check the performance of each query (which is bigger than i've posted here). I will try to reproduce it in the test but i can't use the database credentials so i will use sqlite. ¿Can this issue related with the connector?

You can use sqlite. I don't think this can be related to the db driver. I tried the code you posted, but It didn't reproduce the bug. So it's caused by your setup somehow.

Well, i just wanted to check the performance of each query

Did you actually measure the performance or did you just assume it's slower because of the subquery? If the latter, that's rarely useful.

I've measured the performance and the currently built sql is slower (from 100ms to 20ms more or less) so i will try to send you a complete example reproducing the error.

@moutb Any luck reproducing this?

Hi @koskimas, I just got back from vacation and I haven't tried it yet. I'd like to do it this weekend.


docs: edit title, del nacos introduction

Edit title, del nacos introduction and add Apache APISIX introduction

@hf400159 you can update contents and file names as well. See https://github.com/apache/apisix-website/pull/915.

@hf400159您也可以更新内容和文件名。见#915。

Close this pull request, conflicts were solved in #923


4 implement a circuit stage

Not ready for merging yet, but in a stage ready to be shown. Variable names are not final, still finding bugs and extremely finicky about how it likes its arguments being passed.
basic example:
  reg4 ← reg 4
  reg4[1;2] ← ⊂q1
  reg4[2;2] ← ⊂(H+.×q0)
  gates ← (H 2) (CNOT (0 3))
  (1) gates stage (thread_reg reg4)

You are measuring qubit 1 and applying a CNOT gate with qubit 0 as control and 3 as target and an H gate to qubit 2

I found a bug when trying to apply a CNOT gate from example from qubit 4 to qubit 0, for some reason nothing seems to be happening and I could not figure out why this was the case. Maybe we could discuss it in person


autoplaylist.txt

how do i play an autoplaylist?

Edit options.ini file UseAutoPlaylist = yes
If you want your own songs to be played by the autoplaylist go to autoplaylist.txt and delete everything. Then add youtube urls with the songs, each link has to be on a DIFFERENT line

ty!


switch to markup-it upstream repo

Current markup-it dep is based on @cassiozen's fork - moving to upstream (his changes were merged in https://github.com/GitbookIO/markup-it/pull/26). Using the latest release in the currently used major release line 2.x.

LGTM

LGMT


NUT-04: Add optional memo for PostMintQuoteBolt11Request

There have been multiple requests to be able to control the memo of an invoice. The availability of this option could depend on the backend used.
NUT-04 should have an optional memo field that a mint can can choose to honor (if their Lightning backend supports setting it).

Along with the option for memo and expiry it would be good to have description_hash. LUD 06 requires the invoice to be generated with a description hash.

Along with the option for memo and expiry it would be good to have description_hash. LUD 06 requires the invoice to be generated with a description hash.

Most backends don't allow you to set the expiry, so I'm reluctant to make this user configurable. As for the description hash, there has been an ongoing debate whether that should be removed or not. The majority of wallets don't care about it and most backends also don't let you set it (or in the case of CLN require you to know the entire description to be able to pay).
I think memo makes sense, description hash maybe too if the need is there (although I think it doesn't matter anymore, so I'd also ignore it), but for the expiry I'm doubtful that it should be a user choice.

Agreed that expiry doesn't need to be in there if its not well supported.
If description hash gets removed from LUD 06, then I also don't think description hash is necessary. As it is now very few lightning address providers seem to validate it anyways.

As it is now very few lightning address providers seem to validate it anyways.

That matches my experience, I think there might be some that will hash the full description and check that instead if there's a d tag but not h

I'm not sure this should added it creates an opportunity for the mint to learn more about the user and/or their intentions then is required to mint ecash which i think should be discouraged.

I'm not sure this should added it creates an opportunity for the mint to learn more about the user and/or their intentions then is required to mint ecash which i think should be discouraged.

Good point but I think it should still be optional. The mint can also read all the memos of the invoices they are paying.

Good point but I think it should still be optional so that mints can provide the same user experience as any other lightning wallet.

For the receiver the wallet could add a description tied to the mint quote. However, as you say that doesn't help the payee know what they're paying. So adding the optional field would allow that same experience and leave it up to the wallet to make the privacy trade off or not.

The mint can also read all the memos of the invoices they are paying.

Right but that's a reality of lighting not a choice within the NUTs.

Proposal to add optional description field is here:
https://github.com/minibits-cash/nuts/blob/request-desc/04.md

Proposal to add optional description field is here:

Could you open a PR and link to it here for tracking?


TranslucentMesh does not function for block pickups

When dropping blocks, the translucent value is not copied over to the MeshComponent.  However, after fixing this, these blocks (like core:ice)  do not render at all.  The code to render these translucent meshes is very different from the opaque version.  Likely it is just dusty?

Try it again with the latest fix for translucent meshes in MovingBlocks/Terasology#1591. Maybe that fixes the problem right away ;)


Replace the warning about missing when using coerce with info

Generally a warning suggest the user may want to question the current approach, which isn't the case here - just that there are missing values, in case this wasn't noticed.

Codecov Report

Merging #41 into dev will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##              dev      #41   +/-   ##
=======================================
  Coverage   99.11%   99.11%
=======================================
  Files           7        7
  Lines         225      225
=======================================
  Hits          223      223
  Misses          2        2

Impacted Files
Coverage Δ

src/convention/coerce.jl
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b828c1...a37ecbc. Read the comment docs.


additional-skip-pattern is invalid

add additional-skip-pattern is invalid，even if i create a bean as ClientSampler.NAME, but not run into this class's method 'trySample'

Can you provide a complete, minimal, verifiable sample that reproduces the problem? Can you also provide any meaningful information about the used versions? It should be available as a GitHub (or similar) project or attached to this issue as a zip file.

1.versin is 2.0.0.RELEASE
2.example  ：
`public class MySleuthClientSampler extends HttpSampler {
private final Pattern pattern;
MySleuthClientSampler(SkipPatternProvider provider) {
this.pattern = provider.skipPattern();
}
@Override
public  Boolean trySample(HttpAdapter<Req, ?> httpAdapter, Req req) {
String url = httpAdapter.path(req);
boolean shouldSkip = this.pattern.matcher(url).matches();
if (shouldSkip) {
return false;
}
return null;
}
}`
bean code：
@Bean(name = ClientSampler.NAME) 	@Primary 	@Order(Ordered.HIGHEST_PRECEDENCE + 1) 	public HttpSampler mySleuthClientSampler(SkipPatternProvider provider){ 		return new MySleuthClientSampler(provider); 	}
setting:
  sleuth:     sampler:       probability: 1.0     web:       additional-skip-pattern: "/hi2"
3.describe
I debug at method trySample, but restTemplete(bean) as client to invoke http method never debug into line.
I did not want to report client that contain "/hi2", and additional-skip-pattern is invalid.
4. run program
sample is spring-cloud-sleuth-sample-zipkin

5.env is spring boot 2.0.3.RELEASE integrate spring cloud sleuth, so match sleuth's version is 2.0.0.RELEASE

and if create a bean as ServerSampler.NAME, and i invoke  http（GET）that controller give ，will debug into method trySample,so  as server is normal ，just as client is invalid .
if  not create a bean as client by myself, just set additional-skip-pattern: "/hi2",also is invalid.

Please use the latest stable release begin. Sleuth 2.0.0 is old


Issues: 1116, bugfix release

Fixes #1116
Problem:
This issue is a few fold:

RPM spec file format was not being followed properly

Requires:   , [repeat]

RPM was not actually installing dependencies during test
RPM was not failing when project package failed to install during test
DEB was not actually installing dependencies during test
DEB was not fialing when project package failed to install during test

Analysis:

added a check_requires() function that will add the proper formatting

Change performed in the build-rpm.py

Changed the Dependency.cmd to be handled differently with a
Dependency.install_cmd

Change performed in the redhat's fetch_and_install_deps.py

Fix was multi-fold, but all under redhat's fetch_and_install_deps.py:

runCommand() was changed to use subprocess.check_output
runCommand()'s call for rpm -i  now has a status check
a last verification against rpm -qa is performed

Made a Dependency._install_req to be cond. exec. by parent

This is always executed by F5Dependency
This is added to the ubuntu's fetch_and_install_deps.py

Again multi-fold in the ubuntu's fetch_and_install_deps.py:

runCommand() was changed to use subprocess.check_output
runCommand()'s call for dpkg -i  now has a status check
a last verification against dpkg -l is performed

Tests:
This is a test in and of itself; however, there is now an additional
ring of tests for both ubuntu and debian that assures, using its
individual packaging medium, a means to verify that the package is, in
fact, installed after the processing of the test scripts on the
associated docker container instance.

No bump of init.py in here?

@pjbreaux not yet.

@caphrim007 @pjbreaux can we get this approved and merged please?

lgtm

Bump the version, and we'll merge.


printing does not work on Windows Server 2008r2

Version 121.0.6167.81 (Offizieller Build) (64-Bit)
a. Printing does not create any output to printers.
b. Selecting more pages per page will result in a crash message "RESULT_CODE_KILLED_BAD_MESSAGE"
c. printing PDF files works as expected.

I'm looking into this issue, but I haven't been able to resolve it. For now, print web pages to PDF and print the resulting PDFs.

I just switched the renderer from DirectWrite to FreeType and it fixed all the problems. It will probably fix it on XP too.
Supermium hotfix comes later today.

Hotfix tested, so far printing is working like expected.
Thank you for your quick support.


[MRG] ENH: bypass LinearOperator in lobpcg for small-size cases

bypass LinearOperator if (n - sizeY) < (5 * sizeX) in lobpcg
Reference issue
Closes #10983
What does this implement/fix?
Even if the original input matrices were given as arrays, each of them is first turned into a LinearOperator. When lobpcg is requested to compute > 20% of eigenvalues, it simply switches to eigh, but before that needs to recover the arrays back, which is a dramatic waste.
Unless original input matrices were given as LinearOperator, avoid the conversion when computing > 20% of eigenvalues and call eigh directly on the original arrays.
Additional information
No additional unit tests required.

LGTM, could someone please review/merge?

I'm not familiar with this function, but my general comments are

I think it would be better to add a benchmark to show the performance improvements. Ref
In my understanding, this PR can improve the performance in the special situation ((n - sizeY) < (5 * sizeX)). So I think it would be better to add unit tests to check there is no backward breaking in the specific situation.

@AtsushiSakai thanks for your review! Please see my replies below:

I'm not familiar with this function, but my general comments are

I think it would be better to add a benchmark to show the performance improvements. Ref

The performance improvements are self-evident, since the PR simply eliminates unnecessary computations, so hopefully the benchmark is not necessary in this rather trivial PR.

In my understanding, this PR can improve the performance in the special situation ((n - sizeY) < (5 * sizeX)). So I think it would be better to add unit tests to check there is no backward breaking in the specific situation.

There were already unit tests for the case  of interest (n - sizeY) < (5 * sizeX) that remained intact, just better formatted in this PR, and I also already added some more, so there is surely no backward breaking. Additionally, there are multiple tests for this case in svds calls, which this PR has not touched, all passed.

@tylerjereddy @AtsushiSakai
OK, I have added tests for  A, B, and M in the form of dense array, sparse matrix, and LinearOperator both for the special situation ((n - sizeY) < (5 * sizeX)) and not.
The failed tests come from stats, i.e. unrelated to this PR.

@tylerjereddy @AtsushiSakai
Could someone please review/merge? LGTM and the changes are simple.

@tylerjereddy @AtsushiSakai
Could someone please review/merge? LGTM, the changes are simple, and all relevant tests pass.

Could someone please review/merge? LGTM, the changes are simple, and all relevant tests pass.

@rc  Maybe you can have a look? I guess that may be your part of the code that is edited in this PR.

@lobpcg Besides the two little suggestions above, LGTM.

@tylerjereddy @AtsushiSakai
Could someone please review/merge? LGTM: the changes are simple, one review finished, and all relevant tests pass.

The circleci failure fatal: couldn't find remote ref master is probably because the branch hasn't been rebased since the default branch of the project switched to main.
If rebasing isn't too much of a pain that might be helpful, since there are some docstring changes.

The circleci failure fatal: couldn't find remote ref master is probably because the branch hasn't been rebased since the default branch of the project switched to main.
If rebasing isn't too much of a pain that might be helpful, since there are some docstring changes.

Could you please help? I do not know how to do it.

In terminal, this should work:
$ git fetch upstream  # assuming the main scipy repo is called upstream
$ git rebase upstream/main
Doing this locally, the result looks like this :  https://github.com/ev-br/scipy/pull/new/pr/15280

@tylerjereddy Transferred to #15424 to fix the issue with the default branch of the project switched to main.
@ev-br Thanks for your help! I'll try it later - my local copy is in poor shape. In the mean time, it's easier for me just open a new clean PR #15424 since only 2 files are edited.


multiple hive query in hive editor page

Hi~
I have a question about hive query
From the image, I have three hive queries in hive editor
But when I execute it, it only run first query (create table). the last two query do not execute.

So I want to ask the situation is normal or abnormal ?
If in the hive query editor, only execute one hive query at the same time?
My hue version is 3.9. Thanks.

It looks like a bug there. Could you copy paste the query here so that I can quick try on the latest Hue?

Good in 3.10

Hi, this seems to happen also on version 4.0, cannot test whether was fixed in 4.1 though.

The same issue persist in Hue4.3. I can't run multiple queries.


@opentelemetry/resources use fs/promise，but it's from node version 14.

What happened?
Steps to Reproduce
Expected Result
Actual Result
Additional Details
this version use fs/promise, from node doc: https://nodejs.org/dist/latest-v18.x/docs/api/fs.html#promises-api, it's from node version 14. so many node app below 14 are effect.
https://github.com/open-telemetry/opentelemetry-js/blob/main/packages/opentelemetry-resources/src/platform/node/machine-id/getMachineId-linux.ts
OpenTelemetry Setup Code
No response
package.json
No response
Relevant log output
No response

This broke some builds for us. I understand that it is on it's way out, but since this project doesn't use the engines field (not saying it should) then this change was breaking and should have been art of a major version bump (feat!: for the conventional commit). Another way would be to enforce that commits like this are always considered breaking changes to land in the next major.

We do have the engines field in that package: https://github.com/open-telemetry/opentelemetry-js/blob/main/packages/opentelemetry-resources/package.json#L44
WRT the commit you referenced, we realize that was a breaking change. In the future, we will not drop support for runtimes without a major version bump. We may be able to fix this particular issue for node 12, but it is not a supported version so there is no guarantee and it is not tested.

Removing the bug label since this is not for a supported runtime version

We do have the engines field in that package

Sorry I didn't actually check that, I made an assumption based on the internal bug report I got. My bad, sorry. I wonder how our user got into this state without noticing all those warnings then. I think they were already in the process of updating the old project, so maybe nothing to follow up there.

WRT the commit you referenced, we realize that was a breaking change. In the future, we will not drop support for runtimes without a major version bump

👍  And totally understand if you don't fix. I just wanted to make sure folks were on the same page on dropping node version support being breaking.


[Bug]: Grey text on timer

What happened?

this bug is very annoying
Platform
Steam

The grey "Finish" means that the tracker has detected you've been eliminated.

In "Normal" Shows, it can rarely happen when the server wrong decided to end the show earlier but you are still playing. (Not a bug with the tracker)
In Explore Show, it happens randomly yes, but I didn't investigated yet the reason why...


Adding list of public events

Adding a list of the public events, both non-preventable and preventable, to the Options documentation page. I found that the only way I could get this information was in the source code, and thought it would be helpful to have in the documenation.

I definitely agree.
Unfortunately we are in the process of redoing that page of the documentation (see https://github.com/select2/select2/pull/3724), so I can't merge this pull request. Feel free to create a new pull request to docs-faq though.

Thanks. Sorry about. I've made pull request #3734 to docs-faq.


Plugin differences/benefits

After browsing this & other app updater type plugins it's not really clear to me what the differences/benefits of this plugin compared to these 2 are:
https://github.com/phonegap/phonegap-plugin-contentsync
https://github.com/markmarijnissen/cordova-app-loader
It seems like this one is a bit more complicated - but maybe that's actually just better documentation & perhaps more features. Would someone mind sharing their insight here?

Sorry for the late answer.
You might find some useful info in this thread.
I'm not gonna do the detailed comparison, only in short, since I don't have experience in using these two plugins.
Anyway, both solutions are a good ones. Although all three plugins allows you do to the same thing (update the app content) - they are doing this in slightly different ways. Which one is best for you - it is for you to decide.
cordova-app-loader is a pure JS plugin, that uses manifest file to detect, what files to download from the server and use. This approach is good, because it allows you to download only updated files instead of loading the whole project. JS API is quite simple, which is also good and easy to use. Plus, pure JS approach has one main benefit for plugin developer and his users: developer can implement some feature for several platforms at once (with some tweaks, of course, but still). But since this is a JS plugin - all code is run in the webview, which (for me) can be potentially dangerous. If it runs on the native side - there's just less chances of breaking, plus better control of the device's platform and less dependencies on the Cordova itself.
phonegap-plugin-contentsync is a native plugin with good JS API, which allows you to launch the update process and listen for different events during it. Since the actual work is done on the native side - this should be more reliable, then pure JS approach. Although, it is hard to maintain native code for several platforms and takes more time to add new features. If I understood correctly, this plugin is loading zip archive with your project and installs it in the custom www folder. There are different mechanics for that, which is good: you can either change the whole project, or let plugin to somehow merge them. But it requires a bit more work from the app developer's side to implement the update flow, which can be tricky. Another problem, is that plugin will download zip archive every time without checking if there is really anything new on the server. Archive approach has another potential problem: if user missed several updates - archive on the server might not be correct for him, or he will have to download several of them step-by-step, reloading page several times. So this can also become a bit tricky.
cordova-hot-code-push-plugin is a pure native plugin with JS API that you can use to download/install updates. He is some sort of the mix of these two plugins. Yes, it is a bit more complex, since has more configs. But when you wrap your head around them - it should be quite simple. chcp.json is an entry point for the plugin. In there you define url to you web project on the server, web content version and minimum required native version to run it. The last one is, actually, a nice feature, since it allows you to protect users from installing web content, that native side yet doesn't support. chcp.manifest is a file, where you define paths to your web project files and their hashes (versions). When plugin launches - it first loads chcp.json and checks, if new update is available and if it can be installed in the current version of the application. If so - it the loads chcp.manifest to detect, which files has changed since the last update. This way, even if user skipped several updates - plugin will know, what needs to be changed in the app and download only changed/updates files. Then it will put all project files in the separate folder and load index.html from it. Also, it will store the previous version as a backup just in case.
CHCP plugin also has a CLI client utility, which you can use to generate configuration files or to run local server. And a cordova-hot-code-push-local-dev-addon plugin will help you to do the local development with this plugin: it will capture changes, that you do in the www folder and upload them on the testing devices/emulators, so you could see the changes immediately.
You can read in more details on how plugin works in the documentation. I tried to document it well enough, so it would be easier for others to use and understand the workflow. But the main idea was to let the plugin to do all the hard lifting and minify the JS code, that developer need to write to perform the update. You can even skip it fully, if you want.
But anyway, I would say - just try them out and choose, what is better suits your needs :) That's a beauty of open source: there's a lot of different solutions to choose from and you can always adjust it to your needs, if required.

Ah very awesome, just what I needed. Thank you so much @nikDemyankov This eliminates one of them from my list & then as you say, I will just try the other 2 out.
My 2 cents is that it's worth having something like this available in the readme since the current landscape of updater type plugins is confusing to those of us with limited time to try them all out. Perhaps also separating the documentation into multiple pages so that only the basics, including getting something running fast is up front, then the details can be linked to in separate pages. ie something similar to https://github.com/j3k0/cordova-plugin-purchase - not to say that it is the perfect example, but that's the one on top of my head :)
Not trying to be bossy or anything here, just brainstorming ways to make the project clearest to newcomers, including those that just want to find the right solution for their needs asap since not all of us have the time/resources to give all the solutions a test drive. On the documentation details, it looks like you've done an awesome job, but my initial reaction was something like "oh man I have to learn all this stuff  before I can use it...ugh...", so to your point that much of this could even be skipped, I'm thinking it would be helpful to just put it in a separate page so that less energetic people like me aren't scared off on first sight unnecessarily. It's clear you're investing a lot of good energy into this project & it looks super robust, so it would be great to see something like this rise to the top of the pile - which I think a little marketing (even just something along the lines of clarifying the project's differentiation/benefits & getting started fast) would go a long way towards.
Again only my best here on everything, trying to give hopefully useful feedback since the project looks great & I really sincerely appreciate the time you took for this nicely detailed response. Thanks man & good luck!

@blahtao thanks for suggestions. I agree, that having all docs on one page can be a bit too much for newcomers. I should break it into separate wiki pages.


Check against the use of undefined

r? @jesse-michael-han

also writing some tests

Thanks @jesse-michael-han !

Ok will wait on your go to merge 👍

tests pass, feel free to merge


GetAndUnpack test is broken due to sourceforge.net unavailability

Test tries to download zip file
http://downloads.sourceforge.net/ant-contrib/ant-contrib-1.0b2-bin.zip
but sourceforge.net is not available now.
IMHO, we should not rely on such resources but provide them locally instead.
For example, start some small local web server during the build, which could provide several test files

not the case anymore as we migrated all tests to mocks


mzlib update to 504 which removes zero intensity peaks

zero intensity peaks cause calibration task to crash.
I believe newer, fast mass spectrometers are producing files with extraneous zero intensity peaks
Zach fixed calibration in the prior commit to deal with zeros.
I updated mzlib so that when a file is read in any file format (raw, mgf, mzml) either statically or dynamically, zero intensity peaks are eliminated.
With this change, the unit test that zach created to test for how calibration handled zeros became obsolete. So, I eliminated the test. BUT, I retained his code fix, which should just remain as an active buffer. I don't believe that line of code can easily be tested w/o making a public function out of it.

I was able to calibrate an mzML with with known zero peaks without incident

It's also well tested in mzLib, now. Looks good!


Smart auth

Description
Implement claim/proof aggregation according to the smart auth protocol.
Justification
This will allow for transactions to be signed and submitted as the currently logged in user, instead of all transactions being sent as "alice"

Completed for all auth services except auth-delegate


Use ansible verifier instead of testinfra

This verifier is the default in molecule as of 3.0, and allows us to remove the Python tests and their associated linters.

@ablbot rebase


Fix #2202 - Shift bindView of SessionListAdapter to its view holder.

Fixes #2202
Changes: Move code of bindView from adapter to view holder.

@iamareebjamal This part of the code is repeated in the view models. Where should I put this code?

Views

@iamareebjamal Please review :)

@mayank8318 Please resolve conflicts

@iamareebjamal Resolved!

@iamareebjamal Please review :)


ResolveConfigSize doesn't resolve size for Surfaces without a size

Hey Hein,
As per commit aa4649e494d9fa6238f4ae2f9d22d322f5079d1e, _resolveConfigSize(renderNode) returns configSize.size = null for Surfaces without an explicitly defined size. This results in an Cannot read property '0' of null as configSize.size is not defined.
For instance, breaking the current NavBarLayout example code:
dataSource: {
    background: new Surface({properties: {backgroundColor: 'black'}}),
    title: new Surface({content: 'My title'}),
   ...

For anyone encountering the same issue, just a small workaround:
dataSource: {
    background: new Surface({properties: {backgroundColor: 'black'}}),
    title: new Surface({content: 'My title', size:[true, true]}),
   ...

Ah, thanks for the heads up Manuel!
I'll let you know when this is fixed!

Alright, has been fixed.
Thanks!