[html][xml] HTML/XML Tags editing like Visual Studio does (in WPF editor)

I thought, while using Code, that it could implement the same thing Visual Studio does with XAML files, when changing tags name. Visual Studio, while you're editing a piece code like this way:
<TextBox></TextBox>
into
<Run></Run>
changes automatically closing tag. Code doesn't do that, for example, editing a XAML file with Code results in, without manual edit:
<TextBox></TextBox>
into
<Run></TextBox>

Dikirim dari ponsel cerdas Samsung Galaxy saya.
-------- Pesan asli --------
Dari: boxHiccup<EMAIL_ADDRESS>Tanggal:14/02/2016  02:14  (GMT+07:00)
Ke: Microsoft/vscode<EMAIL_ADDRESS>Cc:
Subjek: [vscode] HTML/XML Tags editing like Visual Studio does (in WPF
editor) (#3000)
I thought, while using Code, that it could implement the same thing Visual Studio does with XAML files, when changing tags name. Visual Studio, while you're editing a piece code like this way:  into  changes automatically closing tag. Code doesn't do that, for example, editing a XAML file with Code results in, without manual edit:  into  —Reply to this email directly or view it on GitHub.

This should apply to JSX/TSX as well.

There is an extension for this:
https://marketplace.visualstudio.com/items?itemName=formulahendry.auto-rename-tag


MM-22843 - Updating RHS size on wider screens

Summary
MM-22843 - Updating RHS size on wider screens
Ticket Link
https://mattermost.atlassian.net/browse/MM-22843

Creating a new SpinWick test server using Mattermost Cloud.

Test server creation failed. See the logs for more information.

Test server destroyed

Creating a new SpinWick test server using Mattermost Cloud.

Mattermost test server created! :tada:
Access here: https://mattermost-webapp-pr-4985.test.mattermost.cloud

Account Type
Username
Password

Admin
sysadmin
Sys@dmin123

User
user-1
User-1@123

New commit detected. SpinWick will upgrade if the updated docker image is available.

Mattermost test server updated with git commit 0b96a5e9861b480cb7ea156b5c3bf48c818e557c.
Access here: https://mattermost-webapp-pr-4985.test.mattermost.cloud

New commit detected. SpinWick will upgrade if the updated docker image is available.

New commit detected. SpinWick will upgrade if the updated docker image is available.

Test server creation failed. See the logs for more information.

Mattermost test server updated with git commit a867698659f594dbdd3002de0a941cb450ce3c8c.
Access here: https://mattermost-webapp-pr-4985.test.mattermost.cloud

Test server destroyed


Incorrect example for textfile collector

In the example for the textfile collector the following example is provided:
https://github.com/prometheus/client_python/tree/a5f0e25273b9007d2ab72480779a51378a86d83a#node-exporter-textfile-collector
from prometheus_client import CollectorRegistry, Gauge, write_to_textfile

registry = CollectorRegistry()
g = Gauge('raid_status', '1 if raid array is okay', registry=registry)
g.set(1)
write_to_textfile('/configured/textfile/path/raid.prom', registry)

However, this example will not work, because the Gauge collector won't be registered in the registry without calling
registry.register(g)

If the example is run, it will simply create an empty metrics file at the given path.

The gauge is registered here, that's what the registry parameter is for. I have tested this to confirm a bug hasn't slipped in.

The gauge is registered here, that's what the registry parameter is for. I have tested this to confirm a bug hasn't slipped in.


fix: image not rounded

Related Issue

Information about the related issue

Closes: #
Describe the changes you've made

Type of change
What sort of change have you made:

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Code style update (formatting, local variables)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?

Checklist

[ ] My code follows the guidelines of this project.
[ ] I have performed a self-review of my own code.
[ ] I have commented on my code, particularly wherever it was hard to understand.
[ ] I have made corresponding changes to the documentation.
[ ] My changes generate no new warnings.
[ ] I have added tests that prove my fix is effective or that my feature works.
[ ] Any dependent changes have been merged and published in downstream modules.

Screenshots (if applicable)

Original
Updated

original screenshot
updated screenshot

Code of Conduct

[ ] I agree to follow this project's Code of Conduct

@krishguptadev Your name card don't pop up like others. Maybe fix with another issue 👍🏼

@krishguptadev Your name card don't pop up like others. Maybe fix with another issue 👍🏼

What do you mean? 😅

@krishguptadev Your name card don't pop up like others. Maybe fix with another issue 👍🏼

What do you mean? sweat_smile

@mkubdev 's card

your card

@krishguptadev Your name card don't pop up like others. Maybe fix with another issue 👍🏼

What do you mean? sweat_smile

@mkubdev 's card

your card

This looks like a bug.


Create repository for collaboration w BMcG

Check w collaborators whether project should be private or open.
Create reference list:

https://peerj.com/articles/3208/
http://blogs.plos.org/everyone/2017/05/08/making-progress-toward-open-data/

This is now made at https://github.com/alan-turing-institute/data-availability-statements (private repo). Do need to add the links though.

Done!


Remove legacy doc-label-check action

We've switched to docbot. It should be safe to delete doc-label-check.

If we're assuming there're other projects using it, we should publish a tag and remove it in master.

Yes, the legacy docbot should be removed. I'll send a PR later.
AFAIK, only the main pulsar repo uses the docbot.

I don't suggest that you remove this code. Could we make a deprecated tag?

@nodece as I mentioned above, if we're assuming there're other projects using it, we should publish a tag and remove it in master.
For example, we push a tag v0.1.0 so that users depend on doc-label-check can write<EMAIL_ADDRESS>We don't effectively maintain it, though.


Helm chart generates invalid duplicate securityContext attribute for dapr-sidecar-injector

In what area(s)?
/area test-and-release
What version of Dapr?
latest
Expected Behavior

Helm chart should not contain duplicate attributes
Actual Behavior
Helm chart contains duplicate securityContext definitions
        securityContext:
          runAsUser: 1000
        command:
        - "/injector"
        args:
        - "--log-level"
        - info
        - "--metrics-port"
        - "9090"
        securityContext:
          runAsNonRoot: true

Thanks for reporting. Would you like to submit a PR for this?

@yaron2 Sure thing, https://github.com/dapr/dapr/pull/2785

Thanks!

Closed via #2785.
Thanks @slacksach!


Record Raspbian image on SDHC

Etcher version: 1.2.1
Operating system and architecture: Windows 10 - x64
Image flashed:

Hello, I'm having this problem in creating the Respbian image. I'm using an 8GB SanDisk SDHC. I have already formatted the card and downed the image to see if something had been corrupted. Would you know how to solve this question?

Is it possible that either your SD card or your card-reader is slightly faulty? Do you have a different card and/or a different card-reader you could try?

É possível que seu cartão SD ou o seu leitor de cartões esteja um pouco defeituoso? Você tem um cartão diferente e / ou um leitor de cartões diferente que você poderia tentar?
I did a scan in SD through H2testw and the result was this:
Warning: Only 7671 of 7672 MByte tested.
The media is likely to be defective.
3.8 GByte OK (8009408 sectors)
3.6 GByte DATA LOST (7700800 sectors)
Details:0 KByte overwritten (0 sectors)
0 KByte slightly changed (< 8 bit/sector, 0 sectors)
3.6 GByte corrupted (7700800 sectors)
0 KByte aliased memory (0 sectors)
First error at offset: 0x00000000f46d8000
Expected: 0x00000000f46d8000
Found: 0x0000000000000000
H2testw version 1.3
Writing speed: 6.12 MByte/s
Reading speed: 11.7 MByte/s
H2testw v1.4
Already the card reader, I believe that is not with problem since I am using of the laptop that is new. Unfortunately I can not immediately have another card to test or an external reader.

The media is likely to be defective. and 3.6 GByte DATA LOST (7700800 sectors) doesn't sound good.
Did you buy this card from eBay by any chance? From those H2testw results it sounds like you've bought a 4GB SD card which has been illegally reprogrammed to report its size as 8GB. If you can, try to get a refund.

But can this be affecting performance and giving this problem in the image recording?

Yes. Those test results mean that half of the SD-card you have is broken and won't store any data.

Closing this issue, as it's not an issue with Etcher, but with the storage device;
@SirFilbido feel free to keep the conversation going, I'm just closing this to avoid it getting in between bugs and such.

@SirFilbido You can read more about this at https://sosfakeflash.wordpress.com/


Updated ast.MemberExpr, equal, and added more tests

@mattn ,
Any thoughts on this?

Please note what you want to change. AFAICS, you seems to want to change nil == nil and add kindOf ?

Added toInt, updated error codes, changed so return can be used in main, added kindOf, updated member expressions and index expressions. Those are the bigger changes. The update to IsValid seemed fairly minor, not sure if it really changed much.

Note that the changes are grouped into there own commit. The addition of new tests or test changes are also in there own commit. The hope was that would make it easier to review. Please let me know if there is anything else I can do to help make the changes easier to review.

LGTM. Thank you. In next time for PR, please note what you want to change in description.


Change extra archive data to rely on uniqueness of a variable address, not a function address

Fixes #5478

This fix work as expected (static variable's address uniqueness is guaranteed). But I doubt the id will change run-to-run, will this affect loading dumped checkpoint (I'm not sure whether dumped checkpoint contains such id), or is just OK?
wrt the implementation, I see this static variable technique most used in template definition, where multiple template instantiation got unique static variables automatically. In this implementation, the template function is left unimplemented to forbid unknown data types, so why not just return a hard-coded number constant in each template instantiation (though not very elegant)?

This fix work as expected (static variable's address uniqueness is guaranteed).

Thanks for checking. I'll fix the inspect errors and merge afterwards.

But I doubt the id will change run-to-run, will this affect loading dumped checkpoint (I'm not sure whether dumped checkpoint contains such id), or is just OK?

The id is not used anywhere except for identifying the data type at runtime. So it will not affect the checkpointing data.

wrt the implementation, I see this static variable technique most used in template definition, where multiple template instantiation got unique static variables automatically. In this implementation, the template function is left unimplemented to forbid unknown data types, so why not just return a hard-coded number constant in each template instantiation (though not very elegant)?

The point of this solution is to provide an extensible solution (possibly even by the user) that guarantees uniqueness of the id's at runtime.

retest lsu

retest lsu

Rostam is still down...

retest lsu


fix: add _ to charaters allowed in modules name

Hello,
since #844 we don't have our modules listed in completion
This PR fix that

Good catch!


mock thinky connections when doing a build

I needed to add a process.exit(err? err : 0) to the end of the webpack.run cb in the bin/compile file to close the connection when the build finishes.
Do you want to merge a pr for that, or would you rather restructure the compile process to not hold open connections?

@stevelacy Actually just did that, but the build should not touch the DB since a production build will try to connect to the production DB which is obv not good


"main" key points to non-existing file

One cannot import the module, because the file referenced in the "main" key does not exist.
https://github.com/pldespaigne/content-hash/blob/39c2628a0827208733ab53563c301a605cc89fe3/package.json#L6
I assume the value should be "dist/index.js".

It should be ok now (v2.4.3) ! Can you test it ?


Fix/Improve URL segment concatenation

Currently we join URL segments by string concatenation, which is... workable but not great, especially combined with Unicode.
We should use existing libraries to do this correctly:
urlparse.urljoin
This is the urlparse library (Py2) / urllib.parse (Py3).
Bonus: this lets us supply base URLs but also merge with user-supply query params (down the road).
This is a side element of https://github.com/svanoort/pyresttest/issues/104

Completed with https://github.com/svanoort/pyresttest/commit/28992699a023c4c4b5081cc9495f9adeb96e5fc3


Feature Request: Rescale LoRA

I would like the option to rescale a LoRA prior to resizing.
Considering that you can compare the LoRA to a base model, this may also change the output size.
Thanks for the good work!

Good idea, I added it. You can now append rescale=0.5 or whatever to the recipe.

Considering that you can compare the LoRA to a base model, this may also change the output size.

It will offset the scores uniformly, but won't change which dims get selected.

but won't change which dims get selected.

Rescaling with spn resulted in a file size 1/10 the size. (as I guessed it might)
Can we get rescale in the file name so it doesn't overwrite?

Rescaling to 0.2 with spn_ckpt resulted in a file size 1/10 the size. (as I guessed it might)

Yes if you use a fixed threshold. rescale=0.2 will have the same effect than adding -log10(0.2) = 0.7 to the threshold.
eg. spn_lora=1,thr=-1.4,rescale=0.2 ~ spn_lora=1,thr=-0.7
That is until I add a parameter for raising the singular values to a power. But this will wait until we have ways to plot statistics. There is already too many parameters for flying blind.

Also. can we get rescale in the file name so it doesn't overwrite?

I added it.


Update README client libraries with disque_jockey

Hey,
Not sure if this is appropriate because disque_jockey isn't striclty a client library -- it provides a framework for writing ruby workers that fetch from Disque, akin to projects like Sidekiq or Resque.  Just thought I'd PR it in case you would like to point people to a project like that.
Cheers

Thank you @DevinRiley, people will figure out it's a library for workers after a quick check to the README, so I merged it.


allow to customize nameserver deployment

This allows to customize the nameserver deployment via the DNSConfig CRD. It allows to set the command, environment variables and pod labels.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>7
Details

18 of 40 (45.0%)  changed or added relevant lines in 2 files are covered.
90 unchanged lines in 21 files lost coverage.
Overall coverage increased (+0.02%) to 51.376%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

cmd/k8s-operator/nameserver.go
15
23
65.22%

k8s-operator/apis/v1alpha1/zz_generated.deepcopy.go
3
17
17.65%

Files with Coverage Reduction
New Missed Lines
%

k8s-operator/sessionrecording/ws/conn.go
1
84.85%

cmd/k8s-operator/nameserver.go
1
72.73%

packages/deb/deb.go
1
87.06%

types/persist/persist.go
2
88.46%

util/syspolicy/rsop/resultant_policy.go
2
94.78%

tstest/natlab/vnet/vnet.go
2
44.06%

ipn/ipnlocal/local.go
2
64.21%

k8s-operator/sessionrecording/fakes/fakes.go
2
75.61%

control/controlclient/direct.go
2
62.48%

control/controlbase/conn.go
2
84.75%

Totals

Change from base Build<PHONE_NUMBER>2:
0.02%

Covered Lines:
55978

Relevant Lines:
108957

💛  - Coveralls


[SPARK-41894][SS][TESTS] Restore the write permission of commitDir after run testAsyncWriteErrorsPermissionsIssue

What changes were proposed in this pull request?
This pr aims to restore the write permission of commitDir after run testAsyncWriteErrorsPermissionsIssue in AsyncProgressTrackingMicroBatchExecutionSuite so that mvn clean can run successfully.
Why are the changes needed?
Make mvn clean can run successfully after run mvn test with AsyncProgressTrackingMicroBatchExecutionSuite
Does this PR introduce any user-facing change?
No, just for test
How was this patch tested?

Pass Github Actions
Manual test

build/mvn clean install -pl sql/core -am -DskipTests
build/mvn clean test -pl sql/core -Dtest=none -DwildcardSuites=org.apache.spark.sql.execution.streaming.AsyncProgressTrackingMicroBatchExecutionSuite
build/mvn clean -pl sql/core

Before
build/mvn clean -pl sql/core run failed
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-clean-plugin:3.1.0:clean (default-clean) on project spark-sql_2.12: Failed to clean project: Failed to delete /${basedir}/sql/core/target/tmp/streaming.metadata-4d41fbcc-d517-4159-961c-95688dadd2c8/offsets/0 -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException

After
All three commands run successfully.

cc @HyukjinKwon @jerrypeng

cc @HeartSaVioR

friendly ping @HyukjinKwon @HeartSaVioR

Thanks! Merging to master.

Thanks @HeartSaVioR


Info prompt for replacements happened in editor

Type: Bug
I can't see the amount of replacing done. (Replace all)
VS Code version: Code 1.74.2 (e8a3071ea4344d9d48ef8a4df2c097372b0c5161, 2022-12-20T10:29:14.590Z)
OS version: Windows_NT x64 10.0.22623
Modes:
Sandboxed: No

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-8700 CPU @ 3.20GHz (12 x 3192)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: disabled_offdirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okskia_renderer: enabled_onvideo_decode: enabledvideo_encode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabledwebgpu: disabled_off

Load (avg)
undefined

Memory (System)
31.92GB (24.36GB free)

Process Argv

Screen Reader
no

VM
0%

Extensions (13)

Extension
Author (truncated)
Version

rtf
ale
2.6.1

auto-close-tag
for
0.5.14

vscode-todo-highlight
jgc
2.0.4

vscode-language-pack-es
MS-
1.74.12140936

vscode-edge-devtools
ms-
2.1.1

color-highlight
nau
2.5.0

color-manager
roy
0.7.5

vscode-st
Ser
1.12.14

ayu-green
Sir
1.0.1

code-spell-checker
str
2.12.0

code-spell-checker-spanish
str
2.1.4

ayu
tea
1.0.5

material-theme
zhu
3.15.6

(12 theme extensions excluded)

I can't see the amount of replacing done. (Replace all)

@laramjoj sorry I didn't follow this, did the replace all successfully happen?

Thanks for creating this issue! We figured it's missing some basic information or in some other way doesn't follow our issue reporting guidelines. Please take the time to review these and update the issue.
Happy Coding!

It does do the replacements, but I can't see how many replacements it does. (Google translation)

This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our documentation.
Happy Coding!

This feature request has not yet received the 20 community upvotes it takes to make to our backlog. 10 days to go. To learn more about how we handle feature requests, please see our documentation.
Happy Coding!

:slightly_frowning_face: In the last 60 days, this feature request has received less than 20 community upvotes and we closed it. Still a big Thank You to you for taking the time to create this issue! To learn more about how we handle feature requests, please see our documentation.
Happy Coding!


Adding a new recipe for applecrumble to lennarts recipes collection

Hi Lennart,
i've found an applecrumble recipe! hope that you'll enjoy it!

Thank you for this contribution @claireclaireb.
Before I can merge this PR, could you please still add the following changes:

[ ] Move the contents of applecrumble_recipe.txt to a .qmd file in the /recipes subfolder.
You can take a look at the other recipes in that folder.
[ ] It would be great, if you could adjust the structure of the content to the structure of the other recipes (for an example, see Matteo's tiramisu recipe), i.e., a short YAML header with some metadata including your author name. the ingredients section can be started with ## {{< fa basket-shopping >}} Ingredients and the "directions" be added to the ## {{< fa kitchen-set >}} Procedure section.

Hope this makes sense! Let me know if you have any questions!

Thanks for these additional changes @claireclaireb! As a final:tm: request, could you remove the files applecrumble_recipe.txt and applecrumble.qmd from the root of the directory (not the recipe applecrumble.qmd inside /recipes)? thanks!

Hi Lennart,
I really tried to solve the problem. But I think I've caused even more
chaos. Since yesterday I can no longer access your recipes folder.
I think my commit-notes are messy too. Would it be okay with you if we
go over this together on Friday?
I have now created a finished file with the recipe, but it is not in
the recipes folder but in recipes_lnnrt . There are two recipe files
in the recipes folder that are unusable. But since I can no longer
use/add the folder, I cannot delete them from it.
I'm very sorry for the choas!! Or can you see what my problem is? I'm
slowly getting lost :)
Quoting Lennart Wittkuhn @.***>:

Thanks for these additional changes @claireclaireb! As a final:tm:
request, could you remove the files applecrumble_recipe.txt and
applecrumble.qmd from the root of the directory (not the recipe
applecrumble.qmd inside /recipes)? thanks!
--
Reply to this email directly or view it on GitHub:
https://github.com/lnnrtwttkhn/recipes/pull/16#issuecomment-1914602330
You are receiving this because you were mentioned.
Message ID: @.***>

Hi @claireclaireb,
no worries! We can look at it together on Friday. From what I can see, this is what happened:

In commit https://github.com/lnnrtwttkhn/recipes/pull/16/commits/466a7a8ca5334b491a47bfab21839cfea34934b3: (1) You removed applecrumle.qmd, (2) you renamed applecrumble_recipe.txt to applecurmble_recipes.qmd (notice the typo), and (3) added a new file recipes/applecumble_recipe.qmd that looks like your original applecrumble_recipe.txt file.
In commit https://github.com/lnnrtwttkhn/recipes/pull/16/commits/a7ad78c64bd98f13b16b91296cbca8b3166a553e you added another file applecrumble_recipe.qmd to the root of the project directory.
In https://github.com/lnnrtwttkhn/recipes/pull/16/commits/50da60b19f16270975e9c36ab4917f322bafce2b you removed applecurmble_recipes.qmd (see point 1) removed applecurmble_recipes.qmd again.

All of this happened on the main branch of your forked repository.
Here's what you could try: In your forked repository (recipes_lnnrt) on the main branch (verify using git branch), do the following:

Remove recipes/applecrumble_recipe.qmd, this should be an empty file (here, /recipes is the subfolder inside recipes_lnnrt). You can do this using your file browser.
Remove recipes/applecumble_recipe.qmd (here, /recipes is the subfolder inside recipes_lnnrt). You can also do this using your file browser.
Then move (and rename) applecrumble_recipe.qmd in the root of the recipes_lnnrt folder) to recipes/applecrumble.qmd. You can also do this using your file browser or using mv applecrumble_recipe.qmd recipes/applecrumble.qmd in the command line while being in the recipes_lnnrt folder (check with pwd and move around with cd).

Feel free to try this (after all, with Git we rarely loose anything beyond recovery, unless we try hard) but also don't worry about it, if you feel lost. We can look at it together in our next seminar session!


Explain where artman smoketest logs are

Codecov Report

Merging #2258 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #2258   +/-   ##
=========================================
  Coverage     86.74%   86.74%
  Complexity     5134     5134
=========================================
  Files           452      452
  Lines         20378    20378
  Branches       2189     2189
=========================================
  Hits          17676    17676
  Misses         1928     1928
  Partials        774      774

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96180d7...8af78db. Read the comment docs.

PTAL


Lombok disables incremental compilation in gradle

There is an approach for Gradle 4.6 to allow incremental compilation when annotation processors are used: https://github.com/gradle/gradle/issues/1320
Is this approach sufficient for Lombok? Does it require a lot of work on Lombok side?
The current state prohibits the use of lombok in big gradle projects.

Lombok is a bit of a special case, as it uses internal APIs to change existing types. This is not officially allowed by the Processor API. Given how incremental annotation processing in Gradle currently works (to be released in 4.7), Lombok would work fine. But there is no guarantee that this would keep working in the future if we decide to take more control of the round environment for instance.
I guess this is the trade-off that Lombok has always taken - Rely on compiler internals in order to provide the most concise code.

@nsiniakevich  That change would also be great but is unrelated to incremental compilation. Can you please open a separate issue?

I've taken a closer look at Lombok. Its usage of Trees.instance(procEnv) would fail if used with Gradle's incremental compiler, because Gradle decorates the processing environment. Of course Lombok could add a workaround to extract the original environment if the devs are ready to take on that additional workaround.

@rzwitserloot what do you this about this workaround?

@oehme I've just wanted to open issue, but it's already here https://github.com/rzwitserloot/lombok/issues/1611 ;)

@oehme I'm gonna try to interpret this one:
Okay, so, Lombok should call Trees.instance(procEnv) as normal, but, before proceeding, call .getClass().toString() to check if it so happens to be gradle's wrapper around the Trees class. If it is, we use reflection to fetch the javac Trees impl, and we carry on with whatever we were doing, using that reflection-obtained original environment.
Is that all it's gonna take? Because – that sounds rather simple to do. Can you point me at the wrapper code, or, better yet, tell me the fully qualified name of the wrapper + the method/field we can use to extract the original environment?

@rzwitserloot You'll also need to register Lombok in one of Gradle's incremental categories. I did take a look at the annotations and it seems like they all look at each annotated element in isolation, making Lombok an isolating processor (the most efficient category). Also as far as I can see you never generated code, but always mutate the original AST. Is that correct?
The delegating wrapper is here. If you decide to go forward with this, we can add a smoke test to Gradle to ensure we don't break you without advance notice.

Since Gradle team says Lombok should be changed to properly separate it’s annotations from its processors to avoid this annoyance for users. but https://github.com/rzwitserloot/lombok/issues/1611 won't be fixed, is  supporting Incremental annotation processing still possible for Lombok?

@eximius313 as mentioned above already, this is unrelated to incremental compilation.

@oehme or anyone else familiar with this new Gradle feature: In order to take advantage of this, do we need to do anything special? For example, is doing compile <lombok:1.16.22> sufficient for incremental annotation processing now?

It's Gradle 4.7+ and you'll need a lombok version that includes the change. Not sure if that already was released @rzwitserloot?

Lombok 1.16.22 [1] says: PLATFORM: lombok now counts as an incremental annotation processor for gradle. and the jar contains the correspondent META-INF/gradle/incremental.annotation.processors file.
[1] https://projectlombok.org/changelog

Awesome, thanks!

@oehme Got it! Just to confirm with more clarity from my end:
In order for incremental compilation with Lombok to be used, all that is needed is:

lombok 1.16.22+
Gradle 4.7+

No other special configuration needed. Properties such as annotationProcessorPath are recommended for optimality.
Is this correct?

Well, you also need to enable incremental compilation if you haven't already.

I had not. Looks like that's what I was missing. Thanks!

@oehme I now see the following error. It goes away if I remove the incremental compilation option:
warning: Can't get the delegate of the gradle IncrementalProcessingEnvironment. Lombok won't work.
/Users/jrlin/Projects/talent-pemberly-api/api-it-test-fwk/src/main/java/api/it/test/internal/Test.java:7: warning: lombok.javac.apt.LombokProcessor could not be initialized. Lombok will not run during this compilation: java.lang.ClassCastException: org.gradle.api.internal.tasks.compile.processing.IncrementalProcessingEnvironment cannot be cast to com.sun.tools.javac.processing.JavacProcessingEnvironment
public class TestUserAuth {
       ^
        at lombok.javac.apt.LombokProcessor.getJavacProcessingEnvironment(LombokProcessor.java:426)
        at lombok.javac.apt.LombokProcessor.init(LombokProcessor.java:89)
        at lombok.core.AnnotationProcessor$JavacDescriptor.want(AnnotationProcessor.java:112)
        at lombok.core.AnnotationProcessor.init(AnnotationProcessor.java:165)
        at lombok.launch.AnnotationProcessorHider$AnnotationProcessor.init(AnnotationProcessor.java:73)
        at org.gradle.api.internal.tasks.compile.processing.DelegatingProcessor.init(DelegatingProcessor.java:57)
        at org.gradle.api.internal.tasks.compile.processing.IsolatingProcessor.init(IsolatingProcessor.java:41)
        at com.sun.tools.javac.processing.JavacProcessingEnvironment$ProcessorState.<init>(JavacProcessingEnvironment.java:500)
        at com.sun.tools.javac.processing.JavacProcessingEnvironment$DiscoveredProcessors$ProcessorStateIterator.next(JavacProcessingEnvironment.java:597)
        at com.sun.tools.javac.processing.JavacProcessingEnvironment.discoverAndRunProcs(JavacProcessingEnvironment.java:690)
        at com.sun.tools.javac.processing.JavacProcessingEnvironment.access$1800(JavacProcessingEnvironment.java:91)
        at com.sun.tools.javac.processing.JavacProcessingEnvironment$Round.run(JavacProcessingEnvironment.java:1035)
        at com.sun.tools.javac.processing.JavacProcessingEnvironment.doProcessing(JavacProcessingEnvironment.java:1176)
        at com.sun.tools.javac.main.JavaCompiler.processAnnotations(JavaCompiler.java:1170)
        at com.sun.tools.javac.main.JavaCompiler.compile(JavaCompiler.java:856)
        at com.sun.tools.javac.main.Main.compile(Main.java:523)
        at com.sun.tools.javac.api.JavacTaskImpl.doCall(JavacTaskImpl.java:129)
        at com.sun.tools.javac.api.JavacTaskImpl.call(JavacTaskImpl.java:138)
        at org.gradle.api.internal.tasks.compile.IncrementalAnnotationProcessingCompileTask.call(IncrementalAnnotationProcessingCompileTask.java:76)
        at org.gradle.api.internal.tasks.compile.JdkJavaCompiler.execute(JdkJavaCompiler.java:50)
        at org.gradle.api.internal.tasks.compile.JdkJavaCompiler.execute(JdkJavaCompiler.java:36)
        at org.gradle.api.internal.tasks.compile.daemon.AbstractDaemonCompiler$CompilerCallable.call(AbstractDaemonCompiler.java:88)
        at org.gradle.api.internal.tasks.compile.daemon.AbstractDaemonCompiler$CompilerCallable.call(AbstractDaemonCompiler.java:76)
        at org.gradle.workers.internal.DefaultWorkerServer.execute(DefaultWorkerServer.java:42)
        at org.gradle.workers.internal.WorkerDaemonServer.execute(WorkerDaemonServer.java:46)
        at org.gradle.workers.internal.WorkerDaemonServer.execute(WorkerDaemonServer.java:30)
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.lang.reflect.Method.invoke(Method.java:498)
        at org.gradle.process.internal.worker.request.WorkerAction.run(WorkerAction.java:101)
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.lang.reflect.Method.invoke(Method.java:498)
        at org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
        at org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
        at org.gradle.internal.remote.internal.hub.MessageHubBackedObjectConnection$DispatchWrapper.dispatch(MessageHubBackedObjectConnection.java:155)
        at org.gradle.internal.remote.internal.hub.MessageHubBackedObjectConnection$DispatchWrapper.dispatch(MessageHubBackedObjectConnection.java:137)
        at org.gradle.internal.remote.internal.hub.MessageHub$Handler.run(MessageHub.java:404)
        at org.gradle.internal.concurrent.ExecutorPolicy$CatchAndRecordFailures.onExecute(ExecutorPolicy.java:63)
        at org.gradle.internal.concurrent.ManagedExecutorImpl$1.run(ManagedExecutorImpl.java:46)
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
        at org.gradle.internal.concurrent.ThreadFactoryImpl$ManagedThreadRunnable.run(ThreadFactoryImpl.java:55)
        at java.lang.Thread.run(Thread.java:745)

@pbi-qfs can you take a look at this? The field name didn't change so I don't know why this would fail.

@oehme  thanks for the pointer, I didn't account for a delegate having a delegate having ...
I fixed this in https://github.com/pbi-qfs/lombok/tree/fixGradle5Incremental
@linjer can you try this quick build: lombok.jar.zip ?

@pbi-qfs I just tried the jar you provided above and I get the same result. To make more clear how I set up the module that is failing, here's part of the build.gradle:
repositories {
  flatDir {
    dirs 'lib' // jar was unzipped into <module>/lib/lombok.jar
  }
}

dependencies {
  apt name: 'lombok'
  compileOnly name: 'lombok'
  // ...
}

// See https://blog.gradle.org/incremental-compiler-avoidance
compileJava {
  options.annotationProcessorPath = configurations.apt
}

what if you try annotationProcessor instead of apt plugin (https://github.com/rzwitserloot/lombok/issues/1602#issuecomment-389179459) ?

Are you using apt plugin?

@linjer There should be a stacktrace output on stderr before the "warning: Can't get the delegate of the gradle IncrementalProcessingEnvironment. Lombok won't work." message (maybe you have to run gradle with -i or -d to see it), pointing to an error in some line between 416 and 419. Can you paste this as well?

@eximius313 You are correct I was using the apt plugin. In order to help isolate the issue, I've made a run without the plugin and only declaring compile 'org.projectlombok:lombok:1.16.22'.
I get a similar error still:
java.lang.ClassCastException: com.sun.tools.javac.processing.JavacProcessingEnvironment cannot be cast to com.sun.tools.javac.processing.JavacProcessingEnvironment
        at lombok.javac.apt.LombokProcessor.getJavacProcessingEnvironment(LombokProcessor.java:419)
        at lombok.javac.apt.LombokProcessor.init(LombokProcessor.java:89)
        at lombok.core.AnnotationProcessor$JavacDescriptor.want(AnnotationProcessor.java:112)
        at lombok.core.AnnotationProcessor.init(AnnotationProcessor.java:165)
        at lombok.launch.AnnotationProcessorHider$AnnotationProcessor.init(AnnotationProcessor.java:73)
        at org.gradle.api.internal.tasks.compile.processing.DelegatingProcessor.init(DelegatingProcessor.java:57)
        at org.gradle.api.internal.tasks.compile.processing.IsolatingProcessor.init(IsolatingProcessor.java:41)
        at com.sun.tools.javac.processing.JavacProcessingEnvironment$ProcessorState.<init>(JavacProcessingEnvironment.java:500)
        at com.sun.tools.javac.processing.JavacProcessingEnvironment$DiscoveredProcessors$ProcessorStateIterator.next(JavacProcessingEnvironment.java:597)
        at com.sun.tools.javac.processing.JavacProcessingEnvironment.discoverAndRunProcs(JavacProcessingEnvironment.java:690)
        at com.sun.tools.javac.processing.JavacProcessingEnvironment.access$1800(JavacProcessingEnvironment.java:91)
        at com.sun.tools.javac.processing.JavacProcessingEnvironment$Round.run(JavacProcessingEnvironment.java:1035)
        at com.sun.tools.javac.processing.JavacProcessingEnvironment.doProcessing(JavacProcessingEnvironment.java:1176)
        at com.sun.tools.javac.main.JavaCompiler.processAnnotations(JavaCompiler.java:1170)
        at com.sun.tools.javac.main.JavaCompiler.compile(JavaCompiler.java:856)
        at com.sun.tools.javac.main.Main.compile(Main.java:523)
        at com.sun.tools.javac.api.JavacTaskImpl.doCall(JavacTaskImpl.java:129)
        at com.sun.tools.javac.api.JavacTaskImpl.call(JavacTaskImpl.java:138)
        at org.gradle.api.internal.tasks.compile.IncrementalAnnotationProcessingCompileTask.call(IncrementalAnnotationProcessingCompileTask.java:76)
        at org.gradle.api.internal.tasks.compile.JdkJavaCompiler.execute(JdkJavaCompiler.java:50)
        at org.gradle.api.internal.tasks.compile.JdkJavaCompiler.execute(JdkJavaCompiler.java:36)
        at org.gradle.api.internal.tasks.compile.daemon.AbstractDaemonCompiler$CompilerCallable.call(AbstractDaemonCompiler.java:88)
        at org.gradle.api.internal.tasks.compile.daemon.AbstractDaemonCompiler$CompilerCallable.call(AbstractDaemonCompiler.java:76)
        at org.gradle.workers.internal.DefaultWorkerServer.execute(DefaultWorkerServer.java:42)
        at org.gradle.workers.internal.WorkerDaemonServer.execute(WorkerDaemonServer.java:46)
        at org.gradle.workers.internal.WorkerDaemonServer.execute(WorkerDaemonServer.java:30)
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.lang.reflect.Method.invoke(Method.java:498)
        at org.gradle.process.internal.worker.request.WorkerAction.run(WorkerAction.java:101)
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.lang.reflect.Method.invoke(Method.java:498)
        at org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
        at org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
        at org.gradle.internal.remote.internal.hub.MessageHubBackedObjectConnection$DispatchWrapper.dispatch(MessageHubBackedObjectConnection.java:155)
        at org.gradle.internal.remote.internal.hub.MessageHubBackedObjectConnection$DispatchWrapper.dispatch(MessageHubBackedObjectConnection.java:137)
        at org.gradle.internal.remote.internal.hub.MessageHub$Handler.run(MessageHub.java:404)
        at org.gradle.internal.concurrent.ExecutorPolicy$CatchAndRecordFailures.onExecute(ExecutorPolicy.java:63)
        at org.gradle.internal.concurrent.ManagedExecutorImpl$1.run(ManagedExecutorImpl.java:46)
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
        at org.gradle.internal.concurrent.ThreadFactoryImpl$ManagedThreadRunnable.run(ThreadFactoryImpl.java:55)
        at java.lang.Thread.run(Thread.java:745)
warning: Can't get the delegate of the gradle IncrementalProcessingEnvironment. Lombok won't work.
/Users/jrlin/Projects/talent-pemberly-api/api-server/src/main/java/com/linkedin/talent/factories/api/server/internal/clients/hireidentity/HireIdentitiesClientFactory.java:16: warning: lombok.javac.apt.LombokProcessor could not be initialized. Lombok will not run during this compilation: java.lang.ClassCastException: org.gradle.api.internal.tasks.compile.processing.IncrementalProcessingEnvironment cannot be cast to com.sun.tools.javac.processing.JavacProcessingEnvironment
public class HireIdentitiesClientFactory extends SimpleSingletonFactory<HireIdentitiesClient> {
       ^
        at lombok.javac.apt.LombokProcessor.getJavacProcessingEnvironment(LombokProcessor.java:426)
        at lombok.javac.apt.LombokProcessor.init(LombokProcessor.java:89)
        at lombok.core.AnnotationProcessor$JavacDescriptor.want(AnnotationProcessor.java:112)
        at lombok.core.AnnotationProcessor.init(AnnotationProcessor.java:165)
        at lombok.launch.AnnotationProcessorHider$AnnotationProcessor.init(AnnotationProcessor.java:73)
        at org.gradle.api.internal.tasks.compile.processing.DelegatingProcessor.init(DelegatingProcessor.java:57)
        at org.gradle.api.internal.tasks.compile.processing.IsolatingProcessor.init(IsolatingProcessor.java:41)
        at com.sun.tools.javac.processing.JavacProcessingEnvironment$ProcessorState.<init>(JavacProcessingEnvironment.java:500)
        at com.sun.tools.javac.processing.JavacProcessingEnvironment$DiscoveredProcessors$ProcessorStateIterator.next(JavacProcessingEnvironment.java:597)
        at com.sun.tools.javac.processing.JavacProcessingEnvironment.discoverAndRunProcs(JavacProcessingEnvironment.java:690)
        at com.sun.tools.javac.processing.JavacProcessingEnvironment.access$1800(JavacProcessingEnvironment.java:91)
        at com.sun.tools.javac.processing.JavacProcessingEnvironment$Round.run(JavacProcessingEnvironment.java:1035)
        at com.sun.tools.javac.processing.JavacProcessingEnvironment.doProcessing(JavacProcessingEnvironment.java:1176)
        at com.sun.tools.javac.main.JavaCompiler.processAnnotations(JavaCompiler.java:1170)
        at com.sun.tools.javac.main.JavaCompiler.compile(JavaCompiler.java:856)
        at com.sun.tools.javac.main.Main.compile(Main.java:523)
        at com.sun.tools.javac.api.JavacTaskImpl.doCall(JavacTaskImpl.java:129)
        at com.sun.tools.javac.api.JavacTaskImpl.call(JavacTaskImpl.java:138)
        at org.gradle.api.internal.tasks.compile.IncrementalAnnotationProcessingCompileTask.call(IncrementalAnnotationProcessingCompileTask.java:76)
        at org.gradle.api.internal.tasks.compile.JdkJavaCompiler.execute(JdkJavaCompiler.java:50)
        at org.gradle.api.internal.tasks.compile.JdkJavaCompiler.execute(JdkJavaCompiler.java:36)
        at org.gradle.api.internal.tasks.compile.daemon.AbstractDaemonCompiler$CompilerCallable.call(AbstractDaemonCompiler.java:88)
        at org.gradle.api.internal.tasks.compile.daemon.AbstractDaemonCompiler$CompilerCallable.call(AbstractDaemonCompiler.java:76)
        at org.gradle.workers.internal.DefaultWorkerServer.execute(DefaultWorkerServer.java:42)
        at org.gradle.workers.internal.WorkerDaemonServer.execute(WorkerDaemonServer.java:46)
        at org.gradle.workers.internal.WorkerDaemonServer.execute(WorkerDaemonServer.java:30)
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.lang.reflect.Method.invoke(Method.java:498)
        at org.gradle.process.internal.worker.request.WorkerAction.run(WorkerAction.java:101)
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.lang.reflect.Method.invoke(Method.java:498)
        at org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
        at org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
        at org.gradle.internal.remote.internal.hub.MessageHubBackedObjectConnection$DispatchWrapper.dispatch(MessageHubBackedObjectConnection.java:155)
        at org.gradle.internal.remote.internal.hub.MessageHubBackedObjectConnection$DispatchWrapper.dispatch(MessageHubBackedObjectConnection.java:137)
        at org.gradle.internal.remote.internal.hub.MessageHub$Handler.run(MessageHub.java:404)
        at org.gradle.internal.concurrent.ExecutorPolicy$CatchAndRecordFailures.onExecute(ExecutorPolicy.java:63)
        at org.gradle.internal.concurrent.ManagedExecutorImpl$1.run(ManagedExecutorImpl.java:46)
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
        at org.gradle.internal.concurrent.ThreadFactoryImpl$ManagedThreadRunnable.run(ThreadFactoryImpl.java:55)
        at java.lang.Thread.run(Thread.java:745)

you have to have both:
dependencies {
    annotationProcessor("org.projectlombok:$lombokVersion")
    compileOnly("org.projectlombok:lombok:$lombokVersion")
}

via https://github.com/rzwitserloot/lombok/issues/1602#issuecomment-389179459

"java.lang.ClassCastException: com.sun.tools.javac.processing.JavacProcessingEnvironment cannot be cast to com.sun.tools.javac.processing.JavacProcessingEnvironment" sounds as if you have two classloaders in place, and the ProcessingEnvironment is coming from another one than the classloader of the LombokProcessor class.
In addition you're not executing against the version of my comment above, since there is no cast to JavacProcessingEnvironment anymore in line 419, but to ProcessingEnvironment (which would probably fail in the next step again due to the classloader issues)

@eximius313 I can't get annotationProcessor "org.projectlombok:1.16.22" to work. It gives me the following error:
Could not resolve all files for configuration ':annotationProcessor'.
> Could not find org.projectlombok:1.16.22:.
  Required by:
      project :

@pbi-qfs This makes sense. I am using some custom tooling/infra for my company. I'm trying to reproduce this using a vanilla gradle project and it looks like it works in that context, so this issue may be due to our usage of multiple classloaders or some related issue.

@linjer it's org.projectlombok:lombok, you forgot the latter.

@pbi-qfs Gradle doesn't wrap the environment multiple times, so I don't think the change you linked will fix this.

@oehme thanks for this info - it was just a wild guess (since the relevant stacktrace was not included in the first comment), so I'll bury that "fix".

@oehme I believe you're correct. I see a similar error with the patched jar above from @pbi-qfs . I had tried to reproduce this in a new, plain gradle project to try to help isolate the issue, but it's been difficult to reproduce.
It's not a high priority for me so I think I'll move on for now. Let me know if there's anything either of you would like me to do to help document this in the meanwhile.

@oehme Regarding the dependency spec string org.projectlombok:lombok. I intentionally omitted the latter lombok component because in all the posts (above and in the linked issue), @eximius313  specifies the following:

annotationProcessor("org.projectlombok:$lombokVersion")

To me it looks intentionally suggested to use annotationProcessor("org.projectlombok:1.16.22") but it doesn't work.

@linjer That's a typo and can't work. A Maven dependency needs group. artifact and version.
As for the error: If you can create a reproducible example that would be great. I can't think of anything that could break classloading in this way off the top of my hat.

For reference, @oehme I als tried setting the following properties:
org.gradle.parallel=true
org.gradle.daemon=true

But with the very simple usage I could not reproduce the issue.

Daemon is the default anyway and parallel has no influence on classloading. If anything, the problem would have to be some very deep hack into our compiler infrastructure. The only plugin I know that does such a thing is the errorprone plugin.

@linjer - sorry, that was copy-paste error. I corrected that

Why still get this warning using 1.18.22
> Task :app:compileErmengDebugJavaWithJavac
The following annotation processors are not incremental: jetified-compiler-3.8.5.jar (com.arialyy.aria:compiler:3.8.5).
Make sure all annotation processors are incremental to improve your build speed.


Crash in tests after patched out components

cache definition only when was defined after patching out components

Thanks @CurlyHeir !!

thx for merge, when you will update typhoon pod ?


Fix some of Bugs in CTE, include subquery cost, tabel reference

please describe bugs you fixed

simplefy the plan of cte subquery.

mutiple times refer to cte

cte filter push down

There are two general ways to CTEs processing: (1) treat CTE as a blackbox subquery; (2) inline and expand CTE as subquery. Are you supporting both?

Before:

Now:

cte tabel reference. consider:
 sql = "with cte as (select a_common2.a1 from a a_common2 where a1 = 1) select a_common.a1 from a a_common where a_common.a1 in (select a1 from cte)";

this case is refering to tpcds q95
with ws_wh as
(select ws1.ws_order_number,ws1.ws_warehouse_sk wh1,ws2.ws_warehouse_sk wh2
 from web_sales ws1,web_sales ws2
 where ws1.ws_order_number = ws2.ws_order_number
   and ws1.ws_warehouse_sk <> ws2.ws_warehouse_sk)
 select
   count(distinct ws_order_number) as "order count"
  ,sum(ws_ext_ship_cost) as "total shipping cost"
  ,sum(ws_net_profit) as "total net profit"
from
   web_sales ws1
  ,date_dim
  ,customer_address
  ,web_site
where
    d_date between date '2001-4-01' and
           (cast('2001-4-01' as date) + 60 days)
and ws1.ws_ship_date_sk = d_date_sk
and ws1.ws_ship_addr_sk = ca_address_sk
and ca_state = 'VA'
and ws1.ws_web_site_sk = web_site_sk
and web_company_name = 'pri'
and ws1.ws_order_number in (select ws_order_number
                            from ws_wh)
and ws1.ws_order_number in (select wr_order_number
                            from web_returns,ws_wh
                            where wr_order_number = ws_wh.ws_order_number)
order by count(distinct ws_order_number)
limit 100


Change the tiles so they always show metadata and are larger like Jekyll blog defaults

Similar to on the wax-facets theme:
https://minicomp.github.io/wax-facets/collection/

Tiles now show a short description. I am closing this issue.


[SPARK-32062][SQL] Reset listenerRegistered in SparkSession

What changes were proposed in this pull request?

Reset listenerRegistered when application end.
Why are the changes needed?

Within a jvm, stop and create SparkContext multi times will cause the bug.
Does this PR introduce any user-facing change?

No.
How was this patch tested?

Add UT.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/28994/
Test PASSed.

cc @cloud-fan @vinooganesh

Test build #124375 has started for PR 28899 at commit fb88f3a.

Test build #124389 has started for PR 28899 at commit a486f1f.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/29008/
Test PASSed.

Test build #124390 has started for PR 28899 at commit 708c9ff.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/29009/
Test PASSed.

Test build #124389 has finished for PR 28899 at commit a486f1f.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/124389/
Test FAILed.

Test build #124390 has finished for PR 28899 at commit 708c9ff.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Test build #124375 has finished for PR 28899 at commit fb88f3a.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/124390/
Test FAILed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/124375/
Test FAILed.

retest this please

Test build #124416 has started for PR 28899 at commit 708c9ff.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/29035/
Test PASSed.

Merged build finished. Test PASSed.

Test build #124416 has finished for PR 28899 at commit 708c9ff.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/124416/
Test PASSed.

@ulysses-you - quick question for you (mostly for my own knowledge), do people usually destroy and re-create a spark context in the lifetime of a JVM? I was actually thinking about including this, but assumed that most people would create the singleton context and then use session instances for these types of short lives operations.

@vinooganesh
Not usual, but in local mode it may happen.
e.g. in spark test case, we create and stop context multi times. If the bug exists, other test case will be affected.

thanks, merging to master!

@cloud-fan thanks for merging !
BTW do we need to a backport for 3.0.1 ?

It's not a bug that people can hit in practice, I think it's OK to leave 3.0.


Only save as SVG works in plot context menu

Originally reported https://github.com/microsoft/vscode/issues/115077
All other items do nothing:

We're going to wait for an external customer to enter this to consider addressing it. Thanks!


Fails to pick up the next ability and everything gets added to the previous one

Here is an example creature to show what I mean. It fails to notice that Shadow Breath is a new ability so everything gets added to ability above it. This appears to be related to the brackets in its name but even if i remove all the brackets, it still doesn't pick up the legendary actions.
Adult White Shadow Dragon
Huge Dragon (Chromatic), Typically Chaotic Evil
Armor Class 18 (natural armor)
Hit Points 200 (16d12 + 96)
Speed 40 ft., burrow 30 ft., fly 80 ft., swim 40 ft.
STR DEX CON INT WIS CHA
22 (+6) 10 (+0) 22 (+6) 8 (−1) 12 (+1) 12 (+1)
Saving Throws Dex +5, Con +11, Wis +6, Cha +6
Skills Perception +11, Stealth +10
Damage Immunities cold
Damage Resistances necrotic
Senses blindsight 60 ft., darkvision 120 ft., passive Perception 21
Languages Common, Draconic
Challenge 16 (15,000 XP) Proficiency Bonus +5
Ice Walk. The dragon can move across and climb icy surfaces
without needing to make an ability check. Additionally, difficult
terrain composed of ice or snow doesn’t cost it extra movement.
Legendary Resistance (3/Day). If the dragon fails a saving throw, it
can choose to succeed instead.
Living Shadow. While in dim light or darkness, the dragon has
resistance to damage that isn’t force, psychic, or radiant.
Sunlight Sensitivity. While in sunlight, the dragon has
disadvantage on attack rolls, as well as on Wisdom (Perception)
checks that rely on sight.
Actions
Multiattack. The dragon can use its Frightful Presence. It then
makes one Bite attack and two Claw attacks.
Bite. Melee Weapon Attack: +11 to hit, reach 10 ft., one target. Hit:
17 (2d10 + 6) piercing damage plus 4 (1d8) necrotic damage.
Claw. Melee Weapon Attack: +11 to hit, reach 5 ft., one target. Hit:
13 (2d6 + 6) slashing damage.
Tail. Melee Weapon Attack: +11 to hit, reach 15 ft., one target. Hit:
15 (2d8 + 6) bludgeoning damage.
Frightful Presence. Each creature of the dragon’s choice that is
within 120 feet of the dragon and aware of it must succeed on
a DC 14 Wisdom saving throw or be frightened for 1 minute. A
creature can repeat the saving throw at the end of each of its
turns, ending the effect on itself on a success. If a creature’s
saving throw is successful or the effect ends for it, the creature is
immune to the dragon’s Frightful Presence for the next 24 hours.
Shadow Breath (Recharge 5–6). The dragon exhales necrotic
energy in a 60-foot cone. Each creature in that area must make
a DC 19 Constitution saving throw, taking 54 (12d8) necrotic
damage on a failed save, or half as much damage on a successful
one. A Humanoid reduced to 0 hit points by this damage dies,
and a shadow rises from its corpse and acts immediately after
the dragon in the initiative count. The shadow is under the
dragon’s control.
Bonus Actions
Shadow Stealth (Only in Dim Light or Darkness). The dragon
takes the Hide action.
Legendary Actions
The dragon can take 3 legendary actions, choosing from the
options below. Only one legendary action option can be used at
a time and only at the end of another creature’s turn. The dragon
regains spent legendary actions at the start of its turn.
Detect. The dragon makes a Wisdom (Perception) check.
Tail Attack. The dragon makes one Tail attack.
Wing Attack (Costs 2 Actions). The dragon beats its wings. Each
creature within 10 feet of the dragon must succeed on a DC 19
Dexterity saving throw or take 13 (2d6 + 6) bludgeoning damage
and be knocked prone. The dragon can then fly up to half its
flying speed.

I was using the wrong module to import. this was my mistake

Opened in error


ChildrenWithProps<> doesn't implement iter_mut()

Problem
props.children doesn't implement iter_mut(). This makes it very difficult to iterate over the children and make a change on all of them (say, for example, set a value in the child props to false).
Steps To Reproduce
Steps to reproduce the behavior:
pub struct GroupProps {
    pub children: ChildrenWithProps<Item>,
}

impl Component for Item {
    fn update(&mut self, msg: Self::Message) -> bool {
        self.props.children.iter_mut().for_each(|child| {
            child.is_selected = false;
        });
    }
}

Expected behavior
props.children should implement iter_mut(), allowing us to iterate over the children and mutate them.
Screenshots
None
Environment:

Yew version: v0.17
Rust version: 1.51.0
Target, if relevant: wasm32-unknown-unknown.
Build tool, if relevant: -
OS, if relevant: -
Browser and version, if relevant: -

Questionnaire

[x] I'm interested in fixing this myself but don't know where to start
[ ] I would like to fix and I have a solution
[ ] I don't have time to fix this right now, but maybe later

You're probably using ChildrenWithProps::<_>::iter(); wrong. It doesn't allow mutation because you're supposed to mutate the elements, then render them to the VDom using Component::view();. See the example on the docs page
#[derive(Clone, Properties)]
struct ListProps {
    children: ChildrenWithProps<ListItem>,
}

impl Component for List {
    // ...
    fn view(&self) -> Html {
        html!{{
            for self.props.children.iter().map(|mut item| {
                item.props.value = format!("item-{}", item.props.value);
                item
            })
        }}
    }
}

I see your point of view, but what I'm trying to do is to make a RadioGroup component which hosts inner RadioButton components. Now what I want to do is to make a private on_change_listener inside the RadioButton which notifies the parent RadioGroup that a radio button has been clicked, so that it can disable the rest of the buttons in the same group. So when I detect a change event or in the create event, I'm assigning the on_change_listener to the parent to set the change listener. So this requires me to iterate over the (mutable) children as assign the listener to each of them. I'm open to suggestions on how to go about this.

I actually made something like what you want to do yesterday. Here it is
The solution was to simply not use children and use a map. I wrote my own map that statically maps enums to an array, which has insanely low overhead, but using something like a HashMap would still have less overhead, since Yew does a lot of work for your component to participate in the DOM.

So you're saying we should create a new component by mapping the existing one in the render call? Isn't that expensive?

So you're saying we should create a new component by mapping the existing one in the render call? Isn't that expensive?

I'm saying use a list of states rather than a list of components, and then render those states to the DOM.

I was thinking it'll make sense to have a RadioButton so that it can be used separately if we have to, and have it as the children of the RadioGroup to make it work together.
Also, apparently ChildrenRenderer<T> is implemented as a Vec<T> internally, so it should be pretty simple to implement iter_mut by simply calling the function on the Vec

So take a prop of a bunch of  RadioButtons and render the buttons accordingly?

I guess so. In Yew, I'd probably instead mark the indexes for each RadioButton component, something along the lines of this:
pub struct RadioGroup {
    children: ChildrenWithProps<RadioButton>,
    selected: usize,
}

impl Component for RadioGroup {
    // ...
    fn update(&mut self, msg: Msg) -> ShouldRender {
        match msg {
            // ...
            Msg::Update(selected) => {
                self.selected = selected;
            }
        }
    }

    fn view(&self) -> Html {
        html! {
            <div>{
                // now we assign an index to each radio button:
                for self.children.iter().enumerate().map(|(i, radio)| {
                    radio.props.onselect = self.link.callback(|_| Msg::Update(i));
                    radio.props.selected = self.selected == i;
                    radio
                })
            }</div>
        }
    }
}

Hi 👋
The state of things in Yew has changed since this issue was first raised. Properties are now stored in Rcs so are effectively readonly, so this is no longer as easy to implement. #1961 is the PR that introduced this change. In order to implement this solution now we'd need to introduce interior mutability for Context<Self> (bit like ComponentLink<Self> but holds Properties too and lives outside of the component state).
Let me know if you still want to request this feature or if the approach provided by @frostu8 (thank you btw ❤) solved the need for the feature.
Housekeeping:

I guess making that a feature of ChildrenWithProps::<_> is what you're asking

Agreed, I have swapped the bug label for the feature request label :)


License missing in package.json / License file missing

Repository is missing a License file / package.json is missing a license as well.
Can you add one to your project?
Would love to use this but having no license is a stop for us.
Thanks!

I like to use this package but like @eek mention, stoping us from using as no license is added.

@parimalyeole1  sorry, I just fixed one bug, its @levansuper 's package.

Thanks @mitra42
@levansuper use this https://docs.github.com/en/communities/setting-up-your-project-for-healthy-contributions/adding-a-license-to-a-repository
and publish to npm if possible.

@eek  Thanks for suggestion and sorry for the delay. the MIT license is added


Update to the latest version of the Azure.Provisioning packages

Description
Contains fixes for

AssignRole => CreateRoleAssignment
PostgreSQL flexible server naming requirements updated to no longer drop numbers

We expect 1 more update on Friday with the last changes for 9.0-rc1.
Microsoft Reviewers: Open in CodeFlow

/azp run

Tests need updating


Roles and profile picture bugs

Describe the bug

Profile picture not correctly aligned in settings (refer image 1)
When you view your own profile, the roles 'x' are too close to the roles names and also, unlike how they looked before the Discord profile's update, the roles do not have their own "card" (like the border and different background - either another color from the background of the role's container or the color of the role) (refer to image 2)
When you open a bot's profile, unlike a users profile, here the roles are completely messed up. (refer to image 3 & 4)

To Reproduce

Just enter the settings page and the icon is not correctly aligned, not need for additional steps.
Open your own profile from the menu on the right in any server.
Open a bot's profile from the menu on the right in any server.

Screenshots

Information:
Discord channel: Stable
OS: Windows
Mod: BetterDiscord
Discord language: English

I found out that the problem with the profile picture in the settings was because SoftX makes the profile information card be bigger then it was standard by Discord so the background does not align with the picture anymore. I made a quick fix that makes the account information card back as it was, until the SoftX team makes an actual fix for this.
.accountProfileCard_b69b77 {
    width: 608px;
}

Just put this into the Custom CSS Editor and it should work out just fine.

Working on a fix


Reduce test suite run time

Helps with #528. Shaves off almost 20 minutes from the test suite (22 minutes compared to 39 minutes).

Thanks, I'll hold the urge to change unrelated lines of code from now on.


fetchData not called on subroutes

  <Route path="/dashboard" component={Dashboard}/>    <---- fetch data will get called
  <Route onEnter={requireLogin}>
    <Route path="loginSuccess" component={LoginSuccess}/>
  </Route>

  <Route onEnter={requireLogin}>
    <Route path="/dashboard" component={Dashboard}/>    <---- fetch data will NOT get called
    <Route path="loginSuccess" component={LoginSuccess}/>
  </Route>

@stevoland?

Maybe I missed some patch, but in my fork its working well.

When I was having this issue it was on subroutes as well.

I'm temporarily just doing:
componentDidMount() {
if (!isLoaded(this.context.store.getState())) {
return this.context.store.dispatch(loadMyPinkStarMonkeys());
}
}

@martinwells @bdefore you can see this behavior if your components are decorated more than once, or with something other than connect from Redux. When your components are wrapped with decorators it makes it hard for the GetDataDependency to get ahold of your fetchData functions.
We need to figure out a better pattern for declaring data dependencies in components. Redux 4.0 removes the reference to the wrapped component by default, which will also break the fetchData method.

@mhodgson You're right that multiple decorators, or decorators that don't add a WrappedComponent static is the issue.
The change to Redux 4.0 doesn't make any difference though - that refers to a ref to the element, not a static property to the component.
The simplest solution is to put the fetchData on the connected component.

@stevoland I misunderstood. How would you feel about a decorator called fetch that took two arguments, a function for immediate fetch (fetchData) and a function for deferred fetch (fetchDataDeferred) and we just say it HAS to be the outermost decorator?

@mhodgson sounds like a top plan to me. @erikras?

By "immediate fetch", do you mean a "blocking fetch" that will complete before the server-side render?

yes, basically it should work the same way it does now, but be more reliable as people add additional decorators.

Is this issue still pending, @stevoland?

I like @mhodgson's offer of a fetch decorator that must be the outermost.

I'll see if I can get a PR in today.

:+1: @mhodgson


Improvements

Adding ordering to the cv items
Adding clickable links to publications
Capitalize the first letter of titles
Centering the footer text
Adding Courses to the CV
Fixing latest post template
Removing the unnecessary comments
Reverting the accessibility

thanks for this contribution! one issue with this PR is that it bundles together a few unrelated changes. some of your changes we'd be happy to accept (e.g., bug fixes), but other stylistic changes that alternate the current design (such as capitalizing titles) won't be accepted. some changes are kind of borderline, and I'm not sure whether we want them or not without looking into it closer.
my recommendation is to split this PR into multiple, and address one particular thing in each PR. this would make it much easier to review and discuss proposed changes.


Added javadoc comments where possible to better explain classes and…

… methods.

Refactored method and parameter names to make them easier to understand
Added support for JSON output of statistics to ease readabillity and processing
Added command line option for Geowave application to output stats in JSON format
Refactored code to move multiple nested declarations out of function calls to make code easier to read

Coverage decreased (-21.2%) to 30.434% when pulling fbbdee819a13941a8832ec252b96d8e0f555b14f on GEOWAVE-1007-Improve-statistics into 286d34e401dad6d1be1d2547dca3fbc195a5ccb0 on master.

Coverage decreased (-0.2%) to 51.483% when pulling c74a06f95e94ec5833a28d9ac9a955c67f10df2c on GEOWAVE-1007-Improve-statistics into 286d34e401dad6d1be1d2547dca3fbc195a5ccb0 on master.

Coverage decreased (-0.2%) to 51.483% when pulling c74a06f95e94ec5833a28d9ac9a955c67f10df2c on GEOWAVE-1007-Improve-statistics into 286d34e401dad6d1be1d2547dca3fbc195a5ccb0 on master.

Coverage decreased (-0.2%) to 51.49% when pulling c74a06f95e94ec5833a28d9ac9a955c67f10df2c on GEOWAVE-1007-Improve-statistics into 286d34e401dad6d1be1d2547dca3fbc195a5ccb0 on master.

Coverage decreased (-0.2%) to 51.49% when pulling c74a06f95e94ec5833a28d9ac9a955c67f10df2c on GEOWAVE-1007-Improve-statistics into 286d34e401dad6d1be1d2547dca3fbc195a5ccb0 on master.

Coverage decreased (-0.2%) to 51.49% when pulling c74a06f95e94ec5833a28d9ac9a955c67f10df2c on GEOWAVE-1007-Improve-statistics into 286d34e401dad6d1be1d2547dca3fbc195a5ccb0 on master.

Coverage decreased (-0.2%) to 51.49% when pulling c74a06f95e94ec5833a28d9ac9a955c67f10df2c on GEOWAVE-1007-Improve-statistics into 286d34e401dad6d1be1d2547dca3fbc195a5ccb0 on master.

Coverage decreased (-0.2%) to 51.49% when pulling c74a06f95e94ec5833a28d9ac9a955c67f10df2c on GEOWAVE-1007-Improve-statistics into 286d34e401dad6d1be1d2547dca3fbc195a5ccb0 on master.

Coverage decreased (-0.2%) to 51.49% when pulling c74a06f95e94ec5833a28d9ac9a955c67f10df2c on GEOWAVE-1007-Improve-statistics into 286d34e401dad6d1be1d2547dca3fbc195a5ccb0 on master.

Coverage decreased (-0.2%) to 51.49% when pulling c74a06f95e94ec5833a28d9ac9a955c67f10df2c on GEOWAVE-1007-Improve-statistics into 286d34e401dad6d1be1d2547dca3fbc195a5ccb0 on master.

Coverage decreased (-0.2%) to 51.486% when pulling 203dd4e465e4ae8ceafbf77171ead61447f0f966 on GEOWAVE-1007-Improve-statistics into 286d34e401dad6d1be1d2547dca3fbc195a5ccb0 on master.

Coverage decreased (-0.2%) to 51.482% when pulling ce1883c43d26f77d9411aecaa2448a6a3e184755 on GEOWAVE-1007-Improve-statistics into e74581c8cf408f99d71ac216eb0b808de3c6bfce on master.

Coverage decreased (-0.2%) to 51.482% when pulling ce1883c43d26f77d9411aecaa2448a6a3e184755 on GEOWAVE-1007-Improve-statistics into e74581c8cf408f99d71ac216eb0b808de3c6bfce on master.

Coverage decreased (-0.2%) to 51.482% when pulling ce1883c43d26f77d9411aecaa2448a6a3e184755 on GEOWAVE-1007-Improve-statistics into e74581c8cf408f99d71ac216eb0b808de3c6bfce on master.

Coverage decreased (-0.2%) to 51.482% when pulling ce1883c43d26f77d9411aecaa2448a6a3e184755 on GEOWAVE-1007-Improve-statistics into e74581c8cf408f99d71ac216eb0b808de3c6bfce on master.

Coverage decreased (-0.2%) to 51.482% when pulling ce1883c43d26f77d9411aecaa2448a6a3e184755 on GEOWAVE-1007-Improve-statistics into e74581c8cf408f99d71ac216eb0b808de3c6bfce on master.

Coverage decreased (-0.2%) to 51.482% when pulling ce1883c43d26f77d9411aecaa2448a6a3e184755 on GEOWAVE-1007-Improve-statistics into e74581c8cf408f99d71ac216eb0b808de3c6bfce on master.

Coverage decreased (-0.2%) to 51.482% when pulling ce1883c43d26f77d9411aecaa2448a6a3e184755 on GEOWAVE-1007-Improve-statistics into e74581c8cf408f99d71ac216eb0b808de3c6bfce on master.

Coverage decreased (-0.2%) to 51.482% when pulling ce1883c43d26f77d9411aecaa2448a6a3e184755 on GEOWAVE-1007-Improve-statistics into e74581c8cf408f99d71ac216eb0b808de3c6bfce on master.

Coverage decreased (-0.2%) to 51.479% when pulling 218a554d7f492e7ddf5e2e3da973a103fa052f04 on GEOWAVE-1007-Improve-statistics into e74581c8cf408f99d71ac216eb0b808de3c6bfce on master.

Coverage decreased (-0.2%) to 51.448% when pulling 70cd8788f33f94446192bc5abc992de60a70c185 on GEOWAVE-1007-Improve-statistics into e74581c8cf408f99d71ac216eb0b808de3c6bfce on master.

Coverage decreased (-0.2%) to 51.448% when pulling 70cd8788f33f94446192bc5abc992de60a70c185 on GEOWAVE-1007-Improve-statistics into e74581c8cf408f99d71ac216eb0b808de3c6bfce on master.

Coverage decreased (-0.2%) to 51.448% when pulling 70cd8788f33f94446192bc5abc992de60a70c185 on GEOWAVE-1007-Improve-statistics into e74581c8cf408f99d71ac216eb0b808de3c6bfce on master.

Coverage decreased (-0.2%) to 51.448% when pulling 70cd8788f33f94446192bc5abc992de60a70c185 on GEOWAVE-1007-Improve-statistics into e74581c8cf408f99d71ac216eb0b808de3c6bfce on master.

Coverage decreased (-0.2%) to 51.448% when pulling 70cd8788f33f94446192bc5abc992de60a70c185 on GEOWAVE-1007-Improve-statistics into e74581c8cf408f99d71ac216eb0b808de3c6bfce on master.

Coverage decreased (-0.2%) to 51.448% when pulling 70cd8788f33f94446192bc5abc992de60a70c185 on GEOWAVE-1007-Improve-statistics into e74581c8cf408f99d71ac216eb0b808de3c6bfce on master.

Coverage decreased (-0.5%) to 51.124% when pulling 9d2ae4633936343f556bf72a7c9e5fa111c07784 on GEOWAVE-1007-Improve-statistics into e74581c8cf408f99d71ac216eb0b808de3c6bfce on master.

Coverage decreased (-0.5%) to 51.124% when pulling 9d2ae4633936343f556bf72a7c9e5fa111c07784 on GEOWAVE-1007-Improve-statistics into e74581c8cf408f99d71ac216eb0b808de3c6bfce on master.

Coverage decreased (-0.5%) to 51.124% when pulling 9d2ae4633936343f556bf72a7c9e5fa111c07784 on GEOWAVE-1007-Improve-statistics into e74581c8cf408f99d71ac216eb0b808de3c6bfce on master.

rebased into PR #1015


No upper cap on typing-extensions version (fixes issue #5)

When using the ^3.10 syntax, poetry also adds an upper cap (<4.0) on the version of typing-extensions, which is problematic as explained in issue #5. Therefore this PR changes the ^3.10 to >=3.10, avoiding the problematic upper cap.

@klbostee LGTM, thanks!


[ldd-rings] Fix various copy-editing errors in the Rings dictionary

Issue Type
Enhancement
Describe the issue identified (if applicable)
Various copy-edit errors have been found in the Rings dictionary. They, along with the proposed changes, are listed individually below. These suggested changes were initially collected during the DMSP in 2022.
Describe the solution you'd like

In the definition of the attribute axis_name, there is an extra space that should be removed.
In the definition of the attributes ring_event_start_time_utc and ring_event_stop_time_utc, the phrase “XX is required label attribute for all ring occultation data” is duplicated and should only occur once.
The definition of the attribute data_quality_index says “Possible values are: ” but then does not list the possible values.
For the attributes occultation_type, light_source_incidence_angle, observed_ring_azimuth, and normal_mode_wavenumber, there should be a space before the previous attribute definition.
For the attributes ring_radius, minimum_ring_radius, maximum_ring_radius, projected_sun_diameter, minimum_projected_sun_diameter, maximum_projected_sun_diameter, and sigma_projected_sun_diameter, the definition says “units are km”. We propose removing “km” from the definitions because the schema allows any Units_of_Length.
For the attribute maximum_ring_longitude_observed_minus_subsolar, the definition should say largest instead of smallest.
For the attribute incidence_angle, the word “between” is missing in the definition in the phrase “Incidence angle is the angle the surface normal vector at the intercept…”.
In the definition of the attribute light_source_incidence_angle, there should be consistency in formatting between “north-side” and “southside”.
In the definition for the attributes time_constant and sigma_time_constant, there is a typo: “them” vs. “then”.
In the definition for the attribute projected_sun_diameter, there are extra spaces that should be removed.
In the definition for the attribute fit_rms_semimajor, the acronym “RMS” should be spelled out as “root mean square”.
In the definition for the attribute corotating_flag, “a table field”<value_meaning> for N should be reworded to say “A coronating frame was not used.”
In the definitions for the attributes corotating_ring_longitude, minimum_corotating_ring_longitude, and maximum_corotating_ring_longitude, the typo “the with” should be corrected.
In the class Ring_Reprojection/Display_Direction/
Ring_Spectrum/Display_Direction/, the phrase “Multiple entries are permitted the settings in the” in the definition should be reworded.
In the class Ring_Model/Ring_Orbital_Element/Normal_Mode_Parameters/, the typo “is one is present” in the class definition should be corrected.
In the class Ring_Reprojection/Reprojection_Geometry/, the typo “(.g., radius…” in the class definition should be corrected.
The definition of the attribute along_track_timing_offset could use more clarity; perhaps point to a journal article discussing how this quantity is used.
For the attribute occultation direction, the phrase “the distance” in all three value definitions should be converted to “the projected distance”
For the attribute ring_profile_direction, the definition of the seldom-used value “Multiple” takes up more space than the overall definition of the attribute. Should that be there? The same content is repeated in the actual value definition.
For the attribute ring_profile_direction, the definition should mention why the value “Both” is not available.
In the definitions for the attributes highest_detectable_opacity and lowest_detectable opacity, the technical definition of opacity, as well as its relationship to optical depth, should be included. And the definition should perhaps not include a reference to “nearly opaque rings,” because this excludes moderate or tenuous rings.
For the definitions of the attributes minimum_ring_longitude_observed_minus_subsolar and maximum_ring_longitude_observed_minus_subsolar, the phrase “Required in label files for ring occultation data" is in the first but not the second. It should be neither or both. The attribute is currently optional, and no schematron rule actually requires its use.
In the definitions for the attributes corotating_ring_longitude, minimum_corotating_ring_longitude, and maximum_corotating_ring_longitude, the phrase “rotating frame. The with zero longitude defined at the epoch specified by epoch_reprojection_basis_utc, zero” should be converted to “co-rotating frame.  The zero longitude is defined as the prime meridian at the epoch specified by epoch_reprojection_basis_utc. Therefore, zero”.
In the change log, Display_Direction was used from the display namespace, not the geometry namespace.
Broadly, definitions are inconsistent in their phrasing and in how they refer to one another.
Broadly, the useful phrase “the body identified in the enclosing class”, which appears in some attribute definitions (e.g., j2), should appear in others as well.

Describe alternatives you've considered
No alternates are necessary when requesting copy-edit changes.
LDD Dictionary Version
The LDD version number is not needed for an enhancement request.
PDS4 IM Version
1M00
Need-by Date
No specific need-by date applies to these requested changes.
Additional context
No additional context is needed for these changes.

This Issue corresponds to RMS-DSMP Issue A.


how migrate from ngx-translate to i18n ?

Hi,
I am working on an Angular 7 project and I have to implement internationalization
The project requires me to have only one deliverable installed at the customer server (that means only one folder)
This is why I can't use the actual version i18n, I'll use your library ngx-translate.
The new i18n version will released in a few months, I would like to anticipate the migration of ngx-translate to i18n.
I thought to inject the two libraries (i18n and ngx-translate) in the project to implement now the i18n IDs. But I'll use the pipes of ngx-translate until the upgrade is done.
It should look like this:
<p i18n="@@hometitre" translate>home.title</p>
With this, I can generate one file xlf without using it when I build the application.
Do you think this is correct?
I saw a library called i18n-polyfill . It allows us to concatenate an .xlf file generated by an i18n library and by an object that went through an i18n service.
Knowing that all my variables are into ".html" file, I don't really understand know how to use this service?

@Laetitia28 hi!
try use ngx-translate-migrate,
Tool for migrate from ngx-translate to Angular i18n.


Regarding filtering by tags

Hi,
I have been using the Cloudmapper tool for my AWS account for a while. Recently, I have trying to use the feature of filtering by tags, but am not getting the output I expected. When I try to run the prepare script by filtering for a single tag (python3 cloudmapper.py prepare --no-read-replicas --regions us-east-1 --account aws-jdf-apps-devl --config /opt/cloudmapper/src/config.json 0 --tags component:isu ), the cloudmapper tool only recognizes the EC2's that have the exsiting tag and not any other resources like Lambda and S3.
I have tried changing the return pyjq.all(".Tags[]", self._json_blob) lines in nodes.py file to return pyjq.all(".Tags[]?", self._json_blob), but that does not fix my issue. Can someone tell me what I need to do the exisiting code in order to solve my problem?

Is cloudmapper able to filter ECS and S3 resources by tags? If not, are you guys able to add functionality to enable this filtering? @copumpkin @elliot @marczak @akgood

@kvbamith I don't think any of the people you tagged are likely to assist you (at least two of them I am certain would not). It is inappropriate to do that.
CloudMapper does not visualize S3 buckets or Lambdas that are not part of VPCs.

Oh, I apologize for that. I was thinking about the notification system. Thanks for the reply. Does Cloudmapper visualize ECS?

I'm closing this issue as the network diagram functionality of CloudMapper is no longer being maintained.  Other features of CloudMapper, such as the audit functionality, is still maintained. If someone is interested in maintaining the network diagram functionality they can look at the issues tagged unmaintained_functionality for all the issues related to this that have been closed as they will unfortunately not be worked on by me.


Death_Due_To_HIV_Dataset

Description
This dataset contains the number of deaths due to HIV at various points in time.

Source : WHO

Checklist:

[x] -  I have followed the contributing guidelines of this project as mentioned in CONTRIBUTING.md
[x] -  I have cross-checked that the dataset I'm uploading is not present in the project
[x] -  I have cross-checked that the dataset is present in the correct folder

Good one @sanam2405
Congrats 🎉, your PR got merged. To be eligible for the swags from ClueLess. Follow these steps.

Star this repository. ⭐
SignIn / SignUp in [ClueLess Website](https://www.clueless.tech/) .
Go to the profile section from the top right-hand corner.

Comment your profile URL under this comment tagging the person who merged your PR.

That’s it. Follow the leaderboard!
And don’t forget to share your achievement with your friends.


merge from arlac77/template-github-action,arlac77/template-kronos-component

package.json

fix(engines): add >=14.12.0 remove >=14.11.0 (engines.node)

.github/workflows/ci.yml

chore(deps): add 14.12.0 remove 14.11.0 (jobs.build.strategy.matrix.node-version)

.github/workflows/update_readme_api.yml

chore: add 14.12.0 (jobs.update_readme_api.steps.with.node-version)

Codecov Report

Merging #829 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #829   +/-   ##
=======================================
  Coverage   28.94%   28.94%
=======================================
  Files           1        1
  Lines          76       76
  Branches        1        1
=======================================
  Hits           22       22
  Misses         54       54

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 363fe46...ee60c02. Read the comment docs.


Moving some event to private api

just because that don't use redis =>>>

[x] Use a private user service endpoint to decode the token
[x] Do the same for the CDN-service gen token

waiting for the test and debug


diamond support

Following up on our conversation via email I have added diamond support. I didn't know if you wanted the package to be named sass-mq like npm and bower or mq as you refer to it in the readme.
To publish the package when you are ready, run the following commands:
Install diamond:
npm i -g diamondpkg
Register for an account:
diamond login
Publish the package (run in package dir)
diamond publish

Thanks, that's great! Note that this is an experiment and depending on the success of Diamond (which I want to support), this may get reverted. Let's give it a few months and see how it goes!
Can you post a link to where we can see usage stats for this particular package?

The stats interface is currently being built, it should be done in 1-2 days at most. You bring up a good point, I can support pulling info from package.json files for packages that don't require any of diamond's more advanced features.

When using version 0.10.1 it will automatically pull from your package.json if no diamond.json is found. I have removed diamond.json

Sweet! I'll give it a go when it's ready for a spin.

If it is diamond you are wondering about, the registry is live right now. I am hoping to deploy download stats on friday. (Registry status)

Awesome!
Before merging, I'd like this PR to contain a test. I can do it in the next few weeks (I'm pretty busy right now), but if you have time to write one, I can get this merged sooner!

Should the test just be a basic install and compile?

Exactly, this is where tests are run: https://github.com/sass-mq/sass-mq/blob/master/scripts/test.sh

I have written some tests.

Thanks @Hackzzila! Let me have a look.

Thanks for fixing up my tests! The new site with download counts is near completion.

@Hackzzila looks like the registry is down right now so I'll hold off on merging this until it's fixed and stable, if that's okay!

Sorry about that, it was just a bug with the status page. The registry itself seems to be stable. You should be good to go. If you encounter any bugs please let me know!

Hmm, weird, I get this when I try to install a package:
diamond install bootstrap
dia ERR! registry error: 404 bootstrap
dia ERR! not ok

That is because of the move to the new registry. Bootstrap is not currently published to the registry. If you want to install a package from the npm registry, use diamond install npm:bootstrap. You could try diamond install sierra. The examples are updated in the new docs (note: this is a work in progress).

Thank you! I published sass-mq and it works.
I have two questions:

Do we have to run diamond publish for every new version or will the registry pick up new tags automatically?
Does diamond support dist-tags like npm?

You currently have to publish for every version, but automation is something to look into.

Yes http://vue.diamond.hackzzila.com/#/docs/cli/tag

Got it. Thanks! Ideally publication would be fully automated on this repository and handle both npm and Diamond, then. If you have any pointers / tutorials for doing both, that'd be great, because like a lot of open-source contributors I'm trying to make sure this part is taking as little of my time as possible.


MAINT: Update constants to codata 2018 values (second try)

For issues see the comments on the commits.

My mistake, the replacement works fine. I'm however unsure about the last bit of code:
# finally, insert aliases for values
for k, v in list(_aliases.items()):
    if v in _current_constants:
        physical_constants[k] = physical_constants[v]
    else:
        print(k)

The replacement of the name with an alias does however not work as 'vacuum mag. permeability' is (already) part of the newest set of data and therefore it can't be replaced by its alias 'magn. constant'.

I don't fully follow this. Right now in master we have:
>>> from scipy import constants
>>> constants.value('magn. constant')
1.2566370614359173e-06
>>> constants.value('vacuum mag. permeability')
...
KeyError: 'vacuum mag. permeability'

So what is the issue exactly with giving 'magn. constant' and 'vacuum mag. permeability' both the same, updated value for this constant?

The replacement of the name with an alias does however not work as 'vacuum mag. permeability' is (already) part of the newest set of data and therefore it can't be replaced by its alias 'magn. constant'.

I don't fully follow this. Right now in master we have:
>>> from scipy import constants
>>> constants.value('magn. constant')
1.2566370614359173e-06
>>> constants.value('vacuum mag. permeability')
...
KeyError: 'vacuum mag. permeability'

So what is the issue exactly with giving 'magn. constant' and 'vacuum mag. permeability' both the same, updated value for this constant?

That is in principle not a big issue. It just won't work with the following code:
# finally, insert aliases for values
for k, v in list(_aliases.items()):
    if v in _current_constants:
        physical_constants[k] = physical_constants[v]
    else:
        del _aliases[k]

as it checks the names in the physical_constants against the names in the _current_constants. And with this code I don't see a way to set the alias magn, constant for the variable vacuum mag. permeability.

Can someone help me out?

Tests are failing because of
In [11]: _physical_constants_2002['atomic unit of mag. dipole moment']
---------------------------------------------------------------------------
KeyError                                  Traceback (most recent call last)
<ipython-input-11-7a09a706b73b> in <module>
----> 1 _physical_constants_2002['atomic unit of mag. dipole moment']

KeyError: 'atomic unit of mag. dipole moment'

In [12]: _physical_constants_2002['atomic unit of magn. dipole moment']
Out[12]: (1.8548019e-23, 'J T^-1', 1.6e-30)

In [13]: physical_constants['atomic unit of mag. dipole mom.']
Out[13]: (1.85480201566e-23, 'J T^-1', 5.6e-33)

Your changes to parsing have somehow caused the 2002 entry for atomic unit of magn. dipole moment to not be transformed to atomic unit of mag. dipole mom. anymore

Tests are failing because of
In [11]: _physical_constants_2002['atomic unit of mag. dipole moment']
---------------------------------------------------------------------------
KeyError                                  Traceback (most recent call last)
<ipython-input-11-7a09a706b73b> in <module>
----> 1 _physical_constants_2002['atomic unit of mag. dipole moment']

KeyError: 'atomic unit of mag. dipole moment'

In [12]: _physical_constants_2002['atomic unit of magn. dipole moment']
Out[12]: (1.8548019e-23, 'J T^-1', 1.6e-30)

In [13]: physical_constants['atomic unit of mag. dipole mom.']
Out[13]: (1.85480201566e-23, 'J T^-1', 5.6e-33)

Your changes to parsing have somehow caused the 2002 entry for atomic unit of magn. dipole moment to not be transformed to atomic unit of mag. dipole mom. anymore

Well, I renamed the name of the parsing function from parse_constants to parse_constants_2002to2014 but I did not change the content of the function. And I also think there was no alias before my commits that changed moment to mom. in the 2002 values.

So, in total you could say that this pull request got pretty messy. You can take it but if you want to solve the alias and test function issue another way, I won't blame you. The current situation is not perfect as the alias mechanism did not sufficiently handle the way how aliases were generated for the test function and so I had to change the test function.
So if you want to go with a more sophisticated approach, you have my blessing. If not, happy merging.

Is there any news on your decision about this pull request? Can it be merged or do you want to refactor the codata value import mechanism in a more fundamental way?

Both keys still work, so find returning a different key shouldn't really matter - that's not a real backwards compat break I'd say.
>>> constants.physical_constants['natural unit of momentum']
(2.730924488e-22, 'kg m s^-1', 3.4e-30)
>>> constants.physical_constants['natural unit of mom.um']
(2.730924488e-22, 'kg m s^-1', 3.4e-30)

Let's get this in. Thanks @jakobjakobson13!


should be (???) doesn't compile

Doing scala and Akka trainings, I would like to use ??? as a stand-in for the matcher and have it compile.
val result = ....
result should be (???)

I don't necessarily need to run it, but if it does run it should still result in a NotImplementedError, it just seems like a perfect stand-in for any student to fill in the answer and remove pending to see if they're right. It also seems perfect as a stand-in for any testers.

Didn't know, that putting pending up front made the whole thing pending.  Therefore, this should be closed too, unless you find value keeping it open

OK. Sure. Closing.


Lambda in Xamarin.iOS - returning signature error when payload

I'm getting an error when including a payload to invoke a Lambda Function. It works when the payload is empty though. It returns the following error:
"The request signature we calculated does not match the signature you provided. Check your AWS Secret Access Key and signing method. Consult the service documentation for details. The Canonical String for this request should have been..."
Secret Access Key and other data are ok, and as I said it works when including an empty payload string:
try
{
    var lambdaClient = new AmazonLambdaClient("XXXX", "XXXX", RegionEndpoint.USEast1);

    //var args = @"{""value1"" : ""one"", ""value2"" : ""two"", ""value3"" : ""three""}"; // <--- RETURNS ERROR
    //var args = @"{""value1"" : ""one""}"; // <--- RETURNS ERROR
    //var args = "{ }"; // <--- RETURNS ERROR
    var args = ""; // <--- 202 and responds with the expected message

    var ir = new InvokeRequest() {
        FunctionName = "arn:aws:lambda:us-east-1:XXXXXX:function:helloWorld",
        //Payload = args,
        PayloadStream = AWSSDKUtils.GenerateMemoryStreamFromString(args),
        InvocationType = InvocationType.RequestResponse
    };

    InvokeResponse resp = await lambdaClient.InvokeAsync(ir);

    resp.Payload.Position = 0;
    var sr = new StreamReader(resp.Payload);
    var myStr = sr.ReadToEnd();

    Console.WriteLine("Status code: " + resp.StatusCode);
    Console.WriteLine("Response content: " + myStr);
}
catch (Exception ex)
{
    Console.WriteLine("error: " + ex.Message);
}

I tried with Cognito credentials and same results. Also tried with Payload and/or PayloadStream in the InvokeRequest object, same results.
Working with Xamarin.iOS and Xamarin Studio. I included the package AWSSDK - AWS Lambda <IP_ADDRESS> from the official NuGet Gallery.
Thanks, hope you can help me!

Thank you for reporting this. We've just released a patched version of the SDK which resolves this issue. The version of the patched Lambda package on NuGet is <IP_ADDRESS>.
Sorry for the inconvenience.


Add option to support line numbers

I believe a viable enhancement to this plugin would be addition of the option to show line numbers in the screenshot. It might help when not whole file is screenshotted but rather a section of it. When creating guides online or sharing code snaps with others it helps whomever is reading to orient themselves in the file.

Hi @Dmusulas, thx for the issue reporting, line numbers are supported in v1.2.0, you can upgrade CodeSnap.nvim to v1.2.0 and add has_line_number = true to open display line numbers feature.


fix: HasAction: Pass all data to actions created from string

As mentioned in Discord: Actions created from a string received different data than callables.
https://discord.com/channels/883083792112300104/883085267383226478/928258984081784892

We should probably do this for bulk actions as well

I might be wrong here, but aren't you using first class callables? Does this work in PHP 8.0?

It's only arrow functions (PHP 7.4) and variable parameter/array unpacking (PHP 5.6).

Ah right fair enough, but does dependency injection still detect those properties correctly on the original closure? You've tested this, right?

Ah right fair enough, but does dependency injection still detect those properties correctly on the original closure? You've tested this, right?

No it required the arguments in the right direction. Since you introduced the $this->evaluate() here, we can apparently create a Closure on the fly since it's evaluated at a later point 🤔 Before I got Livewire errors.

Thanks :)