Add Save All button to save secrets

Status
Ready for review / Work in progress
Description of Changes
Fixes #88
Added a Save All button to the distribute view. To achieve this logic is moved from CopyButton, SaveAllButton and ShareRow up to Distribute.
Because it can happen that most shares save successfully and only some fail, I wanted to display the status of every share individually. I opted to display the status of every save action in the share row itself.
Implementation:

I've moved the copy and save logic into Distribute.js.
Save All does the same as if you saved each of share one-by-one and the error handling is exactly the same.
With Save All you can't choose the filename. Because this might overwrite an existing file Save All fails if the file already exists.
I've moved the 'Save failed' field to the status text, this is more clear imo and allows us to show specific errors in the tooltip.
When copying, only one copy button will indicate "Copied" and it will return to default after 5 seconds.
Due to these changes ShareRow is basically reduced to rendering, CopyButton and SaveFileButton is not used anymore in this view.

Possible improvements

Improve styling of the Save All button. It kind of dissappears now in the panel now. Maybe give it a colour?
Some general refactoring is probably also possible...

Testing
Try copying and saving some shares.

Hey, @koenaad. I agree with Gabe, there's more change here than we probably want/need. Let's start by

[ ] moving the share saving stuff into a shared module, and
[ ] dropping the changes to the copy button behavior, since that's not really related to the Save All function.

is it possible to access SaveFileButton from a Save All button?

As you may have seen, in React, data flows down from a component to its children via their 'props'. So if Distribute needs to communicate anything to a button in a ShareRow (like a relevant error status), it should render it as a property of the ShareRow, and the ShareRow can render it as a property of the SaveFileButton, and the SaveFileButton can render it as text, if that's your goal. Note that child components can also listen for lifecycle events in order to update their internal state in response to changing props.
These might be helpful reading if you haven't seen them yet:
https://reactjs.org/docs/components-and-props.html#extracting-components
https://reactjs.org/docs/state-and-lifecycle.html

or should we opt for a different solution to show that Save All failed?

If there are more suggestions, I'm happy to hear them, but I do think per-file status is the way to go here. I don't think the roll-back or empty directory requirement are viable solutions for various reasons...

Hey @GabeIsman and @liliakai, thanks for the feedback. I've read up more on the principles and architecture behind React.
I've started from scratch on my fork and opened a new PR here: #133 (hope opening a new PR isn't too spammy)


Domain activation is Failed - [BRIEF DESCRIPTION]

App Id: d3279rrl8pe3lu
Region: us-east-1
Step: Domain activation
Status: Failed

Note: Do not include information that is sensitive in nature such as your domain name, company etc.

Issue/question
A clear and concise description of what the issue/question is.
Error message
If there is an error message, please include it here.
Note: Be sure to check the message for sensitive information.
Additional information
Please add any other relevant information. Please feel free to include screenshots.

Our records indicate that this app has been deleted.


Trying to automatically call submit once a condition is met.

THIS question has got me part of the way to this answer, but I'm still missing something. I want to be able to conditionally submit a form once a certain input length is reached, but I cant seem to call the my handleFormSubmit function from anywhere except the component and still have access to the formProps that I need to attach to the payload of the action that gets dispatched on the submit. Could anyone point me in the right direction? This is what I have so far:
import React from 'react';
import { connect } from 'react-redux';
import { Field, reduxForm } from 'redux-form';
import { withRouter } from 'react-router-dom';
import { getProductDetails, formatTable } from '../actions';

const form = reduxForm({
  form: 'postUPC'
});

const upcNormalizer = upc => {
  if (!upc) return upc;
  const onlyNums = upc.replace(/[^\d]/g, '');
  if (onlyNums.length < 12) {
    return onlyNums;
  } else {
    return onlyNums.slice(0, 11);
  }
};

export class SearchBar extends React.Component {
  constructor(props) {
    super(props);
    this.handleSubmitWrapper = this.handleSubmitWrapper.bind(this);
    this.handleInputChange = this.handleInputChange.bind(this);
  }

  handleSubmitWrapper() {
    const { handleSubmit } = this.props;
    console.log('SUBMITTING NOW');
    handleSubmit(this.handleFormSubmit.bind(this))();
  }

  handleInputChange(e) {
    const currentInput = e.target.value;
    if (currentInput.length == 12) {
      this.handleSubmitWrapper();
    }
  }
  handleFormSubmit(formProps) {
    this.props.getProductDetails(formProps);
  }

  renderAlert() {
    if (this.props.errorMessage) {
      return (

            Error!
            {this.props.errorMessage}

      );
    }
  }
  render() {
    const { handleSubmit, onChange } = this.props;
    return (

        <form>
          {this.renderAlert()}

            <Field
              onChange={this.handleInputChange}
              normalize={upcNormalizer}
              autoComplete="false"
              autoFocus="true"
              name="upc"
              component="input"
              type="number"
              placeholder="Enter UPC"
            />
            UPC

        </form>

    );
  }
}

const mapStateToProps = state => ({
  products: state.table.products
});

export default withRouter(
  connect(mapStateToProps, { getProductDetails, formatTable })(form(SearchBar))
);

Your issue doesn't belong in our GitHub issue tracker, because it seems to be a usage support question; in this case, please open a question in StackOverflow, and use the redux-form tag.
If we're wrong, or if you are able to lay it out better, perhaps we will be able to help you.
In this case, please open a new issue.
Thanks for using Redux Form!


[Question] How to set value of search field programatically

Hello,
I'm trying to implement an onRowClick handler that sets the search field value to some string from the row data. I'm using the custom SearchField component as described here:
http://allenfang.github.io/react-bootstrap-table/custom.html#searchfield
However, I can't get a ref to this component to set its value manually:
<SearchField
  ref={component => { this.searchField = component; }}
  ...

componentDidMount = () => {
    console.log('searchField node: ', this.searchField); // undefined

I also tried this approach from the docs
// Search table for 'React.js'
this.refs.table.handleSearch('React.js'); // this.refs.table is a ref for BootstrapTable

The handleSearch function correctly filters the data and the clear search button works, however it does not set the desired value into the input field, so the user does not know there is a search going on.
Any ideas on how can I access the input element and set its value programatically? Something like this.refs.searchField.setValue(rowData.foo); would be ideal

Solved by using a custom component as described in item 02 from doc topic above, exposing a ref to its  element. The DOM node can then be accessed using
[ref to BootstrapTable element].refs.toolbar.refs.seachInput.[ref to input element] ( note the seachInput typo)


ACM-4615 get pull secret instead of dockerconfigjson from mce credentials

What this PR does / why we need it:
get pull secret instead of dockerconfigjson from mce credentials to make consistent with https://github.com/openshift/hypershift/blob/main/docs/content/how-to/aws/create-aws-hosted-cluster-secret-credentials.md. This allows for successful cluster creation when following the docs
Which issue(s) this PR fixes:
Fixes https://github.com/openshift/hypershift/issues/2179 & https://issues.redhat.com/browse/ACM-4615
Checklist

[x] Subject and description added to both, commit and PR.
[x] Relevant issues have been referenced.
[ ] This change includes docs.
[ ] This change includes unit tests.

Before:
2023-03-28T14:53:44-04:00	INFO	Retreiving credentials secret	{"namespace": "clusters", "name": "aws-secret-test"}
2023-03-28T14:53:51-04:00	ERROR	Failed to create cluster	{"error": "failed to default network: failed to get version for release image quay.io/openshift-release-dev/ocp-release:4.13.0-rc.0-x86_64: the .dockerconfigjson key is invalid, {namespace: clusters, secret: aws-secret-test}"}

After:
2023-03-28T16:03:49-04:00       INFO    Retreiving credentials secret   {"namespace": "clusters", "name": "aws-secret-test"}
Using baseDomain from the --base-domain flag
2023-03-28T16:03:54-04:00       INFO    Creating infrastructure {"id": "dockercfg-xtf6p"}
2023-03-28T16:03:54-04:00       INFO    Using zone      {"zone": "us-east-1a"}
2023-03-28T16:03:55-04:00       INFO    Created VPC     {"id": "vpc-06773e8e4cab02449"}
.
.
... to completion

/cc @rokej @jnpacker

@o-farag Can you please make sure it also works with the secret that MCE UI creates? Thanks.

@rokej using the secret the ui creates works as well

Same output as the description

/ok-to-test

/area hypershift-operator

/approve


slackarchive.io isn't up to date

It looks like it stopped working on the 11th January. It also doesn't appear to have been tracking #general and really needs to now that we shut down #getopenjdk earlier this week.

I've pinged their support as I've forgotten where to go to fix this.

I've added the slackarchive not to #general so hopefully when @karianna gets it back up and running we should start getting an archive of #general.

Apparently @gdams support is more responsive than the official one, I've pinged them again

@karianna Any progress on this?  Still no archiving of the #general channel :-(  Worth chasing again.

Yeah I've pinged them again, annoyingly no response and they've taken another year's payment!

They're dropping the service - we may have to host our own based off https://github.com/AdoptOpenJDK/slackarchive

From slackarchive:
Hi,
What will be the easiest is to work with the SlackArchive Importer to import an exported archive from Slack.
Remco

I'm not sure if hosting this ourselves is a good idea... I imagine that we are going to require a huge amount of disk space to store the full archive

It's text, I suspect it'll be tiny.
Cheers,
Martijn
On 3 May 2018 at 12:37, George Adams<EMAIL_ADDRESS>wrote:

I'm not sure if hosting this ourselves is a good idea... I imagine that we
are going to require a huge amount of disk space to store the full archive
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/AdoptOpenJDK/openjdk-infrastructure/issues/312#issuecomment-386266618,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AALCaD7mBOSqRIVlN4aLqvJ1Tmc0j-gKks5tuuwIgaJpZM4StyOR
.

We've got a paid slack instance now so have the history back - closing


[CWS] fix usage of the secl dependency on darwin, and policy loading from outside the agent

What does this PR do?
This PR:

ensures SIGKILL is defined in SignalConstants on macOS/Darwin, as this is used in some dd-go tests
make PopulateFieldsWithRuleActionsData public, as this needs to be used to fix-up the actions in rulesets. Needed for backend validation

Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

/merge


add doc example for using jussi for local services dev

supplants https://github.com/steemit/devportal/pull/206

The separate pieces necessary to put this together are now covered in the readme (like how to specify a config file to use, how to edit the config file, etc). Closing in favor of #219


Block stuck at 2,000,190 won't sync

Anyone else have this problem? Block stuck at 2,000,190 and won't add any more blocks to it. Everything just stuck there for days.

same issue here

Jdog88, i've resolved my issue by starting again...
Deleted Neo Gui folder
Downloaded NEO Gui again
Downloaded "Offline Synchronized Data"
Extracted downloaded NEO-Gui into a folder in C:\ drive
Opened the extracted NEO-Gui folder, then, extracted the downloaded "Offline Synchronized Data" into the NEO-Gui folder (root directory)
The "chain.acc" file will be in the NEO-Gui folder
Ran "NEO-Gui.exe"
It quickly synced to latest block hight

solution here (I haven't tested it, but looks legit)
https://www.reddit.com/r/NEO/comments/83j7dl/is_your_neo_node_stuck_at_2000190/

@Johnydog @Jdog88 @jrsikors Some of nodes have this problem recently, just resync your blockchain will be fine. You can use this offline blockchain data package(http://static.neo.org/client/chain.acc.zip) to make it faster.

@PeterLinX  ... it seems like some people are having the problem even with the chain.acc.zip ... unless there is a newer chain.acc.zip that gets you past the 2000190 block.
It actually looks like CoZ removed the non chain.acc.zip bootstrap ... judging on some of these  comments ... i wonder if it wasn't fixing it and causing more problems.

@PeterLinX @jrsikors I used Peter's Link above and resync the blocks and it reached over 2000190.

WTF ? How can this happen ?

I can't tell if your comment is meant to be funny @vidov1  :smile:
You can always start from 0/0/0 and download the blockchain the way it was originally intended to be done... which is downloading blocks 1 at a time.

@Johnydog @PeterLinX .. so i noticed in Johnnydogs, instructions you actually UNZIP the chain.acc.zip .. that wouldn't be what the instructions at http://docs.neo.org/en-us/node/gui.html say to do.
Are the instructions on the site wrong?  Do you actually need to unzip the chain.acc.zip ?

@erikzhang  as well .. see my previous post

No, we needn't unzip it.

Thanks @erikzhang  -- you can close this one -- @Jdog88  , who originally posted the issue, said he was good to go.
Anyone else still having similar or different problems should create a new issue.


Button improvements

Description

Small code improvements on the Button class.

Motivation and Context

Improvements were suggested in the .NET IoT port of the Button, and make the code better.

How Has This Been Tested?

Existing unit tests ran.

Types of changes

[x] Improvement (non-breaking change that improves a feature, code or algorithm)
[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Config and build (change in the configuration and build system, has no impact on code or features)
[ ] Dependencies (update dependencies and changes associated, has no impact on code or features)
[ ] Unit Tests (work on Unit Tests, has no impact on code or features)
[ ] Documentation (changes or updates in the documentation, has no impact on code or features)

Checklist:

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.

Closed; wrong branch :)


Create phot_per_sec.py

This file contains phot_per_sec.py, the python code which uses MESA output (effective temperature and stellar radius) and determines the number of photons emitted by a star every second for a single period for each wavelength in the ROTSE-III CCD sensitivity range.

@aawallace, @johnridge, same question -- why is this PR not merged?  Has this code been tested?


Fixing issue where service account did not get PSP bound

This change fixes an issue where newly created service accounts sometimes
do not get a role binding created for them, and therefore cannot create
pods because they don't have an associated pod security policy. This
is happening because role bindings are being incorrectly deleted and,
coupled with a race condition in the serviceaccount.go logic, are not
recreated successfully. This change prevents those role bindings from
being deleted incorrectly and causes the service accounts to have their
psps assigned correctly.
Issue:
https://github.com/rancher/rancher/issues/14441

LGTM


⚠ Bofrost.lu has degraded performance

In edaffb6, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1205 ms

Resolved: Bofrost.lu performance has improved in ec0037f after 6 minutes.


LLVM 10,11,12,13,14: add enableZ3 argument

Description of changes
Added Z3 to the build inputs of LLVM versions 10-14 when not cross-compiling. Cross compiling needs further CMake variables I have not personally tested hence the test beforehand.
Things done

Built on platform(s)

[X] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

cc/ @symphorien @sternenseemann

This should target staging.
Does this make z3 enter the closure of everything by default on darwin (which uses a llvm stdenv) ?

Yeah afraid this needs to be off by default, because of the bootstrapping situation.

@Ericson2314, I'll try to add the necessary flags to make z3 cross-compilable.

@symphorien, I have tried pkgs.pkgsLLVM.llvmPackages_10.stdenv and Z3 is used. Same thing with pkgs.llvmPackages_10.stdenv.

@peperunas No this isn't just about cross, but also about native Darwin boostrapping. Please make the new feature off by default, so this is not a mass rebuild. Then we can merge it and separately decide when it is safe to turn on.

@Ericson2314, done that and I added a TODO to remind us to take care of the edge case later.
Let me know if there's anything else I should do and thank you and @symphorien  for the review :-)


feat: added gym quotes

Hey @Shariar-Hasan, I noticed that there is only 1 quote in the "Gym" Category so I have added more quotes for gym. Please provide your suggestions if any changes are needed.
For this category generally The authors are not known So i couldn't find a lot of quotes. I'll add more when I find.

cool, thanks for the contribution


[ur] Localize 'devops' in Urdu

Need to localize devops term in Urdu language

You can work on it

Closing Issue as PR Merged


Update to Epi 11 and some improvements

Hi @jstemerdink,
Just want to acnolage that I've seen this but been on vacation, so I've not had time to review it yet. Hoping to do so during this week.

@LinusEkstrom No worries, hope you had a great vacation! See you at the summit In October?

I will most likely not travel to the US this autumn for the EMVP summit and Ascend event, but I'll surely join Sthm Ascend and potentially some of the other European Ascend events. Hoping for the next EMVP event a bit closer...

Nice additions to the code and usage samples, good work! Will be looking to see if this is something we'll start using for Epinova.

You did the groundwork :) Used it a few projects myself

Good to hear, and I remember you telling me this before when we met. I've been spending quite a lot of effort in taking the "Feature Folders" concept further then what I've seen others do, with the goal to have as little as possible of feature specific code outside of the feature folder. Settings has been a nail in the eye, that's somewhat mitigated by using this system.


Add docstrings

@gavinsunde You're probably gonna want to commit and merge your changes more often (like, even if they're not perfect yet) because this kind of work is very likely to result in merge conflicts


Any chance to build this for VS Code

It's the more popular editor. I love this plugin and would esp love it over there.

sorry, I've no any experience on vscode plugin development, but you're welcome to contribute to porting this plugin and I'm glad to help :)

I think I am interested in working on this. Using VS code or a fresh electron canvas to work on you could create something cross-platform and truly exceptional. For example you could do something like the MarkText but with a keyword to search and or toggle the two panel style from NV. I am kind of excited by this but won't be able to do anything until early March


Update react template to use the public 18.3.0-beta.1

@pamelabrasil I thought we agreed that I will be approving PRs that make changes to projects templates and scripts!

I really wish if this was true "The team is more than capable in doing changes in this infrastructure when required, including in gulp." but it is not!


Demo application planned?

Just a question: Is a demo application (seleton) planned? Thank you! Gabriel

This is an open sourced library for a closed-source commercial application we are developing.  At this stage, there isn't a demo app / skeleton application planned.  However, if the Readme isn't sufficient for what you want to do, raise an issue here and I'll try to help out.
Also, a common mistake that people make is that because of the naming convention we've used, is that this is an official Aurelia (Durandal Inc.) Plugin.  It isn't.


Update API client to support querying by deposition_id

Update the API client to support querying annotations by deposition_id.

@manasaV3 this was missing an assignee so i added you :) feel free to reassign!


Release Google.Cloud.DocumentAI.V1 version 3.8.0

Changes in this release:
New features

Added http configuration and document publishing for v1beta2 (commit 0090f90)
Added ImportDocuments, GetDocument and BatchDeleteDocuments RPCs for v1beta3 (commit 0090f90)

Created release for Google.Cloud.DocumentAI.V1-3.8.0


Helm chart for deploying the Operator

Is your feature request related to a problem? Please describe.
Currently to install the Operator the suggested approach is to run the 'make deploy' command. I was wondering if it would be possible to create a Helm chart for the Operator. Users typically have Helm installed. Providing a Helm chart will make Operator installation consistent with other uses.
Describe the solution you'd like to see
The deploy rule from Makefile is below:
deploy: install-kustomize
kubectl apply -f config/crds
kubectl apply -f config/manager/namespace.yaml
./scripts/image_patch.sh ./config/default/manager_image_patch.yaml ${IMG}
bin/kustomize build $(KUSTOMIZE_BASE) | kubectl apply -f -
kustomize installation can be broken out into a separate script which installs all the pre-requisite tools. Such a script can also include the execution of image_patch.sh script and execution of 'kustomize build'. The rest of the commands that remain in the deploy rule are application of Kubernetes YAMLs. These can be turned into a Helm chart.
Describe alternatives you've considered
Alternative is what exists today - using the 'make deploy' command.

Hi, we already have a Helm chart for the operator, it can be found here: https://github.com/banzaicloud/banzai-charts/tree/master/istio-operator

Awesome!! Thanks for the pointer.
May be I missed it, but I did not find reference to the chart in the README.

you're right, we forgot to mention it in the readme, we'll add it.


Firelock ECS + some other stuff.

This PR:

Moves all firelock logic into the system
Combines IsHoldingPressure and IsHoldingFire into a single function

Less iterating over neighbouring tiles & checking for blocked/airtight directions.

Fixes pressure & fire checks.

Previously these just didn't work because a fire lock would only iterate over un-blocked adjacent tiles, but the airlock itself ensured that there were no unblocked tiles.
The way it does these checks now might be somewhat questionable. This will probably also needs rejigging for the planet/atmosphere stuff. @Zumorica

Makes the FirelockSystem periodically check if a firelock is holding back pressure or a fire, and will turn on lights if it is.

The pressure check is only done for closed firelocks, but does still involve periodically querying & iterating over all firelock entities
Might be better to give firelocks an ActiveFirelockVisuals component whenever they get closed, and iterate over that instead?

Some sprites were changed

Some blank closed_unlit states were fixed.
Shuttle airlock closed_unlit and bolted_unlit were swapped, to make them consistent with other airlocks (red for bolted, orange/yellow for closed).
There is now an appearance data enum to toggle showing the closed_unlit state.

The actual reason this PR exists is because I wanted to start working on proper pressure cycling airlocks, and was working on a pressure-sensing component for doors that would turn a light on and block opening if there was a significant pressure difference, but then I realized that firelocks basically already did all this and you could just slap a firelock onto an external airlock. But then again, maybe some of the firelock functionality should just be split off into different components.
Demo video showing the is-holding-pressure checks in action. I haven't actually tested fire. Video also shows some external airlocks that were given a firelock component, but the entity prototypes weren't actually changed.
https://user-images.githubusercontent.com/60421075/169737147-f32ae871-b247-4814-9a8a-46cc0e225710.mp4
Note that the video shows the wrong pop-ups (fire warning instead of pressure warning). This has since been fixed.
:cl:

fix: Firelocks will now properly warn users that try to open them if they are holding back an inferno or the cold vacuum of space.

I think the firelock tried to close on me, and became both open, and airtight at the same time.

fixed merge conflict
had to replace CheckPressureAndFire with not as optimized version, was no longer compatible with master.
fixed bug with EmergencyPressureStop making the door open, but air tight.

Played with it for a bit, and it seems to work fine now. Going to merge it like this, instead of it being stuck for eternity.


ADL library not found

ADL library not found
NVIDIA 3070

You can disable the AMD flag, it should work!
This is my example:


Add analyzer to make sure Retry Attributes are used correctly

Some extensions configure retry policies at the function level and some do not (doc here).
We should add an analyzer that throws a diagnostic error/warning when a Retry Attribute is used incorrectly.

Design Discussion topics:

Review api surface
Can we find a way to improve retry policies (will it need breaking changes?) since there are so many configuration options/rules
After 1 & 2 do we still need an analyzer?


tcell 2.0 only displays truecolor ansi codes

Hi,
I use tcell in combination with libvterm.
I recently updated to 1.4 and found that themes were ignored when displaying ANSI colors, so I was happy to see that this was fixed for 2.0. However a new problem has come up:
$ printf "\x1b[38;2;255;100;0mTRUECOLOR\x1b[0m\n"
TRUECOLOR

correctly prints TRUECOLOR in an orange hue
$ printf "\x1b[31mRed\x1b[0m\n"
Red

Prints "Red" without any color.
I've tested a few truecolor palette displays and they work perfectly, while 256 palettes don't display anything. My prompt also lacks its usual color.
My setup is Alacritty, Linux and solarized-dark theme.

Yes, I also need it for this.

Whoa.  That printf above suggests a terminal bug -- like it can't support both truecolor and palettized colors at the same time.
I think you should file this as a bug against Alacritty.  Probably alacritty can't use 24-bit color until this is fixed.

@gdamore Hmm, I am not sure if that's the cause!
The exact same bug appears in iTerm 3.4.2.
Also both iTerm and alacritty show the right colors when the printf is executed directly in a teminal (so not inside tcell).
Lastly, tcell 1.4 does show these in color, but only uses 24-bit colors to represent them (as is expected on that version).
Could it be that somewhere in the palettization the conversion is only done correctly for 24-bit color, but not others?

I've added the colored strings to https://github.com/gdamore/tcell/blob/master/_demos/hello_world.go and they work perfectly, so it's something on my side after all.
Closing this, but @gdamore if you have any idea/pointer as to what changed in getting tcell to show these colors in version 2.0 I would be curious to hear it!


Multiple tabs with differents routes in the same component

I would like to know how I put 2 tabs with different routes in the same component, can someone help me?

Lack of information


Don't add helmrelease controller to the manager when remote subscript…

…ion is running on hub cluster
Signed-off-by: Xiangjing Li<EMAIL_ADDRESS>https://github.com/open-cluster-management/backlog/issues/8427
https://github.com/open-cluster-management/backlog/issues/7533

XJ not sure how diff is the release 2.1 and release 2.2 branch because the remove operator sdk work. Hopefully its relatively straightforward to pull this change to 2.1.

XJ not sure how diff is the release 2.1 and release 2.2 branch because the remove operator sdk work. Hopefully its relatively straightforward to pull this change to 2.1.


[iOS] TextInput does not scroll to reveal what's being typed

If a user inputs a large text into a TextInput it's stopping the caret at the last visible position without showing what's being typed by the user.
React Native version:
info Fetching system and libraries information...
System:
    OS: macOS 10.14.5
    CPU: (8) x64 Intel(R) Core(TM) i7-6700HQ CPU @ 2.60GHz
    Memory: 534.96 MB / 16.00 GB
    Shell: 5.3 - /bin/zsh
  Binaries:
    Node: 10.15.3 - ~/.nvm/versions/node/v10.15.3/bin/node
    Yarn: 1.17.3 - /usr/local/bin/yarn
    npm: 6.4.1 - ~/.nvm/versions/node/v10.15.3/bin/npm
    Watchman: 4.7.0 - /usr/local/bin/watchman
  SDKs:
    iOS SDK:
      Platforms: iOS 12.2, macOS 10.14, tvOS 12.2, watchOS 5.2
    Android SDK:
      API Levels: 23, 25, 26, 27, 28
      Build Tools: 23.0.1, 24.0.0, 25.0.1, 25.0.2, 25.0.3, 26.0.1, 26.0.2, 26.0.3, 27.0.3, 28.0.2, 28.0.3
      System Images: android-26 | Google APIs Intel x86 Atom, android-28 | Intel x86 Atom, android-28 | Google APIs Intel x86 Atom_64
  IDEs:
    Android Studio: 3.0 AI-171.4443003
    Xcode: 10.2.1/10E1001 - /usr/bin/xcodebuild
  npmPackages:
    react: 16.8.6 => 16.8.6
    react-native: 0.60.5 => 0.60.5

Steps To Reproduce

Create a TextInput and set either prop: value or defaultValue
Add fontSize and lineHeight to the field's style.

<TextInput
  defaultValue='some default value'
  style={{ fontSize: 28, lineHeight: 32 }}
/>

Our investigations have discovered this is an iOS only issue. It appears to happen only for devices without the notch. These were the ones we were able to observe the issue happening:

iPhone 8 (12.4)
iPhone 8+ (12.1.2)
iPhone 7+ (11.4.1)
iPhone 6S+ (11.4.1)
iPhone SE (9.3.2)

The issue does not occur for Android. We were also able to notice the correct behavior happening on iPhone X and XS Max.
Describe what you expected to happen
The TextInput should scroll to the side revealing what the user is typing.
Example
Run this on iOS: https://snack.expo.io/Sk3hmoHBB

This, for one reason or another, is caused by the existence of the lineHeight style property.

This, for one reason or another, is caused by the existence of the lineHeight style property.

Not for me. It occurs when setting a custom font (fontFamily) and size (fontSize).

In the environment I'm working on this doesn't seem to have anything to do with line height, and instead depends on the fontSize style prop.
As far as I can tell, the issue appears when the font size is above a certain value, which depends on the font family. For example, the default iOS font seems to break at sizes above 15, and the font my team is using (Google's Poppins) breaks above 13.

it seems to me this can be related to both lineHeight and fontSize. For example in my app if the size is 14 it scrolls correctly with a line height set. If I set the size to 16 it will not scroll until I remove the lineHeight.

still exists as far as I can tell

still a bug in my testing

:\


Use Videogular with ngRoute

Hello,
I have an issue using Videogular with ngRoute. I can use the two of them separately, but when I try to use them together, I have the following error: " HTTP "Content-Type" of "text/html" is not supported. Load of media resource http://localhost:8383/videogular/index.html failed".
In my app.js I have:

angular.module('myApp', [
"ngSanitize",
"com.2fdevs.videogular",
'ngRoute'
])

Why doesn't it work?

I don't know, it works in our demo app.
http://videogular.com/demo/#/


replication deadlocks after Unreachable error from the Network

Describe the bug
When you modify the example network implementation to treat 'Connection Refused' or similar errors as Unreachable, the ReplicationCore main() loop seems to block forever in drain_events
To Reproduce
Steps to reproduce the behavior:

Update the rocksdb example to use Unreachable in the event one of the nodes is unavailable.
modify the script that runs the example to stop the leader node, and bring it back online a bit later after a new leader is chosen.

Expected behavior
The downed leader will come back as a Follower
Actual behavior
The downed leader comes back initially as a Follower, but can receive no updates, and ultimately eventually becomes Candidate, and the split never resolves itself.   The 2 nodes from the cluster that stayed up keep communicating with each other, and the one that was down appears to be all alone.
Env (please complete the following information):

OS: linux
CPU: AMD EPYC
Rust-toolchain: nightly-2023-05-04
Openraft version 0.8.4 ( current main branch )

Additional context
The fix seems to be to change the end of main() to run either   backoff_drain_events or drain_events, but not 1 after the other.
            if let Some(b) = &mut self.backoff {
                let duration = b.next().unwrap_or_else(|| {
                    tracing::warn!("backoff exhausted, using default");
                    Duration::from_millis(500)
                });

                self.backoff_drain_events(Instant::now() + duration).await?;
            } else {
                self.drain_events().await?;
            }

With this change, the backoff_drain_events happens every 500ms, until the node comes back.  Then it seems to rejoin the cluster and get heartbeats again.
Without this change, this code seems to hang forever
  pub async fn drain_events(&mut self) -> Result<(), ReplicationClosed> {
        tracing::debug!("drain_events");

        let event = self.rx_repl.recv().await.ok_or(ReplicationClosed {})?;   <-- never returns

The change doesn't make any existing tests fail.

Thank you for reporting this issue in detail and proposing a fix.
What's the version of openraft were you using? I'll check if the issue has been resolved in the main branch.
With the latest main branch, if there is a pending action, drain_events will return immediately:
https://github.com/datafuselabs/openraft/blob/5da9594d3658e5d1637d8e0a896f6724fdc918f9/openraft/src/replication/mod.rs#L508-L518
And RaftCore will periodically send an heartbeat event to ReplicationCore to wake up it thus self.rx_repl.recv() should not block for ever.

I was unable to reproduce the issue with a test case. Could you assist me in confirming that the steps in this test align with the steps in your situation:

#834

And with export RUST_LOG=debug, the testing script will output debug level logs, which may help on tracing this issue.

I was on a previous version of main.   I'll try again with this updated code and see if this resolves it.  My version definitely doesn't have that if statement.

The updated main branch resolves this issue.

I was on a previous version of main. I'll try again with this updated code and see if this resolves it. My version definitely doesn't have that if statement.

Right. I found this bug and fixed it after pushing the backoff to github. :(


Erratic behaviour

Describe the bug
When using a Virtualizer with a list index component to jump to a specific point within the list, scrolling upwards really quickly after loading makes the scrollbar jitter. It continuously calls range change event handler until it reaches start index 0.
To Reproduce
Video: https://photos.app.goo.gl/j9SXEJGUyirVuCyY7
Expected behavior
It should just load the previous items once and not loop all the way back to 0
Platform:

OS: MacOS
Browser: Electron
Version of this package: 0.33.3
Version of framework: vue 3.4.27

Additional context
I'm trying to implement a virtual list that supports a list index component used for jumping to a specific index. Regular horizontal scrolling from the start of the list until the end works perfect.
After using the list index to jump to a specific offset, scrolling downwards to load higher index items works fine too. However, when scrolling upwards extremely fast seems to create a state where the scrollbar is stuck and a update loop is triggered which loads all the items until index 0 is reached.
I've tried using a normal VList instead of a Virtualizer (with scroll-ref) but that had the same effect. I've based my implementation on the feed example
Simplified usage of the component:
 <Virtualizer
      v-slot="item"
      ref="virtualizer"
      :item-size="85"
      :data="list.items"
      :scroll-ref="scrollRef"
      :shifting="shifting"
      @range-change="onRangeChange"
    >
      <component
        v-if="item"
        :key="item.index"
        :item="item"
      />
    </Virtualizer>

Hi, could you make a minimal reproduction?

Hi @inokawa I've created an isolated electron app that's as close as possible to how the actual app functions. If possible, I'd like to share it privately. Could you let me know how I could do so?

I want to chime in and say I've also been experiencing this, and I have some theories on what's causing it.
When I trip the loader to load more, the load happens but the scroll has continued to move up during that same period (inertial scrolling?). Because I'm only appending 25 items to the head of the list, the visible range is immediately put back into the "go get more to load" state due to the upward momentum.
I have a really weird fix where i basically timeout the ability to load more for 1.5s, and after a mutation and a nextTick(), I move the scroll position back to where it should be (i mark the item that was at the top prior to when I started loading). This is... not great, because the scroll is still basically firing. So for end users, it kinda just feels like they are shoved back down and then it pops around.
@mrooding i think maybe you could be experiencing the same thing?

@WalrusSoup that's interesting. Even without this bug I noticed that the range change event handler was firing very often so I already introduced a debounce function with a 1000ms timeout.
Would you be able to share an isolated example of your solution?
@inokawa @WalrusSoup I've stripped the example app to the bare minimum of what my overall setup looks like: https://drive.google.com/file/d/1RiToR4mq0iitkQKbbg6vQ_DdDy7ubGEi/view?usp=sharing
To reproduce:

Install dependencies using pnpm install
Run the app using pnpm watch
Move your cursor to the right side of the window so that the list index appears
Click on one of the list index options in the middle or near the end of the list (e.g. L).
Try scrolling down and upwards

Thanks! I'll take a look.

Your application logic fetches new items in onRangeChange callback. Prepending items will change visible range so onRangeChange can be called infinitely if we don't have proper guard. So please consider adding any guard.

@inokawa thank you for the reply. What would a proper guard look like to you?

Hi @inokawa I'd appreciate your input on this one. Thanks again


Mac/Firefox trackpad scroll not working

I have the latest Mac OS and Firefox browser, the scroll bar is not responding while using the trackpad

Thanks for reporting. The scrollbar needs a lots of rework but we have other priorities right now. We'll tell you as soon as we start working on it, but for now I think it's best to use classic scrollbar.

@malexandre Fair enough, thank you for the update!

Scrollbar will soon be deprecated as we choose to use the browser scrollbar.


Make self-assignment possible of issues based on level.

We will add people by hand as contributors :-)


question about moving querier and connection related codes

In future release, will pggen move querier interface and all connection related code out of *.sql.go file? It looks kind of ugly if i have multiple .sql.go files

Which code would you want moved? In general, having code in different locations complicates the implementation and makes pggen less predictable to use.

it would be very convenient if
type Querier interface{},
type DBQuerier struct {}
type genericConn interface {} blocks and related new function as well as WithTx functions are moved to a separate go file. For example, sqlc separates them to to two different go file named {package name}.goandquerier.go. Maybe on pggen you can move these to a separate to something like pggen.goon the output directory. i believe this will makesql.go` file look a lot cleaner because it'll only contain query related implementations.

I understand it might look neater but it also means more generated files per directory. I've heard folks express preferences for both approaches. My preference is for 1 query file means 1 go file because it's predictable. Given that it's generated code, the less people need to think about it, the better.
I'm going to close this because:

It's not clearly better.
Adding an option to control output adds another flag which increases the testing burden. pggen code generation is already quite complex. I avoid adding flags wherever I can to reduce the number of ways pggen generates code.
pgx should probably define type genericConn interface {} but it doesn't so we included in every package. If pgx adds genericConn, I'm happy to use that instead.

If you feel strongly about this, you could probably hack up an awk script to do the transformation for you.


What file cannot be found?help

Traceback (most recent call last):
File "C:\Softwares\ComfyUI\ComfyUI-1214\memoAvatar\MemoAvatorl-oneky-T8\MemoAvatorl-oneky-T8\ComfyUI\custom_nodes\ComfyUI-IF_MemoAvatar\IF_MemoAvatar.py", line 126, in generate
resampled_path = resample_audio(temp_audio, resampled_path)
File "C:\Softwares\ComfyUI\ComfyUI-1214\memoAvatar\MemoAvatorl-oneky-T8\MemoAvatorl-oneky-T8\ComfyUI\custom_nodes\ComfyUI-IF_MemoAvatar\memo\utils\audio_utils.py", line 27, in resample_audio
p = subprocess.Popen(
File "C:\Softwares\ComfyUI\ComfyUI-1214\memoAvatar\MemoAvatorl-oneky-T8\MemoAvatorl-oneky-T8\ComfyUI\Python\lib\subprocess.py", line 971, in init
self._execute_child(args, executable, preexec_fn, close_fds,
File "C:\Softwares\ComfyUI\ComfyUI-1214\memoAvatar\MemoAvatorl-oneky-T8\MemoAvatorl-oneky-T8\ComfyUI\Python\lib\subprocess.py", line 1456, in _execute_child
hp, ht, pid, tid = _winapi.CreateProcess(executable, args,
FileNotFoundError: [WinError 2] 系统找不到指定的文件。
[EasyUse] Save Text: No file details found. No file output.
Prompt executed in 10.97 seconds

you probably missed the ffmpg installation
this normally should have been taking care of on ther requirements.txt
activate your env and make sure to have the directory for ffmpg on the environment path
micromamba install ffmpeg -c conda-forge

Problem solved,I forgot to add the path,my bad,tk u so much!


Use pypy-2.6 on Travis

This is the latest version and will hopefully be updated in Travis soon (from pypy-2.5).
This PR makes a custom pyenv with pypy-2.6 when running the pypy tox env.
Fixes #261.

@nathanielmanistaatgoogle I finally got the magical incantation right after two dumb mistakes

Using TOXENV (copy-pasta) instead of TOX_ENV
Running the env (tox -e ${TOX_ENV}) before patching the pypy version instead of after

Anyhow we should get this merged ASAP so the build can go green (and other PRs will pass).

Sorry for the delay in reviewing - was in a meeting.
This smells like a temporary workaround until Travis sorts itself out - is that the case? If so, should there be TODOs in the content of these commits, or issues filed?

Yes thanks for the reminder. #266 filed.


Fix wrong translation

fix issue #2454
update translate that make misunderstanding.

Update translation on Crownin. PR close.

Update translation on Crownin. PR close.


Is it possible to crack with only the nether and end?

Not sure where else to ask this, but I'm trying to crack the seed of a server, but it has an anti-Xray plugin which I'm pretty sure entirely breaks the seed finding. Since it doesn't affect the end or nether, is it possible to use only those dimensions?

just turn off emerald ore then do /seed data clear and start exploring world, then go to end to get pillars
you can also do
turn off emerald ore
turn off mod
relog
turn on mod
start exploring world
when you have high amount of bits go to end to get pillars


Localized GetThingsDone

locale.ini is missing. Do you forget it in your commit ?
Plus, you have to declare ln10 as 2nd parameter of the define.
Currently, there is an error message in the browser console.

Unfortunately there is still a bug. The l10n parameter is declared at the wrong place.
I suggest you to use the browser debugger console. On Chrome press Ctrl+Shift+J (Windows / Linux) or Cmd+Opt+J (Mac).
Plus it's important to adapt the locale to the Sugarizer language settings. See for example what is done here: https://github.com/llaske/sugarizer/blob/master/activities/Clock.activity/js/loader.js#L15

There is a bug that l10n can´t read locale.ini

There is still a JavaScript error here https://github.com/llaske/sugarizer/pull/91/files#diff-dfd8ded96c059b5ff29b10a910b9c80fR10

Ive corrected the JS error, there are no errors left at the console :D, tell me if I have to do something more

No there is still an error in the console here https://github.com/llaske/sugarizer/pull/91/files#diff-2e7d59fafdfd04e74f0bacea342d2326R10

Ive solved the error, but there is other error with the Items, Im trying to solve it too


Migrations handling.

I know it's more of a general thing rather than a project specific question, but is there a "default/preferred way" of how database migrations (both data and schema) are gonna be handled? What about rolling back? I'm not looking for a specific answer, but just in general a thoughts of how (if at all) it could be handled from mrsk point of view.

The best way to handle this is for migrations to roll out as part of feature flags. So deploy need version with new stuff behind a flag. Run migrations as an exec. Validate all is well. Remove flag.
But you can do whatever you like, really. MRSK doesn't take a position any which way. Just makes it easy to kick off migrations with exec.


StreamWriter API revamp: access to ByteBufferAllocator

Once we revamp the StreamWriter API (see also #194), we should have StreamWriter give the user access to a ByteBufferAllocator.

marking 1.2.0 for now, this is not a blocker though so we can move to 1.3.0


Dashed line plugin can't figure out the dashes when the points are very close together

We've known about this for a while with drawing lines, especially as we start to zoom out:

I think this is also what's causing our point halo dashed lines to just become solid circles:
(a 20-gon drawn with a 12px radius)
new DashLine(this.halo, HALO_STYLE).drawCircle(0, 0, 12, 20);

Adding an extra graphics.setLineStyle() right before we start the drawing seems to have fixed the problem.
No idea why. 😆


Bug fixes

Purpose
Fixes issues #7 , #22, #61, #62 , #66
Changes
Fixes issues #7 , #22, #61, #62 , #66
Checklist

[x] My code follows the style of this project.
[x] The code compiles without warnings.
[x] I have performed a self-review of the changes.
[x] I have documented my code, in particular the intent of the
hard-to-understand areas.
[x] (If necessary) I have updated the CHANGELOG. Assumed not necessary since this is bug fix PR.

CLA acceptance
By submitting the contribution I accept the terms and conditions of the
Contributor License Agreement v1.0

link: https://developers.concordium.com/CLAs/Contributor-License-Agreement-v1.0.pdf

[x] I accept the above linked CLA.

Can you please update the CHANGELOGs and the version number of frontend and backend as well please?

Yes Surely,
Its done

@abizjak  : code to fix #66 has been removed

@abizjak : code to fix #66 has been removed

Great, thanks.

@parv0888 have you udpated the version number here already?
Can you merge this after doing so?


Not reseending images

Hey, could you add so that it will repost completly everything from the read channel? Including pictures.

Check if you sendAttachments is set as true in settings.json


Unable to override the Table Checkbox theme

https://github.com/react-toolbox/react-toolbox/blob/dev/components/table/TableHead.js#L45-L49
https://github.com/react-toolbox/react-toolbox/blob/dev/components/table/TableRow.js#L38

oops, seems like I can do the trick on theme.checkboxCell


Added buttons to flip limits

Currently this looks like this:

@borkin @PennyQ - I was trying to find a clear but unobtrusive way to do this. Do you think this is intuitive?
Fixes #70

@astrofrog Yeah it's very clear to me except this icon  between max & min text box. What's it for?

@astrofroghttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_astrofrog&d=CwMCaQ&c=WO-RGvefibhHBZq3fL85hQ&r=PPKbA3gSrhZ0r0pFtkZLpCPOmU2uXS4VZkPr-isl_EQ&m=MESVxw8l7Om8Fp0GoXlBmrMJL4lAUgVAUogtfnSrX-Y&s=j_3JQg7hpyrBTImd5WfVYoEk0RmqbuOJYfsLR20yDUI&e= All looks good to me but I do agree with Penny that “<>” is not intuitive for “flip limits”…
Perhaps a double-headed arrow icon instead of <>?  Or put a word between the brackets like <-swap-> or <-flip->?
On Feb 25, 2016, at 3:36 PM, Penny Qian <notifications<EMAIL_ADDRESS>wrote:
@astrofroghttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_astrofrog&d=CwMCaQ&c=WO-RGvefibhHBZq3fL85hQ&r=PPKbA3gSrhZ0r0pFtkZLpCPOmU2uXS4VZkPr-isl_EQ&m=MESVxw8l7Om8Fp0GoXlBmrMJL4lAUgVAUogtfnSrX-Y&s=j_3JQg7hpyrBTImd5WfVYoEk0RmqbuOJYfsLR20yDUI&e= Yeah it's very clear to me except this icon [image] https://urldefense.proofpoint.com/v2/url?u=https-3A__cloud.githubusercontent.com_assets_13411839_13333477_48802722-2Ddbd5-2D11e5-2D874b-2D6d97780f60eb.png&d=CwMCaQ&c=WO-RGvefibhHBZq3fL85hQ&r=PPKbA3gSrhZ0r0pFtkZLpCPOmU2uXS4VZkPr-isl_EQ&m=MESVxw8l7Om8Fp0GoXlBmrMJL4lAUgVAUogtfnSrX-Y&s=iYtk-RUAs0-kQBp4_MhNSmvTmoY2N4r9Qn-uBrUpaHs&e=  between max & min text box. What's it for?
—
Reply to this email directly or view it on GitHubhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_glue-2Dviz_glue-2D3d-2Dviewer_pull_81-23issuecomment-2D188971555&d=CwMCaQ&c=WO-RGvefibhHBZq3fL85hQ&r=PPKbA3gSrhZ0r0pFtkZLpCPOmU2uXS4VZkPr-isl_EQ&m=MESVxw8l7Om8Fp0GoXlBmrMJL4lAUgVAUogtfnSrX-Y&s=dGSGlTzFd0YOYl4bUdg50Wo4oIT_r7ksfFUafftvpis&e=.

@borkin @PennyQ - what about this?

Ideally I'd prefer if it took up less space, but we'd need to make sure it's intuitive. Maybe there is a symbol/icon we can use?

This looks better, but I agree that a space-saving icon would be better…
Is there any generic text/symbol character we could use such as one of the following?
⇄
↔
⇔
On Feb 25, 2016, at 4:32 PM, Thomas Robitaille <notifications<EMAIL_ADDRESS>wrote:
Ideally I'd prefer if it took up less space, but we'd need to make sure it's intuitive. Maybe there is a symbol/icon we can use?
—
Reply to this email directly or view it on GitHubhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_glue-2Dviz_glue-2D3d-2Dviewer_pull_81-23issuecomment-2D188996962&d=CwMCaQ&c=WO-RGvefibhHBZq3fL85hQ&r=PPKbA3gSrhZ0r0pFtkZLpCPOmU2uXS4VZkPr-isl_EQ&m=P3_EO27IqyfdJ00L9ibe84qozJTRUt7MlOz5ZjhO0W8&s=lDZwG_VTmtHiS5sHqyms85tHoxSkYbW3n43s1goYEOw&e=.

@borkin - perfect, thanks for the suggestions! Does this look better?

Love it, looks good to me! :)  What do you think @PennyQhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_PennyQ&d=CwMCaQ&c=WO-RGvefibhHBZq3fL85hQ&r=PPKbA3gSrhZ0r0pFtkZLpCPOmU2uXS4VZkPr-isl_EQ&m=PeKU32xs9AoqJwEnasLkWSNBDR7IQSMNUaMoyrSoWsY&s=F-ObnBLWryxBZVyg9N3Qa-glRMFB2uW2rIOIwh0vQmw&e= ?
On Feb 25, 2016, at 4:44 PM, Thomas Robitaille <notifications<EMAIL_ADDRESS>wrote:
@borkinhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_borkin&d=CwMCaQ&c=WO-RGvefibhHBZq3fL85hQ&r=PPKbA3gSrhZ0r0pFtkZLpCPOmU2uXS4VZkPr-isl_EQ&m=zKjF3nxhqM6XettaQR1_xyo36N2lHg3k0gBks73ULJ4&s=vpRGDorMIXb3NhFb0rqEZsc1sDzPdmbOLxJw3wJhZks&e= - perfect, thanks for the suggestions! Does this look better?
[screen shot 2016-02-25 at 9 44 02 pm]https://urldefense.proofpoint.com/v2/url?u=https-3A__cloud.githubusercontent.com_assets_314716_13335428_fa9ff670-2Ddc08-2D11e5-2D9c40-2D77f6e72337b5.png&d=CwMCaQ&c=WO-RGvefibhHBZq3fL85hQ&r=PPKbA3gSrhZ0r0pFtkZLpCPOmU2uXS4VZkPr-isl_EQ&m=zKjF3nxhqM6XettaQR1_xyo36N2lHg3k0gBks73ULJ4&s=jzofm7zIMAtfhY745RKpp7pPpoetG4MqxHnqVgO0OKA&e=
—
Reply to this email directly or view it on GitHubhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_glue-2Dviz_glue-2D3d-2Dviewer_pull_81-23issuecomment-2D189000242&d=CwMCaQ&c=WO-RGvefibhHBZq3fL85hQ&r=PPKbA3gSrhZ0r0pFtkZLpCPOmU2uXS4VZkPr-isl_EQ&m=zKjF3nxhqM6XettaQR1_xyo36N2lHg3k0gBks73ULJ4&s=r4SvUQuAQVZ8ZnOE1nWlt9cr1DDjtnMOxL7PpMzJzC0&e=.

It looks good for me. I don't know why I always think it to be a button that we could click...


[v0.11] Changes to minimize exposure to security issues

cmd/agent/main.go

Static code analysis states that unsanitized usage of the --component-port flag can potentially lead to SSRF. In practice, this may be very hard to happen, given that the source of the flag is always an integer (taken from containerPort of a Pod). Anyways, this is switching that flag to an Integer to be on the safe side (and to prevent the warning from the static code analysis tool).

python/kserve

Run poetry update.
The main reason of the upgrade is a recent fix to the MSAL library to escape an unsafe string.
As an aside, this also moves away from CVE-202-4807, which is only applicable to Windows 64 platforms.

Additionally, this adds some more resiliency to openshift-ci runs.
Fixes #91
Testing instructions
A simple sanity check should be OK.
Checkout this PR:

Clone the repo: git clone https://github.com/opendatahub-io/kserve.git && cd kserve
Fetch the PR: git fetch origin pull/93/merge:pr-93
Checkout the code: git checkout pr-93

On a clean OpenShift cluster, and given you have the code of this PR checked out:

Deploy ServiceMesh. Run: test/scripts/openshift-ci/deploy.ossm.sh
Deploy Serverless. Run: test/scripts/openshift-ci/deploy.serverless.sh
Deploy KServe:

oc new-project kserve
oc label namespace kserve testing.kserve.io/add-to-mesh=true
kustomize build config/overlays/odh | \
  sed "s|kserve/storage-initializer:latest|quay.io/edgarhz/kserve-storage-initializer:security-updates-v011|" | \
  sed "s|kserve/agent:latest|quay.io/edgarhz/kserve-agent:security-updates-v011|" | \
  sed "s|kserve/router:latest|quay.io/edgarhz/kserve-router:security-updates-v011|" | \
  sed "s|kserve/kserve-controller:latest|quay.io/edgarhz/kserve-controller:security-updates-v011|" | \
  oc apply -f -

Deploy a test model:

oc new-project kserve-test
oc label namespace kserve-test testing.kserve.io/add-to-mesh=true
sed 's/ClusterServingRuntime/ServingRuntime/' config/runtimes/kserve-mlserver.yaml | \
  sed "s|mlserver:replace|docker.io/seldonio/mlserver:1.3.2|" | \
  oc apply -f -
cat <<EOF | oc apply -f -
apiVersion: "serving.kserve.io/v1beta1"
kind: "InferenceService"
metadata:
  name: "sklearn-irisv2"
  annotations:
    serving.knative.openshift.io/enablePassthrough: "true"
    sidecar.istio.io/inject: "true"
    sidecar.istio.io/rewriteAppHTTPProbers: "true"
spec:
  predictor:
    model:
      modelFormat:
        name: sklearn
      runtime: kserve-mlserver
      storageUri: "gs://seldon-models/sklearn/mms/lr_model"
EOF

Check that the model replies correctly:

ENDPOINT=$(oc get ksvc sklearn-irisv2-predictor -o jsonpath='{.status.url}')
curl -kv -H "Content-Type: application/json" -d '{"inputs": [{"name": "input-0","shape": [2, 4],"datatype": "FP32","data": [[6.8, 2.8, 4.8, 1.4],[6.0, 3.4, 4.5, 1.6]]}]}' $ENDPOINT/v2/models/sklearn-irisv2/infer

If you get a reply, it should all be running OK.
Notes
If you approve this PR, please, also approve #94

Looks like this is also good for upstream. why don't you send this pr to upstream?

Looks like this is also good for upstream. why don't you send this pr to upstream?

It is there: https://github.com/kserve/kserve/pull/3157

/lgtm

Ignoring CI failure for python 3.11 - it is a known issue in our fork
Merging.


Adding func to mount ceph/s3fs in ncn-power stage

IM:CRAYSAT-1582
Reviewer:Ryan
Adding a function to mount ceph and s3fs after checking the ceph health in ncn power stage
Summary and Scope
Summarize what has changed. Explain why this PR is necessary. What is impacted? Is this a new feature, critical bug fix, etc?
Is this change backwards incompatible, backwards compatible, or a backwards compatible bugfix?
Issues and Related PRs
List and characterize relationship to Jira/Github issues and other pull requests. Be sure to list dependencies.

Resolves CRAYSAT-1582

Testing
Tested on:

Tested on surtur and fanta system

Test description:
Ncn's were powered off and then powered on to validate the changes.
In the step: sat bootsys boot --stage ncn-power --ncn-boot-timeout 900
The output was observed during the process of above command.Once the Ceph was unfreezed and status is available, could observe mount of ceph and s3fs happening with the msg "INFO: Mounted Ceph and S3FS filesystems on ncn-m001 successfully."
To validate if it successfully mounted or not, first verified on the ncn-m001, then once the other master and worker nodes booted. Logged into the ncn's and verified if the mount points are reflected. they were  available as mount points. below are the output samples:
ncn-m001:/mnt/shiva # awk '{ if ($3 == "fuse.s3fs") { print $2; }}' /etc/fstab
/var/opt/cray/sdu/collection-mount
/var/opt/cray/config-data

ncn-m002:~ # awk '{ if ($3 == "fuse.s3fs") { print $2; }}' /etc/fstab
/var/opt/cray/sdu/collection-mount
/var/opt/cray/config-data
ncn-m002:~ # awk '{ if ($3 == "ceph") { print $2; }}' /etc/fstab
/etc/cray/upgrade/csm

This successfully confirms the working of the function added to automate the mount availability.
Risks and Mitigations
Low
Are there known issues with these changes? Any other special considerations?
no
Pull Request Checklist

[x] Version number(s) incremented, if applicable
[x] Copyrights updated
[x] License file intact
[x] Target branch correct
[x] CHANGELOG.md updated
[x] Testing is appropriate and complete, if applicable
[ ] HPC Product Announcement prepared, if applicable

Testing output on fanta system:
sat_bootsys_ncn-power_output.txt
A minor  correct of typo error is also addressed from freeze ceph to unfreeze ceph, as we unfreeze in that steo

fanta_system_testing_op.txt
Latest testing done on fanta post changes in the code

From your testing output:
ncn-m002:~ # awk '{ if ($3 == "fuse.s3fs") { print $2; }}' /etc/fstab
/var/opt/cray/sdu/collection-mount
/var/opt/cray/config-data
ncn-m002:~ # awk '{ if ($3 == "ceph") { print $2; }}' /etc/fstab
/etc/cray/upgrade/csm

This does not test whether these filesystems are mounted. The file /etc/fstab is just a configuration file that tells the node which filesystems should be mounted. It does not tell us which filesystems actually are mounted. To do that, use either mount or findmnt. For example:
ncn-m001:~ # findmnt --type ceph,fuse.s3fs | cat
TARGET                             SOURCE                                                         FSTYPE    OPTIONS
/var/opt/cray/sdu/collection-mount s3fs                                                           fuse.s3fs rw,relatime,user_id=0,group_id=0,allow_other
/var/opt/cray/config-data          s3fs                                                           fuse.s3fs rw,relatime,user_id=0,group_id=0,allow_other
/etc/cray/upgrade/csm<EMAIL_ADDRESS>ceph      rw,relatime,name=admin-tools,secret=<hidden>,ms_mode=prefer-crc,acl,mon_addr=<IP_ADDRESS>:3300/<IP_ADDRESS>:3300/<IP_ADDRESS>:3300

Test output post changes: https://gist.github.com/shivaprasad-metimath/ea0d890ee821856c9ed7fb86c63d99ea
Note: A cronjob existed to mount the ceph and s3fs for every minute. Hence had to disable and unmount. I have unmounted only s3fs to have a scenario covered as well

I created CRAYSAT-1872 for us to look into the cron job that auto-mounts ceph and s3fs filesystems.

Sure Ryan, Thanks for creating a ticket. will go ahead and merge the PR
we can work on the new ticket later.


Conflict between TOS and LICENSE

I'm confused by the Terms Of Service page, which states that you aren't allowed to modify this software:

Permission is granted to temporarily download one copy of the materials (information or software) on Sharpify Ltd's website for personal, non-commercial transitory viewing only. This is the grant of a licence, not a transfer of title, and under this licence you may not:
modify or copy the materials;
use the materials for any commercial purpose, or for any public display (commercial or non-commercial);
attempt to decompile or reverse engineer any software contained on Sharpify Ltd's website;
remove any copyright or other proprietary notations from the materials; or
transfer the materials to another person or "mirror" the materials on any other server.

While at the same time there's a LICENSE file which contains an MIT license, allowing most of the above.
I'm hoping that this still is an open source software and the text in TOS is a mistake.

It is open source and MIT is correct license.
I had quickly copied the terms of service from a different website. I will update that accordingly.


some codes style optimization

just some codes style optimization

@lidengke Please sign the Contributor License Agreement!
Click here to manually synchronize the status of this Pull Request.
See the FAQ for frequently asked questions.

@lidengke Thank you for signing the Contributor License Agreement!

this failed checkstyle. can you update it?

We're cleaning out the issue tracker and closing issues that we've not seen much demand to fix. Feel free to comment with additional justifications if you feel that this one should not have been closed.


S-LoRA with pytorch backend is very slow

Motivation
I using the scripts to benchmark s-lora with lmdeploy 0.2.6 on 2*A30. Firstly I only benchmark the base model lama2-13b-hf, the performance of pytorch backend is obviously lower than using turbormind backend, It is almost unusable.
Besides, if the tp=2, the utilization of gpu 0 is almost 0 but the gpu1 is always 100%, why?
# benchmark/benchmark_pytorch_engine_a100.sh
# https://github.com/InternLM/lmdeploy/blob/main/benchmark/profile_throughput.py
python3 profile_throughput.py data.csv /data/models/Llama-2-13b-hf/ \
--backend pytorch --tp 2 --concurrency 1 --cache-max-entry-count 0.5 \
--request_out_len 256 --top-k 3 --top-p 0.95 --temperature 0.0 --repetition-penalty 1.15 \
--num-prompts 10 --csv perf.csv

Related resources
No response
Additional context
No response

Any restful scripts offered to benchmark s-lora?

https://github.com/InternLM/lmdeploy/pull/1392 I have done some optimization, Please have a try.

#1392 I have done some optimization, Please have a try.

I have tested the newest version 0.3.0, the performance of the PyTorch backend is about 45% of the performance of the TurboMind backend.
bs = 1, base model is Llama-2-13b-hf, 2*A30,
the token qps is 20.4 using pytorch backend while the token qps is 49 using turbomind backend.
@grimoire

@grimoire Any processes can be shared about this issue?


Multiprocess writes using to_hdf5

After seeing @stuartarchibald's post on gitter, I was a bit curious how to_hdf5 actually worked and whether it would be viable to call from multiple processes.
Turns out to_hdf5 just calls store underneath the hood while holding the file open locally. The biggest issue of course is that the file is held open in write mode on the scheduler (meaning nothing else can write to the HDF5 file without corrupting it). Since the type of locking was not specified and store uses a threading.Lock by default, this is also incompatible with the multiprocessing use case (i.e. threading.Lock cannot be serialized/locked across processes). IOW the current implementation of to_hdf5 is not friendly even for locked parallel writes.
That said, it should be feasible to change to_hdf5's behavior to be more friendly for storage from multiple processes (though it will still need to be locked). In this case, it would still create the datasets initially (as it already does), but then would close the file. Instead of passing raw HDF5 Datasets as targets, a wrapper class would need to be used (to allow for pickling). The wrapper class would need to provide a __setitem__ method that would open the HDF5 file and write to the HDF5 Dataset at the selection specified in a process safe manner (probably with locket.lock_file). Ideally it would provide a __getitem__ method as well. Doing this should allow for HDF5 file to be written to in parallel. This assumes the filesystem is very robust and syncing changes between different nodes.
An alternative to this proposal that would avoid locking would be to have data serialized back to the scheduler, which then writes each piece to the HDF5 file as it arrives. This would avoid the overhead of the previous strategy (and any potential issues locking) by guaranteeing only one process ever opens the HDF5 file and keeps open until everything is written. This strategy would continue to work well for non-parallel use cases with arguably less overhead than is present now. The only thing to do before writing out all results would be to optimize the graphs since store would no longer be used.

Can this approach handle a Dask array that has np.nan in chunks?
The method mentioned here seems to not work for this case.

Ultimately working with Arrays of unknown shape would be difficult. How would you propose allocating an adequately sized HDF5 Dataset?

We could also consider an entirely different approach if we could guarantee there is a Client. Might provide some impetus to think about issue ( https://github.com/dask/dask/issues/3237 ). ;) Namely we could persist the Dask Array and then pass all the Futures to one Dask job, which could then write them out as they arrive. This would avoid having a file lock and would allow the HDF5 file to only be opened once by one worker. Other safety measures could be added here like writing to a temp file that gets moved to the right location only when it is done. Of course this wouldn't allow parallel writes; though, neither does the strategy in PR ( https://github.com/dask/dask/pull/3179 ).
cc @shoyer @jhamman

On a different note, took a look at what support for VDS was in h5py and it seems there has been an attempt to add Python support for this, but it is incomplete. That said, we could certainly explore a simple solution along these lines (an HDF5 file per chunk) as Dask can already help do the legwork for this sort of thing without too much trouble. This would allow parallel reading and writing as a direct consequence of using multiple files. Though keeping track of these files would come with some overhead.

From, my perspective, streaming computed arrays when using distributed to a single writer would be a nice compromise here. I'm not sure what machinery would be needed to make that happen but I can vouch for its potential application.
In terms of virtual datasets, I'm headed this way with xarray as well. In our case we can use save_mfdataset(datasets, paths) to enable parallel writing to separate files. datasets would be some partitioned version of a single xarray.Dataset made up of dask arrays.

It’s worth noting that Zarr has support for copying data into HDF5 files.
ref: http://zarr.readthedocs.io/en/stable/api/convenience.html#zarr.convenience.copy


Suggested solution to "Offloading The Work" doesn't seem correct

The suggested solution uses a Nan::To<Function> which, at least here, doesn't compile:
See link: https://github.com/workshopper/goingnative/blob/master/exercises/offloading_the_work/solution/myaddon.cc#L41
The compiler tells me this:
make: Entering directory `/mypath/going-native/myaddon/build'
  CXX(target) Release/obj.target/myaddon/myaddon.o
../myaddon.cc: In function ‘Nan::NAN_METHOD_RETURN_TYPE Delay(Nan::NAN_METHOD_ARGS_TYPE)’:
../myaddon.cc:42:27: error: no matching function for call to ‘To(v8::Local<v8::Value>)’
  Nan::To<Function>(info[1]);
                           ^
../myaddon.cc:42:27: note: candidate is:
In file included from ../node_modules/nan/nan.h:199:0,
                 from ../myaddon.cc:1:
../node_modules/nan/nan_converters.h:53:38: note: template<class T> typename Nan::imp::ToFactory<T>::return_t Nan::To(v8::Local<v8::Value>)
 typename imp::ToFactory<T>::return_t To(v8::Local<v8::Value> val) {
                                      ^
../node_modules/nan/nan_converters.h:53:38: note:   template argument deduction/substitution failed:
../node_modules/nan/nan_converters.h: In substitution of ‘template<class T> typename Nan::imp::ToFactory<T>::return_t Nan::To(v8::Local<v8::Value>) [with T = v8::Function]’:
../myaddon.cc:42:27:   required from here
../node_modules/nan/nan_converters.h:53:38: error: invalid use of incomplete type ‘struct Nan::imp::ToFactory<v8::Function>’
../node_modules/nan/nan_converters.h:18:29: error: declaration of ‘struct Nan::imp::ToFactory<v8::Function>’
 template<typename T> struct ToFactory;
                             ^

It would be nice to have an example on how we get a Nan::MaybeLocal<v8::Function> (or whatever) or how to check if a passed argument is a function.

just saw the PR (https://github.com/workshopper/goingnative/pull/67).


[Docs] Expose Meshery API Docs in the App

Current State
Currently, Meshery API docs are only available at https://docs.meshery.io/reference/rest-apis.
Desired State
Ensure Meshery API docs are also exposed inside of the Meshery App too through a new UI route /system/docs.
This would help Meshery users/contributors to readily explore different Meshery features.
Acceptance Test:

Expose a new UI route: /system/docs.
Add a new command that generates the docs and places the generated under /public/docs/index.html
Add backend support to serve the static file
Use redocly for the process
Expose a new menu item under the user avatar menu bar. 'API Docs`
Use the docs icon. (you may ask for it in the slack)
Add automation to ensure docs are updated on each release.
Ensure the automation process updates Meshery latest stable release version in the generated docs.

Contributor Guides and Handbook

📚 Instructions for contributing to documentation

Meshery documentation site and source

🛠 Meshery Build & Release Strategy
🎨 Wireframes and designs for Meshery UI in Figma (open invite)
🙋🏾🙋🏼 Questions: Discussion Forum and Community Slack

I would like to work on this

Hey @theBeginner86, can I work on this?

Hi @theBeginner86 I would like to work on this!

@yashlondhe90960 thanks for volunteering. Will you propose a solution here and once verified, let's get you assigned.

@theBeginner86 @leecalcote If no one is working on it. Can I work on it?

@leecalcote @theBeginner86 can i have this issue?

@theBeginner86 I think this issue is perfect for me as I was looking for some mid-level issues. Yes, the Meshery server runs perfectly.
So far my approach is-

Create a menu named API DOCS
Create an endpoint of system/docs pointed by API DOCS
Using Redocly I will connect it to the documentation Github source and generate the docs.
Link the docs to the endpoint.
Write a yaml file for automation.
I didn't dive deep into this issue as I'm working on another issue which I almost completed. If assigned I will start working on it tomorrow and share a more detailed approach. I think I can solve it.


Django-allauth-ui updates

Django-allauth-ui updated where it looks for some of these files. And you now need slippers as an app for this to work correctly.
There is also an error when trying to handle the new user signup verification email.
SSLCertVerificationError at /accounts/signup/
[SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: unable to get local issuer certificate (_ssl.c:1000)
I have not debugged this one yet though since I do not need that for my application.
Also sorry for black automatically reformatting some of the files, but also you should definitely use that extension.

Hmm, you might need to install your certs with Python. Can't say for sure.
Given that, I think this PR should be an issue instead.
[x] - Black is great. I use it for non-tutorials all the time. Courses tend to have as minimal of extensions as possible to keep things consistent between what is seen on video and what is in the reference.


Gulo-Laptop: ext4/btrfs migration

IT'S TIME
NO MORE NTFS
I finally have enough storage space to migrate everything.
Time to do the deed.

NTFS has caused kernel panics, screwed up permissions, and keeps breaking.
No more.


Download to CSV - value headers are offset

When using viz.csv() with the following data structure:
var data = [
{"year": "1989", "Hydrocarbon": "Oil", "value": 5007.5},
{"year": "1989", "Hydrocarbon": "Gas", "value": 905.7},
{"year": "1989", "Hydrocarbon": "Condensate", "value": 0},
{"year": "1990", "Hydrocarbon": "Oil", "value": 12347.8},
{"year": "1990", "Hydrocarbon": "Gas", "value": 2168.7},
{"year": "1990", "Hydrocarbon": "Condensate", "value": 0}]
I've noticed it's being exported to CSV incorrectly, with an additional header containing the text "data:text/csv:charset=utf-8" being included, which is offsetting the columns. When opened in excel:

Also, what's happening to my year values here? Can I prevent the auto formatting to long date/time format? I had to use strings for my year field in order to get sorting to work correctly in my stacked chart (issue #527 )

Which browser, OS, and application are you using? Do you see that "data:text/csv:charset=utf-8" if you open the csv in a simple text editor?
Also, the year values get transformed into javascript Date objects, and what you are seeing is the full date string. I can look into outputting the original year string.

I just realized something as I started digging, if you pass true to the function like this:
viz.csv(true);

Then it will return the original unformatted data :-)

Passing true fixed the date formatting, thanks!
I'm on Win 7 x64 Pro. I'm using d3plus within an embedded WPF webbrowser control for a C# app. Downloading to CSV works fine in standalone IE 11 and in the embedded browser (I think IE 10). Still get the "data:text/csv:charset=utf-8" header (even when opening in simple text editor). However the CSV button doesn't seem to do anything when I tested in Firefox 48.0.

Another thing I just noticed in IE - when I use the time slider and the CSV button together on the same chart, clicking/dragging the time slider will inadvertently trigger the CSV button.

@lcoursey thanks for the info! Can you post a code snippit of how you're using CSV and time slider together?


Table content not displayed

I'm using react: "^15.6.1" and react-table:"^6.5.3", tried to mock the below example, but the table data is not showing up i can only see the pagination boxes and nothing else, Please help
https://react-table.js.org/#/story/simple-table
Below is my code:
`import React, { Component } from "react";
import ReactTable from "react-table";
import "react-table/react-table.css";
export class ReactGridTable extends Component {
render() {
const data = [{ name: 'Tanner Linsley',  age: 26,   friend: {  name: 'Jason Maurer',  age: 23,  } },
{ name: 'Tanner Linsley', age: 26, friend: { name: 'Jason Maurer', age: 23, }
}];
const columns = [{
Header: 'Name',
accessor: 'name' // String-based value accessors!
}, {
Header: 'Age',
accessor: 'age',
Cell: props => {props.value} // Custom cell components!
}, {
id: 'friendName', // Required because our accessor is not a string
Header: 'Friend Name',
accessor: d => d.friend.name // Custom value accessors!
}, {
Header: props => Friend Age, // Custom header components!
accessor: 'friend.age'
}];
return (
  <div>  <ReactTable  data={data} columns={columns}/></div>
);

}
}`

Can you put your version of the code into codesandbox ?
There are some lines in there that don't look like valid Javascript.

@niteshjain132 I'm having the exact issue. @gary-menzel BTW the code sandbox seems to be broken for me. I keep getting the following error:

You need to reset your codesandbox cache - it was happening to me as well (but it does work if you use incognito mode - that is how I worked out it was a cache issue).
I suspect codesandbox had some glitch that happened recently - no clear explanation but the cache clear fixed it for me.

And I think I understand what you mean now. There is another "issue" that is still open where users are not seeing content in Chrome for some reason (I don't have that problem) and it may be related to a build environment issue (and not a react-table) issue.

Thanks @gary-menzel for the quick response. I suspect this is the reason. @niteshjain132 Can you post here a screenshot of the output (I want to see if you see the structure of the table but are missing only the content... to be 100% certain about the issue). Take a screenshot and copy the portion of the image you want and simply paste it in the editor. It will work correctly.

Thanks @kevinguard and @gary-menzel  for the analysis, I will post the snapshot shortly..

@gary-menzel I'm having this issue as well. Here is what my table looks like in chrome:

Here it is in firefox

For anyone still having this issue, please check the following FAQ and apply the recommended fix to your HTML doctype.....
https://github.com/react-tools/react-table/wiki/FAQ#my-reacttable-doesnt-seem-to-display-properly-on-browser-x---help

Thanks for the fix, works great now!

As this has been solved and answered in the FAQ and one other issue, I'll close it now.

@TWood67 Hi I got exactly same problem with you, where did you add  ? I tried added it to index.html, but not working, still not showing data.

@StevenZhangLC The proposed fixed was to solve the problem of the page navigation taking up all the space when using Chrome (yes, the recommendation is to add it at the top of your html page - before the <html> tag). The screenshot you have provided does not look like the same problem but rather looks like an issue with how you are rendering the columns. Are you able to demonstrate the issue with a small codesandbox sample and some dummy data?

@gary-menzel Thanks a lot for the fast reply!
I am not sure how to embed a codesandbox here, so I just take a screen shot form codesandbox.

As you can see, the top two rows are so narrow, and when the mouse hover through it, it changed colour, like has data in it, but it is blank.
And I added !DOCTYPE html to the top of html page. Same result.
Really appreciate for any help.

Firstly, you can just copy link from the codesandbox and past it anywhere you like (others can edit it but not save it if they don't own the sandbox - they have to fork it).
Secondly, you should check back in the documentation and look at some of the examples. Your column definitions are incomplete.
Header is for the text you want displayed - not for the field you want to show.
You need to provide an accessor to tell react-table what you want to display in the column.
Given you are new to react-table you should probably consider joining the #react-table Slack channel (there is a badge at the top of the react-table documentation page). The github issues are mainly for feature requests and bug reporting (they are not really monitored for questions about usage).

@gary-menzel Thank you so much Gary. It works now.

And thanks for your guide, now I get how to post codesandbox link here.
I do have Slack, and after your guide I joined the react-table channel, its real useful, thanks again.
After all, thanks for your patience. I learned a lot.

@gary-menzel , i am facing a similar issue but in safari browser. When i load the table in chrome, it displays all the data perfectly but when i load it in safari browser the header takes up all the space. I have attached the snippets for both browser.
safari browser snippet -

chrome browser snippet -


[cloud_firestore] Sending data to firestore is slow

We are planning to do a realtime application, We are able to integrate firestore in the app, but, sending data to firestore takes an average of 1.2 seconds. We have also checked this with the example app provided with the plugin in a good internet connection.
We have recorded some samples in the sheet attached (https://docs.google.com/spreadsheets/d/1oJBTTbF8654EiFy5whMztWLBSQ8mViRIuE2TLK_ThzA/edit#gid=0)
Steps to Reproduce
Build the example app provided with firestore.
Modify the sample data to this. So that we can calculate the delay.
 {
      'sentTime': DateTime.now(),
      'serverReceivedTime': FieldValue.serverTimestamp(),
 }

Expected behavior
We need the speed to be less than at least 100 milliseconds for the data to be received at the firestore end because the data deals with currency. The data will be very small.
Thanks

Hi @Ajaystefin
can you please provide your flutter doctor -v ,
your flutter run --verbose
and a reproducible minimal code sample.
Thank you

Without additional information, we are unfortunately not sure how to resolve this issue. We are therefore reluctantly going to close this bug for now. Please don't hesitate to comment on the bug if you have any more information for us; we will reopen it right away!
Thanks for your contribution.
Could everyone who still has this problem please file a new issue with the exact descriptions what happens, logs and the output of 'flutter doctor -v'  please.
All system setups can be slightly different so it's always better to open new issues and reference related issues.


The new website is too heavy.

That's it, the new website is too heavy compared with the previous one, may be caused by the vectorized (SVG) images used as background:

/svg/orb_docs.svg
/svg/documentation.svg

Can you elaborate a bit? It does not seem to have any difference for me.


fix(deps): update module github.com/azure/azure-sdk-for-go/sdk/azcore to v1.12.0

This PR contains the following updates:

Package
Type
Update
Change

github.com/Azure/azure-sdk-for-go/sdk/azcore
require
minor
v1.11.1 -> v1.12.0

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

ℹ Artifact update notice
File name: go.mod
In order to perform the update(s) described in the table above, Renovate ran the go get command, which resulted in the following additional change(s):

2 additional dependencies were updated

Details:

Package
Change

github.com/Azure/azure-sdk-for-go/sdk/internal
v1.5.2 -> v1.9.0

golang.org/x/net
v0.25.0 -> v0.26.0


[docs] Add outlined buttons to ButtonSizes  demo

outlined is also missing at the typescript definition files (ButtonClassKey)

@marcel-ernst Do you want to submit a pull-request to fix that? :)


Update chart coroot to 0.14.6

This PR contains the following updates:

Package
Update
Change

coroot
patch
0.14.4 -> 0.14.6

Release Notes

coroot/helm-charts (coroot)
v0.14.6
Compare Source
A monitoring and troubleshooting tool for microservice architectures.

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

Edited/Blocked Notification
Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.
You can manually request rebase by checking the rebase/retry box above.
⚠ Warning: custom changes will be lost.


[IT] Add Cover Synonyms

Add saracinesca and cler as synonyms for garage door.
cler is used a lot in northern Italy.

I don't understand why it does not pass CI....

It means "shutter"... I'm afraid it's a dialectal form, but it's so used here (in Milan) that it confused me.

Looks like another language (bulgarian) is blocking the test.
Please wait until it is resolved before merging.
Cler is not Italian, we're not allowing dialects, otherwise the Italian files would be long like an encyclopedia...

Looks like another language (bulgarian) is blocking the test. Please wait until it is resolved before merging.
Cler is not Italian, we're not allowing dialects, otherwise the Italian files would be long like an encyclopedia...

I agree.
thanks

As soon as I'm at home :)


docs: update url in cwgo Getting Started

What type of PR is this?

docs
What this PR does / why we need it (en: English/zh: Chinese):

en: update url in cwgo Getting Started
zh: 更新 cwgo Getting Started 中的 url
Which issue(s) this PR fixes:

中文的也要改下。

In another pr


⚠ Bofrost.at has degraded performance

In 34a78e1, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 2863 ms

Resolved: Bofrost.at performance has improved in 31257ae.


Google Home Color Issue

Whenever I tell the Google Assistant to change the color of my IKEA light bulbs, the Google Assistant tells me the lights bulbs aren't available, but the lights still change to the correct color.
I did not experience this issue when having these lights connected to the earlier home-assistant-matter-bridge version.
Everything else is working as expected, turning the lights on/off does not give this error, changing brightness is also working properly..

This is related to #208 and will be fixed today or tomorrow 🙂


Restore doc on volume backup and restore

Addresses https://github.com/docker/cli/pull/1063

Thank you @gbarr01!


modified for disalign

Motivation
Add Distribution Alignment algorithm for long-tailed recognition.
Modification
Add Distribution Alignment algorithm config files and implementation files.

[ ] configs/resnext/resnext50-32x4d_8xb32_in1k_imagenet_lt_cj.py: The first step, which add 'ColorJitter' for train_dataloader.
[ ] configs/resnext/resnext50-32x4d_8xb32_in1k_imagenet_lt_cj.py: The second step, which add 'ColorJitter' for train_dataloader, and apply Disalign head and GRWloss.
[ ] mmcls/models/losses/generized_re_weighting_loss.py
[ ] mmcls/models/heads/disalign_linear_head.py

Checklist
Before PR:

[ ] Pre-commit or other linting tools are used to fix the potential lint issues.
[ ] Bug fixes are fully covered by unit tests, the case that causes the bug should be added in the unit tests.
[ ] The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
[ ] The documentation has been modified accordingly, like docstring or example tutorials.

After PR:

[ ] If the modification has potential influence on downstream or other related projects, this PR should be tested with those projects, like MMDet or MMSeg.
[ ] CLA has been signed and all committers have signed the CLA in this PR.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


openssl enc with passcode doesn't decode on linux/windows if created on mac m1

Creating encrypted files on Mac with M1 chip and attempting to decode on Linux/Windows yields error 'bad decrypt'.

Could you please provide more details? The command line you use in both cases, for example

Also whether the password includes any Unicode codepoints/characters that are encoded differently under different normalization forms.

No unicode, just hex key (generated with openssl actually).
command to encypt/decrypt is,
openssl enc -aes-256-cbc -in input.enc -out output.txt
openssl enc -aes-256-cbc -d -in input.enc -out output.txt

What are the versions of the openssl on the Mac, Linux, Windows?

No response from the reporter. Closing.


Update wallet core and client-api-schema to work with exit format

yarn prepare and yarn test should work in wallet-core but not in browser-wallet or server-wallet. I couldn't see any easy way to preserve the types exported by wallet core, so unfortunately this change is breaking and more work will be needed to convert those packages too.
We cannot easily maintain the current SimpleGuarantee type because it does not have an amount field. In the exit format, guarantee allocations require an amount.
~Early feedback appreciated on the following design decision: the internal types in wallet core have optional fields. These fields are given default values when converting to (serializing) types for the wire or for the app. Although this seems kind of nasty, it leads to a smaller change set here and can be fixed later on.~ Turns out this wasn't too hard to fix now, in fact.

In favour of #3762


New method to send files in base64

Due to the new requirement to be able to generate invoices and that they can be shared or downloaded by the user. It is necessary to create a new bridge method since these invoices cannot be hosted anywhere. These files could be of any type (pdfs or zips).
Documentation:

Tech Analysis
Apps Spec

ShareBase64
shareBase64: ({ content: string, fileName: string }) => Promise<void>

Request → { type: "SHARE_BASE64", id: string, payload: { content: "base64 string", fileName: "fileName.ext" } }
Response → { type: "SHARE_BASE64", id: string }

Success response
Empty response.
Error response codes
400 → Bad request: If payload is null or there's any missing mandatory parameter.
500 → Internal Error: If an error occurred while processing the file

I would improve the example:
- Request → { type: "SHARE_BASE64", id: string, payload: { content: "base64 string", fileName?: "pdfname" } }
+ Request → { type: "SHARE_BASE64", id: string, payload: { content: "base64 string", fileName: "pdfname.pdf" } }
Response → { type: "SHARE_BASE64", id: string }

I guess the extension will come in the fileName right?
In addition, can fileName be null? I would force it as mandatory, wdyt?

I left it optional because for the SHARE method this filename field does not exist, and we are the ones who put "Document" as the file prefix, same with the extension.
But I dont have a strong opinion to let it mandatory and let web to put the extension, I just wanted to reuse all SHARE logic possible.

I would improve the example:
- Request → { type: "SHARE_BASE64", id: string, payload: { content: "base64 string", fileName?: "pdfname" } }
+ Request → { type: "SHARE_BASE64", id: string, payload: { content: "base64 string", fileName: "pdfname.pdf" } }
Response → { type: "SHARE_BASE64", id: string }

I guess the extension will come in the fileName right? In addition, can fileName be null? I would force it as mandatory, wdyt?

I left it optional because for the SHARE method this filename field does not exist, and we are the ones who put "Document" as the file prefix, same with the extension.
But I dont have a strong opinion to let it mandatory and let web to put the extension, I just wanted to reuse all SHARE logic possible.

I don't see the point in making this parameter optional. It implies that at the time of showing the modal Share if the filename is null we have to define a name for the file that we are going to share. I believe that this responsibility should come to us made from webapp and always receive a name with which we want to share the file.

I would improve the example:
- Request → { type: "SHARE_BASE64", id: string, payload: { content: "base64 string", fileName?: "pdfname" } }
+ Request → { type: "SHARE_BASE64", id: string, payload: { content: "base64 string", fileName: "pdfname.pdf" } }
Response → { type: "SHARE_BASE64", id: string }

I guess the extension will come in the fileName right? In addition, can fileName be null? I would force it as mandatory, wdyt?

I left it optional because for the SHARE method this filename field does not exist, and we are the ones who put "Document" as the file prefix, same with the extension.
But I dont have a strong opinion to let it mandatory and let web to put the extension, I just wanted to reuse all SHARE logic possible.

I don't see the point in making this parameter optional. It implies that at the time of showing the modal Share if the filename is null we have to define a name for the file that we are going to share. I believe that this responsibility should come to us made from webapp and always receive a name with which we want to share the file.

We agreed on making filename mandatory, modifying spec.

what is left to proceed with this?

Has this been considered? https://developer.mozilla.org/en-US/docs/Web/API/Web_Share_API

https://jira.tid.es/browse/WEB-1942


docs: use the Europa Rising blog post content for the docs.dagger.io new index page

Starting with CI/CD in your local dev is too abrupt, and there is a lot of great content on that blog post page that we should promote more 😉
cc @shykes

Good idea 👍

Duplicate of https://github.com/dagger/dagger/issues/1912, closing in favour of that one.