Merge proxy_init image with proxyv2 image

Part of https://github.com/istio/istio/issues/17518
Benefits:

1 less image to worry about
Only pull a single image. This means the pull will be finished during
the init, rather than during pod startup. This means Envoy can get ready
quicker and have less chance of the application starting up before it
and failing requests

Please provide a description for what this PR is for.
And to help us figure out who should review this PR, please
put an X in all the areas that this PR affects.
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure

@howardjohn: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

pilot-e2e-envoyv2-v1alpha3_istio
8524257ffcae467a8f28c068e55d17318e954689
link
/test pilot-e2e-envoyv2-v1alpha3_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

pilot-e2e-envoyv2-v1alpha3_istio
8524257ffcae467a8f28c068e55d17318e954689
link
/test pilot-e2e-envoyv2-v1alpha3_istio

e2e-bookInfoTests-envoyv2-v1alpha3_istio
8524257ffcae467a8f28c068e55d17318e954689
link
/test e2e-bookInfoTests-envoyv2-v1alpha3_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

pilot-e2e-envoyv2-v1alpha3_istio
8524257ffcae467a8f28c068e55d17318e954689
link
/test pilot-e2e-envoyv2-v1alpha3_istio

e2e-bookInfoTests-envoyv2-v1alpha3_istio
8524257ffcae467a8f28c068e55d17318e954689
link
/test e2e-bookInfoTests-envoyv2-v1alpha3_istio

e2e-mixer-no_auth_istio
8524257ffcae467a8f28c068e55d17318e954689
link
/test e2e-mixer-no_auth_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

pilot-e2e-envoyv2-v1alpha3_istio
8524257ffcae467a8f28c068e55d17318e954689
link
/test pilot-e2e-envoyv2-v1alpha3_istio

e2e-bookInfoTests-envoyv2-v1alpha3_istio
8524257ffcae467a8f28c068e55d17318e954689
link
/test e2e-bookInfoTests-envoyv2-v1alpha3_istio

e2e-mixer-no_auth_istio
8524257ffcae467a8f28c068e55d17318e954689
link
/test e2e-mixer-no_auth_istio

e2e-simpleTests_istio
8524257ffcae467a8f28c068e55d17318e954689
link
/test e2e-simpleTests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

pilot-e2e-envoyv2-v1alpha3_istio
8524257ffcae467a8f28c068e55d17318e954689
link
/test pilot-e2e-envoyv2-v1alpha3_istio

e2e-bookInfoTests-envoyv2-v1alpha3_istio
8524257ffcae467a8f28c068e55d17318e954689
link
/test e2e-bookInfoTests-envoyv2-v1alpha3_istio

e2e-mixer-no_auth_istio
8524257ffcae467a8f28c068e55d17318e954689
link
/test e2e-mixer-no_auth_istio

e2e-simpleTests_istio
8524257ffcae467a8f28c068e55d17318e954689
link
/test e2e-simpleTests_istio

e2e-simpleTests-distroless_istio
8524257ffcae467a8f28c068e55d17318e954689
link
/test e2e-simpleTests-distroless_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

pilot-e2e-envoyv2-v1alpha3_istio
8524257ffcae467a8f28c068e55d17318e954689
link
/test pilot-e2e-envoyv2-v1alpha3_istio

e2e-bookInfoTests-envoyv2-v1alpha3_istio
8524257ffcae467a8f28c068e55d17318e954689
link
/test e2e-bookInfoTests-envoyv2-v1alpha3_istio

e2e-mixer-no_auth_istio
8524257ffcae467a8f28c068e55d17318e954689
link
/test e2e-mixer-no_auth_istio

e2e-simpleTests_istio
8524257ffcae467a8f28c068e55d17318e954689
link
/test e2e-simpleTests_istio

e2e-simpleTests-distroless_istio
8524257ffcae467a8f28c068e55d17318e954689
link
/test e2e-simpleTests-distroless_istio

e2e-simpleTestsMinProfile_istio
8524257ffcae467a8f28c068e55d17318e954689
link
/test e2e-simpleTestsMinProfile_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

pilot-e2e-envoyv2-v1alpha3_istio
8524257ffcae467a8f28c068e55d17318e954689
link
/test pilot-e2e-envoyv2-v1alpha3_istio

e2e-bookInfoTests-envoyv2-v1alpha3_istio
8524257ffcae467a8f28c068e55d17318e954689
link
/test e2e-bookInfoTests-envoyv2-v1alpha3_istio

e2e-mixer-no_auth_istio
8524257ffcae467a8f28c068e55d17318e954689
link
/test e2e-mixer-no_auth_istio

e2e-simpleTests_istio
8524257ffcae467a8f28c068e55d17318e954689
link
/test e2e-simpleTests_istio

e2e-simpleTests-distroless_istio
8524257ffcae467a8f28c068e55d17318e954689
link
/test e2e-simpleTests-distroless_istio

e2e-simpleTestsMinProfile_istio
8524257ffcae467a8f28c068e55d17318e954689
link
/test e2e-simpleTestsMinProfile_istio

e2e-bookInfoTests-trustdomain_istio
8524257ffcae467a8f28c068e55d17318e954689
link
/test e2e-bookInfoTests-trustdomain_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

pilot-e2e-envoyv2-v1alpha3_istio
8524257ffcae467a8f28c068e55d17318e954689
link
/test pilot-e2e-envoyv2-v1alpha3_istio

e2e-bookInfoTests-envoyv2-v1alpha3_istio
8524257ffcae467a8f28c068e55d17318e954689
link
/test e2e-bookInfoTests-envoyv2-v1alpha3_istio

e2e-mixer-no_auth_istio
8524257ffcae467a8f28c068e55d17318e954689
link
/test e2e-mixer-no_auth_istio

e2e-simpleTests_istio
8524257ffcae467a8f28c068e55d17318e954689
link
/test e2e-simpleTests_istio

e2e-simpleTests-distroless_istio
8524257ffcae467a8f28c068e55d17318e954689
link
/test e2e-simpleTests-distroless_istio

e2e-simpleTestsMinProfile_istio
8524257ffcae467a8f28c068e55d17318e954689
link
/test e2e-simpleTestsMinProfile_istio

e2e-bookInfoTests-trustdomain_istio
8524257ffcae467a8f28c068e55d17318e954689
link
/test e2e-bookInfoTests-trustdomain_istio

e2e-simpleTests-cni_istio
8524257ffcae467a8f28c068e55d17318e954689
link
/test e2e-simpleTests-cni_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

pilot-e2e-envoyv2-v1alpha3_istio
8524257ffcae467a8f28c068e55d17318e954689
link
/test pilot-e2e-envoyv2-v1alpha3_istio

e2e-bookInfoTests-envoyv2-v1alpha3_istio
8524257ffcae467a8f28c068e55d17318e954689
link
/test e2e-bookInfoTests-envoyv2-v1alpha3_istio

e2e-mixer-no_auth_istio
8524257ffcae467a8f28c068e55d17318e954689
link
/test e2e-mixer-no_auth_istio

e2e-simpleTests_istio
8524257ffcae467a8f28c068e55d17318e954689
link
/test e2e-simpleTests_istio

e2e-simpleTests-distroless_istio
8524257ffcae467a8f28c068e55d17318e954689
link
/test e2e-simpleTests-distroless_istio

e2e-simpleTestsMinProfile_istio
8524257ffcae467a8f28c068e55d17318e954689
link
/test e2e-simpleTestsMinProfile_istio

e2e-bookInfoTests-trustdomain_istio
8524257ffcae467a8f28c068e55d17318e954689
link
/test e2e-bookInfoTests-trustdomain_istio

e2e-simpleTests-cni_istio
8524257ffcae467a8f28c068e55d17318e954689
link
/test e2e-simpleTests-cni_istio

e2e-dashboard_istio
8524257ffcae467a8f28c068e55d17318e954689
link
/test e2e-dashboard_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

pilot-e2e-envoyv2-v1alpha3_istio
8524257ffcae467a8f28c068e55d17318e954689
link
/test pilot-e2e-envoyv2-v1alpha3_istio

e2e-bookInfoTests-envoyv2-v1alpha3_istio
8524257ffcae467a8f28c068e55d17318e954689
link
/test e2e-bookInfoTests-envoyv2-v1alpha3_istio

e2e-mixer-no_auth_istio
8524257ffcae467a8f28c068e55d17318e954689
link
/test e2e-mixer-no_auth_istio

e2e-simpleTests_istio
8524257ffcae467a8f28c068e55d17318e954689
link
/test e2e-simpleTests_istio

e2e-simpleTests-distroless_istio
8524257ffcae467a8f28c068e55d17318e954689
link
/test e2e-simpleTests-distroless_istio

e2e-simpleTestsMinProfile_istio
8524257ffcae467a8f28c068e55d17318e954689
link
/test e2e-simpleTestsMinProfile_istio

e2e-bookInfoTests-trustdomain_istio
8524257ffcae467a8f28c068e55d17318e954689
link
/test e2e-bookInfoTests-trustdomain_istio

e2e-simpleTests-cni_istio
8524257ffcae467a8f28c068e55d17318e954689
link
/test e2e-simpleTests-cni_istio

e2e-dashboard_istio
8524257ffcae467a8f28c068e55d17318e954689
link
/test e2e-dashboard_istio

integ-telemetry-k8s-tests_istio
8524257ffcae467a8f28c068e55d17318e954689
link
/test integ-telemetry-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

pilot-e2e-envoyv2-v1alpha3_istio
8524257ffcae467a8f28c068e55d17318e954689
link
/test pilot-e2e-envoyv2-v1alpha3_istio

e2e-bookInfoTests-envoyv2-v1alpha3_istio
8524257ffcae467a8f28c068e55d17318e954689
link
/test e2e-bookInfoTests-envoyv2-v1alpha3_istio

e2e-mixer-no_auth_istio
8524257ffcae467a8f28c068e55d17318e954689
link
/test e2e-mixer-no_auth_istio

e2e-simpleTests_istio
8524257ffcae467a8f28c068e55d17318e954689
link
/test e2e-simpleTests_istio

e2e-simpleTests-distroless_istio
8524257ffcae467a8f28c068e55d17318e954689
link
/test e2e-simpleTests-distroless_istio

e2e-simpleTestsMinProfile_istio
8524257ffcae467a8f28c068e55d17318e954689
link
/test e2e-simpleTestsMinProfile_istio

e2e-bookInfoTests-trustdomain_istio
8524257ffcae467a8f28c068e55d17318e954689
link
/test e2e-bookInfoTests-trustdomain_istio

e2e-simpleTests-cni_istio
8524257ffcae467a8f28c068e55d17318e954689
link
/test e2e-simpleTests-cni_istio

e2e-dashboard_istio
8524257ffcae467a8f28c068e55d17318e954689
link
/test e2e-dashboard_istio

integ-telemetry-k8s-tests_istio
8524257ffcae467a8f28c068e55d17318e954689
link
/test integ-telemetry-k8s-tests_istio

integ-mixer-k8s-tests_istio
8524257ffcae467a8f28c068e55d17318e954689
link
/test integ-mixer-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

pilot-e2e-envoyv2-v1alpha3_istio
8524257ffcae467a8f28c068e55d17318e954689
link
/test pilot-e2e-envoyv2-v1alpha3_istio

e2e-bookInfoTests-envoyv2-v1alpha3_istio
8524257ffcae467a8f28c068e55d17318e954689
link
/test e2e-bookInfoTests-envoyv2-v1alpha3_istio

e2e-mixer-no_auth_istio
8524257ffcae467a8f28c068e55d17318e954689
link
/test e2e-mixer-no_auth_istio

e2e-simpleTests_istio
8524257ffcae467a8f28c068e55d17318e954689
link
/test e2e-simpleTests_istio

e2e-simpleTests-distroless_istio
8524257ffcae467a8f28c068e55d17318e954689
link
/test e2e-simpleTests-distroless_istio

e2e-simpleTestsMinProfile_istio
8524257ffcae467a8f28c068e55d17318e954689
link
/test e2e-simpleTestsMinProfile_istio

e2e-bookInfoTests-trustdomain_istio
8524257ffcae467a8f28c068e55d17318e954689
link
/test e2e-bookInfoTests-trustdomain_istio

e2e-simpleTests-cni_istio
8524257ffcae467a8f28c068e55d17318e954689
link
/test e2e-simpleTests-cni_istio

e2e-dashboard_istio
8524257ffcae467a8f28c068e55d17318e954689
link
/test e2e-dashboard_istio

integ-telemetry-k8s-tests_istio
8524257ffcae467a8f28c068e55d17318e954689
link
/test integ-telemetry-k8s-tests_istio

integ-mixer-k8s-tests_istio
8524257ffcae467a8f28c068e55d17318e954689
link
/test integ-mixer-k8s-tests_istio

integ-pilot-k8s-tests_istio
8524257ffcae467a8f28c068e55d17318e954689
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

pilot-e2e-envoyv2-v1alpha3_istio
8524257ffcae467a8f28c068e55d17318e954689
link
/test pilot-e2e-envoyv2-v1alpha3_istio

e2e-bookInfoTests-envoyv2-v1alpha3_istio
8524257ffcae467a8f28c068e55d17318e954689
link
/test e2e-bookInfoTests-envoyv2-v1alpha3_istio

e2e-mixer-no_auth_istio
8524257ffcae467a8f28c068e55d17318e954689
link
/test e2e-mixer-no_auth_istio

e2e-simpleTests-distroless_istio
8524257ffcae467a8f28c068e55d17318e954689
link
/test e2e-simpleTests-distroless_istio

e2e-bookInfoTests-trustdomain_istio
8524257ffcae467a8f28c068e55d17318e954689
link
/test e2e-bookInfoTests-trustdomain_istio

e2e-simpleTests-cni_istio
8524257ffcae467a8f28c068e55d17318e954689
link
/test e2e-simpleTests-cni_istio

e2e-dashboard_istio
8524257ffcae467a8f28c068e55d17318e954689
link
/test e2e-dashboard_istio

integ-telemetry-k8s-tests_istio
8524257ffcae467a8f28c068e55d17318e954689
link
/test integ-telemetry-k8s-tests_istio

integ-mixer-k8s-tests_istio
8524257ffcae467a8f28c068e55d17318e954689
link
/test integ-mixer-k8s-tests_istio

integ-pilot-k8s-tests_istio
8524257ffcae467a8f28c068e55d17318e954689
link
/test integ-pilot-k8s-tests_istio

e2e-simpleTests_istio
6aaad595252c3ea548d20cf54131a15c164f3bad
link
/test e2e-simpleTests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

pilot-e2e-envoyv2-v1alpha3_istio
8524257ffcae467a8f28c068e55d17318e954689
link
/test pilot-e2e-envoyv2-v1alpha3_istio

e2e-bookInfoTests-envoyv2-v1alpha3_istio
8524257ffcae467a8f28c068e55d17318e954689
link
/test e2e-bookInfoTests-envoyv2-v1alpha3_istio

e2e-mixer-no_auth_istio
8524257ffcae467a8f28c068e55d17318e954689
link
/test e2e-mixer-no_auth_istio

e2e-bookInfoTests-trustdomain_istio
8524257ffcae467a8f28c068e55d17318e954689
link
/test e2e-bookInfoTests-trustdomain_istio

e2e-simpleTests-cni_istio
8524257ffcae467a8f28c068e55d17318e954689
link
/test e2e-simpleTests-cni_istio

e2e-dashboard_istio
8524257ffcae467a8f28c068e55d17318e954689
link
/test e2e-dashboard_istio

integ-telemetry-k8s-tests_istio
8524257ffcae467a8f28c068e55d17318e954689
link
/test integ-telemetry-k8s-tests_istio

integ-mixer-k8s-tests_istio
8524257ffcae467a8f28c068e55d17318e954689
link
/test integ-mixer-k8s-tests_istio

integ-pilot-k8s-tests_istio
8524257ffcae467a8f28c068e55d17318e954689
link
/test integ-pilot-k8s-tests_istio

e2e-simpleTests_istio
6aaad595252c3ea548d20cf54131a15c164f3bad
link
/test e2e-simpleTests_istio

e2e-simpleTests-distroless_istio
6aaad595252c3ea548d20cf54131a15c164f3bad
link
/test e2e-simpleTests-distroless_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

pilot-e2e-envoyv2-v1alpha3_istio
8524257ffcae467a8f28c068e55d17318e954689
link
/test pilot-e2e-envoyv2-v1alpha3_istio

e2e-bookInfoTests-envoyv2-v1alpha3_istio
8524257ffcae467a8f28c068e55d17318e954689
link
/test e2e-bookInfoTests-envoyv2-v1alpha3_istio

e2e-mixer-no_auth_istio
8524257ffcae467a8f28c068e55d17318e954689
link
/test e2e-mixer-no_auth_istio

e2e-dashboard_istio
8524257ffcae467a8f28c068e55d17318e954689
link
/test e2e-dashboard_istio

integ-telemetry-k8s-tests_istio
8524257ffcae467a8f28c068e55d17318e954689
link
/test integ-telemetry-k8s-tests_istio

integ-mixer-k8s-tests_istio
8524257ffcae467a8f28c068e55d17318e954689
link
/test integ-mixer-k8s-tests_istio

integ-pilot-k8s-tests_istio
8524257ffcae467a8f28c068e55d17318e954689
link
/test integ-pilot-k8s-tests_istio

e2e-simpleTests_istio
6aaad595252c3ea548d20cf54131a15c164f3bad
link
/test e2e-simpleTests_istio

e2e-simpleTests-distroless_istio
6aaad595252c3ea548d20cf54131a15c164f3bad
link
/test e2e-simpleTests-distroless_istio

e2e-bookInfoTests-trustdomain_istio
6aaad595252c3ea548d20cf54131a15c164f3bad
link
/test e2e-bookInfoTests-trustdomain_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

pilot-e2e-envoyv2-v1alpha3_istio
8524257ffcae467a8f28c068e55d17318e954689
link
/test pilot-e2e-envoyv2-v1alpha3_istio

e2e-mixer-no_auth_istio
8524257ffcae467a8f28c068e55d17318e954689
link
/test e2e-mixer-no_auth_istio

e2e-dashboard_istio
8524257ffcae467a8f28c068e55d17318e954689
link
/test e2e-dashboard_istio

integ-telemetry-k8s-tests_istio
8524257ffcae467a8f28c068e55d17318e954689
link
/test integ-telemetry-k8s-tests_istio

integ-mixer-k8s-tests_istio
8524257ffcae467a8f28c068e55d17318e954689
link
/test integ-mixer-k8s-tests_istio

integ-pilot-k8s-tests_istio
8524257ffcae467a8f28c068e55d17318e954689
link
/test integ-pilot-k8s-tests_istio

e2e-simpleTests_istio
6aaad595252c3ea548d20cf54131a15c164f3bad
link
/test e2e-simpleTests_istio

e2e-simpleTests-distroless_istio
6aaad595252c3ea548d20cf54131a15c164f3bad
link
/test e2e-simpleTests-distroless_istio

e2e-bookInfoTests-trustdomain_istio
6aaad595252c3ea548d20cf54131a15c164f3bad
link
/test e2e-bookInfoTests-trustdomain_istio

e2e-bookInfoTests-envoyv2-v1alpha3_istio
6aaad595252c3ea548d20cf54131a15c164f3bad
link
/test e2e-bookInfoTests-envoyv2-v1alpha3_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

pilot-e2e-envoyv2-v1alpha3_istio
8524257ffcae467a8f28c068e55d17318e954689
link
/test pilot-e2e-envoyv2-v1alpha3_istio

e2e-mixer-no_auth_istio
8524257ffcae467a8f28c068e55d17318e954689
link
/test e2e-mixer-no_auth_istio

e2e-dashboard_istio
8524257ffcae467a8f28c068e55d17318e954689
link
/test e2e-dashboard_istio

integ-telemetry-k8s-tests_istio
8524257ffcae467a8f28c068e55d17318e954689
link
/test integ-telemetry-k8s-tests_istio

integ-mixer-k8s-tests_istio
8524257ffcae467a8f28c068e55d17318e954689
link
/test integ-mixer-k8s-tests_istio

integ-pilot-k8s-tests_istio
8524257ffcae467a8f28c068e55d17318e954689
link
/test integ-pilot-k8s-tests_istio

e2e-simpleTests_istio
6aaad595252c3ea548d20cf54131a15c164f3bad
link
/test e2e-simpleTests_istio

e2e-simpleTests-distroless_istio
6aaad595252c3ea548d20cf54131a15c164f3bad
link
/test e2e-simpleTests-distroless_istio

e2e-bookInfoTests-trustdomain_istio
6aaad595252c3ea548d20cf54131a15c164f3bad
link
/test e2e-bookInfoTests-trustdomain_istio

e2e-bookInfoTests-envoyv2-v1alpha3_istio
6aaad595252c3ea548d20cf54131a15c164f3bad
link
/test e2e-bookInfoTests-envoyv2-v1alpha3_istio

integ-istioctl-k8s-tests_istio
6aaad595252c3ea548d20cf54131a15c164f3bad
link
/test integ-istioctl-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

pilot-e2e-envoyv2-v1alpha3_istio
8524257ffcae467a8f28c068e55d17318e954689
link
/test pilot-e2e-envoyv2-v1alpha3_istio

e2e-mixer-no_auth_istio
8524257ffcae467a8f28c068e55d17318e954689
link
/test e2e-mixer-no_auth_istio

integ-telemetry-k8s-tests_istio
8524257ffcae467a8f28c068e55d17318e954689
link
/test integ-telemetry-k8s-tests_istio

integ-mixer-k8s-tests_istio
8524257ffcae467a8f28c068e55d17318e954689
link
/test integ-mixer-k8s-tests_istio

integ-pilot-k8s-tests_istio
8524257ffcae467a8f28c068e55d17318e954689
link
/test integ-pilot-k8s-tests_istio

e2e-simpleTests_istio
6aaad595252c3ea548d20cf54131a15c164f3bad
link
/test e2e-simpleTests_istio

e2e-simpleTests-distroless_istio
6aaad595252c3ea548d20cf54131a15c164f3bad
link
/test e2e-simpleTests-distroless_istio

e2e-bookInfoTests-trustdomain_istio
6aaad595252c3ea548d20cf54131a15c164f3bad
link
/test e2e-bookInfoTests-trustdomain_istio

e2e-bookInfoTests-envoyv2-v1alpha3_istio
6aaad595252c3ea548d20cf54131a15c164f3bad
link
/test e2e-bookInfoTests-envoyv2-v1alpha3_istio

integ-istioctl-k8s-tests_istio
6aaad595252c3ea548d20cf54131a15c164f3bad
link
/test integ-istioctl-k8s-tests_istio

e2e-dashboard_istio
6aaad595252c3ea548d20cf54131a15c164f3bad
link
/test e2e-dashboard_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

pilot-e2e-envoyv2-v1alpha3_istio
8524257ffcae467a8f28c068e55d17318e954689
link
/test pilot-e2e-envoyv2-v1alpha3_istio

integ-telemetry-k8s-tests_istio
8524257ffcae467a8f28c068e55d17318e954689
link
/test integ-telemetry-k8s-tests_istio

integ-mixer-k8s-tests_istio
8524257ffcae467a8f28c068e55d17318e954689
link
/test integ-mixer-k8s-tests_istio

integ-pilot-k8s-tests_istio
8524257ffcae467a8f28c068e55d17318e954689
link
/test integ-pilot-k8s-tests_istio

e2e-simpleTests_istio
6aaad595252c3ea548d20cf54131a15c164f3bad
link
/test e2e-simpleTests_istio

e2e-simpleTests-distroless_istio
6aaad595252c3ea548d20cf54131a15c164f3bad
link
/test e2e-simpleTests-distroless_istio

e2e-bookInfoTests-trustdomain_istio
6aaad595252c3ea548d20cf54131a15c164f3bad
link
/test e2e-bookInfoTests-trustdomain_istio

e2e-bookInfoTests-envoyv2-v1alpha3_istio
6aaad595252c3ea548d20cf54131a15c164f3bad
link
/test e2e-bookInfoTests-envoyv2-v1alpha3_istio

integ-istioctl-k8s-tests_istio
6aaad595252c3ea548d20cf54131a15c164f3bad
link
/test integ-istioctl-k8s-tests_istio

e2e-dashboard_istio
6aaad595252c3ea548d20cf54131a15c164f3bad
link
/test e2e-dashboard_istio

e2e-mixer-no_auth_istio
6aaad595252c3ea548d20cf54131a15c164f3bad
link
/test e2e-mixer-no_auth_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

pilot-e2e-envoyv2-v1alpha3_istio
8524257ffcae467a8f28c068e55d17318e954689
link
/test pilot-e2e-envoyv2-v1alpha3_istio

integ-mixer-k8s-tests_istio
8524257ffcae467a8f28c068e55d17318e954689
link
/test integ-mixer-k8s-tests_istio

integ-pilot-k8s-tests_istio
8524257ffcae467a8f28c068e55d17318e954689
link
/test integ-pilot-k8s-tests_istio

e2e-simpleTests_istio
6aaad595252c3ea548d20cf54131a15c164f3bad
link
/test e2e-simpleTests_istio

e2e-simpleTests-distroless_istio
6aaad595252c3ea548d20cf54131a15c164f3bad
link
/test e2e-simpleTests-distroless_istio

e2e-bookInfoTests-trustdomain_istio
6aaad595252c3ea548d20cf54131a15c164f3bad
link
/test e2e-bookInfoTests-trustdomain_istio

e2e-bookInfoTests-envoyv2-v1alpha3_istio
6aaad595252c3ea548d20cf54131a15c164f3bad
link
/test e2e-bookInfoTests-envoyv2-v1alpha3_istio

integ-istioctl-k8s-tests_istio
6aaad595252c3ea548d20cf54131a15c164f3bad
link
/test integ-istioctl-k8s-tests_istio

e2e-dashboard_istio
6aaad595252c3ea548d20cf54131a15c164f3bad
link
/test e2e-dashboard_istio

e2e-mixer-no_auth_istio
6aaad595252c3ea548d20cf54131a15c164f3bad
link
/test e2e-mixer-no_auth_istio

integ-telemetry-k8s-tests_istio
6aaad595252c3ea548d20cf54131a15c164f3bad
link
/test integ-telemetry-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

pilot-e2e-envoyv2-v1alpha3_istio
8524257ffcae467a8f28c068e55d17318e954689
link
/test pilot-e2e-envoyv2-v1alpha3_istio

integ-pilot-k8s-tests_istio
8524257ffcae467a8f28c068e55d17318e954689
link
/test integ-pilot-k8s-tests_istio

e2e-simpleTests_istio
6aaad595252c3ea548d20cf54131a15c164f3bad
link
/test e2e-simpleTests_istio

e2e-simpleTests-distroless_istio
6aaad595252c3ea548d20cf54131a15c164f3bad
link
/test e2e-simpleTests-distroless_istio

e2e-bookInfoTests-trustdomain_istio
6aaad595252c3ea548d20cf54131a15c164f3bad
link
/test e2e-bookInfoTests-trustdomain_istio

e2e-bookInfoTests-envoyv2-v1alpha3_istio
6aaad595252c3ea548d20cf54131a15c164f3bad
link
/test e2e-bookInfoTests-envoyv2-v1alpha3_istio

integ-istioctl-k8s-tests_istio
6aaad595252c3ea548d20cf54131a15c164f3bad
link
/test integ-istioctl-k8s-tests_istio

e2e-dashboard_istio
6aaad595252c3ea548d20cf54131a15c164f3bad
link
/test e2e-dashboard_istio

e2e-mixer-no_auth_istio
6aaad595252c3ea548d20cf54131a15c164f3bad
link
/test e2e-mixer-no_auth_istio

integ-telemetry-k8s-tests_istio
6aaad595252c3ea548d20cf54131a15c164f3bad
link
/test integ-telemetry-k8s-tests_istio

integ-mixer-k8s-tests_istio
6aaad595252c3ea548d20cf54131a15c164f3bad
link
/test integ-mixer-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

pilot-e2e-envoyv2-v1alpha3_istio
8524257ffcae467a8f28c068e55d17318e954689
link
/test pilot-e2e-envoyv2-v1alpha3_istio

integ-pilot-k8s-tests_istio
8524257ffcae467a8f28c068e55d17318e954689
link
/test integ-pilot-k8s-tests_istio

e2e-simpleTests_istio
6aaad595252c3ea548d20cf54131a15c164f3bad
link
/test e2e-simpleTests_istio

e2e-simpleTests-distroless_istio
6aaad595252c3ea548d20cf54131a15c164f3bad
link
/test e2e-simpleTests-distroless_istio

e2e-bookInfoTests-trustdomain_istio
6aaad595252c3ea548d20cf54131a15c164f3bad
link
/test e2e-bookInfoTests-trustdomain_istio

e2e-bookInfoTests-envoyv2-v1alpha3_istio
6aaad595252c3ea548d20cf54131a15c164f3bad
link
/test e2e-bookInfoTests-envoyv2-v1alpha3_istio

integ-istioctl-k8s-tests_istio
6aaad595252c3ea548d20cf54131a15c164f3bad
link
/test integ-istioctl-k8s-tests_istio

e2e-dashboard_istio
6aaad595252c3ea548d20cf54131a15c164f3bad
link
/test e2e-dashboard_istio

e2e-mixer-no_auth_istio
6aaad595252c3ea548d20cf54131a15c164f3bad
link
/test e2e-mixer-no_auth_istio

integ-telemetry-k8s-tests_istio
6aaad595252c3ea548d20cf54131a15c164f3bad
link
/test integ-telemetry-k8s-tests_istio

integ-mixer-k8s-tests_istio
6aaad595252c3ea548d20cf54131a15c164f3bad
link
/test integ-mixer-k8s-tests_istio

integ-framework-local-tests_istio
786831ac07994236bb382628e0010ca747a14c5f
link
/test integ-framework-local-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

pilot-e2e-envoyv2-v1alpha3_istio
8524257ffcae467a8f28c068e55d17318e954689
link
/test pilot-e2e-envoyv2-v1alpha3_istio

integ-pilot-k8s-tests_istio
8524257ffcae467a8f28c068e55d17318e954689
link
/test integ-pilot-k8s-tests_istio

e2e-simpleTests_istio
6aaad595252c3ea548d20cf54131a15c164f3bad
link
/test e2e-simpleTests_istio

e2e-simpleTests-distroless_istio
6aaad595252c3ea548d20cf54131a15c164f3bad
link
/test e2e-simpleTests-distroless_istio

e2e-bookInfoTests-trustdomain_istio
6aaad595252c3ea548d20cf54131a15c164f3bad
link
/test e2e-bookInfoTests-trustdomain_istio

e2e-bookInfoTests-envoyv2-v1alpha3_istio
6aaad595252c3ea548d20cf54131a15c164f3bad
link
/test e2e-bookInfoTests-envoyv2-v1alpha3_istio

integ-istioctl-k8s-tests_istio
6aaad595252c3ea548d20cf54131a15c164f3bad
link
/test integ-istioctl-k8s-tests_istio

e2e-dashboard_istio
6aaad595252c3ea548d20cf54131a15c164f3bad
link
/test e2e-dashboard_istio

e2e-mixer-no_auth_istio
6aaad595252c3ea548d20cf54131a15c164f3bad
link
/test e2e-mixer-no_auth_istio

integ-telemetry-k8s-tests_istio
6aaad595252c3ea548d20cf54131a15c164f3bad
link
/test integ-telemetry-k8s-tests_istio

integ-mixer-k8s-tests_istio
6aaad595252c3ea548d20cf54131a15c164f3bad
link
/test integ-mixer-k8s-tests_istio

integ-framework-local-tests_istio
786831ac07994236bb382628e0010ca747a14c5f
link
/test integ-framework-local-tests_istio

unit-tests_istio
786831ac07994236bb382628e0010ca747a14c5f
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

pilot-e2e-envoyv2-v1alpha3_istio
8524257ffcae467a8f28c068e55d17318e954689
link
/test pilot-e2e-envoyv2-v1alpha3_istio

integ-pilot-k8s-tests_istio
8524257ffcae467a8f28c068e55d17318e954689
link
/test integ-pilot-k8s-tests_istio

e2e-simpleTests_istio
6aaad595252c3ea548d20cf54131a15c164f3bad
link
/test e2e-simpleTests_istio

e2e-bookInfoTests-trustdomain_istio
6aaad595252c3ea548d20cf54131a15c164f3bad
link
/test e2e-bookInfoTests-trustdomain_istio

e2e-bookInfoTests-envoyv2-v1alpha3_istio
6aaad595252c3ea548d20cf54131a15c164f3bad
link
/test e2e-bookInfoTests-envoyv2-v1alpha3_istio

integ-istioctl-k8s-tests_istio
6aaad595252c3ea548d20cf54131a15c164f3bad
link
/test integ-istioctl-k8s-tests_istio

e2e-dashboard_istio
6aaad595252c3ea548d20cf54131a15c164f3bad
link
/test e2e-dashboard_istio

e2e-mixer-no_auth_istio
6aaad595252c3ea548d20cf54131a15c164f3bad
link
/test e2e-mixer-no_auth_istio

integ-telemetry-k8s-tests_istio
6aaad595252c3ea548d20cf54131a15c164f3bad
link
/test integ-telemetry-k8s-tests_istio

integ-mixer-k8s-tests_istio
6aaad595252c3ea548d20cf54131a15c164f3bad
link
/test integ-mixer-k8s-tests_istio

integ-framework-local-tests_istio
786831ac07994236bb382628e0010ca747a14c5f
link
/test integ-framework-local-tests_istio

unit-tests_istio
786831ac07994236bb382628e0010ca747a14c5f
link
/test unit-tests_istio

racetest_istio
786831ac07994236bb382628e0010ca747a14c5f
link
/test racetest_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

pilot-e2e-envoyv2-v1alpha3_istio
8524257ffcae467a8f28c068e55d17318e954689
link
/test pilot-e2e-envoyv2-v1alpha3_istio

integ-pilot-k8s-tests_istio
8524257ffcae467a8f28c068e55d17318e954689
link
/test integ-pilot-k8s-tests_istio

e2e-bookInfoTests-trustdomain_istio
6aaad595252c3ea548d20cf54131a15c164f3bad
link
/test e2e-bookInfoTests-trustdomain_istio

e2e-bookInfoTests-envoyv2-v1alpha3_istio
6aaad595252c3ea548d20cf54131a15c164f3bad
link
/test e2e-bookInfoTests-envoyv2-v1alpha3_istio

e2e-dashboard_istio
6aaad595252c3ea548d20cf54131a15c164f3bad
link
/test e2e-dashboard_istio

e2e-mixer-no_auth_istio
6aaad595252c3ea548d20cf54131a15c164f3bad
link
/test e2e-mixer-no_auth_istio

integ-telemetry-k8s-tests_istio
6aaad595252c3ea548d20cf54131a15c164f3bad
link
/test integ-telemetry-k8s-tests_istio

integ-mixer-k8s-tests_istio
6aaad595252c3ea548d20cf54131a15c164f3bad
link
/test integ-mixer-k8s-tests_istio

integ-framework-local-tests_istio
786831ac07994236bb382628e0010ca747a14c5f
link
/test integ-framework-local-tests_istio

unit-tests_istio
786831ac07994236bb382628e0010ca747a14c5f
link
/test unit-tests_istio

racetest_istio
786831ac07994236bb382628e0010ca747a14c5f
link
/test racetest_istio

codecov_istio
786831ac07994236bb382628e0010ca747a14c5f
link
/test codecov_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

unit-tests_istio
786831ac07994236bb382628e0010ca747a14c5f
link
/test unit-tests_istio

codecov_istio
786831ac07994236bb382628e0010ca747a14c5f
link
/test codecov_istio

racetest_istio
d3ccb8832b42dca40ef71256efc946cb9a1cc4b7
link
/test racetest_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

Thanks!! I meant to do that and completely forgot. See lack of tests issue
https://github.com/istio/istio/issues/17199
On Fri, Oct 4, 2019 at 4:22 PM Romain Lenglet<EMAIL_ADDRESS>wrote:

@rlenglet requested changes on this pull request.
This is great!
In tools/istio-docker.mk
https://github.com/istio/istio/pull/17615#discussion_r331715589:

@@ -127,6 +119,7 @@ docker.proxyv2: pilot/docker/envoy_pilot.yaml.tmpl
docker.proxyv2: pilot/docker/envoy_policy.yaml.tmpl
docker.proxyv2: tools/packaging/common/istio-iptables.sh
docker.proxyv2: pilot/docker/envoy_telemetry.yaml.tmpl
+docker.proxyv2: $(ISTIO_DOCKER)/istio-iptables

How about proxy_debug and proxytproxy? You modified the command line in
the injection template, so those images will now break.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/istio/istio/pull/17615?email_source=notifications&email_token=AAEYGXLOPNQFD36GWR7SG73QM7F33A5CNFSM4I5RWBN2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCG7WFIY#pullrequestreview-297755299,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAEYGXLC3XK5O4IIMK35733QM7F33ANCNFSM4I5RWBNQ
.

@howardjohn: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

pilot-multicluster-e2e_istio
3c0a6042074782563f23044bf69ebbdd8b761f94
link
/test pilot-multicluster-e2e_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

pilot-multicluster-e2e_istio
3c0a6042074782563f23044bf69ebbdd8b761f94
link
/test pilot-multicluster-e2e_istio

e2e-dashboard_istio
3c0a6042074782563f23044bf69ebbdd8b761f94
link
/test e2e-dashboard_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

pilot-multicluster-e2e_istio
3c0a6042074782563f23044bf69ebbdd8b761f94
link
/test pilot-multicluster-e2e_istio

e2e-dashboard_istio
3c0a6042074782563f23044bf69ebbdd8b761f94
link
/test e2e-dashboard_istio

release-test_istio
3c0a6042074782563f23044bf69ebbdd8b761f94
link
/test release-test_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rlenglet github UI is acting weird, everything should be good now. They all need the bash iptables but only proxyv2 needs the golang version

They all need the bash iptables but only proxyv2 needs the golang version

Yes, you should be good now.

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

pilot-multicluster-e2e_istio
3c0a6042074782563f23044bf69ebbdd8b761f94
link
/test pilot-multicluster-e2e_istio

e2e-dashboard_istio
3c0a6042074782563f23044bf69ebbdd8b761f94
link
/test e2e-dashboard_istio

release-test_istio
3c0a6042074782563f23044bf69ebbdd8b761f94
link
/test release-test_istio

gencheck_istio
efe480ec2626b7f905010ecc849bf463325cff8c
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

pilot-multicluster-e2e_istio
3c0a6042074782563f23044bf69ebbdd8b761f94
link
/test pilot-multicluster-e2e_istio

e2e-dashboard_istio
3c0a6042074782563f23044bf69ebbdd8b761f94
link
/test e2e-dashboard_istio

release-test_istio
3c0a6042074782563f23044bf69ebbdd8b761f94
link
/test release-test_istio

gencheck_istio
efe480ec2626b7f905010ecc849bf463325cff8c
link
/test gencheck_istio

integ-framework-local-tests_istio
efe480ec2626b7f905010ecc849bf463325cff8c
link
/test integ-framework-local-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

pilot-multicluster-e2e_istio
3c0a6042074782563f23044bf69ebbdd8b761f94
link
/test pilot-multicluster-e2e_istio

e2e-dashboard_istio
3c0a6042074782563f23044bf69ebbdd8b761f94
link
/test e2e-dashboard_istio

release-test_istio
3c0a6042074782563f23044bf69ebbdd8b761f94
link
/test release-test_istio

gencheck_istio
efe480ec2626b7f905010ecc849bf463325cff8c
link
/test gencheck_istio

integ-framework-local-tests_istio
efe480ec2626b7f905010ecc849bf463325cff8c
link
/test integ-framework-local-tests_istio

racetest_istio
efe480ec2626b7f905010ecc849bf463325cff8c
link
/test racetest_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@istio/wg-environments-maintainers please take a look

" That means the Dockerfile ENTRYPOINT command, when defined, must be specified in vector form, to avoid the container runtime prefixing with a shell."
"ENTRYPOINT ["myapp"]"

So it seems the official way to add .deb packages is our friend Bazel...
https://github.com/bazelbuild/rules_docker#container_image-1
I really hope the base distroless image for Istio proxy will be generated from a different repo ( tools,etc) so we don't add a bazel dep if we have to..).  Maybe even do it in the proxy repo, so that proxy builds also generate a distroless-base image where we can just add the agent ? For now it's probably ok to go with your hack of blindly copying all .so files...

Talked with @costinm , will use istio-iptables (no .sh) everywhere, and make sure all usages for VMs are updated for this. For now will keep the distroless hack since it is existing, but opened an issue to track improvement

I think it makes for the proxy repo to produce all repo artifacts (deb packages and docker images).
For that to happen, agent and iptables need to be decoupled from istio/istio and integrated into proxy build system.

@howardjohn: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-security-k8s-tests_istio
d4be86fe868b936ce568acc7c22822b8cde14d87
link
/test integ-security-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-security-k8s-tests_istio
d4be86fe868b936ce568acc7c22822b8cde14d87
link
/test integ-security-k8s-tests_istio

e2e-mixer-no_auth_istio
d4be86fe868b936ce568acc7c22822b8cde14d87
link
/test e2e-mixer-no_auth_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-security-k8s-tests_istio
d4be86fe868b936ce568acc7c22822b8cde14d87
link
/test integ-security-k8s-tests_istio

e2e-mixer-no_auth_istio
d4be86fe868b936ce568acc7c22822b8cde14d87
link
/test e2e-mixer-no_auth_istio

e2e-dashboard_istio
d4be86fe868b936ce568acc7c22822b8cde14d87
link
/test e2e-dashboard_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest
failures seem infrastructural

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-security-k8s-tests_istio
d4be86fe868b936ce568acc7c22822b8cde14d87
link
/test integ-security-k8s-tests_istio

e2e-mixer-no_auth_istio
d4be86fe868b936ce568acc7c22822b8cde14d87
link
/test e2e-mixer-no_auth_istio

e2e-dashboard_istio
d4be86fe868b936ce568acc7c22822b8cde14d87
link
/test e2e-dashboard_istio

integ-framework-k8s-tests_istio
d4be86fe868b936ce568acc7c22822b8cde14d87
link
/test integ-framework-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-security-k8s-tests_istio
d4be86fe868b936ce568acc7c22822b8cde14d87
link
/test integ-security-k8s-tests_istio

e2e-mixer-no_auth_istio
d4be86fe868b936ce568acc7c22822b8cde14d87
link
/test e2e-mixer-no_auth_istio

e2e-dashboard_istio
d4be86fe868b936ce568acc7c22822b8cde14d87
link
/test e2e-dashboard_istio

integ-framework-k8s-tests_istio
d4be86fe868b936ce568acc7c22822b8cde14d87
link
/test integ-framework-k8s-tests_istio

integ-istioctl-k8s-tests_istio
d4be86fe868b936ce568acc7c22822b8cde14d87
link
/test integ-istioctl-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-security-k8s-tests_istio
d4be86fe868b936ce568acc7c22822b8cde14d87
link
/test integ-security-k8s-tests_istio

e2e-mixer-no_auth_istio
d4be86fe868b936ce568acc7c22822b8cde14d87
link
/test e2e-mixer-no_auth_istio

integ-framework-k8s-tests_istio
d4be86fe868b936ce568acc7c22822b8cde14d87
link
/test integ-framework-k8s-tests_istio

integ-istioctl-k8s-tests_istio
d4be86fe868b936ce568acc7c22822b8cde14d87
link
/test integ-istioctl-k8s-tests_istio

e2e-dashboard_istio
d4be86fe868b936ce568acc7c22822b8cde14d87
link
/test e2e-dashboard_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-framework-k8s-tests_istio
d4be86fe868b936ce568acc7c22822b8cde14d87
link
/test integ-framework-k8s-tests_istio

integ-istioctl-k8s-tests_istio
d4be86fe868b936ce568acc7c22822b8cde14d87
link
/test integ-istioctl-k8s-tests_istio

e2e-dashboard_istio
d4be86fe868b936ce568acc7c22822b8cde14d87
link
/test e2e-dashboard_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@howardjohn: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

e2e-dashboard_istio
d4be86fe868b936ce568acc7c22822b8cde14d87
link
/test e2e-dashboard_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

failed to export image: failed to create image: failed to get layer sha256:226f3eff3002042707a9f31eb68b8255ac9c23ccf4591aba9931c10c822226eb: layer does not exist?? not sure how this could happen.. docker on the node may be broken
/retest

@howardjohn: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

e2e-dashboard_istio
d4be86fe868b936ce568acc7c22822b8cde14d87
link
/test e2e-dashboard_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test pilot-multicluster-e2e_istio

/retest

@howardjohn: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

e2e-dashboard_istio
d4be86fe868b936ce568acc7c22822b8cde14d87
link
/test e2e-dashboard_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

e2e-dashboard_istio
d4be86fe868b936ce568acc7c22822b8cde14d87
link
/test e2e-dashboard_istio

racetest_istio
2a3a034bc37812644d8031214f6e84ff79809132
link
/test racetest_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

racetest_istio
2a3a034bc37812644d8031214f6e84ff79809132
link
/test racetest_istio

integ-security-k8s-tests_istio
2a3a034bc37812644d8031214f6e84ff79809132
link
/test integ-security-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

racetest_istio
2a3a034bc37812644d8031214f6e84ff79809132
link
/test racetest_istio

e2e-bookInfoTests-envoyv2-v1alpha3_istio
2a3a034bc37812644d8031214f6e84ff79809132
link
/test e2e-bookInfoTests-envoyv2-v1alpha3_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

racetest_istio
2a3a034bc37812644d8031214f6e84ff79809132
link
/test racetest_istio

unit-tests_istio
2a3a034bc37812644d8031214f6e84ff79809132
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest


terraform: 1.3.1 -> 1.3.2

https://github.com/hashicorp/terraform/releases/tag/v1.3.2
Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Looking at the release diff I'm surprised vendor sha hasn't changed

https://github.com/hashicorp/terraform/compare/v1.3.1...v1.3.2
go.{mod,sum} haven't changed?

D'oh, I looked at 1.3.2...main instead.


Mail recipients reworked

increased unit test coverage for recipient service
additional notification support for users in multiple departments:

mail recipients will be choosen by assigned rules in departments

Coverage increased (+0.05%) to 68.894% when pulling b5f9bab5752d9c10401172063548a30445de857f on mail-recipients into b1b0c96a4983bd5958f340907ee5c593956ce2c5 on master.


Context object not typed on rule arguments

Question about GraphQL Shield
When using graphql-shield in conjunction with apollo-server, it seems like the type of the context provided to apollo-server is not automatically forwarded into the rule definition context. I can manually set the context type on each rule of course, but I wonder if there's maybe just something I'm missing. Should this just work?
Thank you.

[x] I have checked other questions and found none that matches mine.

We offer priority support for all financial contributors. Don't forget to add priority label once you become one! 😄

Love it, did it (as QuestMate) but can't add tag :)

Hi @sreuter!
Thank you for becoming a backer of GraphQL Shield! You are not missing anything. GraphQL Shield relies on GraphQL Middleware and GraphQL Middleware is netural when it comes to servers. That's why we don't automatically derive the type of the context from your server.
I've been planning on making GraphQL Shield type-safe, which includes context, for some time. Some things, behind the scenes, have started steering this boat in the right direction, and your sponsorship is definitely a big contribution on that part. I'll let you know when this feature roles out.
For the time being, I suggest we keep it this issue open for future references.


ensure that commit_hash.h is included in the source tarball

This is not needed anymore (already incorporated)


When to use paket.dependencies and paket.references?

I've read the documentation on paket.dependencies and paket.references, but it's still not clear to me which one I need to edit. It says that paket.dependencies specifies the rules for the application's dependencis. paket.references adds references to an MSBuild project and apparently it's optional.
But what happens when there are no paket.references? Will Visual Studio still recognize the dependencies? Should I place paket.dependencies in each project folder?
After automatically converting my package.config files with paket, I now have a single paket.dependencies file in the root of my solution and paket.references files in each project folder of my solution. If I want to add dependencies, do I only need to add them to the paket.references files? Will paket.dependencies in the solution folder be then updated automatically?
Basically, I don't understand the possible interaction between paket.dependencies and paket.references.

paket.dependencies is a global view of your dependencies. there is no such thing in nuget.
paket.references contains all direct dependencies of a csproj or fsproj. It's not optional. You need to specify that in order to get the references in your project.
so in short: you need to edit both, but commands like paket add help you there.

paket.dependencies = solution wide set of dependencies, not related to any project.
paket.references = dependencies required by a specific fsproj / csproj project etc.

Thanks for the quick answers! They really helped clarify their purpose and relationship. You may want to add that to the index page.
I guess I was confused because it explicitly says that it is optional in The paket.references files:

It acts a lot like NuGet's packages.config files but there are some key differences:
...

It's optional

Is that a mistake or is that meant differently?

@exercitusvir please send a pull request with whatever you think would clarify the docs. We need the help of newcomers here.

It is optional insofar as you don't need it just to manage dependencies. I often use just a dependencies file when working with F# scripts when I don't have a project.
You do need it if you want to marry dependencies to VS projects (AFAIK).

OK. Let me get this working first and then I'll try to improve the documentation for beginners.
One more question. Is there a command to check all paket.references files and update the paket.dependencies file correspondingly? That way, I would only have to edit the paket.references files and run paket with that command just once.
Another suggestion would be to add an overview of the commands with a short description. I only found the list on the right of the index page where it seems that I have to open each page of a command to find out what it's for.

One last question. If I don't have paket.references for each project then how is paket going to know which dependencies a project needs? Will it simply include all dependencies listed in paket.dependencies in every project?

If you don't have a references file, then your project has 0 references.
There is no command that puts dependencies from references files into dependencies file. But you will get errors if that happens.
Yes, a table with the commands would be nice.

So that means that paket.references files are in fact required if the project requires dependencies? I just want to make sure I understand it so that I don't put wrong information in the docs.
Are you planning to add a command that puts dependencies from references files into dependencies file?

I seem to recall an issue about references -> dependencies file a long time ago. One relatively easy way to add to dependencies to a project is (I think) by using paket add. There's an optional argument on that command which can take in the name of a project. Paket will then get the dependency (if it doesn't already have it) and then add it to the project.
An alternative that I sometimes follow is if it dependency already exists, I manually add the dependency to the references file and then run paket install.

Yes it's required. We should remove the "optional" remark since it's obviously misleading.
No I don't plan such a command. Earlier versions did that automatically during install or update. That was convenient, but led to misunderstandings. So we decided to remove that.

@isaacabraham -

An alternative that I sometimes follow is if it dependency already exists, I manually add the dependency to the references file and then run paket install.

It seems paket install would simply no-op if the paket.lock exits and is up-to-date. What works for me is paket install --force. Is there a better/more explicit way to tell paket to force update fsproj from paket.references without a full reinstallation?

Pretty sure that install will update the project files for all references if needed even if lock hasn't changed


Introduce standard log fields and expose zap.SugaredLogger

To introduce standard logging fields and conventions, we need to fix the following limitations with the current codebase

go-logr logr.logger interface doesn't support log levels (they use verbose level number instead).
Top level fields (ts, msg etc) are not as per google structured logging standard. This makes it difficult to view the logs in google console. https://cloud.google.com/logging/docs/structured-logging

To fix this, this PR introduces the following changes (more PRs to follow)

Add standard logging fields namespace and sliceCluster
Change log field names

level -> severity
msg -> message
ts -> timestamp

Expose SugaredLogger from zap to use warn and debug levels directly
Rename NewLogger to NewWrappedLogger and expose SugaredLogger under NewLogger
Replace setupLog in main.go to use sugaredLogger (as an example)

Next steps

Gradually replace logr.Logger with uzap.SugaredLogger in all our packages
Improve log messages and fields

report link  'https://kubeslice.github.io/e2e-allure-reports/Kind-worker-operator-2022-11-14T07:57:44-master-236/index.html'


Expose underlying BSON types from MongoJS

These are necessary if you want to do things like use literal ObjectIds in your code.
For example, this solution on StackOverflow is possible with MongoJS but not with then-mongo:
http://stackoverflow.com/questions/21076460/how-to-convert-a-string-to-objectid-in-nodejs-mongodb-native-driver
Implementation mostly lifted from MongoJS:
https://github.com/mafintosh/mongojs/blob/8e7ae24c3963d706c2b94f1778dcc0fcba2fbc99/index.js#L26-L38

This is really needed feature, would be nice if it's merged.


Update Messaging_and_Streaming.md

Adding suprsend

Thanks, will take care of that from next time. ✌


A few issues

I'm new to laravel so this may be an error on my end, however I am encountering the following issues.
When generating controllers with
php artisan crud:generate Posts --route=yes --view-path="admin" --namespace=Admin --route-group=admin
I get the controller and model in the proper namespace, and the route is correct in routes.php.  However, the controller class is empty.  None of the methods are generated.  And no views are generated.
When I try to generate just a controller, say, if I wanted a separate UsersController within Admin, I am unable to use --route or --namespace as option.  This essentially means that I am unable to create the controller within Admin.
Any attempt to generate views for any controller results in a Symfony undefined offset: 1 error.

Hi @SaintGiff
Maybe you forgot to include the fields.
You must need to define fields as well for this operation.
eg:
php artisan crud:generate Posts --fields="title:string:required, body:text:required" --route=yes --pk=id --view-path="admin" --namespace=Admin --route-group=admin


test: support travis multirunner BVER in selenium lib

supports both variants of BVER for safari technology preview -- unstable coming from https://github.com/DamonOehlman/travis-multirunner/pull/23

LGTM with a note to add this to utilities.


XAML files are ignored when doing a project wide unification of line endings

A user has reported that adding ".xaml" to the list of supported file formats doesn't make the extension analyze and modify XAML files after clicking the "Unify Line Endings In Project" button.

I've fixed the issue in the newest release.


Display last edit date

Would be nice to have the last edit day displayed in the list on left AND in detail page.

We're not going to show the history revisions on the app (you can navigate to there by the #revisions button). In this sense, it might not have much value for showing the last edit day IMHO.

@hackjutsu I dont need whole revision history, last the last edit date for the current gist.   And yes, the revision history can be seen with a simple click (which opens the page in browser).

@hackjutsu
I think we should display information that GitHub's online Gist page displays.

@wujysh @mikeerickson
When we have a setting page in the future release, I'll add an option to turn on/off the last edit date, and maybe some other information.

Done: https://github.com/hackjutsu/Lepton/commit/6e18ec097b328266eb0f44cd55c262586c3fab7e


Start with some AVS diagram

This could be clearer, but I think it is a start.
I'd love feedback. (Look at rendered md on the branch to see it better)

Diagram is good IMO. Some more explanation regarding the workflow could be useful for newbies.
I was explaining the same thing yesterday and I found a similar diagram (and for the hell I can't find it again anymore).


New Release (1.7.2)

Hey there! First off, thank you so much for building such an awesome project.
I'd like to request a new release (1.7.2 or 1.8.0) which includes the commit: https://github.com/tsl0922/ttyd/commit/790cfb39f1f1137f681087ac1884f56e17c5a14f.
I am building a project that relies on ttyd and requires users to install ttyd on their machine, but requires the previously mentioned commit to work correctly with my project.
It would be awesome to have a release that includes the commit so that it is easier for users to install it without needing to build from source.
I can help bump the ttyd on some package managers after the next release.

Resolved by: https://github.com/tsl0922/ttyd/commit/020e2f3ded508d5fca95196a647fde09f05758b3
Thank you so much!


Add a CLI tool for local tagging

Closes #66
Closes #148
Haven't yet done an online test, maybe tomorrow. Perhaps @omus would like to try it out for me. 🙂
Do note that the Docker instructions will only work after this is merged and tagged.

I'll test this out now

Worked perfectly for JuliaIO/CodecLz4.jl for the v0.4.0 release. One minor thing that would be nice to change is to have the tool prompt for the GitHub token if none is passed in. Doing this avoids recording the GitHub token in your shell history


Add a wiki: WEBFISHING Wiki

An anonymous user has submitted a new wiki via our submission form.
Link to origin wiki: https://webfishing.fandom.com
Link to destination (independent) wiki: https://webfishing.wiki.gg

Will be in the v3.11.1 release, pending approval from Chrome and Firefox


[FEAT]: Try creating diagrams using Mermaid

Description
GitHub recently announced the integration of Mermaid. Let us see whether this can be useful to include diagrams into markdown pages and if this also works on https://arneis.readthedocs.io.
Additional Information
Other links:

https://ardalis.com/github-diagrams-with-mermaid/
https://github.com/mermaid-js/mermaid
https://github.com/github/roadmap/issues/372
https://mermaid-js.github.io/
https://www.youtube.com/watch?v=-HUwt8dF4X8

Hi! I just published a tutorial to use the mermaid graphic tool here.
I hope you find it useful!

Hi! I just published a tutorial to use the mermaid graphic tool here.
I hope you find it useful!

Yes, it is!
Would you mind submitting a Pull Request to ARNEIS repo in order to have it listed as an ARNEIS official HOWTO?

Sure 😄 I'll do it asap

Sure 😄 I'll do it asap

@pitdagosti I got lost: did you eventually submit the PR? If so, where is it?

Sure 😄 I'll do it asap

@pitdagosti I got lost: did you eventually submit the PR? If so, where is it?

Never mind. The result is now maintained at https://github.com/B-AROL-O/ARNEIS/blob/main/docs/howto/howto-use-mermaid-graphic-tool.md


Added check during input, do not trigger shortcut keys during input

Added check during input, do not trigger shortcut keys during input
https://github.com/user-attachments/assets/e6f567b3-2a0c-4d02-8190-570f8168405f

release test to 0.0.7-alpha.1


Updated prism.js theme, fixing browser selection in docs

You had some rather old prism.js theme styles at docs that didn't have the scope for the text selection inside the code, that resulted in invisible text selection elsewhere. I updated the corresponding theme file with the latest (https://github.com/PrismJS/prism/blob/gh-pages/themes/prism-twilight.css), keeping some of the edits you've done so it would look basically the same (kept the added font to font stack, removed some styles from the code element, stuff like that).
If there are still things that you had removed manually and that should be kept — you could change it afterwards, or point me to them, I'll change this PR.

Thanks. :)


Fix broken link on ref/modify.html page in docs

The FactoryBot.modify reference page on the documentation site has a broken link for "the guide".
This commit fixes the link.

Beautiful, thank you!


Filtering by UTC DateTimeOffset causing issues in SyncTable

For brevity please refer to this discussion
Essentially a simple conditional filter on a query doesn't seem to be working at all. If I have this particular query
allMessages = await                         MobileServiceInstance.GetSyncTable<Messages>()                             .OrderByDescending(key => key.SentDate)                             .Take(50)                             .ToListAsync();
I should expect the last 50 messages in the SyncTable. Now if I take the result of this query and want to get all the items whos SentDate property is less than a particular item's SentDate I should be able to do this
filteredMessages = await                         MobileServiceInstance.GetSyncTable<Messages>()                             .OrderByDescending(key => key.SentDate)                             .Take(50)                             .Where(p => p.SentDate < allMessages[24].SentDate)                             .ToListAsync();
Note that the SentDate property is a DateTimeOffset datatype. The above variable should be a list of 25 items. However the result is 0 when I run it.
You can reference the stackoverflow discussion for all the tests we performed, but I'm starting to come to the conclusion that it is a bug.

I think I had a similar issue before and I ended up switching over from DateTimeOffset to DateTime in my client side models. This may be a bug that needs to be fixed, but maybe you can get by using DateTime in the mean time.

@dillondrobena Thanks for using Azure Mobile Apps. Since this issue is over 2 years old, I'll close it for now but feel free to ask us questions if you have any. Also, please refer to the section on the ReadMe that highlights the future of Azure Mobile Apps.


design revamp of harvesting process

[x] baby test examples (cg)
[ ] check in w/ jan about how this would effect parallelization
[ ] draft plan (ew)

@cmgosnell I leave tomorrow morning through September 20, so I guess I'll draft out a plan once I'm back. In addition to illustrative example(s) of desired input and output tables, here are questions that came to mind during my early pondering:

What level of error reporting is desired when a field constraint fails? Is it sufficient to report the field name and constraint that failed, or is it also desirable to report the unique field values that failed (when applicable)?
Do multi-column constraints need to be supported? Can we recast two-column locations (e.g. lat, lon) to single geometry columns?
Does an entity identifier need to be created, or is an existing field always used as such? In other words, is it

[ a | b ] + [ a | c ] = [ *a ] entities + [ *a | b | c ] data, or
[ a | b ] + [ a | c ] = [ *id | a ] entities + [ *id | b | c ] data ?
where * denotes primary key columns in the output tables.

Can the normalization groupings be determined from the output tables and their primary keys? For example:

[ a | b | c ] -> [ *a | *b ] entities + [ *a | c ] data
c must be normalized by a
[ a | b | c ] -> [ *a | *b ] entities + [ *a | *b | c ] data
c must be normalized by a, b

Are some primary keys spread across multiple input tables? For example, can there be:
[ (a1, b1) ] + [ (a2, c1) ] = [ (a1, ), (a2, ) ] entities + [ (a1, b1, null), (a2, null, c1) ] data
where '(...)' denotes a table row.

hi @ezwelty!! sorry I didn't get this to you before you skedaddled but I finally generated examples. I tried to give a few concrete, standard examples, but I could certainly add more if that would be helpful.
I'll respond to these questions shortly.

What level of error reporting is desired when a field constraint fails? Is it sufficient to report the field name and constraint that failed, or is it also desirable to report the unique field values that failed (when applicable)?

Do you mean if a specific field/values (if the plant_name for plant_id_eia == 3 isn't consistent enough) or if a whole column has too many non-harvestable values (if the plant_name column has more than 10% nulls after the harvesting process)? I am going to assume it is the latter because I don't think we want/need to report the individual values when they fail.
On a normal ETL run, it should be sufficient to report that a column has failed its constraints. Nonetheless, it is important for debugging to have a way to jump into the fray to determine how things failed.

Do multi-column constraints need to be supported? Can we recast two-column locations (e.g. lat, lon) to single geometry columns?

We don't currently have multi-column constraints. Nonetheless, if we can do it without too many back-flips it would be nice to be able to do this for lat/long. I don't think there are any other columns which would fall into this bucket. So squishing lat/long together as a geometry and checking for spatial closeness instead of consistency seems like the right way to go.

Does an entity identifier need to be created, or is an existing field always used as such? In other words, is it
[ a | b ] + [ a | c ] = [ *a ] entities + [ *a | b | c ] data, or
[ a | b ] + [ a | c ] = [ *id | a ] entities + [ *id | b | c ] data ?
where * denotes primary key columns in the output tables.

All entity identifiers are grabbed from existing fields. Sometimes those identifiers are composite primary key columns

Can the normalization groupings be determined from the output tables and their primary keys? For example:
[ a | b | c ] -> [ *a | *b ] entities + [ *a | c ] data
c must be normalized by a
[ a | b | c ] -> [ *a | *b ] entities + [ *a | *b | c ] data
c must be normalized by a, b

The normalization grouping should be able to be determined based on the PKs of the final tables. Both the primary keys (to find the entity identifier columns) and which data columns need to be harvested should be able to be determined based on the metadata for the output tables. If these two examples are an 1 vs 2, it looks like the second example is the way.

Are some primary keys spread across multiple input tables? For example, can there be:
[ (a1, b1) ] + [ (a2, c1) ] = [ (a1, ), (a2, ) ] entities + [ (a1, b1, null), (a2, null, c1) ] data
where '(...)' denotes a table row.

No. A composite primary key should always come from an input table in which all of its pk columns exist. There are tables which have plant_id_eia and others which have both plant_id_eia and generator_id. If a plant id doesn't show up associated with a generator, than it shouldn't end up in the generator entity table.

@cmgosnell I'm back!

Do multi-column constraints need to be supported? Can we recast two-column locations (e.g. lat, lon) to single geometry columns?

We don't currently have multi-column constraints. Nonetheless, if we can do it without too many back-flips it would be nice to be able to do this for lat/long. I don't think there are any other columns which would fall into this bucket. So squishing lat/long together as a geometry and checking for spatial closeness instead of consistency seems like the right way to go.

In that case, I would recommend converting two-column geometries to single-column geometries (e.g. geopandas.GeoSeries to support all types of geometries, or a simple lon, lat tuple if all we want to worry about for now are points) in an initial step. That way we avoid developing a syntax for multi-column constraints just for coordinate pairs.

Are some primary keys spread across multiple input tables? For example, can there be:
[ (a1, b1) ] + [ (a2, c1) ] = [ (a1, ), (a2, ) ] entities + [ (a1, b1, null), (a2, null, c1) ] data
where '(...)' denotes a table row.

No. A composite primary key should always come from an input table in which all of its pk columns exist.

So more generically, I think you are saying that output table primary keys (whether one or multiple fields) cannot contain null values?
In my example, I was trying to get at whether an entity can be spread across multiple tables. For example, would the input tables:

a
b

a1
b1

and

a
c

a2
c1

where a is the primary key of both output tables, result in the output tables:
entities

a

a1

a2

and
data

a
b
c

a1
b1
null

a2
null
c1

@ezwelty welcome back! I hope away time way nice.

So more generically, I think you are saying that output table primary keys (whether one or multiple fields) cannot contain null values?

I believe that is the case, although I'm a little fuzzy on how this would work for the association tables. I think in those instances it might be good to enable nulling of the PKs because I think in  those cases the PKs are all of the columns. If we are collecting info from tables about which utilities operate in which states and counties.... it would probably be good to enable collecting state-only info for utilities.

In my example, I was trying to get at whether an entity can be spread across multiple tables.

Ah, now I see what you are asking. Yes. Definitely. The id's for a single entity almost always come from multiple tables. And because the reporting isn't airtight (and general mismatch of reporting requirements) we'll end up with missing data for some entities because they didn't show up in all of the input tables.

@cmgosnell I've started drafting a proposal and fleshing out your example, but it seems to be incomplete? For example, the resulting 3 output tables discard the linkage between plant_id_eia & generator_id and utility_id_eia & utility_name_eia. There are also fields that don't get carried over, like sales, net_generation_mwh, and capacity_mw. This was likely on purpose to make the example more lightweight, but it will probably serve us better to make it a complete example relative to the input tables. Could you fill out the missing columns?

that is fair! I was just focused on the entity-type output tables, not the "data" output tables. I'll add those tables and columns.

okay @ezwelty I believe I've fleshed out the output tables in the notebook. I checked it into the sprint24 branch! lmk if that works for ya or if you have more questions.

Hey @ezwelty, @cmgosnell and I chatted about the time columns and different frequencies, and also discovered the very helpful df.merge_asof() method, and searched for all of the inter-frequency merges that are happening in the codebase now, which is not that many (and they're in the output objects / analysis layer). So we're thinking of re-naming the time columns to reflect their frequency like report_year and report_month and report_quarter etc. but keeping them all Datetime types.
Given that we do want to combine attribute values from tables that are reported with different frequencies, but which pertain to entities (utilities, plants, etc) that are consistent on some longer timescale, I'm not sure I see a way to avoid having some infrastructure that's specific to the time columns.

@zaneselvans Thanks for the update.

... we do want to combine attribute values from tables that are reported with different frequencies, but which pertain to entities (utilities, plants, etc) that are consistent on some longer timescale...

Sure. Could you provide a minimal input-output example here to illustrate what you have in mind? I need to understand the operation in terms of rows, column names, primary keys ... to be able to implement it.

@zaneselvans @cmgosnell How would you like me to share work (documentation, code, tests) and gather feedback on it? Temporary standalone catalyst repo, pudl branch, pudl pull request?
A couple questions about the example:

With the harvest logic we hashed out on the call, I can reproduce the example, except for generators_eia860. Expected:

   plant_id_eia generator_id report_date  capacity_mw
0             3            1  2018-01-01        153.1
1             3            1  2017-01-01        153.1
2             3            2  2018-01-01         50.0
3             3            2  2017-01-01         50.0
4             4            a  2017-01-01          NaN
5             4            b  2017-01-01          NaN

Q: Should the last two rows be there? If not, then it is settled. If yes, this would require knowing to harvest only from inputs generators_eia860 and boiler_generator_assn_eia860, which is neither my understanding of data table behavior nor entity/association table behavior.
With harvest: False (data table), it extracts all fields from the input table with the same name:
   plant_id_eia generator_id report_date  capacity_mw
0             3            1  2018-01-01        153.1
1             3            1  2017-01-01        153.1
2             3            2  2017-01-01         50.0
3             3            2  2018-01-01         50.0

i.e. the 4 rows of input generators_eia860
With harvest: True, it harvests all the instances of the primary key fields (plant_id_eia, generator_id, report_date) from the other input tables. If rows where all data fields are null are removed, the result is equivalent to the above, since only input generators_eia860 has both the primary key fields and capacity_mw:
    plant_id_eia generator_id report_date  capacity_mw
0              3            1  2017-01-01        153.1
1              3            1  2018-01-01        153.1
2              3            1  2018-02-01          NaN
3              3            1  2018-03-01          NaN
4              3            1  2018-04-01          NaN
5              3            1  2018-05-01          NaN
6              3            1  2018-06-01          NaN
7              3            1  2018-07-01          NaN
8              3            1  2018-08-01          NaN
9              3            1  2018-09-01          NaN
10             3            1  2018-10-01          NaN
11             3            1  2018-11-01          NaN
12             3            1  2018-12-01          NaN
13             3            2  2017-01-01         50.0
14             3            2  2018-01-01         50.0
15             4            a  2017-01-01          NaN
16             4            b  2017-01-01          NaN

I am curious why input table generators_eia860 links plant_id_eia and generator_id with utility_id_eia, but this relation is not retained anywhere in the outputs. If an unintentional omission, I presume a simple association table would be used to preserve that relationship?

p.s. Not sure if this is helpful, but in regards to time, here is how I would imagine organizing the tables. The example assumes 1-many utilities-plants, and that attributes are reported either annually, quarterly, or monthly.

utility: [utility_id,  ... ] All "static" attributes harvested across all tables and all time scales reported in association with a utility_id.
utility_annual: [utility_id, report_year, ... ] All attributes harvested across all tables reported annually in association with a utility_id and report_year.
utility_quarterly: [utility_id, report_quarter, ... ] All quarterly attributes ...
utility_monthly: [utility_id, report_month, ... ] All monthly attributes ...
plant: [plant_id, utility_id, ... ]
plant_annual: [plant_id, report_year, ... ]
...

We've been organizing feedback via branch-and-PR, which each of us making a branch off of the current sprint branch (sprint25 right now, sprint26 starting next week, but it doesn't exist yet), and then doing a PR against whatever the current sprint branch is t the time of the PR's creation. After each sprint we merge anything into the sprint branch back into dev and create a new sprint branch.
Let me think some more about the other stuff in here.


feat(proxy): TLS config reload

Why

Fixes #330
What

Reload TLS config via the admin.
Checklist

[ ] ~I have made corresponding changes to the tests~
[ ] ~I have made corresponding changes to the documentation~
[x] I have run the app using my feature and ensured that no functionality is broken

Now that #357 and #127 are done. I'll get back to working on this.

Closing in favor of https://github.com/fleek-network/ursa/pull/455.


Cookie too large error

Bug report.
User filters and page settings appear to be saved in cookies, so users with many settings can receive a 400 - Request Header or Cookie Too Large error when browsing the community server site. The cookie that caused this particular error is 8,220 bytes. By default, nginx is configured to limit cookies to 8 kilobytes, so this cookie is slightly larger than the default limit.
An easy fix would be to add large_client_header_buffers 4 16k; to the nginx server block, but that will be reset if the container is restarted.
Community Server <IP_ADDRESS>8, installed via Docker.

Thank you. We will include this fix in the next release.


🐱 add support for MEOW ERC20 token icon

A PR to add the MEOW token icon.

Contract address (Ethereum mainnet): 0x77be1ba1Cd2D7a63BFfC772D361168cc327dd8bc
Website: https://meoweth.com/
Etherscan (contract verified): https://etherscan.io/token/0x77be1ba1cd2d7a63bffc772d361168cc327dd8bc

You can also find our project here:

CMC: https://coinmarketcap.com/currencies/miaomiaomiaoerc20/
CoinGecko: https://www.coingecko.com/en/coins/meow

OK, good point regarding the decimals..
I'm waiting for an optimized logo, I'll push it ASAP.
Thanks

I've just added an optimized SVG logo and have corrected the contract decimal properly.

Great work, thank you for your contribution


Consider addind default values to variables documentation

I needed to open the source code to learn that producer's max_retries defaults to 3. It would be great if this was explicit on variable description.

Default argument information is contained in the init function specification for each class. For Producer, it's here. We could maybe also put it in the docstring, but I'm not keen on duplicating that information.

Oh, that's enough then.
Just noticed that "Init signature" is available at ipython information, via:
In [1]: import pykafka
In [2]: pykafka.Producer?

Thank you.


Update vulnerabilities

update any packages that may be causing vulnerability issues.

Not really sure what is up with this one, but I can't find the vulnerabilities in our dependency graph anymore. I assume that whatever package we rely on that was using it removed it from their dependency.

The package was hoek version < 3.

On Apr 27, 2018, at 3:51 PM, Connor Grimm<EMAIL_ADDRESS>wrote:
Not really sure what is up with this one, but I can't find the vulnerabilities in our dependency graph anymore. I assume that whatever package we rely on that was using it removed it from their dependency.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

I did remember that, but the problem is that I don't even see it in our dependency tree.

Closing because there are no longer vulnerabilities.

When Adam pushed his package-lock files, they included some outdated dependencies. The package-lock file is not our direct dependencies, but generally made up of our dependencies' dependencies.

There is a new message (I think when I updated npm, but I didn't notice it at first) when installing new packages. Here is the message:

After some more research, I found that we don't really need to worry about any of these issues. As npm receives reports from users about vulnerability issues, an npm audit will report those issues along with their severity. I found that all of our critical, high, and moderate severity vulnerabilities are in development dependencies and would not be provided in a production environment. Many of our low severity vulnerabilities are of the same cut, and the rest don't seem like our use cases will run into them from my shallow search. I'm closing this issue unless we figure out a need to do something more about this.


wip: change private to public calls

Please read contributing guidelines and remove this line.

#9796  👈
master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @fcarreiro and the rest of your teammates on  Graphite