KOGITO-7256: Patch PR for KOGITO-7255 with doc improvements in Callback guide

JIRA: https://issues.redhat.com/browse/KOGITO-7256

Description: Patch PR for KOGITO-7255 with doc improvements in Callback guide

https://github.com/kiegroup/kogito-docs/pull/46
Please make sure that your PR meets the following requirements:

[x] Pull Request title is properly formatted: KOGITO-XYZ Subject
[x] Pull Request title contains the target branch if not targeting main: [0.9.x] KOGITO-XYZ Subject
[x] The nav.adoc file has a link to this guide in the proper category

@fjtirado Please review the changes in the PR and share your comments.

@hmanwani-rh Thanks for the suggestions, but the PR as it is cannot be merged In my opinion, the guide after the changes is not longer useful. Reason is that the meaning of key sentences is completely changed.

@fjtirado Thanks for reviewing the changes and sharing comments.
I've made some of the changes as suggested. However, added questions and responses to some comments for which I'd need your input. Please take a look one more time and share your inputs.

@hmanwani-rh Thanks for the suggestions, but the PR as it is cannot be merged In my opinion, the guide after the changes is not longer useful. Reason is that the meaning of key sentences is completely changed.

@fjtirado Please let me know if now we can merge this PR with the applied changes.

@hmanwani-rh , after reading the whole document, the only thing that I would change is
After that, the published CloudEvent modifies the value of move field and publishes the move field as a result field. Also, the consumed CloudEvent contains an attribute named kogitoprocrefid, which holds the process instance ID of the workflow that published the consumed CloudEvent.
to
After that, the workflow application consumes the event published by the listener and sets the result field. The consumed CloudEvent contains an attribute named kogitoprocrefid, which holds the process instance ID of the workflow
Reason is that after the rearrangement, the first sentence is not relevant (even redundant with previous content) and a simplified version is more readable

@fjtirado Thanks for sharing the suggestion. I've made the change as suggested.
Merging this PR.


only dat file in /.well-known/ directory is shared/synced

no reason to restrict those imo,
some keep pgp-keys in there
and other contact~ish information
atm im experimenting with dat being my deploy tool for a website (static files only),
and having some of them just be ignored w/o notice is very frustrating

Hey, thank you for the heads up!
What version of the CLI are you using?
Also, do you have a .datignore file in the folder?
Looking into the source for dat-ignore it doesn't seem like it should be doing anything special with the .well-known directory.

version: latest stable from npm

standard .datignore:

.git
.dat
node_modules
*.log
**/.DS_Store
Thumbs.db

full contents of /.well-known/:
https://github.com/dym-sh/site/tree/master/.well-known
i also made new pure dat with only /.well-known/, and the problem repeated itself

ohwait, it's white-listing only the dat file!

imo, if there is a .datignore -- everything not in there should be included.

Are you using dat share on one machine and using dat sync on another machine? It should be including anything that's not in the datignore file.

Do you happen to be loading this archive through dat-gateway or hashbase?

yes, share/sync, and sync/sync later yield the same.
you can see all the files on source: https://github.com/dym-sh/site
hashbase is only a secondary sync target, it didnt matter, files are missing on my server
and as i said, i created a new dat (no hashbase) with just .well-known/, and the dat file was the only one shared.
try to put random files in .well-known and see if they sync.

I think I found it! By default, the CLI has the ignoreHidden flag set to true which means it'll ignore any folders that start with a .. When doing a share or sync, you should set this flag to false and manually add any "hidden" folders to the .datignore file.
So unless I'm mistaken about the boolean parsing logic, you should be able to do something like this:
dat share . --ignoreHidden=false

Refs:
https://www.npmjs.com/package/dat-ignore#options
https://github.com/datproject/dat-node/blob/master/dat.js#L109
https://github.com/datproject/dat/blob/master/src/commands/share.js#L18

alright, it worked :D
will have to alias dat sync --ignoreHidden=false


Add proper support for floats in entities

Floating point numbers that happen to be whole numbers are
incorrectly treated as integers.  For float64 types encode them
as Edm.Double types.

[ ] The purpose of this PR is explained in this or a referenced issue.
[ ] The PR does not update generated files.

These files are managed by the codegen framework at Azure/autorest.go.

[ ] The PR targets the latest branch.
[ ] Tests are included and/or updated for code changes.
[ ] Updates to CHANGELOG.md are included.
[ ] Apache v2 license headers are included in each file.

Fixes https://github.com/Azure/azure-sdk-for-go/issues/4733
Some recordings were updated, you can ignore them.

Can one of the admins verify this patch?


Addition of networks in mist_device_gateway.tunnel_configs.[key] causing errors

In the latest version where networks is added under tunnel_configs.[key].networks to resource mist_device_gateway I hit an error when trying to create a gateway
│ Error: Missing TunnelConfigsValue Attribute Value
│
│   with mist_device_gateway.gateway_one,
│   on main.tf line 10, in resource "mist_device_gateway" "gateway_one":
│   10: resource "mist_device_gateway" "gateway_one" {
│
│ While creating a TunnelConfigsValue value, a missing attribute value was detected. A
│ TunnelConfigsValue must contain values for all attributes, even if null or unknown.
│ This is always an issue with the provider and should be reported to the provider
│ developers.
│
│ TunnelConfigsValue Attribute Name (networks) Expected Type:
│ types.ListType[basetypes.StringType]

resource "mist_device_gateway" "gateway_one" {
  name      = "gateway_one"
  device_id = "redacted"
  site_id   = "redacted"
  oob_ip_config = {
    type = "dhcp"
  }
  additional_config_cmds = ["#", "##"]
  dns_servers            = ["<IP_ADDRESS>"]
  managed                = false
  dhcpd_config = {
    enabled = true,
  }
  tunnel_configs = {
    default = {
      ike_lifetime = 28800,
      # Upset about Networks here
    },
  }
}

this appears to be fixed in the latest release


Add PKCS8 Support

Squashed and rebased #147, then updated the tests to use test-cert-gen like the other tests.
Closes #27

[x] Reject other formats in openssl and security_framework. Done by simply checking the start of the key.
[x] Update from_pkcs8 tests to use PKCS#8 keys. test_cert_gen doesn't support it, so generated RSA keys are converted using openssl pkcs8 -topk8 -nocrypt.
[x] Fix Windows failing two_servers test. Fixed by using unique container names.

I noticed this PR has been sitting for a few weeks now. This is also something that I'm hoping can land soon, since. Is there anything I can do to help get these changes merged into master?
(And thank you @kazk @Goirad for all the work you've put in so far!)

@sfackler Please approve running workflows.

Here's a patch to fix the macOS build:
diff --git a/src/imp/security_framework.rs b/src/imp/security_framework.rs
index ca86cd5..f133903 100644
--- a/src/imp/security_framework.rs
+++ b/src/imp/security_framework.rs
@@ -423,6 +423,7 @@ impl<S: io::Read + io::Write> TlsStream<S> {
         Ok(self.stream.context().buffered_read_size()?)
     }

+    #[allow(deprecated)]
     pub fn peer_certificate(&self) -> Result<Option<Certificate>, Error> {
         let trust = match self.stream.context().peer_trust2()? {
             Some(trust) => trust,
diff --git a/src/test.rs b/src/test.rs
index 897bb85..5fe8151 100644
--- a/src/test.rs
+++ b/src/test.rs
@@ -186,7 +186,10 @@ fn peer_certificate() {
     let socket = p!(builder.connect("localhost", socket));

     let cert = socket.peer_certificate().unwrap().unwrap();
-    assert_eq!(cert.to_der().unwrap(), keys.client.ca.get_der());
+    assert_eq!(
+        cert.to_der().unwrap(),
+        keys.server.cert_and_key.cert.get_der()
+    );

     p!(j.join());
 }

I will have to fix the OpenSSL issue tomorrow.

Linux tests should be fixed if you merge in master.

@sfackler Thanks, rebased on the latest master. I need you to approve running workflows again :|

schannel doesn't support importing PEM encoded RSA key at the moment. https://github.com/steffengy/schannel-rs/pull/64#issuecomment-576995977
I don't have Windows machine to test, but looks like it can be decoded with
let res = wincrypt::CryptDecodeObjectEx(wincrypt::X509_ASN_ENCODING |
                                        wincrypt::PKCS_7_ASN_ENCODING,
                                        wincrypt::PKCS_RSA_PRIVATE_KEY, // <-
                                        der.as_ptr(),
                                        der.len() as winapi::DWORD,
                                        wincrypt::CRYPT_DECODE_ALLOC_FLAG,
                                        ptr::null_mut(),
                                        &mut buf as *mut _ as winapi::LPVOID,
                                        &mut len);

I'm not sure why you say PEM is not supported and then link to a PR implementing exactly that? Are you trying a PKCS#1 or a PKCS#8 key?

I linked to the comment saying:

Turns out it rejects PKCS1 keys. I've added a test to that effect.

They added explicit check:
    /// Imports a PEM-encoded PKCS8 private key.
    /// This functions decodes PEM blocks with or without "-----BEGIN PRIVATE KEY-----"
    /// and "-----END PRIVATE KEY-----" headers, but if PEM guards are present they must be exactly
    /// these.

Tests are failing on Windows here because we're testing with PEMs having BEGIN RSA PRIVATE KEY (PKCS1) headers.
As far as I can tell, "Turns out it rejects PKCS1 keys." is because it failed to decode DER encoded key. The snippet I posted above should be able to decode RSA key, and schannel should be able to support both by using the headers to detect the kind.

Where is the key coming from? I don't see it in the PR.
Anyway, the feature is to add PKCS8 support, the test should use a PKCS8 key.

Keys are generated by test_cert_gen crate.

Anyway, the feature is to add PKCS8 support, the test should use a PKCS8 key.

The function should probably be renamed. schannel is the only one that ignores the headers in PEM (should be possible to fix this). I think most users want a way to create an Identity from a certificate chain and a private key for client authentication, and not PKCS8 support specifically. I don't think it's a good idea to limit to PKCS8 key because users will have to parse the PEM and select a specific function to call (unless native_tls adds a wrapper function later), and native_tls will have to add separate functions wrapping each backend.
rustls supports creating config with a certificate chain, and a matching private key. They can add support for more key types without breaking changes. I think native-tls should provide something similar. The key types supported by each backend may vary, but that's already the case with PKCS12.

native-tls is about providing standard, cross-platform primitives. I strongly believe we should standardize on PKCS8 for the private key format as it supports all key types. I also think blindly accepting different formats in the same function adds to the general confusion about key formats. Adding PKCS1 support separately may be done but I don't really see the appeal. It's pretty easy to convert PKCS1 keys to PKCS8.

users will have to parse the PEM and select a specific function to call

I don't understand what you mean by this.

Just to be clear, only accepting PKCS#8 is fine if that's what is best for native_tls. I'm not against it. I just thought it's more ergonomic to have a function to create an Identity from a certificate chain and a PEM-encoded private key, and thought it's easier for native-tls because it can let each backend handle the PEM. This PR (#147) currently works that way, and from_pkcs8 is misleading.
If we're going strict, we'll need to reject keys in openssl and security_framework.

I don't understand what you mean by this.

If native_tls provided separate functions for each key from_pkcs8/from_rsa/from_ecdsa etc., each user (library) will have to parse the PEM to find which one to call. It's pretty common to not have control over the private key format.

Adding PKCS1 support separately may be done but I don't really see the appeal. It's pretty easy to convert PKCS1 keys to PKCS8.

If native-tls can provide a cross-platform way to convert between formats, that'll be great.

I would be more than happy to also support PKCS1 (if for no other reason than to avoid all of the support issues from people with the wrong encoding :D), but whatever is implemented does definitely need to be consistent across the backends, either supporting or not supporting a format.

Oh wow... thank you all for the flurry of comments and commits!
While I'm mainly looking for PKCS 8 support (since in my case, I can require that the private keys are in PKCS 8 form), I agree with @kazk and @sfackler that if we are to limit the key format to PKCS 8, we need to do so consistently across all backends, and if we are to support something, all three backends should support it. (I'd also add that if we want to make a generic function that accepts keys of different formats (PKCS 1, PKCS 8, SEC 1, etc.), it shouldn't be named from_pkcs8, obviously :slightly_smiling_face:)
And again, do let me know if there's anything I can do to help!

I'll change to only support PKCS#8 format by rejecting anything else. I don't have a macOS/Windows machine to work on adding and testing other formats. Also, I found a way to convert PKCS#1 and SEC1 to PKCS#8 in pure Rust that might be good enough for my use case (started topk8).
I tried using topk8 to test Windows after converting PKCS#1 to PKCS#8, and it seems to work. But two_servers test panicked with:

"unexpected EOF during handshake" on accept
"The Local Security Authority cannot be contacted" on connect

Not sure what's wrong because server_pkcs8 test passes.

TODO

[ ] Reject other formats in openssl and security_framework
[ ] Update from_pkcs8 tests to use PKCS#8 keys. test_cert_gen doesn't support it :(
[ ] Fix Windows failing two_servers test

@sfackler I need you to approve running workflows again. I tested on my fork, and all tests should pass.

I have no experience with MacOS programming, and I see the P12 code also does this, but is there really no way to import key material without involving the filesystem?

Yeah, unless things have changed since last time I looked into this, you can only get a SecIdentify out of a keychain, and keychains have to live on the filesystem.

What needs to be done before merge?


fix(go): interface code gen

Adds generation of empty structs for behavioral interfaces. These are to
be used by the runtime so that methods that return behavioral interfaces
have some known type that is able to be constructed and returned. These
may be able to be made private (non-exported) though they may be
referenced by other JSII modules that depend on them as necessitated by
the runtime.
Additionally, changes type signatures in places to always refer to the
interface type of JSII classes, interfaces, and structs. This is
required since JSII methods always return the interface implementation
of complex types in order to resolve runtime reference values. In order
for the returned values to be passed into other methods, the methods
themselves must accept the interface type and not the concrete type.
Added runtime code gen for calls to jsii get/set apis. Changed order of
args in runtime Get/Set functions to better match method invoke.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject6AEA49D1-5lHf64IXfvmr
Commit ID: 17cee7acee0a64db83651aa0106fefd6c86117ed
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject6AEA49D1-5lHf64IXfvmr
Commit ID: 5945a5d20ce1d19caccd9adc078d03aa206eebcb
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository


update layout

Can you:

[ ] remove the wiggu.egg-info
[ ] remove the empty, untiitled file

link this PR to the issue(s) you were addressing?


Doesn't fix the method call indentation

https://github.com/elyby/php-code-style/issues/1
The PHP version you are using ($ php -v):
PHP 7.2.8

PHP CS Fixer version you are using ($ php-cs-fixer -V):
PHP CS Fixer 2.12.2

The command you use to run PHP CS Fixer:
vendor/bin/php-cs-fixer fix -v

The configuration file you are using, if any:
https://github.com/elyby/php-code-style/blob/50c7deed656f1f168db00db6f7988dcd24c57d44/src/Rules.php
If applicable, please provide minimum samples of PHP code (as plain text, not screenshots):

before running PHP CS Fixer (no changes):

<?php
class Test {

    public function actionGetHistoryRendered(int $id) {
        return Yii::$app->response->sendContentAsFile(
            $this->findDevice($id)->history_rendered,
            'historyRendered.xml',
            ['mimeType' => 'text/xml']
            );
    }

}

with the changes you expected instead:

<?php
class Test {

    public function actionGetHistoryRendered(int $id) {
        return Yii::$app->response->sendContentAsFile(
            $this->findDevice($id)->history_rendered,
            'historyRendered.xml',
            ['mimeType' => 'text/xml']
        );
    }

}

PHP-CS-Fixer doesn't fix closing bracket. I can put it with any indentation and it will not be fixed. I can try to submit PR, but I need your help to identify, which one fixer should be responsible for this indentation.

Yeah I'm experiencing this too using --rules=@PhpCsFixer

Tested on latest master:
kub@:~/GitHub/PHP-CS-Fixer(master)$ cat test.php
<?php
class Test {

    public function actionGetHistoryRendered(int $id) {
        return Yii::$app->response->sendContentAsFile(
            $this->findDevice($id)->history_rendered,
            'historyRendered.xml',
            ['mimeType' => 'text/xml']
            );
    }

}
kub@:~/GitHub/PHP-CS-Fixer(master)$ php php-cs-fixer fix test.php --diff --dry-run -v --rules=@PhpCsFixer
Paths from configuration file have been overridden by paths provided as command arguments.
F
Legend: ?-unknown, I-invalid file syntax (file ignored), S-skipped (cached or empty file), .-no changes, F-fixed, E-error
   1) test.php (class_attributes_separation, php_unit_internal_class, php_unit_test_class_requires_covers, class_definition, method_argument_space, braces)
      ---------- begin diff ----------
--- Original
+++ New
@@ @@
 <?php
-class Test {
-
-    public function actionGetHistoryRendered(int $id) {
+/**
+ * @internal
+ * @coversNothing
+ */
+class Test
+{
+    public function actionGetHistoryRendered(int $id)
+    {
         return Yii::$app->response->sendContentAsFile(
             $this->findDevice($id)->history_rendered,
             'historyRendered.xml',
             ['mimeType' => 'text/xml']
-            );
+        );
     }
-
 }

      ----------- end diff -----------

method_argument_space is the one that fixes the indent, but must be configured as:
    'method_argument_space' => ['on_multiline' => 'ensure_fully_multiline'],

@erickskrauch @bobemoe you have to provide more details what is not working in your case - would be perfect if you can make a PR with a failing test.

Closing as the reporting didn't provide the details needed to work on this.


created primeNums.js

tests for prime numbers in JavaScript
issue #3
n is the limit to the value of the prime numbers
example:
test_prime(15)
logs 2, 3, 5, 7, 11, 13

@vichitr, could you approve this in the files changed section so it counts toward Hacktoberfest? Thanks.


Support for Amber

fixes #1

It's crashing with this stacktrace, on some usecases (like entering DM session conversation):
E/AndroidRuntime(31384): java.lang.RuntimeException: Failure delivering result ResultInfo{who=null, request=3, result=-1, data=Intent { (has extras) }} to activity {yana.nostr.debug/yana.nostr.MainActivity}: java.lang.IllegalStateException: Reply already submitted
E/AndroidRuntime(31384): 	at android.app.ActivityThread.deliverResults(ActivityThread.java:5994)
E/AndroidRuntime(31384): 	at android.app.ActivityThread.handleSendResult(ActivityThread.java:6033)
E/AndroidRuntime(31384): 	at android.app.servertransaction.ActivityResultItem.execute(ActivityResultItem.java:67)
E/AndroidRuntime(31384): 	at android.app.servertransaction.ActivityTransactionItem.execute(ActivityTransactionItem.java:45)
E/AndroidRuntime(31384): 	at android.app.servertransaction.TransactionExecutor.executeCallbacks(TransactionExecutor.java:135)
E/AndroidRuntime(31384): 	at android.app.servertransaction.TransactionExecutor.execute(TransactionExecutor.java:95)
E/AndroidRuntime(31384): 	at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2574)
E/AndroidRuntime(31384): 	at android.os.Handler.dispatchMessage(Handler.java:106)
E/AndroidRuntime(31384): 	at android.os.Looper.loopOnce(Looper.java:226)
E/AndroidRuntime(31384): 	at android.os.Looper.loop(Looper.java:313)
E/AndroidRuntime(31384): 	at android.app.ActivityThread.main(ActivityThread.java:8762)
E/AndroidRuntime(31384): 	at java.lang.reflect.Method.invoke(Native Method)
E/AndroidRuntime(31384): 	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:604)
E/AndroidRuntime(31384): 	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1067)
E/AndroidRuntime(31384): Caused by: java.lang.IllegalStateException: Reply already submitted
E/AndroidRuntime(31384): 	at io.flutter.embedding.engine.dart.DartMessenger$Reply.reply(DartMessenger.java:435)
E/AndroidRuntime(31384): 	at io.flutter.plugin.common.MethodChannel$IncomingMethodCallHandler$1.success(MethodChannel.java:272)
E/AndroidRuntime(31384): 	at com.sebdeveloper6952.amberflutter.amberflutter.AmberflutterPlugin.onActivityResult(AmberflutterPlugin.kt:136)
E/AndroidRuntime(31384): 	at io.flutter.embedding.engine.FlutterEngineConnectionRegistry$FlutterEngineActivityPluginBinding.onActivityResult(FlutterEngineConnectionRegistry.java:813)
E/AndroidRuntime(31384): 	at io.flutter.embedding.engine.FlutterEngineConnectionRegistry.onActivityResult(FlutterEngineConnectionRegistry.java:432)
E/AndroidRuntime(31384): 	at io.flutter.embedding.android.FlutterActivityAndFragmentDelegate.onActivityResult(FlutterActivityAndFragmentDelegate.java:853)
E/AndroidRuntime(31384): 	at io.flutter.embedding.android.FlutterFragment.onActivityResult(FlutterFragment.java:1251)
E/AndroidRuntime(31384): 	at io.flutter.embedding.android.FlutterFragmentActivity.onActivityResult(FlutterFragmentActivity.java:652)
E/AndroidRuntime(31384): 	at android.app.Activity.dispatchActivityResult(Activity.java:8951)
E/AndroidRuntime(31384): 	at android.app.ActivityThread.deliverResults(ActivityThread.java:5987)

Do you have any idea what might cause this?

It's probably because we are decrypting in the build method, i think we will need to make a loading screen and decrypt each event async before opening the dms screen

xxiiiiii I have no idea... :(
Em 2023-12-08 15:57, Fmar escreveu:

I've commented the dms decrypt but now it is also crashing with the
same error on main > initRelays > getSingleNip51List >
Nip51List.fromEvent > signer.decrypt when initializing nip-51
blocked/search relay lists which can include private elements which
need to be decrypted.
So this in not on the build method, so something else might be causing
these.
If I debug it and slowly accept each decrypt request on amber it works,
it only crashes when needed to decrypt multiple events.
Might be something related to async simultaneously request to native
kotlin code?
Any idea how to deal with this?
--
Reply to this email directly, view it on GitHub [1], or unsubscribe
[2].
You are receiving this because you are subscribed to this
thread.Message ID: @.***>

--
ZITRON DESIGN - SINCE 2000
www.zitron.pt [3] | @.***
Links:
[1] https://github.com/frnandu/yana/pull/53#issuecomment-1847440253
[2]
https://github.com/notifications/unsubscribe-auth/AUD7IWRRFNNFQPBCQHNWPHLYIM2IJAVCNFSM6AAAAABAJJZ4E2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNBXGQ2DAMRVGM
[3] http://www.zitron.pt

I managed to fix the crash in the dms screen using the following code in dm_session_list_item_component.dart:
final provider = Provider.of<DMProvider>(context, listen: false);
try {
  EasyLoading.show(status: "Decrypting dms...");
  await provider.decryptDms(widget.detail.dmSession.pubkey);
} finally {
  EasyLoading.dismiss();
}
RouterUtil.router(context, RouterPath.DM_DETAIL, widget.detail);

I suspect when running in the build method or the main.dart it's not running inside the main ui thread and there's a race condition when talking to the native code

DartNdkPlugin for acinq event verifier was conflicting with amberflutter plugin, that was causing crashes when rejecting requests and also on nip51 decrypt (not on build methods).
Should mostly work now.
Give it a test and let me know what you think @greenart7c3
Only thing is when you manually remove permission for decrypt and don't accept "remember my choice" the decrypt per dm event will not work correctly. Can't figure out why. I'll try to resolve that later after release.

The dms are not working when not using the remember my choice option because in amber flutter there was some intent flags that are used only when there's support for receiving multiple results at once.
Made a pull request in amber flutter.
https://github.com/sebdeveloper6952/amberflutter/pull/7


First information card should be "What is depression?"

First information card (Before "Behavioral activation") should be "What is depression?" containing the below text:
What is depression?
This treatment was designed to help you with depression, which is defined as an extended period of time of at least 2 weeks in which a person experiences a depressed mood or a loss of interest or pleasure in activities that were once enjoyed, along with several other symptoms. Many people will experience at least one episode of major depression in their lifetime and it can affect people of all ages, cultures, income, education, and marital status. Depression can have a major impact on your life, including decreased optimism or motivation, low self-esteem, trouble concentrating (paying attention), self-harm, and/or suicidal thoughts and behavior. Medical problems associated with depression include heart disease, chronic pain, type 2 diabetes, substance use, fatigue, and malnutrition. Individuals with depression often keep to themselves and avoid their normal activities. This isolation can cause additional problems, such as loneliness, relationship problems, decreased job satisfaction or unemployment, and educational failure. Given all these resulting problems, the identification and treatment of depression are critical.
The specific symptoms of depression may include the following:

Feeling sad or down most of the time,
Loss of interest in usual activities,
Significant weight loss or weight gain,
A decrease or increase in appetite,
Difficulty sleeping or sleeping too much,
Feelings of agitation or irritability,
Feeling tired or loss of energy (fatigue),
Feelings of worthlessness or excessive/inappropriate guilt,
Difficulty thinking or concentrating or making decisions,
Crying spells,
Feeling hopeless,
Suicidal thoughts and/or attempts.

Although most individuals experience some form of the above symptoms from time to time, a diagnosis of depression only is made if you feel strong feelings of distress, or you are having a lot of trouble with your day-to-day functioning. Some people can identify stressful life events including loss of a loved one, financial difficulty, or job loss as a reason for their depression. However, the specific causes of depression are rarely known, and depression might start without warning. Regardless of the initial cause of depression, depression results in a specific pattern of behavior that leads to feelings of loneliness, sadness, isolation, lack of purpose, and/or hopelessness. The key to feeling better is not in identifying the root cause of depression because this is nearly impossible, but rather in understanding and changing your depressed patterns of behavior.

Do you want a swedish translation on this as well or just english?

Yes, the app needs to be complete in both English and Swedish. You can use Google translate for now.


workflows/check-nix-format.yml: pin nixpkgs (fix staging)

Description of changes
Hotfix https://github.com/NixOS/nixpkgs/issues/301268

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Good enough for a hot-fix — thank you @SomeoneSerge!

verified this fixes the issue on staging. thanks!


fight audio glitches (noises) from PluginListActivity (and samples-host-engine)

It has been an issue that the plugin preview Activity comes with somewhat buggy implementation that when we hit "Play" button the outputs comes with some noises. It is more obvious when we apply the plugin ("On" mode).
Since the noise is not reproducible (the location of noises vary every time), it is rather how we use AudioTrack.
The same kind of issue seems to occur on aap-midi-device-service (which only uses Oboe),

This does not occur on aapinstrumentsample + midi-device-service anymore.
samples-host-engine may still has the issue, but it is also suffered from inconsistent play speed, thus that should be fixed first.


[feature] Add time to youtube shortcode.

For example, {{< youtube id="blee" time="6m20s" >}}
Ty

@gaetwoo has posted his solution to this [here][1]. As youtube shortcode enhancement is tracked in that other issue. This one can be closed.
[1]:


How to use it with the UR10 robot arm in unity?

I put the Robotiq 2F_85 on the linkee of the UR10 robot arm, where the tool head should be, but the gripper failed to rotate with the arm, it just stayed horizontal. Does anyone know why and how I can put it on the URrobot in Unity and move it with the correct inverse kinematics angle movement?

Hi @SherryKKKKKKKK,
The homogeneous transformation matrix (HTM) of the Robotiq gripper is defined by a unit matrix in the project. However, to utilize the gripper in conjunction with the robot, it is necessary to modify the HTM of the gripper to align with the HTM of the robot's TCP (Tool Center Point).
The position and rotation of the robot's TCP must be determined from the robot parameters in the product manual or from the Denavit-Hartenberg parameters using the Forward Kinematics calculation.
[https://www.universal-robots.com/articles/ur/application-installation/dh-parameters-for-calculations-of-kinematics-and-dynamics/](DH Parameters for calculations of kinematics and dynamics)
Once the position and rotation of the end-effector have been aligned with the robot's TCP, the gripper needs to be attached to the robot's last joint.
I hope everything is clear, if not, please contact me at:
<EMAIL_ADDRESS>Have a great day.


style(label): remove "too-many-ancestors" comment for SentenceSubcatalog

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 83.028%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
5259

Relevant Lines:
6334

💛  - Coveralls


Hot reload doesn't work on Linux ARM (Raspberry Pi/Ubuntu)

Steps to Reproduce
All these steps are produced in VS Codium on Ubuntu 20.10 ARM version for Raspberry Pi 4 (8GB).

Following this guide (codelabs.developers.google) till step 3.
Replace 'Hello World' string with another new string. Result:

Debug console: Reloaded 1 of 548 libraries in 5,864ms.
The app Hello World text didn't change anything. It's still Hello World.

Then follow step 4 to change the with new external package.

Debug console: Reloaded 1 of 602 libraries in 2,037ms.
Just like in the step 2 (nothing change).

Logs

Logs
From Debug Console of VS Codium:
Launching lib/main.dart on Linux in debug mode...
lib/main.dart:1
Connecting to VM Service at ws://<IP_ADDRESS>:41341/Fm3XF7DHS90=/ws
Reloaded 1 of 548 libraries in 5,864ms.
Reloaded 1 of 548 libraries in 1,622ms.
Reloaded 1 of 548 libraries in 2,297ms.
Reloaded 55 of 602 libraries in 8,760ms.
lib/main.dart:17:26: Error: Cannot invoke a non-'const' factory where a const expression is expected.
Try using a constructor or factory that is 'const'.
    child: Text(WordPair.random().asPascalCase),
                         ^^^^^^
Reloaded 1 of 602 libraries in 2,037ms.

From Details Tree of DevTools (open in VS Codium):

From flutter doctor -v:
[✓] Flutter (Channel master, 2.1.0-13.0.pre.41, on Linux, locale en_US.UTF-8)
    • Flutter version 2.1.0-13.0.pre.41 at /home/ngdangtu/.local/flutter
    • Framework revision bc9d0e0a4b (4 days ago), 2021-03-11 17:25:02 +0530
    • Engine revision 1b68503bc8
    • Dart version 2.13.0 (build 2.13.0-125.0.dev)

[✓] Chrome - develop for the web
    • CHROME_EXECUTABLE = /snap/bin/chromium

[✓] Linux toolchain - develop for Linux desktop
    • Ubuntu clang version 11.0.0-2
    • cmake version 3.16.3
    • ninja version 1.10.0
    • pkg-config version 0.29.2

[✗] Flutter IDE Support (No supported IDEs installed)
    • IntelliJ - https://www.jetbrains.com/idea/
    • Android Studio - https://developer.android.com/studio/
    • VS Code - https://code.visualstudio.com/

[✓] Connected device (2 available)
    • Linux (desktop) • linux  • linux-arm64    • Linux
    • Chrome (web)    • chrome • web-javascript • Chromium 89.0.4389.82 snap

! Doctor found issues in 1 category.

Tagging @markusaksli-nc to verify this issue on Linux.

Didn't see this on an Ubuntu VM but this was on ARM @darshankawar

@ngdangtu-vn Did you have your whole dev environment on the Raspberry Pi or did you just connect to it using DevTools? I may be able to try this out.

I installed dart (sdk), and flutter manually from the official. I'm also very sure that I have set PATH for them. Funny though, when I run flutter it seems to reinstall  dart sdk. So I think now I have 2 dart sdks. One mine, the other one installed in flutter dir.

We have a 2GB Raspberri Pi 4 and Ubuntu desktop is only supported on 4GB or 8GB. Flutter only works with 64 bit but the Raspberry OS 64bit version is still in beta so we can't test this.

After update to a little newer version, thing seems fixed itself:
[✓] Flutter (Channel master, 2.1.0-13.0.pre.175, on Linux, locale en_US.UTF-8)
    • Flutter version 2.1.0-13.0.pre.175 at /home/ngdangtu/.local/flutter
    • Framework revision efbde443d2 (19 hours ago), 2021-03-18 13:40:08 -0700
    • Engine revision c4628b709c
    • Dart version 2.13.0 (build 2.13.0-149.0.dev)

... Should I close the issue?

Since you seem to be the only one to run into this so far then we can close it for now.


POC of conda.

If you have any questions to any of the points above, just submit and ask!  This checklist is
here to help you, not to deter you from contributing!

In light of this, I was hoping to show how conda support might work, and ask a couple questions about next steps.
Overall, the code itself is pretty straightforward. Miniconda has a CONDA_PREFIX env var in the same way that virtualenv has VIRTUAL_ENV.
The tricky part comes later in
https://github.com/sdispater/poetry/blob/475c6572ac3eb04d5a4136a4b01890020ae9129e/poetry/utils/env.py#L430-L438
Where the VIRTUAL_ENV env var gets set temporarily, but this wouldn't work for conda as it would expect CONDA_PREFIX to be set.  My thought there would be to tell class VirtualEnv if it is inside a conda or virtualenv, and if so, set the appropriate env var, but maybe there's a better way?
The other question was w.r.t. testing. Do you have some sense for what would be an appropriate test setup for this PR? As far as I can tell testing VIRTUAL_ENV doesn't exist.
As an aside, it's worth noting, as a workaround for installing with conda
$ VIRTUAL_ENV=/Users/thauck/src/miniconda3/envs/poetry poetry install

seems to work.

@sdispater, gonna go head and close this, but if you think this is worth doing (and you could answer my questions), I'll reopen and finish it up.


closed_categories.json file missing.

Thanks for this great repository @Wenyueh and @evison.
I was trying to understand how some of the yelp part of the code works and I think some data are missing.
More specifically:
closed_categories.json from
https://github.com/Wenyueh/LLMforRS_item_representation/blob/18f638a242798db10dff2a5a3607308154998676/item_rep_method.py#L273-L276
As you can see in this screenshot from the readme download link:

The data seems to not be there.
It is possible this is because this was "closed"/"private" data that you were not able to share publicly.
If so, I'd recommend to add this into the readme or the code as a comment so this help future reader.

Hello Marc,
Thank you for your interest in the project. The data is here:
[image: Screen Shot 2023-08-24 at 2.52.32 PM.png]
On Thu, Aug 24, 2023 at 2:33 PM Marc Ferradou @.***>
wrote:

Thanks for this great repository @Wenyueh https://github.com/Wenyueh
and @evison https://github.com/evison.
I was trying to understand how some of the yelp part of the code works and
I think some data are missing.
More specifically:
closed_categories.json from
https://github.com/Wenyueh/LLMforRS_item_representation/blob/18f638a242798db10dff2a5a3607308154998676/item_rep_method.py#L273-L276
As you can see in this screenshot from the readme download link
https://drive.google.com/u/0/uc?id=1qGxgmx7G_WB7JE4Cn_bEcZ_o_NAJLE3G&export=download
:
[image: Screenshot 2023-08-24 at 2 30 58 PM]
https://user-images.githubusercontent.com/4520383/263069854-900cc41d-a3a3-4843-b6bd-2f2793910d88.png
The data seems to not be there.
It is possible this is because this was "closed"/"private" data that you
were not able to share publicly.
If so, I'd recommend to add this into the readme or the code as a comment
so this help future reader.
—
Reply to this email directly, view it on GitHub
https://github.com/Wenyueh/LLMforRS_item_representation/issues/1, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AGVXIM5RB42LSCONA7AQFNTXW6NAHANCNFSM6AAAAAA35NYLDU
.
You are receiving this because you were mentioned.Message ID:
@.***>

@Wenyueh If I may ask, how did you create this file?

The file is created based on frequency counting of tags in Yelp and a hierarchical structure is of categories built based on the frequency counting. Basically the idea is: the most frequently occurred tags will be highest level of category; categories below them are selected based on co-occurrences counting. The code is not very organized yet and I will upload them when I cleaned them up.

Thanks @Wenyueh can't wait to see the code :)

Sorry to keep messaging on this closed issue.
I keep wondering if this method introduces temporal leakage.
CID might be more affected by it.
The naive idea is that if you use co occurrence to generate your CID or SemID then you're using data you're going to train on before training on them potentially creating an unfair advantage versus when you compare it to other methods.
Does it make sense @Wenyueh ?

Hi,
No worries and thank you for asking questions :)
The indices for CID are generated only using co-occurrences from the training dataset; thus no leaking for validation and test.
As for the indices for SemID, the co-occurrences I meant in the previous message was referring to the co-occurrences of tags, not items. Thus will not be a leakage because all methods have access to that :)
Hope it's clear!

Thanks for the answer that makes total  sense. I am guessing you're splitting your data with a temporal split hence no chance of any leakage. That's great 😃
Thanks for your answer.


Add +redhat to version for Konflux builds

The motivation is so there's a way to distinguish a Red Hat Konflux build of ec from an GitHub upstream build.
After this patch, ec version will show something like v0.4.1+redhat for a Konflux build, and v0.4.1 for the same build if it was done in GitHub.
Ref: EC-573

New revision includes Zoran's suggestion, and I added some semi-related improvements for local build testing with make dist-container.


New Crowdin translations

Enjoy!

Quick, merge before Crowdin decides to mess up this branch.
For some reason it's stuck 8 commits behind master. Annoying.


Austin update seeds

Added seed data for each recipe type so that we have data to populate once we get each route working.

Lines 2-8 was the first "starter" recipe I put in.  I only meant to put in 3 more, but put in the deviled eggs as another "starter" on accident, so I just left it there. We will eventually have more seed recipes down the line, so it shouldn't matter in the end. I just wanted to make sure I had a recipe for each type.


BITMAKER-4038: Add optional Sentry monitoring to the estela API

Description

Add optional Sentry monitoring to the estela API

Issue

https://tasks.bitmaker.dev/issues/4038

Checklist before requesting a review

[ ] I have performed a self-review of my code.
[ ] My code follows the style guidelines of this project.
[ ] I have made corresponding changes to the documentation.
[ ] New and existing tests pass locally with my changes.
[ ] If this change is a core feature, I have added thorough tests.
[ ] If this change affects or depends on the behavior of other estela repositories, I have created pull requests with the relevant changes in the affected repositories. Please, refer to our official documentation.
[ ] I understand that my pull request may be closed if it becomes obvious or I did not perform all of the steps above.

@joaquingx The Sentry configuration here seems outdated, so a fresh look at this integration is needed. Some things to improve would be that the import of Sentry should be conditional on whether the user wants it. May as well close this, or keep it open to not forget about it.


fix reloading "clientId" values from persistence

Scope & Purpose
Fix recovery of "clientId" values in Agency when restarting an agent from persistence.

[x] :hankey: Bugfix (requires CHANGELOG entry)
[ ] :pizza: New feature (requires CHANGELOG entry, feature documentation and release notes)
[ ] :fire: Performance improvement
[ ] :hammer: Refactoring/simplification
[x] :book: CHANGELOG entry made

Backports:

[x] Backports required for: 3.6

Testing & Verification

[x] This change is a trivial rework / code cleanup without any test coverage.
[x] The behavior in this PR was manually tested

http://<IP_ADDRESS>:8080/view/PR/job/arangodb-matrix-pr/13333/

http://<IP_ADDRESS>:8080/view/PR/job/arangodb-matrix-pr/13344/

http://<IP_ADDRESS>:8080/view/PR/job/arangodb-matrix-pr/13377/

Tests blue


Wording change on status messages

Screen space is limited on the UI when displaying the status messages (especially this particular message), so I shortened the wording.

@TimEvWw Mind if I de-global-ify Status class next?

@RickCarlino No Problem. That was next on the agenda anyway with the changes for reporting the pin status.


Cannot set notebook password

When I try to set password instead of token on terminal, I got some error. (also on loginpage,)
here's errors and against.

out side of container. “Can not control echo on the terminal” = docker exec -ti bash
no congirugation file => type 'jupyter notebook --generate-config`
ValueError: No JSON object could be decoded => !!!!!!stuck!!!

I want to manually edit conf file using text editor... but I can't find & install them.
It's a bug, I think.

I think this is the problem of jupyter notebook configuration in our prebuilt docker image (yunabe/lgo:latest).
Can you share the list of exact commands you run so that I can reproduce and diagnose the issue?
Thanks

I missed generate notebook config file.
below error is gone. now password works fine!.
$ jupyter notebook password
Enter password:
Verify password:
Traceback (most recent call last):
  File "/usr/local/bin/jupyter-notebook", line 11, in <module>
    sys.exit(main())
  File "/usr/local/lib/python2.7/dist-packages/jupyter_core/application.py", line 266, in launch_instance
    return super(JupyterApp, cls).launch_instance(argv=argv, **kwargs)
  File "/usr/local/lib/python2.7/dist-packages/traitlets/config/application.py", line 658, in launch_instance
    app.start()
  File "/usr/local/lib/python2.7/dist-packages/notebook/notebookapp.py", line 1571, in start
    super(NotebookApp, self).start()
  File "/usr/local/lib/python2.7/dist-packages/jupyter_core/application.py", line 255, in start
    self.subapp.start()
  File "/usr/local/lib/python2.7/dist-packages/notebook/notebookapp.py", line 380, in start
    set_password(config_file=self.config_file)
  File "/usr/local/lib/python2.7/dist-packages/notebook/auth/security.py", line 148, in set_password
    config.NotebookApp.password = hashed_password
  File "/usr/lib/python2.7/contextlib.py", line 24, in __exit__
    self.gen.next()
  File "/usr/local/lib/python2.7/dist-packages/notebook/auth/security.py", line 131, in persist_config
    with io.open(config_file, 'w', encoding='utf8') as f:
IOError: [Errno 2] No such file or directory: '/home/gopher/.jupyter/jupyter_notebook_config.json'


Import error

I am trying to import tensorflow (I have installed on 14.04 LTS and tensorflow 0.8) but it shows atributeError: module 'imp' has no attribute 'find_module'
Traceback (most recent call last): File "", line 1, in File "/home/prayalankar/anaconda3/envs/tensorflow/lib/python3.5/site-packages/tensorflow/init.py", line 23, in from tensorflow.python import * File "/home/prayalankar/anaconda3/envs/tensorflow/lib/python3.5/site-packages/tensorflow/python/init.py", line 45, in from tensorflow.python import pywrap_tensorflow File "/home/prayalankar/anaconda3/envs/tensorflow/lib/python3.5/site-packages/tensorflow/python/pywrap_tensorflow.py", line 28, in _pywrap_tensorflow = swig_import_helper() File "/home/prayalankar/anaconda3/envs/tensorflow/lib/python3.5/site-packages/tensorflow/python/pywrap_tensorflow.py", line 18, in swig_import_helper fp, pathname, description = imp.find_module('_pywrap_tensorflow', [dirname(file)]) AttributeError: module 'imp' has no attribute 'find_module'
How to proceed.

I got tensorflow  working but by installing on Python 2.7 on my conda platform without any error. Above problem is still there i checked it and i think Python has changed the find_module to reload() in 3.x so it might be the problem but i do not know how to fix this .
Still looking for solution (solid) for 3.x

In your Python 3.x shell, can you please run the following:
import imp
print(dir(imp))
print(imp.__file__)

...and let us know what it prints. The find_module() function should be available in Python 3.5, which you appear to be using, so I'm not sure why this would happen. (One possibility is that there's a file called imp.py in your PYTHONPATH, and that's causing it to get confused.)

I am getting following output. I think there is no find_module()

import imp
print(dir(imp))
['Example', 'Flask', 'SQLAlchemy', 'builtins', 'cached', 'doc', 'file', 'loader', 'name', 'package', 'spec', 'app', 'db']
print(imp.file)
/home/prayalankar/imp.py

The problem is that there's a file called imp.py in your PYTHONPATH. In particular, it looks like it's in /home/prayalankar/imp.py.
There are two options for fixing this:

Rename /home/prayalankar/imp.py to something else, so that it doesn't clash with the name of a built-in Python module, or
Change your PYTHONPATH so that it no longer includes /home/prayalankar.


Error: 'gbk' codec can't decode byte 0xac in position 2: illegal multibyte sequence

aspeak -f 296.txt -l zh-cn
Error: 'gbk' codec can't decode byte 0xac in position 2: illegal multibyte sequence
While 296.txt is UTF-8 text file.
UTF8 is more popular than GBK nowadays.

Should be fixed in v1.1.2


Johan proteomics lab

@neoformit
some suggested initial content for Proteomics Lab 😄

thanks @neoformit 😄
could you please review the changes?


Colocated routes should not include route module filename in route id to match v2 convention

Discussed in https://github.com/kiliman/remix-flat-routes/discussions/126
Originally posted by akomm May 28, 2024
Before I open it in issue, maybe doc confusion again :)
It appears that the route IDs have been altered some. I find frequently a /route suffix at the end of the ID.
Its not a frequent thing to use the ID of the routes, but there is one official in remix that is documented,  that being useRouteLoaderData(). But there are other use-cases to, I have one and had to adjust code to remove the suffix.
People who use this would have code breakage after adjusting the flat-routes to nested flat-routes because IDs of their routes changed.
I have adjusted my code to remove the suffix, but wanted to point out that you might have overlooked it.

Well, considering the + is a hybrid routing convention, I'm not sure it's a compatibility issue. Perhaps I'll add an option to strip + from route ids.

Oh its part of the hybrid, then nvm.
It was a bit unclear to me that its hybrid, I thought its an extension to the flat-routes
The title confused me, thought its separate from hybrid, but the prompt actually has hybrid in the path name:


Creation of multiple BTC accounts is not supported

[29-Dec-2017 06:28:18 UTC] PHP Fatal error:  Uncaught GuzzleHttp\Exception\ClientException: Client error: POST https://api.coinbase.com/v2/accounts resulted in a 400 Bad Request response:
{"errors":[{"id":"invalid_request","message":"Creation of multiple BTC accounts is not supported"}]}

I had this same problem with the Python API, so I think that they disabled this feature.

Hey @pktejani, as was already mentioned we don't support creation of multiple BTC accounts.

Hello. Any information about problem?


"Translate Me" command

Google Translate has an API that could be used for a translate command for Lisa.
Proposed syntax: @Lisa translate me <source language> to <target language> <text to be translated>
Docs for the Translate API: https://cloud.google.com/translate/docs
Another proposed API, if we only want to translate from Japanese: https://jisho.org/docs (I would prefer having any language available, personally)

Propose Removing the me from the command. It would flow better as:
@Lisa Translate English To Japanese Hello!


Need help with pyenv management

I am trying to manage pyenv with these commands:
zplugin ice atclone"./libexec/pyenv init - > zpyenv.zsh" atinit"export PYENV_ROOT=\"$ZPLGM[PLUGINS_DIR]/pyenv---pyenv/bin\" && export PATH=\"$ZPLGM[PLUGINS_DIR]/pyenv---pyenv/bin:$PATH\"" atpull"%atclone" pick"zpyenv.zsh" nocompile"!"
zplugin light pyenv/pyenv

It works well before I am trying to pyenv install --list and then I got error message:
mnj$ ~ pyenv install
pyenv: no such command `install'

I am not sure about how to correctly manage $PATH or maybe I am trying to use zplugin wrongly and solve trouble for which this tool wasn't created?

I'm pretty tired currently but looking at pyenv --help (after running your snippet) reveals there's indeed no install command for pyenv.

Yeah, here is a main problem. Something went wrong with installation process.
This is old issue about why install command is missing pyenv/pyenv#777
Btw, old-school pyenv installation is working as expected.

@psprint do you have any suggestions?

I can only hint how to shorten the atinit hook:
zplugin ice atclone"./libexec/pyenv init - > zpyenv.zsh" atinit"export PYENV_ROOT=\"$ZPLGM[PLUGINS_DIR]/pyenv---pyenv/bin\" && export PATH=\"\$PWD/bin:$PATH\"" atpull"%atclone" pick"zpyenv.zsh" nocompile"!"
zplugin light pyenv/pyenv

I cannot help with the installation of pyenv.

Nice, thank you, thank you for your help! It makes me easy to understand your tool.

Glad that I could help. Thank you very much for the donation!

@psprint hi again, I just noticed that Pyenv was broken...
I take snipped from your Gallery
zinit ice atclone'PYENV_ROOT="$PWD" ./libexec/pyenv init - > zpyenv.zsh' \
    atinit'export PYENV_ROOT="$PWD"' atpull"%atclone" \
    as'command' pick'bin/pyenv' src"zpyenv.zsh" nocompile'!'
zinit light pyenv/pyenv

And it doesn't work on my end. Could you help me please with that? I can't figure out where is the problem.
$ which python
/usr/bin/python

$ eval "$(pyenv init -)"
$ which python
/home/psv/.zinit/plugins/pyenv---pyenv/shims/python

@psprint hi again, I just noticed that Pyenv was broken...
I take snipped from your Gallery
zinit ice atclone'PYENV_ROOT="$PWD" ./libexec/pyenv init - > zpyenv.zsh' \
    atinit'export PYENV_ROOT="$PWD"' atpull"%atclone" \
    as'command' pick'bin/pyenv' src"zpyenv.zsh" nocompile'!'
zinit light pyenv/pyenv

And it doesn't work on my end. Could you help me please with that? I can't figure out where is the problem.
$ which python
/usr/bin/python

$ eval "$(pyenv init -)"
$ which python
/home/psv/.zinit/plugins/pyenv---pyenv/shims/python

Doesn't the output of the command indicate that it worked fine? Also, there's pyenv package.

Doesn't the output of the command indicate that it worked fine? Also, there's pyenv package.

No, it doesn't work at all because which python points to system python binary but should point to shims /home/psv/.zinit/plugins/pyenv---pyenv/shims/python

Don't know how but with pyenv package it works fine. Thank you!

@pythoninja What does the zinit look like for https://github.com/Zsh-Packages/pyenv?

zinit pack for pyenv

@tony I do not understand your question

@pythoninja sorry for the misunderstanding.  I was asking for what zinit command you ended up using to load pyenv.
I ended up using what @pschmitt gave for now


EHConsole enhancements

Consumer group :

EHConsole should NOT use the prefix Website when creating its consumer group when connecting to Event Hub.
EHConsole should delete the consumer group he created to monitor the event hub

Choice of Event Hub to monitor: For now the tool is hardcoded to monitor only ehdevices. We need to give the user the choice of monitoring the event hub of his choice

Upd. Choice of Event Hub to monitor is already implemented (in master only).

Closing as EHConsole is NOT recreating a new consumer group but instead is using the default one, which is acceptable


Added Adan Optimizer

Proposed changes
Added Adan Optimizer and the tests according to the issue #1729. Kindly go through the changes and share your thoughts.
Checklist
Put an x in the boxes that apply.

[x] I have read the CONTRIBUTING document
[x] I have run pre-commit run --all-files to format my code / installed pre-commit prior to committing changes
[x] I have added tests that prove my fix is effective or that my feature works
[x] I have updated the necessary documentation (if needed)

@angeloskath
I went ahead and added the Adan Optimizer and also modified tests. Kindly review the code and give your valuable feedback.

If Adan is added to MLX, then what's the criterion for adding optimizers?
PyTorch is more conservative in their core lib relative to Optax. The mlx-optimizers package could serve as a location for new optimizers as it already has non-traditional implementations (e.g., ADOPT, LAMB, Muon, QHAdam, etc.).

Actually, I don't think we will merge this into MLX core.  In fact @cvnad1 I will close this. @stockeh may be interested in having a PR at to mlx-optimizers.

If Adan is added to MLX, then what's the criterion for adding optimizers?

We don't have a strict criterion. But for the most part we aren't planning to add new optimizers unless there is a really compelling reason to add something.


Ship Piracy Empty Ships without any Crew

Disable and board a hostile ship (Ecliptic, Varuun, Spacer, or Crimson Fleet) and there will be no crew aboard even though the ship (when you undock will still shoot at you).

Details
Happens after you fly an unregistered ship to Wolf Station (in order to sell contraband that was onboard) rather than to a city to register it. After this all ships you board will be empty.
Game Version
<IP_ADDRESS>
New Game
Yes
Reproduction Steps
As above.

Can confirm this issue. Mod to fix and discussion on the topic here:
https://www.nexusmods.com/starfield/mods/5668

May be a duplicate of issue #268

Closing as a duplicate of https://github.com/Starfield-Community-Patch/Starfield-Community-Patch/issues/221


UI - Data - Tokens/Pools Table

There are a few corrections to a tokens/pools table

Please fix shadows for the cards except search bar at the top
Please add a separation line under the title
Please replace "pairs" with "pools"
Please change "pools/tokens" buttons to tabs
Please reduce the search bar inside the table and move it to the right
Please change the style of "trade" button
Left alignment of data inside the table
Please change body text font color
Please remove grey/white shifting of rows, just white with grey separation line.

Thanks!

New message from @katyarozenfeld
Hi, I just reviewed data - exciting, looks great! But still there are a few deltas between design and live app. Here is a list:

Title "Statistics" text style isn’t correct
Please add a separation line below the title
Body text color doesn't fit the design - main body text color is 0A2540
Is is possible to change card's shadows exactly as it is in Zeplin? As this page is full of information, shadows look slightly distractive, so the if you can make shadow more gentle would be great.
Please change arrow icons in the header of the table
Please add icon to a search box
Please change the color of "search" to D0D7DF
Please add shadow to token images - tokens with white backgrounds are problematic
Separation lines inside the table (and grey header box) should reach the edges
Please change the style of V1/V2 tags - relevant to all pages
Is it possible to fix alignment in the table? Titles and numbers should be aligned left.

Thanks a lot

From @nhindman23 https://user-images.githubusercontent.com/53524917/90064660-cea05880-dcf3-11ea-8ee4-fcfff8b7ac40.png

@pingustar Kill the ratio column for now, it's not quite the same thing between V1 and V2, so I probably shouldn't have added that.

All done, please review.

Hi, I 've just reviewed https://staging.swap.bancor.network/eth/data
Here are a few comments:

Tabs - "token"/"pool" text color  - please fix
Search - "search" text color - please fix (should be lighter). Also relevant to typing mode - need to be 0A2540.
Tabs - blue line looks broken - "trapeze" shape
Please align tabs with table content. No need to make blue line wider than tab name.
Can we fix the width of the buttons? Just as it is in Zeplin? 132 px & 132 px
Pagination - Please replace icons to what we have in Zeplin
Pagination - Please change text color

Mobile

Please move "search" box to top right (screenshot attached)
Please fix spacing in statistics card (screenshot attached)

Dark mode

I'm sorry, it feels too late - but I've prepared design only for one page in dark mode to be as a guide for you, but now I feel it wasn't enough. Therefore, I've added dark mode version of pool page here, and there are a few points that need to be changed: https://app.zeplin.io/project/5d70f6905eefcd18e1c40502/screen/5f3668ef86e30c68d2f09039/

Please let me know if you need a detailed guide for the dark mode in addition to what we have in Zeplin or do you prefer to receive the list of changes per each page?
Thanks!

@pingustar Just wanted to check whether you see my comment above. Please let me know if I should open new issue for these comments. Thanks!

I am seeing it @katyarozenfeld
If you can add a new issue and add checkboxes for each bullet point that would be great. Will help me a lot. Thanks!

Added #91.
Thanks!

Message from @katyarozenfeld

Hi, here are a few comments for data pool/token table:
* [ ]  Tabs - "token"/"pool" text color - please fix

* [ ]  Search - "search" text color - please fix (should be lighter). Also relevant to typing mode - need to be 0A2540.

* [ ]  Tabs - blue line looks broken - "trapeze" shape

* [ ]  Please align tabs with table content. No need to make blue line wider than tab name.

* [ ]  Can we fix the width of the buttons? Just as it is in Zeplin? 132 px & 132 px

* [ ]  Pagination - Please replace icons to what we have in Zeplin

* [ ]  Pagination - Please change text color

Mobile
* [ ]  Please move "search" box to top right (screenshot attached)

* [ ]  Please fix spacing in statistics card (screenshot attached)

Dark mode
I'm sorry, it feels too late - but I've prepared design only for one page in dark mode to be as a guide for you, but now I feel it wasn't enough. Therefore, I've added dark mode version of pool page here, and there are a few points that need to be changed: https://app.zeplin.io/project/5d70f6905eefcd18e1c40502/screen/5f3668ef86e30c68d2f09039/
Please let me know if you need a detailed guide for the dark mode in addition to what we have in Zeplin or do you prefer to receive the list of changes per each page?
Thanks!

Sorry @katyarozenfeld we got our wires crossed and mislead you, because this is related to your original request it should remain in the original issue. I've closed #91 now and moved your feedback back in here.
Creating a new issue in this case would only been warranted if

We already fulfilled all requests made in the original issue.
Issue had been closed and passed it's review phase (Everyone was happy with it at the time including you)
You have brand new changes/designs to make, outside of the original scope that was drawn in the original issue.

Because we didn't fully achieve your original request and you've got further feedback on it, it should remain in this issue and be re-opened if necessary until we've fully completed it.
Thanks again for your rich and consistent feedback, we'll further work on our strategy to ensure we don't give you any mixed signals going forward.

@Velua Thanks for making things clear!

[ ]  Tabs - "token"/"pool" text color - please fix

[ ]  Search - "search" text color - please fix (should be lighter). Also relevant to typing mode - need to be 0A2540.

[ ]  Tabs - blue line looks broken - "trapeze" shape

[ ]  Please align tabs with table content. No need to make blue line wider than tab name.

[ ]  Can we fix the width of the buttons? Just as it is in Zeplin? 132 px & 132 px

[ ]  Pagination - Please replace icons to what we have in Zeplin

[ ]  Pagination - Please change text color

Mobile

[ ]  Please move "search" box to top right (screenshot attached)

[ ]  Please fix spacing in statistics card (screenshot attached)

@katyarozenfeld
the v2/1 badge for darkmode is missing.
Any feedback to the latest changes.
Please disrecard the icons for now. I'll do them all at once. Might have a few questions soon about that.

Bagde - https://app.zeplin.io/project/5d70f6905eefcd18e1c40502/screen/5f3cd63d2b6ae231d674608d/.
Re feedback - will check it right now.

Just checked - everything looks great, except this one

[ ] Please align tabs with table content. No need to make blue line wider than tab name.

Thanks @katyarozenfeld we've aligned the tabs with the content, now active in production and staging, still working on the badges.

Thanks!

@pingustar I'm still seeing this. Can you please fix?
Thanks!

fixed table alignment.


add feature text-to-singing 🎤🎵

Hello 😀,
I'd like to suggest adding a text-to-singing voice synthesis feature.
https://github.com/topics/singing-voice-synthesis
Thank you -_-

I will try to get to it


Support to generate thread dump in a file

JGroups generate thread dump in the same log of the server. When dealing with suspected nodes, the logs become big and it is hard to find out the root cause.
This PR allows the developer to set a custom path to generate the thread dump.

https://issues.redhat.com/browse/JGRP-2608


OCPBUGS-15909: Revert: Pass BareMetalHost name to IPA"

This reverts commit 768af8fe4f8782fb7b3e2a0d55ffa624de5009ec.
/hold
Dualstack installs are failing since this Pr merged, it appears to be setting the hostname which results in CSR's to go unapproved.

/payload-job periodic-ci-openshift-release-master-nightly-4.14-e2e-metal-ipi-ovn-dualstack

/unhold
/test e2e-metal-ipi-sdn-bm
/jira refresh

/jira refresh

/approve
This is sad and frankly quite confusing. I guess in the next iteration, I'll just leave the dispatcher script in place.

/payload-job periodic-ci-openshift-release-master-nightly-4.14-e2e-metal-ipi-ovn-dualstack
double checking it wasn't a fluke

It passed 2x, vs a permafail in CI.  Unholding
/hold cancel

/lgtm


Remediation, Remixing, and Copyright Readings / Discussion

Read the two following short articles:

Remix Culture and Amateur Creativity: A Copyright Dilemma
Measuring Fair Use: The Four Factors

Then respond:

Highlight a passage from either article that surprised you about copyright infringement and "fair use": What surprised you?
Identify one or two "grey areas" identified in the readings that can make copyright infringement unclear.

" A violation of copyright?
Many within the cultural industries believe that any unauthorized extract taken from a pre-existing work constitutes copyright infringement. Strictly speaking, they are right. Remixes do violate the copyright in a pre-existing work, insofar as the act of creating a second work that contains elements of an original work violates both the right of reproduction (Article 9 of the Berne Convention) and the right of communication to the public (Article 8 of the WIPO Copyright Treaty) of the original author. "
So, according to this Fanfiction and Fanart is illegal because it infringes on the original authors copyright / intellectual property. When I had to study copyright law, we zoned in on Disney because they are the most active about their copyright. If you look into the legal content for Disney, you'll see how they dodge and use these laws to their advantage. There are other companies that respond to violations, but Disney is just the biggest example.

"Remixes do violate the copyright in a pre-existing work, insofar as the act of creating a second work that contains elements of an original work violates both the right of reproduction (Article 9 of the Berne Convention) and the right of communication to the public (Article 8 of the WIPO Copyright Treaty) of the original author."
I found this surprising because there are so many remixes out there, from music to film parodies, to, like Erin discussed, fanfiction and fanart. There are multiple sites that serve as platforms for these works, encouraging it, and it is strange to think that all of that is technically illegal, and thus, these sites illegal...

"The moral rights of the original author also come into play. Under Article 6bis of the Berne Convention, “the author shall have the right to claim authorship of the work and to object to any distortion, mutilation or other modification […] which would be prejudicial to his honor or reputation”. When a given song is remixed in a way that strongly decontextualizes its meaning, the author of the original work can claim a violation of moral rights."
"In other words, just because images from a cinematographic work are mixed with a specific song that does not mean that the public will stop purchasing either the original movie or the original soundtrack. On the contrary, such remixes or mash-ups may constitute free publicity for the pre-existing work."
These seem strongly contradictory.

"The moral rights of the original author also come into play. Under Article 6bis of the Berne Convention, “the author shall have the right to claim authorship of the work and to object to any distortion, mutilation or other modification […] which would be prejudicial to his honor or reputation”. When a given song is remixed in a way that strongly decontextualizes its meaning, the author of the original work can claim a violation of moral rights."
This section of the passage from "Remix Culture and Amateur Creativity: A Copyright Dilemma" was surprising to me because it essentially allows creators of music to have power to say which versions of his/her song are crap or not, I thought that was quite funny! In all seriousness though, I think that this power to the creator is a good power to possess and it gives you almost something like a safety blanket.

hah @thammer12499 we did the same section

"Existing copyright laws do not adequately address the challenges arising from the wealth of amateur creativity facilitated by the tools available within the digital environment."
Why would legislative changes not be made when the environment in which copyright applies has completely changed over the past several years? Nations that fail to protect IP infringement from occurring can often lead to a magnitude of problems including distrust from foreign investors and encouraging piracy and counterfeiting.
A common grey area identified in the articles is whether or not a remix still infringes on the original creator's copyright protections or whether they can be legally created under amateur creativity clause.

@Tonya-Velcko More like potentially illegal (or infringement) if a court decides it that way...

"One might also argue that remix works are akin to quotations protected under Article 10 of the Berne Convention. Under this Article, it “shall be permissible to make quotations from a work which has already been lawfully made available to the public, provided that their making is compatible with fair practice, and their extent does not exceed that justified by the purpose”. While quotations are often associated with literary works, the Berne Convention refers to “quotations from a work”, which may include audiovisual, musical or even photographic works. In 2011 the Court of Justice of the European Union decided in Eva-Maria Painer v. Standard Verlags GmbH and others (CJEU-C/145/10) that photography could be quoted, as long as it had been made lawfully available to the public and the name of the author was indicated. It could therefore be argued that remixing audiovisual or musical works is similar to quoting from a literary work."
I was surprised that photography was mentioned in this. I often see that photographers don't want their work being used by others regardless. One thing that I personally get confused with is, "as long as it had been made lawfully available to the public." What would be lawfully available? or not available.

hah @thammer12499 we did the same section

Oh I hadn't even noticed, lol.

Grey Area 1:
"The situation, however, remains less than clear elsewhere. In the United States, the courts are still grappling with the issue, as indicated in Stephanie Lenz v. Universal Music Corporation which has been ongoing since 2007.  A few months later, Universal Music Corporation had the video removed from YouTube claiming copyright infringement; an allegation strongly contested by Ms. Lenz."

Remix Culture and Amateur Creativity: A Copyright Dilemma
"The moral rights of the original author also come into play. Under Article 6bis of the Berne Convention, “the author shall have the right to claim authorship of the work and to object to any distortion, mutilation or other modification […] which would be prejudicial to his honor or reputation”. When a given song is remixed in a way that strongly decontextualizes its meaning, the author of the original work can claim a violation of moral rights."
I never knew that copyright infringement also implied the violation of an artist's moral rights. I guess I never saw art as a type of moral medium that reflects the creator.
Measuring Fair Use: The Four Factors
"Determining what is transformative—and the degree of transformation—is often challenging. For example, the creation of a Harry Potter encyclopedia was determined to be “slightly transformative” (because it made the Harry Potter terms and lexicons available in one volume), but this transformative quality was not enough to justify a fair use defense in light of the extensive verbatim use of text from the Harry Potter books."
I found this paragraph to be a "gray area" because it shows how determining if a work is transformative enough to be infringing on a copyright is difficult and varies from case to case. It makes you wonder if there are some pieces that purposefully infringe copyrights but do so with a degree of transformation that make it barely legal.

Example of a case resolved amicably (in a friendly deal-making way): https://www.pon.harvard.edu/daily/dealmaking-daily/in-dealmaking-with-tom-petty-sam-smith-backs-down/

"For example, in one case an artist used a copyrighted photograph without permission as the basis for wood sculptures, copying all elements of the photo. The artist earned several hundred thousand dollars selling the sculptures. When the photographer sued, the artist claimed his sculptures were a fair use because the photographer would never have considered making sculptures. The court disagreed, stating that it did not matter whether the photographer had considered making sculptures; what mattered was that a potential market for sculptures of the photograph existed. (Rogers v. Koons, 960 F.2d 301 (2d Cir. 1992).)"
I find this case to be very interesting, because if the sculptor had sculpted whatever was depicted in the photograph, this never would have been an issue. How did the photographer get a copyright on the photo? Did they own whatever was depicted? If not, could the owner of whatever was in the photograph sue the photographer? It's just a messy situation.

"A disclaimer is a statement that “disassociates” your work from the work that you have borrowed. For example, if you write an unauthorized biography of Mickey Mouse, you may include a disclaimer such as, “This book is not associated with or endorsed by the Walt Disney Company.” Will it help your position if you use a disclaimer? In close cases where the court is having a difficult time making a fair use determination, a prominently placed disclaimer may have a positive effect on the way the court perceives your use. However, generally a disclaimer by itself will not help. That is, if the fair use factors weigh against you, the disclaimer won’t make any difference."
This section seems to be saying mostly that disclaimers don't help, which was a little surprising to me. It also says "if the fair use factors weigh against you..." which leads to the idea that there may be situations where a disclaimer might help?
"In some cases, the amount of material copied is so small (or “de minimis”) that the court permits it without even conducting a fair use analysis....As with fair use, there is no bright line test for determining a de minimis use."
This section is another confusing part, because how do they determine what is small enough of an infringement for them to allow? Does allowing small infringements encourage it to happen repeatedly since there are no consequences for doing it?

"The moral rights of the original author also come into play. Under Article 6bis of the Berne Convention, “the author shall have the right to claim authorship of the work and to object to any distortion, mutilation or other modification […] which would be prejudicial to his honor or reputation”. When a given song is remixed in a way that strongly decontextualizes its meaning, the author of the original work can claim a violation of moral rights."
I found this interesting because the author can not only claim copyright on a remix of a song, which is a very popular thing in todays music, but they can also claim copyright even if the song was "Strongly Decontextualized" meaning they took parts of the song out of context.  Does that mean that copyright can be claimed if someone who wrote a song used a similar line as another song,  The author of the song that was released first could claim copyright even if the other author had never heard it?

"When a given song is remixed in a way that strongly decontextualizes its meaning, the author of the original work can claim a violation of moral rights."
I found this interesting. In the past few years, I have seen a larger influx of remixes posted to YouTube intended to be crude jokes. They haven't been taken down on the site, but under legal grounds they could be.
Though, this becomes a grey area under Article 10 of the Berne Convention. It “shall be permissible to make quotations from a work which has already been lawfully made available to the public, provided that their making is compatible with fair practice, and their extent does not exceed that justified by the purpose”.

Collecting some excellent questions being raised here:

How did the photographer get a copyright on the photo?  (thanks @debbie-evans )
'"One thing that I personally get confused with is, "as long as it had been made lawfully available to the public." What would be lawfully available? or not available."' (thanks @jbg5721 )
(my distillation of several posts): Are we seeing tension between the international Berne convention and US lawcourts on remixing culture?

"Determining what is transformative—and the degree of transformation—is often challenging. For example, the creation of a Harry Potter encyclopedia was determined to be “slightly transformative” (because it made the Harry Potter terms and lexicons available in one volume), but this transformative quality was not enough to justify a fair use defense in light of the extensive verbatim use of text from the Harry Potter books. (Warner Bros. Entertainment, Inc. v. RDR Books, 575 F.Supp.2d 513 (S.D. N.Y. 2008).)"
What? How could a Harry Potter Encyclopedia not have quotes from the books? It's about the Harry Potter world! How can they say that the fair use is transformative because of the definitions of terms, while also saying it is infringement for the same reasons?

"YouTube’s Content ID software analyzes samples of musical works provided by the recording industry and collective management organizations and compares them with the videos uploaded to the website. The software establishes a link between an existing work and an uploaded work such as a remix. If the content matches, the video may be automatically blocked or the sound muted and the user is automatically informed by e-mail that the material has been disabled “as a result of a third-party notification claiming that this material is infringing”.(WIPO, Rostama)."
How can the software tell that the users videos is infringing, does it take each content and compare it to each other, also what determines the user content is good enough to be consider a remix, and what if the new remixed content takes viewership from the original work?

Gray Area 2 ("Measuring Fair Use: The Four Factors"): "Some people mistakenly believe it’s permissible to use a work (or portion of it) if an acknowledgment is provided."
This short passage is a grey area because, again like the last one, there is a line that has to be drawn somewhere but there is always a case where we don't know if the line was passed or not. It is very hard to determine where permission may be granted to pass.

Highlight a passage from either article that surprised you about copyright infringement and "fair use": What surprised you?
 A few months later, Universal Music Corporation had the video removed from YouTube claiming copyright infringement; an allegation strongly contested by Ms. Lenz."
The copyright claims that YouTube makes have always surprised me. I watch YouTube and I notice that a lot of YouTubers are always careful not to have music playing in the background because they don't want to get copyrighted. I understand that people profit and make a living off of YouTube but so do other people on platforms like Instagram and Tik Tok. Music is played on Instagram and Tik Tok without copyright claims. The YouTube strict copyright rules on music in the background of videos has always surprised me.
Identify one or two "grey areas" identified in the readings that can make copyright infringement unclear.
"When you review fair use cases, you may find that they sometimes contradict one another or conflict with the rules expressed in this chapter. Fair use involves subjective judgments, often affected by factors such as a judge or jury’s personal sense of right or wrong. Despite the fact that the Supreme Court has indicated that offensiveness is not a fair use factor, you should be aware that a morally offended judge or jury may rationalize its decision against fair use."
This seems like a grey area because it is based on others and if they deem it wrong. It seems that depending on who you are dealing with, things could end differently, which makes things unclear and hard to understand.

"YouTube’s Content ID software analyzes samples of musical works provided by the recording industry and collective management organizations and compares them with the videos uploaded to the website. The software establishes a link between an existing work and an uploaded work such as a remix. If the content matches, the video may be automatically blocked or the sound muted..."
This is interesting that YouTube has a software that can analyze weather or not something is copyright. With there being a lot of gray space when it comes to copyright it doesn't seem like a computer would be able to accurately tell the difference between something that is a copyright violation and a remix. Then it takes it down automatically on its own without any actual people involved in the decision.
"The situation, however, remains less than clear elsewhere. In the United States, the courts are still grappling with the issue, as indicated in Stephanie Lenz v. Universal Music Corporation which has been ongoing since 2007.  A few months later, Universal Music Corporation had the video removed from YouTube claiming copyright infringement; an allegation strongly contested by Ms. Lenz."
This is a grey area because Ms. Lenz could argue the content of the video wasn't intentionally supposed to be the song in the background, but instead the children playing. But then someone may copy music and just put a video up with it and claim their intent was to show a video not copy the music. When in reality the video could just be a scapegoat to be able to share the music as their own.


Update ci.yml

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.13%. Comparing base (81f209a) to head (ec85c1d).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #832      +/-   ##
==========================================
+ Coverage   95.11%   95.13%   +0.01%
==========================================
  Files         127      127
  Lines        5036     5036
==========================================
+ Hits         4790     4791       +1
+ Misses        246      245       -1

Flag
Coverage Δ

unittests
95.13% <ø> (+0.01%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Code location of Entities

Where is the location in the code where you add the entities?
I do only see 3 entities for MQTT and want to look into the code to add some more and learn a bit:

Can you please give me a hint where I can find the location?

@ttvt can you please have a look into the issues so this Addon can keep alive?

I found it!


Data values files

still in draft.
implements this proposal: https://github.com/vmware-tanzu/carvel-community/tree/develop/proposals/ytt/002-raw-data-values for https://github.com/vmware-tanzu/carvel-ytt/issues/381
this PR also:

adds or_add=True to @overlay/replace so that when map key does not match, replace would fallback to just adding map item
relaxes data values given over cmd line (--data-values-* family) to not require existing values in the data values overlays

updated HasTemplating() to accept yamlmeta.Node. looks better!

This looks great to me.
The conversation about organizing tests really ought to take into account all --data-value... flag functionality; we'll peel that off for another time.
Thank you for your contribution, Mr. Kalinin.


Provide framework for a new generation of WM microservices

Impact of the new feature
New and isolated system with no impact in the current services
Is your feature request related to a problem? Please describe.
As we have been discussing since the Fall 2023 O&C week, there is a need to provide better tools, automation, simple and modernized software stack allowing DevOps (and non-core developers) to feel more confident with the WM stack and workflow, such that new WM microservices can be easily prototyped and put into production, to satisfy the needs of the stakeholders and the CMS collaboration.
Describe the solution you'd like
There are mainly 2 goals with this META issue:

provide a core functionality for the next generation of WM Microservices (core HTTP functionality, software stack, basic/common REST APIs, monitoring, CI/CD pipeline, etc)
provide tools to bootstrap new WM microservices, e.g.: create a basic repository structure, create the skeleton of a new microservice, create dockerfiles, create deployment/services manifests, etc.

As we create the sub-tasks, we need to edit this description and add all of them below.
Describe alternatives you've considered
None
Additional context
None

Closing as a duplicate of https://github.com/dmwm/WMCore/issues/11821 (even though this one came in earlier).


Winkler/show more objects

resolves #571

Description

Run SHOW TERSE OBJECTS
If we see 10K results
Fall back to querying the information schema

Checklist

[X] I have read the contributing guide and understand what's expected of me
[X] I have signed the CLA
[X] I have run this code in development and it appears to resolve the stated issue
[x] This PR includes tests, or tests are not required/relevant for this PR
[X] I have opened an issue to add/update docs, or docs changes are not required/relevant for this PR
[X] I have run changie new to create a changelog entry

This looks like an interesting one to test, lol

I could use some help in a couple areas on this @mikealfare @dbeatty10:

Ensuring what I have here is performant. In particular do you see any major red flags with holding (up to) 10 10k row agate tables in memory and then merging them?
Code readability. I worked around a few jinja limitations here, namely the inability to update a variable's value in the context of a for loop when that variable is defined outside the loop. Someone smarter than me may have a better approach.
How to test this.

You could also create the loop in the models() fixture:
@pytest.fixture(scope="class")
def models():
    my_models = {"my_model_0.sql": "{{ config(materialized='table') }} select 1 as id;"}
    for view in range(1,15000):
        my_models.update({f"my_model_{view}.sql": "select * from {{ ref('my_model_{view-1}') }};"})
    return my_models

Hey @mikealfare thanks for that example. I borrowed from it and got a successful test run on my local 👍 .
There are a few modifications in this version vs. yours:
class TestListRelationsWithoutCaching:
    @pytest.fixture(scope="class")
    def models(self):
        my_models = {"my_model_0.sql": _TABLE_1_SQL}
        for view in range(1, 10100):
            my_models.update({f"my_model_{view}.sql": _VIEW_X_SQL})

        return my_models

HOWEVER, it took about 2 hours for this to run on Snowflake. Is that something we are concerned about? Should we perhaps override the list_relations_without_caching macro to use a lower count of objects before triggering the loop just for the purpose of integration testing? Use a dedicated warehouse with higher thread count?

Hey @mikealfare thanks for that example. I borrowed from it and got a successful test run on my local 👍 .
There are a few modifications in this version vs. yours:
class TestListRelationsWithoutCaching:
    @pytest.fixture(scope="class")
    def models(self):
        my_models = {"my_model_0.sql": _TABLE_1_SQL}
        for view in range(1, 10100):
            my_models.update({f"my_model_{view}.sql": _VIEW_X_SQL})

        return my_models

HOWEVER, it took about 2 hours for this to run on Snowflake. Is that something we are concerned about? Should we perhaps override the list_relations_without_caching macro to use a lower count of objects before triggering the loop just for the purpose of integration testing? Use a dedicated warehouse with higher thread count?

This is now out of date right? No longer doing 10k, and in fact only about 100.

@VersusFacit thanks so much for the great review and pro tip on using namespace variables which made this so much easier. I believe this is ready for another round of review with additional macro abstraction, tests, and a tweak to the termination logic as a result.


net/tcp: reset the dupack counter.

Summary
After setting the retransmission flag, we need to set the dupack counter to 0.
Impact
N/A
Testing
Locally verified.

@jerpelea  Done


Request: Add Python type hinting to pyslang

Pyslang does not currently appear to be configured/set up to support strong typing at all, making it a bit difficult to use with modern IDEs (which can help suggest whether a method actually exists, etc.).
It would drastically increase the usability of this library if the typing information (which is presumably strong in C++'s type system) was transferred to pyslang.

I agree that this is nice to have but it's not something I have time to spend on any time soon. I'd be happy to accept a PR though if you want to tackle it.


Feature: Add Container runner support for declarative yaml file testing method

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind documentation

/kind tests

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area commands

/area pkg

/area events

What this PR does / why we need it:
Add support for container runner to execute tests inside a container which is also part of "add support for testing falco rules using declarative YAML files in event-generator". The implementation idea is here
Which issue(s) this PR fixes:
Part of GSoC 2024 project "Falco: Upgrading event-generator and automating Falco performance testing"
https://github.com/falcosecurity/evolution/issues/362

Special notes for your reviewer:
cc @alacuku @jasondellaluce

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: GLVSKiriti
Once this PR has been reviewed and has the lgtm label, please assign leogr for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

LGTM label has been added.  Git tree hash: 2956b053a423ce241e0a151f7fe387f991c29044

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: alacuku, GLVSKiriti
Once this PR has been reviewed and has the lgtm label, please assign leogr for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/approve

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: alacuku, GLVSKiriti
Once this PR has been reviewed and has the lgtm label, please assign leogr for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is APPROVED
Approval requirements bypassed by manually added approval.
This pull-request has been approved by: alacuku, GLVSKiriti
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


add Selection Sort implementation in javaScript

add Selection Sort implementation in javaScript

@akshitagupta15june  I have contributed as a part of hacktober fest. please add hacktoberfest-accepted label to the PR.
Thanks.

already available


Automated Package Upgrade

:tada: This PR is included in version 25.5.16 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


add null redeemers logic to languages in finalizeTx

Closes https://github.com/Plutonomicon/cardano-transaction-lib/issues/380
In particular:

We can now send value to a script address without requiring a dummy minting policy to mint something - it turns out that a redeemer was required with our current logic. The Alonzo cddl has specific requirements for empty redeemers found here https://github.com/input-output-hk/cardano-ledger/blob/master/eras/alonzo/test-suite/cddl-files/alonzo.cddl#L123
Some PlutusV2 info can be found here also https://github.com/input-output-hk/cardano-ledger/blob/81a309fa6410d4216724a3eb32e4141da40733e9/eras/alonzo/test-suite/cddl-files/alonzo.cddl#L117

I tested this on a contract I'm working on elsewhere locally and the transaction completes without requiring the extra minting policy/redeemer.

This is probably going to conflict with #340, but it's needed critically so we should merge it sooner rather than later


Update to support django 2.0-3.0

Codecov Report

Merging #3 into develop will increase coverage by <.01%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop       #3      +/-   ##
===========================================
+ Coverage    99.43%   99.43%   +<.01%
===========================================
  Files           13       13
  Lines          884      885       +1
===========================================
+ Hits           879      880       +1
  Misses           5        5


Can customize MetadataProvider

Can customize MetadataProvider

hey @waldrix thanks for this. could you elaborate more on this contribution?

Hi @faniereynders,
I work with a large and modular application API configured with further level "api/{domain}/{controller}/{action}/{id}".
So I need to intercept the creation of metadata to filter and/or process before returned.
The best way I see is to make polimorfic MetadataProvider.BuildMetadata and add an overload to WebApiProxyExtensions.RegisterProxyRoutes to pass custom metadata-provider.
This is an example:
`
namespace MyAppNamespace
{
public class MyAppMetadataProvider : MetadataProvider
{
public SinMetadataProvider(HttpConfiguration config)
: base(config) { }
	protected override Metadata BuildMetadata(HttpRequestMessage request)
	{
		Metadata metadata = base.BuildMetadata(request);

		//Process or manipulate metadata...

		return metadata;
	}
}

}
//During application start-up
config.RegisterProxyRoutes(new MyAppMetadataProvider(config));
`
Thank you for your project!
Marco.


Telemetry opt-out for all users of a project?

Hi, according to the README of this project, it is possible to disable telemetry by setting an environment variable - however, this would only work to disable telemetry on my own system.
If I am working on an open-source project which includes an IBM library, is there a way to apply the opt-out for all those people that my own project is distributed to? As they are unlikely to be interacting with the IBM libraries directly, the telemetry would likely get overlooked.

Hi @joepie91 - thank you for your question. How are you distributing your project?
If the latter, what about committing the initial .env file that includes the opt-out environment variable documented here.


TDE installation: Typo when referring to path between text and code

Small typo:
The incipit says we assume the files are in C:\EKM.
The paths listed within the code are referring to C:\EKM_files

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d61685ee-fa58-d14a-b611-040c89372dcc
Version Independent ID: dfbcf396-28e6-0fd2-e7cc-3178d3c7f4f2
Content: Enable TDE on SQL Server Using EKM - SQL Server
Content Source: docs/relational-databases/security/encryption/enable-tde-on-sql-server-using-ekm.md
Product: sql
Technology: security
GitHub Login: @shohamMSFT
Microsoft Alias: shohamd

@1Dimitri -- thank you for catching this.  I am updating the article.