python library can't handle bare Tuple<T,S> return type from Arduino Library

Describe the bug
When an Arduino function with return type Tuple<T,S> (e.g Tuple< int, const char*>) They Python library fails with ValueError: top level type can not be tuple.  If instead an Object<T,S> is returned the system works fine.
This may be purely a documentation issue (or even PEBCAK) rather than a "bug" since I can't seem to find anywhere where it mentions Tuples cant be returned "bare". The only hint I can find is here and here where it is mentioned Objects<> preserve internal structure.
NOTE: This is with Python3.9 on a Windows system. No Linux system handy to test right now but I am 99% certain that it is not an OS level issue.
The Traceback is:
File "test_tuple_rpc.py", line 5, in <module>
    a = ...\simple_rpc.SerialInterface("COM12")
  File "simple_rpc\simple_rpc.py", line 58, in __init__
    self.open(load)
  File "...\simple_rpc\simple_rpc.py", line 208, in open
    super().open(handle)
  File "...\simple_rpc\simple_rpc.py", line 149, in open
    self._get_methods()
  File "...\simple_rpc\simple_rpc.py", line 123, in _get_methods
    method = parse_line(index, line)
  File "...\simple_rpc\protocol.py", line 124, in parse_line
    method = _parse_signature(index, signature)
  File "...\simple_rpc\protocol.py", line 69, in _parse_signature
    method['return']['fmt'] = _parse_type(fmt)
  File "...\simple_rpc\protocol.py", line 31, in _parse_type
    raise ValueError('top level type can not be tuple')
ValueError: top level type can not be tuple

To Reproduce
Steps to reproduce the behaviour:
Load test_tuple_rpc.ino on Arduino:
#include "simpleRPC.h"

void setup() {
    Serial.begin(9600);
    while(!Serial) {}
}

//Object<int, const char*> test_func()
//{
//    Object<int, const char*> t ={0, "OFF"};
//    return t;
//}

Tuple<int, char> test_func()
{
    Tuple<int, char> t ={0, "O"};
    return t;
}

void loop() {
    interface(Serial, test_func, "test_func:");
}

Run test_tuple_rpc.py on desktop machine:

a = simple_rpc.SerialInterface("COM12")
b = a.test_func()
print(b)
a.close()

Expected behavior
If it is expected that Tuples can't be top level return types on their own then perhaps that needs to be explicitly mentioned in the docs.
If Tuples are expected to be top level return types then perhaps the python code could "cast" them to Object on the python side? That second option sounds like it would break stuff. Alternatively Tuple and Object could be merged to a single type (if so I personally prefer the Tuple name to match the C++ equivalent of Vector)

The internal structure of both Tuple and Object types are nested, e.g., Tuple<char, int, float> is shorthand for Tuple<char, Tuple<int, Tuple<float, Tuple<>>>>.  If these types were merged, data in such a structure would be presented to the caller as an overly complicated nested structure, e.g., ('a', (10, (1.2))) instead of the expected ('a', 10, 1.2).
To circumvent this, we need two types of these objects, one that serialises to a flat list and one that has an explicit internal structure. To stick with the previous example, Object<char, int, float> is shorthand for Object<Tuple<char, Tuple<int, Tuple <float, Tuple <>>>> and data in such a structure is presented to the caller as a simple tuple, e.g., ('a', 10, 1.2).
So in a sense, the Object type places the parentheses around the values. This however means a bare Tuple no longer has a representation for the caller.
I will try to explain this in the documentation as well.

I tried to explain it in this note.

Yeah after playing with it more I see the concept and understand the idea. Indeed merging them makes little sense. Perhaps my confusion is purely based on semantics about what the flat type is called and what the nested type is called. In a sense I was thinking of Object as the flat one, perhaps due thinking about them like structs in C, and Tuple as the nested one.
Regardless this was my mistake and I agree on all points you have made. I obviously missed the note! Sorry for the noise. Feel free to close the Bug Report. As always thank you for the excellent library
P.S
As an aside, I personally prefer to use the STL, even on Arduino, so I have patched your C++ library to at least support std::string, but I could likely include support for std::vector and std::array (or others). Is that something you are interested in? If so I can open a feature request on the other repo and eventually put in a PR for them. I don't mind maintaining internal patches for the stuff we are working on but I only bring it up because support for Arduino String is there. I understand what we are doing is somewhat niche (power management for an RF system) so I don't want to overstep.

I would have preferred using the STL as well, but to my knowledge it is not distributed by default with the Arduino cores. If this is the case, it may be a bit more difficult for an end user to use this library. Of course I could be wrong here.

I just thought I could give it a go, but the standard installation does not seem to work, at least not in my setup. As soon as I include ArduinoSTL.h, I get the following errors.
.../libraries/ArduinoSTL/src/del_opvnt.cpp:25:58: error: 'nothrow_t' in namespace 'std' does not name a type
 _UCXXEXPORT void operator delete[](void* ptr, const std::nothrow_t& ) throw(){
                                                          ^~~~~~~~~
.../libraries/ArduinoSTL/src/del_ops.cpp:25:50: error: 'std::size_t' has not been declared
 _UCXXEXPORT void operator delete(void* ptr, std::size_t) throw(){
                                                  ^~~~~~
.../libraries/ArduinoSTL/src/del_opnt.cpp:25:56: error: 'nothrow_t' in namespace 'std' does not name a type
 _UCXXEXPORT void operator delete(void* ptr, const std::nothrow_t& ) throw() {
                                                        ^~~~~~~~~
.../libraries/ArduinoSTL/src/del_opvs.cpp:25:53: error: 'std::size_t' has not been declared
 _UCXXEXPORT void operator delete[](void * ptr, std::size_t) throw(){

Mini rant to start: I honestly hate how Arduino pushes this weird C within C++ style of programming. I understand they are trying to be beginner friendly but I feel it creates a bunch of weird corner cases when you are trying to do something a little more involved. Mini rant over.
So honestly I have not used ArduinoSTL.h but those errors seemed strange. A quick Google search points to these threads:  and  which tl;dr suggest changing #include <ArduinoSTL.h> to #include "ArduinoSTL.h" or changing Arduino IDE version
All that said the way I use the STL is to include -lstdc++_nano in the build flags. For the Teensy line of boards I modify boards.txt > teensyXX.build.flags.libs to include the additional library. For Arduino it is somewhat more involved, requiring either arduino-cli or modifying other .txt. files (some info here ). The nice thing about lstdc++_nano is it does not throw, is relatively light weight and imo fulfills the role of ArduinoSTL.h.
Of course modifying Arduino files is daunting for many users so I understand that any STL inclusion would cater to a niche of a niche.

Changing the <> to "" did not help. I am also not sure whether this library is still maintained.
I mainly use arduino-cli for my projects and adding a build flag seems to be rather straightforward. Do you perhaps have an example project where std::string is used together with build options, include and library paths?
I would not mind adding some optional extra complexity. We could think about an additional include for STL support in conjunction with some build instructions.

I opened discussion #24 for this topic.


User error, I am sure

I have Task installed and I ran it in the mp3binder dir. it looks like it was successful, but when I try to run, I get the zsh: command not found.
Task and Go are new to me, so i am sure this is a user error.  Any suggestions? Working on a Mac.
user@audiobooks mp3binder-main % task fatal: not a git repository (or any of the parent directories): .git task: [default:test] go test -cover -race ./... task: [default:prepare] mkdir -p dist ?   	github.com/crra/mp3binder/cmd/tui	[no test files] ?   	github.com/crra/mp3binder/io/rewindingreader	[no test files] ?   	github.com/crra/mp3binder/mp3binder	[no test files] ?   	github.com/crra/mp3binder/mp3binder/tags	[no test files] ok  	github.com/crra/mp3binder/cli	(cached)	coverage: 68.6% of statements ok  	github.com/crra/mp3binder/encoding/keyvalue	(cached)	coverage: 100.0% of statements ok  	github.com/crra/mp3binder/slice	(cached)	coverage: 17.9% of statements ok  	github.com/crra/mp3binder/value	(cached)	coverage: 100.0% of statements task: [default:build-for] go build -trimpath -ldflags="-w -s -X main.name="mp3binder" -X main.version="" -X main.realm="mp3binder" -extldflags '-static'" -a -buildvcs=false -o dist/darwin_amd64/mp3binder ./cmd/tui

I'll look into it.

I was able to resolve. Found the app in the darwin folder, and moved. All
at this moment looks to be working (calling the command). Have not tested
on files yet
On Fri, Mar 24, 2023, 11:58 AM crra @.***> wrote:

I'll look into it.
—
Reply to this email directly, view it on GitHub
https://github.com/crra/mp3binder/issues/38#issuecomment-1483275598, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ABEBBWHHQL5VFHZB7EKF4TLW5XVGFANCNFSM6AAAAAAWEKPBA4
.
You are receiving this because you authored the thread.Message ID:
@.***>

Let's start step by step: did you check out via git or did you just unzip a snapshot?
According to the error log you may did the later. You should use the git clone https://github.com/crra/mp3binder.git command. The reason for this is, that the build script uses the git history/tags to "bake in" the version number in the final binary. If you call the build command in a non-git directory this just fails.
However you could also use the pre-built binary releases ;)

I was able to resolve. Found the app in the darwin folder, and moved.
Feel free to come back to me if there is any issue.


Installation process (help needed)

how can i install and start using meh? there is a .xcodeproj file in the repo that i opened in xcode, but when i ran it, it said build succeeded, but then idk what to do. could you please help me out

It's a CLI program so the only way to install it is to copy the built executable to somewhere in your $PATH environment variable. I made this several years ago and haven't really gotten round to working on it, I'd recommend using this instead. I believe it can built as an app through Xcode if that's what you're looking for.

thank you for the quick reply. i came to your project from macfeh, bc macfeh is very outdated and it can't be built in xcode anymore. i'ld like to avoid xcode at all costs actually. if i understood correctly i just need to copy project.pbxproj to my /usr/local/bin and it should work? or what is the built executable exactly? (i come from linux, so mac development is new to me)

You can either build it from terminal by negating to (where you saved the project) and running the command "clang meh.m -x objective-c -framework Cocoa -o meh" then copy the executable called "meh" in the project folder, to your $PATH or alternatively open the xcodeproj, hit build, then on the side column under a folder called "Products" will be an executable called "meh", right click on it, Show in Finder then copy that $PATH.
There isn't a help dialog atm, I didn't get around to it, but there are few arguments you can use when running, but I don't think any are especially import or even implemented so I wouldn't worry about them, just run meh . Good luck, because it's certainly not finished and will like crash a lot.

well, i got 4 warning generated after compiling it, and after adding the executable to path it worked fine, except the keybinds, none of those worked. unfortunately idk anything about C, so i can't really those deprecated warnings

Yeah, they old deprecated methods still work, but may be phased out in future releases of Mac OS. Sorry about the state I left this in, I might get around to updating it eventually, but I'm quite busy at the moment so I couldn't say when.


[Feature]

Feature :rocket:
Fetching song lyrics: -lyrics   (Sukesh)
Objective :pushpin:
Let's say if someone has given a command as -lyrics

It will get the lyrics of the song.

Features to be added / modified :ballot_box_with_check:

It gets the lyrics of the song.

/assign


Support .dockerignore

First off, awesome project! I use it on every repo and it's made my life (and my teams' lives so much better).
Since you have such a good collection of what should be ignored for each language/framework/etc, have you ever thought about expanding it to .dockerignore files as well? The syntax is slightly different, but it could be really useful.
I could see this working 2 ways:

Extend https://www.github.com/dvcs/gitignore to include the equivalent .dockerignore (and .patch) files and serve them here as well.
Automatically convert the final rendered .gitignore files to .dockerignore format (with things like prepending ** to directories).

This might be tricky because there are cases where there isn't 100% parity. For instance, you commit .rc type files for linters, tools, etc or test folders to git, but you generally don't want to include them in your containers.

Thanks for the kind words.  I haven't really through about creating .dockerignore, but that sounds like it would be a great addition.
One of the projects I want to work on is extracting the template generation engine into it's own project.  With the guts of what generates its separate, it think it would be fairly easy to modify the engine to handle all of the use cases for docker.
Another thing I wanted to comment on is separating docker ignore's into their own front end project.  One of the original decisions behind gitignore.io was to ensure that it only does one thing well.  It would probably make sense to create a dockerignore.io or something in order to make a project that handles docker files.
That being said, I'm all for helping to figure out a way to make docker ignore templates more accessible.
What do you currently do when you're looking for .dockerignore templates?

I'm going to turn the gitignore project into a monorepo which should help break up the different parts of this project into a better organizational hierarchy.  After I separate this out, it should be easy to figure out what the dockerignore engine looks like.


Use official fluentui_system_icons package

Is your feature request related to a problem? Please describe.
Given that Microsoft is publishing an specific package fluentui_system_icons (https://pub.dev/packages/fluentui_system_icons), we should:

Deprecate or potentially remove our FluentIcons class
Add new dependency
Update the example to use the official package. For now we will loose the search feature, but I'm going to notify MSFT team with our solution via generator in https://github.com/microsoft/fluentui-system-icons/issues/377

Describe the solution you'd like
Use the official FluentIcons package.
Describe alternatives you've considered
N/A
Additional context
N/A

We used to use that iconset from microsoft before (https://pub.dev/packages/fluent_ui/changelog#004---22022021), but a lot of icons are missing and it doesn't look native. Using the fonts provided by microsoft itself is better, imo.
One thing that I've experimented is, if already in the Windows platform, we don't need to export the windows asset because the fluent ui icon set font is already installed in the system. You can find the icon list here. FontFamily name is Segoe MDL2 Assets
More info:

https://docs.microsoft.com/en-us/uwp/api/windows.ui.xaml.controls.fonticon?view=winrt-22621#examples

After, the microsoft icon library has certainly evolved in the last months...
(And according to what you said above, it was not the official microsoft lib that you used?)

it was not the official microsoft lib that you used?

it was the same icon set


uninitialized constant PdfjsViewer (NameError)

In production mode I got this error
config/routes.rb:17:in  block in <top (required)> : uninitialized constant PdfjsViewer (NameError)
My routes.rb
 mount PdfjsViewer::Rails::Engine => "/pdfjs", as: 'pdfjs'
In development mode everything is ok

I'm pretty sure that your whole production environment is broken. Can you load any other dependency?

I have this issue before, what I'm doing to fix this is, remove mount PdfjsViewer::Rails::Engine => "/pdfjs", as: 'pdfjs'from routes.rb and gem 'pdfjs_viewer-rails' from Gemfile
then bundle
after that
I put the gem 'pdfjs_viewer-rails'  to the Gemfile and bundle install
then make sure the pdfjs_viewer-rails is loaded
then I put this mount PdfjsViewer::Rails::Engine => "/pdfjs", as: 'pdfjs' to my routes.rb
now its work

@roomaroom are you using Spring? Maybe spring cached a corrupt state. 😐

I've just run the project now on Rails 7 and it's working as expected.
This issue is 5 years old, Im guessing it is no longer relevant.
Recommend close.

@evolve2k Thanks for your feedback. I'm closing the issue. If the problem comes up again, we can reopen.


nexrad-decode summarization API, add common traits

This introduces a new nexrad-decode::summarize API for producing aggregate statistics from messages which ease understanding of the radar's current behavior or inspection of volumes/chunks' contents.
Additionally, this derives common traits more consistently across structures, and it introduces some custom Debug implementations where they were missing.

Force-pushed to main due to rebase from Github losing signatures.


[$500] user have to press two times on Use current location

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 1.3.79-3
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @gadhiyamanan
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1696574867561759
Action Performed:

click on FAB and select Request money
go to distance tab
click on Start
enter any character which will suggest you location
click on Use current location

Expected Result:
current location should be applied as start point
Actual Result:
on first click suggestion closes and on second click current location applies
Workaround:
UnKnown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[x] Android: mWeb Chrome
[ ] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos

Android: Native

Android: mWeb Chrome

https://github.com/Expensify/App/assets/38435837/6d22bc02-bda8-4d65-b72f-d95f1c7d2ff3

iOS: Native

iOS: mWeb Safari

https://github.com/Expensify/App/assets/38435837/1e4c3b13-0b4d-4ad1-907b-2a7ac65f2ff5

MacOS: Chrome / Safari

https://github.com/Expensify/App/assets/38435837/226bb51e-aeca-4418-ae31-76c3599ac1f8
https://github.com/Expensify/App/assets/38435837/d5489cd7-7756-43b9-a02b-197a6b8a82d5

MacOS: Desktop

https://github.com/Expensify/App/assets/38435837/72c2ea95-9265-40be-bd0c-9dc6ae7f4bb0
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~013503150cd677c799
Upwork Job ID:<PHONE_NUMBER>031705088
Last Price Increase: 2023-10-09

Proposal
Please re-state the problem that we are trying to solve in this issue.
The user has to press the Use current location button twice before the button actually registers a click if the address search suggestions are visible.
What is the root cause of that problem?
The dismissal of the address search suggestions moves the button which prevents the click event from being registered.
What changes do you think we should make in order to solve the problem?
Use a fixed position for the button.
What alternative solutions did you explore? (Optional)
None.

Proposal
Please re-state the problem that we are trying to solve in this issue.
The location button is not clickable because it moves when the autocomplete receives the onBlur event.
What is the root cause of that problem?
Because onBlur is processed before onClick (causing the button to move), the UserCurrentLocationButton never receives the onClick event.
What changes do you think we should make in order to solve the problem?
Since onMouseDown is processed before onBlur, we can use onMouseDown (desktop) and onTouchStart (mobile) to intercept the action and prevent the onBlur event from propagating.
onMouseDown={(e) => {e.preventDefault()}}
onTouchStart={(e) => {e.preventDefault()}}
This allows the UserCurrentLocationButton to be triggered without any layout changes and without interfering with the operation of the autocomplete field.
What alternative solutions did you explore?
N/A

The proposal from @graylewis does the trick and I think we can proceed with it.
Solutions proposed by @akinwale involve relocation of the Use current location button which, I think, is something we would like to avoid.
🎀 👀 🎀 C+ reviewed

I'm expecting to submit a PR in the next few hours for this issue.

Heading OoO until Oct. 25 so reassigning this so it can be paid on time 👍

PAYMENTS TO BE MADE OCT 23

@gadhiyamanan [$50] (Reporter)
@graylewis requires [$500 = $250 Bonus] (Contributor)
@burczu does not require payment (Contractor)

@burczu can you complete the checklist above?

@gadhiyamanan payment made and contract ended  - thank you! 🎉
@graylewis payment made and contract ended  - thank you! 🎉

@burczu can you complete the checklist above?

@burczu can you complete the checklist above?

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[ ]  [@burczu] The PR that introduced the bug has been identified. Link to the PR: I don't think that any other PR introduced this issue. It was done this way since the beginning.
[ ]  [@burczu] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: n/a
[ ]  [@burczu] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: n/a
[ ]  [@burczu] Determine if we should create a regression test for this bug. I don't think we need regression tests here - the bug wasn't impactful and didn't block any flow in the App. It was just inconvenient behaviour for the user so it was just UX fix.
[ ]  [@burczu] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[ ]  [@CortneyOfstad] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:


Login Screen

Is your feature request related to a problem? Please describe

Missing login screen page
need user authentication for Datathon

Describe the solution you'd like

create a login screen page
simple design that allows users to authenticate themselves

Additional context
n/a

This will only be for the admins


Fix changed checking for LocationFields

See https://github.com/caioariede/django-location-field/issues/119

@alantrick can we add a testcase for this?

Closing for inactivity


Fix resampling of down, up, and remove events.

This adds the necessary synthetic move/hover events to
resampler, which is needed for position to not change as
part of a down, up, or remove events.

Do we need also to change gesture_binding_resample_event_on_widget_test.dart?

And not all device have hover event input (e.g. touch screen). Is that the case that for such devices it's guaranteed that PointerAddEvent and PointerDownEvent are the same location and therefore there won't be extra hover event generated?

gesture_binding_resample_event_on_widget_test.dart

Fixed.

And not all device have hover event input (e.g. touch screen). Is that the case that for such devices it's guaranteed that PointerAddEvent and PointerDownEvent are the same location and therefore there won't be extra hover event generated?

Yes, I expect that. As otherwise they actually have "Hover" in practice.

And not all device have hover event input (e.g. touch screen). Is that the case that for such devices it's guaranteed that PointerAddEvent and PointerDownEvent are the same location and therefore there won't be extra hover event generated?

Yes, I expect that. As otherwise they actually have "Hover" in practice.

So I think we need a comment somewhere pointing it out.

See also the failed test log in https://api.cirrus-ci.com/v1/task/4806495726469120/logs/main.log

This should be fixed by the change to gesture_binding_resample_event_on_widget_test.dart.

BTW, unlike Gerrit, Github can't tell changes between different versions if a PR/CL only has a single commit. We usually have multiple commits in a single PR so we can tell what's changed over time. During the merge, those commits will be squashed into a single commit.

@dreveman BTW, unlike Gerrit, Github can't tell changes between different versions if a PR/CL only has a single commit. We usually have multiple commits in a single PR so we can tell what's changed over time. During the merge, those commits will be squashed into a single commit.

Ack. I'll avoid squashing during uploads in the future.


Variables in Kotlin: Android Basics with Compose

URL of codelab
https://developer.android.com/codelabs/basic-android-kotlin-compose-variables?continue=https%3A%2F%2Fdeveloper.android.com%2Fcourses%2Fpathways%2Fandroid-basics-compose-unit-1-pathway-1%23codelab-https%3A%2F%2Fdeveloper.android.com%2Fcodelabs%2Fbasic-android-kotlin-compose-variables#1
In which task and step of the codelab can this issue be found?
Data Types
Describe the problem
Less of a problem, more of a lack of clarity. We are told to look at a YouTube video with 7.3k likes and asked what data type the Likes are. While the likes are undoubtedly an Int as it is said in the tutorial the way that they are expressed (7.3k) is a String, and the fact that we are told that numbers with a decimal is a Float could further add confusion. Again, nothing is strictly incorrect, but is most definitely strange and unclear.
Steps to reproduce?

Go to...
Click on...
See error...

Versions
Android Studio version:
API version of the emulator:
Additional information
Include screenshots if they would be useful in clarifying the problem.

Hi @duenyo
Thank for writing in with your feedback.
You are correct in what you state and that it could cause confusion for a future student.
I will share this concern with the team so they can consider it when making future updates and lesson revision.
Hope you are enjoying the course.
Regards.


fix: conformance test fixes for deleteFiles, fileDelete, and copy

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

[ ] Make sure to open an issue as a bug/issue before writing your code!  That way we can discuss the change, evaluate designs, and agree on the general idea
[ ] Ensure the tests and linter pass
[ ] Code coverage does not decrease (if any source code was changed)
[ ] Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

Looks good other than the lint errors


Add option to (really) disable any gamma correction

taken care of in main, to delete.

see https://github.com/ciromattia/kcc/issues/511


dns_lookup_family has auto in v2, v4_only in v1 as the default.

According to https://www.envoyproxy.io/docs/envoy/latest/api-v1/cluster_manager/cluster#config-cluster-manager-cluster,

If this setting is not specified, the value defaults to v4_only.

According to https://www.envoyproxy.io/docs/envoy/latest/api-v2/api/v2/cds.proto#enum-cluster-dnslookupfamily,

Enum Cluster.DnsLookupFamily
...
AUTO
(DEFAULT)

This could introduce some surprises/things broken for users in transition from v1 to v2.
Probably related to https://github.com/envoyproxy/envoy/issues/2853.

@htuch thoughts on this? I remember we discussed this a while back but I don't recall what we actually said about it.

I'm going to close this as answered. Unfortunately I don't think we can change this now though I agree it was a poor choice (@ccaraman just ran into this at Lyft). If you feel like doing a doc warning PR that would be appreciated.

@mattklein123 I don't remember what the reasoning here was, it probably was just an oversight. I agree that the best we can do is docs. I also think I need to fix my gmail filters to spot these kinds of questions, I totally missed this.


Validate that changed files are actual files

Changes
Should fix a bug where directories are trying to be uploaded as if they are files during deploy stage.
Being tested by myself and K3S.
Checklist

[x] have tested my change
[ ] updated relevant documentation
[ ] Remove any/all console.logs I added
[x] eslint is not complaining
[ ] have added myself to the contributors' list in CONTRIBUTING.md
[ ] for feature PRs: PR only includes one feature enhancement.

Apparently this issue was fixed.


docs: improve types in blog writing agent notebook

Hi 👋🏻
I was playing with writing agent notebook after my issue #625 and realized there are some type issues:

Type of "append" is partially unknown
Argument type is "list[Unknown]"

This is because we don't explicitly provides type for list item of tools_and_outputs.
I've made fix that explicitly adds the type for tools_and_outputs.

I follow strict typing in all of my projects to get type hints everywhere, I recommend we add following in vscode settings.json
"python.analysis.typeCheckingMode": "strict",

This is because even with 30 sec tutorial we're not 100% type safe:

Thanks ❤

Hmm, we've put a lot of effort into type safety, and we ensure every PR that gets merged passes Pyright, so I'm not sure what is going on here, particularly for the call decorator.
What type checker are you using here?

Looks like there is an issue from a previous PR. We are going to work to resolve those type errors that should never have been the case.

What type checker are you using here?

I'm using VSCode + Pylance + mypy
If you create new project using uv and add mypy & use vscode + pylance you'll get the same error.
Most of the time these errors are from missed types of list item, forgot to pass down generic, etc.
Moreover, as you can see in my first screenshot, implicit type of tools_and_outputs is list[Any]` which is not ideal and technically we should write type for list item as well.
This is my first PR and if you want I'll submit more PRs regarding types as I get aware of it. I really love the simplicity of mirascope and will be using from now on.
Awaiting your response.

So for maintainability we've created a call_factory method for creating the call decorator for each provider. Originally we were relying heavily on nested typing overloads to dynamically generate the type based on variable types, but apparently the new version of Pyright (which Pylance uses) no longer supports this (or I guess considered support a bug and removed support 🤦 )
We've implemented a fix to use protocols instead so that the correct typing returns in this newer version. Once we merge in that fix and release it, I would love to see if you're still having the same typing issues here. I'm hopeful that this fix will return the proper type hints we expect in the examples.
As for PRs / contributions, they are always welcome with open arms! This particular PR may no longer be necessary with the fix I mentioned, but definitely keep the PRs coming!

We're available to answer any questions you may have along the way :)

Thanks for your time and efforts. Closing this one.
Finally, Can you let me know where should I track the fix you mentioned so I can check it once landed in official release.
Thanks.

This PR contains the fix, which I just released in v1.5
As you mentioned, while this fixes the issue with the call decorator, it still doesn't change anything on the tools_and_outputs list (since the type there is inferred and not explicit).
If we're going to add this additional typing, we should add it for every single example, not just this tutorial. Namely, all of the files in examples/learn/agents/ would need updating as well as the files in examples/learn/tools/tool_message_params.

we should add it for every single example

I left this decision up to you. If you want I can update this PR because it's simple but lengthy.
I tried v1.5.0 and I'm no longer getting error on .call() however while exploring more I found missing type arg for generic error on tool. I guess we should open seperate issue for dicussing this type issues instead of in this PR. WDYS?

Awaiting your response 😇

Glad the call decorator type errors are fixed! PR for updating these examples with improved types on tools_and_outputs are welcome if you believe they will add value. One reason we've left some type hints out is for brevity/readability of examples, but you're welcome to add more clarity here!
As for the BaseTool typing, this is an interesting point. As a user, you'll never actually use or instantiate a BaseTool instance because it's an abstract class. We've included the generic for the tool schema type for each specific provider (e.g. OpenAITool).
You could use Any as the type in your definition (e.g. class GetBookAuthor(BaseTool[Any])) but using Any is generally bad practice.
One reason we haven't marked the tool_schema method as abstract is that the user should not need to define it. Curious for your thoughts here.

Hi,
Thanks for your patience. I reflected on your thoughts and realized I should first understand the codebase and then make large PRs.
For the rest of the comments I'll open new issue if anything found.
Thanks, Closing this for now.


Need a way to .Navigate() to "_top"; break out of "Shell"

If your nav paradigm dictates that at some point you no longer have the option to utilize the Hamburger menu, then it's a real pain to try and hide the button and collapse the menu. Especially in a way where the visual state manager doesn't override what you specify.
It would be beneficial, I think, to have a way to call .Navigate( with some sort of indicator that this will "break out" of the Shell's content area and come to the "top" of the window. At the same time, using 'back' should get the user back to where they were - inside the shell.

So, first and foremost - do remember that our Shell and Hamburger menu implementation is totally optional and you are free to implement your own Shell that handles this behavior. If you do create your own, send us a pull request.
In terms of building something like this, it is important to consider suspend/resume scenarios and navigation serialization. This sort of nested navigation pattern usually requires multiple frames, which would need to be serialized and restored, etc.  To achieve something like you are talking about would also require abstracting the back navigation away from a specific frame into an aggregating service that understands the relationship between Frames and knows when back/forward transitions between Frames.
In short, I agree that this is a perfectly viable approach to building an app, just that I'm not sure this scenario is a high-percentage need and one we would incorporate anytime soon. That said, we do have multiple Windows on the backlog, which could require some of this plumbing to be constructed...
It should be noted that there is a way to inject top level content above the hamburger, etc. in the Shell and we use this to show login UIs, etc.

HamburgerMenu.IsFullScreen will get you a similar effect. Is that enough?

@JerryNixon i'm not sure that's what i'm looking for, but i'll check it out.
@darenm you're completely right when looking at this for a fully robust solution. at this point i'm just scrambling to get anything to work for this scenario. I'll have a look at what the Login UI calls do and see if I can use a similar approach in my app. Thanks.

Got it pseudo-working in my codebase with a new interface for Page types: IMenuOptionalPage ; I then react to the Navigated events and process the relevant parameters for the interface showing or hiding the hamburger and/or menu pane accordingly.
If I get time I'll work this in to the Minimal sample and submit a PR.

As a Sample, not in Minimal.


Image Removed is not triggering

When I tried to delete an image in the Editor it does not trigger the event

This issue is stale because it has been open for 60 days with no activity.


aging versus ageing

Related to #2691
Any MP term that contains the word aging in it should have a synonym that replaces aging with ageing.
slow aging
mortality/aging
premature aging
early reproductive senescence (accelerated reproductive aging)

Done!


Remove Network enum from README

Enums were removed in favor of strings for "Network" type
Need to updated README
https://github.com/Pusher-Labs/asgardex-clients/tree/master/packages/asgardex-client#set-network

enum is back :arrow_down:
export enum Network {
  Mainnet = 'mainnet',
  Testnet = 'testnet',
}

^ https://github.com/xchainjs/xchainjs-lib/blob/master/packages/xchain-client/src/types.ts#L5-L8


Implement copying, indexing and enumeration for NSOrderedSet using NSMutableArray/NSMutableSet

This is a follow up to #385
Were this to be merged, the only things left unimplemented would be description(withLocale:) and description(withLocale:indent:), excluding the sort options that are not yet implemented by NSArray

@swift-ci please test

From https://ci.swift.org/view/Pull Request/job/swift-corelibs-foundation-PR-Linux/486/console it looks like there was a test failure:
TestFoundation/TestNSOrderedSet.swift:177: error: TestNSOrderedSet.test_RemoveObject : XCTAssertEqual failed: ("3") is not equal to ("2") -

@swift-ci please test

Do we need any additional tests for this functionality?

I will clean up the commits a bit once the implementation is finalized

@swift-ci please test

@swift-ci please test.


Added Black within a GitHub Actions workflow

so what exactly does the .pre-commit files do? I'm not to sure lol.

Version control integration config file

Finally All checks passed


Add spacing to invalid DSL JSON data error

Pretty minor one, but bugged me out so what can you do 🤷♂

hah, nice

merge on green

Warnings

:warning:

Any changes to library code should be reflected in the Changelog.
Please consider adding a note there and adhere to the Changelog Guidelines.

  Generated by :no_entry_sign: Danger Swift against 47ffd4cc31c3e67bca293502b66e29995efb1112


Add check for DefaultFileRegion to calculate size of msg in AbstractT…

rafficShapingHandler
Motivation:
Currently calculateSize method in AbstractTrafficShapingHandler calculates size for object of type ByteBuf or ByteBufHolder. Adding a check for FileRegion, makes it possible to do traffic shaping for FileRegion objects as well
Modification:
Check if object to be sent is of type FileRegion, if yes calculate the size using its count() method.

@netty-bot test this please

@sarankk can you please fix the compile error:
06:36:51 [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.8.0:testCompile (default-testCompile) on project netty-handler: Compilation failure
06:36:51 [ERROR] /code/handler/src/test/java/io/netty/handler/traffic/FileRegionThrottleTest.java:[66,12] error: try-with-resources is not supported in -source 1.6
06:36:51 [ERROR]   (use -source 7 or higher to enable try-with-resources)
06:36:51 [ERROR]
06:36:51 [ERROR] -> [Help 1]
06:36:51 [ERROR]
06:36:51 [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
06:36:51 [ERROR] Re-run Maven using the -X switch to enable full debug logging.
06:36:51 [ERROR]
06:36:51 [ERROR] For more information about the errors and possible solutions, please read the following articles:
06:36:51 [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
06:36:51 [ERROR]
06:36:51 [ERROR] After correcting the problems, you can resume the build with the command
06:36:51 [ERROR]   mvn <args> -rf :netty-handler

@sarankk can you please fix the compile error:
06:36:51 [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.8.0:testCompile (default-testCompile) on project netty-handler: Compilation failure
06:36:51 [ERROR] /code/handler/src/test/java/io/netty/handler/traffic/FileRegionThrottleTest.java:[66,12] error: try-with-resources is not supported in -source 1.6
06:36:51 [ERROR]   (use -source 7 or higher to enable try-with-resources)
06:36:51 [ERROR]
06:36:51 [ERROR] -> [Help 1]
06:36:51 [ERROR]
06:36:51 [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
06:36:51 [ERROR] Re-run Maven using the -X switch to enable full debug logging.
06:36:51 [ERROR]
06:36:51 [ERROR] For more information about the errors and possible solutions, please read the following articles:
06:36:51 [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
06:36:51 [ERROR]
06:36:51 [ERROR] After correcting the problems, you can resume the build with the command
06:36:51 [ERROR]   mvn <args> -rf :netty-handler

yes, changed to close stream with finally block, since try-with-resources is not supported in language level 6

@netty-bot test this please

@sarankk @dineshjoshi thanks a lot


Fixed issues observed in operator with fluxninja plugin

This change is

We can close this.

These issues were handled as part of https://github.com/fluxninja/aperture/pull/364.
Closing this PR.


Pin python version used by pre-commit

This ensures that all environments listed below should produce the same
results:

github actions lint job
zuul lint job
pre-commit.ci
local run via tox -e lint

The root cause for doing is that we observed various outcomes from mypy but we already know that this can also impact other linters. Once we add a runtime requirement for pre-commit for one python version it makes sense to just make it the default python for all hook.
Related: #726

If we're doing this, I would suggest adding a small self-validation script that would compare the values across the CI setups.

There is no need for such script as pre-commit with throw error if it cannot find requested python version.
Still, I will keep this PR as draft until we identify a case where this would prevent an error or confusion. If any of you @webknjaz @cidrblock do spot a misbehavior, likely with mypy or pylint, try this one again and see if it improves the developer experience. Once we have we can undraft and merge it.
I am aware that each approach has its ups and downs, so let's decide on what seems easier for us.

I still think it's useful to have it because the worker VMs come with pre-installed interpreters that may be used silently and it's possible that what is specified in YAML will not be used. This can easily lead to confusing a reader. The configs exist for humans as well, otherwise, we'd be using binary files if there was no need to understand what's in them.

I still think it's useful to have it because the worker VMs come with pre-installed interpreters that may be used silently and it's possible that what is specified in YAML will not be used. This can easily lead to confusing a reader. The configs exist for humans as well, otherwise, we'd be using binary files if there was no need to understand what's in them.

That confuses me as you disapprove making it draft but you also did not approve it. If you support it, lets just merge it and move on.

I don't actively support it but I still can leave some feedback without rejecting. Also, I sometimes post these from phone and the mobile app does not let me create detached comments like the web UI. This is why I'm sometimes forced to use the review feature by the app in which case I select a neutral comment type and not an approval or rejection.


Helm chart deploy failing

Not sure why it's failing, not enough experience with both helm charts and github actions. @HaimKortovich could you check out why https://github.com/bagetter/BaGetter/actions/runs/11783976064/job/32822284205 failed?

@robford123 you know your way around this stuff too, maybe you have an idea?

Try it now - the branch needed to be gh-pages but I did find an organization level setting for the github token that didn't allow writes, just reads.

@Regenhardt  Build is returning status code 403 so the gh token probably does not have write access

Any way to deploy to that repo on the main branch instead of gh-pages? IMO the gh-pages branch as a deployment source is just bad design. Feels like TFS all over again (although it is of course possible it was only my former company using TFS branching like that).  A branch should be a version.
So main branch should be the only branch there, possibly readme file to explain it's a helm chart docs repo, /docs directory for the artifact. What do you think?

Also it's still breaking with the 403: Failed job

Does the token work cross-repo? Maybe we have to make a deploy key there and inject that here?

helm repository is just an index.yaml with tarballs so as @robford123 try adding permissions to write content @Regenhardt


defconstant is not highlighted

Hi! I've created a an extension that is aware of all macros and function of alexandria and the CL standard https://github.com/theHamsta/nvim-treesitter-commonlisp . I considered it as too much to upstream it to nvim-treesitter. But with any-of? the amount of function and macros that are registered clojure, it would maybe be possible to just add those by default to nvim-treesitter


vscode.workspace.onDidChangeTextDocument is called with no changes

I've noticed the function passed to vscode.workspace.onDidChangeTextDocument gets called twice if I just insert a new line into the document, the first time it gets called contentChanges is empty.
An extension might perform a lot of work when the document changes, triggering this event without any actual change seems pretty wasteful.

contentChanges seems to be empty only after the very first change to the document.

@jrieken from what I can see the function passed to onDidChangeTextDocument is called twice in succession after the very first edit, if somebody for some reason is relying on this behavior they are probably writing bad code.

I am not here to judge code quality but my role is to not break existing extensions ;-) I think checking the contextChanges-array for being empty isn't a high burden. It's also documented like that

This usually happens when the contents changes but also when other things like the dirty-state changes.

Closing because no code change is planned


One-Time charge: order items orderable_id / model

It would be great we could set the orderable morph relationship for one time charges like so:
$product = App\Models\SomethingOrderable::find(1);
$result = $user->newCharge();

$item = new ChargeItemBuilder($user);
$item->quantity($data->qty);
$item->unitPrice(money($data->price*100,'EUR'));
$item->description($data->name);
$item->taxPercentage(19);
$tiem->orderableModel($product); // <---------- new method

$result->addItem($item->make());

$result = $result->create();

Currently orderable_id & oderable_type in table order_items is always empty.

How about this?
$item = new \Laravel\Cashier\Charge\ChargeItemBuilder($user, $orderable);

@sandervanhooft yeah... much better! :)

Would be even cooler to do something like this and fill everything automatically:
class ChargeItemBuilder
{
    // ...

    public static function forChargeable(Chargeable $chargeable, Model $billable)
    {

        $result = new static($billable);
        $result->orderable = $chargeable->orderable();
        $result->unitPrice($chargeable->unitPrice());
        $result->description($chargeable->description());
        $result->taxPercentage($billable->taxPercentage());

        return $result;
    }
}

interface Chargeable
{
    public function orderable(): Model;
    public function unitPrice(): Money;
    public function description(): string;
}

This would require some additional modifications around handlePaymentFailed/Paid on the orderable model (also see InteractsWithOrderItems. 🤔
Need to investigate if this is possible without breaking change.

For clarity, this would allow you to do stuff like
$itemA = ChargeItemBuilder::forChargeable($chargeableA, $billable)->make();
$itemB = ChargeItemBuilder::forChargeable($chargeableB, $billable)
    ->taxPercentage(5.5) // overrides allowed
    ->description('Some other description')  // overrides allowed
    ->quantity(3)
    ->make();

$result = $user->newCharge()
    ->addItem($itemA)
    ->addItem($itemB)
    ->setRedirectUrl('https://www.example.com')
    ->create();

This is awesome! 😍

Thanks @divdax .
This is going to involve several steps, need to be careful to not break any existing installations. First impressions:

Add InteractsWithOrderItems into the following interfaces and apply as such:

HandlesPaymentStatusUpdates
ProcessesOrderItem
PreprocessesOrderItems (already exists)

Add checks to Order.handlePaymentPaid etc to check if the handlePaymentFailed method exists on the item before calling it.

Add Chargeable interface.

Add ChargeItemBuilder::forChargeable()

Do you think it's possible?

We have put the first steps towards this on our backlog 🤞

Hey, this would help a lot!
Is there currently any way to get all one-time charges for a user?

Any updates on this?

Hi @valerius21,
this will likely included within the next major release of this package. There is currently no ETA for the next major release, but I expect it to happen within this year.


Ubuntu jobs fail to fetch apt packages with 402 Payment Required

Description
E: Failed to fetch https://packagecloud.io/github/git-lfs/ubuntu/dists/bionic/InRelease  402  Payment Required [IP: <IP_ADDRESS> 443]
E: The repository 'https://packagecloud.io/github/git-lfs/ubuntu bionic InRelease' is no longer signed.

Area for Triage:
Packages
Question, Bug, or Feature?:
Bug
Virtual environments affected

[ ] Ubuntu 16.04
[x] Ubuntu 18.04
[ ] Ubuntu 20.04
[ ] macOS 10.15
[ ] macOS 11.0
[ ] Windows Server 2016 R2
[ ] Windows Server 2019

Expected behavior
Packages can be installed
Actual behavior
Job fails on package install step with 402
Repro steps
https://github.com/mit-plv/fiat-crypto/runs/1355905419?check_suite_focus=true

@JasonGross it impacts all versions of Ubuntu
https://packagecloud.io/github/git-lfs/ubuntu/dists/focal/InRelease
https://packagecloud.io/github/git-lfs/ubuntu/dists/bionic/InRelease
https://packagecloud.io/github/git-lfs/ubuntu/dists/xenial/InRelease
The issue is our friends at packagecloud.io apparently can't access their key due to non payment.
We are trying to remove the packagecloud line from the sources.list so when you run apt it doesn't try to ping them.  I will post a workaround here if it works.

Added a step to just remove git-lfs before we do any apt stuff seems to work.
      - name: remove git-lfs
        shell: bash
        run: |
          cat /etc/apt/sources.list
          ls /etc/apt/sources.list.d
          sudo rm /etc/apt/sources.list.d/github_git-lfs.list
          sudo rm /etc/apt/sources.list.d/github_git-lfs.list.save

FYi the keys are back online...

I think, we ca close this ticket
If this issue still not decided - feel free to reopen

@andy-mishechkin yes the issue can be closed this did make it crystal clear we need to look into a self hosted runner so that we don't have 500+ dependencies that don't relate to our software stack any of which can take us down if something goes wrong.

This issue has just resurfaced.

A google search led me to this thread.
Just had this issue on ubuntu 20.04 on another repo from packagecloud.io.
Err:16 https://packagecloud.io/slacktechnologies/slack/debian jessie InRelease
  402  Payment Required [IP: <IP_ADDRESS> 443]
Reading package lists... Done
E: Failed to fetch https://packagecloud.io/slacktechnologies/slack/debian/dists/jessie/InRelease  402  Payment Required [IP: <IP_ADDRESS> 443]
E: The repository 'https://packagecloud.io/slacktechnologies/slack/debian jessie InRelease' is no longer signed.
N: Updating from such a repository can't be done securely, and is therefore disabled by default.
N: See apt-secure(8) manpage for repository creation and user configuration details.

Err:19 https://packagecloud.io/slacktechnologies/slack/ubuntu focal InRelease
  402  Payment Required [IP: <IP_ADDRESS> 443]
E: Failed to fetch https://packagecloud.io/slacktechnologies/slack/ubuntu/dists/focal/InRelease  402  Payment Required [IP: <IP_ADDRESS> 443]
E: The repository 'https://packagecloud.io/slacktechnologies/slack/ubuntu focal InRelease' is not signed.
N: Updating from such a repository can't be done securely, and is therefore disabled by default.
N: See apt-secure(8) manpage for repository creation and user configuration details.

Same.

This issue has just resurfaced in Ubuntu 21.04

I am facing the same error too

A google search led me to this thread.
Just had this issue on ubuntu 20.04 on another repo from packagecloud.io.
Err:16 https://packagecloud.io/slacktechnologies/slack/debian jessie InRelease
  402  Payment Required [IP: <IP_ADDRESS> 443]
Reading package lists... Done
E: Failed to fetch https://packagecloud.io/slacktechnologies/slack/debian/dists/jessie/InRelease  402  Payment Required [IP: <IP_ADDRESS> 443]
E: The repository 'https://packagecloud.io/slacktechnologies/slack/debian jessie InRelease' is no longer signed.
N: Updating from such a repository can't be done securely, and is therefore disabled by default.
N: See apt-secure(8) manpage for repository creation and user configuration details.

Exact same issue! Although I got this 3-4 days ago 🤔

This issue has just resurfaced in Ubuntu 21.04

@oryband the failure has nothing to do with the Ubuntu version and everything to do with the git-lfs team not paying their bill at packagecloud.io

for anyone who is interested, you should revert to installing slack using snap imstead of that ppa usimg apt.

Just ran into the same with git-lfs package. Since the owner seems to be GitHub in this case, that's not great:
Failed to fetch https://packagecloud.io/github/git-lfs/ubuntu/dists/focal/InRelease  402  Payment Required

this is the issue with git-lfs and should be resolved by now
https://github.com/git-lfs/git-lfs/issues/4548

once again: in November 2022
^@^@W: https://download.docker.com/linux/ubuntu/dists/jammy/InRelease: Key is stored in legacy trusted.gpg keyring (/etc/apt/trusted.gpg), see the DEPRECATION section in apt-key(8) for details.
E: Failed to fetch https://packagecloud.io/github/git-lfs/ubuntu/dists/jammy/InRelease  402  Payment Required [IP: <IP_ADDRESS> 443]
E: The repository 'https://packagecloud.io/github/git-lfs/ubuntu jammy InRelease' is not signed.

Exited with code exit status 100

I can confirm the issue. And inside of a Dockerfile the solution above won't help. =/

RUN rm -fv /etc/apt/sources.list.d/github_git-lfs.list && \
    rm -fv /etc/apt/sources.list.d/github_git-lfs.list.save && \
    apt-get update && \
    apt-get install gettext

Something like this no?

Oh. Yes, but I don't want to take git-lfs from Ubuntu repos, I want to take it from the git-lfs repo :)

Is there a more general solution for this? I am running into this issue with an AtomEditor package.

Is there a more general solution for this? I am running into this issue with an AtomEditor package.

I'm having the same issue.


FIX: correct options container appearance

When Entity or Attr was selected, right panel(options) did not change

solve issue #9 https://github.com/Ahmed-Ali/RealmObjectEditor/issues/9

Used the fix provided at PR #12

Thanks a lot @ivoryxiong for your contribution


-User now has maxRange, Deleted Dead code. On initialization maxRange…

-Very small PR, backend for choosing maxRange for matches
-on creation user maxRange is 10km
merge with 154

Ill wait with merging until andy has merged


pod crashing every now and then

We have multiple clusters, all running the vantage agent. Every now and then a pod on any of them crashes. The helm deployment needs to be destroyed and recreated to fix this issue. We are now missing a week of data for some clusters.
{"time":"2023-12-30T11:30:17.665406711Z","level":"INFO","msg":"restoring pod data from backup"}
{"time":"2023-12-30T11:30:18.469158454Z","level":"ERROR","msg":"failed to setup data store","err":"unexpected EOF"}

How can we solve this issue?

Hi @vquie, the EOF error causing failures to restart should be addressed in the latest chart version 1.0.22/app version 1.0.17. Your agent is likely being OOMKilled, you can use use kubectl describe pod on the agent pod to see what the termination reason is. Assuming they are being OOMKilled, allocate a bit more memory.

Hi @macb , why are there default requests and limit values in values.yaml? :-)
I just increased the memory by a lot and updated to the latest version. The error was exactly the same. I recreated the pvc to make it run again. For now this issue does not look as it is solved. I will monitor it closely.

Hey @vquie, sorry for the slow response. The defaults are there as guidance and so we are good actors in customer's clusters.
After deleting the pvc and updating the agent has the issue occurred again? The fix would not resolve the issue if it had already occured (a bad write to the backup files) but after updating and removing the pvc I would not expect it to occur again.

Thanks. After deleting the PVC this time the error did not happen again.


Crashes a lot

Fedoraware Version Date:
Config used:

Description:

Steps to reproduce:

[ ] I am able to consistently reproduce this error

Steps to reproduce the behavior:

Enable X
Do Y
Notice Z

Additional context

[ ] I have included the steps to reproduce to the best I am able to share.

looks like skill issue ngl

what class do you usually crash on?


Auto Start Mouse Utilities

Description of the new feature / enhancement
It would very nice to have mouse utilities run automatically instead of having to enter 2 shortcuts
Scenario when this would be used?
boot, re-start, updated powertoys
Supporting information
No response

/dup #14784


Playground preview worker

Fixes RM-15748
What this PR solves / how to test:
This adds a playground preview worker for use in the upcoming Workers Playground revamp. It allows you to (unauthenticated) upload a worker to the workers preview system.
Author has included the following, where applicable:

[ ] Tests

Reviewer is to perform the following, as applicable:

Checked for inclusion of relevant tests
Checked for inclusion of a relevant changeset
Checked for creation of associated docs updates
Manually pulled down the changes and spot-tested

Note for PR author:
We want to celebrate and highlight awesome PR review! If you think this PR received a particularly high-caliber review, please assign it the label highlight pr review so future reviewers can take inspiration and learn from it.

👆 sorry about that, accidentally linked this PR to one of mine and merging that closed this one 😓 🤦


Relativize HTML runner includes

Review by @sjrd

Refer to this link for build results (access rights to CI server needed):
https://scala-webapps.epfl.ch/jenkins/job/scalajs-pr/3733/
https://scala-webapps.epfl.ch/jenkins/job/scalajs-matrix-build/4927/
Test PASSed.

Refer to this link for build results (access rights to CI server needed):
https://scala-webapps.epfl.ch/jenkins/job/scalajs-pr/3734/
https://scala-webapps.epfl.ch/jenkins/job/scalajs-matrix-build/4928/
Test PASSed.


Make bird aware of device routes for all non-calico interfaces

Potentially fixes #122

@liljenstolpe Do you have any thoughts on this?

I'd like to get this in today - @spikecurtis WDYT?
I've spoken to @Symmetric and he thinks it looks good.

Passes FV and discussed with @spikecurtis so merging

Hi, all, i don't know if they are related, but after using the image built from the master,  the route point to the new created containers (on other hosts) appeared slowly (about more than 10 secs), and after that, the new route began to appear and disappear in a cycle
Following is the bird.log
2015-05-15 07:14:50 <WARN> ...
2015-05-15 07:14:52 <WARN> Netlink: File exists
2015-05-15 07:14:52 <WARN> Netlink: File exists
2015-05-15 07:14:52 <WARN> ...
2015-05-15 07:14:54 <WARN> Netlink: File exists
2015-05-15 07:14:54 <WARN> Netlink: File exists
2015-05-15 07:14:54 <WARN> ...
2015-05-15 07:14:56 <WARN> Netlink: File exists
2015-05-15 07:14:56 <WARN> Netlink: File exists
2015-05-15 07:14:56 <WARN> ...
2015-05-15 07:14:56 <INFO> Reconfiguration requested by SIGHUP
2015-05-15 07:14:56 <INFO> Reconfiguring
2015-05-15 07:14:56 <TRACE> direct1: Reconfigured
2015-05-15 07:14:56 <INFO> Removing protocol bgp1
2015-05-15 07:14:56 <TRACE> bgp1: Shutting down
2015-05-15 07:14:56 <TRACE> bgp1: Shutdown requested
2015-05-15 07:14:56 <TRACE> bgp1: State changed to stop
2015-05-15 07:14:56 <TRACE> bgp1: BGP session closed
2015-05-15 07:14:56 <INFO> Adding protocol bgp1
2015-05-15 07:14:56 <TRACE> bgp1: Initializing
2015-05-15 07:14:56 <TRACE> bgp1: Starting
2015-05-15 07:14:56 <TRACE> bgp1: State changed to start
2015-05-15 07:14:56 <TRACE> bgp1 > removed <IP_ADDRESS>/24 via <IP_ADDRESS> on enp0s8
2015-05-15 07:14:56 <TRACE> bgp1 > removed [sole] <IP_ADDRESS>/32 via <IP_ADDRESS> on enp0s8
2015-05-15 07:14:56 <TRACE> bgp1 > removed [sole] <IP_ADDRESS>/32 via <IP_ADDRESS> on enp0s8
2015-05-15 07:14:56 <TRACE> bgp1: Sending NOTIFICATION(code=6.3)
2015-05-15 07:14:56 <TRACE> bgp1: Down
2015-05-15 07:14:56 <TRACE> bgp1: State changed to down
2015-05-15 07:14:56 <TRACE> bgp1: Started
2015-05-15 07:14:56 <TRACE> bgp1: Connect delayed by 5 seconds
2015-05-15 07:14:56 <INFO> Reconfigured
2015-05-15 07:14:58 <WARN> Netlink: File exists
2015-05-15 07:14:58 <WARN> Netlink: File exists
2015-05-15 07:14:58 <WARN> ...
2015-05-15 07:14:59 <INFO> Reconfiguration requested by SIGHUP
2015-05-15 07:14:59 <INFO> Reconfiguring
2015-05-15 07:14:59 <TRACE> direct1: Reconfigured
2015-05-15 07:14:59 <INFO> Removing protocol bgp1
2015-05-15 07:14:59 <TRACE> bgp1: Shutting down
2015-05-15 07:14:59 <TRACE> bgp1: Shutdown requested
2015-05-15 07:14:59 <TRACE> bgp1: State changed to stop
2015-05-15 07:14:59 <INFO> Adding protocol bgp1
2015-05-15 07:14:59 <TRACE> bgp1: Initializing
2015-05-15 07:14:59 <TRACE> bgp1: Starting
2015-05-15 07:14:59 <TRACE> bgp1: State changed to start
2015-05-15 07:14:59 <TRACE> bgp1: Down
2015-05-15 07:14:59 <TRACE> bgp1: State changed to down
2015-05-15 07:14:59 <TRACE> bgp1: Started
2015-05-15 07:14:59 <TRACE> bgp1: Connect delayed by 5 seconds
2015-05-15 07:14:59 <INFO> Reconfigured
2015-05-15 07:15:00 <WARN> Netlink: File exists
2015-05-15 07:15:00 <WARN> Netlink: File exists
2015-05-15 07:15:00 <WARN> ...
2015-05-15 07:15:02 <WARN> Netlink: File exists
2015-05-15 07:15:02 <WARN> Netlink: File exists
2015-05-15 07:15:02 <WARN> ...
2015-05-15 07:15:03 <TRACE> bgp1: Incoming connection from <IP_ADDRESS> (port 50185) accepted
2015-05-15 07:15:03 <TRACE> bgp1: Sending OPEN(ver=4,as=64511,hold=240,id=c0a84d15)
2015-05-15 07:15:03 <TRACE> bgp1: Got OPEN(as=64511,hold=240,id=c0a84d16)
2015-05-15 07:15:03 <TRACE> bgp1: Sending KEEPALIVE
2015-05-15 07:15:03 <TRACE> bgp1: Got KEEPALIVE
2015-05-15 07:15:03 <TRACE> bgp1: BGP session established
2015-05-15 07:15:03 <TRACE> bgp1: Connected to table master
2015-05-15 07:15:03 <TRACE> bgp1: State changed to feed
2015-05-15 07:15:03 <TRACE> bgp1 < filtered out <IP_ADDRESS>/0 via <IP_ADDRESS> on enp0s3
2015-05-15 07:15:03 <TRACE> bgp1 < filtered out <IP_ADDRESS>/24 dev enp0s3
2015-05-15 07:15:03 <TRACE> bgp1 < added <IP_ADDRESS>/32 dev enp0s8
2015-05-15 07:15:03 <TRACE> bgp1 < added <IP_ADDRESS>/24 dev enp0s8
2015-05-15 07:15:03 <TRACE> bgp1 < filtered out <IP_ADDRESS>/16 dev enp0s8
2015-05-15 07:15:03 <TRACE> bgp1 < added <IP_ADDRESS>/32 dev cali5dc06414fac
2015-05-15 07:15:03 <TRACE> bgp1 < added <IP_ADDRESS>/32 dev cali8e4eec5efac
2015-05-15 07:15:03 <TRACE> bgp1 < added <IP_ADDRESS>/32 dev calicd8c30d4fac
2015-05-15 07:15:03 <TRACE> bgp1 < filtered out <IP_ADDRESS>/16 dev docker0
2015-05-15 07:15:03 <TRACE> bgp1: State changed to up
2015-05-15 07:15:03 <TRACE> bgp1: Sending UPDATE
2015-05-15 07:15:03 <TRACE> bgp1: Sending END-OF-RIB
2015-05-15 07:15:03 <TRACE> bgp1: Got UPDATE
2015-05-15 07:15:03 <TRACE> bgp1 > added <IP_ADDRESS>/24 via <IP_ADDRESS> on enp0s8
2015-05-15 07:15:03 <TRACE> bgp1 < rejected by protocol <IP_ADDRESS>/24 via <IP_ADDRESS> on enp0s8
2015-05-15 07:15:03 <TRACE> bgp1 > added [best] <IP_ADDRESS>/32 via <IP_ADDRESS> on enp0s8
2015-05-15 07:15:03 <TRACE> bgp1 < rejected by protocol <IP_ADDRESS>/32 via <IP_ADDRESS> on enp0s8
2015-05-15 07:15:03 <TRACE> bgp1 > added [best] <IP_ADDRESS>/32 via <IP_ADDRESS> on enp0s8
2015-05-15 07:15:03 <TRACE> bgp1 < rejected by protocol <IP_ADDRESS>/32 via <IP_ADDRESS> on enp0s8
2015-05-15 07:15:03 <TRACE> bgp1: Got UPDATE
2015-05-15 07:15:03 <TRACE> bgp1: Got END-OF-RIB
2015-05-15 07:15:04 <WARN> Netlink: File exists
2015-05-15 07:15:04 <WARN> Netlink: File exists
2015-05-15 07:15:04 <WARN> ...
2015-05-15 07:15:06 <WARN> Netlink: File exists
2015-05-15 07:15:06 <WARN> Netlink: File exists
2015-05-15 07:15:06 <WARN> ...
2015-05-15 07:15:08 <WARN> Netlink: File exists
2015-05-15 07:15:08 <WARN> Netlink: File exists
2015-05-15 07:15:08 <WARN> ...

I suspect this is because the IPs on your physical interfaces overlap with the range configured for calico. By default you get the following
./calicoctl.py  pool show
+----------------+
|   IPv4 CIDR    |
+----------------+
| <IP_ADDRESS>/16 |
+----------------+

Bird uses this to control which routes it's exporting.
You should be able to resolve your problem by running calicoctl pool remove and calicoctl pool add with appropriate subnets.

@tomdee i also found this and changed the pool to <IP_ADDRESS>/16, but still in problem


refactor ASDF schema URIs and tags

Rework schema naming

drop  unnecessary schema from tags
weldx.bam.de/schemas/weldx -> weldx.bam.de/weldx
maybe keep schema folder for hosting later

use wildcard support for version numbers in tag fields
tag: "tag:stsci.edu:asdf/core/ndarray-1.0.0" -> tag: "tag:stsci.edu:asdf/core/ndarray-*" (need asdf release 2.8)

rename schema tags to asdf:// format

closing for #368 & #369


Added AWS S3 tutorial.

I wrote a tutorial on how to set up Restic with AWS S3. Because it is aimed at people who have not used AWS before, the tutorial mainly consists of a detailed walkthrough of the web-based AWS console.

Great, thanks a lot!

Codecov Report

Merging #919 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #919   +/-   ##
=======================================
  Coverage   55.78%   55.78%
=======================================
  Files         101      101
  Lines        7915     7915
=======================================
  Hits         4415     4415
  Misses       2860     2860
  Partials      640      640

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f11798...d3742e4. Read the comment docs.

No code is changed, therefore I'm cancelling the CI tests.


Snippet Conflict with language-java

I cannot choose the snippet from the popup while (package) language-java is enable neither with 'tab' key nor 'return' key. Especially, when I code for JavaFX.
Please fix this issue.

Already been issued in #75


init commit

There is something wrong with starting controller for pipeline and pipelinerun.

The current running environment can be described as follows:

Set up a kubernetes cluster using kk with version v1.19.8
Install tekton-pipelines using helm install tekton cdf/tekton-pipelines
Set up controller using command go run cmd/controller/main.go --pipeline-backend=tekton

This will run the tekton controllers of pipeline and pipelinerun.
If pipeline-backend flag is not specified, its default value is jenkins
This flag implementation can be reviewed in this commit.

Use kubectl to create Pipeline and PipelineRun to create a pipeline and run it.

Sample yaml files can be seen in this commit.


Weighted Ranges

Hi,
First of all, thanks for your work, the project is really awesome.
I tried to use weighted ranges but it seems I have wrong results.
Here are some tests I ran and compared the outputs with Equilab:
rust_poker : AA vs [QQ@1, 22] (QQ is in the range at 1% frequency) => AA equity is 0.9036
Equilab : AA vs 22 => AA equity is 0.8222
I guess equity shown from rust_poker is wrong since QQ is almost not in the range and so the equity should be closed to AA vs 22

rust_poker : AA vs [QQ@99, 22] (QQ is in the range at 99% frequency) => AA equity is 0.8176
Equilab : AA vs [QQ,22] => AA equity is 0.8189
Here the ouputs between rust_poker and Equilab are match.

It seems like a bug but maybe I missed something.
Regards

Hi I'll take a look today or tomorrow and fix this.

Ok thanks. I'll be happy to help testing if it works as expected.
Also do you plan to implement the board enumeration or just keep using Monte Carlo ?

I think I was able to fix it.  Pull the latest changes and test it out and if there are no issues, I'll close this issue and publish a new version.  There are some plans for full board enumeration, but I'm currently busy with other projects so it might be sometime unless you or someone else would like to implement it.

I made multiple tests and compared them with equilab, it seems good to me. Also did test non sense ranges such as AA@1 vs KK and it is correctly processed as AA vs KK. Good job

Sounds good.  I'll close the issue now and push a new version


Comment Improvements

Capitalize the first letter of comments
Change some "todo"s to "TODO"
Fix 1 typo in comments

Changes applied.

Changes applied.

[ ] Alright then do]()


chore : update packages to latest in base image

Update packages to the latest in the base image to get the latest fixes and reduce Vulnerability
Signed-off-by: Pratik Raj<EMAIL_ADDRESS>

By automtic upgrade we lost control on image deps. As @AkihiroSuda said, it is better to follow Ubuntu release process

ok @AkihiroSuda  @fahedouch
But this will help reduce the vulnerabilities of the image by updating the packages in every new release which got affected.
Updating the base image approach adds a lot of wait time for fixes.

I'm rather planning to pin all the deb packages with https://github.com/reproducible-containers/repro-get for reproducibility, so let me close this.
Users may run apt-get dist-upgrade locally.


Suggestion: make the project part of Hacktoberfest

Hacktoberfest is running this month and I think it might be useful to gain exposure.
It seems that you only need to add hacktoberfest to the repo's topics in order to enable this.
Screenshot from my Hacktoberfest account -they automatically follow al PRs I make, even in non-participating repos-:

Just added hacktoberfest to the repo's topics!


Implement get_sample_rate

https://github.com/ppannuto/python-saleae/blob/f005d9acbd903b4e9720a287f131c7da546e8f5e/saleae/saleae.py#L424
This is no longer true, per the document from Saleae: https://github.com/saleae/SaleaeSocketApi/blob/master/Doc/Logic Socket API Users Guide.md#get-selected-collection-sample-rate

Neat! Happy to take a PR that adds the new interface -- thanks!

@ppannuto first thing first, what a great tool that you have built :D thanks so much for all the great effort.
In  a few seconds I will create a PR that aims to fix this issue.


Tomography module improvement

Description
Improves tomography tools module to allow:

More detailed document strings
Default SIC-POVM based initial state for process tomography.
Custom input and measurement bases
Unifying state and process tomography functions by using a dict of experimental configurations
Basic unit tests

Motivation and Context
Current implementation of process tomography is suboptimal in the number of prepared initial states.
How Has This Been Tested?
Unit tests added in test_tomography.py test module
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)

Wrapper functions were added to maintain backwards compatibility with old tomography.py though these should be phased out.
Checklist:

[x] My code follows the code style of this project.
[] My change requires a change to the documentation.
[] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.

Hey  @chriseclectic , I just addressed some of the comments I made in the review. Unfortunately, we barely have tests for qiskit.tools, so I'm not 100% sure that I haven't break anything. Could you please check that everything works as expected after my changes? Thanks!! :)

Ok, just find out there are some tests for Tomography stuff, and they all passed, so I'm gonna merge this PR and if something is broken, we can fix it later.


[FEATURE] Support for saving/loading to external files

Hello! I love this plugin, but one downside to the codeblocks approach is that your tasks live in a .md file which isn't portable to any other todo.txt management apps.
If it were possible to load to and from a neighboring todo.txt file, this would make the plugin immensely useful to me.
Thanks very much!

I think this is an essential feature too! Here's the implementation I'm thinking of...
There will be a "link" button that allows you to populate the codeblock from the todotxt file at the provided path.
This will add the src metadata to the header like so:

Once linked, the button will be replaced with a "save" button that will persist whatever is in the codeblock to the file whenever clicked.

I'll add a confirmation popup that can be disabled in the settings.

Thoughts?

Definitely! That sounds like a great implementation.
My only other suggestion is to include an option for automatic saving, after the user has finished interacting (on an automatic delay).
My todo.txt file exists in my Obsidian vault, but my vault is backed by an external syncing program (Syncthing). If I had to click Save manually, I'd eventually forget. And then the changes would not be propagated to disk, causing problems when I went to edit my todo.txt on a different device (such as my phone).

To add to that - it would also be important that any external changes to the todo.txt file were detected and imported.

The reason I want saving to be manual is so whether the codeblock overwrites the file and vice versa can be controlled without a complicated synchronization mechanism.

Ok, I totally understand. This would still be a useful feature, and thanks!

Hey @Jefferderp, I've implemented the feature as part of Release 0.2.0
I'll be testing it myself over the next week or 2 and would really appreciate it if you could help me beta test too using the BRAT plugin (https://tfthacker.com/brat-quick-guide)

Awesome, thanks very much! I'll give this a test very soon.

The plugin looks really cool, thank you!  Just installed and tested v.0.2.0...
Re automatic syncs (tested in obsidian 1.5.3 on MacOS 10.15.7):

the codeblock is saved (though timing/trigger event isn't clear to me),
the codeblock isn't read if the file has been changed externally (so, external changes are overwritten).

Honestly, I'd prefer to manually read/write the file (in order to have full control).

@udjer let me add a fix for what you're seeing and add a setting to toggle auto-sync

Hi @benjamonnguyen,

@udjer let me add a fix for what you're seeing and add a setting to toggle auto-sync

thanks a lot for the swift response - no rush with fix or added setting, testing takes time (let me know if you need more info)...
Another option to address @Jefferderp's concern might be to check whether codeblock and file differ upon opening/closing the file containing the todo.txt codeblock and throwing a warning/dialog if they are different?
But perhaps that's more cumbersome or error prone than an auto-sync toggle setting.

@udjer Hey! Overwrite issue should be resolved in v0.2.1, but let me know if the lack of clarity persists as you continue to use it.
@Jefferderp The plugin should be able to coexist with openasmd now

@benjamonnguyen Fab, thanks a lot - now, external changes are loaded and internal changes are reflected in the file.  So, everything works as intended.  Thanks for the swift resolution!

Hi benjamonnguyen,
I just noticed a possibly unexpected/unwanted behaviour syncing the codeblock with an associated todo.txt file: making a change to the codeblock

in "normal" editing mode, the change is written to the file;
in source editing mode, the change is overwritten by the next file sync.

I don't think it matters much (at least not to me) but is a bit unexpected.
An option to disable automatic sync and manually read from/write to the todo.txt file may be useful?

Source mode essentially disables the plugin. Manual syncing wouldn't be feasible since the underlying logic relies on the idea of atomic actions (like when I add, edit, or delete a task).

Ah, I see - thanks for the explanation.


HiveSerDeConverter. Write to ORC records duplication with queue.capacity=1

I'm using HiveSerDeConverter in my project to convert AVRO to ORC just like described here: gobblin.readthedocs.io/en/latest/case-studies/Writing-ORC-Data.
The problem in duplicated records. I have that fancy fork.record.queue.capacity=1 in my job file, but it seems like this parameter works partially. Let me explain it a bit more in-depth.
What my project does: Connect to SFTP, read file list, extract all records from file inside ZIP archive, convert them to avro than to orc just like in the link above, write to output.
I have  sftp server on my localhost for testing purpose. Inside file that need to be read I have 7 data records. When I look to the output orc file, it contains:

third record
third record
third record
4 record
5 record
6 record
7 record

SO, first three records is replaced by THIRD record, than output is normal. I tried hard to understand this behavior, so I reimplemented classes HiveWritableHdfsDataWriterBuilder and HiveWritableHdfsDataWriter in my package and added some dirty debug info into write method.
public void write(Writable record) throws IOException {
        Preconditions.checkNotNull(record);

        log.info("MY WRITABLE: "+record.toString());
        this.writer.write(record);
        this.count.incrementAndGet();
    }

Also I have some debug info in my converter class and in DataWriterBuilder.
public DataWriter<Writable> build() throws IOException {
        log.info("Data writer Builder start");
        ...

Lets look at logs. "Debug message:" is message from my Converter class. "MY WRITABLE" is from DataWriter method write. What I see here: 3 debug messages appeared before DataWriterBuilder class was called. That means that 3 records were processed before writer started to work, so queue.capacity=1 doesn't really work here, that's why we have 3 same records. I still may be ridiculously wrong so I need help)
gobblin.source.extractor.filebased.FileBasedExtractor: Will start downloading file: /home/remoteuser/Files/01.zip:::file.csv
TSStatsConverter: Debug message:: 2016-05-19 00:00:00;123456789012347;123456789012347;7317.00;4878.00;2439.00
org.apache.hadoop.hive.serde2.avro.AvroDeserializer: Adding new valid RRID :7c5adecd:155b9394a0f:-8000
TSStatsConverter: Debug message:: 2016-05-19 00:00:00;123456789012352;123456789012352;732.00;488.00;244.00
TSStatsConverter: Debug message:: 2016-05-19 00:00:00;123456789012349;123456789012349;366.00;244.00;122.00
TSStatsConverter: ------------------------
TSStatsConverter: Data writer Builder start
TSStatsConverter: Preconditions ran succesfully
TSStatsConverter: WRITER.WRITABLE.CLASS=org.apache.hadoop.hive.ql.io.orc.OrcSerde$OrcSerdeRow
TSStatsConverter: WRITER.OUTPUT.FORMAT.CLASS=org.apache.hadoop.hive.ql.io.orc.OrcOutputFormat
TSStatsConverter: MY WRITABLE: org.apache.hadoop.hive.ql.io.orc.OrcSerde$OrcSerdeRow@22012154
TSStatsConverter: MY WRITABLE: org.apache.hadoop.hive.ql.io.orc.OrcSerde$OrcSerdeRow@22012154
TSStatsConverter: MY WRITABLE: org.apache.hadoop.hive.ql.io.orc.OrcSerde$OrcSerdeRow@22012154
TSStatsConverter: Debug message:: 2016-05-19 00:00:00;123456789012351;123456789012351;366.00;244.00;122.00
TSStatsConverter: MY WRITABLE: org.apache.hadoop.hive.ql.io.orc.OrcSerde$OrcSerdeRow@22012154
TSStatsConverter: Debug message:: 2016-05-19 00:00:00;123456789012345;123456789012345;363.00;242.00;121.00
TSStatsConverter: MY WRITABLE: org.apache.hadoop.hive.ql.io.orc.OrcSerde$OrcSerdeRow@22012154
TSStatsConverter: Debug message:: 2016-05-19 00:00:00;123456789012346;123456789012346;363.00;242.00;121.00
TSStatsConverter: MY WRITABLE: org.apache.hadoop.hive.ql.io.orc.OrcSerde$OrcSerdeRow@22012154
TSStatsConverter: Debug message:: 2016-05-19 00:00:00;123456789012348;123456789012348;363.00;242.00;121.00
TSStatsConverter: MY WRITABLE: org.apache.hadoop.hive.ql.io.orc.OrcSerde$OrcSerdeRow@22012154
gobblin.source.extractor.extract.sftp.SftpFsHelper: Transfer finished 1 src: /home/remoteuser/Files/01.zip dest: ?? in 0 at 0.00
gobblin.source.extractor.filebased.FileBasedExtractor: Unable to get file size. Will skip increment to bytes counter Failed to get size for file at path /home/remoteuser/Files/01.zip:::file.csv due to error No such file
gobblin.source.extractor.filebased.FileBasedExtractor: Finished reading records from all files
gobblin.runtime.Task: Extracted 7 data records

In which file did you set fork.record.queue.capacity=1? Can you try setting it in both the .job file and .properties file?

I set it in a .pull file where is my job config lays. Putting it to .properties file didn't help. I tested it earlier, logging this property in different classes, looked like it works fine.
@sahilTakiar, I found some new info. I created new converter similar to the original one, but it uses new SerDe object for every record. So, no duplicated records. But problem still here. First three records is third record. Maybe this is problem with writer? Logs:
FileBasedExtractor: Will start downloading file: /home/remoteuser/Files/Terminal_Tethering01.zip:::Export Tethering Subscribers.csv
TSStatsConverter: Debug message:: 2016-05-19 00:00:00;123456789012347;123456789012347;7317.00;4878.00;2439.00
AvroDeserializer: Adding new valid RRID :-4b494a8a:155c4244e69:-8000
InstrumentedConverter: CONVERTED RECORD:::org.apache.hadoop.hive.ql.io.orc.OrcSerde$OrcSerdeRow@61bbb8a4
InstrumentedConverter: CONVERTED HASH:::1639692452
TSStatsConverter: Debug message:: 2016-05-19 00:00:00;123456789012352;123456789012352;732.00;488.00;244.00
InstrumentedConverter: CONVERTED RECORD:::org.apache.hadoop.hive.ql.io.orc.OrcSerde$OrcSerdeRow@8e53cf0
InstrumentedConverter: CONVERTED HASH:::149241072
TSStatsConverter: Debug message:: 2016-05-19 00:00:00;123456789012349;123456789012349;366.00;244.00;122.00
InstrumentedConverter: CONVERTED RECORD:::org.apache.hadoop.hive.ql.io.orc.OrcSerde$OrcSerdeRow@1169d3a
InstrumentedConverter: CONVERTED HASH:::18259258
TSStatsConverter: Debug message:: 2016-05-19 00:00:00;123456789012351;123456789012351;366.00;244.00;122.00
InstrumentedConverter: CONVERTED RECORD:::org.apache.hadoop.hive.ql.io.orc.OrcSerde$OrcSerdeRow@35b0050
InstrumentedConverter: CONVERTED HASH:::56295504
TSStatsConverter: Debug message:: 2016-05-19 00:00:00;123456789012345;123456789012345;363.00;242.00;121.00
InstrumentedConverter: CONVERTED RECORD:::org.apache.hadoop.hive.ql.io.orc.OrcSerde$OrcSerdeRow@75b734cb
InstrumentedConverter: CONVERTED HASH:::1974940875
TSStatsConverter: Debug message:: 2016-05-19 00:00:00;123456789012346;123456789012346;363.00;242.00;121.00
InstrumentedConverter: CONVERTED RECORD:::org.apache.hadoop.hive.ql.io.orc.OrcSerde$OrcSerdeRow@212341d5
InstrumentedConverter: CONVERTED HASH:::555958741
TSStatsConverter: Debug message:: 2016-05-19 00:00:00;123456789012348;123456789012348;363.00;242.00;121.00
InstrumentedConverter: CONVERTED RECORD:::org.apache.hadoop.hive.ql.io.orc.OrcSerde$OrcSerdeRow@7f7305e8
InstrumentedConverter: CONVERTED HASH:::2138244584
SftpFsHelper: Transfer finished 1 src: /home/remoteuser/Files/Terminal_Tethering01.zip dest: ?? in 0 at 0.00
FsDataWriterBuilder: ------------------------
FsDataWriterBuilder: Data writer Builder start
FileBasedExtractor: Finished reading records from all files
gobblin.runtime.Task: Extracted 7 data records
gobblin.runtime.Task: Row quality checker finished with results:
FsDataWriter: MY WRITABLE HASH:<PHONE_NUMBER>
FsDataWriter: MY WRITABLE HASH: 149241072
FsDataWriter: MY WRITABLE HASH: 18259258
FsDataWriter: MY WRITABLE HASH: 56295504
FsDataWriter: MY WRITABLE HASH:<PHONE_NUMBER>
FsDataWriter: MY WRITABLE HASH: 555958741
FsDataWriter: MY WRITABLE HASH:<PHONE_NUMBER>
gobblin.publisher.TaskPublisher: All components finished successfully, checking quality tests
gobblin.publisher.TaskPublisher: All required test passed for this task passed.
gobblin.publisher.TaskPublisher: Cleanup for task publisher executed successfully.
gobblin.runtime.Fork-0: Committing data for fork 0 of task task_cmd_pre_post_1467874476697_0

More debug info now) In destination file rows:
2016-05-19 00:00:00;123456789012347;123456789012347;7317.00;4878.00;2439.00
2016-05-19 00:00:00;123456789012352;123456789012352;732.00;488.00;244.00
2016-05-19 00:00:00;123456789012349;123456789012349;366.00;244.00;122.00

look like:
2016-05-19 00:00:00<PHONE_NUMBER>12349<PHONE_NUMBER>12349	366.00	244.00	122.00
2016-05-19 00:00:00<PHONE_NUMBER>12349<PHONE_NUMBER>12349	366.00	244.00	122.00
2016-05-19 00:00:00<PHONE_NUMBER>12349<PHONE_NUMBER>12349	366.00	244.00	122.00

I tested it with files different in size, in content, but still h*ck this first three records. I will made new gobblin build this week, and will create clean job files and stuff. Maybe something will change.

@kSky7000 Can you please share your pull file, changes you made to any class and some sample data. I will try to reproduce it locally and debug.

@abti Thank you very much.
https://github.com/kSky7000/cuddly-pancake
pull file, zip with data sample, sources.

@abti Really sorry for bothering but I need help) Any news about this bug? Did you try to reproduce it?

Hi Nikolay,
Apologies for dropping the ball on this. I missed to revisit this, and I am
traveling right now. I will try to dig into this early next week.
Regards
Abhishek
On Tue, Aug 2, 2016 at 4:24 PM, Nikolay Skovorodin<EMAIL_ADDRESS>
wrote:

@abti https://github.com/abti Really sorry for bothering but I need
help) Any news about this bug? Did you try to reproduce it?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/linkedin/gobblin/issues/1086#issuecomment-236870993,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAEPe-DoqX5Uh-gg6Gr5ViVCzxTYwx42ks5qbyHfgaJpZM4JE2Or
.

@abti I found another intresting thing. Today I used example json-project with orc addition to it and achieved same result with first three records being duplicated. What do you think about it? For hadoop im using Hortonworks HDP 2.2

I hit the same issue. I used HiveSerDeConverter and HiveWritableHdfsDataWriterBuilder to write records to ORC files. I noticed that some records are duplicated and some others are missing.  Is there any plan to fix this issue? @abti
@kSky7000 Did you find the solution for it?
Thanks

@jeffwang66 Unfortunately i did not resolve this issue.

I have the same issue. fork.record.queue.capacity=1 does not help.


Helmet Detection

Is your feature request related to a problem? Please describe.
In Industry, specially manufacturing industry, Personal Protective Equipment (PPE) like helmet (hard-hat), safety-harness, goggles etc play a very important role in ensuring the safety of workers. However, many accidents still occur, due to the negligence of the workers as well as their supervisors. Supervisors can make mistakes due to the fact that such tasks are monotonous and they may not be able to monitor consistently.
Describe the solution you'd like
This project aims to utilize existing CCTV camera infrastructure to assist supervisors to monitor workers effectively by providing them with real time alerts.
Approach to be followed (optional)
-> Input is taken from CCTV cameras
-> YOLO is used for detecting persons with proper PPE and those without PPE.
-> Deep_SORT allocates unique ids to detected persons and tracks them through consecutive frames of the video.
-> An alert is raised if a person is found to be without proper PPE for more than some set duration, say 5 seconds.

I want to work on this issue

I want to work on this issue


Use prophet settings in robyn_refresh

Hi,
We have trained a model using certain values for prophet passing it through robyn_inputs() (eg., changepoint.range,seasonality.mode...). We want to reproduce the same settings of training period in all the refreshes by passing those parameters in robyn_refresh().
However, when doing the refresh for those models, we would like to pass the same parameters, but robyn_refresh() doesn't seem to have the option for that. We have run into an error when running robyn_refresh() and passing those parameters.
  Robyn <- robyn_refresh(     , dt_input = data     , dt_holidays = holidays       , refresh_steps = steps     , refresh_mode = "auto"     , refresh_iters = iterations      , refresh_trials = trials     , plot_pareto = FALSE     , changepoint.range = 0.6     , changepoint.prior.scale = 0.30     , n.changepoints = 36       , seasonality.mode = 'additive'     , seasonality.prior.scale = 15     , holidays.prior.scale = 15   )
The error was the following: Error in robyn_refresh(, dt_input = vistaprint_dt_rw_filtered, dt_holidays = holidays,  :    unused arguments (changepoint.range = 0.6, changepoint.prior.scale = 0.3, n.changepoints = 36, seasonality.mode = "additive", seasonality.prior.scale = 15, holidays.prior.scale = 15)
Problem should be solved allowing both robyn_refresh() and the nested call of robyn_engineering() to pass those parameters using "..."

Hi, @joangcc
I've just deployed a fix into the main branch for custom prophet inputs on robyn_refresh(). Please, do re-install Robyn to match version 3.4.12 and let us know if everything's as expected.
Cheers.

Hi @laresbernardo ,
Thank you for your changes. We have updated our main branch to catch these changes. We are trying the process and running into some errors. Specifically, when running robyn_refresh:
Robyn <- robyn_refresh(     robyn_object = our_filename     , dt_input = our_dt     , dt_holidays = dt_prophet_holidays      , refresh_steps = 30     , refresh_mode = "auto"# in auto mode will refresh number of iterations     , refresh_iters = 500     , refresh_trials = 2     , plot_pareto = FALSE   )
After running robyn_refresh, the process gives us the following error just when the first trial starts:
'>>> Start running 2 trials with 500 iterations per trial each with TwoPointsDE nevergrad algorithm...
Running trial nr. 1
Error in {: task 1 failed - "argument is of length zero"'
We will keep working in this, as the error may well be due to some bug on our end.
We will keep you updated.
Cheers.

Hi @joangcc I think this error doesn't have a relation to the robyn_refresh() changes but let us know...
Just FYI, no need to pass those parameters again to robyn_refresh() because they are now saved into the exported object on robyn_run()'s results and automatically set to be the new defaults for every iteration. I'd use robyn_refresh() parameters in case you'd like to change (for some reason) on new refresh iterations.

Hi @laresbernardo ,
I confirm that robyn_refresh does accept now explicit declaration of prophet parameters and uses them in model training.
However, robyn_refresh does not use the values used during initial training period. I have to declare them again. custom_param, which I assume is the object that should save explicitly declared prophet settings, is an empty list in the RDS file once you save the results from the initial run. I have tested this using your demo script. See code to reproduce the problem:
`
library(Robyn)
set.seed(123)
Sys.setenv(R_FUTURE_FORK_ENABLE="true")
options(future.fork.enable = TRUE)
data("dt_simulated_weekly")
head(dt_simulated_weekly)
data("dt_prophet_holidays")
head(dt_prophet_holidays)
robyn_object <- "path"
InputCollect <- robyn_inputs(
dt_input = dt_simulated_weekly
,dt_holidays = dt_prophet_holidays
,date_var = "DATE"
,dep_var = "revenue"
,dep_var_type = "revenue"
,prophet_vars = c("trend", "season", "holiday")
,prophet_signs = c("default","default", "default")
,prophet_country = "DE"
,context_vars = c("competitor_sales_B", "events")
,context_signs = c("default", "default")
,paid_media_vars = c("tv_S", "ooh_S"	,	"print_S"	,"facebook_I" ,"search_clicks_P")
,paid_media_signs = c("positive", "positive","positive", "positive", "positive")
,paid_media_spends = c("tv_S","ooh_S",	"print_S"	,"facebook_S", "search_S")
,organic_vars = c("newsletter")
,organic_signs = c("positive")
,factor_vars = c("events")
,cores = 6
,window_start = "2016-11-23"
,window_end = "2018-08-22"
,adstock = "geometric"
,iterations = 200
,nevergrad_algo = "TwoPointsDE"
,trials = 1
)
hyper_names(adstock = InputCollect$adstock, all_media = InputCollect$all_media)
hyperparameters <- list(
facebook_I_alphas = c(0.5, 3)
,facebook_I_gammas = c(0.3, 1)
,facebook_I_thetas = c(0, 0.3)
,print_S_alphas = c(0.5, 3)
,print_S_gammas = c(0.3, 1)
,print_S_thetas = c(0.1, 0.4)
,tv_S_alphas = c(0.5, 3)
,tv_S_gammas = c(0.3, 1)
,tv_S_thetas = c(0.3, 0.8)
,search_clicks_P_alphas = c(0.5, 3)
,search_clicks_P_gammas = c(0.3, 1)
,search_clicks_P_thetas = c(0, 0.3)
,ooh_S_alphas = c(0.5, 3)
,ooh_S_gammas = c(0.3, 1)
,ooh_S_thetas = c(0.1, 0.4)
,newsletter_alphas = c(0.5, 3)
,newsletter_gammas = c(0.3, 1)
,newsletter_thetas = c(0.1, 0.4)
)
InputCollect <- robyn_inputs(InputCollect = InputCollect,
hyperparameters = hyperparameters,
changepoint.prior.scale =0.3,
seasonality.mode = 'multiplicative',
seasonality.prior.scale=12,
holidays.prior.scale = 12,
n.changepoints = 1)
OutputCollect <- robyn_run(
InputCollect = InputCollect
, plot_folder = robyn_object
, pareto_fronts = 3
, plot_pareto = FALSE
)
OutputCollect$allSolutions
select_model <- "1_17_4" #adapt
robyn_save(robyn_object = robyn_object
, select_model = select_model
, InputCollect = InputCollect
, OutputCollect = OutputCollect
)
Robyn <- robyn_refresh(
robyn_object = robyn_object
, dt_input = dt_simulated_weekly
, dt_holidays = dt_prophet_holidays
, refresh_steps = 1
, refresh_mode = "manual"
, refresh_iters = 200
, refresh_trials = 1
)
`
Let me know if I should create a separate issue for that.
Thanks,
Joan

Hi @Lares,
THanks for your quick response.Updated. Robyn object saves nowcustom_params. However, seems this parametersarenot having effect.
See the following comparison:
This first image shows prophet_decomp.png before the refresh(initial run). See how the trend only has 1 changepoint as expected.

This second image shows prophet_decomp.png after the refresh, using the code I sent you in my previous message. As you can see, in the refresh, Prophet is using more changepoints, ignoring the explicit parameters declared in initial training period-

Is there any extra step that I have to do to indicate robyn_refresh it should be using custom_params?
Thanks,
Joan

Yeah, sorry for that. I didn't even know exactly how to check if it was working OK, so thanks for the example and double-checking. I've just used your reproducible code to test and should work now (both original and refresh versions have 1 change-point on prophet_decomp outputs).
I've also added a message printed for when custom parameters are being used. Please, let us know (again) if it worked alright this time.
Have a nice weekend @joangcc

Hi @laresbernardo ,
It works! Thanks for fixing this issue.
Best,
Joan


Cleanup leaf_as_range

Issue Type

[ ] Bug Report
[ ] EOS Configuration rendering error
[X] Documentation Issue Report

Summary
It looks like leaf_as_range was removed eos_designs l3ls-evpn, but not all the references to it were.
https://github.com/aristanetworks/ansible-avd/search?q=leaf_as_range&type=code
This is confusing given some example repos still mention it and it does nothing.
Component Name
eos_designs
Steps to reproduce
N/A
Expected results
N/A
Actual results
N/A

This is a simple cleanup job likely fixed in the eos_designs refactor.


Dev mode on multi module project without -pl causes gives "packaging type is not supported" error

git clone https://github.com/OpenLiberty/guide-maven-multimodules
From the finish directory, run mvn io.openliberty.tools:liberty-maven-plugin:3.3.5-M2-SNAPSHOT:dev (without including -pl ear -am)
Notice the Maven Reactor build order:

[INFO] guide-maven-multimodules-jar                                       [jar]
[INFO] guide-maven-multimodules-war                                       [war]
[INFO] guide-maven-multimodules-ear                                       [ear]
[INFO] guide-maven-multimodules                                           [pom]

Dev mode runs on the ear module.
Press q and Enter to quit.
Dev mode tries to run again on the pom module, then fails with the error:

[ERROR] Failed to execute goal io.openliberty.tools:liberty-maven-plugin:3.3.5-M2-SNAPSHOT:dev (default-cli) on project guide-maven-multimodules: CWWKM2173E: Failed to install application from project io.openliberty.guides:guide-maven-multimodules:pom:1.0-SNAPSHOT. The project packaging type is not supported.

Dev mode should skip over the pom module in this scenario since it already ran in the ear module.

In this case, ear and pom modules both do not have downstream module, so dev mode tries to run on both.  The same issue occurs with the run goal.
More generally, we could pick one module and not run the other.  Or (particularly for the case where there is more than one module which has Liberty config with no downstream modules that depend on them), simply quit with a warning or error, telling the user they need to use -pl.