[terra-table] Table implementation guide

Summary

What was changed:
Added the implementation guide to the Terra Table component.
Why it was changed:
The implementation guide was added to explain proper usage to consumers.
Testing

This change was tested using:

[ ] WDIO
[ ] Jest
[ ] Visual testing (please attach a screenshot or recording)
[ ] Other (please describe below)
[X] No tests are needed

Reviews
In addition to engineering reviews, this PR needs:

[ ] UX review
[X] Accessibility review
[ ] Functional review

Additional Details
N/A
This PR resolves:
UXPLATFORM-9734

Thank you for contributing to Terra.
@cerner/terra

Looks good @chrismichalewicz. I have one suggestion for the table that lists the examples. Since the examples are meant to illustrate the use of a specific property, I suggest noting which prop the example has enabled. What is your thought about this. See Nikhita's Search Field doc for an example.

I agree, I think if we can bubble up the props into the Example table, similar to Search Field that would be ideal. I do like how you expand more on the props on the individual example pages so I would keep that.   @cm9361  Can you update the example table on the About page to include mention of the props used.

Looks good @chrismichalewicz. I have one suggestion for the table that lists the examples. Since the examples are meant to illustrate the use of a specific property, I suggest noting which prop the example has enabled. What is your thought about this. See Nikhita's Search Field doc for an example.

I agree, I think if we can bubble up the props into the Example table, similar to Search Field that would be ideal. I do like how you expand more on the props on the individual example pages so I would keep that. @cm9361 Can you update the example table on the About page to include mention of the props used.

Would that work as well for the Table?  The props used are already documented in each example.  We don't have dedicated examples for each prop.

Looks good @chrismichalewicz. I have one suggestion for the table that lists the examples. Since the examples are meant to illustrate the use of a specific property, I suggest noting which prop the example has enabled. What is your thought about this. See Nikhita's Search Field doc for an example.

I agree, I think if we can bubble up the props into the Example table, similar to Search Field that would be ideal. I do like how you expand more on the props on the individual example pages so I would keep that. @cm9361 Can you update the example table on the About page to include mention of the props used.

Would that work as well for the Table? The props used are already documented in each example. We don't have dedicated examples for each prop. The Table component is a bit more complex than the search field.

@cm9361  I think there is still value in doing this for Table, even if we aren't calling out or have examples for all Props.  How I envision a user using that info is maybe they have a question on a specific prop they can scan the table really quickly to see if we have example for it and go straight to it rather than opening all of the examples searching for a particular prop.
Also sorry for the duplicate comments with regards to this.  After I posted the original commment figured I'd start a 'formal' review. Probably a newbie mistake.

Here are some suggested revisions to the example table:

Link to Example
Description

Default Table
An example demonstrating a basic table populated with tabular data and no interactive elements.

Zebra Striped Table
An example demonstrating the ability enable zebra striping.

Pinned Columns
An example demonstrating pinned columns (frozen leftmost columns) and overflow columns.

Sortable Table
An example demonstrating how to enable sorting within a table. Heading cells of sortable columns are interactive and include an icon indicating sort direction.

Table Column States
An example demonstrating column states and interactions such as an error or sort. Header cells include an icon that represents the state of the data in the column.

etc.

Link to Example	Description
Default Table	An example demonstrating a basic table.
Zebra Striped Table	An example demonstrating the ability enable zebra striping.
Pinned Columns	An example demonstrating pinned columns (frozen leftmost columns) and overflow columns.
Sortable Table	An example demonstrating how to enable sorting within a table.
Table Column States	An example demonstrating column states and interactions.
Table with Focusable Cells	An example demonstrating tab stop behavior in a table with interactable elements.
Single Row Selection	An example demonstrating a table with single row selection mode.
Multiple Row Selection	An example demonstrating a table with multiple row selection mode.
Table with Sections	An example demonstrating a table with sections.
Table Without Headers	An example demonstrating a table without headers.

Here are some suggested revisions to the example table:
Link to Example	Description
Default Table	An example demonstrating a basic table populated with tabular data and no interactive elements.
Zebra Striped Table	An example demonstrating the ability enable zebra striping.
Pinned Columns	An example demonstrating pinned columns (frozen leftmost columns) and overflow columns.
Sortable Table	An example demonstrating how to enable sorting within a table. Heading cells of sortable columns are interactive and include an icon indicating sort direction.
Table Column States	An example demonstrating column states and interactions such as an error or sort. Header cells include an icon that represents the state of the data in the column.
etc.
Link to Example Description Default Table An example demonstrating a basic table. Zebra Striped Table An example demonstrating the ability enable zebra striping. Pinned Columns An example demonstrating pinned columns (frozen leftmost columns) and overflow columns. Sortable Table An example demonstrating how to enable sorting within a table. Table Column States An example demonstrating column states and interactions. Table with Focusable Cells An example demonstrating tab stop behavior in a table with interactable elements. Single Row Selection An example demonstrating a table with single row selection mode. Multiple Row Selection An example demonstrating a table with multiple row selection mode. Table with Sections An example demonstrating a table with sections. Table Without Headers An example demonstrating a table without headers.

Ok.  I think I understand the comment now.  You want better elaboration on the purpose of the example more than calling out specific properties in the description.  I will work on making these updates.

Here are some suggested revisions to the example table:
Link to Example	Description
Default Table	An example demonstrating a basic table populated with tabular data and no interactive elements.
Zebra Striped Table	An example demonstrating the ability enable zebra striping.
Pinned Columns	An example demonstrating pinned columns (frozen leftmost columns) and overflow columns.
Sortable Table	An example demonstrating how to enable sorting within a table. Heading cells of sortable columns are interactive and include an icon indicating sort direction.
Table Column States	An example demonstrating column states and interactions such as an error or sort. Header cells include an icon that represents the state of the data in the column.
etc.
Link to Example Description Default Table An example demonstrating a basic table. Zebra Striped Table An example demonstrating the ability enable zebra striping. Pinned Columns An example demonstrating pinned columns (frozen leftmost columns) and overflow columns. Sortable Table An example demonstrating how to enable sorting within a table. Table Column States An example demonstrating column states and interactions. Table with Focusable Cells An example demonstrating tab stop behavior in a table with interactable elements. Single Row Selection An example demonstrating a table with single row selection mode. Multiple Row Selection An example demonstrating a table with multiple row selection mode. Table with Sections An example demonstrating a table with sections. Table Without Headers An example demonstrating a table without headers.

Ok. I think I understand the comment now. You want better elaboration on the purpose of the example more than calling out specific properties in the description. I will work on making these updates.

Thanks!

Thanks for improving the example descriptions. Please change italics back to regular font. I had italicized the text in my comment so you could see what I added/changed, but the italics are not needed in the final version.
One additional minor change that occurred to me is for the zebra stripe example, should we add that it applies to rows and not columns.

Thanks for improving the example descriptions. Please change italics back to regular font. I had italicized the text in my comment so you could see what I added/changed, but the italics are not needed in the final version. One additional minor change that occurred to me is for the zebra stripe example, should we add that it applies to rows and not columns.

I will remove the italics.  I apologize for misinterpreting that detail.  As far as the zebra striping, I don't think we need to mention rows versus columns.  That term means that you are striping alternating rows.  However, I can still call it out for completeness.

Can we move the introductory description (first two sentences and Caution/Note) to the Overview section and have the Table of the Contents directly under the Terra Table heading? It looks like there are two separate overviews that could be combined. I may just be unaware of the reason to have them separate though.
Has Reg Affairs approved the use of the Caution labels? I can request a review from them, or we could change both instances to Note or Important! with a different background color. I also recommend moving the first Caution/Note to be above the description as it applies to the whole page. The second Caution/Note should be moved under the heading of the section it applies to.

Thanks for improving the example descriptions. Please change italics back to regular font. I had italicized the text in my comment so you could see what I added/changed, but the italics are not needed in the final version. One additional minor change that occurred to me is for the zebra stripe example, should we add that it applies to rows and not columns.

I will remove the italics. I apologize for misinterpreting that detail. As far as the zebra striping, I don't think we need to mention rows versus columns. That term means that you are striping alternating rows. However, I can still call it out for completeness.

No need to change the zebra striping description as it is commonly understood to refer to alternating rows. Thanks!

Can we move the introductory description (first two sentences and Caution/Note) to the Overview section and have the Table of the Contents directly under the Terra Table heading? It looks like there are two separate overviews that could be combined. I may just be unaware of the reason to have them separate though.
Has Reg Affairs approved the use of the Caution labels? I can request a review from them, or we could change both instances to Note or Important! with a different background color. I also recommend moving the first Caution/Note to be above the description as it applies to the whole page. The second Caution/Note should be moved under the heading of the section it applies to.

@cldeitrich  I don't believe Reg Affairs has gone through and reviewed any of our use of the Caution labels. Tbh I don't think it's probably worth the trouble and we could probably just update it to use an Important!     @cm9361  is this something we can update?  As well as the moving of the text as suggested in the Overview section?   That logic makes to me as it appears like there are multiple Overview sections.

I've added my edits. It looks like we are distinguishing whether we're referring to Table (the component name) or a table in general, so I tried to make that distinction clearer.
On the About page, for the Section table, isCollapsible was missing the Required column value. I put the value as Optional, but please review if that's correct.
I'm not sure which file the Properties table lives in, but if possible it would be good to edit that as well.
Let me know if you have any questions or if other changes need to be made!

It looks like we are distinguishing whether we're referring to Table (the component name) or a table in general, so I tried to make that distinction clearer.

The properties table is generated from the comments included in our source code.  If there are specific updates desired to the API documentation, I can make those updates for you.  I just need to know what needs to be updated.  The alternative is that I could direct you to the appropriate file(s).


add allstream

@sboily do you know this PR is not merged?
If this is complete and valid, do you know if we *need it for something?
@mwolff44 can you take it please?
All new portal plugins should be related to a JIRA ticket with an explanation/approbation by a PO otherwise PR are not read by non-dev people with our current workflow :sweat_smile:

It's a draft.


[SPARK-45312][SQL][UI][FOLLOWUP] Fix no-unused-vars error in eslint check

What changes were proposed in this pull request?
Fix no-unused-vars error in eslint check, because add togglePlanViz function in #43099 , this PR just move it in eslint-disable no-unused-vars block.

Why are the changes needed?
Fix eslint check error

Does this PR introduce any user-facing change?
No

How was this patch tested?
exist test.
Tested in local too
➜  spark git:(master) ✗ ./dev/lint-js
lint-js checks passed.

Was this patch authored or co-authored using generative AI tooling?
No

cc @panbingkun @yaooqinn


No NgModule metadata found for 'function (){}'.

Donno if it's related to https://github.com/angular/angular-cli/issues/7910 but :
- [ x] bug report -> please search issues before submitting

Versions.
Angular CLI: 1.5.0-rc.3
Node: 6.11.0
OS: win32 x64
Angular: 5.0.0-rc.6
... animations, common, compiler, compiler-cli, core, forms
... http, language-service, platform-browser
... platform-browser-dynamic, router

@angular/cli: 1.5.0-rc.3
@angular-devkit/build-optimizer: 0.0.31
@angular-devkit/core: 0.0.20
@angular-devkit/schematics: 0.0.34
@ngtools/json-schema: 1.1.0
@ngtools/webpack: 1.8.0-rc.3
@schematics/angular: 0.0.48
typescript: 2.5.3
webpack: 3.8.1

Repro steps.
ng build --prod --app=prod --output-path dist/fr --locale fr --bh /fr/ --i18n-format xtb --i18n-file src/locale/fr.xtb build success  but on browser got error
The log given by the failure.
Browser get me :

Desired functionality.
would be nice if this error happens durning build process,
Mention any other details that might be useful.
my package.json
my .angular-cli.json

I don't think it's the same as https://github.com/angular/angular-cli/issues/7910 because that one is about Universal I believe.
I haven't seen this error myself though, so I don't know what's happening here. It seems like a library doesn't have the right metadata? Perhaps that's it. Does it still happen with the latest CLI (1.5.0-rc.5)?
If it does, can you setup a minimal repro please? You can read here why this is needed. A good way to make a minimal repro is to create a new app via ng new repro-app and adding the minimum possible code to show the problem. Then you can push this repository to github and link it here.

no don't have this error on rc5 and donno why  but here I can't find where is problem anyway will close this issue

@filipesilva  don't know if need open new issue but after making an "successful" ng build on browser I have this result

thanks if any helps

@istiti do you also get that error on development builds? What's the command you used to build?

@filipesilva build command
    "ok": "npm run fr && npm run de",
    "fr": "node --max-old-space-size=8192 ./node_modules/@angular/cli/bin/ng build --prod --app=prod --output-path dist/fr --locale fr --bh /fr/ --i18n-format xtb --i18n-file src/locale/fr.xtb",
    "de": "node --max-old-space-size=8192 ./node_modules/@angular/cli/bin/ng build --prod --app=prod --output-path dist/de --locale de --bh /de/ --i18n-format xtb --i18n-file src/locale/de.xtb",

don't have this error on dev

Can you try those commands with sourcemap turned on --sm please? That should give you a better error message and maybe a hint on what's breaking.

I have this problem with example code from angular "tour-of-heroes".
I was working with the official tutorial from Angular Universal.
I downloaded the example mentioned there from angular. I installed npm packages. Then I ran:
npm run build:ssr
npm run serve:ssr
Then I got the same error:
universal\dist\server.js:56322
                throw new Error("No NgModule metadata found for '" + stringify(type) + "'.");
                ^
Error: No NgModule metadata found for 'function (){}'.
    at NgModuleResolver.resolve (universal\dist\server.js:56322:23)
    at CompileMetadataResolver.getNgModuleMetadata (universal\dist\server.js:51312:60)
    at JitCompiler._loadModules (universal\dist\server.js:69796:87)
    at JitCompiler._compileModuleAndComponents (universal\dist\server.js:69757:36)
    at JitCompiler.compileModuleAsync (universal\dist\server.js:69673:37)
    at CompilerImpl.compileModuleAsync (universal\dist\server.js:86506:49)
    at PlatformRef.bootstrapModule (universal\dist\server.js:6666:25)
    at Object.Zq8w (universal\dist\server.js:113582:866)
    at n (universal\dist\server.js:113582:158)
    at Object.0 (universal\dist\server.js:113582:545)

I tried all solutions suggested:

Reinstall npm packages
Update typescript version
Update angular-cli version
Chack that there is no webpack in package.json
Change npm version (I tested it with v4 and v5)

I checked the compiled of dist/server.js, and found a problem in the property methodof NgModuleResolver:
NgModuleResolver.prototype.resolve = /**
     * @param {?} type
     * @param {?=} throwIfNotFound
     * @return {?}
     */
    function (type, throwIfNotFound) {
        if (throwIfNotFound === void 0) { throwIfNotFound = true; }
        var /** @type {?} */ ngModuleMeta = findLast(this._reflector.annotations(type), createNgModule.isTypeOf);
        if (ngModuleMeta) {
            return ngModuleMeta;
        }
        else {
            if (throwIfNotFound) {
                throw new Error("No NgModule metadata found for '" + stringify(type) + "'.");
            }
            return null;
        }
    };

The problem is, that the instansethis._reflector has no property annotations, but it has only these two properties [ 'builtinExternalReferences', 'reflectionCapabilities' ].
I do not know if the example is wrong configured, if it is a bug, or if there is problem in my computer?

In case anyone else find this article like i just did.
It turned out for me it was because in my main.ts i had:
const platform = platformBrowserDynamic(); platform.bootstrapModule(AppModule);
Changing this to:
platformBrowserDynamic().bootstrapModule(AppModule);
Resolved my problem.

thanks @jbiesta.
it slove my problem.

That fixed it for me too. That's silly!!

This unfortunately didn't fix the problem for me, I have explained in details the problem on this stackoverflow question, in hope it was not a bug but it appears to be one:
https://stackoverflow.com/questions/52892251/bootstrap-multiple-or-single-modules-based-on-url-in-main-ts

Facing same issue for AOT build, works fine with ng build --aot=false

Following answer solved my issue:
https://stackoverflow.com/questions/48871139/ng-build-throws-error-tried-to-find-bootstrap-code-but-could-not


Stringfix: Macintosh is not MediaAccessControl

Fixed "PowerMAC" strings 😄

As noted in the file header, these files are automatically generated from the output of QEMU. If it is changed in https://gitlab.com/qemu-project/qemu then we will update the file.

Ok thanks, will try it over there.


Doesn't work Music Assistant addon on Raspberry Pi 4 rpi4-64 Argon One

What version of Music Assistant has the issue?
2.0.0b5
The problem
I tried but doesn't work. :(
Raspberry Pi 4 rpi4-64 Argon One
Home Assistant 2023.1.7
Supervisor 2023.03.1
Operating System 9.5
Frontend 20230110.0 - latest
When i installed the Music Assistant Add-on, clicked the Start button, but not changed on Runing and green color point, it is still red color.
I can't use Music Assistant.
How to reproduce

Deleted old (HACS) Music Assistant on Settings/ Devices & Services/ Integrations.
Deleted source on HACS.
Restarted Home Assistant.
Added this link: https://github.com/music-assistant/home-assistant-addon
Refreshed site.
Searched and installed Music Assistant Beta (2.0.0b5) on Add-ons .
Clicked the Start button, but not changed on Runing and green color point, it is still red color.
Checked the Music Assistant Log.

Relevant log output
2023-03-14 21:50:16 INFO music_assistant -- Starting Music Assistant Server (a473959f8ad94c0e82xxxxxxxxxxaad8) on port: 8095 - autodetected IP-address: 192.xxx.x.xxx
2023-03-14 21:50:17 INFO music_assistant.streams -- Started stream controller (using ffmpeg version 4.3.5 with libsoxr support)
2023-03-14 21:50:49 INFO music_assistant -- Loaded metadata provider MusicBrainz Metadata provider
2023-03-14 21:50:49 INFO music_assistant -- Loaded plugin provider Frontend
2023-03-14 21:50:49 INFO music_assistant -- Loaded metadata provider TheAudioDB Metadata provider
2023-03-14 21:50:49 INFO music_assistant -- Loaded player provider Chromecast
2023-03-14 21:50:49 INFO music_assistant -- Loaded music provider URL
2023-03-14 21:50:49 INFO music_assistant -- Loaded player provider UPnP/DLNA Player provider
2023-03-14 21:50:49 INFO music_assistant -- Loaded player provider SONOS
2023-03-14 21:50:49 INFO music_assistant.metadata -- Start scan for missing artist metadata
2023-03-14 21:50:49 INFO music_assistant.metadata -- Finished scan for missing artist metadata
2023-03-14 21:50:49 INFO music_assistant.providers.slimproto -- Starting SLIMProto server on port 3483
2023-03-14 21:50:49 INFO music_assistant -- Loaded player provider Slimproto
2023-03-14 21:50:49 INFO music_assistant -- Loaded plugin provider JSON-RPC API
2023-03-14 21:50:49 INFO music_assistant -- Loaded metadata provider fanart.tv Metadata provider
2023-03-14 21:50:49 INFO music_assistant -- Loaded player provider Airplay
2023-03-14 21:50:50 INFO music_assistant.players -- Player registered: exxxxxxa-f6f3-a42e-c27a-1xxxxxxxxxx8/Kitchen speaker
2023-03-14 21:50:50 INFO music_assistant.players -- Player registered: 3xxxxxxd-3184-47eb-a1a6-3xxxxxxxxxx8/All speakers
2023-03-14 21:50:59 INFO music_assistant.players -- Player registered: 5xxxxxxc-dbba-6069-2b1b-2xxxxxxxxxxa/Bathroom speaker
2023-03-14 21:51:36 INFO music_assistant.players -- Player registered: 4xxxxxx6-8ace-0913-4623-cxxxxxxxxxxd/Bedroom speaker
Additional information
No response
What version of Home Assistant Core are your running
2023.1.7
What type of installation are you running?
Home Assistant OS
On what type of hardware are you running?
Raspberry Pi

The log seems to indicate it starts b so it is unusual. Can you post some of the screen captures you did before so we can see what you see?
I notice you aren’t running the latest version of HA. Would you be happy to upgrade to see if that fixes anything?

The log seems to indicate it starts so it is unusual. Can you post some of the screen captures you did before so we can see what you see? I notice you aren’t running the latest version of HA. Would you be happy to upgrade to see if that fixes anything? If you want to stay on your version of HA then you could go back to MA V1

When I wrote earlier, I tested HAOS 2023.3.3, Supervisor 2023.03.1, Music Assistant was 2.0.0b4.
Then these messages were:

I later read that the HACS version Music Assistant no longer works for HAOS 2023.3.3 and later versions, so I restored a previous save, HAOS 2023.1.7. Before the update, the Music Assistant worked fine, since I updated it to HAOS 2023.3.3, it has not worked since then, and it is useless to update it to HAOS 2023.1.7.
I currently have HAOS 2023.1.7 Music Assistant 2.0.0b5 up, according to the log it's fine, in fact it's like the Addon hasn't even been started.

I am completely at a loss.

It appears to be crashing. Do you have a minimum of 2gb of memory ?

Also look if the rest of your system is not consuming all memory, this looks an awful lot like OOM (out of memory) issues

It appears to be crashing. Do you have a minimum of 2gb of memory ?

Yes, 4Gb

ok thanks, strange!
it appears to be crashing right after it had connection issues to 2 cast players, maybe that is related but i doubt it.
Is there anything in the supervisor log right after it crashed ?
HA settings --> System --. Logs --> select Supervisor in the top right

Previously, the HACS version Music Assistant worked well under HAOS 2023.1.7.  Since I updated to HAOS 2023.3.3, it hasn't worked since then.  Even though I went back to HAOS 2023.1.7, it didn't work anymore.  Since I opened this issue, the HACS version is not up.
I just deleted the Music Assistant Addon, reinstalled it and saw something strange.  Did it show as if it was active, like it was running/or there was an update?  Not really.
Please look at the pictures.

I checked HA settings --> System --.  Logs --> select Supervisor but no error referring to Music Assistant.  I waited for about 15 minutes.

It looks like it is has installed correctly. You are also installing the latest which is good. But do you still have the issue that when you click on start it initially looks good but then just stops?

After installation, when I press the Start button, it charges for 3-4 seconds, but still does not switch to Running.  If I then press the Start button, the 3-4 second loading time is no longer there.
Never switched to Running.  There are also no new audio devices among the entities.

Updated Music Assistant 2.0.0b6 but same problem.
Please check the video .

Thanks. I don’t have much more at the moment but try turning on the watchdog and see what happens when you try and start it then. I also have found that after I have started sometimes I need to refresh my browser for the correct indications to be shown.

I am very sad that there is no way I will be able to upgrade to the new version.
Therefore, I would rather return to the old HACS version, I installed it again from HACS, but when I add it in the Settings/ Devices & Services menu, I get an error.
Error
Config flow could not be loaded: 500 Internal Server Error Server got itself in trouble.

There is no way to solve it?
Is there any way to make it work somehow?
I am still using HAOS 2023.1.7 .
My previous backup (HAOS 2023.1.7) includes the HACS version of Music Assistant, but it no longer works with that either.
It doesn't work since updating from HAOS 2023.1.7 to HAOS 2023.3.3, and I'm reloading HAOS 2023.1.7 to no avail.  :(

Yes sorry this isn’t working for you at the moment. Did turning on the watchdog make any difference?
Your situation is unusual as there are hundreds of people using V2 without this problem. Is there anything different about your setup?
Are you installing HAOS as per the first instructions here https://www.home-assistant.io/installation/raspberrypi/ (That is not container, not supervised, just the regular HA operating system on an SD card in a regular Raspberry  Pi (I see you refer to Argon One but I think that is just the case isn’t it?)
Have you a normal network setup? That is, a single subnet where you access your HA instance with HTTP not HTTPS.
If you have another SD card try installing a fresh version of HA and just add the MA add on and see if that works.

I use an M.2 SSD and unfortunately there is only one, no extras.
As far as I know, I'm using Raspberry HAOS.
I access HA from two addresses,
https://xxx.xxx.x.xxx:8123 (my fixed HA IP)
and
https://myduckdns.org:8123
Do you think Music Assistant v2 should work with the latest HA now?
Can you make an instructional video on how to properly remove the HACS version, how to install the new version, start it, and if it starts properly, what is the addon's icon, where, what entities appear, what options will there be when creating call service automation?
I think it would be a great help to many of us.

Let me ask the devs whether that internal https is a problem. People have had issues with V1 in the past….

Ok at the moment the thinking is that https is not the issue but we will continue to investigate.
The video is a good idea but unfortunately I am away from home at the moment. Let me step through your comments though.
If you don’t see MA listed in the HACS integrations then you have successfully removed it. People who had issues had problems removing the integration from HA SETTINGS.
In theory restoring a backup should allow you to install MA V1 but at least one other person has reported the same problem as you. We are stuck unfortunately as this is a HA issue which we can’t solve other than by moving forward and getting V2 up and running for all.
Installing the new version I think you are doing correctly. You just need to add the new repository to the add on store and then install the version with BETA in its name.
Currently there is NO integration for HA that works with V2. That is coming in a week or two. That means no icon, no entities and no automations. What you install is the MA server  which currently works standalone and will play your music.
Can you go to SETTINGS >> ABOUT and post the four lines of info from the top.

You have restored your HA instance to 2023.1.x and not 2023.2.x.
Solution here is either go to one version up to HA 2023.2 or check the versions of Music Assistant within HACS, somewhere tucked away it lets you choose a version and you can select the 2023.1 version of MA there

You can upgrade HA to a specific version as follows https://community.home-assistant.io/t/how-to-install-hassio-specific-version-includes-downgrade/54954/22
so you can try HA 2023.2.x Available versions are https://www.home-assistant.io/blog/2023/02/01/release-20232/

Something else is causing my problem.
Unfortunately, by accident, but I also experience the same error with another extension.
I stopped a previously installed and running extension, and when I want to start it again, according to the log, it starts, but for some reason it doesn't, and the extension icon is still gray and there is a Start button.
Unfortunately, I don't know what the source of the error could be, I can't figure out how to fix it.
I don't want to start with a completely clean HA system, because I already have a lot of work in it, on the dashboard, and I have a lot of automation.
I think that if I perform a clean installation and then restore the previous full backup (snapshot) then the error will still be present.
It's like my HA system crashed. :(

Oh my God!
I found the mistake!
I almost did a clean installation, but I thought I would not only turn off the power, but also shut down the machine within the HA system.
Then, as a last test, I turned on the Raspberry4 again, and miraculously, the system was restored.
At the moment, HAOS 2023.1.7 HACS version Music Assistant v1 is disabled, MA extension v2 is installed and it started without any problems. I added my Spotify account in the WebUI interface.
For several days, lots of HA reboots, backup reloads were all unnecessary.
The system was stuck for some reason, crashed.

Now how does MA v2 work, I would like to know what options there are regarding MA in the creation of HA automation?

Firstly, glad you have it working.
Secondly, I supplied a link that shows how to upgrade or downgrade to a specific HA version. Please refer to that if you need to do so in the future.
Lastly, the HA integration that will allow MA V2 to interact with HA is still a week or two away. So you can enjoy your music on MA and keep an eye on the updates for future capability enhancements.


Change UID to 10001

Purpose

Ensure containers run with a high UID to avoid host conflicts

Codecov Report
Patch coverage has no change and project coverage change: +54.09% :tada:

Comparison is base (9a26899) 26.01% compared to head (1898610) 80.10%.
Report is 8 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1592       +/-   ##
===========================================
+ Coverage   26.01%   80.10%   +54.09%
===========================================
  Files         268        9      -259
  Lines       31008      548    -30460
  Branches     4938      246     -4692
===========================================
- Hits         8068      439     -7629
+ Misses      22670      109    -22561
+ Partials      270        0      -270

Flag
Coverage Δ

adapter
?

common-controller
?

config-deployer-service
?

idp-domain-service
80.10% <ø> (ø)

router
?

Flags with carried forward coverage won't be shown. Click here to find out more.
see 259 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Add 3 missing disabled prisons

@alan if you could take a look at why the checks are failing, when you get a chance


Elysia main class has any type

When I hover "Elysia" class, it has the following data
(alias) class Elysia
(alias) const Elysia: typeof Elysia
import Elysia
───────────────────────────────────────────────
### Elysia Server
Main instance to create web server using Elysia
───────────────────────────────────────────────
*@example*
import { Elysia } from 'elysia'

new Elysia()
    .get("/", () => "Hello")
    .listen(8080)

but my app variable has type "any", and all the other methods like "use" and "listen" have type "any" and are not suggested.
Is this normal?
Here's my current code in index.ts:
import { Elysia } from "elysia";
import { html } from "@elysiajs/html";

const app = new Elysia()
    .use(html())
    .listen(8080);

console.log(`🦊 Elysia is running at ${app.server?.hostname}:${app.server?.port}`);

and tsconfig.json:
{
  "compilerOptions": {
<...some-options...>
    "types": [
      "bun-types"
    ]
  }
}

Have you set strict: true in tsconfig.json?

Hi same problem. I didn't have such a problem on my Mac computer. I started experiencing this on the Win 11 subsystem.
Error: Property 'state' does not exist on type 'Elysia<"", { request: {}; store: {}; }, { type: {}; error: {}; }, {}, {}, false>'.ts(2339)

tsconfig.json
{
  "compilerOptions": {
    "target": "ESNext",
    "jsx": "react",
    "module": "ESNext",
    "moduleResolution": "node",
    "types": ["bun-types"],
    "esModuleInterop": true,
    "forceConsistentCasingInFileNames": true,
    "strict": true,
    "noImplicitAny": true,
    "strictFunctionTypes": true,
    "skipLibCheck": true,
    "emitDecoratorMetadata": true,
    "experimentalDecorators": true
  }
}

setup.ts

import Elysia from 'elysia'
import { User } from './database/models/users'

const setup = new Elysia({
  name: 'setup',
})
  .state('User', User)
  .decorate('ApiResponse', (data: any) => {
    return new Response(JSON.stringify(data))
  })

export default setup

Closing as unable to reproduce, feels free to reopen a new issue if this problem still occurs.
Thanks.


⚠ Bofrost.fr has degraded performance

In fcbe866, Bofrost.fr (https://www.bofrost.fr) experienced degraded performance:

HTTP code: 200
Response time: 1827 ms

Resolved: Bofrost.fr performance has improved in 5ab1b40 after 10 minutes.


Bump chef-zero to 4.6.2+ to pick up logging level changes.

Chef Zero 4.5 is too verbose at info log level. In 4.6.2+ this logging was reduced to debug: https://github.com/chef/chef-zero/pull/216. Updates Chef's chef-zero dependency to make info logs less annoying.
@chef/client-core

👍

Hold on merging, this may not be necessary...


[Rel. 7.0.0] Broken Extension Override

The Problem in a Nutshell
First time initialization of VS Code Services with the Language Services Override extension fails with: this._fileService.onWillActivateFileSystemProvider is not a function. However, this issue doesn't persist when I downgrade to Version 6.0.3. Furthermore, I made sure that all of the packages are on the same version (either 7.0.0 or 6.0.3).
Other breaking extensions are listed in the last section of this issue.
Stack Trace
Uncaught TypeError: this._fileService.onWillActivateFileSystemProvider is not a function
    AbstractExtensionService2 abstractExtensionService.js:101
    ExtensionService2 extensionService.js:42
    ExtensionServiceOverride2 extensions.js:213
    _createInstance instantiationService.js:120
    _createServiceInstance instantiationService.js:224
    _createServiceInstanceWithOwner instantiationService.js:213
    _createAndCacheServiceInstance instantiationService.js:203
    _safeCreateAndCacheServiceInstance instantiationService.js:161
    _getOrCreateServiceInstance instantiationService.js:148
    get instantiationService.js:70
    startup lifecycle.js:38
    invokeFunction instantiationService.js:77
    startup lifecycle.js:36
    initialize2 services.js:211
    setup LSPSetup.ts:67
    <anonymous> LSPSetup.ts:90
    abstractExtensionService.js:101:41

Sample Code (Initialization)
await (async function setup() {
    const workerLoaders: Partial<Record<string, WorkerLoader>> = {
        editorWorkerService: () => new (toCrossOriginWorker(EditorWorker))(),
        textMateWorker: () => new (toCrossOriginWorker(TextMateWorker))(),
    }

    window.MonacoEnvironment = {
        getWorker: function (moduleId, label) {
            const workerFactory = workerLoaders[label]
            if (workerFactory != null) {
                return workerFactory()
            }
            throw new Error(`Unimplemented worker ${label} (${moduleId})`)
        }
    }

    /* Initialize Module */
    await initializeMonacoServices({
        ...getTextmateServiceOverride(),
        ...getThemesServiceOverride(),
        ...getKeybindingsServiceOverride(),
        ...getLanguageServiceOverride()
    });
})();

Sample Code (Usage)
let editor = monaco.editor.create(
      editorContainer.current!,
      {
          theme: 'Default Dark+',
          automaticLayout: true,
          scrollBeyondLastLine: false,
          model: null,
          lightbulb: { enabled: monaco.editor.ShowLightbulbIconMode.OnCode }
      }
  );

Relevant Parts of package.json
  "dependencies": {
    "@codingame/esbuild-import-meta-url-plugin": "^1.0.2",
    "@codingame/monaco-vscode-configuration-service-override": "^7.0.0",
    "@codingame/monaco-vscode-cpp-default-extension": "^7.0.0",
    "@codingame/monaco-vscode-editor-service-override": "^7.0.0",
    "@codingame/monaco-vscode-keybindings-service-override": "^7.0.0",
    "@codingame/monaco-vscode-textmate-service-override": "^7.0.0",
    "@codingame/monaco-vscode-theme-defaults-default-extension": "^7.0.0",
    "@codingame/monaco-vscode-theme-service-override": "^7.0.0",
    "monaco-editor": "npm<EMAIL_ADDRESS>    "monaco-languageclient": "^8.6.0",
    "vscode": "npm<EMAIL_ADDRESS>    "vscode-languageclient": "^9.0.1"
  },
  "devDependencies": {
    "@types/vscode": "^1.91.0",
    ... file truncated

Vite Configuration
import { defineConfig } from 'vite'
import react from '@vitejs/plugin-react'
import { nodePolyfills } from 'vite-plugin-node-polyfills'
import importMetaUrlPlugin from '@codingame/esbuild-import-meta-url-plugin'

// https://vitejs.dev/config/
export default defineConfig({
  plugins: [react(), nodePolyfills()],
  optimizeDeps: {
    esbuildOptions: {
      plugins: [importMetaUrlPlugin]
    }
  }
})

Final Observations

Downgrading all of the modules to v6.0.3 fixes the issues and everything works perfectly.
Taking off the Language Services Override prevents the fatal error but errors for other modules continue (example):

Uncaught (in promise) Error: Unable to load extension-file://vscode.theme-defaults/themes/dark_plus.json: Unable to read file 'extension-file://vscode.theme-defaults/themes/dark_plus.json' (Error: Unable to resolve nonexistent file 'extension-file://vscode.theme-defaults/themes/dark_plus.json')
    internalSetColorTheme workbenchThemeService.js:375
    setColorTheme workbenchThemeService.js:346
    current async.js:163
    promise callback*queue async.js:163
    setColorTheme workbenchThemeService.js:345
    setTheme theme.js:16
    setTimeout handler*setTheme/< theme.js:15
    promise callback*setTheme theme.js:14
    StandaloneEditor2 standaloneCodeEditor.js:166
    <anonymous> injection.js:11
    ConfiguredStandaloneEditor monaco.js:73
    _createInstance instantiationService.js:120
    createInstance instantiationService.js:94
    createConfiguredEditor monaco.js:261
    ... output truncated to relevant parts

I made sure that all of the packages are on the same version (either 7.0.0 or 6.0.3).

monaco-languageclient wasn't updated to use the v7, so I doubt you don't have duplicated dependencies.
What is the result of npm list vscode?

 I was wondering if there was some way to use the vscode-languageclient directly instead of using monaco-languageclient. I couldn't find any docs to integrate it using this API. Do you have any thoughts? Thanks a lot for the help :partying_face:

monaco-languageclient can help but it's not mandatory and vscode-languageclient can be used directly. There's nothing specific to that library, you can refer to the offical languageclient documentation.
This library allows to run a VSCode (web) extensions using vscode-languageclient, either by loading a vsix file, declaring it by hands in the code or even run it in the main thread (with the local extension host, which is probably the simpler way if you need to start/stop dynamically language clients).

Yeah that makes sense to me! Thanks a lot!


new page /:slug/:tier

E.g. /mochajs/backers
This should show the list of all backers with a search box on top to quickly find a given user by name.
It should be responsive.
Bonus point: /:slug/:tier.:format(json|csv)
(should return the same data in son or cvs format)

Problem we are trying to address: a meetup wants to "checkin" paid members at their next monthly meeting. Right now, it's painful for them to scroll on the phone.
This is the simplest solution we could think of. Feel free to propose other (easier) things to build.

That meetup is ConsciousnessHackingSF: https://opencollective.com/chsf
They have 100+ members.

note that this still needs an api endpoint.
On Fri, Sep 30, 2016 at 4:01 PM Ascari<EMAIL_ADDRESS>wrote:

Closed #167 https://github.com/OpenCollective/OpenCollective/issues/167.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/OpenCollective/OpenCollective/issues/167#event-808958901,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AF0vPbY9ylWgszi19-67y1kqhcWy7P7yks5qvWqigaJpZM4JL3ZE
.


dashboard: incorrect message

It says it's cold outside and to open a window but it's almost 100F out there 😅

Looking at the code, it doesn't look like there's any logic presently which modifies the message or image
https://github.com/swharden/iot-weather-station/blob/1d10c4ac29feba4d2c424811908c9c08b642b3ff/src/html/index.html#L86-L95


Sender Name not showing

When I send emails the sender name is not showing. It shows the "username" from<EMAIL_ADDRESS>const send = require('gmail-send')({
  user<EMAIL_ADDRESS>  pass: 'password',
  to: email,
  // from: 'John Doe', no matter what I put here it doesn't do anything.
  subject: emailSubject,
  text:    emailContent,
})

Try John Doe<EMAIL_ADDRESS>

Try John Doe<EMAIL_ADDRESS>
that didn't work but John Doe<EMAIL_ADDRESS>worked strangely

John Doe<EMAIL_ADDRESS>worked for me also, but the profile picture is not showing and it says: "Gmail cannot verify if domain send this email and not a spam author"

It cannot work until this patch is accepted: https://github.com/alykoshin/gmail-send/pull/6
@alykoshin it's really a showstopper... Pls help!


ApiClient uses guzzlehttp/guzzle 4.2

https://github.com/guzzle/guzzle/blob/master/UPGRADING.md
4.x to 5.0
Removed Fluent Interfaces:
GuzzleHttp\Post\PostBody
This is used in CL\Slack\Transport\ApiClient

@stefanbraspenning Sorry for the late reply and thanks for your contribution! I'm merging this to help others with the same issue, although I might have to adjust the Guzzle version later as I'm catching up on all the issues in the last few months.


Compatibility for Julia v 1.0.1

I mostly rewrote :

some functions definitions with the new syntax ' func(... : : T) where{T}'.

struct definitions with the keyword 'struct' instead of 'type'

old variables Vector{UInt8}(nbytes) to Vector{UInt8}(undef,nbytes)

After these modifications i was able to read some .mat files

And this shouldn't drop 0.6 support so you need Compat.SparseArrays instead. You'll also need to raise the Compat version required and for 1.0 compatibility changes Compat 1.0 should be good enough.

Sorry I made a mistake when updating this branch and it appears not revertable so I reopenned this as https://github.com/JuliaIO/MAT.jl/pull/102


Revert button doesn't appear in the editor after overriding any property value.

Operating system or device, Godot version, GPU Model and driver (if graphics related):
Windows 10 64 bits
Godot 3.0 Beta build 1
Issue description:
I was following the Step by step docs on Instancing, but when in "Editing Instances":
http://docs.godotengine.org/en/latest/learning/step_by_step/instancing.html#editing-instances
I found this wierd behavior: After overriding any property value of a node on an instanced scene, the revert button doesn't appear. You need to select another node and then back in order to refresh/redraw the property and the refresh button to appear.
Here's a gif:

I suppose the right behavior must be similar to when editing properties on the Project Settings:

Steps to reproduce:
Follow this step by step guide:
http://docs.godotengine.org/en/latest/learning/step_by_step/instancing.html#editing-instances
Until the section Editing Instances
Link to minimal example project:
instancing.zip

In this case, when a property is edited, tree emits signal and this callback is received:
https://github.com/godotengine/godot/blob/master/editor/property_editor.cpp#L3657
it may be possible that the code to check if the value is overriden is not being called. There is a complicated chain of property being changed set to be refreshed later that may not be working.

From what I could see, there's just 5 references to the "ReloadSmall" icon:

Three at the end of the update_tree() that makes all the checks:

If the property comes from an instanced node and it's different than the original on the instanced node.

bool mbi = _might_be_in_instance();
if (mbi) {

	Variant vorig;
	Dictionary d = item->get_metadata(0);
	int usage = d.has("usage") ? int(int(d["usage"]) & (PROPERTY_USAGE_STORE_IF_NONONE | PROPERTY_USAGE_STORE_IF_NONZERO)) : 0;
	if (_get_instanced_node_original_property(p.name, vorig) || usage) {
		Variant v = obj->get(p.name);

		if (_is_property_different(v, vorig, usage)) {
			item->add_button(1, get_icon("ReloadSmall", "EditorIcons"), 3);
			has_reload = true;
		}
	}
}

If the property can revert.

if (obj->call("property_can_revert", p.name).operator bool()) {

	item->add_button(1, get_icon("ReloadSmall", "EditorIcons"), 3);
	has_reload = true;
}

If the property has a default value specified on a script.

if (!has_reload && !obj->get_script().is_null()) {
	Ref<Script> scr = obj->get_script();
	Variant orig_value;
	if (scr->get_property_default_value(p.name, orig_value)) {
		if (orig_value != obj->get(p.name)) {
			item->add_button(1, get_icon("ReloadSmall", "EditorIcons"), 3);
			has_reload = true;
		}
	}
}

And two in the method _check_reload_status() being called after editing any property.

If the property can revert. (I saw that this works for example with the Settings properties)

if (obj->call("property_can_revert", p_name).operator bool()) {
	has_reload = true;
}

If the property has a default value specified on a script.

if (!has_reload && !obj->get_script().is_null()) {
	Ref<Script> scr = obj->get_script();
	Variant orig_value;
	if (scr->get_property_default_value(p_name, orig_value)) {
		if (orig_value != obj->get(p_name)) {
			has_reload = true;
		}
	}
}

And as I don't think that refreshing the entire tree for a single edited property was a good idea, I edited (Take a look at this pull request: https://github.com/godotengine/godot/pull/13958) the _check_reload_status method to add the checking code (missing, I think, because the update_tree method does three checks, and the _check_reload_status only two) before updating its reload buttons and the issue is gone.
I'll be following this issue to know the correct fix when someone that is familiarized with Godot source code fixes it.
Keep up the good work!


Cannot Generate Seed for RE1

Version
2.2.2 (81c73fc)
Seed
R610-EGNL-ZJHHHC7310009KM9H0GXZZZZZZZZZZZ
Scenario
RE 1 (Chris)
What happened?
Every time I try to generate a seed for RE1 I get the following error message and unable to play the randomizer for RE1:
"An error occurred during generation. Please report this seed and try another"
Here is a screenshot:

Attaching the logs as well:
log_pl0.txt
log_pl1.txt
The randomizer works perfectly for RE2. No issues when generating a seed for RE2.
NOTE: When trying to generate a seed last night for RE1 I got a slightly different error message saying "Run out of free item slots". If I get this error message again I will update this issue.

Also, wanted to add that the randomizer was working with RE1 up through version 2.1.7. Using the latest version (2.2.2) I started to get this error message.

UPDATE: Tried generating another seed (R610-JWPU-ZJHHHC7310009KM9H0GXZZZZZZZZZZZ) and received the following message:
"Run out of free item slots Please report this seed and try another."
Here is a screenshot:

Let me know if you need any additional details.
Loving these randomizers!! These are great :)

UPDATE: After this latest update (3.0.1), I was able to generate a seed for RE1 (and RE2 and RE3). I believe this issue is resolved.


php74, php80: 7.4.15 -> 7.4.16, 8.0.2 -> 8.0.3

Motivation for this change
Things done

[X] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[X] NixOS
[ ] macOS
[ ] other Linux distributions

[X] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[X] Tested execution of all binary files (usually in ./result/bin/)
[X] Determined the impact on package closure size (by running nix path-info -S before and after)
[X] Ensured that relevant documentation is up to date
[X] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 115973 at 82734e8c run on aarch64-linux 1

3 packages marked as broken and skipped:

libsForQt512.kcachegrind
pulseeffects-legacy
pulseeffects-pw

18 packages built successfully:

adminer
arcanist
engelsystem
icingaweb2
libsForQt5.kcachegrind (libsForQt515.kcachegrind ,plasma5Packages.kcachegrind)
libsForQt514.kcachegrind
lsp-plugins
matomo
matomo-beta
nagios
nextcloud-news-updater
phoronix-test-suite
php (php74)
php80
qcachegrind
unit
wp-cli
yle-dl


Release v0.7.0

[x] Bump PowerShellGet version (#378)
[x] Bump Chocolatey version
[ ] Finalize CHANGELOG.md
[ ] Tag v0.7.0
[ ] Push to Chocolatey
[ ] Push to PowerShell Gallery

Closes #353

@rkeithhill can you take a final pass through the change log, since you've been keeping it current? Everything else in this Milestone is marked done. Are we missing anything?

You added Test-PoshGitInProfile, right?  Is that supposed to be exported from the module?
I'm working on a PR for the CHANGELOG right now.

Ugh, looks like the EOL normalization messed up the Pester tests. I'll fix these tonight.

You added Test-PoshGitInProfile, right? Is that supposed to be exported from the module?

You added in #361 to support Add-PoshGitToProfile. I don't think it needs to be exported.

Ugh, looks like the EOL normalization messed up the Pester tests. I'll fix these tonight.

Fixed by https://github.com/dahlbyk/posh-git/pull/401.

Cool.  Thanks.

You added in #361 to support Add-PoshGitToProfile. I don't think it needs to be exported.

Sorry, What I was actually thinking of was Remove-PoshGitFromProfile.  I thought you had added such a command at one point but I can't find it.  So ... nevermind.

Sorry, What I was actually thinking of was Remove-PoshGitFromProfile. I thought you had added such a command at one point but I can't find it. So ... nevermind.

I had introduced it with #239, but pulled it out to keep the PR focused on Chocolatey. That commit now lives in https://github.com/dahlbyk/posh-git/compare/remove-from-profile, ready to be revisited if we deem it useful.

@dahlbyk  I think we are getting close.  I don't have anything else (issues/PRs).  The CHANGELOG.md is up-to-date AFAIK.  That said, I fully expect that after this is released into the wild, we'll be doing a 0.7.1 within weeks to a month.  Just the way it goes with the amount of code change we've made.

That said, I fully expect that after this is released into the wild, we'll be doing a 0.7.1 within weeks to a month. Just the way it goes with the amount of code change we've made.

👍
My wife's out of town this week, so off hours are limited, but I'll try to review #402 soon.

No problem.  I set a tentative release date of 2/14 - our Valentine's gift to the posh-git user community.  :-)

@dahlbyk I think this release is ready to cut loose.

[x] Tag v0.7.0
[x] Push to Chocolatey
[x] Push to PowerShell Gallery

Not quite as smooth as one might have hoped, but the release is out on Chocolatey and PowerShell Gallery.
Publish-Module apparently won't find modules that don't live in a folder of the same name:
C:\Dev\OSS\posh-git [release-v0.7.0 ≡]> publish-module -Path .\src  -NuGetApiKey 'deadbeef-dead-beef-dead-beefdeadbeef'
publish-module : The specified module with path '.\src' was not published because no valid module was found with that path.
At line:1 char:1
+ publish-module -Path .\src  -NuGetApiKey 'deadbeef-dead-beef-dead-bee ...
+ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : InvalidArgument: (.\src:String) [Publish-Module], ArgumentException
    + FullyQualifiedErrorId : InvalidModulePathToPublish,Publish-Module

Ah, that's why I typically have a "build release" stop that copies the contents of src into a .release\<module-name> folder and I publish from there.   Need to get back to work on PlasterBuild.  :-)

Ah, that's why I typically have a "build release" stop that copies the contents of src into a .release\<module-name> folder and I publish from there. Need to get back to work on PlasterBuild. :-)

I am content to discard the last two commits, if you think that's a better approach. The other benefit of using posh-git/ instead of src/ is that the hack from #392 could be reverted.

@Haacked @shiftkey if you want to start pulling an update into GitHub Desktop, I'd use v0.7.0. I'm not certain we'll keep the last few commits in this branch. Let me know if you have any issues!

Ah, that's why I typically have a "build release" stop that copies the contents of src into a .release\<module-name> folder and I publish from there. Need to get back to work on PlasterBuild. :-)

I am content to discard the last two commits, if you think that's a better approach. The other benefit of using posh-git/ instead of src/ is that the hack from #392 could be reverted.

@rkeithhill thoughts? I'd like to merge this to close the loop on v0.7.0, but am ambivalent between posh-git/ and src/. The former seems to have a couple advantages, and I'm not sure what a "release" process would do other than copy src/ elsewhere.

The build pipeline I'm about to start working on again in PlasterBuild has several additional steps that necessitate creating some sort of "output" dir whether that's called Release, .release,  or out.
The current thinking on the build pipeline is this:
Init, Clean, BeforeBuild, StageFiles, Analyze, Sign, AfterBuild, Test, BuildHelp, GenerateFileCatalog, Install, Publish

Not all of those steps are required.  Script signing is optional as-is using the markdown help generator and generating file catalogs.  And the Install and Publish build steps are primarily meant to be invoked manually.  Although I believe the PowerShell team wants module authors to start providing generating a file catalog.
Not to mention ~\GitHub\dahlbyk\posh-git\posh-git just looks weird to me.  :-)

:ok: dropped the commits to move from src/ to posh-git. Those changes, should wish to restore them:
0001-Move-module-files-from-src-into-directory-of-same-na.patch
0002-Revert-src-check-in-PSModulePath.patch


onPress disable imagezoom

i put onPress on <view, but i can`t let the imagezoom move the area, the onpress is disabling the main moving and panning

I have the same problem


Timer: Handle Chrome/Edge throttling

Received word from a professional pentration test that our session countdown timer was not working.  It has worked for years so I was surprised to fail this test.
Turns out in 2021 Chrome/Edge significantly changed the behavior of timers used on "inactive tabs".
See: https://usefulangle.com/web-updates/post/110/chrome-88-will-throttle-timers-1-minute

Anywhere you use window.setInterval, windows.setTimeout` you can replace with ...
window.setInterval = PrimeFacesExt.timers.setInterval;
window.setTimeout = PrimeFacesExt.timers.setTimeout ;
window.clearInterval= PrimeFacesExt.timers.clearInterval;
window.clearTimeout= PrimeFacesExt.timers.clearTimeout;

Just a note if you use CSP with this component or just to use the setInterval utitlies standalone you need to modify your CSP policy to allow worker-src 'self' blob:;
<context-param>
    <param-name>primefaces.CSP_POLICY</param-name>
    <param-value>worker-src 'self' blob:; script-src 'self'</param-value>
</context-param>

Anywhere you use window.setInterval, windows.setTimeout you can replace with ...
window.setInterval = PrimeFacesExt.timers.setInterval;
window.setTimeout = PrimeFacesExt.timers.setTimeout ;
window.clearInterval = PrimeFacesExt.timers.clearInterval;
window.clearTimeout = PrimeFacesExt.timers.clearTimeout;

Hello @melloware . If I understand correctly, the workaround is to prevent timer from stopping due to browser tab inactivity.
However, I don't see PrimeFacesExt.timers can be called from browser directly since it should be undefined.
Let's go to showcase for example, https://www.primefaces.org/showcase-ext/views/home.jsf

Anything I missed here? :thinking:

That showcase is old. PrimeTek has not deployed the latest yet.

Make sense. The commit was done https://github.com/primefaces-extensions/primefaces-extensions/commit/6c466f44af2ae485d7dee53a8a4e5595749b5376 in June, 2023 while the showcase build time was in April, 2023.

Yes, that's a good catch since this kind of issue might be non-trivial to discover. the tab inactivity throttling makes more sense in mobile devices but if that applies to all browsers including those in desktop devices, having the workaround to make sure the timer is accurate is really nice.

@jxmai latest showcase deployed!  https://www.primefaces.org/showcase-ext/views/home.jsf

Thanks for letting me know! PrimeFacesExt.timers exists now 👍


how to achive keycloak.init({ onLoad: check-sso }) in OIDC-client adapter

How do i achive this using oidc-client adapter . Using keycloak adpater I will get the user is authendicated or not authendicated if the use user is not authendicated I shall bring up my custom page. signinRedirect is directly taking me to the login page. I want to ask some information before the keycloak login page..
TIA..
keycloak.init({ onLoad: check-sso })
this.UserManager = new UserManager({
...IDENTITY_CONFIG,
userStore: new WebStorageStateStore({ store: window.sessionStorage }),
stateStore: new WebStorageStateStore({ store: window.sessionStorage })
});
I dont want to use localstorage.. if I use session storage it works fine for first time(untile browser have the keycloak cookies). if the user logged in then the session created and user info is stored in session. but I can not retriew the information in another tab. for example if user open one more tab and opens the app the session or empty untile I invoke the keycloak auth request..

All i need is if I have any method to get the userSession accross all the tab . Keycloak is maintaining separate cookies which we cannot read.

Instead of sessionStorage  you can use localStorage for the userStore. localStorage is accessible for the same application across TABs.

I struggle a lot with the whole think. Can you provide a working keycloak example please? How to setup the configuration?

You want in with oidc adaptor..
https://medium.com/@franciscopa91/how-to-implement-oidc-authentication-with-react-context-api-and-react-router-205e13f2d49 .. this link helps me to setup the keycloak with oidc-client-ts adaptor..

All i need is if I have any method to get the userSession accross all the tab . Keycloak is maintaining separate cookies which we cannot read.

Instead of sessionStorage you can use localStorage for the userStore. localStorage is accessible for the same application across TABs.

Due to security reason I dont want to use the localStorage..
I tried with signinSilent  but it shows error in new tab, if we add any param in signinRedirect which will return me the flag saying user is authendicated or not authendicate .
Currently signinRedirect shows the login page if the useris not logged In, we dont have a control to decide wheater should we show the login page or not.. It would be good if it send us the promise saying authendicated / not authendicated .

I have found a solution for this , we need to send a param to signinRedirect method to achieve this, I am using it in this way , on new tab if the session is not available then i will call signinRedirect({ prompt:'none' }) like this , if cookies are present in the browser then the app will auto login , if the cookies not availble then catch block will be triggered in "signinRedirectCallback"  method, I have written code inside signinRedirectCallback catch to navigate my custom login page.

Summary is : call signinRedirect method with ({ prompt:'none' }) to avoid the login screen


add json schema generation

Add the toJSONSchema method to generates the json schema document.

A few inline comments here and there, but that looks awesome :+1:


Photo thumbnails white on iPhone app run on iPad

Hi!
When an iPhone app in run on iPad (in my case iPad AIR) in so called compatibility mode (iPhone4 size) thumbnails for images are present (can be selected - selection is visible), but entire screen is white. It is possible to reproduce this issue on real device and on simulator. If example code is needed, please let me know.

https://openradar.appspot.com/25813088
https://forums.developer.apple.com/thread/43400


Notification system

We should implement a more sophisticated notification system to queue snackbars in the future, but for now what we have works.

Code currently has 3 sec delay function after each backend command to display snackbar. Remove delay(ms) once better notification system is implemented.


Bower dependency management fails due to missing bower.json

Rangy not being picked up by dependency injectors, because they have no way of knowing what the main file is for rangy. package.json has the main property, but these injectors often look to a bower config for the same property. I couldn't find such a config in this repository.
As a result, rangy is missing among dependencies managed by for example grunt wiredep. Also see https://github.com/fraywing/textAngular/issues/144#issuecomment-91470030 for an example of this when depending on textAngular.
<!-- bower:js -->
<script src="bower/textAngular/src/textAngular.js"></script>
<script src="bower/textAngular/src/textAngular-sanitize.js"></script>
<script src="bower/textAngular/src/textAngularSetup.js"></script>
... bower/textAngular/dist/textAngular-rangy.min.js missing ...
<!-- endbower -->

I need to look into this, but I'm sure you're right, so why have you closed it?

Because the various rangy files were included properly as dependencies to https://github.com/fraywing/textAngular. I didn't look carefully enough.
The confusion was because textAngular was talking about a provided range.min packaged with textAngular, which was not picked up by wiredep. The normal rangy dependencies however were and it worked fine.

Great.


Trigger the DALLE 2 image generation API and pass the input user prompt and get/save the resulting image response

https://github.com/sopra-fs23-group-15/envisage-server/pull/74

https://github.com/sopra-fs23-group-15/envisage-server/pull/74/commits/b761dedc9233e98ca4cdf789bfef2c4e1c5993e7


[INTERNAL][FIX] sample name: Controller Extension

The name for the list item in #/sample/ was incorrectly defined as "Control Extensions" whereas it should be "Controller Extensions".
Fixes: https://github.com/SAP/openui5/issues/2249

Hello UI5 colleagues,
Could you please update/close the reported bug after the pull request is processed?
https://github.com/SAP/openui5/issues/2249
Kind Regards,
Elena


[WIP] Delegates management PoC

What it solves
Part of https://github.com/safe-global/safe-pm/issues/85
How this PR fixes it
A new Settings page was added under Delegates where it is possible to manage Safe delegates through the UI
How to test it
Go to Settings/Delegates and if you are a Safe's owner you will be able to add/remove delegates and modify existent delegates labels
Related tasks

[ ] Use Client GW SDK for /delegates calls once https://github.com/safe-global/safe-react-gateway-sdk/pull/72 is merged

Screenshots

The CRUD looks great! Is it not possible to use the CGW atm? We should also save the delegates to the store so we can reference it to allow for delegate transaction proposal.

Despite having set a task to "implement delete all delegates" it seems there is no such endpoint AFAIK -> https://github.com/safe-global/safe-client-gateway/blob/main/src/routes/delegates/routes.rs

Despite having set a task to "implement delete all delegates" it seems there is no such endpoint AFAIK -> https://github.com/safe-global/safe-client-gateway/blob/main/src/routes/delegates/routes.rs

There are two delete endpoints. You can also use my open gateway SDK PR as a reference.


Document novelty voices from Apple

Apple preloads a number of novelty voices by default on macOS (multiple languages) and iOS/iPadOS (English only).
These novelty voices are more harmful than helpful for a read aloud feature and are unfortunately localized, which makes their detection more difficult than it should be.
With native APIs and Firefox, there might be ways of detecting them based on their package name, but that's not the case elsewhere.
In order to filter them out, we'll need to document these voices just like we do it for recommended voices. I'll use a separate JSON file specifically for that.
List of languages to support:

[ ] Arabic
[ ] Basque
[ ] Bhojpuri
[ ] Bulgarian
[ ] Catalan
[ ] Chinese
[ ] Croatian
[ ] Czech
[ ] Danish
[ ] Dutch
[x] English
[ ] Finnish
[x] French
[ ] Galician
[ ] German
[ ] Greek
[ ] Hebrew
[ ] Hindi
[ ] Hungarian
[ ] Indonesian
[x] Italian
[ ] Japanese
[ ] Kannada
[ ] Korean
[ ] Malay
[ ] Marathi
[ ] Norwegian
[ ] Persian
[ ] Polish
[ ] Portuguese
[ ] Romanian
[ ] Russian
[ ] Slovak
[ ] Slovenian
[x] Spanish
[ ] Swedish
[ ] Tamil
[ ] Telugu
[ ] Thai
[ ] Turkish
[ ] Ukrainian
[ ] Vietnamese

After further investigation, it seems that these localized names are only used by Apple in its UI and not through the Web Speech API.
This is great news, since we can drop localized names and complete this task.


[$1000] VBA - Cannot select the checkbox when a valid field is being focused entering bank account manually

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Open Settings => Workspace => Choose any workspaces => Connect Bank Account => Connect Manually.
Notice that  Routing Number  is being focused and no error is showed, click on check box
Again focus on the Routing Number and click on check box

Expected Result:
Checkbox should be selected and focused at the first click
Actual Result:
Checkbox is not selected when a valid field is focused for the first time
Workaround:
unknown
Platform:

Where is this issue occurring?

Web
iOS
Android
Desktop App
Mobile Web

Version Number: 1.2.34-1
Reproducible in staging?: y
Reproducible in production?: y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:
https://user-images.githubusercontent.com/43996225/204901005-ae449d44-dbd9-484c-ab01-1ffbbb182ab9.mp4
https://user-images.githubusercontent.com/43996225/204901029-5abe71aa-3602-4fa4-8b60-5f0fa5b7bbd1.mov
Expensify/Expensify Issue URL:
Issue reported by: @hungvu193
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1669819241231349
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01a77f27abe4f6fc46
Upwork Job ID:<PHONE_NUMBER>212991488
Last Price Increase: 2022-12-15

Proposal
There is no easy fix to it because onBlur on the text field gets called first (which in turn causes validate, which changes the layout). Since the layout is changed after onBlur, the click event never gets fired.
Solutions
We can:
a. On the checkbox, use onMouseDown instead of onClick. This will ensure that the click event fires before the layout gets a chance to change. However, onMouseDown is different from onClick in the sense that it gets triggered on all type of clicks. We can sort of make up for this by checking the button type in the event that gets passed to onMouseDown.
b. Add a condition inside the onBlur method of the field such that if the role of relatedTarget is a checkbox, then skip calling the validate method. ie
diff --git a/src/components/Form.js b/src/components/Form.js
index 34199bd4f..e84d95521 100644
--- a/src/components/Form.js
+++ b/src/components/Form.js
@@ -217,9 +217,11 @@ class Form extends React.Component {
                 ref: node => this.inputRefs[inputID] = node,
                 value: this.state.inputValues[inputID],
                 errorText: this.state.errors[inputID] || fieldErrorMessage,
-                onBlur: () => {
+                onBlur: (e) => {
                     this.setTouchedInput(inputID);
-                    this.validate(this.state.inputValues);
+                    if (e.nativeEvent.relatedTarget.role !== 'checkbox') {
+                        this.validate(this.state.inputValues);
+                    }
                 },
                 onInputChange: (value, key) => {
                     const inputKey = key || inputID;

Let me know which approach makes more sense and I'll implement that one.

I am casting a vote for "do nothing". The blur happens first and causes the layout shift. We shouldn't try to interfere with that. Our forms are design to get you to address errors and resolve them so I think this behavior would be more than tolerated (and probably unusual for anyone to actually do).

Proposal
Problem
Event execution order: mousedown -> blur -> click, so the blur happens cause layout change, then click event targets to wrong component.
Solution
we can implement the behavior as ios/android is to keep focusing when click checkbox
In https://github.com/Expensify/App/blob/820e876d5e4a8cbffe272220c1182c8942ed93cf/src/pages/ReimbursementAccount/BankAccountManualStep.js#L114
<CheckboxWithLabel
                        style={styles.mt4}
                        inputID="acceptedTerms"
+                       onMouseDown={(event)=>{
+                           event.preventDefault();
+                           event.stopPropagation();
+                        }}
...

In https://github.com/Expensify/App/blob/820e876d5e4a8cbffe272220c1182c8942ed93cf/src/components/CheckboxWithLabel.js#L92
                    <Checkbox
                        isChecked={this.isChecked}
                        onPress={this.toggleCheckbox}
+                       onMouseDown={this.props.onMouseDown}
                        label={this.props.label}
                        hasError={Boolean(this.props.errorText)}
                        forwardedRef={this.props.forwardedRef}
                    />
                    <TouchableOpacity
                        focusable={false}
                        onPress={this.toggleCheckbox}
+                       onMouseDown={this.props.onMouseDown}
...

https://user-images.githubusercontent.com/113963320/205027080-94346535-8147-44b4-8de0-79d4045883ea.mp4

This could be a duplicate of https://github.com/Expensify/App/issues/12715

I don't think it's a dupe, but similar. The fix for the ToS link is on staging and this issue with the checkbox still remains.

I am casting a vote for "do nothing". The blur happens first and causes the layout shift. We shouldn't try to interfere with that. Our forms are design to get you to address errors and resolve them so I think this behavior would be more than tolerated (and probably unusual for anyone to actually do).

I tend to agree @marcaaron, though the fact it works fine on native but not Web is an inconsistency. Not sure if that wholly sways the opinion here, but if it's simple enough to remove that inconsistency, it could be worth it.

I'm a little concerned about the proposals we've got. The mouse down solution is missing some explanation for why a "mouse down" gets fired before a "blur" but a "click" happens after. And adding checks to the blur handler to "cancel the blur" really goes against out current design. On blur the error should be shown. I don't think we really need to make exceptions to that and I think users will have a high tolerance for a small issue like this.

😞

Coming back here. Why doesn't mobile work the same as web on this form, could we look at what explanation there is for why it isn't consistent? I think our options boil down to:

Live with the inconsistency between web and mobile (i.e do nothing)
Fix web to not lose focus on the field when clicking the checkbox (i.e like on mobile)
Fix mobile to lose focus on clicking the checkbox (i.e like on web)

Huh, those are good questions. Maybe we bring this to Slack to align on the behavior?

Yah mon, posted here.

Discussion going on in the thread.

The latest of where we're at on the expected behaviour from the thread is:

The correct behavior for mWeb and mobile would be:

Field gets blurred (you interacted with another field so the one that was focused should get blurred now)
Checkbox is checked (a blur event shouldn’t necessarily block the checkbox from getting pressed)

I have an outstanding question for @marcaaron re: platform consistency, but I believe this should be implemented consistency across web, desktop, mobile and mWeb.
I'm going to add the External label in the meantime to get this one moving.

Waiting for clarity on the expected result...

I think that how it works on web. When you press the checkbox, the input will lose its focus and now the checkbox has the focus. The issue is similar to https://github.com/Expensify/App/issues/12715, but it only fixes the ToS TextLink with onMouseDown similar to @tienifr proposal but the checkbox still does not implement the onMouseDown solution.
https://github.com/Expensify/App/blob/a414d1a30c1726ae6dcfd44d4f28e1ccaf3b7cdf/src/pages/ReimbursementAccount/BankAccountManualStep.js#L128-L135
Why on native the input does not lose its focus? It's because we set the keyboardShouldPersistTaps to handled, which prevent the focus loss when a click inside the Form is handled, in this case the checkbox (or the ToS, or the fix the errors).

I think we have decided to not work on these issues for now and re-visit them after all the Form refactors are complete, we are planning to create a tracking issue for these type of issues. (More details)

@thesahindia Do we have that tracking issue yet?

Just sharing my findings may be issue will resolve after refactor.
https://github.com/Expensify/App/issues/13211#issuecomment-1334047967
The mouse down solution is missing some explanation for why a "mouse down" gets fired before a "blur" but a "click" happens after.
Actually its not changing the any order here
preventDefault will stop the event bubbling in the case input field will not get any outside click event. so link onPress will work as it should be.
Here input onBlur calling due to Linking. App focus is leaving when user going outside of app bcz link opening in new tab.
So its working like this with preventDefault
onPress Link => Linking.openURL => Input onBlur
Now why its not working without preventDefault - Due to form component.
If there is any error changes state change trigger
if (!_.isEqual(errors, this.state.errors)) {
this.setState({errors});
}
on state change form component will re-render and it will trigger childrenWrapperWithProps function. Now every children of form component will recreated with  React.cloneElement and in this case onValueChange will be lost. so for both issue reason is same form component is recreating elements on onBlur due to state change. In this case old component handlers will canceled or lost.

@jatinsonijs Are you saying because that state changed the input blur place before the checkbox click?

Still hold...

According to this SO I am meant to unassign the assigned BZ team member when a bug is on hold, because I am assigned to the tracking issue here

@trjExpensify do you want to handle this together since it seems like you put the callout to ensure form validation is consistent?

Yep, makes sense because this issue hasn't gone anywhere yet really!

Still hold...

Still on hold.

Not overdue

Still held on the overarching form validation tracker.

Still held, but we have someone picking up the form validation project at large now. Woop!

Still the same here, Melv.

Not overdue

Still held.

Held

👋 The tracking issue this was held on has been completed now. I just re-tested this issue and the checkbox is checked on first click now as expected. @muttmuure, I've removed the hold from this issue title, dropped it back to daily,  and you can proceed to process the $250 payment to @hungvu193 for this initial bug report.

@trjExpensify Thank you, I've just applied

Thanks Tom!


Use a proper logging library instead of console.x()

Unfortunately there is no standard logging library all JS projects use, so continuing to use console.warn() is probably for the best.


Video content auto downloads when navigating to record page

When navigating to this record, a video is automatically downloaded. This was found in Chrome.

I am closing this issue since we should migrate away from record soon.


OpenAIRE not harvesting metadata

If you click on "Research Data" at https://www.openaire.eu/search/dataprovider?datasourceId=re3data_____::fe0d76581a60e1287a93e2ed2cb29339 you see that the titles, descriptions etc. of resources are not harvested (correctly).  The Czech repo doesn't have this problem: https://explore.openaire.eu/search/dataprovider?datasourceId=re3data_____::a507cdacc5bbcc08761c92185dee5cab
This might be fall-out from the fact that we are 593 commits behind ufal:clarin, but maybe not, so better have an issue on this problem.

Just to note that this should be probably cross-referenced to #13. Also assigning @cyplas to this.

Ondrej says this has been fixed (https://github.com/ufal/clarin-dspace/pull/947) and should be included in the next release.
If it seems urgent, I can try to incorporate the fix sooner, but I would prefer not to do that, as I would have to cherry-pick commits, which risks breaking other functionality.

Ondrej says this has been fixed (ufal#947) and should be included in the next release.

That is good news - but it's funny, because last time I checked it actually worked for UFAL, but not for us.

If it seems urgent, I can try to incorporate the fix sooner, but I would prefer not to do that, as I would have to cherry-pick commits, which risks breaking other functionality.

No, not so urgent - we might as well wait for the official release.
Let's leave this issue open until it is fixed.

That is good news - but it's funny, because last time I checked it actually worked for UFAL, but not for us.

That may well be, as they may well be deploying from a dev branch.

The problem seems to have been solved with the new release, (cf. eg. https://explore.openaire.eu/search/dataprovider?datasourceId=re3data_____::fe0d76581a60e1287a93e2ed2cb29339) so closing.


Fix duplicate data-testid on system tabs

Closes #
Description Of Changes
A Plus Cypress test was failing due to finding two elements with data-testid system-tabs, this fixes by removing it from the TabContent element (that testid was newly introduced by #4922 and is not being used).
Pre-Merge Checklist

[ ] All CI Pipelines Succeeded
[ ] Issue Requirements are Met
[ ] Update CHANGELOG.md

Thank you Jeremy! ⭐


[objc] Add ProcessedAssembly and uniqueness validation

Detect any duplication based on the assembly (internal) name and also
it's sanitized (safe) name. Otherwise generated code won't work;

Avoid recomputing the name (or safe name) whenever possible;

Adjust unit tests for some code movement that ease reuse;

Build and tests passed.


[Hub Generated] Review request for Microsoft.Consumption to add version stable/2023-03-01

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
ARM API Information (Control Plane)
Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo.  If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.
Changelog
Add a changelog entry for this PR by answering the following questions:

What's the purpose of the update?

[ ] new service onboarding
[ ] new API version
[ ] update existing version for new feature
[ ] update existing version to fix swagger quality issue in s360
[x] Other, please clarify

When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

[x] I commit to follow the Breaking Change Policy of "no breaking changes"
[x] I have reviewed the documentation for the workflow.
[ ] Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist

Applicability: :warning:
If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

Change to data plane APIs
Adding new properties
All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

[x] Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review.  Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

Adding a new service
Adding new API(s)
Adding a new API version
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.

[x] Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

[ ] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist
If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.
NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)
Please follow the link to find more details on PR review process.

/azp run unifiedPipeline

/azp run unifiedPipeline

/azp run unifiedPipeline

/azp run unifiedPipeline

/azp run unifiedPipeline

/azp run unifiedPipeline

/azp run unifiedPipeline

/azp run unifiedPipeline

/azp run unifiedPipeline

/azp run unifiedPipeline

/azp run

@pthippeswamy Please fill in the correct checkboxes in the first comment so we can get a quick overview of what's going on with this PR and make sure you've understood the relevant linked docs. Then fix CI validation errors.

@pthippeswamy Please fill in the correct checkboxes in the first comment so we can get a quick overview of what's going on with this PR and make sure you've understood the relevant linked docs. Then fix CI validation errors.

PLease fix this comment before re-starting the ARM review

/azp run unifiedPipeline

/azp run unifiedPipeline

/azp run unifiedPipeline

/azp run unifiedPipeline

/azp run unifiedPipeline

/azp run unifiedPipeline

/azp run unifiedPipeline

Thanks for sharing and helping.

@pthippeswamy Please fix CI check error.

/azp run

Breaking change ADO - approved - https://msazure.visualstudio.com/One/_workitems/edit/23289060
Met with Suhas Rao to discuss about the errors seen on the PR.
Have reached out to Breaking Change team to clarify about the documentation and will update the PR once we get an approval from Breaking change team.
On the Linter error "path-for-resource-action" - This API is a tenant level API that is already in PROD and used by customers and the path cannot be modified. We are documenting the API that was missed.

@konrad-jamrozik Based on the above comments, can Swagger LintDiff error in this PR be approved?

Breaking change ADO - approved - https://msazure.visualstudio.com/One/_workitems/edit/23289060
Met with Suhas Rao to discuss about the errors seen on the PR.
Have reached out to Breaking Change team to clarify about the documentation and will update the PR once we get an approval from Breaking change team.
On the Linter error "path-for-resource-action" - This API is a tenant level API that is already in PROD and used by customers and the path cannot be modified. We are documenting the API that was missed.

@konrad-jamrozik Based on the above comments, can Swagger LintDiff error in this PR be approved?

@bdefoy @rkmanda can you have a look at this potential false positive and advise how to proceed?

/azp run unifiedPipeline

@qiaozha @msyyc @tadelesh Could you help to take a look at the SDK BreakingChange error in this PR? Thanks

Breaking change ADO - approved - https://msazure.visualstudio.com/One/_workitems/edit/23289060
Met with Suhas Rao to discuss about the errors seen on the PR.
Have reached out to Breaking Change team to clarify about the documentation and will update the PR once we get an approval from Breaking change team.
On the Linter error "path-for-resource-action" - This API is a tenant level API that is already in PROD and used by customers and the path cannot be modified. We are documenting the API that was missed.

@konrad-jamrozik Based on the above comments, can Swagger LintDiff error in this PR be approved?

@bdefoy @rkmanda can you have a look at this potential false positive and advise how to proceed?
@bdefoy @rkmanda @konrad-jamrozik -- Could you please let us know if there is anything needed from us for the PR to get merged? ARM team signed off on the PR. Please let me know if any information is needed. We have a deadline to get this merged asap, so appreciate all your help on this!

@pthippeswamy , please ping the ARM api review on call person to evaluate above justification of linter error.

Task to track if API can be migrated to compliant path - Bug 24126550: Pricesheet path is not ARM API compliant

As this API is already being used in production by customers, and just the swagger was out-of-date for the production API, the author wants to get exception to allow this API to be used in the swagger. Their team is discussing internally to migrate to RPC-compliant API in near future, tracked via: https://github.com/Azure/azure-rest-api-specs/pull/23914#issuecomment-1568801060.

@pthippeswamy Please fix SDK azure-sdk-for-go error : https://github.com/Azure/azure-rest-api-specs/pull/23914/checks?check_run_id=13737425507.  You can refer to tadelesh's comments to fix it.

/azp run

/azp run unifiedPipeline

/azp run unifiedPipeline

/azp run unifiedPipeline

/azp run unifiedPipeline

/azp run unifiedPipeline

/azp run unifiedPipeline

tadelesh's

@tadelesh @v-jiaodi - Regarding the errors due to "consumption.json" file - I tried correcting the errors around "error-response" and checked in the file to mitigate the SDK azure-sdk-for-go error but it resulted in file showing up 88 more errors.
Consumption.json file is shared across many teams and has APIs that we are not aware of and are unrelated to the API we are documenting.
Could you please consider this and provide “Approved-Lint Diff” label on the PR to allow documentation to go forward? thanks.

/azp run unifiedPipeline

tadelesh's

@tadelesh Chenjie Shi FTE @v-jiaodi Di Jiao (WICRESOFT NORTH AMERICA LTD) Vendor - Regarding the errors due to "consumption.json" file - I tried correcting the errors around "error-response" and checked in the file to mitigate the SDK azure-sdk-for-go error but it resulted in file showing up 88 more errors. Consumption.json file is shared across many teams and has APIs that we are not aware of and are unrelated to the API we are documenting.
Could you please consider this and provide “Approved-Lint Diff” label on the PR to allow documentation to go forward? thanks.

I have already added some directive to handle it in Go SDK. Perhaps, you could revert your change.

tadelesh's

@tadelesh Chenjie Shi FTE @v-jiaodi Di Jiao (WICRESOFT NORTH AMERICA LTD) Vendor - Regarding the errors due to "consumption.json" file - I tried correcting the errors around "error-response" and checked in the file to mitigate the SDK azure-sdk-for-go error but it resulted in file showing up 88 more errors. Consumption.json file is shared across many teams and has APIs that we are not aware of and are unrelated to the API we are documenting.
Could you please consider this and provide “Approved-Lint Diff” label on the PR to allow documentation to go forward? thanks.

I have already added some directive to handle it in Go SDK. Perhaps, you could revert your change.

Yes, I did not check in anything for the sdk-for-go error.

@tadelesh Chenjie Shi FTE @v-jiaodi

@tadelesh Chenjie Shi FTE @v-jiaodi - Could you please let me know if anything is needed from my end on the PR?

approved lint diff due to arm comment

Go SDK breaking changes are not introduced in this PR. Approved.


Add A11y Section: eslint-plugin-vue-accessibility

General

✏ Mark the necessary items without changing the structure of the PR template.

[x] Pull request template structure not broken

Type

ℹ  What types of changes does your code introduce?

👉 Put an x in the boxes that apply

[ ] Fix
[x] Feature

Checklist

ℹ  Check all checkboxes - this will indicate that you have done everything in accordance with the rules in CONTRIBUTING.

👉  Put an x in the boxes that apply.

[x] Title as described
[x] Make sure you put things in the right category!
[x] Always add your items to the end of a list

Open Source

[x] Link description does not contain a link to an author / third-party resource
[x] The documentation (README) contains a description of the project, illustration of the project with a demo or screenshots and a CONTRIBUTING section
[x] The documentation is in English.
[x] The project is active and maintained.
[x] The project accepts contributions.
[x] Not a commercial product

Apps/Websites

[ ] The website is available without errors or ssl certificate problems, and load in a reasonable amount of time.
[ ] The website is using vuejs intensively. It should detect vue with vue-devtools.

If you cannot detect vue with vue-devtools due to work at non public pages (e.g. for enterprise website), you can send Pull Request with screenshot that detected it.

[ ] The website is original and not too simple. For that reason, blogs and simple landing pages are rejected.
[ ] A commercial product using Vue, provided that guests could reasonably check out how Vue was used A commercial product using Vue, provided that guests could reasonably check out how Vue was used (i.e. A headless CMS which uses Vue for the Admin/editor Area and offers a free tier).

eslint-plugin-vue-a11y has not been updated for about 3 years. eslint-plugin-vue-accessibility, the successor to eslint-plugin-vue-a11y, is updated regularly, so we have added this resource for reference.
Please confirm it!


refactor root.preRun to support composition

The root.preRun func assigned to rootCmd.PersistentPreRunE relies
on Project.Open(), which assumes all child commands will want to operate
on an existing Project.
While it's no big deal to assign root.PreRunNoop, that actually seems to
mess with a couple of the truly shared global flag handlers.
For example, log-level, chdir and dry-run are handled in the
root.preRun right now. This makes the PreRunNoop trick come
with the odd side-effect of those flags being unhandled.
The Cobra command.SetGlobalNormalizationFunc might be abused to handle
flag-triggered actions, but that seems dangerous as well. :skull:
As a starting point, this PR separates out the Project.Open() and the other
calls, which makes it easier to compose a custom PersistentPreRunE in
child commands that don't assume a Project already exists.
This is necessary for the work I'm doing today on #229 (which will come in a different PR).
Any better ways of handling this would be awesome. Decomposing the flag-triggered stuff
even further might be good to consider.

oops might need to rebase, I just pushed a rebase getting rid of some of the merge commits in master

So far it hasn't been a big concern, the only commands that use the no-op don't really do any AWS related stuff so the log level / dry run not working is ok, but it's definitely not ideal

I will resolve the conflicts, @tj - I'm still working on the generator feature, so it's pretty easy.
On the noOp thing - the global flags not being globally-handled definitely tripped me up - I was assuming, for example, that the dry-run service would be wired up, because I wanted to support the dry-run flag in the #229 generator stuff. But since I can't have Project.Open() errors kill my command, I had to noOp it, and then there was no dry-run stuff set up... yadda yadda :loop:
Lemme rebase and I can toss a subordinate PR up in a while that shows a preview of a #229 implementation, so the issue is more clear.

cool looks good to me now! thanks


[PORT] pos_longpolling from 8.0 to 9.0

@GabbasovDinar lint errors need to be fixed here

@ilmir-k DONE


Import messages to a Team/Channel in migration mode fails with bad request and no other information

Hello, I am using postman with a valid access token to POST to a team/channel in migration mode.  The POST body is a copy of the page example using my valid tenant email id as the user id:
{
"createdDateTime":"2019-04-04T19:58:15.911Z",
"from":{
"user":{
"id":"",
"displayName":"",
"userIdentityType":"aadUser"
}
},
"body":{
"contentType":"html",
"content":"Hello World"
}
}
The response I get is:
{
"error": {
"code": "BadRequest",
"message": "Bad Request",
"innerError": {
"date": "2020-10-23T14:31:08",
"request-id": "e7094f9e-f7cc-4850-a22b-be0803d836a3",
"client-request-id": "e7094f9e-f7cc-4850-a22b-be0803d836a3"
}
}
}
Any ideas here?

@matt-wright , Could you please help us to understand the problem you are facing ?

hello, I have successfully created a team/channel in migration mode but yet when attempting to add an actual message as per the above returned json, I only get a BadRequest. Is there a way to query the request id to retrieve more details as to the exact problem with the bad request?  Excepting for the createdDateTime edited to ensure it is later than the back in time team/channel timestamp.  I am only using my valid aaduser id as my corp email.  If I change to an invalid email, I get a response to that affect that the user doesn't exist in our Teams AD instance.  So what is the problem is that it mentions bad request but I have no further information as to why that is the case.

I'd like to know why I am getting a BadRequest please?

Not much help here, why is that?  So it turns out, while the id field will indeed accept a userPrincipalName value and, complain if it isn't a valid aaduser, it will throw the BadRequest error when an attempt to POST a new message to the channel is performed.  The id value uses MUST be the user's actual retrieved id value of their AAD record using the https://graph.microsoft.com/v1.0/users/ call.


I would like to change the code little bit, i want to actuly append to the output file not just write, i made chages in code, just I dont know How to create jar file with modified code, can you help me with that?

Hi, I have the same issue as well! I'm modifying the code so the information will be delimited with commas(,) instead of semicolons(;)


webpack-obfuscator not working on Firebase deployment

https://togithub.com/javascript-obfuscator/webpack-obfuscator/issues/155

Left a solution for those who need and close it for no responded
https://togithub.com/javascript-obfuscator/webpack-obfuscator/issues/155#issuecomment-1445274450