add pod affinity and antiffinity rules

Add soft rules for the Job so Pods prefer to be scheduled on the same zone and not to be scheduled on the same node.
This will improve the performance as pods in the same node will still resources from each other, and pods in different zone will have a performance penalty since networking is most likely to be worse.

/assign @vsoch @alculquicondor
I didn't tested but IIUIC these features will help to improve the placement of the flux pods for maximizing performance.
It requires some testing

This looks OK to me but I'll want to get feedback from @alculquicondor too. I'm not sure if it will muck with testing given we don't actually have different nodes there.

why just preferred?

why just preferred?

because this is backwards compatible, a Job that ran before we'll be able to run after this change, if we make it required it may leave some Pods unschedulable , and it seems flux operator expectation is all pods are available.

lgtm

This looks fantastic - thank you to you both!


tabnine was not working on vs code jupyter note book but working fine in vs code insider jupyter note book.please reslove it

please complete the following information:

OS version: [e.g. Win 10, Mac Catalina]
Editor: [e.g. vscode, intelij, sublime]
Editor version:
Programming language: [e.g. js, ts, c++]
TabNine extension version:
Engine version (could be located within Tabnine Hub):

Issue Details:
gz#1609

Maybe this link solve your problem!
https://www.codegrepper.com/code-examples/shell/how+to+install+tabnine+in+jupyter+notebook
https://community.dataiku.com/t5/Using-Dataiku-DSS/How-to-enable-auto-completion-in-Jupyter-Notebook/m-p/2436

Since the legacy Jupiter extension uses a "custom editor," it will not be able to use TabNine completions as you normally do in .py files. However, this issue will be addressed soon thanks to the Jupyter extension "native editor" (currently in roll out).
So, as you said, to work around this issue you can use Visual Studio Code Insiders where the Jupyter extension will use the native editor.
Another possible workaround is to enable the experiment for the native editor as described here -
https://github.com/codota/tabnine-vscode/issues/61#issuecomment-809257077


Fix size of fields

Code Coverage

File
Coverage [0.00%]
:x:

composeApp/src/commonMain/kotlin/login/presentation/LoginScreen.kt
0.00%
:x:

Total Project Coverage
0.00%
:x:


Window scroller explicit prop types

Ref #926
@bvaughn Are you okay with it?

Codecov Report

Merging #927 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master    #927   +/-   ##
======================================
  Coverage    89.9%   89.9%
======================================
  Files          57      57
  Lines        1615    1615
======================================
  Hits         1452    1452
  Misses        163     163

Impacted Files
Coverage Δ

source/WindowScroller/WindowScroller.js
86.27% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f275a57...6c53aeb. Read the comment docs.

Thanks @TrySound. Let me know if you'd like my help working through these, if y'all are happy with this solution.

Looks good to me 😄 👍


Continue playing when minimized without PiP mode

VLC does that. Useful when I just want to listen the audio from the video.

This would be so incredibly appreciated, I can't use the app to listen to music, audiobooks, or video audio (DJ mixes, video podcasts, etc.) as I would do without this

duplicate of #10


I am having problems in installation while setting up the project.

Unable to install package pygrib.
Error contains:
eccodes not found which I installed using conda.
Microsoft Visual C++ 14.0 or greater is required. which also I have installed.
--proof:

Here is the complete error:
Building wheels for collected packages: pygrib
  Building wheel for pygrib (pyproject.toml) ... error
  error: subprocess-exited-with-error

  × Building wheel for pygrib (pyproject.toml) did not run successfully.
  │ exit code: 1
  ╰─> [23 lines of output]
      eccodes not found, build may fail...
      running bdist_wheel
      running build
      running build_py
      creating build\lib.win-amd64-cpython-311\pygrib
      copying src\pygrib\__init__.py -> build\lib.win-amd64-cpython-311\pygrib
      running build_ext
      <string>:18: _DeprecatedInstaller: setuptools.installer and fetch_build_eggs are deprecated.
      !!

              ********************************************************************************
              Requirements should be satisfied by a PEP 517 installer.
              If you are using pip, you can try `pip install --use-pep517`.
              ********************************************************************************

      !!
      C:\Users\Lenovo\AppData\Local\Temp\pip-build-env-mn706q2z\overlay\Lib\site-packages\Cython\Compiler\Main.py:381: FutureWarning: Cython directive 'language_level' not set, using '3str' for now (Py3). This has changed from earlier releases! File: C:\Users\Lenovo\AppData\Local\Temp\pip-install-oyr7x6e1\pygrib_df6a9faaa73c4c9989f7dd1248ac782d\src\pygrib\_pygrib.pyx
        tree = Parsing.p_module(s, pxd, full_module_name)
      warning: src\pygrib\_pygrib.pyx:358:12: Unreachable code
      Compiling src/pygrib/_pygrib.pyx because it changed.
      [1/1] Cythonizing src/pygrib/_pygrib.pyx
      building 'pygrib._pygrib' extension
      error: Microsoft Visual C++ 14.0 or greater is required. Get it with "Microsoft C++ Build Tools": https://visualstudio.microsoft.com/visual-cpp-build-tools/
      [end of output]

  note: This error originates from a subprocess, and is likely not a problem with pip.
  ERROR: Failed building wheel for pygrib
Failed to build pygrib
ERROR: ERROR: Failed to build installable wheels for some pyproject.toml based projects (pygrib)

Try removing geopandas and see if that works?

@peterdudfield Thanks for taking time to propose a solution to my issue but it still gives the same error.

you could run this in docker? Some other solutions here - https://stackoverflow.com/questions/35640117/installing-pygrib-package

Any luck?

@peterdudfield unfortunately no, I am thinking of using a virtual machine now, what do you suggest?

or use docker


Charlie/JTac/Hivemind/Colony/Deadchat are all shades of pink and purple (accessibility issue?)

Description
This is more of a feature request/accessibility change than a bugfix, but when i'm in ghost and i'm looking at the chat it's really hard to distinguish these channels when all/most of them are being used at once, and I don't really have colorblindness.
Additional context

Charlie should stay as purple.
Hivemind could be made blueish grey (like the defender's colors), although it would have to be more saturated than the separated UI's purplish grey
Jtac could be made more pink?
Colony could be similar to the we-ya radio colors (since it's a we-ya colony

idk exactly what colors to make the radios but i agree i think chat should be easier to read, though theres defo gonna be a little bit of trouble coming up with colors that havent been used


Use either service or /etc/init.d consistently

Great plugin btw! Thanks :)
Just noticed that you're not being consistent with service vs init.d:
https://github.com/capistrano-plugins/capistrano-unicorn-nginx/blob/master/lib/capistrano/tasks/unicorn.rake#L52
(It's init.d everywhere else.)
Seems service is more the way to go, but best-practice is to use the full path in scripting, so that someone can't sneakily slip a binary on the front of the PATH and get a use to execute it. I would default to /usr/sbin/service and make it configurable in case some systems don't follow that.
Ref: http://askubuntu.com/questions/2075/whats-the-difference-between-service-and-etc-init-d

I am experiencing this issue even after setting nginx service path. to '/lib/systemd/system/nginx.service'. I am using CentOS 7
#nginx
set :nginx_service_path, '/lib/systemd/system/nginx.service'
set :nginx_server_name, 'localhost'
set :nginx_config_path, '/etc/nginx/conf.d'

Error

  INFO [f1ea6c0d] Finished in 0.027 seconds with exit status 0 (successful).

  INFO [11cd737d] Running /usr/bin/env sudo /etc/init.d/nginx reload as<EMAIL_ADDRESS>
 DEBUG [11cd737d] Command: /usr/bin/env sudo /etc/init.d/nginx reload

 DEBUG [11cd737d] 	sudo: /etc/init.d/nginx: command not found


Edit composition properties / enable & disable compositions

Hi, thanks for your app!
I'm currently working on automating to render a template about wheater. There are single sub-compositions in this template that have to be enabled/disabled, depending on the given data.
Is there a way to disable/enable these? I can only find ways to edit layers.
Thanks for helping!

Hello,
I think it should be possible via After Effects Scripting, and since you can include scripts theoretically, I think it is doable. However, based on my limited knowledge of the scripting APIs, I, unfortunately, can't guarantee that.
Cheers!


Pagination when no repos available

Pagination still shows up when there are no more repos to show.
For example on this page:

Hi, I've made a PR for this issue, please take a look: https://github.com/max-programming/hacktoberfest-projects/pull/72


lgtm suppression comment does not do anything

https://lgtm.com/projects/gl/nekokatt/hikari/rev/pr-abb5dfec98327d16f1ba3a55e81587b9468738c1
Seems that something in the suppression logic is not working as expected. I have an issue where import x is followed by a from x import y. There is a warning that both from x and import x are used together, which is fair enough.
However, when following the instructions to mute said issue, nothing actually happens. The error still remains unsuppressed.

If you want to remove only this alert (and not other similar alerts), you can add the comment lgtm [py/import-and-import-from] to the end of line 35.

I'm not sure if this is a bug or just an incorrect instruction on how to suppress the message, but as you can see, the comment is already there to suppress this warning.
Any info would be greatly appreciated, thanks once again :-)

I believe what you're seeing is the fact that alert suppressions are not applied to PRs, and only take effect once the commit containing the suppression has been merged. (See here in the LGTM FAQ.)
The reason for this is to minimise the possibility of merging code containing bugs (or security problems) that would otherwise be hidden by a suppression comment.
So hopefully all you should need to do is merge the associated PR, and the alert should be suppressed correctly.
I hope this clears things up! 🙂

:man_facepalming: i completely forgot that this was a thing. My bad. Sorry for wasting time, but thank you for cleaning this up for me. :+1:


Generate image

I want to create a new 500 * 500 white image to generate watermark image. How can I operate it? I think the interface is only loaded

Use System.Drawing to create new images. ImageFactory is designed as a wrapper around existing System.Drawing images or images loaded from a source.
Once created you can then load that image into the ImageFactory for further processing.
https://github.com/JimBobSquarePants/ImageProcessor/blob/614af1b61978de1eca15c07f131e3bbdc8139c50/src/ImageProcessor/ImageFactory.cs#L426


Fix withdraw and desk-reject options

it looks good to me but how are you going to migrate the data?

it looks good to me but how are you going to migrate the data?

I found 11 request forms which have the old withdraw and desk-reject options selected. Once this PR is merged, I will update the request form invitation on the live site. With that I can simply manually update these 11 request forms by posting a Revision to each.
I could do this successfully locally.


Update intro file

Fixed indentation issue

[ ] I have read freeCodeCamp's contribution guidelines.
[ ] My pull request has a descriptive title (not a vague title like Update index.md)
[ ] My pull request targets the master branch of freeCodeCamp.
[ ] None of my changes are plagiarized from another source without proper attribution.
[ ] My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.
Closes #XXXXX

@vssupriya Thank you for submitting a pull request (PR). I have closed the PR because the changes you have made does not improve the article.
I have also marked this PR invalid for Hacktoberfest as I believe that it does not follow the recommended guidelines:

Quality Standards
In line with Hacktoberfest value #2 (Quantity is fun, Quality is key), we have provided examples of the quality standards we encourage. This applies mainly to beginners.

PRs that are automated e.g. scripted opening PRs to remove whitespace / optimize images.
PRs that are disruptive e.g. taking someone else's branch/commits and making a PR.
PRs that are regarded by a project maintainer as a hindrance vs. helping.
Something that's clearly an attempt to simply +1 your PR count for October.

Learn more at https://hacktoberfest.digitalocean.com/details


Faster "Goto Symbol in Workspace"

VSCode's "Goto Symbol in Workspace" has a debounce timeout and is not as fast as "Goto Symbol in Editor", maybe we can improve that by borrowing some ideas from Sublime Text. It achieves this feature with 2 major steps from my guess:

It builds index for each project, it may be slow at first run but will be fast once opened some folder. Generally the index is a symbol -> file map.
It provides two-step search in "Goto any Symbol", so symbols with same name will only take over one row, letting people find what their want more efficient.

I'll post some images to add details to what I said:
VSCode:

It refreshes at a debounce time of about 1 seconds.
Same name symbols are all displayed here, which may make target symbol be far away from top of the list.

Sublime Text:

It shows unique symbol names first, with its source file languages (it was extracted from syntax highlighting during the indexing step).
When you enter one name, it then shows source paths and you can jump to that file quickly (it even doesn't wait your next enter to show the file, it creates a phantom view to quickly check out the source contents without actually open it in editor).

The typing debounce is vscode is ~200ms but it is up to extensions to build and persist an index or not. We don't make assumptions about that. The https://github.com/microsoft/vscode-anycode does that but other might. What language/extension are you seeing this with?

I'm viewing a TypeScript project in vscode screenshot above, with the built-in TypeScript language support. The main point here is not setting a smaller debounce time, but the experience of "Goto Symbol in Workspace" feels more slower than "Goto Symbol in Editor". The latter works almost instantly.
Another annoying thing from the screenshots above is that vscode searches symbols in global paths (/Applications/Visual Studio Code.app/...) where people normally don't expect that. Maybe I was missing some configurations, maybe that's why it was slow.
I respect that vscode gives out every small function to extensions to make it more powerful, so I'm not expecting vscode to repeat what sublime has done (many features are powered by extracting info from syntax-highlighting). But I still want vscode to think the ways to improve user experience.

forwarding to @mjbvz since this is TS (but in reality this is for each language extension)

Another annoying thing from the screenshots above is that vscode searches symbols in global paths (/Applications/Visual Studio Code.app/...) where people normally don't expect that. Maybe I was missing some configurations, maybe that's why it was slow.

That's because TypeScript ships symbols like console of common JS environments, like browsers, and those symbols happen to live in files inside the extension which is inside the app.

Duplicate of #46718


[Feature Request]: Add contact page with contact form

Is there an existing issue for this?

[X] I have searched the existing issues

Feature Description
We need to add a contact page to our project that includes a user-friendly contact form. This form should allow users to enter their details (name, email, and message) and send queries directly to a specified email address. The page should be designed to be responsive, ensuring a seamless experience on both desktop and mobile devices.
Priority
High
Record

[X] I have read the Contributing Guidelines
[X] I'm a GSSOC'24 contributor
[X] I have starred the repository

Thank you for creating this issue! 🎉 We'll look into it as soon as possible. In the meantime, please make sure to provide all the necessary details and context. If you have any questions or additional information, feel free to add them here. Your contributions are highly appreciated! 😊
You can also check our CONTRIBUTING.md for guidelines on contributing to this project.

Not required as of now

Hello @krishnas005! Your issue #366 has been closed. Thank you for your contribution!


webchat customization specific question

🚨 The issue tracker is not for implementation questions 🚨
Hi,
Not sure if this is the right 'channel' for this question. I am finalizing a webchat implementation on my own site. I am struggling with the color that pops up if I hover over the send button (or a suggested action in for instance an adaptive card)

.
I checked the defaultStyleOptions.js and tried a number of options that made sense (cardEmphasisBackgroundColor or sendBoxButtonColorOnFocus) but all without result. Other options with regards to webchat customization work just fine.
Which one is supposed to designate the color for hovering over a send button or a card action?
Help appreciated
Best
Hessel

Hi @HesselWellema, sendBoxButtonColor is the defaultStyleOption you're looking for, though this may change all buttons in the send box, not just the send button. If you want to change only the send button, you can do so by using idiosyncratic styling, available in our samples.
Please feel free to peruse our samples, which provide a lot of ideas and foundation for customizing your version of Web Chat.
'How to' questions such as this one are better suited for Stack Overflow. Please feel free to post other questions you have about developing your own features over there so the community at large may help out. If you need help with a Web Chat implementation, you can post a question to the Web Chat tag. Thank you!


Reset caller's environment and workingdir, ...

These are the changes I extracted from ViDA-NYU/reprozip#115
I did not include the move to .travis/uml-docker/, the change where I use the files from the current repo rather than curl'ing the scripts, and disabling fig and docker-compose (although it is doable via env vars).
The problem of course is that because scripts get curl'ed, the tests ran for this branch don't actually reflect the passing status (they are downloaded from your master branch).

Ok for me, just waiting for the README.md update before merging

Will this do?

Perfect, thx


winhttp callback handle error case

Invoke callback with error code when sending HTTP request fails
Correct some typos

Superseded by #19


Help

How do I install my pokemon?

Hey @russelltaylor05,
Sorry for the confusion you're having. I think there may have been a bit of a misunderstanding. Pokédex Tracker is an online service that you use to easily keep track of your progress as you attempt to complete a Living Dex. This application is primarily geared for tracking the Pokémon in Generation VI (X, Y, Omega Ruby, or Alpha Sapphire).
Because of the online nature of this website, there is actually no need to install any additional software or Pokémon onto your own computer. All you have to do is visit the URL in your browser, sign in, and start marking them as caught as you catch them in your game!
Hope that clears things up for you! Let us know if you have any other questions! Happy tracking!
Cheers,
Robin

I dunno, that sounds like a lot of work, can I just get a refund instead?


Wavesurfer on Safari never responds to Ready on file loading

Wavesurfer.js version(s):
Latest
Browser and operating system version(s):
Safari latest, iOS latest
Code needed to reproduce the issue:
(Please reduce your code as much as possible and only post the minimum code needed to reproduce the issue. A Code pen is an excellent way to share such code)
Load a file via file input dialog
Wavesurfer never triggers
  this.wavesurfer.on("ready", () => {
    this.isLoading = false;
  });

so it just sits on the loading animation.
Works fine on Windows/Android.
Use behaviour needed to reproduce the issue:
Load a file via file upload
Similar to
https://github.com/katspaugh/wavesurfer.js/issues/1567
https://github.com/katspaugh/wavesurfer.js/issues/1415
But these have been closed and the same issue still exists.
I could not get the suggestion solution re: microphone working with loading files via file dialog.
It just never seems to return to the ready callback, no matter what hacks I tried creating wavesurfer with a context.

Which backend are you using? you could try the waveform-ready event instead. I think with MediaElement, only waveform-ready is emitted, but with other backends, both ready and waveform-ready are mitted but I could be wrong about that.
waveform-ready – Fires after the waveform is drawn when using the MediaElement backend. If you're using the WebAudio backend, you can use ready.
From this page:
https://wavesurfer-js.org/docs/events.html

Using the default, but I tried it on the other one as well and it still fails on iOS.

I confirm this issue, it seems to happen only when using the MediaElement backend and passing the peaks parameter to the load function.
The behavior described by the documentation instead, provides that the ready event is emitted when the audio is ready to play while the wave-ready event when the waveform has been drawn.

@sonicviz have a look at this sample and try it out on your ios device,
https://www.entonbiba.com/lab/ios2.html
do you have your code available somewhere to look at with the upload function you mention?

@sonicviz have a look at this sample and try it out on your ios device,
https://www.entonbiba.com/lab/ios2.html
do you have your code available somewhere to look at with the upload function you mention?

@sonicviz have a look at this sample and try it out on your ios device,
https://www.entonbiba.com/lab/ios2.html
do you have your code available somewhere to look at with the upload function you mention?

I just tried this on Chrome, Safari, and IOS Safari. It plays back fine on IOS Safari, but does not playback properly on Safari for OSX.

Does someone figure out how to solve this problem? Still buggy on Safari 15.3.

This still doesn't work for me on iOS. The issue is marked as closed but I don't see any fix. I tried using the version 7.7.3 and the "ready" event is never fired on iOS, even with a direct user interaction.

Please open a new issue and add a snippet of your code, the audio URL and the iOS version.


Self connect nodes

first things first, this library looks awesome. is possible self connect nodes in order to represent loops and/or draw kind of state machine diagrams?

Hello @jc-anguiano
Thanks: D
By default it does not allow one to connect with it.
But the class could be overwritten.
I don't quite understand your question. Could you put a picture?
Jero


Release 5.x : folders resources/features "missing"

Hello,
I was upgrading my "OpenStreetMap Community Index viewer" (https://github.com/jbelien/oci-viewer) to version 5.x but I realized folders features and resources are now not included anymore.
That's unfortunate since I use those (sub-)folders to create the hierarchy regions/countries in my "viewer".
Would it be possible to add those folders back ?
Thanks :)

I can put them back, sorry!

Thanks @bhousel ! :)

When is the next release planned ?
So I put it in my agenda to continue the work on upgrading to v5 😄

I was going to do a minor release when #474 is done, but I can do it later today.


Return proper Success/Error code to host

This commit adds change to send the right error code to host during the marker lid validation. When the marker lid validation fails we were trying to send a PLDM_ERROR But it was sent as a response to the file write request and PHYP assumed that the error code returned was for the write operation and did not go ahead to check the sensor event sent to indicate the entitlment fail during marker lid validation.
Defect: PE00LNC2

Sagar tested and a detailed message now appears on the OS:
The selected firmware image can not be applied.

The Build Date of the firmware image selected is
    June 01, 2024.
The System's Update Access Key Expiration Date is
    December 31, 2023.

Please contact your service support structure.


Clean up warnings, fix one soundness issue

I am still working on adding Windows support, but was hoping to get this merged first.
This PR does two things, First, it cleans up all warnings in the build. Second, and more importantly, it fixes a potential soundness issue where a non-mutable buffer was passed to a C function ioctl that mutated it. The fix is simply to make the buffer mutable, and pass a mutable reference to ioctl.
These changes do not have any impact on functionality other than fixing the soundness issue. That said, the soundness issue was in an OSX-specific function, so it may be worth running cargo test on OSX to be sure.

thanks, has less warnings now. I cannot judge the ioctl part, but I believe you judge this issue better than me

forgot to mention: ran the tests on OSX and the examples (some are broken, but the example itself needs to be fixed, I'll do that another time in master)


msbot clone: Ability to specify Search Service tier as parameter

Tool
Name: Msbot
Describe the problem
From Microsoft/AI/issues/323
Author: @gabog

Is your feature request related to a problem? Please describe.
By default, msbot create a Standard Search Service which is kind of expensive for dev and local tests.
If I understand this correctly (https://docs.microsoft.com/en-us/azure/search/search-sku-tier) the search pricing tier can not be changed after its been created.
QnAMaker allows you to select a pricing tier when creating the service but this parameter is not exposed by msbot

Describe the solution you'd like

I would like to have a parameter where I can specify the pricing tier to be used by the Search Service used by QnAMaker.

Describe alternatives you've considered

I've considered manually recreating QnAMaker and then update the bot files and the dispatcher, but this is time consuming and I will need to do it again if I need to update my environment from a new drop (msbot doesn't support update, you are forced to delete and recreate if you want to get the latest).

Additional context
Add any other context or screenshots about the feature request here.
[enhancement]

Tracked via #584


Always use --batch with GPG

https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=913614
This is being done extensively upstream.
Also moved the python executable hackery out of the entrypoint.

👍


#1158 Remove letter-contact routes

Description
Remove letter-contact routes.  I started to delete dao code, but that caused errors.
#1158
Type of change
Please check the relevant option(s).

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update
[ ] Documentation changes only

How Has This Been Tested?

[x] All unit tests pass
[x] Deployed
[x] Manual testing by Strike team

Checklist

[x] I have assigned myself to this PR
[x] PR has an appropriate title: #9999 - What the thing does
[x] PR has a detailed description, including links to specific documentation
[x] I have added the appropriate labels to the PR.
[x] I did not remove any parts of the template, such as checkboxes even if they are not used
[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to any documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[x] I have ensured the latest master is merged into my branch and all checks are green prior to review
[x] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules
[x] The ticket is now moved into the DEV test column

Nathan manually tested changes for this ticket.  (He says the Cypress regression is not appropriate for this.)  He tells me that the changes look good.

Could you also deploy this to Dev, run the QA suite against it using the action in the QA repo, and link to the results in the testing section, please? The suite QA suite should pass, Cris updated it before leaving. If there's an issue we'll need to wait for her to get back next week.


asar protocol handler, Failed to load resource

In our app, we reference all of assets with url with different protocols.
I'm currently working on build the distribution app and want to use asar to make a package of the whole app.
We load the start page like this:
BrowserWindow.loadUrl('asar:' + __dirname + '/static/dashboard.html');

That part alone works, but as soon as I added a protocol.registerProtocol for 'asar' protocol the above page could not be load:
    Protocol.registerProtocol('asar', function(request) {
        //do some work with request url
        return new Protocol.RequestFileJob(url);
    });

In the console it says:
Failed to load resource: asar:/path/to/MyApp.app/Contents/Resources/app.asar/static/dashboard.html

The same code would work fine with normal app folder even though I use 'asar' protocols for all my asset reference urls.
I suspect that Protocol.RequestFileJob(url) does not work for inside asar package, but not sure how to dig deeper.

If I only use 'asar:' protocol for the starting page, and keep all other url reference with my custom protocol. I got the following error when load resources:
Imported resource from origin 'myprotocol://' has been blocked from loading by Cross-Origin Resource Sharing policy: Received an invalid response. Origin 'asar://' is therefore not allowed access.

Yeah Protocol.RequestFileJob can not read asar archives, as work around you can use fs module to read the file and the use protocol.RequestStringJob to return the content.

If I only use 'asar:' protocol for the starting page, and keep all other url reference with my custom protocol. I got the following error when load resources:

Have you turned on CSP in your html file?

I added
<meta http-equiv="Content-Security-Policy" content="default-src fire: 'unsafe-inline'" >

In my starting html page.
But still got the same error:
Imported resource from origin 'myprotocol://' has been blocked from loading by Cross-Origin Resource Sharing policy:
Received an invalid response. Origin 'asar://' is therefore not allowed access.

I find no way to solve the cross-protocol reference issue stated above, so I can only go on with changing all resource protocols to "asar" in my html files.
Now I'm trying to use protocol.RequestStringJob inside registerProtocol to handle resources in asar package like this:
    Protocol.registerProtocol('asar', function(request) {
        //work out file path
        var fileContent = fs.readFileSync(filePath);
        return new Protocol.RequestStringJob({
            mimeType: Mime.lookup(file),
            data: fileContent
        });
    });

It works for html and css files, I can load them from asar correctly. But any image files are not displaying. It doesn't report any "Failed to load resource" error so my guess is that the request is proceeded but somehow the content cannot be displayed. Is it because the default setting charset: 'UTF-8' gets in the way of displaying images? @zcbenz

It is because RequestStringJob is not capable of processing binary data, #566 did propose a way to fix this but it is not implemented yet.
I'll fix the custom protocol not loading under asar://, it is affecting Atom too.

I tested atom-shell v0.21.1, without asar: protocol, it didn't complain about cross-origin policy anymore.
But my custom protocol still cannot load resource from asar package due to protocol.RequestFileJob does not work for files inside asar, and lack of RequestBufferJob implemented.
I guess the example in Application Packaging Documentation:
app.on('will-finish-launching', function() {
    var protocol = require('protocol');
    protocol.registerProtocol('atom', function(request) {
      var url = request.url.substr(7)
      return new protocol.RequestFileJob(path.normalize(__dirname + '/' + url));
    });
});

Will not work for asar package, can you confirm that?

Yeah I can confirm it, we still need a way to load asar resources in custom protocols.


Implement error object links.

See http://jsonapi.org/format/#error-objects.

➕ I would like to see this implemented as well


Add custom colour support to Skeleton

Skeleton component is being used in more and more screens, and since we were handed dark designs for Black Friday, we need to implement custom Colors so as to have properly stylised Skeleton in the screen

Not supported Orbit design system. Dark theme should be available using the colorTheme environment


Improve raster maps

Can we improve the raster maps (specifically overlap rasters and delta rasters) so the buffer area doesn't dictate the shape of the map? This may require the recruitment of some North American shapefile (or something of that ilk). Maybe the geodata package has something?

Has @ezylstra done this? :thinking:

Kinda... Quick question for @jcoliver: do we want the delta and overlap maps to always have the political boundaries, or should it be an option available with an argument to those functions like boundaries = TRUE?

Addressed for overlap maps in acaa869 and delta maps in aee7e08.


Digit Differ

Hi Okovalov!
Can you help me to fix it.
I want the bot run if first last digit =1 then second last digit =2 and run purchase with prediction
Thank you.

@felixhuy by second last digit you mean a last digit from the previous tick or a digit which is before a last digit from the current tick?

Last digit after current tick.
Ex: 5 6 7 3 5 4 1 2 - last digt 1 then last digt 2 and the bot will trade.
Are you understand ?

@felixhuy then you need to add a variable, call it "flag" for instance and set it to 0 by default. then in the second block you need check if last digit = 1 then set flag = 1. before this statement you need to add another if - so if flag = 1 and last digit = 2 then purchase else set flag = 0. then in the forth block you need to set flag to 0 (reset it)

It is working ! thank you so much

But it only run true first time, and after every last digit is 2 it always run :(

You need to reset the flag back to zero once both conditions are met. I would say do it right before your purchase operator
Sent from my iPhone

On Apr 10, 2017, at 6:31 AM, felixhuy<EMAIL_ADDRESS>wrote:
But it only run true first time, and after every last digit is 2 it always run :(
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

Can you help me to setup it. I followed your mean but it still not  run. It
not run :(
Vào 11-04-2017 01:48 AM, "Oleksandr Kovalov"<EMAIL_ADDRESS>đã
viết:

You need to reset the flag back to zero once both conditions are met. I
would say do it right before your purchase operator
Sent from my iPhone

On Apr 10, 2017, at 6:31 AM, felixhuy<EMAIL_ADDRESS>wrote:
But it only run true first time, and after every last digit is 2 it
always run :(
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/okovalov/test_store/issues/1#issuecomment-293043000,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AY-x9MN0bRt8V1RPi3kwllZUsh2dU7niks5runlhgaJpZM4M38ND
.

I tried but it is not work !

Right after Purchase add "set Digit = 0"
On Wed, Apr 19, 2017 at 10:13 PM, felixhuy<EMAIL_ADDRESS>wrote:

I tried but it is not work !
[image: capture]
https://cloud.githubusercontent.com/assets/26194420/25210362/8bf61db2-25a9-11e7-8448-60133ac2473c.PNG
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/okovalov/test_store/issues/1#issuecomment-295547285,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABoK_bVfxmdImLp_E7knpewSAqUiacSyks5rxr9FgaJpZM4M38ND
.

--
"Success is simple. Do what's right, the right way, at the right time."
best regards,
tradakad

I did it but it sill not work :(

it go 1 - 2 - .... not purchase

because i think if it work it will be decrease percent lost > 2 times by check last digit


require() returns single-element array

When I do something like var c = require('config.yaml'); I get a single-element array with the YAML-derived data structure as the element. I guess that's more or less as documented, but it seems strange. I would have expected that I'd get just the data structure, with no extra array around it. Having to use a [0] to get to the actual data is an annoyance. Is there some point I'm missing?
That is, I'd hoped to get
{"property1":"value1","property2":"value2"}

but instead I get
[{"property1":"value1","property2":"value2"}]

Problem is, that yaml file CAN contain multiple doc. WIthout [] wrapper you will be unable to separate "multiple docs" from "single doc with array".

Ah, that makes sense. Thanks. I'm used to Perl, where the file-parsing function just returns multiple values if there are multiple documents in the file, but I never paid attention to anything but the first value because I was using single-document files. I'm not sure why I didn't run into the issue with PHP. Probably using a library that assumed a file would contain only a single document (no PHP YAML implementations seem to be very good).

I suspect, that most use-cases of require() will be with single-doc. require is sugar. We could officially say, that require works only with single-doc files, and throws exception on multidocs. But i'm not sure, that gain is big enougth to do such limits.
Anyway, if more strong reasons appears, we can reconsider API changes. Now i've added comment about shift to readme, and close ticket.

Vitaly, after all, I must admit, I was wrong about my position on returning list of documents. As you said, the most frequent case is "single-doc". And as I can clearly see now, when you see in the code:
var config = require(CONFIG_FILE).shift();

That looks strange, as you expect require to return a single value.
I believe require should return single document (first one, when multi-doc) without throwing an error. In other words calling shift() internally.

Ok. Let's change API in next release.


Connecticut counties

I added the Orange County, CA to this commit as well.

Looks great, thanks!


Carousel - Add ArrowsColor property

Feature request type
Enhance component
Component name
MudCarousel
Is your feature request related to a problem?
The arrows only use Color.Inherit. I want to be able to set the arrows color (ArrowsColor), just like I can set the bullets color (BulletsColor). Otherwise I have to implement the arrow templates for a simple feature.
Describe the solution you'd like
Implement ArrowsColor property with a similar implementation as BulletsColor
Have you seen this feature anywhere else?
No response
Describe alternatives you've considered
Use the arrow templates feature
Pull Request

[X] I would like to do a Pull Request

Code of Conduct

[X] I agree to follow this project's Code of Conduct

I can't personally promise a merge in any situation but this sounds simple and seems like it has attention so I would say go for it.


Target .NET Framework 4.8

Targeting .NET Framework 4.8 is required if we want to reference a .dll built targeting it, which will be necessary in the future for some referenced mods (for example, "A RimWorld of Magic").
As a side note, I started changing the patch for "A RimWorld of Magic" to be a referenced one. So far it allowed me to significantly simplify it and made the patch more readable, and it allowed me to condense the current patch at least 100 lines. I still expect the size of the patch to still go significantly up, possibly reaching 1000+ lines in total. In size alone it'll likely only be outdone by Vehicle Framework and Vanilla Expanded Framework.

I guess it's fine as long as it compiles and runs. I have no issues building 4.8


Package Manager Error

I am getting a Package Manager error when I tried to add a new package/component from the package manager

Could not load component list:Error Cannot create property '$bundled' on string '' *** Could not merge components ***
Version

v2.1.0
Browser

[ ] Electron distribution
[ ] Chrome
[ ] Safari
[ ] Firefox
[ ] Edge

OS

[ ] Windows

To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior

Screenshots

Additional context

Hi @corepk, does this happen with any package? or just help and cancel?
Are you able to reproduce this if you create an empty bot from the scratch?

@corepk Do you get this error adding any of the packages. We do have an error reported on the latest version of the Help and cancel package.
https://github.com/microsoft/BotFramework-Composer/issues/8515

@gabog & @srinaath - Yes I am getting this error with any of the packages.

Am also getting the same exception, while trying to install any of the packages from the package manager console.

This error indicates that the "schema merge" process was unable to complete successfully.
During this process, the code downloads JSON schema files from json-schema.org and schemas.botframework.com -- is there a change that one or both of these URLs is blocked on your network @corepk @VishnuM1?

This error indicates that the "schema merge" process was unable to complete successfully.
During this process, the code downloads JSON schema files from json-schema.org and schemas.botframework.com -- is there a change that one or both of these URLs is blocked on your network @corepk @VishnuM1?

Hi @benbrown - We do not have such a security network policy so any URLs should not get blocked. I think it is a known issue and it is only with latest version of composer not sure though. @VishnuM1 - Can you please confirm your composer verion?

@corepk Does that airtel.in/dot url ring a bell to you at all? That is not something Composer should be accessing directly, and it seems to be a network error page...

@benbrown - yes. Thank you for highlighting it. Let me try to understand why is it happening. Airtel is an internet service provider and you are correct that Composer should not access this URL directly. Let me investigate it. Thanks again :)

@corepk Any info you can provide will be helpful.

I also get a similar error when trying to install Orchestrator package.

If this problem persists, please file an issue on GitHub
Could not load component list:Error Cannot create property '$bundled' on string '<iframe src=http://<IP_ADDRESS>:8080/webadmin/deny/index.php?dpid=15&dpruleid=11&cat=107&dplanguage=-&url=http%3a%2f%2f185%2e199%2e109%2e153%2fdraft%2d07%2fschema width="100%" height="100%" frameborder=0>' *** Could not merge components ***
Now I tried installing the package via dotnet CLI
dotnet add OrchTest.csproj package Microsoft.Bot.Builder.AI.Orchestrator --version 4.14.1
Determining projects to restore...
Writing C:\Users\pahurkat\AppData\Local\Temp\tmp176E.tmp
info : Adding PackageReference for package 'Microsoft.Bot.Builder.AI.Orchestrator' into project 'OrchTest.csproj'.
info : Restoring packages for C:\Users\pahurkat\OrchTest\OrchTest\OrchTest.csproj...
warn : NU1701: Package 'Microsoft.Azure.KeyVault.Core 1.0.0' was restored using '.NETFramework,Version=v4.6.1, .NETFramework,Version=v4.6.2, .NETFramework,Version=v4.7, .NETFramework,Version=v4.7.1, .NETFramework,Version=v4.7.2, .NETFramework,Version=v4.8' instead of the project target framework '.NETCoreApp,Version=v3.1'. This package may not be fully compatible with your project.
info : Package 'Microsoft.Bot.Builder.AI.Orchestrator' is compatible with all the specified frameworks in project 'OrchTest.csproj'.
info : PackageReference for package 'Microsoft.Bot.Builder.AI.Orchestrator' version '4.14.1' added to file 'C:\Users\pahurkat\OrchTest\OrchTest\OrchTest.csproj'.
info : Committing restore...
info : Writing assets file to disk. Path: C:\Users\pahurkat\OrchTest\OrchTest\obj\project.assets.json
log  : Restored C:\Users\pahurkat\OrchTest\OrchTest\OrchTest.csproj (in 629 ms).
It does get added in the csproj file :

but when I update the schema, it gives the same error

@benbrown

@chrimc62 this error is coming out of the cli and the library when attempting to traverse the schema definitions. It appears most-often connected with a call to http://json-schema.org/draft-07/schema# that is referenced in our bot framework schema files. Any idea why this might occur for some people?


Added the video

Description 📜
Videography on Decision Making and Branching Structure  #886
Contributed By: Priyanshi Gupta
C_CPP batch 5
Fixes # <886>

Type of change 📝

[ ] Au#dio (Should be in mp3 format Includes speech clarity, Concise ,Low distortion)
[X] Video (Animations, screen-recordings, presentations and regular explanatory films are all possibilties etc)
[ ] Doc#umentation (Content Creation in the form of codes or tutorials)
[ ] Other (If you choose other, Please mention changes below)

Domain of Contribution 📊

[ ] Android Dev #(Flutter)
[ ] Android Dev #(Java)
[ ] Android Dev #(Kotlin)
[ ] Backend Dev #(Java)
[ ] Backend Dev #(.NET)
[ ] Backend Dev #(PHP)
[ ] Backend Dev #(Python)
[X] C/CPP
[ ] Competitive #Programming
[ ] Cyber #Security
[ ] DS#A
[ ] Data#base
[ ] Datascience with #Python
[ ] Datascience with #R
[ ] Frontend Dev #HTML/CSS/JS
[ ] Frontend Dev #React/Angular/Vue
[ ] Go#lang
[ ] Interview #Prep
[ ] Java_#Domain
[ ] Java#Script
[ ] ME#RN
[ ] Machine #Learning
[ ] Open #Source
[ ] Python_#Domain
[ ] Ru#st
[ ] Statis#tics
[ ] UI/#UX

Checklist ✅

[X] I follow Contributing Guidelines & Code of conduct of this project.
[X] I have performed a self-review of my own code or work.
[X] I have commented my code, particularly in hard-to-understand areas.
[X] My changes generates no new warnings.
[X] I'm GWOC'21 contributor

Screenshots / Gif (Optional) 📸

done

@priyanshiparolia  Noice .... Neat... :octocat: LGTM❤ 🚀


Inconsistent shape of the return values of scipy.stats.spearmanr.

When an array with shape (m, n) with n > 2 is given to spearmanr, the return values have shape (n, n).  When n is 2 or 1, the return values are scalars:
In [1]: import scipy

In [2]: scipy.__version__
Out[2]: '1.0.0.dev0+8c5b5a2'

In [3]: from scipy.stats import spearmanr

x3 has three columns:
In [4]: x3 = np.random.randint(0, 10, size=(8, 3))

In [5]: rho, p = spearmanr(x3)

In [6]: rho
Out[6]:
array([[ 1.        ,  0.77777778, -0.61753478],
       [ 0.77777778,  1.        , -0.47809144],
       [-0.61753478, -0.47809144,  1.        ]])

Now use just the first two columns:
In [7]: rho, p = spearmanr(x3[:, :2])

For consistency, rho should have shape (2, 2), but
In [8]: rho
Out[8]: 0.77777777777777779

Here, rho should have shape (1, 1):
In [9]: rho, p = spearmanr(x3[:, :1])

In [10]: rho
Out[10]: 1.0

It would be nice if the shape of the return values was consistent.  I would expect the following to be True for a 2-d array x, even for p=1 or p=2:  spearmanr(x[:,:p])[0] == spearmanr(x)[0][:p,:p].

I don't remember, but I found it annoying that np.corrcoef does not return a correlation coefficient when we have two variables, and returns 3 redundant values instead.
It could also be ancient backwards compatibility when the correlation functions were not vectorized.


feat: Added updater for github actions

Added auto-update for our GitHub actions.
Either it runs once a week or manually. The action will create a PR, which then would update all the versions, something like this:https://github.com/linkdotnet/Blog/pull/115 or this https://github.com/linkdotnet/StringBuilder/pull/4
Unfortunately I can't run this workflow on a branch. That makes it a bit tricky to verify if everything is working as it should

I'm a bit hesitant to enable just pushing updated versions, for two reasons:

What if they have breaking changes?
This is a supply chain attach for sure. Somebody pushes an update to an action, that action steals our secrets and pushes them somewhere else.

Can this work a bit like dependeabot perhaps, where we get a chance to review the changed actions and decide if we need to upgrade?

It works like dependabot. It creates a new PR with the updated packages. It points to the latest release. Still there is a chance where you have that issue as you described it.
See the PR I attached to the original post .

Will open a simpler PR


How to refresh token

I have success to get access_token
But the token has an expire time, I have to refresh token in 10 minutes.

oauth provider?
oauth version?
Refresh token RFC
http://tools.ietf.org/html/rfc6749#section-1.5
http://tools.ietf.org/html/rfc6749#section-6
http://tools.ietf.org/html/rfc6749#section-10.4
make a post described by your oauth provider
POST xxx/refresh?refresh_token=XXX&client_id=YYY&grant_type=refresh_token&client_secret ...
expiration currently must be handled by you in failure callback, and reconnect then
https://github.com/OAuthSwift/OAuthSwift/wiki/OAuth-2.0-Token-Expiration

Is it there a reason why OAtuhSwift does not implement the refresh mechanism but itself?
I believe a good start would be to add expires_in and refresh_token properties in the OAuthSwiftCredential object such that those can be exposed to the client that might need to kick off a "token refresh" request.
I'd like to make a PR about this but I'm not sure if it is against the OAuthSwift's roadmap.
Thanks.

@fabiomassimo no reason I think
(I use only oauth1 so I did not investigate this topic, just make some google and rfc search to provide some answer)
every PR is welcomed about this subject


Freezes on startup, with no errors

Minecraft 1.16.5, Fabric loader 0.11.3, Fabric API 0.32.5, CustomPlayerModels 1.16-0.0.10d
No other mods installed
latest.log

Does it load without CustomPlayerModels, only with fabric api? Also check your debug.log, maybe it has something in it.

Yes, it loads fine with only fabric api, and with 18 other mods without this one.
I can't seem to find debug.log, where is it?

Nvm fabric doesn't write debug.log-s, thats a forge only thing. Try reinstalling fabric, I downloaded the exact same version and it works for me.

Please test the latest version (0.0.13a).

Yes, it does seem to be fixed, thank you!


Create server.py File

As a ...  developer
I need ...  to organize my RESTful API service
So that ...  I can easily test all of my requests from one entry point.
Assumptions:
*...For get requests, it will be /recommendations/id
*...For put requests, it will be /recommendations/id
*...For post requests, it will be /recommendations
*...For list (a get request that gets all recommendations) requests, it will be /recommendations
*...For delete requests, it will be/recommendations/id
Acceptance Criteria:
Given ... If we run python server.py,
When ...When we browse via local host
Then ... we will automatically be able to run each request seamlessly and view the results of this action.

We need to modify hari's files to remove the URLs
We need to add urls in the server.py file

@cfnyu is this going to replace @Harivadhana Skeleton branch? If so, should we squash it?

Well I'm not sure we will need individual files for each API call as I don't believe the code will be that lengthy or complicated. I feel most calls made from the API will just be calling either the product class or the models class but the calls themselves won't have much logic in them. For these reasons I think for now we can remove this PR but maybe keep the branch so that if we do decide to use individual files we'll have the branch with the code.

@cfnyu by this PR, do you mean Hari's?

Yes I meant Hari's PR


Add _table_name_for_alias to replace '.' with '_' when creating an …

…alias to tables in another database
Fixes #1310, #1316
Ideally we'd have tests for this, but setting up the testing framework to handle external databases is not something I have time for at the moment.
All Submissions:

[ ] I've checked to ensure there aren't other open Pull Requests for the same update/change.
[ ] I've submitted a ticket for my issue if one did not already exist.
[ ] My submission passes all tests. (Please run the full test suite locally to cut down on noise from travis failures.)
[ ] I've used Github auto-closing keywords in the commit message or the description.
[ ] I've added/updated tests for this change.

New Feature Submissions:

[ ] I've submitted an issue that describes this feature, and received the go ahead from the maintainers.
[ ] My submission includes new tests.
[ ] My submission maintains compliance with JSON:API.

Bug fixes and Changes to Core Features:

[ ] I've included an explanation of what the changes do and why I'd like you to include them.
[ ] I've provided test(s) that fails without the change.

Test Plan:
Reviewer Checklist:

[ ] Maintains compliance with JSON:API
[ ] Adequate test coverage exists to prevent regressions

Just created a test setup to help replicate the issue. Repo at https://github.com/cedm/jsonapi-apartment-test
Check the README for details.

In testing the above repo,  https://github.com/cedm/jsonapi-apartment-test, this pr does not fix the issue I thought we were having. Closing and will leave the issues open so we can fix with another pr.

In testing the above repo,  https://github.com/cedm/jsonapi-apartment-test, this pr does not fix the issue I thought we were having. Closing and will leave the issues open so we can fix with another pr.


translations PR 20180702

Ideally this PR should be review by community members for each language.
Note: In the event that you see an english translation instead of the desired language is because this PR was submitted before the translation was made on the Mattermost Translation Server and probably will be submitted for the next PR.

fr LGTM. However, I noticed that strings have changed and the translation haven't been kept for some strings.

Jason reported to me this is because maybe Pootle doesn't retain long translation on changed strings. But I have found others that have changed hose translations have been kept intact.

This is definitely an eye to keep on.

@enahum Would you happen to have a link to the script that pulls strings from en.json to Pootle?
Perhaps we can take a look with @wget's help on if the issue is due to the script or a bug in Pootle.

This may have happened cause of the recent work on the translations made by Jesus, regardless of that there is no link to the script as it is being executed directly into the box, so I'm copying the script here just for reference
#!/bin/bash
PATH=/home/ubuntu/.nvm/versions/node/v5.10.1/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games
lOCS="/usr/local/lib/python2.7/dist-packages/pootle/translations/mattermost/"
PLT_BRANCH="master"
WEB_BRANCH="master"
RN_BRANCH="master"

function safecmd(){
	typeset cmnd="$*"
	typeset ret_code

	eval $cmnd
	ret_code=$?
	if [ $ret_code != 0 ]; then
		echo "Error: '$cmnd'" $ret_code
		#/usr/local/bin/mail.sh<EMAIL_ADDRESS>"Pootle Error" "Error: $cmnd $ret_code"
		exit $ret_code
	fi
}

function update_template() {
    #Convert POT
    I18N2PO="/home/ubuntu/pootle/i18n2po"

    #json templates from github
    TWEBSTATIC="/tmp/web_static.json"
    TPLATFORM="/tmp/platform.json"
    RNSTATIC="/tmp/mobile.json"

    #Get new json
    PLT_URL="https://raw.githubusercontent.com/mattermost/mattermost-server/$PLT_BRANCH"
    WEB_URL="https://raw.githubusercontent.com/mattermost/mattermost-webapp/$WEB_BRANCH"
    RN_URL="https://raw.githubusercontent.com/mattermost/mattermost-mobile/$RN_BRANCH"
    wget $WEB_URL/i18n/en.json -O $TWEBSTATIC
    wget $PLT_URL/i18n/en.json -O $TPLATFORM
    wget $RN_URL/assets/base/i18n/en.json -O $RNSTATIC

    #merge WebApp and RN
    safecmd i18n4mm -m -r $RNSTATIC -f $TWEBSTATIC -o /tmp

    #Overwrite POT templates
    POTTEMPLATE="/usr/local/lib/python2.7/dist-packages/pootle/translations/mattermost/templates/"

    $I18N2PO -pot -o $POTTEMPLATE"web_static.pot" $TWEBSTATIC
    $I18N2PO -pot -o $POTTEMPLATE"platform.pot" $TPLATFORM

    cp $TWEBSTATIC $POTTEMPLATE
    cp $TPLATFORM $POTTEMPLATE

    #save template in database
    pootle update_stores --no-rq --project=mattermost --language=templates  --force --overwrite --config /etc/pootle.conf
}

function update_po() {
	CODE=$1
	echo "################Start $CODE##########################"

	#store all database in filesystem (po's)
	echo "store database in filesystem"
	safecmd pootle sync_stores --no-rq --project=mattermost --language=$CODE --force --overwrite --config /etc/pootle.conf

	#create new po with new template and old po translation
	echo "creating new template and old po translation"
	safecmd pot2po -t "$lOCS/$CODE/web_static.po" "$lOCS/templates/web_static.pot" "$lOCS/$CODE/web_static_new.po"
	safecmd pot2po -t "$lOCS/$CODE/platform.po"   "$lOCS/templates/platform.pot"   "$lOCS/$CODE/platform_new.po"

	#overwrite old po
	echo "overwrite old po"
	mv "$lOCS/$CODE/web_static_new.po" "$lOCS/$CODE/web_static.po"
	mv "$lOCS/$CODE/platform_new.po"   "$lOCS/$CODE/platform.po"

	#save new po in database
	echo "store new po in database"
	safecmd pootle update_stores --no-rq --project=mattermost --language=$CODE --config /etc/pootle.conf
	echo "################Finished $CODE########################"
}

function sync() {
    for l in $(ls -1 $lOCS | grep -v templates); do
	    update_po "$l"
    done

    echo "SUCCESS sync po's"
}

# this function needs the pootle user
function pootle_process(){
	echo "update templates"
	update_template

	echo "update PO"
	sync

	echo "Recreate stats in redis"
	pootle refresh_stats --no-rq --project=mattermost --config /etc/pootle.conf

	echo "Restart pootle"
	sudo start pootle
	sleep 10

	#echo "Get translation from server"
	#/usr/local/bin/update_lang.sh 'es' 'es'
	#/usr/local/bin/update_lang.sh 'pt' 'pt_BR'
}

echo "Stop Service"
sudo stop pootle
sleep 10

echo "Clear cache"
redis-cli flushall

echo "Execute process"
pootle_process

echo "SUCCESS"
exit 0

@cpanato done


:recycle: Use F-strings in Click examples

As discussed in https://github.com/tiangolo/typer/pull/502#issuecomment-2016506065:

This PR covers too many different things, so it would be better to split it to be able to take some things while not taking others.

Specifically, I would take the changes in the Click examples from "some str {blah}".format(blah=blah) to f-strings. That was just an exact copy of Click's tutorials, but now they updated them, we can update them here as well.

Thanks to @marksmayo for originally catching these cases 🙏

Note that if we end up merging #938, we can simply close this one. Or we can merge this one first, and update the other one afterwards 🤷.

Nice, thank you! :rocket: :cake:


fix property bug in empty cell

Coverage remained the same at 79.837% when pulling 065ea35f3784cbfa3ea8ab56747776821ac63292 on lesliekim:master into 9a8dda391cb0c29525271184b1b37caf93e3f3f7 on Microsoft:0.1.0-dev.

Coverage remained the same at 79.837% when pulling d907664aabc3faaa8dfcf7cb7d8cdcd4525472d7 on lesliekim:master into 9a8dda391cb0c29525271184b1b37caf93e3f3f7 on Microsoft:0.1.0-dev.

Coverage remained the same at 79.837% when pulling d907664aabc3faaa8dfcf7cb7d8cdcd4525472d7 on lesliekim:master into 9a8dda391cb0c29525271184b1b37caf93e3f3f7 on Microsoft:0.1.0-dev.


docs: fix links in QL topics

Two links fixed in the QL help:

In: https://help.semmle.com/QL/learn-ql/javascript/introduce-libraries-ts.html
"Also see the documentation for classes in the Introduction to the QL libraries for JavaScript."
In: https://help.semmle.com/QL/learn-ql/java/introduce-libraries-java.html
"To explore this area further, see Navigating the call graph."

The other three broken links reported in the same issue were fixed in #1930, but the changes haven't been published yet.
I'll post links to the previews when the sphinx PR job goes green.

LGTM


Bug

Challenge Waypoint: Add Different Padding to Each Side of an Element has an issue.
User Agent is: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:37.0) Gecko/20100101 Firefox/37.0.
Please describe how to reproduce this issue, and include links to screenshots if possible.
My code:

margin

padding

padding

I'm having the same issue

Works in iE but not Firefox

When opening your link in FF I ran into the same problem. Although smashing the run test button a bit fixed it. Now I am unable to reproduce :lollipop:
If that doesn't work for you, try a hard refresh.
Windows/Linux:

Hold the Ctrl key and press the F5 key.
Or, hold down Ctrl and ⇧ Shift and then press R.
Mac:
Hold down the ⇧ Shift and click the Reload button.
Or, hold down ⌘ Cmd and ⇧ Shift and then press R.

@anish165 thanks for posting. We have a PR which will, hopefully, fix this. Closing as a duplicate of #4909.


Instructions for NFS Fail and --storage-account option omitted

When running the command as per instructions:
az storage share-rm create \
    --account-name $STORAGEACCT \
    --account-key $STORAGEKEY \
    --enabled-protocol NFS \
    --root-access RootSquash \
    --name "myshare"

This will fail with:
RequiredArgumentMissingError: the following arguments are required: --storage-account

I am confused to what --account-name represents given there is a requirement for --storage-account.
I referenced this with az storage share-rm create --help and I don't find either --account-name or  --account-key in the help guide.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a888b024-cae0-d9d7-d593-580b080f1b46
Version Independent ID: fa3bfa5c-b539-d2ea-48ce-00f63a8bf99e
Content: Create an NFS share - Azure Files
Content Source: articles/storage/files/storage-files-how-to-create-nfs-shares.md
Service: storage
Sub-service: files
GitHub Login: @roygara
Microsoft Alias: rogarana

Thanks for the question! We are taking a look into this and will get back to you soon.

@darkn3rd Thanks from pointing this out. I confirmed the option should be --storage-account and there is no --account-key option. I have submitted a PR to resolve this and it should be live later today.


dotnetfx install failed

I have resolved the issue about the previous NuGet.org dependency failure by following the docs, but when I have depended on "dotnetfx 4.7.2," I have packed it and then uploaded it to Chocolatey to see if I can get past the verification.
However, the verification failed because of dotnetfx not installing because of the error as specified in https://gist.github.com/choco-bot/67467569d304aed11a5141a0cdd934ca#file-install-txt-L1463 | Line 1463.
The problem is that if I have removed the dependency, then users will have to install .NET Framework 4.7.2 manually or through Chocolatey, which is what I don't want. I want my package and a dependency to be installed without errors.

@EoflaOE That's a known thing. You need to ask for an exemption on your package. This will be fixed in the future when the package-verifier supports reboots.

Thanks @mkevenaar! I will ask for exempt, because it requires reboot.

@EoflaOE I understand why you might have created this issue here, but in future, can you use the package moderation page on chocolatey.org to ask questions about the package moderation process?  Or, you can ask questions in the Gitter room here: https://gitter.im/chocolatey/chocolatey.org

@EoflaOE actually, looks like you have asked a question there already :+1:


Look into why the blog is down

looks like the process just died. i updated it so it should restart automatically


fixed minor typo

sup! thx for making this module!

Thanks @williamle8300 :)
I will be adding plenty new components soon. Including TabView, ScrollView and other stuff :P

Np. Sick! Are these abstractions coming from React-Native land?

Well yeah, the concept is the same and I think they originally come from UIKit (iOS) and I think they're awesome as base components for layouting almost any possible problem out there

yea man. I love the clean interface you got for this module. keep up the great work!
cheers.


Links Update

More holistic content

By this I mean review and exxpand http://<IP_ADDRESS>:8000/datascience/useful_links/


Include GraphQL queries when exporting a collection to Postman

I have checked the following:

[X] I've searched existing issues and found nothing related to my issue.

Describe the feature you want to add
Current functionality
Exporting a collection to Postman does not include GraphQL queries.
Desired
Include GraphQL queries when exporting to Postman
Mockups or Images of the feature
Current output
{
  "name": "RequestName",
  "event": [],
  "request": {
    "method": "POST",
    "header": [],
    "url": "{{domain}}/graphql"
  }
}

Desired output
{
  "name": "RequestName",
  "event": [],
  "request": {
    "method": "POST",
    "header": [],
    "url": "{{domain}}/graphql",
    "body": {
      "mode": "graphql",
      "graphql": {
        "query": "..."
      }
    }
  }
}

Closing this as support for this was merged in #2386


JsonLiteralMacros silently supresses exceptons

            case Left(t: Throwable) => c.abort(
              c.enclosingPosition,
              "Invalid JSON in interpolated string"
            )

It's completely impossible to diagnose what exactly went wrong in this situation. You can't put a breakpoint into a macro code, etc, etc.

Fixed in #927.


Fix NullReferenceException for some scenarios

new SidebarPinnedModel() should be called before using.

While this would work, the better solution would be to load the view models from app.cs. Additionally, loading the sidebar items should be done from the sidebar, not from SettingsViewModel.

@yaichenbaum Just want to note, to initialize sidebar model without problems, we have to do it after App.AppSettings initializing which initializing in InstanseViewModel


Allow to compare two zip files for calculated tracks

I want to see the changes that were made on the map between two versions

First Version works so far, Code still needs a clean up

This is now possible, also setting it to different versions to display


Add xml:base attribute to the feed tag

Per @pathawks over in https://github.com/jekyll/jekyll-feed/pull/36#issuecomment-104422305, and per the Atom spec:

Any element defined by this specification MAY have an xml:base
attribute [W3C.REC-xmlbase-20010627].  When xml:base is used in an
Atom Document, it serves the function described in section 5.1.1 of
[RFC3986], establishing the base URI (or IRI) for resolving any
relative references found within the effective scope of the xml:base
attribute.

I believe this fixes #22.
/cc @holman and @bkeepers, as this should finally fix the question that started this all

We might need to add it per post, if a post contains relative links.

We might need to add it per post, if a post contains relative links.

Done via  d863e8a. Good call.

:+1:

It works!

:tada:


Our own exemplar parser

Add our own parse function for exemplars
Tests for exemplar parser

@simoncozens Two things:

the function should also handle ranges
if you're going to copy and paste my code (which doesn't handle ranges) you should add me as a commiter or say so in the commit ;-)

Sorry, you're right about the second thing. I'll fix that now. For the first, do we have ranges anywhere?

@simoncozens Yes, CJK for example, like in data/languages/zh_Hans.textproto where 万-与 is a range.


Scheduling plateaus due to POD killing

Following the same test outlined in #5650, you can trace the events and will notice that one of the major reasons why the ramp curve for startup is non-linear, and has plateaus, is due to the pod killing done by the controllers, giving incorrect feedback into the system.
Using the soak test that @jayunit100 you can see a graphical representation of this.
Related Issues:
https://github.com/GoogleCloudPlatform/kubernetes/issues/3954
https://github.com/GoogleCloudPlatform/kubernetes/issues/3952
Expected Results:
No pod killing on ramp up.

Why are controllers killing pods? That's probably not the root cause. (More probable: too many/conflicting pods assigned to a single host, kubelet sets pods to failed. #5446 should greatly reduce this problem though.)
Alternatively, the controller is reacting too fast, starting N pods, then noticing only M are running and starting another N-M pods, then later killing N-M pods. This would be a true controller bug; it should count pods that are going to start running even if they haven't started yet. But I don't think we have this bug?
I think it's P1 to figure out what's going on.

@lavalamp the merge for #5446 was done 3 days ago, this test was from tip of last night.
Correction: "is due to the pod killing done by the controllers" - I don't know exactly who is doing the killing, that is a supposition on my part ^

which is "the soak test that @jayunit100" that you're referring to? #5447 ?

thats a way you can visualize this - when the job starts, the throughput is constant for a long time, and then jumps.   A screenshot of the graphing part of the app is here (the plateau is not included in this timeslice) https://cloud.githubusercontent.com/assets/826111/6604156/0091d88a-c7fd-11e4-983a-c414e92220cd.jpg.  in any case you can also pol the number of pods that are running
for i in 1 to 150; do
    kubectl get pods | grep blah | wc -l  ; done
``
and  invariably get something like this (if RC=is 5)

3
3
3
3
3
3
3
3
3
3
8
8
8
8
8
8
8
8
8
8
15
15
...

I observed a very similar behavior - I looked a bit deeper into it and basically, all the pods get pending pretty quickly and it took quite a lot of time to start them and report back to apiserver that they are started.
cc @fgrzadkowski
i think that #5714 might help, but we also need to look deeper into what takes time when starting pods.

<EMAIL_ADDRESS>FYI

I am unable to repro this. I modified contrib/for-tests/network-tester/rc.json to make 150 pods and ran a loop getting the number of running pods every three seconds. Output below. It seems to monotonically and quickly make progress.
10
current-context: "crested-analogy-671_kubernetes"
Running: cluster/../cluster/gce/../../cluster/../_output/local/bin/linux/amd64/kubectl get pods
17
current-context: "crested-analogy-671_kubernetes"
Running: cluster/../cluster/gce/../../cluster/../_output/local/bin/linux/amd64/kubectl get pods
20
current-context: "crested-analogy-671_kubernetes"
Running: cluster/../cluster/gce/../../cluster/../_output/local/bin/linux/amd64/kubectl get pods
74
current-context: "crested-analogy-671_kubernetes"
Running: cluster/../cluster/gce/../../cluster/../_output/local/bin/linux/amd64/kubectl get pods
95
current-context: "crested-analogy-671_kubernetes"
Running: cluster/../cluster/gce/../../cluster/../_output/local/bin/linux/amd64/kubectl get pods
126
current-context: "crested-analogy-671_kubernetes"
Running: cluster/../cluster/gce/../../cluster/../_output/local/bin/linux/amd64/kubectl get pods
139
current-context: "crested-analogy-671_kubernetes"
Running: cluster/../cluster/gce/../../cluster/../_output/local/bin/linux/amd64/kubectl get pods
160

The repro is mentioned in #5650, and we re-created last friday.

@timothysc Can you check to see if this problem is now fixed, and if so, close the issue?

@davidopp yes, we'll run have a test run this afternoon.

@timothysc Did you run this test - I think this was caused by #6059 and I think it should be fixed now.

@wojtek-t  yes we can close this issue.  However I'm still deep into e2e to try and prevent future regressions.
fwiw, we still see lumps in draining a pool, but there are so many tickets around that area I'll wait to file a new one.


It is very slow when runing on the custom data.

I have been successed to run the repo on my custom data by transforming the data to rawstearm. However, I found it takes more than 10 hours to run. My model has 152,301 vertices and 204,012 faces and there are 70 cameras. It seems that it taks long time in "overlapping checking", "TexInit".
Do you have any suggestion? I store all vertices in "Vertices.0" and all faces in "Faces.0". Is this the reason?

Hi Haoqian, these lines may be helpful:
https://github.com/Xiaoming-Zhao/advtex_init_align/blob/2f30b94090d4f04ea740b4c21a19dfb2e73328cb/run_scannet.sh#L106-L117
Essentially, this command splits the whole mesh into some sub-meshes such that the overlapping checking can be done quickly. The reason is that overlapping checking involves Markov Random Fields (MRF), which considers pairwise information between adjacent faces. This will be very slow to optimize for a large graph, namely the mesh in this case. Therefore, we split the mesh with CGAL::METIS::partition_graph such that the MRF only needs to be run on some small graphs.

Thank you!!


Avoid having jq read files directly & fix file line endings

Description
Avoid having jq read files directly & fix file line endings. This comes to fix issues when running the CLI on Windows and git-bash
Type of change

[x] Bug fix
[ ] New feature
[ ] Breaking change

Confirmed works on Mac OS.


"Password to short message" looks pretty bad

When signing up as a new applicant: if the password is too short it looks like this:

This might be a problem elsewhere as well

Should be "Passordet er for kort..." and so on, not an incomplete sentence.

Already fixed


[Bug] Race condition behavior in bower.commands.install

If you run multiple bower.commands.install's in parallel the output of the last one to settle will write over the first settled install in the append line operation to bower.json
https://github.com/bower/bower/blob/343e6ac8bcb3ad69a90b2e8c37bf71796417f7b8/lib/core/Project.js#L44 analyse here reads bower.json and sets that._json
that._json is later used to append the line entry to once the async operation is complete.
https://github.com/bower/bower/blob/343e6ac8bcb3ad69a90b2e8c37bf71796417f7b8/lib/core/Project.js#L111 writes using the original that._json which doesn't contain the content of the first bower.commands.install since it settled before the update was written to bower.json
Order of operations:
* read bower.json into memory
* read bower.json into memory
* async fetching operation
* async fetching operation
* write update to bower.json using originally cached content
* write update to bower.json using originally cached content

Where I think it should be:
* read bower.json into memory
* read bower.json into memory
* async fetching operation
* async fetching operation
* re-read bower.json and write update to bower.json
* re-read bower.json and write update to bower.json

This is consistently reproducible if you clear your bower cache between tests.

Thanks for reporting @jasonmit. Just to get it right, the use case is when one is running several install at the same time on the same projet ?

Yes and programmatically.

Let me know if you're open to another read before the right, to implement a lock to prevent concurrent installs, or a third option I am not thinking of.

bower doesn't support "merging" of bower.json. if you operate on single project, you need to run commands sequentially, or pass multiple arguments to install / uninstall multiple things


When you have multiple compiler issues the auto import does not work in Intellij plugin

Auto imports did not work when the following code was copied to IDE
int i = 0;
    try {
        json family = p.family;
        while (true) {
            json e = family[i];
            system:println(e);
            i = i + 1;
        }
    } catch (errors:Error e) {
        string msg = e.msg;
        if (!strings:contains(msg, "array index out of range")) {
            system:println(msg);
            throw e;
        } else {
            system:println("length of array: " + i);
            // Ignore the error.
        }
    }

Created https://github.com/ballerinalang/plugin-intellij/issues/658 on the relevant repo


Handle get and list options in cached getters

Signed-off-by: Monis Khan<EMAIL_ADDRESS>@sttts @p0lyn0mial

Before improving client cacher which were introduced in desperate times, what would it cost to wire through a proper lister? I don't like to continue going the wrong route.
/hold

@mfojtik @sttts @p0lyn0mial you probably care about this sooner rather than later.
/close


LD Examples added to spec.md

@fdelavega although I appreciate your comments on createdAt updatedAt , please take into account that the original v2 Entities do not include dateModified or dateCreated and as a result the automatic translation does not "make up anything new".
We can in a follow-up add dateCreated and dateModified in all v2 entities and therefore createdAt and updatedAt in all LD entities ... but that would be lower priority I guess
would you be happy to approve as it is? thanks!


Method [validateDimensions] does not exist.

I am using laravel 5.2 and this method is not present in the Illuminate \Validation\Validator class.
But I picked up the repository, and the method in this class.
My composer:
"require": {
"php": ">=5.5.9",
"laravel/framework": "5.2. *"
},
But even making a lot updates and reinstalling everything is not updating the code.

This has not been included in a tagged release yet. It'll be available in the next 5.2.x tag.


More than one terminal paths support or fallback to default if custom terminal not found. (Feature request)

I'm using atom-sync-settings to sync atom settings between two computers, one is mac and one is windows.
I'm not using window's default cmd and so I configured custom terminal app in this atom-terminal package. But, when atom-sync-settings sync that settings from windows to mac, the custom terminal path from windows is invalid and not working on mac.
It'll be better if this package can support multiple path settings or fallback second path if first path not found or some other ways to solve this issue.

:+1:
or even just a terminal path option for each operating system


[master-next] Update several clang Type::dump() calls to fix the build

It now requires an extra clang::ASTContext argument.
https://ci.swift.org/view/swift-master-next/job/oss-swift-incremental-RA-osx-master-next/7670/console:
/Volumes/swift-ci/jenkins/workspace/oss-swift-incremental-RA-osx-master-next/swift/lib/AST/ASTDumper.cpp:3755:14: error: no matching member function for call to 'dump'
01:55:26         cty->dump(os);
01:55:26         ~~~~~^~~~
01:55:26 /Volumes/swift-ci/jenkins/workspace/oss-swift-incremental-RA-osx-master-next/llvm-project/clang/include/clang/AST/Type.h:2617:8: note: candidate function not viable: requires 0 arguments, but 1 was provided
01:55:26   void dump() const;
01:55:26        ^
01:55:26 /Volumes/swift-ci/jenkins/workspace/oss-swift-incremental-RA-osx-master-next/llvm-project/clang/include/clang/AST/Type.h:2618:8: note: candidate function not viable: requires 2 arguments, but 1 was provided
01:55:26   void dump(llvm::raw_ostream &OS, const ASTContext &Context) const;
01:55:26        ^
01:55:26 1 error generated.

Also, fix up code using DominatorTreeBase::getRoots(), which was removed upstream, to use roots(), roots_being(), etc. instead.

@swift-ci please test

Build failed
Swift Test Linux Platform
Git Sha - 4fd0cdc2efddd3eb64ad279a29af3b9779d56399

Build failed
Swift Test OS X Platform
Git Sha - 4fd0cdc2efddd3eb64ad279a29af3b9779d56399

Not ideal, I'm puzzled as to why this broke now, since I made these changes quite a while back but it's ok.

@varungandhi-apple This is fallout from the clang API being changed in upstream llvm on Friday (here) which is why it's only breaking now.

Ah! Sorry. I mistook this for something else that was very similar. Makes sense.

@swift-ci please test

Build failed
Swift Test Linux Platform
Git Sha - 4fd0cdc2efddd3eb64ad279a29af3b9779d56399

Build failed
Swift Test OS X Platform
Git Sha - 4fd0cdc2efddd3eb64ad279a29af3b9779d56399

@swift-ci please test

Build failed
Swift Test Linux Platform
Git Sha - 3957574a7b62aa7f6660a117c75eb83103224a9d

Build failed
Swift Test OS X Platform
Git Sha - 3957574a7b62aa7f6660a117c75eb83103224a9d

@swift-ci please smoke test

LGTM, thanks!

Now failing with the below after these fixes:
Assertion failed: (Elt->getBitWidth() == EltVT.getSizeInBits() && "APInt size does not match type size!"), function getConstant, file /Users/buildnode/jenkins/workspace/swift-PR-osx/branch-master-next/llvm-project/llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp, line 1307.

Looking at the old CI logs it was failing with the above before the upstream clang changes this PR handles started, so going to go ahead and merge this anyway.


Make all live and draft links open in a new win

Some live and view draft links were opening in a new window and some weren't for no apparent reason. This fixes that inconsistency.
I opened a PR to the Wagtail main repo https://github.com/torchbox/wagtail/pull/3211 as there were some other html/python files to change and it was too hacky to include it in our repo.
We should delete the pages_for_moderation and recent_edits pages if/when that PR is merged and a new version of Wagtail released.
This also changes the way edit previews work. Before each revision would open a new tab and this was confusing people as the number of tabs kept increasing.
The preview window now is unique per page, meaning that changing the page multiple time and clicking on the preview button now open the preview page in the same window.

Coverage remained the same at 98.117% when pulling 1cca609bbffdc7961f591c4ed51b342bf7ad587f on links-consistency into 214c968fe014c7bac043c0ef32348f8a722bb438 on master.


fix dependency peer-dep warnings, mostly

There's two remaining.
For the firebase/data-compat warning we'd need to just upgrade firebase. See: https://github.com/firebase/firebase-js-sdk/pull/6319
For the other, we'd need to wait for nivo to stop using react-motion https://github.com/plouc/nivo/issues/667

For the other, we'd need to wait for nivo to stop using react-motion plouc/nivo#667

I think the react-motion dep is already removed in the latest Nivo, but when I tried to upgrade us a month or two ago a bunch of mysterious stuff blew up. Probably if you spend half an hour figuring out what changed you could upgrade it. The react-motion dependency isn't small so getting rid of it would be a nice win.


[Feature/Improvement] Status bar background color match workout screen color

Purpose: As a user, I would like the status bar to match the workout screen.
More details: Some more details on the feature/improvement
Currently, the status bar is a different color than the rest of the screen during the workout. See screenshot:

The status bar color should match the current color of the workout screen, i.e. green, red, or black depending on the timer interval.
Acceptance Criteria:

Status bar color matches the rest of the workout screen for a cohesive appearance.

Closed in #106


Attempt to fix #1694 (Transpose bug)

Closes #1694 (hopefully)
I'm not sure if this will work, but let's give it a try anyway.

@Steffan153 is that better?


QA test for 1.2b

Test all functionality, including error-handling

QA Testing was performed by @AY2223S2-CS2103T-F12-1/developers


Correct spelling mistakes.

Great! I like speling fixes! Rebased to master in 36da7a918f442bd5822152a210f980d3d414eed0, I just changed the commit message to remove the period at the end.


[BUG] session timeout does not work

Describe the bug
If you set timeout on session (e.g. session = curl_cffi.requests.Session(timeout=1.0)), it will have no effect when you call session.request, unless you pass the timeout again explicitly.
To Reproduce
curl_cffi.requests.Session(timeout=0.001).get('https://google.com')  # works, but should fail

curl_cffi.requests.Session().get('https://google.com', timeout=0.001)  # fails as expected
curl_cffi.requests.Session(timeout=0.001).get('https://google.com', timeout=0.001)  # fails as expected

Expected behavior
Timeout set on session should be applied to individual requests when there is no explicit timeout set for them.
Versions

OS: windows 10 x64
curl_cffi version 0.6.0
pip freeze dump (too long, I don't think it's important, let me know if you need it though)

Fixed in 0.6.1


(feat) Employer view and skeleton controller

First pass of the employer view and controller. Basically lays out Tyler's picture plus a table of jobs and their status at the bottom.

Good template, let's merge this in

Ben could you add a newline to the end of the files and then resubmit the pull request? If you click on the files changed tab Github is complaining that the last line of the files don't have newline characters.

Looks to be fixed, thanks!
I used git commit --amend to add that tweak into my last commit (didn't have to do a new pull request) but I did have to do a --force (git push -f origin feat/employer).

Looks good to me. Merging now.


Add an openforcefield.filters module to aid in standardizing filtering of molecule sets of parameterization?

In https://github.com/openforcefield/qca-dataset-submission/issues/17, we've been discussing how best to prepare molecule sets for quantum chemical calculations. We often need to apply a series of filters, such as

eliminate molecules with <3 heavy atoms
eliminate molecules with >100 heavy atoms
eliminate exotic elements
eliminate molecules that a reference force field (e.g. smirnoff99Frosst) cannot type

Currently, some of these filters live in some one-off Jupyter notebooks, like this one:
https://github.com/choderalab/fragmenter_data/blob/bond_order/combinatorial_fragmentation/filter/filter_full_drugbank.ipynb (cell 6)
We have a few possibilities:

locate useful tools for filtering within an openforcefield.filters module, which can standardize filtering across our projects
locate these filtering tools within a pipeline intended to fragment molecules for quantum chemical calculations, like https://github.com/openforcefield/fragmenter

What do folks think? Since filtering often happens right before fragmentation, I'm tempted to recommend option 2, but if there are uses for filtering beyond pre-filtering prior to (and likely also after) fragmentation for quantum chemical computation, it may be useful to pursue option 1.
The only use outside of fragmentation I can think of right now is pre-filtering the PDB Ligand Expo to build SMIRNOFF parameters for all molecules in the PDB, but we would likely just want to try to type everything with SMIRNOFF and drop everything else.

eliminate molecules that a reference force field (e.g. smirnoff99Frosst) cannot type

OK, so I'd actually skip that part. For example, we'd like to get boron parameters in soon, as there is some interest in these compounds. We currently can't type these molecules, but we DO want them to go through our toolchains anyway. :)
I'm OK with either option for filtering. My first inclination would have been to apply option 1, which is opposite your first inclination. But you're right it often occurs just before fragmentation. (Except sometimes we don't fragment molecules, which may be an argument for option 1).

we would likely just want to try to type everything with SMIRNOFF and drop everything else.

Could be there are gasses and other very small molecules present in the PDB ligand expo that we would want to filter out.

OK, so I'd actually skip that part. For example, we'd like to get boron parameters in soon, as there is some interest in these compounds. We currently can't type these molecules, but we DO want them to go through our toolchains anyway. :)

I think that attempting to type a molecule is the easiest way to figure out if it has crazy metal groups, etc. I'd suggest we at least try to get parameters for everything we would want into our SMIRNOFF progenitor---even if they're not great---and use this as a filter for what we should be able to fit. Otherwise, we're going to run into trouble when we start trying to fit parameters because molecules will simply fail to type.

@jchodera there's a bit of a chicken-and-egg problem since we have no QM on molecules with boron centers in them so it's hard to estimate starting point parameters for boron (I have literally no parameters available to me for this). I'll add boron, maybe with some dummy parameters, as soon as I have some molecules with it in it (Danny Cole's stuff can come up with a good first pass) but I don't have any yet. So... I'd really like to run them through the pipeline first.

(GAFF, GAFF2, MMFF94, etc. do not cover boron-containing compounds. OpenEye has some internal parameters but they're highly skeptical of them and therefore won't share them. So... Best option is to get some molecules run and then get first-pass parameters from Danny Cole's group.)


October 31st Deliverables

@alee156 @lukezhu1

[x] Fix bug in backend where web app doesn't threshold app properly

Deliverable is showing that not only two corners of the brain are visible in the plotlys
https://github.com/NeuroDataDesign/seelviz/blob/gh-pages/reveal/html/Aut1367reorient_atlas.region_region_color.html
https://github.com/NeuroDataDesign/seelviz/blob/gh-pages/reveal/html/Aut1367reorient_atlas_brain_figure.html
https://github.com/NeuroDataDesign/seelviz/blob/gh-pages/reveal/html/Aut1367reorient_atlas_edges_graphml.html
https://github.com/NeuroDataDesign/seelviz/blob/gh-pages/reveal/html/Aut1367reorient_atlasplotly.html

[x] Allow user input for orientation parameters

Deliverable is web service shown to Jovo

[x] Modify input for functions such that we convert user inputted data into standardized form

Deliverable is showing output for both nifti image and numpy array from ndstore are the same for our web service
^ The links above are using token input, while jon's uses nifti input

Note: may not be bug
@jonl1096

[x] Make backend for secondary page

Deliverable is html of second page
http://<IP_ADDRESS>/clarityviz/
token: Aut1367reorient_atlas

[x] Make output of web service an html formatted "report" containing all the embedded plotly's in an organized fashion with table of contents

Deliverable is output for Ailey's brain

[x] Time pipeline, and keep track of the specific order of steps

Deliverable is a latex document with the time and order of steps
https://github.com/NeuroDataDesign/seelviz/blob/gh-pages/Jupyter/Pipeline_Analytics.pdf

@toekneesunshine

[x] Run sufficient number of trials on Ilastik until objects are clearly defined

Deliverable is Jupyter notebook with justification for number of trials and outputs
https://github.com/NeuroDataDesign/seelviz/blob/gh-pages/Tony/Ilastik on Raw and HistEq Fear199 Data.ipynb

[x] Run sufficient number of trials on histogram equalized brain until objects are clearly defined

Deliverable is Jupyter notebook with justification for number of trials and outputs
https://github.com/NeuroDataDesign/seelviz/blob/gh-pages/Tony/Ilastik on Raw and HistEq Fear199 Data.ipynb

[x] Afterwards type up report on findings in Latek

Deliverable is Latex report
Writeup talks about pretty much the exact same thing as the Jupyter Notebook linked above.  Since classifier didn't generate any objects in new data, just analyzed the training input data objects.  https://github.com/NeuroDataDesign/seelviz/blob/gh-pages/pdfs/writeup-detailing-ilastik.pdf

[x] Type up report on findings in Latek describing the various algorithms we used for processing Ailey's brain and the rational behind them -> use this to interpret our results

Deliverable is Latex report
https://github.com/NeuroDataDesign/seelviz/blob/gh-pages/pdfs/clarityviz-algorithms-writeup.pdf

@gurian @daniel

[ ] Sign up for sciserver account
http://www.sciserver.org/tools/compute/
[x] Tony will give you a numpy array representing a brain

The numpy array is under /Tony/Fear199ds100ITKFile.npy

[ ] Using numpy, scikit, and matplotlib, construct as many statistical analyses of the brains that you can
[ ] Type up a latex report on findings

@jovo

its good.  but please modify so that each task has a very clear definition of done, such that greg & i know whether you've completed it.
please revise each task accordingly, possibly removing some as appropriate.

@jovo Edited for clarity in deliverables

better.  code is not a valid deliverable.  a figure, a notebook, a proof, etc., are deliverables.
think from the perspective of ailey, a deliverable is something you might show her that she might act on. she doesn't care if code exists. she cares about demonstration of functionality.

@jovo Edited again!

better still!  of note, checking a box complete means that you have now linked to the deliverable.
i have therefore unchecked the box :)

audit old issues!!!

simplify tasks!

always be using ailey data

@toekneesunshine

maybe we want to eventually make a PR to ilastik?
are you having fun with the machine vision?
put this write up in the webpage?

@jonl1096

get website using the "skin" from neurodata
put each image on its own page so it is easier to load?
add pipeline_analytics to webpage?  which compute are you using?

@lukezhu1

replace "tracex" with ROI name?

@gurion509

manually label one of the ailey brains

@toekneesunshine https://github.com/Connectomics-Classes/hackwicket-silverbacks/tree/master/postProcessScript < don't know how this works, but it should be able to create a cool 3d visualization of segmented stuff. also in the top level directory 'pipeline.py' uses some pre-processing that might be helpful for this stuff (it's all pretty janky cause it was a 2 week project)

@jonl1096 the website still has content from the Bootstrap template; getting rid of it and using a higher quality/nicer looking background photo will make the site a lot more presentable for a demo (which you guys seem to steadily be getting better at)

@jonl1096 I think the website was well-decorated. But my question is just I think you need some clearer directions in general.

@alee156 make the links work

@toekneesunshine It would be awesome if you could title the plots, label axes, and include a short comment under each plot describing what's being represented by the plot. Otherwise I feel like I'm spending too effort on trying to understand what the plot is trying to show me, rather than trying to understand what the significance of the plotted results is.

@toekneesunshine I agree with @mnatenz1, I think labels and sentences to explain plots are helpful for the sake of the class; you guys are doing stuff that is significantly different than everything we are doing, so sometimes it is kind of hard to keep up!
@seelviz I really like the focus on having beautiful graphics all around; really makes your results pop even if I don't always understand them fully :)


How to dynamically alias a service with new alias changes?

I manage multiple environments of a same service, I deploy them using CircleCI, my circle.yml look like this:
...
...
deployment:
  development:
    branch: master
    commands:
      - now -t $NOW_TOKEN --alias dev-pin.mydomain.com
  production:
    branch: production
    commands:
      - now -t $NOW_TOKEN --alias pin.mydomain.com

As you can see the alias is dynamic depending on the branch. With the new alias change and the deprecation of --alias how can I accomplish this same behavior described? The last alias by running now alias does not work for me in this particular case.
Thanks!

@cayasso You can accomplish this by using a separate command: now alias.
This is how I accomplish it with GitLab CI:
deploy:
  stage: deploy
  script:
        - URL=$(now -t ${NOW_TOKEN})
        - now -t ${NOW_TOKEN} alias set ${URL} dev-pi.mydomain.com

@cayasso Have you managed to get it working? If you have, please close the issue! ✌

^

@hugomd sorry for delay, yes that worked great for me, thank you for all the help ;-)


close rowGroupCursors when Popped due to io.EOF in mergedRowGroupRows

This commit fixes a potential goroutine leak. mergeRowGroupRows cursors, when
initialized, might spawn a goroutine (e.g. asyncPages.readPages). Previously,
when a cursor returned io.EOF, this cursor was popped from the min-heap but
never closed, resulting in leaked goroutines.
cc @achille-roussel @Pryz

Any pointers on where to add a regression test?

We are possibly seeing this in a rollout today. We have ~100s of orphaned goroutines parked here:
https://github.com/segmentio/parquet-go/blob/main/page.go#L222
The goroutines do seem to be slowly falling off. Currently still investigating.

Is that consistent with this issue?

If you are using the Merge* functions it would be related.
Alternatively you might be missing a Close call on Rows instances in the code using parquet-go.

Yup, this was my bad. Saw some new behavior on a rollout and was concerned, but this is attributable to other changes in the rollout. I'll leave my original post only for continuity of the conversation :P

Updated and added test.

@joe-elliott there are some finalizers set up to close resources on GC (including the goroutines leaked by the behavior this PR fixes). I found it helpful to disable those and run a leak detector to track down this leak.