SSH Key Enforcement Limitation

I do understand the reasoning for having required minimums for ssh keys.  But enforcing this and not allowing it to be modified is very restricting.  Maybe I am the only one with this problem but I use Cloud66 to manage my production environments and it creates 1024 bit keys.  Yes i have requested they make this changeable or default to 2048.
If this is something thats going to be enforced the way it is, there should either A: be the option to enable/disable it, or B: modify the minimum requirements.  Or make these limitations widely known.
Yes, I do understand its for security but at what cost?  So now Im stuck:

waiting for cloud66 to update (not possible, i need to get code out there)
going back to another solution (gitlab, possible but id rather not)
depend on external public hosting sites (then whats the point of self hosting)

Hi, thanks your feedback!
What version of Gogs and system you are using?

Ubuntu 14.04, Gogs <IP_ADDRESS>9
0.6.0-1427038154.529b6f0.trusty - installed via packager.io

Thanks your info!
Let me see if this is possible to make easy change to allow 1024 key and prompt a warning message. Does this sound good to you?

that sounds excellent.  If you want I could probably look at getting this in place as well.  I wanted to make sure to get a ticket in at least first

Sure, I think this is the place: https://github.com/gogits/gogs/blob/master/models/publickey.go#L104-L114
Is your key is RSA 1024?

Yes it is RSA 1024.

@zacheryph thanks for classifying!

Hi @zacheryph , pushed fix to master, now you're able to use [service] DISABLE_MINIMUM_KEY_SIZE_CHECK = true to disable minimum check.

Ahh nice.  I was attempting to do a warning but couldn't get it.  This works also.  Awesome, thank you.

No problem!

How's going on this one?

This is working as expected.  Love it.  Thank you.  Can be closed :D

Great, thanks for confirmation!

Hehe.  I did have an issue with the Locale file yesterday.  I renamed it locally and everything came up just fine

Cool, actually I added a auto-fix for that locale thing last night.


Upgrade OpenIPMI to 2.0.36 to fix CVE-2024-42934

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

[x] The toolchain has been rebuilt successfully (or no changes were made to it)
[x] The toolchain/worker package manifests are up-to-date
[x] Any updated packages successfully build (or no packages were changed)
[x] Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
[x] Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
[x] All package sources are available
[x] cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
[x] LICENSE-MAP files are up-to-date (./LICENSES-AND-NOTICES/SPECS/data/licenses.json, ./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md, ./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)
[x] All source files have up-to-date hashes in the *.signatures.json files
[x] sudo make go-tidy-all and sudo make go-test-coverage pass
[x] Documentation has been updated to match any changes to the build system
[ ] Ready to merge

Summary

What does the PR accomplish, why was it needed?
Upgrade OpenIPMI to 2.0.36 to fix CVE-2024-42934
Change Log

CVE-2024-42934

Does this affect the toolchain?

NO
Associated issues

NA

Links to CVEs

https://nvd.nist.gov/vuln/detail/CVE-2024-42934

Test Methodology

Pipeline build id: xxxx

Thanks @xordux for the review.

Thanks  @jslobodzian/ @rikenm1 for the review.

Auto cherry-pick results:

main :white_check_mark: -> https://github.com/microsoft/azurelinux/pull/10734

Auto cherry-pick pipeline run -> https://dev.azure.com/mariner-org/mariner/_build/results?buildId=657998&view=results


[FX-2262] Renders hidden sub-menus to ensure they are crawlable

Closes: FX-2262
Looks identical, just instead of rendering/not rendering we thread the boolean through to useSpring and display: none|block

Clever!

CSS> JS ❤


Replace Boost Locale

Boost locale isn't header only and fails to link as a result on Windows, we either need to vendor Boost in a different way or replace it with something else.

One possible replacement: https://github.com/nemtrif/utfcpp

May be use <codecvt> from STL? Yes, it is deprecated and we even have an issue to get rid of it, but it is still supported and this way we won't need any dependencies.

May be use <codecvt> from STL? Yes, it is deprecated and we even have an issue to get rid of it, but it is still supported and this way we won't need any dependencies.

Or may be even use ICU 🤔

@SiarheiFedartsou Yes we switched to ICU in #1660.
However, we are not using ICU on iOS so we'd need a platform implementation (using NSString?). And there is a linker error on Android due to the vendored dependency not including the necessary source files.

May be use <codecvt> from STL? Yes, it is deprecated and we even have an issue to get rid of it, but it is still supported and this way we won't need any dependencies.

This seemed like a reasonable temporary solution to me.


Super users cannot edit the profile of other super users

When a super user tries to edit the advisor position of another super user, the following pink message is displayed:
"Forbidden: Exception while fetching data (/updatePosition): You do not have permissions to do this."
Both super users were assigned to the same advisor organization.
The work around is to select the "ANET User" button for the super user profile being selected.  This makes the edited super user no longer a super user, but at least the position can be edited.

Added to epic #2191

Discussed this with @dspCarlson and he told me that:

super users need to change the location, position name or billet number of another super user (within their organization or in a subordinate organization).
but, super users don't change privileges from super user to user when another advisor redeploys.  They just don't do it.  Its not an intuitive action.  Super users are overwhelmed with other duties.

Therefore we need to make sure they are allowed to change a super user position as long as it is within their organization or in a subordinate organization. But super users shouldn't be able to upgrade a user position to a super user position.


Expand compiler

Work on the following compiler expansions:

Add more backends (ARM for now)
Add more frontends for Brainfuck-like languages

Project restructured completely and recreated from scratch in a modular and maintainable way.
Added fuckbeEs frontend
Working on a x86_64 assembly backend

Added a comprehensive README

Added x86_64 machine code generation (incomplete)

Add complete x86_64 machine code generation and JIT example

Added customizable memory allocator


$cordovaBarcodeScanner camera not show when view by iOS 10+

when i click the scan button, nothing will happen, i sleep the ipad, and turn on again, then the camera will appear.

Have the same problem, on an iPhone 5s with 10.1.1. The scanner windows doesn't show up until I click the home key and click on the app icon again. If I tap the scan button twice, I get a "Scan is already in progress" popup, even though the scan windows isn't showing.

his is due to the new content security introduced in iOS 10 to prevent XSS.
https://github.com/phonegap/phonegap-plugin-barcodescanner/issues/382#issuecomment-271886739

Duplicate of https://github.com/phonegap/phonegap-plugin-barcodescanner/issues/382

Hi, do we have solution for this?

@amoizesmailacn yes, you have to add gap: to your CSP

@jcesarmobile  Do u have a steps on how to do it?

@amoizesmailacn look for your Content-Security-Policy meta tag in your index.html and add gap: in the default-src.

@jcesarmobile Oh the first tap of the scan button, nothing happen and when I tap again the button the error message is "Scanning failed: Scan is already in progress"


eos_download: add disable ztp for vEOS-lab running in Eve-NG

Added --disable_ztp flag to disable ZTP mode for vEOS-lab devices used in Eve-NG
To test just add the flag to the script:
./eos_download.py --api <Arista.com token> --ver 4.23.2F --img vEOS-lab --eve --disable_ztp
This will add DISABLE=True in /mnt/flash/zerotouch-config
localhost login: admin
localhost>en
localhost#sho zerotouch

ZeroTouch Mode: Disabled
Script Exec Timeout: 900

Added this code along with some other changes via another commit so closing this one. All the changes here worked after testing.


Guestbook test on openstack leak volumes from redis StatefulSet

How to categorize this issue?

/area testing
/kind bug
/priority normal
What happened:
In regular tests I noticed that a lot of volumes leak in our openstack landscape. Most of the leaked volumes are 8GB in size and contain some redis data, so I assume they are from the guestbook test with deploys a redis sts.
What you expected to happen:
No leaking.
How to reproduce it (as minimally and precisely as possible):
Currently I only observe it after the fact (after the resp. test cluster was already deleted). Haven't tried to reproduce yet.
Anything else we need to know?:
We are currently testing k8s 1.19.2 and 1.18.9 clusters, unfortunately from the leaked volumes I cannot tell which clusters the volumes originated from.
Environment:

Gardener version:
Kubernetes version (use kubectl version): 1.19.2 and 1.18.9
Cloud provider or hardware configuration: openstack
Others:

/area storage

/assign @ialidzhikov

This issue is actually caused by the Testing if Shoot can be hibernated successfully against v1.19 cluster. See https://github.com/gardener/gardener-extension-provider-gcp/issues/172 (issue is opened under gardener/gardener-extension -provider-gcp but it is applicable also for all providers using CSI, there is also the same issue under g/g - https://github.com/gardener/gardener/issues/2545).
You can read the full analysis in https://github.com/gardener/gardener-extension-provider-gcp/issues/172#issuecomment-692791115. Long story short - currently there is no garbage collection for of volumeattachments.storage.k8s.io (resource which is used with CSI) in kube-controller-managare (ref kubernetes/kubernetes#77324). When Shoot is hibernated, the Nodes are forcefully deleted (without waiting running Pods to detach volumes) -> this leaks volumeattachments. On wake up new volumeattachment is created for the PV and the new Node and the old volumeattachment is orphaned.
Basically this can be easily reproducible with with the Testing if Shoot can be hibernated successfully test.

Run the test

$ go test -timeout=0 -mod=vendor ./test/suites/shoot \
      --v -ginkgo.v -ginkgo.progress -ginkgo.noColor \
      --report-file=/tmp/report.json \
      -kubecfg=$KUBECONFIG \
      -shoot-name=$SHOOT_NAME \
      -project-namespace=$PROJECT_NAME \
      -ginkgo.focus="Testing if Shoot can be hibernated successfully"

Ensure that the test succeeds but leaves a PV

# Ensure that the test ns is deleted
$ k get ns
NAME              STATUS   AGE
default           Active   97m
kube-node-lease   Active   97m
kube-public       Active   97m
kube-system       Active   97m

$ k get volumeattachments.storage.k8s.io
NAME                                                                   ATTACHER                   PV                                                               NODE                                                     ATTACHED   AGE
csi-62dfe186e1e1498955ff92d07d3ea7bc6bb30531547b73527bd0fc0bd214f2e2   cinder.csi.openstack.org   pv-shoot--baaaaar--tm-foo-1a9ced3c-9750-4ebe-90bc-7b7ea1edaaaa   shoot--baaaaar--tm-foo-worker-uoq0s-z1-ddcdf9db8-8khsn   true       35m

$ k get pv
NAME                                                             CAPACITY   ACCESS MODES   RECLAIM POLICY   STATUS     CLAIM                                          STORAGECLASS   REASON   AGE
pv-shoot--baaaaar--tm-foo-1a9ced3c-9750-4ebe-90bc-7b7ea1edaaaa   8Gi        RWO            Delete           Released   gardener-e2e-269qt/redis-data-redis-master-0   default                 36m

$ k describe pv

Events:
  Type     Reason              Age                   From                                                                                Message
  ----     ------              ----                  ----                                                                                -------
  Warning  VolumeFailedDelete  3m11s (x13 over 26m)  cinder.csi.openstack.org_csi-driver-controller-69fb7c6f55-rhp74_2788f50c-fd59-4d66-817a-5c9463b6c6d1  persistentvolume pv-shoot--baaaaar--tm-foo-1a9ced3c-9750-4ebe-90bc-7b7ea1edb3ea is still attached to node shoot--baaaaar--tm-foo-worker-uoq0s-z1-ddcdf9db8-8khsn

This issue should also occur for the other providers.
/status accepted

Note also that the Shoot deletion flow does only deletes and waits for PVCs, but not PVs.

This issue should also occur for the other providers.

I tested on AWS now and the PV deletion hanged again in Terminating but the underlying EBS volume was successfully deleted. I now see that there was a change in the external-provisioner starting v2.0.0 (ref https://github.com/kubernetes-csi/external-provisioner/pull/438/) that now checks whether the PV has volumeattachments and if yes, it fails early and does not call the CSI driver for volume deletion. Currently only provider-openstack extension is using<EMAIL_ADDRESS>That explains why we see the issue only on openstack (for now).

Nice finding! Thanks so much for digging into this!


Consider abstractions/refactoring of [CommonModel]Service and hubspot/salesforce clients to simplify future connector development

There's a lot of duplicated code for connectors and reading/writing/fetching common models right now.
We might want to spend some time refactoring / making better abstractions here to make future development easier. For example:

for every object, across both HS and salesforce, we write the same code over and over to page over responses and pipe things from HS/SF into PassThrough, and it’s relatively complicated. This is likely code that needs to be used for most future connectors, so it would be nice to abstract this away to make new connector development simpler.
90% of the code in AccountService, ContactService, *Service is the same. We could probably make that abstracted as well

Migrated to internal project management tool.


Focus on datepicker could open datepicker

Summary
Provide a means above clicking on the calendar icon, to trigger up the picker, this could facilitate UX on the date picker.
I'm thinking about having an event like on the material datepicker that helps fire up the picker.
Use case
Filling a form using the tab key to switch fields, the user needs to click on the calendar icon to popup the picker.
Workarounds
Tried selecting the button that follows the focused input, and triggered a click event on the button element in the component.ts file, but the behaviour is not stable and throws errors sometimes in the console.

I think from an accessibility standpoint, that is potentially confusing. The focus would start on the input, but then get moved before reading the input. Keyboard users would not get to hear the current value before being forced into a new place, which makes it harder to understand what is happening.
@chlane do you have any guidance on if this is an accessible pattern?

I agree with @gnomeontherun, since screen reader cursors follow browser focus, if focus is moved involuntarily, blind screen reader users may not be able to read some content, like the label for the input field or any other content  from aria-labelledby or aria-describedby. Keyboard-only and blind screen reader users should be able to read and activate controls at their own pace and discretion by using the Tab key to focus controls and the Enter key to activate them.

@gnomeontherun and @chlane the idea is not to enable this by default, but instead to provide a means whenever needed to open the picker, without only clicking on the icon. As I said, it's also available on mat-datepicker (on which you can call a open method to popup the picker).

But if the date picker can only be opened by clicking then how is a user who is not using a mouse going to open it?
Get Outlook for iOShttps://aka.ms/o0ukef

From: Tchowa Franck A<EMAIL_ADDRESS>Sent: Saturday, March 14, 2020 6:06:33 AM
To: vmware/clarity<EMAIL_ADDRESS>Cc: Chris Lane<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [vmware/clarity] Focus on datepicker could open datepicker (#4367)
@gnomeontherunhttps://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fgnomeontherun&data=02|01|chlane%40vmware.com|d8d9940834bb4aca74ff08d7c818860a|b39138ca3cee4b4aa4d6cd83d9dd62f0|0|0|637197879974785956&sdata=5ihZQNIN6kEIt9Tm4Ol7ugztXz9t44sX9VtmV84%2B57E%3D&reserved=0 and @chlanehttps://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fchlane&data=02|01|chlane%40vmware.com|d8d9940834bb4aca74ff08d7c818860a|b39138ca3cee4b4aa4d6cd83d9dd62f0|0|0|637197879974795955&sdata=AFY3EfCvbjID6jGFg3t0M3C1yQZuZy9%2BLLfY6K4%2FlDA%3D&reserved=0 the idea is not to enable this by default, but instead to provide a means whenever needed to open the picker, without only clicking on the icon. As I said, it's also available on mat-datepicker (on which you can call a open method to popup the picker).
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fvmware%2Fclarity%2Fissues%2F4367%23issuecomment-599057482&data=02|01|chlane%40vmware.com|d8d9940834bb4aca74ff08d7c818860a|b39138ca3cee4b4aa4d6cd83d9dd62f0|0|0|637197879974795955&sdata=DSUPPtRlX%2BQuImHBi2y9egTtTfbN%2FuF%2FC5wYIjdiFO8%3D&reserved=0, or unsubscribehttps://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FALPARJTRYFINOWEAKJH4GJDRHN6NTANCNFSM4LHBI3DA&data=02|01|chlane%40vmware.com|d8d9940834bb4aca74ff08d7c818860a|b39138ca3cee4b4aa4d6cd83d9dd62f0|0|0|637197879974795955&sdata=57pad60yrtjhrgwH4qtmjVDyN3jAqebZIOq2PytvQ0k%3D&reserved=0.

@chlane I don't know if it's to me you're addressing, in any case, I'm requesting an event on the datepicker, that we could invoke maybe on a focus, keyup... event.

@franckstifler Hi franckstifler. Opening the datepicker when its trigger gains focus will cause an involuntary movement of focus. When the datepicker opens, the best practice is to move focus inside of it. Due to this, It is important to let sighted keyboard-only and bind screen reader users initiate the appearance of controls like datepickers and dialogs by activating a focused trigger element with the Enter key. Additionally, users should be able to tab past the date picker's triggering element without triggering the appearance of the date picker. Low-vision keyboard-only users and blind screen reader users may try to explore the controls on the page using the Tab key and be confused by having to interact with a date picker control that they do not intend to interact with.
Even if it is not enabled by default, creating an inaccessible feature contradicts our mission of ensuring  our products are born accessible and  introduces more complexity to accessibility testing and conformance reporting (ACRs/VPATs).

I'm going to close this as something we won't do, since it has accessibility implications. Thanks for the suggestion though, I understand the request.


Create index.html file

Create an index.html file for the homepage

Hi @ALX-SE-Algorithmia/code-reviewing-team
I would like to create the index.html file.

Thank you for your implementation.
Your PR has been merged.


Template string bug \u003 ?

var foo = `["m",9536]`;

Emits
var foo = "[\"m\",\u0039536]"; // ?

I came across this by pasting JSON into a template string. Whats '\u003' ?

Good news! That's actually \u0039, which is ASCII 9, so this is technically not wrong.
Bad news: our escaping is broken for at least 7 characters. I'll have a fix out in a bit.

:) Found fix in
core.ts
var escapedCharsRegExp = /[\0-\x19\t\v\f\b\0\r\n\u2028\u2029\u0085]/g;

Yup, correcting it now.


sqlite 4.6.2 has depdenies, that require android compileSdkVersion 33

Describe the bug
sqlite 4.6.1 works fine. sqlite 4.6.2 has android dependencies that are compiled against android sdk version 33. Therefore, during a gradle build, errors show up, that the app needs to be compiled against sdk 33. Capacitor 4 supports only sdk 32.
    1.  Dependency 'androidx.room:room-runtime:2.5.0' requires libraries and applications that
    depend on it to compile against version 33 or later of the
    Android APIs.

    :app is currently compiled against android-32.

    Recommended action: Update this project to use a newer compileSdkVersion
    of at least 33, for example 33.

    Note that updating a library or application's compileSdkVersion (which
    allows newer APIs to be used) can be done separately from updating
    targetSdkVersion (which opts the app in to new runtime behavior) and
    minSdkVersion (which determines which devices the app can be installed
    on).

    2.  Dependency 'androidx.sqlite:sqlite-framework:2.3.0' requires libraries and applications that
    depend on it to compile against version 33 or later of the
    Android APIs.

    :app is currently compiled against android-32.

    Recommended action: Update this project to use a newer compileSdkVersion
    of at least 33, for example 33.

    Note that updating a library or application's compileSdkVersion (which
    allows newer APIs to be used) can be done separately from updating
    targetSdkVersion (which opts the app in to new runtime behavior) and
    minSdkVersion (which determines which devices the app can be installed
    on).

    3.  Dependency 'androidx.sqlite:sqlite:2.3.0' requires libraries and applications that
    depend on it to compile against version 33 or later of the
    Android APIs.

    :app is currently compiled against android-32.

    Recommended action: Update this project to use a newer compileSdkVersion
    of at least 33, for example 33.

    Note that updating a library or application's compileSdkVersion (which
    allows newer APIs to be used) can be done separately from updating
    targetSdkVersion (which opts the app in to new runtime behavior) and
    minSdkVersion (which determines which devices the app can be installed
    on).

    4.  Dependency 'androidx.security:security-crypto:1.1.0-alpha05' requires libraries and applications that
    depend on it to compile against version 33 or later of the
    Android APIs.

    :app is currently compiled against android-32.

    Recommended action: Update this project to use a newer compileSdkVersion
    of at least 33, for example 33.

    Note that updating a library or application's compileSdkVersion (which
    allows newer APIs to be used) can be done separately from updating
    targetSdkVersion (which opts the app in to new runtime behavior) and
    minSdkVersion (which determines which devices the app can be installed
    on).

To Reproduce
Steps to reproduce the behavior:

Create a capacitor app with the supported compileSdkVersion 32 and include sqlite 4.6.2.
npx cap run android --> the errors show up

Expected behavior
sqlite should be compiled against sdk 32, as long as 33 is not officially supported by capacitor.
Desktop (please complete the following information):
Smartphone (please complete the following information):

Device: Pixel 7
OS: Android 13
Browser [e.g. stock browser, safari]
Version 32/33

@mueggi Thanks for your remark, either you keep running with 4.6.1 which works with API 32 or the latest release which requires API 33. The update to androidx.security:security-crypto:1.1.0-alpha05 was required to fix some issues. @capacitor/core doesn't seems to suffer from this. May be you should ask the ionic team to move Capacitor 4 to API 33.


update MockBigScreenPlayer to support subtitle changes

📺 What
Follow up to https://github.com/bbc/bigscreen-player/pull/137.
Make registerForSubtitleChanges work as expected with the mock.

Tickets: IPLAYERTVV1-11166

🛠 How
Update MockBigScreenPlayer

If you run npm run pre-release:patch on this branch it should be good to go.

If you run npm run pre-release:patch on this branch it should be good to go.

done!


ENH: Merge T2w images and coregister to T1w template

Changes proposed in this pull request
Integrates and connects up nipreps/smriprep#319.
Documentation that should be reviewed

[ ] Mention in docs

Raw

Preprocessed

Doc update:

Doesn't seem worth making a distinction that they won't be available in template spaces yet. That will be on the todo list.

@mgxd This should be good to go.


Quite clear glass turns back to vanilla glass when placed in refined storage

Issue description:
Quite clear glass turns back to vanilla glass when placed in refined storage
What happens:
When I autocraft 3 regular glass to quite clear glass using an alloy smelter, when the items are imported into the system they are changed back to regular glass.
What you expected to happen:
Quite clear glass should be added to the system and not turned back to regular vanilla glass
Steps to reproduce:

Place glass in the alloy smelter
Get the smelted Quite clear glass
Place the items into the system

Version (Make sure you are on the latest version before reporting):

Minecraft: 1.10.2 (Skyfactory 3)
Forge: forge-<IP_ADDRESS>4
Refined Storage: 1.2.22

Does this issue occur on a server? [no] Single player
Small screencast to show it in action:
http://screencast-o-matic.com/watch/cbfV226Lhp (Sorry for the loud noise at the beginning of the video)

duplicate

If you are storing your glass in storage drawers, they can (and will) accept anything that's ore dictionaried. And as Quite Clear Glass is ore dictionaried to blockGlass it will accept it and convert it. The screencast you have there doesn't show all your network, so I can't tell if that's an issue here or not.

Not storing anything in storage drawers. The alloy smelter was connected to refined storage and kept turning it back into glass when inserting in RS, also I manually added the Quite clear glass in to RS system so why would storage drawers have any effect on that?

But will the block end up in your drawers due to an external storage connection?

If you don't have any storage drawers with glass in attached to this network, then this doesn't apply. If you do, however, then that may be what you're running into.
RS will prioritise putting items with like items in storage. Storage Drawers "advertise" they have the items within, and all items that are oredicted to those items. So if you have a drawer with glass in it, RS will look to see where it can place Quite Clear Glass, and the Storage Drawer will report it has items and can accept it, so RS will place it there.
If this is not what you want, you can set the external storage attached to the storage drawer to "Export only". To see if this is a RS bug or a Storage Drawers issue, I'd suggest re-creating this with an independent network, with just a Controller, Alloy Smelter, Storage block (or Disk Drive and disk), Importer and EIO Alloy furnace. If it still does it with just RS and EIO, nothing else in the network, then it's a RS bug.

I was having the opposite problem, vanilla glass turning to quite clear, and also using storage drawers.
I solved it by adding a 1k storage block and using it only for vanilla glass storage.

This is likely cause Storage Drawers manage their own stuff, might be a solution to turn off oredict matching on your external storage facing the drawer(s).

mmm so i had it linked using an external storage pipe and network, would that still cause this problem? anyway I removed all the storage drawers anyway and put all in RS, I'll test it again later

If you insert the glass manually in the drawer controller, what happens? Will it transform to the normal glass as well?

Yep. If I insert the "Quite Clear Glass" in a Drawer Controller connected to a drawer with "Glass", Storage Drawers converts it to regular glass. Thus, this is not an RS issue. Please report over at the Storage Drawers issue tracker. This can be intended behavior as well.

I also tested this again yesterday and it's indeed not an RS issue. I did have a drawer that contained glass. sorry about that.


Current Value not displaying value

On the portfolio pg in the positions section the Total Returns/Current Value toggle button....when changed to Current Value, Value still shows 0.000 even though there is a current value for an open position...
see screenshot:

market currentValue should be total value of all positions.


Add support for pagination

Ideally, allow jumping to a specific page, paging forward/backward, and configuring page size. We should try to assume as little as possible about how pagination is actually implemented by the consuming app -- they might have all the data loaded onto the client, or (more likely) they might be paginating the response from the web server. Also, they might be tracking pagination info in various ways (e.g., by storing them in the query params).

Done in PR #12


Error when running pip install rudalle==1.0.0

Trying to get the code to run locally on my computer with python in Anaconda. I entered this command: pip install rudalle==1.0.0
Wasn't able to install as I got this error. How to fix?
ERROR: Could not install packages due to an OSError: [Errno 2] No such file or directory: 'x:\users\xxx\anaconda3\lib\site-packages\numpy-1.20.3.dist-info\METADATA'

ERROR: Could not find a version that satisfies the requirement youtokentome~=1.0.6 (from rudalle) (from versions: 1.0.0, 1.0.1, 1.0.2, 1.0.3rc1, 1.0.3, 1.0.4, 1.0.5, 1.0.6)
ERROR: No matching distribution found for youtokentome~=1.0.6

Other error

pip3 install Cython


enh: ts/js/ci setup for connectors

unify eslint + prettier with front
add CI

@lasryaric had to add an empty TS file to src, otherwise it's a typescript error ("TS was configured on directory XXX but there are no files")


Clean up Dashboard > System and Settings > Boards section

There are a number of pages within this section of the Dashboard System and Settings. Let's ensure they're using the right styles for buttons and that they all look good in the v9 interface.
That means things like

Making sure any tabs included in the page actually work (the bootstrap 4 tab required markup is new.)
Making sure we use btn-secondary instead of btn-default.
Making sure we use float-left and float-right instead of the old pull classes.
Other legacy bootstrap 3 -> 4 conversion updates.

Hi @aembler, here is the PR : https://github.com/concrete5/concrete5/pull/8625
Thanks :)

Thanks!


Bug in Solution

I think according to the problem statement, the problem should accept the solution a=7 and then b=a statements. But, its even accepting b=a then a=7 .
Refer below for the problem statement:
Challenge Declare JavaScript Variables has an issue.
User Agent is: Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/49.0.2623.87 Safari/537.36.
Please describe how to reproduce this issue, and include links to screenshots if possible.
My code:
// Example
var ourName;
var myName;
// Define myName below this line

Did you put the correct challenge and explaination? What you've put in "My code:" doesn't match what you wrote at the top.

Yeah, I think @kvscse is referring to the Storing Values with the Assignment Operator challenge.
If the following is what you intended, it should not pass the challenge, thus there is no problem with the challenge. It would not pass the third test of b should have a value of 7 because b would still be equal to 2.
// Setup
var a;
var b = 2;

// Only change code below this line
b = a;
a = 7;

Closing as this isn't a bug. @kvscse let me know if my understanding of your problem is wrong and I can reopen the issue.

@erictleung The code fails the first time. However, when the tests are run again, it will pass.

I added console.log("a = " + a + ", b = " + b); above the rest of the code. Here's what my browser's console outputs the first time the tests are run:

As expected, both a and b are undefined before the rest of the code is run. However, when the tests are run the second time, here's what I get:

Yes..sorry..I mistakenly typed the code..
Thanks @erictleung its the problem what I wanted to note.Thank You. :)

@alistermada @erictleung
yes look at the console, according to the motive of the problem statement, it must be success only if b is also 7..but not "undefined" right??

@FreeCodeCamp/issue-moderators Any thoughts on why this is happening? If you copy paste this into a newly opened window for Storing Values with the Assignment Operator, and run the tests twice, it'll pass.
console.log("a = " + a + ", b = " + b);

// Setup
var a;
var b = 2;

// Only change code below this line
b = a;
a = 7;

Running it once goes to the point in which a=7. The second time takes that value when b=a. The store is remaining in the console's memory.
How to avoid that is beyond me. But that is why, @erictleung

Humm . . one way to fix this would be to add a regex to check that the assignment has been done properly.
IE:
/b\s*=\s*a/

@SaintPeter right now, the last test actually tests for that with /b\\s*=\\s*a\\s*;/g.test(code). This challenge has all sorts of weird things going on with it like in #7890.

LOL, well, I guess we ought to fix it then?  ;)

I did the same thing, but it's not working. I really want to figure this out.

var a=7;
var b=a;
var b=;
Please help me, What will be the value of B;

Alhamdulillah, I found the solution:
http://prntscr.com/gx9x1a


[openapi] single backslash escape for UUID Regex

The regular expression specified in the pattern for various UUID fields uses two backslashes for escaping the dashes (\\-) when it should only use one (\-), similarly to how it is done on the F3548-21 branch of the astum-utm protocol .
Some participants rely on these definitions to validate payloads received from the APIs, and run into problems.

@BenjaminPelletier I don't know if this should be merged to main or instead moved to a separate branch as was done for the astm-utm/Protocol repository?
The goal would be to have a commit with the fix available so that we can point the submodule in the interuss/monitoring repository to it.

This should be merged to main.  This repo contains APIs InterUSS designed, not APIs that are components of published third-party standards like astm-utm/Protocol or uastech/standards, so we can change them at will (though of course we should pay attention to usability concerns like backwards compatibility, etc).  The canonical API for F3548-21 actually has the same problem, but it was fixed in the unofficially-corrected branch we use.

Sorry, I misspoke -- we should rev the least-significant number in the semantic version (patch) since we are fixing a bug and adding no new functionality

Fixed


Native deepspeed implementation

As usual, lightning is nice but limited.  It would be great to have a full pytorch version with deepspeed so that we can experiment with 3D parallelism.  Early experiments suggest that gpt3 isn't scalable much past 32 nodes (polaris) using simply pytorch-lightning + ZeRO3 or FSDP.  Perhaps scaling past this point requires pipeline/model parallism or tensor parallelism, both of which are not available via the lightning interface.

Cobbled together.  Testing in progress.  Will open new issues if scaling sucks or issues abound.


Crash when using interactable object when changing scene

I'm getting an error: InvalidOperationException: Collection was modified; enumeration operation may not execute. it's coming from VRTK.VRTK_InteractableObject.ForceStopAllInteractions ()

InvalidOperationException: Collection was modified; enumeration operation may not execute.
System.Collections.Generic.List1+Enumerator[UnityEngine.GameObject].VerifyState () (at /Users/builduser/buildslave/mono/build/mcs/class/corlib/System.Collections.Generic/List.cs:778) System.Collections.Generic.List1+Enumerator[UnityEngine.GameObject].MoveNext () (at /Users/builduser/buildslave/mono/build/mcs/class/corlib/System.Collections.Generic/List.cs:784)
VRTK.VRTK_InteractableObject.ForceStopAllInteractions () (at Assets/VRTK/Scripts/VRTK_InteractableObject.cs:869)
VRTK.VRTK_InteractableObject.ForceStopInteracting () (at Assets/VRTK/Scripts/VRTK_InteractableObject.cs:563)
VRTK.VRTK_InteractableObject.OnDisable () (at Assets/VRTK/Scripts/VRTK_InteractableObject.cs:654)

Completed with https://github.com/thestonefox/SteamVR_Unity_Toolkit/commit/f9c5ca2e9321fec8ce68296de4a530a391459cdb


convert GPT2CausalLM to tflite

Hello, I am trying to convert keras-nlp supported models to tflite. Below is code snippet for GPT2 but I have also run into below error with other keras nlp models. I am getting this error: AttributeError: 'GPT2CausalLM' object has no attribute '_get_save_spec for the few keras nlp models I tried when trying to convert to tflite. Ideally, I want to be able to convert any keras nlp model to tflite, can you guys guide me on above error and suggest any fixes and if there are any other potential errors I should be aware of.
Below is my conversion code:
preprocessor = keras_nlp.models.GPT2CausalLMPreprocessor.from_preset(
    "gpt2_base_en",
    sequence_length=128,
)
gpt2_lm = keras_nlp.models.GPT2CausalLM.from_preset(
    "gpt2_base_en", preprocessor=preprocessor
)

gpt2_lm.save("gpt2_model.keras")

loaded_model = tf.keras.models.load_model("gpt2_model.keras")
converter = tf.lite.TFLiteConverter.from_keras_model(loaded_model)

converter.optimizations = [tf.lite.Optimize.DEFAULT]

tflite_model = converter.convert()

with open("gpt2_model_custom.tflite", "wb") as f:
    f.write(tflite_model)

I tried the above code and I get the following error.
[<ipython-input-16-9f253e13d59c>](https://localhost:8080/#) in <cell line: 17>()
     15 converter.optimizations = [tf.lite.Optimize.DEFAULT]
     16
---> 17 tflite_model = converter.convert()
     18
     19 with open("gpt2_model_custom.tflite", "wb") as f:

6 frames
[/usr/local/lib/python3.10/dist-packages/tensorflow/lite/python/tflite_keras_util.py](https://localhost:8080/#) in model_input_signature(model, keep_original_batch_size)
    117     input_specs = input_specs[0][0]
    118   else:
--> 119     input_specs = model._get_save_spec(  # pylint: disable=protected-access
    120         dynamic_batch=not keep_original_batch_size)
    121     if input_specs is None:

_AttributeError: 'GPT2CausalLM' object has no attribute '_get_save_spec```_

Hi @merronmuche ,
Thanks for reporting the issue.
keras_nlp has been renamed to keras_hub, so you can install keras-hub using !pip install -Uq keras-hub and the attribute error seems to be resolved in the latest version.
Attaching Gist for your reference.


Spotting passwords in VB now

Added optional As String in generic password pattern to spot VB string assignments
I still need to adjust the README

The automatic markdown generation is failing, but I ran it myself.
P.S. I did a PR to the tools repo to try to fix the problems with the paths (relative vs absolute). I think it works, see what you think.


[Tooltip] fix wrong anatomy

Raised here: https://github.com/radix-ui/primitives/issues/590#issuecomment-817177537

Thank you! Not sure if should be a separate PR, but I noticed something similar for the Slider component:
  <Slider.Root>
    <Slider.Track>
      <Slider.Thumb />
    </Slider.Track>
    <Slider.Range />
  </Slider.Root>

The Range should be inside Track, and Thumb should be outside:
  <Slider.Root>
    <Slider.Track>
+      <Slider.Range />
    </Slider.Track>
+    <Slider.Thumb />
  </Slider.Root>

Ha, thanks for that @pacocoursey, I'll open another PR.

@peduarte I'll let you merge this or apply these changes on top of yours as you wish.

Done in https://github.com/radix-ui/website/pull/132/commits/bf1ff6ba0e55ad4fb176a20e2d8140ad558c1204


Update build.gradle

This PR is to solve the issue "the resource android:attr/lStar is not found"
Android SDK that doesn't support certain attributes, such as lStar which was introduced in Android 12 (API level 31).

Why hasn't this been merged? is this package no longer maintained?


order on extra fields not respected

Feature Request
Among many things we're using Pydantic for (thank you for this amazing project) is as an interim step for a report / data export engine. On some exports, I know the form of half of the columns & want to validate those. The other half, I don't need to validate.
I use the extra flag on that so the object is flexible enough w/o having to create a new model dynamically. What I would expect: Pydantic would take & create new fields per extra key on the class in the order that the field is received. What happens: new fields are created, but order isn't respected - see the example below.
Feels like a bug; is this the expected behavior? Given the importance that Pydantic places on field order I'd assume the answer is no but wanted to get your thoughts.
Output of python -c "import pydantic.utils; print(pydantic.utils.version_info())":
             pydantic version: 1.4
            pydantic compiled: False
                 install path: /Users/leo/.local/share/virtualenvs/services-PFQGUeYK/lib/python3.8/site-packages/pydantic
               python version: 3.8.1 (default, Dec 27 2019, 18:06:00)  [Clang 11.0.0 (clang-1<IP_ADDRESS>)]
                     platform: macOS-10.15.2-x86_64-i386-64bit
     optional deps. installed: ['email-validator']

from pydantic import BaseModel

class CSVRow(BaseModel):
    id: int
    name: str
    address: str

    class Config:
        extra = "allow"

row: dict = {"id": 1, "name": "Jon Snow", "address": "100 Winterfell", "Sword Name": "Longclaw", "Birth Year": "281 AC", "Birth Place": "Tower of Joy", "Lovers": ["Ygritte", "Danerys Targaryen"]}

validated_row: CSVRow = CSVRow(**row)

validated_row
# CSVRow(id=1, name='Jon Snow', address='100 Winterfell', Birth Year='281 AC', Birth Place='Tower of Joy', Lovers=['Ygritte', 'Danerys Targaryen'], Sword Name='Longclaw')

validated_row.dict()
# {'id': 1, 'name': 'Jon Snow', 'address': '100 Winterfell', 'Birth Year': '281 AC', 'Birth Place': 'Tower of Joy', 'Lovers': ['Ygritte', 'Danerys Targaryen'], 'Sword Name': 'Longclaw'}

validated_row.json()
# '{"id": 1, "name": "Jon Snow", "address": "100 Winterfell", "Birth Year": "281 AC", "Birth Place": "Tower of Joy", "Lovers": ["Ygritte", "Danerys Targaryen"], "Sword Name": "Longclaw"}'

I've changed the label from bug to feature request since we don't make any guarantee about this working the other way at present.
The reason for this is:
https://github.com/samuelcolvin/pydantic/blob/645e5fe6a0c74c95c24410571e9bb804af3eb677/pydantic/main.py#L857-L869
This is the most performant way (I know of) to achieve what's currently required, however I would consider a change to maintain order.
But it would depend on the performance impact, if it's too large I'd rather avoid the change.

Gotcha - I changed the header on the original issue to reflect your label change.
Would you want ordering on extra fields to be an option on config & split the difference? Or is the additional complexity not worth that consideration to you?
Given the relatively substantial performance implications of using a list vs. sets as currently implemented, by performance impact I'd imagine it would be hard to justify. unless you introduce an ordered implementation of set, a la something like https://github.com/LuminosoInsight/ordered-set, which sort of splits the difference but slows things down a little bit).

IIUC the feature request is about key ordering at a model level. But maybe an intermediate option with the extra fields ordered after the declared ones could be implemented with no performance impact. This wouldn't resolve the feature request but it seems a valuable feature by itself and maybe a starting point.
names_used is only employed to evaluate extra. An oversimplified and far-from-reality example that would set extra before the fields iteration and modify it in place suggests that this strategy could be more performant (and less memory-consuming) while avoiding the unordering introduced by the set:
from string import ascii_letters as L

DECLARED, EXTRA = 5, 5
input_data = {L[k]: k for k in range(DECLARED + EXTRA)}
fields = [L[k] for k in range(DECLARED)]

def test1():
    # unordered extra
    names_used = set()

    for f in fields:
        names_used.add(f)

    extra = input_data.keys() - names_used

def test2():
    # ordered extra
    extra = list(input_data)

    for f in fields:
        extra.remove(f)

if __name__ == '__main__':
    import timeit
    print(timeit.timeit("test1()", setup="from __main__ import test1"))
    print(timeit.timeit("test2()", setup="from __main__ import test2"))

+1 on this feature request. I've run into this field order problem when creating tests for a FastAPI application. Using .dict() seems to keep field order, but .json() fails regularly.
from pydantic import BaseModel

class TestInput(BaseModel):
    class config:
        extra = "allow"

class TestOutput(TestInput):
    id: str
    metadata: str

keys_input = {
    "key1": True,
    "key2": False
}
keys_output = {
    "id": "some_id",
    "key1": True,
    "key2": False,
    "metadata": "some_metadata"
}

test_input = TestInput.parse_obj(keys_input)
test_output = TestOutput.parse_obj(keys_output)

exclude_fields = {"id", "metadata"}
assert test_input.dict() == test_output.dict(exclude=exclude_fields)
assert test_input.json() == test_output.json(exclude=exclude_fields)

Any updates on this? Did you guys found a workaround to repect the field order? Also run into this problem building a FastAPI application

@xoelop I've used the following as a workaround. Note that I am still using Pydantic v1.8 and haven't tested on more recent versions.
class Foo(BaseModel):
  def __init__(self, *args, **kwargs):
    # HACK: Because Pydantic does not preserve order for extra parameters (https://github.com/samuelcolvin/pydantic/issues/1234)
    #       we assign them in order after the class has been created
    # HACK #2: To do this, we temporarily set 'allow_mutation' to True, and
    #       reset it to the value in Config afterwards.
    extra_kwargs = {}
    for k in list(kwargs):
      if k not in self.__fields__:
        extra_kwargs[k] = kwargs.pop(k)

    super().__init__(*args, **kwargs)

    # vvvv Enable mutations vvvv
    old_allow_mutation = self.__config__.allow_mutation
    self.__config__.allow_mutation = True
    for k, v in extra_kwargs.items():
      setattr(self, k, v)
    self.__config__.allow_mutation = old_allow_mutation
    # ^^^^ Reset mutability as before ^^^^

This is fixed in v2 I think. I'll add a unit test to confirm that order is maintained.
I doubt it will get changed in v1, but hopefully v2 will be released this year.


Add support for Patch method

@zakiva can you check why this is failing. Thanks.

@simon3z fixed

I'd like to understand why this functionality is needed and several aspects around it:

the client already provides the update_X methods with PUT, why the patch is needed in addition to it?
do all the entities support PATCH on k8s client side? (didn't see a definitive answer in the docs)
how the users will differ update_X from patch_X and know when to use which? maybe better names are required, if indeed this functionality shall be added to the client.

@abonas Almost all entities support Patch on Kubernetes side (except for ComponentStatus which does not support other methods as well). Patch may be useful for late initialization or when pushing annotations on entities, maybe @simon3z can point out another use case.
I agree that having both update and patch may be confusing. One option is to change "update" to "replace" as done in kubectl commands: https://github.com/kubernetes/kubernetes/pull/10468 https://github.com/kubernetes/kubernetes/pull/10374

the client already provides the update_X methods with PUT, why the patch is needed in addition to it?

http://restcookbook.com/HTTP Methods/patch/

when you only need to update one field of the resource, PUTting a complete resource representation might be cumbersome and utilizes more bandwidth (you have to GET  and PUT)

patching is done atomically on the server side (no risk for races with other concurrent GET/PUT)

kubernetes and openshift are supporting it both server side and on their clients (kubectl patch and oc patch), we should close this gap here.

do all the entities support PATCH on k8s client side? (didn't see a definitive answer in the docs)

As any other rest-api call it can fail server-side for several reasons. What if it's supported but the user has no permissions to update the entity. We shouldn't enforce any policy on the client side.
If an entity has no patch support it will fail.

how the users will differ update_X from patch_X and know when to use which? maybe better names are required, if indeed this functionality shall be added to the client.

Update is replacing the entire entity and patch is just a diff that gets applied atomically. The user will use pick the one which is relevant for his use-case.
"Patch" is called patch in rest-api, in rest-client, in kubernetes and openshift (both server and client) so I don't think we should change its name.
On the other hand, what we call "update" is called "replace" in kubernetes:
$ kubectl help
...
  create         Create a resource by filename or stdin
  replace        Replace a resource by filename or stdin.
  patch          Update field(s) of a resource using strategic merge patch.

Although I am fine to keep the existing method with the current name "update".

the client already provides the update_X methods with PUT, why the patch is needed in addition to it?
http://restcookbook.com/HTTP Methods/patch/
when you only need to update one field of the resource, PUTting a complete resource representation might be cumbersome and utilizes more bandwidth (you have to GET and PUT)
patching is done atomically on the server side (no risk for races with other concurrent GET/PUT)
kubernetes and openshift are supporting it both server side and on their clients (kubectl patch and oc patch), we should close this gap here.
do all the entities support PATCH on k8s client side? (didn't see a definitive answer in the docs)
As any other rest-api call it can fail server-side for several reasons. What if it's supported but the user has no permissions to update the entity. We shouldn't enforce any policy on the client side.
If an entity has no patch support it will fail.

yes that is obvious that the server can fail any request for any particular reason and the client doesn't enforce it. my point was that if only one entity supports it on server side, I don't see any reason adding a "massive" support for it for all entities.

how the users will differ update_X from patch_X and know when to use which? maybe better names are required, if indeed this functionality shall be added to the client.
Update is replacing the entire entity and patch is just a diff that gets applied atomically. The user will use pick the one which is relevant for his use-case.
"Patch" is called patch in rest-api, in rest-client, in kubernetes and openshift (both server and client) so I don't think we should change its name.
On the other hand, what we call "update" is called "replace" in kubernetes:
$ kubectl help
...
create         Create a resource by filename or stdin
replace        Replace a resource by filename or stdin.
patch          Update field(s) of a resource using strategic merge patch.
Although I am fine to keep the existing method with the current name "update".

yes, I would not rename the existing update methods not to break existing users.
I am missing tests and additions to readme in this patch.

@zakiva don't forget @abonas's ask for documentation and examples.

@simon3z @abonas done

@abonas ack?

@abonas ack?

@simon3z
I left a comment

@abonas can you check if everything is ok now? Thanks.

@simon3z LGTM. have you reviewed it?

:+1:


Outputting wrong file name for image

https://github.com/JellyKid/TwitchTV_FCC
You can find my webpack config there. I'm importing an image in app/components/Channel.jsx. File-loader creates an empty image file and URL string passed to the URL variable. Then it creates the correct file with a totally different hash. I can't seem to get it to give me the correct url or figure out why it's creating an empty image with the correct name.
For example, if I build my project I get two png files.
One 1KB PNG b28d947a261b18ffe4e9740a151b60b5.png and a second 4KB PNG aadf7e0813a755cc519342de5ce91041.png, but file-loader returns the string to the first blank image. File loader should really only be creating one image, so where the second one is coming from, I'm baffled.

Not a problem with file-loader.... It has something to do with webpack preloaders. If importing with "!file!../images/twitch.png" it loads only the one PNG file. Going to open a case on webpack since I'm not actually using any preloaders.

I ran in to something similar and it turned out it was because I was using the babel loader, which was already loading images. I didn't need to have my own file-loader for loading images.


log_configuration shouldn't require optional key secretOptions

If you try and define a log_configuration block, it will fail if you do not define any secretOptions, which are optional.
  log_configuration = {
    logDriver = "awslogs"
    options = {
      awslogs-group = aws_cloudwatch_log_group.foo.id
      awslogs-region = var.aws_region
      awslogs-stream-prefix = "db"
    }
  }

will throw
The given value is not suitable for child module variable "log_configuration"
defined at .terraform\modules\resat_db\variables.tf:135,1-29: attribute
"secretOptions" is required.

https://github.com/cloudposse/terraform-aws-ecs-container-definition/blob/master/variables.tf#L149
Setting secretOptions = [] works around this.

Sorry, this is still an issue and I opened up a new PR for it.


Use github actions for CI

Signed-off-by: Joel Stanley<EMAIL_ADDRESS>

IMO the libpdbg.h change should be in a separate commit.

IMO the libpdbg.h change should be in a separate commit.

It should not be there at all! Thanks for catching that.

Thanks @shenki

Seems to have worked!
https://github.com/open-power/pdbg/runs/3695301873


IBC v8

Tracked for v18. Context TBD

I'm sorry, but I'm not able to assist with your request. As an AI language model, I don't have the capability to check or manipulate labels on an issue. Is there anything else I can help you with?


New article: Create elevation data & services

@FarazGIS New guide that describes how to use USGS worldwide DEM data from their SRTM mission with 30m accuracy to build Elevation service on the Microsoft Azure Cloud.

@FarazGIS
Thanks for reviewing the proposed changes. Note that the commits will need to be moved into the private repo for staging and automated checks.
When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team


Please add "patches" parameter when using kustomize in provider-argocd

What problem are you facing?
I wanted to use "patches" while using kustomize in provider-argocd. Normally, if I create a native argocd application manifest I am able to specify patches for my kustomize application like - docs/operator-manual/application.yaml

How could Crossplane help solve your problem?
If we have the same kind of support in provider-argocd, then it will be really helpful as then I can create a "managed" argocd application manifest in crossplane using provider-argocd
The current supported params for kustomize in provider-argocd is shown below -

I have a WIP at https://github.com/crossplane-contrib/provider-argocd/pull/210

I have a WIP at #210

This is working as expected. Thanks @stevendborrelli .

Any chance to get this one resolved @MisterMX  @maximilianbraun @janwillies  by merging the PR?


Reset binary sensor "call_no_answered"

Hi!
Does anyone knows if/how i can reset this sensor on my Dahua VTO ? When i send service "cancel call" it stays on and i can't find a way to reset it to off...

Same here, though some actions around the VTO are resulting in it being reset.
I believe accepting the next incoming call will clear this one (though didn't test this theory), so you would have to create a helper that will use this binary sensor to be triggered until the unanswered call was recognised to have taken place and any information about it review - like for example camera footage.
I'll probably go this route. Would love not needing to though....

If you figure it out which action is needed you're welcome to write here...
Thanks!

Sure!
I'd appreciate the same in return, or from anyone else for that matter.


Dimensionality of the kernel

Great repo! Hope you would be able to help me out here.
The dimension of the output of the K(self, X,X2=None) operation in kernels.py seems to be $M$ by $M$, where $M$ is the size of $X$. However, as the function is vector-valued and thus the kernel should also be vector-valued, I was expecting the output to be $MD$ by $MD$ where $D$ is the dimension of the vector output, following Equ.(8) in the paper and the description again in Section 2.1
A subsequent and more relevant question to my application, is that how to compute the entropy from the kernel representing the posterior? For the scalar-valued GP, one would need to add the learnt noise variance $\sigma^2$ to the covariance matrix/kernel:
$$K(X,X) + \sigma^2 \mathbf{I}\ .$$
However, here the noise variance $\sigma_d^2|_{d=1}^D$ has $D$ dimensions, and according to Equ.(9) in Alvarez et al. (2012), one needs the $MD$ by $MD$ kernel.
Thank you!

This is true, the covariance matrix is $MD \times MD$. We assume an $M \times M$ block diagonal matrix where each block is $k (\mathbf{x}_i,\mathbf{x}_k) \cdot I_d $.
I'm not sure of the second part of the question (computing the entropy). Can you elaborate?

Thanks for the prompt response!
So in the implementation the $MD\times MD$ is simplified to $M\times M$? Because as I print out the shape of for instance Kzz() in npde.py, the displayed dimension is $M,M$.
Sure, let me point to the referenced equation (Equation (9) in Alvarez et al. (2012)) reproduced here:

As you can see $\Sigma$ is a diagonal matrix with $D$ diagonal entries as ${\sigma_d^2}$. My question is, I want to compute the covariance matrix in the last line of the equation but am having trouble to. In particular, the boldfonted $\mathbf{\Sigma}$ is the kronecker product between $\Sigma$ and $\mathbf{I}$, and as a result $\mathbf{\Sigma}$ has dimension $MD \times MD$. The $\mathbf{K}(\mathbf{X}, \mathbf{X})$, to be added to this covariance must match the dimension for the addition, which brings me to my initial question, how can I obtain a Kzz() which has dimension $MD \times MD$?

In our formulation, $\Sigma$ is also a diagonal matrix with the same entry $\sigma$ on the diagonal. This means, for each output dimension $d \in {1,\ldots,D}$, we have the same variance. Consequently, the same $M \times M$ matrix $K(Z,Z)$ applies to each output dimension and we never have to compute the whole $MD \times MD$ Kronecker product. Unfortunately, our base implementation only stores $M\times D$ inducing values/outputs $U,Z$ and computes $M\times M$ covariances whereas (if I understood correctly) you need $MD$-dimensional inducing values/outputs and $MD\times MD$ covariances.
Can you check kern.OperatorKernel? I think it matches what you need whereas I don't remember testing this module. So unfortunately I cannot guarantee that it is flawless...

Consequently, the same $M\times M$ matrix $K(Z,Z)$ applies to each output dimension and ...

So, is $\Sigma$ explicitly used in some matrix operation, since I am not sure how.
To simplify, is there a way to do things in the $M\times M$ size: i.e., calculating the covariance in the last line of Equation (8) above, but in the $M\times M$ shape? I am okay with using that, but not sure how $\Sigma$ would fit in with the current implementation in terms of matrix operation (addition and multiplication).

We never explicitly form a $D\times D$ kernel matrix but always work with $M \times M$ kernels between $z_i$ and $z_j$ or (similarly $N \times M$ kernels between $x_i$ and $z_i$). You can see the details here: https://github.com/cagatayyildiz/npde/blob/master/npde.py#L62
Do you refer to including GP uncertainty in the predictions, which is what the last line of equation 8 corresponds to? If so, notice that we discard the GP uncertainty in this work. Check our follow-up work concerning how to properly sample from GP posteriors: https://github.com/hegdepashupati/gaussian-process-odes

I see.

Do you refer to including GP uncertainty in the predictions, which is what the last line of equation 8 corresponds to?

I guess you could say I am trying to include GP uncertainty (i.e., $\Sigma$ or $\mathbf{\Sigma}$), but not for prediction though, because I plan to use the posterior covariance $\mathbf{K}$ for calculating posterior entropy (i.e.,  $\mathbf{K}(\mathbf T, \mathbf T)$ over a set $\mathbf T$ of test input points). I realize you might also call this predictive uncertainty (i.e. used for predictions).

That, unfortunately you need to implement on your own. Happy to help if you have further questions!

Got you, thanks! Closing this issue.


Image import issue when build for production

I import and use image like this in code:
import FF1_A from '../../public/images/FF1_A.png'
<Image src={FF1_A} alt="Example A" key={1} />

It works fine for next dev or next build on my local macOS.
But on a Linux server, it is giving me this error:
> next build && next start

info  - Loaded env from /var/www/html/.env.local
info  - Checking validity of types
info  - Creating an optimized production build
Failed to compile.

./components/Modals/FF1NavModal.tsx
Module not found: Can't resolve '../../public/images/FF1_A.png' in '/var/www/html/components/Modals'

What could possibly cause this?

It is case sensitivity.


API for reactive commands can be improved

I file it as issue to discuss some proposal. We created (for inhouse use;)) helper class ReactiveCommandEx, with following methods:
public static ReactiveCommand<Unit> CreateAlwaysAvailable(Action action);
public static ReactiveCommand<Unit> CreateAlwaysAvailableAsyncTask(Func<object, Task> action)
public static ReactiveCommand<Unit> CreateAlwaysAvailableAsyncTask(Func<Task> action)
public static ReactiveCommand<Unit> CreateAsyncTask(IObservable<bool> canExecute, Func<Task> action)

public static ReactiveCommand<Unit> CreateAsyncTask(IObservable<bool> canExecute, Func<object, Task> action)
public static ReactiveCommand<Unit> Create(IObservable<bool> canExecuteObservable, Action<object> action)
public static ReactiveCommand<Unit> Create(IObservable<bool> canExecuteObservable, Action action)

Which are simply wrappers for ReactiveCommand methods, ensuring that:

ReactiveCommand<Unit> is consistently used as return type,
When command is always available client code is shorter (no Observable.Return(true) everywhere :)).
When Func<Task> throws exception instead of returning faulted task it is properly converted to observable and is pushed to ThrownExceptions.

Is it worth integrating such functionality into ReactiveUI? If so I will create PR.

Could you give an example of before and after code?

@mteper Does are mostly additions wrapping existing functionality, which code (client or library) you would like to see?

@kwesolowski just trying to understand the problem you are solving as it's not ringing a bell. So curious what your app code looks like without the helpers and then with.

AD1: It is just minor annoyance - ReactiveCommand.Create creates ReactiveCommand<object> so if you change implementation to CreateAsyncTask you have to change type. Guidelines state that VM state should be used anyway (not object passed by command)).
AD2. it simply allows to replace:
ReactiveCommand.CreateAsyncTask(Observable.Return(true), _ => actionAsync()); with:
ReactiveCommandEx.CreateAlwaysAvailableAsyncTask(_ => actionAsync()); (with code completion this is faster to type:)).
AD3. ReactiveCommand.CreateAsyncTask(IObservable<bool> canExecute, Func<object, Task> executeAsync, IScheduler scheduler = null) uses executeAsync(x).ToObservable() to convert task to observable and use observable implementation.
Then passed  Func<object, IObservable<T> is called within
class ReactiveCommand<T>  {
...
ExecuteAsync(...
{
 Observable.Create<T>(...
HERE
}

Where it will throw immediately if executeAsync(x) throws immediately instead of returning task in faulted state, causing exception to be not reported on ThrownExceptions. I can check it against latest nuget and file separate issue/PR.
And generally add conveniance method, because currently you cannot:
4a. Create synchronous version of command:
ReactiveCommand.Create(Observable.Return(true), _ => doSth()) (you can subscribe to result of Create but then errors are not present in ThrownExceptions
4b. Create synchronous version of command not taking any argument:
ReactiveCommand.Create(Observable.Return(true), () => doSth()) which allows shorter
ReactiveCommand.Create(Observable.Return(true), doSth)
4c. Create async task from async function not taking any argument (again requires ignoring it and writing lambda instead of using existing async method).
And for all three above extra overload for AlwaysAvailable.

@kwesolowski Thanks, that helps!
AD1: Perhaps @paulcbetts can speak to reason for inconsistency. Note, however, that the generic type is for the return value not input parameter.
AD2: I am pretty sure there is already an overload that lets you omit the enabledWhen observable.
AD3: if true, sounds like a good fix.
AD4: I'll again defer to @paulcbetts on design rationale

@kwesolowski
AD2 is definitely already in the ReactiveCommand static functions
AD4c could work like this perhaps (if I understand you correctly)
ReactiveCommand.CreateAsyncTask(doSthAsync);

private Task doSthAsync(object parameter)
{
    return Task.FromResult(true);
}

AD2: @patsissons Good point, i missed that - so this part is of my post is invalid.
AD4c sure it can can, but if you already have private Task doSthAsync() without parameter you have to wrap it in next lambda providing null (and if guidelines stating to ignore command parameters are still valid it would be clearer no to bother with this object at all).

#971 radically overhauls the APIs for RxCommand. It will be merged shortly and included in RxUI 7.

Further to my above comment, the only issue you raise that #971 does not address is AD3. I think you're right that exceptions thrown directly by the executeAsync (and canExecute) callbacks should be trapped and ticked through ThrownExceptions, so I'll add this as a separate issue.


readme changed to mention about callback function parameters of the search

#215

Codecov Report
Base: 96.03% // Head: 96.03% // No change to project coverage :thumbsup:

Coverage data is based on head (07ee895) compared to base (3b5aed8).
Patch has no changes to coverable lines.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@            Coverage Diff            @@
##             master     #232   +/-   ##
=========================================
  Coverage     96.03%   96.03%
  Complexity      188      188
=========================================
  Files            36       36
  Lines           630      630
=========================================
  Hits            605      605
  Misses           25       25

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Copy on select doesn't work

Check for existing issues

[X] Completed

Describe the bug / provide steps to reproduce it
text is not being automatically copied into the clipboard after selecting it
Environment
cat .config/zed/settings.json

// Zed settings
//
// For information on how to configure Zed, see the Zed
// documentation: https://zed.dev/docs/configuring-zed
//
// To see all of Zed's default settings without changing your
// custom settings, run the `open default settings` command
// from the command palette or from `Zed` application menu.
{
    "buffer_font_size": 15,
    "soft_wrap": "editor_width",
    "copy_on_select": true
}

If applicable, add mockups / screenshots to help explain present your vision of the feature
No response
If applicable, attach your ~/Library/Logs/Zed/Zed.log file to this issue.
If you only need the most recent lines, you can run the zed: open log command palette action to see the last 1000.
No response

CC @mikayla-maki

You need to specify it like this:
{
// Other settings
"terminal": {
    "copy_on_select": true
  },
}

:)

my fault, I'm sorry


chore: use tsx

Saw an opportunity to recommend using tsx in a cool project.
If you prefer the node command, you can also do node -r tsx/cjs.
(Sorry for the unsolicited PR—feel free to close as well.)

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

hell, why not, I like tsx. landing. thank you!


[INLONG-314] Support consumpe data in the specified offset interval

Recently, we wanted to introduce TubeMQ into Kylin, but we found that TubeMQ could not meet the usage scenarios of Kylin. Therefore, we hope that TubeMQ provides the following functions:
1. Support to get the maximum offset of every partitions
2. consume a specify partition
3. Support consumpe data in the specified offset interval
JIRA link - [INLONG-314] created by gxcheng

Closed due to long periods of inactivity
Please reopen it if needed


update

push all change to STD

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


look into astroport pool pair types

Following up on the discussion on https://github.com/timewave-computer/covenants/pull/119#discussion_r1373022378:
Look into whether different pool pair types (stable, xyk, custom, ...) could affect this in some unexpected way.

Main questions for this are:

How do migrate pool types?
How are prices calculated for each pool type?
Is there a common abstracted interface we can use? In what ways are the interactions with the pools different?


[Feature]: Responsive preview of the application

Summary
A way to preview the application to test how it will perform on various screen sizes or devices.
Motivation
Currently, there is only one way to test this is deploy the application, and using the dev tools test the responsiveness in the deployed URL.
Additional Context
One idea on how I think responsiveness can be handled is by having a button for previewing the application at the top in the navigation bar.
And the content can be similar to the dev tools experience but with fewer details. Something like this:

In the dropdown, there can be an option to add a new device which can then accept width and height for the specific device.

Another idea would be simply to show desktop, mobile and tablet icons at top and render the canvas in that size.

@jyash97 this is a great feature once we support responsive UI. Right now our UI is fixed for desktop screens and we don't scale for smaller devices. We'll look at incorporating this when we build our mobile responsive feature

This is now solved in our edit mode. More responsive properties will be available when we enable responsive applications


multithread option but still only using one thread

Thank you for lovely tools. I am currently using polyA estimation part of nanopolish. I have tried this alone (v0.13.2) and works well, as well as part of pipelines like these:
https://github.com/biocorecrg/master_of_pores (unsure the version as is within a container)
https://github.com/nanoporetech/pipeline-polya-ng conda install with 0.13.2 version
In each case, it seems despite telling it to use more than one thread it is still only using one thread.
I manually installed nanopolish with git clone and make and I check the makefile has the enable multithread thingy.
In the case of master of pores nextflow and pipeline-polya-ng they take care of the installation but I assume its similar story.
This based only seeing one process running in top and with the following shell line:
cat /proc/$(pgrep nanopolish)/status | grep -i Threads
Sorry if I misunderstood perhaps this not necessary if the inputs are not split into separate processes.

Hi @callumparr,
There is a known issue with the conda version where multi-threading is disabled. Do you see the same behaviour in the version you manually installed from github?
Jared

When running manually installed nanopolish
❯ ./nanopolish/nanopolish polya --threads=12 --reads=pipeline-polya-ng/Workspaces/pipeline-polya-ng/input/reads.fastq --bam=pipeline-polya-ng/Workspaces/pipeline-polya-ng/alignment/aligned_reads_sorted.bam --genome=transcriptome_tutorial/Analysis/ReferenceData/Mus_musculus.GRCm38.cdna.all.fa > polyA.tsv

❯ cat /proc/$(pgrep nanopolish)/status | grep -i Threads

Threads:	12

Seems in this case it runs as expected using multiple threads. Do all steps use
To confirm
./pipeline-polya-ng/Workspaces/pipeline-polya-ng/.snakemake/conda/ffe8ea22/bin/nanopolish polya --threads=12 --reads=pipeline-polya-ng/Workspaces/pipeline-polya-ng/input/reads.fastq --bam=pipeline-polya-ng/Workspaces/pipeline-polya-ng/alignment/aligned_reads_sorted.bam --genome=transcriptome_tutorial/Analysis/ReferenceData/Mus_musculus.GRCm38.cdna.all.fa > polyA.tsv

gives this output for thread number
❯ cat /proc/$(pgrep nanopolish)/status | grep -i Threads
Threads:	1

It takes about 20hr to run through one direct RNA seq library from minION flow cell so its not the end of the world and I could just revert to using nanopolish alone without the pipeline

I'll try to look into the conda issue soon


Theme Colors

The light theme still looks like a 1st-grade art class gone wrong.
The color scheme is defined at the top of the minified CSS files here:
src/CubeServer-app/cubeserver_app/static/themes

I might suggest that a simple CSS filter might be the simplest way to achieve a nice-looking light mode. Using a browser extension that allows for playing around with that sort of thing...

I'd say the result is pretty nice.
The filter would have to be applied to the body but not to images or the webcam stream. Javascript could apply a class to the body based on which theme was selected.
The CSS might look something like this-
body.darkmode:not(img) {
    filter: ...;
}

On second thought, Bootstrap 5.3 now includes stuff for multiple color themes. We should figure out how to use that.


[#5] Release 2.1.0

Changes proposed in this Pull Request:

Includes new translation functions to work with i18N
Automated publishing scripts
Updated demo project

I assume that this is just to publish the package v2.1.0, and there would be a follow up PR to clean up the demos?

Yes. The react demo should be pretty clean I think. Angular still needs to be updated. And once this package is published, the demos will be able to use it in their dependencies. Although these changes don’t affect the demo at all, so it can be a lower priority.

I noticed that in the demo, neither Angular nor React is using open sans in Stackblitz / CSB. I am assuming this will get fixed once we a finished with all that theme stuff?


Oap + DCPMM performance benchmark and analysis

When changing disk from HDD to SSD, we saw some performance degradation in OAP +DCPMM with 9 I/O intensive queries 3TB TPC-DS.

Fixed in PR#1098. Closed.


Alpha Mask

Heres an implmintation of alpha mask (code has not been cleaned up and contains some umbraco stuff that should be refactored out etc)
It applies the alpha channel from a png to the current image
Not sure if you will find it uesful and I dont have time to do a proper git commit but I've attached the files anyway
alphamask.zip

Hi there,
Thanks for adding this. I'm wondering though, what functionality difference is there in this to the existing Mask functionality.
Cheers
James


Should metric attributes be required to be namespaced?

Summarizing reasons for not introducing this requirement:

it's not necessary since metric attributes are already namespaced (by the metric they are on)
longer attribute names make writing backend metric queries more cumbersome

Summarizing reasons for introducing this requirement:

establishes that there is a single set of attributes that can be used across traces, metrics and logs

encourages correlation between signals, which is one of OTel's core missions

metrics can be derived from logs
raw measurements can be emitted via logs

I will update these summaries based on any comments made below.

Additional cons:

Most major observability platforms don't use namespaces in metric attributes in their collectors (Prometheus, Grafana, Datadog, New Relic, for example)
Namespaces are complicated and people tend to add namespaces, even when not necessary, "just in case". Cf discussion of process.runtime.jvm.gc.name vs jvm.gc_name (the question of when to use . for a separate namespace, or _ for a qualifier of the preceding word is complicated)
Could lead to more fragmentation too, preventing easy correlation between metrics (example: we could have namespaces for different JVM implementations, and thus different attribute names, which prevent easy aggregation on jvm.hotspot.thread.name and jvm.j9.thread.name

Additional pros:

Namespaces help avoid conflict with different vendors implementations and interpretations of the standard and conventions

Thank you for tracking this, @trask!

As an FYI - TC met and I'll be putting together a proposal (on this bug) on an "Option C".
The strawman is that all attributes are required to have namespaces.  When an attribute namespace is the same as a "metric" namesapce, the attribute namespace will be dropped on the metric.
The idea here is we get the "best of both worlds" of reserved namespaces, global attribute registry, using the same "attribute bundle" for instrumentation across signals, but we also can produce metrics that look like the rest of the worlds metrics in addition to allowing tooling to understand a consistent set of rules when namespaces disappear.
I'll work on fleshing this out with concerns and details as a future comment.  Once "Option C" is fleshed out, we'll be voting on a path forward.

I'm curious if "Option C" might influence some of our metric naming choices.
For example, system.processes.count has attribute state, which would implicitly become system.processes.state.
It could be better(?) in this case to name the metric system.process.count, and then the attribute state would implicitly become system.process.state.

Having to choose for each attribute whether it should be namespaced or not will generate tons of discussions very difficult to arbitrate.
I propose an option D: Allow aliases for metric attributes.
Each attribute has a "principal" name, plus an array of aliases. When querying the metric, one could use the main name or any of the aliases.
First (naive) implementations could be to simply store each alias as a separate attribute.
Pros:

Otel metric attributes remain aligned with the rest of the world (with simple attribute names)
Allows correlation with logs and traces (with namespaced attributes).

Cons:

Significant change in metrics data format, I'm not competent enough to understand the implications of such a change.

Option C: Metrics have implicit namespaces
This proposal requires all attributes in OpenTelemetry Semantic conventions to be namespaced, and available in a global registry.  This provides many benefits, including:

Avoiding overlap between signals
Simplified code generation and tooling automation
Allowing sharing of attribute definitions between any signal in OpenTelemetry without the need for breaking changes.

Additionally, there is a desire from existing metric users for "small" or "short" attributes, as is the convention for metrics-only systems today.   For example, rather than jvm.memory.state, metrics users would prefer an attribute in their backend to be just state
Metrics Implicit Namespace
To achieve this, Metrics will implicitly create a namespace based on their name.  For example, a metric called process.cpu.utilization would implicitly have a namespace of process.cpu.  Additionally we add the following rules:

When transmitting OTLP, any attribute not already namespaces (does not contain a .) is implicitly assumed to be in the metric's namespace.
When recording metric attributes, SDKs may drop the implicit namespace from attributes if it exists, e.g. process.cpu.state => state.
When exporting metrics to Prometheus, dropping the implicit namespace is required.
Backends MAY drop implicit namespaces from metric attributes.

Expected use cases

Instrumentation authors are able to generate one set of attributes where it makes sense (e.g. extracting HTTP attributes) and using them for all signals.
Metrics users are able to get short attribute names for key attribute types.
Metric attributes that become shared with traces/logs no longer need to be namespaced, so this would no longer be a breaking change.

@jack-berg While I proposed Option C as a compromise, my own opinion aligns with yours.

To achieve this, Metrics will implicitly create a namespace based on their name. For example, a metric called process.cpu.utilization would implicitly have a namespace of process.cpu

Just if anyone wants to see, I have a draft PR to move the system metrics to YAML and before this option was proposed, it was the output I got with our current semconv tooling
https://github.com/dynatrace-oss-contrib/semantic-conventions/blob/feat/system-metrics-yaml/specification/metrics/semantic_conventions/system-metrics.md#metric-systemcputime
For ex: the system.cpu.* metrics have a state attribute. But system.memory.* and system.paging.* metrics also have that attribute.
The outcome is that the state attribute is created under those three namespaces (system.cpu.state, system.memory.state, system.paging.state)
Now a technicality I mentioned above: If we want Option C but also want the markdown rendering for the above attribute to be simply state, then I think we need changes in the tooling, because I couldn't find a way to do it. Maybe there is and I just don't know (which screams we need better docs for the semconv tool :D)

as discussed in the specification meeting, I believe this issue should be decided by the @open-telemetry/technical-committee since there are strong pros and cons to these approaches (including Option C outlined by @jsuereth), and we need a decision (one way or the other) before we can feature-freeze the JVM runtime metrics

I realize the following is not immediately actionable given the current state of OTEL. The fundamental issue we're dealing here is that OTEL's semantic convention bundle semantics with naming. Here's a contrive example of why this is bad: assume we want to capture events containing CPU measurements into an SQL table. Which table schema would you choose?
CREATE TABLE PROCESS_CPU (
  utilization INT NOT NULL,
  state       VARCHAR(50) NOT NULL,
  idle_time   INT NOT NULL
);

or
CREATE TABLE PROCESS_CPU (
  process_cpu_utilization INT NOT NULL,
  process_cpu_state       VARCHAR(50) NOT NULL,
  process_cpu_idle_time   INT NOT NULL
);

I think it's safe to say most engineers would pick the first option (the basic DRY principle; Go linter even has a similar anti-stutter rule). But then how do we distinguish if the state columns in this table and in a different table refer to the same thing or not? OTEL semantic conventions cannot help any more at this point, but the solution does exist - by capturing additional metadata about the columns in the table schema. I went into details of such approach in my talk last year https://www.shkuro.com/talks/2022-10-27-schema-first-application-telemetry/

I'm with @yurishkuro on this. I was suggesting to allow aliases for attributes names, and such aliases could be part of such attributes metadata.
In terms of implementation though, it's a bit tricky. Developers who are implementing OpenTelemetry to instrument their application and emit metrics would need to follow strictly the semantic conventions that specify such aliases.
For example, suppose the semantic conventions for system.cpu commend to include system.cpu.state AND its alias state. When emitting the system.cpu.utilization metric, the developer would need to make sure to include not just the "state" attribute, but the ["state", "system.cpu.state"] attribute.

A TC vote was requested on this, however it is not clear to me what the option "require namespace" is. What namespace? Any namespace? Is it OK to place all attributes in namespace all.? What really is the requirement? That all attributes are spread into more than one namespace? How many? Should namespaces in some way match the metric name namespace?
Are we instead perhaps trying to say that a metric attribute considered in isolation from the metric should have a meaningful name, such that the interpretation of that meaning does not require additional knowledge of a context in which it is used (i.e. the metric name)? So, state does not match this requirement (state of what?). cpu.state probably matches the requirement since we know what a CPU is and can define what a state of a CPU is.
Let's look at another example. We currently have a cpu attribute in system.cpu.time metric. What does cpu attribute describe? It is supposed to be the integer number of the cpu. Arguably, probably a clearer name would be cpu_number. Is this good enough? Seems like a namespace is superfluous in this case.
My suggested definition is of course still ambiguous. Let's look at another example: a port. We know what a port is right? It's that number that is associated with a network socket (to be clearer, we would probably want to call this port_number instead of port). So, no other context needed? No, it turns out it can be a client port or a server port. So, server.port is namespaced enough? But what if we decide we want for all http connections to record 4 port numbers: the client, the server, and the incoming port on the proxy and outgoing port on the proxy. Should we use client.src.port, proxy.dest.port, proxy.src.port, server.dest.port? What's the framework for making a decision about what namespace (how deeply nested) to use?
I find that the definition of "require namespace" rule is lacking the necessary precision to apply it. It would be great if you can come up with a proper definition (or maybe there is one that I do not see, please point me to it). Without such precise definition I don't think that option is ready for the TC to vote on.

@tigrannajaryan from my perspective the question is merely whether metric attributes are exempt from the namespacing requirements we already impose on attributes elsewhere.
Technically, the attribute naming spec is stable and is quite clear on this already. It starts with:

This section applies to Resource, Span, Log, and Metric attribute names (also known as the "attribute keys"). For brevity within this section when we use the term "name" without an adjective it is implied to mean "attribute name".

Then follows with:

Names SHOULD follow these rules:
Use namespacing to avoid name clashes.

Put simply, option A just reinforces what the spec already says. The other options aim to carve out some sort of exception for metrics. I don't think we need more precision with the attribute namespacing rule (at this moment in time) since trace and log semantic convention conversations have been able to proceed without it.

Thanks @jack-berg
That's very useful.
I think we need clarify what we consider a clash, i.e. a clash with what? It appears that another way to think about "no exception for metrics" approach is to say that we want globally unique attribute names across all signals, such that no metric attribute can be the same as a span attribute or a log attribute unless the attribute has the exact same meaning. I would expect that we make this clarification in the spec should we decide that yes, we would like metric attributes to "require a namespace".

Thank you for organizing the vote on this issue! Can we keep the discussion going on other options? @yurishkuro mentioned using metadata to convey this information. I suggested an option D, allowing aliases for attributes. But these were discarded in the discussion 😥

Can we keep the discussion going on other options?

TC votes are for decision making. The decision is made to go with "Option A: Metric attributes must have namespaces".

@bertysentry I don't think selecting Option A negates the possibility of something like an Option C or D appearing in the future.  However, the details of Option D are too open ended to consider voting.  As you saw, Option C vs. Option A was a close call, but the fundamental agreement was that from a Semantic Conventions standpoint, metric attributes will have namespaces and unified descriptions/meaning between signals.
On a metric-backend-specific case, allowing aliases for well-known metric attributes is totally fine, but outside the scope of OpenTelmetry.  Users are also welcome to shorten metric names via processors if it is their desire.

Thank you, @jsuereth, for the reply. I'm glad there is still room for discussion on improving this. IMO the required namespace in metric attributes is doomed to failure (for various reasons already detailed before). I'm concerned that too few implementations will follow these strict conventions, and that's why I truly hope enhancements will be considered, to ensure a wide adoption of these conventions. 🙏

I think the main decision here was that they are conceptually namespaced and that's how we will describe them in semantic conventions. On this basis, any transmission optimizations can still be built.


Broken demo link in README.md

The demo link in README.md points to https://jekyll-nagymaros.netlify.app/ which doesn't seem to be active.
https://piazzai.github.io/jekyll-nagymaros/ is probably the correct link
There should also be a related pull request.
(sorry for my GitHub mess up :-()

That's correct. I migrated the demo site and forgot to update the link. Merged in #4.


Increment quote crate version since version not found at 1.0.2

This PR increments the version after my cargo was unable to find version 1.0.2 of quote in the registry.
error: failed to select a version for the requirement `quote = "= 1.0.2"`
  candidate versions found which didn't match: 1.0.3, 1.0.1, 1.0.0, ...
  location searched: crates.io index
required by package `frame-support-procedural-tools v2.0.0-alpha.3 (https://github.com/hicommonwealth/substrate.git?branch=drew.up#3042e415)`
    ... which is depended on by `frame-support-procedural v2.0.0-alpha.3 (https://github.com/hicommonwealth/substrate.git?branch=drew.up#3042e415)`
    ... which is depended on by `frame-support v2.0.0-alpha.3 (https://github.com/hicommonwealth/substrate.git?branch=drew.up#3042e415)`

Superseded by https://github.com/paritytech/substrate/pull/5152


my 1st PR

Heap Sort O(nlogn)

kudos, also provide the problem statement on the top as comment and also rename with extension.


how I am accessing and changing the "interfaces"?

Thank you very much for the fast response!
can you please help me understand how I am accessing and changing the "interfaces"? Let's say I want to set the color or gridWidth. I did not understand how I do this...
Thanks.
Originally posted by @LidorCubee3D in https://github.com/gabotechs/react-stl-viewer/issues/5#issuecomment-1147613563

I do not fully understand what do you mean by "changing the interfaces".
Maybe this example can help you understand how to set the configuration for the viewer component. For the color and the gridWidth you can set the properties like this:
<StlViewer
  modelProps={{
      color: "#008675"
  }}
  floorProps={{
      gridWidth: 300
  }}
/>

Thanks. now I get it.
I have another question please. I am trying to upload "big" files (40MB and up) and the viewer do not showing anything. sometimes it gives an error in the console

Is there a limit for file-size? is there a way to fix that?
In addition, is there a way to support 3MF, OBJ files?
Thanks in advance.


Upgrade AWS SDK to v3

note to self: ensure that there are no cross-account problems with these changes. e.g. if you assume a role that is on another account that it correctly uses the right account id.

Notes for self: frisp.php could move into bin/frisp
and check the autoload of FrispEnv.php is even necessary.

Having troubles compiling into phar, lambda gives "Unhandled" errors when testing the phar. 😞


Terminal.creationOptions is empty in remote SSH window

Issue Type: Bug

Use the Remote - SSH extension to connect to a Linux PC.
In a remote window, clone https://github.com/ChaosinaCan/vscode-remote-x11
Set a breakpoint at https://github.com/ChaosinaCan/vscode-remote-x11/blob/master/extension/src/extension.ts#L110
Debug the extension. If no terminals are open when the extension activates, open the terminal panel and reload the window.
Inspect the creationOptions parameter of the terminal.

Expected behavior:
terminal.creationOptions contains information about the terminal, such as shellPath = "/bin/bash".
Actual result:
terminal.creationOptions = {
    cwd: undefined,
    env: undefined,
    name: undefined,
    shellArgs: undefined,
    shellPath: undefined,
}

I am able to get the terminal's processId and find things about it that way, as in https://github.com/ChaosinaCan/vscode-remote-x11/blob/master/extension/src/extension.ts#L116, but being able to use the new creationOptions field would greatly simplify that.


Table - remark-gfm is rendering an empty <td /> element instead of not rendering it

Subject of the issue
I have some css for my tables, and one of my users had a space after some row in the table.
In Github it renders well. However, using react-markdown it looks weird (image below). Turns out that while Github ignores this space, in remark-gfm there's an added td element which makes the UI look weird in my case...
I think it's a bug since it doesn't align with how Github is rendering the table.
Your environment

Packages: react-markdown (version 5)

Steps to reproduce
Example in codesandbox.io:
https://codesandbox.io/s/react-markdown-forked-4hj01
Expected behavior
Should render the ordered list exactly like in Github:

hello...
hi...

first cell
second cell and last

first cell
second cell and last

Notice the number of <td /> elements in the first row - it's two elements in Github, whereas in react-markdown with remark-gfm it's three.
Actual behavior
There's an excessive <td /> element which is empty.
This is the UI:

These are the HTML elements (the marked element is the redundant element):

Your codesandbox does not display the screenshot you shared here?

I cannot reproduce:
| a |
| - |
| b |SP
`

in micromark. I *can* reproduce:

| a |SP
| - |

there

I'm not sure I understand. The sandbox does reproduce this.
Maybe I got confused in the beginning but now it should appear ok.
This is the code in sandbox link:
import React from "react";
import "./styles.scss";
import ReactMarkdown from "react-markdown";
import gfm from "remark-gfm";

const markdown = `
| hello... | hi... |
| :----   | :----     |
| first cell | second cell and last |
| first cell | second cell and last |

`;

export default function App() {
  return <ReactMarkdown plugins={[gfm]} children={markdown} />;
}

Should be fixed. Your example worked fine now!

Funny question but I still see the same UI in sandbox. What should I be doing to get the updated version?

npm update

Sorry but I still don't understand. 😅
How can I see it working properly live on codesandbox? All the packages are updated to the latest version there.

@wooorm's instructions are for testing locally.

How can I see it working properly live on codesandbox? All the packages are updated to the latest version there.

That is a question for CodeSandbox support<EMAIL_ADDRESS>


Go to symbol in workspace leads to nonexisting files

VSCode Version: Code 1.10.2 (8076a19fdcab7e1fc1707952d652f0bb6c6db331, 2017-03-08T14:02:52.799Z)
OS Version: Windows_NT ia32 10.0.14393
Extensions:

Extension
Author
Version

swagger-viewer
Arjun
1.3.0

gitignore
codezombiech
0.5.0

githistory
donjayamanne
0.2.0

python
donjayamanne
0.6.0

xml
DotJoshJohnson
1.7.0

pgsql
doublefint
0.0.7

code-runner
formulahendry
0.6.14

gc-excelviewer
GrapeCity
1.1.13

beautify
HookyQR
1.0.1

plantuml
jebbs
1.3.0

MagicPython
magicstack
1.0.7

PowerShell
ms-vscode
0.10.0

vscode-json-transform
octref
0.1.2

vscode-docker
PeterJausovec
0.0.13

better-merge
pprice
0.5.1

language-plantuml
qhoekman
0.0.3

todotasks
sandy081
0.4.0

searchdocsets-vscode
silverlakesoftware
0.5.2

python-extended-snippets
tushortz
0.0.1

vim
vscodevim
0.6.5

erlang-otp
yuce
0.2.1

Steps to Reproduce:

Open a directory with files
Click Ctrl + T and look at list of found symbols - paths to files in witch these symbols are found are incorrect.

It is possible that this issue is caused by an installed extension. Can you try to run VS Code without extensions? From the command line, execute: code --disable-extensions and try your steps again to see if it reproduces. If you see it is an issue with the extension, please file it against the extension repository itself.

Without extensions it doesn't work at all.

Then please file the issue against the extension that produces the broken paths.

Why do you think so?
I have turned off all extensions and described functionality doesn't work.

Because the "Goto to symbol" functionality is provided by the Python extension.

I thought that this is the core feature.
Thank you then.


RqSocket.getRemotePort() throws exception

org.takes.HttpException: [400] header "X-Takes-RemotePort" is mandatory, not found among [host, x-takes-localport, x-takes-remoteaddress, user-agent, accept, x-takes-localaddress]
        at org.takes.rq.RqHeaders$Smart.single(RqHeaders.java:226)
        at org.takes.rq.RqSocket.getRemotePort(RqSocket.java:93)

@EugenDueck I believe, this is fixed in #1061 Thanks!

Job gh:yegor256/takes#1060 is not assigned, can't get performer