[feature] shell completion

Add completion on commands project names and tags may be useful.

Here's a bash completion script. source it or put it in /etc/bash_completion.d. This completes watson commands, command options, command names for the help command and projects and tags for the start command. It doesn't complete projects or tags for the -p and -T options of log and report yet. Another nice feature would be to complete frame ids for the remove and edit commands.
This is my first bash completion script, so maybe there are better way to do this...
# Bash completion suppoort for watson

_watson_complete () {
    local cur cmd commands projects tags

    commands='cancel config edit help log projects remove report start status stop sync tags'

    cur=${COMP_WORDS[COMP_CWORD]}
    cmd=${COMP_WORDS[1]}

    case ${COMP_CWORD} in
        1)
            COMPREPLY=($(compgen -W "$commands" -- "$cur" )) ;;
        *)
            case "${cmd}" in
                config)
                    COMPREPLY=($(compgen -W "-e --edit" -- ${cur})) ;;
                help)
                    COMPREPLY=($(compgen -W "$commands" -- "$cur" )) ;;
                log|report)
                    COMPREPLY=($(compgen -W "-f -t -p -T --from --to --project --tag" -- ${cur})) ;;
                remove)
                    COMPREPLY=($(compgen -W "-f --force" -- ${cur})) ;;
                start)
                    if [[ $COMP_CWORD -eq 2 ]]; then
                        projects="$(watson projects)"
                        COMPREPLY=($(compgen -W "$projects" -- ${cur}))
                    else
                        tags="$(watson tags | sed 's/.*/+\0/')"
                        COMPREPLY=($(compgen -W "$tags" -- ${cur}))
                    fi
                    ;;
            esac
            ;;
    esac

    return 0
}

complete -F _watson_complete watson

:+1:
BTW, did you see this: http://click.pocoo.org/5/bashcomplete/?

Ah, ok, I was wondering how that pip completion code in my ~/.bashrc works :)
Unfortunately, this is an all-nothing-solution, it seems. You can't customize it to support project and tag completion.
To implement frame ID completion, the following new watson command would be helpful (in the vein of watson projects and watson tags). I'm not sure, though, how helpful it would be to be presented with a list of opaque hex IDs when trying to find the frame to edit or remove.
@cli.command()
@click.pass_obj
def frames(watson):
    """
    Display the list of all frame IDs.

    \b
    Example:
    $ watson frames
    f1c4815
    9d1a989
    8801ec3
    [...]
    """
    for frame in watson.frames:
        click.echo(style('short_id', frame.id))

I'm not sure, though, how helpful it would be to be presented with a list of opaque hex IDs when trying to find the frame to edit or remove.

If it is not useful, then we can switch back to click's built-in completion feature, right?

No, since that doesn't give completion of projects and tags, AFAICS.

@SpotlightKid : Did you had the chance to take a look at https://github.com/click-contrib/click-completion ?

No, I haven't. I wasn't aware of that project. How does it help completing Watson specific objects like project and tags?
 :)


Using JxlDecoderSetPreferredColorProfile with JxlDecoderRewind

Hello,
I use JxlDecoderSetPreferredColorProfile in my programs.
I observed that after JxlDecoderRewind, the preferred color profile is forgotten, and the image data decoded later corresponds to the image's default color profile (like the JxlDecoderSetPreferredColorProfile call was never used).
I have to subscribe for the JXL_DEC_COLOR_ENCODING event again, because that's the only place where JxlDecoderSetPreferredColorProfile could be set again now.
Is it desired behavior?
If it is desired, please add info to documentation.
Or could be the JxlDecoderRewind call be made to remember the color profile preference?

I agree that either we properly document the current behavior (basically rewind conceptually forgets everything and is the same thing as reset, except you have to use it with the same input and it might do some things more efficiently this time because it cached some useful info), or change the current behavior to remember things like this that (and then properly document that).
I don't have a strong opinion on what is the best thing to do; keeping the current behavior is less work and maybe conceptually a bit cleaner (since it will be arbitrary where to draw the line between what it remembers and what it forgets, e.g. you could also remember image buffers etc). But it needs to be documented better in any case.

Let's change the behavior instead of just documenting what is going on right now.

change the current behavior to remember things like this that (and then properly document that).

What exactly are "things like this"?

@jonsneyers I'm not entirely sure how to implement this best.
Currently don't reset this:
  dec->thread_pool.reset();
  dec->keep_orientation = false;
  dec->render_spotcolors = true;
  dec->coalescing = true;
  dec->desired_intensity_target = 0;
  dec->orig_events_wanted = 0;
  dec->frame_references.clear();
  dec->frame_saved_as.clear();
  dec->frame_external_to_internal.clear();
  dec->frame_required.clear();
  dec->decompress_boxes = false;

which corresponds to calls to
JxlDecoderSetCoalescing
JxlDecoderSetDesiredIntensityTarget
JxlDecoderSetDecompressBoxes
JxlDecoderSetKeepOrientation
JxlDecoderSetRenderSpotcolors
JxlDecoderSkipFrames
JxlDecoderSubscribeEvents

This works now, and could just be documented. If we want JxlDecoderSetDesiredIntensityTarget to keep state across resetting the decoder, I guess we would need to keep dec->passes_state and  dec->got_all_headers, but doing this naively doesn't work, because it breaks the frame skipping (see pending pull request). Making output_encoding_info part of the JxlDecoderStruct is also not straightforward, because there are places where only the PassesDecoderState is passed.
Any thoughts?

As long as it is clear what gets reset to defaults and what doesn't, it's OK with me. It does need to be documented properly though.

Ok, going with documenting the status quo then.


Vue 1.0 support

Do you plan to release support for vue 1.0?

Hi @warksit, thanks for the interest!
I would like to inform you that I have intended to upgrade the component to support the latest version of vue. My time is limited, but I will do my best to be done as soon as possible.
Feel free to contribute if you want :)

e32362aa7fe9f52786a6b05493fa0102f10ab88b


fix spacy version to 1.10.0

since we're not supporting spacy 2.0 yet

@yayitswei this is great, thanks so much!!! 🥇


update max-results usage

Examples for --max-results showed this arg following instance command, though cloud-select --max results instance .... is what works.
Thank you!

Thanks for opening this @xorJane ! I think the right fix was to fix the bug vs. having the user count starting from 0. Thank you for the suggestion, and acting so quickly with a pr.

Sorry about that! I glanced quickly and thought you were changing the index of the example for the one off error - totally my fault / lack of reading closely enough. This is definitely a fix we need!


Accept all minor versions of React 16

Accept React versions for 16.X.X, not only 16.0.X
Documentation reference:
https://docs.npmjs.com/getting-started/semantic-versioning

Improvement over https://github.com/CognizantStudio/react-loader/pull/66

Thanks!

May we have a patch version bump?

Yes, i'll get this bumped tomorrow, thank you

Done

Oh! I just saw I changed the 'react-dom' dependecy but forgot 'react' itself arggg. Could you change it please?

You're thinking ^16.0.0 for react too?

Yep, I forgot it.

Done

Superb! Thank you very much


Any guide help migrate from appengine-api-1.0-sdk

PLEASE READ: If you have a support contract with Google, please create an issue in the support console instead of filing on GitHub. This will ensure a timely response.
as:
https://cloud.google.com/appengine/docs/standard/java11/java-differences
Java 11 runtime, the App Engine standard environment no longer includes bundled App Engine services such as Memcache and Task Queues. Instead, Google Cloud provides standalone products that are equivalent to most of the services that were previously bundled with the Java 8 runtime
i am using
datastore
memcache
cloud task (queue)
for example:
cannot resolve
com.google.appengine.api.datastore.Text
com.google.appengine.api.memcache.MemcacheService
com.google.appengine.api.urlfetch.HTTPHeader
thanks

For datastore, please look at google-cloud-datastore.
For memcache, please look at google-cloud-memcache. This client is used for managing memcache instances.
For cloud tasks, pleaase look at google-cloud-tasks.

thanks, but why
the docs comparing has big difference between appengine and gcloud?
for example, datastore doc:
https://cloud.google.com/appengine/docs/standard/java/datastore
has 1x pages
https://github.com/googleapis/java-datastore
only 1 page

The Github repo https://github.com/googleapis/java-datastore contains info on the specific client library rather than AppEngine as a whole. https://cloud.google.com/appengine/docs/standard/java/datastore shows a bunch of examples along with sample code and is cross-referenced with other things. Hope this helps!


declarative pipeline: lock is engaged, even if stage's when condition does not apply

I have defined a number of stages, contained in a parent stage, which also has a Lock defined in its options block.
In cases where the when condition does not apply, the lock is still engaged, causing the pipeline to wait for the lock to become available.
Showcase:
    stage('some stages') {
        when {
            expression {
                someCondition()
            }
        }
        stages {
            stage('stage1') {
            }
            stage('stage2') {
            }
        }
        options {
            lock(label: 'DEV', quantity: 1, variable: 'locked_env')
        }
    }

expected behaviour: The Lock is only requested if the stage's when condition evaluates to true

options are invoked before when. This is intentional.

Ok. Is it then possible to pass the conditional to the lock option?

That's why even though I'd like to switch to declarative pipelines I have to stick with scripted pipelines. I hope they do implement some better logic to wait for the lock before assigning expensive resources to the build (using an executor).

I can understand why there would be technical reasons to invoke the options block before the when, for instance when the when condition needs some preparation. However it is indeed non-intuitive in this case.
Adding functionality to let the items in the option block declare themselves if they can be invoked ' early' or 'late' would be very welcome!

@accumulator Could you open a JIRA on issues.jenkins.io in the pipeline-model-definition-plugin component for adding a beforeOptions flag for when, like the existing beforeAgent flag? Thanks!

https://issues.jenkins-ci.org/browse/JENKINS-51865 contains a workaround (haven't tried it myself, yet).
@accumulator Did you create a ticket for beforeOptions?

Seems this would block my solution/workaround proposal for #134 :\
However, from the OP's example in that issue, I see that in at least scripted context the lock step can be used with a closure.
I did not try, but maybe that can be used in this case as well - have it used as a container of stages, parallels, steps etc. based on the needs and intention of a pipeline job developer? e.g.
    stage('some stages') {
        when {
            expression {
                someCondition()
            }
        }
        lock(label: 'DEV', quantity: 1, variable: 'locked_env') {
            stages {
               stage('stage1') {
                }
               stage('stage2') {
                }
            }
        }
    }

or
stage {
   steps {
      lock (...) {
         sh "make check"
      }
   }
}

and so on?

I'm going to close this, since there is currently nothing I could do in the lockable-resources plugin which would change this behaviour. As @abayer said, this needs to be fixed in pipeline-model-definition-plugin. Feel free to reopen if the situation changes.

FYI: Yesterday I created a PR against https://github.com/jenkinsci/pipeline-model-definition-plugin which introduces beforeOptions within when: https://github.com/jenkinsci/pipeline-model-definition-plugin/pull/356

FYI: Note: JENKINS-51865 is done, new beforeOptions in when is available in pipeline-model-definition 1.4.0.


Revision of CommandLine

The command line has been developed for individual components (cmine, norma, ami) rather than a complete commandline for chaining these together. We have shown that they can be chained in org.xmlcml.ami2.plugins.CommandProcessor. However the syntax was ad hoc, used horrible punctuation, interacted with the shell, was different from the normal style, etc.
word(frequencies)xpath:@count>20~w.stopwords:pmcstop.txt_stopwords.txt
sequence(dnaprimer)
...

I put my hand up and ask for forgiveness. (Even I can't remember the syntax).
This is a proposal to deprecate it (it's only 1 month old) and replace by something less complex and more consistent.
##PROPOSAL
Each module (including ami submodules) has a reserved command starting with _, i.e.:
_cmine
_norma
_gene
_identifier
_phylo
_regex
_search
_sequence
_species
_word

These can be chained (the newlines are just for prettiness) as:
_norma --xsl nlm2html
_search disease
_search inn
_sequence dna
_word frequencies
_species binomial
_species genus

The structure here is
_plugin option

This will give rise to a single results.xml as
/cproject/ctree/plugin/option/results.xml

note that the duplicated operations (here _search and _species) are independent and in parallel.
The normal arguments in args.xml can then be appended:
_identifier rrid --id.regex myregex.xml
_phylo --ph.newick myfile.nwk --ph.nexml myfile2.nexml

Note that the option is optional for some modules.
Generally this will make commandlines simpler.

I definitely think that sorting out the possible command line options is a great idea!
I have a few thoughts of my own to add to this:
I'm concerned about focussing too much on unification of norma and ami into a single tool. This might sound totally anti to previous comments I have made about simplicity and ease of running but I don't think it is entirely the case. I fear this may be a step backwards (basically making a utility just like ami was before norma was factored out of it). We want to keep code common to norma and ami together (e.g. handling CTrees) but we don't want ami to depend on norma (this code should be migrated to cmine) and we certainly don't want to make cmine (this repo) depend on either of the two and start some circular dependency situation.
However I do think a simple 'frontend tool' that calls both ami and norma could be great! I think we should still provide norma and ami as standalone command line utilities that do their own thing but this doesn't stop us having a third tool (name TBD) that calls both as and when needed. This may be precisely what you were suggesting but I wasn't clear. Perhaps is should even be called cmine (hence why the issue is in this repo?).
This new tool should depend on both ami and norma (obviously) but could also even depend on quickscrape and getpapers etc... A sort of one-stop shop for textmining. This should also be the place in which we do post-mining analysis IMHO (making the html tables and so on).
In terms of the structure for what the command line arguments should look like I haven't yet got a solid opinion. The current situation with (e.g.) ami2-gene --g.gene --g.type.. could also be improved. Currently, for example, --g.gene seems superflous because it is already specified by the name of the command line script. --g.type seems less than intuitive to me because of the g. prefix.
ami2-gene --type typename --project projectname should be all that is needed. The fact that the typename given is a type of gene should be inferred because we are calling ami2-gene. However this doesn't fit well with an extensible plugin architecture because we would need to make a new ami2-plugin for every plugin written.
This obviously changes if we want to run multiple plugins at a single go because we need to know which option goes with which plugin. I'm not sure how best to approach this; perhaps commandname --plugin foo bar baz --baz-thingtovary 2 --foo-differentthing 0 --bar-dump /var/log/bazdump.log
I think this is more intuitive for a command line user than using a '_' as a special character. We also don't need to do any special reservation of commands then. We just look through all plugins in the class path (or perhaps even an external resource (e.g. to keep chemtagger in a seperate jar)) and see if any match those given. If so we load them and pass them all --pluginname-x y. They can then decide what to do with the options.
If desired we could have a --norma-transform transformname, --html-table or even a --getpapers-query zika in this 'super tool'
In any case I think in addition to having a supertool we should look at the state of the command line options in the standard norma and ami binaries for people who want to use them in a standalone fashion.

Immediate comments:

This new syntax is indeed an overlay and norma retains its independence. as do each ami plugin.
it must be OS and shell independent. We can't assume the tools will be java.
we can't rely on subsidiary files, context, etc. Parsing must be automatic and problem/installation independent.

At present we have a list of formally independent commands:
norma xsl -x myfile.xsl
word frequencies --w.stopwords pmcstop.txt stopwords.txt --minfreq 20
sequence dnaprimer
search tropicalVirus --dictionary org/xmlcml/ami2/plugins/dictionary/tropicalVirus.xml
species binomial
gene human
summary datatables
summary frequencies

The general form is therefore
command option [argument, argument...]

The separation must be syntactic. Else how do we tell that species is not another argument of --dictionary
There are the following options:

separation character. It must not interact with the shell. The options are limited to ,.-_ (checked with SO).
newline (very fragile and horrible in commandlines)
case sensitivity

NORMA nlm2html SPECIES binomial

This is also fragile.
I am aware that this will develop into a full language, but at present we can contain it.
My current preference is for one/some/all of
NL
\n
_

as isolated character strings.
I agree we drop the _species and replace by _ species. This is trivial at present.

Have changed petermr version to use - as command separator (not prefix).   I suggest waiting to see if what I produce meets the need. There's no real reason to make a wrapper for the command-line when almost everyone will want to use a GUI.
I also think having a new (obscure) way of writing command-line instructions will decrease, rather than increase, usability.

How will the cross platform app work? Will it just call the local binaries?

In terms of needing a command separator I think we can avoid it. All we need to do is ensure (probably to be done when we look through how ami processes commands as well) is that the plugins don't take 'free form' text separated by spaces.
To alter your command line as an example:
cmine --norma-transform xsl --norma-stylesheet myfile.xsl --plugin word --word-type frequencies --word-stopwords pmcstop.txt,stopwords.txt --word-minfreq 20 --plugin sequence --sequence-type dnaprimer --summary datatables
This makes the pairs of objects --option-name optionvalue free to change order. I think this form of --option [value if required] is much more standard. It also means we could use a standard argument processor rather than having to implement our own.

@tarrow it will be an electron app (which is already cross-platform) with a plugin system. Each plugin will be a node package that wraps some tool in a consistent API, and automatically gets the right precompiled binaries.

Thanks,
I am all for using standard tools where possible.
Some immediate points.

There is no intention of merging normal and ami
we need something that can be run on a server in Cambridge as well as a
gui. This is fairly pressing.

... have to go now...
On Wed, Apr 6, 2016 at 10:08 AM, Richard Smith-Unna <
<EMAIL_ADDRESS>wrote:

@tarrow https://github.com/tarrow it will be an electron app
http://electron.atom.io (which is already cross-platform) with a plugin
system. Each plugin will be a node package that wraps some tool in a
consistent API, and automatically gets the right precompiled binaries.
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/ContentMine/cmine/issues/3#issuecomment-206241816

--
Peter Murray-Rust
Reader in Molecular Informatics
Unilever Centre, Dep. Of Chemistry
University of Cambridge
CB2 1EW, UK
+44-1223-763069

The existing tools can be run on a server in Cambridge, no?

Sure,
but the commandline interface was poor which is why I have been hacking it.
It's certainly possible to string everything together without separators.
It's a question of what is simplest and most robust. If all the options are
used it can be a string of 50 arguments.
On Wed, Apr 6, 2016 at 10:58 AM, Richard Smith-Unna <
<EMAIL_ADDRESS>wrote:

The existing tools can be run on a server in Cambridge, no?
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/ContentMine/cmine/issues/3#issuecomment-206274124

--
Peter Murray-Rust
Reader in Molecular Informatics
Unilever Centre, Dep. Of Chemistry
University of Cambridge
CB2 1EW, UK
+44-1223-763069

well I agree that is not ideal - how about only accepting one plugin via commandline arguments, and if the user wants to run multiple plugins they provide a (YAML?) file containing the plugins and their parameters

I think it's possible to do it by concatenated arguments.
My current architecture is:
cmine [general arguments]
  command option [command arguments]
  command option [command arguments]
  command option [command arguments]

the option used to be called `--type` and we can revert to that. It's not
essential for all comands. However it organizes the output very nicely.

More later...

On Wed, Apr 6, 2016 at 2:29 PM, Richard Smith-Unna<EMAIL_ADDRESS>> wrote:

> well I agree that is not ideal - how about only accepting one plugin via
> commandline arguments, and if the user wants to run multiple plugins they
> provide a (YAML?) file containing the plugins and their parameters
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly or view it on GitHub
> <https://github.com/ContentMine/cmine/issues/3#issuecomment-206373058>
>

--
Peter Murray-Rust
Reader in Molecular Informatics
Unilever Centre, Dep. Of Chemistry
University of Cambridge
CB2 1EW, UK
+44-1223-763069

I have continued to refactor cmine, norma and ami. It should now be able to develop a commandline syntax we are all happy with.
I have developed CMineParser and CMineCommand as a separation of the functions of ArgProcessor. The parser builds a model of the commands in CMineCommand which can then be edited.
I can create a simple-to-parse syntax, with some agreed conventions.
cmine [args] -c command1 [args1] -c command2 [args2] ...

this is easy to parse and reasonably easy to implement as
cmine [general arguments]
  command1 [option1Arg] [command1arguments]
  command2 [option2Arg] [command2arguments]

Many arguments are inherited from cmine while others are command-specific


#SHA-22 Resolve-eslint-hooks-deps

https://linear.app/shadcn-extension/issue/SHA-22/fix-eslint-react-hook-dependency-array-warnings
🚨 NOTE: Make sure you merge the Migration to contentLayer2 first before merging this branch. 🚨

Closed in favor of this PR


[WFCORE-3579] The embed-host-controller command should check for boot…

… completion even in the empty config case.
Checking the host-state is not necessary any more as WFCORE-3579 means the read of the local host name will be rejected until the HC is booted.
https://issues.jboss.org/browse/WFCORE-3579
See also the comments on https://issues.jboss.org/browse/WFCORE-3655
@luck3y @jmesnil FYI / approval.

Closing; it produced hangs in TS. Too late in the 4.x cycle for something that does that.


No way to toggle mods with "alt/" prefix as created by retro

[X] I have checked the known issues and searched Github to ensure this issue has not already been reported.
[X] This is not a feature request, I know those belong on Discord/Github Discussions.

Description of the bug:
On PC 2s2h uses the tab key to toggle mods that use the "/alt" prefix (created with retro). It seems like there's currently no way to toggle such mods on android as no controller button can be mapped to that function and it's also not in the menu.
Simply adding a mod that works on pc in this way to the Android 2s2h mods folder does not activate it automatically, so these mods can currently not be used at all.

This seems to be fixed in the current version (1.1.1) of the app. There's a touchscreen menu with a checkbox for using the alternate assets.


feature: support jsr-303 jakarta namespace

What is the purpose of the change
Java EE has been renamed from javax to jakarta, Related jar packages no longer use the package name starting with javax, including the jsr-303 api. To support Hibernate Validator 7.x, a new JValidatorNew file has been added for compatibility with version 7.x
close #9544
Brief changelog

Add JValidatorNew, use new api.
ValidationFilter masks implementation class exceptions

Verifying this change
I can't write new unit tests because Hibernate Validator 7.x and 6.x can't exist under the classpath at the same time and there would be a class conflict. But I have tested 7.x separately in my development environment and it works fine, so I hope someone else can test it again to make sure it works!

Checklist

[x] Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[ ] Each commit in the pull request should have a meaningful subject line and body.
[ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[ ] Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
[ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
[ ] Add some description to dubbo-website project if you are requesting to add a feature.
[ ] GitHub Actions works fine on your own branch.
[ ] If this contribution is large, please follow the Software Donation Guide.

doc pr https://github.com/apache/dubbo-website/pull/1039


update cmd/zfs to import logrusx from cerana org

Issues affected/resolved
fixes #174

This change is

Previously, mmlb (Manuel Mendez) wrote…
> #### update cmd/zfs to import logrusx from cerana org
>
> ## Issues affected/resolved
>
> fixes #174
>
>
>

Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable


fix display of parentheses for right-to-left languages

This is a followup to https://github.com/electron/electronjs.org/pull/1254
A few things are still quirky on RTL pages, like parentheses. Here's an example from the Arabic /releases page:

Possible ways to solve this:

https://stackoverflow.com/questions/5741522/brackets-displays-wrongly-for-right-to-left-display-style
 tag
http://rtlcss.com
https://www.npmjs.com/package/flipcss

Recommendation: add dir="auto" to surrounding section elements, like <section class="page-section" dir="auto">. I think the browser should automatically detect the language of the content of an element with dir="auto" based on the characters used, then select an appropriate direction on a per-section basis. Sections that are still in English will be left-to-right, and fully translated sections in Arabic would be right-to-left.
Bidirectional text in HTML: https://www.w3.org/International/articles/inline-bidi-markup/index
Bidirectional text in Unicode: https://www.w3.org/International/articles/inline-bidi-markup/uba-basics
I'll try this out and let y'all know how I go.

Sounds good, @snidelyhazel! Feel free to open a WIP PR whenever.

@snidelyhazel thanks again for digging into this. Can you open a pull request that makes some of these exploratory changes? That will make it easy for folks to preview the effects of the change.


switch implemented in mobile

calling this checkbox since we have flow for  it already and the api is identical, also takes in a label too since we'll basically always do this
@keybase/react-hackers

@keybase/react-hackers bump

:+1:
just with a question, but you can merge


corvina, burga

This pull request was generated by the 'mq' tool
[test]
flake rate: 0.1
logical conflict every: 1000
sleep for: 600s
close stale after: 24 hours
[pullrequest]
requests per hour: 20
deps=[b,c]

/trunk merge


az dls fs * commands fail with 'ConnectionError'

This is autogenerated. Please review and update as needed.
I've deployed and ADLSgen2 store and now I would like to create file systems inside.
Storage creation command:
az storage account create -n [name]-g [resource-group] --sku Standard_LRS --kind StorageV2 --hierarchical-namespace true

Note that the location is westeurope for this storage account.
Works fine - now trying to run az dls fs commands like:
az dls fs create --account [accountname] --path /test
az dls fs show --account [accountname] --path /

Gives the following error message:
HTTP error: ConnectionError(MaxRetryError("HTTPSConnectionPool(host='[storagename].azuredatalakestore.net', port=443): Max retries exceeded with url: /webhdfs/v1/test123?OP=GETFILESTATUS&api-version=2018-09-01 (Caused by NewConnectionError('<urllib3.connection.VerifiedHTTPSConnection object at 0x05C0BFD0>: Failed to establish a new connection: [Errno 11001] getaddrinfo failed',))",),)
Traceback (most recent call last):
  File "C:\Users\VSSADM~1\AppData\Local\Temp\pip-install-rtk110ve\knack\knack\cli.py", line 206, in invoke
  File "C:\Users\VSSADM~1\AppData\Local\Temp\pip-install-rtk110ve\azure-cli-core\azure\cli\core\commands\__init__.py", line 603, in execute
  File "C:\Users\VSSADM~1\AppData\Local\Temp\pip-install-rtk110ve\azure-cli-core\azure\cli\core\commands\__init__.py", line 661, in _run_jobs_serially
  File "C:\Users\VSSADM~1\AppData\Local\Temp\pip-install-rtk110ve\azure-cli-core\azure\cli\core\commands\__init__.py", line 654, in _run_job
  File "C:\Users\VSSADM~1\AppData\Local\Temp\pip-install-rtk110ve\six\six.py", line 693, in reraise
  File "C:\Users\VSSADM~1\AppData\Local\Temp\pip-install-rtk110ve\azure-cli-core\azure\cli\core\commands\__init__.py", line 631, in _run_job
  File "C:\Users\VSSADM~1\AppData\Local\Temp\pip-install-rtk110ve\azure-cli-core\azure\cli\core\commands\__init__.py", line 305, in __call__
  File "C:\Users\VSSADM~1\AppData\Local\Temp\pip-install-rtk110ve\azure-cli-core\azure\cli\core\__init__.py", line 485, in default_command_handler
  File "C:\Users\VSSADM~1\AppData\Local\Temp\pip-install-rtk110ve\azure-cli\azure\cli\command_modules\dls\custom.py", line 143, in create_adls_item
  File "C:\Users\VSSADM~1\AppData\Local\Temp\pip-install-rtk110ve\azure-datalake-store\azure\datalake\store\core.py", line 601, in exists
  File "C:\Users\VSSADM~1\AppData\Local\Temp\pip-install-rtk110ve\azure-datalake-store\azure\datalake\store\core.py", line 204, in info
  File "C:\Users\VSSADM~1\AppData\Local\Temp\pip-install-rtk110ve\azure-datalake-store\azure\datalake\store\lib.py", line 432, in call
azure.datalake.store.exceptions.DatalakeRESTException: HTTP error: ConnectionError(MaxRetryError("HTTPSConnectionPool(host='[storagename].azuredatalakestore.net', port=443): Max retries exceeded with url: /webhdfs/v1/test123?OP=GETFILESTATUS&api-version=2018-09-01 (Caused by NewConnectionError('<urllib3.connection.VerifiedHTTPSConnection object at 0x05C0BFD0>: Failed to establish a new connection: [Errno 11001] getaddrinfo failed',))",),)

Is there a somewhere or am I doing something wrong?
Describe the bug
Command Name
az dls fs list
Errors:
az dls fs list: error: the following arguments are required: --path

To Reproduce:
Steps to reproduce the behavior. Note that argument values have been redacted, as they may contain sensitive information.

Put any pre-requisite steps here...
az dls fs list

Expected Behavior
Environment Summary
Windows-10-10.0.18362-SP0
Python 3.6.6
Shell: cmd.exe

azure-cli 2.0.70

Extensions:
interactive 0.4.3
storage-preview 0.2.8

Additional Context

Commands shouldn't throw stack traces, at worst we should have logic to cleanly handle this error

@adewaleo - As suggested, I tried to use the above command and "create file system command combinations as under

az dls fs create --account "abcxyz123" --path "/test1"
az dls fs create --account "abcxyz123" --folder --path "/test1"
az dls fs create --account "abcxyz123" --folder --path "/"
az dls fs create --account "abcxyz123"  --path "/"
" in storage account created in West US 2 and West Central US but it fails with exactly same error as above. Hope this helps to troubleshoot.

So this issue is not in specific region.

@HarshGandhiNL I am not sure if you are responding to my comment or someone else's. I left my previous comment to guide whoever will eventually fix the issue. I was acknowledging that this is a bug because a stack trace was thrown.
Hopefully an owner of DLS or member from the CLI team, would be able to help address your issue. I am no longer a member of the CLI team.

I think this is trying to access gen2 account using gen1 commands?
This is not supported so will not work.

Is there anywhere to keep updated about when gen2 will be supported by CLI? Judging by the DNS suffix in the error description, it's almost certainly accessing gen1 stores, but is there any alternative? The standard blob api (az storage blob *) give an error (with stack trace, again):
Blob API is not yet supported for hierarchical namespace accounts. ErrorCode: BlobApiNotYetSupportedForHierarchicalNamespaceAccounts

@lisardggY Sorry wasn't clear. The first line
az storage account create -n [name]-g [resource-group] --sku Standard_LRS --kind StorageV2 --hierarchical-namespace true
reads on creating a storagev2 account and then trying to access it as adls gen1 storage account, which will not work.

Please close this if there aren't any other asks. This seems to be a user error i.e. trying to use adls gen1 commands for adls gen2 account.


[Tracking, Green Reviews WG] Design Green Reviews WG pipeline workflow

Description

Following from the proposal "Proof of Environmental Sustainability activities and best practices for CNCF projects", the Green Reviews WG is setting up infrastructure to measure the sustainability footprint of CNCF projects. This issue tracks the design & implementation of this technical work.
Please add your suggestions / comments / questions to the Design Doc here! 🌱
Milestones

Create a document to start outlining the sections above.
Discuss the progress during Green Reviews WG meetings.
Identify the starting point (or multiple points in parallel) that can be worked on.
Break down work into actionable items that folks can take on.

Epic

[ ] https://github.com/cncf-tags/green-reviews-tooling/issues/1

Co-Authored By: Kristina D @guidemetothemoon

I have few comments/questions:
Here it is the google doc tracking the implementation details and related discussion:
https://docs.google.com/document/d/19fzZW-IMv2kDNatKFHeHh7wqcEN0e2N60wzxvCGZd48/edit?usp=sharing
Could you please clarify what we would need k6 for? I am not an expert and it is not so clear to me :)
I would maybe need add a step which I think it would be to install the project we would like to test.
e.g. In the test server we would need to install the target project (Falco for the moment)
Does Prometheus handle the remote write? Where can I read some doc on how?
Can't wait to start!

I have seen some steps to trigger GH actions between different repos. Is it a valid approach?

This is the way to go, yes. The workflow to build and deploy the CNCF project should trigger the GH Action workflow in the green-reviews-tooling repo.
To achieve this, we need to add a workflow_dispatch in the CNCF project build pipeline (assuming they use GH Action). Then, we need to add a a repository_dispatch in the tooling repo. This will be the trigger for the load tests.

Could you please clarify what we would need k6 for?

These should be benchmark tests that perform an action against the CNCF Project. To use an example more familiar to me, in the example of a GitOps benchmark test, we create and deploy an application which Flux/ArgoCD then reconcile in the cluster. This would be the equivalent to the SCI Functional Unit, in theory:

The functional unit defines how your application scales. For instance, if your application scales by APIs then choose API as your functional unit.

This will look different for each CNCF Project. Unsure what this looks like for Falco - it is what we are trying to figure out next :)
In this scenario, the benchmark tests run in the same Node as Kepler is running, so that we can measure the energy consumption of the Functional Unit.

Does Prometheus handle the remote write?

devstats is a Grafana dashboard so we should be able to use the Prometheus instance running on our Node as a data source. TBD :)

@nikimanoledaki, @AntonioDiTuri the Falco project tests their deployments on Equinix using this Ansible config https://github.com/falcosecurity/kernel-testing/tree/main. Perhaps this could be a good starting point for us? We could copy the resources, deploying the setup (for testing purposes, -> running the Falco tests) then reducing the deployment (remove all settings we do not need) and adding new configuration (to enable assessing the SCI score, measuring energy etc.). We likely need to build a small project (in Go or so) next to the Ansible config to make some calculations.
cc @incertum

@leonardpahlke, our Falco core maintainers meeting is on October 5th. Will check with the other maintainers (@FedeDP, @Andreagit97) to see how we can generalize the Ansible setup so that it can be used for more future projects beyond Falco. Voting in favor of creating a Go project that we can all contribute to. This may come in handy for future setup configurations and other aspects.

I see that this ticket is referenced: https://www.bbb.org/us/il/aurora/profile/window-installation/green-t-windows-0654-88593900
Does this mean that we plan to run Kubernetes on a bare-metal Equinox cluster, without a hypervisor like EKS?
Do we plan to deploy each project directly on the hosts, or in the Falco case as a daemonset?

Alternatives such as Firecracker microVMs are being considered to work with Falco's setup: https://github.com/cncf-tags/green-reviews-tooling/issues/1#issue-1926319038)

Please note that the Firecracker VM setup you are referencing is used to test different kernel versions. For the Green Reviews WG efforts, one kernel version is sufficient, and we would like to deploy Falco realistically, as the goal here is currently slightly different: we want to test performance.

@incertum that is correct, Equinis is our infrastructure so we will be running on a BM cluster without a hypervisor. We are currently evaluating the pros/cons of different tooling and cluster setups. We have not decided on any yet. We're looking into CAPI for GitOps but we're still evaluating how

Do we plan to deploy each project directly on the hosts, or in the Falco case as a daemonset?

This is a great question - we are still in the process of designing the E2E flow. We need to think about how we will scale when we test each project separately, with an emphasis on isolation so that we can run the tests for each project in an isolated way. This could be done with CAPI by running a new worker cluster for each test. However this could be too much overhead. We could also achieve this degree of isolation within a single cluster if we run each CNCF Project and its test on a dedicated Node if we do a combination of Namespace + Node taint/isolation for each project that we test. So Falco would run as a Daemonset but the Pod would only run on 1 Node. Please let me know what you think about this idea.
In order to make a decision about the above it would also help us first to decide what and how we will run the tests for each CNCF Project. With regard to what we test, I agree with @leonardpahlke's idea that we could reuse the existing Falco test steps with some changes to fit our use case.
With regard to how we run these tests, we should discuss whether we will use the Project's existing test tooling or a unified test tooling. For example, we could use the tooling that each CNCF Project uses, such as Ansible in the case of Falco. Alternatively, we would use a unified testing tooling such as k6, which has been brought up before but we are not sure yet that k6 is the right tool for testing Falco. Before we move forward, it would be good to establish whether k6 is a good tool to use to test Falco. @incertum, do you think it would be possible to collaborate with you and the other Falco maintainers to do a spike on this?
@immavalls works with k6 and brought up the following, here:

Will this be using https://github.com/marketplace/actions/k6-load-test? or is the plan to run the tests in a k8s cluster using https://github.com/grafana/k6-operator? I can help figure this part out with more information

we would like to deploy Falco realistically, as the goal here is currently slightly different: we want to test performance.

Could you expand further on what you mean with regard to deploying Falco realistically? Is there something we are missing or should look out for in your experience of how Falco is deployed?

@incertum I've been looking at https://github.com/falcosecurity/kernel-testing with @nikimanoledaki to see if we can reuse the approach you're using with GitHub Actions and Ansible.
I may well be missing something but high level AIUI the test is triggered by Falco's Prow instance which runs the Ansible playbook that connects to an Equinix machine using SSH.
Is the Equinix machine running Kubernetes and how do you manage it?
I ask because in our case we need to run the tests on a K8s node. This is so Kepler can attribute the energy consumption from the CPU socket to the Falco pods.

@rossf7
GitHub Actions + Ansible Kubernetes module could be a valid solution.
Any alternative will work for us, Ansible is not required from our side.
I'd like to clarify that our kernel testing involved spinning up VMs to test different kernels, and yes, SSH was used, along with some other setup requirements. However, for the Green Reviews WG + Falco, VMs and SSH are not necessary. I shared our setup to demonstrate how we successfully established a robust pipeline using GitHub Actions + Ansible against an Equinix machine. My intention was to illustrate that the steps of our pipeline could potentially inspire the Green Reviews workflow. Realizing maybe it complicates the discussion, apology for any confusion caused.

@incertum No worries and thank you this is very helpful!

GitHub Actions + Ansible Kubernetes module could be a valid solution.
Any alternative will work for us, Ansible is not required from our side.

We're looking into using Ansible and the Kubernetes module could be useful for our pipeline but good to know other tooling is an option.
For the cluster we can use the Equinix Ansible module but we still need to provision K8s. CAPI / CAPEM is a challenge without a management cluster. Kubeadm is also an option but it would be good to see other CNCF projects solve this.

Closing this issue since we are tracking more specific work in the WG repository: https://github.com/cncf-tags/green-reviews-tooling


Feature/retrieve advanced search definition

Checklist

[x] the [contributor license agreement][] is signed
[x] commit message follows [commit guidelines][]
[x] tests are included
[x] screenshots are included showing significant UI changes
[ ] documentation is changed or added

Description of change
This PR adds the support for retrieving Advanced search definition in Search page and passing the Wizard controls to component AdvancedSearchPanel.
In Advanced search mode, the retrieval is started when Search page is in initialising state. Once that is done, update SearchPageOptions to use the Collections configured for Advanced search.

The new tests for the Advanced Search Panel displaying logic are failing @PenghaiZhang , and seeing they're pretty critical to this I better wait until you fix to review. :wink:


MongoCursor.limit doesn't work for values > 1024

The range is unlimited when setting a limit > 1024.
Apparently that's the number of documents per chunk, and the limit doesn't work for multiple chunks.

Workaround is to use std.range.take until this is fixed.

This is still open, any idea what might be causing this?


Drop Java 5 support

The Java 5 options will be removed from future JDKs. So the upcoming 0.11 release should be the last with Java 5 support. After this we should remove the compiler flags to avoid future warnings and errors.
compile:
    [javac] Compiling 2 source files to /Users/philipp/Code/ringojs-master/build/classes
    [javac] warning: [options] source value 1.5 is obsolete and will be removed in a future release
    [javac] warning: [options] target value 1.5 is obsolete and will be removed in a future release
    [javac] warning: [options] To suppress warnings about obsolete options, use -Xlint:-options.
    [javac] 3 warnings

A lot of NIO and file related stuff has been introduced in Java 7. So dropping Java 5 would bring us only some better compiler output, but does not help us for issues like #293 to drop also the JNI POSIX layer.
My proposal would be to require Java 7 as a minimum for Ringo 0.12 as the next release. What do you think, @grob / @oberhamsi / @kmfdm1 ?

:+1:

This needs further changes in the Debian build files, where Java 5 and 6 are minimum dependencies at the moment.


setAttributedString sets color to black, instead of primary color

Steps to reproduce:

Create a RichTextEditor and set the attributed string to any string or NSAttributedString onAppear:

RichTextEditor(text: $formattedText, context: rtContext)
   .onAppear {
       rtContext.setAttributedString(to: NSAttributedString(string: note.content))
   }

The RichTextEditor will display the string in black, even when in Dark Mode

Expected Behavior
When adding a string, the color should be set to the primary color, which is dependent on the current view mode (dark mode or light mode). When writing in an empty RichTextEditor, this behaves correctly (white text for dark mode, black text in light mode).

I guess you'd first have to analyze if the string contains any color information, so that intentional black or any other colors isn't converted?
Perhaps it would be better to have a separate setString that takes a raw string and applies the primary color?

I have very little understanding of how NSAttributedString works, but I don't think you'd need to check that—you could just "wrap" the new Attributed String with the proper default color, and any changes/overrides within should remain.
But a setString could also just do the trick.

Hello @henningko this is currently work in progress. This will be solved with the Configuration of the TextView and will be implemented in following weeks, I am actively working on this, but have other things from my work on my plate. I can confirm that the default attributes for the string are not correctly set by the Apple SDK.

I've been trying to figure out how to use the recently added RichTextColor to turn the text white when in dark mode figuring that was the solution...I guess I misunderstood what that was for? I initially tried manipulating attributed string but nothing seemed to work. If anyone has any ideas how to get the text to turn light while in Dark Mode I'll give you a million internet points!

Hello @MrGobert can you maybe share some code what did you actually tried to do and expected result?
To VERY simplify this, as follows:
func adjust(
        _ color: Color,
        for scheme: ColorScheme
    ) -> Color {
        switch self {
        case .background:
            if (color == .black && scheme == .dark) || (color == .white && scheme == .light) {
                return .clear
            }
            return color
        default:
            if (color == .white && scheme == .dark) || (color == .black && scheme == .light) {
                return .primary
            }
            return color
        }
    }

if the color is exact black or white, RichTextView detects this and returns for background always clear and for foreground always primary color which is system defined. The issue you might be facing is some shad of black or white is not exactly .black or .white instance, thus not reflecting the color scheme.
See the demo and tell me if anything is clear.
at last I set color to black to ensure this doesnt meddle with something...
https://github.com/danielsaidi/RichTextKit/assets/17381941/b4d5b0da-fbdf-4ee8-81db-cc8aaa49d912

Hello @MrGobert can you maybe share some code what did you actually tried to do and expected result?
To VERY simplify this, as follows:
func adjust(
        _ color: Color,
        for scheme: ColorScheme
    ) -> Color {
        switch self {
        case .background:
            if (color == .black && scheme == .dark) || (color == .white && scheme == .light) {
                return .clear
            }
            return color
        default:
            if (color == .white && scheme == .dark) || (color == .black && scheme == .light) {
                return .primary
            }
            return color
        }
    }

if the color is exact black or white, RichTextView detects this and returns for background always clear and for foreground always primary color which is system defined. The issue you might be facing is some shade of black or white is not exactly .black or .white instance, thus not reflecting the color scheme.
See the demo and tell me if anything is clear.
at last I set color to black to ensure this doesnt meddle with something...
demo.mov

Thank you! This does look super simple, and how I imagined it to work. However I'm not sure how to get access to RichTextColor or how to apply adjust method to my RIchTextEditor

@yaroslav2308 This approach works well in general, but I adjusted the color picker in particular to not do this automatically, since the user may in fact want a white background  even when in light mode. :)


C++ bindings and linux compatibility fix

c++ poser bindings are more of a bonus this time, the linux compatibility fix is more important

rebased on the latest master branch

i may have forgot to add linux support to the c++ poser bindings... ;^_^


Add the tutotial about how to use vineyard runtime to accelerate the kubeflow pipelines.

Ⅰ. Describe what this PR does
As titled.

I suggest putting the sample into the directory fluid/samples. Thanks.

I have put the common source code and YAMLs to samples/vineyard.


wrong urls on list

when I'm on http://localhost:3000/hotels I get
http://localhost:3000/create instead of http://localhost:3000/hotels/create
and it's the same with all the links.
links are correct for the url http://localhost:3000/hotels/ (trailing slash)

thank you. so,
it's not really a bug but something to take into account when designing app navigation (then it should be ok)


Documentation link results in 404

The link to the documentation in the README seems dead: http://rasbt.github.io/coral_pytorch
Is the documentation available somewhere else?
Regards,

Ah, sorry, I recently moved the project from my personal to my research group GitHub account. I forgot to update the links in certain places. The correct link is https://Raschka-research-group.github.io/coral_pytorch


Initial removal of Abdera

@reta Can you help to remove the Abdera parts from the CDI systests? It looks like if it's removed then the tests break completely.

Thanks @reta


lt, gt and others rich comparisons behave differently as for example iadd

The following looks inconsistent:
A small reproducer with cython 0.27.1:
cdef class MutableFloat:
    cdef double x
    def __cinit__(self, x):
        self.x=x
    def __iadd__(self, MutableFloat other):
        self.x=self.x+other.x
        return self
    def __lt__(self,  MutableFloat other):
        return self.x<other.x
    def __gt__(self, MutableFloat other):
        return self.x>other.x
    def __repr__(self):
        return str(self.x)

and now:
  a,b=MutableFloat(1.0), MutableFloat(2.0)
  a+=b #a=3.0, works
  a<b  #error x unknown
  a>b #error x unknown

when  we look at the cythonized functions:
static PyObject *__pyx_pf_7mutable_12MutableFloat_2__iadd__(struct __pyx_obj_7mutable_MutableFloat *__pyx_v_self, struct __pyx_obj_7mutable_MutableFloat *__pyx_v_other); /* proto */
static PyObject *__pyx_pf_7mutable_12MutableFloat_4__lt__(PyObject *__pyx_v_self, struct __pyx_obj_7mutable_MutableFloat *__pyx_v_other); /* proto */
static PyObject *__pyx_pf_7mutable_12MutableFloat_6__gt__(PyObject *__pyx_v_self, struct __pyx_obj_7mutable_MutableFloat *__pyx_v_other); /* proto */

for __iadd__  (and any other functions) self is xxx_MutableFloat but for rich comparisons PyObject *. Maybe this is how it should be, but I didn't find anything  about this  potential problem in the documentation. Anyway if this is "functioning as designed", the need to declare 'def gt(MutableFloat self, MutableFloat other):' looks strange to me.

Typing the arguments of these special methods will give you a TypeError on reversed comparisons. Try 1 < a and a < 1, for example. The semantics are documented in the standard Python docs. We should reference those, I think. A pull request to improve the Cython docs would be appreciated.

I take that back...

You are right. Python specifies their signature as self, other.


[stable/k8s-spot-termination-handler] add support for setting securityContext

What this PR does / why we need it:
Adds support for setting securityContext, allowing the locking down of privileges, etc
Some minor version cleaning, and adding myself to the maintainers, given that I originated the first version of this chart. ;)
Checklist

[x] DCO signed
[x] Chart Version bumped
[x] Variables are documented in the README.md
[x] Title of the PR starts with chart name (e.g. [stable/chart])

This is in draft status, as I need to do some more thorough testing.
Doing a helm template piped to kubectl apply -f - gives no errors.
If anyone else could try it out, that'd be great.
I'll test it in an actual k8s cluster soon!


Add error message when sending friend request to friend

What this PR does 📖

Add error message for existed friend.
Move the error message below the text field.
Fix the wrong error message mentioned in this PR #276

https://user-images.githubusercontent.com/14248245/201402402-afaf1585-fc64-42c5-9620-e2b5c6cfc9cc.mov
Which issue(s) this PR fixes 🔨

Resolve #279

Special notes for reviewers 🗒
Additional comments 🎤

Worked with trying to add myself and add someone I was already friends with, awesome job! 🔥 🎉


Bad browser performance on large text with highlighted features

Scrolling in the notebook is noticeably laggy when the text with highlighted features is in sight. Maybe it will help if we merge spans with the same weight (at least in case of word analyzers).

Yeah, I also saw performance issues, epecially in IPython notebook. Profile showed that browser was recalculating element heights or something like that. I wonder if that's specific to IPython.

mostly fixed in #115


Does not support comments in codeblock

Describe the bug
Adding a comment to codeblock results in the error shown below in screenshot.
Expected behavior
A comment should have no additional effect as expected
Screenshots
If applicable, add screenshots to help explain your problem.

Nice catch. Thank you for reporting.


feat: provide pkg entry points for import API

Despite that the cjs format is widely used in Nodejs, there are many reasons to use ESM today. Let's add the corresponding entry points.
  "exports": {
    ".": {
      "types": "./dist/index.d.ts",
      "import": "./browser/index.js",
      "node": "./dist/index.js",
      "default": "./browser/index.js"
    },

My fault, I was a bit hasty, trying to solve a couple of problems at once. Our practical cases:

We have subsystems on node.js, in which the use of the require is prohibited due to ISEC policies (to avoid manipulation of module contents).
We use esbuild for bundling, and we'd like to pick up the appropriate module versions when format set esm. As you rightly noted, the node directive has priority, so commonjs chunks appear instead.

EMS format brings a portion immutability: you cannot just override module.exports entry or require.cache as for commonjs. This makes whole module mocking a problem, but increases security.
Our case is quite exotic: we want to resolve a deps tree as esm, but to convert it to cjs at the final step. This will significantly reduce the size of the bundle.

The increase in security is wholly illusory. Consider the following, for instance:
// patch.mjs
import { Document } from 'yaml'
Document.prototype.toJS = () => 'foo'

// index.mjs
import './patch.mjs'
import { parse } from 'yaml'
parse('one: two') // returns 'foo'

If an attacker is able to execute code in your runtime environment, the above will work completely independently of the CJS/ESM packaging of this library. This is not a scenario for which it's reasonable to build protections; if an attacker gets that far, you've already lost the game. To protect against this, you should have wholly separate environments where you're running user & system code.

Our case is quite exotic: we want to resolve a deps tree as esm, but to convert it to cjs at the final step. This will significantly reduce the size of the bundle.

Where is that bundle size saving coming from, for something like yaml as a dependency?

The increase in security is wholly illusory

Well, immutable references in the module cache are just the first step, but more are needed. warmup + deep Object.freeze might fit your snippet.

I'm not suggesting to abandon cjs, but just add another entry point.
Correct. We have a need to make static builds for some utilities.

I'm not suggesting to abandon cjs, but just add another entry point.

Well, immutable references in the module cache are just the first step, but more are needed. warmup + deep Object.freeze might fit your snippet.

Given that I'm not willing to deep-freeze all objects in yaml, if you want to do that as a user, how does the module system help you at all if you're already intercepting imports/requires or operating them through a whitelist of some sort?
This security policy sounds like a thing that you can easily measure, but which has no real-world impact.

I'm not suggesting to abandon cjs, but just add another entry point.

Adding separate import & require entry points for Node.js would probably need to be done in a new major version, given that it would break the following identity:
// barrel.cjs
module.exports = require('yaml')

// index.mjs
import { Document as ESMDocument } from 'yaml'
import { Document as CJSDocument } from './barrel.cjs'
ESMDocument === CJSDocument

So while adding an entrypoint sounds like a small change, it's still a breaking change. Which, to be clear, I'm quite willing to consider, but it needs to have really good reasons for it. That's why I'm asking for practical, real-world examples of cases where the current config can be shown to be suboptimal in some way.

Reasonable. We can avoid br change via adding smth like:
{
   "export": {
      "cjs": {
         "types": "./dist/index.d.ts",
         "default": "./dist/index.js"
      } ,
      "esm": {
         "types": "./dist/index.d.ts",
         "default": "./dist/browser/index.js"
      }
   }
}

Reasonable. But module refs obtained via require and import are alway different, afair:
var y1 = require('yaml'), y2 = await import('yaml'); console.log(y1 === y2)

The top-level module, yes, but not the contents. Try this:
var y1 = require('yaml');
import('yaml').then(y2 => {
  console.log(y1.parse === y2.parse);
});

Same trick with a separated esm entrypoint:
https://github.com/jprichardson/node-fs-extra/blob/master/package.json#L57

Ah, I'd missed that you'd changed your proposal to defining yaml/esm and, presumably, yaml/esm/util. That would indeed avoid making this a breaking change, but I'm still not at all convinced this is worthwhile given that importing from yaml and yaml/util already works just fine.
I don't buy the argument that ESM is more secure than CJS for this library, and I'm still waiting for a reply to this question from earlier:

Our case is quite exotic: we want to resolve a deps tree as esm, but to convert it to cjs at the final step. This will significantly reduce the size of the bundle.

Where is that bundle size saving coming from, for something like yaml as a dependency?

Tbh, I'm tempted to wait for Node's require(esm) support to mature enough to allow dropping the CJS build completely.

I don't claim to have the truth. But we find the combination sufficient: immutable module cache plus frozen immutable modules. I want to believe that Object.freeze / {configurable: false, writable: false} effects cannot be reverted.

Closing, as the publication of the package on JSR (https://jsr.io/@eemeli/yaml) now allows for it to be installed in Node.js (or elsewhere, with similar commands) using
npx jsr add @eemeli/yaml

which will result in a local ESM-only dependency available as
import { parse, stringify } from '@eemeli/yaml'

That'll still include the imports from node:buffer and node:process that are stripped from the browser build, but those can be shimmed using a similar config.


Cannot compile Code on Solidity Remix Browser

Hi,
I am using Solidity Remix Browser version 0.4.13 to run the code.
Simply coped the entire code and tried to compile but got error message
"callback contain no result Error: Error: VM Exception while executing eth_estimateGas: invalid opcode".
Request to provide solutions for this issue.
Regards
Tanmay

solidity moves pretty quickly - for better or for worse :)
i'll happily accept a pr for this.

which framework did you use??
regards,
Likita

framework for what exactly?

Like truffle or embark or any other?
In remix I'm getting errors??
On 14 Mar 2018 23:50, "mario"<EMAIL_ADDRESS>wrote:

framework for what exactly?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/zupzup/solidity-example-crowdfunding/issues/1#issuecomment-373125069,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AeOxu4PGlx6HW15oPs4tQ6Uf-pis8Ackks5teV9PgaJpZM4OgIga
.

No framework. Keep in mind, that the repo and code is about 1 year old, so it shouldn't be surprising, that it doesn't work with the most recent versions of solidity.


Installation 404 Not found

While installing the plugin I got the error „install response status 404 Not found ..“ (see attached picture)
This was the only problem while installing the plugin.

I use the Homebridge UI.
Version 4.50.2 is installed.
It is installed on Raspberry Pi.
Govee version 7.9.0 is installed.
Node version 18.13.0
Npm version 9.3.1

please use the homebridge terminal to run these commands:
cd /usr/local/lib/node_modules/homebridge-govee

sudo npm install @abandonware/bluetooth-hci-socket

sudo npm install @abandonware/noble

restart homebridge and see if this has worked 🤔

This worked for me. But after making an update to the plugin I recieved the same error. Do you think this will cause any problems?
I also struggle to connect the hygrometer H 5075 to my homebridge.
thanks for help in advance

I used sudo hcitool inq and sudo hcitool scan but without any result. Thats why I can‘t pair the hygrometer with the homebridge.
With command hcitool dev I see hci0 I guess this is the bluetooth MAC from the raspberry


Warning: Check the render method of @mantine/core/Tooltip with Mantine 7 and MRT V2

mantine-react-table version
v2.0.0-alpha.4
react & react-dom versions
^18.2.0
Describe the bug and the steps to reproduce it
On the project we use Mantine UI library v7.3.0 and Mantine React Table, everything works fine but the console displays Warning: Function components cannot be given refs. Attempts to access this ref will fail. Did you mean to use React.forwardRef()?
Check the render method of @mantine/core/Tooltip.
Which is a bit annoying. Is it possible to fix it?
Minimal, Reproducible Example - (Optional, but Recommended)

Screenshots or Videos (Optional)

Do you intend to try to help solve this bug with your own PR?
No, because I do not have time to dig into it
Terms

[X] I understand that if my bug cannot be reliably reproduced in a debuggable environment, it will probably not be fixed and this issue may even be closed.

Which features have you enabled when you see this warning?

tooltip is trying to pass in reference to a child component. for that you must change your child component into forwarded component. using React.forwardRef


Split into hx711_power_up and hx711_power_down?

https://github.com/endail/hx711-pico-c/blob/1b634c3bd4e65b52ca3437721fa77f1268befcc8/src/hx711.c#L278
Consider readability of long function w/comments.

hx711_pwr_t and hx711_set_power removed. Replaced with hx711_power_up and hx711_power_down.


tabAutoComplete doesn't work in pycharm 2023.1.2

Before submitting your bug report

[X] I believe this is a bug. I'll try to join the Continue Discord for questions
[X] I'm not able to find an open issue that reports the same bug
[X] I've seen the troubleshooting guide on the Continue Docs

Relevant environment info
- OS: windows 10
- Continue: 0.0.46
- IDE: pycharm 2023.1.2

Description
i configured a tabAutoComplete model deepseek-7b with openai, and it works on pycharm 2023.1.1, but not on 2023.1.2
To reproduce
relevant config:
'''
{
"tabAutoCompleteModel":
{
"title": "Deepseek",
"provider": "openai",
"model": "deepseek-7b",
"apiBase": "http://my-api-base/v1",
"apikey": "my-apikey",
"contextLength": 10000
},
"disableSummaries": true,
"completeionOptions": {
"temperature": 0.3
}
}
'''
Log output
No response

Hey, I checked, and it was because the auto complete was disabled in the pycharm settings. It was just not mandatory in the 2023.1.1 version. I'm closing the issue.


Awake in PowerToys UI is set to enable even after Exit it from the tray icon

Microsoft PowerToys version
0.64.1
Installation method
PowerToys auto-update
Running as admin
No
Area(s) with issue?
Awake
Steps to reproduce
enable awake from the UI.
then from the awake tray icon exit.
The UI is still on Enable On
✔ Expected Behavior
In the UI Awake should be Off.
or
the icon tray should not allow to Exit and eventually report exit from the UI or something
❌ Actual Behavior
PowerToys is still Enable in the UI, but it is not more running as it has been exited from its own tray icon
Other Software
No response

I think you're right. Awake shouldn't show the exit command when it's started from the runner. Going to Settings should be the way to disable it.

@jaimecbernardo
there is also another edge case, not sure if i should open a new issue for it:
if you have awake enabled and then restart the OS, the awake tray icon won't be there at the next start-up of Windows, but the UI looks like is still on the switch enable status ON.

The fix for this issue has been released in 0.65. Please update PowerToys to the latest version:
https://github.com/microsoft/PowerToys/releases

@Raffaello , that looks like another issue indeed. Please open a new one if it's still occurring.


After a sucessful auth request seeing "Exception of type 'System.AggregateException' was thrown." when calling a cloud function.

Hi,
My app successfully finishes an auth request (running in editor). User is logged in correctly. Then I call a cloud function and it finishes with "Exception of type 'System.AggregateException' was thrown."
What I do:

FirebaseApp.CheckAndFixDependenciesAsync().ContinueWith(task => {
firebaseApp = FirebaseApp.DefaultInstance;
...
later: auth = Firebase.Auth.FirebaseAuth.GetAuth(firebaseApp);
in AuthStateChanged then creating global "functions" object: functions = FirebaseFunctions.GetInstance(firebaseApp);
calling the function exactly as described here: https://firebase.google.com/docs/functions/callable
Every function call ends with task.IsFaulted = true and empty stack trace
this is the error message: "Exception of type 'System.AggregateException' was thrown."

additional informations:

app is correctly signed (I see the problem in editor AND when deployed to android device)
everything runs in "us-entral1"
using the lates googleplaygames plugin (0.9.56) and firebase_unity_sdk_5.4.3 (just the packages auth, remoteConfig, database and functions)

I am searching since 3 days for the root cause, I guess now I need some help...
Thank you!
Regards,
Tino

Hi @Rainking80,
Have you looked at the backend logs to see what the Functions are doing? You can find them in the Firebase console, in Functions, in the Logs tab. They should say something like:
Function execution took 7 ms, finished with status code: 200
If they instead show a red flag and some error text, then there's some unhandled exception in your backend function. If not, you may want to add some logging statements to your functions just to make sure they're doing what you expect.
On the client, all exceptions are wrapped in AggregateException, but there may be a more specific exception you can get out of it. An example of how to do that is here:
https://github.com/firebase/quickstart-unity/blob/fe63718246942a212554e8a0a46fb76140753b3b/functions/testapp/Assets/Firebase/Sample/Functions/TestCase.cs#L63

Hi,
Thank you for the fast response. In my firebase console I see the functions successfully called (attached screenshot). Also I use Postman to develop and test the functions - everything seems to run perfectly except the Unity client:

Hmm, and if you unwrap the AggregateException object, what do you see?
    FunctionsException e = null;
    foreach (var inner in task.Exception.InnerExceptions) {
      if (inner is FunctionsException) {
        e = (FunctionsException)inner;
        break;
      }
    }
    if (e == null) {
      // We didn't get a proper Functions Exception.
      throw task.Exception;
    }
    throw new Exception(String.Format("Error {0}: {1}", e.ErrorCode, e.Message));

Hi,
thank you! with your hint and the help of the debugger I found the root cause. It was a type mismatch when returning the result. Since I took the exact code from the Firebase documentation here: https://firebase.google.com/docs/functions/callable
I guess it is too old. Other code samples like this one are working: https://github.com/firebase/quickstart-unity/blob/fe63718246942a212554e8a0a46fb76140753b3b/functions/testapp/Assets/Firebase/Sample/Functions/TestCase.cs
Kind regards,
Tino

Glad it's working for you now. We'll double-check those docs and make sure everything's up to date.


Correct name of src folder

The Arduino library framework allows the library code files to be stored under a subfolder of the library. This library must have the exact name src:
https://arduino.github.io/arduino-cli/latest/library-specification/#source-code
Previously, the folder was incorrectly named scr, which caused the code files stored under the folder to not be recognized by Arduino development software.
This caused the failure of the validity checks that are ran on libraries submied to the Arduino Library Manager:
https://github.com/arduino/library-registry/pull/4484#issuecomment-2088835473
Linting library in TimerUtils
ERROR: Path does not contain a valid Arduino library.
       See: https://arduino.github.io/arduino-cli/latest/library-specification
       (Rule LS001)

Closing as duplicated by https://github.com/Pascal2511/TimerUtils/commit/9837148817014c85c4559c7b5bec15b894c5a5cb
@Pascal2511 it is a bit frustrating to me that I took the time to submit a fix and you just ignored it.


Week 6 review ticket

Image manipulation with 2-D arrays
JavaScript: rapid api
Table generation with rapid api data

The idea is of fitness is narrowed down by focusing on the balance between school work and fitness
The use of API's will be in the website to obtain optimal data

team work completed, included brain write and project idea(ex. using rapidAPI)
individual work completed, the green, red, blue scale.
everything completed


Automatically choose best tqdm

Switch to tqdm.auto to enable better progress bars in jupyter notebooks vs terminal.

Thanks for the PR. Could you also change the one at https://github.com/zhijian-liu/torchpack/blob/master/torchpack/callbacks/inference.py#L36?

Thanks for the PR. Could you also change the one at https://github.com/zhijian-liu/torchpack/blob/master/torchpack/callbacks/inference.py#L36?


Tonals table comes from ns-countries

I may be mistaken here, but...
I'm looking at the tonals object in the exported data.  These are the tonals from the ns-countries.   So, when the tonal refers to unit_id 6, it matches the content of unit_id 6 from the ns-country-classes element in JSON, not the units element.
This may be related to #168

Tonals (as captured in TONAL_COLLECTION list) are from standard as well as non-standard classes. I'll need to change the id generation logic of classes/units as they are from two different collections. Ultimately, we'll be merging these into a single collection as described in #168.


[SPARK-45886][SQL] Output full stack trace in callSite of DataFrame context

What changes were proposed in this pull request?
In the PR, I propose to include all available stack traces in DataFrame context to the callSite field and apparently to the summary. For now, DataFrame context contains only one item of stack trace, but later we'll add a config to control the number of items in stack traces (see https://github.com/apache/spark/pull/43695).
Why are the changes needed?
To improve user experience with Spark SQL while debugging some issue. Users can see all available stack trace, and see from where the issue comes in user code from.
Does this PR introduce any user-facing change?
No, should not. Even if user's code parses the summary.
How was this patch tested?
By running new test suite:
$ build/sbt "test:testOnly *QueryContextSuite"

Was this patch authored or co-authored using generative AI tooling?
No.

@cloud-fan Could you review this PR, please.


ci: fixup update-deps.yml

fixes previous PR that updated to updater v2

Codecov Report
Base: 90.48% // Head: 91.37% // Increases project coverage by +0.88% :tada:

Coverage data is based on head (9bf627b) compared to base (e390ced).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1047      +/-   ##
==========================================
+ Coverage   90.48%   91.37%   +0.88%
==========================================
  Files         114        9     -105
  Lines        3575      197    -3378
==========================================
- Hits         3235      180    -3055
+ Misses        340       17     -323

Impacted Files
Coverage Δ

...ib/src/sentry_attachment/io_sentry_attachment.dart

dart/lib/src/transport/rate_limiter.dart

dart/lib/src/protocol/sentry_level.dart

dart/lib/src/protocol/sentry_trace_context.dart

dart/lib/src/protocol/debug_image.dart

dart/lib/src/protocol/sentry_stack_frame.dart

...art/lib/src/environment/environment_variables.dart

dart/lib/src/protocol/sentry_request.dart

dart/lib/src/protocol/sentry_operating_system.dart

dart/lib/src/protocol/sentry_stack_trace.dart

... and 95 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


[BUG]:  Poster image not showing with audioOnly prop in version 6.0.0

Version
6.0.0
What platforms are you having the problem on?
iOS, Android
Architecture
Old architecture
What happened?
In previous versions, setting the audioOnly prop to true while playing a video displayed the poster image. In version 6.0.0, the screen goes black, and only the audio plays without showing the poster image.
Environment:
React Native Video Version: 6.0.0
React Version: 17.0.2
React Native: 0.68.2
Device: (e.g., Samsung Galaxy A73)
OS: (Android 14)
Expected Behavior:
The poster image should display while the audio plays.
Actual Behavior:
The screen is black while the audio plays, and the poster image is not visible.
Reproduction
repository link
Reproduction
Step to reproduce this bug are:
Open the app.
Play a video with the audioOnly prop set to true.

I confirm this feature has been removed in 6.0.0. The best would be that you reimplement this poster management on app side.

I can manage this my adding the  tag


conf/layer.conf: Add LAYERDEPENDS_raspberrypi

To allow the command
bitbake-layers layerindex-fetch meta-raspberrypi
to work out, we need to declare the dependencies.
Use the same dependencies as declared in kas-poky-rpi.yaml .
Question is if we add the multimedia layer as well
(as mentioned in the README.md but not in the kas-poky-rpi.yaml).
LAYERDEPENDS_raspberrypi = "core networking-layer perl-layer qt5-layer"

Can one of the admins verify this patch?

Updated.

Can you please edit your commit log following https://meta-raspberrypi.readthedocs.io/en/latest/contributing.html#formatting-patches? Otherwise, looks good to me.

Fixed.

this is now addressed via 08d27cd and 25d1eb4


[Airflow] Trigger Cumulus to Process Aquirable via API call

Test code will first focus on CBRFC MPE since we already have a processor for the new geoprocess.
Related to USACE/Cumulus#74

Requires completion of USACE/Cumulus#86 to be fully ready.

Work is done for existing product in dev.  Issue will be complete when the following are done:

[ ] https://github.com/USACE/airflow-config/pull/19 Merged into Develop
[ ] https://github.com/USACE/cumulus-api/pull/77 merged into Develop


Create user API endpoint

Our Jenkins Ansible script creates different users for different jobs, with different passwords, ssh keys, tokens etc. Right now we're creating the provisioner's users by hand, which is time consuming, error prone and one of the few manual processes in our infrastructure.
Having the ability to create users (as an Admin user with an auth token), change their passwords, ssh keys would fix that problem for us, as we'd be able to drive the whole process through Ansible.

Also if the API could serve the users SSH key(s), one could use the Network Console feature of the debian preseed (which needs the authorized keys to be served via HTTP).
This network console could allow for Jenkins/Ansible checking that installation is proceeding correctly.
At the moment, one would need to hijack the SoL flux and grep it... which is kind of a mess.


[Enhancement] check data partition in memory match with those in disk and report lack data partition to the metric

[Enhancement] check data partition in memory match with those in disk and report lack data partition to the metric

@leonrayang Please help to review the code, thank you very much

Hi @leonrayang @Victor1319 , can we merge this PR? We have a PR that will be submitted, depending on this. Thank you very much.

Codecov Report

Merging #1641 (a106364) into master (497ffd9) will not change coverage.
The diff coverage is n/a.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@           Coverage Diff           @@
##           master    #1641   +/-   ##
=======================================
  Coverage   47.72%   47.72%
=======================================
  Files         455      455
  Lines       78195    78195
=======================================
  Hits        37319    37319
- Misses      37952    37963   +11
+ Partials     2924     2913   -11

Impacted Files
Coverage Δ

blobstore/clustermgr/volumemgr/volumemgr.go
77.66% <0.00%> (-4.30%)
:arrow_down:

blobstore/common/consul/consul.go
17.50% <0.00%> (-0.63%)
:arrow_down:

master/topology.go
28.86% <0.00%> (+0.13%)
:arrow_up:

master/data_partition.go
45.64% <0.00%> (+0.22%)
:arrow_up:

blobstore/common/raftserver/server.go
78.84% <0.00%> (+0.57%)
:arrow_up:

blobstore/access/stream_get.go
78.05% <0.00%> (+1.06%)
:arrow_up:

util/stat/statistic.go
66.30% <0.00%> (+4.65%)
:arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


[BUG] Top N API returns no results when only cpu or only memory is enabled

What is the bug?
Top N API returns no results when only cpu or only memory is enabled.
In RestTopQueriesAction we have a single check for MetricType.LATENCY which is causing this issue:
https://github.com/opensearch-project/query-insights/blob/main/src/main/java/org/opensearch/plugin/insights/rules/resthandler/top_queries/RestTopQueriesAction.java#L69
How can one reproduce the bug?

Enable top N for cpu. Ensure latency, memory, and search.query.metrics.enabled are disabled.

curl -X PUT "localhost:9200/_cluster/settings?pretty&flat_settings" -H 'Content-Type: application/json' -d '{"transient" : {"search.insights.top_queries.cpu.enabled" : true}}'

Index data and send some search requests

// Bulk
curl -X POST "localhost:9200/_bulk?pretty" -H 'Content-Type: application/json' -d'
{ "index" : { "_index" : "test2", "_id" : "1" } }
{ "field1" : "value1" }
{ "index" : { "_index" : "test2", "_id" : "2" } }
{ "field2" : "value2" }
{ "index" : { "_index" : "test2", "_id" : "3" } }
{ "field3" : "value3" }
{ "index" : { "_index" : "test2", "_id" : "4" } }
{ "field4" : "value4" }
'

// Match all
curl -X GET "http://localhost:9200/_search?pretty&phase_took" -H 'Content-Type: application/json' -d'
{
  "query": {
    "match_all": {}
  }
}'

Get Top N

% curl -X GET "localhost:9200/_insights/top_queries?pretty"

{
  "top_queries" : [ ]
}

API will return no results even though top N cpu is enabled
What is the expected behavior?
Top N should return results if any 1 or more metrics (latency, cpu, memory) are enabled.

If user calls Top N api without any type param (ex GET /_insights/top_queries) we use type=latency by default. That is why no results are returned anytime latency is disabled but cpu and/or memory are enabled.
final String metricType = request.param("type", MetricType.LATENCY.toString());

Need to update documentation:
https://opensearch.org/docs/2.16/observing-your-data/query-insights/top-n-queries/#monitoring-the-top-n-queries
You can use the Insights API endpoint to obtain the top N queries for all metric types:

GET /_insights/top_queries

@dzane17 is right, I think this is a bug introduced when adding CPU and memory as additional metric types. IMO we should not set the default metric type subjectively. But in this case we should also update the API to disallow users to call the API without the type parameter.


Added 35 | Search Insert Position | Python

Pull Request Template
What have you Changed(must)
Write here what you have changed in the codebase
Issue no.(must) - #906
Pr will be close and marked as spam. If issue number not found or issue was assigned to someone else.
Marking as spam can block your account from HacktoberFest.
Self Check(Tick After Making pull Request)

[x] This issue was assigned to me if not it will be marked as spam.
[x] My file is in the proper folder
[x] I am following clean code and Documentation.
[x] I have added the title and what program will do first in the file
[x] I have named the file as (Problem #). (Problem Title(in Camel Case)).(extension)
ex. 2. AddToNumbers.py

README - How to Contribute

Please Review this PR


Adding global metadata

Docs Build status updates of commit 264c3b9:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

DocsLegal/docfx.json
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


s/t/bamtools_filter.cpp: simplify GetScriptContents().

This MR resolves https://github.com/pezmaster31/bamtools/issues/237
Changes:

Make 'feof(inFile)' a while condition (to avoid infinite loop in the code)
break when fgets() returns NULL (no data to read)
check ferror() - fgets() return value is undefined behaviour in this case.

Testing:

Running
bamtools filter -script filter_script -in ./tests/data/sam_spec_example.bam -out out.bam with filter_script

{
  "filters" :
    [
      { "id" : "inAnyErrorReadGroup",
        "tag" : "RG:ERR*"
      },
      { "id" : "highMapQuality",
        "mapQuality" : ">=75"
      },
      { "id" : "bothMatesMapped",
        "isMapped" : "true",
        "isMateMapped" : "true"
      }
    ],
  "rule" : "!inAnyErrorReadGroup & (highMapQuality | bothMatesMapped)"
}

succeeds

@vpa1977 I've improved your commits a bit. Could you try HEAD once more before I cut a new release?


Show userstore type in the userstore list page

Is your suggestion related to an experience ? Please describe.

Userstore list view in the console

Describe the improvement

Give an indication about the userstore type in the userstore list page

This is subjective. Most of the cases description will give the necessary brief about the user store. Userstore type may not give much useful context to the viewer


Enable decimal128 test

I'm not sure why this is failing, but it seems like it might point to an Arrow JS bug. In particular, the decimal array written by pyarrow is
https://github.com/kylebarron/arrow-js-ffi/blob/f9ae0be8ccb77b6a40461f5bed7037c212d2014d/tests/pyarrow_generate_data.py#L61
I'm not sure how to interpret the console.log output from here
https://github.com/kylebarron/arrow-js-ffi/blob/f9ae0be8ccb77b6a40461f5bed7037c212d2014d/tests/ffi.test.ts#L390-L391
DecimalBigNum(4) [Uint32Array] [ 1230, 0, 0, 0 ]
DecimalBigNum(3) [Uint32Array] [ 1230, 0, 0 ]

Looks like the same error as https://github.com/apache/arrow/issues/37920


Fix documentation regarding Restore permission requirement

Fix documentation regarding Restore permission requirement

@KesemSharabi -

Can you review this PR?
IMPORTANT: When this content is ready to merge, you must add #sign-off in a comment or the approval may get overlooked.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team


Implement storage limit

As of today there is no limit for the total size of files that are stored on the server. Would be a nice feature to limit to a certain size, and delete older files if that limit is broken

Hi,
This a feature I really needed so I have implemented a simple solution in my fork. My implementation doesn't delete older files when quota is exceeded though.

Hi,
Nice implementation, I may implement my own later though. If you wish you can create a pull request so I can remember the way you did things ?
Goploader is subject to heavy changes in the next weeks, especially on the statistics module by the way.
Cheers and thanks for the implementation example :+1:

Sure, a pr created.

Commented on your PR :)

I had a closer look and tested a bit further, thing is, you're dependent on the header (which the client doesn't provide). To know the exact size of the thing being uploaded you'll have to check the wr variable which contains the exact number of bytes that were written on disk. I'm currently working on integrating that, but that adds another step (if the file is too large, it is first written and then deleted).
That's the only safe way I found actually. Anyone can tamper the header :/

The issue is now fixed. I implemented it my own way by checking the written bytes, and reworked a little on how the stats are saved (they are now saved in the same transaction as the resources). Thanks for the help ! :) Website will get an update soon.

That's great :) Your solution looks much better.

Thanks I'm glad you like it ! I got inspired by your work :)
Pushing the website with updated documentation right now.


network-manger-openvpn causes docker to not start

Output of docker version:
Client:
 Version:      1.12.1
 API version:  1.24
 Go version:   go1.6.3
 Git commit:   23cf638
 Built:        Thu Aug 18 05:33:38 2016
 OS/Arch:      linux/amd64
Cannot connect to the Docker daemon. Is the docker daemon running on this host?

Output of docker info:
Cannot connect to the Docker daemon. Is the docker daemon running on this host?

Aug 19 23:53:45 lapp1 systemd[1]: docker.service: Failed with result 'exit-code'
docker ps
An error occurred trying to connect: Get http://%2Fvar%2Frun%2Fdocker.sock/v1.24/containers/json: read unix @->/var/run/docker.sock: read: connection reset by peer
Steps to reproduce the issue:

fresh ubuntu 16.04 install
install network-manager-openvpn
service docker start

Describe the results you received:
Job for docker.service failed because the control process exited with error code. See "systemctl status docker.service" and "journalctl -xe" for details.
Describe the results you expected:
docker service to start....
Additional information you deem important (e.g. issue happens only occasionally):

Can you provide the untruncated log?

I had tested this several times before opening the bug report. However, after rolling back to a previous snapshot and trying once again I am unable to repo.
I am guessing this could be closed until someone else can repo it.

Thanks, I'll close this issue


More options than only mark an article as relevant and irrelevant

Feature Request
Is your feature request related to a problem? Please describe.
Sometimes users are not sure if the article is relevant or not and they want to think about it a little bit more or discuss it with a colleague. In other situations an article can be very relevant and then they want ASReview to show more articles like that, and be able to find the article again easily.
Describe the solution you'd like
An option to mark an article as uncertain and be able to make the decision later. The super relevant option could be an option during the screening proces when users think the article is more relevant than the other articles marked as relevant.
Why would you like to see this feature
Currently there are only two options relevant and irrelevant. But in reality there are more levels of how relevant an article is, an article can be very relevant and the user could be uncertain about if the article is relevant or not.

@Sybren-UU Thanks for reporting! We will add more information in the documentation of the next release. In the future someone might want to help us out with adding the options:
'postpone decision' => the next record in the queue will be shown and the postponed record will be moved back to the pool of unlabeled records. This would solve your issue, but most probably in the next iteration the same record will show up as most relevant...
another option is
'remove record' => it might be the record does not belong in the pool and should be deleted. This option should remove the record and re-train the model with the deleted record.

The notes field can be very helpful in the mentioned examples. Feel free to reopen the issue (and maybe be a bit more specific on the proposed solution).


Not redirecting on failure

On a failure of invalid credentials (for provider: 'hanami', not a github integrated solution etc), the authentication fails loudly throwing an error with no sensible way to rescue from. The tests written show tests to ensure that a redirect is done on the failure of an authentication however in practice I can not see this happening.
Any chance for some help on how to resolve this issue?

Hi @John-Hayes-Reed  and sorry for a delay (for some reason I'm not getting any notification from GH when someone creates issue or pull request in my repository). What you describe, seems to be an Omniauth thing and on purpose. I'm not sure how can this behaviour be safely overridden by the Hanami provider. Meanwhile, I updated example application with solution suggested by Omniauth FAQ.


Mobile responsiveness

The form needs to fill the full page on mobile. This can be done using CSS width rules.

#12


Addition of new method

Hi!
In my work often require to create & fit images with default background on empty areas, which is formed when bestfit apply. Hope my request is helpful.

Thanks for contributing. It looks like you can achieve the same behavior pretty easily with existing methods (best_fit, create, overlay):
// These are already known values
$max_width = 200;
$max_height = 50;
$bg = '#ffcc00';

// We'll need to use two instances
$img1 = new SimpleImage();
$img2 = new SimpleImage();

// Best fit the original image
$img1->load('butterfly.jpg')->best_fit($max_width, $max_height);

// Create the new image and overlay the original one
$img2->create($max_width, $max_height, $bg)->overlay($img1)->output();

Unless there's a reasonable demand for it, I'd prefer not to add this as a separate method, particularly when it can be done in just a few lines of code :)


Adding k8s-endpoint as command line arg

Add the possibility to define K8S_ENDPOINT via command line args , If it fails to find the arg the script will default back to the original way of getting the k8s endpoint

install.sh won't be updated further


[Bug]: Table widget interactable columnTypes (button, icon button, menu button, and edit actions) should not be present in selectedRow, triggeredRow, and updatedRow properties

Is there an existing issue for this?

[X] I have searched the existing issues

Description
Table widget interactable columnTypes (button, icon button, menu button, and edit actions) should not be present in selectedRow, triggeredRow properties.
Steps To Reproduce

D&D a table widget.
add a custom column and change the type to button
Observe that the button column appears in selectedRow and triggeredRow properties.

Public Sample App
No response
Version
cloud

EditActions1 comes up on auto-complete which needs to be removed from suggestions along with the other changes mentioned above.
Slack conversation


[DOCS] Typo in docstrings to_argilla metrics_strategy should be metric_strategy

Which page or section is this issue related to?

What are you documenting, or what change are you making in the documentation?

Closed with #334


Instructions only applicable to older version of the SDK

Issue in ./help/c-target-mobile-app/mobile-send-activity-information-analytics.md
I was told this only applies to older versions of the mobile SDK. It would be good to call it out. I suspect that means versions 4.14 or earlier since they are not using the batch delivery API which returns the tnta automatically for A4T activities.

@ryrob30, the entire page isn't applicable to newer versions?

That's correct.


Annotation Guide using Misogyny Use Case

This guide will serve as a guide for:

Training an AMI system with IberEval 2018's dataset
Annotating and exporting annotations
Retraining
Inter-Annotator Agreement

To simplify the system for the guide, we will exclude Subtask 3 (target) and make Multiclass, but not Multilabel, of Subtask 2 (category). We also need to make the datasers public, the initial and the annotated ones, to make the guide replicable.
Even though it is not a tutorial, it is intended to use runnable code as much as possible.

Done!


cairo: 1.16.0 -> 1.17.4

Motivation for this change
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

This is technically an unstable release but I guess it makes sense to bump this since 1.16 is buggy. It would allow us to close https://github.com/NixOS/nixpkgs/pull/127120
Some interesting changes: most importantly, Meson port. But we can handle that later too.

https://cairographics.org/news/cairo-1.17.4/
https://cairographics.org/news/cairo-1.17.2/

This is technically an unstable release

Where's that documented?

On https://cairographics.org/news/, odd-minor versions are called snapshot.

Wow, that is not obvious. :(
In that case I think it's probably better to just keep patching.


two languages to TaskConfigurationWizard

Adding localization to package org.jkiss.dbeaver.tasks.ui.wizard class TaskConfigurationWizard
new Strings in class TaskUIMessages (package org.jkiss.dbeaver.tasks.ui.internal)

Please make PR in your personal repo fork


Should/Must EBML define the Signed VINT?

In EBML is a VINT defined which is equal to an Unsigned VINT.
Matroska uses a Signed VINT for the laced frame size.
I would say yes, EBML have to define the Signed VINT.

As you said, it's a Matroska thing (vaguely related to EBML size encoding). It doesn't belong in EBML. (just as the code doesn't belong in libebml)

OK. I close the issue.
It's a Matroska thing.


[DMS-119] Update score board action version

Fixed in: https://github.com/Ed-Fi-Alliance-OSS/Data-Management-Service/pull/30