feat(remix-react): add magic comment to allow webpack bundling

Closes: #

[ ] Docs
[ ] Tests

Testing Strategy:

To make sure I understand, we know that the route module will be there because we make our own manifest rather than relying on webpack's built-in code splitting mechanism?

To make sure I understand, we know that the route module will be there because we make our own manifest rather than relying on webpack's built-in code splitting mechanism?

Without this, webpack attempts to bundle / create dynamically loadable chunks for the import. Since it can't resolve the variable to a path on disk, webpack ultimately will just throw an error at runtime saying something like "this chunk wasn't able to be bundled".
With this comment webpack doesn't try to bundle that import at all and just resolves whatever string is passed to it at runtime using dynamic import instead of the webpack module graph resolution algorithm.

Right. What I was trying to make sure I understood is why it works to leave the dynamic import in place :) I think I get it. Thanks!


The implementation of chen long's Multi-key FHE

Is there an implementation of Multi-key FHE based on BGV in the SEAL library?
The author of "Batched Multi-hop Multi-key FHE from Ring-LWE with Compact Ciphertext Extension" told me that SEAL have implemented it, but I can't seem to find it.

That's what I wanna no. I am perfecting this scheme recently.


getEclipseBundleSymbolicName is invoked "too early" for rcp apps

getEclipseBundleSymbolicName is invoked "too early" by rcp app configuration (indirectly, by getEclipseIntroId in defaultConfig.groovy). That means: temprary manifest does not exist yet, but getEclipseBundleSymbolicName already tries to read it, which leads to FileNotFoundException.
The solution is simply to replace PluginUtils.getEclipseBundleSymbolicName with project.bundleSymbolicName (which is populated early, before rcp app configuration).

Fixed with commit 17fd52633c5d36badc5309555e72f916a4a9cafe


fix: test-known-build used a hard-coded user

The hardcoded user prevent anyone but that user to run the test
successfully because of the unauthorized access to the test repository.
Signed-off-by: Romain Arnaud<EMAIL_ADDRESS>

@Roming22 closing for now - can revisit when we refactor the examples or add to e2e tests


[Feature]: Implement filter profiles on explore page

Contact Details
No response
What do you like to be improved?

Filter for Aktivitätsgebiete (Bundesländer & Bundesweit) && Biete && Suche
Inside each category ||
Create message: No user found for current filter
Reset filter

only for logged in users


Make the fields of TextMetrics lazily calculated, and add an API that eliminates double layouts.

This adds an extension to the HTML canvas API that allows you to pass the
TextMetrics object returned by measure_text() to fill_text() and/or
stroke_text() to draw the measured text without laying it out again. It
improves performance on the canvas_nanovg demo.

@bors-servo: r+

:pushpin: Commit 75a9e5d has been approved by pcwalton

:hourglass: Testing commit 75a9e5da57a6cd1095b203989d34616e8c9d2a94 with merge 654dc99ad1a48452f88d3d6ea581aaa21e2c9329...

:broken_heart: Test failed - checks-travis

@bors-servo: r+

:pushpin: Commit d01bc5d has been approved by pcwalton

:hourglass: Testing commit d01bc5d002eafb3ccc7cc6209ac6f1f27fe1d4de with merge ca201ac0c88e0e84fd71d22e999e1d148445fe1f...

:sunny: Test successful - checks-travis
Approved by: pcwalton
Pushing ca201ac0c88e0e84fd71d22e999e1d148445fe1f to master...


Make a screen chat with more views.

Hi, i want to make a screen chat like this

i see in sample files in ChatViewController we have to inheritance JSQMessagesViewController so how can i custom a screen with more views not only chat view ?

Thanks @pqhuy87it ! :smile:
This doesn't seem specific to the library. StackOverflow is a more appropriate place to ask this question. :blush:
I'm going to close this issue, but the community should feel free to continue the discussion here.
Other ways to get help:

Ask on StackOverflow with the jsqmessagesviewcontroller tag
See the FAQ
Search previous questions


Split arcdps_struct.h into two headers so one can be included from linux

Is the Windows.h include really necessary?

It's needed in
typedef uintptr_t (*WindowCallbackSignature)(HWND hWnd, UINT uMsg, WPARAM wParam, LPARAM lParam);
typedef ModInitSignature (*GetInitAddrSignature)(const char* arcversion, ImGuiContext* imguictx, IDirect3DDevice9* id3dd9, HMODULE arcdll, MallocSignature mallocfn, FreeSignature freefn);

which in turn are needed for the definition of arcdps_exports


LSTM: Error when string contains a number

When i try put a number inside the string i got a error. if i change "1" to "one"  it work perfectly.
let net = new brain.recurrent.LSTM();
net.train([
        { input: 'rate something: 1', output: [1] },
        { input: 'rate something: 2', output: [0.8] },
        { input: 'rate something: 3', output: [0.5] },
        { input: 'rate something: 4', output: [0.2] },
        { input: 'rate something: 5', output: [0] },

        ], {
                errorThresh: 0.005,
                iterations: 200,
                log: true,
                logPeriod: 10,
                learningRate: 0.3
            });
        let output = net.run('1');
        sails.log.info('output');
        sails.log.info(output);

iterations: 0 training error:<PHONE_NUMBER>85519
iterations: 10 training error: 1.2918302579915208
iterations: 20 training error: 1.2350417776285887
iterations: 30 training error: 1.2174326572564922
iterations: 40 training error: 1.1939474465655842
iterations: 50 training error: 1.2130778637941426
iterations: 60 training error: 1.1994392580854605
iterations: 70 training error: 1.207562241232045
iterations: 80 training error: 1.1737905311798773
iterations: 90 training error: 1.17077167012348
iterations: 100 training error: 1.1686849515992324
iterations: 110 training error: 1.16726060855015
iterations: 120 training error: 1.1621521847722407
iterations: 130 training error: 1.1389143399426636
iterations: 140 training error: 1.168624639308815
iterations: 150 training error: 1.1458368969024213
iterations: 160 training error: 1.1245658296674121
iterations: 170 training error: 1.1174364988591916
iterations: 180 training error: 1.114947384936504
iterations: 190 training error: 1.1134176966091878
info: output
------> error in output: info: e something: 5stop-inputstart-output0.8

I guess the problem comes from the way you structured your training Data.

The problem is not with structure, but with how the net is built.  To get this to work you'd need to modify the network.  It isn't terribly difficult and will be addressed in v2, which we are actively working on.  This is a "cross-bread" of translation in (or sort of like a standard recurrent neural network) with a direct number out (like a timestep), you'd need to take a look at both approaches and sort of use the best from each.  This is still on the drawing board (ie hypothetical, but still very close), but the api would likely look something like this:
import { Recurrent, layer } from 'brain.js';
const { inputCharacterMap, rnn, output } = layer;
const net = new Recurrent({
  inputLayer: () => inputCharacterMap("{string containing all possible characters}"),
  hiddenLayers: [(input, previousOutput) => rnn({ width: 1, height: 1 }, input, previousOutput)],
  outputLayer: (input) => output({}, input)
});

NOTE: this won't work yet.  and the example isn't complete, but it is to show off the underlying architecture (note: we WILL make it easier to use so you don't have to configure the layers, they'll just come about automagically).
However, you could probably get away with something like this using simply the feedfoward neural network architecture (NeuralNetwork class) if you simply do this:
let net = new brain.NeuralNetwork();
net.train([
  { input: { rateSomething1: 1 }, output: [1] },
  { input: { rateSomething2: 1 }, output: [0.8] },
  { input: { rateSomething3: 1 }, output: [0.5] },
  { input: { rateSomething4: 1 }, output: [0.2] },
  { input: { rateSomething5: 1 }, output: [0] },
], {
  errorThresh: 0.005,
  iterations: 200,
  log: true,
  logPeriod: 10,
  learningRate: 0.3
});
let output = net.run({ rateSomething1: 1 });
sails.log.info('output');
sails.log.info(output);


Missing COINGECKO_API_KEY in .env, yarn start => Error

Collecting page data. Fetch Error. Info: {
  endpoint: 'https://coingecko.osmosis.zone/api/v3/coins/list',
  config: { method: 'GET', body: undefined },
  status: 403,
  exception: a [Error]: JSON parse error: SyntaxError: Unexpected token 'U', "Unauthorized access" is not valid JSON
      at C:\Users\MiqArt\Desktop\osmosis-frontend\packages\web\.next\server\chunks\5247.js:7:445425
      at Generator.throw (<anonymous>)
      at r (C:\Users\MiqArt\Desktop\osmosis-frontend\packages\web\.next\server\chunks\5247.js:7:443919)
      at process.processTicksAndRejections (node:internal/process/task_queues:95:5) {
    status: 403,
    data: { url: 'https://coingecko.osmosis.zone/api/v3/coins/list' },
    response: Response {
      status: 403,
      statusText: 'Forbidden',
      headers: Headers {
        date: 'Sat, 31 Aug 2024 15:16:45 GMT',
        'content-type': 'text/plain;charset=UTF-8',
        'content-length': '19',
        connection: 'keep-alive',
        vary: 'Accept-Encoding',
        server: 'cloudflare',
        'cf-ray': '8bbdfbc8e81b0b3a-AMS'
      },
      body: ReadableStream { locked: true, state: 'closed', supportsBYOB: true },
      bodyUsed: true,
      ok: false,
      redirected: false,
      type: 'basic',
      url: 'https://coingecko.osmosis.zone/api/v3/coins/list'
    }
  }
}

I think this issue is existing because there is no public Coingecko.Osmosis coins api anymore however maybe the code should be changed to take coins from the regular coingecko coins list https://api.coingecko.com/api/v3/coins/list

I don't have this issue anymore so the problem is probably solved already
it is possible to work around the issue if you still have it

register with coingecko
change the api endpoint to point directly to coingecko
use yout own api key

I am not sure about the implications of this, but I could get the repo up and running with this in the past
but again: I don't see this issue anymore

IIRC, this may be a key into our own CoinGecko proxy cc @niccoloraspa


Non-Datagram Packet Ping with multiple targets causes Segmentation Error

Configuring multiple Non-Datagram PING probes :
    probe {
      name: "xyz_git"
      type: PING
      targets {
        host_names: "git.xyz.net"
      }
      interval_msec: 5000  # 5s
      timeout_msec: 1000   # 1s
      ping_probe {
        use_datagram_socket: false
      }
    }
    probe {
      name: "xyz_nexus_server"
      type: PING
      targets {
        host_names: "nexus.xyz.net"
      }
      interval_msec: 5000  # 5s
      timeout_msec: 1000   # 1s
      ping_probe {
        use_datagram_socket: false
      }
    }

Causes an segmentation fault when running CloudProber:
 [signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0xbc2294]

goroutine 200 [running]:
github.com/google/cloudprober/probes/ping.(*Probe).Start(0xc0003f2320, 0xff51e0, 0xc00027e880, 0xc000127200)
	/home/travis/gopath/src/github.com/google/cloudprober/probes/ping/ping.go:466 +0x324
created by github.com/google/cloudprober/prober.(*Prober).startProbe
	/home/travis/gopath/src/github.com/google/cloudprober/prober/prober.go:268 +0x16f

@VincentS Thanks for the bug report. I was not to able to reproduce it right away, so I had a few questions:

Does it happen immediately after starting cloudprober, or randomly after some time?
Which version of cloudprober are you running? (for stack trace and source code matching).

Anything else you can share about your setup.

Also, was there another line above the segmentation violation code line in the error message?

Ah, I was able to finally reproduce it. This bug gets triggered only if one of the targets doesn't get resolved. Basically whenever we take the following code path, "result" data  struct doesn't get created for a target:
https://github.com/google/cloudprober/blob/206e5fcb9193bcbfe07950ea49a04ab08f985c51/probes/ping/ping.go#L207
I'll send a fix soon.
Thanks again for reporting this bug.

Thank you for the quick response / fix.

Released the fixed binary in v0.10.4.


Use longitude-one/wkt-parser, remove php 7.4 & 8.0 support

min php version >= 8.1 (as in longitude-one/wkt-parser)
use Attributes for tests as doctrine/annotation 2 removed SimpleAnnotationReader
on my linux, I had to change some on the tests values to make it pass, not included in this pull request because I found a comment "//TODO: Test should be fixed, distance are differents on Windows and on Linux."

There is probably more to do but that can be a start

tests should be ok now, I had to modify workflow so forks can be executed (so it need maintener approval to be run)

+1

Hey guys, I just stumbled upon this library, would love to use it, but obviously can't because I'm running the latest doctrine version and PHP 8.1.
When do you think this will be merged into the main branch? Thanks!

Hey guys, I just stumbled upon this library, would love to use it, but obviously can't because I'm running the latest doctrine version and PHP 8.1.
When do you think this will be merged into the main branch? Thanks!

Hi Pim,
In our side, we used this library with PHP8.1 and Doctrine ORM 2.14.2 without worries.
It just Doctrine Annotations and Doctrine Lexer which are in the previous versions (see #36).
What is your issue?
Regards,
Mickaël


⚠ SceneTime has degraded performance

In e8000a0, SceneTime ($ST) experienced degraded performance:

HTTP code: 200
Response time: 17978 ms

Resolved: SceneTime performance has improved in 4e25510 after 5 minutes.


DISTMYSQL-466: RestartReplicationQuick called even from Orchestrator cluster where recovery has been globally disabled

https://perconadev.atlassian.net/browse/DISTMYSQL-466
Problem:
When recovery is disabled globally, UnreachableMasterWithLaggingReplicas and UnreachableIntermediateMasterWithLaggingReplicas cases cause replica io thread to be restarted.
Cause:
Commit 98bd7f0f added the feature allowing global recovery disable
Commit fc33f3ee moved the implementation to
executeCheckAndRecoverFunction
Commit b761fa3d introduced runEmergencyOperations() function. Its purpose was to read topology instance to speed up recovery. The instance was read, then recovery was skipped if disabled globally.
Commit 464a3c1d and 684d6e24 caused the regression. They introduced the call to emergentlyRestartReplicationOnTopologyInstance() from runEmergencyOperations().
https://github.com/openark/orchestrator/pull/572 and https://github.com/openark/orchestrator/pull/1005 provide the detailed explanation, why it was done.
Solution:
If recovery was disabled globally, and this is not forced discovery, skip restart of replicas.
Additionally fixed Instance object read from Orchestrator's backend DB. Such and object was missing QSP member (Query String Provider). As the consequence any query related to master/slave <-> source/replica could not be resolved and failed (because nil string query was executed)

Related issue: https://github.com/openark/orchestrator/issues/0123456789
Description
This PR [briefly explain what is does]

https://ps80.cd.percona.com/job/mysql-orchestrator-pipeline/44/


install: refresh installation guide README

Refresh installation guide README with a clearer structure, and provide
a list of distribution with official Kata packages. This also updates
the openSUSE Leap versions supported to 15 and 15.1.
Fixes: #533
Signed-off-by: Marco Vedovati<EMAIL_ADDRESS>

/test


Cant download/install McEdit

Description of Issue: Can't download MCEdit
MCEdit Version: <IP_ADDRESS>
Operating System: Ubuntu 19.04
A screenshot or full text of the error from the console:
Detecting state of the dependencies...
Traceback (most recent call last):
 File "../bin3/mcedit-<IP_ADDRESS>/install.py", line 994, in <module>
 File "../bin3/mcedit-<IP_ADDRESS>/install.py", line 431, in o0O0Oooo0O
ImportError: No module named pkg_resources

Try reading the readme

Well, now i got this:
Starting MCEdit... Running in fixed mode. Support files are in your Documents folder. Traceback (most recent call last):   File "/usr/lib/python2.7/runpy.py", line 174, in _run_module_as_main     "__main__", fname, loader, pkg_name)   File "/usr/lib/python2.7/runpy.py", line 72, in _run_code     exec code in run_globals   File "/tmp/release-master/MCEdit-Unified/__main__.py", line 38, in <module>   File "/tmp/release-master/MCEdit-Unified/mcedit.py", line 13, in <module>   File "/tmp/release-master/MCEdit-Unified/splash.py", line 10, in <module> ImportError: No module named pygame

Got it working somehow.


Possibility to boot RaspberryPi3 via USB

There is a beta feature in the RaspberryPi3 firmware that seem to allow to boot the device via USB rather than solely relying on a full sd card boot. For better reliability regarding sd card lifetime we should evaluate the possibility to integrate support for booting the RaspberryPi3 via USB. More information can be found here:
https://developer-blog.net/raspberry-pi-vom-usb-stick-booten/
https://www.raspberrypi.org/documentation/hardware/raspberrypi/bootmodes/msd.md
https://www.raspberrypi.org/forums/viewtopic.php?t=153177&p=1010284
https://www.digikey.com/en/maker/blogs/booting-your-raspberry-pi-from-usb/55b72783afa046c5a5bcd8a9c1792713
See also the general documentation on possible boot modes for RaspberryPi:
https://www.raspberrypi.org/documentation/hardware/raspberrypi/bootmodes/

Boot via USB works now. The only thing missing  is a way or documentation to setup USB boot. The procedure should be documented as:

initial boot via sd card (so that the internal OTP is flashed for USB boot support)
Flash *.img on USB stick/harddisk
mount /bootand modify /boot/cmdline.txt and change root=/dev/mmcblkp2 to root=/dev/sda2
mount /etc/fstab and change all /dev/mmcblkXXX to /dev/sdaX
remove SD card from Pi3 and plug in USB stick/hdd
Boot

Please note that with the latest change point (4) is not required anymore. Just /boot/cmdline.txt still has to be manually edited with the correct device path to the root device (change from /dev/mmcblkp2 to /dev/sda2). Editing /etc/fstab is not required anymore and should make the switch from SD card to USB booting way easier.


Hubble parametrized

I think the StandardCosmology should only be an inheritance of other components. Therefore, we should separate out the Hubble (and later the Tcmb) pieces. This PR makes the Protocol HubbleParametrized which holds the Hubble info.
PR Checklist

[ ] Give a detailed description of the PR above.
[ ] Document changes in the CHANGES.rst file. See existing changelog for examples.
[ ] Add tests, if applicable, to ensure code coverage never decreases.
[ ] Make sure the docs are up to date, if applicable, particularly the docstrings and RST files in docs folder.
[ ] Ensure linear history by rebasing, when requested by the maintainer.

Can you explain this change a little more? As I understand it, a Hubble parameter comes with having a scale factor, which comes with having a redshift... So in this picture, every FLRW cosmology should be HubbleParametrized intrinsically.

As in, we should package it into FLRWBackground?

I just don't see how it could be separate from the distance functions. The Hubble function is the connection between redshift and physical time, from which you get the comoving distance.
Hm, ok, on the implementation side, I see how a cosmology instance might not expose the H0 and H(z) details, in which case one would have to manually differentiate the comoving distance somehow to get it back ...
Maybe the name sent me in the wrong direction, because it's not parametrised by the Hubble function. Perhaps HubbleParameter as an alternative?

Maybe the name sent me in the wrong direction, because it's not parametrised by the Hubble function. Perhaps HubbleParameter as an alternative?

That sounds reasonable, or what about HasHubbleParameter or SupportsHubbleParameter?

Also, then I suppose we would separate out HasTCMB?
I've been trying to decide whether HasTCMB would require support for photons? Technically the CMB background temperature is the temperature of the photons, so if the are no photons.... OTOH often in simple models, e.g. only matter and dark energy we still talk about the background temperature.

I think if we want to separate everything, then yes, we should separate truly everything.
I like the HasX names, but then we probably also want to change all the components (again) to be HasXComponent.

Ok. Followup PR will separate out the Tcmb and rename the components.

Codecov Report

Merging #31 (889c6fc) into main (88bac07) will increase coverage by 0.56%.
The diff coverage is 74.07%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@            Coverage Diff             @@
##             main      #31      +/-   ##
==========================================
+ Coverage   72.37%   72.94%   +0.56%
==========================================
  Files          13       14       +1
  Lines         286      292       +6
==========================================
+ Hits          207      213       +6
  Misses         79       79

Impacted Files
Coverage Δ

src/cosmology/api/extras.py
70.83% <70.83%> (ø)

src/cosmology/api/__init__.py
100.00% <100.00%> (ø)

src/cosmology/api/standard.py
84.21% <100.00%> (+10.52%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ntessore, ready for review.
One thing I've considered changing w.r.t astropy is inv_efunc to efunc_inv. I think this makes the relationship to efunc more explicit. What do you think? Also is efunc a good name? What would be a better alternative?

What are your thoughts on HasTcmb requiring (or not) HasPhotonComponent ?

I don't see a benefit to requiring it. It might not be exposed by the underlying cosmology object, similar to the point of this PR.

One thing I've considered changing w.r.t astropy is inv_efunc to efunc_inv. I think this makes the relationship to efunc more explicit. What do you think? Also is efunc a good name? What would be a better alternative?

I find both inv_efunc and efunc_inv poor choices because it makes me think that is an inverse function returning a redshift given a value. Also, what's the computational advantage of having it? I can only think of sticking it directly into a numerical quadrature, but if a cosmology implementation wants to do that internally, the method doesn't have to be exposed.

When mypyc has fixed some issues with runtime-checkable protocols (in their radar) we can compile this whole library into c-wheels. Long term, speed will never be an issue.

I don't see a benefit to requiring it. It might not be exposed by the underlying cosmology object, similar to the point of this PR.

SGTM

I find both inv_efunc and efunc_inv poor choices because it makes me think that is an inverse function returning a redshift given a value. Also, what's the computational advantage of having it? I can only think of sticking it directly into a numerical quadrature, but if a cosmology implementation wants to do that internally, the method doesn't have to be exposed.

For v0.1 we can remove inv_efunc. Punt the decision down the road a bit.
What about the name efunc?

For v0.1 we can remove inv_efunc. Punt the decision down the road a bit. What about the name efunc?

Sounds good. I don't know of any other, more recognisable name for efunc. CCL calls it h_over_h0 but I don't find that better.

For v0.1 we can remove inv_efunc. Punt the decision down the road a bit. What about the name efunc?

Sounds good. I don't know of any other, more recognisable name for efunc. CCL calls it h_over_h0 but I don't find that better.

We have H for the Hubble Parameter. What about EH?

For v0.1 we can remove inv_efunc. Punt the decision down the road a bit. What about the name efunc?

Sounds good. I don't know of any other, more recognisable name for efunc. CCL calls it h_over_h0 but I don't find that better.

We have H for the Hubble Parameter. What about EH?

Those uppercase function names violate PEP 8 and look like constants, so that makes efunc superior in my opinion.

Those uppercase function names violate PEP 8 and look like constants, so that makes efunc superior in my opinion.

😮💨. Yeah, it's a problem with H, but thankfully not H0. My issues with efunc are that it feels silly to name a function func, even more so when it's technically a method.


[SB-1199] Add a v6 migration guide

@KtorZ - I apologize for not mentioning this earlier but there is something I'd like to clarigy about the Ogmios transition doc. The doc says that, for transactions, both witness.bootstrap and witness.signatures in v5 are equivalent to signatories in v6. Can you clarify that this is correct? I didn't do an exhaustive search but it looks like witness.signatures can be ignored. Here's an example. Am I missing something?
v5
                            "signatures": {
                                "9ef2c915feb819c3fc215f8d46c6e9df314ac3fa226d07a6d02e1093a6362e33": "5fa2f01a8482b8b9223a99a5497ee5f72950aae24fde9b8cd9edc65dc49109a854b07f475b03d7e541763b0797fe93cc5f7ed24d72a6d4a71a3adf8b40b5313b",
                                "6a5f97df4ef57702b68d5df7c2154b8fdac94ffeed9a6fa4d4bdcd619645ce1b": "db70bc723d2a7d471a5e4fea1008dd10f9c56e76a278f52297c67270fdc2a435628296523ca68c90cb2da1b06681f0573ac633047e9a939558c43accc674057a",
                                "27a574b32ac79a8b4e8cf5d79ef5dd481b0f7cbf086ed2df343f2e59d00c9956": "9d27bc1a6ac8e012a57d0b31a5aad6c616cf69f20d4f30c952704e308c35bbee4db6a2322d7c17730d84f2605fa586adf4de071ecd7ff7ffbaf5a6cb661fba08"
                            },
                            "bootstrap": [
                                {
                                    "key": "317b5aa592ba7d2501a677d04a3cd3899dc4c86aba0536f04a640e6443d9a881",
                                    "signature": "60477a7ae9d33e05eb4614534379e707b306aa9f87be42d39678769240fd6da02f125d4c8ccb210500c02bd6d5b5bc4f049b5dfcd1779dd6869f5007d59b33a7",
                                    "chainCode": "96",
                                    "addressAttributes": "93"
                                },
                                {
                                    "key": "b923c06f24b2654c75bb9bbea4bc458006e312c766bc89b0ed6747e553d05146",
                                    "signature": "69787974706f776b66716c62706b6b7563656c67716462626d666a7a6b767a636c67717775786f76646765616c776b72707464697066636f646471686c6d676c",
                                    "chainCode": "310e",
                                    "addressAttributes": "9b"
                                }
                            ],

v6:
                    "signatories": [
                        {
                            "key": "7f2cc631aa6cc2c5241e4191c088cff8809e29cef1bf32f674ac0382e185ac9b",
                            "signature": "5cf000fae51cb31f443b0bcf286c1f3c2ca4318c2de48bc22c863fdcb25a44ae41148a3ff75981e0e70590ea57d6f2ca579df6ba3fcf94836731ee667139fb94",
                            "chainCode": "a0"
                        },
                        {
                            "key": "8e9e471972bfa659af4b6eb2360c189d8bbf4dd5011eda3669644a6f42573a7d",
                            "signature": "1143edd821747126ccb1f43516409cedbc8b99f4a73c0a80b51a6f973cecb0bf8189604e5ad71361593124e38d8f5f37f2b8ecce01891924431ef5e8a3568a7a",
                            "chainCode": "b245",
                            "addressAttributes": "a38d"
                        }
                    ,

Thanks!


chore: new release

Added

#499

Approved.
[Sign-In With Ethereum Delegate Manager App] was tested properly. The app works as expected
A tx was created using
Safe Claiming App
Tx Builder App
WalletConnect app
as smoke testing for these apps, as a dependency update was done for them


Feature: Ability to know when Websocket connected successfully (i.e. optional, user-defined event handlers for lifecycle visibility)

Motivation and Use Case
With a regular web socket class, I'd define an 'open' event handler and invoke resolve within it (see example).
This allows me to use await with connectToFeed() in a meaningful way because the connectToFeed() promise only resolves when the web socket is established successfully.
  // within my class
  connectToFeed(): Promise<void> {
    return new Promise((resolve, reject) => {

      const connectionTimeout = setTimeout(() => {
        reject(new Error("WebSocket connection timeout (5s)"));
      }, 5000);

      this.ws = new WebSocket("...");
      this.ws.addEventListener("message", (message) => {
        console.info(message);
      });
      this.ws.addEventListener("open", () => {
        console.info("WS connected");
        clearTimeout(connectionTimeout);
        resolve();  // <<<<<<<<<<<<<<<<< here
      });
      this.ws.addEventListener("close", () => {
        console.info("WS closed");
      });
      this.ws.addEventListener("error", (error) => {
        console.error("WS error", error);
        reject(error);
      });
    });
  }

Current behavior
However, this library does not allow the end user to know when the websocket connection was established successfully.
  // within my class
  connectToWSPublic(): Promise<void> {
    return new Promise((resolve, reject) => {
      const publicTransport = new hl.WebSocketTransport({
        url: "wss://api.hyperliquid.xyz/ws",
        timeout: 10_000,
      });

      this.wsPublic = new hl.PublicClient(publicTransport);

      // Not a valid way to use resolve b/c it does not wait for a successful websocket
      // connection before resolving.
      resolve();
    });
  }

Possible solution
Allow optional, user-defined callback handlers for lifecycle events (the transport object can run its existing logic for these handlers, but also check if the defined callback function exists--using typeof onOpen === 'function'--and invoke it if defined.)
Which leads me to then think that user-defined onOpen, onClose, and onError events are probably the solution b/c this solves a related issue, which is the library does provide visibility into the lifecycle of the web socket connection, which would achieved by allowing a user to define custom callbacks and add their desired console log, or whatever they may need, there.
(I did not mention onMessage, b/c for the PublicClient and WalletClient, their expected behavior is of the library to handle 'message' events; but your upcoming web socket event subscription class might be solved just by user to define their own send() method and onMessage() handler for the reconnecting class.)

I agree, I missed that point. Background initialization of WebSocket may not suit everyone. Also, because of the "protected" variable modifier, you can't interact with the socket from under the transport without ignoring the TypeScript warning.
I propose to add a new method in WebSocketTransport "ready" which waits for connection opening, and also change the modifier of socket variable from "protected" to "readonly". I consider proxying "onOpen", "onClose" and "onError" from socket to WebSocketTransport unnecessary.
Do you have any objections or suggestions regarding my solution?

yeah, onOpen or ready is most important.
To illustrate the use case for the others, onClose or onError would allow an app to handle the lifecycle in different ways, like disabling trading until reconnected or sending a message to a a database for visibility into the app state. For now, I can live without these, but can see how they might be useful.


IconService.HttpProvider is not a constructor, while using with node js es5.

I am facing this issue, while using with express app, es5 but no any issue working with es6 React app.

try
const IconService = require('icon-sdk-js').default;
const HttpProvider = IconService.HttpProvider;

Getting this issue again.
Cannot read properties of undefined.

try
const IconService = require('icon-sdk-js').default;
const HttpProvider = IconService.HttpProvider;

Node version:
16.13.0
Npm version:
8.5.0

Icon-sdk-js does not support es5.


[Paimon-682][Improvement]Support schema validation when invoke create sch…

…ema.
https://github.com/apache/incubator-paimon/issues/682
Purpose
(What is the purpose of the change, or the associated issue)
Tests
(List UT and IT cases to verify this change)
API and Format
(Does this change affect API or storage format)
Documentation
(Does this change introduce a new feature)

Thanks @hk-lrzy , we need to add tests for the validation

The e2e test fails du to an exist issue
Thanks @hk-lrzy LGTM +1


Please keep Install directory synced with release assets

Assets in 3.4 release don't match with 3.4 tag.
3.4 tagged:
$ md5sum Install/driver/*
d863785c9e4be2f7507a2920d7264a6f  Install/driver/scream.cat
3c9b55d6d981ff9525488042bf04b8f2  Install/driver/Scream.inf
ac9c1a464b53805ca8813ec333d8e7a0  Install/driver/Scream.sys

assets from release 3.4:
$ md5sum Install/driver/*
3b57f01d11361a9dcc5f5da162cdcf7f  Install/driver/scream.cat
41ffe89383e643f2266dfebe33e1dd69  Install/driver/Scream.inf
95cf29f9cd747e35b6bc7796eed219fb  Install/driver/Scream.sys

Yeah, my workflow does not respect the fact that Github tags master with release tags.
The "master" branch was actually in sync with the lastest released version, but the "3.4" tag wasn't. I've now moved the tag. I'll keep this in mind for future releases.


CRAN link on landing page

On the landing page here

Pypi links to where you can find packages, but the link for CRAN goes to the R project landing page. Perhaps link to https://cran.rstudio.com/web/packages/, which seems closer match to the pypi link
Or, there's also http://www.r-pkg.org/ - a 3rd party R pkg UI that's not based on 1990's best practice from @gaborcsardi

:)

It's not 1990s best practice, it's vintage, man. #hipstercode.

oh right, that


Specify which permissions are required for the macaroon

Document what macaroon permissions are required.

Description
The wiki documentation should contain the exact set of macaroon permissions required by the app.

Context
Users could use a more restricted macaroon instead of the admin.macaroon. The aim would be improved security and transparency.

@juhi24 BitBanana supports macaroon reading. Depending on what macaroon you put in, the UI will automatically be adapted and hide or disable some functionality.
If you use a read only macaroon for example, the send button will be greyed out. Etc.
But you are right, this could be documented.


Integration Blockchain Name Service with Enigma secret auction

Checklist

[x] Registry
[x] Registrar
[x] Secret auction

[x] AuctionFactory
[x] AuctionPricer

PortalNetwork/engns-demo


fix: update create-starknet to use starknet-react v1

Current dependencies on/for this PR:

main

PR #270

PR #271   👈

This comment was auto-generated by Graphite.


terragrunt: 0.51.7 -> 0.52.0

Description of changes
change log: https://github.com/gruntwork-io/terragrunt/releases/tag/v0.52.0
diff: https://github.com/gruntwork-io/terragrunt/compare/v0.51.7...v0.52.0

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.


Error message when attempting to merge files

I get the following error message when trying to merge. it says "unable to get the modification date of video" . i have tried moving the files to my C drive and desktop and that didn't help either. also doesn't give me the ability to click on the three dots in settings to change file output path. THanks brother!

HI, please complete the template for bugs to be able to investigate the case.
Template: https://github.com/rubegartor/ReelSteady-Joiner/blob/master/.github/ISSUE_TEMPLATE/bug_report.md
Thanks!

Hey bro! a reinstall fixed the issue! i think i had not let my PC restart when i installed it first which caused this. Although there seems to be another major problem with the processed video. SHould i open a new ticket? or continue in this one?

Open a new one with the bug template.


Don't repeat response code twice

https://github.com/Snawoot/hola-proxy/pull/26#issuecomment-797764325

Thanks!


shimgen errors causing successful package installation to fail

We're installing some software that is being installed via chocolatey/powershell as part of our Packer build process. While the software is being completely and successfully installed, shimgen is throwing some errors that ultimately get reported back to packer as exit 1 causing the whole build to fail. Here's a sample of the error:
Calling command ['"C:\ProgramData\chocolatey\tools\shimgen.exe" --path="..\\lib\xboxgdk\tools\Installers\powershellStub.exe" --output="C:\ProgramData\chocolatey\bin\powershellStub.exe"  --iconpath="C:\ProgramData\chocolatey\lib\xboxgdk\tools\Installers\powershellStub.exe"']
2021-03-17 14:34:53,513 5004 [DEBUG] -  [ShimGen] [WARN ] Could not extract icon from associated program. Using default. Error:
2021-03-17 14:34:53,513 5004 [DEBUG] -  [ShimGen]   Selected Icon is invalid
2021-03-17 14:34:53,700 5004 [DEBUG] -  [ShimGen] Microsoft (R) Visual C# Compiler version 4.8.3761.0
2021-03-17 14:34:53,700 5004 [DEBUG] -  [ShimGen] for C# 5
2021-03-17 14:34:53,700 5004 [DEBUG] -  [ShimGen] Copyright (C) Microsoft Corporation. All rights reserved.
2021-03-17 14:34:53,700 5004 [DEBUG] -  [ShimGen] This compiler is provided as part of the Microsoft (R) .NET Framework, but only supports language versions up to C# 5, which is no longer the latest version. For compilers that support newer versions of the C# programming language, see http://go.microsoft.com/fwlink/?LinkID=533240
2021-03-17 14:34:53,700 5004 [DEBUG] -  [ShimGen] c:\ProgramData\shimgen\generatedfiles\20210317_143453_3570\Assembly.cs(6,29,6,43): error CS1026: ) expected
2021-03-17 14:34:53,700 5004 [DEBUG] -  [ShimGen] c:\ProgramData\shimgen\generatedfiles\20210317_143453_3570\Assembly.cs(7,2,7,10): error CS1730: Assembly and module attributes must precede all other elements defined in a file except using clauses and extern alias declarations
2021-03-17 14:34:53,700 5004 [DEBUG] -  [ShimGen] c:\ProgramData\shimgen\generatedfiles\20210317_143453_3570\Assembly.cs(7,31,7,32): error CS0116: A namespace cannot directly contain members such as fields or methods
2021-03-17 14:34:53,700 5004 [DEBUG] -  [ShimGen] c:\ProgramData\shimgen\generatedfiles\20210317_143453_3570\Assembly.cs(7,35,7,49): error CS1026: ) expected
2021-03-17 14:34:53,700 5004 [DEBUG] -  [ShimGen] c:\ProgramData\shimgen\generatedfiles\20210317_143453_3570\Assembly.cs(8,2,8,10): error CS1730: Assembly and module attributes must precede all other elements defined in a file except using clauses and extern alias declarations
2021-03-17 14:34:53,700 5004 [DEBUG] -  [ShimGen] c:\ProgramData\shimgen\generatedfiles\20210317_143453_3570\Assembly.cs(9,2,9,10): error CS1730: Assembly and module attributes must precede all other elements defined in a file except using clauses and extern alias declarations
2021-03-17 14:34:53,700 5004 [DEBUG] -  [ShimGen] c:\ProgramData\shimgen\generatedfiles\20210317_143453_3570\Assembly.cs(10,2,10,10): error CS1730: Assembly and module attributes must precede all other elements defined in a file except using clauses and extern alias declarations
2021-03-17 14:34:53,700 5004 [DEBUG] -  [ShimGen] c:\ProgramData\shimgen\generatedfiles\20210317_143453_3570\Assembly.cs(11,2,11,10): error CS1730: Assembly and module attributes must precede all other elements defined in a file except using clauses and extern alias declarations
2021-03-17 14:34:53,700 5004 [DEBUG] -  [ShimGen] c:\ProgramData\shimgen\generatedfiles\20210317_143453_3570\Assembly.cs(12,2,12,10): error CS1730: Assembly and module attributes must precede all other elements defined in a file except using clauses and extern alias declarations
2021-03-17 14:34:53,700 5004 [DEBUG] -  [ShimGen] c:\ProgramData\shimgen\generatedfiles\20210317_143453_3570\Assembly.cs(13,2,13,10): error CS1730: Assembly and module attributes must precede all other elements defined in a file except using clauses and extern alias declarations
2021-03-17 14:34:53,700 5004 [DEBUG] -  [ShimGen] c:\ProgramData\shimgen\generatedfiles\20210317_143453_3570\Assembly.cs(14,2,14,10): error CS1730: Assembly and module attributes must precede all other elements defined in a file except using clauses and extern alias declarations
2021-03-17 14:34:53,700 5004 [DEBUG] -  [ShimGen] c:\ProgramData\shimgen\generatedfiles\20210317_143453_3570\Assembly.cs(15,2,15,10): error CS1730: Assembly and module attributes must precede all other elements defined in a file except using clauses and extern alias declarations
2021-03-17 14:34:53,700 5004 [DEBUG] -  [ShimGen] c:\ProgramData\shimgen\generatedfiles\20210317_143453_3570\Assembly.cs(17,2,17,10): error CS1730: Assembly and module attributes must precede all other elements defined in a file except using clauses and extern alias declarations
2021-03-17 14:34:53,700 5004 [DEBUG] -  [ShimGen] c:\ProgramData\shimgen\generatedfiles\20210317_143453_3570\Assembly.cs(18,2,18,10): error CS1730: Assembly and module attributes must precede all other elements defined in a file except using clauses and extern alias declarations
2021-03-17 14:34:53,700 5004 [DEBUG] -  [ShimGen] c:\ProgramData\shimgen\generatedfiles\20210317_143453_3570\Assembly.cs(19,2,19,10): error CS1730: Assembly and module attributes must precede all other elements defined in a file except using clauses and extern alias declarations
2021-03-17 14:34:53,700 5004 [DEBUG] -  [ShimGen] [ERROR] ShimGen had an issue creating 'C:\ProgramData\chocolatey\bin\powershellStub.exe'. Please check the logs above.

We're using choco 0.10.15, software is being installed on WS2019. Let me know if you need any more info!
┆Issue is synchronized with this Gitlab issue by Unito

Based on some changes happening to the Chocolatey repositories, this issue has been moved from the chocolatey/shimgen repository to the chocolatey/home repository.

Ran into the same issue, make sure that choco is properly installed on the machine.
Can you run choco from the command line?


Fix Dependabot alerts for CVE-2022-28948

Related https://github.com/dnaeon/go-vcr/issues/70

The CVE is in yaml.v3, however we are using yaml.v2.  The CVE was incorrectly flagged in v2 which has since been fixed.


GDScript member class changes type.

Godot version:
3b4fad435c2856398f87b6f010013ce1a114b31b
OS/device including version:
Fedora 33
Issue description:
The member type test_object changes its type from Node to bool when this statement is executed if test_object and true:.
extends Node

var test_object: Node = null

func _ready():
	test_function(null)

	# This changes `test_object` type to bool.
	if test_object and true:
		print("At this point the variable type is changed from `Node` to `bool`.")

	# This will cause an error because you can't compare bool with a `Nil`
	test_function(null)

func test_function(obj):
	if test_object == obj:
		return
	test_object = obj

Steps to reproduce:

Put the above code into a script
Play the scene
The GDScript VM will complaing the second time test_function is executed.

Minimal reproduction project:
TestOperatorIssue.zip

Not reproducible on master (85186bc).


jellyfin throws error on launch when using .p12 for HTTPS support

I have jellyfin server portable running on my Windows 7 machine for a couple of months testing it out. I do not have a reverse proxy. It was working perfectly fine with HTTPS (default port 8920 and port forwarding on my network) using the .p12 file I supplied it which was generated using ACME client.
However since the original cert expired, I updated it and now I cannot get it to work with HTTPS at all. This is what I am seeing in the console when launching the server.
[03:03:51] [ERR] [1] Emby.Server.Implementations.ApplicationHost: Error loading cert from C:\Portable Software\jellyfin\jellyfin.pfx
Internal.Cryptography.CryptoThrowHelper+WindowsCryptographicException: The specified network password is not correct.
   at Internal.Cryptography.Pal.CertificatePal.FilterPFXStore(ReadOnlySpan`1 rawData, SafePasswordHandle password, PfxCertStoreFlags pfxCertStoreFlags)
   at Internal.Cryptography.Pal.CertificatePal.FromBlobOrFile(ReadOnlySpan`1 rawData, String fileName, SafePasswordHandle password, X509KeyStorageFlags keyStorageFlags)
   at System.Security.Cryptography.X509Certificates.X509Certificate..ctor(String fileName, String password, X509KeyStorageFlags keyStorageFlags)
   at System.Security.Cryptography.X509Certificates.X509Certificate2..ctor(String fileName, String password, X509KeyStorageFlags keyStorageFlags)
   at Emby.Server.Implementations.ApplicationHost.GetCertificate(String path, String password)

I have tried using a cert password, no password, generating the .p12/.pfx file through openssl (using the .key and .crt files from acme client) and even creating a self signed p12/pfx. I am always seeing this error now when starting the server with a p12/pfx loaded. I also verified the .p12, .key and .crt files were valid using openssl.
What could be causing this?

I realize now that this would have been a better question for the main repository, but I also don't believe that Windows 7 is officially supported anymore. I don't think it has for a long time to be honest.


Fix echo/logprob OpenAI completion bug

Fixes #2703 and allows echo to be used with a list of tokens

@ywang96 Thanks for the recommendations!

I've noticed flaky behaviour in buildkite/ci/pr/entrypoints-test and buildkite/ci/pr/lora-test today. According to the history of main branch, this started happening since this PR was merged.


Test stubs

Description
This stubs out most of the tests for assignments three, four, and five. A few tests are left in, but all of them fail until a line or two is removed. There are also some new comments and rabbit holes.
Check List

[ ] All test passed
[ ] Any new functionality or fixes you added is covered by new tests

All the tests are supposed to fail. Still feels weird...

This looks really clean to me. I like the test renames.


Mat/Pat - Editing form after leave start

Reconsider the rules for editing form after leave starts for supervisor and applicant.
Details TBD

duplicate


Adapt docs to PennyLane theme

This updates the Forest device docs to reflect the general setup of the PL theme.
Benefits
The new structure shows one page per device. I tried to update code and all links (many were broken) as much as I could, but did not re-run every code sample.
Drawbacks
There were automodapi errors stemming from the __init__ file importing the T, S, CSWAP and CCNOT gates, which are actually no longer defined in the ops module (since PL supports them now). I deleted these imports, since a user should not import the gates from the plugin anyways.
Note
The PR is best reviewed by building the docs.

Just noticed that the puzzle image looks a bit weird on my screen. Seems like it might be an alpha channel, with the grey parts removed (I think they're transparent, and thus not visible on white background), also leaving a minor black spot at the bottom.
Could be nice to fix, although this could also be something that affects the puzzle image in other places.

Just noticed that the puzzle image looks a bit weird on my screen. Seems like it might be an alpha channel, with the grey parts removed (I think they're transparent, and thus not visible on white background), also leaving a minor black spot at the bottom.
Could be nice to fix, although this could also be something that affects the puzzle image in other places.

 But should be better now! Thanks for picking that up.

@thisac thanks for pointing out all the other broken links! @antalszava I'm also not sure...this PR was just intended to move to the new theme (and doing minimal content updates), but you are right, we should revisit the entire docs. I don't think I'll have time to do that. Shall we merge this one and make a new ticket for the content update? It will be much easier to review!

Great, if @thisac also approves feel free to merge... :)

I've activated readthedocs PR builds for this repo 👍

[ch1980]


Refs #123746

Added ImageView/FileView customizations so that description no longer results in error when it is an object.

@Petchesi-Iulian Please use volto-ims-policy for this kind of monkey-patches / customizations.
Also, please commit in two steps in order to easily see changes:

Commit original file
Commit changes

Moved to https://github.com/eea/volto-ims-policy/pull/6


Multiple IServer implementations in the same app

Hello folks,
I'm sorry if this is a noob question, but i'm looking at ways to make an asp.net core application available both over regular http as well as via a custom server. i'd like both servers to pipe into the "same" application so that they share di and any other state that comes with the host if possible.
Basically I want to be able to process requests coming in both over http and from somewhere else, (in my case in memory but could be from anywhere)
As far as I understand, the best way to do this is to implement IServer on my own custom server and do a UseServer() with that, but since I also want to have kestrel listen to requests, I've been thinking I should make a wrapper IServer implementation that starts both my server and kestrel.
Is this line of thinking correct or is there a better/ built in way to do this? as far as I understand there can only be one IServer implementation registered

You're right on all counts.
Don't worry about using UseServer, it takes an instance. Directly registering with DI will make it easier for you to resolve services.

Great :)
Is there anything else to think about with the move to generic host in .net core 3? Following some prs and digging though the code I've gathered that a web app is just a HostedService in the new model, is it still the case that IServer is a Singleton or is it scoped?
(Or actually, maybe you can already register IServer as scoped today and just create a scope for each server?)

No, IServer is still a singleton in the new generic host scenario.

Cool np, thanks for the info!
I ended up with this as a poc, perhaps it will be of use to someone :)
public class Program
{
    public static Task Main(string[] args) =>
        WebHost.CreateDefaultBuilder(args)
        .UseKestrel()
        .UseMultiServer<KestrelServer, TestServer>()
        .UseStartup<Startup>()
        .Build()
        .RunAsync();
}

public class MultiServer<TServer1, TServer2> : MultiServer, IServer where TServer1 : IServer where TServer2 : IServer
{
    public MultiServer(TServer1 server1, TServer2 server2) : base(new IServer[] { server1, server2 }) { }
}

public class MultiServer : IServer
{
    public IServer[] Servers { get; }
    public IFeatureCollection Features { get; set; } = new FeatureCollection();

    public MultiServer(IServer[] servers)
    {
        Servers = servers;
        foreach (var f in servers.SelectMany(s => s.Features))
            Features[f.Key] = f.Value;
    }

    public Task StartAsync<TContext>(IHttpApplication<TContext> application, CancellationToken cancellationToken) =>
        Task.WhenAll(Servers.Select(s => s.StartAsync(application, cancellationToken)));

    public Task StopAsync(CancellationToken cancellationToken) =>
        Task.WhenAll(Servers.Select(s => s.StopAsync(cancellationToken)));

    public void Dispose()
    {
        foreach (var s in Servers)
            s.Dispose();
    }
}

public static class ServerExtensions
{
    public static IWebHostBuilder UseMultiServer<TServer1, TServer2>(this IWebHostBuilder hostBuilder) where TServer1 : class, IServer where TServer2 : class, IServer =>
        hostBuilder.ConfigureServices(services =>
        {
            services.AddSingleton<TServer1, TServer1>();
            services.AddSingleton<TServer2, TServer2>();
            services.AddSingleton<IServer, MultiServer<TServer1, TServer2>>();
        });
}

public class TestServer : IServer
{
    public Task StartAsync<TContext>(IHttpApplication<TContext> application, CancellationToken cancellationToken) => Task.CompletedTask;
    public Task StopAsync(CancellationToken cancellationToken) => Task.CompletedTask;
    public IFeatureCollection Features { get; } = new FeatureCollection();
    public void Dispose() { }
}


tablet loads views instead of views_mobile when views_tablet is not present

Is there any way to load views_mobile as the tablet layout when views_tablet is not present?
At this point, when views_tablet is not present, the templates in views get loaded; the only way around this is to have both views_tablet and views_mobile with the same exact files, which creates redundancy.
I couldn't find any reference on how to achieve this in the docs, any info would be appreciated.
Thanks

I can think of two ways to do this. I haven't tested either, but I don't see why they wouldn't work.
Use partials
You could put the common view code in partials in app/views/, such as app/views/mobile/foo/_index.html.erb. Then your app/views_mobile/foo/index.html.erb and app/views_tablet/foo/index.html.erb could both just be
<%= render "mobile/foo/index" %>

They would still be duplicate files, but at least they would be one liners.
Override tablet_views_path
You can override tablet_views_path in any controller to build the view path you want. See https://github.com/neighborland/mobu/blob/799d0630394d10dbf995ff01a259fd2af8f78eb6/lib/mobu/detect_mobile.rb#L38. Something like
def tablet_views_path
  path = [Rails.root + 'app' + 'views_tablet', Rails.root + 'app' + 'views_mobile']
  @@tablet_views_path ||= [Rails.root + 'app' + 'views_tablet'
end

Hello,
Thanks for the tip. I ended up forking your project and managed to get it to work as I needed an urgent solution for a project I was working on.
I appreciate you creating the gem in the first place, very useful!


Merge in changes to release

For the kernel/server name fix and the changelog changes I made for the recent release.

Codecov Report

Merging #13976 into release-2020.09 will decrease coverage by 0.03%.
The diff coverage is 7.14%.

@@                 Coverage Diff                 @@
##           release-2020.09   #13976      +/-   ##
===================================================
- Coverage            59.87%   59.84%   -0.04%
===================================================
  Files                  693      693
  Lines                38345    38350       +5
  Branches              5514     5518       +4
===================================================
- Hits                 22958    22949       -9
- Misses               14207    14218      +11
- Partials              1180     1183       +3

Impacted Files
Coverage Δ

...ient/datascience/interactive-ipynb/nativeEditor.ts
7.78% <ø> (ø)

src/client/datascience/jupyter/kernels/helpers.ts
34.23% <0.00%> (-0.63%)
:arrow_down:

src/datascience-ui/interactive-common/mainState.ts
57.14% <ø> (ø)

.../datascience/interactive-common/interactiveBase.ts
5.77% <9.09%> (-0.03%)
:arrow_down:

src/client/datascience/crossProcessLock.ts
79.41% <0.00%> (-11.77%)
:arrow_down:

src/client/common/utils/platform.ts
60.00% <0.00%> (-8.00%)
:arrow_down:

src/client/linters/pydocstyle.ts
86.66% <0.00%> (-2.23%)
:arrow_down:

src/client/datascience/debugLocationTracker.ts
76.56% <0.00%> (-1.57%)
:arrow_down:

src/client/common/process/proc.ts
14.49% <0.00%> (-0.73%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 411aae9...6cdf00a. Read the comment docs.


Add new service Prostgredb.

Would be good to have Postgre and pgAdmin to be available as a service. Some of the script we have are DB driven,

[x] add PostgreDB service extract from https://www.enterprisedb.com/download-postgresql-binaries
[x] add pgAdmin4 python service https://www.pgadmin.org/download/pgadmin-4-python/

done


[cpp con] add cpp concurrent

first cpp concurrent version

this looks like a "specific adjustment" :)
char padding[2 * CACHE_LINE_SIZE - 88];

it's not, cpp needs to manually adjust struct size to be multiple of cache line size for concurrent processing, it is to avoid false sharing
btw please use clang++ for concurrent

C++ code currently is not assigning top5 posts into resulted array (relatedPosts). Please check @jinyus

relatedPost.related[upperBound + 1] = &posts[j];
seems like an optimization.
@cyrusmsk

Oh it is using references. I haven’t noticed that. Thnx

fyi, this is unsafe: posts[j]


[FZ Editor] Show both native and scaled monitor dimensions

The monitor tooltip shows the scaled dimensions:

Let's add the native resolution as well using labels to explain the values:

Native 1920x1080
Scaled 1280x720

I'm assuming we have the scaling value as well? I'd add that to the native resolution: 1920 x 1080 (200%)

@niels9001
not sure it's necessary, what is necessary is to put the explicit scaled value because we will allow to define canvas layout for scaled resolutions and they will only be applicable to monitors with the same scaled value.

Scaling enlarges UI, it does not decrease the actual resolution. Therefore are not the way to think of this. Niels has a simple and perfectly correct solution! 👍

not sure it's necessary, what is necessary is to put the explicit scaled value because we will allow to define canvas layout for scaled resolutions and they will only be applicable to monitors with the same scaled value.

Disgree. I've seen many confused comments about wrong resolutions.


Issue with composite primary key

Hi,
I'm using your bundle with Symfony 2 and Doctrine and I have an entity with a composite primary key where one of it is another entity:
class MyClass
{
    /**
     * @var Project\MyBundle\Entity\MyEntity
     * @ORM\Id
     * @ORM\ManyToOne(targetEntity="Project\MyBundle\Entity\MyEntity", inversedBy="MyClass")
     * @ORM\JoinColumn(name="my_entity_id", referencedColumnName="id")
     */
    private $myEntity;
    /**
     * @var integer
     * @ORM\Id
     * @ORM\Column(name="my_integer", type="integer")
     */
    private $myInteger;
...
}

The issue here is when i try to delete 'MyClass' i get this exception :
Warning: spl_object_hash() expects parameter 1 to be object, string given in vendor/doctrine/orm/lib/Doctrine/ORM/UnitOfWork.php at line 1540
After investigation it seems that in the final array_merge() in onFlush() from the listener SimpleThings\EntityAudit\EventListener\LogRevisionsListener,  the object'myEntity' is replaced by the value of its id and therefore doctrine can't save it :
$entityData = array_merge($this->getOriginalEntityData($entity), $this->uow->getEntityIdentifier($entity));
I tried to change the order of the merge :  $entityData = array_merge($this->uow->getEntityIdentifier($entity),$this->getOriginalEntityData($entity)); and it worked for my case. Is there a particular reason for this merge to have this specific order or can it be changed ?
For the same reasons, it seems the postFlush() function throws an error because of how the SQL code is built for the extra updates.  $columnName is assumed to always be a string while in my case it is an array.
Thank you.

@RomainCXP are u still using this bundle? did  you fork it to make that changes? im having the same issue


Active Sync: Presto query stuck at querying old file after overwriting files directly on HDFS

Alluxio Version:
2.2.1
Describe the bug
bin/alluxio fs startSync /user/hive/warehouse/test.db/xiangqun_test5
After enabling active sync, every time after I overwrite the above folder, the query will be stuck for a few minutes getting the old file(the deteled file) and raise error as follows:
Error opening Hive split alluxio://<IP_ADDRESS>:19998/user/hive/warehouse/test.db/xiangqun_test5/part-00000-abb0bba1-341e-49f9-b6aa-fe0a6fa03d05-c000.snappy.parquet (offset=0, length=756): Failed to read block ID=83886080000 from tiered storage and UFS tier: File does not exist

To Reproduce

Create a table with a folder.
Enable active sync for that path
Overwrite the folder directly on HDFS with e.g. spark.
Query the table.

Expected behavior
Query returns the updated data without duplications or errors.
Urgency
Describe the impact and urgency of the bug.
Additional context
Add any other context about the problem here.

Thanks for filing the issue to help us track this better.
Could you also attach your presto configuration, specifically your hive connector config?

connector.name=hive-hadoop2
hive.metastore.uri=thrift://metastore_server:9083

hive.metastore.username=presto
hive.metastore.user.rpcpassword=******

hive.max-initial-splits=300
hive.max-initial-split-size=64MB
hive.max-split-size=128MB
hive.max-outstanding-splits=1000
hive.max-outstanding-splits-size=1GB
hive.max-split-iterator-threads=1000
hive.metastore-timeout=1m
hive.metastore.partition-batch-size.min=20
hive.metastore.partition-batch-size.max=200
hive.config.resources=/etc/presto/core-site.xml,/etc/presto/hdfs-site.xml
hive.dfs-timeout=1m
hive.dfs.connect.timeout=30s
hive.storage-format=PARQUET
hive.compression-codec=SNAPPY
hive.parquet.use-column-names=true
hive.parquet.fail-on-corrupted-statistics=false
hive.non-managed-table-writes-enabled=true
hive.table-statistics-enabled=true
hive.ignore-corrupted-statistics=true

hive.security=file
security.config-file=/etc/presto/rules.json
security.refresh-period=5m

Hi @lxqfy sorry for the late response, is this still a valid issue? I think it should be resolved in newer version. Feel free to reopen it if it's not resolved.


[endpoints.mdx] update for hybrid mode

Description (required)
This page was written before hybrid mode existed, and none of the examples or explanation on this page mentions needing export const prerender = false for server endpoints.
This PR adds that extra context to the paragraph introducing server endpoints, and also calls this out in the note that the examples need an on-demand rendered mode.

Lunaria Status Overview
🌕 This pull request will trigger status changes.

Learn more
By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.
You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale
File
Note

en
guides/endpoints.mdx
Source changed, localizations will be marked as outdated.

Warnings reference

Icon
Description

🔄
The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

!coauthor


c-api/component-model: proof of concept

Zulip link
This is a proof of concept for the component model exposed in the C API. I mostly took the approach of "how would I want this to look in the C API" and let the rust implementation fall out from that. I think there are certainly improvements that could be made to the implementation that I will point out as review comments.
This is a draft to foster discussion, but I don't expect actually merge this.

Thanks for starting on this! I like the idea of the approach here to start with C/C++ APIs and kinda go from there. I want to point out some points though and provide some thoughts on what you've already implemented:

I'd recommend planning out resources pretty early on. They radically change a lot of things if they weren't previously accounted for so you'll want to make sure they're taken care of. (e.g. borrows, owns, etc)
Indices-vs-strings is an interesting question. I think it can go either way, but I additionally think we'll want the ability to inspect type information. For example the enum variant 2 is not the same across different enums. Additionally the enum variant name "foo" also isn't the same across enums. With type information though this can all be equated and the name and/or index can be "resolved" what its relative to.
I'm all for some sort of Val::new_unchecked but I've given it no thought as to what it would look like other than "that should probably exist and I have no idea what it would look like".

Drawing from the parallels of the C API for wasm there's sort of two modes for values - one where a value is tagged with its type and one where a value is "unchecked" and you assert it's the right type. That might be good to follow with components as well where what you've sketched out so far is the untagged/unchecked version so far (I know there's a tag for a kind but it's more of a discriminant than "this is the type of the value"). That'd roughly correspond to TypedFunc and Func in the Rust API sort of.

but I additionally think we'll want the ability to inspect type information.

Agreed, I've not spent time on this yet, but was planning on exposing this in a similar manner to wasmtime::component::Func.

two modes for values - one where a value is tagged with its type and one where a value is "unchecked" and you assert it's the right type.

Could you clarify this? I don't quite follow, there seems to only be the ability to call the dynamic function variants (wasmtime::Func) in the C API for wasm. I don't see anything that has the type attached, in fact any method call from host->guest does typechecking today AFAIK.
If you're talking about having TypedFunc support in the C-API, I think that's possible in the component model with some code generation and having a way to write a C struct directly into guest memory using the canonical ABI format.

Oh you are correct, no TypedFunc in the C API, I have no idea how that would work. I mean moreso wasmtime_func_call vs wasmtime_func_call_unchecked which is Func::call vs Func::call_unchecked. The latter isn't typed but additionally is unsafe since you assert that whatever you passed is the correct type.
The component model is trickier in this regard where it's not as obvious how a list of records with variants of strings should be laid out in memory (compared to a i32). One idea I've toyed with is that the "raw" version of the component model is the canonical ABI, not a structured value. That would put quite a burden on users of the component model, however, perhaps too much.

That would put quite a burden on users of the component model, however, perhaps too much.

Maybe, I mean there would have to be a codegen portion to think about here too. I'm not really sure how passing values back would work in this model.
Reguardless, I think that can come in a v2 and I'm going to focus on just supporting the wasmtime_func_call equivalent for the component model. The unchecked variant could be added for better performance if someone runs into it, but probably the better solution is to invest in figuring out how the TypedFunc variant would work in the C-API.

Makes sense yeah. In that sense I'd recommend ensuring that type information can be tagged on values at the same time, and that'll help a lot with resources and resolve the string-vs-index problem as well (aka always use an index and then the index is relative to what's in the type info)

Curiousity: why doesn't C and Golang use a static lib built from the Rust crate?

Curiosity: why doesn't C and Golang use a static lib built from the Rust crate?

It does (from the C API) - however all these languages don't have the same ABI, so C is common set of ABI all these languages speak


Needs update to support curl 7.64.1

When curl update to version 7.64.1, curl modified CURLE_SSL_CACERT in curl.h: L623
#define CURLE_SSL_CACERT CURLE_PEER_FAILED_VERIFICATION
caused a build error in cpr/error.cpp:
ErrorCode Error::getErrorCodeForCurlError(std::int32_t curl_code) {
...
        case CURLE_SSL_CACERT: //60
            return ErrorCode::SSL_CACERT_ERROR

        case CURLE_PEER_FAILED_VERIFICATION: //60
            return ErrorCode::SSL_REMOTE_CERTIFICATE_ERROR;
...

See more information:
install-x86-windows-dbg-out.log
Thanks.

I believe this is resolved by #296 which has already been merged, are you on master?


Major, Minor and Patch version parts as separate variables

Hi, additionally to the NBGV_MajorMinorVersion I would really like to have all the version parts available as separate (environment) variables.
Since (as I understand it) the version height doesn't have to be in the patch part of the version, all three would be preferable.
I need this primarily in a cloudbuild (via nbgv cloud -c -a) for docker tags ( 0.x, 0.1.x, 0.1.2), which is currently not possible without parsing the version via script.
I would like to request the feature that nbgv would set NBGV_Major, NBGV_Minor and NBGV_Patch.
As a bonus, the NBGV_PrereleaseVersion without the leading dash would also be welcomed.

This all sounds reasonable. I'll try to get this done over the next week or so. But anyone else is welcome to send a PR as well.

The properties (excluding the NBGV_ prefix) are:

VersionMajor
VersionMinor
BuildNumber (this was preexisting)
VersionRevision

The BuildNumber always represents the 3rd integer in the version. If you want the version/git height specifically, use VersionHeight, since as you say that may not appear as the 3rd integer.
I've also added a PrereleaseVersionNoLeadingHyphen property for you.

Sounds great, thank you so much!

Any ETA on a release? Would love to migrate my last projects, but they are blocked by this.


Issue with "XSOAR CI/CD" in @site/docs/reference/articles/xsoar-ci-cd.md

Describe the problem
The Overview video is not working.
Suggested fix
Video starts correctly.

We tested it and it works.
I have attached some pictures of the video.


Split up memcopy by architecture

This PR is the final result of my changes to break out architecture specific code into separate files.
This code moves all of the memory chunk copying code into their own files and utilizes functable to reference them.

Rebased and fixed issue with configure script.

Using @neuroblast pigz-bench-python c_decompress.py script I was able to get these performance results:
Method                  ms      mb/s
pigzCloudflare.exe      5167    216.72
pigzng.exe              4127    271.35
pigznmoinvaz.exe        4077    274.67

I ran it a few times. Sometimes ng and my branch equaled more closely, but other times it was equivalent to what is seen above.

@nmoinvaz your decompression results match up with my findings that zlib-ng provides superior decompression to Cloudflare or baseline zlib.
On the other hand, I do need to update the graphs to reflect the recent improvements in zlib-ng compression speed. I was hoping to update the repository when pigz built with zlib-ng supports compression level 1. That would change the lower graph in my repository, as zlib-ng uses a different strategy at level 1 than classic zlib.

I have fixed all the pigz issues for compression level 1 - it is just a matter of getting them merged into develop by @Dead2.

Rebased.

@Dead2 being able to split out compiler flags by file is important for performance testing. Because we don't know if our compiler flags for intrinsics support is changing other parts of the executable and leading to performance increase/decreases.

I agree completely.
I thought this PR was not ready yet, but I'll try to get some benchmarks done soon(TM).
I am working on setting up a dedicated machine for benchmarks, where one core is isolated from other processes, most kernel threads and interrupts. Deviation in the benchmarks is looking like it might be half of what it used to be, but I am not quite finished with it yet.

@mtl1979 any ideas what might be the issue with libpng CI?
 Testing /home/runner/work/zlib-ng/zlib-ng/libpng/pngtest.png:
 Pass 0: rwrwrwrwrwrwrwrwrw
 Pass 1: rwrwrwrwrwrwrwrwrw
 Pass 2: rwrwrwrwrwrwrwrw
 Pass 3: rwrwrwrwrwrwrwrwrwrwrwrwrwrwrwrwrwrw
/home/runner/work/zlib-ng/zlib-ng/libpng/pngtest.png: libpng warning: bad adaptive filter value
/home/runner/work/zlib-ng/zlib-ng/libpng/pngtest.png -> pngout.png: libpng read error

 Testing /home/runner/work/zlib-ng/zlib-ng/libpng/pngtest.png: FAIL

This LGTM bot is annoying.

Looks like problem is with AVX chunk implementation.

@nmoinvaz You can test that by changing __m256 to __m128. That essentially downgrades it from AVX2 to AVX.

It seems there are no _mm128_set functions..

Maybe mm_broadcastb..

Got it working. Appears chunk size is too big like I suspected.

Actually we already have SSE2 which is _m128i.

@Dead2 this is ready for review again.

Tests using configure, to check for regressions
Baseline ee28753685d62117f8ef4ef8b94ba101a5cd1e96
   text    data     bss     dec     hex filename
  93054    1304      32   94390   170b6 libz-ng.so.1

 Level   Comp   Comptime min/avg/max  Decomptime min/avg/max
 1      52.643%    0.173/0.177/0.180       0.102/0.111/0.118  16560094
 2      40.045%    0.343/0.348/0.353       0.104/0.115/0.118  12597075
 3      39.033%    0.441/0.450/0.454       0.105/0.111/0.115  12278729
 4      38.024%    0.492/0.496/0.500       0.103/0.109/0.113  11961356
 5      37.949%    0.540/0.547/0.552       0.100/0.109/0.113  11937808
 6      37.902%    0.683/0.691/0.694       0.103/0.107/0.113  11923043
 7      37.128%    1.440/1.446/1.449       0.100/0.108/0.113  11679311
 8      37.095%    2.272/2.288/2.294       0.096/0.110/0.116  11668933
 9      37.089%    2.596/2.609/2.616       0.099/0.109/0.113  11667081

 avg1   39.656%                1.006                   0.110
 tot                         135.812                  14.843

PR/560 Split up memcopy by architecture
   text    data     bss     dec     hex filename
  95248    1472      32   96752   179f0 libz-ng.so.1

 Level   Comp   Comptime min/avg/max  Decomptime min/avg/max
 1      52.643%    0.170/0.175/0.180       0.109/0.119/0.125  16560094
 2      40.045%    0.337/0.349/0.356       0.110/0.122/0.129  12597075
 3      39.033%    0.442/0.452/0.457       0.113/0.120/0.123  12278729
 4      38.024%    0.490/0.498/0.501       0.111/0.119/0.124  11961356
 5      37.949%    0.536/0.545/0.550       0.107/0.115/0.120  11937808
 6      37.902%    0.687/0.693/0.696       0.110/0.119/0.121  11923043
 7      37.128%    1.439/1.446/1.451       0.110/0.117/0.123  11679311
 8      37.095%    2.290/2.293/2.296       0.100/0.115/0.120  11668933
 9      37.089%    2.610/2.615/2.620       0.103/0.115/0.120  11667081

 avg1   39.656%                1.007                   0.118
 tot                         135.982                  15.909

No changes to compressed size.
It does look like things have gotten slower, both deflate and inflate seems to have slowed down, but it is especially noticeable in inflate where it is 7.3% slower.

CMAKE Tests
Baseline ee28753685d62117f8ef4ef8b94ba101a5cd1e96
   text    data     bss     dec     hex filename
  92883    1304      32   94219   1700b libz-ng.so.1

 Level   Comp   Comptime min/avg/max  Decomptime min/avg/max
 1      52.643%    0.170/0.179/0.183       0.099/0.112/0.116  16560094
 2      40.045%    0.345/0.351/0.355       0.104/0.113/0.118  12597075
 3      39.033%    0.442/0.452/0.457       0.105/0.113/0.118  12278729
 4      38.024%    0.478/0.494/0.499       0.100/0.113/0.117  11961356
 5      37.949%    0.543/0.547/0.551       0.097/0.110/0.116  11937808
 6      37.902%    0.683/0.689/0.693       0.103/0.109/0.113  11923043
 7      37.128%    1.438/1.448/1.453       0.106/0.110/0.113  11679311
 8      37.095%    2.288/2.293/2.297       0.099/0.109/0.116  11668933
 9      37.089%    2.600/2.612/2.617       0.096/0.112/0.116  11667081

 avg1   39.656%                1.007                   0.111
 tot                         135.977                  14.995

PR/560 Split up memcopy by architecture 0e4ec9731e78172c5a9415592d49428e8c3fe05a
   text    data     bss     dec     hex filename
  95253    1472      32   96757   179f5 libz-ng.so.1

 Level   Comp   Comptime min/avg/max  Decomptime min/avg/max
 1      52.643%    0.166/0.176/0.183       0.116/0.122/0.126  16560094
 2      40.045%    0.343/0.348/0.353       0.116/0.124/0.129  12597075
 3      39.033%    0.442/0.454/0.458       0.113/0.120/0.126  12278729
 4      38.024%    0.478/0.491/0.496       0.111/0.117/0.121  11961356
 5      37.949%    0.530/0.541/0.547       0.104/0.117/0.124  11937808
 6      37.902%    0.682/0.688/0.692       0.107/0.115/0.120  11923043
 7      37.128%    1.441/1.448/1.453       0.110/0.118/0.123  11679311
 8      37.095%    2.283/2.293/2.298       0.113/0.116/0.120  11668933
 9      37.089%    2.606/2.615/2.618       0.106/0.116/0.123  11667081

 avg1   39.656%                1.006                   0.118
 tot                         135.813                  15.984

Cmake sees a speedup on deflate, but inflate gets slower here too.
PS: These tests were done using gcc (GCC) 4.8.5 20150623 (Red Hat 4.8.5-39), on a Haswell cpu with hyperthreading, turbo and some power saving disabled.

@Dead2, I imagine it will be slower for both deflate and inflate, due to the compiler only enabling intrinsics in the files that use them. Also there is a performance hit due to the functable.chunk* calls.

I have made an additional commit which grabs the chunksize in inflateInit and then uses it instead of continuously calling functable.chunksize.

I ran into something odd:
Changing default optimization in configure from -O2 to -O3 (to match zlib and cmake) crashes when combined with this pull request.
i.e. https://github.com/dankegel/zlib-ng/commits/cmake-intrinsics-files-v2-plus-O3 crashes on the GCC no opt configure builders, but https://github.com/dankegel/zlib-ng/commits/bug638-default-O3 doesn't.
I can't reproduce the crash on my local machine with ubuntu 20.04, but I can with a container running ubuntu 18.04.  So, the recipe to reproduce the crash is:
fire up ubuntu 18.04, then:
git clone https://github.com/zlib-ng/zlib-ng
cd zlib-ng
git remote add dank https:///github.com/dankegel/zlib-ng
git fetch dank
git checkout cmake-intrinsics-files-v2-plus-O3
mkdir btmp
cd btmp
../configure --warn --without-optimizations --without-new-strategies
make -j3
cd test
make testshared

Rebuilding with -g in *FLAGS and rerunning with QEMU_RUN=valgrind finds:
Process terminating with default action of signal 11 (SIGSEGV)
General Protection Fault
at storechunk (memchunk.c:54)
by chunkmemset_c (memchunk_tpl.h:143)
by zng_inflate_fast (inffast.c:276)
by zng_inflate (inflate.c:817)
by test_large_inflate (example.c:445)
by main (example.c:988)
Changing -DUNALIGNED_OK to -UUNALIGNED_OK temporarily and rebuilding rescues the test.
This is on a plain old amd64 box ( i3-4130 ).

If you have time to track it down it would be very helpful.

Evidently -O3 turns on vector instructions on ubuntu 18.04, but not ubuntu 20.04;
compiling with -Wa,-adhln shows movaps used on 18.04 but not 20.04.

Adding "no-sse" target attribute to that function stops it from crashing even with -O3.

On both ubuntu 18.04 and 20.04:
ubuntu@demo-ubu1804:~/src/zlib-ng/btmp$ gcc -Q --help=target | grep sse
  -mfpmath=                   		sse
  -mno-sse4                   		[enabled]
  -msse                       		[enabled]
  -msse2                      		[enabled]
  -msse2avx                   		[disabled]
  -msse3                      		[disabled]
  -msse4                      		[disabled]
  -msse4.1                    		[disabled]
  -msse4.2                    		[disabled]
  -msse4a                     		[disabled]
  -msse5
  -msseregparm                		[disabled]
  -mssse3                     		[disabled]

so those instructions are lurking, just waiting for the optimizer to use them.

This commit seemed necessary here:
https://github.com/dankegel/zlib-ng/commit/1c9d7f3707c831b372442a202a3fbfd71352d67d

Personally I think we should just add a comment to the function and use memcpy() always... Using SSE/SSE2 instructions on a 64-bit target is not discouraged optimization in my opinion as all processors support it.

SSE + SSE2 is mandatory on x86-64, so the fact that compilers utilize that fact is unsurprising.
It looks to me like the UNALIGNED_OK check is false, since the compiler can choose to use movaps there, and movaps does not support unaligned access. I find it strange that the compiler would use movaps here though, since it is meant for floating point ("Move Aligned Packed Single-Precision Floating-Point Values"). If it had use movups, it would probably have worked fine.
I suspect we would have to use compiler intrinsics to do this reliably correctly.
I wonder whether gcc using movaps there is a compiler bug, but since we specify uint64_t, I think it is within its rights to assume it is 64-bit aligned.
Btw, it is not actually true that cmake uses -O3, that is an Ubuntu configuration and does not reflect a cmake default. RHEL and even Fedora default to -O2.
So if we were to change configure to -O3, we'd have to specify a cmake default of -O3 also.

SSE engine is by default in floating point mode and switching to integer mode would require extra move between SSE registers... That would obviously have performance penalty... You can see it clearly in disassembly of some functions where the result of a load to vector register is used by integer SSE instruction.

Re O2 vs O3: for what it's worth, https://gitlab.kitware.com/cmake/cmake shows that the upstream default is O3:
./Modules/Compiler/GNU.cmake:  string(APPEND CMAKE_${lang}_FLAGS_RELEASE_INIT " -O3 -DNDEBUG")

Whether or not we make O3 the default in configure, we need to test with O3 on, or we'll miss out on some interesting bugs...

Somebody wants to make a pull request for CI run to test -O3 and to include possible fixes?

memcpy optimizes nicely these days, doesn't it?

I rebased my "compare shared libraries generated by configure and cmake" branch on top of
this one and got it to pass for amd64 and powerpc.  It's failing on arm because
configure builds adler32.c with -march=armv8-a+crc -mfloat-abi=hard -mfpu=neon,
but cmake doesn't.  See
https://github.com/dankegel/zlib-ng/tree/cmake-intrinics-files-v2-plus-bug638

@dankegel For functable.c failure: The different flags are:
-DARM_NEON_SLIDEHASH -D__USE_LARGEFILE64 -Wno-implicit-fallthrough xxx -MD -MT -MF xxxxxxxxxxxxxxxxxxxxxxx
xxxxxxxxxxxxxxxxxxxx xxxxxxxxxxxxxxxxxxx xxxxxxxxxxxxxxxxxxxxxxxxx -O2 xxx xxx xxx -march=armv8-a+crc+simd

I added all the x's so I could reorder the flags and see which ones are equal and which ones are missing... First one is cmake, second one is configure...

@dankegel You've probably hit an issue similar to this: https://pzemtsov.github.io/2016/11/06/bug-story-alignment-on-x86.html
TL;DR: UNALIGNED_OK isn't. While x86 (and AMD64) can do unaligned access in machine code the same is not true of C(++).

Like I said earlier, UNALIGNED_OK only works correctly when all vector instructions are disabled... For some source files, this is what we actually want and as such higher optimization levels could be considered as user error... We could add "-mno-sse" to those files, but that would only work on AMD64/x86_64 targets...
For 32-bit x86 processors, even 64-bit variables can cause issues as largest general-purpose register is 32 bits and MMX-optimizations could be used for 64-bit variables... Disabling both SSE and MMX would solve that though...

UNALIGNED_OK appears to be overloaded... it used to mean 4-byte accesses on non-4-byte-aligned addresses by the main CPU?

@dankegel Now we have UNALIGNED_OK and UNALIGNED64_OK...

Rebased against latest develop

Rebased https://github.com/dankegel/zlib-ng/tree/cmake-intrinics-files-v2-plus-bug638
on top of this, now aarch64 passes; arm-linux-gnueabihf is still failing, though,
because configure builds all source files with some arch options, but cmake doesn't.
e.g. configure builds adler32.c like this:
2020-06-22T18:20:47.6201024Z arm-linux-gnueabihf-gcc -march=armv8-a+crc -O2 -O3 -DNDEBUG -std=c99 -Wall -D_LARGEFILE64_SOURCE=1 -DHAVE_VISIBILITY_HIDDEN -DHAVE_VISIBILITY_INTERNAL -DHAVE_BUILTIN_CTZ -DHAVE_BUILTIN_CTZLL -DARM_CPUID -mfloat-abi=hard -DUNALIGNED_OK -DUNALIGNED64_OK -DARM_ACLE_CRC_HASH -mfpu=neon -DARM_NEON_ADLER32 -DARM_NEON_MEMCHUNK -DARM_NEON_SLIDEHASH -I/home/runner/work/zlib-ng/zlib-ng/btmp1 -I/home/runner/work/zlib-ng/zlib-ng -c -o adler32.o /home/runner/work/zlib-ng/zlib-ng/adler32.c

but cmake builds it like
2020-06-22T18:20:39.3454955Z [12/93] /usr/bin/arm-linux-gnueabihf-gcc -DARM_ACLE_CRC_HASH -DARM_CPUID -DARM_NEON_ADLER32 -DARM_NEON_MEMCHUNK -DARM_NEON_SLIDEHASH -DHAVE_BUILTIN_CTZ -DHAVE_BUILTIN_CTZLL -DHAVE_VISIBILITY_HIDDEN -DHAVE_VISIBILITY_INTERNAL -DUNALIGNED64_OK -DUNALIGNED_OK -D_LARGEFILE64_SOURCE=1 -D__USE_LARGEFILE64 -I. -I../ -Wall -Wno-implicit-fallthrough -O3 -DNDEBUG   -std=c99 -MD -MT CMakeFiles/zlibstatic.dir/adler32.c.o -MF CMakeFiles/zlibstatic.dir/adler32.c.o.d -o CMakeFiles/zlibstatic.dir/adler32.c.o   -c ../adler32.c

Now it's somebody else's turn to fix the gnueabihf discrepancy...

@mtl1979 any thoughts on this error? Can't seem to find arm_acle.h. Doesn't appear to be any such file available on ARM windows.
crc32_acle.c
NMAKE : fatal error U1077: '"C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Tools\MSVC\14.26.28801\bin\HostX86\ARM64\cl.EXE"' : return code '0x2'
Stop.
./arch/arm\crc32_acle.c(9): fatal error C1083: Cannot open include file: 'arm_acle.h': No such file or directory

@Dead2 I'm not sure there is much else left to do here except keep rebasing each time develop changes..

@nmoinvaz #include <intrin.h>

It looks like my latest commit solved it.

I rebased https://github.com/dankegel/zlib-ng/tree/cmake-intrinics-files-v2-plus-bug638 on top of https://github.com/zlib-ng/zlib-ng/commit/05959455249f85edc1dea09071e7d81a10f6a218.  To make things easier, it only checks amd64, ppc, and aarch64... and it's green.  I had to change configure slightly to get the file order to match.

All the CI checks out now..

curse you coverage uploader!!

Tested using a configure build on x86-64 Haswell.
Activated multiple generated file mode. Source: silesia-small.tar
Level 1: /tmp/deflatebench-1.tmp 270.1 MiB / 283,253,760 B
Level 2: /tmp/deflatebench-2.tmp 135.1 MiB / 141,626,880 B
Level 3: /tmp/deflatebench-3.tmp 105.1 MiB / 110,154,240 B
Level 4: /tmp/deflatebench-4.tmp 90.0 MiB / 94,417,920 B
Level 5: /tmp/deflatebench-5.tmp 90.0 MiB / 94,417,920 B
Level 6: /tmp/deflatebench-6.tmp 75.0 MiB / 78,681,600 B
Level 7: /tmp/deflatebench-7.tmp 60.0 MiB / 62,945,280 B
Level 8: /tmp/deflatebench-8.tmp 45.0 MiB / 47,208,960 B
Level 9: /tmp/deflatebench-9.tmp 45.0 MiB / 47,208,960 B

 Runs: 20
 Levels: 1-9
 Trimworst: 10

Baseline 738a6e5b07c0495b8652c77b4879145c083ea49f
   text    data     bss     dec     hex filename
  93246    1304      32   94582   17176 libz-ng.so.1

 Level   Comp   Comptime min/avg/max  Decomptime min/avg/max  Compressed size
 1      57.881%    1.754/1.779/1.790       1.082/1.098/1.106  163950540
 2      43.903%    1.735/1.750/1.763       0.559/0.567/0.572  62178636
 3      42.510%    1.615/1.631/1.644       0.414/0.423/0.438  46826710
 4      41.490%    1.576/1.591/1.606       0.358/0.364/0.368  39174432
 5      41.215%    1.707/1.730/1.749       0.330/0.354/0.363  38913920
 6      41.038%    1.699/1.726/1.737       0.286/0.300/0.305  32289128
 7      40.784%    1.899/1.909/1.915       0.223/0.236/0.243  25671760
 8      40.707%    1.829/1.843/1.849       0.168/0.173/0.178  19217358
 9      40.696%    2.020/2.042/2.047       0.164/0.175/0.181  19212387

 avg1   43.358%                1.778                   0.410
 tot                         160.016                  36.908

PR/560 24f8fc777a6957d05284a130e48a751515ca23ad
   text    data     bss     dec     hex filename
  95360    1472      32   96864   17a60 libz-ng.so.1

 Level   Comp   Comptime min/avg/max  Decomptime min/avg/max  Compressed size
 1      57.881%    1.776/1.793/1.800       1.114/1.142/1.158  163950540
 2      43.903%    1.733/1.747/1.755       0.570/0.590/0.600  62178636
 3      42.510%    1.608/1.628/1.638       0.435/0.453/0.462  46826710
 4      41.490%    1.568/1.585/1.593       0.369/0.377/0.381  39174432
 5      41.215%    1.708/1.730/1.740       0.369/0.379/0.383  38913920
 6      41.038%    1.705/1.723/1.731       0.299/0.307/0.315  32289128
 7      40.784%    1.887/1.896/1.903       0.234/0.245/0.252  25671760
 8      40.707%    1.826/1.835/1.842       0.179/0.186/0.188  19217358
 9      40.696%    2.024/2.033/2.039       0.178/0.185/0.188  19212387

 avg1   43.358%                1.774                   0.429
 tot                         159.701                  38.638

Cmake version of the above tests
Baseline 738a6e5b07c0495b8652c77b4879145c083ea49f w/CMAKE
   text    data     bss     dec     hex filename
  93075    1304      32   94411   170cb libz-ng.so.1

 Level   Comp   Comptime min/avg/max  Decomptime min/avg/max  Compressed size
 1      57.881%    1.774/1.790/1.798       1.092/1.107/1.118  163950540
 2      43.903%    1.723/1.738/1.746       0.554/0.563/0.569  62178636
 3      42.510%    1.603/1.621/1.628       0.415/0.429/0.438  46826710
 4      41.490%    1.571/1.579/1.586       0.342/0.358/0.365  39174432
 5      41.215%    1.710/1.725/1.730       0.346/0.357/0.364  38913920
 6      41.038%    1.706/1.720/1.727       0.285/0.295/0.302  32289128
 7      40.784%    1.878/1.891/1.897       0.225/0.237/0.243  25671760
 8      40.707%    1.826/1.830/1.833       0.168/0.176/0.182  19217358
 9      40.696%    2.030/2.037/2.042       0.168/0.176/0.185  19212387

 avg1   43.358%                1.770                   0.411
 tot                         159.304                  36.981

PR/560 24f8fc777a6957d05284a130e48a751515ca23ad w/CMAKE
   text    data     bss     dec     hex filename
  95365    1472      32   96869   17a65 libz-ng.so.1

 Level   Comp   Comptime min/avg/max  Decomptime min/avg/max  Compressed size
 1      57.881%    1.749/1.777/1.790       1.113/1.134/1.146  163950540
 2      43.903%    1.747/1.754/1.762       0.576/0.590/0.600  62178636
 3      42.510%    1.612/1.625/1.632       0.421/0.443/0.452  46826710
 4      41.490%    1.576/1.585/1.592       0.362/0.369/0.378  39174432
 5      41.215%    1.718/1.728/1.738       0.357/0.370/0.380  38913920
 6      41.038%    1.713/1.725/1.730       0.300/0.311/0.316  32289128
 7      40.784%    1.890/1.897/1.904       0.230/0.247/0.257  25671760
 8      40.707%    1.832/1.838/1.843       0.170/0.181/0.191  19217358
 9      40.696%    2.035/2.040/2.044       0.177/0.184/0.190  19212387

 avg1   43.358%                1.774                   0.425
 tot                         159.689                  38.286

The output library is still 5 text-bytes bigger with cmake than with configure, but that is much much closer than before.
The performance is now a bit slower with cmake than before, but it is now more in line with configure.
Configure tests also shows that it got faster with this PR.
So all in all, I think this looks great, and I think we should get this merged. Any objections?

Oh, forgot to say that inflate is ~4.5% slower, so that is not great. But these are important fixes, so in my opinion it is worth it.

@Dead2 I already said that there was one small issue that can be resolved in subsequent pull request... After that we can add AVX2-optimized versions for some functions. Those should improve performance on more recent machines...

Rebased.


[18.03] backport reaper fixes

Backports for 18.03 of;

https://github.com/docker/swarmkit/pull/2526 [manager/orchestrator/task_reaper] Fix task reaper test to also set the desired state on tasks to prevent reconciliation races
https://github.com/docker/swarmkit/pull/2591 [manager/orchestrator/taskreaper] Move task_reaper_test to orchestrator/taskreaper
https://github.com/docker/swarmkit/pull/2666 [orchestrator/task reaper] Clean up tasks in dirty list for which the service has been deleted
https://github.com/docker/swarmkit/pull/2675 [manager/orchestrator/reaper] Clean out the task reaper dirty set at the end of tick()
https://github.com/docker/swarmkit/pull/2669 Fix task reaper batching

git cherry-pick -s -S -x a388cad309edddb9880899fe8927afbe4717a18e
git cherry-pick -s -S -x 8cfb337920a6658b302643f27074ca3d669176ec
git cherry-pick -s -S -x 592e8eddfa43ec5fbd6e34da5ad6890dfa9313fb
git cherry-pick -s -S -x 1a43a3b612d8c775db8a44c8399844e1f7e4aed2
git cherry-pick -s -S -x 5291c7a7b45773a4fe18720a54485ee2dde0af3d

Conflict when cherry-picking https://github.com/docker/swarmkit/commit/8cfb337920a6658b302643f27074ca3d669176ec, likely because things were cherry-picked out of order;
On branch 18.03-backport_reaper_2
You are currently cherry-picking commit 8cfb3379.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:

	modified:   manager/orchestrator/taskreaper/task_reaper_test.go

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)

	deleted by them: manager/orchestrator/replicated/task_reaper_test.go

Resolved by git rm manager/orchestrator/replicated/task_reaper_test.go to mark resolution
To verify everything looked ok after merging, I compared the directories with master;
git diff master  manager/orchestrator/taskreaper/
git diff master  manager/orchestrator/

Which produced an empty diff, so the master/orchestrator directory is fully up to date with master

This supersedes https://github.com/docker/swarmkit/pull/2668
ping @anshulpundir @dperny @cyli PTAL if this LGTY

LGTM, let's do it.


Replace LiveData and callbacks with flows

Unfortunately, debounce does a slightly different thing: most notably, debounce(5s) would wait 5s after an emit and then emit all subsequent emits in those 5s as a list, which means every tap on refresh is guaranteed to be delayed at least 5s. I think Kotlin/kotlinx.coroutines#1302 is what I'd need, but it's not implemented yet.


pop-up is closing before completing tags

Expected Behavior
I want to add as much tag I want
Actual Behavior
It goes away before I finish taggin
Steps to Reproduce the Problem
When I right click on a page and click on add to pocket, the pop up opens on the top right with a box to type tags, but mostly goes away before I finish it. I want it to go away only I press enter
Specifications

Version: latest
Browser: Chrome
Operating System: Win 10

yes i have the same problem since the beginning of using pocket (over a year)
It ist really frustrating!
I am using Chrome on macos.
Please fix this.

This has an open PR that's been sitting there for almost a year, without action. I don't know what the pocket team are up to, but they clearly aren't maintaining this extension.
https://github.com/Pocket/extension-save-to-pocket/pull/203

i think this is fixed now.

This is fixed as of extension version 4.0.0


htlcswitch+lnwallet+channeldb: invalid sig fix

This PR persistently stores updates received from the remote party until we've produced a signature that includes these updates. Previously those updates were only stored in memory and dropped across restarts. This lead to the production of an invalid signature and channel force closure.
Fixes #3822

Fixing tests is not easy, because many of the tests rely on sending empty commit sigs.

My main concern is that we now restore the update logs from several sources: the local/remote commit, the pending remote commit and the dangling remote updates.

Yes, fully agree to this. Maybe it would have been better to persist the complete local and remote update logs, to not have to think so hard about reconstruction.

Maybe it would have been better to persist the complete local and remote update logs, to not have to think so hard about reconstruction.

Any updates that aren't committed are to be forgotten upon reconnection. If we persisted all updates, we'd have issues w.r.t preemptively attempting to evaluate a commitment view using abandoned updates.

party until we've produced a signature that includes these updates

Haven't dug into the PR yet, but this seems incorrect. Instead, we should only store the updates when we receive a signature from the remote party.


Support Dependency Bundles

As LEADS develops, the dependency list has grown rapidly. To better manage these dependencies, we want to introduce dependency bundles like FastAPI (pip install "fastapi[all]").

Sorry for the confusion, we are recently preparing for a massive launch of breaking changes to our Arduino Library. A corresponding revision will be released then. The newer version shall prevail. You may wait until then.

From our experience in LEADS Jarvis, the executable script seems unable to correctly import other files.


x/pkgsite: double magnifying glass icons in search input element on iOS

What is the URL of the page with the issue?
pkg.go.dev
What is your user agent?
Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/16.2 Safari/605.1.15
Screenshot

What did you do?
Navigate there in iOS 16.2 Safari.
What did you expect to see?
One magnifying glass icon by the input element.
Moving the cursor to the far left, the input element retains focus and you can still type.
What did you see instead?
Two magnifying glass icons by the input element.
When I typed "pow", then moved the cursor back to the beginning of the input, and then past it to the left, the cursor is lost, and you have to tap the input element again for it to have focus. I assume these two issues are related.

This has bothered me forever but I’m always immediately distracted and forget to file a bug. Thank you.

Either make it type="text" or
skip pkgsite's own icon for Safari or
disable the browser styling with css magic.

No, gopherbot closes related issues after a fix is merged.