switch from markdown2 to mistletoe

markdown2 has a lot of trouble with latex+mathjax, see e.g. #10, #62 and various issues on Zulip. mistletoe is what leanprover-community.github.io uses and it seems to do better with these examples.
A deployed version can be viewed here. Here's the test file specifically for LaTeX output. Looks like #10 is still an issue, but #62 seems fixed.
I also added a feature to make markdown headings have a # link after them, which allows linking to the middle of a page (as in https://github.com/leanprover-community/leanprover-community.github.io/pull/11).
Another slight change is to make the syntax highlighting default to lean.

I'm going to try to modify the markdown processor so that it's as close to the behavior on https://math.stackexchange.com and https://mathoverflow.net as possible, since (in my opinion) those sites are the most significant places on the web right now where users frequently input LaTeX embedded in markdown.
This is likely to break some of the LaTeX we currently have, but I think the consistency will be worth it.

@bryangingechen thank you for taking this on! This change is definitely overdue.
I'm happy to merge this as soon as there's no obvious breakage worse than what it fixes. I see you marked this as a draft, is there more you're planning to change?

Ok, let's try this out!
#deploy :octopus:

https://github.com/leanprover-community/doc-gen/actions/runs/568726686 :crossed_fingers:

Ok, the trigger seems to work!  I've canceled the workflow, because I realized that we still need to merge master here in order to get the new deploy_docs.sh

#deploy

Okay, this failed because leanprover-community-bot didn't accept the invitation to the demo repo. Trying again:
#deploy

Oh, this new test workflow is cool!

I'm happy to merge this as soon as there's no obvious breakage worse than what it fixes. I see you marked this as a draft, is there more you're planning to change?

Yeah, I still haven't finished the changes described in my second comment above. The good news is I think I've already managed to fix #10. I'll try to clean things up and push a commit with my progress tonight.

#deploy and fix the $4

#deploy 🙏


[FLINK-1711] - Converted all usages of Commons Validate to Guava Checks(for Java classes), Scala predef require(for Scala classes)

[FLINK-1711] - Converted all usages of Commons Validate to Guava Checks(for Java classes), Scala predef require(for Scala classes)

I'm running a last check on travis on my branch. Then I'm merging this. Thanks for your work!

Thanks @aljoscha .I notice above it says "This pull request is closed, but the lokeshrajaram:all_guava branch has unmerged commits." Is there anything more needs to be done for this?

That's because I rebased your commit which changes the signature of the commit. But if you look here https://github.com/apache/flink/commits/master you can see that your commit is among the most recent ones. :smile:


Remove use of BundleUtilities in Linux build

Description
This PR removes the use of CMake's BundleUtilities in Linux builds.
This implementation explicitly bundles the Flutter library, automatically bundles plugin libraries via the $<TARGET_FILE:${plugin}_plugin> generator expression, and allows plugins to specify further dependancies via an optional <plugin_name>_bundled_libraries list.
All libraries are also now copied into a "lib" directory within the bundle instead of just next to the executable.
Related Issues
Resolves: https://github.com/flutter/flutter/issues/58883
Tests
Updated 'Injecting creates generated Linux plugin Cmake file'.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I signed the CLA.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I updated/added relevant documentation (doc comments with ///).
[x] All existing and new tests are passing.
[x] The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
[x] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.

[x] No, no existing tests failed, so this is not a breaking change.
[ ] Yes, this is a breaking change.

@stuartmorgan is this ready to land? Would you like to mark it 'waiting for tree to go green'?

@zanderso For committers, I generally leave it up to them how they want to land PRs.

Sorry, I didn’t know this was waiting on me to merge.


SAK-32151 Rubrics Service integration with Sakai

This PR includes some changes to the original Rubrics development, to make it work with Sakai master:
-Earle's work on kernel to support both hibernate and JPA via the same EntityManager (see also KNL-1583).
-Earle's Rubrics project maven reorganization.
-Kernel changes to allow Rubrics/Spring Boot being initialized as a webapplication with SakaiApplication context as parent.
-Moving spring dependencies and libraries to master pom and lib folder respectively. Firstly, because Rubrics needs it, but also with the work started on KNL-1583 Sakai is moving on that direction, where many tools will require and share those libraries.
-Solving bugs on Rubric tools when editing rubrics/association/evaluation.
-Solving other bugs: use LocalDateTime, CriterionOutcome class, styles, i18n, etc.
This is a gigantic PR, so if you need more details on any change, feel free to ask me.

It seems kernel-impl tests are failing due to the activation of the JPA entityManager introduced (commented) on KNL-1583 and used here,
TestComponentManagerContainer is null on SakaiKernelTestBase, which is used on many places. Probably due to some misconfiguration on the test components.xml file.
@earle can you help? Thanks.


Support pipeline as code

Hi, recently I'm playing with Jenkins and found their pipeline as code feature very helpful.
I can pull the pipeline configuration from remote repo.

Or edit it in the UI:

This is my simplest Jenkins pipeline configuration code: https://github.com/EcutDavid/react-resetcss-dev-template/blob/master/Jenkinsfile
So what about support:
Define the configuration yaml URL in front end, and pull it periodically into workspace.
Or other better solutions?

We've been discussing being able to fetch pipelines from a remote source (starting with Git) as well as allowing us to edit pipelines directly through the interface. It's on our roadmap for the next couple releases.

I was thinking this, one possible solution:

You choose Github OAuth as login option (so we get token to access your repos)
When you first login we clone the repo and set the workspace folder to point to the /pipelines (or whatever folder you choose).
We have a "resync with git" button that will refetch the git-repo.

@JuhaS Is the GitHub log in working already? It'd be nice to activate it at least for one project.

Is the GitHub log in working already?

Yes, but probably needs some cleanup, I'll try to make that happen this week.


Add OnRTCPReceived callback

With this commit plus a small modification to webrtc.RTPSender,
a user could easily set a callback to be invoked when RTCP packets are received.
If ya'll like this approach I'll add some tests to make it mergeable.
Proposed modification to webrtc.RTPSender:
func (r *RTPSender) OnRTCPReceived(f func([]rtcp.Packet)) {
       go func() {
               select {
               case <-r.sendCalled:
                       r.rtcpReadStream.OnRTCPReceived(f)
               case <-r.stopCalled:
                       return
               }
       }()
 }

Example usage by user code:
sender, err := peer.connection.AddTrack(track)
if err != nil {
        return emptySdp, errors.Wrapf(err, "Unable to add %s track to PeerConnection %s", sourceID, peerID)
}
sender.OnRTCPReceived(func(msg []rtcp.Packet) {
        logs.Debugf("PeerConnection %s stream %s received RTCP: %s", peerID, sourceID, msg)
        // TODO: Implement sender pacing based on stream feedback (REMB, NACKs, etc)
})

Closing after some discussion in the #pion channel. This approach is too specific to my use case. For consistency, we'd also need to add an OnRTP callback, and then we'd have two different ways to receive these messages.


Plotting topology and big trees

Hi,
This is another feature that would be really useful. Plotting perhaps using plotly backend, so big trees can be viewed and zoom-ed in/out. I see there is show() function, but it does not show topology.
Being able to display tree, branches, how they are arranged, to immediately see the whole tree, just right away from the Julia code, is really nice for diagnostics. Maybe such function already exists ?

I'm afraid I don't have the requisite skills to do plotting, but you can use R's plotting functions if you like:
julia> using Phylo
INFO: Precompiling module Phylo.

julia> using RCall

julia> include(joinpath(Pkg.dir("Phylo"), "src/rcall.jl")) # Load in the helper code to interface to R
sexp (generic function with 103 methods)

julia> tree = rand(Ultrametric(10)) # Creates a random tree with 10 tips
Phylo.BinaryTree{Phylo.LeafInfo,Void} phylogenetic tree with 19 nodes and 18 branches
Leaf names:
String["tip 1", "tip 2", "tip 3", "tip 4", "tip 5", "tip 6", "tip 7", "tip 8", "tip 9", "tip 10"]

R> library(ape)

julia> @rput tree
Phylo.BinaryTree{Phylo.LeafInfo,Void} phylogenetic tree with 19 nodes and 18 branches
Leaf names:
String["tip 1", "tip 2", "tip 3", "tip 4", "tip 5", "tip 6", "tip 7", "tip 8", "tip 9", "tip 10"]

R> plot(tree)

You need to install R, the ape library in R (using install.packages("ape")) and the RCall package in Julia, so this isn't the simplest of solutions(!), but then you can use ape's plotting code. Note that you type $ to switch from a Julia prompt to an R prompt, and hit the backspace key at the R prompt to switch back...

I'll add plotting functionality at some point. I got a lot of the code ready.

Code from (here)[https://github.com/jangevaare/PhyloTrees.jl/blob/master/src/plot.jl] can be used/modified for this package as well @mkborregaard

That would be great, thanks. Apart from being a deeply inelegant solution, the R plotting I've been using isn't even very nice. I don't know if you've done much with trees, but the best tree plotting functionality I've seen is ggtree in case you're interested...

Looks nice - can you saw what you like about it in particular? Just the fact that it can do a lot? I thought we'd start with the basics and build from there :-)

I've never used it in anger - I've never been much of a figure person - but I've had collaborators produce trees using it, and they do look good and the package is very flexible. I agree, basics first though!
However, looking at their code, I've liked the way it ties into the rest of that ggplot2 ecosystem, so I guess that works from the Plots.jl perspective, assuming you were planning on going with that. The other thing is just the easy extensibility of it. For instance the simplicity of switching layouts:
> library(ggtree)
ggtree v1.12.6  For help: https://guangchuangyu.github.io/software/ggtree

If you use ggtree in published research, please cite:
Guangchuang Yu, David Smith, Huachen Zhu, Yi Guan, Tommy Tsan-Yuk Lam. ggtree: an R package for visualization and annotation of phylogenetic trees with their covariates and other associated data. Methods in Ecology and Evolution 2017, 8(1):28-36, doi:10.1111/2041-210X.12628
> tr <- rtree(50)
> ggtree(tr)
> ggtree(tr, layout="slanted")
> ggtree(tr, layout="circular")

and so on. Not like some packages I've used in the past I guess...

I was gonna implement dendrogram and fan to begin with, but it should def be that easy to switch

Four years ago I wrote some pretty amazing code for this using BezierCurves for declaritive curves in Compose, too bad nobody cares about that anymore

Great - the simpler the better. Sounds good to me. As far as Compose is concerned, I didn't know about it before 10 seconds ago... it looks great - I always liked lisp :)


Preferred guild setting

Added $guild set and $guild unset to store preferred Guild in database
If guild is set, other guild commands (like treasury or info) can be invoked without explicitly typing the guild name again

As a design choice, i think it would be better if preferred guild was per guild (server) instead of per user, since it will end up with a lot of users typing the same command in a server, no?
Mostly comes down to changing user to guild, and checking if ctx.guild is not None


Fix relationship-tagging not working

Also fixed that when selecting the "None" option it would just be added to the list instead of removing all selected options.
Works also for the non-taggable-version.
Fixes https://github.com/the-control-group/voyager/issues/4039

When we will get the release with this fix?


x/mobile: gomobile bind does not support vendor

What version of Go are you using (go version)?

go version go1.13 windows/amd64

Does this issue reproduce with the latest release?
What operating system and processor architecture are you using (go env)?
go env Output
set GO111MODULE=auto
set GOARCH=amd64
set GOBIN=
set GOCACHE=C:\Users\Wang\AppData\Local\go-build
set GOENV=C:\Users\Wang\AppData\Roaming\go\env
set GOEXE=.exe
set GOFLAGS=
set GOHOSTARCH=amd64
set GOHOSTOS=windows
set GONOPROXY=
set GONOSUMDB=
set GOOS=windows
set GOPATH=D:\Work\go\gopath
set GOPRIVATE=
set GOPROXY=https://proxy.golang.org,direct
set GOROOT=D:\Work\go
set GOSUMDB=sum.golang.org
set GOTMPDIR=
set GOTOOLDIR=D:\Work\go\pkg\tool\windows_amd64
set GCCGO=gccgo
set AR=ar
set CC=gcc
set CXX=g++
set CGO_ENABLED=1
set GOMOD=D:\Work\go\gopath\src\github.com\fatedier\frp\go.mod
set CGO_CFLAGS=-g -O2
set CGO_CPPFLAGS=
set CGO_CXXFLAGS=-g -O2
set CGO_FFLAGS=-g -O2
set CGO_LDFLAGS=-g -O2
set PKG_CONFIG=pkg-config
set GOGCCFLAGS=-m64 -mthreads -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=C:\Users\Wang\AppData\Local\Temp\go-build704107050=/tmp/go-build -gno-record-gcc-switches

What did you do?

go get  github.com/fatedier/frp
vi {GOPATH}/github.com/fatedier/frp/cmd/frpc/sub/export.go

package sub

import (
	"time"
	"math/rand"

	_ "github.com/fatedier/frp/assets/frpc/statik"

	"github.com/fatedier/golib/crypto"
)
// I want to export this function only
func Start(filePath string) {
	crypto.DefaultSalt = "frp"
	rand.Seed(time.Now().UnixNano())

	runClient(filePath)
}

open terminal
gomobile bind -target android github.com/fatedier/frp/cmd/frpc/sub
What did you expect to see?
gomobile create a .aar and .jar file
What did you see instead?
gomobile: D:\Work\go\gopath\bin\gobind.exe -lang=go,java -outdir=C:\Users\Wang\AppData\Local\Temp\gomobile-work-225577183 github.com/fatedier/frp/cmd/frpc/sub failed: exit status 1
type-checking package "github.com/fatedier/frp/cmd/frpc/sub" failed (D:\Work\go\gopath\src\github.com\fatedier\frp\cmd\frpc\sub\http.go:22:2: could not import github.com/spf13/cobra (type-checking package "github.com/spf13/cobra" failed (D:\Work\go\gopath\pkg\mod\github.com\spf13\cobra@v0.0.3\bash_completions.go:11:2: could not import github.com/spf13/pflag (cannot find package "github.com/spf13/pflag" in any of:
        D:\Work\go\src\github.com\spf13\pflag (from $GOROOT)
        D:\Work\go\gopath\src\github.com\spf13\pflag (from $GOPATH)))))

Any update here? gomobile bind -mod vendor says "flag provided but not defined: -mod". Without the flag, it always downloads packages ignoring vendor/ dir just like with a regular build.
This is on go1.14.

Hi, any update on this?
gobind -lang=go,java -outdir=/tmp/gomobile-work-1386653115 -javapkg=net.isoftservices.client ./src/game/android

unable to import bind: [-: cannot find package "." in:
	/home/kordax/Projects/maxbet/octopus/vendor/golang.org/x/mobile/bind]
unable to import bind: [-: cannot find package "." in:
	/home/kordax/Projects/maxbet/octopus/vendor/golang.org/x/mobile/bind]
unable to import bind: [-: cannot find package "." in:
	/home/kordax/Projects/maxbet/octopus/vendor/golang.org/x/mobile/bind]
"golang.org/x/mobile/bind" is not found; run go get golang.org/x/mobile/bind: [-: cannot find package "." in:
	/home/kordax/Projects/maxbet/octopus/vendor/golang.org/x/mobile/bind]

I get the same error using vendor/ / go version go1.18.3 linux/amd64

Some further digging, starting from scratch:
From: https://pkg.go.dev/golang.org/x/mobile/cmd/gomobile
$ go install golang.org/x/mobile/cmd/gomobile@latest
$ export PATH=$PATH:/home/user/go/bin
$ gomobile init
$ gomobile version

gomobile version unknown: cannot test gomobile binary: exit status 1, no required module provides package
golang.org/x/mobile/cmd/gomobile: go.mod file not found in current directory or any parent directory;
see 'go help modules'

Ok, so in a module:
$ mkdir test ; cd test ; go mod init test.com
go: creating new go.mod: module test.com

And: git init ; echo "test" > readme.md ; git add readme.md ; git commit -m "Initial"
$ go mobile version

gomobile version unknown: cannot test gomobile binary: exit status 1, no required module provides package
golang.org/x/mobile/cmd/gomobile; to add it:

    go get golang.org/x/mobile/cmd/gomobile

Run go get:
$ go get golang.org/x/mobile/cmd/gomobile
go: added golang.org/x/mobile v0.0.0-20220722155234-aaac322e2105
go: added golang.org/x/mod v0.4.2
go: added golang.org/x/sys v0.0.0-20210809222454-d867a43fc93e
go: added golang.org/x/tools v0.1.8-0.20211022200916-316ba0b74098
go: added golang.org/x/xerrors v0.0.0-20200804184101-5ec99f83aff1

$ go mod tidy
go: warning: "all" matched no packages

$ gomobile version

gomobile version unknown: cannot test gomobile binary: exit status 1, no required module provides package
golang.org/x/mobile/cmd/gomobile; to add it:

        go get golang.org/x/mobile/cmd/gomobile

Ok, try example:
Download https://cs.opensource.google/go/x/mobile/+/aaac322e:example/basic/main.go
$ go mod tidy
go: downloading golang.org/x/exp v0.0.0-20190731235908-ec7cb31e5a56
go: downloading golang.org/x/image v0.0.0-20190802002840-cff245a6509b

$ go mod vendor
$ gomobile version

gomobile version unknown: cannot test gomobile binary: exit status 1, cannot find package "." in:
        /home/user/test/vendor/golang.org/x/mobile/cmd/gomobile

Ok, apparently golang.org/x/mobile/cmd/gomobile is never added to go.mod since not being a dependency.
Force dependency by adding package to main.go:
	_ "golang.org/x/mobile/cmd/gomobile"

Try again:
$ go mod tidy
$ go mod vendor
$ gomobile version

gomobile version unknown: binary is out of date, re-install it

Here is when the error is triggered in go mobile source:
https://github.com/golang/mobile/blob/8578da9835fd365e78a6e63048c103b27a53a82c/cmd/gomobile/version.go#L46
Apparently go list -f {{.Stale}} golang.org/x/mobile/cmd/gomobile should return false, but it returns true in our test module:
$ go list -f {{.Stale}} golang.org/x/mobile/cmd/gomobile
true

If we use StaleReason:
$ go list -f {{.StaleReason}} golang.org/x/mobile/cmd/gomobile

We get:
stale dependency: golang.org/x/mobile/internal/sdkpath

On other test repo we get the same reason, just a different dependency path (e.g. stale dependency: cgo)
My current knowledge of golang doesn't go as far as to know how to investigate this further. Hope someone else can pick this up.

Can someone from the gomobile team comment? It's 2024 and I still cannot use gomobile with vendoring and go modules. I am using GO111MODULE=off as a workaround, which is not great.


Your key can be imported on other machines without having a public key

"Using keys" section seemingly requires a copy of public key, but in fact, things are much simpler: you just do gpg --edit-card and fetch. This will import your key even if its URL is not set. Then you just set the trust and it's all done.
Usually, when I configure a new installation I always have yubikey by my hand, but not the usb with backed up gpg files. Only yubikey is required to get and set up your key on a new machine.

This only works if the public key was uploaded to a keyserver though, right?

Yes, seems like you are right: https://stackoverflow.com/questions/46689885/how-to-get-public-key-from-an-openpgp-smart-card-without-using-key-servers . Perhaps in my case the key was already uploaded, and gpg looked it up regardless of an empty URL field.


Migrate the Ownership of a Repository over API

Hello
Is there a way to change the Ownership of a Repository over API. I must change a lot of Owners from  Repositorys.
Thank you

I can work on this


Update cisco.cson

I fixed the banner-motd of the day search, instead of searching until the end of the file after the motd, it now searches until it encounters the ^ character again. I then duplicated it for multiple banners that I've come across. Currently includes exec, login, and prompt-timeout. Tested and working. -MB

Thanks!!


New Gradel structure - reuse tar file

This experimental is based on a assumption that py2 and py3 sdist works the same and the tar file can be used inter-changeable.

only build sdist once (so put task in sdks/python/build.gradle). This task should execute first before parallel execution of many test tasks. The generated tar file can be used in all downstream tasks (e.g. tox tests and IT tests).
move copy sources out of sdist and only tox tasks depend on it
re-organized and refactor tasks, params in BeamModulePlugin to make code cleaner.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

Post-Commit Tests Status (on master branch)

Lang
SDK
Apex
Dataflow
Flink
Gearpump
Samza
Spark

Go

---
---
---
---
---
---

Java

Python

---

---
---
---

Pre-Commit Tests Status (on master branch)

---
Java
Python
Go
Website

Non-portable

Portable
---

---
---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

test test


[SPARK-47172][CORE][3.4] Add support for AES-GCM for RPC encryption

What changes were proposed in this pull request?
This change adds AES-GCM as an optional AES cipher mode for RPC encryption. The current default is using AES-CTR without any authentication. That would allow someone on the network to easily modify RPC contents on the wire and impact Spark behavior. See SPARK-47172 for more details.
Why are the changes needed?
The current default is using AES-CTR without any authentication. That would allow someone on the network to easily modify RPC contents on the wire and impact Spark behavior.
Does this PR introduce any user-facing change?
Yes, it adds an additional configuration flag is reflected in the documentation.
How was this patch tested?
Existing unit tests are all ensured to pass. New unit tests are written to explicitly test GCM support and to verify that modifying ciphertext content will cause an exception and fail.
build/sbt "network-common/test:testOnly"
build/sbt "network-common/test:testOnly org.apache.spark.network.crypto.AuthIntegrationSuite" build/sbt "network-common/test:testOnly org.apache.spark.network.crypto.AuthEngineSuite"
Was this patch authored or co-authored using generative AI tooling?
Nope.

There's a build error that needs to be addressed:
[error] /home/runner/work/spark/spark/common/network-common/src/main/java/org/apache/spark/network/crypto/GcmTransportCipher.java:148:1:  error: incompatible types: Buffer cannot be converted to ByteBuffer
[error]                     .flip();
[error]                          ^
[error] /home/runner/work/spark/spark/common/network-common/src/main/java/org/apache/spark/network/util/ByteBufferWriteableChannel.java:44:1:  error: incompatible types: Buffer cannot be converted to ByteBuffer
[error]         ByteBuffer temp = src.slice().limit(bytesToWrite);
[error]                                            ^2 errors

@Ngone51 & @mridulm , the remaining build failure is with /dev/mima and is all unrelated code. How do you want to proceed?

Thanks, merged to branch-3.4.


Change mechanism for calling PSSA

🗣 Description
Previously, the pipelines had been calling PSScriptAnalyzer using MegaLinter.  This change uses PowerShell code that installs the PSSA module install and runs PSSA against every PowerShell file.
💭 Motivation and context
Closes: #1366
🧪 Testing
Ran CI pipeline.
Added "Write-Host" code to trigger failures.
Added a debugging line to verify which files are tested.
✅ Pre-approval checklist

[x] This PR has an informative and human-readable title.
[x] PR targets the correct parent branch (e.g., main or release-name) for merge.
[x] Changes are limited to a single goal - eschew scope creep!
[x] Changes are sized such that they do not touch excessive number of files.
[x] These code changes follow the ScubaGear [content style guide]
[x] Related issues these changes resolve are linked preferably via [closing keywords]
[x] All relevant type-of-change labels added.
[x] All relevant project fields are set.
[x] All relevant repo and/or project documentation updated to reflect these changes.
[x] All automated checks (e.g., linting, static analysis, unit/smoke tests) passed.

✅ Pre-merge checklist

[ ] PR passed smoke test check.
[ ] Feature branch has been rebased against changes from parent branch, as needed
[ ] Resolved all merge conflicts on branch
[ ] Notified merge coordinator that PR is ready for merge via comment mention

✅ Post-merge checklist

[ ] Feature branch deleted after merge to clean up repository.
[ ] Verified that all checks pass on parent branch (e.g., main or release-name) after merge.

Updated per Addam's request to show specific errors and warnings as GitHub workflow annotations.

That's a good idea, ty.  I will take that as an action.

Converted script to a function.  Added parameters, including one for debugging mode.  Reformatted the output to be as clean as possible.
You can see an example of the output here:  https://github.com/cisagov/ScubaGear/actions/runs/11689042287/job/32550906633
@buidav or @schrolla , do you want to mod your review?

Created TODO to write unit tests for this function: https://github.com/cisagov/ScubaGear/issues/1403

No worries.  Thanks for the good idea.


coprocessor: RPN function UnaryNot

Signed-off-by: Breezewish<EMAIL_ADDRESS>
What have you changed? (mandatory)
This PR adds UnaryNot RPN function.
What are the type of the changes? (mandatory)

Improvement (change which is an improvement to an existing feature)

How has this PR been tested? (mandatory)
New unit test.

/run-integration-tests

/run-integration-tests


Navbar doesn't always highlight the proper nav link

Example, when going to the "Learn" section, the color changes to the mustard color. when you click on the user guide docs, the leader link color remains mustard, but the link color goes away on the contributor guide docs or review docs.
Do we also want the Join link to light up when going through the sign up process?
We need to verify if other links are not having the correct behavior as well.
The link colors are being set using Django code, so someone who is proficient with that should take a look.

duplicate of #1200

Closing as duplicate of #1200


Network and Docker DNS READMEs and defaults

Mostly minor cleanups.

Tricky one to test :smile:, but happy for it to go in.


Remove NamedItem

NamedItem was a wrapper for NavigationItem to provide a name for them. NavigationItem not supports getName() directly so NamedItem is no longer needed.

Coverage decreased (-0.03%) to 94.943% when pulling dedb4ced82754c9a596f896172a7f023c979cbb9 on remove-named-item into e629474589fb1e3b9c54dab14ac5a3e20af6c511 on develop.


TLS: add support for password-protected private keys.

While there, rename "cert_chain" to "certificate_chain", since
we're using the full word in rest of the API.

@htuch @dnoe

Can you explain how this works?

Do we want to avoid renumbering fields at this point?

Renumbering is OK while we're in draft stage and there should be no data out there relying on it. When we declare v2 APIs finalized (or people start using them in anger), then we should stop the renumbers.

@htuch private keys can be password-protected at the OpenSSL/BoringSSL API level using SSL_CTX_set_default_passwd_cb, which allows for encrypted keys to be a part of the provisioning process (assuming that password is stored in a file that isn't, otherwise it's moot exercise).
This is common feature in web servers, and most of them support it.

So, this buys us some security in the case where we have provisioned the key on the filesystem and then deliver inline the password? Shouldn't this be past of DataSource (and exclusive of having inline keys?).

@htuch yes, or the other way around, i.e. encrypted key is provided inline and password is stored on the filesystem... so we need DataSource to support both scenarios.

@PiotrSikora Do you want to build this into DataSource itself? It seems everywhere we have a DataSource we might want this.

@htuch no, that wasn't my plan, but if you have a valid use case, then adding such option is fine by me. However, we're talking about 2 different layers of encryption here.
OpenSSL has a very specific format for encrypting private keys, which: (a) we're unlikely to reuse in other places, (b) we have to support, since that's the format people use to encrypt private TLS keys.

Please add a description to the new field with a reference to the OpenSSL description of how its passwords work and I'll merge.

@PiotrSikora are you planning on following up on this? If not, I'll close and we can reopen later.

@PiotrSikora Friendly ping.

Closing for now. We can reopen if/when we need this.


resizable column

Hi
do u consider implement resizable column (eg, by integrate with react-resizable)?

HI @ntuwang, I'm definitely open and welcome any cool feature, so far I didn't have too much time to implement these cool stuffs, and just only focusing on bug fix and some major feature implementation. So PR is welcome and let me know if you have any question when implement, thanks


HBASE-26947 Implement a special TestAppender to limit the size of tes…

…t output

It is not easy to write a UT for the log4j2 appender so I just test it manually.
Change the 'appender.console.maxSize' property in log4j2.properties to a very small value, for example, 1K, you will soon see this output when running UT in IDE
2022-04-12 22:44:20,366 Time-limited test ERROR Log size exceeded the limit 1024, will stop logging to prevent eating too much disk space

So I think this approach works.
And I set default value to 1G, which should be enough for most cases...
@busbey @ndimiduk FYI. I think this could solve the recent space problem of our ci system.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 27s
Docker mode activated.

_ Other Tests _

+1 :green_heart:
asflicense
0m  9s
The patch does not generate ASF License warnings.

7m 20s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4340/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4340

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile

uname
Linux ed9d5fe97259 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / ea9bc92ce2

Default Java
AdoptOpenJDK-1.8.0_282-b08

mvninstall
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4340/1/artifact/yetus-general-check/output/patch-mvninstall-root.txt

compile
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4340/1/artifact/yetus-general-check/output/patch-compile-hbase-logging.txt

javac
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4340/1/artifact/yetus-general-check/output/patch-compile-hbase-logging.txt

hadoopcheck
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4340/1/artifact/yetus-general-check/output/patch-javac-3.1.2.txt

hadoopcheck
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4340/1/artifact/yetus-general-check/output/patch-javac-3.2.2.txt

hadoopcheck
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4340/1/artifact/yetus-general-check/output/patch-javac-3.3.1.txt

spotbugs
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4340/1/artifact/yetus-general-check/output/patch-spotbugs-hbase-logging.txt

Max. process+thread count
60 (vs. ulimit of 30000)

modules
C: hbase-logging U: hbase-logging

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4340/1/console

versions
git=2.17.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  5s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+1 :green_heart:
mvninstall
2m 28s
master passed

+1 :green_heart:
compile
0m 10s
master passed

+1 :green_heart:
shadedjars
3m 46s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 11s
master passed

_ Patch Compile Tests _

-1 :x:
mvninstall
0m 38s
root in the patch failed.

-1 :x:
compile
0m 10s
hbase-logging in the patch failed.

-0 :warning:
javac
0m 10s
hbase-logging in the patch failed.

-1 :x:
shadedjars
0m 37s
patch has 10 errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 10s
the patch passed

_ Other Tests _

-1 :x:
unit
0m  9s
hbase-logging in the patch failed.

10m 22s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4340/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4340

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 4a3f36a43101 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / ea9bc92ce2

Default Java
AdoptOpenJDK-1.8.0_282-b08

mvninstall
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4340/1/artifact/yetus-jdk8-hadoop3-check/output/patch-mvninstall-root.txt

compile
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4340/1/artifact/yetus-jdk8-hadoop3-check/output/patch-compile-hbase-logging.txt

javac
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4340/1/artifact/yetus-jdk8-hadoop3-check/output/patch-compile-hbase-logging.txt

shadedjars
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4340/1/artifact/yetus-jdk8-hadoop3-check/output/patch-shadedjars.txt

unit
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4340/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-logging.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4340/1/testReport/

Max. process+thread count
62 (vs. ulimit of 30000)

modules
C: hbase-logging U: hbase-logging

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4340/1/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 34s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+1 :green_heart:
mvninstall
3m 44s
master passed

+1 :green_heart:
compile
0m 10s
master passed

+1 :green_heart:
shadedjars
5m 25s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 12s
master passed

_ Patch Compile Tests _

-1 :x:
mvninstall
0m 52s
root in the patch failed.

-1 :x:
compile
0m  9s
hbase-logging in the patch failed.

-0 :warning:
javac
0m  9s
hbase-logging in the patch failed.

-1 :x:
shadedjars
0m 54s
patch has 10 errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m  9s
the patch passed

_ Other Tests _

-1 :x:
unit
0m  9s
hbase-logging in the patch failed.

14m 17s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4340/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4340

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux c6bd910e018d 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / ea9bc92ce2

Default Java
AdoptOpenJDK-11.0.10+9

mvninstall
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4340/1/artifact/yetus-jdk11-hadoop3-check/output/patch-mvninstall-root.txt

compile
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4340/1/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-hbase-logging.txt

javac
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4340/1/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-hbase-logging.txt

shadedjars
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4340/1/artifact/yetus-jdk11-hadoop3-check/output/patch-shadedjars.txt

unit
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4340/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-logging.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4340/1/testReport/

Max. process+thread count
72 (vs. ulimit of 30000)

modules
C: hbase-logging U: hbase-logging

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4340/1/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 12s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 23s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 53s
master passed

+1 :green_heart:
compile
8m 52s
master passed

+1 :green_heart:
checkstyle
1m 20s
master passed

+1 :green_heart:
spotbugs
11m 23s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 16s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 46s
the patch passed

+1 :green_heart:
compile
10m 14s
the patch passed

-0 :warning:
javac
10m 14s
root generated 5 new + 1467 unchanged - 5 fixed = 1472 total (was 1472)

+1 :green_heart:
checkstyle
1m 58s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  2s
The patch has no ill-formed XML file.

+1 :green_heart:
hadoopcheck
13m 49s
Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.

+1 :green_heart:
spotbugs
7m 36s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 20s
The patch does not generate ASF License warnings.

68m 30s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4340/2/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4340

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile xml

uname
Linux 10e58bfdc1ca 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / ea9bc92ce2

Default Java
AdoptOpenJDK-1.8.0_282-b08

javac
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4340/2/artifact/yetus-general-check/output/diff-compile-javac-root.txt

Max. process+thread count
140 (vs. ulimit of 30000)

modules
C: hbase-logging . U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4340/2/console

versions
git=2.17.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  7s
Docker mode activated.

-0 :warning:
yetus
0m  2s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 18s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 21s
master passed

+1 :green_heart:
compile
1m 34s
master passed

+1 :green_heart:
shadedjars
3m 38s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 38s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 15s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 14s
the patch passed

+1 :green_heart:
compile
1m 33s
the patch passed

+1 :green_heart:
javac
1m 33s
the patch passed

+1 :green_heart:
shadedjars
3m 40s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
1m 27s
root generated 4 new + 81 unchanged - 4 fixed = 85 total (was 85)

_ Other Tests _

+1 :green_heart:
unit
340m 51s
root in the patch passed.

363m 27s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4340/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4340

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux bcc2266b3b60 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / ea9bc92ce2

Default Java
AdoptOpenJDK-1.8.0_282-b08

javadoc
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4340/2/artifact/yetus-jdk8-hadoop3-check/output/diff-javadoc-javadoc-root.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4340/2/testReport/

Max. process+thread count
4543 (vs. ulimit of 30000)

modules
C: hbase-logging . U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4340/2/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 13s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 16s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 12s
master passed

+1 :green_heart:
compile
6m 15s
master passed

+1 :green_heart:
checkstyle
1m  9s
master passed

+1 :green_heart:
spotbugs
7m 29s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 15s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m  7s
the patch passed

+1 :green_heart:
compile
6m  9s
the patch passed

-0 :warning:
javac
6m  9s
root generated 1 new + 1472 unchanged - 0 fixed = 1473 total (was 1472)

+1 :green_heart:
checkstyle
1m  9s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  1s
The patch has no ill-formed XML file.

+1 :green_heart:
hadoopcheck
11m 29s
Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.

+1 :green_heart:
spotbugs
7m 40s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 20s
The patch does not generate ASF License warnings.

52m 41s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4340/3/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4340

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile xml

uname
Linux 67dc595b8ba5 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / ea9bc92ce2

Default Java
AdoptOpenJDK-1.8.0_282-b08

javac
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4340/3/artifact/yetus-general-check/output/diff-compile-javac-root.txt

Max. process+thread count
138 (vs. ulimit of 30000)

modules
C: hbase-logging . U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4340/3/console

versions
git=2.17.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 32s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 22s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 59s
master passed

+1 :green_heart:
compile
2m 51s
master passed

+1 :green_heart:
shadedjars
5m 10s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
3m 24s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 20s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m  2s
the patch passed

+1 :green_heart:
compile
2m 39s
the patch passed

+1 :green_heart:
javac
2m 39s
the patch passed

+1 :green_heart:
shadedjars
5m 29s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
3m 20s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
331m 26s
root in the patch passed.

367m 29s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4340/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4340

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux c50880a3c233 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / ea9bc92ce2

Default Java
AdoptOpenJDK-11.0.10+9

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4340/3/testReport/

Max. process+thread count
4903 (vs. ulimit of 30000)

modules
C: hbase-logging . U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4340/3/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  1s
Docker mode activated.

-0 :warning:
yetus
0m  2s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 20s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 57s
master passed

+1 :green_heart:
compile
1m 40s
master passed

+1 :green_heart:
shadedjars
4m 23s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 44s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 34s
the patch passed

+1 :green_heart:
compile
1m 42s
the patch passed

+1 :green_heart:
javac
1m 42s
the patch passed

+1 :green_heart:
shadedjars
4m 22s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 55s
the patch passed

_ Other Tests _

-1 :x:
unit
359m  0s
root in the patch failed.

387m 36s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4340/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4340

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 4298147e3939 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / ea9bc92ce2

Default Java
AdoptOpenJDK-1.8.0_282-b08

unit
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4340/3/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-root.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4340/3/testReport/

Max. process+thread count
2606 (vs. ulimit of 30000)

modules
C: hbase-logging . U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4340/3/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
2m  3s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 33s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
5m  0s
master passed

+1 :green_heart:
compile
15m  1s
master passed

+1 :green_heart:
checkstyle
2m  7s
master passed

+1 :green_heart:
spotbugs
16m 54s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 24s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
5m 16s
the patch passed

+1 :green_heart:
compile
17m 47s
the patch passed

-0 :warning:
javac
17m 47s
root generated 1 new + 1472 unchanged - 0 fixed = 1473 total (was 1472)

+1 :green_heart:
checkstyle
2m 19s
the patch passed

+1 :green_heart:
whitespace
0m  1s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  2s
The patch has no ill-formed XML file.

+1 :green_heart:
hadoopcheck
25m 24s
Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.

+1 :green_heart:
spotbugs
20m 20s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 37s
The patch does not generate ASF License warnings.

123m 37s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4340/4/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4340

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile xml

uname
Linux 2f12901f18d9 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / f990f56e8e

Default Java
AdoptOpenJDK-1.8.0_282-b08

javac
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4340/4/artifact/yetus-general-check/output/diff-compile-javac-root.txt

Max. process+thread count
137 (vs. ulimit of 30000)

modules
C: hbase-logging . U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4340/4/console

versions
git=2.17.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  1s
Docker mode activated.

-0 :warning:
yetus
0m  4s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 21s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 38s
master passed

+1 :green_heart:
compile
1m 53s
master passed

+1 :green_heart:
shadedjars
3m 44s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
2m  7s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 33s
the patch passed

+1 :green_heart:
compile
1m 53s
the patch passed

+1 :green_heart:
javac
1m 53s
the patch passed

+1 :green_heart:
shadedjars
3m 42s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
2m  6s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
255m 15s
root in the patch passed.

279m 23s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4340/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4340

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 3fed9f2fca07 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / f990f56e8e

Default Java
AdoptOpenJDK-11.0.10+9

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4340/4/testReport/

Max. process+thread count
5689 (vs. ulimit of 30000)

modules
C: hbase-logging . U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4340/4/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Any other concerns? @ndimiduk @busbey

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 44s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 37s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
5m 16s
master passed

+1 :green_heart:
compile
16m 41s
master passed

+1 :green_heart:
checkstyle
2m 34s
master passed

+1 :green_heart:
spotbugs
19m 12s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 28s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m 54s
the patch passed

+1 :green_heart:
compile
17m 24s
the patch passed

-0 :warning:
javac
17m 24s
root generated 1 new + 1472 unchanged - 0 fixed = 1473 total (was 1472)

+1 :green_heart:
checkstyle
2m 24s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  2s
The patch has no ill-formed XML file.

+1 :green_heart:
hadoopcheck
25m 45s
Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.

+1 :green_heart:
spotbugs
18m 12s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 38s
The patch does not generate ASF License warnings.

125m 27s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4340/5/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4340

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile xml

uname
Linux 3f2d86ccdcc6 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 35aa57e445

Default Java
AdoptOpenJDK-1.8.0_282-b08

javac
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4340/5/artifact/yetus-general-check/output/diff-compile-javac-root.txt

Max. process+thread count
138 (vs. ulimit of 30000)

modules
C: hbase-logging . U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4340/5/console

versions
git=2.17.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 36s
Docker mode activated.

-0 :warning:
yetus
0m  2s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 18s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 22s
master passed

+1 :green_heart:
compile
1m 41s
master passed

+1 :green_heart:
shadedjars
3m 47s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 52s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 12s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 20s
the patch passed

+1 :green_heart:
compile
1m 41s
the patch passed

+1 :green_heart:
javac
1m 41s
the patch passed

+1 :green_heart:
shadedjars
3m 44s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 49s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
225m 52s
root in the patch passed.

250m 52s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4340/5/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4340

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 646b70bdcf37 5.4.0-1071-aws #76~18.04.1-Ubuntu SMP Mon Mar 28 17:49:57 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 35aa57e445

Default Java
AdoptOpenJDK-11.0.10+9

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4340/5/testReport/

Max. process+thread count
4862 (vs. ulimit of 30000)

modules
C: hbase-logging . U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4340/5/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 40s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 41s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 19s
master passed

+1 :green_heart:
compile
1m 24s
master passed

+1 :green_heart:
shadedjars
3m 55s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 25s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m  5s
the patch passed

+1 :green_heart:
compile
1m 25s
the patch passed

+1 :green_heart:
javac
1m 25s
the patch passed

+1 :green_heart:
shadedjars
3m 52s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 23s
the patch passed

_ Other Tests _

-1 :x:
unit
324m 35s
root in the patch failed.

346m 59s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4340/5/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4340

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 0d6050b246d1 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 35aa57e445

Default Java
AdoptOpenJDK-1.8.0_282-b08

unit
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4340/5/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-root.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4340/5/testReport/

Max. process+thread count
2291 (vs. ulimit of 30000)

modules
C: hbase-logging . U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4340/5/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Ping @ndimiduk


Create version 2.0.0 for python sample

What does this PR do?:
This PR creates a new version of python-basic sample. The new version uses the 3.0.0 version of python stack instead of the default one 2.1.0.
Which issue(s) this PR fixes:
fixes https://github.com/devfile/api/issues/1112

@maysunfaisal as discussed we will keep the parent overrides for the new sample version. I've also updated the port to 8080


Integrate Actors v5 Test Vectors

This is not ready to be worked on yet, as the specs-actor team has not created the suite yet, but their progress on this can be tracked here: https://github.com/filecoin-project/specs-actors/issues/1266

Test vectors have been available for a while. This is ready to be worked on now.


modified dynamic routing per role

Proposed solution
closes #178
Added a dynamic route to navbar - if user is an admin she can view a new link to 'manage camps'
Testing Done
passes tests

@mtr574 - please review all changes before merging. You just rolled-back my PR
(I'll fix back in next feature)


chore/update changelog

fix: add prompt=consent to the redirect url to obtain refresh token
Update CHANGELOG

Summary

Ticket:
What's Changed

Changed

Update CHANGELOG

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: onimsha
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Segfault / Cancelling a request mid-flight

Is is possible to cancel a request mid-flight? I've taken a look at the code of Ethon::Multi and it has delete method. Here's what I've tried to do and ended up with a segfault:
#!/usr/bin/env ruby

require 'typhoeus'

hydra = Typhoeus::Hydra.new()
request = Typhoeus::Request.new('http://example.com')
request.on_headers do |response|
  # Examine the headers, decide that we don't like them, cancel request
  handle = hydra.multi.easy_handles.first
  hydra.multi.delete(handle)
end

request.on_complete do |response|
  response # <--- segfault time!
end

hydra.queue(request)
hydra.run

you should be able to abort a request by returning :abort from the on_body request: https://github.com/typhoeus/ethon/blob/8d376542f8ff43e2040ed3b3641533baa2a4a898/lib/ethon/easy/callbacks.rb#L42. It is probably possible to do for on_header but not yet implemented in ethon.

I see :+1:
OK, maybe I'll look into implementing the same functionality for on_header. In some cases I think it makes perfect sense to abort in on_headers if we're seeing a bad response code.

👍


How to replace TTS

Thanks for the great project. I followed the changes, and replaced STT using Azure STT. And I want to replace the TTS, have you tried this ?

You mean you want to replace the text-to-speech on Vector?

Yes, i want to replace text to speech with Azure TTS.
Then change Q&A service too, i think the Q&A service should be in cloud, so it may be easier.

That would require DDL to release more source code and it would be out of the scope for this project, since it is done locally on Vector and not in a server. For replacing the Q&A service, I would look in the knowledgegraph.go file


Fix pnpm lockfile

pnpm install
I guess this got broken by a recent dependabot PR (maybe because of a badly handled merge conflict (or something that wasn't actually surfaced as a merge conflict but which disagreed between two PRs)).

Yeah, I think there might have been a bad merge between #3585 and #3586.


Moving cache folder out of files directory requires overriding constant REL_DIR_FILES_CACHE

Due to our infrastructure setup we wanted to move the cache files out of the files folder and into application/cache.
Specifying cache folder was easy (concrete.php in application/config) but the CssAsset  and JavaScriptAsset files use the constant REL_DIR_FILES_CACHE to specify where the cached files are located. As such we had to override this constant in application/config/start.php -
define('REL_DIR_FILES_CACHE', '/application/cache');

It feels like this should be able to be controlled via the cache settings in application/config/concrete.php.

Related to #2507


SSKDF with KMAC: "missing message digest"

OpenSSL version: 3.0.7
When trying to derive keys using SSKDF with KMAC128 or KMAC256, OpenSSL returns an error:
40671FF4307F0000:error:1C800081:Provider routines:sskdf_size:missing message digest:providers/implementations/kdfs/sskdf.c:338:

However, the man page mentions that the digest parameter is only required for hash-based and HMAC-based SSKDF. Why does the SSKDF implementation assume the digest is present: https://github.com/openssl/openssl/blob/openssl-3.0/providers/implementations/kdfs/sskdf.c#L332-L343?
Perhaps the ctx->out_len value should be checked here first? This value is set by OSSL_KDF_PARAM_MAC_SIZE here: https://github.com/openssl/openssl/blob/openssl-3.0/providers/implementations/kdfs/sskdf.c#L475-L480

Also note that the man page example for KMAC128 also sets the digest parameter to SHA-256:
*p++ = OSSL_PARAM_construct_utf8_string(OSSL_KDF_PARAM_DIGEST,
                                        SN_sha256, strlen(SN_sha256));

The pod example seems wrong..
There is an example of how to set up a kmac in evp_kdf_ss_kmac (see test_kdf_ss_kmac).
It does not need the digest.

Can you provide the code you are using please, so I can see the difference between this and the expected usage in the test.?

Something like this:
int main() {
	const unsigned char in_key[16];
	const unsigned char salt[64];
	const unsigned char info[64];
	unsigned char out_key[64];
	size_t out_key_len = sizeof(out_key);
	int ret;

	OSSL_PARAM_BLD *bld = OSSL_PARAM_BLD_new();
	OSSL_PARAM_BLD_push_utf8_string(bld, OSSL_KDF_PARAM_MAC, "KMAC128", 0);
	OSSL_PARAM_BLD_push_size_t(bld, OSSL_KDF_PARAM_MAC_SIZE, 64);
	OSSL_PARAM_BLD_push_octet_string(bld, OSSL_KDF_PARAM_KEY, in_key, 16);
	OSSL_PARAM_BLD_push_octet_string(bld, OSSL_KDF_PARAM_SALT, salt, sizeof(salt));
	OSSL_PARAM_BLD_push_octet_string(bld, OSSL_KDF_PARAM_INFO, info, sizeof(info));
	OSSL_PARAM *params = OSSL_PARAM_BLD_to_param(bld);

	EVP_KDF *kdf = EVP_KDF_fetch(NULL, "SSKDF", NULL);
	if (kdf == NULL) {
		ERR_print_errors_fp(stdout);
		return 1;
	}
	EVP_KDF_CTX *ctx = EVP_KDF_CTX_new(kdf);
	if (ctx == NULL) {
		ERR_print_errors_fp(stdout);
		return 1;
	}
	if ((ret = EVP_KDF_CTX_set_params(ctx, params)) != 1) {
		ERR_print_errors_fp(stdout);
		return 1;
	}
	size_t kdf_size = EVP_KDF_CTX_get_kdf_size(ctx);
	if (kdf_size < SIZE_MAX) {
		out_key_len = kdf_size;
	}
	if ((ret = EVP_KDF_derive(ctx, out_key, out_key_len, NULL)) != 1) {
		ERR_print_errors_fp(stdout);
		return 1;
	}
	printf("Key generation successful!\n");
}

The output length is whatever size you want?

i.e One of the inputs to KMAC is the output length - since it is variable size..

According to https://www.openssl.org/docs/man3.0/man3/EVP_KDF_CTX_get_kdf_size.html:

EVP_KDF_CTX_get_kdf_size() returns the output size if the algorithm produces a fixed amount of output and SIZE_MAX otherwise. If an error occurs then 0 is returned. For some algorithms an error may result if input parameters necessary to calculate a fixed output size have not yet been supplied.

So perhaps the KMAC length isn't the right output, but it should be SIZE_MAX?

Yeah probably, but I would tend to think that in the example that you present that you wouldnt want to call it at all? What use is a return value of SIZE_MAX to you use case?. I can change the code, but it doesnt really help you.

I will fix up the code.. But this logic does not make any sense for a variable length output..
	size_t kdf_size = EVP_KDF_CTX_get_kdf_size(ctx);
	if (kdf_size < SIZE_MAX) {
		out_key_len = kdf_size;
	}

You may want to free the kdf, ctx, params and bld..

Well, I actually perform different KDFs depending on the input arguments of my function. For some KDFs, the EVP_KDF_CTX_get_kdf_size call is useful. Yes, technically I could have a check for SSKDF with KMAC specifically to not invoke this call, but it's a bit unexpected. I would expect it to work, and it could actually be useful in a case like this (pseudocode):
// out_key_len = 0 means: determine output length automatically.
int do_kdf(const char *name, size_t out_key_len) {
    // Set up KDF...

    size_t kdf_size = EVP_KDF_CTX_get_kdf_size(ctx);
    if (kdf_size == 0) {
        printf("Error in EVP_KDF_CTX_get_kdf_size\n");
        return 1;
    }
    if (kdf_size == SIZE_MAX) {
        if (out_key_len == 0) {
            printf("expected out_key_len != 0\n");
            return 1;
        }
    } else {
        if (out_key_len != 0) {
            printf("expected out_key_len == 0\n");
            return 1;
        }
        out_key_len = kdf_size;
    }

    // Do KDF...
}

Fair enough.. You could potentially have truncated values for the else case that are valid so that logic might not be quite right..
I better go and check the code I added for HKDF to support KMAC a few days ago - it may have the same size related problem.. Thanks.

You could potentially have truncated values for the else case that are valid so that logic might not be quite right..

What do you mean?

I mean the output length can be less than the digest size.

See the test vectors in test/recipies/30_test_evp_data/evpkdf_ss.txt for SHA1

Thanks, that makes sense, I'll fix that


VERCEL Deployment: Impossible to deploy vercel when using "VITE"

What is the location of your example repository?
Hydrogen Demo Store
Which package or tool is having this issue?
Hydrogen
What version of that package or tool are you using?
2024.1.4
What version of Remix are you using?
2.8.0
Steps to Reproduce
Try to deploy the Hydrogen demo store to Vercel
Expected Behavior
Deploy the hydrogen demo store when using vite.
Actual Behavior
I got these issue:

With Vercel cli:

It's worked fine when run build and preview in local with minioxygen runtime.

The server build is created by default in dist/server/index.js. Perhaps you need to tell Vercel where to find it?
You can also modify this in vite.config.js, in the remix(...) plugin.
Also, if you're not going to deploy to Oxygen, you probably can build the project using Remix CLI or Vite directly instead of Hydrogen CLI.

Vercel is now providing support for Remix with Vite with a preset.

@frandiox I'm also trying to deploy to Vercel but I don't see any option to set the entry point for server. Do you know any ressource that can help us to deploy to Vercel ?

Also do you have a working example for the vite.config.js part ?

Is there any repository we can refer to if we want deploy the latest hydrogen to vercel?
The vercelPreset() is not working.

Vercel is now providing support for Remix with Vite with a preset.

@frandiox I'm also trying to deploy to Vercel but I don't see any option to set the entry point for server. Do you know any ressource that can help us to deploy to Vercel ?

Also do you have a working example for the vite.config.js part ?

any ressource, or repository we can refer to? @frandiox


generate contact sheet

Add an option to the automation panel to create a contact sheet HTML file, which would present all of the generated images along with their features in a simple table.

Duplicate issue, closing.


url_launcher (iOS only): PlatformException when attempting opening an oauth URL for the 2nd time

I am attempting to call my endsession OIDC endpoint using the url_launcher package (6.1.0). Everything works as expected on Android. On iOS, I'm receiving a PlatformException.
Steps to Reproduce

Ensure Flutter 2.10.5 is installed on macOS.
Create a new Flutter project
Replace main.dart with the following: (see "Code Sample" below)
3a. Ensure the following is added to the iOS project's Info.plist as a URL Schema:

<key>CFBundleURLTypes</key>
<array>
  <dict>
    <key>CFBundleTypeRole</key>
    <string>Editor</string>
    <key>CFBundleURLSchemes</key>
    <array>
      <string>com.manninglabs.steadycalendar</string>
    </array>
  </dict>
</array>

Execute flutter run on the code sample
When the app runs, click the blue "Open URL" button.
Proceed to authenticate with Google.
After a successful authentication, simply close the web view by tapping Done at the top left.
Stop the app.
Start the app again, click the blue "Open URL" button to open the web view again.
You'll notice that the app crashes with the message:

2022-05-05 18:26:01.769507-0400 Runner[23134:1476616] [VERBOSE-2:ui_dart_state.cc(209)] Unhandled Exception: PlatformException(Error, Error while launching https://kjrhibtvtcvdliankmqh.supabase.co/auth/v1/authorize?provider=google&redirect_to=com.manninglabs.steadycalendar%3A%2F%2Flogin-callback%2F, null, null)
#0      StandardMethodCodec.decodeEnvelope (package:flutter/src/services/message_codecs.dart:607:7)
#1      MethodChannel._invokeMethod (package:flutter/src/services/platform_channel.dart:167:18)
<asynchronous suspension>
#2      launch (package:url_launcher/url_launcher.dart:99:23)
<asynchronous suspension>

Expected results:
Expect the app to not crash.
Actual results:
App crashes.

Code sample
See above in step 3.
import 'package:flutter/material.dart';
import 'package:url_launcher/url_launcher.dart';

void main() => runApp(MyApp());

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      debugShowCheckedModeBanner: false,
      title: 'Material App',
      theme: ThemeData.dark(),
      home: Home(),
    );
  }
}

class Home extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return Scaffold(
      body: Center(
        child: RaisedButton(
          onPressed: _launchURL,
          child: Text('Open URL'),
        ),
      ),
    );
  }
}

_launchURL() async {
  const url =
      'https://zoxrlbhkzaifzaxsaamh.supabase.co/auth/v1/authorize?provider=google&redirect_to=com.manninglabs.steadycalendar%3A%2F%2Flogin-callback%2F';
  if (await canLaunch(url)) {
    await launch(url);
  } else {
    throw 'Could not launch $url';
  }
}

Logs
[VERBOSE-2:ui_dart_state.cc(209)] Unhandled Exception: PlatformException(Error, Error while launching https://zoxrlbhkzaifzaxsaamh.supabase.co/auth/v1/authorize?provider=google&redirect_to=com.manninglabs.steadycalendar%3A%2F%2Flogin-callback%2F, null, null)
#0      StandardMethodCodec.decodeEnvelope
package:flutter/…/services/message_codecs.dart:607
#1      MethodChannel._invokeMethod
package:flutter/…/services/platform_channel.dart:177
<asynchronous suspension>
#2      launch
package:url_launcher/src/legacy_api.dart:102
<asynchronous suspension>
#3      _launchURL
package:steadycalendar/main.dart:43
<asynchronous suspension>

flutter analyze

Analyzing .Trash...
No issues found! (ran in 0.7s)

flutter doctor -v
[✓] Flutter (Channel stable, 2.10.5, on macOS 12.3.1 21E258 darwin-arm, locale en-US)
    • Flutter version 2.10.5 at /Users/seenickcode/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 5464c5bac7 (2 weeks ago), 2022-04-18 09:55:37 -0700
    • Engine revision 57d3bac3dd
    • Dart version 2.16.2
    • DevTools version 2.9.2

[!] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
    • Android SDK at /Users/seenickcode/Library/Android/sdk
    ✗ cmdline-tools component is missing
      Run `path/to/sdkmanager --install "cmdline-tools;latest"`
      See https://developer.android.com/studio/command-line for more details.
    ✗ Android license status unknown.
      Run `flutter doctor --android-licenses` to accept the SDK licenses.
      See https://flutter.dev/docs/get-started/install/macos#android-setup for more details.

[✓] Xcode - develop for iOS and macOS (Xcode 13.3.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • CocoaPods version 1.11.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2020.3)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.10+0-b96-7249189)

[✓] Android Studio (version 2020.3)
    • Android Studio at /Users/seenickcode/Downloads/Android Studio 2.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.10+0-b96-7249189)

[✓] IntelliJ IDEA Ultimate Edition (version 2021.2.3)
    • IntelliJ at /Applications/IntelliJ IDEA.app
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart

[✓] VS Code (version 1.67.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.40.0

[✓] Connected device (2 available)
    • iPhone SE (3rd generation) (mobile) • E273BFC8-5473-4F98-B47A-10E92452F34D • ios            • com.apple.CoreSimulator.SimRuntime.iOS-15-4 (simulator)
    • Chrome (web)                        • chrome                               • web-javascript • Google Chrome 101.0.4951.54

[✓] HTTP Host Availability
    • All required HTTP hosts are available

! Doctor found issues in 1 category.

That zoxrlbhkzaifzaxsaamh.supabase.co url isn't connecting for me. @seenickcode can you check it out?

@jmagman try again please. (The supabase project hosting that URL had been asleep so just woke it up.) Thank you for your help.

I can't squeeze any error out from launching it from Safari or a web view, just a bool that it fails to launch.  It's also failing on web, I can see more in the console:
Failed to launch 'com.manninglabs.steadycalendar://login-callback/#access_token=<longaccesstoken>&refresh_token=<refresh_token>&token_type=bearer' because the scheme does not have a registered handler.

Are you sure this is only not working on iOS?  Can you try on web flutter run -d chrome?

I cannot reproduce the crash on Chrome.
So it appears I can reproduce the crash with url_launcher v6.0.10 (only on iOS) but not with the newest v6.1.2. Closing.
Thank you, @jmagman for helping out!


[Question] _How do I use the hinting system

Hi,
I wanted to know how to use the hinting feature to navigate windows using the keyboard.
I can't figure out how to use this.....
Can someone help?
Thanks

I enter the GUI normal mode as per the tutorial and start mspaint,
But I can't seem to bring up easy click by pressing FF.

FF is equal to <shift-f><shift-f>, is that correct?
If there is some errors, they will be outputed into ~/.win-vind/log/**.log.
Thanks!

Aah yes that works.

how to express when I want hit f key twice, which is all lowercase. such as ff. @pit-ray


[Scene] Add SceneStringNames::id_pressed

See also:

https://github.com/godotengine/godot/pull/91939

Thank you!


Added HTTP basic auth support for httpget

I implemented a service that provides AWS credentials via HTTP to updated expired tokens. However, I would prefer to at least have HTTP basic authentication on this service. With this change you don't have to change anything in the UI.
It should be noted that this might not be the ideal implementation, I just hacked it together to make it work. Feel free to propose any other solution that accomplishes the same.

ping

I could update the UI to allow a custom header. Then you could add Authorization: Basic ....

I think that should work as well, thanks!

I added a custom header in https://github.com/anvilsecure/aws-sigv4/commit/a5036eaf75b7af0d1bca6b207c52b7681b5ac0d2
I think something like this was definitely needed, thanks for the PR.


Wrong Link to Pulumi Terraform Bridge in Terraform vs. Pulumi

Problem description
https://www.pulumi.com/docs/intro/vs/terraform/- The link "Pulumi Terraform bridge repo" points to the wrong repo.
Suggestions for a fix
Replace https://github.com/pulumi/pulumi-terraform with https://github.com/pulumi/pulumi-terraform-bridge

Oh my apologies for that - we changed it and I didn't realise that was outstanding. I will fix those docs now

Closed via #2758


Cannot access 'exports' before initialization

Component or Package Name: jsx-email
Component or Package Version: 2.1.3
@jsxp-email/cli Version?:
Operating System (or Browser): macOS
Node Version: 22.11.0
Link to reproduction (⚠ read below):

Expected Behavior
The render function is working in CommonJS
Actual Behavior
I use a monorepo with pnpm and turborepo, when I trigger programmaticaly an email with the render function, the API throw this error:
ReferenceError: Cannot access 'exports' before initialization     at loadConfig (/node_modules/.pnpm/jsx-email@2.1.2_@jsx-email+app-preview@1.2.6_@types+node@22.8.5_react@18.3.1_rollup@4.24.0_sa_mdygf2jpttdrtguyc2kz5zafcm/node_modules/jsx-email/src/config.ts:215:56)     at render (/node_modules/.pnpm/jsx-email@2.1.2_@jsx-email+app-preview@1.2.6_@types+node@22.8.5_react@18.3.1_rollup@4.24.0_sa_mdygf2jpttdrtguyc2kz5zafcm/node_modules/jsx-email/src/renderer/render.ts:28:32)
The offending code in cjs is the following:
if (globalThis[exports.globalConfigSymbol])         return globalThis[exports.globalConfigSymbol];     ...     const exports = searchResult?.config ?? {};
There is a mix between the exports keyword and the exports variable, you should rename the exports variable to avoid this name collision.
Additional Information

If you don't provide a reproduction, we cannot help you.

Here is the reproduction link:
https://stackblitz.com/edit/jsx-email-repro-gkk1ey?file=package.json
In the terminal, "npm run dev" should triggered the error

Thanks. Looking into it.

I have a fix. Should be up within the hour.

Thanks a lot !


Binary wrappers don't support "quoted multivalue" variables

Calling a command that wraps around a binary does not respect values that are quoted.
Commands affected:

bin/composer
bin/drush
bin/coder

Examples:

--test="abc def" will be passed as --test="abc".
bin/drush "command path" will be passed as drush command path.

See PR #38

Fixed.


Roll engine e4f46f32f1fd..0e8ed2715a35 (21 commits)

https://github.com/flutter/engine/compare/e4f46f32f1fd...0e8ed2715a35
git log e4f46f32f1fd..0e8ed2715a35 --first-parent --oneline
2020-02-10<EMAIL_ADDRESS>Roll src/third_party/dart b158bf7bd537..5244d99a5d4e (1 commits) (flutter/engine#16517)
2020-02-10<EMAIL_ADDRESS>Adds new route annoucement method. (flutter/engine#16523)
2020-02-10<EMAIL_ADDRESS>Remove mirrors on the web (flutter/engine#16516)
2020-02-10<EMAIL_ADDRESS>Apply lints from internal roll (flutter/engine#16509)
2020-02-10<EMAIL_ADDRESS>Partially fix canvas vs text paint order when running on Blink/Webkit browsers (flutter/engine#16483)
2020-02-10<EMAIL_ADDRESS>Use Skia to determine "actual" font name in CanvasKit backend (flutter/engine#16504)
2020-02-09<EMAIL_ADDRESS>Roll src/third_party/dart f120417ddbfc..b158bf7bd537 (2 commits) (flutter/engine#16514)
2020-02-08<EMAIL_ADDRESS>Roll src/third_party/dart 9464eb51f539..f120417ddbfc (1 commits) (flutter/engine#16513)
2020-02-08<EMAIL_ADDRESS>Roll fuchsia/sdk/core/mac-amd64 from FLFOw... to PMcw3... (flutter/engine#16512)
2020-02-08<EMAIL_ADDRESS>Roll src/third_party/dart 4310f50edc95..9464eb51f539 (2 commits) (flutter/engine#16511)
2020-02-08<EMAIL_ADDRESS>Roll src/third_party/skia 8dad1ffd81f8..c03e6982f96f (2 commits) (flutter/engine#16510)
2020-02-08<EMAIL_ADDRESS>Roll fuchsia/sdk/core/linux-amd64 from LvSlH... to 8L7NY... (flutter/engine#16508)
2020-02-08<EMAIL_ADDRESS>Roll src/third_party/dart fd992e423ef6..4310f50edc95 (17 commits) (flutter/engine#16506)
2020-02-08<EMAIL_ADDRESS>Roll src/third_party/skia a9405c2a2967..8dad1ffd81f8 (1 commits) (flutter/engine#16505)
2020-02-08<EMAIL_ADDRESS>Roll src/third_party/skia b2031d4255e2..a9405c2a2967 (5 commits) (flutter/engine#16502)
2020-02-08<EMAIL_ADDRESS>Apply Google Java format (flutter/engine#16501)
2020-02-08<EMAIL_ADDRESS>Check Java formatting in format.sh (flutter/engine#16500)
2020-02-07<EMAIL_ADDRESS>Roll src/third_party/skia 9f3eef796f63..b2031d4255e2 (12 commits) (flutter/engine#16499)
2020-02-07<EMAIL_ADDRESS>Fix safe area reporting with transparent FlutterActivitys. (#46060) (flutter/engine#16208)
2020-02-07<EMAIL_ADDRESS>Roll fuchsia/sdk/core/mac-amd64 from fvWgE... to FLFOw... (flutter/engine#16498)
2020-02-07<EMAIL_ADDRESS>[SkParagraph] Text layout benchmarks using SkParagraph (flutter/engine#16373)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Landed manually since framework tree has been flaky and the roll hasn't been able to land.


第三章的横向联邦图像分类报错OSError: [Errno 22] Invalid argument

Files already downloaded and verified
Traceback (most recent call last):
File "main.py", line 25, in
server = Server(conf, eval_datasets)
File "/Users/huqiming/Library/CloudStorage/OneDrive-stu.cdut.edu.cn/bs/Practicing-FL/Practicing-Federated-Learning-main/chapter03_Python_image_classification/server.py", line 11, in init
self.global_model = models.get_model(self.conf["model_name"])
File "/Users/huqiming/Library/CloudStorage/OneDrive-stu.cdut.edu.cn/bs/Practicing-FL/Practicing-Federated-Learning-main/chapter03_Python_image_classification/models.py", line 7, in get_model
model = models.resnet18(pretrained=pretrained)
File "/Users/huqiming/opt/anaconda3/envs/py37/lib/python3.7/site-packages/torchvision/models/resnet.py", line 277, in resnet18
**kwargs)
File "/Users/huqiming/opt/anaconda3/envs/py37/lib/python3.7/site-packages/torchvision/models/resnet.py", line 263, in _resnet
progress=progress)
File "/Users/huqiming/opt/anaconda3/envs/py37/lib/python3.7/site-packages/torch/hub.py", line 590, in load_state_dict_from_url
return torch.load(cached_file, map_location=map_location)
File "/Users/huqiming/opt/anaconda3/envs/py37/lib/python3.7/site-packages/torch/serialization.py", line 600, in load
with _open_zipfile_reader(opened_file) as opened_zipfile:
File "/Users/huqiming/opt/anaconda3/envs/py37/lib/python3.7/site-packages/torch/serialization.py", line 242, in init
super(_open_zipfile_reader, self).init(torch._C.PyTorchFileReader(name_or_buffer))
OSError: [Errno 22] Invalid argument
环境：
python3.7;
torchaudio0.10.2;
torchvision0.11.3

问题解决了，M1 pro的MAC不知道为什么用不了，换成Windows 10就可以了


Fix link to GEO for one sample in RNA-Seq Ref based tutorial

nice catch

It was catched by @afalaki in #280


Refactor for credential helper

Using native python libraries is introducing a serious dependency management risk due to the state of python environments we want to integrate with. To remove the burden of the vendored packages and associated patches, include and call a binary credential helper. The python plugin code is still responsible for parsing the config and updating the repository object headers, but detecting credentials and generating tokens is offloaded to the helper.
Tested builds and installed on RHEL7 and RHEL8 hosts to test authenticated repo access. No config change was required when using these.
dnf-plugin-artifact-registry:
Name        : dnf-plugin-artifact-registry
Epoch       : 1
Version     : 1testing
Release     : g1.el8
Architecture: x86_64
Install Date: (not installed)
Group       : Unspecified
Size        : 5247647
License     : ASL 2.0
Signature   : (none)
Source RPM  : dnf-plugin-artifact-registry-1testing-g1.el8.src.rpm
Build Date  : Wed 14 Dec 2022 08:52:47 PM UTC
Build Host  : inst-build-pkg-el8-build-package-qsl6d.c.<redact>.internal
Relocations : (not relocatable)
URL         : https://cloud.google.com/artifact-registry
Summary     : dnf plugin for Artifact Registry
Description :
Contains a dnf plugin for authenticated access to Artifact Registry repositories.
config(dnf-plugin-artifact-registry) = 1:1testing-g1.el8
dnf >= 1.0.0
rpmlib(CompressedFileNames) <= 3.0.4-1
rpmlib(FileDigests) <= 4.6.0-1
rpmlib(PartialHardlinkSets) <= 4.0.4-1
rpmlib(PayloadFilesHavePrefix) <= 4.0-1
rpmlib(PayloadIsXz) <= 5.2-1
/etc/dnf/plugins/artifact-registry.conf
/usr/lib/python3.6/site-packages/dnf-plugins/__pycache__/artifact-registry.cpython-36.opt-1.pyc
/usr/lib/python3.6/site-packages/dnf-plugins/__pycache__/artifact-registry.cpython-36.pyc
/usr/lib/python3.6/site-packages/dnf-plugins/artifact-registry.py
/usr/libexec/ar-token
/usr/share/doc/dnf-plugin-artifact-registry
/usr/share/doc/dnf-plugin-artifact-registry/LICENSE

yum-plugin-artifact-registry:
Name        : yum-plugin-artifact-registry
Epoch       : 1
Version     : 1testing
Release     : g1.el7
Architecture: x86_64
Install Date: (not installed)
Group       : Unspecified
Size        : 5246846
License     : ASL 2.0
Signature   : (none)
Source RPM  : yum-plugin-artifact-registry-1testing-g1.el7.src.rpm
Build Date  : Wed 14 Dec 2022 08:37:55 PM UTC
Build Host  : inst-build-pkg-el7-build-package-yjws8.c.<redact>.internal
Relocations : (not relocatable)
URL         : https://cloud.google.com/artifact-registry
Summary     : Yum plugin for Artifact Registry
Description :
Contains a Yum plugin for authenticated access to Artifact Registry repositories.
config(yum-plugin-artifact-registry) = 1:1testing-g1.el7
rpmlib(CompressedFileNames) <= 3.0.4-1
rpmlib(FileDigests) <= 4.6.0-1
rpmlib(PartialHardlinkSets) <= 4.0.4-1
rpmlib(PayloadFilesHavePrefix) <= 4.0-1
yum >= 3.0
rpmlib(PayloadIsXz) <= 5.2-1
/etc/yum/pluginconf.d/artifact-registry.conf
/usr/lib/yum-plugins/artifact-registry.py
/usr/lib/yum-plugins/artifact-registry.pyc
/usr/lib/yum-plugins/artifact-registry.pyo
/usr/libexec/ar-token
/usr/share/doc/yum-plugin-artifact-registry-1testing
/usr/share/doc/yum-plugin-artifact-registry-1testing/LICENSE

This presubmit is actually not valid. Amending in GoogleCloudPlatform/oss-test-infra#1855
Will rerun presubmits after this is merged.

/retest


SFB Online, is it supported or not

Why are you gumming up your own documentation for Teams DNS requirements with a product you no longer support?
https://learn.microsoft.com/en-us/microsoft-365/enterprise/external-domain-name-system-records?view=o365-worldwide#external-dns-records-required-for-teams-and-skype-for-business-online
You have lyncdiscover as a cname included twice, and one entry says teams still requires it while the other entry says it's only required for SFB Online.  Just get rid of all the unsupported product information and list the Teams DNS requirements.

@msbemba Thank you very much for the contribution and updating the documentation with PR. @robgeach Hope this update is helpful for you. Thanks for taking out some time to open the issue. Appreciate and encourage you to do the same in future also.


Add a num_cpus() function

This is useful for when you are calling make from Just and want to pass a -j argument

Nice, merged!


Failing executions marked as successful

When invoking a transaction from this account.
cairo 1 account.
It should return an error, but instead it doesn't.

thanks for reporting it, we'll take a look

Do you have an example test case like in the other issue? It would be of great help.
I'm looking into it now.

Unfortunately, I dont have an example testnet setup.

I tried to replicate the bug, but in my test case it succesfully panics with the correct message 'panic'.
https://github.com/lambdaclass/starknet_in_rust/pull/1045/files


Replace liborigin with generated parser

Hi. I was searching GH for documentation on origin file format to write its description in machine-readable way to generate a parser and found

trace the memleaks and errors in the liborigin code

in your markdown readme. Are you familiar with origin format well enough to either give me an overview of it (the pieces missing from https://github.com/jgonera/openopj/blob/master/docs/opj_format.markdown) or fill the gaps in my code?
meta:
  id: origin
  file-extension: opj
  application: Origin
  endian: be
doc: >
  https://github.com/jgonera/openopj/blob/master/docs/opj_format.markdown
seq:
  - id: signature
    type: signature
  - id: header
    type: header
  - id: data_list
    type: data_list
  - id: window_list
    type: window_list
  - id: parameters_section
    type: parameters_section
  - id: note_list
    type: note_list
  - id: project_tree
    type: project_tree
  - id: attachment_list
    type: attachment_list
types:
  cpya_ver:
    seq:
      - id: major
        type: strz
        terminator: "."
      - id: minor
        type: strz
        terminator: " "
  signature:
    seq:
      - id: sig_seq
        content: "CPYA "
      - id: cpya_ver
        type: cpya_ver
      - id: build_number
        type: strz
        terminator: "#"
      - id: line_terminator
        contents: "\n"
  header_data_block:
    seq:
      - id: unknown
        size: 27
      - id: version
        type: f8
      - id: unknown1
        size: 4
  data_section:
    seq:
      - id: header
        size: 27
      - id: content
        type: f8
      - id: null_block
        type: null_block
  data_header_flags:
    seq:
      - id: unkn0
        type: b4
      - id: integers
        type: b1
      - id: unkn1
        type: b2
      - id: text_and_numeric
        type: b1
      - id: unkn2
        type: b8
  text_or_numeric:
    doc: "In case of Text values, the value is a null-terminated string. The bytes after the null are garbage or earlier contents of the value and can be disregarded."
    seq:
      - id: unkn0
        type: u8
        doc: "If the first byte is equal 0, the value is a double, if it's 1, the value is a string."
      - id: unkn1
        contents: [0]
        doc: " The second prefix byte seems to be always 0."
      - id: value
        type:
          switch-on: unkn0
          cases:
            0: f8
            1: strz
  data_header:
    seq:
      - id: unknown0
        size: 22
      - id: flags
        type: data_header_flags
      - id: data_type2
        type: u1
      - id: total_rows
        type: u4
      - id: first_row
        type: u4
      - id: last_row
        type: u4
      - id: unknown1
        size: 24
      - id: value_size
        type: u1
      - id: unknown2
        type: u1
      - id: data_type_u
        type: u1
      - id: unknown3
        size: 24
      - id: data_name
        type: strz
        size: 25
        doc: "Data name, for worksheets it's \"WORKSHEET_COLUMN\". Column is at most 18 chars long, remaining characters are used for \"_\", terminating null byte and worksheet name which may be truncated if too long."
      - id: data_type3
        type: u2
        doc: "According to [importOPJ][] the bytes starting at 0x0071 (start of this field) didn't exist before Origin 5.0."
      - id: unknown4
        type: u8
        doc: "Always zeros?"
    instances:
      rows:
        doc: >
          The data content block consists of consecutive values (e.g. consecutive rows in a worksheet column). The number of rows is `totalRows`. `firstRow` indicates the first non-empty row (0 is the first row) and `lastRow` indicates the last non-empty row.
          It should be enough to parse the values up to `lastRow` and skip the remaining ones.
          The format of the value seems to depend on `valueSize` and `dataType`:
             According to [liborigin][] `dataTypeU = 8` means that an integer value is unsigned (this is not verified).
             `valueSize = 1` seems to be rare or non-existent, at least in Origin 7.0552.
        size: value_size
        repeat: expr
        repeat-expr: total_rows
        type:
          switch-on: value_size
          cases:
            1: u1
            2: u2
            4: u4 #or f4
            8: f8
            #valueSize > 8: Text
            #valueSize > 8 and dataType & 0x100: text_or_numeric

  window_section_header:
    doc: >
      As of now, the description of window list and its subsections is incomplete and merely serves as an indication of how to skip to the parameters section.
      window_section contains a header block and a layer list.
    seq:
      - id: unknown0
        size: 2
        doc: "Unknown, always zero?"
      - id: name
        type: strz
        size: 25
      - id: unknown2
        size: n
        doc: "See importOPJ for details"
  ### Parameters section
  parameters_section_header:
    doc: >
      This section does not contain blocks. Instead it contains an arbitrary number of parameter elements.
      window_section contains a header block and a layer list.
      The last parameter element is followed by a 0 byte and a line feed (`00 0A`), i.e. if you encounter a parameter name equal to "\0", there are no more parameter elements.
      The section ends with a null block (or possibly it's another section which is usually empty).
    seq:
      - id: name
        size: n
        type: str
      - id: lf0
        contents: "\n"
      - id: value
        type: f8
      - id: lf1
        contents: "\n"

Hi, unfortunately I am not familiar with the OPJ format. However, I am quite interested in helping you build such a parser, since the liborigin2 library often causes severe memory leaks which lead to filling of RAM and eventual crash of the application after several minutes of unusable workplace.
The author of liborigin2 also does not look like willing to collaborate too much, stating that "e-mails from persons "planning to work" will be ignored" on their website http://soft.proindependent.com/liborigin2/, and the last update of the website is nearly six years old. So I think there is a real need for a up-to-date OPJ parser.