Downloader - git checkout master often fails

A lot of git repositories renamed the master branch to main the downloaders default is to checkout master
It should be changed that the next try for checkout should be main before fetching everything,
0:22:07.460 [main] INFO  org.ossreviewtoolkit.downloader.Downloader - Trying to download 'Gem::google-cloud-core:1.6.0' sources to '/tmp/ort-ScanCode11212755666478816222/Gem/unknown/google-cloud-core/1.6.0' from VCS...
20:22:07.461 [main] INFO  org.ossreviewtoolkit.downloader.Downloader - Using processed VcsInfo(type=Git, url=https://github.com/googleapis/google-cloud-ruby.git, revision=master, path=google-cloud-core). Original was VcsInfo(type=, url=, revision=, path=).
20:22:07.461 [main] INFO  org.ossreviewtoolkit.downloader.Downloader - Detected VCS type 'Git' from type name 'Git'.
20:22:07.466 [main] INFO  org.ossreviewtoolkit.downloader.vcs.Git - Configuring Git to do sparse checkout of path 'google-cloud-core'.
20:22:07.875 [main] INFO  org.ossreviewtoolkit.downloader.vcs.Git - Adding Git revision 'master' (taken from package metadata) as a candidate.
20:22:08.319 [main] INFO  org.ossreviewtoolkit.downloader.vcs.Git - Adding Git revision 'google-cloud-core/v1.6.0' (guessed from package 'google-cloud-core' and version '1.6.0') as a candidate.
20:22:08.319 [main] INFO  org.ossreviewtoolkit.downloader.vcs.Git - Trying revision candidate 'master' (1 of 2)...
20:22:08.319 [main] INFO  org.ossreviewtoolkit.downloader.vcs.Git - Trying to fetch only revision 'master' with depth limited to 50.
20:22:08.320 [main] INFO  org.ossreviewtoolkit.utils.common.ProcessCapture - Running 'git fetch --depth 50 origin master' in '/tmp/ort-ScanCode11212755666478816222/Gem/unknown/google-cloud-core/1.6.0'...
20:22:08.968 [main] WARN  org.ossreviewtoolkit.downloader.vcs.Git - Could not fetch only revision 'master': IOException: Running 'git fetch --depth 50 origin master' in '/tmp/ort-ScanCode11212755666478816222/Gem/unknown/google-cloud-core/1.6.0' failed with exit code 128:
fatal: couldn't find remote ref master

Falling back to fetching all refs.
20:22:08.968 [main] INFO  org.ossreviewtoolkit.downloader.vcs.Git - Falling back to fetching all refs with depth limited to 50.
20:22:08.970 [main] INFO  org.ossreviewtoolkit.utils.common.ProcessCapture - Running 'git fetch --depth 50 --tags origin' in '/tmp/ort-ScanCode11212755666478816222/Gem/unknown/google-cloud-core/1.6.0'...
20:22:46.326 [main] INFO  org.ossreviewtoolkit.utils.common.ProcessCapture - Running 'git checkout master' in '/tmp/ort-ScanCode11212755666478816222/Gem/unknown/google-cloud-core/1.6.0'...
20:22:46.329 [main] WARN  org.ossreviewtoolkit.downloader.vcs.Git - Could not fetch with only a depth of 50: IOException: Running 'git checkout master' in '/tmp/ort-ScanCode11212755666478816222/Gem/unknown/google-cloud-core/1.6.0' failed with exit code 1:
error: pathspec 'master' did not match any file(s) known to git

Falling back to fetching everything.

Please note that not hard-coding the remote default branch "master" has been fixed about a year ago when resolving #3590.
In your case, the metadata for package Gem::google-cloud-core:1.6.0 at https://rubygems.org/api/v2/rubygems/google-cloud-core/versions/1.6.0.yaml explicitly sets the homepage_uri to https://github.com/googleapis/google-cloud-ruby/tree/master/google-cloud-core. Note how "master" is part of that URL, which is what ORT uses as candidate for the revision. ORT also adds the "google-cloud-core/v1.6.0" tag as a revision candidate, and it should succeed downloading it in the end (but I cannot tell for sure as your log is truncated).
So actually, everything should be fine here, except that the log output is a bit confusing maybe. And we should probably prefer tags over branches in the list of revision candidates.

thanks for your answer.
here is a more complete log:
20:22:07.460 [main] INFO  org.ossreviewtoolkit.scanner.PathScanner - Finished scanning Gem::google-apis-storage_v1:0.8.0 in thread 'main' (42 of 609).
20:22:07.460 [main] INFO  org.ossreviewtoolkit.scanner.PathScanner - Scanning Gem::google-cloud-core:1.6.0' in thread 'main' (43 of 609)
20:22:07.460 [main] INFO  org.ossreviewtoolkit.downloader.Downloader - Trying to download 'Gem::google-cloud-core:1.6.0' sources to '/tmp/ort-ScanCode11212755666478816222/Gem/unknown/google-cloud-core/1.6.0' from VCS...
20:22:07.461 [main] INFO  org.ossreviewtoolkit.downloader.Downloader - Using processed VcsInfo(type=Git, url=https://github.com/googleapis/google-cloud-ruby.git, revision=master, path=google-cloud-core). Original was VcsInfo(type=, url=, revision=, path=).
20:22:07.461 [main] INFO  org.ossreviewtoolkit.downloader.Downloader - Detected VCS type 'Git' from type name 'Git'.
20:22:07.466 [main] INFO  org.ossreviewtoolkit.downloader.vcs.Git - Configuring Git to do sparse checkout of path 'google-cloud-core'.
20:22:07.875 [main] INFO  org.ossreviewtoolkit.downloader.vcs.Git - Adding Git revision 'master' (taken from package metadata) as a candidate.
20:22:08.319 [main] INFO  org.ossreviewtoolkit.downloader.vcs.Git - Adding Git revision 'google-cloud-core/v1.6.0' (guessed from package 'google-cloud-core' and version '1.6.0') as a candidate.
20:22:08.319 [main] INFO  org.ossreviewtoolkit.downloader.vcs.Git - Trying revision candidate 'master' (1 of 2)...
20:22:08.319 [main] INFO  org.ossreviewtoolkit.downloader.vcs.Git - Trying to fetch only revision 'master' with depth limited to 50.
20:22:08.320 [main] INFO  org.ossreviewtoolkit.utils.common.ProcessCapture - Running 'git fetch --depth 50 origin master' in '/tmp/ort-ScanCode11212755666478816222/Gem/unknown/google-cloud-core/1.6.0'...
20:22:08.968 [main] WARN  org.ossreviewtoolkit.downloader.vcs.Git - Could not fetch only revision 'master': IOException: Running 'git fetch --depth 50 origin master' in '/tmp/ort-ScanCode11212755666478816222/Gem/unknown/google-cloud-core/1.6.0' failed with exit code 128:
fatal: couldn't find remote ref master

Falling back to fetching all refs.
20:22:08.968 [main] INFO  org.ossreviewtoolkit.downloader.vcs.Git - Falling back to fetching all refs with depth limited to 50.
20:22:08.970 [main] INFO  org.ossreviewtoolkit.utils.common.ProcessCapture - Running 'git fetch --depth 50 --tags origin' in '/tmp/ort-ScanCode11212755666478816222/Gem/unknown/google-cloud-core/1.6.0'...
20:22:46.326 [main] INFO  org.ossreviewtoolkit.utils.common.ProcessCapture - Running 'git checkout master' in '/tmp/ort-ScanCode11212755666478816222/Gem/unknown/google-cloud-core/1.6.0'...
20:22:46.329 [main] WARN  org.ossreviewtoolkit.downloader.vcs.Git - Could not fetch with only a depth of 50: IOException: Running 'git checkout master' in '/tmp/ort-ScanCode11212755666478816222/Gem/unknown/google-cloud-core/1.6.0' failed with exit code 1:
error: pathspec 'master' did not match any file(s) known to git

Falling back to fetching everything.
20:22:46.329 [main] INFO  org.ossreviewtoolkit.downloader.vcs.Git - Falling back to fetch everything including tags.
20:22:46.330 [main] INFO  org.ossreviewtoolkit.utils.common.ProcessCapture - Running 'git fetch --unshallow --tags origin' in '/tmp/ort-ScanCode11212755666478816222/Gem/unknown/google-cloud-core/1.6.0'...
20:23:29.784 [main] INFO  org.ossreviewtoolkit.utils.common.ProcessCapture - Running 'git checkout master' in '/tmp/ort-ScanCode11212755666478816222/Gem/unknown/google-cloud-core/1.6.0'...
20:23:29.786 [main] WARN  org.ossreviewtoolkit.downloader.vcs.Git - Failed to fetch everything: IOException: Running 'git checkout master' in '/tmp/ort-ScanCode11212755666478816222/Gem/unknown/google-cloud-core/1.6.0' failed with exit code 1:
error: pathspec 'master' did not match any file(s) known to git

20:23:29.786 [main] INFO  org.ossreviewtoolkit.downloader.vcs.Git - Trying revision candidate 'google-cloud-core/v1.6.0' (2 of 2)...
20:23:29.787 [main] INFO  org.ossreviewtoolkit.downloader.vcs.Git - Trying to fetch only revision 'google-cloud-core/v1.6.0' with depth limited to 50.
20:23:29.788 [main] INFO  org.ossreviewtoolkit.utils.common.ProcessCapture - Running 'git fetch --depth 50 origin google-cloud-core/v1.6.0' in '/tmp/ort-ScanCode11212755666478816222/Gem/unknown/google-cloud-core/1.6.0'...
20:23:31.740 [main] INFO  org.ossreviewtoolkit.utils.common.ProcessCapture - Running 'git tag -f google-cloud-core/v1.6.0 FETCH_HEAD' in '/tmp/ort-ScanCode11212755666478816222/Gem/unknown/google-cloud-core/1.6.0'...
20:23:31.743 [main] INFO  org.ossreviewtoolkit.utils.common.ProcessCapture - Running 'git checkout google-cloud-core/v1.6.0' in '/tmp/ort-ScanCode11212755666478816222/Gem/unknown/google-cloud-core/1.6.0'...
20:23:31.905 [main] INFO  org.ossreviewtoolkit.downloader.vcs.Git - Successfully downloaded revision google-cloud-core/v1.6.0 for package 'Gem::google-cloud-core:1.6.0.'.
20:23:31.906 [main] INFO  org.ossreviewtoolkit.downloader.Downloader - Finished downloading source code revision 'd3d6fd2fc732b76abe8459babf4b5dc000f3ce67' to '/tmp/ort-ScanCode11212755666478816222/Gem/unknown/google-cloud-core/1.6.0'.
20:23:31.906 [main] INFO  org.ossreviewtoolkit.scanner.scanners.scancode.ScanCode - Running ScannerDetails(name=ScanCode, version=30.1.0, configuration=--copyright --license --info --strip-root --timeout 300 --json-pp) on directory '/tmp/ort-ScanCode11212755666478816222/Gem/unknown/google-cloud-core/1.6.0'.
20:23:31.906 [main] INFO  org.ossreviewtoolkit.scanner.scanners.scancode.ScanCode - Archiving files for 'Gem::google-cloud-core:1.6.0'.
20:23:32.027 [main] INFO  org.ossreviewtoolkit.utils.common.ProcessCapture - Running '/usr/local/bin/scancode --copyright --license --info --strip-root --timeout 300 --processes 3 /tmp/ort-ScanCode11212755666478816222/Gem/unknown/google-cloud-core/1.6.0 --json-pp /tmp/ort-ScanCode4561876618655265927/result.json' in '/'...
20:25:25.538 [main] INFO  org.ossreviewtoolkit.scanner.PathScanner - Finished scanning Gem::google-cloud-core:1.6.0 in thread 'main' (43 of 609).
20:25:25.538 [main] INFO  org.ossreviewtoolkit.scanner.PathScanner - Scanning Gem::google-cloud-env:1.5.0' in thread 'main' (44 of 609)
20:25:25.539 [main] INFO  org.ossreviewtoolkit.downloader.Downloader - Trying to download 'Gem::google-cloud-env:1.5.0' sources to '/tmp/ort-ScanCode11212755666478816222/Gem/unknown/google-cloud-env/1.5.0' from VCS...
20:25:25.539 [main] INFO  org.ossreviewtoolkit.downloader.Downloader - Using processed VcsInfo(type=Git, url=https://github.com/googleapis/google-cloud-ruby.git, revision=master, path=google-cloud-env). Original was VcsInfo(type=, url=, revision=, path=).
20:25:25.539 [main] INFO  org.ossreviewtoolkit.downloader.Downloader - Detected VCS type 'Git' from type name 'Git'.
20:25:25.544 [main] INFO  org.ossreviewtoolkit.downloader.vcs.Git - Configuring Git to do sparse checkout of path 'google-cloud-env'.
20:25:26.029 [main] INFO  org.ossreviewtoolkit.downloader.vcs.Git - Adding Git revision 'master' (taken from package metadata) as a candidate.

Successfully downloaded revision google-cloud-core/v1.6.0 for package 'Gem::google-cloud-core:1.6.0.'.

Yupp, so all is good.
However, I'll make some improvements shortly about the order in which revision candidates are tried.

Feel free to verify whether https://github.com/oss-review-toolkit/ort/pull/4997 skips the tries to download from "master" in your case.


No way to determine which version (regular or Biz) should the user see

Since Personium does not have any way to determine which is which.
I am working on a proposal to solve the following issues.

There is no automated way to determine which HomeApp the User (data subject, object, passive user) or organization (data consumer/provider) must use.
Currently either version of HomeApp can be logged in.

In HomeApp, the list of installed apps contains HomeApp itself and accidentaly got rendered.
Current hotfix is not to render the app with the same box name as the running app (HomeApp).

Proposal
Introduce a new key/value pair ("CellType": <cell's type>) to profile.json so that the app can determine the rendering routine properly.
There are two major catogories of cell type.

"User"
"App"

Catogorized by "User" Type

"person"
Data subject which is supposed to be a "real" person.
Issue No.1 solved: HomeApp is the default app.
  {
      "DisplayName":"Guest",
      "Description":"",
      "Image": ...
      "CellType": "person"
  }

"organization"
Data consumer or provider which is an organziation.
Issue No.1 solved: HomeApp for Biz is the default app.
Examples: P's Mart
  {
      "DisplayName":　"P's Mart (Wakaba Branch)",
      "Description":　"",
      "Image": ...
      "CellType": "organization"
  }

"object"
Data subject which is an object.
Examples: car, apartment

"passive"
Passive user cell
Examples: infants, elderly

Catogorized by App Type
Except AdminApp, all other app types (CellApp/ClientApp/BizApp) got installed onto the cell as box.

"AdminApp"
Management app that can display all the details inside a unit cell or regular cell.
Examples: UnitManager, CellManager

"CellApp"
Management app that display client/business apps
Issue No.2: Basice rule for a CellApp is not to display any CellApp.
Examples: HomeApp, HomeApp for Biz
  {
      "DisplayName":"HomeApp",
      "Description":"ホームアプリセル",
      "Image": ...
      "CellType": "CellApp"
  }

"ClientApp"
Client app for data subject.
Examples: MyBoard, Calorie Smile, Wakaba Municipal Info Bank
  {
      "DisplayName": {
          "en": "MyBoard",
          "ja": "マイボード"
      },
      "Description": {
          "en": "Demo application (MyBoard).",
          "ja": "デモアプリ「マイボード」"
      },
      "Image": ...
      "CellType": "ClientApp"
  }

"BizApp"
Business app for data consumer/provider.
Examples: Wakaba Municipal Info Bank for Biz
  {
      "DisplayName": {
          "en": "Wakaba Municipal Info Bank",
          "ja": "わかば市情報バンク"
      },
      "Description": {
          "en": "Admin application for Wakaba Municipal Info Bank.",
          "ja": "わかば市情報バンクアプリセルです。"
      },
      "Image": ...
      "CellType": "BizApp"
  }

I think the newly introduced key "CellType" should rather be  just "Type" because profile.json is a file for describing the profile of the Cell.

We should not probably introduce type value "passive".  Instead it should be handled with another key, e.g. ("Passive": true or "Active": false) later.   A person, organization or object..  may be passive, whereas other person, organization or object..  maybe active.

Word choice "App"/"Schema"/"Client" should be carefully considered.  Also, the polymorphism may be taken into account, i.e. by introducing a convention like below, forward matching can extract super-class of the "Type" defined.

Client.Cell.Personal  - home-app type client for personal use
Client.Cell.Business  - home-app type client for business use
Client.App.Personal  - application client for personal use
Client.App.Business - application  client for biz use
We should also probably consider the "sub-schema". (The new notion we discussed the other day to handle multiple views in same app for multiple user roles, e.g.  teacher, student etc.)
Isn't that "Personal"/"Business" thing handled with sub-schema, rather than Cell's "Type"?
I do not have my answer for this yet.

To avoid confusion, I prefer CellType because when new comers might think that is application type when the cell is for an application.

Can't agree with you on the following names. Client app makes sense but client cell does not make any connection with HomeApp as an app for client to manage a cell. Let's discuss it during Sprint meeting

Client.Cell.Personal
Client.Cell.Business

The following commits solve this issue.

Commit 7267f99d9d5247462351f7bd028d1a71d7873290
Commit 6354bee89b0e11fed52c2d05c0dfe743fddabff3
Commit f039aa954294e7537409039cc6d4842123e4f4ed


Enhancement: Push notifications for defined Pokemon.

As a functional user of the application, would like the ability to identify specific Pokemon I'm am looking for, so that upon spawning in searched areas the user receives a notification of a new spawning of a given Pokemon.

read the FAQ, it's already on the to:do list

Duplicate.
Also: THE CHECKLIST ISNT THERE FOR SHITS AND GIGGLES!


Add --with-shell for shelling out with different command and flags

Close #3732
This hasn't been tested on Windows.

Thanks for dedicating time to implementing it.
Was it a deliberate decision that you made while working on it to not also apply it to the become action?
https://github.com/junegunn/fzf/blob/056cb5e52c7753d303f45dc8cf15777c7d0285ff/src/terminal.go#L3396-L3398
: | fzf --with-shell 'ruby -e' --bind 'enter:become:puts "Hello world"'

The example in the man page works well, but it may cause some issues for people with a defined FZF_DEFAULT_COMMAND. Consider this alternative:
tail /usr/share/dict/words | fzf --with-shell 'ruby -e' --preview 'puts {}.upcase.reverse'

Was it a deliberate decision that you made while working on it to not also apply it to the become action?
fzf

No, it was an oversight.

The example in the man page works well, but it may cause some issues for people with a defined FZF_DEFAULT_COMMAND.

Good point, thanks!

@rashil2000 Hi, can you take a look at this patch when you have some time? I could use some help on the Windows part, and you're the one who last changed the relevant code in #2647.

@rashil2000 Hi, can you take a look at this patch when you have some time? I could use some help on the Windows part, and you're the one who last changed the relevant code in #2647.

Sure, I'm currently travelling, will have a look in a few days

So I did some preliminary testing of this on a Windows VM against cmd and powershell, and at least it doesn't seem to break the existing workflow.

cmd.exe execution is broken, restoring CmdLine parameter.


Support for index hints

It can happen that the same set of database index can make one query optimal while another query less optimal.
Datasources (SQL/document) has index feature hints to modify this behavior:
MySQL: https://dev.mysql.com/doc/refman/8.0/en/index-hints.html
Mongo: https://docs.mongodb.com/manual/reference/operator/meta/hint/
Postgres (doesn't have it but considering): https://wiki.postgresql.org/wiki/OptimizerHintsDiscussion
This issue tracks this idea around Prisma 2.

Is this resolved?
How can I use index hint on MySQL?

Back in the day you could not close as "not planned", which we would use today.
Prisma does not support this today. If you need it, please open a new feature request issue for it. Thanks!


Fix: Incorrect mri_segstats argument

Description
This PR fixes a bug in an mri_segstats call in recon-surf.sh (this line), in which an incorrect argument was specified (segfile instead of seg).
This was pointed out by a user who tried running the pipeline with the vol_segstats flag, which leads to the error:
ERROR: Option --segfile unknown
setting seed for random number genererator to 1234
Command exited with non-zero status 255

The changes introduced here have been transferred to https://github.com/Deep-MI/FastSurfer/pull/246


test: avoid compiler optimization of benchmarks

It's generally possible for the compiler to optimize benchmarks, which is not what we want.
This PR puts each benchmark operation in a black_box wrapper to (attempt to) avoid this.

After further investigation, it appears that the wrapper is already applied.


Added OPUS audio format support, for both iOS and Android

Added OPUS audio format support, for both iOS and Android

Test Plan

What's required for testing (prerequisites)?
What are the steps to reproduce (after prerequisites)?
Compatibility

OS
Implemented

iOS
✅

Android
✅

Checklist

[ ] I have tested this on a device and a simulator
[ x] I added the documentation in README.md
[ ] I mentioned this change in CHANGELOG.md
[ ] I updated the typed files (TS and Flow)
[ ] I added a sample use of the API in the example project (example/App.js)

does the player also support opus?

+1


Add support for setting a FAT32 label

This adds a SetLabel() to the FileSystem interface. On SquashFS and ISO 9660, this method returns an error, as the filesystems are read-only.
For FAT32, this new method re-uses code that was previously in Create() and Create() is updated to call this new method at filesystem initialization time. Doing this required to initialize the fs structure earlier, before writing anything to the destination. Let me know if this refactoring is acceptable!
On top of this, the PR seizes the occasion to move the label reading logic closer to Windows and dosfstools' fatlabel behavior. That is, they read the label from the root directory rather than the bootsector. And, according to fatlabel's man page, Windows does not even write the label to the bootsector, which would cause go-diskfs to fail detecting it.
For the tests, I manually modified the fixture with "fatlabel" to include a label by default and updated the Readme. Was this the proper way of doing ?

"I torture packets / containers."
😆

Adding SetLabel() makes sense, and the returns from read-only filesystems are correct.
I don't mind terribly moving all of the "write to disk" from fat32.Create() to the end, as opposed to interspersed. Moving just one of them to its own function writeBootSector() but not the others - e.g. writeFsis, writeFat - is a bit unbalanced.
Having SetLabel() means you need to add the enforcement of the label format into there, so might as well take advantage and use the raw label in the dos71EBPB structure, although that would require changing the comment here.

That is, they read the label from the root directory rather than the bootsector. And, according to fatlabel's man page

I am somewhat torn on this. For SetLabel(), I like what you did, i.e. write it to both places. For read, are there compatibility issues? I cannot recall the driver behind the original implementation, but I am pretty sure the logic was taken from how Linux does it. Do we run the risk that some tool will write it only to the boot sector volume label, and this Label() read code will miss it? Is there some other construct that we can use to distinguish between on-filesystem label and on bootsector label?

For the tests, I manually modified the fixture with "fatlabel" to include a label by default and updated the Readme. Was this the proper way of doing ?

Unfortunately, yes. I have not come up with a better way.

Thanks for the review! I like the suggestion of introducing writeFsis and writeFat in the same way as writeBootSector; this is also the occasion to share more code with allocateSpace. I pushed a new proposition with these changes in a dedicated refactoring commit.
Regarding the compatibility concern, I might be a little bit too optimistic here, but I was considering that Windows is the reference implementation while Linux is the main alternative implementation. On Linux, the kernel does not read nor writes the label. There was a proposition some times ago to introduce an ioctl for it, but it did not get merged. Thus, the reference Linux implementation is fatlabel and I followed carefully the advertised behavior.
If it proves to be problematic, future options could be:

Add a fallback path on the bootsector, but we may end up with stranger consistency issues.
Add a FAT32 specific helper to query the label from the boot sector.

Would it be acceptable this way ?

So are you saying that:

Windows is the reference, which you implemented here in this PR.
Linux does not do anything with it in the kernel at all.
Linux does it in fatlabel (userspace), which follows your implementation.

If that is correct, then I think we can work with this. Going to take another look at the changes.

Going to kick off CI. If it all passes, are you good to go?

Oops, the lint. Sorry... Will push a fix this evening. Aside from this, good to.


Simulating neutral

From AJR, JI:
RoLE implements neutral if competition/environmental filtering are either very close to 0 or very close to 1. In these cases everyone regardless of trait is either experiencing very strong or very little death-pressure, and so it's effectively equal across the community.
There are potentially some edge cases where one species finds the narrow optimum and wins extravagantly. This leads to the "fudge factor" delta, which is a value added to everyone's competition kernel effectively blunting it. delta may be a way to tune what %neutral/what %competition/nichey a simulation is.

For "true" neutral, a brute force option may be to wrap the entire death probabilities situation in an if statement sidestepping all kernel calculations and assigning everyone equal death probability (not verbatim but see https://github.com/role-model/roleR/blob/main/src/iterModelCpp.cpp ca. lines 46, 93, and specifically 98):
if(comp_sigma == 0 && env_sigma == 0) {
        # here mixing R and C code, this line taken from iterModelCpp.cpp at 98
        # change this
        # NumericVector death_probs = env_filter_probs + comp_probs;
        # to
        death_probs = 1 / n_indiv # rep'd to the appropriate length
}

(not a complete fix because if the sigmas == 0 it would break some calculations earlier in the loop, but the gist)

Also in RoLE one individual dies per time step, after Hubbell. So there's no selection of death rates, just differential death probabilities. This is just a note for RMD who forgot this.

Status of shiny app for interactive simulations?
I think I can run sims interactively and extract things, but the shiny app is still a little buggy.
(debug?)

15m or less
App, plotting space, pars, run a model, run with higher migration
Walk through rules of neutral


Upgrade the default docker image node version to 12

This PR https://github.com/TerriaJS/TerriaMap/pull/561 bump the node version to 10.
However, node 10 is not in LTS anymore. We should test node 12 and update all our docker image to use node 12

I think we've done this already


Gitlab Bug Fix

We found a bug in the gitlab collector that would stop you from being able to get commits if the collector ran for a repo, but the collector was misconfigured.  What would happen is the collector would have a bad configuration that didn't allow you to retrieve commits from git.  If someone then created a Gitlab repo in a dashboard, the collector would run, retrieve no commits, and set the last updated to the current time.  The "first run" would have been run already.  Then, when the configuration was fixed, the collector would have already done the first run, so it would only try to retrieve commits from the "last update" time, back 10 minutes.  Therefor never retrieving the commits from whatever value was specified for first run.  This change prevents updating the "last update" time on a repo unless there was a successful request made to gitlab.  Any HttpClientErrorException or ResourceAccessException will prevent the "last update" time from changing, which means, a newly configured repo will get it's first run again, and other repos will get all commits from the last successful run.
Sorry for the long explanation, I think there is probably more explanation than actual code.  Let me know if you have questions.

LGTM


Change section size

The size of my section is way too big. I am forced to press a lot of text into a heading (which cannot be avoided) and the current settings ensure that a section easily takes up half a page.
Example:
= Title
:toc:
:numbered:
:toc-placement!:

:toc::[]

== this could be a pretty big section for example, which I just have to use, can actually not be avoided and is therefore not a solution, I have to get it as small as section level 4 or level 5 without ruining my table of contents

I convert my .adoc-files with asciidoctor-pdf in terminal:
asciidoctor-pdf myfile.adoc
Already tried even more equals like ===== section, sure, my section is now way smaller and perfect, but my toc is destroid.

Please study the theming guide. That's how you can customize the appearance of the text in the PDF. See https://github.com/asciidoctor/asciidoctor-pdf/blob/v1.5.x/docs/theming-guide.adoc#keys-heading

Here's how you can adjust the section title size using a custom theme named my-theme.yml:
extends: default
heading:
  h2-font-size: $base-font-size * 1.25

Then run using:
asciidoctor-pdf -a pdf-theme=./my-theme.yml doc.adoc


Nightly doc build warnings

Description of the modifications
Enable nightly doc build warnings.
Useful links and references
No response

resolveed by @hpohekar 's changes above


Datepicker enhancement: add option for expected input formats

Hello,
We use the datepicker like this:
<RadzenDatePicker
    TValue="DateTime?"
    Value="@_boundValue"
    DateFormat="dd MMM yyyy"
    Kind="DateTimeKind.Local"
    Change=HandleDatePickerChangeAsync
    DateRender="HandleDateRender"/>

We display the date in the input field with dd MMM yyyy as it is more unambigous for Europeans and Americans.
However we have noticed some users, who choose to forego the picker and type the date will use the more familar 03/04/2023 format. We are based in the UK and people expect 03/04/2023 to equal 03 April 2023, however Radzen parses that as 04 March 2023
I can see this happens here, the dd/MM/yyyy format doesnt match dd MMM yyyy so it falls back to the default method:
https://github.com/radzenhq/radzen-blazor/blob/b5f414623e695d72de6fd79f21537d84aa5c7e2c/Radzen.Blazor/RadzenDatePicker.razor.cs#L515-L521
So the approach could be for the line 520 parse to use local standards (I thought Kind="DateTimeKind.Local" might do that)
But perhaps another solution could be an InputFormat param where you could list formats to try and parse with before falling back to the default on line 520
so something like: InputFormat="dd MMM yyyy, dd/MM/yyyy"

We would probably add a new Parse method that users can implement as they need. Pull requests welcome!

Does this issue still happen?

@jonheslop at the company I currently work for we ran into a similar problem and we were thinking in the same direction as your request.
After reading @akorchev comment about a new parse-method, I implemented the change and made my first PR #1090 for this project. Hope this gets approved so we can both benefit.
ps. An example of the function we want to use to parse the date-input is:
        public static DateTime? ParseDate(string input)
        {
            string[] formats = { "dd-MM-yyyy", "dd/MM/yyyy", "dd-MM-yy", "dd/MM/yy", "ddMMyyyy", "ddMMyy", "dd-MM", "dd/MM", "ddMM" };

            foreach(var format in formats)
            {
                if (DateTime.TryParseExact(input, format, null, System.Globalization.DateTimeStyles.None, out var result))
                {
                    return result;
                }
            }

            return null;
        }


Are SQL and XSS regular expressions in 3.X compatible with 2.X?

Motivation

Proposed solution

Alternatives

Additional context

Hi @zb2018. Sorry but i have to close this. I suggest you to ask any questions in our Slack channel, see https://github.com/coreruleset/coreruleset/blob/v4.0/dev/README.md .


I want to be able to set an arbitrary resolution.

I want to be able to set an arbitrary resolution.
The required resolution setting is not in the menu.

I should open a PR for the library's repository that my application uses for conversion. In the meantime, could you tell me more about your use case?

@kingtosh https://github.com/akumathedyn123/python-epub-extractor-epub2txt


wrap() invoked when engine is already closed

Expected behavior
wrap() not invoked when engine is closed.
Actual behavior
wrap() is invoked when engine is closed..
javax.net.ssl.SSLException: SSLEngine closed already
	at io.netty.handler.ssl.SslHandler.wrap(...)(Unknown Source) ~[netty-handler-4.1.8.Final.jar:?]

Steps to reproduce
ListenableFuture<Response> listenableFuture = asyncHttpClient.preparePost(API_URL)
        .setHeader("Connection", "Keep-Alive")
        .addHeader("Content-Type", "application/json")
        .addHeader("Authorization", apiKey)
        .setBody(JsonUtils.getObjectMapper().writeValueAsBytes(data))
        .execute();
listenableFuture.toCompletableFuture().exceptionally(throwable -> {
    // SSLException logged.
    return null;
});

Minimal yet complete reproducer code (or URL to code)
None yet.
Netty version
4.1.8.Final
JVM version (e.g. java -version)
java version "1.8.0_102"
Java(TM) SE Runtime Environment (build 1.8.0_102-b14)
Java HotSpot(TM) 64-Bit Server VM (build 25.102-b14, mixed mode)
OS version (e.g. uname -a)
Linux xxxx 4.4.19-29.55.amzn1.x86_64 #1 SMP Mon Aug 29 23:29:40 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux

thanks for reporting @johnou ... keep us posted if you have a repro and we will look in the mean time.

@Scottmitch sgtm, soon as 4.1.9.Final is out I'll deploy a canary build.

I took a closer look and this exception originates from [1]. Can you explain why you think this is unexpected behavior?
[1] https://github.com/netty/netty/blob/4.1/handler/src/main/java/io/netty/handler/ssl/SslHandler.java#L664

@Scottmitch I was unsure which is why I didn't create the issue initially, so you are saying in my scenario (using async-http-client) the client establishes a connection with the server, ssl handshake completes and before the client has a chance to send the http request the connection is interrupted / closed? If so then I am happy to close this issue.

This exception is generated if after a wrap the SSLEngine signifies the engine has closed. At this point we will fail all pending writes which have not yet been wrapped. This may happen during the handshake or also at other times, but I don't see any indication in this case of it being a problem. Yes please close if this makes sense and you don't have any additional information which would indicate an issue in Netty.


Update Clickbench results with DataFusion 28.0.0

Is your feature request related to a problem or challenge?
With the release of DataFusion 28, it would be great to update the DataFusion performance reported on https://benchmark.clickhouse.com/
Notably, #6904 and related PRs for faster grouping performance show 2-3x performance improvements
Describe the solution you'd like
Update the results. I am not 100% sure how to do so, but I think the discussions on https://github.com/apache/arrow-datafusion/issues/5276 contain the answer
The datafusion scripts are in https://github.com/ClickHouse/ClickBench/tree/main/datafusion
maybe @jychen7 knows / can provide some hints
Describe alternatives you've considered
No response
Additional context
No response

the readme of https://github.com/ClickHouse/ClickBench/blob/main/datafusion/README.md was updated at Apr this year and is likely still updated.

I could set it up in weekend for v28

the result is nice! Especially previous timeout query 32 now finish in 8s
https://github.com/ClickHouse/ClickBench/pull/127/files

Also shall we create an issue to add DataFusion (Parquet, partitioned) to Clickbench? Current one is single parquet

Also shall we create an issue to add DataFusion (Parquet, partitioned) to Clickbench? Current one is single parquet

Yes please do @jychen7 -- that would be amazing
Note there is at least one query that will fail with the partitioned dataset in datafusion 28.0.0 due to https://github.com/apache/arrow-datafusion/issues/7039. @jonahgao  fixed the problem on main but I don't think the fix is in the 28.0.0 release

We just released datafusion 33, so I think this ticket is somewhat stale. If someone wants to update ClickBench again with the latest release, that would be great -- perhaps we can open a new ticket


initial folders are created form dbt cloud cli

initial request to merge the branch

initial merge to main master


Can you add our app "Newsplus" to the list of apps that use your code ?

Newsplus is an Indian Languages Focussed News Aggregator platform. We have used your code base to integrate youtube videos into our app. We pull trending videos, news from Indian Language News Channels etc from Youtube using their API services & then based on the user location, language etc we show the relevant videos in the feed. We used your code base to play the Videos inline/separate window. Please find the list of apps where we have used your code. Thank you for the stable & open source code.
English : https://play.google.com/store/apps/details?id=com.veooz
Telugu : https://play.google.com/store/apps/details?id=com.veooz.te
Tamil : https://play.google.com/store/apps/details?id=com.veooz.ta
Marathi : https://play.google.com/store/apps/details?id=com.veooz.mr
Malayalam : https://play.google.com/store/apps/details?id=com.veooz.ml
Hindi : https://play.google.com/store/apps/details?id=com.veooz.hi
Bengali : https://play.google.com/store/apps/details?id=com.veooz.bn
Gujarati : https://play.google.com/store/apps/details?id=com.veooz.gu
Kannada : https://play.google.com/store/apps/details?id=com.veooz.kn
Thank you.

Hey, sure. Can you send me a pull request?


Update Composer dependencies (2022-04-16-00-04)

Visual regression test passed!
View the visual regression test report


Auth::user always returning null

Laravel Version: 6.2.0
PHP Version: 7.2.19
Database Driver:Mysql

Description:
I was working on a blog projects API, and then found this kind of weird behavior that looks like a bug. While requesting user id in the function that returns user articles by id, it work all right, but on the other controller functions it always give null id. Here is my controller code. After trying different methods found around the web nothing seems to work!
`<?php
namespace App\Http\Controllers;
use Illuminate\Http\Request;
use App\Article;
use Illuminate\Support\Facades\Auth;
class articles_controller extends Controller
{
public function index()
{
    return Article::all();
}

public function show()
{
    return Article::where('user_id', auth()->user()->id)->get();
}

public function store(Request $request)
{
    $user_id =Auth::user()->id;
    $article = new Article([
    'user_id' => $user_id,
    'title' => $request->title,
    'article' => $request->article,
  ]);

  $article->save();

  ddd($article);
  return $article;
}

public function delete(Request $request)
{
    $user_id = $request->user;
    $article = Article::where('user_id',$user_id)->first();
    $article->delete();

    return 204;
}

}`
`<?php
namespace App;
use Illuminate\Database\Eloquent\Model;
use Illuminate\Foundation\Auth\User as Authenticatable;
class Article extends Authenticatable
{
protected $fillable = [ 'title', 'article'];
protected $hidden = [ 'id','created_at', 'updated_at'];

public function user()
{
    return $this->belongsTo('App\User');
}

}`
`<?php
use Illuminate\Http\Request;
use App\Article;
use App\Controllers\UserController;
/*
|--------------------------------------------------------------------------

API Routes

Here is where you can register API routes for your application. These

routes are loaded by the RouteServiceProvider within a group which

is assigned the "api" middleware group. Enjoy building your API!

*/

Route::post('login', 'UserController@login');
Route::post('register', 'UserController@register');
Route::group(['middleware' => 'auth:api'], function(){
Route::get('/article', 'articles_controller@index');
Route::get('/article/specific','articles_controller@show');
Route::post('article', 'articles_controller@store');
Route::patch('article/{id}', 'articles_controller@update');
Route::delete('article/delete', 'articles_controller@delete');

});`
No matter what I try, always the show function works as it should while other functions return the id as null.

It's normal, you are using the auth:api middleware which does not retain user in session

So what should I use instead of auth:api?

So what shall be used in this case and why it works only for the show function?

The github issues are for reporting bugs, there are other channels to request help with your project.
Laracasts Forums
Laravel.io Forums
StackOverflow
Discord
Larachat
IRC
That aside, you could try to check with dd what is the resolved user id because if the show method work then the store should be too.
In the delete mehod you should call the user method instead of reading the user property.
$user_id = $request->user()->id;

Furthermore I think you really should read and follow a style guide like the PSR-12 or PSR-2.
Next time please use the code blocks to post your code (put it between ```php and ```)

Well tried what you said and it changes nothing. If it's not a bug then why it gets the id only in the first function and returns null on the other ones? Furthermore no solution seems to work in any forum, maybe cause of the fact that I'm currently using the latest Laravel version?

It seems like it gets the id, but why does it save it as null in the database then?
Furthermore here is the preview
3 3 3 true "Illuminate\Auth\RequestGuard"

Please add the user_id field to your fillable properties in the Article model and try again.

Thank you. Had this issue for 2 days. Thanks again!

Just in case you’re not aware, there are a lot of options available to get help with Laravel.
Laracasts, Laravel.io, Laravel discord  channel, and larachat slack. You could probably get help much faster there for issues like this.

Hi,
I have the same problem with auth()->user(). Here are the results which I have:
"?"
"?"
false
"Illuminate\Auth\SessionGuard"

Hi,
I have the same problem with auth()->user(). Here are the results which I have:
"?"
"?"
false
"Illuminate\Auth\SessionGuard"

Hi @riatabduramani have you found a solution. I'm getting exact same outcomes.

same
"?" "?" "?" false "Illuminate\Auth\SessionGuard"

i also got same
"?" "?" "?" false "Illuminate\Auth\SessionGuard"

As a person who had the same problem, I can share the solution that worked for me. I switched from Passport to Sanctum.

Hi i have same problem in auth()->user(), the result is
?
?
?
true
"Illuminate\Auth\SessionGuard"

"?"
"?"
"?"
false
"Illuminate\Auth\SessionGuard"
i do
dd(
auth()->id() ?? '?',
Auth::id() ?? '?',
$request->user()->id ?? '?',
auth()->check(),
get_class(auth()->guard())
);
    i think now its not working?

i have the same problem


⚠ Bofrost.lu has degraded performance

In 742e429, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1088 ms

Resolved: Bofrost.lu performance has improved in b794ff1 after 6 minutes.


require("functify") should export a single function

In an effort to make functify easier to use I'm going to have it export only the functify function.  Static methods will be available off of functify itself.  Using it will look something like this:
let f = require("functify");

for (let i of f.range(0,10).map(x => x * x)) {
  console.log(i);
}

@rybesh fyi

fixed by https://github.com/kevinb7/functify/commit/f2753093a67191a789da6972b7ee44f91f63043c


vscode should have its own orgnization on github.

As more extensions  added to vscode, it is reasonable that all the vscode related stuff goes to one place that allow people to easily work with it.

Thanks for your feedback, we have considered a separate organization when we opened the code at github and decided against a separate organization. We can revisit this at a later point in time. For now the convention is to prefix vscode related repositories with vscode-.

@chrisdias fyi


Update Usernames

Apologies for the inconvenience, but I changed my handles everywhere to be a bit more professional. I'd really appreciate if the links could be updated here 🙏 many thanks

No problem :)


Refactor: T_STRING3

3 refers to "triple quoted", name should be expanded so this is obvious

This will be taken care of in a future rewrite.


Adding Auth on Subscriptions

Issue #, if available:
re #1766 #1043
Description of changes:
adding protection on subscriptions
BREAKING CHANGE: If an owner is included in the auth directive it will either be a requirement if it's the only rule or an optional input if used with other rules
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@SwaySway per chat we need to respond with null and not { "ok": true } with an authorized request on subscriptions otherwise the GraphQL schema will give a type error and fail the subscription request from a client

Also note that for existing projects the check:
? The default behavoir for @auth has changed in the latest version of Amplify
Read here for details: https://aws-amplify.github.io/docs/cli-toolchain/graphql#authorizing-subscriptions
 Do you wish to continue? Yes
authsubstestt $

This is not working correctly, it always will do a process.exit() which blocks an amplify push no matter what you select. We need to look at this logic and see what the bug is. @SwaySway @kaustavghosh06

@SwaySway per chat we need to respond with null and not { "ok": true } with an authorized request on subscriptions otherwise the GraphQL schema will give a type error and fail the subscription request from a client

I've added a change on the subscription resolver to return null

This is not working correctly, it always will do a process.exit() which blocks an amplify push no matter what you select. We need to look at this logic and see what the bug is. @SwaySway @kaustavghosh06

Corrected in the latest commit

Added an e2e test in PerFieldAuthTests.e2e.test.ts to confirm new @auth behavior


Project Idea Selection

Hackathon Submission: <PROJECT_NAME>
Name of Team Lead
Enter your full name

GitHub handles of Team Members
Enter the GitHub handles of all your team members (including yourself) as separate bullet points

Are all of your team members registered on our Hackathon Signup page?
This is a mandatory step for all participants to be considered eligible for judging

[ ] Yes
[ ] No

Rules and Code of Conduct
By submitting this PR, you agree to follow our Rules and Code of Conduct.

[x] Yes

Anything Else?
Any other feedback, queries or information you would like to share with us?

@Vedant817 the codebase of the project must be added to a separate repo of its own and not the submissions repo. Please do so and fill your submission with the appropriate information. You can resubmit a PR after that.


Add option to wake using proximity sensor

Pretty much all phones have a front facing proximity sensor, for sensing when someone is holding the phone against their ear when calling so the phone can disable the screen. My request is to add an option to wake the screen when a change in proximity is measured. This would allow you to wake the screen by moving your hand in front of it.
If I recall correctly, while the sensors reports data as a distance (e.g. 5.0cm), usually the sensors can only read two or a few more values. For example, it might say "0.0 cm" or "5.0 cm" but no other values.

This seems like a duplicate of #105

Detecting movement of the device is not the same as detecting something coming close to the proximity sensor

I think it actually is, the way that I understand it, the feature you are describing works based on the devices accelerometer or gyroscope detecting certain movements.   So the device knows that it is in the vertical position (next to your ear).   Waking the screen on motion is already something we have built in, as well as waking the device by detecting faces.   Some phones do have a proximity device, but not many.   I am putting these tickets together because they are all device sensor related.

Almost all phones have proximity sensors.

In some phones it is nearly invisible unless you shine a bright light at it, for example on my oneplus 2 the proximity sensor to the left of the front facing camera is almost invisible.

You are missing the point. Using a proximity sensor is very useful in wall mounted situations. To solve the problem, I used a third party app that wakes the screen so I can move my hand to close to the screen to turn it on. Waving your hand at the proximity sensor is faster than trying to click the on button

If someone is interested in implementing this feature, they are welcome to do a PR request.  I have labeled this as help wanted for those who want to contribute.

I am with you, sounds like a good feature to have.  I am leaving this request open hoping someone decides to help on this feature.

I could take a look, it's an excuse to start learning android app development so that's good I suppose

I have some sensor code in the application already, it gets a list of supported sensors and reports them over MQTT.  So that is the start, detecting if the device has the proximity sensor, then the next step is to detect a change in that sensor to wake the device.


C# Class Library configuration through external fluent API config project

http://forums.bridge.net/forum/community/help/506-code-configuration-specification-instead-additional-to-the-attributes
Assigning to @vladsch, but this is something that several of us will have to discuss and be involved in.

A fluent API would be nice for configuration but I think it is quite a technical challenge to execute the configuration code during compile-time.
I testwise implemented a draft for the Fluent API based on the forum post on interface level. As a contract I introduced an ICompilerExtension which receives an ICompilerContext. The ICompilerContext then provides the Fluent API. The compiler will implement this interfaces in the way that it will add the attributes dynamically to the type information. Also no big deal, just a bit of effort to implement all methods of the Fluent API.
Now I face the challenge of somehow load the assembly and execute the initialization code that is implemented in the compiled project. The output assembly references Bridge.dll instead of a working mscorlib so we need to replace it somehow. But if we replace bridge.dll with the default mscorlib other code within the project will not run properly since it depends on types and code of Bridge.dll. Has somebody experience with this?
So far I have no idea how to execute the code that is located in the output assembly.
Another solution for the actual problem of having code independent annotations could be the External Annotations approach which JetBrains uses for Resharper. The maintainance is of course higher than the Fluent API.

Good news: The xml based approach just like Resharper works fine. I started working on this topic on this branch: http://github.com/Danielku15/Bridge/tree/ExternalAttributes
It is in an early development state but already working for simple annotations.
I will update this issue and file a pull request once it reaches a better state with code documentation, unit tests etc.


Macaron logs are output to console instead of to file as configured

Gitea version (or commit ref): 1.5.0
Git version: 2.18.0
Operating system: macOS 10.11
Database (use [x]):

[ ] PostgreSQL
[ ] MySQL
[ ] MSSQL
[x] SQLite

Can you reproduce the bug at https://try.gitea.io:

[ ] Yes (provide example URL)
[ ] No
[ ] Not relevant
[x] No access to the logs

Log and config gist: https://gist.github.com/lukasbestle/ee3aa793ce1223b5aa92a9aca1818b17

Description
I have configured Gitea to write its logs to file (see the Gist I linked to above). However the Macaron logs are still output to console even though I'd expect them to be output to the logs/http.log file.
Please let me know if you need any further information

Is this a upstream macaron problem?

I’m not comfortable enough with the Gitea codebase, but given that the logging options are Gitea options and there is no related issue in the Macaron repo, I’d say it’s probably an issue in Gitea itself.
Can you reproduce the issue on your machine?

I think this option depends on environment setting for macrond (development or production)


fix: multiple objectstores under same indexdb database

due to complications in dynamically adding objectstores under already
opened indexdb database, jsindexdb provider will have predefined list of
objectstores. onupgradeevent during very first creation of database
will create those object stores in advance.
attempt to create store not defined in object store will not return
any error, instead it will create new database for that object store.
closes #1309

Signed-off-by: sudesh.shetty<EMAIL_ADDRESS>

This code is used in https://github.com/trustbloc/edge-agent/blob/master/pkg/store/vc/store.go#L40
we need to make sure it's working before release aries-framework-go

existing feature is still supported

@fqutishat Existing functionality is not broken, only pre initializing all aries object stores. Any other stores will still use older version of open db logic.
https://github.com/hyperledger/aries-framework-go/blob/f1d4e4f7552b7e50eccc31791026746787309567/pkg/storage/jsindexeddb/jsindexeddb.go#L73


Upgrade dependencies, mainly lexical for better performance

Before
Lexer
test three         ... bench:  14,350,033 ns/iter (+/- 767,897) = 82 MB/s
Parser:
test three         ... bench:  27,030,841 ns/iter (+/- 765,058) = 43 MB/s
After
Lexer
test three         ... bench:  14,089,720 ns/iter (+/- 667,112) = 84 MB/s
Parser
test three         ... bench:  26,409,095 ns/iter (+/- 1,086,535) = 44 MB/s

@kdy1 rebased


Instructions unclear

Hello, kinda stuck and don't understand the inscructions at all, please help. ty.

Which part do you not understand, the installation or configuration or ...?

The installation, I am stuck at the binary path. I opened the bath file and
typed in the patch to mpv
On Tue, Apr 27, 2021 at 4:26 AM Tony Chan @.***> wrote:

Which part do you not understand, the installation or configuration or ...?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/tnychn/mpv-discord/issues/17#issuecomment-827419419,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AIDPSYMIKCJ4VOKLAFJ5LNTTKZYJ3ANCNFSM43R5DKFQ
.

maybe your path contains spaces, in which case you would need to put quotation marks around it

It does not contain any space, I just don't know what's the binary_path and how I can make it work

The binary_path should be the path to mpv-discord's binary (the one inside the zip you downloaded from releases), not mpv's binary.

Is this ok?

This is just the folder path. You need to point it to the binary file itself, which is C:\Users\name\Downloads\mpv rich\bin\windows\mpv-discord.exe.

Okay, ty I will try

This is just the folder path. You need to point it to the binary file itself, which is C:\Users\name\Downloads\mpv rich\bin\windows\mpv-discord.exe.

I feel like it doesnt work, do I have to do extra steps ?

Try using a path without whitespace. And where did you place the discord.lua, discord.conf files respectively?

I will try, and I placed them here

This have to be filled or not ?

Okay, it worked you can close this now, thank you for your help.


[FEAT] Pass more variable in useTable Antd

Is your feature request related to a problem? Please describe.
I want to use these methods and variable.
current
setCurrent
pageSize
setPageSize
pageCount

These variables are used to manipulate the pagination system
Describe alternatives you've considered
No response
Additional context
No response
Describe the thing to improve
These methods should be passed to response of useTable (AntD) the same way setFilters and setSorter has been passed

Thank you @rajaomariajaona 🚀


Common Hooks validateschema error

Steps to reproduce
https://docs.feathersjs.com/api/hooks-common.html#validateschema fresh install inserted in CREATE user-hooks.js validate schema as per the link above.
module.exports = {
before: {
all: [],
find: [ authenticate('jwt') ],
get: [ ...restrict ],
create: [ validateSchema(userSchema(), Ajv), hashPassword(), setCreatedAt(), setUpdatedAt() ],
update: [ ...restrict, hashPassword() ],
patch: [ ...restrict, hashPassword() ],
remove: [ ...restrict ]
},
function userSchema() {   return {     title: 'User Schema',     $schema: 'http://json-schema.org/draft-04/schema#',     type: 'object',     required: [ 'email', 'password', 'role' ],     additionalProperties: false,     properties: {       email: { type: 'string', maxLength: 100, minLength: 6 },       password: { type: 'string', maxLength: 30, minLength: 8 },       role: { type: 'string' }     }   }; }
ERROR
/Users/me/Develop/feathers/src/services/users/users.hooks.js:22     create: [ validateSchema(userSchema(), Ajv), hashPassword(), setCreatedAt(), setUpdatedAt() ], ReferenceError: Ajv is not defined
I added const Ajv = require('ajv');
New error:
`
/Users/Tektango/Develop/feathers/node_modules/ajv/lib/ajv.js:94
if (!v) throw new Error('no schema with key or ref "' + schemaKeyRef + '"');
Error: no schema with key or ref "http://json-schema.org/draft-04/schema#"
`
https://github.com/epoberezkin/ajv says

JSON Schema draft-06 is published.
Ajv version 5.0.0 that supports draft-06 is released. It may require either migrating your schemas or updating your code (to continue using draft-04 and v5 schemas).
Please note: To use Ajv with draft-04 schemas you need to explicitly add meta-schema to the validator instance:
ajv.addMetaSchema(require('ajv/lib/refs/json-schema-draft-04.json'));

ReferenceError: Ajv is not defined It seems you didn't require Ajv as shown in the doc example https://docs.feathersjs.com/api/hooks-common.html#validateschema .

Ok - I'll dig into it deeper.
I reported that I added const Ajv = require('ajv'); but looking at docs again and try to figure out what else I am missing...

I'm having the same issue. I solved the error message by updating the schema version in my JSON Schema but I still cannot get validation to happen.
change from v04
$schema: 'http://json-schema.org/draft-04/schema#'
to v06 in your JSON Schema file
$schema: 'http://json-schema.org/draft-06/schema#'
Per the upgrade to AJV 5.0.0
https://github.com/epoberezkin/ajv/releases/tag/5.0.0

but I still cannot get validation to happen. Does the hook not work, or does Ajv not agree with your schema?

Right, the hook does not work for two reasons. First is the schema 04 to 06 change needed and second is validation succeeds all the time. I managed to fix by rewriting my own and I intend to debug the common hook to see why it is not working.
//needs cleanup ;o)
const Ajv = require('ajv');
let schema = require('./schema.json');
let feathersErrors = require('feathers-errors');

let errors = feathersErrors.errors;

function validate(hook){
  let ajv = new Ajv({ allErrors: true });
  let validate = ajv.compile(schema);
  let valid = validate(hook.data);

  if (!valid) {
    throw new errors.BadRequest('Invalid Request', validate.errors);
  }
}

This hooks is being used in production so I look forward to what you find. Thanks!

This has been consolidated with https://github.com/feathers-plus/feathers-hooks-common/issues/372


Added protozero installation;

Just updated CMakeLists.txt to install protozero (at least for OSX);

I am not sure how to handle this. Protozero is an external library and might already be installed from somewhere else. Maybe this should be a separate target? Or a CMake option a la INSTALL_PROTOZERO_TOO?

@joto yes, you're right, implicit install could cause problems;


SwiftUI design

App needs a design refresh, both because it's been 6 years since the initial work was done and because SwiftUI makes it a hell of a lot easier to build new stuff.
Started on quite a bit of it here: https://github.com/5calls/ios/pull/329
I would like to not keep the whole redesign in a single PR but unless there are other changes hitting main it doesn't really matter.
Tracking some (not at all comprehensive) todos:

[x] Loading issues, contacts
[x] Send outcomes back to server
[x] Setting location, persisting location
[x] Dashboard / Main issues view
[x] #352
[x] Issue detail view
[x] Issue contact detail view (i.e. script and phone numbers for an issue + specific contact)
[ ] Done page design
[x] About view
[x] Reminders view
[x] My Impact view
[x] #349
[ ] Localization pass
[ ] Accessibility pass
[ ] Modern welcome screen @heathermh
[ ] indicate which issues have been called about on the issue list (local issue completion cache is fine)
[ ] add share functionality in IssueNavigationHeader
[ ] Launch screen should match new layout

Bugs

[x] Welcome screen doesn't show paging pips
[ ] issue order is not respected (see 5calls.org for proper ordering)
[ ] Placeholder contact circles are not aligned right
[ ] With no location, users should be able to see issue details but need to enter a location before proceeding
[ ] If we haven't loaded a contact for an area, clicking "see your script" crashes (we should probably show an error "can't find any contacts for this issue in your location, try a different location")
[ ] iPad: tapping twice on "Detect my location" complains about leaked continuations (my iPad takes a long time to get a location? needs a disabled state)
[ ] iPad: changing your location should reload the issue detail to reflect new contacts
[ ] Welcome screen: button is only tappable on text, not blue background @heathermh

Cleanup tasks for after this is done and ready for prod:

[ ] Move plausible tracking to the new views
[ ] Remove uikit views
[ ] Remove unneeded 3p stuff: firebase, down, Promises

Modern welcome screen suggestion. What do you think? This should easily support dark mode and dynamic type.

This looks great @heathermh, open a PR and I can add some specific feedback.

done


fix(react): fix missing record props in ArrayBase.Item

Before submitting a pull request, please make sure the following is done...

[x] Ensure the pull request title and commit message follow the Commit Specific in English.
[x] Fork the repo and create your branch from main.
[ ] If you've added code that should be tested, add tests!
[ ] If you've changed APIs, update the documentation.
[x] Ensure the test suite passes (npm test).
[x] Make sure your code lints (npm run lint) - we've done our best to make sure these rules match our internal linting guidelines.

formily升级到2.0.0-rc.19后，ArrayBase.Item需要添加record属性

base(当前的main)分支确实是会构建失败，看起来不先修复，PR的「Compressed Size」步骤都过不去～


Fix edition of new features with new data

Fixes https://github.com/CartoDB/cartodb/issues/10666.
The problem: We're passing a null cartodb_id attribute to queryRowModel, and this causing the following error (only when you edited any field in the feature form):
{"errors":["PG::Error: ERROR:  null value in column \"cartodb_id\" violates not-null constraint\nDETAIL:  Failing row contains (null, null, null, a, b).\n"]}

With these changes, queryRowModel doesn't get a cartodb_id when creating a new feature/row.
@matallo makes sense? Thanks! 💋

LGTM

Thanks @matallo!


else/knob needs a +1 / -1 actual rotary limitless encoder that whenever you turn right, sends out +1, whenever you turn left, sends out -1.

there was an original claim that there's a limitless rotary encoder in knob and all i gotta do is click on the help and it's there.
there is no mention of Rotary or Endless in the documentation, and after bunches of back'n'forth in comments, it turns out there is no such thing available.
https://www.facebook.com/groups/puredata/posts/10160354837214495/

so, is that really it? whenever you turn the knob, no matter how fast you turn it, like no matter what the delta is, you always get either "1" or "-1"? Or if you turn it really fast/wider you end up having a faster increment or decremet?
I had to stop and think where have I seen such a thing, and maybe the phone gain knob of my sound card is like that. Do you have any other examples? What exactly are you trying to implement in Pd with this?

Rotary encoders would tend to send +1 on every turn to the right and -1 on every turn to the left. So if u turn "Five steps" to the right you would be sending +1 Five times. Not +5.  Instead Five separate instances of +1. I hope that helps somewhat as info

I have had multiple devices midicontrollers with Rotary endless knobs and basically they send 63 and 64 out incessantly as many times as you turn it. This is for having incremental control over pitch parameters, like a radio tuning knob.

One device that i used to have is the Faderfox UC4 which has Rotary endless encoders and those r awesome

and what do you need this in a patch for? you expect it to behave like a rotary knob by allowing the user to click and drag it around for that, right? Like, it would be the same or similar to using knob with its 'circular' mode, huh?

and what do you need this in a patch for? you expect it to behave like a rotary knob by allowing the user to click and drag it around for that, right? Like, it would be the same or similar to using knob with its 'circular' mode, huh?

For Extremely slow pitch changes kind of like tuning a radio. I sold the uc4 and dont have a single Rotary encoder anymore in my setup so being able to have one or more within PD would be amazing. The problem with current circular is that it does not send +1 -1 it instead sends decimals all over the place, which i cannot use for anything.

@esaruoho : I use the rotary knobs of the Akai Mini Mk3 quite a lot and when I made patches for them, I realized that they not only send -1 and +1 (which are then encoded as 127 and 1), but also bigger values if you rotate faster. Decoding is easily done with a moses 64 where the left output is the inc values and the right output with a - 128 is the dec values.
With a little trick and an underlying vsl, you can also create the endless rotary behavior with the current else/knob. I'm pasting a little patch with this kind of abstraction below (didn't try with the Akai since I don't have it here right now).
@porres : Maybe this kind of vertical or horizontal interaction might be relevant. The relative values might also be an option. But on the other hand, this works quite simply - so not sure if additional features are necessary?
#N canvas 426 206 665 597 12; #X floatatom 62 259 6 0 0 0 - - - 0; #X obj 62 118 moses 64; #X obj 115 141 - 128; #X obj 62 64 ctlin 0; #N canvas 788 138 450 300 knob 0; #X obj 100 102 vsl 31 26 -16 16 0 0 empty empty empty 0 -9 0 12 #fcfcfc #ffffff #000000 0 1; #X obj 90 136 t f b; #X obj 120 179 f; #X obj 90 179 +; #X msg 184 81 set 0; #X obj 90 203 t f f; #X obj 100 100 knob 31 0 127 0 0 \$0_out \$0_in #ffffff #ffffff black 0 1 0 0 0 360 0 0 0; #X obj 184 222 mod 128; #X obj 90 248 outlet; #X obj 90 56 inlet; #X connect 0 0 1 0; #X connect 1 0 3 0; #X connect 1 1 4 0; #X connect 2 0 3 1; #X connect 3 0 2 0; #X connect 3 0 5 0; #X connect 4 0 0 0; #X connect 5 0 8 0; #X connect 5 1 7 0; #X connect 7 0 6 0; #X connect 9 0 1 0; #X coords 0 -1 1 1 31 31 2 100 100; #X restore 62 193 pd knob; #X connect 1 0 4 0; #X connect 1 1 2 0; #X connect 2 0 4 0; #X connect 3 0 1 0; #X connect 4 0 0 0;

... and this simpler version outputs relative and absolute values with the circular else/knob and its regular interaction:
#N canvas 520 149 450 466 12;
#X obj 70 60 knob 31 0 127 0 0 empty empty #ffffff #ffffff black 0 1 0 0 0 360 0 0 0;
#X obj 70 158 t f f;
#X obj 70 194 -;
#X obj 70 236 - 64;
#X obj 70 284 - 64;
#X obj 70 260 mod 128;
#X obj 70 134 i;
#X obj 199 327 +;
#X obj 229 327 f;
#X obj 70 308 t f f;
#X floatatom 199 377 5 0 0 0 - - - 0;
#X floatatom 70 377 5 0 0 0 - - - 0;
#X text 111 376 relative;
#X text 239 376 absolute;
#X connect 0 0 6 0;
#X connect 1 0 2 1;
#X connect 1 1 2 0;
#X connect 2 0 3 0;
#X connect 3 0 5 0;
#X connect 4 0 9 0;
#X connect 5 0 4 0;
#X connect 6 0 1 0;
#X connect 7 0 8 0;
#X connect 7 0 10 0;
#X connect 8 0 7 1;
#X connect 9 0 11 0;
#X connect 9 1 7 0;

(sorry for the pd syntax spam - don't know how to properly share patches here)

not sure if additional features are necessary?

I was wondering the same

(sorry for the pd syntax spam - don't know how to properly share patches here)

please upload it as a zipped file!

Ah, .zip makes sense - sorry, I didn't see that. Only tried .pd and .txt.
Both patches compressed here now:

knob_experiments.zip](https://github.com/porres/pd-else/files/13260399/knob_experiments.zip)

yup, there you go, kind of what I had in mind


Add functionality to create rules

While we can export and restore a quality profile (which is a set of rules) to migrate it to another server from the UI, there's no way to do that with rules customization. That includes new rules and modified rules. See this ticket for more information.
Since this handler is already capable of reading rules, we could add the functionality to add rules as well, so we could use it to transfer customized rules from one server to another.

Closed by this commit


[actions] Multiple identical reusable workflow files are cached

Description
I used files-changed.yml to output git's file changes, and subsequently discovered that runner was caching duplicate repositories.
files-changed.yml
name: files-changed

on:
  workflow_call:
    outputs:
      exam:
        value: ${{ jobs.detect.outputs.exam }}
      user:
        value: ${{ jobs.detect.outputs.user }}
      gateway:
        value: ${{ jobs.detect.outputs.gateway }}

jobs:
  detect:
    runs-on: ubuntu-latest
    outputs:
      gateway: ${{ steps.changes.outputs.gateway }}
      exam: ${{ steps.changes.outputs.exam }}
      user: ${{ steps.changes.outputs.user }}
    steps:
      - uses: https://github.com/actions/checkout@v3
      - uses: https://github.com/dorny/paths-filter@v2
        id: changes
        with:
          base: ${{ gitea.ref }}
          filters: |

            exam:
              - exam/**
              - basic/**
              - pom.xml
            user:
              - user/**
              - basic/**
              - pom.xml
            gateway:
              - gateway/**
              - basic/**
              - pom.xml

cache files
c209e0011589:/# cd ~/.cache/act
c209e0011589:~/.cache/act# ls
***-.gitea-workflows-files-changed.yml@0c7ea79e8bf0e3ad5434d3c960f3757f2b1de783
***-.gitea-workflows-files-changed.yml@605f5b35384b5e14983f7fd06a6ad527c4965eb2
***-.gitea-workflows-files-changed.yml@7a5506b743d87f630c83d3ec456329213a5b8be9
***-.gitea-workflows-files-changed.yml@fa0181a7bb1fcd7167ea7d2cc7446c7fc98bc7f8
https---github.com-actions-checkout@v3
https---github.com-dorny-paths-filter@v2
<EMAIL_ADDRESS>
Gitea Version
1.20
Can you reproduce the bug on the Gitea demo site?
No
Log Gist
No response
Screenshots
No response
Git Version
No response
Operating System
No response
How are you running Gitea?
docker images:
gitea: gitea/gitea:1.20
gitea runner: gitea/act_runner:0.2.3
Database
SQLite

I will move this issue to gitea.com . But I can't register for an account beacuse I haven't received a confirmation email for gitea.com.


unused crates in a workspace not included in package, but still expected

Current Behavior
https://github.com/GothenburgBitFactory/taskwarrior/blob/19f2c0d7b4bb023a938cc35fce3e45872ff3f07f/src/tc/CMakeLists.txt#L11
corrosion_import_crate(
  MANIFEST_PATH "${CMAKE_SOURCE_DIR}/Cargo.toml"
  LOCKED
  CRATES "taskchampion-lib")

https://github.com/GothenburgBitFactory/taskwarrior/blob/19f2c0d7b4bb023a938cc35fce3e45872ff3f07f/Cargo.toml#L3
// Cargo.toml
members = [
    "taskchampion/taskchampion",
    "taskchampion/sync-server",
    "taskchampion/lib",
    "taskchampion/integration-tests",
    "taskchampion/xtask",
]

Of those, taskchampion-lib depends on taskchampion, and the other three are not used from C++. I wouldn't mind including them in the package. However, from https://github.com/GothenburgBitFactory/taskwarrior/issues/3294
$:/tmp> tar -xf task-3.0.0.tar.gz
$:/tmp> cmake -S task-3.0.0 -B build
-- Configuring C++17
-- System: Linux
-- Looking for libshared
-- Found libshared
-- Looking for SHA1 references
-- Looking for libuuid
-- Found libuuid
-- Configuring cmake.h
-- Rust Target: x86_64-unknown-linux-gnu
-- Using Corrosion as a subdirectory
error: failed to load manifest for workspace member `/tmp/task-3.0.0/taskchampion/integration-tests`

Caused by:
  failed to read `/tmp/task-3.0.0/taskchampion/integration-tests/Cargo.toml`

Caused by:
  No such file or directory (os error 2)

so it seems that the source for the crates not required are not included in the package.
Expected Behavior
Package builds without error!
Steps To Reproduce
Build the Taskwarrior 3.0.0 release from its package.
Environment
No response
CMake configure log with Debug log-level
No response
CMake Build step log
No response

error: failed to load manifest for workspace member /tmp/task-3.0.0/taskchampion/integration-tests

Corrosion internally uses cargo-metadata to get information on the workspace and expects cargo-metadata to work. This error looks like it comes straight out of cargo metadata - Could you verify if cargo metadata --manifest-path /path/to/your/Cargo.toml works on your package without corrosion?

I downloaded the tarball and indeed cargo metadata does not work - neither do any other cargo commands.
I also tried running cargo metadata just on the library crate, but that still causes an error.
I'd recommend replacing your workspace Cargo.toml during the release processs, to avoid this issue, since removing the missing workspace member indeed seems to fix the problem.
I'll be closing this issue, since corrosion requires cargo metadata to work.

Thanks!
I filed this on the assumption that something in Corrosion identified the files that would be packed, and did not include the other crates in the workspace. Since cargo metadata then requires those files, that seemed a bug.
However, I suppose CPack is really just gathering all of the source files referenced in the build, without specific support from Corrosion.


Super Mario Land DX Patch

Any chance a patch could be produced for Super Mario Land DX now that the 2.0 version is out? I gave the GB v1.0 patch a shot in case it worked but it just loads to a blank screen. Thanks

Yes, absolutely! Super Mario Land is the very first game I created a save state patch for, so DX must have a patch too :)
I've now created and uploaded the patch. Let me know if any issues.

Yes, absolutely! Super Mario Land is the very first game I created a save state patch for, so DX must have a patch too :)
I've now created and uploaded the patch. Let me know if any issues.

Seems broken, atleast for me. Saving would either send me back to the main menu, or would glitch out the graphics. Loading also either does nothing, or crashes.

@Espio419 I've just double checked applying the patch and seems to be working fine here.
Note you will need to apply the save state patch to a working Super Mario Land DX v2.0 ROM. The md5 for that ROM should be 119bdf89bdf38e489facd79cf251ccd0.
After patching the expected md5 is 85ccbe7f0806de2575825bb9af0edd93.

@mattcurrie The MD5s check out for both roms, but still spazzes out for me. Maybe it has something to do with my EZ-FLASH Junior, even though the other patches here work. It works fine an mGBA, though.

@Espio419 Ah strange. I've tested on EZ-Flash jr and Everdrive GB X5 and it works ok on both.
When you put the save state patched ROM on your micro SD, did you already have a ROM with the same name on there? I'm wondering if the EZ-Flash jr saw an existing 8 KB .sav on there and so it didn't enlarge it to 128 KB.

I did have a ROM using the same name. I have tried deleting the save, but it still wouldn't work. Even changing the name of the ROM causes the same issue.

@Espio419 Hmm, I can't really think of any other reasons you would have having trouble - it sounds like you're doing everything correctly. Its a bit of a hassle, but other things to try would be either another micro SD card, or re-format the one you have already and set up again.

Seem to be having the same issue myself on a EZFlash Jr. I've tested it on my normal MicroSD and a seperately freshly formatted one, both either reboot to title screen or crash to black screen requiring a hard reboot when attempting to save, nothing happens on load. I've checked and the .sav file is the expected 128KB. EZFJr is running FW4.

@AngelAbaddon thanks for reporting back.
Strange that it doesn't work with your GBC. I've just tried saving and loading on my GBCs (all different revision SOCs) without issue. I'm using FW5 on my EZFJr, but I'm not aware of any changes compared to FW4 that would affect the save state patch.
I wonder if it could be due to power. Maybe you could you try powering your GBC with fresh AAs or a DC adapter?

@AngelAbaddon That's the same with me. Saving and loading doesn't work on my modded Boxy Pixel GBC with the FunnyPlaying Retro Pixel 2.0 display, but works fine on my Boxy Pixel GBA with the FunnyPlaying V2 LCD. Connecting my GBC to a power source for charging doesn't make a difference.

@mattcurrie unfortunately no luck. I've not got a plug adapter, but fresh batteries made no difference.

Can you try with this alternate save state patch? It just adds a delay after switching ROM banks. It shouldn't really be required, but if ezfjr has some timing issue then it could help.
test1.bsdiff.zip

Saving seems to work, but loading the save still crashes the game.

@mattcurrie No luck on my end. Got it to save once, then loading everything went to hell, graphical glitches everywhere leading to a crash. After that if I try to save (after deleting the .sav file to start fresh) I have the same issue as the initial patch.

Thanks for testing @Espio419 and @AngelAbaddon.
I fear this might be a tricky one to fix unless I can reproduce it with my hardware. I tried downgrading my ezfjr to FW 4 just in case, but saving and loading still worked fine for me. There should be another ezfjr in my house somewhere, but the kids seem to have misplaced it. I'll keep hunting...
It would be great if you could try the other CGB games that I've made patches for - if any of the other CGB patches are broken for you on your CGBs too then maybe I can figure out some commonality between them. Apart from that I might be able to create a set of patches testing different parts of the process and see where it is getting stuck... I'd really like to figure out the issue if possible :)

@mattcurrie I have problem with all patched gbc roms (gb - no problem). Every patched gbc roms (all 12) after save button - freeze game forever (or reset to title screen).
My Game Boy Color flash cartridge version is:
System Information

CPLD Version: 1
BIOS Version: 1
OS Version: 4

Asm Date: 16.12.2016
Asm Time: 2:14:28

Which.gb v0.4
Seems to be a...
CPU CGB D

Hi @AngelAbaddon, @Espio419, @RoxMarty,
Sorry it has been a while since I've been able to look at this. If you're still having trouble with these patches, could you try running this test ROM linked below on your flash carts and various game boys? This will check that the full 128 KB of SRAM is available and working correctly. The GBC save patches require that the test reports "Passed!" for all banks (0-9 and A-F).
https://github.com/eievui5/sram128/releases/tag/v1.0.1

Hi, @mattcurrie
My log:
128KiB SRAM test ROM:
Bank 0-3 - Passed!
Bank 4-F - Failed!
What it means? GBC quick save/load is never work for me?

@RoxMarty, yes unfortunately it looks like your flash cart only has 32KB of SRAM, which is too small for the GBC save states.

@RoxMarty, yes unfortunately it looks like your flash cart only has 32KB of SRAM, which is too small for the GBC save states.

All banks passed for me.

@mattcurrie, thanks for the answer!
Now the problem is clear. It is a pity that there is no way to solve it

@mattcurrie All banks passed for me


Zynaddsubfx: no loaded instrument on upgrade.

Describe the bug
I upgraded Zynaddsubfx (latest unstable), and was surprised to discover the new amazing interface (whooa)... and that I had no more loaded instrument (empty bank).
I solved that problem by removing the user zynaddsubfx configuration and bank cache (I think the problem is the bank cache):
~$ rm .zynadd*

and indeed, once you reload zynaddsubfx, you can see that the instruments are back. Also, a new file ~/.zynaddsubfx-bank-cache.xml is created, and the bank path is hardcoded, like:
...
bank="/nix/store/2y9g74xs09x960m66g6pbnxxgmwpzvjv-zynaddsubfx-3.0.5/share/zynaddsubfx/banks/the_mysterious_bank_4/"
...

I guess that in other distributions this path does not change when zynaddsubfx is updated, but with nix the bank path changes on upgrade, so the user needs to manually clear the cache on each upgrade.
I'm not sure what's the best way to solve this problem. I was thinking that the best solution may be to add a small wrapper around zynaddsubfx which clears the cache if it detects in ~/zynaddsubfx-bank-cache.xml a path to another nix executable. The other possibility may be to use /run/current-system/sw/share/zynaddsubfx/banks/ instead of the /nix/ one, but it won't work outside of NixOs.
If these options are not working, at least it would be nice to document that bank cache should be cleared on upgrades.
Steps To Reproduce
Steps to reproduce the behavior:

Upgrade zynaddsubfx and potentially garbage collect the old version
Start zynaddsubfx: instruments may disapear

Notify maintainers
@goibhniu
@kira-bruneau

still relevant, just haven't gotten around to fixing it

I think this issue should not be closed as for now it is based on a non-accepted PR, so I'll re-open waiting for the changes to be merged upstream.


Buttons for selecting upper-right or lower-left extent when adding center track

Description

What was changed in this pull request?

Buttons for selecting the upper-right or lower-left extent were added to the center square of the add track position pop-up menu. The behavior of HiGlassComponent.adjustOtherTrackOptions had to be slightly modified (https://github.com/higlass/higlass/compare/develop...keller-mark:keller-mark/add-center-track-with-extent?expand=1#diff-77a44232595309f20e1f8787348f2734L3179) to prevent infinite loops.

Why is it necessary?

Not necessary, just an enhancement.
Fixes #759
Screenshots
No hover:

Hover over center:

Hover over upper right triangle:

Hover over lower left triangle:

Checklist

[ ] Set proper GitHub labels (e.g. v1.6+, ignore if you don't know)
[ ] Unit tests added or updated
[ ] Documentation added or updated
[ ] Example(s) added or updated
[ ] Update schema.json if there are changes to the viewconf JSON structure format
[x] Screenshot for visual changes (e.g. new tracks or UI changes)
[x] Updated CHANGELOG.md

Nice addition! Would you mind adding a section to the docs describing this?
A mention here: https://github.com/higlass/higlass/blob/develop/docs/tutorial.rst
And a more detailed description with a screenshot here: https://github.com/higlass/higlass/blob/develop/docs/views.rst

Thanks! I have added some info about this to both of those places.


"The TemplateBinding markup extension is an alternative to creating a ControlTemplate that uses the RelativeSource markup extension to set the BindingContext of the root element in the template to its templated parent."

It is so wordy and once again explains some low level stuff without introducing the concepts properly. Please add examples, avoid sentences as "The TemplateBinding markup extension is an alternative to creating a ControlTemplate that uses the RelativeSource markup extension to set the BindingContext of the root element in the template to its templated parent." <-- I had to read that at least three times before I was able to digest it is really just saying "This is another alternative".
Please cut down on the words everywhere, explain the concepts cleanly, and add more examples. This is a huge problem with all Xamarin.Forms documentation.
Thank you.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a4b35f51-7abf-c8cc-2dfb-2cb20a0fc200
Version Independent ID: f47aa11e-86c3-9387-e1f8-b6ce29fe5eb7
Content: Xamarin.Forms control templates - Xamarin
Content Source: docs/xamarin-forms/app-fundamentals/templates/control-template.md
Product: xamarin
Technology: xamarin-forms
GitHub Login: @davidbritch
Microsoft Alias: dabritch

Hi @Tommigun1980
Yes, TemplateBinding is just an alternative. But it's an alternative for that specific scenario. Not an alternative to RelativeSource bindings in general.
That doc is already example heavy - 68% of it is code.
What concepts aren't explained clearly in the doc, in your opinion?

Hi David.
It's just so hard to read. Almost all XF documents are like that, they make very simple concepts sound extremely complex. "The TemplateBinding markup extension is an alternative to creating a ControlTemplate that uses the RelativeSource markup extension to set the BindingContext of the root element in the template to its templated parent." is just word salad, and really just says "You can also do this:". The entire explanation refers to the previous section that is somehow condensed into the sentence.
Don't you think sentences like "The TemplateBinding markup extension is an alternative to creating a ControlTemplate that uses the RelativeSource markup extension to set the BindingContext of the root element in the template to its templated parent." are quite tough to comprehend?
Thanks.

Hi @Tommigun1980
I agree that it's tough to comprehend.

I've fixed this in a PR that will go live early next week (the CI server is currently under high load).


Binding module error. Unknown bindType:1

Addon Version
0.1.92
World of Warcraft Version
Retail
Describe the bug
LUA Error presents immediately when loading the world. Bags also appear empty when inventory is opened.

It appears that if you have an item that has changed types but not updated its' metadata, it is possible to have an item with a "Binds when picked up" type present within inventory.
1	OnAcquire	Bind on Pickup
The specific Item in question within my inventory is Schematic: Bundle of Fireworks (https://www.wowhead.com/item=199232/schematic-bundle-of-fireworks).

Temporarily resolved the issue by adding the following lines within the bindType if statements.
elseif (bindType == 1) then
  bindinginfo.binding = const.BINDING_SCOPE.BOP

Error Message:
Message: Interface/AddOns/BetterBags/data/binding.lua:61: Binding module error. Unknown bindType:1 bag:3 slot:27
Time: Wed Aug 14 01:58:27 2024
Count: 1
Stack: Interface/AddOns/BetterBags/data/binding.lua:61: Binding module error. Unknown bindType:1 bag:3 slot:27
[string "@Interface/AddOns/Blizzard_SharedXMLBase/ErrorUtil.lua"]:3: in function <...nterface/AddOns/Blizzard_SharedXMLBase/ErrorUtil.lua:1>
[string "=[C]"]: in function `assert'
[string "@Interface/AddOns/BetterBags/data/binding.lua"]:61: in function `GetItemBinding'
[string "@Interface/AddOns/BetterBags/data/items.lua"]:842: in function `AttachItemInfo'
[string "@Interface/AddOns/BetterBags/data/loader.lua"]:72: in function <Interface/AddOns/BetterBags/data/loader.lua:67>
[string "=[C]"]: in function `xpcall'
[string "@Interface/AddOns/Blizzard_ObjectAPI/Mainline/AsyncCallbackSystem.lua"]:76: in function `FireCallbacks'
[string "@Interface/AddOns/Blizzard_ObjectAPI/Mainline/AsyncCallbackSystem.lua"]:35: in function <.../Blizzard_ObjectAPI/Mainline/AsyncCallbackSystem.lua:31>
[string "=[C]"]: ?
[string "=[C]"]: in function `accessor'
[string "@Interface/AddOns/Blizzard_ObjectAPI/Mainline/AsyncCallbackSystem.lua"]:52: in function `AddCallback'
[string "@Interface/AddOns/Blizzard_ObjectAPI/Mainline/Item.lua"]:332: in function `ContinueOnItemLoad'
...
[string "@Interface/AddOns/Blizzard_UIParent/Mainline/UIParent.lua"]:422: in function `UIParentLoadAddOn'
[string "@Interface/AddOns/Blizzard_UIParent/Mainline/UIParent.lua"]:627: in function `MajorFactions_LoadUI'
[string "@Interface/AddOns/Blizzard_ExpansionLandingPage/Blizzard_DragonflightLandingPage.lua"]:103: in function `SetUpMajorFactionList'
[string "@Interface/AddOns/Blizzard_ExpansionLandingPage/Blizzard_DragonflightLandingPage.lua"]:96: in function `RefreshMajorFactionList'
[string "@Interface/AddOns/Blizzard_ExpansionLandingPage/Blizzard_DragonflightLandingPage.lua"]:91: in function `RefreshOverlay'
[string "@Interface/AddOns/Blizzard_ExpansionLandingPage/Blizzard_DragonflightLandingPage.lua"]:83: in function <...sionLandingPage/Blizzard_DragonflightLandingPage.lua:79>
[string "=[C]"]: in function `CreateFrame'
[string "@Interface/AddOns/Blizzard_ExpansionLandingPage/Blizzard_DragonflightLandingPage.lua"]:49: in function `CreateOverlay'
[string "@Interface/AddOns/Blizzard_ExpansionLandingPage/Blizzard_ExpansionLandingPage.lua"]:78: in function `RefreshExpansionOverlay'
[string "@Interface/AddOns/Blizzard_ExpansionLandingPage/Blizzard_ExpansionLandingPage.lua"]:37: in function <...pansionLandingPage/Blizzard_ExpansionLandingPage.lua:35>

Locals:

Steps to reproduce
Have item present in inventory with "Binds on pickup up" bindType.

Very interesting find! I'm looking at this.
I'll note that the Schematic itself is non-binding, but creates a binding item when crafted.

could it have been a different item?
That one is working for me just fine

If you have a chance, re-edit binding.lua, take out your elseif and change the last lines of the file to this:
  local itemID = C_Item.GetItemID(itemLocation)
  assert(bindinginfo.binding ~= const.BINDING_SCOPE.UNKNOWN, (format("Binding module error. Unknown bindType:%s itemID: %s bag:%s slot:%s", bindType, itemID, itemLocation:GetBagAndSlot())))
  return bindinginfo
end

This will help us track down the actual rogue item

Well this is interesting, I am very curious how this item has that bindType internally considering it has "Binds when equipped" in tooltip.

Message: Interface/AddOns/BetterBags/data/binding.lua:62: Binding module error. Unknown bindType:1 itemID: 205229 bag:3 slot:30
Time: Wed Aug 14 04:43:46 2024
Count: 1
Stack: Interface/AddOns/BetterBags/data/binding.lua:62: Binding module error. Unknown bindType:1 itemID: 205229 bag:3 slot:30
[string "@Interface/AddOns/Blizzard_SharedXMLBase/ErrorUtil.lua"]:3: in function <...nterface/AddOns/Blizzard_SharedXMLBase/ErrorUtil.lua:1>
[string "=[C]"]: in function `assert'
[string "@Interface/AddOns/BetterBags/data/binding.lua"]:62: in function `GetItemBinding'
[string "@Interface/AddOns/BetterBags/data/items.lua"]:842: in function `AttachItemInfo'
[string "@Interface/AddOns/BetterBags/data/loader.lua"]:72: in function <Interface/AddOns/BetterBags/data/loader.lua:67>
[string "=[C]"]: in function `xpcall'
[string "@Interface/AddOns/Blizzard_ObjectAPI/Mainline/AsyncCallbackSystem.lua"]:76: in function `FireCallbacks'
[string "@Interface/AddOns/Blizzard_ObjectAPI/Mainline/AsyncCallbackSystem.lua"]:35: in function <.../Blizzard_ObjectAPI/Mainline/AsyncCallbackSystem.lua:31>
[string "=[C]"]: ?
[string "=[C]"]: in function `accessor'
[string "@Interface/AddOns/Blizzard_ObjectAPI/Mainline/AsyncCallbackSystem.lua"]:52: in function `AddCallback'
[string "@Interface/AddOns/Blizzard_ObjectAPI/Mainline/Item.lua"]:332: in function `ContinueOnItemLoad'
...
[string "@Interface/AddOns/Blizzard_UIParent/Mainline/UIParent.lua"]:422: in function `UIParentLoadAddOn'
[string "@Interface/AddOns/Blizzard_UIParent/Mainline/UIParent.lua"]:627: in function `MajorFactions_LoadUI'
[string "@Interface/AddOns/Blizzard_ExpansionLandingPage/Blizzard_DragonflightLandingPage.lua"]:103: in function `SetUpMajorFactionList'
[string "@Interface/AddOns/Blizzard_ExpansionLandingPage/Blizzard_DragonflightLandingPage.lua"]:96: in function `RefreshMajorFactionList'
[string "@Interface/AddOns/Blizzard_ExpansionLandingPage/Blizzard_DragonflightLandingPage.lua"]:91: in function `RefreshOverlay'
[string "@Interface/AddOns/Blizzard_ExpansionLandingPage/Blizzard_DragonflightLandingPage.lua"]:83: in function <...sionLandingPage/Blizzard_DragonflightLandingPage.lua:79>
[string "=[C]"]: in function `CreateFrame'
[string "@Interface/AddOns/Blizzard_ExpansionLandingPage/Blizzard_DragonflightLandingPage.lua"]:49: in function `CreateOverlay'
[string "@Interface/AddOns/Blizzard_ExpansionLandingPage/Blizzard_ExpansionLandingPage.lua"]:78: in function `RefreshExpansionOverlay'
[string "@Interface/AddOns/Blizzard_ExpansionLandingPage/Blizzard_ExpansionLandingPage.lua"]:37: in function <...pansionLandingPage/Blizzard_ExpansionLandingPage.lua:35>

Locals:

Well this is interesting, I am very curious how this item has that bindType internally considering it has "Binds when equipped" in tooltip.

Congratulations, you found a 'broken' item.  :D
It appears that the item was BoE in Season 3, but changed to BoP in Season 4. I was able to find one on the Auction House. You can see both BoE and BoP tooltips
The immediate fix would be to equip it to bind it or put it in the mail without BetterBags loaded for now - or drop your elseif back in. I'll have a patch ready for Cidan in the morning.
 I was going through and fixing all of the API changes in my addons list when I found this error and it piqued my curiosity. I put my elseif back in place immediately so I could continue playing but will be sure to update once the new version is pushed to confirm resolved.

PR #581 will fix this

resolved as of BetterBags v0.1.96


Segementation fault

Hi,
I have just hit the same issue as #111 which seems to be caused by the images themselves maybe. I am using the same code and a buffer image taken from puppeteer (https://github.com/GoogleChrome/puppeteer/blob/master/docs/api.md#pagescreenshotoptions) without issues.
But my tests here https://github.com/JakeGinnivan/jest-image-snapshot/blob/master/tests/jest-image-snapshots.spec.ts cause a segmentation fault (specifically Command failed with signal "SIGSEGV").
Any ideas on where to look?

I am ok with this being closed so cleanup open issues. I have ended up using a native image comparison library.


Angular material mdc migration

With angular 15 there was an update for the angular material components.
Currently we are using MatLegacy... modules which should be replaced in the near future with the new MDC components.
There is a migration tool which automatically replaces the used modules and updates some other things. However this needs testing and manual intervention in at least most cases. For that the migration tool has a feature to do this migration only for specific modules (which has the drawback that the main styles.scss will not be modified).
A migration guide can be found here: https://material.angular.io/guide/mdc-migration
Components to migrate

[x] Autocomplete
[ ] Button
[ ] Card
[ ] Checkbox
[ ] Chips
[ ] Dialog #3397
[x] Form Field #3002
[x] Input #3002
[ ] List
[ ] Menu
[x] Option / Optgroup #3002
[x] Paginator
[ ] Progress Bar #3097
[ ] Progress Spinner #3097
[x] Radio #3001
[x] Select #3002
[x] Slide Toggle
[x] Slider #2998
[ ] Snack Bar #3097
[ ] Table
[x] Tabs #2998
[x] Tooltip #2999

When working on this: Do not try to stick to the old appearance too much and just adapt the changes from the library. This will make our life easier especially with the upcoming material design 3 update.


chore(cli): linting 1/5

That was my first effort in the lining progress, before I split them per package, all subsequent PR will aim here.

test red waiting for #94


Having trouble with redirect_uri

Hi, I'm having a bit of trouble, and I would appreciate some help
I'm following the instructions to set up LinkedIn (in place of Facebook). I've added the app, as it says in the instructions, but I don't understand what to do with the redirect URI, as the instructions state that it should be blank. I have a link on my website of the form:
https://www.linkedin.com/oauth/v2/authorization?response_type=code&client_id=CLIEND_ID&redirect_uri=      http%3A%2F%2Ffoo.com%2Ffrontend%2Flogin_redirect&scope=r_basicprofile
When I click this, linkedin confirms the request and then redirects to the link encoded in the url above (http://foo.com/frontend/login_redirect) with some parameters in the url. I should then send those parameters to a particular linkedin api endpoint to obtain a token for the user.
Currently, when linkedin tries to redirect, a 404 error is returned. I tried adding that redirect URI to the redirect URIs of the application, and the result was the same.
To summarise, do I need to use a particular redirect url (in which case, what is it?), or, if not, how do I tell django-rest-framework-social-oauth2 which redirect URI it should make available?

The redirect URI would be and url on your front end. Your frontend extracts the code from the URI and can use my package to convert it.


The hero img looks strange on high resolution display

Hmm not really sure what's strange? You mean the font is too small?

No. It seems that the hero-image was cropped when comparing to a it self on a iPad.
BTW, I am not a front-end developer, if I asked a silly question, don't be angry 😂.

No worries, it's adjusting because of background-position: 50%  and height constrain CSS in _sass/pages/page.scss. If you want you can adjust height property on line 13 to a bigger value, so that on larger breakpoints the image is larger. You can play around in your browser dev-tools to find a value that would hit the right spot for you 🙂

@janczizikow Many thanks to you, I'll try it.


docs: Update snapshot examples to Jest 19

http://facebook.github.io/jest/blog/2017/02/21/jest-19-immersive-watch-mode-test-platform-improvements.html#snapshot-updates

We dropped the “test” prefix in snapshot names from top level test or it calls.
We improved the printing of React elements to cause less changes when the last prop in an element changes.

Thanks again for your contribution!

Codecov Report

Merging #53 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #53   +/-   ##
=======================================
  Coverage   97.26%   97.26%
=======================================
  Files           5        5
  Lines          73       73
  Branches       31       31
=======================================
  Hits           71       71
  Misses          2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3d45a8...637fee7. Read the comment docs.


Does semver invalidate Nx caches when the CHANGELOG.md files are created?

Hi,
I would like to verify my workflow:
Steps:

Build entire project in develop branch successfully
Run your semver plugin
Push to master
Build everything again in develop branch

At Step 4., has the semver plugin invalidated all the caches for the libraries where it updated the CHANGELOG.md file?
If yes, is there a way to avoid doing that?
Thank you

Hi @bjornharvold, thank you for raising this issue.
In fact, semver plugin will implicitly invalidate Nx cache. This isn't something we control (or want to control) as, apparently, Nx will invalidate the cache when any file is added/changed/removed in the project's folder.
In addition to this, it's the desired behavior as CHANGELOG.md is part of the source code and could be used by some custom build commands to generate docs and stuff like that.