Readme update

fixes #992
This is an attempt to restructure the readme

I think we are going to get way more questions about stability (and they are already frequent) if we move our stability info out of the readme, but I don't have a strong opinion on it. What do you think?
I think we should have a look over slack and issues for things that people ask a lot even if they are on the docs and have them on the Readme or at least linked in the readme. Or have a FAQ linked in the readme. :thinking:

I would add a Sponsoring as well with ways companies can sponsor us (engineer time, infrastructure, money, etc). And maybe some words that sponsorships can be anonymous if the companies want.

I think we are going to get way more questions about stability (and they are already frequent) if we move our stability info out of the readme, but I don't have a strong opinion on it. What do you think?

I feel that the question comes lesser nowadays. I wanted to take it out because it takes up a lot of space. I added a link on the readme to the stability & support page.

FAQ

I went over the last ~2 months and most of them were legit questions, small details or troubleshooting.
This is what i noted down, i'm not going to write it down in the scope of this PR, i'll create an extra issue for it.
FAQ
Why should i use this over csi-secret-store
Why should i use this over SealedSecrets
How does templating work / how do i debug templating
How do i debug an external-secret that doesn't sync?
How do i refresh a secret?
What the heck base64
Authentication mechanisms
Upgrade procedure from KES to ESO
``

/approve

/approve

Not sure if my phone or GitHub being weird, but everything that I've sent went double 😅 and it it is not letting me delete. Let's see if this content will get doubled as well 👀

We can let it like that and if we see the need to add it afterwards, we can just add. LGTM!
thank you @moolen !!

/merge

Stability and support link seems to be broken

We need to cut a release for them to be available at latest. If you go to /main/ you will find them.

Things linked from the readme, since they are main by default, could link to main links, right? (Except for the root doc link).

Contributing links, coc, stability. They are always stuff that we wanted out there right away on the repo readme that is on main.


fix: try to open with Chrome if default browser app does not support custom tabs

Connection with issue(s)
Resolve issue #1232

Testing and Review Notes

Install browser app which does not support custom tabs such as Sleipnir
https://play.google.com/store/apps/details?id=jp.co.fenrir.android.sleipnir

Set installed browser as a default browser app by setting app

Try to open URL by ChromeSafariBrowser

Before this fix, cannot open URL
After this fix, can open URL by Chrome

To Do

[x] double check the original issue to confirm it is fully satisfied
[x] add testing notes and screenshots in PR description to help guide reviewers
[ ] request the "UX" team perform a design review (if/when applicable)

If Opera browser is installed, somehow all queries return nothing.
After some research, I found that Chrome developer site's sample code has category setting for query intent. Added this solve the problem somehow. Very weird, but it works.

Thanks! @all-contributors please add @addie9000 for code


FloatingSearchView in Toolbar (Google Play like)

Is there a way i can achieve the same behaviour as in the new Google Play Store?
Tried every XML variant but it isnt working for me ( cause it needs to take full height in order to work with suggestions. But then the Toolbar height is full height (cause Search is nested in it))
My concern is on stackoverflow too, but no answers yet. If it is not a productive issue/concern, you can close it. Just curious if someone got it working somehow.
http://stackoverflow.com/questions/34311630/android-floatingsearchview-inside-toolbar

Hi @markuspaschke,
To add to my answer on SO, although you can't use the scrolling effect using the Toolbar, it is likely that I will add some custom support for scrolling, I agree that it is a needed feature.
In addition, if you would like to contribute to the project by adding the above feature or any other feature, let me know and I will publish a document about how the library works.
Thanks for your comment.

Is there a document anywhere that gets it working?

Hi @apMadden , Yes there is an example in the sample app.

Hey @arimorty  thanks for the quick response. Looking at this now this isn't the right issue, my mistake.


doc: Update link to React v16.0 documentation

doc: Update link to React v16.0 documentation
Releated: #7151

The TODO here is to fix the deployment of the 16 docs. Until then, linking to 17 is fine because there's really no differences between 16 and 17.


AxisTitle Alignment

Before v0.50, the x-axis labels can be aligned to the bottom of the chart. But after the upgrade, I'm not sure how we can have the label not be on top of the bars. I tried text alignment but that didn't do the trick.
Screenshots

Versions
Flutter v3.0.5
fl_chart v0.55.1

Hi. As you might know, titles are widgets now. So you can wrap your titles with a Padding widget to shift them down.

Adding Padding will shift it out of the "box"
Here is my widget
return SideTitleWidget(
    axisSide: meta.axisSide,
    space: 0.0,
    angle: min(pi / 2, _numTitle * (pi / 25)),
    child: Padding(
      padding: const EdgeInsets.only(top: 8.0),
      child: Text(
        _label.substring(0, _endChar),
        style: Theme.of(context)
            .textTheme
            .caption!
            .copyWith(fontSize: 10.0),
      ),
    ),
  );

@imaNNeoFighT Adding Padding will shift it out of the "box"
Here is my widget
return SideTitleWidget(
    axisSide: meta.axisSide,
    space: 0.0,
    angle: min(pi / 2, _numTitle * (pi / 25)),
    child: Padding(
      padding: const EdgeInsets.only(top: 8.0),
      child: Text(
        _label.substring(0, _endChar),
        style: Theme.of(context)
            .textTheme
            .caption!
            .copyWith(fontSize: 10.0),
      ),
    ),
  );

same issue here. add space or padding will shift it out of box.
It used to work well before v0.50.
Have you figured out any workaround ?

To anyone who hasn't figured it out, try increasing reservedSize along with Padding to increase the box and avoid shifting the Title out of it.


fix(Creampies): Make it so identities are respected when creaming or being creamed

About the PR

Made it so identities are respected when creaming or being creamed
Why / Balance

Resolves #18540
Resolves #30676
Technical details

Media

before (refer to)
#30676
#18540
After
Screencast from 08-05-2024 04:17:09 PM.webm
Requirements

[x] I have read and I am following the Pull Request Guidelines. I understand that not doing so may get my pr closed at maintainer’s discretion
[x] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

Code kinda shit IMO

Might fix

https://github.com/space-wizards/space-station-14/blob/f7d8b4e7d469c03f4adab33307af4a44e44b0319/Content.Server/Flash/FlashSystem.cs#L139-L143
No idea if I'm supposed to use Identity() or not.

Gyaat

Mistakes where made


Add Code Of Conduct

A Code Of Conduct file is necessary for smoother collaboration and contribution, reducing conflicts. Please assign the issue under SSOC'24

@Niharika0104 mam,please add labels


Setup screen

This pull request alters the words in the Setup Assistant, mainly based on information and suggestions from http://bit.ly/Aa0Udv
I also fixed a small bug I came across when playing with the setup assistant:
If you run the setup assistant from within the QS prefs, finish it, then click 'run' again, it takes you to the last page as opposed to taking you back to the first.

I was hoping this could be merged in time for ß64 seeing as it's just words, but no rush :)


Add popup menu support

A popup menu is likely a Grid (after #100) + vertical Scroll widget being shown on an overlay layer.
Showing a popup menu needs to support being placed near an arbitrary location. As of writing this, the overlay widget only supports placing relative to a widget, so this is potentially new functionality for the overlay.
The popup menu needs to support type-to-select. However, I want any widget to be able to be used as a menu item, so this needs to either be callback based or we need a way to specify the type-ahead-string for a given menu item.
The API for a popup menu needs to support being notified if the menu is dismissed without a selection being made. a OnceCallback can be used to signal when a selection is made or cancelled.
It might be nice to have a dedicated widget that renders a chevron and displays the associated popup menu. This could then be used within a button's label to offer a push button with an optional popup menu.

As of 07f1febe9fbf4514ee07f1d92eac8ccb584de307 this is mostly implemented. Opening new issues to track remaining features.
https://github.com/khonsulabs/cushy/assets/50053/264b15cf-be01-4f0e-848e-cae574029596


Add "integrations" docs section

Maybe add also a section how to run an allure report locally in browser?

The thing is I never did that. Can you point me to some tutorial/docs?

And if so maybe we should link also docs to how to setup Allure report? XD

https://github.com/allure-framework/allure2

And if so maybe we should link also docs to how to setup Allure Report? XD

Great idea. At first I just wanted this PR to be a replication of #1605 but in docs, but if there's more good we can do, let's do it.


Ideas to implement

Some of the ideas I have jotted down to enhance the experience:

Random car after you lose!
Snow mod
NOS limiter
Engine blow
Chaos combo
Game crash when you collide hard
Blindfold
No reset
Solo car (not nuzlocke anymore)
Lose money per lost car
Stock only!
lose grip more the race lasts
random roadblocks with traffic cars?
faster & more agressive traffic like in UG2 RacerAI

Accelerate the tram in chinatown track and/or the train in drag race track, if possible
Force upon the player a certain randomly picked car up the beginning of the career (and optionally: do not let them choose other vehicles except unlocked ones (ouch!)). Or maybe it is Solo car already.

Thinking about it, the best approach to implementing this would be something like mutators in UT.
Might as well call them that.


feat(appeals/api): add audit trail logging

Describe your changes
Initial group of audit trail logs for features that have already been developed.
Issue ticket number and link
https://pins-ds.atlassian.net/browse/BOAT-531
Type of change 🧩

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation update
[ ] Other (please explain in the description section above)

Checklist before requesting a review

[ ] I have performed a self-review of my own code
[ ] I have double checked this work does not include any hardcoded secrets or passwords
[ ] I have made corresponding changes to the documentation
[ ] I have provided details on how I have tested my code
[ ] I have referenced the ticket number above
[ ] I have provided a description of the ticket
[ ] I have included unit tests to cover any testable code changes

this may create conflicts with https://github.com/Planning-Inspectorate/back-office/pull/1615.

this may create conflicts with #1615.

Ok...I'd better get mine merged first then ;)


Multivariate nodes

Hello,
I was wondering if it is possible to use multivariate nodes in a graph.
Here is an example: Let's say, we have some features (that are acquired at the same time and that we assume they are not independent of each other) which we want to represent together in a node. We thought about creating tuples out of these features, so, the respective column (which would ideally correspond to the multivariate node that we want to have) of the DataFrame will contain these tuples. However, apparently, this leads to the categorical encoding of each unique combination of the tuples.
What would be the correct practice to do achieve this? We don't want to represent each of those features as independent nodes again as we assume that they are not independent.
Thanks in advance!

usually it is best to have univariate nodes and express the relationship between any two variables through edges. In your case, given two features (A,B) acquired at the same time, perhaps it is not clear whether A causes B or B causes A.
Do you know anything about A or B? A reasonable choice would be to model them as having a common unobserved cause. Graph is U->A, U->B and U is unobserved. If more is known about the relationship between A and B, then you can add an edge between A and B too.

Thank you for the answer! The problem was that there were 30-40 features (about the medical history), and we couldn't conclude whether there were causal relationships between those features, as we didn't want to make any hard assumptions. But we can follow what you suggested.


fix "attempt to index a nil value" in CodexQuest:CheckNamePlate()

Sometimes frame:GetName() returns nil so we must check it before call :find() or an attempt to index a nil value error will be threw.
However, the Pull Request https://github.com/project-classic/ClassicCodex/pull/36 removed this check. So I met this when I was standing next to the Orgrimmar Flight Manager and do a /reload:
(Note: Line number is different from current master branch, the file: https://github.com/SwimmingTiger/ClassicCodex/blob/master/quest.lua#L398)
3x ClassicCodex\quest.lua:398: attempt to index a nil value
ClassicCodex\quest.lua:398: in function `CheckNamePlate'
ClassicCodex\quest.lua:126: in function <ClassicCodex\quest.lua:28>

Locals:
...
frame = <unnamed> {
 0 = <userdata>
}
...

Add the check back and add a comment to avoid subsequent developers deleting it.

#36 was opened in rush and I'm sorry that it wasn't fully tested.
I look into CodexQuest:CheckNamePlate this time and I found it is called when NAME_PLATE_UNIT_ADDED triggered and traversing all children of WorldFrame and find all the nameplates. Since there is C_NamePlate.GetNamePlateForUnit, I think it is not efficient to traverse. I'll open a new PR later.

Is it really faster to traverse 40 units at a time than the previous method? The previous method only needs to traverse about 20 at a time.
function CodexQuest:UpdateAllNameplates()
    for i = 1, 40 do
        local unitID = "nameplate" .. i
        if UnitExists(unitID) then
            CodexQuest:UpdateNameplate(unitID)
        end
    end
end


Increase ANCMV1 minor version to 8.2

https://github.com/aspnet/IISIntegration/blob/release/2.2/version.props currently has 8.1 as the version number, which isn't higher than the current ANCM installation. This causes the dll not to be replaced.

Current public ANCM version:
ANCMV1
Dll version: 8.2.1991.0
Msi version: 2.1.1991
Proposed versions:
ANCMV1 and ANCM V2
release/2.1
Dll version: 12.1.xxxx
Msi Version: 2.1.xxxx
release/2.2
Dll version: 12.2.xxxx
Msi Version: 2.2.xxxx
release/3.0
Dll version: 13.0.xxxx
Msi Version: 3.0.xxxx
This keeps versions between the dll and msi consistent.

What about WHB?

@joeloff Can we make build versions of the windows hosting bundle match what we do for the rest of aspnetcore?
https://github.com/aspnet/WindowsHostingBundle/blob/master/tools/Version.props#L50-L63 vs last two digits of the current year + number of days since Jan 1st?

Normally we'd grab the build number from the props file that's passed through during official builds. That section is only used when you build locally to generate a build number


Doesn't open some ZIPs

Hi again,
Tried to open a MDV inside a ZIP file, it didn't work.
Should I consider something else?
Note: Perhaps I understood wrong the information about what it does and how to use it.
Thanks.

ZIP files aren't supported by the device, uncompress the file before.


Babel errors

Server can now deal with the special snowflake babel errors.
Server now just logs compilation errors, instead of exiting

@Techwraith gave the green light


examples: fix leak on error path

We would leak ip when we goto fail.  Always allocate the small string
so we can always call free on it.

thanks


stagelinq-discover: use %v to render map[string]interface{} values (#26)

As referenced in #26, us %v to render map[string]interface{} values in stagelinq-discover.

Thank you for the PR! :)


Multiverse: First PR

Brief description
First PR for Multiverse
Description
Support Multiverse at OpenPype
Additional info
Documentation (add "type: documentation" label)
https://j-cube.jp/solutions/multiverse/docs/dev/
Testing notes:

Install Multiverse as free user and setup it to OpenPype
Create USD, USD Composition, USD Override from Maya and publish them.
Load USD firstly to Maya, and Copy File path to USD Override and add it as USD layer at Maya.

Thank you for the contribution @zhoub We'll do our best to review as soon as possible.

From your "testing notes":

Load USD firstly to Maya, and Copy File path to USD Override and add it as USD layer at Maya.

Would love to hear some thoughts on how applying overrides could be better managed in the pipeline instead of needing to "manually" add these from a copied path like this. Especially because those loaded override wouldn't be loaded 'versioned' in the correct way? It'd always refer to the single static version?
A first thought:
We could have an extra Loader implementation (which doesn't actually create any new containerized nodes) that's labeled "Add as override". It could just go through the current user selection to find all multiverse compounds and just adds this as an override layer. Still we'd need to define how to "manage" the versions for that too.

We could have an extra Loader implementation (which doesn't actually create any new containerized nodes) that's labeled "Add as override". It could just go through the current user selection to find all multiverse compounds and just adds this as an override layer. Still we'd need to define how to "manage" the versions for that too.

We briefly discussed with the guys from jCube the same thing as an option. We have multiple places where similar approach is taken now. Yeti rigs are the best example for example, where they get applied to selected geometry upon loading, or try to find it based on IDs similar to the look manager.
Looks being applied with IDs to the corresponding meshes are another good example.

Looks being applied with IDs to the corresponding meshes are another good example.

Sort of, yes. But adding it as an attribute into an existing loaded content does mean it might be hard to keep track of the currently loaded version with how containers are built - because you'd still need the 'container' for host.ls() to pick it up. Not impossible, but not trivial either.

Solid stuff - unfortunately I don't have the time to actually give this a production test run, but the code looks good to me.

Thanks a lot for testing.

I think we will add a page in our documentation first, then we can give you a link to it. But maybe we should also write a short documentation on the OP docs. Could you point me to a documentation of a similar tool? (such as the alembic creator and loader?)

@pberto this is the closest example probably https://openpype.io/docs/artist_hosts_maya#working-with-yeti-in-openpype

I know this PR is closed, but I would like to show the docs I am working on. It would be good to know if the style makes sense before making going far, then I make a doc pr:
https://github.com/j-cube/OpenPype/commit/70fe3f87127b7476f6c3d84437e292dba5022459

I know this PR is closed, but I would like to show the docs I am working on. It would be good to know if the style makes sense before making going far, then I make a doc pr:

Do you still need to add the images in the documentation to the Branch?
Other than that I feel the documentation looks very solid and thorough. Some bits might be somewhat "generic OpenPype" information too, regarding how creators work etc. But I don't feel that's in the way currently.

Yes I did not add the images yet. Glad you like it. I will get through it :)

Next PR is in: https://github.com/pypeclub/OpenPype/pull/3178


Feature Request: Import tasks to project

My actions before raising this issue

[X ] Read/searched the docs
[ X] Searched past issues

I have many tasks, unassociated with a project, created on an older version of CVAT (from before projects) - I wish to merge these tasks into a single project (with a single labelling schema etc). I would like to request that the devs consider adding the feature of moving an existing task to a project.

Hi @LukeAI
You can do this:


Provide container images

After merging this pull request and publishing a new release, this should work:
docker run --rm --publish 9292:9292 ghcr.io/tabulapdf/tabula

The service will be available on http://localhost:9292

Thanks! I don't really know how to evaluate this, but at least superficially this looks good to me. @jazzido ? @mtigas ?

@mtigas, feel free to merge this; I don't have permission to do so.


Store outlet info

Solve #85

Pull Request Test Coverage Report for Build 225

126 of 207 (60.87%) changed or added relevant lines in 17 files are covered.
2 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-2.6%) to 90.256%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/main/java/seedu/ptman/logic/parser/PartTimeManagerParser.java
0
1
0.0%

src/main/java/seedu/ptman/model/outlet/OutletInformation.java
13
14
92.86%

src/main/java/seedu/ptman/model/ModelManager.java
5
7
71.43%

src/main/java/seedu/ptman/model/UserPrefs.java
2
4
50.0%

src/main/java/seedu/ptman/storage/StorageManager.java
13
16
81.25%

src/main/java/seedu/ptman/logic/commands/ViewOutletCommand.java
0
3
0.0%

src/main/java/seedu/ptman/ui/OutletDetailsPanel.java
3
6
50.0%

src/main/java/seedu/ptman/commons/events/ui/AnnouncementChangedEvent.java
0
4
0.0%

src/main/java/seedu/ptman/logic/parser/AnnouncementCommandParser.java
0
5
0.0%

src/main/java/seedu/ptman/storage/XmlOutletFileStorage.java
4
9
44.44%

Files with Coverage Reduction
New Missed Lines
%

src/main/java/seedu/ptman/model/outlet/OutletInformation.java
1
95.0%

src/main/java/seedu/ptman/logic/commands/ViewOutletCommand.java
1
0.0%

Totals

Change from base Build 213:
-2.6%

Covered Lines:
2362

Relevant Lines:
2617

💛  - Coveralls


showdown.setFlavor('github');

So I tried putting
showdown.setFlavor('github');

into my JavaScript as per the help file:
converter = new showdown.Converter()
converter.setFlavor('github');
html=converter.makeHtml(text)

but now the script gives the error:
TypeError: converter.setFlavor is not a function

I'm completely confused... how did that happen?

Does the converter or showdown object gets created properly?

Yes, the html that is output is correct.

Does it work when you set it in the global level?
showdown.setFlavor('github');

It works for me. I couldn't reproduce this issue. Please provide more details

node - v8.11.1
npm - 5.6.0
showdown - 1.9.0
windows 10 pro

@joereddington that's interesting. Everything seems to work fine in a browser. Maybe you've accidentally changed converter variable in some other script or used setFlavoUr method =)
'use strict';
const conf = {simpleLineBreaks: true};
const converter = new showdown.Converter(conf);
converter.setFlavor('github');

const root = document.getElementById('root');

let xhr = new XMLHttpRequest();
xhr.open('GET','./jsnotes.md');
xhr.send();
xhr.onload = function() {
  root.innerHTML = converter.makeHtml(xhr.response);
}


AMBARI-23997. Server metadata cache does not have valid hash after updates with no any registered agent.

What changes were proposed in this pull request?
Now server guarantees hash relevance for metadata cache. Also metadata cache contains actual info about GPL acceptance.
How was this patch tested?
Manual testing.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/2537/
Test PASSed.


Pass associated notebook document to kernel source command

Kernel commands don't need to check for activeNotebookEditor.notebook anymore.

rebornix/fragile-swan


[subset] Improve PairPosFormat2 subsetting

This does two things:

Intersect subsetter glyphset with the table's Coverage before
passing to ClassDef1 for subsetting.  Anything that doesn't
get past Coverage wouldn't ever get to ClassDef1,

Never reuse class0 of ClassDef2.  There's unspoken assumption
that ClassDef2's class0 is never used for actual kerning, since
that's the unbounded "every other glyph" class.  Previously our
ClassDef subsetter was reusing class0 if "every other glyph"
happened to become empty because of the subset glyphset.  Don't
do that for PairPos's ClassDef2.  As a result of this assumption,
don't keep a PairPosClass2 subtable if only ClassDef2's class0
survived subsetting.

Would be good to add tests for both.
Related to https://github.com/harfbuzz/harfbuzz/issues/2703

Would be good to add tests for both.

it looks like @garretrieger is already adding some test files along with the respective harfbuzz subsetter's changes in https://github.com/harfbuzz/harfbuzz/commit/f6298da947bc45d77d631266f142c8ebf1e5856e
Could you point to the actual file(s) relevant for this issue so we can add it here too?

The font file we use in the harfbuzz tests is: https://github.com/googlefonts/harfbuzz/blob/gpos_2/test/subset/data/fonts/gpos2_2_font5.otf
and the specific subset text that triggers a situation effected by this change is:
.#

@garretrieger Hey Garret, I tried using the font file you pointed to from harfbuzz test suite, called "test/subset/data/fonts/gpos2_2_font5.otf". If I subset it using the text string you said, with the commandfonttools subset gpos2_2_font5.otf --text='.#' I get the same subsetted output whether @behdad's current PR patch is applied or not, in both cases the GPOS table is emptied (no lookups left).
Are you sure this is the right font/string combination?

@behdad could you help me figure out a good test case for this? someting like "given some kern feature containing pos class rules, and this subsetter --text input, the expected result is ..." I can then turn that into an actual test. Or I just assign it back to you and you finish this.

Hmm let me check on the result of that test case in harfbuzz.

Ok, I see the same in the expected files. These test cases
!#
!#%
both produced changes in the fonttools expected files in the PR and have a non-empty GPOS. So I'd try those instead. You can also look at all the cases we test (it's a cross product of the fonts, profiles, and subsets):
https://github.com/harfbuzz/harfbuzz/blob/master/test/subset/data/tests/layout.gpos2.tests

Thanks Garrett, I tried both "gpos2_1_font7.otf" and "gpos2_2_font5.otf" with the combinations of text strings you posted, and they both result in an empty GPOS whenever I run through the fonttools subset <fontfile> --text-file=subset.txt, whether or not @behdad's patch from this current fonttools PR is applied or not. I run the same command with fonttools installed in editable mode, checking out the main branch (where the patch is not applied) and this PR branch, and I don't get any different result. In all cases, the resulting GPOS is empty. I need to figure out a test case that makes the current main branch fail, and this PR branch pass.

AH! I had to pass --layout-features+=test otherwise the "test" feature under which those PairPosFormat2 were located were dropped by default :)

@behdad PTAL (I can't add you as reviewer as you're the PR author)


Supporting Ruby 2.6.6 and other security releases

Ruby 2.6.6 was a security release, and came out on 3/31/20 (https://www.ruby-lang.org/en/news/2020/03/31/ruby-2-6-6-released/).  It's not yet available in setup-ruby so things like CI jobs can't run Ruby 2.6.6 yet and will output: ##[error]Version 2.6.6 not found.  It looks like this kind of lag has been raised as an issue for previous Ruby releases (eg, https://github.com/actions/setup-ruby/issues/8) but I don't see anything on the releases this week.
It seems like one alternative is to swap the job to run in a Ruby container instead of on the runner.  Another alternative is to use https://github.com/ruby/setup-ruby, which worked for me as a drop-in replacement and includes 2.6.6.
Thanks!

Thanks @kevinrobinson!  I have temporarily switched over to ruby/setup-ruby as a result of your post and everything is happy.   Thanks for raising this issue for the rest of us. Cheers 🍻


Warning displayed when rendering

When rendering all icons the following warning is displayed:
Warning: Unknown DOM property fill-opacity. Did you mean fillOpacity?

Also
 Unknown DOM property fill-rule. Did you mean fillRule?


Starting proof of concept on live preview

Initial ideas on creating a previewing system of animations and gifs via the usage of Images.jl and ImageView.jl.
Currently, there is no functional code ready for testing yet. I wanted to write down my thoughts before I forgot about them here:
My initial thought of handling this problem is to store the image in the buffer of one's computer. From there, preview the image by serializing it to some graphical viewer. Once the graphical viewer exits, the preview process finishes. Right now, for my proof of concept, I am constraining the problem as follows (lemme know your thoughts @Wikunia):

Create a method in the javis function to create images that are saved into the buffer when the method is called with something like liveview::Bool.

Determine how to convert the Luxor based Drawing object to an object compatible to a form suitable for being read by other viewing libraries.

Preview one image with one frame in a viewer.

Close the viewer and have the script gracefully finish execution.

Some notes I have on the process so far.

I inspected Images.jl and using the load function, the image is loaded in as the type: Array{RGB{N0f8},2} with eltype RGB{Normed{UInt8,8}}. The Luxor.jl based Drawing object can be stored into the buffer using the call type: Drawing(500, 500, :image)

There is a native function in Luxor.jl to get the matrix representation of the stored Drawing object called image_as_matrix() which must be called after defining everything to be drawn onto a Drawing. By the following collect(image_as_matrix()) call, the returned matrix is of the form Array{ARGB32,2} with eltype ARGB32.

An interesting dilemma is to determine whether or not @cormullion would want a native function in Luxor.jl to convert the Drawing object's matrix to a matrix type compatible with Images.jl. Or if we should make our own method for handling Images.jl type...

I wonder what would be the best viewer for CLI based viewing. Looking at GTK.jl and ImageView.jl right now

Fun fact, this should be able to be rendered natively in a Jupyter notebook without any extra work! :D

I wonder if we could make some sort of REPL based communication tool to the viewer to go forward with images, skip to a frame, etc.

Further, I had a great conversation with @staticfloat on the Julia Slack about this interesting problem space. Here are excerpts before I lose them to the Slack void:

That I don’t know; usually I do stuff like RGB.(x) to convert an array x from one type to an RGB type, but that depends on RGB having a constructor that looks like RGB(::ARGB32).

If that doesn’t exist, you may be able to define something like ThrowAwayAlpha(x::ARGB32) = RGB(x.r, x.g, x.b) or something like that.

then you can do ThrowAwayAlpha.(array)

By spooky coincidence I've just been rewriting the imagematrix functions, because of bugs in transparency handling... My current code, on master and intended for a breaking Luxor version 3.0, outputs a plain array of arrays of floats (potentially RGBA values):
julia>  m = @imagematrix begin
               background(1, 1, 0, 0.5)
       end 2 2
2×2 Array{Array{Float64,1},2}:
 [1.0, 1.0, 0.0, 0.501961]  [1.0, 1.0, 0.0, 0.501961]
 [1.0, 1.0, 0.0, 0.501961]  [1.0, 1.0, 0.0, 0.501961]

The differences here are because arithmetic on the ARGB32 value 0xFFFF0080 is low precision.
I'm just guessing at all this stuff - I'd rather be doing other things with Luxor. :)

Can you @TheCedarPrince clarify what fails with ARGB seems like Images can handle that based on https://juliagraphics.github.io/Luxor.jl/stable/basics/#Drawing-as-image-matrix or am I wrong?
My initial thoughts on this were actually to not see one frame but all frames just live.
In steps

We create an ImageView (or GTK) canvas
have a sleep statement depending on the frame rate
update the canvas for the next frame

The user might want to be able to specify something like rendered frames such that on a 10 min movie production it's easy to see the last 5 seconds as an example.
I also like the idea of jumping using the command line but I would move that to another issue for now.
Side note: I've seen that you changed formatting of the files which makes it harder to review your code in the future as it's unclearer which lines are actually effected. Do you mind to open a different PR for this formatting as I do think it looks nice :wink:

Can do @Wikunia ! My linter was a bit overzealous and decided to reformat everything. I will open a separate PR about syntax formatting since you like the style. I was using JuliaFormatter.jl for that formatting. Should work in VSCode as well!
Oh, nothing was failing, I was just writing up my notes/thoughts before I forgot them. I agree -- the CLI based jump tool is a separate thing altogether.
I agree with your vision as well for what could be done - I was just working on a proof of concept to get at least one frame shown. Your idea is the long-term goal for this PR. I typically solve complicated problems like this by breaking it up into smaller parts, solving each of those, and then recombining them to solve the big problem. I'll ping or Slack you as I make progress.
@cormullion spooky :ghost: ! I quite like that raw version of you handling the matrix. Seems like it would give greater flexibility to users so that they could map the returned type to whatever they need. Cool! Looking forward to v3.0! :smile:

I am not sure if ImageView.jl will work for our purposes. I just started a discussion in #image-processing in the Julia Slack about this strange behavior I am getting when I am attempting to preview a gif via imshow:

I will keep exploring to see what is possible!

I would assume this is because of color palette issues.
In our case I thought we would always just push the new image matrix and not a gif because in live view we would not create a gif.

That makes better sense @Wikunia . I guess what I am having trouble trying to figure out regarding an animation that has 1...n number of frames and how to show specific frames to a user.
What I was thinking was that using the image_to_matrix() function, was to create a matrix of matrices where one could easily access frames they would want to see. The array I imagine could be of the form n x length x width where "length" and "width" are dimensions of the frame. If I want to view a subset of the frames, I could then access this matrix to get the specific frames I want to display.
However, where I get lost is how best to show not just one image, but any number of images. That was why I was exploring the imshow method as I thought that could potentially work for this case. It may still so I will continue examining it.
Do you understand where I am running into an issue? Feel free to Slack me if I am not being clear. If you have additional thoughts, let me know! Thanks!

How about this? https://juliagizmos.github.io/GtkReactive.jl/stable/drawing.html
Being able to have a slider for the frame and the frame gets rendered and displayed when the user changes the slider.
Maybe we can also use: https://juliagizmos.github.io/GtkReactive.jl/stable/reference.html#GtkReactive.player not sure how to handle frame rate there but it might be an option.

@Wikunia don't know if this is still useful

Thanks for the tip @cormullion ! I think this is the golden ticket for this problem!
I made some additional progress. I have this gif showing some of what I got working right now:

What I was able to figure out was to get a slider to show that sends a signal to and from a textbox object. The textbox object can also send a signal back to the slider. It's pretty fun and what I imagine it being used for is via the slider or textbox, each time a new frame number is chosen, a callback action could take place to get the correct frame and render it in the viewer. My next step is to get an image to render in a GTK canvas, but I am struggling to know how to do it. Sadly, the documentation is not so great.
UPDATE: I got images working! Now to make the image appear with a slider/textbox widget...

This is ready for review @Wikunia. There are some notes and comments I left inside the javis_viewer.jl file so as to keep things in mind for future upgrades to the viewer. Let me know what you think! :smile:

Great I resolved some conversations. Do you it is reasonable to make the viewer also loop from the last frame to the first one? This seems to make sense when one normally creates a gif at least :wink:

Also format your code!  I think this is finally ready for merge.

I think we can't write tests for this as we can't open a display.

All tests passed, I added thorough documentation to the functions and methods. Feel free to review @Wikunia.

Hey! I reran the CI and things look OK @Wikunia ! Mind if I do the honors to merge it - if of course there are no more problems!

Do you mind to also add a test for going from the last frame to the first frame and back?
Then it's good to go!

HELL YEA!!!!! :fire: :fire: :fire: Thanks for all the critiques! I am pretty happy with the first iteration of this viewer!


fix: improved hash code generation (#490)

1. Description

1.1. Checklist

[ ] The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs: etc).
[ ] I have read the Contributor Guide and followed the process outlined for submitting PRs.
[ ] I have updated/added tests for ALL new/updated/fixed functionality.
[ ] I have updated/added relevant documentation in docs and added dartdoc comments with ///.
[ ] I have updated/added relevant examples in examples.

1.2. Breaking Change

[ ] Yes, this is a breaking change.
[ ] No, this is not a breaking change.

1.3. Related Issues

Codecov Report

Merging #491 (9b9b815) into main (a1e72c7) will decrease coverage by 12.52%.
The diff coverage is 1.17%.

:exclamation: Current head 9b9b815 differs from pull request most recent head acdfc2a. Consider uploading reports for the commit acdfc2a to get more accurate results

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@             Coverage Diff             @@
##             main     #491       +/-   ##
===========================================
- Coverage   77.11%   64.59%   -12.52%
===========================================
  Files         173      122       -51
  Lines        1586     1110      -476
===========================================
- Hits         1223      717      -506
- Misses        363      393       +30

Impacted Files
Coverage Δ

.../lib/src/entities/adaptor/repo_commit_adaptor.dart
0.00% <0.00%> (ø)

...y/lib/src/entities/adaptor/repo_commit_create.dart
0.00% <0.00%> (ø)

...y/lib/src/entities/adaptor/repo_commit_delete.dart
0.00% <0.00%> (ø)

...y/lib/src/entities/adaptor/repo_commit_update.dart
0.00% <0.00%> (ø)

...ckages/bluesky/lib/src/entities/follow_record.dart
0.00% <0.00%> (ø)

packages/bluesky/lib/src/entities/like_record.dart
0.00% <0.00%> (ø)

packages/bluesky/lib/src/entities/post_record.dart
100.00% <ø> (ø)

...kages/bluesky/lib/src/entities/profile_record.dart
0.00% <0.00%> (ø)

...ckages/bluesky/lib/src/entities/repost_record.dart
0.00% <0.00%> (ø)

...es/bluesky/lib/src/extension/at_uri_extension.dart
0.00% <0.00%> (ø)

... and 1 more

... and 60 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Differences in test results

After reading your answer to a similar question, the training effect is related to the random initialization of the seed, then can you ask me how much better training seeds are? I want to check the reason for the poor performance, the best results of 50 times are not ideal, but I checked the parameters and initialization methods you set (in contrast to the matlab code), and found no problems. These all make me very confused and can't find the reason.

Yes, other parameters are the same as in the Matlab version. However, the random process may affect the training because the image pair for training is randomly picked (check /Train/VIDDataset.py line 52 to 54). Each time, the image pairs used for training may be different, which may result in the different trained models.

Hi! @HengLan , can you tell me how to compute the num_pairs in Config.py.

Hi! @HengLan , can you tell me how to compute the num_pairs in Config.py.

You do not have to compute it. The num_pairs means the number of images pairs for training in one epoch, and it is manually determined. Of course, you can change it as you want if the performance can be guaranteed.

Yes, other parameters are the same as in the Matlab version. However, the random process may affect the training because the image pair for training is randomly picked (check /Train/VIDDataset.py line 52 to 54). Each time, the image pairs used for training may be different, which may result in the different trained models.

Thank you for your answer. I later confirmed that the two random seeds in the matlab version were set to 0. At present, I will change the random seed to 0 and then test it. But I also found another problem, your code is python2, I run it in python3, and then when I display the generated label "train_eltwise_label", I find that the center point is not centered, and the bottom right is one space. I don't know if it's a problem with the python version, but this is probably one of the reasons for the poor reproduction for me.

https://github.com/HengLan/SiamFC-PyTorch/blob/e6c538eef72e0e258cf826d2d41b341eba4e4aba/Train/Utils.py#L17
Yes, I have the same problem. I change line17 to
label_origin = np.array([np.ceil(label_side / 2)-1, np.ceil(label_side / 2)-1])

SiamFC-PyTorch/Train/Utils.py
Line 17 in e6c538e
label_origin = np.array([np.ceil(label_side / 2), np.ceil(label_side / 2)])
Yes, I have the same problem. I change line17 to
label_origin = np.array([np.ceil(label_side / 2)-1, np.ceil(label_side / 2)-1])

As far as I know, Python2 is significantly different from Python3. Your answer may be the explanation for the difference in results. Thanks!

This change does not solve the problem. Now I use Python 2 to run your code, and the results are normal. Thank you!

This change does not solve the problem. Now I use Python 2 to run your code, and the results are normal. Thank you!
What is the normal result of what you said? So you haven't changed anything, just use python2 to run the code to get the results in the article?

Yes, I just use python2 to run the original code and train from scratch. The AUC of OTB100 is about 0.58.


Closes: #1

Updated validations.py python script.
Added check to invalidate usernames starting with period or underscore
Fixes #<issue_number_goes_here>

It's a good idea to open an issue first for discussion.

[ ] Tests pass
[ ] Appropriate changes to README are included in PR

@googlebot I signed it!


chore(deps): upgrade runtime dependencies

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade-runtime-dependencies-1.x" workflow

⚪ Backport skipped
The pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually.
Manual backport
To create the backport manually run:
backport --pr 1714

Questions ?
Please refer to the Backport tool documentation


Refactor french doc

Hi Remi,
This is a refactor of the french doc (Split code to CodeBlock), preparing for a follow-up update (Add the 'All providers' section).

Thanks!
It seems that some links are broken though. The CI is complaining about invalid links

Should be good now :D

Epic, thanks a lot!


add zh(Chinese) version

Wow, this is amazing. I'll review it and merge it when I can. :)

Thank you very much. :)

Please, could you submit a PR to update this line: https://github.com/HugoGiraudel/sass-guidelines/blob/gh-pages/_data/translations.yml#L120?
Adding something like ", translated by ..." in Chinese, with Markdown links would be nice. Kind of what has been done for the Polish translation: https://github.com/HugoGiraudel/sass-guidelines/blob/gh-pages/_data/translations.yml#L100.

All right


Update regenbogen-ice api paths

The regenbogen-ice root api should be https://regenbogen-ice.de/api instead of https://www.regenbogen-ice.de/api
The new api versions doesn't support the train_vehicle all api. So I removed the api and the RegenbogenICE experimental annotation.
The new api has versioning so the old paths are deprecated.

You can see new the api changes at the regenbogen-ice api docs: https://docs.regenbogen-ice.de

Nice that I get to know the docs page thanks


how to get the position of hovered residue then highlight next residue in html

!DOCTYPE html>

thanks~
Si

I saw the tutorial in https://github.com/molstar/rcsb-molstar/blob/master/src/viewer/index.html, but I  still don't know how to get the  position of hovered residue then highlight next residue .

@JonStargaryen

rcsb-molstar isn't the best library to achieve this, it's mainly implementing functionality/behaviors specific to RCSB.org and isn't tremendously useful as general purpose dependency.
I'd go with the main Mol* library and follow David's and rtviii's comments from https://github.com/molstar/molstar/issues/1001#issuecomment-1848939354.


skip image generation for builder needs

If the builder needs is used, som stuff still happens, which is not necessary and costs build time:

static files get copied (e.g. javascript libs)
needflow, needpie and co. get generated

All of the directives should check the current builder and decide on their own, if actions are needed or not.
For the beginning, the following builder skip their internal generation/work:

needs
linkcheck
doctest
coverage

Done with the changes introduced in the last 2-3 releases.


Possibility to subscribe to multiple events

At the moment, the Subscriber only allows you to subscribe to 1 event. It would be really useful if I could write 1 subscriber that subscribers to multiple events for logging purposes etc...

I'm not sure if I get what you mean - using service tags (if you use the SymfonyBridge) you can already do this, just add more tags with the same name but different values for "subscribes_to".

I see, but there is no way to map the different Events to different notify methods?
So for example:
// RefundCreatedEvent
public function notifyRefundCreatedEvent(Message $message);

// RefundPaidEvent
public function notifyRefundPaidEvent(Message $message);

Ah, hehe, no, sorry about that. There is just one method for all events in that case, maybe you could some "ugly" switch statement there? Or add methods on the event themselves to differentiate the way you want to treat them.

I see... Maybe it's a good thing to just keep this lib simple as possible :)
I'll leave them in separated subscribers then. Thanks!

Also, sometimes middleware can be a solution for this type of problem.
Op 21 apr. 2015 20:32 schreef "Ruud Kamphuis"<EMAIL_ADDRESS>
Closed #23 https://github.com/SimpleBus/MessageBus/issues/23.
—
Reply to this email directly or view it on GitHub
https://github.com/SimpleBus/MessageBus/issues/23#event-286501255.


naught stop not working.

naught start example.js
naught stop
Child process fails to receive process.on('message', ...) in node v0.11.11 and greater.
if (process.send) {
	process.send('online');
	console.log("sent online");
}

process.on('message', function(m, server) {
	//********** This never gets called in node v0.11.11 or greater. **********
	console.log('Message' + m);
	process.exit();
});

var number = 0;
function printMessage() {
	number = number + 1;
	console.log("Message " + number);
	setTimeout(printMessage, 1000);
}
printMessage();

The setTimeout seems to effect the behavior of the master.
Removing the printMessage() block makes this work as expected.
Interesting behaviour, though, I am wondering if this is a real need or this part of the code was just meant for debugging the issue?

I think this issue was fixed with 1.5.1 :-)
(Just based on doing some manual trying)


Add property tests for luhn

Adding this as a reminder to myself to make a PR. I found some interesting edge cases this way.

One argument against this is that it's awfully revealing. Thoughts @maintainers?

I'm very keen on prop-testing, but currently we don't rely on anthing not delivered by OTP.
I do think, that introducing rebar(3) or erlank.mk here just to have some prop testing is too much.
Also this change would not only mean to just PR that single exercise, but also adding necessary stuff into documentation of how to install and get it running. I've touched some tracks where documentation and reality is out of sync drastically and I don't want this to happen to erlang (if possible).

Understandable. Also the tests I wrote have a crude reimplementation of the algorithm, which when shown to users, makes it less fun.

I do think, that property testing will expose at least a partial solution to the problem in general, so even if I am eager to it, I do fear we can't use it.
But since using rebar3 (#106) is a fact that has been decided upon, I will definitively reconsider property testing about next year.

Closing since this is stale and too revealing. The property-based tests I wrote are linked in case anyone is curious in the future.


Fix tree 14.9

I believe this fixes #29, but on the final step of the pipeline (CSV_base_table_creator ...) I'm getting a recursion depth error when trying to output the css files:
  File "/Users/yan/Documents/GitHub/tree-build/oz_tree_build/taxon_mapping_and_popularity/dendropy_extras.py", line 448, in write_brief_newick
    child.write_brief_newick(out, polytomy_braces)
  File "/Users/yan/Documents/GitHub/tree-build/oz_tree_build/taxon_mapping_and_popularity/dendropy_extras.py", line 448, in write_brief_newick
    child.write_brief_newick(out, polytomy_braces)
  [Previous line repeated 989 more times]
  File "/Users/yan/Documents/GitHub/tree-build/oz_tree_build/taxon_mapping_and_popularity/dendropy_extras.py", line 440, in write_brief_newick
    out.write(polytomy_braces[0])  # added
  File "/Users/yan/miniforge3/lib/python3.10/codecs.py", line 328, in reset
    IncrementalDecoder.reset(self)
RecursionError: maximum recursion depth exceeded

I believe this happens because of the last commit in this PR (Update Holomycota.PHY), which tries to fix the glomeromycota. Could you see if you get the same error, @davidebbo ?

I guess this is an actual limitation of the recursive python code I grabbed from dendropy. I could fix it by simply increasing the python recursion depth. I'm surprised we haven't hit it before, however, and the added fungi are not terribly deep, so I'm a bit puzzled as to why this particular change triggers such a deep recursion.

Thinking more deeply, it might not be the depth of the added fungi, but simply that those new clades contain several polytomies that need to be randomly resolved, which means that the RNG will breaks polytomies elsewhere in the tree slightly differently, which could easily hit the recursion depth limit. I'll try with some other random seeds, but I guess that's only a quick fix. The "proper" way to do this is to either increase the recursion depth, or re-write the write_brief_newick function to use iteration rather than recursion.

Going through the steps now with your files, to see if I can repro.

Thank you! I changed the seed to the classic "42" and it went through OK, so I guess that hack will do for the time being!

Thank you! I changed the seed to the classic "42" and it went through OK, so I guess that hack will do for the time being!

Ok, I guess 42 can be the answer to the tree of life, and everything.
Is this stack overflow something you saw in ordered_output.log? I did not see this, though it did seem to break in a different way. I'm running it again with 42.

Yes, it bombed out and write what I pasted above in ordered_output.log

I was actually running into an unrelated pageviews issue that I'm looking to. But for some reason, I did not hit your issue with either seed. It's possible that the seed is not deterministic across machines, so that the failure is a bit random.
If we do need to increase recursion limit from the 1000 default, it can be done via:
sys.setrecursionlimit(1500)

The pageviews issue I mentioned was just a silly mistake on my part, and not a real problem. Everything ran successfully with seed 42. Would need to try again with original seed.

By using my newick formater, I can produce a before/after diff for this change. You can find it here. Is this be interesting, as a way to help validate the change?

Interesting. I'm not sure I can get a good feel for the changes from the diff, though. I'd need to see some sort of tree comparison, I guess. There are these "tangle gram"-like things, and I've written some hack code in the past to display then. E.g. see https://arftrhmn.net/how-to-make-cophylogeny/

Agreed, it's quite hard to make sense of the diff. At least, it's clear that it added many more taxa than it removed (if it removed any). Actually, ignoring tree shape, is it at all helpful to see a list of added and removed taxa?

FWIW, the following are gone from the new tree:
Aulacoctena_acuminata_ott3684130
Aulacoctena_ott3684128
Callianira_antarctica_ott3684104
Callianira_bialata_ott3684107
Callianira_compressa_ott3684100
Callianira_cristata_ott3684101
Callianira_diploptera_ott3684105
Callianira_ficalbi_ott3684103
Callianira_hexagona_ott3684102
Callianira_ott3684099
Charistephane_fugiens_ott1578
Charistephane_ott1579
Haeckelia_beehleri_ott1587
Haeckelia_bimaculata_ott3684109
Haeckelia_filigera_ott3684108
Haeckelia_ott1588
Haeckelia_rubra_ott574290
Haeckeliidae_ott1583
LobataPlus_ott523271
Mertensia_ott523270
Mertensia_ovum_ott523265
Mertensiidae_ott1580
Miliaria_calandra_ott324663
Pleurobrachiidae_ott747323
Strigops_habroptilus_ott809432

the following are gone from the new tree

Ah, really useful, thanks.

Strigops_habroptilus_ott809432

This is the kakapo (a fantastic bird), and it should have been replaced by  Strigops_habroptila_ott6520246

LobataPlus_

That was a clade I invented in the Ctenophores.

Haeckeliidae_ott1583
Mertensiidae_ott1580

Hmm, these shouldn't have gone. But I've just revised the Ctenophores again, and will check.

Miliaria_calandra_ott324663

The corn bunting. Now Emberiza_calandra_ott6520265


Match all docs

We really need a way to show docs in an index without a query. For instance, to get a peek at what documents are in this index without knowing its schema.

query=* does that.


[CI] upgrade stretch to buster

Motivation
In CircleCI setup, bump rust:stretch to rust:buster for builders. This
is to keep it consistent with Docker build.
Have you read the Contributing Guidelines on pull requests?
Yes.
Test Plan
This is tested live in CircleCI commit verify workflow.

r+

@bors-libra r+

:pushpin: Commit 6862422 has been approved by bmwill

:hourglass: Testing commit<PHONE_NUMBER>69f03dbcdb12d9ca153778561e35c6 with merge 3743988d16364960329af1342297432ca5355e5e...

:sunny: Test successful - checks-circle_commit_workflow
Approved by: bmwill
Pushing 3743988d16364960329af1342297432ca5355e5e to master...


Request for results

Hi,
Could you please provide original results on different benchmarks?
BR,

Hi, the quick answer is we cannot.
I was visiting another lab last year. As we share all resources in my lab, my desktop has been released and transferred to another guy and he formatted everything. Sad.
I will try to search for the results which might survive someplace on some servers but don't count on that. The majority of data on the servers are some alpha/beta versions of our method.
I will update this issue if I have some founds.

Hi guys, as many people email me about the result, I re-run the experiment with the GitHub version last week and found the result is a little bit different from the paper. I think it is because of the GitHub version has been reconstructed for easy understanding, so they are a little bit different. To reproduce the result, set rotation to 0 in init.m and run the OTB benchmark.
I hope this helps:
OTB result


feat(Datagrid): Checkbox view all button in panel

What will this achieve?
Adds view all button to checkboxes that surpasses 10 or more

https://user-images.githubusercontent.com/12755042/216653645-b0e10d69-acb7-4381-9322-087136949792.png

Just kidding. @matthewgallo reminded that this is actually done.


[BUG] Segmentation fault at 0x0000000000000000 in IO_Event_Selector_EPoll_Type_free

Witnessed another GC crash in production caused by io-event:
[BUG] Segmentation fault at 0x0000000000000000
ruby 3.4.0preview2 (2024-10-07 master 32c733f57b) +YJIT +PRISM [x86_64-linux]

-- C level backtrace information -------------------------------------------
/usr/local/ruby/lib/libruby.so.3.4(rb_print_backtrace+0x14) [0x79d035181f81] /tmp/ruby-build/ruby-3.4.0-preview2/vm_dump.c:822
/usr/local/ruby/lib/libruby.so.3.4(rb_vm_bugreport) /tmp/ruby-build/ruby-3.4.0-preview2/vm_dump.c:1151
/usr/local/ruby/lib/libruby.so.3.4(rb_bug_for_fatal_signal+0x104) [0x79d034f69794] /tmp/ruby-build/ruby-3.4.0-preview2/error.c:1107
/usr/local/ruby/lib/libruby.so.3.4(sigsegv+0x46) [0x79d0350c4ca6] /tmp/ruby-build/ruby-3.4.0-preview2/signal.c:930
/lib/x86_64-linux-gnu/libc.so.6(0x79d034a83520) [0x79d034a83520]
/artifacts/bundle/ruby/3.4.0+0/gems/io-event-1.7.1/lib/IO_Event.so(IO_Event_List_free+0x0) [0x79d0073f9294] ./io/event/selector/epoll.c:324
/artifacts/bundle/ruby/3.4.0+0/gems/io-event-1.7.1/lib/IO_Event.so(IO_Event_Selector_EPoll_Descriptor_free) ./io/event/selector/epoll.c:327
/artifacts/bundle/ruby/3.4.0+0/gems/io-event-1.7.1/lib/IO_Event.so(IO_Event_Selector_EPoll_Descriptor_free) (null):0
/artifacts/bundle/ruby/3.4.0+0/gems/io-event-1.7.1/lib/IO_Event.so(IO_Event_Array_free+0x2b) [0x79d0073f94a5] ./io/event/selector/array.h:55
/artifacts/bundle/ruby/3.4.0+0/gems/io-event-1.7.1/lib/IO_Event.so(IO_Event_Selector_EPoll_Type_free) ./io/event/selector/epoll.c:161
/usr/local/ruby/lib/libruby.so.3.4(RTYPEDDATA_TYPE+0x0) [0x79d034f8d8bf] /tmp/ruby-build/ruby-3.4.0-preview2/gc.c:1061
/usr/local/ruby/lib/libruby.so.3.4(rb_data_free) /tmp/ruby-build/ruby-3.4.0-preview2/gc.c:1062
/usr/local/ruby/lib/libruby.so.3.4(rb_gc_obj_free) /tmp/ruby-build/ruby-3.4.0-preview2/gc.c:1202
/usr/local/ruby/lib/libruby.so.3.4(gc_sweep_plane+0x207) [0x79d034f8e816] gc/default.c:3532
/usr/local/ruby/lib/libruby.so.3.4(gc_sweep_page) gc/default.c:3620
/usr/local/ruby/lib/libruby.so.3.4(gc_sweep_step) gc/default.c:3892
/usr/local/ruby/lib/libruby.so.3.4(gc_sweep_continue+0xb) [0x79d034f97cc3] gc/default.c:3979
/usr/local/ruby/lib/libruby.so.3.4(gc_continue) gc/default.c:2074
/usr/local/ruby/lib/libruby.so.3.4(heap_prepare+0x52) [0x79d034f9b31a] gc/default.c:2093
/usr/local/ruby/lib/libruby.so.3.4(heap_next_free_page) gc/default.c:2308
/usr/local/ruby/lib/libruby.so.3.4(newobj_cache_miss) gc/default.c:2416
/usr/local/ruby/lib/libruby.so.3.4(newobj_init+0x0) [0x79d034f9c8e5] gc/default.c:2440
/usr/local/ruby/lib/libruby.so.3.4(rb_gc_impl_new_obj) gc/default.c:2524
/usr/local/ruby/lib/libruby.so.3.4(newobj_of) /tmp/ruby-build/ruby-3.4.0-preview2/gc.c:891
/usr/local/ruby/lib/libruby.so.3.4(rb_wb_protected_newobj_of) /tmp/ruby-build/ruby-3.4.0-preview2/gc.c:918
/usr/local/ruby/lib/libruby.so.3.4(ec_ary_alloc_embed+0x18) [0x79d034ea1c50] /tmp/ruby-build/ruby-3.4.0-preview2/array.c:796
/usr/local/ruby/lib/libruby.so.3.4(ec_ary_new) /tmp/ruby-build/ruby-3.4.0-preview2/array.c:830
/usr/local/ruby/lib/libruby.so.3.4(rb_ec_ary_new_from_values) /tmp/ruby-build/ruby-3.4.0-preview2/array.c:849

Thanks, I think I saw this the other day too.

I've seen this twice now over the past week: https://github.com/socketry/async-http/actions/runs/11361403630/job/31601041660

It may be something wrong with this code:
https://github.com/socketry/io-event/blob/v1.7.1/ext/io/event/selector/epoll.c#L323-L328
Specifically this:
https://github.com/socketry/io-event/blob/v1.7.1/ext/io/event/selector/list.h#L54-L74

I wonder if only one of these is non-NULL:
	if (node->head && node->tail) {
		IO_Event_List_pop(node);
	}

Even if only one of them is non-NULL, not removing the list item would cause major problems.

From the core dump:
(gdb) f 8
#8  IO_Event_List_free (node=0x74736f685f747365) at ./io/event/selector/list.h:71
71	./io/event/selector/list.h: No such file or directory.
(gdb) p *node
Cannot access memory at address 0x74736f685f747365

Looks like node is garbage? Not sure.
Lots of arguments are optimized out so the dump is hard to inspect.
#11 IO_Event_Selector_EPoll_Type_free (_selector=0x79cf896750f0) at ./io/event/selector/epoll.c:161
161	./io/event/selector/epoll.c: No such file or directory.
(gdb) p ((struct IO_Event_Selector_EPoll *)_selector)->descriptors
$3 = {base = 0x79cef7d7a0d0, count = 1024, limit = 672, element_size = 40, element_initialize = 0x79d0073f9260 <IO_Event_Selector_EPoll_Descriptor_initialize>, element_free = 0x79d0073f9290 <IO_Event_Selector_EPoll_Descriptor_free>}

(gdb) p (struct IO_Event_Selector_EPoll_Descriptor)(((struct IO_Event_Selector_EPoll *)_selector)->descriptors->base[0])
$10 = {list = {head = 0x74736f685f747365, tail = 0x656e6e6f63223a22, type = 0x696e696c632d7372}, io =<PHONE_NUMBER>830537827, waiting_events = (IO_EVENT_READABLE | IO_EVENT_ERROR | IO_EVENT_EXIT | unknown: 0x2e796640),
  registered_events = (IO_EVENT_READABLE | IO_EVENT_PRIORITY | IO_EVENT_EXIT | unknown: 0x226d6f40)}

Seems like both pointers are invalid:
(gdb) p *(struct IO_Event_Selector_EPoll_Descriptor *)(0x74736f685f747365)
Cannot access memory at address 0x74736f685f747365
(gdb) p *(struct IO_Event_Selector_EPoll_Descriptor *)(0x656e6e6f63223a22)
Cannot access memory at address 0x656e6e6f63223a22

Perhaps they were already freed?

Thanks for the extra context.
One possibility I'm considering is that perhaps the Fiber that added itself to the list has been garbage collected without the stack unwinding. Then the fiber would not remove itself from the list, but the list node would become garbage.

Released in v1.7.2.


[plugin-svelte] upgrade svelte-hmr to 0.13.2, fix remote source support

Changes
Update to<EMAIL_ADDRESS>and adapt code to breaking changes in the new version.
This fixes support for svelte-hmr with source: "remote" option.
Without this fix, the Svelte plugin is using a given version of svelte-hmr (currently 0.12), but it pulls @latest from remote source. This can cause a mismatch between the versions of code transform that runs in Node, and the runtime that runs in the browser. The recent release of v0.13 of svelte-hmr created such a situation and revealed the bug.
See: https://github.com/rixo/svelte-hmr/issues/27#issuecomment-800142127
I have introduced an option to svelte-hmr, used in the Snowpack plugin in this PR, that makes the code transform write its current version to the runtime imports it adds to components code.
From all my tests, this approach seems to work, but there is still something strange in the logs:
[snowpack] import svelte@latest → https://pkg.snowpack.dev/svelte
[snowpack] import svelte-hmr@0.13.2@latest →<EMAIL_ADDRESS>
Snowpack stills try to fetch svelte-hmr@0.13.2@latest apparently, even if this seems to pull the expected 0.13.2 runtime, so there is no impact. (I have verified that if the import mentioned another version, that's what we get according the the logs, not latest.)
As a side note, while doing this, I detected that the Svelte plugin didn't work with pnpm because of the transitive svelte-hmr dependency. I've try all my might to find a solution to this but couldn't. All I can think of would be for the Svelte plugin to add a mount for its runtime, but that seems a heavy weight solution. Any pointer about how to fix this would be appreciated. In other plugins, pnpm support is generally fixed with the use of absolute path for the svelte-hmr runtime imports.
Testing
Manually tested that the plugin and HMR now work both with source: "remote" and without it.
Docs
This is a bug fix.

Thanks @rixo! I can take a look at that weird log that you're seeing

Thanks @rixo! I fixed the log issue here: 68df7237
Also a heads up that "remote" source is getting an upgrade, and will use npm instead of Skypack for streaming imports in the future (first landing in source: "remote-next", but the plan is for this to replace "remote" eventually). That should resolve a lot of these issues by bringing remote support closer to local.


Multithreaded queries modifying global upstreams state.

This should be fixed by implementing upstream queries in a queued fashion.
Bug #10

Lazy solution is to keep upstream objects global, upstream connections local


NEXT-38717 Disable delete for global number ranges Fixes #4978

1. Why is this change necessary?
Currently it is possible to delete 'Global' number ranges, it is however not possible to create them again. This means that if the "Product" number range gets deleted by an admin, the state of the system cannot be fixed (without manually fixing it in the database or...)
2. What does this change do, exactly?
Add a check that disables the delete button for Global number ranges. (Currently that is only 'Product')
3. Describe each step to reproduce the issue or behaviour.
Go to the Number Ranges settings page.
Check the delete button for Product number range.
4. Please link to the relevant issues (if any).
https://github.com/shopware/shopware/issues/4978
NEXT-38717
5. Checklist

[x] I have rebased my changes to remove merge conflicts
[x] I have written tests and verified that they fail without my change
[x] I have created a changelog file with all necessary information about my changes
[x] I have written or adjusted the documentation according to my changes
[x] This change has comments for package types, values, functions, and non-obvious lines of code
[x] I have read the contribution requirements and fulfill them.

Hi @runelaenen thanks for your contribution, we have the same ticket and the fix was merged already. I would love to close this one then.


IE 11 script error

Hi,
I got an error on only in IE (my test was on IE 11), it working well for Chrome and FreFox.
Error message :
[iFrameSizer][Host page: iFrameResizer0] [iFrame.onload] IFrame(iFrameResizer0) not found SCRIPT5007: Unable to get property 'firstRun' of undefined or null reference File: iframeResizer.min.js, Line: 8, Column: 7626
the error is located exactly here:
var b=P[w].firstRun
If you can have a look I will appreciate it.
PS: Thanks for your lib it's a very good tool !

Can you try that on the non min version.

Hey David,
with the non min version the error is there:
function checkReset(){ 			// Reduce scope of firstRun to function, because IE8's JS execution 			// context stack is borked and this value gets externally 			// changed midway through running this function!!! 			var 				firstRun           = settings[iframeId].firstRun,
the value for iframeId is for example "iFrameResizer4"
but in settings there is only the  iFrameResizer5.
so IE throws 'Unable to get property 'firstRun' of undefined or null reference'
Thanks

Strange do you have a link I could look at

I have the same issue but on IE 10


Update tankix to 532

After making all changes to the cask:

[x] brew cask audit --download {{cask_file}} is error-free.
[x] brew cask style --fix {{cask_file}} left no offenses.
[x] The commit message includes the cask’s name and version.

Verified locally, since Travis is taking too long.


add LICENSE-* to sub-crates

Signed-off-by: Igor Gnatenko<EMAIL_ADDRESS>

Closing due to inactivity. Feel free to reopen if you're still interested!


Update minimum GPU requirements

Description

Checklist

[x] I am familiar with the Contributing Guidelines.
[x] New or existing tests cover these changes.
[x] The documentation is up to date with these changes.

Closing in favor of #75


Can't install plugin

Hey I'm using Packer and I can't seem to install this plguin I get this error:
 ✗ Failed to install saadparwaizl/cmp_luasnip
  Errors:
    Cloning into '/home/dan/.local/share/nvim/site/pack/packer/start/cmp_luasnip'...
    fatal: could not read Username for 'https://github.com': terminal prompts disabled

Not really sure whats going on here I have my github ssh key set up correctly as about 20 other plugins have no problem installing.
I have been following this tutorial https://www.youtube.com/watch?v=ub0REXjhpmk but fail in installing this plugin.

I think you have a typo in the repo name it's saadparwaiz1/cmp_luasnip not saadparwaizl/cmp_luasnip

Haha! Thanks I should type less!


Attribute name cannot be emptied in custom attributes

[Build] 16.1 fix3 18.11.2016
[Steps to reproduce]

As supplier go to Account/Manage attributes
Enter a new attribute for customers or subscriptions
For attribute enter all fields and save
Edit this  attribute; empty attribute name and save

[Expected result]
attribute name is emptied
[Observed result]
nothing happens (old value stays)

This was fixed and merged together with issue #443.

[Build] 16.1 fix4
not fixed

Fixed. Locale strings for the attribute names are now deleted if a null value or an empty string is the input.

[Build]16.1. fix6 verified


⚠ Secret Website 3 has degraded performance

In 4ff69b2, Secret Website 3 ($SECRET_WEBSITE_3) experienced degraded performance:

HTTP code: 200
Response time: 2012 ms

Resolved: Secret Website 3 performance has improved in fe5579a.


Safari compatibility on Mac & iOS

I haven't been able to get the pathtracer to work at all in Safari on Mac or iOS, both updated to the latest versions as of today. Everything works fine on Chrome. The problem occurs whether I'm using the Github hosted demos or from a local server.
One clue is the black "Loading" page does appear, however it fails just before the loading percentage begins.
This problem does not occur with the "skinned geometry support" or "morph target support" demo's. All other demos cause the error:
A problem repeatedly occurred with "https://gkjohnson.github.io/three-gpu-pathtracer/example/bundle/basic.html"
[Reload Webpage]
Because of the nature of the error it results in no page loading into the tab and therefore no way that I know of to look for errors.
Mac is a MacBook Pro 16" M1 and the phone is a 14 Pro.

See https://github.com/gkjohnson/three-gpu-pathtracer/issues/441#issuecomment-1610640494

Fixed in #483


About insert and unresolved identifiers

Hello there,
I'm just trying to use SQLite.swift doing this:
-I created a DB with sqlitebrowser
-I put the file created in the root folder in my project
-I'm loading the db like this:
let path = NSSearchPathForDirectoriesInDomains(
.DocumentDirectory, .UserDomainMask, true
).first as String
let db = Database("(path)/db.sqlite3")
personDb = db["person"]
-I'm trying to insert values like this:
if let insertID = personDb.insert(name <- personName.text, email <-<EMAIL_ADDRESS>hourlySalaray <- 14.0, minWeekHours <- minHours.text.toInt()!, maxWeekHours <- maxHours.text.toInt()!, maxDailyHours <- maxDailyHours.text.toInt()!, isSupervisor <- isSupervisor.on)  {
        println("Inserted: \(insertID)")

    }

But XCode continues telling me "Use of unresolved identifier X" about "name, email, hourlySalaray..." and all the fields that are in my DB and in my person table.
I'm using the latest version of XCode with all the Libraries loaded correctly following the steps mentioned in the instructions.
I would be more than happy to use this project if I can solve this issue.
Thank you very much!
Regards

Yes stephen, I was not using the Expressions correctly :)


Release schedule

Regular releases
I've thought a bit about release planning and would like to propose that we follow a fixed regular release schedule. I believe this comes with a number of benefits:

Having regular releases forces us to focus stronger on what is important for the next release
Releases are a good indicator of progress
Regular releases can increase community engagement
Regular releases decrease risk of failure and disappointment

There's a lot written on this topic and I think the general consensus is that regular releases are a good thing and result in better software.
A monthly schedule
So, I went on thinking about how regular we might want to ship a new release. My current thinking is that every month would make a nice target. Anything more frequent might be prone to fail especially with a team as small as hours. A release every two weeks might get easily disrupted by holidays etc whereas a release every months sounds doable on a consistent basis.
Release naming scheme
This had me thinking about a release naming scheme. Of course we are going to follow semver but it might be nice to give each release a name just liking Ubuntu does (e.g. Ubuntu 20.10 Groovy Gorilla). Trinity does the same and each release highlights a woman in science.
One thing that resonates with me is trying to connect to our name Fe. There are more than 5000 known minerals in the word that might make good use for release names. We could even combine that with the months of the release and arrive at something like:

January Jade
February Ferrum
March Minium
April Amethyst
...

We could also just follow the alphabet instead of matching the first letter of the months. I just like the idea of using minerals as release names. Wikipedia has a good sorted list of minerals: https://en.wikipedia.org/wiki/List_of_minerals
Release planning
We can create milestones for every release of the year ahead of schedule but we should at a minimum always have the milestone for the upcoming release and the one after that on GitHub. That is so that we can move issues from one release to the next if the window is closing and we realize an issue has to be moved to the next milestone.
At the beginning of each months we spend some time to assign issues to the upcoming release miestone. This will help us to increase focus on what is important to achieve next.
Semver
We are expected to follow semver. While semver allows to stick to a version like 0.1.0 and only increase a pre-release suffix e.g. 0.1.0-alpha.1, 0.1.0-alpha.2, 0.1.0-alpha.3 I'm personally not a fan because semver defines everything to the righthand side of the dash as just meaningless alphanumeric text. It could also be 0.1.0-y7pRR.8.3.J. Therefore, I suggest we use the individual components of the semver scheme right from the beginning and just attach -alpha to it until things stabilize. So releases would look like 0.1.0-alpha, 0.2.0-alpha, 0.2.1-alpha. Both are valid uses of semver but I like the latter approach a whole lot more.

Let me summarize what we discussed offline. We are going with monthly releases, picking release names with names from minerals starting with A, and going through the alphabet. According to that I will rename the milestone for our first release to January Release: 0.1.0 Amethyst

I've also changed the February mineral to something starting with a "B".
https://en.wikipedia.org/wiki/Borax

Ah yes, thanks.

We've been following this release schedule for a while now. Closing.


feat!: apply the changes of lbm-sdk and ostracon proto

Description

apply the changes of https://github.com/line/lbm-sdk/pull/869 and  https://github.com/line/lbm-sdk/pull/887
base lbm-sdk commit hash: b8864730859710d92a83f9f91289d4c6aef658cd

Main changes

Remove Ostracon protobuf struct and message which same with Tendermint
VRF Proof move from block.header to Entropy in Block structure

warning

RequestBeginBlock, RequestBeginRecheckTx and RequestEndRecheckTx of abci proto are Ostracon's proto, so these should be use ostracon import(github.com/line/ostracon/abci/types)

Motivation and context

How has this been tested?

Screenshots (if appropriate):
Checklist:

[x] I followed the contributing guidelines and code of conduct.
[x] I have added a relevant changelog to CHANGELOG.md
[ ] I have added tests to cover my changes.
[ ] I have updated the documentation accordingly.
[x] I have updated API documentation client/docs/swagger-ui/swagger.yaml

LGTM
There seems to be no difference with the tendermint light client.

Yes, that's right. But we don't use right now. Because some structure is same struct with Tendermint, but we use Ostracon's structure. So the compiler recognize as different object.
So I think it's better that we need to replace to use Tendermint's structure in Ostracon if same.


Not possible to specify controller when fragment is included in declarative way

Currently it is possible set fragment controller when instantiate fragment programmatically, like this:
sap.ui.jsfragment("{someFragment}",{controllerInsance});
But we can't specify controller, when we include fragment declaratively:
<core:Fragment fragmentName="{fragmentName}"  type="XML"/>
I think it will be nice, if we can specify controller via "controllerName" attribute exactly like we do in <mvc:View controllerName="{controllerName}"..> in views.

But isn't then a view the better choice?

In different scenarios we should be free to attach different controllers declaratively.

For Views, I agree, for fragments I don't.
The possibility to provide a controller to a fragment on construction was meant to allow exactly the same that can be done declaratively: a fragment inherits the controller from its containing view. In controller or helper code, the view might not be known to the framework, so we allowed to pass the right controller.
Giving fragments a controller of their own makes them more complex (e.g. it raises the need for lifecycle hooks) and makes them more like views.
So why not use views instead?

You are right. It can be handled by putting the fragment it in a dummy view, which will include the fragment. I am closing the issue. Thank you, Frank.

@codeworrior Coming from Angular I'm used to compose views with different reusable components where I have a clear separation between the template and the logic. How can we achieve the same with UI5? For fragments we can't define the controller declaratively and custom controls don't support templates AFAIK.

https://sapui5.hana.ondemand.com/sdk/#/api/sap.ui.core.XMLComposite looks promising


The best speed performance

Which framework in DeepSpeed has the best speed performance, and is there anything faster than DeepSpeed?

@zhoumengbo - this depends on a lot of factors, are you asking about training or inference?  Available hardware?  Model size?
Overall, I'd recommend reading more about deepspeed here, to get a sense of the features provided (Zero, Inference, DeepSpeed-Chat, etc) and what might apply to your situation.


simplified NJKScrollFullScreen

Hi, your NJKScrollFullScreen is great!, I have spend months looking for a simplified lib to hide navBar & tabBar when scroll. it can be much simplified if add an automatic execution to instead of ViewController delegate, I mark the additional code with warning msg place, it will not change the way to use by your README description. I have tested the code I changed, it only need 3 line code to use  NJKScrollFullScreen. so may I pull request to you? thx!

in my UITableViewController.m
just add below 4 lines code and NJKScrollFullScreen work well:
self.edgesForExtendedLayout = UIRectEdgeAll;
self.extendedLayoutIncludesOpaqueBars = YES;
_scrollProxy = [[NJKScrollFullScreen alloc] initWithForwardTarget:self];
self.tableView.delegate = (id)_scrollProxy;


README should include instructions to run the heroicon installer

rails g heroicon:install

Thanks for the suggestion. The README currently mentions the need to install and setup Tailwind, SimpleForm, and the heroicons gem, all of which have their own generators that need to be ran, but it's probably easy to miss heroicons out of the three


jsonConcat assumes array

When merging, jsonConcat invokes push on an entity of type Object (e.g. {text: 'Section One'}), but push is a function of Array.

I'm assuming this is no longer an issue. Please re-open when necessary.


Custom guard issue in ver 6

Laravel Version: 6.0.3
PHP Version: 7.2.13
Database Driver & Version: MariaDB, 10.3.11

Description:
Hi,
I have decided to create a custom guard in my app and when trying to login, it throws BadMethodCallException: Method Illuminate\Auth\RequestGuard::attempt does not exist
I followed what the doc says here: https://laravel.com/docs/6.x/authentication
Steps To Reproduce:
1-install a new Laravel 6,
2- Create a custom guard "api" to store data in different table.
3-Attempt to login user , it throws above error.

https://github.com/mtvbrianking/multi-auth

Hey there,
Can you first please try one of the support channels below? If you can actually identify this as a bug, feel free to report back and I'll gladly help you out and re-open this issue.

Laracasts Forums
Laravel.io Forums
StackOverflow
Discord
Larachat
IRC

Thanks!

@driesvints I did that Sir!
had to hack it finally! Auth Facade dose not expect us to use it for a custom api guard! . and that's why it throws error on  attempt method.


Help request: how to store attributes against a specific websocket

I've written this minimal server based on examples/multicast.rb
require 'em-websocket'

EventMachine.run {
  @channel = EventMachine::Channel.new

  EM::WebSocket.start(:host => "<IP_ADDRESS>", :port => 8080) do |ws|
    ws.onopen { |handshake|
      sid = @channel.subscribe { |msg| ws.send msg }
      puts "WebSocket connection open"
      ws.send "Hello Client, you connected to #{handshake.path}"
    }

    ws.onclose {
      puts "Connection closed"
      @channel.unsubscribe(sid)
    }

    ws.onmessage { |msg|
      puts msg
      @channel.push "<#{sid}>: #{msg}"
    }
  end
}

However, this errors on the first message sent from a socket, because the sid attribute doesn't persist between onopen and onmessage.
server.rb:24:in `block (3 levels) in <main>': undefined local variable or method `sid' for main:Object (NameError)

If I create the attribute as an instance variable, the second socket opened overrides @sid for the first.
It looks, from the example, like it was expected to persist between blocks, in the scope of a single web socket. Does anyone know how I can set a variable within this scope?

I found the solution, and I could kick myself for raising the issue. Just in case anyone finds this here's what the problem was.
The local variables will persist if the onclose and onmessage events are set within the onopen block.
e.g.
require 'em-websocket'

EventMachine.run {
  @channel = EventMachine::Channel.new

  EM::WebSocket.start(:host => "<IP_ADDRESS>", :port => 8080) do |ws|
    ws.onopen { |handshake|
      sid = @channel.subscribe { |msg| ws.send msg }
      puts "WebSocket connection open"
      ws.send "Hello Client, you connected"

      ws.onclose {
        puts "Connection closed"
        @channel.unsubscribe(sid)
      }

      ws.onmessage { |msg|
        puts msg
        @channel.push "<#{sid}>: #{msg}"
      }
    }
  end
}

This script will send any message by any open websocket out to every websocket which is currently connected.


Added performance measurements images

Coverage increased (+0.02%) to 75.644% when pulling 18e8aa920bd3bc99148f9b2efee2dbaa9f537319 on amarcine:master into 5ff9fd3d74acca3eca968eda1cc7142253817a8c on contiv:master.


Investigate use of the OpenAlex API for discovering related works

Investigate whether we can use the OpenAlex API to discover related works for a DMP. It looks like it is more focused on Publications rather than Datasets.
OpenAlex API docs
If viable, we can build out a Lambda that calls the API and then a Lambda that can be run to schedule the calls to OpenAlex.

On hold since OpenAlex is part of the information available within the COKI Observatory Network system. See issue #77

closing this one as it will be part of our work with COKI #77


[BUG] Deprecation Warning - from moment.js when using time axes

Expected Behavior

Current Behavior
Deprecation warning: value provided is not in a recognized RFC2822 or ISO format. moment construction falls back to js Date(), which is not reliable across all browsers and versions. Non RFC2822/ISO date formats are discouraged and will be removed in an upcoming major release. Please refer to http://momentjs.com/guides/#/warnings/js-date/ for more info.
Arguments:
[0] _isAMomentObject: true, _isUTC: false, _useUTC: false, _l: undefined, _i: 2018.01.01, _f: undefined, _strict: undefined, _locale: [object Object]
Error
    at Function.createFromInputFallback (http://<IP_ADDRESS>:8000/static/documerge/node_modules/moment/moment.js?v=1523389320944:320:98)
    at configFromString (http://<IP_ADDRESS>:8000/static/documerge/node_modules/moment/moment.js?v=1523389320944:2368:15)
    at configFromInput (http://<IP_ADDRESS>:8000/static/documerge/node_modules/moment/moment.js?v=1523389320944:2594:13)
    at prepareConfig (http://<IP_ADDRESS>:8000/static/documerge/node_modules/moment/moment.js?v=1523389320944:2577:13)
    at createFromConfig (http://<IP_ADDRESS>:8000/static/documerge/node_modules/moment/moment.js?v=1523389320944:2544:44)
    at createLocalOrUTC (http://<IP_ADDRESS>:8000/static/documerge/node_modules/moment/moment.js?v=1523389320944:2631:16)
    at createLocal (http://<IP_ADDRESS>:8000/static/documerge/node_modules/moment/moment.js?v=1523389320944:2635:16)
    at hooks (http://<IP_ADDRESS>:8000/static/documerge/node_modules/moment/moment.js?v=1523389320944:12:29)
    at momentify (http://<IP_ADDRESS>:8000/static/documerge/node_modules/chart.js/dist/Chart.js?v=1523389320944:13795:11)
    at parse (http://<IP_ADDRESS>:8000/static/documerge/node_modules/chart.js/dist/Chart.js?v=1523389320944:13817:14)
warn @ moment.js?v=1523389320944:293
(anonymous) @ moment.js?v=1523389320944:320
configFromString @ moment.js?v=1523389320944:2368
configFromInput @ moment.js?v=1523389320944:2594
prepareConfig @ moment.js?v=1523389320944:2577
createFromConfig @ moment.js?v=1523389320944:2544
createLocalOrUTC @ moment.js?v=1523389320944:2631
createLocal @ moment.js?v=1523389320944:2635
hooks @ moment.js?v=1523389320944:12
momentify @ Chart.js?v=1523389320944:13795
parse @ Chart.js?v=1523389320944:13817
determineDataLimits @ Chart.js?v=1523389320944:14149
update @ Chart.js?v=1523389320944:7230
update @ Chart.js?v=1523389320944:14109
getMinimumBoxSize @ Chart.js?v=1523389320944:6416
each @ Chart.js?v=1523389320944:9899
update @ Chart.js?v=1523389320944:6430
updateLayout @ Chart.js?v=1523389320944:4259
update @ Chart.js?v=1523389320944:4214
construct @ Chart.js?v=1523389320944:3944
Chart @ Chart.js?v=1523389320944:6215

Possible Solution
Moment.js might deprecate the functionality. Unless provided date format along with date. like moment(value, format) in #13795 form the above screenshot
Steps to Reproduce (for bugs)

Configure to time axis

{
type: "line",
data: {
            // labels: ["Used", "Remaining"],
            datasets: [{
                label: 'Test Merges',
                xAxisID: "time",
                fill: true,
                lineTension: 0,
                data: [
                    {x: '01-01-2018', y:10},
                    {x: '02-01-2018', y:5},
                    {x: '02-05-2018', y:15}
                ]
            }]
        },
config: {
            scales: {
               xAxes: [{
                    id: 'time',
                    type: 'time',
                    time: {
                        tooltipFormat: "DD MMMM, YYYY"
                    }
                }]
            }
        };
    }
}

Environment

Chart.js version: "^2.7.2",
Chrome 65.0.3325.181

I think a try ... catch here would be an important performance hit since it's called very often (I already removed exception handling for color parsing). What moment recommend as alternative for this deprecation?

As mentioned in the Issue description, format needs to be passed long with value. As they are not supposed to assume a date format for the value being passed, as per the RFC2822 or ISO format.
///So,
moment(value); //moment("04-12-2018");
//must be changed to
moment(value, format); //moment("04-12-2018", "MM-DD-YYYY");

That's line 13791 and if Chart.js users didn't provide a format, then we still need to fallback to moment(value) so we can't just drop support for moment(value) until next major release.

maybe we can just assume ISO8601 .... it makes the deprecation warning go away but it doesn't necessarily solve the problem


fix(intersection): fix unsigned subtraction

Description
Fixed the error caused by unsigned subtraction
Related links

Tests performed
https://evaluation.tier4.jp/evaluation/reports/1b310650-c475-5c8d-a468-a5b5c3a701cc?project_id=prd_jt
Notes for reviewers
none.
Interface changes
none.
Effects on system behavior
none.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.

[X] I've confirmed the contribution guidelines.
[X] The PR follows the pull request guidelines.

In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.

[X] The PR follows the pull request guidelines.
[X] The PR has been properly tested.
[X] The PR has been reviewed by the code owners.

Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.

[X] There are no open discussions or they are tracked via tickets.
[X] The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

This PR fixes https://github.com/autowarefoundation/autoware.universe/pull/5264


Update backends.py

Use USERNAME_FIELD instead of username for custom user model, otherwise it will cause problems for custom user model without the field.

Thank you for the fix.


php-fpm is not installed when using 'gitpodlatest' for the PHP version in starter.ini

Describe the bug

When using the existing installation of PHP in gitpod/workspace-mysql, php-fpm is not installed so PHP does not work with nginx out of the box. This breaks the demo flow when nginx is the default server (which currently is the default in starter.ini).
Screenshots

Steps to reproduce

ensure docker image layer cache is busted
run a gitpod-laravel-starter with 'gitpodlatest' set for the PHP version in starter.ini

Expected behavior

Ideally php-fpm would be installed as part of gitpod/workspace-mysql. There is a question there in a PR that rasies this thought.
At a minimum php-fpm must be installed in php.sh when the existing Gitpod installation of PHP is left as-is.
This will of course need to be removed if Gitpod decides to includes php-fpm in gitpod/workspace-mysql
We could sniff for the php-fpm installation and act accordingly but I would rather not introduce that complexity.
Additional information

I decided to go with sniffing out the php-fpm install and dynamically installing it if it wasn't already installed.

depends on https://github.com/apolopena/gitpod-laravel-starter/issues/204


Code Action provider

Add a code action provider (light bulb feature) to add imports that are not actually imported

Possible usage:

[ ] Test

for the refactorings: there will be an own issue.


docs: update variable descriptions

Description
Make descriptions consistent. Some style and grammar updates.
Check the relevant boxes:

[ ] Bug fix (nonbreaking change that fixes an issue)
[ ] New feature (nonbreaking change that adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Examples or tests (addition or updates of examples or tests)
[x] Documentation update
[ ] CI related update (pipeline, etc.)

Checklist

[ ] If relevant, a test for the change has been added or updated as part of this PR.
[ ] If relevant, documentation for the change has been added or updated as part of this PR.

Merge

Merge using "Squash and merge".
Make sure to use a relevant conventional commit message that is based on the PR contents. The commit message determines whether a new version of the modules needs to be released, and if so, which semver number to use).

@SirSpidey I think you have an old version of common-dev-assets here. Can you run git submodule update and commit + push?

@ocofaigh I had to run git submodule update --remote --merge to get any change to show up because I had already updated the submodule with the other command. Not sure if that's going to fix the issue or create new ones.

Seems to be issues pulling the docker image used by pipeline. Have seen it in a few places today. Have restarted the pipeline to see if it works this time

Closing this PR because I want to review the descriptions in related modules.


Landscape view does not show camera feed

The camera feed shows in portrait mode, but when you flip the device to landscape mode then the camera feed disappears. This seems similar to the following issue: https://github.com/gdombiak/OctoPod/issues/414
OS: iOS/iPadOS 15.4.1
Devices: iPhone 12 Pro and iPad Mini 6
Reproduction Steps:

Go to Panel Tab
Place device in portrait mode (camera feed is visible)
Turn device to landscape mode (camera feed disappears while the print job status is scrolled upstairs and pushes camera feed out of window)
Turn device back to portrait mode (camera feed reappears)

Hi @ShodaPublicity,
Thanks for reporting this. The behavior you described is expected on the iPhone due to a small screen when in landscape. However, this is not ok for the iPad Mini that has a way bigger screen. I will add support for the iPad Mini for the next release.
Thanks,
Gaston


Normalize geometry when querying

When wraparound is enabled on a map, the coordinates returned on tap are different when the map has been wrapped around. Because of this, panning the map and attempting to do a query will result in service exceptions.
Using the geometry engine to normalize the coordinates will prevent errors.
This only applies to situations where wraparound is enabled. Because of that, I chose to explicitly check if it is enabled, even though that is the default. That was a didactic decision rather than a practical one, but I think it is important for clarity. I did choose to put the condition check and normalization on one line;  this may be controversial, but I didn't want to divert emphasis from the intention of the sample.

@dkemlage Can you please take a look at this? The errors caused by this behavior are unlikely to be encountered in the general operation of the samples. However, it was important to get this in because the Runtime behavior isn't intuitive and we don't document this anywhere else.

Thanks for the review! :)