react-scripts package.json pulls in webpack-dev-server v3.2.1 which has a vulnerable version of jquery bundled

Describe the bug
The package.json for react-scripts pulls in version 3.2.1 of webpack-dev-server.  In the /client directory of webpack-dev-server (in the node_modules under react-scripts) there is a file called live.bundle.js that includes v3.3.1 of jquery.  OWASP Dependency Checker flags this version of jquery with CVE-2019-11358 because versions before 3.4.0 of jquery have a vulnerability.
Steps to reproduce
Use create-react-app.  That brings in the vulnerable dependency.
Expected behavior
Would prefer that package.json of react-scripts brings in a later version of webpack-dev-server such as 3.7.2.  In that version, the live.bundle.js brings in the v3.4.1 version of jquery which is not vulnerable based on the CVE above.  This should fix it for us and not give us a medium level vulnerability.
Actual behavior
See description above.  Please advise on when this can be fixed.  Thanks, Mike

Did you try recovering your dependencies? We depend on webpack-dev-server 3.2.1, which depends on jquery ^3.2.1, which will resolve to the latest 3.x minor. It's annoying, but there's not much we can do on our end.

Since webpack-dev-server only runs during development this is actually not a real vulnerability. But if you do really care about it you can force it to resolve a certain version by using yarn's resolutions.

To answer heyimalex, I've tried multiple methods of doing that including deleting my node_modules and also getting rid of the global cache and letting him build that from scratch.  It always insists on bringing in exactly 3.2.1 and not 3.4.1.  I can cause a top level webpack-dev-server to be the version I want but the one under /node_modules/react-scripts/node_modules will always be 3.2.1.  Surgical npm updates don't help.
To answer rovansteen, on that subject of only during development, I tried moving react-scripts to a dev dependency but so many things broke on the npm install that I gave up (after spending days on it).  I notice all the examples and instructions point to having react-scripts as a prod dependency.  Should react-scripts work as a dev dependency?  If so, should I try again and report the issues I found when I try that?  Alternatively, should react-scripts bring in webpack-dev-server as a dev dependency instead of prod as it is doing now?

See https://github.com/facebook/create-react-app/issues/1764 about the reason create-react-app does not use devDependencies. What I mean is that the so called vulnerability never runs in production because webpack-dev-server only runs when you are developing, so there is no reason to worry about it.

#1764 convinced me more that react-scripts should include webpack-dev-server as a dev dependency.  Not sure why it mistakenly includes it as a prod dependency.  Also, the explanation that a vulnerability is not a vulnerability because it doesn't get run in production doesn't work with security/compliance/risk/audit folks.  If the file is deployed with the production code, it is there.  With the large compliance penalties in the news, we can't really take a chance so we are forced into yarn if we want to be compliant with regulations in the US and around the world.
However, it sounds like the solution to quite a few problems with create react app is to use yarn.  Is there a statement somewhere in the documentation saying you must use yarn with create react app?      Should I put in an issue on the documentation for this?  It would seem that if your solution for compliance is yarn, that should be specified very clearly in all documentation one could read about using create react app, quick start guides, etc...  Alternatively, you could increase the version dependency in the react-scripts package.json on webpack-dev-server to point to the 3.7.2 version of webpack-dev-server instead of 3.2.1.  Is there some reason why that is not an acceptable solution?  Are there too many breaking changes in that higher version?

@mecorusf webpack dev server 3.2.1 isn’t “vulnerable”, jquery 3.2.1 is. Is that version of jquery always being pulled when you re-install? When you removed node modules did you also delete yarn.lock and/or package-lock.json before reinstalling?

The problem is not about bumping a dependency, the problem is that a lot of these so called vulnerabilities have been popping up lately and we are not always in a position to update all of these dependencies. Some of them might be tied to other dependency constraints which contain breaking changes, which needs to be tested etc.
I fail to understand the security issue here. Unless you pull in that version of jQuery in your own code it won't be in your bundle thus the code won't run anywhere. But if that somehow is still an issue you can always build your bundle on a non-production server or remove node_modules after building.

@rovansteen Eh, I’m sympathetic to people with draconian IT policies. If this was bugging a ton of people, ie npm audit warned on fresh installs, I would try and get the dependency upgraded quickly just to make beginner ux nicer. But as it stands there’s nothing we can do; we’re literally not depending on a vulnerable version of jquery.

I agree with you about the user experience, you want to be able to start or install a new create-react-app without any warnings. But I also think it is good to educate people what these vulnerability warnings actually mean.

"But as it stands there’s nothing we can do; we’re literally not depending on a vulnerable version of jquery."  I'll answer all the posts above soon but I'd like to address this one.  In your package.json in /react-scripts, you specifically call out webpack-dev-server v3.2.1 (instead of a later version that is available).  webpack-dev-server v3.2.1 has jquery in it's live.bundle.js.  It also calls it out in its package.json.  I can report that on the webpack-dev-server list but they have already fixed it in their later release and that will be their answer.  More later...

Your opinion that it is not a vulnerability is not shared by security experts.  Also, the "the code is not used" argument is not a valid argument from a security or hacking point of view.
However, thank you for providing a couple of good options.  We can certainly do some post-processing on the node_modules directory even though that is not ideal and will require a bit of extra work for all the projects.  But the better answer is that there is hope for a fix in the future.    Note that there is already a better version of webpack-dev-server available right now!  That is version 3.7.2 (available now).  And if you were to fix the package.json in /react-scripts to point to that already-fixed version, it would simplify things for people who are required to be in compliance with various regulations.
In addition, I have verified that I can use yarn to force the resolution but it does cause some other warnings that I will have to investigate.  More later.  Thanks, Mike

I've verified I can fix this with yarn.  I added this to the package.json:
"resolutions": {
"webpack-dev-server": "^3.7.2"
},
It got warnings about peer dependencies needing to be at a higher version for webpack but doesn't appear to cause any issues.  It will be a reasonable workaround until #7259 updates the dependency on webpack-dev-server.
Thanks for sticking with me and helping me to come to a solution.


taskserver: 1.0.0 -> 1.1.0

Test build succeeded on my machine.
Not test-run, though.
Also required for my work on #7771

Great, thanks!


Point instead of GeoPoint?

Within the function names Point is now synonymous with lat/lon. It feels a little redundant to me to then use GeoPoint for the lat/lon data type. Maybe it should just be Point?
Originally posted by @sahrk in https://github.com/uber/h3/issues/403#issuecomment-730844967

One issue with this is that to anyone from a geoinformatics or GIS background, a Point is represented as [X,Y], which translates to [longitude,latitude]. It's confusing enough that H3 currently represents it's points as [Y,X] / [latitude,longitude]; changing the name to Point would remove the current naming differentiation between the way points are represented in H3 vs virtually every other geometry package (GeoJSON, WKT, etc).
I'd really like to see this fixed internally in H3, so it uses [X,Y] / [longitude,latitude] ordering like every other major geographical package, but it would be a confusing and breaking change for much existing code.
At the least, it'd be nice to have a pretty big warning in the documentation that GeoPoints (and all other coordinate ordering) is the non-standard [Y,X]/[latitude,longitude]

One issue with this is that to anyone from a geoinformatics or GIS background, a Point is represented as [X,Y], which translates to [longitude,latitude].

But (lat, lon) are polar coordinates, not cartesian coordinates, and in polar coordinates the polar angle is given before the azimuthal angle. We sometimes find it convenient to treat them as if they are cartesian coordinates, which I suppose led to the convention of changing the order. But with the exception of that representation convention geographic coordinates are always referred to as "latitude, longitude". For example, I just looked up a ship at vesselfinder.com and it gives the latitude first, not the longitude.

It's confusing enough that H3 currently represents it's points as [Y,X] / [latitude,longitude]; changing the name to Point would remove the current naming differentiation between the way points are represented in H3 vs virtually every other geometry package (GeoJSON, WKT, etc).

H3 represents cartesian (x, y) coordinates using the Vec2D structure. It is unrelated to GeoPoint, and stores the components in x, y order.
I do agree that, though geographic coordinates are the only kind of point used by the API, the term Point is too ambiguous. Rather than changing GeoPoint to Point, it might be better to use GeoPoint throughout (which would require changing function names).

But (lat, lon) are polar coordinates, not cartesian coordinates, and in polar coordinates the polar angle is given before the azimuthal angle. We sometimes find it convenient to treat them as if they are cartesian coordinates, which I suppose led to the convention of changing the order
You're of course correct that it's standard, in geography, to correctly list latitude/longitude pairs in [Y,X]; I believe the origin of the [X,Y] standard for geoinformatics was the OGC spec for WKT, considering that WKT is designed to represent any multi-coordinate system, and longitude counts left to right, while latitude counts bottom to top;
when translated to x/y this means the Longitude/Latitude approach made the most sense. Since then, GeoJSON and most other standards that use a Point type expect this ordering.

H3 represents cartesian (x, y) coordinates using the Vec2D structure. It is unrelated to GeoPoint, and stores the components in x, y order.
Apologies for being unclear; I meant internally in it's quasi-geojson formats.

What I have seen done that may be a good solution is to rename it to LatLngPoint; this makes the ordering explicit, and differentiates it from any other sort of [X,Y] point.

What I have seen done that may be a good solution is to rename it to LatLngPoint; this makes the ordering explicit, and differentiates it from any other sort of [X,Y] point.

I'd be in favor of this - perhaps just LatLng? If the current geoToH3 and h3ToGeo functions were called latLngToCell and cellToLatLng it would save us a great deal of user confusion I suspect.

What I have seen done that may be a good solution is to rename it to LatLngPoint; this makes the ordering explicit, and differentiates it from any other sort of [X,Y] point.

I'd be in favor of this - perhaps just LatLng? If the current geoToH3 and h3ToGeo functions were called latLngToCell and cellToLatLng it would save us a great deal of user confusion I suspect.

I'm partial to latLon, rather than latLng, but I think either would neatly solve all the issues. Thanks @lokkju !

linking to #121 - there is still nothing in the documentation about the datum and ellipsoid being used for latitude and longitude coordinate functions, and the only reference in code is a comment:
earth radius in kilometers using WGS84 authalic radius

+1 to the idea of explicitly stating latLng/latLon. This seems to be the clearest option by far.

I also like the explicitness of latlng/latLng/latlon/latLon; you might notice the camel case bugging me here, but that's a separate issue :)
More importantly, in terms of lon vs lng, we should probably pick one. A quick search shows that the codebase is currently inconsistent. Should we start an issue to settle it? Or a mini-RFC?

Also a +1 for LatLng (camelCase 4ever!). As for Lng vs Lon I personally prefer Lng. Implicit vowels works well enough that some languages are based on it. ;) While Lon reminds me of Lon Lon Ranch and I just can't take it seriously. That's not a good enough reason to actually go with one or the other, but I think this is entirely down to personal preferences as both are used in the wild.

linking to #121 - there is still nothing in the documentation about the datum and ellipsoid

The datum for H3 is a sphere with the WGS84 authalic radius. I agree that should be in the documentation.

Also a +1 for LatLng (camelCase 4ever!). As for Lng vs Lon I personally prefer Lng. Implicit vowels works well enough that some languages are based on it. ;) While Lon reminds me of Lon Lon Ranch and I just can't take it seriously. That's not a good enough reason to actually go with one or the other, but I think this is entirely down to personal preferences as both are used in the wild.

An argument for Lon: "latitude/longitude" is always abbreviated verbally as "lat/lon". Because of that GeoPoint uses lon for the longitude field. If we go with Lng then GeoPoint should probably also be changed for consistency.

When we have to write a mini-RFC to decide between lng and lon the naming discussion has jumped the shark :). I agree that we should be consistent. I have a slight preference for lng as retaining the ŋ phoneme, but we should just pick one.

I'm also in favor of lng.
So it sounds like the current summary is that we'll be renaming GeoPoint to latLng.

Here's a currently broken PR which shows the changes to the RFC and in h3api.h: https://github.com/uber/h3/pull/454


Reduced version of #366 (only init and interp_time)

Changes
Describe changes in this PR
Related Issues
Closes # (add issue numbers)
Checks

[ ] updated CHANGELOG.md
[ ] updated tests
[ ] updated doc/
[ ] update example/tutorial notebooks

Hello @vhirtham! Thanks for updating this PR.

In the file weldx/transformations/local_cs.py:

Line 105:36: F821 undefined name 'TimeSeries'
Line 164:36: F821 undefined name 'TimeSeries'
Line 207:61: F821 undefined name 'TimeSeries'
Line 219:17: F821 undefined name 'orientation'
Line 229:17: F821 undefined name 'orientation'
Line 251:9: F821 undefined name 'self'
Line 252:22: F821 undefined name 'self'
Line 252:40: F821 undefined name 'time_ref'
Line 253:13: F821 undefined name 'self'
Line 253:44: F821 undefined name 'time_ref'
Line 369:5: F811 redefinition of unused '_build_orientation' from line 116
Line 404:5: F811 redefinition of unused '_build_coordinates' from line 150

Think this can be closed and removed now?

Think this can be closed and removed now?

your call I guess 😉

Think this can be closed and removed now?

your call I guess 😉

You requested this PR to get a better overview. 😉 Just wanted to make sure you didn't have any other plans with it before I destroy it.


Could not run ID signatures

Hi Raviteja @rvangara
I was planning to repeat the ID signatures by running the SigProfilerAssignment, but met some problems. I tried the Analyze.cosmic_fit  with the context_type="ID" or context_type="83" , but these didn't work. I wonder what I should type in here.
The code and error message showed below:
>>> Analyze.cosmic_fit( samples,
...                     output,
...                     input_type="vcf",
...                     context_type="ID",
...                     genome_build="GRCh38",
...                     cosmic_version=3.3,
...                     verbose=False,
...                     make_plots=True,
...                     exclude_signature_subgroups=None,
...                     exome=False)
Starting matrix generation for SNVs and DINUCs...Completed! Elapsed time: 338.77 seconds.
Matrices generated for 10071 samples with 0 errors. Total of 2684788 SNVs, 19882 DINUCs, and 0 INDELs were successfully analyzed.
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/user/miniconda3/lib/python3.10/site-packages/SigProfilerAssignment/Analyzer.py", line 11, in cosmic_fit
    decomp.spa_analyze(samples=samples,  output=output, signatures=signatures, signature_database=signature_database,nnls_add_penalty=nnls_add_penalty, nnls_remove_penalty=nnls_remove_penalty, initial_remove_penalty=initial_remove_penalty,genome_build=genome_build, cosmic_version=cosmic_version, make_plots=make_plots, collapse_to_SBS96=collapse_to_SBS96,connected_sigs=connected_sigs, verbose=verbose,decompose_fit_option= False,denovo_refit_option=False,cosmic_fit_option=True,devopts=devopts,exclude_signature_subgroups=exclude_signature_subgroups,exome=exome,input_type=input_type,context_type=context_type,export_probabilities=export_probabilities, export_probabilities_per_mutation=export_probabilities_per_mutation, sample_reconstruction_plots=sample_reconstruction_plots)
  File "/home/user/miniconda3/lib/python3.10/site-packages/SigProfilerAssignment/decomposition.py", line 177, in spa_analyze
    genomes = data[vcf_context]
KeyError: 'ID'

Dear @MeteorLiu96,
Thanks for reaching out. As you can see in your output, your vcf files did not contain any indels (0 INDELs were successfully analyzed.), so that's the cause of this issue. Please try to use VCF files containing indels, and feel free to reopen the ticket if you still have any issues.
Best,
Marcos


chore: remove owlbot

In this PR:

Disable Owlbot and remove related files, please see go/disable-owlbot-java for more info.

Kokoro - Test: Integration Instance failed due to no corresponding build config:
Caused by: com.google.devtools.kokoro.controller.UserException: APPLICATION_ERROR;devtools.kokoro.executor.proto/KokoroExecutorWorker.ReadBuildConfig;no file found at path 'src/github/java-cloud-bom/.kokoro/presubmit/integration2' or with allowed extensions invalid argument;AppErrorCode=3;StartTimeMs=1724937711227;tcp;Deadline(sec)=300.0;ResFormat=uncompressed;interceptors={[com.google.frameworks.debug.sherlog.core.rpcutil.Stubby3ClientInterceptor];overrides={}};ServerTimeSec=6.01757E-4;LogBytes=256;FailFast;EffSecLevel=none;ReqFormat=uncompressed;ReqID=6ba3a50129dd64b0;GlobalID=0;Server=[2002:aa2:b4cb:0:b0:902:8952:16cc]:14003

This is irrelevant to the PR.

You can ignore Test Integration instance. It's testing for infrastructure.


Update box OS

Let's not use an unsupported OS anymore, yeah?

the provisioning script fails for me.
The SSH command responded with a non-zero exit status. Vagrant
assumes that this means the command failed. The output for this command
should be in the log above. Please read the output to determine what
went wrong.
Thijss-MBP:kong-vagrant thijs$

Whups, I had that associated change on a separate branch and couldn't remember if it was updated. Yeah we need to add -y to the redis install. Re-up'd with this change.

box builds now, but doesn't run:
Thijss-MBP:kong-vagrant thijs$ vagrant ssh
Welcome to Ubuntu 14.04.5 LTS (GNU/Linux 3.13.0-119-generic x86_64)

 * Documentation:  https://help.ubuntu.com/

  System information as of Thu May 18 19:10:28 UTC 2017

  System load:  0.28              Processes:           81
  Usage of /:   3.6% of 39.34GB   Users logged in:     0
  Memory usage: 12%               IP address for eth0: <IP_ADDRESS>
  Swap usage:   0%

  Graph this data and manage this system at:
    https://landscape.canonical.com/

  Get cloud support with Ubuntu Advantage Cloud Guest:
    http://www.ubuntu.com/business/services/cloud

0 packages can be updated.
0 updates are security updates.

New release '16.04.2 LTS' available.
Run 'do-release-upgrade' to upgrade to it.

vagrant@vagrant-ubuntu-trusty-64:~$ kong start
migrating core for database kong
core migrated up to: 2015-01-12-175310_skeleton
core migrated up to: 2015-01-12-175310_init_schema
core migrated up to: 2015-11-23-817313_nodes
core migrated up to: 2016-02-29-142793_ttls
core migrated up to: 2016-09-05-212515_retries
core migrated up to: 2016-09-16-141423_upstreams
core migrated up to: 2016-12-14-172100_move_ssl_certs_to_core
core migrated up to: 2016-11-11-151900_new_apis_router_1
core migrated up to: 2016-11-11-151900_new_apis_router_2
core migrated up to: 2016-11-11-151900_new_apis_router_3
core migrated up to: 2016-01-25-103600_unique_custom_id
core migrated up to: 2017-01-24-132600_upstream_timeouts
core migrated up to: 2017-01-24-132600_upstream_timeouts_2
migrating hmac-auth for database kong
hmac-auth migrated up to: 2015-09-16-132400_init_hmacauth
migrating rate-limiting for database kong
rate-limiting migrated up to: 2015-08-03-132400_init_ratelimiting
rate-limiting migrated up to: 2016-07-25-471385_ratelimiting_policies
migrating cors for database kong
cors migrated up to: 2017-03-14_multiple_orgins
migrating ip-restriction for database kong
ip-restriction migrated up to: 2016-05-24-remove-cache
migrating key-auth for database kong
key-auth migrated up to: 2015-07-31-172400_init_keyauth
migrating jwt for database kong
jwt migrated up to: 2015-06-09-jwt-auth
jwt migrated up to: 2016-03-07-jwt-alg
migrating galileo for database kong
galileo migrated up to: 2016-04-15_galileo-import-mashape-analytics
migrating oauth2 for database kong
oauth2 migrated up to: 2015-08-03-132400_init_oauth2
oauth2 migrated up to: 2016-07-15-oauth2_code_credential_id
oauth2 migrated up to: 2016-12-22-283949_serialize_redirect_uri
oauth2 migrated up to: 2016-09-19-oauth2_api_id
oauth2 migrated up to: 2016-12-15-set_global_credentials
migrating basic-auth for database kong
basic-auth migrated up to: 2015-08-03-132400_init_basicauth
basic-auth migrated up to: 2017-01-25-180400_unique_username
migrating response-ratelimiting for database kong
response-ratelimiting migrated up to: 2015-08-03-132400_init_response_ratelimiting
response-ratelimiting migrated up to: 2016-08-04-321512_response-rate-limiting_policies
migrating acl for database kong
acl migrated up to: 2015-08-25-841841_init_acl
32 migrations ran
Error: /usr/local/share/lua/5.1/kong/cmd/start.lua:23: nginx: [alert] mmap(MAP_ANON|MAP_SHARED, 134217728) failed (12: Cannot allocate memory)

  Run with --v (verbose) or --vv (debug) for more details
vagrant@vagrant-ubuntu-trusty-64:~$

I cannot reproduce this. Try increasing the amount of memory you give to the VM?

2048 works, but... only recently increased from 512 to 1024 (because Cassandra was added), and now even further...

Welp, cassandra's expensive :P we could not run cassandra by default? Or we can bump the memory. Or try reducing the default kong shm size. I'm a fan of either of the first two ideas. Memory's cheap. Let's use it :)

@Tieske ping :)

I think cassandra needs to remain because it is required for the kong test suite to run. Hence probably best to increase memory default, which I just did.


HDDS-8369. Decommissioning with rack aware placement policy does not replicate to correct rack.

What changes were proposed in this pull request?
Currently decommissioned node is also considered to determine rack which leads to undesired result causing wrong rack selection. Now we don't consider decommissioned node for rack aware policy algorithm.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-8369
How was this patch tested?
Verified in real test environment.

@ChenSammi , @siddhantsangwan Can you please help to review.

I think we should look at the difficulty of fixing https://issues.apache.org/jira/browse/HDDS-7226 before proceeding with this fix. It would be easy for other code areas to fall into a similar trap to this one, and ultimately we need to fix https://issues.apache.org/jira/browse/HDDS-7226 anyway.

Considering this is a two line fix, is there any harm in letting this go in and then take on HDDS-7226?

It needs a unit test, at least in the non legacy RM. I also think it just papers over a problem and we should fix it correctly by addressing HDDS-7226 and then adjusting the code to use usedNodes and excludedNodes correctly. If something changes in the topology, then it could end up returning the decommissioning node as we are no longer excluding it.
Fixing HDDS-7226 should not be difficult and it will give a more robust solution going forward.

Agreed, we need a UT at least. I am not sure how much work HDDS-7226 is going to be, and also Ashish mentioned we will need a follow up fix after HDDS-7226 to fix this specific issue. So we need to balance the short-term problem with the long-term fix.
Ashish can you discuss with Stephen and decide a path forward?

I also wonder about other scenarios. Eg, lets say we have 3 replicas, and one is unhealthy (scrubber found a problem with it, and marked it bad). Right now, when we make the call to the placement policy we will pass the 2 good nodes and the unhealthy replica node as excluded and ask for 1 new node - which is effectively the same as passing 2 good nodes and a decommission node, as it will still confuse the placement algorithm.
What we really need to do is pass used nodes as nodes 1 and 2, as they are going to stay, and pass the unhealthy replica node as excluded so we don't select that node for a new copy. But we need that other Jira implemented to have usedNodes working in the RackAwarePlacementPolicy.
So I think the fix here addresses a partial solution for a specific scenario, but leaves other parts unfixed.

@sodonnel , I have updated PR for just Legacy RM which will continue to use old interface without usedNodes.
New RM will use the new interface which will use both "used and exclude nodes".
Rack aware policy to handle both scenario is handled in below PR.
https://github.com/apache/ozone/pull/4614
Until legacy RM code exist decommissioning scenario will continue to work with this fix.

Thanks @ashishkumar50 for the patch, @krishnaasawa1, @sodonnel for the review.


Don't generate messages.properties

Hello,
In the new version is not Automatically generated "messagges.properties"
http://prntscr.com/amgblc
Regards Ismael.

@iisma1 This is intended because Waterfall now uses the new BungeeCord implemntation with an optional messages.properties in the root folder.

So basically you just create a messages.properties file and change the messages you want.


Document in OptionsBuilder.java the incompatible options

Document in these 3 methods that they are mutually exclusive for the target

inPlace() (precise that in place means to create the target file in the same folder as the original, just changing the extension)
toFile() you precise instead the target file name path including the extension
destinationDir()

OptionsBuilder does not detect and complains that you set them together.
Thanks.

Hi Olivier,
Would you like to create a PR with a fix for this?
Robert

We should also mention use of  standalone with headerFooter if merged


Help me please

Which download link should you take for a powkiddy x28
In fact, I don't even know what firmware is. Do I need it to play fortnite?

As I said already in your last ticket, this is an Android only device so none of the available images will work for the x28 and I don't know anything about this device or how to help you.  Try Reddit.


fix rm non-visiable charactor null in out file

Proposed changes
Issue Number: close #xxx

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall


Call shared config fresh before retry

cc @bcall-r7 @athompson-r7 @bturner-r7 @eciramella-r7
See also #174 which started off this work. After some testing we realised that a stack created before a refresh would have stale EC2/CloudFormation clients. We now use the Aws.shared_config.fresh function to refresh credentials and re-assign new clients (initialised with the appropriate credentials) to the ec2/cf client instance variables.

Closing this after reverting #174 (in #193). This feature requires more work and wasn't deemed necessary as part of the v1.0 release.


[T2A2][T15-A4]Huang Zihua

Reduced SLAP of method main.

Ready for review

Ready for review

@JamesHuangUC Good start.

Use the imperative very in commit messages (simplify instead of simplified, change instead of changed).
Mention the function name if the edits are limited to only one method.
Create new branches for different activities and create separate pull requests for them.


include: remove unnecessary autoconf.h includes

The autoconf.h header is not required because the definitions present in
the file are exposed using the compiler -imacros flag.

Note that there's a little bit of risk with a patch like this: there are a tiny handful of spots where we're compiling code outside of the normal device target paths but might still want to have access to project kconfig. The intel_adsp "bootloader" code was like this until fairly recently (it's been fixed to build with the rest of the project now), and I have some unsubmitted changes that do this in the x86 EFI loader.
Those are the only two examples I can think of, but I wouldn't be surprised if someone else was playing similar tricks (though I don't see any after a quick audit of the patch0. Just something to be aware of if some obscure build suddenly regresses.

Fair point. I really trusted CI here, but haven't considered anything else. Maybe I should send a mail to the mailing-list, so people is aware of this change.


Fill SortedSet

When you ask AutoFixture for a hash set, it provides a non-empty value:
var fixture = new Fixture();
var actual = fixture.Create<HashSet<string>>();
Assert.NotEmpty(actual); // Succeeds

When you request a sorted set, on the other hand, the returned set is empty. This test fails its assertion:
var fixture = new Fixture();
var actual = fixture.Create<SortedSet<string>>();
Assert.NotEmpty(actual); // Fails

Since AutoFixture can already supply non-empty collections, and one of the constructor overloads for SortedSet<T> takes a IEnumerable<T>, it ought to be fairly easy to add a relay from SortedSet<T> to IEnumerable<T>.
The implementation could for example be a new ISpecimenBuilder that handles requests for any SortedSet<T> by resolving IEnumerable<T> from the context, and then invoking the appropriate constructor overload with the returned value.
Another implementation option is to mimic the way hash sets are already filled. See the combination of EnumerableFavoringConstructorQuery and HashSetSpecification in the Fixture class.

See also #622 and #623.


Files delete slowly

Files take a while to delete, progress bar counts to 100% without being able to interact with the app until the operation is over and at times will restart and count to 100 again in the same operation.
I think this may be a reproduced bug, I tried searching at first (not extensively.)👍🏼

Files take a while to delete

Yes, because Aves is not a file manager it does not have direct file access. Contrary to file managers, gallery apps must rely on other media-related APIs, which take time to move/delete files.

at times will restart

Sometimes deleting can be in 2 steps, when it's moving the items to the bin and you configured Aves to let it preserve dates when moving items. In that case, there will be a first step to edit the metadata, then another step to move it to the bin, so you see the progress indicator going from 0% to 100% twice.


Added e2e test for page.tag.detached event

refs: #15537
This adds an e2e test and test snapshot for the page.tag.detached webhook so we can prevent regressions and bugs in the future
Got some code for us? Awesome 🎊!
Please include a description of your change & check your PR against this list, thanks!

[x] There's a clear use-case for this code change, explained below
[x] Commit message has a short title & references relevant issues
[x] The build will pass (run yarn test:all and yarn lint)

We appreciate your contribution!
Also, if you'd be interested in writing code like this for us more regularly, we're hiring:
https://careers.ghost.org

Hey-hey @Dark-Knight11 👋 These are great changes are I think we are 90% there. I've left couple of comments around areas that need improvement. Feel free to reach out if you need more guidance and thanks for the contribution!

Hi, I have made the requested changes kindly look into it and lmk if anymore changes are needed from my side.
Thanks!

The snapshots seem to be outdated on and are failing now. Can you please re-record them again @Dark-Knight11 🙏

Hey @Dark-Knight11 thanks again for your contributions! This has been merged and the hacktoberfest-accepted label added to make sure it counts.
Please keep them coming 🙏 we have so much we want to achieve beyond hacktoberfest 😬


Displaying Projects with different variables.

What would you like help with?
I have a folder with all my projects called "100. Projects".
A project's front matter looks like this:
creation_date: 2022-12-20T17:20
pro_deadline: 31-12-22
pro_start: 10-12-22
pro_end:
type: project
status: #PRO/doing
area: #project/workspace
I tried using dataview, and it worked to display projects for a specific area, display all projects, all projects with a certain status, etc.—I think this plugin can do that better, right?
But my issue is that when I tried to display all projects from the "100. Projects" path, it displayed all notes inside all folders (since each project is its folder, not its note, right.) (I use folder notes, so each project also has a project note, which I wanted to display, but it still displays all the notes within all subfolders)
These are my settings for this view:

Did I grossly misunderstand the Projects plugin, or am I missing something? I mean, it's also called "Projects Plugin," right??
This is an example of what I used dataview for:

Hi, and thanks for trying out the plugin!
Each project defines a collection of notes to include in the project. Currently, you can use folders or Dataview queries to define what notes to include.
The reason why it displays all notes under the folder you selected is because you have "Include subfolders" enabled, which will include notes from every subfolder.
If you have a folder per project in the 100. Projects folder, you may want to create separate Projects for each project folder.

It's not quite what I had in mind, tbh. I wanted to display all projects in one table with some data, but dataview can do that; this plugin could do it better (I thought). I don't need this now, but I'll keep it installed.

I see! You'd like to see all the projects at once. Sounds similar to #140.


creating a contact page and hubspot form

Description
Adding a contact form that feeds directly into hubspot & changing to 'trusted by 1000+ organizations'.
For now, this is just a silent release (only accessible via dust.tt/home/contact url). I'd like to release it now to test it. We'll then finalize the form directly in hubspot, and add/change hyperlinks everywhere as we land.

@ameliedrhub FYI
@JulesBelveze I have a few react hydration issues I may need your help with when you're back ;)


update rlp_03 to 1.0.4

update rlp_03 to 1.0.4

https://github.com/teragrep/rlp_03/issues/5

Newest release updated it


remove version lock from the engine

the patch removes the yam version lock , after the engine recovery and before the engine-setup role execution.
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1827135
Signed-off-by: Evgeny Slutsky<EMAIL_ADDRESS>

ci test please

why is done in the ansible role and not inside engine-backup when doing the restore? How is it a unique problem to this role and not a general problem of restoring(upgrading) from older release?

why is done in the ansible role and not inside engine-backup when doing the restore? How is it a unique problem to this role and not a general problem of restoring(upgrading) from older release?
agreed, it better to be part of the engine-backup --restore flow.

why is done in the ansible role and not inside engine-backup when doing the restore? How is it a unique problem to this role and not a general problem of restoring(upgrading) from older release?

agreed, it better to be part of the engine-backup --restore flow.

oh, sorry, maybe I wasn't clear in the last comment. I meant to fix this in the restore script itself, i.e. in https://github.com/oVirt/ovirt-engine/blob/master/packaging/bin/engine-backup.sh.in
you will face the same problem when upgrading manually without any ansible role involved

@michalskrivanek, yes that what I was referring to.
see didi's comment on that:
https://bugzilla.redhat.com/show_bug.cgi?id=1827135#c6

remove the file /etc/dnf/plugins/versionlock.list  causes this error when running engine-setup:
[ ERROR ] fatal: [localhost -> engine.es.localvms.com]: FAILED! => {"changed": false, "module_stderr": "Shared connection to engine.es.localvms.com closed.\r\n", "module_stdout": "Traceback (most recent call last):\r\n  File \"/usr/lib/python3.6/site-packages/dnf-plugins/versionlock.py\", line 184, in _read_locklist\r\n    with open(locklist_fn) as llfile:\r\nFileNotFoundError: [Errno 2] No such file or directory: '/etc/dnf/plugins/versionlock.list'\r\n\r\nDuring handling of the above exception, another exception occurred:\r\n\r\nTraceback (most recent call last):\r\n  File \"/root/.ansible/tmp/ansible-tmp-1588248748.822611-1967-113087827221267/AnsiballZ_dnf.py\", line 102, in <module>\r\n    _ansiballz_main()\r\n  File \"/root/.ansible/tmp/ansible-tmp-1588248748.822611-1967-113087827221267/AnsiballZ_dnf.py\", line 94, in _ansiballz_main\r\n    invoke_module(zipped_mod, temp_path, ANSIBALLZ_PARAMS)\r\n  File \"/root/.ansible/tmp/ansible-tmp-1588248748.822611-1967-113087827221267/AnsiballZ_dnf.py\", line 40, in invoke_module\r\n    runpy.run_module(mod_name='ansible.modules.packaging.os.dnf', init_globals=None, run_name='__main__', alter_sys=True)\r\n  File \"/usr/lib64/python3.6/runpy.py\", line 205, in run_module\r\n    return _run_module_code(code, init_globals, run_name, mod_spec)\r\n  File \"/usr/lib64/python3.6/runpy.py\", line 96, in _run_module_code\r\n    mod_name, mod_spec, pkg_name, script_name)\r\n  File \"/usr/lib64/python3.6/runpy.py\", line 85, in _run_code\r\n    exec(code, run_globals)\r\n  File \"/tmp/ansible_dnf_payload_y5l1lo2t/ansible_dnf_payload.zip/ansible/modules/packaging/os/dnf.py\", line 1304, in <module>\r\n  File \"/tmp/ansible_dnf_payload_y5l1lo2t/ansible_dnf_payload.zip/ansible/modules/packaging/os/dnf.py\", line 1293, in main\r\n  File \"/tmp/ansible_dnf_payload_y5l1lo2t/ansible_dnf_payload.zip/ansible/modules/packaging/os/dnf.py\", line 1266, in run\r\n  File \"/tmp/ansible_dnf_payload_y5l1lo2t/ansible_dnf_payload.zip/ansible/modules/packaging/os/dnf.py\", line 649, in _base\r\n  File \"/usr/lib/python3.6/site-packages/dnf/base.py\", line 435, in fill_sack\r\n    self._plugins.run_sack()\r\n  File \"/usr/lib/python3.6/site-packages/dnf/plugin.py\", line 155, in run_sack\r\n    self._caller('sack')\r\n  File \"/usr/lib/python3.6/site-packages/dnf/plugin.py\", line 104, in _caller\r\n    getattr(plugin, method)()\r\n  File \"/usr/lib/python3.6/site-packages/dnf-plugins/versionlock.py\", line 78, in sack\r\n    for pat in _read_locklist():\r\n  File \"/usr/lib/python3.6/site-packages/dnf-plugins/versionlock.py\", line 190, in _read_locklist\r\n    raise dnf.exceptions.Error(NOT_READABLE % e)\r\ndnf.exceptions.Error: Unable to read version lock configuration: [Errno 2] No such file or directory: '/etc/dnf/plugins/versionlock.list'\r\n", "msg": "MODULE FAILURE\nSee stdout/stderr for the exact error", "rc": 1}

@eslutsky @sandrobonazzola but Didi's comment suggests a different path - to stop updating the package, i.e. invoke engine-setup with --offline. That does solve the problem without touching/removing any files anywhere.

@eslutsky @sandrobonazzola but Didi's comment suggests a different path - to stop updating the package, i.e. invoke engine-setup with --offline. That does solve the problem without touching/removing any files anywhere.
in this case we are invoking engine-setup role [0]
which tries to install ovirt-engine package regardless of the offline parameter [1]
so it the versionlock is set to incorrect OS  it will fail to find the package.

[0]  https://github.com/oVirt/ovirt-ansible-hosted-engine-setup/blob/7a4215f34acab123b14f2f085c690ef7cf5d7e0f/tasks/partial_execution.yml#L48
[1] https://github.com/oVirt/ovirt-ansible-engine-setup/blob/baa98047ba902201aac4f595986c29816ad4d8fc/tasks/install_packages.yml#L2

yep, so that's the only change needed. any package upgrade/installation need to happen before restore and engine-setup. then everything's going to work nicely

yep, so that's the only change needed. any package upgrade/installation need to happen before restore and engine-setup. then everything's going to work nicely

there are cases when engine-setup role runs against host which doesn't have the package installed, so the deployment invoked through ansible only (without any wrappers).

engine-setup role yes, but not the hosted-engine setup. the step you're fixing is part of the installation originating from appliance, so you always have ovirt-engine installed. It just may not be up to date (along with other outdated packages, so "dnf upgrade" makes sense to do in earlier step anyway


feat(connector): [Bluesnap] add authorize, capture, void, refund, psync, rsync and Webhooks support

Type of Change

[ ] Bugfix
[X] New feature
[ ] Enhancement
[ ] Refactoring
[ ] Dependency updates

Description
Updating support for Bluesnap payment gateway
Payment Method: card
Supported payment flows

Authorize
Capture
PSync
Refund
Cancel
RSync
Webhooks

Additional Changes

[ ] This PR modifies the database schema
[ ] This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Checklist

[X] I formatted the code cargo +nightly fmt --all
[X] I addressed lints thrown by cargo clippy
[X] I reviewed submitted code
[X] I added unit tests for my changes where possible
[ ] I added a CHANGELOG entry if applicable

This pull request is blocked because of other blocking changes are there in this PR.

Closing this in favour of (#649)


Make Process.default_state recursive

Though it is rarely used, the Process.default_state method previously broke when a process' ports schema had ports that were either not nested at all or nested more than one level deep. This PR fixes that by making default_state recursive and adds a test to ensure it works.

By creating this pull request, I agree to the Contributor License
Agreement, which is available in CLA.md at the top level of this
repository.

Ready to merge. I'm pretty sure the required statuses thing is something that was configured on GitHub itself under Settings > Branches > Edit master > Require status checks to pass before merging. I can see it for the vivarium-ecoli repo where I am an admin but not for this one.


No dark mode on Windows 10 1803

Describe the bug
None of the toggle theme options work
Technical Info (please complete the following information)

OS: Windows 10 1803
Tusk Version: 0.22

I hope tusk supports evernote's new UI asap.

if y wanting it so mach why not start contributing 😜

The same issue goes for Ubuntu 18.04. Using Tusk 0.22.0 (x64).
Still loving it though:)

Also true for Ubuntu 18.10

https://github.com/klaussinani/tusk/issues/88
@AndreasPuhl  @minasm Search befor openning issues 😜

Please see #88 for more info


Updated arrested abroad tool

Updated the arrested abroad tool with the support that the FCO can provide in the British Overseas Territories. I've also updated the content for the rest of the world outcome.

@hannahwhittaker This is now ready for checking and approval.


Orders API The amount of the order does not match the total amount from the order lines.

Expected behavior
I expected to be redirected to the payment screen.
Actual behavior
This error message:

Error executing API call (422: Unprocessable Entity): The amount of the order does not match the total amount from the order lines. Expected order amount to be €10.48 but got €6.48. Field: amount. Documentation: https://docs.mollie.com/guides/handling-errors. Cart Dump: { "amount": { "currency": "EUR", "value": "6.48" }, "method": "banktransfer", "redirectUrl": "https:///en/module/mollie/return?cart_id=79&utm_nooverride=1&rand=1547598071", "webhookUrl": "https:///en/module/mollie/webhook", "metadata": { "cart_id": 79, "order_reference": "HZTFVOTQM", "secure_key": "d48a7db5935c814f09720e29325b6fba" }, "locale": "en_US", "billingAddress": { "givenName": "", "familyName": "", "email": "", "streetAndNumber": "jasdasd 12 ", "city": "", "region": "", "country": "KR", "postalCode": "123-123" }, "shippingAddress": { "givenName": "", "familyName": "", "email": "", "streetAndNumber": "", "city": "", "region": "", "country": "KR", "postalCode": "123-123" }, "orderNumber": "HZTFVOTQM", "lines": [ { "name": "Sweet Pumpkin Muffin", "quantity": 1, "sku": "41\u00a4308\u00a40", "unitPrice": { "currency": "EUR", "value": "5.49" }, "totalAmount": { "currency": "EUR", "value": "5.49" }, "vatAmount": { "currency": "EUR", "value": "0.00" }, "vatRate": "0.00" }, { "name": "Shipping", "quantity": 1, "sku": "", "unitPrice": { "currency": "EUR", "value": "2.99" }, "totalAmount": { "currency": "EUR", "value": "2.99" }, "vatAmount": { "currency": "EUR", "value": "0.00" }, "vatRate": "0.00" }, { "name": "Gift wrapping", "quantity": 1, "sku": "", "unitPrice": { "currency": "EUR", "value": "2.00" }, "totalAmount": { "currency": "EUR", "value": "2.00" }, "vatAmount": { "currency": "EUR", "value": "0.00" }, "vatRate": "0.00" } ] }

Looking at the values in it, I can find: unit price: 5.49€, another unit price: 2.99€ and a random 2.00€ which together would indeed result in a total of 10.48€. The products original price is 4.99€ with a 30% discount dropping it to 3.49€ + 2,99€ shipping = 6.48€. Thus, I can't explain where the 5.49€ are coming from. The last 2.00€ would be the exact same amount that is charged for gift wrapping. Which is also set to "quantity" 1 which is curious, given that gift wrapping is disabled in my store.
Steps to reproduce the behavior
Activate oders API and check out.
Environment

PrestaShop version: <IP_ADDRESS>
Mollie module version: 3.3.3 (orders API)

It appears this issue is still present in the current version of this module. I had the exact same error where gift wrapping is added to the total amount, even though this was not set by the customer. The solution by firstred still works and allows charging the customer for wrapping correctly, but requires modification of the module itself. The other solution of disabling gift wrapping in Prestashop does fix the problem temporarily, but of course, we do want to offer our customers the option of having their gifts wrapped. Can the code be changed permanently by the developer to fix this issue in future versions as well?


fix(ListingManagement): Fix inaccurate results on first click of org …

…steward tab #402

@wski @arw180

:+1:

:+1:


Rendering a table via collection?

Some of this behavior was throwing me off.  This is using Thorax 2.3.5.
Related:

https://lostechies.com/derickbailey/2012/04/05/composite-views-tree-structures-tables-and-more/
https://github.com/walmartlabs/thorax/issues/402

At https://jsfiddle.net/oko05cv7/, I'm trying to be able to render a table correctly, but a div is being added.  Why would it create two layers? I'd assume the tag='tr' would be the tagName on the CollectionView.

A second thing I notice is that, if you were to omit a tag in collection, the collection view contents won't render. I would expect it to work and either be a div (or inherit the tagName set in item-View, which would be tr in this example: https://jsfiddle.net/5yc8s84q/)

I eventually was able to reconfigure it to work https://jsfiddle.net/zxyheohu/, is that how you'd do it?  What would be the equivalent of this with a CollectionView? If this does work, are you ok if we add it as an example in the README/docs somewhere?

I looked into collection-element however the documentation / examples on that are minimal. Would a collection-element play a role in 3?

Edit: corrected the second point's JS fiddle URL and corrected to say the collection view content doesn't show.


DSP-804: create a child node with a custom IRI

resolves DSP-804
closes #1305

@benjamingeer thanks for reviewing this!


command Alt + Enter is doesn't works in cmd, git bash

Microsoft PowerToys version
"0.3.72"
Running as admin

[X] Yes

Area(s) with issue?
PowerToys Run
Steps to reproduce
command Alt + Enter is doesn't works in cmd, git bash
✔ Expected Behavior
show spotlight
❌ Actual Behavior
in cmd press Alt + Enter
Perhaps because it exists in cmd commend.
Is there a solution other than changing the existing one?
Other Software
No response

@yunyeop can you include the Zip from "Report Bug"?
I'm betting your terminal windows are elevated but PowerToys itself isn't being run as an admin,  I just tried and if PT is run as admin, it works against elevated cmd / terminal windows

@yunyeop can you include the Zip from "Report Bug"?
I'm betting your terminal windows are elevated but PowerToys itself isn't being run as an admin, I just tried and if PT is run as admin, it works against elevated cmd / terminal windows

it works well thanks!


Apple TV

Please, could you add apple tv support

I am not familiar with tvOS. Not sure how UIKit works on Apple TV. Should be easy to port if it has core animation and the 'snapshotAfterScreenUpdate' API. Maybe you can put up a PR to contribute to the project.😀

Hey @lkzhao ! I have made a minimal working tvOS example app with Hero from a fork. It's not good enough for me to open a pull request, so you can take a look first here
I had to put some conditional compiling in the DebugView because sliders and pinchgestures weren't available in tvOS.
The transition did have a subtle stutter at the beginning, maybe because of the visual effect view, but it could be fixable by tweaking some Hero parameters.

@fruitcoder I have an Apple TV application in production now and in few weeks I will redesign it and do tvOS support for Hero and send PR to @lkzhao if you don't do it faster :)

@fruitcoder I checked out your branch, Looks awesome. It is quite useable already. @f0r3s1 I believe we can get this merged soon, so don't put too much work into this.
@fruitcoder I have just pushed a commit into the master branch that fix the flash that you are seeing.
One thing I have noticed is that the Debug Plugin really doesn't do much in tvOS without the slider. Can we just make the Debug Plugin unavailable in tvOS instead? Later, we can build some gesture to mimic the slider function. But that shouldn't be blocking.

I'll do it right now. Now HeroDebugPlugin and HeroDebugView aren't compiled for tvOS and are, therefore, unavailable.

Your fix works perfectly, the flicker is gone! PR at #71

I updated the master with a some ported examples. Just got myself familiar with tvOS's focus model. One thing I have noticed with ImageView with adjustImageWhenFocused enabled, is that I have no way of snapshotting the focused imageView. Any of you guys know how this can be done?

Do you have a branch that illustrates the issue? What image do you get when snapshotting a focused image view?

@fruitcoder Yes, please checkout the tvOS examples under the imageGallery tab:

The result I got from snapshotting a focused view does not contain the focused effect.

Ah I see! I'll take a look tomorrow

Oh damn... I've had my issues with this super private API of the image view focus behaviour and here we go again. The problem is that the focused image view cannot be snapshotted, because there are CATransformLayers involved. See at: https://developer.apple.com/reference/quartzcore/calayer/1410909-render which is used under the hood of snapshotView:afterScreenUpdates. Comparing layer tree of the cells once with "Adjusts image when focused" and once without shows us:
with focus:
<HeroTvOSExamples.ImageCell: 0x7f8004e18020; baseClass = UICollectionViewCell; frame = (435 64; 307.2 307.2); opaque = NO; layer = <CALayer: 0x6100002245e0>>
   | <UIView: 0x7f8004e18440; frame = (0 0; 307.2 307.2); gestureRecognizers = <NSArray: 0x61000005dfa0>; layer = <CALayer: 0x610000224600>>
   |    | <UIImageView: 0x7f8004e18600; frame = (0 0; 307 307); autoresize = RM+BM; userInteractionEnabled = NO; layer = <CALayer: 0x610000224620>>
   |    |    | <_UIStackedImageContainerView: 0x7f8004e18ce0; frame = (0 0; 307 307); layer = <_UIStackedImageContainerLayer: 0x7f8004e18ea0>>
   |    |    |    | <CALayer: 0x610000225080> (layer)
   |    |    |    | <CALayer: 0x610000225060> (layer)
   |    |    |    |    | <CATransformLayer: 0x610000225280> (layer)
   |    |    |    |    |    | <CALayer: 0x610000225400> (layer)
   |    |    |    | <CALayer: 0x610000225240> (layer)
   |    |    |    | <CALayer: 0x610000225320> (layer)
   |    |    |    |    | <CATransformLayer: 0x6100002252e0> (layer)
   |    |    |    |    |    | <CATransformLayer: 0x610000225420> (layer)
   |    |    |    |    |    |    | <CALayer: 0x610000225300> (layer)
   |    |    |    |    |    |    | <CALayer: 0x610000226780> (layer)
   |    |    |    | <UIView: 0x7f8004e19340; frame = (0 0; 1 1); layer = <CALayer: 0x610000224f40>>

without focus:
<HeroTvOSExamples.ImageCell: 0x7febc940a020; baseClass = UICollectionViewCell; frame = (64 64; 307.2 307.2); opaque = NO; layer = <CALayer: 0x618000032e80>>
   | <UIView: 0x7febc9409d30; frame = (0 0; 307.2 307.2); gestureRecognizers = <NSArray: 0x6180000555d0>; layer = <CALayer: 0x618000032fc0>>
   |    | <UIImageView: 0x7febc9410910; frame = (0 0; 307 307); autoresize = RM+BM; userInteractionEnabled = NO; layer = <CALayer: 0x618000033320>>

Going deeper on the image view's layer's sublayers:
po (collectionView.cellForItem(at: indexPath) as! ImageCell).imageView.layer.sublayers.first!.sublayers!
▿ Optional<Array<CALayer>>
  ▿ some : 5 elements
    - 0 : <CALayer:0x608000039f40; position = CGPoint (153.22 153.5); bounds = CGRect (0 0; 505 511); delegate = <_UIStackedImageContainerLayer: 0x7f9dacb114c0>; contents = <CGImage 0x6080001d4a00>
	<<CGColorSpace 0x600000028380> (kCGColorSpaceICCBased; kCGColorSpaceModelRGB; sRGB IEC61966-2.1)>
		width = 280, height = 280, bpc = 8, bpp = 32, row bytes = 1120
		kCGImageAlphaPremultipliedFirst | kCGImageByteOrder32Little
		is mask? No, has mask? No, has matte? No, should interpolate? Yes; opacity = 0.5; contentsScale = 1; transform = CATransform3D (1 0 0 0; 0 1 0 0; 0 0 1 0; 0 50 0 1); contentsCenter = CGRect (0.5 0.5; 0 0); shadowColor = <CGColor 0x608000093a60> [<CGColorSpace 0x618000027a40> (kCGColorSpaceICCBased; kCGColorSpaceModelMonochrome; Generic Gray Gamma 2.2 Profile; extended range)] ( 0 1 ); zPosition = -51; animations = [position=<CABasicAnimation: 0x61800002f440>]>
    - 1 : <CALayer:0x608000039e20; position = CGPoint (153.5 153.5); bounds = CGRect (0 0; 307 307); delegate = <_UIStackedImageContainerLayer: 0x7f9dacb114c0>; sublayers = (<CATransformLayer: 0x60800003a2e0>); allowsGroupOpacity = YES; >
    - 2 : <CALayer:0x60800003a6c0; position = CGPoint (153.314 153.5); bounds = CGRect (0 0; 307 307); contents = <CGImage 0x6080001d4550>
	<<CGColorSpace 0x600000028380> (kCGColorSpaceICCBased; kCGColorSpaceModelRGB; sRGB IEC61966-2.1)>
		width = 512, height = 512, bpc = 8, bpp = 32, row bytes = 2048
		kCGImageAlphaPremultipliedLast | 0 (default byte order)
		is mask? No, has mask? No, has matte? No, should interpolate? Yes; hidden = YES; masksToBounds = YES; backgroundColor = (null); animations = [position=<CABasicAnimation: 0x61800003c0e0>]>
    - 3 : <CALayer:0x60800003a720; position = CGPoint (153.314 153.5); bounds = CGRect (0 0; 307 307); sublayers = (<CATransformLayer: 0x60800003ab20>); mask = <CATransformLayer: 0x60800003aee0>; filters = (
    "<CAFilter: 0x61800005a0d0>"
); animations = [position=<CABasicAnimation: 0x61800002dac0> filters.brightness.inputAmount=<CABasicAnimation: 0x61800002d120>]>
    - 4 : <CALayer:0x60800003b420; position = CGPoint (0.5 0.5); bounds = CGRect (0 0; 1 1); delegate = <UIView: 0x7f9dacb133b0; frame = (0 0; 1 1); alpha = 0; layer = <CALayer: 0x60800003b420>>; opaque = YES; allowsGroupOpacity = YES; opacity = 0>

This is the first hint of the visible bounds of the scaled image (CGRect (0 0; 505 511)), so a super hacky way would be to take that bounds, calculate a transform that would scale the original image to that bounds, and take this as a snapshot for the fromView. But since internals can change, this would have to be tested for every tvOS release 😔

Oh! I just saw you already got the correct frame via imageView.focusedFrameGuide.layoutFrame 😄

I managed to get the frame correct when coming from a focused view, but I could not yet make it revert to the focused frame because I rely on the cell still being focused:
https://github.com/fruitcoder/Hero/tree/tv-os-focus-fix
To make the reverse working I thought about taking the focus from the current view away and forcing the focus back to the previously focused item, but I don't know if that works.

Nice! I feel like this is pretty good already. UIKit refocus the imageView after the dismiss transition with a scale animation. Seems fluid. One thing I have noticed it that white glare suddenly disappears. Is that possible we can focus the imageView we created during the transition to get that glare effect? Or just snapshotting the focused view using resizableSnapshotViewFromRect

I saw @felix-dumit used this when capturing the background for UIVisualEffectView here: https://github.com/lkzhao/Hero/issues/26 https://github.com/lkzhao/Hero/commit/7d9f0f11a4c7e94d26fb48f4b0ad25dcd51e10ea

Hm, would be interesting to make that work. The glare seems to be one of the custom layers that don't aren't part of the composition being screenshotted. But maybe if the transition view returns the image view snapshot as its preferredFocusEnvironments or preferredFocusedView and calling setNeedsFocusUpdate() and updateFocusIfNeeded() on the transition view might produce the glare.


Merging this repo with the greenland master branch

Currently working on merging two branches
TODO

[x] Catch possible errors
- [ ] Graceful error handling in socket connection
[x] Display main menu in client (partial)
[x] Response to the request of client in server
[x] Compile with Makefile
[x] Modularise client and server

Pretty much done, ready to merge

Should I do a sync instead of merging? Cause it shows the branch has conflicts.

U can just fix it on the GitHub or git pull on ur local machine and fix it with ur git client

conflicts resolved


include jar even if secure feature is disabled

The secure module and the signed and encrypted methods are the
only parts of jar that depend on openssl, so this adds all the other
parts of jar to be used even without those crates.

Thanks! Looks like there's some travis failures though in the doc tests.

Hm, how does cargo doc --no-deps work?

Ok, I moved the docs using those methods to the specific methods themselves. Passes locally.


Traffic light detection - dummy mode

What?
Created a dummy detector for the traffic lights using the /vehicle/traffic_lights topic that the simulator publishes to.
Why?
The /traffic_waypoint is published and further development can be done until the live detector is implemented.
[x] - works on simulator
[x] - tested locally
[ ] - local env version: Simulator running on OS X 10.13.3 and ros running on VirtualBox

Hi @fadida! Thank you for the comment. Using a detector base class is a great suggestion! I have not include that yet because I wanted to get through the requirements as quickly as possible in order to facilitate the development for all the other project nodes. In my opinion, we can merge this branch as is and implement inheritance while we build the live_detector.py after @ooleksyuk completes her classifier on a new branch. Does this approach make sense?

Note that you can switch from dummy to live detector from the /ros/src/tl_detector/tl_detector.py


chore: update dispatch builder to work with 18.0

Issue being fixed or feature implemented

As mentioned in #4983, Dockerfile.GitHubActions.Dispatch no longer worked because of changes to the directory structure, target platforms and addition of a .dockerignore file.
What was done?

Update dependencies
Change ARM platform target to aarch64-linux-gnu
Delete .dockerignore

How Has This Been Tested?

Locally
Breaking Changes

What were we using that .dockerignore file for?
Checklist:

[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have added or updated relevant unit/integration/functional/e2e tests
[ ] I have made corresponding changes to the documentation

For repository code-owners and collaborators only

[ ] I have assigned this pull request to a milestone

Thanks for the explanation! I guess the question is if we also want to maintain this Dockerfile, or if nobody is using it then we can just delete it (and the even older phusion-based image)? Future versions won't use Gitian to build anyway I believe.


jax2tf with certain reshapes fails with polymorphism

This feels like it should work:
import jax
import jax.numpy as jnp
from jax.experimental import jax2tf
import tensorflow as tf

@jax.jit
def f(x):
  n,z = x.shape
  padding_mask = jnp.ones((n + 1, z), dtype=bool)
  return jnp.reshape(padding_mask, ((n + 1) * z))

f_tf = tf.function(jax2tf.convert(f,
                                  polymorphic_shapes=["(b, 2)"]),
                                  autograph=False)
f_tf.get_concrete_function(tf.TensorSpec([None, 2], tf.int32))

gives

TypeError: Shapes must be 1D sequences of concrete values of integer type, got 2*b + 2.

This should work. I will look at it.

The problem arises because the shape parameter for jnp.reshape is a scalar (not a tuple), and in this case it happens to be a representation of a polynomial 2*b +2. There is a check in jnp.reshape that watches for scalar shapes, and that check is confused by the representation of the polynomial, which happens to be iterable.


Incompatible CLI parameters --all and --directory-only / Inconsistent behavior w.r.t. original ls

os: Linux Mint 20.2
lsd --version:  lsd 0.20.1
echo $TERM: xterm-256color
echo $LS_COLORS:

Expected behavior
If applicable, add the output of the classic ls command (\ls -la) in order to show the buggy file/directory.
If I define alias ls='ls -ahl --color' and then use ls -d *, this works and lists all the names of the directories in my current dir (even those starting with .) but not their contents. This is what is expected from -a and -d CLI parameters.
I would expect the same behavior from lsd
Actual behavior
If the application panics run the command with the trace (RUST_BACKTRACE=1 lsd ...).
In case of graphical errors, add a screenshot if possible.
When I define alias ls='lsd -ahl --color auto', and I attempt to run ls -d *, I get error: The argument '--all' cannot be used with '--directory-only'.
Fist of all, this behavior is inconsistent with the behavior of original ls.
Second, I don't see why these CLI parameters would be incompatible. Indeed, original ls behavior seems reasonable. Thus I would expect lsd to consider them compatible too.

As a beginner user, my theory is that in the file src/app.rs the following piece of code is responsible for this behavior
Arg::with_name("directory-only")
                .short("d")
                .long("directory-only")
                .conflicts_with("all")
                .conflicts_with("almost-all")
                .conflicts_with("depth")
                .conflicts_with("recursive")
                .help("Display directories themselves, and not their contents (recursively when used with --tree)"),

hi @Gasu16, yes, you get the point right! and we still need to check if the output behavior matches the GNU ls.
a PR is welcome if you could help to check it and validate the output!
also don't forget to add a test after the implementation.

hi @Gasu16, yes, you get the point right! and we still need to check if the output behavior matches the GNU ls.
a PR is welcome if you could help to check it and validate the output!
also don't forget to add a test after the implementation.

Hi!
I am currently working on the implementation to solve this issue, if everything goes fine soon I will send the first PR, trying to make the output behavior matching the ls command.

@zwpaper should I merge it in the master branch?

Hi @zwpaper I pushed my PR which solves the problem, feel free to check it and let me know if there are any problems with it.

fixed by https://github.com/Peltoche/lsd/pull/587


NavigationExperimental: Unhandled JS Exception: Can't add property 0, object is not extensible

After trying to upgrade from 0.24.1 to 0.26.2 I ran into this exception using NavigationAnimatedView.
As I understand the exception, React Native's Animated doesn't like it anymore if you use an animation value that is not an Animated.Value, which is what NavigationExperimental seems to be doing.
But I could be wrong. I generally find these kinds of issues hard to debug.

I strongly recommend you to upgrade to v0.28-rc. A lot has changed in NavigationExperimental since v0.26.
If it still spits out an exception after the upgrade, please post the block of code that's causing it so we can help you debug.
🍺

Yeah, I'll upgrade a bit later. Got a bit scared when I saw all the changes. Also,  the. 25 and. 26 upgrade didn't go smooth. Can't really afford to spend much time fixing working stuff right now.

Hi there! This issue is being closed because it has been inactive for a while.
But don't worry, it will live on with ProductPains! Check out its new home: https://productpains.com/post/react-native/navigationexperimental-unhandled-js-exception-cant-add-property-0-object-is-not-extensible
ProductPains helps the community prioritize the most important issues thanks to its voting feature.
It is easy to use - just login with GitHub. GitHub issues have voting too, nevertheless
Product Pains has been very useful in highlighting the top bugs and feature requests:
https://productpains.com/product/react-native?tab=top
Also, if this issue is a bug, please consider sending a pull request with a fix.
We're a small team and rely on the community for bug fixes of issues that don't affect fb apps.


Enable control of use of caching in tf.keras.preprocessing.image_dataset_from_directory

System information

TensorFlow version (you are using): TF 2.3.0
Are you willing to contribute it (Yes/No): Yes

Describe the feature and the current behavior/state.
This concerns the API tf.keras.preprocessing.image_dataset_from_directory(...) I read through the doc as well as the source code, it doesn't seem like there's any control over behavior concerning cache() for the tf.data.Dataset. As best I could understand this, it won't be right to apply .cache(...) to the output tf dataset of this API since shuffling is done (esp. for train) and caching anything after, it freezes the initial shuffling order, such that it stays fixed at subsequent epochs. According to general wisdom, this is highly likely not desirable. The caching should be done before shuffling, but there's no way to specify this at API call time. The only workaround I could think of is to copy/paste the exact code, and write your own version.
Will this change the current api? How?
One can add this feature without affecting old behavior. Cache is simply assumed False unless supplied otherwise, and if it is false, the old code path should execute.
Who will benefit with this feature?
image_dataset_from_directory(...) is a nice convenient method and caching may improve performance by not repeating the image resizing processing. It can also help if your original directories are remote and may suffer outage or unpredictable lag.
Any Other info.

tf.keras.preprocessing.image_dataset_from_directory will be deprecated from Tensorflow 2.9 version, prefer loading data with tf.keras.utils.image_dataset_from_directory, and then transforming the output tf.data.Dataset with preprocessing layers.
If you still feel this feature needs to be added, feel free to open a new feature request. Thanks!


Improve UX of Signup Screen.

During signup, the error is displayed using snackbar which is not visible when the keyboard is in use.
Steps to reproduce
Improve the logic and enable error on EditText.
Expected behaviour
Show the error on EditText using method setError and setErrorEnabled.
Reference: https://developer.android.com/reference/android/support/design/widget/TextInputLayout#seterror
Actual behavior
The error is shown on Snackbar which is not visible.
Would you like to work on the issue?
No
Bug demo for more clarification:

I would like to work on this.

go ahead.

I completed it. Want to know the difficulty label of this issue?


fix(deps): update terraform github.com/terraform-ibm-modules/terraform-ibm-watsonx-saas-da to v1.4.5

This PR contains the following updates:

Package
Type
Update
Change

github.com/terraform-ibm-modules/terraform-ibm-watsonx-saas-da
module
patch
v1.4.4 -> v1.4.5

Release Notes

terraform-ibm-modules/terraform-ibm-watsonx-saas-da (github.com/terraform-ibm-modules/terraform-ibm-watsonx-saas-da)
v1.4.5
Compare Source
Bug Fixes

deps: update terraform terraform-ibm-modules/cos/ibm to v8.10.3 (#143) (e86e92f)

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

/run pipeline

:tada: This issue has been resolved in version 2.2.8 :tada:
The release is available on:

GitHub release
v2.2.8

Your semantic-release bot :package::rocket:


could not determine a constructor for the tag '!degrees'

Hi,
I have tried to install the ROS2 Driver with this Howto: https://github.com/UniversalRobots/Universal_Robots_ROS2_Driver
At the Driver Testing I got the following Error:
flo@DESKTOP-L4I9CIG:~$ ros2 launch ur_bringup ur_control.launch.py ur_type:=ur5e robot_ip:=yyy.yyy.yyy.yyy use_fake_hardware:=true launch_rviz:=true
[INFO] [launch]: All log files can be found below /home/flo/.ros/log/2021-07-08-13-15-59-881791-DESKTOP-L4I9CIG-138
[INFO] [launch]: Default logging verbosity is set to INFO
Task exception was never retrieved
future: <Task finished name='Task-2' coro=<LaunchService._process_one_event() done, defined at /opt/ros/galactic/lib/python3.8/site-packages/launch/launch_service.py:226> exception=SubstitutionFailure('executed command failed. Command: /opt/ros/galactic/bin/xacro /home/flo/workspace/ros_ws_foxy_ur_driver/install/ur_description/share/ur_description/urdf/ur.urdf.xacro robot_ip:=yyy.yyy.yyy.yyy joint_limit_params:=/home/flo/workspace/ros_ws_foxy_ur_driver/install/ur_description/share/ur_description/config/ur5e/joint_limits.yaml kinematics_params:=/home/flo/workspace/ros_ws_foxy_ur_driver/install/ur_description/share/ur_description/config/ur5e/default_kinematics.yaml physical_params:=/home/flo/workspace/ros_ws_foxy_ur_driver/install/ur_description/share/ur_description/config/ur5e/physical_parameters.yaml visual_params:=/home/flo/workspace/ros_ws_foxy_ur_driver/install/ur_description/share/ur_description/config/ur5e/visual_parameters.yaml safety_limits:=true safety_pos_margin:=0.15 safety_k_position:=20 name:=ur5e script_filename:=/home/flo/workspace/ros_ws_foxy_ur_driver/install/ur_robot_driver/share/ur_robot_driver/resources/ros_control.urscript input_recipe_filename:=/home/flo/workspace/ros_ws_foxy_ur_driver/install/ur_robot_driver/share/ur_robot_driver/resources/rtde_input_recipe.txt output_recipe_filename:=/home/flo/workspace/ros_ws_foxy_ur_driver/install/ur_robot_driver/share/ur_robot_driver/resources/rtde_output_recipe.txt prefix:="" use_fake_hardware:=true fake_sensor_commands:=false \nCaptured stderr output: error: could not determine a constructor for the tag \'!degrees\'\n  in "/home/flo/workspace/ros_ws_foxy_ur_driver/install/ur_description/share/ur_description/config/ur5e/joint_limits.yaml", line 18, column 19 \nwhen evaluating expression \'load_yaml(joint_limits_parameters_file)\' \nwhen evaluating expression \'__joint_limit_parameters[\'joint_limits\']\' \nwhen evaluating expression \'__limits[\'shoulder_pan\'][\'min_position\']\'\nwhen instantiating macro: read_model_data (/home/flo/workspace/ros_ws_foxy_ur_driver/install/ur_description/share/ur_description/urdf/inc/ur_common.xacro)\ninstantiated from: ur_robot (/home/flo/workspace/ros_ws_foxy_ur_driver/install/ur_description/share/ur_description/urdf/ur_macro.xacro)\nin file: /home/flo/workspace/ros_ws_foxy_ur_driver/install/ur_description/share/ur_description/urdf/ur.urdf.xacro\n')>
Traceback (most recent call last):
  File "/opt/ros/galactic/lib/python3.8/site-packages/launch/launch_service.py", line 228, in _process_one_event
    await self.__process_event(next_event)
  File "/opt/ros/galactic/lib/python3.8/site-packages/launch/launch_service.py", line 248, in __process_event
    visit_all_entities_and_collect_futures(entity, self.__context))
  File "/opt/ros/galactic/lib/python3.8/site-packages/launch/utilities/visit_all_entities_and_collect_futures_impl.py", line 45, in visit_all_entities_and_collect_futures
    futures_to_return += visit_all_entities_and_collect_futures(sub_entity, context)
  File "/opt/ros/galactic/lib/python3.8/site-packages/launch/utilities/visit_all_entities_and_collect_futures_impl.py", line 45, in visit_all_entities_and_collect_futures
    futures_to_return += visit_all_entities_and_collect_futures(sub_entity, context)
  File "/opt/ros/galactic/lib/python3.8/site-packages/launch/utilities/visit_all_entities_and_collect_futures_impl.py", line 45, in visit_all_entities_and_collect_futures
    futures_to_return += visit_all_entities_and_collect_futures(sub_entity, context)
  [Previous line repeated 1 more time]
  File "/opt/ros/galactic/lib/python3.8/site-packages/launch/utilities/visit_all_entities_and_collect_futures_impl.py", line 38, in visit_all_entities_and_collect_futures
    sub_entities = entity.visit(context)
  File "/opt/ros/galactic/lib/python3.8/site-packages/launch/action.py", line 108, in visit
    return self.execute(context)
  File "/opt/ros/galactic/lib/python3.8/site-packages/launch_ros/actions/node.py", line 465, in execute
    self._perform_substitutions(context)
  File "/opt/ros/galactic/lib/python3.8/site-packages/launch_ros/actions/node.py", line 420, in _perform_substitutions
    evaluated_parameters = evaluate_parameters(context, self.__parameters)
  File "/opt/ros/galactic/lib/python3.8/site-packages/launch_ros/utilities/evaluate_parameters.py", line 151, in evaluate_parameters
    output_params.append(evaluate_parameter_dict(context, param))
  File "/opt/ros/galactic/lib/python3.8/site-packages/launch_ros/utilities/evaluate_parameters.py", line 72, in evaluate_parameter_dict
    evaluated_value = perform_substitutions(context, list(value))
  File "/opt/ros/galactic/lib/python3.8/site-packages/launch/utilities/perform_substitutions_impl.py", line 26, in perform_substitutions
    return ''.join([context.perform_substitution(sub) for sub in subs])
  File "/opt/ros/galactic/lib/python3.8/site-packages/launch/utilities/perform_substitutions_impl.py", line 26, in <listcomp>
    return ''.join([context.perform_substitution(sub) for sub in subs])
  File "/opt/ros/galactic/lib/python3.8/site-packages/launch/launch_context.py", line 197, in perform_substitution
    return substitution.perform(self)
  File "/opt/ros/galactic/lib/python3.8/site-packages/launch/substitutions/command.py", line 119, in perform
    raise SubstitutionFailure(on_error_message)
launch.substitutions.substitution_failure.SubstitutionFailure: executed command failed. Command: /opt/ros/galactic/bin/xacro /home/flo/workspace/ros_ws_foxy_ur_driver/install/ur_description/share/ur_description/urdf/ur.urdf.xacro robot_ip:=yyy.yyy.yyy.yyy joint_limit_params:=/home/flo/workspace/ros_ws_foxy_ur_driver/install/ur_description/share/ur_description/config/ur5e/joint_limits.yaml kinematics_params:=/home/flo/workspace/ros_ws_foxy_ur_driver/install/ur_description/share/ur_description/config/ur5e/default_kinematics.yaml physical_params:=/home/flo/workspace/ros_ws_foxy_ur_driver/install/ur_description/share/ur_description/config/ur5e/physical_parameters.yaml visual_params:=/home/flo/workspace/ros_ws_foxy_ur_driver/install/ur_description/share/ur_description/config/ur5e/visual_parameters.yaml safety_limits:=true safety_pos_margin:=0.15 safety_k_position:=20 name:=ur5e script_filename:=/home/flo/workspace/ros_ws_foxy_ur_driver/install/ur_robot_driver/share/ur_robot_driver/resources/ros_control.urscript input_recipe_filename:=/home/flo/workspace/ros_ws_foxy_ur_driver/install/ur_robot_driver/share/ur_robot_driver/resources/rtde_input_recipe.txt output_recipe_filename:=/home/flo/workspace/ros_ws_foxy_ur_driver/install/ur_robot_driver/share/ur_robot_driver/resources/rtde_output_recipe.txt prefix:="" use_fake_hardware:=true fake_sensor_commands:=false
Captured stderr output: error: could not determine a constructor for the tag '!degrees'
  in "/home/flo/workspace/ros_ws_foxy_ur_driver/install/ur_description/share/ur_description/config/ur5e/joint_limits.yaml", line 18, column 19
when evaluating expression 'load_yaml(joint_limits_parameters_file)'
when evaluating expression '__joint_limit_parameters['joint_limits']'
when evaluating expression '__limits['shoulder_pan']['min_position']'
when instantiating macro: read_model_data (/home/flo/workspace/ros_ws_foxy_ur_driver/install/ur_description/share/ur_description/urdf/inc/ur_common.xacro)
instantiated from: ur_robot (/home/flo/workspace/ros_ws_foxy_ur_driver/install/ur_description/share/ur_description/urdf/ur_macro.xacro)
in file: /home/flo/workspace/ros_ws_foxy_ur_driver/install/ur_description/share/ur_description/urdf/ur.urdf.xacro

I got the same Error when I try to connect to a URSim in VMWare.
Thank you in advance.
Best regards
Florian

@destogl thanks for linking. I am eagerly waiting for a solution.

@NebuDa for what I can tell, this is a Galactic-related issue. something has changed there in xacro parsing or similar, which is breaking this. If you need this soon I propose to use Foxy.

Changed ROS2 to Foxy and now it works. Should I close the Issue, or let it open for future Galactic integration?

solved in #166


"increment_build_number" and "increment_version_number" fail to update main info.plist file.

New Issue Checklist

[x] Updated fastlane to the latest version
[X] I have read the Contribution Guidelines

Issue Description
Running the "increment_build_number" and "increment_version_number" actions correctly increments the values everywhere apart from the main info.plist file for the app. The "Current Project Version" value is incremented successfully for both the Project, and the two targets (app and tests). The plist for the tests target is also incremented successfully, however only the main plist for the app is left out. This of course means that the builds uploaded to Hockey have incorrect build and version numbers.
Complete output when running fastlane, including the stack trace and command used
SBB-MacBook-Pro:Rec.IT sbb.moko$ fastlane hockey
[14:25:33]: -------------------------------------------------
[14:25:33]: --- Step: Verifying required fastlane version ---
[14:25:33]: -------------------------------------------------
[14:25:33]: fastlane version valid
[14:25:33]: ------------------------------
[14:25:33]: --- Step: default_platform ---
[14:25:33]: ------------------------------
[14:25:33]: Driving the lane 'ios hockey' 🚀
[14:25:33]: ------------------------------------
[14:25:33]: --- Step: increment_build_number ---
[14:25:33]: ------------------------------------
[14:25:33]: $ cd /Users/sbb.moko/Documents/Rec.IT && agvtool next-version -all
[14:25:33]: ▸ Setting version of project REC.IT to:
[14:25:33]: ▸ 550.
[14:25:33]: ▸ Also setting CFBundleVersion key (assuming it exists)
[14:25:33]: ▸ Updating CFBundleVersion in Info.plist(s)...
[14:25:33]: ▸ Updated CFBundleVersion in "REC.IT.xcodeproj/../REC.ITUITests/UITestInfo.plist" to 550
[14:25:33]: ▸ Updated CFBundleVersion in "REC.IT.xcodeproj/../Rec.IT/REC.IT-Info.plist" to 550
[14:25:34]: ------------------
[14:25:34]: --- Step: sigh ---
[14:25:34]: ------------------

+-------------------------------------+---------------------------------+
|                        Summary for sigh 1.4.0                         |
+-------------------------------------+---------------------------------+
| adhoc                               | true                            |
| force                               | true                            |
| skip_install                        | false                           |
| development                         | false                           |
| app_identifier                      | com.mokosocialmedia.Rec-IT      |
| username                            |<EMAIL_ADDRESS>|
| ignore_profiles_with_different_name | false                           |
| skip_fetch_profiles                 | false                           |
| skip_certificate_verification       | false                           |
+-------------------------------------+---------------------------------+

[14:25:34]: Starting login with user<EMAIL_ADDRESS>[14:25:38]: Successfully logged in
[14:25:38]: Fetching profiles...
[14:25:49]: Found 3 matching profile(s)
[14:25:49]: Updating the profile to include all devices
[14:25:55]: Downloading provisioning profile...
[14:25:56]: Successfully downloaded provisioning profile...
[14:25:56]: Installing provisioning profile...
/Users/sbb.moko/Documents/Rec.IT/fastlane/provisioning/AdHoc_com.mokosocialmedia.Rec-IT.mobileprovision
[14:25:56]: Setting Provisioning Profile type to 'ad-hoc'
[14:25:56]: --------------------------------------
[14:25:56]: --- Step: increment_version_number ---
[14:25:56]: --------------------------------------
[14:25:57]: $ cd /Users/sbb.moko/Documents/Rec.IT && agvtool new-marketing-version 2.6.2
[14:25:57]: ▸ Setting CFBundleShortVersionString of project REC.IT to:
[14:25:57]: ▸ 2.6.2.
[14:25:57]: ▸ Updating CFBundleShortVersionString in Info.plist(s)...
[14:25:57]: ▸ Updated CFBundleShortVersionString in "REC.IT.xcodeproj/../REC.ITUITests/UITestInfo.plist" to 2.6.2
[14:25:57]: ▸ Updated CFBundleShortVersionString in "REC.IT.xcodeproj/../Rec.IT/REC.IT-Info.plist" to 2.6.2

Configuration Files
Please copy the complete content of your Fastfile and any other configuration files you use below:
Fastfile:
# This is the minimum version number required.
# Update this, if you use features of a newer version
fastlane_version "1.37.0"

default_platform :ios

platform :ios do
  before_all do
  end

  desc "Bump build number, commit & push to remote"
  lane :incrementBuild do

    # Bump build number
    increment_build_number

    # Commit and push to remote
    commit_version_bump(
      message: 'Build number bump by fastlane - buildnumber lane',
      force: true
    )
    push_to_git_remote
  end

  desc "Deploy a new build via HockeyApp"
  lane :hockey do

    # Bump build number
    increment_build_number

    # Download and install the latest AdHoc profile
    sigh(
      adhoc: true,
      force: true,
      output_path: "./fastlane/provisioning"
    )

    # Set version number to the one at the top of the CHANGELOG
    readme = File.read("../CHANGELOG.md")
    latest_version = readme.split("\n## ").first
    first_line = latest_version.split("\n").first
    version_number = first_line.split(" ")[1]

    increment_version_number(
        version_number: version_number
    )

    # Generate release notes from CHANGELOG
    release_notes = latest_version.split("\n")[1..-1].join("\n")
    puts release_notes

    # Create the IPA file - save in Temp folder
    profileUDID = lane_context[SharedValues::SIGH_UDID]
    puts "Profile UUID: #{profileUDID}"
    gym(
      xcargs: "PROVISIONING_PROFILE=#{profileUDID}",
      scheme: "xxxxxxx",
      silent: true
    )

    # Deploy via HockeyApp
    markdown_type = '1'
    hockey(
      api_token: 'xxxxxxxxxxxxxxxxxxxxxxxxxxx',
      notes_type: markdown_type,
      notes: release_notes
    )

    # Make sure our directory is clean, except for changes Fastlane has made
    clean_build_artifacts

    # Commit and push to remote
    commit_version_bump(
      message: 'Build number bump by fastlane - hockey lane',
      force: true
    )
    push_to_git_remote
  end

  desc "Upload a new build to iTunesConnect"
  lane :itunes do

    # Bump build number
    increment_build_number

    # Make sure everything is committed
    ensure_git_status_clean

    # Download and install the latest App Store profile
    sigh(
      output_path: "~/Documents/Temp"
    )

    # Create the IPA file - save in Temp folder
    gym(
      scheme: 'xxxxxx',
      silent: true,
      output_directory: "~/Documents/Temp/"
    )

    # Just upload the build - do nothing else
    deliver(
      skip_screenshots: true,
      skip_metadata: true,
      automatic_release: false,
      submit_for_review: false
    )

    # Make sure our directory is clean, except for changes Fastlane has made
    clean_build_artifacts

    # Commit and push to remote
    commit_version_bump(
      message: 'Build Version Bump by fastlane',
      force: true
    )
    push_to_git_remote
  end

  after_all do |lane|
    # This block is called, only if the executed lane was successful
  end

  error do |lane, exception|
  end
end

Environment
fastlane version (fastlane -v): v1.66.0
Do you use bundler, rbenv or rvm? NO

I just ran the following lane:
  lane :inc
    increment_build_number
  end

My project's CFBundleVersion value was incremented as expected.
Have you setup your Xcode project per https://developer.apple.com/library/ios/qa/qa1827/_index.html?

Yes, Current Project Version and Versioning System are set correctly for both the Project, and both targets.
The plists are also setup correctly as described on that Apple doc.
On Wed, 09 Mar 2016 at 6:32 AM Val Polouchkine
<
mailto:Val Polouchkine<EMAIL_ADDRESS>
wrote:

I just ran the following lane:
lane
:inc
increment_build_number
end
My project's
CFBundleVersion
value was incremented as expected.
Have you setup your Xcode project per
https://developer.apple.com/library/ios/qa/qa1827/_index.html
?
—
Reply to this email directly or
https://github.com/fastlane/fastlane/issues/3602#issuecomment-193999097
.
https://github.com/fastlane/fastlane/issues/3602#issuecomment-193999097

Hey!
I've had the same problem with my fastlane configuration. I've just solved it, but the fix is very strange.
At my fastlane configuration I also use update_app_identifier action. If the increment_build_number action is below the update_app_identifier action then the fastlane doesn't increase the build number. On the other hand, it** has stared to work** after I had moved the increment_build_number above the update_app_identifier action. It's strage, but "it works". I hope I've helped.
Working configuration
...
     increment_build_number(
        build_number: build_number
      )
      update_app_identifier(
        xcodeproj: "#{options[:project_name]}.xcodeproj",
        plist_path: "#{options[:project_name]}/Info.plist",
        app_identifier: options[:app_identifier]
      )
...

Broken configuration
...
      update_app_identifier(
        xcodeproj: "#{options[:project_name]}.xcodeproj",
        plist_path: "#{options[:project_name]}/Info.plist",
        app_identifier: options[:app_identifier]
      )
      increment_build_number(
        build_number: build_number
      )
...

Thanks for the report @TheAdamBorek. Glad you're up and running. The OP didn't post here in a while, so I'm going to close this.

Thanks for your help @vpolouchkine & @TheAdamBorek. I'm no longer involved with the project where I was seeing that issue, and it is working perfectly on my current projects, so hopefully it was just a "one off"! Definitely safe to close this.


Long-pressing swapped keys performs erratically

Thank you for your efforts on Karabiner!
While trying latest Elements I have noticed that when swapping the backspace key with backslash and then holding a backslash the input stutters and even hangs completely sometimes. Here are my settings:
{
    "profiles": [
        {
            "name": "Default profile",
            "selected": true,
            "simple_modifications": {
                "delete_or_backspace": "backslash",
                "backslash": "delete_or_backspace"
            }
        }
    ]
}

I've improved the key repeat handling at v0.90.36.
Could you confirm whether this issue has fixed in the latest version?
You can upgrade to the latest version from "Misc > Check for updates" or
https://pqrs.org/latest/karabiner-elements-latest.dmg

Works perfectly! Thank you!


adds debugging for CorruptMessage errors

Adds error logging when message corruption errors are received.

I've release v0.7.1.messagecorruptiondebug with this code.

There's a functional spec failing for some reason, is this normal?

Yup


Memory leak

After about two days of operation, it has accumulated 1.8 GiB of RSS. This seems very excessive.

I run a3ce328d, process uptime 46h (dockered), checking c2s_normal_auth from example.yml on two servers every 30 seconds. RSS is about 8 MiB. If that helps :)

@hnrd Thanks for sharing. Which probers do you use? I suspect the ping prober might be the culprit.


Proposal: Developing Desert Hunter Game with KAIA, stunning UI, and gameplay to enrich the player experience like never before

Description:

Breathtaking graphics: Stunning, meticulously detailed visuals that captivate players.
Polished design: Every element crafted for a seamless and immersive experience.
KAIA integration: Enriching gameplay with advanced blockchain technology.
Engaging gameplay: Action-packed desert adventures to keep you hooked.
Innovative development: Leveraging cutting-edge tools for an exceptional game.
Smooth UI: Intuitive and sleek interface for effortless navigation.

Bounty track

Other

Video: https://www.youtube.com/watch?v=5PGLLgTiLxw
Play Game: https://trandrewsg91.itch.io/kaia-desert-hunter-game
Git: https://github.com/trandrewsg91/Desert-Hunter-Game-On-Kaia
Twitter: https://x.com/TranDrew251678/status/1866103552424497364

Approved for 1120 KAIA with a 50% penalty = 560 KAIA

closing


Windows agent should be configured for Windows Certificate Store by default

Agent Version and Platform
2.136.1
OS of the machine running the agent?
Windows
Azure DevOps Type and Version
on-premises TFS
16.131.28226.3
What's not working?
To get the windows agent to run completely with a TFS server using self-signed SSL certificate I need to configure manually:
config.cmd --gituseschannel --sslcacert ./locationtoyourcert.pem

The one option is required for git fetch, the other is required to (explicitly download artifacts e.g. using 'Download Build Artifacts' task).
Is it possible to configure the agent by default to use the Windows Certificate Store?

@lg2de that's a little bit hard, the agent is an dotnet core application, it's already use Windows cert store. the problem is all the different tools you may use during your pipeline, i don't think there is a universal way to force everything to use windows cert store, plus some linux tool that built on old version openssl may not support windows cert store at all. :)

The package is for window, so it "knows" it is for windows.
The batch file (config.cmd) is specific for windows. I could set required options internally.

i am talking about all the different tools you used during the build, like npm, node, python, go, etc, they may have no idea about windows certificate store. :)

I'll create a PR to illustrate my thoughts.

@TingluoHuang I analyzed the code.
I found that the option gituseschannel is for Windows only.
I do not see any reason why we should not use SChannel by default.
Would you accept a PR changing default behavior?
Do we need an option to disable SChannel by default?

@vtbassmatt to help. :)

Seems like a potentially back-compat breaking change with very limited positive effects. Unlikely to take that as a PR, sorry.

@vtbassmatt, I wonder how you come up with "limited positive effects".
I can't imagine who wouldn't want to use the certificate store in Windows.

@lg2de it's limited because, for anyone for whom this matters, they're already specifying -gituseschannel at config time. For everyone else, the change is neutral (vast majority of cases) or potentially harmful (misconfiguration where OpenSSL knows about a corporate root CA but Windows cert store doesn't, for example).
Yes, I wish SChannel was the default on Windows. And we're looking at ways to safely introduce that change.

@vtbassmatt I doubt if many users are specifying -gitusschannel when configuring the Agent.
This option is nowhere mentioned in the docs and not mentioned in the config.cmd --help. How would they know about this option?
Except by searching the Agent's source code and finding this issue. At least that's how I found out.
Please document this usefull option!

Hm, it should be reported in help now. I'll investigate why it's not.

Ah, got it. We didn't actually replace our hard-coded help page in the agent. I'll go get this one added.

https://github.com/microsoft/azure-pipelines-agent/pull/2940


[BitbucketLastCommit] Add Bitbucket last commit

Add support for Bitbucket last commit: https://developer.atlassian.com/cloud/bitbucket/rest/api-group-commits/#api-repositories-workspace-repo-slug-commits-revision-get

It would be possible split this current implementation into separate branch and non-branch variations (like the GitHub, GitLab and Gitea services do), but as far as I can see this would require an preliminary request to /repositories/{user}/{repo} to resolve the main branch:
GET https://bitbucket.org/api/2.0/repositories/shields-io/test-repo?fields=mainbranch
{
    "mainbranch": {
        "name": "main",
        "type": "branch"
    }
}

Happy to implement, but let me know what you think.

It would be possible split this current implementation into separate branch and non-branch variations (like the GitHub and Gitea last commit API), but as far as I can see this would require an preliminary request to /repositories/{user}/{repo} to resolve the main branch:

Given BitBucket doesn't give us a way to get the default branch without making an extra request, I think it is fine to just say branch is a required param. That is what we have done for the BitBucket Pipelines badge.
There's a bit of background on this in https://github.com/badges/shields/pull/5318 and the linked issues

nice - thanks :+1:


4.3 o7s triggers/timeline working incorrectly

Say it starts as dadaluma, it will tell me its bibliotecha and cause multitude of issues

This sounds the same as issue #138 and issue #123. Have you updated to https://github.com/ravahn/FFXIV_ACT_Plugin/releases/tag/v<IP_ADDRESS>?

No I hadn't, I never know when there's an update because ACT just tells me there's an update 24/7

Ok! I'll mark this as fixed, then.  Glad that was it!


Add role Icinga Web 2

This PR will introduce the feature to configure, manage Icinga Web 2 and its modules. It allows for the following features:

Manage Resources.ini
Manage authentication.ini
Manage config.ini
Manage Groups.ini
Import DB Schema
Create Admin Users and Permissions
Manage Module Monitoring
Manage Module IcingaDB
Manage Module Director, Import Schema and run Kickstart

Currently tested OSs

Ubuntu 22.04.2 LTS

Future Plans:

Add installation routine for modules from source/git.
Add more modules like Businessprocess/graphite/cube etc.
Add a generic module installation with or without configuration for community modules?

Ref: #31

Updated the Build, all the linter issues can be worked on later.

LGTM, if we fix the linter issues separately.


Cloning a PR repo freezes a build image

In a release image we can load the repo for a Pull Request, for example: https://github.com/mariari/lepiter.git.
But if we try this in a build image, i.e., that already contains a checked out repo from which the PR is forked, then the image freezes.

It could be useful to try this again.
A general remark is though that IceRepository registry is an OrderedCollection used by IceRepository name, having two of those with the same name is possible but will lead to conflicts.
It is probably better to forget the old one before creating the new one.

I added an implementation of both the fork and PR creation through the GitHub REST API (in class GtGitHubAPITool).
It seems to work just fine.
This also gives us options to query various aspects of GitHub objects that are often hard to get (is a repo a fork, what is the parent/source, etc).


Custom dialog appears when discarding a change with RemoteHub extension

I am not sure the origin so assigning a few people. Steps:

install RemoteHub extension on desktop
open a repo via desktop
do a change
discard the change

=> 🐛  you get a custom dialog even though I would have expected a native one.

Oh, looks like this may have been intentional: https://github.com/microsoft/vscode-remotehub/commit/6167c9a296974befb0d46377d12e2da17d90e19c

Closing as I have dropped all usage of custom dialogs in RemoteHub.


the rviz lost some depth img

Required Info |
-- | --
Camera Model | SR300
Operating System & Version | ubuntu
Platform | PC
Language | C++ ROS
I run this commend
roslaunch realsense2_camera rs_rgbd.launch
and I find that the rviz without many black region
First image

When I add one white paper in that place that‘s ok

[Please Ignore - RealSense system comment]

Close this issue for lack of activity. Please feel free to reopen if the issue is still relevant.