Panic on windows path C:\

https://github.com/oxc-project/oxc-resolver/blob/dbe3a22997a309292d5381e9dac9cfae09510630/src/path.rs#L69

@Boshen is the above fix going to be in the newly released 0.5.5 version?

@Boshen is the above fix going to be in the newly released rspack 0.5.5 version which I believe also has the bump up for oxc-resolver?

Yes, 0.5.5 includes this change https://github.com/web-infra-dev/rspack/releases/tag/v0.5.5

fix: bump oxc-resolver to fix windows path by @Boshen in https://github.com/web-infra-dev/rspack/pull/5722


Exception: getUploadUrl command is not supported.

Description
When i runing the example code about upload files from file picker(https://github.com/flet-dev/examples/blob/main/python/controls/file-picker/file-picker-upload-progress.py) and remove the web view, return this error: "Exception: getUploadUrl command is not supported.". How can i upload files from file picker in desktop app?.
Sorry for my bad english.
My code:
from typing import Dict

import flet
from flet import (
    Column,
    ElevatedButton,
    FilePicker,
    FilePickerResultEvent,
    FilePickerUploadEvent,
    FilePickerUploadFile,
    Page,
    ProgressRing,
    Ref,
    Row,
    Text,
    icons,
)

def main(page: Page):
    prog_bars: Dict[str, ProgressRing] = {}
    files = Ref[Column]()
    upload_button = Ref[ElevatedButton]()

    def file_picker_result(e: FilePickerResultEvent):
        upload_button.current.disabled = True if e.files is None else False
        prog_bars.clear()
        files.current.controls.clear()
        if e.files is not None:
            for f in e.files:
                prog = ProgressRing(value=0, bgcolor="#eeeeee", width=20, height=20)
                prog_bars[f.name] = prog
                files.current.controls.append(Row([prog, Text(f.name)]))
        page.update()

    def on_upload_progress(e: FilePickerUploadEvent):
        prog_bars[e.file_name].value = e.progress
        prog_bars[e.file_name].update()

    file_picker = FilePicker(on_result=file_picker_result, on_upload=on_upload_progress)

    def upload_files(e):
        uf = []
        if file_picker.result is not None and file_picker.result.files is not None:
            for f in file_picker.result.files:
                uf.append(
                    FilePickerUploadFile(
                        f.name,
                        upload_url=page.get_upload_url(f.name, 600),
                    )
                )
            file_picker.upload(uf)

    # hide dialog in a overlay
    page.overlay.append(file_picker)

    page.add(
        ElevatedButton(
            "Select files...",
            icon=icons.FOLDER_OPEN,
            on_click=lambda _: file_picker.pick_files(allow_multiple=True),
        ),
        Column(ref=files),
        ElevatedButton(
            "Upload",
            ref=upload_button,
            icon=icons.UPLOAD,
            on_click=upload_files,
            disabled=True,
        ),
    )

flet.app(target=main, upload_dir="uploads")

Issues:

Flet version:
Name: flet
Version: 0.10.1
Summary: Flet for Python - easily build interactive multi-platform apps in Python
Home-page:
Author: Appveyor Systems Inc.
Author-email<EMAIL_ADDRESS>License: Apache-2.0
Location: C:\Users\conta\AppData\Local\Programs\Python\Python311\Lib\site-packages
Requires: copier, flet-runtime, packaging, qrcode, watchdog, websocket-client, websockets
Required-by:

Operating system:
Windows

https://www.youtube.com/watch?v=Z0luQoMchNA
Hi! I Found this example.
Credits to Sri Edy Nurcahyo.

https://www.youtube.com/watch?v=Z0luQoMchNA Hi! I Found this example. Credits to Sri Edy Nurcahyo.

This method somehow the files from file_picker.result have path attribute as None. Any alternate fix to this issue?


 This makes it hard to maintain, so we need to reorganize it.
Also fix src/test/moment/format.js which iterates over almost all locales ...

Close because #2850 was merged


Ida UI text refactor

Make the naming convention less confusing on first glance, add ability to change these on the fly without hardcoded strings.

Nice stuff


vuex store state function-properties are undefined only inside the browser

Basically any form of fun is being removed and not defined in the browser, while still being accessible in the server side rendering.
new Vuex.Store({
  state: {
    fun: () => false,
    bar: { fun: function(){ return false} },
  ...

Vuex state should be serializable (i.e. if it will be discarded during JSON.stringify then it is not safe to use).


Add error checking to threads - ensure an integer is passed

phrokka version: v 1.2.1
Python version: 3.10
Operating System: Mac OS

Description
Pharokka crashes is a non-integer is passed as -t.
Add error correction in the next update.

Also in meta mode print number of contigs

Closed in v1.3.0


HDDS-7974. [Snapshot] KeyDeletingService to be aware of Ozone snapshots

What changes were proposed in this pull request?
Refactored KeyDeletingService to accommodate deleting keys from snapshot DB's deletedTable.

Add support for snapshots in OMKeyPurgeRequest and OMKeyPurgeResponse
Abstracted common code for both SnapshotDeletingService and KeyDeletingService into AbstractKeyDeletingService
Added getBlocksForKeyDelete() which gets the BlockGroup for a single key from OmKeyLocationInfoGroup

What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-7974
How was this patch tested?
Unit test and Existing test.

Thanks @smengcl for the review.


Update README with guides for GCC evaluation and docker-free compilations

Add a user guide for GCC evaluation: How to build GCC, configure to run GCC and getting the packet- and frame-level QoE metrics
Guide on build options: Recommend source build for quick local development, and docker-based build for deployment

Closes #101, #102.

Will be addressed in #104


Tesseract OCR LED/LCD display text recognition

Hi All,
I am trying to detect the numeric values from the digital display LED/LCD(Remote and other devices). Integrated the tesseract along with GPUImage and used the trained data. But it's not giving a proper result.
Here is the code:
let tesseract: G8Tesseract = G8Tesseract(language: "eng")!
tesseract.delegate = self
tesseract.charWhitelist = "0123456789:"
tesseract.charBlacklist = "abcdefghijklmnopqrstuvwxyz_+-=/?.,><()*&^%$#@!:;"
let imageCheck = UIImage(named: "remote1.jpg")//Sample image, but we need to capture the image from camera then used it
let scaledImage = newImage?.scaledImage(1000)
let preprocessedImage = scaledImage?.preprocessedImage() ?? scaledImage
if let tesseract = G8Tesseract(language: "eng") {
tesseract.engineMode = .tesseractOnly
tesseract.pageSegmentationMode = .auto
        //Auto Adjustment to Input Image
        var inputImage = CIImage(image: preprocessedImage!)
        let options:[CIImageAutoAdjustmentOption : AnyObject] = [.enhance:1 as AnyObject]
        let filters = inputImage!.autoAdjustmentFilters(options: options)

        for filter: CIFilter in filters {
           filter.setValue(inputImage, forKey: kCIInputImageKey)
       inputImage =  filter.outputImage
          }
        let cgImage = context.createCGImage(inputImage!, from: inputImage!.extent)
        tesseract.image =  UIImage(cgImage: cgImage!)

        //Apply noir Filter
        let currentFilter = CIFilter(name: "CIPhotoEffectTonal")
        currentFilter!.setValue(CIImage(image: UIImage(cgImage: cgImage!)), forKey: kCIInputImageKey)

        let output = currentFilter!.outputImage
        let cgimg = context.createCGImage(output!, from: output!.extent)
        let processedImage = UIImage(cgImage: cgimg!)
        tesseract.image = processedImage
       // tesseract.image = preprocessedImage!
       tesseract.recognize()
        debugPrint("Text: \(String(describing: tesseract.recognizedText))")

}
Scaled image reference get from: https://www.kodeco.com/2010498-tesseract-ocr-tutorial-for-ios
O/P which is am getting:
Optional(" 9 9\n  11593  7\n 1 80\n \n0\n5533\n\n")"

Expected O/P: 25 and 5:21
Could you anyone guide me to resolve this.
Thanks!

Query posted in respective GitHub.


I use ‘jfrog xr am’ to scan source code，It can only report the dependency security issue，but it can‘t report transitive dependency security issue，but it can be found in xray，why？

I use ‘jfrog xr am’ to scan source code，It can only report the dependency security issue，but it can‘t report transitive dependency security issue，but it can be found in xray，why？

@liwei2151284 -
The jfrog xr am command scans all of your project depedencies - both direct and transitive (indirect). The command output displays only vulnerable dependencies (and allows filtering them out according to your Xtay policy).
Can you therefore ellaborate more about the issue you're seeing? Which vulnerable depedencies do you not see as part of the command output?

@eyalbe4 Thank you for answering my question
I use “jfrog xr am” without "--watch", maybe means it can report all of the secruity issues.but I can only see the direct dependency issues.
My pom file：

If I use 'jfrog xr am' ,my scan report:

Dependancy tree:

If I use 'jfrog xr s xxx.jar',my scan report all security issues:

My source code:
https://github.com/liwei2151284/Guestbook-microservices-k8s/tree/master/gateway-service

@liwei2151284 -
It looks like dependencies such as ch.qos.logback:logback-core are indeed packed inside your getway-service.jar. And by running jfrog xr s getway-service.jar, Xray identified these packed depedencies and their vulnerabilities.
I can see though that ch.qos.logback:logback-core is not included in the dependencies tree output yuo shared. Is it indeed not there, or you just haven't shared the entire output?
If it is not there there, could it be that these depedencies make into your getway-service.jar from somewhere else during your build? If they do, then the jfrog xr am command, which does not build the code, but just compiles it with maven to find its dependencies, can't be aware of them.
Please let us know what you think.

@eyalbe4  Thanks for answering my question
This is all my dependency tree，you can see logback-core is in it.

Hi @liwei2151284, thanks again for reporting this issue and also for the detailed logs.
We found the issue that caused the missing dependencies in maven-audit and fixed it.
We will update here as soon as the fix will be released.

Hi @liwei2151284,
We just released JFrog CLI 2.6.2 which fixes this issue.
We'd appreciate your feedback on it.
Sorry for the inconvenience caused by this.

Hi @sverdlov93
Thank you very much ,I've already upgrade JFrog CLI 2.6.2, and it worked well.


Renaming for spacedock.info

SETI-BalanceMod from kerbalstuff renamed to SETI-Rebalance for spacedock.info, I ll adjust my metadata as soon as I have the new spacedock id.
I can not find any dependencies or references within netkan on the former "SETI-BalanceMod" identifier.
And with kerbalstuff gone, this is the ideal point in time for a name change.

this is the ideal point in time for a name change.

Not really, existing users won't have an upgrade path so you'll split your userbase. If you're dead-set on changing the identifier the best time for that is when 1.1 is released and everyone will assume they need to start from scratch with mods.

Hm, makes sense.
I did not plan to update the mod before ksp 1.1 and wanted to prevent users from ckan installing it with the current identifier when 1.1 hits and I m not available to make the change.
But since 1.1 will break a lot of mods anyway I guess changing it then will be better than removing the update option now (without knowing a 1.1 release date, might still be weeks away).
Pull request can be closed.
Thank you for your input!

Closed by authors request


hotfix/parking -> dev

This change is

Reviewed 2 of 2 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

byuSuite/Apps/Parking/controller/MyVehiclesViewController.swift, line 217 at r1 (raw file):

				if error == nil {
					self.loadData()
					super.displayAlert(title: "Success", message: "Successfully activated vehicle. Be aware that it can take up to 10 minutes in some cases for privileges to reflect on this vehicle.", alertHandler: nil)

15

byuSuite/Apps/Parking/controller/VehicleViewController.swift, line 76 at r1 (raw file):

						super.displayAlert(error: error, title: "Activation Failed")
					} else {
						super.displayAlert(title: "Success", message: "Successfully activated vehicle. Be aware that it can take up to 10 minutes in some cases for privileges to reflect on this vehicle.", alertHandler: { (_) in

15

Comments from Reviewable

Review status: all files reviewed at latest revision, 2 unresolved discussions.

a discussion (no related file):
Add to vehicle registering

Comments from Reviewable

Review status: 0 of 3 files reviewed at latest revision, 3 unresolved discussions.

a discussion (no related file):
Previously, romrell4 (Eric Romrell) wrote…
Add to vehicle registering

Done.

byuSuite/Apps/Parking/controller/MyVehiclesViewController.swift, line 217 at r1 (raw file):
Previously, romrell4 (Eric Romrell) wrote…
15

Done.

byuSuite/Apps/Parking/controller/VehicleViewController.swift, line 76 at r1 (raw file):
Previously, romrell4 (Eric Romrell) wrote…
15

Done.

Comments from Reviewable

Reviewed 3 of 3 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.

byuSuite/Apps/Parking/controller/AddEditVehicleViewController.swift, line 220 at r2 (raw file):

					if let vehicle = vehicle {
						self.editVehicle = vehicle
						super.displayAlert(title: "Success", message: "Your vehicle has been successfully edited. Be aware that it can take up to 15 minutes in some cases for privileges to reflect on this vehicle.", alertHandler: { (_) in

This one isn't needed

Comments from Reviewable

Review status: 2 of 3 files reviewed at latest revision, 1 unresolved discussion.

byuSuite/Apps/Parking/controller/AddEditVehicleViewController.swift, line 220 at r2 (raw file):
Previously, romrell4 (Eric Romrell) wrote…
This one isn't needed

Done.

Comments from Reviewable

Reviewed 1 of 1 files at r3.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable


removed write in second and third archive

removed write in second and third archive when the points don't fit in first archive. This behavior  is considered a bug

turns out some clients write in lower archives and aggregate data themselves. Closing PR


Radius Blog homepage is bare

navigating to https://blog.radapp.io/ shows you a blank page which is pretty boring. we should consider adding some content to this page or just linking to https://blog.radapp.io/posts instead.

AB#12901

add redirect to https://blog.radapp.io/posts


Bad/unreliable data

PSA to anyone looking to use this data -
Looking through the JSON it appears that the data is very, very inaccurate. Here is an example of what I mean:
{"id":6990,"country":"Canada","state":"Alberta","city":"Manitoba"},
{"id":6991,"country":"Canada","state":"Alberta","city":"Newfoundland and Labrador"},
{"id":6992,"country":"Canada","state":"Alberta","city":"Northwest Territories"},
{"id":6993,"country":"Canada","state":"Alberta","city":"Nunavut"},
{"id":6994,"country":"Canada","state":"Alberta","city":"Saskatchewan"},
{"id":6995,"country":"Canada","state":"Alberta","city":"Wood Buffalo"},
{"id":6996,"country":"Canada","state":"Alberta","city":"Yukon"},

That is 100% of the data for my province. Only 1 of those is an actual city, the rest are the names of OTHER PROVINCES. The data for British Columbia is missing Vancouver and Victoria, Toronto isn't listed under Ontario, etc
The data for Canada is very, very wrong and missing a tonne of entries. This is probably the case for the entire dataset. Last update was 2 years ago so I doubt this will change so this serves as more of a PSA to anyone looking at this repo.

Same with Russia
{"id":27997,"country":"Russia","state":"Moskovskaya","city":"Aeroport District"},
{"id":27998,"country":"Russia","state":"Moskovskaya","city":"Akademichesky District"},
{"id":27999,"country":"Russia","state":"Moskovskaya","city":"Alexeyevsky District"},
{"id":28000,"country":"Russia","state":"Moskovskaya","city":"Altufyevsky District"},
{"id":28001,"country":"Russia","state":"Moskovskaya","city":"Arbat District"},
...
Mentioned above are districts of the city of Moscow.
District in Russia is an equivalent of county or even neighborhood in US, not city.
In addition it's Moskovskaya Oblast, Leningradskaya Oblast and etc.


Dev

This is a comment

FYI, let me know if you want me to size the images better so they aren't so huge...Markdown looks to just thrown whatever the default image size in but it looks like I can add real img tags and size things that way if preferable.

With the BGI caveat, I think this now looks good enough for a merge to dev.

Hey @logichammer - content is all good! I have some questions about where content is placed.

I like your annotated image of the hardware setup, and we've previously had one embedded, but got feedback that it prevents people from getting to the critical written content in the readme. How about revising the second sentence of the second paragraph (currently "(Click here to view an image of the common physical components of an OpenAPS setup.)") to something like "(Here are two visuals to show you what the physical hardware components of an OpenAPS setup look like - version A is without labels; version B contains labels to describe the parts.)" (Yours obviously would be Version B, or however you want to differentiate between the two, and we'd hyperlink them instead of embedding.)

Your NS explanation is great! Did you see the added Visualization section, though, in phase 3? Wondering if you could review it (https://github.com/openaps/docs/blob/dev/docs/Automate-system/vizualization.md) and see what you think about integrating all of your content in that page? (I'd vote to do that for now, and we can discuss if the Visualizations/Monitoring page should get moved from under Phase 3 to Phase 2, but would probably be separate from using-oref0-tools regardless, since that's a huge page in of itself.)

Thoughts?

FYI, took Ella snow camping Friday afternoon and just now getting back into
things...I should be able to make these changes tonight!
Personally, I think the documentation needs some images out front to
inspire folks / break up some of the dense technical jargon...show them the
reward for figuring out everything...heck, a NS with Basal graph showing
perfect numbers after doing something like eating pizza would be super
inspiring.  If scrolling is a barrier for folks, this project might be too
much. You could say the same about making folks having to click through to
see images but I think showing folks what the reward is up front, will
inspire them to delve deeper.  Seeing one of Dana's graphs was the reason I
got all hot and bothered to sit even more in front my computer.  "What if
those could be Ella's number?".  Just my two cents.  I'll make them link
but wanted to give you my take on it.
No,  totally missed the piece about Visualization (I want to add the phrase
Nightscout in there because that's what I was scanning for).  I'll see
about merging everything.
Thanks folks and see you soon!
Matt
PS In person questions I'll have:
Can you tell us more about the two other routes (increased range and
miniaturization)?
Are you OK with promotion / getting the word out?  If so, guidelines?
Guidelines for onboarding new folks that I personally know with T1D?  I'm
following whatever rules you guys layout...not going to go rogue.
Other areas that need documentation?  The two different routes referenced
above?
On Thu, Jan 28, 2016 at 10:55 AM, Dana Lewis<EMAIL_ADDRESS>wrote:

Hey @logichammer https://github.com/logichammer - content is all good!
I have some questions about where content is placed.

I like your annotated image of the hardware setup, and we've
previously had one embedded, but got feedback that it prevents people from
getting to the critical written content in the readme. How about revising
the second sentence of the second paragraph (currently "(Click here to view
an image of the common physical components of an OpenAPS setup.)") to
something like "(Here are two visuals to show you what the physical
hardware components of an OpenAPS setup look like - version A is without
labels; version B contains labels to describe the parts.)" (Yours obviously
would be Version B, or however you want to differentiate between the two,
and we'd hyperlink them instead of embedding.)
Your NS explanation is great! Did you see the added Visualization
section, though, in phase 3? Wondering if you could review it (
https://github.com/openaps/docs/blob/dev/docs/Automate-system/vizualization.md)
and see what you think about integrating all of your content in that page?
(I'd vote to do that for now, and we can discuss if the
Visualizations/Monitoring page should get moved from under Phase 3 to Phase
2, but would probably be separate from using-oref0-tools regardless, since
that's a huge page in of itself.)
Thoughts?
—
Reply to this email directly or view it on GitHub
https://github.com/openaps/docs/pull/80#issuecomment-176337297.

@logichammer - this is now super out of date with where docs are. I think we've got most of this folded in, but would love for you to go look at the next iteration of dev (coming shortly, as a PR from dana-dev) to see if any of the NS stuff you worked on here should be added into the NS visualization section (now much higher in the phase flow). That'll be the place to open a new PR to and adjust from there. Thanks!


v0.2.0 Release

This is a check list and notes for v0.2 release
BAND Framework Release Process
Before release

[x]  A GitHub issue is created with a checklist for the release.

This is the issue!

[x]  A release branch should be taken off develop (or develop pulls controlled).

Will be working off develop

[x] Release notes for this version are added to the CHANGELOG.rst file.

[x] Ensure that links and references have been updated (e.g., no occurrences of privateband).

no occurrences of privateband; once actions is working, we should make link checking part of our CI

[x] Version number is updated wherever it appears and +dev suffix is removed (in README.md and possibly in CHANGELOG.rst ).

[x] Check README.md Citing bandframework for correctness (e.g., ensure that author list matches AUTHORS ).

[x] Tests are run with source to be released (this may iterate):

Online CI (GitHub Actions) tests must pass.

Documentation must build and display correctly wherever hosted.

N/a (no actions or tests at this time)

[x] Pull request from either the develop or release branch to main requesting
one or more reviewers (including at least one other administrator).

Here is the PR: https://github.com/bandframework/bandframework/pull/50

[ ] Reviewer will check that all tests have passed and will then approve merge.

[x] Send an email to<EMAIL_ADDRESS>asking to confirm whether the list of email contacts in CODE_OF_CONDUCT.md  is up-to-date.

Confirmed email is working and recipients listed

During release
An administrator will take the following steps.

[ ] Merge the pull request into main.

[ ] Once CI tests have passed on main:

A GitHub release will be taken from the main

A draft release is being worked at https://github.com/bandframework/bandframework/releases

[ ] If the merge was made from a release branch (instead of develop), merge this
branch into develop.

[ ] Create a new commit on develop that appends +dev to the version number
(wherever it appears).

After release

[ ] Ensure all relevant GitHub issues are closed.

PR is now out https://github.com/bandframework/bandframework/pull/50

Release of v0.2.0 complete
https://github.com/bandframework/bandframework/releases/tag/v0.2.0


feat: opt-out scm.email

Fix #XXX

Documentation
Description
This is handy when using scm.commitusingapi: true, email and user are not required IIRC.
Test
To test this pull request, you can run the following commands:
cp <to_package_directory>
go test

Additional Information
Tradeoff

Potential improvement

This will help me to avoid setting them https://github.com/elastic/apm-server/blob/a5aaf076514d6bd849eaf2bd8baed7cc5df5e845/.ci/updatecli/values.d/scm.yml#L6-L10 when using this policy with commitusingapi


Log additional information on crashes from rexi

Overview
This improve the log messages from rexi. It adds flowing info:

nonce
node originator of the request
mfa of the function called
client Pid

Checklist

[x] Code is written and works correctly;
[ ] Changes are covered by tests;
[ ] Documentation reflects the changes;

Overall I think this looks good, but I'm a bit confused as to why the nonce isn't getting logged already. We write the log entry in [1], which includes the MsgId in [2], and we set that value in [3] by way of [4]. This log statement is happening in rexi_server:init_p/3 which is already recording the nonce [5], so I'm a bit confused as to why the nonce is not showing up as expected, or even the fall back msg_id [6].
[1] https://github.com/apache/couchdb/blob/e6ecb1030b1971a49e69a4d7f2042ed7eb9e6653/src/couch_log/src/couch_log_writer_syslog.erl#L76-L96
[2] https://github.com/apache/couchdb/blob/e6ecb1030b1971a49e69a4d7f2042ed7eb9e6653/src/couch_log/src/couch_log_writer_syslog.erl#L92
[3] https://github.com/apache/couchdb/blob/e6ecb1030b1971a49e69a4d7f2042ed7eb9e6653/src/couch_log/src/couch_log_formatter.erl#L44
[4] https://github.com/apache/couchdb/blob/e6ecb1030b1971a49e69a4d7f2042ed7eb9e6653/src/couch_log/src/couch_log_util.erl#L50
[5] https://github.com/cloudant/couchdb/blob/e6ecb1030b1971a49e69a4d7f2042ed7eb9e6653/src/rexi/src/rexi_server.erl#L138
[6] https://github.com/cloudant/couchdb/blob/e6ecb1030b1971a49e69a4d7f2042ed7eb9e6653/src/couch_log/src/couch_log_util.erl#L51

@chewbranca: You were right the Nonce shouldn't be part of a message. I just pushed the change which removes it. The nonce is added by couch_log_writer_syslog.erl to the syslog message. It can be accessed as %msgid from format pattern.

+1


[WIP] Bump libssh2 to 1.7.0

Tests are all screwy for me locally (including on master), so we'll see if this works on CI, but it seems all good.

Definitely appears to have some windows issues, probably missing and/or superfluous includes.


Random word

Hello. Would it be possible to add the option to display a random word/words? To learn new words. Regards.

Sorry. I saw now that there was already a similar request.


add UTIME_OMIT, UTIME_NOW on linux

@bors: r+

:pushpin: Commit 22e79d6 has been approved by alexcrichton

:hourglass: Testing commit 22e79d6 with merge 603e5a7...

:sunny: Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 603e5a79c68bc744834775e910787ec57eff0d4c to master...


Turtles April release

[x] https://github.com/rancher/highlander/issues/80
[x] https://github.com/rancher/turtles/issues/494

We had a release party where @mbologna did the release of: https://github.com/rancher/turtles/releases/tag/v0.7.0


Seed(Soil) created by Gardenlet lacks volume infromation in Alicloud

What happened:
When  deploying a Garden(soil) cluster, after gardenlet is deployed in the soil cluster, the seed representing soil cluster is generated by Gardenlet. However, the seed lacks all volume information like persistentvolume.garden.sapcloud.io/minimumSize: 20Gi.
And also, it is even worse, after update a Gardener cluster by enabling Gardenlet, persistentvolume.garden.sapcloud.io/provider: FlexVolume disappeared.
What you expected to happen:
How to reproduce it (as minimally and precisely as possible):
Anything else we need to know?:
Environment:

Gardener version:
Kubernetes version (use kubectl version):
Cloud provider or hardware configuration:
Others:

Can you share the gardenlet component config?

Can you share the gardenlet component config?

It turns out to be a problem of configuration of gardenlet:
Current configuration is:
SeedConfig:
  Spec:
  Volume:

While it should be:
SeedConfig:
  Spec:
    Volume:

So perhaps we can close this issue :)

/close


Some suggestions on compatibility

Move these recipes into arcana2plus namespace

There are many recipes in minecraft namespace such as flint.json, which could cause compatibility issues with other mods.
NOTE: Also concern RecipeManagerMixin, which should also be modified.
Register your own recipe type and its serializer, instead of using Mixin and Java code.
This is good for extensibility. You can view my repo for some inspiration. >> teddyxlandlee/player-skull <<
Class initializer is a good thing. Things in the class initializer will run just when the class is loaded. It looks like that:

public class Foo {
    // Other code
    static { // here it is
        // ...
    }
    // Other code
}

My intention is to create a config file where these recipes can be disabled. I think this would solve compatibility issues.

My intention is to create a config file where these recipes can be disabled. I think this would solve compatibility issues.

Then creating a bundled resource pack with fabric-resource-loader-v0 is a good idea. Those recipes which should be optional would be moved into the bundled resource pack.


Bump identity-apps versions

$subject

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/9093065389
Status: failure

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/9096025643

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/9096025643
Status: success

Already updated with: https://github.com/wso2/product-is/pull/20384


Just a few questions

Hello,
I have got the api docs with a email to helpdesk. And now I have a few questions.

What version of the documentation you're using? And how much pages you have? (Mine is from 20.09.2018 and has 19 pages)

In mine there is nothing about getting homeworks and a few other stuff. Only json rpc and nothing about a rest API. Did you figured out the rest api yourself?

The guy from the untis team, who send me the documentation said:

The query interval of your program must NOT be less than 60 minutes. Otherwise the query will be blocked by the system.

Have you any experience with testing your program? Did you got blocked?

And in my sheet I can't find anything about the secret authentication and anonymous login. Did you figured out this also yourself?

Best regards.

Hi,

What version of the documentation you're using? And how much pages you have? (Mine is from 20.09.2018 and has 19 pages)

I have the same version.

In mine there is nothing about getting homeworks and a few other stuff. Only json rpc and nothing about a rest API. Did you figured out the rest api yourself?

Figured it out by myself.

The guy from the untis team, who send me the documentation said:

The query interval of your program must NOT be less than 60 minutes. Otherwise the query will be blocked by the system.
Have you any experience with testing your program? Did you got blocked?

I think they don't have a blocking system which triggers that early. Never got blocked. Just don't abuse it and you should be fine. If there servers can not handle 2 request every hour, then they probably did something wrong while developing WebUntis.

And in my sheet I can't find anything about the secret authentication and anonymous login. Did you figured out this also yourself?

Yes, again. I figured it out by myself. Nothing there in the official documentation.

Ok, thank you very much for awnsering. I like your api wrapper.

Do you know, if there is also something to get all teacher who theaches me in which lesson?

https://github.com/TheNoim/WebUntis/blob/master/index.d.ts#L49

That's funny, could it be that my school blocks fetching also the teacher? This is one lesson json object Im getting.
{
  "id": 357397,
  "date": 20200922,
  "startTime": 955,
  "endTime": 1040,
  "kl": [
    {
      "id": 280,
      "name": "11",
      "longname": " (314)"
    },
    {
      "id": 285,
      "name": "11",
      "longname": "(320)"
    }
  ],
  "su": [
    {
      "id": 1,
      "name": "KR",
      "longname": "Kath. Relogion"
    }
  ],
  "ro": [
    {
      "id": 44,
      "name": "314",
      "longname": "(9d)"
    }
  ],
  "lsnumber": 9800,
  "activityType": "Unterricht"
}

That's funny, could it be that my school blocks fetching also the teacher? This is one lesson json object Im getting.

It could be. Can you make a screenshot of some lessons on the webuntis page?

It's funny, because on the web untis page I can see my teachers, but on the mobile app i can't. Could it be that webuntis fetch the data an other way like the mobile app? And the mobile app use the offfical api?

Currently, there are three known apis to me:

The official
WebAPI (Used by the webpage)
App API

However, this is the first time that I encountered that some api is missing some data. I mean, if some api is returning the data, we should be able to get it somehow. But we need to modify the api client.

how do you recommend the login management? just login for one api call and then log out or leave the session valid and not logout and validate the session before every api call?

how do you recommend the login management? just login for one api call and then log out or leave the session valid and not logout and validate the session before every api call?

If you really know you only do one request, you can logout. However, a session is only valid for 15 minutes. So, if you do more than one request in 15 minutes, you can just leave it. The client will refresh the session by itself.


Abstract logic satisfaction relation hardcoded

The Lindström's theorem chapter hard-codes the abstract logic satisfaction relation as \models_L.  Needs to be replaced by something defined in open-logic-config.sty à la \Sat

Right, @AldAnt ?  Maybe use a different symbol by default, say three-line turnstile?

We can use a different symbols, as long we are careful to preserve \models
for the classical relation: there will be instances of a logic <F,
\models_F> which is supposed to denote FOL, so such occurrences should not
be replaced.
A
On Sun, Sep 20, 2015 at 1:42 PM, Richard Zach<EMAIL_ADDRESS>wrote:

Right, @AldAnt https://github.com/AldAnt ? Maybe use a different symbol
by default, say three-line turnstile?
—
Reply to this email directly or view it on GitHub
https://github.com/OpenLogicProject/OpenLogic/issues/55#issuecomment-141832760
.

--

G. Aldo Antonelli
Professor of Philosophy
University of California, Davis
http://aldo-antonelli.org
<EMAIL_ADDRESS>+1<PHONE_NUMBER>


Invalid prop type options

Shouldn't the option prop require an array?

I have this same issue.

#63 already open to fix this

Can the new version please be published on npm as well? :)


[T6A3][T13-C1] Sean Zhang

Ready for review. Referenced #861 for Storage exceptions

@puzzledsean
Some comments added. Please ack & close the PR after reading comments.


Fix logstash build error

Description
Logstash Dockerfile tries to install an already bundled plugin and returns an error while building.
Motivation and Context
This changes fixes issue #3173.
The path to the solution
Types of Changes

[x] Bug fix (non-breaking change which fixes an issue).

Definition of Done Checklist:

[x] I've read the Contribution Guide.
[x] I enjoyed my time contributing and making developer's life easier :)

@Mahmoudz error still exists, please merge this fix

@Mahmoudz error still exists, please merge this fix

Do this changes work for you?

@Mahmoudz error still exists, please merge this fix

Do this changes work for you?

yes, they do

that line in is obsolete already with the new version of logstash so you can safely merge this fix


Failure to classify SMB encrypted session packet protocol as SMB

Describe the bug
A clear and concise description of what the bug is.
The encrypted SMB session protocol is classified as only TCP.
When analyzing the "smb3-aes-128-ccm.pcap" and "smb311-aes-128-ccm-filt.pcap" files of the https://wiki.wireshark.org/SampleCaptures#smb3-encryption URL, they are classified as only TCP.
This Pcap file is also classified as only TCP.
smb300-aes-128-ccm.pcap.gz, smb311-aes-128-ccm.pcap.gz, smb311-aes-128-gcm.pcap.gz, smb311-aes-256-ccm.pcap.gz, smb311- aes-256-gcm.pcap.gz file of the https://github.com/wireshark/wireshark/tree/master/test/captures URL
“SMB” exists from the 5th character of the payload, but it is not classified as SMB.
arkime_parsers_classifier_register_tcp("smb", NULL, 5, (uint8_t *)"SMB", 3, smb_classify);
Elasticsearch version:
https://demo.arkime.com/
Arkime/Moloch version:
https://demo.arkime.com/
OS name and version:
https://demo.arkime.com/
How was Arkime/Moloch built/installed: (rpm, deb, easybutton, ...)
https://demo.arkime.com/
Provide logs, stack traces and steps to reproduce:
...

The ones on the wireshark page don't seem to have the TCP handshake. Did you upload some to demo that do? If so what tag did you use.

The ones on the wireshark page don't seem to have the TCP handshake. Did you upload some to demo that do? If so what tag did you use.

The "smb240401" tag was used in the "smb3-aes-128-ccm.pcap" and "smb311-aes-128-ccm-filt.pcap" files.

Ya neither of those have SYN or SYN-ACK, we require at least one of those to classify.

Ya neither of those have SYN or SYN-ACK, we require at least one of those to classify.

Thank you for answer.
have a good day.

Ok, if you find another one let me know


How to train Faster R-CNN on my dataset ?

Hello,
I have successfully ran the training and testing. I am wondering what do I need to change to train on a new dataset?
Thanks!

There are just teo things you need to do.

Make your own dataset class as you can find in chainercv/datasets.
Write train.py as you can find in examples/faster_rcnn


.NET May 2024 Update - .NET 8.0.5, NET 7.0.19, .NET 6.0.30

.NET May 2024 Update
Release Notes

8.0.5
7.0.19
6.0.30

.NET 7.0 reaches end of support today
Status

Asset Type
8.0.5
7.0.19
6.0.30
Notes

Installers/Binaries
✅
✅
✅

Snaps
✅
✅
✅

Linux Packages (Microsoft distribution)

The list below refers to the Microsoft-provisioned feeds (packages.microsoft.com) and does not in any way represent direct availability in distros (eg RHEL, Fedora).

     Centos 7
NA
✅
✅

     Centos 8
✅
✅
✅

     Debian 10
✅
✅
✅

     Debian 11
✅
✅
✅

     Debian 12
✅
✅
✅

     Fedora 37
✅
✅
✅

     Fedora 38
✅
✅
✅

     Fedora 39
✅
✅
✅

     Fedora 40
✅
✅
✅

     OpenSUSE 15
✅
✅
✅

      Ubuntu 20.04
✅
✅
✅

     Ubuntu 22.04
✅
✅
✅

     Ubuntu 23.04
✅
✅
✅

     Ubuntu 24.04
✅
✅
✅

Issues
Please report any issues you find either by responding to this issue, creating a new issue or creating a new issue in one of the following repos:

ASP.NET Core: dotnet/aspnetcore
Entity Framework Core: dotnet/efcore
.NET CLI/SDK dotnet/sdk
.NET runtime dotnet/runtime
Winforms: dotnet/winforms
WPF: dotnet/wpf
NuGet: nuget/home
Containers: dotnet/dotnet-docker
Winget: microsoft/winget-pkgs

Known Issues

Is the full changelog link for the 7.0.19 release supposed to be comparing v6.0.29 -> v7.0.19? I guess I was expecting 7.0.18 -> 7.0.19?
https://github.com/dotnet/core/releases/tag/v7.0.19

There seems to be a change in the Central Package Management behaviour in SDK 8.0.300 around the existence of Directory.Packages.props file. We had one in our solution but it didn't have anything defined, ie:
<Project>
</Project>

dotnet restore was happy under previous SDK versions, but now under 8.0.300 it starts complaining about the incorrect use of Central Package Management (as if it is enabled), eg:
error NU1008: Projects that use central package version management should not define the version on the PackageReference items but on the PackageVersion items

Deleting the Directory.Packages.props has fixed the issue.

Publish the blog too .

@antmeehan it seems to be this change: https://github.com/NuGet/NuGet.Client/pull/5572

Is it possible that this update changed the way analyzers work at least for 8.0.5? Out of sudden analyzers that didn't trigger before are now producing warnings or in our case errors preventing our build from working even so there weren't any changes

Can we get a priority on publishing the blog on the day that updates are released?  https://devblogs.microsoft.com/dotnet/May-2024-updates/ that's MIA.  I'm not a developer, I'm a patcher and I rely on the communication from the .NET blog to know what updates I should be expecting.

@SusanBradley the blog post is now live at dotnet-and-dotnet-framework-may-2024-servicing-updates/

@mairaw https://support.microsoft.com/en-us/topic/-net-6-0-update-may-14-2024-kb5038350-a08fa6e5-7c7e-4ecb-a15e-268507cd39ab that says that the .net 6 also has security updates, not just 7 and 8?

Hello, My apologies for the wrong details in the https://support.microsoft.com/en-us/topic/-net-6-0-update-may-14-2024-kb5038350-a08fa6e5-7c7e-4ecb-a15e-268507cd39ab. I have submitted a request to update this to reflect that 6.0 is a non security release

As @antmeehan and @andreaskromann point out with https://github.com/NuGet/NuGet.Client/pull/5572, I think it's worth noting that the default value of <ManagePackageVersionsCentrally /> has essentially changed such that whenever a file called Directory.Packages.props is present, the default value is now true (8.0.300) as opposed to false (prior to 8.0.300).
This was in fact a breaking change for us, because some of our legacy projects in our mono repository haven't been migrated to use the centralized package management, causing some of our builds to fail when building with the 8.0.300 SDK. We relied on the default value and using a more specific Directory.Build.props to ensure that these legacy projects did not use the central nuget package versioning.
Now, for anyone reading this, it's easily fixed by explicitly setting <ManagePackageVersionsCentrally>false</ManagePackageVersionsCentrally> in the Directory.Build.props file where you do not want to use CPM, but it is indeed something you MUST do before upgrading the dotnet SDK.

Any reason why 8.0.4 or 8.0.5 is not listed here https://hub.docker.com/_/microsoft-dotnet-runtime ?

Any reason why 8.0.4 or 8.0.5 is not listed here https://hub.docker.com/_/microsoft-dotnet-runtime ?

@pebezo The images are up to date, but the syndication from the Microsoft Asset Registry to DockerHub is currently not working. See https://github.com/dotnet/dotnet-docker/issues/5327.
You can view the latest tags on MAR: https://mcr.microsoft.com/product/dotnet/runtime/tags

Why did this release include the 8.0.300 SDK but the matching Visual Studio 17.9.7 update ship with 8.0.205?
If I install 8.0.300 manually, it doesn't work properly in Visual Studio because it looks like the compiler version is too old, causing the SDK analyzers to not work.
For example:
The analyzer assembly 'C:\Program Files\dotnet\sdk\8.0.300\Sdks\Microsoft.NET.Sdk\codestyle\cs\Microsoft.CodeAnalysis.CodeStyle.dll' references version '<IP_ADDRESS>' of the compiler, which is newer than the currently running version '<IP_ADDRESS>'.	ServiceControl.Audit.Persistence.SagaAudit	C:\Program Files\dotnet\sdk\8.0.300\Sdks\Microsoft.NET.Sdk\codestyle\cs\Microsoft.CodeAnalysis.CodeStyle.dll

We currently have our CI builds set up to pick up the latest SDK, so this results in us having failing builds due to the analyzers in the updated SDK finding more cases of triggering patterns, but then us not being able to see them locally in Visual Studio and apply fixers.
It also appears the compiler in the 8.0.300 SDK has a new language breaking change that has impacted us as well, and it's a pain to figure out what's going on when I can't use the matching SDK in Visual Studio.

Why did this release include the 8.0.300 SDK but the matching Visual Studio 17.9.7 update shipped with 8.0.205?

@bording - The May Updates included releases for 8.0.105, 8.0.205, and 8.0.300. Way back in the beginnings of .NET Core, we needed to figure out how to support new versions of Visual Studio along with new features in shared tools, such as compilers and analyzers. We refer to the first digit of the 'patch version' as the feature band. Sometimes a new feature band will include updates that effect backward compatibility.
To help know what .NET goes with what VS, we include the mappings in detailed release metadata. This can be seen as a top-level index that references each version channel (8.0 example). This file includes the VS mapping info, for example ...
                    "version": "8.0.205",
                    "version-display": "8.0.205",
                    "runtime-version": "8.0.5",
                    "vs-version": "17.9.7",
                    "vs-mac-version": "",
                    "vs-support": "Visual Studio 2022 (v17.9)",
                    "vs-mac-support": "",
                    "csharp-version": "12.0",
                    "fsharp-version": "8.0",
                    "vb-version": "16.9",

where vs-version indicates which VS update includes this particular SDK and Runtime, and vs-support, which indicates the supported VS minor version.
Hopefully this info helps with your update automation.

The blog post no longer contains links to the list of actual non-security changes in the release. Previously, there were links to the merged PRs in each repo, which wasn't ideal but at least was useful. Now, I have no easy way to see the list of actual changes without going to each repo and manually searching the PRs by milestone.
Please reconsider this change in communication, and ideally consider a way to list all of the changes in a simple list. Thanks

@rbhanda - please take a look.

And the VS support info perhaps can be more easily consumed on the dot.net site
https://dotnet.microsoft.com/en-us/download/dotnet/8.0

Can we have link to what's the new feature released in 8.0.300, compared to 8.0.205, it should be a new feature release, so what's the new feature?

Did 8.0.5 change the GC characteristics?

@Maoni0 can you have a look at the above?

Can we have link to what's the new feature released in 8.0.300, compared to 8.0.205, it should be a new feature release, so what's the new feature?

This versioning is primarily to enable new tooling work share with Visual Studio (ie compilers, analizers, msbuild, etc) to move forward with new versions of VS, though impactful SDK changes do sometimes also come into play.
@marcpopMSFT - who could help work out a good way to get this information into release notes or some other location?

CC @baronfel in case he has any better idea on how to track/document this.
Typically, the SDK feature band releases are mostly about updates of the VS tooling (ie updates to nuget, msbuild, roslyn, razor, vstest, etc) to ensure the SDK matches what ships in VS. Those tool updates can have features in them but we rely on individual teams to document and call out any new features (for example, nuget package search was introduced in 8.0.200).
For the SDK, we typically update the .net 9 release notes with new features (even if those features ship in the feature band SDKs) to reduce the release costs. Looking over PRs into the 8.0.3xx branch, there are a few minor quality of life improvements and some container changes. Everything else in codeflow.

Different repos/tech have different approaches here. The Containers tech has dedicated release notes in the SDK repo that are tracked per-SDK Release, while the F# team has per-component release notes markdown files that are currently published to community run sites like https://fsharp.github.io/fsharp-compiler-docs/release-notes/Language.html. I think from a process perspective the first step is having some kind of per-component changelog tracking happening as changes are made in the repo, and then aggregating those periodically.

Did 8.0.5 change the GC characteristics?

I see dotnet/runtime#100575 included in 8.0.5.
@Maoni0 can you have a look at the above?

Apologies, this was most likely a false alarm. Averages are now returning to the same as before so I think it was simply because the rolling upgrade of course also means a rolling restart of all containers:

Is it possible that this update changed the way code style analyzers work at least for 8.0.5? Out of sudden analyzers that didn't trigger before are now producing warnings or in our case errors preventing our build from working even so there weren't any changes. e.g.: error IDE0100: Remove redundant equality

Since this release my CIDC has been broken for our aspnet application. CSHTML files now have build errors that don't make any sense. Of all the build errors its just cshtml files.
for example :
<div render-if="!@isUpdate" class="col-md-2"> has a build error error CS0201: Only assignment, call, increment, decrement, await, and new object expressions can be used as a statement
isUpdate is defined above in a code block.
Using 8.0.301 doesnt help, has the same behaviour. For now I have pinned my pipeline image to mcr.microsoft.com/dotnet/sdk:8.0.204 but I have yet to figure out how to get a dev container with the 8.0.204 sdk

@wtgodbe, can you have a look at the comment above? Starting with you since @nckl is seeing the break in aspnetcore.

https://github.com/dotnet/aspnetcore/pull/54763 was the only analyzer change we took for 8.0.5, but it's not clear to me how that could be related (CC @JamesNK). If it's not that, it seems more likely to be a change in dotnet/roslyn-analyzers

Why did this release include the 8.0.300 SDK but the matching Visual Studio 17.9.7 update shipped with 8.0.205?
If I install 8.0.300 manually, it doesn't work properly in Visual Studio because it looks like the compiler version is too old, causing the SDK analyzers to not work.
For example:
The analyzer assembly 'C:\Program Files\dotnet\sdk\8.0.300\Sdks\Microsoft.NET.Sdk\codestyle\cs\Microsoft.CodeAnalysis.CodeStyle.dll' references version '<IP_ADDRESS>' of the compiler, which is newer than the currently running version '<IP_ADDRESS>'.	ServiceControl.Audit.Persistence.SagaAudit	C:\Program Files\dotnet\sdk\8.0.300\Sdks\Microsoft.NET.Sdk\codestyle\cs\Microsoft.CodeAnalysis.CodeStyle.dll

We currently have our CI builds set up to pick up the latest SDK, so this results in us having failing builds due to the analyzers in the updated SDK finding more cases of triggering patterns, but then us not being able to see them locally in Visual Studio and apply fixers.
It also appears the compiler in the 8.0.300 SDK has a new language breaking change that has impacted us as well, and it's a pain to figure out what's going on when I can't use the matching SDK in Visual Studio.
@bording  were you able to resolve this? I am also getting same error after manully installing 8.0.300 sdk.

FYI, I am trying to install aspnetcore-runtime 8.0 on an almalinux image, and it appears the repo is missing:
dotnet-runtime-deps-8.0-8.0.1-1.x86_64
I followed instructions here: https://learn.microsoft.com/en-us/linux/packages
and it appears that method is not necessary anymore, e.g: https://learn.microsoft.com/en-us/dotnet/core/install/linux-rhel still results in this:
`microdnf install aspnetcore-runtime-8.0
aspnetcore-runtime-8.0-8.0.5-1.el9_4.x86_64
dotnet-host-8.0.5-1.el9_4.x86_64
dotnet-hostfxr-8.0-8.0.5-1.el9_4.x86_64
dotnet-runtime-8.0-8.0.5-1.el9_4.x86_64
libicu-67.1-9.el9.x86_64
`
On an amazonlinux-2023 image using the package method (https://packages.microsoft.com/config/amazonlinux/2023/packages-microsoft-prod.rpm), these are installed:
dotnet-host-8.0.1-1.x86_64 dotnet-hostfxr-8.0-8.0.1-1.x86_64 dotnet-runtime-deps-8.0-8.0.1-1.x86_64 dotnet-runtime-8.0-8.0.1-1.x86_64 aspnetcore-runtime-8.0-8.0.1-1.x86_64

closing in favor of https://github.com/dotnet/core/issues/9390

@rbhanda, shall I open up an "issue" for my comment above? Thanks!


Add integration test for risk based login with complex payload

Related Unit test PR:

https://github.com/wso2-extensions/identity-conditional-auth-functions/pull/187

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/10579333624

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/10579333624
Status: cancelled

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/10579419955


grocery: sort, interface.html

Changes:

Sort checked items to bottom as I have seen that behavior on most or all shopping/todo apps.
Enable Widgets, the back button takes the space anyway.
Allow to edit items without reuploading entire app with interface.html which is a modified grocery.html.

Thanks!


UpdateWorkflow ShardId based metrics WIP

Add shardId to updateworkflow. Also created a reusable thing to add more metrics around shardIds if needed.

For hotshard detection

Tested on staging

Metrics for updateworkflow break

Pull Request Test Coverage Report for Build 01862eb5-e93a-42a9-8546-1b39b96a8fd0

21 of 25 (84.0%)  changed or added relevant lines in 2 files are covered.
37 unchanged lines in 11 files lost coverage.
Overall coverage increased (+0.05%) to 57.211%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

common/persistence/persistenceMetricClients.go
18
22
81.82%

Files with Coverage Reduction
New Missed Lines
%

client/history/client.go
2
38.1%

client/history/metricClient.go
2
45.3%

service/history/handler.go
2
47.15%

service/history/shard/context.go
2
66.7%

service/matching/matcher.go
2
91.46%

service/matching/taskListManager.go
2
76.37%

common/task/fifoTaskScheduler.go
4
82.47%

service/frontend/workflowHandler.go
4
59.98%

service/history/task/fetcher.go
4
91.24%

service/history/task/transfer_standby_task_executor.go
4
86.4%

Totals

Change from base Build 018629b0-d67f-4830-850c-ae7166f3ae2d:
0.05%

Covered Lines:
84957

Relevant Lines:
148498

💛  - Coveralls


Issue with Lambdas

Hi,
Im running in an issue were if i use lambdas as match processors, he doesnt run and hangs java up.
i then tried to use inner classes and its working that way. i also tried to do the same scan in a version lower( a lot lower ..) and it worked perfectly.
Also tried to run a List for each to see if it wasnt my pc freaking out and it works too. the only difference i found in your poms is that the lower is compiled in java 1.8 but the newer is in java 1.8.
Verbose doesnt say nothing.
Version that hangs: 2.0.10
Version that worked: 1.2

Thanks for the report. Can you please provide an example?
On Jan 22, 2017 2:35 AM, "GirithGoloth"<EMAIL_ADDRESS>wrote:

Hi,
Im running in an issue were if i use lambdas as match processors, he
doesnt run and hangs java up.
i then tried to use inner classes and its working that way. i also tried
to do the same scan in a version lower( a lot lower ..) and it worked
perfectly.
Also tried to run a List for each to see if it wasnt my pc freaking out
and it works too. the only difference i found in your poms is that the
lower is compiled in java 1.8 but the newer is in java 1.8.
Verbose doesnt say nothing.
Version that hangs: 2.0.10
Version that worked: 1.2
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/lukehutch/fast-classpath-scanner/issues/103, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAxhKQN6cYjkXKmeAkbbU99RRzZsZFnyks5rUzDXgaJpZM4LqWGK
.

Hi thanks for the response.
Its attached to the comment.
classpath_test.zip

Thanks @GirithGoloth, I can replicate the hang using your testcase. I don't understand the hang though. In the Eclipse debugger, if I pause the running thread to examine it, it just says "Waiting for (id = 86)", it doesn't allow me to examine the stacktrace. The fact that the JVM debugger can't even stop the running thread to obtain a full stacktrace indicates something weird is going on.
I compile FCS using Java 1.8, in 1.7 compatibility mode (because I have a lot of users that are not on Java 8 yet). This has always worked before.
The weird thing is that lambdas work in the unit tests in the FastClasspathScanner project itself. So it seems to be a difference with how Maven is compiling FCS for release.
I'll see if I can figure out what Maven is doing differently in the two cases, but it's a very strange bug.

The symptoms are similar to this OpenJDK bug:
https://bugs.openjdk.java.net/browse/JDK-8145888

@GirithGoloth I found what's triggering the problem. If you remove the call to startup() from the BeansScanner() constructor, and then instead call BeansScanner.getInstance().startUp(), the code works fine.
This seems to indicate that some part of the Java 8 lambda system is not fully initialized yet if you use lambdas in the static initializer block of the class that contains the main method (i.e. before main runs).
I assume this is a Java 8 bug? What do you think?

I think that it is related with java 8 definetely since i can actually still use your library fine in other places. Only this class with this combination of steps was with this problem and the weird part is before calling the fastscanner if you create a list and use forEach with a lambda, it works, even if i call parallelStream and also adding, when it hangs no exception is thrown.
Im closing this issue as it doesnt seem related to FastClasspathScanner. Thanks for your replies and keep up the good work.

@GirithGoloth it hangs somewhere deep in the JVM, so it does seem to be a Java 8 bug. I filed a report at the Oracle website and directed them here, hopefully they will take a look. I guess just make sure that main has started running before you call FashClasspathScanner. Thanks for the report!

@GirithGoloth OK, this is definitely a JRE bug. I created this minimal testcase to illustrate the problem:
import java.util.concurrent.Callable;
import java.util.concurrent.ExecutionException;
import java.util.concurrent.ExecutorService;
import java.util.concurrent.Executors;

public class LambdaBug {

    // Code will hang after "Entering startUp()" if and only if both these are true
    private static final boolean RUN_AS_STATIC_INITIALIZER = true;
    private static final boolean RUN_USING_LAMBDA = true;

    static {
        if (RUN_AS_STATIC_INITIALIZER) {
            startUp();
        }
    }

    private static void startUp() {
        System.out.println("Entering startUp()");
        ExecutorService es = Executors.newSingleThreadExecutor();
        try {
            Callable<Void> callable;
            if (RUN_USING_LAMBDA) {
                callable = () -> {
                    System.out.println("Lambda executed");
                    return null;
                };
            } else {
                callable = new Callable<Void>() {
                    @Override
                    public Void call() throws Exception {
                        System.out.println("Inner class method executed");
                        return null;
                    }
                };
            }
            es.submit(callable).get();
        } catch (InterruptedException | ExecutionException e) {
            throw new RuntimeException(e);
        }
        es.shutdown();
        System.out.println("Exiting startUp()");
    }

    public static void main(String[] args) {
        if (!RUN_AS_STATIC_INITIALIZER) {
            startUp();
        }
        System.out.println("Exiting main");
    }
}

PS to trigger this, you have to be running in another thread, which is why the 1.2 version did not exhibit this problem -- it was single-threaded.

I got an explanation from David Holmes of Oracle about why this code example causes deadlock -- very interesting:
http://mail.openjdk.java.net/pipermail/core-libs-dev/2017-January/046060.html
I still have questions about whether this can be prevented, or at least detected by FastClasspathScanner (so that FCS doesn't accept Lambda expressions in this context) -- see that conversation thread.

I discovered this issue doesn't just happen with lambdas, it can happen with anonymous inner classes too, if they access the fields of the class they are defined within. The deadlock is hit as soon as they try to access those fields. (Presumably this also happens with method calls.)

Hi,
Well seems we have to be careful were we use and lambdas and Threads. I hope they somehow create a compilation warning so that we can be careful on doing this kind of stuff, but with what im seeing this is a very hard pattern to track and sometimes it would spam warning in the console which would be undesirable. So for now might well be aware of this situation and how to prevent it .
Thanks for keeping this updated on the problem.

@GirithGoloth see the discussion on the core-libs-dev mailing list above. The right solution for FastClasspathScanner is to run MatchProcessors on the calling thread, so I just refactored the code to do that. Your original code example should work fine now.
The only form of scanning you can't do from a class initializer block now is asynchronous scanning, i.e. calling scanAsync() rather than scan(), since this will run MatchProcessors on a separate thread. FastClasspathScanner will now detect this case (of asynchronous scanning, launched from a class initializer block), and will throw a RuntimeException, refusing to start, in preference to causing a deadlock.
Thanks for this bug report, fixing this was a fascinating journey! This fix will be in version 2.0.13.


Adding privateEndpoint child resource privateDNSZoneGroup and adding customDNSconfig JSON to privateEndpoint.

Latest improvements:
MSFT employees can try out our new experience at OpenAPI Hub  - one location for using our validation tools and finding your workflow.

Contribution checklist:

[ ] I have reviewed the documentation for the workflow.
[ ] Validation tools were run on swagger spec(s) and have all been fixed in this PR.
[ ] The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

[ ] Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

[ ] If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

  If it's ready, please remove the Draft label.

@Wistlie Hi. Since we are on a tight schedule for this feature. It's better to merge this one ASAP. Could you solve the comments and I can help merge this PR.

Hey @MyronFanQiu ! Sorry I haven't responded, I've been waiting for feedback from my technical manager, I'm aiming to resolve these comments by EOD tomorrow.

@MyronFanQiu Looks like there may be a few more changes to do based on the comments, I will resolve as soon as I hear back from people.

/azp run automation - sdk

/azp run automation - sdk

/azp run automation - sdk

@pilor do you think you'd sign off on this PR now? I'm about to take off the draft tag after a final review from my manager.

/azp run automation - sdk

/azp run automation - sdk

/azp run automation - sdk

/azp run automation - sdk

/azp run public.rest-api-specs


[Feature] add formatter with support for rich styling to legend

What problem does this feature solve?
Adds support for sophisticated legends.

What does the proposed API look like?
Add formatter to legend, with styling through rich property, just like you have it for label in this example?

+1 here. I came here to look for a solution for formatting the legend through the API, but wasnt able to find anything.
I was able to make rich text to work under legend though, take a look here @jayarjo
https://echarts.apache.org/examples/en/editor.html?code=PYBwLglsB2AEC8sDeBYAULWBjYAbYATgFywDaARAMQAM1AzHQGyPkA0sVtzAnN2x5QAsWAIYAjLAFN-VSQFY6AJjrSAuq3SYAJiLAiAzpLAlUGTLH3AArgSklSm85gpgAniGntyi6gEZFMj6-dIF-gqG-chEs6o5OFABihJL6YPxK1OwMill-WXSCWdzUsWbx5ADKYJIgHvyKPuy-ABw5sL7cvuzKhbCKxaVOzuQAIimSBGlNcpl9St157XK9HSUaZeYUAOpGuCLQWvzczewA7KdNi7zsgiVxsKqOAL7r5riSAOaSByb3TtUADzAVVc71-GyG5hw-GIsAA5JQGHQ4a9IUMAGYwYEQABekhIvkKfzRmOgYB2EA-AAtjPCxHgtCjiZDScC3GD4RA9LgIFgmRC0QB6QWwLSSdEQaCSWAEXlUizslLMoayrBU8FotEiDWa3UAdwgWjA6tgzUyyt1sCpkkpNJIdHNAstmDEIiwAGsPgRrAcAMJ4QgkBGMABCp0UZv5zrR9IIYoIACURFoIFZ9CQiU7ndDA_DKOiC1Ho0MRDyPtAg1IyRMi8W3pLJAAJG3U2kO1F1zCsiq4_HtTN1p4W8wvZWjp3KzEEAC2umqsPRVmgWEgMAAFNARNPJABKZDDzAEIw2OBwpAiAA-cNgAGpYJvt7f4U84QBuWDC2BplIyuUK0HSgaxrwiI16pABsDupIrhjh2Qz3OOmAAgAggCEDpvuGxuB4JDkKI1QfIQrhsPcIhofoAAqvLujqTj6FSwB6iQ6KloYCHPKirioehJiIRYEwQCk9imP87h9uQroECRGyGLKKQADIiK41hgCGri4d6erkBxmGiThHCSdJdECQpSkqWpGmMdpZgvLp5jYeJhlwbJgn6IpylWKp6kcJp1mYLZIn2WJuFOfcLmmR5XmWVpzyPGgTxAA&_source=echarts-doc-preview
But still there is no way as far I could see to have different colors and sizes on the borders, because "borderWidth" and "borderColor" doesn't support arrays to make it fully custom regarding top, bottom, right and left.
I wanted to have this legend style so everyone can have an idea:


bdd-spring-1559658880 to 0.0.1

Promote bdd-spring-1559658880 to version 0.0.1

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Security vulnerability

The module relies on node-fetch < 2.6.7 which is known as vulnerable. Please upgrade to the latest version of node-fetch
node-fetch  <2.6.7
Severity: high
node-fetch is vulnerable to Exposure of Sensitive Information to an Unauthorized Actor - https://github.com/advisories/GHSA-r683-j2x4-v87g

Thanks @zucatti for reporting this security concern. Let us take a look at it and try to resolve this asap.

Fix has been merged

released with v4.7.2


add zero-config support for loading ES modules in Node (round 2)

This PR adds zero-config support for loading ES modules in Node. This PR just replaces the entry require with esmRequire. Now --require modules, configs, and others files can have ESM syntax. The caveat is that .mjs files are not supported since under the hood mocha is still using require() to load files. See the following esm doc note:

💡 By Node’s rules, builtin require cannot sideload .mjs files. However, with esm, ES modules can be sideloaded as .js files or .mjs files may be loaded with dynamic import.

@boneskull Feel free to push tests to this PR.

Well, adding zero-config support will be beneficial for the tests, but then we would have to push lots of branches.

The parsing/loading of modules is a core functionality of Node. I'm unsure wether we should replace this by an external module.
I haven't understood the exact difference between using:

Node's --experimental-modules flag
mocha --require esm
this PR

Are we considering this PR only to save the typing of --require esm ?
On the other hand we would need a new flag giving the user the possibility to opt out esm?
Anyway just changing "bin/_mocha" will not do the job. Since we don't spawn a child-process in all cases anymore, "bin/mocha" would need to be adapted as well.

@juergba fair questions, will have a go at answering.

Node's --experimental-modules flag

i think it works with .js extension too.
e.g. (index.js is import assert from 'assert';)
node --experimental-modules index.js -> SyntaxError: Unexpected identifier
node -r esm index.js -> works

mocha --require esm

So AFAIK we sideload after the core code has run, so while this would work for spec files, it would not work for mochas core code. e.g. (an import inside cli.js)
node bin/mocha -r esm test/reporters/base.spec.js -> SyntaxError: Unexpected identifier
node  -r esm bin/mocha test/reporters/base.spec.js -> works

this PR

It believe it acts like the working example above EXCEPT doesn't apply to the users spec file. So its the best of both. We can use ESM inside core without impacting users code.
FYI ive been testing with change in bin/mocha.
Let me know your thoughts on above. Its possible im completely out of my depth here lol.

It believe it acts like the working example above EXCEPT doesn't apply to the users spec file. So its the best of both. We can use ESM inside core without impacting users code.

Where should we allow ESM:

loading our --require option?
loading  our --file option and user's test files?
in Mocha's core code?
parsing our configuration files?

IMO we should enable the first two items.
Enabling it for Mocha's core code, I don't see the benefit. There is a risk in overriding a Node core functionality with an external module, which is maintained by mainly just one maintainer.
I'm not convinced of enabling an esm zero-config support, with a flag --require esm it's ok though.
We should go for --experimental-modules. BTW the file extension can be handled with "type" field in package.json.

@juergba

Enabling it for Mocha's core code, I don't see the benefit.

 Even once native ESM lands will be some time before we can drop support for un-supporting envs.
But its disappointing we have had so many issues (and concerns) with it.

We are mainly still vegetating in ES5 caves.
I feel rather uncomfortable about this issue. It's not enough to take a few minutes time to say "it" runs and then merge this PR.
Someone has to take the lead and invest hours/days for this issue. What does "it" include? How are we going to test? What are we going to break (eg watch feature)?
#3006 is a good beginning to understand what our users' expectations are.

closed in lieu of #4038


[WIP: Comments Welcome] Added NSNotifications and a Branch delegate (AIS-271).

Branch can be awkward to integrate in certain kinds of apps since the Branch object only communicates state through a callback block.  I added a Branch delegate and NSNotifications.

Added a Branch delegate with optional callback methods:
branch:willOpenURL:
branch:didOpenURL:linkParameters:error:

Added Branch NSNotifications:
BNCBranchWillOpenURLNotification and BNCBranchDidOpenURLNotification

Added an example in the Branch-Testbed that demonstrates usage.

To Do:

Get feedback from stake holders.
Add documentation.

Result of Integration 1
Duration: 9 minutes and 8 seconds
Result: Perfect build! All 200 tests passed. :+1:
Test Coverage: 60%

Result of Integration 2
Duration: 7 minutes and 49 seconds
Result: Perfect build! All 200 tests passed. :+1:
Test Coverage: 60%

I think my main concern with adding this is that I'm not sure where in the documentation you'd put it? https://dev.branch.io. If it's not in the docs, no one will use it and therefore it's superfluous.
Related to the above, have we received feedback that people need this? If so, what problem are they trying to solve that can't be solved with the delegate callback block? I don't want to add ideological methods without a customer need or use case.

As far as documentation goes, I plan on making a small section explaining the delegate methods and notifications and making it clear that they are optional alternatives to the handling everything in the callback.

Can you modify the readme so that I can review how you plan on recommending the implementation alongside the current integration path?

I'll add the docs shortly. Let me finish up some other stuff first.

@E-B-Smith ping me once the readme is complete so I can make sure the changes go in the new docs

Result of Integration 3
Duration: 8 minutes and 38 seconds
Result: Build failed 1 test out of 200

Result of Integration 4
Duration: 9 minutes and 48 seconds
Result: Build failed 1 test out of 200

Result of Integration 5
Duration: 8 minutes and 33 seconds
Result: Build failed 1 test out of 200

Result of Integration 6
Duration: 11 minutes and 45 seconds
Result: Build failed 2 tests out of 200

Result of Integration 6
Duration: 11 minutes and 45 seconds
Result: Build failed 2 tests out of 200

Result of Integration 8
Duration: 9 minutes and 37 seconds
Result: Build failed 1 test out of 204

Result of Integration 9
Duration: 10 minutes and 12 seconds
Result: Build failed 2 tests out of 204

Result of Integration 10
Duration: 10 minutes and 1 second
Result: Build failed 1 test out of 204

Result of Integration 11
Duration: 9 minutes and 25 seconds
Result: All 204 tests passed, but please fix 1 warning.
Test Coverage: 62%

Result of Integration 12
Duration: 2 minutes and 10 seconds
Result: 4 errors, failing state: build-errors

Result of Integration 13
Duration: 13 minutes and 58 seconds
Result: -1 error, failing state: internal-build-error

Result of Integration 14
Duration: 14 minutes and 31 seconds
Result: -1 error, failing state: internal-build-error

Result of Integration 15
Duration: 9 minutes and 59 seconds
Result: All 204 tests passed, but please fix 1 warning.
Test Coverage: 62%

Result of Integration 16
Duration: 9 minutes and 35 seconds
Result: All 204 tests passed, but please fix 1 warning.
Test Coverage: 62%

Hey @jdee , Would you mind taking a look at this again and let me know what you think?
I've added your suggestions for this PR to make the delegate and notifications more useful, and I've add a small example app called BareBones.
The relevant files to look at are the delegate / notification header file and the BareBones documentation, part of which I plan on rolling into our bigger doc at some point.
Header file:
https://github.com/BranchMetrics/ios-branch-deep-linking/blob/d04e66eb8ab0d651f834e77bcc6ab3b949cdf257/Branch-SDK/Branch-SDK/BranchDelegate.h
Document:
https://github.com/BranchMetrics/ios-branch-deep-linking/blob/d04e66eb8ab0d651f834e77bcc6ab3b949cdf257/Examples/BareBones/README.md

This is a nice implementation and a nice example. I do see something wrong with BareBones, however. If I open a link, it routes to a view (LinkVC, I think) after showing the WaitingVC. If I then background the app and put it in the foreground again, I get the WaitingVC again, though no link was opened.
I think this gets to the heart of my concern about the API for the Branch SDK in the first place. There are a number of issues that originally confused me when I was first working with the Branch SDK (not to mention QA at the last job) and seem to confuse partners on a regular basis, because the behavior of the SDK is often unexpected. This is just my opinion, but I suspect a lot of partners might agree. The following remarks are motivated by practical concerns about supportability, though I think these things might also fall under the heading of best practices. And since you asked, here are my two cents:
I've often seen people remark in GitHub issues that something isn't working, "and the callback fires with {"+clicked_branch_link": false, "+is_first_session": false} when I foreground the app. Obviously something is broken." In fact, they have some other problem, but the fact that this behavior is unexpected means it always has to be explained and always arouses suspicion. If the SDK behaved in a way that was obvious and didn't have to be explained, it would be a big improvement. The current behavior is a little like a software implementation of Homer Simpson's Everything's OK Alarm.

With recent changes to WebViewExample, I witnessed some of this behavior in spades, and it confused me greatly in recent testing until I realized what was happening. Because handleDeepLinkWithNewSession: passes every link to the server, even if the method returns NO, and it passes every response back to the app, the app receives quite a lot of +non_branch_link responses when using the About the App view. I think that could stand to be improved.
I can't find it now, but I read somewhere (possibly the Apple Human Interface Guidelines) a very useful piece of advice: Never notify the user of an error that occurred in response to an action they did not initiate. Consumers of this SDK are developers, not end users, but a similar idea could be put forth here: Don't notify the app when 1) an error occurred; or 2) nothing happened in response to an event that was entirely initiated by the SDK, not the user or the app. If the user tries to open a link, and that fails, of course an error should be reported. Arguably, if the SDK would certainly have returned a link in response to a deferred deep link check, but cannot because of an error, that should be reported. One problem is that the SDK doesn't know this before calling the server. So the willStart notification as it stands can really only mean will check for a deferred deep link but may not actually be opening a link. Perhaps the willStart notification could be moved somewhere like handleDeepLink or continueUserActivity, so that the SDK can be fairly sure that it is actually responding to an open from the app, not a deferred deep link check, and events can be generated only when those methods return YES, so there's reason to expect the link open to succeed. It could also happen at initialization if the appropriate launch option key is available, so the app knows it was launched from a link.
Further, the data model here is not exactly request-response. A request gets only a single response. (Yes, there are some odd models here and there that don't conform, but this is generally the case.) The model here is a subscription to a stream of asynchronous events. In fact, with the addition of these notifications, the subscription is established through the NotificationCenter, and subscription now clearly (and correctly) is unrelated to initialization. Calling initSession may result in a series of requests with individual responses, but that's a matter of implementation. It's most natural to expect the app to be called back only when events of interest occur. Every request to the server will generate a response. Every response need not (and should not) be passed back to the app, only those that indicate events of interest to the app. And the notifications should be used to distinguish different types of event.
I think this is the right idea:

BranchSessionDidStartNotification: Indicates initialization success. Generated only once, because the app initiated the session.
BranchSessionDidFailToStartNotification: Indicates initialization failure. Generated only once, because the app initiated the session.
BranchLinkWasOpenedNotification: Indicates that a link was successfully opened. Generated every time a link is actually opened and available. Includes the link and all relevant data from the server. This is generated in addition to BranchSessionDidStartNotification if an app is launched from a link. Links are irrelevant to initializing a session except as an implementation detail. There should be no need to handle it in more than one notification.
BranchLinkDidFailToOpenNotification: Indicates that an open request initiated by the app failed.

Arguably, you can live with the same notification used for success and error, with an optional error element that indicates failure. I think smaller interfaces are better, and so is finer semantic distinction. There is precedent in lots of delegate protocols, e.g. WKNavigationDelegate.
I don't think there's any need to hold up merging this PR, though the behavior of BareBones might be improved, at least in app code. I think this could easily live in staging for a while, and you could refine it over time.

Thanks for this write up Jimmy. I think the analogy is sound and the original pattern does have its flaws. My original thought when implementing the consistent callback was that "developers will call initialize session and register a deep link handler callback expecting a response, so we better respond 100% of the time a session initializes." That's why the methods are named as such. There were some unwanted behaviors that we tied the definition of session to foreground/background, like session reinitialization in system alerts (push notifs, location etc), but it delivered a consistent response when a session was initialization otherwise.
However, your point here is very relevant. Developers are registering for notifications and should not be alerted when there's no data to process. It looks like we have this functionality under BranchLinkWasOpenedNotification, so it's possible for the developer to register for just the relevant stuff. The issue you're taking is mostly with the testbed, no?

Thanks for taking the time with all the thoughtful feedback.
I don't want to leave your comments hanging but I don't have much time today to respond. In short, maybe we should better communicate that a Branch session isn't just the first time the app opens, it can happen multiple times during a normal app life time.  Foreground / Notifications and other events can start a new Branch session.  That said, often the first app run is special. Do you think it would be convenient to have a special indicator for first Branch initialization?
Also I want to mention that the issue with the BareBones example showing the last link opened is a bug that I've fixed. I'm still testing the fix before I push it.

Thanks @aaustin and @E-B-Smith. Nothing's ever perfect, and hindsight is always 20/20. I'm not always sure if my point will get across, so I may have both overstated and diluted what I wanted to say.
Here it is in bullet points:

The current API for the SDK is low-level. Works great, and lots of apps build a great deep-linking experience on it. But there's currently only one entry point, often a block literal in the AppDelegate, that just tells the app that something somewhere happened, maybe a link open, maybe an error, maybe nothing. Please examine the data to determine what happened and what you need to do.
What an app really wants is to be told that an event of interest occurred and receive just the relevant data.
Changing the existing behavior might be good, but changing things is risky, and that probably at least requires some review.
This is a really nice improvement to the SDK, and it offers an excellent opportunity to address these semantic issues.
I like what's been done, but I would argue for more notifications and more delegate methods with a finer grain.

I'll just add an example to show why I think this is still a little complicated. This is from BareBones:
    @objc func branchDidStartSession(notification: Notification) {
        WaitingViewController.hide()

        let url : URL? = notification.userInfo?[BranchURLKey] as? URL

        if let error = notification.userInfo?[BranchErrorKey] as? Error {
            if let url = url {
                self.showAlert(
                    title: "Couldn't Open URL",
                    message: "\(url.absoluteString)\n\n\(error.localizedDescription)"
                )
            } else {
                self.showAlert(title: "Error Starting Branch Session", message: error.localizedDescription)
            }
            return
        }
        if let buo = notification.userInfo?[BranchUniversalObjectKey] as? BranchUniversalObject {
            let linkViewController = LinkViewController.instantiate()
            linkViewController.branchObject = buo
            linkViewController.branchURL = url
            navigationController?.pushViewController(linkViewController, animated: true)
            AppStats.shared.linksOpened += 1
            return
        }
    }

That's a large method with multiple purposes. If the delegate methods were more finely-grained:
@objc func branchDidStartSession(branch: Branch) {
    NSLog("Branch started successfully") // nothing to do
}

@objc func branch(branch: Branch, didEncounterInitializationError error: Error) {
    showAlert(title: "Error Starting Branch Session", message: error.localizedDescription)
}

@objc func branch(branch: Branch, didEncounterLinkOpenError error: Error, withURL url:URL) {
    WaitingViewController.hide()
    showAlert(title: "Couldn't Open URL", message: "\(url.absoluteString)\n\n\(error.localizedDescription)")
}

@objc func branch(branch: Branch, didOpenLink link: BranchLink, withURL url: URL) {
    WaitingViewController.hide()

    let linkViewController = LinkViewController.instantiate()
    linkViewController.branchObject = link.universalObject
    linkViewController.branchURL = url
    navigationController!.pushViewController(linkViewController, animated: true)
    AppStats.shared.linksOpened += 1
}

Note: No optionals. No guards. No pyramid code. Trivial to read and maintain because
no contextual interpretation is necessary. When an open event happens, the URL and
BranchLink are not optional. How can you open a link without a link? The original uses
notifications, which are generic objects, so you'll always at least have something like:
let url = notification.userInfo![BranchURLKey] as! URL

This is always a trade-off between notifications and delegates, so I chose the delegate
in order to illustrate the point more clearly, but you can simplify notification handling
along these lines as well using multiple notification types. And multiple notifications can let you fan out these tiny tasks to multiple code units. With a single notification, these events always
force you through a single selector, and you have to do the fanout yourself.
When a single notification or delegate method is reused with lots of parameters, you always have to have if-else blocks, guards and so on.
Again, I clicked "approve" on the original PR, and except for the bug fix Ed's working on, I'd say this can be merged. But I'd also give some thought to further improvements along these lines, since this is new.

I think I need to review more in depth. I don’t think it’s a good idea to implement a notification that alerts every session open. It should only alert when link data is present. Can’t the developer register for the BranchLinkWasOpened notification and not need all that ghetto logic to check it link data is present? Listening to every session is optional and shouldn’t be recommended. Otherwise, it’s the exact same thing as my original callback block implementation.

Result of Integration 17
Duration: 9 minutes and 53 seconds
Result: 1 error, failing state: build-errors

I have a feeling we could arrive at a clear understanding if we all jumped on a 10-min. video call or something.
On a tangential note, with regard to notifications, Apple's MPMusicPlayerController has two methods: beginGeneratingPlaybackNotifications and endGeneratingPlaybackNotifications. These are useful when working with that utility because the alternative is to constantly remove and add observers for several different notifications generated by the MPMusicPlayerController. I think the NotificationCenter and OperationQueue together are smart enough to short-circuit early if there are no observers for a notification, so there's no significant cost to posting a notification if no one's listening. The point is that there is precedent for not generating notifications at all by default and requiring the app to turn them on if it wants to use them. That would be an option here. I'm not sure if it's needed or even a good idea. It's just food for thought.

Result of Integration 19
Duration: 9 minutes and 57 seconds
Result: All 204 tests passed, but please fix 1 warning.
Test Coverage: 62%

Result of Integration 20
Duration: 9 minutes and 43 seconds
Result: Build failed 1 test out of 204

Result of Integration 21
Duration: 10 minutes and 13 seconds
Result: All 204 tests passed, but please fix 1 warning.
Test Coverage: 62%

Result of Integration 22
Duration: 10 minutes and 22 seconds
Result: Build failed 2 tests out of 204

Result of Integration 23
Duration: 10 minutes and 16 seconds
Result: Build failed 2 tests out of 204

Result of Integration 24
Duration: 10 minutes and 5 seconds
Result: Build failed 1 test out of 204

Result of Integration 25
Duration: 10 minutes and 2 seconds
Result: All 204 tests passed, but please fix 1 warning.
Test Coverage: 62%

Result of Integration 26
Duration: 9 minutes and 26 seconds
Result: All 204 tests passed, but please fix 1 warning.
Test Coverage: 62%

Result of Integration 28
Duration: 9 minutes and 28 seconds
Result: Build failed 1 test out of 204

Result of Integration 29
Duration: 9 minutes and 18 seconds
Result: 1 error, failing state: build-errors

Result of Integration 30
Duration: 9 minutes and 55 seconds
Result: All 204 tests passed, but please fix 1 warning.
Test Coverage: 62%

Result of Integration 31
Duration: 10 minutes and 36 seconds
Result: All 204 tests passed, but please fix 1 warning.
Test Coverage: 62%

Result of Integration 32
Duration: 12 minutes and 17 seconds
Result: All 204 tests passed, but please fix 1 warning.
Test Coverage: 62%

Result of Integration 34
Duration: 9 minutes and 14 seconds
Result: All 221 tests passed, but please fix 1 warning.
Test Coverage: 65%

Result of Integration 35
Duration: 9 minutes and 21 seconds
Result: All 221 tests passed, but please fix 1 warning.
Test Coverage: 65%

Result of Integration 36
Duration: 9 minutes and 19 seconds
Result: All 221 tests passed, but please fix 1 warning.
Test Coverage: 65%

Result of Integration 37
Duration: 9 minutes and 29 seconds
Result: All 221 tests passed, but please fix 1 warning.
Test Coverage: 65%

Result of Integration 38
Duration: 11 minutes and 28 seconds
Result: Build failed 1 test out of 221

Result of Integration 39
Duration: 10 minutes and 23 seconds
Result: All 221 tests passed, but please fix 1 warning.
Test Coverage: 65%

Result of Integration 40
Duration: 10 minutes and 39 seconds
Result: Build failed 1 test out of 223

Result of Integration 41
Duration: 10 minutes and 28 seconds
Result: Build failed 1 test out of 223

Result of Integration 42
Duration: 9 minutes and 49 seconds
Result: All 223 tests passed, but please fix 1 warning.
Test Coverage: 65%

Result of Integration 43
Duration: 10 minutes and 53 seconds
Result: 1 error, failing state: build-errors

Result of Integration 44
Duration: 10 minutes and 18 seconds
Result: All 223 tests passed, but please fix 1 warning.
Test Coverage: 65%

Result of Integration 45
Duration: 10 minutes and 25 seconds
Result: All 223 tests passed, but please fix 1 warning.
Test Coverage: 62%


Custom file or method for adding a domain

We should be able to maintain our own list of domains that we want to exclude without touching the data files.
Thanks.

Can you provide an example of what you are trying to achieve?  I'm unclear about the scenario for the request.

Something like
DisposableEmailChecker::add_data_source('domains.txt');
or
DisposableEmailChecker::add_domains([...domains]);

I have opted for implementing the add_domains(array) and remove_domains(array).  Thanks for the suggestion.


Make methods in INSOperationObserverProtocol protocol optional

I'm finding myself only wanting to subscribe to a few of the methods in INSOperationObserverProtocol, and noticed that other classes in the framework, like INSTimeoutObserver, effectively do the same. Perhaps the methods should be made optional so they don't need to be implemented as stubs?
Thanks for the port by the way. it's been really useful for me!

Cool thanks


Add support for akka typed

With Akka 2.6, typed actors has become the new paradigm. Would be nice to add support for it in your project.
I can help if you would like to give me some hints to get started.

Thanks for the proposal, @karolchmist! I need to look at the API to see the best way to integrate it here.

b7079655b656f34fe8e66e810a0333f69a8a527f adds support for typed actors. I'm going to update the README and release a new version in the next few days.


include DistributionForecast and make plot generic

Issue #, if available:
Description of changes:
Include DistributionForecast and make plot work for all Forecast objects.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Related to #289

Job PR-316/1 is complete.
Docs are uploaded to http://gluon-ts-staging.s3-accelerate.dualstack.amazonaws.com/PR-316/1/index.html

Codecov Report

Merging #316 into master will increase coverage by 40.3%.
The diff coverage is 44.23%.

@@            Coverage Diff             @@
##           master     #316      +/-   ##
==========================================
+ Coverage   40.32%   80.63%   +40.3%
==========================================
  Files         142      142
  Lines        8024     8040      +16
==========================================
+ Hits         3236     6483    +3247
+ Misses       4788     1557    -3231

Impacted Files
Coverage Δ

src/gluonts/model/forecast.py
72.3% <44.23%> (+21.03%)
:arrow_up:

src/gluonts/dataset/artificial/_base.py
36.67% <0%> (+1.43%)
:arrow_up:

src/gluonts/core/exception.py
62.5% <0%> (+2.08%)
:arrow_up:

src/gluonts/model/trivial/constant.py
76.92% <0%> (+11.53%)
:arrow_up:

src/gluonts/kernels/_kernel_output.py
87.09% <0%> (+12.9%)
:arrow_up:

src/gluonts/model/seasonal_naive/_estimator.py
100% <0%> (+14.28%)
:arrow_up:

src/gluonts/model/npts/_estimator.py
100% <0%> (+14.28%)
:arrow_up:

src/gluonts/dataset/artificial/recipe.py
89.21% <0%> (+14.93%)
:arrow_up:

src/gluonts/model/deepar/_estimator.py
100% <0%> (+15.09%)
:arrow_up:

src/gluonts/dataset/stat.py
96.32% <0%> (+15.44%)
:arrow_up:

... and 93 more

Looks good! Thank you


TS Server fatal error:  Maximum call stack size exceeded

Type: Bug
❗❗❗ Please fill in the sections below to help us diagnose the issue ❗❗❗
TypeScript Version: 5.6.0-dev.20240814
Steps to reproduce crash

TS Server Log
❗ Server logging disabled. To help us fix crashes like this, please enable logging by setting:
"typescript.tsserver.log": "verbose"

After enabling this setting, future crash reports will include the server log.
VS Code version: Code 1.92.1 (Universal) (eaa41d57266683296de7d118f574d0c2652e1fc4, 2024-08-07T20:16:39.455Z)
OS version: Darwin arm64 23.6.0
Modes:

System Info

Item
Value

CPUs
Apple M2 (8 x 2400)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: enabled_ondirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okskia_graphite: disabled_offvideo_decode: enabledvideo_encode: enabledwebgl: enabledwebgl2: enabledwebgpu: enabledwebnn: disabled_off

Load (avg)
12, 8, 12

Memory (System)
8.00GB (0.12GB free)

Process Argv
--crash-reporter-id e3fbdaee-5c99-4817-a669-b828770bf2c0

Screen Reader
no

VM
0%

Extensions (14)

Extension
Author (truncated)
Version

codeium
Cod
1.10.11

vscode-eslint
dba
3.0.10

react-native-react-redux
EQu
2.0.6

prettier-vscode
esb
11.0.0

gluestack-vscode
glu
0.1.22

rest-client
hum
0.25.1

jbockle-format-files
jbo
3.4.0

vscode-gutter-preview
kis
0.31.2

vscode-typescript-next
ms-
5.6.20240814

color-highlight
nau
2.8.0

vscode-scss-formatter
sib
3.0.0

sass-indented
syl
1.8.31

simple-ruby-erb
vor
0.2.1

JavaScriptSnippets
xab
1.8.0

A/B Experiments
vsliv368:30146709
vspor879:30202332
vspor708:30202333
vspor363:30204092
vscod805:30301674
binariesv615:30325510
vsaa593cf:30376535
py29gd2263:31024239
c4g48928:30535728
azure-dev_surveyone:30548225
2i9eh265:30646982
962ge761:30959799
pythongtdpath:30769146
welcomedialog:30910333
pythonnoceb:30805159
asynctok:30898717
pythonregdiag2:30936856
pythonmypyd1:30879173
h48ei257:31000450
pythontbext0:30879054
accentitlementst:30995554
dsvsc016:30899300
dsvsc017:30899301
dsvsc018:30899302
cppperfnew:31000557
dsvsc020:30976470
pythonait:31006305
dsvsc021:30996838
945dj816:31013170
pythoncenvpt:31062603
a69g1124:31058053
dvdeprecation:31068756
dwnewjupytercf:31046870
impr_priority:31102340
nativerepl1:31104043
refactort:31108082
pythonrstrctxt:31112756
wkspc-onlycs-c:31111717
wkspc-ranged-c:31111712

Please try collecting the TS Server log from the crashed instance:

Set "typescript.tsserver.log": "verbose"

Restart VS Code and reproduce the problem

Open the TypeScript section of the output panel

At the very top, find the first line that prints to path to the semantic error log file. It should look something like:
[Info  - 19:54:59.247] <semantic> Log file: /Users/matb/Library/Application Support/Code - Insiders/logs/20200213T104930/exthost55/vscode.typescript-language-features/tsserver-log-ZT2zau/tsserver.log

That file contains the typescript logs.

Look through that log file for the first error or stack trace you see. If you can share the log, I can also take a look to see if anything stands out

⚠Warning: The TypeScript log may include information from your workspace, including file paths and source code. If you have any concerns about posting this publicly on Github, just let me know and we can arrange something else. On our side, we only use these logs to investigate issues like this

Duplicate of #225480. Please fill in the original issue instead of opening new ones


v3_utl.c: memory access overrun in s2i_ASN1_INTEGER()

bug: memory access overrun in s2i_ASN1_INTEGER()  in v3_utl.c
When a 1-digit decimal number is passed in, the memory value[1] is out of bounds.
please check the patch:
https://github.com/openssl/openssl/compare/master...readyu:openssl:readyu-patch-20230324-v3_utl
https://github.com/openssl/openssl/pull/20591

As per my comments in #20591 this does not look like an overrun to me.


Implement web-ui tool

Per conversation with @dottorblaster and @alfsuse.
We'd like to implement a web-UI to execute the same features we have on command-line:

deploy a plugin
deploy a group
build a group

The UI will be inside the k3ai-code in from cmd\tools\web
We will proceed by steps:

Implement the golang webserver
Implement the UI with the plugin list
Implement the UI with the group list
Deploy [2] and [3]
Implement a visual tool to create  groups

We will leave this issue open, and we are going to split it in sub-tasks

Closing due inactivity


Feature Request : Add a config option to use the gcloud proxy

This is amazing extension, I can use it in daily work with bigquery.
Is it possible to add a config option to let the extension to use the "gcloud proxy"? My company has an enterprise proxy for gcp, I found i need to setup the vscode's proxy to it , otherwise the extension can't access gcp. But unfortunetly , the gcp proxy is different with the internet proxy, if I change the vscode proxy setting, other extensions can't access internet. So could you consider to add a config option to use the gcp proxy? or can let the extention to read the existing gcloud config option to get the gcloud proxy ?

@jetdragon
Thanks for using.
I don't think BigQuery's SDK supports setting up a Proxy 😭
https://github.com/googleapis/nodejs-bigquery/issues/1021
If you find any useful documentation or issues, please let me know.


Generated SNS Topic access policy problem

I think we need to leave the default (none) access policy on the SNS topic. It should only allow principals from the current account to use the topic. The installed policy appears to cause a problem sending from the ECS container.

Fixed with #15
Default was set to us-east-1 and deploy was in eu.  Don't use defaults for this.