iOS "Location Always" returns unavailable always in the real device

Bug report

Summary
iOS device (iPhone 6s) returns unavailable for "Location Always" all the time.
Environment info
System:
OS: macOS 10.15.4
CPU: (4) x64 Intel(R) Core(TM) i5-7360U CPU @ 2.30GHz
Memory: 985.29 MB / 8.00 GB
Shell: 3.2.57 - /bin/bash
Binaries:
Node: 8.11.4 - /usr/local/bin/node
npm: 6.14.2 - /usr/local/bin/npm
Watchman: 4.9.0 - /usr/local/bin/watchman
SDKs:
iOS SDK:
Platforms: iOS 13.2, DriverKit 19.0, macOS 10.15, tvOS 13.2, watchOS 6.1
Android SDK:
API Levels: 23, 25, 26, 27, 28
Build Tools: 26.0.2, 26.0.3, 27.0.3, 28.0.3
System Images: android-22 | Google APIs Intel x86 Atom, android-23 | Google APIs Intel x86 Atom, android-26 | Google Play Intel x86 Atom, android-27 | Google APIs Intel x86 Atom, android-29 | Google APIs Intel x86 Atom
IDEs:
Android Studio: 3.6 AI-192.7<IP_ADDRESS>08749
Xcode: 11.3/11C29 - /usr/bin/xcodebuild
npmPackages:
react: 16.9.0 => 16.9.0
react-native: 0.61.5 => 0.61.5
npmGlobalPackages:
create-react-native-module: 0.16.0
react-native-cli: 2.0.1
react-native-git-upgrade: 0.2.7
Library version: 2.1.4
Steps to reproduce
const result = await check(PERMISSIONS.IOS.LOCATION_ALWAYS).then(results => results);
console.log(result);
Describe what you expected to happen:
console.log should return either "denied" or "granted". But it returns "unavailable". So I requested Location_when_in_use and it worked fine. Then again requested LOCATION_ALWAYS and again it showed "unavailable". So I manually changed permissions to Always in settings and tried to check locations again and console log printed "unavailable" again.
Then I downgrade the library version to 2.0.10 and check again. It started to work fine.
Seems like there is an issue with 2.1.4 version or some versions from 2.0.10. Also that did not work with checkMultiple too.

@samitha9125 Hi. Are you sure you add background location update capability? It makes no sense to ask for LOCATION_ALWAYS if it's not enabled.

@zoontek hi. Yes I did. It worked fine(react-native-permissions 2.1.4)on the Simulator but not in the real device. So I downgraded the version to 2.0.10 and everything started to work fine.

This is strange since there is absolutely no changes in the Location always handler or the module.ios.ts file since 2.1.0: https://github.com/react-native-community/react-native-permissions/compare/2.1.0...2.1.4
Could you submit your Podfile?

I pasted my podfile below. Also I did not use the example app because another package that I use for background locations tracking does request these permissions if I have not requested them from the user already. that package permissions handling works without any issue for Location Always permission but react-native-permission does not. So I don't think that occurs because of a device issue.
Devices I used - iPhone 6s(13.4.1) and iPhone 11 (13.4.1)
platform :ios, '10.0'
require_relative '../node_modules/@react-native-community/cli-platform-ios/native_modules'
require_relative '../node_modules/react-native-unimodules/cocoapods.rb'
target 'SampleApp' do
Pods for SampleApp
pod 'FBLazyVector', :path => "../node_modules/react-native/Libraries/FBLazyVector"
pod 'FBReactNativeSpec', :path => "../node_modules/react-native/Libraries/FBReactNativeSpec"
pod 'RCTRequired', :path => "../node_modules/react-native/Libraries/RCTRequired"
pod 'RCTTypeSafety', :path => "../node_modules/react-native/Libraries/TypeSafety"
pod 'React', :path => '../node_modules/react-native/'
pod 'React-Core', :path => '../node_modules/react-native/'
pod 'React-CoreModules', :path => '../node_modules/react-native/React/CoreModules'
pod 'React-Core/DevSupport', :path => '../node_modules/react-native/'
pod 'React-RCTActionSheet', :path => '../node_modules/react-native/Libraries/ActionSheetIOS'
pod 'React-RCTAnimation', :path => '../node_modules/react-native/Libraries/NativeAnimation'
pod 'React-RCTBlob', :path => '../node_modules/react-native/Libraries/Blob'
pod 'React-RCTImage', :path => '../node_modules/react-native/Libraries/Image'
pod 'React-RCTLinking', :path => '../node_modules/react-native/Libraries/LinkingIOS'
pod 'React-RCTNetwork', :path => '../node_modules/react-native/Libraries/Network'
pod 'React-RCTSettings', :path => '../node_modules/react-native/Libraries/Settings'
pod 'React-RCTText', :path => '../node_modules/react-native/Libraries/Text'
pod 'React-RCTVibration', :path => '../node_modules/react-native/Libraries/Vibration'
pod 'React-Core/RCTWebSocket', :path => '../node_modules/react-native/'
pod 'React-cxxreact', :path => '../node_modules/react-native/ReactCommon/cxxreact'
pod 'React-jsi', :path => '../node_modules/react-native/ReactCommon/jsi'
pod 'React-jsiexecutor', :path => '../node_modules/react-native/ReactCommon/jsiexecutor'
pod 'React-jsinspector', :path => '../node_modules/react-native/ReactCommon/jsinspector'
pod 'ReactCommon/jscallinvoker', :path => "../node_modules/react-native/ReactCommon"
pod 'ReactCommon/turbomodule/core', :path => "../node_modules/react-native/ReactCommon"
pod 'Yoga', :path => '../node_modules/react-native/ReactCommon/yoga'
pod 'DoubleConversion', :podspec => '../node_modules/react-native/third-party-podspecs/DoubleConversion.podspec'
pod 'glog', :podspec => '../node_modules/react-native/third-party-podspecs/glog.podspec'
pod 'Folly', :podspec => '../node_modules/react-native/third-party-podspecs/Folly.podspec'
React Native Permissions dependencies
permissions_path = '../node_modules/react-native-permissions/ios'
pod 'Permission-LocationAlways', :path => "#{permissions_path}/LocationAlways.podspec"
pod 'Permission-LocationWhenInUse', :path => "#{permissions_path}/LocationWhenInUse.podspec"
React Native Maps dependencies
rn_maps_path = '../node_modules/react-native-maps'
pod 'react-native-google-maps', :path => rn_maps_path
pod 'GoogleMaps'
pod 'Google-Maps-iOS-Utils'
React Native thirdparty dependencies
pod 'react-native-geolocation', path: '../node_modules/@react-native-community/geolocation'
target 'ArakshaDriverAppTests' do
inherit! :search_paths
# Pods for testing
end
use_native_modules!
use_unimodules!(exclude: [
'expo-face-detector',
'expo-constants',
'expo-file-system',
'expo-permissions',
'expo-app-loader-provider',
'unimodules-barcode-scanner-interface',
'unimodules-camera-interface',
'unimodules-face-detector-interface',
'unimodules-file-system-interface',
'unimodules-sensors-interface',
'unimodules-task-manager-interface'
])
end
target 'SampleApp-tvOS' do
Pods for SampleApp-tvOS
target 'SampleApp-tvOSTests' do
inherit! :search_paths
# Pods for testing
end
end

Also I did not use the example app because another package that I use for background locations tracking does request these permissions if I have not requested them from the user already.

That's exactly why I would like you to test the example app. To ensure that it's not an incompatibility with other libs.

I just tried with both libs (react-native-permissions to check / request permission, @react-native-community/geolocation to get the position) and everything went well (on a real device).
Check the code here: https://github.com/zoontek/rn-location-permission-example/blob/master/App.js

In my simulator too it returns "unavailable" always.

@zoontek Thank you so much for your unbelievable support. Really appreciate it. I use background geolocation to acquire user location when user is not using the app. That package itself manage permissions but only if we have not granted those permissions in advance.
I don't like random popups of permission dialogs because that would be so annoying for a user. That's why I prefer react-native-permissions which grant the capability prior to the feature request.
My Info plist.
<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
<plist version="1.0">
<dict>
	<key>CFBundleDevelopmentRegion</key>
	<string>en</string>
	<key>CFBundleDisplayName</key>
	<string>$(PRODUCT_NAME)</string>
	<key>CFBundleExecutable</key>
	<string>$(EXECUTABLE_NAME)</string>
	<key>CFBundleIdentifier</key>
	<string>$(PRODUCT_BUNDLE_IDENTIFIER)</string>
	<key>CFBundleInfoDictionaryVersion</key>
	<string>6.0</string>
	<key>CFBundleName</key>
	<string>$(PRODUCT_NAME)</string>
	<key>CFBundlePackageType</key>
	<string>APPL</string>
	<key>CFBundleShortVersionString</key>
	<string>$(MARKETING_VERSION)</string>
	<key>CFBundleSignature</key>
	<string>????</string>
	<key>CFBundleURLTypes</key>
	<array>
		<dict>
			<key>CFBundleTypeRole</key>
			<string>Editor</string>
			<key>CFBundleURLName</key>
			<string>com.sample.sampleapp</string>
			<key>CFBundleURLSchemes</key>
			<array>
				<string>sample-app</string>
			</array>
		</dict>
	</array>
	<key>CFBundleVersion</key>
	<string>$(CURRENT_PROJECT_VERSION)</string>
	<key>ITSAppUsesNonExemptEncryption</key>
	<false/>
	<key>LSApplicationQueriesSchemes</key>
	<array>
		<string>comgooglemaps</string>
	</array>
	<key>LSRequiresIPhoneOS</key>
	<true/>
	<key>NSAppTransportSecurity</key>
	<dict>
		<key>NSAllowsArbitraryLoads</key>
		<true/>
		<key>NSExceptionDomains</key>
		<dict>
			<key>localhost</key>
			<dict>
				<key>NSExceptionAllowsInsecureHTTPLoads</key>
				<true/>
			</dict>
		</dict>
	</dict>
	<key>NSLocationAlwaysAndWhenInUseUsageDescription</key>
	<string>Driver app can share your location with parents only when you are on a journy.</string>
	<key>NSLocationAlwaysUsageDescription</key>
	<string>Driver app can share your location with parents only when you are on a journy.</string>
	<key>NSLocationWhenInUseUsageDescription</key>
	<string>App easily can locate your position on map once you allow this.</string>
	<key>NSMotionUsageDescription</key>
	<string>Araksha Driver uses Motion for location optimizations.</string>
	<key>UIAppFonts</key>
	<array>
		<string>Lato-Black.ttf</string>
		<string>Lato-Bold.ttf</string>
		<string>Lato-Light.ttf</string>
		<string>Lato-Regular.ttf</string>
		<string>Roboto-Bold.ttf</string>
		<string>Roboto-Light.ttf</string>
		<string>Roboto-Medium.ttf</string>
		<string>Roboto-Regular.ttf</string>
		<string>Roboto-Thin.ttf</string>
		<string>Roboto-Italic.ttf</string>
	</array>
	<key>UIBackgroundModes</key>
	<array>
		<string>location</string>
	</array>
	<key>UILaunchStoryboardName</key>
	<string>LaunchScreen</string>
	<key>UIRequiredDeviceCapabilities</key>
	<array>
		<string>armv7</string>
	</array>
	<key>UISupportedInterfaceOrientations</key>
	<array>
		<string>UIInterfaceOrientationPortrait</string>
	</array>
	<key>UIUserInterfaceStyle</key>
	<string>Light</string>
	<key>UIViewControllerBasedStatusBarAppearance</key>
	<false/>
</dict>
</plist>

@pawtalpet check this issue. It will solve your problem :)

Everything seems fine in your plist. Could you try building the repro repo app on your iPhone to check if you have the same result as me?

I use this module in front of react-native-background-geolocation-android as well for the same reason. It works fine. Note that on new iOS the user has to actually go in to settings and manually grant always, all you can do is check here and direct the user with a dialog then open the app's settings (a different API, built in to react-native if I recall correctly) then re-check.
I was working in that area of my project just last week, all works.

@mikehardy Actually that is exactly what I did for my current project because of new iOS feature. But it did not work very well with react-native-permissions 2.1.4 version but 2.0.10 version.
@zoontek I'll use the example app and give you a feedback soon :)

@zoontek I created two projects (RN 0.62.2 and RN 0.61.5) and tried to do the same thing. react-native-Permissions worked as expected in both projects. But I have no idea why it is not working in my original project.

First, avoid using both libs to request permissions in your code (only use react-native-permissions for this)
Then try resetting your phone permissions: https://www.addictivetips.com/ios/reset-all-app-permissions-on-ios/

I will do that. Thank you so much for your awesome support. I'll close the issue now since this is not related to this library :)

@samitha9125 No problem. I hope you'll find the cause of it!

Currently, you have two libs to handle location permission: that's not useful and dangerous. react-native-permissions internal state can't communicate with react-native-geolocation internal state.

Use one or the other, not both at the same time.

This comment was helpful to me as well 💯
I also have react-native-geolocation installed and it was automatically requesting background permissions after I updated the Info.plist - thought it was this library.
But it was easy to fix: https://github.com/react-native-geolocation/react-native-geolocation#setrnconfiguration
Perhaps it would be even worth a mention in this library's README that other libraries may conflict. I think https://github.com/react-native-geolocation/react-native-geolocation is probably pretty common.

for anybody still having this issue, an extensive cleaning did the trick for me:
"ios:clean": "rm -rf ~/Library/Caches/CocoaPods && rm -rf Pods && rm -rf ~/Library/Developer/Xcode/DerivedData/* && cd ios && xcodebuild clean && pod cache clean --all && pod deintegrate && pod setup && pod install --verbose && cd ..",


tig like interface?

I find tig quite useful for specific explorations on git. I am wondering if such an interface could be a next enhancement for this project. I.e. launch the console UI with a standard activities (or any other query) table and allow an easy navigation and interaction with the issues, further filtering, etc. The issues and other related data could be specifically cached for the duration of the interface and refreshed based on a keyboard command.

I've built one already :)
https://github.com/mikepea/go-jira-ui
It needs a little bit of love (and updating to use go-jira.v1), but is
pretty functional. Let me know what you think!
On Tue, Mar 20, 2018 at 6:43 AM, rodlogic<EMAIL_ADDRESS>wrote:

I find tig https://jonas.github.io/tig/ quite useful for specific
explorations on git. I am wondering if such an interface could be a next
enhancement for this project. I.e. launch the console UI with a standard
activities (or any other query) table and allow an easy navigation and
interaction with the issues, further filtering, etc.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/Netflix-Skunkworks/go-jira/issues/156, or mute the
thread
https://github.com/notifications/unsubscribe-auth/AAAjTRrY1xASNKbIubmCykZ2lZCoWctGks5tgQd5gaJpZM4Sx6rR
.

@mikepea Aha! Let me give it a shot.

I am not planning on any curses interface for go-jira.  I recommend @mikepea's project listed previously for a curses based interface.

you could also try using fzf. for example:
jira list --query "resolution = unresolved and assignee=currentuser() ORDER BY created" | fzf --preview="echo {}| cut -d : -f 1 |xargs -I % sh -c 'jira view %'"


chore: remove unsafe-eval from script-src CSP

Description
'unsafe-eval' source can be removed after removal of NPM dependency box-intersect
Type of change
Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?

verified updated script-src content-security-policy: ... script-src 'self'; ...
no indication of scripts failing to execute.

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes

Legal
This project is available under the Apache 2.0 License.

Can you clarify what you mean by 'unsafe-eval' source can be removed after removal of NPM dependency box-intersect? When do we plan on removing box-intersect?

it was a dependency from app-kit and was removed as part of this PR. box-intersect is using new Function (aka unsafe-eval, see issue).


garage_0_8: 0.8.5 -> 0.8.6, garage: 0.9.1 -> 0.9.2

Description of changes
https://git.deuxfleurs.fr/Deuxfleurs/garage/releases/tag/v0.9.2
https://git.deuxfleurs.fr/Deuxfleurs/garage/releases/tag/v0.8.6
Signed-off-by: Raito Bezarius<EMAIL_ADDRESS>Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 292619 run on x86_64-linux 1

2 packages built:

garage (garage_0_9 ,garage_0_9_2)
garage_0_8 (garage_0_8_6)

Result of nixpkgs-review pr 292619 run on aarch64-darwin 1

2 packages marked as broken and skipped:

garage_0_8
garage_0_8_6

1 package failed to build:

garage (garage_0_9 ,garage_0_9_2)

Result of nixpkgs-review pr 292619 run on x86_64-darwin 1

2 packages marked as broken and skipped:

garage_0_8
garage_0_8_6

1 package failed to build:

garage (garage_0_9 ,garage_0_9_2)


[ODS-5584]: making SSL mount optional for AdminApp

Context
Right now Ed-Fi Docker images are hardwired to only run if they have an SSL certificate mounted in a docker volume. This makes it incompatible to run in a cloud environment where SSL encryption is usually handled by another service like a load balancer or an API Gateway. An example of this behavior can be seen in the link below.
https://github.com/Ed-Fi-Alliance-OSS/Ed-Fi-ODS-Docker/blob/5ae5208f3dde940ae14e5fc93a79323419e77b21/Web-Ods-AdminApp/Alpine/pgsql/run.sh#L44
Solution
Modify Ed-Fi Docker images so that the SSL mount is optional

This will be included on the next tag from main for ODS/API 6.0+, but we'll need to cherry-pick it onto the last 5.3 tag. Will update here when that's complete.

@FluentGuru The image is available now at edfialliance/ods-admin-app:2.1.4. Let us know if you have any other issues and thanks again!

@pmcvtm Understood! Thank you very for expediting the merge!


Bug in assigning color to duplicate letters

Hi,
I was trying Fibble's day 226 word, whose answer is SURGE. One of the words I attempted was EVENS, which has two Es, and the program told me that both Es were wrong.  Here's what I concluded:
If there were an R in the word, then the R in SWEAR would be wrong, therefore the yellow E in the middle would be correct. Since EVENS has a black E in the third position, it must be wrong. therefore, the third E should be yellow or green. However, it could not have been yellow, since the Wordle rules state that when you type a letter twice, but there is only one in the word and in neither the positions you typed, the first one is yellow and the second one is black. Since the first one in EVENS is black and I know it's correct, the second E must be green, which contradicts the fact that the E in SWEAR is yellow. I then concluded that there was no R in the word.
However, there WAS an R. So the lie in EVENS was on the second E. This means that the correct version of EVENS would have the first E black and the second E yellow. Shouldn't that never happen?
(Here's a screenshot:)

The lie on EVENS is on the first E, though? I'm not sure why your logic or theorizing banned that.
The first E is yellow (in reality). The second E, as per normal Wordle rules, is grey, and truthfully appears as such.
The lie table for that game is
2 (R is yellow > grey)
3 (U is yellow > grey)
3 (A is grey > green)
1 (E is yellow > grey)
5 (S is yellow > grey)
1 (R is yellow > grey)
5 (R is yellow > grey)
2 (N is grey > green)
2 (N is grey > yellow)
I think big factor tricking you is that it's very easy to assume that if the same letter in the same position gives two different colors, at least one of them must be a lie. But you created the situation where normal Wordle rules would cause them to be different, as you mention, and they are both true.
Really unlucky complex rules interaction, but I do think it's working as intended.


[io_callback] Adds test for io_callback being used inside custom partitioning

Offline chatted with @hawkinsp on fixing the crash when using io_callback inside the custom partitioning.
The test is currently skipped because of a JAX bug that the lifetime of the _callback wrapper inside emit_python_callback is not well managed after the lowering rule dies.  That would lead to io_callback not working inside custom_partitioning. (Credit to @hawkinsp )
Here I provided a test that can repro the issue and guard the behavior after the issue is fixed.

@pschuh could you ptal at this one? The issue is that callback object isn't kept alive if called from a partition call, because that call uses an ephemeral MLIR module context, which means the host_callback doesn't end up getting kept alive by the executable. This causes a use-after-free.

It doesn't look that simple. lowering_result.keepalive yes does need to have its lifetime extended, but there are two other problems with doing effects inside custom partitioning:

lowering_result.host_callbacks must be properly populated but this list must be passed as an argument to backend.compile(), but it wouldn't be completely known until compilation has reached spmd partitioning.
tokens are not properly added to the computation but we don't know which effect tokens are needed before we end up lowering the body.


Dockerfile example

Dockerfile that works for me if anyone's interested.
FROM nvidia/cuda:11.0.3-devel-ubuntu20.04

ENV DEBIAN_FRONTEND=noninteractive

RUN apt-get update && \
    apt-get install python3 -y && \
    apt-get install python3-pip -y && \
	apt-get install git ffmpeg libsm6 libxext6 -y

RUN cd ./home && \
	git clone https://github.com/Janspiry/Palette-Image-to-Image-Diffusion-Models
#I only clone this for the requirements.txt.  I run palette from mounted drive /root/data

RUN pip3 install \
	torch==1.7.0+cu110 \
	torchvision==0.8.1+cu110 \
	-f https://download.pytorch.org/whl/torch_stable.html

RUN pip3 install -r ./home/Palette-Image-to-Image-Diffusion-Models/requirements.txt

WORKDIR ./root/data

Run with something like
docker run --rm --gpus all -it -v <path_to_palette_repo>:/root/data -v palette

@trufty so do you manually clone a copy of the repo to ./root/data? Haven't used docker much, but interested in getting this running. Having trouble with other installation methods #20 #21 #22.

@trufty thanks! I will probably give this a try at some point.

Feel free to reopen the issue if there is any question

@Janspiry can you make it so people can reproducibly use your code? For example, add unit tests integrated with GitHub actions.

That's good advice, but need some time.
Considering that other users can work well, I think there is a bias in the operation.


Set all swal lib

Thank you for your contribution!
I'm closing this PR because the library is no longer under development/maintenance at SocialBase.


Apply AboutDroidKaigiDetail design

Idea Description
The image has been changed for the AboutDroidKaigiDetail for dark mode
Reference images and links

i want to do this :raised_hand_with_fingers_splayed:


Add com.google.fonts/check/os2/fsselectionbit7 check

Closes https://github.com/googlefonts/fontbakery/issues/3241

@felipesanches Will address all of your change requests this week

Question about testing in https://github.com/googlefonts/fontbakery/pull/3314#discussion_r641836410, otherwise I think that I addressed everything in the review.

I will comment out the SKIP-test so that I can look at it more carefully later and I'll merge the rest as it is looking good.
If I recall correctly, there was some caveat with testing SKIPs. I'll verify if that's the case here.

@googlebot I consent.

I will comment out the SKIP-test so that I can look at it more carefully later and I'll merge the rest as it is looking good.
If I recall correctly, there was some caveat with testing SKIPs. I'll verify if that's the case here.

Ty!


check error message when genesis/last block "too old"

check ToObject instances of: TraceForgeEvent
-- | Trace the forging of a block as a slot leader.
data TraceForgeEvent blk = ... |
  -- | We should have produced a block, but didn't, due to too many missing
  -- blocks between the tip of our chain and the current slot
  --
  -- As a sanity check, we record also the failure returned by
  -- 'anachronisticProtocolLedgerView', although we expect this to be
  -- 'TooFarAhead', never 'TooFarBehind'.
  | TraceCouldNotForge SlotNo AnachronyFailure

from the logs:
[nixos19:cardano.node.Forge:Warning:62] [2019-11-29 16:35:58.00 UTC] {"kind":"TraceCouldNotForge","reason":"TooFarAhead","slot"
:103923}

so this works pretty nice. :+1:


Pinia with version 2.2.0 is required

I tried to use the package for my project, however after a weird issue in the console and some time looking into the issue, I found that my error is probably due to a feature missing in my version of Pinia (2.0.26) and seems like that feature is added in 2.2.0. The action helper was added to defineStore.
The error I was getting:
Uncaught TypeError: Cannot destructure property 'action' of 'undefined' as it is undefined.

The related code snippet:

I thought I had specified this in peerDeps but clearly not.
Upgrade pinia and you are good to go 🙂


Have only sorted_accum in WitnessEntities

resolved by https://github.com/AztecProtocol/aztec-packages/pull/3479


pkg/operator: Update resource DeepCopies to happen earlier

To ensure we are never mutating the objects returned from the cache,
create the copy immediately after it's retrieved.

Mostly I moved them to ensure we're never mutating them before deepcopying, which is required to avoid breaking the informer cache/deltaFifo queue.


Tasks got stuck in "Pending" states forever caused by empty callback

One day, when the druid (0.11.0) cluster restarting, I found some tasks stuck in pending task list. After several days, the cluster worked well, but these tasks still stuck here. Every modules are normal expect these task.
But actually, these tasks had done in SUCCESS states due to log of overlord, and data from these tasks had injected into Druid which appeared in coordinator console.
After analyzing source code (0.12.0 has same code), I found there seems like a tiny bug.
In the normal process, overlord restarts in following procedures:

waiting for leader selecting
waiting for several second before starting manage() in TaskQueue thread
restoring tasks and normal attach callback function
adding tasks in pending task

For MiddleManager, it can restore all tasks which was running before restarting, and register these tasks in Zookeeper. And now, Overlord can receive CHILD_ADDED from running tasks, and updating running task list. But if Overlord receive Zookeeper task running event before starting manage(), it will register an empty callback. And the pending task list can not be clear forever.
Through breaking point in TaskQueue and waiting for Zookeeper event can reproduce this bug.
Finally, this bug can be judged by 2 scenarios:

tasks stuck in pending task list forever in Overlord console
normal callback resisted in Map<String, ListenableFuture> taskFutures can never  be clear up. TaskQueue:260

Even though it is just a display bug, it makes users feel quite confused.
Registering a valid callback in CHILD_ADDED and CHILD_UPDATE instead of a empty callback when new a RemoteTaskRunnerWorkItem can fix it. RemoteTaskRunner:978

Is this still an issue?


This repository is dead. Don't use.

It just won't include any of the components/controllers/services/directives.
This is broken.
Made me lose a HUGE amount of time.

I've added a note to the top of the README that this project is no longer maintained. Sorry about that


Few miscellaneous fixes

These two comes from a cleanup of the stash on my local machine.
They seems to make sense... please @bjackman have a look feel free to rebase-merge if you think there are not bold errors ;-)

This is stale code which requires a big refactoring and testing... let's got back to these points if we ever get hits from the same issue in the future.


OID Value

Currently I use this fake OID value (next available one after blake2 family) but we probably need an official one to be defined
1 3 6 1 4 1 1722 12 2 3 8  : BLAKE3            : blake3
Reference: http://www.oid-info.com/cgi-bin/display?oid=1+3+6+1+4+1+1722+12+2&action=display

Apologies for leaving this one hanging for so long. Does anyone know who did this for BLAKE2?

http://www.oid-info.com/cgi-bin/display?oid=<IP_ADDRESS>.4.1.1722&action=display
Implies that <IP_ADDRESS>.4.1.1722 was registered to Kudelski SA by Éric Chaubert
if blake3 is no longer associated with above entity, you can ask anybody else to regiester a new oid under their own org.
For example Debian Project has an OID and I guess could register an OID for blake3 if one asks nicely http://oid-info.com/get/<IP_ADDRESS>.4.1.9586.100

I think without OID, I will not be able to contribute blake3 to libgcrypt and thus use it for Apt by default.

Is there a draft RFC submitted for blake3 to IETF?

Apperantly it is trivial to apply for oids. I.e. instructions on https://ldapwiki.com/wiki/How To Get Your Own OID imply that it's just a short form, and then one can have a BLAKE3 oid.

@veorq Hi, would you be able to assist us in allocating / registering / publishing the O.I.D for BLAKE3 under the same O.I.D. as blake2?
Specifically we are hoping to allocate something similar to the BLAKE2 O.I.D. http://oid-info.com/get/<IP_ADDRESS>.4.1.17<IP_ADDRESS>.8
I.e. http://oid-info.com/get/<IP_ADDRESS>.4.1.17<IP_ADDRESS>.8 which would then stand for {iso(1) identified-organization(3) dod(6) internet(1) private(4) enterprise(1) 1722 Kudelski SA cryptography(12) hashAlg(3) for BLAKE3 and 8 for BLAKE3-256 as specified at blake3.io
I hope continuation of keeping the OIDs next to each is ok with you.
Thank you for your time.

I have now submitted http://oid-info.com/get/<IP_ADDRESS>.4.1.17<IP_ADDRESS>.8 which is pending oid-info review.
Will submit a pull request to the spec document too.

https://github.com/BLAKE3-team/BLAKE3-specs/pull/4/files

http://oid-info.com/get/<IP_ADDRESS>.4.1.17<IP_ADDRESS>.8 is now live, I think this issue can be closed now.

Apologies for not chiming in on this sooner. There isn't a lot of established practice on this yet, but I've argued for avoiding labels like blake3-256, in favor of just calling it blake3 as much as possible. I wrote out a longer version of my reasoning here: https://github.com/BLAKE3-team/BLAKE3-specs/issues/3. Here's a shorter version:

"BLAKE3-128" is not domain-separated from "BLAKE3-256". The former is just a truncated version of the latter. This is in contrast to BLAKE2, where shorter output lengths were domain-separated.
"BLAKE3-512" offers no additional security over "BLAKE3-256". This is in contrast to BLAKE2b-512, which does offer more security than BLAKE2b-256. (Note that BLAKE3 is derived from BLAKE2s, and there is no such thing as BLAKE2s-512.)

The vast majority of applications using BLAKE3 should stick to the default output length. I think truncated BLAKE3 should be about as common as truncated MD5. Extended outputs are useful in niche applications, like deriving very long or oddly-sized keys for uncommon algorithms, but again not something most applications should think about using. (And because different output lengths aren't domain separated, there's no real sense in which different lengths represent different algorithms.)
As far as I can tell, hash algorithm sets with multiple labeled sizes are only as common as they are because of old government standards. BLAKE3 tries as much as possible to remove unnecessary choices. We've avoided concerning the caller with details like the word size or the parallelism degree, and it would be nice not to concern them with output size either.

Apologies for not chiming in on this sooner. There isn't a lot of established practice on this yet, but I've argued for avoiding labels like blake3-256, in favor of just calling it blake3 as much as possible. I wrote out a longer version of my reasoning here: BLAKE3-team/BLAKE3-specs#3. Here's a shorter version:

"BLAKE3-128" is not domain-separated from "BLAKE3-256". The former is just a truncated version of the latter. This is in contrast to BLAKE2, where shorter output lengths are domain-separated.
"BLAKE3-512" offers no additional security over "BLAKE3-256". This is in contrast to BLAKE2b-512, which does offer more security than BLAKE2b-256. (Note that BLAKE3 is derived from BLAKE2s, and there is no such thing as BLAKE2s-512.)

The vast majority of applications using BLAKE3 should stick to the default output length. I think truncated BLAKE3 should be about as common as truncated MD5. Extended outputs are useful in niche applications, like deriving long or oddly-sized keys for uncommon algorithms, but again not something most applications should think about using. (And because different output lengths aren't domain separated, there's no real sense in which different lengths represent different hash functions.)
As far as I can tell, sets of hash functions with multiple labeled sizes are only as common as they are because of old government standards. BLAKE3 tries as much as possible to remove unnecessary choices. We've avoided concerning the caller with details like the word size or the parallelism degree, and it would be nice not to concern them with output size either.

Cool, so it's blake3. But that doesn't change the oid numbers right? cause it's just <IP_ADDRESS>.4.1.17<IP_ADDRESS>.8 no? and that's the only id registered so far, which i guess should be refer to as just BLAKE3. Or do you dislike that OID number too somehow? I think we do need to specify a child number of .3 and .8 is just as good as any other number.
I guess i should update https://github.com/BLAKE3-team/BLAKE3-specs/pull/4/files to not mention -256, and just call it blake3 there too.

I'm unfamiliar with how OIDs work in general, so I might be misunderstanding things. It looks like <IP_ADDRESS>.4.1.17<IP_ADDRESS> is registered as blake3 and <IP_ADDRESS>.4.1.17<IP_ADDRESS>.8 (one extra number on the end) is registered to blake3-256. I guess I was hoping that only the former would exist? But if that clashes with how other hashes are defined, I suppose it's really not a big deal. Also am I seeing correctly that no OIDs are defined for any hash other than BLAKE2 and BLAKE3? Maybe this system is less widely used than I assumed from my initial impression?

I'm unfamiliar with how OIDs work in general, so I might be misunderstanding things. It looks like <IP_ADDRESS>.4.1.17<IP_ADDRESS> is registered as blake3 and <IP_ADDRESS>.4.1.17<IP_ADDRESS>.8 (one extra number on the end) is registered to blake3-256. I guess I was hoping that only the former would exist? But if that clashes with how other hashes are defined, I suppose it's really not a big deal. Also am I seeing correctly that no OIDs are defined for any hash other than BLAKE2 and BLAKE3? Maybe this system is less widely used than I assumed from my initial impression?

There are OIDs for all hash algos under the sun. You are looking at only those registered by a single private company with 1722. All OIDs are scoped by company IDs.

It seems there is mish mash of OIDs and we can do whatever, i.e.:

SHA1 http://oid-info.com/get/<IP_ADDRESS>.2.26
SHA256 http://oid-info.com/get/2.16.8<IP_ADDRESS>.4.2.1
SHA3 http://oid-info.com/get/2.16.8<IP_ADDRESS>.4.2.9

So yeah, we can drop <IP_ADDRESS>.4.1.17<IP_ADDRESS>.8 and just have <IP_ADDRESS>.4.1.17<IP_ADDRESS> as "blake3" hash algorithm.
But I now wonder if we should allocate OID for every mode of BLAK3 and if more modes might be added later (unlikely). Cause <IP_ADDRESS>.4.1.17<IP_ADDRESS> means hash(input) mode right? What are the OIDs for keyed_hash and derive_key modes? Just use the same ones? or have like 3.1, 3.2, 3.3 for them? Or move the keyed_hash to be under hmacs somewhere under http://oid-info.com/get/<IP_ADDRESS>.4.1.1722.12.3?

I'm unfamiliar with how OIDs work in general, so I might be misunderstanding things. It looks like <IP_ADDRESS>.4.1.17<IP_ADDRESS> is registered as blake3 and <IP_ADDRESS>.4.1.17<IP_ADDRESS>.8 (one extra number on the end) is registered to blake3-256. I guess I was hoping that only the former would exist? But if that clashes with how other hashes are defined, I suppose it's really not a big deal. Also am I seeing correctly that no OIDs are defined for any hash other than BLAKE2 and BLAKE3? Maybe this system is less widely used than I assumed from my initial impression?

re 256 => blake produces arbitrary length output, but in keyed_hash mode requires a 256-bit key. Hence 3.8 kind of makes sence as a catch all for all three modes of blake3, no?


[BUG] On Mobile Devices this Footer Section should be centered

Description
The Copyright and links should be centered in the layout as it is more convenient to use with one hand
Screenshots

Any additional information?
No response
What browser are you seeing the problem on?
Chrome
Checklist

[X] I have checked the existing issues
[X] I have read the Contributing Guidelines
[X] I have read the discussion tab thoroughly and got the project idea
[X] I am willing to work on this issue (optional)
[X] I am a GSSoC'23 contributor

@rohansx Please assign me this issue under GSSoC 23

@ManasMadan i guess no need for this now


[VSCode] Undo is not supported in some cases

Hi,
I noticed that the undo in VSCode is not working in some cases, for example when you create a decision or new input nodes (and so on).
In addition to those cases, it does not work when you set the type for the decisions and you try undo the steps (but actually in those cases I might agree that the undo should just work on the visual components, i.e. it should not undo stuff on the background like type of decisions and other properties).

@roota that's expected for now, the Undo/Redo commands from vscode are not yet bound to the extension state control. We are aiming to the new VSCode API to finally doing it.
Thanks for your message, I'll keep you posted as soon as we integrate it.

@r00ta I'll be tackling the issue on this JIRA https://issues.redhat.com/browse/KOGITO-883, hopefully it will be ready soon ;)

Fixed by: https://github.com/kiegroup/kogito-tooling/commit/b203e71065a8d5bde6a364c0ca7bf47f537d18c8


Improve compilation time of the Haskell backend

Documenting some things we talked about:

adding option -j6 dropped the compilation time from 3m15 to 2m12 on my AMD5950x
executables are built in series, we could investigate if there is a way to parallelize that.
we could also ask the Serokell guys if they have ideas about how to improve compile performance. It's not in the initial list of tasks, but maybe they have some pointers.
installing, configuring, and running make on the haskell backend. Any solution we find should strive to maintain that.


Adding more tests

Codecov Report

Merging #299 (c15253d) into master (66e666b) will increase coverage by 1.68%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master     #299      +/-   ##
============================================
+ Coverage     66.40%   68.08%   +1.68%
- Complexity      979     1008      +29
============================================
  Files           163      163
  Lines          3268     3271       +3
  Branches        447      449       +2
============================================
+ Hits           2170     2227      +57
+ Misses          972      922      -50
+ Partials        126      122       -4

Impacted Files
Coverage Δ

...rc/main/java/seedu/address/logic/LogicManager.java
77.27% <ø> (+46.83%)
:arrow_up:

...u/address/storage/JsonSerializableAddressBook.java
100.00% <100.00%> (+22.85%)
:arrow_up:

...main/java/seedu/address/commons/util/FileUtil.java
77.27% <0.00%> (+4.54%)
:arrow_up:

src/main/java/seedu/address/model/AddressBook.java
67.21% <0.00%> (+4.91%)
:arrow_up:

...in/java/seedu/address/model/module/ModuleName.java
80.00% <0.00%> (+10.00%)
:arrow_up:

.../java/seedu/address/model/module/ModuleCredit.java
77.77% <0.00%> (+11.11%)
:arrow_up:

.../seedu/address/logic/parser/AddressBookParser.java
23.25% <0.00%> (+18.60%)
:arrow_up:

.../seedu/address/storage/JsonAddressBookStorage.java
100.00% <0.00%> (+28.57%)
:arrow_up:

.../java/seedu/address/storage/JsonAdaptedModule.java
100.00% <0.00%> (+38.46%)
:arrow_up:

... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


feat(trip): activateCrashDetection

You also need to add your method in the class DrivekitTripAnalysis (with some documentation), in this file : packages/drivekit_trip_analysis/flutter_drivekit_trip_analysis/lib/flutter_drivekit_trip_analysis.dart
Otherwise well done, and we'll see tomorrow how to test and complete the example 😁


IndexError: string index out of range on training/synthetic_osm_data_xml.xml

I tested this on both Python 3.5.1 :: Anaconda 2.4.1
Master branch
parserator train training/synthetic_osm_data_xml.xml    usaddress

training model on 16148 training examples from ['training/synthetic_osm_data_xml.xml']
Traceback (most recent call last):
  File "/Users/chengguangnan/anaconda/bin/parserator", line 11, in <module>
    sys.exit(dispatch())
  File "/Users/chengguangnan/anaconda/lib/python3.5/site-packages/parserator/main.py", line 37, in dispatch
    args.func(args)
  File "/Users/chengguangnan/anaconda/lib/python3.5/site-packages/parserator/main.py", line 66, in train
    training.train(module, train_file_list)
  File "/Users/chengguangnan/anaconda/lib/python3.5/site-packages/parserator/training.py", line 92, in train
    trainModel(training_data, module)
  File "/Users/chengguangnan/anaconda/lib/python3.5/site-packages/parserator/training.py", line 25, in trainModel
    X.append(module.tokens2features(tokens))
  File "/Users/chengguangnan/anaconda/lib/python3.5/site-packages/usaddress-0.5.5-py3.5.egg/usaddress/__init__.py", line 263, in tokens2features
    token_features = tokenFeatures(token)
  File "/Users/chengguangnan/anaconda/lib/python3.5/site-packages/usaddress-0.5.5-py3.5.egg/usaddress/__init__.py", line 235, in tokenFeatures
    features = {'abbrev' : token_clean[-1] == u'.',
IndexError: string index out of range

Also, how was the default .crfsuite built? Since 'training/*.xml' will throw an error.

hey @chengguangnan - that's odd, I'll look into it
the default .crfsuite model file is built w/ parserator train training/labeled.xml usaddress
& for using a glob pattern w/ parserator, it needs to be quoted, e.g. parserator train "training/*.xml" usaddress

This looks like it's closed. If the issue returns, let us know!


New rule proposal: use 'var' whenever possible (consistency, maintainability)

We use var in our codebase whenever possible, but as new people come on board they may be used to the tediousness of declaring local variable types. Apart from reducing the number of namespaces imported (and, therefore, collisions), it also avoid having to know exactly what type a method or property will return.
But I'd like to be able to flag local declarations whenever var is possible rather than try to catch it in PR reviews or later after the fact.
For example, these are examples that should use var when such a rule is enabled.
ConsoleColor color = ConsoleColor.Red;
IEnumerable<string> ids = packages.Select(package => package.Id);

There are, of course, times when it's not possible but, in my experience, very few.
ConsoleColor color;
Enum.TryParse(typeof(ConsoleColor), "red", out color);

string id = null;
foreach (var package in packages)
{
    if (CheckSomething(package))
    {
        id = package.Id;
    }
}

I'm almost certain a duplicate of this was created already, but now I can't find it. There are two reasons why I don't like this rule:

Readability: StyleCop tends to prefer explicit code to implicit code. For example, omitting private on a method is not allowed. For consistency with StyleCop itself, I could only ever support a version of this rule which falls into two categories:
a. Only use var where the type is obvious - specifically in cases where the value is a cast, as, or new expression, is not a primitive type or string
b. Never use var except where required (certain anonymous types)
Versioning: I believe this would be the first code fix introducing C# 6+ syntax, which could cause a problem for some users. Eventually this will just not be a problem anymore, but for now it weighs against what I see as an unfavorable rule.

That said, I know the DotNetAnalyzers/VarUsageAnalyzer project aims to provide this functionality, along with code-cracker and possibly new features in Visual Studio 2015 itself.

This is included in VS15 preview.
https://www.visualstudio.com/en-us/news/releasenotes/vs15-relnotes

This is possible using .editorconfig in VS2017. Closing.


Add Rate

Add Rate as ValueObject

Coverage remained the same at 100.0% when pulling a2dc750d9dd3ed3d3a4761de1a1f69b51f6dab01 on add-rate into e8c56597f5fd5d62a9c910a573fe5aa3dc3d7c3e on develop.

Coverage remained the same at 100.0% when pulling 58f91ff308ece89ecd26f6d3227f072fda9352d9 on add-rate into e8c56597f5fd5d62a9c910a573fe5aa3dc3d7c3e on develop.

@MasayukiFukada Oops, I Fixed it.

OK


issue of the result of VESPCN

Hello, the PSNR of VESPCN is worse than that in the paper. What is the reason?

Hi @AIRedWood
There's a related issue #10, please @ me again if anything still unclear.

you said in issue10:
PSNR we use to metric the performance is calculated a bit tricky:
In the code of mine, I directly get PSNR on 3 channels (RGB, or just 1 for Y);
But in the research, people do this. First translate RGB image into YUV via the matlab function rgb2ycbcr, and only calculated on its Y channel (luminance channel), in this way the PSNR can increase about 2dB (surprised?)
and  the code in vespcn:
self.metrics['psnr'] = tf.reduce_mean(tf.image.psnr(label_center, sr, 255))
But I don't know how to call rgb2ycbcr. Can I use YUV mode to calculate PSNR in the training code?

I run the coomand:
python run.py --mode=eval --input_dir=/VSR/Results/vespcn/MYDATA --test=vid4 --l_only --enable_psnr --enable_ssim
It shows:
frames += self._process_at_file(file, file.frames)
File "../VSR/DataLoader/Loader.py", line 353, in _process_at_file
frames.append(self._vf_gen_custom_pair(vf, depth, i))
File "../VSR/DataLoader/Loader.py", line 322, in _vf_gen_custom_pair
frames_lr = [img for img in vf.pair.read_frame(depth)]
File "../VSR/DataLoader/VirtualFile.py", line 346, in read_frame
image_bytes = [BytesIO(self.read()) for _ in range(frames)]
File "../VSR/DataLoader/VirtualFile.py", line 346, in
image_bytes = [BytesIO(self.read()) for _ in range(frames)]
File "../VSR/DataLoader/VirtualFile.py", line 143, in read
raise EOFError('End of File!')
EOFError: End of File!

@AIRedWood Which branch did you use, master or dev branch?
My test at master is OK.

python run.py --mode=eval --input_dir=/VSR/Results/vespcn/MYDATA --test=vid4 --l_only --enable_psnr --enable_ssim

Is your input_dir right? Since it seems to be an absolute path

As for rgb2ycbcr, the implementation is at VSR/Util/ImageProcess.py:232

@LoSealL  thank you ， I test it  successfully， the psnr is 25.12.

@LoSealL
But I find a new question.
you said in question 10:
In reference paper, the author's optical flow is ranged from [-1, 1], but interpreted as the entire motion (i.e. a car from coord(0, 0) to coord(W, 0)). But this makes the network very hard to converge. So I constrain the motion to absolutely 1 pixel, which means the estimated movement is at most 1 pixel. A tricky but not mentioned trick at SPMC[2].
I see it in the code.
def warp(image, u, v, additive_warp=True, normalized=False):   """warp the image with flow(u, v)   If flow=[u, v], representing motion from img1 to img2   then warp(img2, u, v)->img1~   Args:        image: a 4-D tensor [B, H, W, C], images to warp        u: horizontal motion vectors of optical flow        v: vertical motion vectors of optical flow        additive_warp: a boolean, if False, regard [u, v]          as destination coordinate rather than motion          vectors.        normalized: a boolean, if True, regard [u, v] as        [-1, 1] and scaled to [-W, W], [-H, H] respectively.
Could you tell me more about the significance of using normalized?

@AIRedWood
If normalized is False, then u and v is the absolute pixel value. For example, u(1, 1)=1 means the motion at (1, 1) on u direction (a.k.a x direction) is 1. Here motion means velocity(or \Delta u) if additive_warp=True, or means destination (u_{new}) if additive_warp=False.
If normalized is True, u(1, 1)=1 means the motion at (1, 1) is W, where W is the width of the inputs. And the motion of 1 pixel is 1/W.

@LoSealL
May I ask if I understand this correctly?
If normalized is True, the relative displacement of a pixel is in the interval W* [1,1], that is, [-W, W], and if normalized is False, then the relative displacement of a pixel is [-1,1].
That is to say, normalized enlarges the range of intervals.

Yes, exactly

@LoSealL  thank you~


headline schema improvements

This is pretty much done, but I want to talk about how Bolt is going to approach handling null in the schema. This one is sort of different than the others and I know we are shooting for consistent approaches across the code base.

@joekarasek given that I just merged in https://github.com/bolt-design-system/bolt/pull/522 which included updates to pull in and use the new (super handy) remove_null Twig filter, did you want to do another quick pass at this to add that in here or should I merge and we can follow-up with that after?

This broke all kinds of things with headline styling.
For example:
Homepage demo before

Homepage demo after

Hopefully there's a small and systematic fix?  In any case, it highlights the need for visual regression testing (automated of course, but human-powered until we get there, especially when refactoring core components like headline).

@remydenton @joekarasek  🤦♂
I screwed up here. The original PR and Netlify URL appeared to have checked out but the subsequent one included the visual regression you mentioned @remydenton
On paper, this should be a non breaking minor update to shift the in-template validation over to use our YAML schema. I can't dig in for a couple hours but I'm guessing one or more of the values getting resolved here is different, causing the Headline to use the wrong tag, the wrong sub component... something along those lines.

Thanks @sghoweri.  Good to hear it did check out during the initial review, so we shouldn't be that far off.


[PowerRename] Do not crash with big counter values and bound max padd…

…ing value

Summary of the Pull Request
swprintf_s __fastfails when the buffer is too small, so we're checking the required buffer size ahead of printing to it and falling back to 0 padding in case it cannot fit. Note that we must use swprintf with nullptr buf, because the _s version panicks on it as well.

PR Checklist

[x] Closes: #28247
[ ] Communication: I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected
[ ] Tests: Added/updated and all pass
[ ] Localization: All end user facing strings can be localized
[ ] Dev docs: Added/updated
[ ] New binaries: Added on the required places

[ ] JSON for signing for new binaries
[ ] WXS for installer for new binaries and localization folder
[ ] YML for CI pipeline for new test projects
[ ] YML for signed pipeline

[ ] Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

verified that PowerRename now falls back to zero padding with a value of

${padding=999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999}

What is the max acceptable value again?

@Jay-o-Way Now it's set to be modulos of MAX_PATH, though in practice it'd be constrained by a number length itself, because the whole buffer length is MAX_PATH.

That is.... Absolutely insanely huge 😆🤯 Maybe we can set a more reasonable limit?

/azp run


Added Cssurl param

im not sure about the validation settings in PayInitParameterInterface.php

@jbennecker thank you for your input

https://github.com/payment/saferpay/commit/bdb11d62ead4e914cc29f635f3b3993f7a6fc10d
https://github.com/payment/saferpay/releases/tag/3.1.0


CloseAndReconnect(): Close WS even if connect goroutine is running

@vocoded it looks there is a possible race condition.
Please take a look at https://github.com/ihorserba/recws/pull/9/commits/9f661efec859fa6c08df6e40c8227de214ae18c7


Disabling/uninstalling plugin while highlighting is active does not disable highlighting

This should have been fixed already. Have you updated your client?

This should have been fixed already. Have you updated your client?

Issue was made shortly after installing the plugin, and Runelite is up to date as of this morning at ~7am. Checking now to see if it has been fixed.

Issue was made shortly after installing the plugin, and Runelite is up to date as of this morning at ~7am. Checking now to see if it has been fixed.

Ah, I see the issue. It seems this plugin and Bank Value Heatmap plugin don't play well together.
https://user-images.githubusercontent.com/3915208/104112787-83956c00-52b8-11eb-8c65-d48e8661a2e8.mp4
I'll close the issue.

Ah, I see the issue. It seems this plugin and Bank Value Heatmap plugin don't play well together.
https://user-images.githubusercontent.com/3915208/104112787-83956c00-52b8-11eb-8c65-d48e8661a2e8.mp4
I'll close the issue.

Oh, I see... I hadn’t thought about that. I’ll have that sorted out in the next update. Thanks for letting me know!

Oh, I see... I hadn’t thought about that. I’ll have that sorted out in the next update. Thanks for letting me know!


drawio: 21.3.7 -> 21.4.0

Description of changes
Update drawio to the latest version.
This update includes a security fix (not yet public at the time I'm submitting the PR).

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

What should we do for 23.05?  Usually we'd backport the security patch, but we don't know what it is yet.  Will you be able to keep an eye on the situation and put up a PR for 23.05 when we find out what the security fix is?

Will you be able to keep an eye on the situation and put up a PR for 23.05 when we find out what the security fix is?

Okay no problem, I'll take care of it


chore: Adjust expected long task count for Istanbul

Adjusts the number of long tasks expected in timings.test.js from 2 to 3 following the addition of Istanbul to test agent builds.
Overview
Istanbul adds long tasks to the agent build used with tests, following https://github.com/newrelic/newrelic-browser-agent/pull/567. The long term solution is actually to change the WDIO coverage mechanism so it doesn't include Istanbul except when collecting coverage.
Related Issue(s)
https://issues.newrelic.com/browse/NR-124935
Testing
Automated tests should all pass.

This change was included in another PR merged today.


Fix nav and toc issues

The local preview is ok after modification.

Notes:
Run the following commands in the docs folder to preview locally (this instruction will be added into the README file in another PR):
npm run start
npm run start -- --locale cn

cc @qiupingdai


Update Swagger Route Docs

The GET WordSuggestion, ExampleSuggestion, and GenericWord routes can now take the keyword query.
The Swagger docs should capture this information.

This ticket has been addressed.


TUF Repo error

Hey Gentlemen,
Can someone confirm the tuf repository is up to date. I'm getting an "unknown target file" error when attempting to manually install flynn.
$ sudo ./install-flynn --clean --yes --channel nightly --version v20161111
...

===> 11:00:35.459 running "./flynn-host download --repository https://dl.flynn.io/tuf --tuf-db /etc/flynn/tuf.db --config-dir /etc/flynn --bin-dir /usr/local/bin"
INFO[11-17|11:00:35] initializing TUF client
INFO[11-17|11:00:39] downloading components with version v20161111
INFO[11-17|11:00:39] downloading images
11:00:39.342293 host.go:157: tuf: unknown target file: v20161111/version.json.gz
===> 11:00:39.358 ERROR: failed to run "./flynn-host download --repository https://dl.flynn.io/tuf --tuf-db /etc/flynn/tuf.db --config-dir /etc/flynn --bin-dir /usr/local/bin", exit status 1

You are specifying a version that doesn't exist. What version do you want?

It's worth noting that you can leave off the --version flag to get the latest version from a channel.

The latest stable would be fine.
$  sudo ./install-flynn --clean --yes
...

INFO[11-17|11:16:14] initializing TUF client
INFO[11-17|11:16:18] getting configured release channel
INFO[11-17|11:16:18] determining latest version of stable release channel
INFO[11-17|11:16:18] latest stable version is v20161114.0
INFO[11-17|11:16:18] downloading components with version v20161114.0
INFO[11-17|11:16:18] downloading images
11:16:18.622108 host.go:157: tuf: unknown target file: v20161114.0/version.json.gz
===> 11:16:18.640 ERROR: failed to run "./flynn-host download --repository https://dl.flynn.io/tuf --tuf-db /etc/flynn/tuf.db --config-dir /etc/flynn --bin-dir /usr/local/bin", exit status 1

Hmm, I can't reproduce that issue, it must be a CDN glitch. I'll run an invalidation, please try again in 30 minutes.

Ack. Thanks!

@JMSwag the issue here is probably because you are using an old install script, you should download the latest script (curl -o install-flynn https://dl.flynn.io/install-flynn) and try again.

@lmars That fixed it. Thanks guys.

Hey guys,
Getting this error:
===> 11:43:58.017 running "./flynn-host download --repository https://dl.flynn.io/tuf --tuf-db /etc/flynn/tuf.db --config-dir /etc/flynn --bin-dir /usr/local/bin"
/tmp/install-flynn: line 398: ./flynn-host: cannot execute binary file: Exec format error
===> 11:43:58.027 ERROR: failed to run "./flynn-host download --repository https://dl.flynn.io/tuf --tuf-db /etc/flynn/tuf.db --config-dir /etc/flynn --bin-dir /usr/local/bin", exit status 126
Does anybody have any clue of how to fix this?

What is the output of uname -a?

Just read somewhere that Flynn doesn't work on ARM, after switching to X86 everything is working.


add support for toml

add support for toml??

What's your usecase? As I see there are 'sections' with values and values outside of sections. So we either need to read values in the root or take them from one of sections...

As the use-case is not entirely clear to me and nobody is willing to assist with clarifications I have no other choices except close the issue. If somebody needs this features - please feel free to comment here or open a new issue.


Android Testing failing on Bazel CI

https://buildkite.com/bazel/bazel-at-release-plus-incompatible-flags/builds/13#6dd83578-ede3-4bf4-bd29-fc6d6a6f66e8
Android Testing is failing with Bazel@Release + incompatible flags due to
ERROR: /var/lib/buildkite-agent/.cache/bazel/_bazel_buildkite-agent/34bf6870dfb715fb6ec0e0d81121469e/external/protobuf_archive/BUILD.bazel:605:1: Traceback (most recent call last):
--
  | File "/var/lib/buildkite-agent/.cache/bazel/_bazel_buildkite-agent/34bf6870dfb715fb6ec0e0d81121469e/external/protobuf_archive/BUILD.bazel", line 605
  | internal_gen_well_known_protos_java(srcs = WELL_KNOWN_PROTOS)
  | File "/var/lib/buildkite-agent/.cache/bazel/_bazel_buildkite-agent/34bf6870dfb715fb6ec0e0d81121469e/external/protobuf_archive/protobuf.bzl", line 266, in internal_gen_well_known_protos_java
  | Label(("%s//protobuf_java" % REPOSITOR...))
  | File "/var/lib/buildkite-agent/.cache/bazel/_bazel_buildkite-agent/34bf6870dfb715fb6ec0e0d81121469e/external/protobuf_archive/protobuf.bzl", line 266, in Label
  | REPOSITORY_NAME
  | The value 'REPOSITORY_NAME' has been removed in favor of 'repository_name()', please use the latter (https://docs.bazel.build/versions/master/skylark/lib/native.html#repository_name). You can temporarily allow the old name by using --incompatible_package_name_is_a_function=false

However, it is passing with Bazel@HEAD, where --incompatible_package_name_is_a_function is already flipped to true.
I don't understand why this is happening, is android_test_support embedded in Bazel binary and depends on protobuf? @jin

Ah, I see we have --incompatible_package_name_is_a_function=false in the config file
This flag is removed recently at https://github.com/bazelbuild/bazel/commit/2b3ad18eec4e6b968d840777249c809e478b2e13, so please remove them from config file.

You can now upgrade protobuf to <IP_ADDRESS>
https://github.com/protocolbuffers/protobuf/releases/tag/v<IP_ADDRESS>

Yes, we had the same problem where protobuf was updated and we had to test on the latest Bazel where the incompatible change with REPOSITORY_NAME was enabled. That is why I added the flag workaround.
Will look into this.

@meteorcloudy Not quite -- <IP_ADDRESS> is just a tag, but we depend on the individual language releases. The latest release is still 3.6.1 https://github.com/protocolbuffers/protobuf/releases

We can close this now :smile:


Add search feature

Using google maps autocomplete API,
create a search bar that will let users type in placenames and when they select a place, recentre the map

https://www.figma.com/file/HfT3GwZlpR6q9RScMNdF5D/mymizu-Web-App?node-id=0%3A1

Please check notion link for more details:
https://mymizu.notion.site/Searching-on-map-81e3f2506abd40698c4e9d308da492ad


Debugging/Logging using Config value for RyuJit

We should use Config value JIT/EE interface to set RyuJit debugging/logging setting instead of setting via uitilcode.

@pgavlin Was this tracking your JitHost work? Sounds like we can close this?
There's #697 tracking a mechanism for the CoreRT compiler to actually pass these values in.

Yeah, this work is complete w.r.t. the JIT and JIT interface.


iDaaS Connect SAP

Is your feature request related to a problem? Please describe.
Create a submodule iDaaS Connect SAP to enable the processing of SAP data. This initial submodule should just have the core iDaaS Connect base framework and be able to build.

Implemented and passed a general build


Reorganize directory structure

index.html needs to be in root for easy integration with Github Pages
Consider making gh-pages the main branch: "If you created a new branch for GitHub Pages, go to the repository settings. In the Branches section, change the default branch to the newly created gh-pages branch."
Probably link with #15

Link with #3


Unicode values outside Basic Multilingual Plane cannot be processed correctly.

For example:
font.stringToGlyphs('\u{2f894}') will return an array with two “.nodef” in it.

If font.glyphs.glyphs[...] is being used to access a certain glyph directly, then it will return an object with an undefined unicode value.

It seems this is the limitation of cmap format, since format 4 only supports 16-bit unicode value.

Would it help if we parsed a different cmap format?

In that case, cmap format 12 is probably a good choice then, it’s widely adopted and the superset of format 4.

@lixiangliu cmap 12 read support was just added with PR #207 😉

Closing this issue because of the cmap 12 support. @lixiangliu  let me know if there's something else that blocks you from working wit these fonts.

The same issue still exists with values outside the BMP. Looks like it may be because of the limitations of charCodeAt() https://mathiasbynens.be/notes/javascript-unicode#code-point-from-string

@amart1n You're right charCodeAt() "will always return a value that is less than 65536." (ref)
codePointAt() is the new method to use but because of the compatibility we would need to add Mathias's polyfill: https://github.com/mathiasbynens/String.prototype.codePointAt and use it instead of charCodeAt() to have a full Unicode support.

Closed through #338


[BUSINESS PROCESS]: Create purchase requisitions

Contact details
<EMAIL_ADDRESS>Organization type
Parnter / ISV / Independant consultant
End-to-end business process
Procure to pay
Which business process area is this article related to?
Procure materials and services
Enter the name of the business process you are starting work on
Create purchase requisitions
Enter any additional comments or information you want us to know.
Comments go here
Specify the date you expect the article to be completed and ready for review.
02/24/2024
Code of Conduct

[X] I agree to follow this project's Code of Conduct

Amir - Thank you for your interest in contributing to the procure to pay business process.  Looking forward to the document in line with our discussion.


relax the pypi dependency requirements

First of all, thanks for a great package, it's really cool!
I'm trying to use textract as part of a larger project, however, when I install it from PyPI it imposes rather strict requirements on package versions (and reinstalls them) - are those exact pinning necessary to make it work or is this a shortcut from the past to achieve a stable behavior?

That's a great question @krzysztof. I started pinning versions in 1.5.0 to address issues like #107 that originated from chardet version issues. I've been using @pyup-bot to help manage it, but I can appreciate the difficulty in textract requiring specific versions that might conflict with other package dependencies. The main goal is to make sure people don't install textract and then run into problems with the functionality "not working" when it's really an issue with a dependency.
I'd be open to relaxing them to being >= particular versions or even excluding particular versions. I'm not sure how that works with @pyup-bot but I'm sure we can work something out. What are you thinking here? Do you want to throw a PR together?

@deanmalmgren I guess the functionality stability is best achieved with unit tests, but since this is quite an aggregation of many different extractors, I am not sure how cumbersome it would be to maintain it.

I'd be open to relaxing them to being >= particular versions or even excluding particular versions. I'm not sure how that works with @pyup-bot but I'm sure we can work something out. What are you thinking here? Do you want to throw a PR together?

I'll try to find time this week to integrate it with our project and see what constraints I can find.

Most of the advice I've read, suggest pinning the dependencies in order to make an install independent of the currently installed packages. Are there any dependencies in particular which are too strict for your purpose?
@MalikRumi you can install textraxt 1.6.2 with pip install git+https://github.com/deanmalmgren/textract.git. This version makes pocketsphinx an optional dependency.


Replace querySelector with getElementBy*

querySelector is slow. It's used in quite a lot of places in the code. getElementByClassname and getElementById is a lot faster. Note the API isn't 1:1 but close enough.
e.g. benchmark
p.s. just trying to make Apex work with larger data sets. It's a good charting solution, but maybe 5-10x slower than a lot of similar options. Happy to help optimize all parts of it in any way.

Sure, replaced where applicable.


feat(entrypoint-0.7): base - all changes in regards to the Entrypoint v6 & v7 support

Pull Request Checklist

[ ] Did you add new tests and confirm existing tests pass? (yarn test)
[ ] Did you update relevant docs? (docs are found in the site folder, and guidelines for updating/adding docs can be found in the contribution guide)
[ ] Do your commits follow the Conventional Commits standard?
[ ] Does your PR title also follow the Conventional Commits standard?
[ ] If you have a breaking change, is it correctly reflected in your commit message? (e.g. feat!: breaking change)
[ ] Did you run lint (yarn lint:check) and fix any issues? (yarn lint:write)
[ ] Did you follow the contribution guidelines?

PR-Codex overview
This PR introduces versioning changes and updates across various files in the codebase.
Detailed summary

Updated entry point ABI versions to v6
Modified schema validation for strict hex values
Added API key constant for staging environment
Adjusted function return types for better type safety
Improved error handling and versioning consistency

The following files were skipped due to too many changes: packages/core/src/utils/testUtils.ts, packages/core/src/errors/account.ts, packages/accounts/src/msca/plugin-manager/decorator.ts, packages/core/src/account/schema.ts, packages/ethers/src/types.ts, packages/alchemy/src/middleware/userOperationSimulator.ts, packages/accounts/src/light-account/decorator.ts, packages/plugingen/src/commands/generate/phases/plugin-actions/management-actions.ts, packages/core/src/middleware/types.ts, packages/ethers/src/provider-adapter.ts, packages/core/src/actions/smartAccount/sendTransactions.ts, packages/core/src/middleware/defaults/overridePaymasterData.ts, packages/accounts/src/msca/plugin-manager/uninstallPlugin.ts, packages/accounts/src/msca/plugins/multisig/actions/proposeUserOperation.ts, packages/accounts/src/msca/plugins/multisig/types.ts, packages/accounts/src/msca/plugin-manager/installPlugin.ts, packages/core/src/actions/smartAccount/sendUserOperation.ts, packages/plugingen/src/commands/generate/phases/plugin-actions/read-actions.ts, packages/accounts/plugingen/phases/plugin-actions/management-actions.ts, packages/accounts/src/light-account/actions/transferOwnership.ts, packages/core/src/actions/smartAccount/checkGasSponsorshipEligibility.ts, packages/accounts/src/nani-account/account.ts, packages/core/src/actions/smartAccount/signUserOperation.ts, packages/accounts/src/msca/plugins/multi-owner/plugin.ts, packages/accounts/src/msca/plugins/multisig/plugin.ts, packages/core/src/index.ts, packages/accounts/src/msca/plugins/multisig/utils/splitAggregatedSignature.ts, packages/accounts/src/msca/account/multisigAccount.ts, packages/core/src/actions/smartAccount/sendTransaction.ts, packages/accounts/src/msca/utils.ts, packages/core/src/actions/smartAccount/buildUserOperationFromTxs.ts, packages/core/src/__tests__/utils.test.ts, packages/core/src/account/base.ts, packages/core/src/actions/smartAccount/internal/sendUserOperation.ts, packages/ethers/src/account-signer.ts, packages/core/src/actions/smartAccount/buildUserOperationFromTx.ts, packages/core/src/utils/types.ts, packages/core/src/actions/smartAccount/internal/runMiddlewareStack.ts, packages/core/src/actions/smartAccount/buildUserOperation.ts, packages/core/src/utils/index.ts, packages/accounts/src/msca/account/multiOwnerAccount.ts, packages/core/src/client/decorators/bundlerClient.ts, packages/core/src/utils/defaults.ts, packages/accounts/plugingen/phases/plugin-actions/index.ts, packages/accounts/src/msca/plugins/session-key/plugin.ts, packages/core/src/client/decorators/smartAccountClient.ts, packages/accounts/src/light-account/account.ts, packages/core/src/utils/userop.ts, packages/plugingen/src/commands/generate/phases/plugin-actions/index.ts, packages/core/src/entrypoint/0.6.ts, packages/accounts/src/msca/plugins/session-key/extension.ts, packages/core/src/actions/smartAccount/dropAndReplaceUserOperation.ts, packages/alchemy/src/client/types.ts, packages/core/src/entrypoint/types.ts, packages/core/src/actions/smartAccount/types.ts, packages/core/src/entrypoint/0.7.ts, packages/core/src/entrypoint/index.ts, packages/core/e2e-tests/simple-account-staging.e2e.test.ts, packages/core/src/account/simple.ts, packages/core/src/abis/SimpleAccountAbi_v7.ts, packages/core/src/account/smartContractAccount.ts, packages/alchemy/src/middleware/gasManager.ts, packages/core/src/types.ts, packages/core/src/abis/EntryPointAbi_v7.ts

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

To see the specific tasks where the Asana app for GitHub is being used, see below:

https://app.asana.com/0/0/1206854921431396
https://app.asana.com/0/0/1206826573496436
https://app.asana.com/0/0/1206826573496426
https://app.asana.com/0/0/1206924039831384

All the comments are accommodated, and this PR should have all necessary implementations for both 0.6 and 0.7 entry point support with strong typing of user operations, etc., with default entry point support for version (0.6) and address.
Next step:
Thanks for the first-round review; I would appreciate reviewing the overall design. Please note that there are follow-up PRs for making typing less strict in some places with fallbacks.

Unit test PR is included in the follow-up PR.
With the default 0.6 entry point, all the existing unit/e2e tests should pass for migration safety.
Documentation update for different entry point support

cc: @moldy530 @dancoombs @dphilipson @rthomare

@moldy530 per your comment,

https://github.com/alchemyplatform/aa-sdk/pull/514#discussion_r1558157699

SupportedEntryPoint contains a map of chained => EP address. But this is different from EntryPointDef.
getEntryPoint() first fetch the supported entry point for the version, then with the input chain param, gets the EP address from the above EP address map unless the user inputs addressOverride.
So the user can do getEntryPoint(chain, { addressOverride: '0xasdfasdfasdf' }) for whatever chain they use as long as the bundler/infra supports.

@moldy530 I refactored the light account v2 pr, moved all entrypoint v7 base branch related fixes/changes on this PR on the HEAD commit. tested with unit test/e2e test, etc. per our sync today, for v6 backward compatibility, nothing breaking.
Ready for final pass, and merge to main branch.
cc: @dphilipson @dancoombs @dphilipson @rthomare

Lint and Test passes, but PR title format is not passing even after changing the PR title to fix the fail issue. Should be okay. @moldy530

@moldy530

https://github.com/alchemyplatform/aa-sdk/pull/514#discussion_r1562739793

sorry this is removed from the light account v2 pr

@moldy530 accommodated all the last stretch items.


Adopt the RISC-V documentation format (#73)

Signed-off-by: Jeff Scheel<EMAIL_ADDRESS>

Merged. Thanks.
Regards
Kumar
From: Jeff Scheel @.>
Sent: Friday, January 21, 2022 7:18 AM
To: riscv/riscv-platform-specs @.>
Cc: Subscribed @.***>
Subject: [riscv/riscv-platform-specs] Adopt the RISC-V documentation
format (#73) (PR #74)
Signed-off-by: Jeff Scheel @.***
You can view, comment on, or merge this pull request online at:
https://github.com/riscv/riscv-platform-specs/pull/74
Commit Summary

9750d7c
https://github.com/riscv/riscv-platform-specs/pull/74/commits/9750d7c74f3d89f2c5bb16d6b56393ed852f8bbd
Adopt the RISC-V documentation format (#73)

*File Changes *
(7 files https://github.com/riscv/riscv-platform-specs/pull/74/files)

A .gitmodules
https://github.com/riscv/riscv-platform-specs/pull/74/files#diff-fe7afb5c9c916e521401d3fcfb4277d5071798c3baf83baf11d6071742823584
(3)
M Makefile
https://github.com/riscv/riscv-platform-specs/pull/74/files#diff-76ed074a9305c04054cdebb9e9aad2d818052b07091de1f20cad0bbac34ffb52
(13)
M README.md
https://github.com/riscv/riscv-platform-specs/pull/74/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5
(34)
A docs-resources
https://github.com/riscv/riscv-platform-specs/pull/74/files#diff-c6b8c2ab88c6438631b7039b046c96a11bb872122f574c52853db865fbf56dc0
(1)
M riscv-platform-spec.adoc
https://github.com/riscv/riscv-platform-specs/pull/74/files#diff-e2e67320afc3dbcf884d10778f562bfa141048bbccbf7be067df8813a55a66fd
(35)
M riscv-platform-spec.pdf
https://github.com/riscv/riscv-platform-specs/pull/74/files#diff-99ecfcb7e450940e80bfe4a0cfd18e303023e4688c9b90d3024ec8e65e909f27
(0)
D riscv-platform-spec.yml
https://github.com/riscv/riscv-platform-specs/pull/74/files#diff-df353c870044c9886487aa2973440e6bb89f0a56b6c8e0d2f37d5fa1bbbf3586
(8)

Patch Links:

https://github.com/riscv/riscv-platform-specs/pull/74.patch
https://github.com/riscv/riscv-platform-specs/pull/74.diff

—
Reply to this email directly, view it on GitHub
https://github.com/riscv/riscv-platform-specs/pull/74, or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABLRGVVTZD6PNWDJJJ4BQFDUXF2JZANCNFSM5MPY7VEA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>


Consider providing filtering of editable percentile of candidates in evolution chart

E.g. drop down:

All
Top 50%
Top 10%
Custom Value


[SPARK-29462] The data type of "array()" should be array

What changes were proposed in this pull request?
During creation of array, if CreateArray does not gets any children to set data type for array, it will create an array of null type .

Why are the changes needed?
When empty array is created, it should be declared as array.

Does this PR introduce any user-facing change?
No

How was this patch tested?
Tested manually

Can one of the admins verify this patch?

Can one of the admins verify this patch?

cc @srowen @MaxGekk @dongjoon-hyun

To clarify, why do you think it should be null? not saying it shouldn't be, but is this in comparison to a standard or other DB?

Ah... I see. That was done intentionally to match hive behavior. I will close this PR.
Thanks @srowen @maropu
We also need to update SPARK-29462

Can one of the admins verify this patch?

Can one of the admins verify this patch?

@amanomer Could you add some test cases?

Test build #112946 has started for PR 26324 at commit 39ed807.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/17868/
Test PASSed.

Test build #112946 has finished for PR 26324 at commit 39ed807.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/112946/
Test FAILed.

Test which ensures that empty array and map should be of string type is failing.

@maropu

Can you remove the test? Anyway, I'm neutral on this change; I'm a bit worried that hive users get confused with this behaviour change. cc: @dongjoon-hyun @wangyum

Test build #112994 has started for PR 26324 at commit 6fc258b.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/17917/
Test PASSed.

@gengliangwang @maropu kindly review

Failure is not related. Retest this please.

Test build #112994 has finished for PR 26324 at commit 6fc258b.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/112994/
Test FAILed.

retest this please.

Test build #113042 has started for PR 26324 at commit 6fc258b.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/17963/
Test PASSed.

Test build #113042 has finished for PR 26324 at commit 6fc258b.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/113042/
Test PASSed.

@gengliangwang Can you help in finding out why is this failing?
Thanks

@maropu @srowen Just double confirm, are you ok with the proposal?

I agree that compatibility is a minor issue here. But it also sounds like this change allows things to work that did not before. I'm trying to think of cases where something works with the current behavior and not with the new... is there one?

yea, that's ok to change it. Because of the behaviour change as @srowen said, we might need to update the migration guide, too.

I agree that compatibility is a minor issue here. But it also sounds like this change allows things to work that did not before. I'm trying to think of cases where something works with the current behavior and not with the new... is there one?

Previously array() can't be stored into array<array<?>> type since string value can't store into array type.
After the change in this PR,  array() can be stored as array<array<?>> type, which also seems reasonable..

yea, that's ok to change it. Because of the behaviour change as @srowen said, we might need to update the migration guide, too.

+1, @amanomer could you add migration guide?

Yes, I will add.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/18082/
Test PASSed.

Test build #113169 has started for PR 26324 at commit acc2864.

I'm asking the reverse question - is there anything that works before this change but not after? I understand it makes something else work.

Test build #113169 has finished for PR 26324 at commit acc2864.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/113169/
Test PASSed.

I'm asking the reverse question - is there anything that works before this change but not after? I understand it makes something else work.

oh I see.. I can't think of any.

Test build #113188 has started for PR 26324 at commit bb5e68a.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/18101/
Test PASSed.

Test build #113188 has finished for PR 26324 at commit bb5e68a.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/113188/
Test PASSed.

cc @srowen @maropu

I think its better for more other reviewers (e.g., @dongjoon-hyun, @wangyum, ...) who's familiar with hive to check this before merging (I'm not sure about why hive regards array() as array<string>

It's a tough call but ..

Since Spark can insert null type to other types, the problem is resolved.

This makes sense to me. I personally follow Hive whenever I am not sure but if we have another good coherent reason like ANSI standard, let's try to stick to that.

@maropu @srowen @dongjoon-hyun kindly review this PR?

Merged to master.

Thanks all.

@HyukjinKwon Shouldn't empty map also be Map<NullType,NullType> ?

Sorry, actually I think I have to revert this back for the reasons below:

per https://github.com/apache/spark/pull/26324#issuecomment-547999191 we should think about what to do with map type together.

Seems like null type coercion depends and some DBMSes don't event have null types. Hive has it but Hive case was array<string>.

In case of PostgreSQL seems it coerces to TEXT type.

Using null as default type might cause a corner case as below. Should we add void as NullType? needs some investigations.
CREATE TABLE weird_null USING JSON AS SELECT NULL AS null_col;
SHOW CREATE TABLE weird_null

CREATE TABLE `weird_null` (`null_col` NULL)
USING JSON

CREATE TABLE `weird_null_1` (`null_col` NULL)
USING JSON

Error in SQL statement: ParseException:
DataType null is not supported.(line 1, pos 40)

== SQL ==
CREATE TABLE `weird_null_1` (`null_col` NULL)
-------------------------

This PR basically means a revert of https://github.com/apache/spark/pull/18516#issuecomment-312765246 - let's don't make it complicated for now.

@HyukjinKwon @maropu review this PR https://github.com/apache/spark/pull/26317 also.

I don't agree we should revert it. The Hive behavior is really confusing and we shouldn't inherit it anymore. concat(array(), array(1)) returns array of string, which doesn't make sense. Presto returns array of int.
I think map() can be inferred as map<void, void>. The map key can be null type but can't be null, so this is fine as long as map<void, void> is empty.
For CTAS, I don't think it's related. If we can create table with null-type column using CTAS, why not allow array<void> as well?

@Ngone51 can you help revert the revert?

Okay, I am good to bring it back. Let me open a PR to revert of a revert.

@cloud-fan, we didn't add void type yet BTW.

null type is the same as void type, or unknown type. We can change the string representation of NullType if needed.

Yeah, so my point was that I wonder if it's right to promote the type we're not supporting correctly.


There is no provision to run ddpg.

I typed the policy as 'lol' and it still gives the same result. The readme says that we can run the experiments for ddpg as well as maddpg which is definitely not working.

I also find the same problem

I typed the policy as 'lol' and it still gives the same result. The readme says that we can run the experiments for ddpg as well as maddpg which is definitely not working.

Hi,do you know how we can run the experiments for ddpg now?


WIP: Play with dotnet-affected

Closing PR, play-field has moved to https://github.com/Energinet-DataHub/opengeh-process-manager-outlaws-poc


Feature: Pattern Matching Lets

Now you can do
let (a, b) = ...
 in a + b

Fun! No more matches with a single branch! Yay!

You wrote that!


get_mut_edges() is needlessly called 3 times

In calculating the likelihoods, and independently in the forwards and backwards algorithms. We should call it once and store it. I will do this in my updated code.

Another great catch!

On Dec 6, 2019, at 10:39 PM, Yan Wong<EMAIL_ADDRESS>wrote:
In calculating the likelihoods, and independently in the forwards and backwards algorithms. We should call it once and store it. I will do this in my updated code.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub https://github.com/awohns/tsdate/issues/75?email_source=notifications&email_token=ACRLT2B2PN2NOYMRP7YTWVDQXLIBPA5CNFSM4JXCYXE2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4H6YUJ7A, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACRLT2FWUUWQVJKOZJQNQETQXLIBPANCNFSM4JXCYXEQ.

Fixed with https://github.com/awohns/tsdate/pull/77


Fullscreen is actually only halfscreen in Chrome

Hi,
I just tested the fullscreen plugin. It works perfectly in FireFox, but using Google Chrome results with this:

The demo works fine for me on Chrome 47.0.2526.106. Can you please provide a self-contained example that demonstrates the problem?

@jfirebaugh Well the demo works for me as well. I just saw that you updated the CDN (I was using the CDN), this fixed the pseudo fullscreen for me (this is exactly what I needed).
However, the fullscreen still does not work. I tried to reproduce the error, in a self-contained example (like the demo, just with the cdn), worked like the demo. So this is probably an interference with some other lib I use. I am happy with the pseudo fullscreen :+1:.


Tango Ros Streamer For phab 2 pro

hi,i want to show and edit my 3D simulation from Rtab-map on tango device to my desktop.While using my tango device everything is OK. i can create 3D simulation and can see datas and coordinates but i want to connect my device and my computer .i install tango ros streamer and in my devices, i fill the correct master url then ros light turn on green , but tango light is still yellow. i can start rviz and rtabmap in my desktop seperately however how can i connect tango device and my desktop
my tango device is lenovo phab 2 pro , and im using ubuntu 16.04

Hi @gizemarik,
After setting the ROS Master URI you should be able to receive Tango data on your desktop (enable local master should not be checked). Your device should be in the same network as your desktop.
Here are some tutorials that could help:
http://wiki.ros.org/tango_ros_streamer/Visualisation
http://wiki.ros.org/rtabmap_ros/Tutorials/Tango ROS Streamer
http://wiki.ros.org/ROS/NetworkSetup

@psoetens @smits  thanks all

I also cannot connect to the master URI of ros from the smartphone "Tango ROS Streamer" app.
roscore is launched on the laptop and I can successfully ping the laptop's local net IP from the phone terminal.


Misconfigured config leads to using all the default settings

In Biome 1.5.1, useConsistentArrayType was moved back to the nursery group, which made the Biome cli complain about it, and is how I discovered this issue.
While the cli doesn't do anything beside throwing an error, it seems like the vscode extension instead reverts to use all the defaults for the formatter.
So formatting on save will change all space indentation to tabs for example.
Ideally a misconfiguration in the linter should not affect the formatter's configuration. Or the linter's config itself for that matter.

Checked again today, if I make a typo in the config, and reload VSCode, Biome will not be available as a formatter:

It's a step in the right direction, now Biome won't format files incorrectly, but I still wish it'd be able to format if the config error is not related to the formatting settings.

Closing. The CLI now errors. In v1.8 the LSP will not do anything.


Remove unnecessary horizontal divider

Description of the change: Removed unnecessary horizontal divider
Reason for the change: Consistency between different documentations
Link to original source: none

Closes #

Hello @cozyplanes,Thanks again for the PR! It's HACKTOBERFEST! We want to show our appreciation by sending                                              you some special Hacktoberfest swag. If you have not already, could you please fill out                                              this form so we can send it to you? Thanks!                                             Team SendGrid DX


Support latest kubeedge demo in killercoda-scenarios

Now KubeEdge has many examples in the example repo, but users need to install the kubeedge clusters by themselves.
In order to help developers experience these cloud native edge-computing demos better, we will to integrate these demo experiences in killercoda-scenarios.

Hi @fisherxu,
i am interested in this issue. Could you provide some resources to learn and contribute in this issue?

I am Vishal Raj, a final year CSE student. The KubeEdge project to support the latest version installation demo in killercoda is captivating. I'm eager to contribute to this project and help create a hands-on experience of KubeEdge deployment with the latest version. Integrating cloud-native edge-computing demos will enable developers to experience KubeEdge's capabilities online. Let's collaborate to make KubeEdge more accessible and user-friendly for developers!

Hi, @fisherxu I am chaomei yan from USTC, I am interested in this project and I have send an email to you a few days ago~

Hi @fisherxu ,
I am Shashank Mittal, an undergrad at IIT(BHU). i am interested in this issue. Could you provide some resources to learn and contribute in this issue?


Fix excessive sourcemap traceback import in bundle mode

Environment

luaBundle{Entry} enabled
sourceMapTraceback enabled

Before:
__TS__SourceMapTraceBack being required in every module even when not being used.
____modules = {
["lualib_bundle"] = function(...)
local function __TS__SourceMapTraceBack(fileName, sourceMap)
    ...
end
 end,
["mod1"] = function(...)
local ____lualib = require("lualib_bundle")
local __TS__SourceMapTraceBack = ____lualib.__TS__SourceMapTraceBack
 end,
["mod2"] = function(...)
local ____lualib = require("lualib_bundle")
local __TS__SourceMapTraceBack = ____lualib.__TS__SourceMapTraceBack
 end,
}

local __TS__SourceMapTraceBack = require("lualib_bundle").__TS__SourceMapTraceBack
__TS__SourceMapTraceBack(debug.getinfo(1).short_src, {...})

After:
____modules = {
["lualib_bundle"] = function(...)
local function __TS__SourceMapTraceBack(fileName, sourceMap)
    ...
end
 end,
["mod1"] = function(...)
 end,
["mod2"] = function(...)
 end,
}

local __TS__SourceMapTraceBack = require("lualib_bundle").__TS__SourceMapTraceBack
__TS__SourceMapTraceBack(debug.getinfo(1).short_src, {...})

What is the benefit of this change?

There is no real functional change, it just reduces the number of useless traceback imports when transpiling in bundle mode.
This change just makes it so we include __TS__SourceMapTraceBack feature at a global level and not at the module level which causes those imports (although not used) to be present in all modules

I don't like bundling logic leaking into individual file transformation and the bundled files no longer being valid by themself. Without any real benefit to doing this, I don't really feel like merging this.


Closes svg/svgo#759. Upper case hex color now converts to shortname.

Thanks!

SVGO v1.0.0 with this change has been released now.