Animation after render

Hi @hankchizljaw , How can I apply animation after committing an action?

I got it. To deal with DOM after it renders, just use the keyframes animation. Thanks


Bug: Error thrown first time the clowncar exit is used per world load

only FTC active:
Only happens once and doesn't seem to prevent anything from happening.

Upstream issue: see foundryvtt/foundryvtt#9935 and foundryvtt/foundryvtt#9940 for similar past ones.


[ServiceBus] Graceful noops for methods taking empty lists.

Make send_messages, schedule_messages, cancel_scheduled_messages, and receive_deferred_messages gracefully no-op when provided an empty list or empty batch (where appropriate).  Adds tests and changelog notes for these scenarios.  Closes #15211

/azp run python - servicebus - tests

/azp run python - servicebus - tests

/azp run python - servicebus - tests

/azp run python - servicebus - tests


Highlight invalid params in doc comments

Working on Angular, the team has mostly been very, very on-it with updating doc comments in great detail. However, it's been said by WebStorm users on our team that they catch a lot of invalid params docs, and or missing params docs because WebStorm has a feature that hightlights those issues, and VS Code users haven't had that feature so we miss things sometimes. (Sorry to make a comparison, this is just where the idea came up)
Example
/**
 * This method takes arguments and does basically nothing with them. :)
 * @param b The string that we do nothing with
 * @param c A dearly departed argument that should no longer be documented.
 */
function foo(a: number, b: string) {
}

Ideally in the above example, VS Code would catch two problems:

a is missing a param entry in the doc comment
c is no longer an argument and should be highlighted for removal.

Duplicate of #11378 I believe


Complete RechargeableComponent and its test

Code coverage: https://codecov.io/gh/AlmasB/FXGL/src/dev/fxgl/src/main/kotlin/com/almasb/fxgl/dsl/components/RechargeableComponents.kt
File in fxgl module: RechargeableDoubleComponentTest

[ ] Update the component based on the discussion (points 1 and 2) in #840


Help wanted: Improving performance when repeatedly creating a one-entry bibliography

In JabRef, we use
CSL.makeAdhocBibliography(style, outputFormat.getFormat(), cslItemData);

to create the HTML-preview for the currently selected item in the BibTeX database. Every time the user scrolls through the main list, we update the preview and call this code again. I have carefully profiled what happens, but everything points to this call being the source of our memory and performance problems. I know that makeAdhocBibliography has a clear warning sign in its comments that it will be expensive.
Can you recommend the best possible way to handle our situation so that it is as resource-friendly as possible? We have the following constants and variables:

the style is set in the preferences and stays constant most of the time
the output format is fixed as well
we provide the cslItemData every time the preview needs to be updated

I'm asking this question because at the moment I see no sensible way with one of the built-in ItemDataProviders to achieve this. Therefore, one of my first questions would be: Is it OK to make an ItemDataProvider that changes its content? I would then initialize a CSL instance with an empty provider and change its underlying ItemData list every time we need to render an item.

Your observations are correct. makeAdhocBibliography is good if you only need to create a bibliography once or every now and then, but if you need to create multiple bibliographies you should try to reuse the CSL object. The reason for this is that the CSL object holds a ScriptRunner which is very expensive to create. AFAIR the library contains code that automatically tries to reuse ScriptRunner instances by keeping them in a ThreadLocal but I guess this depends on your setup and on the actual JavaScript engine used.
Regarding your problem with the built-in ItemDataProvider: Just implement your own one that provides citation items dynamically (without a static list like the ListItemDataProvider does). This should work. I think you only need to implement two methods: retrieveItem which is only called at the moment the bibliography is created, and getIds which should return an array of all available citation IDs. I don't remember how often getIds is called and whether you could return a dynamic result here, but I guess you should just try it out. An alternative would be to only re-create the CSL object if the user's list of citation items has changed.
In addition, @koppor is right when he says you should try V8. By default citeproc-java uses Nashorn and this engine is far from being fast, especially at the beginning when it's not warm yet and the JIT compiler has not kicked in (another reason why you should try to keep the CSL instance in memory. The more often you execute the same JavaScript code the better the results of the JIT compiler).
I hope this helps. Let me know if you need more assistance. I can try to create some sample code if you like. Just give me more details, so I can better reproduce your scenario.

Thank you, Michel, for this long answer. I wrote an adapter-class for your CSL engine that holds an instance and synchronizes access to it. Using ThreadLocal was difficult since we run this as SwingWorker and cannot really control which thread it gets assigned to.
I tried it locally and even with fast scrolling through the entries, where I'm sure that several threads try to create a preview, works like a charm. It is soooo much faster.
Thanks again for your time.

Cool! Thanks for the feedback!


Missing Resource Exception

I get a java.util.MissingResourceException when trying to run this
String NewString = naturalDay(date);
Is there something I am missing or something I need to do before calling naturalDay?

Seems that your locale is not supported. I will open an issue to add meaningful exception for this error case.
If you want you can support your language just adding a file named Humanize_{your_locale}.properties into a folder named i18n accesible from the classpath.
The content must be the same as in: https://github.com/mfornos/humanize/blob/master/humanize-slim/src/main/resources/i18n/Humanize_en.properties (but for your locale).
Thank you


Dhivehi Phonetic keyboard for ChromeOS

I am attaching the Dhivehi Phonetic keyboard v1. Uses Hebrew as the primary language (both Dhivehi and Hebrew is RTL)
Hopefully this make it into this repository :)
I have submitted my CLA as well.
manifest.txt
background.txt

Here's the layout (using the QWERTY keyboard)
dhivehi/thaana layout (ތާނަ)
][ޕއޮއިއުޔތރއެއއް
'؛ލކޖހގފދސއަ
/.،މނބވޗ×ޒ
shift
|}{÷_ _ _ޠޓޜޭޢޤ÷
":ޅޚޛޙޣﷲޑށއާ
؟><ޟޏޞޥޝޘޡ

][ޕއޮއިއުއޔތރއެއއް
'؛ލކޖހގފދސއަ
/.،މނބވޗ×ޒ
shifted
|}{÷ޯީޫޠޓޜއޭޢޤ
؟><ޟޏޞޥޝޘޡ

@RiyazMansoor I was about to suggest that you create your own repository for this keyboard layout and then I found that you already have a Chrome extension for it. Bravo!

@RiyazMansoor I was about to suggest that you create your own repository for this keyboard layout and then I found that you already have a Chrome extension for it. Bravo!


Allow overriding autocomplete options

Hi @raykeating, thanks for this plugin. Here's a PR to allow overriding arbitrary options. In my case, I wanted to save results in a different language for all users.
I'm sure there's a lot more complicated things that can be done with languages (searching results in one language but saving them in another, dynamically selecting languages based on multiple factors, etc) but this should be a good starting point that can work as an escape hatch if more complex behavior is added later on.
Open to suggestions if you can come up with a better name than autocompletionRequestOptions - I chose that since it diretly mentions Google's AutocompletionRequest type.
Here's an example query with new settings:
// plugins.ts
export default ({env}) => ({
    'location-field': {
        enabled: true,
        resolve: './strapi-location-field-plugin',
        config: {
            fields: ['geometry', 'address_component'],
            googleMapsApiKey: env('GOOGLE_MAPS_API_KEY'),
            autocompletionRequestOptions: {
                language: 'es-419',
                locationBias: 'IP_BIAS',
                region: 'AR',
            }
        },
    },
});

Thanks! Please publish a new release on NPM when you can :)

Hey, just published to NPM


Add eth proxy

Codecov Report

Merging #158 (f4f8f9c) into develop (63d49d1) will increase coverage by 40.32%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           develop     #158       +/-   ##
============================================
+ Coverage    49.20%   89.52%   +40.32%
============================================
  Files           13       33       +20
  Lines          313     1079      +766
  Branches        48      150      +102
============================================
+ Hits           154      966      +812
+ Misses         159      113       -46

Flag
Coverage Δ

contracts
89.52% <ø> (?)

data-transport-layer
?

message-relayer
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...kages/data-transport-layer/src/utils/validation.ts

packages/data-transport-layer/src/utils/common.ts

...ices/l1-ingestion/handlers/state-batch-appended.ts

...ckages/data-transport-layer/src/utils/constants.ts

...ices/l1-ingestion/handlers/transaction-enqueued.ts

...ckages/data-transport-layer/src/utils/contracts.ts

.../l1-ingestion/handlers/sequencer-batch-appended.ts

packages/message-relayer/src/relay-tx.ts

...layer/src/services/l1-ingestion/handlers/errors.ts

.../src/services/l2-ingestion/handlers/transaction.ts

... and 36 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63d49d1...f4f8f9c. Read the comment docs.


oci: reconsider to remove the restriction of image tag must match the chart version.

please reconsider to remove the restriction of image tag must match the chart version:

To successfully pull dependencies, the image name in the registry must match the chart name and the tag must match the chart version. The repository entry in Chart.yaml is specified as the repository name on the registry without the image name.

from: https://helm.sh/docs/topics/registries/
why?
flows on cicd with artifact promotion from dev to integration to staging to production are very useful and has been used as a possible and working cicd flow.
This flow is heavily in use with docker images.
so why to limit the helm oci chart image with this restriction too?
benefits:

add tag like dev and stg to the same oci chart image (artifact promotion)
can install chart like latest version without the need of mention the chart version (good for dev environments)
probably there are more benefits

@dsaydon90 This is a good question.
There are a number of reasons. Here is one of them...
Helm does more than manage templates that are turned into Kubernetes manifests. It does package management which includes things like dependency management. In order to handle dependency management Helm uses semver for versions. This enables it to work out updates which is a common task. Other package managers do something similar.
In order to add support for dev, staging, etc then Helm would need to rework the way it handled versions which is not a small task.
The Docker use case of of using dev, staging, and so forth for floating tags is considered an anti-pattern by some as it causes problems. For example, if you deploy to production and there is an issue you need to roll back... how do you do that? You're following a floating tag and don't have the previous version. Using a tag like production also means you can't leverage caching well in a Kubernetes cluster. You have to always fetch from the registry. The constant pulling of images causes delays in launching, scaling, and causes hidden bandwidth costs.

can install chart like latest version without the need of mention the chart version (good for dev environments)

If you use a helm command without specifying a version you can get the latest today. This is already solved for.
I understand your desire for the floating tags. If you want to try to convince us I would ask that you show your use case is beneficial and that it's something we could do well in helm.

Hi @mattfarina , if using semver is a must also for OCI by design, I'm not sure that I'll be able to influence here.
But, in my opinion, I still think that it will be great to leave the power for the env user to decide how to manage his helm oci chart images (with sem ver or with env patterns ot whatever he wants).
My scenario is to let the developers to have easier life by picking the right helm oci chart version like helm oci chart image with the tag dev and if they will want to install the stg version they will just need to choose that tag.
probably there are more scenarios that the community can share.
This issue was just to keep the versioning by floating tags in mind, Let me know if currently nothing will be done and l will close this case..

Here is a serious drawback of semver: It implies a sortable array of versions. But that is simply not the case when you have independent feature branches being developed in an enterprise.
Say I have branchA and branchB feature branches running in parallel, and there are changes to both of them. How do we coordinate between them who gets to use which versions? And which versions are < than which other versions during development?
Here, only non-sortable "tags" have meaning as versions. Things like "branchA-234", "git-commit-123abc" and so on.

I believe the same comment @mattfarina posted earlier applies here as well @pmorch:

In order to add support for dev, staging, etc then Helm would need to rework the way it handled versions which is not a small task.

While I sympathize with your use case here, Helm is a package manager. A package manager's primarily focus is on published releases. In-development branches or pre-release versions are a secondary focus. Or in some cases, not considered at all.
Semantic versioning helps us address many of the issues that come with release management like sorting and version lookups (e.g. ^1.0.3). The tradeoff is that it does not help sort through pre-release versions such as a branch name, as you astutely point out.
If you can determine a way where we can apply the same feature set we get with semantic versioning for pre-release versions, we are open to suggestions in the form of a PR or a HIP. So far we have not found any similar solutions in other package managers. Or at least, they require significant time and investment to rework parts of Helm to address.

Point taken, @bacongobbler.
If you've decided:

In-development branches or pre-release versions are a secondary focus. Or in some cases, not considered at all.

then my point is moot. And I guess semver has proven its validity in the field already ;-)

Closing this issue as answered. Please feel free to comment here and let us know if you have further questions. Thanks!

One workaround is to publish the chart to:
oci://myregistry.com/my-project/my-artefact/dev:0.0.0
oci://myregistry.com/my-project/my-artefact/prod:0.0.0

This also has the added benefit of letting you track the history of the floating 0.0.0 label is, assuming your OCI registry keeps around un-tagged versions and their creation times.


WIP - 2DScrollable - Partial implementation for review

WIP for discussion in this design document

Closing this to keep it off the triage queue, discussion and feedback is still welcome though.


fixed cosmic_dance.jl example

PR Checklist
If you are contributing to Javis.jl, please make sure you are able to check off each item on this list:

[ ] Did I update CHANGELOG.md with whatever changes/features I added with this PR?
[ ] Did I make sure to only change the part of the file where I introduced a new change/feature?
[ ] Did I cover all corner cases to be close to 100% test coverage (if applicable)?
[ ] Did I properly add Javis dependencies to the Project.toml + set an upper bound of the dependency (if applicable)?
[ ] Did I properly add test dependencies to the test directory (if applicable)?
[ ] Did I check relevant tutorials that may be affected by changes in this PR?
[ ] Did I clearly articulate why this PR was made the way it was and how it was made?

Link to relevant issue(s)
Closes #358
How did you address these issues with this PR? What methods did you use?
Thanks @Sov-trotter for pointing out the mistake.

Thanks for the fix and PR @Ved-Mahajan :hugs:


code-splitting-redux-reducers

https://github.com/insin/react-examples/tree/master/code-splitting-redux-reducers

No more applicable since redux has been removed


Documentation: FP_CORE_UTIL set too low?

Description
The documentation at https://github.com/The-OpenROAD-Project/OpenLane/blob/master/docs/source/usage/hardening_macros.md#global-placement says that users should set PL_TARGET_DENSITY to 0.5 and FP_CORE_UTIL to 5.
This would set the target density to 50% and the core utilization to 5%.
Is this correct?
Expected Behavior
N/A
Environment report
N/A

Reproduction material
Read the documentation at https://github.com/The-OpenROAD-Project/OpenLane/blob/master/docs/source/usage/hardening_macros.md#global-placement
Relevant log output
N/A

I believe that might have been intentional for "tiny" designs. @armleo Do you recall if that was correct?

Documentation for FP_CORE_UTIL looks ok for small macros


Nestable state deltas

One things we've been discussing recently is that the current approach of separating routing and execution might not be the right thing to do, because it means that we can’t cleanly account for what happens as we move around the liquidity graph — for instance, if we have cycles, intuitively, there shouldn’t be any problem, because once we go “around”, we end up in a different market state with different available liquidity, but this requires a way to track state changes without having to commit to them. The approach of just trying to compose together trading functions doesn’t really capture that, and also caused us to run into other problems.
Instead, it could be cleaner if we did a different approach, where we directly simulated potential executions, then picked the one we like, i.e., as we explore a path, we actually execute trades along that path, and then see how much output we get from that trade, and then later, when we find a path we like, we can pick its execution trace and apply it.  Our current storage system doesn't allow this, however, because our StateTransaction isn't nestable.
This PR introduces a new StateDelta type, representing an arbitrarily-deeply nested stack of delta updates to an underlying state. This API allows exploring a tree of possible execution paths concurrently, before finally selecting one and applying it to the underlying state.
On creation, StateDelta::new takes ownership of a StateRead + StateWrite instance, acquiring a "write lock" over the underlying state (since &mut S is StateWrite if S: StateWrite, it's possible to pass a unique reference).
The resulting StateDelta instance is a "leaf" state, and can be used for reads and writes, following the some execution path.
When two potential execution paths diverge, delta.fork() can be used to fork the state update.  The new forked StateDelta will include all previous state writes made to the original (and its ancestors).  Any writes made to the original StateDelta after fork() is called will not be seen by the forked state.
Finally, after some execution path has been selected, calling delta.apply() on one of the possible state updates will commit the changes to the underlying state instance, and invalidate all other delta updates in the same family.  It is a programming error to use the other delta updates after apply() has been called, but ideally this should not be a problem in practice: the API is intended to explore a tree of possible execution paths; once one has been selected, the others should be discarded.
TODO

[x] Remove the GATs currently introduced in this PR and change the associated stream types to have a 'static lifetime, and update the internals of the existing State/StateTransaction code so that their streams can meet that requirement (this probably means wrapping internals in Arc<RwLock>).
[x] Connect the stub prefix stream to the StateDelta's nonconsensus_prefix method, then copy-paste its internals to provide stream impls for the other stream types (which are almost but not exactly the same; I think copy-pasting code will be clearer and more maintainable than trying to make the behavior generic)

The new StateDelta code is now fully functional, and side-by-side with the existing State/StateTransaction code. It passes all the same tests as those structures do.
I'm unsure whether the best course is to (1) merge it as-is, then deduplicate usage later, or (2) to carry through with

removing State/StateTransaction;
exposing Snapshot;
replacing State by StateDelta<Snapshot> and StateTransaction by StateDelta<StateDelta<Snapshot>>
possibly renaming StateDelta to StateTransaction (?)

in this PR.

I did the replacement in https://github.com/penumbra-zone/penumbra/pull/1983/commits/47a13e89068f9673d0dbbe272facffbe2e67efdc ; it ended up touching a fair amount of the component code because the trait signatures changed.


Rustdoc clippy and typo fixes

Various documentation fixes for warnings shown by running cargo clippy and typos.

Changelog already contains an entry about clippy fixes.

lgtm but there's still more clippy failures, could you fix those?

lgtm but there's still more clippy failures, could you fix those?

There are 2 lints "a const item should not be interior mutable":
const EMPTY_CELL: Cell<T> = Cell::new(0);
const INIT: UnsafeCell<MaybeUninit<T>> = UnsafeCell::new(MaybeUninit::uninit());

I'm not sure what to do here without breaking something.

Clippy docs just suggest to replace const with static.

Clippy docs just suggest to replace const with static.

But that doesn't compile, so it's not even an option.

you can remove the const, and do buffer: [const { UnsafeCell::new(MaybeUninit::uninit()) }; N]. this is inline const block, stabilized in 1.79.

you can remove the const, and do buffer: [const { UnsafeCell::new(MaybeUninit::uninit()) }; N]. this is inline const block, stabilized in 1.79.

Thanks. Done.


NeonServices misnamed, missing, or required?

We need to take a look at how the cluster services are named by NeonService and NeonServiceMap` as we converge on the v1 release.  Some of these service definitions may no longer be necessary and I also wonder if we should be naming other services like Loki, etc.

[x] Seems like NeonServices.NeonSystemDb=db-citus-postgresql should actually be neon-system-db, since that's how we talk about it.  I've also seen looking code like:
Log.LogInfo($"[{KubeNamespaces.NeonSystem}-db] Creating user '{dbUser}'.");

which (incorrectly?) uses the namespace name to log neon-system-db.

[x] I'm relocating the Grafana and Harbor setup code to Neon.Kube.Setup and removing the corresponding job services, so we can remove the SetupHarbor and SetupGrafana names.

[x] I'm also going to remove the following from the service names and maps:

[x]  neon-cluster-api: this service is going to be replaced by configmaps
[x] neon-identity-service/neon-identity-operator we're probably going to remove these services entirely
[x] test-cadence/test_temporal: NeonService serviceMap parameter has been optional for some time now so we don't need these definitions

[ ] Seems like we should add names for other services (so we don't have to hardcode strings everywhere) like:

[ ] minio
[ ] ???

[x] We should probably also rename NeonServiceMap --> NeonKubeServiceMap and NeonServices --> KubeService since the new names are more descriptive of what these actually are.

[ ] Make sure helm charts have correct names:

[ ] neon-cluster-operator chart is named incorrectly?

I think we've revisited service naming enough.  I'm going to close this.


resvg dependency update

It would be nice to have an updated version of resvg (especially because it would fix an issue I encounter).
I've tried to make iced_wgpu compatible with resvg v0.18 as there are some breaking changes but I guess I'm not skilled enough for this task.
I managed to make it compile but it's clearly broken (no svg display on screen) => my fork
Can someone have a look? It may be easy to fix. I didn't open a pull request but I can open a draft if someone want to help me on this.

I gave a shot at this in #1060.
It seems to work for me. Let me know!

It works for me too! Thanks @hecrj!


Add Google Analytics tag

I had to change from Hash to BrowserRouter for GA to pick up history changes within the browser as pageviews. Otherwise, just adding the GA4 property tag.
@wrunion

Unfortunately, using BrowserRouter would be a breaking change. We'll chat more soon!


Update AllMySmsTransport.php

if you don't json_encode the body, you'll receive an error from AllMySMS :
body content is invalid" (1005)

Can you move the PR to symfony/symfony? This is a read-only repository and nothing can be merged from here. Thank you.


Fixup granting of permissions on functions

The existing code failed miserably to grant permissions on functions.
Using the following code:
postgresql::server::grant { "grant_func_privs":
  role                    => 'rewind',
  db                      => 'postgres',
  privilege               => 'EXECUTE',
  object_type             => 'FUNCTION',
  object_name             => 'pg_catalog.pg_ls_dir',
  object_arguments        => ['text', 'boolean', 'boolean'],
  require                 => Postgresql::Server::Role[$rewind_user],
}

The created queries were:
GRANT EXECUTE ON FUNCTION "pg_catalog.pg_ls_dir"("text","boolean","boolean") TO "rewind";

and for the "unless" case:
SELECT COUNT(*) FROM (SELECT 1 WHERE has_function_privilege('rewind', 'pg_catalog.pg_ls_dir("text","boolean","boolean")', 'EXECUTE') = true);"

The patches in this series fix that to be:
GRANT EXECUTE ON FUNCTION pg_catalog.pg_ls_dir(text,boolean,boolean) TO "rewind";
SELECT COUNT(*) FROM (SELECT 1 WHERE has_function_privilege('rewind', 'pg_catalog.pg_ls_dir(text,boolean,boolean)', 'EXECUTE') = true);"

since both the types and the complete function expression must not be quoted.

Thanks for the friendly feedback!
I was sadly unable to run PDK on my platform with this module. It seems something is very broken my platform (Gentoo), since even after running:
pdk bundle install --path vendor/bundle

(which succeeds fine and installs the dependencies), trying to validate or unit test will make PDK attempt to reinstall all dependencies with sudo, completely ignoring they are already there in vendor/bundle.
Unless you have an idea what is wrong, I could only develop the tests "blindly" (using travis-feedback). I can certainly do that, but it may take a bit.

@sanfrancrisko That should have done the trick to get the Static and Spec parts green.
I can also look at the acceptance tests, they should run through fine now, but they only ever worked since they never tested granting permissions to a function taking parameters, so it would be better to add something like this to accepteance tests (I can try tomorrow, hopefully won't take too many iterations).

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@508571a). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #1150   +/-   ##
=========================================
  Coverage          ?   38.12%
=========================================
  Files             ?       15
  Lines             ?      480
  Branches          ?        0
=========================================
  Hits              ?      183
  Misses            ?      297
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 508571a...681fba1. Read the comment docs.

I did now also add an acceptance test for granting EXECUTE to functions with arguments.
Must have been beginner's luck, it seems to have played out well on my first attempt (and that was my first acceptance test ever) ;-).

Thanks for updating the current tests and adding the new coverage too @olifre. Appreciate you doing this as your first acceptance test! 😄
Change LGTM!
Regarding the issues you were seeing with the PDK - I asked some of my more PDK-savvy colleagues what they thought might be the issue. A few suggestions:

Drop the --path parameter from the bundle install command and let the PDK handle this
If you're using Bundler >= 2 you can set the path (seeing as using --path is now deprecated) globally: pdk bundle config set path <PATH> (FWIW, I have it set it to .bundle)

Before running pdk bundle install and pdk test unit, I would recommend removing the Gemfile.lock and vendor directory from your repo. Let me know how it works out.

@sanfrancrisko Thanks for the friendly feedback and the PDK help!
Sadly, it fails for me — I have PDK <IP_ADDRESS> (latest packaged version for Gentoo) and Bunder 1.17.2 (newer versions are available up to 2.1.4, but I should probably not mix them with an old PDK).
After cleaning up (removing {{Gemfile.lock}} and {{vendor}}) and then running:
pdk bundle install

it tries to run sudo and wants to overwrite my system's ruby installation :-(.
For the config (even with bundler 2) I would expect it won't work since PDK sets BUNDLE_IGNORE_CONFIG: 1 (as I see in the debug output) so any config would be ignored — no? Potentially, that's also why the path setting in the older bundler version fails.


How to actually run commands?

The command list at http://localhost:8282/hubs/harmony-hub/devices/linux-computer/commands works great. Whenever I try to run any of the commands, I'm failing miserably

http://localhost:8282/hubs/harmony-hub/devices/linux-computer/commands/volume-down
results in
Cannot GET /hubs/harmony-hub/devices/linux-computer/commands/volume-down
This is what my main page looks like.

The first time I tried I was attempting to use the example from the README and then I noticed that page listed it differently. I can't get it working either way.


4 saved nets

Hi,
when I load .t7 file, I can see 4 nets as dict in variable.
'Controller.encoder'
'conv2.classifier'
'fc4.classifier'
'glob-1.classifier'
what is the role of each net in code? which one i can use to calculate Mutual Information between 2 images?
best regards
then output of Controller.encoder is a vector in size (64), is this vector the encoded with max mutual information of input?

So the encoder is where everything is happening, from encoding the MI to scoring pairs from the joint / product of marginals. Unfortunately it's not separable in a simple way because it was built to take advantage of dataparallel, but it's still relatively easy to use.
So the controller first draws some data, then passes it through the encoder:
https://github.com/rdevon/DIM/blob/master/cortex_DIM/models/controller.py#L201-L208
The layer_outs is what we want, which actually is a set of vectors in the space we're going to computing the score (related to the PMI). This is a little opaque, but check out the forward function of the BigEncoder:
https://github.com/rdevon/DIM/blob/master/cortex_DIM/models/controller.py#L77
So what this forward does is it calls a function to extract some tensors needed for various models one might attach on top of an encoder. Once again, this was done this way to make dataparallel faster, but it made things a little less clear.
So what the encoder forward is doing after passing the data through the encoder when you attach DIM to it is this:
https://github.com/rdevon/DIM/blob/master/cortex_DIM/models/dim.py#L244
Which computes L and G which are the transformed versions of the local and global vectors respectively. We are going to use these to compute the score.
https://github.com/rdevon/DIM/blob/master/cortex_DIM/models/dim.py#L294-L301
So basically all you need to do is:

pull data
pass data through encoder like in the controller
extract the local and global vectors from layer_outs dict (keyword should be local) like in routine method in DIM.
score according to the function of your choice here, e.g.,:
https://github.com/rdevon/DIM/blob/master/cortex_DIM/functions/dim_losses.py#L13

Keep in mind that the PMI should be derivable from the scores u. Let me know exactly what loss function you are using and I can help you out there.

thanks a lot for your response,
when i load nets from .t7 how can I do part 3? I could get a 64 size vector from nets.encoder.
as I understood we compute Mutual Information on encoded feature from Images not strict by images that it is a combination of local features and global features, but what is the final result for saying this sentence "This is the vector that has most mutual information from input image and we can use it as an alternative for input image", Is it possible to say this sentence for final output of nets.encoder? (64 size vector of output)

yes , I did it. and this is the total values are saved in .t7 file

these are all variables that loaded with .t7.

yes , I did it. and this is the total values are saved in .t7 file

these are all variables that loaded with .t7. .

no I've just gotten a vector in size 64.

ok, so the list should be all activations, the dict should have values that correspond to the local / global vectors from DIM.


Address::to_raw sets both inner and bech32m when they are mutually exclusive

to_raw fn: https://github.com/astriaorg/astria/blob/c31c10b6db41b19fdce8e4b172363f855d88be23/crates/astria-core/src/primitive/v1/mod.rs#L451

Looking at the function, it sets the field to Bytes::new(), which is the correct thing to do. The default value of a unset protobuf bytes field is "empty".
Closing this as not-fix because it's correct and the bug report wrong.


Module 2 exercises [BASHARA AHMED ABUBAKARI]

Education Facilities.pdf
Road Network Density.pdf
Health Facility.pdf
Soil Suitability Index.pdf

Please "drag & drop" exercise 1 pdf file below.

Please "drag & drop" exercise 2 pdf file below.

Please "drag & drop" exercise 3 pdf file below.

Please "drag & drop" exercise 4 pdf file below.

Please UPDATE THE TITLE of this "Issue" in the title bar above with your name.

If you haven't done so, please go back to Module 2 and make sure to take
the post-training survey. Participating in surveys is required for receiving
the "GALUP Certificate" by the University of Florida.

Well done, Bashara. You clearly grasped the material outlined in Module 2 and successfully applied it to these exercises. There was a minor issue with your legend for Exercise 2 (it has the legend from exercise 1), but this can be fixed by updating/refreshing the legend in the layout editor to match your current map display. Otherwise, everything looks good. Thank you for your participation!


Question about the provided command

Dear authors,
Thank you for your great work!
The python commands you provided are in this form: python -minclearn. Could you please kindly educate me how this works? Usually, the python comments I use have the form of python my_script.py -single_character_parameter --multiple_character_parameter.
I searched the web but didn't find any relevant info. I would appreciate it if you could share some.
Thank you in advance!

Hi.
In fact, python -minclearn  is the same as the python -m inclearn -xxx, which runs the inclearn as a module. And these two command is basically the same as python inclearn/__main__.py

Thank you so much!


Minor fixes to discovery node in misc

better logging
ethmac -> ether
include firmware version in bacnet

merging because misc directory


MangaHub: update API URL

Updated the MangaHub API from "mghubcdn.com" to "mghcdn.com" to resolve the issue "hostname api.mghubcbdn.com not verified" as the URL had moved over to "mghcdn.com"
Checklist:

[ ] Updated extVersionCode value in build.gradle for individual extensions
[x] Updated overrideVersionCode or baseVersionCode as needed for all multisrc extensions
[ ] Referenced all related issues in the PR body (e.g. "Closes #xyz")
[ ] Added the isNsfw = true flag in build.gradle when appropriate
[x] Have not changed source names
[ ] Have explicitly kept the id if a source's name or language were changed
[x] Have tested the modifications by compiling and running the extension through Android Studio
[ ] Have removed web_hi_res_512.png when adding a new extension

PR made through GitHub web editor. Please actually compile and test your changes in Android Studio or AndroidIDE.

PR made through GitHub web editor. Please actually compile and test your changes in Android Studio or AndroidIDE.

i applied the changes to the apk and ran it on my mihon client, and it worked. Only after that did i made the branch.

oh yeah lemme show you the screenshots. also sorry abt that checklist, i mistakenly added that in.

sure ig, you still need to bump baseVersionCode in the generator. read the Contributing guide for more info.

sure ig, you still need to bump baseVersionCode in the generator. read the Contributing guide for more info.

oh yeah sure, lemme do that.

sure ig, you still need to bump baseVersionCode in the generator. read the Contributing guide for more info.

if you dont mind, could u point me towards that specific guide that u mentioned? i dont seem to find anything that mentions that thing u mentioned.

https://github.com/keiyoushi/extensions-source/blob/main/CONTRIBUTING.md

so from my understanding of it, it should be good to go now.

so from my understanding of it, it should be good to go now. Please do let me know if that's the case of if it still requires some changes.

That's not the correct version to bump. You are making changes to the base theme, so you must edit baseVersionCode like what AwkwardPeak7 said.

so from my understanding of it, it should be good to go now. Please do let me know if that's the case of if it still requires some changes.

That's not the correct version to bump. You are making changes to the base theme, so you must edit baseVersionCode like what AwkwardPeak7 said.

Oh, i checked the contribution guide and it said to bump that for the existing extention. Ig I'll just do what u told me to

Alright, made the change as the both of you suggested. Hopefully that should be it now.


brew doctor hopelessly slow

Your Windows build number:  (Type ver at a Windows Command Prompt)
Microsoft Windows [Version 10.0.18362.267]

What you're doing and what's happening:  (Copy&paste the full set of specific command-line steps necessary to reproduce the behavior, and their output. Include screen shots if that helps demonstrate the problem.)
In WSL (I use Debian/GNU Linux), install linuxbrew (https://docs.brew.sh/Homebrew-on-Linux). On my system, I have 77 programs installed (brew list | wc -l). Once it's installed, run the following command:

time brew doctor
On my system, here's the output:
 Your system is ready to brew.
 brew doctor  1.86s user 8.03s system 11% cpu 1:23.02 total

What's wrong / what should be happening instead:

The performance of this command is incredibly bad. If I disable Windows Security Real-time protection, and run the command again, here's the output:
 Your system is ready to brew.
 brew doctor  1.81s user 5.25s system 99% cpu 7.087 total

I've read about this numerous times; developers recommending disabling real-time protection to get back performance on their development machines. Would it be possible to disable this for the WSL system when it's working in its own file system? This performance difference is frankly striking (more than 10x faster in this case).
Another very noticeable performance difference is in brew list itself:
time brew list
brew list  0.28s user 1.30s system 77% cpu 2.031 total
brew list  0.39s user 1.17s system 98% cpu 1.584 total
The top line is with real-time protection enabled, bottom line with it off.

This is somewhat improved by excluding the folder
~/AppData/Local/Packages/TheDebianProject.DebianGNULinux_76v4gfsz19hv4/
in Windows Security -> Virus & threat protection -> Virus & threat protection settings -> Exclusions
But even with this setting, the execution time is:
brew doctor  2.84s user 13.36s system 66% cpu 24.545 total

#873 et al


rootfs.vhd make target

New makefile target to create rootfs.vhd from rootfs.tar using tar2ext4.
Requires building cmd/tar2ext4 locally.
Signed-off-by: Hamza El-Saawy<EMAIL_ADDRESS>

Oop this needs a rebase after https://github.com/microsoft/hcsshim/commit/51aee6bd9e4da920dd6473137929370606402ad1

Maybe it's worth having this be part of the default goal, can't think of why we wouldn't want to always build this as it's the default if it exists.

I think this line gzip -f -d ./out/rootfs.tar.gz consumes the tar.gz file, so running it by default would crash all the pipelines that expect to build the rootfs manually


vertx stack resolution should use VERTX_HOME/lib directory when it exists

If the directory exist, the resolution result may be cached to speed up the next resolution


link github team updates to trino configurations

@MichaelTiemannOSC  asked if changes to team memberships could automatically trigger workflows. The use case was keeping team memberships and trino access control synchronized.
This is the list of categories of "event" that can trigger a github workflow:
https://docs.github.com/en/actions/learn-github-actions/events-that-trigger-workflows
I don't see any triggers that directly map to "change to team members" but one could probably contrive an issue-based system that triggers a workflow which both updates team members and creates a pull-request to make some corresponding change to a trino policy config.
It might be advantageous to focus on how this could be accomplished in a world where we are using Ranger.

Another promising approach is to write a trino GroupProvider plugin that does what we want.
xref: https://github.com/trinodb/trino/issues/9835
An example of such a plugin implementation, for LDAP, is here:
https://github.com/arghya18/trino-group-provider-ldap-ad
Based on that example, a similar plugin that used github api instead of ldap api would be simple enough to be feasible.

Trino's doc page, for completeness:
https://trino.io/docs/current/develop/group-provider.html

cc @caldeirav  @rimolive  @HumairAK

With this approach, file system access control implementation will primarily rely on group based catalog rules (for contributors). And we can use role-based access for example for internal operations / admin users once this is available: https://github.com/trinodb/trino/issues/9839
See my comments on the above issue, where the multiple GroupProvider approach could be used for federation purpose when multiple data providers leverage the platform to share data.

I have created a skeleton repo for a GitHubGroupProvider:
https://github.com/os-climate/trino-github-group-provider
It will build with mvn clean package but it only returns an empty Set<String>, so it needs the biz logic for actually talking to a github org and identifying team memberships to use for trino group names


labview 2020 64 bit

create read/write method VI name is not correct

Is that using the latest Beta Build (v1.2.54)?
I haven't been able to reproduce it yet.

I found another bug and I've added .vim creation support.
But I can't replicate this error :-(.
Can you send my the class example?

Desktop.zip

this pitcure show the other bug?

what is the differences about these two method？

Interesting...

Interesting...

Do you reproduce these bugs？

Interesting...

Hi Do you replicate these errors??

I've not found the issue yet.
You can always help he out and probe some values in the VI:
C:\Program Files (x86)\National Instruments\LabVIEW 2020\resource\Framework\Providers\Open_GDS\ClassProviders\Provider_LvNativeClass\ClassWriterNative_class\DialogCreateMethod.vi
...to see what's going on.
To debug this VI (or any OpenGDS VIs), open the VI, enable "Allow debugging" (VI Properties/Execution), add a Break Point on the BD in the VI and save it.
Then restart LV and when this VI gets called the BD will open and you can debug it.
After the VI gets closed, the debugging stops working so to debug it again, you have to restart LV and repeat the process.

BTW regarding the Property Method:Get/Set or Property Node:Read/Write, if you use the Property Node:Read/Write, you can read and write object attribute values using a standard Property Node VI (QD: rn).
You could of course use thee Read/Write VI as normal SubVIs but that's not their intention.

BTW regarding the Property Method:Get/Set or Property Node:Read/Write, if you use the Property Node:Read/Write, you can read and write object attribute values using a standard Property Node VI (QD: rn).
You could of course use thee Read/Write VI as normal SubVIs but that's not their intention.

I've not found the issue yet.
You can always help he out and probe some values in the VI:
C:\Program Files (x86)\National Instruments\LabVIEW 2020\resource\Framework\Providers\Open_GDS\ClassProviders\Provider_LvNativeClass\ClassWriterNative_class\DialogCreateMethod.vi
...to see what's going on.
To debug this VI (or any OpenGDS VIs), open the VI, enable "Allow debugging" (VI Properties/Execution), add a Break Point on the BD in the VI and save it.
Then restart LV and when this VI gets called the BD will open and you can debug it.
After the VI gets closed, the debugging stops working so to debug it again, you have to restart LV and repeat the process.

Did you open this project? is it correct??

There is no issue with the project when I use it?!?!?

There is no issue with the project when I use it?!?!?

I find this _property ctl seems not correct. what is the problem?

There is no issue with the project when I use it?!?!?

it seems labview'bug??


feat: implementing sharing files

Summary:

Current Functionality: File upload is functional and supports multiple files.
Current Limitation: All files are currently processed through kUTTypeURL.

Next Steps:

Testing Against kUTTypeFileURL: I am in the process of testing file uploads against kUTTypeFileURL. This will help differentiate between general URLs and file URLs more effectively.

Notes:

Plan: Once testing is complete and verified, I will update this PR with the necessary changes. PS: I'll be testing on a real device since it will be essential to fully validating the behavior of kUTTypeFileURL.

Update:
I tested this PR on a physical device and every file still goes through kUTTypeURL, I'm not proficient in Swift but everything works fine :)

awesome, thank you @kayode0x! will test it later today

done :)

Released as part of 1.8.0: https://github.com/MaxAst/expo-share-extension/releases/tag/v1.8.0
Thanks for the contribution @kayode0x  🙏


Upgrade nowrap classes for Tailwind 2.0

Updating classes per https://tailwindcss.com/docs/upgrading-to-v2#update-renamed-utility-classes

I've updated the classes with my last commit. Thank you for your contribution.


Add text for specific data values on charts

Hi,
Is there a way to add text to specific data values in a chart? through the dataLabelFormatCode we can apply it to all of the data labels but not for a specific label.

Hi
Something similar was started here : https://github.com/gitbrent/PptxGenJS/pull/727
Powerpoint can take values from cells, so maybe the dataLabels could be stored in a new column

@benjaminpavone  Thanks for your response. the PR wasn't approved so we don't have the support for it.
there is another way that I can refer to?

Is there anything new regarding this issue?


Show all rows does not work for the wide table (110 columns)

This was a problem with the maximum network message size for web sockets.
I have increased in web.xml, but we need better error reporting to diagnose such problems (see #68).


AdminIDFile parameter in env_domino not working

Hi,
I'm new to Domino but I love the idea of Domino on Docker! Nice job guys!!
I use --env-file parameter when I execute the docker run command ... and when I add to the env_domino file the variable:
AdminIDFile=/local/notesdata/admin.id
no id file is created in the path /local/notesdata/

Sorry we have not seen this question earlier..
We are using what Domino offers with the standard setup and "just" make it available over environment configuration.
In the standard setup this is an input and not an output parameter.
You don't need to specify an admin for a 2nd server in the domain. This is only needed for the first server.
Here is an example what you would use for a 2nd sever:
  isFirstServer: "false"
  ServerName: domino-acme-02
  ServerIDFile: http://<IP_ADDRESS>/software/domino-acme-02.id
  OtherDirectoryServerName: domino-acme-01
  OtherDirectoryServerAddress: domino.acme.com

Sorry we have not seen this question earlier..
We are using what Domino offers with the standard setup and "just" make it available over environment configuration.
In the standard setup this is an input and not an output parameter.
You don't need to specify an admin for a 2nd server in the domain. This is only needed for the first server.
Here is an example what you would use for a 2nd sever:
  isFirstServer: "false"
  ServerName: domino-acme-02
  ServerIDFile: http://<IP_ADDRESS>/software/domino-acme-02.id
  OtherDirectoryServerName: domino-acme-01
  OtherDirectoryServerAddress: domino.acme.com


Issue with Access control in AWS Amplify Console

** Please describe which feature you have a question about? **
Access Control in the AWS Amplify Console seems to be broken
** Provide additional details**
1.- Access control passwords were configured previously for existing GitHub master and dev branches (No global password)  Result: OK
2.- Updated the master branch to "Publicly viewable" Result: No OK
Other attempts:

Even after re-deploying the master branch the password was not removed.
Enabling a Global password, then disabling it and then setting "Publicly viewable" to the master branch and "Restricted - password required" for the dev one. Didn't work either.
The documentation does not clarify if it takes a particular amount of time to update such passwords. https://docs.aws.amazon.com/amplify/latest/userguide/access-control.html

PD: Issue seem to be related to https://github.com/aws-amplify/amplify-console/issues/171 but such issue is closed. So I opened this one.

Hi @jhonangelmireles. So basically the issue is you can't disable the access control right now. Can you share the appId and region with us. We will investigate your issue.

I have this same issue. Enabled password and when I remove it still enforces it.

I am still facing this issue. Even after changing the branch access to "publicly viewable", username & password is being enforced.

@spdiamstu If you are using Next.js - SSR framework, rebuilding should work.

+1 This issue is back. Any fixes?


a phone compatible version

I would like to try the game but since I am a cell phone user I cannot play this version, I only suggest if you can create a compatible version for cell phone users who use the M64Plus FZ emulator

This is not a reasonable request. Your options for playing on a mobile device is Retroarch with Mupen64plus-next core the GLES3 version. The issue is with the emulators, not on us.


Change swift-nio Package dependency version (once NIOAsyncSequenceProducer has been released)

Our package makes use of NIOAsyncSequenceProducer. At the time of writing this issue, NIOAsyncSequenceProducer has not been included in an official swit-nio release (version at the time of writing this: 2.41.1).
Once a new swit-nio version has been released, please change the Package.swift dependency as follows:
dependencies: [
-   .package(url: "https://github.com/apple/swift-nio.git", branch: "main"),
+   .package(url: "https://github.com/apple/swift-nio.git", from: <latest_version>),
    .package(url: "https://github.com/apple/swift-log.git", from: "1.0.0"),
],

https://github.com/apple/swift-nio/releases/tag/2.43.1 should have it now.

Hey @hassila,
thank you for pointing that out! I have created a PR accordingly


Added missing option documentation

What I did
isToolshown was missing from documentation so i've added it.
It allows to control if to show or hide the toolbar above the story.

Sure!

Oh I didn't realize that options was being deprecated. Excuse my oversight

Thanks for the fix @mortal94


upgrading point cloud from master branch to 0.2.0

This chunk of code is used to populate the vertices of a THREE.ParticleSystem (named THREE.PointCloud in the latest version of three.js), which renders the geolocation of various social media icons on the map. With the master branch code, it took some digging but I figured out how to add particles to my map (see issue #155). Having a little bit of trouble performing the same task with the 0.2.0 branch- any help would be appreciated :)
define(function(){ return function(options){
    var
        coords = options.city.geo.projection([
            parseFloat(options.longitude),
            parseFloat(options.latitude)
        ])
    ;
    return (
        options.geometry.vertices.push(new THREE.Vector3(
            coords[0],
            options.altitude * options.city.geo.pixelsPerMeter,
            coords[1]
        )) - 1
    );
};});

guessing this'd be something suitable for a blueprint wotsit, rather than fudging it directly into three.js?

cough. any assistance ?

yes the idea of 0.2.0 is that you can do whatever data inputs & visualizations cleanly as plugins, and those are called blueprints. input bluprints and output blueprints. no need to hack vizi core (for example the scene creation code9 like in 0.1.
this is an example of such an output plugin that draws points:
https://github.com/vizicities/vizicities/blob/0.2.0/src/Blueprint/BlueprintOutputDebugPoints.js


[#3057] fix(web): fix breadcrumbs text display styles

What changes were proposed in this pull request?
Fix breadcrumbs text display styles.
Why are the changes needed?
Fix: #3057
Does this PR introduce any user-facing change?

How was this patch tested?
local

Can it support auto-adjusting for different screen size?

It's flexible width of Breadcrumbs from the code.

I think left pannel need have Horizontal scrollbar instead of truncating the word

The horizontal scrollbar is too ugly, I suggested to truncate the word and see the whole word when hover the tree node a while. And that's how it's usually handled. @xunliu

The horizontal scrollbar is too ugly, I suggested to truncate the word and see the whole word when hover the tree node a while. And that's how it's usually handled. @xunliu

Can it support auto-adjusting for different screen size?

Yes, I tested different size.

The current implementation looks good to me. @LauraXia123 can you please help to review the code?

LGTM


Fix typo

node.js -> Node.js

@changeworld : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Looks good; Thanks @changeworld


Add Persistent Review Feature to PR Agent

PR Type:
Enhancement

PR Description:
This PR introduces a new feature to the PR Agent that allows it to publish persistent reviews. The main changes include:

A new method publish_persistent_review has been added to the abstract git_provider class and implemented in the github_provider class.
The run method in pr_reviewer has been updated to use the new publish_persistent_review method if the presistent_comment setting is enabled.
The release notes have been updated to reflect this new feature.

PR Main Files Walkthrough:
 files:

pr_agent/git_providers/git_provider.py: Added a new abstract method publish_persistent_review.
pr_agent/git_providers/github_provider.py: Implemented the publish_persistent_review method. This method checks for previous comments starting with "## PR Analysis", updates them if found, or creates a new comment.
pr_agent/tools/pr_reviewer.py: Updated the run method to use the new publish_persistent_review method if the presistent_comment setting is enabled.
RELEASE_NOTES.md: Updated the release notes to include the new persistent review feature.

Example usage
We will only enable one 'review' message in a PR. every new 'review' command will re-edit it

/describe

Preparing review...

@zmeir
Please notice this PR.
i dont think it collides with 'remove_previous_review_comment', but you are welcome to check and validate.
I think that persistent review will be more useful for most people, compared to 'review -i'

Preparing review...

Preparing review...

Preparing review...

Preparing review...

Preparing review...

PR Analysis

🎯 Main theme: Add Persistent Review Feature to PR Agent
📝 PR summary: This PR introduces a new feature to the PR Agent that allows it to publish persistent reviews. The main changes include adding a new method publish_persistent_review to the abstract git_provider class and implementing it in the github_provider and gitlab_provider classes. The run method in pr_reviewer has also been updated to use the new method if the persistent_comment setting is enabled. The release notes have been updated to reflect this new feature.
📌 Type of PR: Enhancement
🧪 Relevant tests added: False
⏱ Estimated effort to review [1-5]: 3, because the PR introduces a new feature and requires reviewing changes in multiple files.
🔒 Security concerns: No security concerns found

PR Feedback

💡 General suggestions:

It would be helpful to provide more context in the PR description about the motivation behind adding the persistent review feature and how it benefits users.
Consider adding some unit tests to cover the new functionality in the git_provider classes.
Update the release notes to include any necessary instructions or details for users to use the persistent review feature.

 🤖 Code feedback:

relevant file: pr_agent/git_providers/github_provider.py
suggestion: Consider adding error handling for the case when editing a comment fails in the publish_persistent_review method. [important]
relevant line: self.publish_comment(pr_comment)

relevant file: pr_agent/git_providers/gitlab_provider.py
suggestion: Consider adding error handling for the case when updating a comment fails in the publish_persistent_review method. [important]
relevant line: self.publish_comment(pr_comment)

relevant file: pr_agent/tools/pr_reviewer.py
suggestion: Consider refactoring the logic in the run method to separate the code for publishing a persistent review into a separate method for better readability and maintainability. [medium]
relevant line: self.git_provider.publish_persistent_review(pr_comment)

relevant file: pr_agent/settings/configuration.toml
suggestion: Consider adding a comment or documentation explaining the purpose of the persistent_comment setting. [medium]
relevant line: persistent_comment=true

Preparing review...

Preparing review...

/describe


Clean train

I found 3 variables always are null, and verified it with source code and compiling.
Check it within internal opensource, external opensource, metric learning usage..  Passed compilation. So, Just remove them ?
Maybe I am wrong, but clean it necessary if I am right.
@emailweixu @hedaoyuan @reyoung

Track related LOG:
commit 623a419538564aa91fb02b71d57e2576979c127b
Author: xuwei06 xuwei06@1ad973e4-5ce8-4261-8a94-b56d1f490c56
Date:   Wed Jun 3 00:15:21 2015 +0000
Change Trainer to support multiple trainer in one process.

And fixed a bug for Stat.cpp

git-svn-id: https://svn.baidu.com/idl/trunk/paddle@630 1ad973e4-5ce8-4261-8a94-b56d1f490c56

commit ae24f3d3b08517f6b6ee9cc07a89ebf22e059809


performance drop with GooglenetV1

Before v0.5 I used padR=padding in pooling layer, it works well and got a very good perf with googlenet scoring.
However with this new release, there is a check point in Pooling.cpp:
 for (int i = 2; i <= 3; ++i)
        consistency = consistency && (
                (src_desc->dims[i] - kernel[i - 2] + padding_l[i - 2]
                 + padding_r[i - 2]) / strides[i - 2] + 1
                == dst_desc->dims[i]);
    if (!consistency) return invalid_arguments;

So I have to use padR just like the test case:
for (int i = 0; i < 2; ++i) {
        if ((pd.ih + pd.padh + padR[0] - pd.kh)/pd.strh + 1 < pd.oh) ++padR[0];
        if ((pd.iw + pd.padw + padR[1] - pd.kw)/pd.strw + 1 < pd.ow) ++padR[1];
 }

Then the fps drops to HALF before.
And there are about 4 pooling cases in GooglenetV1 this padR would be used, taking much more time than before.
I thought the output memory would be clear to zero, before pooling right? So even if I use padding(instead of padR), the loss result was still right with much better performance.
PS: padding_kind::zero
So any possible improvement ?

Thanks for catching this. We changed the way we handled padding in pooling to be consistent with TensorFlow and MXNet frameworks, but this resulted in code falling back to reference pooling implementation in case of uneven padding. We will address the issue and performance for this case will be on par with what you observed before.

Thanks, looking forward.

378dcf97e28be7301e9ca2d3448a2a272de2820e fixes this issue.


Add java10 1.10.0_1-b10 (new cask)

💁 These changes add a Cask for Java 10

[x] brew cask audit --download {{cask_file}} is error-free.
[x] brew cask style --fix {{cask_file}} reports no offenses.
[x] The commit message includes the cask’s name and version.

Additionally, if adding a new cask:

[x] Named the cask according to the token reference.
[x] brew cask install {{cask_file}} worked successfully.
[x] brew cask uninstall {{cask_file}} worked successfully.
[x] Checked there are no open pull requests for the same cask.
[x] Checked the cask was not already refused in closed issues.
[x] Checked the cask is submitted to the correct repo.

Sorry, can't read 😴

No, sorry again. My first comment was correct.

Whoops. Thanks.


AT-SPI2: Activate tree updates only if org.a11y.Status's IsEnabled is true

In Slint we've had the situation that on Linux machines where there's no screen reader running, access kit would still send tree updates on the a11y bus. We've seen this in https://github.com/slint-ui/slint/issues/3867 as well as in https://github.com/slint-ui/slint/pull/3046#issuecomment-1623831111 .
Based on my reading of https://www.freedesktop.org/wiki/Accessibility/AT-SPI2/ as well as peeking at the Qt Sources as well as Orca it seems like to me that AccessKit's AT-SPI2 adapter should consider itself active only if org.a11y.Status.IsEnabled in the path /org/a11y/bus on org.a11y.Bus on the session(!) bus is true, and of course watch the property for any changes.
Would this behaviour make sense to implement?

Do GTK and Qt check this status just once on startup, or can they connect to the bus, watch for the status to change, and initialize accessibility if, say, Orca is started after the application? The latter would be ideal, but we should at least aim for parity with existing toolkits.

Qt checks this once on startup and then is supposed to watch for changes, but that isn't implemented. I can't find out where Gtk would check for this property, but the spec suggests that this is what toolkits should do.
Okay, but your response sounds like you agree that access kit should implement the spec'ed behaviour. That would solve the issue one of our users reported (paying a price for tree updates despite no a11y tech being in use), while still providing full accessibility support when needed.
I might give it a try when I'm back - I'll be offline for a few weeks. But anyone please feel free to beat me to it ;-)

Hello,
GTK3 may have used this property in the past, but GTK4 surely doesn't care.
By the way I have a VM running Ubuntu 23.10 on which the AT-SPI daemon is started and IsEnabled always return true even when no AT appear to be currently running. I think the bus launcher accepts an argument to force this property to true, and I wouldn't be surprised if some distributions use it if accessibility is configured to start with the system.
With that being said, this is on my TODO list. I didn't implement it initially because I wasn't sure where we would monitor for the property change signal, it's still a bit blur currently to be honest.
If we want to do it right, we should also monitor the session bus for name owner changed events for org.a11y.Bus, otherwise we risk crashing the application if the accessibility bus goes down. We also want this process to be centralized, keeping track of all the adapters so that we can activate/deactivate them from a single place.
I don't think it's going to be so easy, I can't really spend time on this before mid next week anyway.

Woah, I overthought this one!

We don't need to watch for name owner changed signals if we directly monitor the session bus for property changes (without using the proxy mechanism provided by zbus).
As soon as the adapter is initialized, I think most UI toolkit developer don't mind if it doesn't deactivate when all ATs stop. Otherwise we would need to re-initialize an adapter and we will need a more complicated API for that.
At this point, Adapter::new should not return an Option anymore, The adapter's design should come closer to the subclassing adapters we have for macOS and Windows.
The hardest part is to initialize multiple adapters if an AT was not running when the app started.

I think I can handle this in a reasonably short time.

Status update
Tackling this issue is taking me way longer than I anticipated... I wasted time trying multiple approaches and I am not really used to writing async Rust, but I think I finally just solved the last major blocker. I still have a couple of tasks to finish, but the PR might be ready before this weekend.

Thank you for implementing this!


Fix issue where seeders improperly marked as leechers

This fixes an issue I was running into with traditional BitTorrent clients. The tracker was marking seeders as leechers, even though this was not the case.
When starting a new transfer with all of the files already downloaded, a started event is sent out with left=0 (at least this is the case in Deluge and Transmission). A completed event is explicitly not sent out (FTA https://wiki.theory.org/BitTorrentSpecification):

completed: Must be sent to the tracker when the download completes. However, must not be sent if the download was already 100% complete when the client started. Presumably, this is to allow the tracker to increment the "completed downloads" metric based solely on this event.

Currently params.left is set to Infinity even if it was supplied as left=0 in the querystring. This fixes that issue, and retains the behavior of setting params.left to Infinity when it is unparseable.

Looks good to me. I'm just going to swap isNaN for Number.isNaN since I usually try to avoid isNaN's automatic coercion. Doesn't make a difference in this case, though.

8.0.13


Delete .travis.yml

@nirushanm Please sign the Contributor License Agreement!
Click here to manually synchronize the status of this Pull Request.
See the FAQ for frequently asked questions.

Not sure why we would want to do this.


Updating Xamarin sample with proper linker settings

Xamarin.iOS requires the linker behavior to be set to Don't Link. Updating the sample to have the linker set to that value for all build configurations and updating the readme to note that as well.

@JeremyLikness for review.

@codemillmatt few questions for this PR:

Is --interpreter still needed or not? If yes, can we update the doc to explain why?

When I follow the link for the linker options, I see this:

Disabling linking will make sure that no assemblies are modified. For performance reasons this is the default setting when your IDE targets for the iOS simulator. For devices builds this should only be used as a workaround whenever the linker contains a bug that prevents your application to run. If your application only works with -nolink, please submit a bug report.

(Emphasis added my own). Is it possible to turn off linking just for the Entity Framework package? Is this solution a workaround (we should note that in the doc) or a permanent one?
Jeremy

Hey @JeremyLikness ...

--interpreter is no longer needed.

And I wanted to talk with you about linking/not linking Entity Framework. Right now when I tell the linker to skip the EF packages I still get the exception. I would suspect then that EF is using something further down the chain the linker needs. Or maybe not ... I'm going to pull the EF source into the solution & see what I can find out. Ideally we can then add [Preserve] attributes to the correct spots and make a permanent fix.

fwiw - it looks like it's the QueryableMethods constructor where the issue is originating from - lots of reflection going on in there.

A little more digging - since QueryableMethods is doing a bunch of reflection - something that eventually gets used based off that class (in this particular case it will be Count) gets linked out.
But if I do a --linkskip System.Core all is well without having to turn off linking altogether.
Now with that said, it would be nice if we could narrow this down a bit more, so I'll still do some digging.

@codemillmatt thanks for your efforts with this! Is it in a state ready for review or are you still working on it?

@JeremyLikness - yes - please do give it a review. If it's good let's merge this in.


Packaging: Snapcraft

We should consider packaging a Snapcraft package.

From goreleaser:

Remember you need to snapcraft login first.

Not sure if this works with GHA.

Seems it would:
https://github.com/snapcore/action-build
https://github.com/snapcore/action-publish

store_login: ${{ secrets.STORE_LOGIN }}
This will build the project, upload the result to the store, and release it to the edge channel. If the release input parameter is omitted, then the build will not be uploaded but not released.
In order to upload to the store, the action requires login credentials. Rather than a user name and password, the action expects the data produced by the snapcraft export-login command.

When I was trying to get started with this their login server was down ... At some point I'll try again.

#1897 has an first draft using goreleaser but I don't think this will work.
goreleaser doesn't seem to support runtime dependencies but we will need at least gpg, git and likely some others (like xclip). Also I haven't figured out how to use pinentry or SSH and GPG agents.
Maybe we can package it with an custom snapcraft.yaml or maybe we need to ask for classic confinement.

I've created a draft but this is more involved than I tought. The level of isolation they require is quite annoying for us. gopass itself is working, even SSH. But the GPG agent doesn't seem to work (yet). Their documentation is OK, but the interfaces docs are a bit lacking.

I didn't make much progress here. The snapcraft documentation wasn't very helpful.
But if someone wants to help, feel free to do.


One to Many Relationship Backwards

In the visualizer, the crows feet point to the "one" instead of pointing to the "many".
model Person {
  id      Int       @id @default(autoincrement())
  friends Friends[]
}

model Friends {
  id       Int     @id @default(autoincrement())
  Person   Person? @relation(fields: [personId], references: [id])
  personId Int?
}

Shouldn't it be the other way around?

Nope, from all I've seen, the way it's currently done in Prismaliser is correct

Welp, TIL. Seems backwards to me but I'll go with it. I like the tool a lot.

Hey, I also have the same doubt.
I used dbdiagram.io before.
So, for me the Mapping seems to be reversed.
I would like to know if my presumption was wrong.
I've attached one example from dbdiagram.io where one country can have many users (one-to-many):-


Runtime Error in sensor.py as of version 0.5.11 of RPi.GPIO

Upgraded to version 0.5.11 of RPi.GPIO and am receiving the following error when raspisump initiates a reading with sensor.py
Traceback (most recent call last):
File "/usr/local/bin/rsump.py", line 19, in
reading.water_reading()
File "/usr/local/lib/python2.7/dist-packages/raspisump/reading.py", line 36, in water_reading
water_depth = pit_depth - value.distance()
File "/usr/local/lib/python2.7/dist-packages/raspisump/sensor.py", line 32, in distance
GPIO.setup(self.trig_pin, GPIO.OUT)
RuntimeError: Please set pin numbering mode using GPIO.setmode(GPIO.BOARD) or GPIO.setmode(GPIO.BCM)

In the meantime you can downgrade to version 0.5.10 as follows
sudo pip uninstall RPi.GPIO
sudo pip install https://pypi.python.org/packages/source/R/RPi.GPIO/RPi.GPIO-0.5.10.tar.gz#md5=f1c67de40bf99e0612d75538b06a2181

As of version 0.5.11 of RPi.GPIO the GPIO.setmode statement in sensor.py has to be moved inside the 'for loop' in distance(self) method.
This happens because, according to the changelog for version 0.5.11 of RPi.GPIO, the 'GPIO.cleanup() unsets the current pin mode'
So it was getting unset after the first sample was taken.
This will be fixed in version 0.5.3 of Raspi-Sump.  In the meantime simply downgrade RPi.GPIO to version 0.5.10 as stated above.  Will try to fix by this weekend.

Issue fixed with raspisump version 0.5.3
sudo pip install -U raspisump


Re-fs.watching files on rename event

Some editors (e.g. Coda) rename temp files rather than directly overwriting files on save; fs.watch loses track of the file at that point. This patch makes fs.watch re-bind itself on "rename" events. See discussion at #1803, #1846, and at https://github.com/joyent/node/issues/2062.

Modified so that the close event is called on the FSWatcher corresponding to the old fs.watch when the new one is created; that way, if the Node team decides to change the behavior of fs.watch in the future to continue monitoring a file after being replaced by a rename, we won't get duplicate watch events.

Since @jashkenas wanted to try hard to stick with the new, not-so-stable fs.watch API, this is a more desirable patch. LGTM

Agreed -- and looks quite elegant. I'm probably going to be busy / out of the loop for the next few days, so feel free to merge at will.

So, as Michael points out, there's a problem: "rename" can mean either that the file was overwritten (in which case we want to re-watch it), or that it was moved elsewhere. If it's moved elsewhere, the file is still watched (which we may or may not want, depending on where it moved to—but maddeningly, there's no way to tell where it moved to!).
It bears mentioning that fs.watch is capable, at least in principle, of watching directories for changes. That'd be great, since it'd give us new file detection at no extra cost, and then renaming would work right (that is, if you rename a file to a watched directory, it'll be watched; otherwise it won't). So I'm going to work on this pull request for a bit longer...

So, as I reported here, any use of fs.watch on the Mac bears the risk of crashing the entire process if the target is deleted; wrapping it in fs.stat is not sufficient to make it safe.
As Michael said:

I would have just stuck with watchFile for now and let the windows users deal with whatever pains exist in watch until that API is ironed out.

I'm inclined to agree. fs.watch is the only option on Windows; it's not ready for use on the Mac yet. I think we should merge #1846 and push out 1.1.4 as a bugfix release soon.

It looks like the process crash has been fixed on Node master (thanks, @bnoordhuis), so assuming a 6.0.1 release in the near future, this fs.watch patch should be workable. The #1846 alternative is still appealing for other avoiding less serious fs.watch issues, and for compatibility with Node 0.4.x.

Merging since this is a clear and jashkenas-approved improvement on the current master. Falling back on fs.watchFile can be discussed as a separate issue.

@trevorburnham: push a commit to this pull that changes the required node version to >0.6.0 or whatever.

@michaelficarra Not sure if that's a good idea. We don't want npm to refuse to install the latest coffee-script package just because coffee -w won't work. Plenty of people have good reason to stay on 0.4.x for a little while longer.

@trevorburnham: how spectacularly will it fail for node 0.4.x users that try to use coffee -w? There should be a nice deprecation notice. "This feature is no longer compatible with your version of node. Upgrade to 0.6.1 or newer.".

@MichaelFicarra Yeah, good idea. Pushed 9633816d7a to master, which gives a warning like
The --watch feature depends on Node v0.6.0+.

So, an update on the state of directory-watching with fs.watch:
The only events fs.watch gives you when you watch a directory are renames, which you get whenever a file is created, deleted, or moved to/from the given directory. It doesn't give us file changes, or renames within subdirectories. Further, as the Node docs tell us:

Warning: Providing filename argument in the callback is not supported on every platform (currently it's only supported on Linux and Windows).

So on a Mac, watching a directory just gives your callback ('rename', null) any time something happens.
Is this useful? Well, we could do an fs.readdir every time a rename event is fired from the given directory to detect new files (which we weren't doing because of the performance implications of doing fs.readdir on a polling basis—see one of the first issues I raised, #365), but to solve #1853 with that approach as well, we'd have to watch the parent directory of each watched file for changes and respond appropriately.
This is all implementable, but it'd result in a watch function that's as big as the rest of command.coffee put together. Someone needs to build a Node library on top of fs.watch just to produce sensible file-watching behavior...


[Usage] RuntimeError: The size of tensor a (81) must match the size of tensor b (8) at non-singleton dimension 1

Describe the issue
Issue: RuntimeError: The size of tensor a (81) must match the size of tensor b (8) at non-singleton dimension 1
Command:
python -m llava.eval.run_llava --model-path liuhaotian/llava-v1.5-13b --image-file "https://llava-vl.github.io/static/images/view.jpg" --query "What are 3 objects in the image? Separate each object by a comma. Order largest to smallest. Exclude background. Format: object1, object2, object3."

Log:
Namespace(model_path='liuhaotian/llava-v1.5-13b', model_base=None, image_file='https://llava-vl.github.io/static/images/view.jpg', query='What are 3 objects in the image? Separate each object by a comma. Order largest to smallest. Exclude background. Format: object1, object2, object3.', conv_mode=None, sep=',', temperature=0.2, top_p=None, num_beams=1, max_new_tokens=512)
llava-v1.5-13b
You are using a model of type llava to instantiate a model of type llava_llama. This is not supported for all configurations of models and can yield errors.
Loading checkpoint shards: 100%|███████████████████████████████████████████████████████████████████████████████████████████████████████████████████████| 3/3 [00:16<00:00,  5.42s/it]
Traceback (most recent call last):
  File "/usr/lib/python3.10/runpy.py", line 196, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "/usr/lib/python3.10/runpy.py", line 86, in _run_code
    exec(code, run_globals)
  File "/root/research/suhail/LLaVA/llava/eval/run_llava.py", line 158, in <module>
    eval_model(args)
  File "/root/research/suhail/LLaVA/llava/eval/run_llava.py", line 129, in eval_model
    n_diff_input_output = (input_ids != output_ids[:, :input_token_len]).sum().item()
RuntimeError: The size of tensor a (81) must match the size of tensor b (8) at non-singleton dimension 1

Other info

Python 3.10.12

>>> transformers.__version__
'4.36.2'

Also curious about this warning:
You are using a model of type llava to instantiate a model of type llava_llama. This is not supported for all configurations of models and can yield errors.

I have the same issue  :(

I have the same issue

Sounds like @haotian-liu is aware!

Thanks for reporting! Can you check the current main branch fixes it?

Now fixed! Thanks.


Building with rollup and @rollup/plugin-commonjs breaks theme export

https://github.com/primer/components/blob/master/src/theme.js results in a ReferenceError when built with rollup and using @rollup/plugin-commonjs.
An MCVE is created here https://github.com/SaitamaSama/rollup-mcve
Steps to repro the said bug:

Clone the above repo git clone https://github.com/SaitamaSama/rollup-mcve
npm i
npx rollup -c -w
Open http://localhost:3000 in browser

Expected result
A button is mounted on the DOM.
Current Result:
ReferenceError: require is not defined

Some thing that seems to work instead of the require:
+import {colors, theme} from '@primer/components/lib/theme-preval';
-const themeExport = require('./theme-preval')
-const {theme, colors} = themeExport

Thanks for the heads up! We're doing a bunch of work on the theme right now and will keep this in mind!


Admin button on dropdown

Description of the new feature/enhancement
We could have a button or shortcut for opening a new window as admin since some tasks can only be done with authorization. Sometimes we need to change the terminal only for that specific task like installing things with choco (try "choco install gh").

I think this belongs to the series of issues like #1032

Thanks for the suggestion! This is gonna be covered by some combination #1032, #5000, #632, which is being worked on at the moment (see #7240).
/dup #632


Gradient DB site seems to be down

The link in README.md : https://hub-backend.getstorybook.io/redirect/storybook/0df99f9c-6d93-4766-a009-1f633aa91579?q=
seems to be down. I see a page with Application Error

Oh wow, it looks like storybook hub shut down 😢
Until I push it to an alternate host (like github pages), you can clone the repo and run yarn install ; yarn storybook. It'll load the demo page with all the gradients on it on localhost.

Cool, thanks.

@garetmckinley Any updates on this? It seems like the link mentioned in the README also is not working - https://0df99f9c-6d93-4766-a009-1f633aa91579.sbook.io/
Very curious to check out all the presets!


I don't think the Eterna, Quanta and Arcana Enchanting will ever be compatible with Quark Oddities Enchanting Matrix?

since the 2 mods has options to overhaul the vanilla enchanting mechanics they will never play nice with each other? I did see Forgecraft does have the 2 mods installed so I'm not sure if there were any feedback when it came to the changes

Apoth's enchanting module forcibly disables matrix enchanting if present, making it compatible would require the creation of a third merged system that supports both.


add CMAKE_C_FLAGS_RELEASE in specify_static_crt_flag

In CMakeLists.txt, add CMAKE_C_FLAGS_RELEASE in specify_static_crt_flag. So, when building Release using MSVC, the CRT flag is MT.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Looks good, if you sign the CLA we should be able to proceed with this, thanks!

Thanks! Would you mind signing the CLA so that we can merge this?

I am really sorry that I have singed the CLA just now.

Merging into 4.6.2 release branch and then master.


Not able to implement imbedded screenshots

Environment
- OS: Windows 10
- Node: 16
- cypress-mochawesome-reporter: 3.2.3
- cypress: 10

What happened?
I am trying to implement Mochawsome report to my Cypress 10 framework. I use cypress-mochawesome-reporter plugin and set it up regarding npm package instructions https://www.npmjs.com/package/cypress-mochawesome-reporter. But the problem is that the report is generated without imbedded screenshots despite of using embeddedScreenshots: true parameter in reporterOptions object. cypress/screenshots folder contains the necessary screenshots but they are missing in the report.
P.S. I have to add an important remark. Further investigation revealed that some screenshots are embedded, but a half of them are not. On the moment of publishing this report I used only 1 test to check if the plugin work at all and got a report without screenshot. Now I have a big number of tests: 81 tests total, 26 failed, and only 15 of them have screenshots. Screenshots folder contains images for all failed tests
Config file
module.exports = defineConfig({
    video: false,
    reporter: 'cypress-mochawesome-reporter',
    reporterOptions: {
        charts: true,
        reportPageTitle: 'mochawsome',
        embeddedScreenshots: true,
        inlineAssets: true,
        saveAllAttempts: false,
  },
  e2e: {
        experimentalStudio: true,
	experimentalSessionAndOrigin: true,
	chromeWebSecurity: false,
	setupNodeEvents(on, config) {
            require('cypress-mochawesome-reporter/plugin')(on);
	    return require('./cypress/plugins/index.js')(on, config)
	},
    },
})

Relevant log output
No response
Anything else?

Please create a repo with the problem and steps to reproduce the issue so I can have a look.
Thanks.


feat(pagination): Add CSS vars for $pagination

Signed-off-by: Isabelle Chanclou<EMAIL_ADDRESS>Add CSS vars in Pagination component.

LGTM, few questions to answer before merging

What's the status of this PR. Approved on your side @louismaximepiton?

Yup the PR is fine to me, but we need to propose some changes to Bs directly, since some replaced variables still exist in Bootstrap with Sass only.


lnd_test: give peers more time to successfully attempt connection

We might hit a connection refused error in cases where the peer connects
to us exactly as we try to connect to it. We retry the connection within
a wait predicat, as it should be the case that the other peer
establishes the connection, and the two peers actually connects.
Should resolve the flake
   --- FAIL: TestLightningNetworkDaemon/data_loss_protection (12.68s)
        lnd_test.go:99: Failed: (data loss protection): exited with error:
            *errors.errorString unable to connect Dave to carol: rpc error: code = Unknown desc = dial tcp <IP_ADDRESS>:19799: connect: connection refused
            /home/travis/gopath/src/github.com/lightningnetwork/lnd/lntest/itest/lnd_test.go:8239 (0xd4e2c3)
            	testDataLossProtection.func1: t.Fatalf("unable to connect %v to carol: %v",
            /home/travis/gopath/src/github.com/lightningnetwork/lnd/lntest/itest/lnd_test.go:8385 (0xd1afe6)
            	testDataLossProtection: restartDave, _, daveStartingBalance, err := timeTravel(dave)
            /home/travis/gopath/src/github.com/lightningnetwork/lnd/lntest/itest/lnd_test.go:123 (0xced56a)
            	(*harnessTest).RunTestCase: testCase.test(h.lndHarness, h)
            /home/travis/gopath/src/github.com/lightningnetwork/lnd/lntest/itest/lnd_test.go:14533 (0xd55e8c)
            	TestLightningNetworkDaemon.func4: ht.RunTestCase(testCase)
            /home/travis/.gimme/versions/go1.13.linux.amd64/src/testing/testing.go:909 (0x509a19)
            	tRunner: fn(t)
            /home/travis/.gimme/versions/go1.13.linux.amd64/src/runtime/asm_amd64.s:1357 (0x460e81)
            	goexit: BYTE	$0x90	// NOP
FAIL
FAIL	github.com/lightningnetwork/lnd/lntest/itest	993.451s

Interesting linter failure:

lntest/harness.go:440:10: lostcancel: the cancel function returned by context.WithTimeout should be called, not discarded, to avoid a context leak (govet)
ctxt, _ = context.WithTimeout(ctx, 15*time.Second)

lntest/harness.go:440:10: lostcancel: the cancel function returned by context.WithTimeout should be called, not discarded, to avoid a context leak (govet)
512			ctxt, _ = context.WithTimeout(ctx, 15*time.Second)


Exception due to KeyError missing text

What bug did you encounter?
At the scene with the client Stacy and Lucy's, when agreeing to the shorter deadline, the exception as described in additional notes occurs.
I am running version 1.5 under Manjaro Linux.
Steps to Reproduce
Select at that step "Sure. I've been getting more comfortable in my duties here. ..."
Then the exception with the KeyError missing text? occurs.
Screenshots
No response
Additional Information
[code]
I'm sorry, but an uncaught exception occurred.

While running game code:
  File "game/script.rpy", line 2047, in script call
    call v2_routine from _call_v2_routine
  File "game/scripts/labels/day_activity_choices.rpy", line 490, in script call
    python:
  File "game/scripts/labels/v2_story.rpy", line 58, in script call
    call v2_working_late_sad_path from _call_v2_working_late_sad_path_2
  File "game/scripts/labels/v2_story.rpy", line 64, in script
    oliver @ smile "Just let me know if you have any questions. I'll shoot you the information on the project when [missing text?]"
KeyError: 'missing text?'

-- Full Traceback ------------------------------------------------------------

Full traceback:
  File "game/script.rpy", line 2047, in script call
    call v2_routine from _call_v2_routine
  File "game/scripts/labels/day_activity_choices.rpy", line 490, in script call
    python:
  File "game/scripts/labels/v2_story.rpy", line 58, in script call
    call v2_working_late_sad_path from _call_v2_working_late_sad_path_2
  File "game/scripts/labels/v2_story.rpy", line 64, in script
    oliver @ smile "Just let me know if you have any questions. I'll shoot you the information on the project when [missing text?]"
  File "/home/johannes/game/LearnToCodeRPG-1.5-linux/renpy/ast.py", line 921, in execute
    renpy.exports.say(who, what, *args, **kwargs)
  File "/home/johannes/game/LearnToCodeRPG-1.5-linux/renpy/exports.py", line 1373, in say
    who(what, *args, **kwargs)
  File "/home/johannes/game/LearnToCodeRPG-1.5-linux/renpy/character.py", line 1253, in __call__
    what = self.prefix_suffix("what", self.what_prefix, what, self.what_suffix)
  File "/home/johannes/game/LearnToCodeRPG-1.5-linux/renpy/character.py", line 1172, in prefix_suffix
    return (sub(prefix) + sub(body) + sub(suffix))
  File "/home/johannes/game/LearnToCodeRPG-1.5-linux/renpy/character.py", line 1152, in sub
    return renpy.substitutions.substitute(s, scope=scope, force=force, translate=translate)[0]
  File "/home/johannes/game/LearnToCodeRPG-1.5-linux/renpy/substitutions.py", line 278, in substitute
    s = formatter.vformat(s, (), kwargs) # type: ignore
  File "/home/tom/ab/renpy-build/tmp/install.linux-x86_64/lib/python3.9/string.py", line 165, in vformat
  File "/home/tom/ab/renpy-build/tmp/install.linux-x86_64/lib/python3.9/string.py", line 205, in _vformat
  File "/home/johannes/game/LearnToCodeRPG-1.5-linux/renpy/substitutions.py", line 168, in get_field
    obj, arg_used = super(Formatter, self).get_field(field_name, args, kwargs)
  File "/home/tom/ab/renpy-build/tmp/install.linux-x86_64/lib/python3.9/string.py", line 270, in get_field
  File "/home/tom/ab/renpy-build/tmp/install.linux-x86_64/lib/python3.9/string.py", line 227, in get_value
KeyError: 'missing text?'

Linux-6.0.15-1-MANJARO-x86_64-with-glibc2.36 x86_64
Ren'Py <IP_ADDRESS>90809
Learn to Code RPG 1.5
Tue Jan  3 12:54:30 2023
[/code]

https://www.renpy.org/doc/html/text.html
I can at least see why. It's literal missing text. There's supposed to be a name variable from the global store I believe or maybe an issue occurred when generating the translations. Regardless the [missing text] needs to be replaced. Very good eye.
https://github.com/freeCodeCamp/LearnToCodeRPG/blob/38c8c8e868ae830945832d275d7b483967fb4c6d/game/scripts/labels/v2_story.rpy#L64


Get it to work on Windows

Need to compile libraries used by server for Windows and make a VS2017 project, fixing any platform errors that arise. Better yet, use cmake to generate the project files.

Fixed with commit https://github.com/vexyl/MCHawk/commit/2f57b3ab750310da61cd9f22bf63c71b7bb79510.