Clean up dependencies and setup instructions

This PR separates packages that are needed for running tests (notebook tests in particular) from the dependencies actually needed to import gpflow, updates the tensorflow and tfp dependencies to the latest stable releases (tf 2.0, tfp 0.8), and updates the README accordingly.

@awav  do the CircleCI tests still need to be based on top of the personal Docker image you built, or can we simply reuse a standard ubuntu / python base image that someone else is providing, now that tensorflow 2 is released and easily installable via pip ?

@awav do the CircleCI tests still need to be based on top of the personal Docker image you built, or can we simply reuse a standard ubuntu / python base image that someone else is providing, now that tensorflow 2 is released and easily installable via pip ?


Improve isort compatibility with black

Add ensure_newline_before_comments, see:
https://black.readthedocs.io/en/stable/compatible_configs.html#configuration
To trigger the rule, add a comment before some import.

Well, in any case, it's an enhancement. 🤷🏼♂


C023 fix rust versioning

Can you provide some explanation for what this is fixing?

@aludvik Every time a rust package is built, it's versioned with the version number from the Cargo.toml file. This is undesirable. This PR modifies the installed Dockerfiles for the rust components so that packages are versioned with the output of bin/get_version, matching the rest of the packages.


Update Upgrader interface comments to include expected system state.

Capture discussion on PR #2185 to update javadoc comments.
Doc update only - contains no code changes.

@EdColeman you read my mind with these comments and beat me to the punch. :1st_place_medal:  Thanks for getting these in.


Replace deprecated ATOMIC__INIT by Atomic::new

This will break the build on older compilers.

Ok, close then?

Yeah


Passing in token via GraphiQL

So I got as far as getting an auth token after login. But when I create a post via GraphiQL, how do I pass in that token?

There is a graphiql fork somewhere that gives you richer experience by offering you presets (for any queries/mutations/variables you want to keep in that preset) as well as attaching authentication. I forget where it is, please have a look for any electron-based graphiql or related google chrome apps. The particular one I'm mentioning exists somewhere on github here. I will edit this issue when I come across it as I will be going down the same path soon.

I use this one https://github.com/skevy/graphiql-app and you can add the authorization header with the JWT you get from the login mutation

Ok awesome! Can you please add it to the Readme?

I've decided to take your work to its eventual aim and will produce a version that references your work, so all good now. Thanks for leading the way on this @swarthout !


Expose JSON functionality

This is some work towards #3.

Also this probably belongs in ekg-core instead.

I'd actually like to move the JSON functionality into ekg-json to make it reusable without depending on ekg proper. I'd like to look into this soon.

I agree. It would be nice to have an instances for FromJSON as well. Another thing I noticed is, that there is no nice way to define an instances for Sample, as it is only a type synomym.


add osx support

So, from your PR, the only difference between linux and darwin shell is one line, on linux:
const ioctlReadTermios = syscall.TCGETS

and on darwin:
const ioctlReadTermios = syscall.TIOCGETA

Is this PR a WIP or do you wanted to just show me the tested version that works on osx?

yes that is the only difference. it is up to you what to do. i tested the change and it works.

@Eiffel-Alpine, I incorporated your changes and added you to changelog https://github.com/ai-traders/dojo/releases/tag/0.3.2. From now on, Dojo will be cross compiled and there will be two binaries released: one for Linux and one for Darwin.


How about we stop deprecating everything every other release....

I can't believe how terrible the experience is using these tools.
It seems the whole process is playing jigsaw puzzle games trying to line up all the versions so that something, anything works.
We are sorry but your original working tensorflow code for training is being moved to generic tf.slim for generic training.
We are sorry but your changed code using generic tf.slim was not specific enough, make these changes.
We are sorry but after having you do all this, tf.slim is moving to contrib.
Okay, now contrib is going away and here is a basic script that will just tell you cannot change anything for you, code it all again yourself. All 3rd party guides are now worthless.
(Roughly after about a year of this, I realized what a waste of time and left tensorflow)
Now I'm back only to try to get other frameworks (which work) models converted to tflite since it's the only decent solution for performance on mobile.
Of course the tools to convert to tf-lite require a bunch of tensorflow things to be installed again.
Oops, I'm using Cuda 10.1, watch pip packages try opening libcudart-9.
Install tensorflow 2.x from source for cuda 10.1, whoops it wants newer python now.
Install tensorflow addons, BOOM it doesn't support tensorflow 2.4.0.
Backdate to tensorflow 2.1, rebuild everything.
Install tensorflow addons, BOOM it doesn't support tensorflow <2.2.0.
I know this will just get closed and someone will mention that I'm wrong for being a Gentoo user who expects to build from source and not limp off of a packaging system to fix a project that cannot properly figure out how to handle backwards compatibility. Nor will I use some "docker" container....
Do you need some help coding? Is this intentional lock-in related movement to keep everyone rewriting things? Can you stop deprecating things long enough for someone to actually build something longer than a year and have it work when they are done? Thanks.

Comment previously posted on Tensorflow/addons, but I deprecated it to get it over here ;)

I think it is a duplicate of https://github.com/tensorflow/tensorflow/issues/43302

Here's some more...
Converting a yolov3 model to TFLITE to run on a phone.
Tried 4 different projects.
1st: All code worked until needing slim from tf.contrib. Didn't want to rewrite their code.
2nd: needed onnx and tensorflow_addons but it doesn't work with tensorflow 1.x. Older pip package for tensorflow_addons with 1.x support is now removed so it cannot be done.
3rd: Go all the way through, it spit out tflite files that I then mapped into my android project. java.lang.IllegalStateException: This model does not contain associated files, and is not a Zip file.
You'd think that means it would be the right format.... nope TFLITE has various "metadata" and looks like mine is missing it.
java.lang.IllegalStateException: This model does not contain associated files, and is not a Zip file.
Stuck again. My tflite in a binary editor looks similar but has "TOCO Converted" where the example tflite for android shows "TFLITE_METADATA".
Just documenting the various ways I get stuck here, since I need a big collection to get enough ammo to make the case to management  for using something else.

@acidtonic Thank you for your feedback and apologies for the inconvenience.
tf.contrib module was a collection of modules contributed by external users as well as internal resources and it was a big challenge to maintain all of it along with TF 2 upgrades.
So we wanted to apply a divide and conquer approach where part of it is consumed in TF Core, another part where we have designated owners and some portions deprecated which were less popular and no one claimed ownership.
As a result we have TF Addons (works with TF 2.X) where we have revived popular modules of tf.contrib and also provides a place where users can request to add new functionality as well.
When using TF Addons it can be a good idea to familiarize yourself with python op compatibility with various TF versions. See https://github.com/tensorflow/addons#python-op-compatility
Lot of our developers prefer having support for the latest CUDA versions and sadly, CUDA is not backward compatible so some of the moves are breaking. As you can imagine it would create too many branches/forks to support several versions at once, which can be very resource intensive.
We appreciate your feedback and are committed to enhance TensorFlow significantly and provide a better user experience.


Environment variables NOT available in static builds

Prior code means variables are not available when statically built and/or deployed to Netlify or Vercel.
What kind of change does this PR introduce?
Fixes npm run build error that environment variables are not available.
What is the current behavior?
“supabaseUrl is required” error message when deploying statically.
What is the new behavior?
Error is gone, supabase works in dev and production, server-side and client-side as advertised.
Additional context
Add any other context or screenshots.

If we want static to be the default for env variables we should update all examples and maybe also the docs.
https://github.com/supabase/auth-helpers/blob/main/packages/sveltekit/README.md#supabaseclient-setup

We decided to not change the way we load env variables by default. You can always change it to your likings.


Closes #1345 project forms

This fix has global visual regression implications. Will tag in #1345 that we need a thorough pass through the site to make sure other select2 widgets look OK


Rename domain www.facebook.com to web.facebook.com

for changes the facebook, this minimal change, is solution problem, when execute getUserID.

Unless there are objections, let's go with the approach I suggested here? https://github.com/Schmavery/facebook-chat-api/issues/632#issuecomment-377293267

@Schmavery @ravkr  I would have to see how many redirects there may be

Thanks for investigating this issue @Theblood. I'm going to close this as the fix here won't work for everyone, let's keep discussing the solution in #632 if necessary.


chore: add "tembleking" as maintainer in "sysdig-secure" plugin

Link to GitHub repository
https://github.com/jenkinsci/sysdig-secure-plugin
When modifying release permission
List the GitHub usernames of the users who should have commit permissions below:

@marcuzzuu
@airadier

This is needed in order to cut releases of the plugin or component.
If you are modifying the release permission of your plugin or component, fill out the following checklist:

### Release permission checklist (for submitters)
- [x] The usernames of the users added to the "developers" section in the .yml file are the same the users use to log in to [accounts.jenkins.io](https://accounts.jenkins.io/).
- [x] All users added have logged in to [Artifactory](https://repo.jenkins-ci.org/) and [Jira](https://issues.jenkins.io/) once.
- [x] I have mentioned an [existing team member](https://github.com/orgs/jenkinsci/teams) of the plugin or component team to approve this request.

Hi @timja sorry to bug you, but I saw you reviewing other PRs merged today in here. Can you please approve this one, or tell us what we need to do in order to get this one merged? Thanks!

Just needed a green build, when I checked a couple of times earlier it was failing.


Support Databricks 3.1.1 in new build profiles

This unfortunately required a bunch more copy of files.
relates to https://github.com/NVIDIA/spark-rapids/issues/3224

Copy files just for existing shim layer for both 301db and 311db.
Needed to move the Pandas files into shim layer due to databricks differences
A few other functions needed new shim interfaces
A few places ShuffleQueryStageExec and others use different parameter numbers so made checks more generic
Installed a lot more databricks jars into the .m2 and updated pom dependencies to use those jars rather then the spark 3.x ones and pom file.  Note we don't have their pom files so dependencies aren't pulled directly. Currently thi si sonly for databricks 3.1.1, 3.0.1 databricks will be done separately.
removed 301emr from build since we don't test it, I can pull this out if people want.
Added TaskContextTrampoline in databricks 3.0.1 to be able to get to the memory manager. 3.1.1 has that api public.

build

running build looks like some shim change went in, I need update

actually it looks like the change didn't update the databricks shim

build

build

Updated and reran builds on databricks and apache.
I rechecked the databricks built jar with this for default build vs existing build and only differences are due to removed spark311 shim files and moved Pandas files.

build

build

error on tearing down one of the tests, trying to reproduce to see if related to this or something happened during build:

_ ERROR at teardown of test_write_sql_save_table

build


Introduce macOS 13 runner with iOS 17

Run tests on iOS 17 in CI.

@bfollington LGTM. One question: you mentioned this test runner seems to take much longer than the v16 one. Is this something that should cause concern, or just inconvenient?

@gordonbrander both.... I don't think there's anything we can do but it's going to be frustrating for development. It's tolerable though.


Bug: Does not block access when inside a Ward

Please add a config option to respect wards and prevent access when inside a Ward that the player does not have permission for.
Great job btw!  All the other stuff we talked about seems to work great! :)
Are you on Discord?

I thought table access was already restricted. I will add that options.

It does say "no access" but the keypress still makes the static map draw and flashes something really fast on the screen that I can't see and freezes for a second so it feels like it's drawing the map.  When interacting with the interactive area to view the map it just shows the interactive map even though the tooltip says no access.  (I use the reversed logic and the "read map" portion if that makes a difference)

Ah I got it. Will fix

Fixed in 1.1.3

Getting error when it loads.  I sent you details on discord.


Add possibility to include a data attribute to text element.

I want to be able to scale text with css to offset text scaling together with the svg.
Ex, svg width=1000 and fontSize=16, if this svg then has a width: 100% with css on it, the text will be super small if the svg container scales down on for ex mobile devices.
With this we can now choose to add a data attribute to the text node which can be selected in css. This enables us to target different text nodes in the svg to apply different styling on different nodes.
A really nice example is using container query units to offset the scaling text with css only. Then we can just do something like this with the cqi unit.
.plotcontainer text[data-name="my-regular-text"] {
    font-size: calc(2rem - 1.85cqi);
}

.plotcontainer text[data-name="my-large-text"] {
    font-size: calc(8rem - 2cqi);
}

I would prefer to solve this at the base Mark level rather than being specific to the Text mark.
Could you use a class name #1002 or the existing ariaLabel or ariaDescription options to target the elements instead? Seems like that would already work.
Regarding data attributes, would you want these to be channels (varying on each instance of a mark), or just constant? It sounds like a constant would be sufficient here, and simpler. If a channel, we would have to declare it and initialize it in the constructor.

You're right, className is probably a better way to go for this.
Regarding channels or not, im not super clear on this at the moment, so far i've only had use cases where it would not have been necessary.


Add transaction log button functionality

Add the functionality of adding/deleting transactions to the buttons from #36
Depends on #36 and #34

Does this open up a form to add a transaction?

Tasks:

Reflect changes from adding and deleting transaction to transaction log component. (Backend?)
UI for adding and delete transaction interface. (component?)
UI for transactions appearing in transaction log component. (component?)

I think this task can be split into 3 like this if that makes it easier to work with.

This is done. https://github.com/Taks0708/SOFTENG310-FinTrack/pull/93


app crash

Hello everyone
my app crash when i validate picture or video that i record .
i make adb logcat and it show me this error :
ReactInstanceManager.ctor()
can someone plz help me to fix it

Facing same issue once image is selected app crashes.

I have a similar issue with the lasts releases; this solved for me:
check the imports; if you have:
import { showImagePicker } from 'react-native-image-picker';
changed the import import RNImagePicker from 'react-native-image-picker';
and implement in this way: RNImagePicker.showImagePicker(options, (response) => {})

I am using below code with react native version
"react": "16.9.0",
"react-native": "0.61.2",
import ImagePicker from 'react-native-image-picker';

// More info on all the options is below in the API Reference... just some common use cases shown here
const options = {
  title: 'Select Avatar',
  customButtons: [{ name: 'fb', title: 'Choose Photo from Facebook' }],
  storageOptions: {
    skipBackup: true,
    path: 'images',
  },
};

/**
 * The first arg is the options object for customization (it can also be null or omitted for default options),
 * The second arg is the callback which sends object: response (more info in the API Reference)
 */
ImagePicker.showImagePicker(options, (response) => {
  console.log('Response = ', response);

  if (response.didCancel) {
    console.log('User cancelled image picker');
  } else if (response.error) {
    console.log('ImagePicker Error: ', response.error);
  } else if (response.customButton) {
    console.log('User tapped custom button: ', response.customButton);
  } else {
    const source = { uri: response.uri };

    // You can also display the image using data:
    // const source = { uri: 'data:image/jpeg;base64,' + response.data };

    this.setState({
      avatarSource: source,
    });
  }
});

App crashes after selecting image and getting response.

@pawanvivekananda did you find any solution?

App crashes after selecting image and getting response.

any solution?

Add the missing permissions to your plist file. Info here.

Any solution ?

I think androidx creating this issue any update on that ?

Having this same issue again on an emulator and also on real device. No exceptions thrown.

Facing the same issue as soon as I select an image to upload the app crashes without giving any errors, but it's displaying the response in the console. I also tried using react-native-image-crop-picker, but it too made the app crash on image upload. I was first running the app using the command "npx react-native run-android". And when the app crashed it was only showing the response of the uploaded image. But then I switched to Android Studio and built the app from there and as soon as I uploaded the image the following error was displayed in the logcat-
{ height: 200,
width: 92,
type: 'image/jpeg',
fileName: 'rn_image_picker_lib_temp_54c4dc23-202f-45a0-94da-1b05f313f8ed.jpg',
fileSize: 13008,
uri: 'file:///data/user/0/com.abc/cache/rn_image_picker_lib_temp_54c4dc23-202f-45a0-94da-1b05f313f8ed.jpg' }
2021-03-26 19:44:46.889 7469-7469/com.abc E/AndroidRuntime: FATAL EXCEPTION: main
Process: com.abc, PID: 7469
java.lang.RuntimeException: Failure delivering result ResultInfo{who=null, request=13002, result=-1, data=Intent { dat=content://media/external/images/media/168402 flg=0x1 (has extras) }} to activity {com.abc/com.abc.MainActivity}: java.lang.NullPointerException: Attempt to invoke interface method 'void com.facebook.react.bridge.Callback.invoke(java.lang.Object[])' on a null object reference
at android.app.ActivityThread.deliverResults(ActivityThread.java:5078)
at android.app.ActivityThread.handleSendResult(ActivityThread.java:5120)
at android.app.servertransaction.ActivityResultItem.execute(ActivityResultItem.java:49)
at android.app.servertransaction.TransactionExecutor.executeCallbacks(TransactionExecutor.java:108)
at android.app.servertransaction.TransactionExecutor.execute(TransactionExecutor.java:68)
at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2199)
at android.os.Handler.dispatchMessage(Handler.java:112)
at android.os.Looper.loop(Looper.java:216)
at android.app.ActivityThread.main(ActivityThread.java:7625)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:524)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:987)
Caused by: java.lang.NullPointerException: Attempt to invoke interface method 'void com.facebook.react.bridge.Callback.invoke(java.lang.Object[])' on a null object reference
at com.reactlibrary.RNPgReactNativeSdkModule$1.onActivityResult(RNPgReactNativeSdkModule.java:157)
at com.facebook.react.bridge.ReactContext.onActivityResult(ReactContext.java:308)
at com.facebook.react.ReactInstanceManager.onActivityResult(ReactInstanceManager.java:758)
at com.facebook.react.ReactDelegate.onActivityResult(ReactDelegate.java:90)
at com.facebook.react.ReactActivityDelegate.onActivityResult(ReactActivityDelegate.java:112)
at com.facebook.react.ReactActivity.onActivityResult(ReactActivity.java:68)
at android.app.Activity.dispatchActivityResult(Activity.java:7797)
at android.app.ActivityThread.deliverResults(ActivityThread.java:5071)
at android.app.ActivityThread.handleSendResult(ActivityThread.java:5120)
at android.app.servertransaction.ActivityResultItem.execute(ActivityResultItem.java:49)
at android.app.servertransaction.TransactionExecutor.executeCallbacks(TransactionExecutor.java:108)
at android.app.servertransaction.TransactionExecutor.execute(TransactionExecutor.java:68)
at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2199)
at android.os.Handler.dispatchMessage(Handler.java:112)
at android.os.Looper.loop(Looper.java:216)
at android.app.ActivityThread.main(ActivityThread.java:7625)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:524)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:987)
2021-03-26 19:44:46.892 7469-7469/com.abc D/e: CrashLogs : {"ts":"2021-03-26 19:44:46","app_id":"UNKNOWN","package":"UNKNOWN","android_id":"UNKNOWN","platform":"Linux","os_version":"28","device_model":"COR-AL00","device_name":"HONOR","sdk_version":"1.6.0","network_type":"UNKNOWN","stack":"com.reactlibrary.RNPgReactNativeSdkModule$1.onActivityResult(RNPgReactNativeSdkModule.java:157)","cause":"java.lang.NullPointerException: Attempt to invoke interface method 'void com.facebook.react.bridge.Callback.invoke(java.lang.Object[])' on a null object reference"}

We have the same exact issue:

empty React Native project
react-native-image-picker latest

App crashes after selecting an image.
Any updates on this?

Add the missing permissions to your plist file. Info here.
If you are having issues on Android, add to the AndroidManifest.xml:
<uses-permission android:name="android.permission.READ_EXTERNAL_STORAGE" />
<uses-permission android:name="android.permission.WRITE_EXTERNAL_STORAGE" />
<uses-permission android:name="android.permission.CAMERA" />
<uses-feature android:name="android.hardware.camera" />
<uses-feature android:name="android.hardware.camera.autofocus" />

This works for me

try this solution :
https://lifesaver.codes/answer/android-app-crashes-automatically-when-opened-1122

try this solution : https://lifesaver.codes/answer/android-app-crashes-automatically-when-opened-1122

The given link is not working. Can you share any other link for the solution or the solution itself please?

4 years since this was posted, anyone have a solution? Still experiencing this myself...
"react-native-image-picker": "4.10.1",
"react-native": "0.72.1",

Add quality: 0.1      includeBase64: true,
and test app replay
const response = await launchImageLibrary({
mediaType: "photo",
selectionLimit: 1,
quality: 0.1,
includeBase64: true,
});

Someone has found any solution?

Someone has found any solution?

Not a solution, but what I believe is the cause.
From my attempts to get this to work, this seems to be caused by the library opening the camera as a separate activity, the phones OS then see's that the React Native activity is idle and kills it to manage memory, so when you accept the image and try to get sent back, there is nothing to be sent back to, or it sends you back to refreshed app as if it was freshly opened, due to restarting of the activity (example below). From my experience this doesn't happen on all phones or consistently, which makes it even more annoying as you're at the mercy of the OS.
To prevent an outright crash of the app, change the line in MainActivity.java from:
super.onCreate(savedInstanceState);

to
super.onCreate(null);

onCreate

I already have this line.
Specifically what happens is that when the selected file is big (specifically happens with the large videos) the app shows the "not working app" message and asks to wait for it to work or to close it, but right after it appears the launchImageLibrary responds and the message closes itself. However if the message appears after the response, even when you tell it to wait and the app functions correctly, the message keeps showing until you select to close it.


Refactor filesystem data source

This is in preparation of returning content/attributes wrapped in a LazyValue. See #794.

Probably still a work in progress, but has made enough progress to be merged.


Traverse directory structure up to add parent node_modules paths.

Add node-modules/.bin of parent directories as well. This works for my monorepo setups as well as nested packages.
refs #8

Thanks!


WEBSITE SUGGESTION

Add popups to the website so that you can advertise products to people!

Pissandshittium merchandises

also shouldn't this go to the website repo

infinite money glitch


Update config.json to match new specification

This addresses #46. I've taken as much data as possible from the Common Lisp track for the topics, added the missing ones and adjusted the difficulty estimates to the example solutions.

Thanks for this contribution @wasamasa! Good call pulling from the common lisp track!


victoriametrics: 1.80.0 -> 1.81.0

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/VictoriaMetrics/VictoriaMetrics/releases.
meta.description for victoriametrics is: "fast, cost-effective and scalable time series database, long-term remote storage for Prometheus"
meta.homepage for victoriametrics is: "https://victoriametrics.com/"
meta.changelog for victoriametrics is: "https://github.com/VictoriaMetrics/VictoriaMetrics/releases/tag/v1.81.0"
Updates performed

Golang update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 1.81.0 with grep in /nix/store/cb1xwl38mz99gwaz2b80rhyqixxz39pn-VictoriaMetrics-1.81.0
found 1.81.0 in filename of file in /nix/store/cb1xwl38mz99gwaz2b80rhyqixxz39pn-VictoriaMetrics-1.81.0

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
victoriametrics

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/cb1xwl38mz99gwaz2b80rhyqixxz39pn-VictoriaMetrics-1.81.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A victoriametrics https://github.com/r-ryantm/nixpkgs/archive/bb373da6577c802c66510ca5ecd41e8ba294831a.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/cb1xwl38mz99gwaz2b80rhyqixxz39pn-VictoriaMetrics-1.81.0
ls -la /nix/store/cb1xwl38mz99gwaz2b80rhyqixxz39pn-VictoriaMetrics-1.81.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

victoriametrics

Maintainer pings
cc @yorickvP @ivan for testing.

Result of nixpkgs-review pr 189202 run on x86_64-linux 1

1 package built:

victoriametrics

Result of nixpkgs-review pr 189202 run on x86_64-linux 1

1 test built:

nixosTests.victoriametrics


fix invalid path on windows

I'm windows users, when I clone repo, I have a problem with folder name,  it has a space at the end, and raise a error invalid path.  I deleted it and everything works fine.

Thanks for your help!


feat(sdk): use ky instead of axios

Axios is based on old XMLHttpRequests, Ky is based on new fetch API

Maybe just do this which allows to use any SDK : https://github.com/nfroidure/openapi-ts-sdk-builder/issues/10 ?


[DO-NOT-MERGE] Revert everything since 4bde149

Jira Ticket: https://broadworkbench.atlassian.net/browse/[Ticket #]

Summary of changes:

What

Why

Testing strategy

[ ]

This is for tesing only, no reviews needed.


[Suggestion] Consider using BlazorDependencies

@RemiBou Recently I have created small library that simplify Razor Class Library dependency management
https://github.com/redradist/BlazorDependencies
https://medium.com/@redradist/blazor-dependencies-d5597d07ebef
Using it user may not to manually add all script dependencies to index.hmtl ;)

At first I included the scripts.js as a resource and then called eval on it, but it caused some problem.
The documented way to include those resources is to use script tag, the user can also bundle the scripts with its other tools like webpack, I think it's not a big deal and I want to keep the dependencies level to the minimum, so we'll keep it as is.
But people can use your lib with BrowserInterop anyway.

At first I included the scripts.js as a resource and then called eval on it, but it caused some problem.
The documented way to include those resources is to use script tag, the user can also bundle the scripts with its other tools like webpack, I think it's not a big deal and I want to keep the dependencies level to the minimum, so we'll keep it as is.
But people can use your lib with BrowserInterop anyway.

But using https://github.com/redradist/BlazorDependencies you are not enforce users to use only BlazorDependencies
User will be able to add script directly or to specify in blazorDeps.json:
[
  {
    "type": "Razor Class Library",
    "name": "BrowserInterop"
  }
]

Nobody enforce users to use BlazorDependencies, it is just convenient option ;)


Color filetype icons

This PR addresses #221. It adds colour (provided by nvim-devicons) to the filetype component's icon.
Before:

After:

Is this option works now?
I even tried to specify it explicitly, but have icons without colors:

Here is my configuration.
It have colors in other plugins that use nvim-web-devicons.


New planet causes error

2018-06-23 16:59:55 | Getting player info...
2018-06-23 16:59:55 | Scanning for planets...
Player Level: 0it [00:00, ?it/s]   Traceback (most recent call last):
  File "cheat.py", line 379, in <module>
    planets = game.get_uncaptured_planets()
  File "cheat.py", line 234, in get_uncaptured_planets
    key=lambda x: x['sort_key'],
  File "cheat.py", line 232, in <genexpr>
    return sorted((game.get_planet(p['id']) for p in planets if not p['state']['captured']),
  File "cheat.py", line 185, in get_planet
    key=lambda x: x['zone_position'])
  File "cheat.py", line 183, in <genexpr>
    and z['capture_progress'] < 0.95)),
KeyError: 'capture_progress'

Fixed by https://github.com/SteamDatabase/SalienCheat/commit/7fb2ccfe8e0236d4a6d5729e844b82022fcc4216


Cargo: set LTO option to false == thin-local

Gentoo ebuild of Rust 1.70 started showing different behavior w.r.t. LTO. That makes builds fail like:
rustc: .../InstructionPrecedenceTracking.cpp:97:
void llvm::InstructionPrecedenceTracking::validate(const
llvm::BasicBlock*) const: Assertion `It->second == nullptr && "Block is
marked as having special instructions but in fact it  has " "none!"'
failed.
error: could not compile `update-ssh-keys` (bin "update-ssh-keys")

Changing lto = true to lto = false (a.k.a. "thin-local") in Cargo.toml makes the build failure disappear.

FYI, the CI failure has nothing to do with changes in this PR.
It is a typical can of worms.
All python code was written in python2, which does not exist in distros in these days. Maybe rewrite the code in python3?


Handle multi instances properly

When running multiple instances, it would be great if Momo would ensure only one of those instances schedules any jobs.
Current implementation: All instances will simultaneously try to schedule all jobs (they have all timers started internally). That's a huge amount of overhead and leads to quite a high probability of race conditions, so scheduling jobs multiple times where you actually wanted to run it only once. There's two checks to prevent this currently - one in the Scheduler and one in the Repository. What I am proposing is solving this in a way that all instances are not even trying it, but only one master instance.
How could this work:

Some instances start simultaneously.
Each of them starts a timer to check for the one active scheduler.
This check happens by looking in the database looking for a record containing the active instance. This record contains a schedulerId and a timestamp.
If they find such a record and the timestamp is smaller than a given timeout interval, they do nothing except of checking again in some seconds.
If they don't find such a record, they set themselves as active (at best atomic, otherwise something like double checked locking?) and schedule all jobs
While being active, the active record needs to be updated every few seconds, so other schedulers won't consider themselves as active
If the active scheduler finds itself not being active anymore, it cleans up. This usually won't happen, as the instance will be dead then.

Benefit:

Only one instance is active ever. So no race conditions.
Less overhead, as only once instance is keeping all the timers.
Easier to understand, as the whole scheduling code is meant to be executed only once at the same time. There is one global check to see whether you are active or not.

What do you think?

I agree that this should be the default behaviour.
Executions already have something similar with a scheduleId/timestamp and a timeout mechanic. I have to refresh my understanding there, but we might be able to use those already existing fields for the functionality you describe.


point-to-point network check: use tls dialer

Using the check-endpoints tool results in log spam when the endpoint uses tls.
The golang tls implementation cannot handle a clean close (tcp close notify) without first completing the tls handshake. Simply using the tls dialer (set to not verify server certs) over comes this issue.
If the server is also set to require a client cert, a client cert must be provided. This can't be just any self-signed cert (even if no verification will be performed) since the server will indicate which signers it supports and a well behaved tls client will not send a client cert that does not have a chain leading to a supported signer.

We want new tcp connections for each ping, don't we? How expensive are those if we use tls? My gut feeling is that 10ish per second don't harm. But be aware that tls costs.

/retest

/test e2e-aws-operator
/test e2e-aws-upgrade

/test e2e-aws-upgrade

/lgtm
here's to less log spam
@sanchezl does this also fix the logspam in openshift-apiserver?

etcd appreciates your efforts, thank you.
https://storage.googleapis.com/origin-ci-test/pr-logs/pull/openshift_cluster-kube-apiserver-operator/901/pull-ci-openshift-cluster-kube-apiserver-operator-master-e2e-aws/1283207912335872000/artifacts/e2e-aws/gather-extra/pods/openshift-etcd_etcd-ip-10-0-140-75.us-west-1.compute.internal_etcd.log

@sanchezl does this also fix the logspam in openshift-apiserver?

@deads2k yes, the tls handshake fixes openshift-apiserver, tls handshake + client cert fixes etcd.

/lgtm

/retitle Bug 1855284: point-to-point network check: use tls dialer


User can configure the default appmap filter

Currently, we have default filter settings for the appmap, but they are not configurable by the user. It would be better if the user could change them to suit their needs.
We want to add options to the VS Code settings, so that filter options would appear in this menu:

User feedback:
Hi, thanks for considering my input! Unfortunately this particular solution doesn't look intuitive to me. I wouldn't search for it there. I rather imagine something like this:

Add one more box to the Declutter window. It would be a Checkbox + select picker with label: Save filter as.
So once we add all "hide names" in the box above it, we can save them together with the settings above it to a particular named filter.
Then it would be easy to go to another map and pick that filter from a select box and tick it.
There could also be a tick with "use this saved filter by default" so that when you jump between the maps it gets automatically applied.
Also such filters would be preferably defined in the appmap.yml

Hope that feedback helps!


Re-add modules from CoraBot v3 such as chatbot and auto-moderation.

Re-add modules from CoraBot v3

[x] Auto-Moderator
[x] Chat Bot
[x] Guild Notifier
[x] Music/Radio?
[x] Bot Logger
[x] Mod Logger
[x] Support Tickets
[x] Suggestions

Considerations

Means of storing support ticket information. (Use database?)
Create support tickets using channel or threads?

Known Issues

Message content required for auto moderation, chat bot and logger modules. Will require intent from April 2022 onwards.

Marking as complete.
Features includes mostly from v4.0.0 beta 3
Remaining features added in v4.0.0 beta 4


Accommodating language-specific rules, config, and scopes

Hi,
First off, thank you for your work on making this useful tool "just work".
I've run into a couple lesser areas in which it would be nice to have resolution, both related to language-specific features:

The focus on file name matching in the .editorconfig spec doesn't seem to be able to take advantage of the Atom-support for multiple scopes within a file (e.g., JavaScript blocks inside Markdown where one may wish for the Markdown to indent by 4 spaces but for the JavaScript code to match the rest of the project with 2 spaces--as I like to do.)

While I see there are domain-specific property proposals and this may address some of the use cases for having domain-specific config:

Not every JavaScript-based project is open to having what they see as redundancy in adding an .editorconfig when they already have linting which, at least in theory, should be usable to cover much of the same ground. Even while it is not completely redundant (e.g., eslint will not specify indentation for non-JS files), some projects see things in such a light, depriving those of us who like to work on their projects, but who are not inclined to fork them, to have to make do with the project owner's lack of accommodatability).
ESLint already has very granular language-specific rules which don't seem to be even on the proposal list for .editorconfig. Some projects already expect this in their configs (e.g., config specific to switch indents, IIFE bodies, special handling for ternary operators, and other context-specific handling, as per the eslint indent rule's options.

However, current ESLint-driven tools do not seem to be an adequate solution here--not only due to the limitations that eslint is only for JavaScript, but also because its rule fixers are I believe only suited, per their coding, to apply after-the-fact, and do not set you up for proper indenting when you say hit return and want a newline to already have the indent applied, as with your .editorconfig application (auto-applying fixers might work but I think would come with its own hazard).
While one could develop a tool to query the ESLint config and adjust Atom (to listen for a cursor change, check the scope, and apply the proper indent), to date, the only ESLint-aware tool I am aware of for Atom, eslint-tab-length merely toggles the Atom application-level setting (and it seems to be hard-coded for use with standard).
So I was curious to hear your thoughts on this, as your project is the closest thing I have seen to date; whether in the direction of

Adapting your own package to support:

ESLint config file reading (and not merely adding equivalent .editorconfig rules since, again, some projects will, from what I have seen, be inclined to insist on only using ESLint)
Having the ESLint rules apply with scope-awareness (e.g., giving precedence to eslint rules over .editorconfig ones when a nested scope, like JavaScript (source.js) within Markdown, was detected)

OR:

To simply allow coordination with other packages that wish to read ESLint configs and apply within a nested scope or at least provide an option to users to disable the application of settings to nested scopes so that other packages could handle the nested scope and/or ESLint config reading.

Thanks!

The focus on file name matching in the .editorconfig spec doesn't seem to be able to take advantage of the Atom-support for multiple scopes within a file (e.g., JavaScript blocks inside Markdown where one may wish for the Markdown to indent by 4 spaces but for the JavaScript code to match the rest of the project with 2 spaces--as I like to do.)

See #237. This is a limitation of Atom's APIs, and something that needs to be addressed at the core-level.

Not every JavaScript-based project is open to having what they see as redundancy in adding an .editorconfig when they already have linting which, at least in theory, should be usable to cover much of the same ground. […] some projects see things in such a light, depriving those of us who like to work on their projects

EditorConfig isn't a linter; it's a means to facilitate contributions from people with different coding preferences. I think you'll find projects without .editorconfig files simply lack them because the author is unaware of EditorConfig's existence (or underestimate its importance). Projects that refuse to have an .editorconfig file in their codebase are only damaging people's ability to contribute.
That being said, I don't feel this is enough reason to justify making an exception to the package's current behaviour. Doing so would involve the following complications:

Adding an additional layer of logic over the underlying editorconfig library powering this package, which could involve any number of complications.
Justifying the absence of support for other linters and language toolchains; if we give ESLint special treatment, why not markdownlint, stylelint, go fmt, rust fmt, clang-format, and virtually any other specialised tool that reads from a config file?
Accommodating users who don't want to infer such settings in the absence of an .editorconfig file; do we offer them a package setting to do so? How do we justify the priority with which an .eslintrc file is honoured instead of .editorconfig, or vice versa? What if users wish to alter said priority? Finally, how many projects would actually benefit from this? How many users do you expect would be confused by this behaviour?

All these problems stem from attempting to fix problems that, quite frankly, have nothing to do with this package or EditorConfig, and everything to do with stubborn project-authors not caring about making contributor's lives easier.

ESLint already has very granular language-specific rules which don't seem to be even on the proposal list for .editorconfig. Some projects already expect this in their configs (e.g., config specific to switch indents, IIFE bodies, special handling for ternary operators, and other context-specific handling, as per the eslint indent rule's options.

Atom doesn't provide settings for controlling this sort of behaviour (or only does so in a limited manner). Contextual and language-specific indentation would be a nightmare to implement, and doing so is well beyond this package's responsibilities. Remember that EditorConfig is designed to accommodate all programming languages — when you consider the syntax of more exotic cases like Lisp, Forth, Scheme and PostScript, you'll start to see why granular indentation isn't so straightforward to implement.
In short, I feel the ideas you've proposed would introduce more problems than they'd solve. It would certainly violate the Principle of Least Astonishment, if nothing else.

Closing as Atom is abandoned.


webpack locale err

Description of the Issue and Steps to Reproduce:
webpack config add:
  resolve: {
    alias: {
      vue$: 'vue/dist/vue.esm.js',
      moment: 'moment/src/moment'
    }
  }

<script>
import moment from 'moment'
moment.locale('zh-cn'); // pack error
</script>

Please include the values of all variables used.
Environment:
OSX Node.js 8.4.0
Both the browser and the OS are important to us, particularly if you have an unsual environment like an IOT application.
Other information that may be helpful:

The time zone setting of the machine the code is running on
The time and date at which the code was run
Other libraries in use (TypeScript, Immutable.js, etc)

If you are reporting an issue, please run the following code in the environment you are using and include the output:
console.log( (new Date()).toString())
console.log((new Date()).toLocaleString())
console.log( (new Date()).getTimezoneOffset())
console.log( navigator.userAgent)
console.log(moment.version)

console.log( (new Date()).toString())
Thu Aug 17 2017 17:09:27 GMT+0800 (CST)
console.log((new Date()).toLocaleString())
2017-8-17 17:09:27
console.log( (new Date()).getTimezoneOffset())
-480
console.log( navigator.userAgent)
Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/62.0.3178.0 Safari/537.36
console.log(moment.version)
2.18.1

Ensure your issue is isolated to moment. Issues involving third party tools will be closed unless submitted by the tool's author/maintainer.
WARNING in ./node_modules/moment/src/lib/locale/locales.js
Module not found: Error: Can't resolve './locale' in '/Users/willin/Documents/w2fs/coding-task/node_modules/moment/src/lib/locale'
 @ ./node_modules/moment/src/lib/locale/locales.js 55:12-39
 @ ./node_modules/moment/src/lib/locale/locale.js
 @ ./node_modules/moment/src/moment.js
 @ ./src/component/moment/index.js
 @ ./node_modules/babel-loader/lib!./node_modules/vue-loader/lib/selector.js?type=script&index=0!./src/router/timeline/tasks.vue
 @ ./src/router/timeline/tasks.vue
 @ ./node_modules/babel-loader/lib!./node_modules/vue-loader/lib/selector.js?type=script&index=0!./src/router/timeline/timeline.vue
 @ ./src/router/timeline/timeline.vue
 @ ./src/router/timeline/index.js
 @ ./src/router/index.js
 @ ./src/main.js
 @ multi (webpack)-dev-server/client?http://localhost:3993 webpack/hot/dev-server ./src/main.js

This was fixed in #4042 and should be fine in the next release. In the meantime the easiest reliable workaround for the the issue is to manaully change require('./locale/' + name) to require('moment/locale/' + name) in your node_modules/moment directory.

This was fixed in #4042 and should be fine in the next release. In the meantime the easiest reliable workaround for the the issue is to manually change require('./locale/' + name) to require('moment/locale/' + name) in your node_modules/moment directory.

Hey just noticed on the change log page that this fix has not been included in a release yet, just wondering when the cuttable release is

webpack 3.6.0 + moment 2.19.0 still has the problem.
Seems like the proble is not fixed in latest release.....

Looks like the issue it's still there

Same problem here.
I have a project that's working on 4 computers. Another computer I am trying to set it up on throws the same error as described.
Webpack (2.2.1) and Moment (2.15.1) versions are the same everywhere. Node/Npm similar/same.


Don't allow word-wrap on the table cells with the thumbs up and thumbs down icons

At some screen sizes, that table cell can get really weird. I'd highly recommend applying the white-space: nowrap CSS rule to those table cells.

Honestly the whole thing needs redesigned. It was fine as a table when there were a few columns but the more that get shoved in the worse the layout gets at any screen width.


Discussion: Observations on design of the homepage and suggestions for improvement (Desktop Only)

Hello everyone, I am a regular user of the website using a web-browser and I have a few observations concerning the design of the home-page from usability perspective which I would like to share with you.
1. Spread Trends component is not visible at first glance and not intuitive

Problem: Currently when user visits the home-page from a web-browser, a scroll-down action is needed to view the Spread Trends visualizations. Moreover, if one wants to use all the features of the visualization (i.e. using Beginning, 1 month tabs), his/her options of hovering through the states on the left hand side is limited. As you can see in the picture, I can only start from Odisha if I want to hover through different states to visualize their graphs.

Current Workaround: Currently, users can load visualizations for different states by selecting different states available through a drop-down list.

Proposed Solution: I think making the moving the Spred Trends component to the top-left portion of the page (on top of the table component) would be more user-friendly and intuitive.

Currently there is a Search-Bar component, and a component which includes total numbers and minigraphs. Point 2 of #1230  already questions the relevance of Search-Bar component, and I also agree with the solution that was proposed. In addition, I think, the components with a div of level and minigraph could be moved to the top-right (more will be discussed in the next point) to make space for the Spread Trends component.
Instead of showing all three visualizations for confirmed, recovered and deceased cases, we can show only one, and incorporate vertical tabs to browse through the different visualizations

2. Redundant information on total numbers

Problem: Currently the information on total numbers is presented in 3 different places. This, in my opinion is a bit redundant, and could be removed to make the hom-page more compact.

Proposed Solution: The general information from the top of the table could be removed. The uers can take use of the information available on the top right side of the page (available over the map component). This would also help us with the problem 1.

Looking forward to a conversation involving the moderators and contributors to discuss these points. Thank you!

Hey @pulakchakraborty, thanks for the detailed suggestions. I think @jeremyphilemon would be able to better explain the design choices. I'll just give my two cents.
I believe you're looking at it only through the lens of a PC user. For example, having the buttons on the right of the Spread Trends is difficult to translate to mobile, since horizontal space is extremely limited. Our traffic is predominantly mobile, so we have to keep these things in mind.
Regarding redundancy in the placement of total numbers, I don't think of the ones above the map are particularly redundant. Think of them as a placeholder until the user goes on to select a state to view the state's numbers.

I think a scroll to top feature can be added on the home page at the bottom right corner.

I think a scroll to top feature can be added on the home page .


Add Demystifying Deep Learning

Hello @fredhohman,
i would like to add Demystifying Deep Learning, a project to make Deep Learning more beginner-friendly with Human-Centered Design. For this, we developed an interactive learning application for experimentation with datasets and convolutional neural networks (http://ai.uol.de).

Hi @svenschultze,
Thanks for submitting your project! While this survey is up to date until late 2018, the past couple of years have resulted in my many more deep learning visualization systems. Unfortunately this site isn't up to date with all the latest advancements. I want to include your project, but since the website survey is 2 years "behind" I need to consider how to include yours while keeping everything consistent; maybe another section with more recent projects makes sense.
Let me think on this for a little bit!


DNM (but please review): remove ignite/starport

The ignite cli has a terrible track record of keeping dependencies like cosmoscmd up to date.
For security reasons, we should remove any depencency that lives in its repository.
For maintainability reasons, same thing.

Note:
I can't figure out why the docker container keeps failing, causing the CI tests for gov (which we want to keep) are failing.

Note:
I can't figure out why the docker container keeps failing, causing the CI tests for gov (which we want to keep) are failing.
Do we happen to use the ignite cli at all in the flow?

Without testing it on my end, i guess it's failing due to some incorrect working directory at the runtime execution - i did a quick scroll thru the workflow log ~ and i think i saw that the chronologic order of the gh actions might be incorrect.
The logfile tells us that the docker compose up command is running against the wall - this action is being executed AFTER cloning cw-unity-prop repo, which does not have a docker compose file. That should be ran on the juno(d) workdir, not cw unity prop.
Maybe.

Thank you very much for your review, that is actually a bug that I introduced while testing CI, and I will revert it shortly.
Sorry about that!

I think that in the end it’s going to be necessary to rewrite this. I have written the star port removal four or five times now and I don’t know where the bug is but I bet that I don’t repeat it if I try to rewrite.

@nghuyenthevinh2000 @catShaark @vuong177
Hi, would you mind please having a formal look at this PR?
Something is wrong, and at this point, I've got to choose between rewriting it and tossing it.
Thanks!

Hey! Denis from Ignite here. @faddat, would you mind elaborating on what you mean by:

The ignite cli has a terrible track record of keeping dependencies like cosmoscmd up to date.

"For security and maintainability" sounds vague. If there is something you think is wrong with the package, we'd be happy to discuss this.

I also think that I need to close this one I can't for the life of me figure out why the CI is broken and I think that it has something to do with of course cosmoscmd.

Thanks for a detailed response, @faddat! Can you, please, describe (or link to) a specific example of what's not possible to do right now with cosmoscmd, so we can use this constructive feedback to improve the package?
The argument that it hasn't been up-to-date with the SDK in the past is weak. Well, we're a small team (3-4 people) working on the project and we're doing our best, it is up-to-date now.
The idea behind the package is simple: for Cosmos SDK to act more like a framework rather than a set of libraries loosely tied together with a template, functionality that is non-chain specific should be abstracted away into libraries.

cosmoscmd is not as customizable as we want it to be, but only very specific actionable feedback can help us improve the package.

@sascha1337 we've (imo) got to make ci pass.  And I think it should pass unmodified.  @nghuyenthevinh2000 is working on this too.  So, what I think we should be able to achieve is:

zero changed files in .github
removal of the ignite cli
usage of ibc-go v3 with its full set of cli extensions

if you need a hand picking up the sdk, please don't hesitate to reach out.
@fadeev sir, Ignite cli uses and forces its users into using, version 2.0.3 of ibc-go.  This version has been abandoned by the ibc-go team, and their release notes on 2.1.0 and 2.2.0 explicitly state to retire version 2.03. of ibc-go and these kinds of things will be the items behind my request to the cosmos-sdk team to remove ignite cli from the readme of the cosmos sdk, as this is by no means the first time we have had this conversation.
I'm sorry.

I do suspect that there's a bug in the cmd folder.  It's just simply that I do not know where it is.  I may now try like:
wasmd/cmd -> this repo -> find and replace everything dealing with appname.  It is unfortunately not my first time at this rodeo.

@faddat I'm sorry, but you're talking nonsense. Ignite CLI does not enforce any version of IBC. A developer can follow simple instructions and upgrade the version of IBC to v3. The newest version of Ignite CLI comes with the latest version of IBC.
If you have a feature request (like making it possible to keep seeds in the binary), please, create an issue and describe your use case:
https://github.com/ignite-hq/cli/issues

@faddat I'm sorry, but you're talking nonsense. Ignite CLI does not enforce any version of IBC. A developer can follow simple instructions and upgrade the version of IBC to v3. The newest version of Ignite CLI comes with the latest version of IBC.
If you have a feature request (like making it possible to keep seeds in the binary), please, create an issue and describe your use case:
https://github.com/ignite-hq/cli/issues

he said earlier in this convo, that he did follow those v2->v3 instructions - would it be possible to quick scroll thru the CI logs and point at the core issue, sir product manager ? :pray:
he documented the steps and tries very detailed here, why creating another issue thread, DRY principle
thanks sir !

The instructions were written after I completed the rework stuff.  @fadeev thank you so much for updating ignite cli.  My preference for Juno is that we proceed forward with the removal of ignite cli from juno so we can have fewer dependencies and be more of a reference.
@nghuyenthevinh2000 thanks so much for finishing this work.

Ok:

Main needs merging in
I think v8 -> v9 since we're now working against v9 candidate

And then I think I'm happy with merging this and moving it forward for testing.

Gonna do that now out of curiosity

on it.

@the-frey hey, main is merged in already afaik

@the-frey hey, main is merged in already afaik
@sascha1337 if you're working on juno routinely, please feel free / encouraged to make PR's into branches like these, basically to keep up velocity.

I've literally seen that on the iOS app I had to turn on notifications manually, now I see what's going on when watching repos :) automatically being in the feedback loop
Plus whitelisting GitHub notifications when turning on do not disturb / work modus across devices, small thing but literally game changer 😁  LGTMFAM

@faddat Is this now updated and R4M? I've already approved but I think GH is prompting me to smash that tick button again.

Yep, this is ready to rock.

@joeabbey would you mind giving this a review dude?

Spotted maybe 1 thing that might be worth renaming, but GTM apart from that (and apols if I've mis-remembered where the app info via CLI gets logged from - the Stargate CosmosHub thing always annoyed me).

they're both worth changing.  thanks.

Have changed. If CI passes then it's GTM


Idempotent repo add/remove

Currently 'helm repo add' hangs indefinitely if the repo exists and 'helm repo remove' exits with error if the repo exists.
Probably easiest to add flags on 'helm repo add' and 'helm repo remove' similar to how there is an idempotent 'helm upgrade --install'.

Have you see the --no-update flag on helm repo add?
What is the error you see on helm repo remove when the repo exists?

Sorry, meant exists with error if the repo doesn't exist.  Message is: "Error: no repo named "foo" found
echo $?
1

Which is probably fine, as for that use case I can just do the following (although I don't want to ignore other errors).
helm repo remove foo || true

I apologize, I did not see the --no-update flag.  So I believe that helm repo add is ok.  I'm still unsure of the reason for the command hanging, but i'll try to track that down.
Thanks for the help.  I'll close this as the hanging doesn't have to do with the ticket and I can work around the helm repo remove error code.


Add support to sign in with Slack

Slack has added the ability to sign in: https://api.slack.com/docs/sign-in-with-slack
The info should be fetched from /api/users.identity instead of /api/auth.test and /api/users.info

Just a heads up, shouldn't this issue be closed?

Year right. Thank you for letting me know.
This issue was resolved by #32.


The documented panic handler does not exit raw mode correctly in the Termion backend

Description

Following the code on : https://ratatui.rs/how-to/develop-apps/panic-hooks/
I'm using the Termion backend.
The line in the docs
output.into_raw_mode()?.suspend_raw_mode()?;

should in theory disable raw mode from the terminal, but in reality it does not.
The '\n' characters on strdout/stderrr go to a new line, but they don't place the cursor at the beginning of the line, thus resulting in a weird output.
To Reproduce

painc!() anywhere in the app and see the stdout/stderr with weird newline behaviour.
Expected behavior

Screenshots

Environment

OS: Fedora 39
Terminal Emulator: GNOME Terminal
Font: Liberation Mono
Crate version: 0.26.1
Backend: Termion

Additional context

I don't know if this should be a bug in Termion itself.

I pointed out this issue while adding this code to the website: https://github.com/ratatui-org/ratatui-website/pull/69
It might be an issue with termion and I'm thinking if we should move this issue to the website repository or not...

output.into_raw_mode()?.suspend_raw_mode()?; does suspend raw mode but only until the end of the block, where the RawTerminal created by into_raw_mode is dropped, and the previous state is restored (which is likely still Raw mode I'd guess). See:
https://gitlab.redox-os.org/redox-os/termion/-/blob/master/src/raw.rs?ref_type=heads#L44-48
Also note that panic_cleanup().expect("failed to clean up for panic"); will prevent the panic hook running on the next line if the cleanup fails. This is likely not what you want.
That is to say, the website doc is wrong and untested and should be fixed. Would you want to submit a PR for this?
BTW, I'm curious about your rationale for choosing termion over crossterm for your app. Do you have any thoughts you can share on this choice?

From what I understand from the source that you linked ( https://gitlab.redox-os.org/redox-os/termion/-/blob/master/src/raw.rs?ref_type=heads#L44-48 ), creating a new io::stdout() sets the prev_ios to the mode of the terminal at the creation of the object, so if the terminal is already in raw mode, prev_ios is already raw mode, so it doesn't really exit raw mode.
One more reason to implement what I requested in #1006 , so that I can switch back and forth from raw mode at least during normal program execution, if not in the panic handler😉

BTW, I'm curious about your rationale for choosing termion over crossterm for your app. Do you have any thoughts you can share on this choice?

I chose Termion for 3 main reasons:

What I'm developing is Linux-only
Termion is lighter and has fewer dependencies than Crossterm
I prefer Termion's Input/Event handling APIs compared to Crossterm

From what I understand

yep

One more reason to implement what I requested in https://github.com/ratatui-org/ratatui/issues/1006 , so that I can switch back and forth from raw mode at least during normal program execution, if not in the panic handler😉

yep agreed

I chose Termion for 3 main reasons:

Makes sense :)

I think there's still likely a problem with having a panic handler and using raw mode with termion, and that can probably only really be fixed by termion (or by providing your own code to do basically the same thing as termion does earlier on in the calls (save the termios value and restore it when panicking)..

See https://gitlab.redox-os.org/redox-os/termion/-/issues/176 for more discussion on this.

I managed to write a panic handler that works:
use std::{
    io::{self, Write},
    panic,
};

use anyhow::{Context, Result};
use termion::{input::MouseTerminal, raw::IntoRawMode, screen::IntoAlternateScreen};

fn initialize_panic_handler() -> Result<()> {
    let mut raw_output = io::stdout().into_raw_mode()?;

    raw_output.suspend_raw_mode()?;

    let panic_hook = panic::take_hook();
    panic::set_hook(Box::new(move |panic| {
        let panic_cleanup = || -> Result<()> {
            let mut output = io::stdout();
            write!(
                output,
                "{}{}{}",
                termion::clear::All,
                termion::screen::ToMainScreen,
                termion::cursor::Show
            )?;
            raw_output.suspend_raw_mode()?;
            io::stdout().flush()?;
            Ok(())
        };
        panic_cleanup().expect("failed to clean up for panic");
        panic_hook(panic);
    }));

    Ok(())
}

fn main() -> Result<()> {
    initialize_panic_handler().context("failed to initialize panic handler")?;

    let stdout = MouseTerminal::from(
        io::stdout()
            .into_raw_mode()
            .context("failed to enable raw mode")?
            .into_alternate_screen()
            .context("unable to enter alternate screen")?,
    );

    let mut terminal =
        Terminal::new(TermionBackend::new(stdout)).context("creating terminal failed")?;

In the initialize_panic_handler function I create a raw terminal, and immediately exit raw mode, so that the raw terminal has the correct prev_ios field set.
In the panic handler I reference that raw terminal to exit raw mode, and it works as long as initialize_panic_handler is called before entering raw mode in the main function.
So if you want to update the docs with a working implementation, there you have it😉
Note that this doesn't solve the need for #1006 and #991 .


May remove documentation from in the repository

This issue may result in mess, like this #9079

Yes! Actually, it's never my intention to keep tons of documentation within the repo. We'll just have the readme, and a separate wiki or github pages for extended documentation.

What about adding README and similar documents to .npmignore?

@anonrig This solution should be valid while repository is getting bigger. I think documentation is always useful outside the repository and therefore each documentation must have  a website.

@anonrig definitely. But still, when you clone the repo for inspection, further development, customization, etc, it gives you everything. Which may not be what you want.

On the contrary, as a developer being able to access the documentation from the same repo might be a good thing. @dashersw

Very few people look in the folder for documantation

@anonrig it might. I don't have a strong opinion on this.


Custom attribute for UseDatabase broken

Is there an existing issue for this?

[X] I have searched the existing issues

Describe the bug
There is a bug where the short hand of
[UseDbContext(typeof(TradingDbContext))]
won't work as
[UseAppDbContext]
This is using 12.2

The middleware pipeline order for the field Query.stopOrders is invalid. Middleware order is important especially with data pipelines. The correct order of a data pipeline is as follows: UseDbContext -> UsePaging -> UseProjection -> UseFiltering -> UseSorting. You may omit any of these middleware or have other middleware in between but you need to abide by the overall order. Your order is: UsePaging -> UseProjection -> UseFiltering -> UseSorting -> UseDbContext.... (HotChocolate.Types.ObjectType)

Steps to reproduce

https://hotchocolategraphql.slack.com/files/U027FD05RHS/F02M3GKRRM1/image.png
https://hotchocolategraphql.slack.com/files/U027FD05RHS/F02M0H0TLQ5/image.png
https://hotchocolategraphql.slack.com/files/U027FD05RHS/F02MT75CK24/image.png

Relevant log output
1. The middleware pipeline order for the field `Query.stopOrders` is invalid. Middleware order is important especially with data pipelines. The correct order of a data pipeline is as follows: UseDbContext -> UsePaging -> UseProjection -> UseFiltering -> UseSorting. You may omit any of these middleware or have other middleware in between but you need to abide by the overall order. Your order is: UsePaging -> UseProjection -> UseFiltering -> UseSorting -> UseDbContext.... (HotChocolate.Types.ObjectType)

Additional Context?
Hotchocolate latest version 12.2.0
Product
Hot Chocolate
Version
12.2.0

This is not a bug. The order of attributes in C# is not guaranteed, that is why we reworked the attributes to infer the order from the code line number.
Add the following constructor to your attribute:
public UseAppDbContext([CallerLineNumber] int order = 0)
{
    Order = order;
}

This works spuriously for me on v12.12.1. It solved my error in one case, but does not work in others.
Attribute:
  public UseFurDataContext([CallerLineNumber] int order = 0) {
    Order = order;
  }

  public override void OnConfigure(
    IDescriptorContext context,
    IObjectFieldDescriptor descriptor,
    MemberInfo member) {
    descriptor.UseDbContext<FurDataContext>();
  }
}

Implementation:
[ExtendObjectType(typeof(BossBattlePlayer))]
public class GameBattleExtensions {
  [GraphQLDescription("Paginate through the moves in the game")]
  [Serial]
  [UseFurDataContext]
  [UsePaging]
  public IQueryable<BattleMove> GetMoves([Service] FurContext context, [Parent] BossBattlePlayer battle) => context.Data.BattleMoves
    .IncludeDefaultBattleMove()
    .Where(m => m.BattleId.Equals(battle.Id))
    .OrderByDescending(s => s.CreatedAt);
}

Error:
{
  "errors": [
    {
      "message": "For more details look at the `Errors` property.\n\n1. The middleware pipeline order for the field `BossBattlePlayer.moves` is invalid. Middleware order is important especially with data pipelines. The correct order of a data pipeline is as follows: UseDbContext -> UsePaging -> UseProjection -> UseFiltering -> UseSorting. You may omit any of these middleware or have other middleware in between but you need to abide by the overall order. Your order is: UsePaging -> UseSorting -> UseDbContext... -> UsePaging. (Furballs.Api.Bosses.BossBattlePlayerType)\n",
      "type": "Exception",
      "code": "SchemaException",
      "data": {},
      "stack": [ ...
      ]
    }
  ],
  "meta": {
    "traceId": "0HMK6R5OEHV8H:00000002"
  }
}

For future Google travelers... If all your decorators are applied twice in order, it probably means you have a method with the same name elsewhere in your codebase.
HotChocolate.SchemaException: For more details look at the Errors property.

1. The middleware pipeline order for the field `Query.items` is invalid. Middleware order is important especially with data pipelines. The correct order of a data pipeline is as follows: UseDbContext -> UsePaging -> UseProjection -> UseFiltering -> UseSorting. You may omit any of these middleware or have other middleware in between but you need to abide by the overall order. Your order is: UsePaging -> UseProjection -> UseFiltering -> UseSorting -> UsePaging -> UseProjection -> UseFiltering -> UseSorting. (HotChocolate.Types.ObjectType<DataAccess.Query>)```

For future Google travelers... If all your decorators are applied twice in order, it probably means you have a method with the same name elsewhere in your codebase.
Many thanks.


V.0.10.4 - Cargo.toml doesn't match Cargo.lock

Hi
Issue https://github.com/void-linux/void-packages/issues/48794

Sorry about that.  I've created a new release 0.10.5 that has them aligned.


Remove-DbaDatabaseSafely - lost database trying to remove it safely

Bug Report
Call function Remove-DbaDatabaseSafely -SqlInstance SRV1 -Database DB1 -BackupFolder \\srv-backup\sql_backup\ -NoDbccCheckDb:
Lost database.
General Troubleshooting steps

[X] Verified running the latest release of dbatools?
[X] Verified errors are not related to permissions?
[ ] Can duplicate in new/clean PowerShell session (clean = powershell -NoProfile)?

Version Information

Operating System (Name|Version): Windows 10 1709
PowerShell Version: 5.1
SQL Server (Edition|Version): 2008 R2

Steps to Reproduce

Some additional information
Remove-DbaDatabaseSafely had a parameter -BackupFolder which is not in naming consistence with Backup-DbaDatabase -BackupDirectory

ill look into this asap


Defaut password has changed and can't be reset

Defalut password is: "password" (without quotes) don't works


ADR manager on VS code - Wording used in the template (Decider)

I´ve noticed that the template used by ADR manager extension in VSCode uses the word ´Decider´, which is not correct in the context.
it should be ´Decision maker´(or decision participants).
The word decider does not refer to a person.

In the ADR template, it is "Deciders" https://github.com/adr/madr/blob/develop/template/adr-template.md
Is ChatGPT wrong?

I am fine with changing it to "Decision Makers". WDYT @socadk?

This is not about decider being an English word or not, but about the meaning of the word.  I prefer not to comment on ChatGPT.
For British English decider is the final game.
In US English this is rather for the person, though in many years working for a US company, I've never seen anyone using this word with this meaning.
I've just started using ADR manager, and I can go for another solution,.

From: Oliver Kopp @.>
Sent: Thursday, April 20, 2023 6:18:40 PM
To: adr/adr-manager @.>
Cc: Guillaume Fagernes-Turpin @.>; Author @.>
Subject: Re: [adr/adr-manager] ADR manager on VS code - Wording used in the template (Decider) (Issue #155)
In the ADR template, it is "Deciders" https://github.com/adr/madr/blob/develop/template/adr-template.md
Is ChatGPT wrong?
[image]https://user-images.githubusercontent.com/1366654/233426834-6c3f829e-355b-4848-a89e-6c1cdfd30bd6.png
I am fine with changing it to "Decision Makers". WDYT @socadkhttps://github.com/socadk?
—
Reply to this email directly, view it on GitHubhttps://github.com/adr/adr-manager/issues/155#issuecomment-1516609423, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AMFVS7K5DWO7AGBDDH5HDILXCFOWBANCNFSM6AAAAAAXFS6AJI.
You are receiving this because you authored the thread.Message ID: @.***>

The information contained in this message may be CONFIDENTIAL and is
intended for the addressee only. Any unauthorized use, dissemination of the
information or copying of this message is prohibited. If you are not the
addressee, please notify the sender immediately by return e-mail and delete
this message.
Thank you

Thank you for the comment - and the understandable explanation, highly appreciated!
Double check: It is "Decision Maker" without any additional "s" at the end?
I field an issue at https://github.com/adr/madr/issues/101.
Two options to go from here:

Fix adr-manager - and let it derive from the original MADR 2.1.2 template
Fix https://github.com/adr/madr/issues/101, release MADR 4.0.0, update ADR Manager to support MADR 4.0.0. - In all cases, ADR Manager needs to be updated to follow latest MADR. 3.0.0 is out more than half a year now.

In case you have any other comments on the latest development version (which is available at https://github.com/adr/madr/blob/develop/template/adr-template.md), just let us now. Here or at the issue tracker of MADR at https://github.com/adr/madr/issues.

Hi Oliver,
Thanks for your follow-up!
What about ´Decision maker(s)´ which would fit both scenarios with one or several involved individuals?
From: Oliver Kopp @.>
Date: Friday, 21 April 2023 at 09:00
To: adr/adr-manager @.>
Cc: Guillaume Fagernes-Turpin @.>, Author @.>
Subject: Re: [adr/adr-manager] ADR manager on VS code - Wording used in the template (Decider) (Issue #155)
Thank you for the comment - and the understandable explanation, highly appreciated!
Double check: It is "Decision Maker" without any additional "s" at the end?
I field an issue at adr/madr#101https://github.com/adr/madr/issues/101.
Two options to go from here:

Fix adr-manager - and let it derive from the original MADR 2.1.2 template
Fix adr/madr#101https://github.com/adr/madr/issues/101, release MADR 4.0.0, update ADR Manager to support MADR 4.0.0. - In all cases, ADR Manager needs to be updated to follow latest MADR. 3.0.0 is out more than half a year now.

In case you have any other comments on the latest development version (which is available at https://github.com/adr/madr/blob/develop/template/adr-template.md), just let us now. Here or at the issue tracker of MADR at https://github.com/adr/madr/issues.
—
Reply to this email directly, view it on GitHubhttps://github.com/adr/adr-manager/issues/155#issuecomment-1517359759, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AMFVS7PXYHNHP7XAJBCEMVLXCIV7ZANCNFSM6AAAAAAXFS6AJI.
You are receiving this because you authored the thread.Message ID: @.***>

The information contained in this message may be CONFIDENTIAL and is
intended for the addressee only. Any unauthorized use, dissemination of the
information or copying of this message is prohibited. If you are not the
addressee, please notify the sender immediately by return e-mail and delete
this message.
Thank you

What about ´Decision maker(s)´

Done :-) --> https://github.com/adr/madr/issues/101 - and also released.
Will flow into this tool as soon as someone updates it to MADR 4.0.0 - https://github.com/adr/adr-manager/issues/165. Thus, I am closing this issue 😅
We have another term discussion around confirmation, compliance, etc - do you have some spare minutes to contribute to the discussion at https://github.com/adr/madr/pull/170?


Allow multipart upload

Should fix #203

Is it tested? If the response is false please test with https://github.com/decebals/pippo-demo/tree/master/pippo-demo-upload

Yes, is tested. I will make a new test again with that demo


Fix TagHelper directive tests to fail when expected.

Prior to this change the equals bits were falling back to the type comparison that ChunkGenerator exposes.

:up: :date:

:shipit:

:shipit:


Initialize implementations for proxy contracts and protect initialization methods

It should be avoided that the implementation of proxy contracts can be initialized by third parties. This can be the case if the initialize function is unprotected. Since the implementation contract is not meant to be used directly without a proxy delegate-calling it is recommended to protect the initialization method of the implementation by initializing on deployment.
When working on this issue, please take care of BondedECDSAKeepVendorImplV1 initialization but also make sure there are no other similar problems in other places of the code.

@tintinweb's suggestions are handled in https://github.com/keep-network/keep-ecdsa/pull/323.


grape-entity 0.5.1 breaks http_codes spec

With this commit, which introduce Grape::Entity::Exposure::NestingExposure::OutputBuilder, it break spec/grape/api_spec.rb:2034, the txt error formatter using is_a?(Hash) to test whether the response body need to cast to JSON, which here becomes OutputBuilder, a SimpleDelelator for Hash.

This is a dup of https://github.com/ruby-grape/grape/issues/1350, right? Would love a fix in the right place.

right, dup of #1350


Usage

I'm using v4.  I spent hours trying to pass in json without it working.  Here's what finally worked.
var queryText = "SELECT * FROM c WHERE c.A = @userId ";
var queryDefinition = new QueryDefinition(queryText);
queryDefinition.WithParameter("@userId", "97a611aa-b894-42fa-9934-e957bf272466");
...
await foreach (var contact in _contactsContainer.GetItemQueryIterator(queryDefinition)){}

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d4787bd5-5e70-c491-0772-5158de8b8624
Version Independent ID: cb34b3f3-4dcb-0c98-ace5-1da73b2259bc
Content: Parameterized queries in Azure Cosmos DB
Content Source: articles/cosmos-db/sql-query-parameterized-queries.md
Service: cosmos-db
Sub-service: cosmosdb-sql
GitHub Login: @timsander1
Microsoft Alias: tisande

@dcblakesley Thank you for reaching out and taking the time to provide feedback.
Documentation on the page targets v3 SDK since v4 is currently in preview.
Once v4 is generally available, we will make updates to the SDK documentation wherever applicable.

@dcblakesley Please let us know if you need any further help with this.

@dcblakesley For now we are going ahead and closing this feedback. Please get back to us if any other question.


ON/Off option is reverse in activating ragdoll

Godot version:

9b1fdad
OS/device including version:

linux mint
Issue description:

I create the physical skeleton by the button and I use physical_bones_simulation(true) to activate it. The result is fine if I don't check simulate physics option of the physical bones in the editor. If I check the bone while using physical_bones_simulation(true), it stops the simulation of that bone. It is off instead of on.
Another problem, I don't know whether it is a bug or not. is it true that I must call physical_bones_simulation(true) to activate the simulation and check/uncheck desire bone with simulation? If I don't call physical_bones_simulation(true) and check the simulate physics of the physical bones option in the editor, nothing happens.
Steps to reproduce:
create the physical skeleton
call  physical_bones_simulation(true)
check the simulate physics option of the physical bones in the editor
Minimal reproduction project:

Thanks you for your comment, I've improved the API in order to make easy the activation and deactivation of full body or partial.
Also I've removed the possibility to check simulation on physical bone on the editor in order to avoid misunderstanding.
Thanks you for your contribution!
Check this #18764


Search "button" is a link

The search "button" is a link, and Lighthouse marks it as an error. I believe this should be a button, unless I'm wrong.

Hi Catalin! Can you please assign me this issue?

Hi Catalin! Can you please assign me this issue?

Done! Thanks 🙌

Done! I hope it's okay 🦾

Fixed by https://github.com/catalinpit/attila-theme/pull/5. Thanks a lot once again @emiliacb! Appreciate the help! 🙏


Warnings and Suggestions... Are there any plans to migrate.

Hello,
Thanks for building this plugin. It's much appreciated.
I was just installing this plugin to try it out. Got the below message.
Any plans to maintain and upgrade?
npm install -g bower
npm WARN deprecated<EMAIL_ADDRESS>We don't recommend using Bower for new projects. Please consider Yarn and Webpack or Parcel. You can read how to migrate legacy project here: https://bower.io/blog/2017/how-to-migrate-away-from-bower/
/usr/local/bin/bower -> /usr/local/lib/node_modules/bower/bin/bower
/usr/local/lib
└──<EMAIL_ADDRESS>

There are no current plans to maintain this plugin.


ChatAnthropicTools: fixArrayXMLParameters improvements

It seems like ChatAnthropicTools is just temporary until Anthropic officially releases tool calling: https://github.com/langchain-ai/langchainjs/pull/4618#discussion_r1511983435
This PR fixes some issues I've had when using ChatAnthropicTools with Opus:

Validating nested properties in the JSON schema failed
Opus returns number arrays like [1,2,3] or 1,2,3 consistently for me, but the current code parsed that as ["[1,2,3]"] and ["1,2,3"] respectively

@davidfant was able to verify - some typing issue though. Why mutate the input into fixArrayParams?


Facets Site Improve Events

Problem Description:
There are SI events missing on advanced search events.
Expected Behavior/Solution:
Add or update SI events on advanced search.
Requirements:

[x] User selects a facet accordion

Category: Facets Accordion Item
Action: Open/Close
Label: Facet <name of facet>

[x] User checks a facet checkbox

Category: Facets Checkbox
Action: Checked
Label: Facet <name of entity>

[x] User unchecks a facet checkbox

Category: Facets Checkbox
Action: Unchecked
Label: Facet <name of entity>

[x] User deselects a facet from the Selected Filters

Category: Facets Selected Filters
Action: Remove
Label: Facet<name of entity>

[x] User selects Clear All facets from the Selected Filters

Category: Facets Selected Filters
Action: Selected
Label: Facet Clear All

Needed for promotion:
If an item on the list is not needed, it should be crossed off but not removed.

[ ] ~Wireframe/Mockup - Mike~
[ ] ~Committee discussions - Sarah~
[ ] ~Feasibility/Team discussion - Sarah~
[ ] ~Backend requirements - TBD~
[ ] Frontend requirements - Kam
[ ] Questions

UAT/LUX Examples:
View User selects a facet accordion report:
https://my2.siteimprove.com/Analytics/375000/Custom/EventTracking/Index/1?SearchField=&Query=facets+acco

Verify Category, Action, and Labels appear correctly.

View User checks a facet checkbox | 1User unchecks a facet checkbox` reports:
https://my2.siteimprove.com/Analytics/375000/Custom/EventTracking/Index/1?SearchField=&Query=facets+checkbox

Verify Category, Action, and Labels appear correctly.

View User deselects a facet from the Selected Filters | User selects Clear All facets from the Selected Filters reports:
https://my2.siteimprove.com/Analytics/375000/Custom/EventTracking/Index/1?SearchField=&Query=facets+selec

Verify Category Action, and Labels appear correctly.

Dependencies/Blocks:
N/A
Related Github Issues:

#90
#91

Related links:
For more information on SI Events please view the documentation here:
https://docs.google.com/document/d/1jsH4ckYOW7ykXlKACctZOP1IpxYnGaRIRPGDiuUbGMQ/edit
Wireframe/Mockup:
N/A

Approved per UAT

SI events are being captured from prod. Looks good to close.


White space between navbar and sidebar

Hey guys =)
Just another issue I notice, right above the sidebar there is an white block:

How can I fix it?

Few others have mentioned this as well but I can't seem to recreate it. Can you try changing menubar height to --menubar-height : -0px; in userChrome.css? You will have to restart firefox after it.
Also just confirming, do you have any of the toolbars selected on "customize toolbar" page?

@akshat46, changing the --menubar-height at line 16 solved the issue =)
Thanks!
I'm closing it


What's the difference of this from ray-x/lsp_signature.nvim?

As title. I'm using ray-x/lsp_signature but it's kinda laggy. This info will be helpful for people using this plugin :) Thank you

By my count, that plugin is around 1400 loc, this is about 100 (and less, if/when I upstream some modifications to the signature help handler since half of the plugin is a duplicated handler). I don't care if people us lsp_signature.nvim, the name is a coincidence, it was the most obvious name for something that opens signature help for you.

OK cool. Feel free to tag me if you have some new features that need someone to test.


Disable master in CI.

There's no need to build and test the exact same commit twice between
bors's auto branch and master. Hopefully this will help reduce the
bors timeouts due to waiting on appveyor.

r? @alexcrichton
(rust_highfive has picked a reviewer for you, use r? to override)

I'm often frustrated with travis and appveyor configuration rules, but from testing on my repo this seems to work.
An alternative is to test "if pull request OR branch == cargo-auto" to avoid double testing on beta branches, but I wasn't certain if there are scenarios where you ever push directly to a branch and want it to test.  Beta PRs are hopefully rare and this seemed like a more conservative approach.  Also, I'm not entirely certain how homu is configured.  It might also need to check for "try" branch, though I don't think that's ever used here.
Anyways, let me know if you want this tweaked at all.

:sunny: Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing feb2209615d0814249cda7319df7b027189ed1e7 to master...


Issue resume websocket and exit websocket

Issue 1
Describe the bug

I create android project and then create android library module,
in library module, add Service, and put websocket.
in library module, add activity, start websocket.
in android project, add button "btn" to startactivity to library module.
compile app to test
click button "btn", then will go to library module
click phone home button.
go back app.
the app exit library module, go back android project.

To Reproduce
Steps to reproduce the behavior:

Open app
click phone home button
3 go back app
will get same result

Expected behavior
after go back app, should resume library module, not exit library module.
Issue 2

in library module, add Service, and put websocket.
in library module, add activity, after finish use, cant close socket in activity.

Does anyone know, how could this two issue be fixed?
Thank you.

Hello @RalryOng,
please provide an example application.
Keep in mind this library is designed for Java and not Android.
Best regards,
Marcel

Hi Marcel,
thank you for your reply, i will think other way.


MGDOBR-486: shard uses service account for authentication

MGDOBR-486
PR owner checklist
Please make sure that your PR meets the following requirements:

[ ] Your code is properly formatted according to this configuration.
Run mvn clean verify -DskipTests so that imports are correctly set.
[ ] Your commit messages are clear and reference the JIRA issue e.g: "[MGDOBR-1] - $clear_explanation_of_what_you_did"
[ ] All new functionality is tested
[ ] Pull Request title is properly formatted: MGDOBR-XYZ Subject
[ ] Pull Request contains link to the JIRA issue
[ ] Pull Request contains link to any dependent or related Pull Request
[ ] Pull Request contains description of the issue
[ ] Pull Request does not include fixes for issues other than the main ticket

PR reviewer(s) checklist

[ ] Check if code and Github action workflows have been modified and if the modification is safe
[ ] If the modification is safe, add the safe to test label

How to trigger pipelines and use the bots:

Run the end to end pipeline
Annotate the pull request with the label: safe to test. If you want to run the pipeline again, remove and add it again.

Rebase the pull request
Comment with: /rebase.

Changes look ok to me, just can the minikube overlay be adjusted too?

Sure, done


Improve docstrings

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (3f53021) 100.00% compared to head (62532fe) 100.00%.

:exclamation: Current head 62532fe differs from pull request most recent head e4a03d7. Consider uploading reports for the commit e4a03d7 to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #164   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            6         6
  Lines          156       156
  Branches        34        34
=========================================
  Hits           156       156

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


See graph of 7 days older metric

I am not able to set retention policy to see graph of 7 days older metric, how to set policy to see historical data.

That would be in storage-schema.conf for carbon, explained here .
The sample one provided with the standard installation, that you can see here defines the following :
[carbon]
pattern = ^carbon\.
retentions = 60:90d

[default_1min_for_1day]
pattern = .*
retentions = 60s:1d

I'm actually surprised it's not more than that. How is yours configured?

@fauzankhanak - after updating storage schema you should delete old metrics and recreate wsp files.


Remove null reference possibility in hediff comp inspirational

Sorry for the double post. Changed files does not update on github unless I recreate the PR after fixing merge conflicts.  This one is just cleaning up the loading logic (fixes a few misconfigs along the way)

Preference against using 'case'; hediffcomp mostly unchanged.
Accepted class restriction changes


[BUG] Install script doesn't work

What happened:
The install script included in the repo is not valid
What you expected to happen:
Microshift gets installed
How to reproduce it (as minimally and precisely as possible):

wget script install.sh
sh install.sh

Anything else we need to know?:
Install fails because of function name
Environment:

Microshift version (use microshift version):
Hardware configuration:
OS (e.g: cat /etc/os-release):
Kernel (e.g. uname -a):
Others:

Relevant Logs

closing as we will be deprecating install.sh in the future