Asymmetric authentication

Is asymmetric authentication possible with windows credential provider. I'm asking because i couldn't find anything helpful about this topic.

What do you mean by asymmetric authentication?

By asymmetric authentication, I’m referring to an authentication model similar to SSH, where a user is authenticated by a private key. The Credential Provider would verify this key against a public key, enabling a password-less login. Is there a way for the Credential Provider to handle such an authentication using key pairs?

Credential providers only capture user authentication and pass it to LSASS. Inside LSASS an authentication package is what determines if a user is authorised to login or not.
https://learn.microsoft.com/en-us/windows/win32/secauthn/authentication-packages
So in your scenario you'd need a credential provider to interact with the user, and a auth package to know what to do with the material signed by the users key.
However that's only going to be good for a local login. Won't allow access to domain resources. AD supports password and x509 certificates (smart cards) only.

so from what i had read, x509 certificates are what im looking for. Does this library support it, as I couldn't find anything in samples or source code, only password type login.

sorry for bothering but are there any updates on this?

@LDzik sorry I missed your reply. This wraps the Windows Credential Provider framework, so any logon capture type would be supported, but I'm afraid I don't have examples for them.
The key to your scenario would be overriding  OnGetSerialization() and returning a native structure that contains your smart card creds.


First Experience Tutorial

We can easily detect that the user is running the program for the first time by the lack of the config. In that case we can play a small simple tutorial that walks the user through the feature of the program.

Duplicate of #148


Provide full path to additional files config

Provide full absolute path to additional files config so that Packer doesn't prefix it with the upstream path.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/approve


MINOR: add a space for kafka.metrics.polling.interval.secs description

As title, there should be a space between in and kafka.metrics.reporters words.

Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

fix 3.8 version document in this PR


Follow up for SPDM_ERROR_CODE_DECRYPT_ERROR.

Background: https://github.com/DMTF/libspdm/issues/488, https://github.com/DMTF/libspdm/issues/489
This is follow up for https://github.com/DMTF/libspdm/pull/519.
There are more cases to close session, such as GetMeasurement in session.
I think we need ensure all session messages handle this.
Or a better way is to have a generic place to handle SPDM_ERROR_CODE_DECRYPT_ERROR .

I will check it.


Updating the URL to the default Git repo

The URL to the default Git repo should be: https://.visualstudio.com_git<project>, instead of https://.visualstudio.com<project>_git<project>.

Thanks :+1:


grep provider preview breaks on input

Environment (please complete the following information):

OS: Arch linux 5.11.1-arch1-1
(Neo)Vim version: NVIM v0.5.0-dev+1115-gc1fbc2ddf
vim-clap version: 8b618fcbbee7cf30ce9d05be00706ddb558f96af
Have you reproduced with a minimal vimrc: yes
Have you updated to the latest plugin version: yes
Have you upgraded to/compiled the latest Rust binary: yes

Describe the bug
scrolling through :Clap grep with no input changes the preview window accordingly
once you input text the preview window is frozen
Clap debug

            has cargo: 1
            has maple: /home/zach/.local/share/nvim/site/pack/packer/start/vim-clap/target/release/maple
           maple info: version 0.1.23, built for x86_64-unknown-linux-gnu by rustc 1.51.0-nightly (44e3daf5e 2020-12-31).

         has +python3: 1
has py dynamic module: 1
            has ctags: ctags with JSON output support
    Current sync impl: Lua
     Current FileType: clap_input
Third Party Providers: []
       Global Options:
    let g:clap#autoload_dir = '/home/zach/.local/share/nvim/site/pack/packer/start/vim-clap/autoload'
    let g:clap#provider_alias = {'gfiles': 'git_files', 'hist:': 'command_history', 'hist/': 'search_history'}
    let g:clap_background_shadow_blend = 50
    let g:clap_current_selection_sign = {'texthl': 'ClapCurrentSelectionSign', 'linehl': 'ClapCurrentSelection', 'text': ''}
    let g:clap_disable_bottom_top = 0
    let g:clap_disable_matches_indicator = v:false
    let g:clap_disable_optional_async = v:false
    let g:clap_disable_run_rooter = v:true
    let g:clap_enable_background_shadow = v:true
    let g:clap_enable_debug = v:false
    let g:clap_enable_icon = 1
    let g:clap_forerunner_status_sign = {'done': '•', 'running': '!', 'using_cache': '*'}
    let g:clap_insert_mode_only = v:false
    let g:clap_layout = {'relative': 'editor'}
    let g:clap_multi_selection_warning_silent = 0
    let g:clap_no_matches_msg = 'NO MATCHES FOUND'
    let g:clap_open_action = {'ctrl-v': 'vsplit', 'ctrl-x': 'split', 'ctrl-t': 'tab split'}
    let g:clap_open_preview = 'always'
    let g:clap_popup_border = 'rounded'
    let g:clap_preview_direction = 'LR'
    let g:clap_preview_size = 5
    let g:clap_providers_relaunch_code = '@@'
    let g:clap_search_box_border_style = 'nil'
    let g:clap_search_box_border_symbols = {'nil': ['', ''], 'curve': ['', ''], 'arrow': ['', '']}
    let g:clap_spinner_frames = ['🌑', '🌒', '🌓', '🌔', '🌕', '🌖', '🌗', '🌘']
  Provider Variables:
                     []

Screenshots

i can reproduce this behavior on 2 machines (though they are mostly similarly configured).
hmm, the preview window seems to be broken for me with several providers.. i'll do more digging. the issue might be local to me

hmm after messing with my settings, i can't reproduce this bug anymore, even with an identical configuration. closing, i'll reopen with more details if i can reproduce this again. sorry for the trouble

ah, setting     vim.g.clap_enable_icon = 1 breaks it

I always enable the icon, no issues, please provide a minimal vimrc to reproduce.

this combination
vim.g.clap_enable_icon = 1
vim.g.clap_provider_grep_enable_icon = 1

produces the expected behavior but this
vim.g.clap_enable_icon = 1
vim.g.clap_provider_grep_enable_icon = 0

does not.
i will provide detailed steps to reproduce tomorrow

Now I can reproduce this issue, please try #649.


Update to Scala 2.13

Updates the code to Scala 2.13. It also adds automatic launching of a dynamo docker container from the tests.

Removed adding docker support in the tests since travis already covers that


create HoH db and users in the init postgres job

Signed-off-by: myan<EMAIL_ADDRESS>Reference: https://github.com/stolostron/backlog/issues/24506

/cc @clyang82 @morvencao


Make decoders functions, not classes

Decoders are implemented as classes, but are usually used as functions.  Therefore, it would be better to make them functions.
However, as with pipeline operators, it is still possible to make a class and provide a __call__ member to have a class emulate a function if there is need for decoder persistent state.

I find that more often than not I end up adding various helper functions to Decoder objects (ex. to offer a default initializer, or properties to indicate dimentionality of phenomes, etc.).  So I'd lean toward the __call__ approach.


Docs

Awesome. Feel free to land stuff without being blocked on me when my input seems unnecessary. I can't be responsive enough anyway.


Fix xGroupResoure Integration Test failures due to missing System.DirectoryServices.AccountManagement

Pull Request (PR) description
Fixes issue in xGroupResource Integration tests where the tests would fail if the System.DirectoryServices.AccountManagement namespace was not loaded.
This Pull Request (PR) fixes the following issues
None
Task list

[x] Added an entry under the Unreleased section of the change log in
CHANGELOG.md. Entry should say what was changed, and how that affects
users (if applicable).
[ ] Resource documentation added/updated in README.md.
[ ] Resource parameter descriptions added/updated in README.md, schema.mof
and comment-based help.
[ ] Comment-based help added/updated.
[ ] Localization strings added/updated in all localization files as
appropriate.
[ ] Examples appropriately added/updated.
[ ] Unit tests added/updated. See
DSC Resource Testing Guidelines.
[x] Integration tests added/updated (where possible). See
DSC Resource Testing Guidelines.
[x] New/changed code adheres to
DSC Resource Style Guidelines and Best Practices

This change is

Codecov Report

Merging #602 into dev will not change coverage.
The diff coverage is n/a.

@@         Coverage Diff         @@
##            dev   #602   +/-   ##
===================================
  Coverage    74%    74%
===================================
  Files        27     27
  Lines      4078   4078
  Branches      4      4
===================================
  Hits       3038   3038
  Misses     1036   1036
  Partials      4      4


DCOS-48222: TypeError: Failed to execute 'selectAllChildren' on 'Selection': parameter 1 is not of type 'Node'.

Check if the function exists before we try to
call it.
Closes https://jira.mesosphere.com/browse/DCOS-48222
Testing

Verify that the check makes sense given the error.
(Optional) Add global.document.getSelection().selectAllChildren = 0; to the first line of the selectAll function in ClickToSelect. Open the install cli modal from the top right corner and verify that clicking on the snippet does not produce any console errors as it would otherwise.

Trade-offs
The sentry error has disappeared, so we can only guess what caused this.
Dependencies
None.
Screenshots
None.

:tada: This PR is included in version 2.139.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Branded colormap options

Hi all,
I've created three Cal-Adapt Analytics Engine branded colormaps for us to use when displaying our data. Options:

ae_orange : broadly represents increasing positive values, but also temperature-related/radiation variables, my vote for our default colormap
ae_blue : broadly represents negative values, but can also be for moisture-related variables
ae_div : diverging colormap option that utilizes both ae_orange and ae_blue colors; can be used for wind-related variables, pressure (while pressure doesn't diverge, it is commonly. plotted as such for high/low pressure), as well as any anomaly display

Because visualizations touch on many files, I'll need guidance/assistance on 'behind-the-scenes' implementation in climakitae (thinking specifically the explore/explore2.py, visualize.py, and threshold_tools.py scripts, could be missing others). But for now, to implement the new colormaps, you can add the following code (example using ae_orange):
import numpy as np
import matplotlib.colors as mcolors
ae_orange = pkg_resources.resource_filename('climakitae', 'data/cmaps/ae_orange.txt')
ae_orange_data = np.loadtxt(ae_orange)
ae_orange_cm = mcolors.LinearSegmentedColormap.from_list('ae_orange_cmap', ae_orange_data, N=256)

Examples of what this looks like from explore_warming notebook below:

Maybe add a CR+LF to each of these files to comply with our style guide?


[8pt] Add south Alaska to HAND processing

A list of south Alaska HUCs is coming and need to be included in our BED runs.
All inputs should be there, but this card is to prove that those HUCs will process correctly.

Ok. no problem. Emily.. I can start getting you the DEM's and pick up where we left off

Yes, we will want to store the Alaska data as 3338. Rob, I think it would be best for you to get the data set up and then Emily can work out the kinks from there.

@EmilyDeardorff : Can you figure out what HUC8's are now going to be used for Alaska?  As Carson mentioned it will be the HUC 2 of 19 (HUCs starting with 19), but we don't need all of Alaska. Only the HUCs 8 that we have NWM stream data for.

Liliana probably also knows which HUCs are the ones we need for Alaska covered by NWM v3.

The HUC8_Alaska_NWMv30 shapefile that Alemayehu sent us on Sept 22 contains these HUCs: 19020202, 19020301, 19020602, 19020203, 19020302, 19020800, 19020201, 19020104, 19020601, 19020401, 19020103, 19020402, 19020505, 19020503, 19020504, 19020102, 19020101, 19020502, 19020501
Does that look right?

oh  ya. Can you compare those HUCs to the streamlines and makes sure it matches?  But yes, I think that has it. I will work this week on getting you some DEMs in 3338 for those HUCs.

'Lake' column issue (2/28/24)
The NWM streams geopackage did not have the 'Lake' attribute like it was supposed to. It turns out that data was there, just in a column titled 'NHDWaterbodyComID'. To resolve, I created a column called 'Lake' in the NWM streams Alaska geopackage (which is an input to the pre-clip processing).
Incorrect CRS for Alaska (2/28/24)
The default FIM projection is not correct to use for Alaska. To resolve, I added logic to a few scripts to assign the CRS variable depending on whether it is an Alaska HUC or not.
DEM domain geopackage not matching Alaska CRS (2/29/24)
The input DEM domain (input_DEM_domain=${inputsDir}/3dep_dems/10m_5070/HUC6_dem_domain.gpkg) was not a compatible CRS with the Alaska data (even though the polygon does include Alaska). To resolve, I added logic to a few scripts that uses the Alaska DEM domain (inputs/3dep_dems/10m_South_Alaska/23_11_07/DEM_Domain.gpkg) if the Alaska HUC is detected.

Future Work: Need to get USGS gages for Alaska (3/4/24)
With the recent in the dev-fim-pipeline-alaska branch, the FIM pipeline has run to completion for the first time. Most of the outputs look as expected, with the exception of some USGS outputs (listed below). This is to be expected because our inputs do not currently contain the USGS gages for alaska. Eventually, we will want to add another USGS gages file that contains that data for Alaska.

FIM pipeline outputs summary:

HUC folder is missing:

usgs subset gages
usgs subset gages 0
usgs elev table
3d nld subset levees burned

branch 0 folder is missing:

usgs elev table

branch folder is missing:

usgs elev table

Branch Zero Inundation of the Matanuska River near Palmer, Alaska

input flow for every branch was set to 890 CMS, which is the 20% AEP flow for the Matanuska R at Palmer AK USGS gage
the cross-hatched area marks the boundary of HUC 19020402
mosaic or branch inundation is not included in this image

Branch zero inundation near the Matanuska River at Palmer AK - USGS gage 15284000

High stream density leading to too many branches in HUC 19020402
Running the FIM pipeline on HUC 19020402 (Matanuska River near Palmer, Alaska) resulted in 867 branches being generated. The expected number of branches for a HUC is more like 20-40 branches. This unexpected behavior can be attributed to an overly dense network of streams being fed into the model. The figures below shows that the intensity of this issue varies between HUC.

50% AEP Alaska inundation after mitigating stream density issue
These results are using preliminary AEP flow data.

Matanuska River near Palmer, AK

Eagle River, AK

Anchorage, AK

Anchorage, AK

Trapper Creek, AK

Rude River, AK


Miff master patch 1

Advantage 360 Pro PR template
What's changed:
Why has this change been implemented:
What (if any) actions must a user take after this change:

Sorry. I don't know what I'm doing.


Logfire with Celery ingores token

Description
Hello!
I'm running pytest with Celery (5.4.0) worker in Docker containers without a token and after each task I get the following output:
celery-worker-test-1  | 2024-12-07T11:16:39.350795862Z Traceback (most recent call last):
celery-worker-test-1  | 2024-12-07T11:16:39.350805992Z   File "/usr/local/lib/python3.10/site-packages/opentelemetry/context/__init__.py", line 154, in detach
celery-worker-test-1  | 2024-12-07T11:16:39.350810430Z     _RUNTIME_CONTEXT.detach(token)
celery-worker-test-1  | 2024-12-07T11:16:39.350814298Z   File "/usr/local/lib/python3.10/site-packages/opentelemetry/context/contextvars_context.py", line 50, in detach
celery-worker-test-1  | 2024-12-07T11:16:39.350817965Z     self._current_context.reset(token)  # type: ignore
celery-worker-test-1  | 2024-12-07T11:16:39.350821411Z TypeError: expected an instance of Token, got None
celery-worker-test-1  | 2024-12-07T11:16:39.521499430Z [2024-12-07 11:16:39,521: ERROR/ForkPoolWorker-7] Failed to export batch code: 401, reason: {"detail":"Invalid token"}
celery-worker-test-1  | 2024-12-07T11:16:47.664289545Z [2024-12-07 11:16:47,664: ERROR/ForkPoolWorker-7] Failed to export batch code: 401, reason: {"detail":"Invalid token"}
celery-worker-test-1  | 2024-12-07T11:16:47.724731606Z [2024-12-07 11:16:47,724: ERROR/ForkPoolWorker-8] Failed to export batch code: 401, reason: {"detail":"Invalid token"

Moreover, even if there is a token (and I'm actually receiving logs from virtual machine), the same warning appears in Celery logs after each tasks proceed.
[2024-12-07 11:30:00,026: ERROR/ForkPoolWorker-1] Failed to detach context
Traceback (most recent call last):
  File "/usr/local/lib/python3.10/site-packages/opentelemetry/context/__init__.py", line 154, in detach                     _RUNTIME_CONTEXT.detach(token)
  File "/usr/local/lib/python3.10/site-packages/opentelemetry/context/contextvars_context.py", line 50, in detach           self._current_context.reset(token)  # type: ignore
  TypeError: expected an instance of Token, got None

Python, Logfire & OS Versions, related packages (not required)
Logfire info from local PC
logfire="1.2.0"
platform="Windows-10-10.0.26100-SP0"
python="3.11.9 (tags/v3.11.9:de54cf5, Apr  2 2024, 10:12:12) [MSC v.1938 64 bit (AMD64)]"
[related_packages]
requests="2.32.3"
pydantic="2.7.1"
fastapi="0.115.0"
protobuf="4.25.5"
rich="13.9.2"
executing="2.1.0"
opentelemetry-api="1.27.0"
opentelemetry-exporter-otlp-proto-common="1.27.0"
opentelemetry-exporter-otlp-proto-http="1.27.0"
opentelemetry-instrumentation="0.48b0"
opentelemetry-instrumentation-asgi="0.48b0"
opentelemetry-instrumentation-celery="0.48b0"
opentelemetry-instrumentation-fastapi="0.48b0"
opentelemetry-instrumentation-sqlalchemy="0.48b0"
opentelemetry-proto="1.27.0"
opentelemetry-sdk="1.27.0"
opentelemetry-semantic-conventions="0.48b0"
opentelemetry-util-http="0.48b0"

Logfire info from VM
logfire="1.2.0"
platform="Linux-6.8.0-40-generic-x86_64-with-glibc2.36"
python="3.10.16 (main, Dec  4 2024, 20:37:22) [GCC 12.2.0]"
[related_packages]
requests="2.32.3"
pydantic="2.7.1"
fastapi="0.115.0"
protobuf="4.25.5"
rich="13.9.2"
tomli="2.0.2"
executing="2.1.0"
opentelemetry-api="1.27.0"
opentelemetry-exporter-otlp-proto-common="1.27.0"
opentelemetry-exporter-otlp-proto-http="1.27.0"
opentelemetry-instrumentation="0.48b0"
opentelemetry-instrumentation-asgi="0.48b0"
opentelemetry-instrumentation-celery="0.48b0"
opentelemetry-instrumentation-fastapi="0.48b0"
opentelemetry-instrumentation-sqlalchemy="0.48b0"
opentelemetry-proto="1.27.0"
opentelemetry-sdk="1.27.0"
opentelemetry-semantic-conventions="0.48b0"
opentelemetry-util-http="0.48b0"

Which celery signal are you using to add the logfire.configure()?

This looks relevant: https://github.com/open-telemetry/opentelemetry-python/issues/4163#issuecomment-2329836974

Which celery signal are you using to add the logfire.configure()?

My logfire.configure()
logfire.configure(
    send_to_logfire="if-token-present",
    token=settings.LOGFIRE_TOKEN or None,
    service_name=settings.MODE,
    console=False,
)

The docs are using worker_init signal, not the worker_process_init.
I did a refactor of that part of the docs, and I think before it was worker_process_init, then I got this report on private, and changed the docs. 😅

@chrnmaxim Were you able to read my last comment? 👋

@chrnmaxim Were you able to read my last comment? 👋

Hi there!
Thanks for the answer! Even when I visited the docs to add the link, I didn't notice the difference 😅
Yes, I tried to configure Logfire with Celery according to the current version of the docs, but the problem still exists for me when running tests locally in Docker. I'll try it from VM just to make sure there is no problem with local Docker configure and let you know.

@chrnmaxim Were you able to read my last comment? 👋

Well, I checked it on VM and the problem still exists, despite updated config. But there is a token and I'm actually receiving logs in Logfire.
[2024-12-11 05:30:04,687: ERROR/ForkPoolWorker-2] Failed to detach context
Traceback (most recent call last):
  File "/usr/local/lib/python3.10/site-packages/opentelemetry/context/__init__.py", line 154, in detach
    _RUNTIME_CONTEXT.detach(token)
  File "/usr/local/lib/python3.10/site-packages/opentelemetry/context/contextvars_context.py", line 50, in detach
    self._current_context.reset(token)  # type: ignore

Logfire config:
@worker_init.connect()
def init_celery_tracing(*args, **kwargs):

    logfire.configure(
        send_to_logfire="if-token-present",
        token=settings.LOGFIRE_TOKEN or None,
        service_name=settings.MODE,
        console=False,
    )
    logfire.instrument_celery()

Try pip install -U 'logfire[celery]'. opentelemetry-instrumentation-celery="0.48b0" is out of date and I think this was fixed since then.

Try pip install -U 'logfire[celery]'. opentelemetry-instrumentation-celery="0.48b0" is out of date and I think this was fixed since then.

I updated logfire to 2.7.0 adnd opentelemetry-instrumentation-celery="0.49b2" and finally there is no error.
Thank you!


Added api-server.py

Runs either the jsonrpc api or the notificationapi

Coverage remained the same at 75.7% when pulling 05c08e1242b4a892647de04d023820590c918ef7 on pyapi into ab863e537556d0d5794b20adfe97101c6032ea1d on development.

Don't merge this, yet ;)


Direct feed from GPU memory in Java

PR adds 2 things to Java API:

allocating tensor in GPU (GPUBFCAllocator)
directly feeding tensors allocated in GPU (makeCallable/runCallable with CallableOptions)

Originally posted as a feature request #37909.
Testing:

bazel test //tensorflow/java:DirectSessionTest //tensorflow/java:GPUTensorTest

It might not be the best implementation. Please, review and advise.
Thanks

I should handle these by the weekend

Quick question, is TF JNI going to be deprecated in favor of JavaCPP?

I will have to ask internally and see what are the plans.

Hi, any updates, comments or advice?
Thanks

As long as it's exposed to the C API, the SIG-JVM will be happy to merge this.
/cc @karllessard

We'd need to doe some ifdefs around various pieces to remove the cuda specific parts from the jni files when compiling the CPU build. For example the include of cuda_runtime_api.h isn't guarded and so probably won't compile on CPU only machines.
Have you checked the behaviour of this code on CPU only builds?

@sjamesr  Could you please have a look at this PR? Thank you!

@gbaned , @sjamesr is not working for TensorFlow anymore and the TF Java project efforts has been migrated to this repository. It would be interesting if the following patch can be migrated to the new codebase so we (SIG JVM) can review it and merge it.

@okdzhimiev  Can you please check @karllessard's comments and keep us posted ? Thanks!

@gbaned I haven't followed TF development for quite a while. Would be great if somebody take this over.

@karllessard's comments sound good.
Also, what was missing are ifdefs for non-CUDA builds - see @Craigacp's comment.

@okdzhimiev, @Craigacp Can you please migrate this patch to new codebase as mentioned @karllessard in the above comment.

The current PR exposes bare pointers to users and uses JNI which SIG-JVM has moved away from to JavaCPP. This patch will require essentially a complete rewrite for the new codebase. Some of the JNI portions could be converted into pure C++ which was then wrapped and exposed for use with JavaCPP, or we could have some way of checking if the JavaCPP binding for CUDA is in the classpath and then mirror the logic into Java (using reflection probably so it doesn't crash on CPUs). The Java level API would need to be different. If @okdzhimiev wants to work on porting it over to the new codebase then we can discuss it in a PR on https://github.com/tensorflow/java, otherwise we should open an issue there to provide equivalent functionality. Not sure when we'd get around to doing it though.

@gbaned Is there now a way to access buffers in GPU memory through the stable C/C++ API? If we can do it in C/C++, we can do in Java, that's not a problem, but I was under the impression that this was still not supported, in which we may not want to have this in TF Java, until this becomes possible with the stable C/C++ API that is.

It has been 14 days with no activity and the awaiting response label was assigned. Is this PR still valid? Assigning the stalled label. Please comment to reassure me that this is still being worked on.

@karllessard Can you please take a look on above comments from @Craigacp, @saudet. Thanks!

Karl, Samuel and I are all members of SIG-JVM, but we can't do anything without moving this patch over to https://github.com/tensorflow/java and rewriting it.

@karllessard Any update on this PR? Please. Thanks!

@karllessard Any update on this PR? Please. Thanks!

Hi @gbaned , like @Craigacp mentioned previously, nobody from SIG JVM is planning to work on this anytime soon. If the author (@okdzhimiev) is interested in rebasing his PR on the new repo for TF Java (https://github.com/tensorflow/java), it would certainly help but I think we should close this one.


Fixed older node-fetch dep by the fbjs dependnecy used by React

Coverage decreased (-0.02%) to 57.214% when pulling 561d968ecdebb2867d1c721e0c29ff96072d7806 on jwilaby/node-fetch-fix into e0793418bf73b2f856e56ce7c49969ed33c4327f on master.

Works on my end after packaging:

Can we get an approval even with a 2/100th of a percent drop in coverage?

@justinwilaby I'll bump it up to 0.05% as the threshold.


Added documentation for tls_min_version, tls_cipher_suites, and tls_p…

…refer_server_cipher_suites
Updated the config.json.js variable names from vault_ to consul_

Thanks!


Retry connecting to device in CI after lost connection

Sometimes ios-deploy loses connection to the device after installing, starting debugserver, and launching. This is shown with an error message like:
Process 579 exited with status = -1 (0xffffffff) lost connection

This happens frequently in our CI system: https://github.com/flutter/flutter/issues/120808
Usually in CI, on retry it'll work and pass - so this is an attempt to retry without failing the test first. It's not guaranteed to fix since we're unable to recreate this error locally.
Pre-launch Checklist

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[x] I signed the CLA.
[ ] I listed at least one issue that this PR fixes in the description above.
[x] I updated/added relevant documentation (doc comments with ///).
[x] I added new tests to check the change I am making, or this PR is test-exempt.
[x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Google testing seems to be failing on something unrelated. I tried clicking "Re-run" but hasn't done anything yet. I'll give it a little time and if not, I'll update the branch to trigger it to rerun.

BTW, your google testing failure looks like a bug with FRoB. I chatted with the release team who is on it, I think they are going to put out a PSA soon.

BTW, your google testing failure looks like a bug with FRoB. I chatted with the release team who is on it, I think they are going to put out a PSA soon.

Thanks for the heads up!


Simple Persistent Storage implementation

Moved across and ported to typescript some of the internal stuff that we have in backstage that uses localStorage. This is a simple interim solution to power things like #990.
Closes #1060

:heavy_check_mark: Checklist

[ ] All tests are passing yarn test
[ ] Screenshots attached (for UI changes)
[ ] Relevant documentation updated
[ ] Prettier run on changed files
[ ] Tests added for new functionality
[ ] Regression tests added for bug fixes

This PR is set as Draft just now as our library didn't have tests that I can move across, so I need to spend some time writing some tests for this and then it's ready for merge

Just noting that changing the API surface will create more work for internal plugins owners that want to publish their plugins as open source.

@Rugvip what do you think the API should look like here? The same but just all async functions and the ability to subscribe to changes?

@benjdlambert something like that, along with a separate hook that wraps it all up and makes it easy to consume in components.

@stefanalund as long as the hook consumption pattern doesn't change drastically I think we're good. There's not an un-refactorable amount of usage internally :grin:

@Rugvip wanna take a look at: https://github.com/spotify/backstage/pull/1064/files#diff-36b1b787a3b06c5e362a4eb2ad4f3bb1R1-R91 does this make more sense?


Added Terrartisan

Added new game, Terrartisan

Nice addition, thanks!
Would you please consider adding a dot character "." at then end of the line, right after the author name ?

Done ;)

Thanks!


Fixed cellular link

Fixed cellular link
Change-type: patch

Please make sure to read the CONTRIBUTING document before opening the PR for relevant information on contributing to the documentation. Thanks!

@balena-ci I self-certify!


Add icon feature

Hi, thanks for this nice plugin
I think it will be good to add a method for icon feature.

OK, I develop it.


Have named suffix for instance console log

This allows us to easily identify/find/archive console logs
from failed runs.

Looks good, thanks!


Keep track of open xhrs and only flush if there aren't too many

To help prevent barometer's requests holding up the application's requests we could keep track of open xhrs and only send the buffer if less than a specified number are open.

Currently we wait at least 5 seconds between flushing the buffer and timeout each XHR request after 4 seconds. It shouldn't be possible to ever have more than one request in-flight at once.

I mean keep track of other requests so we don't complete with the application for what might be limited band width.

Ahh interesting. Great idea :+1:


L5 - Method 'hasScope' only accepts a string as argument.

I have to modify the hasScope method of the Authorizer class to make it work with Laravel 5.
The internal hasScope method of the oauth server only supports scope checking with the scope id (string) not with multiple values (array).

Went with my own implementation and updated the tests as well. Thanks for reporting and contributing!


No Control for Signage Displays

Hi everybody. My office has me investigating a couple TVs for a large installation here. One is the Samsung QB65H-N, one of their commercial panels, and we'd hope it would be network controllable.
Sadly, not so much.
samsungctl looks promising, but doesn't seem to interface with the screen at all. It can get it up on the network, and an nmap reveals this:
Starting Nmap 7.40 ( https://nmap.org ) at 2019-09-16 12:38 EDT
Nmap scan report for <IP_ADDRESS>
Host is up (0.0045s latency).
Not shown: 65531 closed ports
PORT      STATE SERVICE
1515/tcp  open  ifor-protocol
9197/tcp  open  unknown
38485/tcp open  unknown
40000/tcp open  safetynetp

Nmap done: 1 IP address (1 host up) scanned in 5.26 seconds

Okay, potentially promising. However, none of those ports responds to samsungctl for either legacy or websocket control. If I curl them, I only get a SOAP reply on port 9197.
$ curl http://<IP_ADDRESS>:9197
<?xml version="1.0"?><s:Envelope xmlns:s="http://schemas.xmlsoap.org/soap/envelope/" s:encodingStyle="http://schemas.xmlsoap.org/soap/encoding/"><s:Body><s:Fault><faultcode>s:Client</faultcode><faultstring>UPnPError</faultstring><detail><UPnPError xmlns="urn:schemas-upnp-org:control-1-0"><errorCode>402</errorCode><errorDescription>Invalid Args</errorDescription></UPnPError></detail></s:Fault></s:Body>

This seems to tell me this unit just doesn't support the type of control samsungctl does? Or is there some magic dance I need to do to enable it? Any guidance is appreciated. Our other option is an LG unit that supports SNMP (yay) but requires an NDA to get any documentation on it (BOO!)

This could be a UPNP API (Assuming on the xml tags)
Have you tried to control the panel via a UPNP software/requests ?
Some UDP Broadcasts from that display?
Also what are you want to do with the Smart Signage panel ?
They can be controlled via "MagicInfo Server" from samsung.
Perhaps you can do some reverse engineering...?

Hi! I had the same issue with my home info display (Samsung QB13R-T). I tried also the free (up to 25 devices) "Magicinfo Server" but that didn't seem to fit my purpose. Samsung has actually quite good documentation on MDC protocol and I ended up using that one to control my display power state. If you're interested in more details, I have written a blog post about this:
https://jb1c.blog/2020/07/08/controlling-samsung-signage-qb13r-t-based-on-unifi-protect/


⚠ Bofrost.be has degraded performance

In 93fad84, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 1761 ms

Resolved: Bofrost.be performance has improved in b7f4eb7 after 6 minutes.


Efficiently look up lines/columns of many nodes

Fixes #179, adds FilePositionMap
This assumes that requested offsets will be close to previous requests,
which should be true if this is used while walking a tree, etc.
Future tasks if the basic design is solid:

copy license to new files
Document this in the public API
Deprecate PositionUtilities or make those APIs use FilePositionMap?
(E.g. cache FilePositionMap in a static variable,
and use $text is === as previous request)

Please add the license block to the new files, then I'll merge it

@roblourens It's added :)


Add VM-Install-Proxy-Execution

For common and more involved install mechanisms there should exist a helper function like VM-Install-Raw-GitHub-Repo etc.
See https://github.com/mandiant/VM-Packages/wiki/Contributing#example-4 for a good candidate of tools run via cmd.exe, for example.

Oh I like this! Then we could also have a function argument, or environment variable, that allows you to specify your preferred proxy execution mechanism (e.g., cmd or powershell). @Ana06 you had mentioned something like this before

Similar to #2

I think this has already been address. @mr-tz can we close this issue?


Broken on todomvc.com

Visiting: http://todomvc.com/examples/aurelia/
Results in no UI for me on the latest Firefox on Linux.

Thank you for reporting this. It's known and already addressed/fixed here:
https://github.com/tastejs/todomvc/issues/1492
But I am waiting for https://github.com/tastejs/todomvc/pull/1545 to be picked.


Contribute to rhai org?

Hi, I'm wondering if you would be interested to contribute this into the rhai org.

Hi, awesome! Let's proceed.

I need to be a member of the org to transfer the repo. I'd like to remain the admin of this repository if possible.

OK, I've sent you a member invitation.  Let me know if you need anything else.

I've migrated the repo under the rhaiscript organization, but I miss the admin permissions.
Also, we might want to create a rhai https://hex.pm/ account and transfer the elixir package there as well.

I've migrated the repo under the rhaiscript organization, but I miss the admin permissions. Also, we might want to create a rhai https://hex.pm/ account and transfer the elixir package there as well.

I'll make you admin right away.

Do you think it is possible to rename the repo to rhai-rustler to be consistent with naming?

I think it would be confusing since rhai_rustler is the name of the elixir package as well. Elixir packages have usually snake cased names:
https://hex.pm/packages

That's fine with me!  OK closing this.  Thanks for your contribution!


React fe unit tests

[ ] I have added the tests to cover my changes.
[ ] I have updated the documentation and CHANGELOG accordingly.
[ ] I have read the CONTRIBUTING document.

React front end unit test cases for most of the components. Please note that the components might not have 100% coverage and this PR is only to kickstart the unit testing for front end.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.2 out of 3 committers have signed the CLA.:white_check_mark: Kamalesh-suresh:white_check_mark: Prasy12:x: amalanpsiogYou have signed the CLA already but the status is still pending? Let us recheck it.

@wjcunningham7 @santoshkumarradha This PR is the first step for react unit tests to move out of the "0%" coverage. Please note that this might not have 100% coverage. Currently the code coverage is close to 70% . We will keep increasing this in the future releases.


[run-tests] [fix][client] When the compressed message size exceeds maxMessageSize, the information in the InvalidMessageException may be incorrect

This PR is for running tests for upstream PR https://github.com/apache/pulsar/pull/17910.

/pulsarbot run-failure-checks


Playstore warning for using app permissions in manifest android

Timeline
Now: Remove Photo and video permissions permission or submit declaration
If your use of Photo and video permissions is not permitted according to Google Play policy, you must remove it from your app. If your app has a legitimate reason for using Photo and video permissions, you must submit this declaration between now and the compliance deadline.

Playstore showing warning ,whether this package using this permissions ,if its using please remove in next release

No, there is no permission here: https://github.com/pichillilorenzo/flutter_inappwebview/blob/master/flutter_inappwebview_android/android/src/main/AndroidManifest.xml
check your own Android manifest.xml permissions or check other dependencies.

ok Thanks


gherkin: Add another Russian translation for "scenario outline"

Summary
This PR adds another Russian term for "Scenario outline" - "Шаблон сценария" (scenario template).
Details

Motivation and Context
Improve Russian translation.
I think "Шаблон сценария" conveys the meaning better than the existing translation.
How Has This Been Tested?
N/a

Screenshots (if appropriate):
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue).
[x] New feature (non-breaking change which adds functionality).
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected).

Checklist:

[x] The change has been ported to Java.
[x] The change has been ported to Ruby.
[x] The change has been ported to JavaScript.
[x] The change has been ported to Go.
[x] The change has been ported to .NET.
[ ] I've added tests for my code.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have updated the CHANGELOG accordingly.

Thanks! We also need an entry in the CHANGELOG.md file.

Hey @hkosova 🙂
Thanks again for your contribution 👍
Do you think you could quickly update the changelog please?

@aurelien-reeves done

Thank you!

Hi @hkosova,
Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 🍾
In return for this generous offer we hope you will:

✅ Continue to use branches and pull requests. When someone on the core team approves a pull request (yours or someone else's), you're welcome to merge it yourself.
💚 Commit to setting a good example by following and upholding our code of conduct in your interactions with other collaborators and users.
💬 Join the community Slack channel to meet the rest of the team and make yourself at home.
ℹ Don't feel obliged to help, just do what you can if you have the time and the energy.
🙋 Ask if you need anything. We're looking for feedback about how to make the project more welcoming, so please tell us!

On behalf of the Cucumber core team,
Aslak Hellesøy
Creator of Cucumber


MaterialAdminTimeWidget not working properly.

forms.TimeField(
    widget=widgets.MaterialAdminTimeWidget,
    disabled=True,
)

Will generate a time widget field with 2 icons, the first to open the popup and second to set to the current time. None of them works. However, if the user clicks on the field it does work.
It is also showing below the field instead of inside the field as the DateWidget.

Can you give more information about the issue, from my side it works properly, couldn't reproduce it

Since last update, my date field has the same strange behaviour:

Buttons are outside of the input and don't work on my custom Form (not ModelForm) inside a Formset.
Date field was working properly before.


Scaling Council

Naruto Unison needs a Council of people in charge of ensuring all the numbers are fair, fun, and balanced. These people would not necessarily need any coding experience. Lots of numbers in the project at present are basically placeholders awaiting the formation of a Council, including:

DNA prices of Reanimated characters
DNA rewards for winning, losing, first-game-of-the-day, etc.
Mission objective goals
XP system
Effects of hidden skill-rating user field on matchmaking

The Council would also be responsible for character balancing. I think it would be neat to have some sort of democratic element to the proceedings, but I'm not sure what that would look like.

I would like to work on mission objective goals.

I would like to be on the council as well, I’m well versed in balancing and where numbers should be.

i would also like to join the charracter balancing team and the XP/ hidden skill rating matchmaking. Not sure about the other parts as i haven't been able to check this since ~100 commits, i'll try to catch up when i can.

Oh, cool! I wasn't expecting any interest in this pre-alpha release. I'll set something up on the project wiki and post a link to it here. Probably later today.

Perhaps we should make a discord server for council.

No Discord yet. Until alpha release, everything stays transparent and publicly accessible on the repository.

Yo! Id like to work on balance, and i have some experience as a moderator, so i hope i can help u with that, too. :)

Having given this a lot of thought, I've decided that until alpha release and the accompanying infrastructure, all scaling will occur through first-come, first-serve pull requests. If there is a number you want to change, just go into the code, change it, and submit the change as a pull request. This is also the perfect opportunity to contribute to the repository, even if you don't have much programming experience!
For example, if you want to change the DNA cost of a character, go to their file (in src/Game/Characters/Reanimated/) and edit the Character.price field (the number at the bottom of their entry).
As a more in-depth example, let's say you want to change the amount of destructible defense Orochimaru must destroy with Kusanagi in order to complete an objective for unlocking Orochimaru (S) from 200 to 100.

to
Reach 100 Career
"Destroy 100 total destructible defense with [Kusanagi]."

If you have requests/suggestions for new missions or new kinds of mission objectives (including character-specific ones), or if you think a mission objective isn't fun and should be replaced with something else, but you don't want or know how to implement it on your own, just leave a comment on #13 and I'll add it in.
I hope all of this makes sense!

Actually, I do have one question for all of you, because it's something I've been torn about. I made a system so that when someone copies a skill, the effects from that skill end when the copy does. For example, if Fū uses Mind Transfer Puppet Curse to copy Orochimaru's Major Summoning: Manda for 4 turns and uses it, his Manda will disappear after 4 turns when the copy expires. To offset this nerf, copied skills would have no chakra cost, in order to avoid the frustrating situation of copying a skill but not being able to use it. The idea is to make copying more reliable, and less prone to semi-random chances of gaining huge unfair advantages.
Compared to the way Naruto Arena did it, does this seem like an improvement? An argument could be made that semi-random chances of gaining huge unfair advantages is precisely the point of copying skills. It's also a bit more complicated this way, and I'm opposed to pointless complexity, so that's another negative.

It seems more logical to me that if the skill is copied, it should require the same amount of chakra to be used as of the character who has the skill. Also a permanent copy of the skill seems better in my opinion rather than 4 turns, this adds more strategical thinking on which skill to copy for your advantage. You could also add a moment of predicting your opponent's strategy for copy skill making it usable only once, so if it was used and the targeted character did nothing during that turn, you get punished.
You could also add channeling skill, which mirrors an opponent's skill. So for example if Orochimaru is being trapped by a channeling skill while using Manda Summoning, he will also get damaged by Manda Summoning skill and the character who used the channeling skill will get buff from Manda Summoning the same way Orochimaru does.

Tbh, i dont think its an unfair advantage (about if u copy Manda and use it and then it lasts forever). but when it ends after ending his copy effect, i think this should sound as an conditional effect, like "Fuu will copy a skill from his opponent for 4 turns, during this time, if that copied skill is used, this will be ended when Fuu copy effect ends" and then it costs no chakra as a boost. But this is only my opinion, im not sure bout if it's fair or not.
Ops: Sorry for my bad english, im not that good at speaking xD.

It would be interesting to test that idea out. But for now i feel like the old n-a version is better. Making it cost 0 but last 4 turns seems like it would feel a but awkward. That would made copies a bit too predictable as most players would target the more expensive skill users. F.E. every game where you have a copy and enemy team has something like hanabi sakura oro ( bad team but just f.e.) you would most surely try to copy oro, to which everyone can counter play by just not using his 45 skill

A clear consensus! Thank you all for your feedback.


Improve name of exported file

Currently it exports it using an id that is not human friendly, and it also doubles the extension on  it. E.g. 0a6ded3b-658b-49b6-8dd8-d81d4aa54040.png.png
We can simply use the image title, making sure we remove any existing file extension on it.

The name should be prompted to the user like on other software.

The name should be prompted to the user like on other software.

The prompt could be used for other options like adding annotations or not (c.f. see https://github.com/zakodium-oss/pixelium/issues/119)
I made a typo in my first message (edited since). I meant you should use the file name using the image's title.


Minor Documentation Typo

https://github.com/lepture/mistune/blame/14ce757ba0ff1f0d78c9f71f193ec4e3072c4836/docs/advanced.rst#L22
https://mistune.readthedocs.io/en/latest/advanced.html#use-renderers
class MyRenderer(mistune.HTMLRenderer):
    def codespan(self, text):
        if text.startswith('$') and text.endswith('$'):
            return '' + escape(text) + ''
        return '' + escape(text) + ''

# use customized renderer
markdown = mistune.create_markdown(renderer=MyRenderer())
print(markdown('hi `$a^2=4`'))

Currently your example MyRenderer is showing how to render math, but I think you meant to render the text:
'hi `$a^2=4$`'

(currently missing trailing $)

Thanks for your reporting. Fixed.


Save BitArray as logical array

Fix for https://github.com/JuliaIO/MAT.jl/issues/84

Sorry no one noticed this! Because your repo was deleted, I added (with a test :wink:) in #124


Flutter - Make the sample app architecture intuitive

The example app architecture should be intuitive and simple for new developers.
The calls to the TIKI SDK should be visible and simple to understand, not wrapped inside other classes.
The slices should just handle UI changes. The logic should be in a special service for Tiki Sdk, shared by all the slices.
Before updating the code, the architecture should be drafted.
Acceptance criteria
1 - Updated architecture and app working

https://user-images.githubusercontent.com/8357343/218505768-013859b3-5580-492c-8d18-0c08005c4474.mp4

https://user-images.githubusercontent.com/8357343/219409097-e9875c29-3b3c-4078-86fb-f38b0e36430e.mp4


Renaming the post-processing file

Post processing is stored in output folder, can its name be changed. Can we give a name to post-processig file.

You can use the command line argument -A,OutputDirectory=your_directory to change the output directory or you can also use the environment variable ARCANE_OUTPUT_DIRECTORY.

Yes that is exactly what I was looking for, thanks for pointing it out.


[MINOR] Relaxing required props with defaults

Change Logs
Some of teh zk lock configs have defaults and so we should avoid checking for required props.
Impact
Some of teh zk lock configs have defaults and so we should avoid checking for required props.
Risk level (write none, low medium or high below)
low
Documentation Update
Describe any necessary documentation update if there is any new feature, config, or user-facing change

The config description must be updated if new configs are added or the default value of the configs are changed
Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
ticket number here and follow the instruction to make
changes to the website.

Contributor's checklist

[ ] Read through contributor's guide
[ ] Change Logs and Impact were stated clearly
[ ] Adequate tests were added if applicable
[ ] CI passed

@nsivabalan : Please check the failing test


feat(user): split repositories list by type

Question
Response

Version?
v1.4.1

Devices tested?
Oneplus 5

Bug fix?
no

New feature?
yes

Includes tests?
no

All Tests pass?
yes

Related ticket?

Screenshots Auth user

Before
After
After

Screenshots user

Before
After

Description

Added categories to repo list screen

(In order to fix the Travis build, you have to add the english sentences in all the translations files.
You can use the translations I provided for French, leave other as English until a native speaker does the translation)

@machour tried to fix longer texts with ellipsizeMode. Please check the updated screenshot under auth user. Also worked on other remarks you have provided.

Coverage remained the same at 45.125% when pulling 7e98e9de37a4c2510618f46e3bbba40db1a66883 on Arjun-sna:repo_list_categories into f80885f4f52a1ce18eb498728f71e49aa759a3b4 on gitpoint:master.


refactor/feat: 'Next' and 'Queued' segment API

This PR is being opened on behalf of TV 2 Norge.

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Refactor that includes an addition and a change to the internal UserAction API, and to an endpoint of the HTTP API introduced in this release (release50), therefore not considered breaking.

What is the current behavior? (You can also link to an open issue here)
The currently existing setNextSegment action makes it possible to queue a segment, so that its first part will be set as Next when reaching the end of the current segment. There's no endpoint or UserAction available to set the first part of a given segment as Next.

What is the new behavior (if this is a feature change)?

setNextSegment UserAction and the corresponding /playlists/{playlistId}/set-next-segment endpoint set the first playable part of the given segment as Next. - This corresponds to what has been known in the GUI as Set segment as Next.
queueNextSegment UserAction and the corresponding /playlists/{playlistId}/queue-next-segment endpoint queue the given segment, so that its first part will be set as Next when reaching the end of the current segment. However, if the next part is already outside of the current segment, the first playable part of the given segment will be set as Next. - This corresponds to what has been known in the GUI as Queue segment.

Other information:
The GUI has been updated to use the updated user actions. The nextSegmentId property of the Playlist has been renamed to queuedSegmentId for consistency.

Status

[x] Code documentation for the relevant parts in the code have been added/updated by the PR author
[x] The functionality has been tested by the PR author
[x] Automated tests to cover the new functionality and/or guard against regressions have been added
[ ] The functionality has been tested by NRK

Note: The author of the original stable API PR has been consulted and they approve of this change.


Bluetooth: Host: Add support for the Periodic Advertising Connection Procedure

This PR adds support for connecting to a synced device from the PAwR advertiser, and receiving such connection requests when synchronized.

Depends on https://github.com/zephyrproject-rtos/zephyr/pull/56373, the first two commits can be ignored in this PR.

I am thinking of moving the connection context allocation to enhanced connection complete instead of sync established. This will simplify the implementation a bit (dont need CONNECTING_SYNCED, no extra cleanup of sync) and the connection context can be used by "regular" connections in the mean time.
We could also move the connection context allocation to when the sync context is allocated if we want to always be sure we have a connection context available. Not sure if we want to fail sync creation if we are unable to allocate the connection context though.

Did the simplification. The connection context is only allocated on the sync side when needed (at conn_complete). Also fixed an issue where the application was given an unexpected reference to the connection for the peripheral connection, leading to leaking the connection context.

Rebased and added a sample demonstrating the periodic advertising connection procedure.

Rebased on main and added a commit to fix the typos pointed out by @alwa-nordic.


checking the GitLab ulimate box during Extractor setup does not automatically load GitLab Ultimate models

Migrated from GitLab: https://gitlab.com/meltano/meltano/-/issues/1339
Originally created by @dmor on 2019-12-02 23:19:37

Situtation
Checking the GitLab Ultimate box during Extractor setup does not automatically load GitLab Ultimate models
Expected Behavior
When the user checks this box, the Models and Transforms for GitLab Ultimate are loaded by default (in addition to the rest of the GitLab models)
You can see the user click the GitLab Ultimate checkbox in the Extractor settings shortly after 11:05 in this video: https://youtu.be/MdseBq4_2Oo?t=665
You can see that we had to go and manually install the GitLab Ultimate specific models around 20:10 https://youtu.be/MdseBq4_2Oo?t=1210

View 4 previous comments from the original issue on GitLab


generate function for asking id

generate asking question askForId to ask user whether okay to expose their account id when typing account id with command. This is for mixpanel project of identity management

It keeps asking me the same question after I say "no, thank you" by typing n
I was using this command:
./bin/near state mike.testnet

I will fix this, thanks

The tests seem to be failing as it's waiting for a response on this new prompt:

++../bin/near state testaccount1603834350.test.near -v
No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself.
Check the details on how to adjust your build configuration on: https://docs.travis-ci.com/user/common-build-problems/#build-times-out-because-no-output-was-received
The build has been terminated

I see, I will fix the test, too. Thanks

Sorry, I hate to keep adding comments, but I'm trying all the different ways.
I think if the user says, "no thank you, please don't track me" we should not ask them again if they want to share their account ID.
For instance, if I do near login and it prompts me, and I say, "no thank you" and then do near state it will ask me if I want to share my account ID.
I think if the answer is no to the first question, the second question should not be asked, but that is not how it behaves now.

Unfortunately I cannot see Mixpanel because of a bug on their end, but I've filed a ticket. I think as long as the most recent comment is addressed and it's showing the person's accountId in Mixpanel, good to go!

Thank you so much for testing and reviewing for me.
Actually, I consider the no situation here, and when the setting is like this:

Would you mind check where I point out again?


Performance profiles: calculate min. resources taking into account OSDs

Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2263148
Calculate minimum required resources based on OSD pods to be deployed. Also:

Refactoring: avoid duplicated renders of 'ConfigurePerformance' & 'EnableTaintNodes' components.

there is one edge-case I see as well (no one reported it in prod yet, so we might be okay... but good to fix): say I selected no-prov SC from the StorageClass dropdown and move forward with the deployment (pvCount will be set in redux)... now I decided to navigate "Back" and select prov SC now... issue is pvCount will still be older value and we might end up using it to calculate deviceSetCount somewhere...

there is one edge-case I see as well (no one reported it in prod yet, so we might be okay... but good to fix): say I selected no-prov SC from the StorageClass dropdown and move forward with the deployment (pvCount will be set in redux)... now I decided to navigate "Back" and select prov SC now... issue is pvCount will still be older value and we might end up using it to calculate deviceSetCount somewhere...

Addressed: pvCount is reset in  to prevent this issue.

/approve
/lgtm

/cherry-pick release-4.16

/cherry-pick release-4.16-compatibility


add styling to running title

Please retain italicization for running title. Please text align centre.
Running titles are encoded as <span data-el="fw" data-type="runningTitle">.
Example: Please see emdH5_Q1. Search: The Chronical Historie.

@mahaylagalliford @pszpak  If this is for a semi-diplomatic text, then surely this SHOULDN'T be done by default. Every text will be different. It's up to the encoder to determine what style is appropriate for running titles in that text, and then to create a rendition element to apply it. Deviations from the normal rendition should then be handled using a local @style attribute.

@martindholmes Because the vast majority of those that we have seen fit this format, we feel comfortable adding the generic styling so that not every file needs to add the same stuff to the <tagsDecl>. For those that don't fit the centered and italic formatting (I've come across a couple where a page or two with roman type on running titles), people can add @rendition or @style

This is pernicious; it means that the standalone XML files for the semi-diplomatic texts will be missing crucial information. Remember that we are trying to describe the original document in the XML. This is nothing to do with how we might decide to render it later. You can't do XML encoding through render-time CSS. Please don't do this.

@martindholmes We will do this in the <tagsDecl>. Thanks for catching that!


Replace Unicode quotes in scripts with ASCII quotes

Some issues I noticed during an IDEA analysis run. I don't know how these scripts could ever work, they seem to contain Unicode " (code point 0x201c) since the beginning (which can happen when copy and pasting from a blog for instance).
I couldn't test these scripts, but since they couldn't work anyway I'm wondering if anybody is using these. For the benefits of users outside of LinkedIn I would prefer to clean them up in order to make the Voldemort distribution less confusing. I could provide an alternative PR for that.

Maybe it works because the getopts builtin just ignores these Unicode chars? But even then I think this should be fixed in order to avoid confusion.

Merged. Thanks for all the contribs, @bitti !

Thanks, appreciate it! I hope I can open some more substantial PRs soon

Uh oh ;P ...
Just kidding, sounds great xD !


Expose more information in the Uncoercible exception.

This PR partially addresses #338 by adding additional information to the Uncoercible exception, which was previously declared as follows:
exception Uncoercible

and is now declared as follows:
exception Uncoercible of uncoercible_info

where uncoercible_info is an abstract type.  Additionally, the PR registers a printer for Uncoercible that displays the source and target types of the failed coercion.  Here's an example program
$ cat uc.ml
let _ = Ctypes.(coerce int string) 3
$ ocamlfind c -o uc  -package ctypes -linkpkg uc.ml

which previously behaved like this:
$ ./uc
Fatal error: exception Ctypes_coerce.Uncoercible

and now behaves like this:
$ ./uc
Fatal error: exception Coercion failure: int is not coercible to char*

/cc @dsheets

Great! Thanks!


/questadmin reload (Internal Error) v. 2.55

This was my 4th quest added so I added it it told me to do /guest admin reload when I did it said Internal error has occurred while attempting to perform this command. and thats it! I can No longer add any quests.

Hey, I've encountered a similar error recently and I found out that if you add an Item reward it automatically creates a "- null" item which creates an error when you reload OR try to edit the quest. Try going in the config folder of the plugin and opening the quests.yml with notepad++ and removing all the "- null" items in the files.
Hope it helps !

Please update to the latest dev build. If the issue persists, create a new ticket with the full error message. Thanks!


Use explicit block argument

I noticed this in my recent debugging, and those extra block frames in the backtrace make navigating byebug an even less pleasant experience.
Note that https://github.com/rubocop-hq/ruby-style-guide#block-argument says:

Beware of the performance impact, though, as the block gets converted to a Proc.

So let's benchmark it:
def bad(&block)
  doit { yield }
end

def good(&block)
  doit(&block)
end

def doit
  yield
end

require 'benchmark/ips'
Benchmark.ips do |x|
  x.report("bad") { bad { true } }
  x.report("good") { good { true } }
  x.compare!
end

for i in 2.3.8 2.4.6 2.5.4 2.6.3 2.7.0-preview1; do rbenv shell $i; echo "Using $i"; ruby benchmark.rb; done
Using 2.3.8
Warming up --------------------------------------
                 bad   131.872k i/100ms
                good   139.755k i/100ms
Calculating -------------------------------------
                 bad      1.983M (± 2.6%) i/s -     10.022M in   5.058025s
                good      2.023M (± 3.2%) i/s -     10.202M in   5.048388s

Comparison:
                good:  2022994.4 i/s
                 bad:  1982846.4 i/s - same-ish: difference falls within error

Using 2.4.6
Warming up --------------------------------------
                 bad   105.170k i/100ms
                good   107.950k i/100ms
Calculating -------------------------------------
                 bad      1.989M (± 3.3%) i/s -      9.991M
                good      2.034M (± 3.2%) i/s -     10.255M

Comparison:
                good:  2034153.1 i/s
                 bad:  1988744.2 i/s - same-ish: difference falls within error

Using 2.5.4
Warming up --------------------------------------
                 bad   301.730k i/100ms
                good   321.918k i/100ms
Calculating -------------------------------------
                 bad      7.296M (± 4.3%) i/s -     36.509M in   5.013932s
                good      8.026M (± 4.1%) i/s -     40.240M in   5.022519s

Comparison:
                good:  8025705.3 i/s
                 bad:  7295732.8 i/s - 1.10x  slower

Using 2.6.3
Warming up --------------------------------------
                 bad   325.799k i/100ms
                good   347.909k i/100ms
Calculating -------------------------------------
                 bad      8.928M (± 3.1%) i/s -     44.634M in   5.004710s
                good     10.530M (± 3.4%) i/s -     52.882M in   5.027933s

Comparison:
                good: 10530398.1 i/s
                 bad:  8927578.8 i/s - 1.18x  slower

Using 2.7.0-preview1
Warming up --------------------------------------
                 bad   332.038k i/100ms
                good   338.596k i/100ms
Calculating -------------------------------------
                 bad      8.679M (± 3.6%) i/s -     43.497M in   5.018605s
                good     10.060M (± 3.0%) i/s -     50.451M in   5.019502s

Comparison:
                good: 10060370.5 i/s
                 bad:  8678942.1 i/s - 1.16x  slower

Looks like a non-issue.
Also @bquorning I'll have a following PR, so don't bother releasing immediately unless you enjoy it.

I'm upstreaming the style guide to remove the performance warning: https://github.com/rubocop-hq/ruby-style-guide/pull/779


Rename element type

Rename element_type into name
This attribute has been renamed by the alchemy-json_api gem
and reflects what this attribute is called in Alchemy core.
Rename elementType() into componentName()
The element attribute used is called name and not type, also in Vue components have a name attribute.

I think there's still a reference to element_type in the wiki as well?

In our private company wiki? Yes, but not here :)


Build tweaks

Just a couple of minor changes to clone_avro_and_build. The build would fail on OSX due to readlink version, and so we replace it w/ a function.

Does this version still requires patched avroc library? I would imagine that the fix should be long in master by now

I'm not sure actually, but would be nice to move to mainline avro. @walshb do you know status?
I am seeing a few commits on https://github.com/Byhiras/avro/commits that are not tagged with a JIRA.

The pyavroc code will build fine against the Avro master ("trunk") branch, but you are right, there are still some patches that didn't make it upstream. Last year the upstream maintainers were a bit slow to respond so I stopped sending patches. I'll see if I can find time to send some more upstream.

Re: upstream avro, it turns out that pyavroc actually does rely on an extra function being present: "avro_schema_enum_number_of_symbols". I'm trying to get this pushed upstream:
https://issues.apache.org/jira/browse/AVRO-1528

@walshb looks like they do have a point, maybe there is a way to read the schema without this function

@andrusha I believe their original point was that they didn't want to do bounds-checking as part of avro_schema_enum_get. The newer patch for AVRO-1528 just provides a separate function so the caller can do the bounds check themselves. So no performance problem. I will try poking them on the Avro mailing list.

@davemt @andrusha I have created JIRAs for the important fixes:
https://issues.apache.org/jira/browse/AVRO-1528 (already existed).
https://issues.apache.org/jira/browse/AVRO-1902
https://issues.apache.org/jira/browse/AVRO-1904
https://issues.apache.org/jira/browse/AVRO-1906
No reply yet from the Avro-C people. Will try the Avro mailing list.


Add the user’s rep to FIRE

Currently, there is no way to tell if a post was made by a 1-rep user or a 20k-rep mod. It would be nice to show the user’s rep and mod status next to their username.

For my own reference:
Line 1079
const userName = d.username + (d.se && d.se.post ? ` <span>(${d.se.post.owner.reputation})</span> ` : ' ');

Line 1096
 _('span', 'fire-username', {html: userName, title: 'Username'})

Just gotta make that work if SE data loads slower than the time a report takes to open.


更新 WeChatMenu

Codecov Report

Merging #723 (6fbcb0b) into master (c6c46d5) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #723   +/-   ##
=======================================
  Coverage   75.37%   75.37%
=======================================
  Files         106      106
  Lines        5203     5203
=======================================
  Hits         3922     3922
  Misses       1281     1281

Flag
Coverage Δ

unittests
75.37% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

wechatpy/work/client/api/menu.py
54.54% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6c46d5...6fbcb0b. Read the comment docs.

lgtm


xClusterStatName new variables

Describe the feature request
There should be a new variables, which can be used in inboundClusterStatName/outboundClusterStatName:
%SERVICE_NAME% - Will be substituted with name of the service.
%SERVICE_NAMESPACE% - Will be substituted with namespace of the service.
It gives more flexibility in defining patterns.
Affected product area (please put an X in all that apply)
[ ] Ambient
[x] Docs
[ ] Dual Stack
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[x] Extensions and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
Affected features (please put an X in all that apply)
[ ] Multi Cluster
[ ] Virtual Machine
[ ] Multi Control Plane
Additional context
In our k8s kubernetes setup the service foo can be present in many namespaces and have to be treated as the same service (for this purpose we aggregate them behind one virtualservice) - but each pair of service name and namespace is a different envoy cluster and have different name in metrics which have huge impact on cardinality of these metrics. Having a option to configure envoy altStatName with the same value (using only %SERVICE_NAME%) for these clusters will reduce it dramatically.

But this is a mesh wide config. How will you set for specific service? If you really need %SERVICE_NAME% makes sense. Why do you need ONLY %SERVICE_NAMESPACE%?

okay, so can i prepare a pr with addition of this %SERVICE_NAME%?

yes


DOC: Small improvements in optimize._lsq docstrings

Hi, I tried to fix some problems left with docstring after my PRs with least-squares algorithms were merged.

Apart from the two comments about verb in summary lines, this looks good to me.

@dlax, good suggestions, I updated one-line summaries.


[php] support securityContext

IRSA must be supported for php chart to work with EKS.
$ ls -la /var/run/secrets/eks.amazonaws.com/serviceaccount/..2019_12_10_15_33_09.833408446/token
-rw------- 1 root root 1034 Dec 10 15:33 /var/run/secrets/eks.amazonaws.com/serviceaccount/..2019_12_10_15_33_09.833408446/token

Only root users can read and write tokens mounted with IRSA.
However, in PHP-FPM, it should be executed as the nobody user, and the token cannot be referenced from the nobody user.
https://docs.aws.amazon.com/en_pv/eks/latest/userguide/iam-roles-for-service-accounts-technical-overview.html
So we will modify the SecurityContext based on this document.
Checklist

[X] Chart Version bumped

LGTM


Simply cannot figure out how to attach a ListItem button to a Drawer

[x] I have searched the issues of this repository and believe that this is not a duplicate.

Expected Behavior

I'm trying to follow the material-ui documentation, with the end goal being creating a left anchored permanent Drawer which has ListItem buttons that link to different pages.
Current Behavior

The documentation seems to me to be incomplete. It fails to describe in any detail how you link the actual ListItems to the Drawer, or even how to create buttons out of ListItems in general. If you look at the Demos for Drawers (https://material-ui-next.com/demos/drawers/), the ListItems are abstracted out to another file which is not shown. This ensures that there's no way to understand how to connect the two.
I've searched excessively on how to accomplish this, and have tried numerous variations of my own. Granted, I'm new at this. But I feel the documentation should be there to help. In all honesty, I'm just looking to help solve this issue, so I can move on with my project 😄 but perhaps I can help you guys improve your Docs as well.
Thank you!
Steps to Reproduce (for bugs)

Your Environment

Tech
Version

Material-UI
1.0.0-beta.20

React
16.0.0

browser
Chrome

how you link the actual ListItems to the Drawer, or even how to create buttons out of ListItems in general

@RSpicer Sounds like you are having two questions here. I'm wondering how we could make thing simpler. I hope the following example helps:
import React from 'react';
import Button from 'material-ui/Button';
import List, { ListItem, ListItemText } from 'material-ui/List';
import Drawer from 'material-ui/Drawer'

function Index() {
  return (
    <Drawer type="permanent">
      <List>
        <ListItem
          button
          component="a"
          href="https://www.paypal.me/oliviertassinari/1"
        >
          <ListItemText primary="Inbox" />
        </ListItem>
      </List>
    </Drawer>
  )
}

export default Index;

https://codesandbox.io/s/8xv8vl85w8

I'm sorry. I missed a key component (heh) of this question. What I want to accomplish is to render a separate component to my Drawer, activated via the ListItem button. Apologies for missing this key part in my issue!


Screen small fixes

"UNDO" in snack bar should be in caps letters
App

Design

https://zpl.io/2vO5EEY

After turn off Privacy Mode, Available and In progress card should have same conditions as it was before turning on Privacy Mode - if were open, should be open; if were closed, should be closed. At the moment cards are always closed after turning off Privacy Mode.

Show all (transactions) should have normal letter spacing
Space between In progress card and Transactions header should be 30 dp

Checked


Aggregate event subscriptions

Currently, we're subscribing to each event separately. This was a limitation of viem at the time I set that up, and maybe it still is.
This needs to change, even if we have to bypass Viem, because we're listening for A LOT of events and currently we're positively hammering the RPC with eth_getFilterChanges requests.

You can listen to multiple topics in Viem too: https://viem.sh/docs/actions/public/watchEvent.html#multiple-events

Fantastic, thanks a lot for the help, I'll use that :)

come across this and thanks @jxom for the advice
so according to the docs even with watchFilter, we can't meaningfully use single filter to filter for both criteria (list of events, current gameId which is in args)

The caveat here is that you cannot scope by indexed arguments (JSON-RPC/topic design limitation).

I digged the implementation a bit, viem actually do apply the arg when creating the filter
https://github.com/wevm/viem/blob/81ae35284e22164e8f8ac4d3b44f846b83f548f1/src/actions/public/createEventFilter.ts#L194
but the catch is the arg in filter has to be consistent across events -- i.e. game id is the only thing we filter in all event, which is true for the current contract & use case
where it did end up using one eth_getFilterChanges rpc call for all events (as in the logs)
Let me know if we're good with this hack I can PR

@norswap btw will recommend do a simple rxjs wrapper for easier event filtering & async control, where it also integrates well with jotai from my understanding if we need that in future https://jotai.org/docs/utilities/async#atomwithobservable

Hey, if we could observe all events & filter on game ID upstream, that'd be
swell!
If not, we can just listen to all events & filter in the frontend. Because
it works via polling at the moment, this is still preferable to the current
situation where we poll for every single events.
Regarding rxJS, I'd rather not introduce another dependency/framework if we
can avoid it. I feel like it's not really needed here, we can just update
the jotai store directly in the callback.
And yes, feel free to go for the issue!
On Fri, Feb 16, 2024, 02:48 debuggingfuture (Vincent LCY) <
@.***> wrote:

@norswap https://github.com/norswap btw will recommend do a simple rxjs
wrapper for easier event filtering & async control, where it also
integrates well with jotai from my understanding if we need that in future
https://jotai.org/docs/utilities/async#atomwithobservable
—
Reply to this email directly, view it on GitHub
https://github.com/0xFableOrg/0xFable/issues/91#issuecomment-1946941557,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AABRLP3GBYZPCIR5RI5MDQLYTZKATAVCNFSM6AAAAABAYVX33OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNBWHE2DCNJVG4
.
You are receiving this because you were mentioned.Message ID:
@.***>


Multiple quick fix bulbs appearing on selection

VSCode Version: 1.11.0
OS Version: Win 10

Steps to Reproduce:

Create an unused function/variable.
Select multiple lines with unused function/variable declaration within the editor.

dupe #22517


:bug: Fix link name collision (rename link to linkTool)

Now enabling of the link plugin (block-level link embeds) breaks inline links.
The reason is name collision.
This fix renames block-level link to linkTool, that fixes the issue.
Might be a breaking change for users who use block-level link.
Also:
:memo: Add supported tools and how to use it to README

Thanks @Loskir


Bug 2154165: disable webhook for rook

disabling webhook for rook untill is officially supported
Signed-off-by: subhamkrai<EMAIL_ADDRESS>

/assign @travisn @iamniting

/bugzilla refresh


polish front end design

-12/11 : could always use improvement, but no outstanding issues in primary view


No logs,no html elements on safari remote debugging with a connected iphone

Ionic version:  (check one with "x")
[ ] 1.x
[x] 2.x
I'm submitting a ...  (check one with "x")
[x] bug report
[ ] feature request
[ ] support request => Please do not submit support requests here, use one of these channels: https://forum.ionicframework.com/ or http://ionicworldwide.herokuapp.com/
Current behavior:
I can't remote debug app on ios device with safary. I can see under Develop my device a I connect to it but no logs or html elements are shown.
Expected behavior:
logs and html elements should be shown if device is connected to safari on mac
Steps to reproduce:
I build application with ionic build ios and then I go to Xcode, open project, choose my connected iphone and run it. later I open safari and choose my iphone from develop menu.

Hello! Thanks for opening an issue with us! As this seems like more of a support question i will urge that you ask this question on our forum or on our slack channel. Thanks for using Ionic!


Refactor OCI

Add checks for nil channel, missing repository name, missing tag, invalid document channel, and excluded suffixes
Add error messages for failing to parse repository reference, and other errors

[pkg/handler/collector/oci/oci.go]

Raise the amount of returned recordings from 10 to 100
Fix the condition for polling
Add a check for a nil channel
Add an error message for missing repository name
Add an error message for missing tag
Add an error message for invalid document channel
Add a filter for excluded suffixes
Add a check for the context being done
Add an error message for failing to parse the repository reference

Signed-off-by: naveensrinivasan<EMAIL_ADDRESS>

I am aware of the need for quick action, however, I suggest that we avoid the necessity of rework due to the changes in the data structure. It would be greatly appreciated if we could avoid this, as it is extremely time-consuming and frustrating.
The PR was promptly addressed in light of the feedback received.
I would have to rework on the Pull Request and someone has to review it again and I would like to avoid this.

I am aware of the need for quick action, however, I suggest that we avoid the necessity of rework due to the changes in the data structure. It would be greatly appreciated if we could avoid this, as it is extremely time-consuming and frustrating. The PR was promptly addressed in light of the feedback received.
I would have to rework on the Pull Request and someone has to review it again and I would like to avoid this.

Due to the code conflicts and CLA issues resulting from the co-author commit, I will close this PR and open a new one.


Add SanityCheck callback

Adds a SanityCheck callback as discussed on Zulip.
If some checks don't pass the output will look like this:
1/4 sanity checks failed:
---
1: Model and loss function compatible with data (ERROR)

To perform the optimization step, model and loss function need
to be compatible with the data. This means the following must work:

- `(x, y), _ = iterate(learner.data.training)`
- `ŷ = learner.model(x)`
- `loss = learner.lossfunction(learner.model(x), y)

Left a couple of clarity suggestions. Only extra functionality that would be nice is the ability for the check function to pass information to the error message. For example, in the data iteration check we could print the type of the batch instead of just saying "it's not a tuple."

Yeah, was thinking about that, too, but wanted to get a simple draft out.I guess checkfn could be ::(Learner,) -> T and message would be replaced by a messagefn::(T,) -> String. Would have to decide on a return value for a passing check. What do you think?

Left a couple of clarity suggestions. Only extra functionality that would be nice is the ability for the check function to pass information to the error message. For example, in the data iteration check we could print the type of the batch instead of just saying "it's not a tuple."

Yeah, was thinking about that, too, but wanted to get a simple draft out.I guess checkfn could be ::(Learner,) -> T and message would be replaced by a messagefn::(T,) -> String. Would have to decide on a return value for a passing check. What do you think?

Couldn't the return type of checkfn be Tuple{Bool, Vararg{Any}}? So you could have something like return (false, typeof(batch)) inside the checkfn. Then we have messagefn(args...) -> String.

Couldn't the return type of checkfn be Tuple{Bool, Vararg{Any}}? So you could have something like return (false, typeof(batch)) inside the checkfn. Then we have messagefn(args...) -> String.

I would leave the message functions to the future, I feel like this is already a very large implementation for a simple feature. We can always expand the number of checks and the clarity of the messages.

I would leave the message functions to the future, I feel like this is already a very large implementation for a simple feature. We can always expand the number of checks and the clarity of the messages.


Icons on VSCode 1.86 Terminal

The problem
After upgraded the VSCode to 1.86 and its terminal is not showing the icons as emoji.

It looks fine on OS build-in Terminal app though.

Relevant Zsh configuration
ZSH_DISABLE_COMPFIX="true"
export PATH=$HOME/bin:/usr/local/bin:$PATH
export PATH="/usr/local/sbin:$PATH"
export ZSH="/Users/chanko/.oh-my-zsh"
ZSH_THEME="spaceship"
plugins=(git docker docker-compose)
source $ZSH/oh-my-zsh.sh
FPATH=$(brew --prefix)/share/zsh/site-functions:$FPATH

What is version of Spaceship are you using?
v4.15.0
What is version of Zsh are you using?
zsh 5.9 (x86_64-apple-darwin23.0)
What operation system are you running?
macOS
Do you use any Zsh framework or plugin manager?
No response
Which terminal emulator do you use?
VSCode
Additional information
No response

There is workaround by this issue https://github.com/microsoft/vscode/issues/32840.


how to reuse only the "get images" logic of image.List

What is the problem you're trying to solve
Currently image.List contains 2 steps:

Get the images according to the filters.
Print the images.

It'd be nice to have an exported function that only does the first step. The detailed rationale is very similar to https://github.com/containerd/nerdctl/pull/1837#discussion_r1069763156, and this time instead of directly creating a PR, I think opening an issue first probably makes more sense.
Describe the solution you'd like
Looking at the fields of types.ImageListCommandOptions, many of them are only needed by 2. Print the images, so maybe we can create a new function and make it only depend on the things it needs:
func ListTheNewFunc(ctx context.Context, namespace, address string, Filters, NameAndRefFilter []string) ([]images.Image, error)

or maybe it can just take a *containerd.Client as the caller of this function can be potentially a long-running process, and it can call clientutil.NewClient itself to instantiate the client only once during process initialization:
func ListTheNewFunc(ctx context.Context, client *containerd.Client, Filters, NameAndRefFilter []string) ([]images.Image, error)

I don't have a perfect name in mind for the new function, so I just use ListTheNewFunc as a placeholder, and I'm not even sure if creating a new function makes sense to you, and I appreciate any suggestion, thanks!
Additional context
I'm more than happy to work on this as long as the community reaches a consensus on the approach.

Maybe you can rename the current image.List to image.ListCommandHandler, and extract the main list logic to a new image.List func. You can pass a client to the new image.List (e.g., as your 2nd func). Something like this:
// ListCommandHandler constructs containerd client, calls `List` to get images that match filters, and formats/prints the result.
func List(ctx context.Context, options types.ImageListCommandOptions) error {
    ...
    imageList, err :=List(ctx, client, ...)
    ...
}

// List queries containerd client to get image list and only returns those matching given filters.
func List(ctx context.Context, client *containerd.Client, Filters, NameAndRefFilter []string) ([]images.Image, error)

Maybe you can rename the current image.List to image.ListCommandHandler, and extract the main list logic to a new image.List func. You can pass a client to the new image.List (e.g., as your 2nd func).

Sounds great! @AkihiroSuda @Zheaoli Could we consistently use this naming pattern when we extract the "main logic" out of a command? Thanks!

// ListCommandHandler constructs containerd client, calls List to get images that match filters, and formats/prints the result.
func List(ctx context.Context, options types.ImageListCommandOptions) error {

List -> ListCommandHandler?

another thing we can do for this command is to pass a io.Writer to printImages, which can come from ListCommandHandler, which can come from cmd.OutOrStdout when ListCommandHandler is called by imagesAction.
Just notice currently the output is binded to os.Stdout.

Sure, I can do it in another PR. Just want to make it clear that this may be unrelated to this issue. Linking the relevant issue: https://github.com/containerd/nerdctl/issues/1856

@AkihiroSuda @Zheaoli Would greatly appreciate your feedback for https://github.com/containerd/nerdctl/issues/1855#issuecomment-1397466812, thank you!
"main logic" is from https://github.com/containerd/nerdctl/pull/1837#discussion_r1069763156:

preprocess step: process cli flag and construct options (which we're refactoring);
flag/option validation step: check either flags (previously) or options (after refactor), to resolve conflict options or do some filtering (e.g., here --quiet and --filter=size; in run we have some -i -d -t conflict).
main logic step: which I feel we should return the structs if it's a GET/LIST-kind func, or a success or fail indicator (bool, err, etc), or a PUT/DELETE-kind func.
postprocess step: after receiving results from 3, print as a table or json, etc.

From https://github.com/containerd/nerdctl/pull/1837#discussion_r1071501112:

LsCmd or other names are not keeping the same style as other command

Maybe we can make the names consistent regardless if the "main logic" has been separated out? For example, we can rename all functions to be XXXCommandHandler first and then we can separate the "main logic" out of each function.


(Dart) Support Dart's new Null Safety type system

Describe the issue
Dart's new Null Safety language feature introduces some new keywords and a new way to specify types:

late and required are new keywords

Never is a new type found in dart:core

(almost) all types can be suffixed with a ? to indicate a nullable type. For example, in:
f(int x) { ... }
g(int? x) { ... }

f is a function which accepts a non-null int parameter, and g accepts a nullable int parameter.

Which language seems to have the issue?

Dart.
Are you using highlight or highlightAuto?
Either.
Sample Code to Reproduce

late int x;
f({required int? y}) {}

Expected behavior

late and required should be hilighted as keywords. int? should highlight the same as int.
Additional context

Please add a usage of Never to your sample.
A PR would be welcome.  Tagging this as beginner friendly.

Should the long list of built-in types just be duplicated to include, e.g. int?, String?, ... or is there a better way?

Duplication is probably best, but you can do it dynamically with JS... break out the types (or do all the Built-Ins count?) split them, then build a second set with ? appended, add that to the first...

You'll need to add ? to the keyboard $pattern... and is that going to cause any false positives with ternary?

Does this apply to user types as well? Is so might want to think about making it a mode instead that matches all [identifier]?, but again would need to consider false positives.

Please add a usage of Never to your sample.

Done.

You'll need to add ? to the keyword $pattern... and is that going to cause any false positives with ternary?

It shouldn't; most Dart code is auto-formatted so that a ternary ? has whitespace before it.

Does this apply to user types as well? Is so might want to think about making it a mode instead that matches all [identifier]?, but again would need to consider false positives.

It does, but I think it would be more confusing to match [identifier]?, since that would match differently from [identifier].
Although... it is exceedingly common practice to only name types with a leading capital letter (and optional _) and to only name variables, consts, fields, methods, etc with a leading lower case letter (and optional _); so that might be a nice improvement to make...

[identifier]?, since that would match differently from [identifier].

Not sure what you mean?

@srawlins Any interest in taking a pass at the second part of this?

Sorry, I dropped the thread here. I was getting at the idea that today we don't have any special mode for "types" that would include user types. For example:
int v1;
UserType v2;

int is in the list of built_ins in KEYWORDS, but UserType is not, and it matches no other mode. So int is highlighted as hljs-built_in, and UserType is not highlighted at all.
I think this is a fine. If user types should be highlighted separately from, say, functions and variables (e.g. display UserType and v2 in two different ways), that's fine, but I don't think it would be required to close this issue.
I can mail a PR adding int? etc to the list of built_ins.


chore: expose SSL port in Dockerfile and enable SSL in matterbridge o…

…ptions
Proposed Changes

Describe the changes you made.

Added the -ssl option to the matterbridge command.
Opened port 8443 for SSL connections.

Related Issues

Related issues or pull requests

#133

Where does matterbridge take the certificate for https://<IP_ADDRESS>:8443 from?
Additionally i dont know what else impact it has, so I'd recommend adding a ENV as a flag and add the ssl conditionally (default false - to not break anything for others).

https://github.com/Luligu/matterbridge/pull/62#issuecomment-2197524509
Since /root/.matterbridge has already been added to the VOLUME, there’s no issue with adding certificates to /root/.matterbridge/certs.
Additionally, I don’t think it’s necessary to create an env variable for selecting SSL, as port 8443 should only be used by those who need it.

However, if you, as the maintainer, prefer that I handle this, I have already completed the task. Does this meet your expectations?


Disable a select dropdown?

This is high priority issue for us when editing cascading select controls (say country, state, city). State and city must be disabled before selecting a country, how can we achieve this? I have looked at the examples and source code and I don't think its implemented yet. Can anyone suggest a temporary solution with CSS to disable the select control?

Hi!
It's one thing we need to make fast. For now there is a work-around really ugly, but it works. I use a disabled lx-text-field and a lx-select, and with a ng-if I display the right one. Like I said, really ugly, bit we did not had time to update the select for this.

In the last version, we've reworked and fixed a lot of things. If this issue is still happening, please re-open the issue. Thank you!


webui-popover on checkbox - not showing checkbox as selected

hi,
thanks for nice plugin. I am trying to get the popover on checkbox - if a checkbox is clicked it should show, if i uncheck it should hide.
the popover is coming correctly. but problem is, it is not showing checkbox as checked. Any clue how to solve this problem?
here is my code
html:
<input type='checkbox' id='check' />click here

this is popover div

js:
$('#check').webuiPopover({url:'#d1'});
and here is screenshot of result:

Both clicks are interferencing one another. To workaround put popover in manual and trigger it manually. Example:

//Initailize
 $('#check').webuiPopover({trigger:'manual'});
...

 //Show it
 $('#check').click() {function() {
      $('#check').webuiPopover('show');

hey,
thanks for your reply.. it is showing me the checkbox checked and popover as well, but it is giving me this error:
jquery.webui-popover.js:305 Uncaught TypeError: this.options.onShow is not a function
the code i wrote as you rusggested:

//Initailize
$('.check').webuiPopover({trigger:'manual'});

//Show it
$('.check').click(function() {
     $('.check').webuiPopover('show');
     })

Complete working sample: https://jsfiddle.net/bu67Lbds/

I note your example only shows the popup after you have clicked the element. Often you would want the popup to happen as you hover and before you click. I am having the same problem with using it with buttons, the 'hover' method hides my click.on function actually on the button. Is there any way around this besides forcing the popup when you click? Thanks it is a really good piece of work otherwise

I though that was what you want.
If you want to show the popover on hover it's super easy, it's just the default way this plugin works. Here are some samples: https://jsfiddle.net/8nLz1rrx/

Yes, I acknowledge that your jsFiddle example works but as I mentioned, the popup only comes when you click, if you use the ‘hover’ method it hides the underlying click action, as you say yourself. However, with a button or a checkbox, normally you want the popup to occur before you click, ie when you hover, because you want the user to know what the results of the click will be. But your otherwise very good plugin, prevents the normal click on the button happening, if you use the hover method. It is all about the sequence of when the popup is shown. Sorry if I am not making myself clear.
Regards
Robyn Hannah PhD BE (Hons 1) Grad Dip Counselling.
http://nrie.com.au/NRIEWB9Version/index.html NRIE Logo
NRI Electronics Pty. Ltd.
PO Box 20, Alstonville, NSW, 2477.
Phone: 02 6628 7961 or 0427 068 257
email<EMAIL_ADDRESS><EMAIL_ADDRESS>www.nrie.com.au
From: Eduardo Molteni<EMAIL_ADDRESS>Sent: Saturday, 30 April 2016 22:43
To: sandywalker/webui-popover
Cc: robynjayqueerie; Comment
Subject: Re: [sandywalker/webui-popover] webui-popover on checkbox - not showing checkbox as selected (#159)
I though that was what you want.
If you want to show the popover on hover it's super easy, it's just the default way this plugin works. Here are some samples: https://jsfiddle.net/8nLz1rrx/
—
You are receiving this because you commented.
Reply to this email directly or view it on GitHub https://github.com/sandywalker/webui-popover/issues/159#issuecomment-215961236 Image removed by sender.
No virus found in this message.
Checked by AVG - www.avg.com
Version: 2016.0.7539 / Virus Database: 4563/12135 - Release Date: 04/30/16

No virus found in this message.
Checked by AVG - www.avg.com
Version: 2016.0.7539 / Virus Database: 4563/12135 - Release Date: 04/30/16

hi @Eddie,
thanks, this was exactly i what wanted. it works really cool..

Excellent @ssjogus! Could you please close the issue so we all help Sandy taking care of the issue list?