Support measuring items automatically

Hello, everyone!
I'd like to implement this feature, unfortunately, I'm not pretty sure how to do that. What would be the implications of not using getItemLayout with the actual code?

Right now we need the layout of each cell to be able to know in which column to put them in (always the column with the smallest total height). To be able to do the measuring I think the best way to go is check how it is implemented in VirtualizedList and do something similar.
I think what might make it hard is that we don't want to measure all rows at once, only those that will be visible so this means we need to also know what is the state of windowing. I wonder if at this point it would just be simpler to fork the VirtualizedList code and adapt it to support this layout.
So yeah at this point I'm really unsure of what the proper solution is :), we'd just have to try some stuff to see if it works.

@janicduplessis sounds interesting.
It worth to take a look at the source code of FlatList since numColumns is implemented in FlatList.

@juan Can we compromise and measure each cell in one swoop to then pass explicit dimensions to each list item?

@kaifaust We could do that until we have a better implementation but we have to make it sure it is clear that not providing the getItemLayout will cause all items to be measured so it should only be used with small data sets.


Added support for recursively comparing two multi-dimensional arrays …

…for equivalency. Should fix #260.
Fixed a bug when chaining multiple assertions together.
During equivalency assertions, a declared type of object is still processed as a run-time type.

"During equivalency assertions, a declared type of object is still processed as a run-time type" (emphasis mine)
Isn't that actually a change that largely reverts #161 rather than a preservation of behavior?

In my opinion it's a small correction. The problem is that without it, non-generic collections and dictionaries will never be able to benefit from ShouldBeEquivalentTo. I couldn't even add support for multi-dimensional arrays without it. Functionally, I would be surprised if an object property doesn't get compared at all. The main reason for making a distinction between the declared and the run-time type was to support comparing interfaces and only including the members the interface defines.

The non-generic collections were still able to benefit from ShouldBeEquivalentTo,  a user just needs to indicate their intention by calling RespectingRuntimeTypes().  In my opinion, ShouldBeEquivalentTo is complex enough and "special case" behaviors like treating collections differently with respect to runtime vs declared types makes it harder for users to know how it is going to behave.  Yes, per #116 any two objects are found equivalent, when RespectingDeclaredTypes(), though an error is given if the root object is type object.  It is possible to implement multi-dimensional array support while preserving the runtime/declared type behavior that was in place.

v3.4 will still respect the declared type all the way down (or up) the object graph, unless a property or element is of type object. In that case, it will use the run-time type. This evaluation happens for every evaluation of the CompileTimeType in the EquivalencyValidationContext. IMHO, it doesn't make sense to throw an exception just because some nested property is defines as `object.


Disable partial dependence plots for large data scenarios

Description
It is not possible to visualize all scatter plot points in partial dependence plot. Hence, disabling it for large data.
Before:-

After:-

Checklist

[x] I have added screenshots above for all UI changes.
[ ] I have added e2e tests for all UI changes.
[ ] Documentation was updated if it was needed.

Codecov Report

Merging #1843 (4a39787) into main (75e4926) will increase coverage by 13.28%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             main    #1843       +/-   ##
===========================================
+ Coverage   79.00%   92.28%   +13.28%
===========================================
  Files          19       99       +80
  Lines        1324     4603     +3279
===========================================
+ Hits         1046     4248     +3202
- Misses        278      355       +77

Flag
Coverage Δ

unittests
92.28% <ø> (+13.28%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

raiwidgets/raiwidgets/cohort.py

...idgets/raiwidgets/responsibleai_dashboard_input.py

raiwidgets/raiwidgets/fairness_dashboard.py

...iwidgets/raiwidgets/fairness_metric_calculation.py

raiwidgets/raiwidgets/model_analysis_dashboard.py

raiwidgets/raiwidgets/explanation_dashboard.py

raiwidgets/raiwidgets/error_analysis_constants.py

...iwidgets/raiwidgets/explanation_dashboard_input.py

raiwidgets/raiwidgets/error_handling.py

raiwidgets/raiwidgets/dashboard.py

... and 108 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Use forge namespaced registry for track type and track kit

I tried, it was horribly complicated and way overkill for my needs.

Ah ok. I thought forge ones would help polling random kits.

If you can get it working sure, but after digging through the registry code for 45 minutes trying to understand how the hell it worked I gave up and just rolled my own.


Token should refresh automatically in background

Currently in this approach the token is not automatically refreshed. The token get expires after 1 hour.

I would think you may need to handle this on your implementation, for instance, if you get a 401 from your API, simply trigger adalService.login(); .


Users can circumvent the repository limit

Gogs version (or commit ref): <IP_ADDRESS>6
Git version: 2.1.4
Operating system: up to date Debian 8
Database:

[x] PostgreSQL
[ ] MySQL
[ ] SQLite

Can you reproduce the bug at http://try.gogs.io:

[ ] Yes
[ ] No
[X] Not relevant (no admin access)

Log gist: not relevant

Description
When creating a user with a repository limit of 0, the user cannot create repositories. But the user can still create an organization and create an endless amount of repositories in the organization, rendering the repository limit useless.

Duplicated of https://github.com/gogits/gogs/issues/2643 and please follow https://github.com/gogits/gogs/issues/1556


add a list of security related OS

I don't think this is the right awesome list to include this, that is why I didn't merge it. Closing it for now.


Fixes #1654: Switch to a spin pg_try_advisory_lock

Postgres can deadlock with a pending pg_advisory_lock and
a long running CREATE INDEX CONCURRENTLY statement.

Reproduce the deadlock in PostgreSQLConcurrentMigrationMediumTest
with a modified version of the regular ConcurrentMigrationMediumTest
Modify PostgreSQLAdvisoryLockTemplate to spin until
pg_try_advisory_lock returns true or it is interrupted
Sleep for 100ms on failed attempt to acquire the advisory lock

Could you sign the CLA and resolve conflicts so this can be merged? Thanks!

Apologies. I didn't see your previous comment. I have signed the CLA now and resolved the merge conflicts

The build appears to be failing even after rebasing onto the commit for the latest green build. It seems like the same tests are failing on master.

Thanks for contributing this. Your code has been integrated.


Next Version of BAC0 (BACnet networks) will use bacpypes3 and so will become async

Describe the bug
Next version will use async and this will break actual code
Actual code : https://github.com/google/testrun/blob/254effde47f77e6b5255a69c1f46174ed94ccc51/modules/test/protocol/python/src/protocol_bacnet.py#L20
To Reproduce
Async development is done here : https://github.com/ChristianTremblay/BAC0/tree/async
Additional context
As a convenience, this is what the fix could be. But as I'm not sure of your use case, I'm not presenting that as a PR
import BAC0
import asyncio
import logging
from signal import SIGINT, SIGTERM, signal
from bacpypes3.npdu import Address

LOGGER = None
BAC0_LOG = '/root/.BAC0/BAC0.log'

class BACnet():
  """BACnet Test module"""
  bacnet = None #class instance, a way to access it from handler to disconnect when it's over

  def __init__(self, log):
    # Set the log
    global LOGGER
    LOGGER = log

    # Setup the BAC0 Log
    BAC0.log_level(log_file=logging.DEBUG, stdout=logging.INFO, stderr=logging.CRITICAL)

    self.devices = []

  async def discover(self, local_ip=None):
    LOGGER.info("Performing BACnet discovery...")
    BACnet.bacnet = BAC0.lite(ip=local_ip)
    while BACnet.bacnet._initialized is False:
      await asyncio.sleep(0.01)
    LOGGER.info("Local BACnet object: " + str(BACnet.bacnet))
    try:
      await BACnet.bacnet._discover(global_broadcast=True) # calling the async version with await to wait for result
    except Exception as e:
      LOGGER.error(e)
    LOGGER.info("BACnet discovery complete")
    with open(BAC0_LOG,'r',encoding='utf-8') as f:
      bac0_log = f.read()
    LOGGER.info("BAC0 Log:\n" + bac0_log)
    self.devices = await BACnet.bacnet._devices(_return_list=True) # bacnet.devices have been hidden under _devices to keep the property capability... and allow returning list if required... or a good looking table.

  # Check if the device being tested is in the discovered devices list
  async def validate_device(self, local_ip, device_ip):
    result = None
    LOGGER.info("Validating BACnet device: " + device_ip)
    await self.discover(local_ip)
    LOGGER.info("BACnet Devices Found: " + str(len(self.devices)))
    if len(self.devices) > 0:
      # Load a fail result initially and pass only
      # if we can validate it's the right device responding
      result = False, (
        f'Could not confirm discovered BACnet device is the ' +
        'same as device being tested')
      for device in self.devices:
        deviceName, vendorName, devId, device_address, network_number = device
        LOGGER.info("Checking Device: " + str(device))
        if Address(device_ip) == device_address: # or <IP_ADDRESS> in 192.168.30 returns True
          result = True, f'Device IP {device_ip} matches discovered device'
          break
    else:
      result = None, 'BACnet discovery could not resolve any devices'
    if result is not None:
      LOGGER.info(result[1])
    return result

def handler(sig, sig2):
    print(f"Got signal: {sig!s}, shutting down.")
    BACnet.bacnet.disconnect()
    loop = asyncio.get_event_loop()
    loop.stop()
    # loop.remove_signal_handler(SIGTERM) ## doesn't work on Windows, using signal instead
    # loop.add_signal_handler(SIGINT, lambda: None)

def main(logger, local_ip, device_ip):
    loop = asyncio.get_event_loop()
    signal(SIGINT, handler)
    signal(SIGTERM, handler)
    loop.create_task(_main(local_ip=local_ip, logger=logger, device_ip=device_ip))
    loop.run_forever()
    tasks = asyncio.all_tasks(loop=loop)
    for t in tasks:
        t.cancel()
    group = asyncio.gather(*tasks, return_exceptions=True)
    loop.run_until_complete(group)
    loop.close()

async def _main(logger, local_ip, device_ip):
    b = BACnet(logger)
    result = await b.validate_device(local_ip=local_ip, device_ip=device_ip)
    print(result)
    handler("Over", None)

 # This was a quick way to make it work on its own, locally
if __name__ == '__main__':
    logger = logging.getLogger()
    device_ip='<IP_ADDRESS>'
    local_ip='<IP_ADDRESS>/24'
    main(logger=logger, local_ip=local_ip, device_ip=device_ip)

Hi @ChristianTremblay thanks for letting us know about this, we will take a look at this!


V3 compatibility

Discussed in https://github.com/saade/filament-fullcalendar/discussions/86

Originally posted by tonypartridge May 25, 2023
Any plans for Filament V3 yet?

There is already a pull request #88

Hello friends.
Just released v3.0.0-beta1.
PLEASE READ CAREFULLY:

This is a first-pass release for supporting v3.
There WILL BE BRAKING CHANGES when the final v3.0.0 is released.
The docs are not updated yet. But there are no braking changes for now.

Thanks for everyone who opened a PR for supporting v3. :yellow_heart:


IndexError: index 128 is out of bounds for axis 0 with size 128

Hello,
When I run SegGradCam code to use GradCam in Thresholding Segmentation with PixelRoI,
an unexpected error occurs:
Code:

from imageio import imread
image = imread("../input/retinal-vessel-segmentation/DRIVE/training/images/21_training.tif")
image = tf.image.resize(images=image, size=[128, 128])
image = image.numpy()
image = image.astype(np.uint8)
data = Image.fromarray(image)
data.save('dummy_pic.jpg')

a = "./dummy_pic.jpg"
a = imread(a)

roi=PixelRoI(128,128,a)

Error:
---------------------------------------------------------------------------
IndexError                                Traceback (most recent call last)
/tmp/ipykernel_35/845604040.py in <module>
      1 # image = imread(images[0], 3)
----> 2 roi=PixelRoI(128,128,a)
      3 # roi.shape()

/tmp/ipykernel_35/2143735659.py in __init__(self, i, j, image)
     64         self.image = image
     65         self.roi = np.zeros((image.shape[-3], image.shape[-2]))
---> 66         self.roi[i, j] = 1
     67         self.i = i
     68         self.j = j

IndexError: index 128 is out of bounds for axis 0 with size 128

Environment:
Desktop         : Virtual Environment Kaggle, GPU
Tensorflow     : 2.6.2 (unupgradable)
Matplotib        : 3.5.1 (unupgradable)
Question:
Can anyone please help me to solve this error?

I would try index 127. If the size of the axis is 128, it means there are indexes from 0 to 127


Consider implementing smoke tests on release

See scarb's release workflow for reference

Is this still relevant?
cc @MaksymilianDemitraszek @cptartur

Assigning to cli team @cptartur to have a clear ownership here


Add support for STM32H725/735 parts

Reference Manual is RM0468
Ref #163

[x] Updates to support STM32H725/735 parts
[x] Successfully build examples
[x] At least one example for these parts specifically - examples/ethernet-rtic-stm32h735g-dk.rs
[x] Fix other breakages from https://github.com/stm32-rs/stm32-rs/pull/554
[x] Remove dependency on nightly PAC build

Rebased onto master

Hi, this should now be possible with the 0.14 release of stm32h7.

Someone is keen to start using this 😄  . Indeed now that #240 is merged it just needs a rebase

Hehe guilty as charged 😅
I've got a nucleo with Ethernet coming in a few days so I'm very much looking forward to trying out this HAL

@korken89 Have you been able to try this out? Unless there's any major problems, I plan to merge this PR into master and make new issues for anything else that comes up.

I have been successfully using it for 1 week now :)

Great! Let's merge it

bors r+


Not glimmer 2 friendly

Currently if you spin this up and proxy a component you will get the error Template.create is not a function
More detail here https://github.com/emberjs/ember.js/issues/14228
We are using a CP for layout (something Robert calls out as likely a problem in the above issue). Also I'm uncertain if it's a problem just yet, but it seems the Ember.HTMLBars.compile could be an issue. I'm hoping we can modify this proxy to be both ember 2.8 and 2.9 friendly. I'll report back when I know more :)

I think the ast rewrite is a bit more reliable and it might just work in 2.9

I solved the original template error that blocked this in the early alpha/beta series. I assume this will land in the 2.9.0-beta.5 that ships next.
https://github.com/emberjs/ember.js/pull/14390/files
The issue now is that rerender doesn't seem to actually update the given template so I'll need to look at this further before I can identify the root cause. I'm out of bandwidth until Wed night next week but I do have this as my number 1 priority so we can continue to provide feedback during the glimmer 2 beta cycle

That's awesome. I'm not sure why rerender wouldn't work. I have some time tomorrow, but seems like you have a good handle on the 2.9 issue. I will try to explore the AST approach. I think that will remove the need to use the CP layout and might even fix the rerender.

@toranb I had a quick look into how glimmer is getting the template, while I think that using a CP is nice since it's useful for the first time to dynamically generate a template, it won't re-execute that code during a re-render since we only get the layout during lookup-component and we never update that. I think all the magic happens here:
function lookupComponentPair(componentLookup, owner, name, options) {
  let component = componentLookup.componentFor(name, owner, options);
  let layout = componentLookup.layoutFor(name, owner, options);

  let result = { layout, component };

  if (layout && !component) {
    result.component = owner._lookupFactory(P`component:-default`);
  }

  return result;
}

We would have to test this, but it seems like this is slightly different than what I remember seeing earlier. It's possible that the AST rewrite will work around this issue since the "layout" is always static, we will just re-render the yielded block.

@MiguelMadero great follow up and it makes total sense. I can now see why the CP for layout is a limitation vs the AST rewrite approach you've mentioned a handful of times now.

I was looking into something related at work and I found this in Glimmer 2, seems like one of the missing pieces of this puzzle:
https://github.com/emberjs/ember.js/blob/master/packages/ember-glimmer/lib/environment.js#L76-L86
this._definitionCache = new Cache(2000, ({ name, source, owner }) => {
      let { component: ComponentClass, layout } = lookupComponent(owner, name, { source });
      if (ComponentClass || layout) {
        return new CurlyComponentDefinition(name, ComponentClass, layout);
      }
    }, ({ name, source, owner }) => {
      let expandedName = source && owner._resolveLocalLookupName(name, source) || name;
      let ownerGuid = guidFor(owner);

      return ownerGuid + '|' + expandedName;
    });

I won't have time to look into this until late this week and I would like to wrap up the AST tests and land that PR, but I wanted to leave this here in case this helps.

To my surprise ... I loaded up 2.9.0 stable today and it seems to be working just beautifully

@toranb Ember 2.9.0 did no ship with Glimmer 2. It is now expected and available in 2.10.0 (beta.1)

@josemarluedke huh any tweet, blog or gh issue I can read to learn about why it was delayed? This is the first I've heard of it

@toranb i can confirm that glimmer was delayed. Essentially 2.9 === 2.8.2. The release was branched from the lts since glimme 2 wasnt 100% ready. The release blog post contains more official details.

It's odd, I replied via email yesterday but I don't see any of my messages.... Anyway, the release blog post. In summary:

In the Ember 2.9 beta blog post, we announced our intention to include the new Glimmer 2 rendering engine in the 2.9 release. However, after careful consideration, we have decided to temporarily hold off on the integration.

This means that 2.9 will ship with the same rendering engine as 2.8 and does not include any new features, notable changes or deprecations.

This is good for us, because that means that we support the "stable" for 6 more weeks and have time to make it work correctly before the official release.

Awesome! More time to get this working as you mentioned :)

Huh?
Keep in mind that 2.9 is not glimmer two, it was reverted. Can you try
2.10-beta?
On Sat, Oct 22, 2016 at 11:45 PM Toran Billups<EMAIL_ADDRESS>wrote:

Closed #18 https://github.com/toranb/ember-cli-hot-loader/issues/18.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/toranb/ember-cli-hot-loader/issues/18#event-832960263,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAC5HIa_froek8Ypgo7rfnET1cNhlUW6ks5q2soxgaJpZM4J5tLo
.

Sorry for being the party pooper. We will make it work in Glimmer 2. I can
have a look next week.
On Sun, Oct 23, 2016 at 12:30 AM Miguel Madero<EMAIL_ADDRESS>wrote:

Huh?
Keep in mind that 2.9 is not glimmer two, it was reverted. Can you try
2.10-beta?
On Sat, Oct 22, 2016 at 11:45 PM Toran Billups<EMAIL_ADDRESS>wrote:
Closed #18 https://github.com/toranb/ember-cli-hot-loader/issues/18.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/toranb/ember-cli-hot-loader/issues/18#event-832960263,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAC5HIa_froek8Ypgo7rfnET1cNhlUW6ks5q2soxgaJpZM4J5tLo
.

@MiguelMadero no worries - I reopened the issue w/ the title "Not glimmer 2 friendly" (to be agnostic of ember version)

Is there any update on this issue ? Ember 2.10 will be released in two week and I'm facing to an issue that seems related to glimmer 2 and ember-cli-hot-loader. When I do a change on a component, it reload it (not the full page but just the component) but there is no change on it. It load the thing.

@GCorbel unfortunately not yet. As far as I know there is an issue in Glimmer 2 in the place where the cache is stored. I have not had a chance to look into it, but I'm working on a Glimmer 2 project, so I may be able to have a look at it tomorrow.

@GCorbel Sorry for my lack of involvement here. Robert Jackson did mention that a templateCache exists in ember-glimmer/environment
so … conceptually
let environment = owner.lookup(‘service:-glimmer-enviornment’);
environment._definitionCache /// bust this up
@MiguelMadero this sound like it's something we could pursue (while we wait on the bigger/better AST rewrite work you have planned) ?

@toranb you're right.
I tried with this instance initializers and it works :
export function initialize(appInstance) {
  appInstance.__container__.lookup('service:-glimmer-environment')._definitionCache.limit = 1
}

export default {
  name: 'glimmer-cache',
  initialize
};

There is probably a better way to this.
@MiguelMadero and @toranb don't worry about the lack of work on this issue. This an open source project and you do not have to work on it and, more importantly, you have not to share it for free. Thanks for your work!

@GCorbel wow that's an epic workaround honestly :)
no worries on the work here -we had a blocker originally and it seems like we have a way forward here so 2.10 will work when it's released in a few weeks. I'll knock out a PR that @MiguelMadero can look over in the next 2 days. Ideally you just do what you did in ember 2.9 and "magic" it's reloaded :) without any special initializer work.
 Honestly didn't think people found this valuable (yet) as it's so young #good_to_know

I known this project by reading this article which was listed in the ember weekly of this week. It's very useful.
It seems I have this error message Error: EEXIST: file already exists, symlink '/frontend/tmp/broccoli_merge_trees-input_base_path-7gijyz6I.tmp/1/log-book/pods/components/delete-btn-form/template.js' -> '/frontend/tmp/broccoli_merge_trees-output_path-Mceiwyqw.tmp/log-book/pods/components/delete-btn-form/template.js' more often as issues because of the hot loader. It happens every 5 or 6 saves.

@GCorbel @toranb great finds. We can try to push this to our current cache invalidation hook and I can test in our 2.10 apps now that we have some of them :D
Unfortunately, the AST rewrite doesn't solve this problem, so this fix is still needed. The AST rewrite will simplify a few things and likely solve other issues, but I'm happy if we can get this one first.
@GCorbel re: EEXIST, can you open another issue and we can track it there?
Thanks for all your feedback and the workaround and I'm happy to hear that others are finding this useful, now we need to make it better :)

Woohoo! I had a quick look and using environment._definitionCache.store.clear() works, but we may be able to only remove the stuff we need to update.

@GCorbel @toranb I opened https://github.com/toranb/ember-cli-hot-loader/pull/28

@MiguelMadero @toranb Just wanted to say that I also think this project is very cool. I tried it in a new project (as in empty) and it worked very well. When I tried with my production app (which is not so small) I had a few problems, but I do want to try again ;)
This is a really good project, thanks for the effort!

@corrspt , Thanks for the kind words this is encouraging!
If you more info of any of the issues you found, please open an issue. We're always looking for opportunities to make this better.

When I get around to try it again (and I will, soon I hope), I'll create the issue. The problem at the time was that I couldn't "isolate" what was causing the issue so that I could provide a reproduction. But I'll do better next time!
Thanks again!


No way of clearing a field set against a work item

In Settings I accidentally selected the wrong Work Item Type to update, and assigned a field to it. However, there is now no way at all to set this field back to null/blank. So I cannot clear Bug work type to have no field associated with it. I can change it to any other field, but cannot clear it.

Hi! @nataliia-ckb  Thanks for reporting, can you check if you get any errors in the browser console or network log

Hi @AminTi, thank you! Just checked, don't see anything unusual apart from the error message I quoted here, but I don't think it's related.
Sorry, forgot to say I tried this in Chrome and Safari and I assumed it was just a UI issue. Once a field is selected, there is no X/"delete"/clear button. So I can search from the list I screenshotted and change the field to anything else (and it works absolutely fine), but no way to "reset" it. I did scroll through the list of options and they were just fields, there wasn't anything that said "blank" or "clear" etc.

Hi again, it will be fixed in an upcoming release.


Fix missing gradle profiler report

We seemed to accidentally remove gradle profiler reporter when removing slack reporter.

@bot-gradle test this

OK, I've already triggered ReadyForMerge build for you.

Seems to be working.


decoder: h264: Use Cow instead of slice

Fixes #44
Partially address #49
Relies on chromeos/cros-libva#10

I tested the changes using fluster and there seems to be no effect on the test results

So unfortunately I am getting test failures on AMD when decoder: h264: vaapi: Use slice arrays instead multiple buffers is applied...
---- decoder::stateless::h264::vaapi::tests::test_25fps_nonblock stdout ----
thread 'decoder::stateless::h264::vaapi::tests::test_25fps_nonblock' panicked at src/decoder/stateless.rs:399:21:
assertion `left == right` failed: at frame 0
  left: "f3fd3133"
 right: "3eae0fa4"
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

---- decoder::stateless::h264::vaapi::tests::test_25fps_block stdout ----
thread 'decoder::stateless::h264::vaapi::tests::test_25fps_block' panicked at src/decoder/stateless.rs:399:21:
assertion `left == right` failed: at frame 0
  left: "f3fd3133"
 right: "3eae0fa4"

Possibly AMD doesn't like slice arrays? That would be quite an issue...

Pushed the first 3 commits (and an update to cros-libva so build passes on the PR) - let's see if we can figure out the AMD issue...

Possibly AMD doesn't like slice arrays? That would be quite an issue...

Yeah, I can confirm the AMD does not like slice arrays (source). Assert fails on debug mesa.

I'm wondering the reason for this limitation - tried to look at related issues on Gitlab, but could not find a matching one. Maybe we should open a bug?

I'm wondering the reason for this limitation - tried to look at related issues on Gitlab, but could not find a matching one.

When I briefly looked at the code it seemed if I understand it correctly, the slice data is submitted to the hw on vaRenderBuffer, so I think it's just a design choice.
I wonder how other users approaches this issue and if it is an Intel driver issue. I tried running ToT ccdec with video generated using gst-launch-1.0 videotestsrc num-buffers=1000 ! 'video/x-raw,width=320,height=240,format=NV12' ! x264enc option-string="slices=100" ! filesink location=a.h264 and checked the md5 with ffmpeg and checksums were the same.

Maybe we should open a bug?

Nevertheless I think it could be worth it


Add extra commands in the "/help" command.

Just a few commands I think that are important that are missed out.

if we're going to be updating this, I personally feel that we don't need to tel users about the /avatar command because it's mostly useless in comparison to the menu, which the command just tells them to use anyways.
Also I personally think /msg should be changed to /pm since all the experience I've had trying to explain how to pm a user, more users understood what /pm might do rather than /msg

SolarisFox I agree on the PM one but I think the avatar one should stay.

@Soku-Hi, can you explain why you think the avatar one should stay?

@Zarel I always use /avatar and never use the other way so many it's just a preference thing.

Unless you already know which avatar you want, and its code, the GUI is much better for that.
Also, the syntax for /chall is not user-friendly for formats with teams. I have gotten a lot of bug reports from people who do that (my answer was always "don't do that")

@Slayer95 changes will be made!

@Slayer95, actually, /chall is fine now, you're probably referring to an older implementation of /chall.

@Zarel @Slayer95 @SolarisFox So am I getting rid of "/avatar" and replacing "/chall" with "/challenge"? (I can't squash tonight as I'm on my phone).

Also I know "/chall" is fine but "/challenge" seems more correct.

Sorry about was having copy and pasting issues from my other commits I was copying the "+" signs as well. :(

rip unknown repository


[ICON REQUEST]: Add CO2 icon for suistanable products

Icon name
CO2
Use cases

Carbon saving
Carbon consumption

Design ideas
CO2 Text
Checklist

[X] I have searched if someone has submitted a similar issue before and there weren't any. (Please make sure to also search closed issues, as this issue might already have been resolved.)
[X] I have searched existing icons to make sure it does not already exist and I didn't find any.
[X] I am not requesting a brand logo and the art is not protected by copyright.
[X] I am not requesting an icon that includes religious, political imagery or hate symbols.
[X] I have provided appropriate use cases for the icon(s) requested.

This is the best CO2 text feasible within our design system (1px padding, 2px spacing, using existing elements from list-numbered and CC), but I really don't think it's up to par (too small, too sparse):

<svg
  xmlns="http://www.w3.org/2000/svg"
  width="24"
  height="24"
  viewBox="0 0 24 24"
  fill="none"
  stroke="currentColor"
  stroke-width="2"
  stroke-linecap="round"
  stroke-linejoin="round"
>
  <circle cx="13" cy="12" r="3" />
  <path d="M22 19.2h-2c0-1.004 2-2.004 2-3s-1-1.504-2-1" />
  <path d="M6 9.3a2.8 2.8 0 0 0-3.5 4.4 2.7 2.7 0 0 0 3.5 1" />
</svg>

An alternate idea for this use case is using leaf for carbon emission.


[FEATURE] Run integration tests as part of the OpenSearch distribution

Is your feature request related to a problem?
Following a problem in another plugin (https://github.com/opensearch-project/opensearch-build/issues/2043), and coming from https://github.com/opensearch-project/opensearch-build/issues/58, there's no automated testing that this plugin runs as part of the OpenSearch distribution.
What solution would you like?
Run integration tests as part of the distribution.

we support both :integTest & :integTestRemote gradle tasks which allows running integration tests as part of the OpenSearch distribution.


ACS-6793 Expand free disk space action

Checklist

Jira Reference (also in PR title): https://alfresco.atlassian.net/browse/ACS-6793

README updated after adding/changing behaviour of an action

Proposed version increment for release:

[ ] Patch (bugfix)
[X] Minor (new feature)
[ ] Major (breaking changes)

External PR link where changes has been tested:
https://github.com/Alfresco/acs-packaging/pull/2698

Description
For some tests the original action was not freeing up enough memory, so we decided to implement optional steps to help with that

Note: to fix pre-commit (extra whitespace at the end of the sentence): https://github.com/Alfresco/alfresco-build-tools/actions/runs/8187524258/job/22388181314?pr=524


Issue316

My first time attempt of contributing to the awesome project!
Any feedback is welcome!

This pull request implements the command mentioned in Issue #316 (Search command)

Coverage remained the same at 100.0% when pulling b8d06227b2448f09c8b8b9250e77f69fd272f60b on stijnbrouwers:Issue316 into 51ac522e5b8e473a454a67fec451f216110bde7c on pnp:dev.

Awesome! Welcome aboard and I will review the PR shortly. For the next time, please let us know you're working on an issue. It would be a shame if someone else was working on it as well.

Hi Waldek,
First of all, thanks for your great feedback!
Regarding 'For the next time, please let us know you're working on an issue.': I know this is the normal procedure but wasn't sure how much time I could commit and if I was able to pull it off since JS isn't my "core language" :-). If someone else would have worked on it, I would just have dropped my changes and seen it as a learning experience.
Regarding the review:
I think I implemented all changes including the JSON output. I also have a placeHolder for the 'rawResults' I just need it as a valid option for the 'output'-parameter. As I understand, this is something that does not need implementation from my side and needs some more planning? When it's available, I'll be able to just uncomment my code and it should work.
Again, thanks for reviewing so quickly!

As for the raw output, I've been thinking that it should be something specific to your command. Because we don't need it in any other command right now, for now, we could do it behind a --rawOutput option in your command. That way, we have the flexibility in your command, without having to implement it in all other commands.

Allright, I just did the change!
Everything should be fine now.

Perfect! Thank you! I'll review it shortly.

Sorry for the trouble, but I'm getting merging conflicts when trying to squash the commits into one. Since you have built the command, would you mind rebasing your fork to get the latest changes from the upstream so that we can be sure that nothing is lost in the process? Thank you, and don't hesitate to reach out if I can help with anything.

Hey @waldekmastykarz ,
No problem. The rebase has been done, please let me know if you need anything else!

Awesome! Appreciate your help and the quick turnaround

Hey @stijnbrouwers, it seems that I still can't rebase to dev without merge conflicts. You should be able to repro what I'm seeing by doing:

git checkout dev
git pull upstream dev
git checkout Issue316
git rebase dev > here is where I'm getting merge conflicts

Hi Waldek,
I think it's best if I create a new branch with the changes.
Something seems to have gone terribly wrong while merging/commiting and it currently is an immense mess :-s
Commits have been replicated and stuff like that so the history of my GIT is bloating.
Since the changes are quite isolated I think it's fastest and easiest just to start from scratch in a new branch. What do you think?

Let's do that, just to ensure that we don't mess up anything else. Thank you for helping out. I'll close this PR and will wait for a new one, ok?

I just opened the new one (#683 ).
Sorry for the inconvenience with this rebasing issue.
Don't really sure I understand what went wrong though...


Point cloud to world frame transformation

Describe the feature you'd like
When working with point clouds, sometimes we want to express them in the world (or robot base) frame.
I currently do this with a method proposed by @Victorlouisdg through Open3D:
pcd_in_camera = point_cloud_to_open3d(point_cloud)
pcd = pcd_in_camera.transform(X_W_C)
point_cloud = open3d_to_point_cloud(pcd)

Do we want to create a function for this in the camera toolkit (leaving possibilities for future optimisations, I haven't checked the performance implications yet of the above conversions to and from Open3D. I'm assuming it's fairly cheap because it's zero copy)?
Use cases

Merging point clouds from different cameras (e.g., with ICP)
Logging point clouds to, e.g., rerun

Possible implementation
We could wrap the above code snippet into a function named transform_point_cloud, which could go into https://github.com/airo-ugent/airo-mono/blob/main/airo-camera-toolkit/airo_camera_toolkit/point_clouds/operations.py

Actually you can do the following w/o going to open3D:
# assumes pc is an Nx4 array with homogeneous points.
pc_in_A = (X_A_B @ pc_in_B.T).T

In terms of adding a function for this, we could do that if required/desired.
I think the pc operations are indeed the best place to add them.  There is actually already a helper class in the spatial-algebra package, that could be used, we can simply wrap it: https://github.com/airo-ugent/airo-mono/blob/main/airo-spatial-algebra/airo_spatial_algebra/operations.py.

So if I get it correctly, we would only need to wrap operations.transform_points, because the point cloud positions is a Vectors3DType.
Since Open3D conversion is not required in that case, then perhaps adding an additional function for this is overkill.
(For me this was about reducing a 3-line operation + imports to a one-liner, but transform_points does the same)

So if I get it correctly, we would only need to wrap operations.transform_points, because the point cloud positions is a Vectors3DType.

indeed!

Since Open3D conversion is not required in that case, then perhaps adding an additional function for this is overkill.

on the other hand it will be easier to find. So I think it could still be a good idea


Makes the stand-alone runtime.c the fibonacci benchmark with some ifndefs

Saw the issue and decided to fix it.

Not sure I get it, that means every compilation will jet injected the FIB function, even if unrelated?
Has --single-thread been removed?

expressions to be replaced like in the comment I quoted

I'll implement this.

I closed the original issue (#53) by other means. Now we just have to decide if we keep a default program on runtime.c or not.

Hi, any updates on the state of the review of this PR? Can it be merged?


[KIE-859] make drools quarkus extension build reproducible

@yurloc  see this

Please add a comment that this workaround can be removed once we upgrade to a Quarkus version that contains this fix: https://github.com/quarkusio/quarkus/pull/38365.

Please add a comment that this workaround can be removed once we upgrade to a Quarkus version that contains this fix: quarkusio/quarkus#38365.

@yurloc @lucamolteni done


Spock changes and shield style for CircleCI badge

Update spock to 1.1
Fix some small errors in the parameter injection
Use shield style for CircleCI to better fit with the other shields

Don't worry.

it is just a fix for the tests that does not fail in this case, but I reworked it a bit when contributing this methodology to Gradle itself and thereby found some minor issues I thought I PR here too.
Long ago I remembered why I don't like the approach you take with this plugin and don't use it anyway. :-)

Ok -- I will be making some changes soon to deal with a new version of JGit and maybe include some small enhancements to deal with submodules.
BTW, what is it that you didn't like with the approach? I will try to improve it if I can. :)

Unlikely, it is the whole concept.
I don't like having access to the VCS being necessary to build the software.
It is ok to query some information from the VCS, storing it in some file e. g., but it shouldn't fail if VCS is not available.
If you e. g. export the sources, you suddenly cannot build it anymore.
Or if you use e. g. HanDouts and its server-side checkout feature, the build agent also has no access to the VCS.

Well, I built this largely to work with versioning with VCS, so that was a core assumption. So yes; it's unlikely that I will change this.

I know, that's why I didn't ask for it. :smile:


Create KliKli-milestone_1.md

upload milestone
Milestone Delivery Checklist

[x] The milestone-delivery-template.md has been copied and updated.
[x] The invoice form :pencil: has been filled out for this milestone.
[x] This pull request is being made by the same account as the accepted application.
[ ] In case of acceptance, the payment will be transferred to the initial ETH(USDT/CRU) payment address.
[ ] The delivery is according to the Guidelines for Milestone Deliverables.

update PR Link ，Please look over

update PR Link


Fix parsing facilities responses

Fix parsing facilities responses without FACILITY_ADDRESS or CAMPGROUND_RECREATION_AREA by adding except KeyError
Sample facility response from 89898:
{'FacilityID': '', 'LegacyFacilityID': '', 'OrgFacilityID': '', 'ParentOrgID': '', 'ParentRecAreaID': '', 'FacilityName': '', 'FacilityDescription': '', 'FacilityTypeDescription': '', 'FacilityUseFeeDescription': '', 'FacilityDirections': '', 'FacilityPhone': '', 'FacilityEmail': '', 'FacilityReservationURL': '', 'FacilityMapURL': '', 'FacilityAdaAccess': '', 'GEOJSON': {'TYPE': '', 'COORDINATES': None}, 'FacilityLongitude': 0, 'FacilityLatitude': 0, 'Keywords': '', 'StayLimit': '', 'Reservable': False, 'Enabled': False, 'LastUpdatedDate': ''}

It seems to be reservable as it looks reserved from July to Sept, but yeah I think the campsite is just missing info

Yeah, it does looks to be bookable from the UI. I see some information we can gather at a new endpoint below, but this would require some fallback logic when the ridb.recreation.gov endpoint doesn't return Address information https://www.recreation.gov/api/camps/campgrounds/234262
The campsite itself has availability information here so there's no problem with searching: https://www.recreation.gov/api/camps/availability/campground/234262/month?start_date=2021-09-01T00%3A00%3A00.000Z
The last issue is that camply currently filters to Reservable = True and Enabled = True here. Overriding this opens a can of worms because campsites like this one in Yosemite will show up on searches.

So with all that being said, there's two options here:

Merge this pull request and that's it

This option will stop the error from being thrown but will exclude campsites like https://www.recreation.gov/camping/campsites/89898 from being searched moving forward anyways since it's not Reservable or Enabled

Merge this Pull Request and add a backlog ticket to workaround when Address Information Isn't Returned and When the campsite isn't Reservable/Enabled - but still looks like it's bookable.


U-boot 2020.01 and serial console

Dear all,
I am trying to understand how to change the default pin of the u-boot (2020.01) console for the Raspberry pi CM3+ board.
I am using yocto with meta-raspberrypi on the dunfell branch and how everything works between the first stage bootloader, u-boot, u-boot internal device tree and the kernel device tree is not really clear to me.
Here is what I would like to achieve:

Get UART0 or UART1 as the standard console for u-boot and the linux kernel on pins 32 and 33

Make u-boot pass my device tree (stored in the boot partition) to the kernel and not the device tree generated by the first stage bootloader

Regarding the first point, I already created a new device tree within u-boot and set it as the default bootloader in my default config (see attached files).
Here is the different things I tried:

Use UART0 on pins 32 and 33

In the u-boot device tree:
chosen {
    stdout-path = "serial0:115200n8";
}
...
&uart0 {
    pinctrl-names= "default";
    pinctrl-0 = <&uart0_gpio32>;
    status = "okay";
}

In the config.txt:
enable_uart=1
dtoverlay=uart0,txd0_pin=32,rxd0_pin=33,pin_func=7

This works but only for the kernel, I don't get any output from u-boot and can't stop the boot process.

Use UART1 on pins 32 and 33: more or less the same modification but with different values

I would like to know if there is another file I should modify to get this working. When I use the uart0 or uart1 on pin 14 and 15 everything works properly.
The second point seems pretty clear to me. I will change the bootscript and load the file with the fatload command and pass it to the kernel. However, I wonder if it might create some problems if the first stage bootloader has already reserved the pins.
Finally, when u-boot is starting correctly I have the following warning and I was not able to find any explanation for it:
U-Boot 2020.01 (Jan 06 2020 - 20:56:31 +0000)

DRAM:  948 MiB
RPI Compute Module 3+ (0xa02100)
MMC:   mmc@7e202000: 0
Loading Environment from FAT... **WARNING at drivers/mmc/bcm2835_sdhost.c:410/bcm2835_send_command()!**
**WARNING at drivers/mmc/bcm2835_sdhost.c:410/bcm2835_send_command()!**
*** Warning - bad CRC, using default environment

In:    serial
Out:   vidconsole
Err:   vidconsole
Net:   No ethernet found.
starting USB...
Bus usb@7e980000: scanning bus usb@7e980000 for devices... 1 USB Device(s) found
       scanning usb for storage devices... 0 Storage Device(s) found
Hit any key to stop autoboot:  0
**WARNING at drivers/mmc/bcm2835_sdhost.c:410/bcm2835_send_command()!**
**WARNING at drivers/mmc/bcm2835_sdhost.c:410/bcm2835_send_command()!**
switch to partitions #0, OK
mmc0(part 0) is current device
Scanning mmc 0:1...
Found U-Boot script /boot.scr

Should I simply ignore it ?
Thank you in advance for your time.
Best regards
Romain
0002-rpi_cm3_digisens_defconfig.txt
0004-digisens-dtb.txt

U-boot 2020.01 is not provided by oe-core anymore. The current latest version is 2021.10. Please try to reproduce the issue against the current version but nevertheless I would suggest you to follow it up with the u-boot project.


Evaluation with Pascal VOC2007 classification

Hi there,
For this multi-label datasets, I used sklearn MultiOutputRegressor with estimator logisticRegression and tested it with several models. All scores I got are significantly higher than corresponding score in Table 10: ResNet50 89.1 (83.8 CLIP), ResNet101 88.7 (84.4 CLIP), Efficientnet_b0 88.6 (84.4 CLIP), CLIP_VIT_B32 89.2 (87.7 CLIP).
I'm wondering if my evaluation logic for this multi-label dataset is different from yours, since MultiOutputRegressor trains 20 estimators under the hood. However, with a single logisticRegression model, it handles single label problem only.  Could you share more information of how you do linear probe with this multi-label dataset?

Hi, can you provide your evaluation code in computing accuracy score? @meigaoms Maybe I have some mistakes in calculating mAP score.


Add Monograph DCTAP

Good call. I've updated the names. We'll have to discuss with the interlingua group if it's ok to change the file names in the Google sheet so that we don't have to do this every time we download the files.


chore(deps): update dependency @dcos/http-service to v2.3.1

This PR contains the following updates:

Package
Type
Update
Change
References

@dcos/http-service
dependencies
minor
2.0.0 -> 2.3.1
source

Release Notes

dcos-labs/http-service
v2.3.1
Compare Source
Bug Fixes

xhr: fix typo preventing responseHeaders from showing (e7e6b63)

v2.3.0
Compare Source
Features

expose reponse header (8674173)

v2.2.0
Compare Source
Features

expose reponse header (8674173)

v2.1.0
Compare Source
Features

expose reponse type on requests (a17a94b)
expose response type on requests (#28) (4d203ec)

2.0.2 (2019-02-19)
2.0.1 (2019-02-15)
v2.0.2
Compare Source
2.0.2 (2019-02-19)
v2.0.1
Compare Source
2.0.2 (2019-02-19)

Renovate configuration
:date: Schedule: At any time (no schedule defined).
:vertical_traffic_light: Automerge: Disabled by config. Please merge this manually once you are satisfied.
:recycle: Rebasing: Whenever PR becomes conflicted, or if you modify the PR title to begin with "rebase!".
:no_bell: Ignore: Close this PR and you won't be reminded about this update again.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

PR has been edited
:construction_worker: This PR has received other commits, so Renovate will stop updating it to avoid conflicts or other problems. If you wish to abandon your changes and have Renovate start over you may click the "rebase" checkbox in the PR body/description.


README: Change shim path in virtc README

The shim installation path has been changed to
/usr/libexec/clear-containers.
Signed-off-by: Archana Shinde<EMAIL_ADDRESS>

Coverage remained the same at 67.055% when pulling fcceae724de408d35310769665d4478d82c236a5 on amshinde:change-shim-path into 01c872512aff76d2aa46e7481a46051ba18bcb2b on containers:master.

lgtm


clean snyk report

[STACS-Vulnerabilities]
📲 What
Updating libs/deps according to the snyk report
🤔 Why
To improve security
🛠 How
Updated libs based on the report generated by snyk test
👀 Evidence

🕵 How to test
Just build
✅ Acceptance criteria Checklist

[ ] Code peer reviewed?
[ ] Documentation has been updated to reflect the changes?
[ ] Passing all automated tests, including a successful deployment?
[ ] Passing any exploratory testing?
[ ] Rebased/merged with latest changes from development and re-tested?
[ ] Meeting the Coding Standards?

Hey, what's the Snyk.Fixes folder for please?

Hey, what's the Snyk.Fixes folder for please?

Not sure, I think it's a byproduct of unsuccessful build attempts until I found the instructions. I've removed it. Also I'm looking to restore the line endings to CRLF instead of LS, as it creates unnecessary diffs

Hey, what's the Snyk.Fixes folder for please?

Not sure, I think it's a byproduct of unsuccessful build attempts until I found the instructions. I've removed it. Also I'm looking to restore the line endings to CRLF instead of LS, as it creates unnecessary diffs

Thanks, also the files should all be LF, it's in the .gitattributes and was a conscious decision 🙂

You'll see here we deliberately set LF: https://github.com/amido/stacks-dotnet/blob/master/.gitattributes#L1

Hey, what's the Snyk.Fixes folder for please?

Not sure, I think it's a byproduct of unsuccessful build attempts until I found the instructions. I've removed it. Also I'm looking to restore the line endings to CRLF instead of LS, as it creates unnecessary diffs

Thanks, also the files should all be LF, it's in the .gitattributes and was a conscious decision 🙂

Yes, the differences I was seeing was because of the extra folder, it's removed now, redid some updates, should be ok now.
Still noob in .net and VS :P

@johnsall No worries, thanks for doing the updates! 🙂

Once this is merged in a PR will need to be made to stacks-webapp-template to update the SHA used by the Stacks CLI tool. I can show you how to do this after it's merged in if you'd like! 🙂

Once this is merged in a PR will need to be made to stacks-webapp-template to update the SHA used by the Stacks CLI tool. I can show you how to do this after it's merged in if you'd like! 🙂

yes please, I'm still feeling my way around stacs AND .net

Thanks for this!


Feat/565 countdown remaining letters

Description

The latest update enables the addition of a maxLength attribute for input fields and textareas. Once this attribute is included, a countdown message will be displayed below the respective input or textarea, indicating the remaining characters allowed.
PR for documentation: https://github.com/Altinn/altinn-studio-docs/pull/934
Related Issue(s)

closes #565

Verification/QA

Manual functionality testing

[x] I have tested these changes manually
[ ] Creator of the original issue (or service owner) has been contacted for manual testing (or will be contacted when released in alpha)
[ ] No testing done/necessary

Automated tests

[ ] Unit test(s) have been added/updated
[x] Cypress E2E test(s) have been added/updated
[ ] No automatic tests are needed here (no functional changes/additions)
[ ] I want someone to help me make some tests

UU/WCAG (follow these guidelines until we have our own)

[x] I have tested with a screen reader/keyboard navigation/automated wcag validator
[ ] No testing done/necessary (no DOM/visual changes)
[ ] I want someone to help me perform accessibility testing

User documentation @ altinn-studio-docs

[x] Has been added/updated

[ ] No functionality has been changed/added, so no documentation is needed
[ ] I will do that later/have created an issue

Changes/additions to component properties

[x] Changes are reflected in both src/layout/layout.d.ts and layout.schema.v1.json, and these are all backwards-compatible
[ ] No changes made

Support in Altinn Studio

[x] Issue(s) created for support in Studio

[ ] This change/feature does not require any changes to Altinn Studio

Sprint board

[x] The original issue (or this PR itself) has been added to the Team Apps project and to the current sprint board
[ ] I don't have permissions to do that, please help me out

Labels

[x] I have added a kind/* label to this PR for proper release notes grouping
[ ] I don't have permissions to add labels, please help me out

Is the textarea from the design system making the unit tests fail? Or is the problem on this end?

Is the textarea from the design system making the unit tests fail? Or is the problem on this end?

The unit tests are failing because of a problem within the design system. I have created a PR that should fix this. :)


Caching implementation analysis and implementation for PFCOUNT

Benchmarking for current PFCOUNT implementation
Analyse if caching is required for PFCOUNT as done by Redis here
This might be required as computing the cardinality from an HLL involves merging multiple HLLs. Without caching, every time PFCOUNT is called, we would need to recompute the cardinality from the raw HLL data this is expensive.

I would like to take this up. Can you assign it to me?

@Dev79844 assigned, thanks for picking this up.

Hello @Dev79844,
There has been no activity on this issue for the past 5 days.
It would be awesome if you keep posting updates to this issue so that we know you are actively working on it.
We are really eager to close this issue at the earliest, hence if we continue to see the inactivity, we will have to reassign the issue to someone else. We are doing this to ensure that the project maintains its momentum and others are not blocked on this work.
Just drop a comment with the current status of the work or share any issues you are facing. We can always chip in to help you out.
Thanks again.

@arpitbbhayani I am sorry for the delay, I will finish this issue in this week itself


Can the provided models perform multi-label classification?

The provided code examples provide a good example of single label classification (e.g. rvlcdip). But can this be easily extended to multi-label classification? I'm a bit new to models where the predicted label is the actual textual representation of the label versus an integer. In the latter case multi-label can be provided through one-hot encoding an array of possible labels; does UDOP have a similar extension from single label to multi-label? How would one do it?

For multi label (and single!) I think the general approach is to add special tokens to the tokenizer (I.e. <CLASS_2/>) and train the model to predict the relevant class tokens for each input

We are a generative open vocabulary model so the answer should be yes. We have a text decoder to generate text so there is no reason UDOP can't generate text.


Hatch Tribute on the Pie Chart for MIN Raise does not show

When you scroll over everything else does but Tribute


Mobile UI - Assets, Pools, Pool Detail

Add hooks for window size and window scroll position
Tweak overview component

Closes #380

Repurposing to close #368 (after merging #144), close #369, and ultimately close #346.

Update: due to @Thunnini working on trading functionality, this will exclude responsive UI for that functionality.

@delivan Feel free to review!

@jonator UX/UI Review:

deposit/withdraw process needs to continue in one modal (no overlapping modal)
"Hide zero balance" toggle button looks more big than the design
sorting drop-down looks more big than the design
Pool table item cannot be clicked(not be linked to pool detail page)
padding values does not match the design of the pool detail page as a whole

@delivan ===> @victortokaito and I have discussed the button size issue, but otherwise the other issues are fixed

@delivan Ready for review.

(On desktop) If num of my pools is ≤ 6 in My Pools section, the show more button should not be shown.
(On mobile) If num of my pools is ≤ 3 in My Pools section, the show more button should not be shown.

@delivan @victortokaito I've updated from your feedback

@delivan I've fixed the first bullet. For the second bullet I've created a bullet in issue #362 to fix all wallet connection logic together as I noticed "sign out" was not working either.
What do you mean on the last bullet? Like UI feedback? There is a gold outline that appears on focus

Oops, Never mind. I didn't connect wallet so nothing happened.
Now LGTM! Let's go further.


Weirdy McWeirdFace - Snow Edition

No idea what's going on here.
Cannot state how to recreate.

Closing for now


tabel prefix?

I am using a prefix in my table names: tbl_.
I do not use the Yii2 prefix, but this does not matter.
I generate class names without tbl_ as is recommended.
This setup is not possible in enchanced-gii. The code generated always gives classes the tbl prefx name.
Is it possible to give the table name a prefix, but the class names no prefix?

Do you use . (dot), at the end of your prefix? -> ex : tbl_.persons
How about the generated model with check on 'use table prefix'?
maybe the generated CRUD is not support prefix yet, i'll test that..

If I use tbl prefix the generator only uses it for the master table, not for the relations. Hence, the class names have tbl in the name.
I do not use a dot in the name.

Thanks!

Hi! Have you tried the new version with table prefix?

I will do it in the afternoon.


Github workflow for linting (flake8, black, isort) and testing

Github workflow for linting (flake8, black, isort) and testing, can look here for an example.
Also fix flake8 issues if there are any. Lets discuss things like "function too complex" prior to implementation changes though.
Failing unit tests can be ignored for the scope of this, we will tackle those separately.

PR here: https://github.com/fullctl/fullctl/pull/4


Raise LuckyRecord::RecordNotFoundError for first, last etc. when a record is not found

Right now it raises for find but not for first, last etc.
Similar to
https://github.com/luckyframework/lucky_record/blob/acdc00a3237e186f5a391123bca189149aa9453c/src/lucky_record/queryable.cr#L39
This requires:

Making sure first and last raise the error: results.first? || raise RecordNotFoundError.new(...the_args)

Closed by #156 and #150


[Deals Page] Email us button in Employees Benefit

The email behind the "Email us" button in the Employees Benefit is now the<EMAIL_ADDRESS>In this page that should be<EMAIL_ADDRESS>Also, please make the mailto: so that it includes the subject line "Employees Benefit Enquiry".
Thanks 👍

@RohrerHope I don't understand your initial description. It's confusing. Which email is the correct one?

@RohrerHope I don't understand your initial description. It's confusing. Which email is the correct one?

The correct one is<EMAIL_ADDRESS>:)
Please add a Subject element to the mailto: like "Employees Benefit Enquiry", if possible.
Thanks 👍🏼

@RohrerHope @lcoenen this was altered and pushed over set-up-deal-pages
Note:
The subject line can't be added as per the usual ?subject=abc link. As this is a <form action="#" method="get" request button, I'll have to inform myself what other option we have to add the automated subject line.
As for now, this is to be considered as solved.

Pushed to staging


Page edit view incorrectly reporting dirty rich text in Firefox

Issue Summary
When editing a page that contains Draftail rich text (either as a RichTextField or as a RichTextBlock in a StreamField), navigating away sometimes presents a warning that the page has been changed, even though it hasn't.
This happens for me consistently in Firefox 64, although I haven't been able to reproduce in other browsers. Specifically what is happening is this:

The JSON representing the rich text is generated in a nicely formatted way, with line breaks and indents:
https://github.com/wagtail/wagtail/blob/882f8f3cf8ddd79c30e611a48882b309e90dad0c/wagtail/admin/rich_text/converters/contentstate.py#L87

The page edit view HTML contains this JSON as the <input value>, including those line breaks and indents:

The dirty form check's initialData (generated via $form.serialize()) gets set with a serialized version of that initial value, including line breaks:
https://github.com/wagtail/wagtail/blob/882f8f3cf8ddd79c30e611a48882b309e90dad0c/wagtail/admin/static_src/wagtailadmin/js/core.js#L59

Certain seemingly innocuous events cause the <input value> to change, removing the line breaks and indents:

I can make this happen by highlighting the <input> in Firefox Developer Tools and (less predictably) by clicking away to another tab and coming back. Some event seems to cause the normalization of this value to clean it up.
At first I thought this might be some Firefox quirk around handling of special characters within <input value>, but I couldn't reproduce it using some manually generated HTML with the same content. So my guess is this is somehow related to how/when Draftail/Draft.js monitors/updates its state, but I don't know enough about those internals to pinpoint it further.

Because the <input value> has been changed, the subsequent dirty form check here always fails:
https://github.com/wagtail/wagtail/blob/882f8f3cf8ddd79c30e611a48882b309e90dad0c/wagtail/admin/static_src/wagtailadmin/js/core.js#L68
This presents the user with a warning when navigating away, even though they haven't done anything.

Steps to Reproduce

Start a new project with wagtail start myproject

Create a simple page type in models.py:
class TestPage(Page):
    body = RichTextField()

    content_panels = Page.content_panels + [
        FieldPanel('body'),
    ]

Create an instance of this page, entering some content in the body field.

Save the page, then, after it reloads, try navigating away. You'll see a warning even though you didn't make any further changes.

A simple fix that works for me is to modify this line to remove the nice formatting (just remove the indent=4, separators=(',', ': ')). This makes the JSON more normalized upon first load, and so subsequent refreshes don't change it. This does have the slight downside of making the page HTML less readable, and also still relies on the Python JSON formatting exactly matching what the browser regenerates.
Another option would be to add some kind of initial refresh before initialData is saved in the dirty check, to ensure that whatever formatting Draftail/Draft.js wants to do to its content happens once before we save the reference state.
Ping @thibaudcolas - any idea what is happening here?

I have confirmed that this issue can be reproduced as described on a fresh Wagtail project: yes

Technical details

Python version: 3.6.3
Django version: 2.1.4
Wagtail version: 2.5a0 (current master)
Browser version: Firefox 64.0

I think I'm seeing this in Chrome too, with a blank rich text field that I click on and then click away from. Chrome debugger shows that initialData contains:
body=%7B%0D%0A%20%20%20%20%22blocks%22%3A%20%5B%0D%0A%20%20%20%20%20%20%20%20%7B%0D%0A%20%20%20%20%20%20%20%20%20%20%20%20%22key%22%3A%20%228enu2%22%2C%0D%0A%20%20%20%20%20%20%20%20%20%20%20%20%22type%22%3A%20%22unstyled%22%2C%0D%0A%20%20%20%20%20%20%20%20%20%20%20%20%22depth%22%3A%200%2C%0D%0A%20%20%20%20%20%20%20%20%20%20%20%20%22text%22%3A%20%22%22%2C%0D%0A%20%20%20%20%20%20%20%20%20%20%20%20%22inlineStyleRanges%22%3A%20%5B%5D%2C%0D%0A%20%20%20%20%20%20%20%20%20%20%20%20%22entityRanges%22%3A%20%5B%5D%0D%0A%20%20%20%20%20%20%20%20%7D%0D%0A%20%20%20%20%5D%2C%0D%0A%20%20%20%20%22entityMap%22%3A%20%7B%7D%0D%0A%7D

While $form.serialize() gets:
body=null

Python version: 3.7.2
Django version: 2.1.4
Wagtail version: 2.4
Browser version: Chrome 72.0.3626.96

Like @chosak with content in the field even where JSON is equivalent I'm seeing it pretty printed versus inline, and key order changing. Seems like a case of needing canonical JSON?
I have worked on an app that had to do this as JSON data was hashed on both Python server and JS client.

I can think of two reasons for this to happen:

What you’ve already mentioned - the serialised format is different client-side and server-side.
The editor will attempt to save (serialise) content whenever the user interacts with it (e.g. focus), regardless of whether content actually changed.

I think it would be possible to prevent the editor from saving when it’s not actually needed, but there will always be cases that can't be handled (variations of the user making edits and then undoing them). If it seems possible to have the same serialisation format on the client and server, it’s probably worth trying first.

@chosak

A simple fix that works for me is to modify this line to remove the nice formatting (just remove the indent=4, separators=(',', ': ')). This makes the JSON more normalized upon first load, and so subsequent refreshes don't change it. This does have the slight downside of making the page HTML less readable, and also still relies on the Python JSON formatting exactly matching what the browser regenerates.

do you think this fix would be worth integrating into Wagtail? I'm worried of its reliability, but you might have more insight based on how it's worked for you so far.

@thibaudcolas while I believe this would fix the problem, the right fix is probably to do it client-side.
I don't know that we can or should assume that Python JSON formatting exactly matches how the browser JSON formats the same information. The JS code is the place where dirtyness is being detected so it feels like that's where the canonical initial state should be generated (even if in practice it's a superfluous decode/encode).
To do this client-side, something would have to happen to the form element (I'm not sure what) so that the initial $form.serialize call would always match subsequent calls. Right now that initial call seems to return the initial data in its exact original form, preserving line breaks, whereas subsequent calls actually generate it from the form inputs.
Would it be possible to force the editor to do an initial save/serialize of content right after it's first initialized (but before the enableDirtyFormCheck is set up)? This would persist a client-side-serialized version of the data as the initial version instead of relying on the version from the backend.

Good question. It sounds like something I wouldn't want to have to orchestrate (the different parts of the client-side code of Wagtail are generally very loosely coordinated), but it also does sound like a much better fix. I'll have a look, thanks for getting back to me so quickly.

Hi, I suspect Draftail 1.2.1 in Wagtail 2.5.1 is removing the indentation in the JSON. It doesn't happen with Draftail 0.17.2 in Wagtail 2.4.
Wagtail 2.5.1

Wagtail 2.4

Thanks @nwjlyons, that’s good to know. I’m not sure whether this can be considered a bug, feature, implementation detail – but it’s good to know nonetheless 😄.
Thinking more about this issue, I think a potentially simple solution to this would be to simply delay the initialisation of this "dirty form check" by some time (5-10s? 1min?). Thinking about it from the end user’s perspective, I can see how it wouldn’t be very useful to get this prompt after only a few seconds interacting with the page.
This is rather inelegant from a technical standpoint, but a delay of multiple seconds would remove the need for us to orchestrate field initialisation for the purpose of this dirty field check. And it seems like a UX improvement as well.

Alternatively, it would be good to understand why this is only happening in Firefox. I’m still clueless about that.

Alternatively, it would be good to confirm whether this is indeed only happening in Firefox, and if so why.

I can confirm it happens in Chrome, Safari, and Firefox.
An alternative solution might be to listen to change events on the form?

Unless anyone has objections to my proposal in https://github.com/wagtail/wagtail/issues/4978#issuecomment-508016667, I’ll have a look at implementing this. I might consider other options while implementing specifically for rich text fields.

@thibaudcolas @KalobTaulien and I were chatting about something related to this; would it be possible to simply wait to do the check until the user actually types some characters or some other user event? Might not actually be a better solution but figured I’d mention it.


Extra Padding Between Carousel and parent View with marginTop

Is this a bug report, a feature request, or a question?
Question
Have you followed the required steps before opening a bug report?
(Check the step you've followed - put an x character between the square brackets ([]).)

[x] I have read the guidelines regarding bug report.
[x] I have reviewed the documentation in its entirety, including the dedicated documentations :books:.
[x] I have searched for existing issues and made sure that the problem hasn't already been reported.
[x] I am using the latest plugin version.
[x] I am following the issue template closely in order to produce a useful bug report.

Have you made sure that it wasn't a React Native bug?
Yes
Is the bug specific to iOS or Android? Or can it be reproduced on both platforms?
Currently tested it with only Android
Is the bug reproductible in a production environment (not a debug one)?
Haven't tried in production environment

Environment
Environment:
React: 16.9.0
React native: 0.61.2
react-native-snap-carousel: ^3.8.4
Target Platform:
Android (6.0)
Expected Behavior

When I use marginTop in my parent View of Horizontal Carousel, I am getting some extra padding in the bottom. The padding increases as I increase the marginTop.

I already tried the suggestions mentioned in https://github.com/archriss/react-native-snap-carousel/issues/489 and it didn't resolve the problem.
Actual Behavior
There shouldn't be any padding at the bottom when I use marginTop in style of my parent View.
Reproducible Demo
https://snack.expo.io/B1S-Ht96B
Steps to Reproduce

Change marginTop value from 0 to 50%
You will observe the bottom padding keeps increasing with the same

was this resolved? I'm getting the same issue, putting flexGrow: 0 and padding: 0 didn't resolve it


Problem with extract-mouth-batch.py

When I try to train my own model and extract-mouth from the speaker's video, it doesn't correctly predict the face. For example, when I try to predict all the videos inside the evaluations/samples/GRID, it takes the images of the upper right corner of the face instead of the mouth. Please tell me how to fix it and why this is happening.
Any help would be greatly appreciated. Cheers!

In videos.py use these lines of code will work, using cv2 resize method occurs this problem .
from skimage.transform import resize
resized_img = resize(frame, new_img_shape)

When I try to train my own model and extract-mouth from the speaker's video, it doesn't correctly predict the face. For example, when I try to predict all the videos inside the evaluations/samples/GRID, it takes the images of the upper right corner of the face instead of the mouth. Please tell me how to fix it and why this is happening.
Any help would be greatly appreciated. Cheers!

does your project works ?


Resolve bare modules using file system parsePath()

Imagine the scenario:
lib/main.js
utils/uppercase.js/index.js

In this setup we have 2 esm modules with the following content:
// lib/main.js
import { toUpperCase } from 'uppercase.js'
print(toUpperCase('hello graaljs'));

and
// utils/uppercase.js/index.js
export default str => str.toUpperCase();

When trying to execute this application with gralljs (not node) with a custom file system, we can observe the following calls:
// OK
fs.parsePath('./lib/main.js')
fs.checkAccess('./lib/main.js')
// Odd
fs.toRealPath('./lib/uppercase.js')

Even though esm modules require absolute or relative paths on the browser, node for example, is less strict and so it seems graaljs too.
However, I'd expect not to assume that bare module paths to be relative to the caller module. Instead, I'd expect the engine to perform a parsePath('uppercase.js') call as nothing can be stated over the path so custom file system implementations can resolve to a real path, in this example, they would point back to ./utils/uppercase.js/index.js.
Am I wrong, assuming this is a bug in the engine?

The call happens from here:
https://github.com/oracle/graaljs/blob/4a8eceb372b4d4d5c44ec09abb0cc50e1c79e24d/graal-js/src/com.oracle.truffle.js/src/com/oracle/truffle/js/runtime/objects/DefaultESModuleLoader.java#L89-L139
If the specifier is bare, as in not absolute, relative or uri path, then don't assume relative from refFile and do a full parsePath() call?

An possible alternative where implementations could define their custom behavior could be:
// FileSystem.java
default Path resolveSibling(Path base, String other) {
  return base.resolveSibling(other);
}

default URI resolveSibling(URI base, URI other) {
  return base.relativize(other);
}

This would retain the current behavior and implementation of custom FileSystem could add the desired rules to handle "bare" modules or fallback to the default which is always relativize to the base when other isn't an absolute path.

Hi @pmlopes, sorry for the delayed response. Yes, I agree that using a relative path with bare specifiers is not ideal. I will work on a fix and let you know as soon as possible.

bar specifiers are not part of the spec so they need to get resolved in userland.

@pmlopes, we changed the FS lookups for bare specifiers as you suggested (here). Please let us know if you have other comments -- and thanks for reporting this issue!

Thanks!


Update README.md

Adds additional description for what Kliento is and its limited use
Adds note to prefer ContractKit over Kliento

@yorhodes quick question: should I merge, squash, or rebase PRs?


perf: PBR Enhancement

Please check if the PR fulfills these requirements

[x] The commit message follows our guidelines
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Enhancement
What is the current behavior? (You can also link to an open issue here)
#196  #216 #217  #218  #294  #295  #296
What is the new behavior (if this is a feature change)?
solve the problems above.

SH baker
HDR loader
IBL baker
frambebuffer mipmaps
shader enhancement
color space correction

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No.
Bake workflow:

load HDR texture:

 engine.resourceManager
    .load<TextureCubeMap>({
      // url: "https://gw.alipayobjects.com/os/bmw-prod/10c5d68d-8580-4bd9-8795-6f1035782b94.bin", // sunset_1K
      // url: "https://gw.alipayobjects.com/os/bmw-prod/20d58ffa-c7da-4c54-8980-4efaf91a0239.bin",// pisa_1K
      url: "https://gw.alipayobjects.com/os/bmw-prod/59b28d9f-7589-4d47-86b0-52c50b973b10.bin", // footPrint_2K
      type: AssetType.HDR
    }).then(cubeMap => {...})

IBL Baker

const bakedCubeMap = IBLBaker.fromTextureCubeMap(cubeMap);

SH Baker

const sh = new SphericalHarmonics3();
SphericalHarmonics3Baker.fromTextureCubeMap(cubeMap, sh);
scene.ambientLight.diffuseMode = DiffuseMode.SphericalHarmonics;
scene.ambientLight.diffuseSphericalHarmonics = sh;

Effect Preview

SH Baker

IBL Baker

PBR Base

HDR

HDR

has been merged by other PRs


Remove duplicate HillasParameters implementations.

As the title says. Right now we have 4 or 5 hillas implementations. I suggest to choose one of them.

I approve.
From my tests, 4 and 5 never fail while 1, 2 and 3 sometimes fail for some parameters (nan value returned).

We decided we need a test using some 'true' listed values. Also checking for all quadrants.
@MaxNoe mentioned he has some code doing that already in the toy-eventsource.
We want to keep number implementation number 5 (cov, eigen)

Hi.
How would the true values computed in the first place?
Why implementation 5?
You may find a notebook to compare the different implementation of hillas_parameters in ctapipe there:
https://github.com/cta-observatory/cta-benchmarks/blob/master/hillas_parameters.ipynb
The results for skewness and psi are quite different.

Because it's the most readable and runtime is not largely different (50% from slowest to fastest)

The results for skewness and psi are quite different.

Just minus signs and rotations by 180°, so no real different, there is a unit test in ctapipe showing this.

Ok thank you for the explanations @MaxNoe !

Or not rotations but different domains of the angle. So some functions return [-pi, pi], which is not really helpful, as only a 180° range is meaningfull, and some use different domains with a width of 180°.
And the sign of skewness depends on the orientation of psi


GoogleDisplayVideo360RecordSDFAdvertiserOperator CSV parse fix

Uses csv.reader to parse CSV instead of str.split(',')
Fixes bug encountered where CSV fields containing commas would cause invalid data to be saved to the Airflow variable (breaking the DAGs that use this variable).

@googlebot I signed it!

@googlebot can you recheck this PR?


Postgres error when installing dependencies via pip

Steps to reproduce
Hardware / OS: 15-inch Macbook Pro (2015) running macOS High Sierra (version 10.13.3 (17D102)

Clone citeas-api at commit f2b293b9cb47bb4c079528d8a95837b3db77be97
Create a virtual environment using virtualenv with the built-in macOS Python 2.7.10 (also replicated when setting up the virtual environment using a separately installed Python 3.6.4)
Activate the virtual environment
Try and install dependencies using pip install -r requirements.txt

Collecting psycopg2==2.6.1 (from -r requirements.txt (line 15))
  Using cached https://files.pythonhosted.org/packages/86/fd/cc8315be63a41fe000cce20482a917e874cdc1151e62cb0141f5e55f711e/psycopg2-2.6.1.tar.gz
    Complete output from command python setup.py egg_info:
    running egg_info
    creating pip-egg-info/psycopg2.egg-info
    writing pip-egg-info/psycopg2.egg-info/PKG-INFO
    writing top-level names to pip-egg-info/psycopg2.egg-info/top_level.txt
    writing dependency_links to pip-egg-info/psycopg2.egg-info/dependency_links.txt
    writing manifest file 'pip-egg-info/psycopg2.egg-info/SOURCES.txt'
    Error: could not determine PostgreSQL version from '10.3'

    ----------------------------------------
Command "python setup.py egg_info" failed with error code 1 in /private/var/folders/kj/13ksgycx1lqcynzpcsl1btm00000gp/T/pip-install-jsrXgm/psycopg2/

Proposed solution
Update Postgres requirement in requirements.txt from psycopg2==2.6.1 to psycopg2==2.7. See issue on psycopg2 Githuib repo (via this Stackoverflow post).

Hi Martin. I noticed the same error a bit ago. The codebase is now updated to psycopg2 2.7.5 which resolved it on my end.


coordinate problems...

Hello,
I just opened basic.js, , modified a bit (just showing map size and ball coordinates) and run it...I noticied that somehow the y coordinate of my_ball is smaller then the min_y of the map ? How is this possible ??

As i see on screenshot, map Y size is from 1653 to 3842 and you in 3273 which is in the middle.

@pulviscriptor oh i'm such a dump ass, i thougt my_ball.x is -3273 and min_y is -1653...props to me, making the ' - ' in conole.log :c. ;)


Fix temperature_sensor device revision

Fix temperature_sensor device revision to match 1.3 specs

Looks like there is another file that needs copyright info.

Fixed but now there is another error
Extension error (autoapi.extension):
Handler <function run_autoapi at 0x7f0d1ee68680> for event 'builder-inited' threw an exception (exception: Relative import with too many levels (1) for module 'temperature_sensor')

I think the sensor directory needs an empty __init__.py to make the folder a package wrt to imports.

The measurement folder needs it too.

The measurement folder needs it too.

Thanks for the tip. Fixed.


update questDBs integration guide

They also support (limited) a connection string directly via sqlalchemy

adding a note on the notebook is fine here


int64 Support

Would it be possible to support int64 numbers? Currently there is a int32 defined and we're using values that are to big for int32. For example postgres shmall parameter.
The code part where spiff stops is [this part][1]
[1]: https://github.com/cloudfoundry-incubator/spiff/blob/master/yaml/parser.go#L72

Closing due to inactivity.


Add operation identifier to retry logs.

This PR adds logging of the OperationContext object to the CommandOperationHelper.logRetryExecute() method. The OperationContext object provides context information about the operation being executed, such as the operation id.
Logging  the OperationContext object  can be useful for troubleshooting, as it allows us to track the execution of specific operations.
JAVA-4939

@vbabanin Is the PR a draft because you had been waiting for the tests to pass?

@vbabanin Is the PR a draft because you had been waiting for the tests to pass?
Yes, the PR is a draft because I was waiting for the results of some manual testing that I was finishing up


Generalize interrupt trap condition evaluation conditions

This approach is more extensible, and now implicitly includes writes to sstatus.SIE / mstatus.MIE, as it should.

At the end of the new sentence perhaps add "(including mstatus, mip, and mie)" in the machine chapter, and add "(including sstatus, sip, and sie)" in the supervisor chapter?

@jhauser-us Sounds good, but to avoid injecting further confusion, I’d like to add mideleg to the first list, since it is also explicitly mentioned in the preceding paragraph. (While it’s of course contrived to use the clearing of an mideleg bit to action the interrupt-taking logic, and while excluding mideleg from this clarifying list has no normative impact, it seems likely that excluding it will invite further questions.)

@aswaterman Not arguing against, but observing that including or excluding mideleg in the list makes a difference to hardware.  If not in the list, hardware is free to not ensure interrupt-taking right after a mideleg write.  If in the list, hardware specifically must ensure interrupt-taking right after a mideleg write.  If mideleg is in the list, one can imagine an eventual ACT testing this case to ensure that interrupt-taking occurs as required.

Indeed. I’ll briefly note two things: first, John’s list is non-normative, in that it only clarifies which registers are “expressly depended” on. Second, while this does make a difference to HW, most implementations should do it automatically (by flushing the pipe on writes to an almost-never-written register), and this definition keeps the spec cleaner by not creating carve-outs for registers that are “expressly depended” on but don’t require this synchronization.

Updated as proposed.  I'm going to merge this now to obviate near-term confusion, while acknowledging this might not be the final word on this topic.


How to implement IOS 15 scan text feature in Flutter TextField

I want to add ios 15's new scan text feature in my flutter textfield. I have set my target deployment as 15.2 for both project and podfile and yet the option is not coming like in the featured image. If anyone out there know how can it be done, it will be a great help.

Hi @felix0324324
You can do it this with native TextField of Flutter?

Hi @felix0324324 You can do it this with native TextField of Flutter?

So....I cannot use "flutter_form_builder" functions?

I made a question because if dont work with native form field, cant be work with this package

I made this question because if don't work with native form field, also cant be work with this package

I have to click twice to focus the "Native TextField".
The first time click on "Native TextField" seems nothing happens.

After investigation, flutter does not provide a way to use the "scan text" ios feature natively. As it does not use native UITextField from iOS we can't provide a quick and easy way to implement it.
The best approach would be to create another widget using flutter native text input package (in a separate flutter package)


Add support for Aqara high precision motion sensor

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

29 of 47 (61.7%)  changed or added relevant lines in 2 files are covered.
4 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.1%) to 82.558%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

zhaquirks/xiaomi/init.py
1
5
20.0%

zhaquirks/xiaomi/aqara/motion_agl04.py
28
42
66.67%

Files with Coverage Reduction
New Missed Lines
%

zhaquirks/tuya/ts004f.py
4
80.65%

Totals

Change from base Build<PHONE_NUMBER>:
-0.1%

Covered Lines:
6352

Relevant Lines:
7694

💛  - Coveralls


Fix aws.s3.xxx invalid even IcebergAwsClientFactory is set as client.factory

Why I'm doing:
we would like to make aws.s3.xxx parameters valid, so we specify  ("client.factory"="com.starrocks.connector.iceberg.IcebergAwsClientFactory").
But it turns out that aws client still uses aws session token instead of aws credentials that we set in catalog's params.
What I'm doing:
Fix aws.s3.xxx invalid even IcebergAwsClientFactory is set as client.factory
What type of PR is this:

[x] BugFix
[ ] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Does this PR entail a change in behavior?

[ ] Yes, this PR will result in a change in behavior.
[x] No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

[ ] Interface/UI changes: syntax, type conversion, expression evaluation, display information
[ ] Parameter changes: default values, similar parameters but with different default values
[ ] Policy changes: use new policy to replace old one, functionality automatically enabled
[ ] Feature removed
[ ] Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

[ ] This is a backport pr

Bugfix cherry-pick branch check:

[ ] I have checked the version labels which the pr will be auto-backported to the target branch

[ ] 3.3
[ ] 3.2
[ ] 3.1
[ ] 3.0
[ ] 2.5

@Youngwb @stephen-shelby plz help review it.

Can you put your create catalog's sql, I think we haven't this problem.

Can you put your create catalog's sql, I think we haven't this problem.

"type"="iceberg",
"iceberg.catalog.type"="rest",
"iceberg.catalog.uri"="xx",
"iceberg.catalog.warehouse"="xx",
"iceberg.catalog.credential"  =  "xx",
"aws.s3.access_key"="xx",
"aws.s3.secret_key"="xx",
"aws.s3.region"="xx",
"aws.s3.enable_path_style_access"="true",
"client.factory"="com.starrocks.connector.iceberg.IcebergAwsClientFactory"

Can you put your create catalog's sql, I think we haven't this problem.

"type"="iceberg", "iceberg.catalog.type"="rest", "iceberg.catalog.uri"="xx", "iceberg.catalog.warehouse"="xx", "iceberg.catalog.credential" = "xx", "aws.s3.access_key"="xx", "aws.s3.secret_key"="xx", "aws.s3.region"="xx", "aws.s3.enable_path_style_access"="true", "client.factory"="com.starrocks.connector.iceberg.IcebergAwsClientFactory"
plz check it. Thanks @Smith-Cruise

just add "iceberg.catalog.disable_vended_credential" = "true"
We have a temporary fix in #49141

Can you put your create catalog's sql, I think we haven't this problem.

"type"="iceberg", "iceberg.catalog.type"="rest", "iceberg.catalog.uri"="xx", "iceberg.catalog.warehouse"="xx", "iceberg.catalog.credential" = "xx", "aws.s3.access_key"="xx", "aws.s3.secret_key"="xx", "aws.s3.region"="xx", "aws.s3.enable_path_style_access"="true", "client.factory"="com.starrocks.connector.iceberg.IcebergAwsClientFactory"
plz check it. Thanks @Smith-Cruise

just add "iceberg.catalog.disable_vended_credential" = "true"
We have a temporary fix in #49141

Got it. Thanks !

@zhaohehuhu So can I close this CL?

Sure.

@Smith-Cruise  @alvin-celerdata #49141 The fix is not released in 3.3.2, right ?

@Smith-Cruise @alvin-celerdata #49141 The fix is not released in 3.3.2, right ?

yes, I think you check it by yourself.


Use Github API to ship branches on Github

As a developer working on a repository on Github
I want to ship the branch using the Github API instead of using Git commands on my machine
So that Github shows the correct merge status and I can take advantage of branch protection, CI, and review approvals.

This PR would resolve #539, #673, #705, #51, #201, #445
Notes

create a personal access token
store the token in the Git Town configuration for the project
get the PR number by listing all pull requests with the head parameter set to filter by branch name
merge the PR

Requires the user giving use a personal access token from github

see the last line of this doc

Get PR number via branch name

doc
use the head filter

Merge PR

doc
Use the squash and commit_message parameters

Resolved by #937 and #1006. Released in 4.2.0


RABSW-982 nnf-dm: allow use of ExternalMgsNid when creating MPIJob

When creating a lustre-to-lustre MPIJob, the orchestrated lustre FS may be
using an external MGS.
Signed-off-by: Dean Roehrich<EMAIL_ADDRESS>

Can something that unit tests this change?


Cheer emotes don't have feature parity with BTTV emotes.

Describe the bug

Cheer emotes (Cheer1, Cheer10, pajaCheer1, etc.) cannot be zoomed in. You cannot open links to the GIF.
To reproduce

Find a channel with people cheering.
Hover over the cheer emote and see that it doesn't have a preview.
Right click the emote and see that you cannot open the link in a browser.

Screenshots

N/A
Chatterino version

Chatterino + Dankerino patches 763acf9a based on upstream c2782666a66810ef6b973ce543626ad80d07e352
Operating system

Ubuntu 20.04.1 LTS (Focal Fossa)
Additional information

This is caused by the EmoteElement created for a bit cheer not having a valid Tooltip set when it's created. This means it fails the check in ChannelView.cpp#L1406 where the tooltip must not be empty.


Check RAPL file permission at launch

Following https://github.com/mlco2/codecarbon/issues/232 I propose an improvement to check permission on RAPL file to avoid having an error on each measurement and using the fallback.
This will not fix the issue, but we are not responsible of Ubuntu decision of rapl file permission.

Why the obvious error is logged as a warning? That would lead to incorrect results and the user won't be the wiser. How can a user know that some file having the wrong perms warning is important at all?
Also while at it why not give a user a suggestion on how to fix it?

Thanks @stas00 for challenging us and keep using Code Carbon despite all difficulty.
What do you think of:
                    logger.error(
                        "Unable to read Intel RAPL files for CPU power, we will use a constant for your CPU power."
                        + " Please view https://github.com/mlco2/codecarbon/issues/232#issuecomment-910394964"
                        + f" for workaround : {e}"
                    )

Looks perfect to me, @benoit-cty! Thank you!


resourcemerge: add pruning helpers when creating a ConfigMap

This adds a variant of the ConfigMap resourcemerge funcs which prunes fields that do not show up in a given runtime.Object. This will be used to prune configs for operands from mistyped values and from operator internal fields.

/assign @deads2k

/assign @mfojtik

/lgtm


Investigate if CSS specificity is correct when using opinionated layers

Remix adds their own "critical css". Vite does the same. Almost. This is to avoid FOUC:
https://github.com/remix-run/remix/discussions/8070#discussioncomment-7625870
One solution to this problem could be to use "opinionated layers" in dev mode for Remix (and potentially Vite).
The relevant function that figures out specificity, that could be incorrect, if the same CSS block is added twice:
https://github.com/eagerpatch/navita/blob/81f962c9c675f3820191bcc1200e9d9f00fc511a/packages/engine/src/helpers/getPropertyPriority.ts#L203
Note: The root cause is that the same CSS block is added twice.

The CSS specificity is correct. There was however another bug due to how Remix inlines criticalCss. But a fix for that is on the way.


⚠ Bofrost.at has degraded performance

In f9cff50, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 2088 ms

Resolved: Bofrost.at performance has improved in 7a5cc46.


The labels in the QMNIST dataset are all equal to 0.

🐛 Describe the bug
The labels in the QMNIST dataset are all equal to 0.
im_transform = T.Compose([
    T.ToTensor()
])

qmnist_train = torchvision.datasets.QMNIST('data/', train=True, download=True, transform=im_transform)

# the first image is a '5'
plt.imshow(qmnist_train[0][0][0])
# prints '0'
print(qmnist_train[0][1])

# the following never outputs anything
[print(qmnist_train[i][1]) for i in range(len(qmnist_train)) if qmnist_train[i][1] != 0]

Versions
Collecting environment information...
PyTorch version: 1.13.1
Is debug build: False
CUDA used to build PyTorch: 11.6
ROCM used to build PyTorch: N/A

OS: Ubuntu 22.04.1 LTS (x86_64)
GCC version: (Ubuntu 11.3.0-1ubuntu1~22.04) 11.3.0
Clang version: Could not collect
CMake version: Could not collect
Libc version: glibc-2.35

Python version: 3.10.8 (main, Nov 24 2022, 14:13:03) [GCC 11.2.0] (64-bit runtime)
Python platform: Linux-5.15.0-57-generic-x86_64-with-glibc2.35
Is CUDA available: True
CUDA runtime version: 11.6.124
CUDA_MODULE_LOADING set to: LAZY
GPU models and configuration: GPU 0: NVIDIA GeForce GTX 980 Ti
Nvidia driver version: 525.60.11
cuDNN version: Could not collect
HIP runtime version: N/A
MIOpen runtime version: N/A
Is XNNPACK available: True

Versions of relevant libraries:
[pip3] geotorch==0.3.0
[pip3] numpy==1.23.5
[pip3] torch==1.13.1
[pip3] torchaudio==0.13.1
[pip3] torchvision==0.14.1
[conda] blas                      1.0                         mkl
[conda] ffmpeg                    4.3                  hf484d3e_0    pytorch
[conda] geotorch                  0.3.0                    pypi_0    pypi
[conda] mkl                       2021.4.0           h06a4308_640
[conda] mkl-service               2.4.0           py310h7f8727e_0
[conda] mkl_fft                   1.3.1           py310hd6ae3a3_0
[conda] mkl_random                1.2.2           py310h00e6091_0
[conda] numpy                     1.23.5          py310hd5efca6_0
[conda] numpy-base                1.23.5          py310h8e6c178_0
[conda] pytorch                   1.13.1          py3.10_cuda11.6_cudnn8.3.2_0    pytorch
[conda] pytorch-cuda              11.6                 h867d48c_1    pytorch
[conda] pytorch-mutex             1.0                        cuda    pytorch
[conda] torchaudio                0.13.1              py310_cu116    pytorch
[conda] torchvision               0.14.1              py310_cu116    pytorch

cc @pmeier

Can reproduce.

This is caused by a faulty byte flip in
https://github.com/pytorch/vision/blob/7dc5e5bd60b55eb4e6ea5c1265d6dc7b17d2e917/torchvision/datasets/mnist.py#L525-L528
which was introduced in #4598.

Ok, byte flipping, i.e. changing the endianness, is possible with PyTorch, by viewing the data through a different dtype:
if needs_byte_reversal:
    parsed = (
        parsed.contiguous()
        .view(torch.uint8)
        .view(parsed.numel(), num_bytes_per_value)
        .flip(1)
        .flatten()
        .view(torch_type)
    )

Thanks for the tip @lezcano!

Thanks a lot for investigating @pmeier, and @Foobin for the report.
Perf isn't critical at this stage of the dataset loading, so we can go with either solution (revert to np, or use the native pytorch code above).
Any pref Philip?

Minimally leaning towards the PyTorch only solution, since we tried to phase out numpy as much as possible for our prototype datsets (see #4882). But I'm fine with either.

I know you guys mentioned that perf is not an issue here, but the PyTorch version should be much faster on CPU due to @vfdev-5 's recent vectorisation of flip.

Good to know! If we can confirm that with some quick benchmarks, we could also potentially simplify the code @pmeier mentioned above https://github.com/pytorch/vision/issues/7079#issuecomment-1379976150 ?

If we can confirm that with some quick benchmarks, we could also potentially simplify the code

I don't think we can. The code above was carefully designed to not make a memcopy unless needed. torch.flip always copies. So if we are after performance, I don't think we have much room for improvement.

I meant "simplify" this code:
https://github.com/pytorch/vision/blob/7dc5e5bd60b55eb4e6ea5c1265d6dc7b17d2e917/torchvision/prototype/utils/_internal.py#L94-L97
i.e. remove the numpy dependency and use the pytorch way

Hi


Demonstrate GET, POST, PUT, and DELETE with HttpClient

Fixes #12580.
Creating as a draft for visiblity. Things still left to do:

[x] Complete the sample, which is mostly just cleaning up some of the copy/paste.
[ ] Demonstrate System.Net.Http.Json as a more streamlined approach to sending/receiving JSON.
[ ] Add a section or two to the topic to discuss the code demonstrated in the sample.

@Rick-Anderson Are you happy with this approach? I think I'll skip the System.Net.Http.Json stuff in this PR but cover it later in another change. If you have time, and you're interested, you should be able to run the sample app as is.

Wow, this is fantastic. We just need to document it must be run from https://localhost:5001 (or you must change the port). I tried to catch the socket exception and return a warning but was unable to. The would probably pollute the  clean code anyway.
Good plan. Let me know how I can help.

@Rick-Anderson Thanks for taking a look. I added a commit that uses the incoming request to determine the correct address to use, so it should work whatever the host/port is.
I'm going to work on getting some content into the topic next. What kind of detail do you think should go into the topic?

@serpent5  we don't want a cook-book step by step instructions how you made the code - like what MSDN used to do. Let the code do the talking. Refer to the code and explain how it work.
Does that help?

Yeah, sure, that makes sense.
I'll work on adding a new section that focuses on the POST example but also refers the to the PUT and DELETE examples, for completeness. I'm hoping the reader can just spin up the sample and see it all in action, without being cook-booked through it, like you said. I should have it ready by the end of the week, if not a bit earlier.

@Rick-Anderson I'm getting a 404 on the Dropbox link. If you're happy with how this renders, don't worry about providing a new link.

Have a look at the published doc when you have time.