[Editor] Prevent some shortcut errors when generating docs

Makes the check for EditorSettings singleton in the shortcut override methods silent to avoid errors on documentation generation
To see the change compare the CI run of this and master for example, this will turn up at the top of both the class reference update and the C# glue:
ERROR: EditorSettings not instantiated yet.
   at: ED_SHORTCUT_OVERRIDE_ARRAY (editor/editor_settings.cpp:1658)
ERROR: EditorSettings not instantiated yet.
   at: ED_SHORTCUT_OVERRIDE_ARRAY (editor/editor_settings.cpp:1658)

Fixes: https://github.com/godotengine/godot/issues/91510

How about removing the error check in ED_SHORTCUT_OVERRIDE* instead, and just make it a silent return?

Could do that, but it is an action that expects things to work so might be safer to have it error correctly when it's expected to work correctly, but can make an alternative solution like that
The non-override versions do exit silently so could equalize that
Will make a second commit with that solution instead and we'll decide which to go with

Yeah I think we can go with this alternative solution.

Thanks!

Thank you!


How to handle the clear event when the x is pressed?

When I type a city to do a lookup there appears a little x in order to clear my selection.
Is there a prop I can set so that when that button is pressed I can take some action?
Thanks

+1

I can't see the x button in Android but on iOS its there. Is there some prop that can be set to show it up on Android?

+1

+1

@guilhermepontes you closed this issue without comment. Is this just a #wontfix or did I miss something?

Any news on this?

Any updates on this?

@jamesa3 this issue is closed. Please open a new issue (please allow the issue template).

add refrence the call
      <GooglePlacesAutocomplete         ref={InputRef}          ... /> InputRef.current?.setAddressText('')


Method resolution for slices

impl<T> [T] is separately defined in core and alloc, so I changed def_crate function in method_resolution.rs to return multiple crates.

bors r+


update docking demo to use nodeFlags

This add the node flags. Most of the patch is in the attached below file since else it gets a little hard to send given thats on a different repo. You should be able to git apply that to hello_imgui
0001-add-support-for-setting-node-flags-of-new-dock-space.patch

Ok, I merged those changes and added the patch to hello_imgui.
I had to change the generator options for DockNodeFlagsPrivate_
I also added a demo usage in python:
https://github.com/pthom/imgui_bundle/blob/9dd5427bb6b65a2e6e9f631f6d72204cd3842297/bindings/imgui_bundle/demos_python/demos_immapp/demo_docking.py#L216-L217
Thanks!

Hi Pascal,
Very nice, thanks!
Cheers,
Dee
On Thu, Mar 9, 2023 at 5:40 PM Pascal Thomet @.***>
wrote:

Ok, I merged those changes and added the patch to hello_imgui.
I had to change the generator options for DockNodeFlagsPrivate_
I also added a demo usage in python:
https://github.com/pthom/imgui_bundle/blob/9dd5427bb6b65a2e6e9f631f6d72204cd3842297/bindings/imgui_bundle/demos_python/demos_immapp/demo_docking.py#L216-L217
Thanks!
—
Reply to this email directly, view it on GitHub
https://github.com/pthom/imgui_bundle/pull/92#issuecomment-1462385123,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AANUOGND4GDOHIWFH56FGHLW3IBYVANCNFSM6AAAAAAVU45FYM
.
You are receiving this because you authored the thread.Message ID:
@.***>


Docs down?

http://www.gosurf.io/ seems to be down.

I was looking for them too. I'm not sure if this project is still being actively maintained. Here is the pull request I've submitted to change the URL: https://github.com/headzoo/surf/pull/32

This project looks pretty dead if no one can merge this little fix. :-1:

I'm merging the pull request now. I don't have much time to work on the project, but this was a pretty big stumbling block for people who want to poke around at the code.


metadatasvc: remove string "header" from http header match

see  issue https://github.com/coreos/rocket/issues/409
The specification says that queries to the metadata service must have an HTTP header:
Metadata-Flavor: AppContainer
The actual check in the metadatasvc main.go is for "AppContainer header"

good catch, thanks!


Plugin not working with latest SteamVR beta builds

Tested with latest core and plugin as on 1-23-16.
Wanted to make you guys aware of the problem.
Error is as follows in this screenshot:
http://prntscr.com/9udxuh
-Dylan

Let's reopen this please, we can close it when we fix it for the latest versions

@DjDyll We've updated the driver so that it should work with the current version of SteamVR. It may also work with the current beta versions, but Valve often releases beta versions prior to updating the public OpenVR API for us to build against. I'd suggest sticking with the current releases whenever possible.
Please let me know if the latest SteamVR-OSVR driver works for you. If it does, we can close this issue. Thanks!


feature request: option to turn off screen to conserve power when remote installing.

I see retroarch can turn off the lower screen so I hope this is possible, if not, lower the brightness to the lowest level?
And offer some notification when completed like making sound or calling some remote CGI? I'm actually using an ugly fix for the later, after the real URLs that I want to install, I append another URL which is a CGI sending a push notification to phone.

Couldn't you just lower the brightness from the home menu? Also, I feel like power conservation options would fit better as a CFW feature, rather than being implemented on a per-application basis.

Yes it fits better as an OS feature, but after all 3DS is not running an ordinary OS, and installing big CIA files is not a common scenario for 3DS, and I guess it's to complicated to implement this in CFW.
That been said, if I could write this, would you accept the PR?

It really shouldn't be that difficult of a feature to implement in CFW.
If you can implement it in a clean way, I suppose I wouldn't have too many objections to pulling it in. I had trouble thinking about what to do when an error occurs while the screen is off, etc., but I suppose you could just add a global screen toggle and rely on the user to turn it back on later and see the error.

Please don't laugh if my ideas are wrong.
If implementing it in CFW, CFW would maintain something like an inactivity timer in the background and when it shot CFW shutdown the screen, but usually games wouldn't need that, and probably hazardous like if you're watching a long cinematic sequence without any input, so it would need a switch which is off by default, and when you started a CIA install, you set it on, and set it back to off when the install finished.
It would work more like a general OS/app relationship, but again 3DS is not running an ordinary OS, I really couldn't think of another scenario which would need this OS feature, and it would be simpler to implement it in FBI.
If implementing it in FBI, your idea sounds even simpler, no need to add an option item then, just a hint message like "press X to turn off/on the screen" during install is enough.

It wouldn't have to be an OS/app relationship; you could simply have a CFW feature that allows the user to toggle the screen on and off at will.

Oh that makes sense... rosalina is a thing, I'm not used to think that way yet.


zetaclient : Add a new thread which runs the supply check

https://www.notion.so/zetachain/Zeta-supply-checks-3d0f82b36d294662a985ae5c8be61698?pvs=4

The problem with PendingOutbound and PendingRevert
The Following uses PendingOutbound as an example, but we can also use a similar design for PendingRevert.

Pending Outbound covers two stages of a CCTX.

Pending outbound: This is when the outbound scheduler has not picked up the TX, and the outbound has not been broadcasted.
Awaiting confirmation: This is when the TX is broadcasted and awaiting confirmation. The amount has already been minted or released. So, total supply or total locked values would already reflect this amount.


Timestamp in lnd backup file

Thank you for your contribution to RaspiBlitz. Before submitting this PR, please make sure:

[x] That its based against the dev brach - not the default release branch.

The name of the lnd-rescue-backup is already quite long. I can see a benefit in also having a timestamp on there but I would recommend to do that manually if needed by for example archiving the file for example in a diretcory with the date. In normal cases your file system will also give you metadata when the file was created.


Devise 4.2.0 On Rails 5.0.0 - Not Permitting :email or :name

I have an existing application that I wanted to upgrade to Rails 5 since I have other applications running Rails 5 with similar configurations.  When I upgrade to Rails 5.0.0 the :email and :name values are not permitted.  I went to review the previous application configuration and realized that it was running on Rails 5.0.0.rc2. I upgraded second application to Rails 5.0.0 and received the same exact error.  When I went back to the existing application and changed to Rails 5.0.0.rc2 it works again.  Is there a configuration change that I need to account for to upgrade to Rails 5.0.0.

You need to give us more information on how to reproduce this issue, otherwise there is nothing we can do. Please read CONTRIBUTING.md file for more information about creating bug reports. Thanks!


fix: allow users to submit the form earlier

fix: allow users to submit the form earlier
Description
Allow the user to submit the long TUI form earlier using the shortcut key [Ctrl + S].
list of supported keymaps

[ ] This change requires a documentation update
[ ] I have made corresponding changes to the documentation

Related Issue(s)
closes #710
This PR addresses issue #X
Screenshots
If relevant, please add screenshots.

Notes
Please add any relevant notes if necessary.

completed the requested changes.

P.S. In the future, please push review changes as separate commits (which will be squashed upon merging). It makes it easier to rereview later.


Add screenshots in the readme file

No one cares about the code, people need screenshots to see how beautiful it looks. :smirk: :lollipop:

Adding one more for i3:

Adding a new one for i3 desktop:


Adding a timestamp option

Hi.
First of all, thanks for your great job.
I've added the option to set a timestamp in order to upload the weight of a concrete date-time.
I've never coded go before so please, be indulgent :)
Regards.

Thanks for your effort


ISO aren't bootable

Hello,
So I downloaded the iso for 10.14.6 with all the clover files in it, used Etcher to write the iso on the USB, but the final USB isn't bootable.
What I'm missing?

Have you add Boot Entry with path "/EFI/EFI/CLOVER/CLOVERX64.efi" in BIOS ?

Hi,
Yes, I did and that's the screen I'm presented with. (Please see the
attached)
On Thu, Sep 19, 2019, 8:25 PM Quert<EMAIL_ADDRESS>wrote:

Have you add Boot Entry with path "/EFI/EFI/CLOVER/CLOVERX64.efi" in BIOS ?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/the-Quert/Dell-XPS-9360-Hackintosh/issues/4?email_source=notifications&email_token=AM6MHEQ2NJSWGVHVPDCZQSTQKOKVPA5CNFSM4IYKJ66KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7D3VYA#issuecomment-533183200,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AM6MHEVXXS77M57O46NQDILQKOKVPANCNFSM4IYKJ66A
.

Which version of 10.14.6 you are testing ?
Check the MD5 if there is same as I note.

This one, and the MD5 Checksum is matching
https://drive.google.com/file/d/1IlLJ6v556RYNmjHKNmUFkWJ2xrT0rGLn/view?usp=drivesdk
Can you please confirm the process?
Download .DMG > Use Etcher to Flash on USB > Boot from USB
I did that, added entries in Bios too, but as shown in the screen capture, there isn

After testing, there are something wrong with the macOS installer part, Clover works normally.
The images below are un-bootable:

macOS Mojave 10.14.6(18G87) Installer with Clover 5033.dmg
macOS Mojave 10.14.6(18G95) Installer with Clover 5058.dmg

To install macOS Mojave 10.14.6, use with the ISO below:
macOS Mojave 10.14.6(18G84) Installer with Clover 5027.dmg
There is allowed to install 10.14.6(18G84), then update to 10.14.6(18G95)
The un-bootable versions will be test and upload next week.

Since 18G87 and 18G95 are un-bootable, the two versions will be delete from repository and GDrive.
ISO for 18G87 and 18G95 will be testing and uploading in one week.

Alright, that's understandable. Closing the issue now. Thanks for all the assistance.


Onboarding experience

We should define how the first experience for the user has to be. It has to be error free and more intuitive than this:

Also think about the default preferences.

Onboard experience is way better now, default preferences are implemented but possibly not perfect. Currently, implementation of the tutorial is missing.

@MalteBartels Please check out latest version of the app and evaluate the first experience for the user.

@MalteBartels For your information

I like it. Should be enough for our cupcake, maybe we might revisit this in midterm;)

Okay I will close this issue for cupcake


pad_to_worst_case_seq_len boolean, for testing memory limits

config option to help with measuring worst-case memory usage.
forces data collator to always output batches that max out your configured context length.
this will give a somewhat optimistic reading, because the amount of fragmentation will be minimal (as all batches will be able to re-use previously-allocated buffers). but it's a lot better than finding out the impact of a long prompt super late in your run.

looking at the docs (https://huggingface.co/docs/transformers/main_classes/data_collator#transformers.DataCollatorWithPadding.padding), it seems padding=True and padding="longest" mean the same thing
so i've removed the unnecessary collator_pad_to_longest, which is already the default behavior
instead, there's a new pad_to_sequence_len which will control padding. FYI, I tried padding="max_length" but it doesn't work correctly when micro_batch_size>1, so using pad_to_multiple_of= is the best solution. i ensured that the padding is still also a multiple of 64 (and 8) to ensure best performance.

also, note to my future self: i tested this with the following patch to transformers trainer to see what shape the inputs are on each step:
diff --git a/src/transformers/trainer.py b/src/transformers/trainer.py
index 85d4fd5a5..a9e7729ae 100755
--- a/src/transformers/trainer.py
+++ b/src/transformers/trainer.py
@@ -1813,6 +1813,7 @@ class Trainer:

             step = -1
             for step, inputs in enumerate(epoch_iterator):
+                print(os.getpid(), step, {k:v.shape for k, v in inputs.items()})
                 total_batched_samples += 1
                 if rng_to_sync:
                     self._load_rng_state(resume_from_checkpoint)

before, with examples/llama-2/lora.yml (which uses sequence_len=4096 and micro_batch_size=2), i saw iterations of sizes 8091, 8178, 7787, etc
after this patch, the sizes are consistently 8192 each step and the memory usage is much more stable.

config option to help with measuring worst-case memory usage.

ironically using this option actually reduces memory usage in all my tests. without it, fragmentation is a problem and peak VRAM usage is higher. (this makes sense, because when each step is exactly the same size the same few memory buffers can be re-used every time).

testing examples/llama-2/lora.yml again, before patch:

GPU memory usage while training: 7.309GB (+8.193GB cache, +0.848GB misc)

after patch:

GPU memory usage while training: 7.310GB (+6.086GB cache, +0.848GB misc)


Compiler's bug: Field initialization order of record

Description
Maybe I've found a F# compiler's bug, which is demonstrated in .NET Fiddle. https://dotnetfiddle.net/pLFzQE
I expected that each field initialization of record is evaluated in order, but it isn't.
I checked a spec document of F# 3.0 out, and I found "6.9.11 Evaluating Record Expressions" says
that "Each expression e1 … en is evaluated in order". So, I'm afraid this behavior below is a compiler's bug.
Repro Steps
type Foo = {
  A : int
  B : int
  C : int
}

let _ =
  { A = let _ = printfn "1" in 0
    C = let _ = printfn "2" in 0
    B = let _ = printfn "3" in 0 }

Expected/Actual
I expected the above program prints:
1
2
3
but, actually:
2
1
3
Version
F# 3.0 (FSharp.Core, <IP_ADDRESS>), .NET Framework 4.5

This repros in F# 4.0.
Worth noting that the "A C B" order is the only permutation that results in out-of-order initialization.

I think only the new tests are useful. the fix itself was not correct.


Like animation CORS issue

Chromium: 76.0 (Official Build) Arch Linux (64-bit)
Tampermonkey beta: 4.9
Unfavoriting a post shows the heart break animation while favoriting an image gives
Access to XMLHttpRequest at 'https://assets5.lottiefiles.com/datafiles/d9bc9kYC2VttaKb/data.json' from origin 'https://e621.net' has been blocked by CORS policy: No 'Access-Control-Allow-Origin' header is present on the requested resource.

Ahh, good old CORS issue 😒
I see what you meant 👇  Test Sauce

Thanks for reporting the issue 😸  Gonna to fix it ASAP

Commit: d90ac78b7289076f0b4c6eda4cfd4a2c96fa64bc should fix the Lottie data file CORS issue.
Gonna close this issue for now if for some bizarre the issue still acute please do re-open this very issue 😄


Python: Cardinality difference between C# and Python on GetStreamingChatMessageContentsAsync and complete_chat_stream

In C#, GetStreamingChatMessageContentsAsync generates a IAsncEnumerable of StreamingChatMessageContent
// Invoke the chat completion service
IChatCompletionService chatCompletionService = kernel.GetRequiredService<IChatCompletionService>();
var results = chatCompletionService.GetStreamingChatMessageContentsAsync(
    chatHistory: chatHistory,
    executionSettings: new OpenAIPromptExecutionSettings() {
        // Allows the AI to automatically choose and invoke functions from the kernel's plugins
        ToolCallBehavior = ToolCallBehavior.AutoInvokeKernelFunctions
    },
    kernel: kernel
);

// Return the results as a stream
var completeMessage = new StringBuilder();
await foreach (var result in results)
{
    completeMessage.Append(result);

    // Send the message events to the client
    var events = assistantEventStreamUtility.CreateMessageEvent(run.Id, result);
    foreach (var messageEvent in events)
    {
        yield return messageEvent;
    }
}

Python, however, creates a AsyncGenerator[list[StreamingChatMessageContent], which makes the code less obvious to write because you always have to get the first index [0].
# Invoke the chat completion service
chatCompletion: ChatCompletionClientBase = kernel.get_service(type=ChatCompletionClientBase)
results = chatCompletion.complete_chat_stream(
    chat_history=history,
    settings=OpenAIChatPromptExecutionSettings(
        # function_call_behavior=FunctionCallBehavior()
    ),
    kernel=kernel
)

# Return the results as a stream
completeMessage = ""
async for result in results:
    completeMessage += result[0].content

    # Send the message events to the client
    events = event_stream_utility.create_message_event(run.id, result[0])
    for event in events:
        yield event

@matthewbolanos how does dotnet deal with num_responses > 1 for this, because that is the reason everything returns a list!


fix: fixed  DeprecationWarning from pytest about np.int.

Fixed DeprecationWarning from pytest about np.int.

DeprecationWarning: np.int is a deprecated alias for the builtin int. To silence this warning, use int by itself. Doing this will not modify any behavior and is safe. When replacing np.int, you may wish to use e.g. np.int64 or np.int32 to specify the precision. If you wish to review your current use, check the release note link for additional information.
Deprecated in NumPy 1.20; for more details and guidance: https://numpy.org/devdocs/release/1.20.0-notes.html#deprecations self._voxels = np.ceil(np.array(box_size) / self._spacing).astype(np.int)

Changed np.int to np.int32 in line 260 of vina.py.

This would be better served by PR #167


Fix dojo update

User description
-> models should update when the dojo account changes because army models and structure models need to be updated (armies aren't ours anymore so labels change for example)

PR Type
Bug fix, Enhancement

Description

Added an event listener for ACCOUNT_CHANGE_EVENT in main.tsx to reinitialize the game renderer scene when the account changes.
Introduced a new renderModels method in GameRenderer.ts to handle model rendering.
Moved the initialization of animations in GameRenderer.ts to the constructor.
Added and dispatched ACCOUNT_CHANGE_EVENT in Steps.tsx to trigger re-rendering when the account changes.

Changes walkthrough 📝
Relevant filesEnhancement

main.tsxAdd event listener for account change to reinitialize game renderer

client/src/main.tsx
Added event listener for ACCOUNT_CHANGE_EVENT to reinitialize the game renderer scene.  Imported ACCOUNT_CHANGE_EVENT from onboarding steps.

+7/-0

GameRenderer.tsAdd renderModels method and initialize animation in constructor

client/src/three/GameRenderer.ts
Added renderModels method to re-render models.  Moved animation initialization to the constructor.

+7/-3

Steps.tsxDispatch ACCOUNT_CHANGE_EVENT on navigation

client/src/ui/modules/onboarding/Steps.tsx
Added ACCOUNT_CHANGE_EVENT constant.  Dispatched ACCOUNT_CHANGE_EVENT on navigation.

+3/-0

💡 PR-Agent usage:
Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

LGTM


Add output camera model

Right now if there is no ground truth, the camera model for the output is not saved in the pytorch-lightning module. This is needed for generating outputs like point clouds.

Output camera mode is always available as "rig". However, the problem is we also need the rays and grids for sampling RGB value from the input images for purposes like visualization.


Winget install netron fails: "Opening manifest failed"

@TomWildenhain-Microsoft does this repro with the most recent version of winget?

haha nope.  Apparently an old winget version was the issue.


Add option to edit existing links

Description
Add a feature to edit links (if possible), for details, if the user creates a link https://reduced.to/google with the destination URL to https://youtube.com and after saving the user can still change the destination URL which is all https: //youtube.com to https://instagram.com (example)
Screenshots
No response
Additional information
No response

Additionally, you can add the option to touch down, if someone opens a link that has been shortened at https://reduced.to/, then the owner of the link activates the touchdown feature so when someone opens the link it will not immediately redirect to the destination website. Instead there is a dialog and confirmation button which then directs you to the original link

Hey @h4MeMengoding,
Thank you so much for your time and your ideas, those are 2 great Ideas!
The edit option is in on the roadmap and will be added as soon as possible.
The second idea is really cool and I imagine something similar to linktree.
Also I would appreciate if you can create a different feature request for the second idea.
Do you want to work on one of that ideas?

Hi @origranot and @h4MeMengoding,
I am interested in taking the lead on this feature request and yeah the 2nd one is kinda cool idea.
I'd appreciate any guidelines or preferences you might have regarding implementation. If there are any specific areas you want me to focus on or avoid, please let me know.

@askadityapandey Hey!
That's sounds awesome, you are more than welcome to work on that.
The only guidelines is to use the same form to create and update a link.

hi @origranot, if you would like to add to the self-hosting documentation, that would be better!

Hey @h4MeMengoding,
Let's discuss it on different issue.
Would you mind open an issue and elaborate about the missing self-hosting documentation?

hey @origranot , while installing the project on my local machine (I use arch btw) I am facing some errors while running the frontend part. Would love to know your take on this:
reduced.to git:(master) ✗ npx nx serve frontend

> nx run frontend:serve

The CJS build of Vite's Node API is deprecated. See https://vitejs.dev/guide/troubleshooting.html#vite-cjs-node-api-deprecated for more details.

 —————————————————————————————————————————————————————————————————————————————————————————————————————————————————————

 >  NX   Running target serve for project frontend failed

   Failed tasks:

   - frontend:serve

   Hint: run the command with --verbose for more details.

 >  NX   Nx Cloud Warning: VCS Integration Not Configured

   An active version control integration will be required to continue using Nx Cloud soon.
   An organization admin can connect your organization's VCS platform.
   Connect here: https://cloud.nx.app/orgs/6529380887607af2871b3f28/workspaces/658b366affe0b226ad7d9e85/settings/vcs

   View structured, searchable error logs at https://nx.app/runs/lc660DiWrJ

➜  reduced.to git:(master) ✗

hey @origranot , while installing the project on my local machine (I use arch btw) I am facing some errors while running the frontend part. Would love to know your take on this:
reduced.to git:(master) ✗ npx nx serve frontend

> nx run frontend:serve

The CJS build of Vite's Node API is deprecated. See https://vitejs.dev/guide/troubleshooting.html#vite-cjs-node-api-deprecated for more details.

 —————————————————————————————————————————————————————————————————————————————————————————————————————————————————————

 >  NX   Running target serve for project frontend failed

   Failed tasks:

   - frontend:serve

   Hint: run the command with --verbose for more details.

 >  NX   Nx Cloud Warning: VCS Integration Not Configured

   An active version control integration will be required to continue using Nx Cloud soon.
   An organization admin can connect your organization's VCS platform.
   Connect here: https://cloud.nx.app/orgs/6529380887607af2871b3f28/workspaces/658b366affe0b226ad7d9e85/settings/vcs

   View structured, searchable error logs at https://nx.app/runs/lc660DiWrJ

➜  reduced.to git:(master) ✗

Hey, you are welcome to join the community discord here: https://reduced.to/discord
Let's try to figure it out.


Intellisense broken for large JS projects like cocos2dx-js

From @sachingarg05 on July 16, 2016 17:21

VSCode Version: 1.3.1
OS Version: OSX 10.11.5

Steps to Reproduce:

Create a new Cocos2x-JS project following steps on: https://github.com/cocos2d/cocos2d-x
For example: cocos new -l js WebGame
Open project folder in VS Code.
Setup default jsconfig.json which doesn't exclude anything.
Ctrl+Space (autocomplete) and Cmd+Click (go to definition) don't work.
In ./main.js, try Cmd+Click on cc.view or cc.director. VS Code finds an empty reference to cc in Base64Images.js (var cc = cc || {};) and then can't find anything else in cc like cc.view or cc.director etc...

On opening the same project folder in webstorm, both ctrl+space autocomplete and cmd+click go to definition work as expected. So the problem is not with project or code structure etc.
The Visual Studio team has been working on improving support for Cocos2dx C++ projects.
https://blogs.msdn.microsoft.com/vcblog/2016/07/12/cocos2d-x-visual-studio-android-project/
It will be great if VS Code can support intellisense for large javascript projects like Cocos2dx JS.
Copied from original issue: Microsoft/vscode#9391

Moving to TS team since they provide the language smartness for JS as well.

closing in favor of https://github.com/Microsoft/TypeScript/issues/10142


Bad link in README

The link for “Visit our latest documentation on GitHub.” gets a 404 not found error.

Thanks for pointing this out, David!


Bump parallax log level

Stops the easy out.

bors r+
testing if it works regardless of master merg.

bors cancel


Ideas for un-iframables

[ ] See whether fetch can reliably predict (at least with no false negatives) whether a page can be <iframe>d.
[ ] Detect images and PDF files, and embed them directly (via <img> or pdf.js). I imagine some websites allow embedding of images but don't allow iframing them — should check. This could also let us manipulate the contents, though I'm not sure what we'd want — perhaps synchronized scrolling through PDFs, or seeing each other's cursors to point at those images/PDFs (though that starts to sound like embedding the PDF in Cocreate).
[ ] CORS proxy as in X-Frame-Bypass

X-Frame-Bypass might help in some cases if you are happy with using such a workaround. It appears to only work in Chrome and Firefox however. (It did not work for Zoho Slide Broadcast links :-(  ). Anyone know of any other slide presentation synchronization options which might work with comingle?

@seantrace Thanks for the pointer to X-Frame-Bypass. Using a CORS proxy looks like a promising approach! I'll have to experiment with it. (And for Comingle we shouldn't actually need custom built-in HTML elements, so should be able to work on all modern browsers.)
Regarding slides, see #116. In particular, slides.com seems to embed fine in current Comingle.

@edemaine Interested to hear how your experiments go. I was looking for a slides solution which enabled the presenter to step through the deck  and for all sharing viewers to be kept in sync (maybe with option to manually drop out of sync and then hit a catch-up/resync button).

Looks like I need to read all the issues!
I thought you might be interested that I had some success removing CORS with CORSflare.

A quick but mostly effective hack for your second bullet point above:
https://github.com/edemaine/comingle/blob/2694ff95d20b6ee5dc1c8efe2a912fd21a1026b7/client/TabIFrame.coffee#L50
Can be replaced by checking if the url ends with .pdf and using <embed width="100% height="100%"> instead of .  Something similar for .png or .jpg too I'd imagine.  Regexing any hashes after the extension would make it more robust (and e.g. allow direct linking to pages of a pdf).  It won't handle corner cases when a server might use non-standard URLing, but it should cover most of it.

A quick but mostly effective hack for your second bullet point above:
https://github.com/edemaine/comingle/blob/2694ff95d20b6ee5dc1c8efe2a912fd21a1026b7/client/TabIFrame.coffee#L50
Can be replaced by checking if the url ends with .pdf and using <embed width="100% height="100%"> instead of .  Something similar for .png or .jpg too I'd imagine.  Regexing any hashes after the extension would make it more robust (and e.g. allow direct linking to pages of a pdf).  It won't handle corner cases when a server might use non-standard URLing, but it should cover most of it.


feat: a type with a non trivial filter has to be nonempty

Preliminaries for #6844

bors merge


Make command execution thread based

Title is pretty self explanatory. Making the lib a partly async and thread based model should greatly increase performance.

Note: Because of the way asyncio works I won't be implementing threading. But I'll do smth else to simulate the requested behavior.


feat: add approve config

Codecov Report

Merging #19 into master will decrease coverage by 3.33%.
The diff coverage is 65.38%.

@@            Coverage Diff             @@
##           master      #19      +/-   ##
==========================================
- Coverage   78.08%   74.74%   -3.34%
==========================================
  Files           4        4
  Lines          73       99      +26
==========================================
+ Hits           57       74      +17
- Misses         11       19       +8
- Partials        5        6       +1

Flag
Coverage Δ

#unittests
74.74% <65.38%> (-3.34%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pkg/externalplugins/config.go
70.73% <65.38%> (-9.27%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a682ba9...8f6ff65. Read the comment docs.

/assgin

/assgin

/assgin

/size


Fix binary search operator

For binary search, the operator that rocThrust passes to the rocPRIM backend gives a compile error when using a non-device_reference value with a device_reference from the array. This happens for data types that cannot be implicitly converted from a device_reference, such as thrust::tuple. This is fixed by wrapping the operator in a functor that does this conversion explicitly. The tests for this algorithm are extended to include the described behavior.

@stanleytsang-amd what is required to merge this PR, can you provide details about the failed CI stages?

Sorry I must've missed this PR.  The failures are CI infrastructure specific.  I will talk to the CI team to get these resolved, but I think we can merge this in given all the usual tests passed.


Add Safety Wizard to showcase

Safety Wizard started as an Objective-C iOS application and was recently migrated to React Native to have a single codebase across our iOS and Android apps.
This PR has been updated to reflect the guidelines as per @hramos in the previous PR #10679

I am not sure this meets the requirement of having a technical blog post on React Native just yet, I'm afraid.


No status when lacking cache permissions

If cluster-scoped list & watch permissions are missing for types contained in the bundle image, operator-controller will fail to populate .status.
Intenal error also blocks deletion of ClusterExtension CR, due to non-handling of finalizer teardown.
Log example:
W0918 08:58:27.304878       1 reflector.go:561] pkg/mod/k8s.io/client-go@v0.31.0/tools/cache/reflector.go:243: failed to list apps/v1, Kind=Deployment: deployments.apps is forbidden: User "system:serviceaccount:nginx:nginx-install" cannot list resource "deployments" in API group "apps" at the cluster scope
E0918 08:58:27.304923       1 reflector.go:158] "Unhandled Error" err="pkg/mod/k8s.io/client-go@v0.31.0/tools/cache/reflector.go:243: Failed to watch apps/v1, Kind=Deployment: failed to list apps/v1, Kind=Deployment: deployments.apps is forbidden: User \"system:serviceaccount:nginx:nginx-install\" cannot list resource \"deployments\" in API group \"apps\" at the cluster scope" logger="UnhandledError"

Could be fixed with #1282

Would you mind sharing the "version" you ran? If it was a release on GH, which one? if from main, which commit?

Ah, I think that was cut just before I did a pretty large refactor of our caching logic. Would you mind verifying that you are not seeing this issue if you pull the latest changes from the main branch?

Will do o7


Removed explicit calls to bash before scripts.

Change Description

Removed bash being called before each script.
API Changes

[ ] API Changes

Documentation Additions

[ ] Documentation Additions

See https://buildkite.com/EOSIO/eosio-dot-cdt-beta/builds/169 .

See https://travis-ci.com/EOSIO/eosio.cdt/builds/123561807 .


Replace deprecated ControllerConfig with DeploymentRuntimeConfig

Description of your changes
ControllerConfig has been deprecated and it is now recommended to use DeploymentRuntimeConfiginstead as of crossplane v1.14.4
This PR implements that change with a more readable mechanism for deployment.

Fixes #
I have:

[ ] Read and followed Crossplane's contribution process.
[x] Run make reviewable to ensure this PR is ready for review.
[ ] Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested
Existing CI

Question: Where do we control Crossplane's version? If it is here, should we update the version at least v1.14.0 for DeploymentRuntimeConfig?

We don't actually control the version. We install via Helm using stable so it just pulls the most recent version. The libraries like you've linked above shouldn't matter too much as the versions will be backward compatible.


[BEAM-8285] Upgrade to ZetaSQL 2019.09.1

This upgrade removes the need for libstdc++.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[x] Choose reviewer(s) and mention them in a comment (R: @username).
[x] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

R: @amaliujia

run SQL Postcommit

LGTM assuming SQL post commit pass


Proper garbage collection

Yes this was needed, wanted to comment on your prev change

Right, thanks!


Designs for loading and error states

Supported Devices Table

Loading state / error states
Search / filter, no results found

AccessCodeTable / DeviceTable / (Any)Table:

Loading state / error states
No Items returned
Search / filter, no results found

AccessCodeDetails & Device Details / (Any)Details:

Loading state / error states
404 Not Found

AccessCodeForm / (Any)Form

~Loading state / error states~ Moved to https://github.com/seamapi/react/issues/402
404 Not Found

Connect Account Button

Loading state for when clicked
Error state for when the API did not create a connect webview

The snack bar works for errors, but not as a loading indicator. I tried a mini floating version but it's too heavy handed to show loading status. I'm thinking a set of messaging methods should work for most situations:

Centered message with spinner for component first load
Floating or inline feedback for loading
Snackbar for error.

There's more to do on this, but wanted to get feedback first.
Here are two scenarios for...

loading the component at first
loading devices
error when trying to load devices

I think the dark loading floater is too strong, but i think the steps are right. Send feedback and I'll revise.
Watch prototype: https://github.com/seamapi/react/assets/112443289/af91eae0-c7bf-47e7-95d2-d79e4ce4ad49

@razor-x @dawnho Here's a set of prototypes for 7 of the different cases in the original issue comment. Some are small and some are large.
The same basic little floating feedback widgets work on different sizes and shouldn't interrupt anything in the ux.
The link below goes to an index. Click the link to see the prototype. You can type R on your keyboard at any time to return to the index page.
This isn't done but wanted to get feedback before going further. The system seems pretty ok, but i can try it in a few other contexts before building it.
Click here to try the prototypes:
https://www.figma.com/file/Su3VO6yupz4yxe88fv0Uqa/Seam-Components?type=design&node-id=1871%3A14268&mode=design&t=oAQRPDWRn1B2J9J9-1

Updated figma prototype link...
https://www.figma.com/proto/Su3VO6yupz4yxe88fv0Uqa/Seam-Components?page-id=1871%3A14268&type=design&node-id=1931-38264&viewport=2319%2C211%2C0.45&t=OCrhXwOtO36XlHRG-1&scaling=min-zoom&starting-point-node-id=1931%3A38264&show-proto-sidebar=1&mode=design


initialized file structure and files

Issue 1

It looks pretty good!  The only thing I can see is it looks like the eslint was removed from the package.json.  We probably want to keep that in there.

@jburz  I will add the ESLint in the package.json, thank you for catching that! I can see it in the "scripts" section and the "devDependencies" section. Where else does it go?

As long as it has been installed then the package.json dependency should auto update.  It would need to be added manually as a script.


[Bug report]: Dropdown Filter looses data once result is not found

Requirements before reporting

[X] No duplicated issue reported.
[X] I have read the contribution guidelines.
[X] I have checked the lastest version if the bug exist there. See all avaliable packages at npmJS.com
[X] I have made sure that the issue comes from SDDS packages by removing SDDS from my project as a test.
[X] I have followed the installation guide.

Package
@scania/components
Package versions
@scania/components: 4.6.0
Browser
Chrome
Framework
Angular
Version
Angular 13.3.0
Reproduction steps

Go to https://digitaldesign.scania.com/components/dropdowns/code and go to Filter dropdown
Select an option
Type text that isn't available in the dataset
Click outside of the dropdown
Open dropdown
No data available
The prior selected option is now the search term, but no results remain?

Code example
No response
Screenshots
Add/Copy screenshot here

Expected behaviour
The search criteria should not revert back to the selected option itself.
Show the search criteria that have no results and allow the user to remove this themselves to get back to a clean state.
Console errors
No response
Contact information
<EMAIL_ADDRESS>

Spoke with a colleague and seems this would be the intended behavior as it is reverting back to the selected option.

Can I get an ETA on this? as our testers picked up this is still a problem.

Hi @furkick! We don't have an estimate on when to look at this at the moment. However I would like to see how this works/does not work in your application. I'll reach out to you with a time suggestion.

I am closing this issue due to inactivity. If the issue still persists, feel free to reach out to our PO Johan Nilo.


Performance difference vs Windows Instance

Hi,
I've been migrating my Windows instance over to containerd on WSL2. I'm finding there is quite a performance difference between the two.
I've a dotnet core executable which provisions a database and runs scripts (about 4MB worth) on it. On windows it takes 28s to run, against the docker image it takes 1m5s. I've tried running the client from both WSL (1m5s) and from Windows(1m4.9s), and see similar issues.
My command to run up the instance is:
	nerdctl run -d --name sql -e 'MSSQL_PID: Developer' -e 'ACCEPT_EULA=Y' -e 'MSSQL_SA_PASSWORD=apassword' -p 2198:1433 -v .sql-data/data:/var/opt/mssql/data mcr.microsoft.com/mssql/server:latest

Can anyone shed any light on how to diagnose this?
Thanks,
Chris

Hi, are the resources given to both WSL and Windows instance the same? Overall the SQL Server engine is the same when you run on Windows or Linux. Also, what is the storage associated with the database when you are using the WSL2, can you try SQL Server on dedicated Linux VM or container and then see if the same issue exists. SQL on WSL 2 is currently not supported for production or equivalent workload.

Hi @amitkh-msft, yes, this is running on the same machine, and there is plenty of headroom in capacity for resource not to be the issue.  Storage wise, both are running on the same NVMe SSD. For WSL2, its using the default file system and a folder in my home directory, so would be on the virtualised ext4 filesystem. I can't really run it on a like for like dedicated VM, and a different VM might reduce clarity further? I'm using this for my dev environment, so lack of production support isn't an issue as such.

I was on docker using 2017 version and it was ok (not as good but usable), migrate to 2022 and at start it was faster, but after 2 weeks it became dog slow.
Rebuild from backup after wipe and same behavior.
compose:
`version: "3.8"
services:
mssql:
container_name: mssql
hostname: mssql
image: mcr.microsoft.com/mssql/server:2022-latest
stdin_open: true # docker run -i
tty: true        # docker run -t
restart: always
environment:
- MSSQL_SA_PASSWORD=12345Password!
- SA_PASSWORD=
  - ACCEPT_EULA=Y
  - MSSQL_PID=Express
  - MSSQL_COLLATION=Polish_CI_AS
  - MSSQL_MEMORY_LIMIT_MB=8192
  - MSSQL_BACKUP_DIR=/var/opt/mssql/backup
  - TZ=Europe/Warsaw
ports:
  - "1434:1433"
volumes:
  - mssql_data:/var/opt/mssql
  - backup:/var/opt/mssql/backup
  - /etc/timezone:/etc/timezone:ro
  - /etc/localtime:/etc/localtime:ro

volumes:
mssql_data:
name: mssql_data # This line is not allowed to be changed
backup:
name: backup
driver_opts:
type: cifs
o: "username=mssql-backup,password=XXX,vers=3.0,file_mode=0777,dir_mode=0777,rw,uid=10001,gid=10001"
device: "//XXX.XXX.XXX.XXX/mssql"`
I migrate again to Windows Server 2022 and SQL 2022 and it's the fastes.
All is on Proxmox using as VM on same SSD's, same CPU.

ubuntu 22.04 LTS and docker
Windows Server 2022.

Some forum threads:

https://forum.proxmox.com/threads/mssql-on-zfs.56992/

Same data base, same app, same users and on docker it's became painful slow.

could you share sample queries for the purpose of context to understand the slowness that you describe? Additionally, could you please open a support ticket for our team to investigate this further?

i'm using ERP software INSert ERP from insert.com.pl and it's not depend on any specific query - but general reading, writing, updating etc. i see performance scale across the board. i test it on internal accounting to test some "real life" workload but accounting couldn't do it's work - it was so slow.
It's not official supported on linux SQL, but it's SQL so it's should work. But idk why performance keeps slowing down on linux. only backup was faster than windows host but even that became dog slow.
If i can make any diagnostic let me know i will try to provided it.
When trying to find problem i only see some network I/O delay and waiting task go from 0 to 1 to 0 to 1 or stay on 1. but couldn't define why.
adding extra templog files didn't help
my only idea was because it's wasn't used heavy all the time, process was mark as background so when i use it heavy it have to low priority. after redeploy of container and restore DB from backup for some time it will be back to snappy. maybe it's about memory priority. idk really.
How to open a support ticket to investigate this further?


[FEATURE] Donate Popup

Problem
Friction of going and adding to cart then putting in price is screwing up flow of donations.
User Story(s):
As a user I want to select how much and what currency I want to donate to.
Description
Donate popup accessible from project page and project card that allows you to enter amount and currency and donate directly with success screen
Acceptance Criteria

[x] Donate popup
[x] Accessible from donate button on project card
[x] Accesible from doante page on project profile
[x] Drop down fungible toknes
[x] Show price equivalent and amount
[x] Allow to add to cart (saves in local storage)
[x] Button to donate directly
[x] Show break down of fees with dropdown
[ ] Add optional fees (not sure if this in design
[x] Show success screen if donated usccess
[x] succes screen shows share to social button
[x] success screen show donor name with near social profile
[x] success screen shows amount in NEAR
[x] susccess screen shows transactino has and opens in new tab on nearblocks
[x] minimum amount on front end to cover storage costs.
[x] donate.potlock.near to initatie
[x] add referral fees if ferrer sent link (maybe through local storage or throuhg app props)
[x] ability to add note (pass into donate.potlock.near)

Limitations

need external api for token price

Resources

@lachlanglen  Add optional fees (not sure if this in design) -> no has design and I think it's not necessary with this mvp

Will create a separate ticket for optional fees


Zurb Foundation Templates

I personally prefer working with Zurb Foundation and was wondering if you might accept a PR with Foundation templates?

1+ I would like to help out with a foundation package

@scott-mcpherson and @micahalcorn have you already started working on this template? Im using foundation and to use this package I need a decent support for foundation.

I use meteor-autoform with Zurb Foundation also - excited to see interest in this!


Graph query execution with adaptive batching

Feature Request
Legend engine provides batch execution capability for graph fetch queries. Batch execution capability lets the engine perform "graphFetch" operation (fetch the nested property structure as per the query) on a list of objects in one go.
This feature significantly improves performance of graph queries, specially in the case of relational stores where the cost of executing a SQL query is high. Let's consider a situation where a graph fetch operation is being performed on 2000 objects and the fetch tree requires 5 SQLs to be executed. Without batching, the number of SQL executions would be (2000 * 5 = 10000). The same graph fetch operation when done with a batch size of 1000 would require (2 * 5 = 10) SQL executions which is a lot less (2 is the number of batches). However, executing graph fetch with batching would increase the memory requirement from server perspective.
Description of Problem:
Currently, batch size is configured in the query as an extra parameter to graph fetch operation. It remains constant during the execution. Also, there is a memory limit which is put up to cap the memory being consumed for each batch in the execution (can result in failures if memory limit is breached). It requires some effort to tune the batch size and arrive at a good number, by doing a tradeoff between performance and memory utilization.
Potential Solution:
One of the ways we can tackle this problem is to build an adaptive batching mechanism. Recently, some extra stats were added to graph fetch execution in this PR: https://github.com/finos/legend-engine/pull/492. The idea is to use the stats from previous batches to decide on the batch size for next batch thereby adapting to the dynamics of the execution (increasing batch size if the memory consumption is less compared to the memory limit or reducing batch size if memory consumption exceeds or is close to the memory limit). This feature can help improve performance in the case of executions which are less memory intensive and also avoid failures in executions which are memory intensive.

This issue is stale because it has been open for 30 days with no activity. Please remove stale label or add any comment to keep this open. Otherwise this will be closed in 5 days.

This issue was closed because it has been inactive for 35 days. Please re-open if this issue is still relevant.


"Extension 'ESLint' cannot format 'File.ts'", then it does

I have eslint set up to format on save, and it does, but it also puts a notification in the status bar saying that it cannot.

Repro: https://github.com/JacksonKearl/eslint-cannot-format-repro
https://github.com/microsoft/vscode/blob/43bfc2cda0bf7e5f4d037d06e39754e878bc2a90/src/vs/workbench/contrib/format/browser/formatActionsMultiple.ts#L95-L101

@db to confirm but afaik ESLint is not a formatter, e.g it doesn't contribute into the "Format Document" command but it contributes code actions. Now, the line between code actions and formatting is blurry but in our API and features it's pretty crisp: An extension that calls "registerFormattingProvider" is a formatter (and hence part of the formatting flows) and an extension that calls "registerCodeActionProvider" is not a formatter, but used for fixes, refactorings, and clean-up.

@jrieken ESLint does contribute a formatter if the setting eslint.format.enable is set to true. In this case it dynamically registers a formatter provider.

@JacksonKearl do you have code actions on save enabled as well. If so I guess the formatting happens because of that. But it still doesn't explain the message unless eslint.format.enable is not set to true.

I had "editor.defaultFormatter": "dbaeumer.vscode-eslint" but not "eslint.format.enable": true,, that probably explains it. Is there benefit to using it as a formatter rather than just applying the code actions on save?

Only benefit is that you can invoke the formatter with the default formatter key binding. I personally prefer code action on save.
Closing the issue. Please ping if you think otherwise.


Implement subpath pattern exporting for papi-components

Our custom components, located in lib/papi-components/src are exported from a single index.ts file.
A cleaner solution would be to create a separate export file for each component.
More info can be found in the Node JS docs
Additional reads:
https://github.com/audi2014/react-async-concurrent/blob/main/docs/subpath-imports.md
https://github.com/vitejs/vite/discussions/8575
https://davidwells.io/blog/publishing-flat-npm-packages-for-easier-import-paths-smaller-consumer-bundle-sizes
https://stackoverflow.com/questions/44345257/import-from-subfolder-of-npm-package/61829317#61829317

Thanks for adding this @rolfheij-sil. I did look into this when working on #179 but it wasn't clear to me that flat paths actually effect bundle size, in fact some people say it doesn't help at all and is separate from bundling. In the end I left it out because we are using tree-shaking and I know (from testing)  that does remove any unused parts of papi-components. Even for lodash (which was given as an example of flat paths in one of the linked articles) warns that it might help but it might not, e.g. if you import lodash/<A> and lodash/<B> that have a common dependent function then you will get 2 copies of that dependent function, whereas if you just import A and B from lodash directly and tree-shake then the total bundle size will be smaller because it will only have one copy of the dependent function. So I would recommend tree-shaking for extension developers at the moment. Having said that this might still be useful to do as it is the modern way of importing sub-components of a package, and esp if we can show it does make a difference to bundle size.

I recommended this as it would make it a lot easier to understand what types and such come with which component. However, if there are disadvantages as you mention, maybe we should leave it alone. Can we do some kind of namespacing with another method to avoid throwing tons of disparate types all in one module? Thanks for the thoughts!

Maybe we should consider subpaths for scripture utilties and hooks (assuming we end up putting hooks in here as I have been thinking maybe we should do) to keep things organized. Like here https://reviewable.io/reviews/paranext/paranext-core/468#-NfRW7MxE475_NAOStBG it's all at the same level, but that seems really hard to keep track of what's what.


Document the CLI a bit more

The information on using the CLI doesn't really show people how to actually use and install the CLI. I can take a stab at it also once there's a broader discussion.

This is attended to in https://github.com/fermyon/bartholomew/pull/110
Please feel free to close this, once 110 is merged, if you like.


Add custom information to GeoPoint marker

Hello,
I am currently trying to add information to my marker (description, tags, ..) that I can fetch when clicking the marker. My problem is that onGeoPointClicked returns a GeoPoint object and doesn't allow it to have more into rather than the latitude and longitude. Is there a way to override the callback onGeoPointClicked to have a CustomGeoPoint object ?
Thank you in advance !

you mean when you add marker to map you need to store some information and when you click on it you get those information ?

Indeed !
I was able to create a custom GeoPoint class thats extends GeoPoint to give the information, but I cannot fetch the information on click.

Can you please share your code for custom GeoPoint class ?

sorry for late theoritically you can link additionnal information and geoPoint with lat/lon
you can create Map<GeoPoint,AdditionnalInfo> when user click and get geoPoint fetch that Map to get the information need it

Same problem!
I have 10 markers, each has its own id, I want to display a message on click on the marker by id, and not by longitude and latitude.
(because I can have 2 different markers with exactly the same longitude and width).
Please add String id to GeoPoint class!


Transform map[something]SomethingNotNullable

Add the option to transform map[x]Y correctly.
It also adds some testing to protobuf.Type IsNullable method.
Resolving aliases had some problems too.

Except generated.pb.go, everything else is reviewable.

Rebased, waiting for travis.


Peripherals?

Issue Type

[ ] Bug
[x] Feature Request
[ ] Question

Problem and possible solution
It'd be great to see usb devices and other peripherals(firewire, thunderbolt, etc).

USB -> https://www.npmjs.com/package/usb
Bluetooth -> https://www.npmjs.com/package/noble
Serial Port -> https://serialport.io/docs/en/api-stream#serialportlist

Started to work on this ... will try to provide first approach next week.

@sebhildebrandt is there any update to this?

@OmgImAlexis  Got also stuck with other things, never finished this ;-) ... will also try to work on this next week.

@OmgImAlexis, @ldittmar81  Version 5.0 just released. Here we have some new sections like USB, Bluetooth, Audio, Printers which allows now to get back more detailed information about peripherals.
Be aware: Version 5 is NOT fully backwards compatible to version 5 ... see https://systeminformation.io/changes.html to get an overview over all breaking changes.

@OmgImAlexis, @ldittmar81  Version 5.0 just released. Here we have some new sections like USB, Bluetooth, Audio, Printers which allows now to get back more detailed information about peripherals.
Be aware: Version 5 is NOT fully backwards compatible to version 5 ... see https://systeminformation.io/changes.html to get an overview over all breaking changes.


Show detailed autocomplete data for the power bi dashboard

Is your feature request related to a problem? Please describe.
To verify the work done with the new release of autocomplete we need to be able to go into detail about how the errors are going down

Closing this as the telemetry is visible with good results


Bluetooth: BAP: Fix bad check in bt_audio_valid_qos_pref

The checks did not properly take into account
that the pref_pd_min and pref_pd_max could have valid 0 values.

#AutoPTS run zephyr BAP/UCL/SCC/BV-035-C

Scheduled PR https://github.com/zephyrproject-rtos/zephyr/pull/79413#issuecomment-2393559820, board: nrf53, estimated start time: 14:11:18, test case count: 1, estimated duration: 0:00:58Test cases to be runBAP/UCL/SCC/BV-035-C

AutoPTS Bot results:
No failed test found.
Successful tests (1)BAP     BAP/UCL/SCC/BV-035-C            PASS


Help example for --excludes does not work

$ npx sabik system/ -o build/sabik --excludes=*.test.ts,*.spec.ts
    SyntaxError: Invalid regular expression: /*.test.ts/: Nothing to repeat

$ npx sabik -h
This is source code metrics tool.

USAGE
  $ sabik [TARGET]

OPTIONS
  -h, --help                             show CLI help
  -o, --outputReportDir=outputReportDir  output report directory path. default: ./sabik_report
  -v, --version                          show CLI version

  --excludes=excludes                    exclude patterns is separated by a comma. example:
                                         *.test.ts,*.spec.ts

  --matches=matches                      match patterns. example: .ts$

@kenjis
Hi, Thank you.
Fixed example in help command.

@kenjis
Hi, Thank you.
Fixed example in help command.


Wrong HttpStorageRpcSpans.SPAN_NAME_LIST_OBJECTS value?

https://github.com/googleapis/java-storage/blob/5e9906173ade5434ce1cecbd920445494b375652/google-cloud-storage/src/main/java/com/google/cloud/storage/spi/v1/HttpStorageRpcSpans.java#L30

Thanks for bringing this to our attention, I'll consult with some folks and hopefully have a fix.


Counter and test

Added comments Counter to the website and added test to it

Great job @shakerAbuDrais ! Keep it up! 👏


jetpack deploy failure in RHEL7 ansible jumphost

Is RHEL7 the preferred ansible jumphost OS distro?  or RHEL8?  It doesn't say here in docs.   RHEL7 seems to cause problems, see this log for details.

It should work on both. I usually use RHEL 7 jump host. Can you share the RHEL 7 version on which you are facing this problem as I tried reproducing it on an RHEL 7.8 jump host but didn't encounter the above issue http://paste.openstack.org/show/800800/

This procedure is how I prepare my cluster to run jetpack.
The python3-virtualenv package is not installing.  Can't figure out how it ever would.
ok: [localhost] => (item=python3-virtualenv) => {                                                                                [622/1903]
    "ansible_loop_var": "item",
    "changed": false,
    "changes": {
        "installed": [
            "python3-virtualenv"
        ]
    },
    "failed_when_result": false,
    "item": "python3-virtualenv",
    "rc": 1,
    "results": [
        ""
    ]
}

MSG:

Traceback (most recent call last):
  File "/usr/bin/yum", line 4, in <module>
    import yum
ModuleNotFoundError: No module named 'yum'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/bin/yum", line 6, in <module>
    print >> sys.stderr, """\
TypeError: unsupported operand type(s) for >>: 'builtin_function_or_method' and '_io.TextIOWrapper'. Did you mean "print(<message>, file=<output_stream>)"?

ok: [localhost] => (item=python3-libselinux) => {
    "ansible_loop_var": "item",
    "changed": false,
    "failed_when_result": false,
    "item": "python3-libselinux",
    "rc": 126,
    "results": [
        "No package matching 'python3-libselinux' found available, installed or updated"
    ]
}

MSG:

No package matching 'python3-libselinux' found available, installed or updated

will try switching ansible jumphost to RHEL8 and see if problem goes away

are you using RHEL 7.7?

yes, that's what default Alias lab deployment gave me
On Mon, Dec 7, 2020 at 10:34 AM Asma Syed Hameed<EMAIL_ADDRESS>wrote:

are you using RHEL 7.7?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/redhat-performance/jetpack/issues/316#issuecomment-739993258,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AANDG44WGPKUM5RK7U44H3TSTTYY3ANCNFSM4UQSA3ZA
.

Am upgrading to RHEL7.8 and seeing if problem goes away first

So with RHEL 7.7, we don't have support for python3 packages. So instead, please use RHEL 7.8

It's getting much farther now, so I think this was the problem.  Would help if docs were updated to mention you need > RHEL7.7

@bengland2 Thanks for reporting the issue. We have updated the docs #317  and since the issue is not reproducing in RHEL 7.8. Closing the issue.


Failed to report incoming call to CallKit

Description
App doesn't handle callInvite properly when it is in background or inactive state. On quickstart-ios, there is note says;
"The Voice SDK processes the call notification and returns call invite synchronously. Report the incoming call to CallKit and full the completion before  existing this callback method." and after that it does report incoming call in another functions.
Steps to Reproduce

Register VoIPPush and Twilio in app.
Exit app, wait enough to app is terminated because it failed to report incoming call.

Code
func pushRegistry(... didReceiveIncomingPushWith)
{
incomingPushReceived(payload: payload, completion, completion)

getCallInfo { (callInfo: CallInfo) in
reportIncomingCall(from: callInfo.nameLastName, uuid: callInvite.uuid)
}

completion()
}

Expected Behavior
Receive Call Invite properly
Actual Behavior
iOS terminated App
Reproduces How Often
While the app is in background or inactive states, always.
Voice iOS SDK
Twilio 6.1.0
Xcode
12.3
iOS Version
14.0
iOS Device
iPhone 6s

Hi @meokullu
Sorry that we couldn't get back to you sooner.
To sure that your application can handle incoming VoIP push notifications properly especially when the app was previously terminated, please make sure the PkPushRegistry object is initialized at launch time and kept in the frontmost app component. You can check out the AppDelegate implementation of the quickstart and apply necessary updates.

Hi @meokullu
Sorry that we couldn't get back to you sooner.
To sure that your application can handle incoming VoIP push notifications properly especially when the app was previously terminated, please make sure the PkPushRegistry object is initialized at launch time and kept in the frontmost app component. You can check out the AppDelegate implementation of the quickstart and apply necessary updates.

Hi @meokullu
Hope everything is well. I am hoping that no news is good news and you have managed to resolve the issue.
Closing the ticket for now but please feel free to reach out to us any time.
Best,
-bobie

Hi @meokullu
Hope everything is well. I am hoping that no news is good news and you have managed to resolve the issue.
Closing the ticket for now but please feel free to reach out to us any time.
Best,
-bobie


Session state data issue

Bot Info

App ID: cb62b172-3eab-4c33-9fb9-4df68f35cf70
SDK Platform:  Node.js
SDK Version: 6.5.0
Active Channels: Slack, WebChat
Deployment Environment: Auzure Bot Service (Consumption Plan), LUIS Bot

Issue Description
Updated the bot to use inMemory Bot Storage but session.dialogData variables are not getting stored
Code Snippet
var connector = useEmulator ? new builder.ChatConnector() : new botbuilder_azure.BotServiceConnector({
    appId: process.env['MicrosoftAppId'],
    appPassword: process.env['MicrosoftAppPassword'],
    stateEndpoint: process.env['BotStateEndpoint'],
    openIdMetadata: process.env['BotOpenIdMetadata']
});

var inMemoryStorage = new builder.MemoryBotStorage();
var bot = new builder.UniversalBot(connector).set('storage',inMemoryStorage);
.....
    builder.Prompts.text(session, "Please mention your policy ID");
},
function(session, results, next) {
    if(results.response) {
        session.dialogData.policyNumber = results.response.entity;
        session.send("%s Policy number", session.dialogData.policyNumber);
    }
    builder.Prompts.text(session,"Please enter your Payment Month:");
},

Output
undefined Policy number
Package.json
{
   "name": "luisbot",
   "version": "1.0.0",
   "description": "",
   "main": "index.js",
   "dependencies": {
   "botbuilder": "^3.7.0",
   "botbuilder-azure": "3.0.2",
   "apiai": "^4.0.3",
   "express": "^4.15.4",
   "express-favicon": "^2.0.0"
}

@mlnewbie What happens after you upgrade botbuilder to 3.13.1 (current)?

Hi I tried specifying botbuilder directly as 3.13.1 in package.json and then did an npm update but the issue persists. Have reverted back to specifying ^3.7.0 which I think anyway pulls the latest version? Thanks
-----Nils<EMAIL_ADDRESS>wrote: -----
To: Microsoft/BotBuilder<EMAIL_ADDRESS>From: Nils<EMAIL_ADDRESS>Date: 12/10/2017 01:28AM
Cc: mlnewbie<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [Microsoft/BotBuilder] Session state data issue (#3897)
@mlnewbie What happens after you upgrade botbuilder to 3.13.1 (current)?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
=====-----=====-----=====
Notice: The information contained in this e-mail
message and/or attachments to it may contain
confidential or privileged information. If you are
not the intended recipient, any dissemination, use,
review, distribution, printing or copying of the
information contained in this e-mail message
and/or attachments to it are strictly prohibited. If
you have received this communication in error,
please notify us by reply e-mail or telephone and
immediately and permanently delete the message
and any attachments. Thank you

This seems to be an issue to me too (on 3.13.1). session.dialogData logs to the console, but I can't output any of the variables in a chat


Support dgTMatrix

This pull request adds support for dgTMatrix - I used pg 40 of https://cran.r-project.org/web/packages/Matrix/Matrix.pdf and https://slowkow.com/notes/sparse-matrix/#the-triplet-format-in-dgtmatrix as references, and call csr_matrix using the (data, (row_ind, col_ind)), shape parameter format

Hey @keller-mark, Do you have a test RDS file that contains a dgTMatrix?


Error: Module did not self-register (Node 21.5.0 and uWS 20.35.0)

Hi all, try to use both latest version of NodeJS and uWS, But we have an error:
Error: Module did not self-register: '/builds/devs/uws/uws_linux_x64_120.node'.     at /builds/devs/uws/uws.js:22:9     at Object.<anonymous>     at Module._compile (node:internal/modules/cjs/loader:13)     at Module._extensions..js (node:internal/modules/cjs/loader:1434:10)     at Module.load (node:internal/modules/cjs/loader:1206:32)     at Module._load (node:internal/modules/cjs/loader:1022:12)     at Module.require (node:internal/modules/cjs/loader:1234:19)     at require (node:internal/modules/helpers:1[76])     at Object.<anonymous> (/builds/devs/adminApiGateway.js:8:13)     at Module._compile (node:internal/modules/cjs/loader:1375:14) Node.js v21.5.0
Of course, all binaries available, we check signature - in latest nodejs still usage version 120.
In pervious, 21.4.0 nodejs - all OK.

You probably aren't using official Node.js builds download from nodejs.org

Same here;
https://github.com/ardatan/feTS/actions/runs/7292079034/job/19872333146?pr=974

It does look like the problem is 20.35.0 release specific, setting 20.34.0 explicitly sorted the issue in our case...

Last release is broken from a linker issue. Will be fixed in next

CI is building a fix that works, will release when done


Support running a command to retrieve GitHub token

Enable running a shell command defined in the config file to retrieve
the GitHub API token.
Add the function get_value_from_command which handles calling the
subprocess when the string passed to it begins with !, otherwise the
original string is returned.
Updated README.rst to document this new behaviour.
Resolves #65

@kbenzie look good to me. Some minor changes. Also, would you mind changing the summary of the commit so it is has the gist: prefix (this is convention used in this repo for non-merge commits), but make sure that the summary is still less than 50 characters.
Thanks for taking the time to add this feature :+1:

Awesome! Thanks for the new feature.


Branch Switcher modal dialog too narrow for branch names

Description
Not sure if you want to get some bug reports on experimental features aswell, but kindly let me know if you don't.
Currently we are playing around with the branch-switcher and we noticed that the modal dialog is too narrow for our branch names to be displayed correctly.

Steps to reproduce

Enable branch-switcher experimental feature (-><EMAIL_ADDRESS>Deploy site
Open Branch switcher via Select Branch in sidebar

Expected result
All branch names should be viewable and not being truncated
Actual result
The Modal dialog looks somewhat distorted.

Environment
Tinacms Package Versions

├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>

Tools

Tool
Version

browser
brave Version 1.32.113 Chromium: 96.0.4664.45 (Offizieller Build) (64-Bit)

os
Ubuntu 20.x

node
v16.13.0

npm
8.1.4

Thanks @Perni1984! Definitely appreciate feedback on experimental features.


deployment pkg: added WithSchedulerName func

Example use-case is for NUMA awarding scheduling where dedicated scheduler is configured

/lgtm


Test review

WHAT

🤖 Generated by Copilot at 6018f3c
This pull request updates the GitHub actions and ansible playbook for deploying and testing the Boi bot, a sub-bot of the main wkk_discord_bot. It ensures that the latest Boi image is used, that the bot can connect to the server and the wavelink node, and that the docker resources are managed properly.

🤖 Generated by Copilot at 6018f3c

Boi tasks renamed
Deploy with latest image
Autumn leaves fall, prune

WHY

HOW

🤖 Generated by Copilot at 6018f3c

Rename task 'Stop Boi' to 'stop Boi' for consistency (link)
Specify that 'Test Run' task is for Boi bot (link)

Use latest Boi image from GitHub container registry (link)
Pass environment variables for bot and wavelink connection (link)
Create docker network if not exists (link)
Remove old container before running new one (link)
Prune unused images (link)

👀


Generate Graphs

Goal: Enola should be able to generate visual graphs.
It actually already can, sort of - but the goal here is to "generalize" this, to "any linked models" (incl. RDF).
Issue Definition of Done: https://docs.enola.dev has several (more than 1) graphs #dogfood.

https://docs.enola.dev/concepts/other/#visualization has possible tools (contrib. by PR to add more). -- I've "researched" this a bit more the other day (read e.g. this), and will likely start with generating GEXF, and maybe still also the venerable DOT.gv Graphviz format.
Others can contribute converters to additional other such formats as well, of course.

http://rdfvizler.dyreriket.xyz/

https://docs.enola.dev/models/example.org/graph/
https://docs.enola.dev/concepts/graph/
https://docs.enola.dev/use/rosetta/#graphviz

https://github.com/visjs/vis-network/issues/505 is why I can't "just" use the DOT (GV) "directly" in vis.js; @digitalentity FYI.

https://visjs.github.io/vis-network/examples/ but probably even better let's just use:
https://www.sigmajs.org/storybook/?path=/story/load-gexf-file--story
https://www.sigmajs.org/storybook/?path=/story/mouse-manipulations--story
It just needs a /gexf?q=enola:/ sort of URL supported on the UI.


Disneynow - Unable to extract post url, --ap-mso=Comcast_SSO does not work

Checklist

[x] I'm asking a question
[x] I've looked through the README and FAQ for similar questions
[x] I've searched the bugtracker for similar questions including closed ones

Question

Everytime I try pasting the script url in the cmd prompt, it says unable to extract post url. Btw, I'm using Python 2.6.

once you are signed in with your TV provider, try using the cookies command.

I tried that, and it still won't let me.

There seems to be an issue using ComcastSSO when you are not on a Comcast IP address.


Generator: Upgrade Deps (Security)

npm audit has some deps to be updated for the generator itself.

:tada: This issue has been resolved in version 2.0.2 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Autocomplete

Hi,
Thanks for your lib!
I spend a few hours to try to implement an autocomplete but did not succeed.
Do you have a way please ?

Hi @Kenji94,
sorry I do not have any time currently to look into this. I have not used autocomplete with ng-mat-search-bar so far, so I cannot assist you.
I am happy to review a pull request if you do implement something, that's all I can offer for now, sorry.
Cheers,
Tom

Closing this, as I cannot offer development of this feature right now and TO did not follow up on this.


Training returns keras.callbacks.History and does not complete the total number of epochs

Training ends before reaching the set epoch amount. Detector and recognizer training.
Why is this happening?
I'm using the example notebook, even training on google colab or paperspace.com.
https://console.paperspace.com/fabioharry/notebook/rhnaf58unfsnkbp
Is there a way to continue from a checkpoint instead of starting from scratch every time?
detector_batch_size = 2
detector_basepath = os.path.join(data_dir, f'detector_{datetime.datetime.now().isoformat()}')
detection_train_generator, detection_val_generator, detection_test_generator = [
    detector.get_batch_generator(
        image_generator=image_generator,
        batch_size=detector_batch_size
    ) for image_generator in image_generators
]
detector.model.fit_generator(
    generator=detection_train_generator,
    steps_per_epoch=math.ceil(len(background_splits[0]) / detector_batch_size),
    epochs=50,
    workers=0,
    callbacks=[
        tf.keras.callbacks.EarlyStopping(restore_best_weights=True, patience=5),
        tf.keras.callbacks.CSVLogger(f'{detector_basepath}.csv'),
        tf.keras.callbacks.ModelCheckpoint(filepath=f'{detector_basepath}.h5')
    ],
    validation_data=detection_val_generator,
    validation_steps=math.ceil(len(background_splits[1]) / detector_batch_size)
)

Epoch 7/50
827/827 [==============================] - 316s 382ms/step - loss: 0.0043 - val_loss: 0.0114
Epoch 8/50
827/827 [==============================] - 324s 391ms/step - loss: 0.0050 - val_loss: 0.0158
Epoch 9/50
827/827 [==============================] - 316s 382ms/step - loss: 0.0052 - val_loss: 0.0054
Epoch 10/50
827/827 [==============================] - 326s 395ms/step - loss: 0.0035 - val_loss: 0.0117
Epoch 11/50
827/827 [==============================] - 361s 437ms/step - loss: 0.0041 - val_loss: 0.0107
<keras.callbacks.History at 0x7f9e5a0c2490>

You have an EarlyStopping callback with a patience of 5
tf.keras.callbacks.EarlyStopping(restore_best_weights=True, patience=5)
Remove it if you want to continue training

You have an EarlyStopping callback with a patience of 5
tf.keras.callbacks.EarlyStopping(restore_best_weights=True, patience=5)
Remove it if you want to continue training

True, but I would suggest against removing it. Going for the full 50 epochs when your model stops improving after 10 is a loss of time. Moreover, your model seems to start overfitting after the 9th epoch.


Clicking on one Push Notification on iOS opens multiple ones (FCM)

Steps to Reproduce
Receive multiple push notifications.
User taps to open one notification.
onResume triggers for all notifications received and redirects to a specific page for each one.
Once the user tries to return (back button) from a notification page, instead of going to home page, it goes to the other notification page.
The user has to click on the back button for each notification page to return to the home page.
Is this the expected behavior? I thought that onResume should be triggered only for the notification that the user tapped and not for each notification received. Or is the way I am implementing this wrong?
Logs
[✓] Flutter (Channel stable, v1.0.0, on Mac OS X 10.13.6 17G3025, locale pt-BR)
    • Flutter version 1.0.0 at /Users/isadora_maria/Downloads/flutter
    • Framework revision 5391447fae (3 months ago), 2018-11-29 19:41:26 -0800
    • Engine revision 7375a0f414
    • Dart version 2.1.0 (build 2.1.0-dev.9.4 f9ebf21297)

[✓] Android toolchain - develop for Android devices (Android SDK 28.0.3)
    • Android SDK at /Users/isadora_maria/Library/Android/sdk
    • Android NDK at /Users/isadora_maria/Library/Android/sdk/ndk-bundle
    • Platform android-28, build-tools 28.0.3
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1024-b01)
    • All Android licenses accepted.

[✓] iOS toolchain - develop for iOS devices (Xcode 10.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 10.1, Build version 10B61
    • ios-deploy 1.9.4
    • CocoaPods version 1.5.3

[✓] Android Studio (version 3.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 29.0.1
    • Dart plugin version 173.4700
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1024-b01)

[✓] Connected device (1 available)
    • Isadora • 7388be6c205ef382341a23c03c4a62834feb61ea • ios • iOS 12.1

• No issues found!

@IsaNascimento
The issue at https://github.com/flutter/flutter/issues/28580 has been closed and moved here. Future collaboration on this issue will be done here.

I have the same problem..

Hi @IsaNascimento
(and hello to @kmusham and @kleinpetr as well)
if you arer still experiencing this issue with the latest version of Flutter and firebase_messaging?
please provide your flutter doctor -v?
Also, to better address the issue, would be helpful
if you could post a self contained app on github
or the steps to reproduce it.
Thank you
1060

@iapicca Hey, Yes I am using the newest stable Flutter and No I don't using latest firebase_messaging plugin, because the backgroundMessage callback is absolutely bad and I dont understand why it is changed. In verison 5.1.4 is background message working fine as well.. here https://stackoverflow.com/questions/58394139/flutter-firebase-messaging-onbackgroundmessage-hell

@iapicca Is there some chance to fix it with using version 5.1.4. Thanks

Hi @kleinpetr
I apologize for the delay,
is your experience with backgroundMessage  improved with firebase_messaging: ^5.1.8?
thank you

Without additional information, we are unfortunately not sure how to resolve this issue. We are therefore reluctantly going to close this bug for now. Please don't hesitate to comment on the bug if you have any more information for us; we will reopen it right away!
Thanks for your contribution.
Could everyone who still has this problem please file a new issue with the exact descriptions what happens, logs and the output of 'flutter doctor -v'  please.
All system setups can be slightly different so its always better to open new issues and reference related issues.


docs(math): use list of steps for clearer guidance

Pre-flight checklist

[ ] I have read the Contributing Guidelines on pull requests.
[ ] If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
[ ] If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

Test Plan

Test links

Deploy preview: https://deploy-preview-_____--docusaurus-2.netlify.app/
Related issues/PRs

hmmmmm, why not 👍
https://deploy-preview-9659--docusaurus-2.netlify.app/docs/markdown-features/math-equations/

I'm not against this change but we have to make it pass linting / Prettier
And it doesn't seem to like it so far and seems hard to fix 😅

source does not look super good but at least prettier and rendering are ok now 🤪
If someone want to reformat content why not but it's good enough to merge for now, thanks


loading icon on the bottom when loadMoreAsync works

I want to show loading icon on the bottom when loadMoreAsync works
Is it possible with this?

It should be simple, you can set a flag to true on your state at the beginning of the loadMoreAsync function, and to false when it reaches its end.
In the render function if that flag is true you render the loading icon!
Hopefully, I helped, good luck!

@HugoCerdeiraSkrey what's flag? I've tried to set this.state.isLoading = true but didn't see any loading indicator showed

I'm using following
<ListView    dataSource={this.dataSource}    renderRow={this.renderRow}    renderScrollComponent={props => <InfiniteScrollView {...props} />}    canLoadMore={this.props.canLoadMoreContent}    onLoadMoreAsync={this.loadMoreContentAsync} />
loadMoreContentAsync is invoked, but I don't see any activity indicator. Am I doing something wrong?

@troublediehard I think you're right based on the document. But the problem might be because ListView won't render when your rowData is the same (at the end of the list, number of rows is the same until onLoadMoreAsync finish). That's what i think, i'm not sure about that also.
And my solution for that is:

Modify the InfiniteScrollView class:

class InfiniteScrollViewCustom extends InfiniteScrollView {
    render() {
        let statusIndicator;

        //Here is what i did: Instead of waiting for a status to add statusIndicator to the end of this.props.children I added an Indicator element at the end of the children list.
        statusIndicator = React.cloneElement(
            this.props.renderLoadingIndicator(),
            { key: 'loading-indicator' },
        );

        if (this.state.isDisplayingError) {
            statusIndicator = React.cloneElement(
                this.props.renderLoadingErrorIndicator(
                    { onRetryLoadMore: this._loadMoreAsync }
                ),
                { key: 'loading-error-indicator' },
            );
        }

        let {
            renderScrollComponent,
            ...props,
        } = this.props;
        Object.assign(props, {
            onScroll: this._handleScroll,
            children: [this.props.children, statusIndicator],
        });

        console.log(props);

        return cloneReferencedElement(renderScrollComponent(props), {
            ref: component => { this._scrollComponent = component; },
        });
    }
}

Set renderLoadingIndicator property and use the flag in here:

<ListView
            renderScrollComponent={props => <InfiniteScrollViewCustom renderLoadingIndicator={() => this.state.loading ? <ActivityIndicator style={{ marginTop: 10 }}/> : <View/>} {...props} />}
            dataSource={...}
            renderRow={...}
            canLoadMore={...}
            onLoadMoreAsync={...} />

So that we always have a child at the end of this.props.children and the Indicator will appear when the flag is true.
Here is my first solution, that might be a trick than a solution, but hope that helps somebody.


Power Platform WhoAmI DevOps task failing when we set task version 2 from pipeline.

Power Platform WhoAmI task failing when we set version 2 from pipeline. With Version "0" its working but those versions are deprecated.

failed: Microsoft PowerPlatform CLI Version: 1.19.4+gfbe2fd6 Error: An unknown argument *** was passed. Usage: pac auth create [--name] [--url] [--username] [--password] [--

I have regenerated the App registration secret key and now it's working fine.


can I gobuster dir Client Side rendered websites?

If a website returns 200 from every path, (or 304 if its cached) like react apps with react router standard  configuration, like this one can I brute force it URIs with gobuster?
I guess the only way would be to add a feature to evaluate javascript from 200 responses if needed, or am I missing something?

you can only filter on the returned size but there is no way to interpret the returned javascript. But you can enumerate custom routes on this app.

thanks


a question about issues

hi all, in my spare times i read issues. is there a way to mark an issue to find it later easily ?
if i comment on the issue my name @sturkmen72 i can find it easily. is this way permissible?

If it is an issue you find valuable, commenting with a :+1: is a good idea to show other people that this issue is of certain interest. Posting ":+1: @sturkmen72 " is also ok and suits your needs

If you look to the side panel then you can see there is a subscribe button. Then you can check the overview of all topics you subscibed to.

@StevenPuttemans i have checked watch on top , thus i am subscribed to all issue.

Why would you do that? :D

i thought some conversation has useful information for me to understand source code. i liked to read them


Add iteration model in preparation for removing snapshots

Coverage increased (+0.03%) to 93.811% when pulling 748bdc3fffb4bee34ef1cfefbe7e07847c1a94b6 on iteration_model into b2a5e9b9fea2fa5c6ca42d2b3439eb83d8612588 on master.

Coverage increased (+0.03%) to 93.811% when pulling 1bfa93e5c9b6c377d9d3fb5e3b3c8da5bf9da897 on iteration_model into b2a5e9b9fea2fa5c6ca42d2b3439eb83d8612588 on master.


Separated OSM types, and added code for cleaning up failed tasks

Coverage increased (+1.2%) to 84.023% when pulling 447d9c1107df68348bc380d0aa5ec2b6e5d7dd6f on 13282-RefactorGenericFeatureTask into 221211c578e95eeba8301cd65d65d2d2cefb0677 on master.

This needs some work yet.


Nixify HaLVM

@acw 👋 :)
The nix package manager allows someome to drop into an arbitrary shell w/ prebuilt haskell deps. (optionally profiled) w/ a GHC. It would be nice to add halvm-ghc to this list.
nix-repl> pkgs.haskell.compiler.
pkgs.haskell.compiler.ghc6102Binary  pkgs.haskell.compiler.ghc7103        pkgs.haskell.compiler.ghc784         pkgs.haskell.compiler.ghcjsHEAD
pkgs.haskell.compiler.ghc6104        pkgs.haskell.compiler.ghc722         pkgs.haskell.compiler.ghc801         pkgs.haskell.compiler.jhc
pkgs.haskell.compiler.ghc6123        pkgs.haskell.compiler.ghc742         pkgs.haskell.compiler.ghc802         pkgs.haskell.compiler.uhc
pkgs.haskell.compiler.ghc704         pkgs.haskell.compiler.ghc742Binary   pkgs.haskell.compiler.ghcHEAD
pkgs.haskell.compiler.ghc704Binary   pkgs.haskell.compiler.ghc763         pkgs.haskell.compiler.ghcNokinds
pkgs.haskell.compiler.ghc7102        pkgs.haskell.compiler.ghc783         pkgs.haskell.compiler.ghcjs

So we could just do:
$ nix-shell -p "haskell.packages.ghcHaLVM (pkgs: with pkgs; [ BoundedChan ])"

Modifying this code would be a good starting point.
https://github.com/NixOS/nixpkgs/blob/master/pkgs/development/compilers/ghc/head.nix
I'd like to start working on this, for ease of dev. w/ HaLVM.

Cool. How well NixOS supports Xen?

@izgzhen It's supported afaict, https://github.com/NixOS/nixos/blob/master/modules/virtualisation/xen-dom0.nix
https://nixos.org/wiki/NixOS_and_Xen
But this addition to nixpkgs would be moreso related to using the nix package manager, not necessarily NixOS, and the goal would be to get a working halvm-ghc and HaLVM environment setup fast, with any deps. you need. nix (package manager) just let's you sandbox your entire system, including language deps. system deps. If you use nix on NixOS you can declaratively specify systemd units and reify your configuration with nixos-rebuild --switch.
The nix package manager can run on any OS (best support for linux / darwin). So users should be able to write haskell code on any OS that ghc runs on and cross-compile to Xen using a nix-expression that references halvm-ghc w/ HaLVM.
On the GHCJS project, distribution of the compiler has been a major impediment to adoption. Some people put it on nixpkgs, and it's very simple to get a working environment setup, the only problem is the learning curve with nix. But knowledge of the entire lang. / eco-system isn't necessary if you want a working compiler fast.
Getting ghcjs from scratch
$ curl https://nixos.org/nix/install | sh
# copy . /home/<user>/.nix-profile/etc/profile.d/nix.sh   into your .bashrc
$ nix-shell -p "haskell.packages.ghcjs (pkgs: with pkgs; [ ghcjs-base, aeson ])"
# pulls prebuilt ghcjs from the hydra cache into your /nix/store and symlinks it into the shell below
[nix-shell:~]$  ghcsi --info
# ... etc

Lastly, it seems there is experimental support for generic ghc cross compilers:
https://github.com/NixOS/nixpkgs/blob/master/pkgs/top-level/haskell-packages.nix#L135

I'm on board. Anything you need on the HaLVM side?

@dmjio I'm quite interested in helping with this; in fact my motivation for https://github.com/NixOS/nixpkgs/pull/13131/files was in part hoping someone open just this issue!

https://github.com/NixOS/nixpkgs/pull/23097
cc @acw @izgzhen @Ericson2314

HaLVM-2.4.0 is on nixpkgs/master, closing.


Create literature_review.md

[ ] What is the complete street?- 1-2 pages
[ ] What is the purpose of complete street? Why we need complete street?
[ ] Regulation of Complete Street -State, local, DOT
[ ] How is benefit local economics?
[ ] How is benefit to environmental conservation?
[ ] What is some challenges that needs to overcome?
[ ] Conclusion
[ ] References


typechecker: Added cint type id to negate

Before we couldn't typecast negative constants to c_int.
This fix makes it so now we can do things like -1 as! c_int.
Fixes #465.

Changed the commit message and changed up the test.
if array[0] == -1 as! c_int still feels weird, but atleast its castable now.
Would be cool if we could do just if array[0] == -1 since casting -1 to c_int would never fail.


Implement circle

Hello @Panz99, thanks for this contribution! To merge it, we need some unit tests. Most likely you can find some in the turf js repository

@lukas-h The unit test for the circle function was added

@Panz99  Thank you very much for your contribution. I just merged it. We will publish your contribution in the next minor release.


Adding an example Makefile.lcl

Vikram,
Please resubmit these with the name Makefile.lcl.example or something similar, for all the modules.  Otherwise it will conflict with the actual Makefile.lcl file every time one wants to update the source from the repository.


Made tooltip on TileSet Paint Button give more information when disabled

Fixes #78162
When TileSet becomes read only (such as multiple scenes using it at the same time), the Paint Button becomes disabled. Apparently this behaviour is not properly communicated to users. This PR changes the tooltip of the Paint Button when enabled/disabled to communicate this behaviour better to the user. When enabled the tooltip is the normal "Paint properties.", however now when disabled the tooltip is "TileSet is in read-only mode. Make the resource unique to edit TileSet properties."

Hey, thanks for the contribution!
I think the idea is quite good, and the implementation is acceptable, but it is a bit unusual to define strings as variables like that.  It makes things a bit more difficult to track IMO. I think I would suggest, instead doing it that way, to create some sort of an update_readonly() method, and update buttons/tooltips/etc... there.
That would avoid having to define those strings elsewhere.

Good feedback, I've implemented it by adding a _update_buttons_enabled() function and removing the string variables.

Renamed function _update_buttons() since it just seemed neater.
The function also contains other bits of repeated code, so I think it cleans up the code overall.

Thanks!


Misleading information on ability to embed report to SharePoint

This sentence suggests that user with free Power BI can use described procedure to copy link and embed it into SharePoint for reports in Premium Capacity:
"Users need a Power BI Pro or Premium Per User (PPU) license, unless the report is hosted in a Power BI Premium capacity (EM or P SKU). In that case, users only need a free Power BI license to view reports embedded in Sharepoint Online."
Unfortunately, the free Power BI user does not have this option "Embed Report" in the "File" menu...

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 0fc5abbd-e082-d1e1-109d-6f6cec8854a1
Version Independent ID: f8affce3-98f2-0cc6-b4de-d9af7ced0fbe
Content: Embed a report web part in SharePoint Online - Power BI
Content Source: powerbi-docs/collaborate-share/service-embed-report-spo.md
Service: powerbi
Sub-service: pbi-collaborate-share
GitHub Login: @maggiesMSFT
Microsoft Alias: maggies

Thanks for your comment, @mireQT. This issue has been assigned to the doc author for review.

Hi, @bishalgoswami -- I guess the key word in that sentence is view:
"... users only need a free Power BI license to view reports embedded in Sharepoint Online."
I've reworded it to make it clearer. Change should be live tomorrow afternoon Pacific time.
Thanks!


Tablet server may unnecessarily make zookeeper calls to get the session id.

In the tablet server method getTabletSession() it calls ServiceLock.getSessionId() which makes multiple calls to zookeeper.  Within the tablet server process the session id should be invariant, so going to zookeeper each time adds cost to things in the tserver that call this.
Also its not clear that this is correct.  In the case where tablet server has lost its lock and has not terminated yet when it calls this method it will get the other tserver process session id.
There is a  ServiceLock.getLockID() that calls zooKeeper.getSessionId(). This makes sense to use in the process that acquired the lock, but not outside.  Maybe TabletServer.getTabletSession() could use ServiceLock.getLockID() to get the session id or cache the session id.
Noticed this while working on #3625.  Not completely sure its a problem, opening issue for follow up.

ZooKeeper.getSessionId javadoc:
public long getSessionId()
The session id for this ZooKeeper client instance. The value returned is not valid until the client connects to a server and may change after a re-connect. This method is NOT thread safe
Returns:
current session id

It seems that calling ZooKeeper.getSessionId may give the wrong answer if the ZooKeeper client reconnects to the server.  It might be best to get the SessionId right after creating the ServiceLock and use that for the life of the TabletServer.

Looks like this was closed with #3638