Bug: -verify -paranoid -test does not work with zpaqfranz a store.zpaq 'long_path_windows_dir' -longpath

Hello!
I absolutely love this tool and seeing how you improve it.
Thank you.
I find it a joy to deal with windows longpaths, and I am sure you do too ;).
Here's the issue I've run into.
First, zpaq version.
zpaqfranz v58.7k-JIT-GUI-L,HW BLAKE3,SHA1/2,SFX64 v55.1,(2023-07-24)
Usage: zpaqfranz command archive.zpaq files|directories -switches
       double quote for multipart archive name => "test_???.zpaq"

Here's the command I ran.
PS D:\zpaq> .\zpaqfranz.exe a .\email_in_container_2.zpaq 'I:\desktop-ekf8q7u_2021_04_03_1-18-5-28-17\E\Easeus 06 13_18\3TBGreen001(I)\Lost Files\Existing Partition\EmailArchiverPro' -longpath -paranoid -test -sha3 -verify -summary

It added the files fine (yay!), but the verification code doesn't seem to be able to read long paths?
3TBGreen001(I)/Lost Files/Existing<EMAIL_ADDRESS>Area.Fastmail Download/2017/09/2017-09-08 22.42.18Z  City of Dallas seeks input on proposed park renovations.pdf>>
48699: error kind 3 ERROR_PATH_NOT_FOUND      opening <<I:/desktop-ekf8q7u_2021_04_03_1-18-5-28-17/E/Easeus 06 13_18/3TBGreen001(I)/Lost Files/Existing<EMAIL_ADDRESS>Area.Fastmail Download/2017/09/2017-09-08 22.47.03Z  ALCGENL 133 17 - AY18 ELECTRICIANS MATE ENGINEER PETTY OFFICER (EPO) SCREENING RESULTS.pdf>>
48699: error kind 3 ERROR_PATH_NOT_FOUND      opening <<I:/desktop-ekf8q7u_2021_04_03_1-18-5-28-17/E/Easeus 06 13_18/3TBGreen001(I)/Lost Files/Existing<EMAIL_ADDRESS>Area.Fastmail Download/2017/09/2017-09-08 22.49.52Z  CORRECTION  Port of Seattle Connections, Sept. 8, 2017.pdf>>
--------------------------------------------------------------------------------------------------------------------
OK          SHA-3 : 00119876 of 00237811 (    15.26 GB hash check against file on disk)
WARN        SHA-3 : 00117935 of 00237811 (file not found, cannot check hash)

I had a similar thing happen with 1on1 command.
48699: error kind 3 ERROR_PATH_NOT_FOUND      opening <<I:/desktop-ekf8q7u_2021_04_03_1-18-5-28-17/E/Easeus 06 13_18/3TBGreen001(I)/Lost Files/Existing<EMAIL_ADDRESS>Area.Fastmail Download/2017/09/2017-09-08 22.49.52Z  CORRECTION  Port of Seattle Connections, Sept. 8, 2017.pdf>>

63992: Same hash             992.000.149 (same name too) 000.149
63995: To be deleted           196.885 (same name, same hash)
63996: DRY RUN because no -kill switch entered

I used the 1on1 because I extracted that container, and I wanted to see if there were any files that didn't get added correctly.
I'm currently trying the 1on1 command without the -longpath switch. I'll post results when it completes.

At 99% yes, it is a bug in the -longpath
Where? I really do not know
Please report the output of the attached pre-release
58_8c.zip

Mixed results here.
It looks like it worked for the a command.
PS D:\zpaq> .\zpaqfranz_58_8c.exe a .\email_in_container_testing.zpaq 'F:\Recovered\Local Disk(G)\Deleted Files\EmailProcessing\[EAP''D - 12-2020] GmailEmls\GmailEmls\DownloadArchiveDelete-Dec282019\__MACOSX\Messages\' -longpath -sha3 -summary -test -paranoid -verify
zpaqfranz v58.8c-JIT-GUI-L,HW BLAKE3,SHA1/2,SFX64 v55.1,(2023-07-30)
franz:-summary                                  1
franz:-sha3 -hw -longpath -paranoid -test -verify
38992: INFO: getting Windows' long filenames
59838: Trimmed last /  F:/Recovered/Local Disk(G)/Deleted Files/EmailProcessing/[EAP'D - 12-2020] GmailEmls/GmailEmls/DownloadArchiveDelete-Dec282019/__MACOSX/Messages
Creating ./email_in_container_testing.zpaq at offset 0 + 0
Add 2023-08-05 21:49:48   253.135                  0 (    0.00 B) 16T (0 dirs)
253.135 +added, 0 -removed.

0 + (0 -> 0 -> 5.297.089) = 5.297.089 @ 0.00 B/s
====================================================================================================================
Compare archive content of:./email_in_container_testing.zpaq:
1 versions, 253.135 files, 5.297.089 bytes (5.05 MB)
Scanned          1 00:23:27          0 file/s (                    0)
  253.135 in <<//?/F:/Recovered/Local Disk(G)/Deleted Files/EmailProcessing/[EAP'D - 12-2020] GmailEmls/GmailEmls/DownloadArchiveDelete-Dec282019/__MACOSX/Messages/>>
Total files found: 253.135

Done 99%     0.00 B of     0.00 B, diff 0 bytes so far

00253135 = same
Total different file size: 0 bytes
====================================================================================================================
./email_in_container_testing.zpaq:
1 versions, 253.135 files, 5.297.089 bytes (5.05 MB)

Verify hashes of one version vs filesystem (1 thread, -ssd for multithread)

1421.172 seconds (000:23:41) (all OK)

But 1on1 reported the same error.
I haven't tested the new release yet.

Thanks, but I really need the full output with -debug, to catch the exact position of the file hashing (for a command)
For 1on1 I need an example too


WEBPACK BUNDLE

WEBPACK BUNDLE
Acceptance Criteria
GIVEN a text editor web application
WHEN I run the text editor application from my terminal
THEN I find that my JavaScript files have been bundled using webpack

Files bundled in webpack


[SC-836] fix coverage

Codecov Report
Patch coverage: 92.47% and project coverage change: +5.22 :tada:

Comparison is base (445b8e3) 81.51% compared to head (a667d05) 86.74%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #109      +/-   ##
==========================================
+ Coverage   81.51%   86.74%   +5.22%
==========================================
  Files          23       10      -13
  Lines         606      249     -357
  Branches      142       42     -100
==========================================
- Hits          494      216     -278
+ Misses        112       33      -79

Impacted Files
Coverage Δ

contracts/PowerPod.sol
100.00% <ø> (ø)

contracts/helpers/ResolverMetadata.sol
0.00% <ø> (ø)

contracts/helpers/WhitelistHelper.sol
0.00% <ø> (ø)

contracts/Settlement.sol
91.37% <90.00%> (-8.63%)
:arrow_down:

contracts/libraries/FusionDetails.sol
90.90% <90.90%> (ø)

contracts/FeeBank.sol
100.00% <100.00%> (ø)

contracts/FeeBankCharger.sol
100.00% <100.00%> (ø)

contracts/WhitelistRegistry.sol
97.40% <100.00%> (+0.06%)
:arrow_up:

contracts/libraries/DynamicSuffix.sol
100.00% <100.00%> (ø)

contracts/libraries/TokensAndAmounts.sol
100.00% <100.00%> (ø)

... and 5 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


node-gyp rebuild hangs on MacOS

Node Version: v9.5.0<EMAIL_ADDRESS>Platform: Darwin enether.local 16.7.0 Darwin Kernel Version 16.7.0: Tue Jan 30 11:27:06 PST 2018; root:xnu-3789.73.11~1/RELEASE_X86_64 x86_64
Compiler:

Apple LLVM version 9.0.0 (clang-9<IP_ADDRESS>)
Target: x86_64-apple-darwin16.7.0
Thread model: posix
InstalledDir: /Library/Developer/CommandLineTools/usr/bin

Module: modern-syslog @ 1.1.4 and 1.1.2.

><EMAIL_ADDRESS>install /usr/local/lib/node_modules/modern-syslog
> node-gyp rebuild

This command hangs forever. I tried

re-installing node-gyp
re-installing with --unsafe-perm
running installs with sudo
using<EMAIL_ADDRESS>installing xCode

No, npm install heapdump also hangs
><EMAIL_ADDRESS>install /Users/stanislavkozlovski/Documents/SumUpCode/apigateway/node_modules/heapdump
> node-gyp rebuild

> xcode-select-p
/Library/Developer/CommandLineTools

Did you accept the EULA when you installed Xcode?  I ask because I expected xcode-select -p to point to /Applications/Xcode.app/Contents/Developer.  What happens when you switch to that path with xcode-select -s?

Yes.
Still hangs after switching:
sudo xcode-select -s ~/Applications/Xcode.app/Contents/Developer/
Password:
stanislavkozlovski@Stanislavs-iMac ~ -  $ node-gyp rebuild
gyp info it worked if it ends with ok
gyp info using<EMAIL_ADDRESS>gyp info using<EMAIL_ADDRESS>| darwin | x64

@Enether I ran into this hang today after upgrading to Node 10.0.0, hung on headdump. Backing Node down to 8.11.1 restored the ability to build. I wasn't doing direct builds, rather yarn install with a fairly large load of packages (Appium requires rebuild)

The only thing that helped me was downgrading my node version from 10.0 to v9.11.1 with nvm.

closing due to staleness, I'm assuming that no additional comments means this may be resolved by newer versions of node?

Hello, I'm facing this problem randomly in macOS x64 CI
https://github.com/toeverything/AFFiNE/actions/runs/5676994082/job/15384648202

@himself65 Error: The operation was canceled.
Does not look random to me.

@himself65 Error: The operation was canceled.
Does not look random to me.

I was canceled because it reaches the max time of CI which is 6 hrs


dh parameters

May I have the dh parameters of the arm?
I would like to work on trajectory generation.

what's the dh parameters?

dh parameters is "Denavit-Hartenberg parameters".
For example, we can make original myCobot simulator from scratch by using dh parameters.
I made myCobot simulator.
https://github.com/karaage0703/mycobot_pi
My understanding, myCobot dh parameters is similar to UR5(reference)
myCobot dh parameters which I estimate is below.
https://docs.google.com/presentation/d/17b-rVN2hMOyrtATXlfU7OeVewjkEbSOUjrN6cOPCY6U/
This is Not official information. I want to know official myCobot dh parameters, too.

Maybe you can refer to this. More details need to wait.

dh parameters is "Denavit-Hartenberg parameters".
For example, we can make original myCobot simulator from scratch by using dh parameters.
I made myCobot simulator.
https://github.com/karaage0703/mycobot_pi
My understanding, myCobot dh parameters is similar to UR5(reference)
myCobot dh parameters which I estimate is below.
https://docs.google.com/presentation/d/17b-rVN2hMOyrtATXlfU7OeVewjkEbSOUjrN6cOPCY6U/
This is Not official information. I want to know official myCobot dh parameters, too.

Hi,
Is your DH parameter correct?
The structure of robot in your figure is much different with that of myCobot.
You need to add description how to read your DH parameter.

dh parameters is "Denavit-Hartenberg parameters".
For example, we can make original myCobot simulator from scratch by using dh parameters.
I made myCobot simulator.
https://github.com/karaage0703/mycobot_pi
My understanding, myCobot dh parameters is similar to UR5(reference)
myCobot dh parameters which I estimate is below.
https://docs.google.com/presentation/d/17b-rVN2hMOyrtATXlfU7OeVewjkEbSOUjrN6cOPCY6U/
This is Not official information. I want to know official myCobot dh parameters, too.

Hello.
Let me ask a question on your simulator.
In your code, you define the DH parameter as follows.
`# myCobot DH parameters
[theta, alpha, a, d]
mycobot_sim = NLinkArm([[0., math.pi / 2, 0, 0.13156],
[0., 0., -0.1104, 0.],
[0., 0., -0.096, 0.],
[0., math.pi / 2, 0., 0.06639],
[0., -math.pi / 2, 0., 0.07318],
[0., 0., 0., 0.0436]])
`
I am wondering why you put zeros in theta in DH parameter?
Is there any special technique to update theta by setting up zeros initially?
Thanks.

@kotai2003
Hi, thanks for your comment.
To tell the truth, I'm not familiar with DH parameter.
I made my software according to real robot and basic robotics text.
Please refer to official information. And if you can fix my mistake, please give me Pull Request.
Sorry for I can't answer your question directly.


Create Randoop tests for an arbitrary class

I have used the -c flag before, specifying a text file with the target classes. Using evosuite, the framework was able to generate test cases for the classes. However, using the same text file with randoop, the framework was not able to generate any test cases with a message at the end "Test generator (randoop) did not generate any tests!".
I used the Lang as a test subject, and I wrote in the text file org.apache.commons.lang3.math.Fraction.
Originally posted by @islamelgendy in https://github.com/rjust/defects4j/issues/389#issuecomment-740576802

Instructions for reproducing the issue:

The command is simply
gen_tests.pl -g randoop -p Lang -v 1f -n [id] -o [outputdir] -b 30 -c [dir]/Lang_classes_file.txt.
in the Lang_classes_file.txt I wrote a single line:
org.apache.commons.lang3.math.Fraction
After a few seconds a message "Test generator (randoop) did not generate any tests!" was shown on the console.
Keep in mind that the same command worked with -g evosuite.

Context:
Randoop is not a targeted test generator. It does not resolve dependencies when given a target class. Rather, it uses a bottom-up approach on a set of classes (or all classes in a system) and has a post-hoc filter that filters the pool of generated tests and retains only tests related to a target class.
Problem:
Defects4J currently passes only the set of relevant classes to Randoop. In the above example, neither the target class (Fraction) nor a class that uses it is in the set of relevant classes, and hence Randoop does not produce any tests.
Workaround:
Changing get_relevant_tests to get_all_tests will invoke Randdop on all classes.
@islamelgendy Let me know if this works for you.

Thanks @rjust
I think you meant to change the get_relevant_tests (which is get_relevant_classes) to get_all_classes not get_all_tests.
It does generate now a test suite. However, looking at the generated test cases, they seem to test all kind of classes, not only the targeted one org.apache.commons.lang3.Fraction.
For example, I can see test cases calling methods in org.apache.commons.lang3.time.DateUtils, org.apache.commons.lang3.text.translate.EntityArrays, org.apache.commons.lang3.BooleanUtils, and etc.
It would seem that is not paying any attention to the target class, but it is actually generating test cases for all_classes.

Good catch regarding tests vs. classes -- I fixed the comment.
Yes, Randoop does generate a pool of tests for all classes, but then filters that pool.
I am not entirely sure how Randoop filters the generated tests, when a target class is provided. AFAIK it does use a coverage analysis to identify tests that cover a target class, but I am not sure whether this analysis applies to each test method or the entire test class. The Randoop documentation should provide an answer, though. If it does not, you could submit an issue to the Randoop Github repo. If the coverage analysis applies to an entire test class, you can reduce the number of test methods per test class (see Randoop manual: "--testsperfile=int. Maximum number of tests to write to each JUnit file. [default 500]").
Hope this helps.


Accessing name of enum with a raw value

First of all, this library is awesome! Thanks for all your hard work @Azoy.
Was wondering if there was a way to get the name of an enum case (not the raw value) via this library.
e.g...
enum Country: String {
    case usa = "united_states_of_america"
    case ca = "canada"

    func caseName() -> String {
        // ??
    }
}

print(Country.usa.rawValue) // prints "united_states_of_america"
print(Country.usa.caseName()) // prints "usa"

I believe you can do this by simply:
String(describing: Country.usa)

Ah, yes you're right. I didn't check my example before sending it. The use case here is I want to find the name of potentially custom CodingKey on a type, and it seems like there is a custom description property on CodingKey that interferes with the typical description. In the example above, if you conform Country to CodingKey you end up with...
enum Country: String, CodingKey {
    case usa = "united_states_of_america"
    case ca = "canada"
}

print(Country.usa.rawValue) // prints "united_states_of_america"
print(String(describing: Country.usa)) // prints "Country(stringValue: "united_states_of_america", intValue: nil)"

I see...
My initial reaction is to use something a little complicated in that case then. It might be a little clunky, certainly something that seems worth adding to this library, but here is a little function to get the case name:
func getEnumCaseName<T>(for value: T) -> String? {
  guard let metadata = reflect(T.self) as? EnumMetadata else {
    return nil
  }

  return withUnsafePointer(to: value) {
    let raw = UnsafeRawPointer($0)
    let tag = Int(metadata.enumVwt.getEnumTag(for: raw))
    return metadata.descriptor.fields.records[tag].name
  }
}

enum Country: String, CodingKey {
  case usa = "united_states_of_america"
  case ca = "canada"
}

print(getEnumCaseName(for: Country.usa)) // usa

Wow, works perfectly. Thanks @Azoy !
Out of curiosity I noticed you mentioned you & some others are trying to get this library / pieces of this library added to the swift standard library. Any updates on the direction of that?
I ask because I'm including Echo in some experimental server stuff I've been doing recently & am curious what the future of it might be / how likely it is this would break in future swift versions.

Yes, we're trying to move some of the reflection keypath APIs into the standard library. We're almost ready to release information!
There are some things that I'm planning on namespacing to make it obvious what APIs could break in the future because they're not ABI stable. Right now that includes all the keypath APIs and tuple/existential/function/metatype metadata. It's also worth noting that if you're deploying on a platform with a non-stable ABI, then other metadata structures can be expected to change as well.

Will definitely be looking out for that release. Thanks again for the help!


The Project Server Migration Doc is missing steps

To: MS Project Server Product team,
The office migration docs for both Project Server 2016 and 2019 migrations titled "Upgrading to Project Server" are missing a key step. I opened a case with Microsoft and they asked me to submit the issue here instead of taking action after confirming there is an issue with the documentation and a separate issue with Project Server 2019.
Documentation feedback: The command Migrate-SPProjectDatabase is missing from the articles and is a key step to successfully migrate from Project Server 2013 to Project Server 2016.
Please verify the steps and add the missing information as the steps provided will not complete a migration.
In addition, Project Server 2019 is completely missing the Powershell command Migrate-SPProjectDatabase. This was also confirmed by the Microsoft support team. Because Project Server 2019 is new, there may not have been companies attempting a migration yet.
I hope this helps other customers migrate to Project Server. If you have any questions, please reach out to me.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 05262b2f-6cbc-5cda-fe7a-50e35ed0cc4e
Version Independent ID: 58d80865-5e58-70e5-6993-19d047e34e01
Content: Upgrading to Project Server 2019
Content Source: Project/upgrading-to-project-server-2019.md
Product: project-server-itpro
GitHub Login: @efrene
Microsoft Alias: efrene

As for Project Server 2019, this makes sense. Microsoft requires you to upgrade from 2013 -> 2016 (running the Migrate cmdlet) -> 2019. Since there is nothing to 'migrate' for Project Server as there is from 2013 to 2016, the cmdlet isn't required.

Thanks so much for your interest in the content.   I am following up with this, but I believe that the Migrate-SPProjectDatabase isn't required for migration to Project Server 2019 since the Project Database doesn't exist in Project Server 2016, as I believe it was then a part of the SharePoint Content database.   I also am looking at the "Upgrading to Project Server 2016" article to see if the Migrate-SPProjectDatabase cmdlet isn't present (and I agree, it should be present), but I am seeing it in the content.  I will make sure to verify this again, just to make sure.  Again, thanks so much for taking the time to look at the content and for your interest in it's accuracy.

@SteveZFlorida - I just confirmed with support that my above comment was valid.  If you have a case number, I can follow up with the person you are talking with on the Microsoft Support team.  Just let me know.  Thanks again in your interest in making the content better.
@tseward - Thank you for feedback on this as well.


docs: mention implicitly watched directories in documentation

This partially addresses #13929 by making note of the unexpected behavior in the file_sd_config section of the documentation, indicating that users should not place configuration files in very large directories.

@roidelapluie, when you can take a look.


Save bbox prompts differently

Currently, the prompts are saved in this format:

x0
y0
min_y
min_x
width
heigth

For the (x0, y0) point prompt, this is perfect because that's directly how SAM takes point prompts. However, for the last 4 columns providing the bounding box info, it's not ideal. To be directly compatible and much easier to interface with SAM bbox prompts, this is what the CSV should look like:

x0
y0
min_x
min_y
max_x
max_y

Currently, it's VERY confusing to convert the first arbitrary format into the the bounding box XYXY array that SAM expects (max_x = min_x + width and max_y = min_y + heigth).

Fixed in https://github.com/brainhack-school2023/collin_project/commit/2861eee08ce63412f46123a09bca3d974ac74030


Requesting clarity on generate-templates usage

Go-msi comes with some default templates in the program directory, but it also allows the user to provide a custom "src" template, and a custom "out" template.  It's just not clear to me how the generator uses the source template to generate a new template.  Maybe it's because I've not used wix before.
I thought I would take the wix templates provided, edit them manually, and add the modified versions to my repository (just like one does with wix.json).  It's just confusing to me to use a template generator to generate new templates based on existing templates.  And then do i still have to manually edit the generated templates?  Any additional explanation would help. Thanks!
The help for go-msi is below.
USAGE:
   go-msi generate-templates [command options] [arguments...]

OPTIONS:
   --path value, -p value     Path to the wix manifest file (default: "wix.json")
   --src value, -s value      Directory path to the wix templates files (default: "C:\\Program Files\\go-msi\\templates")
   --out value, -o value      Directory path to the generated wix templates files (default: "C:\\Users\\me\\AppData\\Local\\Temp\\go-msi806034671")
   --version value            The version of your program
   --license value, -l value  Path to the license file

generate-templates sub command is an helper tool to validate the golang templating implementation, nothing more. make sub command will regenerate the template appropriately JIT.
The templates located at https://github.com/mh-cbon/go-msi/tree/master/templates are primarily golang templates
see for example those expressions https://github.com/mh-cbon/go-msi/blob/master/templates/product.wxs#L104
This pre-processing in golang is necessary to inject a ton of information into the wix templates.
The wix templates, once pre-processed, are provided as is to wix tool set. Under the wix universe, the operator/developer/whatever-people would manually write the wix templates, before calling for the wix binaries.
The generate-template helps to test and to reproduce this manual process.
To benefit of go-msi simplicity with some tailor made wix templates, you need to duplicate them, probably into your repo, as you did, they contains the golang template expressions.
You must keep those golang templating expressions and work around them to implement your installer features.
Those expressions are the helpers that reflects the configuration put into the wix.json file.
At worst, if you remove those expressions, it would be the same as removing features of go-msi, or ignoring some parts of the wix.json file you declared.
When generating the msi file with go-msi make, do not forget to pass in your special templates via the --src,-s flag to instruct the program the location of the wix files to consume.
You do not need to keep the same file names (LicenseAgreementDlg_HK.wxs / WixUI_HK.wxs / product.wxs).
They must be in the root directory of the value of --src
$ tree -L 1
.
├── choco
├── LicenseAgreementDlg_HK.wxs
├── product.wxs
└── WixUI_HK.wxs

1 directory, 3 files

It's just confusing to me to use a template generator to generate new templates based on existing templates.

its just confusing anyway.


New bills aren't being logged

I assume it's a verbosity-level problem, since Machine is otherwise logging just fine.

Huh. LOG_VERBOSITY is set to 3, and logging the adding of a new bill is done at level 3, so I don't know what's happening here.


 directories in "Nintendo 3DS"?

I think there are 2 additional  directories built in "Nintendo 3DS" on the way to emuNAND_formatted.
Are they obsolete and may be deleted in the final cleanup or do they have some function?
I want my SD to be as clean as possible. :-)

Once you are completely done, there may be multiple folders in the
"Nintendo 3DS" folder. The largest one will be your SysNAND folder, and the
other ones can be deleted as they are leftover from EmuNAND.
On Sat, Mar 12, 2016, 7:32 AM MZ-4<EMAIL_ADDRESS>wrote:

I think there are 2 additional directories built in "Nintendo 3DS" on the
way to emuNAND_formatted.
Are they obsolete and may be deleted or do they have some function?
I want my SD to be as clean as possible. :-)
—
Reply to this email directly or view it on GitHub
https://github.com/Plailect/Guide/issues/10.


Feature Request: WaveStream from IWaveProvider

I believe getting a WaveStream from IWaveProvider is a common need when working with streaming sources. Mixing and format conversion are only implemented on streams, and the core NAudio currently does not have a convenient way to get one from an IWaveProvider.
Additionally it would help to have IWaveProvider-based implementations for mixing and format changes.

My recommendation is to do format conversion to PCM up front (which most of the file readers life Mp3FileReader, MediaFoundationReader already do), then get to ISampleProvider as soon as possible (there's an extension method that will go from WaveStream or IWaveProvider to ISampleProvider). AudioFileReader does all that in one step. You can then mix using MixingSampleProvider. I prefer this as it means that positioning (which can be a bit of a nightmare itself) can be handled separately based on what exactly you're trying to achieve and what the actual source of incoming audio is.


[$1000] Web - Link has been re-sent text in verify secondary login is not cleared even reload the page

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Login any account
Go to Settings -> Profile -> Contact method
Click "New contact method" button -> Fill in any email that is not Expensify account yet
Click on the secondary email that just added to verify it
Click on Didn't receive a magic code?
Verify that the text "Link has been re-sent" is displaying
Click back arrow in top header
Click on the secondary email that just added

Expected Result:
"Link has been re-sent" should be hide when we start to verify secondary login again
Actual Result:
"Link has been re-sent" is still displaying although we start to verify secondary login again
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[x] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: 1.3.43-3
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/93399543/a8866fbd-b5ef-4879-8b77-c35673cbdb46
https://github.com/Expensify/App/assets/93399543/124fcf53-fe34-4e04-813b-3529e07c860a
Expensify/Expensify Issue URL:
Issue reported by: @hoangzinh
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1689865993497519
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01bcfd004a86329f7b
Upwork Job ID:<PHONE_NUMBER>629244416
Last Price Increase: 2023-07-25

Proposal
Please re-state the problem that we are trying to solve in this issue.
Link has been re-sent text in verify secondary login is not cleared even restart the validate secondary login again
What is the root cause of that problem?
The condition to show the "Link has been re-sent" is from the Onyx key validateCodeSent https://github.com/Expensify/App/blob/be2c81fb1e0b27517451a6d00be097c8d3954ef6/src/pages/settings/Profile/Contacts/ContactMethodDetailsPage.js#L212
Currently, we haven't implemented any logic so that it will reset the key validateCodeSent of validating secondary login when the page ContactMethodDetailsPage is unmounted => the "Link has been re-sent" text is alway displayed
What changes do you think we should make in order to solve the problem?
In the component lifecycle componentWillUnmount of ContactMethodDetailsPage, we need set the Onyx key validateCodeSent of validating secondary login to false so it will hide the text "Link has been re-sent" when we visit the this page again.
Moreover, we can also clear the error when we click in the text link "Didn't received the magic code" as well if we think it's necessary (usually we won't clear the error). Almost same as here

The proposal from @kbecciv looks good to me
🎀 👀 🎀 C+ reviewed

Moreover, we can also clear the error when we click in the text link "Didn't received the magic code" as well if we think it's necessary (usually we won't clear the error)

Sounds good, let's do both

Oh wait, was that actually @hoangzinh proposal? 😄

From what I know, @hoangzinh and @kbecciv is the same person, right?

If you look at the Slack link, I don't think so 😄

Okay, so @hoangzinh was first. Could you assign him?

NP! I have also asked @kbecciv to make this clearer in the future, which has been done here now: https://github.com/Expensify/App/issues/23344#issuecomment-1645384195

Summarizing payouts for this issue:
Bug reporter + Contributor: @hoangzinh $1500 + $250 = $1750 (hired on Upwork)
Contributor+: @ArekChr - from Callstack, no individual payment
Above payment includes efficiency bonus 🎉
Upwork job: https://www.upwork.com/jobs/~01bcfd004a86329f7b

@ArekChr do you mind completing the BugZero checklist so I can close out this issue? Thanks!

[x]: The PR that introduced the bug has been identified. Link to the PR: no PR has been identified.
[x]: The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: no comment.
[x]: A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: no discussion.
[x]: Determine if we should create a regression test for this bug. I think we can have a simple unit test for that.

Regression Test Proposal

Simulate a contact method that hasn't been confirmed.
Navigate to the contact method verification page.
Click the "Didn't receive a magic code?" button with mocked function.
Unmount the component.
Re-mount the component. Validate that the message "Link has been re-sent" doesn't appear.

Before 4 and 5 points, we can add a delay for two scenarios for success and failure cases regarding this comment if that will be introduced.
What are your thoughts? Do we agree 👍 or 👎?

@ArekChr thanks! One question - what does "unmount the component" and "re-mount the component" mean? I want to make sure that the regression steps can be understood equally by technical and non-technical testers (I'm mostly non-technical if you couldn't tell 😄).

Got it, thanks for the explanation!
So would it still be correct if we updated steps 4 and 5 to the following?

Refresh the page.
Validate that the message "Link has been re-sent" doesn't appear.

If we were using the React Native Testing Library, the appropriate step might be to 'remount the component'. However, for e2e tests, I concur with the given steps. I've updated the regression test steps.

Perfect, thanks!


Question on instructions for smaller footprint self-contained app

@blackdwarf @mairaw
In ...
https://github.com/dotnet/docs/blob/master/docs/core/preview3/deploying/index.md#deploying-a-self-contained-deployment-with-a-smaller-footprint
... where it discusses changing ...
<TargetFramework>netcoreapp1.1</TargetFramework>

[Note: My test app is 1.1, so I changed that :point_up: to 1.1 over what's in the doc.]
... to ...
<TargetFramework>netstandard1.6</TargetFramework>

This operation indicates that, instead of using the entire netcoreapp1.0 framework, which includes .NET Core CLR, the .NET Core Library, and a number of other system components, our app uses only the .NET Standard Library.

I published the app both ways ... with the TargetFramework set to netstandard1.6 and with it set to netcoreapp1.1 and there was no difference in size: 45.5 MB (both down from 53.9 MB when using Microsoft.NETCore.App). Both apps run fine, and the published output looks identical.
Can you clarify the difference between using those two target frameworks, since I don't see a difference in app size or runtime behavior? If there is no difference, then why does the instruction say to change the TargetFramework?
Test project: https://github.com/GuardRex/testselfcontained
.NET Command Line Tools (1.0.0-preview3-004056)

Product Information:
 Version:            1.0.0-preview3-004056
 Commit SHA-1 hash:  ccc4968bc3

Runtime Environment:
 OS Name:     Windows
 OS Version:  10.0.14393
 OS Platform: Windows
 RID:         win10-x64

This question is premature: There's still some work being done on this right now (https://github.com/dotnet/sdk/pull/450#issuecomment-269839148). I'll reopen later if needed.

I think the reason you aren't seeing a size difference is because your app is referencing ASP.NET MVC, which probably brings in most everything that you could cut out by switching to the "smaller" footprint method.  Try it on a "Hello World" console app and you should probably see a size difference.

This subject makes more sense to me now. It's been explained to me that currently there is no difference between netstandard* and netcoreapp*. In the future, they may diverge. If they do, then a difference in app size might be seen if the TargetFramework is changed ... maybe.
There is a problem here (or a pair of problems).

This operation indicates that, instead of using the entire netcoreapp1.0 framework, which includes .NET Core CLR, the .NET Core Library, and a number of other system components, our app uses only the .NET Standard Library.

The words "using" and "includes" in the first part of the statement is troublesome: A TargetFramework of netcoreapp* does NOT bring in the runtime and host policy implementation all by itself, so the first part of the statement seems misleading (highly subject to whatever the dev thinks the words "using" and "includes" mean). You have to add add Microsoft.NETCore.Runtime.CoreCLR and Microsoft.NETCore.DotNetHostPolicy manually in package deps (or get the full Microsoft.NETCore.App metapackage) to make it a runnable app either way WRT the TargetFramework.
The other thing is that it really doesn't matter if the TargetFramework is left as netcoreapp* right now. There is an issue that I opened about a double-publish folder bug at https://github.com/dotnet/sdk/issues/569. However, there isn't a difference in the size of the app or in its ability to get runnable output.

/cc @rpetrusha

I think this should go back to closed for now. I'll check again when 2.0 lands. If I can't get the small-footprint self-contained app working, I'll reopen at that time.


Rewriting decimal.js prototype toString method leads to unexpected behaviour

https://github.com/terra-money/terra.js/blob/9e5f553de3ff3e975eaaf91b1f06e45658b1a5e0/src/core/numeric.ts#L18
Replacing in prototype leads to fact, that if you use decimal.js in your app you will receive unexpected response.
e.g.
// const terra = require('@terra-money/terra.js');
const Decimal = require('decimal.js');

const decimal = new Decimal('500000');

console.log(decimal.toString());

If run without terra sdk you will get
500000 in output
But if you will add require for terra sdk you will get
500000.000000000000000000

I guess the best option is to remove prototype modification


Register event handler with Scala fails

I know Scala is not a supported language but it should have compiled compatibility with Java libraries. When registering an event handler with Scala, it seems not to be able to retrieve it at runtime.
Reproducible in:
The Slack SDK version
1.27.0
Java Runtime version
1.8.0_312
OS info
ProductName:    macOS
ProductVersion: 11.6.6
BuildVersion:   20G624
Darwin Kernel Version 20.6.0: Tue Apr 19 21:04:45 PDT 2022; root:xnu-7195.141.29~1/RELEASE_X86_64
Steps to reproduce:
import com.slack.api.app_backend.events.EventHandler
import com.slack.api.bolt.App
import com.slack.api.bolt.context.Context
import com.slack.api.bolt.jetty.SlackAppServer
import com.slack.api.model.block.Blocks.*
import com.slack.api.model.block.composition.BlockCompositions.*
import com.slack.api.model.block.element.BlockElements.*
import com.slack.api.model.event.AppHomeOpenedEvent
import com.slack.api.app_backend.events.payload.AppHomeOpenedPayload
import com.slack.api.model.view.Views.*

@main def hello: Unit =
  println("Starting app!")
  val app = new App()
  val server = new SlackAppServer(app)
  server.start()

  app.event(classOf[AppHomeOpenedEvent], (payload, ctx) => {
    val appHomeView = view(view => view
      .`type`("home")
      .blocks(asBlocks(
          section(section => section.text(markdownText(mt => mt.text("*Welcome to your _App's Home_* :tada:")))),
          divider(),
          section(section => section.text(markdownText(mt => mt.text("This button won't do much for now but you can set up a listener for it using the `actions()` method and passing its unique `action_id`. See an example on <https://slack.dev/java-slack-sdk/guides/interactive-components|slack.dev/java-slack-sdk>.")))),
        actions(actions => actions.elements(asElements(
            button(b => b.text(plainText(pt => pt.text("Click me!"))).value("button1").actionId("button_1"))
        )))
      ))
    )

    val res = ctx.client().viewsPublish(r => r
      .userId(payload.getEvent().getUser())
      .view(appHomeView)
    )

    ctx.ack()
  })

Expected result:
Event responded to.
Actual result:
[qtp122803133-158] WARN com.slack.api.bolt.App - No BoltEventHandler registered for event: app_home_opened
---
[Suggestion] You can handle this type of event with the following listener function:

app.event(AppHomeOpenedEvent.class, (payload, ctx) -> {
  return ctx.ack();
});

Hi @kietay, thanks for asking the question!
The cause of your issue should be where to place your event listeners. The line server.start() blocks the app's current thread, so the following lines of code are not executed. Once you move server.start() to the bottom of the main method, your app should work as you expect.


⚠ UdeS website (prod) has degraded performance

In 4b419fd, UdeS website (prod) (https://www.usherbrooke.ca/) experienced degraded performance:

HTTP code: 200
Response time: 1980 ms

Resolved: UdeS website (prod) performance has improved in 0409369.


Add SeiV2 config migration

Describe your changes and provide context

Adds config migration guide for config.toml and app.toml for seiv2

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 61.68%. Comparing base (954bd21) to head (f7c7d35).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1612      +/-   ##
==========================================
+ Coverage   61.46%   61.68%   +0.22%
==========================================
  Files         365      365
  Lines       26107    26107
==========================================
+ Hits        16047    16105      +58
+ Misses       8994     8935      -59
- Partials     1066     1067       +1

see 3 files with indirect coverage changes


Multiple edges between nodes

Do you have plans to implement multiple edges between nodes?
Right now new edge will overwrite previous.
And this this looks like one edge.
               mesh = new THREE.Mesh(self.cylinderGeometry, material);
Looks like we can bend cylinder

Could you clarify? Do you mean multiple edges connecting the same two nodes, like:

Yes.

I'm probably not going to implement that any time soon - haven't been doing much work on this project. However, it should be easy enough to implement by looping the code. Something like:
deltas = [-0.15, 0.15];
deltas.forEach(function (dy) {
    mesh = new THREE.Mesh(self.cylinderGeometry, material);
    mesh.position.addVectors(n1.position, n2.position).divideScalar(2.0);
    mesh.lookAt(n2.position);
    mesh.translateY(dy);
    mag = n2.position.distanceTo(n1.position);

    if (edge.hasOwnProperty('size')) {
        mesh.scale.set(edge.size, edge.size, mag);
    } else {
        mesh.scale.z = mag;
    }

    // Save array-index references to nodes, mapping from object structure
    mesh.source = map[edge.source.toString()];
    mesh.target = map[edge.target.toString()];
    self.scene.add(mesh);
    self.edges.push(mesh);
});

where this would go where the current edge rendering bit is. It's untested, so it will take some finagling to get running.


The IP version looks too old to compile on Alveo U45N/Alveo SN1022?

Hi zhguanw，
I am trying to put RecoNIC on Alveo U45N/SN1022. But RecoNIC's building tcls are using the older version IP, such as P4 are using v1.0 and ernic are using v3.1. While ernic v3.1cannot work on U45N's part(xcu26-vsva1365-2VL-e). That will causing some  problem.
FYI, I had put Open-nic on U45N, and working good.

Thanks for your reply! I am using vivado 2023.1 before and I changed to vivado 2021.2 now. The problems on IP version are solved. Now the only problem is moving RecoNIC on U45N.
Best regards,
PriceHuang

Hi @PriceHuang,

Now the problem is driver cannot work with the project. After insmod the driver I still cannot find the device by ifconfig.
Can see the error code "onic_pci_probe : onic_enable_cmac () failed with -16"

"onic_enable_cmac() failed with -16" means the CMAC component is not reset properly. Are you using the same version Ubuntu and linux kernel mentioned in the repo? We only tested on Ubuntu 20.04 with linux kernel version 5.4.0-125-generic.
BTW, in your current project, are you using U45N FPGA board, instead of U250?
Best regards,
Guanwen

Hi @PriceHuang,

Now the problem is driver cannot work with the project. After insmod the driver I still cannot find the device by ifconfig.
Can see the error code "onic_pci_probe : onic_enable_cmac () failed with -16"

"onic_enable_cmac() failed with -16" means the CMAC component is not reset properly. Are you using the same version Ubuntu and linux kernel mentioned in the repo? We only tested on Ubuntu 20.04 with linux kernel version 5.4.0-125-generic.
BTW, in your current project, are you using U45N FPGA board, instead of U250?
Best regards, Guanwen
Yes, I do run on Ubuntu-20.04 but linux kernel is 5.15.0-84-generic, and the board I am using is U45N.
I just solve the problem by annotating the code in "onic_main.c" line 1084 to line 1086.
And now I caught a new problem, the test case in rdma_test will fall in QP2 in FATAL problem after I try to test 128K Byte payload in SEND_RECV test.

Best regards,
PriceHuang

Hi @PriceHuang ,
Good to hear that you solved the problem.
>And now I caught a new problem, the test case in rdma_test will fall in QP2 in FATAL problem after I try to test 128K Byte payload in SEND_RECV test.
The issue is caused by "RQE_SIZE" (https://github.com/Xilinx/RecoNIC/blob/main/lib/rdma_api.h#L24), which is 256*256 = 64KB per RQ size. You can simply set it to 512 to bypass the issue. I'll update a version soon to make the rqe_size configurable.
Thanks,
Guanwen

Hi @PriceHuang ,
Good to hear that you solved the problem.
>And now I caught a new problem, the test case in rdma_test will fall in QP2 in FATAL problem after I try to test 128K Byte payload in SEND_RECV test.
The issue is caused by "RQE_SIZE" (https://github.com/Xilinx/RecoNIC/blob/main/lib/rdma_api.h#L24), which is 256*256 = 64KB per RQ size. You can simply set it to 512 to bypass the issue. I'll update a version soon to make the rqe_size configurable.
Thanks, Guanwen

Hi @zhguanw-amd ,
In later time on that night, I just reboot the host to solve the problem.
I found the RecoNIC  driver are running on userspace, maybe the problem is caused by memory overflow? For I cannot meet any "memory free" operation while can meet the "memory allocate"operation.
Thanks,
PriceHuang

Hi @PriceHuang ,
In send_recv.c, there are some buffers that we forgot to free, but it has nothing to do with QP fatal. If you check ./lib/*, you could find those free operations. QP fatal means some registers of ERNIC have wrong values. In your case, you are trying to send payload size more than a RQ buffer can accommodate.
We will update the send_recv example later. BTW, we'll also add hardware optimization gradually. Please keep tuned.
Thanks,
Guanwen


Rework collection of performance tests results

Context
This commit changes the way the coordinator collects performance test results.
Previously, we had a list of test ids, and iterated only once on the list. If
the result of a test wasn't available, then we'd wait one minute, and recheck.
In practice, it means there was no way to have an idea of the global completion,
because the first tests in the list can "block" reporting.
Now, we loop on the full list of tests, check if the result of each test is
available. If so, we collect the result, and if not, requeue until all tests
are completed. We keep the one minute loop between checks. This allows us to
provide better feedback by having a global advancement metric.
Please review carefully the code as I don't think we have any way to test it beforehand...

@melix For next time: Just run a performance test coordinator on your branch to verify that the change works.


Normal-cast not working correctly in Source1

In Reborn, the config engine works beautifully and i have no problems.
That said, in Source1 for some reason the Space-bar normalcast only seems to work for items, but not abilities. I haven't changed anything within the Source1 config in ages so I don't know why it would glitch now. I've tried using the f7 toggle to reset it, as well as reloading the engine entirely but to no avail. It's not a huge issue, as I prefer playing in Reborn anyways but I thought I'd run it by you anyways. Thanks m8.

Do you have everything unbinded in ingame Dota settings?

Can be closed, source 1 has been depreciated.


Language documentation

As discussed in #5 adding the available languages to the docs
So basically the docs say:

specify default language to interpret search string; xx is ISO 639-1 language code, _YY (optional) is 2-letter ISO 3166-1 country code

This is the list of available languages:
Albanian
Arabic
Bengali
Cantonese
Catalan
Croatian
Czech
Danish
Dutch
English
Farsi
Finnish
French
German
Greek
Hebrew
Hindi
Hungarian
Indonesian
Italian
Japanese
Korean
Malay
Norwegian (Bokmal)
Norwegian (Nynorsk)
Polish
Portuguese
Romanian
Russian
Simplified Chinese
Slovak
Spanish
Swedish
Tagalog
Thai
Traditional Chinese
Turkish
Ukrainian
Urdu
Vietnamese

Edit: Ordered list by name
Source: https://tenor.com/gifapi/documentation#localization

@obrunsmann
I also had a look on it, and I had mapped the language codes with their country names in local changes.
A push will be coming up sooner.

Fixed : https://github.com/justkawal/tenor/commit/17b64b729e8aa4923b7a4f756c10dcf09578fd66
It has the Languages also and is available on tenor: 1.0.9


Compressed call instruction c.jal missing implied destination register

The implied destination register x1 is missing from the definition of c.jal
INST16<PHONE_NUMBER>010964 PC<PHONE_NUMBER>010930          000037f1             c.jal       0x0000000000010930
                dst REG_1<PHONE_NUMBER>010966   <=== MISSING

@kathlenemagnus thanks for the quick fix!


[QUESTION] Excel Messed Up / ExcelExport on Nayjest/Grids does not work

Prerequisites

[ ] Able to reproduce the behaviour outside of your code, the problem is isolated to Laravel Excel.
[X] Checked that your issue isn't already filed.
[X] Checked if no PR was submitted that fixes this problem.

Versions

PHP version: 7.2.10
Laravel version: 5.6
Package version: 3.0

Description
Hey guys. I'm using Nayjest/Grids and I can't use the ExcelExport. It's with a depreciated function there, so I'm trying manually. I followed the documentation and it works. But.... it's all messed up. How can I fix this?
Expected behavior:
I want this way:
ID |        Created At |           Updated At |         Initials | Quantity
2 | 2018-06-20 09:45:30 | 2018-06-20 09:45:30 | EN |   | 7
3 | 2018-06-20 09:45:30 | 2018-06-20 09:45:30 | IN |   | 35
In other words, I need a header or an identification.
Actual behavior:
When I download the xlsx, I have this:
2 | 2018-06-20 09:45:30 | 2018-06-20 09:45:30 | EN |   | 7
3 | 2018-06-20 09:45:30 | 2018-06-20 09:45:30 | IN |   | 35
Additional Information
In the Nayjest/Grids I have this code:
protected function renderExcel()
    {
        /** @var Excel $excel */
        $excel = app('excel');
        $excel
            ->create($this->getFileName(), $this->getOnFileCreate())
            ->export(new PesoFuncaoExport, 'peso_funcao.xls');

    }

So, this code does not work because the method create is depreciated. When I try to use the other methods, I cannot download the file, I click on the button, the page is refreshed but I can't download.
I'm using this code
 protected function renderExcel()
    {
        /** @var Excel $excel */
        $excel = app('excel');
        $excel->download(new PesoFuncaoExport, 'peso_funcao.xlsx' );
            // ->create($this->getFileName(), $this->getOnFileCreate())
            // ->export(new PesoFuncaoExport, 'peso_funcao.xls');

    }

Anyone can Help?

Another question:
  public function collection()
    {
        return Invoice::all();
    }

This will give me all records of my Model, right? I'm asking because I'm getting records that I don't need. How can I ignore these?

And Can I change the order of the records?
Showing Like This
ID | Created At | Updated At | Initials | Quantity
2 | 2018-06-20 09:45:30 | 2018-06-20 09:45:30 | EN |   | 7
3 | 2018-06-20 09:45:30 | 2018-06-20 09:45:30 | IN |   | 35
Changing quantity to be after ID, for example
ID |  Quantity | Created At    | Updated At | Initials
2 |          7 |       2018-06-20  | 09:45:30 | 2018-06-20 09:45:30 | EN
3 |  35 | 2018-06-20 09:45:30 | 2018-06-20 09:45:30 | IN

Hi @RafaelRodriguesFraga,
I haven't tested it myself (yet), but most likely this article will help you suit your needs:
Mapping data

You indeed need the WithMapping concern.

Hey guys, it worked, I tried with FromQuery and worked better than with FromCollection.
I just have a final question (I guess haha): Can I join tables with FromQuery? I have a Updated_By column that returns 2, 3, 1, depending on the ID of who updated. I wanted to join users to get the name instead ID. I did that, but didn't show nothing. Neither ID or Name.

Thanks guys. It worked. I tried the FromQuery Interface and works perfectly for me. Betten than FromCollection.
Thanks a bunch for the help


hijack KernelCallBack table

reference/example: https://github.com/ORCA666/KCTHIJACK

dear mentors , I came across this issue and I would like to work on it. i would appreciate your guidance as I work on this issue. Let me know if you have any suggestions or guidance on how I can get started. can you assign me with more details.

this issue is about adding a rule to detect the technique referenced in the linked github/gitlab project to hijack the KernelCallback table. if you're not sure what this means, then i think its reasonable to either 1) look at other PRs that add rules to learn how to do this, or 2) find another issue that is more aligned with your skills and experiences. please also review the documentation and examples of capa so you're familiar with the terms and technologies. we're happy to help with specific questions, especially when you can share what you've already tried.


allow @barthru on staffGrp

Currently, MEI Basic disallows @barthrue on staffGrp. That should be available.

Pinging @lpugin

@musicEnfanthen the attribute is nowadays called @bar.thru and is allowed in MEI Basic through att.staffGrp.vis.


Peer to Peer Code Review 23/05/2023

Hey @lordksix, Really great work done so far!

Great use of modules
Code is very clean and Reusable
Code is DRY and uses KISS, YAGNI Principles 👍

Keep up the good work

@sunga12 Thank you! Happy coding


feat(fromOpenApi): support standard string formats

Supports the following standard OAS string formats:

date
binary
byte

Released: v0.1.0 🎉
This has been released in v0.1.0!

📄 Release notes
📦 npm package

Make sure to always update to the latest version (npm i @mswjs/source@latest) to get the newest features and bug fixes.

Predictable release automation by @ossjs/release.


feat/example: non editable comments plugin

simple javascript plugin for comments integration

r? @krishnaIndia
(maidsafe_highfive has picked a reviewer for you, use r? to override)


branch-2.0 fix insert into core when expression num do not match slot num

Proposed changes
Issue Number: close #xxx

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall


Add extra settings variable.

I suggest this enhancement with gitlab_extra_settings in order to avoid a very long list of parameters. This would be more flexible.

LGTM

:+1:

Any news?

What can I do to see this enhancement merged?

Not stale, just still waiting for maintainer review.
@geerlingguy I'm a GitLab employee, I would be happy to help maintain this role.

Since this change allows people to drop in pretty much any other extra settings they'd want, I like it. The structure is a little annoying (compared to simpler key-values) and I'd probably prefer maintaining my own gitlab config file template instead of having a lot of extra settings. But for the one or two small tweaks, this works out okay.


Add dynamic git remotes support

Support to specify more git remotes, easily.

Add additional remotes in ~/.cstar_perf/git_remotes.json

{
"alan": "git://github.com/aboudreault/cassandra.git",
...
}

All remote added in git_remotes.json are automatically added and updated.
If a remote is deleted from the git_remotes.json file, it is automatically removed from the repository remotes.

//cc @EnigmaCurry

Awesome!
+1


should it be this right ?

https://github.com/trekhleb/javascript-algorithms/blob/ba2d8dc4a8e27659c1420fe52390cb7981df4a94/src/data-structures/tree/BinaryTreeNode.js#L133

this should always exist. Since there is no restriction on parameters in JS, if node is undefined/null, setRight(node) is the same as removing the right child. If this line is omitted, this.right.parent = this; has a possibility of calling null.parent which would throw an error.

Ok- - - #ay```
```_**@[]()**_```


Resou_rce in architecture diagram.

[Enter feedback here]
Architecture diagram splits term "Resou rce" in three places.
-- Joe

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 900b3b20-5693-1beb-0b4b-161548a7d14f
Version Independent ID: 94d5daef-6e7b-23d2-58bd-b2796bbbc7e1
Content: Dev-Test deployment for testing PaaS solutions - Azure Solution Ideas
Content Source: docs/solution-ideas/articles/dev-test-paas.md
Service: architecture-center
Sub-service: solution-idea
GitHub Login: @adamboeglin
Microsoft Alias: pnp

Thanks for reporting - this issue is under review.  This is a Microsoft Internal DevOps Bug ID AB#190807

@groundh0g Can you elaborate more with the screen shot for which section of the document your feedback is applicable.

@groundh0g Just following up again in case missed the previous communication.

@groundh0g Since we have not heard back from you we will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion and we will reopen the issue.

@groundh0g Since we have not heard back from you we will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion and we will reopen the issue.


(WIP) -(not ready) Not allow, Footer collection venue opening times names dynamic.

Not allow, Footer collection venue opening times names dynamic.
Fix the whats-on page (etc), names not dynamic

OpeningTimesStatic
(VisitUsStaticContent)

@ishouty You can use draft PRs if a PR is WIP.


Exclude vim swap-files from group_vars rsync

At least I seem to leave those vim's to background ;-/

Oh yes, that's a good one. I'll merge it as soon as it passes travis check. Thanks!


Deleted challenge still appears in projects view

I recently deleted https://maproulette.org/mr3/admin/project/8/challenge/3375 but it still appears in my project view. When I click on it I get a message that the challenge does not exist.

I believe this has been fixed. Please reopen if you experience it again.


fastlane match nuke appstore does not work

New Issue Checklist

[x] Updated fastlane to the latest version
[x] I have read the Contribution Guidelines

Issue Description
Running fastlane match nuke appstore results in an error.
Complete output when running fastlane, including the stack trace and command used
Machine:app user$ fastlane match nuke appstore

[!] Please run `match nuke [type], allowed values: distribution and development. For the 'adhoc' type, please use 'distribution' instead.

Environment
✅ fastlane environment ✅
Stack

Key
Value

OS
10.12.2

Ruby
2.2.4

Bundler?
false

Git
git version 2.10.1 (Apple Git-78)

Installation Source
~/.fastlane/bin/bundle/bin/fastlane

Host
Mac OS X 10.12.2 (16C67)

Ruby Lib Dir
~/.fastlane/bin/bundle/lib

OpenSSL Version
OpenSSL 1.0.2g  1 Mar 2016

Is contained
true

Xcode Path
/Applications/Xcode.app/Contents/Developer/

Xcode Version
8.2.1

System Locale

Variable
Value

LANG
en_US.UTF-8
✅

LC_ALL
en_US.UTF-8
✅

LANGUAGE
en_US.UTF-8
✅

fastlane files:
No Fastfile found
No Appfile found
fastlane gems

Gem
Version
Update-Status

fastlane
2.9.0
✅ Up-To-Date

Loaded fastlane plugins:
No plugins Loaded
Loaded gems

Gem
Version

CFPropertyList
2.3.4

activesupport
<IP_ADDRESS>

addressable
2.5.0

babosa
1.0.2

bigdecimal
1.2.6

bundler
1.13.7

claide
1.0.1

colored
1.2

commander
4.4.3

domain_name
0.5.20161129

dotenv
2.1.1

excon
0.54.0

faraday
0.10.1

faraday-cookie_jar
0.0.6

faraday_middleware
0.10.1

fastimage
2.0.1

gh_inspector
1.0.2

google-api-client
0.9.20

googleauth
0.5.1

highline
1.7.8

http-cookie
1.0.3

httpclient
2.8.3

hurley
0.2

i18n
0.7.0

io-console
0.4.3

json
1.8.1

jwt
1.5.6

libxml-ruby
2.9.0

little-plugger
1.1.4

logging
2.1.0

memoist
0.15.0

mime-types
3.1

mime-types-data
3.2016.0521

mini_magick
4.5.1

minitest
5.4.3

multi_json
1.12.1

multi_xml
0.6.0

multipart-post
2.0.0

nanaimo
0.2.3

nokogiri
1.5.6

os
0.9.6

plist
3.2.0

power_assert
0.2.2

psych
2.0.8

public_suffix
2.0.5

rake
10.4.2

rdoc
4.2.0

representable
2.3.0

retriable
2.1.0

rouge
1.11.1

rubygems-update
2.5.2

rubyzip
1.2.0

security
0.1.3

signet
0.7.3

slack-notifier
1.5.1

sqlite3
1.3.13

terminal-notifier
1.7.1

terminal-table
1.7.3

test-unit
3.0.8

thread_safe
0.3.5

tzinfo
1.2.2

uber
0.0.15

unf
0.1.4

unf_ext
<IP_ADDRESS>

unicode-display_width
1.1.2

word_wrap
1.0.0

xcodeproj
1.4.2

xcpretty
0.2.4

xcpretty-travis-formatter
0.0.4

generated on: 2017-01-20

Can you try fastlane match nuke distribute, which will nuke both ad hoc and app store profiles

Hi @KrauseFx, running that results in this message (in red):
[!] Please run `match nuke [type], allowed values: distribution and development. For the 'adhoc' type, please use 'distribution' instead.

Followed the advice on that prompt and got it to work.  I am assuming there is a known issue with running fastlane match nuke appstore that simply hasn't been documented...

Sorry, spelling mistake on my side, you can use fastlane match nuke distribution, as the error message indicates 👍


Is it possible to add icons into the legend?

Hi I was wondering if it is possible to add Icons into the legend? I tried to do that but my HTML skills are very poor.
Regards

Answered on forum here - https://discourse.nodered.org/t/node-red-contrib-worldmap-using-html-icon-in-legend/83167/3?u=dceejay


v0.12 is not compatible with v0.13

Got this error when testing qhub on DO with Terraform v0.13.3
qhub/test_rendering/terraform-state$ terraform init
Initializing modules...

Initializing the backend...

Initializing provider plugins...
- Finding latest version of hashicorp/digitalocean...

Error: Failed to install providers

Could not find required providers, but found possible alternatives:

  hashicorp/digitalocean -> digitalocean/digitalocean

If these suggestions look correct, upgrade your configuration with the
following command:
    terraform 0.13upgrade .terraform/modules/terraform-state/modules/digitalocean/spaces

Opened this PR to resolve: https://github.com/Quansight/qhub-terraform-modules/pull/23

Closing as there was PR to address this issue.

Closing as there was PR to address this issue.


react-app-rewire-mobx does not work with latest babel 7.x

react-app-rewire-mobx pluging is not working with the latest react-app-rewired.
I need to use the below code in config-overrides to make it work.
module.exports = function override(config, env) {
    config = injectBabelPlugin( [
        "@babel/plugin-proposal-decorators",
        {
            "legacy": true
        }
    ],config);

    return config;
  };

See notes on the homepage.
Not supporting 2.0 directly.  Also see https://github.com/arackaf/customize-cra

Hi! I have this problem and do you change package.jason or create tsconfig.json?


[Bug]: Import the sql file, if the primary key is repeated, the error log is not printed in full

ODC version
ODC420
OB version
any environment
What happened?
Import the sql file, if the primary key is repeated, the error log is not printed in full
What did you expect to happen?
Checking the logs shows duplicate primary key errors
How can we reproduce it (as minimally and precisely as possible)?

Create a primary key index table and insert a piece of data

Import sql format file

View logs
It is found that the import is successful, but the log does not have a primary key duplicate error

View logs
It is found that the import is successful, but the log does not have a primary key duplicate error

ob-loader

Anything else we need to know?
No response
Cloud
No response

The error printed here is only Java's printing of exceptions. In fact, based on the log of ob loader, this error will not be printed, which is the same as ODC.
Won't fix this.


change notification event UUID

Change notification event UUID to not override BLE GATT specification. Discussion in https://github.com/JF002/Pinetime/pull/140 and is compatible with these drafted changes to Infinitime: https://github.com/JF002/Pinetime/pull/161

Thank you very much for the pull request, sorry about the slow response.

Thank you very much for the pull request, sorry about the slow response.

Hi! There is still discussions about the UUID's of custom services on InfiniTime being done inhttps://github.com/JF002/Pinetime/pull/163. So this call UUID probably need to change one more time, when the devs has decided.

Hi! There is still discussions about the UUID's of custom services on InfiniTime being done inhttps://github.com/JF002/Pinetime/pull/163. So this call UUID probably need to change one more time, when the devs has decided.


How to make full size

Hello,
how can I make map appear at 100% width/height. I need make it full window size (like Google Maps).
At the moment, I define arbitrary name to the directive and then use a script that modifies style width/height in window.onresize event. The bad thing about that seems like part of map is not loading properly. Also I have to use non-angular JS to achieve that.

Hi everyone, I have problem on setting height to 100% inside the tab (angular ui bootstrap).
 <uib-tabset active="active">                 <uib-tab index="0" heading="Map">

                 </uib-tab>                 <uib-tab index="1" heading="Sample">                     Sample                 </uib-tab>             </uib-tabset>
and this is my template

             <leaflet width="100%" height="100%"></leaflet>

Luckily, i was able to make it, here's my fixed.
`

`

Thanks @rhalf your solution works like a charm. !

Thanks @rhalf.
I use something like:

So my solution is a bit different - but I stick content above the map - so I really want my map to be "the rest of the page".  If there's no content above it, then it's 100% of the page size.  Though it's more complicated than the 100% all the time solution, it works pretty well. In this case I assume that the ID of the leaflet tag is "gismap".
/**
* We want the leaflet map to be 100% of the page size, so we
* have this nifty function to resize it.  However, in some cases
* the user might resize the window - and we want the map to resize as
* well.  This handles that by auto-updating the style.
/
var updateWindowHeight=function () {
// Get the top of the GISmap div - we'll make that where the map
// starts, since that'll ensure that it uses the entire div.
var el=angular.element(document.querySelector('#gismap'));
// Get the absolute position of the top of the element.
var top_padding=el[0].getBoundingClientRect().top;
// Get the height of the window.
ctrl.doc_height=$window.innerHeight ;
// Subtract that top padding - since other content is there.
ctrl.map_height=ctrl.doc_height-top_padding;
// Set the height of the map to be the remainder of the page.
// we need to have a height, otherwise it'll assume 0 height,
// which means no map.
ctrl.mapStyle={'height': ctrl.map_height + 'px'};
// Tell leaflet that it needs to reset the mapsize since
// a window resize event or something similar happened.
leafletData.getMap('gismap').then(function(map) {
$timeout(function() {
map.invalidateSize();
}, 300);
});
}
/*
* Window resize event handling - this ensures we properly adjust the
* leaflet map size whenever someone resizes the window.  Essentially
* making it always take up 100% of the map.
*/
angular.element($window).bind('resize', function () {
updateWindowHeight();
});


How far behind the googletest repo is this project?

Would be possible to include the google test repo into this as a submodule that can be updated fairly easily?

Yes, it would indeed be something nice!
Actually, I'm using gmock 1.7.0, which was released in september 2013.
Seems like a dinosaur, but the latest version, released in august 2016, is "only" 1.8.0.
So I'll just try with that new version, and see if everything is still compatible...
I'll leave this issue open in the meantime.
Thanks for the suggestion : )

All right, latest version now includes the latest googletest release, aka 1.8.0.
Binaries are still included, as this is more convenient.
But the supplied makefile automatically downloads googletest from GitHub, so it's now very easy to update (just change the version number in the makefile).

Tell me if I can close the issue : )

Thanks for this! 👍


Add version to package.json

Both npm install and yarn add need the package.json to contain a version so that this package can be added using commands like npm i https://github.com/wolfgang42/rockstar-js.
I understand that you might not want to publish this on npm. I am fine using the longer command to add this package in node_modules but that fails as well because version is required. This is the error I see:
~/w/rockstar  yarn add https://github.com/wolfgang42/rockstar-js                                                                                yarn add v1.7.0
info No lockfile found.
[1/4] 🔍  Resolving packages...
error Can't add "rockstar-js": invalid package version undefined.
info Visit https://yarnpkg.com/en/docs/cli/add for documentation about this command.

There is a similar error for npm install as well.
This PR adds the version key to package.json so that the above commands can work.

Seems pretty inconsequential and I can definitely understand people wanting to install rockstar-js via npm (similarly to installing typescript). wolfgang can shout at me if he disagrees :P

Not going to shout. Thanks @gunnerwolf!


FALCON-1932 Extension CLI should support common options

Tested CLI command with common options.

+1

@sowmyaramesh To follow up with our talk, our current CLI framework doesn't check whether an option is used in a command or not, i.e. they are all optional. In other words, whether I add an option or not doesn't change your extension repository results, if you don't use these options. For example, "bin/falcon extension -enumerate -url http://localhost:15000 -d -ddd " gives the same result as "bin/falcon extension -enumerate -url http://localhost:15000".
This resembles with REST api design, i.e. it won't throw error if user pass an unrecognized parameter. Hope this resolves your concern.
If you want to be able to throw error for unsupported options, you need to change our CLI framework.

@yzheng-hortonworks : There are two ways of handling it.
1> Instead of adding by default to Extension CLI it can be added only to commands which honor it. That way by default if unsupported option is passed it will throw exception. This is how it is handled today in the code
2> Other way is to handle in specific commands
As your code is in accordance with the current design I will give a ship ti. We can revisit this if required in the future. Thanks!

+1

Thanks @sowmyaramesh . Yes, and this would be a lot of work, since every CLI command only validates required parameters but not unsupported ones. We need to change every CLI command to make it happen.


Add a configuration parameter to specify the default query limit

I've recognized that only the first 10 elements are returned when querying all elements from a repository. This was also reported in this StackOverflow thread.
This PR attempts to fix this behaviour by providing a configuration option for this value. The default value is 10 to prevent a breaking change. Users may set it to Integer.MAX_VALUE to retrieve all elements from a repository.

Nice!

@zUniQueX thanks for the PR. We are debating internally whether to do it this way or to use https://redis.io/commands/ft.config-set/ using the MAXSEARCHRESULTS property. I will let you know but either way, having a config file the Spring-way is a good idea.

Thanks for the fast reply!

We are debating internally whether to do it this way or to use https://redis.io/commands/ft.config-set/ using the MAXSEARCHRESULTS property.

Don't we need to do both? IIRC the default value of MAXSEARCHRESULTS is 10000, so aren't this different configuration values?

Thanks for the fast reply!

We are debating internally whether to do it this way or to use https://redis.io/commands/ft.config-set/ using the MAXSEARCHRESULTS property.

Don't we need to do both? IIRC the default value of MAXSEARCHRESULTS is 10000, so aren't this different configuration values?

Indeed, I got confused with global max vs the individual query max - I very much dislike the 10 preset, in the EntityStreams I hardcoded a min default of 10000. I'm thinking we can use this as the default here too, unless it is overwritten by the configuration. Thoughts?

@bsbodden I've revised the PR and adapted your requested changes. See what you think about it.

@bsbodden Thanks for the fast integration! Is there any chance to get this released on the 2.7 branch, if we'd backport this?

@bsbodden Thanks for the fast integration! Is there any chance to get this released on the 2.7 branch, if we'd backport this?

Sure, I will cherry pick and apply new commits that will work on the 2.7 branch, then I'll push a snapshot. Will likely do a release on that branch after closing a few more issues.


Events col on the cloud.taipy

Hi,
First of all, great work!
Looks like Events column on the cloud.taipy.io contains redundant info at this moment.
Repro steps:

Go to https://www.taipy.io/ and scroll down to see Events
Go to https://cloud.taipy.io/ and scroll down to see Events
Compare

Screenshots:
Looks fine ✔ from step 1:

Looks bad ❌ from step 2:

Additional information:
What is the purpose to show (referring to the step 2) there links to 404 Error or Logout (when user is not logged in)?
It could be more transparent.
Best wishes,

Thank you for your feedback! We are taking care of it as soon as possible.

Thank you for your message, sounds great! ✨

Done!


Filter to only UTXOs for TransactionOutput query

Although it's not clear from the query, this endpoint actually just gets you all outputs and doesn't check if they are spent or not. Probably filtering based on whether or not it is spent should be added as a feature and the behavior explicitly documented.

Replaced by #79 since I think these need to be separate endpoints


Added setup callback

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 83.81%. Comparing base (ae4dd31) to head (49ab72d).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #82      +/-   ##
==========================================
+ Coverage   83.80%   83.81%   +0.01%
==========================================
  Files          91       91
  Lines        2988     2991       +3
  Branches      457      458       +1
==========================================
+ Hits         2504     2507       +3
  Misses        318      318
  Partials      166      166

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Coveralls needs to be advisory only

At some point coveralls was added in a ratchet configuration which means coverage is only ever allowed to improve, or merges are blocked.  There also appears to be issues where the following situation occurs:

commit some code, coverage goes down
commit some coverage, coverage goes up
squash and merge, coverage goes down, master is "red".  That's the state of<PHONE_NUMBER>7cf82aac5c7e1b0501a8967af45fb4 (Current master as of raising this issue)

I'm not certain if this is the actual sequence of events, but it looks like it might be based on recent commits.
Coveralls should be changed to be advisory only.

I don't know how coveralls was enabled for this repo, but I disabled it now:

Thanks @thombergs !


patch: update logo file

Change-type: patch
Signed-off-by: Alan Boris<EMAIL_ADDRESS>

@balena-ci I self-certify!


Messages as byte arrays

To allow partial and full messages in a single struct.
Messages can be created with no bytes, we could change that, but it would require more code.

I explored your idea @fcanas, please look if it makes sense to you.


Fixed minor bug with formatting log message

Also, go vet can help to find typos like this.

@andyone Please submit changes inside src/margo.sh/ upstream https://github.com/KurokuLabs/margo
I will fix this one along with adding the go list support for earlier versions of Go.

Done

@logrusorgru Cool! Didn't know about this feature.
But I'm not sure how to use it. For example, the command from your example doesn't work:
› margo.sh git:(master) grep 'mx.Log.Printf' golang/margocode.go
                mx.Log.Printf("cannot load the list of stdlib packages", err)

› margo.sh git:(master) go vet -printfuncs=Print,Printf,Println,Fprint,Fprintf,Fprintln,Sprint,Sprintf,Sprintln,Error,Errorf,Fatal,Fatalf,Panic,Panicf,Panicln && echo $?
0

@andyone , may be
go vet -blah=blah ./...

For recursive vet

@logrusorgru Yeah, you are right. Thanks for the explanation.


chore: Switch to OpenTofu

This PR attempts to migrate references to terraform to opentofu. References to terraform remain:

in links to docs that don't currently have an obvious analogue
in ADRs which should be immutable
some variable names that may be better to migrate more carefully

I agreed with the comment on the ticket that it seems to just-work fine now.
Bug: T348311

Are there any breaking changes in this that hard require using tofu?
I'm wondering if we should soft start by falling back to a terraform executable if tofu is not found, or if this a bad incentive for not installing tofu in the first place?

IMHO this is a bad incentive for not properly moving and in the event we start to find there is a tiny drift will just add confusion. At the very least I see this as potentially causing fighting over the changes in tf/env/production/.terraform.lock.hcl and friends

Ok, then let's not do it. I agree with your concerns. Fine with merging this as is whenever we feel ready.


Metrics: remove-when-sleeping not working

The metrics code is messed up; "remove-when-sleeping" does not display at all due to coding oversight.

Fixed a while ago


AWSTransfer Download to std::stringstream instead of file

I am having problems with the AwsTransfer library, particularly on the "DownloadFile" function. Ideally, I do not want to write to a file and then have to read the contents back into memory. Your integration tests here: https://github.com/aws/aws-sdk-cpp/blob/master/aws-cpp-sdk-transfer-tests/TransferTests.cpp#L194-L235 check the uploaded file by downloading to an FStream. I am able to successfully do this; however, I have not been able to successfully implement the this to an std::stringstream. For small transfers (less than 20MB) I don't seem to have problems, but when I increase the size to 21MB, I no longer get the entire file. Here is my attempt:

std::shared_ptr<std::stringstream> AwsTransfer::SyncDownload(const std::string& bucket, const std::string& key) {
    std::shared_ptr<std::stringstream> contents = std::make_shared<std::stringstream>();
    std::shared_ptr<TransferHandle> request = m_transfer->DownloadFile(bucket, key, [&contents]() {
        std::iostream* out = Aws::New<std::iostream>(allocationTag, contents->rdbuf());
        return out;
    });

    request->WaitUntilFinished();

    return contents;
}

Do I need to preallocate the size of the stringstream before passing?

does the file contain text only or also binary data? If binary data you need to tell stringstream to not pay attention to null characters. Have you tried with std::stringstream::binary?

@JonathanHenson Thanks for the reply. I am almost always pulling down binary data (images etc), I'll give binary a try and see if that resolves the issue.

@JonathanHenson Just revisited the code and it looks like the test file we are sending and then downloading doesn't contain null characters and we still having the issue. The file  contains "0123456789".... repeated over and over to meet the desired upload and download test size. Like I mentioned in the original post, we don't notice any problems with the tests until we get about ~20MB. I verified that the AWSTransfer upload works great by pulling the image down with the AWS CLI. But when trying to use the AWSTransfer download function, I don't get the entire file size. I'll go ahead and make the change with the binary safety as well.

If I'm not mistaken the ~20MB is being downloaded in one thread and therefore is written to your stream from its very begging. I observed that for bigger files there is good chance of writing to the stream in just about random sequence (as the parts come).
In TransferHandle.cpp:358, there is:
            partStream->seekg(0);
            m_downloadStream->seekp(writeOffset);
            (*m_downloadStream) << partStream->rdbuf();
            m_downloadStream->flush();

Tell me if I'm wrong here, but no standard in-memory-stream is able to seek beyond already written memory. I mean it's ok to seek through the stream when it's full of data. You can't seek past it in attempt to write data further. That is OK for files though.

An example could be found here
https://github.com/awsdocs/aws-doc-sdk-examples/pull/885


systemd unit file documentation

I'm installing the template<EMAIL_ADDRESS>from the distribution, in order to bring up the system on CoreOS. The docs are a little bit thin; what I'd like to propose is a discussion here, which I'd summarize with a PR for docs/systemd.md that would summarize the instructions and perhaps suggest a best way to deal with that kind of setup, in several ways simple and complex.
To be fair the systemd docs on the use of the @ in a filename to create a variable are also kind of thin.

Yes, definitely much needed.  As you've stumbled across some docs from a long time ago.  On the bright side, Ubuntu and Debian have stabilized on systemd so the old upstart init script can probably also be removed.
Few comments while I think aloud:

The IPv6 stuff in the current template is a mess because IPv6 in Docker is a mess, inclined to leave it there because it at least works, but I find it distracting.
The ExecStartPre=-/usr/bin/docker pull $IMG step will pull updates to the image before running.  I think this is handy to resolve security issues as images are pushed , but others may not expect their system to pull new images at init time.  Thoughts?

Big fan of safe defaults here. If people don't want sudden updates to images they shouldn't be running latest anyway.

Is docker pull a safe step if hub.docker.com is down, or network connections are wonky? We had some github down time today so I'm sensitive to overly reliable systems working a little too well so that they fail rarely and spectacularly.
Actually, hub.docker.com has had some issues of late so this is not an idly curious question.

Is docker pull a safe step if hub.docker.com is down, or network connections are wonky?

It's setup so that if the docker pull fails, the rest will run anyways:
From systemd.service(5):

If the absolute filename is prefixed with "-", an exit code of the command normally considered a failure (i.e. non-zero exit status or abnormal exit due to signal) is ignored and considered success.

If any of those commands (not prefixed with "-") fail, the rest are not executed and the unit is considered failed.
ExecStart= commands are only run after all ExecStartPre= commands that were not prefixed with a "-" exit successfully.

I was just about to link the docs :) https://www.freedesktop.org/software/systemd/man/systemd.service.html

Please continue discussion at #204


out-of-bounds sequence access when iterating over the result of set_symmetric_difference with a range for.

Getting an out-of-bounds sequence access error when trying to iterate on the result of a set_symmetric_difference.
I'm using trunk.
#include "flux.hpp"
#include <iostream>
#include <cassert>

int main()
{
  std::array arr1{0, 1, 2, 3, 4, 5};
  std::array arr2{   1,    3,    5, 6, 7};
  auto merged = flux::set_symmetric_difference(flux::ref(arr1), flux::ref(arr2));

  assert(flux::equal(merged, std::array{0, 2, 4, 6, 7}));

  for (auto i : merged) {
    // crashes here
    std::cout << i << "\n";
  }

  return 0;
}

Link to the example: https://godbolt.org/z/z6E1eashz
I tried several variations, like reifying into a vector, also crashes
auto vec = merged.to<std::vector>(); // crashes

Interestingly I have a much more complex example using scan and map on the result of set_symmetric_difference and it works.
https://godbolt.org/z/9ex3se6hY

Hi @indiosmo, thanks for the detailed bug report.
I think I can see what the problem is:  set_symmetric_difference_adaptor's  cursor_type should compare equal when both underlying cursors are the same; but the defaulted equality operator is also comparing the state_ field. This means that when using iterators, the end check never returns true and so iteration tries to run off the end of the underlying array, which (fortunately) gets caught by the bounds check.

Hi @indiosmo, this should now be fixed. Thanks again for the bug report, please let me know if you come across any more problems

Cool, I'll test it in a few days. Thanks for the fix.


RDSS linked evidence precaution

This feature request for RDSS is not really related to a problem but would be preferred for moderator safety with RDSS ban approvals linking Roblox phishing links along with other phishing links of sorts.
I would like to see RDSS ban approvals contain links/the evidence in `` ('https://www.roblox.com/home'). Reasoning behind this is concern of a moderator miss-click which could cause a moderators account and/or personal information to become compromised.

RoModerator already has this as an action when banning users with the evidence.

I have considered making a pull request for this myself however my knowledge is not quite there yet to do this myself and still learning.

The markdown features of the originating ban request can be retained, as they are removed in the code, so that the phishing links aren't able to be clicked. However, RoMod also applies the same markdown feature which can yield unusual results and causing the link to be clickable again, like so:
Originating ban request evidence: AUTOMATED BAN REQUEST BY FILTER: <https://roblox.com>
What is displayed in RoMod's success message: AUTOMATED BAN REQUEST BY FILTER: https://roblox.com/``
This is also seen when automatic mutes are executed. There are ways we can prevent the link from being clickable in the success reason, for example by adding a backtick at the beginning, but if you were to ever bring up that particular infraction, you can see that the link is still clickable, like so:
Originating ban request evidence: AUTOMATED BAN REQUEST BY FILTER: <https://roblox.com>
What is displayed in RoMod's success message (after prepending a backtick in the evidence): AUTOMATED BAN REQUEST BY FILTER: `<https://roblox.com>
Output when displaying evidence for that particular infraction: AUTOMATED BAN REQUEST BY FILTER: https://roblox.com`
Ultimately, the best solution would be if RoMod would remove any other markdown formatting features from the evidence then RDSS can retain the markdown formatting of the originating ban request.
However, my thoughts about it are that I'm not sure it is necessary because discord will prompt you with a confirmation if you want to visit that website for domains you have not shown trust for. What's real and what's a phishing link is pretty easy to discern and even then, clicking a phishing link doesn't do much unless you enter your account information on the site


[Proposal] Support for OpenID Connect (OIDC) Authentication (obliterating own user management)

I would like to propose support for a generic OpenID Connect authentication adapter. OpenID Connect is a standardized protocol and simply an authentication layer on top of OAuth 2.0.
It is already supported by an increasing number of public identity providers, including Google, Microsoft Accounts, Microsoft Azure AD, Salesforce, Paypal, Amazon Cognito, Auth0 and many more.
Both clients and servers are readily available. An overview can be found at http://openid.net/developers/libraries/.
Configuring an OpenID Connect client, even for a completely new identity provider is as easy as providing client key and secret, as well as the path to the providers configuration endpoint defined in the Openid Connect spec.
As the protocol also specifies a standardized userinfo endpoint fixing https://github.com/rethinkdb/horizon/issues/841, https://github.com/rethinkdb/horizon/issues/563 and https://github.com/rethinkdb/horizon/issues/216 would be trivial and most likely part of the implementation.
This proposal also alleviates the need to

implement password auth https://github.com/rethinkdb/horizon/issues/176
Add a user-create command https://github.com/rethinkdb/horizon/issues/550
make Horizon its own Oauth provider https://github.com/rethinkdb/horizon/issues/615
support multiple oauth providers simultaneously https://github.com/rethinkdb/horizon/issues/682 (OpenID Connect also standardizes Identity Federation/"Social login")

Since the protocol is standardized, it half-way fixes https://github.com/rethinkdb/horizon/issues/428 and makes adding new providers (https://github.com/rethinkdb/horizon/issues/271) trivial as this just means providing a new configuration for the OIDC adapter.
Since the redirect URL is just part of the adapter configuration it also fixes https://github.com/rethinkdb/horizon/issues/230.
I am generally a proponent of the Unix philosophy of doing one thing and doing it well. Since even setting up your one's own OIDC provider can be as easy as starting a docker container or signing up for Cognito/Auth0 I would like to lobby for keeping the user management facilities within the core of horizon at a minimum and move towards OIDC support instead.
Looking forward to your feedback!
Update - 03/22/17
There are two general ways to implement this:

Horizon as Relying Party (OpenID Connect Client)
Implement Auth Code Flow in Horizon, e.g. using https://github.com/panva/node-openid-client.
This is analog to the current OAuth2 implementation and could also extend that. Requires Horizon to handle its own user sessions (as currently done via issuing signed JWT tokens).
Horizon as Resource Provider (API Server/Backend Node)
The Client (Mobile/Single-Page/Web-Application) acquires an Access/ID Token from an OpenID Connect Identity Provider on its own and provides either to Horizon to authenticate there on behalf of the user.
Option a): Present ID Token - Only a good idea when the ID token is shortlived (i.e. 5 minutes) just like a typical access token. Allows Horizon to derive all relevant user details directly from the ID token and is thus extremely scalable. Cf. https://developers.google.com/identity/sign-in/web/backend-auth
Option b): Present Access Token - In order to verify the user identity, Horizon needs to pass on the access token to the Identity Provider's userinfo endpoint (specified in OIDC spec) and process the results. This adds latency to the authentication and load to the Identity Provider.

I have implemented Option 2a) (best for my usecase) in a private fork and would be happy to discuss.

I totally agree with keeping the user management at a minimum, from my use case I see that auto reconnects and easier server side validation are far more  important at this stage. I say this because I am embedding horizon in my application so adding complex logging is just a usual Express hack, but I don't believe that this would be the case if I was serving my app with horizon (via hz cli). So it is very important to use an authentication mechanism that is suitable for the general use case, and for those who want to try something more complex or different (the remaining 10 %) embed horizon and add your thing via some rest api.

I have implemented OIDC ID Token auth. See above for details.


Update default configuration to 0.1 deg zstar

This was just pulled from the zstar-run branch. Is this what you had in mind @AndyHoggANU?

Yep. Looks good.
One thing I just noticed looking through these changes. The input files and executables are still stored on x77 ... we probably need to shift those to ik11 if others are going to be able to access them?

I'm going to merge now -- we can update filenames later.


Develop

PR Types
Others
PR changes
Others
Describe
add MobileNetV3_small_x1_0.yaml

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Improve live view performance

The live view loads slowly. Improve and add a progress bar.

Seems refresh table is the one slowing down the application

The problem is the second ajax call to get monthly data. We need to bundle everything into one ajax call. The map fix however helped a little


CiaB produces invalid configuration/required parameter is undocumented

I'm submitting a ...

bug report

Traffic Control components affected ...

CDN in a Box
Documentation
Traffic Ops ORT

Current behavior:
CDN-in-a-Box's cache server Profiles are missing the required Parameter:
{
	"name": "trafficserver",
	"config_file": "package",
	"value": "{{version}}-{{patch}}.{{commit hash}}.{{Enterprise Linux release}}.{{distro}}.{{CPU arch}}"
}

Which is also not present anywhere in documentation. If this Parameter is not present, atstccfg will assume that the server is using the unsupported ATS version 5.0, and will generate its configuration appropriately. This means that it will possibly generate configuration that the cache servers can't actually understand.
Expected behavior:
atstccfg should be aware of the actual ATS version installed on the CiaB cache servers.
Minimal reproduction of the problem with instructions:
Check the ORT logs for CiaB cache servers, notice that they note the ATS version as 5

These exist now, but have Values that are just (unchanged). If that's handled specially, I think it's undocumented. If it isn't, then a reasonable feature request would be that it isn't required (which is covered by #6205) or that the Value be valid and correct somehow.

These exist now, but have Values that are just (unchanged). If that's handled specially, I think it's undocumented.

CDN in a Box changes it to a valid value:
https://github.com/apache/trafficcontrol/blob/497b885614729a8eba8a2019b0cc23a9c9ef0f09/infrastructure/cdn-in-a-box/cache/run.sh#L45
https://github.com/apache/trafficcontrol/blob/497b885614729a8eba8a2019b0cc23a9c9ef0f09/infrastructure/cdn-in-a-box/cache/run.sh#L52
But yeah, we should document it. Note that our site's downloadable profiles
already have it:
    {
      "configFile": "package",
      "name": "trafficserver",
      "value": "8.1.1-59.673d979d0.el8.centos.x86_64"
    },

can this be closed @ocket8888 @zrhoffman

No, the parameter is still undocumented

This is it, right?
https://github.com/apache/trafficcontrol/blob/743f1d49c0047458b95e6c047363863e8120ec39/docs/source/overview/profiles_and_parameters.rst#L465-L469
It could still use an example IMO

Huh, yeah, I guess it is.


CBT check and table of contents

Noticing that "VMs with CBT disabled" plugin is reporting on VMs that have CBT enabled with the variable "Should CBT be enabled" set to "$true".  Am i misunderstanding that it should be reporting on VMs that instead have CBT disabled?
Changing line 17 to "Where-object {$_.Config.ChangeTrackingEnabled -ne $CBTEnabled}"  flips this
Also, I searched but was unable to find a way to disable the 'table of contents' at top of vCheck report.
Is this easily possible?
Thanks for maintaining this script, Alan and everyone else

Yep, good catch! Just pushed an update to the dev branch- can you test it out for us?
There is a setting in the style to show the table of contents or not- $ShowTOC

thanks Sneddo, dev copy of '620 CBT Status' looks good.
I changed $ShowTOC in style to $false but table of contents is still appearing in email.
Also could not locate where $ShowTOC is being called out in any other file, unless that's not how it's being handled.
I renamed the 'Get-ReportTOC' function to something else as a workaround

Yeah, you're right- it's not actually used. If I get a chance today I'll push a fix for it, otherwise it will be a week or so.

This should now be fixed


How should it work?

Hi, @zenato
Just wonder about the idea (I'm surprised that can't see this question in issues).
We have next in middleware:
let isRender = false

module.exports = function(options) {
  if (!options || !options.url) {
    throw new Error('Must set url.')
  }

  let rendererUrl = options.url

  const userAgentPattern = options.userAgentPattern || new RegExp(botUserAgents.join('|'), 'i')
  const excludeUrlPattern =
    options.excludeUrlPattern || new RegExp(`\\.(${staticFileExtensions.join('|')})$`, 'i')
  const timeout = options.timeout || 10 * 1000

  return (req, res, next) => {
    if (isRender) return next()
    isRender = true

My concern is that isRender flag. On first request it's false. That's fine. We can run our logic to detect bot and so. After first call you make it true. And it makes middleware ignore all the following requests.
What's the idea?

@vvscode It was huge mistake.The isReder flag was designed for cache, but decided not to implement the cache. But I didn't delete this flag and did commit.
Thank you for let me know. I fixed it.


Can this be used in an existing project?

Can you use this inside an existing project as a dashboard view/page?

@AlmogRnD You can have it as an app under an umbrella application (see: https://github.com/kittoframework/kitto/wiki/Umbrella-Apps).
If you need further help on how this can work, let's chat on gitter (https://gitter.im/kittoframework/Lobby).
I'll close this issue as I prefer to keep issues mostly about bug reports. Thanks.