Conflicting ingressClassName http01 issuer spec and acme.cert-manager.io/http01-ingress-class annotation

Describe the bug:
When

a (Cluster)Issuer is configured with the new spec.acme.solvers[].http01.ingress.ingressClassName property to set the default ingress class for challenge solver ingresses (instead of the older ...http01.ingress.class),
and an application ingress tries to override the default ingress class using the documented acme.cert-manager.io/http01-ingress-class annotation,

the generated Challenge resource will have both class and ingressClassName set in its spec. This causes a conflict with the status message "the fields ingressClassName and class cannot be set at the same time" and fail to create an Ingress resource to solve the HTTP01 challenge.
Stripped-down/redacted example of the Challenge resource created by cert-manager:
apiVersion: acme.cert-manager.io/v1
kind: Challenge
metadata:
  name: testingress-tls-xxxxx-000000000-1111111111
  namespace: acmetest
spec:
  authorizationURL: https://acme-v02.api.letsencrypt.org/acme/authz-v3/00000000000
  dnsName: testingress.example.com
  issuerRef:
    group: cert-manager.io
    kind: ClusterIssuer
    name: my-clusterissuer
  key: >-
    xxxxxxxxxxxxxxx.....
  solver:
    http01:
      ingress:
        class: nginx
        ingressClassName: nginx
  token: yyyyyyyyyyyyyyyy.....
  type: HTTP-01
  url: https://acme-v02.api.letsencrypt.org/acme/chall-v3/00000000000/xxxxxx
  wildcard: false
status:
  presented: false
  processing: true
  reason: the fields ingressClassName and class cannot be set at the same time
  state: pending

Setting the old-style ...http01.ingress.class attribute on the Issuer's solver spec instead of ingressClassName avoids the issue and works as expected, but will create challenge solver ingresses with the legacy class annotation instead of the modern ingressClassName spec.
Expected behaviour:

Either there should be a separate, new and well documented annotation for Ingresses to override the ingressClassName instead of the class attribute of a Challenge, e.g. something like acme.cert-manager.io/http01-ingress-ingressclassname,
or cert-manager should automatically figure out, based on the configuration of a solver, which type of configuration is set as default, and convert the class name set via Ingress annotation as necessary to replace that default, instead of adding a duplicate/conflicting attribute.

Steps to reproduce the bug:
Stripped-down app ingress manifest:
apiVersion: networking.k8s.io/v1
kind: Ingress
metadata:
  annotations:
    acme.cert-manager.io/http01-ingress-class: nginx
    cert-manager.io/cluster-issuer: my-clusterissuer
  name: testingress
  namespace: acmetest
spec:
  ingressClassName: nginx
  rules:
    - host: testingress.example.com
      http:
        paths: [] # ...
  tls:
    - hosts:
        - testingress.example.com
      secretName: testingress-tls

Stripped-down ClusterIssuer manifest:
apiVersion: cert-manager.io/v1
kind: ClusterIssuer
metadata:
  name: dico-clusterissuer
spec:
  acme:
    # ...
    solvers:
      - http01:
          ingress:
            ingressClassName: nginx

Anything else we need to know?:
This relates to the new http01.ingress.ingressClassName solver spec attribute which got introduced in the recent v1.15 cert-manager version. It's not a regression, but a bug or a missing part with the new feature.
Environment details::

Kubernetes version: 1.24.10
Cloud-provider/provisioner: Azure/AKS
cert-manager version: v1.12.1
Install method: official Helm chart

/kind bug

any updates on this?

We also have the same problem: our 1500 NS cluster and 150 projects implement a single issuer and use ingress annotations to override ingress class, thus allowing to setup only 1 issuer for several ingress controllers.
We are also missing an annotation such as acme.cert-manager.io/http01-ingress-ingressclassname to override the issuer setup and avoid to ask to projects to multiply the number of their issuers.

We also have a similar problem:
In the previous versions of cert-manager we were using a combination of annotations in the Ingress
    acme.cert-manager.io/http01-ingress-class: "nginx-public"
    cert-manager.io/cluster-issuer: "letsencrypt-http"

Recently we updated the cert-manager to the 1.12.3 version and modify the ClusterIssuer to include the ingressClassName instead of the class.
When the cert-manager try to update a certificate with this two annotations, the cert-manager says
err="the fields ingressClassName and class cannot be set at the same time"

and generate a service in nodePort mode.
When we go to the Ingress and delete the acme.cert-manager.io/http01-ingress-class: "nginx-public" the cert-manager doesn't update the certificate and it's trying to generate the certificate using the service with the nodePort.
When we delete the certificate, automatically the cert-manager generates a new one with the correct properties.
It's possible solve this situation without deleting the certificate?

We are encountering the same issue - its odd since it never happened with one of our other namespaces ingresses but just happening with our main production ingress. Any updates?

/remove-lifecycle stale

/remove-lifecycle stale

Even if you remove the ingressClass from your cluster issuer
before:
    solvers:
    - http01:
        ingress:
          ingressClassName: nginx-public

after:
    solvers:
  - http01:
      ingress: {}

and just set the class on your ingress
acme.cert-manager.io/http01-ingress-class: "nginx-public"

it just sets a kubernetes.io/ingress.class annotation on the ingress! This should not happen! Maybe that is the problem ... that the cert-manager should overwrite the ingressClass annotation instead of adding the old kubernetes.io/ingress.class annotation!
So if you set the acme.cert-manager.io/http01-ingress-class:, cert-manager should SET OR OVERRIDE the ingressClassName on the solver ingress instead of setting the old "kubernetes.io/ingress.class" annotation!

I would like to see a resolution to this as well--agree with @discostur's observation that acme.cert-manager.io/http01-ingress-class seems to be setting the "class" annotation, not the "ingressClass" annotation.

/remove-lifecycle stale


The statistical results show an anomaly

Describe the Bug
The statistical results show an anomaly
look https://umami.buasis.eu.org/share/Wdw336ggsph7M5Fa/buasis.eu.org

Database
PostgreSQL
Relevant log output
no log

Which Umami version are you using? (if relevant)
v2.15.1
Which browser are you using? (if relevant)
edge browser，and use api in edge browser
How are you deploying your application? (if relevant)
netlify

I forgot to mention that only one website is abnormal, and the statistics service of other websites is normal


Fix #2527 - Remove FormCollection use

This removes the dependency on Microsoft.AspNet.Http from the Mvc.Core
code. Added the reference back to tests where needed (DefaultHttpContext).

/cc @davidfowl

VS loves to format stuff :laughing:

Looks as if a few more tests need to change.

:watch:

@dougbu updated

:shipit:


⚠ Samsung has degraded performance

In 0ae51b3, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 2440 ms

Resolved: Samsung performance has improved in aaa1c6b.


This should be divided by 2*PI

https://github.com/DeepBlueRobotics/WPILibWebSocketsToWebots/blob/0368549ec54106bf8b3a5a4e2fea48a574f29f72/src/main/java/code/lib/sim/MockedSparkEncoder.java#L36

I multiplied pi by 2


boost::compute::normal_distribution returns incorrect variance

I tried to generate random number using boost compute random, but it seems it returns wrong variance.
My script can be found at here.

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/33279479-boost-compute-normal_distribution-float-returns-incorrect-variance?utm_campaign=plugin&utm_content=tracker%2F402515&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F402515&utm_medium=issues&utm_source=github).

Which version of Boost.Compute have you used? Because this bug was issued here https://github.com/boostorg/compute/issues/587 and should be fixed by pull-request https://github.com/boostorg/compute/pull/591 (see develop branch).

Ah, I see. I was on the main branch 44f08e3932e8ec1101e1aa137e404c3da5fddb5c.
After I swtiched the develop branch, the issue was solved. Thank you for your information!

Glad I could help!

Just a quick tangential comment about your script: if you're generating a lot of normals (not using compute), you'll find that boost::random::normal_distribution is considerably faster than std::normal_distribution; both libstdc++ and MSVC appear to be using a Box-Muller algorithm, while boost::random::n_d uses the much faster ziggurat algorithm (since 1.56.0).
(Compute can't do the same, as far as I can see, because the ziggurat algorithm is a rejection sampling algorithm that requires branching and looping until an acceptable value is found).


Licence

I would like to known if it is possible to use SPIKA in Commercial project ? Because I don't understand everything about the differences licences (what i can do with or not)
Thanks

licence is MIT License, which is commercial friendly.
"Permission is hereby granted, free of charge, to any person obtaining a copy
of this software and associated documentation files (the "Software"), to deal
in the Software without restriction, including without limitation the rights
to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
copies of the Software, and to permit persons to whom the Software is
furnished to do so, subject to the following conditions:
The above copyright notice and this permission notice shall be included in
all copies or substantial portions of the Software."
https://en.wikipedia.org/wiki/MIT_License


Display events

Display all events and for given device.

Hey @nkstanchev, want to try working on this? We can zoom to chat about it if you'd like!

@alexcourouble Sure! Count me in

@nkstanchev for now, we can just implement a list subcommand under event. You can look at the other list subcommands as an example. We can use this API call:  http://localhost:48080/api/v1/event.
In the future, we can imagine list the events just for a specific device. In this case, the command would look like this: edgex event list [DEVICE NAME/ID]. But no rush :)
Let me know if you have any issues!


HDFS-17166. RBF: Throwing NoNamenodesAvailableException for a long time, when failover

Description of PR
Provides a description of the bug, the cause of the bug and steps to reproduce it：https://issues.apache.org/jira/browse/HDFS-17166
How was this patch tested?
1. Unit testing

please see: TestRouterClientRejectOverload.testNoNamenodesAvailableLongTimeWhenNsFailover()

2. Comparison test in real environment

Suppose we have 2 clients [c1 c2], 2 routers  [r1 r2] and a ns [ns60], the ns has 2 nn [nn6001  nn6002]

If both nn6001 and nn6002 are in standby state, the priority of nn6002 is higher than nn6001,

r1 uses the package that fixing the bug, r2 uses the original package which has the bug

c1 loops to send requests to r1, and c2 loops to send requests to r2, the request is related to ns60

Make both nn6001 and nn6002 in standby state

After the router reports that nn is in standby state, switch nn6001 to active
14:15:24 nn6001 is active

Check the log of router r1, after nn6001 switches to active, only NoNamenodesAvailableException is printed once

Check the log of router r2, and print NoNamenodesAvailableException for more than one minute after nn6001 switches to active

At 14:16:25, the client c2 accessing the router with the bug could not get the data, and the client c1 accessing the router after the bug was fixed could get the data normally:

c2's log:unable to access normally

c1's log:display the result correctly

For code changes:

[x] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
[ ] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 35s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 3 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
33m 31s

trunk passed

+1 :green_heart:
compile
0m 33s

trunk passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
compile
0m 30s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
checkstyle
0m 26s

trunk passed

+1 :green_heart:
mvnsite
0m 35s

trunk passed

+1 :green_heart:
javadoc
0m 34s

trunk passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
javadoc
0m 26s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
1m  2s

trunk passed

+1 :green_heart:
shadedclient
22m 13s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 24s

the patch passed

+1 :green_heart:
compile
0m 25s

the patch passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
javac
0m 25s

the patch passed

+1 :green_heart:
compile
0m 22s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
javac
0m 22s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 15s
/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs-rbf.txt
hadoop-hdfs-project/hadoop-hdfs-rbf: The patch generated 5 new + 1 unchanged - 0 fixed = 6 total (was 1)

+1 :green_heart:
mvnsite
0m 24s

the patch passed

+1 :green_heart:
javadoc
0m 22s

the patch passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
javadoc
0m 20s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
0m 55s

the patch passed

+1 :green_heart:
shadedclient
23m 26s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
29m 32s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs-rbf.txt
hadoop-hdfs-rbf in the patch passed.

+1 :green_heart:
asflicense
0m 38s

The patch does not generate ASF License warnings.

120m 36s

Reason
Tests

Failed junit tests
hadoop.hdfs.server.federation.router.TestRouterRpc

hadoop.hdfs.server.federation.router.TestRouterQuota

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5990/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5990

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 4bac7adc94c4 4.15.0-213-generic #224-Ubuntu SMP Mon Jun 19 13:30:12 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / da69e7f403c95c8daf7305eea60432f4fc57d9bb

Default Java
Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5990/1/testReport/

Max. process+thread count
2646 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project/hadoop-hdfs-rbf

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5990/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 28s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 3 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
32m 43s

trunk passed

+1 :green_heart:
compile
0m 32s

trunk passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
compile
0m 30s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
checkstyle
0m 26s

trunk passed

+1 :green_heart:
mvnsite
0m 33s

trunk passed

+1 :green_heart:
javadoc
0m 36s

trunk passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
javadoc
0m 26s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
0m 59s

trunk passed

+1 :green_heart:
shadedclient
20m 57s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 24s

the patch passed

+1 :green_heart:
compile
0m 24s

the patch passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
javac
0m 24s

the patch passed

+1 :green_heart:
compile
0m 22s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
javac
0m 22s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 15s

the patch passed

+1 :green_heart:
mvnsite
0m 25s

the patch passed

+1 :green_heart:
javadoc
0m 23s

the patch passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
javadoc
0m 19s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
0m 55s

the patch passed

+1 :green_heart:
shadedclient
21m 17s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
19m 13s

hadoop-hdfs-rbf in the patch passed.

+1 :green_heart:
asflicense
0m 31s

The patch does not generate ASF License warnings.

105m 56s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5990/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5990

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 8cee938ef2d5 4.15.0-213-generic #224-Ubuntu SMP Mon Jun 19 13:30:12 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 29c98dcc951470f37ab9d9cd11f7036aa7b10484

Default Java
Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5990/2/testReport/

Max. process+thread count
2639 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project/hadoop-hdfs-rbf

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5990/2/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@simbadzina @goiri  Could you please help to review.

@KeeProMise Thank you for your contribution, LGTM. The information described is very detailed!

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 32s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 3 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
32m  8s

trunk passed

+1 :green_heart:
compile
0m 32s

trunk passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
compile
0m 30s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
checkstyle
0m 25s

trunk passed

+1 :green_heart:
mvnsite
0m 34s

trunk passed

+1 :green_heart:
javadoc
0m 35s

trunk passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
javadoc
0m 27s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
1m  0s

trunk passed

-1 :x:
shadedclient
20m 30s

branch has errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 25s

the patch passed

+1 :green_heart:
compile
0m 25s

the patch passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
javac
0m 25s

the patch passed

+1 :green_heart:
compile
0m 22s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
javac
0m 22s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 14s

the patch passed

+1 :green_heart:
mvnsite
0m 25s

the patch passed

+1 :green_heart:
javadoc
0m 23s

the patch passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
javadoc
0m 20s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
0m 53s

the patch passed

-1 :x:
shadedclient
20m  5s

patch has errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
19m  9s

hadoop-hdfs-rbf in the patch passed.

+1 :green_heart:
asflicense
0m 30s

The patch does not generate ASF License warnings.

103m 48s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5990/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5990

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 77fc3e6b5d7d 4.15.0-213-generic #224-Ubuntu SMP Mon Jun 19 13:30:12 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / fd893312f62b5d1f3308fb0f34f213798bab5492

Default Java
Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5990/4/testReport/

Max. process+thread count
2638 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project/hadoop-hdfs-rbf

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5990/4/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 51s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 3 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
43m 31s

trunk passed

+1 :green_heart:
compile
0m 45s

trunk passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
compile
0m 40s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
checkstyle
0m 33s

trunk passed

+1 :green_heart:
mvnsite
0m 48s

trunk passed

+1 :green_heart:
javadoc
0m 45s

trunk passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
javadoc
0m 35s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
1m 29s

trunk passed

-1 :x:
shadedclient
33m 58s

branch has errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 38s

the patch passed

+1 :green_heart:
compile
0m 38s

the patch passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
javac
0m 37s

the patch passed

+1 :green_heart:
compile
0m 34s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
javac
0m 34s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 22s

the patch passed

+1 :green_heart:
mvnsite
0m 36s

the patch passed

+1 :green_heart:
javadoc
0m 30s

the patch passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
javadoc
0m 25s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
1m 23s

the patch passed

-1 :x:
shadedclient
32m 45s

patch has errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
22m 45s

hadoop-hdfs-rbf in the patch passed.

+1 :green_heart:
asflicense
0m 39s

The patch does not generate ASF License warnings.

149m 33s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5990/5/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5990

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 9ff633bec736 4.15.0-212-generic #223-Ubuntu SMP Tue May 23 13:09:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / e41f72c304cfd8de4ec13392aaed6271af0b1a39

Default Java
Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5990/5/testReport/

Max. process+thread count
2708 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project/hadoop-hdfs-rbf

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5990/5/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 28s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 3 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
31m 26s

trunk passed

+1 :green_heart:
compile
0m 32s

trunk passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
compile
0m 30s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
checkstyle
0m 25s

trunk passed

+1 :green_heart:
mvnsite
0m 33s

trunk passed

+1 :green_heart:
javadoc
0m 35s

trunk passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
javadoc
0m 26s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
1m  0s

trunk passed

-1 :x:
shadedclient
22m 58s

branch has errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 24s

the patch passed

+1 :green_heart:
compile
0m 25s

the patch passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
javac
0m 25s

the patch passed

+1 :green_heart:
compile
0m 23s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
javac
0m 23s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 14s

the patch passed

+1 :green_heart:
mvnsite
0m 24s

the patch passed

+1 :green_heart:
javadoc
0m 22s

the patch passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
javadoc
0m 20s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
0m 54s

the patch passed

-1 :x:
shadedclient
23m 21s

patch has errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
19m 27s

hadoop-hdfs-rbf in the patch passed.

+1 :green_heart:
asflicense
0m 31s

The patch does not generate ASF License warnings.

108m 38s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5990/6/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5990

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux c842325ffa1f 4.15.0-213-generic #224-Ubuntu SMP Mon Jun 19 13:30:12 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / ff812317821414e9758f8d441e21aee826d75207

Default Java
Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5990/6/testReport/

Max. process+thread count
2567 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project/hadoop-hdfs-rbf

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5990/6/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 30s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 3 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
34m 36s

trunk passed

+1 :green_heart:
compile
0m 32s

trunk passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
compile
0m 30s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
checkstyle
0m 25s

trunk passed

+1 :green_heart:
mvnsite
0m 34s

trunk passed

+1 :green_heart:
javadoc
0m 35s

trunk passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
javadoc
0m 27s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
0m 59s

trunk passed

-1 :x:
shadedclient
20m 27s

branch has errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 24s

the patch passed

+1 :green_heart:
compile
0m 25s

the patch passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
javac
0m 25s

the patch passed

+1 :green_heart:
compile
0m 23s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
javac
0m 23s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 14s

the patch passed

+1 :green_heart:
mvnsite
0m 24s

the patch passed

+1 :green_heart:
javadoc
0m 22s

the patch passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
javadoc
0m 20s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
0m 55s

the patch passed

-1 :x:
shadedclient
20m  8s

patch has errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
19m 26s

hadoop-hdfs-rbf in the patch passed.

+1 :green_heart:
asflicense
0m 30s

The patch does not generate ASF License warnings.

106m 56s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5990/7/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5990

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 53fb34456ce6 4.15.0-213-generic #224-Ubuntu SMP Mon Jun 19 13:30:12 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 209f5883112aa247eefc1c254f14f4d64be55975

Default Java
Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5990/7/testReport/

Max. process+thread count
2561 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project/hadoop-hdfs-rbf

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5990/7/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 52s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 3 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
42m  8s

trunk passed

+1 :green_heart:
compile
0m 43s

trunk passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
compile
0m 43s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
checkstyle
0m 33s

trunk passed

+1 :green_heart:
mvnsite
0m 45s

trunk passed

+1 :green_heart:
javadoc
0m 46s

trunk passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
javadoc
0m 37s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
1m 26s

trunk passed

-1 :x:
shadedclient
32m 35s

branch has errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 34s

the patch passed

+1 :green_heart:
compile
0m 34s

the patch passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
javac
0m 34s

the patch passed

+1 :green_heart:
compile
0m 32s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
javac
0m 32s

the patch passed

+1 :green_heart:
blanks
0m  1s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 20s

the patch passed

+1 :green_heart:
mvnsite
0m 34s

the patch passed

+1 :green_heart:
javadoc
0m 30s

the patch passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
javadoc
0m 26s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
1m 20s

the patch passed

-1 :x:
shadedclient
32m 55s

patch has errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
22m 41s

hadoop-hdfs-rbf in the patch passed.

+1 :green_heart:
asflicense
0m 42s

The patch does not generate ASF License warnings.

147m  2s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5990/8/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5990

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 2b5bb9fb1067 4.15.0-212-generic #223-Ubuntu SMP Tue May 23 13:09:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / cb4e08cb364c80d53a83a62f79dee19060636d17

Default Java
Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5990/8/testReport/

Max. process+thread count
3183 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project/hadoop-hdfs-rbf

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5990/8/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

I think the shadedclient error is not related to my pr, because I found that other PRs in the recent period also have this problem.

I think the "shadedclient" error is not related to this PR, because I found that all other PRs in the recent period also have this problem. error log:

@KeeProMise Can you provide a link to the unit test that reported the error?

I think the "shadedclient" error is not related to this PR, because I found that all other PRs in the recent period also have this problem. error log:

@KeeProMise Can you provide a link to the unit test that reported the error?
I found it. https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5990/8/artifact/out/branch-shadedclient.txt

I think the "shadedclient" error is not related to this PR, because I found that all other PRs in the recent period also have this problem. error log:

@KeeProMise Can you provide a link to the unit test that reported the error?
I found it. https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5990/8/artifact/out/branch-shadedclient.txt

Thank you for your timely resolution, if the shadedclient problem is fixed, I will re-check my pr

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 55s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 3 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
44m 35s

trunk passed

+1 :green_heart:
compile
0m 44s

trunk passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
compile
0m 41s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
checkstyle
0m 36s

trunk passed

+1 :green_heart:
mvnsite
0m 48s

trunk passed

+1 :green_heart:
javadoc
0m 48s

trunk passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
javadoc
0m 37s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
1m 32s

trunk passed

+1 :green_heart:
shadedclient
34m  6s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 35s

the patch passed

+1 :green_heart:
compile
0m 36s

the patch passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
javac
0m 36s

the patch passed

+1 :green_heart:
compile
0m 31s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
javac
0m 31s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 20s

the patch passed

+1 :green_heart:
mvnsite
0m 35s

the patch passed

+1 :green_heart:
javadoc
0m 30s

the patch passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
javadoc
0m 26s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
1m 22s

the patch passed

+1 :green_heart:
shadedclient
37m 15s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
22m 53s

hadoop-hdfs-rbf in the patch passed.

+1 :green_heart:
asflicense
0m 42s

The patch does not generate ASF License warnings.

156m 29s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5990/9/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5990

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 4aa8afceab4e 4.15.0-212-generic #223-Ubuntu SMP Tue May 23 13:09:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / cb4e08cb364c80d53a83a62f79dee19060636d17

Default Java
Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5990/9/testReport/

Max. process+thread count
3037 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project/hadoop-hdfs-rbf

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5990/9/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@slfan1989 @goiri @simbadzina  "shadedclient error" has been fixed, If you have time, please help to continue the review or merge the PR, Thanks a lot~

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 29s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 3 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
31m 59s

trunk passed

+1 :green_heart:
compile
0m 32s

trunk passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
compile
0m 29s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
checkstyle
0m 26s

trunk passed

+1 :green_heart:
mvnsite
0m 33s

trunk passed

+1 :green_heart:
javadoc
0m 35s

trunk passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
javadoc
0m 26s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
0m 58s

trunk passed

+1 :green_heart:
shadedclient
20m 46s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 25s

the patch passed

+1 :green_heart:
compile
0m 25s

the patch passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
javac
0m 25s

the patch passed

+1 :green_heart:
compile
0m 23s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
javac
0m 23s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 15s

the patch passed

+1 :green_heart:
mvnsite
0m 25s

the patch passed

+1 :green_heart:
javadoc
0m 23s

the patch passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
javadoc
0m 20s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
0m 58s

the patch passed

+1 :green_heart:
shadedclient
21m 13s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
19m 16s

hadoop-hdfs-rbf in the patch passed.

+1 :green_heart:
asflicense
0m 30s

The patch does not generate ASF License warnings.

105m  3s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5990/10/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5990

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 4ff2c053af7c 4.15.0-213-generic #224-Ubuntu SMP Mon Jun 19 13:30:12 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / b8b1dea36262f5175208ea335f158ec347738521

Default Java
Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5990/10/testReport/

Max. process+thread count
2556 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project/hadoop-hdfs-rbf

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5990/10/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 51s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 3 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
43m 54s

trunk passed

+1 :green_heart:
compile
0m 45s

trunk passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
compile
0m 42s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
checkstyle
0m 36s

trunk passed

+1 :green_heart:
mvnsite
0m 47s

trunk passed

+1 :green_heart:
javadoc
0m 48s

trunk passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
javadoc
0m 36s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
1m 26s

trunk passed

+1 :green_heart:
shadedclient
34m 30s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 34s

the patch passed

+1 :green_heart:
compile
0m 35s

the patch passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
javac
0m 35s

the patch passed

+1 :green_heart:
compile
0m 32s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
javac
0m 32s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 21s

the patch passed

+1 :green_heart:
mvnsite
0m 34s

the patch passed

+1 :green_heart:
javadoc
0m 31s

the patch passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
javadoc
0m 25s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
1m 21s

the patch passed

+1 :green_heart:
shadedclient
34m  1s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
23m 13s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs-rbf.txt
hadoop-hdfs-rbf in the patch passed.

+1 :green_heart:
asflicense
0m 40s

The patch does not generate ASF License warnings.

152m  9s

Reason
Tests

Failed junit tests
hadoop.hdfs.server.federation.router.TestRouterRPCMultipleDestinationMountTableResolver

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5990/11/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5990

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux aa583f8e6a40 4.15.0-212-generic #223-Ubuntu SMP Tue May 23 13:09:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 8846f60404da677c2256029e42fe362e63dc12ae

Default Java
Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5990/11/testReport/

Max. process+thread count
3426 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project/hadoop-hdfs-rbf

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5990/11/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 29s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 3 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
32m  8s

trunk passed

+1 :green_heart:
compile
0m 31s

trunk passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
compile
0m 30s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
checkstyle
0m 25s

trunk passed

+1 :green_heart:
mvnsite
0m 34s

trunk passed

+1 :green_heart:
javadoc
0m 35s

trunk passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
javadoc
0m 26s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
1m  0s

trunk passed

+1 :green_heart:
shadedclient
20m 52s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 24s

the patch passed

+1 :green_heart:
compile
0m 24s

the patch passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
javac
0m 24s

the patch passed

+1 :green_heart:
compile
0m 21s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
javac
0m 21s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 15s

the patch passed

+1 :green_heart:
mvnsite
0m 25s

the patch passed

+1 :green_heart:
javadoc
0m 22s

the patch passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
javadoc
0m 19s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
0m 52s

the patch passed

+1 :green_heart:
shadedclient
21m 16s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
19m 29s

hadoop-hdfs-rbf in the patch passed.

+1 :green_heart:
asflicense
0m 31s

The patch does not generate ASF License warnings.

105m 35s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5990/12/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5990

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux d91211994ad2 4.15.0-213-generic #224-Ubuntu SMP Mon Jun 19 13:30:12 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / d338de4aa57d30349cb7bb1fa32c1d93dfc851e0

Default Java
Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5990/12/testReport/

Max. process+thread count
2641 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project/hadoop-hdfs-rbf

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5990/12/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

Hi @goiri @simbadzina The latest CI report green here and you have approved this PR. If no more comments here, Please help to check in. Thanks.

@goiri If you have time, please help to continue the review or merge the PR, Thanks a lot~

@goiri @simbadzina @slfan1989 If you have no other questions about this PR, please help merge it, thanks


Template variable warning: 'break' is undefined

I am getting the following warning in my HA logs:
Template variable warning: 'break' is undefined when rendering '{%- set activepage = namespace() -%} {%- for entity in device_entities(haspdevice) -%} {%- if entity|regex_search("^number\..*_active_page(?:_\d+|)$") -%} {%- set activepage.entity=entity -%} {{ break }} {%- endif -%} {%- endfor -%} {% if states(activepage.entity)|lower == "none" %}-1{% else %}{{ states(activepage.entity) | int }}{% endif %}'
5:17:00 PM – (WARNING) helpers/template.py - message first occurred at 5:07:24 PM and shows up 416 times

Just saw you updated the code already. Closing.


Improve internal series parser performance?

Motivation for changes:
Currently, calls to the series parser from series plugin end up instantiating one parser per series per entry. Instantiating a new parser involves compiling regexes for that series again, which may be slow.
Detailed changes:
Add an lru cache where internal parser keeps instantiated parsers for configured series. This means the parsers should be instantiated once per series in your config, rather than once per series per entry.
Caveats and a Request
I haven't done any performance testing, this was just a gut reaction. If anyone would like to do some scientific performance testing, or just test this branch out with your (series heavy) config and post results it would be appreciated.

A while back I made a plugin that can test this rather easily. Task:
  mock_series:
    parsing:
      series: guessit
    mock_series:
      number: 100
      with_episode_id: yes
    configure_series:
      from:
        mock_series:
          number: 1500
      settings:
        identified_by: ep

Plugin: https://gist.github.com/cvium/eeb40652570dd8fc501b75cae29348f1

I did some very cursory testing without significant result. Thinking this isn't worth it.


Tracing Tab

Describe the solution you'd like
It would be nice to have a flame chart / tracing tab.
This would only work when tracing is on but I tend to keep tracing on in development.
Describe alternatives you've considered
Playgrounds have tracing. Logging tools can create flame charts / tracing.

https://github.com/warrenday/graphql-network-inspector/pull/43


Pick only exact matched locale for polyfill

This fixes #315.
I'll be able to run more test on Monday, but it should be ok.
Is there any other usage I'm not aware of that could be broken by this approach?

@jgoclawski no issues with this, thanks for reporting and also submitting the patch.
I will version shortly.


Enable pylint and pyright after Radiology Insights again for other healthinsights projects (CancerProfiling & ClinicalTrialMatcher)

Enable pylint and pyright after Radiology Insights again for other healthinsights projects (CancerProfiling & ClinicalTrialMatcher)

Remove the 2 pyproject.toml files again in the root of both repositories.


GitHub: Invite member

Who should be invited to Catena-X ng
GitHub User:
https://github.com/ds-jleyh
Vouching person: @mkanal

Invitation sent. Like always, you can add you colleague to our team after the invite is accepted @mkanal

Closing, since the invitation was accepted


Too wide intervals between links in the references section of the docstrings

References section formatted as per numpydoc standard.
Here is an example:

Fixed in #488


add -webkit-appearance: none to Button

Webkit shows rounded submit buttons. Screenshot is taken of the bottom of http://papercast.xyz/ on iPhone 6+

hi @pitr Thanks for the info. You could tell me which browser, and if possible also the version.

Mobile Safari, iOS 9.2

bump

Hi @pitr
Maybe it's because you are not making use of the Normalize.css. These add tags in the head:
<!-- Google Fonts -->
<link rel="stylesheet" href="https://fonts.googleapis.com/css?family=Roboto:300,300italic,700,700italic">

<!-- CSS Reset -->
<link rel="stylesheet" href="https://cdnjs.cloudflare.com/ajax/libs/normalize/3.0.3/normalize.css">

See more info here:
https://milligram.github.io/#getting-started

ah, didn't realise normalize.css is a hard dependency


[now-python] Encode body as utf-8 before making a request

Addresses #3091
I still have to deploy and test.

My current question about this is, does aws/lambda ensure that the data in the payload body is utf-8. It should be coming from the browser, but I'm not sure if we should be checking the content-type header or not.
In any case, this modification will ensure wider compatibility and also does what the other handlers are doing by default as well (assuming utf-8 for encoding strings).

Thanks for the PR!
Can you add a test for this behavior so we don't regress?

writing one now

How do I run just the python builder tests?

Codecov Report

Merging #3093 into canary will increase coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           canary    #3093      +/-   ##
==========================================
+ Coverage   11.33%   11.34%   +<.01%
==========================================
  Files         268      268
  Lines       10064    10069       +5
  Branches     1314     1314
==========================================
+ Hits         1141     1142       +1
- Misses       8830     8834       +4
  Partials       93       93

Impacted Files
Coverage Δ

src/commands/deploy/latest.js
0% <0%> (ø)
:arrow_up:

src/util/handle-error.ts
38.88% <0%> (ø)
:arrow_up:

src/commands/deploy/legacy.ts
0% <0%> (ø)
:arrow_up:

src/util/deploy/process-deployment.ts
0% <0%> (ø)
:arrow_up:

src/util/deploy/create-deploy.js
0% <0%> (ø)
:arrow_up:

src/util/errors-ts.ts
47.48% <0%> (+0.02%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3201227...1b919e8. Read the comment docs.

This should be good to go now. Tests are passing and ready for wider review.


Support angular 1.4.9

It's just about using "angular": "~1.4.8" instead of "angular": "1.4.8"so my project can use e. g. version 1.4.9 without bower complaining about possible version conflicts.
Thank you very much.

Refer to #58 - you can use bower resolutions. Feel free to re-open issues if this did not work.


[Bug] [dolphinscheduler-ui] If the parameters of the query page are modified, requests are sent to the backend all time until whe number of page limit

Search before asking

[X] I had searched in the issues and found no similar issues.

What happened

admin login
search project  name in project page
modify the pageNo parameter to any value (Is greater than 10)
eg http://ip:12345/dolphinscheduler/ui/#/projects/list?pageSize=10&pageNo=70&searchVal=
View page requests and log requests

What you expected to happen
When the user first requests it，response contains the params  totalPage: 7
When the user requests it a second time, the parameter pageNo should be changed to totalPage: 7

How to reproduce

admin login
send a request  to this url  http://ip:12345/dolphinscheduler/ui/#/projects/list?pageSize=10&pageNo=70&searchVal=

Anything else
2.0.1-prepare
Version
2.0.1-prepare
Are you willing to submit PR?

[ ] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

I will handle.

@karen-liu01 Is this the problem?

The problem has been solved and verified


Add more tests for JWT allow_missing_or_failed

Description:
Add more unit tests to demonstrate the status quo behavior of JWT filter with allow_missing_or_failed requirement. Some behavior is arguably incorrect or confusing, though we will try not to fix it in this PR.
Related issues:

https://github.com/envoyproxy/envoy/issues/8909

Risk Level: Low
Adding tests only.
Testing:
Add more unit tests for existing feature.
Docs Changes:
Release Notes:
[Optional Fixes #Issue]
[Optional Deprecated:]

can you fix format and DCO?

can you fix format and DCO?

Done

@lizan , can you re-approve? I think I lost it after a push.


Epic tiger double hit % is wrong

Example: https://sky.shiiyu.moe/stats/CaptainArner/Lemon

Hello h8re! Thank you for the submission. Could you give more detail on the glitch? For example, perhaps what the correct double hit is supposed to be?

Hello h8re! Thank you for the submission. Could you give more detail on the glitch? For example, perhaps what the correct double hit is supposed to be?

A level 100 epic tiger has a 20%. I believe this is supposed to have a 14.8% chance. I'm not sure if it's all epic levels, or just 74, as the legendary ones seem to be correct.

Thank you for the info. Our pet specialists @boblovespi  and @metalcupcake5  will handle this issue :D

This issue is now resolved. Thank you for your cooperation!


Extension is red but no update available. Instead it says "Replaced by..." what do I do next?

When I run the extension updater it lists two of my kexts in red as needing an update. There are no updates but it says each was replaced by a kext that I already have installed (and updated). Do I delete these kexts in red since they are redundant or will it break my system?

When I run the extension updater it lists two of my kexts in red as needing an update. There are no updates but it says each was replaced by a kext that I already have installed (and updated). Do I delete these kexts in red since they are redundant or will it break my system?

which kexts?


Gray out whole (3) if the computation hasn't finished.

If the data is not ready (compute status != complete) then gray out and disable all of step 3, like below

absorbed by #1561


Updated menubar icons and hotkeys

Thanks to Gedeon Maheux for fixing graphics that were driving me a
little crazy.

I'm a total GitHub noob: I had no idea that the commit I just did for the hotkey support would get included in the pull request I made for the menubar icons. There shouldn't be any conflicts: just wanted to let you know why the pull request name doesn't really reflect the changes I'm sending you.

And after squinting at the screen during this morning's Radar extravaganza, a new preference.

I'm a total GitHub noob: I had no idea that the commit I just did for the hotkey support would get included in the pull request I made for the menubar icons.

A GitHub PR is a request to merge a certain branch into a certain other branch. It'll track any additional commits you add to the branch.
I'm happy with all these changes. Especially the modernised hotkeys — I'd started doing that a couple of times, and got annoyed that it was difficult and gave up!


Link to gh-profile on message gravatar.

Had to use shell

Thanks for the PR! Another way to accomplish this would be to wrap in an <a/> tag, like:
h('a', { href: userUrl, target: '_blank' }, h('img.avatar', { src: msg.avatar }))

@shama Tried that first, but the a tag does not seem to open in a new window/browser even with target: '_blank'

@hemanth Ah strange, I thought that worked. Instead of using shell.openExternal here (as that ties this element to the desktop app only), do this instead:
onclick: function (e) {
  self.send('openUrl', userUrl)
}

which should emit the event up until the desktop.js listener catches it to call shell.openExternal: https://github.com/moose-team/friends/blob/master/desktop.js#L29

@shama Neat, thanks, makes much more sense now, have updated it to avoid direct call via shell.

Thanks!

:+1:


Add standard message for resetting the user coordinates on an EpicsMotor

In one of our profiles we have https://github.com/NSLS-II-JPLS/profile_collection/blob/de9bbe0f17ebe6ff951fccb5534f49bc55f7bc77/startup/00-startup.py#L17-L26
async def reset_user_position(msg):
    obj = msg.obj
    (val,) = msg.args

    old_value = obj.position
    obj.set_current_position(val)
    print(f"{obj.name} reset from {old_value:.3f} to {val:.3f}")

RE.register_command("reset_user_position", reset_user_position)

because this particular beamline needs to reset what "0" of some of their (pseudo)-motors means on a regular basis.  Do we want to pull this up to be a "standard" message (pro: I assume that more than 1 beamline will make use of this con: extends the "expected" ophyd API) or ship this co-routine + instructions of how to turn it on?
attn @prjemian .

I am at a +0.5 on adding this to ophyd as optional API on movables. It's a pretty standard thing to do, and we should probably provide a standard way to do it if we don't want plans reaching in and calling obj.set_current_position(...) or whatever directly, breaking the bluesky plan abstraction.
I am going to have opinions about what to call this standard method and associated message (shocking!). :-D There is a lot of ambiguous terminology in this space, and this should be as unambiguous as we can reasonably make it.

In my experience, only a few beamlines use this as routine operations.  Most would prefer this procedure be a bit hard to locate, to prevent inadvertent or misuse.
Instead of making this command so mainstream, consider adding the code above to the ophyd documentation of set_current_position() for those beamlines wanting it as routine.

Also, the name is a bit off.  Suggest we might be repositioning the human when actually the command is to redefine the user coordinate of an EpicsMotor object.

My first reaction to this was "that sounds really useful." Then my second reaction was "I can't think of where I would use it." Very strange.
Either way, this code snippit is a pretty good example of how to add run engine commands that may be useful for fulfilling a beamline's specific needs where there isn't a standard signal to manipulate to get the same effect.

Given that, I move to make this a documented example.

arguable this is covered here (?) https://github.com/bluesky/bluesky/issues/1777
@danielballan  please advise


Update docs for ArangoBackupPolicy CR

Will be ready for review after merging https://github.com/arangodb/kube-arangodb/pull/1321

Closing this in favor of https://github.com/arangodb/docs-hugo/pull/225


Characteristic.CurrentTemperature and negative values

In gen/HomeKitTypes.js the CurrentTemperature characteristic is defined as:
Characteristic.CurrentTemperature = function() {
Characteristic.call(this, 'Current Temperature', '00000011-0000-1000-8000-0026BB765291');
this.setProps({
format: Characteristic.Formats.FLOAT,
unit: Characteristic.Units.CELSIUS,
maxValue: 100,
minValue: 0,
minStep: 0.1,
perms: [Characteristic.Perms.READ, Characteristic.Perms.NOTIFY]
});
this.value = this.getDefaultValue();
};
I have been working on a Homebridge platform that supports temperature sensors, and I found the temperature always read 0.0°C in HomeKit applications when it's a negative temperature.
Negative temperatures in celsius are very common, especially in winter.
I changed the minValue to -100 in HomeKitTypes.h and then it worked !
Characteristic.CurrentTemperature = function() {
Characteristic.call(this, 'Current Temperature', '00000011-0000-1000-8000-0026BB765291');
this.setProps({
format: Characteristic.Formats.FLOAT,
unit: Characteristic.Units.CELSIUS,
maxValue: 100,
minValue: -100,
minStep: 0.1,
perms: [Characteristic.Perms.READ, Characteristic.Perms.NOTIFY]
});
this.value = this.getDefaultValue();
};

@stipus Application should override minValue if the value it tries to display is lower than default minValue. The current min/maxValue are generated from Apple's HomeKit Accessory Simulator.

OK I understand. I'm going to search how to override minValue from the Homebridge platform.

@stipus just do a characteristic.minValue = targetMinValue and it should work :)

Thanks a lot for your fast answers :)
Best regards,
stipus

@stipus do you have an example how to do this dynamically from inside a plugin when it encounters min/max values being exceedee?

I did what KhaosT explained during accessory creation. No problem since then.
Best regards,
stipus

After watching this discussion I made this change to my plugin homebridge-dht and homebridge-mcuiot, and it works fine.  I even did a test run in the freezer with one sensor.  I added the min and max as part of defining the accessory.
            this.temperatureService = new Service.TemperatureSensor(this.name);
            this.temperatureService
                .getCharacteristic(Characteristic.CurrentTemperature)
                .setProps({
                    minValue: -100,
                    maxValue: 100
                })
                .on('get', this.getTemperature.bind(this));


infer command not found

I have installed all the dependencies required for the fb infer on Ubuntu 14.04 LTS. Also I have cloned the latest infer from Git. After compilation and installation of the infer, I am getting error each time saying infer command not found, whenever I am trying to run infer for infer/examples/android-hello project.
I am running command after moving to infer/examples/android-hello project:
infer -- ./gradlew build as said in the document of the infer.
And I am getting error saying "infer command not found".
Also when I am trying to get infer version by running "infer --version", still I am getting the same message "infer command not found".
Can someone help me to resolve this?
This image consist of the error message which I am getting when compilation and installation of the infer.

Hi @kushalsethi. Did you follow the install instructions in install-infer-from-source ?

Thank you! I followed them and got infer running. :)
Can you please tell me if I have one module dependency for my android project and my project's folder structure looks like-
main-project/main-app
main-project/module-dependecny
Where should I run infer command? Do I have to run separately for each folder or only main-app will work?
Thank you!

Hello @kushalsethi,
You should run infer through the build-system used to build your app. The code that will be analyzed will be the one where the build-system invokes the compiler.
If the command to build your app is, for example
./gradlew build

then the command to run the analysis is
infer -- ./gradlew build

Thanks.

Thank you! It worked.


Fix 21292: Link directly to https s3 downloads

Companion PR: dlang/downloads.dlang.org#6

@wilzbach : So do I, but the issue is orthogonal. We currently have users that click on a download link, and get absolutely nothing. Not even a message from Chrome saying "This file couldn't be downloaded because...". It's embarrassing and needs to be fixed yesterday.

@wilzbach : So do I, but the issue is orthogonal. We currently have users that click on a download link, and get absolutely nothing. Not even a message from Chrome saying "This file couldn't be downloaded because...". It's embarrassing and needs to be fixed yesterday.

This didn't work, because the files are stored by year internally, not by release...

This didn't work, because the files are stored by year internally, not by release...


Extensions not working in custom tabs

Describe the bug
Extensions seem to be not working in custom tabs, but work normally in normal tabs, so far tried with the popular extensions: ublock origin and dark reader
To Reproduce
Open any link in custom tab from another app
Expected behavior
Custom tabs should work with extensions
Screenshots
As you can see, dark reader not working

Smartphone (please complete the following information):

Device: Redmi note 6 pro
Android Version : A12L
Kiwi Browser Version  (Tested on both play store vers 101.0.4951.40 and github vers.  101.0.4951.57

Additional context
Add any other context about the problem here.

You use dark reader?

You use dark reader?

Yes as i mentioned in the post

I stumbled across this problem as well, but it's definitely not a general "extensions not working in custom tab" issue.
In fact, I've been successfully running my own userscripts via Tampermonkey for a while now and they all work fine.  This problem only started occurring after I installed uBlock Origin and the Dark Reader both of which are not working in custom tabs.
It seems impossible to debug as a mere user, because the custom tab is exactly that: a single tab. This makes extension pages refer to themselves, which doesn't produce any useful information.
I still noticed something peculiar though. When the full Kiwi app is opened in the background, any uBlock Origin pop-up opened from within the custom tab will refer to the domain of the tab that is currently active in the app. When the app is closed, it will instead refer to itself, I assume because it's the current url of the only Kiwi tab.

I too have this issue, however, some extensions do not work outright and others are broken. It's also an issue when you select "Install App" option to have the webpage open as a separate home screen app.

From what I can tell the issue arises when the webpages are opened in this interface rather than the native browser app.


Could not empty wallet

"thread_name": "AWT-EventQueue-0",
"logger_name": "org.multibit.hd.core.services.BitcoinNetworkService",
"message": "Could not complete the transaction without signing",
"stack_trace": "org.bitcoinj.core.Wallet$CouldNotAdjustDownwards: null
at org.bitcoinj.core.Wallet.completeTx(Wallet.java:3730) ~[multibit-hd.jar:na]
at org.multibit.hd.core.services.BitcoinNetworkService.completeWithoutSigning(BitcoinNetworkService.java:902) [multibit-hd.jar:na]
at org.multibit.hd.core.services.BitcoinNetworkService.prepareTransaction(BitcoinNetworkService.java:765) [multibit-hd.jar:na]
at org.multibit.hd.ui.views.wizards.empty_wallet.EmptyWalletWizardModel.prepareTransaction(EmptyWalletWizardModel.java:280) [multibit-hd.jar:na]
at org.multibit.hd.ui.views.wizards.empty_wallet.EmptyWalletWizardModel.showNext(EmptyWalletWizardModel.java:118) [multibit-hd.jar:na]

Looks like the wallet didn't have enough funds to allow it to be emptied. We'll need a warning for this.

Presuably caused by too much dust

BitcoinNetworkService has already had it's error handling tweaked so that:

the error is logged but no stacktrace is printed
the user gets a useful message.

Nothing to do so closing.


Fix the VIEW_INFORMATION checkbox not being selected (visually)

Generated id of "Display Advanced..." was in conflict with "View Information"

Thanks!

Removing cherrypick label, this changed 4.0-specific code.


feat: add components to calcite map sample

Summary
Updates the map-calcite-widgets.html sample to include map components with calcite.

cc @bsvensson merging to main 🌟


Disk initialized by Windows not listed by Hackintool

Disk is partitioned with a small EFI partition and large NTFS partition. It is recognized by Diskutil
/dev/disk0 (internal, physical):
#:                       TYPE NAME                    SIZE       IDENTIFIER
0:      GUID_partition_scheme                  *1.0 TB     disk0
1:       Microsoft Reserved                        16.8 MB    disk0s1
2:      Microsoft Basic Data Projects         1.0 TB     disk0s2
Priority is -10

Is it shown in Hackintool? Can you take a screenshot?

It’s not shown in Hackintool in the top window, but is in the detailed list. it’s disk2. So it’s not as bad as I reported, for which I apologize.
Skip

On Mar 29, 2020, at 5:03 PM, headkaze<EMAIL_ADDRESS>wrote:
Is it shown in Hackintool? Can you take a screenshot?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/headkaze/Hackintool/issues/77#issuecomment-605701064, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABL6DGZXIXSBUTQ76ROQOSDRJ6ZQNANCNFSM4LWDFAZQ.

Is it an EFI parition because it should be in the top list if it is?

Yes, the details are correct in the bottom part of the list. I also have an SSD where the EFI partition is second on the disk, and that disk is detected and displayed. Normally the EFI partition is 200 MB if macOS partitions it.

On Mar 29, 2020, at 7:11 PM, headkaze<EMAIL_ADDRESS>wrote:
Is it an EFI parition because it should be in the top list if it is?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/headkaze/Hackintool/issues/77#issuecomment-605716537, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABL6DG77L4BZBPQTRLQFANDRJ7IQZANCNFSM4LWDFAZQ.

on the list, it shows up as Microsoft Reserved.

On Mar 29, 2020, at 7:11 PM, headkaze<EMAIL_ADDRESS>wrote:
Is it an EFI parition because it should be in the top list if it is?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/headkaze/Hackintool/issues/77#issuecomment-605716537, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABL6DG77L4BZBPQTRLQFANDRJ7IQZANCNFSM4LWDFAZQ.

How did you create your EFI partition? To be identified as EFI in Hackintool the media content UUID needs to be "C12A7328-F81F-11D2-BA4B-00A0C93EC93B". Microsoft Reserved is "E3C9E316-0B5C-4DB8-817D-F92DF00215AE".
You can use diskpart in Windows with the following command to create an EFI parition:
create partition efi size=200
format quick fs=fat32 label="System"

diskpart
list disk
sel disk N
clean
convert gpt
create part primary
format fs=ntfs quick label=Projects
exit
convert gpt  creates a small partition which the BIOS interprets as being an AHCI disk
if I then do create part efi it creates the partition as the second partition on the disk.
Disk 1 was created by windows and the EFI partition is partition 2
Disk 2 is not a bootable disk, so I don’t need a large EFI partition.
I have another disk I can play with. I’ll try leaving out the convert gpt and see if your suggestion works.
It isn’t a biggie; I was just surprised that the list didn’t agree with diskutil.
You have an excellent program; Nuke #77 and I’ll refile if I can't find a solution that keeps Windows happy, macOS happy and Hackintool happy.
Thanks,
Skip

On Mar 29, 2020, at 8:06 PM, headkaze<EMAIL_ADDRESS>wrote:
How did you create your EFI partition? To be identified as EFI in Hackintool the media content UUID needs to be "C12A7328-F81F-11D2-BA4B-00A0C93EC93B". Microsoft Reserved is "E3C9E316-0B5C-4DB8-817D-F92DF00215AE".
You can use diskpart in Windows with the following command to create an EFI parition:
create partition efi size=200
format quick fs=fat32 label="System"
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/headkaze/Hackintool/issues/77#issuecomment-605723321, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABL6DG5YVEADNNCVIKFRTUDRJ7PATANCNFSM4LWDFAZQ.

I dual boot Windows and macOS and this is how I created my partitions:
1. Run Windows Setup
2. Press Shift+F10 for Command Prompt
3. Run 'diskpart'
4. Run the following commands:
list disk
select disk #
clean
convert gpt
5. Create UEFI system partition (ESP). Type the following:
create partition efi size=200
format quick fs=fat32 label="System"
6. Create MSR partition. Type the following:
create partition msr size=128
7. Exit diskpart and select the empty partition and select New
8. Reboot into macOS
9. Run Disk Utility
10. Split the partition in half
11. Install macOS in the first partition
12. Install Windows 10 in the second partition

Thanks, I’ll try that.  I converted GPT, added 200MB EFI partition and a primary NTFS partition. Works fine.
I also partitioned the disk in macOS: diskutil formatDisk diskN 1 gpt exfat  100%; then used disport in Windows to formatthe partition as NTFS.
Just another way of skinning the cat. Thank you for setting me on the right path.

On Mar 29, 2020, at 9:00 PM, headkaze<EMAIL_ADDRESS>wrote:
I dual boot Windows and macOS and this is how I created my partitions:

Run Windows Setup
Press Shift+F10 for Command Prompt
Run 'diskpart'
Run the following commands:
list disk
select disk #
clean
convert gpt
Create UEFI system partition (ESP). Type the following:
create partition efi size=200
format quick fs=fat32 label="System"
Create MSR partition. Type the following:
create partition msr size=128
Exit diskpart and select the empty partition and select New
Reboot into macOS
Run Disk Utility
Split the partition in half
Install macOS in the first partition
Install Windows 10 in the second partition
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/headkaze/Hackintool/issues/77#issuecomment-605731400, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABL6DG5M3BRVSIA47QPCQC3RJ7VLNANCNFSM4LWDFAZQ.


Update software.txt

Added Domino REST API 1.0.12

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Hi @sbasegmez!
Thanks for your request!
Usually changes are going into the develop branch first, before merging them into main.
software.txt changes are kind of special and I think it would be time to add another software branch to be able to push software faster into the main branch, when we have pending changes in the develop branch.
Also all changes need to pass the automation test, which I am running usually first on new software before merging them.
The changes you are pulling in are already in the develop branch. But we have other pending changes.
Because I am submitting 95% of the content, we have no bigger branch management. But software.txt and current_version.txt are special cases.
I don't want to block new software because of pending changes in the develop branch where we want others to test, before we merge them into main.
I will just merge my changes including the software.txt and current version file.

I merged the develop branch to main. But I will look into a better way managing the software.
What I would like to do in the long run is to use software.jwt from Domino autoupdate.
But it does only contain Notes, Domino and Traveler.

Did you know you can use your own version of software.txt and current_version.txt  stored in an external software directory specified by SOFTWARE_DIR or DOWNLOAD_FROM.
This allows you to bring up a newer version of the files.
For Git repo reasons I need to revisit again, the files are stored twice. we need it to check the software before starting the build process and the build container also needs it to validate the hashes.

Hi Daniel,
Normally, I don't need to upgrade to the latest release immediately. This version of DRAPI was an exception. I learned how to do it now. I agree. There should be a better way to handle this in the future but having the chance to override it manually is enough for now.
Thanks for resolving the issue.

You can make any change to the software.txt.
Currently the GitHub project is the gatekeeper for the software.txt and if we would move it to a different place, this would make it more complicated.
This way you only need the project and no external connection.
We would need a place where we store the software.txt.
For the HCL software.jwt this is a signed file provided by HCL on one of their servers.
The community project is using GitHub.
It's customizable today by having your own version and we are usually pushing the changes out quick.
I will bring this up again to see how we could improve it.
But this comes from the very early days of the repository when Thomas started it and we can't quickly change it without introduces changes for existing users.
We could offer new options, but they would need to be secure.
What I would really like would be a software.jwt with all software and a public key we could use to validate it.
I did hear that at Engage from a couple of admins having the public key available for domdownload to validate software after download on top of just having the SHA256 in software.txt .
Also we have some additional software listed. For example Borg Backup and Tika.
They are listed with their hashes to ensure you get the validated versions.
That's clearly a community offering and not a direct HCL offering.
So for now I think it is best to stay with software.txt and provide the option to modify it.


Option numericOnly doesn't work on it's own

Is it intended that numericOnly doesn't work when it's the only option supplied? I would expect that any non number keypress would still be suppressed regardless of other options. ex:
var cleaveNumeral = new Cleave('.input-numeral', {
    numericOnly: true
});

Here's a fiddle displaying the experience:
https://jsfiddle.net/br8dy/pcttaqeb/2/
Possible solutions:
a. suppliying a true value to numericOnly would suppress non number keypresses even when it's the only option supplied.
b. update documentation to explain which options will respect the numericOnly value
Thanks for the clarification

Thanks @matbrady I went with the option b.
https://github.com/nosir/cleave.js/blob/master/doc/options.md#numericonly
Just saying, if numericOnly is the only option in the user case, it doesn't cleave anything :)

@nosir thanks for the clarification and update!


append new IAP receipt fields

Codecov Report

Merging #38 into master will decrease coverage by 5%.
The diff coverage is 16.66%.

@@         Coverage Diff          @@
##           master   #38   +/-   ##
====================================
- Coverage     100%   95%   -5%
====================================
  Files           3     3
  Lines         189   200   +11
====================================
+ Hits          189   190    +1
- Misses          0     8    +8
- Partials        0     2    +2

Impacted Files
Coverage Δ

appstore/validator.go
85.71% <16.66%> (-14.29%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c46ab73...2eb7bcf. Read the comment docs.

Auto-renewable subscription notifications....
https://developer.apple.com/library/content/documentation/NetworkingInternet/Conceptual/StoreKitGuide/Chapters/Subscriptions.html#//apple_ref/doc/uid/TP40008267-CH7-SW16

@sanae10001
Thanks a lot :-)


create mixin for .form-inline

Move code from .form-inline class into .form-inline-layout() mixin in
less/mixins/forms.less so it can be safely used in less/navbar.less
Refs #19430

Please exclude the dist/ and docs/ files from your pull request.

Reverted dist/ and docs/. Sorry about that :)

@andreiduca: please also squash the patches.

I'm inclined to punt on this for v3 as it's more than a critical bug fix—it's an architectural change that adds a new mixing and moves code across files.

Closing per @mdo.


fix(grpc msg max): removes grpc msg max size

allows for larger messages to still be sent/received
fixes getumbrel/umbrel#1245

Solution taken from bosworth's lightning library: https://github.com/alexbosworth/lightning/blob/master/lnd_grpc/authenticated_lnd_grpc.js#L57

Legend.