Swift 6 concurrency warnings

Given containers like such on Factory 2.3.2:
public final class CoreContainer: SharedContainer {
     public static let shared = CoreContainer()
     public let manager = ContainerManager()
}

With Swift 6 complete concurrency we get the following error Class property 'shared' is not concurrency-safe because non-'Sendable' type 'CoreContainer' may have shared mutable state.
Is Factory up-to-date with concurrency yet?

https://github.com/hmlongco/Factory/discussions/210

Any plans to release a version that's compatible with Xcode 16?

Also FYI that branch still doesn't solve the problem that Factory isn't Sendable, leading to errors like this:
enum Container {
  @MainActor
  static var instance: Factory<SomeType> {
    self {
      .init()
    }
  }
}

func someAsyncMethod() async {
  // Non-sendable type 'Factory<SomeType>' in implicitly asynchronous access to main actor-isolated property 'instance' cannot cross actor boundary
  let dependency = await Container.instance()
}

Assume you meant what???
extension Container {
  @MainActor var instance: Factory<SomeType> {
    self { .init() }
  }
}

Can't create static Factory's.
But check out the pinned issue on async Factory's. https://github.com/hmlongco/Factory/issues/211
Factory can't be Sendable without enforcing that T is Sendable, and..
a) Not every type will be Sendable
b) Enforcing Sendable would break a ton of existing code.

Sorry that was a bad example. I did mean this inside Container.
How about:
extension Factory: Sendable where Element: Sendable {}

Any plans to address this?


Add support of audio transformers

This PR proposes an integration of audio transformers into outlines framework (#1270)

Hey @rlouf 🙋♂
I'm not sure, but it seems that the runner disk is full and qwen2-audio files are taking a bit too much space, I can try to find a gguf version or maybe a smaller model? Wdyt?

We generally use HF's internal testing models which are much smaller, see the other tests. Can you try to find if there is one for audio?

Hey @rlouf
I updated test_generate_text
I have 95% coverage, the missing parts are in case of import errors (not sure we want to modify the test env to have the coverage) or processor with no tokenizer, to what extend do you want to increase the coverage?
Otherwise good for review on my side


Pytanque installation fails on Ubuntu 14.04

Hi,
I'm trying to install branch feature/exprs of Arybo and I'm getting the following error when I run the command to install pytanque: sudo pip install pytanque
Command "/usr/bin/python -u -c "import setuptools, tokenize;__file__='/tmp/pip-build-3EsubV/pytanque/setup.py';exec(compile(getattr(tokenize, 'open', open)(__file__).read().replace('\r\n', '\n'), __file__, 'exec'))" install --record /tmp/pip-nseUJr-record/install-record.txt --single-version-externally-managed --compile" failed with error code 1 in /tmp/pip-build-3EsubV/pytanque/
Any ideas of how I could get passed this error or successfully install pytanque?
Thanks,
Sebastian

Hello Sebastien,
"pip install pytanque" will install the stable version of pytanque uploaded on Pypi (this one https://pypi.python.org/pypi/pytanque/0.2.0), which should work with the feature/exprs version of Arybo.
The error you have is thus independent of this experimental branch and seems to be related to your Python installation. Which version of Python are you using ? Is this 32-bit or 64-bit ubuntu ?
Thanks :)

Thanks for you quick reply! I'm using Python 2.7.6 on a 64-bit Ubuntu.

Okay ! Can you please try to reproduce this inside a virtualenv :
$ sudo apt-get install virtualenvwrapper
(reload your terminal then)
$ mkvirtualenv arybo-exp
$ workon arybo-expr
(arybo-exp) $ pip install pytanque
(arybo-exp) $ cd /path/to/arybo && python ./setup.py install

I've reproduced the issue in a virtualenv and attached the log of the last command.
error-log.txt

Thanks ! This is a much better error message :)
It seems that the GCC compiler on Ubuntu 14.04 is too old and does not support C++14.
One workaround is to install a recent version of Clang using the official LLVM APT repositories here:
http://apt.llvm.org/ .
In a nutshell, add deb http://apt.llvm.org/trusty/ llvm-toolchain-trusty-3.9 main to your /etc/apt/sources.list , then update apt (sudo apt-get update) and install clang-3.9 (sudo apt-get install clang-3.9).
You can then install pytanque using CC=clang-3.9 CXX=clang++-3.9 pip install pytanque .
Let me know if this solves your problem!

Thanks for your suggestion! Unfortunately, it seems that the following symbols are missing in clang-3.9 gets, insert, emplace (see attached error log). Any other suggestions?
error-log2.txt

Okay the C++ library (listdc++) is also too old... :/
Try to install the paquets libc++-dev and libc++abi-dev and relaunch the installation.
I'm sorry I don't have any 14.04 ubuntu VM right now. If this doesn't work, I'll try to find a way tonight (in a few hours) !

Unfortunately, it doesn't work even after installing the two packages you mentioned. Thanks for your help!

Okay i've got a solution thanks to @romainthomas !
We can install gcc 6.0 and the associated uptodate libstdc++ under Ubuntu 14.04 using a PPA;$
$ sudo add-apt-repository ppa:ubuntu-toolchain-r/test
$ sudo apt-get install g++-6

and then install pytanque like this:
$ CC=gcc-6 CXX=g++-6 pip install pytanque

Thanks a lot! That worked! Note that you also have to run sudo apt-get update after the first command.

Okay nice :) I'll keep this one open 'till the documentation is updated for this!


ROX-17743: Delete ROX_POSTGRES_DATASTORE in Policy Categories UI

Description

deprecating our Postgres feature flag

Checklist

[ ] Investigated and inspected CI test results
[x] ~Unit test and regression tests added~

Testing Performed

yarn lint in ui
yarn build in ui
yarn start in ui

Manual testing

Expand Platform Configuration, and then click Policy Management.

See Policies and Policy categories tabs.

Click Policy categories.

See GET /v1/policycategories request

Click Create category, type Created category, and then click Create.

See POST /v1/policycategories request.
See GET /v1/policycategories request.

Click Policies, and then click a policy link.

See selected policy category.

Click Actions, and then click Edit policy.

See created policy category in select drop-down list.

Click Cancel, click back, click Create policy, use Created category.

See created policy category in dry run results.

Click Save.

See create policy category in payload of POST /v1/policies request.

/retest


send ctrl+c event to DUT serial port

In order to cancel any commands in DUT serial port, implemented sending ctrl+c event through input form.
In addition, li element in messages to make it visible even if the content is empty.

I fixed to "early return"!

defined constant value & move it to the top of index.ts


Update rc6

Coverage remained the same at 100.0% when pulling f7aa81a434a62ef472be8e23c55dc5f110e79d7d on update-rc6 into 5e32b2f7a7a18543b4cd596e2f2453639929a3ed on master.


refactor: improved workflow env vars

#253  👈
develop

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @bob-obringer and the rest of your teammates on  Graphite


Set-CsCallQueue  could not truncate  channelId

Hi All ,
Env:

trying get callQueue channelId

then  try to truncate  this channel from the callQueue throw an exception  as below

But when I try with   Rest    via   current authentication  token , then it works.

In  api this field name ThreadId  but we can just see in powershell module as ChannelId    I think something wrong  in MicrosoftTeams Module .
Any idea ?

Another issue about Set-CsCallQueue when  remove call answering  user relation via powershell  MicrosoftTeams.
when I try remove user via Admin.teams.microsoft.com    I can see   api request in fiddler.

then

but when I try same thing  in  powershell core or  windows powershell  get an exeption  as below

Powershell Core

windows Powershell

old version  of Microsoft Teams   was working but  >4.2.0  does not .
Where am I going wrong?
thx for help

I test  on 4.4.1 with pwsh 7.2.4    both of them  worked   I  made  reset  channel with  -ChannelId ''    and  -Users @()  .
It is working .
Thanks.


small README code highlight update

Thanks for submitting this @pushthat, the docs site has moved to https://rancher.com/docs/k3s/latest/en/, please review and submit any changes there.


HH serial number

Ordered two RD200, both have a HH serial number. Added to config_flow.py and both were found. Wouldn't it be better to check the serial number if it contains FR: , then fetch the model number and check if its a RD200v2 instead of checking the first two chars of the serial number?
Thanks for providing this nice integration :)

Probably would be easier, but I am worried it will find extra devices on the network. I'll add HH


Additional troubleshooting steps

Hi, can you add some more troubleshooting steps to this page?
We were running this command:
auditpol.exe /set /subcategory:{0CCE9222-69AE-11D9-BED3-505054503030} /failure:enable /success:enable
and it kept reverting even though the ADFS service was allowed to generate audits per Group Policy.
We had to also set this (after a call to Microsoft support)
In the Group Policy Management Editor, go to Computer Configuration > Policies > Windows Settings > Security Settings > Advanced Audit Policy Configuration > Audit Policy.
Double-click on Object Access.
Right-click on Audit Application Generated in the right pane. Select Properties, then check the boxes next to Success and Failure.
many thanks

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: eb5cf254-9d8e-de7a-30e8-487b68205bc2
Version Independent ID: 28bc66e2-0de2-73e6-8cb8-243daab81628
Content: Install the Connect Health agents in Azure Active Directory
Content Source: articles/active-directory/hybrid/how-to-connect-health-agent-install.md
Service: active-directory
Sub-service: hybrid
GitHub Login: @billmath
Microsoft Alias: billmath

@tim-reading-bzy
Thanks for your feedback! I've assigned this issue to the author who will investigate and update as appropriate.

Thank for submitting this. I have created a work item for it and will reviewing this in the coming weeks. I am not sure what the timeline will be, so I am going to close this for now. But once I have an update I will drop it in here and let you know.
Thank you!
Bill
#please-close


[Bug]: Facing error while using get_nodes fn in AISearch db

Bug Description
Hi,
We are facing below error while using get_nodes() fn in AISearch db.
azure.core.exceptions.HttpResponseError: () Invalid expression: 'embedding' is not a retrievable field. Only fields marked as retrievable in the index can be used in $select.
Parameter name: $select
Code:
Message: Invalid expression: 'embedding' is not a retrievable field. Only fields marked as retrievable in the index can be used in $select.

Although, we have resolved this issue from AISearch end but, could you pls provide a way to achieve same at llamaindex end?
Version
0.11.6
Steps to Reproduce
NA
Relevant Logs/Tracbacks
No response

yes, have built index using llama-index only:
vector_store=AzureAISearchVectorStore(
                search_or_index_client=index_client,
                filterable_metadata_field_keys=filterable_metadata_fields,
                index_name=INDEX_NAME,
                index_management=IndexManagement.CREATE_IF_NOT_EXISTS,
                id_field_key="id",
                chunk_field_key="chunk",
                embedding_field_key="embedding",
                embedding_dimensionality=1536,
                metadata_string_field_key="metadata",
                doc_id_field_key="doc_id",
                language_analyzer="en.lucene",
                vector_algorithm_type="exhaustiveKnn",
            )

but, it is making embedding field as non-retrievable only by default.


async_std::sync::Mutex is too heavy

I've noticed that async-std uses std::sync::Mutex in quite a few places. It's well known that parking_lot offers much better performance, and more noticeably space saving, compared to the std mutex, thus enabling very fine-grained locks.
The current async_std::sync::Mutex and other few places of async_std seems to be using std::sync::Mutex, which has quite a few allocations and is very heavy-weight. Is there any existing discussion about performance and code bloat impact of switching over to parking_lot?
There is also a probability that we can use ideas similar to parking_lot to create a very cheap and light-weight (i.e. only a few bytes, no extra allocation) async Mutex that optimises for non-contended cases.

Perhaps we could reuse Spinlock from crossbeam-channel?

I did a few experiments, and I think I got an idea that can reduce async_std::sync::Mutex to the size of usize and makes it allocation-free when there isn't contention.
Here's the brief list of my plan. If you think it looks alright, I'll proceed to implementation and benchmark the performance differences.
Step 1: Replace Slab with a double linked list

insertion/removal into/from the slab is replaced with linked list insertion/removal.
replace the item in the slab is replaced with a direct write to the list node.
benefits:
** slab does not shrink itself, while linked list is.
** as we don't need to know the length of waker list, only if it's empty, we reduce size requirement of blocked to 16 bytes (from 40 bytes for slab) plus Mutex overhead.

Step 2: Replace doubly linked list with single linked list

disallow non-list-head to acquire the lock. Note that the current unlock code only wakes the first item in the iterator, so it won't deadlock. This will actually give the Mutex a bit of extra fairness.
now we no longer need to remove arbitrary elements from the queue, so we can change doubly linked list to single linked list, reduce blocked (which will be the linked list head pointer) to 8 bytes plus Mutex overhead.

Step 3: Pack everything into an AtomicUsize

we can use the lowest 2-3 bits of the linked list head pointer to replace the LOCKED, BLOCKED and the Mutex, so packing everything into the same AtomicUsize.

After all steps the size of Mutex<()> will reduce from 64 bytes to 8 bytes, free to construct and destruct.

Do we allocate nodes for the linked list on the heap? If so, I am worried that these allocations will be slower than using the slab.
Another possibility is to lazily allocate the slab on the heap only when it is actually needed (i.e. there is contention on the async mutex). We could even put the address of the slab into state while using the lowest 2-3 bits for other stuff.

The linked list nodes are allocated on the heap, for the benefits of a stable address. Linked list has an extra benefit of guaranteed O(1) insertion/removal (slab uses Vec, which is amortised O(1)), and O(1) to get an item from the list (get an item from slab have O(n) complexity). Slab also does not shrink itself (and it is difficult for us to decide when to shrink them), so the worse case space complexity will be O(num of task * num of Mutexes). Linked lists have a worse case space complexity of O(num of tasks).
From my initial experiments, performance actually goes up slightly by using linked lists, despite the allocation.

Interesting! Okay, I'm convinced :) On another thought, there must be tricks for optimizing allocations in the typical case so I'm not worried as much anymore...
I'd be happy to review a PR that replaces slab with linked lists.
Also, it would be great to have your experiments as microbenchmarks using #[bench].

I did a few experiments, and I think I got an idea that can reduce async_std::sync::Mutex to the size of usize and makes it allocation-free when there isn't contention.

Do we allocate nodes for the linked list on the heap? If so, I am worried that these allocations will be slower than using the slab.

The linked list nodes are allocated on the heap, for the benefits of a stable address. Linked list has an extra benefit of guaranteed O(1) insertion/removal (slab uses Vec, which is amortised O(1)), and O(1) to get an item from the list (get an item from slab have O(n) complexity). Slab also does not shrink itself (and it is difficult for us to decide when to shrink them), so the worse case space complexity will be O(num of task * num of Mutexes). Linked lists have a worse case space complexity of O(num of tasks).
From my initial experiments, performance actually goes up slightly by using linked lists, despite the allocation.

If you just use futures_intrusive::sync::Mutex you get your parking-lot backed small mutex without any need for heap allocations - and even without the need to write the code yourself :-)

Perhaps we could reuse Spinlock from crossbeam-channel?
https://github.com/crossbeam-rs/crossbeam/blob/30f5d8b0a0cd6ea5923b771ce6c75834a1e44bec/crossbeam-channel/src/utils.rs#L64-L112
I'd accept a PR that switches from Mutex to Spinlock.

Btw: I would be super careful with pure Spinlocks in userspace. If the OS schedules away the thread which holds the lock you will start wasting a ton of resources and enter the wonderful world of priority inversions. IMHO they are a tool for Kernels and embedded applications. For normal userspace applications one should fallback to a Kernel wait primitive after some spins, or just avoid them in general.

If you just use futures_intrusive::sync::Mutex you get your parking-lot backed small mutex without any need for heap allocations - and even without the need to write the code yourself :-)

I looked at the code, I think the basic idea is the same. However using that will pull in a large amount of dependencies, which this project tries to avoid. My PR also does better than the code you refers to, so I don't see the point switching to that.

Yes, it's literally a HUGE amount of dependencies 😀

Btw: I would be super careful with pure Spinlocks in userspace. If the OS schedules away the thread which holds the lock you will start wasting a ton of resources and enter the wonderful world of priority inversions. IMHO they are a tool for Kernels and embedded applications. For normal userspace applications one should fallback to a Kernel wait primitive after some spins, or just avoid them in general.

That's true, and my benchmarks show that naively changing everything to spinlock causes 4x performance degradation. However after changing from Slab to a linked list, we only spend very small amount of time in the critical region, and benchmark shows a similar (and slightly better) performance when compared with the current state.
FYI, crossbeam's Spinlock also has a back off policy which will yield to other threads if it cannot acquire the lock in a few spins.

Yes, it's literally a HUGE amount of dependencies 😀

If you see #252 you will notice that parking-lot is explicitly removed as a dependency from this project.

Reducing deps is all well and good, but it doesn't make much sense to end up writing and maintaining equivalent code here when the potential dependency is of good quality and maintained.

For reference, these are our current async_std::sync::Mutex benchmarks:
test contention    ... bench:     893,650 ns/iter (+/- 44,336)
test create        ... bench:           4 ns/iter (+/- 0)
test no_contention ... bench:     386,525 ns/iter (+/- 368,903)

This is futures_intrusive::sync::Mutex with default Cargo options and with is_fair set to false:
test contention    ... bench:   1,968,689 ns/iter (+/- 303,900)
test create        ... bench:           8 ns/iter (+/- 0)
test no_contention ... bench:     431,264 ns/iter (+/- 423,020)

This is tokio::sync::Mutex:
test contention    ... bench:   2,614,997 ns/iter (+/- 167,533)
test create        ... bench:          24 ns/iter (+/- 6)
test no_contention ... bench:     516,801 ns/iter (+/- 139,907)

This is futures::lock::Mutex:
test contention    ... bench:   1,747,920 ns/iter (+/- 149,184)
test create        ... bench:          38 ns/iter (+/- 1)
test no_contention ... bench:     315,463 ns/iter (+/- 280,223)

There is some variance to these numbers between consecutive runs, though.

@stjepang Are the sources of these benchmarks available somewhere?
Is it the ones of #370? If yes then I think the "contention" benchmarks do only a part of what the name says. It is only about contention within a single-thread, but cross-thread synchronization will never have an impact. In that kind of benchmark likely futures_intrusive::sync::LocalMutex would be blazing fast due to eliding synchronization.

If I'm reading the code correctly, it looks like locking Tokio's Mutex requires no heap allocations even when it's contended.
The idea is that the future returned by Mutex::lock can itself be a member of an intrusive linked list of tasks waiting for the mutex. It seems like only the waker from the most recent poll of a given lock future is retained, which seems odd to me, but I could be misreading.

@stjepang Can you add in the benchmarks using your async-lock crate as well?  I know that you've got two different crates (async-mutex and async-lock, which appear to be forks of one another), and that this crate uses async-mutex, but I wanted to know if you've made some speed ups in one vs. the other.  Basically, I want to know which of those crates I should be using in the future.


module not found error

After installing a new module with npm install <module> --save the platform still cannot find the module.
Try out:
rm -rf node_modules and then npm install
OR
docker-compose down -v and then sudo docker-compose up
@NJaku01 Do you have similar issues?

Yes, I also had this problem some times. With me sudo docker-compose up --force-recreate helped.

@MarkusKonk We can close this, right?

@NJaku01 Please make sure that the developer documentation in the README includes your workaround, then close this.


[MRESOLVER-148] Use latest vanilla Guice4, no need for for forked one anymore.

https://issues.apache.org/jira/browse/MRESOLVER-148
Depends on https://github.com/apache/maven-resolver/pull/79
The commit from PR 79 will go away once that PR is merged.

Going through...

Updated to leave only meaningful changes (as dependant PR was merged), sorry if this force push messed you up, but wanted to prep it for clean merge.

No issue, I did cherry-pick the relevant commit anyway.


Options to change Teams channel Ask an Expert and Share feedback

How do we change the Teams channel - one for Ask an Expert and another for Share feedback?
Because we have only one option in Config app for Teams ID which is used by both options - Ask an expert and Share feedback.

Currently the app is configured in such a way that it posts both the query and feedback in General channel of team only. The feedback cannot be shared in separate channel.

Thank you for reporting this. For FAQ Plus repository, we are currently only making changes to fix critical bugs or deployment failures. Please consider forking the repository to implement your improvement and post back here if you're successful.


Drawer opacity

Hi,
i would like to ask about the Drawer component and opacity attribute that is added when component has active state. I don't want this effect in my application, so i started to look for a way to remove it.
I tried to use toolbox-loader to define my own theme. I found a global variable $color-overlay-opacity in _global.scss file. This is my theme file:
$color-overlay-opacity: 0 !default;

Unfortunately this way doesn't work, so I started to look around why, and I found that this variable is never used in any component.
What is more, I found that Overlay component that is used in Drawer has a default prop opacity set to 0.5. I think that it would be nice to be able to set this value by prop in Drawer or variable in my own theme.
Please tell me what do you think about it, or let me know if there is some other way to set this value :)

Yeah, we missed this. Initially the drawer has its own overlay so it was able to set the opacity. Then we put an opacity attribute directly in the Overlay component. I'm moving it to a CSS attribute so you can override it by SCSS which so easy.
Labeled as bug and resolving asap.
Thanks! :)

Thank you! :)


bootrom

when compile with top level .v, it is missing module BootROM rom

Assuming you executed the following step to generate the verilog:
"make -f Makefile.vc707-u500devkit verilog"
I believe the bootrom source code is actually compiled when you execute:
"make -f Makefile.vc707-u500devkit mcs"


Bug in azure-storage-blob

As shown in model serialization for ContentSettings， the required type for content_md5 is str as shown below:
https://github.com/Azure/azure-sdk-for-python/blob/00c9044986e1bb35f7d2be0deb5935b5342ae1a7/sdk/storage/azure-storage-blob/azure/storage/blob/_models.py#L621
But when uploading, content_md5 needs to be converted to bytearray and the following code would cause a bug when converting a string to bytearray.
https://github.com/Azure/azure-sdk-for-python/blob/00c9044986e1bb35f7d2be0deb5935b5342ae1a7/sdk/storage/azure-storage-blob/azure/storage/blob/_blob_client.py#L382
blob_content_md5=bytearray(content_settings.content_md5) if content_settings.content_md5 else None,
TypeError: string argument without an encoding

This would cause error when uploading with content_md5. Please fix asap.

Hi, I'm new to this. I searched online for this issue and I found out that the bytearray() function needs a second argument specifying the type of encoding required when the source is a string. I hope this solves this issue.

https://github.com/Azure/azure-sdk-for-python/issues/13003


Bootstrap 4.0.0-alpha3 .tag class breaks WordPress

When using the new .tag class in WordPress, it is conflicting with the post tag class names applied to a lot of WordPress elements like the body class, hentry etc.
It just won't work on WordPress.
Any work around on this?
Thanks!

Probably the easiest way is to remove/rename the .tag class in WP. You can do so by using the body_class filter.

And that is a bad WP practice.
body_class(), post_class() and probably more than I know add the .tag class to elements.

It's been a long time since I worked with Wordpress—is there a list of used classes in the default theme(s) we should avoid?

Here's a good article with possible classes:
http://www.wpbeginner.com/wp-themes/default-wordpress-generated-css-cheat-sheet-for-beginners/
On Monday, 22 August 2016, Mark Otto<EMAIL_ADDRESS>wrote:

It's been a long time since I worked with Wordpress—is there a list of
used classes in the default theme(s) we should avoid?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/twbs/bootstrap/issues/20542#issuecomment-241288247,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACCMSEdERwXN_7MK-GJshvEXloOH6qjoks5qiNuygaJpZM4Jom2V
.

I loved the idea behind .tag but it would bring unnecessary breakage to wordpress projects if that is the case.  Maybe the class can be changed to .bs-tag or simply left as .label despite the readability concerns with the html  tag.  Personally, i've never had any readability issues with .label classes and  tags because they're typically used in different contexts.
Click me
<input type="text" id="username">

Gymnasium
#19094
@guylepage3
@cvrebert

I think WP uses this only on the body tag (not 100% sure). Perhaps a rule to not have .tag apply to the body would address all issues?
.tag:not(body) { // bs tag css }

https://jsfiddle.net/cyberwombat/yg4s5txs/1/

@gilronc it appears that wordpress is using .tags and not .tag.
Furthermore, they are also recommending to add use the .tag class to include a secondary descriptor such as;
.tag-[name]

https://codex.wordpress.org/Function_Reference/post_class
https://wordpress.org/support/topic/adding-tagcategory-name-as-css-class-in-query
https://github.com/twbs/bootstrap/issues/19094
@mdo
@cvrebert

@cyberwombat Not only the body, but also post entries. What if someone has success as a post tag? Then an entry would be assigned the tag-success class which will make the background green.
@guylepage3 a snippet from WordPress 4.6
} elseif ( is_tag() ) {
	$tag = $wp_query->get_queried_object();
	$classes[] = 'tag';
	if ( isset( $tag->term_id ) ) {
		$tag_class = sanitize_html_class( $tag->slug, $tag->term_id );
		if ( is_numeric( $tag_class ) || ! trim( $tag_class, '-' ) ) {
			$tag_class = $tag->term_id;
		}

		$classes[] = 'tag-' . $tag_class;
		$classes[] = 'tag-' . $tag->term_id;
	}
}

There it adds the .tag class to the body.

@maimairel  tag-success requires the tag class to be present. We can modify the css to be:
.tag.tag-success { ...  }

As WP only uses .tag in the body tag and we prevent .tag from affecting body as mentioned earlier.
https://jsfiddle.net/cyberwombat/yg4s5txs/2/
Does that address the WP use cases?

.tag or .tags are pretty generic and may cause conflicts......i really like .label.  Either one will work though.  My main development platform is Drupal so i won't really encounter any conflicts with Bootstrap's css.  I'm using Bootstrap 4 and 3 currently to develop a Drupal 8 theme.  Other frameworks typically use prefixes to solve the problem eg: bs-tag instead of .tag.  The problem with prefixes is that it can cause code bloat pretty quickly, imagine prefixing cards, tables, alerts etc( .bs-cards, .bs-tables, .bs-alerts ).  Maybe the wordpress conflicts can be resolved quickly by themers who are capable of
sub-theming the core wordpress themes and adding their own classes or removing the defaults. One thing that makes Bootstrap easy to use is that it is plug and play(Insert a stylesheet, add a couple classes and you're done)
Salesforce Lightening Framework, Almost everything is prefixed(It increases compatibility but I don't like seeing slds scattered on every html tag, it gets messy pretty quickly)

3

https://www.lightningdesignsystem.com/components/utilities/grid/

I feel I have to highly disagree on this instance @gilronc.
IMO, there are two fractions of Boostrap users in this instance.
1) ALL Bootstrap users

All Bootstrappers have to deal with the friction and troubles of the .label tag.

vs.
2) Wordpress-Boostrap users

Wordpress-Boostrap users are only a small fraction of Bootstrap users that have to deal with the Wordpress / .tag issue. Also there are a few solutions to the Wordpress-Boostrap users issue.

So having said that, I have to err on the side of the majority of Bootstrap users and push for the having the .tag tag implemented into v4 in replacement of the .label tag.

@guylepage3 let's keep it real. Currently 26% of all websites globally use WordPress so it's a massive fraction of Bootstrap users

@guylepage3 , .label or .tag is fine with me.  I've just never really had any problems with the html  or a  causing me any concerns.
I do agree that it might cause friction and affect readability in some cases but .label has just been around forever ....Foundation, Salesforce and other micro-frameworks seems to have standardized on .labels , even github uses .label for their "tags" :)
Nothing is wrong with either one from my perspective, i'm fine with whichever one the core maintainers decide to go with.

@Olivia101, 26% is not the majority.

Here's a snippet to unset the tag body class:
add_filter( 'body_class', 'bs4_remove_tag_body_class' );
function bs4_remove_tag_body_class( $classes ) {
    if ( false !== ( $class = array_search( 'tag', $classes ) ) ) {
        unset( $classes[$class] );
    }
    return $classes;
}

There's no generic tag class added by the post_class() function, but adding WordPress post tags like "success" (generates tag-success class) etc. will cause trouble, w/ body as well as post class.

@guylepage3 I believe he meant that was 26% of the internet, not Bootstrap users. So it could quite easily be a majority of Bootstrap users, it just depends on the overlap. I know I have seen A LOT of WP themes based on BS and would happily advocate for the framework to try and play nice with it :)

@eliottrobson thanks. Although I am still not convinced. We should find out what the actual number is then.
Also, there is a work around for it.
Lastly, IMO, I feel that software decisions should not be predicated nor effected by other, third party, software. Decisions should be made for the primary software.

I really still want to use the label component, but with it being .tag I have no choice than removing it from Bootstrap. It's too troublesome to adjust WordPress just to use something that can be coded easily ourself.
If Bootstrap 4 gets officially released with .tag, I'm pretty sure many WordPress users will encounter the same issue.

@maimairel, if you look at the workarounds presented above you'll notice that it's extremely easy to alter for your specific use case. The work arounds for all other Bootstrap users are definitely cumbersome and anti-semantic.

@diggy your addition to functions.php did the trick for me.
WordPress has a popular feature that you add to the  tag to pull in WP classes based on the page you're on for the ability to edit those specific pages apart from other pages included in a Wordpress theme.
 <body <?php body_class(); ?>>

This attribute is calling in the class "tag" only on tag pages, I don't see this as a huge issue as a workaround has already been established and the "body class" is just empty class placeholders incase you want to edit a specific page class (IE: .tag, .home, .logged-in, etc). None of these WP CSS classes are actually applying any rules to your page, they are there as utilities only incase you might want to.
Thanks for addressing this. I'm happy with a functions workaround, I was going to program some JS to do the same thing but this works!

Improved snippet, removing all offending classes from WP's body and post class arrays:
add_filter( 'body_class', '_twbs_bootstrap_20542', 10, 1 );
add_filter( 'post_class', '_twbs_bootstrap_20542', 10, 1 );
function _twbs_bootstrap_20542( $classes )
{
    return array_diff( $classes, array(
        'tag',
        'tag-pill',
        'tag-default',
        'tag-info',
        'tag-warning',
        'tag-danger',
        'tag-success',
        'tag-primary',
    ) );
}

body.tag is a core and standard way of theming in WordPress. Removing it, because of a need to work around Bootstrap's .tag is worse then silly. I suppose we should just consider WordPress and Bootstrap 4 to be incompatible, officially? Let some users fork Bootstrap, some user break WordPress? This is a weird decision, resting on the "purity" of naming .tag.

We'll be getting the class name changed in Alpha 6.

@mdo if we are going to change the class name.
May I request not going back to the old .label?
As referenced in https://github.com/twbs/bootstrap/issues/19094, there is a conflict with .label.

there is a naming conflict between bootstrap's class name .label and the html tag . it is generally good practice to not name your classes after html tags for easy and clear recognition.

i'd like to propose that we change the bootstrap .label to something like .tag.

Fix coming at you in #21020.

I see that tag is changing back to badge in Alpha 6. Just as an FYI, I was also getting a conflict when using Bootstrap 4 with Prism.js - it uses the tag class for styling code that is either recognized or flagged as markup.
It's a roughly-equal amount of work to prefix either the generated class or the Bootstrap CSS, so this is mostly just a heads-up that there are other conflicts than WordPress.
Is it fairly likely that badge will be the "final" name for that component?

@mdo why not just use .btn modofier like .btn.btn-tag?)

Personally, I like the badge class name. Just my subjective thoughts.


Rename metadata.json to config.json

It is increasingly being useful configuration options, when it started out as purely metadata.
Could cause confusion with the --config mechanism though - maybe that should be called "settings" instead?

This is particularly relevant as plugins increasingly use metadata.json for their plugin configuration: https://datasette.readthedocs.io/en/0.32/plugins.html#plugin-configuration

I'm definitely doing this rename, now that metadata.json is used for allow permissions configuration as well as-of #811.

I'll also rename --config to --setting.

I was confused by --config and I tried passing the json from datasette-ripgrep into config.json just as a wild guess.
A short term solution might be pointing out in plugins that their snippet json can go in metadata.json at least makes it easier to search for config options or to know where to start if someone is new.

Is there any reason to keep --setting rather than moving those items into a configure.json file with all the configuration options that currently live in metadata.json?

I can't keep up with the renaming contexts, but I like having the ability to run datasette+ datasette-ripgrep against different configs:
datasette serve --metadata=./metadata.json

I have one for all of my code and one per client who has lots of code. So as long as I can point to datasette to something, it's easy to work with.

It's going to be called datasette.json and the concept of metadata will be split out separately. See:

#2149


Openshift CVS: Add the spec to metallb

CVP Ops is complaining about the spec missing from metallb:
"error spec does not exist for the custom resource metallb",
trying to fix that.

/override ci/prow/ci-index-upgrade-bundle
/overried ci/prow/operator-e2e-upgrade

/override ci/prow/operator-e2e-upgrade

/override ci/prow/ci-index-upgrade-bundle

/override ci/prow/operator-e2e-upgrade


Was LLM not fine-tuned at either stage in the paper?

Reading the paper, it seems that the parameters of the LLM are always frozen

Yes, your understanding is correct. We only tune the parameters of the projector in the both stage. Thank you for your attention in our GraphGPT.


Open folder not shown and text on open files are erased after machine reboot

Description
Open folder not shown and text on open files are erased after machine reboot.
Fortunately when I close the files it prompts to save. I can not save and reopen the files to reload my data.
Steps to Reproduce

reboot the machine while atom is open
start atom

Expected behavior:  To have the previously open folder to be open
Actual behavior: Open folder not shown and text on open files are erased after machine reboot
Versions
Atom    : 1.12.4
Electron: 1.3.9
Chrome  : 52.0.2743.82
Node    : 6.5.0
apm  1.12.9
npm  3.10.5
node 4.4.5
python 2.7.12
git 2.7.4
OS - Ubuntu 16.04 LTS

This occurs when the Linux Drive containing the Files is not yet mount, on mounting it works as expected

If this is related to a mounted drive as @greenyx says, then this is a duplicate of https://github.com/atom/atom/issues/11797. Was this on a mounted drive @ShanikaEdiriweera?

Yes I run both windows and ubuntu on my machine. I was working with files on a mounted drive.

Thanks @ShanikaEdiriweera, I'm following up with the dev team on how this could have happened.

@ungb can you reproduce this?

This occurs when the Linux Drive containing the Files is not yet mount, on mounting it works as expected

@iolsen I can't repro this issue when the drive is mounted.  When it's not mounted I am seeing the issue where it opens atom with all the tabs open but all the files are empty which makes it seem like there's data loss but once you put the drive back in it works.
When the drive is not mounted we should probably either warn the user that we attempted to open their folder from a location that can't be found, or open a blank editor.
Open folder from mounted drive and open a few files:

Opening Atom when drive is unmounted

Thanks for the work reproducing the problem @ungb :bow:

Any progress on this? Need any help? It has wiped my code a minute ago :) @iolsen @lee-dohm

Thanks for the reminder. I've bumped the priority on this.

#15681 addresses this by smoothing some of the rough edges in the project and buffer deserialization process.
Unfortunately I wasn't able to make Atom handle the specific case of having a project root directory on a not-yet-mounted drive; all that we see is an ENOENT from the filesystem, so we can't distinguish the cases where we should wait for the file to appear from those where we shouldn't (after an mv or an rm -rf, say). What I was able to do was improve our handling of attempts to deserialize project directories and buffer paths that were on disk, but aren't any more. Now:

Any missing root directories are shown in an error notification on launch:

Hopefully, this should at least clue you in that something happened to your project on disk rather than "silently ignore it."

TextEditors are no longer created for buffers that used to be backed a file on disk which is now missing. This prevents this panic-attack inducing "hey look all of your files are empty now" behavior from before.

The good news is that this should address a host of issues related to things being done to your files between launches of Atom with serialized state. We'll no longer open a bunch of empty editors if you git checkout a different branch, for example.


Latest version does not work on 1.21.

It simply does not show up in JEI or creative menu on the latest version1.21-0.2.15 Fabric (1.21).

Duplicate of #9
The creative tab isn't showing up, but the item is craftable.


Oval Charm not working.

Have Oval charm equipped and it does change the time required to produce an egg.

Hihi!! I have confirmed this is a pixelmon bug and made a ticket for this: https://pixelmonmod.com/tracker.php?p=2&t=18897 Thank you very much! Closing


Improve typing of custom req/resp type

Discussed in https://github.com/falconry/falcon/discussions/2370

Originally posted by jkmnt October 14, 2024
Testing f4 beta with the our falcon-powered app. No runtime issues so far, but a few errors from the typechecker.
The app.add_error_handler and app.add_error_handler expects the callables with signature of  [falcon.Request, falcon.Response, ...etc]. Our app is using the custom Request class:
falcon.App(request_type=MyRequest)

def my_error_handler(req: MyRequest, ...): ...

Maybe the request/response types should be typed as generics bound to the base type ?
Something like
TReq = TypeVar('TReq', bound=Request)

class App(Generic[TReq, TResp]):
    def __init__( self,  request_type: Optional[type[TReq]] = None, ...): ...

    def add_error_handler(self, exception, handler: Callable[[TReq, TResp, TCtx, ...], None]): ...

The same issue is with before/after hook adders . Yes, it's way harder to type since they know nothing about the app class.

BTW, there was some (missed by mypy) errors reported by pyright. I think I'll try to fix some and submit a separate PR.

that would be great. Feel free to also open an issue when you do that.
also if you know tox and github action we could add a gate with it too, so that it stays tested

I have just created an issue to track the Pyright gate: #2373.

Another thing related to the typing:
I noticed the middleware type is just the object. It's the user-facing interface so imho typing should be better.
I suggest of something like
class MwWithReqHandler(Protocol):
    def process_request(self, req: Request, resp: Response) -> None: ...

class MwWithRespHandler(Protocol):
    def process_response(self, req: Request, resp: Response, resource: object, req_succeeded: bool) -> None: ...

class MwWithProcessHandler(Protocol):
    def process_resource(self, req: Request, resp: Response, resource: object, params: dict[str, Any]) -> None: ...

Middleware = Union[MwWithReqHandler, MwWithRespHandler, MwWithProcessHandler]

This is not perfect but better than nothing. The bad thing is that it's enough to have one conforming (with others nonconformin) methods to pass the type check. The good thing: the user may inherit it's middleware class from these protocols (kind of abc but w/o runtime overhead) and get full typesafety.
class MyMiddleware(MwWithReqHandler, MwWithRespHandler):
    def process_req(...)
    def process_resp(...)

I thought about it while doing that part, but if we type it as Middleware = Union[MwWithReqHandler, MwWithRespHandler, MwWithProcessHandler] won't that require that all 3 method are provided?
If not then that's for sure an option!

No afaik its enough to satisfy just one protocol of the union.

Seems like a good option then!

it probably makes sense to open a new issue with it. If you can work on a PR it would be great!

Yes, let's divide and conquer these typing improvements. Like improvement of the middleware protocols could be one issue/PR :slightly_smiling_face:

it probably makes sense to open a new issue with it. If you can work on a PR it would be great!

Ok, I'll draft the PR then.

I managed to type this all up at https://github.com/falconry/falcon/issues/2397 before looking for this, but looks like I came to the same conclusions 🙈
Thanks!


otel-desktop-viewer: fix darwin build

otel-desktop-viewer> Building subPackage ./...
otel-desktop-viewer> # github.com/shoenig/go-m1cpu
otel-desktop-viewer> vendor/github.com/shoenig/go-m1cpu/cpu.go:65:33: error: use of undeclared identifier 'kIOMainPortDefault'; did you mean 'kIOMasterPortDefault'?
otel-desktop-viewer>    IOServiceGetMatchingServices(kIOMainPortDefault, matching, &iter);
otel-desktop-viewer>                                 ^~~~~~~~~~~~~~~~~~

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[X] x86_64-darwin
[X] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 351732

aarch64-darwin

:white_check_mark: 1 package built:

otel-desktop-viewer


Add modestga support

modestga now supports parallel constrained minimization: https://github.com/krzysztofarendt/modestga
This should enable solving a wider class of MPC problems, bacause it's based on genetic algorithm. Multi-CPU optimization using FMUs was already tested in https://github.com/sdu-cfei/modest-py

FMPy support should be added first: https://github.com/sdu-cfei/mshoot/issues/4
PyFMI is not usable anymore and mshoot cannot be installed with pip.


Upgrade to OpenSSL 1.0.2o and 1.1.0h

Sorry for being a bit late!

@deepj Can you rebase and update latest definitions like 2.5.1?

@hsbt done


docker: set client scheme to http so we can ping server to negotiate version

Hello @landism, @jazzdan,
Please review the following commits I made in branch maiamcc/set-scheme-docker-client:
f3c4d6fd7808ebbfae84a473f5261273869dd024 (2019-10-08 14:43:35 -0400)
docker: set client scheme to http so we can ping server to negotiate version
without this change, calls to NegotiateVersion (which happens if $APIVersion isn't set),
we will always return API v1.24:

pinging the server will always error
b/c of unrecognized scheme (cuz nothing in our options has set the scheme yet); NegotiateAPIVersion ignores the error and passes along an empty ping to negotiateAPIVersionPing
given an empty ping, we default to
v1.24

If we can't accurately discern the user's docker version, we can't use
any features introduced in later versions (e.g. I'm fixing this so that
I can use the filters param for ImagesPrune).
Code review reminders, by giving a LGTM you attest that:

Commits are adequately tested
Code is easy to understand and conforms to style guides
Incomplete code is marked with TODOs
Code is suitably instrumented with logging and metrics

Can we do this for just the version check? It seems bad to give up on https across the board.

I took a swing at doing it just for the version check, but I can't find a way to READ the scheme of the docker client (private field) so i can't get the current value to reset it to that after i change it to http... like what i would want to do is:
if client.scheme == "":
    client.WithSchema("http")
    NegotiateAPIVersion()
    client.WithSchema("")

I guess I could just set it back to empty after?

or maybe I'm misunderstanding what's going on?
You say the request fails because we haven't set the scheme yet - do we set the scheme later somehow and then requests start working, but for some reason we're doing the ping earlier than that?

ya, this doesn't smell right.
have you looked at how the docker cli does the version negotiation?
does it work if you switch over to the negotiation option that ships with the cli?
https://godoc.org/github.com/docker/docker/client#WithAPIVersionNegotiation

This is much cleaner with #2323 + #2325 -- closing this ticket.


'block' is not defined while trying to retrieve Notion Workspace ID

I tried retrieving the block.space_id but here is what I get in the Chrome console

I tried using the debugger but that too did not work

Here is my public Notion page:
https://www.notion.so/2aff6f7db5f64da98bf8f6902f53ca5c

You need to do it from a page hosted via this starter kit. For example, https://react-notion-x-demo.transitivebullsh.it/2aff6f7db5f64da98bf8f6902f53ca5c
Your workspace ID is 4bf2c35d-acbb-450a-9f7a-e1b0a89e8871


enhance fetch-root-ca and do not rely PID as serial number

enhance fetch-root-ca  to support extract root ca from both cacerts and istio-ca-secret
do not rely on PID to set CA's serial number

@costinm @sdake please help review. Thanks!

BTW: I did some testing and Envoy has rejected the cert created with the makefile.
I'm starting to suspect the start time or something else - did you see this happening ?
I used the cert_tool and it started working without problems.

Let me verify this.

@costinm I have done:

make iris-cacerts-selfSigned
kubectl create ns istio-system

kubectl create secret generic cacerts -n istio-system
--from-file=iris/selfSigned-ca-cert.pem
--from-file=iris/selfSigned-ca-key.pem
--from-file=iris/root-cert.pem
--from-file=iris/selfSigned-ca-cert-chain.pem```
4. kubectl create ns test
5. label test ns
6. deploy sleep pod
The sleep pod starts successful. From the log the cert is pushed to envoy successfully:
2020-06-05T05:07:49.477068Z	info	cache	Root cert has changed, start rotating root cert for SDS clients
2020-06-05T05:07:49.477184Z	info	cache	GenerateSecret default
2020-06-05T05:07:49.477741Z	info	sds	resource:default pushed key/cert pair to proxy
2020-06-05T05:08:01.995810Z	info	sds	resource:ROOTCA new connection
2020-06-05T05:08:01.996028Z	info	sds	Skipping waiting for ingress gateway secret
2020-06-05T05:08:01.996083Z	info	cache	Loaded root cert from certificate ROOTCA
2020-06-05T05:08:01.996284Z	info	sds	resource:ROOTCA pushed root cert to proxy
2020-06-05T05:08:02.269695Z	warning	envoy filter	[src/envoy/http/authn/http_filter_factory.cc:83] mTLS PERMISSIVE mode is used, connection can be either plaintext or TLS, and client cert can be omitted. Please consider to upgrade to mTLS STRICT mode for more secure configuration that only allows TLS connection with client cert. See https://istio.io/docs/tasks/security/mtls-migration/
2020-06-05T05:08:02.276196Z	warning	envoy filter	[src/envoy/http/authn/http_filter_factory.cc:83] mTLS PERMISSIVE mode is used, connection can be either plaintext or TLS, and client cert can be omitted. Please consider to upgrade to mTLS STRICT mode for more secure configuration that only allows TLS connection with client cert. See https://istio.io/docs/tasks/security/mtls-migration/
2020-06-05T05:08:03.278169Z	info	Envoy proxy is ready

Can you share the steps you used that you encountered the error?  Thanks!

@irisdingbj during your tesitng, please set strict mTLS - as specified here:https://istio.io/docs/tasks/security/authentication/mtls-migration/#lock-down-mutual-tls-for-the-entire-mesh
You will see in your published logs the warning line:
2020-06-05T05:08:02.269695Z	warning	envoy filter	[src/envoy/http/authn/http_filter_factory.cc:83] mTLS PERMISSIVE mode is used, connection can be either plaintext or TLS, and client cert can be omitted. Please consider to upgrade to mTLS STRICT mode for more secure configuration that only allows TLS connection with client cert. See https://istio.io/docs/tasks/security/mtls-migration/

You should verify that the certs are being validated. Istio will do this for you with strict mTLS.. Perhaps this is what Costin is doing.
Cheers,
-steve


add aviability to delete calendars, bugfix

This is some amount of new code
Would you provide more info on your work?

Also, while I appreciate your work, please consider cleaning up your PR branch.
For example:

Fork the latest dev branch, then cherrypick your previous commits back. Some bug fixes are already implemented, and other areas of code may have been changed since your fork.
To catch up with the latest branch, consider using "fast-forward" instead of github's in-build buttons when possible to reduce complicated fork merges.

not relevant anymore looks like and can be implemented by code owner if need


Fix crash on deep link request page

Details

Fixed Issues

$ https://github.com/Expensify/App/issues/29183
PROPOSAL:  https://github.com/Expensify/App/issues/29183#issuecomment-1755815680
Tests

[x] Verify that no errors appear in the JS console

Offline tests

QA Steps

Create a request money
Click request preview
Click request item
Click date and copy url
Create a public room and send URL
Logout and open the publish room
Click open url
Verify that app should not crash

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

https://github.com/Expensify/App/assets/57568571/59d90578-d967-4bbe-92c8-dffd6c4f9817

iOS: Native

iOS: mWeb Safari
https://github.com/Expensify/App/assets/57568571/08ab8bae-ea05-427a-9877-af07f49d5079

MacOS: Chrome / Safari
https://github.com/Expensify/App/assets/57568571/e227bf81-8ba0-46d9-b976-52521c472cd4

MacOS: Desktop
https://github.com/Expensify/App/assets/57568571/b83fa261-3301-4edf-8a91-ab3542391b5c

Reviewer Checklist

[X] I have verified the author checklist is complete (all boxes are checked off).
[X] I verified the correct issue is linked in the ### Fixed Issues section above
[X] I verified testing steps are clear and they cover the changes made in this PR

[X] I verified the steps for local testing are in the Tests section
[X] I verified the steps for Staging and/or Production testing are in the QA steps section
[X] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[X] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[X] I checked that screenshots or videos are included for tests on all platforms
[X] I included screenshots or videos for tests on all platforms
[X] I verified tests pass on all platforms & I tested again on:

[X] Android: Native
[X] Android: mWeb Chrome
[X] iOS: Native
[X] iOS: mWeb Safari
[X] MacOS: Chrome / Safari
[X] MacOS: Desktop

[X] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[X] I verified proper code patterns were followed (see Reviewing the code)

[X] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[X] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[X] I verified that comments were added to code that is not self explanatory
[X] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[X] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[X] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[X] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[X] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[X] I verified the JSDocs style guidelines (in STYLE.md) were followed

[X] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[X] I verified that this PR follows the guidelines as stated in the Review Guidelines
[X] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[X] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[X] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[X] If a new component is created I verified that:

[X] A similar component doesn't exist in the codebase
[X] All props are defined accurately and each prop has a /** comment above it */
[X] The file is named correctly
[X] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[X] The only data being stored in the state is data necessary for rendering and nothing else
[X] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[X] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[X] All JSX used for rendering exists in the render method
[X] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[X] If any new file was added I verified that:

[X] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[X] If a new CSS style is added I verified that:

[X] A similar style doesn't already exist
[X] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[X] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[X] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[X] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[X] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[X] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[X] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[X] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

https://github.com/Expensify/App/assets/16493223/a0321eef-e198-4817-a7ef-544edee2c698

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Cherry-picked to staging by https://github.com/tgolen in version: 1.3.81-6 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

🚀 Deployed to staging by https://github.com/tgolen in version: 1.3.83-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.83-11 🚀

platform
result

🤖 android 🤖
skipped 🚫

🖥 desktop 🖥
skipped 🚫

🍎 iOS 🍎
skipped 🚫

🕸 web 🕸
skipped 🚫

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.83-11 🚀

platform
result

🤖 android 🤖
skipped 🚫

🖥 desktop 🖥
skipped 🚫

🍎 iOS 🍎
skipped 🚫

🕸 web 🕸
skipped 🚫

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.83-11 🚀

platform
result

🤖 android 🤖
skipped 🚫

🖥 desktop 🖥
skipped 🚫

🍎 iOS 🍎
skipped 🚫

🕸 web 🕸
skipped 🚫

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.83-11 🚀

platform
result

🤖 android 🤖
failure ❌

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅


pkg/receive: basic hashring support

Changes
This PR adds a basic hashring type to the receive package. The hashring does not implement consistent hashing because today we do not care about needing to shift data around between scale-up/scale-down. The current plan is that at every scale event we flush all data, write it to block storage, and start again.
Going forward, a PR will embed a Hashring into the Handler struct so that when handling requests, the Handler can decide if it needs to handle the request itself or forward it to another host.
Forwarding functionality will be added in a follow up.
Verification
Unit testing of hashring.
cc @metalmatze @brancz

Very nice. I like that it is so simple. Should be a good start!
/cc @bwplotka


Add Repository

URL of codelab:
https://developer.android.com/codelabs/basic-android-kotlin-compose-add-repository
Specify the language of the codelab if it is not English:
In which task and step of the codelab can this issue be found?
Task 9 - Step 3
Describe the problem
In task 3, "Create Data Layer," we name the repository class "DefaultMarsPhotosRepository," but in Step 9 it is referred to as "NetworkMarsPhotosRepository."
Steps to reproduce?
n/a
Versions
n/a
Additional information
n/a

Duplicate of #39, #34, #23, #17


Fix the error message when deleting a media file in use

Describe the Bug
When deleting a media file that is in use, a network error is displayed

Steps to Reproduce

Go to 'Media Library'
Try to delete a media file that is being used as the organisation icon
See error

Expected Behavior
I think we could display a more understandable (user-friendly) message.
Like: "This media file can't be deleted because it is in use"
Actual Behavior
The following error is displayed:
A network error has occurred. Please try again later.
Additional Information

Traceback
Dec 06 11:32:21 ERROR django.request - 500 Internal Server Error: /ajax/media/file/delete/
Traceback (most recent call last):
File "/home/tory/Integreat/integreat-cms/.venv/lib/python3.9/site-packages/django/core/handlers/exception.py", line 47, in inner
  response = get_response(request)
File "/home/tory/Integreat/integreat-cms/.venv/lib/python3.9/site-packages/django/core/handlers/base.py", line 181, in _get_response
  response = wrapped_callback(request, *callback_args, **callback_kwargs)
File "/home/tory/Integreat/integreat-cms/.venv/lib/python3.9/site-packages/django/views/decorators/http.py", line 40, in inner
  return func(request, *args, **kwargs)
File "/home/tory/Integreat/integreat-cms/.venv/lib/python3.9/site-packages/django/contrib/auth/decorators.py", line 21, in _wrapped_view
  return view_func(request, *args, **kwargs)
File "/home/tory/Integreat/integreat-cms/integreat_cms/api/decorators.py", line 115, in wrap
  return function(request, *args, **kwargs)
File "/home/tory/Integreat/integreat-cms/integreat_cms/cms/views/media/media_actions.py", line 361, in delete_file_ajax
  media_file.delete()
File "/home/tory/Integreat/integreat-cms/.venv/lib/python3.9/site-packages/django/db/models/base.py", line 966, in delete
  collector.collect([self], keep_parents=keep_parents)
File "/home/tory/Integreat/integreat-cms/.venv/lib/python3.9/site-packages/django/db/models/deletion.py", line 302, in collect
  raise ProtectedError(
django.db.models.deletion.ProtectedError: ("Cannot delete some instances of model 'MediaFile' because they are referenced through protected foreign keys: 'Organization.icon'.", {<Organization (id: 1, slug: test-organization, region: augsburg)>})

I am not sure about the expected result actually.
Maybe we should be able to delete used media files actually? And there should be no error in this case?

I am not sure about the expected result actually.
Maybe there should be no error in this case? And we should be able to delete used media files?

If so, what do we do with organisations, where the logo is mandatory, and the deleted file was used as a logo?

That's why we want to prevent media files from being deleted when they are used. But I agree with you that just showing an error  is not user friendly 😅

Or maybe we should disable the "delete" button in this case, and show a tooltip message?

I think disabling is the best. The reason can be explained like for archiving a mirrored page:


Reports of IMM not working

From Phil:
"imm se3 throw an error: ValueError: x and y must have same first dimension, but have shapes (98,) and (2,)
and the vector case is sensitive to initialization, sometimes the estimation is not good"
Also running integration tests on latest commit doesn't seem to work. Investigating.

Fixed by #116


[clkmgr] Fix dft issues

Addresses #5452 and #5453

force step_down_req to 0 when in test mode
remove bypass mux when in test mode

Signed-off-by: Timothy Chen<EMAIL_ADDRESS>

@arnonsha can you double check the assumptions? I'm not bothering to protect the step_down signals after flops since I assume those will be off the scan chain.  If that won't be the case, let me know and I can move the protection point.

Maybe we should add the  no_scan prefix to all dividers ?
If not we will add the dividers explicitly to the no scan list

Maybe we should add the no_scan prefix to all dividers ?
If not we will add the dividers explicitly to the no scan list

ah yes good point, we had not discussed before if no-scan should have some kind of special naming.  Is no_scan prefix what you prefer? Do you mind adding it to the DFT doc (maybe it's there already and i missed it).
Can I add it to the prim_clock_div instantiation level?

thanks @arnonsha , if someone else can approve, then we can merge this for the next delivery.


deepseek/coder suggests only how to edit the files but doesnt edit it directly. how to make it edit the files and make changes directly on the files?

Issue
as titled
Version and model info
latest
deepseek/deepseek-coder

When reporting problems, it is very helpful if you can provide:

Aider version
LLM model you are using
Any stack traces or error messages
A description of what you were doing when the error happened.

Including the “announcement” lines that aider prints at startup is an easy way to share some of this helpful info.
Aider v0.37.1-dev
Models: gpt-4o with diff edit format, weak model gpt-3.5-turbo
Git repo: .git with 243 files
Repo-map: using 1024 tokens

I can confirm.
Running aider --model deepseek/deepseek-coder
with
Aider v0.47.1 Model: deepseek/deepseek-coder with diff edit format Git repo: .git with 463 files Repo-map: using 1024 tokens
and having two files added to context:
99c_target/imports/ui/App.vue 99c_target/imports/ui/Login.vue
and giving the following prompt:

change the code to make 99c_target/imports/ui/Login.vue the entry point of the app

makes aider only giving suggestions instead of changing the code:
`
To make 99c_target/imports/ui/Login.vue the entry point of your Vue.js application, we need to configure the router to use this component as the default route. Since you've added
99c_target/imports/ui/App.vue to the chat, we can proceed with the necessary changes.
Let's assume you have a router configuration file (router.js or index.js) that we need to update. If you don't have one, please let me know, and I'll guide you through creating it.
                                                                   Example router.js or index.js (if you have one)

// router/index.js or router.js
import { createRouter, createWebHistory } from 'vue-router';
import Login from '99c_target/imports/ui/Login.vue';
const routes = [
{
path: '/',
name: 'Login',
component: Login
}
// Add other routes here if needed
];
const router = createRouter({
history: createWebHistory(),
routes
});
export default router;
                                                                              Update main.js or main.ts

Ensure your main entry file (main.js or main.ts) imports and uses the router configuration:
// main.js or main.ts
import { createApp } from 'vue';
import App from './App.vue';
import router from './router'; // Adjust the path according to your project structure
createApp(App)
.use(router)
.mount('#app');
createApp(App)
.use(router)
.mount('#app');
                                                                           Ensure App.vue uses the router

`
Even telling aider explicitly to change into /chat-mode code or use change code directly in the prompt did not change the behaviour.

@99cv @paul-gauthier thx

I have the same issue. it does not build files at all with Aider. It just tells you what to do. I hope it gets fixed quite soon. 🤞

It seems I have found a work-around. At least it worked now once with another terminal. Please check guys if this isn't the problem with the built in VS Code terminal. In the standard command line all works as expected it seems...

@leanit-piotr
I never use aider in the vs code terminal. So the issue occured in normal terminal in zsh shell as well.
My last task was to change just one line (finally just for testing purposes) in one file and aider with model deepseek/deepseek-coder was still just dropping suggestions instead of "doing the work".
@paul-gauthier
with option --edit-format whole aider is doing changes again! Thanks!

I'm going to close this issue for now, but feel free to add a comment here and I will re-open or file a new issue any time.


Your note on "custom roles"

I believe you may need to reword the note "This app imports custom roles from Salesforce as part of the provisioning process, which the customer may want to select when assigning users" - I just configured user provisioning with a Salesforce app. On the Salesforce side, you have both profiles and roles. However, only profiles get provisioned back to Azure. However, they appear as Roles on the Azure side. A little confusing. Thanks for your help.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 624be0a5-9ab6-ec59-e7a2-74585cb0571e
Version Independent ID: a00a09c8-f0c5-2bfe-75aa-6183346af405
Content: Tutorial: Configure Salesforce for automatic user provisioning with Azure Active Directory
Content Source: articles/active-directory/saas-apps/salesforce-provisioning-tutorial.md
Service: active-directory
GitHub Login: @jeevansd
Microsoft Alias: jeedes

@chetansriv  Can you please make this change?

This is updated.
#Please-close

We will now proceed to close this thread. If there are further questions regarding this matter, please comment and we will gladly continue the discussion.


Tenant does not apply

I can't figure out where the error is
class Product extends BaseModel implements HasMedia
{
    use BelongsToTenants;

    public $tenantColumns = ['scheme_id' => 'scheme_id'];

}

Controller for check
$products = Product::limit(1);
dd(\Landlord::getTenants(), $products->toSql(), $products->first());

Ouput

Can you help me find the problem?

Hi @diegonella, have you implemented the middleware to set the tenant value for request?

Hello,
We have an exciting opportunity for you! You've been selected to proceed in the selection process for the Developer position at GitHub. Congratulations on your achievement!
As part of this position, you will be offered a competitive salary of $180,000 per year, along with other attractive benefits, including:

Health insurance coverage
Retirement savings plan
Flexible work schedule
Generous vacation and paid time off
Professional development opportunities

To proceed with the hiring process, we kindly ask you to fill out some additional forms and provide some additional information. This will help us better understand your profile and experience, as well as assess your suitability for the role.
Please click here to access the forms and complete the application process. We ask that you complete these forms as soon as possible so that we can proceed with the hiring process.
Important: You have 24 hours to complete the application process.
If you have any questions or need further information, please don't hesitate to contact us.
Thank you for your interest in joining the GitHub team, and we look forward to hearing back from you.
Best regards,
GitHub Recruitment Team
acgnet, @lucasrc98, @CesarNog, @diegosilva789, @robotenique, @renanbirck, @linces, @diegomagikal, @theagosakai, @eurmn, @devtbraga, @GregoriSchuster, @lcmps, @josefelipesouza, @euharrison, @italobb, @ThalesCouto, @vinicius-vph, @rafaeldl, @shuhikari

Closing since not feedback was done


React event isn't working.

So a few days ago I was using the .eventstart reaction, and it worked, now when I do it the message appears with the reaction, but adding a reaction will not give you the money. Is there any way I could fix that?

Is the money awarded after the timer runs out?

Maybe you hae too much money, I don't know :P Can't reproduce, works fine.


fix: Convert nodeId to number in importConfig before calling API

Fixes #767

@zwave-js-bot fix lint

@zwave-js-bot fix lint

Pull Request Test Coverage Report for Build 606892528

0 of 5 (0.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.003%) to 18.801%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

app.js
0
5
0.0%

Totals

Change from base Build 602502207:
-0.003%

Covered Lines:
2004

Relevant Lines:
10940

💛  - Coveralls


Remove guava dependency

Description
Removing unnecessary guava dependencies
Issues Resolved
https://github.com/opensearch-project/ml-commons/issues/1854
Check List

[ X] New functionality includes testing.

[X ] All tests pass

[X ] New functionality has been documented.

[X ] New functionality has javadoc added

[X ] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Did you compare the opensearch-ml zip size before and after this removal? We can remove it for now but we probably will add some of them back to use Guava cache for better cache management if the zip size doesn't change much.

Hi @Zhangxunmt this PR is not really have the zip size optimization as it's main focus, but rather it was more meant about making the build file clean from exclusion and shading acrobatics and avoiding dependencies that can collide with opensearch runtime.
Now if we intend on keeping Guava going forward for various other reasons (e.g. Cache) then should we use runtime dependency instead of compile time?
You can pass the guava to testImplementation instead and avoid the exclusions and shading?

Some new PR merged to main branch. Rebase first to make the CI pass?

@samuel-oci Can you rebase this PR and merge? It's been a long time. Not sure if it has new conflicts with recent commits. Currently still no plan to use guava for cache.


Whats the correct way of setting the volumes in the container

What directories are important or necessaries for the container to persist data using volumes?
Currently I have these:

/usr/local/tomcat/webapps

work
logs
temp
-/opt/pega/data

Any Suggestion?

@yokodev What data are you looking to persist?  Is this for web/batch or stream nodes?
I'd also suggest looking at the Helm charts repo here: https://github.com/pegasystems/pega-helm-charts.  That provides a codified example of a Kubernetes deployment - including volume claims as needed.

@dcasavant Well, you got me there...
How do you know if a tomcat is web/batch or stream?  my guess is that this is web
I have some 7.4 and 8.2 images based on this article How to run Pega 7.4 in Docker
and came to the configuration above by guessing what my team may need... but was wondering what would be the official way of doing things.
I will also look at the repo you mention...
Thanks

@yokodev I assume this is a pure docker deployment and not trying to do things through kubernetes?

or is it something wrong with the docker images

So that depends on which docker image you're referring to. Is that this image from this repo or something you built on your own given the article above?
Generally you can create a volume at the /opt/pega directory using whatever means you want to do so. A popular thing to do in the pure docker world is to use a data-container which defines this volume and then wire that up to this container.

Yes, I built it based on the article...
Regarding the volumes I currently have this mapped to the host

/usr/local/tomcat/

webapps
work
logs
temp

/opt/pega/data
I didn't want to lose the logs, and the temp folder is for the search indexes,
although I have to set the node every time the VM is restarted. Is there a way of setting this permantenly?

@yokodev what is this UI/program you're using to do things? I'm generally familiar with docker command line.
With that said your logic sounds fine enough. As far as setting the node-type permanently you can do that with this image though with the one you built I suspect you'd have to wire things up in your own way to do that. You can use the below query to see how we wire-up setting the NODE_TYPE for this image and perhaps apply that logic however you can to your context.
https://github.com/pegasystems/docker-pega-web-ready/search?q=NODE_TYPE&unscoped_q=NODE_TYPE

@cdancy  That is Pega :)
So every time I restart the host it gets terribly slow and so, one of the things that help alleviate this is to set the Host node ID  on the Search Index host node setting (shown above) but it gets wiped out on every restart, so I was wondering if its a volume issue or how do you make it persistent across restarts.

That is Pega :)

hahaha ... I'm in a different context and assumed you were posting a screenshot of some program to start docker containers. Indeed it is Pega :) So that's just basic docker at this point. I would personally recommend using a data-container as I noted above to make this stupid-simple. Check out the below article to see how to wire things up.
https://boxboat.com/2016/06/18/docker-data-containers-and-named-volumes/

@cdancy  Sorry about that probably I wasn't expressing my ideas in the clearest of ways...
So my doubt primarily geared towards best practices, and now that someone with knowledge was answering take advantage and throw in, some other issues that I was having...
So, I'm able to persist everything, I just don't know how to persist this setting across reboots( node setting for the search indexes).

@yokodev What are you using to orchestrate your restarts?  How is the configuration managed?

@dcasavant well its GCP scheduler, and was just trying to figure out a way of persisting this option across reboots. So I thought it may be related to my volume configuration being wrong or something.

@yokodev I haven't tried the GCP scheduler so I can't advise on that.  I'd suggest moving to GKE (GCP Kubernetes) as that is a supported tool and can be deployed using the Helm charts linked above.

@dcasavant Yes, I know... So because of our requirements within the company sometimes we just need to spawn a single container for a couple of days and not have a full-fledged installation.
That said, do you guys have plans to provide such docker image so that one is able to just test out something in a single node and then get rid of it?
Any other recommendation is well welcome.
Thanks

@yokodev With some basic automation of the commands, you can spin up and tear down deployments using GKE as well (and it is the more appropriate tool to solve this problem).  That is how I would suggest running a deployment regardless of the duration.
Depending on your exact use cases, you can also automate the restoration of a DB from backup or full installation on a run-by-run basis.


remove enums that aren't used by any slots according to ``

doesn't require a migrator?

freq_clean_enum
organism_count_enum
plant_growth_med_enum
samp_md_enum

There are slots that share names with these enums, like samp_md, 'sample measured depth', which currently has a QuantityValue range.
I have no idea how that relates to these PVs. Too bad there's no annotations.
  samp_md_enum:
    from_schema: http://w3id.org/mixs/terms
    permissible_values:
      DF: {}
      RT: {}
      KB: {}
      MSL: {}
      other: {}

Possibly related: https://en.wikipedia.org/wiki/Depth_in_a_well


Validation issue with +84898084530 (VN)

Please read the "guidelines for contributing" (linked above) and fill in the template below.
should be changed
Ho Chi Minh City => VietNam
Country/region affected (e.g., "US"): VN
Example number(s) affected ("+1<PHONE_NUMBER>"): +84898084530
The phone number range(s) to which the issue applies ("+1 555 555-XXXX"): +8489XXXXXXX
The type of the number(s) ("fixed-line", "mobile", "short code", etc.): mobile
The cost, if applicable ("toll-free", "premium rate", "shared cost"):
Supporting evidence (for example, national numbering plan, announcement from mobile carrier, news article): announcement from mobile carrier(Mobifone)
link to demo

@DayiJung
This issue is similar to https://github.com/googlei18n/libphonenumber/issues/992 and will be tracked there. Hence closing the issue here.


Run smithy-swift & aws-sdk-swift CI on all platforms

Describe the feature
When running continuous integration on the smithy-swift repo, it is only performed on Mac.  This can mask changes that are not compatible with Linux.  Additional safeguards are needed to ensure that changes will build on all supported platforms.
Use Case
To detect smithy-swift changes that are not compatible with all supported platforms as early as possible in the development cycle.
Proposed Solution
Add CI jobs to run smithy-swift CI on a variety of Apple / Linux platforms, comparable to the SDK's CI config.
Other Information
No response
Acknowledgements

[ ] I may be able to implement this feature request
[ ] This feature might incur a breaking change

Now building:

CI on all Apple platforms except Watch, oldest & newest supported.
CI on AL2 & Ubuntu Linux, oldest & newest supported.
(aws-sdk-swift) Integration tests on the same platforms as CI.

Closing as Done.


Drop support or EOL Python 2.6

Fixes #216.

Sorry, I forgot to say that the automatic formatters are only available in 2.7+ so depends on the first commit.

#218 covers thus for now.


Question about the backproject function?

Hello,
Why set the z>0 condition?
As I know, z is up,x is front, y is left in this coordinate. When set z>0 condition, it filters out all points below the ground.
But, sometimes the road is up and down.

def backproject(features, points, projection):     n_images, n_channels, height, width = features.shape # [6, 64, 225, 400]     n_x_voxels, n_y_voxels, n_z_voxels = points.shape[-3:]     points = points.view(1, 3, -1).expand(n_images, 3, -1) #[6, 3, 1168128]     points = torch.cat((points, torch.ones_like(points[:, :1])), dim=1) #[6, 4, 1168128]     points_2d_3 = torch.bmm(projection, points) #[6, 3, 1168128]     x = (points_2d_3[:, 0] / points_2d_3[:, 2]).round().long()     y = (points_2d_3[:, 1] / points_2d_3[:, 2]).round().long()     z = points_2d_3[:, 2]     **valid = (x >= 0) & (y >= 0) & (x < width) & (y < height) & (z > 0)**     volume = torch.zeros((n_images, n_channels, points.shape[-1]), device=features.device) #[6, 64, 312, 312, 12]     for i in range(n_images):         volume[i, :, valid[i]] = features[i, :, y[i, valid[i]], x[i, valid[i]]]     volume = volume.view(n_images, n_channels, n_x_voxels, n_y_voxels, n_z_voxels)     valid = valid.view(n_images, 1, n_x_voxels, n_y_voxels, n_z_voxels)     return volume, valid

Hi @rockywind ,
After multiplying by projection matrix here points are in camera coordinates. This means that x and y are now in image plane and z is the distance to the point. So here with z > 0 we simply check that point is in front of the camera (not behind).

OK, I see.Thank you!


We should note the current on-prem limitation

There is a current limitation of being able to only sync one on-prem web application URL Farm wide.  We are seeing that many customers that are trying to sync more then one on-prem web applications (URL) and failing, then opening support cases. Can we please update this article to state the known limitation to help customers avoid any misunderstandings.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 8f0d9527-a78b-d18b-d218-881fac11423d
Version Independent ID: 3ad8fc7b-4869-dbdc-802b-a804f65d0e39
Content: Configure syncing with the new OneDrive sync app for SharePoint 2019
Content Source: SharePoint/SharePointServer/install/new-onedrive-sync-client.md
Product: sharepoint-server-itpro
GitHub Login: @kaarins
Microsoft Alias: kaarins

@mikelee-msft Thank you for submitting feedback. We understand that this issue has been resolved.
Please feel free to re-open this issue if there is a specific area of the docs that we can improve or make better. Thank you.

Thank you!!   Looks Great!


ci: harden workflows

Codecov Report

Merging #324 (90b86ce) into trunk (4601b3a) will not change coverage.
The diff coverage is n/a.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@           Coverage Diff           @@
##            trunk     #324   +/-   ##
=======================================
  Coverage   97.56%   97.56%
=======================================
  Files           5        5
  Lines         205      205
  Branches       64       64
=======================================
  Hits          200      200
  Misses          5        5

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Rotation related webpage returns access denied

https://storage.googleapis.com/openimages/web/2018-05-10-rotation-information.html
This now returns access denied.
Anonymous caller does not have storage.objects.get access to openimages/web/2018-05-10-rotation-information.html.

Hi @derekhh
The link was broken, the correct link is:
https://storage.googleapis.com/openimages/web/2018-05-17-rotation-information.html
Thanks for reporting this!


Play classified as "no-play" because of a flag that didn't wipe out a play

In week 6, 2019 (Giants @ Patriots), Brady threw a pick and then Markus Golden was flagged on the return for unnecessary roughness. The play_type is listed as "no_play", even though the flag got enforced after the interception return. play_id is 455 in week 6 2019, for reference. If this is on purpose and I'm just misunderstanding the classification, my apologies!

Similar shows up in week 13, with Patriots against the Texans. Brady threw a pick to Bradley Roby, who got flagged for unsportsmanlike conduct after the pick, and the play is listed as "no_play."

Just saw that "no_play" is given for anything where a penalty is called. I'll close this now, sorry to bother!

This still might be a bug but don't have time to check right now. What does play_type_nfl say on these plays?

Both listed as PASS in play_type_nfl. Thanks!

Got it, thanks. play_type_nfl is what the NFL provides itself, while play_type is something inferred in the code. I'm guessing this is probably a bug but since the NFL has removed access to this data we probably won't bother fixing it.

Okay, that's what I was thinking, but just wanted to check and see if I was on the right path. Easy enough to get around it by querying differently. Too bad about NFL APIs :/
Thanks for your help!

Closing this because it's been fixed in the development branch


Jai/TLI 101.e -- Added ability to upload multiple model and fixed graphs

Pull Request Description
Feature Implementation:
This PR enables the functionality for uploading multiple models to Dashboard 2. The system has been updated to handle file validation, properly store uploaded models, and display corresponding data and graphs for each model. The following changes have been made:

Multiple Model Upload: Users can now upload multiple models at once instead of uploading one at a time.

File Validation: The system checks the file types of uploaded models and ensures only valid model files are accepted. Invalid files trigger an error message.

Error Handling: Several error scenarios have been accounted for:

Invalid File Types: Non-model files are rejected, and a helpful error message is displayed.
Duplicate Model Names: Users are notified if they attempt to upload a model with a name that already exists.

Dashboard 2 Output: The dashboard now correctly generates data and graphs for each uploaded model. Each model's respective data is shown, and graphs are plotted accordingly.

Local Storage: Uploaded models are stored in local storage and are retrievable without any issues, ensuring persistence between sessions.

Graph Enhancements:

Axes Labels: Both dashboards now have properly labeled axes on the graphs to improve clarity and data interpretation.
Hover Tooltip: A tooltip now appears when hovering over any graph, displaying detailed data for the hovered point.

Acceptance Criteria:

Multiple Model Upload: Users can upload multiple models simultaneously in Dashboard 2.
Error Handling:

Invalid file types (non-model files) are rejected with an error message.
Duplicate model names trigger a notification, preventing overwriting.

Dashboard 2 Output: The dashboard correctly processes and displays the data and graphs for all uploaded models.
Local Storage: Uploaded models are correctly stored and retrieved from local storage.
Hover Tooltip: Detailed data is displayed when hovering over the graph points.
Axes: Axes on graphs are labeled for better data interpretation on both dashboards.

Testing:

Test uploading multiple models with valid and invalid file types.
Test the handling of duplicate model names.
Verify that data and graphs are displayed correctly for each model in the dashboard.
Ensure that models are stored in local storage and persist after refresh.
Test the tooltip on graph hover and verify that it displays the correct data.
Confirm that the axes of the graphs are labeled properly.

Looks good Jai thanks! Go through my comments but other than that works fine