INVALID_HEADER_TYPE error when force:org:open --targetusername in CI

Summary
Getting this error when using my Github action:
2021-01-21T23:24:16.1309590Z {
2021-01-21T23:24:16.1310214Z   "status": 1,
2021-01-21T23:24:16.1310795Z   "name": "INVALID_AUTH_HEADER",
2021-01-21T23:24:16.1311417Z   "message": "INVALID_HEADER_TYPE",
2021-01-21T23:24:16.1311952Z   "exitCode": 1,
2021-01-21T23:24:16.1312599Z   "commandName": "OrgOpenCommand",
2021-01-21T23:24:16.1318645Z   "stack": "INVALID_AUTH_HEADER: INVALID_HEADER_TYPE\n    at HttpApi.getError (/usr/local/lib/sfdx/node_modules/jsforce/lib/http-api.js:250:13)\n    at /usr/local/lib/sfdx/node_modules/jsforce/lib/http-api.js:95:22\n    at tryCallOne (/usr/local/lib/sfdx/node_modules/promise/lib/core.js:37:12)\n    at /usr/local/lib/sfdx/node_modules/promise/lib/core.js:123:15\n    at flush (/usr/local/lib/sfdx/node_modules/asap/raw.js:50:29)\n    at processTicksAndRejections (internal/process/task_queues.js:79:11)\nOuter stack:\n    at Function.wrap (/usr/local/lib/sfdx/node_modules/@salesforce/core/lib/sfdxError.js:171:27)\n    at OrgOpenCommand.catch (/usr/local/lib/sfdx/node_modules/@salesforce/command/lib/sfdxCommand.js:259:67)\n    at processTicksAndRejections (internal/process/task_queues.js:97:5)\n    at async OrgOpenCommand._run (/usr/local/lib/sfdx/node_modules/@salesforce/command/lib/sfdxCommand.js:97:13)\n    at async Config.runCommand (/usr/local/lib/sfdx/node_modules/@oclif/config/lib/config.js:173:24)\n    at async Main.run (/usr/local/lib/sfdx/node_modules/@oclif/command/lib/main.js:27:9)\n    at async Main._run (/usr/local/lib/sfdx/node_modules/@oclif/command/lib/command.js:43:20)\n    at async Object.run (/usr/local/lib/sfdx/dist/cli.js:32:20)",
2021-01-21T23:24:16.1321716Z   "warnings": []
2021-01-21T23:24:16.1322208Z }

Strangely only happens in CI. Works fine on my mac...
The user is definitely there fwiw:
2021-01-21T23:24:14.7297790Z === Orgs
2021-01-21T23:24:14.7325708Z   ALIAS   USERNAME               ORG ID              CONNECTED STATUS
2021-01-21T23:24:14.7327500Z   ──────  ─────────────────────  ──────────────────  ────────────────
2021-01-21T23:24:14.7331337Z   HubOrg<EMAIL_ADDRESS>00Dd0000000fbMlEAI  Connected
2021-01-21T23:24:14.7331975Z
2021-01-21T23:24:14.7336057Z      ALIAS   USERNAME                                     ORG ID              EXPIRATION DATE
2021-01-21T23:24:14.7337543Z ───  ──────  ───────────────────────────────────────────  ──────────────────  ───────────────
2021-01-21T23:24:14.7338961Z (U)  ciorg<EMAIL_ADDRESS>              00D54000000GvJ9EAK  2021-01-22
2021-01-21T23:24:14.7340416Z      qauser<EMAIL_ADDRESS>00D54000000GvJ9EAK  2021-01-22

Steps To Reproduce:
Working on a repo to reproduce this cleanly...
Expected result
Prints login url
Actual result
Throws error
Additional information
Namespaced org.
sfdx-cli/7.82.0-3d0c527ac6 linux-x64 node-v12.18.3
Ubuntu 18.04.5

Only seems to be happening in namespaced devhub, not in regular developer edition hub.

Only seems to be happening in namespaced devhub, not in regular developer edition hub.

Ran out of scratch orgs for the day to reproduce

Ran out of scratch orgs for the day to reproduce

Using alias isn't the issue, opening by username fails in same way
userinit=$(sfdx force:user:create -f ci/modules/services/qa-user-template.json --json)
username=$(echo $userinit | jq -r '.result.fields.username')
sfdx force:org:list
sfdx force:org:open -u $username -r --loglevel=TRACE --json

Using alias isn't the issue, opening by username fails in same way
userinit=$(sfdx force:user:create -f ci/modules/services/qa-user-template.json --json)
username=$(echo $userinit | jq -r '.result.fields.username')
sfdx force:org:list
sfdx force:org:open -u $username -r --loglevel=TRACE --json

Does adding --dev-debug give you any additional information around the request being made?
Out of curiosity, why are you trying to open the org in CI? Can you share a github action config that would reproduce off the fork of the dreamhouse app?

Does adding --dev-debug give you any additional information around the request being made?
Out of curiosity, why are you trying to open the org in CI? Can you share a github action config that would reproduce off the fork of the dreamhouse app?

Hi, thanks for the flag. Nothing obvious so far.
To makes things even hard I can only reproduce it in our internal repo, but not in public one 🥴
I've used credentials from public one (totally different NS, dev org AND also removed all files from internal repo) - command fails. Log attached below:
reproduced.txt
Here's a log from identical action, from this repo.
not-repro.txt

why are you trying to open the org in CI?
I'm testing permissions using jest+playwright (via sfdx-node ... IMO you guys need first-party support for NPM). I use nodejs to create user, assign permset and all sort of other things. Here's my workhorse wrapper I extensively use in jest to drive my org.

Hi, thanks for the flag. Nothing obvious so far.
To makes things even hard I can only reproduce it in our internal repo, but not in public one 🥴
I've used credentials from public one (totally different NS, dev org AND also removed all files from internal repo) - command fails. Log attached below:
reproduced.txt
Here's a log from identical action, from this repo.
not-repro.txt

why are you trying to open the org in CI?
I'm testing permissions using jest+playwright (via sfdx-node ... IMO you guys need first-party support for NPM). I use nodejs to create user, assign permset and all sort of other things. Here's my workhorse wrapper I extensively use in jest to drive my org.

One thing that stands out is that failing request has two slashes after domain

2021-01-23T07:15:41.5956366Z 2021-01-23T07:15:41.595Z sfdx:connection DEBUG request: {"url":"https://efficiency-ability-90682-dev-ed.cs43.my.salesforce.com//services/data/v50.0","method":"GET","headers":{"content-type":"application/json","user-agent":"sfdx toolbelt:"}}

vs

2021-01-23T07:58:36.1805001Z 2021-01-23T07:58:36.180Z sfdx:connection DEBUG request: {"url":"https://agility-force-32812-dev-ed.cs92.my.salesforce.com/services/data/v50.0","method":"GET","headers":{"content-type":"application/json","user-agent":"sfdx toolbelt:"}}

One thing that stands out is that failing request has two slashes after domain

2021-01-23T07:15:41.5956366Z 2021-01-23T07:15:41.595Z sfdx:connection DEBUG request: {"url":"https://efficiency-ability-90682-dev-ed.cs43.my.salesforce.com//services/data/v50.0","method":"GET","headers":{"content-type":"application/json","user-agent":"sfdx toolbelt:"}}

vs

2021-01-23T07:58:36.1805001Z 2021-01-23T07:58:36.180Z sfdx:connection DEBUG request: {"url":"https://agility-force-32812-dev-ed.cs92.my.salesforce.com/services/data/v50.0","method":"GET","headers":{"content-type":"application/json","user-agent":"sfdx toolbelt:"}}

@amphro any ideas why one would be using JWT another using access token and if that's the root cause?
I'm quite limited to what I can do with my devhub/repo.

@amphro any ideas why one would be using JWT another using access token and if that's the root cause?
I'm quite limited to what I can do with my devhub/repo.

Hi @sjurgiscould you try running this with the latest-rc build of the cli, you can install it with npm install sfdx-cli@latest-rc --global and uninstall it with npm uninstall sfdx-cli@latest-rc --global


Observe resource

Codecov Report

Merging #7 into master will decrease coverage by 7.02%.
The diff coverage is 2.43%.

@@            Coverage Diff             @@
##           master       #7      +/-   ##
==========================================
- Coverage   49.37%   42.34%   -7.03%
==========================================
  Files           8        9       +1
  Lines         241      281      +40
==========================================
  Hits          119      119
- Misses        105      145      +40
  Partials       17       17

Impacted Files
Coverage Δ

local/observeResource.go
0% <0%> (ø)

local/client.go
60% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b37abc...d24d567. Read the comment docs.


NSToolbar text-only mode is broken

The text-only mode of the toolbar is broken and does not work correctly in macOS 12. When the user has chosen text-only mode for the toolbar then the toolbar items that do not have a menu are not validated. Whether they are enabled or disabled (i.e. greyed out or not) seems to be unpredictable.
I have confirmed that it still works in macOS 10.13 (my earliest test environment). It seems that neither NSToolbarItem’s validate method is sent for these items nor the corresponding validateMenuItem method is used (neither is validateToolbarItem). Based on the comments I wrote at the time, validate is supposed to be sent for text-only toolbar items too:
// The default implementation of this method does nothing. Overriding this
// will allow any responder object to validate the toolbar item. This method
// is also invoked in text-only mode.
override func validate() {

From Apple’s old documentation:

Validation for view items is not automatic because a view item can be of unknown complexity. To implement validation for a view item, you must subclass NSToolbarItem and override validate (because NSToolbarItem’s implementation of validate does nothing for view items). In your override method, do the validation specific to the behavior of the view item and then enable or disable whatever you want in the contents of the view accordingly. If the view is an NSControl you can call setEnabled:, which will in turn call setEnabled: on the control.
In the absence of a custom menu form representation, NSToolbar by default disables a view item’s overflow menu item.
If a toolbar item has a custom menu form representation with no submenu, then the toolbar will validate the overflow menu item and the toolbar item’s text in Text Only Mode differently than it would with the default menu form representation: If the menu form representation menu item’s target implements validateMenuItem: (part of NSMenuValidation), the toolbar calls that method to validate both the overflow menu item and the toolbar item’s text in Text Only Mode.

Related or not ? : when the toolbar is in text-only mode, after you hit the "Refresh" button, the toolbar switches to text+icon mode…

It appears that the switch is provoked by this change of image : https://github.com/ViennaRSS/vienna-rss/blob/0b3bba857f49454d792497618191d4154445ee30/Vienna/Sources/Application/AppController.m#L1964

For some reasons, this quick and dirty hack works : replace item.image = … with ((NSButton *)item.view).image = …


[REQUEST] Implement schedule agencies ID verification (GTFS rule)

Is your feature request related to a problem? Please describe.
A schedule should not have IDless agencies, except if there's only a single agency defined. Agencies ID must be valid. This is a GTFS rule implemented in Google Python validator as ValidateIdlessAgency and ValidateRouteAgencyId.
Describe the solution you'd like
Actual Google GTFS validator behaviour : Verifies if an agency is IDless. An agency can be IDless only if a single agency is defined. Verifies if route agencies ID are valid (in agencies set).
https://github.com/google/transitfeed/blob/master/transitfeed/schedule.py line 1281
Describe alternatives you've considered
Additional context
Line 171 and 172 in Error support priorities https://docs.google.com/spreadsheets/d/1vqe6wq7ctqk1EhYkgtZ0_TbcQ91vccfs2daSjn20BLE/edit#gid=0

Implemented in https://github.com/MobilityData/gtfs-validator/pull/269

@lionel-nj can that issue be closed? Let me know if that's NOT the case

@fabrice-v This issue  can be closed., however verification of foreign key agency_id remains to do for GTFS attributions.txt and fare_attributes.txt. Keeping this issue opened as a reminder.

Closing this issue

Closing this issue, will backport implementation to check validity of fare_attributes.agency_id and attributions.agency_id in a future PR.


[DML] ResNet NCHW model tests doesn't meet the tolerance requirement

We defined tolerance as <0.005 here, but the results of resNet NCHW model tests only meet <0.01. So we need discussion on how to solve this problem.
[----------] 3 tests from ResNetNchwTests
[ RUN      ] ResNetNchwTests.NchwTest0
Error: The output value at index 5 is expected as -9.77821, but got -9.77252
../../src/tests/end2end/models/ResNetNchw.cpp(32): error: Value of: utils::CheckValue(result, outputNpy.as_vec<float>())
  Actual: false
Expected: true
[  FAILED  ] ResNetNchwTests.NchwTest0 (3628 ms)
[ RUN      ] ResNetNchwTests.NchwTest1
Error: The output value at index 26 is expected as -19.3955, but got -19.3886
../../src/tests/end2end/models/ResNetNchw.cpp(32): error: Value of: utils::CheckValue(result, outputNpy.as_vec<float>())
  Actual: false
Expected: true
[  FAILED  ] ResNetNchwTests.NchwTest1 (3197 ms)
[ RUN      ] ResNetNchwTests.NchwTest2
Error: The output value at index 5 is expected as -8.86224, but got -8.8562
../../src/tests/end2end/models/ResNetNchw.cpp(32): error: Value of: utils::CheckValue(result, outputNpy.as_vec<float>())
  Actual: false
Expected: true
[  FAILED  ] ResNetNchwTests.NchwTest2 (3144 ms)
[----------] 3 tests from ResNetNchwTests (9969 ms total)

We reported this issue to Hisham by mail on 15, Sept. We don't receive his reply till now.


Revert "Upgrade async deps"

Reverts 3scale/apisonator#314
There is a connection management issue described here: https://issues.redhat.com/browse/THREESCALE-7864?focusedCommentId=19394087&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-19394087

bors r+


Can't upload csv in firefox live system

Describe the bug
A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior:

Go to bayern.ehrenamtskarte.app/cards/import
Click on Mehrere Karten erstellen
Lade die gegebene CSV hoch (*)
See error "Ungültiger Dateityp"

(*) CSV datei
Name,Ablaufdatum,Kartentyp
Thea Test,03.3.2026,Standard
Tilo Torvitz,,Goldkarte
Torben Trost,,Goldkarte
Tina Tuchel,12.10.2024,Standard
Tamara Tsaregorodtseva,05.05.2025,Standard
Tom Thomasson,05.05.2025,Standard
Torsten Tuchele,1.1.2025,Goldkarte

Expected behavior
File is loaded and entries are displayed
Desktop (please complete the following information):

Browser firefox
Version ?

Additional context
Add any other context about the problem here.
maybe check out the discussion in this stackoveflow answer
https://stackoverflow.com/a/11834872

I cannot reproduce this. When I save the file as a .csv it works as expected. If I remove the file ending, uploading fails as expected. Also exporting a csv from libre-office works as expected, creating a correct csv that is recognized correctly.
I tried Firefox 118.0.2 (a very new version)
and Firefox 75.0 (release from april 2020)

I tested locally, if removing the "accept" value in the html changes anything and found that it doesn't, so I'd try to reopen #1059 and see if that changes anything. I'm pretty sure this will fix this.


ngModelController: trigger change when only property of model changes

Description
If you have an input box that is associated with a model that is an array (or an object), the update machinery ($formatter pipeline and so on) is not triggered if only a property on the array or object changes.  This is because ngModelController watches the model without checking objectEquality.
The multiple select input has a kind of hack that triggers a call to $render if the model updates a property but this fails to call the $formatter pipeline. If we push a new option into the array then the select renders OK but a required validator would fail to update.
Reproduction
See this http://plnkr.co/edit/yNFihkAgrVhHYx7lOtMc?p=preview.
Suggested Fix
Asking the NgModelController to watch with object equality would probably be the simplest solution. There may be a performance impact, though since most models are not objects or arrays then this should short-circuit quite quickly for those values.
Angular Version: 1.2.5+
OS: all
Related to : #5337

it seems like this issue is still open. I would like to have a go at fixing it. Is there any new information or planning available for this issue?
I thought, it might be possible to make the deep-watching configurable through the ngModelOptions (default = false i.e. no deep watching).
There is also still a comment in ngModel.js "TODO(perf): why not move this to the action fn?". Does someone have some history why this code wasnt moved to the action function in the first place (I assume with "action function" the listener is meant)  ?

It be cool if the option allowed for either deep equality or for it to use a watchCollection under the hood, this keeps it flexible.
@Narretz @antonkarsten any update on putting this into the next 1.5.x release?


BAU - pass environment

Add ticket reference to Pull Request title: e.g. 'FS-123: Add content', if there is no ticket prefix with BAU
Change description
A brief description of the pull request

[ ] Unit tests and other appropriate tests added or updated
[ ] README and other documentation has been updated / added (if needed)
[ ] Commit messages are meaningful and follow good commit message guidelines (e.g. "FS-XXXX: Add margin to nav items preventing overlapping of logo")

How to test
If manual testing is needed, give suggested testing steps
Screenshots of UI changes (if applicable)

Cannot be merged until environment fix is resolved (currently no magic redis uri value)


Add Emby connector

Added connector for Emby media server.
Album names are recognized only on album view, because i dont think the necessary info is provided anywhere else.
Tested on Emby v<IP_ADDRESS> and Chrome v55 / Opera v42

I'm testing right now the connector, and it didn't worked until I changed the isPlaying function:
diff --git a/connectors/v2/emby.js b/connectors/v2/emby.js
index 6fa3e210..e65421d5 100644
--- a/connectors/v2/emby.js
+++ b/connectors/v2/emby.js
@@ -9,7 +9,7 @@ Connector.artistSelector = '.nowPlayingBarText .textActionButton[data-type="Musi
 Connector.trackSelector = '.nowPlayingBarText .textActionButton[data-type="MusicAlbum"]';

 Connector.isPlaying = function () {
-       return $('.nowPlayingBarCenter .unpauseButton').hasClass('hide');
+       return $('.nowPlayingBarCenter .playPauseButton .md-icon').text() === 'pause';
 };

 Connector.getCurrentTime = function () {

Is this issue for me only? I'm using Emby 3.1.5.

No, it was the same for me after i have upgraded the server. The HTML structure changed a bit after the yesterday's update.

👍 Thanks!


Append has an extra )

Append([userPrincipalName], ".test")) should be Append([userPrincipalName], ".test") Notice the removal of a ')'

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: c8685339-06af-5bb1-64da-80c16878b0bf
Version Independent ID: 1ee0d812-00de-90cc-f5e2-d53e3b610bf0
Content: Writing Expressions for Attribute Mappings in Azure Active Directory
Content Source: articles/active-directory/active-directory-saas-writing-expressions-for-attribute-mappings.md
Service: active-directory
GitHub Login: @barbkess
Microsoft Alias: barbkess

@wesleykirkland Thanks for your feedback! We will investigate and update as appropriate.

@wesleykirkland Thanks for reporting! I have made the necessary change in the document and submitted the pull request.


AttributeError: module 'collections' has no attribute 'Mapping'

(env) xxxxx@xxxxxMacBook-Pro testProject % starknet-devnet
Traceback (most recent call last):
File "/Users/xxxxx/devData/starkNet/testProject/env/bin/starknet-devnet", line 5, in
from starknet_devnet.server import main
File "/Users/xxxxx/devData/starkNet/testProject/env/lib/python3.10/site-packages/starknet_devnet/server.py", line 4, in
from starkware.starknet.services.api.gateway.transaction import Deploy, InvokeFunction, Transaction
File "/Users/xxxxx/devData/starkNet/testProject/env/lib/python3.10/site-packages/starkware/starknet/services/api/gateway/transaction.py", line 13, in
from services.everest.api.gateway.transaction import (
File "/Users/xxxxx/devData/starkNet/testProject/env/lib/python3.10/site-packages/services/everest/api/gateway/transaction.py", line 5, in
from starkware.starkware_utils.validated_dataclass import ValidatedMarshmallowDataclass
File "/Users/xxxxx/devData/starkNet/testProject/env/lib/python3.10/site-packages/starkware/starkware_utils/validated_dataclass.py", line 13, in
from starkware.starkware_utils.validated_fields import Field
File "/Users/xxxxx/devData/starkNet/testProject/env/lib/python3.10/site-packages/starkware/starkware_utils/validated_fields.py", line 12, in
from starkware.starkware_utils.marshmallow_dataclass_fields import (
File "/Users/xxxxx/devData/starkNet/testProject/env/lib/python3.10/site-packages/starkware/starkware_utils/marshmallow_dataclass_fields.py", line 6, in
from frozendict import frozendict
File "/Users/xxxxx/devData/starkNet/testProject/env/lib/python3.10/site-packages/frozendict/init.py", line 16, in
class frozendict(collections.Mapping):
AttributeError: module 'collections' has no attribute 'Mapping'
OS: MacOS 12.0.1
python: 3.10
starknet-devnet: 0.1.6

When does this happen? How did you trigger it?

First try downgrading to starknet-devnet v0.1.5.
If that still fails, return to v0.1.6, but try with a lower version of Python (v3.9, v3.8, v3.7).

I've tried reproducing this locally and concluded that using Python 3.9 fixed the issue. It is now documented that Python 3.10 is not supported.


feat: add support for self-signed certificates

First of all: very cool project! I think this intermediate layer between plugin and llm backend makes a lot of sense.
Now regarding this issue: There is currently no way (that I am aware of) to let llm-ls trust custom self-signed certificates. This makes it impossible to communicate securely with backends that use such certificates.
After looking into this a bit, it seems that this could be alleviated relatively easily by not using the rustls-tls feature when importing reqwest:
reqwest = { version = "0.11", default-features = false, features = ["json", "rustls-tls"] }

By default, reqwest will then use system-native TLS (see: https://docs.rs/reqwest/latest/reqwest/#tls), which would allow the user to simply trust self-signed certificates within the OS and llm-ls should then also automatically trust this certificate.

Thanks!
By default AFAIK reqwest uses openssl, for which I've had issues with when building on multiple platforms. There might be a way to do it with rustls, I'd have to dig. Feel free to take a stab at this if you feel like it!


Create an OpenGL Core Context

Currently, SFML 2.0 doesn't have the ability to create a core OpenGL context (unless this is hidden by asking for a specific version number). It would be good if it had such an ability.

It has already been discussed a lot on the forum (and maybe on this tracker too).
SFML still uses deprecated functions in its graphics module, but once I get rid of them I'll support context flags in the public API.


Changing to wired breaks Joomla

I am using this in a custom Joomla template but changing "input" to "wired-input" breaks Joomla form. Joomla expects < input >.  Is there a way I can achieve the wired effect by using a css class instead of changing them to "wired-***" ?

Joomla does not recognize wired-input as an input.
See example - http://sketch.starazure.com  > Joomla > Login
If you try to login using username: admin and password: admin it thinks the fields are empty.
Also in the page - http://sketch.starazure.com/index.php/joomla/register
If you try to register it thinks all fields are empty.
If I change wired-input to "input" it works.
So back to my question - Is there a way I can use wired styles without changing my inputs to wired-inputs ? Ideally a css class would be more ideal.
I am kind of stuck because my theme is based on hang drawn elements and found this as its almost ready to be released.

Checkout https://www.getpapercss.com i think that may suit you well

That is a great alternative. Too bad I could not use Wired JS but thanks for the alternate solution.

I'm sure with further investigation we could solve the Joomla issue as well. If I were to take a hunch, Joomla is scanning for particular tag names. Or it has some issues with shadowdom/custom elements.

This could be the issue:
In my php file, the input is:
<wired-input class="form-control" type="text" name="username" id="username" value="" size="25" required="" aria-required="true" autofocus=""> </wired-input>
When it gets rendered, I see there is another input that gets generated inside wired-input with a different id as shown below:
<input id="txt" type="text" required="" autofocus="" size="25">

That input is inside a Shadow DOM, so it's protected. How do you tell Joomla what controls to use for the form? Or does it pick them up automatically?

This is how Joomla renders a field:
In my login php file, it calls the form field type
<?php echo $field->input; ?>
The in my form field text.php file I have this:
<input class="form-control" type="text" name="<?php echo $name; ?>" id="<?php echo $id; ?>" <?php echo $dirname; ?> value="<?php echo htmlspecialchars($value, ENT_COMPAT, 'UTF-8'); ?>" <?php echo implode(' ', $attributes); ?> />
I have a work around but does not work for emails
I did this
<wired-input type="text"> <input class="form-control" type="text" name="<?php echo $name; ?>" id="<?php echo $id; ?>" <?php echo $dirname; ?> value="<?php echo htmlspecialchars($value, ENT_COMPAT, 'UTF-8'); ?>" <?php echo implode(' ', $attributes); ?> /> </wired-input>
This worked BUT it wanted to show a tooltip with error, I get javascript errors:
An invalid form control with name='jform[name]' is not focusable. register:1 An invalid form control with name='jform[username]' is not focusable. register:1 An invalid form control with name='jform[email1]' is not focusable.

Seem like you or joomla is adding an input control as a child of wired-element. You don't need to do that. Wired-input creates an input element automatically inside a shadow-root. So now there are 2 inputs. I assume joomla is asking that inserted input for the value rather than asking the value from wired-input.

I just tried another option but that did not work either. Joomla still does not recognize it as an input.
I used jQuery as shown below.
Php file:
<input type="password" class="form-control wired"
JQuery:
`$(function () {
'use strict'
$(".wired").replaceWith(function() { return "" + this.innerHTML + ""; });
})
`
Result:

When I remove the jQuery, thus removing wired-input, it works but as expected its not a wired input.

I think the main problem here is that wired-input does not have the form-control class on it.
I don't see the code where you are inserting the wired-input. How are you defining it. Maybe add that class name?

form-control is just a Bootstrap class. It was adding an additional border and css properties so I had removed it. I added it back but it has no impact. Still facing the same issue.

I did some reading, and I think what I'll have to do is pass the name property from wired-input to the underlying input control.

I just released a new build.
Try v0.6.7 see if it helps.
<EMAIL_ADDRESS>

I already use<EMAIL_ADDRESS>It does not work and still says empty password.
Thanks for trying.

can you check if the  inside your  has a name attribute set?

Never mind, I just saw your site, and see that it is being set. Not sure what else to do here, and I dont really fancy learning joomla t the moment. :/

I understand. I don't know what to do either.


Issues #1881, #1882, #1961

These are a couple of minor fixes to fix issues #1881, #1882, and #1961 around months being updated when changing years and changing config options programatically. I also fixed the unit tests to run correctly independent of what time zone the computer running the tests is in.

Great fix! is it already clear when there will be a new release?


Running codegen to generate source yaml fails

Expected behavior
I would have expected the following command to generate yaml for the model files
dbt run-operation generate_source --args 'schema_name: my_schema'
Note - it works when I pass additional parameters such as the table names
Actual behavior
19:42:41  Running with dbt=1.8.1
19:42:42  Registered adapter: trino=1.8.0
19:42:43  Found 11 models, 1 snapshot, 48 data tests, 1 seed, 6 sources, 893 macros, 1 unit test
19:42:44  Encountered an error while running operation: Database Error
  TrinoUserError(type=USER_ERROR, name=SYNTAX_ERROR, message="line 18:28: mismatched input 'ilike'. Expecting: '%', '*', '+', '-', '.', '/', 'AND', 'AT', 'EXCEPT', 'FETCH', 'GROUP', 'HAVING', 'INTERSECT', 'LIMIT', 'OFFSET', 'OR', 'ORDER', 'UNION', 'WINDOW', '[', '||', <EOF>, <predicate>", query_id=20240525_194243_10461_izpe7)

Steps To Reproduce
Under models, I have a few folders which have their own folders
dbt run-operation generate_source --args 'schema_name: my_schema'
Log output/Screenshots
No response
Operating System
MacOS Sonoma 14.5
dbt version
1.8.1
Trino Server version
446-galaxy-1-u3-ge03ca8e8c2a
Python version
3.8.3
Are you willing to submit PR?

[ ] Yes I am willing to submit a PR!

codegen.generate_source utilizes dbt_utils.get_tables_by_pattern_sql underneath, where the ilike operator is used. Trino doesn't support ilike operator.
You need to install aditional package - trino_utils, which provides a Trino-compatible implementation of this macro.
Please install trino_utils package according to Installation Instructions, and it should work.


chore: do not use network_plugin default from sdk

This checklist is used to make sure that common guidelines for a pull request are followed.
Related command

the cli should not set network_plugin defaults. it should let the AKS RP handle defaulting.
General Guidelines

[x] Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
[x] Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
[x] My extension version conforms to the Extension version schema

For new extensions:

[ ] My extension description/summary conforms to the Extension Summary Guidelines.

About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Thank you for your contribution! We will review the pull request and get back to you soon.

Failures in the CI check are not related to the change, will fix in another PR #7775

#7775 merged, please rebase from main

@FumingZhang - looks like CI is passing now. thanks for the fix.

@zhoxing-ms PTAL


add to CI

just as other repos do, travis.ci needs to build this codebase. since the build needs to push to dockerhub and quay.io, this issue implicitly will require a makefile refactor. see https://github.com/deis/minio/pull/9/files#r46733280 for more

closing, as this is already in CI. I missed the travis file


Renaming ConnectionTypes isn't working

Renaming connection types, doesn't seem to fully work.
Type(ChatObject.self, as: "Chat") {
    Field("messages", at: ChatObject.messages, as: Connection<MessageObject>.self) {
                    Argument("first", at: \.first)
                    Argument("after", at: \.after)
                    Argument("last", at: \.last)
                    Argument("before", at: \.before)
    }
}

Type(MessageObject.self, as: "Message") {
    Field("id", at: \.id)
    Field("text", at: \.text)
}

ConnectionType(MessageObject.self, as: "Message")

I get the following error:
Fatal error: 'try!' expression unexpectedly raised an error: Type "MessageObjectConnection" was referenced but not defined.
When I don't rename the ConnectionType, then the schema builds, but I end up with MessageObjectConnection instead of MessageConnection.
If I don't include the Chat type, then the schema builds with the correct MessageConnection name.

@d-exclaimation do you have an idea of how to fix this?

Not 100% sure what's the problem. My guess is probably the fact the Message Object Connection is referenced in Chat type and renaming it somehow breaks that. I haven't used it personally in a while hut I can take a look at it

While on this topic, there's probably some sense in rethinking the Connection API sometime.
Some nice improvements would be:

Allowing connections of protocols or unions
Allowing custom fields on connections
Allowing custom fields on edges

These improvements would arguably make the Connection feature that much more powerful.
I have a bit of an idea of how this could be done, but my understanding is that there are issues around how to make this work with Codable.

@d-exclaimation the renaming issue is obviously more pressing (though it's still not the end of the world), but I thought you may have some ideas on everything else too

The main issue is fixed as of #109.

Since the main issue is fixed, I created a new issue #110 to discuss other improvements to connections that were mentioned above.


Fix/required form attribute LESQ-165

Description
Music year: 2005

Updates newsletter form

Issue(s)
Fixes #LESQ-165
How to test

Go to https://deploy-preview-2134--oak-web-application.netlify.thenational.academy/contact-us

Screenshots
How it used to look (delete if n/a):

How it should now look:

Checklist

[ ] Added or updated tests where appropriate
[ ] Manually tested across browsers / devices
[ ] Considered impact on accessibility
[ ] Design sign-off
[ ] Approved by product owner
[ ] Does this PR update a package with a breaking change

The label fields for the newsletter signup fields are aria-hidden="true" and I have no idea why this might be the case, as it means that, from a screen reader perspective, these fields have no labels. Functionally and visually it all looks correct, and I can see that Jack's comments are addressed by the latest changes.

Update: it seems that the aria-hidden attribute was originally added for a good reason:
https://github.com/oaknational/Oak-Web-Application/blame/fc4c27edd7ea569d3a0b23807a150ee002b61c52/src/components/Input/Input.tsx#L149
https://github.com/oaknational/Oak-Web-Application/pull/880#pullrequestreview-1140337057
So on that basis Kyle has reverted the change and I can discuss this with @jack-skerrett-oak in the new year. My initial suspicion is that the redundant aria-labelledby attribute on the label was causing VoiceOver to read the label twice, so the correct fix would have been to remove this redundant attribute rather than adding aria-hidden to the label.

:tada: This PR is included in version 1.311.6 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


migrate Discretization from tf.keras to keras_core

Hi @fchollet,
This PR is for migrating Discretization  from tf.keras to keras_core. But I didn't know you already migrated it, I checked it yesterday it was not there but no issues.

Thanks for the PR. This item is already completed.


getEpochsInfo without proofs not returning data when there is gap between epochs

Reproduction scenario
When the following is executed against testnet (where genesis epoch is 0 and then jumps directly to 895):
cd packages/dapi-grpc/protos/platform/v0
grpcurl -insecure -max-time 100 -d '{ "v0": { "start_epoch":1, "count": 10, "asc
ending": true } }' --proto platform.proto <IP_ADDRESS>:1443 org.dash.platform.dapi.v0.Platform.getEpochsInfo

it returns no epochs.
Expected behavior
Returns 10 epochs starting from 895.
Actual behavior
{
  "v0": {
    "epochs": {},
    "metadata": {
      "height": "5756",
      "coreChainLockedHeight": 1097091,
      "epoch": 1159,
      "timeMs": "1725526684695",
      "protocolVersion": 1,
      "chainId": "dash-testnet-51"
    }
  }
}

After some discussions it looks like this will not happen on mainnet, so we have decided we will not fix this one in near future.
Please reopen if it happens on mainnet.


Unable to ever close inventory when using search

When using the search bar, I stay locked in its focus and may never leave my inventory. I'm just stuck searching. Note that I can enter interact with everything within my current screen along with access the config view, just never exit.

https://github.com/isXander/Debugify/issues/109


Pin the openjdk docker version

Because openjdk:8 is always pointed to the latest revision of 8 series, the latest one disabled TLS 1.0 (~16 hours ago) thus causes the mysql test to fail, this PR pins the Docker image to an older tag with specific revision so that it won't be overrode again

Thanks for locating fast.


Missing dependency: lighthouse

Expected Behavior
The @puppeteer/replay is compiled without errors when it is installed as a dependency.
Actual Behavior
An error occurs when I bundle my app:

[vite]: Rollup failed to resolve import "lighthouse/core/fraggle-rock/api.js" from<EMAIL_ADDRESS>
This is due to lighthouse missing from the dependencies and/or peerDependencies in package.json. lighthouse is listed only as a devDependency, while in fact it is a normal dependency since the library source depends on it.
Steps to Reproduce the Problem

npm create vite@latest my-app -- --template vanilla
cd my-app && npm install
npm install --save @puppeteer/replay
Import from @puppeteer/replay in the main.js file:
import { PuppeteerRunnerExtension } from '@puppeteer/replay'
npm run build

Specifications

Version<EMAIL_ADDRESS>node 16.18.0
Platform: Linux

@adamraine could you please take a look?

So we prevent Lighthouse from being bundled using rollup externals:
https://github.com/puppeteer/replay/blob/961965eb6dfffd02191cbc6fee311df899ca1d7e/rollup.config.cjs#L20
I would expect tree shaking prevent rollup from using LighthouseRunnerExtension and therefore remove the need to import Lighthouse.
In any case, we should remove the lighthouse runner extension from the main bundle. Eventually we will make Lighthouse a peer dependency, but Lighthouse needs a lot of work with rollup plugins to work in bundled environments. If rollup can't automatically trim the Lighthouse import statements, maybe we should add a separate import path for Lighthouse like @puppeteer/replay/lighthouse.


F.clip does not allow x_min >= x_max

A suggestion to make F.clip behave more like numpy.clip allowing x_min >= x_max instead of raising an error.

Maybe it doesn't really make sense as no gradients are propagated 🤔

Let me close this issue.


Attempt to re-enable iam#testPermissions

https://github.com/googleapis/nodejs-storage/issues/393
Fix should be in prod. PR is to re-enable skipped test.

👋 thanks @frankyn!  Can you run npm run fix on this to get the linty in check?

Is this not blocked by system stestd as well?

Well hey, one step at a time 🤣 @kinwa91 is on fixing the system tests as we speak.

😸 lol, I'm a curious cat! Addressed lint issue.


Proofreading the chart descriptions in Grafana

What
I added descriptions for all 49 charts in Grafana. I need help with proofreading.
Charts on 3 Dashboards to be reviewed
Login credentials can be found in 1password > [EE] Demo & Test Env > AE staging grafana admin.

Delivery Efficiency
Delivery Quality
Delivery Cost

How to review and save chart descriptions?

Click on 'Edit' of a panel

Review the 'Description' section

Click on 'Save' to save dashboard

@Startrekzky Looks good, and logically it makes sense. I just made 1 small PR with some formatting fixes to DeliveryEfficiency.json. The rest don't need any changes

@Startrekzky @kevin-kline One thing that might be cool, to help user understand some common metric terms like "lead time", "PR/MR", "delivery time", "bug/issue" etc. - would be to make a list somewhere of these terms (maybe in a table, name/description)
We could put them in Grafana home page, or link to GRAFANA.md in github docs. Just an idea to help new users understand all these terms being used in the panel descriptions

Thanks @oddscenes , I think it's a good idea to put the common metrics explanation on the homepage. I planned to put it in the 'R&D Performance Metrics Analysis Guide', but that part will be too long. Maybe we can figure it out later.

Adding this to the phase 2 roadmap and closing for now #196


minor bugfixes and enhancements

Fixed mainWindow to hosting Window for FilterDataGrid in windows which are not the application main window
Disabled filtering of CollectionsViewSources for "CanFilter = false" (todo: check to set filter glyph invisible in this case)
Fixed German localization

approved contributions


ProducesResponseType

Codecov Report

Merging #20 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #20   +/-   ##
=======================================
  Coverage   45.35%   45.35%
=======================================
  Files          26       26
  Lines         377      377
=======================================
  Hits          171      171
  Misses        206      206

Impacted Files
Coverage Δ

...eakerMeet.Api/Controllers/CommunitiesController.cs
82.35% <ø> (ø)

...eakerMeet.Api/Controllers/ConferencesController.cs
82.35% <ø> (ø)

.../SpeakerMeet.Api/Controllers/SpeakersController.cs
82.35% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3fa2bc6...dce1e88. Read the comment docs.


Prism::Translation::Parser incompatibility with token type of left brace

Incompatibility in token types for Hash literals has been identified between Parser gem and Prism.
Below is the Gemfile common to expected and actual:
$ cat Gemfile
# frozen_string_literal: true

source "https://rubygems.org"

gem 'prism'
gem 'rubocop'

Expected Behavior
There is an expectation for tLBRACE token type of left brace to return, similar to that provided by Parser gem:
$ bundle exec ruby -rrubocop/ast -rprism -rprism/translation/parser/rubocop -ve "p RuboCop::AST::ProcessedSource.new('{key: value}', 3.3).tokens.map(&:type)"
ruby 3.3.0 (2023-12-25 revision 5124f9ac75) [x86_64-darwin22]
[:tLBRACE, :tLABEL, :tIDENTIFIER, :tRCURLY]

Actual Behavior
When using Prism as the backend, tLCURLY is returned as token type of left brace:
$ bundle exec ruby -rrubocop/ast -rprism -rprism/translation/parser/rubocop -ve "p RuboCop::AST::ProcessedSource.new('{key: value}', 80_82_73_83_77.33).tokens.map(&:type)"
ruby 3.3.0 (2023-12-25 revision 5124f9ac75) [x86_64-darwin22]
[:tLCURLY, :tLABEL, :tIDENTIFIER, :tRCURLY]

It is expected to return the same result as 3.3, even when the argument is 80_82_73_83_77.33.
Background
This difference in behavior was detected while I was working on the Prism integration, due to a failing test within RuboCop AST:

https://github.com/rubocop/rubocop-ast/blob/v1.30.0/spec/rubocop/ast/processed_source_spec.rb#L451-L452
https://github.com/rubocop/rubocop-ast/blob/v1.30.0/spec/rubocop/ast/processed_source_spec.rb#L451-L452

NOTE: This issue causes Layout/SpaceInsideHashLiteralBraces cop to not work with Prism.


Metadata import and other refactoring

Sorry for this big change list. Many small simple changes
Many datsets implemented task instead of AbstractTask and their behavior for status etc was different. Now all use either AbstractTask or AbstractTaskXYDataset.
Also the AllTaskFinishedListener needed to get some callbacks so that we can use it in the ProjectMetadataPaneController.importParameters .

I imported 100 times the same metadata sheet from the import dialog - using the AllTaskFinish listener and it seems to work fine - no memory leak. Thats only Javafx stuff here

All done from my side


Not receiving notifications from MIUI

Application
YouTube
Issue
I disable it but after restarting the phone the battery optimization is active again and the notifications don't come.  please help.
Patch

Motivation
notifications are not coming
Acknowledgements

[X] I have searched the existing issues and this is a new and no duplicate or related to another open issue.
[X] I have written a short but informative title.
[X] I filled out all of the requested information in this issue properly.

On MIUI devices, in addition to battery optimization exclusions, you must grant Autostarts permission


NP-1477: Reserved concurrent executions

Ensure the post authentication function for Cognito is always warm to
avoid it hitting timeout when trying to hit our post authentication
function.
It should hopefully be a work-around for
https://unit.atlassian.net/browse/NP-1477 to avoid broken logins.

@janbj @axthosarouris : I dont think it hurts to configure this, even tho it wont deal with the bug. So we merge?


Update URL with #anchor

Notes for Reviewers
This PR fixes #8951
Signed commits

[x] Yes, I signed my commits.

🚀 Preview for commit 4b63f736236c2e7e3d63b0380c06b78b8c06dfb9 at: https://6515470f9640e97afb908348--meshery-docs-preview.netlify.app

🚀 Preview for commit 4b439d7eaa106b52251607e6ab716c1e68475a76 at: https://651663063a3a353749f59b7b--meshery-docs-preview.netlify.app


Can view the conference schedule in-app

There should be a somewhere (probably the left-side navbar?) that opens a modal with a text description of the event schedule.
Presumably we want this to show the meetup schedule during the meetup, and the real conf schedule during the conf.
Stretch goal: highlight what time it currently is.

Extra stretch goal: would it be possible for all times to be shown in your local time zone? (Note I am very aware that time zones are extremely annoying to deal with programmatically! But I think it'd be great.)
I'm feeling inspired by https://gamesdonequick.com/schedule here. Not sure how they do it.

Janky and simple, but good enough for now. Includes local time zones.


TokenRequestValidation: parameter 'redirect_uri' can be omitted

Describe the bug
In a request of a token to the tokenEndpoint (using client method authentication private_key_jwt) the 'redirect_uri' parameter is mandatory if it's specified in the authorization request, but can be omissed and read from the authorization request. If it's specified, then it must be equals.
From OIDC specification https://openid.net/specs/openid-connect-core-1_0.html#TokenRequestValidation:
Ensure that the redirect_uri parameter value is identical to the redirect_uri parameter value that was included in the initial Authorization Request. If the redirect_uri parameter value is not present when there is only one registered redirect_uri value, the Authorization Server MAY return an error (since the Client should have included the parameter) or MAY proceed without an error (since OAuth 2.0 permits the parameter to be omitted in this case).
At the moment, it throws an OAuth2AuthenticationException (invalid_grant).
To Reproduce
When a token request is valid, it can be reproduced omitting the 'redirect_uri' parameter.
Expected behavior
The 'redirect_uri' shouldn't be mandatory, but it must be equals, if present, to the 'request_uri' that was specified in the authorization request.
Sample
if (StringUtils.hasText(authorizationRequest.getRedirectUri()) && 				!authorizationRequest.getRedirectUri().equals(authorizationCodeAuthentication.getRedirectUri())) { 			throw new OAuth2AuthenticationException(OAuth2ErrorCodes.INVALID_GRANT); 		}
I'd say this evaluation is reversed: ONLY IF authorizationCodeAuthentication.getRedirectUri() has text THEN it must be equals to authorizationRequest.getRedirectUri().

@itsmariohere The current logic...
if (StringUtils.hasText(authorizationRequest.getRedirectUri()) &&
		!authorizationRequest.getRedirectUri().equals(authorizationCodeAuthentication.getRedirectUri())) {
	throw new OAuth2AuthenticationException(OAuth2ErrorCodes.INVALID_GRANT);
}

...is correct as far as I can see. The validation only applies if the redirect_uri was supplied in the OAuth2AuthorizationRequest.
Can you provide a test that reproduces the issue you are having. You can start the test using something similar to authenticateWhenInvalidRedirectUriThenThrowOAuth2AuthenticationException().

If you would like us to look at this issue, please provide the requested information. If the information is not provided within the next 7 days this issue will be closed.

Closing due to lack of requested feedback. If you would like us to look at this issue, please provide the requested information and we will re-open the issue.


Add Logic for Landing page

Please describe the feature you want this project to offer
The login page should redirect to the game page, and the two names should show.
Describe the solution you'd like
Add Routing and prop passing to the game page

Can I work on it?
"/login" for directing to the login page directory.
My approach

I think title should be "Add Logic for login page".

Okay @PriyanshuPardhi24, you can go ahead with it!

Thank You @harshilparmar, I've edited the description for clarification

@r-ush can u specify is it a "login page" or a "landing page"

It would be in the landing page component only, the description of how it should be is given in the first description.
it should have two inputs to take in names of players and a play button

Hi @PriyanshuPardhi24
What's the update?


Added link to GH Action for posting to Teams

Created a GitHub Action to post to Microsoft Teams based on various GH events.

@pulkitaggarwl and me discussed it and felt that this PR is not the right fit for this repo.


Update contracts

Use new contract set for development environment
Update to latest contract ABIs

The recent smart contract updates are causing test failures. We need to resolve that before merging these update.

Fixed the test issues. I needed to get the voting adapter name using IVoting as a similar function which was once in Managing has been removed.


[doc] Add doxygen documentation to the project - [merged]

In GitLab by @perarnau on Apr 24, 2019, 15:32
Merges documentation -> master
Working documentation with:

Automatic online publshing onto readthedocs on gitlab tag events.
Documentation generation and packaging on make dist

Several things remain todo:

missing todo in aml.h
point documentation to release URL which does not exists yet since there is no release.

In GitLab by @perarnau on Apr 25, 2019, 13:03
merged
By Swann Perarnau on 2019-04-25T18:03:02 (imported from GitLab project)

In GitLab by @perarnau on Apr 25, 2019, 13:03
mentioned in commit fa1e22148709f465daa70e57bcd712bb59fc5d91
By Swann Perarnau on 2019-04-25T18:03:02 (imported from GitLab project)

In GitLab by @perarnau on Apr 24, 2019, 15:48
added 1 commit
fb89ba6e - Format vector documentation
Compare with previous version
By Nicolas Denoyelle on 2019-04-24T20:48:32 (imported from GitLab project)

In GitLab by @perarnau on Apr 24, 2019, 15:51
added 1 commit
1b46d2e0 - checkpatch
Compare with previous version
By Nicolas Denoyelle on 2019-04-24T20:51:01 (imported from GitLab project)

In GitLab by @perarnau on Apr 25, 2019, 08:50
Documentation with code samples
By Nicolas Denoyelle on 2019-04-25T13:50:58 (imported from GitLab project)

In GitLab by @perarnau on Apr 25, 2019, 08:50
Typo Tiling 2D
By Nicolas Denoyelle on 2019-04-25T13:50:46 (imported from GitLab project)

In GitLab by @perarnau on Apr 25, 2019, 09:18
Trigger doc on master plus release branches on event push.
Do protect release versions branches with name vX.X.X
By Nicolas Denoyelle on 2019-04-25T14:18:57 (imported from GitLab project)

In GitLab by @perarnau on Apr 25, 2019, 09:45
added 3 commits
4470d0a4 - Write file purpose9c08e747 - fix typo2b8fd66c - fix release pipeline stage
Compare with previous version
By Nicolas Denoyelle on 2019-04-25T14:45:41 (imported from GitLab project)

In GitLab by @perarnau on Apr 25, 2019, 09:47
added 1 commit
3b831dab - fix syntax
Compare with previous version
By Nicolas Denoyelle on 2019-04-25T14:47:55 (imported from GitLab project)

In GitLab by @perarnau on Apr 25, 2019, 12:52
changed title from {-Documentation-} to {+[doc] Add doxygen documentation to the project+}
By Swann Perarnau on 2019-04-25T17:52:31 (imported from GitLab project)

In GitLab by @perarnau on Apr 25, 2019, 12:52
changed the description
By Swann Perarnau on 2019-04-25T17:52:31 (imported from GitLab project)

In GitLab by @perarnau on Apr 25, 2019, 12:52
assigned to @perarnau
By Swann Perarnau on 2019-04-25T17:52:31 (imported from GitLab project)

In GitLab by @perarnau on Aug 6, 2019, 13:56
mentioned in commit fa1e22148709f465daa70e57bcd712bb59fc5d91


HTTP body conversion will throw an InvalidOperationException when the request have an empty body

Description
HTTP body conversion will throw an InvalidOperationException when the request have an empty body.

When using the ASP.NET Core integration, a response is never sent back to the client, the request will hang. (Maybe related to #2476)

With the built-in HTTP type with the default System.Text.Json serializer, a response with status code 500 will be sent back to the client.

With the built-in HTTP type with Newtonsoft as the serializer :

Sending an empty body will throw and a response with status code 500 will be sent back to the client.
Sending an empty body with the header Content-Type: application/json allows the conversion to proceed without any error. The AzureFunction will receive a null object.

With the in-process model sending an empty body will create an instance of the object.

With the built-in HTTP type I have traced the origin of the issue(s) back to this line of the DefaultFromBodyConversionFeature.
Steps to reproduce
This repository has been made available to demonstrate the issue.
Debug each project one by one and send all 3 request to them :
curl -d '{ "Name": "potato" }' -H "Content-Type: application/json" -X POST http://localhost:7021/api/Function1 -v
curl -H "Content-Type: application/json" -X POST http://localhost:7021/api/Function1 -v
curl -X POST http://localhost:7021/api/Function1 -v
This will demonstrate the issues and the difference in behavior between them.
The latest version of the packages have been used :
    Microsoft.Azure.Core.NewtonsoftJson v2.0.0
    Microsoft.Azure.Functions.Worker v1.22.0
    Microsoft.Azure.Functions.Worker.Extensions.Http v3.2.0
    Microsoft.Azure.Functions.Worker.Extensions.Http.AspNetCore v1.3.1
    Microsoft.Azure.Functions.Worker.Sdk v1.17.2

Specifically for the case when a response is never sent back to the client, it was fixed in v1.3.2. It was related to #2476.


[$500] Threads - When deleting the last unread message, the "New" marker appears for a second

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: <IP_ADDRESS>
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Action Performed:

Open a chat
Send two messages
Click on "Mark as unread" on the first message
Delete the messages one by one

Expected Result:
The new marker disappears with no delay
Actual Result:
The new marker disappears after a delay
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence
https://github.com/Expensify/App/assets/93399543/80457243-2963-4f49-af63-ecdf717d78d2
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01e466a8c7c7ded031
Upwork Job ID:<PHONE_NUMBER>491375616
Last Price Increase: 2023-12-04

Proposal
Please re-state the problem that we are trying to solve in this issue.
What is the root cause of that problem?
We update the unread marker only after the action is actually deleted (the API response comes). Therefore, the marker is briefly visible while the API request is running.
What changes do you think we should make in order to solve the problem?
We should hide the marker when the last action has has pending DELETE action.
For this, in this function, we should also return false if the reportAction has pending DELETE action:
if (reportAction.pendingAction === CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE) {
    return false;
}

https://github.com/Expensify/App/blob/8bb02a4715e0724499a9c8969b73ba34f0037d3e/src/pages/home/report/ReportActionsList.js#L334-L354
What alternative solutions did you explore? (Optional)

This issue was addressed here https://github.com/Expensify/App/pull/30485#issuecomment-1784859939
I think the suggested solution would solve the issue

Dupe of https://github.com/Expensify/App/issues/25606

Closing as this is a dupe!

@ArekChr any thoughts on the proposals from paultsimura and s-alves10 in another PR

As previously discussed, we agreed to address this issue in a separate PR. I've reviewed the solution provided by @s-alves10 in PR #30485 and it solves the bug. Given that @s-alves10 has already developed a working fix, I think we should go ahead with this approach.
:ribbon: :eyes: :ribbon: C+ reviewed

Thanks! Looks good, since we're ReportActionsUtils.ts, let's make sure we don't add any regression.

@ArekChr
PR is ready for review https://github.com/Expensify/App/pull/32474

This has caused regression. We're working on a fix

PR is in review

Not paying out yet due to regression.

@MonilBhavsar can you let me know when the regression is resolved for payout please?

PR is deployed to production yesterday. I'll add seven days and update the title

not overdue yet, waiting for regression 7 day period.

*Payment summary
@ArekChr does not require payment (Contractor)
@s-alves10 requires payment automatic offer (Contributor) - PAID $500.


[Flake] Spanner backup_extra_integration_test timeout in integration-daily

https://storage.googleapis.com/cloud-cpp-community-publiclogs/logs/google-cloud-cpp/main/b26a3594d97bd4dce5be67b84a95cc83027ba774/fedora-34-integration-daily/log-41205cf7-cb1a-47bb-9c62-ea8ced6d1e94.txt

Here is one with the decreased LRO polling-time limit, which therefore fails before the timeout, and so shows an RPC trace of what we were waiting for.

GCB: https://console.cloud.google.com/cloud-build/builds;region=us-east1/3b521951-cb36-4382-87fe-4735560a633b;tab=detail?project=cloud-cpp-testing-resources
Raw: https://storage.googleapis.com/cloud-cpp-community-publiclogs/logs/google-cloud-cpp/main/ad4e1dc2b80420918f62c866cf448cde59f367ae/fedora-34-integration-daily/log-3b521951-cb36-4382-87fe-4735560a633b.txt

Closing in favor of #8616.


More efficient serialization of escaped characters

The following benchmark shows more than 20x speed up during serialization of string with escaped characters for these changes:
https://github.com/plokhotnyuk/jsoniter-scala/blob/8d0ddbe182c976cd2719fc96ff00e5d2b0a4328b/jsoniter-scala-benchmark/src/main/scala/com/github/plokhotnyuk/jsoniter_scala/macros/StringOfEscapedCharsBenchmark.scala#L82
Before:
[info] REMEMBER: The numbers below are just data. To gain reusable insights, you need to follow up on
[info] why the numbers are the way they are. Use profilers (see -prof, -lprof), design factorial
[info] experiments, perform baseline and negative tests that provide experimental control, make sure
[info] the benchmarking environment is safe on JVM/OS/HW level, ask for reviews from the domain experts.
[info] Do not assume the numbers tell you what you want them to tell.
[info] Benchmark                                                                  (size)   Mode  Cnt       Score       Error   Units
[info] StringOfEscapedCharsBenchmark.writeCirce                                      128  thrpt   15   16580.718 ±   489.095   ops/s
[info] StringOfEscapedCharsBenchmark.writeCirce:·gc.alloc.rate                       128  thrpt   15    1430.753 ±    42.074  MB/sec
[info] StringOfEscapedCharsBenchmark.writeCirce:·gc.alloc.rate.norm                  128  thrpt   15  135799.257 ±    20.702    B/op
[info] StringOfEscapedCharsBenchmark.writeCirce:·gc.churn.PS_Eden_Space              128  thrpt   15    1432.215 ±   253.708  MB/sec
[info] StringOfEscapedCharsBenchmark.writeCirce:·gc.churn.PS_Eden_Space.norm         128  thrpt   15  135806.370 ± 22262.913    B/op
[info] StringOfEscapedCharsBenchmark.writeCirce:·gc.churn.PS_Survivor_Space          128  thrpt   15       0.021 ±     0.019  MB/sec
[info] StringOfEscapedCharsBenchmark.writeCirce:·gc.churn.PS_Survivor_Space.norm     128  thrpt   15       1.955 ±     1.753    B/op
[info] StringOfEscapedCharsBenchmark.writeCirce:·gc.count                            128  thrpt   15      32.000              counts
[info] StringOfEscapedCharsBenchmark.writeCirce:·gc.time                             128  thrpt   15      34.000                  ms

After:
[info] REMEMBER: The numbers below are just data. To gain reusable insights, you need to follow up on
[info] why the numbers are the way they are. Use profilers (see -prof, -lprof), design factorial
[info] experiments, perform baseline and negative tests that provide experimental control, make sure
[info] the benchmarking environment is safe on JVM/OS/HW level, ask for reviews from the domain experts.
[info] Do not assume the numbers tell you what you want them to tell.
[info] Benchmark                                                                  (size)   Mode  Cnt       Score      Error   Units
[info] StringOfEscapedCharsBenchmark.writeCirce                                      128  thrpt   15  362014.105 ± 6127.986   ops/s
[info] StringOfEscapedCharsBenchmark.writeCirce:·gc.alloc.rate                       128  thrpt   15    1083.880 ±   18.428  MB/sec
[info] StringOfEscapedCharsBenchmark.writeCirce:·gc.alloc.rate.norm                  128  thrpt   15    4712.001 ±    0.001    B/op
[info] StringOfEscapedCharsBenchmark.writeCirce:·gc.churn.PS_Eden_Space              128  thrpt   15    1069.504 ±  362.388  MB/sec
[info] StringOfEscapedCharsBenchmark.writeCirce:·gc.churn.PS_Eden_Space.norm         128  thrpt   15    4651.869 ± 1581.798    B/op
[info] StringOfEscapedCharsBenchmark.writeCirce:·gc.churn.PS_Survivor_Space          128  thrpt   15       0.015 ±    0.021  MB/sec
[info] StringOfEscapedCharsBenchmark.writeCirce:·gc.churn.PS_Survivor_Space.norm     128  thrpt   15       0.066 ±    0.092    B/op
[info] StringOfEscapedCharsBenchmark.writeCirce:·gc.count                            128  thrpt   15      24.000             counts
[info] StringOfEscapedCharsBenchmark.writeCirce:·gc.time                             128  thrpt   15      27.000                 ms

Codecov Report

Merging #962 into master will increase coverage by 0.07%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #962      +/-   ##
==========================================
+ Coverage   85.24%   85.32%   +0.07%
==========================================
  Files          74       74
  Lines        2331     2330       -1
  Branches      150      148       -2
==========================================
+ Hits         1987     1988       +1
+ Misses        344      342       -2

Impacted Files
Coverage Δ

.../core/shared/src/main/scala/io/circe/Printer.scala
94.89% <100%> (-0.03%)
:arrow_down:

...re/shared/src/main/scala/io/circe/JsonNumber.scala
93.58% <0%> (+2.56%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 773656a...aaa78a4. Read the comment docs.

Nice, thanks @plokhotnyuk!


Java: subjective reorganization of some classes

Motivation and Context

Description

Contribution Checklist

[ ] The code builds clean without any errors or warnings
[ ] The PR follows the SK Contribution Guidelines and the pre-submission formatting script raises no violations
[ ] All unit tests pass, and I have added new tests where possible
[ ] I didn't break anyone :smile:

Duplicate of PR #5039


Properly flush the status / results file after handling

Logs weren't showing up promptly for us, and this fixes it.

The diff ignoring whitespace is easier to read.


feat: add 64-bit RISC-V support

This is a rework of https://github.com/simonschoening/libhermit-rs/commit/011b34df2eb5e0f6c9ee3cd652a1644f1b9a27d7.
Closes https://github.com/hermit-os/kernel/issues/100
Closes https://github.com/hermit-os/kernel/pull/277
Closes https://github.com/hermit-os/kernel/issues/439

I finally got to merge this! 🥳


Public Announcement

It'd better if we announce this product to public in something like producthunt etc or is it done somewhere?

This is a great idea.
We think we should have two features until the project is ready for producthunt.

integrate a more intelligent matching of English questions through Bert based models.
change the UI to English

@Timoeller  agree, or actually multilanguage, should not be too complicated and doable on the weekend.


v1 Project Card Conversion

The primary purpose of this PR is to upgrade this repository to have ProjectCard v1 compliant schema.
📇 Updates cards

Moves v0 cards to projects_v0
Puts v1 cards in projects
Validates all cards with ProjectCard

🟢 Makes sure cards put in projects pass validation

Adds a workflow to test validation of project cards with latest version of projectcard

🔧  Adds tooling

local script for executing project card conversion in a batch manner  convert_to_v1
batch validation validate_cards

@i-am-sijia This should be ready for review and merging - LMK if you have any requested changes!


Hardware configuration for habitat-sim

Does habitat-sim must be installed on a computer with GPU?

Habitat-sim can run on computer without a dedicated GPU. Performance may be poor, however.


Inheritance

I just hit my first need for a subclass. It would be super cool if Firemodel could support something like:
model FilingQuestion: Question {
    option firestore.path = "users/{user_id}/filings/{filing_id}/questions/{question_id}";
}

Til then, I'll be coding this one up manually.

Let's discuss this. Pring is going to be an obstacle, and I'm not sure yet how to deal with it.


Segfault when calling Atom.GetBonds()

Describe the bug
Segfault when calling GetBonds() on an Atom
To Reproduce
$ python -c "from rdkit import Chem; mol = Chem.MolFromSmiles('CCC'); Chem.AddHs(mol).GetBonds()[0].GetEndAtom().GetBonds()"
Segmentation fault (core dumped)
Expected behavior
Should output the bonds corresponding to whichever atom is the end atom of the molecule's first bond.
Screenshots
N/A
Configuration (please complete the following information):

RDKit version: 2023.03.2       py311hc21844d_0    conda-forge
OS: [e.g. Ubuntu 20.04] Happens on Ubuntu 22.04.2 LTS and arch linux 6.4.4-arch1-1
Python version (if relevant): 3.11.0 and 3.11.3
Are you using conda? Yes (actually using mamba, not conda)
If you are using conda, which channel did you install the rdkit from? conda-forge
If you are not using conda: how did you install the RDKit? N/A

Additional context
I have the same problem with any SMILES string I try. However, it works fine if I don't call Chem.AddHs() first, or if I split the code into multiple lines (the following works fine):
from rdkit import Chem
mol = Chem.MolFromSmiles('CCC')
mol2 = Chem.AddHs(mol)
print(mol2.GetBonds()[0].GetEndAtom().GetBonds())

This is awell- known issue due to the object lifetime management between C++ and Python.
As you have already found, you need to assign intermediate C++ objects to a variable to avoid that they are destroyed before being used, which is what causes the segfault, e.g.:
python -c "from rdkit import Chem; mol = Chem.MolFromSmiles('CCC'); mol_h = Chem.AddHs(mol); mol_h.GetBonds()[0].GetEndAtom().GetBonds()"

Therefore, yes, this is a bug, but there is a very simple workaround and, unfortunately, no easy solution.

Ah okay, I didn't realize this was well-known and difficult to solve (didn't find anything when I searched for issues with segfaults on GetBonds()). Thanks for the reply!


HIVE-2558: Drop codegen k8s.io/code-generator

generate-groups.sh was deprecated in k8s.io/code-generator 1.29 and deleted in 1.30. Instead, the usage was replaced with:

kube_codegen.sh library's kube::codegen::gen_helpers

The issue with the above is:

It doesn't allow to specify just running deepcopy and instead adds as well code conversion and defaulter code generation.
While deepcopy-gen and conversion-gen can deal well with the multiple input paths that we have, conversion-gen wants to work at the package level, which means it ends up wrongly processing the vendored k8s deepcopy directives. This in turn means that we are forced to use the kubernetes header files to respect their copyright, but ends up adding the kubernetes copyright to openshift generated code.
gen_helpers enforces usage of --output-base matching the import name, which means that we had to workaround with a symlink of ${REPO_ROOT}/github.com/openshift/ to "${REPO_ROOT}..".
vendored generated deepcopy got deleted and make vendor had to pick up the tab.

/remove-lifecycle stale
@celebdor lmk if you want me to pick this up.


Mistake in experiment.py file

In the forward function in experiment.py file, shouldn't it be:
return self.model.forward(input, **kwargs),
instead of
return self.model(input, **kwargs)
If not, please explain why as I'm unable to understand. Thanks!

Hi, did you encounter this problem like below? If yes, did you solve this problem? Thank you
pytorch_lightning.utilities.exceptions.MisconfigurationException: The provided lr scheduler ExponentialLR doesn't follow PyTorch's LRScheduler API. You should override the LightningModule.lr_scheduler_step hook with your own logic if you are using a custom LR scheduler.

https://discuss.pytorch.org/t/any-different-between-model-input-and-model-forward-input/3690
this link may help you.

Behind the curtain, the call to model is exactly model.forward :)


Refactor Processor shutdown behavior to wait until buffers are empty before preparing for shutdown

~Note: this PR is incomplete. Creating now to get early feedback. Outstanding items:~

~Testing~
~Documentation~

Description
This PR refactors the shutdown behavior to wait until the local buffer and peer forwarder buffer are empty and a configurable peer forwarder drain timeout has expired before preparing the processors for shutdown. This is to prevent flushing or reopening partial windows in the stateful aggregators.
Issues Resolved
Partially #1770
Check List

[x] New functionality includes testing.
[x] New functionality has been documented.

[x] New functionality has javadoc added

[x] Commits are signed with a real name per the DCO

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #1792 (6dcff19) into main (5cae696) will decrease coverage by 0.23%.
The diff coverage is 70.37%.

:exclamation: Current head 6dcff19 differs from pull request most recent head c1c5ae6. Consider uploading reports for the commit c1c5ae6 to get more accurate results

@@             Coverage Diff              @@
##               main    #1792      +/-   ##
============================================
- Coverage     94.01%   93.78%   -0.24%
- Complexity     1454     1461       +7
============================================
  Files           188      188
  Lines          4263     4297      +34
  Branches        344      347       +3
============================================
+ Hits           4008     4030      +22
- Misses          174      186      +12
  Partials         81       81

Impacted Files
Coverage Δ

.../dataprepper/peerforwarder/LocalPeerForwarder.java
75.00% <0.00%> (-25.00%)
:arrow_down:

...dataprepper/peerforwarder/RemotePeerForwarder.java
84.31% <0.00%> (-1.69%)
:arrow_down:

...pper/peerforwarder/PeerForwarderConfiguration.java
85.26% <28.57%> (-2.17%)
:arrow_down:

...opensearch/dataprepper/pipeline/ProcessWorker.java
79.62% <74.28%> (+5.34%)
:arrow_up:

.../opensearch/dataprepper/parser/PipelineParser.java
85.31% <100.00%> (+0.42%)
:arrow_up:

...eerforwarder/PeerForwardingProcessorDecorator.java
100.00% <100.00%> (ø)

.../org/opensearch/dataprepper/pipeline/Pipeline.java
88.57% <100.00%> (-4.19%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

However, I don't see this in use. Is this more of a draft?

Yes, working on integration now. I'll request a re-review once it's "done", hoping to do so by EOD

Should be ready for re-review assuming checks pass @dlvenable @asifsmohammed
I functionally tested with drain_timeout and an aggregate processor, shutdown worked as intended
2022-09-28T16:06:48,785 [main] INFO  org.opensearch.dataprepper.parser.PipelineParser - Building sinks for the pipeline [log-pipeline]
2022-09-28T16:06:48,785 [main] INFO  org.opensearch.dataprepper.parser.PipelineParser - Building [stdout] as sink component
2022-09-28T16:06:48,786 [main] INFO  org.opensearch.dataprepper.parser.PipelineParser - Constructing MultiBufferDecorator with [1] secondary buffers for pipeline [log-pipeline]
...
2022-09-28T16:06:49,045 [main] INFO  org.opensearch.dataprepper.pipeline.server.DataPrepperServer - Data Prepper server running at :4901
2022-09-28T16:06:52,047 [log-pipeline-processor-worker-1-thread-1] INFO  org.opensearch.dataprepper.pipeline.ProcessWorker -  log-pipeline Worker: No records received from buffer
2022-09-28T16:07:02,917 [log-pipeline-processor-worker-1-thread-1] INFO  org.opensearch.dataprepper.pipeline.ProcessWorker -  log-pipeline Worker: Processing 1 records from buffer
2022-09-28T16:07:10,171 [HTTP-Dispatcher] INFO  org.opensearch.dataprepper.pipeline.Pipeline - Pipeline [log-pipeline] - Received shutdown signal with processor shutdown timeout PT30S and sink shutdown timeout PT10S. Initiating the shutdown process
2022-09-28T16:07:12,242 [HTTP-Dispatcher] INFO  org.opensearch.dataprepper.plugins.source.loghttp.HTTPSource - Stopped http source.
2022-09-28T16:07:12,243 [HTTP-Dispatcher] INFO  org.opensearch.dataprepper.pipeline.Pipeline - Pipeline [log-pipeline] - Shutting down process workers
2022-09-28T16:07:14,935 [log-pipeline-processor-worker-1-thread-1] INFO  org.opensearch.dataprepper.pipeline.ProcessWorker - Processor shutdown phase 1 complete.
2022-09-28T16:07:14,935 [log-pipeline-processor-worker-1-thread-1] INFO  org.opensearch.dataprepper.pipeline.ProcessWorker - Beginning processor shutdown phase 2, iterating until buffers empty.
2022-09-28T16:07:14,937 [log-pipeline-processor-worker-1-thread-1] INFO  org.opensearch.dataprepper.pipeline.ProcessWorker - Processor shutdown phase 2 complete.
2022-09-28T16:07:14,938 [log-pipeline-processor-worker-1-thread-1] INFO  org.opensearch.dataprepper.pipeline.ProcessWorker - Beginning processor shutdown phase 3, iterating until<PHONE_NUMBER>937.
2022-09-28T16:07:26,955 [log-pipeline-processor-worker-1-thread-1] INFO  org.opensearch.dataprepper.pipeline.ProcessWorker - Processor shutdown phase 3 complete.
2022-09-28T16:07:26,956 [log-pipeline-processor-worker-1-thread-1] INFO  org.opensearch.dataprepper.pipeline.ProcessWorker - Beginning processor shutdown phase 4, preparing processors for shutdown.
2022-09-28T16:07:26,958 [log-pipeline-processor-worker-1-thread-1] INFO  org.opensearch.dataprepper.pipeline.ProcessWorker - Processor shutdown phase 4 complete.
2022-09-28T16:07:26,958 [log-pipeline-processor-worker-1-thread-1] INFO  org.opensearch.dataprepper.pipeline.ProcessWorker - Beginning processor shutdown phase 5, iterating until processors are ready to shutdown.
{"destinationIp":"<IP_ADDRESS>","message":"peer forwarding","sourceIp":"<IP_ADDRESS>","status":200,"@timestamp":"2022-09-28T16:07:29.961-05:00"}
2022-09-28T16:07:29,982 [log-pipeline-processor-worker-1-thread-1] INFO  org.opensearch.dataprepper.pipeline.ProcessWorker - Processor shutdown phase 5 complete.
2022-09-28T16:07:29,983 [HTTP-Dispatcher] INFO  org.opensearch.dataprepper.pipeline.Pipeline - Pipeline [log-pipeline] - Shutting down process workers
2022-09-28T16:07:29,991 [HTTP-Dispatcher] INFO  org.opensearch.dataprepper.pipeline.server.DataPrepperServer - Data Prepper server stopped

1 last piece coming - going to bump the default processorShutdownTimeout to 30s instead of 10s since the default peer forwarder drain timeout is 10s

Thanks for making these significant changes!


Return Types/Objects Not Documented

The return types/objects appear to not be documented.  Expected returned samples...

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 502427ff-b3ec-a619-ab19-ee4b4ef86854
Version Independent ID: 05a343a1-64ff-51d2-8eb0-e0dc41efea9f
Content: Get-SPEnterpriseSearchTopology (sharepoint-server)
Content Source: sharepoint/sharepoint-ps/sharepoint-server/Get-SPEnterpriseSearchTopology.md
Service: sharepoint-2016-powershell
GitHub Login: @techwriter40
Microsoft Alias: kirks

@kirkpabk thank you for your submission.  If you are referring to the Input or Output sections, these are part of the schema template, but we do not use them, so they are left blank intentionally.  thank you.


add a TelnetEvent for raw messages

When encoding a TelnetEvent::Message, it guarantees a \r\n ending to all of its output, but that isn't always desirable. Add a new event called TelnetEvent::RawMessage that acts like a ::Message, but does not add the \r\n.
Incoming events never decode to ::RawMessage. It's intended for encoding outgoing messages only.
I added this today because I need this behavior for my project, but I'm not sure what your thoughts are on it, since it adds a new TelnetEvent. I haven't added tests yet because I want to make sure we're aligned on api / need first.

I think a RawMessage event makes sense. Will need to add some doc comments to the event types to explain the difference between the two.

Looks good!


Review gas difference between DR inclusion vs result inclusion

Right now there is a huge difference between the gas required for DR inclusion and the result inclusion.
The idea is to identify what is happening behind the curtains and identify if there is any improvement to reduce gas cost.

@clbartoli and I found out the main differences regarding the gas costs of reportDataRequestInclusion and reportResult functions:

reportDataRequestInclusion calls abs.pushActivity(requests[_id].pkhClaim, block.number); which has an intensive gas cost (>100k gas)
reportDataRequestInclusion calls a digest function with an usually slightly bigger argument (_result data is usually smaller than _poi[0])

(1) shows that it might be interesting to review the ActiveBridgeSetLib.sol contract to reduce gas costs.


url match error in hybrid app (traversal+url dispatch)

I am getting error 400. "Could not find a matching Swagger operation" for valid paths.
I believe that the route is not matching because is configured with traversal.
the route.path given to spec.get_op_for_request() is:
/api/*traverse
(as is defined in app configuration)
If I replace route.path with request.path_info
it works in some cases but fails for routes that has parameters.
ie, works with: /api/method
but fails with: /api/method/1
the latest could not be validated against:
swagger: '2.0'
basePath: /api
paths:
  /method:
    get:
      description: xxx
      parameters:
        - name: id
          in: path
          description: xxxx
          required: true
          type: integer
          format: int32
      responses:
        200:
          description: OK

What version of pyramid are you using? And can you give a super simple endpoint definition for your pyramid app?
I can't say I'm very familiar with traversal style configuration, but I'm happy to help add context if you're interested in getting it working w/ pyramid_swagger.

I'm using pyramid 1.7.
Reviewing the code, I think it is not possible to make it work that way, since there not exists the patterns to match paths in swagger definition.
Anyway,
here
is a small app with a test case.
Thanks.

Definitely thanks for the reproduction. I suspect it is possible (Pyramid must be able to do path resolution or it couldn't route!) but it will likely be a little different from how the normal resolution is done.
I'll leave this open in case someone else comes across the same issue.


GH-1679 only include rdf4j-storage poms

(and by extension, rdf4j-client as well)
This ensures rdf4j-runtime only includes the libraries necessary for
anyone building RDF4J-based applications, and doesn't include
additional dependencies like the workbench or console - which are not
commonly necessary for app dev purposes. This is mostly to consolidate and remove discrepancies between the various umbrella poms we have in play.
GitHub issue resolved: #1679
Briefly describe the changes proposed in this PR:

apps depending on rdf4j-runtime pom dependency now include everything in rdf4j-storage and rdf4j-client
it does not include rdf4j-console, workbench and server modules, and therefore also not things like logback.

Only seems to include rdf4j-storage, was that intentional?

@hmottestad that module includes a lot of other ones, transitively. Do you think there's something missing?

I don’t know if anything else is needed, so I reckon this is fine :)

You mentioned RDF4J-client in your PR, so I just wondered if it should also have been included or if it is included transitively. I don’t know if it is needed.

Ah fair point. It is included transitively, but it might be clearer to include it explicitly.


Error destroying new Rails model

It's not immediately obvious to me what's going on here as I don't know the Rails destroy mechanism very well, but destroying a model right after creating it in a brand new app throws a file not found error:
...
13: from .../gems/fabrication-2.21.0/lib/.../model_generator.rb:11:in `create_fabrication_file'
12: from .../gems/fabrication-2.21.0/.../model_generator.rb:27:in `copy_attributes_from_model'
...
`require': cannot load such file -- ~/test_app/app/models/fakemodel.rb

Repro:
rails new test_app; cd test_app
rails g fakemodel
rails d fakemodel

I wouldn't guess that it's relevant but I'm installing fabrication automatically in all new Rails apps using .railsrc and a template file. If you think it matters I can include them here.
https://github.com/paulelliott/fabrication/blob/2fe931c083067c6b499da44445a5dc92a08e2875/lib/rails/generators/fabrication/model/model_generator.rb#L11
Thanks for taking a look!

In your initial report you said you ran:
rails g fakemodel
rails d fakemodel

You can't run those commands without specifying what you're generating though. Unless I'm missing something? I've tried doing it as a model and as a scaffold on a new app but both worked just fine.

I'm going to assume this is PEBKAC and tidy up your issues. Thanks for a great project, hope you're well 😁


⚠ Bofrost.de has degraded performance

In 0798aac, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1306 ms

Resolved: Bofrost.de performance has improved in f1c7e82 after 21 minutes.


Getting 302 when requesting resource

Hi,
I was just playing around with API and kept getting responses with the status code 302.
// Request
GET /api/anime/1 HTTP/1.1
Host: jikan.me
Connection: keep-alive
Accept: */*
Origin: http://localhost:3000
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/59.0.3071.115 Safari/537.36
Referer: http://localhost:3000/customRetro
Accept-Encoding: gzip, deflate
Accept-Language: en-CA,en-GB;q=0.8,en-US;q=0.6,en;q=0.4

// Response
HTTP/1.1 302 Found
Date: Tue, 22 Aug 2017 17:49:03 GMT
Server: Apache
Access-Control-Allow-Origin: *
Access-Control-Allow-Methods: *
Keep-Alive: timeout=5, max=100
Connection: Keep-Alive
Transfer-Encoding: chunked
Content-Type: application/json

I didn't find anything on the website regarding this problem. Is there a reason why it is a 302?

Hi @kamikaz1k ,
we recently had made some changes to the SSL. So HTTPS only was returning 200 where-as HTTP was returning a 302.
A valid response will return "200 - OK".
Thanks for bringing this to my attention, it's fixed now!


Implement Weight to Fee/Token for Schema Pallet

[ ] calculate_schema_cost function implementation, TODOs listed
[ ] implement weights to cost conversion

https://github.com/paritytech/substrate/blob/e9d79daaa782f41680ada04719151371a737c6fb/frame/transaction-payment/src/lib.rs#L517
Above is an example for weighttofee and aspects of weight computation

https://docs.substrate.io/rustdocs/latest/frame_system/limits/struct.BlockWeights.html


Change data layout for optical properties.

Purpose
Change data layout for optical properties.
Use (ncol, nlev) ordering instead of (nlev, ncol).

[x] I have read and checked the items on the review checklist.

Prior to this PR (https://buildkite.com/clima/rrtmgp-clima-a100-pipeline/builds/21#)

With this PR (https://buildkite.com/clima/rrtmgp-clima-a100-pipeline/builds/22#0191e308-a3b8-42a9-a123-ccdc177ad46b)


file protocol instead of https

 Issue by samandarr
Friday Sep 08, 2017 at 10:51 GMT
Originally opened as https://github.com/graphcool/cli/issues/174

After executing following command, browser pop-up and tried to open file:///console.graph.cool/cli/auth%3FcliToken={SOME_TK}&authTrigger=init
$ graphcool init --schema https://graphqlbin.com/hn-starter.graphql --name Hackernews
⠦ You need to authenticate. Your browser will open shortly...✖  Error: Whoops, something went wrong during authentication.

You can enable additional output by setting export DEBUG=graphcool and rerunning the command.
Open an issue on GitHub: https://github.com/graphcool/graphcool-cli.
Get in touch if you need help: http://slack.graph.cool/

⠴ You need to authenticate. Your browser will open<EMAIL_ADDRESS>alert: failed to send exception to sentry: Socket timed out on request to sentry.io

 Comment by timsuchanek
Tuesday Sep 12, 2017 at 09:04 GMT

Thanks for reporting @samandarr.
To be able to do anything about it, we need more information.
Is it possible for you to turn on export DEBUG=* and try this with the latest graphcool cli version
1.3.13? Thanks!

 Comment by samandarr
Tuesday Sep 12, 2017 at 17:47 GMT

@timsuchanek Currently using cli version of 1.3.7. Works fine.  Thanks!.

 Comment by marktani
Tuesday Sep 12, 2017 at 17:48 GMT

Please note that this is a beta version that should not be used in production yet. The officially supported version right now is 1.2.1.

 Comment by samandarr
Wednesday Sep 13, 2017 at 09:50 GMT

Having the same issue again once I run
export DEBUG=* (enabled debugging)
graphcool console
graphcool Send request to https://api.graph.cool/system
graphcool Payload:
graphcool {"query":"query ($projectId: ID!){\n  viewer {\n    project(id: $projectId) {\n      id\n      name\n      alias\n      schema\n      version\n      region\n    }\n  }\n}","variables":{"projectId":"cj7iuaw6601ah0175bd0mlu5x"}} +0ms
The Console for project Dunemyth Foe was opened in your browser.

 Comment by samandarr
Tuesday Sep 12, 2017 at 18:03 GMT

@marktani okay, I take it into account

The --schema option doesn't exist anymore in the new CLI version, therefore this won't be fixed.


[Bug] When i open the debugger the Activity log scrolls to the bottom of the panel

When i click on the debug in the activity log it open the debug but scrolls me to the bottom of the log losing my place.
scroll bug.webm

Missed this bug today; I'll take a look tomorrow. Pretty sure I know what it'll be.
(Please do feel free to assign bugs like to me when you file them, and I can always change it if needed.)

Sounds great. The new debugger popout is a gift, but constantly loosing your scroll state is daunting.
In addition to this bug, I wonder if we could highlight the Activity row when the hover state is shown:

Think I need a bit of an assist from @dglazkov on this one. I've tracked it down to the guard on the Activity Log, and in particular this.run?.events looks to be fresh on every render, and that means the Activity Log is re-rendered. Not sure what the right thing is for the guard, but it feels like it needs to represent both "there is a new message in a run" or "a message within a run has changed".

it's a really weird one. I am pretty sure the identity doesn't change, but I am still spelunking...


rtp_to_hls demo handle_notification callback incorrect arity

In new API as described here for Pipeline https://hexdocs.pm/membrane_core/Membrane.Pipeline.html#c:handle_notification/4
the handle_notification callback now also expects a 4th context argument. Would be great to update the example with this in mind, as well as provide an example of such context.

That's because that demo uses core v0.5.2, while the context was added in v0.6.0 if I recall correctly. The context is documented here

@DaniruKun a new version of rtp_to_hls demo has been merged. You can take a look at it here https://github.com/membraneframework/membrane_demo/tree/master/rtp_to_hls

Hi, thanks you! Will give it a go again.


Fixed-length columns cannot be dictionary encoded.

This was an oversight and the patch was reviewed on the Parquet github account, #407. It was just not committed.
Reporter: Ryan Blue / @rdblue
Assignee: Ryan Blue / @rdblue
Note: This issue was originally created as PARQUET-63. Please see the migration documentation for further details.

Julien Le Dem / @julienledem:
Issue resolved by pull request 30
https://github.com/apache/incubator-parquet-mr/pull/30

Ryan Blue / @rdblue:
Resubmitted in PR #30


[CI] Unsafe slice in MeshKit Error Code Utility

Current Behavior
A bug exists here https://github.com/meshery/meshery/actions/runs/5565866598/jobs/10166560575#step:4:33

Contributor Guides and Handbook

🛠 Meshery Build & Release Strategy
📚 Instructions for contributing to documentation
Meshery documentation site and source
🎨 Wireframes and designs for Meshery UI in Figma
🙋🏾🙋🏼 Questions: Discussion Forum and Community Slack
🧪 Meshery Test Plan Spreadsheet

Is this the problem with go version

@leecalcote I would like to work on this issue. Would you assign me.


Add python3 compatibility

Add python3 compatibility using six.

@stevecoward Let me know if these changes are satisfactory. I've tested this locally and found them to be helpful in installing using setup.py install. You can perform your own testing and let me know if the changes can be deployed to pypi. Thank you.

Hi Steve, @stevecoward, did you get a chance to review the PR that I submitted?


R2DBC Pool does not guarantee minIdle

Bug Report
First, Error Detected
CannotCreateTransactionException
Could not open R2DBC Connection for transaction

Second, We found R2DBC Pool Status
Oddly enough, there is no guarantee of R2DBC Pool minIdle on a particular instance. The number of R2DBC Pool idle connections is not being maintained.
Only 1 out of 3 instances is anomalous. Please check the image below.

Third, Source Code
@Configuration
internal class R2dbcConfiguration internal constructor(
    @Value("\${payment-platform.r2dbc.host}")
    private val host: String,
    @Value("\${payment-platform.r2dbc.port}")
    private val port: Int,
    @Value("\${payment-platform.r2dbc.username}")
    private val username: String,
    @Value("\${payment-platform.r2dbc.password}")
    private val password: String,
    @Value("\${payment-platform.r2dbc.database}")
    private val database: String,
): AbstractR2dbcConfiguration() {

    companion object {
        const val CONNECTION_FACTORY_PROVIDER_DRIVER_NAME = MariadbConnectionFactoryProvider.MARIADB_DRIVER

        private const val MAX_SIZE = 20
        private const val INITIAL_SIZE = MAX_SIZE
        private val CONNECTION_POOL_MAX_LIFE_TIME = Duration.ofSeconds(30)
    }

    @Bean
    override fun connectionFactory(): ConnectionFactory {
        return ConnectionFactories.get(
            ConnectionFactoryOptions.builder()
                .option(ConnectionFactoryOptions.SSL, false)
                .option(ConnectionFactoryOptions.HOST, host)
                .option(ConnectionFactoryOptions.PORT, port)
                .option(ConnectionFactoryOptions.USER, username)
                .option(ConnectionFactoryOptions.PASSWORD, password)
                .option(ConnectionFactoryOptions.DATABASE, database)
                .option(ConnectionFactoryOptions.DRIVER, PoolingConnectionFactoryProvider.POOLING_DRIVER)
                .option(ConnectionFactoryOptions.PROTOCOL, CONNECTION_FACTORY_PROVIDER_DRIVER_NAME)
                .option(PoolingConnectionFactoryProvider.INITIAL_SIZE, INITIAL_SIZE)
                .option(PoolingConnectionFactoryProvider.MAX_SIZE, MAX_SIZE)
                .option(PoolingConnectionFactoryProvider.MIN_IDLE, MAX_SIZE / 2)
                .option(PoolingConnectionFactoryProvider.MAX_ACQUIRE_TIME, Duration.ofSeconds(2))
                .option(PoolingConnectionFactoryProvider.MAX_CREATE_CONNECTION_TIME, Duration.ofSeconds(2))
                .option(PoolingConnectionFactoryProvider.MAX_LIFE_TIME, CONNECTION_POOL_MAX_LIFE_TIME)
                .option(PoolingConnectionFactoryProvider.VALIDATION_DEPTH, ValidationDepth.REMOTE)
                .option(PoolingConnectionFactoryProvider.MAX_VALIDATION_TIME, Duration.ofSeconds(2))
                .option(MariadbConnectionFactoryProvider.LOOP_RESOURCES, LoopResources.create("r2dbc", LoopResources.DEFAULT_IO_SELECT_COUNT, LoopResources.DEFAULT_IO_WORKER_COUNT, true, false))
                .build()
        )
    }
}

Versions

Driver: r2dbc-pool "1.0.1.RELEASE", Spring Boot WebFlux
Database: Aurora MySQL 8
Java: 17
OS: Mac OS

@mp911de @pderop
Hi.
Do you know about this issue?
I would appreciate any suggestions on how to fix it.

@pkgonan ,
Hi,
Thank you for reaching out, but I'm unsure how I can help here, so I will let @mp911de comment on this issue.
If you suspect that the problem may be related to the reactor-pool project, I'd recommend isolating the issue there first and, if needed, submit a separate issue in the reactor-pool GH project with the details.
Thank you.

MinIdle is being considered upon connection pool warmup. Is your application calling ConnectionPool.warmup() and awaiting the result?
Regarding the exception, can you attach the stack trace so that we can direct the issue into the appropriate component?


Add gosec code security check

Enable gosec in the .github/workflows/codeql-analysis.yml
Add gosec to the make security target
Add .gosec.json as configuration file for local runs

Codecov Report

Merging #4 (196ed6f) into main (609ef1e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main       #4   +/-   ##
=======================================
  Coverage   55.63%   55.63%
=======================================
  Files           1        1
  Lines         142      142
=======================================
  Hits           79       79
  Misses         43       43
  Partials       20       20

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 609ef1e...196ed6f. Read the comment docs.


interceptResume operator in Controller

When writing asynchronous code it's sometimes necessary to have the code between suspension points executed in the dispatch (UI) thread.
asyncUI function is implemented to support the case, it wraps each resume* call with SwingUtilities.invokeLater call, thus all "user" code is executed in the dispatch thread.
There are two kinds of problems:

It seems that the majority of implementations of async libraries should somehow support the feature (e.g. on Android there is also the UI thread distinction), and it wouldn't be cool if design forced them to write the same boilerplate for wrapping resume calls.
There's no obvious way how to force the authors of external suspension functions to wrap the continuation calls too.

The solution is to introduce another operator, interceptResume having the signature similar to
operator fun interceptResume(block: () -> Unit): Unit

And the compiler compiles coroutine a little bit differently when it meets such an operator.
Particularly, it wraps continuation methods into lambda-argument of interceptResume, i.e.
they compiled to something semantically identical to
override fun resume(x: T) =
    controller.interceptResume { doResume(x) } // where `doResume` is as-is state-machine processing

override fun resumeWithException(x: Throwable) =
    controller.interceptResume { doResumeWithException(x) } // where `doResumeWithException` is as-is state-machine processing

Usefulness of this operator is not limited to UI. In back-end enterprise systems one often needs precise control on what specific thread-pool different kinds of operations use, so that resource consumption by various time-consuming requests can be controlled. This interceptResume operation can be used to implement fork coroutine builder that is similar to async, but is used with some an executor as its argument, so that the following code can be written:
fork(executor) {
    // coroutine code here
    await(...)
    // resumes in our thread pool again
}

The question arises, whether this operator is the subject to support in JS backend with its single-threaded environment.

It depends on yet-to-be determined rules to separate asynchronous vs synchronous coroutines and suspension functions. It also depends on whether JS backend is going to provide stub implementations for Thread-like primitives or omit them altogether.

This feature is currently covered by ContinuationInterceptor element of CoroutineContext


Add Dockerfile validation with Hadolint

Need to setup a CI first (CircleCI ? Travis ? Codeship ?)
run Dockerfile against Hadolint before build

See #27
Do you think travis should also push to the docker hub ?

I believe the image should not be pushed if hadolint fail.
I do not know how the docker Hub behave if a CI fail on a branch, gotta check this out !
If the hub is smart enought not to push the image on CI failure, I believe there is no need to put this step in the Travis CI 😉

After a quick check, it seems possible to use the Docker Hub automated test feature
But for a matter of consistency, I believe all CI actions should take place at the same place, so in our case travis should handle the test, build and push actions.
@pyaillet WDYT ?

Closed by #32