CHR-22: Here's a PR with a link in the description

Here's a link
https://linear.app/christopher-triolo/issue/CHR-22/this-is-a-test-pr

closing


Syntax error with more complex graphs

Hi! I have tried to get the plotly plugin to work but it only allows me to make basic plots, but if I use another example from plotly.com it shows me a syntax error. So how can we achieve more complex plots with this tool?
Thanks in advance

Hello!
First, thank you for using this plugin!
Regarding plugin, the way it works now is so that you can create a YAML object with data array, layout and config objects.
YAML will be converted to json and passed to Plotly.newPlot('myDiv', data, layout, config) function.
This supports only an imperative approach, where your YAML have to contain all the data required for plot creation written explicitly.
On the other hand, lots of Plotly examples have data generated by JS code, which doesn't work in this plugin for now.
Can you please provide which particular example you are refering to? And a snippet which shows syntax error?

I have found a way to draw plots from DataViewJS blocks. Basic example would look like this:
//If your example needs d3 - download library from https://d3js.org/d3.v7.min.js to vault
//If no - just delete this part
let path = app.vault.adapter.basePath;//absolute path to your vault
var d3 = require(path+"\\utils\\d3.v7.min.js");

//Here you can paste example from plotly.com
//NOTE: `Plotly.newPlot` won't work here, use `window.renderPlotly` instead
var data = [
{x:[0,1,2,3,4,5,6,7,8,9],y:[4,4,2,2,3,3,2,2,4,4]},
{x:[0,1,2,3,4,5,6,7,8,9],y:[3,3,1,1,2,2,1,1,3,3]}
];
var layout = {};
var config = {};

window.renderPlotly(this.container, data, layout, config)

This template is available from Command Palette (Ctrl+P).
Already released in 0.0.6.

Thanks, Dmitriy

Thank you very much, now using the plugin is easier. This plugin is the number one option for plotting a large amount of data. Thanks again 🙏

Hi! This is a menor issue but probably you can add the option to define a custom folder for the d3 script. I make a work arround using templater to generete the dataview template.
var d3 = require(path+"\/Scripts\/d3.v7.min.js")

First, I am glad those changes were helpful!
Regarding hardcoded path to d3 lib, I agree that defining it in settings is a better way.
I have created separate issue #4  for this.


TextField loses focus on external submission

I have an auto-submitting form that sends debounced network requests on every form change. The TextField loses focus whenever the submit function is triggered, I guess this is because of Formik's internal setSubmitting(true).
Simple codesandbox describing the issue:
https://codesandbox.io/s/mystifying-microservice-2srb9
Workaround would be to directly call a submission function wrapped in useCallback in order to avoid setSubmitting(true), shown here, however this skips validation cycle:
https://codesandbox.io/s/awesome-ride-mjzq9

Hey,
        <Field
          label="test"
          name="email"
          component={TextField}
          disabled={false}
        />

Make the problem go away too. But this is not a real solution.

I think this should special case should be handled in user land
const disabled = // only disable if user clicks submit but not when auto submitting
<Field
          label="test"
          name="email"
          component={TextField}
          disabled={false}
        />


Update README.md

In line 178, templates folder seems to be inside of static folder and this condition gives notfoundtemplate error. I suggest delete one tab, I discovered this solution because I sew your solutions folder on github where locations is correct

Sorry if I am not doing the pr properly.


downgrade sentinel url check log error to warn

Description
Since we are sending service is down message to slack, we can downgrade this to warn to avoid spamming logscribe.
Fixes https://github.com/Bisonai/orakl/issues/2200
Type of change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Checklist before requesting a review

[ ] I have performed a self-review of my code.
[ ] If it is a core feature, I have added thorough tests.

Deployment

[ ] Should publish npm package
[ ] Should publish Docker image

it's a duplicate 🙏😅
https://github.com/Bisonai/orakl/pull/2204


Error on the sharp module

I'm trying to use the module, but I get an error as soon as I am trying to set an icon. If I set icon to false the other settings do work.
I'd really like to have the icons working though.
I already tried reinstalling the sharp module, without success.
Any ideas?
/app/node_modules/sharp/lib/sharp.js:34
  throw new Error(help.join('\n'));
  ^

Error:
Something went wrong installing the "sharp" module

Cannot find module '../build/Release/sharp-linuxmusl-x64.node'
Require stack:
- /app/node_modules/sharp/lib/sharp.js
- /app/node_modules/sharp/lib/constructor.js
- /app/node_modules/sharp/lib/index.js
-<EMAIL_ADDRESS>
Possible solutions:
- Install with verbose logging and look for errors: "npm install --ignore-scripts=false --foreground-scripts --verbose sharp"
- Install for the current linuxmusl-x64 runtime: "npm install --platform=linuxmusl --arch=x64 sharp"
- Consult the installation documentation: https://sharp.pixelplumbing.com/install
    at Object.<anonymous> (/app/node_modules/sharp/lib/sharp.js:34:9)
    at Module._compile (node:internal/modules/cjs/loader:1159:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1213:10)
    at Module.load (node:internal/modules/cjs/loader:1037:32)
    at Module._load (node:internal/modules/cjs/loader:878:12)
    at Module.require (node:internal/modules/cjs/loader:1061:19)
    at require (node:internal/modules/cjs/helpers:103:18)
    at Object.<anonymous> (/app/node_modules/sharp/lib/constructor.js:8:1)
    at Module._compile (node:internal/modules/cjs/loader:1159:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1213:10)

Node.js v18.12.1

 ERROR  [unhandledRejection] 1

ℹ Vite client warmed up in 2459ms

 ERROR  Cannot restart nuxt:  1

 ERROR  (node:17) PromiseRejectionHandledWarning: Promise rejection was handled asynchronously (rejection id: 31)

Hey @larsvdd , sorry to hear that, could you give information about your Operating System ? As it looks like to be some compatibility issue.

Hey @larsvdd
Do you have any updates on this ?

same issue


Not able to login after changing 2FA device

After changing 2FA I am not able to login, everytime after filling in the 2FA code app says please enter valid password.

Please specify if you are using a build from master per CONTRIBUTING.md

This issue is for Google Play version.


An alternative approach

I briefly checked the code. If all you want to download and convert to mp3, why not doing it simply in bash; such as following quick-and-dirty script.
#!/usr/bin/env bash

SYSDOWNDIR="$HOME/downloads"

function downmp3()
{
    if [ $# -le 1 ]
    then
        echo "Usage: downmp3 <youtube-link> <filename>"
        exit -1
    fi

    ylink="$1"
    fname="$2"

    pytube "$ylink" -p . -f $fname
    yname=`ls | grep -i $fname`
    avconv -i "$yname" -vn "$fname.mp3"
}

downmp3 $@

hey,
basically the scripts offers several ways to download videos with pytube. You can add several links to the tracklist.txt or just hand over an url to a public available playlist. So if your playlist has 100 videos in it you don't need to copy paste all the urls.
However I'm not even sure if the script still works or if youtube meanwhile changed there API.

Ok, downloading paylist is a good contribution! However, I would have done in this way: having two tools, one is extracting all the urls from playlist and print out to stdout or file. The second tool reads from stdin or file and downloads all the videos. This is more unix style tooling technique.

Totally agree. It was just a very early version and tbh the general approach is pretty bad. If I find some time I will rewrite the whole script and clean the code. Unfortunately, its at the moment a total mess. Thanks for the suggestion

You are welcome!
On Sun, Dec 4, 2016 at 8:22 PM, niph<EMAIL_ADDRESS>wrote:

Totally agree. It was just a very early version and tbh the general
approach is pretty bad. If I find some time I will rewrite the whole script
and clean the code. Unfortunately, its at the moment a total mess. Thanks
for the suggestion
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/niph/pytube-extension/issues/1#issuecomment-264700800,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AWGQs_0noQIlbYwsa3vTgetBJfmXF2y3ks5rErCKgaJpZM4KmLuQ
.


Add support populate Java Object with custom schema without FakeForSc…

PR adds support to populate Java objects with a custom schema without using the FakeForSchema annotation. The existing implementation of net.datafaker.providers.base.BaseFaker#populate(java.lang.Class<T>, net.datafaker.transformations.Schema<java.lang.Object,?>) requires the use FakeForSchema annotation to generate fake data for the object.

Codecov Report

Merging #787 (cfe8aaa) into main (dc4cfcf) will increase coverage by 0.00%.
The diff coverage is 62.50%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@            Coverage Diff            @@
##               main     #787   +/-   ##
=========================================
  Coverage     92.86%   92.86%
  Complexity     2642     2642
=========================================
  Files           284      284
  Lines          5212     5214    +2
  Branches        537      536    -1
=========================================
+ Hits           4840     4842    +2
+ Misses          244      243    -1
- Partials        128      129    +1

Impacted Files
Coverage Δ

...n/java/net/datafaker/annotations/FakeResolver.java
72.41% <50.00%> (-5.37%)
:arrow_down:

...n/java/net/datafaker/providers/base/BaseFaker.java
90.59% <100.00%> (ø)

... and 2 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

lgtm


Add timeTickInterval

Trying to address #8. Not sure if PRs are the best for spec discussion, but I didn't want to keep going if I'm not on the right track for what you are looking for here. When you have time to look appreciate your feedback on this.

Thanks for the PR! Superseded by #47.


Plugin cannot be enabled

I tried to enable the plugin on Godot 4.0.2 via AssetLib.
AssetLib --> Controller Input Viewer --> Download --> Move "ControllerInputViewer" folder to res://addons/ --> Enable plugin
This is the error on enable:
Unable to load addon script from path: 'res://addons/ControllerInputViewer/ControllerInputVIewerPlugin.gd'. This might be due to a code error in that script.
Disabling the addon at 'res://addons/ControllerInputViewer/plugin.cfg' to prevent further errors.

Console Output:
Unable to open file: res://.godot/imported/NodeIcon.svg-6b4a76cb23fc54c90706fcdf1bc1e61f.ctex.
Failed loading resource: res://.godot/imported/NodeIcon.svg-6b4a76cb23fc54c90706fcdf1bc1e61f.ctex. Make sure resources have been imported by opening the project in the editor at least once.
Failed loading resource: res://addons/ControllerInputViewer/ControllerHud/Assets/NodeIcon.svg. Make sure resources have been imported by opening the project in the editor at least once.
res://addons/ControllerInputViewer/ControllerInputVIewerPlugin.gd:6 - Parse Error: Could not resolve script "res://addons/ControllerInputViewer/ControllerViewerCaller.gd".
res://addons/ControllerInputViewer/ControllerInputVIewerPlugin.gd:6 - Parse Error: Could not preload resource file "res://addons/ControllerInputViewer/ControllerHud/Assets/NodeIcon.svg".

If you delete the .gdignore folder in the ControllerHud folder, it will import the files properly and can be enabled.

Thank you!


Support docblock inheritance

Hi there,
This is a fantastic extension, it "just works".  I have a feature request: to add support for docblock inheritance, as defined here.  For example:
$child = new Child;
// Should inherit documentation for this method from Parent::method
$child->method();

class Parent {
  /**
   * Parent method documentation.
   */
  public function method() {}
}

class Child extends Parent {
  public function method() {/* overridden behavior */}
}

A stretch goal would be actually respecting the {@inheritDoc} tag, so child classes can override just part of the documentation.
I would be happy to take a look at this myself if you could point me in the right direction.
Thanks!

This would be a nice feature to have. I appreciate you looking into it and hope the following notes help. Feel free to ask any questions.
PhpSymbol in symbol.ts is the interface that holds all symbol information and the symbol tree for a file is built with the SymbolReader class in symbolReader.ts. I'm refactoring PhpSymbol a little right now so that it has a PhpSymbol.doc property which will hold docblock info. Currently docblock info is stored in PhpSymbol.description and PhpSymbol.type. I think it will be easier to work with the revised interface, but it can be easily changed later if you want to start before I get the refactor done.
During the symbol tree construction a method docblock, for example, would be parsed by PhpDocParser and have the summary, description and @return type assigned to the method symbol, whilst child parameter symbols would have the @param type and description assigned to them. I'm unfamiliar with where the {@inheritDoc} tag is allowed within a docblock. You may want to check the docblock parser to see if it can handle it as it is quite basic. If it is only expected within the main description and/or tag description sections then it's probably fine, otherwise the current regexes that pull out tag info may not work.
For the document inheritance, an approach that comes to mind would be to create a merge symbols function that takes an array of symbols found in the inheritance chain and produces a unique array of symbols with the merged information. Symbols should be treated as read only, so create new symbols when merging. The order of the passed in symbols can be guaranteed to follow the inheritance order to make processing easier. The passed in array could conceivably contain all methods in the inheritance chain not just all methods of a particular name.
The merge symbols method could then be used in the various providers or perhaps be centralised in SymbolStore. See SymbolStore.lookupTypeMember in symbolStore.ts which is a method used by many of the providers to get member info. #26 may tie into this feature too, though I'm unsure it it's isolated to the completion provider.
The code has a few rough edges and is in constant development. I hope you can find your way around ok. I'm open to any suggestion you have. Thanks!

@GiacoCorsiglia just a note to let you know doc block inheritance and {@inheritdoc} has been resolved in upcoming v0.8.0

resolved in v0.8.0


It's not possible (at least for me) to install via Pip

What is the purpose of your issue?

[x] Bug
[ ] Feature Request
[ ] Question
[ ] Other

Description

Here is what I've done:
sudo apt install python3-pip
pip3 install spotdl
sudo apt-get install ffmpeg
spotdl --help

it says >> spotdl: command not found
This is the recommended way of installing spotdl in installation page. But it doesn't work for me. Is there any thing that I'm missing?
OS details
DISTRIB_ID=Ubuntu
DISTRIB_RELEASE=18.04
DISTRIB_CODENAME=bionic
DISTRIB_DESCRIPTION="Ubuntu 18.04.1 LTS"
NAME="Ubuntu"
VERSION="18.04.1 LTS (Bionic Beaver)"
ID=ubuntu
ID_LIKE=debian
PRETTY_NAME="Ubuntu 18.04.1 LTS"
VERSION_ID="18.04"
HOME_URL="https://www.ubuntu.com/"
SUPPORT_URL="https://help.ubuntu.com/"
BUG_REPORT_URL="https://bugs.launchpad.net/ubuntu/"
PRIVACY_POLICY_URL="https://www.ubuntu.com/legal/terms-and-policies/privacy-policy"
VERSION_CODENAME=bionic
UBUNTU_CODENAME=bionic

Is there any thing that I'm missing?

Most likely the path it was installed to is not in $PATH, so either fix that or use an absolute path for the spotdl command.
This is neither a bug in spotdl nor in pip (most likely), and support for general OS problems is out of scope here.

@linusg Dude it might happen for a lot of other users. I know that it's not a bug in spodl but I think if you add a few instructions about how to fix it many others will be happy. By the way I'm not a python developer so it's hard for me to figure out what is going on here.

I did - find out where it got installed and whether that path is in PATH or not 😉

@ImanMh As @linusg said, you most likely do not have the directory where python bin files get installed to in your $PATH environment variable.
Find where the python package got installed:
$ find ~/.local/ /usr/ -name spotdl

This should give you an output path ending with bin/spotdl, so the full path should be something like [...]/bin/spotdl.
We need to append this directory to the $PATH variable.
$ echo "export PATH='[...]/bin:$PATH'" >> ~/.bashrc

This should be it; try opening a new terminal and $ spotdl --help.

@ritiek Thanks that was helpful.

I am very confused, how do I add it to my path if my path is /home/xander/.local/bin/spotdl

@TheDucklessMan export PATH="/home/xander/.local/bin:$PATH" or more generally export PATH="$HOME/.local/bin:$PATH"

Thanks


Rebrand library

From Kelley:

Consider generalizing the project name for broader C++ use. The library is generic but just happens to support Arduino. (and doesn't use streams)

Merging this into #3.


[BUG] Spacing issues with paragraphs nested in lists

Describe the Bug
When attempting to create a COVID KMI email with formatting that required paragraphs nested in lists there is an extra break line tag (br) added.
To Reproduce
Steps to reproduce the behavior:

List item 1\n\n
\tShould be paragraph in the list item without extra br above

Expected Behavior
A clear and concise description of what you expected to happen.
Actual Behavior
Description of what happens for the purposes of reproducing the bug
Relevant Story
If applicable, link the related story here.
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop

OS: [e.g. iOS]
Browser: [e.g. chrome, safari]
Version: [e.g. 22]

Smartphone

Device: [e.g. iPhone6]
OS: [e.g. iOS8.1]
Browser: [e.g. stock browser, safari]
Version: [e.g. 22]

Additional Context
Add any other context about the problem here.

This content
\n\n1. List item 1\n Should be paragraph in the list item without extra br above
seems to work while this content causes the problem
\n\n1. List item 1\n\n\tShould be paragraph in the list item without extra br above

Three possible approaches:

CSS route:

Use global CSS (style header in jinja template) with selectors for paragraphs instead of inline styles for paragraphs.
Potential problems - global styles might now work across all email clients; inline styles are usually recommended for emails

Provide information to renderer wether paragraph is inside list item block

render can use that information to render differently (or call different different method altogether)
requires changes to Markdown (and potentially to Lexer)
Potential problems - can we supply our own Markdown?

Do not modify list rules. Modify lexer so that it never creates newline token.

The solution is mix of options 2 and 3. Created an md file stating how mistune works, how notification-utils uses it and how we fixed it.

Before

After

As per last comment The issue is fixed. To ensure the fix does not cause any issues We sent a few emails from the same templates and compared them with the emails that were sent before.  The issue is fixed and no issue is introduced.

This fix has been verified
Before snd After screen shots have ben attached.
Check was performed on other emails impacted by the code fix, with no issues
Closing ticket


Constant for Observable

Feature Request
Thank you for your great work!
I have a frequent usecase where I need to return an Observable of type void.
With promises, you can do the following:
const conditionalAsyncOp = () = {
  if (someCondition) {
    return asyncOp()
  } else {
    return Promise.resolve();
  }
}

function asyncOp(): Promise<void> {
  return new Promise(resolve => {
    // do some asynchronous work
    setTimeout(resolve, 1000)
  })
}

Using EMPTY or of() are breaking the chain because they complete which is not desired here.
The equivalent of Promise.resolve() for observables would be:
new Observable<void>(observer => observer.next())

I would love to have a constant similar to EMPTY which is a shortcut of the above code.

@hoi4 if I understood you correctly: you are looking for a constant that behave like EMPTY but that never completes, correct? If that's the case, then I think that what you are looking for is the constant NEVER :slightly_smiling_face:

@josepot Thank you for your answer.
I cannot use NEVER because like EMPTY it also breaks the observable chain (as it is not emitting anything). I need the observable to emit void (by calling next without any parameters) and to not complete.
What I would like to have is the following:
export const VOID = new Observable<void>(observer => observer.next());

Of course, I could just define this constant for myself, but I thought that maybe others have the same usecase. 🤔

I do not think core will include those - empty, never are specific edge-case observable previously backed by operator. What you're mentioning in here is a plain observable emits value which is undefined, I recommend to create user land values instead.
Few things meanwhile: first, not sure what breaks the observable chain means: all observables properly run to completion. secondly, The equivalent of Promise.resolve() cannot be what you mentioned - promise runs to completion, so if you want to create equivalent it should complete too.

@kwonoj Thank you for your answer.
Just to clearify what I mean:
I created a very small stackblitz to illustrate the use case:
const VOID = new Observable<void>(observer => observer.next());

function asyncOp(value: number): Promise<void> {
  return new Promise(resolve => {
    setTimeout(() => {
      console.log(`resolving for value`, value);
      resolve();
    }, 2000);
  });
}

function conditionalAsyncOp(value: number): Observable<void> {
  if (value % 2 === 0) {
    return defer(() => asyncOp(value))
  } else {
    // When replacing VOID with EMPTY or NEVER, the second tap below is not executed
    return VOID;
  }
}

of(1).pipe(
  tap(value => console.log(`VALUE`, value)),
  switchMap((value) => conditionalAsyncOp(value)),
  tap(() => console.log(`Observable pipe still running`))
).subscribe()

The tap operator following the switchMap is not executed if conditionalAsyncOp does not emit any value (NEVER) or completes (EMPTY).
Maybe there is a better way of implementing such a behaviour in which case I would be very glad about some guidance. Thank you!


Default to Spark 2.3.1 in spark_connect()

Fixed with https://github.com/rstudio/sparklyr/pull/1686


Allow interpolating instances with non rounded geometry

When interpolating instances one may want to not round values to integers.
This can be useful when adding masters to a designspace without piling up rounding differences.
For example, if  you have 4 masters and a bunch of instances in between:
A-B
| |
C-D

And you want to interpolate new masters where instances W, X, Y, Z and R were:
A--W--B
|  |  |
X--R--Z
|  |  |
C--Y--D

You do not want to round to integers in those new masters otherwise the other instances will be too different from the original 4-master instances. Say an instance interpolated between A and B will be different from an instance interpolated between A and rounded-W or rounded-W and B, whereas it will be closer to that instance interpolated between A and non-rounded-W or non-rounded-W and B.

Updated description.

Is there any reason to want the rounded option at all?  Rounding should only happen during the export IMO.


Music controls don't work with background mode on iphone

Using ionic 3 and deploying to iphone.  When background mode is enabled music controls don't show up at all.  with background mode turned off music stops on screen lock and music controls show up but don't do anything.
cordova-plugin-music-controls: 2.1.4
cordova-ios: 4.4.0
cordova-plugin-background-mode: 0.7.2

Make sure you are using the UIWebView and not the new WKWebView in Ionic. (WKWebView is the default)
https://ionicframework.com/docs/wkwebview/

https://github.com/katzer/cordova-plugin-background-mode/pull/274/files

This plugin doesn't use https://github.com/katzer/cordova-plugin-background-mode though right? or am I supposed to install the plugin?

The problem with the background mode plugin is that it plays a silent audio file in the background continuously to fake activity and stop suspension of the app even when it's idle.  It may be fixed now but the problem was that the background-mode plugin steals the audio session.
I would recommend giving the ionic-webview plugin a look if you want background processing support as it enables background processing but doesn't fake any work load so the OS can still suspend your add as it needs to when it is idle.


fix: increase space size for test job

Description of changes
Increased space size to 8GB for test job to avoid the heap limit error spotted in codebuild
<--- JS stacktrace --->
--
3758 |
3759 | FATAL ERROR: Ineffective mark-compacts near heap limit Allocation failed - JavaScript heap out of memory

CDK / CloudFormation Parameters Changed

Issue #, if available

Description of how you validated changes
Checklist

[ ] PR description included
[ ] yarn test passes
[ ] Tests are changed or added
[ ] Relevant documentation is changed or added (and PR referenced)
[ ] New AWS SDK calls or CloudFormation actions have been added to relevant test and service IAM policies
[ ] Any CDK or CloudFormation parameter changes are called out explicitly

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Codecov Report

Merging #1602 (1951b11) into cb (c722cf2) will not change coverage.
The diff coverage is n/a.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@           Coverage Diff           @@
##               cb    #1602   +/-   ##
=======================================
  Coverage   63.42%   63.42%
=======================================
  Files         371      371
  Lines       21701    21701
  Branches     5177     5177
=======================================
  Hits        13763    13763
  Misses       7211     7211
  Partials      727      727

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Update updateTags function by using new runtime function

Issue #, if available:
New method of comparing tags was added in runtime. Using this new method to reduce amount of custom logic code of updateTags.
Description of changes:
Use new method in runtime to replace custom logic of comparing two tags.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

/lgtm


Comment widget separate bundle

The page comment widget should have his own bundle, something like /widgets/comments.min.js instead of being within the app bundle app.min.js. It should make it way lighter and easier to load from 3p apps as comment widget.

@bonustrack Something like https://disqus.com/?

Closing this issue, we will use a separated repo for it.


Tacotron 2 no longer works on Google colab

Since Google colab no longer functions with Tensorflow 1, it has corrupted Tacotron 2 training and synthesis notebooks. Even when I use the Tensorflow 2, it still corrupts Tacotron 2 by not recognizing the child directories. Like: os.chdir('tacotron2') no longer functions.
Is there a way to fix?

I am looking for a fix too, have you found a solution?

Upgrade the Tacotron repo (this repo) to use TensorFlow 2
!tf_upgrade_v2 --intree "/content/tacotron2" --outtree "/content/tacotron2_v2" --reportfile "/content/report.txt"
I go the extra steps and rename the new version to "tacotron" by executing the following:
mv tacotron2 tacotron2_v1 mv tacotron2_v2 tacotron


Pre commit/push hooks fail in the latest version

Hi 👋 ,
Thanks for this project!
Pre-commit or push hooks fail in the latest version for me under macOS Monterey 12.3 (whether it matters), I wonder if conditional cd shown in the screenshot is the culprit. (this commit)

My config:
if Mix.env() == :dev do
  config :git_hooks,
    verbose: true,
    hooks: [
      pre_commit: [
        tasks: [
          {:cmd, "mix format --check-formatted"}
        ]
      ],
      pre_push: [
        tasks: [
          {:cmd, "mix quality"}
        ]
      ]
    ]
end

Seem to work fine with the version 0.6.5.
How to reproduce:

Download git_hooks_bug.zip
mix deps.get && mix compile
touch test.txt && git commit -m whatever

Same here.

Unfortunately :mix_task doesn't respect result values in 0.6.5, so if you downgrade be sure to use :cmd.

We ran into this, and the current fix we have is to run mix git_hooks.install whenever we get this missing dependencies error even after running deps.get.

I have limited time but actively looking at this when I have time to focus on it 😞
So far, I cannot reproduce this in a reliable way. The example project provided by this issue gets fixed after running mix git_hooks.install, but this should never happen in the first case so something it's definitely not right.
I will keep investigating, but it will be great if I can get more details such as the folder structure of the repo as I think it's the root of the issue 🙏

When the auto_install feature creates .git/hooks/pre-push it looks like this:
#!/bin/sh

[ "/Users/myuser/code/myapp/deps/git_hooks" != "" ] && cd "/Users/myuser/code/myapp/deps/
git_hooks"

mix git_hooks.run pre_push "$@"
[ $? -ne 0 ] && exit 1
exit 0

I notice that if I remove the first line there, the git hook seems to work properly!
It seems to mean that mix deps.get is ran in the deps/git_hooks dir and not in the project root as we may want instead.
What is the idea with that cd line? Thanks, @qgadrian !

When the auto_install feature creates .git/hooks/pre-push it looks like this:
#!/bin/sh

[ "/Users/myuser/code/myapp/deps/git_hooks" != "" ] && cd "/Users/myuser/code/myapp/deps/
git_hooks"

mix git_hooks.run pre_push "$@"
[ $? -ne 0 ] && exit 1
exit 0

I notice that if I remove the first line there, the git hook seems to work properly!
It seems to mean that mix deps.get is ran in the deps/git_hooks dir and not in the project root as we may want instead.
What is the idea with that cd line? Thanks, @qgadrian !

Hey @djthread
I am currently reviewing this issue, expect a preview version by this week 🤞
Regarding the cd... things started going south with this commit trying to provide more flexibility on some custom project setups (elixir projects not in the root of the git repo, submodules...) :/

I created a PR and will remove the auto directory change of this library, it's giving more problems than solving anything.
Can anyone please test 0.8.0-pre0 version and confirm the issues are gone? I've tested it on my projects and they work fine, I'm having a hard time trying to reproduce this every time.

Hm. I checked out my app fresh and changed my git_hooks dependency to the fix-hooks-and-dependencies branch.
During compilation, I saw
↗ Installing git hooks...
And the dev phoenix app started up ...
My pre-commit hook which should have been created wasn't created at all.
I'm not certain of many details, so feel free to ask questions.

It asks to install , whenever there is a mix command.

FWIW, I get the same error with 0.8.0-pre0:
Unchecked dependencies for environment dev:
* blankable (Hex package)
  the dependency is not available, run "mix deps.get"
* ex_doc (Hex package)
  the dependency is not available, run "mix deps.get"
* recase (Hex package)
  the dependency is not available, run "mix deps.get"
* dialyxir (Hex package)
  the dependency is not available, run "mix deps.get"
* credo (Hex package)
  the dependency is not available, run "mix deps.get"
** (Mix) Can't continue due to errors on dependencies

We ran into this, and the current fix we have is to run mix git_hooks.install whenever we get this missing dependencies error even after running deps.get.

this works for me

Update on this, I published a new v0.8.0-pre1 release that hopefully resolves this issue.
I will wait to get some feedback before publishing a production release.


default_actions should exclude actions not defined for the controller

ActiveAdmin.register User do
	actions :all, :except => :show

	index do
	  default_actions
	end
end

default_actions should render Edit, and Delete links only

Implemented in 82bd4c1c101ca5860fefdfc39a153e4f2f66dd74


Can't build "branch stable-1.1" with error: storage size of ‘hmac_ctx’ isn’t known.

Hi, I'm trying to build FreeRDP-WebConnect but on building FreeRDP I get error:
[ 35%] Building C object winpr/libwinpr/sspi/CMakeFiles/winpr-sspi.dir/NTLM/ntlm_compute.c.o
/home/user/prereqs/FreeRDP/winpr/libwinpr/sspi/NTLM/ntlm_compute.c: In function ‘ntlm_compute_message_integrity_check’:
/home/user/prereqs/FreeRDP/winpr/libwinpr/sspi/NTLM/ntlm_compute.c:649:18: error: storage size of ‘hmac_ctx’ isn’t known
  649 |         HMAC_CTX hmac_ctx;
      |                  ^~~~~~~~
/home/user/prereqs/FreeRDP/winpr/libwinpr/sspi/NTLM/ntlm_compute.c:656:9: warning: implicit declaration of function ‘HMAC_CTX_init’; did you mean ‘HMAC_CTX_new’? [-Wimplicit-function-declaration]
  656 |         HMAC_CTX_init(&hmac_ctx);
      |         ^~~~~~~~~~~~~
      |         HMAC_CTX_new
/home/user/prereqs/FreeRDP/winpr/libwinpr/sspi/NTLM/ntlm_compute.c:662:9: warning: implicit declaration of function ‘HMAC_CTX_cleanup’ [-Wimplicit-function-declaration]
  662 |         HMAC_CTX_cleanup(&hmac_ctx);
      |         ^~~~~~~~~~~~~~~~
/home/user/prereqs/FreeRDP/winpr/libwinpr/sspi/NTLM/ntlm_compute.c:649:18: warning: unused variable ‘hmac_ctx’ [-Wunused-variable]
  649 |         HMAC_CTX hmac_ctx;
      |                  ^~~~~~~~
make[2]: *** [winpr/libwinpr/sspi/CMakeFiles/winpr-sspi.dir/build.make:90: winpr/libwinpr/sspi/CMakeFiles/winpr-sspi.dir/NTLM/ntlm_compute.c.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:1989: winpr/libwinpr/sspi/CMakeFiles/winpr-sspi.dir/all] Error 2
make: *** [Makefile:156: all] Error 2
Unable to build FreeRDP package. Exiting...

Also, I tried to build FreeRDP latest version and it built.
But I can't build branch stable-1.1 which used in FreeRDP-WebConnect.
OS: Ubuntu 22.04
Coulde you help please?!

Anything older than stable-2.0 and master is deprecated and unmaintained. So, don't bother with the ancient 1.0 1.1 branches.
Also, for build issues don't use the issue tracker. Instead, you can use the FreeRDP matrix channel or github discussions for this.


Add about us page.

Want to add a about us page and remove the content of about from the main page and add creativeness to about us page

Please assign me this issue.

@tjanhvi this issue is already open, before opening any issues make sure that no other similar issue is open.


Programmatically uploading (geo)JSON files throws mimetype error

Bug Report
Calling this:
const filePath = '[...]/filename.geojson';

await payload.create({
    collection: 'geofiles',
    filePath: tmpFilePath,
    data: {}
  });

results in the following error:
TypeError: Cannot read properties of undefined (reading 'mime')
    at getFileByPath ([...]/node_modules/payload/src/uploads/getFileByPath.ts:16:34)
    at async createLocal ([...]/node_modules/payload/src/collections/operations/local/create.ts:65:21)

I'm using Payload 1.6.6.
Possible cause
I believe the problem lies in the the following code const mimetype = fromFile(filePath); (link) which ultimately in the file-type package does this new FileTypeParser().parse(tokenizer);.
FileTypeParser.parse() (link) does not support (geo)JSON.
The file-type states This package is for detecting binary-based file formats, not text-based formats like .txt, .csv, .svg, etc., does this mean that the payload upload system also only supports binary-based file formats?

Hey @stefgootzen this is very interesting. I have never run into this myself but I can see how this package would definitely cause some issues with text-based files.
We can likely swap out this dependency to support text-based files. I will convert this to a Discussion and then add it to our Roadmap.
If you'd like to help here, we would happily accept a PR. Looks like the package is only used in 3 places within our code so if we can find a suitable replacement, we can certainly swap it out.
Otherwise, we should be able to get to this in our Roadmap Priority 2 (next quarter).


Keep getting error "The client shell files do not exist, we recommend you run a new install"

Running install for: Debian 7.7|head -1|awk {'print '} Debian 7.7|head -1|awk {'print '}|cut -d . -f 1
Please choose an option below
Base Setup:

Install
Update

Optional:
3) EnableSSL
q) Quit
Choose mode: 2
Mode: Running Update/Upgrade
Webpage Location, User and Admin information.
Webpage Location Setup
Please enter location for web interface [Default: ]: /patchmgr
Please enter the relative path [Default: /patchmgr/]:
Notice: Default Location Used: /patchmgr/
Database Setup information
Enter the MySQL root password:
Notice: pdashboard updating database tables
Installing Apache related configurations
Notice:  already exists.
Error: The client shell files do not exist, we recommend you run a new install.
Press 'Enter' to return to the Main Menu.
I am doing the "Update" option to try and go through the install again to troubleshoot and verify that the Mod_Rewrite option for Apache is installed and I get this error. See above for output.
The directory exists /patchmgr and is even chmod'd to 777.

Assigned issue to metalcated, as he is the primary in the installer. I will also be reviewing the issue.
Reviewing source, I see that the issue happens when it searches for files that it doesn't find.
I'm not sure if we are asking for the current web directory or not, but if we aren't this is the most likely cause of the issue.
##Code to check
if [[ "$?" = 0 ]]; then
auth_key=$(grep auth_key=\" ${new_web_dir}client/*.sh|awk -F\" {'print $2'}|head -n 1)
server_uri=$(grep server_uri=\" ${new_web_dir}client/*.sh|awk -F\" {'print $2'}|head -n 1)
else
echo -e "\e[31mError\e[0m: The client shell files do not exist, we recommend you run a new install.\n"
unset wait
read -p "Press 'Enter' to return to the Main Menu." wait
mainMenu
fi

I'll take a look and get it fixed.
On Sun, Jan 4, 2015, 9:53 AM jonsjava<EMAIL_ADDRESS>wrote:

Assigned issue to metalcated, as he is the primary in the installer. I
will also be reviewing the issue.
Reviewing source, I see that the issue happens when it searches for files
that it doesn't find.
I'm not sure if we are asking for the current web directory or not, but if
we aren't this is the most likely cause of the issue.
##Code to check
if [[ "$?" = 0 ]]; then
auth_key=$(grep auth_key=" ${new_web_dir}client/.sh|awk -F" {'print $2'}|head -n 1)
server_uri=$(grep server_uri=" ${new_web_dir}client/.sh|awk -F" {'print $2'}|head -n 1)
else
echo -e "\e[31mError\e[0m: The client shell files do not exist, we recommend you run a new install.\n"
unset wait
read -p "Press 'Enter' to return to the Main Menu." wait
mainMenu
fi
—
Reply to this email directly or view it on GitHub
https://github.com/PatchDashboard/patchdashboard/issues/4#issuecomment-68635399
.

Issue has been resolved in the most current commit on the master branch. Please git pull for the most current. If you are running RC1, you may do a git pull in a separate directory and copy only the installer.sh over to the RC1 directory. I cannot guarentee this will work, but it SHOULD work. Please post if you continue to have issues. Thank you and good luck. :)

I have a VM saved in a state so I'll do another git and test it out most likely tomorrow evening and write back.

Closing ticket due to lack of feedback.  If the issue resurfaces, please resubmit a new ticket.


September 20th Social Media Post

“The greatest threat to our planet is the belief that someone else will save it.”
This quote by Robert Swan reminds us of our personal responsibility in addressing climate change. Each of us has the power to make a difference through our daily actions. By reducing our carbon footprint, conserving resources, and supporting sustainable practices, we contribute to a healthier planet.
Let’s take action today for a better tomorrow.
——
Please is there anyone to work on this @clentafrica/wg-design

Alright, i will work on this!
Thank You!

@erioc @clentafrica/wg-marketing-comms , this hasn’t been posted

Hi guys, let’s ensure to post this on the 20th of September. I will post on LinkedIn l.

This has been posted on Twitter, @yigakpoa please ensure this post goes out on FB and Ig

Scheduled to go out tomorrow on FB & IG @1pm GMT+1. Thanks Everyone.


Add rule no-return-await

From ESLint official docs:
Using return await inside an async function keeps the current function in the call stack until the Promise that is being awaited has resolved, at the cost of an extra microtask before resolving the outer Promise. return await can also be used in a try/catch statement to catch errors from another function that returns a Promise.

Using return await inside an async function keeps the current function in the call stack

Personally I think it doesn't worth losing the call stack just to avoid a microtask in this case.
I'm not strongly against this change. However, to avoid microtask, we should also remove async keyword if the function doesn't use await at all.

I guess we can keep the await keywords for easier debugging, then


BUG: Fix the Media Carousel

We seem to be repeating the same attachments multiple times. We would need to fix it...

This is fixed and pushed to production -> https://github.com/vijays-hub/pissbook/pull/35


chore: added missing olm manifest for a servicemonitor for the mc metrics

added missing OLM manifest for a ServiceMonitor for the spoke metric service.

continuation of: https://github.com/open-cluster-management-io/multicloud-operators-subscription/pull/283
issue: https://github.com/stolostron/backlog/issues/25649

/cc @chenz4027


Does docopt ignore my raised exceptions?

I am a little more than slightly annoyed here...
I am I right in my inference that as soon as I run the line:
args = docopt(__doc__, version='2<IP_ADDRESS>')

I lose the ability to have raised exceptions do anything other than the extremely unhelpful and non-intuitive action of print the usage text and kill my script?
I am sure that I must be confused.  This makes no sense to me.  To say that docopt is beloved by tons of programers would be unfair in its understatement.  I can not see it getting so popular with this as a default behavior, but I can't get it to do anything else.
Can someone help me?

I'm not sure I fully understand your issue, but this might be what your are after:
try:
    arguments = docopt(__doc__, version='Naval Fate 2.0')
except SystemExit:
    print("Wanted to exit!")
    print("but we keep marching on!")
else:
    print("Arguments are OK:")
    print(arguments)

Basically, docopt will want to kill your script, but that is nothing more then an exception that you can catch.

Thanks @frnhr.
Here is a bit more of what's driving me crazy starting with my __doc__.
"""Get info for those SNPs within a certain distance of genomic features whose homologs were differentially expressed in the external species.

Usage:
  snps_near_homologous_de.py (--knearest=<path>... --diffexpr=<path> --output=<path>) [options]

Options:
  -h --help             Show this screen.
  -v --version          Show version.
  --knearest=<path>     One or more paths representing a `nearest_features_beds` file (REQIRED).
  --diffexpr=<path>     A single path representing a `ids_with_diff_expr` file (REQIRED).
  --output=<path>       A single path representing where to write output (REQIRED).
  -d --distance=<INT>   Distance of SNP from feature [default: 0].
  -c --chunksize=<INT>  Rows of diff expr table to read in at one time [default: 10000].
  -p --parallel         Run in parallel (options are 'yes' or 'no') [default: 'yes'].
  -n --dryrun           Do nothing. Just print the options dictionary for sanity.

Write file representing which SNPs are within a certain distance of a feature in `internal`
species that were diff expressed in `external` species.
"""

Below is what comes after my imports and func defs.
if __name__ == '__main__':
    args = opt(__doc__, version='2<IP_ADDRESS>')

    # ipdb.set_trace()
    if args["--dryrun"]:
        print(args)
        exit(1)

    # Settings
    snp_distance_from_gene = args["--distance"]
    assert isinstance(snp_distance_from_gene, int)

    de_table_chunksize = args["--chunksize"]
    assert isinstance(de_table_chunksize, int)

    run_parallel = args["--parallel"]

    # input
    nearest_features_beds = args["--knearest"]
    ids_with_diff_expr = args["--diffexpr"]

    #output
    snps_near_homologous_de_path = args["--output"]

    main(nearest_features_beds,
         snp_distance_from_gene,
         ids_with_diff_expr,
         de_table_chunksize,
         run_parallel)

Now in a function that main calls internally, I try to do something with the value set by args["--parallel"]. If the value is not an expected value, I try to be a good programmer who treats his users nicely and fails informatively:
if parallel == 'yes':
        # do thing A
    elif parallel == 'no':
         # do thing B
    else:
        raise ValueError("Valid values for '--parallel' are ['yes','no']. You provided: {value}".format(value=parallel))

So.  Are you saying that in order to inform my user what they did wrong, I basically need to

wrap my entier if __name__ == '__main__': # do stuffin a try-exept in order to
catch docopt trying to kill my script with SystemExit
try to figure out what caused the SystemExit myself and finally,
re-raise THAT?

That seems like it kind of negates the removal of the overhead of defining a CLI in click or argparse.  Am I understanding things correctly?  I am sorry for bugging you guys!  Thanks for your help.

Ah, the thing is that docopt was exiting on that first line (that you posted in your question), and script never even got execute further in order to reach the point where you raise the ValueError.
I would definitely agree that docopt has some ways to go when it comes to showing us which part of the usage pattern failed (i.e. was not met). Currently it simply says basically "You're using it wrong!!" and doesn't say why, which is suboptimal. Ref: https://github.com/docopt/docopt/issues/57
In your particular case, however, this can be achieved like so (a trimmed-down version of your code):
"""Get info for....
Usage:
  snps_near_homologous_de.py [options]

Options:
  -p --parallel=<YES_NO>  Run in parallel (options are 'yes' or 'no') [default: 'yes'].
"""

from docopt import docopt as opt

def main(parallel):

    if parallel == 'yes':
        print('do thing A')
    elif parallel == 'no':
        print('do thing B')
    else:
        raise ValueError(
            "Valid values for '--parallel' are ['yes','no']. You provided: {value}".format(
                value=parallel))

if __name__ == '__main__':
    args = opt(__doc__, version='2<IP_ADDRESS>')

    # Settings
    run_parallel = args["--parallel"]

    main(run_parallel)

The default won't work, however.

Perhaps it is simpler to have a usage pattern like this:
... [--no-parallel] ...

That way, specifying --no-parallel meas, well, "don't do parallel", otherwise "do parallel". In order to check this, just do
 parallel = not args['--no-parallel`]

With this usage pattern, you don't need to explicitly way "yes" or "no". Docopt will populate args with True if you have specified the option, False otherwise.

Thanks for your help, but I just went back to click. I get my validation included in the interface design, it allows unlimited pos_args which ends up cleaning up my interface as well,  I have a working CLI in WAY less heart-ache for how my brain thinks about things.
Thanks again though.


[WFCORE-4569] Ensure the AuthenticationContext is also registered as the JVM wide default.

We currently automatically associate this with the class loader of every deployment but we don't register it globally meaning any internal services that also need the default such as XA recovery don't have access to it.
https://issues.jboss.org/browse/WFCORE-4569

This fix relates to a long standing issue that has been investigated across different teams, @fl4via is also going to take a look at verifying if this does address the larger issue.

Thank you very much @fl4via this is good news.

@darranl thanks!


UI: programming language highlight wrong keyword

Description
I check some TypeScript code in code review page, some keywords in variable names like module or var will be highlight improperly.
Gitea Version
1.19.4
Can you reproduce the bug on the Gitea demo site?
Yes
Log Gist
No response
Screenshots

Git Version
No response
Operating System
No response
How are you running Gitea?
docker-compose
Database
MySQL

It's an upstream bug
https://swapoff.org/chroma/playground/

Bisstocuz thanks for opening a issue.
👀

Don't think we need to keep every upstream issue open.


Pull req.

Please accept my pull request, I just made another one to pylint. @sharmistharanit

Yes I just accepted it.

Thank you,


MS SqlServer Update with Join is not correctly implemented

The Illuminate\Database\Query\Grammars\Grammer.php function compileUpdate returns a final construct like this:
return trim("update {$table}{$joins} set $columns $where");
This fails using SqlServer. It produces incorrect SQL, for example:
update [InventoryCodes] inner join [Products] on [InventoryCodes].[ProductID] = [Products].[ProductID]
set [InventoryCodes].[StockQty] = [InventoryCodes].[StockQty] - 2
where [InventoryCodes].[FullSKU] = '1827-11' and [Products].[TrackInventory] = '1'

Looks great, but fails in actual use.
Correct SqlServer format will be like this (note the set command is before the join, the table name is actually listed twice, alternately an alias could be used but needs to be extracted from the $table variable first):
update [InventoryCodes] set [InventoryCodes].[StockQty] = [InventoryCodes].[StockQty] - 2
from [InventoryCodes]  inner join [Products] on [InventoryCodes].[ProductID] = [Products].[ProductID]
where [InventoryCodes].[FullSKU] = '1827-11' and [Products].[TrackInventory] = '1'

This implies that the SqlServerGrammer.php file should override the compileUpdates function, check if there is a join, and return something like this:
    if (!empty($joins))
        {
           $sql =  trim("update {$table} set $columns from {$table} {$joins} $where");
        }
        else
        {
            $sql =  trim("update {$table} set $columns $where");
        }

    return $sql;

Table aliases will cause the above to fail (eg [InventoryCodes as ic]).  So it would make sense to also set up a method to extract the table alias from the $table variable to use as the first table name argument in the result.   Then the resultant SQL would look like this:
update [ic] set [ic].[StockQty] = [ic].[StockQty] - 2
from [InventoryCodes as ic]  inner join [Products] on [ic].[ProductID] = [Products].[ProductID]
where [ic].[FullSKU] = '1827-11' and [Products].[TrackInventory] = '1'

And the $sql returned for a join would be this:
 $sql =  trim("update {$table_alias} set $columns from {$table} {$joins} $where");
If there was no table alias, the $table_alias value would simply be $table.
I don't have time in the near future to set up a pull request with a final resolution, but if this issue sits around long enough I will eventually try to do so.

Closing since we have a PR open now.


gopls doesn't write its log

What version of Go are you using (go version)?

$ go version
go version go1.12.1 linux/amd64

Does this issue reproduce with the latest release?
Yes.
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/bstaletic/.cache/go-build"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"
GOPATH="/home/bstaletic/go"
GOPROXY=""
GORACE=""
GOROOT="/usr/lib/go"
GOTMPDIR=""
GOTOOLDIR="/usr/lib/go/pkg/tool/linux_amd64"
GCCGO="gccgo"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build434682588=/tmp/go-build -gno-record-gcc-switches"

What did you do?

This is basically a continuation of https://github.com/golang/go/issues/31194. This time I'm having troubles getting to gopls' log.
Steps to reproduce:

Follow all but the final two steps in https://github.com/golang/go/issues/31194 (basically, setup ycmd and open a go file).
Currently, the gopls command line is gopls -logfile /tmp/gopls_$PID_$RANDOM.log

The file and its name is generated by ycmd.

If the log path is hardcoded (to somthing like /home/bstaletic/go.log), the empty log file gets created but nothing is written to the file.

What did you expect to see?
Some content in the log, to help me debug things.
What did you see instead?
Empty log whose size was 0bytes.

try adding -rpc.trace and it will log all the rpc messages

Thanks. That did work. Is there also a way to log tracebacks when an error is returned?

Not right now, but we should switch to using the https://golang.org/x/xerrors package so that we can do that.

Thanks for the response. For what it's worth, I did make a PR for our project to use gopls instead of gocode and godef.
https://github.com/Valloric/ycmd/pull/1243

I would like to take on this issue, what's the best way to start?

Thanks for contributing this, @jan-xyz! Closing this issue since https://golang.org/cl/179880 has been submitted.


PHP warning

Warning: Invalid argument supplied for foreach() in /usr/local/opnsense/mvc/app/library/OPNsense/Firewall/Plugin.php on line 134
You'd know better how to fix... :)

should be https://github.com/opnsense/core/issues/3576, can you try https://github.com/opnsense/core/commit/5dca5cc7238a84a8611becbc48623c8e4646367a ?

Right ok, I'll ask in the forum where I got this from :)


Action Reports to Incorrect Check

I have two workflows that run simultaneously on push.
One contains the Jest tests and this action, the other does not.
When this action does its thing, on the Checks tab, it displays its info under the wrong workflow, occasionally.
In the screenshot I have included, Branches: Test, Scan is where I would have expected the Jest Test Results to appear, but instead it showed up under the other workflow.

Thank you for creating the issue :)
I'll deal with it now and report back if there is any progress.

I have approached the currently published APIs from various directions, but they do not seem to support it.
Perhaps the grouping here is via the API, but the name seems to be determined by which application it is via, and I couldn't do anything to change the name when accessing it from the API.
I would like to respond again when the following issues are resolved.
https://github.community/t/specify-check-suite-when-creating-a-checkrun/118380


Add Lineage Emition from pandas.DataFrame.to_csv

Add Lineage Emition from pandas.DataFrame.to_csv

closed by https://github.com/gage-russell/pandas-lineage/pull/12


neovim: heavy refactor

Description of changes
Follow up of https://github.com/NixOS/nixpkgs/pull/237425#issuecomment-1738059902

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Triggering eval after it was fixed on master.
@ofborg eval

Introducing "plugins" here might be too opiniated. Let's first introduce init.lua support and after 23.11 we can discuss  this more calmly.

merged in another PR


Change how IOManager is handling exceptions

With this patch withIOManager will rethrown the exception thrown when
LPOVERLAPPED was null.  This wasn't the case previously which was a mistake.
I also documented better (an experiment a bit more) with one particular case:
why we are not throwing exceptions when the LPOVERLAPPED is NULL and
GetQueuedIoCompletionStatus errored with ERROR_INVALID_HANDLE.  I can
reproduce this scenario when we close the iocp's HANDLE, but only in some
circumstances e.g. running the same test twice or more.  The first time
dequeueCompletionPackets exists cleanly (i.e. GetQueuedIoCompletionStatus
errors with ERROR_ABANDONDED_WAIT_0) and the next one errors with
ERROR_INVALID_HANDLE).  This behaviour is not documented in MSDN.
Also label the IOManager thread, which is useful for profiling with the
eventlog.

withIOManager use IOException
Removed withMaxSuccess from tests
Label the IOManager thread

bors merge


Fatal Issue detected: Error running 'Fawkes-0.3.exe'

I just downloaded the Fawkes-Software (as of how I understand it, is the GUI-App).
When I run the exe, I get the following error-window:

I am using Windows 10.

Can also confirm this on Windows 10.
Any Qt framework needed to install?

Same issue here with 0.30 and 0.31 Windows installers.
Issue persists with or without Run as Administrator.
Edition	Windows 10 Pro (64bit)
Version	20H2
OS build	19042.685
Experience	Windows Feature Experience Pack 120.2212.551.0

Same issue here with 0.30 and 0.31 Windows installers.
Issue persists with or without Run as Administrator.
Edition	Windows 10 Pro (64bit)
Version	20H2
OS build	19042.685
Experience	Windows Feature Experience Pack 120.2212.551.0

This issue seems to be a duplicate of #93
Or vice versa

This issue seems to be a duplicate of #93
Or vice versa

@nottheend as you can see this is #78, while #93 is newer. So #93 is the duplicate.

@nottheend as you can see this is #78, while #93 is newer. So #93 is the duplicate.

That make sense @twistios. So maybe collaborator would close #93 in favor of #78 then. Maybe @emilywenger could do that?

That make sense @twistios. So maybe collaborator would close #93 in favor of #78 then. Maybe @emilywenger could do that?

Same here.
Windows 7 64x
So it's not about the windows version.
Tried to install inside a Virtual Machine, Windows 7 64x, AND THE SAME!
This problem persist since August 2020, and no solution yet?
I also tried the binary software, but there some errors on processing.
So can't use it at all.

Can any of you guys try the binary version? If it has error, would you paste the error message here?

Hello
I tried:
Name: Fawkes-0.3.1.exe
Size: 131078861 bytes (125 MiB)
SHA1: BDD69DFAA520DE414651F23F0003D4EC92872974
I still get the same error:
Fatal error detected
Failed to execute script app_qt
Thanks

same error.
binary version message:

PS C:\Users\M\Downloads> ./protection-v0.3 -d C:\Users\M\Downloads\New folder
Traceback (most recent call last):
File "tensorflow\python\pywrap_tensorflow_internal.py", line 18, in swig_import_helper
File "imp.py", line 297, in find_module
ImportError: No module named '_pywrap_tensorflow_internal'

During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "tensorflow\python\pywrap_tensorflow.py", line 58, in
File "c:\users\jonwe\appdata\local\programs\python\python37\lib\site-packages\PyInstaller\loader\pyimod03_importers.py", line 493, in exec_module
File "tensorflow\python\pywrap_tensorflow_internal.py", line 28, in
File "tensorflow\python\pywrap_tensorflow_internal.py", line 20, in swig_import_helper
ImportError: DLL load failed: A dynamic link library (DLL) initialization routine failed.
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "protection.py", line 13, in
File "c:\users\jonwe\appdata\local\programs\python\python37\lib\site-packages\PyInstaller\loader\pyimod03_importers.py", line 493, in exec_module
File "tensorflow_init_.py", line 28, in
File "c:\users\jonwe\appdata\local\programs\python\python37\lib\site-packages\PyInstaller\loader\pyimod03_importers.py", line 493, in exec_module
File "tensorflow\python_init_.py", line 49, in
File "c:\users\jonwe\appdata\local\programs\python\python37\lib\site-packages\PyInstaller\loader\pyimod03_importers.py", line 493, in exec_module
File "tensorflow\python\pywrap_tensorflow.py", line 74, in
ImportError: Traceback (most recent call last):
File "tensorflow\python\pywrap_tensorflow_internal.py", line 18, in swig_import_helper
File "imp.py", line 297, in find_module
ImportError: No module named '_pywrap_tensorflow_internal'
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "tensorflow\python\pywrap_tensorflow.py", line 58, in
File "c:\users\jonwe\appdata\local\programs\python\python37\lib\site-packages\PyInstaller\loader\pyimod03_importers.py", line 493, in exec_module
File "tensorflow\python\pywrap_tensorflow_internal.py", line 28, in
File "tensorflow\python\pywrap_tensorflow_internal.py", line 20, in swig_import_helper
ImportError: DLL load failed: A dynamic link library (DLL) initialization routine failed.
Failed to load the native TensorFlow runtime.
See https://www.tensorflow.org/install/errors
for some common reasons and solutions.  Include the entire stack trace
above this error message when asking for help.
[9464] Failed to execute script protection

No installation required: https://dev.scrb.ai


[EventRequest] table 32 “Item Ledger Entry”, VerifyOnInventory [External]

Please add a new publisher event OnVerifyOnIventory in Table 32 on External function VerifyOnInventory and call at the start of the function

Please add the corresponding Integration Event In the bottom of the table

This event already exist


[INLONG-648] Change initial version of inlong-sort to 0.9.0-incubating-SNAPSHOT

Codecov Report

Merging #502 (d6347e6) into master (4b22232) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master    #502      +/-   ##
===========================================
- Coverage      7.71%   7.70%   -0.02%
- Complexity      562     563       +1
===========================================
  Files           355     355
  Lines         31077   31077
  Branches       4970    4970
===========================================
- Hits           2399    2393       -6
- Misses        28187   28193       +6
  Partials        491     491

Impacted Files
Coverage Δ

.../java/org/apache/flume/sink/tubemq/TubemqSink.java
51.42% <0.00%> (-4.00%)
:arrow_down:

.../producer/qltystats/DefaultBrokerRcvQltyStats.java
45.70% <0.00%> (+0.39%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b22232...d6347e6. Read the comment docs.


Update Client.php

Added the AccountID parameter to the regex that reads the config file.
fixes #1

Just independently verified that this is the fix. Otherwise fantastic work on updating this for PHP8 and the new URL schema. Can we get this merged, please?

Thank you very much for this, missed it myself.


Handle arrays with const as size in instruction data

Closes #1623

is this ready for review?

yes, I hope I haven't left anything out

Thank you!


[Docenhancement][Added code sample]

Please review.

Acrolinx Scorecards
We do not currently enforce a minimum score for content merged to the default branch. This will change in the future.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/concepts/device-capabilities/device-capabilities-overview.md
92
5
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit 3aa8eeb:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/concepts/device-capabilities/device-capabilities-overview.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Acrolinx Scorecards
We do not currently enforce a minimum score for content merged to the default branch. This will change in the future.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/concepts/device-capabilities/device-capabilities-overview.md
91
5
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit b2cd132:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/concepts/device-capabilities/device-capabilities-overview.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Acrolinx Scorecards
We do not currently enforce a minimum score for content merged to the default branch. This will change in the future.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/concepts/device-capabilities/device-capabilities-overview.md
91
5
link
:white_check_mark:

msteams-platform/concepts/device-capabilities/native-device-permissions.md
89
17
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit 784fa87:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/concepts/device-capabilities/device-capabilities-overview.md
:white_check_mark:Succeeded
View

msteams-platform/concepts/device-capabilities/native-device-permissions.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


KAFKA-12648: Make changing the named topologies blocking

Use a Kafka future to be able to add, remove then add back the same topology
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

@ableegoldman @guozhangwang @rodesai  Can you give this a look? I would like to say its pretty strait forward but....

Hey @wcarlson5 sorry for getting late on this review.. overall it looks good, and I think adding the future makes sense. Just feeling that we can simplify the thread coordination on a single-rebalance-trigger a bit.
Also, seems some related tests are failed.

@guozhangwang  @ableegoldman I think this is ready for another pass.


Move vagrant, docker in /etc to "Script to rule them all"

https://github.com/github/scripts-to-rule-them-all
borderrouter moved to the script-to-rule-them-all config boilerplate and I think it is a very clean pattern. I'm proposing we move the Vagrantfile, Dockerfile (when merged) and codelab to use the same pattern.

Codelabs have also been updated (thanks to @Vyrastas)

Build a Thread network with nRF52840 boards and OpenThread
Simulating a Thread network with OpenThread


Clarify that it is actually possible to build against OpenBLAS (except we discourage it)

Spotted by @pacien

Fixed by 3cbe86d622e93b8a19c1e28f2ff86e1e62b9ba2e


remove packr

We don't use packr in the gitea-operator, removing the makefile steps.

Closed in favour of https://github.com/integr8ly/gitea-operator/pull/23


2.3.1 runs in jupyter but python script

my code runs in jupyter but when I use python script. It gives me gpu oom error.

sorry
i didn't write:
base_model.trainable = False


Support alphanumerical releases

Is your feature request related to a problem? Please describe.
Currently changie only support semver based releases, e.g. v1.3.5, v2.0 and so on. Several of our projects have a different naming schema, for example hardknott.TQMa335x.BSP.SW.0122 (see https://github.com/tq-systems/meta-tq/tags for more).
All parts parts separated by . are orthogonal and are changed within their own meaning.
Describe the solution you'd like
I would like to support arbitrary release names, including this naming schema. Of course in that case there is no major, minor, patch or next. Within this schema the release would have to be specified explicitely every time.
Merging the release notes should be done by timestamps as well.
Describe alternatives you've considered
For us semver is not suitable, because the first part already is the Yocto release name. There is almost no relation bewteen for example hardknott.TQMa335x.BSP.SW.0001 and zeus.TQMa335x.BSP.SW.0001.

So after a little bit of time to think about this I have a few questions as well as maybe a potential solution.
First, Changie versioning support is not coincidentally anything that https://github.com/Masterminds/semver supports. By definition it sounds like semver only but can also support calver or similar versions where sorting can be done numerically. Therefore, your suggestion of supporting alphanumerical falls into a bit of an issue.
However, that is not the only issue, namely this part here:
All parts parts separated by . are orthogonal and are changed within their own meaning.

This is particularly difficult to solve as version sorting used by the merge command is done via filenames. Sorting by timestamps is not possible as the timestamp is not used anywhere in the batch output and therefore can not be used in the merge command. You can sort of get around this if you were to use Calver as the date would be the version and thus would auto sort chronologically.
One additional problem is your versions include more than 3 parts, which will most likely cause issues when parsing.
To me it sounds just a little too far outside the range of what Changie is focused on to support this type of versioning.
You would definitely have to fit your project into what Changie is expecting in terms of versioning or make massive changes to a fork and maintain it.

Thanks for looking into this. I already suspected our current naming schema is not supported (or not supportable at all).
Requiring numbers in front for sorting is understandable and reasonable. Arbitrary suffixes are also possible apparently. But I noticed only 3 number versions are supported. Is there a hard requirement for that? Even releases like <IP_ADDRESS>.4 are sortable. I admit this is theoretical for now, but to support separate stable branches with disjunct release names in the same repository (e.g. hardknott and kirkstone), the major number has to be sacrificed. Is it possible to add support for multiple levels of numbers?

I believe the 3 numbers are simply due to the expected major, minor and patch values. It is not a list of numbers it is those 3 values specifically. You can add a list of arbitrary numbers with metadata or any values using the prerelease but those will also be sorted which may not be what you want. semver.org has all the details and all of the values should be supported in changie. That would give you a version something like 0.1.5+hardknott as metadata or 0.2.3+hardknott.5 where you can add more dot separated values for additional metadata. The version value would still be the first three numbers.

Thanks for confirmation. So I take right now just major, minor, patch is supported for versioning management. I am aware, that arbitrary suffixes are possible, as you mentioned. Unfortunately releases like 0.1.5+hardknott and 0.1.5+kirkstone would be completely different and independent. But this is something on a global project scale and should be manageable using different (stable) branches.
Anyway, thanks for your feedback.


Why isn't OSSL_HPKE_SUITE opaque?

Why isn't the OSSL_HPKE_SUITE opaque?
Why is it passed directly on the stack and returned, as opposed to pointers?
The project did lots of work to make everything opaque, this seems like a step backwards.

IIRC, there was much discussion about this at the time and the conclusion was we would allow it (i.e. this wasn't accidental).
Hopefully @sftcd can chip in and provide the rationale here.

On 03/02/2023 09:18, Matt Caswell wrote:> Hopefully @sftcd can chip in
and provide the rationale here.
Basically, that type is two uint16_t's which is smaller than
a pointer. And both the type and values are in the RFC (or
the IANA registry) so it doesn't seem like there's anything
useful to "hide" or be opaque about in this case.
Cheers,
S.

Sorry, typo - it's three uint16_t's

Closing since this is marked as resolved.


Refactor: Commit list popup

Move popup for selecting a commit to zcl_abapgit_popup
Allow to skip sorting of commits in zcl_abapgit_git_commit which often led to "too many commits" error (on GitHub you get the 300 most recent commits)

Popup will be used in zcl_abapgit_gui_page_sett_remo and zcl_abapgit_gui_page_tags (separate PR)

In which method was the logic changed? It's a bit hard to review when the move to IF and logical changes are in the same commit 😅

I included the change to Repo > Settings > Remote. You can test the commit popup there, for example with the abapGit repo.


Create possibility to add new steps and change properties after presentation starts

By making impress.js being able to change it's properties after it is being started we will close one of the most requested features so far.
This issue groups all the requests that will be fixed once impress.js allow changing it's properties dynamically.

I had a need for this for my impressionist project (an impress.js editor). It was surprisingly easy, almost like a single line change (plus some refactoring) to impress.js core. Committed to my fork here:
https://github.com/henrikingo/impress.js/commit/d8f21f303e604374177d9c53edb1c381a66a5d2a
I'm glad I could "accidentally" stumble into implementing this much requested feature!

Above is now merged to master. If you made changes to the DOM, calling goto() will now redraw the presentation.


Project ID in recurring task ID

Hi, it seems like there is an issue with the field: created_from_recurring_task_id. As I understand it this field, should contain the ID of the task, that the recurring task was created from, but instead it seems to contain the project ID.

Seems like it was just the documentation that was not up to date. I figured it out randomly


Fix two translation build issues

Just realised that I cherry-picked an individual commit instead of the merge one hence there was no merge #xxx in its title 🙈 Fixed (tweaked the title manually, no code changes).


Rack and Install BIG-IP HW

BIG-IPs racked
Need more cabling

Waiting on licenses to complete configuration.

licenses added, Certificate added. setup as standalone now.
Need:

[ ] optics purchased
[ ] optics installed by HE
[ ] HA setup
[ ] VPN banners and logos configured for webtop


fix(dashboard): expose filter prop

Summary

The filter props wasn't being exposed through the Dashboard, so couldn't set an filter element into the DashboardHeader

:tada: This PR is included in version 1.54.3 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.54.3 :tada:
The release is available on npm package (@release-1.x dist-tag)
Your semantic-release bot :package::rocket:


Prl 4618 template update solicitor

JIRA link (if applicable)
PRL-4618
Change description
Serve order - CA&DA personal service via Applicant solicitor email
Does this PR introduce a breaking change? (check one with "x")
[ ] Yes
[ X] No

closing this


Use continuation local storage instead of attaching to domain

We should use https://www.npmjs.org/package/continuation-local-storage instead of attaching _bugsnagOptions to the domain object.

This probably won't happen, I think node 0.12 has something better built in.


o1-mini:  unsupported parameter

Firstly, thanks for this magnificient plugin.
I've been trying to use the o1-mini model but I get the following error:
Unsupported parameter: 'max_tokens' is not supported with this model. Use 'max_completion_tokens' instead.

I changed the configuration to add  max_completion_tokens but it seems that the max_tokens is sent in the request.
anyone with similar issue?

Just tried using o1/o1-mini, faced the same problem.
Though my understanding of lua and nvim plugins ecosystem is limited, I believe that local configs for plugins override existing entries in plugins default tables, but still use default values for anything that is not present in the override.
After a quick look at the source code, it looks that max_tokens is a default parameter, hence is always present in request.
So far only o1-preview and o1-mini seem to be affected. But they are also still in beta and might change behavior in release version.
Still, though, is there any way to change request parameters based on model name? Or completely delete default config and send out your own parameters?

Just installed this extension to try out and had this very same issue.

I faced the same issue 😕
I will try to make PR commit when I have the time to fix it. 🥲

I tried to fix this issue, but its too difficult for me. 😢


Config problems

So I finally found out how to do the configs (after a lot of research) finding the keys in en_us.json language file of Minecraft.
My problem is that the mod doesn't seem to accept both a list of disabledPrefixes and a list of enabledPrefixes. But even when I go with only one of these lists, it appears that the filtering is still broken. For example: If I have a list of enabledPrefixes, I still get "narrator.position.screen" playing all the time - which you can hear from navigating the menus.
{
"chatEnabled": true,
"disabledPrefixes": [
"advancements.",
"commands.",
"debug.",
"effect.minecraft.",
"gui.narrate.",
"narration.button.usage.",
"narration.checkbox.usage.",
"narration.component_list.usage",
"narration.cycle_button.usage.",
"narrator.button.",
"narrator.screen.usage",
"narrator.loading",
"narrator.position.",
"narrator.screen.title",
"narrator.screen.usage",
"subtitles."
],
"enabledPrefixes": [
"addServer",
"attribute.name",
"biome.minecraft.",
"block.",
"book.",
"container.",
"createWorld.",
"menu.",
"options.",
"selectWorld.",
"sleep."
],
"enabledRegularExpressions": []
}

Here is an even more basic test of the config:
{
"enabledPrefixes": [
"menu.",
"narrator.screen."
]
}

Thanks for pointing this out! It looks like this is probably a real bug, I'll try to take a look at it in a few days.

Thank you.
I don't know why this would happen but I have some ideas on things to improve:
-JSON parsing errors

I think I see the problem.
When I first started this mod, I believe for every call to narrate, the text came directly from a single translation in some language file. Now, it looks like multiple translations can get chained together while calling narrate:
...
[12:26:11] [Render thread/INFO] (Minecraft) [STDOUT]: Stacktrace: net.minecraft.client.util.NarratorManager.narrate(NarratorManager.java)
[12:26:11] [Render thread/INFO] (Minecraft) [STDOUT]: Stacktrace: net.minecraft.client.gui.screen.Screen.narrateScreen(Screen.java:568)
...
[12:26:11] [Render thread/INFO] (Minecraft) [STDOUT]: text: Title Screen. Use mouse cursor or Tab button to select element
[12:26:11] [Render thread/INFO] (Minecraft) [STDOUT]: is it accepted? false
[12:26:11] [Render thread/INFO] (Minecraft) [STDOUT]: is it empty? false
[12:26:11] [Render thread/INFO] (Minecraft) [STDOUT]: is narrator active? true

Here, the text sent to narrate is "Title Screen. Use mouse cursor or Tab button to select element". Instead of seeing only one translation at a time, narrate is being called with a combination of two translations:

"narrator.screen.title": "Title Screen", and
"narrator.screen.usage": "Use mouse cursor or Tab button to select element",

So the way that I originally designed this mod, to match the exact text sent to the narrator, will no longer work.
One approach to try to fix it could be to check whether the text begins with an accepted narration, so perhaps "Title Screen..." followed by anything else would be accepted (if narrator.screen.title was an enabled prefix). This approach could get a lot of narration working again, but it is far from perfect:

It is possible that the "begins with" match might match other narrations which it was not supposed to match
Text that is embedded in a longer sentence which does not begin with an enabled prefix would not be narrated

And there could be more issues still. But I think this is the best approach I can think of for now, so I will try to work on that.

Also, thank you for pointing out that it was hard to figure out what prefixes existed and where to find them, I will add the en_us.json file to my mod and reference it in the README.
As well, I would like to clarify that "enabledPrefixes" and "disabledPrefixes" are designed to be configurable at the same time. The thought I had was, for example, if I wanted to enable all menu. prefixes except for one or two, maybe menu.singleplayer and menu.multiplayer, it is smaller and better to enable only menu. while also disabling menu.singleplayer and menu.multiplayer rather than having to list out and enable all 25 other menu.[...] prefixes.
But you do also make a point that an illegal configuration file should probably result in the narrator saying something about it, so I will also look into that.

Please check if this is fixed for you in the newest release file:
https://www.curseforge.com/minecraft/mc-mods/narrator-configs-mod/files/4014290

Hello,
I tried the latest build using the below two config files to compare things. In the first case, hovering menu buttons does not trigger the narrator. However in the second case, it does.
{
"chatEnabled": true,
"enabledPrefixes": [
"death.",
"sleep."
],
"enabledRegularExpressions": [
"^\d+, \d+, \d+$"
]
}
{
"chatEnabled": true,
"enabledPrefixes": [
"attribute.",
"biome.minecraft.",
"block.",
"book.",
"death.",
"sleep."
],
"enabledRegularExpressions": [
"^\d+, \d+, \d+$"
]
}

Thank you for trying things out and explaining what goes on behind the scenes. I don't know Java myself (but I'm a seasoned Python developer).
From what you describe I think I see the problem and/or why I get confused.
I have made these assumption and observations trying to work with this mod:
The language files (example: en_us.json) is a JSON-formatted file in the style of CSV. The data structure looks like a map/dictionary with key/value pairs where the first string is the key and the second is the value.
Adding something like "advancements." to the "enabledPrefixes" lead me to believe that:
"All keys that start with that string - advancements. - will be filtered when the mod is doing a lookup for the narration".
Now in your last comment it appears to me that you are instead filtering things by value and not by key. If this is a mistake or a limitation in Minecraft and mods in general, I can't tell - you have more insight into that than I do.
However, as one dev to another I would say that this logic is prone to many errors: Keys in a map/dict are unique while Values are not.
There is another problem here and that is localization:
The main reason I found this mod and wanted to try and make it work is because I want to be able to play Minecraft in order to learn a language. A user can install a foreign narrator in their OS - like say, Chinese (Mandarin) and then toggle on Chinese subtitles.
If it is possible to refactor the code so that the configs work on Keys rather than Values than the above would be possible.

Thank you for your thoughts and input.
When I started this mod, I had the same idea - it should theoretically be easy to just match the text-keys and then control what gets narrated with high precision and accuracy. I then discovered that the Narrator inside of Minecraft only receives strings, all other information (keys included) is gone by the time the Narrator is called. When I realized this, I switched my approach and started converting the text-values into regular expressions, and then live-checking all text received in the Narrator.
This completely agree that this approach is sub-optimal in a lot of ways, but it has the advantage of only needing to modify one place inside of the Minecraft code rather than having to override behavior in a variety of different places, hot-swapping a lot more game-code and having to review and update more code on each release. This was also my first time looking into writing Minecraft mods, so I wanted to make sure I kept a small-footprint and had something decent enough that worked.
Now that I am more familiar and comfortable with modding, I could try to see about the larger-footprint approach, trying to go to where the keys still exist in the calling-code and then writing my filtering logic there, but that would take a significant rewrite and is not feasible in the short term. I would like this mod to be as useful as possible though, so I will definitely be thinking about trying that approach soon.

Alright, I understand.
I believe that such a refactor would make the mod much more usable. Maybe you could team up with shoaib_k on Accessability Plus Extended? This kind of narration filter could potentially be very powerful (and helpful) for both people with disabilities and people looking to just learn a new language such as myself. As far as I can tell this functionality does not exist in that mod at all.
The vision I had before I started looking around at mods was to have subtitles and narration in a foreign language - but filter away useless stuff like "Press Left click or Tab button to chose element". I also envisioned narration of the inventory, hot bar, etc so that when you select your sword/pickaxe on key X, the narrator would speak out this word in the foregn language (and you see it spelled out as well). I think a lot of people would find it fun if they could play Minecraft AND learn a new language at the same time.


how to scrape element array

First of all, thanks for your great work, I'd like to know how to get the elements array as in chrome console: $$("div.item"), then, i can iterate the arrays to click the items, thanks in advance

Hi Penn, in theory, you can pass back the object through stringified JSON using r.dom(), then parse it back into an object.
However, it is much easier to code and maintain the script, if you use XPath to reference the elements array. The syntax is (XPath)[n] where n is the nth element that matches the XPath provided. r.count() can be used to detect how many elements in total to loop through and process. See eg here.


Reorganize externals

The main purpose of this PR is to commit a copy nblibrary from https://github.com/rmshkv/nbscuid-adf-sandbox.git into CUPiD rather than bringing it in as an external. We now use manage_externals to bring in ADF code, and also to bring in MOM6 code (needed for the mom6-tools-nbscuid conda environment).
Aside from creating the nblibrary directory, most of the updates are small (changing paths to point to the new locations of mom6-tools and ADF; updating the README, etc). @rmshkv after accepting this PR I don't think you want to do any more development in nbscuid-adf-sandbox -- that should all happen in this repo now.

Forgot to mention that I did some testing... With these changes I can still run nbscuid-run config.yml from examples/adf-mom6 and nbscuid-run config-adf-only.yml from examples/adf-only


Landing zone tab

We want to add a tab to the early phases of the Migration guide to include how to setup a Landing Zone. This is largely based on the content in Consoto Migration Infrastructure

Docs Build status updates of commit 30b8394:
:warning: Validation status: warnings

File
Status
Preview URL
Details

docs/cloud-adoption/migrate/azure-migration-guide/secure-and-manage.md
:warning:Warning
View
Details

toc.json
:warning:Warning

Details

building-blocks/extending-templates/toc.json
:warning:Warning

Details

bread/toc.json
:warning:Warning

Details

docs/cloud-adoption/migrate/azure-migration-guide/assess.md
:white_check_mark:Succeeded
View

docs/cloud-adoption/migrate/azure-migration-guide/assistance.md
:white_check_mark:Succeeded
View

docs/cloud-adoption/migrate/azure-migration-guide/index.md
:white_check_mark:Succeeded
View

docs/cloud-adoption/migrate/azure-migration-guide/manage-costs.md
:white_check_mark:Succeeded
View

docs/cloud-adoption/migrate/azure-migration-guide/migrate.md
:white_check_mark:Succeeded
View

docs/cloud-adoption/migrate/azure-migration-guide/optimize-and-transform.md
:white_check_mark:Succeeded
View

docs/cloud-adoption/migrate/azure-migration-guide/organize-resources.md
:white_check_mark:Succeeded
View

docs/cloud-adoption/migrate/azure-migration-guide/prerequisites.md
:white_check_mark:Succeeded
View

docs/cloud-adoption/ready/azure-readiness-guide/before-you-start.md
:white_check_mark:Succeeded
View

docs/cloud-adoption/ready/azure-readiness-guide/staying-current.md
:white_check_mark:Succeeded
View

docs/cloud-adoption/migrate/azure-migration-guide/secure-and-manage.md

Line 0: [Warning] Duplicate tab id: (siterecovery, 2).

toc.json

[Warning] Error happen when converting toc.json to Pdf. Details: Could not find file 'T:\svpx\toc.json'.

building-blocks/extending-templates/toc.json

[Warning] Error happen when converting building-blocks/extending-templates/toc.json to Pdf. Details: Could not find a part of the path 'T:\svpx\building-blocks\extending-templates\toc.json'.

bread/toc.json

[Warning] Error happen when converting bread/toc.json to Pdf. Details: Could not find a part of the path 'T:\svpx\bread\toc.json'.

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit 74b620b:
:warning: Validation status: warnings

File
Status
Preview URL
Details

docs/cloud-adoption/migrate/azure-migration-guide/secure-and-manage.md
:warning:Warning
View
Details

toc.json
:warning:Warning

Details

building-blocks/extending-templates/toc.json
:warning:Warning

Details

bread/toc.json
:warning:Warning

Details

docs/cloud-adoption/migrate/azure-migration-guide/assess.md
:white_check_mark:Succeeded
View

docs/cloud-adoption/migrate/azure-migration-guide/assistance.md
:white_check_mark:Succeeded
View

docs/cloud-adoption/migrate/azure-migration-guide/index.md
:white_check_mark:Succeeded
View

docs/cloud-adoption/migrate/azure-migration-guide/manage-costs.md
:white_check_mark:Succeeded
View

docs/cloud-adoption/migrate/azure-migration-guide/migrate.md
:white_check_mark:Succeeded
View

docs/cloud-adoption/migrate/azure-migration-guide/optimize-and-transform.md
:white_check_mark:Succeeded
View

docs/cloud-adoption/migrate/azure-migration-guide/organize-resources.md
:white_check_mark:Succeeded
View

docs/cloud-adoption/migrate/azure-migration-guide/prerequisites.md
:white_check_mark:Succeeded
View

docs/cloud-adoption/ready/azure-readiness-guide/before-you-start.md
:white_check_mark:Succeeded
View

docs/cloud-adoption/ready/azure-readiness-guide/staying-current.md
:white_check_mark:Succeeded
View

docs/cloud-adoption/migrate/azure-migration-guide/secure-and-manage.md

Line 0: [Warning] Duplicate tab id: (siterecovery, 2).

toc.json

[Warning] Error happen when converting toc.json to Pdf. Details: Could not find file 'T:\uayc\toc.json'.

building-blocks/extending-templates/toc.json

[Warning] Error happen when converting building-blocks/extending-templates/toc.json to Pdf. Details: Could not find a part of the path 'T:\uayc\building-blocks\extending-templates\toc.json'.

bread/toc.json

[Warning] Error happen when converting bread/toc.json to Pdf. Details: Could not find a part of the path 'T:\uayc\bread\toc.json'.

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

It feels like this content would be better placed in the Azure Readiness Guide. Before squashing this content, lets chat about the scope of each guide.

@Matticusau : Thanks for your contribution! The author, @jelledruyts, has been notified to review your proposed change.

Hi @Matticusau - thanks for the submission.  The public repo is designed for small corrections to existing content, and should not be used for new articles or large changes to existing content. Instead, Microsoft contributors should use the private repository for these sorts of the commits. Can you open a PR in the private repo ( https://github.com/MicrosoftDocs/architecture-center-pr) with these same commits?
Thanks.
#please-close

Reference information
Microsoft authors and contributors need to make content contributions through the private repository so the content can be staged and validated by the current validation rules.
After you review staging and fix all validation issues, you can add the sign-off comment to let PR reviewers know that the updates are ready to be merged.
Read about authors working in the public repo for more information.
If you need help getting set up to work in the private repo, see Set up Git repository locally for documentation.
We'll close this PR. Thank you.


There should not be any UI issue on the product-view page.

Bagisto Version: Master
Steps To reproduce--
1. Login as a customer.
2. Click on booking item.
3. Try to Book the product.
Expected result: There should not be any UI issue on the product-view page.
Actual result: There is a UI issue on the product-view page if the user is trying to book the booking product. Please find the screen Here.

@jitendra-webkul
Now, this issue is fixed. so I am closing this issue.
And I have attached a screenshot here, for future reference.


has showMonths: 2 in config, setDate is not working if we setting date to below two months(either from or to )

https://jsfiddle.net/tj2Lo4z7/
Your Environment

flatpickr version used:
Browser name and version:
OS and version:

https://jsfiddle.net/aditya__babu/4qtn372g/2/
I'm setting date to ["5-11-2019", "30-12-2019"] but in flatpickr the dates are not selected, but if I set date to ["1-1-2020", "5-1-2020"] the dates are getting selected,
https://jsfiddle.net/aditya__babu/4qtn372g/5/
any one has anyidea how to set dates properly in flatpickr for ["5-11-2019", "30-12-2019"]


Clear cache from console gives warnings and crashes.

Expected behavior
Clearing the cache from console with: php ./bin/console cache:clear
I expect the following message from console:
[OK] Cache for the "dev" environment (debug=true) was successfully cleared.

Actual behavior
Clearing the cache from console with: php ./bin/console cache:clear
In PsrCachedReader.php line 198:

  Warning: filemtime(): stat failed for /var/www/html/vendor/prestashop/autoload/src/Autoloader.php(113) : eval()'d code

Steps to reproduce the behavior

Install mollie module and enable it.
from console: php ./bin/console cache:clear

Environment

PrestaShop version: 8.1.3
Mollie module version: 6.0.4
PHP version: 8.1.27

Additinal information

tested on fresh installed prestashop
when disabling mollie module, clear cache works correctly from console.

The following changes works:

modules/mollie/subscription/Controller/AbstractAdminController.php
namespace Mollie\Subscription\Controller;
to:
namespace Mollie\Subscription\AdminController;

modules/mollie/src/Controller/AbstractMollieController.php
class AbstractMollieController extends \ModuleFrontControllerCore
to
class AbstractMollieController extends ModuleFrontControllerCore

Hi there @sharkooon,
I have forwarded the issue to our development team. As soon as we have some updates I will let you know.
Best Regards,
Invertus Support team.

My suggested changes breaks other stuff, so don't use it. It only works for clear cache from console: php ./bin/console cache:clear

Hi @sharkooon,
The issue can be recreated with native PrestaShop modules as well, as the solution works only when all of the modules are deleted.
It seems to be a PrestaShop issue in general, I would suggest creating a ticket there.
Best Regards,
Invertus Support team.