TagHelpers don't work

Neither the Microsoft.AspNetCore.Mvc.TagHelpers nor custom TagHelpers get resolved.
I think the problem might be that the CompilationTagHelperFeature is not part of the RazorProjectEngine.EngineFeatures collection.
When I debug the source of Statiq.Framework, the Statiq.Razor.Tests.RenderRazorFixture.AlternateModel will try to create the RazorCompiler which tries to resolve the RazorProjectEngine:
https://github.com/statiqdev/Statiq.Framework/blob/6c833bb2087cf1215cbba4b87dd53d8c79636e9e/src/extensions/Statiq.Razor/RazorCompiler.cs#L84
The call to:
https://github.com/statiqdev/Statiq.Framework/blob/6c833bb2087cf1215cbba4b87dd53d8c79636e9e/src/extensions/Statiq.Razor/IServiceCollectionExtensions.cs#L77
should result in adding the CompilationTagHelperFeature
https://github.com/dotnet/aspnetcore/blob/24b34d720366af99b20d1736b96a9ab184d37c31/src/Mvc/Mvc.Razor.RuntimeCompilation/src/DependencyInjection/RazorRuntimeCompilationMvcCoreBuilderExtensions.cs#L97
but when I check the collection of features of the resolved razorProjectEngine, it doesn't contain it.

I added a test for tag helpers (I like to add failing tests before doing work on bugs) and was actually a bit surprised to find they worked out of the box!

At a minimum it looks like the default Microsoft.AspNetCore.Mvc.TagHelpers can be imported. So now I'm wondering where the disconnect is between the behavior you observed and the behavior in the test.
Did you have the @addTagHelper *, Microsoft.AspNetCore.Mvc.TagHelpers syntax either in your Razor file or in a _ViewImports.cshtml file?

Also appears custom tag helpers work out of the box:

One thing we could consider is adding tag helpers to the scope via the RenderRazor module instead of the Razor file or a _ViewImports.cshtml file. My guess is this would look something like the recent work on view data by adding tag helpers to the ViewContext (hopefully that's it - if the set of tag helpers isn't exposed via public API anywhere it might get trickier).
In any event, I'd want to make sure tag helpers are always opt-in (as opposed to adding any automatically) given that they can "take over" normal HTML elements. Though I guess this is up for debate - perhaps the expectation of .NET developers is that tag helpers are available in their Razor views by default and not having them is the unexpected behavior.

I'm flabbergasted... I tried to get this to work a couple of times since June but couldn't. Tried it again after reading this and now it  works as expected. Tried a couple of different scenarios, it just works  ¯_(ツ)_/¯

yup, it all works now...I gave it a few more tries and there were two problems with my code:

the HtmlTargetElement was too strict in my case so the tag helper wasn't being applied
I used namespace instead of the assembly name in the @addTagHelper directive

however, I don't know what was I doing wrong the last time when I was trying the built-in asp.net tag helpers...they didn't work and now they seem to work too...
anyways, I'm glad that we have confirmed that the tag helpers work :) closing the issue...

:) no problem, this caused me to add some tests around tag helpers, so that's good anyway!


feat: support modern ECMAScript libs and targets

I accidentally included changes from #9 in this PR; it should be merged first.


always set ETCDCTL_API=3 in pods

For the discovery.etcd.io service I wanted a one-liner to debug via etcdctl and came up with this:
kubectl exec -it $(kubectl get pods -l app=etcd -o jsonpath='{.items[0].metadata.name}')  -- /usr/local/bin/etcdctl watch '' --prefix

However, it doesn't quite work because ETCDCTL_API=3 isn't set and needs to be on the entire pod. I suggest we make that the default. The hack I have implemented here works:
https://github.com/etcd-io/discovery.etcd.io/blob/master/discovery-etcd-cluster.yaml#L12

@philips that link does not work.

The file was renamed. See it here: https://github.com/etcd-io/discovery.etcd.io/blob/master/etcd-cluster.yaml#L14


Adds security context / SYS_ADMIN privileges to bootstrap container

There are multiple issues in getting volume support / PVC to work inside
of an OpenShift container, such as: https://bugzilla.redhat.com/show_bug.cgi?id=1622670
This PR adds SYS_ADMIN privileges to the boostrap volume copy container, allowing the
container to mount the /tmp folder correctly and thus copy over the files.
During the transition from OpenShift 3.11 to 4.0, SELinux settings (look) to have changed,
I have yet to confirm this however..
Closes https://github.com/openshift/odo/issues/1623

ping @kadel

Let's see if CI passes :+1: this worked on my 3.11 cluster as well as the 4.0 cluster that @kadel gave me access to!

/refresh
/retest

/hold
I don't think that this is a good solution. I suspect that this decreases the security of the cluster, and this won't be possible to do on all clusters.

I'm going to close this one, as this is not an acceptable solution. #1623 was updated with more inside to what is happening


⚠ Empornium has degraded performance

In c952483, Empornium ($EMP) experienced degraded performance:

HTTP code: 200
Response time: 1333 ms

Resolved: Empornium performance has improved in fcd8f2a.


multiple tweaks

blog sidebar to index page (should probably be an include though)
padding on automation page boxes
more padding to left of login button on nav
nav back to pure black
hide icons on mobile on automation page
code link -> target blank

Release Playbook

[ ] Rebase against master
[ ] Code review
[ ] Merge into master
[ ] Verify changes at http://site-staging.convox.com
[ ] Promote release on site-production in the convox/production Rack

@nzoschke wanna get this one out pretty soon so i can put it down


Challenge [Waypoint: Comparisons with the Logical And Operator]

Challenge Waypoint: Comparisons with the Logical And Operator has an issue.
User Agent is: Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/47.0.2526.106 Safari/537.36.
Please describe how to reproduce this issue, and include links to screenshots if possible.
My code:
function myTest(val) {
  // Only change code below this line

  if (val >= 25 && val<= 50) {
       return "Yes";
   }
  }

  // Only change code above this line
  return "No";
}

// Change this value to test
myTest(40);

You have an extra closing bracket on your if statement.

Thanks!


feat(removeSelected): Make removeSelected configurable

Expose the removeSelected property, and adjust isDisabled behavior so that items that would have been removed from a multiple ui-select element because they are currently selected are disabled instead.
Sample behavior:

In the existing version, id would not have appeared in the dropdown because it is currently selected. This pull request adds the option removeSelected so that, if set to false, selected items still appear in the dropdown but are disabled (like in the screenshot).

@dondi The code itself looks ok but there aren't any unit tests. Can you add some and I'll review again?
Thanks! :+1:

Ack, sorry! I had fixed some unit tests that broke due to this change but then got distracted that day and totally forgot about adding new ones. Sorry, my bad, I will notify you when I’ve put something up.

@dondi Is this PR still something you're working on recently? The functionality this PR contains is something I'm looking for as well, so I could take over the PR if it doesn't fit in your schedule =)

Thanks very much for the offer @thomasmiddeldorp 👍  As it turns out, I was chipping away at it and managed to have enough time to wrap things up this morning. Had a learning curve to climb there for a bit. I just pushed both unit tests and a demo—hope it's what you're looking for.

Almost perfect @dondi! Can you just squash down into a single feat(removeSelected) commit? There is a lot of noise in the commit history some of which has been cancelled out.
Once that's done I'll merge :+1:
Useful reference: Commit Message Guidelines

Ah OK, I'll look into that…I presume the "merge from master" commit that is in between there is part of this noise. Yeah I can see how that would be problematic. Would it work better if I create a fresh branch off upstream then place my changed files there, do a single commit, and issue a new pull request?

OK, I have a new pull request using a fresh branch that is updated from upstream. Hope that will be OK.
New pull request: https://github.com/angular-ui/ui-select/pull/1622

You've opened the new one now but you can just force push to your existing branch after squashing, github would have automatically updated this PR with the new single commit. :-)

Yes, I intended to do that at first, but after looking more closely at the overall commits, there were a couple that were no longer valid plus the merge from master commit was in between commits of mine that I wanted to keep, with potential dependent changes in between. So in the end it was more straightforward to start fresh.


Refactored the node dependencies.

Can you please also remove this devDependencies?
    "bcryptjs": "^2.4.3",
    "boom": "^4.3.1",
     "joi": "^10.5.0",
    "jsonwebtoken": "^7.4.1",
    "mongoose": "^4.10.0",
    "nconf": "^0.8.4",
    "nodemon": "^1.11.0",

Done.

Thanks a lot 👍


Added Amjad Chami to contributors list.

Should fix the merge conflict from earlier.

@mjchami, I'm quite elated about your pull request. I wanna evolve this project to addresses various problems faced by first-time contributors. I'd love to learn about your journey in open source community, the problems, pain points you had etc.
Could you explain how you felt when you went through the tutorial, made a pull request and learned that I merged it?
We’ve recently added Facebook share and tweet feature to our web app. Could you please go to https://roshanjossey.github.io/first-contributions/#social-share and share your first contribution to open source?
Also, check out projects with easy issues while you’re there.


[FLINK-17857][test] Make K8s e2e tests could run on Mac

Since the code in master has changes after #12451 is approved, I am afraid some K8s e2e tests still could not work on Mac OS. This PR will fix these tests and make them could run on Mac. Of cause, the PR will not affect the E2E tests on azure.
I have run the following tests on Mac for more than five times for each. They could all pass.

test_kubernetes_application.sh
test_kubernetes_embedded_job.sh
test_kubernetes_session.sh
test_kubernetes_itcases.sh
test_kubernetes_pyflink_application.sh

cc @rmetzger could you please have a look at your convenience?

Rebase latest master and force pushed.


Upgrade mechanism for new embeddings table

Split from:

#8
#3

Options for this:

Documentation: tell people what commands to run to upgrade
Provide a tool (maybe CLI-based) for applying this upgrade
Upgrade automatically

I thought I'd deployed this to Datasette Cloud, but I just checked and it turns out I've only used this in demos there but not made it available to all users - so the need for automatic upgrade is greatly reduced.

I am going to document this exclusively in the release notes.

If you have previously calculated embedding vectors stored in columns on an existing table, you can migrate them to the new table structure by following these steps:

Create a new shadow table to store your embeddings. This table should have the name _embeddings_TABLE where TABLE is the name of your source table, and the same primary key (or compound primary keys). It should then have a emb_xxx column for each stored embedding vector.
One way to create this table is to select a single row and embed just that - this will create the table for you while only costing you one embedding run.

Run the following SQL query to copy across your vectors:
insert or replace into _embeddings_TABLE (id, emb_xxx)
select id, emb_xxx from TABLE

Drop the old column: alter table TABLE drop column emb_xxx

I'm going to try those instructions against this existing table:
CREATE TABLE [releases] (
   [html_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [author] INTEGER REFERENCES [users]([id]),
   [node_id] TEXT,
   [tag_name] TEXT,
   [target_commitish] TEXT,
   [name] TEXT,
   [draft] INTEGER,
   [prerelease] INTEGER,
   [created_at] TEXT,
   [published_at] TEXT,
   [body] TEXT,
   [repo] INTEGER REFERENCES [repos]([id])
, [reactions] TEXT, [mentions_count] INTEGER, [emb_text_embedding_3_small_512] BLOB)

Confirmed: I ran this and got the correct upgrade:
CREATE TABLE [_embeddings_releases] (
   [id] INTEGER PRIMARY KEY,
[emb_text_embedding_3_small_512] BLOB);

insert or replace into _embeddings_releases (id, emb_text_embedding_3_small_512)
  select id, emb_text_embedding_3_small_512 from releases where emb_text_embedding_3_small_512 is not null;

alter table releases drop column emb_text_embedding_3_small_512;


There are seams in the corners of borders

 Issue by Hixie
Tuesday Aug 25, 2015 at 21:49 GMT
Originally opened as https://github.com/flutter/engine/issues/825

At least on a Nexus 9, running examples/widgets/pop_out_and_expand.dart , there are obvious seams in each corner of each box.

 Comment by abarth
Wednesday Aug 26, 2015 at 18:58 GMT

Chrome does a good job of this.  We should dump their SkPictures to see what commands they use to get nice seams.

I'm going to guess that this is not longer an issue?

I don't think the code has changed since then, it seems unlikely it's been fixed.

Looks fixed
import 'package:flutter/material.dart';

void main() => runApp(MyApp());

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Flutter Demo',
      theme: ThemeData(
        primarySwatch: Colors.blue,
      ),
      home: MyHomePage(title: 'Flutter Demo Home Page'),
    );
  }
}

class MyHomePage extends StatefulWidget {
  MyHomePage({Key key, this.title}) : super(key: key);

  final String title;

  @override
  _MyHomePageState createState() => _MyHomePageState();
}

class _MyHomePageState extends State<MyHomePage> {
  @override
  Widget build(BuildContext context) {
    return Scaffold(
      body: Center(
        child: Container(
          padding: EdgeInsets.all(10),
          decoration: BoxDecoration(
              color: Colors.blue[700],
              border: Border.all(width: 9, color: Colors.red[700])),
          child: Text(
            'THIS IS COOOOOOOO0!!!!!!!',
            style: TextStyle(color: Colors.white),
          ),
        ),
      ),
    );
  }
}

[✓] Flutter (Channel beta, v0.11.10, on Mac OS X 10.14.1 18B75, locale en-AT)
    • Flutter version 0.11.10 at /Users/zoechi/flutter/flutter
    • Framework revision c27c4a265e (3 days ago), 2018-11-26 17:07:24 -0500
    • Engine revision eebc6a5895
    • Dart version 2.1.0 (build 2.1.0-dev.9.4 f9ebf21297)

[✓] Android toolchain - develop for Android devices (Android SDK 28.0.3)
    • Android SDK at /usr/local/opt/android-sdk
    • Android NDK at /usr/local/opt/android-sdk/ndk-bundle
    • Platform android-28, build-tools 28.0.3
    • ANDROID_HOME = /usr/local/opt/android-sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1024-b01)
    • All Android licenses accepted.

[!] iOS toolchain - develop for iOS devices (Xcode 10.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 10.1, Build version 10B61
    ✗ Verify that all connected devices have been paired with this computer in Xcode.
      If all devices have been paired, libimobiledevice and ideviceinstaller may require updating.
      To update with Brew, run:
        brew update
        brew uninstall --ignore-dependencies libimobiledevice
        brew uninstall --ignore-dependencies usbmuxd
        brew install --HEAD usbmuxd
        brew unlink usbmuxd
        brew link usbmuxd
        brew install --HEAD libimobiledevice
        brew install ideviceinstaller
    • ios-deploy 1.9.4
    • CocoaPods version 1.5.3

[✓] Android Studio (version 3.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 23.1.2
    • Dart plugin version 173.4700
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1024-b01)

[✓] IntelliJ IDEA Ultimate Edition (version 2018.2.5)
    • IntelliJ at /Applications/IntelliJ IDEA.app
    • Flutter plugin version 30.0.2
    • Dart plugin version 182.5124

[✓] Connected device (1 available)
    • Pixel XL                  • HT69V0203649  • android-arm64 • Android 9 (API 28)
     • Android SDK built for x86 • emulator-5554 • android-x86 • Android 8.1.0 (API 27) (emulator)

! Doctor found issues in 1 category.

(also texted on


World Border Visibility

The Worldborder is no longer visualized by particles. Actually, the border should be shown to the player with flame particles just before he meets it ((https://imgur.com/a/yg022Jy). Since I went from version 1.13.2 to version 1.15.2 this feature does not work anymore. No config settings and not even the Worldborder version has been changed. The Worldborder is just completely invisible.
Paper 1.15.2 – 220
WorldBorder 1.9.10

It was not a Worldborder bug, but a bug in the visualization using the SelectionVisualizer plugin. Worldborder has never had such a feature. Sorry for the inconvenience!


Add mPulse Analytics

This adds support for the mPulse performance analytics library.

Thanks :)

Thank you for the awesome plugin and example code.


jupyterlab_nengo -> jupyterlab-nengo

Could you rename this repo and update the appropriate references to jupyterlab-nengo?

For sure, it seemed to me that the underscore notation is standard for JupyterLab extensions (examples: 1, 2, 3, 4, 5) and they are published on/installed with npm, not pip. But turns out there is also a number of extensions using the hyphen notation (1, 2, 3, 4, 5).


[feat] Add temp adhoc post processing logic for certain tools

Codecov Report
Attention: 24 lines in your changes are missing coverage. Please review.

Comparison is base (f71a0b0) 62.28% compared to head (fecc030) 61.83%.

Files
Patch %
Lines

...ebot-agent/src/erniebot_agent/tools/remote_tool.py
22.58%
24 Missing :warning:

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #176      +/-   ##
===========================================
- Coverage    62.28%   61.83%   -0.46%
===========================================
  Files           56       56
  Lines         2678     2709      +31
===========================================
+ Hits          1668     1675       +7
- Misses        1010     1034      +24

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


[Bug] Static and Class methods are added to the example request bodies

Describe the bug
Class / static methods are included in the example request body.
To Reproduce
Create a dataclass add a class/static method to it and set it to a requestbody with @openapi.body({"application/json": Class})
Expected behavior
We pass an instance of a class so class and static methods should not be in the documentation.
Environment (please complete the following information):

OS: Pop OS 22.04
Browser curl
Version 22.3.1

This issue cause my application not to start under Python 3.10.

Can you provide a minimal sample code snippet?

Maybe fixed by #98?

The classmethod will be a nice quick fix that I will get out and released. But unicode? :confused: Where is there Python 2 code?! Certainly not from Sanic.

@ahopkins thank you you're a legend


Log density with proportionality in ADVI drops more than constant

Summary:
Log density with proportionality in ADVI drops more than constant
Description:
According to stan C++ guidance (https://github.com/stan-dev/stan/wiki/Model-Concept), the log probability of a stan model, with or without proportionality, can be calculated from
template <bool propto, bool jacobian_adjust_transforms, typename T>
T
log_prob(std::vector<T>& params_r,
         std::vector<int>& params_i,
         std::ostream* msgs = 0)
const;

But I find the difference between the exact and proportional log density in Stan ADVI code is not a constant.
Reproducible Steps:
In order to calculate both the exact log density and proportional log density in the unconstrained space, and to print their difference,  add these lines before
https://github.com/stan-dev/stan/blob/12f031565df6265356bdc4c6b191d8df619151f5/src/stan/variational/advi.hpp#L540
            double log_p_exact=0;
            double log_p_prop=0;
            log_p_exact = model_.template log_prob<false, true>(cont_params_);
            log_p_prop = model_.template log_prob<true, true>(cont_params_);
            std::stringstream ss;
            ss << "constant dropped="<<log_p_exact-log_p_prop<<"======";
            std::cout<<ss.str();

Then we can make  cmdstan and run the bernoulli example:
examples/bernoulli/bernoulli variational algorithm=meanfield iter=1000 output_samples=30 data file=examples/bernoulli/bernoulli.data.R

Current Output:
We should expect the output being a constant for all posterior draws, which stands for the log constant term in densities. But it  is not. For instance here is the first 6 lines of the output:
constant dropped==-5.24628
constant dropped==-5.20678
constant dropped==-5.78415
constant dropped==-5.37678
constant dropped==-5.02283
constant dropped==-5.59698

I check that the exact log density ( model_.template log_prob<false, true> ) does return the log density plus jacobian.
Current Version:
v2.17.1

Can you provide a minimal example? An easy way to do it is to just put it
on a branch. (The breadcrumbs you left aren't enough.) Or just isolate it
in a test.
Something looks off. Can you print the cont_params_ and the values for
log_p_exact and log_p_prop? That would help a bit.
On Wed, Apr 25, 2018 at 10:04 PM, Yuling Yao<EMAIL_ADDRESS>wrote:

Summary:
Log density with proportionality in ADVI drops more than constant
Description:
According to stan C++ guidance (https://github.com/stan-dev/
stan/wiki/Model-Concept), the log probability of a stan model, with or
without proportionality, can be calculated from
template <bool propto, bool jacobian_adjust_transforms, typename T>
T
log_prob(std::vector& params_r,
std::vector& params_i,
std::ostream* msgs = 0)
const;
But I find the difference between the exact and proportional log density
in Stan ADVI code is not a constant.
Reproducible Steps:
In order to calculate both the exact log density and proportional log
density in the unconstrained space, and to print their difference, add
these lines before
https://github.com/stan-dev/stan/blob/12f031565df6265356bdc4c6b191d8
df619151f5/src/stan/variational/advi.hpp#L540
        double log_p_exact=0;
        double log_p_prop=0;
        log_p_exact = model_.template log_prob<false, true>(cont_params_);
        log_p_prop = model_.template log_prob<true, true>(cont_params_);
        std::stringstream ss;
        ss << "constant dropped="<<log_p_exact-log_p_prop<<"======";
        std::cout<<ss.str();

Then we can make cmdstan and run the bernoulli example:
examples/bernoulli/bernoulli variational algorithm=meanfield iter=1000 output_samples=30 data file=examples/bernoulli/bernoulli.data.R
Current Output:
We should expect the output being a constant for all posterior draws,
which stands for the log constant term in densities. But it is not. For
instance here is the first 6 lines of the output:
constant dropped==-5.24628
constant dropped==-5.20678
constant dropped==-5.78415
constant dropped==-5.37678
constant dropped==-5.02283
constant dropped==-5.59698
I check that the exact log density ( model_.template log_prob<false, true>
) does return the log density plus jacobian.
Current Version:
v2.17.1
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/stan-dev/stan/issues/2518, or mute the thread
https://github.com/notifications/unsubscribe-auth/AAZ_F2pz4yqLIVWm9a_1egPgVO-QxrYOks5tsSsbgaJpZM4TkaHA
.


Architecture Changes From DINO-DETR

Hello,
Thanks for the great work.
I wonder that the architecture changes such as two stage structure of DAB-Deformable-DETR (mixed query selection) which is implemented on DINO-DETR paperwork, will be also released in this repo or only in DINO-DETR page?
Additional question is that will the DINO-DETR github repo will be based upon this repo, or will there be some drastic changes? If we start from this repo, can it be easy to move the changes of DINO training and model modifications into this repo when DINO page is released?
Thank you so much for your responses in advance.

We will consider providing the two-stage variant of DAB-Deformable-DETR after DINO-DETR is released.
There will be many improvements for the DINO-DETR repo compared with this repo. But I think it is not hard to migrate the models bi-directionally.


Regression: Do not parse cve if cve == None

safety version: 2.2.0
Python version: 3.8
Operating System: Linux - Ubuntu 18.04.1 (docker image: python:3.8)

Description
The database file contains entries with the cve field equals to null. Contrary to 1.10.3 which only parses the field if it is neither None or "", the version 2.2.0 assumes it is always a string.
What I Did
$ safety --debug check

Traceback (most recent call last):
  File "/usr/local/lib/python3.8/site-packages/safety/cli.py", line 143, in check
    vulns, db_full = safety.check(packages=packages, key=key, db_mirror=db, cached=cache, ignore_vulns=ignore,
  File "/usr/local/lib/python3.8/site-packages/safety/util.py", line 601, in new_func
    return f(*args, **kwargs)
  File "/usr/local/lib/python3.8/site-packages/safety/safety.py", line 341, in check
    cve = get_cve_from(data, db_full)
  File "/usr/local/lib/python3.8/site-packages/safety/safety.py", line 279, in get_cve_from
    cve_id = data.get("cve", '').split(",")[0].strip()
AttributeError: 'NoneType' object has no attribute 'split'

$ curl "https://raw.githubusercontent.com/pyupio/safety-db/bc28866e8129481f6b7b687591ae59e96f567dd1/data/insecure_full.json" -s  | grep -A5 -B2 '"cve": null'

        {
            "advisory": "Hypercorn 0.6.0 pauses reading during h11 pipelining, fixing a potential DOS weakness.",
            "cve": null,
            "id": "pyup.io-50866",
            "more_info_path": "/vulnerabilities/None/50866/",
            "specs": [
                "<0.6.0"
            ],
--
        {
            "advisory": "Opendp 0.5.0 hardens samplers to handle some privacy violation cases.\r\nhttps://github.com/opendp/opendp/pull/481",
            "cve": null,
            "id": "pyup.io-50829",
            "more_info_path": "/vulnerabilities/None/50829/",
            "specs": [
                "<0.5.0"
            ],

Hi @v01dXYZ, thanks for reporting this issue; we appreciate your report.
I want to explain that now (Safety 2.0+), all the vulnerabilities have a link to a CVE ID (or a PVE ID), so this issue is a bug coming from the bot's free and open-source database process and upload.
Therefore we are working on finding and fixing the issue that exported those null CVEs; also, we have added handling for "None" CVE ids in the Safety code.
PR #412 has the extra validation for None CVE ids; it will be available in the following Safety version.
I will close this issue; please, open a new one or comment if you have any other questions or concerns.


Does chart.xkcd Have A Privacy Policy?

I've observed that the library doesn't collect/send any data but wondered if it might be useful to add a privacy policy confirming this for sure in the documentation/readme?

This is a pure frontend lib and does not collect/send any data.
But I am not familiar with Privacy Policy, do you have any example repo with similar privacy policy documentation?

I'm developing a wrapper for chart.xkcd for Power BI and it's nearly ready, so I'm just working on the documentation and thought I'd better add one so juct wante to confirm my thinking - I had reviewed the code and was happy that it didn't collect anything.
As an exmaple, I'll provide you with one of mine - here's a custom visual I already have in production for Power BI. Privacy policies can potentially much more complicated than this if they do collect data, but this one is what most people would be keen to be assured of when using a product.
As Power BI visuals are written in TypeScript and there's potential for other server-side stuff to be added in there, users generally like some assurance in terms of a privacy policy. While the code is open source, most people using Power BI are not familiar with JS/TS and will not have the capability to vet this themselves, so it is a common question asked of custom visual developers.
I'll be providing this confirmation from my side for the solution and your above comment from yourself is all I need to confirm the visual - as a full solution - doesn't do anything other that use data for display purposes.
Thanks so much for responding, and thanks so much for a great library! I'll be sure to send you the repo when it's ready, or add it to #14, if that's okay?

@dm-p That's ok, thanks


test(image-stream): increase DMG tests timeouts

I caught an sporadic issue a couple of times, where the DMG tests would
exceed the default 2000ms mocha timeout. All the other image
decompression tests have a much higher timeout already, so this commit
adds the same timeout to the DMG tests file.
Signed-off-by: Juan Cruz Viotti<EMAIL_ADDRESS>

Although 20 seconds is a bit high, I think. Anyways, out of curiosity – where did those timeouts happen? On CI or locally? And can you remember with which one exactly (I suspect bzip2, or adc)?

We used to have lower timeouts, but at some point I increased them to 20s because of Appveyor I think. I'm pretty sure it was bzip2.

All the other image
decompression tests have a much higher timeout already, so this commit
adds the same timeout to the DMG tests file.

Could this somehow be configured as a shared 'disk tests timeout' constant, so that it doesn't need to be duplicated in several different places? (which will be useful if we ever need to increase it again in future, for some reason)

Done, see https://github.com/resin-io/etcher/pull/1599


Transfer Learning issue

Hi,
I tried to follow the steps in developer.md, I encountred a problem after :
cd $TIEFVISION_HOME/src/torch/1-split-encoder-classifier
luajit split-encoder-classifier.lua

this is the error I got :

THCudaCheck FAIL file=/home/dim/torch/extra/cutorch/lib/THC/THCGeneral.c line=66 error=35 : CUDA driver version is insufficient for CUDA runtime version
luajit: cuda runtime error (35) : CUDA driver version is insufficient for CUDA runtime version at /home/dim/torch/extra/cutorch/lib/THC/THCGeneral.c:66
stack traceback:
	[C]: at 0x7f8d34a44720
	[C]: in function 'require'
	/home/dim/torch/install/share/lua/5.1/cutorch/init.lua:2: in main chunk
	[C]: in function 'require'
	/home/dim/torch/install/share/lua/5.1/cunn/init.lua:3: in main chunk
	[C]: in function 'require'
	/home/dim/torch/install/share/lua/5.1/inn/ffi.lua:6: in main chunk
	[C]: in function 'require'
	/home/dim/torch/install/share/lua/5.1/inn/init.lua:3: in main chunk
	[C]: in function 'require'
	split-encoder-classifier.lua:16: in main chunk
	[C]: at 0x00405d50

PS : I'm using cuda 8.0
Thanks,

Which GPU and GPU driver do you have installed?

GPU : nvidia Quadro FX 1080
GPU driver : 340.101

I cannot find that card in https://developer.nvidia.com/cuda-gpus
You will have to check first the 'compute capability' of the card and base on that install the CUDA driver that is highest and is compatible with your compute capability. Each nVIdia driver and CUDA release (check nVidia doc) has a matrix of compute capabilities which you should check and make sure your graphics card is compatible with.

Hello again, the gpu is nvidia Quadro FX 1800 (not 1080) I made a typo there.
So apparently the gpu is a little bit old. I tried again in the laptop of a friend of mine with this config :
gpu : GeForce 840M
gpu driver : 375.26
(I double checked this time)
but now I have a new error after the same step :
Couldn't load /home/ubuntu/Softs/tiefvision/src/torch/1-split-encoder-classifier/nin_imagenet.caffemodel
luajit: split-encoder-classifier.lua:27: attempt to index a nil value
stack traceback:
	split-encoder-classifier.lua:27: in main chunk
	[C]: at 0x00405d50

(cuda 8.0, ubuntu 16.04)
Thanks again,

You need to download the reference model.
For a complete sequence of commands to do that you can take a look at https://github.com/paucarre/tiefvision/blob/master/bin/unsupervised_similarity or just run that script

Thanks, everything works perfectly :)


⚠ Spryr has degraded performance

In ab41397, Spryr (https://spryr.com) experienced degraded performance:

HTTP code: 200
Response time: 3057 ms

Resolved: Spryr performance has improved in 30690e9 after 7 minutes.


Make config value order as same as constant

What is the purpose of the change
code clean.

Coverage decreased (-0.1%) to 51.789% when pulling 94e25fa96e3a2bd5af2498c6ffd46f54a2d814a3 on horizonzy:code-format into 0239421fa59b67c423cf9fcabf5cd6edda0c2076 on apache:develop.

Codecov Report

Merging #2519 (94e25fa) into develop (39bb938) will decrease coverage by 0.17%.
The diff coverage is 100.00%.

@@              Coverage Diff              @@
##             develop    #2519      +/-   ##
=============================================
- Coverage      46.08%   45.91%   -0.18%
+ Complexity      4330     4313      -17
=============================================
  Files            547      547
  Lines          36236    36236
  Branches        4808     4808
=============================================
- Hits           16699    16637      -62
- Misses         17459    17515      +56
- Partials        2078     2084       +6

Impacted Files
Coverage Δ
Complexity Δ

...che/rocketmq/remoting/netty/NettySystemConfig.java
90.90% <100.00%> (ø)
1.00 <1.00> (ø)

...rocketmq/broker/filtersrv/FilterServerManager.java
20.00% <0.00%> (-14.29%)
5.00% <0.00%> (-2.00%)

...org/apache/rocketmq/common/stats/StatsItemSet.java
41.79% <0.00%> (-10.45%)
16.00% <0.00%> (-4.00%)

...org/apache/rocketmq/store/ha/WaitNotifyObject.java
75.00% <0.00%> (-9.62%)
10.00% <0.00%> (-2.00%)

...e/rocketmq/client/impl/consumer/RebalanceImpl.java
45.81% <0.00%> (-9.57%)
32.00% <0.00%> (-4.00%)

...ain/java/org/apache/rocketmq/test/util/MQWait.java
43.24% <0.00%> (-5.41%)
3.00% <0.00%> (ø%)

...mq/client/impl/consumer/RebalanceLitePullImpl.java
49.15% <0.00%> (-5.09%)
10.00% <0.00%> (-1.00%)

...ache/rocketmq/common/stats/MomentStatsItemSet.java
39.13% <0.00%> (-4.35%)
5.00% <0.00%> (-1.00%)

...rg/apache/rocketmq/remoting/netty/NettyLogger.java
17.46% <0.00%> (-3.18%)
2.00% <0.00%> (ø%)

...client/consumer/store/RemoteBrokerOffsetStore.java
67.56% <0.00%> (-1.81%)
20.00% <0.00%> (-2.00%)

... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39bb938...94e25fa. Read the comment docs.


Allow custom base types for structures with optional fields

This a proposed solution to the issue #192.
Extends the templates with a data type template that allows a structure with optional fields to subtype from a custom structure. The template is a copy of the ClassWithOptionalFields.cs with a couple of changes, mainly caused by replacing virtual with override.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Release now has support.


fix registration of selendroid server into a selenium grid

The SelendroidCapabilities requires the selendroid grid node to have the capability: platformName => android

:+1:


enq

how to look up the manu

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 6b07cfcf-8f31-91ed-b1de-c7826a1ab91d
Version Independent ID: dfbc4212-8f47-326a-f872-8186a915ae1e
Content: Country and region availability for Audio Conferencing and Calling Plans
Content Source: Teams/country-and-region-availability-for-audio-conferencing-and-calling-plans/country-and-region-availability-for-audio-conferencing-and-calling-plans.md
Service: skype-for-business-online
GitHub Login: @tonysmit
Microsoft Alias: tonysmit

A question about Telephony within O365. If the tenant is in a North American DC and the users are geo-dispursed, does the calls made from a user in India within India get treated as local or are they long distance because the tenant is not in India? More specific, how are local and long-distance calls differentiated if the tenant where the user resides is not in their geographic local?

sure

寄件者: James Rhea<EMAIL_ADDRESS>寄件日期: 2019年1月23日 1:38
收件者: MicrosoftDocs/OfficeDocs-SkypeForBusiness
副本: yu kwong yiu wilson; Mention
主旨: Re: [MicrosoftDocs/OfficeDocs-SkypeForBusiness] enq (#1312)
@yiuyu2357https://github.com/yiuyu2357, can you say a bit more about what you're trying to do?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/MicrosoftDocs/OfficeDocs-SkypeForBusiness/issues/1312#issuecomment-456634467, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AHkl46xzkQ-Lvs6Uli5_mIcj0iMOF6Y3ks5vF70EgaJpZM4ZjYem.

Hi @KDawg05 , thank you for your feedback.
For example, if when you have configured the license for this user you chose India as location, calls to Indian numbers will be treated as local. You can see this information here:
https://docs.microsoft.com/en-us/microsoftteams/calling-plans-for-office-365#pricing-information

@KDawg05  Thank you for submitting this feedback.
From our understanding the issue has been resolved. If you feel it hasn't been resolved please re-open this issue.
@yiuyu2357  We appreciate any feedback that improves the content in the Microsoft docs but we haven't had any response from you so we are going to close this issue.
Please feel free to re-open this issue if there is a specific area of the docs that we can improve or make better. Thank you.

@officedocsbot close

James Rhea<EMAIL_ADDRESS>於 2019年1月23日 週三 上午9:38寫道：

@yiuyu2357 https://github.com/yiuyu2357, can you say a bit more about
what you're trying to do?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/MicrosoftDocs/OfficeDocs-SkypeForBusiness/issues/1312#issuecomment-456634467,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AHkl46xzkQ-Lvs6Uli5_mIcj0iMOF6Y3ks5vF70EgaJpZM4ZjYem
.

bluesky321<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>Dario Woitasen<EMAIL_ADDRESS>於 2019年3月30日 週六 上午8:47寫道：

[image: Boxbe] https://www.boxbe.com/overview Dario Woitasen (
<EMAIL_ADDRESS>is not on your Guest List
https://www.boxbe.com/approved-list?tc_serial=49173835690&tc_rand=1386889932&utm_source=stf&utm_medium=email&utm_campaign=ANNO_MWTP&utm_content=001&key=Zi%2BfcftGZePFELhuwCzWTMh5sEoVQdxkrzWnGDe7c%2F4%3D&token=sGHhXC8kVxm8dLnCbQZxX5pBDh%2F1ckNLO9C7rYVcjehitVLyphGhd81ZFupuy5DB
| Approve sender
https://www.boxbe.com/anno?tc_serial=49173835690&tc_rand=1386889932&utm_source=stf&utm_medium=email&utm_campaign=ANNO_MWTP&utm_content=001&key=Zi%2BfcftGZePFELhuwCzWTMh5sEoVQdxkrzWnGDe7c%2F4%3D&token=sGHhXC8kVxm8dLnCbQZxX5pBDh%2F1ckNLO9C7rYVcjehitVLyphGhd81ZFupuy5DB
| Approve domain
https://www.boxbe.com/anno?tc_serial=49173835690&tc_rand=1386889932&utm_source=stf&utm_medium=email&utm_campaign=ANNO_MWTP&utm_content=001&dom&key=Zi%2BfcftGZePFELhuwCzWTMh5sEoVQdxkrzWnGDe7c%2F4%3D&token=sGHhXC8kVxm8dLnCbQZxX5pBDh%2F1ckNLO9C7rYVcjehitVLyphGhd81ZFupuy5DB
Hi @KDawg05 https://github.com/KDawg05 , thank you for your feedback.
For example, if when you have configured the license for this user you
chose India as location, calls to Indian numbers will be treated as local.
You can see this information here:
https://docs.microsoft.com/en-us/microsoftteams/calling-plans-for-office-365#pricing-information
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/MicrosoftDocs/OfficeDocs-SkypeForBusiness/issues/1312#issuecomment-478181409,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AHkl45wJ2bEGbjOlDsOM_VVfk4aw-RZzks5vbqVdgaJpZM4ZjYem
.

jack wong<EMAIL_ADDRESS>於 2019年4月9日 週二 上午9:55寫道：

bluesky321<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>Dario Woitasen<EMAIL_ADDRESS>於 2019年3月30日 週六 上午8:47寫道：

[image: Boxbe] https://www.boxbe.com/overview Dario Woitasen (
<EMAIL_ADDRESS>is not on your Guest List
https://www.boxbe.com/approved-list?tc_serial=49173835690&tc_rand=1386889932&utm_source=stf&utm_medium=email&utm_campaign=ANNO_MWTP&utm_content=001&key=Zi%2BfcftGZePFELhuwCzWTMh5sEoVQdxkrzWnGDe7c%2F4%3D&token=sGHhXC8kVxm8dLnCbQZxX5pBDh%2F1ckNLO9C7rYVcjehitVLyphGhd81ZFupuy5DB
| Approve sender
https://www.boxbe.com/anno?tc_serial=49173835690&tc_rand=1386889932&utm_source=stf&utm_medium=email&utm_campaign=ANNO_MWTP&utm_content=001&key=Zi%2BfcftGZePFELhuwCzWTMh5sEoVQdxkrzWnGDe7c%2F4%3D&token=sGHhXC8kVxm8dLnCbQZxX5pBDh%2F1ckNLO9C7rYVcjehitVLyphGhd81ZFupuy5DB
| Approve domain
https://www.boxbe.com/anno?tc_serial=49173835690&tc_rand=1386889932&utm_source=stf&utm_medium=email&utm_campaign=ANNO_MWTP&utm_content=001&dom&key=Zi%2BfcftGZePFELhuwCzWTMh5sEoVQdxkrzWnGDe7c%2F4%3D&token=sGHhXC8kVxm8dLnCbQZxX5pBDh%2F1ckNLO9C7rYVcjehitVLyphGhd81ZFupuy5DB
Hi @KDawg05 https://github.com/KDawg05 , thank you for your feedback.
For example, if when you have configured the license for this user you
chose India as location, calls to Indian numbers will be treated as local.
You can see this information here:
https://docs.microsoft.com/en-us/microsoftteams/calling-plans-for-office-365#pricing-information
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/MicrosoftDocs/OfficeDocs-SkypeForBusiness/issues/1312#issuecomment-478181409,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AHkl45wJ2bEGbjOlDsOM_VVfk4aw-RZzks5vbqVdgaJpZM4ZjYem
.


Adding Terms and Conditions as a new page

@MitulSonagara
I would like to add the terms and conditions in the footer
could you please assign this to me

@AswaniBolisetti
go for it

@MitulSonagara please assign this issue to me i want to work on it


Better Error Message for Conflicts in ModelView Configuration Attributes

I've spent quite some time to realized a simple mistake made in the ModelView Configuration Attributes: form_excluded_columns vs. form_rules. As it turned out, the fields should be mutually exclusive between those two buckets. If you put the same field into both buckets, it's gonna give this error:
admin_1 | <IP_ADDRESS> - - [01/Apr/2016 18:25:45] "GET /admin/user/edit/?id=1 HTTP/1.1" 500 -
admin_1 | Traceback (most recent call last):
admin_1 |   File "/usr/local/lib/python3.4/site-packages/flask/app.py", line 1836, in __call__
admin_1 |     return self.wsgi_app(environ, start_response)
admin_1 |   File "/usr/local/lib/python3.4/site-packages/flask/app.py", line 1820, in wsgi_app
admin_1 |     response = self.make_response(self.handle_exception(e))
admin_1 |   File "/usr/local/lib/python3.4/site-packages/flask/app.py", line 1403, in handle_exception
admin_1 |     reraise(exc_type, exc_value, tb)
admin_1 |   File "/usr/local/lib/python3.4/site-packages/flask/_compat.py", line 33, in reraise
admin_1 |     raise value
admin_1 |   File "/usr/local/lib/python3.4/site-packages/flask/app.py", line 1817, in wsgi_app
admin_1 |     response = self.full_dispatch_request()
admin_1 |   File "/usr/local/lib/python3.4/site-packages/flask/app.py", line 1477, in full_dispatch_request
admin_1 |     rv = self.handle_user_exception(e)
admin_1 |   File "/usr/local/lib/python3.4/site-packages/flask/app.py", line 1381, in handle_user_exception
admin_1 |     reraise(exc_type, exc_value, tb)
admin_1 |   File "/usr/local/lib/python3.4/site-packages/flask/_compat.py", line 33, in reraise
admin_1 |     raise value
admin_1 |   File "/usr/local/lib/python3.4/site-packages/flask/app.py", line 1475, in full_dispatch_request
admin_1 |     rv = self.dispatch_request()
admin_1 |   File "/usr/local/lib/python3.4/site-packages/flask/app.py", line 1461, in dispatch_request
admin_1 |     return self.view_functions[rule.endpoint](**req.view_args)
admin_1 |   File "/usr/local/lib/python3.4/site-packages/flask_admin/base.py", line 68, in inner
admin_1 |     return self._run_view(f, *args, **kwargs)
admin_1 |   File "/usr/local/lib/python3.4/site-packages/flask_admin/base.py", line 367, in _run_view
admin_1 |     return fn(self, *args, **kwargs)
admin_1 |   File "/usr/local/lib/python3.4/site-packages/flask_admin/model/base.py", line 1913, in edit_view
admin_1 |     return_url=return_url)
admin_1 |   File "/usr/local/lib/python3.4/site-packages/flask_admin/base.py", line 307, in render
admin_1 |     return render_template(template, **kwargs)
admin_1 |   File "/usr/local/lib/python3.4/site-packages/flask/templating.py", line 128, in render_template
admin_1 |     context, ctx.app)
admin_1 |   File "/usr/local/lib/python3.4/site-packages/flask/templating.py", line 110, in _render
admin_1 |     rv = template.render(context)
admin_1 |   File "/usr/local/lib/python3.4/site-packages/jinja2/environment.py", line 969, in render
admin_1 |     return self.environment.handle_exception(exc_info, True)
admin_1 |   File "/usr/local/lib/python3.4/site-packages/jinja2/environment.py", line 742, in handle_exception
admin_1 |     reraise(exc_type, exc_value, tb)
admin_1 |   File "/usr/local/lib/python3.4/site-packages/jinja2/_compat.py", line 36, in reraise
admin_1 |     raise value.with_traceback(tb)
admin_1 |   File "/usr/local/lib/python3.4/site-packages/flask_admin/templates/bootstrap2/admin/model/edit.html", line 6, in <module>
admin_1 |     <input name="_continue_editing" type="submit" class="btn" value="{{ _gettext('Save and Continue Editing') }}" />
admin_1 |   File "/usr/local/lib/python3.4/site-packages/flask_admin/templates/bootstrap2/admin/master.html", line 1, in <module>
admin_1 |     {% extends admin_base_template %}
admin_1 |   File "/usr/local/lib/python3.4/site-packages/flask_admin/templates/bootstrap2/admin/base.html", line 30, in <module>
admin_1 |     {% block page_body %}
admin_1 |   File "/usr/local/lib/python3.4/site-packages/flask_admin/templates/bootstrap2/admin/base.html", line 59, in <module>
admin_1 |     {% block body %}{% endblock %}
admin_1 |   File "/usr/local/lib/python3.4/site-packages/flask_admin/templates/bootstrap2/admin/model/edit.html", line 36, in <module>
admin_1 |     {% block edit_form %}
admin_1 |   File "/usr/local/lib/python3.4/site-packages/flask_admin/templates/bootstrap2/admin/model/edit.html", line 37, in <module>
admin_1 |     {{ lib.render_form(form, return_url, extra(), form_opts) }}
admin_1 |   File "/usr/local/lib/python3.4/site-packages/flask_admin/templates/bootstrap2/admin/lib.html", line 212, in <module>
admin_1 |     {% call form_tag(action=action) %}
admin_1 |   File "/usr/local/lib/python3.4/site-packages/flask_admin/templates/bootstrap2/admin/lib.html", line 191, in <module>
admin_1 |     {{ caller() }}
admin_1 |   File "/usr/local/lib/python3.4/site-packages/flask_admin/templates/bootstrap2/admin/lib.html", line 213, in <module>
admin_1 |     {{ render_form_fields(form, form_opts=form_opts) }}
admin_1 |   File "/usr/local/lib/python3.4/site-packages/flask_admin/templates/bootstrap2/admin/lib.html", line 174, in <module>
admin_1 |     {{ r(form, form_opts=form_opts) }}
admin_1 |   File "/usr/local/lib/python3.4/site-packages/flask_admin/form/rules.py", line 109, in __call__
admin_1 |     result.append(r(form, form_opts, field_args))
admin_1 |   File "/usr/local/lib/python3.4/site-packages/flask_admin/form/rules.py", line 305, in __call__
admin_1 |     raise ValueError('Form %s does not have field %s' % (form, self.field_name))
admin_1 | ValueError: Form <flask_admin.contrib.sqla.form.UserForm object at 0x7f8c63cba6a0> does not have field modified_at

The offending code is as below:
from flask.ext.admin.contrib.sqla import ModelView
from flask_admin.form import rules

class User(db.Model):
    id = db.Column(db.Integer, primary_key=True)
    username = db.Column(db.String(80), unique=True)
    email = db.Column(db.String(120), unique=True)
    created_at = db.Column(db.DateTime)
    modified_at = db.Column(db.DateTime)

class User(ModelView)
    form_excluded_columns = ['modified_at']

    form_rules = [
        rules.FieldSet(('id', 'username'),
                       'email'),
        rules.FieldSet(('created_at', 'modified_at'),
                       'Meta'),
    ]

I am running Flask-Admin==1.4.0.  The error was very confusing at first. Perhaps to give a better error message, we should have check the opposing config first before we raise a ValueError?

Closing this now. But I agree that it's confusing. A PR to fix this would be welcome.


Update caching-your-github-credentials-in-git.md

Adding help on how to clear potentially cached, invalid credentials. I had this problem when switching to Personal Access Token abd ithing on github helped. I finally found the asnwer on stack overflow: https://stackoverflow.com/a/66692418

Why:
Closes [issue link]

What's being changed:

Check off the following:

[ ] I have reviewed my changes in staging (look for the latest deployment event in your pull request's timeline, then click View deployment).
[ x] For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

[ ] This pull request impacts the contribution experience

[ ] I have added the 'writer impact' label
[ ] I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

Hai frnd

@pierrebai
Thanks so much for opening a PR! I' got this triaged for review :zap:


Solved A few issues in Network Merger

In the finding unique name function, when a network name already exists in the workspace, append “_n” to the name instead of “n”.  When a user does change the name to a duplicate name, change the text color to orange and add a message explaining the reason.

In the default setting, name the new attribute “Matching.Attribute”  and rename the existing “Matching.Attribute” to “Matching.Attribute_n” if there is already one exists. Add checkers for duplicate attribute names. If the duplicates are detected, change the text to red and having a red error message somewhere in that dialog box.

When an error is detected, grey out the merge button and display the reason in the tooltip instead of popup an error message after the user clicks the merge button.

Make the header of the 2 tables in the network selector section more obvious.

Sort the list in the left window in alphabetical order (case insensitive).

Add tooltip to  “Matching.Attribute”  and also change the text color to make it more clear.

Updates:

List Subheader UI

Rename the 'Matching.Attribute' to 'Matching.Attribute_n' if there is already such attribute name existing

Made the type conflict tooltip more detailed and updated other tooltips.


MN install script error Libraries after executing monoecid

When executing the script and running the command: monoecid
I get the following error message:
monoecid: error while loading shared libraries: libevent_pthreads-2.0.so.5: cannot open shared object file: No such file or directory
What can I do?
Thanks for everybody who response.

I did run the following and that solved the problem.
sudo apt-get install libevent-pthreads-2.0-5


Add 'json()' response format

When I get a response from a get call or a subscription, I'd like the sdk to parse json for me optionally.
I often store stringified json objects as cache items and when I receive a response, it would be a nice developer experience to have it returned as an object. Thinking something like this:
const getResponse = await cacheClient.get('myCache', 'key');
if(getResponse instanceof CacheGet.Hit) {
  const myObject = getResponse.json();
}

If the value is not a stringified object, I'd expect an error to be thrown if this is called.

You can see an example in Postman's documentation here.


Armando/grwth 3860 pass currency to acceptbidmodal

@r3lays after we fix these conflicts we can merge it into the next release, we'll also need a changeset. Should be a patch version.


Added undefined check to event action

Description
Added undefined check to event action to prevent events without actions from being named as eventName.undefined
Issues Resolved
Part of https://github.com/opensearch-project/opensearch-metrics/issues/76
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Seems like the version bump checking is not correct.
Will check now.


Rename function name to avoid conflicts

Following the feedback on the forum: https://www.prestashop.com/forums/topic/1023519-fatal-error-module-file/

l.43 must be updated as well.

Thanks @Quetzacoalt91


[stable/grafana] Allow storing grafana.ini as a secret

Is your feature request related to a problem? Please describe.
Grafana.ini is currently stored as a configmap value. I have to configure auth.generic_oauth with client_id and client_secret and also I would like to configure external database connection with password authentication. Storing it in configmap is not the best idea...
Describe the solution you'd like
Be able to use existing secret as a grafana.ini source.
Describe alternatives you've considered
Alternatively you can provide separate options to configure database connection and auth.generic_oauth.
Additional context
https://github.com/helm/charts/issues/22175 can be related

I concur. My deployment of grafana requires the use of a couple of secrets and passwords for oauth and datasources. Since everything is routed through the grafana.ini, I am looking for a good way to obfuscate those values.

We are facing the same issue here. We need to configure a client_secret and would prefer if it wouldn't show up in the clear...

This stale bot is absolutely useless...
As mentioned in my other issue #22175 it's important that I can use kubernetes secrets to store these secrets and not require to have them in my values for helm to render. existingSecret is already a function that is supported in the helm chart itself. EG.
admin:
  existingSecret: 'grafana-admin-creds'
   userKey: admin-user
   passwordKey: admin-password

Something a long these lines would suffice and be a much better solution.

@davidkarlsen @mrueg @GMartinez-Sisti Sorry for tagging you all out of an act of desperation, as it appears creating an issue may not be tracked/monitored in this monolithic repo with ease.
Is this something on the current roadmap?

I'm not a maintainer but I think I can help.
Looks like there is already a way to perform this in a secure fashion without the need to change this chart or use environment variables for secrets.

Grafana config supports file providers for specific values:

file reads a file from the filesystem. It trims whitespace from the beginning and the end of files. The database password in the following example would be replaced by the content of the /etc/secrets/gf_sql_password file:

[database]
password = $__file{/etc/secrets/gf_sql_password}

Use the feature extraSecretMounts (Additional grafana server secret mounts) to mount your secrets, and go from there.

You just need to check where the extraSecretMounts will be available to specify them in grafana.ini.

@GMartinez-Sisti thanks for the swift response!
That is indeed one way, I'm trying to get my head around how that looks, would you be able to provide an example if it's not too much effort?
Ideally, the existingSecret functionality would be the simplest model considering it's already used in a lot of spots already, but if your method works then that is good enough!

Using an example for oauth, you could do something like this:
grafana.ini:
grafana.ini:
  [auth.generic_oauth]
  enabled = true
  client_id = $__file{/etc/secrets/auth_generic_oauth/client_id}
  client_secret = $__file{/etc/secrets/auth_generic_oauth/client_secret}

Existing secret, or created along with helm:
---
apiVersion: v1
kind: Secret
metadata:
  name: auth_generic_oauth_secret
type: Opaque
stringData:
  client_id: <value>
  client_secret: <value>

Config for extraSecretMounts
- extraSecretMounts:
  - name: auth_generic_oauth_secret_mount
     secretName: auth_generic_oauth_secret
     defaultMode: 0440
     mountPath: /etc/secrets/auth_generic_oauth
     readOnly: true

This should work (famous last words™), note that I wasn't able to deploy to test, but according to the chart these are the required configurations.
Please let me know if it worked, and I might send a PR to add this to the README.

Hi @GMartinez-Sisti ,
Thanks for your post - this just worked for me using grafana 7.1+ - you'll need to change _ to - in your secret definition else kube complains (mine did anyway).
Kind regards,
Pete

Unfortunately, mine doesn't seem to work - perhaps I'm missing something, but here is my config:
https://github.com/raspbernetes/k8s-gitops/blob/620b5e1c39373b3a50ab09db06481f65cc26a239/namespaces/observability/prometheus-operator/prometheus-operator.yaml#L158

@GMartinez-Sisti Unfortunately, mine doesn't seem to work - perhaps I'm missing something, but here is my config:
https://github.com/raspbernetes/k8s-gitops/blob/620b5e1c39373b3a50ab09db06481f65cc26a239/namespaces/observability/prometheus-operator/prometheus-operator.yaml#L158
I get to the redirect URL however it looks like something to do with my secret not being mounted it would appear because notice this in my URL $__file{/etc/secrets/auth_generic_oauth/client_id} where I'd expect to see the client_id value.
https://github.com/login/oauth/authorize?access_type=online&client_id=%24__file%7B%2Fetc%2Fsecrets%2Fauth_generic_oauth%2Fclient_id%7D&redirect_uri=https%3A%2F%2Fgrafana.raspbernetes.com%2Flogin%2Fgithub&response_type=code&scope=user%3Aemail+read%3Aorg&state=vQnPYTCWeoVVikFjc8I1lSO8-yO2uPn-RPAuGf2pdNY%3D

You need to update auth_generic_oauth to auth-generic-oauth-secret, because that is the name of your configured secret in the mount.

Correct me if I'm wrong however the auth_generic_oauth is just an arbitrary mountPath as long as the mount path is correct in my assignment it should be fine.
I think my issue is because I'm not running Grafana 7.1.+ as I just noticed the prometheus-operator for some reason is running 7.0.3 for some reason even though I'm using the latest version which should be 7.1.+.

The File provider is referenced in the documentation for v7.0, so maybe it's not that.
I see you are creating grafana.ini from helm, maybe helm is quoting those values, making it literals, and Grafana doesn't know it has to interpolate those. Try using $$__file instead. 🤷

Interestingly, it worked in the sense it took me to the correct oauth github project but then it redirected me to grafana and said "invalid username and password".
Here are the logs
t=2020-08-16T11:34:39+0000 lvl=info msg="Request Completed" logger=context userId=0 orgId=0 uname= method=GET path=/ status=302 remote_addr=***.***.***.*** time_ms=0 size=29 referer=
t=2020-08-16T11:34:42+0000 lvl=info msg="Request Completed" logger=context userId=0 orgId=0 uname= method=GET path=/login/github status=302 remote_addr=***.***.***.*** time_ms=0 size=304 referer=https://grafana.raspbernetes.com/login
t=2020-08-16T11:35:09+0000 lvl=info msg="state check" logger=oauth queryState=f2f9849c470a30f0c72efeaaf2c2b7238ce62619a7dca90a88d964ad90a4d946 cookieState=f2f9849c470a30f0c72efeaaf2c2b7238ce62619a7dca90a88d964ad90a4d946
t=2020-08-16T11:35:10+0000 lvl=warn msg="Not allowing oauth_github login, user not found in internal user database and allow signup = false"
t=2020-08-16T11:35:10+0000 lvl=eror msg="Invalid Username or Password" logger=context userId=0 orgId=0 uname=
t=2020-08-16T11:35:10+0000 lvl=info msg="Request Completed" logger=context userId=0 orgId=0 uname= method=GET path=/login/github status=302 remote_addr=***.***.***.*** time_ms=1796 size=29 referer=https://github.com/

Okay fixed it. I don't exactly understand why but I needed allow_sign_up: true which was alluded in the logs I sent above Not allowing oauth_github login, user not found in internal user database and allow signup = false

📢 This chart is deprecated: https://github.com/helm/charts/pull/23662
If still applicable, please re-open issues at: https://github.com/grafana/helm-charts


Migrate touch / gesture Hammer library to v2 API

Current version is 1.x
https://github.com/readium/readium-js-viewer/blob/develop/lib/thirdparty/hammer.js
Version 2.x has a new API:
http://hammerjs.github.io/changelog/
What's new in 2.0?
It's completely rewritten, with reusable gesture recognisers,
and improved support for the recent mobile browsers
by making use of the touch-action css property when possible.
Also support for multiple Hammer instances the same time,
so multi-user became possible.

Useful pointer:
http://tech.gilt.com/post/98240068394/five-things-you-need-to-know-about-hammer-js-2-0
Code to migrate:
https://github.com/readium/readium-js-viewer/blob/develop/lib/gestures.js

Swipe gestures currently disabled in ReadiumJS:
https://github.com/readium/readium-js-viewer/blob/develop/src/js/gestures.js#L18

Hi @danielweck ,
I think I've managed to add swipe handling for Hammer v2 API. I´ve made a PR at https://github.com/readium/readium-js-viewer/pull/479
It seems to be working fine. Let me know if there's something missing.


Converting html tables to Wml can create invalid documents (according to Word)

    The other headers are empty, which is a problem

    Empty td-elements work out fine, but not if they contain tags other than p or span

Converting this creates wml code that looks like this:
snip...
<w:tbl>

<w:tr>
<w:trPr></w:trPr>
<w:tc>
    <w:tcPr></w:tcPr>
    <w:p>
        <content further down>
            The other headers are empty, which is a problem
        </content further down>
    </w:p>
    </w:tc>
    <w:tc>
        <w:tcPr></w:tcPr>
    </w:tc>
    <w:tc>
        <w:tcPr></w:tcPr>
    </w:tc>
</w:tr>
<w:tr>
    <w:trPr></w:trPr>
    <w:tc>
        <w:tcPr></w:tcPr>
        <w:p>

        </w:p>
    </w:tc>
    <w:tc>
        <w:tcPr></w:tcPr>
    </w:tc>
    <w:tc>
        <w:tcPr></w:tcPr>
       <w:p>
            <content further down>
                Empty td-elements work out fine, but not if they contain tags other than p or span
            </content further down>
        </w:p>
    </w:tc>
</w:tr>
</w:tbl>
...snip

And word doesn't think the resulting wml is valid. It requires <w:p> tag to come before the closing </w:tc> or in other words: a table cell with just table cell properties is invalid, it also requires some content.
HtmlToWmlConverterCore has a special case that handles this for  without text, but that doesn't work  if they contain elements other than p or span.
I tried adding some test cases, but they pass because  according to Open-Xml-Sdk this is still valid wml. According to wml.xsd a table-cell should conform to this schema:
<xsd:complexType name="CT_Tc">
    <xsd:sequence>
        <xsd:element name="tcPr" type="CT_TcPr" minOccurs="1" maxOccurs="1"/>
        <xsd:group ref="EG_BlockLevelElts" minOccurs="1" maxOccurs="unbounded"/>
    </xsd:sequence>
</xsd:complexType>

This is what EG_BlockLevelElts looks like:
<xsd:group name="EG_BlockLevelElts">
    <xsd:choice>
        <xsd:group ref="EG_BlockLevelChunkElts" minOccurs="0" maxOccurs="unbounded"/>
    </xsd:choice>
</xsd:group>

Apparently the minOccurs="0" on EG_BlockLevelElts overrides the requirement of minOccurs="1" from CT_tc, although I don't agree with that interpretation (and neither does Word).
Still I would like to generate documents that are valid for the most common ooxml implementation by far. Currently I can work around this by changing the HTML fed into the converter, but it would be nice to have this handled for me.
I would like to implement this and submit a pull request, but I wan't to make sure that the changes would be welcome first.

I found a related issue here https://github.com/OfficeDev/Open-XML-SDK/issues/8

@ThomasBarnekow @EricWhiteDev Could this please get some attention?

Closing all issues as this repo is being archived and will no longer be maintained by Microsoft. The project is licensed for continued use and development by forking to your own repo.


encoding/json: behavior changed when decoding into []interface{}

What version of Go are you using (go version)?
I can confirm the changes is introduced by https://github.com/golang/go/commit/11b2853e6f322306a55519d03671e256b966e8ca

$ go version

go version devel +325540922a Fri Jun 5 17:27:32 2020 +0000 linux/amd64

Does this issue reproduce with the latest release?
On master
What did you do?
package main

import "encoding/json"

type A struct {
	A int
}

type B struct {
	B int
}

func main() {
	var a A
	var b B

	decode(`[{"A": 1}, {"B": 2}]`, &a, &b)

	println(a.A, b.B)
}

func decode(raw string, args ...interface{}) {
	json.Unmarshal([]byte(raw), &args)
}

What did you expect to see?
In Go 1.14 the output is 1 2
What did you see instead?
The output is 0 0
It seems like the new JSON decoder handles the element type incorrectly.
diff --git a/src/encoding/json/decode.go b/src/encoding/json/decode.go
index 5f34af44ea..b13df504e0 100644
--- a/src/encoding/json/decode.go
+++ b/src/encoding/json/decode.go
@@ -575,7 +575,15 @@ func (d *decodeState) array(v reflect.Value) error {
                        if i < initialSliceCap {
                                // Reusing an element from the slice's original
                                // backing array; zero it before decoding.
-                               into.Set(reflect.Zero(v.Type().Elem()))
+                               tp := into.Type()
+                               if tp.Kind() == reflect.Interface {
+                                       tp = into.Elem().Type()
+                               }
+                               if tp.Kind() != reflect.Ptr {
+                                       into.Set(reflect.Zero(tp))
+                               }
                        }

can output 1 2.

Thanks for reporting @bobotu.
The commit you mentioned was to fix issue #21092.
/cc @mvdan @trotha01 @ianlancetaylor @bradfitz

As far as I understand, this is working as intended, and the fix for issue #21092 is correct. The docs read:

To unmarshal a JSON array into a slice, Unmarshal resets the slice length to zero and then appends each element to the slice.

You also bring up a potential fix, along with:

It seems like the new JSON decoder handles the element type incorrectly.

Note that your element type is just interface{}, so the decoder applies the default rule which results in a map. If you add fmt.Printf("%#v\n", args) right after the unmarshal, you'll see []interface {}{map[string]interface {}{"A":1}, map[string]interface {}{"B":2}}.
Regardless of whether one would consider your initial code correct or not, I think it was never guaranteed to work given the docs. It seemed to rely on an unintended implementation detail which, as far as I can tell, did the opposite of what the docs say. If you think my understanding of the situation is incorrect, please explain why in detail.

Thanks for your reply. According to the documentation, this is indeed an undefined behavior.
So the correct way is to use josn.Decoder?
func decode(raw string, args ...interface{}) {
	dec := json.NewDecoder(strings.NewReader(raw))
	dec.Token()
	var i int
	for dec.More() {
		if i == len(args) {
			return
		}
		err := dec.Decode(args[i])
		if err != nil {
			panic(err.Error())
		}
		i++
	}
}

According to the documentation, this is indeed an undefined behavior.

I should note that it's not undefined behavior. The docs document that your original code should not work. The fact that it used to work was a bug, which we're fixing in 1.15.
I'm not sure what the correct way to do what you want to do would be; you never told us what you're trying to do, you only provided the solution. Assuming that you want to decode a list of JSON values into specific and different Go types, multiple ideas come to mind:

decoding into []json.RawValue, so you can then decode each into the appropriate type in a second pass
decoding one element at a time, like your latest sample above
decoding into a superset of the two types, like []AB

Thanks for the report @bobotu and the analysis @mvdan.

I am curious at how many people this will break. This broke some of our tests where we relied on unmarshalling merging values as opposed to completely zeroing and overwriting. Looking back at #21092, @OneOfOne indicated that they also relied on the merging behavior. @robmccoll indicated that this would not break @OneOfOne's usage because only new values appended would be zeroed and existing ones would not, but that's not true.
I agree that the docs do indicate that we were relying on broken behavior, and I'm in the process of changing my code.
I think that it's worth considering how much other code this change may break. If it's more than expected, i.e. people have come to rely on the broken behavior, it may be worth changing the documenation instead.

I think that it's worth considering how much other code this change may break. If it's more than expected, i.e. people have come to rely on the broken behavior, it may be worth changing the documentation instead.

We have done this kind of thing in the past where the documentation was ambiguous. One good example is https://github.com/golang/go/issues/39149.
However, this case is different from that one in two very important ways:

Clarity of the docs. In this case, the docs were very clear, so we are only breaking programs which were expecting exactly the opposite.
Number of programs affected. So far, two people have raised the issue here, but we don't have a good idea of how many programs would break once the final release is out. That other issue broke 50 targets/tests at Google, which is quite a lot compared to previous behavior changes and regressions in the json package, so that is a good metric. As far as I can tell, noone at Google has raised an alarm about this change, nor has anyone else been bothered enough by the change to open an issue.

Of course, we still have time. beta1 came out two weeks ago, and rc1 should be out in a couple of weeks. If more people bring up this issue, and especially if they provide proof that it will break many reasonable Go programs, we can reconsider.

Perhaps it would make sense to test this on some large projects like Kubernetes to do a bit more probing for brakage?

If large projects want to test 1.15beta1 or the upcoming 1.15rc1, that would of course be very helpful :) It has to be their initiative, though.

Copying comment from #21092:
This change has produced a small but significant number of test failures in Google's codebase. A reduced example of one case which was broken is:
type T struct {
  Index    int
  Elements []json.RawMessage
}

var message T
tmp := []interface{}{&message.Index, &message.Elements}
err = json.Unmarshal(raw[0], &tmp)
if err != nil {
  return message, err
}
return message, nil

https://play.golang.org/p/iNBD_-mhWTI
I am concerned that there may be more errors in code not covered by tests. (Failing test count: 6, or ~500, depending on whether you count one cluster of related tests as one test or not.)

Here's another relevant minified test case I've come across. This might not be exactly the same issue, but it's related to the same fix CL. It is an example of code that was directly relying on the opposite-of-what-documentation-said behavior in Go 1.14, and so it breaks in 1.15 where #21092 is fixed:
package main

import (
	"encoding/json"
	"fmt"
	"log"
)

type combo struct {
	One  one
	Many []one
}

type one struct {
	A string
	B string
}

func main() {
	b := []byte(`{
		"One":  {"A":"hello"},
		"Many":[{"B":"there"}]
	}`)

	var v combo
	if err := json.Unmarshal(b, &v); err != nil {
		log.Fatalln(err)
	}

	// Initialize many with one.
	for i := range v.Many {
		v.Many[i] = v.One
	}

	// Unmarshal again, which in 1.14 would reuse slice elements
	// when decoding (counter to encoding/json documentation).
	if err := json.Unmarshal(b, &v); err != nil {
		log.Fatalln(err)
	}

	fmt.Println(len(v.Many), v.Many[0].A, v.Many[0].B)

	// Output (Go 1.14): 1 hello there
	// Output (Go 1.15): 1  there
}

As far as I see, the original issue with the mismatch in documentation and behavior was reported in #21092. That was in July 2017. The general preference of package owners at the time was to fix it. @rsc said back then:

I agree that when appending to a slice, unmarshal should start with fresh zeroed slice elements and not the old slice elements that happen to sit between len and cap. Too late for Go 1.10 though.

The relevant CL notes:

The previous behavior directly contradicted the docs that have been in
place for years

If it's been in place for years, another option is to update documentation to match the (unintended) behavior.
We should decide what is better to do at this point. I've seen us update the documentation more often than change behavior in such cases, but I'll let people more familiar with encoding/json and these subtle trade-offs weigh in. Marking as NeedsDecision release-blocker for 1.15.
/cc @mvdan @rsc @neild

For context of our usage, we unmarshal the same data into two types, where the second type is initialized from the first. If the data was for the first type, then the second unmarshal would be a no-op. If the data is for the second type, then the first unmarshal would be a no-op. The change for 1.15 now means that the second operation is a zeroing op if the data was for the first type.
Again, for us this is a minor fix, but I'm just glad we had tests for it.

This change has produced a small but significant number of test failures in Google's codebase.

@neild can you share how that number compares to other past changes in the json library? "small but significant" doesn't really tell me if I should worry. I assume @dsnet will have an opinion here, as we had a similar discussion in https://github.com/golang/go/issues/39149.

We should decide what is better to do at this point.

The docs have always been pretty clear as far as I can tell, so I still default to leaving the change as-is. I'm happy to hear counter-arguments, though, but please try to back them up with evidence.
Another option is a compromise. In the original code, we reused existing element values within a slice's capacity. In the new code, we never reuse any element values in a slice, at all (as documented). A compromise could be to only reuse the existing element values up to a slice's length, ignoring those between its length and its capacity. This is what the original bug report was about:

unmarshal into slice reuses element data between len and cap

However, I still prefer the current behavior over this compromise. But the compromise is better than reverting the entire change, at least.

The reason this is subtle is that "don't reuse element data between len and cap when appending" sounds great, except that the rule "unmarshal into slice cuts len to 0 first" means that all unmarshalling is appending. The pattern that's now been identified both inside and outside Google is to set up a []interface{} containing multiple pointer targets and then unmarshal a json array into it. This is analogous to setting up a struct containing multiple pointer targets and unmarshaling a json object into it. In Go 1.14 these two operations worked the same. In the current Go 1.15 beta they don't.
Consider this program:
package main

import (
	"encoding/json"
	"fmt"
)

func tojs(x interface{}) string {
	js, err := json.Marshal(x)
	if err != nil {
		panic(err)
	}
	return string(js)
}

func main() {
	array := []interface{}{new(int)}
	err := json.Unmarshal([]byte(`["hi"]`), &array)
	fmt.Printf("%s, %v\n", tojs(array), err)

	object := struct{ X interface{} }{new(int)}
	err = json.Unmarshal([]byte(`{"x":"hi"}`), &object)
	fmt.Printf("%s, %v\n", tojs(object), err)
}

Same thing is going on in both the array and object case, just a different container around them.
On the playground with Go 1.14 - https://play.golang.org/p/BjJRIo4cSBP - both behave the same: they try to unmarshal "hi" into a *int and report an error. In the Go 1.15 beta, the struct case still reports an error but the array case now replaces the pre-filled *int with a string. This is a silly short example; a more important one is when you have a JSON array of different object types and prefill an []interface{} with pre-allocations of the right structs for the decoding. In that case, you'd get success in Go 1.14 but failure in the Go 1.15 beta, because the important pre-filled type information is thrown away.
I don't believe it makes sense to break this example by introducing such a big difference between unmarshal into struct and unmarshal into slice.
For Go 1.16, we might try doing what #21092 claimed to be about, namely ignoring pre-filled items beyond the len of the slice passed to unmarshal, while still respecting pre-filled items between 0 and the original len.
For Go 1.15, at this late stage, it looks to me like the best path forward is to revert the breaking change. (It's too late to try some other new semantics.)

@neild can you share how that number compares to other past changes in the json library?

More than some, less than others? As I said, there are only 6 failures, which isn't a lot in the grand scheme of things. However, I'm concerned both that the first case I looked at (https://github.com/golang/go/issues/39427#issuecomment-649844359) isn't obviously doing anything unreasonable, and that there may be more places that aren't caught by test coverage.

@mvdan @dsnet Are you in agreement with the plan suggested for 1.15 in https://github.com/golang/go/issues/39427#issuecomment-650249580?

I'm not in agreement; the pattern that Russ mentioned goes directly against the existing documentation, so I'm not sure how it's considered a breaking change to fix the code instead of rewriting the documentation.
Still, I appear to be alone in my understanding of the Go1 compatibility guarantee, and we've run out of time, so it's time to revert.


Support for MQTT 5

Are there any plans to add support for MQTT 5?

Yes, eventually.
Plan is to first separate out the packet parsing/serialising into a separate ruby gem.
This will make it easier for other MQTT client/server implementations to make use of the packet parsing.
Then plan is to add support for MQTT 5 to that.
Then finally add MQTT 5 functionality to this gem.

Good morning, commenting in order to follow this development and perhaps also help with the TLS implementation when the time comes.
Cheers

any updates about this?


SimpleDnsCrypt GUI not starting on logon

I know this maybe has been asked a trillion of times.. but why SDC can't simply start with the system? I tried creating task with task scheduler, but only got the service running instead.
Is like the GUI refuses to launch even if I'm calling the task with admin privileges, and just get the service (which forces me to manually open the app later).

Why there's no a simple button in the settings "Launch at System start" is so basic.. and this is required. We can't trust the service is running in background and I tend to check everytime. Even I saw one issue raised about to make the tray icon show the status.. the user want feedback about the app status.
Any future plans to implement this? Thank you in advance.

is this required for "DNSCrypt Service" to auto-start during log-on for user ?
or this is only for GUI to show up during every log-on for user ?

I just want to emulate a click on the app once I login in my computer (with the behavior "start hidden in tray" enabled). So just the "loading" screen of the app is shown and then the tray icon. Just that.
You can run the service standalone using net start dnscrypt-proxy, but that is not actually opening the app, that is the reason why SDC exists.

i think by design the UI is just to simplified DNScrypt use/settings thus not needed to run every login
if u use the original DNScrypt, it also run silent in background right ?
although i agree it would be nice if the UI or notification app let user know if DNScrypt run properly/have problem with connection/disabled
like internet-security style, that stay in taskbar and pop-up if it catch some issue

Simple DNSCrypt never starts on boot. Its just an UI for dnscrypt-proxy, which starts as windows service on boot.


Firebase:init error

Context
Package.json:devDependencies notice that I am using Nxtend/Firebase version 12
"devDependencies": {
    "@nrwl/cli": "13.4.3",
    "@nrwl/cypress": "^13.4.3",
    "@nrwl/jest": "^13.4.3",
    "@nrwl/js": "13.4.3",
    "@nrwl/linter": "^13.4.3",
    "@nrwl/nx-cloud": "latest",
    "@nrwl/tao": "13.4.3",
    "@nrwl/workspace": "13.4.3",
    "@nx-plus/vue": "^12.2.0",
    "@nxtend/firebase": "12.1.0",
    "@types/node": "14.14.33",
    "prettier": "^2.3.1",
    "typescript": "~4.4.3"
  }

Command
$ nx generate @nxtend/firebase:init
Result (Error)
Unable to resolve @nxtend/firebase:init.
Cannot find generator 'init' in<EMAIL_ADDRESS>

init is not necessary. You can simply add the plugin to your dev dependencies and start using it. Let me know if you have issues, otherwise I'll close this issue in a few days.

Hi @devinshoemaker
any reason for the firebase package to depend on "@nrwl/devkit" "^12.0.0"
it means the package has not being maintained/updated for v13?
Thanks for you work on this one!
I might join with some simple PRs later on :)


raidemulator: Fix issues with getCombatants and issue with NetworkAbility line parsing

Fix event 0x15 not mapping x/y/z for combatant state
Fix issues with RaidEmulatorOverlayApiHook's getCombatants override vs C# property casing
Fix RaidEmulatorOverlayApiHook's getCombatants override not having the correct timestamp offset when doing initial encounter analysis
Fix issue with suppressSeconds in RaidEmulator
Fix issue with slow PCs causing delay in playback, causing desync vs videos

So, I just ran this against my E9S Summon branch and my E9S logs:
I still see the clones in the wrong position, and the boss doesn't have a BNpcID field, which I'm assuming is expected.
Do I need to do something special here, like run the fight with Network Debugging enabled?

BNpcID isn't included in normal ACT logs, so it can't be included in raidemulator. I think that field is the actual model ID or something?
The analyzed version of the encounter is stored in the IndexedDB table, so you'll need to re-import to fix the positioning/heading issue. I would like to make the Reparse button fix this but when I tried I ran into a weird issue with it dropping some lines, so put that on the backburner for now.

BNpcID isn't included in normal ACT logs, so it can't be included in raidemulator. I think that field is the actual model ID or something?

To be clear, this means that only the line fields in the parsed ACT log are available via getCombatants?
(As for "why BNPCID?", it, and NPCBaseID, are language-agnostic and will usually be included in the network data even if the entity name is not, for certain log lines. I think panic was wondering whether that would be possible here.)

Looking at your e9s Summon PR, you're using BNpcID to determine the real one. You could instead check PosX and PosY. Round them and they should both equal 100 for the boss:
        const boss = bossData.combatants.filter((boss) => Math.round(boss.PosX) === 100 && Math.round(boss.PosY) === 100)[0];

Looking at your e9s Summon PR, you're using BNpcID to determine the real one. You could instead check PosX and PosY. Round them and they should both equal 100 for the boss:

I can settle on using the MaxHP too, since all the clones have 44, and the boss obviously has substantially more than that; BNpcID just felt the most "official"

I think panic was wondering whether that would be possible here.

It's possible more long-term as long as the logs were generated with debug network capture enabled, but actually pulling that information from the 252 lines is going to take a lot more effort. I'm not even sure if I should keep the 252 lines around in a parsed line scope, given how much that would bloat the encounter data.

@JLGarber Looking at this further, I think I'm a bit confused. Can you or someone else confirm something? There are two IDs included in 03 lines that might correspond to BNpcID, if someone can confirm which if either maps to the actual getCombatants return data, I can pull that info into raidemulator as well.

Sure, it's field 9. For a line like 03|2020-12-17T01:50:35.4890000-06:00|40006430|Fatebreaker|0|1|0|0||9707|9020|44|44|0|10000|0|0|100|91|0|-4.792213E-05||cd21237b1278fd2f77352afc9aae6e07, it would be 9707.
(An example of why it matters is something like 03|2020-12-17T01:50:35.3980000-06:00|4000641d||0|1|0|0||108|9020|44|44|0|10000|0|0|100|100|2.384186E-07|3.141593||672cb04d8d25f8a4bcc828153d528ed1, where there's no name field.)

Alright, thanks.
Looking at the fields defined in getCombatants, https://github.com/ngld/OverlayPlugin/blob/master/OverlayPlugin.Core/EventSources/MiniParseEventSource.cs#L40-L62
Comparing against the list of properties currently being tracked in https://github.com/quisquous/cactbot/blob/65e2637b97ba8e86b12e88ff8ac21c3ca60d8438/ui/raidboss/emulator/data/CombatantState.js#L27-L38
Currently the following fields aren't being tracked to emulate this call perfectly:

BNpcID, field 9 of event 03 as you stated, I'll fix this
ID, tracked elsewhere but not included in the emulated response, I'll fix this
Name, tracked elsewhere but not included in the emulated response, I'll fix this
Job, tracked elsewhere but not included in the emulated response, I'll fix this
Level, tracked elsewhere but not included in the emulated response, I'll fix this
OwnerID, maybe event 03 field 6?
CurrentWorldID, maybe event 03 field 7?
WorldID, maybe event 03 field 7?
WorldName, maybe event 03 field 8?
BNpcNameID, maybe event 03 field 9 or 10?
PartyType, not in the logs at all AFAIK, derived completely from memory data?
type, I have no clue what this is supposed to map to?

Actually, looking at it again, I think field 9 is BNPCNameID, while BNpcID is field 10. type is the line type, the 2/3-digit field  at index 0. Probably safe to ignore it. Your other assumptions look right, I think.

WorldID vs CurrentWorldID is almost definitely wrong but I'm not sure which is in the 03 event and where the other would be. It's probably safe to map them both over to event 03 field 7, with a comment that one of them isn't right? I can't envision a trigger that would use that property but I want to at least have something in place even if it's just a placeholder.
type in this case is some part of the Combatant structure in ACT, not a line event type.

I've added tracking for all of the properties mentioned before, but I'm running into one more issue, related to the way encounters are being split. Right now, raidemulator is following the logic here to determine if an encounter ends and a new one should begin:
https://github.com/quisquous/cactbot/blob/65e2637b97ba8e86b12e88ff8ac21c3ca60d8438/ui/raidboss/emulator/data/LogEventHandler.js#L41-L64
The problem is the wipeRegex which checks against NetRegexes.network6d({ command: '40000010' }) which is the Fade in command. This command occurs after all of the non-boss actors are added via 03 events, which means that those log lines aren't included in the encounter (they end up in the previous encounter).
The Log Guide mentions changing to Fade out (40000005) but that command doesn't line up well either. Instead I'm seeing a 8000000D command which seems to be at the exact correct position in the logs for where I'd like to split them, but doesn't seem to be documented as to what this command is.
I'd like to switch to the 8000000D command, since that seems to line up correctly, but I'm pretty sure that's not going to work for older content. So I'd have to, I guess, somehow check if the encounter's first line is a 8000000D command, and then skip the 40000010 command?
The other piece of relevant code is this line, which is doing some sorting. This is to work around log lines being out-of-order according to their timestamp, so the other option is to remove this line but that's going to cause all sorts of other issues with the getCombatant-related stuff since data might not be accurate to what it would be in-game.
https://github.com/quisquous/cactbot/blob/65e2637b97ba8e86b12e88ff8ac21c3ca60d8438/ui/raidboss/emulator/data/NetworkLogConverter.js#L30

Re: splitting.  What's wrong with the fade out network message? That should be before all of the new combatants get added again.
Re: sorting.  I don't think you should re-sort log lines.  My understanding is that ignoring timestamp, the order of logs in the network log file are the order that cactbot sees them in.  The lines that don't have timestamps or appear out of order are ones that come from the in game log, and always end in .000.  Are there other lines that are out of order?  What problems are you addressing by sorting?

The reason for sorting is for the combatant tracker portion. I added the sorting to fix the HP/MP bars bouncing up and down randomly originally, but I think that also got fixed by another change to the way I'm updating the combatant state (basically discarding state updates if they're out of order).

Re: sorting.  I guess I'm just really surprised this is happening.  Can you give some examples?

Re: sorting. I guess I'm just really surprised this is happening. Can you give some examples?

Well it's a bit late at this point, but the readme for emulator specifically calls this out and I completely forgot about it:

Lines are sorted based on timestamp and then index, to account for chat lines (00) being out of order from network lines

I guess this could be accounted for by not using the timestamp from 00 lines for anything, but that might complicate other things.

The sorting and everything else should be addressed for this PR now.
There's one more outstanding issue I noticed recently that I'd like to address for this PR, which is that the timeline display seems to be desync'd for e12s. I'm looking into that now.

This line specifically is causing the problem:
https://github.com/quisquous/cactbot/blob/1bb55da59b2c0dd5c32920bb5c7a812a7a80e608/ui/raidboss/timeline.js#L407
I can work around it to fix sync when seeking/changing perspectives, which partially fixes the issue, but it's still going to cause problems when seeking on fights with a jump in the timeline.
Realistically, the only way to fully address the issue is to modify it to something like:
const newTimebase = this.getTimeBaseForOffset(fightNow);

So that it can be overridden by raidemulator to use the log line's timestamp in replacement of new Date.

Lines are sorted based on timestamp and then index, to account for chat lines (00) being out of order from network lines

I guess this could be accounted for by not using the timestamp from 00 lines for anything, but that might complicate other things.

Yeah, I think this this is the correct way to handle it.  The lines themselves are not misordered, but the times appear in the past because the 00 lines have 000 milliseconds always.  I treat those lines when analyzing log files as having an invalid time and using the time of any previous log line.

I excluded the 00 lines from combatant state tracking and removed sorting in the previous commit, everything's parsing and running as expected with no jittering or anything, so that's fine.
The outstanding issue for this PR from my side I detailed in this comment (https://github.com/quisquous/cactbot/pull/2235#issuecomment-775399889). Given that this is an issue with the current version in main, and given that it requires changing non-emulator code, it should probably be done as a separate PR.

I have reverted the Suppress fixes as implied in the previous conversation. Once this PR is merged, I'll start a new PR with the fix for that (with accompanying PopupText changes).
@quisquous I believe that was the only thing outstanding for this PR?


Test/Code coverage

I mainly just want the badge w/ the number.
There's https://github.com/JuliaCI/Coverage.jl
How do other pkg's do it?
which have it.. julia itself yes.
ah, dataframes
https://github.com/JuliaData/DataFrames.jl/blob/main/.github/workflows/ci.yml
https://codecov.io/gh/JuliaData/DataFrames.jl/tree/master/src
https://docs.julialang.org/en/v1/stdlib/Test/ (nothing there)

docs.julialang.org/en/v1/stdlib/Test (nothing there)

yes but, ] ?test does have a --coverage flag (I knew I'd seen sth)

That flag produces a bunch of .cov files..
e.g. depgraph.jl.33204.cov (next to src/internals.depgraph.jl)
        - """
        -     depgraph(pkgname)
        -
⋮
        - """
        9 depgraph(pkgname) = begin
        9     rootpkg = string(pkgname)
        9     packages = packages_in_active_manifest()
        9     if rootpkg ∉ keys(packages)
        1         error("""
        -         The given package ($pkgname) must be installed in the active project
        -         (which is currently `$(active_project())`)""")
        -     end
        8     deps = Vector{Pair{String, String}}()
       42     add_deps_of(name) = begin
       34         pkg_info = only(packages[name])  # Two packages with same name not supported.
       34         direct_deps = get(pkg_info, "deps", [])
       34         for dep in direct_deps
       26             push!(deps, name => dep)
       26             add_deps_of(dep)
       26         end
        -     end
        8     add_deps_of(rootpkg)
        8     return unique!(deps)  # Could use a SortedSet instead; but this spares a pkg load.
        - end
…

guess that's no. of times line is hit

btw, it's a cmd-line flag for julia itself: julia --code-coverage, https://docs.julialang.org/en/v1/manual/command-line-options/
(found via https://github.com/tfiers/PkgGraphs.jl/actions/runs/3800070568/jobs/6463193393#step:6:43)

Ah, PkgTemplates has a flag for it (that I manually set false).
Template(plugins = [GitHubActions(coverage = true, …)])


Validations

Hello, first of all thanks for this plugin, it is excellent. But I think it should have some way to at least validate if it's empty or not, or a validator like TextFormField does. Thanks greetings.

HI, @lrferreiro, and thanks for the feedback.
you could use controller.contentIsEmpty or controller.content.isEmpty etc. Just keep in mind that an empty paragraph HTML (i.e.

) is not an empty string.
Validator is a great idea to add.
Thanks.


basics:event_looper_unittest FAIL

in travis
FAIL: (05-07 23:36:21.498) //heron/common/tests/python/basics:event_looper_unittest (see /home/travis/.cache/bazel/_bazel_travis/030a6cc9b27b34f2fe0e137b942f59bf/execroot/heron/bazel-out/local_linux-fastbuild/testlogs/heron/common/tests/python/basics/event_looper_unittest/test.log)
____(05-07 23:36:21.505) From Testing //heron/common/tests/python/basics:event_looper_unittest:
==================== Test output for //heron/common/tests/python/basics:event_looper_unittest:
============================= test session starts ==============================
platform linux2 -- Python 2.7.3 -- py-1.4.27 -- pytest-2.6.4
collected 8 items
../../../../../../../../../../heron/common/tests/python/basics/event_looper_unittest.py .....F..
=================================== FAILURES ===================================
___________________ EventLooperTest.test_register_timer_task ___________________
self = <basics.event_looper_unittest.EventLooperTest testMethod=test_register_timer_task>
    def test_register_timer_task(self):
      def to_run():
        self.looper.exit_loop()
        self.global_value = 10

      start_time = time.time()
      interval = 1
      self.looper.register_timer_task_in_sec(to_run, interval)
      self.looper.loop()
      end_time = time.time()
>     self.assertAlmostEqual(start_time + interval, end_time, delta=0.01)
E     AssertionError:<PHONE_NUMBER>.415113 !=<PHONE_NUMBER>.42737 within 0.01 delta
../../../../../../../../../../heron/common/tests/python/basics/event_looper_unittest.py:60: AssertionError
====================== 1 failed, 7 passed in 2.10 seconds ======================
================================================================================

So far:

No one is using heron-python for prod
The heron-prod does not meet the production level of reliability and stablity.

I would sugguest we can turn off thoese heron-python unit tests or mark them flaky for now, if it hurts normal travis building. Also, we would ask people to take their own risks for using heron-python.

@huijunw You can just change 0.01 to 0.03. I did this for Python test for before.


integrate a simple retry for an GET request, when the icinga2 Backend…

…node not available.
should be fix https://github.com/Icinga/dashing-icinga2/issues/9 and is an small backport from https://github.com/bodsch/ruby-icinga2/issues/6

Thanks 👍 I have partially refactored your code in a new PR.
This includes more cleanup:

only one function to do connection handling and data parsing
only one place for connection errors (your patch)
a global attribute initializer function just called once
nil data handler checks (your patch)


repeatable level error

im on cloudrip brawl level 3 i just wrote a code that said that it was a success then when i submited it the coins changed direction and the enemies changed too i dont know why it did that but it did

Working as intended. Most levels after a certain point add randomness to the layout. When you are running your code whilte writing it, it's just an example layout. When you are ready to submit for real, then a new random layout is created.

then wouldnt it be right if you submit your code into the level then the level stay the same until after the code is finished computing?

Your code has to be able to deal with unknown randomness, otherwise it would be too easy to customize your code to the exact pattern of spawns that you are testing against.