[MPQEditor] Introduce 'Show graph'

This draft introduces the ability to edit specific layers in circle-view.
'Show graph` synchronization test:
https://user-images.githubusercontent.com/112689352/233072896-f51418be-6a91-4fb0-b350-9162bf4c0a29.mp4
'Add/Remove' synchronization test:
https://user-images.githubusercontent.com/112689352/233073477-f41f0d4c-f0e2-4162-b521-466db6564a71.mp4
'Add' with changed defaults test:
https://user-images.githubusercontent.com/112689352/233074181-ce93c481-8552-45bc-9692-9ceef7b208d9.mp4
Full draft: #1511
ONE-vscode-DCO-1.0-Signed-off-by: s.malakhov<EMAIL_ADDRESS>

Seems like all PR's were merged and we can close this one.


Release v0.15.7

[Feature] Add coverage task to mocha target, use it for the default task

Codecov Report

Merging #61 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #61   +/-   ##
=======================================
  Coverage   67.56%   67.56%
=======================================
  Files          37       37
  Lines         891      891
  Branches       90       90
=======================================
  Hits          602      602
  Misses        226      226
  Partials       63       63

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e49e9e7...e9341b5. Read the comment docs.


🐛 Bug Report: Prompts and responses are only captured for OpenAI models

Which component is this bug for?
Langchain Instrumentation
📜 Description
When using the ChatOpenAI class, tracing and capturing prompts and responses works just fine. Other classes, e.g. HuggingFaceTextGenInference or Llama2Chat, emit traces, but do not capture the prompts and responses.
👟 Reproduction steps
Replace the ChatOpenAI class in the code example with HuggingFaceTextGenInference.
👍 Expected behavior
Prompts and responses should be traced for non-OpenAI models.
👎 Actual Behavior with Screenshots

🤖 Python Version
No response
📃 Provide any additional context for the Bug.
No response
👀 Have you spent some time to check if this bug has been raised before?

[X] I checked and didn't find similar issue

Are you willing to submit PR?
Yes I am willing to submit a PR!

Hey @Simon-Stone thanks! The SDK assumes you use a standard library to make the API calls (like OpenAI's, Anthropic, Cohere, etc.). Which library are you using in this case?

I would think so. I tried to explicitly add the invoke method to the wrapped methods, but it made no difference:
from opentelemetry.instrumentation.langchain import (
    WRAPPED_METHODS,
    LangchainInstrumentor,
)
from opentelemetry.instrumentation.langchain.task_wrapper import task_wrapper

WRAPPED_METHODS.append(
    {
        "package": "langchain_community.llms.huggingface_text_gen_inference",
        "object": "HuggingFaceTextGenInference",
        "method": "invoke",
        "wrapper": task_wrapper,
    }
)

Interesting. I have a guess that because it's in a different package, we'll need to add that package to _instruments. I'll look into this in depth later.

@Simon-Stone managed to resolve this!

Outstanding! Seems to work like a charm. Thank you so much for the swift and thorough fix, @nirga !


builder added quotes in fieldNames

insert := Db.From("log").Insert(goqu.Record{
	"code" : "10",
	"data" : "connection ok",
})

return error:

Error 1064: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '"log" ("code", "data") VALUES ('10', 'connection ok')' at line 1

mysql needed (code, data) VALUES ('10', 'connection ok'); but not ("code", "data")

Db = goqu.New("mysql", mysqldb)
insert := Db.From("log").Insert(goqu.Record{"code": 10, "data":"data1"})
if _, err := insert.Exec(); err != nil{
fmt.Println(err.Error())
return
}
Error 1064: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '"log" ("code", "data") VALUES (10, 'data1')' at line 1

???

@chaevnicher do you get the error if you use a struct for your insert like in https://github.com/doug-martin/goqu/blob/master/adapters/mysql/mysql_test.go#L226?

I dont use structure like in example.

The error is: table and field names are quoted in builded query, mysql doesnt like it, query sould be something line this:
INSERT INTO log (code, data) VALUES ('10', 'connection ok')

See #44, the mysql adapter may not be registered correctly


Feat/security fix prep

updating files to support the latest security changes and generic branding

This was a test PR


Pokejobs

These changes add a Poké Jobs farming bot for Sword and Shield.

I think I got rid of tabs and UTF-8 characters.


coronavirus-statistics to 0.5.0

RE-CHECK!

Automated adapter checker
ioBroker.coronavirus-statistics

:thumbsup: No errors found
Add comment "RE-CHECK!" to start check anew


expose Media#ffprobe_stderr

this is a nice value for a consumer to log if there ends up being a
problem with the Media

🦗 guess nobody agrees 🦗


How to use HawkTracer without an OS

I would like to use HawkTracer without an operating system, so without any threads. I am targeting an ARM Cortex-M7 microcontroller. At the moment, there is always some way of threading necessary. It would be great if it was possible to configure some build configuration variable like "HT_NO_THREADING" or similar to remove all threading related parts from the library.

@andreasbuhr thank you for the request. I considered this feature a while ago, but due to lack of time and no real usecase I decided to postpone it. I'll put some priority on that feature and try work on that in the upcoming weeks, will keep you updated here.
Just for you to know, I'm going to only disable threading optionally, but HawkTracer will still require libc to build. Dropping libc dependency is a bit of extra work, and I'm not sure if that's really needed for your usecase - if it is, please let me know, we can consider that as well for the future (but I'd keep this issue just for no-thread option).
Btw I recently found my ATmega so I think I'll be able to actually test the feature on real device :)

That's great to hear, thank you so much. Would be great to see HawkTracer running on an ATmega. Let me know if I can be of any help.

@andreasbuhr I've pushed changes to mkolny/optional-threads branch. To configure the project, run:
$ cmake -DENABLE_THREADS=OFF -DENABLE_TCP_LISTENER=OFF <build dir>

Optionally you can disable client (-DENABLE_CLIENT=OFF) and tests (-DENABLE_TESTS=OFF) as I assume you build it with your custom toolchain (-DCMAKE_TOOLCHAIN_FILE).
If you use amalgamated file (hawktracer.c or hawktracer.cpp) you need make sure the HT_ENABLE_THREADS and HT_USE_PTHREADS is NOT defined in ht_config.h file.
For AVR, I also had to provide custom monotonic clock implementation. In that case, you define HT_MONOTONIC_CLOCK_IMPL_CUSTOM and implement HT_TimestampNs ht_monotonic_clock_get_timestamp(void) function somewhere in your code.
The whole threading thing is not documented yet, however, I think it's in a good shape for testing - I'd be very grateful if you could checkout the branch and try to compile it with your project.
Many thanks!

Hi Marcin, wow, that's great! Thank you so much. I just tried compiling the code in https://ide.mbed.com, there are a few issues remaining. If you want me to I could have a look at these next weekend.
The errors I encountered (line numbers might be slightly off)
Error: Identifier "SIZE_MAX" is undefined in "hawktracer.cpp", Line: 1782, Col: 68
Error: Identifier "INT32_MAX" is undefined in "hawktracer.cpp", Line: 3269, Col: 42
Error: Thread-local variable cannot be dynamically initialized in "main.cpp", Line: 32, Col: 10
The third error has to do with the definition of  HT_THREAD_LOCAL. Defining it as empty fixes the problem.

@andreasbuhr Thank you for testing it. The first two issues are general problems, not related to threading itself - we've missed including a stdint.h file where those two macros are defined (and it's OK to include them, as they're part of c99 standard which is the minimum HawkTracer requirement).
The HT_THREAD_LOCAL one was my miss when implementing the support for optional threading - it's definitely not needed to have the macro defined, so I define it to empty if threading is disabled. I pushed all the changes to the same branch, so I'd be grateful if you could test it one more time (I've tested it as well on mbed, but it passed the compilation even without any changes - I guess it depends on the library/platform you choose for compilation?).

Hi, thanks for your work. I tested it again and the errors about SIZE_MAX not being defined persist. Including stdint.h or cstdint does not help. I think it is a problem with the ide.mbed.com toolchain. I opened a thread in their forum to ask for help:
https://forums.mbed.com/t/size-max-not-defined-when-using-online-compiler/8173
I'll keep this issue here updated.

Thanks for the update. Looks like the thread is silent for now - if you don't get any response within a week, I think we could also workaround it in HawkTracer (I don't think SIZE_MAX is actually needed, and INT32_MAX can easily be defined as it's platform-independent constant).

I didn't see any response on the mbed thread, so I've predefined the problematic constants in HawkTracer. @andreasbuhr could you please test the branch one more time with the recent changes?
Many thanks!

Great, thanks a lot for your effort.
It works now.
What I did:
I configured with
cmake -DENABLE_THREADS=OFF -DENABLE_TCP_LISTENER=OFF -DENABLE_CLIENT=OFF -DENABLE_TESTS=OFF
then copied the amalgamated h/cpp files to the project, uncommented #define HT_MONOTONIC_CLOCK_IMPL_CUSTOM in ht_config.h.
Then I implemented ht_monotonic_clock_get_timestamp.
Great!

The change has been merged. Thank you @andreasbuhr for help with testing! Feel free to re-open the issue or open a new one if you experience any problems with that feature.


DPL-805 Display serial number on run show page for revio plates

User story
As a user (Craig) I would like the serial number to be displayed on the run show page for revio plates. The serial number is a subsection of the sequencing plate barcode. See attached images.
The scanned barcode for the Revio sequencing plate is 28 characters:
e.g.
1021188000301570037320231019
The serial number is characters 16 to 20:
e.g.
1021188000301570037320231019
Who are the primary contacts for this story
Craig C
Who is the nominated tester for UAT
Craig C
Acceptance criteria
To be considered successful the solution must allow:

[x] when i edit or create a sequencing run for revio the serial number should be displayed

Additional context

@BenTopping I have moved this to Triage to prioritise in the next meeting.

Deployment
To UAT:
ansible-playbook -vD deploy_traction_ui.yml -i environments/uat -e "github_branch=v7.0.0-5522014790-develop"


Update CouchDB restoration guide

This includes all findings discovered during today's test.

LGTM

This includes all findings

Well, Alfredo has a few changes but they're in a different section. Thanks for taking care of this Sergey!

LGTM

LGTM


update, rename Github into GithubOptions & add BuildOptions API requests resolves #129

Resolves #129

Repasser buildOption en buildOptions


Create UNO game for PS

uses the room-game API
should pass Travis (I swear I tested 3 times http://prntscr.com/ea22as)
uses Fisher-Yates shuffle for the cards
cards display will keep same dimensions and fit to most screen sizes.
(sample display of card selection screen http://prntscr.com/ea2114)

(fixed the main things talked about from one year ago in https://github.com/Zarel/Pokemon-Showdown/pull/2374)

Sidenote: uthml is not supported in battles, and from a quick peek, I don't see a check preventing the commands from being used in battles, unless I'm mistaken?

Also, screen caps of UI?

I'll put these changes in tonight, as well as fixing a very big mistake i accidentally made - allowing players to join after the game has started :(

Battles are already roomgames; anything that is also a roomgame is automatically blocked from existing in battles.

changed things to template strings
removed center tags and replaced with HTML5 compatible stuff text-align: center;
removed font tags and with span style="color: #......"
fixed joining after the game has started
removed the "abusive" spread operators in createDeck() and replaced them with Slayer's Zarel's suggestions (sorry for double commit, I didn't notice the extra comments below it)
fixed the map syntax with parentheses

used Array#find for checking if the card exists.
split the html for hand display into several lines (had to use + to join the strings since template strings allow newlines just by pressing enter) - Do we have to do it using client-side css?  I'm pretty sure that hangman and other chat plugins just list the styling stuff in the HTML as well.
used a simpler sort this.hand.sort((a, b) => (a.colour > b.colour) || (a.colour === b.colour && a.value > b.value))  Sorry Slayer, your method doesn't seem to work since it mixes between sorting by colour and value.
limited timer to max 300 seconds (5 minutes)... PS users already complain that 150 seconds for battles is already too much...

Here's another screenshot:

@sparkychildcharlie , maybe you wrote > in your comparison function rather than -.
I'm fairly sure my method ought to work.... I also tested it :|

when i tried a.colour ("Green") - b.colour ("Blue") = null

So you were comparing strings with > Sigh...
Then try this: ``.sort((a, b) => a.colour.localeCompare(b.colour) || (a.value - b.value))

Ah i see how that works... thanks for the tip about the localeCompare! I didn't know that existed before... it's amazing :3
(I used that for the value comparison as well, since the values are all strings to allow stuff like +2, Reverse, and Wild)

How does this look in dark mode?

Dark mode viewing (uses plain default CSS from main server) - it looks good imo

What about the black Wild card?
On Sun, Feb 19, 2017 at 8:39 AM, Charlie Kobayashi<EMAIL_ADDRESS>
wrote:

Dark mode viewing (uses plain default CSS from main server) - it looks
good imo
[image: dark mode]
https://camo.githubusercontent.com/b8c5c67767c37d9f0d92d2ddb7a56ec4aad98359/687474703a2f2f696d6167652e70726e747363722e636f6d2f696d6167652f66373430646330343634383634616262383031646130323362333264333736332e706e67
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/Zarel/Pokemon-Showdown/pull/3241#issuecomment-280923178,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AULj4K62t8YtOIBkRSJ16K0lE-eOQvXPks5reFQMgaJpZM4MEro1
.

That UI actually looks pretty good 👍

Dark mode wild cards

The yellow cards look very weird. Possibly too saturated.
This design is okay, but I'm not a huge fan...

I could probably work out some CSS if you'd like to make it more aesthetically pleasing

Display changes:

done to Zarel's request/suggestions!
hides the UNO button automatically the turn after

Drawing:

refactored regular drawing of a card to be an "event" of its own (onDraw)
prevents users from drawing a card after playing a colour card (drawing can only happen in during the "play" state now)
only drawing on your own turn will show you your hand display (you can still view your hand any time using /uno or /uno hand)

UNO handling:

handles uno parsing if the next player draws, refactored into it's own function as well (since it occurs at both the draw and the playing part)
for 2p games, if the user does not say uno before playing their last card (Skip => [last card]), they can draw/play without having to say UNO and be penalized 2 cards (in official rules, iirc you have to beat the next player's actions, and not your own)

(bump)
It's been updated ~7 days ago; currently waiting for further comments or for Zarel to push the big green button :3

Bump~!
@Zarel -senpai! It's ready to be evaluated and potentially added too :3

@Slayer95?

Just one thing... Can I haz gradientz plz?

What do you mean? I'm assuming you're referring to a change to the colours in the display through CSS, but I'm not exactly too sure what you'd want to see.

gradients to cards for Slayer-senpai

use the button class for cards

make pass/draw buttons less hard

put in Zarel-senpai's recommendations for text shadows

display updated cards after playing anything

@Zarel it's... updated! :3

The most recent screenshot you've shown me is

Which I still told you to unbalance the text shadow...
[3/7/17, 8:51:37 AM] Zarel: so, something like
[3/7/17, 8:51:52 AM] Zarel: 1px 1px, -1px 1px, -1px -1px, 3px -3px
[3/7/17, 8:52:00 AM] Zarel: all 0 fuzziness and black

Also, I don't think a radial gradient is the best idea; I'd personally prefer something like a top-down gradient.

oopsie! I thought you accidentally left that out this is top down now

That is way too much offset. Apparently you have it zoomed in a lot. Try 2px -2px.

At that zoom level, it looks like 4x might not be enough.
In which case:
1px 0px, -1px 0px, 0px -1px, 0px 1px, 3px -3px

Done.  The last one was at 90% zoom on a 13-inch laptop

Nah, those are fine as-is. Just give another screenshot.

I think that text shadow is a bit much

yeah, UNO cards don't have that much shadow IIRC

@Zarel - I assume you're probably waiting for the screenshot :D

I think this looks pretty good, but what happened to the gradient?

I believe it's still there.  The colour is slightly lighter on the bottom.  Just a touch and not too much to make it seem awkward

Oh, that's very subtle. I can see it in the green now but the others have basically no contrast. Yeah, you might want to tune it up a bit.

The yellow gradient is hard to notice. Maybe it should be darker on top? Maybe look at official Uno cards for inspiration; their yellow cards definitely don't look so whitish.

Changed the colours to use more of 2 colours as opposed to simply transparency. The yellow card starts at a slightly more orange hue before going down to a "pure" yellow at the bottom.

Actually looks pretty good, although the yellow card might be too orangey.

@Zarel

Making it only use Yellow (and yellow mixed with black for the darker hue).  There isnt much differnece otherwise it wouldn't appear to be yellow anymore

I think that looks pretty good.

I'd say less orangey and not no orange at all; this gradient is no longer even noticeable... :/

Also your blue tints purple for some reason...

That's weird, the blue is rgb(0,0,255) which should be max blue and nothing else

@Zarel - is this ok?  The gradients are noticeable much more easily for the yellows the the blues are more "luminous" and "blue"

I mean, it's good enough at this point. I'd probably want to tweak the colors myself, but we can do that after merge. Does anyone not want to merge this?

looks fine

bump @Zarel

...I keep accidentally clicking rebase-merge instead of squash-merge... :/


Latest Xcode: "A newer Command Line Tools release is available"

When I'm running brew doctor I get the following warning:
Warning: A newer Command Line Tools release is available.
Update them from Software Update in the App Store.

However, I have the latest Xcode installed: Version 9.2 (9C40b). I also have it selected using xcode-select tool (or the Xcode GUI, same thing).
brew is fully up to date.
I'm using OSX 10.13.2 (17C88)
Brew Config
~ » brew config
HOMEBREW_VERSION: 1.4.0
ORIGIN: https://github.com/Homebrew/brew
HEAD: f42d8acde3907b90ea32cef01445744288984a4c
Last commit: 62 minutes ago
Core tap ORIGIN: https://github.com/Homebrew/homebrew-core
Core tap HEAD: dbceaf77dcc7c2552d58c7773a891ef7ea7eaf33
Core tap last commit: 2 hours ago
HOMEBREW_PREFIX: /usr/local
CPU: octa-core 64-bit skylake
Homebrew Ruby: 2.3.3 => /usr/local/Homebrew/Library/Homebrew/vendor/portable-ruby/2.3.3/bin/ruby
Clang: 9.0 build 900
Git: 2.14.3 => /Applications/Xcode.app/Contents/Developer/usr/bin/git
Curl: 7.54.0 => /usr/bin/curl
Perl: /usr/local/bin/perl => /usr/local/Cellar/perl/5.26.1/bin/perl
Python: /usr/local/opt/python/libexec/bin/python => /usr/local/Cellar/python/2.7.14/Frameworks/Python.framework/Versions/2.7/bin/python2.7
Ruby: /Users/zesty/.rbenv/shims/ruby => /Users/zesty/.rbenv/versions/2.4.2/bin/ruby
Java: N/A
macOS: 10.13.2-x86_64
Xcode: 9.2
CLT: <IP_ADDRESS>.1.1508540944
X11: N/A

Brew Doctor
~ » brew doctor
Please note that these warnings are just used to help the Homebrew maintainers
with debugging if you file an issue. If everything you use Homebrew for is
working fine: please don't worry or file an issue; just ignore this. Thanks!

Warning: A newer Command Line Tools release is available.
Update them from Software Update in the App Store.

Warning: "config" scripts exist outside your system or Homebrew directories.
`./configure` scripts often look for *-config scripts to determine if
software packages are installed, and what additional flags to use when
compiling and linking.

Having additional scripts in your path can confuse software installed via
Homebrew if the config script overrides a system or Homebrew provided
script of the same name. We found the following "config" scripts:
  /Applications/Postgres.app/Contents/Versions/latest/bin/gdal-config

I'm seeing the same problem on my sierra and high sierra machines that have CLT <IP_ADDRESS>.1.1508540944 but no Xcode installed. I've looked for updates in the app store, but it doesn't show any updates for the CLT.

Potential temporary fix in #3562 until a new CLT version is available from the App Store.

This is a duplicate of #3555

If everything you use Homebrew for is working fine: please don't worry or file an issue; just ignore this.

Please, please read these messages.


added new object type and fact bindings

support classification of different tools (ransomware, miner, etc.)

wrong repo (deprecated)


CAMEL-9043 Fix camel-example-cxf-osgi/blueprint examples

@davsclaus Thanks for pointing out that an easier solution exists. Adjusted.


Repair Ship Notification

I'm a grammar Nazi. It says something like !-19 is out of their repair docks.
Change 'their' to 'her' only one girl comes out of the dock and also all the ships are girls. :V
Also change docks to dock since you only use on dock per ship .:V

lol thanks for noticing this, the actual text was:
" is out of ther repair docks!"
I'm prone to typo, so thanks~


Add Version command

This gets the version of Fly using fly --version, meaning we can use it instead of bleeding knowledge of Lino when we ensure fly is available.
Had to mess around a bit, exploiting the fact do_after is the return value of the execute function. Not sure if this is how it should be done.
Happy to change it.

We do the same thing for ruby_terraform here: https://github.com/tobyclemson/ruby_terraform/blob/master/lib/ruby_terraform/commands/output.rb


Taxes not updated reactively - need GraphQL subscription

Type: major
Describe the bug
When changing the quantity of the items or shipping address, the tax calculated is not updated reactively, the page has to be refreshed to get the taxes.
To Reproduce
Steps to reproduce the behavior:

Go to Admin, enable "Example tax service"
Create a new product.
Add it to the cart, go to the checkout page, see that taxes are caclulated.
Change the quantity of the item. See that taxes are not updated.
Refresh the page, see that taxes are now updated.

Expected behavior
The taxes should be updated reactively.

@aldeed @kieckhafer Testing checkout today it appears that this is still not working. Is there any status update on this?

@kkuzemka @kieckhafer do either of you know if/who picked this up?

@zenweasel is this not working for you here in this repo? or in another location? It is (or at least was) fixed in a non-subscription manner, and this was left open to deal with subscriptions in the future.

I included reproduction steps in the slack message as it includes non-public URL's

The previous "solution" was based on re-finding the doc that is returned from a mutation after events are emitted and awaited. I think we only did this in one mutation, so I would look specifically into which mutations are getting called to update the cart. Maybe other mutations need the same kind of change.
But without subs, we’re only buying time. Subs are the correct solution but ideally we should figure out a better pubsub provider first (which logically would be Kafka since we already require it now).
A middle-ground workaround for now would be to set pollInterval={10} on the Query components where this is an issue (10-second polling). API will be hit a lot of unnecessary times, but it will get the job done.
Or similarly, we could add some code in the UI that does a single re-fetch 5 seconds after each cart mutation.

@rosshadden can we close this now? Or do we need to merge/migrate your changes into this repo?

Has there been any further work to actually use subscriptions beside the <SubscriptionTest /> component? @aldeed Why would Kafka be necessary for this? What would be the caveats when using GraphQL subscriptions directly with Node + MongoDB, where would Kafka come into play and what would it solve?
I'd really be interested to gain more insights into your current roadmap.

@rosshadden  Second call to close or update this ticket. It's been 3 weeks since the last update

My changes were not in this project. I can try porting them over here, but would need the find time to test it.

@janus-reith On the server side, it is hard coded to use an apollo-server PubSub instance: https://github.com/reactioncommerce/reaction/blob/develop/imports/node-app/core/ReactionNodeApp.js#L36-L39
But Apollo folks do not recommend using it for production. I'm not sure it will work correctly for installations running multiple instances of the server. Using Kafka would solve this, or at a bare minimum it should be possible for a plugin to override the pub sub provider.

Thank you, now I get it.


ci: Distribute compiled binary files via GitHub release

If you install locally, I basically recommend using cargo install, but given that one of cargo-hack's main purposes is to use it in CI, it makes sense to distribute the compiled binary files.

To install latest release:
# get latest release and host toolchain
version=$(curl -LsSf https://api.github.com/repos/taiki-e/cargo-hack/releases/latest | jq -r '.name')
host=$(rustc -Vv | grep host | sed 's/host: //')

# linux/macos
curl -LsSf https://github.com/taiki-e/cargo-hack/releases/download/v${version}/cargo-hack-v${version}-${host}.tar.gz | tar xzf -

# windows
curl -LsSf https://github.com/taiki-e/cargo-hack/releases/download/v${version}/cargo-hack-v${version}-${host}.zip -o cargo-hack.zip
7z x cargo-hack.zip

bors r+

I will say, we think alike. I've been contemplating whether to file a PR for a couple days for this exact thing 😁

For those (like myself) looking for a single script to download it, I just added some conditionals to the above.
version=$(curl -LsSf https://api.github.com/repos/taiki-e/cargo-hack/releases/latest | jq -r '.name')
host=$(rustc -Vv | grep host | sed 's/host: //')

if [ $host = 'x86_64-pc-windows-msvc' ]; then
    curl -LsSf https://github.com/taiki-e/cargo-hack/releases/download/v${version}/cargo-hack-v${version}-${host}.zip -o cargo-hack.zip
    7z x cargo-hack.zip
elif [ $host = 'x86_64-apple-darwin' ] || [ $host = 'x86_64-unknown-linux-gnu' ]; then
    curl -LsSf https://github.com/taiki-e/cargo-hack/releases/download/v${version}/cargo-hack-v${version}-${host}.tar.gz | tar xzf -
else
    echo "unsupported operating system"
    exit 1
fi

Use freely, of course.

@jhpratt Thanks, that script is really useful:)

FWIW,  if don't care about the exact name of the toolchain (usually there is no problem), using [[ ... ]] instead of [] makes it a bit simpler:
- if [ $host = 'x86_64-pc-windows-msvc' ]; then
+ if [[ $host =~ windows ]]; then
      curl -LsSf https://github.com/taiki-e/cargo-hack/releases/download/v${version}/cargo-hack-v${version}-${host}.zip -o cargo-hack.zip
      7z x cargo-hack.zip
- elif [ $host = 'x86_64-apple-darwin' ] || [ $host = 'x86_64-unknown-linux-gnu' ]; then
+ elif [[ $host =~ darwin|linux ]]; then

That would definitely make things simpler.
I'm currently looking into how I can still add cargo-hack to $PATH for GitHub Actions. For obvious reasons I'd prefer to avoid adding the current directory to the path. I'm honestly not too familiar with what the idiomatic thing to do is if you have any suggestions?

And completely unrelated to my previous comment, it might be worth stripping the binary before bundling it up. In my experience this typically reduces binary size by about two thirds.

I'm currently looking into how I can still add cargo-hack to $PATH for GitHub Actions. For obvious reasons I'd prefer to avoid adding the current directory to the path. I'm honestly not too familiar with what the idiomatic thing to do is if you have any suggestions?

I don't know if that's the idiomatic way, but I think creating a new directory and adding that directory to $PATH is an easy way. Something like the following:
mkdir ci-bin
mv cargo-hack ci-bin/
echo "$(pwd)/ci-bin" >> "${GITHUB_PATH}"

it might be worth stripping the binary before bundling it up. In my experience this typically reduces binary size by about two thirds.

I think that's definitely a good idea, I'll try that.

I've no idea if you're familiar with the way the PATH env var works in Windows, but I certainly don't. Just reporting that doing the following fails on CI (I use Linux personally, and my household doesn't have any Windows machines).
- name: Install cargo-hack
  shell: bash
  run: |
    version=$(curl -LsSf https://api.github.com/repos/taiki-e/cargo-hack/releases/latest | jq -r '.name')
    host=$(rustc -Vv | grep host | sed 's/host: //')

    if [[ $host =~ windows ]]; then
        curl -LsSf https://github.com/taiki-e/cargo-hack/releases/download/v${version}/cargo-hack-v${version}-${host}.zip -o cargo-hack.zip
        7z x cargo-hack.zip
    elif [[ $host =~ darwin|linux ]]; then
        curl -LsSf https://github.com/taiki-e/cargo-hack/releases/download/v${version}/cargo-hack-v${version}-${host}.tar.gz | tar xzf -
    else
        echo "unsupported operating system"
        exit 1
    fi

    mkdir __cargo_hack_bin
    mv cargo-hack __cargo_hack_bin
    echo "$(pwd)/__cargo_hack_bin" >> $GITHUB_PATH

And I see that you've already implemented stripping, but given that the download is <1 second on CI in the previous link, it turns out that minor optimization will probably have an extremely small effect.

I've no idea if you're familiar with the way the PATH env var works in Windows, but I certainly don't. Just reporting that doing the following fails on CI (I use Linux personally, and my household doesn't have any Windows machines).

Hmm, it's odd that $GITHUB_PATH doesn't work on windows. (I thought it is the formal way to add path...)
I think the way of moving a binary to a directory that is already in $PATH should probably work.
mv cargo-hack $HOME/.cargo/bin/

Hmm, it's odd that $GITHUB_PATH doesn't work on windows. (I thought it is the formal way to add path...)

Oh, this seems to be because the Unix style absolute path (\c\...) returned by bash's pwd is not considered a valid path of Windows. So the following patches work.
          7z x cargo-hack.zip
+         echo "$(pwd)/__cargo_hack_bin" | sed 's/^\///' | sed 's/\//:\\/' >> $GITHUB_PATH
      elif [[ $host =~ darwin|linux ]]; then
          curl -LsSf https://github.com/taiki-e/cargo-hack/releases/download/v${version}/cargo-hack-v${version}-${host}.tar.gz | tar xzf -
+         echo "$(pwd)/__cargo_hack_bin" >> $GITHUB_PATH
      else

      mkdir __cargo_hack_bin
      mv cargo-hack __cargo_hack_bin
-     echo "$(pwd)/__cargo_hack_bin" >> $GITHUB_PATH

However, the way mentioned in my comments above is simpler.
version=$(curl -LsSf https://api.github.com/repos/taiki-e/cargo-hack/releases/latest | jq -r '.name')
host=$(rustc -Vv | grep host | sed 's/host: //')

if [[ $host =~ windows ]]; then
  curl -LsSf https://github.com/taiki-e/cargo-hack/releases/download/v${version}/cargo-hack-v${version}-${host}.zip -o cargo-hack.zip
  7z x cargo-hack.zip
elif [[ $host =~ darwin|linux ]]; then
  curl -LsSf https://github.com/taiki-e/cargo-hack/releases/download/v${version}/cargo-hack-v${version}-${host}.tar.gz | tar xzf -
else
  echo "unsupported operating system"
  exit 1
fi

mv cargo-hack $HOME/.cargo/bin/

That's some odd behavior. I pulled the mv behavior into the extraction, but that's just personal preference. I can confirm that this works as expected on CI.
version=$(curl -LsSf https://api.github.com/repos/taiki-e/cargo-hack/releases/latest | jq -r '.name')
host=$(rustc -Vv | grep host | sed 's/host: //')

if [[ $host =~ windows ]]; then
    curl -LsSf https://github.com/taiki-e/cargo-hack/releases/download/v${version}/cargo-hack-v${version}-${host}.zip -o cargo-hack.zip
    7z x cargo-hack.zip -o ~/.cargo/bin
elif [[ $host =~ darwin|linux ]]; then
    curl -LsSf https://github.com/taiki-e/cargo-hack/releases/download/v${version}/cargo-hack-v${version}-${host}.tar.gz | tar xzf - -C ~/.cargo/bin
else
    echo "unsupported operating system"
    exit 1
fi

Hmm, maybe it is better not to include the version number in the release binary. https://github.com/rust-embedded/cross/issues/457
That allows installing cargo-hack with one command if you know the host os.
before(current):
version=$(curl -LsSf https://api.github.com/repos/taiki-e/cargo-hack/releases/latest | jq -r '.name')
curl -LsSf https://github.com/taiki-e/cargo-hack/releases/download/v${version}/cargo-hack-v${version}-x86_64-unknown-linux-gnu.zip -o cargo-hack.zip

after:
curl -LsSf https://github.com/taiki-e/cargo-hack/releases/download/releases/cargo-hack-x86_64-unknown-linux-gnu.zip -o cargo-hack.zip

That said, this will break the CI that depends on the current URL. However, this issue can be avoided by distributing under both names until the next major version (0.5).


Allow command line access to logging controller

To debug uProxy it is extremely useful to have command line access to the logging controller. Add this to the set of exported things from uproxy_core.ts.

Done in https://github.com/uProxy/uproxy/pull/1368
Note; doesn't fix: https://github.com/uProxy/uproxy/issues/1369


Chore(build):fix isort version conflicting with newest poetry release

Seems a recent release of poetry broke isort.
Upgrade to at least 5.12.0 is required to fix.
Without this, the pre-commit hook is broken
Related link : https://levelup.gitconnected.com/fix-runtimeerror-poetry-isort-5db7c67b60ff

Hi @mveroone ,
What was the error exactly? We do not rely (yet) on Poetry to manage dependencies so I am a bit surprised by this incompatibility.
I tried to reproduce the issue in a brand new virtual environment. After make install, isort --version returns:
(venv_test) user@workstation-la3rvj4l:~/workspace/github/google/slo-generator$ isort --version

                 _                 _
                (_) ___  ___  _ __| |_
                | |/ _/ / _ \/ '__  _/
                | |\__ \/\_\/| |  | |_
                |_|\___/\___/\_/   \_/

      isort your imports, so you don't have to.

                    VERSION 5.12.0

Then make format (which uses isort) and pre-commit seem to work fine:
(venv_test) user@workstation-la3rvj4l:~/workspace/github/google/slo-generator$ make format
isort .
Skipped 6 files
black .
All done! ✨ 🍰 ✨
47 files left unchanged.
(venv_test) user@workstation-la3rvj4l:~/workspace/github/google/slo-generator$ pre-commit
trim trailing whitespace.............................(no files to check)Skipped
fix end of files.....................................(no files to check)Skipped
check yaml...........................................(no files to check)Skipped
check for added large files..........................(no files to check)Skipped
autoflake............................................(no files to check)Skipped
flake8...............................................(no files to check)Skipped
black................................................(no files to check)Skipped
isort................................................(no files to check)Skipped
pylint...............................................(no files to check)Skipped

Hi.
When running against master I get this :
❯ ./venv/bin/pre-commit run
[INFO] Installing environment for https://github.com/PyCQA/isort.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
An unexpected error has occurred: CalledProcessError: command: ('/home/mveroone/.cache/pre-commit/repoa6vlf55_/py_env-python3/bin/python', '-mpip', 'install', '.')
return code: 1
stdout:
    Processing /home/mveroone/.cache/pre-commit/repoa6vlf55_
      Installing build dependencies: started
      Installing build dependencies: finished with status 'done'
      Getting requirements to build wheel: started
      Getting requirements to build wheel: finished with status 'done'
      Preparing metadata (pyproject.toml): started
      Preparing metadata (pyproject.toml): finished with status 'error'
stderr:
      error: subprocess-exited-with-error

      × Preparing metadata (pyproject.toml) did not run successfully.
      │ exit code: 1
      ╰─> [14 lines of output]
          Traceback (most recent call last):
            File "/home/mveroone/.cache/pre-commit/repoa6vlf55_/py_env-python3/lib/python3.9/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 353, in <module>
              main()
            File "/home/mveroone/.cache/pre-commit/repoa6vlf55_/py_env-python3/lib/python3.9/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 335, in main
              json_out['return_val'] = hook(**hook_input['kwargs'])
            File "/home/mveroone/.cache/pre-commit/repoa6vlf55_/py_env-python3/lib/python3.9/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 149, in prepare_metadata_for_build_wheel
              return hook(metadata_directory, config_settings)
            File "/tmp/pip-build-env-yef1679j/overlay/lib/python3.9/site-packages/poetry/core/masonry/api.py", line 41, in prepare_metadata_for_build_wheel
              poetry = Factory().create_poetry(Path(".").resolve(), with_groups=False)
            File "/tmp/pip-build-env-yef1679j/overlay/lib/python3.9/site-packages/poetry/core/factory.py", line 58, in create_poetry
              raise RuntimeError("The Poetry configuration is invalid:\n" + message)
          RuntimeError: The Poetry configuration is invalid:
            - [extras.pipfile_deprecated_finder.2] 'pip-shims<=0.3.4' does not match '^[a-zA-Z-_.0-9]+$'

          [end of output]

      note: This error originates from a subprocess, and is likely not a problem with pip.
    error: metadata-generation-failed

    × Encountered error while generating package metadata.
    ╰─> See above for output.

    note: This is an issue with the package mentioned above, not pip.
    hint: See above for details.
Check the log at /home/mveroone/.cache/pre-commit/pre-commit.log

using venv and python 3.9

Thanks, let me test the same workflow.

Still the same.
I'm running a Debian 11 WSL2 instance, if that helps...
cd /tmp
git clone git@github.com:google/slo-generator.git
cd slo-generator/
python3 --version
python3 -m venv venv
source venv/bin/activate
make install
pre-commit run
pre-commit run --all-files
isort --version
Cloning into 'slo-generator'...
remote: Enumerating objects: 2443, done.
remote: Counting objects: 100% (361/361), done.
remote: Compressing objects: 100% (184/184), done.
remote: Total 2443 (delta 189), reused 330 (delta 175), pack-reused 2082
Receiving objects: 100% (2443/2443), 1.04 MiB | 2.07 MiB/s, done.
Resolving deltas: 100% (1511/1511), done.

[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
An unexpected error has occurred: CalledProcessError: command: ('/home/mveroone/.cache/pre-commit/repoa6vlf55_/py_env-python3/bin/python', '-mpip', 'install', '.')
return code: 1
stdout:
    Processing /home/mveroone/.cache/pre-commit/repoa6vlf55_
      Installing build dependencies: started
      Installing build dependencies: finished with status 'done'
      Getting requirements to build wheel: started
      Getting requirements to build wheel: finished with status 'done'
      Preparing metadata (pyproject.toml): started
      Preparing metadata (pyproject.toml): finished with status 'error'
stderr:
      error: subprocess-exited-with-error

      × Preparing metadata (pyproject.toml) did not run successfully.
      │ exit code: 1
      ╰─> [14 lines of output]
          Traceback (most recent call last):
            File "/home/mveroone/.cache/pre-commit/repoa6vlf55_/py_env-python3/lib/python3.9/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 353, in <module>
              main()
            File "/home/mveroone/.cache/pre-commit/repoa6vlf55_/py_env-python3/lib/python3.9/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 335, in main
              json_out['return_val'] = hook(**hook_input['kwargs'])
            File "/home/mveroone/.cache/pre-commit/repoa6vlf55_/py_env-python3/lib/python3.9/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 149, in prepare_metadata_for_build_wheel
              return hook(metadata_directory, config_settings)
            File "/tmp/pip-build-env-1919ir3t/overlay/lib/python3.9/site-packages/poetry/core/masonry/api.py", line 41, in prepare_metadata_for_build_wheel
              poetry = Factory().create_poetry(Path(".").resolve(), with_groups=False)
            File "/tmp/pip-build-env-1919ir3t/overlay/lib/python3.9/site-packages/poetry/core/factory.py", line 58, in create_poetry
              raise RuntimeError("The Poetry configuration is invalid:\n" + message)
          RuntimeError: The Poetry configuration is invalid:
            - [extras.pipfile_deprecated_finder.2] 'pip-shims<=0.3.4' does not match '^[a-zA-Z-_.0-9]+$'

          [end of output]

      note: This error originates from a subprocess, and is likely not a problem with pip.
    error: metadata-generation-failed

    × Encountered error while generating package metadata.
    ╰─> See above for output.

    note: This is an issue with the package mentioned above, not pip.
    hint: See above for details.
Check the log at /home/mveroone/.cache/pre-commit/pre-commit.log
[INFO] Installing environment for https://github.com/PyCQA/isort.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
An unexpected error has occurred: CalledProcessError: command: ('/home/mveroone/.cache/pre-commit/repoa6vlf55_/py_env-python3/bin/python', '-mpip', 'install', '.')
return code: 1
stdout:
    Processing /home/mveroone/.cache/pre-commit/repoa6vlf55_
      Installing build dependencies: started
      Installing build dependencies: finished with status 'done'
      Getting requirements to build wheel: started
      Getting requirements to build wheel: finished with status 'done'
      Preparing metadata (pyproject.toml): started
      Preparing metadata (pyproject.toml): finished with status 'error'
stderr:
      error: subprocess-exited-with-error

      × Preparing metadata (pyproject.toml) did not run successfully.
      │ exit code: 1
      ╰─> [14 lines of output]
          Traceback (most recent call last):
            File "/home/mveroone/.cache/pre-commit/repoa6vlf55_/py_env-python3/lib/python3.9/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 353, in <module>
              main()
            File "/home/mveroone/.cache/pre-commit/repoa6vlf55_/py_env-python3/lib/python3.9/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 335, in main
              json_out['return_val'] = hook(**hook_input['kwargs'])
            File "/home/mveroone/.cache/pre-commit/repoa6vlf55_/py_env-python3/lib/python3.9/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 149, in prepare_metadata_for_build_wheel
              return hook(metadata_directory, config_settings)
            File "/tmp/pip-build-env-zc9f17bh/overlay/lib/python3.9/site-packages/poetry/core/masonry/api.py", line 41, in prepare_metadata_for_build_wheel
              poetry = Factory().create_poetry(Path(".").resolve(), with_groups=False)
            File "/tmp/pip-build-env-zc9f17bh/overlay/lib/python3.9/site-packages/poetry/core/factory.py", line 58, in create_poetry
              raise RuntimeError("The Poetry configuration is invalid:\n" + message)
          RuntimeError: The Poetry configuration is invalid:
            - [extras.pipfile_deprecated_finder.2] 'pip-shims<=0.3.4' does not match '^[a-zA-Z-_.0-9]+$'

          [end of output]

      note: This error originates from a subprocess, and is likely not a problem with pip.
    error: metadata-generation-failed

    × Encountered error while generating package metadata.
    ╰─> See above for output.

    note: This is an issue with the package mentioned above, not pip.
    hint: See above for details.
Check the log at /home/mveroone/.cache/pre-commit/pre-commit.log

                 _                 _
                (_) ___  ___  _ __| |_
                | |/ _/ / _ \/ '__  _/
                | |\__ \/\_\/| |  | |_
                |_|\___/\___/\_/   \_/

      isort your imports, so you don't have to.

                    VERSION 5.12.0

Weird. I am also running Debian 11 inside a dedicated Cloud Workstation:
(venv) user@workstation-la3rvj4l:/tmp/slo-generator$ cat /etc/os-release
PRETTY_NAME="Debian GNU/Linux 11 (bullseye)"
NAME="Debian GNU/Linux"
VERSION_ID="11"
VERSION="11 (bullseye)"
VERSION_CODENAME=bullseye
ID=debian
HOME_URL="https://www.debian.org/"
SUPPORT_URL="https://www.debian.org/support"
BUG_REPORT_URL="https://bugs.debian.org/"

I tested the same workflow with Python 3.9.2 in order to match your config as closely as possible. I got the same result, with no errors 🤔.

Is there any risk of updating that package, though ?
I get that there's a mystery we would both like to solve, but in the meantime, this prevents me from commiting to any other branch =/ (including my Splunk PR)

Hello,
Same issue than @mveroone on my side :
      × Preparing metadata (pyproject.toml) did not run successfully.
      │ exit code: 1
      ╰─> [14 lines of output]
          Traceback (most recent call last):
            File "/Users/benjamin/.cache/pre-commit/repo2wd3r9hi/py_env-python3/lib/python3.9/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 353, in <module>
              main()
            File "/Users/benjamin/.cache/pre-commit/repo2wd3r9hi/py_env-python3/lib/python3.9/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 335, in main
              json_out['return_val'] = hook(**hook_input['kwargs'])
            File "/Users/benjamin/.cache/pre-commit/repo2wd3r9hi/py_env-python3/lib/python3.9/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 149, in prepare_metadata_for_build_wheel
              return hook(metadata_directory, config_settings)
            File "/private/var/folders/vm/bx_p7skx4rsfnzrms7ykfmxw0000gq/T/pip-build-env-pfh66qzo/overlay/lib/python3.9/site-packages/poetry/core/masonry/api.py", line 41, in prepare_metadata_for_build_wheel
              poetry = Factory().create_poetry(Path(".").resolve(), with_groups=False)
            File "/private/var/folders/vm/bx_p7skx4rsfnzrms7ykfmxw0000gq/T/pip-build-env-pfh66qzo/overlay/lib/python3.9/site-packages/poetry/core/factory.py", line 58, in create_poetry
              raise RuntimeError("The Poetry configuration is invalid:\n" + message)
          RuntimeError: The Poetry configuration is invalid:
            - [extras.pipfile_deprecated_finder.2] 'pip-shims<=0.3.4' does not match '^[a-zA-Z-_.0-9]+$'

          [end of output]

      note: This error originates from a subprocess, and is likely not a problem with pip.
    error: metadata-generation-failed

I'm running on macOS M1, Python 3.9.16

OK let's move forward. I still don't understand why this Poetry bug affects us, as we do not use Poetry. This being said, I agree there is not a big risk associated with bumping the version of this dependency.


Fixed issues in GUI and conversion to SBGN + added empty set nodes for exchange reactions

Issues:

Conversion to SBGN did not work correctly if model contained 2 nodes for the same metabolite
Bezier curves were not drawn correctly in the GUI because of overlapping IDs

Main Changes

Escher2SBML:

Added prefixes to IDs depending on their type ("R_" for midmarker, "M_" for metabolite) for clearer differentiation and to prevent overlapping
Instead of exchange reactions (reactions with only 1 metabolite) ending in a mid- / multimarker:

now end in an empty set node placed at previous position of mid- / multimarker
positions of mid- and multimarkers adjusted accordingly for reactions consisting of only linear segments
new segment between midmarker and empty set node inserted for reactions consisting of only linear segments

Segments (and corresponding nodes) which are not connected to any metabolite (possibly over other segments) are now not converted

Escher2SBGN:

IDs of metabolites were extended to also include the reaction ID to make them unique
Similar like in Escher2SBML empty set nodes were inserted for exchange reactions

There are mainly change requests regarding three categories:

Indication of literal numbers, in particular when dividing, e.g., by 2 where rounding errors could happen if not clearly indicating that a double is meant.
Use of static field constants in the class for identifier manipulation to ensure identical prefixes. Please always use prefixes, not suffixes and prefixes, please always use the same prefixes and don't vary. There are many such uses, not all were indicated in the review.
Use of display messages: Please always import the format method from MessageFormat as a static import where not yet done to shorten the call command to the logger. Please make sure not to insert longer String statements as hard-coded text fragments that will hamper localization efforts. Please also do not break identifiers for message strings.

As a general advice: In if-clauses it is often recommended to use more parentheses to indicate logical constructs better and to avoid misinterpretation.


Explore an IOMMU based scheme that mimics sysmem API for GS/WH

In UMD, "sysmem" refers to 1G hugepages used as shared buffers between device and host.  The APIs for system include tt_SiliconDevice constructor (specifies number of "channels") and accessor methods (read/write/get pointer to buffer) that are channel based.
While preserving the API, write an alternate implementation that does not huge hugepages, but relies on the KMD ability to map physically noncontiguous buffers to a contiguous IO virtual address space seen by the device.
The challenges at the system level:

WH hardware is limited to accessing an address space of 0x0-0xffff'ffff without iATU programming
KMD IOVA allocation does not seem to support complete coverage of this address space
With iATU we can work around this.  However, iATU is limited to 16 regions with a constraint that the IOVA must be naturally aligned with the region size.
Unlike VFIO, KMD API provides no userspace control over the IOVA - so some over-allocation may be necessary to achieve alignment
KMD lacks an API to unmap

Challenge at the user driver level:

Maintain the illusion of one to four channels, even if there are up to 16 sub allocations
At runtime, determine whether to do sysmem via IOMMU or sysmem via hugepage

dma_alloc_coherent or dma_pool_create might be useful in getting aligned memory?


Identity Platform

The scope of this epic includes the cloud infrastructure and integrations necessary to enable the Identity Platform MVP, as described in this requirements doc. As noted in the PRD:

All of the experiences described in the relevant PRFAQ and PID should start with a common platform. Without one, features based on user identity will be reliant on bespoke backend infrastructure and therefore inevitably diverge from one another in terms of experience.

Therefore, this epic itself does not address specific user stories, but lays the foundation for further epics that will.

Closing this old ZenHub epic as stale. We've moved these things to Jira.


tapcli: fix flag checking for universe proof cmds

Addresses issues from #308 that are fixable while using urfave/cli v1.

copilot:all

copilot:all


Create 30-sec YouTube video

See #13

@naquola prepared the vided and uploaded it to YouTube: https://youtu.be/VNvd87AFxaY
Closing issue


chore(package.json): update make package script to update correspondi…

…ng build name
closes #892
Small update to script to reflect package name to corresponding build.

https://github.com/ReactiveX/RxJS/pull/895 seems better, closing this.


AttributeError: 'module' object has no attribute 'maximum'

Hi, I get a error from running topographica jobs,
Traceback (most recent call last):
File "/scratch01/env_c/topographica_pbc/pbc_measurement.py", line 90, in
load_snapshot(path+fname+'/'+snapshot_name)
File "/scratch01/env_c/topographica_pbc/topo/command/init.py", line 325, in load_snapshot
pickle.load(snapshot)
AttributeError: 'module' object has no attribute 'maximum'
Before it worked well, suddenly this error appears, I have no idea how to solve it.

This error seems to indicate that when you saved the snapshot last time, some code of yours previously defined an attribute named maximum, but that attribute is no longer defined in your code so that pickle is failing when it tries to restore that attribute.  If maximum isn't important, you can probably put in a dummy declaration for it so that the pickle loading fails, but there may be other changes needed.

Actually I didnt define maximum in my code.I am not sure where it comes from.Sent from my Huawei Mobile-------- Original Message --------Subject: Re: [ioam/topographica] AttributeError: 'module' object has no attribute 'maximum' (#694)From: "James A. Bednar" To: ioam/topographica CC: dancehours ,Author This error seems to indicate that when you saved the snapshot last time, some code of yours previously defined an attribute named maximum, but that attribute is no longer defined in your code so that pickle is failing when it tries to restore that attribute.  If maximum isn't important, you can probably put in a dummy declaration for it so that the pickle loading fails, but there may be other changes needed.
—You are receiving this because you authored the thread.Reply to this email directly, view it on GitHub, or mute the thread.
{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/ioam/topographica","title":"ioam/topographica","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/ioam/topographica"}},"updates":{"snippets":[{"icon":"PERSON","message":"@jbednar in #694: This error seems to indicate that when you saved the snapshot last time, some code of yours previously defined an attribute named maximum, but that attribute is no longer defined in your code so that pickle is failing when it tries to restore that attribute.  If maximum isn't important, you can probably put in a dummy declaration for it so that the pickle loading fails, but there may be other changes needed."}],"action":{"name":"View Issue","url":"https://github.com/ioam/topographica/issues/694#issuecomment-465307093"}}}
[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/ioam/topographica/issues/694#issuecomment-465307093",
"url": "https://github.com/ioam/topographica/issues/694#issuecomment-465307093",
"name": "View Issue"
},
"description": "View this Issue on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]

/home/wenqi/Documents/gcal_network_diagram.png.gif

/home/wenqi/Documents/gcal_network_diagram.png

http://ioam.github.io/topographica/Tutorials/gcal.html

Hi, I would need to make a diagram of the gcal model. I found I can referred to the model view showed
in the second image from this link http://ioam.github.io/topographica/Tutorials/gcal.html. I have
a difficulty on making the off LGN's dark center bright boundary 's effect. I would like to ask, which software do you use to make that image ? Sorry for this details and technique question.

http://ioam.github.io/topographica/Tutorials/gcal.html

https://ioam.github.io/topographica/Tutorials/gcal.html

This is the right link. https://ioam.github.io/topographica/Tutorials/gcal.html

That's a screenshot from the Tk gui's model editor.

This error seems to indicate that when you saved the snapshot last time, some code of yours previously defined an attribute named maximum, but that attribute is no longer defined in your code so that pickle is failing when it tries to restore that attribute. If maximum isn't important, you can probably put in a dummy declaration for it so that the pickle loading fails, but there may be other changes needed.

Hi Bednar, I am not sure how to define a dummy declaration properly, could you show me this ?

This error seems to indicate that when you saved the snapshot last time, some code of yours previously defined an attribute named maximum, but that attribute is no longer defined in your code so that pickle is failing when it tries to restore that attribute. If maximum isn't important, you can probably put in a dummy declaration for it so that the pickle loading fails, but there may be other changes needed.

Hi Bednar, I am not sure how to define a dummy declaration in the definition of load_snapshot properly, could you show me this ?

Hi Bednar, I am sorry I ask the very old question now. I am stuck with this problem in my project and really need to solve it soon.
Could you please give me some suggestions ?

Sorry; it's very difficult to debug that without the running session and all your files.  A message like that usually indicates that the python code you are running does not match the code that you had when you saved the pickle. At the time of the pickle, there was a module with an object 'maximum' defined, but now there isn't such an object declared in that module, so when pickle tries to restore its state, it fails. From the message I can't tell what module that might be, but if you can figure out which one it is, load the __init__.py file from it into an editor, and add a dummy declaration like class maximum(object): pass. Then maybe loading that pickle will succeed. I can't theorize why maximum would have disappeared from your source tree; maybe it's simply that you're using a different Topographica version or some other different files of your own. Sorry I can't be more help than that; Pickle files very often don't give useful error messages!


Products/Products Documentation

Please change the alignment of both text and headings from right to left to make reading easier.

Confirmed, thank you


typos?

Hi!
I'm trying to port your library in my project where I'm using es6 and standard js linter style.
I've found something that can be considered typos:
line 40:
cthis.sketch.urveVertex( this.getOffset( -offset, offset )+cx+rx*Math.cos( radialOffset+Math.PI*2+overlap*0.5 ),
with cthis you mean this?
line 366:
  if (((otherSegment.getPy1()-yi)*(yi-otherSegment.getPy2()) < -0.00001) || ((y1-yi)*(yi-y2) < -000001)) {
with -000001 you mean -0.000001?

Thank you for opening this issue.
The mistake in line 40 happened when I updated the lib the last time.
The missing dot in line 366 comes from the original processing lib handy written in java but is now corrected. I will open an issue there.


Can't import the POD

I have added YOChartImageKit to my pod but I'm not able to import it or use any of the modules features. If anyone has any information much appreciated.
TYIA!

I am having the same problem. Won't show up in my main target nor in my WatchExtension target.
I am using Swift5, latest Cocoapods etc.

Try the following:
Open xcode schemes list.

Tick YOChartImageKit with "show" and close.
Select YOChartImageKit as a scheme and build (cmd + b)
Change scheme back to your app scheme and see if the error is gone and autocompletion works.

FYI: https://github.com/Quick/Quick/issues/731#issuecomment-328504054


Progress report call - 18th June

Date: 18th June, 16:00 GMT+0
Notes: https://cryptpad.fr/code/#/2/code/edit/PmURjkUy8z+HokpWrMaiRN2z/
Call: https://zoom.us/j/134161591

Thanks all for participating!
Notes were saved in the repo: https://github.com/ipfs-shipyard/pm-idm/blob/master/meetings/2019-06-18_progress-report.md


Install with make on Debian Linux failing

What version of Delve are you using (dlv version)?
Trying to use tag v1.0.0 but haven't got that far yet.

What version of Go are you using? (go version)?
go version go1.10.3 linux/amd64

What operating system and processor architecture are you using?
Debian GNU/Linux 9 (stretch)
Linux Dev 4.9.0-6-amd64 #1 SMP Debian 4.9.88-1+deb9u1 (2018-05-07) x86_64 GNU/Linux

What did you do?
To clone I am using:

GO_PATH=$(go env GOPATH)
DELVE_REPO=github.com/derekparker/delve
git clone https://$DELVE_REPO.git $GO_PATH/src/$DELVE_REPO
cd $GO_PATH/src/$DELVE_REPO
git checkout tags/v1.0.0

To build I am using
make install

What did you expect to see?
Successful build.

What did you see instead?
Lots of dependency errors:

pkg/terminal/command.go:6:2: cannot find package "bufio" in any of:
        /home/dwilliamson/go/src/github.com/derekparker/delve/vendor/bufio (vendor tree)
        /usr/local/go/src/bufio (from $GOROOT)
        /home/dwilliamson/go/src/bufio (from $GOPATH)
pkg/config/split.go:4:2: cannot find package "bytes" in any of:
        /home/dwilliamson/go/src/github.com/derekparker/delve/vendor/bytes (vendor tree)
        /usr/local/go/src/bytes (from $GOROOT)
        /home/dwilliamson/go/src/bytes (from $GOPATH)
vendor/github.com/peterh/liner/common.go:10:2: cannot find package "container/ring" in any of:
        /home/dwilliamson/go/src/github.com/derekparker/delve/vendor/container/ring (vendor tree)
        /usr/local/go/src/container/ring (from $GOROOT)
        /home/dwilliamson/go/src/container/ring (from $GOPATH)
pkg/dwarf/godwarf/type.go:14:2: cannot find package "debug/dwarf" in any of:
        /home/dwilliamson/go/src/github.com/derekparker/delve/vendor/debug/dwarf (vendor tree)
        /usr/local/go/src/debug/dwarf (from $GOROOT)
        /home/dwilliamson/go/src/debug/dwarf (from $GOPATH)
pkg/proc/bininfo.go:6:2: cannot find package "debug/elf" in any of:
        /home/dwilliamson/go/src/github.com/derekparker/delve/vendor/debug/elf (vendor tree)
        /usr/local/go/src/debug/elf (from $GOROOT)
        /home/dwilliamson/go/src/debug/elf (from $GOPATH)
pkg/proc/bininfo.go:7:2: cannot find package "debug/macho" in any of:
        /home/dwilliamson/go/src/github.com/derekparker/delve/vendor/debug/macho (vendor tree)
        /usr/local/go/src/debug/macho (from $GOROOT)
        /home/dwilliamson/go/src/debug/macho (from $GOPATH)
pkg/proc/bininfo.go:8:2: cannot find package "debug/pe" in any of:
        /home/dwilliamson/go/src/github.com/derekparker/delve/vendor/debug/pe (vendor tree)
        /usr/local/go/src/debug/pe (from $GOROOT)
        /home/dwilliamson/go/src/debug/pe (from $GOPATH)
vendor/gopkg.in/yaml.v2/decode.go:4:2: cannot find package "encoding" in any of:
        /home/dwilliamson/go/src/github.com/derekparker/delve/vendor/encoding (vendor tree)
        /usr/local/go/src/encoding (from $GOROOT)
        /home/dwilliamson/go/src/encoding (from $GOPATH)
vendor/gopkg.in/yaml.v2/decode.go:5:2: cannot find package "encoding/base64" in any of:
        /home/dwilliamson/go/src/github.com/derekparker/delve/vendor/encoding/base64 (vendor tree)
        /usr/local/go/src/encoding/base64 (from $GOROOT)
        /home/dwilliamson/go/src/encoding/base64 (from $GOPATH)
pkg/dwarf/op/op.go:5:2: cannot find package "encoding/binary" in any of:
        /home/dwilliamson/go/src/github.com/derekparker/delve/vendor/encoding/binary (vendor tree)
        /usr/local/go/src/encoding/binary (from $GOROOT)
        /home/dwilliamson/go/src/encoding/binary (from $GOPATH)
vendor/github.com/spf13/pflag/string_slice.go:5:2: cannot find package "encoding/csv" in any of:
        /home/dwilliamson/go/src/github.com/derekparker/delve/vendor/encoding/csv (vendor tree)
        /usr/local/go/src/encoding/csv (from $GOROOT)
        /home/dwilliamson/go/src/encoding/csv (from $GOPATH)
pkg/proc/gdbserial/gdbserver_conn.go:7:2: cannot find package "encoding/json" in any of:
        /home/dwilliamson/go/src/github.com/derekparker/delve/vendor/encoding/json (vendor tree)
        /usr/local/go/src/encoding/json (from $GOROOT)
        /home/dwilliamson/go/src/encoding/json (from $GOPATH)
pkg/proc/gdbserial/gdbserver_conn.go:8:2: cannot find package "encoding/xml" in any of:
        /home/dwilliamson/go/src/github.com/derekparker/delve/vendor/encoding/xml (vendor tree)
        /usr/local/go/src/encoding/xml (from $GOROOT)
        /home/dwilliamson/go/src/encoding/xml (from $GOPATH)
cmd/dlv/cmds/commands.go:4:2: cannot find package "errors" in any of:
        /home/dwilliamson/go/src/github.com/derekparker/delve/vendor/errors (vendor tree)
        /usr/local/go/src/errors (from $GOROOT)
        /home/dwilliamson/go/src/errors (from $GOPATH)
vendor/github.com/spf13/pflag/golangflag.go:8:2: cannot find package "flag" in any of:
        /home/dwilliamson/go/src/github.com/derekparker/delve/vendor/flag (vendor tree)
        /usr/local/go/src/flag (from $GOROOT)
        /home/dwilliamson/go/src/flag (from $GOPATH)
cmd/dlv/cmds/commands.go:5:2: cannot find package "fmt" in any of:
        /home/dwilliamson/go/src/github.com/derekparker/delve/vendor/fmt (vendor tree)
        /usr/local/go/src/fmt (from $GOROOT)
        /home/dwilliamson/go/src/fmt (from $GOPATH)
pkg/proc/breakpoints.go:6:2: cannot find package "go/ast" in any of:
        /home/dwilliamson/go/src/github.com/derekparker/delve/vendor/go/ast (vendor tree)
        /usr/local/go/src/go/ast (from $GOROOT)
        /home/dwilliamson/go/src/go/ast (from $GOPATH)
pkg/proc/breakpoints.go:7:2: cannot find package "go/constant" in any of:
        /home/dwilliamson/go/src/github.com/derekparker/delve/vendor/go/constant (vendor tree)
        /usr/local/go/src/go/constant (from $GOROOT)
        /home/dwilliamson/go/src/go/constant (from $GOPATH)
pkg/proc/eval.go:11:2: cannot find package "go/parser" in any of:
        /home/dwilliamson/go/src/github.com/derekparker/delve/vendor/go/parser (vendor tree)
        /usr/local/go/src/go/parser (from $GOROOT)
        /home/dwilliamson/go/src/go/parser (from $GOPATH)
pkg/proc/eval.go:12:2: cannot find package "go/printer" in any of:
        /home/dwilliamson/go/src/github.com/derekparker/delve/vendor/go/printer (vendor tree)
        /usr/local/go/src/go/printer (from $GOROOT)
        /home/dwilliamson/go/src/go/printer (from $GOPATH)
pkg/terminal/command.go:10:2: cannot find package "go/scanner" in any of:
        /home/dwilliamson/go/src/github.com/derekparker/delve/vendor/go/scanner (vendor tree)
        /usr/local/go/src/go/scanner (from $GOROOT)
        /home/dwilliamson/go/src/go/scanner (from $GOPATH)
pkg/proc/eval.go:13:2: cannot find package "go/token" in any of:
        /home/dwilliamson/go/src/github.com/derekparker/delve/vendor/go/token (vendor tree)
        /usr/local/go/src/go/token (from $GOROOT)
        /home/dwilliamson/go/src/go/token (from $GOPATH)
vendor/gopkg.in/yaml.v2/apic.go:4:2: cannot find package "io" in any of:
        /home/dwilliamson/go/src/github.com/derekparker/delve/vendor/io (vendor tree)
        /usr/local/go/src/io (from $GOROOT)
        /home/dwilliamson/go/src/io (from $GOPATH)
pkg/config/config.go:5:2: cannot find package "io/ioutil" in any of:
        /home/dwilliamson/go/src/github.com/derekparker/delve/vendor/io/ioutil (vendor tree)
        /usr/local/go/src/io/ioutil (from $GOROOT)
        /home/dwilliamson/go/src/io/ioutil (from $GOPATH)
service/debugger/debugger.go:7:2: cannot find package "log" in any of:
        /home/dwilliamson/go/src/github.com/derekparker/delve/vendor/log (vendor tree)
        /usr/local/go/src/log (from $GOROOT)
        /home/dwilliamson/go/src/log (from $GOPATH)
vendor/gopkg.in/yaml.v2/decode.go:7:2: cannot find package "math" in any of:
        /home/dwilliamson/go/src/github.com/derekparker/delve/vendor/math (vendor tree)
        /usr/local/go/src/math (from $GOROOT)
        /home/dwilliamson/go/src/math (from $GOPATH)
service/config.go:3:8: cannot find package "net" in any of:
        /home/dwilliamson/go/src/github.com/derekparker/delve/vendor/net (vendor tree)
        /usr/local/go/src/net (from $GOROOT)
        /home/dwilliamson/go/src/net (from $GOPATH)
service/rpc2/client.go:6:2: cannot find package "net/rpc" in any of:
        /home/dwilliamson/go/src/github.com/derekparker/delve/vendor/net/rpc (vendor tree)
        /usr/local/go/src/net/rpc (from $GOROOT)
        /home/dwilliamson/go/src/net/rpc (from $GOPATH)
service/rpc2/client.go:7:2: cannot find package "net/rpc/jsonrpc" in any of:
        /home/dwilliamson/go/src/github.com/derekparker/delve/vendor/net/rpc/jsonrpc (vendor tree)
        /usr/local/go/src/net/rpc/jsonrpc (from $GOROOT)
        /home/dwilliamson/go/src/net/rpc/jsonrpc (from $GOPATH)
vendor/gopkg.in/yaml.v2/apic.go:5:2: cannot find package "os" in any of:
        /home/dwilliamson/go/src/github.com/derekparker/delve/vendor/os (vendor tree)
        /usr/local/go/src/os (from $GOROOT)
        /home/dwilliamson/go/src/os (from $GOPATH)
pkg/goversion/go_version.go:4:2: cannot find package "os/exec" in any of:
        /home/dwilliamson/go/src/github.com/derekparker/delve/vendor/os/exec (vendor tree)
        /usr/local/go/src/os/exec (from $GOROOT)
        /home/dwilliamson/go/src/os/exec (from $GOPATH)
vendor/github.com/peterh/liner/input.go:9:2: cannot find package "os/signal" in any of:
        /home/dwilliamson/go/src/github.com/derekparker/delve/vendor/os/signal (vendor tree)
        /usr/local/go/src/os/signal (from $GOROOT)
        /home/dwilliamson/go/src/os/signal (from $GOPATH)
pkg/config/config.go:7:2: cannot find package "os/user" in any of:
        /home/dwilliamson/go/src/github.com/derekparker/delve/vendor/os/user (vendor tree)
        /usr/local/go/src/os/user (from $GOROOT)
        /home/dwilliamson/go/src/os/user (from $GOPATH)
pkg/config/config.go:8:2: cannot find package "path" in any of:
        /home/dwilliamson/go/src/github.com/derekparker/delve/vendor/path (vendor tree)
        /usr/local/go/src/path (from $GOROOT)
        /home/dwilliamson/go/src/path (from $GOPATH)
pkg/dwarf/line/line_parser.go:6:2: cannot find package "path/filepath" in any of:
        /home/dwilliamson/go/src/github.com/derekparker/delve/vendor/path/filepath (vendor tree)
        /usr/local/go/src/path/filepath (from $GOROOT)
        /home/dwilliamson/go/src/path/filepath (from $GOPATH)
vendor/gopkg.in/yaml.v2/decode.go:8:2: cannot find package "reflect" in any of:
        /home/dwilliamson/go/src/github.com/derekparker/delve/vendor/reflect (vendor tree)
        /usr/local/go/src/reflect (from $GOROOT)
        /home/dwilliamson/go/src/reflect (from $GOPATH)
vendor/gopkg.in/yaml.v2/encode.go:7:2: cannot find package "regexp" in any of:
        /home/dwilliamson/go/src/github.com/derekparker/delve/vendor/regexp (vendor tree)
        /usr/local/go/src/regexp (from $GOROOT)
        /home/dwilliamson/go/src/regexp (from $GOPATH)
vendor/golang.org/x/arch/x86/x86asm/decode.go:13:2: cannot find package "runtime" in any of:
        /home/dwilliamson/go/src/github.com/derekparker/delve/vendor/runtime (vendor tree)
        /usr/local/go/src/runtime (from $GOROOT)
        /home/dwilliamson/go/src/runtime (from $GOPATH)
vendor/gopkg.in/yaml.v2/encode.go:8:2: cannot find package "sort" in any of:
        /home/dwilliamson/go/src/github.com/derekparker/delve/vendor/sort (vendor tree)
        /usr/local/go/src/sort (from $GOROOT)
        /home/dwilliamson/go/src/sort (from $GOPATH)
vendor/gopkg.in/yaml.v2/decode.go:9:2: cannot find package "strconv" in any of:
        /home/dwilliamson/go/src/github.com/derekparker/delve/vendor/strconv (vendor tree)
        /usr/local/go/src/strconv (from $GOROOT)
        /home/dwilliamson/go/src/strconv (from $GOPATH)
vendor/gopkg.in/yaml.v2/encode.go:10:2: cannot find package "strings" in any of:
        /home/dwilliamson/go/src/github.com/derekparker/delve/vendor/strings (vendor tree)
        /usr/local/go/src/strings (from $GOROOT)
        /home/dwilliamson/go/src/strings (from $GOPATH)
vendor/gopkg.in/yaml.v2/yaml.go:14:2: cannot find package "sync" in any of:
        /home/dwilliamson/go/src/github.com/derekparker/delve/vendor/sync (vendor tree)
        /usr/local/go/src/sync (from $GOROOT)
        /home/dwilliamson/go/src/sync (from $GOPATH)
pkg/proc/gdbserial/gdbserver_unix.go:5:8: cannot find package "syscall" in any of:
        /home/dwilliamson/go/src/github.com/derekparker/delve/vendor/syscall (vendor tree)
        /usr/local/go/src/syscall (from $GOROOT)
        /home/dwilliamson/go/src/syscall (from $GOPATH)
pkg/terminal/command.go:19:2: cannot find package "text/tabwriter" in any of:
        /home/dwilliamson/go/src/github.com/derekparker/delve/vendor/text/tabwriter (vendor tree)
        /usr/local/go/src/text/tabwriter (from $GOROOT)
        /home/dwilliamson/go/src/text/tabwriter (from $GOPATH)
vendor/github.com/spf13/cobra/cobra.go:25:2: cannot find package "text/template" in any of:
        /home/dwilliamson/go/src/github.com/derekparker/delve/vendor/text/template (vendor tree)
        /usr/local/go/src/text/template (from $GOROOT)
        /home/dwilliamson/go/src/text/template (from $GOPATH)
vendor/gopkg.in/yaml.v2/decode.go:10:2: cannot find package "time" in any of:
        /home/dwilliamson/go/src/github.com/derekparker/delve/vendor/time (vendor tree)
        /usr/local/go/src/time (from $GOROOT)
        /home/dwilliamson/go/src/time (from $GOPATH)
vendor/gopkg.in/yaml.v2/sorter.go:5:2: cannot find package "unicode" in any of:
        /home/dwilliamson/go/src/github.com/derekparker/delve/vendor/unicode (vendor tree)
        /usr/local/go/src/unicode (from $GOROOT)
        /home/dwilliamson/go/src/unicode (from $GOPATH)
vendor/gopkg.in/yaml.v2/resolve.go:9:2: cannot find package "unicode/utf8" in any of:
        /home/dwilliamson/go/src/github.com/derekparker/delve/vendor/unicode/utf8 (vendor tree)
        /usr/local/go/src/unicode/utf8 (from $GOROOT)
        /home/dwilliamson/go/src/unicode/utf8 (from $GOPATH)
pkg/proc/moduledata.go:5:2: cannot find package "unsafe" in any of:
        /home/dwilliamson/go/src/github.com/derekparker/delve/vendor/unsafe (vendor tree)
        /usr/local/go/src/unsafe (from $GOROOT)
        /home/dwilliamson/go/src/unsafe (from $GOPATH)

This is my first time using Go. I have not set $GOROOT or $GOPATH as they are set at the defaults of /usr/local/go and ~/go. Calling go env on each of these returns valid paths. I can build and run go programs without issue.

This is also an issue on HEAD when I don't git checkout tags/v1.0.0

Your Go install is broken, it can't find the standard library.


Homework - 2. Fixed the names of classes according to BEM.

 I'm closing this pr


Read the docs pages using MKDocs

We should add a Read the docs page with mkdocs. I will be adding the base templates for the documentation and may be @rsdefever with your expertise can take it for the actual documentation :).

@umesh-timalsina are you going to add some base templates or should I just dive in?


Uncommited redux react router actions can cause issues debugging in dev tool

I'm noticing what could potentially be called a bug.

Fresh clone of the repo
npm start
Observe redux react router actions in the debug tool: routerDidChange, replaceRoutes, routerDidChange

If I click the counter to increment and then revert the page content disappears. I believe these router actions should be commited to the redux store on initial page load to prevent this from happening.

Good catch, thanksl not sure what to label it as. If you'd like to submit a PR that would be awesome, if not I'll try to get to it when I have a minute. Thanks!

Going to close this for now as after a lot of deliberation I don't think this is something the starter kit should handle. I see where you're coming from, but this is how it works out of the box w/ redux-router and I don't necessarily want to tailor the starter kit to the devtools. I might be switching this starter kit to https://github.com/Agamennon/redux-tiny-router anyways, so we'll see.


Any Ingestion pipeline support?

Description
We are currently working on a IoT project which will integrate a large number of devices, and save the raw data(which is semi-structured) and do some simple statistical or analytical  aggregation at realtime. There would be millions of devices from hundreds of zone,  connected to the project(High cardinality)
Currently we tried to use kafka ingestion, which druid will pull raw data and save them. And another pulling procedure will pull the kafka again to aggregate based on some dimention( zoneID, typeOfDevice
Motivation
So the problem(might be) is, we have to pull kafka multiple times for different purpose but identical dataset.
Is there any way we could add or configure a pipeline for this kind of process?
Like we received device reading from deviceA of zoneA, save reading data into a table named raw_data. And then use the same data to calculate the sum(reading.data) to save in a aggregated table sum_by_zone?
This could save a lot of bandwidth and computing resources.

You could take a look at the materialized view extension.


Add NEBULA to RSD

It would be great if we can add NEBULA to the research software directory.
It helps us show the impact we have with open-source lesson material development.

I completely agree. I could link it under "impact" of the EUCP project as this is originally derived from the storyboards we developed there, right?

Sounds good to me @Peter9192 !

I created an RSD page:
https://research-software-directory.org/software/nebula
I sent a maintainer link to @JaroCamphuijsen and @raar1


69 update my about data

I updated my info for the About page to replace my email with my github and change my photo and bio.

Great shot, I need to find your photographer :D


Use /run/ostree-booted to determine if host is RHCOS

As mentioned in openshift/sriov-network-operator#647, the best way to figure out if the underlying system is based on rpm-ostree is to look at /run/ostree-booted.
I also added a test harness for script testing, as the logic in bindata/scripts is not trivial.
Fixes: https://github.com/openshift/sriov-network-operator/issues/647

Thanks for the contribution!
LGTM

/lgtm

/lgtm
I guess this is also the cause of bug: https://bugzilla.redhat.com/show_bug.cgi?id=2070888

/lgtm I guess this is also the cause of bug: https://bugzilla.redhat.com/show_bug.cgi?id=2070888

Yes, going to link BZs together

The changes to the kargs script look good to me.
What's the purpose of https://github.com/k8snetworkplumbingwg/sriov-network-operator/pull/276/files#diff-3edef0a0ec747a6f82bd0f9c61538add1ca891ca37c7e85b9fd46d46b343d848? If this is for testing setting kargs in rpm-ostree then I don't think you really need that as we already test that in rpm-ostree CI. If something is missing, we should probably add it there. Do feel free to open an issue about it and we will fix it.
You can add Fixes: https://github.com/openshift/sriov-network-operator/issues/647 to this PR.

Hi and thank you for reviewing,
test/scripts/enable-kargs_test.sh contains a few test for the enable-kargs.sh script, mocking out (and then giving it as working) rpm-ostree and chroot.
As the script is not trivial (regexp through loops inside nested if-statements), I thought a sort of automated testing would have been useful, but it's also true that they came out quite complicated as well (otherwise, you would have got the point).
So, I can leave the script changes and get rid of tests if you think they aren't worth the effort.

If you're testing your script then that's fine and completely up to you. I though you were testing rpm-ostree and that did not make a lot of sense.

nit: please split the tests into a separate commit.

LGTM

/lgtm
@adrianchiris can we merge this one?


Incorrect signature for Exception#initialize

Input
→ View on sorbet.run
# typed: true

StandardError.new(:a_symbol)

Observed output
editor.rb:3: Expected T.nilable(String) but found Symbol(:"a_symbol") for argument arg0 https://srb.help/7002
     3 |StandardError.new(:a_symbol)
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    https://github.com/sorbet/sorbet/tree/master/rbi/core/exception.rbi#L172: Method Exception#initialize has specified arg0 as T.nilable(String)
     172 |        arg0: T.any(String, NilClass),
                  ^^^^
  Got Symbol(:"a_symbol") originating from:
    editor.rb:3:
     3 |StandardError.new(:a_symbol)
                          ^^^^^^^^^
Errors: 1

Expected behavior
irb(main):041:0> StandardError.new(:asdf)
=> #<StandardError: asdf>

I suspect there is an implicit string conversion. The solution may be just that: changing the sig to accept T.nilable(String, Symbol).

Exception#initialize technically accepts anything that implements to_s, so it's arguably an even broader type than that:
irb(main):001:0> Exception.new(5)
=> #<Exception: 5>
irb(main):002:0> Exception.new(true)
=> #<Exception: true>
irb(main):003:0> Exception.new(->(x) { x + 1 })
=> #<Exception: #<Proc:0x00007fc32f952438@(irb):3 (lambda)>>

I don't think we necessarily want to allow all of those, though: even though Ruby would accept them at runtime, I think many programmers (myself included!) would want to be warned if I was accidentally passing a lambda instead of something more sensible to Exception.new.

https://sorbet.org/docs/faq#it-looks-like-sorbet-s-types-for-the-stdlib-are-wrong


[cudapoa] adding PO-PO alignment

the current cudaPOA is mainly based on original POA algorithm [POA 2002]. Same author in  another paper [POA 2004] proposes an extension of the algorithm that allows aligning POA graphs to each other.
This extension is useful for polishing and MSA applications. It can increase cudaPOA parallelism and help to improve performance of MSA/consensus problems for a single window with large number of sequences.

when aligning PO graph to another PO graph, the workload between different threads in a warp can vary and the computation can potentially take many different branches. This behavior has detrimental effect on kernel performance. A better approach may be trying simpler and lighter alignment algorithms such as SPARC.


Revert "chore Apply uninitialized variables check of clang-tidy"

Reverts apache/doris#23497

run buildall


pythonPackages.mpi4py: 3.1.6-unstable-2024-07-08 -> 4.0.1

See https://github.com/mpi4py/mpi4py/releases
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Commit message prefix doesn't trigger building by ofborg:
@ofborg build python312Packages.mpi4py python311Packages.mpi4py

@doronbehar looks good?

Yes! Sorry for forgetting to officially approve, just wanted to see that no regressions are observed on any platform.


Fix notebook issue when creating Kusto notebooks 2nd time after launching ADS

This PR fixes #
Currently, notebooks doesn't work properly (query and intellisense part) for Kusto clusters after opening first notebook from the Kusto database right click option. This was happening because "Kusto" was getting removed from the list of connectionProvidersIds after loading correct Kusto notebook for the first time, so it was getting default sql config.

Can you please add a more descriptive title 😄

Pull Request Test Coverage Report for Build 283071075

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.003%) to 39.606%

Totals

Change from base Build 282802757:
0.003%

Covered Lines:
19920

Relevant Lines:
45955

💛  - Coveralls


List of Operating System Codes Incorrect

I think some of the codes listed in the "List of Operating System Codes" section might be incorrect.
I tried using Windows_v100_X86_* codes but getting an error back:
{
"error": {
"code": "invalidInput",
"message": "Validation Failed.",
"validationErrors": [
{
"target": "requestedSignatures",
"message": "The OS code WINDOWS_v100_X86_TH2_FULL is invalid."
},
{
"target": "requestedSignatures",
"message": "The OS code WINDOWS_v100_X86_RS1_FULL is invalid."
},
{
"target": "requestedSignatures",
"message": "The OS code WINDOWS_v100_X86_RS2_FULL is invalid."
},
{
"target": "requestedSignatures",
"message": "The OS code WINDOWS_v100_X86_RS3_FULL is invalid."
},
{
"target": "requestedSignatures",
"message": "The OS code WINDOWS_v100_X86_RS4_FULL is invalid."
}
]
}
}
Looks like the X86 shouldn't be in there.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 1c20769b-d969-a51a-4eb3-f9cc27875f28
Version Independent ID: 853fe2a9-d654-98a3-7635-c30a450cdbdc
Content: Get product data
Content Source: windows-driver-docs-pr/dashboard/get-product-data.md
Product: windows-hardware
GitHub Login: @balapv
Microsoft Alias: balapv

@Scott1, thanks for letting us know about this. I'll get the documentation updated soon.
@balapv, @SillyKeith, do you know if we should remove these x86 entries?


rage: skip check if not x86

Motivation for this change
This package was failing to build on aarch64 because a development dependency in the check phase is x86 only.
Things done
Set doCheck = true only for x86 systems.

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Should I fix the stdenv.lib warnings? And if so: how?

Should I fix the stdenv.lib warnings? And if so: how?

@ofborg eval

@ofborg eval


Empower Application form to suggest existing tags based on characters being typed

What would you like to be added:
Like other services, it's nice to enter multiple tags by delimiting them by spaces.
It would also be helpful if it could suggest existing tags based on characters being typed. But we don't have any search engine for Tags so it's a bit difficult to fuzzy search currently. But the number of tags is more likely to be less.
One way that we can apply to the current architecture is letting client fuzzy search, like:

Store tags in Datastore (ProjectId, Tag)
Fetch all tags related to the logged-in project when calling ListApplications
The web client does fuzzy search when entering tags

Ideal:

Why is this needed:

This is exactly what happened to the Environment model. Firstly, we thought that the environment ID should be some kind of "ProjectName + EnvName" for easy handling. But after all, it turned to be a UUID and the EnvName is just some kind of "display" name to make it easy to update the name.
I think the Tag model can be the same as the Environment model. Using UUID for the ID and the name is just a display name (could be updated, or could be duplicated). Of course, the same display name is not good and we can do a loose check to avoid using the same name when a new tag is created or updated but after all, users have to ensure that uniqueness.

I think it would be nice if in the future this "Tag" model can also be used to replace our Environment model. The Environment is just a sub-set of Tag functionality since promoting features seems to not depend on that Environment.
Btw, I am still considering which is better "Label" or "Tag". (Tag could be a Label with empty key)
(Sorry for bringing the old topic to this again but it came up to me after thinking about removing the Environment model in the future. 🤣 )

@nghialv

Of course, the same display name is not good and we can do a loose check to avoid using the same name when a new tag is created or updated but after all, users have to ensure that uniqueness.

Yeah, if you think about it, when you create/update tags, you need to query the Datastore for the number of tags with the specified name, but if you limit the number of tags, this will work fine.
One thing that I was worried about is the time when disabling tags. Keeping uniqueness with disabled tags will confuse us.
But this can also be simplified by using deleted instead of disabled, so that it cannot be restored once a tag is deleted.

this "Tag" model can also be used to replace our Environment model. The Environment is just a sub-set of Tag functionality

Agree with it.

Sorry for bringing the old topic to this again

No, it's definitely worth considering. In the case of replacement Environment, using Labe (key: value) isn't bad. Let me think more about it.

We settled on defining them in the application configuration so now we don't have to pay attention to this suggestion stuff on the web.
For labeling I opened a new issue https://github.com/pipe-cd/pipe/issues/2750, so let me close this.
/close


[Feature]: Picture element on template cards

Is your feature request related to a problem?
No problem at all
Describe the solution you'd like
I would like to use a picture element on a template card instead of an icon
Describe alternatives you've considered
No response
Additional context
Now that badges were implemented on template cards one use case would be the picture of a person and in the badge an icon of the room where that person is

Duplicate #457
There is already an feature request for this


Provide option to expose id_token when using OpenID connect extension

Closing - stale, no responses, and really is out-of-scope.


Fix base_synthesizer.py, test_generator branch condition

Improper branch condition.
Without 'greater than or equal to', statement is never True.
This is equivalent to the following:
async def test_generator(output_bytes):
            for i in range(0, len(data), chunk_size):
                if i + chunk_size >= len(output_bytes):
                    yield output_bytes[i:], True
                else:
                    yield output_bytes[i:i+chunk_size], False

Additionally, instead of using a branch condition, we can take advantage of function definitions.
async def test_generator(data: bytes, chunk_size: int):
    total_length = len(data)
    for i in range(0, total_length, chunk_size):
        is_last_chunk = i + chunk_size >= total_length
        yield data[i:i+chunk_size], is_last_chunk

This is more succinct but less obvious.

The logic here is fine.
However I don't see is_last_chunk actually being referenced anywhere else except as a definition.
This can either be closed or merged with probably minimal side-effects.

Closing because I don't think the change is cosmetic since the value doesn't seem to be used.


Terminus Project Config File

I'm not sure if this would be used by others or not, but I have often found myself wanting a config file for terminus to set some default values. The idea is that this would be similar to the WP-CLI wp-cli.yaml file.
I've currently implemented a really rough version of this in a fork. Terminus searches current directory and up for a .terminus file, checks if valid JSON is found, and then either returns a value specified by a passed key or the entire parsed env object.
Right now, I've just implemented it for the site arg. So instead of terminus site <subcmd> --site=mysite, I can drop a .terminus in my project root with
{
  "site": "mysite"
}

and then terminus site <subcmd> will assume --site=mysite if no site value is explicitly passed in.
Let me know if you think this would be helpful and I'll look at building some functional tests for it (unfortunately writing these is a little new to me) and get a PR going.

Hi, @loganyott. We just added the ability to include some arguments by putting them into the environment. There's --site (TERMINUS_SITE), --org (TERMINUS_ORG), --env (TERMINUS_ENV), and the user (TERMINUS_USER). You can choose to load them yourself, or add them to a .env file in whichever directory you choose to invoke Terminus from and Terminus will load them for you. I hope this helps!

Super cool :+1: ! Thanks for following up and letting me know it's been implemented.

I'll try to find an appropriate place but I found it worthy of noting that I don't think this is in the docs anywhere. I had to find this issue to remember which ENV variables to use. I would be happy to hear that I am wrong though! :D


Show more detailed information for freeze transactions

Freeze transactions are missing a lot of details when displayed via the hedera mirror node explorer.
An example of this would be to look at recent transactions involving the system account 0.0.58, which sends the network freeze transactions used for hedera network updates. Here's a recent transaction:
https://hashscan.io/#/mainnet/transaction/0.0.58-1666108200-000000000?t=1666108207.058922003
Although the transaction itself is displayed, information such as what kind of freeze it is, the associated time (when applicable), etc. are not shown.

Mirror node returns a generic description of transactions no matter its type (see below).
I don’t think there is any plan to add transaction type specific info.
But if it happens, Explorer will display this info.
https://hashscan.io/#/mainnet/transaction/0.0.58-1666108200-000000000?t=1666108207.058922003
{
    "transactions": [
        {
            "bytes": null,
            "charged_tx_fee": 0,
            "consensus_timestamp": "1666108207.058922003",
            "entity_id": null,
            "max_fee": "500000000",
            "memo_base64": "",
            "name": "FREEZE",
            "node": "0.0.4",
            "nonce": 0,
            "parent_consensus_timestamp": null,
            "result": "SUCCESS",
            "scheduled": false,
            "transaction_hash": "pMwCbd6mJzqOjgCgocVKa3LuAGjn7Qj1YizTzWPf7IyT/O74/fk/HLomRb5DABkW",
            "transaction_id": "0.0.58-1666108200-000000000",
            "transfers": [],
            "valid_duration_seconds": "120",
            "valid_start_timestamp": "1666108200.000000000"
        }
    ]
}

Moreover, we don't even store full freeze information currently.


Limit log filename length

Fixes #31

btw do the existing tests fail on ecryptfs?

btw do the existing tests fail on ecryptfs?

Oh, I guess the integration tests probably create files in /tmp, which might not be in ecryptfs, but actual use will write into ~/whatever which is.

Thanks for proposing this. Thinking about it, I think it's simpler just to use shorter names in the first place, so I've done that in the upcoming 0.2.4.


Add 'related guides' component to guides

Helpful for navigating pages. These can simply be populated manually.

i think the easiest way to do this is to train an RNN on the titles and contents of our articles and spend $1000 ish on hosting a service on google cloud platform that runs it, then call that api in our files. wdyt @Zmwang622

jk. i think a good way to do this is in the frontmatter, add related_guides and have it be an array of the slugs of the other courses
the only problem is if we move around and rename things, then it might mess things up
however we can fix that with #123

decided not worth. to add code for this, if certain pages have related guides, they can just be added at the bottom like
## Related Guides
1.  [jawn](/jawn)
2.  [jawn](/jawn)
3. [jawn](/jawn)

changed my mind, dont think this is worth closing

what would be some examples of guides and their related guides?

any guide on majors, minors would be related to the schedluing guide. Zero to Offer guides related to each other etc


Use voice dictation to compose emails

It would be very helpful in certain cases if you could compose emails using your voice (i.e: while driving, typing on a keyboard or using a pencil)

Maybe Kõnele can be useful?

This can be done by installing an appropriate keyboard (e.g. enabling Google voice). There's no need for K-9 changes.