HADOOP-16907. Update Netty to 4.1.46Final.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
44m 54s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
29m 36s
trunk passed

+1 :green_heart:
compile
0m 19s
trunk passed

+1 :green_heart:
mvnsite
0m 20s
trunk passed

+1 :green_heart:
shadedclient
47m  6s
branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 17s
trunk passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 11s
the patch passed

+1 :green_heart:
compile
0m 10s
the patch passed

+1 :green_heart:
javac
0m 10s
the patch passed

+1 :green_heart:
mvnsite
0m 14s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  1s
The patch has no ill-formed XML file.

+1 :green_heart:
shadedclient
16m 26s
patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 14s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
0m 13s
hadoop-project in the patch passed.

+1 :green_heart:
asflicense
0m 29s
The patch does not generate ASF License warnings.

112m 50s

Subsystem
Report/Notes

Docker
Client=19.03.7 Server=19.03.7 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1882/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1882

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient xml

uname
Linux 4b84cee92c81 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 4062217

Default Java
1.8.0_242

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1882/1/testReport/

Max. process+thread count
307 (vs. ulimit of 5500)

modules
C: hadoop-project U: hadoop-project

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1882/1/console

versions
git=2.7.4 maven=3.3.9

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.


Add Tizen backend

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Feature
What is the current behavior? (You can also link to an open issue here)
There is no tizen as a backend platfom of ReactiveUI
What is the new behavior (if this is a feature change)?
Tizen has been added as a backend platform  of ReactiveUI
What might this PR break?
None
Please check if the PR fulfills these requirements

[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

Other information:
This PR is a latest revision of #1387. And, this PR contains only the minumum requrirements to support Tizen. So, implementations that need to work correctly (like android, iOS), should be required through different PRs.

Coverage increased (+0.03%) to 69.619% when pulling 8beb63ab00d85446f928aad89e83d33be43bf195 on rookiejava:add-tizen into a20157d68e5c8b2a51c50c525f815ede8f31328c on reactiveui:develop.

Howdy @rookiejava thank-you so much for your contribution. I've noticed on your github profile that you have done some work on the tizen platform before. How well do you know the platform? Do you work at Samsung? We are looking for a platform lead. I'm happy to work with you, pair with you and video call with you to discuss the broader picture. Last I was aware was that .net ++ tizen was immature and it wasn't possible to actually target the platform with nuget (even though the tfm is defined) - has this changed?

@ghuntley Yes. The latest vesrion of Tizen (Tizen 4.0 M2), that offially supports .NET, was released in  the last month. For more details, see https://developer.tizen.org/tizen/release-notes/tizen-4.0-public-m2.

Coverage increased (+0.03%) to 69.619% when pulling 3201e27b626a11777531fc93215dafa1a07ffe1e on rookiejava:add-tizen into a20157d68e5c8b2a51c50c525f815ede8f31328c on reactiveui:develop.

@rookiejava and @ideallee we are looking for two people (you?!) to join the core team of ReactiveUI and help shape the future of Tizen. See https://reactiveui.net/team/ for specifics and if this is of interest to please join us over in https://reactiveui.net/slack at https://reactivex.slack.com/archives/CAK67UA7M/p1526040674000046
Tizen is something we really want to add in Splat, ReactiveUI and Akavache. Let's do it (soon - like next release?)

This branch has been updated and is almost ready for merge. I'm having some difficulties with EventGenerator and tizen.  Any help would be appreciated. Parking this for now.
Repro:

./build.cmd

src/EventBuilder/  is the code generator for src/ReactiveUI.Events/Events_TIZEN.cs

@ghuntley As for this issue, I and my colleague (@WonyoungChoi) took a look inside what happend. And we found there is a bug on EventTenplateInformation class. It seems that it doesn;t work correctly in case of genereic instance type.
https://github.com/reactiveui/ReactiveUI/blob/10b77971d2dc71b36ef051e94655c49fcc9edb8f/src/EventBuilder/Cecil/EventTemplateInformation.cs#L39-L47
According to above logic, if real type name contains kvp name ('T', 'U', 'R'), it replaced into real type name.  As a result, the below 2 cases replaced unintended.

IObservable<Tizen.NUI.UIComponents.Slider.MarkReachedEventArgs> MarkReached

MarkReachedEventArgs turned into MarkBooleaneachedEventArgs

(R => Boolean)

Observable<Tizen.NUI.ImfManager.EventReceivedEventArgs>

EventReceivedEventArg turned into EventTizen.NUI.ImfManager.EventeceivedEventArg

(R => Tizen.NUI.ImfManager.Event)

This is not a bug on only A, but everywhere.  So, I'd like to recomend
a) fix EventTemplateInformation correctly for generic instance type
b) ignore these 2 exceptional cases as for now (even if temporaily way)

I've tweaked it a little bit and build successfully.

amazeeeeeeeed folks 99% who can hit the last onwe _?

@ghuntley  could you review and merge this?

Thanks @rookiejava!


Being able to listen to pageChange event.

There isn't currently a straightforward way to allow for tracking the pageChange event.
For example, if I have 3 pages scrolling through using ParallaxPager, and I want some images to change or animation to happen once the user scrolls to the 3rd page. Since ParallaxContainer is the pageChangeEventListener and does not allow for setting a new one, it seems the only solution would be to subclass PrallaxContainer.
Is it possible to attach a pageChangeListener to ParallaxContainer instead?
Thanks!

Release 2.1.0 should be up on Maven Central shortly with a fix for this


Creating a new role with a workflow defined for Add Role operation doesn't apply workflow in console

Describe the issue:
Even if a workflow is defined for adding a role, when a new role is created using the console app, the workflow is not applied. A new role is directly created without awaiting approval.
How to reproduce:

Get the latest IS pack
Create a workflow for role add operation in the system
Create a new role using the console
Navigate to the roles list page. The fully created role will be displayed. (can verify using management console that it is not pending approval)

Role supervisor was created using console app and role supervisor2 was created using management console.

Expected behavior:
The role should not be created until approved as defined in the workflow.

This issue is being closed due to extended inactivity. Please feel free to reopen it if further attention is needed. Thank you for helping us keep the issue list relevant and focused!


Polyfill example with browserify

Can you provide a quick example of how I would use polyfills with browserify? I'm interested in the WeakMap.

Just add 6to5 to your dependencies and add:
require("6to5/polyfill");

See the docs for more info.

Also the WeakMap polyfill does not have weak references as that's something that's impossible to shim as it's an implementation detail.

True. I settled with writing a TODO comment to just use them when they are out in the wild.


Slick vertical moving from left to right?

Hi, I have this issue where I want to display the carousel vertically but I want it swapping from the left to right like it would if it was horizontal instead from bottom to top, it is possible with this plugin?

it is not

unless you wrap your slide sets in parent elements that then become the slides themselves


Basic CI Theming & Logo

Hey,
Would be awesome to be able to set the main colors of the portal as well as uploading a logo :)

This is currently no planned


feat: introduce new linear-gradient

As you know, I know UI Design more than almost everybody in the world.
This will be more beautiful than before, and this idea is admitted by ZCY.
New Style

Old Style

perfect work


Could the IV be automatically extracted from the encrypted data?

More like a question.
So this works fine:
let data = "The black knight always triumphs!".convertToData()
let key = "01234567890123456789012345678901".convertToData()
let iv = try CryptoRandom().generateData(count: 16)
let encryptedData = try AES256CBC.encrypt(data, key: key, iv: iv)

let decryptedData = try AES256CBC.decrypt(encryptedData, key: key, iv: iv)
print(decryptedData.convert(to: String.self)) // The black knight always triumphs!

Question is can I not pass in the iv as argument so it is automatically extracted from the encrypted data? As in:
let decryptedData = try AES256CBC.decrypt(encryptedData, key: key) <<--
print(decryptedData.convert(to: String.self))

Throws: ⚠ [CryptoError.cipherIVSize: Invalid cipher IV length 0 != 16.]

I'm trying to avoid having to pass the IV around as in here (relies on Apple's CommonCryto / CCCryptor).
Thanks.

No, but if you want, you could prepend the IV to the ciphertext, send/store them together, then split off the first 16 bytes when decrypting.

you seem to be doing the same thing implicitly <<-- exactly 🙃
All right, then. Thanks for confirming. 👍🏻


NX584 alarm control panel fetches data inside a property

Was just reviewing PR #3842 and discovered it was requesting data inside a property declaration. The PR said it was based on the NX584 alarm control panel so I had a look and yes, NX584 panel also does this wrong.
Fetching data from inside a property will pause all activity in the the core until the request is done. This is because the properties are called from inside the event loop (async_update_ha_state) while update is called outside of the event loop and can thus freely block.
The proper fix is to move the fetching of the data to the update method and store the state in an instance variable which will be returned in the state property.
CC @kk7ds

I will fix this as I fix PR #3842


clangd leaks pch files on crash

The PrecompiledPreamble class tries its best to clean up the file, but fails to on crash.
Crashes happen, and these files can be big.
On unix at least, we should be able to unlink the file and clone the FD (specifying ImplicitPCHInclude = /dev/fd/N) when we need to read. Then a proper leak is not possible.
That solution wouldn't help on windows, and wouldn't prevent leaks of PCHs being written when the crash occurs.

We have more reports of leaking PCH files on crash, where signal handlers aren't doing the trick.
(Possibly in an environment where our signal handlers are not being used)
I'd like to look at the unlinking suggestion again.


Infinite buffering on CC on startup, regression from 2.0.0 to 2.0.1

What version of Shaka Player are you using?
2.0.1

Can you reproduce the issue with our latest release version?
Yes, when compiled.
Can you reproduce the issue with the latest code from master?
Yes, but only when compiled.

Are you using the demo app or your own custom app?
Custom app.

If custom app, can you reproduce the issue using our demo app?
No, it seems to have to do with debug turned on / off (it's a timing issue as far as I can tell).

What did you do?

What content did you load?

If custom asset, what manifest and license server URIs?
The asset is time senstive, it only exists 48hrs after creation, so please ping me at<EMAIL_ADDRESS>and I'll give you a manifest.

How did you interact with the content, if at all?
N/A

What did you expect to happen?
The content was supposed to start, like in 2.0.0

What actually happened?
The content did not start, and when enabling some logging (not all, because then the issue did not occur - see patch
logging.diff.txt) I could tell that it got stuck in some sort of buffering loop.
It doesn't actually buffer more than expected, it's just that when it is done buffering, it doesn't start playing.
So it doesn't properly detect that it's done buffering, I guess.

I bisected the repo and it seems to me like 4a608ad10c272f36e8f4e57e5ab63e45f82f6e00 is the commit that introduced this regression.
I'm more than happy to help with more info.

@johanhil, can you please test something for me?  I have been working on a bug today that may be related.
In lib/media/playhead.js, in the constructor, change this.startWatchdogTimer_() to this.onWatchdogTimer_().  I expect this will make the bug more reproducible, even with logging.  Please let me know if this is the case.  If so, I should have a fix out soon.

I believe this was fixed by 84fb9d42.  If not, please let me know and we can reopen and investigate.


Refactor selections

Selections for the longest time has simply been a source-range with some metadata about what the selection is. this seemed like a neat idea at first but it make sense to use artifacts from our artifactGraph instead.
How selections should work and what the refactor should look like is covered in
https://docs.google.com/document/d/16EROjbvGZnBg7Y43yaA36mS4SkC8Cxpm2gpZ1mY2UJo/edit#heading=h.z6ie6kxdgixv

[x] Create the types of the new types
[ ] Implement convertSelectionToOld and convertSelectionsToOld as utils to help with the refactor
[ ] Update Xstate context to use the new types, this will require all the places that consume the types to use the convertSelectionToOld etc utils, though consider converting some of them to use the new types directly if that's easier.

This is what we're aiming for

The "find artifactthat matches sourceRange and type" should be able to use the existing codeToIdSelections function.
The types for the first task has been setup already https://github.com/KittyCAD/modeling-app/pull/3836 note that
export type Selections = {
  otherSelections: Axis[]
  graphSelections: Artifact[]
}

maybe should be
export type Selections = {
  otherSelections: Axis[]
  graphSelections: ArtifactId
}

Instead not sure if one is better than the other.

From the diagram, don't take id too seriously, like in some of those arrows it might be Artifact that is passed around, so long as the id is on the Artifact we good.


Add St. Bonaventure University domain

School Website: https://www.sbu.edu
School email<EMAIL_ADDRESS>

@boraytuna Thank you for your patience while waiting for a review and processing your request. Pull request merged. Please start applying for JetBrains educational subscription at https://www.jetbrains.com/shop/eform/students in an hour, to allow the changes to propagate through JetBrains systems.


fix: containerfiles now are building local code

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 16.28%. Comparing base (8f9ec29) to head (8ce5b4a).
Report is 3 commits behind head on main.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1063   +/-   ##
=======================================
  Coverage   16.28%   16.28%
=======================================
  Files         112      112
  Lines       19771    19771
=======================================
  Hits         3220     3220
  Misses      16267    16267
  Partials      284      284

Flag
Coverage Δ

unittests
16.28% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Create FizzBuzz_one_liner.py

My attempt on FizzBuzz creative solution by making the code one liner.

nice! thanks


dartdoc fails when "call" is declared as a static method?

This issue was originally filed by<EMAIL_ADDRESS>
What steps will reproduce the problem?
1.
class Foo{
   static void call(String bar){ ...}
}

Generate docs.

What is the expected output? What do you see instead?
dartdoc appears to fail on this, at least on dartdocs.org.
Oct 29 23:34:16 b-f7a1dd1bc41d1ac4e9b3409cd693f startupscript: docgen [--compile, --no-include-sdk, --no-include-dependent-packages, --out, docs, --sdk, /dart-sdk, --package-root, ./packages, .]
Oct 29 23:34:19 b-f7a1dd1bc41d1ac4e9b3409cd693f startupscript: Using default options for documenting a single package: --start-page=hakk_builder
Oct 29 23:34:19 b-f7a1dd1bc41d1ac4e9b3409cd693f startupscript: Package Root: ./packages
Oct 29 23:34:19 b-f7a1dd1bc41d1ac4e9b3409cd693f startupscript: Added to libraries: ./lib/basic.dart
Oct 29 23:34:19 b-f7a1dd1bc41d1ac4e9b3409cd693f startupscript: Added to libraries: ./lib/advanced.dart
Oct 29 23:34:19 b-f7a1dd1bc41d1ac4e9b3409cd693f startupscript: Added to libraries: ./lib/lang.dart
Oct 29 23:34:19 b-f7a1dd1bc41d1ac4e9b3409cd693f startupscript: SDK Root: /dart-sdk
Oct 29 23:34:19 b-f7a1dd1bc41d1ac4e9b3409cd693f startupscript: lib/src/advanced/instructions.dart:690:15:
Oct 29 23:34:19 b-f7a1dd1bc41d1ac4e9b3409cd693f startupscript: Error: Static member cannot override instance member 'call' of 'I'.
Oct 29 23:34:19 b-f7a1dd1bc41d1ac4e9b3409cd693f startupscript:   static void call(String callName){
Oct 29 23:34:19 b-f7a1dd1bc41d1ac4e9b3409cd693f startupscript:               ^^^^
Oct 29 23:34:19 b-f7a1dd1bc41d1ac4e9b3409cd693f startupscript: lib/src/advanced/instructions.dart:690:15:
Oct 29 23:34:19 b-f7a1dd1bc41d1ac4e9b3409cd693f startupscript: Info: This is the instance member that cannot be overridden by a static member.
Oct 29 23:34:19 b-f7a1dd1bc41d1ac4e9b3409cd693f startupscript:   static void call(String callName){
Oct 29 23:34:19 b-f7a1dd1bc41d1ac4e9b3409cd693f startupscript:               ^^^^
Oct 29 23:34:19 b-f7a1dd1bc41d1ac4e9b3409cd693f startupscript: Error: Failed to create mirror system.
What version of the product are you using?
1.7.2 stable
On what operating system?
Windows/Linux
What browser (if applicable)?
n/a
Please provide any additional information below.
I get no static warnings or errors when using "call" as a static method.
I get no runtime errors either, works fine.

Mirrors is no longer supported in Dart2JS.


update-bcd: null is not replaced with false

This seems to have been introduced in the last update, most likely.  If BCD has the version set to null, but the collector determines false, it does not appear to overwrite null.

CC @foolip @mzgoddard

@queengooborg do you mean this is a likely regression? Can this be reproduced using current results in https://github.com/openwebdocs/mdn-bcd-results and for which BCD path?

Yes, this is a regression.  This can be reproduced easiest with the add-new-bcd script.  In any feature added that a browser doesn't support, the default null value is left instead of being replaced with false.  The HTMLElement constructor that is being added is a great demonstration of this:

Update: after making some tweaks to enable verbosity, it appears that this is an issue with the logic for hasSupportUpdates.  I'm getting a warning that updates were skipped because the support matrix matches current BCD support data, but that's not accurate if BCD says null and we know it should be false.
I don't know the new version of the update-bcd script well enough to be able to fix this. 😞

I'll take a look at this.

I'm sorry it took me this long, but I finally made the time to debug this and make a fix: https://github.com/openwebdocs/mdn-bcd-collector/pull/1473


Project Restructure

Description
Restructuring project structure to model typical maven multi-module setup and adding a few build utilities for collecting test coverage reports in SonarQube.
Related to NIM-17228
Overview of Changes

Removed /nimbus-parentdirectory.
Moved nimbus-parent/pom.xml from /nimbus-parent to the project's root directory.
Moved nimbus-parent/post/pom.xml to /nimbus-entity-dsl directory.
Added nimbus-test as a module to nimbus-parent.
Added Maven profile ("sonar") for generating sonar results

Sonar reports can now be executed using mvn clean verify sonar:sonar -P sonar

Updated ./build-projects.sh to support the previous changes.

Type of change

[ ] New feature (non-breaking change which adds functionality)

How Has This Been Tested?
All test cases are passing and sonar reports with test case coverage reflecting in the SonarQube UI. The Petclinic application is running with no issues after this change.
Additional Notes
Refrained from adding nimbus-ui as a module to the nimbus-parent artifact.

You did it @lopezton-anthem!
Thank you for signing the Anthem Opensource Software CLA.


Remove the version constraint for pytorch_lightning.

The latest pytorch_lightning (v<IP_ADDRESS>) has fixed the import problem, so we can remove the temporary patch introduced by #672.

LGTM!


Undo mjs build

Undoes mjs build setup in 3.0.0-2 which doesn't seem to work correctly. This can be installed as version 3.0.0-3

Codecov Report

Merging #486 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master   #486   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files           1      1
  Lines          21     21
=====================================
  Hits           21     21

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 736cebe...6feb040. Read the comment docs.

Haven't had time to test this across different build setups but going to leave this open until I have time to dig in

@jxnblk Could you tell me what exactly didn't work? Your way doesn't solve the problem of /emotion.

Ah, I see.


Add a caption_id to coco_gen dataset

I added a caption_id to the *.tfrecord files. The caption_id is the id field in the captions_source.tsv.
The caption_id will be used as the filename for the image generated by the mobile app.
With a caption_id in filename we can calculate any metrics (e.g. IQA-A) offline and map it with the spreadsheet for analytic purpose.

Relevant files are here:
https://github.com/anhappdev/tmp/releases/tag/6

@mohitmundhragithub to test it and report if it's OK.

This PR seems to be working fine.
@anhappdev  do you want to udpate the link for the dataset for the test dataset as well?


Unified Datastore

Looking over the packages we have:

[breadboard] a Datastore, which we use to keep blobs around.
[visual-editor] inputs from a previous run
[visual-editor] inputs from the settings

It feels like these should be unified in some way. Some questions:

Should the Datastore be part of Breadboard, or just the types? It's currently an in-memory store, which makes sense when it's running in node and doesn't have – say – IDB access. But then again we could have a distinct datastore package which opts for the right implementation based on the capabilities it detects? It feels like it could be a hefty piece of code, with multiple implementations, so that's why I'm wondering if we should have it in its own separate package.
Should we expand it to include inputs and secrets? When we start a session we could create a new Datastore for that session and seed it with inputs & secrets at that point. That could be fed from an .env file for node, or through its API when run in the Visual Editor.
Should we collapse the context stuff in the Visual Editor? It feels like the for await loop at the top level is the right point to intercept the answer and store values, as well as provide known inputs & secrets when calling into the UI with the newest node.

@dglazkov wdyt?

Also feels related to #1474 in providing a view to folks to see what the stored values are and allow them to choose those in some way when launching the standalone Component Runner.

Should the Datastore be part of Breadboard, or just the types?

My intuition is that it's just the types, similar to GraphProvider. There can be multiple implementations: IDB definitely, but also board server-based one, where the blobs are literally stored on the server. Should it be a separate package? Yes, and maybe multiple different ones -- or at least implementations in different packages. The IDB-based in visual editor, GCP bucket-based in board-server, etc.
Oooh.... For File System API, we might store the data right next to the boards.

2. Should we expand it to include inputs and secrets?

Yes, that sounds right, too.

3. Should we collapse the context stuff in the Visual Editor?

Yeah, probably.

There's a very rudimentary mechanism that resembles garbage collection generations, called "groups".
Basically, at the beginning of observing a run, we call the startGroup and call endGroup at the end. This is supposed to mark the beginning and the end of all resources that were stored using the data store -- or put differently, all resources associated with this run.
The endGroup returns an opaque identifier (currently a number), which serves as a way to identify this group of resources.
When we no longer need resources from a run (for example, when we discard it), we can call store.releaseGroup(id) and release all the blobs associated with this run.
This serves another purpose: when we want to serialize a run, we can call store.serializeGroup(id) and get a nice array of properly inflated resources associated with the run.
It's super-hacky. But it kind of works. Except for #2528, where it works against us. When we release previous run, we also release the inputs from it -- and so the blobs associated with them disappear.


[BUG] Update docs to include ClientCertificateCredential in EnvironmentCredential

Here: https://github.com/Azure/azure-sdk-for-net/blob/f75a67b7ca8575dd1041b0bfdad6235f4b2c0413/sdk/identity/Azure.Identity/src/EnvironmentCredential.cs#L25
Doesn't include ClientCertificateCredential
Here: https://github.com/Azure/azure-sdk-for-net/blob/f75a67b7ca8575dd1041b0bfdad6235f4b2c0413/sdk/identity/Azure.Identity/src/EnvironmentCredential.cs#L78
Includes it.
azsdke2e
azsdke2e2

Thank you @christothes!


Add typehints for DDPPlugin across accelerators

What does this PR do?

Add/fix typehints for DDPPlugin across accelerators for better typechecking + IDE experience
consistent formatting across changed files

Before submitting

[ ] Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
[x] Did you read the contributor guideline, Pull Request section?
[x] Did you make sure your PR does only one thing, instead of bundling different changes together? Otherwise, we ask you to create a separate PR for every change.
[ ] Did you make sure to update the documentation with your changes?
[ ] Did you write any new necessary tests?
[x] Did you verify new and existing tests pass locally with your changes?
[ ] If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

[x] Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃

Hello @ananthsub! Thanks for opening this PR.

In the file pytorch_lightning/accelerators/ddp_accelerator.py:

Line 129:17: W503 line break before binary operator

In the file pytorch_lightning/accelerators/ddp_cpu_slurm_accelerator.py:

Line 124:13: W503 line break before binary operator

In the file pytorch_lightning/accelerators/ddp_cpu_torchelastic_accelerator.py:

Line 124:13: W503 line break before binary operator

In the file pytorch_lightning/accelerators/ddp_slurm_accelerator.py:

Line 131:13: W503 line break before binary operator

In the file pytorch_lightning/accelerators/ddp_spawn_accelerator.py:

Line 256:17: W503 line break before binary operator
Line 257:17: W503 line break before binary operator

In the file pytorch_lightning/accelerators/ddp_torchelastic_accelerator.py:

Line 126:13: W503 line break before binary operator

Do see the Hitchhiker's guide to code style

@ananthsub as it is a feature I am changing the target branch to feat 1.2, mind rebase pr and resolve conflicts? Thx your contribution and feel free to ping us back if you need something or need some help... 🐰

@ananthsub as it is a feature I am changing the target branch to feat 1.2, mind rebase pr and resolve conflicts? Thx your contribution and feel free to ping us back if you need something or need some help... 🐰


Add more specific errors to CopyModerators command

Part of the effort to improve error messages. I hate that it is a pile of try/catch but I wasn't sure how else to give more specific information about where things are failing. Suggestions welcome.

Merged #196 into main, thanks for the review!


Make IDocumentTypeFeature public

Enables #1209

Hi @twsouthwick
A question for my understanding.
Why are you replacing System.Enum with Struct?
Here's the enums for SpreadsheetDocumentType:
https://learn.microsoft.com/en-us/dotnet/api/documentformat.openxml.spreadsheetdocumenttype?view=openxml-2.8.1
Are they obsolete now?

It's future proofing. I'm thinking about a generalized document type to help with packages in general - the constraint just means that we aren't limited to using an enum, but any struct.

@Asbjoedt this is now merged into the v3.0.0 version. There is a CI feed available to try this out: https://openxmlsdk.blob.core.windows.net/feed/index.json


The baseDomains/subDomains separation is a bit confusing

I feel like the baseDomains/subDomains separation is kind of confusing. I'm sure there's a good reason for it and it helps separating host configuration and modules, but It's hard to really understand without some example modules. The naming doesn't really help either because subDomains are not sub domains of baseDomains. I don't really have any better suggestions though. At least not without looking at some examples and understanding the intention better.
Imo the UX could also be improved a bit for people who don't write reusable modules for their host setups. At the moment it requires me to define all my domains twice, so I added this hack to my config:
config.networking.domains.subDomains = mapAttrs
  (_: _: mkDefault { })
  config.networking.domains.baseDomains;

I'm not sure whether that's a good idea or not, because I don't really understand the intent well enough.
Great module otherwise, by the way!

feel like the baseDomains/subDomains separation is kind of confusing.

I wouldn't say that's case but the naming might make it confusing.
Should have probably used something else, but now i'ts a bit too late since it would break existing configs.

The naming doesn't really help either because subDomains are not sub domains of baseDomains

Can you elaborate a bit on that part?

Imo the UX could also be improved a bit for people who don't write reusable modules for their host setups. At the moment it requires me to define all my domains twice, so I added this hack to my config:
config.networking.domains.subDomains = mapAttrs
(_: _: mkDefault { })
config.networking.domains.baseDomains;

this seems a bit much.
So the way it's intended to be used is in baseDomains you basically "register" which zone apexs are available to the host.
This can be multiple domains like example.com, example.org, my.domain.invalid.
Any record you set here gets propagated into networking.domains.subDomains that match there base domain.
Let's say your basedomains look like this:
  networking.domains = {
    "example.org" = {};
    "example.com" = {};
    "subdomain.example.com" = {};
  };

Then you will end up with two zone files, example.com and example.org.
And then in networking.domains.subDomains you add any subDomains.
Hope this helps clearing the confusion a bit.
Maybe adding something like networking.domains.zones would help which could then behave like the extraConfig module?

Great module otherwise, by the way!

Thank you <3

Today I gave this another shot on a new host and it just clicked. The record inheritance feels a bit magical, but it's convenient for sure. Thanks!


useLocalStorage fails to set state if user browser blocks localStorage

It would be nice if it could fallback more gracefully.
For now, I just copied useLocalStorage code and added that inside error catch:
        const newValue = value instanceof Function ? value(storedValue) : value
        setStoredValue(newValue)

Hi, it should be fixed by #439


fix: modules export

more info here
https://www.typescriptlang.org/docs/handbook/modules/reference.html#node16-nodenext
https://nodejs.org/api/packages.html
https://webpack.js.org/guides/package-exports/

Thanks for PR!


Error restoring checkpoint: BeamSearchDecoder

System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow): Yes
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Windows7, CPU
Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device: NA
TensorFlow installed from (source or binary): pip
TensorFlow version (use command below): tf.VERSION = 1.10.0|tf.GIT_VERSION = b'v1.10.0-rc1-19-g656e7a2b34'| tf.COMPILER_VERSION = b'v1.10.0-rc1-19-g656e7a2b34'
Python version: Python 3.5.5
Bazel version (if compiling from source): NA
GCC/Compiler version (if compiling from source): NA
CUDA/cuDNN version: NA
GPU model and memory: NA
Exact command to reproduce: NA

Describe the problem
I am trying to load a model trained using basic decoder with train_ce=True and loading it with beamsearch with train_ws=True (like inference) but it fails during restore:
Traceback (most recent call last):
  File "train_ws.py", line 502, in <module>
    tf.app.run()
  File "C:\ProgramData\Miniconda3\envs\tensorflow\lib\site-packages\tensorflow\python\platform\app.py", line 125, in run
    _sys.exit(main(argv))
  File "train_ws.py", line 337, in main
    saver.restore(sess, FLAGS.restore_path)
  File "C:\ProgramData\Miniconda3\envs\tensorflow\lib\site-packages\tensorflow\python\training\saver.py", line 1759, in restore
    err, "a mismatch between the current graph and the graph")
tensorflow.python.framework.errors_impl.InvalidArgumentError: Restoring from checkpoint failed. This is most likely due to a mismatch between the current graph and the graph from the checkpoint. Please ensure that you have not altered the graph expected based on the checkpoint. Original error:

Input 1 of node decoder/dynamic_decoder_out/decoder/while/Merge_7_1 was passed float from decoder/dynamic_decoder_out/decoder/while/NextIteration_7:0 incompatible with expected int32.

Source code
def inference_s2s_ce(self, encoder_inputs, decoder_inputs, encoder_inputs_lenghts, decoder_inputs_lenghts, feed_previous):
    true_batch_size = tf.size(encoder_inputs_lenghts)
    encoder_outputs, encoder_state = self.input_encoder(encoder_inputs)
    print('encoder_state ', encoder_state)
    attention_inputs = encoder_outputs # Not time major
    #encoder_outputs = tf.transpose(encoder_outputs, [1, 0, 2]) # time major
    if self.mode == 'train_ws':
        attention_inputs = tf.contrib.seq2seq.tile_batch(encoder_outputs, multiplier=self.beam_width)
        encoder_state = tf.contrib.seq2seq.tile_batch(encoder_state, multiplier=self.beam_width)
        encoder_inputs_lenghts = tf.contrib.seq2seq.tile_batch(encoder_inputs_lenghts, multiplier=self.beam_width)
    with tf.variable_scope('decoder', reuse=tf.AUTO_REUSE) as scope:
        decoder_cell = tf.contrib.rnn.LSTMCell(self.rnn_size,state_is_tuple=True)
        embedding_decoder = variable_scope.get_variable("embedding_decoder", [self.tgt_vocab_size, self.decoder_embedding_size])
        decoder_emb_inp = tf.nn.embedding_lookup(embedding_decoder, decoder_inputs)
        input_layer = Dense(self.rnn_size, dtype=self.dtype, name='input_projection')
        decoder_emb_inp = input_layer(decoder_emb_inp)
        attention_mechanism = tf.contrib.seq2seq.BahdanauAttention( num_units=self.rnn_size, memory=attention_inputs,
        memory_sequence_length=encoder_inputs_lenghts)
        attn_cell = tf.contrib.seq2seq.AttentionWrapper(decoder_cell, attention_mechanism)#, attention_layer_size= self.num_units / 2)
        projection_layer = tf.layers.Dense(self.tgt_vocab_size, use_bias=False)
        if self.mode == 'train_ce':
            helper = tf.contrib.seq2seq.TrainingHelper(decoder_emb_inp, decoder_inputs_lenghts)#,  time_major=False)
            decoder_initial_state = attn_cell.zero_state(true_batch_size, dtype=tf.float32).clone(cell_state=encoder_state)
            decoder = tf.contrib.seq2seq.BasicDecoder(
                cell=attn_cell, helper=helper,
                initial_state=decoder_initial_state,
                output_layer=projection_layer)
            inference_decoder = decoder
        elif self.mode == 'train_ws':
            tgt_sos_id = 3
            tgt_eos_id = 1
            start_tokens = tf.tile(tf.constant([tgt_sos_id], dtype=tf.int32), [true_batch_size])
            batch_size = true_batch_size * self.beam_width#tf.cast(true_batch_size * self.beam_width, dtype=tf.int32)
            decoder_initial_state = attn_cell.zero_state(batch_size, tf.float32).clone(cell_state=encoder_state)
            print('decoder_initial_state shape ', decoder_initial_state)
            decoder = tf.contrib.seq2seq.BeamSearchDecoder(cell = attn_cell, embedding=embedding_decoder, start_tokens=start_tokens,
            end_token=tgt_eos_id, initial_state=decoder_initial_state, beam_width=int(self.beam_width), output_layer=projection_layer)
            inference_decoder = decoder
        with tf.variable_scope('dynamic_decoder_out', reuse=tf.AUTO_REUSE) as scope:
            outputs, _, _ = seq2seq.dynamic_decode(decoder=inference_decoder,output_time_major=False,maximum_iterations=self.output_max_length)
            if self.mode == 'train_ce':
                logits = outputs.rnn_output
                print('Logits ', logits.get_shape())
                return logits
            elif self.mode == 'train_ws':
                return outputs.beam_search_decoder_output.scores

I have tried restoring basicdecoder, that works.

Thank you for your post. We noticed you have not filled out the following field in the issue template. Could you update them if they are relevant in your case, or leave them as N/A? Thanks.
Have I written custom code
OS Platform and Distribution
TensorFlow installed from
Bazel version
CUDA/cuDNN version
GPU model and memory
Exact command to reproduce
Mobile device

Updated the system info and added NA in fields which were skipped.

This question is better asked on StackOverflow since it is not a bug or feature request. There is also a larger community that reads questions there.
If you think we've misinterpreted a bug, please comment again with a clear explanation, as well as all of the information requested in the issue template. Thanks!


About the degeneracy check

Thank you for the great work!
I am trying to understand the degeneracy check (and updating F) part of the code, but the C code seems to be really hard to decipher. So I want to ask do you have the MATLAB code for the degeneracy part (which appears in the C source code)? Or other instructions on implementing the degeneracy part could also help.
Thanks for your time and looking forward to your reply.

You can check probably more human-friendly implementation in OpenCV by @ivashmak
https://github.com/opencv/opencv/blob/master/modules/calib3d/src/usac/degeneracy.cpp#L165


FE: tailwind config updates [MRXN23-450]

Tailwind config updates
Overview
This PR change tailwind config styles to disable old custom styles and override tailwind styles extending ones.
Also updates main colors in config and trough the app.
NOTE: Old tailwind configs are still in the project with _old prefix
Designs
Figma Design System
Feature relevant tickets
MRXN23-450

@anamontiaga things I've found so far:

the following classes do not exist anymore: space-y-18, w-26,
text-gray-100 now is too light to use for texts:

"Edited..." text should probably be greyer

Review info button grey

Recommended file size is not legible

Target and SPF is too light now:

Good job overall, I was expecting this to be way worse 👏🏻 👏🏻


replace deprecated Dir.exists? with Dir.exist?

Description
Removes deprecated method warning.
Check List

[ ] All tests pass
[ ] All commits have been signed-off for the Developer Certificate of Origin. See https://github.com/chef/chef/blob/master/CONTRIBUTING.md#developer-certification-of-origin-dco

Most obvious of obvious fixes.

Thanks, @thomasdziedzic !


Hyphenated option is not supported

Lets say we have the following file
const { task, option, logger, argv } = require('just-task');
const { spawn } = require('child_process');

option('no-cache', { default: false });

task('sayhello', function() {
  logger.info(argv());
});

and we were to run npx just sayhello --no-cache, we will got the following result
[4:17:16 PM] ■ started 'sayhello'
[4:17:16 PM] ■ { _: [ 'sayhello' ],
  cache: false,
  'no-cache': false,
  noCache: false,
  '$0': 'node_modules/.bin/just' }
[4:17:16 PM] ■ finished 'sayhello' in 0.01s

if we instead run with  npx just sayhello --noCache, it will then registers
[4:20:01 PM] ■ started 'sayhello'
[4:20:01 PM] ■ { _: [ 'sayhello' ],
  noCache: true,
  'no-cache': true,
  '$0': 'node_modules/.bin/just' }
[4:20:01 PM] ■ finished 'sayhello' in 0.01s

It seems this is coming from yargs parser on this issue https://github.com/yargs/yargs-parser/issues/92 which since have been solved in the current version.
Would there be plan to update the yargs dependency in the project to the current version?

It's actually that the word "no" has a special meaning in the yargs world. It indicates the opposite of the flag and would result in a false. Maybe try another set of words in your options?

what about this
$ npx just sayhello --Cache=false

@kenotron thoughts?

Well,I have added the following
option('first-name', { default: 'world' });

and ran the following with the result
$ npx just sayhello --first-name
[4:23:00 PM] ■ started 'sayhello'
[4:23:00 PM] ■ { _: [ 'sayhello' ],
  'first-name': true,
  firstName: true,
  'no-cache': false,
  noCache: false,
  '$0': 'node_modules/.bin/just' }
[4:23:00 PM] ■ finished 'sayhello' in 0.01s

so yes, it seems the word no itself has certain significance

Wow, I'm running into the same issue. My options is called no-fork. If I change it to xy-fork it works. no seems to have a special meaning that interferes.

yeah, this is the same rule as what yargs provides. You can look at what all the options allowed are: http://yargs.js.org/docs/#api-optionkey-opt
I need to document this :P

Documentation needed (reopened)


Create product options

Description
Options are used to specify the different available properties of product. Some examples of options are colors, sizes, or material.
Spec

Create options table with these fields:

id: number
title: string

Create product_options relation table with these fields:

product_id: number
option_id: number

Create option_values table with these fields:

id: number
value: string
option_id: number
metadata?: json

Create Option model with products and values relations.
Create OptionValue model with option relation.
Add an API endpoint to create option
Add an API endpoint to create option value
Add an API endpoint to attach one product to many options
Add an API endpoint to attach one option to many products

Tests
Make these tests case
Option creation

creation with success and check that option exists in database
creation fail when request data validation fail
creation fail when model or builder fail to insert data in database

Option value creation

creation with success and check that option exists in database
creation fail when request data validation fail
creation fail when model or builder fail to insert data in database

Attach one option to many products

creation with success and check that option exists in database
creation fail when request data validation fail
creation fail when model or builder fail to insert data in database

Attach one product to many options

creation with success and check that option exists in database
creation fail when request data validation fail
creation fail when model or builder fail to insert data in database

@bnofao  https://github.com/keky-tech/product/pull/5

Voici la pull request
@bnofao  https://github.com/keky-tech/product/pull/5

Merci. Il restera le ticket front.

Je le commence cet après midi


chore: fix build

Related Issues/PRs

#xxx
What changes are proposed in this pull request?
Briefly describe the changes included in this Pull Request.
How is this patch tested?

[ ] I have written tests (not required for typo or doc fix) and confirmed the proposed feature/bug-fix/change works.

Does this PR change any dependencies?

[ ] No. You can skip this section.
[ ] Yes. Make sure the dependencies are resolved correctly, and list changes here.

Does this PR add a new feature? If so, have you added samples on website?

[ ] No. You can skip this section.
[ ] Yes. Make sure you have added samples following below steps.

Find the corresponding markdown file for your new feature in website/docs/documentation folder.
Make sure you choose the correct class estimators/transformers and namespace.
Follow the pattern in markdown file and add another section for your new API, including pyspark, scala (and .NET potentially) samples.
Make sure the DocTable points to correct API link.
Navigate to website folder, and run yarn run start to make sure the website renders correctly.
Don't forget to add <!--pytest-codeblocks:cont--> before each python code blocks to enable auto-tests for python samples.
Make sure the WebsiteSamplesTests job pass in the pipeline.

/azp run

Codecov Report

Merging #2071 (cea41f4) into master (3d1a7fc) will decrease coverage by 2.29%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2071      +/-   ##
==========================================
- Coverage   87.03%   84.75%   -2.29%
==========================================
  Files         306      306
  Lines       16117    16117
  Branches      858      858
==========================================
- Hits        14028    13660     -368
- Misses       2089     2457     +368

see 28 files with indirect coverage changes

/azp run

/azp run


How to include figures in encrypted note? And how to support markdown in encrypted note?

I would like to include a link to figure in an encrypted note. I wonder if this is possible?
It also would be useful if encrypted note can support markdown.

Hi @cuilincui,
It's not possible until #48 is worked out


Different Output in PESPacket from tsduck Demuxer vs ffmpeg demuxer

Hello,
I am sending TS Packets into the tsduck PESDemuxer and extracting the AVC video by streamId. I am sending the data in these packets into Nvidia's GPU h264 decoder. I was able to get it working with ffmpeg per Nvidia's examples, but want to use tsduck. The headers of the packets are the same, but tsduck PESDemux outputs different data. The ffmpeg data can be decoded, but the tsduck PESPacket data content cannot be. Is there some transformation I'm missing for the tsduck output?

Hi @Reinok
It is hard to tell without knowing what your code is doing with the PES packets which are sent by PESDemux.

The headers of the packets are the same, but tsduck PESDemux outputs different data.

What is the difference between what ffmpeg is doing? Same number of PES packets with same headers but different payload? How different?

I have not checked the number of packets, but it was different as of 10 or so bytes in, so the first PESPacket is different.

I have not checked the number of packets, but it was different as of 10 or so bytes in, so the first PESPacket is different.

If you want to understand the core issue, you should provide a piece of TS (producing at least one PES packet), the ffmpeg output and your application output. This is the only way to understand the difference.

I’m somewhat interested in this topic. Currently I only use TSDuck for the actual grabbing of tuner TS data and I pass the data straight to a hacked/modified libavformat to demux. The sort of hack I needed was to make it possible to av_format_find_stream_info skip over certain streams that it cannot handle (EPG, MPEG Private streams, etc) so that demux is quicker and doesn’t timeout waiting to figure out the stream info for streams it can’t help.
Anyway, my point is I’d quite like to drop the avformat dependency and demux using TSDuck as the code is way nicer. The FFmpeg libraries are comprehensive but some of that code is old and it shows!
So I wonder if there real working examples of demuxing using TSDuck and then either passing the PES data to hardware decoders as @Reinok is doing, or indeed passing directly to libavcodec.
In short, is TSDuck being used anywhere for demuxing and passing PES data to other decode libraries? Does the PESDemux gather enough data about codecs, etc. I wouldn’t want to go down this road if it then turned out that TSDuck doesn’t identify enough codec parameters to initialise a decoder, because it had never been used in this manner.

The class PESPacket provides the contextual information for a PES packet: PID, PCR, stream type, codec. This information must be set by the environment which builds the PES packet. In addition to extracting PES packets, the class PESDemux also analyzes the signalization (PAT and PMT's) to collect information on PES PID's, typically stream type and codec, based on the PMT content, including the descriptors in the PMT components. To do that, the PESDemux must receive the complete TS. All demux classes have a set of PID's to demux. They do the filtering on those PID's to demux but they also need the complete TS: the method feedPacket() must be called for all packets.
So, if your class implements PESHandlerInterface, it receives PES packets one by one and each packet carries its codec info. Just take care that the first few PES packets may not be correctly identified if received before the first PMT for their service.
In addition to getting the complete PES packets, the PESHandlerInterface can receive various info such as audio/video attributes or individual NALunits. You may experiment by cloning the pes plugin and playing with the received information.
Take care that HEVC info was very recently added. It is not on version 3.24. Use the latest repo if you need HEVC info.

Great, thanks for the info!


docs: add adr Error Handling Report Problem [skip ci]

Overview

Fixes ATL-xxxx
Checklist
My PR contains...

[x] No code changes (changes to documentation, CI, metadata, etc.)
[ ] Bug fixes (non-breaking change which fixes an issue)
[ ] Improvements (misc. changes to existing features)
[ ] Features (non-breaking change which adds functionality)

My changes...

[ ] are breaking changes
[x] are not breaking changes
[ ] If yes to above: I have updated the documentation accordingly

Documentation

[x] My changes do not require a change to the project documentation
[ ] My changes require a change to the project documentation
[ ] If yes to above: I have updated the documentation accordingly

Tests

[ ] My changes can not or do not need to be tested
[ ] My changes can and should be tested by unit and/or integration tests
[ ] If yes to above: I have added tests to cover my changes
[ ] If yes to above: I have taken care to cover edge cases in my tests

One general comment - and it's fine if there are literally no other options but comparing alternative options and weighing up the tradeoffs is something I consider important (it makes it a decision) - are there any other options? if not - let's just state that this is the only way to do it somewhere?


Can't build windows binaries

Hi, mruby-cli is great!
But, I've got following errors.
CC    build/mrbgems/mruby-io/src/io.c -> build/x86_64-w64-mingw32/mrbgems/mruby-io/src/io.o
/home/mruby/code/mruby/build/mrbgems/mruby-io/src/io.c: In function 'mrb_cloexec_pipe':
/home/mruby/code/mruby/build/mrbgems/mruby-io/src/io.c:156:3: error: implicit declaration of function 'pipe' [-Werror=implicit-function-declaration]
   ret = pipe(fildes);
   ^
cc1: some warnings being treated as errors

it seems that mingw-w64 compiler is more strict for declaration check.
I found work around :
# spec.add_dependency 'mruby-mtest', :mgem => 'mruby-mtest'

but, this is wrong.
we have no test.
thanks.

@kjunichi Thanks for your report! I will look into it and see if I can fix it upstream.
/cc @tsahara

pipe(2) requires <unistd.h> on POSIX platforms.  What is needed on mingw32?

I'm not familiar with Mingw32,but following is my research.
io.h had _pipe function.
This page says that
#define pipe(fds) _pipe(fds, 5000, _O_BINARY)
/* replace 5000 with whatever buffer size you want to use */

http://mingw.5.n7.nabble.com/How-does-mingw-support-pipe-td8714.html

is this helps up?
thanks.

Thank you!  I tried _pipe macro but it is not a drop-in replacement of POSIX pipe(2) as written in the page, so I have merged https://github.com/iij/mruby-io/pull/53 to remove pipe support on Windows platforms.  Could you try updated mruby-io?  docker-compose run compile runs without error for me.

Thank you very much!
It works fine on both 32bit and 64bit windows platform.

Glad to see this resolved, thank you for your efforts!
お疲れ様でした！！


Add SampleAssetManager and test.manager harness

This PR condenses the work in feature/96-exampleManager into it's constituent work. This is an experiment into our discussed approach of an intermediate squash of feature branches that doesn't remove all commits, or merge the entire working history.

Commit messages and content look good to me. The diff between this and feature/96-exampleManager is just one small tweak to a comment in a test file. So all good!

Yeah, Id seen that, and think I thought the new comment was better?


Integrate EIA-860 Multifuel table

Overview
3_5_Multifuel_Y#### is a table in EIA-860 that includes detailed information about multifuel generators.
Why do you want it in PUDL?
Some of the columns in the multifuel table are in pudl from other EIA-860 tables, but there are columns in the multifuel table that are unique to that table (for example, the time to switch from oil to gas), and the data in this table seems more complete than the duplicate columns in other tables (for example, this table indicates that plant 10 can switch fuels while operating (operating_switch = "Y", but the data for this plant currently integrated into pudl has this as a missing value.
Logistics
This is public and published alongside all of the other EIA-860 tables. Integrating may require reconciling overlapping columns from other EIA-860 tables if they disagree with each other.
What do you know about it so far?
It would be great to have this to ensure that multiple_fuels, 'cofire_fuels, switch_oil_gas, and operating_switch` are accurate and complete.
It would also be helpful to have some new data such as the specific breakout of different cofire energy sources (as distinct from energy_source_code and startup_source_code); the time to switch columns, and the factors that limit switching columns.

I think we have concrete plans to get all of the other tables from schedule 3, but hadn't planned for this one yet. Would you be up for making a PR that compiles the necessary file/sheet/column mappings? And then maybe we could work on the transform alongside the other new EIA-860 tables.

@grgmiller I'm going to flesh out this issue a bit in the hopes that we can make it accessible to an open source contributor.

I don't think this is a complete list, but here's some of the columns mappings that we've been parsing for our uses:
column_names = {
        "Plant Code": "plant_id_eia",
        "Generator ID": "generator_id",
        "Energy Source 1": "energy_source_code_1",
        "Energy Source 2": "energy_source_code_2",
        "Multiple Fuels?": "multiple_fuels",
        "Cofire Fuels?": "cofire_fuels",
        "Cofire Energy Source 1": "cofire_source_code_1",
        "Cofire Energy Source 2": "cofire_source_code_2",
        "Cofire Energy Source 3": "cofire_source_code_3",
        "Cofire Energy Source 4": "cofire_source_code_4",
        "Cofire Energy Source 5": "cofire_source_code_5",
        "Cofire Energy Source 6": "cofire_source_code_6",
        "Switch Between Oil and Natural Gas?": "switch_oil_gas",
        "Switch When Operating?": "operating_switch",
        "Time to Switch From Gas to Oil": "switch_gas_oil_time",
        "Time to Switch From Oil to Gas": "switch_oil_gas_time",
        "Factors that Limit Switching?": "switch_limits",
        "Air Permit Limits?": "air_permit_limit",
    }

Hi, just came across this project. I have some free time next week and would be interested in helping out with this issue, if it's still needed. Would looking through https://github.com/catalyst-cooperative/pudl/blob/main/src/pudl/transform/eia860.py be a good place to start?

Hey @jmelot I think the first thing that needs to happen is the spreadsheet tab needs to be mapped for extraction.  You can see a bunch of other examples of how we do that under src/pudl/package_data/eia860/.  You'll need to set up the development environment and pull down the EIA-860 input data archives with pudl_datastore --datasets eia860 so you can inspect all the historical spreadsheets to see what columns are called, how many rows to skip for headers, etc.
Then the tab can get added to the raw extraction step in src/pudl/extract/eia860.py and you can try running the extraction in Dagster and inspect the resulting raw dataframe. Then you could move on to the transform step.

Makes sense, thanks for the help getting started!

Thanks, appreciate that you're interested in tackling this table! Feel free to reach out if you have any questions about the table since I've spent a bit of time looking at it and using data from this table.

It looks like the mappings under src/pudl/package_data/eia860/ are already present, except that there are only column maps for the existing and retired tabs. Should I add a map for the proposed tab as well?
Thanks for all the clear instructions, it was pretty smooth getting things set up! I'm waiting on the ferc_to_sqlite job to finish and then I'll try writing a transform.

Oh great! I didn't realize we'd gotten it to the point of extraction already. If there's data in the proposed tab that would be good to get mapped too -- the other generators also come in those three flavors and it would be nice to have the same coverage for all of them.


Delete manifests/j/JanDeDobbeleer/OhMyPosh/7.62.0 directory

[ ] Have you signed the Contributor License Agreement?
[ ] Have you checked that there aren't other open pull requests for the same manifest update/change?
[ ] Have you validated your manifest locally with winget validate --manifest <path>?
[ ] Have you tested your manifest locally with winget install --manifest <path>?
[ ] Does your manifest conform to the 1.2 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

@wingetbot run

@wingetbot run


[Ember 1.13.0] setDate not working ('this' is in state 'preRender')

Hi David,
setDate() is not working with the new ember beta (1.13.0-beta.1 incl. Glimmer).
setDate: function() {
  this.get('pikaday').setDate(this.get('value'), true);
}.observes('value'),

this is in state 'preRender' at that point in time what makes pikaday undefined.
Uncaught TypeError: Cannot read property 'setDate' of undefined
We could fix it like this:
setDate: function() {
  Ember.run.scheduleOnce('afterRender', this, function() {
    this.get('pikaday').setDate(this.get('value'), true);
  });
}.observes('value'),

Tests are green. Other uses of get('pikaday') don't seem affected. What do you think?

ok tests are only OK in the browser, 13 tests are failing on the command line :-/

That's a bummer, thanks for looking into this. I think there should be a new Ember 1.13.0 beta tomorrow, maybe this improves things.

@DenizOkcu is this still an issue?

I'm still seeing this issue with Ember 1.13.0. The fix from @DenizOkcu seems to solve the issue however.

@polymathnyc Thanks for reporting, I ran the tests against Ember 1.13.0 and they where green so I assumed this issue went away. I will take a look and try to reproduce and fix it!

This should be fixed in version 0.7.2.


exclude globals from find_undeclared_variables

Added a check for global variables when running find_undeclared_variables. Tests updated to reflect the change as well.
Written at PyCon 2019 Sprints.
fixes #931

When does 2.11.0 milestone come out?


Why is the code formatting not working on this highlighted generated jekyll page?

In my gh-page, the code formatting tags are properly encoded.
< tag name goes here >
Corresponding
 and  tags are enclosed.
I believe this is the reason, the preview renders without any issue.

However on the resulting page UI, the code highlighting breaks after # Dependency property system - DPS.

I'm using highlightjs
This seems to be a kind of bug to me.
Any suggestions on this?
source

It's a bug, but not in highlight.js. Here's an excerpt of the relevant part of your page source:

namespace abcLib
{
  public class LatinWords : IMarkupExtension<string>
 ...
}</code></pre>

There are two problems with it:

You probably wanted <string> displayed as is, so you have to escape it as <string>
It looks like </code></pre> was supposed to actually end this code snippet, so they should not be escaped:

I don't know what kind of software generates this HTML, so I can't give any particular recommendations on how to fix those two problems. But they most certainly have nothing to do with highlighting, it's just HTML.


Implement Color trait

@ojustino - could you review this?

I just realized that we should only set the opacity if the color is the fill color - I need to make some tweaks for that

This looks good to me. I also realized that not all color attributes have opacity, and we agree on the traits for which that is or is not the case.


Document API version compatibility

It would be good to document the version compatibility of this library to the Splunk server version.

@shakeelmohamed How come this was closed?


chore: add actions

resolved issue: https://github.com/akebu6/Julia-Notes/commit/9beade4402c93942688600a17a0a684532ba5a47


browse view permanent link should only include relevant settings

All settings that are irrelevant for the current view and all settings that are the default should always be excluded. The links are excessively long and therefore hard to work with at the moment.

This is implemented by #45.


Use explicit constructors when implicit construction isn't wanted

Description
Reported by SonarCloud, we should be using explicit on constructors with single parameters, to prevent implicit constructions.
There are of course a few places, where we actually do want implicit constructions:

String overloads (wchar_t, char32_t, const wchar_t*, const char32_t*, const std::wstring&, std::u32string)
Ftp::DirectoryResponse(const Ftp::Response&)
Time(const std::chrono::duration&)
StencileValue(int) & StencileValue(unsigned int)
RenderStates(...)
Event(const TEventSubtype&)

Is there a type on the list that shouldn't be there or one that you think should be there?
Tasks

[ ] Tested on Linux
[x] Tested on Windows
[ ] Tested on macOS
[ ] Tested on iOS
[ ] Tested on Android

How to test this PR?
Should compile with examples.

I would argue that single char sf::String constructors being implicit is a bad idea
also constructors that have default arguements can be invoked implicitly like this one
    Text(const Font& font, String string = "", unsigned int characterSize = 30);

void f(sf::Text const&);
sf::Font font;
f(font); // compiles!

I would argue that single char sf::String constructors being implicit is a bad idea

Why?

also constructors that have default arguements can be invoked implicitly like this one
    Text(const Font& font, String string = "", unsigned int characterSize = 30);

void f(sf::Text const&);
sf::Font font;
f(font); // compiles!

I went over the public API again and change those constructors as well. This required a change to the joystick example, is this okay this way, @ChrisThrasher?

@eXpl0it3r
putting explicit on the Text constructor prohibits this code from compiling

sf::Text getText(const Font& f)
{
   return {f,"Hello Exploiter",30}; // fails to xompile no implicit conversion
}

the solution is to provide another overload that only takes sf::Font and is marked explicit and uses constructor delegation to delegate to the Font,String,Size constructor but this requires adding docs to the new constructor

Pull Request Test Coverage Report for Build<PHONE_NUMBER>3
Details

2 of 2 (100.0%)  changed or added relevant lines in 2 files are covered.
4 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.02%) to 56.944%

Files with Coverage Reduction
New Missed Lines
%

src/SFML/Window/WindowImpl.cpp
4
52.29%

Totals

Change from base Build<PHONE_NUMBER>7:
-0.02%

Covered Lines:
11900

Relevant Lines:
19893

💛  - Coveralls

A text constructor only taking a font doesn't make sense though. You need to set some string and setting it implicitly isn't a road I'd want to go down.
Since the effect of this change isn't wanted, I'll revert it again.

A text constructor only taking a font doesn't make sense though.

That's the status quo. Are you saying that we should remove the default argument on string?
Text(const Font& font, String string = "", unsigned int characterSize = 30);

The status quo as default arguments. It's clear from the function signature that they are there and what they're set to. Creating an overload with just the front and no other params with default values didn't make sense, because you'll then set a default string in "secret".
I'm just saying we should keep the status quo then.

@ZXShady
or I would make the user type sf::Text infront of the return statement

That would be my vote.

also to note that not all sfml types provide {} syntax to default intiialize
sf::Text getText()
{
     return {}; // works fine
}

sf::CircleShape getCircle()
{
      return {}; // error no implicit conversion
}

why doesn't this work? it is because the default constructor of CircleShape is a constructor marked explicit with efault parameters
explicit CircleShape(float radius = 0, std::size_t pointCount = 30);

I've removed the explicit constructors with default params.

I would argue that single char sf::String constructors being implicit is a bad idea

Why?

Actually the class relies on implicit conversions from chars like this line

sf::String a;
a += 'A'; // the char is implicitly converted into a sf::String then operator+= is called


Demote sorted search to level 3 heading

Just something I noticed while editing README.md: ## Sorted search seems to logically belong under ## Custom search but it has the same level of heading (and does not have its place in the TOC).

bors merge


Enabling CORS does not work

Hello, I don't know what I'm doing wrong, but the enableCorsForAllOrigins method just doesn't add any CORS headers.
I'm on version 3.13.7 and here's how I'm configuring the server.
    val app = Javalin.create {
      it.contextPath = apiPrefix
      it.asyncRequestTimeout = 10000L
      it.defaultContentType = "application/json"
      it.showJavalinBanner = false
      it.enableCorsForAllOrigins()
      it.requestLogger { ctx, ms ->
        RequestLogger.log(ctx, ms)
      }
    }

The other options in the config work well.

I'm not using any other plugins, just simple clean setup in Kotlin.
Is there anything else which needs to be configured?

You can clone this repo and compare to what you have locally: https://github.com/tipsy/javalin-cors-example

Thank you for the example repository. It seems that it was just a typo.
Sorry for bothering you :)

No problem, glad you figured it out!


🧪 Write unit, integration, and end-to-end (e2e) tests

Writing good tests
Overview
As part of a larger effort to learn good CI/CD and Test-driven development, I want to use this project as an opportunity to learn Jest and possibly Cypress for e2e.
Details
Learn
Learn best practices and create write-ups to review and share with others who are getting started with testing.

[ ] Research Jest for unit testing React apps + add to #100DaysOfCode
[ ] Research Jest & React Testing Library for integration testing + add to #100DaysOfCode
[ ] Research Cypress for end-to-end (e2e) testing + add to #100DaysOfCode

Do
Implement these best practices for code-le. Start with the basics and go from there.

[ ] Close to 100% unit test coverage for components, functions, etc.
[ ] Basic integration tests (a handful)
[ ] An E2E test

Teach
Solidify learning by creating resources for others to learn.

[ ] 5- to 10-minute YouTube video
[ ] 60s LinkedIn video
[ ] Mid-length blog post
[ ] Twitter thread (optional)

Research Jest for unit testing React apps + add to #100DaysOfCode
Working on this subtask today. Got some good advice re: testing from a mentor...

I'd say it's not bad to know - but it's not a high priority really for getting your first role

Research & Learning

[ ] Max Schwarz Udemy module
[ ] Traversy tutorial
[ ] Post notes via Goodnotes into #100DaysOfCode project for future content production

Close to 100% code coverage w/ Unit tests
Unit test ideas

[ ] Mock functions that manage data in localStorage to avoid making unnecessary changes
[ ] Put a unit test against each component

[ ] Does it render what it's supposed to?
[ ] Does it handle user interactions correctly?
[ ] Success and failure cases for state changes?

Do
Implement unit, integration, and e2e testing.
Unit testing (some ideas for now)

[ ] Mock functions that manage data in localStorage to avoid making unnecessary changes
[ ] Put a unit test against each component

[ ] Does it render what it's supposed to?
[ ] Does it handle user interactions correctly?
[ ] Success and failure cases for state changes?

Teach
Consolidate learnings

[ ] Summarize learnings in #100DaysOfCode via .md notes


Create React App - Unexpected token import in config.js

Hi, after running getstorybook in my create react app and running storybook I get:
config.js?1daa:1 Uncaught SyntaxError: Unexpected token import
In the console when loading http://localhost:9009/ and no stories loaded.
Didn't tinker or anything (just plain CRA, though not an empty project)
Sorry if that's not enough information, will happily provide more if needed.
package.json:
{   "name": "grumshi",   "version": "0.1.0",   "private": true,   "devDependencies": {     "chai": "^3.5.0",     "enzyme": "^2.4.1",     "react-addons-test-utils": "^15.3.2",     "react-dom": "^15.3.1",     "react-scripts": "0.4.1",     "react-test-renderer": "^15.3.2",     "@kadira/storybook": "^2.21.0"   },   "dependencies": {     "react": "15.3.1",     "react-dom": "^15.3.1",     "react-helmet": "^3.1.0",     "react-redux": "^4.4.5",     "react-router": "^2.7.0",     "react-router-redux": "^4.0.5",     "react-traverse": "0.0.3",     "redux": "^3.6.0"   },   "scripts": {     "start": "react-scripts start",     "build": "react-scripts build",     "test": "react-scripts test --env=jsdom",     "eject": "react-scripts eject",     "storybook": "start-storybook -p 9009",     "build-storybook": "build-storybook"   },   "eslintConfig": {     "extends": "./node_modules/react-scripts/config/eslint.js"   } }
On the console I get this probably related error that goes away if I remove the JSX from the default stories:
ERROR in C:/Users/Guy/Documents/Projects/grumshi/src/stories/index.js                                                                                Module parse failed: C:\Users\Guy\Documents\Projects\grumshi\src\stories\index.js Unexpected token (7:4)                                                   You may need an appropriate loader to handle this file type.                  SyntaxError: Unexpected token (7:4)                                                                                at Parser.pp$4.raise (C:\Users\Guy\Documents\Projects\grumshi\node_modules\webpack\node_modules\acorn\dist\acorn.js:2221:15)                               at Parser.pp.unexpected (C:\Users\Guy\Documents\Projects\grumshi\node_modules\webpack\node_modules\acorn\dist\acorn.js:603:10)                             at Parser.pp$3.parseExprAtom (C:\Users\Guy\Documents\Projects\grumshi\node_modules\webpack\node_modules\acorn\dist\acorn.js:1822:12)                       at Parser.pp$3.parseExprSubscripts (C:\Users\Guy\Documents\Projects\grumshi\node_modules\webpack\node_modules\acorn\dist\acorn.js:1715:21)                 at Parser.pp$3.parseMaybeUnary (C:\Users\Guy\Documents\Projects\grumshi\node_modules\webpack\node_modules\acorn\dist\acorn.js:1692:19)                     at Parser.pp$3.parseExprOps (C:\Users\Guy\Documents\Projects\grumshi\node_modules\webpack\node_modules\acorn\dist\acorn.js:1637:21)                        at Parser.pp$3.parseMaybeConditional (C:\Users\Guy\Documents\Projects\grumshi\node_modules\webpack\node_modules\acorn\dist\acorn.js:1620:21)               at Parser.pp$3.parseMaybeAssign (C:\Users\Guy\Documents\Projects\grumshi\node_modules\webpack\node_modules\acorn\dist\acorn.js:1597:21)                    at Parser.pp$3.parseParenAndDistinguishExpression (C:\Users\Guy\Documents\Projects\grumshi\node_modules\webpack\node_modules\acorn\dist\acorn.js:1861: 32)                                                                                at Parser.pp$3.parseExprAtom (C:\Users\Guy\Documents\Projects\grumshi\node_modules\webpack\node_modules\acorn\dist\acorn.js:1796:19)                    @ C:/Users/Guy/Documents/Projects/grumshi/.storybook/config.js 4:2-27

It's pretty great, If I can get a sample repo.
And tell me the NPM version you are using.

Sure, I'll do that in a little while (npm 3.10.3, node 6.3.0)

I have same error both in react-cdk and pure Storybook
ERROR in E:/DevelopWeb/_CompFactory/_Develop/tmp/react-wizard/src/stories/index.js
Module parse failed: E:\DevelopWeb\_CompFactory\_Develop\tmp\react-wizard\src\stories\index.js Unexpected token (7:4)
You may need an appropriate loader to handle this file type.
SyntaxError: Unexpected token (7:4)
    at Parser.pp$4.raise (E:\DevelopWeb\_CompFactory\_Develop\tmp\react-wizard\node_modules\acorn\dist\acorn.js:2221:15)
    at Parser.pp.unexpected (E:\DevelopWeb\_CompFactory\_Develop\tmp\react-wizard\node_modules\acorn\dist\acorn.js:603:10)
    at Parser.pp$3.parseExprAtom (E:\DevelopWeb\_CompFactory\_Develop\tmp\react-wizard\node_modules\acorn\dist\acorn.js:1822:12)
    at Parser.pp$3.parseExprSubscripts (E:\DevelopWeb\_CompFactory\_Develop\tmp\react-wizard\node_modules\acorn\dist\acorn.js:1715:21)

    at Parser.pp$3.parseMaybeUnary (E:\DevelopWeb\_CompFactory\_Develop\tmp\react-wizard\node_modules\acorn\dist\acorn.js:1692:19)
    at Parser.pp$3.parseExprOps (E:\DevelopWeb\_CompFactory\_Develop\tmp\react-wizard\node_modules\acorn\dist\acorn.js:1637:21)
    at Parser.pp$3.parseMaybeConditional (E:\DevelopWeb\_CompFactory\_Develop\tmp\react-wizard\node_modules\acorn\dist\acorn.js:1620:21)
    at Parser.pp$3.parseMaybeAssign (E:\DevelopWeb\_CompFactory\_Develop\tmp\react-wizard\node_modules\acorn\dist\acorn.js:1597:21)
    at Parser.pp$3.parseParenAndDistinguishExpression (E:\DevelopWeb\_CompFactory\_Develop\tmp\react-wizard\node_modules\acorn\dist\acorn.js:1861:32)
    at Parser.pp$3.parseExprAtom (E:\DevelopWeb\_CompFactory\_Develop\tmp\react-wizard\node_modules\acorn\dist\acorn.js:1796:19)
 @ E:/DevelopWeb/_CompFactory/_Develop/tmp/react-wizard/.storybook/config.js 9:2-27

I guess that this is a problem because of windows @guy-kdm do work under windows?
Unexpected token (7:4) in react-wizard/src/stories/index.js it's just place where jsx code goes:

it starts after strorybook v2 was released
as a temporary solution I run it from mintty shell or ...(It looks like magic to me) from Brackets Node.JS plugin (I can only assume that the matter in internal node v0.10, while I use v6.3.1)

I had a similar issue with SyntaxError: Unexpected token import and solved it by adding "es2015" preset to my .babelrc file in the app root folder.
Using transform-es2015-modules-commonjs plugin instead of entire preset should also work.

@guy-kdm @filmic Do you guys have any .babelrc file in your project root?
If so, you may need to remove it.
Here I'd to see a sample repo (or how to reproduce this).

No babelrc (cause CRA), if no one will before I'll upload a sample repo in Saturday, thanks for the help meantime

@arunoda Yep, windows unfortunately :)

@arunoda Rather than removing the .babelrc in root folder (which is used for the app production build) I would create a custom .babelrc just for Storybook as described in docs: https://getstorybook.io/docs/configurations/custom-babel-config

Hi there, sorry for the delay. Any repo with the package.json here
, on my windows machine, failes for getstorybook -f for example. Hope that helps, probably will look at it more once I'll get back to front end.

size matters!!!
https://www.youtube.com/watch?v=tSd4hUOcalg

tl;dr: You need to have Uppercase drive letter in your current folder path 😱😡😮

so to solve this you need to change drive letter to Uppercase
you need to do it through root folder not whole path:
rem doesn't work:
cd E:\your\path_to\project
npm run storybook

rem works:
cd E:\
cd your\path_to\project
npm run storybook

rem works:
cd E:\your\path_to\project
c:
e:
npm run storybook

It looks like in some cases when you open your cmd shell it could be open with lowcase drive letter. in my case when I open it from total commander prompt. I hope now it will be easy to prevent, just need to pay attention to the register of a drive letter.
PS sorry for so emotional. been hunting for this ugly bug for over two months. had to rebuild the workflow in the end.

I am also having this problem.
// .storybook/.babelrc

{
  "presets": [
		["es2015", {"modules": false, "loose": true}],
		"stage-3",
		"stage-2",
		"react",
	],
	"plugins": [
		"transform-class-properties",
		"styled-jsx/babel",
		["transform-react-jsx", { "pragma": "h"}]
	]
}

const { configure } = require('@kadira/storybook')

const req = require.context('../src/components', true, /story.js$/)

function loadStories() {
	req.keys().forEach(filename => console.log(filename) || req(filename))
}

configure(loadStories, module)

console messages:

./HeaderNav/story.js
render.js:65 SyntaxError: Unexpected token import
    at Object.<anonymous> (http://localhost:6006/static/preview.bundle.js:3149:2)
    at __webpack_require__ (http://localhost:6006/static/preview.bundle.js:556:30)
    at fn (http://localhost:6006/static/preview.bundle.js:87:20)
    at webpackContext (webpack:///./src/components_story.js$?:5:9)
    at eval (webpack:///./.storybook/config.js?:8:35)
    at Array.forEach (native)
    at loadStories (webpack:///./.storybook/config.js?:7:13)
    at ConfigApi._renderMain (webpack:///./~/@kadira/storybook/dist/client/preview/config_api.js?:40:20)
    at render (webpack:///./~/@kadira/storybook/dist/client/preview/config_api.js?:66:17)
    at ConfigApi.configure (webpack:///./~/@kadira/storybook/dist/client/preview/config_api.js?:91:9)
renderException @ render.js:65
renderPreview @ render.js:137
renderUI @ index.js:89
dispatch @ createStore.js:186
_renderError @ config_api.js:57
render @ config_api.js:76
configure @ config_api.js:91
(anonymous) @ config.js:12
(anonymous) @ config.js:13
(anonymous) @ preview.bundle.js:3143
__webpack_require__ @ preview.bundle.js:556
fn @ preview.bundle.js:87
(anonymous) @ multi_preview:4
(anonymous) @ preview.bundle.js:586
__webpack_require__ @ preview.bundle.js:556
(anonymous) @ preview.bundle.js:579
(anonymous) @ preview.bundle.js:582
client.js:67 [HMR] connected

Any ideas @arunoda ?

@cgood92 you can try to add BABEL_ENV=commonjsbefore you run storybook.
e.g:
BABEL_ENV=commonjs start-storybook -p 9001 -c .storybook
it worked for me, I had the same problem as you.

Adding BABEL_ENV doesn't work for me, here is my .babelrc
`
{
"presets": [
"next/babel",
"stage-0"
],
"plugins": [
["transform-define", "./env-config.js"],
"transform-export-extensions",
"transform-decorators-legacy",
[
"module-resolver",
{
"root": ["."],
"alias": {
"styles": "./styles"
},
"cwd": "babelrc"
}
],
[
"wrap-in-js",
{
"extensions": ["css$", "scss$"]
}
]
]
}
`

Removing the {"modules":false} flag from my es2015 preset helped in my case.

That would make sense, since currently that'd require webpack 2.
Luckily webpack 2 support is coming!


slave buffer on source redis server is growing indefinitely

Issue Description:
The slave client buffer keep growing on the source redis, even after RDB sync finished. There is no any errors in source or detination, the only issue is that the client buffer growing indefinitely and I've concern that it will cause out of memory soon in the source redis server.
Is this normal, anything I can do about it?
Environment

RedisShake version: v3.1.11
Redis source: 6.2
Redis destination: 6.2
Redis sentinel
Deployed on Cloud Provider: No

Logs
Last logs
2023-10-27 17:27:12 INF syncing aof. allowOps=[6382.40], disallowOps=[15.00], entryId=[30404975], InQueueEntriesCount=[0], unansweredBytesCount=[54076]bytes, diff=[87537], aofReceivedOffset=[29786229765029], aofAppliedOffset=[29786229677492]
2023-10-27 17:27:17 INF syncing aof. allowOps=[4823.60], disallowOps=[10.80], entryId=[30429147], InQueueEntriesCount=[0], unansweredBytesCount=[0]bytes, diff=[114688], aofReceivedOffset=[29786240152485], aofAppliedOffset=[29786240037797]
2023-10-27 17:27:22 INF syncing aof. allowOps=[5342.00], disallowOps=[11.60], entryId=[30455915], InQueueEntriesCount=[0], unansweredBytesCount=[52487]bytes, diff=[67009], aofReceivedOffset=[29786249573285], aofAppliedOffset=[29786249506276]
2023-10-27 17:27:27 INF syncing aof. allowOps=[6856.20], disallowOps=[9.20], entryId=[30490242], InQueueEntriesCount=[0], unansweredBytesCount=[56608]bytes, diff=[90112], aofReceivedOffset=[29786259993509], aofAppliedOffset=[29786259903397]
2023-10-27 17:27:32 INF syncing aof. allowOps=[4987.20], disallowOps=[10.40], entryId=[30515230], InQueueEntriesCount=[0], unansweredBytesCount=[55174]bytes, diff=[69636], aofReceivedOffset=[29786269889445], aofAppliedOffset=[29786269819809]

Additional Information:
Graph

Configuation
type = "sync"

[source]
version = 6.2
address = "slave.source.consul:6379"
username = ""
password = ""
tls = false

[target]
type = "standalone" #
version = 6.2
address = "master.destination.consul:6379"
username = ""
password = ""
tls = false

[advanced]
dir = "data"

# runtime.GOMAXPROCS, 0 means use runtime.NumCPU() cpu cores
ncpu = 4

# pprof port, 0 means disable
pprof_port = 0

# metric port, 0 means disable
metrics_port = 0

# log
log_file = "redis-shake.log"
log_level = "info"
log_interval = 5

rdb_restore_command_behavior = "rewrite"

# pipeline
pipeline_count_limit = 1024

target_redis_client_max_querybuf_len = 1024_000_000
target_redis_proto_max_bulk_len = 512_000_000

Redis shake also configured with this filter:
-- pubsub: skip PUBLISH command
function filter(id, is_base, group, cmd_name, keys, slots, db_id, timestamp_ms)
    if cmd_name == "PUBLISH" then
        return 1, db_id -- disallow
    end

    return 0, db_id -- allow
end

I have no idea. There was a similar issue(#602) but it should have been fixed.

Please provide more info information through the info all command.
Try v4.0, it may help.

The issue is on source redis not destination. Anyway, I already finished running redis shake and migrated all the data, so not an issue for me anymore, but maybe others will experience the issue as well, feel free to close the issue


How to generate DBS and ID report?

Hi,
I've looked in the documents, doc, publication. But I can't find the input parameter to set SigProfilerAssignment to generate DBS and ID solutions. The publication mentioned the DBS and ID few times. But I can't find any description in the README.
Thank you.

Hi @alexgby,
You will want to use the parameter context_type and set it to "DINUC" for DBS and "ID" for Indels.
Please reach out if you have any additional questions.


Update dotnet 5 references to dotnet 6

Expected Behavior
.NET 6 to be referenced exclusively.
.NET 5 hit end of support back in May...
Actual Behavior
Various 5 references sprinkled
grep -ri 'NET 5'
Tests/bin/Debug/Python/PandasTests/PandasMapperTests.py:# Tell PythonNet to use .dotnet 5
Tests/Python/PandasTests/PandasMapperTests.py:# Tell PythonNet to use .dotnet 5
.vs/readme.md:1. Install [.Net 5](https://dotnet.microsoft.com/download) for the project
readme.md:- Install [dotnet 5](https://docs.microsoft.com/en-us/dotnet/core/install/linux):
DockerfileLeanFoundationARM:# Install dotnet 5 sdk & runtime
.vscode/readme.md:1. Install [.Net 5](https://dotnet.microsoft.com/download) for the project
.vscode/launch.json:        Builds the project with dotnet 5 and then launches the program using coreclr; supports debugging.
.vscode/launch.json:        In order to use this you need dotnet 5 on your system path, As well as the C# extension from the

Potential Solution
Happy to send a PR updating these...
Can someone with more historical knowledge of Lean confirm that there are no reasons that certain platforms or code pieces should still reference v5?
Builds just fine for me on Ubuntu with dotnet 6; haven't tried other platforms.
Checklist

[x] I have completely filled out this template
[x] I have confirmed that this issue exists on the current master branch
[x] I have confirmed that this is not a duplicate issue by searching issues

Cool. Will send a PR when I get some down cycles

Hey @Martin-Molinero ,
Sorry about the late response.

Can someone with more knowledge of the project advise on whether those are just a string replace, or if there's a debug/build process on updating those?
Examples:
grep -r '.net5.0'

...

cat AlgorithmFactory/obj/project.assets.json | grep 'net5.0'
          "lib/net5.0/Microsoft.IO.RecyclableMemoryStream.dll": {
          "lib/net5.0/Microsoft.IO.RecyclableMemoryStream.dll": {
        "lib/net5.0/Microsoft.IO.RecyclableMemoryStream.dll",
        "lib/net5.0/Microsoft.IO.RecyclableMemoryStream.xml",


Adapt to COCO format dataset

It is not only adapted to the COCO dataset, but also to the dataset of the COCO format type.

Please lint your code to pass CI.

Code checked

LGTM.


How to create background service in WindowsAppSdk ?

Describe the bug
How to create background service in WindowsAppSdk ?
We want to create background service in WindowsAppSdk which will be running all the time with or without running main application.
Need combination of main application(has UI) & background service.
Even though main application is not running, we want background service to run always and perform some actions as require.
On windows startup also - want to start background service
Steps to reproduce the bug
How to create background service in WindowsAppSdk ?
We want to create background service in WindowsAppSdk which will be running all the time with or without running main application.
Expected behavior
Need combination of main application(has UI) & background service.
Even though main application is not running, we want background service to run always and perform some actions as require.
On windows startup also - want to start background service
Screenshots
Need combination of main application(has UI) & background service.
Even though main application is not running, we want background service to run always and perform some actions as require.
On windows startup also - want to start background service
NuGet package version
None
Packaging type
Packaged (MSIX)
Windows version
No response
IDE
Visual Studio 2022
Additional context
No response

background service in WindowsAppSdk which will be running all the time with or without running main application.
Does this need to do stuff per-user or per-machine?
If per-machine you can create a Packaged Service running as LocalSystem, LocalService or NetworkService
https://learn.microsoft.com/en-us/uwp/schemas/appxpackage/uapmanifestschema/element-desktop6-service
If per-user a BackgroundTask is the usual recommendation. That doesn't run 24x7, it runs when your defined trigger(s) pop
https://learn.microsoft.com/en-us/windows/uwp/launch-resume/create-and-register-a-background-task


DNM: oracle keeper enforces uppercase symbol denoms

This needs discussion to see if it's reasonable.
Adds a migration to turn all symbol denoms currently stored in the oracle keeper (generally as keys, but sometimes as values) into uppercase. Proceeds to enforce that rule in all Set functions.

imo I don't think this is the way to go. For one, you should always write software assuming caps won't match when comparing strings. Also our oracle's settings are still in parameters, so we don't have custom gov handling logic.
cc @zarazan @rbajollari

I'm hoping to solve some issues:

Leverage (and soon ibc quota) module needs to know what denom (all caps, exact match to leverage registry, or something else?) to pass into functions like GetExchangeRate since it can't try multiple possibilities without calling the function multiple times. Currently historic prices use whatever the leverage module set first, and exchange rates always use uppercase.
Oracle module is vulnerable to leverage shenanigans, like updating setting stOSMO vs STOSMO in the registry.
Calling functions with the wrong case currently gives us "unknown denom", but if they were always stored as uppercase in the oracle KVStore, then any getter would also know what key to search for and convert to uppercase.

imo I don't think this is the way to go. For one, you should always write software assuming caps won't match when comparing strings. Also our oracle's settings are still in parameters, so we don't have custom gov handling logic. cc @zarazan @rbajollari

I agree that if we don't ever need to support handling capitalization differences as different assets ("tOKEN" vs "TOKEN") then the oracle should store everything in the same case (all upper or all lower). Preferably we would enforce this requirement further upstream (such as when submitting proposals) instead of putting a ton of toUpper in the keepers but like Woz said, we don't have custom gov handling logic yet.


create separate planes-surface folder

Right now, all is included in PC registration, but clearly it is not a registration method, but a more general concept.

Solved in #10


Plan initial tasks for online editor

Plan initial tasks for making the online editor.

Hello @GSMgeeth , I'll like to know what your issue aims at. Are you trying to ask for the steps needed in building an online editor or what the online editor can successfully do? And what language are you going to use for this project?

Hello @GSMgeeth , I'll like to know what your issue aims at. Are you trying to ask for the steps needed in building an online editor or what the online editor can successfully do? And what language are you going to use for this project?

Hi @Dorcastunmise
This is an issue for me and my team to plan the tasks in order to move our already existing online editor to this public repository. It's an online editor that is in it's very basic stages and we are planning to make it an open source project so that everyone can contribute and make it a great free product.
Our current editor is hosted in Firebase and have used React as the frontend. These are to be discussed again through this issue and subject to change.

Oooh. That's a good plan actually. Goodluck.

Hi, would love to be part of this project. Hope there's enough room for one more

Sure @Omafovbe , happy to have you. we are still at the discussion stage and yesterday we planned on moving to GO based backend instead of Firebase which is the current approach. Because, Firebase is not going to be scalable going forward. Frontend is developed in React and we are planning to keep that as it is.
We will update you with our decisions. Let's keep in touch.


chore(deps): upgrade jenkins-x/jx3-versions to version 1.1.49

from: https://github.com/jenkins-x/lighthouse.git

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign hferentschik
You can assign the PR to them by writing /assign @hferentschik in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Reflect camelot in pypdf_table_extraction namespace

This is the elaboration of #9 and the first step in rebranding.
I copied the file structure to /pypdf_table_extraction and imported all the objects from camelot where needed. This way I tried to achieve to be completely backwards compatible.
from camelot.backends.poppler_backend import PopplerBackend
from pypdf_table_extraction.backends.poppler_backend import PopplerBackend

from camelot.handlers import Lattice,Stream
from pypdf_table_extraction.parsers import Lattice,Stream

@MartinThoma can I have your opinion here?

Is it ok, to move forward with this one and merge?

On a second thought, Let's merge this, after we merged all the open PR's from the old repo's here.
(As some are some big refactors, and merging them here is already a lot of work)

Just tested this, added some fixes.
This one has been sitting here some while.
So Let's go!!! :sparkles: :rocket:


[Landcover Toolkit] Set up eslint and fix all errors

[x] Add lint configuration to support EE code style and Google style
[x] Add npm run fix to auto-format and fix errors
[x] Remove config for clang
[x] Fix all lint errors, adding/fixing JSDoc as necessary

Once this PR is merged we can add CI checks to the main repo to ensure PRs pass lint checks.
Note that lint warnings also show in VS Code w/the appropriate extensions. For example, using ESLint:

@gorelick-google  I've reverted indentation fixes and lint checks, and clobbered old commits so this PR will have a cleaner history when merged. PTAL and reassign back to me when ready. Thanks!


Fix yeelight light brightness

Description:
The brightness should always be an integer.
Related issue (if applicable): fixes https://github.com/home-assistant/home-assistant/issues/14354#issuecomment-402252546
Checklist:

[ ] The code change is tested and works locally.
[x] Local tests pass with tox. Your PR cannot be merged unless tests pass

Thanks! 😎


Provide arm binaries

Is your feature request related to a problem? Please describe.
There is no arm binaries available for release, armv7 and aarch64
Describe the solution you'd like
To have arm binaries and not compiled the project manully.
Describe alternatives you've considered
Compile it manually.
Additional context
There is no other alternative over compiling the project.

Thanks @deepu105! I'll definitely test.

Hi @patrickelectric I still haven't had the chance to do this. If you are familiar with the Rust toolchain could you please help with this? Should be fairly straightforward to add the target to https://github.com/kdash-rs/kdash/blob/main/.github/workflows/cd.yml and test if everything is working as expected

Tha latest release v0.3.3 has ARM and aarch64 binaries. @patrickelectric can you please test and let me know if they work as expected? Please note that the copy to clipboard feature is disabled on those due to some library compatibility issues


fix static filez (by actually adding them)

Codecov Report

Merging #4 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master       #4   +/-   ##
=======================================
  Coverage   41.66%   41.66%
=======================================
  Files          18       18
  Lines         228      228
=======================================
  Hits           95       95
  Misses        133      133

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72d9bfd...e678fff. Read the comment docs.


CoinChange DP problem in java for HakinCodes #497

Have you read the Contributing Guidelines on Pull Requests?
Yes
Description
CoinChange DP problem in java
Checklist

[X] I've read the contribution guidelines.
[X] I've checked the issue list before deciding what to submit.
[X] I've edited the README.md and link to my code.

Related Issues or Pull Requests
For #497

@Kritika37 remove .cpp file since postorder traversal is already implemented in C-Plus-Plus/graphs/. Also, add sample input-output in .java file.

Hey, I have to mention input-output as comments in the file @iamrajiv

@Kritika37 sample input-output means provide examples

@Kritika37 sample input-output means provide examples

ya I know I am asking whether i should mention them in comments or directly @iamrajiv

Why is there Post Order Traversal file in Coin DP Change problem

I guess it is showing all the commit till now from different branches I have submitted @SKAUL05

@Kritika37 add examples at end of the code something like this
/*
...
*/

Why is there Post Order Traversal file in Coin DP Change problem

I guess it is showing all the commit till now from different branches I have submitted @SKAUL05

Please rebase it accordingly.
Use separate branches for separate issues

@Kritika37 add examples at end of the code something like this
/*
...
*/

ok

@Kritika37 removeC-Plus-Plus/README.md and C-Plus-Plus/ds/Binary_Tree_Postorder_Traversal.cpp

Hey please check this @SKAUL05

hey please check this once @SKAUL05

Hey, Please check this once @SKAUL05

Hey, Please check this once @SKAUL05

@all-contributors please add @Kritika37 for code