 (See message below.)
I'd rather the generator caught the exception and printed out an error message. Something like this:
No gist generated for "assert": assert/web/main.dart has a syntax error.

Here's what I saw instead (note: it doesn't mention "assert", making it harder to figure out what went wrong):
Unhandled exception:
Uncaught Error: Error in <unknown source>: Unterminated string literal

Error in <unknown source>: Expected to find ')'

Error in <unknown source>: Expected to find ';'

Error in <unknown source>: Expected to find ';'

Error in <unknown source>: Expected a statement

Error in <unknown source>: Unexpected token 'in'

Error in <unknown source>: Expected to find ';'

Error in <unknown source>: Expected an identifier

Error in <unknown source>: Expected to find ';'

Error in <unknown source>: Expected to find ';'

Stack Trace:
#0      _parseSource (package:analyzer/analyzer.dart:78)
#1      parseCompilationUnit (package:analyzer/analyzer.dart:38)
#2      AnalyzerUtil.findLibraries (package:gist/analyzer.dart:10)
#3      Generate._isDartpadAble (http://localhost:50109/gist.dart:125)
#4      ListMixin._filter (dart:collection/list.dart:278)
#5      Object&ListMixin.retainWhere (dart:collection/list.dart:268)
#6      Generate.run.<run_async_body> (http://localhost:50109/gist.dart:51)
#7      Future.Future.microtask.<anonymous closure> (dart:async/future.dart:144)
#8      _microtaskLoop (dart:async/schedule_microtask.dart:43)
#9      _microtaskLoopEntry (dart:async/schedule_microtask.dart:52)
#10     _runPendingImmediateCallback (dart:isolate-patch/isolate_patch.dart:96)
#11     _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:149)

#0      _rootHandleUncaughtError.<anonymous closure> (dart:async/zone.dart:895)
#1      _microtaskLoop (dart:async/schedule_microtask.dart:43)
#2      _microtaskLoopEntry (dart:async/schedule_microtask.dart:52)
#3      _runPendingImmediateCallback (dart:isolate-patch/isolate_patch.dart:96)
#4      _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:149)

Oh yeah, I see. I use the analyzer to see which libraries it imports. I'm not sure if i will be able to fix this before I go on holiday though.

No worries. The workaround is just to test the code before running gist generate.
Have great holiday!


I paid for the book, but the link in my email is not the full book.

What's going on? I paid for the book, I click on the link to start reading my book form the email, it takes me to a copy that starts each chapter with a sales pitch for the new price of the book and cuts each chapter short saying I need to buy the book. I did. What's up?

Hi @gnarmedia, if you see the chapter excerpts, it likely means that you are logged out.
To read the full book content, just log in with the email that you originally used to sign up and purchase the book.

@gnarmedia Hey Adam, you sound frustrated and rude. I just processed refund for you.
From Stripe:

Refunds take 5-10 days to appear on a customer's statement.


SecureEnd2endTest.BlockingAuthMetadataPluginAndProcessorSuccess

A stitched-up PR consisting of commits from #5809, #5843, and #5849 encountered the following errors, which are not deterministically linked to the changes made in the PR:
tests.bins/opt/end2end_test:SecureEnd2end/SecureEnd2endTest.BlockingAuthMetadataPluginAndProcessorSuccess/0 (from grpc.tests)
Failing for the past 1 build (Since Unstable#7163 )
Took 0.89 sec.
add description
Error Message
Failure
Standard Output
D0319 13:28:12.441136151   16366 test_config.c:276]          test slowdown: machine=1.000000 build=1.000000 total=1.000000
Note: Google Test filter = SecureEnd2end/SecureEnd2endTest.BlockingAuthMetadataPluginAndProcessorSuccess/0
[==========] Running 1 test from 1 test case.
[----------] Global test environment set-up.
[----------] 1 test from SecureEnd2end/SecureEnd2endTest
[ RUN      ] SecureEnd2end/SecureEnd2endTest.BlockingAuthMetadataPluginAndProcessorSuccess/0
I0319 13:28:12.443131069   16366 end2end_test.cc:198]        Scenario: proxy 0, credentials ssl
E0319 13:28:12.444652267   16366 tcp_client_posix.c:173]     failed to connect to 'ipv6:[::1]:32767': socket error: connection refused
D0319 13:28:12.457330945   16366 metadata.c:230]             WARNING: 1 metadata elements were leaked
D0319 13:28:12.457373068   16366 metadata.c:230]             WARNING: 1 metadata elements were leaked
D0319 13:28:12.457382996   16366 metadata.c:230]             WARNING: 1 metadata elements were leaked
D0319 13:28:12.457390299   16366 metadata.c:230]             WARNING: 1 metadata elements were leaked
D0319 13:28:12.457397419   16366 metadata.c:243]             WARNING: 1 metadata strings were leaked
D0319 13:28:12.457404266   16366 metadata.c:243]             WARNING: 1 metadata strings were leaked
D0319 13:28:12.457411301   16366 metadata.c:243]             WARNING: 1 metadata strings were leaked
D0319 13:28:12.457417518   16366 metadata.c:243]             WARNING: 1 metadata strings were leaked
D0319 13:28:12.457424042   16366 metadata.c:243]             WARNING: 2 metadata strings were leaked
D0319 13:28:12.457431541   16366 metadata.c:243]             WARNING: 1 metadata strings were leaked
D0319 13:28:12.457439018   16366 metadata.c:243]             WARNING: 1 metadata strings were leaked
D0319 13:28:12.457445425   16366 metadata.c:243]             WARNING: 1 metadata strings were leaked
D0319 13:28:12.457452233   16366 metadata.c:243]             WARNING: 1 metadata strings were leaked
D0319 13:28:12.457459230   16366 metadata.c:243]             WARNING: 1 metadata strings were leaked
[       OK ] SecureEnd2end/SecureEnd2endTest.BlockingAuthMetadataPluginAndProcessorSuccess/0 (14 ms)
[----------] 1 test from SecureEnd2end/SecureEnd2endTest (14 ms total)
[----------] Global test environment tear-down
[==========] 1 test from 1 test case ran. (14 ms total)
[  PASSED  ] 1 test.

Caught signal 11
bins/opt/end2end_test[0x547533]
/lib/x86_64-linux-gnu/libpthread.so.0(+0xf8d0)[0x7fde78e408d0]
bins/opt/end2end_test[0x47c5f3]
bins/opt/end2end_test[0x4765b2]
bins/opt/end2end_test[0x4ce1e4]
bins/opt/end2end_test[0x4726c2]
bins/opt/end2end_test[0x46b747]
bins/opt/end2end_test[0x4e7199]
bins/opt/end2end_test[0x4562e2]
bins/opt/end2end_test[0x45b6f1]
bins/opt/end2end_test[0x45b8c3]
/usr/lib/x86_64-linux-gnu/libstdc++.so.6(+0xb6970)[0x7fde789bb970]
/lib/x86_64-linux-gnu/libpthread.so.0(+0x80a4)[0x7fde78e390a4]
/lib/x86_64-linux-gnu/libc.so.6(clone+0x6d)[0x7fde7812b87d]
Command terminated by signal 11
real 0.84
user 0.00
sys 0.00

Happening for the following BlockingAuthMetadataPluginAndProcessorFailure as well.
tests.bins/opt/end2end_test:SecureEnd2end/SecureEnd2endTest.BlockingAuthMetadataPluginAndProcessorFailure/0 (from grpc.tests)

Failing for the past 1 build (Since Unstable#16133 )
Took 0.52 sec.
add description
Error Message

Failure
Standard Output

D0328 17:49:34.736821933   16882 test_config.c:278]          test slowdown: machine=1.000000 build=1.000000 total=1.000000
Note: Google Test filter = SecureEnd2end/SecureEnd2endTest.BlockingAuthMetadataPluginAndProcessorFailure/0
[==========] Running 1 test from 1 test case.
[----------] Global test environment set-up.
[----------] 1 test from SecureEnd2end/SecureEnd2endTest
[ RUN      ] SecureEnd2end/SecureEnd2endTest.BlockingAuthMetadataPluginAndProcessorFailure/0
I0328 17:49:34.738693791   16882 end2end_test.cc:198]        Scenario: proxy 0, credentials ssl
E0328 17:49:34.746187323   16883 tcp_client_posix.c:173]     failed to connect to 'ipv6:[::1]:32767': socket error: connection refused
E0328 17:49:34.768702691   16885 sync_posix.c:51]            assertion failed: pthread_mutex_lock(mu) == 0

*******************************
Caught signal 6
bins/opt/end2end_test[0x5479c3]
/lib/x86_64-linux-gnu/libpthread.so.0(+0xf8d0)[0x7ff32154f8d0]
/lib/x86_64-linux-gnu/libc.so.6(gsignal+0x37)[0x7ff320787067]
/lib/x86_64-linux-gnu/libc.so.6(abort+0x148)[0x7ff320788448]
bins/opt/end2end_test[0x46907d]
bins/opt/end2end_test[0x4744f3]
bins/opt/end2end_test[0x4761d9]
bins/opt/end2end_test[0x4ce584]
bins/opt/end2end_test[0x472b02]
bins/opt/end2end_test[0x46ba17]
bins/opt/end2end_test[0x471cd5]
bins/opt/end2end_test[0x46ba17]
bins/opt/end2end_test[0x4e7199]
bins/opt/end2end_test[0x4562e2]
bins/opt/end2end_test[0x45b6f1]
bins/opt/end2end_test[0x45b8c3]
/usr/lib/x86_64-linux-gnu/libstdc++.so.6(+0xb6970)[0x7ff3210ca970]
/lib/x86_64-linux-gnu/libpthread.so.0(+0x80a4)[0x7ff3215480a4]
/lib/x86_64-linux-gnu/libc.so.6(clone+0x6d)[0x7ff32083a87d]
Command terminated by signal 6
real 0.48
user 0.01
sys 0.00

I do not see this recently.


not getting connection using private token

Below statement does not give any results , its getting struct here only
GitLabApi gitLabApi = new GitLabApi(ApiVersion.V3, "http://your.gitlab.server.com", "YOUR_PRIVATE_TOKEN");

Not understanding your issue, this statement does nothing but allocate an object.  Is it throwing an exception, if so please provide the stack trace.

@KMadhuSudhan
Additionally, if you have not, you need to replace  "http://your.gitlab.server.com" and "YOUR_PRIVATE_TOKEN" with your values.

@KMadhuSudhan if you are still facing this issue, I can help you. If not, we can close this issue.

@KMadhuSudhan
Have you resolved this issue, if so, please close.

@KMadhuSudhan
I am closing this issue, if you need to re-open it, please feel free to do so.


Recommendation of problems based on the problems(/categories/tags) that user has not solved but yet popular!

hi I have created a simple problem recommender using python. My cfhandle is FanOfTourist.It is a very basic python script. if you increase userdifficulty variable in the program it will recommend easier problems and if you decrease it it will recommend harder problems.

Our codebase(backend) is also in Python. It would be so easy for you to integrate it.

How much data do stopstalk have to train a recommender system?
I just found stop stalk and it seems extremely interesting!

Hey @afcruzs , current stats are something like this -

3600+ users and 400+ custom users
~3.7M submissions
~38k unique problems (with and without tags)

Awesome. What information is there for each problem and for each user?, in order to model the features. Hoy many tagge problems are there?

Hey @afcruzs : Can you please mail me at<EMAIL_ADDRESS>, we can take the thread there :)


Ag grid theme editable-cell shouldn't set text align to right

Latest version

[X] I have tested the latest version

Description
It should be part of .numeric-cell not .editable-cell
Steps to reproduce
Inspect example - https://www.saltdesignsystem.com/salt/components/ag-grid-theme/examples#variants
Expected behavior
No response
Package name(s)
AG Grid Theme (@salt-ds/ag-grid-theme)
Package version(s)
2.1.0
Browser

[X] Chrome
[ ] Safari
[ ] Firefox
[ ] Microsoft Edge

Operating system

[X] macOS
[ ] Windows
[ ] Linux
[ ] iOS
[ ] Android

Are you a JPMorgan Chase & Co. employee?

[X] I am an employee of JPMorgan Chase & Co.

will be released in next release


upgrade protobuf to 2.4+

In 2.4.0, protobuf introduces some changes for java to make prorobuf message construction more efficient, which is very useful in large-scale data processing application, such as log transformation in Hadoop.
So comes the request.  Any comments?

Thanks for doing this, Angus! Looks good.
Kind of hard to believe they broke backwards compatibility just to move com.google to google. .. It'll take some time for us to merge this as we'll need to do this at the same time as upgrading all of our build machines to protoc 2.4, redeploy everything in sync, etc. Fun.

Thanks for the comments, dvryaboy.
Wait for the progress to start our own redeployment. :-)
BTW, I have created a issue concerning the weird package name in protobuf project.
http://code.google.com/p/protobuf/issues/detail?id=345


how to run llama.py/llama_ccp.py?

Hello,
I've seen that theres an API to use llama.cpp in an Open AI API like style, but I would rather want to run it like you do main when llama.cpp is made executable.
So I have tried to run llama_cpp.py which gives this error FileNotFoundError: Shared library with base name 'llama' not found
and I have tried to run llama.py which gives this error ImportError: attempted relative import with no known parent package
before you ask I have installed the llama-cpp-python library.
Any help is appreciated, Thank you!

What's the code you're calling and how did you install?

I did clone this repo and installed the llama-cpp-python package. Then I went into ./llama-cpp-python/llama_cpp and there I wanted to run llama.py or llama_cpp.py like you would if you installed llama.cpp where you run llama.cpp.

I did clone this repo and installed the llama-cpp-python package. Then I went into ./llama-cpp-python/llama_cpp and there I wanted to run llama.py or llama_cpp.py like you would if you installed llama.cpp where you run llama.cpp.

pip install jupyterlab
pip install notebook
cd your/folder/with/llama
jupyter notebook

>>> from llama_cpp import Llama
>>> llm = Llama(model_path="./models/7B/ggml-model.bin")
>>> output = llm("Q: Name the planets in the solar system? A: ", max_tokens=32, stop=["Q:", "\n"], echo=True)
>>> print(output)
{
  "id": "cmpl-xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx",
  "object": "text_completion",
  "created":<PHONE_NUMBER>,
  "model": "./models/7B/ggml-model.bin",
  "choices": [
    {
      "text": "Q: Name the planets in the solar system? A: Mercury, Venus, Earth, Mars, Jupiter, Saturn, Uranus, Neptune and Pluto.",
      "index": 0,
      "logprobs": None,
      "finish_reason": "stop"
    }
  ],
  "usage": {
    "prompt_tokens": 14,
    "completion_tokens": 28,
    "total_tokens": 42
  }
}

change path to model and run

Thank you for your response!
What are you trying to tell me?
I made the API work but im not happy with it as everytime I want a new prompt to be answered it needs to re load the model and it also likes to speak chinese which I am not capable of speaking sadly.
Thats why I wanted to run the main files in this repo on their own to maybe prevent the models from needing to be reloaded every time and speaking chinese as you can't specify a conversation before asking it something and then its just chinese somethimes if you would ask "Hello" as an example.

Can you please share exactly what you're running? It sounds like you're invoking llama_cpp.py directly which won't work. You need to import the modules as @Priestru showed in that example or check out the readme section on running llama_cpp.setver

Thanks!


Docs : Toggle Switch

[x] I have searched the Issues to see if this bug has already been reported
[x] I have tested the latest version

Steps to reproduce

Go to https://www.flowbite-react.com/docs/components/forms#toggle-switch

Current behaviour
Describe what is currently happening and why it's a problem.

Expected behaviour
Describe what you expected to happen.

Context
What are you trying to accomplish? Does this only happen on a specific browser, screen size, or operating system?
If possible, provide a live example URL, screenshot, video, or a repository with the minimal reproduction of the issue.

I recently encountered an issue in my application and realized that there has been a change in the Flowbite-react template. To address this issue for now, I added a custom theme. This solution might help others facing similar problems.
export const customThemeToggleSwitch: CustomFlowbiteTheme['toggleSwitch'] = {
    toggle: {
      base: "after:rounded-full rounded-full border group-focus:ring-4 group-focus:ring-cyan-500/25",
      checked: {
          on: "after:bg-white after:translate-x-full",
          off: "after:bg-gray-400 dark:after:bg-gray-500 border-gray-200 bg-gray-200 dark:border-gray-600 dark:bg-gray-700",
      },
    },
};

Additionally, I noticed that PR #1199 could potentially resolve this issue if integrated.

Working on this issue Docs : Toggle Switch #1321

HI, I am using the latest version and this bug is still there, same behavior, the fix with styling is not working cus now the thumb running out when on checked

HI, I am using the latest version and this bug is still there, same behavior, the fix with styling is not working cus now the thumb running out when on checked

Hey there, firstly make sure u are not overriding the theme in any way, both on global level (using <Flowbite> component) or local level by using the theme prop.


Get detailed error information

Is there any way to  get mor detailed error informations? (That is, [serial.on('error', console.log('ERROR'));

Found it in an example, sorry about that
function gotError(theerror) {
print(theerror);
}


Could not locate that index-pattern-field (id: postfix_queueid)

The dashboard het this message: Could not locate that index-pattern-field (id: postfix_queueid)

Make sure you've setup the Postfix bits (grok patterns, et al.) correctly and be sure to refresh the indexes.
See https://github.com/ActionScripted/elastic-kibana-postfix/issues/2#issuecomment-458057818 for a similar issue.

Make sure you've setup the Postfix bits (grok patterns, et al.) correctly and be sure to refresh the indexes.
See https://github.com/ActionScripted/elastic-kibana-postfix/issues/2#issuecomment-458057818 for a similar issue.


remote write: When ingesting, check that labels are indeed sorted lexicographically

Proposal
There are some references to the requirement (or assumption) of having lexicographically sorted labels throughout the code base. Some references in code and issues / PRs below:

Labels
func (ls Labels) HasDuplicateLabelNames()
promparse.go
https://github.com/prometheus/prometheus/issues/8861#issuecomment-855885421
https://github.com/prometheus/prometheus/pull/5372
https://github.com/prometheus/prometheus/pull/10532

Also the emerging remote write spec mentions this requirement.
This requirement is, however, not enforced when samples are being ingested (appended to head), unlike other similar requirements (no empty labels, no duplicate labels - these cases are considered 'invalid samples').
I'd like to understand:

Is label ordering a 'hard requirement', i.e. should such samples be considered invalid and we should refuse to append them and treat them similarly to empty / duplicate labels?
If yes, should this check be added to head append logic
If no, to understand better what are exactly the consequences of providing unsorted labels (and to have this explanation documented somewhere)

Good question. I would say labels have to be sorted.
From client_golang perspective, we have label sorting enforced by default.
We are also experimenting with different label sorting flows for Thanos Store API for better deduplication logic with @fpetkovski (https://github.com/thanos-io/thanos/pull/5796)
BTW: Can you tell us more about real consequences of having this implemented/required vs ... not doing anything? (:

I was mainly following up some changes we had upstream in Thanos (https://github.com/thanos-io/thanos/pull/5508) to validate labels, seeing now that labels are also somewhat being validated in TSDB before ingestion (what I mentioned above - no empty / duplicated labels). I assume with normal clients, this should not be a concern, as you mention, since client_golang enforces this. But in the upstream, where potentially users could be sending us data from unknown sources / "unofficial" clients via remote write, this guarantee might not exist (and this is indeed a case that occurred in our Thanos deployment).
As for real consequences - that's what I'm primarily trying to understand here (with my limited knowledge of these particular internal workings of Prometheus) - what happens if labels are ingested unsorted? Does this incur some performance penalty or are there more serious consequences?

Maybe it's a stupid question but does the label order in Prometheus affect the fingerprint hash calculation in AlertManager?

@roidelapluie that is true for scraping, but referring back to my original question, this might not be true for series coming over remote write. So even though it is a must, it is not being enforced upon ingestion. I'm still unclear on what the consequences of not having ordered labels are. Looks like we're having more discussions around this in the upstream as well (https://github.com/thanos-io/thanos/discussions/5866).

Regarding consequences, one thing that comes to mind is hashes being different depending on how labels are sorted: https://github.com/prometheus/prometheus/blob/main/model/labels/labels.go#L137

This is very clear that labels.Labels must be sorted inside Prometheus:
https://github.com/prometheus/prometheus/blob/b1566f761ef7d1c8ab6446afd017c0ce17e9224e/model/labels/labels.go#L42-L44
Another way in which behaviour will change is Labels.Compare will say that the same labels in different order are unequal, and will sort labels differently if they are in the wrong order.
IMO the Prometheus remote-write handler can error or it can sort the input, depending on how nice we want to be to callers.

We have optimisations that depend on ordering. PromQL does not work on
unsorted labels.
Le vendredi 11 novembre 2022, Bryan Boreham @.***> a
écrit :

This is very clear that labels.Labels must be sorted inside Prometheus:
https://github.com/prometheus/prometheus/blob/
b1566f761ef7d1c8ab6446afd017c0ce17e9224e/model/labels/labels.go#L42-L44
Another way in which behaviour will change is Labels.Compare will say
that the same labels in different order are unequal, and will sort labels
differently if they are in the wrong order.
IMO the Prometheus remote-write handler can error or it can sort the
input, depending on how nice we want to be to callers.
—
Reply to this email directly, view it on GitHub
https://github.com/prometheus/prometheus/issues/11505#issuecomment-1311901433,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AACHHJU7ZJJXMTIQ4DUWT5LWHZWB5ANCNFSM6AAAAAARTGALSU
.
You are receiving this because you were mentioned.Message ID:
@.***>

--
Pivo

Thanks for the clarifications everyone. I was mainly curious because we had some rouge series with unsorted labels in our system, but I haven't notice any adverse effects.
I'd agree then we should enforce this at least in remote write handler, if not alongside other label validation / sanitization in the head appender.

@bwplotka the Prometheus remote-write receiver doesn't check, currently.  See also #11571
I do not agree to add the check to head append logic, only to remote-write receiver.

IMO If you can create test that proves Prometheus can consumes unordered metric, then yes. If it's only the case for users of TSDB (as a library), then probably this check could live in the user side unless it's inefficient to do so.

If by Prometheus you mean when metrics come from scrapes, then as @roidelapluie commented in https://github.com/prometheus/prometheus/issues/11505#issuecomment-1309497821 this should be enforced at scrape time, so it should not be possible. It seems the consensus is to do this rather on remote write or to leave this up to upstream users, if TSDB is used as a library.

Hello from the bug scrub!
We understand the discussion that the problem is that Prometheus, when ingesting via remote write, does not ensure that the labels are sorted, as required by the remote write spec.
So the action left to do here is that Prometheus must reject remote write samples where the labels are not sorted.
Remote-read needs to be vetted, too.

Initial thoughts:

Whilst outright rejecting payloads with out-of-order label names might be the right thing to do according to spec adherence it may cause havoc if it was added with no way of disabling it. Soft enable first? Log problems? Plan for strict enforcement later (fix on the fly in the mean time)? Flag to enable strict mode (to be made default at a future point in time)?
UTF-8 label names and servers running in different locales (well, with different collations specifically) make "sorted lexicographically" more complex. For example, something that is in correct sort order with LC_COLLATE set to en-GB.UTF8 might not be in sort order with LC_COLLATE set to C. Having a consistent LC_COLLATE setting across all servers (especially if geographically distributed) may not be possible.

Areas to consider:

Collation across locales (as noted above)
Ingress: Scrape
Ingress: Remote Write 1.0 endpoint
Ingress: Remote Write 2.0 endpoint
Ingress: Remote Read result processing
Egress: Remote Write 1.0 payloads
Egress: Remote Write 2.0 payloads
Compliance tests

may cause havoc

Given there is no sort after receipt of data, flagging an error causes less havoc.

locales

Not an issue.  We're just comparing the bytes as numbers.

Ingress: Scrape

Scraping does not mandate labels are sorted when they arrive; Prometheus sorts the labels.

Remote Write

Prometheus generates labels correctly sorted on write.


Quiet Theme: Members List has Inconsistent Gaps Between Each

Sorry for the number of issues that I'm submitting, just trying help. I hope you understand.

I'm not sure why the Quiet logo and version number are right there either. But really good job on this theme, you're inspiring me to learn more about CSS because I didn't realize you could do that much with it.

hmmm the Inconsistent gaps are because of the "now playing" some have it some dont and that quiet thing is a bug


Remove prints from loadTdlib

Function loadTdlib has noisy prints and I can't disable it. Eg:
println("Try to load tdlib as library")
...
it.printStackTrace()
println("Try to load tdlib from artifact")
...
it.printStackTrace()
println("Try to load tdlib from local path: $path")
...
println("Can't load tdlib")

Maybe remove this lines?

Yes, good catch, it was useful during testing and understanding what goes wrong from users. Better to replace it with some custom exceptions in next release.


iOS App Build failed on M1 Pro Macbook

Description
iOS App version build crashes with exit code 1.
Version
0.67.3
Output of npx react-native info
System:
OS: macOS 12.2.1
CPU: (10) arm64 Apple M1 Pro
Memory: 1.20 GB / 16.00 GB
Shell: 5.8 - /bin/zsh
Binaries:
Node: 16.13.1 - /usr/local/bin/node
Yarn: 1.22.17 - /opt/homebrew/bin/yarn
npm: 6.14.15 - /usr/local/bin/npm
Watchman: 2<IP_ADDRESS> - /opt/homebrew/bin/watchman
Managers:
CocoaPods: 1.11.2 - /usr/local/bin/pod
SDKs:
iOS SDK:
Platforms: DriverKit 21.2, iOS 15.2, macOS 12.1, tvOS 15.2, watchOS 8.3
Android SDK: Not Found
IDEs:
Android Studio: Not Found
Xcode: 13.2.1/13C100 - /usr/bin/xcodebuild
Languages:
Java: Not Found
npmPackages:
@react-native-community/cli: Not Found
react: 17.0.2 => 17.0.2
react-native: 0.67.3 => 0.67.3
react-native-macos: Not Found
npmGlobalPackages:
react-native: Not Found
Steps to reproduce

Create new project with command

npx react-native init AwesomeTSProject --template react-native-template-typescript

Run Metro Bundler

npm run start

Run iOS Build

npm run ios

See an Error

Snack, code example, screenshot, or link to a repository
Crash log:
https://controlc.com/64ad9455

require_relative '../node_modules/react-native/scripts/react_native_pods'
require_relative '../node_modules/@react-native-community/cli-platform-ios/native_modules'
platform :ios, '11.0'
target 'TestApp' do
config = use_native_modules!
use_react_native!(
:path => config[:reactNativePath],
to enable hermes on iOS, change false to true and then install pods
:hermes_enabled => false
)
pod 'RNVectorIcons', :path => '../node_modules/react-native-vector-icons'
target 'testApp' do
inherit! :complete
Pods for testing
end
Enables Flipper.

Note that if you have use_frameworks! enabled, Flipper will not work and
you should disable the next line.
use_flipper!()÷
post_install do |installer|
react_native_post_install(installer)
__apply_Xcode_12_5_M1_post_install_workaround(installer)
end
end

use platform: ios,'11' and run pod install
require_relative '../node_modules/react-native/scripts/react_native_pods'
require_relative '../node_modules/@react-native-community/cli-platform-ios/native_modules'

platform :ios, '11.0'

target 'TestApp' do
 config = use_native_modules!

 use_react_native!(
   :path => config[:reactNativePath],
   # to enable hermes on iOS, change `false` to `true` and then install pods
   :hermes_enabled => false
 )
 pod 'RNVectorIcons', :path => '../node_modules/react-native-vector-icons'

 target 'testApp' do
   inherit! :complete
   # Pods for testing
 end
 # Enables Flipper.
 #
 # Note that if you have use_frameworks! enabled, Flipper will not work and
 # you should disable the next line.
 # use_flipper!()÷
 post_install do |installer|
   react_native_post_install(installer)
   __apply_Xcode_12_5_M1_post_install_workaround(installer)
 end
end

last version of React Native doesn't work with last iOS version?

use platform: ios,'11' and run pod install
require_relative '../node_modules/react-native/scripts/react_native_pods'
require_relative '../node_modules/@react-native-community/cli-platform-ios/native_modules'

platform :ios, '11.0'

target 'TestApp' do
 config = use_native_modules!

 use_react_native!(
   :path => config[:reactNativePath],
   # to enable hermes on iOS, change `false` to `true` and then install pods
   :hermes_enabled => false
 )
 pod 'RNVectorIcons', :path => '../node_modules/react-native-vector-icons'

 target 'testApp' do
   inherit! :complete
   # Pods for testing
 end
 # Enables Flipper.
 #
 # Note that if you have use_frameworks! enabled, Flipper will not work and
 # you should disable the next line.
 # use_flipper!()÷
 post_install do |installer|
   react_native_post_install(installer)
   __apply_Xcode_12_5_M1_post_install_workaround(installer)
 end
end

last version of React Native doesn't work with last iOS version?

one of the latest react native version 0.67.4 default use platform :ios, '11.0' in pods file

use platform: ios,'11' and run pod install
require_relative '../node_modules/react-native/scripts/react_native_pods'
require_relative '../node_modules/@react-native-community/cli-platform-ios/native_modules'

platform :ios, '11.0'

target 'TestApp' do
 config = use_native_modules!

 use_react_native!(
   :path => config[:reactNativePath],
   # to enable hermes on iOS, change `false` to `true` and then install pods
   :hermes_enabled => false
 )
 pod 'RNVectorIcons', :path => '../node_modules/react-native-vector-icons'

 target 'testApp' do
   inherit! :complete
   # Pods for testing
 end
 # Enables Flipper.
 #
 # Note that if you have use_frameworks! enabled, Flipper will not work and
 # you should disable the next line.
 # use_flipper!()÷
 post_install do |installer|
   react_native_post_install(installer)
   __apply_Xcode_12_5_M1_post_install_workaround(installer)
 end
end

last version of React Native doesn't work with last iOS version?

one of the latest react native version 0.67.4 default use platform :ios, '11.0' in pods file

Well, this doesn't work.

@khokanuzzman


Prisma + MongoDB many Relations not working

Bug description
Hello there, today i've got some problem. and idk this is bug or something else.
basically, i've got user model
model User {
  id            String   @id @default(auto()) @map("_id") @db.ObjectId
  wishlist      Products @relation(fields: [wishlistId], references: [id])
  wishlistId    String[] @unique @db.ObjectId
}

and products
model Products {
  id              String     @id @default(auto()) @map("_id") @db.ObjectId
  title           String
  User            User[]
}

Query i've got like this (for example):
await this.prisma.user.findMany({ include: { wishlist: true } });

MongoDB (for example):
wishlistId: [ "626cdd27e12f021cce54772f" -> ObjectID ]
any ideas? for fix this.
Environment & setup

OS: Mac OS
Database: MongoDB
Node.js version: 16.13.0

Prisma Version
3.13.0

Many to many relations work differently with Prisma and MongoDB right now and require a list on both sides: https://www.prisma.io/docs/concepts/components/prisma-schema/relations/many-to-many-relations#mongodb

Many to many relations work differently with Prisma and MongoDB right now and require a list on both sides: https://www.prisma.io/docs/concepts/components/prisma-schema/relations/many-to-many-relations#mongodb

Thanks, for this


chore: add ReverseReadTuples storage stub to support reverse expand

Description
This adds the ReverseReadTuples stub to the storage interface to support reverse queries for reverse expansion use cases. This will help us improve the implementation of the ListObjects API by reverse expanding tuples to reveal objects the user has access to.
References
Review Checklist

[ ] I have clicked on "allow edits by maintainers".
[ ] I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
[ ] The correct base branch is being used, if not main
[ ] I have added tests to validate that the change in functionality is working as expected

Tests will fail until it is implemented. Feel free to help with the implementation for the memory and postgres storage adapters 👍

@miparnisari do you mind renaming this signature based on what we discussed yesterday? I agree that a name such as ReadStartingWithUser probably is more logical at this point (until we refactor our storage interface to be more concise).

Codecov Report
Base: 76.86% // Head: 77.67% // Increases project coverage by +0.81% :tada:

Coverage data is based on head (dc60f19) compared to base (e088948).
Patch coverage: 95.50% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #241      +/-   ##
==========================================
+ Coverage   76.86%   77.67%   +0.81%
==========================================
  Files          80       81       +1
  Lines        8911     9076     +165
==========================================
+ Hits         6849     7050     +201
+ Misses       1704     1678      -26
+ Partials      358      348      -10

Impacted Files
Coverage Δ

storage/storage.go
91.75% <ø> (ø)

storage/postgres/postgres.go
65.61% <82.35%> (+0.33%)
:arrow_up:

storage/test/tuples.go
57.01% <97.95%> (+5.19%)
:arrow_up:

storage/memory/memory.go
90.59% <100.00%> (+0.41%)
:arrow_up:

storage/test/storage.go
100.00% <100.00%> (ø)

server/commands/write_authzmodel.go
71.87% <0.00%> (-22.36%)
:arrow_down:

server/errors/errors.go
78.20% <0.00%> (-2.06%)
:arrow_down:

pkg/id/id.go
71.42% <0.00%> (-1.91%)
:arrow_down:

server/test/server.go
88.09% <0.00%> (-1.04%)
:arrow_down:

server/test/write.go
65.78% <0.00%> (-0.88%)
:arrow_down:

... and 18 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


match email rule with link rule

Fixed Issues
$ GH_LINK https://github.com/Expensify/App/issues/28544
$ Proposal https://github.com/Expensify/App/issues/28544#issuecomment-1741831052
Tests

Go to any chat on New Expensify
In the composer, type [emoji](email) (for example [😄](abc@gmail.com)) and send
Verify that in the message sent, emoji is not changed to link

QA

Go to any chat on New Expensify
In the composer, type [emoji](email) (for example [😄](abc@gmail.com)) and send
Verify that in the message sent, emoji is not changed to link

Result
https://github.com/Expensify/expensify-common/assets/102477862/623ed57c-695a-4cb8-a22e-e6dedb3f7edc

I have read the CLA Document and I hereby sign the CLA

I have read the CLA Document and I hereby sign the CLA

Done @hoangzinh . Thanks!

Why are the author and reviewer checklists missing on this PR?

@hoangzinh Thanks. I fixed the lint error and pushed a commit. I wonder why the lint check workflow isn't shown now.


cannot import name 'torchvision_ssl_encoder'

Hi
I just want to run following example, but I get this error "cannot import name 'torchvision_ssl_encoder'"
from pl_bolts.utils.self_supervised import torchvision_ssl_encoder

resnet = torchvision_ssl_encoder('resnet18', pretrained=False, return_all_feature_maps=True)
x = torch.rand(3, 3, 32, 32)

feat_maps = resnet(x)

Is something wrong with pytorch-lightning-bolts?

@hrnademi can you share the exact message and some more details about your local env?

@hrnademi
I think torchvision_ssl_encoder is an internal function and thus hasn't been exported in utils/init.py. You can use the docs here: https://pytorch-lightning-bolts.readthedocs.io/en/latest/self_supervised_models.html to import the available pre-trained self-supervised learning models present.

I can confirm this issue on master
>>> from pl_bolts.utils.self_supervised import torchvision_ssl_encoder
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/Users/jirka/Workspace/pytorch-lightning-bolts/pl_bolts/utils/self_supervised.py", line 1, in <module>
    from pl_bolts.models.self_supervised import resnets
  File "/Users/jirka/Workspace/pytorch-lightning-bolts/pl_bolts/models/self_supervised/__init__.py", line 21, in <module>
    from pl_bolts.models.self_supervised.amdim.amdim_module import AMDIM
  File "/Users/jirka/Workspace/pytorch-lightning-bolts/pl_bolts/models/self_supervised/amdim/__init__.py", line 1, in <module>
    from pl_bolts.models.self_supervised.amdim.amdim_module import AMDIM
  File "/Users/jirka/Workspace/pytorch-lightning-bolts/pl_bolts/models/self_supervised/amdim/amdim_module.py", line 16, in <module>
    from pl_bolts.utils.self_supervised import torchvision_ssl_encoder
ImportError: cannot import name 'torchvision_ssl_encoder' from 'pl_bolts.utils.self_supervised' (/Users/jirka/Workspace/pytorch-lightning-bolts/pl_bolts/utils/self_supervised.py)

seems like we have cyclic import somewhere...

I have bolts version '0.3.4' and I am still getting the error.


CSS cannot PATCH lists [ ]

@timbl @michielbdejong
In /preferences/ Manage your Trusted App I tried to add https://podpro.dev
This should insert
:me acl:trustedApp
            [
                acl:mode acl:Append, acl:Control, acl:Read, acl:Write;
                acl:origin <https://podpro.dev>]

but failed with error 422. Some details
Preview
	{name: "UnprocessableEntityHttpError",…}
	details
	:
	{}
	errorCode
	:
	"H422"
	message
	:
	"An N3 Patch delete/insert formula can not contain blank nodes."
	name
	:
	"UnprocessableEntityHttpError"
	statusCode
	:
	422

Payload
	@prefix solid: <http://www.w3.org/ns/solid/terms#>.
	@prefix ex: <http://www.example.org/terms#>.

	_:patch

		  solid:inserts {
			<https://bourgeoa2.solidcommunity.net:8443/profile/card#me> <http://www.w3.org/ns/auth/acl#trustedApp> _:bn_wrjr7 .
			_:bn_wrjr7 <http://www.w3.org/ns/auth/acl#origin> <https://podpro.dev> .
			_:bn_wrjr7 <http://www.w3.org/ns/auth/acl#mode> <http://www.w3.org/ns/auth/acl#Read> .
			_:bn_wrjr7 <http://www.w3.org/ns/auth/acl#mode> <http://www.w3.org/ns/auth/acl#Write> .
			_:bn_wrjr7 <http://www.w3.org/ns/auth/acl#mode> <http://www.w3.org/ns/auth/acl#Append> .
			_:bn_wrjr7 <http://www.w3.org/ns/auth/acl#mode> <http://www.w3.org/ns/auth/acl#Control> .
		  };   a solid:InsertDeletePatch .

Thanks for spotting this! I think maybe this patch is actually incorrect. The _:patch in the subject is fine,  but why is there a blank node _:bn_wrjr7 in there? Can we change mashlib so that it uses a named node there?
CSS indeed checks this
And the spec indeed specifies this

Ah, I went for a different approach in https://github.com/solidos/solid-panes/pull/390, namely using a named node instead of a blank one for this thing:

                            [
                                acl:origin <https://podpro.dev>;
                                acl:mode
                                acl:Read, acl:Write, acl:Append, acl:Control
                            ].

I think we can consider this fixed, right @bourgeoa? Or are there still new conversations I'm unaware of?

Agree to close.
I shall open an issue in Rdflib


Identifiers validation failed for dataset Agrobiodiversidad de tres regiones de importancia biocultural en el centro-occidente de México

Identifier validation failed for the dataset Agrobiodiversidad de tres regiones de importancia biocultural en el centro-occidente de México:

Crawler attempt: 4
Publishing organization: Comisión nacional para el conocimiento y uso de la biodiversidad
Publishing country: MEXICO
Installation: IPTCONABIO
Number of occurrences indexed for this dataset at the time of the issue: 2928
Cause: GBIF ID problems exceed 50% threshold: 100% duplicates; 2928 total records; 2928 absent records
Pipelines execution steps: http://api.gbif.org/v1/pipelines/history/execution/3757084/step

New IDs sample:

Old IDs sample:

urn:catalog:CNRG-INIFAP:CNRG:NO DISPONIBLE:80701c8f859d5c386226e2897d0a069e
urn:catalog:CNRG-INIFAP:CNRG:NO DISPONIBLE:8e199531b055815d9e0b85ccacf5b481
urn:catalog:CNRG-INIFAP:CNRG:NO DISPONIBLE:ad3b2244ae75bf2c4e4fc89a0b6d445a
urn:catalog:COPANABIS:NO APLICA:NO APLICA:008ba4c33514b5de228ec84a442d145e
urn:catalog:COPANABIS:NO APLICA:NO APLICA:00c6768fc8baf5b236702029e8c007fb
urn:catalog:COPANABIS:NO APLICA:NO APLICA:0265890e5d81786b882c55ff2adbc016
urn:catalog:COPANABIS:NO APLICA:NO APLICA:03b390ab3f16442a5f26bea1075950ea
urn:catalog:COPANABIS:NO APLICA:NO APLICA:0429004f20b5c4c00966203681e3c3a8
urn:catalog:COPANABIS:NO APLICA:NO APLICA:08edea91edce1c973d569d460b0d2f7e
urn:catalog:COPANABIS:NO APLICA:NO APLICA:0bc4bedcc5f564de4ecd2269e0fe7bf5

Publisher email
Hello,
I am contacting you from the GBIF Secretariat about a dataset published by the Agrobiodiversidad de tres regiones de importancia biocultural en el centro-occidente de México : https://doi.org/10.15468/svraur.
We noticed that the occurrenceIDs were changed. We have temporarily paused the ingestions of this dataset.
As you might already know, when an occurrence record has a new occurrenceID for a given dataset, our system considers it to be a new occurrence.
This means that it will be given a new gbifid and a new occurrence URL (like this one: https://www.gbif.org/occurrence/1252968762) and the old gbifid and URL will be deprecated.
In this case, this means that the occurrence URLs would be deprecated when ingesting the newest versions of these datasets.
We would like to check with you if those changes were intentional. Do you know if this is the case?
Please let us know, thanks! We are happy to resume the dataset ingestion.
Note that some users rely on those occurrence URLs and gbifids (like https://bionomia.net for example). In an attempt to improve
the stability of the occurrence URLs and gbifids, we have implemented a warning system to detect these type of changes in datasets (see this news item).
If the data publisher can provide us with a list of old and new occurrenceIDs per record, we can avoid the identifier and URL changes. Could that be an option?
Please let us know if you have any question. Thanks!
All the best,

You can skip/fix identifier validation using the registry UI.

Identifier validation still  failing for the dataset Agrobiodiversidad de tres regiones de importancia biocultural en el centro-occidente de México:

Crawler attempt: 5
Publishing organization: Comisión nacional para el conocimiento y uso de la biodiversidad
Publishing country: MEXICO
Installation: IPTCONABIO
Number of occurrences indexed for this dataset at the time of the issue: 2928
Cause: GBIF ID problems exceed 50% threshold: 100% duplicates; 2928 total records; 2928 absent records
Pipelines execution steps: http://api.gbif.org/v1/pipelines/history/execution/3757207/step

New IDs sample:

Old IDs sample:

urn:catalog:CNRG-INIFAP:CNRG:NO DISPONIBLE:80701c8f859d5c386226e2897d0a069e
urn:catalog:CNRG-INIFAP:CNRG:NO DISPONIBLE:8e199531b055815d9e0b85ccacf5b481
urn:catalog:CNRG-INIFAP:CNRG:NO DISPONIBLE:ad3b2244ae75bf2c4e4fc89a0b6d445a
urn:catalog:COPANABIS:NO APLICA:NO APLICA:008ba4c33514b5de228ec84a442d145e
urn:catalog:COPANABIS:NO APLICA:NO APLICA:00c6768fc8baf5b236702029e8c007fb
urn:catalog:COPANABIS:NO APLICA:NO APLICA:0265890e5d81786b882c55ff2adbc016
urn:catalog:COPANABIS:NO APLICA:NO APLICA:03b390ab3f16442a5f26bea1075950ea
urn:catalog:COPANABIS:NO APLICA:NO APLICA:0429004f20b5c4c00966203681e3c3a8
urn:catalog:COPANABIS:NO APLICA:NO APLICA:08edea91edce1c973d569d460b0d2f7e
urn:catalog:COPANABIS:NO APLICA:NO APLICA:0bc4bedcc5f564de4ecd2269e0fe7bf5

Publisher email
Hello,
I am contacting you from the GBIF Secretariat about a dataset published by the Agrobiodiversidad de tres regiones de importancia biocultural en el centro-occidente de México : https://doi.org/10.15468/svraur.
We noticed that the occurrenceIDs were changed. We have temporarily paused the ingestions of this dataset.
As you might already know, when an occurrence record has a new occurrenceID for a given dataset, our system considers it to be a new occurrence.
This means that it will be given a new gbifid and a new occurrence URL (like this one: https://www.gbif.org/occurrence/1252968762) and the old gbifid and URL will be deprecated.
In this case, this means that the occurrence URLs would be deprecated when ingesting the newest versions of these datasets.
We would like to check with you if those changes were intentional. Do you know if this is the case?
Please let us know, thanks! We are happy to resume the dataset ingestion.
Note that some users rely on those occurrence URLs and gbifids (like https://bionomia.net for example). In an attempt to improve
the stability of the occurrence URLs and gbifids, we have implemented a warning system to detect these type of changes in datasets (see this news item).
If the data publisher can provide us with a list of old and new occurrenceIDs per record, we can avoid the identifier and URL changes. Could that be an option?
Please let us know if you have any question. Thanks!
All the best,

You can skip/fix identifier validation using the registry UI.


Emc networker b&r

Description
This PR...

Types of changes

[ ] Breaking change (fix or feature that would cause existing functionality to change)
[X ] New feature (non-breaking change which adds functionality)
[ ] Bug fix (non-breaking change which fixes an issue)
[ ] Enhancement (improves an existing feature and functionality)
[ ] Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale

[ ] Major
[ ] Minor

Bug Severity

[ ] BLOCKER
[ ] Critical
[ ] Major
[ ] Minor
[ ] Trivial

Screenshots (if appropriate):
How Has This Been Tested?
  A small scale lab environment with two Hypervisors, One Management server, one zone, one cluster. Three different accounts with VMs.  Multiple users performing common scenarios for seven days now.
 All the B&R cases with the exception of SLA Based backups that is not supported by the Backup Vendor have been tested. Backup and Restore of whole VMs and single volumes. Import of backup offerings from the external provider. Assignment of backup offerings to VMs.
 There is a basic implementation of the B&R functionality on the KVM Hypervisor Guru.

Great to see this PR @fermosan. Thank you.
Can you please add some description which gives some details about the PR changes like the operations that are supported, how to configure and all?

Hello @harikrishna-patnala .  There is a pending documentation pull as well at:
https://github.com/apache/cloudstack-documentation/pull/281
As mentioned there all the B&R framework functionality is supported with the exception of SLA backups. Networker cannot support something like that without DELL EMC doing some implementation on their own for KVM hypervisors.  If the documentation is not sufficient let me know what you want me to describe and i will be more than happy to do it.
Thanks again,

@blueorangutan package

@rohityadavcloud a Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 3754

@blueorangutan package

@harikrishna-patnala a Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

nice work @fermosan

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6550 (SL-JID-1952)

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@DaanHoogland @rohityadavcloud @harikrishna-patnala  Is JaCoCo failing for some particular reason ?

UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6550 (SL-JID-1957)

@DaanHoogland @rohityadavcloud @harikrishna-patnala Is JaCoCo failing for some particular reason ?

are you fully ready yet, @fermosan ? let's not worry about jococo untill we are ready to merge.

@DaanHoogland @rohityadavcloud @harikrishna-patnala Is JaCoCo failing for some particular reason ?

are you fully ready yet, @fermosan ? let's not worry about jococo untill we are ready to merge.

Our tests look good. We are running some scenarios now. Surely, there will be another commit for the documentation pull in cloudstack-documentation.
I am currently looking at the following scenario. Maybe you can suggest something. The backups are meant to expire at predefined retention days configured by the administrator on the Networker side. This will happen automatically and Cloudstack B&R Framework will be unaware of this. It looks like BackupSyncTask in B&R implementation can be utilized to do that.

Yes. That worked like a charm.  I'll keep you posted as I make progress.

@DaanHoogland This commit concludes all the designed functionality for the plugin.
Backups are registered / removed properly from/to Cloudstack.
We will keep testing in internally for a few more days and there are some plans for doing some more cleanups in the bash shell scripts in case the backup is not successful (with EMC Networker to blaim for this and not Cloudstack).  There are few instructions to add in the documentation pull for administrators. However, Networker is quite complex piece of software and is impossible to go in great depth.
Also, in Dev mailing list a UI bug was found for creating Schedules.  Is there a bug report / issue for that one or we need to open one ? I think @svenvogel  acknowledged the bug.
Lastly, you think we can include this in the next release provided that everything is working as expected?

@rohityadavcloud , what is the status of the jacoco validator? I've seen unexplained failures in other PRs too.

@DaanHoogland This commit concludes all the designed functionality for the plugin. Backups are registered / removed properly from/to Cloudstack. We will keep testing in internally for a few more days and there are some plans for doing some more cleanups in the bash shell scripts in case the backup is not successful (with EMC Networker to blaim for this and not Cloudstack). There are few instructions to add in the documentation pull for administrators. However, Networker is quite complex piece of software and is impossible to go in great depth.

:+1:
...

Lastly, you think we can include this in the next release provided that everything is working as expected?

sure, if it works it's in

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

UI build: :heavy_multiplication_x:
(SL-JID-1964)

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

UI build: :heavy_multiplication_x:
(SL-JID-1965)

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6550 (SL-JID-1966)

you have a small conflict @fermosan . can you resolve it? (will happen more often the coming time, I'm sure)

It is resolved.

@rohityadavcloud Can you provide some insight regarding JaCoCo errors ? Is it something with the commit ?

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6550 (SL-JID-1976)

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6550 (SL-JID-2013)

@rohityadavcloud @DaanHoogland A quick update.  Our tests doing great here. Everything works as expected. We will keep testing for a few more weeks.  When is <IP_ADDRESS> scheduled to be released and approximately when 4.18.0 ?  Maybe we can catch the deadline for <IP_ADDRESS> unless you don't want to introduce new features in a minor version for some reason.

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6550 (SL-JID-2032)

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6550 (SL-JID-2042)

@blueorangutan package

@DaanHoogland a Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 3876

@blueorangutan test

@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

Trillian test result (tid-4591)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 48396 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6550-t4591-kvm-centos7.zip
Smoke tests completed. 100 look OK, 1 have errors
Only failed tests results shown below:

Test
Result
Time (s)
Test File

test_08_upgrade_kubernetes_ha_cluster
Failure
579.71
test_kubernetes_clusters.py

@rohityadavcloud @harikrishna-patnala @slavkap CLGTM i don´t think we have anybody other than @fermosan and colleagues to test this. Can you agree we can merge?

@blueorangutan package

@DaanHoogland a Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Packaging result: :heavy_multiplication_x: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 3898

Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. LL-JID 96

@blueorangutan test

@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@slavkap are your concerns met?

@DaanHoogland  @slavkap Thank you for your review and approvals. Of course we are going to maintain it since it will be actively used. It will be moved to <IP_ADDRESS> milestone or stay for 4.18 ?

@blueorangutan test

@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@DaanHoogland @slavkap Thank you for your review and approvals. Of course we are going to maintain it since it will be actively used. It will be moved to <IP_ADDRESS> milestone or stay for 4.18 ?

new features never go in dot releases, so 4.18 I'd say. Also it is targetted to main so the next release made from that branch ;)

@blueorangutan package

@rohityadavcloud a Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 4000

@blueorangutan test

@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

Trillian Build Failed (tid-4723)

Trillian test result (tid-4724)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 43604 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6550-t4724-kvm-centos7.zip
Smoke tests completed. 100 look OK, 1 have errors
Only failed tests results shown below:

Test
Result
Time (s)
Test File

test_08_upgrade_kubernetes_ha_cluster
Failure
577.23
test_kubernetes_clusters.py

@harikrishna-patnala I'm going to close/open to see if we can get some sonarcube output. Other than that I am counting two LGTM and testing performed and will merge. Do you want to have a second look, as well?

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6550 (SL-JID-2232)

Hello, replies inline.

Did a round of review, in addition to the requested changes or questions, pl also:

rebase your branch against last main branch to allow sonar and other checks to re-kick
done.
look at any code smells reported by the sonarcloud bot and see coverage report by codecov if it helps to improve the code
will do
add any marvin/functional test
There are some tests already implemented.

Misc:

Does this plugin ship as enabled by default, is there a way to disable it?
It is enabled by selecting Networker as B&R Plugin from general options.
Does it require any UI or DB/schema changes etc?
No UI or DB/schema changes required.

For more details you can check: https://github.com/apache/cloudstack-documentation/pull/281
Since it's vacation period for us we will revert with the changes your requested when we get back.

We'll have to do without sonar output on this one I guess. It wasn't triggered, even after re-opening.

@DaanHoogland  @rohityadavcloud
Hello, how we can kick in sonar ?

@DaanHoogland @rohityadavcloud Hello, how we can kick in sonar ?

@fermosan you can run it from your IDE, it should run automatically on PRs. There are free plugins for most IDEs.

@DaanHoogland @rohityadavcloud Hello, how we can kick in sonar ?

@fermosan , maybe do as @rohityadavcloud suggested and rebase your code on latest, then force push it to your branch.
 I'll keep you posted as I make progress.

@DaanHoogland @rohityadavcloud Hello, how we can kick in sonar ?

@fermosan , maybe do as @rohityadavcloud suggested and rebase your code on latest, then force push it to your branch. Did you manage to run sonar locally?

@DaanHoogland We should now be rebased. Can you confirm all is ok so we can move on with the test of the review notes?

Yes @fermosan, all looks good, I'll re-run the regression tests.
@blueorangutan package

@DaanHoogland a Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@rohityadavcloud can you have a second look in terms of the B&R framework architecture, please?

@blueorangutan package

@DaanHoogland a Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 4299

@blueorangutan package

@DaanHoogland a Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 4303

@blueorangutan test

@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

Trillian test result (tid-5038)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 40606 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6550-t5038-kvm-centos7.zip
Smoke tests completed. 102 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test
Result
Time (s)
Test File

test_08_upgrade_kubernetes_ha_cluster
Failure
567.99
test_kubernetes_clusters.py

I'll try to complete a round of review
@blueorangutan test centos7 vmware-67u3

@rohityadavcloud a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests

Trillian test result (tid-5055)
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 40249 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6550-t5055-vmware-67u3.zip
Smoke tests completed. 103 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test
Result
Time (s)
Test File

@blueorangutan package

@rohityadavcloud a Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Packaging result: :heavy_multiplication_x: el7 :heavy_multiplication_x: el8 :heavy_multiplication_x: debian :heavy_multiplication_x: suse15. SL-JID 4386

@blueorangutan package

@rohityadavcloud a Jenkins job has been kicked to build packages. It will be bundled with
SystemVM template(s). I'll keep you posted as I make progress.

Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 4400

@blueorangutan test matrix

@rohityadavcloud a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests

Trillian test result (tid-5088)
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 37778 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6550-t5088-xenserver-71.zip
Smoke tests completed. 104 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test
Result
Time (s)
Test File

Trillian test result (tid-5089)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 45537 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6550-t5089-kvm-centos7.zip
Smoke tests completed. 103 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test
Result
Time (s)
Test File

test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers
Failure
464.49
test_vpc_redundant.py

test_05_rvpc_multi_tiers
Failure
426.33
test_vpc_redundant.py

Trillian test result (tid-5090)
Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7
Total time taken: 49189 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6550-t5090-vmware-65u2.zip
Smoke tests completed. 102 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test
Result
Time (s)
Test File

test_02_upgrade_kubernetes_cluster
Failure
544.75
test_kubernetes_clusters.py

test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers
Failure
591.73
test_vpc_redundant.py

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6550 (SL-JID-2512)

UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6550 (SL-JID-2523)

@fermosan did you answer all @rohityadavcloud 's comments? (i.e. do you guys agree this is ready or not?)

@fermosan did you answer all @rohityadavcloud 's comments? (i.e. do you guys agree this is ready or not?)

@DaanHoogland @rohityadavcloud.  There are two pending comments regarding NPEs for minCores and minMemory. I did not implemented them, they were there. I haven't looked all the code to determine if those values can ever be undefined.
We redeployed all the code (with current branch and fixes) to a new environment and run all tests again. Everything was found in good order.

@blueorangutan package

@DaanHoogland a Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 4504

@blueorangutan test

@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

Trillian test result (tid-5170)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 44096 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6550-t5170-kvm-centos7.zip
Smoke tests completed. 102 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test
Result
Time (s)
Test File

test_08_upgrade_kubernetes_ha_cluster
Failure
621.75
test_kubernetes_clusters.py

test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers
Failure
453.88
test_vpc_redundant.py

insanity:
@blueorangutan test

@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

Trillian test result (tid-5178)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 40179 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6550-t5178-kvm-centos7.zip
Smoke tests completed. 103 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test
Result
Time (s)
Test File

test_08_upgrade_kubernetes_ha_cluster
Failure
567.35
test_kubernetes_clusters.py

@DaanHoogland sorry I was away on holidays, I'll address it this week
@blueorangutan package

@rohityadavcloud a Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 4591

@blueorangutan test

@rohityadavcloud a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

Left some outstanding remarks otherwise LGTM. @fermosan can you comment if this plugin disable by default? (if not could be add a global setting to disable this by default and have it enabled via a global setting?)

Hello. Yes there are the following global settings:

-- | --
backup.plugin.networker.url | DELL EMC Networker server URL. Default: https://localhost:9090/nwrestapi/v3
backup.plugin.networker.username | DELL EMC Networker server username. Default: administrator
backup.plugin.networker.password | DELL EMC Networker server password. Default: password
backup.plugin.networker.pool | DELL EMC Networker Media Pool. Default: Default
backup.plugin.networker.validate.ssl | Whether to validate API server (SSL/TLS) connection.  Default: false
backup.plugin.networker.request.timeout | DELL EMC Networker API request timeout in seconds. Default: 300
backup.plugin.networker.client.verbosity | DELL EMC Networker Client verbosity: Default: false

If i am not mistaken the enable/disable for the plugin is done by setting the global backup.framework.provider.plugin to the desired plugin value.

Trillian test result (tid-5233)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 40027 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6550-t5233-kvm-centos7.zip
Smoke tests completed. 104 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test
Result
Time (s)
Test File

Thanks @fermosan your comments about the framework level provider/settings makes sense (I forgot that was already in place). Kindly review other outstanding comments, I think this is ready for merging once you address them. cc @DaanHoogland @nvazquez

ping @fermosan you see any chance to address @rohityadavcloud 's remaining comments?

ping @fermosan you see any chance to address @rohityadavcloud 's remaining comments?

Yes. @DaanHoogland
Updates:
if (guestOsMapping == null || hostVo == null)  will be reverted in a coming patch
I am trying to see if we can use the Script.findScript().  I cannot find a way to make this work. The function is called on the management server side and the script cannot be found since it exists on the client.
Furthermore in the development environment the lookup path is under the local development directories.
There is now straight way to get "kvm.script.dir" or "scripts.path" from environ since configure for super is not there.
If there is no way for this to work the full path will be used there.  Any ideas ?
I am also working on eliminating the need for sudo execution on the KVM host side (needs some work/testing and more conf in
the EMC networker side). If successful, i will commit here and update the documentation pull as well to reflect that.
For the [ui/public/config.json] I will revert the changes and match main in a coming patch.
Finally for the comments about
int minCpuCores = virtualMachineTo.getCpus();
long minMemory = virtualMachineTo.getMinRam();
The code was there beforehand and as far as I can see it is not used by any other components. It is however used in the tests. I am not sure what is supposed to do and which components are supposed to call it if any. Any inputs ? How we going to proceed on that ? My guess is that it has to do something with the computer offerings. Can those be null under any circumstance ?
Maybe @nvazquez  has some input for the above.

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

ping @fermosan you see any chance to address @rohityadavcloud 's remaining comments?

Yes. @DaanHoogland Updates: if (guestOsMapping == null || hostVo == null) will be reverted in a coming patch
I am trying to see if we can use the Script.findScript(). I cannot find a way to make this work. The function is called on the management server side and the script cannot be found since it exists on the client. Furthermore in the development environment the lookup path is under the local development directories. There is now straight way to get "kvm.script.dir" or "scripts.path" from environ since configure for super is not there. If there is no way for this to work the full path will be used there. Any ideas ?
I am also working on eliminating the need for sudo execution on the KVM host side (needs some work/testing and more conf in the EMC networker side). If successful, i will commit here and update the documentation pull as well to reflect that.
For the [ui/public/config.json] I will revert the changes and match main in a coming patch.
Finally for the comments about
int minCpuCores = virtualMachineTo.getCpus(); long minMemory = virtualMachineTo.getMinRam();
The code was there beforehand and as far as I can see it is not used by any other components. It is however used in the tests. I am not sure what is supposed to do and which components are supposed to call it if any. Any inputs ? How we going to proceed on that ? My guess is that it has to do something with the computer offerings. Can those be null under any circumstance ?
Maybe @nvazquez has some input for the above.

@DaanHoogland @rohityadavcloud

Reverted config.json and HostVO null checks
Eliminated the need to run sudo from cs side. Documentation pull is also updated.

Only two remaining points of discussion are:
minCpuCores /  minMemory
If anyone has any input about the usability of the supposed usability of those in KVMGuru let me know.
script.findScr
Couldn't find a way to utilize it from the management side. Will give it another try.  If not it will remain as it is for now.

Script.findScript can work in the Cmd handler on the KVM resource (libvirtcomputingresource) and it depends exactly where/how you want to run it.

minCpuCores / minMemory
If anyone has any input about the usability of the supposed usability of those in KVMGuru let me know.

On the first issue ^^, @weizhouapache or @shwstppr can you check and advise?

@blueorangutan package

@DaanHoogland a Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@rohityadavcloud @weizhouapache @shwstppr @fermosan is there anything left to discuss here?

Packaging result: :heavy_check_mark: el7 :heavy_multiplication_x: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 4906

Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_multiplication_x: debian :heavy_check_mark: suse15. SL-JID 4992

Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 5019

@blueorangutan test matrix

@DaanHoogland a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests

Trillian test result (tid-5566)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 43733 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6550-t5566-kvm-centos7.zip
Smoke tests completed. 104 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test
Result
Time (s)
Test File

test_04_autoscale_kubernetes_cluster
Failure
32.90
test_kubernetes_clusters.py

test_08_upgrade_kubernetes_ha_cluster
Failure
569.24
test_kubernetes_clusters.py

Trillian test result (tid-5565)
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 46161 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6550-t5565-xenserver-71.zip
Smoke tests completed. 105 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test
Result
Time (s)
Test File

@rohityadavcloud @weizhouapache @shwstppr @fermosan is there anything left to discuss here?

@DaanHoogland i think that there are some questions to be answered. What is a rough estimation for the 4.18 release ?

@rohityadavcloud @weizhouapache @shwstppr @fermosan is there anything left to discuss here?

@DaanHoogland i think that there are some questions to be answered. What is a rough estimation for the 4.18 release ?

@fermosan it should be the second half of januari, but it would be nice to have this in for a couple of weeks to get people to test it and stabilise if needed,

Trillian test result (tid-5567) Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7 Total time taken: 53426 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6550-t5567-vmware-65u2.zip Smoke tests completed. 103 look OK, 2 have errors, 0 did not run Only failed and skipped tests results shown below:
Test 	Result 	Time (s) 	Test File
test_02_create_template_with_checksum_sha1 	Error 	5.16 	test_templates.py
test_03_create_template_with_checksum_sha256 	Error 	5.17 	test_templates.py
test_04_create_template_with_checksum_md5 	Error 	5.15 	test_templates.py
test_02_upgrade_kubernetes_cluster 	Failure 	537.80 	test_kubernetes_clusters.py
test_08_upgrade_kubernetes_ha_cluster 	Error 	4093.32 	test_kubernetes_clusters.py
test_09_delete_kubernetes_ha_cluster 	Failure 	0.05 	test_kubernetes_clusters.py
ContextSuite context=TestKubernetesCluster>:teardown 	Error 	45.96 	test_kubernetes_clusters.py

the test_templates errors are handled in #7001

@blueorangutan test matrix

@blueorangutan package

@rohityadavcloud a Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@rohityadavcloud @fermosan do we reset the package-lock.json on this? I think we can merge as soon as we have.

Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 5055

@blueorangutan test

@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@rohityadavcloud @fermosan do we reset the package-lock.json on this? I think we can merge as soon as we have.

re-ping, before this gets rained down by BO messages, @rohityadavcloud @fermosan

@rohityadavcloud @fermosan do we reset the package-lock.json on this? I think we can merge as soon as we have.

re-ping, before this gets rained down by BO messages, @rohityadavcloud @fermosan

@DaanHoogland  @rohityadavcloud  I thnik we can reset.

Trillian test result (tid-5613)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 43891 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6550-t5613-kvm-centos7.zip
Smoke tests completed. 105 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test
Result
Time (s)
Test File

test_08_upgrade_kubernetes_ha_cluster
Failure
590.78
test_kubernetes_clusters.py

@rohityadavcloud @fermosan do we reset the package-lock.json on this? I think we can merge as soon as we have.

re-ping, before this gets rained down by BO messages, @rohityadavcloud @fermosan

@DaanHoogland @rohityadavcloud I thnik we can reset.

ok, @fermosan , can you please do that? I'll rerun a quick package build / test as soon as you have. Hope to merge over x-mas ;)

@fermosan sorry to be bugging you. I don´t think the package-lock is intended to be deleted, just to remain unchanged.

@blueorangutan package

@DaanHoogland a Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan test matrix

@fermosan sorry to be bugging you. I don´t think the package-lock is intended to be deleted, just to remain unchanged.

@DaanHoogland  No prob. I pulled from origin/main and added

Packaging result: :heavy_check_mark: el7 :heavy_multiplication_x: el8 :heavy_multiplication_x: el9 :heavy_multiplication_x: debian :heavy_multiplication_x: suse15. SL-JID 5079

@blueorangutan package

@DaanHoogland a Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 5080

@blueorangutan test matrix

@DaanHoogland a Trillian-Jenkins matrix job (centos7 mgmt + xenserver71, rocky8 mgmt + vmware67u3, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests

@blueorangutan package

@rohityadavcloud a Jenkins job has been kicked to build packages. It will be bundled with
SystemVM template(s). I'll keep you posted as I make progress.

Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 5085

@blueorangutan test matrix

@DaanHoogland a Trillian-Jenkins matrix job (centos7 mgmt + xenserver71, rocky8 mgmt + vmware67u3, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests

one last time
@blueorangutan package

@DaanHoogland a Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 5125

@blueorangutan test matrix

@DaanHoogland a Trillian-Jenkins matrix job (centos7 mgmt + xenserver71, rocky8 mgmt + vmware67u3, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests

Trillian test result (tid-5687)
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 38887 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6550-t5687-xenserver-71.zip
Smoke tests completed. 106 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test
Result
Time (s)
Test File

Trillian test result (tid-5689)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 42336 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6550-t5689-kvm-centos7.zip
Smoke tests completed. 105 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test
Result
Time (s)
Test File

test_08_upgrade_kubernetes_ha_cluster
Failure
580.23
test_kubernetes_clusters.py

Trillian test result (tid-5688)
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server r8
Total time taken: 51317 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6550-t5688-vmware-67u3.zip
Smoke tests completed. 105 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test
Result
Time (s)
Test File

test_07_arping_in_vr
Failure
5.22
test_diagnostics.py

@blueorangutan package

@DaanHoogland a Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Packaging result: :heavy_multiplication_x: el7 :heavy_multiplication_x: el8 :heavy_multiplication_x: el9 :heavy_multiplication_x: debian :heavy_multiplication_x: suse15. SL-JID 5170

Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 5174

@blueorangutan test matrix

@DaanHoogland a Trillian-Jenkins matrix job (centos7 mgmt + xenserver71, rocky8 mgmt + vmware67u3, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests

Trillian test result (tid-5747)
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 42964 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6550-t5747-xenserver-71.zip
Smoke tests completed. 106 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test
Result
Time (s)
Test File

Trillian test result (tid-5748)
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server r8
Total time taken: 47433 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6550-t5748-vmware-67u3.zip
Smoke tests completed. 106 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test
Result
Time (s)
Test File

As I saw the error on the jacoco build in another PR on the apache jenkins as well, I am going to merge.

@DaanHoogland  Hello and happy new year. We leave this pull as it is for further communication or i delete branch ?

@fermosan you can delete the branch, we can create new PRs or issues if we need to and we also have<EMAIL_ADDRESS>


NU5 Tracking: Required ZIPs

This epic will track the ZIPs that we will need to implement ahead of NU5 testnet activation.

NU5 Proposed ZIPs

ZIP 216: Require Canonical Jubjub Point Encodings - #1798
ZIP 224: Orchard Shielded Protocol - #1742, #1864
ZIP 225: Version 5 Transaction Format - ~#1822~, #1829, #1863
ZIP 244: Transaction Identifier Non-Malleability - #1874, #881
ZIP 252: Deployment of the NU5 Network Upgrade - #1841, ~#1797~

NU4: Canopy

ZIP 207: Funding Streams - #801 (excluding founders reward)
ZIP 211: Disabling Addition of New Value to the Sprout Value Pool - #1564
ZIP 212: Allow Recipient to Derive Sapling Ephemeral Secret from Note Plaintext - #785 (excluding sender)
ZIP 214: Consensus rules for a Zcash Development Fund - #801 (excluding founders reward)
~ZIP 215: Explicitly Defining and Modifying Ed25519 Validation Rules - #1565~
ZIP 251: Deployment of the Canopy Network Upgrade - #1597

NU3: Heartwood

ZIP-221: Flyclient - #1567
ZIP-213: Shielded Coinbase - #608
ZIP 250: Deployment of the Heartwood Network Upgrade

NU2: Blossom

ZIP-208: Shorter Block Target Spacing
ZIP-206: Deployment of the Blossom Network Upgrade

NU1: Sapling

ZIP-243: Transaction Signature Validation for Sapling
ZIP-32: Shielded Hierarchical Deterministic Wallets - #267 (validation only)
ZIP 205: Deployment of the Sapling Network Upgrade

~Change to difficulty adjustment on Testnet - #1256~

NU0: Overwinter

ZIP-143: Transaction Signature Validation for Overwinter
ZIP-200: Network Upgrade Mechanism - #337, #706, #1334, #1820
ZIP-201: Network Peer Management for Overwinter - #706, #1334
ZIP-202: Version 3 Transaction Format for Overwinter
ZIP-203: Transaction Expiry

Sprout

ZIP-209: Prohibit Negative Shielded Chain Value Pool Balances - #1895

@mpguerra @dconnolly I've added some missing ZIPs (and one section that probably should have been a separate ZIP). I've also crossed out some ZIPs we've implemented already.
Our next task should be to split the tickets for the following ZIPs into essential validation work, and other work that's out of scope:
- ZIP 207: Funding Streams - #801 (excluding founders reward)
- ZIP 214: Consensus rules for a Zcash Development Fund - #801 (excluding founders reward)
- ZIP 212: Allow Recipient to Derive Sapling Ephemeral Secret from Note Plaintext - #785 (excluding sender)
- ZIP-32: Shielded Hierarchical Deterministic Wallets - #267 (validation only)
@dconnolly do you want to take ZIP 32 and 212? And I'll take ZIPs 207 and 214?

Removed #1864 as this is already tracked in #1856

Removed #1334 as this is already tracked under #1853


chore: update rn share

This PR resolves MOPLAT-583
Description

Updates react native share dependency and adds now required app id param.
PR Checklist

[ ] I have tested my changes on iOS and Android.
[x] I hid my changes behind a feature flag, or they don't need one.
[x] I have included screenshots or videos, or I have not changed the UI.
[x] I have added tests, or my changes don't require any.
[x] I added an app state migration, or my changes do not require one.
[x] I have documented any follow-up work that this PR will require, or it does not require any.
[x] I have added a changelog entry below, or my changes do not require one.

To the reviewers 👀

[ ] I would like at least one of the reviewers to run this PR on the simulator or device.

Changelog updates
Changelog updates

Cross-platform user-facing changes

iOS user-facing changes

Android user-facing changes

Dev changes

Update react-native share - Brian

Need help with something? Have a look at our docs, or get in touch with us.

👍


Feature Request: Navigator stack reset to  view

I think an important navigation feature would be to reset the root navigation (this pattern is useful for apps that have a login screens, or an hamburger alike menu), in theory this could make issue #36 much more manageable (or defer the native drawer support to later).

I just noticed that the native code does indeed have replace but it's not exposed to the JS module

That is true, you could build one using NavigationActions.
https://reactnavigation.org/docs/navigators/navigation-prop#Reset

@browniefed wrong project? xD

Oops haha

haha

@dzannotti we've been throwing around ideas for something like this, as a similar need arose internally.
I'd like to think more about how this would apply to drawer layout.... do you have a specific use case that you are wanting to use it for? I'd prefer to learn from real actual needs and try to make sure we solve those use cases as best as possible.
One idea we had thrown around is that we could have an option to present and push called clearUntil where you could pass it a route name and after presenting or pushing, it would clear the current navigation stack until the passed route name:
Navigator.push('ScreenA', props, { clearUntil: 'ScreenB' });

It's still unclear to me if this is the right model, and if it solves other people's use cases (which might be different than our own)

@lelandrichardson the most common use case I can see for this is what happens when the user taps on an item of an hamburger menu where it's common to have a reset of the navigation stack and a display of a new route. This behaviour is also already available in the lib swift files but not exposed to js

Navigator.push('ScreenA', props, { clearUntil: 'ScreenB' });

@lelandrichardson clearUntil sounds more or less close to immediatelyResetStack from current js navigation solutions which is different than replace. Also, i feel like passing an option like that is confusing.
exposing Navigator.replace and Navigator.resetStack(maybe?) clearly communicates the intent here.

@chirag04 when would Navigator.resetStack(...) get called? before or after pushing a new screen? or at any moment? Would it be the responsibility of the pushed screen or the screen doing the pushing?
What animations do Navigator.replace(...) calls use?
I'm certainly amenable to adding a new top level call to Navigator, but I feel like I don't understand the semantics of replace yet enough to answer these basic questions...

resetStack and replace can happen at any moment just like push. It will be the responsibility of screen doing the pushing. eg:
<Row
   title="Push new screen"
   onPress={() => Navigator.replace('ScreenTwo')}
/>

In above example, screenone gets replaced with screenTwo. replace uses no animation. replace is same as re-rendering screenone with a new set of config. It's just convenient to think of these two configs(with replace) as "screens"

To be clear, at airbnb the main use case is "success screens". Let's say we have a flow to have the user fill something out, and hit "submit". Once they've succeeded, we present them with a "Success" screen. At this point, they should not be able to go back, and when they hit dismiss, it should go back to before the flow started.
I feel like the right way to do this is to use present() and dismiss() but I think there's some nuance there in terms of what the user should see.
@chirag04 it sounds like your replace method is solving a fundamentally different use case, so perhaps we should be thinking of these things as two different features.

To be clear, at airbnb the main use case is "success screens". Let's say we have a flow to have the user fill something out, and hit "submit". Once they've succeeded, we present them with a "Success" screen. At this point, they should not be able to go back, and when they hit dismiss, it should go back to before the flow started.

I feel like the right way to do this is to use present() and dismiss() but I think there's some nuance there in terms of what the user should see.

How would you do it if this success screen is not a modal on ios? if you use push then the back button should be able to take you to the previous screen. replace is the middle ground here.

I think the desired behavior in our case is as follows:
Let's say we have a stateful flow with 3 steps: A, B, and C. The user starts the flow from Home. We then have a success screen Success that we want to show after the user submits on C.
I think the desired navigation steps are:

Home => A (push) (Home is reachable via pop)
A => B (push) (A is reachable via pop)
B => C (push) (B is reachable via pop)
C => Success (push) (A, B, C, should no longer be reachable. pop/dismiss produces Home)
Success => Home (dismiss)

This seems like a pretty different use case than what replace solves. So there may be two new APIs needed (replace, and some "clearing" ability somewhere).

taking the same example:
Here are the navigation steps that i'm targeting:

Home => A (push) (Home is reachable via pop)
A => B (push) (A is reachable via pop)
B => C (push) (B is reachable via pop)
C => "D/success" (replace/no animation) (C, should no longer be reachable. pop/dismiss produces B)
D/Success => B (dismiss)

I agree there is a need for two apis. 1) replace. 2) resetStack. Your use-case can be solved with resetStack. on step 4 you do resetStack(['Home', 'Success']);
Both these apis are very common in the js navigation solutions.

I see what you are saying i think, but why would C => Success not have an animation?

when you have an animation like push, the expectation is that you should be able to go back to the previous screen. it depends on how you show the success screen. There are three ways to do it:

C => success using push.  push animation. expectation is you can go back to C.
C => success using replace. No animation. no expectation of going back to C. back button points to B.
C => success using present. modal animation. expectation here is debatable. I think it's fine to not land of C again here.

@lelandrichardson another good use case for exposing reset/replace stack is a classic login flow, after the login screen you'd never want to tap back to go to the login screen, but just replace the root component with a dashboard of some kind

This is a critical feature. Would a PR be accepted?