[Feature] Handle avoidance setpoints correctly regarding smoothing

At the moment, the waypoints coming from obstacle avoidance override the setpoints generated by a FlightTask: https://github.com/PX4/Firmware/blob/f1d17c9003280498724211310c6e5601b1df44da/src/modules/mc_pos_control/mc_pos_control_main.cpp#L693
In order to benefit from smoothing features given by the "Smooth" FlightTasks, we need to read and use those setpoints directly in the FlightTask.
Since the avoidance is only used in the Auto FlightTasks, the setpoints should be read in the AutoMapper.
Tasks:

[ ] Merge AutoMapper and AutoMapper2
[ ] Get avoidance waypoints in AutoMapper and ManualPosition

@Stifael @MaEtUgR Please comment

@mrivi FYI

Update after discussion with @mrivi :

We need to have avoidance available in manual position and auto modes.
We want to have the overall same flight behavior when the drone flies a regular mission (no obstacles) with and without avoidance:

Solution: Smoothing has to be done in the FlightTask or stop publishing avoidance when there are no obstacles.

To avoid discontinuities in the setpoints when the avoidance starts and stop publishing, the FlightTask has to be aware of the avoidance setpoint

Solution: Read avoidance setpoints in the FlightTasks

If avoidance wants to stop quickly the drone, we don't want to add delay because of the smoothing

Solution: Use a second set of jerk/acceleration constraints when the avoidance publishes a setpoint to allow fast reaction.

Sidenote: it's confusing when the @AuterionWrikeBot creates issues. Could at least be in the description who wrote it?

we need to read and use those setpoints directly in the FlightTask

yes ok, but we should keep it contained in a library like @mrivi started out in #11561 because if it's modular in this way it's better maintainable.

We need to have avoidance available in manual position and auto modes.

Does the avoidance always react the same way? I expected a different behavior when flying manually compared to a mission.

We need to have avoidance available in manual position and auto modes.

Does the avoidance always react the same way? I expected a different behavior when flying manually compared to a mission.

PX4 avoidance can be run only in auto modes. However the current interface supports pos control modes as well (even if they are not enabled by default).

We have collision prevention available in manual position control, using the laser scanner message.

We have collision prevention available in manual position control, using the laser scanner message.

Ok, that's what I expected, the implementation here https://github.com/PX4/Firmware/tree/6c3e79f3614f0060d5998c39be358512101252ff/src/lib/CollisionPrevention is used with distance data from the external module in manual position flight.

The PX4 collision prevention doesn't uses the vehicle_trajectory_waypoint interface these changes don't have an impact on that feature.
However I am aware of other obstacle avoidance system integrated with PX4 that can be used in position control mode. Therefore the current master implementation is thought for pos control mode as well even if it's not enabled by default upstream since PX4 avoidance doesn't support it.

This is fixed now.


[Improvement] Improve language key name and fix typo

Why are the changes needed?

Close #3251 .
Brief change log

How was this patch tested?

[ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

[ ] Add screenshots for manual tests if appropriate

[ ] Run test locally before making a pull request

Documentation

Does this pull request introduce a new feature? (yes / no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@zhoujinsong
These three variables are same? If they are, I will remove two variables.

These three variables are same? If they are, I will remove two variables.

I found four place and I suggest keeping the last two, they have singular and plural forms.
  optimzerGroup: 'Optimizer Group',
  optimizergroup: 'Optimizer Groups',
  optimizerGroup: 'Optimizer Group', --keeping
  optimizerGroups: 'Optimizer Groups',, --keeping

And recommended to leave a space before and after the number.
  last1h: '最近 1小时',
  last12h: '最近 12小时',
  last24h: '最近 24小时',
  last7day: '最近 7天',

These three variables are same? If they are, I will remove two variables.

I agree with @zhongqishang.
We should keep the following variables only:
optimizerGroup: 'Optimizer Group',
optimizerGroups: 'Optimizer Groups',

@zhongqishang @zhoujinsong I had updated code. Please review. Thanks!

Thanks for the work! @chouchouji
Thanks for the review! @zhongqishang


Timestamps, Processing and areaDetector

Ok, putting this as an issue so that we can discuss look at it. Attn. @dchabot @gjwillms @tacaswell .
After some discussion with Mark Rivers and playing with the AD Driver for the FastCCD I have managed to work out the issue with timestamps, and blocking. So, Firstly if you need to use the stats plugins (for example) you need to set them to blocking $(P)$(R)BlockingCallbacks. This will ensure that the put complete doesn't come back until the stats have processed.
Now in areaDetector 2.0 there is support for the epics records having the detector timestamp by setting the "TSE" field of those records. I tested this with the fastCCD (I take the timestamp of the first packet arriving at the detector electronics) and it looks good, even at 100Hz. Also all stats plugins have the same timestamp.
Also, the new HDF5 file plugin stores this info (timestamps) in the HDF5 file.
The info is here:
areaDetector timestamps

I don't see any downside to this.  From my point of view, this implements the intended behavior of the Stats plugin during a scan.  We don't have an immediate need for fast time-stamping, but it's great to have it in reserve.

Ok then i will implement it @tacaswell what is the state of my poor add_detectors branch?
On Mar 27, 2015, at 8:05 AM, gjwillms <notifications<EMAIL_ADDRESS>wrote:
I don't see any downside to this. From my point of view, this implements the intended behavior of the Stats plugin during a scan. We don't have an immediate need for fast time-stamping, but it's great to have it in reserve.
—
Reply to this email directly or view it on GitHubhttps://github.com/NSLS-II/ophyd/issues/93#issuecomment-86916012.

P.s. I agree 100% this is actually what ad should do why it is not default is not clear to me.
Also, I noticed that AD 2.2 has a much simplified roi/stats plugin which should be much better for our intended use.
Best wishes,
Stuart
On Mar 27, 2015, at 08:05, gjwillms <notifications<EMAIL_ADDRESS>wrote:
I don't see any downside to this. From my point of view, this implements the intended behavior of the Stats plugin during a scan. We don't have an immediate need for fast time-stamping, but it's great to have it in reserve.
—
Reply to this email directly or view it on GitHubhttps://github.com/NSLS-II/ophyd/issues/93#issuecomment-86916012.

This is currently working at CSX
attn #165


generate api documentation throws error

I'm submitting a ...  (check one with "x")
[ x] bug report => search github for a similar issue or PR before submitting
[ ] feature request
[ ] support request => Please do not submit support request here, instead see use [gitter](https://gitter.im/mgechev/angular2-seed) or [stackoverflow](https://stackoverflow.com/questions/tagged/angular2)

Current behavior

running the following commands in cmd within project folder
api document for the app
$ npm run build.docs
generate api documentation
$ npm run compodoc
$ npm run serve.compodoc
Expected behavior

Minimal reproduction of the problem with instructions

open cmd
cd to project folder
run npm tasks to build api documentation
$ npm run build.docs
$ npm run compodoc
$ npm run serve.compodoc

What is the motivation / use case for changing the behavior?

Please tell us about your environment:

Angular Seed Version: aaaaf75

1.0

Node: node --version =
v7.10

I found the build.docs.ts is commented out. Is this on purpose?

For generation of documentation use:
$ npm run compodoc
$ npm run serve.compodoc

H:\angular-seed-master>npm run compodoc

<EMAIL_ADDRESS>compodoc H:\angular-seed-master
node ./node_modules/.bin/compodoc -p src/client/tsconfig.json

H:\angular-seed-master\node_modules.bin\compodoc:2
basedir=$(dirname "$(echo "$0" | sed -e 's,\,/,g')")
^^^^^^^
SyntaxError: missing ) after argument list
at createScript (vm.js:53:10)
at Object.runInThisContext (vm.js:95:10)
at Module._compile (module.js:543:28)
at Object.Module._extensions..js (module.js:580:10)
at Module.load (module.js:488:32)
at tryModuleLoad (module.js:447:12)
at Function.Module._load (module.js:439:3)
at Module.runMain (module.js:605:10)
at run (bootstrap_node.js:427:7)
at startup (bootstrap_node.js:151:9)
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR<EMAIL_ADDRESS>compodoc: node ./node_modules/.bin/compodoc -p src/ client/tsconfig.json
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>compodoc script.
npm ERR! This is probably not a problem with npm. There is likely additional log
ging output above.
npm ERR!      C:\Users\ChrisR\AppData\Roaming\npm-cache_logs\2017-05-26T18_17_41
_748Z-debug.log

@premiumwd try removing node prefix from the compodoc script.

removed node prefix from the following, it works
"webdriver-start": "./node_modules/protractor/bin/webdriver-manager start",
"webdriver-update": "./node_modules/protractor/bin/webdriver-manager update",
"compodoc": "./node_modules/.bin/compodoc -p src/client/tsconfig.json",
"serve.compodoc": "./node_modules/.bin/compodoc -s"

I added the prefix because of https://github.com/mgechev/angular-seed/issues/1926...

It is probably because of his associations with node in windows.

Thanks anyway! You have a great project!


fix: repeat process msg

关联的Issues (Related Issues)

close https://github.com/filecoin-project/venus/issues/5917
改动 (Proposed Changes)

附注 (Additional Info)

自查清单 (Checklist)
在你认为本 PR 满足被审阅的标准之前，需要确保 / Before you mark the PR ready for review, please make sure that:

[ ] 符合Venus项目管理规范中关于PR的相关标准 / The PR follows the PR standards set out in the Venus project management guidelines
[ ] 具有清晰明确的commit message / All commits have a clear commit message.
[ ] 包含相关的的测试用例或者不需要新增测试用例 / This PR has tests for new functionality or change in behaviour or not need to add new tests.
[ ] 包含相关的的指南以及文档或者不需要新增文档 / This PR has updated usage guidelines and documentation or not need
[ ] 通过必要的检查项 / All checks are green

Codecov Report

Merging #340 (2daabd4) into master (48736ac) will increase coverage by 0.19%.
The diff coverage is 81.13%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #340      +/-   ##
==========================================
+ Coverage   53.88%   54.08%   +0.19%
==========================================
  Files          74       74
  Lines        7960     8014      +54
==========================================
+ Hits         4289     4334      +45
- Misses       3328     3333       +5
- Partials      343      347       +4

Flag
Coverage Δ

unittests
54.08% <81.13%> (+0.19%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

testhelper/mock_full_node.go
79.35% <50.00%> (-0.96%)
:arrow_down:

service/message_state_refresh.go
72.25% <78.37%> (+0.62%)
:arrow_up:

service/message_service.go
60.67% <88.46%> (+1.56%)
:arrow_up:

service/events.go
48.48% <100.00%> (+1.60%)
:arrow_up:

service/message_selector.go
78.17% <100.00%> (+0.60%)
:arrow_up:

... and 1 file with indirect coverage changes


feat(uat): implement GGMQ scenario based on GGAD-1-T25

Issue #, if available:
Implement GGMQ scenario based on GGAD-1-T25
Description of changes:

Add T25 scenario
Add new step - rename a connection

Why is this change necessary:
Implement scenarios
How was this change tested:
Run scenario locally
Test results:
Given my device is registered as a Thing....................................passed
And my device is running Greengrass.........................................passed
When I create a Greengrass deployment with components.......................passed
And I create client device "publisher"......................................passed
And I create client device "subscriber".....................................passed
And I update my Greengrass deployment configuration, setting the component aws.greengrass.clientdevices.Auth configuration to:.passed
And I update my Greengrass deployment configuration, setting the component aws.greengrass.client.Mqtt5PythonPahoClient configuration to:.passed
When I associate "publisher" with ggc.......................................passed
When I associate "subscriber" with ggc......................................passed
And I deploy the Greengrass deployment configuration........................passed
Then the Greengrass deployment is COMPLETED on the device after 5 minutes...passed
And the aws.greengrass.clientdevices.mqtt.EMQX log on the device contains the line "is running now!." within 1 minutes.passed
Then I discover core device broker as "localMqttBroker1" from "publisher" in OTF.passed
Then I discover core device broker as "localMqttBroker2" from "subscriber" in OTF.passed
And I connect device "publisher" on aws.greengrass.client.Mqtt5PythonPahoClient to "localMqttBroker1" using mqtt "v5".passed
And I connect device "subscriber" on aws.greengrass.client.Mqtt5PythonPahoClient to "localMqttBroker2" using mqtt "v5".passed
When I subscribe "subscriber" to "iot_data_0" with qos 1....................passed
When I publish from "publisher" to "iot_data_0" with qos 1 and message "Test message" and expect status 0.passed
And message "Test message" received on "subscriber" from "iot_data_0" topic within 5 seconds.passed
And I rename connection "publisher" to "publisher_old"......................passed
And I connect device "publisher" on aws.greengrass.client.Mqtt5PythonPahoClient to "localMqttBroker1" using mqtt "v5".passed
When I publish from "publisher" to "iot_data_0" with qos 1 and message "Connect again" and expect status 0.passed
And message "Connect again" received on "subscriber" from "iot_data_0" topic within 5 seconds.passed

All clients (except Java Paho):
[INFO ] 2023-08-01 15:54:25.075 [main] StepTrackingReporting - Passed: 'GGMQ-1-T25-v3-sdk-java: As a customer, I connect with same client id twice (not reconnect) and be able to publish and subscribe to messages.'
[INFO ] 2023-08-01 15:54:25.075 [main] StepTrackingReporting - Passed: 'GGMQ-1-T25-v3-mosquitto-c: As a customer, I connect with same client id twice (not reconnect) and be able to publish and subscribe to messages.'
[INFO ] 2023-08-01 15:54:25.075 [main] StepTrackingReporting - Passed: 'GGMQ-1-T25-v3-paho-python: As a customer, I connect with same client id twice (not reconnect) and be able to publish and subscribe to messages.'
[INFO ] 2023-08-01 15:54:25.075 [main] StepTrackingReporting - Passed: 'GGMQ-1-T25-v5-sdk-java: As a customer, I connect with same client id twice (not reconnect) and be able to publish and subscribe to messages.'
[INFO ] 2023-08-01 15:54:25.075 [main] StepTrackingReporting - Passed: 'GGMQ-1-T25-v5-mosquitto-c: As a customer, I connect with same client id twice (not reconnect) and be able to publish and subscribe to messages.'
[INFO ] 2023-08-01 15:54:25.075 [main] StepTrackingReporting - Passed: 'GGMQ-1-T25-v5-paho-python: As a customer, I connect with same client id twice (not reconnect) and be able to publish and subscribe to messages.'

Any additional information or context required to review the change:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eschastlivtsev I put PR on draft to add paho-java client before merge.


Allow to set the body in merge_options?

I'm wrapping an API and want to create a convenient client. To achieve this, I'm trying to incrementally build a request that can handle all the requests I'll need to perform.
However, I haven't found a way to set the body as form-encoded or JSON (depending on the API's design/needs).
Here are my attempts at setting a form-encoded body:
defmodule Client do
  @rpc_endpoint "..."

  def new_request(method, path) do
    Req.Request.new(method: method, url: @rpc_endpoint <> path)
  end

  def set_bearer(request, token) do
    Req.Request.merge_options(request, auth: {:bearer, token})
  end

  def set_form(request, payload) do
    # First try

    Req.Request.merge_options(request, form: payload)
    # ** (ArgumentError) unknown option :form
    #     (req 0.3.12) lib/req/request.ex:803: Req.Request.validate_options/2
    #     (req 0.3.12) lib/req/request.ex:566: Req.Request.merge_options/2

    # Second try

    Req.Request.merge_options(request, body: {:form, payload})
    # warning: Passing :body is deprecated, use Req.update/2 instead.
    #   (req 0.3.12) lib/req/request.ex:557: Req.Request.merge_options/2
    #
    # ** (KeyError) key :body not found in: {%Req.Request{
    #    method: :post,
    #    url: URI.parse("https://api.dropboxapi.com/2/oauth2/token"),
    #    headers: [],
    #    body: nil,

    # Third try

    Req.update(request, body: {:form, payload})
    # ** (ArgumentError) errors were found at the given arguments:

    #   * 1st argument: not an iodata term

    #     :erlang.iolist_size({:form, %{...}})
    #     (mint 1.6.2) lib/mint/http1.ex:1039: anonymous fn/1 in Mint.HTTP1.add_content_length_or_transfer_encoding/2
  end

  def set_json(request, payload) do
    Req.Request.merge_options(request, json: payload)
  end

  def run_request(request) do
    Req.Request.run_request(request)
  end
end

The end goal is to be able to build the request like so:
new_request(:post, "/some/path")
|> set_bearer(...)
|> set_form(%{...})
|> run_request()

I can do this instead:
  def set_form(request, payload) do
    Req.update(request, body: URI.encode_query(payload))
  end

  def set_json(request, payload) do
    Req.update(request, body: Jason.encode_to_iodata!(payload))
  end

But by doing so I'm bypassing Req and the nice things like automatic response body decoding.

I'm sorry for the noise, it seems updating Req solved my issue 👀


add DARK mode

Is your feature request related to a problem? Please describe.
There is no dark mode as users prefer dark mode more.
Describe the solution you'd like
I would like to add a toggle button for dark mode which user if want to can turn on and off
Are you willing to contribute to this issue? [Yes/No]
Yes

@maneprajakta shall I work on this?

Check out #41 :)


WIP: Introduce hyperfed command as a wrapper

similar to hyperkube command in k8s, hyperfed command is introduced as a wrapper for controller-manager and kubefed2 binaries. This is according to the comment in https://github.com/kubernetes-sigs/federation-v2/pull/416#issuecomment-438718379

PR https://github.com/kubernetes-sigs/federation-v2/pull/416 itslef is updated with the commits in this pr, hence closing this.

/cc @marun, reopened this hyperfed pr, ptal. Thanks!

oops, i just saw the comment from paul in the other pr. I too feel the commits could be reviewed together as the original code size in that pr was very small and hence closing this for now.

I'm reviewing here!

I think there's still value in being able to distribute kubefed2, since the UX for cli usage will be simpler. Is there still value in being able to distribute controller-manager separately, or could hyperfed replace it entirely?

Agree with you on distributing kubefed2. its a client tool and we might need to distribute this tool for Linux and Darwin (lets leave it as instruction to build it for now). I do feel there is no need to distribute controller-manager separately and can be taken over by hyperfed, like we do it in the federation-v2 docker image in this pr.
Also @marun, have addressed the comments. can you ptal, Thanks!

Nice work!
/lgtm


FormBuilderChipsInput, Exception: A FocusNode was used after being disposed

I am using the code provided in the example page.
When typing a new person in the FormBuilderChipsInput, then releasing the keyboard and then trying to write something else, I get the following error:
E/flutter (15302): [ERROR:flutter/lib/ui/ui_dart_state.cc(157)] Unhandled Exception: A FocusNode was used after being disposed.
E/flutter (15302): Once you have called dispose() on a FocusNode, it can no longer be used.
E/flutter (15302): #0      ChangeNotifier._debugAssertNotDisposed.<anonymous closure>
package:flutter/…/foundation/change_notifier.dart:106
E/flutter (15302): #1      ChangeNotifier._debugAssertNotDisposed
package:flutter/…/foundation/change_notifier.dart:112
E/flutter (15302): #2      ChangeNotifier.notifyListeners
package:flutter/…/foundation/change_notifier.dart:201
E/flutter (15302): #3      FocusNode._notify
package:flutter/…/widgets/focus_manager.dart:970
E/flutter (15302): #4      FocusManager._applyFocusChange

As you can see from the image below, the suggestion is not showed when writing "pa".

I have this widget on a drawer, and I get this same error.

Thanks for bringing this to my attention @Draxent & @RedTech64.
I'm resolving the issue (along with others) over there in chips_input package repository and will be pulling in the updated version with a fix soon.

Same issue on version_4

Same issue with FormBuilderRadioGroup
E/flutter ( 4293): Once you have called dispose() on a FocusNode, it can no longer be used. E/flutter ( 4293): #0      ChangeNotifier._debugAssertNotDisposed.<anonymous closure> (package:flutter/src/foundation/change_notifier.dart:117:9) E/flutter ( 4293): #1      ChangeNotifier._debugAssertNotDisposed (package:flutter/src/foundation/change_notifier.dart:123:6) E/flutter ( 4293): #2      ChangeNotifier.notifyListeners (package:flutter/src/foundation/change_notifier.dart:217:12) E/flutter ( 4293): #3      FocusNode._notify (package:flutter/src/widgets/focus_manager.dart:1027:5) E/flutter ( 4293): #4      FocusManager._applyFocusChange (package:flutter/src/widgets/focus_manager.dart:1723:12) E/flutter ( 4293): #5      _rootRun (dart:async/zone.dart:1182:47) E/flutter ( 4293): #6      _CustomZone.run (dart:async/zone.dart:1093:19) E/flutter ( 4293): #7      _CustomZone.runGuarded (dart:async/zone.dart:997:7) E/flutter ( 4293): #8      _CustomZone.bindCallbackGuarded.<anonymous closure> (dart:async/zone.dart:1037:23) E/flutter ( 4293): #9      _rootRun (dart:async/zone.dart:1190:13) E/flutter ( 4293): #10     _CustomZone.run (dart:async/zone.dart:1093:19) E/flutter ( 4293): #11     _CustomZone.runGuarded (dart:async/zone.dart:997:7) E/flutter ( 4293): #12     _CustomZone.bindCallbackGuarded.<anonymous closure> (dart:async/zone.dart:1037:23) E/flutter ( 4293): #13     _microtaskLoop (dart:async/schedule_microtask.dart:41:21) E/flutter ( 4293): #14     _startMicrotaskLoop (dart:async/schedule_microtask.dart:50:5) E/flutter ( 4293):

Hello all
Any news regarding this error?

Hello All,
I got an error while i  select FormBuilderChipsInputA and after i change the FormBuilderDateTimePicker  got this error FocusNode was used after being disposed. please help me.

@danvick please help us for this error.

I'm getting the same error using FormBuilderChipsInput, using flutter_form_builder: ^3.14.1 (I couldn't use >= v4 due to some conflicts and build errors).
Is there any update on a fix for this?
E/flutter ( 9659): [ERROR:flutter/lib/ui/ui_dart_state.cc(177)] Unhandled Exception: A FocusNode was used after being disposed.
E/flutter ( 9659): Once you have called dispose() on a FocusNode, it can no longer be used.
E/flutter ( 9659): #0      ChangeNotifier._debugAssertNotDisposed.<anonymous closure>
package:flutter/…/foundation/change_notifier.dart:117
E/flutter ( 9659): #1      ChangeNotifier._debugAssertNotDisposed
package:flutter/…/foundation/change_notifier.dart:123
E/flutter ( 9659): #2      ChangeNotifier.notifyListeners
package:flutter/…/foundation/change_notifier.dart:217
E/flutter ( 9659): #3      FocusNode._notify
package:flutter/…/widgets/focus_manager.dart:1027
E/flutter ( 9659): #4      FocusManager._applyFocusChange
package:flutter/…/widgets/focus_manager.dart:1723
E/flutter ( 9659): #5      _rootRun (dart:async/zone.dart:1182:47)
E/flutter ( 9659): #6      _CustomZone.run (dart:async/zone.dart:1093:19)
E/flutter ( 9659): #7      _CustomZone.runGuarded (dart:async/zone.dart:997:7)
E/flutter ( 9659): #8      _CustomZone.bindCallbackGuarded.<anonymous closure> (dart:async/zone.dart:1037:23)
E/flutter ( 9659): #9      _rootRun (dart:async/zone.dart:1190:13)
E/flutter ( 9659): #10     _CustomZone.run (dart:async/zone.dart:1093:19)
E/flutter ( 9659): #11     _CustomZone.runGuarded (dart:async/zone.dart:997:7)
E/flutter ( 9659): #12     _CustomZone.bindCallbackGuarded.<anonymous closure> (dart:async/zone.dart:1037:23)
E/flutter ( 9659): #13     _microtaskLoop (dart:async/schedule_microtask.dart:41:21)
E/flutter ( 9659): #14     _startMicrotaskLoop (dart:async/schedule_microtask.dart:50:5)

Same here!

Same here!

Same issue. Not sure, which widget is causing it, though. But my date and time picker definetly shows this error after a while. :( @danvick : is it possible to address this? Thanks!

Same issue. Not sure, which widget is causing it, though. But my date and time picker definetly shows this error after a while. :( @danvick : is it possible to address this? Thanks!

The below code causes this issuef or me.
                FormBuilderDateTimePicker(
                  name: 'date',
                  // onChanged: _onChanged,
                  inputType: InputType.date,
                  decoration: InputDecoration(
                    labelText: 'Date of Birth',
                  ),
                ),

The below code causes this issuef or me.
                FormBuilderDateTimePicker(
                  name: 'date',
                  // onChanged: _onChanged,
                  inputType: InputType.date,
                  decoration: InputDecoration(
                    labelText: 'Date of Birth',
                  ),
                ),

Well, I did the following: I edited form_builder_date_time_picker.dart and uncommented the contents of the dispose method.
That seem to have adressed the issue.
But I am a flutter newbie, so I have no idea about the consequences, maybe this will eventually lead to a memory leak...

Well, I did the following: I edited form_builder_date_time_picker.dart and uncommented the contents of the dispose method.
That seem to have adressed the issue.
But I am a flutter newbie, so I have no idea about the consequences, maybe this will eventually lead to a memory leak...

I have same problem with FormBuilderChoiceChip and solved using property focusNode.
Ex.:
`FocusNode focusNode;
@override
void initState() {
super.initState();
focusNode = FocusNode();

}
@override
void dispose() {
focusNode.dispose();
super.dispose();
}
FormBuilderChoiceChip(
focusNode: focusNode,
....
`

I have same problem with FormBuilderChoiceChip and solved using property focusNode.
Ex.:
`FocusNode focusNode;
@override
void initState() {
super.initState();
focusNode = FocusNode();

}
@override
void dispose() {
focusNode.dispose();
super.dispose();
}
FormBuilderChoiceChip(
focusNode: focusNode,
....
`

I'm getting this error all the time, and the only solution was commenting out _focusNode.dispose() in FormBuilderFieldState
  @override
  void dispose() {
    _focusNode.removeListener(_touchedHandler);
    // Dispose focus node when created by initState
    if (null == widget.focusNode) {
      //_focusNode.dispose(); <-- Causes "A FocusNode was used after being disposed"
    }
    _formBuilderState?.unregisterField(widget.name, this);
    super.dispose();
  }

It looks not very correct, but I just cannot figure it out where the real problem is.

I am getting your very often too. Any help would be appreciated.
On Wed, 10 Feb, 2021, 5:22 am Slava P<EMAIL_ADDRESS>wrote:

I'm getting this error all the time, and the only solution was commenting
out _focusNode.dispose() in FormBuilderFieldState
@override
void dispose() {
_focusNode.removeListener(_touchedHandler);
// Dispose focus node when created by initState
if (null == widget.focusNode) {
//_focusNode.dispose(); <-- Causes "A FocusNode was used after being disposed"
}
_formBuilderState?.unregisterField(widget.name, this);
super.dispose();
}
It looks not very correct, but I just cannot figure it out where the real
problem is.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/danvick/flutter_form_builder/issues/313#issuecomment-776324941,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAIHDZ7Z4CUGICHCKQHTCRTS6HDFNANCNFSM4NY2GCGA
.

I am getting this issue in FormBuilderDropdown as well,
Any update ?

@jigarfumakiya use fix from linked https://github.com/danvick/flutter_form_builder/issues/703

Thanks That worked @slavap

Ran into the same problem.  After testing different combinations of interactions, I discovered that if I restart the application, and interact with the FormBuilderDateTimePicker control first, it works.  However, if I interact with a FormBuilderSegmentedControl, and then try to click on FormBuilderDateTimePicker control, the date time picker throws the focus exception.
The solution that worked for me, without making any modifications to the original flutter_form_builder code was to update my calls to FormBuilderSegmentedControl, and set the focusNode property.  See below.
FormBuilderSegmentedControl(
...
focusNode: FocusNode(),  // added attribute
...
)
There is an issue w/ how FormBuilderField is disposing the focusNode.  It becomes an issue if application is hot reloaded.  You may have to do a hot restart instead.

Make sure you use the same formKey every rebuild.
Do not  create this in Statelesswidget
  final formKey = GlobalKey<FormBuilderState>();

Or put the codes in build method

@Goxiaoy formKey does not help

Just want to chime in ... I had some of the same issues as described above.
When I use the FormBuilderSearchableDropdown I end up with one or more of the following:

Multiple TextFields will get focus at the same time
I will get an error about a FocusNode being used after being dispose()d
The TextInputAction.next will not correctly navigate to the next field.

In my local copy of flutter_form_builder I made the following change to form_builder_searchable_dropdown.dart starting on Line 173:
                onChanged: (val) {
                  // Per https://github.com/danvick/flutter_form_builder/issues/703
                  // state.requestFocus();
                  state.didChange(val);
                },

This change resulted in all my dropdowns and FormBuilderTextFields working properly. No errors in the log. No funny behavior in the app.
I'm commenting here to help out. I haven't had the time (yet) to figure out whether this is a general solution and submit a PR.

FormBuilderCheckbox & Chips  -- the same issue.  Once you have called dispose() on a FocusNode, it can no longer be used.

When I use the FormBuilderSwitch, I had  the same issues as described above.
@saltatory 's comments is Helpful for me.
But it make a new issues ,When I am Click the Switch  Button ,The TextFields can't resign FirstResponder.
I fix it by override requestFocus func:
  @override
  void requestFocus() {
    FocusScope.of(context).unfocus();
  }

reference： https://stackoverflow.com/questions/44991968/how-can-i-dismiss-the-on-screen-keyboard
I will submit a PR later.

@iDevOrz @saltatory Your fixes are just workarounds and not actual fixes, because the normal behaviour would be to actually request the focus. So this should stay unchanged :
  void requestFocus() {
    FocusScope.of(context).requestFocus(effectiveFocusNode);
  }

I found out that the real reason this bug happens is that for some FormBuilder fields, the effectiveFocusNode isn't assigned to the actual widget.
Here is how I fixed it :
For FormBuilderChoiceChips, FormBuilderDropdown, FormBuilderFilterChips, FormBuilderSlider :
The widget used under the hood for each one of these FormBuilder fields have a focusNode parameter that I set to state.effectiveFocusNode.
For example, for FormBuilderChoiceChips :
ChoiceChip(
        focusNode: state.effectiveFocusNode, //Added this line
        label: option,
        selected: field.value == option.value,
        onSelected: state.enabled
            ? (selected) {
                final choice = selected ? option.value : null;
                state.requestFocus();
                state.didChange(choice);
              }
            : null,
            .......

For FormBuilderCheckbox, FormBuilderCheckboxGroup, FormBuilderRadioGroup, FormBuilderRangeSlider, FormBuilderSegmentedControl, FormBuilderSwitch :
The widget used under the hood for each one of these FormBuilder fields don't have a focusNode parameter, so I wrapped them with a Focus widget which focusNode I set to state.effectiveFocusNode.
For example, for FormBuilderSwitch :
return Focus(
      canRequestFocus: enabled,
      focusNode: state.effectiveFocusNode, //This is the important part
      autofocus: autofocus,
      child: InputDecorator(
          decoration: state.decoration(),
          child: SwitchListTile( .......

I will try to submit a PR this week if I have time

Great. Thanks for the excellent followup. I definitely learned something.

@ojm-it  By the way, Focus() workaround works, but adds undesirable effect with excessive Tab stop.
For example: radio group with Item1 and Item2, tab stops will be: Item1, Item2, “limbo”, next widget.

@ojm-it looks great! did you had time filing that PR? I stumbled across the same issue lately.

@wottpal There is still the excessive tab stop @slavap talked about, and I currently don't have time to look up a solution for it.
Maybe you can have a look at it? And then submit a PR with all these changes combined

@iDevOrz @saltatory Your fixes are just workarounds and not actual fixes, because the normal behaviour would be to actually request the focus. So this should stay unchanged :
  void requestFocus() {
    FocusScope.of(context).requestFocus(effectiveFocusNode);
  }

I found out that the real reason this bug happens is that for some FormBuilder fields, the effectiveFocusNode isn't assigned to the actual widget.
Here is how I fixed it :
For FormBuilderChoiceChips, FormBuilderDropdown, FormBuilderFilterChips, FormBuilderSlider :
The widget used under the hood for each one of these FormBuilder fields have a focusNode parameter that I set to state.effectiveFocusNode.
For example, for FormBuilderChoiceChips :
ChoiceChip(
        focusNode: state.effectiveFocusNode, //Added this line
        label: option,
        selected: field.value == option.value,
        onSelected: state.enabled
            ? (selected) {
                final choice = selected ? option.value : null;
                state.requestFocus();
                state.didChange(choice);
              }
            : null,
            .......

For FormBuilderCheckbox, FormBuilderCheckboxGroup, FormBuilderRadioGroup, FormBuilderRangeSlider, FormBuilderSegmentedControl, FormBuilderSwitch :
The widget used under the hood for each one of these FormBuilder fields don't have a focusNode parameter, so I wrapped them with a Focus widget which focusNode I set to state.effectiveFocusNode.
For example, for FormBuilderSwitch :
return Focus(
      canRequestFocus: enabled,
      focusNode: state.effectiveFocusNode, //This is the important part
      autofocus: autofocus,
      child: InputDecorator(
          decoration: state.decoration(),
          child: SwitchListTile( .......

I will try to submit a PR this week if I have time

many thanks. it's solved by wrapping with Focus.

@ojm-it @alpertungir But this way does not work for me! I got this error
[VERBOSE-2:ui_dart_state.cc(199)] Unhandled Exception: A FocusNode was used after being disposed.
Once you have called dispose() on a FocusNode, it can no longer be used.

FormBuilderChoiceChip was also occurring issue in my code and I solved this issue by using effectiveFocusNode.
Here is my sample code.
final _formKey = GlobalKey<FormBuilderState>();

FormBuilderTextField(
  /// focusNode issue : used after dispose
  focusNode: _formKey.currentState?.fields['extraNotes']!.effectiveFocusNode, // added thisline
  name: 'extraNotes',
  maxLines: 3,
  keyboardType: TextInputType.multiline,
  ...
  // validator: validateRequired,
),

FormBuilderChoiceChip(
  /// focusNode issue : used after dispose
   focusNode: _formKey.currentState?.fields['repetition']!.effectiveFocusNode, // added thisline
   name: 'repetition',
   ...
   /// make validation for required
   validator: validateRequired,
),

and all FormBuilder Widgets are wrapped up with FormBuilder as well.
from adding focusNode with : _formKey.currentState?.fields['{nameField}']!.effectiveFocusNode it worked for me 👍

@ojm-it @alpertungir But this way does not work for me! I got this error
[VERBOSE-2:ui_dart_state.cc(199)] Unhandled Exception: A FocusNode was used after being disposed.
Once you have called dispose() on a FocusNode, it can no longer be used.

Define global variable for focusNode and  initialize it on ctor
class _AppTypeEditFormState extends State {
AppType _appType;
final _formKey = GlobalKey();
AutovalidateMode _autovalidateMode = AutovalidateMode.disabled;
FocusNode _focusNode;
@override
void initState() {
super.initState();
_appType = AppType();
_focusNode = FocusNode();
}

Any update on this, please? @danvick
I'm on the 7.0.0.alpha2 and still get the
Unhandled Exception: A FocusNode was used after being disposed.
Once you have called dispose() on a FocusNode, it can no longer be used.

even on simple FormBuilderTextField. I get this after changing the state back and forth with flutter_bloc state manager.
I tried declaring FocusNode above the FormBuilder, tried global GlobalKey and local one, created in Statefull widget. Nothing seems to work for me.
If the issue is unsolvable I will have to remove this great package from my project  😕

Still getting this issue, not yet resolved...
E/flutter ( 4320): [ERROR:flutter/lib/ui/ui_dart_state.cc(209)] Unhandled Exception: A FocusNode was used after being disposed. E/flutter ( 4320): Once you have called dispose() on a FocusNode, it can no longer be used. E/flutter ( 4320): #0      ChangeNotifier._debugAssertNotDisposed.<anonymous closure> (package:flutter/src/foundation/change_notifier.dart:114:9) E/flutter ( 4320): #1      ChangeNotifier._debugAssertNotDisposed (package:flutter/src/foundation/change_notifier.dart:120:6) E/flutter ( 4320): #2      ChangeNotifier.notifyListeners (package:flutter/src/foundation/change_notifier.dart:288:12) E/flutter ( 4320): #3      FocusNode._notify (package:flutter/src/widgets/focus_manager.dart:1145:5) E/flutter ( 4320): #4      FocusManager._applyFocusChange (package:flutter/src/widgets/focus_manager.dart:1882:12) E/flutter ( 4320): #5      _rootRun (dart:async/zone.dart:1420:47) E/flutter ( 4320): #6      _CustomZone.run (dart:async/zone.dart:1328:19) E/flutter ( 4320): #7      _CustomZone.runGuarded (dart:async/zone.dart:1236:7) E/flutter ( 4320): #8      _CustomZone.bindCallbackGuarded.<anonymous closure> (dart:async/zone.dart:1276:23) E/flutter ( 4320): #9      _rootRun (dart:async/zone.dart:1428:13) E/flutter ( 4320): #10     _CustomZone.run (dart:async/zone.dart:1328:19) E/flutter ( 4320): #11     _CustomZone.runGuarded (dart:async/zone.dart:1236:7) E/flutter ( 4320): #12     _CustomZone.bindCallbackGuarded.<anonymous closure> (dart:async/zone.dart:1276:23) E/flutter ( 4320): #13     _microtaskLoop (dart:async/schedule_microtask.dart:40:21) E/flutter ( 4320): #14     _startMicrotaskLoop (dart:async/schedule_microtask.dart:49:5) E/flutter ( 4320):

Had same problem with FormBuilderDropDown().
Use FormBuilderDropDown(
autofocus: false,
)
//Solved for me
return FormBuilderDropdown(
key: UniqueKey(),
autofocus: false,
decoration: buildInputDecoration("Sub Diagnosis"),
name: 'subDiagnosis',............}

Still having this problem with custom FormBuilderField widgets. The error occurs every time that the current route/page is changed i.e. a new page is pushed onto the stack or a modal dialog is shown (thus unmounting the widget).
Important to note is if the custom widget is not interacted with, then the error does not occur, but this could be due to an error in my own code. Also adding your own FocusNode to the custom widget and then calling FocusNode.dispose() in the widget dispose callback does not fix the issue.
Apart from the widget layout code, here is the code that I used when interacting with the custom widget (in my case, an image picker form field which can work with and display an Uint8List or an XFile):
onTap: () async {
  if (state.mounted) { // not sure if this is necessary
    final picker = ImagePicker();
    final image = await picker.pickImage(source: ImageSource.gallery);
    dynamic result; // this widget can keep track of both actual files on the filesystem, or a raw byte array
    if (typesEqual<T, XFile?>()) { // checks if the generic type of this widget T is an XFile? or a Uint8List?, then transform as necessary
      result = image;
    } else if (typesEqual<T, Uint8List?>()) {
      result = await image?.readAsBytes();
    }
    state.didChange(result as T); // not sure if casting as T is necessary
  }
},

This error messes up the focus of FormBuilderTextFields, requiring the user to tap twice before proper focus is gained and the keyboard is opened. The error persists until the app is restarted.

Error report

E/flutter (20202): [ERROR:flutter/lib/ui/ui_dart_state.cc(209)] Unhandled Exception: A FocusNode was used after being disposed.
E/flutter (20202): Once you have called dispose() on a FocusNode, it can no longer be used.
E/flutter (20202): #0      ChangeNotifier._debugAssertNotDisposed. (package:flutter/src/foundation/change_notifier.dart:114:9)
E/flutter (20202): #1      ChangeNotifier._debugAssertNotDisposed (package:flutter/src/foundation/change_notifier.dart:120:6)
E/flutter (20202): #2      ChangeNotifier.notifyListeners (package:flutter/src/foundation/change_notifier.dart:288:12)
E/flutter (20202): #3      FocusNode._notify (package:flutter/src/widgets/focus_manager.dart:977:5)
E/flutter (20202): #4      FocusManager._applyFocusChange (package:flutter/src/widgets/focus_manager.dart:1715:12)
E/flutter (20202): #5      _rootRun (dart:async/zone.dart:1420:47)
E/flutter (20202): #6      _CustomZone.run (dart:async/zone.dart:1328:19)
E/flutter (20202): #7      _CustomZone.runGuarded (dart:async/zone.dart:1236:7)
E/flutter (20202): #8      _CustomZone.bindCallbackGuarded. (dart:async/zone.dart:1276:23)
E/flutter (20202): #9      _rootRun (dart:async/zone.dart:1428:13)
E/flutter (20202): #10     _CustomZone.run (dart:async/zone.dart:1328:19)
E/flutter (20202): #11     _CustomZone.runGuarded (dart:async/zone.dart:1236:7)
E/flutter (20202): #12     _CustomZone.bindCallbackGuarded. (dart:async/zone.dart:1276:23)
E/flutter (20202): #13     _microtaskLoop (dart:async/schedule_microtask.dart:40:21)
E/flutter (20202): #14     _startMicrotaskLoop (dart:async/schedule_microtask.dart:49:5)

@bdthombre's solution seems to work as a workaround for me.

Still having this problem with custom FormBuilderField widgets. The error occurs every time that the current route/page is changed i.e. a new page is pushed onto the stack or a modal dialog is shown (thus unmounting the widget).
Important to note is if the custom widget is not interacted with, then the error does not occur, but this could be due to an error in my own code. Also adding your own FocusNode to the custom widget and then calling FocusNode.dispose() in the widget dispose callback does not fix the issue.
Apart from the widget layout code, here is the code that I used when interacting with the custom widget (in my case, an image picker form field which can work with and display an Uint8List or an XFile):
onTap: () async {
  if (state.mounted) { // not sure if this is necessary
    final picker = ImagePicker();
    final image = await picker.pickImage(source: ImageSource.gallery);
    dynamic result; // this widget can keep track of both actual files on the filesystem, or a raw byte array
    if (typesEqual<T, XFile?>()) { // checks if the generic type of this widget T is an XFile? or a Uint8List?, then transform as necessary
      result = image;
    } else if (typesEqual<T, Uint8List?>()) {
      result = await image?.readAsBytes();
    }
    state.didChange(result as T); // not sure if casting as T is necessary
  }
},

This error messes up the focus of FormBuilderTextFields, requiring the user to tap twice before proper focus is gained and the keyboard is opened. The error persists until the app is restarted.
Error report

Same here. Any updates how to solve this issue?

@mapokapo
Same here. Any updates on how to solve this issue?


[Installer] Cancel first step of update not stopping other steps

ℹ Computer information

PowerToys version: 0.33.1
PowerToy Utility: setup
Running PowerToys as Admin: yes
Windows build number: 1903

📝 Provide detailed reproduction steps (if any)

Start setup.exe
Stop while configure first step (I think it is the uninstall)

✔ Expected result
Uninstall cancelled and update process stops.
❌ Actual result
Uninstall canceled. After this dotnet cor gets downloaded and after cancel dotnet the install of pt is starting.
📷 Screenshots
no

@htcfreek

Stop while configure first step (I think it is the uninstall)

This is too vague, can you please take a screenshot?

I have no time to reproduce it at the moment.

@enricogior
Could you reproduced it?


Iotagent MQTT - Automatic component test

Implementation of automatic Iotagent MQTT component test for happy day and two alternative scenarios.

Ticket analysis (February, 28th 2020): Done.


Deleting modules doesn't work reliably

RIGHT Click -> Delete on (connected) modules often has no effect. Deleting the gate again after moving it usually works.

Fixed it in https://github.com/Spydr06/logicrs/commit/a9f474b1deeeca67652955e17175874bcdec9d71

New version for download (0.1.1):
https://github.com/Spydr06/logicrs/releases/tag/beta-0.1.1


HTML minifier docs still reference import { prerendering } from '$app/environment'

Describe the bug
https://kit.svelte.dev/docs/migrating#integrations-html-minifier
This needs to be updated to building. But more troubling is that this didn't fail the docs build, which is why I opened an issue at all rather than just a PR.
Reproduction
https://kit.svelte.dev/docs/migrating#integrations-html-minifier
Logs
No response
System Info
n/a

Severity
annoyance
Additional Information
No response

If I import building, I do get better mouseover types - it knows that it's a boolean, whereas for prerendering all the tooltip says is import prerendering. But the build still succeeds with prerendering.
Is it possible to make the declare module '$app/environment' in packages/kit/types/ambient.d.ts treated more strictly?

Found the culprit:
https://github.com/sveltejs/kit/blob/5dc7f9f6a39ee6df0b2fe056eb70086df9218c9b/sites/kit.svelte.dev/src/lib/docs/server/index.js#L145-L149
This seems bad. Gonna try removing it to see what happens

The updated document, https://kit.svelte.dev/docs/migrating#integrations-html-minifier
It should be page += html, right? Otherwise it gives you a blank page.


Allow to customize the list of filters using the configuration object

Expose a new class YPFilterDescriptor which can be used to add new filters to the collection of predefined ones. The demo project is updated as well. In future, the descriptor class may be extended to allow fine tuning of each filter.

Wow!
the fact that we can customize filters like :
config.filters = [
    YPFilterDescriptor(name: "Blur" , filterName: "CIBoxBlur"),
    YPFilterDescriptor(name: "Normal", filterName: ""),
    YPFilterDescriptor(name: "Mono", filterName: "CIPhotoEffectMono"),
    YPFilterDescriptor(name: "Sepia", filterName: "CISepiaTone")
]

is really neat!
We'll wait to know what are @NikKovIos thoughts, but I really like it!
Great job man! 👏

The feature is great! However, I saw a code and it really needs swiflint.
There are few things to do before merge:

Fix syntax. For example fix let name:String to let name: String
filterName: String ) to  filterName: String) and so on.
Bring the default filters into the YPFiltersVC.swift. It's not necessary to set them in config due to most of people, i think, wouldn't customize them. So if filters:[YPFilterDescriptor] var in configuration would be nil, use the default filters.
Fix  config.showsFilters = !false and leave only necessary example code. For ex:  config.showsFilters = false. config.filters.remove(at: 1) config.filters.insert(YPFilterDescriptor(name: "Blur" , filterName: "CIBoxBlur"), at: 1)

After that we can merge it.

Thanks!


Fix error issued when disconnecting wallet

Fixing the error raised when a standard wallet is disconnected. Previously mentioned here https://github.com/solana-labs/wallet-adapter/issues/742
and here https://github.com/solana-labs/wallet-adapter/issues/185

This is intended behavior. When a wallet exogenously disconnects (meaning, the wallet in some way triggers the disconnection without the disconnect method being called on the adapter, whether by switching accounts or for any other reason) a WalletDisconnectError is thrown/emitted by the adapter. The code here is interpreting a change in the connected accounts. If previously there were connected accounts and now there are none, it interprets this as an exogenous disconnection. There is no other information about why the wallet was disconnected, and applications should always be prepared to handle errors thrown by the adapter.

I think I've found the source of the issue (thanks for your patience!) but we'll need a different change to fix it.
Taking Backpack's Standard Wallet implementation as an example, the expected call chain will look like:
1. standardWalletAdapter.disconnect()
  -> 2. backpackStandardWallet.features['standard:disconnect'].disconnect()
    -> 3. backpack.disconnect()

Here's 1 calling 2:
https://github.com/solana-labs/wallet-standard/blob/8940eb4cb943d964a4eec6b47479a65fea4e2726/packages/wallet-adapter/base/src/adapter.ts#L151-L162
Here's 2 calling 3:
https://github.com/coral-xyz/backpack/blob/b854f2bf2ab5cf269b09facb0f53c108e5f5b9f6/packages/wallet-standard/src/wallet.ts#L159-L161
The problem starts here:
https://github.com/coral-xyz/backpack/blob/b854f2bf2ab5cf269b09facb0f53c108e5f5b9f6/packages/wallet-standard/src/wallet.ts#L134C5-L139
When 3 gets called, Backpack's Standard Wallet implementation is going to emit a change event. Before our call stack finishes, we end up here (the location of your PR):
https://github.com/solana-labs/wallet-standard/blob/8940eb4cb943d964a4eec6b47479a65fea4e2726/packages/wallet-adapter/base/src/adapter.ts#L195-L206
What we want is to say "if we are endogenously disconnecting, don't interpret account changes as exogenous disconnections".
I think what we're going to need to do is add an internal disconnecting flag that we'll set inside this block:
https://github.com/solana-labs/wallet-standard/blob/8940eb4cb943d964a4eec6b47479a65fea4e2726/packages/wallet-adapter/base/src/adapter.ts#L152-L158C10
And check here: https://github.com/solana-labs/wallet-standard/blob/8940eb4cb943d964a4eec6b47479a65fea4e2726/packages/wallet-adapter/base/src/adapter.ts#L197


Feature/strict optional

Description
Turns on strict optional typing and turns off implicit optional typing, this means that every time that None is an acceptable alternative argument to a function, the type hint should make use of Optional[] from typing.
Fixes #88
Type of change

[x] New feature (non-breaking change which adds functionality)
[ ] Optimization (back-end change that speeds up the code)
[ ] Bug fix (non-breaking change which fixes an issue)

Key checklist

[x] Make sure you've run the pre-commit checks: $ pre-commit run -a
[x] All tests pass: $ poetry run pytest

Further checks

[ ] Code is commented, particularly in hard-to-understand areas
[ ] Tests added that prove fix is effective or that feature works

Codecov Report

Merging #89 (8ed6fce) into develop (0f10de8) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           develop      #89   +/-   ##
========================================
  Coverage    86.86%   86.86%
========================================
  Files            7        7
  Lines          236      236
========================================
  Hits           205      205
  Misses          31       31

Impacted Files
Coverage Δ

virtual_rainforest/core/config.py
96.15% <100.00%> (ø)

virtual_rainforest/core/grid.py
67.10% <100.00%> (ø)

virtual_rainforest/core/logger.py
100.00% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Add ActiveMQ scaler

Signed-off-by: melisatanrverdi<EMAIL_ADDRESS>Added a new scaler that scales based on ActiveMQ broker. Contacts ActiveMQ's management endpoint to determine the queue's message count and scale accordingly.
Checklist

[x] Commits are signed with Developer Certificate of Origin (DCO - learn more)
[ ] Tests have been added
[ ] A PR is opened to update our Helm chart (repo) (if applicable, ie. when deployment manifests are modified)
[ ] A PR is opened to update the documentation on (repo) (if applicable)
[ ] Changelog has been updated

Fixes #2120

Sorry for my late response @arschles , about unifying the Artemis and ActiveMQ scaler codebases question that you asked previous PR, I've thought Artemis and ActiveMQ classic as separately because of they haven't completed that migration: http://activemq.apache.org/activemq-artemis-roadmap.html
My opinion is we can consider unify the codeebases after the migration. What are your thoughts?

My opinion is we can consider unify the codeebases after the migration. What are your thoughts?

@melisatanrverdi that sounds like a fine plan. Thanks for answering that comment from the previous PR!

I tried to use https://hub.docker.com/r/symptoma/activemq image in my e2e test because this is the only latest version. But it didn’t provide some of my configuration requirements. I tried to use configmap but it didn’t work for one of requirement.
I can patch that docker image according to my requirements or I can use my docker image that I created earlier to test ActiveMQ. I would like to hear your suggestions.

Hi @melisatanrverdi ,
If you need a custom image, you could create a PR here .  We usually use custom images, so don't worry if you need to create a new one :)
Personally, I don't have a strong opinion about using and patching one existing image or creating it from scratch.

We are planning to ship KEDA v2.5 this week - Do you think you'll have time to complete this PR @melisatanrverdi or not?
No rush, we're just checking what will be in and what not.

Hi @melisatanrverdi
Could you update your branch?
Last week we released v2.5 and your branch's CHANGELOG.md is in conflict. Apart from that, you should update it to move your change from v2.5 to v2.6
Thanks for this contribution ❤

/run-e2e activemq.test*

hi @melisatanrverdi ,
I have tried the e2e test and it fails in the e2e cluster.
Could you review it? The logs are here. Please, review the cleanup too because after the failure, the resources are not cleaned.

/run-e2e activemq.test*

hi @melisatanrverdi , I have tried the e2e test and it fails in the e2e cluster. Could you review it? The logs are here. Please, review the cleanup too because after the failure, the resources are not cleaned.

I was accessing health status endpoint of ActiveMQ via IP address. I changed this by sending from inside the pod. I will update CHANGELOG file after ensure that everthing works properly.

/run-e2e activemq.test*

LGTM! Only the small nit about CHANGELOG.md
@arschles PTAL

Is everything all right? Is there something I'm missing that is preventing the merge?

Is everything all right? Is there something I'm missing that is preventing the merge?

Hi @melisatanrverdi ,
your PR looks good, but we'd like till @zroubalik review and unfortunately he is totally busy till vacations. After x-mas we will take care about this PR, sorry for the inconvenience


Broken chart vars

$pf-chart-axis--tick--Width should be 5 -- can't see axis ticks with a value of 1

$pf-chart-axis--grid--stroke--Color, and $pf-chart-axis--tick--stroke--Color are 'transparent'. We need to define colors here in order to show axis ticks.

$pf-chart-axis--grid--Fill is 'transparent', but probably should be 'none'? Transparent seems to work, but material.js and greyscale.js both use 'none'.

$pf-chart-pie--angle--Padding is 1. We don't use angle padding with the standard pie chart. If we want to keep a var for this, it should be zero or we can just remove it?

$pf-chart-global--stroke-dash-array is '10, 5'. This makes the grid lines look like dashes. I believe we want solid grid lines, so I removed it.

$pf-chart-chart--BorderWidth is used as a border around the entire SVG, not the chart itself. It didn't work as expected, so I've removed it.

These vars ended up being unused:

$pf-chart-pie--small--Height,
$pf-chart-pie--small--Width,
$pf-chart-donut--threshold--success--Color,
$pf-chart-donut--utilization--label--subtitle--Fill
$pf-chart-donut--utilization--label--orientation
$pf-chart-tooltip--labels--Padding << we're using chart_tooltip_pointer_length
$pf-chart-tooltip--labels--PointerEvents
$pf-chart-tooltip--pointer--Height

Would like to have new vars for:

$pf-chart-legend--position: right
$pf-chart-donut--label--subtitle--position: center

:tada: This issue has been resolved in version 2.17.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Default Image Resize settings without having to click OK button

Please add a default image resize settings where we do not have to get the extra steps of having to click 'ok' to convert.
Just a right click and convert.
It will save time

Can you tell a bit more on how would you want this to look/work? Maybe direct actions via the context menu?

Can you tell a bit more on how would you want this to look/work? Maybe direct actions via the context menu?
Steps will be like this.

Right Click Image
Click Resize Image
Generate Output / Done

No need to open the menu UI and click OK to confirm resize.
Its fast and save time since we do not have to use different settings everytime!

That means you have one default setting. Sounds like a duplicate of #3133.
Compare with this idea for a sub-menu: #3953

Closing as duplicate of #3133


Cannot start Live Share collaboration session on remote

Describe what happened:
Trying to start a Live Share session from VS Code on remote host hangs on the start. Live Share status bar display is not visible in VSCode.
Live Share is working correctly on my local computer, when not connecting to the remote host.
My colleague can use Live Share with his VSCode with the same remote server. He's using a Mac.
I tried re-installing the extension multiple times both on the local and on the remote.
I tried multiple different accounts (both Microsoft and Github).
I tried to revoke VSCode access from Github credentials and grant it again.
I tried to use a different local default browser for the browser assisted sign-in.
What was your system configuration?
VSCode
Version: 1.70.1 (system setup)
Commit: 6d9b74a70ca9c7733b29f0456fd8195364076dda
Date: 2022-08-10T06:08:33.642Z
Electron: 18.3.5
Chromium: 100.0.4896.160
Node.js: 16.13.2
V8: <IP_ADDRESS>-electron.0
OS: Windows_NT x64 10.0.19044
Remote
Ubuntu 22.02
Live Share Extension Version: v1.0.5683
Steps to Reproduce / Scenario:

Use Remote Explorer to connect an Ubuntu 22.02 remote host.
Install Live Share to remote host.
Click "Share" on Live Share.
Status box opens and displays "Starting collaboration session: Silent Native Login Starting". It doesn't advance.

Please attach logs to this issue:
You can access them via the Live Share: Export Logs command from the command palette (ctrl + shift + p) and attach them to this issue
[2022-08-16 09:39:47.093 Command:liveshare.startFromWelcomeContent I] Decorator: SingleInvocation Starting
[2022-08-16 09:39:47.094 Command:liveshare.startFromWelcomeContent I] Decorator: CancellationDecorator Starting
[2022-08-16 09:39:47.100 Command:liveshare.startFromWelcomeContent I] Decorator: ErrorNotification Starting
[2022-08-16 09:39:47.100 Command:liveshare.startFromWelcomeContent I] Decorator: FirstRunTracking Starting
[2022-08-16 09:39:47.101 Command:liveshare.startFromWelcomeContent I] HasRunPreviously: Starting collaboration session -> true
[2022-08-16 09:39:47.101 Command:liveshare.startFromWelcomeContent I] Decorator: Telemetry Starting
[2022-08-16 09:39:47.102 Command:liveshare.startFromWelcomeContent I] Decorator: TelemetryStatus Starting
[2022-08-16 09:39:47.102 Command:liveshare.startFromWelcomeContent I] Decorator: Validation Starting
[2022-08-16 09:39:47.103 Command:liveshare.startFromWelcomeContent I] Decorator: SessionStateTransitions Starting
[2022-08-16 09:39:47.103 Command:liveshare.startFromWelcomeContent I] Decorator: Progress Starting
[2022-08-16 09:39:47.104 Progress I] Progress notifier opened: 1.
[2022-08-16 09:39:47.106 Command:liveshare.startFromWelcomeContent I] Decorator: InfoPage Starting
[2022-08-16 09:39:47.110 Command:liveshare.startFromWelcomeContent I] Decorator: Authentication Starting
[2022-08-16 09:39:47.110 Command:liveshare.signin I] SessionContext: Status update from "SilentNativeLoginStarting" to "SigninCheckStarting".
[2022-08-16 09:39:47.111 Command:liveshare.signin I] SessionContext: Status update from "SilentNativeLoginStarting" to "SigninCheckStarting".
[2022-08-16 09:39:47.111 Command:liveshare.signin I] SessionContext: Status update from "SilentNativeLoginStarting" to "SigninCheckStarting".
[2022-08-16 09:39:47.111 Command:liveshare.startFromWelcomeContent I] SessionContext: Status update from "SilentNativeLoginStarting" to "SigninCheckStarting".
[2022-08-16 09:39:47.111 Command:liveshare.signin I] SessionContext: Status update from "SigninCheckStarting" to "SilentNativeLoginStarting".
[2022-08-16 09:39:47.111 Command:liveshare.signin I] SessionContext: Status update from "SigninCheckStarting" to "SilentNativeLoginStarting".
[2022-08-16 09:39:47.111 Command:liveshare.signin I] SessionContext: Status update from "SigninCheckStarting" to "SilentNativeLoginStarting".
[2022-08-16 09:39:47.111 Command:liveshare.startFromWelcomeContent I] SessionContext: Status update from "SigninCheckStarting" to "SilentNativeLoginStarting".
[2022-08-16 09:39:47.113 Client I] Attempt to log in with github auth provider.
[2022-08-16 09:39:47.130 Client.Rpc.Auth V] < auth.login()
[2022-08-16 09:39:47.165 Client.Rpc.Auth V] > auth.authenticationChanged:
[2022-08-16 09:39:47.310 Client.Rpc V] > telemetry.genericOperation:
[2022-08-16 09:41:52.406 Contact.Manager V] onActivityStatusChanged-> id:idle newStatus:away publishedPresenceStatus:undefined
[2022-08-16 09:42:37.770 github V] Attempting to load session - login = false
[2022-08-16 09:42:37.783 github V] Successfully loaded session
[2022-08-16 09:42:45.938 microsoft V] Attempting to load session - login = false
[2022-08-16 09:42:46.241 microsoft V] Attempting to load session - login = false
[2022-08-16 09:42:46.307 microsoft W] Failed to load session
[2022-08-16 09:42:46.307 microsoft W] Failed to load session
[2022-08-16 09:39:47.146 Agent.Auth I] isValidExpirationTime=True (8/17/2022 9:37:15 AM - 8/16/2022 11:39:47 AM)
[2022-08-16 09:39:47.146 Agent.Auth I] isValidIssuedAtTime=True (8/16/2022 9:37:15 AM - 1)
[2022-08-16 09:39:47.146 Agent.Auth I] isValidAudience=True (expected audience: https://insiders.liveshare.vsengsaas.visualstudio.com/  actual audience: https://insiders.liveshare.vsengsaas.visualstudio.com/)
[2022-08-16 09:39:47.146 Agent.Auth I] Passed token validation.
[2022-08-16 09:39:47.146 Agent-HubConnectionService V] SetUserInfoAsync on same user info id
[2022-08-16 09:39:47.174 Agent.Http V] < GET https://prod.liveshare.vsengsaas.visualstudio.com/1c0a8dbc
[2022-08-16 09:39:47.306 Agent.Http V] > GET https://prod.liveshare.vsengsaas.visualstudio.com/1c0a8dbc (c131ms sms) => 200 OK
[2022-08-16 09:39:47.334 Agent.Auth V] secret_password_clear_sync(<8:391177f4>, <41:78730f02>) => 0

We’ve made improvements in this area since this issue was filed. We believe this may have improved your experience and are closing this issue. If this issue still persists for you, please comment on the issue and let us know. Thank you.


CustomKernelInstall: skip if kernel is already installed

Testcase CAPTURE-VHD-BEFORE-TEST fails in installation of custom kernel, if the kernel passed as parameter(-CustomKernel) is already installed  in the VM.
This need to be modified to skip if kernel is already installed and CAPTURE-VHD-BEFORE-TEST should be Passed.
07/17/2019 10:48:53 : [ERROR] Kernel upgrade failed in 1 VMs.
07/17/2019 10:48:53 : [ERROR] Custom Kernel: https://lisbuildstorage04.blob.core.windows.net/kernel/3.10.0-957.21.3.el7/kernel-3.10.0-957.21.3.el7.x86_64.rpm installation FAIL. Aborting tests.
build-CustomKernel Logs:
Web link detected. Downloading https://lisbuildstorage04.blob.core.windows.net/kernel/3.10.0-957.21.3.el7/kernel-3.10.0-957.21.3.el7.x86_64.rpm
Custom Kernel:kernel-3.10.0-957.21.3.el7.x86_64.rpm
Removing packages that do not allow the kernel to be installed
Installing kernel-3.10.0-957.21.3.el7.x86_64.rpm
warning: kernel-3.10.0-957.21.3.el7.x86_64.rpm: Header V3 RSA/SHA256 Signature, key ID fd431d51: NOKEY
Preparing...                          ########################################
package kernel-3.10.0-957.21.3.el7.x86_64 is already installed

If you skip that step then it might not be very clear that it's the same kernel.
And if it's already the same kernel, then you might want to either stop or do something else, and not just continue.
Otherwise, if you mean as in Skip state, then that is not very transparent on what it is.

@DivyaJyothiKasam , can you check if you can get kernel version from rpm package version before going for install?
Based on this, we can either continue installing the kernel or skip it.

This behaviour is there by design.
Also, the kernel version can be the same, but from different builds.
To "improve" or fix your scenario, you need to make sure it does make sense for all the other scenarios where you actually want to fail the test case.
In other words, why do you try to run tests with a custom kernel when you already have that kernel in the image? From a higher-level view, this scenario should not exist in your testing setup.


Flash Webview page when jump to a flutter page from the webview page

[x] I have read the Get Started - Installation section
[x] I have read and done the Get Started - Setup Android section
[x] I have read and done the Get Started - Setup iOS section
[x] I have already searched for the same problem

Environment

Technology
Version

Flutter version
2.8.0

Plugin version
5.3.2

Android version
Android 11

iOS version
N/A

Xcode version
N/A

Device information:
Oppo, XiaoMi, Huawei, basically all the Android test devices we have.
Steps to reproduce

Open a fullscreen webview page A
Jump to a normal flutter page B

After navigate to the page B, it will quickly flash the content of page A, if you not see this at first try, just repeat the steps several times.

I also have this problem when I open the WebView and go back to the previous page, there will be a flash screen. Is there a good solution to access

I'm catching the same bug now, only on android (everything is fine with ios) and the value of useHybridComposition is set to true.
And I believe that simply shortening the transition time between pages is a bad decision.
Are there any other options?

Looks the same: https://github.com/flutter/flutter/issues/95545


Scrollable ListView's or ListView's inside of ScrollView?

Can ListView's be made scrollable? I don't see any property on them that says so and when I try with:
            var list = new ListView(items)
            {
                X = 3,
                Y = 3,
                Width = Dim.Fill(),
                Height = Dim.Fill(),
                AllowsMarking = true
            };

it's not scrolling when I use the mouse or hit down arrow.
I also tried putting them inside of a scroll view like so:
            var list = new ListView(items)
            {
                X = 3,
                Y = 3,
                Width = Dim.Fill(),
                Height = Dim.Fill(),
                AllowsMarking = true
            };

            var scrollView = new ScrollView(new Rect(0, 0, top.Frame.Width - 3, top.Frame.Height - 2))
            {
                ShowVerticalScrollIndicator = true,
                ShowHorizontalScrollIndicator = false,
                X = 1,
                Y = 1,
                Width = Dim.Fill(),
                Height = Dim.Fill(),
                ContentSize = new Size(160, 400),
                ContentOffset = new Point(0, 0),
            };

            scrollView.Add(list);
            win.Add(scrollView);

which gave me the scroll bar, but the actual list wouldn't scroll.
Any pointers?

weird - I did a clean build and now it scrolls :) not sure what happened but I'm good!


PER. 3 MORT - LIBRARIES AND RANDOM VALUES HOMEWORK SUBMISSIONS

Post your name and a link to your hacks under this, grades will be linked here soon.
DEADLINE: Tuesday, 12/13, 8:00 PM
LATE PENALTY: -0.05 and a look of moderate disapproval (from Jeffrey) ((Either of them))
😎
GRADES ARE POSTED

Azeem Khan
Homework
Python Libraries Hacks

Mani Taleban
HW
Hacks

Keira Okimoto
Unit 3 Sections 14-15 Homework
Unit 3.14 Libraries Lesson
Unit 3.15 Random Values Student Copy

Derek Sol
HW/Hacks

Hacks

Jishnu Singiresu, Period 3
Homework and Notes

Vivian Ni
Link to hw and notes

Parav Salaniwal

HW
Hacks

Sreeja Gangapuram
Hacks

Kalani Cabral-Omana
HW

Toby Leeder
hack

Max Wu
hacks + hw

Alan Liu-Sui Per 3 Mortensen
Hacks and HW

Tirth Thakkar

Hacks and Homework
Sorry for the late submission thought the deadline was Wednesday at 8:00 AM and the lack of being on the main page it seems to be unupdated for some reason

Tanay Patel

HW

Evan Aparri

Ahad Biabani Period 3 Mort
hacks

Hacks/HW
Ethan Truong
Sorry for late submission, I was under the impression it was still due at 8:00 On Wednesday

Ekamjot Kaire
hw

Samit Poojary
Homework and Notes
Received Extension from Jeffrey

Notes plus hw

HW

HW

Sarah Liu

HW

HW Devon Shepherd

Jeffrey Fonseca


Adding Vajrakumar_Py folder

Vajrakumar_Py folder was added with two files to complete the task of the contribution program.

adding Vajrakumar_Py folder as per the readme.md file


Notifications screen - notifications are displayed incorrectly for max privacy transactions.

Bug description
On "Notifications" screen transactions sent or received by the max privacy are displayed with the same icon and the notification table of contents.

Incorrect notification when sending a regular transaction with regular UTXO.  The addres should be specified, not shielded pool.

checked on build 5.0.9505.3108


Evaluation (eval.py) giving CUDA error

I am training a model to detect a few thousands of tiny instances and I have accordingly adjusted my config.py file.
coco_base_config = Config({

...

    'max_num_detections': 1000,

 ...

    'nms_top_k': 1000,

...

    'masks_to_train': 1000,

...

    # Discard detections with width and height smaller than this (in absolute width and height)
    'discard_box_width': 1 / 550,
    'discard_box_height': 1 / 550,
...
})

While training I did not face any CUDA error however when I went to evaluate it with
python eval.py --trained_model=weights/yolact_custom_100_80000.pth --score_threshold=0.15 --top_k=1000 --image=input_image.png:output_image.png --config=yolact_custom_config
I face a CUDA error saying that I do not have enough memory. Why is this so? If training went out smoothly why does eval show me a CUDA error? How do i fix this error? Thank you!

Try reduce variable top_k. For my laptop with 6 gb of memory only 25 is ok. When I choose more than 25 there is cuda error


REPL requires two carriage returns to move to a new line

I am using ammonite-repl 0.5.8 and scala 2.11.8 on a Mac and every time I try to add a new line to my code it requires pressing enter twice to get a new line.

I just installed 0.5.7 to compare and it does not require double enters to get a new line.

Yeah this is a bug


Add the current provider to AttributeAccessInterface

This is currently done on Startup of the DataModel::Provider.
We do not yet have a set ordering for Startup, so we may have to iterate among register attribute access interface and usage of DataModel::Provider startup. However for now the basics should be there for addressing #36381

Closing PR: after an offline discussion, another concern popping up was that we have dynamic AAI being added and then the order of attach/detach is not so obvious anymore. The dynamic part could also attach however that makes for awkward/more brittle code.
The approach that will be taken instead will be to have construction-time arguments for AAI that need provider or similar variables. Our ember-specific code can assume CodegenDataModelProvider and other applications can call different versions as needed in their main.


Remove all PushNotificationIOS refrences

Summary
This PR removes all the references of PushNotificationIOS from the application
Changelog
[Lean Core] [cleanup] - Removed the PushNotificationIOS native module from React Native (now lives at https://github.com/react-native-community/push-notification-ios).
Test Plan
Tested by building and running the RNTester app for both Android and iOS to make sure the builds succeed and all the example references are cleanly removed; no issues found.

Duplicate of #30026


Query Editor doesn't show row or execution status in statusbar

Azure Data Studio Version: master

Steps to Reproduce:

Run a query

Expected: Details regarding row count and execution status are in the statusbar
Actual: Query status is no longer shown in the statusbar.  This is a recent regression.

Note below that there is now query status in the statusbar

I'm now seeing "Executing query..." while the query is running.  So perhaps the issue is that the Row Count goes away after execution is done.  I'll update if I have additional context.

@kburtram - I'm not able to repro this with latest version from master. Do you have more specific repro steps and does this seem to happen on any server you connect to?

I'll see if this is a mac-only issue

Closing as no repro.


A319 Tolis

after taking off in the plugin let it work in the a319 tolis

If you mean that after take off you cant control A319 toliss, so I have the same issue


SAMZA-1150 : Handling Error propagation between ZkJobCoordinator & DebounceTimer

This PR depends on PR #153

Treats all errors in jobcoordinator as FATAL and shuts-down the streamprocessor
[Bug] Fixed bug reported in SAMZA-1241
Introduced a callback to be associated with the timer (same callback for every Runnable failure)

TBD: some more unit tests

@xinyuiscool @sborya @prateekm Please review . thanks!


Document circunstances under which ResultSetMetadata::num_result_cols and others error

It seems that it requires the driver to provide incorrect information on them, but I am not sufficiently familiar with the code base (yet ^^)

You can try start here: https://docs.microsoft.com/en-us/sql/odbc/reference/syntax/sqlnumresultcols-function?view=sql-server-ver15 ;-)

Hello @jorgecarleitao ,
so finally I've a little bit time, to give a more elaborate answer. In general the ODBC functions have defined error states (and some drivers even stick to them. Not all though). Some of these are invalid state transitions, which users of the odbc-api crate are unlikely to see, since most of them are prevented through usage of Rusts type system.
Others capture misconfiguration of drivers, or runtime errors, like out of memory or a loss of connection. Due to the wide range of data sources which can be wrapped as an ODBC data source, functions can also fail due to a "Generic Error".
In practice I've never seen num_result_cols fail.
Hope this answers the quesion somewhat better.
Cheers, Markus

Personally I do not see yet, why the driver would be required to provide false information. That implies though, that I probably missed the point. On the other hand this is open for a month now, without moving forward. So I am closing this until interesst resparks.


Fix screenshot URL references

I found a better way of doing this across all of the presets, on the main repo. Will open that shortly.


refactor: simple code cleanups in mst implementation

Just cleaned a few things while reviewing the MST. All tests are passing, but some changes (ex: removing some condition) might require to add more tests. Let me know if you think that's the case

@ntampakas is it possible to let the workflows from forks to run and use the AWS credentials? Or is there a better way to deal with external contributions?

@ntampakas is it possible to let the workflows from forks to run and use the AWS credentials? Or is there a better way to deal with external contributions?

Hey Alex!
Probably you are referring to benchmark workflow that uses a self-hosted runner. Is this correct?
AFAIN, a forked repo, cannot execute workflows on the upstream side. What is the exact use case?

@ntampakas I'm referring to the Rust workflow for tests that runs on push, it is also using the self-hosted runner because of the past performance issues with the github runner.

I just talked with @sifnoc who explained to me why you moved to a self-hosted runner. Seems the change was made in PR #199 and time went from 15' to about 4'. I checked the runs before the PR and they were indeed around 15min but unfortunately I can't see the details because Github doesn't keep that information for that long, so I don't know what part was slow. But looking at more recent ones, it seems like running is actual test is the slow part, while installing the different components is fast. So my suggestion: why not just split the tests in different jobs (which will be run in parallel). Currently they are all run into 1 big job called "build". And I see 4 tasks being run:

Test Zk Prover
Test Zk Prover examples
Test backend
Test backend example
Let's split them and see. If it's unequal we can figure out how to split them differently.

i just pushed the change. i created a new workflow. I guess we can keep both running in parallel for now just to check the difference, and then decide which one to keep. We could also cache dependencies to make things even faster. I dont know if caching is possible for rust build/rust test though

How about switching between self-hosted runner and GitHub runner based on where the changes are coming from? E.g., if it's a fork, run in GitHub, but if it's in Summa org, use the current setup? Here's the way to detect the repo name: https://github.com/orgs/community/discussions/25217#discussioncomment-3246901

@teddav Do I get it right that now the tests would either run on both AWS and GitHub when pushed from Summa org or only on GitHub when pushed from a fork? In case of Summa org I was expecting the tests to only run in AWS, not on GitHub.

@alxkzmn yes you're right. It's useless to run on both. Even though now the AWS worker seems a bit overkill even for Summa's team. It seems like everything could run fine just on Github

This PR has been thoroughly discussed and is ready for merging. I appreciate the effort put into this PR, @teddav .
Based on the discussions, it seems that the next step for this PR would be to remove the requirement of an AWS instance in the workflow.


add mass matrix models

First pass to implement mass matrix models for the simulations
Pending:

[x] Governor tests
[x] AC1A tests
[x] Dyn Lines Tests
[ ] Small Signal

@rodrigomha for some models it is required to use "autodiff = false" to avoid the issue with dual numbers. This is also why we can't use forwardiff during the initialization. Probably the best approach is to calculate the jacobian once since currently we calculate the jacobian several times in the process of the simulation and don't exploit its sparsity either. This is something should tackle on a separate PR.


is it possible to add support for yeelink.light.ceiling5 ?

is it possible to add support for yeelink.light.ceiling5 ?
Thanks a lot

@wkamlun I think so, unless that's some old light with an outdated FW and API. But I expect no issues. Will add it today and let you know when you can test it. Cheers!

@wkamlun I've just pushed 1.1.5 that should support your model. Please try it out :)

It's work, thanks a lot
Viesturs Ruzans @.***>) 在 2022年2月23日星期三 上午01:44:28 [GMT+8] 寫道：
@wkamlun I've just pushed 1.1.5 that should support your model. Please try it out :)
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: @.***>


REST API to list all the rooms

Discord feedback: https://discord.com/channels/913109211746009108/913157273046646795/956834391559139358

Nico Bachner also asked for this on Discord: https://ptb.discord.com/channels/913109211746009108/913109211746009112/960848136027398194

Initial version released: https://liveblocks.io/docs/api-reference/rest-api-endpoints#GetRooms


How to show history tab?

[Enter feedback here]
Please give advises. the following documents indicate can not show history tab?
Default active tab to show in the Flow widget.
Valid values : 'receivedApprovals', 'sentApprovals'

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: fac3ad92-eb8f-554a-5de3-14c430e594aa
Version Independent ID: fab1ceb3-5110-4452-0a0d-99346cc31230
Content: Integrate Microsoft Flow with websites and apps - Microsoft Flow
Content Source: flow-docs/developer/embed-flow-dev.md
Service: flow
GitHub Login: @bbarath
Microsoft Alias: barathb

@luoyong0201 Thanks for using Power Automate. Yes, the valid values are: 'receivedApprovals' and 'sentApprovals'. Thank you.


No documentation on the usage of seeders

Having looked through the codebase, docs and even the issues, the only thing I can find related to documentation on the usage of seeders, is lots of people asking for  documentation, one person posting a link that returns a "502 bad gateway" error and no actual documentation.
So I thought I'd better just come straight out and ask myself, is there any documentation on creating and using seeders, whether there is a command to create a barebones seed file (like with migrations), how a seed file might look etc.
Thanks in advance.

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

you will find some information here: https://github.com/db-migrate/node-db-migrate/issues/292

Closing and referring also to #292, just posted something over there, more later this week.


GPU Acceleration?

Does this framework support GPU accelerated decode? Playing back a 1080p video in Firefox (OS X) is pushing my CPU right up to 100% :cry:

Unfortunately, GPU accelerated decoding is not supported now by openh264.

Does the bit steam be fed to decoder at a constant speed such as 30frame per second or it is fed at a whole (as in the decoder console)? if the latter, the decoder will try to use all available resource to decode which may make the CPU usage to jump.

I do appologise, however I was mistaken by the CPU usage. That was actually on a VP9 stream. VP9 disabled and it's down to a more manageable 40-50%. Can I leave this issue open as a "would be nice to have" feature request, or is this really out of the question for this project?

Hi, good to know that it is false alarm, I will close this one then. There is no plan for supporting GPU Acceleration in this project yet.


Update README.md

Not sure if we should move the compile instructions completely to the readme.

I suggest to update the readme at non ng repo. This repo should not be used for daily usage. I don't want that people open more and more issues here that is a alpha problem.

Was ist eigentlich mit diesem PR? Kann das weg? Oder?

changes made in #306


Add .NET Backend validation build to CI

Overview
Most developers use IL2CPP on their day to day work. This means .NET backend is easy to break.
Add an additional build configuration to CI that uses the .NET backend (instead of IL2CPP). CI should fail if that configuration fails.

Got this working, will be sending out PR for this soon...

Pretty sure this is complete, as of #4521


testing/crypto: add ECDSA P256 testing case for asynchronous call

Summary

Add asynchronous call test into ecdsa test case.
Add command line parameters to facilitate subsequent expansion.
Now can test synchronous call through 'ecdsa -s SECP256R1' and test asynchronous call through 'ecdsa -a SECP256R1'

Impact
N/A
Testing
ci

[Experimental Bot, please feedback here]
Yes, but with minor improvements:
Concise Assessment:
The PR seems to meet the requirements, providing context, impact assessment, and testing confirmation. However, the testing section lacks specifics.
Suggested Improvements:

Testing:

Specify the build host OS, CPU, and compiler used.
List the target architectures and boards used for testing.
Instead of stating "ci," provide a link to the successful CI build or relevant test logs.

By adding these details, you offer a more comprehensive and transparent view of the testing process.


Investigate on resilient Sentinel connections using Master/Slave connections

Master/Slave Connections can be established as long as at least one Sentinel is available (see #304). lettuce opens Pub/Sub connection upon connect to receive configuration updates. Investigate on possibilities to utilize Pub/Sub to obtain configuration updates on appearing/disappearing Redis Sentinel nodes for adaptive Sentinel monitoring.

See also: https://groups.google.com/forum/#!topic/lettuce-redis-client-users/Rt1W1ciXfIU

Sentinel Pub/Sub messages +sentinel and -odown/-sdown are good signals to discover changes in Redis Sentinel state changes (added Sentinel, Sentinel back up).
Consider we have two sentinels configured, and one of them is down at the time establishing the Master/Slave connection. Assuming a few things are set up the right way (firewall rules, reported IP addresses) it could be possible establishing the additional Sentinel connection from the reported events and payload reported in the event. This implies at least that the sentinel hostname resolves to the same IP address to connect the specified sentinel node. Not limiting/filtering sentinel nodes, that get available could easily lead to connections to possibly unwanted nodes.
The better alternative might be to use these signals to reattempt connections to nodes which failed to connect initially.


lxc: 2.1.1 -> 3.0.0

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools.
This update was made based on information from https://repology.org/metapackage/lxc/versions.
These checks were done:

built on NixOS
ran ‘/nix/store/mvaxvwlslyaiksjrwcm2rmmnnf8z02w3-lxc-3.0.0/bin/lxc-attach -h’ got 0 exit code
ran ‘/nix/store/mvaxvwlslyaiksjrwcm2rmmnnf8z02w3-lxc-3.0.0/bin/lxc-attach --help’ got 0 exit code
ran ‘/nix/store/mvaxvwlslyaiksjrwcm2rmmnnf8z02w3-lxc-3.0.0/bin/lxc-attach --version’ and found version 3.0.0
ran ‘/nix/store/mvaxvwlslyaiksjrwcm2rmmnnf8z02w3-lxc-3.0.0/bin/lxc-autostart -h’ got 0 exit code
ran ‘/nix/store/mvaxvwlslyaiksjrwcm2rmmnnf8z02w3-lxc-3.0.0/bin/lxc-autostart --help’ got 0 exit code
ran ‘/nix/store/mvaxvwlslyaiksjrwcm2rmmnnf8z02w3-lxc-3.0.0/bin/lxc-autostart --version’ and found version 3.0.0
ran ‘/nix/store/mvaxvwlslyaiksjrwcm2rmmnnf8z02w3-lxc-3.0.0/bin/lxc-cgroup -h’ got 0 exit code
ran ‘/nix/store/mvaxvwlslyaiksjrwcm2rmmnnf8z02w3-lxc-3.0.0/bin/lxc-cgroup --help’ got 0 exit code
ran ‘/nix/store/mvaxvwlslyaiksjrwcm2rmmnnf8z02w3-lxc-3.0.0/bin/lxc-cgroup --version’ and found version 3.0.0
ran ‘/nix/store/mvaxvwlslyaiksjrwcm2rmmnnf8z02w3-lxc-3.0.0/bin/lxc-checkpoint -h’ got 0 exit code
ran ‘/nix/store/mvaxvwlslyaiksjrwcm2rmmnnf8z02w3-lxc-3.0.0/bin/lxc-checkpoint --help’ got 0 exit code
ran ‘/nix/store/mvaxvwlslyaiksjrwcm2rmmnnf8z02w3-lxc-3.0.0/bin/lxc-checkpoint --version’ and found version 3.0.0
ran ‘/nix/store/mvaxvwlslyaiksjrwcm2rmmnnf8z02w3-lxc-3.0.0/bin/lxc-copy -h’ got 0 exit code
ran ‘/nix/store/mvaxvwlslyaiksjrwcm2rmmnnf8z02w3-lxc-3.0.0/bin/lxc-copy --help’ got 0 exit code
ran ‘/nix/store/mvaxvwlslyaiksjrwcm2rmmnnf8z02w3-lxc-3.0.0/bin/lxc-copy --version’ and found version 3.0.0
ran ‘/nix/store/mvaxvwlslyaiksjrwcm2rmmnnf8z02w3-lxc-3.0.0/bin/lxc-config -h’ got 0 exit code
ran ‘/nix/store/mvaxvwlslyaiksjrwcm2rmmnnf8z02w3-lxc-3.0.0/bin/lxc-config --help’ got 0 exit code
ran ‘/nix/store/mvaxvwlslyaiksjrwcm2rmmnnf8z02w3-lxc-3.0.0/bin/lxc-console -h’ got 0 exit code
ran ‘/nix/store/mvaxvwlslyaiksjrwcm2rmmnnf8z02w3-lxc-3.0.0/bin/lxc-console --help’ got 0 exit code
ran ‘/nix/store/mvaxvwlslyaiksjrwcm2rmmnnf8z02w3-lxc-3.0.0/bin/lxc-console --version’ and found version 3.0.0
ran ‘/nix/store/mvaxvwlslyaiksjrwcm2rmmnnf8z02w3-lxc-3.0.0/bin/lxc-create -h’ got 0 exit code
ran ‘/nix/store/mvaxvwlslyaiksjrwcm2rmmnnf8z02w3-lxc-3.0.0/bin/lxc-create --help’ got 0 exit code
ran ‘/nix/store/mvaxvwlslyaiksjrwcm2rmmnnf8z02w3-lxc-3.0.0/bin/lxc-create --version’ and found version 3.0.0
ran ‘/nix/store/mvaxvwlslyaiksjrwcm2rmmnnf8z02w3-lxc-3.0.0/bin/lxc-destroy -h’ got 0 exit code
ran ‘/nix/store/mvaxvwlslyaiksjrwcm2rmmnnf8z02w3-lxc-3.0.0/bin/lxc-destroy --help’ got 0 exit code
ran ‘/nix/store/mvaxvwlslyaiksjrwcm2rmmnnf8z02w3-lxc-3.0.0/bin/lxc-destroy --version’ and found version 3.0.0
ran ‘/nix/store/mvaxvwlslyaiksjrwcm2rmmnnf8z02w3-lxc-3.0.0/bin/lxc-execute -h’ got 0 exit code
ran ‘/nix/store/mvaxvwlslyaiksjrwcm2rmmnnf8z02w3-lxc-3.0.0/bin/lxc-execute --help’ got 0 exit code
ran ‘/nix/store/mvaxvwlslyaiksjrwcm2rmmnnf8z02w3-lxc-3.0.0/bin/lxc-execute --version’ and found version 3.0.0
ran ‘/nix/store/mvaxvwlslyaiksjrwcm2rmmnnf8z02w3-lxc-3.0.0/bin/lxc-freeze -h’ got 0 exit code
ran ‘/nix/store/mvaxvwlslyaiksjrwcm2rmmnnf8z02w3-lxc-3.0.0/bin/lxc-freeze --help’ got 0 exit code
ran ‘/nix/store/mvaxvwlslyaiksjrwcm2rmmnnf8z02w3-lxc-3.0.0/bin/lxc-freeze --version’ and found version 3.0.0
ran ‘/nix/store/mvaxvwlslyaiksjrwcm2rmmnnf8z02w3-lxc-3.0.0/bin/lxc-info -h’ got 0 exit code
ran ‘/nix/store/mvaxvwlslyaiksjrwcm2rmmnnf8z02w3-lxc-3.0.0/bin/lxc-info --help’ got 0 exit code
ran ‘/nix/store/mvaxvwlslyaiksjrwcm2rmmnnf8z02w3-lxc-3.0.0/bin/lxc-info --version’ and found version 3.0.0
ran ‘/nix/store/mvaxvwlslyaiksjrwcm2rmmnnf8z02w3-lxc-3.0.0/bin/lxc-ls -h’ got 0 exit code
ran ‘/nix/store/mvaxvwlslyaiksjrwcm2rmmnnf8z02w3-lxc-3.0.0/bin/lxc-ls --help’ got 0 exit code
ran ‘/nix/store/mvaxvwlslyaiksjrwcm2rmmnnf8z02w3-lxc-3.0.0/bin/lxc-ls help’ got 0 exit code
ran ‘/nix/store/mvaxvwlslyaiksjrwcm2rmmnnf8z02w3-lxc-3.0.0/bin/lxc-ls --version’ and found version 3.0.0
ran ‘/nix/store/mvaxvwlslyaiksjrwcm2rmmnnf8z02w3-lxc-3.0.0/bin/lxc-monitor -h’ got 0 exit code
ran ‘/nix/store/mvaxvwlslyaiksjrwcm2rmmnnf8z02w3-lxc-3.0.0/bin/lxc-monitor --help’ got 0 exit code
ran ‘/nix/store/mvaxvwlslyaiksjrwcm2rmmnnf8z02w3-lxc-3.0.0/bin/lxc-monitor --version’ and found version 3.0.0
ran ‘/nix/store/mvaxvwlslyaiksjrwcm2rmmnnf8z02w3-lxc-3.0.0/bin/lxc-snapshot -h’ got 0 exit code
ran ‘/nix/store/mvaxvwlslyaiksjrwcm2rmmnnf8z02w3-lxc-3.0.0/bin/lxc-snapshot --help’ got 0 exit code
ran ‘/nix/store/mvaxvwlslyaiksjrwcm2rmmnnf8z02w3-lxc-3.0.0/bin/lxc-snapshot --version’ and found version 3.0.0
ran ‘/nix/store/mvaxvwlslyaiksjrwcm2rmmnnf8z02w3-lxc-3.0.0/bin/lxc-start -h’ got 0 exit code
ran ‘/nix/store/mvaxvwlslyaiksjrwcm2rmmnnf8z02w3-lxc-3.0.0/bin/lxc-start --help’ got 0 exit code
ran ‘/nix/store/mvaxvwlslyaiksjrwcm2rmmnnf8z02w3-lxc-3.0.0/bin/lxc-start --version’ and found version 3.0.0
ran ‘/nix/store/mvaxvwlslyaiksjrwcm2rmmnnf8z02w3-lxc-3.0.0/bin/lxc-stop -h’ got 0 exit code
ran ‘/nix/store/mvaxvwlslyaiksjrwcm2rmmnnf8z02w3-lxc-3.0.0/bin/lxc-stop --help’ got 0 exit code
ran ‘/nix/store/mvaxvwlslyaiksjrwcm2rmmnnf8z02w3-lxc-3.0.0/bin/lxc-stop --version’ and found version 3.0.0
ran ‘/nix/store/mvaxvwlslyaiksjrwcm2rmmnnf8z02w3-lxc-3.0.0/bin/lxc-top -h’ got 0 exit code
ran ‘/nix/store/mvaxvwlslyaiksjrwcm2rmmnnf8z02w3-lxc-3.0.0/bin/lxc-top --help’ got 0 exit code
ran ‘/nix/store/mvaxvwlslyaiksjrwcm2rmmnnf8z02w3-lxc-3.0.0/bin/lxc-top --version’ and found version 3.0.0
ran ‘/nix/store/mvaxvwlslyaiksjrwcm2rmmnnf8z02w3-lxc-3.0.0/bin/lxc-unfreeze -h’ got 0 exit code
ran ‘/nix/store/mvaxvwlslyaiksjrwcm2rmmnnf8z02w3-lxc-3.0.0/bin/lxc-unfreeze --help’ got 0 exit code
ran ‘/nix/store/mvaxvwlslyaiksjrwcm2rmmnnf8z02w3-lxc-3.0.0/bin/lxc-unfreeze --version’ and found version 3.0.0
ran ‘/nix/store/mvaxvwlslyaiksjrwcm2rmmnnf8z02w3-lxc-3.0.0/bin/lxc-unshare -h’ got 0 exit code
ran ‘/nix/store/mvaxvwlslyaiksjrwcm2rmmnnf8z02w3-lxc-3.0.0/bin/lxc-unshare --help’ got 0 exit code
ran ‘/nix/store/mvaxvwlslyaiksjrwcm2rmmnnf8z02w3-lxc-3.0.0/bin/lxc-unshare help’ got 0 exit code
ran ‘/nix/store/mvaxvwlslyaiksjrwcm2rmmnnf8z02w3-lxc-3.0.0/bin/lxc-usernsexec -h’ got 0 exit code
ran ‘/nix/store/mvaxvwlslyaiksjrwcm2rmmnnf8z02w3-lxc-3.0.0/bin/lxc-wait -h’ got 0 exit code
ran ‘/nix/store/mvaxvwlslyaiksjrwcm2rmmnnf8z02w3-lxc-3.0.0/bin/lxc-wait --help’ got 0 exit code
ran ‘/nix/store/mvaxvwlslyaiksjrwcm2rmmnnf8z02w3-lxc-3.0.0/bin/lxc-wait --version’ and found version 3.0.0
ran ‘/nix/store/mvaxvwlslyaiksjrwcm2rmmnnf8z02w3-lxc-3.0.0/bin/lxc-checkconfig -h’ got 0 exit code
ran ‘/nix/store/mvaxvwlslyaiksjrwcm2rmmnnf8z02w3-lxc-3.0.0/bin/lxc-checkconfig --help’ got 0 exit code
ran ‘/nix/store/mvaxvwlslyaiksjrwcm2rmmnnf8z02w3-lxc-3.0.0/bin/lxc-checkconfig help’ got 0 exit code
ran ‘/nix/store/mvaxvwlslyaiksjrwcm2rmmnnf8z02w3-lxc-3.0.0/bin/lxc-update-config -h’ got 0 exit code
ran ‘/nix/store/mvaxvwlslyaiksjrwcm2rmmnnf8z02w3-lxc-3.0.0/bin/lxc-update-config --help’ got 0 exit code
ran ‘/nix/store/mvaxvwlslyaiksjrwcm2rmmnnf8z02w3-lxc-3.0.0/bin/init.lxc -h’ got 0 exit code
ran ‘/nix/store/mvaxvwlslyaiksjrwcm2rmmnnf8z02w3-lxc-3.0.0/bin/init.lxc --help’ got 0 exit code
ran ‘/nix/store/mvaxvwlslyaiksjrwcm2rmmnnf8z02w3-lxc-3.0.0/bin/init.lxc --version’ and found version 3.0.0
found 3.0.0 with grep in /nix/store/mvaxvwlslyaiksjrwcm2rmmnnf8z02w3-lxc-3.0.0
directory tree listing: https://gist.github.com/a0534e4d403fd56527c3c04558911af3

cc @wkennington @globin @fpletz for review

No attempt on x86_64-darwin (full log)
The following builds were skipped because they don't evaluate on x86_64-darwin: lxc
Partial log (click to expand)

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

Success on x86_64-linux (full log)
Attempted: lxc
Partial log (click to expand)
/nix/store/mvaxvwlslyaiksjrwcm2rmmnnf8z02w3-lxc-3.0.0/share/lxc/hooks/dhclient-script: interpreter directive changed from "/bin/bash" to "/nix/store/q1g0rl8zfmz7r371fp5p42p4acmv297d-bash-4.4-p19/bin/bash"
/nix/store/mvaxvwlslyaiksjrwcm2rmmnnf8z02w3-lxc-3.0.0/share/lxc/hooks/dhclient: interpreter directive changed from " /bin/bash" to "/nix/store/q1g0rl8zfmz7r371fp5p42p4acmv297d-bash-4.4-p19/bin/bash"
/nix/store/mvaxvwlslyaiksjrwcm2rmmnnf8z02w3-lxc-3.0.0/share/lxc/hooks/squid-deb-proxy-client: interpreter directive changed from "/bin/sh" to "/nix/store/q1g0rl8zfmz7r371fp5p42p4acmv297d-bash-4.4-p19/bin/sh"
/nix/store/mvaxvwlslyaiksjrwcm2rmmnnf8z02w3-lxc-3.0.0/share/lxc/hooks/nvidia: interpreter directive changed from " /bin/bash" to "/nix/store/q1g0rl8zfmz7r371fp5p42p4acmv297d-bash-4.4-p19/bin/bash"
/nix/store/mvaxvwlslyaiksjrwcm2rmmnnf8z02w3-lxc-3.0.0/libexec/lxc/lxc-containers: interpreter directive changed from "/bin/sh" to "/nix/store/q1g0rl8zfmz7r371fp5p42p4acmv297d-bash-4.4-p19/bin/sh"
/nix/store/mvaxvwlslyaiksjrwcm2rmmnnf8z02w3-lxc-3.0.0/libexec/lxc/lxc-net: interpreter directive changed from "/bin/sh -" to "/nix/store/q1g0rl8zfmz7r371fp5p42p4acmv297d-bash-4.4-p19/bin/sh -"
/nix/store/mvaxvwlslyaiksjrwcm2rmmnnf8z02w3-lxc-3.0.0/bin/lxc-checkconfig: interpreter directive changed from "/bin/sh" to "/nix/store/q1g0rl8zfmz7r371fp5p42p4acmv297d-bash-4.4-p19/bin/sh"
/nix/store/mvaxvwlslyaiksjrwcm2rmmnnf8z02w3-lxc-3.0.0/bin/lxc-update-config: interpreter directive changed from "/bin/sh" to "/nix/store/q1g0rl8zfmz7r371fp5p42p4acmv297d-bash-4.4-p19/bin/sh"
checking for references to /build in /nix/store/mvaxvwlslyaiksjrwcm2rmmnnf8z02w3-lxc-3.0.0...
moving /nix/store/mvaxvwlslyaiksjrwcm2rmmnnf8z02w3-lxc-3.0.0/sbin/* to /nix/store/mvaxvwlslyaiksjrwcm2rmmnnf8z02w3-lxc-3.0.0/bin

When this is updated, it should be merged together with the lxcfs upgrade:
https://github.com/NixOS/nixpkgs/pull/37985
Maybe we also want to keep lxc 2.0 for a while?

@Mic92 Doesn't look like many packages are using it. Is there some sort of breakage?

@matthewbauer configuration is backward incompatible to the previous version.


LineChart labelColor does not change its always equal of lineColor

Here is the my marker code:
internal fun getMarker(
    @ColorInt labelColor: Int,
    @ColorInt bubbleColor: Int
): Marker {
    val labelBackgroundShape = MarkerCorneredShape(all = Corner.FullyRounded)
    val label = textComponent {
        color = labelColor
        ellipsize = TextUtils.TruncateAt.END
        lineCount = 1
        padding = MutableDimensions(horizontalDp = 8f, verticalDp = 4f)
        typeface = Typeface.MONOSPACE
        background = ShapeComponent(shape = labelBackgroundShape, color = bubbleColor)
    }

    val indicator = ShapeComponent(
        shape = pillShape,
        color = androidx.compose.ui.graphics.Color(0XFF005BC0).toArgb()
    )

    return object : MarkerComponent(
        label = label,
        indicator = indicator,
        guideline = null
    ) {
        init {
            indicatorSizeDp = 7f
        }
    }
}

The value I entered in the labelColor does not change anything. The labelColor is always the same color as the lineColor.
When I change the lineColor in ChartStyle like this:
LineChart.LineSpec(lineColor = someColor)

label color changing to someColor too.

The answer has already been given…. -> https://github.com/patrykandpatrick/vico/issues/219


Verifier 3.B may be wrong

I think that instead  of
(3.B) Qbar = H(Q, K).
weve got
Qbar = H(Q, record.context.commitment_hash).
but record.context.commitment_hash != K = public_key.

I think that this change to Qbar was inadvertantly left out of the spec. See
https://github.com/microsoft/electionguard/issues/290


CLOUD-42526 more blueprint added

@biharitomi

Jenkins build finished, all tests passed.
Refer to this link for build results: http://ci.sequenceiq.com/job/cloudbreak-pull-request/1779/