executing "" at <.Alerts>: can't evaluate field Alerts in type template.Alert

What did you do?
Create custom notification templates
What did you expect to see?
Notifications being sent to Slack in the expected format.
What did you see instead? Under which circumstances?
No notifications is being sent when an alert fires.
Environment

System information:
Running the official Docker image:

Linux 4.9.0-4-amd64 x86_64

Alertmanager version:

alertmanager, version 0.9.1 (branch: HEAD, revision: 9f5f4b2a516d35cfaf196530b277f1d109254569)
  build user:       root@3b87d661c3dd
  build date:       20170929-12:59:03
  go version:       go1.9

Prometheus version:

/prometheus $ prometheus -version
Error parsing commandline arguments: unknown short flag '-v'
prometheus: error: unknown short flag '-v'

/prometheus $ prometheus --version
prometheus, version 2.0.0-rc.1 (branch: HEAD, revision: 5ab8834befbd92241a88976c790ace7543edcd59)
  build user:       root@1f56dd8b6f7b
  build date:       20171017-12:34:15
  go version:       go1.9.1

Alertmanager configuration file:

global:
[...]
route:
  receiver: k8s-admin-slack
  group_by:
  - alertname
  - k8s_cluster
receivers:
- name: k8s-admin-slack
  slack_configs:
  - send_resolved: true
    api_url: <secret>
    channel: k8s-alerts
    username: '{{ template "slack.default.username" . }}'
    color: '{{ if eq .Status "firing" }}danger{{ else }}good{{ end }}'
    title: '[{{ .Status | toUpper }}] <{{ template "__alertmanagerURL" . }}|{{ .CommonAnnotations.summary
      }}>'
    title_link: '{{ template "slack.default.titlelink" . }}'
    pretext: '{{ template "slack.default.pretext" . }}'
    text: |-
      *Cluster:* {{ .CommonLabels.k8s_cluster }}
      {{ range .Alerts }}{{ if gt (len .Alerts) 1 }}--
      {{ end }}
      {{ .Annotations.description }}
      {{ end }}
    fallback: '{{ template "slack.default.fallback" . }}'
    icon_emoji: '{{ template "slack.default.iconemoji" . }}'
    icon_url: '{{ template "slack.default.iconurl" . }}'
templates:
- /etc/alertmanager/slack.tmpl

Prometheus configuration file:

[...]
      - alert: ScrapeTargetDown
        expr: up != 1
        for: 5m
        labels:
          severity: warn
        annotations:
          summary: "Scrape target down"
          description: "*Details:* The scrape target *{{ .Labels.job }}* on host *{{ .Labels.instance }}* is down."

Logs:

 time="2017-10-23T09:20:50Z" level=error msg="Notify for 1 alerts failed: Cancelling notify retry for "slack" due to unrecoverable error: template: :2:33: executing "" at <.Alerts>: can't evaluate field Alerts in type template.Alert" source="dispatch.go:264"
time="2017-10-23T09:21:50Z" level=error msg="Error on notify: Cancelling notify retry for "slack" due to unrecoverable error: template: :2:33: executing "" at <.Alerts>: can't evaluate field Alerts in type template.Alert" source="notify.go:283"

{{ range .Alerts }}{{ if gt (len .Alerts) 1 }}

Here . has changed to the individual alert, which does not contain an Alerts field. If you want to access this inside the range, you need to save it off to a variable first.

Ah, that is surprising, but actually makes sense. Thanks!


I can´t compile llm with nix

git clone https://github.com/rustformers/llm.git
nix build

error: builder for '/nix/store/zllzqwj422zqrsl24lgr6j5y0m4c1mx7-rust-workspace-deps-unknown.drv' failed with exit code 101; last 10 log lines: > [naersk] RUSTFLAGS: > [naersk] CARGO_BUILD_RUSTFLAGS: > [naersk] CARGO_BUILD_RUSTFLAGS (updated): --remap-path-prefix /nix/store/772s1031nnkf5b5qzw55g6nkir1k2jjc-dependencies=/sources > building > cargo build $cargo_release -j "$NIX_BUILD_CORES" --message-format=$cargo_message_format > error: package half v2.3.1 cannot be built because it requires rustc 1.70 or newer, while the currently active rustc version is 1.69.0 > Either upgrade to rustc 1.70 or newer, or use > cargo update -p<EMAIL_ADDRESS>--precise ver > where ver is the latest version of half supporting rustc 1.69.0 > [naersk] cargo returned with exit code 101, exiting For full logs, run 'nix log /nix/store/zllzqwj422zqrsl24lgr6j5y0m4c1mx7-rust-workspace-deps-unknown.drv'.

This stackoverflow question add more informations
https://stackoverflow.com/questions/76675438/how-to-compile-the-llm-library-with-nix
This one too:
https://stackoverflow.com/questions/76675795/does-nix-always-create-virtual-environment-deterministically

Thanks, it looks like one of our dependencies raised its minimum Rust version to 1.70.0. I'll see if we can bring the MSRV down.

Should work now - let me know if it still occurs!

Hello,
I think the problem is fixed. I have another error now.
warning: Git tree '/mnt/c/Users/gendraup/llm/llm' is dirty
error: builder for '/nix/store/xyli650f4w0lpvvjgw57lszinvvwv80q-rust-workspace-deps-unknown.drv' failed with exit code 101;
last 10 log lines:
>
>   It looks like you're compiling on Linux and also targeting Linux. Currently this
>   requires the pkg-config utility to find OpenSSL but unfortunately pkg-config
>   could not be found. If you have OpenSSL installed you can likely fix this by
>   installing pkg-config.
>
>   ', /sources/openssl-sys-0.9.90/build/find_normal.rs:190:5
>   note: run with RUST_BACKTRACE=1 environment variable to display a backtrace
> warning: build failed, waiting for other jobs to finish...
> [naersk] cargo returned with exit code 101, exiting
For full logs, run 'nix log /nix/store/xyli650f4w0lpvvjgw57lszinvvwv80q-rust-workspace-deps-unknown.drv'.
error: 1 dependencies of derivation '/nix/store/7jd7fpgcjs4hv435v3xl00yql8ba5qj0-rust-workspace-unknown.drv' failed to build
I change llm like that:
    llm = naersk'.buildPackage {
      src = ./.;
      nativeBuildInputs=[ pkgs.pkg-config];

Now I have another error.
warning: Git tree '/mnt/c/Users/gendraup/llm/llm' is dirty
error: builder for '/nix/store/8kz82i1fx8biiyd1g9f9xlci7ghn98fc-rust-workspace-deps-unknown.drv' failed with exit code 101;
last 10 log lines:
>   and include information about your system as well as this message.
>
>   $HOST = x86_64-unknown-linux-gnu
>   $TARGET = x86_64-unknown-linux-gnu
>   openssl-sys = 0.9.90
>
>   ', /sources/openssl-sys-0.9.90/build/find_normal.rs:190:5
>   note: run with RUST_BACKTRACE=1 environment variable to display a backtrace
> warning: build failed, waiting for other jobs to finish...
> [naersk] cargo returned with exit code 101, exiting
For full logs, run 'nix log /nix/store/8kz82i1fx8biiyd1g9f9xlci7ghn98fc-rust-workspace-deps-unknown.drv'.
error: 1 dependencies of derivation '/nix/store/ck6lsynl0am8wqazg5ypdq27nvpxy364-rust-workspace-unknown.drv' failed to build
nix log /nix/store/8kz82i1fx8biiyd1g9f9xlci7ghn98fc-rust-workspace-deps-unknown.drv':
error: failed to run custom build command for openssl-sys v0.9.90
Caused by:
process didn't exit successfully: /build/dummy-src/target/release/build/openssl-sys-b1ba5b75368d72d5/build-script-main (exit sta>
--- stdout
cargo:rerun-if-env-changed=X86_64_UNKNOWN_LINUX_GNU_OPENSSL_LIB_DIR
X86_64_UNKNOWN_LINUX_GNU_OPENSSL_LIB_DIR unset
cargo:rerun-if-env-changed=OPENSSL_LIB_DIR
OPENSSL_LIB_DIR unset
cargo:rerun-if-env-changed=X86_64_UNKNOWN_LINUX_GNU_OPENSSL_INCLUDE_DIR
X86_64_UNKNOWN_LINUX_GNU_OPENSSL_INCLUDE_DIR unset
cargo:rerun-if-env-changed=OPENSSL_INCLUDE_DIR
OPENSSL_INCLUDE_DIR unset
cargo:rerun-if-env-changed=X86_64_UNKNOWN_LINUX_GNU_OPENSSL_DIR
X86_64_UNKNOWN_LINUX_GNU_OPENSSL_DIR unset
cargo:rerun-if-env-changed=OPENSSL_DIR
OPENSSL_DIR unset
cargo:rerun-if-env-changed=OPENSSL_NO_PKG_CONFIG
cargo:rerun-if-env-changed=PKG_CONFIG_x86_64-unknown-linux-gnu
cargo:rerun-if-env-changed=PKG_CONFIG_x86_64_unknown_linux_gnu
cargo:rerun-if-env-changed=HOST_PKG_CONFIG
cargo:rerun-if-env-changed=PKG_CONFIG
cargo:rerun-if-env-changed=OPENSSL_STATIC
cargo:rerun-if-env-changed=OPENSSL_DYNAMIC
cargo:rerun-if-env-changed=PKG_CONFIG_ALL_STATIC
cargo:rerun-if-env-changed=PKG_CONFIG_ALL_DYNAMIC
cargo:rerun-if-env-changed=PKG_CONFIG_PATH_x86_64-unknown-linux-gnu
cargo:rerun-if-env-changed=PKG_CONFIG_PATH_x86_64_unknown_linux_gnu
cargo:rerun-if-env-changed=HOST_PKG_CONFIG_PATH
cargo:rerun-if-env-changed=PKG_CONFIG_PATH
cargo:rerun-if-env-changed=PKG_CONFIG_LIBDIR_x86_64-unknown-linux-gnu
cargo:rerun-if-env-changed=PKG_CONFIG_LIBDIR_x86_64_unknown_linux_gnu
cargo:rerun-if-env-changed=HOST_PKG_CONFIG_LIBDIR
cargo:rerun-if-env-changed=PKG_CONFIG_LIBDIR
cargo:rerun-if-env-changed=PKG_CONFIG_SYSROOT_DIR_x86_64-unknown-linux-gnu
cargo:rerun-if-env-changed=PKG_CONFIG_SYSROOT_DIR_x86_64_unknown_linux_gnu
cargo:rerun-if-env-changed=HOST_PKG_CONFIG_SYSROOT_DIR
cargo:rerun-if-env-changed=PKG_CONFIG_SYSROOT_DIR
run pkg_config fail: PKG_CONFIG_ALLOW_SYSTEM_CFLAGS="1" "pkg-config" "--libs" "--cflags" "openssl" did not exit successfully: ex>
error: could not find system library 'openssl' required by the 'openssl-sys' crate
--- stderr
Package openssl was not found in the pkg-config search path.
Perhaps you should add the directory containing `openssl.pc'
to the PKG_CONFIG_PATH environment variable
No package 'openssl' found
--- stderr
thread 'main' panicked at '
Could not find directory of OpenSSL installation, and this -sys crate cannot
proceed without this knowledge. If OpenSSL is installed and this crate had
trouble finding it,  you can set the OPENSSL_DIR environment variable for the
compilation process.
Make sure you also have the development packages of openssl installed.
For example, libssl-dev on Ubuntu or openssl-devel on Fedora.
If you're in a situation where you think the directory should be found
automatically, please open a bug at https://github.com/sfackler/rust-openssl
and include information about your system as well as this message.
$HOST = x86_64-unknown-linux-gnu
$TARGET = x86_64-unknown-linux-gnu
openssl-sys = 0.9.90
', /sources/openssl-sys-0.9.90/build/find_normal.rs:190:5
note: run with RUST_BACKTRACE=1 environment variable to display a backtrace
warning: build failed, waiting for other jobs to finish...
[naersk] cargo returned with exit code 101, exiting
lines 120-152/152 (END)
P.S. : could you please explain what does MSRV  mean

previous problem fixed but another appears
llm = naersk'.buildPackage {
src = ./.;
nativeBuildInputs=[ pkgs.pkg-config pkgs.openssl] ;
};
    error: builder for '/nix/store/2d8ngvqrdx79sm1q8dmyqs753r1jf4f6-rust-workspace-unknown.drv' failed with exit code 101;
   last 10 log lines:
   > cargo build $cargo_release -j "$NIX_BUILD_CORES" --message-format=$cargo_message_format
   >    Compiling ggml-sys v0.2.0-dev (/build/source/crates/ggml/sys)
   > error: failed to run custom build command for `ggml-sys v0.2.0-dev (/build/source/crates/ggml/sys)`
   >
   > Caused by:
   >   process didn't exit successfully: `/build/source/target/release/build/ggml-sys-7b12760c63a3529b/build-script-build` (exit status: 101)
   >   --- stderr
   >   thread 'main' panicked at 'Could not find llama-cpp/ggml.c. Try running `git submodule update --init`', crates/ggml/sys/build.rs:111:5
   >   note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
   > [naersk] cargo returned with exit code 101, exiting
   For full logs, run 'nix log /nix/store/2d8ngvqrdx79sm1q8dmyqs753r1jf4f6-rust-workspace-unknown.drv'.

    log file

error: failed to run custom build command for ggml-sys v0.2.0-dev (/build/source/crates/ggml/sys)
Caused by:
process didn't exit successfully: /build/source/target/release/build/ggml-sys-7b12760c63a3529b/build-script-build (exit status: >
--- stderr
thread 'main' panicked at 'Could not find llama-cpp/ggml.c. Try running git submodule update --init', crates/ggml/sys/build.rs:1>
note: run with RUST_BACKTRACE=1 environment variable to display a backtrace
[naersk] cargo returned with exit code 101, exiting
P.S. : could you please explain what does MSRV mean

Thanks!
Yep, the two issues you've encountered are:

We have a dependency on OpenSSL for being able to remotely download tokenizers from Hugging Face. You can fix this by including OpenSSL in the flake, or by building with --no-default-features.
The repository has a Git submodule for llama.cpp, and I'm guessing the flake doesn't pull down the submodules for the repository.

I'm not familiar with how Nix flakes work, so I'm not sure what the correct fix for these would be. If you have any suggestions, we'd happily welcome a PR - otherwise you might have to wait for someone who knows Nix to fix this 😅

P.S. : could you please explain what does MSRV mean

Minimum Supported Rust Version. Ours is 1.65.0, but we started using 1.70.0 features by accident, which is why you ran into that issue (Nix bundles 1.69.0 in stable)

Hello
with this command I have llama.cpp pulled down in crates/ggml/sys/llama-cpp
git submodule init
git submodule update
It can be build independently.
but I still have the same problem


ruff removes valid noqa blocks

Hello ,
I am working my way to replace yesqa with ruff . When i run ruff on a sample python code , I have a feeling it removes all the # noqa blocks , even the valid ones .

ruff version used : 0.4.3
code block
print("uuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuu")  # noqa: E501
command used : ruff check --select RUF100 test.py --fix
Output :  Found 1 error (1 fixed, 0 remaining).

Ideally there should be nothing to fix , as the line length exceeds , but ruff removes the # noqa block . Please let me know if i am not using this functionality in a intended manner

The noqa suppression here is not necessary because Ruff doesn't flag any lines that contain no whitespace, because it often indicates that there are no good split points for that line.

Ignores lines that consist of a single "word" (i.e., without any whitespace between its characters). source

I see the argument here that the line could be split after the (. I think that's something we can start doing once we have a way to cheaply get access to the parsed tokens (CC: @dhruvmanila)


Cannot change palette for new carts in config file

Steps to reproduce:
Open config file.
Change default palette, for example "PALETTE = EDG16"
save the config and create a new cart with the "new" command
The result is that the new cart still have the DB16 palette.

I think that's probably deprecated in 0.27 https://github.com/nesbox/tic.computer/wiki/palette
At least the "--pal" option in the metadata is deprecated, and that used those palettes stored in the config file, so I guess those values are not used any more?
But I could be completely wrong about this, I never tried to use the config file to change the palette.

It's a bug. Nesbox asked to open an issue for this: https://itch.io/t/96194/palette-change-from-config-file-doesnt-works-anymore

you define default palette for new carts in the config
it's a bug

fixed in .29


Argument::cetra() should supress warnings about missing parameters

Using Argument::cetra() from Prophecy allows you to bypass required parameters in assertions. This is particularly useful when saying shouldNotBeCalled as you want to catch any and all parameters.
When using cetra the Required Parameter missing warning becomes redundant. Can it be surpressed?

checked, but not looks not possible so far


Create an SVG, SHP, and JSON export function. Save files and all states.

SVG

Layers

map background ?
Voxel layer
text information

property of layer (e.g.  color, name)
query
vpl

voxel element

relative position
color
value ?

JSON

Export all the layers as a geoJSON layer collection

SHP

Create a shapefile per layer

This might have to happen with PostGIS?
Other libraries might translate the coordinates and values into SHP files
The geometry would be a point per voxel with the attributes in the DBF file

Priority
SVG > SHP > JSON

Export SHP is missing. Might have to do it on the backend


Add trackpad category

There are many more to be added under com.apple.AppleMultitouchTrackpad and NSGlobalDomain/com.apple.trackpad.*.

I don't have plans to add to this PR at the moment, but these are still good additions to consider as-is.

Thanks for the PR and your patience! Will take care of it :)

FIY I couldn't find what the ActuationStrength was doing so I removed it. I've tested out on two different Mac models.

@yannbertrand thanks for merging!
ActuationStrength toggles the Silent clicking feature, which is available on some older Macs. I originally used this on a 2015 13" MBP running Monterey, but just confirmed that it is not available on a 2020 13" M1 MBP running Monterey 12.6, nor a  2021 14" M1 MBP running Ventura.
This StackExchange question has a screenshot showing that the option is available on Monterey 12.3.1, with a note that it doesn't seem to have any effect.
This Apple support page has the following line:

On some Mac laptops, you can turn off the sound of your trackpad's click by selecting Silent clicking.

ActuationStrength toggles the Silent clicking feature, which is available on some older Macs. I originally used this on a 2015 13" MBP running Monterey, but just confirmed that it is not available on a 2020 13" M1 MBP running Monterey 12.6, nor a 2021 14" M1 MBP running Ventura.
This StackExchange question has a screenshot showing that the option is available on Monterey 12.3.1, with a note that it doesn't seem to have any effect.
This Apple support page has the following line:

Good to know, thanks!


Terraform tweaks

Fixes a misconception in the -u and -r options for setup-nexus.sh
More descriptive error for when nexus credentials can't be fetch from k8s in setup.nexus.sh
Fix repo PUT operations for existing repos in setup-nexus.sh

/backport lts/csm-1.5


Add welsh translations to confirmation page

Add welsh translations to confirmation page.

Modified template to load i18n variables.
Added translation files in the locales folder.
Modified controller to load i18n variables where appropriate.

CI: No security warnings found


Use std feature in dependencies

This PR:

Target massalabs's fork of polkadot-sdk
Enable all the default-features of the dependencies ("std")

super seeded by https://github.com/keep-starknet-strange/blockifier/pull/31


Add devcontainer configuration

This PR adds a simple devcontainer environment for easier local development.
After opening the project in Visual Studio Code and installing the Remote - Containers extension, the project can be reopened inside the container by Pressing F1 and typing in Reopen in Container. Afterwards a terminal session can be opened by selecting Terminal > New Terminal. From here, the code can be compiled using sudo ./scripts/compile.sh.

Thank you for your contribution!


Minor clean up of difftool patch

See original PR: #422

This gives me a lot less heartburn than adding a pip dependency. I do have some concern about replicating this semantic in a provider but I guess we could punt and remove it as part of a major API bump when the time comes.

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

Thanks for the review @jhoblitt, I'll take a crack at cleaning this up before the end of the day

:+1:


App/load mapbox style

app to render map via url to mapbox style doc or mapbox style doc file upload

Coverage remained the same at 97.659% when pulling 52571e1fd08eb93eecf7b51c1bfe97dc6a5c5579 on CarlyLanglois:app/load-mapbox-style into 0ea9e60d8db3ade41b6a68c9857530f087fc6476 on boundlessgeo:master.

right that is the question, I would recommend passing the json instead of the url here
Sent from my iPhone

On 25 Aug 2017, at 21:09, CarlyLanglois<EMAIL_ADDRESS>wrote:
@CarlyLanglois commented on this pull request.
In examples/upload-map/context-selector.js:

}

handleSubmit(event) {
this.setState({ error: false });
this.message = '';
try {

 fetch (this.state.value)

   .then(

     response => {

       if (response.status >= 400) {

         console.log(response)

         this.badurl = response.url

         this.message = response.status + ' (' + response.statusText + ')';

         this.setState({ error: true });

       } else {

         this.addMap({ url: this.state.value });

I'm not sure i quite understand the question here. is it why are we adding the map using the url and not the json contents? If so, I don't actually have a good answer for you, so maybe worth changing..
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub, or mute the thread.

indeed, exaxtly
Sent from my iPhone

On 25 Aug 2017, at 21:27, CarlyLanglois<EMAIL_ADDRESS>wrote:
@CarlyLanglois commented on this pull request.
In examples/upload-map/context-selector.js:

this.clearError();

this.setState({ value: event.target.value });
}

handleSubmit(event) {
this.clearError();
try {

 fetch (this.state.value)

   .then(

     response => {

       if (response.status >= 400) {

         this.setState({ badurl: response.url });

         const msg = `${response.status} (${response.statusText})`;

         this.setError(msg);

       } else {

         this.addMap({ url: this.state.value });

thanks bart! I had a question on your comment on this line but it got buried when I pushed changes.
Were you asking why not set context w/ json here instead of the url since we're already fetching its contents?
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub, or mute the thread.

ok, yeah no reason other than setContext can handle a url argument itself. I only brought the fetch in when working on error handling but I've made a change to use the json contents now

Coverage remained the same at 97.659% when pulling a1cd5557f9ef9b194516968558b250caf338630a on CarlyLanglois:app/load-mapbox-style into 0ea9e60d8db3ade41b6a68c9857530f087fc6476 on boundlessgeo:master.

@carlylanglois only thing that needs to be done is remove the import for react-dropzone, after that feel free to merge

removed Dropzone for input type=file

Coverage remained the same at 97.659% when pulling e5ee3e83bc2e8962320ef1cba12be4035d409f53 on CarlyLanglois:app/load-mapbox-style into 083ce1206ddec15bd15b6102ba68c44ff92d63d9 on boundlessgeo:master.

JIRA SDK-588

Coverage remained the same at 97.659% when pulling 43962b0fb7b5db76a3b6f4bd8a1c32a8eae7b0cc on CarlyLanglois:app/load-mapbox-style into fa58c18e0ff82804e3dac7249d10e96180a4e96c on boundlessgeo:master.


Rename Azure Monitor Exporter artifact

This PR updates the name of Azure Monitor Exporter module as per the guidance of arch board.

Need to update the ci.yml and possibly the tests.yml


fix download url

I can't say when it changed, but there is a v now in the tag names

I guessing that the the regex in the list all https://github.com/beardix/asdf-yq/blob/1ed8f87127d7593424b2b366848d7b3e513f1e85/bin/list-all#L14 also needs to be fixed, but I'm not sure how

My bad, we just need t make sure to use v4.xxx in the .tool-versions


[Pyamqp] Revert back to websocket-client

aiohttp websocket has 2 bugs when a connection is abruptly cut:

websocket send does not throw an exception -> issue -> known since 2017

websocket receive gets stuck if network is suddenly disconnected -> PR -> unmerged since July 2021

Reverting back to websocket-client in async as that is what most are using. There is another async websocket client but it doesnt support proxies.

/azp run python - eventhub - tests

API change check
APIView has identified API level changes in this PR and created following API reviews.
azure-eventhub

/azp run python - eventhub - tests

/azp run python - eventhub - tests

/azp run python - eventhub - tests

/azp run python - eventhub - tests

Due to issues with running websocket-client in async mode, we decided to stay with aiohttp for async. We were able to use heartbeat from aiohttp and timeouts to mitigate the bugs.

@kashifkhan im having the same issue, can you elaborate on what you did with aiohttp, which timeouts did you use?

@kashifkhan im having the same issue, can you elaborate on what you did with aiohttp, which timeouts did you use?

@gil-cohen I passed in heartbeat parameter in ws_connect with a value of 10 seconds. That was enough time for the library to determine that the underlying connection has been lost.
Additionally you can take a look at these 2 PRs where you can see the changes and some of the exceptions that I am now addressing
https://github.com/Azure/azure-sdk-for-python/pull/26856
https://github.com/Azure/azure-sdk-for-python/pull/27006/files


AttributeError: 'ScheduledScan' object has no attribute 'site_name_id' in utility.py

2020-03-12 09:21:40,970 [MainThread  ] [ERROR] AttributeError: 'ScheduledScan' object has no attribute 'site_name_id'
Traceback (most recent call last):
  File "/home/scantron/master/.venv/lib/python3.6/site-packages/rq/worker.py", line 884, in perform_job
    rv = job.perform()
  File "/home/scantron/master/.venv/lib/python3.6/site-packages/rq/job.py", line 664, in perform
    self._result = self._execute()
  File "/home/scantron/master/.venv/lib/python3.6/site-packages/rq/job.py", line 670, in _execute
    return self.func(*self.args, **self.kwargs)
  File "./utility.py", line 56, in process_scan_status_change
    site_id = scheduled_scan.site_name_id
AttributeError: 'ScheduledScan' object has no attribute 'site_name_id'

https://github.com/rackerlabs/scantron/pull/187


error: package kotlin.jvm.functions does not exist

After updating to latest Visual Studio 2019 for Mac and latest components, my project no longer compiles.
The autogenerated java files created for the revenuecat listener functions fail to compile with the error:
error: package kotlin.jvm.functions does not exist
in reference to the lines:
public class StoreProductPage_PurchaseFailureListener
	extends java.lang.Object
	implements
		mono.android.IGCUserPeer,
		kotlin.jvm.functions.Function2,
		kotlin.Function

After a few hours of googling and finding nothing I'm now completely stuck. I tried downgrading Xamarin.Android but that didn't help.

Finally fixed this by removing all nuget packages for kotlin and revenuecat and then reinstalling the revenuecat package.


Refactor dock server structure in grpc module

In the go formal way, all structure constructing function should
return with interface, one of reason is that they need to comply
with the inheritance conduction of unified interface. Besides,
the seperation between structure and interface will make it easier
for unit test.

Looks like nobody has comments, I will merge this PR at first and develop more test codes in this package.


Remove Junye from Qiskit Bot notifications

Summary
With Junye moving away from the docs effort (congratulations!), he's no longer a suitable contact for people whose PRs touch the documentation.

Details and comments
@HuangJunye: I'd understood from our talk that you'd want your tag removed from this.  Let me know if you want it to stay, though, and we can just close this PR.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
10 unchanged lines in 2 files lost coverage.
Overall coverage increased (+0.01%) to 86.004%

Files with Coverage Reduction
New Missed Lines
%

crates/qasm2/src/lex.rs
4
90.89%

crates/qasm2/src/parse.rs
6
97.58%

Totals

Change from base Build<PHONE_NUMBER>:
0.01%

Covered Lines:
71758

Relevant Lines:
83436

💛  - Coveralls


Add declaration object for deprecation message.

Pass the newly captured deprecation information from CastXML to the
declarations of those objects.

Codecov Report

Merging #138 (27a14ee) into develop (5f42a00) will decrease coverage by 0.30%.
The diff coverage is 93.22%.

@@             Coverage Diff             @@
##           develop     #138      +/-   ##
===========================================
- Coverage    91.68%   91.37%   -0.31%
===========================================
  Files          136      137       +1
  Lines        10613    10329     -284
===========================================
- Hits          9730     9438     -292
- Misses         883      891       +8

Flag
Coverage Δ

unittests
91.37% <93.22%> (-0.31%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pygccxml/declarations/declaration.py
97.43% <80.00%> (-1.05%)
:arrow_down:

pygccxml/parser/scanner.py
95.94% <83.33%> (-0.30%)
:arrow_down:

unittests/test_deprecation.py
95.74% <95.74%> (ø)

unittests/test_all.py
100.00% <100.00%> (ø)

pygccxml/declarations/pointer_traits.py
57.81% <0.00%> (-3.06%)
:arrow_down:

pygccxml/declarations/dependencies.py
69.14% <0.00%> (-2.42%)
:arrow_down:

pygccxml/declarations/calldef.py
87.50% <0.00%> (-2.18%)
:arrow_down:

pygccxml/declarations/algorithms_cache.py
87.80% <0.00%> (-2.15%)
:arrow_down:

pygccxml/declarations/comment.py
91.66% <0.00%> (-2.09%)
:arrow_down:

pygccxml/declarations/location.py
84.61% <0.00%> (-2.06%)
:arrow_down:

... and 30 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f42a00...27a14ee. Read the comment docs.

Codecov Report

Merging #138 (27a14ee) into develop (5f42a00) will decrease coverage by 0.30%.
The diff coverage is 93.22%.

@@             Coverage Diff             @@
##           develop     #138      +/-   ##
===========================================
- Coverage    91.68%   91.37%   -0.31%
===========================================
  Files          136      137       +1
  Lines        10613    10329     -284
===========================================
- Hits          9730     9438     -292
- Misses         883      891       +8

Flag
Coverage Δ

unittests
91.37% <93.22%> (-0.31%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pygccxml/declarations/declaration.py
97.43% <80.00%> (-1.05%)
:arrow_down:

pygccxml/parser/scanner.py
95.94% <83.33%> (-0.30%)
:arrow_down:

unittests/test_deprecation.py
95.74% <95.74%> (ø)

unittests/test_all.py
100.00% <100.00%> (ø)

pygccxml/declarations/pointer_traits.py
57.81% <0.00%> (-3.06%)
:arrow_down:

pygccxml/declarations/dependencies.py
69.14% <0.00%> (-2.42%)
:arrow_down:

pygccxml/declarations/calldef.py
87.50% <0.00%> (-2.18%)
:arrow_down:

pygccxml/declarations/algorithms_cache.py
87.80% <0.00%> (-2.15%)
:arrow_down:

pygccxml/declarations/comment.py
91.66% <0.00%> (-2.09%)
:arrow_down:

pygccxml/declarations/location.py
84.61% <0.00%> (-2.06%)
:arrow_down:

... and 30 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f42a00...27a14ee. Read the comment docs.

May resolve https://github.com/CastXML/pygccxml/issues/122

May resolve https://github.com/CastXML/pygccxml/issues/122


'make install' error

There was an error an the Makefile that caused an error if executing 'make install'.
Fixed now.

looks good


getItem async

add promise return type for native plugins like capacitor with storage plugin
https://capacitorjs.com/docs/apis/storage#get
storage: {
      async getItem(key) {
         const { value } = await storage.get(key)
         return value
      }
}

Asynchronous storage is supported in v0.1.4.


Update Project

Write the controller function to update project details.
Restrictions: Only the owner is allowed to update project details.
Request Structure is present here

Make sure to pull before starting your work.
For any doubts or difficulty, you can ping me on discord, I'll try to help you out as soon as possible.
All the Best!!

Claim
On Sat, 31 Dec 2022 at 12:56 PM, Anurag Jain @.***>
wrote:

Write the controller function to update project details.
Restrictions: Only the owner is allowed to update project details.
Request Structure is present here
https://github.com/opencodeiiita/SaveMyForm-Backend/blob/main/API_Endpoints.md#updateid
Make sure to pull before starting your work.
For any doubts or difficulty, you can ping me on discord, I'll try to help
you out as soon as possible.
All the Best!!
—
Reply to this email directly, view it on GitHub
https://github.com/opencodeiiita/SaveMyForm-Backend/issues/77, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ASEWEPQSKAINTECSBLEOA2TWP7N35ANCNFSM6AAAAAATNNDFIA
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

cakjwenfa

Assigned to @Im-Madhur-Gupta

@Im-Madhur-Gupta updates?

@BuddyLongLegs I have raised a PR, lmk if changes are required.


MNT: CIs

This PR fixes the issue with the CIs about unsupported protocol and adds job scheduling (triggering everyday at 4:00 AM).

It's ready to go from my end @agramfort

thx @GuillaumeFavelier


[macOS] tests are broken on Sonoma

Log of Meson test suite run on 2023-10-22T23:49:41.776019

Inherited environment: DEVELOPER_DIR=/Library/Developer/CommandLineTools TMPDIR=/opt/local/var/macports/build/_opt_svacchanda_SonomaPorts_devel_boxfort/boxfort/work/.tmp LIBRARY_PATH=/opt/local/lib SDKROOT=/Library/Developer/CommandLineTools/SDKs/MacOSX14.sdk NO_PROXY='*.local,169.254/16' USER=root CCACHE_DIR=/opt/local/var/macports/build/.ccache CPATH=/opt/local/include COLUMNS=80 PATH=/opt/local/bin:/opt/local/sbin:/bin:/sbin:/usr/bin:/usr/sbin _=/opt/local/bin/meson CC_PRINT_OPTIONS=YES PWD=/opt/local/var/macports/build/_opt_svacchanda_SonomaPorts_devel_boxfort/boxfort/work/build LANG=en_US.UTF-8 CC_PRINT_OPTIONS_FILE=/opt/local/var/macports/build/_opt_svacchanda_SonomaPorts_devel_boxfort/boxfort/work/.CC_PRINT_OPTIONS LINES=24 HOME=/opt/local/var/macports/build/_opt_svacchanda_SonomaPorts_devel_boxfort/boxfort/work/.home SHLVL=2 MACOSX_DEPLOYMENT_TARGET=14.0 DISPLAY=/private/tmp/com.apple.launchd.EEZzEtiyvC/org.macports:0 __CF_USER_TEXT_ENCODING=0x1F6:0:0

==================================== 1/4 =====================================
test:         nested.c
start time:   15:49:41
duration:     0.24s
result:       killed by signal 6 SIGABRT
command:      MALLOC_PERTURB_=156 /opt/local/var/macports/build/_opt_svacchanda_SonomaPorts_devel_boxfort/boxfort/work/build/sample/nested.c.bin
==============================================================================

==================================== 2/4 =====================================
test:         callback.c
start time:   15:49:41
duration:     0.44s
result:       killed by signal 6 SIGABRT
command:      MALLOC_PERTURB_=239 /opt/local/var/macports/build/_opt_svacchanda_SonomaPorts_devel_boxfort/boxfort/work/build/sample/callback.c.bin
==============================================================================

==================================== 3/4 =====================================
test:         context.c
start time:   15:49:41
duration:     0.86s
result:       exit status 0
command:      MALLOC_PERTURB_=53 /opt/local/var/macports/build/_opt_svacchanda_SonomaPorts_devel_boxfort/boxfort/work/build/sample/context.c.bin
----------------------------------- stdout -----------------------------------
my_int = 42
my_long = 24
==============================================================================

==================================== 4/4 =====================================
test:         timeout.c
start time:   15:49:41
duration:     2.66s
result:       exit status 0
command:      MALLOC_PERTURB_=37 /opt/local/var/macports/build/_opt_svacchanda_SonomaPorts_devel_boxfort/boxfort/work/build/sample/timeout.c.bin
----------------------------------- stdout -----------------------------------
Wait timed out after 1 second
Process killed after 2.0 seconds
==============================================================================

Summary of Failures:

1/4 nested.c   FAIL            0.24s   killed by signal 6 SIGABRT
2/4 callback.c FAIL            0.44s   killed by signal 6 SIGABRT

Ok:                 2
Expected Fail:      0
Fail:               2
Unexpected Pass:    0
Skipped:            0
Timeout:            0

This is related to https://github.com/Snaipe/Criterion/issues/484#issuecomment-1528856215

I've found a way to make bxfi_exe_patch_main() work again on arm64 macOS.
I'll open a PR soon.


fix(persistQueryClient): rename isHydrating to isRestoring

:tada: This PR is included in version 4.0.0-beta.5 :tada:
The release is available on:

npm package (@beta dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


304 Not Modified

the issue  #846 ,the last comment: "Can't understand where in this sample cached image is sent to completion block. As I see just cancelBlock is called in cancelInternal. Please can you assist. Does this code work as expected?",I can't understand either。

We should keep the conversation on the original thread. I replied there.


variable in @import statement

The lastest version introduced the possibility to "access the value of an abstract property from a string using { } operators" (section "String interpolation" in http://lesscss.org/#-string-interpolation).
But the problem is that it doesn't work in import statements. It would be great to write code such like this :
//define the template
@mainTemplate: "BaseTheme";
//import the template
@import<EMAIL_ADDRESS>I don't know if it is possible to resolve this issue, but it would be great !

+1 @darkoba. Needed feature

Just changed my username from darkoba to arnaudgaudin due to professionnal reasons ;-)...

I implemented this feature - in the near future (probably Monday) I make pull request

see https://github.com/cloudhead/less.js/pull/426

Is this happening or not happening? It would be really useful.

my use case for selectors was just added 3 days ago in 93b23d2

:+1: for  @import<EMAIL_ADDRESS>

@joeSaad Just in case, you do realize this feature is implemented quite a while ago, do you?

Having the same issue using Less with Angular 8. Any updates?
"less": "3.9.0",
"less-loader": "5.0.0"

I tried updating to latest, didn't work.
The console outputs the following:
./src/styles.less (./node_modules/@angular-devkit/build-angular/src/angular-cli-files/plugins/raw-css-loader.js!./node_modules/postcss-loader/src??embedded!./node_modules/less-loader/dist/cjs.js??ref--16-3!./src/styles.less)
Module build failed (from ./node_modules/less-loader/dist/cjs.js):

@import<EMAIL_ADDRESS>^
Maximum call stack size exceeded
      in C:\localpath\styles.less (line 709, column 0)

Having the same issue using Less with Angular 8. Any updates?
"less": "3.9.0",
"less-loader": "5.0.0"

I tried updating to latest, didn't work.
The console outputs the following:
./src/styles.less (./node_modules/@angular-devkit/build-angular/src/angular-cli-files/plugins/raw-css-loader.js!./node_modules/postcss-loader/src??embedded!./node_modules/less-loader/dist/cjs.js??ref--16-3!./src/styles.less)
Module build failed (from ./node_modules/less-loader/dist/cjs.js):

@import<EMAIL_ADDRESS>^
Maximum call stack size exceeded
      in C:\localpath\styles.less (line 709, column 0)

same issue in
"less": "3.11.1",
"less-loader": "4.1.0"

@SheldonLaw Causing a loop (Maximum call stack exceeded) is a bug. You should file as a new issue.


Custom migrations source (for bundling)

I would like to be able to run rake-db migrations in production. In production, I don't distribute Typescript sources, I use 2-phase dockerfiles and the running container only has bundles compiled with esbuild/rollup.
However, the only way rake-db discovers migrations is readdir:
https://github.com/romeerez/orchid-orm/blob/4c436cf35d6a0cdd7baf6abfd85bdc179aa959fb/packages/rake-db/src/common.ts#L315-L323
I would appreciate if there was a way to provide the set of migrations programmatically, similar to how Knex does that: https://knexjs.org/guide/migrations.html#custom-migration-sources
Basically, if the above code could call a custom callback instead of always doing await readdir(migrationsPath) that would probably suffice (then the results could be imported with the custom import callback).

Makes sense, rake-db should be capable of running compiled js files, which is not currently supported.
But why provide anything programmatically?
If rake-db will use readdir to find out compiled migrations and run them, would you need something else?

Because I bundle sources.
For each executable script that is needed in production (a server or a cli script) this generates exactly one file such as dist/dbScript.js which combines all project files (and sometimes all node_module sources, too, although at the moment I'm not doing that).
The sources are coming from a mono-repo with dozens of packages, and each micro-service only needs a subset of them, so bundling is very practical to minimize footprint. This also allows simpler serverless deploy, and reduces startup times.

Understood, but still, it's unclear how passing an array of migrations is going to help.
If we imagine that rake-db has exactly the same MigrationSource interface:
class MyMigrationSource {
  getMigrations() {
    // resolves array of migration file names
    return Promise.resolve(['migration1'])
  }

  getMigrationName(migration) {
    // get the version from a file name
    return migration;
  }

  getMigration(migration) {
    switch(migration) {
      case 'migration1':
        // get functions to migrate up or down by a migration name
        return {
          up(knex)   { /* ... */ },
          down(knex) { /* ... */ },
        }
    }
  }
}

Would this be enough? Is this similar to how you did this with Knex?
I'm hoping to find a user-friendly way for this.
Thinking, what if readdir will be used in esbuild config to compile all migration files separately, and rake-db will work with js files. It could be wrapped into a plugin for esbuild.
Or, rake-db could have array of lazy imports of migration files, and the db new command will also automatically insert a new migration path to this array.

Sure, that would be flexible enough to accommodate to any needs. Perhaps too detailed for this particular use case, as I didn't want to fiddle with migration names — the current logic of parsing filenames suits just fine.
This is how I could load migrations so that it works in both dev environment and in the bundle:
const migrations = import.meta.glob('./migrations/*.ts')

This returns an object shaped like:
{
  './migrations/20230811075433_init.ts': [Function: ./migrations/20230811075433_init.ts]
}

...where the function, when called, returns a promise that imports the respective module.
So basically what would be enough for my case is:
const migrations = import.meta.glob('./migrations/*.ts')

export const change = rakeDb(
  { databaseURL: db_url },
  {
    baseTable: BaseTable,
    migrationsSource: Object.keys(migrations),
    import: path => migrations[path],
  },
)

Actually, I don't anticipate any other combination of migrations and import, so perhaps rakeDb could simply accept an object of { [migrationName: string]: () => Promise<Module> }:
export const change = rakeDb(
  { databaseURL },
  {
    baseTable: BaseTable,
    migrations: import.meta.glob('./migrations/*.ts'),
  },
)

Ready! See notes and example here.
You need to add migrations just as you suggested, thanks for letting me know about import.meta.glob:
migrations: import.meta.glob('./migrations/*.ts'),

migrationsPath option is still used to generate new migrations into.

Thanks! I'll try to integrate this in a couple days.


Update .pre-commit-config.yaml

Codecov Report
Patch has no changes to coverable lines.
:loudspeaker: Thoughts on this report? Let us know!.


touch for carousel does not work onload

I have issue with Carousel for version 4.3.1.
Swipe on Carousel does not work on mobile on load (with "data-touch" is set to true) unless we click the next button first. I have tested this with a touch supported laptop (using chrome) as well and its not a device issue.
Looking at the bootstrap code for carousel, It seems that the event handlers are not properly bound at the time of construction of carousel class. Clicking the navigation elements fixes and sets the event binding correctly. A proof of this is when the carousel is loaded there is no "pointer-event" css class on the main element and is only added once you click the "next" navigation link.

Patches welcome. Also please don't skip filling the issue template.

Hi ! @SnippetsUnlimited
Can't I work around this problem by doing the following?
<div id="myCarousel" class="carousel slide" data-interval="false" data-touch="true" data-ride="carousel">
The key points aredata-interval="false" stops autoplay. And  adddata-ride="carousel".
It seems to be contradictory, but without data-ride="carousel", no instance will be created and no event handlers will be set.
You might want to take a look here.
https://github.com/twbs/bootstrap/blob/v4.3.1/js/src/carousel.js#L585
Hi @XhmikosR
The bootstrap is very cool.
I use it a lot. Thank you.
I thought I'd try to solve this problem.
Because I didn't know how to fix it.
I'd love some advice.

/CC @Johann-S

Hi,
Yes if you want the touch events to be set on load you have to use data-ride as @gnoot said 👍


Fix wave example link in README

The link to the wave example was opening the hue example. This fixes the link!
(also some other line-ending changes added automatically by Github)

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Routing priority does not working in Next.js v14

What version of Hono are you using?
4.6.3
What runtime/platform is your app running on?
Node.js v20.16.00
What steps can reproduce the bug?
router.get(
  "/report-period",
  async (c) => {
    const query = c.req.query();

    const result = await service.reportPeriod(
      query
    );
    return c.json(result.toObj(), result.statusCode);
  },
);

router.get("/:id", async (c) => {
  const id = c.req.param("id");

  const result = await service.findById(id);
  return c.json(result.toObj(), result.statusCode);
});

When I make a request to the route "/request-period" it ends up hitting the route with the pattern "/:id"
What is the expected behavior?
The route "/request-period" should be prioritized
What do you see instead?
The route "/:id" is prioritized
Additional information
I'm using Next.js v14 and already deleted the .next folder multiple times.

When I renamed from "/request-period" to "/period" it works well


Add crossref generator

This PR adds the CrossRef generator, based off the schema for CrossRef XML deposits.
This generator creates only the JavaScript object that fits the schema. This will still need to be converted to XML using a module like xml-js before submitting to CrossRef.
⚠ This is a work in progress ⚠
Todo

[x] Figure out what type to use for depositing research module (meeting with CrossRef on Thursday 30 sep about this)
[x] Generate body function
[x] Test upload.

After meeting with CrossRef on what type - it seems like book chapters are the best fitting our discoverability needs and metadata needs. Updating approach now...

Finally in a good state!
Four automated deposits in a row went perfectly good!

Most important to note is that the environment variable for the login requires the role to be included, email/role which I stumbled over.


Widget: EURO DEMO Front to side accidents by severity on road 25

Name
front_ to_side_ accidents_by_severity
Title
front to side accidents take a major part in more severe accidents
Visualization

Visualization explanation
accidents on road X, presented by accident severity, front to side accident type tend to be a severe one.
Use case
front to side accident on road X
when the percentage of front to side accidents in the given location and time frame is greater than 1.1 times the percentage of the front to side accidents in all of the roads
SQL query
query on redash
modified parameters:
road_segment_id
Additional context

@ChayneAzriel looks great! It's a very good insight! Wonderful work!
A few questions - regarding the redash query:

Regarding the Redash query - why is "road_object" there?

Why are you using involved_markers_hebrew and not markers_hebrew?
Seems like the severe accidents numbers in query result do not match the graph's data - why is that?
Why did you add one_lane is not null?

Also - @galraij created a cool visualization - perhaps it's better to add only fatal and severe accidents (it's better to use the word severe and not harsh)

I think it's just left over from when I was playing with the data..
that's what I usually do, I reduce to the amount of accidents from the amount of  involves with distinct
3.the graph was created by python, there are little differences between the redash results and the python ones
at first I thought this road had parts that are defined as one lane, and it was part of trying to get the most accurate data.. but it's not true and I think we can ignore it

I fixed the query according to your comments, there's a little change in the numbers. thank you..
great visualization! I do think that showing the minor accidents gives the full picture, and emphasize the major part that front to side accidents type take in severe and fatal accidents. if we are trying to attract the eye to the fatal and severe, maybe we can play with the colors (make the minor with same colors but more pastel)

@ChayneAzriel Thanks!

great!
Instead, I suggest using the markers table or the markers_hebrew table
You can use the field accident_severity_hebrew for the translation instead of translating in the query itself.
However, we do prefer filtering by the code (accident_type = 2) - since the BackEnd team will implement it using the code.
You can also attach a Python code instead of the query.
Regarding minor (light) accidents - we prefer to focus on severe and fatal accidents - since light accidents can add a lot of noise.
Regarding the visualization -

I wrote a shorter query - the shorter the query / the python code - it will be easier for the backend developers to understand and implement - what do you think on this one?

Hi
I try to create a comprehensive over view:
widget name: front_ to_side_ accidents_by_severity
visualization

Update link to redash query
I think calculation of % need to happened on BE side and be a part of the json. That is to make FE implementation easer
Information text:
תאונות קטלניות וקשות מסוג חזית-צד בהשוואה לסוגי תאונות אחרות באותו מקטע דרך
if any other aspects are missing, please let me know

@MichalOren Are the query need to be time limit (e.g. 5 years back)?

Hi @BarVolunteering

Usually we use 1, 3, 5 & 8 years, as time periods for our widgets. Do we need to change the query to support all ranges?
You're right.  "all_roads_accidents" tag, looks unnecessary.
TNX for your inputs

Changes will be done as part of PR:
https://github.com/hasadna/anyway/pull/2279

Hi @BarVolunteering
In order to clarify, I am adding the summary of the discussion with Bar and Daniel:
First, the Backend always transfers basic values, when the infographic needs to display a value in percentages %, it will happen in the Frontend.
Secondly, regarding the structure of the JSON, when there is no data regarding fatal or serious accidents, the JSON will only contain existing information. The same goes for the display, even partial information is displayed.

@MichalOren This is ready in PR:
https://github.com/hasadna/anyway/pull/2292

Done


"Metroidvania" patch

@lrgilbert Hi again! Made some changes in my fork, if you like you could check them and if you like this I can maybe make these changes optional based on the ldtk map type you are using (Gridvania for this and in other cases use the old import system).


Strip HTML tags when computing reading time

In _layouts/post.html:
- {% assign minutes = content | number_of_words | divided_by: 180 %}
+ {% assign minutes = content | strip_html | number_of_words | divided_by: 180 %}

This way HTML formatting, URLs in anchors and all won't affect reading time.
(Sorry for not making a PR, I'm on my iPad rn)

Closed via #201.


ChroniquesGalactiques Version 4.4.1 (BUGFIX)

Submission Checklist
Required

[x] The pull request title clearly contains the name of the sheet I am editing.
[x] The pull request title clearly states the type of change I am submitting (New Sheet/New Feature/Bugfix/etc.).
[x] The pull request makes changes to files in only one sub-folder.
[x] The pull request does not contain changes to any json files in the translations folder (translation.json is permitted)

New Sheet Details

The name of this game is: <   >  (i.e. Dungeons & Dragons 5th Edition, The Dresden Files RPG)

The publisher of this game is: <   > (i.e. Wizards of the Coast, Evil Hat)

The name of this game system/family is: <   > (i.e. Dungeons & Dragons, FATE)

[ ] I have followed the Character Sheets Standards when building this sheet.

[ ] This sheet has been made on behalf of, or by, the game's publisher.
[ ] This game is not a traditionally published game, but a copy of the game rules can be purchased/downloaded/found at: <   >
[ ] This sheet is for an unofficial fan game, modification to an existing game, or a homebrew system.

Changes / Description
Added a missing */ at the end of the sheetworker code
As a result, the Roll20 engine did not find the closing  element and was not executing any of the sheet-worker code
Please pull this fix to the sheets library as soon as possible

Character Sheet Info Roll20 Internal Use only.


Inline Editing for Grid Cells

Does this grid have support for inline cell editing, or are their plans to include this as a feature of the angular2-grid?

This isn't a data table system, its a drag/drop/resize grid system. You can put anything you like inside the grid items. There's no cells to be edited explicitly...

ok thanks!


iPhone onboarding screen that asks "Do you buy art?"—hard to differentiate question from options

The "Do you buy art?" text initially looks like it's another selectable option on the screen (just like "Yes, I buy art" &c). Maybe should be bolded/given more bottom margin from the text?

add 50px of space


The sounds of alerts drowning out the stream.

Hi! My viewers are always complaining that the alerts (donations, new followers) are much louder than the stream sound. I've already tried turning down the sound in StreamElements to 10% but it doesn't help, the sound of alerts is still loud. Is there any solution to this problem?

Hello! All sounds from moblin are played through a speaker and picked up by the mic. So turning down the speaker volume should work.

Yes, it helps, but then I can't hear the voiced donuts. I thought I could solve this problem by plugging in AirPods, but it only works if I use the headphone microphone. Can I choose to have the outgoing sound go to the AirPods but use the microphone built into the phone?

It helped.
I really like your app! Thank you for your work.

Cool. Happy you like the app =)


[Snyk] Security upgrade jspdf from 1.5.3 to 2.3.1

Snyk has created this PR to fix one or more vulnerable packages in the `npm` dependencies of this project.

Changes included in this PR

Changes to the following files to upgrade the vulnerable dependencies to a fixed version:

package.json
package-lock.json

Vulnerabilities that will be fixed
With an upgrade:

Severity
Priority Score (*)
Issue
Breaking Change
Exploit Maturity

688/1000  Why? Proof of Concept exploit, Recently disclosed, Has a fix available, CVSS 5.9
Regular Expression Denial of Service (ReDoS) SNYK-JS-JSPDF-1073626
Yes
Proof of Concept

(*) Note that the real score may have changed since the PR was raised.

Commit messages

Package name: jspdf
    The new version differs by 250 commits.

9b8f1e9 2.3.1
20f271a Docs: improve output documentation (#3099)
d8bb3b3 fix ReDoS-vulnerable regexp in addImage (#3091)
c91995d Fix: Wrong TypeScript type in jsPDF.table (#3086) (#3087)
3592fc2 fix: scope is not defined in getTextDimensions (#3078)
ef70f92 fix(FileSaver): HTMLAnchorElement is not defined (#3073)
63f89d4 update package-lock.json (#3065)
53ca33b 2.3.0
102f370 Merge pull request #3062 from HackbrettXXX/fix-text-encoding-flags
b686db7 fix text encoding flags
edab14a Added typings for internal events API (#3014)
6579099 Resolve fonts using CSS Level 3 algorithm when using html() (#3040)
75e6ed7 Replace zlib.js and pako with fflate (#3054)
ec7e835 Merge pull request #3047 from HackbrettXXX/fix-instable-encryption-tests
6e9ce29 fix 'jsPDF is not defined" exceptions in fontWeight tests
07a3569 fix instable encryption tests
7403adb Add fonts with different font-weights  (#3036)
451e131 fix textWithLink alignment (#3026)
c0f6c54 Fix table header alignment (#3032)
e834724 add a PR template that links to the contribution guidelines (#3035)
f2c578f 2.2.0
fb76604 fix escaping of font names (#3018)
a2a4474 replace exported enum types by string unions (#3021)
1f23740 Replace Deflater with pako (#2944)

See the full diff

Check the changes in this PR to ensure they won't cause issues with your project.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
🛠 Adjust project settings
📚 Read more about Snyk's upgrade and patch logic

Hi @londonprojects
It looks like the jspdf component is used in the Admin portal also, in 1 place only:


More RCF validation for Set Cookie header

I added some more validation to the set cookie header functionality. It's mostly just forced object types and reconstruction. I still need to add a subdomain check against the allowedOrigin. Also I just thought I should do another pull request at this point because I realized last night that I inverted the logic in the cookie.value regexp. Notice the new hat :)
I know it might be a bit bulky but I figured you could take or leave whatever.

Last night I merged your original pull request, edited it to match the existing coding style, and fixed the inverted logic in the regexp you mentioned.  Subsequently, this pull request cannot be cleanly merged.  :(

Oh. Sorry I didn't realize how fast things seem to happen in github. This was my first attempt at a contribution. I should have checked the upstream before I put in this request. I'll pull it down and make the changes there and try to match your style a little better.

No need to apologize!  I appreciate your help and contributions!

Ok, so I hope I did this right. I pulled down your changes and finished up most of the RFC validation. I got a little stuck on the sub domain validation. I'm not sure what the best approach is for handling TLD checks.  Also I think the check might need to be done against the host as well. I ran some tests in Chrome and it rejects cookies for domain=foo.domain.com if the ws connection (host) is to domain.com even if the origin is foo.domain.com. This makes sense but I don't know if we should check against that or let the user agent handle it. It just gets a little confusing when the server and client are not on the same domain. Maybe I'm over thinking it.

Looks good.  I'm going to merge it and make a couple minor edits.  I think the domain validation is probably a bit overkill.  The browsers can be relied upon to validate when cross-domain cookies can be set.  Also, if we do validate the cookie domain, it should be validated against the Host header, rather than the Origin header.  I'll probably just make it do a barebones validation against illegal characters for the cookie domain instead.
Otherwise, this looks great!


Add checkstyle RedundantModifier check and fix offending classes

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

[ ] Make sure the PR title is formatted like:
[BEAM-<Jira issue #>] Description of pull request
[ ] Make sure tests pass via mvn clean verify. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
[ ] Replace <Jira issue #> in the title with the actual Jira issue
number, if there is one.
[ ] If this contribution is large, please file an Apache
Individual Contributor License Agreement.

R: @dhalperi

Thank you! It actually fixed essentially only redundant interfaces (and their subclasses) which is why I got very confused in review :).

Looks like you missed all the tests.

https://builds.apache.org/job/beam_PreCommit_MavenVerify/4178/console

Accidentally included extra CTOR_DEF rule in previous commit. Reverted.

Thanks! Merged.

(after manually inspecting travis and being sad)

@swegner Please backport to Dataflow, so that future backporting is not insane.


Fix scroll to top button

Description
Scroll to top button is not visible clearly in dark mode, it can be fixed to be visible in dark mode
Screenshots
No response
Additional information
No response

i want to contribute

I am interested to fix this issue , I am participating under JWOC. Can you assign me this issue?

i want to contribute

you can work on this!

I am interested to fix this issue , I am participating under JWOC. Can you assign me this issue?

arjun claimed the issue earlier, you can claim in case he's unable to solve the issue


Upload El Ry

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

[x] Filename in the lowercase format
[x] Image format: png
[x] Image size: 256 by 256 px

I added just one here https://github.com/TrustWallet/tokens/commit/5e4f5cb085bf27b23884ad8e90e696e2a4d0d793, cause other already exist


When using --override it's not possible to remove galleryFlags

When using --override it's not possible to remove the public flag or remove the preview flag.
Right now I solve this by not having a galleryflags in my manifests in sourcecontrol and handling the setting of these flags during publishing. It would be nice if it were possible to blanket-overwrite the galleryFlags json array.
I assume this may cause issues when trying to override other array items. Though I wonder is people ever use the override option in such a way.

Using jsonpath object transform would make the override a lot more powerful: https://www.npmjs.com/package/jsonpath-object-transform


MAVLink latency optimizations

Mavlink streams reordering to improve latency to the companion. In particular this reduces timesync round-trip time spikes by more than 10ms, and makes it generally more stable in my test setup.
@mhkabir You're probably interested in this.
@jkflying @mhkabir anything you'd like to see different in terms of stream priorities?

This looks great!
I also care greatly about latency on the UART because of offboard estimation and controls, and have been flying a commit which runs mavlink rx/tx with a high priority and keeps the loop interval fixed to 1kHz. This also helps with the latency, at the cost of some CPU load. Happy to upstream if considered to be of wider relevance (likely we'd want it enabled in EXTVISION and ONBOARD modes).
And a question - have you been able to run the UART at 3Mbit without issues? Is it a native UART on the companion side, or some kind of USB-UART chip?

I also care greatly about latency on the UART because of offboard estimation and controls, and have been flying a commit which runs mavlink rx/tx with a high priority and keeps the loop interval fixed to 1kHz. This also helps with the latency, at the cost of some CPU load. Happy to upstream if considered to be of wider relevance (likely we'd want it enabled in EXTVISION and ONBOARD modes).

I'd be curious to see if you still need it with this change, and how much of a difference it makes.

And a question - have you been able to run the UART at 3Mbit without issues? Is it a native UART on the companion side, or some kind of USB-UART chip?

Yes it's on Auterion's Skynode (imx8). There we have the full HW under control and you can really go to the limit of 3MBit baud.


Add Navigation does not work in v0.11.4

Hi
I upgraded from v0.11.3 to v0.11.4 ghost. Adding a navigation URL in the Settings/Navigation tab no longer works in the new version. I checked the Network tab, actually no call is made. There are no errors in the console. However, there are a few warnings:

Environment:

node - v6.9.5
npm - v3.10.10
nvm - v0.33.0

Is this a known issue? Or is there something wrong in my environment? Please advise.
Thanks
Vivek Ragunathan

@VivekRagunathan I just tried this on my production blog running 0.11.4, and was not able to reproduce 😕
Did you remember to click the "Save" button at the top of the page? The navigation will only save if you click it 😉
At any rate, if you could provide more information other than "it doesn't work" such as a more explicit description of what you entered, where you clicked, etc., that would help us get to the bottom of this issue if it in fact exists.

@acburdine Yes, I clicked on the Save button and that's when I mentioned that there was no network call record in the Network tab. I tried adding a link to one of the posts (also pages) in my blog.
I am preparing to record a licecap video to show the problem. Get back with the video soon.

@VivekRagunathan Do you have any update on this? Thanks 👋

@kirrg001 Very sorry about the delay. Too bad I forgot to update you. Actually, I had to blow up my server (moving servers), so I did not get a chance to reproduce (0.11.3 - 0.11.4).
But I will be upgrading 0.11.5 soon. Will share with you what happens.

@VivekRagunathan Thanks the update 👋
I will close this issue for now. If you experience this behaviour again, just let us know here.


chore(main): release cli 1.4.2

:robot: I have created a release beep boop
1.4.2 (2024-06-20)
Bug Fixes

small CSS fixes (b0be8d3), closes #57

This PR was generated with Release Please. See documentation.

:robot: Created releases:

<EMAIL_ADDRESS>:sunflower:


append async function error catch

Solve the problem that asynchronous functions can't intercept errors.

Duplicate of https://github.com/pillarjs/router/pull/69


[ot_certs] asn1 library unittest

Add a unitest for the asn1 library.

I have rebased the PR since the last CI run was a month old, no other changes.


Preload from createWebViewWith

Nice work!
Any suggestions on how to preload when creating a Web view dynamically, e.g. in response to window.open()? I'm loading third-party content, so I don't know if/when the content wants to open another page.
public func webView(_ webView: WKWebView, createWebViewWith configuration: WKWebViewConfiguration,
                    for navigationAction: WKNavigationAction, windowFeatures: WKWindowFeatures) -> WKWebView? {

    // Added an initializer to accept an existing configuration
    let newWebView = WKCookieWebView(configuration: configuration)

    if let url = navigationAction.request.url {
        // Doesn't work, probably because we have to return the WebView synchronously,
        // before we have a chance to preload. Loading later doesn't work.
        WKCookieWebView.preloadWithDomainForCookieSync(urlString: url.absoluteString) {
            newWebView.load(navigationAction.request)
        }
    }

    // Add webview to tab list
    myDelegate?.didOpenNewWebView(for: url)

    return newWebView
}

Hi,
I think the idea you suggested was a good idea.
I'll try to figure out a way to apply it.
Or you can do the PR yourself. ^^


Compiler cannot read source code from pipe or character device

Say you want to pass source code into the compiler via a named pipe: crystal build <(echo 'puts "Hello World"'). This creates a pipe and passes that as CLI argument. The compiler errors with: file '/proc/self/fd/11' does not exist. Which isn't entirely correct. It's not a file, but the path certainly exists and it's readable, no problem.
Same error happens with a character device (crystal build /dev/null).
The reason is that the compiler validates filename arguments with File.file?. This is unnecessarily limiting.
https://github.com/crystal-lang/crystal/blob/6b9ad16c98f0289a90a6cc74493a83898050af6f/src/compiler/crystal/command.cr#L617-L619
I think this restriction should be removed or maybe turned into something that checks directory? and maybe readable?. But actually, prior validation seems quite unnecessary. I think it's fine to try reading from the file. If that does not work, it will produce an error. We just need to handle that properly. Avoiding an exception for performance reasons is not a reasonable motivation here.

With #13852 read errors should provide a meaningful error message which should provide a good user experience when this condition is completely removed.


Bid on chain name causes an error in console

Describe the bug
Bid on chain name causes an error in console: TypeError: t.endsWith is not a function
To Reproduce
Steps to reproduce the behavior:

Go to Auction page
Choose a name
Make a bid
See error

Expected behavior
Should act without errors in console.
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

OS: MacOS
Browser: FF
Version: 119

Additional context
Reproducible on the development branch.

Fixed, LGTM


Cant run example with latest nightly & cargo-web

Description
I'm submitting a bug report-
It's actually the same like https://github.com/koute/cargo-web/issues/108 but I don't know where to look for the cause.
Expected Results
cd examples/dashboard && cargo web start --target wasm32-unknown-unknown should work ;-)
Actual Results
see https://github.com/koute/cargo-web/issues/108
Context (Environment)

Rust:1.28.0-nightly (4ecf12bf0 2018-06-02)
yew: v0.4.0 and a6c77bcef465be6b4c52d8634e34cab9308b23d8
target: wasm32-unknown-unknown
cargo-web: v0.6.12

Fixed


Close Master and configure merge bot

Should we make master branch read-only and configure a merge bot that automatically runs CI and only then perform PR merge? (i.e. bors) @Dmitry404 what do you think?

I see not much sense in it. Same about read-only master. Perhaps to set a non-master branch as default would be good enough.

Closing as an unnecessary complication to the build process


Garage started incorrectly stating the open/close state after recent apt updates

What's Wrong
Immediately after registering as open, the garage registers as closed again. This happens even as the garage is still open.
Note the timestamps in the data listed. This started happened after a recent update of system packages, but unfortunately I can't nail down a specific timeline. This setup has been otherwise working flawlessly for over a year, or since the last release update.
2022-05-12 14:52:17 | SensorTrip | Door state changed to CLOSED.
2022-05-12 14:52:16 | SensorTrip | Door state changed to OPEN.
2022-05-12 10:54:48 | SensorTrip | Door state changed to CLOSED.
2022-05-12 10:54:47 | SensorTrip | Door state changed to OPEN.
2022-05-12 10:53:03 | SensorTrip | Door state changed to CLOSED.
2022-05-12 10:53:02 | SensorTrip | Door state changed to OPEN.
2022-05-11 17:05:39 | SensorTrip | Door state changed to CLOSED.
2022-05-11 17:05:38 | SensorTrip | Door state changed to OPEN.
Environment Info
RPi Model:
raspberry pi zero w
OS Release:
Raspbian GNU/Linux 10 (buster)
Service Status:
N/A
Attach Logs
The only notable log.
2022-05-10 19:21:25,414 [359  :0xb6f20900] CONTROL ERROR Exception while running controller [in app @ /home/pi/GaragePi/backend/app.py:113]
Traceback (most recent call last):
File "/home/pi/GaragePi/backend/app.py", line 111, in main
GaragePiController(config['IPC_PORT']).start()
File "/home/pi/GaragePi/backend/controller.py", line 50, in start
msg = socket.recv_multipart()
File "/home/pi/GaragePi/venv/lib/python3.7/site-packages/zmq/sugar/socket.py", line 566, in recv_multipart
parts = [self.recv(flags, copy=copy, track=track)]
File "zmq/backend/cython/socket.pyx", line 783, in zmq.backend.cython.socket.Socket.recv
File "zmq/backend/cython/socket.pyx", line 819, in zmq.backend.cython.socket.Socket.recv
File "zmq/backend/cython/socket.pyx", line 186, in zmq.backend.cython.socket._recv_copy
File "zmq/backend/cython/checkrc.pxd", line 13, in zmq.backend.cython.checkrc._check_rc
File "/home/pi/GaragePi/backend/app.py", line 99, in sigterm_handler
sys.exit(0)
SystemExit: 0

Replaced pi, reflashed os, soldered new cable, and none of that worked.
Replaced the magnetic switch and resolved the issue.


Kanban board setup

Ruby on Rails group project

Link to the kanban board
In this project there are only 2 members.

Invalid ❌
Hi Team,
While you made a great effort in this project, unfortunately, I cannot proceed to review your code.
Your Code Review Request is marked as invalid for this reason:

[ ] You provided a broken link to your project Kanban cards. Please fix that.

Your Code Review Request will be marked as invalid in your Dashboard, so please submit a new one once you are ready 🙏
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

Invalid Code Review Request Does not count into the code reviews limit.

Thank you for your review, the issue has been fixed and the link should be working now.

Hi @tomasesquivelgc, and @ivangonzalez224 ✋
Good job so far!
Hello ✋, you have done well reaching this point of the milestone 🤝 . But there are some issues that you still need to work on to go to the next project but you are almost there!
Status: Required Changes ♻⛔

As stated in the project requirements, each requirement is supposed to be represented on your Kanban board. Kindly add a card for this requirement.

Check the comments under the review.
Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend considering them as they can improve your code.
Cheers, and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread and tag me @1GORDON if something is not 100% clear.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think the code review was unfair, request a second opinion using this form.

Changes
The n+1 problem issue has been added to the project

Hi :raising_hand: :raising_hand: @Team,
Your project is complete!  There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉 🎉
:tada: :champagne:  :tada: :champagne:
Highlights :green_circle:

Project requirement "Make sure there're no N+1 queries happening" has been included in a card :+1:

Optional suggestions
N/A
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

As described in the Code reviews limits policy  you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.


Append next query params on transaction list

Pull Request Test Coverage Report for Build 482932365

0 of 38 (0.0%)  changed or added relevant lines in 2 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-0.3%) to 28.671%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

services/indexes/params/params.go
0
1
0.0%

services/indexes/avax/reader.go
0
37
0.0%

Files with Coverage Reduction
New Missed Lines
%

services/indexes/avax/reader.go
1
14.97%

Totals

Change from base Build 481484982:
-0.3%

Covered Lines:
1154

Relevant Lines:
4025

💛  - Coveralls

Pull Request Test Coverage Report for Build 482932365

0 of 38 (0.0%)  changed or added relevant lines in 2 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-0.3%) to 28.671%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

services/indexes/params/params.go
0
1
0.0%

services/indexes/avax/reader.go
0
37
0.0%

Files with Coverage Reduction
New Missed Lines
%

services/indexes/avax/reader.go
1
14.97%

Totals

Change from base Build 481484982:
-0.3%

Covered Lines:
1154

Relevant Lines:
4025

💛  - Coveralls


Deselecting a textbox when outside of immediate view in scrollviewer causes issues

When a textbox with focus is outside of the immediate view, in a ScrollViewer, having the textbox lose focus (which can be done by selecting another object) makes it so that the ScrollViewer will jump back up to the textbox and deselect it. Is this intended behavior? And if so, is there a way to disable such functionality?

Avalonia 0.9.9
I have also seen this where a Button click is ignored if a TextBox has focus and is scrolled off screen and the button is inside the same ScrollViewer.
Instead the ScrollViewer scrolls the TextBox back into view.
Clicking the button again then fires the command correctly.


feat(rbac): add extensions to rbac backend plugin

Description
Adds extension points to the RBAC backend plugin to allow for backend module support. This extension support will allow for the use of third party access management tools when it comes to loading in permission policies and roles. Included in this PR is an example backend module that can be paired with the RBAC backend plugin.
Fixes

Fixes: RHIDP-2724

Special Notes to the reviewer
Included is an example backend module that can be used to test the new feature. Within the example module is a CSV file in which you can manipulate the roles and permissions to test the scenarios of adding / removing permissions and roles.
Adding the test provider to test new functionality
Install the provider
backend.add(
  import('@janus-idp/backstage-plugin-rbac-backend-module-test/alpha'),
);

Configure the test provider
permission:
  rbac:
    providers:
      test:
        baseUrl: http://localhost:8099
        accessToken: temp
        schedule:
          frequency: { minutes: 1 }
          timeout: { minutes: 1 }
          initialDelay: { seconds: 1 }

This will set the provider schedule to apply the roles and permissions from a csv file every minute.
To see the permissions and roles be updated, edit the csv file plugins/rbac-backend-module-test/test-policy.csv
Finally, to test the manual refresh capability use update the config to adjust the frequency of the schedule
permission:
  rbac:
    providers:
      test:
        baseUrl: http://localhost:8099
        accessToken: temp
        schedule:
          frequency: { minutes: 10 }
          timeout: { minutes: 1 }
          initialDelay: { seconds: 1 }

10 Minutes should give you enough time to edit the csv file and manually trigger refresh.
Edit the csv file with your desire changes.
Call the refresh endpoint
curl -X POST "http://localhost:7007/api/permission/refresh/testProvider" -H "Authorization: Bearer $token" -v

Should return a 200

Tested, works fine.

Works by me as well.

Tested scenarios:

no provider

{"error":{"name":"NotFoundError","message":"The RBAC provider testProvider was not found","stack":"NotFoundError: The RBAC provider testProvider was not found\n    at <anonymous> (/home/dzemanov/Projects/janus2/backstage-plugins/plugins/rbac-backend/src/service/policies-rest-api.ts:1030:15)\n    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)"},"request":{"method":"POST","url":"/api/permission/refresh/testProvider"},"response":{"statusCode":404}}%

Provider loaded - correctly loads data defined by provider

Editing policies from provider by rbac ui correctly results in error

Unable to edit role: source does not match originating role role:default/test-provider, consider making changes to the 'TESTPROVIDER'

Changing csv file correctly updates - removing / adding works

Adding new role via ui with the same name as from provider correctly does not create

Error: Unable to create role. Unable to add role: source does not match originating role role:default/test-provider, consider making changes to the 'TESTPROVIDER'

Refresh endpoint works as expected


Add feature to delay the comment

Pull request for #119 and #124

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at<EMAIL_ADDRESS>Thanks!

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@saiqulhaq updated the pull request.

Thanks a lot for the pull request, it is really high quality! Apart from all the minor syntax nits, this is good to go!

@saiqulhaq updated the pull request.

@vjeux Thanks for the comments and reviews. I just updated it. I'm learning a lot. Thanks!

Hi @vjeux
This PR also contain 'skipCollaborator' setting for issue #124

@saiqulhaq updated the pull request.

Thanks! Sorry for the lack of updates :)

I've tried to enable this setting here:
https://github.com/discourse/discourse/blob/master/.mention-bot
But new PRs are getting mention-bot comments right away:
https://github.com/discourse/discourse/pull/4298
Is it because the feature in this PR has not gone live yet? If so, is there a way to keep up with the latest versions? Seems you're not using GitHub Releases nor tags.

I'm doing a bad job at pushing the latest version to heroku when I merge pull requests. I'll push it today

I just pushed the new version


Laravel 9 route:list trimmed output

Laravel Version: 9.43.0
PHP Version: 8.1.13
Database Driver & Version: irrelevant

Description:
Ever since I upgraded to laravel 9, the route:list command outputs routes in a trimmed format. I need it the way it was before.

If I filter by route name, the line is still trimmed:

You can use the -v option to display the entire information.


Add Flatten adaptor

The build fails because Rust  <= 1.1.0 had no Clone impl for option::IntoIter.

Everything looks good! Will be a new release when I'm home.

Glorious automation


Feature: Create parameter files

Fixed by #532

This release went out today. The extension should auto-update and this fix / functionality will be available at that time.


[Charts] Line graph is not using converted amount

Actually, it was.... I was just not looking at it the right way :-)


No way bro

Describe the new feature or enhancement
Theres no way you can add mods but only for PC, not even mobile or laptops. seriously need to add that cause i play on mobile and chromebook

This feels so disrespectful....
Developers are not machines, you should talk to them nicely.
Your message have no purpose but to make the readers rageful and NOT do what you are requesting.


Extra cell error is hidden in the grid view

Overview
See in the report:

cc @romicolman

I'm closing this ticket since we are addressing the problem in issue #499


Replace gate code with event Fixes #862

Fixes #862
Proposed solution

Changed the usage of gate_code to event id in gate api.

Testing Done

Manual test of web gate interface. Mobile was not tested

Thanks
On Tue, Apr 17, 2018, 16:47 Nitay Rabinovich<EMAIL_ADDRESS>wrote:

Merged #881 https://github.com/Midburn/spark/pull/881.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Midburn/spark/pull/881#event-1578875652, or mute the
thread
https://github.com/notifications/unsubscribe-auth/AAkWjOIYrtgWS7cEYT0GXev4EKqgookoks5tpfKKgaJpZM4TXILx
.


[EXPERIMENT] Attempt to fix ion-test-driver workflow.

Issue #, if available:
#795
Description of changes:
Using this PR to submit ion-test-driver workflows and attempt to find a solution to the setup failures.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Closing in favor of #875


Bundle all CSS and Office UI Fabric in the part

Q
A

Bug fix?
yes

What's in this Pull Request?

Removed reference to external CDN, and bundle everything in the part.
Optimized bundle size by taking a dependency on ui framework grid on the page.
Updated to drop 1.3
Refactored some js code to be more ts'y

thx Mikael, appreciated.


Waiting for rpc client

It worked perfectly fine yesterdaay but today its suddenly not, giving this issue
https://i.imgur.com/m3oamv7.png

this is likely tied to Discord's big API outage, id give it an hour and retry

this is likely tied to Discord's big API outage, id give it an hour and retry

that's a good shout, i'll leave it for now then

It's fixed!  Thanks for the quick help :)


1 year of inactivity, is leaflet.draw dead

This repo has seen no commit for +1 year, PR and issues are stacking up even though @ddproxy (the main contributor and Leaflet member) still uses Github, Leaflet is still very active and Leaflet.draw is still widely used and I don't know an alternative for Leaflet.Draw. maybe somebody from leaflet organisation could tell us about the status of this.
I'm building a product with Leaflet and if leaflet.draw is deprecated my company may tell me to use a supported package. Moreover people making PR, filling up issues and using this package probably need to know the status of this repo.

Leaflet.draw is still widely used and I don't know an alternative for Leaflet.Draw.

leaflet-geoman (formerly leaflet.pm)
Does most if not all of what Leaflet.Draw can do and is actively maintained by @codeofsummit. But yeah it's unfortunate that this long-standing drawing library seems to be dead.

Nobody is updating this plugin? Any fork? Alternatives?
I need rotation for polygons or rectangles like: https://github.com/w8r/Leaflet.Path.Transform
and also leaflet-geoman does not support rotation.
Thank you!

Is anyone aware about someone forking it and simply releasing latest version? For some reason latest release was broken on mobile while unreleased latest code works fine.

Nobody is updating this plugin? Any fork? Alternatives? I need rotation for polygons or rectangles like: https://github.com/w8r/Leaflet.Path.Transform and also leaflet-geoman does not support rotation. Thank you!

Just FYI, Rotation is meanwhile supported in Leaflet-Geoman.
https://github.com/geoman-io/leaflet-geoman#rotation-mode


fix(dh): rename permission mutation

Codecov Report

Merging #1601 (4cdd597) into main (67b7d5e) will increase coverage by 12.89%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##             main    #1601       +/-   ##
===========================================
+ Coverage   18.57%   31.46%   +12.89%
===========================================
  Files          63       78       +15
  Lines        1540     1856      +316
  Branches      144        0      -144
===========================================
+ Hits          286      584      +298
- Misses       1245     1257       +12
- Partials        9       15        +6

Impacted Files
Coverage Δ

...h/source/DataHub.WebApi/GraphQL/GraphQLMutation.cs
0.00% <0.00%> (ø)

... and 19 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Further threading optimizations + caching

Further threading/concurrent optimizations
Using disk caching for extremely large sensu installations

Thanks, had a quick look tonight and there's something odd going on with those Filter by drop-downs again ..

noticed another issue - the DCs keep jumping out of order ..

@naemono merged 👍  and managed to find a relatively simple fix for both issues above

Thanks @alex-leonhardt.  I hadn't had a chance to get back to this yet.  I appreciate the fix.


update csv channel

https://ibm-cloudplatform.slack.com/archives/CQU4MD7KM/p1585085830095700

checking if i also need to update the operator image tag


Implement targeted notifications

At the moment based only on usergroups, but queries can probably be built at a later stage.

bcc-members and public roles not supported, as that requires an iteration of the entire userbase (not a problem, but not needed at the moment)
only respects the emails in the specific usergroups so we can test notifications


Add .tojson() method to Album and other classes

For writing themes based on purely frontend technologies (e.g., VueJS), it would be useful if the Gallery, Album, etc. classes could be easily serialized to JSON.
Jinja supports a tojson filter, which is based on Python's default json module, however most of the data passed to templates in the album dict is not JSON-serializable, thus leading to writing ugly code such as (never mind the early draft, plz)
https://github.com/defeo/sigal-theme/blob/68e3dae1e7a1b94578626d9d587aca3cded1a3cc/templates/album.html#L16-L49
It is not easy to hook into the way the json module serializes objects: having Jinja's tojson work with the Album class would require changes to Jinja's code. Thus I believe the simplest solution would be to add a tojson() method to these classes in Sigal.
If we can agree on a course of actions, I am willing to write a pull request.

Hi,
Interesting, I need to think a bit more about it but it seems a good idea. The galleria theme already use some json serialization so we could maybe use this as well.


To prevent this PR from going to the changelog marked it with the "skip changelog" label.

Snapshot stored with reference name:
refs/pull/14373/merge
Test environment:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/14373/merge/index.html
To test a playground add it to the URL, for example:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/14373/merge/index.html#WGZLGJ#4600
Links to test babylon tools with this snapshot:
https://playground.babylonjs.com/?snapshot=refs/pull/14373/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/14373/merge
https://gui.babylonjs.com/?snapshot=refs/pull/14373/merge
https://nme.babylonjs.com/?snapshot=refs/pull/14373/merge
To test the snapshot in the playground with a playground ID add it after the snapshot query string:
https://playground.babylonjs.com/?snapshot=refs/pull/14373/merge#BCU1XR#0


[Feature Request] Show TLS/SSL Connection Details

Excellent work with v2, its working way better than v1!
What would be great is if we can see in the meta information of the request, what version of TLS was used for the connection as well as maybe some other SSL/TLS related information?
I was thinking something along the lines of what this service offers: https://www.howsmyssl.com/a/check
{
	"given_cipher_suites": [
		"TLS_GREASE_IS_THE_WORD_0A",
		"TLS_AES_128_GCM_SHA256",
		"TLS_AES_256_GCM_SHA384",
		"TLS_CHACHA20_POLY1305_SHA256",
		"TLS_ECDHE_ECDSA_WITH_AES_128_GCM_SHA256",
		"TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256",
		"TLS_ECDHE_ECDSA_WITH_AES_256_GCM_SHA384",
		"TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384",
		"TLS_ECDHE_ECDSA_WITH_CHACHA20_POLY1305_SHA256",
		"TLS_ECDHE_RSA_WITH_CHACHA20_POLY1305_SHA256",
		"TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA",
		"TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA",
		"TLS_RSA_WITH_AES_128_GCM_SHA256",
		"TLS_RSA_WITH_AES_256_GCM_SHA384",
		"TLS_RSA_WITH_AES_128_CBC_SHA",
		"TLS_RSA_WITH_AES_256_CBC_SHA"
	],
	"ephemeral_keys_supported": true,
	"session_ticket_supported": true,
	"tls_compression_supported": false,
	"unknown_cipher_suite_supported": false,
	"beast_vuln": false,
	"able_to_detect_n_minus_one_splitting": false,
	"insecure_cipher_suites": {},
	"tls_version": "TLS 1.3",
	"rating": "Probably Okay"
}

I think mostly the tls_version and given_cipher_suites would be very beneficial.

Thanks! I believe that, typically, a reverse proxy in front of the app handles TLS, so the webhook tester wouldn't capture the original request's TLS information. Or am I mistaken?

@gareth-johnstone friendly ping

Thanks! I believe that, typically, a reverse proxy in front of the app handles TLS, so the webhook tester wouldn't capture the original request's TLS information. Or am I mistaken?

@tarampampam Sorry for late response, its been pretty hectic last few days!
You are absolutely right, it would be the reverse proxy that would be picking up that information!

I believe we have only one option to capture this information - I can add support for TLS certificates in the app, so it will listen on HTTPS instead of HTTP. However, this will require exposing the container port directly to the external world and avoiding the use of any proxy, ingress, etc. That said, is frequently debugging TLS information necessary?

I believe we have only one option to capture this information - I can add support for TLS certificates in the app, so it will listen on HTTPS instead of HTTP. However, this will require exposing the container port directly to the external world and avoiding the use of any proxy, ingress, etc.

We have an external firewall so can therefore block most things anyway - maybe be good as an option to do it this way - for most a reverse proxy would probably be fine, but if you want the additional info, use it directly?

That said, is frequently debugging TLS information necessary?
Probably not, its been a recent requirement for some old software where we are using various versions of SSL over a series of webhooks and trying to figure out which is using what was kind of difficult, so thought it would be a great addition - also very useful for debugging  services that have disabled TLS1.1 etc.

Got it, thanks for clarifying. I'll give it some thought!


[HOLD #15212] Web -  Green "New" line indicator does not disappear after marking as read from LHN

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Open a chat and right click on one of the posted comments
Right click on the chat from the LHN and click on mark as read

Expected Result:
The green "New" line indicator should disappear
Actual Result:
The indicator line does not disappear
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[ ] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number:
Reproducible in staging?:
Reproducible in production?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/93399543/c0d8f5e7-d143-4a11-8bf2-b2d6e7326dd1
https://github.com/Expensify/App/assets/93399543/e8d36946-360d-459f-9be8-c6ff38062956
Expensify/Expensify Issue URL:
Issue reported by: @Nathan-Mulugeta
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1686942669583659
View all open jobs on GitHub

Proposal
Please re-state the problem that we are trying to solve in this issue.
Green "New" line indicator does not disappear after marking as read from LHN.
What is the root cause of that problem?
After marking report as read, newMarkerReportActionID in ReportActionsView is not updated, so the green new line indicator does not disappear.
What changes do you think we should make in order to solve the problem?
We should update newMarkerReportActionID after lastReadTime is changed in shouldComponentUpdate of ReportActionsView.
	shouldComponentUpdate(nextProps, nextState) {
        ...
        if (nextProps.report.lastReadTime !== this.props.report.lastReadTime) {
            this.setState({newMarkerReportActionID: ''});
            return true;
        }
        ...
}

What alternative solutions did you explore? (Optional)
None.

@MonilBhavsar I think we should put this issue on hold and tie it to the master issue for the unread marker, right? I'm going to go ahead and proactively do that now, though I'd like your confirmation either way!

Yes please, thanks 👍

Proposal
Please re-state the problem that we are trying to solve in this issue.
Web - Green "New" line indicator does not disappear after marking as read from LHN.
What is the root cause of that problem?

If we mark as read from LHN, the report's lastReadTime updates to a new value;
In ReportUtils.js, the method isUnread does return lastReadTime < lastVisibleActionCreated, so it would retun false;
But, in ReportActionsView.js inside componentDidUpdate, we do not check if the report automatically became read in order to clear this.state.newMarkerReportActionID.

What changes do you think we should make in order to solve the problem?

We should use the already existing method isUnread from ReportUtils.js in order to not repeat the code;
We should add this logic inside componentDidUpdate in ReportActionsView.js;

if (!ReportUtils.isUnread(this.props.report) && this.state.newMarkerReportActionID != '') {
    this.setState({
        newMarkerReportActionID: '',
    });
}

this.state.newMarkerReportActionID is important in order to prevent unnecessary re-renders.

Still on hold for larger unread factor.

Still on hold for larger unread refactor.

hold

Hold

Same

Same

Just-retested and it's still an issue.

Still held on linked issue.

This should be fixed! We can retest and close this issue

Hey @MonilBhavsar I just retested this and the issue is still reproducible.
https://github.com/Expensify/App/assets/111440031/3e9be3c9-8b76-4df6-bdb7-2f1f0f8818aa

The issue is for web and actions performed states for a read comment

Open a chat and right click on one of the posted comments
Right click on the chat from the LHN and click on mark as read

Perhaps we can update it to "For mark as unread case and for Mobile"

Hey @MonilBhavsar I just retested this again on web and followed the exact steps on the OP. I still am able to reproduce the issue. I will attach a screen recording below.
Screencast from 11-21-2023 09:50:36 PM.webm

This is the expected behavior. The new marker line should persist and will only be removed when user redirects to another chat.

Based on that, I'm good to close this issue and pay @Nathan-Mulugeta via Upwork.

Offer sent.

Just accepted the offer @JmillsExpensify