Nested tags - able to detect and avoid

We're doing a number of different highlights on a page for (a very simple) example:
Text word Text

mark.mark('word');
mark.markRegExp('w.rd');

And we're using the each callback to individually tag what is selected. However, if like in the example above, the same bit of text matches, we end up with:
Text word Text

instead of the expected
Text word Text

(our code will automatically add/append the trackid bits).
Is there any way of setting Markjs to not add a new tag if an existing tag already matches (but still call the each callback)?

Hey @rbairwell,
Thanks for submitting.
Did you look into the exclude and filter options?

I've just checked but it doesn't look like it'll do what I want it to (they seem to be ignoring already marked). I need the "word" marked twice, but ideally without redundant mark tags (which then causes rendering issues with the CSS outline property amongst others). (also related is a highlight on "or" and "word" - the nesting, but not exactly the same marking, does cause issues - but I don't think that can be easily resolved).

@rbairwell Hope this is what you're looking for: https://jsfiddle.net/sLz0ba4L/1/
It should work, however, I have to note that this isn't a unit-tested case. So, keep an eye on it.

Thanks. Tried using filter, but it doesn't work if the second mark is longer than the first:
var currentId=123;
var markFilter = function (textNode, termFound, total) {
                // check for nesting
                var parent=textNode.parentNode;
                if (parent) {
                    if (parent.hasAttribute('data-id)) {
                        console.log('Parent has attribute');
                            parent.setAttribute('data-id',parent.getAttribute('data-id')+' '+currentId);
                            return false;
                    }
                }
                return true;
            };

in the end, I've gone for the following after all the marking is done:
// let's remove duplicated tags
        this.innerDoc.querySelectorAll('[data-id]').forEach(function(element) {
           var parent=element.parentNode;
           if (parent) {
               if (parent.hasAttribute('data-id')) {
                   // check there aren't too many nodes nested
                    var parentNodeLength=parent.children.length;
                    var elementLength=element.children.length;
                    if (parentNodeLength===elementLength+1) {
                        parent.setAttribute('data-id',parent.getAttribute('data-id')+' '+element.getAttribute('data-id'));
                        var tempInstance=new Mark(element);
                        tempInstance.unmark();
                    }
               }
           }
        });

Thanks for pointing me in the right sort of direction. It's not perfect, but it's a lot better than before ;)

I'm glad you've found a way to solve your issue. Feel free to open another issue if there's a need for help.


Position of an Element in an Infinite Sorted Array - Binary Search

Kindly assign the issue to me. I'd be using the binary search algorithm for this particular question and use Java as language to solve. :)

Hello @heenathadani, thank you for creating an issue, it has now been assigned to you.
Important:
Before you start your work on this issue, make sure you go through the README.md and Contribution Guidelines.md
File structure:

In the Searching directory, and navigate to the sub-directory Binary Search.
In the Algorithm.md, please add the problem statement.
Move to the Java directory.
Create the file of your code in camel case.

Here's how the final structure should look like:

Searching

Binary Search

Algorithm.md
Java

your code.java

Please follow the same naming conventions as mentioned.
Before you create a pull request, make some changes in your forked repository so that it matches with the current one and there are no conflicts (git pull).
Note that all PRs are being checked for plagiarism, please refrain from indulging in any crooked means, we trust you!
We thank you for your contribution and time and we hope that you enjoy contributing to open source.


Update README to be more informative

Currently there is no information about what the project is about, only contributing guidelines.

Sure.


[question] gitea?

does this work with gitea? i'm having trouble getting this to work with gitea.
specifically, i have auth configured with basic, with my user name and password and the output i get is the following:
$  semantic-release --allow-initial-development-versions --no-ci
[go-semantic-release]: version:
[go-semantic-release]: ci-condition plugin<EMAIL_ADDRESS>[go-semantic-release]: provider plugin<EMAIL_ADDRESS>[go-semantic-release]: getting default branch...
[go-semantic-release]: found default branch: main
[go-semantic-release]: found current branch: main
[go-semantic-release]: found current sha: main
[go-semantic-release]: getting latest release...
[go-semantic-release]: found version: 0.0.0
[go-semantic-release]: getting commits...
[go-semantic-release]: analyzing commits...
[go-semantic-release]: commit-analyzer plugin<EMAIL_ADDRESS>[go-semantic-release]: calculating new version...
[go-semantic-release]: new version: 0.1.0
[go-semantic-release]: generating changelog...
[go-semantic-release]: changelog-generator plugin<EMAIL_ADDRESS>[go-semantic-release]: creating release...
[go-semantic-release]: object not found
[go-semantic-release]: stopping plugins...

Hey there, thanks for creating this issue.
This looks quite interesting. 🤔 Our CI build actually uses gitea for testing, but I will look into it in the next few days/weeks.

There was a bug when the current sha was a branch name, I fixed it and released v.1.3.0. 🙏


Update Page “home”

Automatically generated by Netlify CMS

Deploy preview for dds-mil ready!
Built with commit cf35f00f2f2ea4a98f48edf636c9820436621e91
https://deploy-preview-239--dds-mil.netlify.app


VS Code take too long to respond when something long is being typed

Description:
This issue is reproducible by editing some file in nBallerina repo.
Screen recording:
https://user-images.githubusercontent.com/1496990/151935501-828af55f-a870-49aa-923b-b20fde6558dd.mp4
When the addition is small the time is bearable, but when it's a long edit, it takes an unbearably long time to compile the final version of the program. My gut feeling is lang-server doesn't debounce the compilation requests in the middle when edits are being made. Feels like all the compilation requests are being queued and each request is processed.
Steps to reproduce:
Affected Versions:
OS, DB, other environment details and versions:
Related Issues (optional):

Suggested Labels (optional):

Suggested Assignees (optional):

Related issue https://github.com/ballerina-platform/ballerina-lang/issues/32020

We tried following with the same string.bal. Here are @rdulmina and my observations.

when typing at the following cursor position int i = "dwew<cursor>" ,

Inside the nballerina project: Observed a slowness for text/didChange requests sent from the VSCode. I guess it is because each individual request consumes a certain amount of time. Therefore, there is a long queue.

Copied the same string.bal content to a single ball file: Observed no slowness for text/didChange requests sent from the VSCode. i.e. no visible queue.

when typing at the following cursor position int i = "dwew<cursor>" ;,
Notice the semicolon after the end quote. In this case although we keep typing at each cursor position each instance is a syntactically valid code instance. Therefore for this scenario error handler/recovery is not involved.

Inside the nballerina project: Observed the same slowness for text/didChange requests sent from the VSCode.

Copied the same string.bal content to a single ball file: Observed no slowness for text/didChange requests sent from the VSCode.

From 2, we think it is okay to conclude that error recovery overhead is not the issue here.
So the problem seems to be with a large project.
@nadeeshaan Do we parse the entire project(each bal file) for a single  text/didChange request or
we only parse the text edited bal file and get the other ones from the cache?

@lochana-chathura we update the content of the changing file only. Also, we have added debouncing to avoid multiple compilations at the server-side as well. Based on your observation, now I'll try to figure out/ identify whether there are any other completions are being processed.
I'll update this thread with the findings.

@rdhananjaya The debouncing is done for the Diagnostics publishing only. After running a few testing cycles, I could isolate one another place where we will have to introduce debouncing as we have done for diagnostics.
Currently, we allow code actions to be provided as compiler plugin extensions. In order to get these code actions we have to get the compilation and then register the available code actions. Since we need to get the compilation after each of the change (since we cannot say that the particular change is associated with and import statement or not) we can identify that as one of the root causes.
IMHO we have to fix it in the first place. We will be looking in to that and keep this issue open once the fix is merged. We'll update the issue accordingly.

Related to #35057


Leftover in the manifests

/kind bug
What steps did you take and what happened:
[A clear and concise description of what the bug is.]
There is a service https://github.com/kserve/kserve/blob/2208f100af02c05031e1910516f31ae3ece87aaf/manifests/charts/templates/service.yaml#L26 that lists port 443 for the kserve-controller-manager, but according to the deployment nothing at 443 is served https://github.com/kserve/kserve/blob/2208f100af02c05031e1910516f31ae3ece87aaf/manifests/charts/templates/deployment.yaml. This would also be a severe security issue because 443 prevents run as non root pods.

Thanks @juliusvonkohout ! Seems to be a bug when generating the metrics service, the port here should be 8443 which targets to the https port in kube rbac proxy used to authenticate and authorize the metrics scraping requests.

and another security issue https://github.com/kserve/kserve/pull/1996

Thanks @juliusvonkohout ! Seems to be a bug when generating the metrics service, the port here should be 8443 which targets to the https port in kube rbac proxy used to authenticate and authorize the metrics scraping requests.

Can I just change it in the template to 8443 and create a pull request or will you do that


Update s3, sdk-core, sqs to 2.16.72

Updates

software.amazon.awssdk:s3
software.amazon.awssdk:sdk-core
software.amazon.awssdk:sqs

from 2.16.67 to 2.16.72.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "software.amazon.awssdk" } ]

labels: library-update, semver-patch

Superseded by #202.


Base image updates for s6 v3 and pin to 3.14

The home assistant base image was updated to s6 v3 which included a few breaking changes detailed here. This makes those fixes.
In addition latest for the alpine base image became 3.15 as a part of this and this addon does not seem to work on alpine 3.15. Added a build.yaml to pin the version to the alpine 3.14 base image and tweaked the pipeline to use it.
Fixes #335
Checklist

[x] PR done against dev branch
[x] Updated zigbee2mqtt/config.json with new version
[x] Updated zigbee2mqtt/CHANGELOG.md file with new changes
[x] Updated zigbee2mqtt/DOCS.md with any changes
[x] Add any new configuration options to zigbee2mqtt/config.json and zigbee2mqtt-edge/config.json.

Fwiw I needed to update stable but this doesn't need to be an immediate update to stable. Is there a way to do like a delayed update to stable? Like I just want to make sure that the addon's image builds when Koenkk pushes out an update to Z2M on June 1st. Stable doesn't need to be updated until then.

@Koenkk Can you take a look at this please? The edge version doesn't work right now.

I tried to reinstall the add-on after reloading/updating the add-ons repositories in HA. I still have the issue and the changelog seems not to have been updated according to the one on Github, is the new build already available ?

@Koenkk yea ok I think I misunderstood the directions. I targetted the dev branch because technically this PR had a fix for stable in it. Not one which required a new version of stable immediately since the existing image works fine. But no new working images for stable could be built without this fix so I thought I should follow those directions.
It looks like doing it that way means this didn't fix edge though. When I pull the dev branch locally i can build and run the edge or stable version just fine but installing it from the repo doesn't. Can the commit be cherry picked back to master? Or would you prefer I just make a new PR with the same changes there? I'm on discord btw if you want to just DM me to get this resolved rather then chatting on this closed PR, CentralCommand#0913.


Shows error when a policy fails to load.

Previously it was showing a message saying that there is not
history for the given policy

Codecov Report

Merging #192 into master will increase coverage by 0.12%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #192      +/-   ##
==========================================
+ Coverage   87.68%   87.80%   +0.12%
==========================================
  Files         115      117       +2
  Lines        2452     2477      +25
  Branches      442      444       +2
==========================================
+ Hits         2150     2175      +25
  Misses        300      300
  Partials        2        2

Impacted Files
Coverage Δ

src/pages/PolicyDetail/Skeleton.tsx
100.00% <ø> (ø)

src/properties/Messages.ts
100.00% <ø> (ø)

src/pages/PolicyDetail/PolicyDetail.tsx
100.00% <100.00%> (ø)

src/pages/PolicyDetail/TriggerDetailSection.tsx
100.00% <100.00%> (ø)

src/pages/PolicyDetail/TriggerErrorState.tsx
100.00% <100.00%> (ø)

The design for errors is a little bit different. Here's the UX doc on it: https://docs.google.com/document/d/1xugj7X-9P_4lHSsQ7EOT2Oxp3n5VVnaGTK6d_wR48ZI/edit?usp=sharing

If we update the icon to red, and then rewrite the message as:
"Error loading trigger history for this policy.
Error code: xxx
[Try again]"
That should work


Pretty much all duplicates

Pretty much all of my builds are duplicates. Not sure how to proceed. Any suggestions?
Decoded hash gets repeated in the metada.json file like so:
0, 1, 2 -> 0, 1, 2, 0, 1, 2 -> 0, 1, 2, 0, 1, 2, 0, 2

Hi, same with me. Its current correcting system for duplicates only detect it once and the newly generated image is not being scanned by the 'for loop' and thus very huge potential for dupes to be formed.

yup same with me full of dupes. the logic for this must be changed


Fix default values of filters

---- Autogenerated Waffleboard Connection: Connects to #419

@LucianBuzzo Would you mind taking a look when you're available?

@dimitrisnl Is this the same as https://github.com/resin-io-modules/rendition/pull/408 ? If it is, could you pick up where @Shou left it?

@LucianBuzzo Oh, I completely missed this PR. Will do so.


Deprecate threshold record fees

Threshold records were deprecated
See https://github.com/hashgraph/hedera-services/issues/506
Corresponding fees should be removed from model

Mainnet updated with fee schedule that deprecates threshold records in fee calculation
https://app.dragonglass.me/hedera/transactions/00561610049260999999269

Mainnet updated with fee schedule that deprecates threshold records in fee calculation
https://app.dragonglass.me/hedera/transactions/00561610049260999999269


Split up tests from github actions into multiple files

Hi @MarcelMue , it's a good idea to split the E2E test, currently I'm working on upgrade the k8s version and dependencies components for the E2E tests. I will rebase on your branch :)

Sounds good! I will merge this soon :)


Lifecycle rewrite for separation of concerns

TODO: write text

Lifecycle rewrite for separation of concerns
Feature request
Rewrite rclcpp::lifecycle for clearer separation of concerns (SoC). Initial PR:
Feature description
I rewrote some of the lifecycle backend code while attempting to create async transitions (PRASYNC). It was suggested it would be best to separate this SoC contribution out into its own issue/PR.
The primary goal was to separate out some of LifecycleNodeInterfaceImpl is responsible for. Currently the LifecycleNodeInterfaceImpl is responsible for:

managing entities
managing lifecycle state
managing services.

I separated these out into files and did some miscellaneous function cleanup / added helper functions.

Short summary, PR has a few more details:

We re-architect LifecycleNodeInterfaceImpl for a cleaner separation of concerns similar to model-view-controller:

LifecycleNodeInterfaceImpl: ("controller") owner of:

StateManager: (model:lifecycle_state) responsible for lifecycle state_machine
StateServicesManager: ("view + controller") public interface of services
EntitiesManager: (model:managed_entities)responsible for entity state

Lifecycle rewrite for separation of concerns
Addresses ISSUESOC.
Separation of Concerns
The LifecycleNodeInterfaceImpl was:

managing ManagedEntities
managing underlying rcl::state_machine
managing services

Proposed architecture:

This PR splits these into 3 separate classes as shown in the figure above. This follows more closely to a model-view-controller design:
LifecycleNodeInterfaceImpl: ("controller") owner of:

EntitiesManager: (model:managed_entities)responsible for entity state
StateManager: (model:lifecycle_state) responsible for lifecycle state_machine
StateServicesManager: ("view + controller") public interface of services

Putting up on rclcpp


Google Material Design Icons not compatible with IE 11

The Google Material Design Icons in pretty-checkbox aren't compatible with IE 11 and display as large square boxes.
https://lokesh-coder.github.io/pretty-checkbox/

Hi @DavidMaza ,
Issue has been fixed in new version 3.
Here's the updated documentation
Feel free to open if you face the same issue.
Thanks!


Move the bond ip4 and gw4 templating out of the bridge conditional.

This allows configuration of a bond interface with an IP address,
even with no bridge defined.

I looked around; we just never happened to do this before.  All the bonded interface IPs were on parent bridges.

interesting how certain obvious cases don't always crop up until later.   LGTM.


Library error when building from source

Hi, when trying to build from source on Ubuntu 20 (latest https://ngc.nvidia.com/catalog/containers/nvidia:pytorch container), I get the following error: /usr/bin/ld: cannot find -ltinfo.
LLVM is not preinstalled on the system. If I install it manually with apt install llvm the build works fine.
May be related to #142.
Installing collected packages: triton
  Running setup.py develop for triton
    ERROR: Command errored out with exit status 1:
     command: /opt/conda/bin/python3.8 -c 'import io, os, sys, setuptools, tokenize; sys.argv[0] = '"'"'/workspace/se3-transformer/triton/python/setup.py'"'"'; __file__='"'"'/workspace/se3-transformer/triton/python/setup.py'"'"';f = getattr(tokenize, '"'"'open'"'"', open)(__file__) if os.path.exists(__file__) else io.StringIO('"'"'from setuptools import setup; setup()'"'"');code = f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' develop --no-deps
         cwd: /workspace/se3-transformer/triton/python/
    Complete output (115 lines):
    running develop
    running egg_info
    creating triton.egg-info
    writing triton.egg-info/PKG-INFO
    writing dependency_links to triton.egg-info/dependency_links.txt
    writing requirements to triton.egg-info/requires.txt
    writing top-level names to triton.egg-info/top_level.txt
    writing manifest file 'triton.egg-info/SOURCES.txt'
    package init file 'triton/_C/__init__.py' not found (or not a regular file)
    reading manifest file 'triton.egg-info/SOURCES.txt'
    reading manifest template 'MANIFEST.in'
    writing manifest file 'triton.egg-info/SOURCES.txt'
    running build_ext
    -- The C compiler identification is GNU 9.3.0
    -- The CXX compiler identification is GNU 9.3.0
    -- Detecting C compiler ABI info
    -- Detecting C compiler ABI info - done
    -- Check for working C compiler: /usr/bin/cc - skipped
    -- Detecting C compile features
    -- Detecting C compile features - done
    -- Detecting CXX compiler ABI info
    -- Detecting CXX compiler ABI info - done
    -- Check for working CXX compiler: /usr/bin/c++ - skipped
    -- Detecting CXX compile features
    -- Detecting CXX compile features - done
    -- Adding Python module
    -- Configuring done
    -- Generating done
    -- Build files have been written to: /workspace/se3-transformer/triton/python/build/temp.linux-x86_64-3.8
    [  2%] Building CXX object CMakeFiles/triton.dir/lib/codegen/analysis/align.cc.o
    [  4%] Building CXX object CMakeFiles/triton.dir/lib/codegen/analysis/allocation.cc.o
    [  6%] Building CXX object CMakeFiles/triton.dir/lib/codegen/analysis/liveness.cc.o
    [  8%] Building CXX object CMakeFiles/triton.dir/lib/codegen/analysis/axes.cc.o
    [ 10%] Building CXX object CMakeFiles/triton.dir/lib/codegen/analysis/swizzle.cc.o
    [ 13%] Building CXX object CMakeFiles/triton.dir/lib/codegen/analysis/layout.cc.o
    [ 15%] Building CXX object CMakeFiles/triton.dir/lib/codegen/selection/generator.cc.o
    [ 17%] Building CXX object CMakeFiles/triton.dir/lib/codegen/pass.cc.o
    [ 19%] Building CXX object CMakeFiles/triton.dir/lib/codegen/target.cc.o
    [ 21%] Building CXX object CMakeFiles/triton.dir/lib/codegen/transform/coalesce.cc.o
    [ 23%] Building CXX object CMakeFiles/triton.dir/lib/codegen/transform/dce.cc.o
    [ 26%] Building CXX object CMakeFiles/triton.dir/lib/codegen/transform/disassociate.cc.o
    [ 28%] Building CXX object CMakeFiles/triton.dir/lib/codegen/transform/cts.cc.o
    [ 30%] Building CXX object CMakeFiles/triton.dir/lib/codegen/transform/membar.cc.o
    [ 32%] Building CXX object CMakeFiles/triton.dir/lib/codegen/transform/peephole.cc.o
    [ 34%] Building CXX object CMakeFiles/triton.dir/lib/codegen/transform/pipeline.cc.o
    [ 36%] Building CXX object CMakeFiles/triton.dir/lib/codegen/transform/prefetch.cc.o
    [ 39%] Building CXX object CMakeFiles/triton.dir/lib/codegen/transform/reorder.cc.o
    [ 41%] Building CXX object CMakeFiles/triton.dir/lib/driver/buffer.cc.o
    [ 43%] Building CXX object CMakeFiles/triton.dir/lib/driver/backend.cc.o
    [ 45%] Building CXX object CMakeFiles/triton.dir/lib/driver/context.cc.o
    [ 47%] Building CXX object CMakeFiles/triton.dir/lib/driver/device.cc.o
    [ 50%] Building CXX object CMakeFiles/triton.dir/lib/driver/error.cc.o
    [ 52%] Building CXX object CMakeFiles/triton.dir/lib/driver/dispatch.cc.o
    [ 56%] Building CXX object CMakeFiles/triton.dir/lib/driver/platform.cc.o
    [ 56%] Building CXX object CMakeFiles/triton.dir/lib/driver/kernel.cc.o
    [ 58%] Building CXX object CMakeFiles/triton.dir/lib/driver/handle.cc.o
    [ 63%] Building CXX object CMakeFiles/triton.dir/lib/driver/stream.cc.o
    [ 63%] Building CXX object CMakeFiles/triton.dir/lib/driver/module.cc.o
    [ 65%] Building CXX object CMakeFiles/triton.dir/lib/ir/basic_block.cc.o
    [ 67%] Building CXX object CMakeFiles/triton.dir/lib/ir/builder.cc.o
    [ 69%] Building CXX object CMakeFiles/triton.dir/lib/ir/context.cc.o
    [ 71%] Building CXX object CMakeFiles/triton.dir/lib/ir/constant.cc.o
    [ 73%] Building CXX object CMakeFiles/triton.dir/lib/ir/dispatch.cc.o
    [ 76%] Building CXX object CMakeFiles/triton.dir/lib/ir/function.cc.o
    [ 78%] Building CXX object CMakeFiles/triton.dir/lib/ir/instructions.cc.o
    [ 80%] Building CXX object CMakeFiles/triton.dir/lib/ir/metadata.cc.o
    [ 82%] Building CXX object CMakeFiles/triton.dir/lib/ir/module.cc.o
    [ 84%] Building CXX object CMakeFiles/triton.dir/lib/ir/print.cc.o
    [ 86%] Building CXX object CMakeFiles/triton.dir/lib/ir/value.cc.o
    [ 89%] Building CXX object CMakeFiles/triton.dir/python/src/main.cc.o
    [ 91%] Building CXX object CMakeFiles/triton.dir/lib/ir/type.cc.o
    [ 93%] Building CXX object CMakeFiles/triton.dir/lib/ir/utils.cc.o
    [ 95%] Building CXX object CMakeFiles/triton.dir/python/src/triton.cc.o
    [ 97%] Building CXX object CMakeFiles/triton.dir/python/src/superblock.cc.o
    /workspace/se3-transformer/triton/lib/driver/module.cc: In member function ‘void triton::driver::cu_module::init_from_ptx(const string&, triton::driver::cu_device*)’:
    /workspace/se3-transformer/triton/lib/driver/module.cc:303:14: warning: ignoring return value of ‘int mkstemp(char*)’, declared with attribute warn_unused_result [-Wunused-result]
      303 |       mkstemp(_fsrc);
          |       ~~~~~~~^~~~~~~
    /workspace/se3-transformer/triton/lib/driver/module.cc:304:14: warning: ignoring return value of ‘int mkstemp(char*)’, declared with attribute warn_unused_result [-Wunused-result]
      304 |       mkstemp(_flog);
          |       ~~~~~~~^~~~~~~
    [100%] Linking CXX shared library ../../triton/_C/libtriton.so
    /usr/bin/ld: cannot find -ltinfo
    collect2: error: ld returned 1 exit status
    make[2]: *** [CMakeFiles/triton.dir/build.make:801: ../../triton/_C/libtriton.so] Error 1
    make[1]: *** [CMakeFiles/Makefile2:111: CMakeFiles/triton.dir/all] Error 2
    make: *** [Makefile:101: all] Error 2
    Traceback (most recent call last):
      File "<string>", line 1, in <module>
      File "/workspace/se3-transformer/triton/python/setup.py", line 122, in <module>
        setup(
      File "/opt/conda/lib/python3.8/site-packages/setuptools/__init__.py", line 163, in setup
        return distutils.core.setup(**attrs)
      File "/opt/conda/lib/python3.8/distutils/core.py", line 148, in setup
        dist.run_commands()
      File "/opt/conda/lib/python3.8/distutils/dist.py", line 966, in run_commands
        self.run_command(cmd)
      File "/opt/conda/lib/python3.8/distutils/dist.py", line 985, in run_command
        cmd_obj.run()
      File "/opt/conda/lib/python3.8/site-packages/setuptools/command/develop.py", line 38, in run
        self.install_for_development()
      File "/opt/conda/lib/python3.8/site-packages/setuptools/command/develop.py", line 140, in install_for_development
        self.run_command('build_ext')
      File "/opt/conda/lib/python3.8/distutils/cmd.py", line 313, in run_command
        self.distribution.run_command(command)
      File "/opt/conda/lib/python3.8/distutils/dist.py", line 985, in run_command
        cmd_obj.run()
      File "/workspace/se3-transformer/triton/python/setup.py", line 77, in run
        self.build_extension(ext)
      File "/workspace/se3-transformer/triton/python/setup.py", line 119, in build_extension
        subprocess.check_call(["cmake", "--build", "."] + build_args, cwd=self.build_temp)
      File "/opt/conda/lib/python3.8/subprocess.py", line 364, in check_call
        raise CalledProcessError(retcode, cmd)
    subprocess.CalledProcessError: Command '['cmake', '--build', '.', '--config', 'Release', '--', '-j160']' returned non-zero exit status 2.
    downloading and extracting https://github.com/llvm/llvm-project/releases/download/llvmorg-11.0.1/clang+llvm-11.0.1-x86_64-linux-gnu-ubuntu-16.04.tar.xz...
    ----------------------------------------
ERROR: Command errored out with exit status 1: /opt/conda/bin/python3.8 -c 'import io, os, sys, setuptools, tokenize; sys.argv[0] = '"'"'/workspace/se3-transformer/triton/python/setup.py'"'"'; __file__='"'"'/workspace/se3-transformer/triton/python/setup.py'"'"';f = getattr(tokenize, '"'"'open'"'"', open)(__file__) if os.path.exists(__file__) else io.StringIO('"'"'from setuptools import setup; setup()'"'"');code = f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' develop --no-deps Check the logs for full command output.

Oh that's an interesting one. LLVM libraries (libLLVMSupport.a in particular) unfortunately depends on terminfo (libtinfo.so). What distribution are you on ? I assume it's not ubuntu. Usually, libtinfo is packaged in ncurses-dev or libtinfo-dev

The distribution is Ubuntu 20.04.2.
You can reproduce this in the same environment with:
docker run --rm --gpus=all -it nvcr.io/nvidia/pytorch:21.07-py3 bash
git clone https://github.com/openai/triton
cd triton/python
pip install -e .

libtinfo seems to be installed with a .5 and .6 suffix:
root@c21fc05a589a:/workspace# /sbin/ldconfig -p | grep tinfo
libtinfo.so.6 (libc6,x86-64) => /usr/lib/x86_64-linux-gnu/libtinfo.so.6
libtinfo.so.5 (libc6,x86-64) => /usr/lib/x86_64-linux-gnu/libtinfo.so.5

Thanks a lot for reporting and debugging. This has been fixed in #173 . I tested it on docker, but please make sure that it also works on your system :)

Thanks for fixing this, it works fine on my setup now.


Client Manual Refactoring

Manual refactoring of the client to meet some of the standards and clean up the code.
This pull request has NOT been tested, therefore, manual testing is required.

@daleu

We'll take a look @ConsoleTVs . Thanks a lot for your contribution! 🙌

The CSS is a bit messy in here.

And aparently, the footer is there, but somehow hidden:

May you guys take a look at it when you have some free time? btw; I also removed dozens of TS warnings.


remove /etc/environment

This directory of file doesn't exist on coreos.

Is there a need or reason for this?  I use this statement on all my nodes.

Well, this line breaks service on coreos. It won't start at all because
/etc/environment doesn't exist.
On Fri, Jun 5, 2015, 16:35 Seán C. McCord<EMAIL_ADDRESS>wrote:

Is there a need or reason for this? I use this statement on all my nodes.
—
Reply to this email directly or view it on GitHub
https://github.com/ceph/ceph-docker/pull/71#issuecomment-109312425.

That's curious; all my hosts are CoreOS.  What version are you running that /etc/environment doesn't exist?
Anyway, I wonder if EnvironmentFile will take the - prefix... something like:
EnvironmentFile=-/etc/environment

According to the documentation, it does.  If you wouldn't mind modifying your PR to simply prefix - to /etc/environment, it should be clean and good.

PR #73 fixes this issue


Added Docker Clone

🛠 Fixes Issue
Fixes #579

👨💻 Changes proposed
Added Clone for Docker
✔ Check List (Check all the applicable boxes)

[x] My code follows the code style of this project.
[x] This PR does not contain plagiarized content.
[x] The title of my pull request is a short description of the requested changes.

📷 Screenshots

This branch is 2 commits ahead, 10 commits behind Rayman-Sodhi:main.

@Rayman-Sodhi  Done !

@gurjeetsinghvirdee  Review
https://user-images.githubusercontent.com/72455881/170650132-1ebda4c6-e329-4ab3-b968-68f8b61588cf.mp4

@gurjeetsinghvirdee Can I request for level 3 on this ?
Since I had tried to add my best to make it as close as Actual Docker Website


Swift Spinner Doesn't Show iOS9.2 - Solved - Submitted PR

SwiftSpinner used to work when called from any method. But in recent updates with Swift and iOS9.2 the SwiftSpinner gets lost in which window it should add the view to. I have solved the issue and submitted a PR from my fork.

#47


Improve indexing of classical music and remixes

Metadata is confusing for classical music. The artist field typically only lists the composer, which makes it hard to search by the performer's (orchestra's? conductor's? soloist's?) name unless it happens to be included in the album name.
The American Decca Recordings 1 by Andrés Segovia has metadata like the following (per ffmpeg -i -- fields are described here):
  Metadata:
    title           : Suite española, Op.47 - Granada (serenata)
    artist          : Isaac Albéniz
    track           : 1/22
    album           : The American Decca Recordings 1
    disc            : 1/6
    date            : 2009-05-26
    TMED            : CD
    MusicBrainz Album Type: album
    MusicBrainz Album Artist Id: 443aad48-c7e7-476f-96bf-90f123a4829b
    MusicBrainz Artist Id: 0a46cf2a-61bd-447d-b8fd-a2b32eb20282
    TDOR            : 2009-05-26
    ASIN            : B001TN0V6U
    TSO2            : Segovia, Andrés
    album_artist    : Andrés Segovia
    CATALOGNUMBER   :<PHONE_NUMBER>32
    compilation     : 1
    MusicBrainz Release Group Id: 58b99c13-12fe-4827-9014-47518b071feb
    artist-sort     : Albéniz, Isaac
    MusicBrainz Album Id: cd0b7289-57e8-44c1-9627-fbcc97990012
    publisher       : Deutsche Grammophon
    MusicBrainz Album Status: official

Another example is The Six Unaccompanied Cello Suites performed by Yo-Yo Ma:
  Metadata:
    title           : Suite No. 1 in G major, BWV 1007: I. Prélude
    artist          : Johann Sebastian Bach
    track           : 1/18
    album           : Six Unaccompanied Cello Suites
    disc            : 1/2
    date            : 1983
    TMED            : CD
    SCRIPT          : Latn
    MusicBrainz Album Type: album
    MusicBrainz Album Artist Id: 24f1766e-9635-4d58-a4d4-9413f9f98a4c
    MusicBrainz Artist Id: 24f1766e-9635-4d58-a4d4-9413f9f98a4c
    TDOR            : 1983
    MusicBrainz Album Id: 99d76582-422f-493d-b83a-be52072edf54
    TSO2            : Bach, Johann Sebastian; Ma, Yo-Yo
    album_artist    : Bach; Yo-Yo Ma
    CATALOGNUMBER   : M2K 37867
    MusicBrainz Release Group Id: 01e23da3-2cba-3a44-b7fc-3f8d4a3f2056
    artist-sort     : Bach, Johann Sebastian
    TSRC            : USSM18200515
    ASIN            : B0000025QM
    publisher       : CBS Records Masterworks
    MusicBrainz Album Release Country: US
    MusicBrainz Album Status: official

This makes me think that I should also be storing the album_artist field, which appears to correspond to the TPE2 tag. The performer field, corresponding to TPE3, seems more appropriate, but it looks like it might not get set by default in some taggers.
https://en.wikipedia.org/wiki/ID3#ID3v2_frame_specification has the following descriptions:

TPE1 - Lead performer(s)/Soloist(s)
TPE2 - Band/orchestra/accompaniment
TPE3 - Conductor/performer refinement
TPE4 - Interpreted, remixed, or otherwise modified by

https://picard-docs.musicbrainz.org/downloads/MusicBrainz_Picard_Tag_Map.html has the following:

TPE1 - Artist
TPE2 - Album Artist
TPE3 - Conductor
TPE4 - Remixer

This still isn't perfect. See Bach Sonatas (feat. flute: James Galway):
  Metadata:
    title           : Sonata, BWV 1020 in G minor, Adagio
    artist          : Johann Sebastian Bach
    track           : 17/21
    album           : Bach Sonatas (feat. flute: James Galway)
    date            : 1995
    BARCODE         :<PHONE_NUMBER>28
    publisher       : BMG Music
    ALBUMARTISTSORT : Bach, Johann Sebastian
    MusicBrainz Album Type: album
    MusicBrainz Album Id: d180b66f-be41-43c8-92f4-b4e5c7c2987a
    MusicBrainz Album Status: official
    artist-sort     : Bach, Johann Sebastian
    album_artist    : Johann Sebastian Bach
    CATALOGNUMBER   : 09026-62555-2
    MusicBrainz Album Artist Id: 24f1766e-9635-4d58-a4d4-9413f9f98a4c
    MusicBrainz Artist Id: 24f1766e-9635-4d58-a4d4-9413f9f98a4c
    MusicBrainz Album Release Country: US

I luck out in that case since the soloist's name already appears in the album name.
Remixes are another issue. I don't think that TPE4 is typically set either, but it seems like using TPE2 may help here too. See 26 Mixes for Cash by Aphex Twin:
  Metadata:
    title           : Time to Find Me (AFX Fast mix)
    artist          : Seefeel
    track           : 1/13
    album           : 26 Mixes for Cash (disc 1)
    date            : 2003-03-25
    compilation     : 1
    ALBUMARTISTSORT : Aphex Twin
    MusicBrainz Album Type: remix
    artist-sort     : Seefeel
    MusicBrainz Album Status: official
    MusicBrainz Album Id: cd20ee48-328b-4c24-8b37-2070f8a57c54
    ASIN            : B000088EGP
    album_artist    : Aphex Twin
    MusicBrainz Album Artist Id: f22942a1-6f70-4f48-866e-238cb2308fbd
    TSRC            : GBBNZ9300032
    MusicBrainz Artist Id: 8ffcd7d7-6293-4fbf-b0f6-46aef9ce9f69
    MusicBrainz Album Release Country: US

I think that the title often contains the remixer's name in the case where they aren't the album artist:
  Metadata:
    title           : Holdon (Modeselektor remix)
    artist          : Apparat & Raz Ohara
    track           : 4/11
    album           : Things to Be Frickled
    disc            : 2/2
    date            : 2008-04
    TMED            : CD
    TDOR            : 2008-04
    album_artist    : Apparat
    TSO2            : Apparat
    SCRIPT          : Latn
    publisher       : Shitkatapult
    TSST            : Remix Apparat
    ASIN            : B00133QSWM
    originalyear    : 2008
    artist-sort     : Apparat & Raz Ohara
    BARCODE         :<PHONE_NUMBER>27
    CATALOGNUMBER   : Strike 89
    Artists         : Apparat
    MusicBrainz Album Status: official
    MusicBrainz Album Release Country: DE
    MusicBrainz Album Type: album
    MusicBrainz Album Id: 3d070d8e-aba9-4141-813d-c50a4e0e0ff6
    MusicBrainz Album Artist Id: dc3dbfc1-f1f1-49c6-9d7c-425fabf3ae12
    MusicBrainz Release Group Id: cf1aad97-b8f6-31bb-9933-8adc74c0bd9e
    MusicBrainz Release Track Id: 76b4e5cf-3271-3d48-bd8a-d3aa664c11c5
    MusicBrainz Artist Id: dc3dbfc1-f1f1-49c6-9d7c-425fabf3ae12

  Metadata:
    title           : Ventolin (Cylob mix)
    artist          : Aphex Twin
    track           : 4/6
    album           : Ventolin EP (The Remixes)
    date            : 1995-03-27
    BARCODE         :<PHONE_NUMBER>982
    publisher       : Warp Records
    ALBUMARTISTSORT : Aphex Twin
    MusicBrainz Album Type: remix
    artist-sort     : Aphex Twin
    MusicBrainz Album Status: official
    MusicBrainz Album Id: e846e716-d6ef-43d9-a296-e2460ca35185
    ASIN            : B00004WULX
    MusicBrainz Artist Id: f22942a1-6f70-4f48-866e-238cb2308fbd
    album_artist    : Aphex Twin
    CATALOGNUMBER   : WAP60CDR
    MusicBrainz Album Artist Id: f22942a1-6f70-4f48-866e-238cb2308fbd
    TIPL            : producer
    composer        : Richard David James
    MusicBrainz Album Release Country: GB

So I should think about this some more and check more songs, but my initial thoughts are:

Add an AlbumArtist field to the Song struct and make nup update fill it.
Make the server include AlbumArtist when generating the Keywords field.
Figure out how to backfill the field (probably through a one-off hack).
Figure out how clients should display AlbumArtist (if at all).

Just to mention it, there are various sort order fields too, but I don't think I'm going to store them for now since I don't know anything about the quality of the data:

TSO2 - Album Artist Sort Order
TSOA - Album Sort Order
TSOP - Artist Sort Order

Since the album artist is probably almost always the same as the (track) artist, I'm tempted to leave the field unset unless it's different.


[Bug Report]: Cannot find package 'src'

Steps to reproduce
When running the yarn run dev command, it mentions that it cannot find the "src" folder, it works if I compile the project as if it were a NestJs
Reproduce link
No response
What is actually happening?
When compiling with the NestJs Framework, it gives an error when searching for the "src" folder, even when using it to make an alias: Configuring Alias And Externals
[ Farmup ] "index" PID 10771 exit 1
[ Farmup ] Build completed in 390ms ⚡FULL EXTREME! Resources emitted to ./dist.
[ Farmup:index ] node:internal/modules/esm/resolve:845
throw new ERR_MODULE_NOT_FOUND(packageName, fileURLToPath(base), null);
^
Error [ERR_MODULE_NOT_FOUND]: Cannot find package 'src' imported from ~/proyectos/backend/dist/index.mjs
at packageResolve (node:internal/modules/esm/resolve:845:9)
at moduleResolve (node:internal/modules/esm/resolve:918:18)
at defaultResolve (node:internal/modules/esm/resolve:1148:11)
at ModuleLoader.defaultResolve (node:internal/modules/esm/loader:390:12)
at ModuleLoader.resolve (node:internal/modules/esm/loader:359:25)
at ModuleLoader.getModuleJob (node:internal/modules/esm/loader:234:38)
at ModuleWrap. (node:internal/modules/esm/module_job:87:39)
at link (node:internal/modules/esm/module_job:86:36) {
code: 'ERR_MODULE_NOT_FOUND'
}
Node.js v21.7.3
System Info
System:
    OS: Linux 5.15 Linux Mint 21.3 (Virginia)
    CPU: (4) x64 Intel(R) Core(TM) i5-7400 CPU @ 3.00GHz
    Memory: 1.57 GB / 7.71 GB
    Container: Yes
    Shell: 5.8.1 - /bin/zsh
  Binaries:
    Node: 21.7.3 - ~/.nvm/versions/node/v21.7.3/bin/node
    Yarn: 4.3.1 - ~/.nvm/versions/node/v21.7.3/bin/yarn
    npm: 10.5.0 - ~/.nvm/versions/node/v21.7.3/bin/npm
    pnpm: 9.5.0 - ~/.local/share/pnpm/pnpm
    bun: 1.0.30 - ~/.bun/bin/bun
  Browsers:
    Brave Browser: <IP_ADDRESS>
    Chrome: 127.0.6533.88
  npmPackages:
    @farmfe/core: ^1.3.0 => 1.3.10

Can you provide a reproduce link？ We can solve problems faster

But I'm just running the "yarn run dev" command, I don't have a link where you can reproduce the problem, since it's a private project for a company. How can I generate a link for you in a project that I generated publicly?

In order for the project to work, I just had to make an empty project and put all the information inside. "I literally copied the information from my 'old' project, created with the same version of farmfe and pasted it into my new project, so it would work." I hate my PC @ErKeLost

In order for the project to work, I just had to make an empty project and put all the information inside. "I literally copied the information from my 'old' project, created with the same version of farmfe and pasted it into my new project, so it would work." I hate my PC @ErKeLost

Thank you for your feedback and use farm @blaicer15


Runtime Timeout Error in Spawn_npc.py script after adding New map

Hi All,
I have created a new map using RoadRunner and currently using Carla 9.11 version.
After creating a map, when i try to run the Spawn_npc.py script, Iam getting a Runtime error as below:
WARNING: Version mismatch detected: You are trying to connect to a simulator that might be incompatible with this API
WARNING: Client API version     = 0.9.11-5-g4c8f4d5f
WARNING: Simulator API version  = 0.9.11-5-g4c8f4d5f-dirty
WARNING: cannot parse georeference: ''. Using default values.
destroying 0 vehicles
destroying 0 walkers
done.
Traceback (most recent call last):
File "spawn_npc.py", line 303, in
main()
File "spawn_npc.py", line 144, in main
spawn_points = world.get_map().get_spawn_points()
RuntimeError: time-out of 10000ms while waiting for the simulator, make sure the simulator is ready and connected to <IP_ADDRESS>:2000
The above error i am facing only in LINUX (Not in Windows). And all other scripts as Automaticcontrol.py and manual control.py is working fine in Linux machine.
This Error iam getting only to the new map which i created. In other Town Maps, the Spawn_npc.py script is working.
Can anyone help why iam facing this error.

Try increasing the timeout first, especially if the map is quite big. You must change the value in this line:
client.set_timeout(10.0)
Otherwise, it might be a different problem.

Try increasing the timeout first, especially if the map is quite big. You must change the value in this line:
client.set_timeout(10.0)
Otherwise, it might be a different problem.

@jackbart94 Yeah i tried increasing the time as well. Still the same issue.

@jackbart94  I have created a map without Pedestrians and Traffic signals. Is that be a problem?

@jackbart94 I have created a map without Pedestrians and Traffic signals. Is that be a problem?

Try following carefully the documentation on how to create a map. It appears that spawn points are the problem here.

@jackbart94 I have created a map without Pedestrians and Traffic signals. Is that be a problem?

Try following carefully the documentation on how to create a map. It appears that spawn points are the problem here.

Yeah, as per the document The vehicle spawn points are added through the Opendrive Actor and even I got 47 Vehicle spawn points in it.
The same works fine for Windows. Only in Linux i could not able to spawn

@jackbart94 I have created a map without Pedestrians and Traffic signals. Is that be a problem?

Try following carefully the documentation on how to create a map. It appears that spawn points are the problem here.

Adding one more observation as, the spawn_npc script is working in no rendering mode perfectly.
Only it is not running when i play the map in unreal Editor and trying to spawn in the map.

It has to be the timeout. There's no other issue I can think of. Could you try and increase it significantly, like 60 seconds or even 120, then eventually paste here the error?

It has to be the timeout. There's no other issue I can think of. Could you try and increase it significantly, like 60 seconds or even 120, then eventually paste here the error?

Still I got the same error as below:
destroying 0 vehicles
destroying 0 walkers
done.
Traceback (most recent call last):
File "spawn_npc.py", line 306, in
main()
File "spawn_npc.py", line 146, in main
spawn_points = world.get_map().get_spawn_points()
RuntimeError: time-out of 120000ms while waiting for the simulator, make sure the simulator is ready and connected to <IP_ADDRESS>:2000

But manual_control.py has the same exact call and you're saying it works, so I'm a bit clueless honestly. Is the simulator running correctly before you run spawn_npc.py? Which version of CARLA are you using?

But manual_control.py has the same exact call and you're saying it works, so I'm a bit clueless honestly. Is the simulator running correctly before you run spawn_npc.py? Which version of CARLA are you using?

Yeah the simulator was running through Unreal Editor(I played the Game from unreal Editor) and i ran the spawn_npc.py
Iam using carla version 9.11

make sure your port 2000 and 2001 is open and accessible and no app is blocking it .

Signal 11 caught. Malloc Size=65538 LargeMemoryPoolOffset=65554  CommonUnixCrashHandler: Signal=11 Malloc Size=65535 LargeMemoryPoolOffset=131119  Malloc Size=145408 LargeMemoryPoolOffset=276544  Engine crash handling finished; re-raising signal 11 for the default handler. Good bye. Segmentation fault (core dumped)
I get the above error on running Spawn_npc.py in Carla Server Build (from source) using Docker

make sure your port 2000 and 2001 is open and accessible and no app is blocking it .

@Ria9929 Yeah there is no problem on that

see if this  might help
https://github.com/carla-simulator/carla/issues/3193

see if this might help
#3193

@Ria9929 Thanks. I went through the mentioned issue, but still i am facing same issue.

Try with a newest version of CARLA, see if it's still happening.

Signal 11 caught. Malloc Size=65538 LargeMemoryPoolOffset=65554 CommonUnixCrashHandler: Signal=11 Malloc Size=65535 LargeMemoryPoolOffset=131119 Malloc Size=145408 LargeMemoryPoolOffset=276544 Engine crash handling finished; re-raising signal 11 for the default handler. Good bye. Segmentation fault (core dumped)
I get the above error on running Spawn_npc.py in Carla Server Build (from source) using Docker

This means you have no memory available.


How to get other project's abi?

I want to get tonstakers' abi, but I found that there is no abi json file in the known category.

You need to develop it by following description in readme and examples.


Handle resolutions for the location engine in the Publisher

On iOS, there's no way to tell the location engine which resolution should it use. So only resolutions for sending location updates through Ably are working. On Android, we've had to write whole location engines implementations to allow resolution changing. Do we want to implement it on iOS too?
┆Issue is synchronized with this Jira Bug by Unito

@KacperKluka would you elaborate on this?

So we want to be able to change the location engine resolution when it's running. For example, this can be used to limit the GPS sensor usage when there are no subscribers on the channel.
With the default Mapbox implementation that's not possible as we can only provide the location engine resolution during its creation. Therefore, we've created our own subclass of the LocationEngine which allows changing the resolution during runtime. Then we've taken Mapbox engines code and adjusted it for the location engine subclass (example). Finally, we create and use one of our own location engines when creating the Mapbox instance.
This allows us to simply call one method and change the resolution whenever we want to :wink:


Cooking plugin

Hereby I present a cooking plugin. It contains an overlay with some basic information.

Nice addition.
You might want to remove the 'Cooked/hr' row and just place its text behind the 'Cooked' amount. This would give you: Cooked: 6 (66 h/r).

Here's the updated UI:

Also; the width is slighty wider to make all the text fit nicely.

This is like 4th "session" related plugin, maybe there should be some common structure added, because now it is just duplicate code all over the place, or maybe even have them all in 1 plugin imo.

Aw, when I read "Cooking plugin" I started imagining a cookbook panel.


Secrets are actually environment variables

Relates to #203
From https://github.com/compose-spec/compose-spec/blob/master/05-services.md#environment

Environment variables can be declared by a single key (no value to equals sign). In this case Compose relies on you to resolve the value. If the value is not resolved, the variable is unset and is removed from the service container environment.

Current compose files like:
services:
  a:
    secrets:
      - BLAH
secrets:
  BLAH:
    external: true

should actual be written like:
services:
  a:
    environment:
      - BLAH

and generate the same internal protobuf definition (still with "service.secrets" for now)

Fixed by #324


remove unused lib to fix #115

remove unused lib to fix #115

Nice catch, that was a dumb oversight :smile:

Also forgot to say thank you for looking into and fixing this :+1:

No problem.


Such a rubbish project? ? ? ? ?

It is said to be decentralized, but the result is that everything is centralized? Are you writing about the centralization of your mother? ? ? ?
Just want to make money, right? ? ?

换了vpn就好了，fuck！！！


Fix "mountain" typos in 2021 policies

@jahfer

❤ Thanks!! I won't comment on the fact that I made this typo in two different spots 😅


Add test cases

Codecov Report

Merging #178 (d857d01) into main (57a04dd) will increase coverage by 0.28%.
The diff coverage is 60.86%.

@@            Coverage Diff             @@
##             main     #178      +/-   ##
==========================================
+ Coverage   67.21%   67.50%   +0.28%
==========================================
  Files          14       14
  Lines        1449     1468      +19
==========================================
+ Hits          974      991      +17
+ Misses        371      370       -1
- Partials      104      107       +3

Impacted Files
Coverage Δ

agent.go
78.57% <60.86%> (+1.01%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57a04dd...d857d01. Read the comment docs.


API does not differ between Distribution.area and areaID

In ColDP and DwC you can give a distribution area by the name of an area of it's identifier from a known gazetteer such as TDWG or ICO country codes. The backend only stored area and places the areaID there.
Keep both fields distinct in the API

We expose an area now in the Distribution and the vocab API:
https://api.catalogueoflife.org/vocab/area?gazetteer=tdwg


Issues in return values

Issues in return values

Fixed conditions in playermove to properly check the valid range for number.
Corrected assignments in tie function (if (spaces[i] = ' ') to if (spaces[i] == ' ')).
Added return value true in tie function for the case when the board is full.
Fixed return value of winner function to return false when no winner is found.
Added break statements after checking for ties in the main loop to exit the loop when a tie is detected.
Fixed the srand initialization with proper casting for time(0).


Asset transfer validation is ineffective

I have noticed that the fungible validate command is not validating the witness transaction produced by an asset transfer operation (and referenced in the respective consignment data structure).
For instance, if one issues the fungible validate command right after the fungible transfer command, even before the witness PSBT is finalized and sent to the Bitcoin blockchain, the response will always be Asset transfer successfully validated.
This misbehavior has been verified in version 0.2.1 of RGB node.

This is correct, it should not validate it. The task of witness transaction validation lies on the wallet. The reason is the simple fact that this transaction is probably not yet mined when the consignment arrives and wallet needs to wait for it.

This is correct, it should not validate it. The task of witness transaction validation lies on the wallet. The reason is the simple fact that this transaction is probably not yet mined when the consignment arrives and wallet needs to wait for it.

After some debugging, I have realized that the consignment validation procedure (validate method of the Consignment structure of the Stash daemon) was actually returning an EndpointTransitionNotFound warning, which means that the procedure was not finding the endpoint node ID (in my test, the consignment had a single endpoint) in the state transitions of the consignment data structure.
After further investigation, I have found out that the cause of this problem is in the procedure that generates the consignment for an asset transfer operation. More specifically, in the consign method of the Stash trait implementation for the Runtime structure of the Stash daemon.
What happens is that the consign method is passed the transition node via its node input parameter, whose ID is then used to produce the endpoints entry of the Consignment structure (see code snippet).
However, that same method, prior to adding the received transition node to the state transitions vector, modifies it to conceal its asset change assignment (see code snippet). Once the transition is modified, its node ID also changes, thus causing the mismatch with the node ID in the endpoints entry.

After some debugging, I have realized that the consignment validation procedure (validate method of the Consignment structure of the Stash daemon) was actually returning an EndpointTransitionNotFound warning, which means that the procedure was not finding the endpoint node ID (in my test, the consignment had a single endpoint) in the state transitions of the consignment data structure.
After further investigation, I have found out that the cause of this problem is in the procedure that generates the consignment for an asset transfer operation. More specifically, in the consign method of the Stash trait implementation for the Runtime structure of the Stash daemon.
What happens is that the consign method is passed the transition node via its node input parameter, whose ID is then used to produce the endpoints entry of the Consignment structure (see code snippet).
However, that same method, prior to adding the received transition node to the state transitions vector, modifies it to conceal its asset change assignment (see code snippet). Once the transition is modified, its node ID also changes, thus causing the mismatch with the node ID in the endpoints entry.

This is correct, it should not validate it. The task of witness transaction validation lies on the wallet. The reason is the simple fact that this transaction is probably not yet mined when the consignment arrives and wallet needs to wait for it.

@dr-orlovsky, then I am really confused because, reviewing the code that is executed when processing the fungible validate command, it is clear that a Spectrum server is queried to make sure that the witness transaction (whose txid is found in the consignment produced by the asset transfer) exists, and that it spends the UTXO that holds the single-use seal associated with the asset allocation that is used as the source for the asset transfer.
If you look at my previous comment, you will see an explanation of why this not happening as it should.

This is correct, it should not validate it. The task of witness transaction validation lies on the wallet. The reason is the simple fact that this transaction is probably not yet mined when the consignment arrives and wallet needs to wait for it.

@dr-orlovsky, then I am really confused because, reviewing the code that is executed when processing the fungible validate command, it is clear that a Spectrum server is queried to make sure that the witness transaction (whose txid is found in the consignment produced by the asset transfer) exists, and that it spends the UTXO that holds the single-use seal associated with the asset allocation that is used as the source for the asset transfer.
If you look at my previous comment, you will see an explanation of why this not happening as it should.

Thank you for all the details. Will review the process how it happens in the code and what can/should be fixed and report back.

Thank you for all the details. Will review the process how it happens in the code and what can/should be fixed and report back.

@dr-orlovsky, in an intention to contribute a bit more with your effort, I was looking at a way to fix this issue. However, the solution seems to be more complex than I have anticipated.
I thought that it would be just a matter of replacing the node ID in the consignment's endpoints to match the node ID of the transitions in the consignment's state transitions. That is, the consignment's endpoints would include the node ID of the concealed transitions (I mean, the transition after its assignments are concealed as required), in the same way that the consignment's state transactions include the concealed transitions.
When that is done, the fungible validate command does not return the EndpointTransitionNotFound warning any more. However, this triggers another error condition, and the fungible validate command now returns the TransitionNotInAnchor failure.
The TransitionNotInAnchor failure is due to the fact that now the node ID (of the concealed transition) in the consignment's endpoints does not match the node ID of the transitions that were used to generate the anchor. In fact, reviewing the procedure that is used to generate the anchors, it is passed the node ID of the "plain" transitions. By "plain" I mean before any of its assignments are concealed as required.
One possible solution would require to change the way the anchors are generated so that they use the node ID of the concealed transitions instead. That sounds a bit too radical though, and I do not know if that is even possible.

@dr-orlovsky, in an intention to contribute a bit more with your effort, I was looking at a way to fix this issue. However, the solution seems to be more complex than I have anticipated.
I thought that it would be just a matter of replacing the node ID in the consignment's endpoints to match the node ID of the transitions in the consignment's state transitions. That is, the consignment's endpoints would include the node ID of the concealed transitions (I mean, the transition after its assignments are concealed as required), in the same way that the consignment's state transactions include the concealed transitions.
When that is done, the fungible validate command does not return the EndpointTransitionNotFound warning any more. However, this triggers another error condition, and the fungible validate command now returns the TransitionNotInAnchor failure.
The TransitionNotInAnchor failure is due to the fact that now the node ID (of the concealed transition) in the consignment's endpoints does not match the node ID of the transitions that were used to generate the anchor. In fact, reviewing the procedure that is used to generate the anchors, it is passed the node ID of the "plain" transitions. By "plain" I mean before any of its assignments are concealed as required.
One possible solution would require to change the way the anchors are generated so that they use the node ID of the concealed transitions instead. That sounds a bit too radical though, and I do not know if that is even possible.

The conceal operation must not modify the transition node id. Transition node id, when computed, conceals all data anyway and uses the concealed version for the hashing. If the id is modified after any of concealements applied that means that the id computing is broken. I will investigate that part of the story separately.
As for the reason why the transition is not found during the validation, it the node id computing works correctly, there should be a different cause of the bug.

Solved with https://github.com/rgb-org/rgb-core/pull/8


Revert "cudatoolkit: Move libcudart to a separate output"

This reverts commit bb1c9b027d343f2ce263496582d6b56af8af92e6.
Motivation for this change
See https://github.com/NixOS/nixpkgs/issues/29798
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)

[ ] NixOS
[ ] macOS
[x] Linux

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

:-1:, this would increase the closure size of Blender by a couple of gigabytes.

@edolstra Could you advise on how to fix #29798?

Probably the rpath set in tensorflow's postFixup phase should be changed from cudatoolkit to cudatoolkit.lib (or maybe cudatoolkit.lib cudatoolkit, in case it's using other libraries from cudatoolkit - but in that case maybe those should be moved to lib as well).


Improve handling of temporary files on windows

What does this PR change? What problem does it solve?
restic currently uses ioutil.TempFile(...) to create its temporary files on Windows. As files cannot be deleted on Windows while these are still opened, restic sometimes leaves temporary files behind. This PR sets the FILE_FLAG_DELETE_ON_CLOSE flag to let windows delete the file automatically once all references were deleted. In addition, the flag FILE_ATTRIBUTE_TEMPORARY is added to avoid unnecessary writes of the temporary files to disk.
As os.Open and therefore ioutil.TempFile do not support these flags, this PR introduces a custom TempFile implementation, that directly calls syscall.CreateFile.
This PR is based on the code from @ducalex in #3465.
The temporary file is also created using shareMode 0, which prevents other processes from accessing the file in parallel. Thus restic is the only process which can open the file. As it will be deleted on close, this ensures that a tempfile can be removed, which fixes #1551.
Was the change previously discussed in an issue or on the forum?
Closes #3465.
Closes #1551.
Supersedes #3306.
Checklist

[x] I have read the contribution guidelines.
[x] I have enabled maintainer edits.
[x] I have added tests for all code changes.
[ ] I have added documentation for relevant changes (in the manual).
[x] There's a new file in changelog/unreleased/ that describes the changes for our users (see template).
[x] I have run gofmt on the code in all commits.
[x] All commit messages are formatted in the same style as the other commits in the repo.
[x] I'm done! This pull request is ready for review.

FILE_ATTRIBUTE_TEMPORARY and FILE_FLAG_DELETE_ON_CLOSE are both available in golang.org/x/sys/windows. That also offers everything now imported from syscall.


Only detecting swipe to directions with items

Fixes #358

I've solved this more generally in #381 as well.

I've solved this more generally in #381 as well.

I would call it a different approach not a more general way. If I get it right you are letting the consumer decide if the menu should be shown vs my not trying to show it when there is nothing to show.

I've solved this more generally in #381 as well.

I would call it a different approach not a more general way. If I get it right you are letting the consumer decide if the menu should be shown vs my not trying to show it when there is nothing to show.

Exactly. I would think it'd be nice to combine your canSwipe{Left,Right} into the default delegate implementation.

Thanks @igorkulman this fixed the issue for me


Hindi word parser is confused by zero width joiner characters (U+200D)

Description
In the Dev Nagari writing system used by Hindi, each consonant is combined with a vowel.  "Conjunct" characters are normally used to represent sequences of consonants that do not have vowels between them, for example the "st" combinaton in "namaste".
Some Hindi web pages use a sequence of consonants with a zero-width joiner character, U+200D, in between them instead of a conjunct character.  When Lute attempts to parse words that contain these characters it splits the words and that breaks the ability to look up definitions in a dictionary.
To make things work properly, the zero--width joiner characters needs to be removed.  It is not enough to add this character to the list of word characters in the language.  The obvious solution would be to modify the SpaceDelimitedParser.get_parsed_tokens() method to remove zero-width joiner characters as well as zero-width space characters.
To Reproduce

Import text from the Hindi web page https://jivani.org/Biography/400/जॉर्ज-ऑरवेल--जीवनी---biography-of--george-orwell-in-hindi-jivani
Open the boo
Click on the word after नामक, which looks like स्थान but contains a zero-width joiner after the first character.
Depending on where you click, you will either select स् or थान

Screenshots
None
Extra software info, if not already included in the Description:

OS (e.g., iOS, windows): Linux
Browser (e.g., chrome, safari): Firefox
How you've installed Lute (Docker, python, source): pip
Version: 3.2.5

This makes a lot of sense, and the PR is super.  I hadn't run into this myself, so I appreciate you fixing this.

Launched in 3.2.7, with some modifications along the way.


[ Bug ]: Missing Line Break in Hash Example

NOTE: only in wide-screen this happen!

This occurs when the snippet has text but no code.  One easy solution is to remove the md styling and just stick with sm style, which looks reasonable even on wider screen imo.  But we loose the big giant code block at sizes > 768px (md)

Finally got back to this... Browsing around the other examples, those snippets with text but lacking code seem to serve well as context separators.  So I would suggest just adding some margin below.  I'll submit a PR with that change for review.


django-ninja compatibility docs

Current Situation
It may be unclear to users how to use this framework with Django Ninja.
Proposed Actions
Create some documentation showing how to integrate with Django Ninja.

I dug into Django Ninja, and it looks like it requires a full-fledged Django environment.
Ninja just exists as an extra HTTP endpoint, so there are zero modifications needed to the existing docs.
Will need @paolodina and @jensenbox to chime in on what confusion currently exists. Is it related to how to send/receive queries from Ninja API endpoints within ReactPy-Django?
Will be closing this issue until I hear some feedback.


add accounts list command

Description
Add ability for user to list all account names in flow config
flow accounts list has one new flag --sort
Can be used for tools that use flow cli.

For contributor use:

[ ] Targeted PR against master branch
[ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work
[ ] Code follows the standards mentioned here
[ ] Updated relevant documentation
[ ] Re-reviewed Files changed in the Github PR explorer
[ ] Added appropriate labels

closing this, not needed going to research adding multisig wizard into flow cli.


Feature footnote support

Hi,
I've created footnote support. To the API I added functions:

Can read footnotes from a paragraph as a list. The footnote object contains footnote reference id and paragraphs.

doc = Document('test.docx')
paragraph = doc.paragraphs[0]
footnotes = paragraph.footnotes
for footnote in footnotes:
    print(f'footnote reference id: {footnote.id}')
    print(f'this footnote has paragraphs: {len(footnote.paragraphs)}')

Can access all footnotes in a document as a list where the list index is footnote reference id for that footnote

doc = Document('test.docx')
for footnote in doc.footnotes:
    print(f'footnote reference id: {footnote.id}')
    print(f'this footnote has paragraphs: {len(footnote.paragraphs)}')

Can add a footnote to the end of a paragraph. The footnote reference id is calculated based on the other footnotes in the document. On a created footnote object you can add paragraphs.

doc = Document('test.docx')
paragraph = doc.paragraphs[0]
new_footnote = paragraph.add_footnote()
new_footnote.add_paragraph('paragraph in footnote')

Can read and change footnote properties in a section.

doc = Document('test.docx')
s = doc.section[0]
print(s.footnote_position)
print(s.footnote_number_format)
print(s.footnote_numbering_start_value)
print(s.footnote_numbering_restart_location)
s.footnote_position = 'beneathText'
s.footnote_number_format = 'hex'
s.footnote_numbering_start_value = 4
s.footnote_numbering_restart_location = 'eachPage'

@scanny Any updates on merging footnote support into the library?

@tiberlas I testing this update locally and it works great. I wish it was merged since being able to pull footnotes from the exact paragraph that they are referenced in great!


multi: update to tlv/v1.1.0 and use new *P2P tlv decoding variants

This changes the call-sites in several places to use the *P2P variants to not trigger an OOM on untrusted input. This makes the code safe with the new tlv version. Note that the call-sites prior to this change were also safe.

Can you add an entry to the release notes please?

updated w/ notes


Allows using yaml config files and shorthand config option

Hi there,
You might not like the added dependencies, but this is something I needed for my own project and II thought you might consider adding the feature!
Cheers,
Jun

By the way, shorthand means that it's possible to do
metalsmith --config blah

And it will automtically look for blah.json blah.yml or blah.yaml files.

Working on fixing tests.

Coverage remained the same at 94.304% when pulling a1d62741bf0471f92db8dea71d8eb38680b71346 on contentascode:master into 8d7265eccd43049a615faf38039b19e08a2c7885 on segmentio:master.

Coverage remained the same at 94.304% when pulling a1d62741bf0471f92db8dea71d8eb38680b71346 on contentascode:master into 8d7265eccd43049a615faf38039b19e08a2c7885 on segmentio:master.


numerical styles with second-field-align="flush"

Using numerical styles such as nature.csl which contain the csl directive second-field-align="flush" in <bibliography ...>, the bibliography is expected to be rendered like a numbered list.
(There are also a few styles with second-field-align="margin", see list at https://gist.github.com/gjuggler/8222414, but since I don't think pandoc can handle stuff in margins these are probably best formatted just like the ones with second-field-align="flush".)
In addition, there should be no space before the superscripted citation numbers. (Citation numbers always appearing before final punctuation seems to be intentional, however, as a look at a number of recent "Nature" articles shows, and the fact that pandoc ignores page numbers is fine since these just aren't supposed to be used with such styles.)
The "et al" issue has been reported before, see https://github.com/jgm/pandoc-citeproc/issues/27.
There are a few other unexpected details, such as missing location and "ed.", but these are csl style errors.
pandoc -s --filter pandoc-citeproc -t markdown-citations <<EOT

Lorem [@arj1]. Ipsum [@boo1, 12-34; @inc1].

# References {-}

---
csl: nature.csl
references:
- page: 271-279
  title: By rail and stage to Galena
  id: inc1
  issued:
    date-parts:
    - - 1968
  author:
  - given: Elizabeth F. L.
    family: Ellet
  container-title: "Prairie state: Impressions of Illinois, 1673–1967, by travelers
    and other observers"
  editor:
  - given: Paul M.
    family: Angle
  publisher: University of Chicago Press
  type: chapter
  publisher-place: Chicago
- title-short: Freakonomics
  title: 'Freakonomics: A rogue economist explores the hidden side of everything'
  id: boo1
  issued:
    date-parts:
    - - 2005
  author:
  - given: Steven D.
    family: Levitt
  - given: Stephen J.
    family: Dubner
  publisher: William Morrow
  type: book
  publisher-place: New York
- title-short: Codes, costs, and critiques
  issue: 1
  page: 19-35
  title: "Codes, costs, and critiques: The organization of information in *Library
    Quarterly*, 1931–2004"
  volume: 76
  id: arj1
  issued:
    date-parts:
    - - 2006
  author:
  - given: Hope A.
    family: Olson
  container-title: Library Quarterly
  type: article-journal
  DOI: 10.1086/504343
...
EOT

Actual output:
Lorem ^1^. Ipsum ^2,3^.

References {#references .unnumbered}
==========

1.Olson, H. A. *et al.* Codes, costs, and critiques: The organization of
information in *Library Quarterly*, 1931–2004. *Library Quarterly*
**76,** 19–35 (2006).

2.Levitt, S. D. & Dubner, S. J. *et al.* *Freakonomics: A rogue
economist explores the hidden side of everything*. (William Morrow,
2005).

3.Ellet, E. F. L. *et al.* in *Prairie state: Impressions of Illinois,
1673–1967, by travelers and other observers* (Angle, P. M.) 271–279
(University of Chicago Press, 1968).

Expected output:
Lorem^1^. Ipsum^2,3^.

References {#references .unnumbered}
==========

1.  Olson, H. A. *et al.* Codes, costs, and critiques: The organization of
    information in *Library Quarterly*, 1931–2004. *Library Quarterly*
    **76,** 19–35 (2006).

2.  Levitt, S. D. & Dubner, S. J. *et al.* *Freakonomics: A rogue
    economist explores the hidden side of everything*. (William Morrow,
    2005).

3.  Ellet, E. F. L. *et al.* in *Prairie state: Impressions of Illinois,
    1673–1967, by travelers and other observers* (Angle, P. M.) 271–279
    (University of Chicago Press, 1968).

Note to self: we can get at this where s is a style via
lookup "second-field-align" $ maybe [] (bibOptions) $ biblio s

If the value is Just "margin", we should insert a line break after the citation number.
If it is Just "flush", we should (for now) insert a space after the citation number.

I have implemented a fix for this that isn't perfect, but is better than what we had.
We now at least get a space after the citation number if second-field-align is flush.
If it's margin, we get a line break.
I don't see a good way of doing better without more major changes.

If it's margin, we get a line break.

Sorry, this was my misunderstanding.  I've changed this so a space, rather than a line break, is inserted.

I just started playing around with creating a custom CSL style and also ran into this problem (second-field-align: flush not being applied); also entry-spacing does not seem to be applied.
Are those still known issues/bugs and/or is there something I can do to achieve the desired layout in HTML output? Thank you!

Fixed in pandoc 2.11. Closing.


Entries in PS Logs about errors with API call

Hello,
I have strange messages in the Prestashop Logs.
All have the same structure, only the payment reference changes.
I put here some xxxx instead of the real payment reference.

Mollie module error: [2023-01-09T10:24:19+0100] Error executing API call (404: Not Found): Payment tr__xxxxxxx_ exists, but the wrong mode is used. Try switching live / test API keys.. Documentation: https://docs.mollie.com/overview/handling-errors

I don't understand, because I'm in live mode, payments work normally, so... I don't know why I get these messages.
It's very strange, because these payments can be 2-3 months old.
Environment

PrestaShop version: <IP_ADDRESS>
Mollie module version: 3.5.1
PHP version: 7.3

Hey there,
We will be glad to help you with this! Our team will check your case, and get back to you as soon as possible with an update.
--
Best Regards,
Invertus Support team.

Hi there @CooUoo,
I can see that you are using the 3.5.1 Mollie module version, could you please try to upgrade the module to the latest one and see if that helps with the issue? You can download the latest release here - https://github.com/mollie/PrestaShop1.7/releases/tag/5.3.1
Keep me updated!
--
Best Regards,
Invertus Support team.

Hello,
Sorry, I made a typing mistake.
I do use the last 5.3.1.
Regards

Hi there,
It seems like the API could have been changed. Orders can be created but something else could not be working properly, as the webhook displays the message that you have attached.
Please try to check the transaction on your account mollie.com, and check if all of the information is matching if the API key is correct and live.
If you have any questions, let us know!
Best Regards,
Invertus Support team.

Hi
I checked every info.
Everything is correct on my shop and on mollie.com.
I can even see the lines in the history of each order "Webhook called successfully..."
That being said, I don't see any malfunction, i.e. orders are ok, payments are ok, refunds are ok...
Everything works as expected.
So, if there is an error somewhere, it doesn't seem to affect our activity.
But still... I don't like non-understood error messages like this.
Regards

Hi there @CooUoo,
We will continue investigating next week, in the meantime, could you please send us your Back-Office and FTP credentials to<EMAIL_ADDRESS>Best Regards,
Invertus Support team.

Hi there @CooUoo,
We have not received the information from your side for some time now, so we are going to close this issue.
If you face this issue once again, please let us know, and we will reopen the ticket.
Best Regards,
Invertus Support team.


feat: add ssl/sasl support for kafka sink

Signed-off-by: tabVersion<EMAIL_ADDRESS>I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.
What's changed and what's your intention?
as title
Checklist

[x] I have written necessary rustdoc comments
[x] I have added necessary unit tests and integration tests
- [ ] I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features).
[x] All checks passed in ./risedev check (or alias, ./risedev c)

Documentation
If your pull request contains user-facing changes, please specify the types of the changes, and create a release note. Otherwise, please feel free to remove this section.
Types of user-facing changes
Please keep the types that apply to your changes, and remove those that do not apply.

Connector (sources & sinks)

Release note
Please create a release note for your changes. In the release note, focus on the impact on users, and mention the environment or conditions where the impact may occur.
adjust properties naming in with clause: change kafka.brokers to properties.bootstrap.server & kafka.topic to topic.
create sink si
from
  s5 with (
    properties.bootstrap.server = '<IP_ADDRESS>:29092',
    topic = 'sink_target',
    format = 'append_only',
    connector = 'kafka'
  )

full kafka sink options:

Field
Required
Note

properties.bootstrap.server
yes
Address of the Kafka broker. Format: ‘ip:port’. If there are multiple brokers, separate them with commas.

topic
yes
Address of the Kafka topic. One sink can only correspond to one topic.

secrity related
optional
The same as kafka source's security settings

properties.timeout
optional (default 5000ms)
The max waiting time for any operation.

properties.retry.max
optional (default 3)
The max retry times for any failed operation.

properties.retry.interval
optional (default 100ms)
The interval between retries.

use_transaction
optional (default true)
Use transactions to deliver messages to kafka.

and enable SSL/SASL settings in kafka sink (the same as kafka source ref)
Refer to a related PR or issue link (optional)
None

@fuyufjh @lmatz what do you think of the properties' naming?

@tabVersion Should we merge it?

@tabVersion Should we merge it?

@lmatz is verifying the feature with aws MSK, so just leave it

The log when not specifying the SASL fields is:

Disconnected while requesting ApiVersion: might be caused by incorrect security.protocol configuration (connecting to a SSL listener?) or broker version is < 0.10 (see api.version.request) (after 1ms in state APIVERSION_QUERY)

Maybe can be used as error message.


List files in a tree view format when reviewing PRs

Issue Description
Type: feature request
Describe what happened (or what feature you want)
When reviewing a PR, list the files in a tree view instead of the bottom buffer. Possibly with the same functionality as github's which lists only the affected from PR files (personally I would like to see all files of a project so i can jump around if needed even to a file that wasn't changed in the PR but has code that I need to check)
Describe what you expected to happen
How to reproduce it (as minimally and precisely as possible)

Tell us your environment
Anything else we need to know?

Could you add a screenshot of what you would like to see? The GitHub UI has changed a bit since this was opened.

Im closing it since i dont use it anymore, i dont even remember what I wanted :|


feat: add German translation

Add German translation
I added a i18n translation file for German, because we want to use Argilla in a setting where people only speak that language. Let me know if that would work like that.
Type of change

[x] Improvement (change adding some improvement to an existing functionality)

How Has This Been Tested
I only added the i18n translation for German, and checked that the UI works based on the browser setting. Please let me know if there is some test that I would adopt.
Checklist

[ ] I added relevant documentation
[x] I followed the style guidelines of this project
[x] I did a self-review of my code
[ ] I made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I filled out the contributor form (see text above)
[ ] I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/)

Hello @paulbauriegel 👋
Thanks for this contribution.
I'll take a look!

Hello again @paulbauriegel
I tested your changes and it works! But we have some UI issues because some words are a bit long.
Here I created a PR to switch language based on the browser language. https://github.com/argilla-io/argilla/pull/4690
Tomorrow we'll improve some UI bugs and we'll merge it.
Many thanks for this amazing contribution and keep improving Argilla together!!

Hello @paulbauriegel this morning we pushed one change into develop, now you can try your translation.
Before approve your PR could you please update the CHANGELOG.md
Thanks!

@damianpumar If you talk about #4690 it actually worked before too🤔. I think detectBrowserLanguage actually defaults to useCookie: true and that's why it might have worked in the browser.
Anyway I can test it again & update the CHANGELOG.md

I tested it again, but I think it might make sense to add a couple more values to the translation js files

@damianpumar I added most of the changes that are relevant to have the feedback task and major UI elements multi-lingual. I would add the changes for other tasks like Text2Text etc in a second MR to make this one not too big. Changelog is updated if there is anything else Todo let me know.

Hi @paulbauriegel you can merge it when you want!
Many thanks for your amazing work!

@damianpumar I don't have the rights to merge it myself, but please go ahead and merge it :-)


Rule of hooks error on useColorScheme v2.0.3

Wanted to drop this off for you guys on the RN sdk
Cause
I'm getting an error on the line within the RN sdk (2.0.3) On file SDKContainer.styled.js useColorScheme is throwing a rule of hooks error. Looking at the type file and the source file useColorScheme doesn't look like it exists anymore? Maybe the types are out of sync on this version?
Not sure but I updated the line in SDKContainer.styled.js to
export const isDarkMode = false;
from
export const isDarkMode = useColorScheme ? useColorScheme() === 'dark' : false;
and I'm no longer seeing the error
Diff
Here is the diff that solved my problem:
diff --git<EMAIL_ADDRESS><EMAIL_ADDRESS>index a04d3f1..ebdd86e 100644
---<EMAIL_ADDRESS>+++<EMAIL_ADDRESS>@@ -26,7 +26,7 @@ export const styles = StyleSheet.create({
         resizeMode: 'contain',
     },
 });
-export const isDarkMode = useColorScheme ? useColorScheme() === 'dark' : false;
+export const isDarkMode = true;
 export const statusBarStyle = {
     backgroundColor: isDarkMode ? '#000000' : '#ffffff',
 };

This issue body was partially generated by patch-package.

This issue is resolved.


Include StorageInfo in Benchmarking Pipeline

This PR is the first step to fully integrating StorageInfo into the benchmarking pipeline.
As it sits, this PR now gives comment metadata to all the benchmarks, taking note of which storage items have been touched while running a benchmark.
Here is an example:
	// Storage: Assets Asset (r:1 w:1)
	// Storage: Assets Account (r:2 w:2)
	// Storage: System Account (r:1 w:1)
	fn transfer_keep_alive() -> Weight {
		(121_000_000 as Weight)
			.saturating_add(T::DbWeight::get().reads(4 as Weight))
			.saturating_add(T::DbWeight::get().writes(4 as Weight))
	}

These comments are now added automatically to the benchmarking through the handlebars template.
This information is derived from the StorageInfo and the tracked prefixes from the benchmarking db.
Further work will be included in the future which will pull more storage information from the StorageInfo such as the max size and length for PoV tracking.

/benchmark runtime pallet pallet_balances

/benchmark runtime pallet pallet_balances

/benchmark runtime pallet pallet_balances

/benchmark runtime pallet pallet_timestamp

/benchmark runtime pallet pallet_timestamp

/benchmark runtime pallet pallet_balances

/benchmark runtime pallet pallet_balances

/benchmark runtime pallet pallet_contracts

/benchmark runtime custom --chain=dev --steps=50 --repeat=20 --pallet=pallet_contracts --extrinsic="*" --execution=wasm --wasm-execution=compiled --heap-pages=8192 --output=./frame/contracts/src/weights.rs --template=./.maintain/frame-weight-template.hbs

/benchmark runtime pallet pallet_timestamp

/benchmark runtime pallet frame_system

/benchmark runtime pallet frame_system

/benchmark runtime pallet frame_system

/benchmark runtime pallet frame_system

/benchmark runtime pallet frame_system

/benchmark runtime pallet frame_system

/benchmark runtime pallet frame_system

bot merge

bot merge


How can I change the visualization? Changes are not displayed in the browser.

Developers please help. I have been suffering for two days. I need to change the visualization of some graphs. Superset installed via Docker. I am modifying the container for the files nvd3_vis.js and chord.jsx. But my changes are not displayed in the browser. There is a feeling that the * .js (x) files are cached. I reset the cache in browsers, restarted the container and even deleted the file nvd3_viz.js. This did not help me. Everything works without changes. Tell me what you need to do to see the changes, after editing the files in the folder ... / superset / assets / visualizations /?
And tell me the development environment, in which it will be convenient to debug the project?

We're in 2017 where the frontend is built. You have to modify the source and then rebuild the whole thing. Next time looking at the documentation may save you two days of suffering  https://superset.incubator.apache.org/installation.html#making-your-own-build

@xrmx Hello. Thanks for the reply. The documentation I have read. Unfortunately I'm not advanced user to understand. I need to change only the angle of the label graphics. This can be done by removing a couple of lines in the source. I thought it can be done quickly. It turned out that it is more difficult. I'll try to understand.
Do you find it difficult to write a procedure or give a link? I can enter these commands in a Docker container?  Thanks for the reply. The documentation I have read. Unfortunately I'm not advanced user to understand. I need to change only the angle of the label graphics. This can be done by removing a couple of lines in the source. I thought it can be done quickly. It turned out that it is more difficult. I'll try to understand.

@xrmx act according to instructions. Throws the error:
root@ubuntu:/superset/superset/assets# yarn
yarn install v1.2.1
warning You are using Node "4.2.6" which is not supported and may encounter bugs or unexpected behavior. Yarn supports the following semver range: "^4.8.0 || ^5.7.0 || ^6.2.2 || ^8.0.0"
info No lockfile found.
[1/4] Resolving packages...
warning brfs > static-module > through2 > xtend ><EMAIL_ADDRESS>warning react-map-gl > mapbox-gl ><EMAIL_ADDRESS>This module has moved: please install @mapbox/point-geometry instead
warning react-map-gl > mapbox-gl > vt-pbf ><EMAIL_ADDRESS>This module has moved: please install @mapbox/point-geometry instead
warning react-map-gl > mapbox-gl ><EMAIL_ADDRESS>This module has moved: please install @mapbox/vector-tile instead
warning react-map-gl > mapbox-gl > vt-pbf ><EMAIL_ADDRESS>This module has moved: please install @mapbox/vector-tile instead
warning react-map-gl > mapbox-gl > geojson-rewind ><EMAIL_ADDRESS>This module is now under the @mapbox namespace: install @mapbox/geojson-area instead
warning github-changes > parse-link-header > xtend ><EMAIL_ADDRESS>Please update to the latest object-keys
warning github-changes > github-commit-stream > request ><EMAIL_ADDRESS>Use uuid module instead
[2/4] Fetching packages...
error<EMAIL_ADDRESS>The engine "node" is incompatible with this module. Expected version ">=6.4.0".
error Found incompatible module
root@ubuntu:/superset/superset/assets# yarn run build
yarn run v1.2.1
warning You are using Node "4.2.6" which is not supported and may encounter bugs or unexpected behavior. Yarn supports the following semver range: "^4.8.0 || ^5.7.0 || ^6.2.2 || ^8.0.0"
$ NODE_ENV=production webpack --colors --progress
error Couldn't find the binary NODE_ENV=production webpack --colors --progress
Tell me, this procedure must be run after each edit of the sources?

@xrmx thank you for the tip! It worked for me!
Tell me, this procedure must be run after each edit of the sources?
It is long enough. How then to debug your code?

npm run dev will watch the files for modifications and re-compile as you edit

@mistercrunch I'm attempting to edit files such as static/assets/src/actions.js, just simple edits such as success alerts. I've rebuilt and cleared my cache, but the changes still don't register in the browser. You mentioned npm run dev is this a prerequisite to seeing the changes or does this just make it quicker to view the changes?


No versioning of sources on browse sources page

In v4.0, we have a concept of versioning for sources (see below)
However, here we don't have the same concept of versioning.

Consider adding versioning to top right of source in v5 as in v4


Fix *-parameter check for method definition

Fixes #2006
One check is added in trees hierarchy to ensure structure is consistent and if anyone uses trees somewhere else this bad state will throw exception.
Let's say "duplicated check" is done in ScalametaParser to provide proper feedback for the user(same as compiler would generate).
(that's why 2 similar checks, I don't know have vision how to have only one check)
Also I added 1 test that should throw error for scala 2 but should be valid for scala 3, do we have a way to determine in test specific scala version?

To show you this in action, unsaved file is parsed by ScalametaParser, saved file error is reported by scala compiler.
Both report the same error in the same place. You can see how it looks with your current metals.


Panic when Yul mapping fails; print friendly message when fe panics

What was wrong?
A yul mapping failure is indicative of a bug in the compiler, but the yul mappers were returning Result types. Fixes #168.
How was it fixed?
Yul mappers now all panic on failure. I also added a panic hook to log the following message when fe panics:
You've hit an internal compiler error. This is a bug in the Fe compiler.
Fe is still under heavy development, and isn't yet ready for production use.

If you would, please report this bug at the following URL:
  https://github.com/ethereum/fe/issues/new

To-Do

[ ] OPTIONAL: Update Spec if applicable

[x] Add entry to the release notes (may forgo for trivial changes)

[x] Clean up commit history

Codecov Report

Merging #327 (935b1b4) into master (3a7fa34) will decrease coverage by 0.31%.
The diff coverage is 57.77%.

@@            Coverage Diff             @@
##           master     #327      +/-   ##
==========================================
- Coverage   92.95%   92.63%   -0.32%
==========================================
  Files          56       56
  Lines        3860     3871      +11
==========================================
- Hits         3588     3586       -2
- Misses        272      285      +13

Impacted Files
Coverage Δ

compiler/src/errors.rs
23.52% <0.00%> (-16.48%)
:arrow_down:

compiler/src/yul/mappers/assignments.rs
75.00% <66.66%> (ø)

compiler/src/yul/operations/abi.rs
94.02% <66.66%> (+1.38%)
:arrow_up:

compiler/src/yul/mappers/expressions.rs
90.19% <80.00%> (-0.19%)
:arrow_down:

compiler/src/lib.rs
90.00% <100.00%> (ø)

compiler/src/yul/mappers/functions.rs
100.00% <100.00%> (ø)

compiler/src/yul/mappers/module.rs
78.57% <100.00%> (ø)

compiler/src/yul/mod.rs
100.00% <100.00%> (ø)

compiler/src/yul/runtime/functions/contracts.rs
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a7fa34...935b1b4. Read the comment docs.


Fixing Routing Issue: 136

The RegEx inline constraint doesn't take care of Escape characters.

@rynowak @yishaigalatzer -- Please have a look.

:watch:

@rynowak I have incorporated the comments.

:watch: almost done here, still looking for one more test (see comment)

@rynowak -- I have added the test case. Look for CreateTemplate_InlineConstraint_Regex_Malformed().

:shipit:

checked in with 4e5fc2e2dd4f7dd7a8c2fd8a936f6b2a002a1078


Removing contentView accessor - fix for keyboard access crash

I'm not certain if there are any unintended side effects of the change.  I'd prefer a fix where contentView was renamed to popoverContentView and is called explicitly.

Do you mean making popoverContentView into an exposed property of SFBPopoverWindow to act as a wrapper around contentView?
From my understanding, the contentView setter must be overridden, and the getter cannot be. The contentView getter is not being explicitly called anywhere that I can find.

I integrated these changes.  Thanks!


Support runtime credential configuration

Allow the use of a {:system, "ENV_VAR"} tuple in config to allow for reading from the system env at run time, I think this should address #7

👍 thanks


can you create example ?

please

My appologies for the delay - I have added the sample now. Please feel free to contact me in case you face any issues - gauravkatoch007 [AT] gmail [dot] com