Error with nested_model() options

Hi!!!
If I try to use nested_model() with the collect_marginals and equilibrate options I have an error:

UnboundLocalError                         Traceback (most recent call last)
 in
----> 1 nested_model(data, collect_marginals=True, equilibrate=True)
~/opt/anaconda3/envs/scanpy/lib/python3.7/site-packages/schist/inference/_nested_model.py in nested_model(adata, max_iterations, epsilon, equilibrate, wait, nbreaks, collect_marginals, niter_collect, hierarchy_length, deg_corr, multiflip, fast_model, n_init, beta_range, steps_anneal, resume, restrict_to, random_seed, key_added, adjacency, neighbors_key, directed, use_weights, prune, return_low, copy, minimize_args, equilibrate_args)
285                                                mcmc_equilibrate_args=equilibrate_args,
286                                                niter=steps_anneal,
--> 287                                                beta_range=beta_range)
288     if collect_marginals and equilibrate:
289         # we here only retain level_0 counts, until I can't figure out
~/opt/anaconda3/envs/scanpy/lib/python3.7/site-packages/graph_tool/inference/mcmc.py in mcmc_anneal(state, beta_range, niter, history, mcmc_equilibrate_args, verbose)
264         else:
265             S = ret[0]
--> 266             attempts += ret[1]
267             nmoves += ret[2]
268
UnboundLocalError: local variable 'attempts' referenced before assignment
I have no problem if i just use nested_model(data).
Thanks!

It seems an issue related to graph-tool, which version are you using?

I'm using the 2.29 version. I just finished running the function after patching graph-tool as you mention in the schist installation session and it works. But now I have problems with schist.tl.draw_graph():

AttributeError                            Traceback (most recent call last)
 in
----> 1 schist.tl.draw_graph(data)
~/opt/anaconda3/envs/scanpy/lib/python3.7/site-packages/schist/tools/_draw_graph.py in draw_graph(adata, layout, use_tree, random_seed, adjacency, key_added_ext, key, copy, **kwds)
117         positions = np.array([x for x in positions][:n_cells])
118     elif layout == 'sfdp':
--> 119         positions = gt.sfdp_layout(g)
120         positions = np.array([x for x in positions][:n_cells])
121     elif layout == 'arf':
AttributeError: module 'graph_tool.all' has no attribute 'sfdp_layout'
The same with fruchterman_reingold_layout

As for the version, I should add a strict dependency to >=graph-tool=2.30.
I cannot reproduce the error for layout, instead. What if you type:
>>> import graph_tool.all as gt
>>> gt.sfdp_layout

Do you get an error?

Yes

AttributeError                            Traceback (most recent call last)
 in
----> 1 gt.sfdp_layout
AttributeError: module 'graph_tool.all' has no attribute 'sfdp_layout'

Mmm, could you try to update to graph-tool>=2.30?
conda install -c conda-forge graph-tool=2.30

(we will update dependecies to 2.33 as it introduces a new model which would be great to introduce)


performance of pre-processing hugectr request of nvt python backend needs improvement

When doing inference with triton, pre-processing hugectr request of nvt python backend performance is poor. Can you please improve it?

We're working on this.  Will let you know when there's an update.


Is there any way to create Table or Grid chart using this library?

Provide ECharts demo

I didn't find any example chart in echarts. I am looking for something similar to DataView in Echarts.
https://echarts.apache.org/examples/en/editor.html?c=pie-roseType-simple


Display bug for divider on chrome canary

Can't seem to find a similar issue, but this is how vertical dividers are being displayed for me on chrome canary. (52.0.2722.0)

Chrome stable, firefox, etc. show the expected result.

The damn canary is chirping.
I really dont know, looks like position: relative isnt being respected. Thank god they fix bugs before stable :wink:

Just fyi, https://bugs.chromium.org/p/chromium/issues/detail?id=618423#c5

This bug should be reopened -- Chrome made a change to follow the current spec. MS Edge already implements the new behavior, and Firefox will follow. It would be best if Semantic updated the code to work with the new behavior (it may be helpful to use width:0 instead of position:absolute)
From the Chrome bug:
"""
This is position: absolute, not relative.
We have updated our implementation to match the spec. absolutely-positioned elements are now positioned according to the spec:
https://drafts.csswg.org/css-flexbox/#abspos-items
"""

👍🏻

@jlukic This is still biting in 54.0.2817.0 canary with chromium not planning on fixing this.

@jlukic Quick update, this bug is now present on all latest channels of chrome including stable.

Also facing this bug. Are there any easy work-arounds?

Im having the same issue when testing on Edge. The issue seems to originate in /definitions/elements/divider.less, as best I can tell anyhow
/*--------------
    Coupling
---------------*/

/* Allow divider between each column row */
.ui.grid > .column + .divider,
.ui.grid > .row > .column + .divider {
    left: auto;
}

when {left:auto} is removed everything seems to be in the right place via edge, chrome, & ff. Not sure what else it will have an effect on or how best to override it yet. Perhaps someone can confirm and come up with a solution.

Not sure what the resolution is here, but my quick fix is to add the 'centered' class to the parent grid. This works for me with a single vertical divider (two or more will collapse onto each other).
Removing the left: auto rule allows vertical divider to display correctly in Chrome but creates the issue in FF. Hopefully a solution arrives soon.

That's interesting. I'm running Firefox 47 on Linux Mint and it had no negative effect when I removed left: auto; however, it did properly position the divider in Edge on Windows 10 and Chrome (Version 52.0.2743.116 (64-bit)) on Linux Mint. I double checked.

That's interesting. For me, removing left: auto in FF (build 47 on Linux Mint) had no negative effect; however, in Edge on Windows 10 and Chrome (Version 52.0.2743.116 (64-bit)) on Linux Mint) the divider was now positioned properly.

https://github.com/w3c/csswg-drafts/issues/401
and
https://bugs.chromium.org/p/chromium/issues/detail?id=633011

Merging into #4342.


Added wander/wanderUnordered to Task.

This should satisfy Issue #249.
I ended up modifying the backing implementation of TaskGather to requiring multiple CanBuildFroms for gatherUnordered.
I added a first pass at the Scaladoc, based heavily on the Scaladoc for gather(unordered).
Let me know if there's any questions/comments/concerns.
-Matt

Current coverage is 85.40% (diff: 100%)

Merging #267 into master will decrease coverage by 0.06%

@@             master       #267   diff @@
==========================================
  Files           254        254
  Lines          7728       7734     +6
  Methods        6104       6107     +3
  Messages          0          0
  Branches       1522       1525     +3
==========================================
  Hits           6605       6605
- Misses         1123       1129     +6
  Partials          0          0

Powered by Codecov. Last update 2e9e545...fe6edfe

Thanks @mutantmell - version 2.1 is already released on Maven Central, your PR will make it in the next release.


x/pkgsite: linking to source code in GitHub Enterprise Server

#40477 suggests that we ask for new internal.source.patterns to support new code hosts.
We are using GitHub Enterprise Server which is hosted in a github.* domain. Currently, pkgsite is unable to resolve code from these repos because it only matches github.com: https://go.googlesource.com/pkgsite/+/5c86378aae4c9aeaf522db7e0a3b312d079f8c3e/internal/source/source.go#638
There is an existing model of self-hosted code repositories illustrated by gitlab.*. I suggest that we add something similar:
	{
		// Assume that any site beginning with "github." works like github.com.
		pattern:   `^(?P<repo>github\.[a-z0-9A-Z.-]+/[a-z0-9A-Z_.\-]+/[a-z0-9A-Z_.\-]+)(\.git|$)`,
		templates: githubURLTemplates,
	},

The downside to this approach is that people using other domain names will not be supported by this pattern, but I suspect the vast majority of people running GitHub Enterprise Server are using the github. subdomain.

Sounds reasonable.

Can you give me a URL to a file for testing? (We will hit it once and then record it for future tests, so the traffic will be minimal.)

@jba Sorry, we don’t expose our GitHub Enterprise instance to the world, nor do we expose our Pkg.go.dev instance, because of corporate reasons. :slightly_frowning_face:
However, I have applied your patch and used go run ./devtools/cmd/seeddb -seed internal-repos.txt -refetch to refetch everything in our database.
I can confirm that the Repository URL is now being properly detected.

:shipit: :tada:


Tasks910-916: Bianet and Imppres

@gkaramanolakis wondering if you can review this PR?

Hi @mirror3, below are some comments:

Pls make sure to merge your branch with the main branch and make task names in the README consistent with the JSON filenames.
In task910_bianet_classification.json, the "Negative Examples" field should not have instances with "No" label (which is the right label) but instead should be instances that have been assigned a wrong label. For example, it should be one instance for which the assigned label is "Yes" while it should be "No" (and the reverse).
Please write more descriptive task names in README to differentiate them. For example, instead of having task793_bianet_classification and task795_bianet_classification, you could have task793_bianet_correct_translation_classification and task795_bianet_language_classification. Also, task798_naturalLanguageInference should be marked as a classification task, e.g., task798_imppres_nli_classification. (Of course, task numbers should be fixed.)
Please improve the descriptions of the following tasks to make sure they're syntactically and grammatically correct and capitalize language names. Here are suggestions for new descriptions:

"Classifying whether two sentences are translations of each other"
"Generating a translation of an English sentence into Kurdish"
"Classifying a given sentence into English or Kurdish"
"Generating a translation of a Kurdish sentence into Turkish"
"Given a premise and a hypothesis, determine if the premise-to-hypothesis entailment is positive, negative or neutral"

task915_imppres_longTextGeneration.json looks too artificial and somewhat weird: there are many examples for which, in contrast to the task definition, it looks like the generated hypothesis is not derived from the premise. Consider, for example, the following instance from the file: "input" (premise): "The five waiters that approached Paul depart.", "output" (hypothesis): "There are exactly five waiters that approached Paul.". The output should not necessarily be derived from the input. Also, all examples look very similar to each other to the extent that a simple rule-based approach could achieve great performance on this task. If you don't have ideas on how to make this specific task more natural, you could remove it.

Thanks!

Please make sure to set the "Categories": [""] and "Domains": [""] fields according to the taxonomy presented here.

Reviews: https://github.com/swarooprm/CSE576HW/pull/80


Accepting a function completion duplicates it when using auto_insert

Thank you for the plugin!
Although it's early, it's almost a perfect replacement for cmp for me.
I've been hitting this issue when accepting completions for functions:
https://github.com/user-attachments/assets/91605a21-1a78-4af9-b8f4-39e58b125afa
I tried setting insertReplaceSupport=false, is it related to that somehow?
Thank you!
Config: https://github.com/3rd/config/blob/c869af41ab08470fdc169b7873a94c0ae130faff/dotfiles/nvim/lua/modules/completion/blink.lua

Can confirm that I also have the issue

It seems to happen with regular snippets (non-LSP) as well.

Thank you!

Sorry to comment on a closed issue, but I've found that the issue persists on some instances, example images below:
When attempting to complete className from the LSP it is initially correctly displayed as an option, all good so far:

When selecting, then the text is correctly auto inserted, however, the cursor lands after the second quote instead of in between both quotes (unsure if this is an issue at all, just wanted to point it out):

When accepting the option, it proceeds to double the input it should initially produce, however, it correctly positions the cursor in between the last double quotes as shown here:

I'm unsure if I have configured the plugin wrong in any way, but I have confirmed I am on the latest update and I believe I've followed all documentation and instructions.
Brilliant plugin by the way, highly appreciated!!!
My blink.cmp config for reference
local M = {
  "saghen/blink.cmp",
  lazy = false, -- lazy loading handled internally
  -- WARNING
  -- DISABLE
  enabled = true,
  -- optional: provides snippets for the snippet source
  dependencies = {
    { "rafamadriz/friendly-snippets", lazy = true },
    { "onsails/lspkind-nvim", lazy = true },
  },

  -- use a release tag to download pre-built binaries
  -- OR build from source, requires nightly: https://rust-lang.github.io/rustup/concepts/channels.html#working-with-nightly-rust
  build = "cargo build --release",
  -- On musl libc based systems you need to add this flag
  -- build = 'RUSTFLAGS="-C target-feature=-crt-static" cargo build --release',
}

function M.config()
  local ui = require("config.ui")
  local lspkind = require("lspkind")
  local blink = require("blink.cmp")

  lspkind.init({
    mode = "symbol_text",
    preset = "default",
    symbol_map = {
      Text = " ",
      Method = "󰆧 ",
      Function = "󰆧 ",
      Constructor = "󰆧 ",
      Field = " ",
      Variable = " ",
      Class = " ",
      Interface = " ",
      Module = "󰅩 ",
      Property = " ",
      Unit = " ",
      Value = " ",
      Enum = " ",
      Keyword = " ",
      Snippet = " ",
      Color = " ",
      File = " ",
      Reference = " ",
      Folder = " ",
      EnumMember = " ",
      Constant = "",
      Struct = " ",
      Event = " ",
      Operator = " ",
      TypeParameter = " ",
    },
  })

  ---@module 'blink.cmp'
  ---@type blink.cmp.Config
  local opts = {
    -- for keymap, all values may be string | string[]
    -- use an empty table to disable a keymap
    keymap = {
      show = "<C-space>",
      hide = "<C-space>",
      accept = {},
      select_and_accept = "<CR>",
      select_prev = { "<S-Tab>", "<Up>", "<C-p>" },
      select_next = { "<Tab>", "<Down>", "<C-n>" },

      show_documentation = "<C-k>",
      hide_documentation = "<C-k>",
      scroll_documentation_up = "<C-d>",
      scroll_documentation_down = "<C-f>",

      snippet_forward = "<Tab>",
      snippet_backward = "<S-Tab>",
    },

    accept = {
      create_undo_point = false,
      auto_brackets = {
        enabled = false,
        default_brackets = { "(", ")" },
        override_brackets_for_filetypes = {},
        -- Overrides the default blocked filetypes
        force_allow_filetypes = {},
        blocked_filetypes = {},
        -- Synchronously use the kind of the item to determine if brackets should be added
        kind_resolution = {
          enabled = true,
          blocked_filetypes = { "typescriptreact", "javascriptreact", "vue" },
        },
        -- Asynchronously use semantic token to determine if brackets should be added
        semantic_token_resolution = {
          enabled = true,
          blocked_filetypes = {},
          -- How long to wait for semantic tokens to return before assuming no brackets should be added
          timeout_ms = 400,
        },
      },
    },

    trigger = {
      completion = {
        -- regex used to get the text when fuzzy matching
        -- changing this may break some sources, so please report if you run into issues
        -- todo: shouldnt this also affect the accept command? should this also be per language?
        keyword_regex = "[%w_\\-]",
        -- LSPs can indicate when to show the completion window via trigger characters
        -- however, some LSPs (*cough* tsserver *cough*) return characters that would essentially
        -- always show the window. We block these by default
        -- blocked_trigger_characters = { " ", "\n", "\t" },
        blocked_trigger_characters = {},
        -- when true, will show the completion window when the cursor comes after a trigger character when entering insert mode
        show_on_insert_on_trigger_character = true,
        -- list of additional trigger characters that won't trigger the completion window when the cursor comes after a trigger character when entering insert mode
        -- show_on_insert_blocked_trigger_characters = { "'", '"' },
        show_on_insert_blocked_trigger_characters = {},
      },

      signature_help = {
        enabled = false,
        blocked_trigger_characters = {},
        blocked_retrigger_characters = {},
        -- when true, will show the signature help window when the cursor comes after a trigger character when entering insert mode
        show_on_insert_on_trigger_character = true,
      },
    },

    fuzzy = {
      -- frencency tracks the most recently/frequently used items and boosts the score of the item
      use_frecency = true,
      -- proximity bonus boosts the score of items with a value in the buffer
      use_proximity = true,
      max_items = 200,
      -- controls which sorts to use and in which order, these three are currently the only allowed options
      sorts = { "label", "kind", "score" },

      prebuiltBinaries = {
        -- Whether or not to automatically download a prebuilt binary from github. If this is set to `false`
        -- you will need to manually build the fuzzy binary dependencies by running `cargo build --release`
        download = true,
        -- When downloading a prebuilt binary force the downloader to resolve this version. If this is uset
        -- then the downloader will attempt to infer the version from the checked out git tag (if any).
        --
        -- Beware that if the FFI ABI changes while tracking main then this may result in blink breaking.
        forceVersion = nil,
      },
    },

    sources = {
      -- similar to nvim-cmp's sources, but we point directly to the source's lua module
      -- multiple groups can be provided, where it'll fallback to the next group if the previous
      -- returns no completion items
      -- WARN: This API will have breaking changes during the beta
      providers = {
        { "blink.cmp.sources.lsp", name = "LSP" },
        { "blink.cmp.sources.path", name = "Path", score_offset = 3 },
        { "blink.cmp.sources.snippets", name = "Snippets", score_offset = -3 },
        { "blink.cmp.sources.buffer", name = "Buffer", fallback_for = { "LSP" } },
        -- -- FOR REF: full example
        -- -- all of these properties work on every source
        -- {
        --   "blink.cmp.sources.lsp",
        --   name = "LSP",
        --   keyword_length = 0,
        --   score_offset = 0,
        --   trigger_characters = { "", "c", "o", "o" },
        -- },
        -- -- the following two sources have additional options
        -- {
        --   "blink.cmp.sources.path",
        --   name = "Path",
        --   score_offset = 3,
        --   opts = {
        --     trailing_slash = false,
        --     label_trailing_slash = true,
        --     get_cwd = function(context)
        --       return vim.fn.expand(("#%d:p:h"):format(context.bufnr))
        --     end,
        --     show_hidden_files_by_default = true,
        --   },
        -- },
        -- {
        --   "blink.cmp.sources.snippets",
        --   name = "Snippets",
        --   score_offset = -3,
        --   -- similar to https://github.com/garymjr/nvim-snippets
        --   opts = {
        --     friendly_snippets = true,
        --     search_paths = { vim.fn.stdpath("config") .. "/snippets" },
        --     global_snippets = { "all" },
        --     extended_filetypes = {},
        --     ignored_filetypes = {},
        --   },
        -- },
        -- {
        --   "blink.cmp.sources.buffer",
        --   name = "Buffer",
        --   fallback_for = { "LSP" },
        -- },
      },
    },

    windows = {
      autocomplete = {
        min_width = 15,
        max_height = 10,
        border = ui.border.Single,
        winhighlight = "Normal:BlinkCmpMenu,FloatBorder:BlinkCmpMenuBorder,CursorLine:BlinkCmpMenuSelection,Search:None",
        -- keep the cursor X lines away from the top/bottom of the window
        scrolloff = 2,
        -- which directions to show the window,
        -- falling back to the next direction when there's not enough space
        direction_priority = { "s", "n" },
        -- Controls how the completion items are selected
        -- 'preselect' will automatically select the first item in the completion list
        -- 'manual' will not select any item by default
        -- 'auto_insert' will not select any item by default, and insert the completion items automatically when selecting them
        selection = "auto_insert",
        -- Controls how the completion items are rendered on the popup window
        -- 'simple' will render the item's kind icon the left alongside the label
        -- 'reversed' will render the label on the left and the kind icon + name on the right
        -- 'minimal' will render the label on the left and the kind name on the right
        -- 'function(blink.cmp.CompletionRenderContext): blink.cmp.Component[]' for custom rendering
        draw = "simple",
        -- Controls the cycling behavior when reaching the beginning or end of the completion list.
        cycle = {
          -- When `true`, calling `select_next` at the *bottom* of the completion list will select the *first* completion item.
          from_bottom = true,
          -- When `true`, calling `select_prev` at the *top* of the completion list will select the *last* completion item.
          from_top = true,
        },
      },
      documentation = {
        min_width = 10,
        max_width = 60,
        max_height = 20,
        border = ui.border.Single,
        winhighlight = "Normal:BlinkCmpDoc,FloatBorder:BlinkCmpDocBorder,CursorLine:BlinkCmpDocCursorLine,Search:None",
        -- which directions to show the documentation window,
        -- for each of the possible autocomplete window directions,
        -- falling back to the next direction when there's not enough space
        direction_priority = {
          autocomplete_north = { "e", "w", "n", "s" },
          autocomplete_south = { "e", "w", "s", "n" },
        },
        auto_show = true,
        auto_show_delay_ms = 0,
        update_delay_ms = 0,
      },
      signature_help = {
        min_width = 1,
        max_width = 100,
        max_height = 10,
        border = "padded",
        winhighlight = "Normal:BlinkCmpSignatureHelp,FloatBorder:BlinkCmpSignatureHelpBorder",
      },
    },

    -- highlight = {
    --   ns = vim.api.nvim_create_namespace("blink_cmp"),
    --   -- sets the fallback highlight groups to nvim-cmp's highlight groups
    --   -- useful for when your theme doesn't support blink.cmp
    --   -- will be removed in a future release, assuming themes add support
    --   use_nvim_cmp_as_default = false,
    -- },
    --
    -- -- set to 'mono' for 'Nerd Font Mono' or 'normal' for 'Nerd Font'
    -- -- adjusts spacing to ensure icons are aligned
    -- nerd_font_variant = "normal",

    kind_icons = {
      Text = "󰉿",
      Method = "󰊕",
      Function = "󰊕",
      Constructor = "󰒓",

      Field = "󰜢",
      Variable = "󰆦",
      Property = "󰖷",

      Class = "󱡠",
      Interface = "󱡠",
      Struct = "󱡠",
      Module = "󰅩",

      Unit = "󰪚",
      Value = "󰦨",
      Enum = "󰦨",
      EnumMember = "󰦨",

      Keyword = "󰻾",
      Constant = "󰏿",

      Snippet = "󱄽",
      Color = "󰏘",
      File = "󰈔",
      Reference = "󰬲",
      Folder = "󰉋",
      Event = "󱐋",
      Operator = "󰪚",
      TypeParameter = "󰬛",
    },
  }

  blink.setup(opts)
end

return M

Thanks! Sounds like there's still edge cases so I'll keep it open. And yeah, I also thought about correctly position the cursor but didn't get around to it

I'm hitting a few other edge cases:

for 1 character snippets, accept doesn't close the menu
accepting any other kind of item clears the current text - 2 but doesn't insert the accepted completion

https://github.com/user-attachments/assets/a9823477-2627-448e-8759-2fbad59ef004

I've had simmillar problem with nvim-cmp, try setting vim.opt.completeopt = '' in your config

Doesn't fix it for me, but something like this does:

But I'm sure it's the wrong way to do it.

Latest commits place the cursor at the first tab stop, fix 1 char snippets not closing the menu on accept and many remaining duplication cases. Closing again, but feel free to re-open if there's more issues

Just tested it and it works perfectly, thank you so much!


positional argument for path instead of working directory

Codecov Report
Attention: 152 lines in your changes are missing coverage. Please review.

Comparison is base (baf356d) 36.14% compared to head (0531518) 48.52%.

Files
Patch %
Lines

pkg/advent/downloader.go
56.68%
67 Missing and 14 partials :warning:

pkg/advent/benchmarker.go
46.77%
33 Missing :warning:

pkg/advent/tester.go
47.61%
11 Missing :warning:

pkg/tasks/tasks.go
79.59%
6 Missing and 4 partials :warning:

pkg/advent/solver.go
86.36%
6 Missing :warning:

pkg/krampus/krampus.go
92.10%
5 Missing and 1 partial :warning:

pkg/advent/advent.go
83.33%
3 Missing :warning:

pkg/runners/pythonRunner.go
0.00%
2 Missing :warning:

Additional details and impacted files
@@             Coverage Diff             @@
##             main      #60       +/-   ##
===========================================
+ Coverage   36.14%   48.52%   +12.38%
===========================================
  Files          21       23        +2
  Lines        1793     1488      -305
===========================================
+ Hits          648      722       +74
+ Misses       1117      720      -397
- Partials       28       46       +18

Flag
Coverage Δ

Linux
48.52% <67.09%> (+12.24%)
:arrow_up:

Windows
?

macOS
?

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Norm book fails to build in Docker

Hi!
I couldn't find a better description for the problem I'm having. I hope you'll help me debug the issue.
So I have a book for Norm: https://github.com/moigagoo/norm/tree/develop/book
This used to build on CI but fails now. I tried building it locally, and it works on my Linux. But in Docker, I'm getting this weird error that apparently has to do JsCode compilation.
The weird part is that I'm random getting errors with random files. Sometimes it's config.nim, sometimes it's customDatatypes.nim, sometimes it's rows.nim. Common thing about them is that they both import tutorial/tables.nim.
Here's an example of an error I'm getting:

Error: unhandled exception: cannot open file stream: tutorial/rows.log [IOError]

This particular one occurs on the CI: https://github.com/moigagoo/norm/actions/runs/3673639930/jobs/6210939015#step:3:539
This makes me think there's a race happening. Since the pages are build concurrently, this sounds like a reasonable hypothesis.

There is an issue with nimibook parallel builds and indeed with scinim/getting-started we used a previous commit. This should be an issue in nimibook instead of nimib. At the moment I can't but I later I can point you to exact issue and the commit to refer to (unless you find it yourself :)). As far as I understand this issue comes up when there is an actual failure and hides the error message for the failure.

Here is the PR in scinim that uses a previous commit in nimibook: https://github.com/SciNim/getting-started/pull/50 Inwould suggest you do the same for Norm. We should then fix the issue and make another release (actually before that I probably should make a release reverting the async commit)

Thanks for the quick response! That helped.


ci: move semver-checks to its own job

This is necessary because it needs to run only on pull_request, and not on push events.
Closes #2968.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 82.943%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
19504

Relevant Lines:
23515

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 82.943%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
19504

Relevant Lines:
23515

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 82.943%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
19504

Relevant Lines:
23515

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

0 of 0   changed or added relevant lines in 0 files are covered.
18 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.007%) to 82.936%

Files with Coverage Reduction
New Missed Lines
%

units/src/weight.rs
18
73.98%

Totals

Change from base Build<PHONE_NUMBER>:
-0.007%

Covered Lines:
19495

Relevant Lines:
23506

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 82.936%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
19495

Relevant Lines:
23506

💛  - Coveralls

This is necessary because it needs to run only on pull_request, and not on push events.

Why is this the claim please?

This is necessary because it needs to run only on pull_request, and not on push events.

Why is this the claim please?

From the issue #2968:

CI is passing for PRs but failing on master because it's failing to find a base branch.

https://github.com/rust-bitcoin/rust-bitcoin/issues/2968#issue-2392715676
This is because of https://github.com/rust-bitcoin/rust-bitcoin/blob/1c96da080ddf8fbeb742398bf835d1815ef00721/contrib/check-semver.sh#L22-L29

Why is this the claim please?

The issue is that it's triggering on pushes to master.
The push target isn't what gets run on force-pushes (except direct pushes to master I guess? which should never happen). The pull_request target is. Or maybe both targets get run in this case... I remember some "CI is running twice" optimization from many years ago related to this.

The push target isn't what gets run on force-pushes ... The pull_request target is

My bad, I was misunderstanding how those targets worked. Thanks, I rescind my concerns.

I see that we are missing docs from the workflows/README.md file for the original API job, which if it existed should have been updated as part of this PR. Since its missing we can do it as a follow up - I created #2975.

I see that we are missing docs from the workflows/README.md file for the original API job, which if it existed should have been updated as part of this PR. Since its missing we can do it as a follow up - I created #2975.

Yeah let's merge this since it has 3 ACKs ASAP so that we fix CI on master.
After that we'll update the README.


test-without-stubs: run go fmt and go vet

These are standard tools and it's good to ensure that we are in keeping
with their guidance.
In particular, note that we had a long-standing formatting inconsistency
in the binary exercise's test suite, only recently fixed via
bd156a4b2958e13212480d9755b5bb50b3abd5be. I've since discovered that
that inconsistency was introduced by me, in #274.
In addition, #317 was a problem reported by go vet. It seems good to
automatically check for those to prevent any similar errors.
Here is what happens if bob/example.go has yelling != nil added:
example.go:22: comparison of function yelling != nil is always true
please follow the 'go vet' suggestions in exercises/bob

Here is what happens if bob.go has a few extra spaces added:
please run 'go fmt' on exercises/bob

Oops, guess we can't run go vet with a different GOARCH. This will require a bit of messy business.

I saw two options:

Make test-without-stubs take an option to determine what it will do (fmt, vet, test). Have the travis runner pass GOARCH to test, but not to fmt or vet. Current solution.

Make test-without-stubs check its GOARCH and not run fmt and vet if GOARCH isn't amd64. But this is merely an artifact of our Travis setup, and it prevents anyone whose computer isn't amd64 from running test-without-stubs locally (without modification)

I'm sure there can be others, so if you know any, speak up.
One thing I don't like (but I don't hate either) is that go fmt and go vet are run for every entry in our build matrix, which probably isn't necessary. We can probably just have one entry that is just for fmt + vet, but is that necessary?

Final note: no golint in this PR, because we have a whole ton of golint output (most of it is uncommented exported items)

It looks like 1.4.3 can't use go vet. Might be time to cut it loose.

we can't run go vet with a different GOARCH

I'm not sure I understand what you mean here. I thought go vet was available on all of the platforms.

It looks like 1.4.3 can't use go vet. Might be time to cut it loose.

Yeah, I think it's totally fine to ditch 1.4.3.

no golint in this PR [...]

Yeah, I've run golint against everything a number of times and fixed some things, but adding comments was going to be a bigger task. Would it be worth creating issues for it and tagging them with good first task and hacktoberfest?

go fmt and go vet are run for every entry in our build matrix, which probably isn't necessary

Yeah, I don't feel to strongly about this one either, since the build is pretty quick. I haven't looked into how easy it would be to have something in the matrix that is just one set of tests. If it's not ridiculous I'd lean towards having a separate entry in the matrix for it.

we can't run go vet with a different GOARCH

I'm not sure I understand what you mean here. I thought go vet was available on all of the platforms.

Yeah I should have mentioned - here's what happens, at https://travis-ci.org/exercism/xgo/jobs/164369569 : we get
vet: import failed: can't find import: fmt
vet: import failed: can't find import: fmt

It looks like 1.4.3 can't use go vet. Might be time to cut it loose.

I would like to provide evidence of that claim: https://travis-ci.org/exercism/xgo/jobs/164373145
if go version | grep -q 1.4.3; then go get golang.org/x/tools/cmd/vet ; fi
package golang.org/x/tools/cmd/vet
	imports golang.org/x/tools/cmd/vet
	imports golang.org/x/tools/cmd/vet: cannot find package "golang.org/x/tools/cmd/vet" in any of:
	/home/travis/.gimme/versions/go1.4.3.linux.amd64/src/golang.org/x/tools/cmd/vet (from $GOROOT)
	/home/travis/gopath/src/golang.org/x/tools/cmd/vet (from $GOPATH)

I've run golint against everything a number of times and fixed some things, but adding comments was going to be a bigger task. Would it be worth creating issues for it and tagging them with good first task and hacktoberfest?

Sometimes I feel unsure about those "should have comment or be unexported" lints, since most of the exported things are what is being asked for in the problem. I sometimes wonder if we should have travis CI filter those out and only show the others.
I put all the golint suggestions at https://gist.github.com/petertseng/1bbaaa1e2fce8a2ae86a16801712b903 so we can take a look.

If it's not ridiculous I'd lean towards having a separate entry in the matrix for it.

I do plan to explore this and report here, so no need to consider merging this PR yet.

If it's not ridiculous I'd lean towards having a separate entry in the matrix for it.

OK, this is the way I have achieved it. Unfortunately, it was still necessary to specify a Go version, so I have to add a comment to keep it synced with the latest version. The consequence for not doing so is https://travis-ci.org/exercism/xgo/jobs/164830757 :
/home/travis/build.sh: line 339: export: `1.6.3,': not a valid identifier

/home/travis/build.sh: line 339: export: `1.5.4,': not a valid identifier

/home/travis/build.sh: line 339: export: `1.4.3,': not a valid identifier

/home/travis/build.sh: line 339: export: `tip]': not a valid identifier

12.06s$ GIMME_OUTPUT=$(gimme [1.7, "1.6.3", "1.5.4", "1.4.3", "tip"]) && eval "$GIMME_OUTPUT"

I don't have any idea what to do with '[1.7,'.

  (using type 'auto')

The command "GIMME_OUTPUT=$(gimme [1.7, "1.6.3", "1.5.4", "1.4.3", "tip"]) && eval "$GIMME_OUTPUT"" failed and exited with 1 during .

Just rebasing on master.

A minor annoyance about having vet/lint as a separate entry is that currently it is the last entry in the matrix since I am using matrix: include: for it. I'm not sure there's a way to fix that. And if it is the last entry, it gets run last, whereas I'd usually like to get feedback on vets and lints sooner than later.
Of course, I will run vet and lint locally on my machine before I submit any PRs, so this will not really be an issue for me locally. So if it's still worth it to keep them as a separate entry, then full speed ahead.

I think comments are addressed, it is useful to have ths in the face of incoming contributions, and we can always revert "travis: Use a separate entry for static checkers" if we don't like the separate entry.


Wrap / unwrap Ⓝ should be part of deposit / withdraw

People are confused on how to wrap / unwrap NEAR and should be more visible.
Solution:

[x] have deposit default to Ⓝ token and when depositing Ⓝ auto wrap _and_deposit.
[x] have withdraw default to Ⓝ and auto unwrap and withdraw

PR #13 fixes this :)


Update samples to showcases React functional style instead of, or in addition to classes.

I am trying to understand how  component that can trigger state change in the  in the real-world example done in the functional style with hooks. Current examples in the "example" directory appear to use class/oop style exclusively instead.

Will something like this give you a better idea? I have created a snack that you can checkout.
https://snack.expo.io/@nathanbeesley/alert-issue-with-ios


When upgrading an RKE2 v1.24/v1.23 imported cluster, the link in the banner does not redirect to the applicable upgrading section in the known issues and limitations page

Setup

Rancher version: v2.7-head https://github.com/rancher/rancher/commit/cd1a71624a94de993d471ce8a643cf4d2dbb75a6
Browser type & version: Chrome

Describe the bug

When upgrading an imported RKE2/K3s cluster, you get the following page:

When clicking the link, you get taken to the top of the known issues and limitations documentation. The issue here is that as a user, when I click the link, I am not expecting to get taken to the top of this page. The page itself has a section on Upgrading Hardened Clusters from v1.24.x to v1.25.x; I would expect to be taken directly there.
Since Rancher cannot determine if I am using a hardened cluster or not due to it being imported, it's up to me as the user to know if this section is applicable. However, it's still worthwhile to me being directed exactly to that section so I can understand if I have to proceed or not.
To Reproduce

In a terminal, setup a 3 node, RKE2 v1.24 cluster (I did 1 server, 2 agent nodes).
As a standard user, navigate to Rancher > Cluster Management > Import Existing.
Import the previously constructed RKE2 cluster; validate that the cluster and nodes come up as Active in Cluster Management and Cluster Explorer.
Edit the cluster configuration to update the K8s version to v1.25.
Attempt to upgrade and note the warning banner that appears.
Click the link and note you're taken to the top of the known issues and limitations page.

Result
I am taken to the top of the known issues and limitations page.
Expected Result

I should be redirected to the Upgrading Hardened Clusters from v1.24.x to v1.25.x of the RKE2 known issues and limitations page.

Currently no way to do this - waiting on this small docs change: https://github.com/rancher/rke2-docs/pull/65

/backport v2.7.2

Validated that this is addressed on v2.7-head https://github.com/rancher/rancher/commit/a841a9e101ae601a033fa8b39342ad4800c91d85.
ENVIRONMENT DETAILS

Rancher install: Docker
Rancher version: v2.7-head https://github.com/rancher/rancher/commit/a841a9e101ae601a033fa8b39342ad4800c91d85
Branch tested: release-2.7.2
Browser: Chrome

TEST RESULT

Scenario
Test Case
Result

1
As a standard user, attempt to upgrade an imported cluster and validate that the shared link specifically goes to the expected, applicable sub-section
:white_check_mark:

VALIDATION STEPS
Scenario 1

In a terminal, setup a 4 node, RKE2 v1.24 cluster (3 server nodes, 1 agent node).
As a standard user, navigated to Rancher > Cluster Management > Import Existing.
Imported the RKE2 cluster and validated that the cluster and nodes came up as Active in Cluster Management and Cluster Explorer.
Edited the cluster configuration to update the K8s version to v1.25.
Attempted to upgrade and validated that I see the following banner:

Clicked the link and was redirected to this section as expected:


MIS: Add better support for transmissive surfaces

Related to #120
With MIS light no longer looks like it passes through transmissive surfaces:

According to this page you can traverse multiple rays through transmissive surfaces to handle this (and even specular cases):
https://www.pbr-book.org/3ed-2018/Light_Transport_I_Surface_Reflection/Direct_Lighting#fragment-DirectLightingIntegratorPrivateData-1

find the light source and get the ray direction
if the hit object is transmissive or transparent then evaluate the attenuation from the hit (ignore refraction / attenuate PDF due to it)


Exec tachikoma update<PHONE_NUMBER>4606

:hamster::hamster::hamster:   Strategy none
Powered by Interval Pull Request as a Service - Tachikoma.io Announcement: 2015-06-28 Updated permissions - Tachikoma.io

Coverage remained the same at ?% when pulling dc0cd64604d9b934fd2fc899bff19b4d521c36a7 on pazjacket:tachikoma/update-20180206174606 into ddf31327ec9d3097b29bd6c49c1071d946319912 on sanemat:master.


Derive "param_hint" in errors from param itself

Rather than trying to apply the same logic to all param types, trying to extract a meaningful value from Parameter.opts even for Arguments, make this a function computed against the Parameter itself. Then, when it's time to specialize it to use the metavar for Arguments, we just need to override the function.
Also unify a small amount of logic being shared among exception classes.
Fully backwards compatible, except for the change to error text on Arguments, which is the intended effect.
Grabs a test out of #612 which checks that this works as intended.
Resolves #704, #598, and #612

+1


Workspace Settings TAB missing ??

Which Workspace Settings TAB are you referring about?

NO FOLDER OPENED

hmm. ok i seen "no folder opened" section then i select my folder, finally workspace settings appears to us :) thanks folks.


<EMAIL_ADDRESS>

ramda/ramda#1277
ramda/ramda#1290

:warning: R.match now returns [] rather than null when there are no matches ramda/ramda#1239

:dromedary_camel:


Installing from git (or a git snapshot) results in package version being 0

I've just noticed that when using git snapshots or the git repository itself, dirty-equals ends up being installed as version "0", e.g.:
$ pip install git+https://github.com/samuelcolvin/dirty-equals
Collecting git+https://github.com/samuelcolvin/dirty-equals
  Cloning https://github.com/samuelcolvin/dirty-equals to /tmp/pip-req-build-a0xri30s
  Running command git clone --filter=blob:none --quiet https://github.com/samuelcolvin/dirty-equals /tmp/pip-req-build-a0xri30s
  Resolved https://github.com/samuelcolvin/dirty-equals to commit 593bcccf738ab8b724d7cb860881d74344171f5f
  Installing build dependencies ... done
  Getting requirements to build wheel ... done
  Preparing metadata (pyproject.toml) ... done
Requirement already satisfied: pytz>=2021.3 in ./.venv/lib/python3.11/site-packages (from dirty-equals==0) (2022.1)
Building wheels for collected packages: dirty-equals
  Building wheel for dirty-equals (pyproject.toml) ... done
  Created wheel for dirty-equals: filename=dirty_equals-0-py3-none-any.whl size=23380 sha256=96b6eecea7fe5c51bc14f23929d3f6146e22344aff7c82749c96fb92c414218e
  Stored in directory: /tmp/pip-ephem-wheel-cache-qjkkipja/wheels/b9/a6/72/32198aa9ff0bfe14230160fbf92821af4a22179c61d55c7070
Successfully built dirty-equals
Installing collected packages: dirty-equals
Successfully installed dirty-equals-0

I've tried adding poetry-version-plugin into build-system.requires but that doesn't seem to help (beside pulling it tons of build-time dependencies).

Ye, we set the version in CI based on the tag:
https://github.com/samuelcolvin/dirty-equals/blob/593bcccf738ab8b724d7cb860881d74344171f5f/.github/workflows/ci.yml#L129
Which in turn calls https://gist.github.com/samuelcolvin/e49096dc93396be60d2e972e8799410d I don't really want to change this as I use similar logic for most projects and it avoids having to set the version in code before creating a release.

Happy to change the default value if there's something more sensible, but I don't see another solution.

Well, that sucks for us packagers but I guess it's not the end of the world.
I wish there was a way for this to either fail or at least emit verbose warning when the value's not updated. I've only noticed this because pip list --outdated listed the version as 0. In general, potential version problems like that are very hard to notice until something suddenly explodes for end users.

humm, ye I feel your pain.
I guess we could push to the repr on release to set the version in code - that would be neat generally. Though I guess it might not help if you use the version from the version tag?

As a minor request, could you please use the same version string both in __init__.py and pyproject.toml, to make the substitution easier for us?

I guess we could push to the repr on release to set the version in code - that would be neat generally. Though I guess it might not help if you use the version from the version tag?

Took me a while to figure it out but I guess you meant "push to the repo"? Yeah, that wouldn't help if you pushed after tagging. I guess it would be somewhat ugly but you could make the CI pipeline rewrite the tag though.

@mgorny worth noting you're going  to have even more problems with watchfiles where we do something similar, but have logic to convert a python style version to rust before editing Cargo.toml, then more logic to convert a rust style version back to python at runtime, see https://github.com/samuelcolvin/watchfiles/pull/159.
And also with pydantic-core where I will do something similar.

Just thinking about this, would it help if we edited pyproject.toml at the same time as __init__.py so at least the source and wheels on pypi were right?

@mgorny worth noting you're going to have even more problems with watchfiles where we do something similar, but have logic to convert a python style version to rust before editing Cargo.toml, then more logic to convert a rust style version back to python at runtime, see samuelcolvin/watchfiles#159.

Well, I'm just using sed to put the correct version into Cargo.toml there.

Should work fine except on pre-releases.

This should be fully fixed by #49 which sets the version in git properly.


Separate notes archive to non-toctree pages

Having notes archive in the main toctree led to a very long link,
which caused a messed up PDF build.
But also maybe the notes archive shouldn't be in the PDF build which
would be archived on Zenodo.
This makes a stub notes-archive page, which links (non-toctree)
links to the notes archive page (which still gets buildt, but not in
the toctree, which means not on the left sidebar)
The primary effect is that the archive from the 2024 workshop isn't
included in the PDF or singlehtml builds.  Which is probably how it
should be anyway.  A secondary effect is that there isn't a left
sidebar link directly to the 2024 notes (but there is to the page
that links them).

Review:

Confirm it's not in pdf or singlehtml
Confirm that this is the right choice to make for where it should be
visible.
Consider if the notes should be in a zenodo-archived git repo at all
(since the repo itself will be archived, right?).  I think it's
probably OK and consistent with the licenses we had said it would be
realesed under - right?

Thanks so much! Reviewing ...

generated pdf: https://github.com/coderefinery/train-the-trainer/blob/gh-pages/branch/rkdarst--separate-notes-archive/lesson.pdf


Minor Dependencies and Mapbox

Summary
Update minor and patch dependencies. Mapbox major update

Test plan

Coverage remained the same at 93.056% when pulling 7f3a220bdea1bbb8f1a07b653643681dece32777 on danactive/upgrade-map into fb66c1b68f833d4747191bc7aaf107661af8c7a0 on master.


CBOR object/array memory leak

destructuring parsed objects/arrays into top level without freeing parent oc_rep_t left memory leak. This has been cleaned up now.

yes it should, however due to the structure changes to the parser, top level obj/arr now have their elements emptied into the top level. If this happens the previous top level oc_rep_t containing them needs to be freed otherwise it's left allocated with no reference to it.

Which is why you're saving it before parsing! Makes sense now

~format


[as2_keyboard_teleoperation] Add ROS 2 parameters

Feature Description

[x] All settings parameters should be pass to the launcher through a config file.
[ ] #574
[ ] Add twist limit to parameters, and when using pose mode, add it.

Implementation Considerations
Use as2_core param utils for the launcher.

Hi @javilinos
This features would be nice to have:

Set initial mode (Pose or Speed) from config file
Set use_sim_time and verbose from config file


add auth schema with auth providers order

What this PR does / why we need it:
configure auth provider ordering explicitly by the user
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #470
Special notes for your reviewer:
Documentation:

Does this PR introduce a user-facing change?:

NONE

/retest

/retest

I've gone over the whole PR again. Please address the comment, I've left a few of my own. Afterward, I'll lgtm it; it's almost done except for a few nits/legibility here and there.

I think I've done all of them except defaulting webhook, as for now, we have only validation webhook? do you think it's a good idea to change it to defaulting webhook in this PR?

/retest

/retest

/retest

/retest

I'm still worried about validation and error handling. Currently, only in the kubecarrier CRD, the API server validation is being checked. Not in the API Server CRD, which the user can create, nor in the apiserver.Manifests resource generation.
What I'm suggesting is creating: func validateAPIServerSpec(*operatorv1alpha1.APIServerSpec) error and defaultAPIServerSpec(*operatorv1alpha1.APIServerSpec) error  helper functions which can and should be used in 3 places:
(maybe placing those functions close to the API definitions, or even make them member function for the operatorv1alpha1.APIServerSpec object? .Validate() error .Default() error)

Kubecarrier CRD webooks
API Server CRD webhooks  (this doesn't exists for now)
apiserver.Manifests function (especially here, since it's the last point before silent failure)

What do you think?
Otherwise, this is a great PR, well written, and tested!

I'm still worried about validation and error handling. Currently, only in the kubecarrier CRD, the API server validation is being checked. Not in the API Server CRD, which the user can create, nor in the apiserver.Manifests resource generation. If no/multiple auth options are specified per line in any one of those the failure shall be silent and ignored --> the most bite you in the ass type.

@nmiculinic The worrying is completely valid, and I agree that this may become an issue in the future, but for now I think it is fine. The reason are as following:

In the usecase that we offer KubeCarrier, users don't have permission to interact with operator API group, so this should be fine.
In the usercase that someone install KubeCarrier, and play around with it.  Mistakes in APIServerCRD and also in apiserver.Manifests will be kind of "ignored" , this is because KubeCarrier operator controller will reconcile the object with the default KubeCarrer config from CLI, and for that one we have a webhook to reject all mistakes.

I don't like to overcomplicate things, in our case users don't interact with APIserver configuration directly, so I don't think we need to add webhooks to apiserver operator. I will add defaulting webhook for KubeCarrier operator and I like the idea of Default and Validate methods for APIServiceSpec, will also do that. Later, if we decide to add webhooks for APIserver operator, we can easily use them

@aborilov , that's what I meant, adding APIserver webhooks is too much for this PR. Adding checks in apiserver.Manifests should be all I ask for. Those validate functions shall be called in two places -- kubecarrier webook and apiserver.Manifests and all is good!

@aborilov , that's what I meant, adding APIserver webhooks is too much for this PR. Adding checks in apiserver.Manifests should be all I ask for. Those validate functions shall be called in two places -- kubecarrier webook and apiserver.Manifests and all is good!

yep, that's done

/retest

/retest

/lgtm


fix GoogleCloudPlatform/cloudsql-proxy/157

improved error message when gcloud is missing.

Need more clean up.


Only show studio settings to admins

We need to implement a very basic user role, that will allow the user to open settings

The idea after the internal discussion is to store simple role information on the site document in the mongo for each installation. By default settings should be accessible without any role or password, however, as soon as the admin sets a password for settings GUI (in the settings global section), it will be required for the site (user) to have correct permission in the database.
Ideally, we should add the checkbox admin in the local settings, to keep it persistent, however when trying to turn it on, the user should be prompted for the admin password. That was it is possible for the admins to give temporary settings access to users by directly affecting this parameter in the database, even without disclosing the password to the user.
Note:
This is not supposed to be a secure feature at the moment but purely there for convenience of limiting admin tools to the correct users, with a little bit of barrier for the artists. Hence security consideration like are not a priority here. That will come once we implement user management properly.


Invalid Envs type inference

I've been doing some testing before cutting a new release and noticed a type inference issue with the new Envs implementation. It's possible to specify type parameters to Envs.run in a way to produces an invalid pending effect set:
def t1(v: Int < Envs[Int & String]) =
    Envs[Int].run[Int, Any, Nothing](1)(v)
val v: Int < Any = t1(42)

By specifying Nothing, other pending environment values are incorrectly removed from the pending set. I'll move forward with the release but we should find a way to avoid this issue and verify if other APIs could also be misused this way. I tried doing the same with the new Aborts but I couldn't reproduce it, I think because of Scala's custom rules for Nothing that don't apply to Any.
A potential fix would be making Envs contravariant like Aborts. Although that would preclude using union type environment values as @jiveshungerford has pointed out, I wonder if it could be a reasonable tradeoff to make the APIs more regular for newcomers so they don't need to learn and remember when to use type unions or intersections. I'd prefer to see all elements in the pending effect type parameter as as elements in sets rather than representing type signatures of actual values.
I've added a pending test for this bug: https://github.com/getkyo/kyo/commit/48dd95352e129033b6b562e6bd35870dc9d4e473

fixed by https://github.com/getkyo/kyo/pull/240


Makeability Lab website slow to load

Need to checkin with Jason (@mechanicjay) about it.
Updating with more search terms: lag, latency, slow load times.
Also related to https://github.com/makeabilitylab/makeabilitylabwebsite/issues/292

This continues to be an issue. Needs to be a priority once I find the time.

Ed Lazowska just emailed me and said the same thing:

makeabilitylab.cs.washington.edu takes forever to load, as do the
pages anchored by the tabs at the top of the page (Jon).

The machine that this docker container runs on currently has 24 cores, and 128G of RAM.
RAM is approximately 50% committed, load average on this box seems to hang out between .5 and 1.5
When running TOP on the host while loading webpages, I see the django process burning 100% cpu (One full core) and the postgres container burning about 20% of a core.
I believe this indicates some inefficiency in the code or perhaps the database routines.
As an addendum, this same hardware is running all the sidewalk instances.  Are you seeing performance issues there?  As another datapoint, I'm not seeing performance issues with the couple of apps I run for support on this system.

Thanks @mechanicjay. The code has been piecemealed together for years (since I was at UMD) so I'm not too surprised to hear that. :(
I'll have to investigate this over the summer when my time opens up a bit.

I'm going to do a little bit of db profiling to see if anything jumps out there we might be able to address for a quick win.

That would be awesome. Thanks!

Using the Sidewalk page as an example, The database is servicing a number of queries, mostly related to pulling back the associated people and papers associated.   Each of those queries is returned very quickly.  Additionally, I don't see any big queries holding up the works.  I hate to say it, but I think it's just a bottleneck in the front-end somewhere.

Ugh. Thanks for your help with this. I've not done frontend profiling before.
Just experimented with Chrome's profiler on our People page. Doesn't look awesome. But not necessarily for full source of delays.

We now have a Django profiler/debugger instead on makeabilitylab-test and localhost.
This is using the Django recommended django-debug-toolbar:

django-debug-toolbar is a very handy tool that provides insights into what your code is doing and how much time it spends doing it. In particular it can show you all the SQL queries your page is generating, and how long each one has taken.

In addition, I added some logging statements to track things on production, and it looks like calculating position roles like get_latest_position() in person.py is very slow.
For example, for ARMath, it took 0.076 secs to render the ARMath project page but 0.056 secs of that was calculating position roles (73%). Similarly, for HandSight, it took 0.25 secs to render the project page but 0.24 secs of that was calculating position roles (over 91%). For SoundWatch: rendered in 0.12 secs but 0.10 secs was position roles (85%) and so on.
It's bad on people page or anywhere else we call that method.

Django's webpage has lots of resources on how to speed things up. They caution the use of relying on caching when just better, more optimal code would work.

See the Performance and Optimization page
Adding a @cached_property decoratory might work well for us in some cases (like get_latest_position)

We are systematically shifting as many queries as possible to using Django ORM rather than Python-based filtering. Should have been doing that from the beginning.

Our pages are now far faster. I haven't fully converted all backend queries to ORM but we're close.
Some timings:

People page now loads in ~0.088 secs after rewriting backend queries and only showing images for current members
Landing page now loads in 0.033 secs with query optimization

Project pages still take too long. For example:

Project Sidewalk webpage takes 0.402 secs to render


7th Sphere

Is this precursor?

Hah yes it is. Who is this?
On Thu, Mar 30, 2023 at 2:12 AM J. Tan @.***> wrote:

Is this precursor?
—
Reply to this email directly, view it on GitHub
https://github.com/adamrandazzo/jrun-monitor/issues/1, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AB7UKIC5CUXSAHCNY5CR2WLW6UP5BANCNFSM6AAAAAAWMZ3EWE
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

I went by sinorev on Efnet / Undernet, though I don't think we crossed paths. I was an acquaintance of Rhad (Andrew) and got my start with Linux / C / everything in between during the golden years of IRC. Years ago, I saw one of your posts on 7thsphere.com about the accomplishments of the 7th Sphere team. I was hoping for a full write up because you guys were ahead of your time and branched out well beyond the script where it seemed everything started. As a contemporary, it was rewarding to see others making strides during a time when the internet was still something of a new frontier. Everyone's so technologically well connected now, but we were more engaged with far less.

That is awesome. I really don't have much insight as to what everyone is
doing these days who was involved with 7th Sphere.   A couple of my buddies from back then stuck with the security
industry.. one was at IOActive and now is at Bloomberg doing security
there.
My main thing these days is doing ecommerce development and integration. I
really enjoy it =)
On Fri, Mar 31, 2023 at 1:16 AM J. Tan @.***> wrote:

I went by sinorev on Efnet / Undernet, though I don't think we crossed
paths. I was an acquaintance of Rhad (Andrew) and got my start with Linux /
C / everything in between during the golden years of IRC. Years ago, I saw
one of your posts on 7thsphere.com about the accomplishments of the 7th
Sphere team. I was hoping for a full write up because you guys were ahead
of your time and branched out well beyond the script where it seemed
everything started. As a contemporary, it was rewarding to see others
making strides during a time when the internet was still something of a new
frontier. Everyone's so technologically well connected now, but we were
more engaged with far less.
—
Reply to this email directly, view it on GitHub
https://github.com/adamrandazzo/jrun-monitor/issues/1#issuecomment-1491309483,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AB7UKIC4WZC7D7J7YVQT4WLW6ZSDRANCNFSM6AAAAAAWMZ3EWE
.
You are receiving this because you commented.Message ID:
@.***>

Really sorry to hear about Andrew's passing. He was brilliant yet approachable at the same time. Reminds me of the type who becomes a professor because they genuinely enjoy teaching and sharing knowledge.
As I recall it, Andrew wrote a port scanner in MFC called "Click" that was bundled with the 7th Sphere installer. Eventually, he released the source code for all of the programs. This was a huge deal at the time ('99 or 2000?) and Andrew's code was outstanding, so I studied it and started incorporating what I learned into my own projects. One day, I sent him a private message for advice and he was totally cool about it. Went into detail about how the asynchronous socket class worked and why he used it instead of threads. I think he was at UMD College Park at this time. In any case, that made a huge impression on me.
It's awesome to hear that things are going well for you. I'm involved in a similar line of work (data integration, technical writing, and support) and it's enjoyable. If life ever slows down and you get a moment, please consider telling the story of 7th Sphere as you remember it. I believe that your perspective is especially valuable as it was a period of time when  anything seemed possible.

Send me an email: @.***
On Sun, Apr 9, 2023 at 1:23 AM J. Tan @.***> wrote:

Really sorry to hear about Andrew's passing. He was brilliant yet
approachable at the same time. Reminds me of the type who becomes a
professor because they genuinely enjoy teaching and sharing knowledge.
As I recall it, Andrew wrote a port scanner in MFC called "Click" that was
bundled with the 7th Sphere installer. Eventually, he released the source
code for all of the programs. This was a huge deal at the time ('99 or
2000?) and Andrew's code was outstanding, so I studied it and started
incorporating what I learned into my own projects. One day, I sent him a
private message for advice and he was totally cool about it. Went into
detail about how the asynchronous socket class worked and why he used it
instead of threads. I think he was at UMD College Park at this time. In any
case, that made a huge impression on me.
It's awesome to hear that things are going well for you. I'm involved in a
similar line of work (data integration, technical writing, and support) and
it's enjoyable. If life ever slows down and you get a moment, please
consider telling the story of 7th Sphere as you remember it. I believe that
your perspective is especially valuable as it was a period of time when
anything seemed possible.
—
Reply to this email directly, view it on GitHub
https://github.com/adamrandazzo/jrun-monitor/issues/1#issuecomment-1501044807,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AB7UKIEEUDYRRAWNA62MMFDXAJBT3ANCNFSM6AAAAAAWMZ3EWE
.
You are receiving this because you commented.Message ID:
@.***>

Your email got scrubbed, mine is work at cr0w (with a zero) dot net


Math magicians: Events

Hello 🤝  CR
Project requirements

[ ] Create a new directory called logic inside your project

[ ] Copy the files calculate.js and operate.js into your logic/ directory

[ ] Install big.js

[ ] Import calculate.js in your Calculator.js component

[ ] Implement click event handlers using the math logic from calculate.js and operate.js in your React component

[ ] The App able to perform math operations.

Hello Reviewer
First, I would like to say thank you for your constructive feedback and
insight into my project.
My PR is already approved by you, and I merged the branch to the dev
branch; however, when I go back to my MV dashboard to submit the repo link,
the status still shows review pending. This issue makes me unable to submit
the project. What do you suggest I do to fix this issue?
On Sat, Aug 26, 2023 at 6:06 PM Francis Ugorji @.***>
wrote:

@.**** approved this pull request.
Hi @mulugithub https://github.com/mulugithub 👋,
Status: Approved 🟢
Your project is complete! There is nothing else to say other than... it's
time to merge it [image: :shipit:]
Congratulations! 🎉
Highlights

Setup linters properly ✔
Passed props to child components of Calculator component ✔
Use of logic file ✔
Calculator functions properly ✔

Optional Suggestions

It would be nice to improve the UI of the application as it
showcases your styling skills.

[image: image]
https://user-images.githubusercontent.com/77106962/263471947-82fdcd7b-af37-4371-b40e-255427d7ca5a.png
Cheers, and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something
is not 100% clear.
Please tag me in your question so I can receive the notification. You can
tag me by typing @Gambit142 https://github.com/Gambit142
As described in the Code reviews limits policy
https://microverse.zendesk.com/hc/en-us/articles/1500004088561 you have a
limited number of reviews per project (check the exact number in your
Dashboard). If you think the code review was unfair, request a second
opinion using this form https://airtable.com/shrQAqnBwek5a0O0s.
—
Reply to this email directly, view it on GitHub
https://github.com/mulugithub/math-magicians/pull/3#pullrequestreview-1596930261,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AOXEN45V7VSNJVGJTYZR3MTXXIGGXANCNFSM6AAAAAA37UKBT4
.
You are receiving this because you were mentioned.Message ID:
@.***>


Question: Do players actually vanish?

Looks like i only get effects along a few other things, but can players with player-esp cheats enabled still see me? or am i just invisible for vanilla players? this would be a very critical flaw

The invisibility effect is just an extra feature - kind of to show you that you are vanished. Players that do not have permission to see you, cheats or not, will not be able to see you at all. None of your movement or similar packets will be sent to them.


Close on clicking outside

I don't know if it's an already implemented function but I need it. I can implement it manually but would appreciate it if it would be a feature.

@Temzasse

Yep it is implemented: https://github.com/Temzasse/react-modal-sheet/blob/master/example/components/SnapPoints.tsx#L50

Where is this an answer to the question? I don't get it.


[feat] Make on_fail an enum instead of string for the validator class

Description
Currently, the on_fail param expects a string or Callable, where string must be one of existing values. Instead, we should change this to an Enum with the allowable set of values.
Why is this needed
Easier documentation, usability.

Addressed in: https://github.com/guardrails-ai/guardrails/pull/674


Add logo component

This PR makes the logo its own component and makes it a little more DRY.

I've been thinking about the best way to handle implementation detail, like so:
https://github.com/lonelyplanet/rizzo-next/blob/tc-logo-component/src/components/logo/logo.scss#L23
Article here: http://csswizardry.com/2015/06/contextual-styling-ui-components-nesting-and-implementation-detail
Should we add a class like I have? Or do something like this:
.logo {
  // styles
  .header & {
    // implementation detail
  }
}

I'm not sure one way is better, but I'm trying to figure out what makes the most sense for us.

I'd think the parent component would control it, like you have it up there?

I changed the implementation from
.lp-logo {
  &.in-global-header { ... }
}

to
.lp-logo {
  .lp-global-header & { ... }
}

I think it's ready to merge.


feat: redesign persistence layer (interface+mock)

#TICKET_NUMBER

Reviewers
Functional:
@atolopko-czi
Readability:

Changes

add
remove
modify

QA steps (optional)
Notes for Reviewer

Incorporated in: https://github.com/chanzuckerberg/single-cell-data-portal/pull/3485


SetInterrupt for input with pulldown resistor

Hey, I am trying to set a synchronous interrupt(trigger is Rising Edge) on a GPIO which has been configured as input with pulldown resistor. Assuming I am connecting a push button, with one side connected to GPIO input and the other to 3.3V. The expected behaviour is that the interrupt fires when button is pressed. However, this only happens if I connect other side of button to ground instead of 3.3v.
For context, I am trying to port this:
https://gpiozero.readthedocs.io/en/stable/api_input.html#button
How can I resolve this please?
Thanks

I just tried this myself, and everything seems to work as expected. I connected one side of a button to GPIO 23, and the other side to 3.3 V. When I press the button, the interrupt triggers. Perhaps you accidentally chose two pins on the tactile switch that are connected together? For reference, this is the code I used:
use std::error::Error;

use rppal::gpio::{Gpio, Trigger};

const GPIO_BTN: u8 = 23;

fn main() -> Result<(), Box<dyn Error>> {
    let mut pin = Gpio::new()?.get(GPIO_BTN)?.into_input_pulldown();

    pin.set_interrupt(Trigger::RisingEdge)?;

    println!("Waiting for rising edge trigger...");
    pin.poll_interrupt(true, None)?;

    println!("Triggered!");

    Ok(())
}

Hey there! My bad... It did work as described for other GPIO pins. I was having problems because I was trying it on BCM 2 and BCM 3 which are i2c SDA and SCL respectively. Those pins have fixed 1.8 kohms pull-up to 3.3v. I believe that was causing the issue.
Thanks!

Hah, that does indeed explain the strange behavior. Glad to hear you figured out the cause!


 Is it possible to make prying reinforced tiles just give you a rod back? Requiring welding is still going to be annoying.

i agree with lank

Seems weird to me to keep the tile items if practically youre just going to use rods anyway. I'd just have prying give a rod back.

applied review

i think it should be the other way around, you have to explicitly craft reinforced tiles
the main issue with rods is you accidentally click and then it slows you down prying it, even if you get the rod back you wont get your time back


Fix arrow TaskGroup TSAN warnings

This turned out to be a false positive. We built a docker container with our deps in it compiled against TSAN, and got a pass: https://hub.docker.com/r/omnisci/core-build-tsan-centos7-cuda10.0


Extra quotation mark in url-encode sass function

Not sure if this is an error or not, but syntax highlighting was all messed up. I presume it's an error and not an escaping thing?

Escaping! Not sure why it's messing up syntax highlighting. %22 is the escaped code for ", but since our code style says to use double-quotes, I'm using the escaped version.


Default exception message can trigger ActionDispatch::Cookies::CookieOverflow

ActionDispatch::Cookies::CookieOverflow is triggered when Pundit generates an overly long message and its stored in the flash/session, e.g.:
  ...
  rescue Pundit::NotAuthorizedError => e
    flash[:alert] = e.message
  end

I suspect the following line is responsible:
message = options.fetch(:message) { "not allowed to #{query} this #{record.inspect}" }

https://github.com/elabs/pundit/blob/145d7592c0028c26e61e8a9569ed3440323eaa40/lib/pundit.rb#L24
If record.inspect returns a long enough string this would cause the 4kb cookie storage limit to be exceeded.

You really should not be storing error messages in the flash. Error messages are meant for consumption by programmers and they may reveal details about your system that you do not want to reveal. You should construct your own error message from the details provided by Pundit (if you need to) or simply show a "Not authorized" generic error message. I think the generic error message is the best option unless you're building an API which others can consume and you want to reveal more about the cause of the error.

@jnicklas agreed.
So forgetting the flash/session problem. Is it worth revisiting including the record.inspect output in the message? This message is potentially much longer than a short summary. Exception messages tend to be pretty succinct. The record (and query) are available on the error object for debugging needs.

There was a big collective Hallelujah when we changed it to inspect recently. I'm guessing changing it back would piss a lot of people off a lot ;)

Oh right, best not cause an uprising! Thanks for explaining, the quick responses, and of course Pundit!


Chinese character renders wrong with Microsoft SQL Server data source

A clear and concise description of what the bug is.
How to reproduce the bug
today , i dont alter anything , but  chinese char show error.
9911554 | ³É¶¼ | ±±¾©

i dont know why ? i already add uri charset=utf8
only sqlserver database show chinese error, i try different sqlserver.
mysql starrocks no this error.
Expected results
what you expected to happen.
Actual results
what actually happens.
Screenshots
If applicable, add screenshots to help explain your problem.
Environment
(please complete the following information):

browser type and version:
superset version: 2.1
python version: python --version
node.js version: node -v
any feature flags active:

Checklist
Make sure to follow these steps before submitting your issue - thank you!

[ ] I have checked the superset logs for python stacktraces and included it here as text if there are any.
[ ] I have reproduced the issue with at least the latest released version of superset.
[ ] I have checked the issue tracker for the same issue and I haven't found one similar.

Additional context
Add any other context about the problem here.

Hello, I tried to make your issue title more detailed.  Am I correct that this only happens with SQL server as a data source?

Hello, I tried to make your issue title more detailed. Am I correct that this only happens with SQL server as a data source?

yes, only SQL server data source.
i apply by docker compose,
i try new env in local computer, i try TAG: 2.1  and TAG:3.0 , try new database.

in sqlserver , i find some columns right , some error ....

Did you work out a solution?
On Sun, Oct 15, 2023, 9:10 PM The MH @.***> wrote:

Closed #25576 https://github.com/apache/superset/issues/25576 as
completed.
—
Reply to this email directly, view it on GitHub
https://github.com/apache/superset/issues/25576#event-10659029847, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ABZYDEB5Z7KIZFBVMFXWFALX7SCRNANCNFSM6AAAAAA5YP2QII
.
You are receiving this because you commented.Message ID:
@.***>

Did you work out a solution?
…
On Sun, Oct 15, 2023, 9:10 PM The MH @.> wrote: Closed #25576 <#25576> as completed. — Reply to this email directly, view it on GitHub <#25576 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABZYDEB5Z7KIZFBVMFXWFALX7SCRNANCNFSM6AAAAAA5YP2QII . You are receiving this because you commented.Message ID: @.>

i  move the data to mysql database.


add quote component

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):
Fix #
Test URLs:

Before: https://main--{repo}--{owner}.aem.live/
After: https://--{repo}--{owner}.aem.live/

URL for testing:

https://develop--aem-boilerplate-xwalk--abamy.aem.page/


More ngrok diagnose docs

Preview: https://ngrok-docs-git-jen-diagnose-ngrok-dev.vercel.app/docs/agent/diagnose/
closes https://github.com/ngrok/ngrok-docs/issues/990

https://github.com/ngrok/ngrok-docs/pull/977 has been merged so want to incorporate that + how to cat out the verbose report from k8s logs (ty @alex-bezek!):
args: ["ngrok diagnose -w /tmp/ngrok_diagnose_output.txt && cat /tmp/ngrok_diagnose_output.txt"]


Adding "Google Account" fails

Following these steps I read a dead end

Click on + Existing Account
Click on Account Type: Google Account

I am left with a blank modal window that says "Account Type"
I'm running version 13.1.2 downloaded from F-Droid on CyanogenMod 12

You should try the latest ChatSecure here: https://guardianproject.info/releases/ChatSecure-v14.1.1-RC-5.apk or through our FDroid repo here: https://guardianproject.info/fdroid/repo/
For some reason, the ChatSecure build on F-Droid.org is very out of date. You will have to uninstall that version first.


General Information about the current status of the repository

Hi,
I stumbled upon this repository, and I would like to try it out and maybe use parts of it in future projects. Now I would like to know if updates can be expected in this repository or if current versions of this approach are stored elsewhere.
Thanks kindly.

Hi, this repo would contain examples and docs regarding the plugin of different versions. For latest version and its source code, you can check what is released to NPM.


feat: expose Sequelize instance for executing raw queries

Checklist

[x] npm test passes
[x] tests and/or benchmarks are included
[x] documentation is changed or added
[x] commit message follows commit guidelines

Description of change
expose Sequelize instance for executing raw queries http://docs.sequelizejs.com/manual/tutorial/raw-queries.html

app.model is instance of Sequelize


Being more explicit with documenting public API

Description of issue or feature request:
As a result of discussion in https://github.com/theupdateframework/python-tuf/pull/2234, opening this issue to make consensus on eventually declaring public API directly in Python sources.
Current behavior:
Developers can explore API provided by python-tuf using RTD pages. As per PEP-8 standard, __all__ could be considered to declare public API. Note by doing so, this also affects start imports.
Expected behavior:
Identify possible use-cases for declaring public API in Python sources.

I'll leave some comments for ngclient since I think that's the easy case:

I'm pretty happy with what is in __init__.py: that really defines the public ngclient API. Defining __all__ sounds good to me -- but not sure if it changes anything from default? Maybe defining __all__ even if it is same as default is good practice? :shrug:
in hindsight, all of the sub modules could have been internal (so updater.py could be _updater.py or _internal/updater.py)

If we did that, probably the only required addition to __init__.py might be a import TargetFile (because the updater API exposes it so makes sense to make it available)
This would be an API change but likely not a problematic one

I think the ngclient changes sound reasonable (but not strictly necessary)


refactor: disable GMP integration via labels

This PR disables integration of benchmarks with Google Managed Prometheus, as we've now migrated to a self-managed stack.

And ideally we do a release immediately after.


Exclude jtreg test sun/security/pkcs11/fips/TestTLS12.java in jdk8u

Hi all,
We have not configure NSS lib in ours test environments for now, so the test sun/security/pkcs11/fips/TestTLS12.java will failed in jdk8u. In jdk11u, this test will skip automatically. So before we configure NSS lib in ours test environments, we need to exclude this testcase in jdk8u.
Change only happen in alibaba excludes files, no risk.

Thanks all for the review.


[CSM-478] Fix slow transaction creation in case of big amount of addresses

A couple of slow cryptographic functions - deriveLvl2KeyPair and checkPassMatches - cause newPayment endpoint to be very slow if there's lots of addresses in the wallet. This PR fixes it in the following ways:

checkPassMatches is performed only once (on root secret key)
Only addresses with money are considered when deriving level 2 secret keys.
In case when the majority of addresses is empty (which is current Bittrex case) this decreases time for newPayment from 2 minutes to 2 seconds.

Only addresses with money are considered when deriving level 2 secret keys.
In case when the majority of addresses is empty (which is current Bittrex case) this decreases time for newPayment from 2 minutes to 2 seconds

This being said, improvement is workaround for short period was developed over night (also with intention to nail the problem down)
Fix removing this "majority of addresses empty" to be further developed

I've reverted
throwM (RequestError "Given money source has no addresses with money!")
this error message b/ it broke daedalus api

I've reverted this error message b/ it broke daedalus api

Thanks. I think that's sensible.

Closing as anymore unnecessary, as it was resolved in a better way with CSM-479


[Bug] RedPajama wrong on macos:An error occurred during the execution of TVM.

🐛 Bug : RedPajama wrong on macos:An error occurred during the execution of TVM
To Reproduce
Steps to reproduce the behavior:

conda create -n mlc-chat-venv -c mlc-ai -c conda-forge mlc-chat-cli-nightly
conda activate mlc-chat-venv
conda install git git-lfs
git lfs install
mkdir -p dist/prebuilt
download binary-mlc-llm-libs.zip  from github,   unzip it to dist/prebuilt/lib
cd dist/prebuilt]
git clone https://huggingface.co/mlc-ai/mlc-chat-RedPajama-INCITE-Chat-3B-v1-q4f16_0
cd ../..
mlc_chat_cli --local-id RedPajama-INCITE-Chat-3B-v1-q4f16_0

Environment

Platform (e.g. WebGPU/Vulkan/IOS/Android/CUDA):
Operating system (e.g. Ubuntu/Windows/MacOS/...): macos
Device (e.g. iPhone 12 Pro, PC+RTX 3090, ...): macmini(M2)
How you installed MLC-LLM (conda, source): conda
How you installed TVM-Unity (pip, source): git
Python version (e.g. 3.10):none
GPU driver version (if applicable):none
CUDA/cuDNN version (if applicable):none
TVM Unity Hash Tag (python -c "import tvm; print('\n'.join(f'{k}: {v}' for k, v in tvm.support.libinfo().items()))", applicable if you compile models):none

Additional context
mlc-chat-vicuna-v1-7b-q3f16_0   can run success.

The error indicate that you have an M1 but installed a conda for x86, please install https://github.com/conda-forge/miniforge miniforge for m1

Please follow the instructions on this page:  https://mlc.ai/mlc-llm/docs/install/conda.html#validate-installation


fix: fail to perform host remove netif

What this PR does / why we need it:
fix: fail to perform host remove netif

Does this PR need to be backport to the previous release branch?:

release/3.12
release/3.11

/cc @zexi @ioito @wanyaoqi

/lgtm

/lgtm


How to use Task and Task.Run in VBScript?

I'm having problems.
The C# code is below:
engine.AddHostType("CSTask", typeof(Task));
engine.AddHostType("CSAction", typeof(Action));
The VBScript code is below:
Function LoopOut1()
  '............
End Function
Function LoopOut2()
   '............
End Function
Function LoopOut3()
   '............
End Function
CSTask.Run(host.del(CSAction,LoopOut1))
CSTask.Run(host.del(CSAction,LoopOut2))
CSTask.Run(host.del(CSAction,LoopOut3))
But the final results are not executed as expected, they are executed sequentially.
LoopOut1 -> LoopOut2 -> LoopOut3
So, what is the correct way to use Task and Task.Run?

Thank you very much.

Please reopen this issue if you have additional questions about this topic. Thank you!


feat: Add tokenSortConfig to preferences controller

Explanation
Adds a tokenSortConfig to PreferencesController to pair with mobile and extension codebases. This config will tell each application which keys tokens are sorted by, which order they are sorted in, and by which sorting callback they should use while being sorted.
References
https://consensyssoftware.atlassian.net/browse/MMASSETS-357
https://consensyssoftware.atlassian.net/browse/MMASSETS-356
Changelog
<!--
If you're making any consumer-facing changes, list those changes here as if you were updating a changelog, using the template below as a guide.

ADDED tokenSortConfig to PreferencesController default state

## Checklist

- [x] I've updated the test suite for new or updated code as appropriate
- [x] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
- [x] I've highlighted breaking changes using the "BREAKING" category above as appropriate
- [x] I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

Looks good!
Can we update change log to reflect the update; sth like
@metamask/preferences-controller

Added: Added tokenSortConfig to preferencesController state

Maybe we wont this one if this gets merged first https://github.com/MetaMask/core/pull/4860/files#diff-40a12640df782cc92dd07efa2b2f120024eb7c5cf1d9431893406ef39132e272

Closes as change was included in https://github.com/MetaMask/core/pull/4860


[Mention The Feature]: Implementing  User Authentication

Is your feature request related to a problem? Please describe.
This website currently don't have a login/register feature
Describe the solution you'd like.
I want to implement login/register feature with a separate web page and implementing backend @
Describe alternatives you've considered.
No response
Additional context.
No response
Show us the magic with screenshots
No response
Checklist

[X] I have checked the Existing Issues
[X] I have read the Contributing Guidelines
[X] I want to work on this issue. (optional)

@Soumya03007 hi can you join the discord server mentioned in readme
there are some people working on the user authentication i was thinking it could be collabrative work as it is a level 3 task

this issue has been solved, so we are closing this issue.


chore(main): release library 7.0.1

:robot: I have created a release beep boop
7.0.1 (2024-11-20)
Bug Fixes

abort test execution when shell commands fail by default (#152) (cd8f97e)

This PR was generated with Release Please. See documentation.

:robot: Created releases:

library-v7.0.1
:sunflower:


HIP94 - Add details on HPR packet processing

Add  precision on how the HPR is accepting packets

Does this still need to be merged or are there any changes that invalidate this PR?

Merging on behalf of the author.


Infinite loops on CVODE

Hi. I have suffered the same problem (infinite loops on CVODE) as you in this post, (https://githubmemory.com/repo/LLNL/sundials/issues/44)
(The interesting point to add is that, sometimes it gets certain values after taking plenty of times...)
Is there any update on this problem?
I have used the version:
pymc3                     3.9.3,
sunode                    0.1.1, and
sundials                   5.3.0
If there is an update on this problem, I plan to update the newest version.

I think this was fixed in sundials 5.4.0 and I've never seen that behaviour since.

I think this was fixed in sundials 5.4.0 and I've never seen that behaviour since.

Thank you for your comments! I will update my version and see if I suffer from the same problem.


[web]: try to copy paste some text in Line Messenger Browser

i can not paste text after copy text at my flutter web project

Hi @echomartha
Can you please provide your flutter doctor -v and a minimal complete reproducible code sample?
Thank you

hello @pedromassangocode  ths is my flutter doctor -v

and this is my code, lib i use  : https://pub.dev/packages/clipboard

already try with Clipboard Clipboard.setData(new ClipboardData(text: _copy)); but same result

@pedromassangocode , this the new  code i tryng to
clipBoard(String url) async {     await Clipboard.setData(ClipboardData(text: url))         .then(           (dynamic result) => Scaffold.of(context).showSnackBar(             SnackBar(content: Text('Success')),           ),         )         .catchError(           (Object error) => Scaffold.of(context).showSnackBar(             SnackBar(content: Text('Error $error')),           ),         );   }
the result

Hi @echomartha
I need you to provide a minimal reproducible code sample by copy/paste it her in the comments and not as image so I can copy then and try to reproduce the issue you are having.
Please note that your code should not use a third-party plugin for this.
If you keep using https://pub.dev/packages/clipboard then I suggest you to close this issue and create a new one in the repository of that plugin https://github.com/samuelezedi/flutter_clipboard.

Can you please elaborate "when i try in Line messenger Browser it cant"?
Does it shows you an error in the console?

@pedromassangocode

Please run your project with flutter run -v and try to reproduce the issue and then provide the output here.
If it is too long you can share it as a .txt file.

Uploading result.txt…

Hi @KernCheh
Can you please share provide what I asked in https://github.com/flutter/flutter/issues/68087#issuecomment-708947441 as well?
Thanks

hi @pedromassangocode
this is the issue i;ve got after deploy my project

the expected result :

@pedromassangocode this my code
 clipBoard(String url) async {
    await Clipboard.setData(ClipboardData(text: url))
        .timeout(Duration(seconds: 2))
        .then(
          (dynamic result) => Scaffold.of(context).showSnackBar(
            SnackBar(content: Text('Success')),
          ),
        )
        .catchError(
          (Object error) => Scaffold.of(context).showSnackBar(
            SnackBar(content: Text('Error $error')),
          ),
        );
  }

Hi @echomartha
Sorry but I'm not understanding what is the real issue here.
You are saying that you cannot paste text into Line Messenger Browser but you are showing a UI with SnackBar build with Flutter.
I tried copy text from Flutter app and then pasting it into safari and it worked. I fear that Flutter does not have support for the Browser you are using. But since this is still not clear to me I'm not sure what the issue really is.
Does the code bellow reproduces the issue?
If it does not reproduce then share a complete sample code that reproduces the issue.
Please share a clear steps by step in how to reproduce the issue.
Unless you explain the issue right I will not be able to understand and reproduce it.
Code sample
import 'package:flutter/material.dart';
import 'package:flutter/services.dart';

void main() => runApp(MyApp());

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Material App',
      theme: ThemeData.dark(),
      home: Home(),
    );
  }
}

class Home extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        title: Text('Material App Bar'),
      ),
      body: Center(
        child: Container(
          child: Text('Hello World'),
        ),
      ),
      floatingActionButton: FAB(),
    );
  }
}

class FAB extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return FloatingActionButton.extended(
      label: Text('Copy \'FlutterX\' to Clipboard'),
      icon: Icon(Icons.add),
      onPressed: () async {
        await Clipboard.setData(ClipboardData(text: 'FlutterX'))
            .timeout(Duration(seconds: 2))
            .then(
              (dynamic result) =>
              Scaffold.of(context)?.showSnackBar(
                SnackBar(content: Text('Success')),
              ),
        )
            .catchError(
              (Object error) =>
              Scaffold.of(context)?.showSnackBar(
                SnackBar(content: Text('Error $error')),
              ),
        );
      },
    );
  }
}

helloo @pedromassangocode
so my problem is when i try in local host it can copy paste like normaly but when i deploy my project, and i testing in mobile safari and line messeger browser it cant showing toast success

Thanks for making it clear.
Can you confirm if the issue also happens when you try on Safari as well?
Noticed you are using an old version of Flutter. Can you please update Flutter and try again?
The latest stable is 1.22 and you can update by running:
flutter channel stable
flutter upgrade --force
If the issue persist please provide your flutter doctor -v.
Thank you

hello @pedromassangocode  sorry for my unclear question
already flutter upgrade and No ussyes found!
this is the new error

Hi @echomartha
Thanks for the update.
This is not an error, you defined a timeout for the seData method to last and since it is taking more than the expected it is showing you this message. You can simply await the future to complete without setting a timeout!
Given your latest message, I feel safe to close this issue. If you disagree, write in the comments bellow and I will reopen it.
Thank you

@pedromassangocode oke thanks for your help


[UX] Hide history/collections

Is your feature request related to a problem? Please describe.
I don't use history/collections. So I would love to hide them since it takes 1/3 of my screen. I normally have 66% of the screen on code and the rest with either a UI or API client to develop faster.
Describe the solution you'd like
A drawer-hide button to hide and show the right panel.
Additional context
We'll get FREE REALSTATE if we do this.

On it!

I opened my laptop 😄

@NBTX can you make the page transitions work? It's partly working. I can do this. 😌

@liyasthomas okay


Select.toString() omits table aliases from joins

Hi Andre
I absolutely love alasql but have run into a tiny bug.
Calling .toString() on an alasql.yy.Select object omits the table aliases of joined tables.
eg JOIN table AS t comes out as JOIN table
Here's a jsfiddle to show it action http://jsfiddle.net/ndxbxrme/ryx7b5yz/1/
and here is a proposed fix for the yy.Select.prototype.toString function (approx line 6992)
if(jn.table){
  ss += 'JOIN '+jn.table.toString();
  if(typeof jn.as !== "undefined") {
     ss += ' AS ' + jn.as;
  }
}

Here's a jsfiddle with the fix implemented http://jsfiddle.net/ndxbxrme/eyLy4zy9/1/
Cheers
Kieron

You are awesome. Ill get it into the code!

Haha, thanks Mathias but don't speak too soon!
I've been using .toString() quite heavily recently and have found a few more bugs.
Here's a jsfiddle showing them all with some fixes included http://jsfiddle.net/ndxbxrme/eyLy4zy9/3/

Thank you!


Update Platform (React version) and Genetics Portal footers due to partnership changes

Due to changes in the consortium partnership that took effect on 1 April 2020, can we please make the following changes to the React version of the Platform and the Genetics Portal footers?

Remove the Biogen text and link
Remove the Celgene text and link
Please add a text entry for Bristol Myers Squibb and please link to https://www.bms.com/

Also added Sanofi to the footer of the Genetics portal since it was missing there.


Set default value for IRODS_ENABLE_430_COMPATIBILITY to NO once iRODS 4.3.1 is released

https://github.com/irods/irods_api_plugin_genquery2/blob/5793807178838b80f63dcccfbf280e4d7be8674e/CMakeLists.txt#L3

I'd rather remove this entirely and replace the precompiler conditionals with version checks

Even better.

Given that building against 4.3.0 is already broken, as we include IrodsRunpathDefaults (not introduced until after 4.3.0) in CMakeLists.txt, and will be further broken once my PR for irods/irods#7312 lands, perhaps we should rip out all the 4.3.0 stuff instead of trying to maintain compatibility.

I wasn't aware we broke support for 4.3.0. That was not intended. We want 4.3.0 users to be able to compile the project and play with it.
Looking at the commit that introduces IrodsRunpathDefaults, it seems we can add a simple conditional that restores support. Does it require more work than that?
I think we have to support 4.3.0 until we decide the experimental period is over.

A conditional would work fine.