Token updates

Alaska Airlines Pull Request
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Resolves: #98, #102
This PR is restructured from this previous PR.
https://github.com/AlaskaAirlines/AuroDesignTokens/pull/105
Summary:
Please summarize the scope of the changes you have submitted, what the intent of the work is and anything that describes the before/after state of the project.
The scope of this PR is to address incorrectly deprecated tokens and update tokens as needed to address a name convention change.
Type of change:
Please delete options that are not relevant.

[ ] New capability
[x] Revision of an existing capability
[ ] Infrastructure change (automation, etc.)
[ ] Other (please elaborate)

Checklist:

[x] My update follows the CONTRIBUTING guidelines of this project
[x] I have performed a self-review of my own update

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.
Thank you for your submission!
-- Auro Design System Team

:tada: This PR is included in version 3.15.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Initial scarthgap compatibility

Minimal changes to get scarthgap compatibility on the kirkstone branch. Since there are no major changes needed I just added this to the kirkstone branch to not have 2 almost identical branches that need to be kept up2date with each EVerest update

Sorry, but personally I disaggree with the proposed approach. Even if there are no marjor changes now, I'd prefer to have the workflow established.
First, I would like to extend the README in this repo here to document, how the EVerest community supports different Yocto releases/branches. I can work on this but due to starting holidays, I cannot make any promises.
In addition to this organizational comment, some technical notes:

Some recipes (mostly the backported ones) are obsolete with scarthgap, since already included and even available in a newer version. This is why I'd recommend to drop them here.
This is why I also would prefer to have a dedicated branch for each (Yocto) upstream release.
I encountered build problems with the OCPP 2.0.1 module with the C++ compiler version in scarthgap but since I tried to build for our Tarragon platform and had to fiddle a little bit around to push it through, I'm not yet sure that I messed thing up on my side. I'll investigate.

Disclaimer: personal opinion, not discussed/consolidated with with my employer team

Sorry, but personally I disaggree with the proposed approach. Even if there are no marjor changes now, I'd prefer to have the workflow established.
First, I would like to extend the README in this repo here to document, how the EVerest community supports different Yocto releases/branches. I can work on this but due to starting holidays, I cannot make any promises.
In addition to this organizational comment, some technical notes:

Some recipes (mostly the backported ones) are obsolete with scarthgap, since already included and even available in a newer version. This is why I'd recommend to drop them here.
This is why I also would prefer to have a dedicated branch for each (Yocto) upstream release.
I encountered build problems with the OCPP 2.0.1 module with the C++ compiler version in scarthgap but since I tried to build for our Tarragon platform and had to fiddle a little bit around to push it through, I'm not yet sure that I messed things up on my side. I'll investigate.

Disclaimer: personal opinion, not discussed/consolidated with with my employer team

I agree, let's have different branches for kirkstone and scarthgap, this was pretty much just a quick poc to see how much is needed to get this to work 😄


BUG: Infinite redirects when adding a CSS stylesheet to html code, unable to load stylehseet

-> Checked the security endpoints, tried commenting out Request Matchers
-> Tried getting rid of asterisks in Request Matchers
-> Tried creating a static folder
-> Checked the registration endpoints

-> Made all enpoints permit all to see if that would load the page, no luck

Kevin helped! And it worked!


Fix tkn pac generate when no git remote url

when we don't have a git remote url (like for example the repository
hasn't been pushed yet) the generate name would come back as "." which
would fail on kube.
So instead use the current working directory as the gitURL so we get a
name for the pipelinerun name

/lgtm

/test go-testing


[util,doc] Add codeblock support to CMDGEN

Since CMDGEN currently uses HTML-comments, if you wrap these comments inside a markdown codeblock to gain formatting for the result of your command, the HTML comments will also be rendered in the codeblock.
This PR adds an optional argument mode to CMDGEN to insert the codeblocks for you, only this time inside the HTML braces.
Currently, if you malform the optional arguments, the errors aren't very nice. This could be improved with this implementation.
As a demonstrator, replace the hardcoded content of the ipgen.py tool in its README with the CMDGEN-generated content. Use the 'console' formatter to clearly show that we are printing CLI output here.

As part of this PR, I noticed that the output from python's argparse changes at some point between 3.8 and 3.12, with the string "optional arguments" changing to "options". This is a non-functional change, but if you run ./util/cmdgen.py --update with a newer version of python than is used in CI, it will change the content, and if you commit it will then fail the CI check.

@jwnrt

Since CMDGEN runs shell, can we do things more akin to Unix tool philosophy and create a script (codewrap.py or codewrap.sh) and then pipe the output to it? E.g.
<!-- BEGIN CMDGEN util/ipgen.py generate --help | util/codewrap.py --type console -->

Yeah I like this more. Thanks for the idea. We should definitely document the cmdgen tools with some examples of solving common problems (such as this), so a contributor can just copy-paste a solution without too much thought.

We should also consider if stdout/stderr handling if we are using pipes in a CMDGEN invocation

Or we could just do
<!-- BEGIN CMDGEN echo '```console`' && util/ipgen.py generate --help && echo '```' -->

Or we could just do
<!-- BEGIN CMDGEN echo '```console' && util/ipgen.py generate --help && echo '```' -->

IMO this is ugly, but will hear arguments

IMO this is ugly, but will hear arguments

My view is this isn't very pretty, but I don't think it's worth adding the shorthand flag to cmdgen to avoid


Does not recognize MSEdge on my mac

I am on a 2010 Mac running the last version of High Sierra (10.13.6) and the latest version of VS Code. When I click the + icon, I get the following notification.
Microsoft Edge could not be found. Ensure you have installed Microsoft Edge and that you have selected 'default' or the appropriate version of Microsoft Edge in the extension settings panel.

Hi damerms,
We currently look for the default Edge application at:
/Applications/Microsoft Edge.app/Contents/MacOS/Microsoft Edge for MacOS.
Could you verify if the path for your Edge browser differs from this?

Hi damerms,
We currently look for the default Edge application at:
/Applications/Microsoft Edge.app/Contents/MacOS/Microsoft Edge for MacOS.
Could you verify if the path for your Edge browser differs from this?

Here is where mine is located.
Applications/Browsers
Thanks,
David Mermelstein
Linkedin http://www.linkedin.com/in/merms |<PHONE_NUMBER>
▲ Plan ● Design ■ Code
ᐧ
On Thu, Jan 28, 2021 at 3:01 PM Michael Liao<EMAIL_ADDRESS>wrote:

Hi damerms,
We currently look for the default Edge application at:
/Applications/Microsoft Edge.app/Contents/MacOS/Microsoft Edge for MacOS.
Could you verify if the path for your Edge browser differs from this?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/microsoft/vscode-edge-devtools/issues/260#issuecomment-769390060,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AACWAFAAPQBKJPQVU5NPWMLS4HGCFANCNFSM4WV4BNNQ
.

Here is where mine is located.
Applications/Browsers
Thanks,
David Mermelstein
Linkedin http://www.linkedin.com/in/merms |<PHONE_NUMBER>
▲ Plan ● Design ■ Code
ᐧ
On Thu, Jan 28, 2021 at 3:01 PM Michael Liao<EMAIL_ADDRESS>wrote:

Hi damerms,
We currently look for the default Edge application at:
/Applications/Microsoft Edge.app/Contents/MacOS/Microsoft Edge for MacOS.
Could you verify if the path for your Edge browser differs from this?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/microsoft/vscode-edge-devtools/issues/260#issuecomment-769390060,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AACWAFAAPQBKJPQVU5NPWMLS4HGCFANCNFSM4WV4BNNQ
.

Hello, David,
this is where the app package is stored, which isn't where your Mac puts all the parts of the browser code.
Can you try the following, and see if it brings the results we expect?
Open the Terminal:
Press Command+Space together and type in "Terminal" - hit enter.
You should get a terminal window

type "cd /Applications/Microsoft\ Edge.app/Contents/MacOS/"
What do you get?

Hello -
I get no such directory. I had submitted an issue and stated all my
browsers are in a custom folder called browsers.
Thanks,
David Mermelstein
Linkedin http://www.linkedin.com/in/merms |<PHONE_NUMBER>
▲ Plan ● Design ■ Code
ᐧ
On Mon, Feb 1, 2021 at 5:22 PM Christian Heilmann<EMAIL_ADDRESS>wrote:

Hello, David,
this is where the app package is stored, which isn't where your Mac puts
all the parts of the browser code.
Can you try the following, and see if it brings the results we expect?
Open the Terminal:
Press Command+Space together and type in "Terminal" - hit enter.
You should get a terminal window
[image: image]
https://user-images.githubusercontent.com/13508/106530415-8e74a280-64ec-11eb-9cf5-9ce23bcf7166.png
type "cd /Applications/Microsoft\ Edge.app/Contents/MacOS/"
What do you get?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/microsoft/vscode-edge-devtools/issues/260#issuecomment-771229928,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AACWAFBWRXZMIE64N6OX2FTS44ZRNANCNFSM4WV4BNNQ
.

Ah, so you customised your install to a certain folder. That's unfortunate. It might be interesting to make this customisable in the extension settings, but we don't have that yet. As the extension has no way to know where you installed your Edge, could you try to create a symlink to point to the bespoke location?
ln -s /Applications/Microsoft\ Edge.app/Contents/MacOS/ Applications/Browsers/

How do I do that?
Thanks,
David Mermelstein
Linkedin http://www.linkedin.com/in/merms |<PHONE_NUMBER>
▲ Plan ● Design ■ Code
ᐧ
On Mon, Feb 1, 2021 at 5:45 PM Christian Heilmann<EMAIL_ADDRESS>wrote:

Ah, so you customised your install to a certain folder. That's
unfortunate. It might be interesting to make this customisable in the
extension settings, but we don't have that yet. As the extension has no way
to know where you installed your Edge, could you try to create a symlink to
point to the bespoke location?
ln -s /Applications/Microsoft\ Edge.app/Contents/MacOS/
Applications/Browsers/
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/microsoft/vscode-edge-devtools/issues/260#issuecomment-771239973,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AACWAFE42OMHUFGCSJTI56LS444KDANCNFSM4WV4BNNQ
.

https://www.switchingtomac.com/tutorials/osx/how-to-create-symlinks-on-your-mac/

Hey @codepo8, I tried out this symlink approach and it didn't seem to work; I think puppeteer doesn't know how to handle a symlink at the executable path instead of an actual executable.
A custom executable location isn't supported by the extension right now so I'm going to close the issue, but this is probably something we should add in the future. We'd just need to make sure the exe they point to is actually Edge and not a different browser-- not sure how easy or difficult that would be.


Got infinite update error while passing JSX VNode to ChildComponent in some case.

Version
2.3.4
Reproduction link
https://github.com/chairuosen/vue-bug-demo/tree/loop-update
Steps to reproduce
clone the demo
checkout branch loop-update
install & run it
click second toggle bar
What is expected?
no error in console
What is actually happening?
[Vue warn]: You may have an infinite update loop in a component render function.

It seems DOM attribute on element is the one to blame, href in this case. Needs deeper investigation.

Wait...
You are passing vnode as prop to your component, and have an this.someObj = this.obj assignment...😅
This would make the whole vnode object reactive. What you should do is something like:
// in Hello.vue
<Child>
  <ToggleContent>
    111111
  </ToggleContent>
</Child>

// in Child.vue

{this.slots.default}

@jkzing thank you for reply.
You mean its different between passing vnode by props and slots? I'll try it tomorrow, thank you for suggestion.
But why it is fine in case3, the only different between 2 and 3 is ToggleContent vs Abc, Both of them are simple.

As @jkzing said, you should use slots.
I'll close this now. If you still feel this is a bug, feel free to open it again.

@chairuosen Not sure on it, what I could say is when you making vnode object reactively the behavior on it would not be expectable.

@znck We just know the solution to avoid the bug. but don't know the reason. and don't know why it works fine in case3.
also, I think the usage of my code isn't weird, I often pass the vnode with props in React.
So I still think this is a bug.
But there is no reopen button for me in this page LOL. Could you please reopen the issue. Thank you.

@chairuosen Actually it was not passing vnode as prop made this happen, it's assigning it to data property of a component by this.someObj = this.obj. Why this working in React is simple, because React would not make any object reactive to reflect your changes on it.

@jkzing Yeah, ^_^ same as I guess. a black-box's view. but can't explain case 3.

@chairuosen Why not? In your case 3 you are using slot, which is not reactive.

@jkzing Both them are not using slot with Child , but using slot in vnode of the prop
case 2:
<Child obj={ {
                vnode:<ToggleContent title="this works not fine. click me">
                    11111
                </ToggleContent>
            } }/>

case 3:
<Child obj={ {
                vnode:<Abc>
                    But this component works also fine with `a` tag.
                </Abc>
            } } />

Just an observation, don't know why this is happening.
<ToggleContent title="this works not fine. click me">
    11111
     // If there is no attribute here, then no infinite look. Some how attributes on hidden html are causing re-render.
</ToggleContent>


google tag manager

📝 Changed routes:

/account-abstraction
/embedded-wallets

(view full size)
(view full size)

Commit b58cf978796efd2123eaab077a06c0788a915230 (https://thirdweb-q2q7zx48z.thirdweb-preview.com).


Add CodeFund sponsorship message to README

What is the purpose of this pull request? (put an "X" next to item)
[X] Documentation update
[ ] Bug fix
[ ] New feature
[ ] Other, please explain:
What changes did you make? (Give an overview)
CodeFund provides ethical sponsorships to open source maintainers. This PR will place the "Sponsored by" image at the top of the README. The sponsoring companies are not paying per click nor impression. They are paying the maintainer(s) on a per-month basis to be the primary sponsor of this project.
For an example, see https://github.com/gitcoinco/code_fund_ads/blob/master/README.md
Is there anything you'd like reviewers to focus on?
/cc @feross

I would check to see whether this is allowed by GitHub's terms of service. I remember a case where an open source funding project was terminated due to GitHub's terms of service. Don't recall the name or details.

I would check to see whether this is allowed by GitHub's terms of service.

We did get approval on this. There are some strict requirements that we are following to ensure we stay within the rules.


Automated Feature Selection

Issue #, if available:
Description of changes:
Add the ability to perform stack-level permutation feature importance based feature pruning in AbstractTrainer. The workflow is as follows for now.

Fit all base learners once.
Select one of the base learners as the proxy model, and repeatedly fit on different feature subsets based on permutation feature importance scores to find the best feature subset. Pruning threshold is determined by permutation feature importance of a synthetic feature by default. Unless specified otherwise, proxy model feature pruning receives 2x the time it took to fit all the learners in the stack layer.
Refit all base learners once on the best feature subset. If validation score improves, use the newly fitted model. Otherwise, use the old model.

Optimizations (on top of RFE with permutation feature importance)

Proxy Model: We use a LightGBM-based model (bagged or not depends on presets) with the best validation score in the stack layer. If there are >50000 trianing rows, only train and evaluated the proxy model on 50000 random training rows. If there are >60000 rows and the proxy model is bagged, use the unbagged version of the proxy model.
Prune Threshold: Pruning threshold is determined by permutation feature importance of a random feature sampled from the standard normal distribution.
Feature Removal: Remove up to 5% of all features at a time whose feature importance is below prune threshold. First try to remove bottom 5% of features. If that doesn't improve the validation score, randomly sample 5% of features where the probability of sampling a feature is proportional to its feature importance rank (feature with lowest feature importance has the highest probability of being sampled)
Permutation Feature Importance Shuffles: Ensure permutation feature importance for each feature is evaluated on at least 10,000 datapoints. If the number of shuffle required is >100 due to small dataset size, fix it to 100 shuffles.
Feature Importance Computation: If feature importance statistics from previous proxy model fits are available within the single RFE loop and we do not have time to evaluate all feature importance statistics, use some of them as the current feature importance estimates. When there are too many features in the dataset, prioritize evaluating feature importance for features we have no estimates from then features with low feature importance from previous fit estimates.

What will be done before merging to master

Remove hacky code that collects statistics for AutoML Benchmark.
Decide how to let users specify feature pruning options. Currently the user specifies feature prune kwargs in ag_args.

Tentative AutoML Benchmark Results (Winrate of AutoGluon Prune vs AutoGluon)

1hr

Medium Quality: 0.524 (Averaged across seed: 0.520)
High Quality: 0.519 (Averaged across seed: 0.569)
Best Quality No Repeated Bag: 0.520 (Averaged across seed 0.510)
Best Quality: 0.512 (Averaged across seed: 0.549)

4hr

Medium Quality: 0.524 (Averaged across seed: 0.549)
High Quality: 0.499 (Averaged across seed: 0.534)
Best Quality No Repeated Bag: 0.530 (Averaged across seed 0.637)
Best Quality: 0.533 (Averaged across seed: 0.569)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Job PR-1274-12 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-1274/12/index.html

Job PR-1274-13 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-1274/13/index.html

Noticed you sometime call it feature_selection sometimes feature_prune but it may be good to standardize the naming for better clarity.

It'd be nice to demonstrate the use of feature-pruning as something advanced users can try out in our tabular-indepth tutorial.

After feature-pruning has been utilized, predictor.fit_summary() should clarify which features have been pruned and are no longer necessary to be present in future test data.  And always outputting a similar print statement would be good at the end of fit() with feature-pruning.

I don't see much code updated regarding the predict() functions, but shouldn't only a reduced set of features need to be present for prediction after fit with feature-pruning? Can you point out where this set is specified?

We would highlight features that are not needed anymore if all base learners in AutoGluon do not use them, but the majority of the time at least one model uses the unpruned features because its validation accuracy does not improve when using the pruned features so I don't know if it will be really worth the effort.

Job PR-1274-14 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-1274/14/index.html

We would highlight features that are not needed anymore if all base learners in AutoGluon do not use them, but the majority of the time at least one model uses the unpruned features because its validation accuracy does not improve when using the pruned features so I don't know if it will be really worth the effort.

Isn't a major advantage of feature-selection that we don't need to keep all the features around anymore?
What if you have a dataset with 3 useless features (and assume they're properly pruned during feature selection), are you saying these 3 features still need to be there in future test data?  If so, why?

It would be a major advantage, but the issue now is that while feature pruning generates a reduced feature set to be applied across the entire stack layer, the layer's base learners only work with the reduced feature set if their validation accuracy increases. So for us to not need the 3 useless features all base learners would need to have better validation accuracy on the reduced feature set and I've almost never seen that happen. We can optionally have a flag that forces all base learners to take the reduced feature set though. I would also need to make sure higher layer models don't use the pruned features from the first layer if I were to get this to reliably work.

Job PR-1274-15 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-1274/15/index.html

Job PR-1274-16 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-1274/16/index.html

Job PR-1274-19 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-1274/19/index.html

Job PR-1274-20 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-1274/20/index.html

Job PR-1274-21 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-1274/21/index.html


Add Valkey support to the build and to the compatibility test in CI

Adds the CMake option TEST_WITH_VALKEY_VERSION to enable make start to setup Valkey clusters instead of Redis.
The default behavior, when the option is not set, is to run tests with Redis, but a given Valkey version takes precedence.
(Note: There is already an option to specify a Redis version TEST_WITH_REDIS_VERSION and Redis 6.2.1 is the default.)
Example usage:
mkdir build && cd build
cmake -DTEST_WITH_VALKEY_VERSION=7.2.4-rc1 ..

make start   # Start valkey clusters
make test    # Tests run on valkey clusters
make stop    # Stop valkey clusters

Additionallty adds Valkey to the compatibility test in CI.

Shall we leave this open until the next release candidate, or the actual release, is out?

I guess you know best how far away an actual release is, and I've seen talks about possibly changing which patch-version to use.
The only benefit to merge it before could be to get the script in place to tryout more, and locally run towards unstable now and then..

ok, do as you want.
the release is within a week.

Updated to run on the first stable release of Valkey 7.2.5.


Build Docker images for ARM

This should be runnable on a Pi.  The arm architecture should also be built when building the Docker image.

Fixed by #34


plugins: summernote: Update version check

Based on other plugins.
Fixes:
PHP Notice:  Constant version already defined ... on line 15

Thank you @notcarbide!


[docs-infra] Improve product mapping

This is a continuation of #37593, to be able to measure the traffic on GA4

Rename product -> productId to make it easier to navigate the codebase, better be clear as well.
Rely on the productId stored in Algolia for the matching, rather than trying to re-compute the value from the pathname, this is wrong.
Cleanup getProductInfoFromUrl() to be simpler a step toward the future

The next steps would be:

Moving the productId logic out of docs-infra to be inside each docs. getProductInfoFromUrl() is hybrid, it feels like a leaky abstraction
Have the markdown pages productId override the logic of getProductInfoFromUrl(). There are cases when the URL structure is not straightforward.
useDemoData() has its own product id logic, this duplication is wrong. it should rely on the PageContext, no reasons to be different.

May want to incorporate the edge cases in https://github.com/mui/material-ui/pull/37721/files and close that one

@Janpot Ah yes, great. I have updated this PR.


Capture the artifacts list of a variant and display them in the web ui

What is the behaviour when the artifact list is very long ?

I forgot to mention this, but I was planning to handle this (in the future), by implementing a file-browser like view where the user can navigate between folders if the artifacts list is above a certain threshold.
What was done here is the minimal viable product :)

I've limited the max height of the artifacts list and made it scrollable beyond it.

Nice work !


Help to deserialize complex JSON

I need to deserialize this JSON:
{
    "emails": {
        "items": [
            {
                "id": 1,
                "email"<EMAIL_ADDRESS>            },
            {
                "id": 2,
                "email"<EMAIL_ADDRESS>            }
        ]
    }
}

Into this object using Marshmallow:
{
    "emails": [
        {
            "id": 1,
            "email"<EMAIL_ADDRESS>        },
        {
            "id": 2,
            "email"<EMAIL_ADDRESS>        }
    ]
}

How can I do it?
I tried this way, which I found more intuitive, but it did not work:
class Phone(OrderedSchema):
    id = fields.Int()
    email = fields.Str()

class Contact(Schema):
    key = fields.Str()
    phones = fields.Nested(Phone, load_from='phones.list', many=True)

@vcamaral please close this as duplicate of https://github.com/marshmallow-code/marshmallow/issues/873.


Update bazel, enable Windows 2022 again

Bazel 6.3.0 fixes a bug that broke the Windows-2022 runner, with the updated version we can enable it again. Note that this is a release candidate, 6.3.0 proper should be out within days.

bazel 6.3.0 is now out – the PR has been updated, but looks like there's some unrelated APT key issues now – I will investigate.

This is blocked on https://github.com/bazelbuild/rules_rust/issues/1120, not sure if upgrading the runner or upgrading bazel is what ultimately causes the long compile commands and subsequent build failures. Updating the rust crate versions within lolhtml could work too, but that would be temporary as crate versions with long compile commands are bound to reappear.

With #922, builds are now passing, PR should be ready for merge.


added Zookeeper to Patroni chart

Added Zookeeper option

Contributor License Agreement signed

bumping for CLA checks

re adding GitHub account to CLA

added secondary email account to github

LGTM, thanks for the PR! :smile:

/cc @linki

@linki ping
does it make sense to add zookeeper as a dependency to the chart so it can be installed with it?

@prydonius I think it does. Maybe we should do something similar to https://github.com/kubernetes/charts/pull/1089/files#diff-c87e703f9d61597f6f671b11cb326e55R44?

Marking this as stale. Please update during the next week.

@Andre-Freitas can you have another look at this? Adding zookeeper as a dependecy makes sense if it's configured.

@linki i can try to check this but in our environment we have our zookeeper outside of k8s. I need to check in helm dependency it i have anyone to differentiate from a k8s or local zookeeper instance

@linki I have added an option to have Etcd or Zookeeper outside of k8s cluster. I have made a few tests and its working

ping @linki

@linki fixed

lgtm, thanks @Andre-Freitas

/ok-to-test

/lgtm


fwupd: fix aarch64 build

Motivation for this change
The following changes are introduced in 1.5.6 and the plugin_synaptics option no longer exist:
https://github.com/fwupd/fwupd/pull/2753/files
https://github.com/fwupd/fwupd/pull/2747/files
With meson 0.60 the build will fails.
Things done
Nothing.

@ofborg build fwupd

Seems that we don't need to disable plugin_synaptics_rmi, just checked https://src.fedoraproject.org/rpms/fwupd/blob/rawhide/f/fwupd.spec#_233


OVS stats

Add probe to collect pmd and coverage stats from OVS.

I would prefer not have it as a separate topology probe, but as an extension to the ovsdb probe, just like the OpenFlow rule one, that can be enabled with ovs.pmd.enabled set to true

Closing it as it hasn't moved in a while. Please reopen if necessary


feat(payment): PAYPAL-1257 replaced paypal credit logo

What?
Replaced paypal credit logo
Why?
According to task https://jira.bigcommerce.com/browse/PAYPAL-1257
Testing / Proof
...
@bigcommerce/checkout

For the record, the checkout-js version for this PR is 1.189.0.
To get release status, please see https://github.com/bigcommerce/bigcommerce/pull/44472 .


Original file downloads on geo works aren't working

Look into the geo_concerns fileset view.

Issue was in the geodata ingest job. CurationConcerns::WorkingDirectory.copy_file_to_working_directory was not being called. Ingest job now uses the plum file actor. Problem solved.


Access request deprovisioning does not revoke app access

Hi,
Following a subscription suspension, an access request deprovisioning event is sent to the DA.
However, the deprovisioning process doesn't remove access to the product in the Apigee app.
See agent logs below :

@gwandwingor the fix for this is in a pre-release build, docker pull ghcr.io/axway/apigee_discovery_agent:v0.1.16-alpha1. Please validate that it is fixed and comment back on this issue.

Hi,
I was able to test this build of the agent and noticed that access request deprovisioning now removes the product access from the application.
I will do some more testing on monday before I close this ticket

Hi,
After some more testing, it appears that deleting the product from the app credential can lead to the creation of "skeleton keys", that may pose a security risk.
Here's the excerpt from the apigee official documentation :

https://cloud.google.com/apigee/docs/api-platform/publish/creating-apps-surface-your-api
Furthermore, the Apigee UI doesn't seem to allow having Credentials without access to a product, as shown below.

It seems like the safest option would be to revoke access to the product from the app as shown below in the UI :

This would effectively prevent from being able to query the API Proxy without generating skeleton keys.

@gwandwingor thanks for that information, I made additional changes to handle this situation. Please test out this version docker pull ghcr.io/axway/apigee_discovery_agent:v0.1.16-alpha2

Hi @jcollins-axway,
I deployed the latest build but now I cannot create access requests anymore. I get the following error

I can provide the full log where we can see the app creation as well as a screen recording of the whole test.


Update BillboardJS from v1 to v2

Description
This PR upgrades billboardJS
Note for Reviewer

Tested for perf test results
Tested for Grafana Charts

Signed commits

[x] Yes, I signed my commits.

Are perf tests using chartjs?

no. We are using billboardJS v2

Tested for Grafana Charts and Perf Tests. We are good to merge @leecalcote .

This is a very pleasant surprise. 😄


Is it editable if for Taiwan display?

There're always political reasons to handle.  :<

This project uses the official country codes specified by the United Nations (https://unece.org/trade/cefact/unlocode-code-list-country-and-territory). You can always change, remove or add countries/regions to the list

Thanks


feat: implementing progressIndicator component.

fixes #273

Pull Request Test Coverage Report for Build 1352

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 71.946%

Totals

Change from base Build 1347:
0.0%

Covered Lines:
665

Relevant Lines:
882

💛  - Coveralls


[BUGFIX] Remove duplicated call skipBrokerEntryMetadataIfExist when parseMessageMetadata

Related to https://github.com/apache/pulsar/pull/10968

@BewareMyPower PTAL. thanks

Add release/2.8.1.x label since https://github.com/apache/pulsar/pull/10968 is already included in Pulsar 2.8.1.


Test relative entities

Adds an entity for test cases that need to resolve their target from another entity. For example, to make assertions on the child of a group member.

Great idea. Good to merge.
Some thoughts I had while reading the code:

Do we really need to have a spec of the child test? Could set TARGET_ENTITY on self and let that propagate to children through the inheritance chain. This will allow nesting children using brooklyn.children.
target and targetId are reserved in the framework for the actual target. Could rename the config in the test to ROOT_ENTITY or ANCHOR_ENTITY. This is kind of related to the above, allowing target inheritance.
Could pull the functionality up in TargetableTestComponentImpl, letting any entity use the scoping.

Spending some more time on it I now see that it's all designed to work together with the looping test case, so the above points are mute.

One final thing. Instead of configuring DslComponent.Scope could directly pass DslComponent as the configuration and evaluate that against the target. This would allow for more complex queries like $brooklyn:ancestor("anchor-id").descendant("scoped-id").

@sjcorbett LGTM. Can you take a look at @neykov 's comments and see what you think. Please feel free to merge when you're ready.

@neykov Thank you for your comments. I have removed the testSpec config key in favour of children, replaced the use of Scope with plain DslComponents and reworked the use of target. The entity now resolves its anchor by checking a new anchor config key, target or targetId (in order), then sets its target to the resolved entity, overwriting any previous value. The anchor is published as a sensor.
I will leave extending this to all the test entities for future work.

I'll merge this now.

Thanks @sjcorbett, changes look great.


Typo on page 5

In Section 2.3 after the introduction of the MTL extensions, the default interval for past operators has one bracket too much.
(∞, 0])

This was already fixed.


Add function call to clear cached warnings

Description
Fixes #4226
Adds function call CALL clear_warnings() RETURN status which clears accumulated warnings in the global WarningContext
Contributor agreement

[ ] I have read and agree to the Contributor Agreement.

Can u open an issue on supporting CALL func() without return clause?

Create issue https://github.com/kuzudb/kuzu/issues/4250


does not build with Go HEAD

This package does some extremely unsafe and unsupported operations.  One of them has broken with Go HEAD, the future 1.23 release.
# github.com/goccy/go-json/internal/encoder.test
github.com/goccy/go-json/internal/encoder.(*Compiler).structCode: relocation target reflect.ifaceIndir not defined
github.com/goccy/go-json/internal/encoder.(*Compiler).isNilableType: relocation target reflect.ifaceIndir not defined
FAIL	github.com/goccy/go-json/internal/encoder [build failed]

The internal function reflect.ifaceIndir no longer exists.  This package should not be referencing it.
If there are performance issues with the reflect package, please file them upstream.  Please don't try to work around them using unsupported operations.  Thanks.

This library has 47 go:linkname lines, particularly in https://github.com/goccy/go-json/blob/5e2ae3f23c1db71990844a230a4d11559efe128e/internal/runtime/rtype.go, which I find very surprising for a JSON library. Please transition away from them like Ian says - if the standard library is lacking features or isn't as performant as you would like it to be, file bugs or patches upstream.
Alternatively, I'm not sure that much can be done in terms of new Go versions not breaking you. It is bound to happen when you depend on dozens of internal reflect and runtime implementation details. @ianlancetaylor personally, I would not restore functions like ifaceIndir, not even for one release cycle - we might otherwise give the impression that go:linkname is somehow covered by the Go1 compatibility guarantee.

@ianlancetaylor  Thank you for notification to me. Since the current code related to the reflect package can be replaced with the use of only public APIs, I plan to address this soon.

Previously, there was a trick implemented to avoid the forced escaping of argument values with reflect.ValueOf. However, since that code is no longer present, we can now use the reflect package normally.

Also, as a general recommendation. Have every linkname & poking into Go runtime protected by a specific Go version, because there's no guarantee on how map, reflect etc. internals are implemented. (e.g. see upcoming swissmap in https://go-review.googlesource.com/c/go/+/580778).

Thank you. I'm already aware of that, and I implemented it with that understanding.

Is there a way to iter a map with zero-alloc? reflect.Value.MapRange or reflect.Value.MapKeys both alloc O(len(m))

@trim21 Yes: use the MapIter.SetIterKey or MapIter.SetIterValue method.

Thanks. for future readers, it would look like this:
func(ctx *Ctx, b []byte, rv reflect.Value) ([]byte, error) {
		if rv.IsNil() {
			return appendNull(b), nil
		}

		size := rv.Len()
		b = appendArrayBegin(b, int64(size))

		iter := mapIterPool.Get().(*reflect.MapIter)
		defer mapIterPool.Put(iter)
		defer iter.Reset(reflect.Value{})

		kv := reflect.New(keyType).Elem()
		vv := reflect.New(valueType).Elem()

		iter.Reset(rv)

		for iter.Next() {
			kv.SetIterKey(iter)
			b, err = keyEncoder(ctx, b, kv)
			if err != nil {
				return b, err
			}

			vv.SetIterValue(iter)
			b, err = valueEncoder(ctx, b, vv)
			if err != nil {
				return b, err
			}
		}

		return append(b, '}'), nil
	}


Moved files internal to SD storage.

I moved files from my internal to the SD card files folders. I have also copied what was in some of the folders, to my Google drive. I cannot access the playlists that I made. Only one song am I able to play with this 'music player for Google'
I've tried everything i can come up with to move apps., and have memory, etc to go into the SDcard. I am not given the option in the settings, storage, the downloaded of app. . usually there is that option that says ,' move to SD CARD, . '
Previous to messing with the folders and am that

I unmounted the SD card and erased it. My phone shows that it is in and that there is the full 14 gb available. ..
Maybe someone has s


Added DeQueue implementation using array and updated corresponding README.md

https://github.com/Algo-Phantoms/Algo-Tree/issues/237

@imsushant12 Don't raise multiple issue code in single one, create different branch for each issue in your local git then push that branch only for separate pr

Okay I am raising new PR, please review:
PR : #1833
Issue: #237


Check error return from json.Unmarshal

In shouldKillAllOnExit(), we should check the error return from json.Unmarshal before dereferencing bundleSpec.Linux

@Zyqsempai
commit 55b8d38d2638cb1774c85a2246627401740642e1 (HEAD -> unmarshal-err-check, origin/unmarshal-err-check)
Author: Ted Yu<EMAIL_ADDRESS>Date:   Wed Feb 26 02:28:10 2020 -0800

    Check error return from json.Unmarshal

    Signed-off-by: Ted Yu<EMAIL_ADDRESS>
See if the commit is signed correctly.

@Zyqsempai @AkihiroSuda
Please take another look.

Codecov Report

Merging #4057 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4057   +/-   ##
=======================================
  Coverage   42.67%   42.67%
=======================================
  Files         130      130
  Lines       14778    14778
=======================================
  Hits         6307     6307
  Misses       7552     7552
  Partials      919      919

Flag
Coverage Δ

#linux
46.07% <ø> (ø)
:arrow_up:

#windows
38.26% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b4967b...9106f70. Read the comment docs.

Test failures don't seem to be related.

@fuweid
Can you take another look ?

The one test failure from https://travis-ci.org/containerd/containerd/builds/655654955?utm_source=github_status&utm_medium=notification is not related to the PR.

@Zyqsempai @mxpv @fuweid
Please review

Codecov Report

Merging #4057 into master will decrease coverage by 0.07%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master   #4057      +/-   ##
=========================================
- Coverage   42.67%   42.6%   -0.08%
=========================================
  Files         130     130
  Lines       14778   14807      +29
=========================================
+ Hits         6307    6308       +1
- Misses       7552    7580      +28
  Partials      919     919

Flag
Coverage Δ

#linux
45.73% <ø> (-0.34%)
:arrow_down:

#windows
38.26% <ø> (ø)
:arrow_up:

Impacted Files
Coverage Δ

runtime/v2/shim/util_unix.go
0% <0%> (ø)
:arrow_up:

services/server/server.go
2.47% <0%> (+0.08%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b4967b...45c85cf. Read the comment docs.

@Zyqsempai @mxpv @fuweid
ping for review

@fuweid what's the status on this one? I see you had concerns about this change; https://github.com/containerd/containerd/pull/4057#pullrequestreview-364981317

time="2020-03-04T23:52:58.010292585Z" level=error msg="RunPodSandbox for &PodSandboxMetadata{Name:create-PodSandbox-with-port-mapping46275150-5e73-11ea-8df4-42010a1401b0,Uid:cri-test-uid46275167-5e73-11ea-8df4-42010a1401b0,Namespace:cri-test-namespace4627516d-5e73-11ea-8df4-42010a1401b0,Attempt:2,} failed, error" error="failed to create containerd task: runtime \"io.containerd.runc.v1\" binary not installed \"containerd-shim-runc-v1\": file does not exist: unknown"

The above doesn't seem to be caused by my change.


Azure AD responses 401 when accquiring access token using the client_secret_jwt client authentication method

I have passed the case Access token request with a certificate using private_key_jwt client authentication method, but I can not find any document about client authentication using client_secert_jwt, it should be mimic with private_key_jwt client authentication method. I follow the doc OAuth2 Client Authentication with Azure AD, but I got the 401 response.
I propose there's section Fifth case: Access token request with a secret key in https://docs.microsoft.com/en-us/azure/active-directory/develop/v2-oauth2-client-creds-grant-flow, it will use the client_secert_jwt client authentication method to authenticate the client.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d32f55ac-acbc-292b-d1b7-ffdd257b11e1
Version Independent ID: ae2a266c-051b-7307-93fd-74bc521c93bf
Content: OAuth 2.0 client credentials flow on the Microsoft identity platform - Microsoft identity platform
Content Source: articles/active-directory/develop/v2-oauth2-client-creds-grant-flow.md
Service: active-directory
Sub-service: develop
GitHub Login: @nickludwig
Microsoft Alias: ludwignick

@moarychan
Thanks for your feedback! I've assigned this issue to the author who will investigate and update as appropriate.

Hey @moarychan - taking a look at this. Will circle back when I have an answer for you.

Hey @moarychan - client_secret_jwt isn't supported as part of our implementation of the client credentials flow. This is intentional and is why you're experiencing an error. Hope this helps!
I will leave this issue open for a few more days in case you have any follow up you'd like to add.

Closing as per above message

#please-close


Bulk upsert has no Save() function

Bulk upsert seems to only have Exec() but no Save() functions generated, so we have to make a separate call for getting the results of the upsert.
https://github.com/ent/ent/blob/9e809635b2e5815e259b4ab1ca08357341576a38/entc/gen/template/dialect/sql/feature/upsert.tmpl#L385
Looking at the template *UpsertBulk.Exec() calls *CreateBulk.Exec which eventually calls *CreateBulk.Save() but ignores the returned results. Is there a technical reason for the missing *UpsertBulk.Save() or has it just not been implemented yet?

Hey @e-nikolov and thanks for raising up this issue.

Is there a technical reason for the missing *UpsertBulk.Save() or has it just not been implemented yet?

Yes. Not all databases support the RETURNING clause on INSERT. What database do you use?
Also, when calling Create()..Save(), ent doesn't scan the created entity from the database. Instead, it gets only the entity ID from the database and uses the provided values in the returned object. This makes entity creation cheaper in terms of Go/database performance.

I use MySQL. I think the generated id field gets scanned from the database, which is what I'm interested in.

Do you mean for "AUTO_INCREMENT" id fields?
The way we get them on MySQL is by using the LAST_INSERT_ID (and a trick to set it on conflict mode). However, when you upsert multiple records, there's no way to get all "upserted" ids. Not only in Go or ent, in MySQL in general.

I struggle with same issue but I use postgres.
Generated code already postgres specific with check like is not supported by MySQL driver. Why not implement this feature for postgres?

I ran into this issue on the UpsertOne variants and was confused by by the different API structure!
(At this point I should mention that I really love the way the API produces readable code!)
I would really love if upsert was following the same API as the other operations.
Reading this thread I stared to ask myself if all variants should have the following methods:

Exec: just returning an error
ID: returning the ID and an error
Save: returning the entity (scanned or with an updated ID of the passed entity) and an error.

PS.
I am using sqlite since I am still evaluating...


Make code compatible with v740sp02

Consider this report: https://abaplint.app/stats/abapinho/abapTimeMachine/statement_compatibility
As suggested by Lars here: https://github.com/abapinho/abapTimeMachine/issues/86#issuecomment-874086296

Out of curiousity I did a local check to see what kind of statements need to be changed for 740sp02, it's mostly "quality of life" stuff:

inline data
SWITCH, FOR, VALUE, etc. statments

Could just change the readme to require 740sp08 and call it a day, up to you 😅

Out of curiousity I did a local check to see what kind of statements need to be changed for 740sp02, it's mostly "quality of life" stuff:

How did you do it @g-back? Did you install abaplint in your fork? I tried to go to abaplint's compatibility chart for your fork but it doesn't seem to be active.

1: install Node on the local PC
2: do npm install @abaplint/cli -g this will install abaplint as a global executeable on the system, use the same command to update to latest
3: clone the repo to local PC
4: adjust abaplint.json
5 in the repo folder, run abaplint on command line

Personally I used abaplint-sci client and server  - but that is a bit more involved to set up than what Lars suggested.

heh, yea
alternatively, create a new branch, edit the abaplint.json in the branch, open a draft pull request


Use modern features of Windows CMake build

With the CMake build setup for Windows, there are a few stale lines that should be modernized:

File geos_svn_revision.h no longer used
GEOS_BUILD_STATIC was removed from a previous GEOS release. Use BUILD_SHARED_LIBS=ON.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.
I do have some suggestions for making it better though...
For recipe:

License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

Documentation on acceptable licenses can be found here.

Another addition to this PR is to use the Ninja build system for Windows build to speed it up. Using the "NMake Makefiles" generator took nearly 23 minutes.

This is definitely a welcomed change but I'm not qualified to review it.
@gillins can you merge this if you are OK with it?

Thanks @mwtoews


OS Notifications on failure/recover

Do you want to request a feature or report a bug?
Feature

For my webpack builds, I have it set up to display an osx notification on error or recovery from errors. It'd be nice to also have this for jest. It lets me not have to switch to the terminal after every file save.
The webpack implementation uses this internally: node-notifier. It supports mac, windows, and linux.
Of course, this should be disabled by default.

Use --notify.

Thanks!

This notifies on every file change, not just on error/recover. If the tests are stable, I don't want a notification.

Feel free to send a pull request to add this feature.


Contributing.md

There is currently no contributing.md, some information on how to contribute would be beneficial.

The get involved section of the readme is sufficient.


feature/#615 added deprecation message for create pipeline api

#615

We probably need a small note in the release note. Otherwise, LGTM!

Yep. Here is the dedicated ticket.
https://github.com/Avaiga/taipy-doc/issues/465


amd_pstate module not being used

I would like to try amd_pstate driver instead of acpi_cpufreq, but although it compiles successfully, the module isn't loaded, whereas with mkinitcpio it all works well.

Could you please provide more context for what you are doing? Logs, config files...
Did you try to force loading this module?

Also, prefer to use "Discussions" page for general questions https://github.com/anatol/booster/discussions

config:
modules: amdgpu,amd_pstate
extra_files: fsck,fsck.ext4
strip: true

kernel vmlinux extra params: amd_pstate.shared_mem=1 initcall_blacklist=acpi_cpufreq_init
The module works as expected when loaded manually after boot (sudo modprobe amd_pstate).
The issue seems to be it is not loaded by booster.

Try to move your modules to modules_force_load: section like this
modules_force_load: amdgpu,amd_pstate
extra_files: fsck,fsck.ext4
strip: true

that did indeed fix the problem, do you know what could cause the normal loading not working?


Add command to re-parse webmentions

They should be cached in the storage/HTML/ folder.

this is getting into a full refactor

attempted in 0.0.11


coparceny, ferrary (logical-conflict)

This pull request was generated by the 'mq' tool

/trunk merge


Make referrer avaialble

Reported by lfayer on 1 Jan 1970 00:20 UTC
Add referrer option to $Request->ServerVariables

Comment by lfayer on 1 Jan 1970 00:20 UTC
(In [29]) return referer from ServerVariables. Supports both REFERER and REFERRER. refs #12

Modified by clinton on 1 Jan 1970 00:20 UTC


Create m-mulitple-select component

we're currently trying to use m-data-table for something that really should be a dropdown with checkboxes next to each item that when collapsed looks like a comma separated list.
What we're currently using

Something like this

Totally agree!
A mockup for this exists in the Discovery page in the UI Figma file where the dashboard filter redesign mockups are 👍


fix(grammar error): changed "Bash a script" to "a Bash script" at the specified locations.

Checklist:

[x] I have read and followed the contribution guidelines.
[x] I have read and followed the how to open a pull request guide.
[x] My pull request targets the main branch of freeCodeCamp.
[x] I have tested these changes either locally on my machine, or GitPod.

Closes #56086

Hey @HvGaur
Thank you for opening this pull request.
As there was different PR - #56091 - following all guidelines, merged recently, we are going to close this one.
Thank you and happy coding! 😊

If you have any questions, feel free to ask questions on the 'Contributors' category on our forum or the contributors chat room.


PL: Remove 3 branch development environment

overview
Having 3 separate branches to maintain on the protocol library is quite a pain for developers. This ticket serves as a placeholder until we decide on an option found below:
OPTION 1: one branch, keep subdomain

master and develop both contain ALL protocols. Whether they show up on the main site or the protocol-delivery subdomain depends on whether they're in protocols/public or protocols/protocol-delivery in the Protocol repo.
updates to master are deployed to main and protocol-delivery subdomain, in 2 different sets of artifacts
updates to develop similarly go to develop.protocols.opentrons.com and develop-protocol-delivery.protocols.opentrons.com, each URL points to a different set of artifacts.

OPTION 2: one branch, use special route instead of subdomain
make a route instead of a subdomain. Then protocols.opentrons.com/protocol-delivery is the "secret" delivery site, instead of the equally-not-actually-secret protocol-delivery subdomain. There is then only a single production artifact for each prod deploy, and only a single staging/develop artifact for each staging deploy. Vue is responsible for filtering the public vs private protocols at runtime.
OPTION 3: one branch, no subdomain, just don't make them findable
no protocol-delivery subdomain, no special route. The "private" protocols are tagged with .private dotfiles, and the parsers represent that tag in the JSON data. They simply are not listed in the categories or the search. Their URL is not obfuscated, it's just a normal slug.

Going with Op 3


The public repo does not have a description of many modules, although there is a description element in the module.xml files.

The public repo does not have a description of many modules, although there is a description element in the module.xml files.
For instance:
zpmshow, sslclien, restforms2-ui
Can you make a new release?

Resolved


IS_BEHIND_PROXY dont work

I will need more details as to your usage case to understand what the issue is...

As far as i see trhe Line number to remove the # in the url is wrong so the Enviroment Variable does nothing

Understood! I've just made appropriate adjustments, thanks for that!


Sort challenge question locale

In management console the list of locale for challenge questions are not sorted. Please provide a sorted list

Thank you for your contribution!
We are closing this issue since it has not been prioritized for a long time. Chances are that it has already been solved in more recent versions. If not, we will be re-evaluating this when it becomes a priority.


commitlint: body's lines must not be longer than 100 characters [body-max-line-length]

Dependabot commit messages body line lengths do not conform with commitlint's defaults.
Take a look at https://github.com/felipecassiors/megatar/pull/13 and https://github.com/felipecassiors/megatar/pull/14
It fails with:

⧗   input: build(deps-dev): bump @typescript-eslint/eslint-plugin

Bumps [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin) from 3.8.0 to 3.9.0.
- [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases)
- [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/CHANGELOG.md)
- [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v3.9.0/packages/eslint-plugin)

Signed-off-by: dependabot[bot]<EMAIL_ADDRESS>✖   body's lines must not be longer than 100 characters [body-max-line-length]

✖   found 1 problems, 0 warnings
ⓘ   Get help: https://www.conventionalcommits.org/

https://github.com/felipecassiors/megatar/pull/13/checks?check_run_id=969926394#step:4:19

This goes along with a similar issue #2056, where Dependabot will also make the commit header too long

I think this is covered by https://github.com/dependabot/dependabot-core/issues/2445, so I'm going to close this as a duplicate, feel free to add any context you feel is missing from that issue in the comments there.

@jurre it's not the same thing, this is about body line while the one you refer is about the subject line.

Meant to link to https://github.com/dependabot/dependabot-core/issues/1666

Or perhaps it should be smarter when URLs are detected. There is no way to break an URL into multiple lines.

@felipecrs I don't know how much of a difference this would make for grouped updates. I removed the URLs from the first line of an update to a group of four dependencies and it's still too long.
Interestingly, in a PR which would update five dependencies at once, they are put in a Markdown table instead. Which would work with the URLs removed. Though that PR exceeds the allowed subject length. :upside_down_face:
I feel like an on/off switch for the inclusion of project URLs for dependencies in Dependabot messages might be the most useful solution. Or, better yet, a differentiation between Git commit messages and PR (meta) info. That Markdown table for grouped dependencies isn't useful outside of Markdown-based UIs, and neither are Markdown-formatted URLs.


[Blazor server side] stop propagation of the event onclick/oncontextmenu

Hello !
This issue following this one which is old and seem have no really answer
https://github.com/aspnet/Blazor/issues/715
I wanted to know if there is a way to stop propagation of the event now.
In my context, i want to stop it on the event contextMenu to prevent browser showing his context menu (and show mine instead)
the only way to do this actually seem attach the event in javascript and then call c# code, but it's a little complex and maybe there is better to do with blazor now.
Thanks for your responses !

This is tracked by https://github.com/aspnet/AspNetCore/issues/5545


[Bug] Changing only brightness and color temperature turns on bulb

Please use the template and fill in all the data requested below!
Describe the bug
I have a setup with homekit automations that set scenes at a certain time (I change the color temperature and brightness of my ambient lights for da, evening end night settings). The scenes are set up to only change the brightness and temperature but leave the on/off state untouched. When I used deconz, this worked like a charme.
With zigbee2mqtt all related lights turn on when setting these scenes.
Related devices
Mostly hue bulbs.
To Reproduce
Steps to reproduce the behavior, for example:

Set a scene that only changes color temperature and brightness for bulbs that are switched off.
[23.11.2021, 20:37:09] [zigbee2mqtt] Publish to 'zigbee2mqtt/0x00178801090cd17a/set': '{"color_temp":454,"brightness":114}'
The brightness and color temperature changes but the device turns on.

Expected behavior
I expect that the color temperature and brightness ist set but the state of the bulb stays untouched.
MQTT messages
If possible (and applicable), please provide the following:

The device entry from zigbee2mqtt/bridge/devices (note: this is different from zigbee2mqtt/bridge/config/devices)

{     "date_code": "20210422",     "definition": {       "description": "Hue white ambiance E14 (with Bluetooth)",       "exposes": [         {           "features": [             {               "access": 7,               "description": "On/off state of this light",               "name": "state",               "property": "state",               "type": "binary",               "value_off": "OFF",               "value_on": "ON",               "value_toggle": "TOGGLE"             },             {               "access": 7,               "description": "Brightness of this light",               "name": "brightness",               "property": "brightness",               "type": "numeric",               "value_max": 254,               "value_min": 0             },             {               "access": 7,               "description": "Color temperature of this light",               "name": "color_temp",               "presets": [                 {                   "description": "Coolest temperature supported",                   "name": "coolest",                   "value": 150                 },                 {                   "description": "Cool temperature (250 mireds / 4000 Kelvin)",                   "name": "cool",                   "value": 250                 },                 {                   "description": "Neutral temperature (370 mireds / 2700 Kelvin)",                   "name": "neutral",                   "value": 370                 },                 {                   "description": "Warm temperature (454 mireds / 2200 Kelvin)",                   "name": "warm",                   "value": 454                 },                 {                   "description": "Warmest temperature supported",                   "name": "warmest",                   "value": 500                 }               ],               "property": "color_temp",               "type": "numeric",               "unit": "mired",               "value_max": 500,               "value_min": 150             },             {               "access": 7,               "description": "Color temperature after cold power on of this light",               "name": "color_temp_startup",               "presets": [                 {                   "description": "Coolest temperature supported",                   "name": "coolest",                   "value": 150                 },                 {                   "description": "Cool temperature (250 mireds / 4000 Kelvin)",                   "name": "cool",                   "value": 250                 },                 {                   "description": "Neutral temperature (370 mireds / 2700 Kelvin)",                   "name": "neutral",                   "value": 370                 },                 {                   "description": "Warm temperature (454 mireds / 2200 Kelvin)",                   "name": "warm",                   "value": 454                 },                 {                   "description": "Warmest temperature supported",                   "name": "warmest",                   "value": 500                 },                 {                   "description": "Restore previous color_temp on cold power on",                   "name": "previous",                   "value": 65535                 }               ],               "property": "color_temp_startup",               "type": "numeric",               "unit": "mired",               "value_max": 500,               "value_min": 150             }           ],           "type": "light"         },         {           "access": 2,           "description": "Triggers an effect on the light (e.g. make light blink for a few seconds)",           "name": "effect",           "property": "effect",           "type": "enum",           "values": [             "blink",             "breathe",             "okay",             "channel_change",             "finish_effect",             "stop_effect"           ]         },         {           "access": 1,           "description": "Link quality (signal strength)",           "name": "linkquality",           "property": "linkquality",           "type": "numeric",           "unit": "lqi",           "value_max": 255,           "value_min": 0         }       ],       "model": "9290022944",       "options": [         {           "access": 2,           "description": "Controls the transition time (in seconds) of on/off, brightness, color temperature (if applicable) and color (if applicable) changes. Defaults to 0 (no transition).",           "name": "transition",           "property": "transition",           "type": "numeric",           "value_min": 0         },         {           "access": 2,           "description": "When enabled colors will be synced, e.g. if the light supports both color x/y and color temperature a conversion from color x/y to color temperature will be done when setting the x/y color (default true).",           "name": "color_sync",           "property": "color_sync",           "type": "binary",           "value_off": false,           "value_on": true         }       ],       "supports_ota": true,       "vendor": "Philips"     },     "endpoints": {       "11": {         "bindings": [],         "clusters": {           "input": [             "genBasic",             "genIdentify",             "genGroups",             "genScenes",             "genOnOff",             "genLevelCtrl",             "touchlink",             "develcoSpecificAirQuality",             "lightingColorCtrl"           ],           "output": [             "genOta"           ]         },         "configured_reportings": [],         "scenes": []       },       "242": {         "bindings": [],         "clusters": {           "input": [],           "output": [             "greenPower"           ]         },         "configured_reportings": [],         "scenes": []       }     },     "friendly_name": "Flur Kommode",     "ieee_address": "0x00178801090cd17a",     "interview_completed": true,     "interviewing": false,     "manufacturer": "Signify Netherlands B.V.",     "model_id": "LTE002",     "network_address": 7109,     "power_source": "Mains (single phase)",     "software_build_id": "1.88.2",     "supported": true,     "type": "Router"   },

Status update from zigbee2mqtt/[FRIENDLY_NAME]
{"brightness":114,"color_mode":"color_temp","color_temp":454,"linkquality":255,"state":"OFF","update":{"state":"idle"},"update_available":false}
Changes to:
{"brightness":8,"color_mode":"color_temp","color_temp":454,"linkquality":255,"state":"ON","update":{"state":"idle"},"update_available":false}

Versions used
Please provide the version of the following pieces of software:

This plugin: homebridge-z2m v1.6.1
Homebridge: v1.3.8
Zigbee2MQTT: commit a51626e3
Homebridge Config UI X: homebridge-config-ui-x v4.41.2

The data send to Zigbee2MQTT via MQTT doesn't contain a state change. I think this behavior is caused by Zigbee2MQTT, not this plugin.


embulk -X gem_home /path/to/foo (not gem_home=/pat/to/foo)

Filed last year's discussion.
-X key val not -X key=val work unexpectedly.
java -jar /path/to/embulk/embulk-0.10.35.jar \
  -X embulk_home=/tmp/embulk_with_equal \

https://gist.github.com/hiroyuki-sato/49374af77dcc8877b4661893530af434
https://twitter.com/dmikurube/status/1517312140864294912?s=20

I could come from Apache Commons CLI's behavior.
We cannot "fix" it if so, but, we'll use -X key=value in our all public documents.
-X key value may work, but we basically do not expect it, and it's not our official recommendations.
Does this work for you?

Thank you for your comment. That policy looks good for me.


Carriage return in resource label

Don't know if you should accept or not carriage return char \r in labels? (actually, you're not accept it while \n is accepted):
{
  "@type" : "anything:Thing",
  "knora-api:attachedToProject" : {
    "@id" : "http://rdfh.ch/projects/0001"
  },
  "rdfs:label": "Transcription ; Les bons historiens sont les meilleurs precepteurs d'une nation\r\n",
  "@context" : {
    "rdf" : "http://www.w3.org/1999/02/22-rdf-syntax-ns#",
    "knora-api" : "http://api.knora.org/ontology/knora-api/v2#",
    "rdfs" : "http://www.w3.org/2000/01/rdf-schema#",
    "xsd" : "http://www.w3.org/2001/XMLSchema#",
    "anything" : "http://<IP_ADDRESS>:3333/ontology/0001/anything/v2#"
  }
}

Error:
{
    "knora-api:error": "org.knora.webapi.BadRequestException: Invalid http://www.w3.org/2000/01/rdf-schema#label: Transcription ; Les bons historiens sont les meilleurs precepteurs d'une nation\r\n",
    "@context": {
        "knora-api": "http://api.knora.org/ontology/knora-api/v2#"
    }
}

Do I have to cleanup my string labels inputs?

@tobiasschweizer If I remember correctly, we had to reject \r (in StringFormatter.toSparqlEncodedString()) because we used that character internally as a word separator so that the Lucene full-text search index would find words that are separated by markup but not by whitespace. But looking at the code, it seems that we now use INFORMATION SEPARATOR TWO (U+001E) for this. So is there any reason to reject \r?

If I remember correctly, we had to reject \r (in StringFormatter.toSparqlEncodedString()) because we used that character internally as a word separator so that the Lucene full-text search index would find words that are separated by markup but not by whitespace.

If you have two parts in a text marked up as paragraphs and remove the markup, they wouldn't necessarily be separated in the string representation, so we add INFORMATION SEPARATOR TWO (U+001E). But this does not depend on an actual newline, it is a setting in the mapping: separatesWords, https://docs.knora.org/paradox/03-apis/api-v1/xml-to-standoff-mapping.html#basic-structure-of-a-mapping
Wasn't the reason to reject \r the differences in line endings between Unix and Windows that we do not want to end up in the tripelstore?

Wasn't the reason to reject \r the differences in line endings between Unix and Windows that we do not want to end up in the tripelstore?

Maybe. If so, I think it still makes sense.
@gfoo

Do I have to cleanup my string labels inputs?

Would it really be useful to have \n in a label? It won't be displayed correctly in a browser anyway, it will just appear as a space.

yep, not usefull. This character is really confusing anyway. I cleaned my input data,  no problems there, you can close.
n.b. : the main use case is when Windows' users copy/paste data containing \r chars, but it is the role of the UI to clean data I think.


Switch circle CI to tox

It makes sense to use the same technologies locally and in CI
as it simplifies local debugging and verifing changes
Before this patch we did run sdist (bulding package) and functional
tests in CI and we were uploading coverage report to covecod
After this PR we are adding code style jobs, unittests with coverage
as well as keeping old jobs in place (but run through tox)
As well now we have 2 reports to upload one for functional tests
one for unittests

@swilly22 here is the PR that should address circle ci issues, but for some reason circle Ci is not running on my PR

@swilly22 I saw some very old
 configuration option. It seems like you'll need to enable it in CircleCI configuration. so circle CI is triggered on opened PR

@swilly22 CI is still not working, hm will prepare one more PR

@boris-42 still no go
#!/bin/bash -eo pipefail
pip install tox
Collecting tox
  Downloading https://files.pythonhosted.org/packages/e0/79/5915b9dad867e89bb6495456acfe5d4e2287e74dfa29c059f7b127d5480e/tox-3.20.1-py2.py3-none-any.whl (83kB)
    100% |████████████████████████████████| 92kB 3.6MB/s eta 0:00:01
Collecting virtualenv!=20.0.0,!=20.0.1,!=20.0.2,!=20.0.3,!=20.0.4,!=20.0.5,!=20.0.6,!=20.0.7,>=16.0.0 (from tox)
  Downloading https://files.pythonhosted.org/packages/1a/c6/bb564f5eec616d241e85d741f00a07f5f50ea12989022ad49bc66876993c/virtualenv-20.2.2-py2.py3-none-any.whl (5.7MB)
    100% |████████████████████████████████| 5.7MB 289kB/s eta 0:00:01
Collecting pluggy>=0.12.0 (from tox)
CircleCI received exit code 2

https://app.circleci.com/pipelines/github/RedisGraph/redisgraph-py/459/workflows/c2deb5ab-7f88-4805-81e9-e4e041cb154f/jobs/821


Update Node CHANGELOG.md

Not sure this is really a feature. It's more of a bugfix actually. We were otherwise C++17 for a while now (maybe that should actually be the feature).

Ah yes, it's not a feature, I'm just following the former notes, since a PR was approved and I forgot to mention it in the CHANGELOG.md.

OK, maybe something for @louwers and @ovivoda to try to improve in the future.

Our main focus is Core, Android and iOS and in principle we don't spend too much time on other platforms. We also don't make releases for them.

What I meant is we may want to define general guidelines on changelogs and release notes.

Thanks for clarifying this @louwers. People are welcome to contribute to all platforms and it is great if they handle releases. The paid maintainers focus is on iOS and Android.

Maybe I should have tagged you Oliver then 😊

Usually I do the node releases, so a appreciate the changelog being uodated sinc eit helps me make the release
I agree though that this should maybe be under bug fixes. maybe something like "fixed -std=c++11 when building node release", or something like that.
Could you add a heading
🐞 Bug fixes
and add this under it, like https://github.com/maplibre/maplibre-gl-native/edit/main/CHANGELOG.md

Done!


Cannot view publiccdn.sharepointonline.com in sources/chrome after enabling CDN

Category

[x] Bug

Describe the bug
I enabled CDN just like it said in the documentation, then shipped and packaged the files. When I get to the end of this page where it says
"Open your browser's development tools and open the Sources tab.
Extend publiccdn.sharepointonline.com under the source and notice how the hello-world-web-part file is loaded from the Public CDN URL pointing dynamically to a library located under the app catalog site collection."
Even though I have enabled CDN, I still only see it in the my tenant client side. The publiccdn.sharepointonline.com is not in there at all in my chrome source.

Steps to reproduce

DELETE THIS LINE BEFORE SUBMITTING - Provide steps to reproduce the behavior:

gulp bundle --ship
gulp package-solution --ship
upload the new helloworld-webpart.sppkg
open browsers dev tools and go to sources, look for public

Expected behavior
Should be showing the publiccdn.sharepointonline.com
Environment details (development & target environment)

Your Developer Environment: 10.15.7 (19H2)
Target Environment: SharePoint Online
Framework:React
Browser(s): Chrome 85.0.4183.121
Tooling: VS Code
Additional details: The more context you can provide, the easier it is (and therefore quicker) to help.

Additional context

The CDN can take up to 30 minutes to get provisioned. You reference a URL in your question, but don't include the URL. Also, you are missing context on what version of SPFx you're using.

@andrewconnell thank you that was it! I wish it would of said it takes time to provision


new service factory: CPS (Cloud Pub/Sub)

This commit adds a new service factory, whereby messages are delivered by publishing to a Cloud Pub/Sub topic.

Thanks for the PR Dan, could you re-run generate_go_py_protos.sh? a diff in generated proto files is blocking the merge atm

Thanks for the PR Dan, could you re-run generate_go_py_protos.sh? a diff in generated proto files is blocking the merge atm

Sure - I added this as a new commit since it touched a bunch of proto files. Let me know if you'd rather I squashed it.

Oh no it seems that it's generating the go proto files with a different version than expected 🤔
Granted, this part of fleetspeak development is frustratingly tricky...
the github actions are setup with the following versions:
          go install<EMAIL_ADDRESS>          go install<EMAIL_ADDRESS>
were you running the script from a python virtualenv specifically for fleetspeak, where fleetspeak_python is installed? That should come with the correct versions for everything

were you running the script from a python virtualenv specifically for fleetspeak, where fleetspeak_python is installed? That should come with the correct versions for everything

Ah, I see. Running from a fleetspeak_python venv seems to have done the trick: only the cpsservice proto was updated.


Regex on auto-linkification is too much restricted

What I want to do is something like [aA][bB][cC]!(?P<id>[0-9]+), but it doesn't allow both the !, and the [aA] thing.

The reason behind the restrictions in the regular expressions is to prevent potential security issues (e.g. DoS problems).  I think it's very possible that a better design could be developed that offers more power without increased risk of security problems.

@zulipbot claim


Update scalafmt-core to 3.3.2

Updates org.scalameta:scalafmt-core from 3.3.1 to 3.3.2.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.scalameta", artifactId = "scalafmt-core" } ]

labels: library-update, early-semver-patch, semver-spec-patch, commit-count:1

Codecov Report

Merging #21 (a72c60a) into main (1dbcaa6) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #21   +/-   ##
=======================================
  Coverage   48.64%   48.64%
=======================================
  Files           5        5
  Lines          37       37
=======================================
  Hits           18       18
  Misses         19       19

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1dbcaa6...a72c60a. Read the comment docs.


How to access static fields (getters)?

The capability StaticInvokeCapability is documented

Gives support for reflective invocation of static members (static methods, getters, and setters)

I tried to invoke the getter with this methods:
classMirror.invoke(field, []);,
classMirror.invokeGetter(field);,
but I always get this error"
Unhandled exception:
NoSuchCapabilityError: no capability to invoke the method 'FACTORY_CONFIG'
Receiver: null
Arguments: []

The classMirror object is certainly not null, I checked that, so the "receiver" mentioned is something internal.
For completeness, these are capabilities I have: libraryCapability, staticInvokeCapability, declarationsCapability, newInstanceCapability, typeRelationsCapability

I tried adding all available capabilities and the error persists. So I suspect this to be either a bug or I'm trying to call them in an incorrect way.

Were you able to resolve this issue? Polymer is using this so it's definitely possible.

Yeah, it was my bad. I had one case where the receiver was indeed null, but
with every test all cases were loaded, so I thought all cases were giving
the error. It's fixed now.
On Tue, Jan 26, 2016 at 3:50 PM, Jacob MacDonald<EMAIL_ADDRESS>wrote:

Were you able to resolve this issue? Polymer is using this so it's
definitely possible.
—
Reply to this email directly or view it on GitHub
https://github.com/dart-lang/reflectable/issues/66#issuecomment-175056201
.


2FA authentication not working

Mobile number verification and 2FA is not working for wallet creation.

Hello! Thank you for issuer, which country your number is?

India. I mean 2FA authentication is not available for many wallet creating. it is blacked out


Double arrows aren't alligned correctly

Consider this code:
$arr = [
                'foo' => 'bar',
            'quatz'             => 'test'
        ];

I would expect that fooand bar are equally aligned  (on the indentation of quatz) and that the double arrows are also equally aligned on the indentation of quatz's double arrow.
But I got this:
        $arr = [
                'foo'           => 'bar',
            'quatz'             => 'test'
        ];

edit:
What I would have expected would be this:
$arr = [
	'foo'   => 'bar',
	'quatz' => 'test',
];

That is technically aligned correctly, and this is a duplicate I think.

It's just not aligned to the minimum possible.

Sorry if that is a duplicate, I probably missed it. Would it be possible to align it to the minimum?

discussion is here: https://github.com/FriendsOfPHP/PHP-CS-Fixer/pull/1273

and here: https://github.com/FriendsOfPHP/PHP-CS-Fixer/issues/1055


Cleanup: don't spill 'fs' namespace shortcut into global namespace.

We should never put namespace abbreviations in header files in
the global namespace. One alternative would be to put them inside
our namespace (SURELOG::fs::), but the cleanest is to never use
it in the headers, only *.cpp compilation units.
Signed-off-by: Henner Zeller<EMAIL_ADDRESS>

Codecov Report

Merging #2491 (0bc0e90) into master (6cb4bca) will increase coverage by 0.00%.
The diff coverage is 39.13%.

@@           Coverage Diff           @@
##           master    #2491   +/-   ##
=======================================
  Coverage   28.26%   28.26%
=======================================
  Files         191      191
  Lines       33266    33265    -1
=======================================
+ Hits         9402     9404    +2
+ Misses      23864    23861    -3

Impacted Files
Coverage Δ

src/Cache/Cache.cpp
0.00% <0.00%> (ø)

src/Cache/PPCache.cpp
1.93% <ø> (ø)

src/Cache/ParseCache.cpp
7.33% <ø> (ø)

src/CommandLine/CommandLineParser.cpp
2.58% <ø> (ø)

src/CommandLine/CommandLineParser.h
76.19% <0.00%> (ø)

src/Design/DesignComponent.h
76.74% <ø> (ø)

src/Design/FileContent.cpp
45.27% <ø> (ø)

src/DesignCompile/CompileClass.cpp
36.79% <ø> (ø)

src/DesignCompile/CompileDesign.cpp
49.57% <ø> (ø)

src/DesignCompile/CompileExpression.cpp
28.55% <ø> (ø)

... and 27 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6cb4bca...0bc0e90. Read the comment docs.


Released v2.4.1 with these fixes

Thanks for the release!  That fixed https://bugzilla.redhat.com/show_bug.cgi?id=1823192


Updated CI Workflow

Updated the contents of python-app.yml to match the CI used in the test repository. Specific changes include:

Setting the workflow to run for pushes and pull requests to 'development' (previously the only specified branch was 'main')
Adding build tests for multiple versions of Python (3.10, 3.11, and 3.12).
Adding a "branch name check" which ensures that nothing is merged to main other than 'development' and hotfix branches.

Now that I'm looking at the previous CI document, it may be worth separating out tests from the build as different jobs, so that it is clearer where the failure occurred. Regardless, I need to fix the dependency issue for 3.12 before I can merge this into development anyways, so I'll need to close this request.

Closing this pull request now; will create another request once the dependency fix has been merged into this branch.

During testing, making changes to a branch after starting the pull request seemed to cause issues, but in this case I was able to re-open and use this pull request for the branch after merging the dependency fixes in. Status checks all passed, so I will merge these changes into development.

I have now renamed the pull request to make the changes clearer. Because the merge was successful, I will now delete the branches for the two features.


fix: publish docs by copying readme to dist

:tada: This PR is included in version 1.0.5 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Go CLI Produces an Invalid Response When Whisk.Error() is Invoked

Provide proper message when whisk.error() is invoked
Add test to ensure whisk.error() responses are received.
Add ability to disable error prefixes

Please review.

https://github.com/openwhisk/openwhisk/issues/815

IPG 265.

@dubeejw - looks like there was a PG build issue.
system.basic.WskBasicTests > Wsk Action CLI should create and invoke a blocking action resulting in a whisk.error response FAILED
    org.scalatest.exceptions.TestFailedException: "ok: invoked /_/whiskError with id 6355e78cd85a4952b8196448e25208e6
    " did not include substring that matched regex "error": "This error thrown on purpose by the action."
        at org.scalatest.MatchersHelper$.newTestFailedException(MatchersHelper.scala:160)

IPG 276.

Any more suggestions on this one?

Updated so that the Go CLI returns an exit code. Please review.

Fixes https://github.com/openwhisk/openwhisk/issues/815


update README and functions docs

PR Details

Description

Related Issue

Motivation and Context

How Has This Been Tested

Types of changes

[ ] Docs change / refactoring / dependency upgrade
[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist

[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

Codecov Report

Merging #351 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #351   +/-   ##
=======================================
  Coverage   98.59%   98.59%
=======================================
  Files          19       19
  Lines        4128     4128
=======================================
  Hits         4070     4070
  Misses         34       34
  Partials       24       24

Impacted Files
Coverage Δ

rows.go
94.48% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12c1e24...b75b6d8. Read the comment docs.

LGTM, thanks @Kimxu.


fix(deploy): clean up gh-pages obsolete files (#3081)

Prevents the gh-pages branch from growing indefinitely by cleaning up before copying new files.
Fixes #3081

I signed the CLA with an alternative e-mail attached to the Google account. Google does not pick up on this?
Also, I realize this is failing the tests, but I need feedback.
Specifically, I'm not sure pursue the failed test Error: ExecStub - unexpected command: git rm -r , given the dynamic arguments supplied to the command.

LGTM. Thanks!


setup-gcloud does not work in example

it appears as though the setup-gcloud action in the example does not work. The workflow example cited in this repository and on the marketplace uses ubuntu-latest as the image, but its missing python-openssl from the base image as well as a setting . To make it work, this repository either needs to include it itself (probably not considering how sparse this is) or you need to do the following
...
env:
    CLOUDSDK_PYTHON_SITEPACKAGES: 1

...

    # steps

    - name: install python-openssl
       run: sudo apt-get install -y python-openssl -o=Dpkg::Use-Pty=0

it appears as though the setup-gcloud action in the example does not work.

What error are you getting if you don't install python-openssl, @trevoro?

gcloud auth activate-service-account *** --key-file=/tmp/tmp-8931VSIBcdJY8Icv
/bin/tar xz -C /home/runner/work/_temp/c5d195bb-1ace-4331-9be7-5ddb6b45397b -f /home/runner/work/_temp/81352a93-56e4-444f-bc12-f7e7ba184cc9
WARNING: .p12 service account keys are not recomended unless it is necessary for backwards compatability. Please switch to a newer .json service account key for this account.
ERROR: (gcloud.auth.activate-service-account) PyOpenSSL is not available. If you have already installed PyOpenSSL, you will need to enable site packages by setting the environment variable CLOUDSDK_PYTHON_SITEPACKAGES to 1. If that does not work, see https://developers.google.com/cloud/sdk/crypto for details or consider using .json private key instead.
##[error]The process 'gcloud' failed with exit code 1
##[error]Node run failed with exit code 1

To make it work the way it is now, I had to take the json file, pull out the key and base64 encode it and use that as the environment variable. If that was totally the wrong way to do it, this could be a documentation and (obviously) PEBKAC error. ;)

Hi @trevoro the documentation for the action does stipulate that the key should be Base64 encoded here: https://github.com/GoogleCloudPlatform/github-actions/tree/master/setup-gcloud#inputs
Here's a list of the software installed by default on the runners, which includes multiple versions of Python: https://help.github.com/en/actions/automating-your-workflow-with-github-actions/software-installed-on-github-hosted-runners

OK that's fine; but the example on Github Marketplace which is a full blown example does not actually work. It's obviously your prerogative to choose whether or not to include Python in the example. Thanks!

Thanks @trevoro Could you please provide a link to the example you're referring to?

@trevoro is this the action you're referring to on this issue? https://github.com/marketplace/actions/google-cloud-platform-gcp-cli-gcloud
This is a separate action from the officially supported setup-gcloud action found here: https://github.com/GoogleCloudPlatform/github-actions/tree/master/setup-gcloud

Hey sorry. I'm not trying to be obtuse about this :)

When I navigated through the marketplace and clicked the "build and deploy to GKE" workflow I got this template https://gist.github.com/trevoro/7b2fda6fcfddb90fe858b94dc4753a5f populated in the in-browser editor
That template has instructions that say to setup your secrets in the workspace where GKE_KEY is the service account key. I agree that there are instructions on how to format the base64 key but they're not referenced in the gist above.
If the key is not encoded properly OR not set you get this error:

gcloud auth activate-service-account *** --key-file=/tmp/tmp-26506ls0Nsxf4ZHG
/bin/tar xz -C /home/runner/work/_temp/c7710d94-bd72-4383-95c1-ae8c8bd5ecd3 -f /home/runner/work/_temp/2d56b3e0-a0a1-4dfd-866a-2fc9283f36a6
WARNING: .p12 service account keys are not recomended unless it is necessary for backwards compatability. Please switch to a newer .json service account key for this account.
ERROR: (gcloud.auth.activate-service-account) PyOpenSSL is not available. If you have already installed PyOpenSSL, you will need to enable site packages by setting the environment variable CLOUDSDK_PYTHON_SITEPACKAGES to 1. If that does not work, see https://developers.google.com/cloud/sdk/crypto for details or consider using .json private key instead.
##[error]The process 'gcloud' failed with exit code 1
##[error]Node run failed with exit code 1

Which naturally makes one wonder why PyOpenSSL wouldn't be installed in the first place... presumably because its not required for the keys if they're formatted the right way.
I've gotten this working only by installing openssl for python in the workflow itself; so the base image that is the default template when you create the action through the marketplace seems to be missing a library required to make it work.
Can you not reproduce this on your side?

Thanks for the follow up @trevoro. Could you please provide a link to the marketplace link you followed?

Hi @trevoro, I just PR'd an explanation in the starter workflow as well as the README so others don't bump into this issue. As far as I can tell, this isn't a dependency issue. Could you try using the results of cat path-to-key.json | base64 as the GKE_KEY secret?

Just to let you know @imjohnbo I had same issue and changed GKE_KEY for base64 and it worked.
In the GKE Template is not showing base64 information.
GKE_KEY with the service account key.


Created a user friendly Experience.

- > Changes I made

Made changes to the entire code
Added CSS files and made a better UI.
Made it responsive
Edited the questions

approved


C-g doesn't return point when using Swiper via ivy-resume

Steps:

C-s search query, accept a result
C-x C-r to resume search, select a different result but don't accept
C-g, I should be returned to the original result I accepted but I'm not

Fixed by dropping Swiper.


Npgsql.CrateDb needs to be strongly-named assembly.

Hi, I am using Npgsql.CrateDb that was loaded from Nuget. In my scenario, ASP.net complains that the assembly needs to be strongly-name.
It seem Npgsql is strongly named, but not the Crate version of Npgsql. Someone might want to post a signed one to Nuget?

Hi @biglobe, we are just finishing our GAC installer which contains a strongly named version of the Crate.io fork. So a new Nuget package with a signed version of the Crate.io fork should be available pretty soon.

Will there be any conflicts if both original npgsql and cratedb are in GAC?

Hi @monanllc, theoretically not. The official npgsql and the Crate.io fork each have their own strong names so they should be able to live side by side in the GAC. The entry for the Npgsql Data Provider in machine.config determines, which assembly will be used.
But there should be no problem using the Crate.io fork to access PostgreSQL and CrateDB.

@apircher Thanks for clarification. May I ask when did you fork the npgsql (pre-4.x vs post-4.x)?

@monanllc We forked pre-4.x but we rebase on a regular basis. Currently we are on the state of the beginning of August - so it's clearly post-4x.

@apircher thanks for the info.


[theme] How to override the styles of the disabled property?

Steps to reproduce
Link to live example: https://codesandbox.io/p/sandbox/objective-hamilton-8cwwr2?file=%2Fsrc%2FApp.js%3A6%2C1
Steps:

add theme

Current behavior
Background color isn't red
Expected behavior
Background color is red
Context
Themin
Your environment
all browsers
Search keywords: disabled property override theme

Targeting using disabled class works. See https://codesandbox.io/p/sandbox/peaceful-dhawan-8pyj6r. But I think disabled as a prop should also be allowed in variants, or we should pick one method (prop or class) and document it. cc @siriwatknp

@ZeeshanTamboli Actually, the custom style is applied to the Button but the default disabled styles has higher specificity.
This is expected for styling, disabled should have higher specificity. The correct approach is to either use a class or :disabled CSS selector:
const theme = createTheme({
  components: {
    MuiButton: {
      styleOverrides: {
        root: {
          variants: [
            {
              props: { variant: "contained" },
              style: {
                '&:disabled': {
                  background: 'black',
                }
              },
            },
          ],
        },
      },
    },
  },
});


[turborepo] Setting dotEnv-field used file instead of defined environment variables

What version of Turborepo are you using?
1.10.0
What package manager are you using / does the bug impact?
pnpm
What operating system are you using?
Mac
Describe the Bug
I have defined .env.example as the value for dotEnv in turbo.json but it not using the environment variables defined in this file but somehow uses the file itself.
Expected Behavior
Ability to quickly source tens of environment variables by linking up a .env file (e.g. .env.example) via turbo.json
To Reproduce
Create .env.example file
AUTH_URL=
ACCOUNT_URL=
DATABASE_URL=
MAX_REFRESH_INTERVAL=

add it to turbo.json like:
"dotEnv": `.env.example`

Run dry-run on the project, e.g. turbo run build --dry-run=json
Expect the dry-run to list the four environment variables as part of:
"environmentVariables": {
        "configured": [],
        "inferred": [],
        "global": [
          "DATA=",
          "VERCEL_ANALYTICS_ID="
        ],
        "passthrough": null,
        "globalPassthrough": null
      }

Reproduction Repo
No response

Hey @weyert the new feature doesn't load the .env file, it just incorporates it into task hashes, since they are sometimes .gitignore'd and thus changes can cause accidental cache hits. Docs coming soon (#5078).
However, I'd love to hear your use case for using Turborepo to load your env vars. What were you doing before, and is there something you would want turbo to do to help?

Ah okay then I misunderstood it. Yeah, my idea was to make it quicker and easy to maintain environment variables listed in turbo.json. Guess, I can write a script that reads dotenv file and update turbo.json manually.

@weyert you don't need to enumerate any env vars that are listed in .env files. As long as the .env files are listed for the correct task, we will take them into account in the file hash. You can continue loading them however you like. With this change, turbo won't need them to be loaded beforehand, since the contents of the file itself get hashed.
What will still need to be enumerated in turbo.json are any env vars that are not loaded from a file, but come from some external source. So if you are currently using dotenv my.env && turbo my-task you can probably  drop the dotenv invocation, as long as something in my-task loads my.env for you.

Yes, but wouldn't the environment variables in CI affect the remote cache? Especially, when you don't use dotenv files in those environments, e.g. CI or docker builds? (aside, I have to admit I haven't got caching work in those places yet.)

If you are running different tasks in CI and locally, then you can configure them separately. If you are running the same task locally and in CI with different env vars, you want those tasks to be cached independently.

I believe the gap here is that most people use .env files only in dev. They might have env vars X, Y, and Z set to dev values, and stored in an .env file that is not committed. When deploying to production, the production values are set directly on the build process, and not added to any .env-* file.
For that common use case, the dotEnv field in turbo.json won't be helpful, as you would still need to enumerate your env vars as part of env or globalEnv to ensure they are correctly accounted for in the production environments hash.

Closing the loop (and issue): with the dotEnv setting, you will catch changes to the .gitignore'd .env file that previously turbo would have missed.
Any environment variables that can be set externally continue to need to be specified in env.