cmake: Upgrade to C++17

Addresses various other issues with setting compiler flags.
CMAKE_C_FLAGS / CMAKE_CXX_FLAGS should NOT be used anymore.
Addressed one minor C++17 issue caused by [[nodiscard]].
Remove compiler flags from Application.mk since they weren't needed and will soon be entirely replaced by CMake.
closes #711

CI Vulkan-Tools build queued with queue ID 58107.

CI Vulkan-Tools build # 1199 running.

CI Vulkan-Tools build # 1199 passed.

GHA is passing in my fork.


📝 [Sticky] UI Kitten 5.0 Discussion & Roadmap

This is a communication-open issue indicating version 5.0 roadmap.
Yes, we're going to skip future 4.x releases since it will introduce some breaking changes 💣
Our plan is:
Features

📆 Time Picker #778

📚 Documentation for Eva Theme System.

For now, we realize that background-basic-color-1 looks like a magic string. And that's why we should describe all theme variables exported from Eva and describe how and where they're used and where not.
Bug Fixes

We're going to close several minor issues during the 4.4.x patch releases. If you have some, please open an issue or send us a PR so we can handle it.

Refactoring

🤔More flexibility in component props by rethinking current APIs.

We're going to add support of passing Component classes as well as Functional components to component props. A good example for this is a title property of TopNavigation component which more likely can include an Image.
This should close the following issues: #564 #737 #777 #810 #863
Currently, we're investigating this feature and looking for a good architecture solution. If you have any suggestions, feel free to mention them in the discussion.

💣 BREAKING: Unification of property names. For example, Select and Autocomplete items should have a same property name for a title. Currently, text and title are used.

💣 [NOT ACCEPTED] BREAKING: Unification with React Native property names. For example, use title property for button instead of passing text as children. Let us know how do you feel about that.

Migration

Starting from v5, this repository will be moved under Eva Design project.

Also, keep in mind that we're going to completely deprecate react-native-ui-kitten package in order to use @ui-kitten/components.

⚠
We're not going to include more feature requests in 5.0. In this discussion, we accept proposals regarding the features described above.
Please open a new issue if you have a feature request or questions regarding the current API in order to help us keep this conversation clean.

More flexibility in component props
As a developer, I would like to have an ability to do:
const Header = () => (
  <TopNavigation title='Title' />
);

as well as
const Title = (evaStyle) => (
  <React.Fragment>
    <Image source={require('./logo.png')}
    <Text style={...evaStyle, ...myCustomStyle}>Title</Text>
  <React.Fragment/>
);

const Header = () => (
  <TopNavigation title='Title' />
);

More flexibility in component props: icon syntax
Idea
We can replace icon properties with something more generic, e.g accessoryLeft and accessoryRight so that these properties can accept any component.
What does it resolves
This will help us resolve #564 and #737.
Examlples

This should render a Button with Icon, like it works currently. Also, we can use accessoryLeft to render icon at the left (currently can be achieved with flexDirection: 'row-reverse')

import { Button, Icon } from '@ui-kitten/components';

const StarIcon = (evaStyle) => (
  <Icon {...evaStyle} name='star' />
);

const IconButton = () => (
  <Button accessoryRight={StarIcon} />
);

This should render a Button with any other component, e.g Spinner.

import { Button, Spinner } from '@ui-kitten/components';

const Loader = (evaStyle) => (
  <Spinner {...evaStyle ...customStyle} {...customProps} />
);

const LoadingButton = () => (
  <Button accessoryRight={evaStyle => <Loader {...evaStyle}/>} />
);

// Could be inlined
//
// const LoadingButton = () => (
//  <Button accessoryRight={Loader} />
//);

This should render an Input with left and right icons

import { Input, Icon } from '@ui-kitten/components';

const ClearIcon = (evaStyle) => (
  <Icon {...evaStyle ...customStyle} {...customProps} name='clear' />
);

const SearchIcon = (evaStyle) => (
  <Icon {...evaStyle ...customStyle} {...customProps} name='search' />
);

const SearchInput = () => (
  <Input
    accessoryLeft={evaStyle => <SearchIcon {...evaStyle} />}
    accessoryRight={evaStyle => <ClearIcon {...evaStyle}/>}
   />
);

// Could be inlined
//
// const SearchInput = () => (
//  <Input accessoryLeft={SearchIcon} accessoryRight={ClearIcon} />
//);

search option in select dropdown ?

@harsh-syook you can use Autocomplete

@artyorsh is it a multi select ? i want a multi select dropdown with search also for company project.

currently using react-native-multiselect lib but that is not ui friendly thats why .

@harsh-syook Currently, you can achieve this by using Autocomplete with custom items using renderItem property.

@artyorsh i'll try :) thanks for quick reply . will it work like react-select library thats for a web?

@artyorsh  with Autocomplete how ? it is only kind of single value select not multi select.

@harsh-syook I'm going to delete this conversation to keep this clean.
As I mentioned above, we're not going to include more feature requests in 5.0. However, in this discussion, we accept bug reports to be closed within 4.4.x patch releases. Please open a new issue if you have a feature request.

@artyorsh ok sure . thanks i'll create the issue then

Potentially affected components
Resuming the ideas above, the following components can be potentially affected. With the new syntax, the properties described for each component below should be able to accept Class components, Functional components, and meaningful primitives like strings or numbers (depending on property meaning).

Autocomplete: label, caption, captionIcon,  icon props
Button: icon prop
Radio, Checkbox and Toggle: text prop
Datepicker and RangeDatepicker: label, caption, captionIcon, icon props
Input: label, caption, captionIcon, icon props
Popover: content prop
Select: label, icon props
Tab: title and icon props
Tooltip: text and icon props
TopNavigation: title, description, leftControl and rightControls props

New syntax example
v4 Input
You can render only a Text inside label property.
<Input
  label='Movies'
  labelStyle={{ color: 'red' }}
/>

v5 Input
Will deprecate labelStyle property, but give you an ability to render anything.
<Input label='Movies' />

// OR

const Label = (props) => (
  <Text {...props} style={[props.style, { color: 'red' }]}>Movies</Text>
);

<Input label={Label} />

I can't wait for the V5. Also, can we add a prop to the Icon component to change his color?

@focux it's not necessary to do this. An Icon accepts fill to change it's color in case you use it with Eva Icons package (which renders svg and accepts svg props). You may also make it render Image and pass tintColor within style property, like it is described in the guide.

Combine styled and withStyles injected properties into one
We can combine properties injected by styled and withStyles function into one, called eva. This may help us control passing ...restProps to the root components. (#669)
withStyles Example
const MyComponent = ({ eva, ...props }) => (
  <View {...props} style={[eva.themedStyle.container, props.style]} />
);

export const MyStyledComponent = withStyles(MyComponent, theme ({
  container: { backgroundColor: theme['background-basic-color-1'] },
}));

styled Example
const MyComponent = ({ eva, ...props }) => {

  const onPressIn = () => {
    eva.dispatch([Interaction.ACTIVE]);
  };

  return (
    <TouchableOpacity {...props} onPressIn={onPressIn} />
  );
};

export const MyStyledComponent = styled(MyComponent);

Select syntax
const MySelect = () => (
  <Select selectedIndex={selectedIndex} onSelect={setSelectedIndex}>
    <SelectGroup title='Group 1'>
      <SelectItem title='Option 1.1'/>
      <SelectItem title='Option 1.2'/>
    </SelectGroup>
    <SelectGroup title='Group 2'>
      <SelectItem title='Option 2.1'/>
      <SelectItem title='Option 2.2'/>
    </SelectGroup>
  </Select>
);

Same would be available for Drawer and Menu components

In my opinion your Button component should conform to react-native's Button such that the text is passed through the title prop and not as a child.

Upcoming changes can be found in PR Changelog

Oh what about making input icons have a visual response when pressed?

@sudomann we can't handle this because there are multiple type of icons, e.g react-native-vector-icons, that come with it's own press handler. Hovewer, in v5, you will be able to put any component there, e.g ghost button.

Support import  individual components on demand.
When we create a new project by npx react-native init MyApp --template @ui-kitten/template-js .
By using react-native-startup-time, you can see that the app startup time is about 2000 ms. If you create an app through npx react native init, the startup time is about 500ms. (android)
The reason is that when we import ApplicationProvider, we actually import all the modules, hoping to optimize the way of importing modules in order to optimize the APP startup time.

@AdamChrist

The reason is that when we import ApplicationProvider, we actually import all the modules, hoping to optimize the way of importing modules in order to optimize the APP startup time.

This is not the reason of increased startup time. Check this guide

Thanks for all the great works and detailed changelog.
Is there a ETA for the 5.0.0 version ? Even a rough estimation. Is it more likely to come in 2-3, 2-3 months or 2-3 years? :)

ping ?

@rdewolff v5 stable will come during the next two weeks. I plan to close several known issues before the version update (you can track it in #1055). This version will not include new components unfortunately.

Thanks for the update! Looking forward!

Time Picker please :(

AutoComplete is great component. But I think Autocomplete can be extended for :

Support multiple value using tags / Chips
Support adhoc value, so user can input external value if not exist

Other components like Table, Accordion, etc like https://www.akveo.com/ngx-admin/pages/dashboard will be great if can be provided.

List and ListItem aren't typed properly like FlatList is, would be nice to have that fixed before V5 is pushed.


Update to SDK 27 not pushed to Maven

Hi
The latest release 3.9.0 does not appear to have the latest gradle update from earlier this week and it's causing a Gradle error "exact same version specification..."
Specifically com,android.support.exifinterface:26.1.0
Can you please update it ?
Thanks

You'll need to add your own exifinterface dependency for the correct version for your project. I assume this is the standard way of solving this problem, since not all projects will track the latest support lib versions.


2962: Fixes SMS error when missing dot on first answer

Raises an error if the first answer token doesn't look like the start of an answer

Just one comment. You can then merge. Nice work.


unable to CAP Operator Application Version Workload Service Account

Hello Team,
how do i set a different service account on CAP application versions -> workloads -> deploymentDefinition ? (https://sap.github.io/cap-operator/docs/reference/#sme.sap.com/v1alpha1.CommonDetails)
We want to manage a k8s application via CAP operator which needs to interact with k8s api inside the cluster.
Cheers,
Steffen

Hi Steffen,
Thanks for reporting the issue.. we so far did not see the need to interact with K8s API server from within a "CAP application workload" and the other common use cases (for service account) could be covered via the supported network policy configs, hence we did not support Service Accounts yet.
However, we will soon add support for specifying a ServiceAccounName on CAP Application workloads with #49
Thanks & Regards,
Pavan


Add device exclude ability

Implementation of device filter without device-include (keep current smartctl-scan logic)

Resolves #97

@k0ste any ideas on this?

@SuperQ

Thanks, maybe we could just copy-pasta the whole device filter implementation from the node_exporter? Then we can have both include and exclude filters.

In this case, you have to abandon the existing logic. These are major changes.

I don't think so. It would still scan, just with a positive and negative filter.

Proposed change: https://github.com/prometheus-community/smartctl_exporter/pull/99


LoginManager.logInWithPermissions never resolve or reject its promise

🐛 Bug Report

LoginManager.logInWithPermissions never resolve or reject its promise, but LoginButton works fine (tested on iOS only)
To Reproduce

I followed the tutorial, added code in AppDelegate.m, Info.plist. called Settings.initializeSDK() in a useEffect.
When I call the example code with LoginManager.logInWithPermissions (with .then or with async/await), the native modal "wants to use 'facebook.com'to sign in" appears. if I press cancel, the function resolve a cancel event. If i press "continue", a webview opens, I log in facebook, the modal closes, and nothing happens. The logInWithPermissions does not resolve, as if the webview is still opened.
Note : I added LoginButton next to my code, when the webview closes, the loginbutton changes to a Logout button, meaning that I did Log in successfully, only the callback is broken somewhere
Expected Behavior

logInWithPermissions should either resolve an object or throw an error. Note that LoginButton works perfectly fine
Code Example

import {AccessToken, LoginManager} from 'react-native-fbsdk-next';

const onFacebookButtonPress = async () => {
  try {
    // Attempt login with permissions
    const result = await LoginManager.logInWithPermissions(['public_profile']);
    // stuck here

    if (result.isCancelled) {
      throw 'User cancelled the login process';
    }

    // Once signed in, get the users AccessToken
    const data = await AccessToken.getCurrentAccessToken();

    if (!data) {
      throw 'Something went wrong obtaining access token';
    }

  } catch (error) {
    console.log(error);
  }
};

Environment

"react-native-fbsdk-next": "^4.4.1"

System:
    OS: macOS 11.6
    CPU: (8) x64 Intel(R) Core(TM) i7-8557U CPU @ 1.70GHz
    Memory: 264.71 MB / 16.00 GB
    Shell: 5.8 - /bin/zsh
  Binaries:
    Node: 14.17.5 - ~/.nvm/versions/node/v14.17.5/bin/node
    Yarn: 1.22.11 - /usr/local/bin/yarn
    npm: 6.14.14 - ~/.nvm/versions/node/v14.17.5/bin/npm
    Watchman: 2<IP_ADDRESS> - /usr/local/bin/watchman
  Managers:
    CocoaPods: 1.10.1 - /Users/arnaud/.rvm/gems/ruby-2.4.0/bin/pod
  SDKs:
    iOS SDK:
      Platforms: iOS 14.5, DriverKit 20.4, macOS 11.3, tvOS 14.5, watchOS 7.4
    Android SDK:
      API Levels: 26, 27, 28, 29, 30
      Build Tools: 27.0.3, 28.0.3, 29.0.2, 29.0.3
      System Images: android-29 | Google APIs Intel x86 Atom, android-30 | Google APIs Intel x86 Atom, android-30 | Google Play Intel x86 Atom
      Android NDK: Not Found
  IDEs:
    Android Studio: 4.1 AI-201.87<IP_ADDRESS>99119
    Xcode: 12.5.1/12E507 - /usr/bin/xcodebuild
  Languages:
    Java: 1.8.0_265 - /usr/bin/javac
  npmPackages:
    @react-native-community/cli: Not Found
    react: 17.0.1 => 17.0.1
    react-native: 0.64.0 => 0.64.0
    react-native-macos: Not Found
  npmGlobalPackages:
    *react-native*: Not Found

update :
When I use LoginButton, the onLoginFinished callback is called, but if I try to call AuthenticationToken.getAuthenticationTokenIOS() or AccessToken.getCurrentAccessToken(), the execution gets stuck at those methods too. I must have missed a step somewhere, probably in the native side ?
Here's my AppDelegate.m juste in case :
#import "AppDelegate.h"

#import <React/RCTBridge.h>
#import <React/RCTBundleURLProvider.h>
#import <React/RCTRootView.h>
#import <CodePush/CodePush.h> // @codepush
#import <Firebase.h> // @firebase
#import <StartupTrace.h> // @firebase-perf
#import <FBSDKCoreKit/FBSDKCoreKit.h> // @facebook

@implementation AppDelegate

- (BOOL)application:(UIApplication *)application didFinishLaunchingWithOptions:(NSDictionary *)launchOptions
{
  // #ifdef FB_SONARKIT_ENABLED
  //   InitializeFlipper(application);
  // #endif

  // @firebase
  if ([FIRApp defaultApp] == nil) {
    [FIRApp configure];
    [StartupPerformanceTrace start]; // @firebase-perf
  }

  // @facebook
  [[FBSDKApplicationDelegate sharedInstance] application:application
                          didFinishLaunchingWithOptions:launchOptions];

  RCTBridge *bridge = [[RCTBridge alloc] initWithDelegate:self launchOptions:launchOptions];
  RCTRootView *rootView = [[RCTRootView alloc] initWithBridge:bridge
                                                   moduleName:@"Cinemate"
                                            initialProperties:nil];

    if (@available(iOS 13.0, *)) {
      rootView.backgroundColor = [UIColor systemBackgroundColor];
  } else {
      rootView.backgroundColor = [UIColor whiteColor];
  }

  self.window = [[UIWindow alloc] initWithFrame:[UIScreen mainScreen].bounds];
  UIViewController *rootViewController = [UIViewController new];
  rootViewController.view = rootView;
  self.window.rootViewController = rootViewController;
  [self.window makeKeyAndVisible];
  return YES;
}

- (NSURL *)sourceURLForBridge:(RCTBridge *)bridge
{
#if DEBUG
  return [[RCTBundleURLProvider sharedSettings] jsBundleURLForBundleRoot:@"index" fallbackResource:nil];
#else
  return [CodePush bundleURL]; // @codepush
#endif
}

- (BOOL)application:(UIApplication *)application
            openURL:(NSURL *)url
            options:(nonnull NSDictionary<UIApplicationOpenURLOptionsKey, id> *)options
{
  [[FBSDKApplicationDelegate sharedInstance] application:application
                                                 openURL:url
                                                 options:options];
  return YES;
}

// - (BOOL)application:(UIApplication *)application
//             openURL:(NSURL *)url
//             options:(nonnull NSDictionary<UIApplicationOpenURLOptionsKey, id> *)options
// {
//   // @facebook
//    if ([[FBSDKApplicationDelegate sharedInstance] application:application openURL:url options:options]) {
//     return YES;
//   }

//   // if ([RCTLinkingManager application:application openURL:url options:options]) {
//   //   return YES;
//   // }

//   return NO;
// }

//- (void)applicationDidBecomeActive:(UIApplication *)application {
//  [FBSDKAppEvents activateApp];
//}

// - (BOOL)application:(UIApplication *)application didFinishLaunchingWithOptions:(NSDictionary *)launchOptions {
//   [[FBSDKApplicationDelegate sharedInstance] application:application
//                            didFinishLaunchingWithOptions:launchOptions];
//   return YES;
// }

- (BOOL)application:(UIApplication *)application
            openURL:(NSURL *)url
  sourceApplication:(NSString *)sourceApplication
         annotation:(id)annotation {
  return [[FBSDKApplicationDelegate sharedInstance] application:application
                                                         openURL:url
                                               sourceApplication:sourceApplication
                                                      annotation:annotation];
}

@end

Not sure what's going on but I know @MilanObradovic just had a different problem with loginWithPermissions where the result appeared to be that it was working on both platforms, perhaps he has some insight?

I think I found it, I had the same problem adding apple signin. So I wondered if an other dependency might be breaking the native code of facebook/apple login. So I removed reanimated 2 lib, and apple signin worked ! Haven't tried yet with facebook signin, but seems to be exactly the same problem. I will try to solve the problem on the reanimated side, and if I can't, I will try to put an issue on the reanimated repository :)
I keep the issue opened for now, will update it later if I found a solution next week.

I use reanimated in combination with apple sign in and facebook. Just patched them for the upcoming rn66 release even https://github.com/software-mansion/react-native-reanimated/pull/2478

Looks like the problem is not only for IOS - I also have it with Android (on version RN: 65.1 but with Reanimated 2.2.2). Response from LoginManager.logInWithPermissions is always cancelled with {isCancelled: true}.

same here with android

react-native: 0.66.2
react-native-fbsdk-next: 4.6.0

react-native-fbsdk-next: 4.6.0

Please try to reproduce with current versions, a lot of time was just invested getting the native SDKs up to date. May not make a difference, but reproducing on old versions is not an efficient use of time as it can lead to troubleshooting already fixed items

react-native-fbsdk-next: 4.6.0

Please try to reproduce with current versions, a lot of time was just invested getting the native SDKs up to date. May not make a difference, but reproducing on old versions is not an efficient use of time as it can lead to troubleshooting already fixed items

I've updated to the latest version

react-native 0.66.3
react-native-fbsdk-next: 6.0.0

but the issue is still here: reject is not resolved
Possible Unhandled Promise Rejection

So if you see Possible Unhandled Promise Rejection and you don't have a .catch, you have a code error. What happens when you add a .catch ?

LoginManager.logInWithPermissions(['public_profile'])
.then(
(result: LoginResult) => {
// ok
}
)
.catch(error => {
// same here: never called
});

Gonna need a https://stackoverflow.com/help/minimal-reproducible-example on this one I think, because I simply do not reproduce this.
Note that there is something fun going on that "rhymes" with this (that is: may be related) - network hangs etc https://github.com/facebook/react-native/issues/32001#issuecomment-971305939

LoginManager.logInWithPermissions(['public_profile'])
      .then(
        (result: LoginResult) => {
          // !!!! Possible Unhandled Promise Rejection was here !!!!
        }
      );

@mikehardy
I'm sorry. Thanks for your time
Mario

Just adding this comment in case anyone else comes across this from a Google search like I did. You'll get this exact problem on iOS if you don't set up your application delegate correctly.
It'll work just fine if the user doesn't have the FB app installed, but won't if they do. You need to add something like:
(BOOL)application:(UIApplication *)application
          openURL:(NSURL *)url
          options:(NSDictionary<UIApplicationOpenURLOptionsKey,id> *)options
{
  return [[FBSDKApplicationDelegate sharedInstance] application:application openURL:url options:options];
}

@mikehardy I'm having the same issue. the promise never resolves or rejects. I added debug point in Xcode and it seems the result from FB is coming but the resolve part is actually not resolving to JS for some reason. I created whole new app to reproduce this issue but it seems to be working fine there. Now I don't know which of my package is giving this issue coz everything just works fine apart from this promise issue. I know you won't be able to help without reproducible demo but could you point me the steps how can I debug it and fix it or how can I find the culprit? adding the package.json here.
{
  "name": "xxx",
  "version": "0.0.1",
  "private": true,
  "scripts": {
    ...
  },
  "config": {
    "react-native-storybook-loader": {
      "searchDir": [
        "./src",
        "./packages"
      ],
      "pattern": "**/*.stories.tsx",
      "outputFile": "./storybook/storyLoader.js"
    }
  },
  "dependencies": {
    "@gorhom/bottom-sheet": "^4",
    "@react-native-async-storage/async-storage": "^1.17.3",
    "@react-native-community/hooks": "^2.8.1",
    "@react-native-community/netinfo": "^8.2.0",
    "@react-navigation/native": "^6.0.10",
    "@react-navigation/native-stack": "^6.6.1",
    "@reduxjs/toolkit": "^1.8.1",
    "@sentry/react-native": "^3.4.1",
    "axios": "^0.26.1",
    "deepmerge": "^4.2.2",
    "i18next": "^21.6.16",
    "lodash": "^4.17.21",
    "react": "17.0.2",
    "react-i18next": "^11.16.8",
    "react-native": "0.68.1",
    "react-native-code-push": "^7.0.4",
    "react-native-config": "^1.4.5",
    "react-native-device-info": "^8.7.0",
    "react-native-fast-image": "^8.5.11",
    "react-native-fbsdk-next": "^8.0.2",
    "react-native-gesture-handler": "^2.4.1",
    "react-native-image-crop-picker": "^0.37.3",
    "react-native-linear-gradient": "^2.5.6",
    "react-native-paper": "^4.12.0",
    "react-native-parsed-text": "^0.0.22",
    "react-native-permissions": "^3.3.1",
    "react-native-reanimated": "^2.8.0",
    "react-native-safe-area-context": "^4.2.4",
    "react-native-screens": "^3.13.1",
    "react-native-svg": "^12.3.0",
    "react-native-vector-icons": "^9.1.0",
    "react-redux": "^7.2.8",
    "redux": "^4.1.2",
    "redux-persist": "^6.0.0",
    "redux-thunk": "^2.4.1"
  },
  "devDependencies": {
    "@babel/core": "^7.12.9",
    "@babel/runtime": "^7.12.5",
    "@react-native-community/eslint-config": "^2.0.0",
    "@storybook/addon-actions": "^5.3",
    "@storybook/addon-knobs": "^5.3",
    "@storybook/addon-links": "^5.3",
    "@storybook/addon-ondevice-actions": "^5.3.23",
    "@storybook/addon-ondevice-knobs": "^5.3.25",
    "@storybook/react-native": "^5.3.25",
    "@storybook/react-native-server": "^5.3.23",
    "@types/jest": "^26.0.23",
    "@types/react-native": "^0.67.4",
    "@types/react-native-vector-icons": "^6.4.10",
    "@types/react-test-renderer": "^17.0.1",
    "babel-jest": "^26.6.3",
    "babel-loader": "^8.2.3",
    "eslint": "^7.32.0",
    "jest": "^26.6.3",
    "metro-react-native-babel-preset": "^0.67.0",
    "prettier": "^2.6.2",
    "react-dom": "17.0.2",
    "react-native-storybook-loader": "^2.0.4",
    "react-native-svg-transformer": "^1.0.0",
    "react-test-renderer": "17.0.2",
    "typescript": "^3.8.3"
  },
  "resolutions": {
    "@types/react": "^17"
  },
  "jest": {
    "preset": "react-native",
    "moduleFileExtensions": [
      "ts",
      "tsx",
      "js",
      "jsx",
      "json",
      "node"
    ]
  }
}

Thank you for your help already.

@mikehardy I'll give it a try. Thank you.

For anyone facing this issue, I was stuck on this for 3 days and the only file that you need to check in case of infinite loop login is AppDelegate.m. I had issues because I was using multiple social auths and also deep linking.
Here's what fixed in my case. If you are using google login or any other social auths add an if condition for them too.
- (BOOL)application:(UIApplication *)application
            openURL:(NSURL *)url
            options:(NSDictionary<UIApplicationOpenURLOptionsKey,id> *)options
{
  if ([[FBSDKApplicationDelegate sharedInstance] application:application openURL:url options:options]) {
    return YES;
  }

  if ([RNGoogleSignin application:application openURL:url options:options]) {
    return YES;
  }

  if ([RCTLinkingManager application:application openURL:url options:options]) {
    return YES;
  }

  return NO;
}

I have the same issue but only on Android; works fine on iOS. I created an issue about it here https://github.com/thebergamo/react-native-fbsdk-next/issues/391

Same problem with android, is there some solution?

Here is my dependencies:
"dependencies": {
"@babel/preset-typescript": "^7.18.6",
"@react-native-community/art": "^1.2.0",
"@react-native-community/viewpager": "5.0.11",
"common": "1.0.0",
"deprecated-react-native-prop-types": "^4.0.0",
"expo": "^48.0.0",
"expo-apple-authentication": "~6.0.1",
"expo-av": "~13.2.1",
"expo-device": "~5.2.1",
"expo-firebase-analytics": "~8.0.0",
"expo-font": "~11.1.1",
"expo-in-app-purchases": "~14.1.1",
"expo-keep-awake": "~12.0.1",
"expo-linear-gradient": "~12.1.2",
"expo-linking": "~4.0.1",
"expo-secure-store": "~12.1.1",
"expo-store-review": "~6.2.1",
"expo-updates": "~0.16.4",
"mobx": "^5.8.0",
"mobx-react": "5.4.3",
"node-libs-react-native": "^1.0.3",
"react": "18.2.0",
"react-dom": "18.2.0",
"react-i18next": "9.0.8",
"react-native": "0.71.3",
"react-native-animate-number": "^0.1.2",
"react-native-confetti": "0.1.0",
"react-native-fbsdk-next": "^11.1.0",
"react-native-gesture-handler": "~2.9.0",
"react-native-google-mobile-ads": "^8.2.2",
"react-native-particles": "^0.0.8",
"react-native-progress": "^5.0.0",
"react-native-progress-circle": "^2.1.0",
"react-native-reanimated": "~2.14.4",
"react-native-redash": "^14.1.1",
"react-native-responsive-screen": "^1.4.1",
"react-native-root-toast": "^3.3.0",
"react-native-star-rating": "^1.1.0",
"react-native-svg": "13.4.0",
"react-native-svg-charts": "5.3.0",
"react-native-swipe-gestures": "^1.0.5",
"react-test-renderer": "18.0.0"
},
"devDependencies": {
"@babel/core": "^7.20.0",
"@babel/plugin-proposal-class-properties": "^7.18.6",
"@babel/plugin-proposal-decorators": "^7.20.13",
"@types/react": "~18.0.27",
"@types/react-native": "~0.70.6",
"babel-jest": "~25.2.6",
"babel-plugin-module-resolver": "^5.0.0",
"babel-preset-expo": "^9.3.0",
"expo-yarn-workspaces": "^2.0.0",
"jest": "^29.2.1",
"react-test-renderer": "18.0.0"
},

Same issue here!
I have tried this solution but didn't work.
I know that the "onActivityResult" is deprecated, but even with the new way here I'm facing the same issue.
I'm using<EMAIL_ADDRESS>and<EMAIL_ADDRESS>Any help is welcome :)

Facing the same issue. What should I do?

Hello,
A tutorial that currently works (as of 27/04/2027) can be found here : However, for those reading this in the future, the idea is to follow the most recent tutorial available. Over time, versions change, and so does code and tutorials.


how to access dashboards without login?

This is kind of question is better asked on stack overflow / gitter / mailing list. Then it's documented:
https://superset.incubator.apache.org/security.html?highlight=public#public


ROADMAP to ERAD2024

This issue just shows the roadmap to ERAD2024. We'll provide a list of dates to keep track of course development:

Initial repo setup

[x] add collaborators (done, invitations sent out)
[x] update theme/readme #2
[x] enable nightly builds https://github.com/openradar/erad2024/commit/edb12d6b5f604fe911dc533321717f5179b28a51 #4
[ ] tbc

Initial working environment ready

[ ] tbc

Docker image ready

[ ] tbc

All packages available in environment/docker

[ ] tbc

Presentations ready

[ ] tbc

Resources ready (data etc.)

[ ] tbc

Notebooks ready

[ ] tbc

Complete workflow ready

[ ] tbc

@kmuehlbauer - can we revisit this issue, and use it to highlight tasks we want to get done during the sprint?


Use the dictionary as the name of the identifiers

I added option to obfuscate code using dictionary and it looks like (based on three words: qwertyuiop, asdfghjkl, zxcvbnm and prefix obfuscatorio_):

source, before this obfuscation:
function helloWorld() {
	console.log("Hello world!");
}
setInterval(helloWorld, 500);

<EMAIL_ADDRESS>

Hi. Are you interested in an update of this PR? If not, I'll update it by myself

You can update yourself if you want

Thank you! I updated and refactored your changes in my PR
https://github.com/javascript-obfuscator/javascript-obfuscator/pull/462
Closed.


Will not run on VMWare/Ubuntu 18.04 LTS guest

Describe the bug
Shadow client will not run on a VMWare Fusion installation with an Ubuntu 18.04 LTS guest.  I have not tried this on Workstation but suspect the same problem may occur in that environment as well.
System

OS: Ubuntu
OS Version: 18.04
Environment: Gnome
Application: AppImage
Application Version: 3.3.17

Configuration

The user is in input group ? yes
The environment uses Xorg ? yes
VA API detects H264 ? And H265 ? can't tell (can't get to this step)

To Reproduce
Steps to reproduce the behavior:

Run the Shadow Launcher
The initial launch screen comes up as expected with "starting Shadow"
Displays "Shadow is Ready" with the orange "Start Now" button
Click the button
Streaming does not start, receive "Error Code: R-0x4"
However, I have verified that the remote Shadow VM started as expected as I'm able to connect to it from Parsec or Steam Remote Play.

Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
I don't know much about Linux graphics drivers, but this may not be a solvable issue.  I have ensured that I have all the required dependencies installed.  However, I get this when I run vainfo:
libva info: VA-API version 1.1.0
libva info: va_getDriverName() returns 0
libva info: Trying to open /usr/lib/x86_64-linux-gnu/dri/vmwgfx_drv_video.so
libva info: va_openDriver() returns -1
vaInitialize failed with error code -1 (unknown libva error),exit
I'm assuming this means that the vmwgfx video driver for VMWare doesn't support the API signatures expected by VA-API.  A brief Google search didn't turn of any explicit confirmation of whether or not the driver provides this support. I tried to force the use of the i965 driver with export LIBVA_DRIVER_NAME=i965 in my .bashrc, but the vainfo just gave me this:
libva info: VA-API version 1.1.0
libva info: va_getDriverName() returns 0
libva info: User requested driver 'i965'
libva info: Trying to open /usr/lib/x86_64-linux-gnu/dri/i965_drv_video.so
libva info: Found init function __vaDriverInit_1_1
DRM_IOCTL_I915_GEM_APERTURE failed: Invalid argument
Assuming 131072kB available aperture size.
May lead to reduced performance or incorrect rendering.
get chip id failed: -1 [22]
param: 4, val: 0
vainfo: intel_memman.c:38: intel_memman_init: Assertion `intel->bufmgr' failed.
Aborted (core dumped)
If there's some clever solution here I can't think of then great; otherwise, this should probably go on the "known issues" page.

shadow requires a direct access to an hardware decoder, means it could only work on a VM with a GPU passthrough.


Feature/case flag release 3.1

JIRA link (if applicable)
NA
Change description
Case flag changes
Does this PR introduce a breaking change? (check one with "x")
[ ] Yes
[x] No

Please resolve the confilcts as well. once done you can merge it to 3.1


[Removal]: Miner locations are Real please remove them from denylist

Hotspot Name
Skinny Latte Loris
Hotspot b58 Address
11oZbC3KcPzmX43EYSe7kcrQAzwyYes7hkhdMafuSK4L9aZnRxc
Discord Handle
happy林#9035
Hotspot Manufacturer
Bobcat
Removal Reason
I am not sure why I am on the Denylist but i give my best to proof the reality
Modifications
Yes
Extra forwarders
No
Extra antennas
Yes
Additional Information
I'm from China. My name is Lin Haiping. First of all, I'm very grateful to helium for enabling people all over the world to get to know each other, talk and discuss together, and make a little contribution to the decentralization. At the beginning, I bought three hot spots. When 3 o'clock is lit on the map of helium, I'm really excited. Later, with the investment of funds and the recognition of the development of helium, more and more young partners participated, Helium is developing very fast, and now it is the largest network in the world that truly belongs to the people. Next, let me talk about myself. Of course, unfortunately, my miners have been blacklisted. I will randomly select one miner to prove that its deployment is true and effective. Here are some related photos. I am Chinese and my English is not very good. Please forgive me. I have no malice.

I used to act as an agent for Rak antennas, so many machines are connected to Rak antennas, which may have some disadvantages of high signal.

I used to act as an agent for Rak antennas, so many machines are connected to Rak antennas, which may have some disadvantages of high signal.
My friends and I have four wallets, respectively: 1. 14rmkvrwretyzhmxycqb79truxc9pfqiusecrkufhokvdxg9pw; 2. 148BpWKrFyjpibQQh74x1VCGKJmXumzso4xofnHSFYT94V5QZAg； 3. 149x7MNhGz7YAz88YohsrGr7f5iqJAdWQqJ9GAtjsdjJntN4M9j； 4. 13ZbxMcRVYfVGHQjGQebmaBXWrCD4KRHWkLwb76bWaA9NoJFftw。
From the beginning to the end, I thank helium very much. I think I was reported because I didn't do well enough. I remind myself to do better. Thank brother KXI for reminding me. Thank you again!


Main/home page is incomplete

The main landing page should be filled in with basic cluster overview information.
Things like summary data regarding:

cpu
mem
disk
nodes
workloads (total pods, services, ingresses, etc.)

fixed in recent commit.


chore: support symfony 5

DataCollector::collect method signature change since SF 4.4

// before Symfony 4.4
public function collect(Request $request, Response $response, \Exception $exception = null);

// since Symfony 4.4
public function collect(Request $request, Response $response, \Throwable $exception = null);

@see https://github.com/symfony/symfony/commit/ffcfdb42a708f91fa9ba201ef43b9af24af27047

Renamed events :
GetResponseForExceptionEvent replaced by ExceptionEvent
PostResponseEvent replaced by TerminateEvent

Swap arguments of dispatch()
@see symfony/symfony@75369da

Use the spaceless filter instead of spaceless tag (since Twig 1.38)

Hi @Oliboy50,
IMO it's a little bit difficult to keep support of Symfony versions before 4.4 but let's try :

The signature of the DataCollector::collect method has been updated since 4.4 and unless I am mistaken PHP only supports covariance since 7.4 version (which is supports since 4.4 version of Symfony)
The signature of the EventDispatcherInterface::dispatch() method has been updated. Maybe we can use the LegacyEventDispatcherProxy decorator as suggests here => I can do it if you want :+1:
For the renamed events GetResponseForExceptionEvent and PostResponseEvent, no idea to keep compatibility.

I think it's better to allow recent applications to use this bundle but I am listening to you if you have any suggestions.

@Oliboy50 Ready for a new release ?

Are we ready for a new release ?

thank you 👌
=> https://packagist.org/packages/m6web/statsd-bundle#v4.0.0


unable to run cmds

This is autogenerated. Please review and update as needed.
Describe the bug
Command Name
az account list
Errors:
The command failed with an unexpected error. Here is the traceback:
'3'
Traceback (most recent call last):
  File "D:\a\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\knack/cli.py", line 236, in invoke
  File "D:\a\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\knack/output.py", line 166, in get_formatter
KeyError: '3'

To Reproduce:
Steps to reproduce the behavior. Note that argument values have been redacted, as they may contain sensitive information.

Put any pre-requisite steps here...
az account list

Expected Behavior
Environment Summary
Windows-10-10.0.19041-SP0
Python 3.8.9
Installer: MSI

azure-cli 2.32.0

Extensions:
account 0.2.1
alias 0.5.2
resource-graph 2.1.0

Dependencies:
msal 1.16.0
azure-mgmt-resource 20.0.0

Additional Context

did tried upgrade not helped
uninstalled the whole CLI and re-installed using MSI
getting similar error as reported

@jiasli for awareness


Completely failed to instantiate CLSID_VirtualBox: ERROR_SERVICE_REQUEST_TIMEOUT 0x8007041D.

Describe the bug
A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

OS: [e.g. iOS]
Browser [e.g. chrome, safari]
Version [e.g. 22]

Smartphone (please complete the following information):

Device: [e.g. iPhone6]
OS: [e.g. iOS8.1]
Browser [e.g. stock browser, safari]
Version [e.g. 22]

Additional context
Add any other context about the problem here.

It seems that the problem is not related to our script.
 Please try to find its solution by your own first.

thank you
When I finished compiling the software, it failed to start. I did a Google search and didn't find any questions, so I didn't know what was wrong. I think starting the GUI is a failure. Can the software be packaged into an installation package after compilation?
------------------ 原始邮件 ------------------
发件人:                                                                                "VirtualBoBs/build-virtualbox-in-windows"                                                                                @.>;
发送时间: 2022年1月27日(星期四) 中午1:17
@.>;
<EMAIL_ADDRESS>主题: Re: [VirtualBoBs/build-virtualbox-in-windows] Completely failed to instantiate CLSID_VirtualBox: ERROR_SERVICE_REQUEST_TIMEOUT 0x8007041D. (Issue #5)
It seems that the problem is not related to our script.
 Please try to find its solution by your own first.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you authored the thread.Message ID: @.***>


saltpack: better error message on failed decryption

pacakge up message info an an rpc-friendly way
upgrade Device objects to contain CTime and Mtime

compute merge properly in sigchain replay
export/import properly

@patrickxb can you take a look? Thanks!

LGTM


[#3542] Fix empty folders in zip file.

Scope
There was a bug when creating zip archives with empty folders.
the empty folders were created with absolute path.
Changes
quick and dirty fix
How to try and test the changes
reviewers: @alibotean
check that changes are ok

need-review

changes-approved


Run commands on login user if run_command_as is not set

Coverage decreased (-0.14%) to 94.88% when pulling b3b90241c115ba6cd417097c430353dd7f6a61a4 on run-commands-on-loginuser-by-default into 163a48039bc28289795966651b07abc12cc25607 on master.

Coverage decreased (-0.14%) to 94.88% when pulling b3b90241c115ba6cd417097c430353dd7f6a61a4 on run-commands-on-loginuser-by-default into 163a48039bc28289795966651b07abc12cc25607 on master.


Rpc wrapper autogeneration

Problem
#2705.
Solution
Reuse existing infrastructure as much as possible and create something emitting code that can be compiled. To be extended.

And we need to adapt tests for Windows and its line endings (\r\n\t vs \n\t).


[bug]: Error in Web UI: Model Conversion Failed: 3dCartoonVision_v10 (2)

Is there an existing issue for this problem?

[X] I have searched the existing issues

Operating system
Linux
GPU vendor
Nvidia (CUDA)
GPU model
RTX a4000
GPU VRAM
16gb
Version number
4.2.5
Browser
Safari  17.5
Python dependencies
accelerate 0.30.1
compel 2.0.2
cuda 12.1
diffusers 0.27.2
numpy 1.26.4
opencv <IP_ADDRESS>
onnx 1.15.0
pillow 10.4.0
python 3.11.9
torch 2.2.2+cu121
torchvision 0.17.2
transformers 4.41.1
xformers 0.0.25.post1

What happened
Click "convert" button in models list to convert it to diffusers format.
Error in Web UI: Model Conversion Failed: 3dCartoonVision_v10 (2)
[2024-07-16 10:09:34,347]::[uvicorn.access]::INFO --> <IP_ADDRESS>:64653 - "PUT /api/v2/models/convert/ce6cb1ae-1754-49bd-8dd7-65bba24bb6f5 HTTP/1.1" 500
[2024-07-16 10:09:34,347]::[uvicorn.error]::ERROR --> Exception in ASGI application

Traceback (most recent call last):
  File "/opt/invokeai/.venv/lib/python3.11/site-packages/uvicorn/protocols/http/httptools_impl.py", line 412, in run_asgi
    result = await app(  # type: ignore[func-returns-value]
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/invokeai/.venv/lib/python3.11/site-packages/uvicorn/middleware/proxy_headers.py", line 69, in __call__
    return await self.app(scope, receive, send)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/invokeai/.venv/lib/python3.11/site-packages/fastapi/applications.py", line 1054, in __call__
    await super().__call__(scope, receive, send)
  File "/opt/invokeai/.venv/lib/python3.11/site-packages/starlette/applications.py", line 123, in __call__
    await self.middleware_stack(scope, receive, send)
  File "/opt/invokeai/.venv/lib/python3.11/site-packages/starlette/middleware/errors.py", line 186, in __call__
    raise exc
  File "/opt/invokeai/.venv/lib/python3.11/site-packages/starlette/middleware/errors.py", line 164, in __call__
    await self.app(scope, receive, _send)
  File "/opt/invokeai/.venv/lib/python3.11/site-packages/starlette/middleware/gzip.py", line 24, in __call__
    await responder(scope, receive, send)
  File "/opt/invokeai/.venv/lib/python3.11/site-packages/starlette/middleware/gzip.py", line 44, in __call__
    await self.app(scope, receive, self.send_with_gzip)
  File "/opt/invokeai/.venv/lib/python3.11/site-packages/starlette/middleware/cors.py", line 93, in __call__
    await self.simple_response(scope, receive, send, request_headers=headers)
  File "/opt/invokeai/.venv/lib/python3.11/site-packages/starlette/middleware/cors.py", line 148, in simple_response
    await self.app(scope, receive, send)
  File "/opt/invokeai/.venv/lib/python3.11/site-packages/fastapi_events/middleware.py", line 43, in __call__
    await self.app(scope, receive, send)
  File "/opt/invokeai/.venv/lib/python3.11/site-packages/starlette/middleware/exceptions.py", line 65, in __call__
    await wrap_app_handling_exceptions(self.app, conn)(scope, receive, send)
  File "/opt/invokeai/.venv/lib/python3.11/site-packages/starlette/_exception_handler.py", line 64, in wrapped_app
    raise exc
  File "/opt/invokeai/.venv/lib/python3.11/site-packages/starlette/_exception_handler.py", line 53, in wrapped_app
    await app(scope, receive, sender)
  File "/opt/invokeai/.venv/lib/python3.11/site-packages/starlette/routing.py", line 756, in __call__
    await self.middleware_stack(scope, receive, send)
  File "/opt/invokeai/.venv/lib/python3.11/site-packages/starlette/routing.py", line 776, in app
    await route.handle(scope, receive, send)
  File "/opt/invokeai/.venv/lib/python3.11/site-packages/starlette/routing.py", line 297, in handle
    await self.app(scope, receive, send)
  File "/opt/invokeai/.venv/lib/python3.11/site-packages/starlette/routing.py", line 77, in app
    await wrap_app_handling_exceptions(app, request)(scope, receive, send)
  File "/opt/invokeai/.venv/lib/python3.11/site-packages/starlette/_exception_handler.py", line 64, in wrapped_app
    raise exc
  File "/opt/invokeai/.venv/lib/python3.11/site-packages/starlette/_exception_handler.py", line 53, in wrapped_app
    await app(scope, receive, sender)
  File "/opt/invokeai/.venv/lib/python3.11/site-packages/starlette/routing.py", line 72, in app
    response = await func(request)
               ^^^^^^^^^^^^^^^^^^^
  File "/opt/invokeai/.venv/lib/python3.11/site-packages/fastapi/routing.py", line 278, in app
    raw_response = await run_endpoint_function(
                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/invokeai/.venv/lib/python3.11/site-packages/fastapi/routing.py", line 191, in run_endpoint_function
    return await dependant.call(**values)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/invokeai/.venv/lib/python3.11/site-packages/invokeai/app/api/routers/model_manager.py", line 760, in convert_model
    assert cache_path.exists()
           ^^^^^^^^^^^^^^^^^^^
AssertionError

What you expected to happen
Model conversion to diffusers
How to reproduce the problem
No response
Additional context
No response
Discord username
No response

@lstein We may have some regressions related to on-demand diffusers conversions. I imagine we just need to add a temp dir.
That said, I wonder if there is any particular reason to support this moving forward. What's the functional use-case, now that we support single-file loading? Maybe we should remove the functionality.


spec: namespace image-spec labels with "org.opencontainers.image"

When labels from images land elsewhere through propagation, it is hard to tell their source. Let's add .image to annotation prefix to make it clear when a label is part of an image.
Please see https://github.com/opencontainers/image-spec/pull/492#discussion_r105034418 for the original issue.
cc @cyphar @vbatts

:+1:

i like the provenance, though does this include the reference to that image's manifest digest as well?

@vbatts hmm, you mean so one can reverse-trace from a runtime-spec config.json to an image?

@jonboulle maybe that too, but not what i was originally thinking. More like "i have ubuntu LTS image (sha256:deadbeefface..), and add my software on top" as only the ubuntu LTS layers stay referenced, but not the original manifest. This would allow a pointer to those objects.

@vbatts This was not intended to go that far. I placed a comment in #600 clarifying the possible link.
I'll create a PR for this one today.

oh oh. this is just an addition onto the prefix, not an .image name. sorry


How to disEnable drag and drop?

RT,and how can I redraw some item when item clicked?
Thank you.

I get it of diable drag and drop by extends AdaptiveTableLayout and override method onLongPress()，and setItemClickListener by adapter.setOnItemClickLstener() .


Decide on a version-numbering scheme

e.g. semantic versioning (@caiw's current preference), or calendar versioning

Agree with semantic versioning. Closing.

@neukym A related question: when should we update the version number? Every merge to main? Or should we have a dev branch we usually merge to, and then do periodic merges of that to main with version increments?

For example we just merged the ippm branch with some new features - arguably warrants a v1.0.1 :)

I was just thinking every 6 months or so I would do it manually - so the package will routinely lag main until we have added in enough features that we think it should warrant a new version number. The new features might warrant it, but TBH, I was just planning on doing it every 6 months.
No one uses it as a package at the moment AFAIK so I don't want to be putting strict versioning policies in place. But do you disagree? For instance, do you use the pip package natively?

I was just thinking every 6 months or so I would do it manually

I don't think we had discussed the mechanism for this actually, now I think about it. So I am versioning main using tagging: Tagging applies a version number to specific git commits on main. (https://github.com/kymata-atlas/kymata-core/releases)
So this can be done in an arbitrary manner, and doesn't have to be linked to a dev branch, or be linked to every commit to main.


Possibility of adding pedestrians

Hello,
I there a possibility to add pedestrians in this simulator?
Or is there a possibility to provide support for pedestrians in the near future?
Thank you.

The AutomotiveSimulator.jl package might include an inspiration for a pedestrian model.
https://github.com/sisl/AutomotiveSimulator.jl/blob/master/src/behaviors/sidewalk_pedestrian_model.jl

Hi @eleurent ,
I'm considered to work on this enhancement, the  behavior model might be social force model.
I'm not sure how to change IDM to avoid pedestrians, but I will look in the literature.
So basically, the pedestrians (or cyclists) should go basically as another attribute of Road object, just like vehicles and controlled_vehicles.
Bests,


What is the difference between Display rule and Enable rule in case of "Command Bar"?

The documentation says the following
"With the command bar, commands that are disabled are hidden"
This is exactly the same thing a display rule does, it hides a button; now, what is the difference between the two as from the text it looks like they are doing exactly the same thing.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: e1a81724-b194-cf25-1542-11b5f817df1f
Version Independent ID: 3b4a3f08-b715-d5fd-5e41-78bb55942b0c
Content: Define ribbon enable rules (Developer Guide for Dynamics 365 Customer Engagement)
Content Source: ce/customerengagement/on-premises/developer/customize-dev/define-ribbon-enable-rules.md
Service: crm-online
GitHub Login: @JesseParsons
Microsoft Alias: jeparson

For command bars, the two types of rules behave the same way to end users.  Both enable rules and display rules hide the button.  Although the behavior is the same, note that enable and display rules offer different sets of rules - for example, custom javascript rules are enable rules.
Also, as the documentation notes, in legacy ribbon UI, there is a visual difference, as enabled rules disable rather than hide buttons, although the ribbon UI is shown only in rare cases in legacy Outlook and web client.

So in the future is there a plan to combine the functionality? As I understand, going forward it is only going to be a Command Bar.


Provide endpoint_url via env var or profile

Motivation and Context
Closes https://github.com/awslabs/aws-sdk-rust/issues/932
Ref. https://docs.aws.amazon.com/sdkref/latest/guide/feature-ss-endpoints.html
Note
This PR adds support for

AWS_ENDPOINT_URL
AWS_IGNORE_CONFIGURED_ENDPOINT_URLS

which is useful for testing implementation on AWS emulators like LocalStack.
This PR does not add support for

AWS_ENDPOINT_URL_<SERVICE>

since it will be a huge change.
That will be implemented in subsequent PRs.

Hi @exoego, thank you for taking time to make code changes and submitting your PR (arigatou gozaimasu)! The requested functionality was recently implemented (PR), and we are planning to get the release out this week.
Also, for your future reference, if you wish to contribute, kindly submit your PR to smithy-rs instead of this repository (as described in CONTRIBUTING).

The feature has just been released (release notes).


Floating Control Bar Bouncing + Unaligned Icons

🔍 Is there already an issue for your problem?

[X] I have checked older issues, open and closed

ℹ Environment / Computer Info
- Spotify version: Spotify for Windows <IP_ADDRESS>2.g94554d24
- Spicetify version: Spicetify v2.10.2
- Fluent installation method: (e.g., GitHub Readme, Spicetify Marketplace): Github (tried both manual and automatci

📝 Description
Icons are not aligned and the floating control bar keeps bouncing up and down. I have also used the patch.
I have attached a screenshot and gif. (Sorry if the gif is low quality)
Edit: It seems like a new UI 'footer' is appear causing the control bar to be pushed up while it is active.
📸 Screenshots

did you really check the other issues? #15, #22, #54 and #66 are good proof that you did not


Parallel processing at Colbert Reranker

It looks like the real problem is not batch in here. The parallel code itself looks wrong.
Look at #326.
You can see the original code, and the new code that you pushed.
The original code is like below.
def get_colbert_score(query: str, content_list: List[str],
                      model, tokenizer) -> List[float]:
    query_encoding = tokenizer(query, return_tensors="pt")
    query_embedding = model(**query_encoding).last_hidden_state
    rerank_score_list = []

    for document_text in content_list:
        document_encoding = tokenizer(
            document_text, return_tensors="pt", truncation=True, max_length=512
        )
        document_embedding = model(**document_encoding).last_hidden_state

        sim_matrix = torch.nn.functional.cosine_similarity(
            query_embedding.unsqueeze(2), document_embedding.unsqueeze(1), dim=-1
        )

        # Take the maximum similarity for each query token (across all document tokens)
        # sim_matrix shape: [batch_size, query_length, doc_length]
        max_sim_scores, _ = torch.max(sim_matrix, dim=2)
        rerank_score_list.append(torch.mean(max_sim_scores, dim=1))

    return list(map(float, rerank_score_list))

The colbert model acts like 'embedding_model' in here. The last_hidden_state is embedding vector.
It gets cosine similarity between each query_embedding and each content_embedding. And rerank contents by that score.
Return to your code. It is much easier you look at #326
The first thing you did wrong is tokenize query and contents at once.
# Tokenize both queries and contents together
        feature = tokenizer(flattened_batch_queries, flattened_batch_contents, padding=True, truncation=True,
                            return_tensors="pt").to(device)

If you decode the feature you can get the result like below.
'[CLS] what is the capital of france? [SEP] nomadamas is great team [SEP]'

It means, it encodes the query and content in the one sentence. And you put this feature into model 'at once'.
I think you try to split the result of embedding at the next code, but it does not work that way at all.
Model creates embedding of the tokenized sentence. It did not create embedding each sentence separately, it embeds a whole input string. So splitting it after embedding seems useless.
In conclusion, the code itself after #326 is wrong and might get the bad results and occurs several errors.


Revendor Microsoft/go-winio v0.3.8

Signed-off-by: John Howard<EMAIL_ADDRESS>Fixes https://github.com/docker/docker/issues/29849
There was a +1 length check error in go-winio causing an invalid filename on alternate data-streams as described in #29849. This is fixed in Microsoft/go-winio v0.3.8
@swernli

LGTM

@jhowardmsft should this go into 1.13.1, or is it only fixing a corner case?

@thaJeztah Probably a good candidate for 1.13.1, but I'm a little on the fence as this is the only instance I've seen. Windows stores zone information on files downloaded through the Internet in certain circumstances to determine if they are "safe". These are stored in extended attributes which are a type of hidden file on disk (nothing to do with the H filesystem attribute). In this case, the Visual Studio installer is a stub which downloads the "real" installer. Because of the bug, the file containing the EA data can't be committed to the layer. So from the POV that it's possible that other apps or installers do similar things, and that the risk of the fix is minimal (only in the EA path which we know doesn't work due to this bug), it's certainly worth consideration.

@vieux moving this to 1.13.1 for consideration (see the above comment)


Add a componentWillUpdate hook to refresh the Dropzone component with updated configurations.

This solves the issue outlined in #26 where the Dropzone component needs updated parameters based on changing props passed from the outside world. In our case, we needed to continuously update a signature parameter for an Amazon S3 upload endpoint when users left a browser window open for a long period of time, causing the endpoint URL to expire.
/cc @boram

I think also managed to pick up a bumped react and react-dom patch version (0.14.2). Let me know if that's OK, or if I should hold off.

Neat! This bugged a bunch of people, so thank you very much! I'll bump the version, too :)

@felixrieseberg @andrewhao
The fix provided in the PR breaks the whole component since it overwrites every single dropzone option with what you've set in djsConfig.
this.dropzone.options = this.getDjsConfig()
This forces users to specify each and every one of dropzone's options, even the default ones, otherwise they cannot use it.
Extending the options should be the best practice here, not overwriting it, imho.

@vmasto - thanks for your insight. I'll put up a PR fix tomorrow, unless you want to take a swag at it first :)

Oh dang, I should have caught that. Fix coming right up.

...and fixed!

Oh boy you beat me to the pulp, thanks! Will test immediately.

I've added Helpers.extend, which I copied in from jQuery a while ago - so old props aren't being overwritten, but additional props should be added to the dropzone object. I'm not sure that it'll cover all use cases, but it should not break current implementations.
Take a look - I'd love a second set of :eyes:

Thanks @felixrieseberg and @vmasto for your quick feedback & fixes. :+1:


ArcGIS: specify output fields

ArcGIS geocoding requests do not return the country code by default, which I need for my application. It should be possible to pass a parameter to the geocode method to specify the output fields.
Relevant API documentation: https://developers.arcgis.com/rest/geocode/api-reference/geocoding-find-address-candidates.htm#ESRI_SECTION1_72748BA0A3B94DE2B5C3C38F56D2D026

I've not tested this, but have you tried adding the parameter into the query string? i.e. put &outFields=Country after your search string. Then you could dig it out of the raw data in the returned Location object.
That said, I've just noticed that the find operation has been deprecated and has been replaced with findAddressCandidates, so this module needs updating.

It doesn't work because query string gets urlencoded.

Actually, having just updated the code for the latest API in my pull request #227, this idea won't work due to the urlencode function.
For a reverse lookup you can get it from the raw data in the Location object:  result.raw['CountryCode'] (where result is the output from calling the reverse function).

Ok, I've worked this out for you - I can add a parameter to the geocode function to specify the outFields. However, do you think you should pass a string: out_fields="Country,Type" or a list/tuple: out_fields=("Country","Type"). I'm not sure which form or parameter would be best. At the moment I've gone with the list/tuple option - I will update my PR in a moment.

If you want to test the string option with my arcgis-api-update branch that would be great.
I'll look into updating it to accept both.

Thanks for the PR. I have done some quick tests and it looks ok.

It now takes either a string (,-delimited if more than one field requested) or a list/tuple. I have also added a couple of tests - hopefully these are acceptable to the maintainers! (I'm pretty new to using tests).

Resolved by #287


Issue with linting in PR builder

Describe the issue:

When a PR has only changes in JS files, PR builder's lint step is failing with following error.

Fixed with

https://github.com/wso2/identity-apps/pull/5845


Some errors in Run Templater stage are not correctly represented in the JobStatusModal since logger fails to log the error

When creating a new component using the CRA template, if the Run Templater stage throws an error, the modal is not updated accordingly. The Run Templater stage's status gets stuck at "STARTED" (blue color) when it should be "FAILED" (red color).

When I debugged it, I found that in processor.ts, the error is caught as expected in processor.ts line 119. However, logger.error() in that catch-block throws its own exception, namely "[ERR_STREAM_WRITE_AFTER_END]: write after end" which is consequently caught at line 134. Since stage.status is set after the logger throws a new error, it's never reflected in the GUI that the stage failed.
I've tried to find out where/why the logger is prematurely closed but to no avail. To make matters more complicated, the issue doesn't seem to be consistent for all errors. For example, when I create a component without Docker running (which also breaks the Run Templater stage with "ECONNREFUSED") it doesn't happen.
Expected Behavior

The Run Templater stage should get marked as "FAILED", making the sidebar color red.
The logger should not fail to log the error.

Current Behavior

The Run Templater stage gets stuck on "STARTED", making the sidebar color blue, even it it failed.
The logger throws "[ERR_STREAM_WRITE_AFTER_END]: write after end".

Possible Solution

A quick work-around which doesn't solve the logger-issue is just to set the stage's status before logging the error.
For the logger ending prematurely, I don't know!

Steps to Reproduce

navigate to /create/create-react-app-template
For the component-Id field, enter a name with capital letters.
Go through the rest of the form and press "Create".
Wait for the Run Templater stage to break.
See error.

My setup: notice the invalid Component ID

Context
Error caught in processor.ts line 119:

Error caught in processor.ts line 134:

Your Environment
NodeJS Version (v12): v12.18.4
Operating System and Version: macOS catalina version 10.15.4
Browser Information: Google Chrome Version 85.0.4183.121 (Official Build) (64-bit)

Do you wanna take a stab at this too @erictnilsson?

A quick work-around which doesn't solve the logger-issue is just to set the stage's status before logging the error.

Seems reasonable 👍

Sure thing! 🙂


Restric types after assertion

I'm using static analysis (PHPStan, Psalm) on my tests, and with the appropriate extensions they are able to restrict types after I've applied assertions.
$this->assertIsString($foo);
// $foo is string now

$this->assertIsInstanceOf(Bar::class, $foo);
// $foo is a Bar instance

Would it be possible to do the same here? It would enable autocomplete os such variables, and suppress warning due to unknown types.

its not related to this plugin, the methods having the docblock describing the behavior.
https://github.com/Haehnchen/idea-php-generics-plugin you can look at this plugin; some docblock are already support.

its not related to this plugin, the methods having the docblock describing the behavior.

How can you add PhpDoc yourself to methods for PHPUnit?

PHPUnit is already having the docblock: https://github.com/sebastianbergmann/phpunit/blob/master/src/Framework/Assert.php#L1324

Thank you!


Option to specify path to configuration file

Context
Follow-up of #263. Now that config files are supported, I'd like to be able to specify a different path for the config file. The reason is that I put all tools config files into a config folder (name is not important), and call linting tools from my task runner, which takes care of passing the right path to the config file.
Proposal
Adding a simple option to the CLI like mdformat -f config/mdformat.toml (-f because -c is more similar to --check). Long option could be --config or --config-file.
Tasks and updates
No response

Thanks for the issue!
I think adding this might be ok. I'm a bit unsure about this for concerns about global config similar as here. This is much better in that the config is explicitly specified so not so much a side effect.
This does raise the question of how to determine root directory for file exclusions. Is it current working directory or the parent directory of the specified config file? We have to know this before implementation.

This is much better in that the config is explicitly specified so not so much a side effect.

Strongly agree. I've never seen anyone using global configuration for tools, as project usually ship their own config, and the config usually depends on the project anyway, so global config rarely make sense. Then it's true that a -f config option would re-enable global configuration, but as you mentioned, you have to explicitly pass the option, and we're responsible adults :smile: Note that I'm not planning on using this option for global config :slightly_smiling_face: I simply prefer organizing my config files in a subfolder (and I generally dislike default config names that start with a dot).

This does raise the question of how to determine root directory for file exclusions. Is it current working directory or the parent directory of the specified config file? We have to know this before implementation.

Indeed, it's important to know that before starting to work on the feature :thinking:
Computing things as relative to the configuration file (or rather its parent folder) means you don't have to get the Git root repository, and running the tool will work from anywhere in the repo (doesn't depend on the CWD either). That also means you have to update the file if you move it, but I believe this rarely happen, so it's not a big issue.
Config-relative paths make sense for .editorconfig for example, because you can have many such files in your repo. mdformat will probably accept only one file, so maybe it doesn't make as much sense, and repo-root-relative or CWD-relative paths will be easier to implement / more intuitive. Many tools depend on the CWD and users generally don't care, as most of the time commands are run from the root of the repository anyway.
Ultimately I think it depends on the tool, and what you're most comfortable with. Sorry, I'm not super helpful here :smile: Anything you choose is fine by me :slightly_smiling_face:

Strongly agree. I've never seen anyone using global configuration for tools, as project usually ship their own config, and the config usually depends on the project anyway, so global config rarely make sense.

ruff (contrary to your comment), mypy (ditto), black, and flake8 all support global configuration files. This is useful because it allows me to get the benefits of linters and formatters when working outside of a shared codebase.  While these tools don't mandate that you use this functionality -- as is evinced by your not knowing it exists (win!) -- lots of people make use of it and it's no big deal.
I find that the global configurations are useful to give me the benefits of linters and formatters with a consistent configuration that I'm used to when working in codebases I don't share with others.

I see, my bad for assuming few people use global configs :smile:


Allow synchronization via bazel query

Description of the issue. Please be specific.
We have a number of targets tagged "manual" that we have to irritatingly sync by hand.
I believe these are excluded from the regular sync because the regular sync uses bazel wildcards, and the targets are excluded from the wildcard.
It would be great if the bazel plugin could use bazel query to determine the targets to sync rather than bazel build: this would allow everything to be discovered, and still let us exclude some of our targets from wildcard build and test.
What's the simplest set of steps to reproduce this issue? Please provide an example project, if possible.

Have a project with some manual targets and an extremely minimal project view. (In particular, the project view should reference the manual targets implicitly via wildcard, not explicitly.)
Sync the project.
Note the manual targets are missing.

Version information
IdeaUltimate: 2022.3.1
Platform: Linux 5.19.0-1023-aws
Bazel for IntelliJ plugin: 2<IP_ADDRESS>.1-api-version-223
Bazel: 5.3.0

I think this is similar to https://github.com/bazelbuild/intellij/issues/4546. @rogerhu is planning to provide a fix.

Sorry for the delay - here is the proposed patch. https://github.com/bazelbuild/intellij/pull/5085

This ticket i believe can be closed?


scRNA workflow

Clean version

Hi @mtekman, we changed the way we add metadata in this repository, and I've updated your PR accordingly, the metadata is now added at the top of the tutorial.md file :)

There is https://en.wikipedia.org/wiki/Bulked_segregant_analysis
for example, but never mind: bulk is probably just fine :)
On 01.02.19 11:25, Mehmet Tekman wrote:

@mtekman commented on this pull request.

In topics/transcriptomics/tutorials/scrna_preprocessing/tutorial.md
https://github.com/galaxyproject/training-material/pull/969#discussion_r253000630:

text-align: center;

border-right: 1px solid #ddd;
border-left: 1px solid #ddd;
+}

+
+
+
+# Introduction
+{:.no_toc}
+
+
+## Why do Single Cell sequencing?
+{:.no_toc}
+
+Single-cell RNA (scRNA) sequencing is the technological successor to classical bulk RNA-seq, where samples are no longer defined at the tissue level but at the individual cell level. Under bulk RNA-seq the expression of genes in a sample would yield the average expression of all the constituent cells in that sample, irregardless of the distinct expressions profiles given by subpopulations of cells. The advent of scRNA sequencing has provided the means to explore samples at the individual cell level, enabling a greater understanding of the development and function of such samples by the characteristics of their constituent cells. Consider the heterogenity of cells sampled from bone marrow, where hematopoietic stem cells can give rise to many different cell types within the same tissue:
It's bulk, the second one sounds strange to me
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/galaxyproject/training-material/pull/969#discussion_r253000630,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AEhbwTOWJLl46QGdrOOZckHla0bMX3KAks5vJBYqgaJpZM4WFlxv.

thank you so much for the review @wm75


its not done but commit pre-rework

like i get it why i cant but i wanna approve my own changes lmao


[Bug]: Chroma HNSWLib Dependency Issue

Bug Description
ERROR: Cannot install llama-index-cli because these package versions have conflicting dependencies.
The conflict is caused by:
llama-index-vector-stores-chroma 0.1.5 depends on onnxruntime<2.0.0 and >=1.17.0
llama-index-vector-stores-chroma 0.1.4 depends on onnxruntime<2.0.0 and >=1.17.0
llama-index-vector-stores-chroma 0.1.3 depends on onnxruntime<2.0.0 and >=1.17.0
llama-index-vector-stores-chroma 0.1.2 depends on onnxruntime<2.0.0 and >=1.17.0
llama-index-vector-stores-chroma 0.1.1 depends on onnxruntime<2.0.0 and >=1.17.0
To fix this you could try to:

loosen the range of package versions you've specified
remove package versions to allow pip attempt to solve the dependency conflict

ERROR: ResolutionImpossible: for help visit https://pip.pypa.io/en/latest/topics/dependency-resolution/#dealing-with-dependency-conflicts
Note: OSX Version 13.5.6
Version
0.10.15
Steps to Reproduce
pip install llama-index
Relevant Logs/Tracbacks
ERROR: Cannot install llama-index-cli because these package versions have conflicting dependencies.

The conflict is caused by:
    llama-index-vector-stores-chroma 0.1.5 depends on onnxruntime<2.0.0 and >=1.17.0
    llama-index-vector-stores-chroma 0.1.4 depends on onnxruntime<2.0.0 and >=1.17.0
    llama-index-vector-stores-chroma 0.1.3 depends on onnxruntime<2.0.0 and >=1.17.0
    llama-index-vector-stores-chroma 0.1.2 depends on onnxruntime<2.0.0 and >=1.17.0
    llama-index-vector-stores-chroma 0.1.1 depends on onnxruntime<2.0.0 and >=1.17.0

To fix this you could try to:
1. loosen the range of package versions you've specified
2. remove package versions to allow pip attempt to solve the dependency conflict

ERROR: ResolutionImpossible: for help visit https://pip.pypa.io/en/latest/topics/dependency-resolution/#dealing-with-dependency-conflicts

I had the same issue. Within my Conda environment, I installed onnxruntime v1.17.1 through Conda Forge before installing llama-index-vector-stores-chroma with pip. Seems to work. HTH.

cool, seems the chroma team suggested something similar, i posted this for an attendee at a hackathon I was hosting, closing for now as the problem is no longer within my scope

if you have this bug too.may be solved by:
conda install -c conda-forge onnxruntime


f_open works but f_lseek and f_read does not

I am trying to load wav data into SDRAM. So first I open a file with f_open() which returns 0 (no error)
But then if I try f_lseek() or f_read(), it returns 1 (FR_DISK_ERR)
It prints:

Daisy is online↵
.===============↵
.Comenzando probarSDRAM.cpp↵
sdcart.init(): 0↵
fsi.Init: 0↵
f_mount: 0↵
abriendo: C4.wav↵ //no error with f_open()
f_lseek error: 1
f_read no se puede abrir C4.wav  error: 1      bytesRead: 0↵
.init audio↵
.fin del main() de probarSDRAM.cpp↵

If I don't use f_lseek(), bytesRead becomes 2 million instead of 0, still gives me error (and it left some hundred bytes to read).
I thought it could be a problem of the SDRAM, but that does not explain why f_lseek() does not work.
On the example WavPlayer.cpp you use f_lseek and f_read, and they seems to work
Here is my code:
#include <stdio.h>
#include <string.h>
#include "daisy_pod.h"

using namespace daisy;

DaisyPod       hw;
SdmmcHandler   sdcard;
FatFSInterface fsi;
WavPlayer      sampler;
int16_t DSY_SDRAM_BSS SDRAMsamples[1024 * 1024 * 32];

void AudioCallback(AudioHandle::InterleavingInputBuffer  in,
                   AudioHandle::InterleavingOutputBuffer out,
                   size_t                                size)
{

    for(size_t i = 0; i < size; i += 2)
    {
        static uint32_t indice = 0; //va de 0 a
        out[i]              = s162f(SDRAMsamples[indice]) * 0.5f;
        indice++;
        out[i + 1]          = s162f(SDRAMsamples[indice]) * 0.5f;
        indice++;
    }
}

int main(void)
{
    // Init hardware
    size_t blocksize = 4;
    hw.Init();
    hw.seed.StartLog(true);
    int error;
    System::Delay(3000);
    hw.seed.PrintLine("Comenzando probarSDRAM.cpp");
    System::Delay(3000);
    SdmmcHandler::Config sd_cfg;
    sd_cfg.Defaults();
    //hw.seed.PrintLine("sd_config.defaults(): %d", error);
    System::Delay(3000);
    SdmmcHandler::Result errorsdmmc = sdcard.Init(sd_cfg);
    System::Delay(3000);
    hw.seed.PrintLine("sdcart.init(): %d", errorsdmmc);
    System::Delay(3000);
    error = fsi.Init(FatFSInterface::Config::MEDIA_SD);
    System::Delay(3000);
    hw.seed.PrintLine("fsi.Init: %d", error);
    System::Delay(3000);
    error= f_mount(&fsi.GetSDFileSystem(), "/", 1);
    System::Delay(3000);
    hw.seed.PrintLine("f_mount: %d", error);

    sampler.Init(fsi.GetSDPath());
    sampler.SetLooping(true);

    FIL fil;
    uint8_t errorff;
    errorff = f_open( //devuelve zero si esta todo bien
        &fil,
        "C4.wav",
        (FA_OPEN_EXISTING | FA_READ));
    if(!errorff) //si abre bien, OpenByName() devuelve 0
        hw.seed.PrintLine("abriendo: %s", "C4.wav");
    else
        hw.seed.PrintLine("no se puede abrir %s  error: %d", "C4.wav", errorff);
    System::Delay(3000);
    //errorff = f_lseek(&fil, 44); //me salteo la metadata
    //if(!errorff) //si abre bien, OpenByName() devuelve 0
    //    hw.seed.PrintLine("f_lseek: %s", "C4.wav");
    //else
    //    hw.seed.PrintLine("f_lseek no se puede abrir %s  error: %d", "C4.wav", errorff);
    //System::Delay(3000);
    unsigned int bytesRead;
    do
    {
        errorff = f_read(
            &fil, SDRAMsamples, 1024 * 1024 * 4, &bytesRead); //lee de a 4Mb
        if(!errorff) //si abre bien, OpenByName() devuelve 0
              hw.seed.PrintLine("f_read: %s     bytesRead: %d", "C4.wav",bytesRead);
        else hw.seed.PrintLine(
            "f_read no se puede abrir %s  error: %d      bytesRead: %d", "C4.wav", errorff,bytesRead);
        System::Delay(3000);
    } while(bytesRead == 1024 * 1024 * 4);

    hw.seed.PrintLine("init audio");
        // Init Audio
    hw.SetAudioBlockSize(blocksize);
    hw.StartAudio(AudioCallback);
    hw.seed.PrintLine("fin del main() de probarSDRAM.cpp");

    for(;;)
    {
        // nothing
    }
}

Hi @MarianoDesivo
The FIL object you're using has been created on the stack, and is therefore inaccessible to the SD peripheral.
It's interesting that the f_open call passes at all, but it could be that it doesn't actually start to read any data via the peripheral until the seek/read functions that actually perform diskio.
If you move the FIL fil object into global space it will be created in the default AXI SRAM sector instead of on the DTCMRAM used for the stack, and everything should work.
This is briefly touched on in the documentation for the FatFSInterface, but isn't specific about other FatFS objects, and should probably be mentioned in the SdmmcHandler, as well as having a dedicated guide in the docs. We'll work on getting some better documentation for this.

Great! Thanks Stephen
it's a bit untidy (and some missing prints) but it read everything OK now:

chunksize:↵
WAVE:↵
. bytesread: 4↵
.f bytesread: 4. bytesread: 4. bytesread: 4. bytesread: 4↵
.Subchunk1Size 16 bytesRead: 4↵
.AudioFormat 1 bytesRead 2↵
.NumofChan 2   bytesRead 2↵
.Samplerate 48000   bytesRead 4↵
.byteRate 192000 bytesRead 4↵
.Block Aling 4 bytesRead 2↵
.Bit Depth 16 bytesRead 2↵
.d . . . bytesRead 4↵
.Subchunk2Size 2979536 bytesRead 4 ↵
.f_lseek: C4.wav↵
.f_read: C4.wav     bytesRead: 2979536↵

Also I used this AudioCallBack to play the wav file from the SDRAM and it is working:
for(size_t i = 0; i < size; i += 2)
    {
        static uint16_t indice = 0; //only from 0 to 64k
        out[i]              = s162f(SDRAMsamples[indice]) * 0.5f;
        indice++;
        out[i + 1]          = s162f(SDRAMsamples[indice]) * 0.5f;
        indice++;
    }

Maybe I need to add a buffer instead of directly using the SDRAM in the AudioCallback

@MarianoDesivo Glad to hear it's working!
I recommend using size_t or some other unsigned 32-bit int (e.g. uint32_t) for your index so you don't run into any issues when you try to read beyond the 2^16 sample.
Otherwise, you can read directly from the SDRAM in the audio callback. There are no problems doing that.
The performance of the 64MB SDRAM isn't quite as fast as the internal memory, but it is still quite fast.
I'm going to close the issue, but feel free to keep commenting if you have any other questions on the subject :)


Some list types are under-specified

In most places we tried to have lists with a complete type annotation, e.g. typing.List[TargetInfo] but in a few places we had to cut corners and we just left it as typing.List.

Fixed in 6870c77.


python312Packages.cyclonedx-python-lib: 7.3.2 -> 7.3.4

Diff: https://github.com/CycloneDX/cyclonedx-python-lib/compare/refs/tags/v7.3.2...v7.3.4
Changelog: https://github.com/CycloneDX/cyclonedx-python-lib/releases/tag/v7.3.4
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 309832 run on x86_64-linux 1

8 packages built:

checkov
checkov.dist
pip-audit
pip-audit.dist
python311Packages.cyclonedx-python-lib
python311Packages.cyclonedx-python-lib.dist
python312Packages.cyclonedx-python-lib
python312Packages.cyclonedx-python-lib.dist


fix coverity scan

CID 42517 (#2 of 2): Uninitialized scalar variable (UNINIT)
4. uninit_use_in_call: Using uninitialized value addr. Field addr.sin_zero is uninitialized when calling bind.
Summary
Please describe the summary for this PR.
Details
Add more details about this PR.

Thank you for your patch 👍
SRS 2.0 is archived, so we don't update it anymore.


lisas heatmaps and heattree changes

Pls approve and merge if ok @LisaHollstein (since its "my" PR).


Add ELR parsing to CSVs

This PR introduces the functionality needed for us to generate csv rows from ELR data. Using Dan's patient extractor function, this changeset extends that by identifying COVID related observations and incorporating relevant fields into the generated rows. Tests are included for the individual function.
Also, per slack discussion, the return type of all functions should be modified to a list of lists. I've done that for the ELR function and also set up the main functions (and tests) to work with that data type.

Me: how are there so many changes in this PR it was like three functions
Also me: oh right, JSON assets 😂

Can you elaborate on where you think some rows aren't the same length as others? The extract_covid_test function does return lists of different lengths, but if you look at line 37, you'll see that if an empty list is returned its not considered a row we want to write to the CSV so we don't append it. The tests also actually cover this case by including a non-covid observation, which successfully does not get written out to the CSV.


verbose parameter causes imagemin to stop with error

The --verbose parameter causes some output on stderr (since stdout is being used for the new image) and the code stops when there is something written to stderr.
This should be handled a bit differently. If the verbose flag is present, the stderr data chunks should be concatenated and pushed to some sort of logging mechanism.
I would do this myself, but I'm unfamiliar with how the logging should be done in this case.

Fixed in 4.2.1.


Customized map style not working.

Hey guys, I was trying to customize the map with a json array that I generated from the google map api style generator as referred in the documentation but somehow it is not working at all.
I have updated my react-native-maps to 0.12.4 as I noticed it is a new feature.
It broke my android so I'm just testing on iOS right now.
Anyone who has tried and succeded?

I just got my android working and the map is working as expected.
So the issue is with iOS. react-native 0.38.1 and react 15.4.1

hi all, i face with this issues too. Any update?

@percyteng is your project working?

I'm facing the same issue on iOS with:
React Native: 0.41.2
React Native Maps: 0.13.0
On Android everything is working.

I just got started with react-native-maps but I also can't get my styles to work on iOS. I haven't tried Android yet.
I wonder if I need to switch to / enable google maps, instead of the default map renderer on iOS? Are json styles supported out of the box on iOS? Thanks!


Extension v3.2.0 installation failed "The extension encountered an error while starting up"

I've been using Brackets and this extension for nearly 2 years without issue.  A couple of days ago I started getting "ESLintError: No ESLint cli available, try reinstalling the extension".
Rinstalling gives "Installation failed. The extension failed while starting up."
Brackets version 1.14, ESLint extension v3.2.0, Win10, node.js v8.11.1, npm v6.11.3, react v16.8.6.
I've tried reinstalling Brackets installing eslint-cli as well as eslint install/init manually via npm.
Love the extension, however, this has just wasted 2 frustrating days.

Same issue here.


Beacon Sample errors

http://googlechrome.github.io/samples/beacon/
Uncaught SyntaxError: Unexpected token ( line 77

Closed in https://github.com/GoogleChrome/samples/pull/154


[ACM-13485] Enabled VirtualMachine actions from search results

PR adds ability to start, stop, restart, pause, and unpause VirtualMachines. These actions are hidden behind the VIRTUAL_MACHINE_ACTIONS feature flag.

FYI @jlpadilla

/lgtm


Action to run on-demand Job from CronJob

CronJobs should have a (client-side) action to take the jobSpec from the CronJob and create a new [regular] Job out of it, so that you can run the CronJob on-demand.

Setup For Reproduction and Validation
Rancher versions: v2.6.1 and v2.6-head(931a0f0)
**Steps for reproduction: **

Go to local cluster from cluster management
Click on workload --> CronJobs --> create CronJobs
Used the following inputs:
Name: auston-test
schedule: 0 * * * *
container image: ranchertest/mytestcontainer
Press create and land on the CronJobs dashboard.
You should see a "Run Now" button on the (931a0f0) version of rancher

Screenshot Before Button was Added

Screenshot After Button is Added

Sanity Checks

I checked this on multiple types of downstream clusters.
I deleted the CronJob and added it again
I cleared my cache and refreshed the page and the button was still there.


Annotate Polymer function with @global.

This will let Analyzer discover it thanks to
https://github.com/Polymer/polymer-analyzer/pull/774.
Part of https://github.com/Polymer/gen-typescript-declarations/issues/23

I am okay with an extra annotation, but it leaves me wondering why detecting an assignment starting with window. wouldn't work. Is that because the polymerFn is used instead of Polymer?

Our approach in analyzer has so far generally been to just follow the @memberof annotations, rather than trying to understand the LHS of the assignment expression. If a function doesn't have @memberof, it would be totally ignored. So I just extended this to also respect @global, since @memberof window was a bit weird (see https://github.com/Polymer/polymer-analyzer/pull/774). I guess we could have had special handling for window instead, this was just simpler to do. Note it is a JSDoc thing: http://usejsdoc.org/tags-global.html.


⚠ File access has degraded performance

In 07167fe, File access (https://fyle.uk/file/fish) experienced degraded performance:

HTTP code: 200
Response time: 5839 ms

Resolved: File access performance has improved in aca481d after 8 minutes.


Update strategy: newest-build not working

Describe the bug
I using argocd image updater latest (sha256:b3622d981368b5dc31e7d85545c3572e4a1c990cbe2403f8bb8053aa70766672). It was working fine with update-strategy: semver (default) but when i change tag to 8 characters of SHA git commit, it not working it not even show logs (it just empty).
To Reproduce
Here is my yaml file:
apiVersion: argoproj.io/v1alpha1
kind: Application
metadata:
  name: image-nexus
  namespace: argocd
  annotations:
      argocd-image-updater.argoproj.io/image-list: image=****/voc/nodeapp
      argocd-image-updater.argoproj.io/write-back-method: git:secret:argocd/git-creds
      argocd-image-updater.argoproj.io/git-branch: main
      argocd-image-updater.argoproj.io/write-back-target: kustomization
      argocd-image-updater.argoproj.io/image.force-update: "true"

      argocd-image-updater.argoproj.io/image.update-strategy: newest-build
      argocd-image-updater.argoproj.io/image.ignore-tags: latest, master
      argocd-image-updater.argoproj.io/image.allow-tags: regexp:^[0-9a-f]{8}$
spec:
  project: default
  source:
    repoURL: https://gitlab.com/van1122/project-argocd.git
    targetRevision: HEAD
    path: image-nexus-service/base
  destination:
    server: https://kubernetes.default.svc
    namespace: test-image-nexus
  syncPolicy:
    syncOptions:
    - CreateNamespace=true
    automated:
      selfHeal: true
      prune: true

Expected behavior
When code change in git, a workflow will run to build and push image with a tag is first 8 characters and i want argocd image updater monitoring image registry and automation update new tag to file kustomization.yaml
Additional context
I also give credential of image registry for argocd-image-updater
Version
latest (sha256:b3622d981368b5dc31e7d85545c3572e4a1c990cbe2403f8bb8053aa70766672)
Logs
I don't know why but when i use update-strategy: newest-build there not print logs, it completely empty. When update-strategy is semver everything working fine (have logs)

I did some testing with using the 'newest-build' strategy and noticed in the logs this was not an acceptable strategy. Image updater ended up defaulting to semver.  I am using v0.12.2 when I observed the below error.
level=warning msg="Unknown sort option newest-build -- using semver

The documentation is a bit confusing as there are warnings to switch to the new names but they appear to be not ready yet. You might try using latest instead and see if that works for you.

I did some testing with using the 'newest-build' strategy and noticed in the logs this was not an acceptable strategy. Image updater ended up defaulting to semver. I am using v0.12.2 when I observed the below error.
level=warning msg="Unknown sort option newest-build -- using semver

The documentation is a bit confusing as there are warnings to switch to the new names but they appear to be not ready yet. You might try using latest instead and see if that works for you.

The version v0.12.2 is different from version latest (sha256:b3622d981368b5dc31e7d85545c3572e4a1c990cbe2403f8bb8053aa70766672), but the update-strategy: latest is working fine in your version v0.12.2? I have tried all scenarios but none of them is work :(


libz blitz: use question mark instead of unwrap in examples

Rebase pull request #141 on master

Thank for your guiding.

It's in conflict now. @muzikmoe if you're busy, I can resolve it for you.

@opilar thank you.

My comment about the unrelated change is still here, and it still needs a rebase. @muzikmoe any interest in keeping up with this PR?

Triage: seems like this PR got lost in the shuffle; I'm going to give it a close. Thanks for the effort.


Duplicate Paragraph

You have a duplicate paragraph in the advisor section

However, you don't have to be a Teams admin to use Advisor for Teams - anybody in your organization can use it. We've set up special permissions so non-admin users can get to Advisor for Teams, even though it's in the Teams admin center. You DO have to be a Teams admin, Teams Service Administrator, or Global Administrator to open the tenant readiness assessments (this is because the special non-admin roles don't have access to the Microsoft Graph APIs underlying the assessments).-

This paragraph is repeated.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d8837c1c-ea62-4ac9-5187-3da28ff2086c
Version Independent ID: 1ae9e143-9895-521f-a3e4-42c9dd8436c0
Content: Use Advisor for Teams to help you roll out Microsoft Teams - Microsoft Teams
Content Source: Teams/use-advisor-teams-roll-out.md
Service: msteams
GitHub Login: @SerdarSoysal
Microsoft Alias: serdars

@EgoManiac Thank you for submitting feedback and contributing to the docs. We are currently investigating this.

@EgoManiac  Thank you for submitting feedback. We understand that this issue has been resolved.
Please feel free to re-open this issue if there is a specific area of the docs that we can improve or make better. Thank you.


Project with datashader and football matches visualization

I started a project that visualize the matches of football teams in the UEFA Champions League. The project is not finished yet and can be found here.
The project takes the matches of all teams that have participated in the Champions and the coordinates of their stadiums. Then I plot each match since 1955 as a line between the coordinates of the stadiums of both teams.
I'm not very happy with the visual appearance of the map. I would like to have something nicer. One option could be to change the map to a black and grey map of Europe and then plot the lines in white and grey. Do you know how to get a map like this? Here is the map.
Any other suggestion is welcomed

Sounds like you can use the Stamen toner maps
(url 'http://tile.stamen.com/toner-background/{Z}/{X}/{Y}.png'), and use the alpha parameter to change the brightness level to make it gray and black.

thanks!


Add an ESM variant + make tree shakeable

Benefits those with client side js who only use some of the helpers or just the ponyfill.
Will probably be implemented like in async-htm-to-string, using the very same linemod tool.

Done as of https://github.com/voxpelli/pony-cause/commit/6174b7b8b6c304ea7cf2571f1e55d596bf710cfa / v2.0.0

When compiling the following:
import { ErrorWithCause } from 'pony-cause';

console.log(new ErrorWithCause('Foobar'));

With  npx esbuild foo.mjs --bundle --minify it becomes:
(()=>{var t=class extends Error{constructor(s,{cause:e}={}){super(s),this.name=t.name,e&&(this.cause=e),this.message=s}};console.log(new t("Foobar"));})();

See live example of the above: https://bundlejs.com/?q=(import)pony-cause&treeshake=[{+ErrorWithCause+}]&text="console.log(new+ErrorWithCause('Foobar'));"