Questions about Dockerfile.

This is related to #283
When cleaning up the Dockerfile, there are still some things which are not clear to me:

We're exposing an http port (5060) but there's not one browser I tried which allowed connecting to that. There's also no HttpsRedirection enabled in the template. So I'm not sure why that's needed.
The line where a user is added:# Creates a non-root user with an explicit UID and adds permission to access the /app folder
# For more info, please refer to https://aka.ms/vscode-docker-dotnet-configure-containers
RUN adduser -u 5678 --disabled-password --gecos "" appuser && chown -R appuser /app
USER appuser

That link points to a page about python. When I look at the dotnetcore section on that same site, there's no requirement at all for creating a user. So I'm not sure why that's needed either.

Now I've got it running locally, I'm gonna try and deploy that to a linux vm we're running in the cloud. I'll update the instructions when I get it running over there.

Thinking a bit ahead and in the section that should be created to promote agility in deployments, I think several points should be taken into consideration:

creation of images

resources (redis, db)

certificates (ssl)

docker swarm, kubernetes

For the certificate point it is possible to manage this resource from the router, for example Traefik https://doc.traefik.io/traefik/

For the point of creation of the user, the idea is not to run the application with a root user:

https://engineering.bitnami.com/articles/why-non-root-containers-are-important-for-security.html


next 8.0.3: JS in client side don't respond

Bug report
In version 8.0.3 after running "next build" the client side does not respond in production mode.
To Reproduce

Start a new next.js project.
add some client side code in the file, for example an "onClick" event on a button, etc.
Run in dev mode  - all fine.
Run "npm build" and then "npm start"  - the onClick event don't respond. no errors in the console.

System information

OS: ubuntu 16.04
Version of Next.js: 8.0.3

Please provide a clear and concise reproduction. We have tests for the exact steps you're providing.


ATEM tally incorrect during a transition

This is such a great project!. I love it!
If I start a transition manually on an ATEM Studio HD the PV bank switches to red, but this is not matcher on TA. It only seems to notice at the end of the transition, when the new input hits the program bus. The screenshot shows the 2 reds on the ATEM, but the setup mimic on TA shows a red & green. Is this a problem with the signalling from the ATEM?
FYI my Stream Deck Companion status works fine when linking the button's status to "Change colours from mixer program tally"

I noticed this as well. Even after the Mix transition is complete, there is a delay of a second or two before the colors swap in Tally Arbiter (and on the listeners I use). The bug is the same for Auto button transition as well as T-bar transition.

This should be fixed in latest


Feature request: Improvement for user configuration

Consider using tools like platformdirs to save the config file (and many other files) in standard directories with multi-platform support. It is very important to follow XDG when placing files inside other people's systems, that way the information is well organized in the OS. You can see a simple example in this project of mine where I also create config files using configparse (and also log files) with the help of platformdirs to automatically retrieve the correct path that should store those files.
It is really easy to implement and the benefit is huge for the open-source community!

Hi,
thanks for info and also providing helpful links.
So would it then be best practice to store the pykanban.ini in user_config_dir and the pykanban.json data for the boards
in user_data_dir?

Exactly, that would be a nice way to organize the files. By the way, maybe it would be simpler to avoid creating folders for different boards and just create the JSON files with the name of the boards.
That wat instead of having:
└───kanban_boards
    ├───Test Board
    │       pykanban.json
    │
    └───test-board
            pykanban.json

You could just have:
└───kanban_boards
    ├───Test Board.json
    └───test-boardjson

That way could be easier to manage the different user boards.
Either way the app looks nice, I love the rich usage!

Ye I was also thinking about different ways of structuring that see here
The reason why I decided to create board specific folders is because I also plan to create some reports/statistics on task completion/progress in the future, which I want to store in the board folder next to the tasks.
I will change to the XDG convention after Ive completed the automated scanner to add tasks.
Thanks again forthe helpful feedback and ressources.
Glad you like the app :)

@YisusChrist  Done :)

I checked it and it looks nice. I love the way you organized the new constants module. Congratulations!

Thank you @YisusChrist
Like I Said, the Ressources you provided were a great Help and I learned Something New. Thanks again for that :)
Also Improved configuring the settings and added an Option to Show Tasks now with todays newest Release.


ST-4542: Upgrade jetty to address CVE-2020-27216

Note that Jersey needs to be upgraded as well to ensure compatibility.
See this word of caution that was included in AK before this
upgrade was applied:
https://github.com/apache/kafka/blob/dbdd1b1bb72ab0e012f7a746cefb6e593da44683/gradle/dependencies.gradle#L71

Closing this because this was taken care of by pint merge from #211


ENH: Update exception message to resolve #10515

Made a quick change to the Exception raised in _convert_with_dtype per the issue raised in #10515.

thanks!


hubble: Add kafka metrics

Adds Kafka metrics to hubble.
hubble: Add kafka metrics

@michi-covalent Good idea. I also removed the error codes from the histogram because it's probably not needed (can be overlayed with the requests metric) and will increase cardinality potentially too much. I did add Apikey to the histogram though.

/test

/test

/test

test-runtime

test-runtime

/test

/test

/test

/test


Add Elf starter project

This adds my new starter project, Elf. Thank you in advance 😇

Thank you!

Thank you!


Any plans to support reccuring events with rrule?

First off, great job putting this together! I've been looking for a viable alternative to fullcalendar and this is it.
Can you please advise or point to how to handle recurring events? Fullcalendar has rrule-plugin. Do you offer anything similar? I couldn't find it in the docs.
Cheers!

Hi @treighmawaka
Thank you for the star! 🙂
As for the recurring events, unfortunately, I have no plans to support them at this time. But I'll leave this issue open and if more people require this feature then I will do it.

@vkurko thanks for the quick reply.  I'll keep on eye on this, hopefully it's upvoted.

I agree that this feature would be really helpful. I'm currently trying to find a workaround as my use case will need to support recurring events.
Thanks for this great project!

we too are looking for this, if it’s something I can help with I’d be more than happy to, but svelte is new to me. If anyone has any workarounds or such that would be nice to share. Looking forward to contributing where I can!

I will be implementing recurrence in one of the solutions I am using this library, and I think present capabilities of the calendar are perfectly enough to achieve this.
What I mean by that is since the calendar is only really meant to present the data in a visual way and responsibility of managing the data is not really something that should fall on the calendar itself.
While viewing it the absolute max you should have inside events prop at any given time should be the amount that calendar can draw at a time.
Think about it like having a box the size of the currently used view.
If it's a week, you should have week's worth of data or you may easily run into performance challenges.
Instead you should have a layer of methods that dynamically select the data you want to be presented based on the currently displayed date range and if you want to indicate that event is recurring you can utilize html content of particular event by for example displaying some icon.
Having that said I'm building some utilities that will support this project and example implementation of some templates that can be used as event content including recurring events could be in scope for that.

@amoscicki  i agree 100% in what you said, that would be really helpful if you’re willing to share your outcomes too. The calendar is a nice representation of the data, but generating the data should happen outside that element.


VSCode tunnel fails to handle IP address proxy correctly

Does this issue occur when all extensions are disabled?: Yes

VS Code Version:  code 1.86.0 (commit 05047486b6df5eb8d44b2ecd70ea3bdf775fd937)
OS Version: Linux 5.4.0-152-generic #169-Ubuntu SMP Tue Jun 6 22:23:09 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Steps to Reproduce:

Assuming proxy IP address is <IP_ADDRESS>:5678
export http_proxy=http://<IP_ADDRESS>:5678
code tunnel

Output:
[2024-02-02 13:30:30] debug Starting tunnel with `code ./code tunnel --verbose`
[2024-02-02 13:30:30] debug starting as new singleton
[2024-02-02 13:30:30] debug Using file keychain storage due to: user prefers file storage:
[2024-02-02 13:30:30] trace Found token in keyring
[2024-02-02 13:30:30] debug [reqwest::connect] starting new connection: https://api.github.com/
[2024-02-02 13:30:30] debug [reqwest::connect] proxy(http://<IP_ADDRESS>:5678) intercepts 'https://api.github.com/'
[2024-02-02 13:30:30] debug [reqwest::connect] starting new connection: https://asse.rel.tunnels.api.visualstudio.com/
[2024-02-02 13:30:30] debug [reqwest::connect] proxy(http://<IP_ADDRESS>:5678) intercepts 'https://asse.rel.tunnels.api.vi
sualstudio.com/'
[2024-02-02 13:30:32] debug Starting tunnel to server...
[2024-02-02 13:30:32] trace Found token in keyring
[2024-02-02 13:30:32] debug [tunnels::connections::relay_tunnel_host] connecting via http_proxy on http://<IP_ADDRESS>:5678
[2024-02-02 13:30:32] warn Error connecting to relay, will retry: error connecting to tunnel: proxy connection failed: fail
ed to lookup address information: Name does not resolve
[2024-02-02 13:30:32] error Error connecting to tunnel endpoint: error connecting to tunnel: proxy connection failed: faile
d to lookup address information: Name does not resolve

But
If I change export http_proxy=http://<IP_ADDRESS>:5678 to export http_proxy=<IP_ADDRESS>:5678, the tunnel starts correctly, suggesting that VSCode always tries to resolve the name if prefixed with http://, even when the name is already an IP address.

Duplicates https://github.com/microsoft/vscode/issues/201417


piraeus-controller goes into NotReady constantly

readinessProbe settings are too tight that it went into NotReady then Ready loop constantly.
The default timeoutSeconds of 1s (probably injected by kubelet) caused so many of "Timeout exceeded while awaiting headers" since I noticed it took a while to respond to linstor controller list-properties.
I increased the timeoutSeconds to 5s then it stayed at ready. I think we should define it in the deployment file. I also increased the periodSeconds so it does not spam the rest-access.log.
By the way, why are we mounting /etc/localtime? It caused me headaches because /etc/localtime on Fedora CoreOS for some reason is a empty directory. I don't see the reason since other deployments of Linstor does not do this.

Good catch. Previously, I was trying to get the entire cluster up as fast as possible. So will follow the readinessProbe change.
Mounting /etc/localtime is meant to set the pod timezone to that of the host.  I have noticed it not working on some hosts. Let me try some other methods for this.

changes have been made accordingly.

relent readinessProbe to 5 sec
change timezone to /usr/share/zoneinfo/Etc/UTC format

changes have been made accordingly.
relent readinessProbe to 5 sec
change timezone to /usr/share/zoneinfo/Etc/UTC format

Hey, I looked into your commit, actually the culprit is timeoutSeconds not periodSeconds (though it's probably better to change it as well), I think 3 seconds is enough, 5 would be a safer bet. Also only controller need to be changed, other things are perfectly fine with old settings.


java.project.referencedLibraries not available at project level (settings.json)

We have written the needed data into your clipboard
Issue Type: Bug
The "java.project.referencedLibraries" works only at workspace level, not at project level.
Contrary to what is described in the online docs (https://code.visualstudio.com/docs/java/java-project), configuring the "referencedLibraries" within the project's settings.json does not work, and the configuration item is actually greyed out.
Moreover, no "java.project.referencedLibraries" setting is present within the settins of the Project Management for Java extension.
This is also contrary to common sense as tipically the libraries a project depends on and their locations are specific to each project, so I wonder what's the sense of having it configured only as a workspace setting.
 Please paste.

The setting java.project.referencedLibraries is not provided by this extension. It's a setting from Language Support for Java(TM) by Red Hat.
This extension is only used to expose this setting with a UI entry.
By saying not at project level, do you mean you want to set it in the workspace folder level?

Yes, exactly. I have multiple project folders in the workspace and each has
a different set of libraries and library locations.
Gianni
Il lun 9 nov 2020, 01:55 Sheng Chen<EMAIL_ADDRESS>ha scritto:

The setting java.project.referencedLibraries is not provided by this
extension. It's a setting from Language Support for Java(TM) by Red Hat
https://marketplace.visualstudio.com/items?itemName=redhat.java.
This extension is only used to expose this setting with a UI entry.
By saying not at project level, do you mean you want to set it in the
workspace folder level?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/microsoft/vscode-java-dependency/issues/373#issuecomment-723697092,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABWJ6PEK2PCENDH4G4RWLA3SO44YDANCNFSM4TOH3WQQ
.

Thanks. This is an issue related with Java Language Server: https://github.com/eclipse/eclipse.jdt.ls/issues/1303. Once the upstream supports the folder scope, then we can set it to folder level.
As a workaround, you can open multiple VS Code instance for different folders.


chore: bdd-nh-1585152545 to 0.0.1

chore: Promote bdd-nh-1585152545 to version 0.0.1

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Fix GitHub pages

As peaceiris/actions-gh-pages README describes:
permissions:
    contents: write

is required. In other hand, without that, the step will fail.
Also a jump to the version 4 is recommended.
Basically because i did a test on the action without this change, just doesn't work:

Anyways, thanks so much @TheLartians.

Thanks a lot for the fix @Zen0x7 and sorry for the late review! The changes look good, however it seems that GitHub Actions are not starting running in this PR for some reason, even after merging with main. Could it be that you need to enable Actions on your fork?


stream commits to backing cloud filesystem

As an operator, I want gazette to compress and stream local spools to their target cloud filesystem as they're written, so that slow cloud FS fragment writes are back-pressured to the client (and I don't overflow my disk).
This is currently worked-around with a dirty, dirty hack of not using compression if recovery-log is in the journal name.
Criteria:

Upon commit, committed data is optimistically compressed and streamed to the backing cloud FS.
Completing a spool requires only closing / renaming the destination cloud FS fragment.

Implementing the incremental compression portion of this. :+1: :+1: On further reflection, streaming to cloud FS appears low value for the complexity.


Failed to converge when training the model.

Hi, thanks for this great tool.
I managed to get the gmt file with public datasets. But I ran into the error when I try to train the model:
/home/sxykdx/miniconda3/envs/ikarus/lib/python3.9/site-packages/sklearn/linear_model/_logistic.py:460: ConvergenceWarning: lbfgs failed to converge (status=1):
STOP: TOTAL NO. of ITERATIONS REACHED LIMIT.

Increase the number of iterations (max_iter) or scale the data as shown in:
    https://scikit-learn.org/stable/modules/preprocessing.html
Please also refer to the documentation for alternative solver options:
    https://scikit-learn.org/stable/modules/linear_model.html#logistic-regression
  n_iter_i = _check_optimize_result(

So, I try to edit here:
https://github.com/BIMSBbioinfo/ikarus/blob/0a4baf40030f998548c18beb93cb06dd9a774420/ikarus/classifier.py#L533
Changed default from 1000 to 2000,4000,10000,40000; still got the same error message. I'm not sure how to fix this. Maybe, I should subsample the data? Thx

I should try assign n_iter in classifier.Ikarus()

Still can't converge, and the time cost didn't change much, as n_iter increased from 50 to 200, 1000,4000 and 10k

Hi! Could you try to increase max_iter here? I think its default value is 100.
The max_iter and n_iter you changed above refer to later steps, the cnv part and the label propagation, respectively.

Hi! Could you try to increase max_iter here? I think its default value is 100.
The max_iter and n_iter you changed above refer to later steps, the cnv part and the label propagation, respectively.

thanks, it'll do the job without subsampling the training data.
The thing is that I downloaded 3 available datasets of AML sample, 2 as training data, 1 as validation set. I tried 2 cominations. The first classified most of the cells as Tumor, the 2nd classified most of the cells as Normal.
I also tried to change the top_x parameter of gene_list.create_all() to try different ratios of normal genes signature to tumor genes signature. It might be good to have snv or cnv data, which I'm not able to get access to. Do you mind to give me some suggestions? Thanks

Closing the issue now due to inactivity. Feel free to re-open if the problem persists.


Updating Mavenir logo

Pre-submission checklist:
Please check each of these after submitting your pull request:

[x] Are you only including a repo_url if your project is 100% open source? If so, you need to pick the single best GitHub repository for your project, not a GitHub organization.
[x] Is your project closed source or, if it is open source, does your project have at least 300 GitHub stars?
[x] Have you picked the single best (existing) category for your project?
[x] Does it follow the other guidelines from the new entries section?
[x] Have you included a URL for your SVG or added it to hosted_logos and referenced it there?
[x] Does your logo clearly state the name of the project/product and follow the other logo guidelines?
[x] Does your project/product name match the text on the logo?
[x] Have you verified that the Crunchbase data for your organization is correct (including headquarters and LinkedIn)?
[ ] ~15 minutes after opening the pull request, the CNCF-Bot will post the URL for your staging server. Have you confirmed that it looks good to you and then added a comment to the PR saying "LGTM"?

Build failed because of:
No cached entry, and Mavenir (member) has issues with logo: Mavenir-Logo-Primary.svg, ENOENT: no such file or directory, open '/opt/build/repo/hosted_logos/Mavenir-Logo-Primary.svg'
No cached entry, and Sosivio (member) has issues with twitter: https://twitter.com/SosivioLtd, 404 - {"errors":[{"code":34,"message":"Sorry, that page does not exist."}]}
Empty twitter for Rancher Federal (member): https://twitter.com/rancherfederal
No cached entry, and Valve Software (member) has issues with twitter: https://twitter.com/valveoficial, 404 - {"errors":[{"code":34,"message":"Sorry, that page does not exist."}]}
Empty twitter for EMQ Technologies (member): https://twitter.com/emqtt
Empty twitter for EMQ Technologies: https://twitter.com/emqtt
Empty twitter for StackStorm: https://twitter.com/Stack_Storm
Item Mavenir (member) has no image_data

Deploy Preview for landscape failed.
Built with commit 134a414463205da3838c34ca2f9144db48909349
https://app.netlify.com/sites/landscape/deploys/60a5341fbc1f980007754958

Deploy Preview for landscape ready!
Built with commit 3e71d70d9f7d340b0e25814b71ad115ffcb00a62
https://deploy-preview-2104--landscape.netlify.app

LGTM

My bad...I thought that's what I did. I'll take a look.
On Wed, May 19, 2021 at 2:00 PM Chris Aniszczyk @.***>
wrote:
I'd rather replace the existing mavenir logo with this new versus adding a new
one in the hosted_logos directory
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

Build failed because of:
We do not support urls for images anymore. Please download the image and put it into the hosted_logos folder, then put its name to the logo field
Empty twitter for EMQ Technologies (member): https://twitter.com/emqtt
Empty twitter for EMQ Technologies: https://twitter.com/emqtt
Empty twitter for Rancher Federal (member): https://twitter.com/rancherfederal
No cached entry, and Sosivio (member) has issues with twitter: https://twitter.com/SosivioLtd, 404 - {"errors":[{"code":34,"message":"Sorry, that page does not exist."}]}
Empty twitter for StackStorm: https://twitter.com/Stack_Storm
Item LIMA has no image_data

LGTM

This isn't what I asked for, literally replace mavenir.svg wtih t he new logo, there's a bunch of other changes here that aren't necessary, I'd close this PR and start again.


Support APIv9

https://github.com/discord/discord-api-docs/pull/2855

Wow, this is a large set of changes. Initial list of changes:

[ ] Set default API version to 9.
[ ] Create a new channel type, ThreadChannel which extends MessageChannel. TODO: Are there guild and non-guild threads? That will affect the implementation a lot.

[ ] Add message_count, member_count, and member. These are currently only used for threads, but are exposed on the top-level channel object for potential future use.
[ ] Add thread_metadata for threads. Should have helpers to expose the higher-level objects.
[ ] Channel types 10 NEWS_THREAD, 11 PUBLIC_THREAD, and 12 PRIVATE_THREAD.
[ ] Track active threads from GUILD_CREATE in a new active thread cache.
[ ] Cache ThreadMembers separately from ThreadChannels?

[ ] Sane limit checking.
[ ] Update the Message object with new thread-related fields.

[ ] Hydrate a Thread(ThreadChannel?) object where possible.
[ ] Add message types 18 THREAD_CREATED and 21 THREAD_STARTER_MESSAGE.
[ ] Add message flag 1 << 5 HAS_THREAD.

[ ] Update intents with thread-related events.

[ ] GUILDS: THREAD_CREATE, THREAD_UPDATE, THREAD_DELETE, THREAD_LIST_SYNC, THREAD_MEMBER_UPDATE, THREAD_MEMBERS_UPDATE.
[ ] GUILD_MEMBERS: THREAD_MEMBERS_UPDATE.
[ ] Document different information sent in THREAD_MEMBERS_UPDATE depending on intents.
[ ] Verify whether threads work in DMs...

[ ] Add new JSON error codes:

[ ] 50083
[ ] 50084
[ ] 50085

Threads are confirmed guild-only and aren't expected to be available in DMs without another major API version bump, see https://canary.discord.com/channels/613425648685547541/837051880982577223/837913346568749087

https://github.com/discord/discord-api-docs/pull/2875

Wow, you're fast

I try.

not bad queer <3


[WIP] Profile page added.

Description

Fixes #41 (Add a profile page in the app and show relevant details.)

New Screenshots

Old Screenshots

@ragesoss @bwreid design for profile page is ready.

Next things to do in this PR:

Link Profile Fragment with the users in the course. (Add a back button in that case, minor UI changes).
Add scrollview in profile page.


Avoid raising and re-queueing when the remote resource is not found

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1599754

I'm good with this, @carbonin was your comment addressed?


kutty-bootstrap: Alert

Alerts should implement this Bootstrap component: https://getbootstrap.com/docs/4.6/components/alerts/
Alert components need some JavaScript to be added to be closeable. That should be the default.
Alerts can be of different kinds. How do we let the developer write which of these kinds to use?
One way is to use a keyword argument:
element1 = Alert("Task completed!", kind="success")
element2 = Alert("Something went wrong", kind="danger")  # should it be called error instead?

The other would be to have separate constructors for each:
element1 = SuccessAlert("Task Completed!")
element2 = DangerAlert("Something went wrong.")

Whatever naming or format we choose here, we should replicate it later for other elements such as button, card, etc.

How are you going to support .alert-link , .alert-heading and the close button?

alert-link: How about adding that class for all Link instances in self.children and in their children? Raw HTML won't change.
alert-heading:  How about a keyword argument that takes a heading?
close button: That should be the default. I think a keyword flag like closeable should be good enough to customize it.

Zee
On Wed, Jan 4, 2023, 11:36 AM Kaustubh Maske Patil @.***>
wrote:

alert-link: How about adding that class for all Link instances in
self.children and in their children? Raw HTML won't change.
alert-heading: How about a keyword argument that takes a heading?
close button: That should be the default. I think a keyword flag
like closeable should be good enough to customize it.

—
Reply to this email directly, view it on GitHub
https://github.com/pipalacademy/kutty/issues/11#issuecomment-1370521112,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAB3EMXR4SQPHWXU2NFFJLWQUHNXANCNFSM6AAAAAATPWKPXA
.
You are receiving this because you commented.Message ID:
@.***>

I think it might be better to structure this too in a similar fashion to cards and other Kutty elements where we can add children to the parent element when it comes to data.
The presentation should be defined early and doesn't need to be changed later, but the main data should have the ability to be changed.
How about this instead?
from kutty import Link, html
from kutty.bootstrap import Alert

alert = Alert(title="Well done!", closeable=False)
alert.add(
    html.p(
      "You have successfully completed",
      Link("the challenge.", "/challenge-page")
    )
)

alert.add will look at the element and its children, if there are any of type Link, it will add the alert-link class to them.

Merged in https://github.com/pipalacademy/kutty/commit/6f21a3b50a0e3b04dc78554aa6e199ed6b47b54b


Unable to Retrieve Call SID When Begin Calling

Hi ,
i am using the file tcplugin.js in my ionic app
i dont seem to recieve call sid
any help
Thanks

Hi,
I'm not exactly sure what you are asking - are you making a successful connection, and then you want to retrieve the call SID from an active connection?
Thanks,
Jeff


Improve contribution process

What
Need to improve the contribution process.
Why
Right now it's not clear how to start developing the library, which commands to use, where to test code, etc.
How

Think about the process.
Change the build pipeline
Update the "CONTRIBUTION" document

[x] Updated the references to CONTRIBUTING.md to be recognizable by GitHub
[x] Provided an ISSUE_TEMPLATE.md for new issues

[x] Added a pre-commit hook which will build and test the library before creating a new commit

#188:

Covers the main points of the contribution
Introduces updated CONTRIBTING guidelines
Introduces the changes to the build pipeline

Contributing process should be much more clear and easy now. Closing.


added period to ThrottleSettings

Hello,
We needed to use a different period than 1 second.
I added the possibility to set this period in ThrottleSettings. The default value is 1 second.
Regards

Thanks! It looks like the travis CI failure has to do with me running an HLint pass as a test-suite. I'm planning on removing this.
You're patch looks great, I'll merge and  upload a new version to hackage ASAP.

@ereteog Released: http://hackage.haskell.org/package/wai-middleware-throttle-<IP_ADDRESS>

Thank you!


Add support for Cookie authorization

Right now gouqi support basic and bearer authentication methods, but Jira actually also supports Cookie-based authentication.

Our organization sadly only allows cookie-based auth. even in an automated context... Would you be willing to accept a PR that adds support for this? I could tackle this fairly quickly if you agree that this would be a nice addition.

Yes, would be more than happy adding also cookies as authentication method


Port 1.8.6 to release-1.8

@howardjohn: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio_release-1.8
f79f21ab97f758733e1d758efe4176a9b5a74bfe
link
/test lint_istio_release-1.8

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio_release-1.8
f79f21ab97f758733e1d758efe4176a9b5a74bfe
link
/test lint_istio_release-1.8

unit-tests_istio_release-1.8
f79f21ab97f758733e1d758efe4176a9b5a74bfe
link
/test unit-tests_istio_release-1.8

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio_release-1.8
f79f21ab97f758733e1d758efe4176a9b5a74bfe
link
/test lint_istio_release-1.8

unit-tests_istio_release-1.8
f79f21ab97f758733e1d758efe4176a9b5a74bfe
link
/test unit-tests_istio_release-1.8

integ-pilot-k8s-tests_istio_release-1.8
f79f21ab97f758733e1d758efe4176a9b5a74bfe
link
/test integ-pilot-k8s-tests_istio_release-1.8

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio_release-1.8
f79f21ab97f758733e1d758efe4176a9b5a74bfe
link
/test unit-tests_istio_release-1.8

integ-pilot-k8s-tests_istio_release-1.8
f79f21ab97f758733e1d758efe4176a9b5a74bfe
link
/test integ-pilot-k8s-tests_istio_release-1.8

lint_istio_release-1.8
761a284bc2d2f257a4abd1fa7df5883e4f84791c
link
/test lint_istio_release-1.8

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio_release-1.8
761a284bc2d2f257a4abd1fa7df5883e4f84791c
link
/test lint_istio_release-1.8

integ-pilot-k8s-tests_istio_release-1.8
761a284bc2d2f257a4abd1fa7df5883e4f84791c
link
/test integ-pilot-k8s-tests_istio_release-1.8

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio_release-1.8
761a284bc2d2f257a4abd1fa7df5883e4f84791c
link
/test integ-pilot-k8s-tests_istio_release-1.8

unit-tests_istio_release-1.8
725bfaff7e7c311c170589d618baa917bb9fda8c
link
/test unit-tests_istio_release-1.8

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@howardjohn: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio_release-1.8
725bfaff7e7c311c170589d618baa917bb9fda8c
link
/test unit-tests_istio_release-1.8

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest


Request for support for Llama 2

GGML version from TheBloke is coming soon: https://huggingface.co/TheBloke/Llama-2-7B-GGML
Thanks!

It is working without any changes. Model architecture might be same as LLaMA 1:
from ctransformers import AutoModelForCausalLM

llm = AutoModelForCausalLM.from_pretrained("TheBloke/Llama-2-7B-GGML", model_type="llama")

print(llm("AI is going to"))

Thanks!


Add git hook for post-rebase

I thought that the post-rewrite hook was taking care of it but that is not the case. No hooks are running after rebasing a branch.
vscode@efe54cb978d4:/workspaces/challenge-registry$ git fetch upstream
remote: Enumerating objects: 1, done.
remote: Counting objects: 100% (1/1), done.
remote: Total 1 (delta 0), reused 0 (delta 0), pack-reused 0
Unpacking objects: 100% (1/1), 581 bytes | 581.00 KiB/s, done.
From https://github.com/Sage-Bionetworks/challenge-registry
   ff081d0..1f3ebb6  main       -> upstream/main
vscode@efe54cb978d4:/workspaces/challenge-registry$ git rebase upstream/main
Successfully rebased and updated refs/heads/main.

Added to Sprint 22.08


Fixing squid: S1604 Anonymous inner classes containing only one method should become lambdas part 3

This pull request is focused on resolving occurrences of Sonar rule
squid:S1604 - “Anonymous inner classes containing only one method should become lambdas”.
You can find more information about the issue here:
https://dev.eclipse.org/sonar/rules/show/squid:S1604
Please let me know if you have any questions.
Soso Tughushi

Closing this pull request because we are not currently supporting lambda expression on android.


No option to print stacktrace_frame::to_string() with color

stacktrace_frame::to_string() has no color option. It seems that it and cpptrace::print_frame() (a private function) can be more or less combined.

Good find, thanks!

0.7.3 is released


Add LosslessCut

Project URL
https://github.com/mifi/lossless-cut
Category
audio
video
Description
The swiss army knife of lossless video/audio editing.e
No need to re-encode video or audio and saving disk space.
Why it should be included to Awesome macOS open source applications  (optional)
iMovie will re-encode the video that taking a lot of disks space and time.
Sometimes we only need some simple features like cutting or merge video files.
LosslessCut is an excellent option to achieve that.
Checklist

[X] Edit applications.json instead of README.md.
[X] Only one project/change is in this pull request
[X] Screenshots(s) added if any
[X] Has a commit from less than 2 years ago
[X] Has a clear README in English

@RicoToothless Thank you! 👍


Strange tensor flow error due to an argument

Hello,
First of all, thank you for your effort with the open-source TTS projects.
As summary, I'm trying to create a TTS of Spanish language using your open-source dc_tts.
To do that, I want to train in my laptop the net that you uploaded as "pre-trained net" in order to know if I will be able to train my own network for spanish (once I have the spanish database correctly), but I get an error of tensorflow due to an argument. I have all the libraries correctly installed and the LJ database downloaded.
The only thing that I did was to download the repository, fix correctly the database paths (LJ) and run the train script with parameter "1".
C:\tf_jenkins\home\workspace\rel-win\M\windows\PY\36\tensorflow\core\framework\op_kernel.cc:1192] Invalid argument: TypeError: a bytes-like object is required, not 'str'
Thank you!

Hello, I'm encountering the same issue !
I'm on Windows 7 working with conda.
The synthetize script worked like a charm on the first try, but I'm still struggling with the same error as @alvaroromerosc .

A quick update,
I can't get tensorflow working on windows with python 27, @Kyubyong, could you point me in the right direction to update your code so it would be compatible with python 3.6 ?
Thanks a lot !

Hello,
I had the same issue with linux in python 3.
In my case, it comes from data_load.py (https://github.com/Kyubyong/dc_tts/blob/master/data_load.py)
Following your link that explain the issue, I searched how to convert bytes to string in python 3:
https://stackoverflow.com/questions/606191/convert-bytes-to-a-string
I replaced:
mel = "mels/{}".format(fname.replace("wav", "npy"))
mag = "mags/{}".format(fname.replace("wav", "npy"))
by
mel = "mels/{}".format(fname.decode("utf-8").replace("wav", "npy"))
mag = "mags/{}".format(fname.decode("utf-8").replace("wav", "npy"))
And it seems to work.
(Maybe it would be better to use try: ... except TypeError: ...)


Kaggle nuclei seg

polus-cell-nuclei-segmentation-plugin is now renamed and updated to new plugin standards
modified yaml file for pre-commits to exclude checking of files of sizes bigger than 500KB

I will open to Najib's branch


[Feature] Support for Alerts

Having the ability to add and maintain alerts

https://www.elastic.co/guide/en/kibana/master/alerting-apis.html
Create/Update/Delete

+1, would be really helpful

+2, would be great!

+3, would be very helpful!

+4, this would be amazing for us

+5 we really need this.

+6 please support

+1 please add support

+1 support for this would be a great help!

+1 PLEASE. Our support team really needs this!

+1, This would be a big help for us, would appreciate any updates

+1 great help for us

+1 would greatly appreciate support for this

+1 could really use this feature for our workflow.

Would be great to use tools we already utilize to create our alerts!

+1 this would be great for our team

+1 this would really help reduce the load on our engineering support team.

+1 would greatly appreciate support for this

+1 please support really need this!

@Kushmaro / @olksdr - I started taking a look at building this out the other day due to the level of demand from different people, but I couldn't seem to find an elastic supported go client for the Kibana API... I can see the elasticsearch one that is currently being used (https://github.com/elastic/go-elasticsearch). Please can you advise on the plan for delivering any of the Kibana based functionality via terraform? Is the plan to create a new repo for this client as is in place for elasticsearch, or are you looking to bake this into this repo somehow? If a new repo is being built for this, is this something we are able to contribute to in order to help speed up the delivery of the kibana functionality in this one?
Also, I'm assuming any Kibana based functionality will be blocked until this client can be built?
P.S. Still new to the Go / TF provider building world so please correct me if my understanding on any of the above is incorrect!

+1 would greatly appreciate support for this! Any ETA on the release of this feature to plan the engineering work accordingly?

+1 would greatly appreciate support for this! Any ETA on the release of this feature to plan the engineering work accordingly?

@aydasraf It's currently planned to release by the end of Jan mate, we'll be submitting an API to https://github.com/disaster37/go-kibana-rest followed by TF support here. I'm happy to give you a ping when it's released.

+1 would greatly appreciate support for this! Any ETA on the release of this feature to plan the engineering work accordingly?

@aydasraf It's currently planned to release by the end of Jan mate, we'll be submitting an API to https://github.com/disaster37/go-kibana-rest followed by TF support here. I'm happy to give you a ping when it's released.

@webfella Thank you mate for the update! Just at the right time for us. I am watching the releases, but would also appreciate the ping. Wish you, a merry Christmas and a wonderful and happy new year.

Thanks for the merge!
As support for alerts has just added, when do we expect the release of 0.6.0?

Sorry for pinging @tobio — and thank you for adding support for alerting— but following @benjyabr's question, when do you plan to release the new version including #292?

We're also looking to add support for managing alert connectors in a 0.6 release. I'd expect sometime in April.

Hi, any update on the release of 0.6.0 please?

Hi @RobDTech , 0.6.0 was released today


In safari,  in donations,  entering number of items allows a number with comma, but then silently saves without saving the item

Summary
In safari or firefox,   you can put a number with a comma (e.g. 200,640) in the number of items field.  If you then save, the corresponding item is not saved .  No error is given to the user.   This behaviour has been verified on donations, but is probably happening in other places.
Why
Bank confusion and frustration -- It'd be pretty easy to miss an item on a large donation / distribution/ purchase of many items
Details
Recreation
Using browser safari
Donations | New Donation
Misc donation will do -- choose an item and put in 200,640 for the number of items
Save
The donation will be saved without the item.
Other places to check

Distributions
Purchases
Partner requests
Inventory adjustments

NB
This needs to be solved in a way such that the users do not lose all their other item input  if they have an error on one.
Criteria for completion

[ ] if the create or update receive a number of items with a comma in it, they either a) give an error or b) save the item with the appropriate value (i.e. the number of items with the comma stripped out)
[ ] tests supporting that
[ ] if reasonable to do (i.e. you have safari), manually test
[ ] investigate purchases, distributions, and partner requests - check whether they have the same issue, and correct if they do. (This item was previously in the Bonus Round, but we do actually need it to be taken care of.)

Hey, I'd like to work on this issue :)

I have a simple solution, but it implies changing the number input for the quantity to a text input. So it removes the little up and down arrows that were there before. Would that be acceptable?

Yes, I think that's fine. Number inputs are kind of dumb in general :)

Hey, some real life issues have come up and i wont be able to finish this issue until next week :( i hope that's ok, feel free to reassign if needed

No rush! You can keep it.

@dorner Ok so the code I added fixes the problem, but it breaks barcode tests.
I've identified the issue I think, the "fill_fields_with_barcode_items" function of the barcode_item.js file is excepting to have number inputs, so fails. I haven't been able to debug this, do you think you could help?

Unfortunately I don't have a barcode scanner to test this (@scooter-dangle ?) but I'm pretty sure it's in barcode_items.js - it has several places where it's looking for input[type=number] which I thought should be changed to input.quantity so it can find the field correctly - but it still doesn't seem to be working. Spent some time trying to debug console logs but couldn't get it working properly. Anyhoo - that's where I'd spend some time poking around.

Hey @dorner , yeah i reached the same conclusions, ok will try to debug. thanks for the help!

Could I give this a go? Distributions exports didn't work out and this seems like a more manageable issue to fix

Go for it!

I'd like to attempt this if no one else is currently working on it.
Looks like the previous attempt was to remove the numeric input type but that affected a test that may have been difficult to fix.
What's happening is that when input type is numeric, Chrome doesn't allow user to enter anything non-numeric, so the problem never arises. However, Safari does allow entering non-numeric characters, but when the form is submitted, it submits a blank value.
I have an idea that could keep the input type as numeric, and use a Stimulus controller to validate that it is indeed numeric, and if not "do something" (I still have to figure out that part).
I've been experimenting:
// app/javascript/controllers/numeric_input_controller.js
import { Controller } from "@hotwired/stimulus";

export default class extends Controller {
  validate(event) {
    const value = event.target.value;

    // FIXME: value is an empty string, doesn't work with this check
    // Maybe just check for empty string, also need to see how Firefox handles this
    if (isNaN(value)) {
      event.preventDefault();
      // Or if this is too ugly, maybe use Bootstrap styles to make the input in an error state?
      // Somehow prevent form submission?
      alert("Please enter a valid number.");
    }
  }
}

And use it in line item fields template app/views/line_items/_line_item_fields.html.erb
<div data-controller="numeric-input" class="li-quantity mx-2">
   <%= field.input :quantity, placeholder: "Quantity", label: false, input_html: { data: { action: "numeric-input#validate" }, class: "quantity my-0"} %>
</div>

Please do give it a go!

I was able to get a client side solution (with a new Stimulus controller) displaying an alert that the input is invalid. But it still let's the user submit the form. It might be possible to also disable the submit button with the client side controller, although then need to also check for the valid case and re-enable it.
But before going further with client side solution, I had a thought as to why isn't this failing with server side validation? It seems like that would be the more "rails way" solution rather than intervening with client side JavaScript. Here's what I found:
Looking at the LineItem model, it has validation that enforces that quantity must be numeric:
validates :quantity, numericality: { only_integer: true, less_than: MAX_INT, greater_than: MIN_INT }

So if the Donation form is submitting an empty string for the line item quantity (as it does when using Safari and user has entered a non-numeric character into the quantity field), I would have expected the save to fail on the server, and display an error message in the UI.
But what actually happens is that it goes ahead and saves the Donation without any line items at all, that is to say, it makes no attempt to insert new line items, and that's why the LineItem model validation never kicks in.
So my next question was, why does it not attempt to save line items?
The answer is in the Itemizable concern that is included in the Donation model, specifically this line:
accepts_nested_attributes_for :line_items,
                                  allow_destroy: true,
                                  reject_if: proc { |l| l[:item_id].blank? || l[:quantity].blank? }

So if the form contains a blank quantity, then it won't attempt to associate any of the line item attributes with the donation, and the code goes ahead and saves the donation without any line items. That's why the LineItem model validation rules never run for this case.
Is this the intended behaviour that a Donation can be saved with no line_items?

Follow-on to my previous comment:
Solely for the experiment, I tried modifying the accepts_nested_attributes_for in the Itemizable concern to remove the reject_if proc:
# experiment for Issue #3373, allow blank quantity, what happens in UI?
    accepts_nested_attributes_for :line_items,
                                  allow_destroy: true
    # reject_if: proc { |l| l[:item_id].blank? || l[:quantity].blank? }
    # accepts_nested_attributes_for :line_items,
    #                               allow_destroy: true,
    #                               reject_if: proc { |l| l[:item_id].blank? || l[:quantity].blank? }

Then in Safari, I attempted to create a new donation with a Quantity like 1,2 (which Safari allows the user to enter, but submits a blank value).
In this case, it gets rejected server side and displays an error message in the UI like this:

One strange thing it does though is to add another LineItem in the form, which the user has to Remove if they didn't want a second line item.
So this could solve the issue, while keeping the input field a numeric type, and without requiring any client side JS.
But, the Itemizable concern is shared across many models so this could affect other areas of the system.

"Is this the intended behaviour that a Donation can be saved with no line_items?"
Yes, as there could be a purely monetary donation recorded in the system.
Aside:  I don't think you should be able to save any of the other Itemizables with no line_items, though.

re: "I don't think you should be able to save any of the other Itemizables with no line_items"
Although the issue mentions this is for Safari, there may actually be a system wide issue in that many models allow saving without Line Items, even if a Line Item name has been added. In this case, if the quantity is missing (because user forgot to enter it or they're using Safari and entered thousands separator), then the system ignores the line item.
To explore further the idea of LineItems being required or not, I ran all the tests with my experimental change to Itemizable concern. Got a number of failures including in Distribution and Purchase system tests.
For example, the distribution test currently expects that you can fill out the form without any line items and that it will be valid:
      it "Allows a distribution to be created and shipping cost field not visible" do
        visit @url_prefix + "/distributions/new"

        select @partner.name, from: "Partner"
        select @storage_location.name, from: "From storage location"
        choose "Pick up"

        fill_in "Comment", with: "Take my wipes... please"
        fill_in "Distribution date", with: '01/01/2001 10:15:00 AM'

        # shipping cost field should not be visible
        expect { page.find_by_id("shipping_cost_div", wait: 2) }.to raise_error(Capybara::ElementNotFound)

        expect(PartnerMailerJob).to receive(:perform_later).once
        click_button "Save", match: :first

        expect(page).to have_content "Distributions"
        expect(page.find(".alert-info")).to have_content "created"
      end

However, it seems that a LineItem does get populated in the form, although without a quantity, and then the test fails with my change because that now triggers LineItem validation. Test screenshot (I updated the quantity error message to indicate that it must be an integer without thousands separator):

So if the direction of this fix goes to server side validation, it might be useful to review the models that include the Itemizable concern, and determine whether is valid  to create any of these without line items. There are 8 models:
app/models/adjustment.rb:
  21:   include Itemizable

app/models/audit.rb:
  22:   include Itemizable

app/models/distribution.rb:
  32:   include Itemizable

app/models/donation.rb:
  36:   include Itemizable

app/models/kit_allocation.rb:
  15:   include Itemizable

app/models/kit.rb:
  16:   include Itemizable

app/models/purchase.rb:
  29:   include Itemizable

app/models/transfer.rb:
  20:   include Itemizable

I also tried another approach in an attempt to be more flexible:
If the user has not entered a line item name and not entered a quantity, it means they don't want line items here so don't associate/validate/save. But if they enter a line item name without a quantity (or vice versa), then they did intend to add a line item, in which case, the quantity should be validated:
# Itemizable concern
    # Changed the OR `||` to `&&`
    # Experiment for issue #3373: If BOTH item_id and quantity are blank,
    # then don't bother associating line items with this model because the
    # user didn't want to add any items.
    # However, if either item_id or quantity is present, then we should
    # associate line items with this model (and thus do validation on it).
    accepts_nested_attributes_for :line_items,
                                  allow_destroy: true,
                                  reject_if: proc { |l| l[:item_id].blank? && l[:quantity].blank? }
                                  # reject_if: proc { |l| l[:item_id].blank? || l[:quantity].blank? }

However, several system tests fail because the current system allows for item name entry with no quantity, and simply ignores these lines.

FWIW, I suspect the same issue with the commas is happening in safari for any itemizable -- we just heard about it in donations.
The extra empty item is odd, certainly, and could potentially cause confusion.  It won't prevent folks from saving the donation, though.

Ah - I meant that from a business pov, I don't see why you would ever save a distribution or a purchase without line items.

Aaand - I see that you can, indeed, enter a purchase with no line items.    I'll write that up as a separate issue.

Here's my take:

Revert the numeric input back to a regular text input. If it doesn't do what we want across the board, there's no need to have it in there.
I think if an itemizable has a name but no quantity, that should always be rejected as an error.
If an itemizable has no name and no quantity, it can be safely ignored / thrown out.
We should have a separate validation that everything but donation has at least one line item.

Up to you how to split those fixes up (same PR or multiple) but IMO that's how it should work.

Luckily, Itemizables with no name and quantity are thrown out already.
We may run into a bit of an issue on distributions with your suggestion, as we, for reasons I don't know, are using a slightly different drop-down there, which doesn't have the blank.  So if they add an item, they'll have to remove it -- it won't just get removed.  Possible support increase.
(slightly puzzled look) we need to do numerical operations on those values... so why would we not do numeric input?

Maybe part of this would be putting distributions on the same drop-down then. :)
I'd advocating changing the field back mainly because it's giving us false confidence. I'm also not the biggest fan of the number type since it comes with those up/down arrows, which are almost definitely not helpful for people filling out the form. (It's really only useful for very small numbers IMO.)

Re changing the distribution drop down -- maybe?  I'd like to poke around to see if there is a legit reason that it was made different?  (If I understand the history of the system correctly, donations were done first, and the other itemizables were modeled on them, so if there's a difference, there might be a reason?)

To keep the scope of this PR small, it could focus only on fixing the issue for Donations, and keep the input field as numeric for now (because that partial is shared for many model updates):

If user does not enter any line item info at all (i.e. no selection from dropdown AND no quantity) -> save donation with no line item(s)
If user selects item from dropdown and leaves quantity blank -> validation error
If user selects item from dropdown and enters an invalid quantity (eg: 1,000 which Safari allows) -> validation error (from the server perspective, this is the same as user leaving quantity blank)
If user selects item from dropdown and a valid quantity  -> save donation with line item(s)

I think this can be done with changes to the Donation model, without touching Itemizable concern.
Otherwise if changing Itemizable concern and/or the input field type in app/views/line_items/_line_item_fields.html.erb, this is going to affect multiple models, possibly both create and edit scenarios, and could end up as a pretty large PR with ever increasing "what about this case?".
Then there could be a separate issue/PR dealing with all the other models, to have them implement the rules from this comment, including changing the input field type.

I, too, felt this was getting a bit out of hand.  I would prefer to keep it as close to the scope of the original issue as possible.
What I am hearing is that there isn't an easy way to just fix the comma issue without any side effects unless we go to the text field, though.
If someone has selected an item and not entered a quantity, it is likely a mistake in this case.  (I expect it is a mistake across the itemizables, but I want to investigate the distribution difference.)  So, yeah.   This sounds reasonable to me.

I believe it can be fixed while keeping the input numeric for now. This commit does that, I added a long-ish commit message to try and explain whats going on.
I maintained/added system tests, but might like to do a little more testing as well.

Well, D's not available on Saturdays, so you have time g.     He might just be right about changing it to a text field being the right answer, though!

Changing the quantity to input type text can be done using simple_form's as: to override the default:

Then the behaviour is consistent across Chrome and Safari. If user enters numeric value, it gets saved as numeric in line_items.quantity. But if they enter non numeric such as thousands separator, they'll get error like this (optionally the error message could be made friendlier to indicate not to include thousands separator if that's a common error):

However, as an earlier contributor observed, this makes several barcode system tests fail. I can investigate further.

Question about barcode reader behaviour:
Is the idea that after a user scans in a barcode (and ideally it encodes a final newline, which triggers a JS stimulus controller that does a lookup via xhr): Then it should pre-populate BOTH the item and quantity fields as per the matching entry in barcode_items table?

I think I know why the barcode system tests fail with the change to make Quantity field text instead of numeric. It's not just the tests, it's broken when running the app as well.
The way it seems to work is after a barcode value is scanned in (which you can also enter in manually and press Enter), the barcode_items.js Stimulus controller takes the barcode value, and submits an xhr to lookup the item, for example:
GET "/diaper_bank/barcode_items/find.json?barcode_item[value]=10037867880046

This example value I got from barcode_items table - and it has a quantity of 108:
diaper_dev=> select * from barcode_items where value = '10037867880046';
 id |     value      | barcodeable_id | quantity |         created_at         |         updated_at         | organization_id | barcodeable_type
----+----------------+----------------+----------+----------------------------+----------------------------+-----------------+------------------
  1 |<PHONE_NUMBER>0046 |             16 |      108 | 2024-04-03 19:03:13.346189 | 2024-04-03 19:03:13.346189 |               1 | Item

When the response is received, the Stimulus controller runs a function fill_fields_with_barcode_results. For the quantity, it attempts to find the field by input type. There are 3 occurrences of this logic:
let current_total = parseInt($(line_item).find('input[type=number]').val());
line_item_quantity = Number(line_item_quantity) + Number($(line_item).find('input[type=number]').val());
$(line_item).find('input[type=number]').val(line_item_quantity);

So when changing the quantity input to a text input, the selectors above won't find anything, and then the Quantity field will not be filled in. Then if the tests try to verify Quantity field it will fail.
Furthermore, if the user tries to save the donation, they'll now get a validation error that Quantity must be provided.
Solution
I think this could be solved by using a data-...-target attribute to identify the quantity field, rather than having the code depend on its input type. As per the Stimulus reference docs on targets
But, there could be some trickiness in that there could be multiple of these fields, so need to make sure the correct one is being updated.
I can look into this.
If on the other hand, the PR should be kept small, the input type change, and corresponding barcode_items.js changes could  be handled in a separate issue. Which would leave this ticket with only the new validation.

1/  Hmm...  this is mostly an aside, bet we have an ungroomed proto-issue "when scanning a recognized barcode, the item name doesn't always show up in the gui, but it saves correctly as the associated item"  I'm wondering if it's related.
2/  On the one hand, we like keeping PRs small, but on the other hand, if I understand correctly, the best fix will break a bunch of other tests.   Does it make sense, to you,  to keep them separate, but do the other work first?

Just to clarify about changing the Quantity input type from numeric to text: It's not just that it breaks tests, it breaks existing app functionality (in that the Quantity field will not be updated from barcode input), and the system tests are failing because of that. This would impact any users that rely on barcode input in that they would have to manually fill in the Quantity field.
A suggestion on how to split this:
1. Leave the Quantity field as numeric, and ensure that Item validation runs for Donation
When either an Item name and/or quantity is entered for a Donation, ensure Item validation runs.
This fixes it for Safari users so that if they enter a Quantity such as 1,000, they'll get an error rather than the Donation being saved without the Item. It also fixes an existing system bug for all users (regardless of browser) that if they select an Item and forget to enter a Quantity, their item is ignored and donation saved without the item, even though the user intended to add this item.
A downside is that for Safari users, when the view renders with the validation error, the value they entered, eg: 1,000 will be cleared out (because Safari submitted a blank string for Quantity, which is the same as a user who forgot to enter a Quantity.
This could go first as it resolves the immediate issue, albeit with not the best UX for Safari users. This commit on my branch has the fix and I could prepare a PR.
2. Separate issue for making Quantity field text
As a separate issue, make the Quantity field text rather than numeric.
This will also require fixing the barcode_items.js controller to not depend in the field input type. When this is fixed, it should also get the barcode system tests passing.
The benefit here is for Safari users (actually all browsers), should they enter an invalid Quantity, it will be preserved when the view re-renders with the validation error.
3. Enforce Item rules for all other Itemizable models
Go over all the other models that include the Itemizable concern and implement the rules mentioned in this earlier comment.
This will also require maintaining several system tests that currently submit model save with an Item selected but no quantity, and expect it to be successful.
4. Item name doesn't show up when barcode scanning, but saved
Not sure if related, could be a different issue in barcode_items.js. Can it be reproduced with local seed data or does this only happen intermittently in production?

IMO fixing the numeric field is more important based on these comments since things are searching for it by input type, which is not a great idea. I'd like to see this fixed first, then we can address the validation problems. I'd probably prefer addressing them all at once via Itemizable rather than treating donation as a special case, which it shouldn't be.

Sounds good, thanks for clarification. I'll work on making the quantity field text, and fixing barcode_items.js to no longer search for a numeric field. I'm thinking of using a data- attribute to identify the quantity field.
btw - earlier I had assumed all the barcode JS is implemented as Stimulus controllers but it turns out its jQuery code that runs on document ready. VSCode is reporting that this is deprecated. Perhaps a future follow-on ticket to convert to Stimulus controller and use the initialize() lifecycle callback?

We discussed switching the jquery loader on our call today, sounds like it'd be fine to do as part of this :)


FoundationEssentials: repair the TimeZone implementation on Windows

Update the Windows path for String.range(of:) being altered to String._range(of:anchored:backwards:). This repairs the build of FoundationEssentials on Windows.

@swift-ci please test


How to Cross compile android kernel?

I am trying to build Android Bullhead kernel following this guide Setup: Linux host, QEMU vm, arm64 kernel
With the following commands
git clone https://android.googlesource.com/kernel/msm
cd msm
git pull origin android-msm-bullhead-3.10-nougat-mr1.1
export ARCH=arm64
export CROSS_COMPILE=aarch64-linux-gnu-
make bullhead_defconfig
ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- make -j72

But then I got the following error:
scripts/kconfig/conf --silentoldconfig Kconfig
warning: (PCI_MSM && AMD_IOMMU) selects PCI_MSI which has unmet direct dependencies (PCI && ARCH_SUPPORTS_MSI)
warning: (SND_SOC_APQ8074 && SND_SOC_MSM8994) selects SND_SOC_MSM_HDMI_CODEC_RX which has unmet direct dependencies (SOUND && !M68K && !UML && SND && SND_SOC && FB_MSM_MDSS_HDMI_PANEL && (SND_SOC_MSM8974 || SND_SOC_APQ8084 || SND_SOC_MSM8994))
warning: (ARCH_MSM) selects DEVFREQ_GOV_MSM_BW_HWMON which has unmet direct dependencies (PM_DEVFREQ && (ARCH_MSM_KRAIT || ARCH_MSM_BIMC_BWMON))
warning: (PCI_MSM && AMD_IOMMU) selects PCI_MSI which has unmet direct dependencies (PCI && ARCH_SUPPORTS_MSI)
warning: (SND_SOC_APQ8074 && SND_SOC_MSM8994) selects SND_SOC_MSM_HDMI_CODEC_RX which has unmet direct dependencies (SOUND && !M68K && !UML && SND && SND_SOC && FB_MSM_MDSS_HDMI_PANEL && (SND_SOC_MSM8974 || SND_SOC_APQ8084 || SND_SOC_MSM8994))
warning: (ARCH_MSM) selects DEVFREQ_GOV_MSM_BW_HWMON which has unmet direct dependencies (PM_DEVFREQ && (ARCH_MSM_KRAIT || ARCH_MSM_BIMC_BWMON))
  CHK     include/generated/uapi/linux/version.h
  HOSTCC  scripts/kallsyms
  HOSTCC  scripts/sortextable
  HOSTCC  scripts/asn1_compiler
  HOSTCC  scripts/dtc/checks.o
  HOSTCC  scripts/dtc/data.o
  HOSTCC  scripts/dtc/dtc.o
  SHIPPED scripts/dtc/dtc-parser.tab.c
  SHIPPED scripts/dtc/dtc-lexer.lex.c
  SHIPPED scripts/dtc/dtc-parser.tab.h
  HOSTCC  scripts/dtc/flattree.o
  HOSTCC  scripts/dtc/livetree.o
  HOSTCC  scripts/dtc/srcpos.o
  HOSTCC  scripts/dtc/treesource.o
  HOSTCC  scripts/dtc/util.o
  HOSTCC  scripts/mod/mk_elfconfig
  CC      scripts/mod/devicetable-offsets.s
  CC      scripts/mod/empty.o
  HOSTCC  scripts/selinux/mdp/mdp
  HOSTCC  scripts/dtc/fstree.o
  HOSTCC  scripts/selinux/genheaders/genheaders
  HOSTCC  scripts/dtc/dtc-lexer.lex.o
  HOSTCC  scripts/dtc/dtc-parser.tab.o
scripts/asn1_compiler.c: In function ‘render_out_of_line_list’:
scripts/asn1_compiler.c:1341:3: warning: enumeration value ‘NOT_COMPOUND’ not handled in switch [-Wswitch]
   switch (e->compound) {
   ^
scripts/asn1_compiler.c:1341:3: warning: enumeration value ‘CHOICE’ not handled in switch [-Wswitch]
scripts/asn1_compiler.c:1341:3: warning: enumeration value ‘ANY’ not handled in switch [-Wswitch]
scripts/asn1_compiler.c:1341:3: warning: enumeration value ‘TYPE_REF’ not handled in switch [-Wswitch]
In file included from include/linux/compiler.h:54:0,
scripts/asn1_compiler.c:1341:3: warning: enumeration value ‘TAG_OVERRIDE’ not handled in switch [-Wswitch]
                 from include/uapi/linux/stddef.h:1,
                 from include/linux/stddef.h:4,
                 from /home/bruce/Android/msm/include/uapi/linux/posix_types.h:4,
                 from include/uapi/linux/types.h:13,
                 from include/linux/types.h:5,
                 from include/linux/mod_devicetable.h:11,
                 from scripts/mod/devicetable-offsets.c:2:
include/linux/compiler-gcc.h:106:30: fatal error: linux/compiler-gcc6.h: No such file or directory
 #include gcc_header(__GNUC__)
                              ^
compilation terminated.
/home/bruce/Android/msm/scripts/mod/Makefile:34: recipe for target 'scripts/mod/devicetable-offsets.s' failed
make[2]: *** [scripts/mod/devicetable-offsets.s] Error 1
make[2]: *** Waiting for unfinished jobs....
scripts/Makefile.build:455: recipe for target 'scripts/mod' failed
make[1]: *** [scripts/mod] Error 2
make[1]: *** Waiting for unfinished jobs....
  CHK     include/generated/utsrelease.h
  UPD     include/generated/utsrelease.h
In file included from scripts/sortextable.c:166:0:
scripts/sortextable.c: In function ‘main’:
scripts/sortextable.h:158:3: warning: ‘relocs_size’ may be used uninitialized in this function [-Wmaybe-uninitialized]
   memset(relocs, 0, relocs_size);
   ^
scripts/sortextable.h:104:6: note: ‘relocs_size’ was declared here
  int relocs_size;
      ^
In file included from scripts/sortextable.c:164:0:
scripts/sortextable.h:158:3: warning: ‘relocs_size’ may be used uninitialized in this function [-Wmaybe-uninitialized]
   memset(relocs, 0, relocs_size);
   ^
scripts/sortextable.h:104:6: note: ‘relocs_size’ was declared here
  int relocs_size;
      ^
  CC      kernel/bounds.s
In file included from include/linux/compiler.h:54:0,
                 from include/uapi/linux/stddef.h:1,
                 from include/linux/stddef.h:4,
                 from /home/bruce/Android/msm/include/uapi/linux/posix_types.h:4,
                 from include/uapi/linux/types.h:13,
                 from include/linux/types.h:5,
                 from include/linux/page-flags.h:8,
                 from kernel/bounds.c:9:
include/linux/compiler-gcc.h:106:30: fatal error: linux/compiler-gcc6.h: No such file or directory
 #include gcc_header(__GNUC__)
                              ^
compilation terminated.
/home/bruce/Android/msm/./Kbuild:35: recipe for target 'kernel/bounds.s' failed
make[1]: *** [kernel/bounds.s] Error 1
Makefile:860: recipe for target 'prepare0' failed
make: *** [prepare0] Error 2
make: *** Waiting for unfinished jobs....
  HOSTLD  scripts/dtc/dtc
Makefile:522: recipe for target 'scripts' failed
make: *** [scripts] Error 2

On Thu, Jun 29, 2017 at 3:34 AM, bruce<EMAIL_ADDRESS>wrote:

I am trying to build Android Bullhead kernel following this guide [https://github.com/google/syzkaller/blob/master/docs/setup_linux-host_qemu-vm_arm64-kernel.md](Setup: Linux host, QEMU vm, arm64 kernel)
With the following commands
git clone https://android.googlesource.com/kernel/msm
cd msm
git pull origin android-msm-bullhead-3.10-nougat-mr1.1
export ARCH=arm64
export CROSS_COMPILE=aarch64-linux-gnu-
make bullhead_defconfig
make -j72
But then I got the following error:
bruce@charm-Super-Server:~/Android/msm$ make clean
bruce@charm-Super-Server:~/Android/msm$ ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- make -j72
HOSTCC  scripts/basic/fixdep
HOSTCC  scripts/kconfig/conf.o
HOSTCC  scripts/kconfig/zconf.tab.o
In file included from scripts/kconfig/zconf.tab.c:2503:0:
scripts/kconfig/menu.c: In function ‘get_symbol_str’:
scripts/kconfig/menu.c:567:18: warning: ‘jump’ may be used uninitialized in this function [-Wmaybe-uninitialized]
jump->offset = r->len - 1;
^
scripts/kconfig/menu.c:528:19: note: ‘jump’ was declared here
struct jump_key *jump;
^
HOSTLD  scripts/kconfig/conf
scripts/kconfig/conf --silentoldconfig Kconfig
.config:4098:warning: override: reassigning to symbol DEBUG_INFO
.config:4099:warning: override: reassigning to symbol CMDLINE
.config:4101:warning: override: reassigning to symbol DEBUG_FS
.config:4102:warning: override: reassigning to symbol NET_9P
.config:4104:warning: override: reassigning to symbol CROSS_COMPILE
warning: (PCI_MSM && AMD_IOMMU) selects PCI_MSI which has unmet direct dependencies (PCI && ARCH_SUPPORTS_MSI)
warning: (SND_SOC_APQ8074 && SND_SOC_MSM8994) selects SND_SOC_MSM_HDMI_CODEC_RX which has unmet direct dependencies (SOUND && !M68K && !UML && SND && SND_SOC && FB_MSM_MDSS_HDMI_PANEL && (SND_SOC_MSM8974 || SND_SOC_APQ8084 || SND_SOC_MSM8994))
warning: (ARCH_MSM) selects DEVFREQ_GOV_MSM_BW_HWMON which has unmet direct dependencies (PM_DEVFREQ && (ARCH_MSM_KRAIT || ARCH_MSM_BIMC_BWMON))
*

Restart config...

Plan 9 Resource Sharing Support (9P2000)

Plan 9 Resource Sharing Support (9P2000) (NET_9P) [Y/n/?] y
Debug information (NET_9P_DEBUG) [N/y/?] (NEW) y
warning: (PCI_MSM && AMD_IOMMU) selects PCI_MSI which has unmet direct dependencies (PCI && ARCH_SUPPORTS_MSI)
warning: (SND_SOC_APQ8074 && SND_SOC_MSM8994) selects SND_SOC_MSM_HDMI_CODEC_RX which has unmet direct dependencies (SOUND && !M68K && !UML && SND && SND_SOC && FB_MSM_MDSS_HDMI_PANEL && (SND_SOC_MSM8974 || SND_SOC_APQ8084 || SND_SOC_MSM8994))
warning: (ARCH_MSM) selects DEVFREQ_GOV_MSM_BW_HWMON which has unmet direct dependencies (PM_DEVFREQ && (ARCH_MSM_KRAIT || ARCH_MSM_BIMC_BWMON))
*

Network File Systems

Network File Systems (NETWORK_FILESYSTEMS) [Y/n/?] y
NFS client support (NFS_FS) [N/y/?] n
NFS server support (NFSD) [N/y/?] n
Ceph distributed file system (CEPH_FS) [N/y/?] n
CIFS support (advanced network filesystem, SMBFS successor) (CIFS) [N/y/?] n
NCP file system support (to mount NetWare volumes) (NCP_FS) [N/y/?] n
Coda file system support (advanced network fs) (CODA_FS) [N/y/?] n
Andrew File System support (AFS) (AFS_FS) [N/y/?] n
Plan 9 Resource Sharing Support (9P2000) (9P_FS) [N/y/?] (NEW) y
9P POSIX Access Control Lists (9P_FS_POSIX_ACL) [N/y/?] (NEW) y
warning: (PCI_MSM && AMD_IOMMU) selects PCI_MSI which has unmet direct dependencies (PCI && ARCH_SUPPORTS_MSI)
warning: (SND_SOC_APQ8074 && SND_SOC_MSM8994) selects SND_SOC_MSM_HDMI_CODEC_RX which has unmet direct dependencies (SOUND && !M68K && !UML && SND && SND_SOC && FB_MSM_MDSS_HDMI_PANEL && (SND_SOC_MSM8974 || SND_SOC_APQ8084 || SND_SOC_MSM8994))
warning: (ARCH_MSM) selects DEVFREQ_GOV_MSM_BW_HWMON which has unmet direct dependencies (PM_DEVFREQ && (ARCH_MSM_KRAIT || ARCH_MSM_BIMC_BWMON))

configuration written to .config

warning: (PCI_MSM && AMD_IOMMU) selects PCI_MSI which has unmet direct dependencies (PCI && ARCH_SUPPORTS_MSI)
warning: (SND_SOC_APQ8074 && SND_SOC_MSM8994) selects SND_SOC_MSM_HDMI_CODEC_RX which has unmet direct dependencies (SOUND && !M68K && !UML && SND && SND_SOC && FB_MSM_MDSS_HDMI_PANEL && (SND_SOC_MSM8974 || SND_SOC_APQ8084 || SND_SOC_MSM8994))
warning: (ARCH_MSM) selects DEVFREQ_GOV_MSM_BW_HWMON which has unmet direct dependencies (PM_DEVFREQ && (ARCH_MSM_KRAIT || ARCH_MSM_BIMC_BWMON))
CHK     include/generated/uapi/linux/version.h
HOSTCC  scripts/kallsyms
HOSTCC  scripts/sortextable
HOSTCC  scripts/asn1_compiler
HOSTCC  scripts/dtc/checks.o
HOSTCC  scripts/dtc/data.o
HOSTCC  scripts/dtc/dtc-lexer.lex.o
HOSTCC  scripts/dtc/dtc-parser.tab.o
HOSTCC  scripts/dtc/dtc.o
HOSTCC  scripts/dtc/flattree.o
CC      scripts/mod/empty.o
HOSTCC  scripts/dtc/livetree.o
HOSTCC  scripts/mod/mk_elfconfig
HOSTCC  scripts/dtc/srcpos.o
HOSTCC  scripts/dtc/treesource.o
HOSTCC  scripts/dtc/util.o
CC      scripts/mod/devicetable-offsets.s
HOSTCC  scripts/dtc/fstree.o
HOSTCC  scripts/selinux/genheaders/genheaders
HOSTCC  scripts/selinux/mdp/mdp
scripts/asn1_compiler.c: In function ‘render_out_of_line_list’:
scripts/asn1_compiler.c:1341:3: warning: enumeration value ‘NOT_COMPOUND’ not handled in switch [-Wswitch]
switch (e->compound) {
^
scripts/asn1_compiler.c:1341:3: warning: enumeration value ‘CHOICE’ not handled in switch [-Wswitch]
scripts/asn1_compiler.c:1341:3: warning: enumeration value ‘ANY’ not handled in switch [-Wswitch]
scripts/asn1_compiler.c:1341:3: warning: enumeration value ‘TYPE_REF’ not handled in switch [-Wswitch]
scripts/asn1_compiler.c:1341:3: warning: enumeration value ‘TAG_OVERRIDE’ not handled in switch [-Wswitch]
In file included from include/linux/compiler.h:54:0,
from include/uapi/linux/stddef.h:1,
from include/linux/stddef.h:4,
from /home/bruce/Android/msm/include/uapi/linux/posix_types.h:4,
from include/uapi/linux/types.h:13,
from include/linux/types.h:5,
from include/linux/mod_devicetable.h:11,
from scripts/mod/devicetable-offsets.c:2:
**include/linux/compiler-gcc.h:106:30: fatal error: linux/compiler-gcc6.h: No such file or directory

You need to copy linux/compiler-gcc5.h to linux/compiler-gcc6.h.

#include gcc_header(GNUC)**
^
compilation terminated.
/home/bruce/Android/msm/scripts/mod/Makefile:34: recipe for target 'scripts/mod/devicetable-offsets.s' failed
make[2]: *** [scripts/mod/devicetable-offsets.s] Error 1
make[2]: *** Waiting for unfinished jobs....
scripts/Makefile.build:455: recipe for target 'scripts/mod' failed
make[1]: *** [scripts/mod] Error 2
make[1]: *** Waiting for unfinished jobs....
In file included from scripts/sortextable.c:166:0:
scripts/sortextable.c: In function ‘main’:
scripts/sortextable.h:158:3: warning: ‘relocs_size’ may be used uninitialized in this function [-Wmaybe-uninitialized]
memset(relocs, 0, relocs_size);
^
scripts/sortextable.h:104:6: note: ‘relocs_size’ was declared here
int relocs_size;
^
In file included from scripts/sortextable.c:164:0:
scripts/sortextable.h:158:3: warning: ‘relocs_size’ may be used uninitialized in this function [-Wmaybe-uninitialized]
memset(relocs, 0, relocs_size);
^
scripts/sortextable.h:104:6: note: ‘relocs_size’ was declared here
int relocs_size;
^
HOSTLD  scripts/dtc/dtc
Makefile:522: recipe for target 'scripts' failed
make: *** [scripts] Error 2
make: *** Waiting for unfinished jobs....
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

silly of me :(


Animated banner shapes blocks text selection

Minor accessibility issue, animated shapes block cursor on text. Suggested fix in CSS:
.banner-shape-wrap {
  pointer-events: none;
}

Thanks a lot for reporting this and @believer for providing the PR for the fix


Allow lowering of outer zoom limit in the camera zoom plugin

Closes #6832
Now uses the recently added Range annotation to allow reducing the outer zoom limit by up to 400.
GIF

There was a problem with this. I tested what would happen if someone already had their config set to a value outside the allowed range of [-400,400] e.g. 600 and it causes the config panel to break and show only:

Instead of:

So to fix that I've caught the exception in the JSpinner and forced it into the acceptable range when the exception is thrown. I also had to forcefully update the config when this happens or else the plugin would continue to use the old value until it was updated again manually.
Should be good now.


Implementing action segmentation

dataset extractor is complete. Work on action segmentation can be started

So just wanted some clarification:
Given a video, we need to segment the frames corresponding to the strokes(action) right? And it must be done for both players.
So as you suggested, we need to develop a 3D model, as we have temporal dimension.
Is there anything I'm missing or you have something else in your mind?

@Sharanranjit There's another issue on this. I'm closing this one. I'm currently working on that one, let me know if you want to contribute to it.


Passkey entry paring

Hi, is this support Passkey entry for pairing?
when I tried paring it, it didn't show the numbers.

Hi, is this support Passkey entry for pairing? when I tried paring it, it didn't show the numbers.

hey not yet , am planning to add

+1
Would be super cool


feat: add resolutions rule

:pencil: Description

Adds rule to prevent the use of the resolutions key.

:tada: This PR is included in version 1.3.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


[Youtube] Extract exact timestamps

Checklist

[X] I'm reporting a bug unrelated to a specific site
[X] I've verified that I'm running yt-dlp version 2<IP_ADDRESS>. (update instructions)
[X] I've checked that all provided URLs are alive and playable in a browser
[X] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[X] I've searched the bugtracker for similar issues including closed ones. DO NOT post duplicates
[X] I've read the guidelines for opening an issue

Description
When downloading YouTube videos the timestamps given to the downloaded files are inaccurate. I suppose this can be improved by copying the method used by Youtube DataViewer (https://citizenevidence.amnestyusa.org/).
Can this be impletemented?
Verbose log
-

They are probably using Youtube Data API which gives the uploaded timestamp. But we can only use the innertube API which only gives the uploaded date

OK. Why is it they can use that and we aren't allowed?
Also, would it be possible to extract timestampts from other video sites such as BitChute and Odysee? That would save me a bit of extraneous work doing 'touch -t' on the downloaded videoes.

youtube-dl will not use any kind of APIs involving sharing personal keys due to obvious reasons.
Originally posted by @dstftw in https://github.com/ytdl-org/youtube-dl/issues/376#issuecomment-583290045

If you require accurate timestamps, use the official data API yourself with your own personal API key. As @pukkandan mentioned, it is not possible to get the accurate timestamp from the Innertube API or the website (unless someone manages to find a way).

Also, would it be possible to extract timestampts from other video sites such as BitChute and Odysee? That would save me a bit of extraneous work doing 'touch -t' on the downloaded videoes.

open a site feature request issue for each of these sites

That would save me a bit of extraneous work doing 'touch -t' on the downloaded videoes.

Note that the mtime of the videos are NOT the timestamp as extracted by yt-dlp. If you want the mtime, there is no choice but to get it from the downloaded file or by probing the download URL

Closing since it is impossible afaik. If it ever becomes possible to implement (without using the Data API ofc), it can be re-opened


Hey, i have some questions:

1- What is the max_len and why it is assigned to 11?
2- What is feature_dim_1 and feature_dim_2?

Thanks

Just change this code pad_sequences(mfcc_vector, maxlen=DESIRED_CUTOFF_LENGTH)
You can't change them, the feature dimensions are fixed, check out librosa library for more details.

Thanks!


Can it be used for .eslintrc files

I have a project with a .eslintrc file which includes all rules. Now I want to check if there are some new rules when there is a new release of eslint.
I have tried ./node_modules/.bin/eslint-find-new-rules .eslintrc, but there is not output. I am not sure if this is a valid use case for this module or if i am doing it wrong.
Thanks for your help.

Yes, this is absolutely a valid use case.
There'll be an output (and a non-zero exit code) only if there are rules that are not covered by the eslint config specified. As you said the specified eslintrc does include all rules, so there's no output.

Ok, thanks. It works partly in my case. If i use the following .eslintrc file, there is no output in the console. But since "eslint:recommended" does only include a few rules i would expect the module to tell me which other rules are missing.
{
    "extends": "eslint:recommended",
    "env": {
        "node": true,
        "browser": true
    },
    "rules": {
    },
    "globals": {
        "afterEach": false,
        "angular": false,
        "beforeEach": false,
        "browser": false,
        "by": false,
        "element": false,
        "expect": false,
        "describe": false,
        "FileList": false,
        "inject": false,
        "it": false,
        "jasmine": false,
        "lxHelpers": false,
        "spyOn": false,
        "UAParser": false,
        "xdescribe": false,
        "xit": false
    }
}

If i use the same .eslintrc but without specifying "extends": "eslint:recommended", it works fine and all rules missing are displayed.

In fact, eslint:recommended maps to eslint/conf/eslint.json. Every rule within eslint/lib/rules should be mentioned and configured in there (~209 in total / that also takes "deactivated" rules into account).

May be for the reworked version @sarbbottam wanted to fork from this one, we may implement some kind of comparison / diff tool, that shows the differences between multiple eslint configurations.
At least, it's something I already thought about.

@ta2edchimp @4kochi absolutely, I plan to raise the first PR, by EOD, a bit tied up at work.

Closing because this module is no longer maintained, please use https://github.com/sarbbottam/eslint-find-rules


Parallel State: Branch .Hope to support the use of states as branch.

What would you like to be added:
Hope to support the use of states as branch.
Why is this needed:
In some cases, we need to use states as a branch.
Although there can be subworkflow to indirectly use states as a branch, it is not convenient to use subworkflow.

@sky132333 we removed the direct use of states definitions inside branches for several reasons. It is much cleaner from the markup and from understanding point of view to place your branch logic (if it needs to be expressed via states) inside a sub-workflow and it also makes it reusable. Hope this helps.

@sky132333 we removed the direct use of states definitions inside branches for several reasons. It is much cleaner from the markup, reduces markup complexity by a lot, and from understanding point of view to place your branch logic (if it needs to be expressed via states) inside a sub-workflow as well as it makes it reusable. Hope this helps.

Okay, I get it


Account for JDK-Next Binaries

JDK-NEXT tarballs have no major version number in name

Closes: https://github.com/AdoptOpenJDK/openjdk-build/issues/1712
Signed-off-by: Morgan Davies<EMAIL_ADDRESS>

Hum this fix is strange .. we now accept OpenJDK without knowing the major version.
The variable jdk_version_found is now true .. but we may have not found a jdk major version
and last, the error message wich display regex no longer match the regex tested ..

Also the PR was not tested in any other job.
Usualy we test the PR with test_installer_windows or standalone_create_installer_windows job before merging.
Then, this PR didn't fix the bug as the extracted folder don't match what expected
https://ci.adoptopenjdk.net/job/build-scripts/job/release/job/create_installer_windows/4110/console
We are looking against 3 known extract path :
First .\SourceDir\OpenJDK15\hotspot\x64\jdk-15.0.0 not exists
Second .\SourceDir\OpenJDK15\hotspot\x64\jdk-15+24 not exists
Third .\SourceDir\OpenJDK15\hotspot\x64\jdk-15.0.0+24 not exists

but the zip file is now extracted ... without the major version determined
SourceDir\OpenJDK\hotspot\x64\jdk-15+24
As discussed in slack we need to stop extract all zip file blindly
Get-ChildItem -Path .\ -Filter *.zip -File -Name| ForEach-Object
and trying to detect arch/jvm/major for each but just rely on the jobs args and manage one artifact at a time.
We need another extract script. I will make a new bug to address this cleanly

see https://github.com/AdoptOpenJDK/openjdk-installer/issues/211
I tried to summarize why we have this problem and all that it entails


bad error message when typo in the name of a module

see Cédric's message on slack

Error: let-open only supported for modules, not namespaces gives no context. (name, file, line,...). This error seems to trigger whenever that is a typo in the opened module name.

I just got this error because a --include was missing (actually via kremlin, because of missing a -I). Very annoying, but I got there in the end, by probing single files to see which one throws the error and then by going through the file to see which modules it refers to. I was lucky and the file was small, so I found the problem quickly.

When I try open Foo, where Foo is not the path, I get an error saying "Namespace Foo cannot be found, No modules in namespace Foo and no files with that name either", which seems reasonable.
Also since we lost history on slack, hard to find out the original bug report : ). Closing, please reopen/file a new issue if required.


[Bug] Reroll always spawns player in the same dimension

I have "reroll dimension" set to false and override dimension set to -1, but its still spawning me in the same dimension. For example rerolling in the erebus spawns me in the erebus when it should be in the nether.

Fixed in 74dfc2336f41bd3ba7a4ccae6e43845797386393 . Override dimension should work period now. I tested a lot. But your mile may vary. Let me know if you run into this issue again.


Button position

Button to be positioned as per Summi's design.

still not as per the xd.

Verified this issue on dev app v2.0.80(486)


Add CloudWatch Logging

Added function that will write a log containing information about query parameters to AWS CloudWatch. Requires an AWS client to be present in the environment that can be accessed with boto3, as well as environment variables AWS_LOG_GROUP_NAME and AWS_LOG_STREAM_NAME. The values I have been using for these are 'data-service-queries-group' and  'data-service-queries-stream', respectively, but something like 'geoglows-service-queries-*' may be more appropriate, that is open for discussion.
@rileyhales @msouff

Hi @J-Ogden99
I'm merging your cloudwatch-logging branch directly into the branch I'm currently working on so I'll close this PR.


Search crashes

There are approximately 100 crashes per day of the FR2 search app
ActionController::UrlGenerationError
SearchQueriesController#create
23 Jun 2018, 08:40
Error message
ActionController::UrlGenerationError: No route matches {:action=>"show", :controller=>"search_queries", :id=>nil} missing required keys: [:id]
Error details
Filed tickets
Stack trace[Show framework code]
ActionController::UrlGenerationError: No route matches {:action=>"show", :controller=>"search_queries", :id=>nil} missing required keys: [:id]
…/freecen2/production/app/helpers/application_helper.rb:  201:in google_advert' /home/apache/hosts/freecen2/production/app/views/search_queries/_form_freecen.html.erb:194:in _app_views_search_queries__form_freecen_html_erb__2477835353264903732_17357765060'
/home/apache/hosts/freecen2/production/app/views/search_queries/new.html.erb:14:in _app_views_search_queries_new_html_erb__2173609002657814540_17357921340' …roduction/app/controllers/search_queries_controller.rb:   72:in create'

Deployed to production.

@smrr723 to check fix in the log before closing.

Can't see any errors similar to the above in the passenger.log on colobus, so the fix seems to have worked.


Allow multiple user markers in a turn

While playing the game, I often found myself in need of reapplying a misplaced marker, so I applied a quick patch.
Great codebase btw -- I have lots of learn from it!

I merged your patch and added a new configuration ALLOW_MULTIPLE_ANSWER which let you choose if you want to allow user to answer multiple times in the same turn.
The good thing with allowing only one answer per turn is that it limits the potential number of requests per user to one per turn which in turn limits the load on the server.
Thanks for the contribution.


New options for view control

Hi, I hope I'm not being annoying make many pull requests and changes 😓 but I changed a couple of things from the last time.
First I noticed new options for changing to overlay were on top of my options for views, so I consolidated them
I added a close button so that you can dismiss the view options if they are in the way.
I changed the way the "no gradient" option looks so it has color instead of just being black, but I hope it will be easier to see. Colors come from Coding Train Colors.
Since the "overlay" view option also deleted the element that contained the links to other options, I removed all the options except "overlay view". My reasoning is that once the links disappear you still have to refresh the page to get the normal view back so the extra links didn't seem to help.
The only thing missing is the completely monochrome, single color progress bar option which was removed when I consolidated all the code. I didn't want to keep adding to this and have a gigantic pull request, but I would be happy to add back that functionality if you like the rest of what I did and still want it.
I enjoy working on this project for fun and I hope I am not causing trouble. Feel free to ignore this very long PR if its too much or not what you're looking for. Thank you 🚂 🌈

Once again providing some context. The background color change does not seem to work in the browser, but I used the same code that was present for changing the background and I can see that it works by examining the CSS.
Normal Rainbow

One non-rainbow option

another non-rainbow option

Im liking your implantation more then mine
its surprising how we went about it different but were so close

Thank you. I'm sorry I should have checked to see what people had already started. I felt unsatisfied with my first attempt it wasn't good looking.
I really haven't done much collaborative development so I mean no offense in having done the same thing.
I only united the controls because they were overlapping. We did have very similar approaches but using the URL was not something I would have thought of at all but it's a great idea! I will definitely keep that approach in mind as well in the future.

Ive gone and added the cool gradient thing to mine if that's OK

Of course! I'm glad you like it.

yes that sounds like a plan


update NPU pipeline generate

Description
1. Why the change?

Add timing logic to the generate function. When generate accepts do_print=True, print these timing information
When we set max_new_tokens=32, now actually output 33  tokens,  fix this issue
transformer's generate actually return input_tokens  + output_tokens, now we only return output_tokens, fix this issue

2. User API changes
No change.
3. Summary of the change
4. How to test?

[x] Unit test: Please manually trigger the PR Validation here by inputting the PR number (e.g., 1234). And paste your action link here once it has been successfully finished.
[x] Application test

PR validation is passed: https://github.com/intel-analytics/ipex-llm-workflow/actions/runs/11286182074


Summoning dragon from Ninja target doesn't work

Description

The Ninja may have a goal to summon an additional threat. For some reason, the dragon ghost role is not created despite the message in the chat.
Reproduction

Be a ninja with an aim to summon threats
Hack the communication console
Receive a message about a connection with a space fish
Dragon ghost role is not created

bruh


Add copybara

Fixes: https://github.com/bazelbuild/bazel-central-registry/issues/1368

Hello @bazelbuild/bcr-maintainers, modules without existing maintainers (copybara) have been updated in this PR. Please review the changes.


Linux x86-64: Doesn't detect required dependencies even when installed

Booting the program on Linux Mint displays this error message and quits. However, all the packages it asked for have been installed already.

Could you try installing "libsdl2-dev" as well to see if that fixes it?

Could you try installing "libsdl2-dev" as well to see if that fixes it?
I had the same issue OP was having (on Debian) and I tried this solution and that solved the problem

That seems to have fixed it!


Remove --check-manifest-lists-from-snapshot flag

This is seemingly unused and is implemented by shelling out to curl.
https://cs.k8s.io/?q=check-manifest-lists-from-snapshot&i=nope&files=&excludeFiles=&repos=
https://grep.app/search?q=check-manifest-lists-from-snapshot
https://sourcegraph.com/search?q=context%3Aglobal+check-manifest-lists-from-snapshot&patternType=standard&sm=1&groupBy=repo
I believe this was part of some work that didn't get picked up based on my reading of https://github.com/kubernetes-sigs/promo-tools/pull/351
/cc @puerco

What type of PR is this?

/kind cleanup
What this PR does / why we need it:
Delete a bunch of unused code to make refactoring simpler.
Which issue(s) this PR fixes:

None
Special notes for your reviewer:
<3
Does this PR introduce a user-facing change?

NONE

/ok-to-test

Because it is shelling out to curl, I also looked it up when doing a big refactor last year, and I also felt nothing was using it. I agree we should remove it, especially to get rid of the curl calls :/
/lgtm
/approve

/test pull-cip-unit-tests


Default Publisher - make it a configurable setting

Every time a manifest app.json is created you get "Default Publisher" as the publisher name.
Why not making it a configuration option so all your new workspaces would get your own publisher name as configured?

Very good idea.

How many apps are you going to create? I would guess once in your life for each App on AppSource and Once for each of your customers. Like eventually it will be a few times per year.

Or default it to the company name from the license.
And add that to extensions created via in-page designer.

Hi! Thank you for your suggestion. We are working on focusing the activity in this repository on addressing issues related to the AL development tools.
As this issue appears to require changes across multiple areas of our product, we recommend that you post this on our Ideas forum at aka.ms/BCIdeas, or vote up the idea if its already there.
We are constantly monitoring top ideas and will consider them for a future release.


[SearchQnA] [ChatQnA] TEI service config for 1-card Gaudi scenario

When using single-card Gaudi, We would like to make changes to docker/gaudi/docker/docker_compose.yaml, as shown in the picture below, to move TEI embedding microservice to CPU. Need that information in the readme, or make corresponding changes to detect the number of HPU cards and pick the right version of docker_compose.yaml.

to move TEI embedding microservice to CPU

Why?  Is TEI-embedding Gaudi utilization too low for it to make sense, or is there some other reason?

to move TEI embedding microservice to CPU

Why? Is TEI-embedding Gaudi utilization too low for it to make sense, or is there some other reason?

Please refer to the problem reported in #370

You can change the docker compose file according your system resource. So it's not an issue.