Add tests for Qw, Qx and Qww. One more test for qx to check how two backslashes are interpreted

It should pass now I think on Windows and POSIX environments. Since echo on Windows leaves quotation marks in, and on POSIX we need them to treat the contents literally, compare qx[echo '\\\\'] and Qx[echo '\\'] to have the same result. The reason for so many slashes is this:
bash, sh, dash (echo binary) and csh builtin:
echo '\' #> \
echo '\\' #> \\
zsh builtin and tcsh builtin:
echo '\' #> \
echo '\\' #> \
Windows:
echo '\' #> '\'
echo '\\' #> '\\'
zsh and tcsh's builtin echo does not properly follow POSIX. Although worst case would be that the test would pass when it shouldn't, we can do better than this. We fix this with the extra slashes. As you can see all the below are different, and the test is functional on POSIX compliant and noncompliant echo's
zsh builtin and tcsh builtin:
echo '\\\\\\\\' #> \\\\
echo '\\\\' #> \\
echo '\\' #> \
If something went wrong and Qx may send half as many slashes as expected, this should detect it without assuming which shell the user has set as the system shell.

Thanks a lot!


Vertices are drawn when clicking on Controls in Chrome

[x] I'm reporting a bug, not asking for help
[x] I've looked at the documentation to make sure the behaviour is documented and expected
[x] I'm sure this is a Leaflet Draw code issue, not an issue with my own code nor with the framework I'm using (Cordova, Ionic, Angular, React…)
[x] I've searched through the issues to make sure it's not yet reported

How to reproduce

Leaflet version I'm using: 1.0.2
Leaflet Draw version I'm using: 0.4.7
Browser (with version) I'm using: Chromium Version 56.0.2924.76 Built on Ubuntu
OS/Platform (with version) I'm using: Ubuntu 16.04 (64-bit)

Steps:

Select polyline or polygon control and point a vertex to any control button (except Cancel): A vertex is drawn.
or: Select circle or rectangle control and draw starting on a control button: The geometry is drawn.

What behaviour I'm expecting and which behaviour I'm seeing
Bug: Vertices are drawn when control buttons are clicked.
Expectation: Controls should have priority over drawing functionality, i.e., control area should be disabled with respect to drawing. This is working correctly on firefox.
Minimal example reproducing the issue
Just use the official jsfiddle to reproduce.

I believe this is related to #670 and has already been patched in 0.4.8+

I believe this is related to #670 and has already been patched in 0.4.8+
No it isn't: 0.4.10 bug still here.

Still having similar issues with this 0.4.14.  Points are being dropped instead of Polygon being closed.


UnsupportedOperationException while fetching vertices by VertexQuery using remote connection

OrientDB Version: 3.1.12
Java Version: 16
OS: Windows
Expected behavior
It should be possible to fetch vertices by relation. As it works in 3.0.x versions of OrientDB.
Also if the number of fetched vertices is less than 40 it works fine as in this case OEmbeddedRidBag is used.
Actual behavior
Exception thrown:
java.lang.UnsupportedOperationException: null
at com.orientechnologies.orient.client.remote.OSBTreeCollectionManagerRemote.loadTree(OSBTreeCollectionManagerRemote.java:68)
at com.orientechnologies.orient.core.storage.ridbag.sbtree.OSBTreeCollectionManagerAbstract.loadSBTree(OSBTreeCollectionManagerAbstract.java:195)
at com.orientechnologies.orient.core.storage.ridbag.sbtree.OSBTreeRidBag.loadTree(OSBTreeRidBag.java:894)
at com.orientechnologies.orient.core.storage.ridbag.sbtree.OSBTreeRidBag.access$500(OSBTreeRidBag.java:76)
at com.orientechnologies.orient.core.storage.ridbag.sbtree.OSBTreeRidBag$SBTreeMapEntryIterator.init(OSBTreeRidBag.java:393)
at com.orientechnologies.orient.core.storage.ridbag.sbtree.OSBTreeRidBag$SBTreeMapEntryIterator.(OSBTreeRidBag.java:320)
at com.orientechnologies.orient.core.storage.ridbag.sbtree.OSBTreeRidBag.rawIterator(OSBTreeRidBag.java:469)
at com.orientechnologies.orient.core.db.record.ridbag.ORidBag.rawIterator(ORidBag.java:206)
at com.tinkerpop.blueprints.impls.orient.OrientVertex.getEdges(OrientVertex.java:839)
at com.tinkerpop.blueprints.impls.orient.OrientVertex.getEdges(OrientVertex.java:747)
at com.tinkerpop.blueprints.util.DefaultVertexQuery$DefaultVertexQueryIterable.(DefaultVertexQuery.java:110)
at com.tinkerpop.blueprints.util.DefaultVertexQuery.vertices(DefaultVertexQuery.java:84)
Steps to reproduce
Probably the result of this commit :

disabled support for tree ridbags in remote
https://github.com/orientechnologies/orientdb/commit/8110b05af752733b24b1b334a998f70c0b3843c1

Also i've tried to always use embedded ridbag by setting following configuration setting on client side:
OGlobalConfiguration.RID_BAG_EMBEDDED_TO_SBTREEBONSAI_THRESHOLD.setValue(Integer.MAX_VALUE);
but it seems to have no affect.  Is there a way to avoid somehow OSBTreeRidBag and always use embedded one?
Thanks

Hi @baguadev, could you try the same on Java 11 ?

Hello @laa
Tried it on JDK 11 with version 3.2.0
When ran it against existing DB got error:
com.orientechnologies.orient.core.exception.OCommandExecutionException: Cannot create user guest: role guest does not exist
DB name="OSystem"
at com.orientechnologies.orient.core.sql.parser.OCreateSystemUserStatement.lambda$executeSimple$0(OCreateSystemUserStatement.java:99)
at com.orientechnologies.orient.core.db.OSystemDatabase.executeWithDB(OSystemDatabase.java:201)
at com.orientechnologies.orient.core.sql.parser.OCreateSystemUserStatement.executeSimple(OCreateSystemUserStatement.java:48)
at com.orientechnologies.orient.core.sql.executor.OSingleOpServerExecutionPlan.executeInternal(OSingleOpServerExecutionPlan.java:97)
at com.orientechnologies.orient.core.sql.parser.OSimpleExecServerStatement.execute(OSimpleExecServerStatement.java:49)
at com.orientechnologies.orient.core.sql.parser.OServerStatement.execute(OServerStatement.java:72)
at com.orientechnologies.orient.core.db.OrientDBEmbedded.executeServerStatement(OrientDBEmbedded.java:1194)
at com.orientechnologies.orient.core.db.OrientDB.execute(OrientDB.java:364)
at com.orientechnologies.orient.server.OServer.createDefaultServerUsers(OServer.java:1067)
at com.orientechnologies.orient.server.OServer.loadUsers(OServer.java:908)
at com.orientechnologies.orient.server.OServer.activate(OServer.java:498)
So for now will stay on 3.1.x with that workaround setting
Thanks

@baguadev since 3.2 version default users are switched off to prevent security problems you need to create your own roles.

You do suggest  you do not use default users because of security reasons

we got a duplicate here: https://github.com/orientechnologies/orientdb/issues/9677
I think we need to actually fix the original problem, reading of the tree  are still needed in remote, and there is already an implementation for read them, is probably just not used in all the cases is needed

Hi,
This should have been fixed in 3.1.13
bye

Solved a while ago, closing


CSV Export

Hello,
I have created a PostgreSQL database to import the csv files produced by synthea. I used the schema given by the wiki entry "CSV File Data Dictionary".
In Observations the entry value should be numeric and in CarePlans the reasoncode is not allowed to be null according to the wiki article. But i have found csv records which are violating these constraints.
In Observations there is a string "Natural death with unknown cause" for the column value which is numeric and in CarePlans there is a null reasoncode.
Am I doing something wrong? Could that be a bug?
I can reproduce it with the command

./run_synthea -p 100

every time.

It is a bug... Either in the wiki or the exporter. Or both.
We'll have to investigate the CarePlan issue -- a patient shouldn't be assigned a careplan for no reason... although CarePlanStart.reason is optional (see https://github.com/synthetichealth/synthea/wiki/Generic-Module-Framework%3A-States#careplanstart) so maybe that is something we need to change to required.
Re: observations. Hmm. We'll need to think about that. Our primary exporter is FHIR, which technically allows a choice of datatypes for Observation.value -- it seems we have some that aren't just numerics, but it looks like the FHIR exporter code handles that correctly.
Suggestions?

Some fact finding.... Technically, the value for that observation is a code:
"valueCodeableConcept": {
  "coding": [{
    "system": "http://snomed.info/sct",
    "code": "9855000",
    "display": "Natural death with unknown cause"
  }],
  "text": "Natural death with unknown cause"
}

When converted to CSV, only the text gets exported.

The FHIR standard allows different types for the value in Observations:
https://www.hl7.org/fhir/observation-definitions.html#Observation.value_x_
But it is not possible in a relational schema to have different data types in one column. My idea would be to have three columns to solve this problem: value, unit and additionally type. For example it could look like this (I have omitted the other columns in this example):
... other columns |      value       | unit  |  type
------------------+------------------+-------+---------
...               | unexpected death |       | string
...               | 32.5             | kg/m2 | decimal
...               | 82.9             | mmHg  | decimal

 Column | Type | Modifiers
--------+------+-----------
... other columns
 value  | text | not null
 unit   | text |
 type   | text | not null

Maybe this is a solution?
It looks like that mapValueToFHIRType which can return StringType is used for Observation.value there:
https://github.com/synthetichealth/synthea/blob/master/src/main/java/org/mitre/synthea/export/FhirStu3.java#L923
Is this the reason for the strings for Observation.value?

Is this the reason for the strings for Observation.value?

In FHIR, yes.
Your proposal looks reasonable. The only downside is that type will be duplicative, and observation is already our biggest table by far. I don't have a better proposal in mind, however.
If you want to submit a pull request against CSVExporter.java adding the additional type column, we'll happily accept it. Otherwise, I'll add it to my backlog and get to it when I can.

Yes I can do it.

We should update the Wiki. Do I have the permission to do that?

The unit of an observation can be null.

Correct. Fixed the wiki.


Fixes token invalidation in cloud-config-downloader

How to categorize this PR?

/area robustness
/kind bug
What this PR does / why we need it:
Fixes a possible issue that could cause the cloud-config-downloader token to be invalidated if there any problems with the root file system of the node.
Basically instead of directly trying to write the token data into the file specified for the token, the data will first be written to a temporary file. If that succeeds and the contents of the temporary file differ from the token file or the token file has still not been created, the temporary file will be mv-ed to the token file. Otherwise (if the contents are the same) the temporary file will be removed.
I managed to reproduce the error locally by writing creating a very large file and then trying to echo some content into another file. The echo commands fills the file until there is not enough space on the device and then exists before filling in the entire data. Echoing to a temp file and then using mv as suggested in the issue prevents this.
Which issue(s) this PR fixes:
Fixes #5674
Special notes for your reviewer:
I have not yet tested this with an actual shoot yet.
Release note:

Fixed an issue that could cause the cloud-config-downloader to invalidate its credentials token if the node that it is currently running on has issues with the file system where the credentials token is stored (for example when the node runs out of disk space).

/assign

Also: What if the move operation corrupts the file. Meaning we were able to write to file_path.tmp but then the disk got full.

The mv operation  calls rename() as the file in this case is not moved between disks. I'm not sure how much this differs between Linux implementations though.
As for the complexity - it's just a few lines of code after all and I think that is why we decided to address this issue in #5674

/lgtm

/approve


System fonts not used on Linux

When using thaw's main branch (fluentui/v0.4) on Linux a fallback font rather than the system font is used for rendering. This looks different than what was rendered using thaw-v0.3 and does not match the system user interface. It looks bad and out of place.
Reason for this change in v0.4 is that generic font-families are missing in the definition of the theme: ui-sans-serif, system-ui and ui-monospace.
This patch fixes this and restores the look from v0.3 and what I would expect (on Linux):
diff --git a/thaw/src/theme/common.rs b/thaw/src/theme/common.rs
index fa460f6..18ad053 100644
--- a/thaw/src/theme/common.rs
+++ b/thaw/src/theme/common.rs
@@ -68,9 +68,9 @@ pub struct CommonTheme {
 impl CommonTheme {
     pub fn new() -> Self {
         Self {
-            font_family_base: "'Segoe UI', 'Segoe UI Web (West European)', -apple-system, BlinkMacSystemFont, Roboto, 'Helvetica Neue', sans-serif".into(),
-            font_family_monospace: "Consolas, 'Courier New', Courier, monospace".into(),
-            font_family_numeric: "Bahnschrift, 'Segoe UI', 'Segoe UI Web (West European)', -apple-system, BlinkMacSystemFont, Roboto, 'Helvetica Neue', sans-serif".into(),
+            font_family_base: "'Segoe UI', 'Segoe UI Web (West European)', ui-sans-serif, system-ui, -apple-system, BlinkMacSystemFont, Roboto, 'Helvetica Neue', sans-serif".into(),
+            font_family_monospace: "Consolas, ui-monospace, 'Courier New', Courier, monospace".into(),
+            font_family_numeric: "Bahnschrift, 'Segoe UI', 'Segoe UI Web (West European)', ui-sans-serif, system-ui, -apple-system, BlinkMacSystemFont, Roboto, 'Helvetica Neue', sans-serif".into(),

             font_size_base_100: "10px".into(),
             font_size_base_200: "12px".into(),

Notable is, that Firefox (which I use) does actually not support ui-*, only system-ui is supported.
I've not prepared a PR but only above patch, HTH.

Since version 0.4 is a complete rewrite, I prefer to use Fluent's design style.
I suggest you can use a custom theme:
let mut theme = Theme::light();
theme.common.font_family_base = "'Segoe UI', 'Segoe UI Web (West European)', ui-sans-serif, system-ui, -apple-system, BlinkMacSystemFont, Roboto, 'Helvetica Neue', sans-serif".into();
theme.common.font_family_monospace =  "Consolas, ui-monospace, 'Courier New', Courier, monospace".into();
theme.common.font_family_numeric = "Bahnschrift, 'Segoe UI', 'Segoe UI Web (West European)', ui-sans-serif, system-ui, -apple-system, BlinkMacSystemFont, Roboto, 'Helvetica Neue', sans-serif".into();
let theme = RwSignal::new(theme);

view! {
    <ConfigProvider theme>
          "..."
    </ConfigProvider>
}

Thanks for the reply. I haven't approach the issue from this side actually. I understand that you want to stick to the defintions from fluentui.
For future references I want to share some collected links and information around the topic "Fonts and Fluent design v9":
fluentui

Fluent UI web represents a collection of utilities, React components, and web components for building web applications.

The repository is located here: https://github.com/microsoft/fluentui
An overview of react components can be found here: https://react.fluentui.dev/
Font family as defined in Fluent design v9
fontFamilyBase
'Segoe UI', 'Segoe UI Web (West European)', -apple-system, BlinkMacSystemFont, Roboto, 'Helvetica Neue', sans-serif
fontFamilyMonospace
Consolas, 'Courier New', Courier, monospace
fontFamilyNumeric
Bahnschrift, 'Segoe UI', 'Segoe UI Web (West European)', -apple-system, BlinkMacSystemFont, Roboto, 'Helvetica Neue', sans-serif

see https://react.fluentui.dev/?path=/docs/theme-fonts--docs#font-family
Fonts used on https://react.fluentui.dev
The website https://react.fluentui.dev actually uses Segoe UI as font also on Linux. It loads the fonts from a Microsoft CDN https://c.s-microsoft.com/static/fonts/segoe-ui/west-european/normal/latest.woff2
How is this possible?

All files on the Fluent UI React GitHub repository are subject to the MIT license. Please read the License file at the root of the project.
Usage of the fonts and icons referenced in Fluent UI React is subject to the terms of the assets license agreement.

In this assets license Microsoft provides a restricted license for the Segoe font

for the following purposes:
a. In connection with the use of a Microsoft API within the development of a software
application, website, or product you create or a service you offer designed to provide access
or interact with a Microsoft service or application (“Application”)
b. To illustrate that Application integrates with one or more Microsoft products and services.

Generally, Segoe fonts are not distributable for other purposes (as web font, bundled with apps etc.) without a license (see https://learn.microsoft.com/en-us/typography/fonts/font-faq):

No, as Segoe UI is both our user interface and corporate branding font, it is not available for use outside of Microsoft products on non-Windows platforms.

The primary monospace font (Bahnschrift) has the same issues.
Open questions
What I find a bit concerning is, that the Fluent design guide prefers proprietary fonts which are not freely available and distributable as primary fonts. On macs it will fallback to the Apple system font, however the font definition does not include a sensible default for Linux systems (which would be system-ui).
One can workaround that limitations using a custom theme and/or importing the Roboto font in the index.html. This is ok and works for me.
What remains is, that the thaw demo using the v0.4 branch on Linux looks bad and broken. For this reason it might be good to select defaults which work well on all platforms (in particular since the design guide is mainly driven by Microsoft and does not cater all platforms well).

First of all, thank you for asking this question.  I had not noticed the font restrictions of Fluent UI before.
I don't know enough about font restrictions. Do I need to remove the proprietary fonts(Segoe UI, Bahnschrift) from the fonts to circumvent Microsoft's font restrictions?
Also, for issues in Linux, I'm willing to add ui-* and system-ui to solve.


Webpack5 failed

UPD: the problem is after
npm install --save @walletconnect/web3-provider

Is this project alive? Webpack5 is already not young, but compilation of this lib fails with messages:
ERROR in ./node_modules/xhr2-cookies/dist/xml-http-request.js 21:11-26
Module not found: Error: Can't resolve 'http' in 'node_modules\xhr2-cookies\dist'

BREAKING CHANGE: webpack < 5 used to include polyfills for node.js core modules by default.
This is no longer the case. Verify if you need this module and configure a polyfill for it.

If you want to include a polyfill, you need to:
        - add a fallback 'resolve.fallback: { "http": require.resolve("stream-http") }'
        - install 'stream-http'
If you don't want to include a polyfill, you can use an empty module like this:
        resolve.fallback: { "http": false }
 @ ./node_modules/xhr2-cookies/dist/index.js 6:9-38
<EMAIL_ADDRESS>2:0-46 4:47-61
<EMAIL_ADDRESS>3:0-60 268:28-42
 @ ./src/components/BodyTop/index.jsx 8:0-65 147:29-50
 @ ./src/components/AppIndex/AppIndex.jsx 3:0-37 7:133-140
 @ ./src/components/AppIndex/index.js 1:0-31 1:0-31
 @ ./src/components/index.js 2:0-27 2:0-27
 @ ./src/index.jsx 3:0-35 4:41-44

and a lot of the same errors:
Can't resolve 'https'
Can't resolve 'util' in 'node_modules\web3-provider-engine\util'
 Can't resolve 'os' in '\node_modules\xhr2-cookies\dist'

Im also getting the same error :((

cannot upgrade to react-script 5.0.0 since it uses webpack 5 had to stay at 4.0.3

Really? You made a stand-alone component which is addicted to react-script?

Any luck on this problem?? Breaking my head for a long time now :(

no luck still waiting for an update like everyone else here who/where are the creators of this library?

Been getting the same error when trying to use solely WalletConnect standalone client, no response in the related issue in their repo either. I guess the only way to go is to manually polyfill all the missing node.js modules?

anyone figure this out I had manually polyfilled everything but nothing seems to be rendering I get a bunch of warnings all something along the lines of " to parse source map from 'node_modules\xhr2-cookies'    Error: ENOENT: no such file or directory, open"

I was had the same problem. I did next steps to resolve it:

Run npm run eject more
Install npm i stream-http --save
Add resolve.fallback to config/webpack.config.js. Example: resolve: { fallback: {      "http": require.resolve("stream-http")    }}

We use CRA 5, and to fix the problem I installed craco, created craco.config.js and put there
const webpack = require('webpack')

module.exports = {
    webpack: {
        plugins: {
	    add: [
	        new webpack.ProvidePlugin({
		    Buffer: ['buffer', 'Buffer'],
		}),
	    ],
	},
	configure: {
	    resolve: {
		fallback: {
		    stream: require.resolve('stream-browserify'),
		    https: require.resolve('https-browserify'),
		    os: require.resolve('os-browserify/browser'),
		    http: require.resolve('stream-http'),
		    buffer: require.resolve('buffer'),
		},
	    },
	},
    },
}

And then install all necessary packages yarn add stream-browserify url assert util stream-http https-browserify os-browserify buffer. Everything works fine but I still get those source maps warnings @Wemmons831 mentioned

We use CRA 5, and to fix the problem I installed craco, created craco.config.js and put there
const webpack = require('webpack')

module.exports = {
    webpack: {
        plugins: {
	    add: [
	        new webpack.ProvidePlugin({
		    Buffer: ['buffer', 'Buffer'],
		}),
	    ],
	},
	configure: {
	    resolve: {
		fallback: {
		    stream: require.resolve('stream-browserify'),
		    https: require.resolve('https-browserify'),
		    os: require.resolve('os-browserify/browser'),
		    http: require.resolve('stream-http'),
		    buffer: require.resolve('buffer'),
		},
	    },
	},
    },
}

And then install all necessary packages yarn add stream-browserify url assert util stream-http https-browserify os-browserify buffer. Everything works fine but I still get those source maps warnings @Wemmons831 mentioned

Thanks a lot for the craco tip.
To save some people's time, craco doesnot support CRA 5 yet, you have to use an early version
npm install<EMAIL_ADDRESS>--save
Find the latest version: https://www.npmjs.com/package/@craco/craco
@mikjakbiak did you ever found a way to remove all the source map errors?

With stable version 2.0.0 of Web3Modal now released, we are officially dropping support for version 1.x
Due to this this issue/pr was marked for closing. It is highly recommended to upgrade as 2.x will be receiving further updates that will enable functionality for some of our newer sdks like auth and push as well as support for WalletConnect v2 (See this post about WalletConnect v1 being deprecated https://medium.com/walletconnect/walletconnect-v1-0-sunset-notice-and-migration-schedule-8af9d3720d2e)
If you need to continue using Web3Modal 1.x and require this feature/fix implemented, we suggest adding it via forking V1 branch.


[WIP] Add more section tests

Description

Add complete test coverage for all existing spacefish sections.
Motivation and Context

Increase faith in code being written and reduce time needed for manual testing.
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

[x] I have tested using MacOS
[ ] I have tested using Linux

Checklist:

[x] I have checked that no other PR duplicates mine
[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have updated the tests accordingly.

Closing the stale PR.


better way to override default parameter value in initializations/activations/regularizers

I don't want to use lambda function as suggested/discussed in https://groups.google.com/forum/#!topic/keras-users/kc0Jsw1vTqY and https://groups.google.com/forum/#!topic/keras-users/1RbHi3I0aGE.

It's not concise and is problematic with serialization.

kwargs parameters are not suitable when there are multiple initialization methods with the same argument name. For example, LSTM(init='uniform', inner_init='orthogonal'), uniform and orthogonal have the same argument named scale.

This modification enables us to override default parameter values in the following way:
LSTM(init='uniform(scale=0.01)', inner_init='orthogonal(scale=0.001)').

@fchollet, please check the detailed result of travis-ci. 5 out of 6 is passed. The one failed is test_adadelta ut.

The above is the result of Travis-CI. The failure is caused by test_adadelta in test_optimizers.py indicated by the following:

When I manually run the test by pytest test_optimizers.py with python 2.7, it's correct.

with the modification of pytest.ini as follows:

When I install the related packages according to code in Travis-CI
,
pytest.ini is the same with repo (without modification), and the test result is

The last three commits have nothing to do with the unit-test of Adadelta. But the checks succeed.
This indicates that:

there is something wrong with the implementation of Adadelta
or
there is something wrong with the travis-ci environment, which causes the unstable result of unit-test of Adadelta.

This is, like, a total hack...

I don't want to use lambda function as suggested/discussed in

But that, or defining a named function, is exactly what you should be doing...

@fchollet In order to override the default value of parameter scale in uniform for example, I have to define a lambda function with unnecessary parameter name, and everyone who wants to override has to do the same thing. I don't think it's a good way.


Outdated Templates

Current Templates arent up2date

Can confirm this - using any of the templates in the extension breaks the project in VS.

The extension has been updated with the latest changes.


[1.8] Fix broken link to Consul

old link is showing up in BLC as 308

Overriding CI requirements from newer branches.

Overriding CI requirements from newer branches.


Duplicate exports for typescript enum type

I'm writing an angular 2 appliation using the angular-cli which use webpack which in turn use acorn. The application is written in typescript. After upgrading angular-cli to the latest version I encountered an error with duplicate errors for my enum types, see example below.
export enum ReportFrequencies
{
    Daily = 6413,
    Weekly = 5593,
    Monthly = 5592,
    BiMonthly = 6452,
    Quarterly = 6412,
    HalfYearly = 6644
}

export namespace ReportFrequencies {
    function isIndex(key): boolean {
        let n = Number(key);
        return String(n) === key && n >= 0;
    }

    export function GetDescription(reportFrequencies: ReportFrequencies) {
        return ReportFrequencies[reportFrequencies].match(/[A-Z][a-z]+/g).join(' ');
    }
}

I traced down the error and saw that it was introduced when webpack started using version 4.x.x of acorn which checks for duplicate exports.
The code example seems like valid typescript and according to https://www.typescriptlang.org/play/ and https://www.typescriptlang.org/docs/handbook/declaration-merging.html. However the checkExport method, https://github.com/ternjs/acorn/blob/01c6ad27d42ff222434ecf9ba3c21fbce2bc3ef8/src/statement.js#L624, throws an error for this code.
Original issue in angular-cli repo: https://github.com/angular/angular-cli/issues/4735

I guess you wanted to report this to another project? Acorn doesn't support parsing TypeScript, only JavaScript code (unless you had a problem with some specific plugin that allows that for you).

Ok, the typescript code is code is transpiled down to the following code:
define(["require", "exports"], function (require, exports) {
    "use strict";
    var ReportFrequencies;
    (function (ReportFrequencies) {
        ReportFrequencies[ReportFrequencies["Daily"] = 6413] = "Daily";
        ReportFrequencies[ReportFrequencies["Weekly"] = 5593] = "Weekly";
        ReportFrequencies[ReportFrequencies["Monthly"] = 5592] = "Monthly";
        ReportFrequencies[ReportFrequencies["BiMonthly"] = 6452] = "BiMonthly";
        ReportFrequencies[ReportFrequencies["Quarterly"] = 6412] = "Quarterly";
        ReportFrequencies[ReportFrequencies["HalfYearly"] = 6644] = "HalfYearly";
    })(ReportFrequencies = exports.ReportFrequencies || (exports.ReportFrequencies = {}));
    (function (ReportFrequencies) {
        function isIndex(key) {
            var n = Number(key);
            return String(n) === key && n >= 0;
        }
        function GetDescription(reportFrequencies) {
            return ReportFrequencies[reportFrequencies].match(/[A-Z][a-z]+/g).join(' ');
        }
        ReportFrequencies.GetDescription = GetDescription;
    })(ReportFrequencies = exports.ReportFrequencies || (exports.ReportFrequencies = {}));
});

Is this not valid in acorn?

There are no language-level exports in that code, so I can't see how Acorn could raise an error about those for that code. (I.e. checkExports simply won't run when parsing it.)

Ok, thanks for the help but I don't have enough knowledge about the webpack echosystem to be able to know why the code breaks after upgrading webpack and acorn versions. Hopefully I can get some help in the issue at the angular-cli repo.

I have been digging a bit more now and looked at the javascript code that typescript transpiles down to and that acorn then tries to parse. As you can see there are two exports there and I guess that is not valid according to some spec? Is it possible to turn the duplicate errors check off?
export var ReportFrequencies;
(function (ReportFrequencies) {
   ReportFrequencies[ReportFrequencies["Daily"] = 6413] = "Daily";
   ReportFrequencies[ReportFrequencies["Weekly"] = 5593] = "Weekly";
   ReportFrequencies[ReportFrequencies["Monthly"] = 5592] = "Monthly";
   ReportFrequencies[ReportFrequencies["BiMonthly"] = 6452] = "BiMonthly";
   ReportFrequencies[ReportFrequencies["Quarterly"] = 6412] = "Quarterly";
   ReportFrequencies[ReportFrequencies["HalfYearly"] = 6644] = "HalfYearly";
})(ReportFrequencies || (ReportFrequencies = {}));

export var ReportFrequencies;
(function (ReportFrequencies) {
   function isIndex(key) {
       var n = Number(key);
       return String(n) === key && n >= 0;
   }
   function GetDescription(reportFrequencies) {
       return ReportFrequencies[reportFrequencies].match(/[A-Z][a-z]+/g).join(' ');
   }
   ReportFrequencies.GetDescription = GetDescription;
})(ReportFrequencies || (ReportFrequencies = {}));

As you can see there are two exports there and I guess that is not valid according to some spec?

Yes, the spec explicitly forbids exporting the same name twice. I consider this a TypeScript bug and I'm not interested in adding a workaround option to Acorn.


Travis: separate env/task for checkqa (flake8, pep8) / use tox

With pytest-django we're using tox on Travis (https://github.com/pytest-dev/pytest-django/blob/master/.travis.yml) and have separate testenvs to only run flake8 (https://github.com/pytest-dev/pytest-django/blob/master/tox.ini#L19-L27), e.g.
[testenv:checkqa-python2.7]
commands =
    flake8 --version
    flake8 --show-source --statistics pytest_django tests
basepython = python2.7
deps =
    flake8
setenv =
    UID = 2

This allows to separate the QA checks from the tests itself.  Currently
pep8 might abort all builds (e.g. https://travis-ci.org/yourlabs/django-autocomplete-light/builds/51990995).
.travis.yml and tox.ini are generated via https://github.com/pytest-dev/pytest-django/blob/master/generate_configurations.py.

This is done by now.


add missing eof line support

Adds support for missing eof marker in git diffs. Without this, the parser will only parse the diff up to the first instance of this marker in the diff.
@yeonjuan I don't actually have any use for this in the parsed output, but discovered this issue when I was experimenting with your library. I'm also not sure if this is the only git diff line that uses the \ character, the git docs are rather sparse on this matter.

HI, @zmully Thanks for fixing it.

I don't actually have any use for this in the parsed output, but discovered this issue when I was experimenting with your library. I'm also not sure if this is the only git diff line that uses the \ character, the git docs are rather sparse on this matter.

After a quick check of the git source, it seems that the "" character is always followed by a "No newline at end of file" message. But I thinks it would be great if we use general type value such as "Message" for the handling other messages we might miss.
{
   type: "Message",
   content: "No newline at end of file"
}

Thanks @yeonjuan for the quick review and feedback! I've updated the PR with your feedback and added the missing README section I didn't catch the first time around. Thanks for putting together this library, it is super useful, and helped me put together an internal tool to parse out stringified JSON (like usually seen in IAM policy declarations)  in diffs and redisplay the changes in a format that makes reviewing changes easier and less error prone.


Ensure filter selections don't automatically reset

Resolves PLATFORM-1687
When trying to select a filter from a shows fitlered artwork view, the picker would always reset when a selection was made.

This issue was caused because the picker was keying off of id from counts which was changed to internalID. The typing was insufficient and thus this wasn't caught.
Actions I took:

Update id to internalID where appropriate
Update the types to ensure future changes would be caught

Ace. I'll update this when I make my internalID to value change 👍


Release new version with updated identifier

The recent change from plugin ID GabrielBB.vscode-lombok to vscjava.vscode-lombok seems to produce problems.
When trying to install the extension in a dev container, I can see after unpacking ~/.vscode-server/extensionsCache/vscjava.vscode-lombok-1.0.1 that the identifier is still the old one:
<Identity Language="en-US" Id="vscode-lombok" Version="1.0.1" Publisher="GabrielBB"/>

Additionally, after installing the plugin, it does not seem to be activated by the remote extension host, which renders it unusable.
The plugin was installed in the dev container under ~/.vscode-server/extensions/vscjava.vscode-lombok-1.0.1/, but again, the identifier is the old one. Changing the identifier manually in ~/.vscode-server/extensions/vscjava.vscode-lombok-1.0.1/.vsixmanifest and restarting did not help.

Doing the following

rename ~/.vscode-server/extensions/vscjava.vscode-lombok-1.0.1/ to gabrielbb.vscode-lombok-1.0.1/
remove entry for gabrielbb.vscode-lombok from ~/.vscode-server/extensions/.obsolete
rename ~/.vscode-server/extensions/vscjava.vscode-lombok-1.0.1 to gabrielbb.vscode-lombok-1.0.1
restart

helped, and the remote extension host is now starting the extension again.
But it still does not resolve Lombok annotations, despite having added -javaagent:\"/home/vscode/.vscode-server/extensions/gabrielbb.vscode-lombok-1.0.1/server/lombok.jar\" to the java.jdt.ls.vmargs setting for the dev container remote.

I have updated my Maven project from an older Lombok version (1.16.x) to the latest version. After accepting a prompt to reload the VS Code window, the issue resolved itself, and Lombok annotations are being resolved again.
I still believe the extension should be released with a new version and correct extension ID.

I've tred to change every occurence of gabrielbb into vscjava, but it doesn't work.
The java.jdt.ls.vmargs setting seems to be valid.

After change to version with updated identifier i have that error:
message: 'Failed to find Premain-Class manifest attribute in /home/app/.m2/repository/org/projectlombok/lombok-mapstruct-binding/0.2.0/lombok-mapstruct-binding-0.2.0.jar\n',

After change to version with updated identifier

There doesn't seem to be a new release yet, or am I missing something?

Nevermind. The redhat.java extension now supports Lombok natively. GabrielBB.vscode-lombok and vscjava.vscode-lombok can simply be uninstalled.


Config orc version in diff profile  #939

What changes were proposed in this pull request?
To slove #939, let oap with spark-2.1 profile can build by Java 7.
How was this patch tested?
Manual test

This patch will back port to branch-0.5


WIP v2 apis for service/containers

@prachidamle this very inital, very WIP PR has examples of how to setup resource actions + "data" field conversion

Very stale. Closing. Sorry @alena1108! 😛


Use withscores to optmize leaders call where rank can be inferred.

When returning results for multiple contiguous members on the leaderboard we were calling zrank and zscore on each of them individually (in a pipeline) which was giving us O(M * log(N)) performance instead of the O(log(N)) performance that we might expect.
We can use withscores=True to avoid the extra zscore commands. Because we know that these are contiguous members of the leaderboard we can infer the ranks of all members from the rank of the first member and avoid (almost) all of the additional zrank calls. This ranking logic has been implemented for each of the 3 types of leaderboards.
This should improve performance for all_leaders, leaders, around_me, members_from_rank_range, and top methods; all of which deal with contiguous chunks of the leaderboard.
Also fixes test builds on python3 by specifying decode_responses.

Looks like we could apply a similar optimization to the around_me, all_members, and members_from_rank_range call.
For members_from_score_range and other similar queries we could do a single zrank call and extrapolate from there since we know we are selecting contiguous chunks of members.
Studio doesn't use: all_members, members_from_rank_range, or members_from_score_range though.

@GraylinKim If we're changing the base method as to how we do calculation of rank, then I'd rather see that change applied to the other methods mentioned in your second comment as opposed to applying this optimization piecemeal.


WIP: fix #3389

coverage: 92.356% (-0.3%) from 92.622%
when pulling<PHONE_NUMBER>a678cad12b66e50663651091af267a on antgonza:fix-3389
into ea0a7ecf793634412235e06e9532227ec3673076 on qiita-spots:dev.


Animate history.replace()

Due to the limitations of the history API, it is not possible to route BACK to a specified route PATH whilst having it animate using the appropriate back transition. Instead, go(-n) must be used which is fragile. Is there any way to support this feature?
I was wondering if we could use the REPLACE action from history.replace(path) to trigger the back animation and have this as a togglable option. I.e animateOnReplace: Bool.
I would be happy to look at this @Traviskn if you're in agreement!

This sounds like a great idea!
I'm wondering if it would be useful to be able to configure either a forward (push) or backward (pop) transition on replace. Maybe a prop like replaceTransitionType where the default is 'none' and the other two options are 'push' and 'pop'. Any thoughts?

@Traviskn yes thats a great idea! I will have a look at getting this implemented tomorrow 👍

Done. See #16.


Rule PT019 Treats Unused Mocks as Fixtures when prefixed with underscores

Rule PT019 treats unused mock arguments prefixed with underscores as Pytest fixtures. Meaning, if you don't use the mock Ruff will flag it as unused fixture.
Example
from unittest import mock

# `_func` gets treated as unused fixture.
@mock.patch("func")
def test(_func):
    assert 1 == 1

Details

Ruff version: v0.0.286
Command: ruff check .

@charliermarsh Understand this is probably just be due to fixture naming conventions, but just thought I would flag in case!

There is a similar issue in the upstream: https://github.com/m-burst/flake8-pytest-style/issues/202


"Impossible to mount its volumes" when (auto)restarting container with -volumes-from

Hi,
I'm using 0.8.1 with devicemapper. I have a mysql container with a data volume attached with -volumes-from. Several containers use links against this to access the database.
Therefor on reboot docker correctly tries to restart the mysql container first but it fails:
[debug] runtime.go:159 Container 7c4643ef8df7ef1c23b312ef207faacc5a8958adc4a3af15db81dbbc220d4d33 was supposed to be running but is not.
[debug] runtime.go:161 Restarting
[debug] deviceset.go:230 activateDeviceIfNeeded(7c4643ef8df7ef1c23b312ef207faacc5a8958adc4a3af15db81dbbc220d4d33)
[/var/lib/docker|6028185e] +job allocate_interface(7c4643ef8df7ef1c23b312ef207faacc5a8958adc4a3af15db81dbbc220d4d33)
[/var/lib/docker|6028185e] -job allocate_interface(7c4643ef8df7ef1c23b312ef207faacc5a8958adc4a3af15db81dbbc220d4d33) = OK (0)
[/var/lib/docker|6028185e] +job release_interface(7c4643ef8df7ef1c23b312ef207faacc5a8958adc4a3af15db81dbbc220d4d33)
[/var/lib/docker|6028185e] -job release_interface(7c4643ef8df7ef1c23b312ef207faacc5a8958adc4a3af15db81dbbc220d4d33) = OK (0)
[debug] deviceset.go:844 [devmapper] UnmountDevice(hash=7c4643ef8df7ef1c23b312ef207faacc5a8958adc4a3af15db81dbbc220d4d33, mode=0)
[debug] deviceset.go:881 [devmapper] Unmount(/var/lib/docker/devicemapper/mnt/7c4643ef8df7ef1c23b312ef207faacc5a8958adc4a3af15db81dbbc220d4d33)
[debug] deviceset.go:886 [devmapper] Unmount done
[debug] deviceset.go:754 Waiting for unmount of 7c4643ef8df7ef1c23b312ef207faacc5a8958adc4a3af15db81dbbc220d4d33: opencount=0
[debug] deviceset.go:659 [devmapper] deactivateDevice(7c4643ef8df7ef1c23b312ef207faacc5a8958adc4a3af15db81dbbc220d4d33)
[debug] devmapper.go:509 [devmapper] removeDevice START
[debug] devmapper.go:519 [devmapper] removeDevice END
[debug] deviceset.go:714 [deviceset docker-252:0-5767278] waitRemove(docker-252:0-5767278-7c4643ef8df7ef1c23b312ef207faacc5a8958adc4a3af15db81dbbc220d4d33)
[debug] deviceset.go:725 Waiting for removal of docker-252:0-5767278-7c4643ef8df7ef1c23b312ef207faacc5a8958adc4a3af15db81dbbc220d4d33: exists=0
[debug] deviceset.go:737 [deviceset docker-252:0-5767278] waitRemove(docker-252:0-5767278-7c4643ef8df7ef1c23b312ef207faacc5a8958adc4a3af15db81dbbc220d4d33) END
[debug] deviceset.go:679 [devmapper] deactivateDevice END
[debug] deviceset.go:898 [devmapper] UnmountDevice END
[debug] runtime.go:293 Failed to register container 7c4643ef8df7ef1c23b312ef207faacc5a8958adc4a3af15db81dbbc220d4d33: Container 7c4643ef8df7ef1c23b312ef207faacc5a8958adc4a3af15db81dbbc220d4d33 not found. Impossible to mount its volumes

With this failing, all other containers depending on that fail as well.
Here is the docker inspect output for that container: https://gist.github.com/discordianfish/ce4edf3861482d44a7c5
My first thought was that maybe the volume container wasn't loaded but it was just a few lines before that error:
[debug] runtime.go:284 Loaded container f6ad2764975c7127348dfae08785053ecd2fcf4567e827257f852f7fe2266dbe

Restarting the container manually works fine. After that, I can restart all depending containers as well. So it seems this is either limited to the start up or a race condition (maybe #4036?).

Is there maybe any progress on this issue?

Closing as this doesn't seem relevant anymore.

Is that because devicemapper is not the default anymore, or is there another issue that solved this that could be referenced?

@MetalArend This was probably due to a bug in how volumes-from was handled in the past. Should not happen anymore.


Abstract LogFloat

We are currently using LogFloat to represent probabilities. This is a sensible default, but may not always be the best choice. It would be better to parametrise the type classes MonadDist and MonadBayes by the type representing probability.

We now have a LogDomain type that is similar to LogFloat, but works with any Floating type. Probability monads have custom types representing real numbers that are used to represent probabilities.


Open Austin name in header

@luqmann pointed out that our name isn't in the header at all. Only in the hero section. He suggested putting "Open Austin" to the right of the star logo.
@VictoriaODell, what do you think about the best way to implement this?

I think we should have an iteration of the logo done horizontally then. I can create that and then we can update the logo files on github.

I think that would be good. But I don't think it's vital for launch. Can you put that on your todo list for the website @VictoriaODell? I'm going to rename this issue and put it in the backlog for now.

Agreed,
I don't know how you work, keep up with emails, and manage all this! I sit
next to a developer at work now so maybe I can try this myself too. X)
Victoria O'Dell | Visual Designer & Activist
*c:*469.951.1576<EMAIL_ADDRESS>*w:*victoriaodell.com
On Thu, Feb 4, 2016 at 10:49 PM, Mateo Clarke<EMAIL_ADDRESS>wrote:

I think that would be good. But I don't think it's vital for launch. Can
you put that on your todo list for the website @VictoriaODell
https://github.com/VictoriaODell? I'm going to rename this issue and
put it in the backlog for now.
—
Reply to this email directly or view it on GitHub
https://github.com/open-austin/open-austin-org/issues/53#issuecomment-180197265
.

@mateoclarke Let's do this for launch. I put the horizontal logo in the Open Austin logo repo issue section and assigned it to you.

this seems done


fixes for switching full-screen and v-sync

Sorry, calling glfwSwapInternal() every frame does not look as a good solution, it should be called only once or on context changes.

I'm setting requireVSync = true on any configFlag change or ToggleFullscreen. You'll se in the new PR.
Who knows why glfwMakeContextCurrent is needed. Have you been able to reproduce the issue?

Still won't work when starting off in fullscreen mode, only when switching from window to fullscreen.
A call to  glfwSetWindowMonitor after glfwSetWindowMonitor.
The actual framerate with v-sync is random without and sometimes v-sync is actually ignored.
When switching form window to fullscreen I actually can't reach 144 HZ, only 143.

Yeah, yesterday's positive tests are no longer reproducible. I've been literally stuck for many years now on just mode switching in DirectX. Rendering goes perfectly, great graphics and performance, but switching mode doesn't work. Last time I could make it work was in DirectX 9.
Sad to see that OpenGL is just as unreliable. I'll continue testing but stuck for now.

I found that to get switching to work reliably (on Linux) I had to do...
    if (toggleScreen!=0) {
        toggleScreen--;
        if (toggleScreen==0) {
            ToggleFullscreen();
            if (!fullScreen) {
                SetWindowSize(GetScreenWidth()/2, GetScreenHeight()/2);
                SetWindowPosition(GetScreenWidth()/4, GetScreenHeight()/4);
            }
        }
    }

when I want to actually activate the change.....
toggleScreen = 4;
fullScreen = !fullScreen;
if (fullScreen) {
SetWindowSize(gameScreenWidth, gameScreenHeight);
otherwise it would do things like give me a low resolution fullscreen and generally behave unpredictably
not sure if this helps or muddies the waters!

Hi chriscamacho!
This might be similar to my solution of calling glfwSwapInternal for 5-8 frames.
Something is definitely weird here.
I will rebuild the Raylib test app in pure GLFX and see if the swapping issues still reproduce.

hi MasterZean,
note I'm only delaying change of screen change pre entering fullscreen when if falls back to windowed, it doesn't seem as finicky!

Excuse me but I'm not convinced by the SwapBuffers() solution... I'll try to review this issue more carefully at some point...

Merging for further review...


Update k3os version references in README

@proegssilb there are still a couple of v0.5.0 references in the doc, if you could correct those in both the "Bootstrap Installation" and the "Takeover Installation" sections I would appreciate it.

That should be cleared up.


New version: Amazon.AWSCLI version 2.13.18

[ ] Have you signed the Contributor License Agreement?
[ ] Have you checked that there aren't other open pull requests for the same manifest update/change?
[ ] This PR only modifies one (1) manifest
[ ] Have you validated your manifest locally with winget validate --manifest <path>?
[ ] Have you tested your manifest locally with winget install --manifest <path>?
[ ] Does your manifest conform to the 1.5 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

Hi @PckgrBot,
I can't find the PR where this manifest was originally submitted, but this is apparently a duplicate, as the manifest is already in the repo. Closing due to merge conflict.


Execution of code for ImageNet code (Moco trick)

Dear author, thanks so much for the brilliant work. Could you guide me in the execution of code for the Imagenet dataset?
Cheers

Hi, you may just need to combine the momentum encoder idea from the MoCo code, with the SupCon loss here. Our paper did not use the MoCo trick, tho.


Add team to account managers in GET company endpoint

Description of change
This adds dit_team to the account_manager and one_list_account_owner fields to the GET company endpoint response data.
We only really need the one_list_account_owner to be updated but I've changed the account_manager field as well for consistency.

Codecov Report

Merging #1059 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           develop   #1059   +/-   ##
=======================================
  Coverage     96.1%   96.1%
=======================================
  Files          213     213
  Lines         6038    6038
  Branches       583     583
=======================================
  Hits          5803    5803
  Misses         168     168
  Partials        67      67

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c9ac8a...cf2dc8b. Read the comment docs.


feat: Do not unmount the chart when data is being loaded

Closes #1126
Currently we unmount the whole chart component and use <Loading /> when data is being fetched via the ChartDataWrapper component.
In my opinion, this is suboptimal user experience, as we lose track of the old chart state when the data is being loaded, and immediately are presented with new state, losing the sense of the difference between prior and current charts.
As we take advantage of smooth transitions between chart states in several chart types, it should result in less obtrusive behavior of the chart component, especially when manipulating chart filters.
For an initial implementation I applied a semi-transparent LoadingOverlay component, this might be changed after @KerstinFaye's review 😁
I also discovered a bug in the hook for data loading we use, that results in missing loading indication of any kind for the charts – this is also fixed by this PR.
How to test
PR

Go to this link.
Play around with the filters.
✅ See that there is a semi-transparent loading overlay and that the chart is not unmounted.

PROD

Go to this link.
Play around with the filters.
❌ See that there's no indication of the data being fetched (bug in the data fetching hooks, previously the whole chart was being unmounted).

Thanks @bprusinowski. It will very much improves user experience. That's really great.
I would shorten the loading information that appears after some seconds. Maybe "Processing large data sets. Please wait.", or"Optimizing large data processing. Please wait."?
Is there any way of not dimming the text but dimming the chart underneath? It seams like the text has the same color as its background but with more opacity. Maybe we could improve the contrast by increasing opacity of the chart so the text is darker than the chart?

@KerstinFaye @bprusinowski just a small heads up. The text for the current loading state (see screenshot) was defined by Thomas Bettler. If we intend on changing it, i would suggest we quickly check in with him. Please also do not forget the translations. Thanks!


Should have native .NET output binding support

Must be able to write output to a Kafka topic using output bindings

[x] Output binding
[ ] Expose important configuration options for producers
[ ] Add unit tests

To help in somebody picking this up, can we define "important" in this issue?

My suggestions would be for you to take a look at the librdkafka and Confluent.Kafka configuration docs and propose what settings should be exposed in the function.
I would start with settings that affect performance and throughput. Settings about max message size could be important too, in case we need to support topics with large messages.
At the end we should add the newly exposed options in our documentation section.
Does it help @brandonh-msft ?

perfect, thanks

@brandonh-msft is this* something you're going to tackle?

take a look at the librdkafka and Confluent.Kafka configuration docs and propose what settings should be exposed in the function.
At the end we should add the newly exposed options in our documentation section.

you can put this on my backlog but i'm tackling #44 first

Ok, assigned to you

K so right now, looking at Global configuration properties in librdkafka docs I'm thinking:

property
proposed name
description

message.max.bytes
MaxMessageBytes
Maximum transmit message size.

enable.auto.commit
AutoCommit
Automatically and periodically commit offsets in the background.

auto.commit.interval.ms
AutoCommitInterval
The frequency in milliseconds that the consumer offsets are commited (written) to offset storage. (0 = disable)

batch.num.messages
BatchSize
Maximum number of messages batched in one MessageSet.

It's not clear to me if some of those are implementations we'd have to code up (autocommit, for instance) or if it's something we specify on the msg that's sent and the protocol/receiver takes care of it. Would be good to get some clarity there if you guys know off the top of your head.
Nothing else is standing out as either applicable to sending messages, or particularly useful.

Are those consumer or producer related settings? It is unclear to me.
Regarding commit configuration: we are doing manual commits, therefore enable.auto.commit and auto.commit.interval.ms will not be used/exposed.

yeah TBH i'm not sure either; i agree it's not super clear in the docs whether it's producer related or not. I just kinda guessed.
So now considering just:

property
proposed name
description

message.max.bytes
MaxMessageBytes
Maximum transmit message size.

batch.num.messages
BatchSize
Maximum number of messages batched in one MessageSet.

Ok. let's start with these. and when people request others or want extra features that are unblocked by exposing others, then we can go add them.

Not sure if we should expose:
enable.idempotence
source: https://github.com/edenhill/librdkafka/blob/master/CONFIGURATION.md

Can someone please update the docs and send a PR for bullet point 2 then. sounds like it's done.

After some more digging found these are all the knobs even possible to set - do we just expose them all?

We already have so many, adding just for the sake of having all might in turn cause the configuration to be over complicated.

fair enough - it doesn't look like, though, i can tweak the pieces I called out earlier after looking at what the .Net SDK exposes in ProducerConfig - which of the above do you think we'd want to expose, then? Perhaps just the EnableIdempotence? I can see value in the Timeouts, BatchNumMessages, and MessageSendMaxRetries, though.

I like your proposal. For Idempotence we need to check how we handle errors in our producer

Yeah, go for the simplest config that enables the majority of scenarios. We can start exposing more config options as developers using this start requesting additional features. Too many knobs and dials get confusing

@brandonh-msft  What's the status of this? In progress? Or complete?


Refactor apply_yaml action to use ObjectStore.CreateFromYAML

Signed-off-by: Wayne Witzel III<EMAIL_ADDRESS>What this PR does / why we need it:
Make it easier for other parts of Octant to take advantage of the CreateFromYAML logic that was added in #954

related #1136


feat: add lapack/base/dptts2

Towards #2464
Description

What is the purpose of this pull request?

This pull request adds initial implementation for lapack/base/dptts2.
Related Issues

Does this pull request have any related issues?

No.
Questions

Any questions for reviewers of this pull request?

No.
Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.
Checklist
TODO:

[x] Add tests for strideB1, strideB2.
[ ] Refactor implementation ( loop interchange )

Please ensure the following tasks are completed before submitting this pull request.

[x] Read, understood, and followed the contributing guidelines.

@stdlib-js/reviewers

I think this PR can now have a final review.


[WIP] MGMT-13692: Use the ignition file info

Description

If the ignition info file (/coreos/igninfo.json) is present in the ISO
use it to determine where the ignition content should be embedded
instead of assuming it should always go in "/images/ignition.img"
If an error is encountered when reading the ignition info, fall back to
the previous ignition path. This allows the image service to seamlessly
support older versions without having to explicitly include logic about
which version is being used in every call.
How was this code tested?

Added a failing test in the integration tests (s390x pre-release).
This should be fixed before merging.
I'm not sure if it's worth adding separate unit-tests for with or without this file.
For now maybe we should pin a single integration test to a version without it? I'm not sure.
Assignees

/cc @filanov
/cc @ori-amizur
Links

Resolves https://issues.redhat.com/browse/MGMT-13692
Checklist

[x] Title and description added to both, commit and PR
[x] Relevant issues have been associated
[x] Reviewers have been listed
[x] This change does not require a documentation update (docstring, docs, README, etc)
[x] Does this change include unit tests (note that code changes require unit tests)

@carbonin I have been asked to continue your work on this, see #156. I removed your commit to modify the integration tests and added a commit to add unit tests instead.


It keeps flashing when setstate

It keeps flashing when setstate , especially when using ReorderableListView, it need to setstate frequent.
It will reload every time when use setstate , because there is no cache.
I hope you can solve this problem.thank you.

Thanks for your feedback. I will check it soon.


Support flag emoji

The regex matches only one non-digit character, but
:canada: is really 🇨🇦.

This could be done by making the format more lax. We could get all characters up until ) or the fullwidth equivalent, or even just until the first whitespace character.
Then just try to react with whatever characters are received up until the first whitespace.

closed by b254ee312a52dd24c5188a0232f6016e0364b304


Empty address in log

I got a log with address empty, which fails the web3 client; however, the explorer is displaying a correct address, https://mastery.aion.network/#/transaction/a18d9b7d1b6f6c0209088fadfd4487a3cf623e3b3d4559abcce26b6b1934fda8.
aion-<IP_ADDRESS>:8545> eth.getTransactionReceipt("0xa18d9b7d1b6f6c0209088fadfd4487a3cf623e3b3d4559abcce26b6b1934fda8")
{ blockHash: '0xadc75e6134978a472e4a42255aab0ea33a0cd85ed56633423414cfb79b13028c',
  nrgPrice: '0x02540be400',
  logsBloom: '00000000000020000000000000000000000000000000000000000000000000000000000000000000000000000000000000000010000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000200000000000080000010000000000000000002000000000000000000000000000000000000000000',
  nrgUsed: 249417,
  contractAddress: '0xa06f2d4682cd64234d7aa644da23fa5edccc9e3c5bdf888f9a6db7f9128d344f',
  transactionIndex: 0,
  transactionHash: '0xa18d9b7d1b6f6c0209088fadfd4487a3cf623e3b3d4559abcce26b6b1934fda8',
  gasLimit: '0x0f4240',
  cumulativeNrgUsed: 249417,
  gasUsed: '0x03ce49',
  blockNumber: 1023871,
  root: '7e8c4e89a68b07f918a526d6368fdac421835f158155e50b41157b8cd4671fdb',
  cumulativeGasUsed: '0x3ce49',
  from: '0xa005bebbea7fc4475f2655cd3485f99db221c692e388052f345c628ebb028534',
  to: '0x',
  logs:
   [ { address: '0x',
       logIndex: 0,
       data: '0x0000000000000000000000000000000100000000000000000000000000000030000000000000000000000000000000500000000000000000000000000000000361626300000000000000000000000000000000000000000000000000000000020000000000000000000000000000000100000000000000000000000000000002',
       topics: [Array],
       blockNumber: 1023871,
       transactionIndex: 0 } ],
  gasPrice: '0x02540be400',
  status: '0x1' }

Was digging into this issue a bit, and found the issue can be pinpointed to https://github.com/aionnetwork/aion/blob/843761824132b2dfe2a6e8dbc5b755167f571718/modApiServer/src/org/aion/api/server/types/TxRecptLg.java#L59
I think the above condition check is unnecessary, because an account creation transaction (tx.getTo() == null) can call another contract which emits a log.

Fixed by #656


⚠ Homepage (omg.lol) has degraded performance

In c64deb4, Homepage (omg.lol) (https://8bit.lol/) experienced degraded performance:

HTTP code: 503
Response time: 2924 ms

Resolved: Homepage (omg.lol) performance has improved in 15fe4b7 after 35 minutes.


python precision handling

how did you handling precision of python?
i use round()

IDK, let's hear from the person who did the coding part.

Hi, Thank you for letting me notice this as I didn't check the sig figs


find_end randomly fails with SIGABRT on Travis CI

I don't know why, but find_end algorithm sometimes fails with with SIGABRT in find_end_string test case. It happens rarely and only with AMD APP SDK (both 2.9.1 and 3.0) on Travis CI (I have an Intel CPU like Travis CI and I wasn't able to reproduce on my PC.) and only on the second ctest --output-on-failure run. I might be AMD APP SDK issue. I'll investigate it.
32/165 Test  #32: algorithm.find_end ...................***Failed    0.17 sec
test_find_end: /home/travis/build/haahh/compute/test/test_find_end.cpp:60: void compute_test::find_end_string::test_method(): Assertion `iter == vectort.begin() + 15' failed.
Running 2 test cases...
unknown location(0): fatal error in "find_end_string": signal: SIGABRT (application abort requested)

Examples:

https://travis-ci.org/boostorg/compute/jobs/112436799 (develop)
https://travis-ci.org/haahh/compute/jobs/112264011#L7337

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/31409709-find_end-randomly-fails-with-sigabrt-on-travis-ci?utm_campaign=plugin&utm_content=tracker%2F402515&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F402515&utm_medium=issues&utm_source=github).

Fixed by https://github.com/boostorg/compute/pull/597.


Re-order molid before merging molecules

A simple fix for #76: the assertion was documented but not checked by all the callers, I changed merge_molecule to reorder molid as it need.

Looks good to me. Can you check the example (i cannot add a comment at that line) in the function documentation?
     /// H-H  H-H  H-H  H-H
     /// 0 1  2 3  4 5  6 7
     /// ```
     /// and call `merge_molecules(0, 2)` the result will be

Should this be merge_molecules(0, 3)?

Should this be merge_molecules(0, 3)?

Yes, nice catch.

Merged. 👍


refactor sampling method

Sampling method currently relies on a summary data structure that is not reversible.
When using optimistic PDES, sample will occur at commit time.
During the commit interval, tracing should collect data, which can be easily reversible.

This is addressed in PR #28
Events processed are kept until fossil collection time (commit time), and that is the point where both sampling and tracing is done.


Converted uploadFile to stream the contents, accept resource or string

I ran into an issue saying "400 Bad Request" with no message, when trying to upload .cr2-raw files. Renaming them to .jpg worked.
After a whole lot of debugging and research, I found a thread on Amazon's forum, specificing how the multipart should look;
https://forums.developer.amazon.com/forums/thread.jspa?messageID=21591&#21591
So this PR covers that.
During this, I also converted uploadFile to take either a resource or a path, and I'm using stream_get_meta_data to get the path of the stream if it's a stream. I'm also creating the stream early on, since it's being converted on at least two places (Node::overwrite() and CloudDrive->nodeExists()) to streams anyway.
This means that the recent, accepted PR of the streams-branch is kinda obsolete, but I kept the uploadStream()-method in, but converted it to just call uploadFile, so we have nice backwards compatibility.

I was in a hurry earlier, I branched to a feature-branch instead and closed the other PR.

This looks fine to me as far as the streams support.


CASMTRIAGE-5077 set environment variables before master node rebuild

Description
Set environment variables before master node rebuild. Specifically setting CSM_RELEASE,  CSM_REL_NAME, and CSM_ARTI_DIR

Checklist

[x] If I added any command snippets, the steps they belong to follow the prompt conventions (see example).
[x] If I added a new directory, I also updated .github/CODEOWNERS with the corresponding team in Cray-HPE.
[x] My commits or Pull-Request Title contain my JIRA information, or I do not have a JIRA.

/backport release/1.4


Icon Request: Gemfile n' gemspec

Current icons for Gemfile and *.gemspec look like this:

As you see, Gemfile n' *.gemspec has no icon at all. However, Gemfile.lock has ruby file icon, even if it's not ruby file.
Checklist:

Visual Studio Code version [1.5.1] [Stable]
vscode-icons extension version [2.0.5]
System: [Windows] [x64]
[x] I've regarded to the FAQ and they did not help.
[x] I'm sure this issue is not a duplicate?
[x] I want to create an icon request
- Type: [file]
- Icon Name: [ruby-gem]
- Sample original Icon: [https://rubygems.org/favicon.ico]
- Extensions: Gemfile, Gemfile.lock, *.gemspec

Gemfile and Gemfile.lock are in Bundler spec [reference]
So, please use this icon [http://ruby-korea.github.io/bundler-site/images/gembundler.png] for those file.
Sorry about that mistake.

I missed the bundler icon in the last PR.


Changing status filter to radio buttons

As in the title. The filter now looks like this; I think this one is more understandable and also passes the tests:

Oh... ouch; now I see you have progressed since then. Not urgent now; let me know what you think.

Superseeded by #590 as requested by the Student Council


test: reduce pod and communication dependencies

Description

Closes #42

Added offline utilities for doing smoke tests, that should also help with developing agents offline.
Refactored old utils for the sake of import consistency.
Rebuilt any test that depended on communication and scrubbed most all pytest xfail on timeouts.
Updated requirements. Specifically databroker V2 was always a requirement for agents.base.BaseAgent, but not in the requirements.txt.
Moved the BlueskyConsumer in adjudicators from an inheritance to an attribute. This will allow flexibility with other message busses, and makes testing less Kafka dependent.

Motivation and Context

Test suite was taking way too long, and fairly brittle. Tests should in general take less than 1 second to run.
Summary of Changes for Release Notes

Fixed
Added
Offline utilities for Kafka, QueueServer,  Agents, Adjudicators
Changed
Moved databroker V2 to main requirements.
Removed
Test suite dependence on containers outside the tests that test communication specifically.
How Has This Been Tested?

Pytest.

Tests now take less time than installing dependencies. :D

Is there a case for installing "dev" without "agents"?  If not, consider adding ".[agents]" into "requirements-dev.txt".
I installed ".[dev]" and pytest failed because of missing torch, scikit-learn dependencies.

My thought there was mostly based on my development cycle, and the expense of putting the .[agents] into an env.
If I'm building a new feature (e.g., an agent in jax or new base features), I only run the tests that I expect to be effected, or the ones I have written to test the new feature.
But the CI/CD has to test everything. Let me know if this is not best practice.


Thumbnail support for image gallery

Displays image thumbnails in a lightbox window. Example included and documentation updated for this feature.

In the example, you have used the same gallery name multiimages which already exists on the page. If you rename it - which you should as it's a separate gallery - the previews fail. This is because the gallery specifically looks for data-toggle="lightbox" when looking for @gallery_items.
See: https://github.com/ashleydw/lightbox/blob/master/ekko-lightbox.coffee#L78
I would rename the option to something smaller like thumbnail or preview and then you can allow the user to set the option via a data attribute - this would remove the need for the lightbox-preview toggle.
How about moving the thumbnails to the bottom? When viewing a wide but short image, it looks a bit messy:

Hi! I made the changes you suggested:

added preview option via data attribute
Moved preview area to the bottom of the lightbox window

Great! If you squash your commits, I'll merge it in and get a new version going


Cli

I inadvertently merged this into the updateTests branch that Diane has reviewed that'll be merged into the predict_testing branch tomorrow. I made one minor change to it adding back in the loadfile`:code/tests/utils.q logic otherwise I would have merged in as above.


Remove activation event trigger.

Hiya all!! PR for catering a discussion here: https://github.com/Azure/vscode-aks-tools/issues/1052#issuecomment-2492569898

This could help resolve the every new release to have walkthrough thing now, because it could be that new release has nothing but fixes which are non superficial. Thoughts everyone please? (please feel free to add)

Thanks heaps. @joybb , @qpetraroia
VSIX here please:
vscode-aks-tools-1.5.2-test-remove-automatic.vsix.zip

I like this idea. Tested VSIX on my end.


Could not resolve "fastly:experimental" when importing fastly:experimental

What version of Hono are you using?
3.12.16
What runtime/platform is your app running on?
Fastly
What steps can reproduce the bug?
Adding import { allowDynamicBackends } from "fastly:experimental";  and calling allowDynamicBackends(true); yields
✘ [ERROR] Could not resolve "fastly:experimental"

    src/index.ts:6:37:
      6 │ import { allowDynamicBackends } from "fastly:experimental";

What is the expected behavior?
A clean compile
What do you see instead?
✘ [ERROR] Could not resolve "fastly:experimental"

    src/index.ts:6:37:
      6 │ import { allowDynamicBackends } from "fastly:experimental";
        ╵                                      ~~~~~~~~~~~~~~~~~~~~~

  You can mark the path "fastly:experimental" as external to exclude it from the bundle, which will remove this error.

Error: Build failed with 1 error:
src/index.ts:6:37: ERROR: Could not resolve "fastly:experimental"

Additional information
I'm able to use regular fastly functions, such as ConfigStore without importing it.
One side-effect of not being able to import fastly, I'm also unable to access Context.client.address.
Stuff like this also gives an error:

                 console.log("test:", c._exCtx.client.address)
                  console.log("test2:", c.executionCtx.client.address)

My package.json
{
  "scripts": {
    "dev": "fastly compute serve --watch",
    "prebuild": "node ./build.js",
    "build": "js-compute-runtime bin/index.js bin/main.wasm",
    "deploy": "fastly compute publish"
  },
  "devDependencies": {
    "esbuild": "^0.17.12"
  },
  "dependencies": {
    "@fastly/js-compute": "^3.7.0",
    "hono": "^3.12.6"
  }
}

Setting   external: ['fastly:*'] in build.js seems to fix this.


Serve signed packages on the cache

See https://github.com/NixOS/nix/issues/75#issuecomment-71452041, Hydra already signs packages, so the cache would need to copy the signatures and make signatures for already-made packages.

:+1:

@edolstra @ikwildrpepper is there any way to help move this forward?
On Thu, Feb 5, 2015, 7:15 AM Daniel Peebles<EMAIL_ADDRESS>wrote:

[image: :+1:]
—
Reply to this email directly or view it on GitHub
https://github.com/NixOS/nixos-org-configurations/issues/8#issuecomment-72999715
.

@rbvermaa :-)

Just patience, I believe @edolstra is busy with this.

Done.

Whee!
On Thu, Jun 4, 2015, 1:14 PM Eelco Dolstra<EMAIL_ADDRESS>wrote:

Closed #8 https://github.com/NixOS/nixos-org-configurations/issues/8.
—
Reply to this email directly or view it on GitHub
https://github.com/NixOS/nixos-org-configurations/issues/8#event-322367296
.


how browser get favicon?

Hi,thx very much for this project. I have a question about how  browser gets favicon.ico?
I did not see server-favicon or app.use(favicon(...)) anywhere.
In server/main.js, i find these code works for favicon.
app.use(express.static(path.resolve(project.basePath, 'public')))
app.use('*', function (req, res, next) {
    const filename = path.join(compiler.outputPath, 'index.html')
    compiler.outputFileSystem.readFile(filename, (err, result) => {
      if (err) {
        return next(err)
      }
      res.set('content-type', 'text/html')
      res.send(result)
      res.end()
    })
  })

but i don't konw how it works .Could u get a explanation? thx very much!

I find this FQA at https://stackoverflow.com/questions/35408729/express-js-prevent-get-favicon-ico . maybe is the answer！


[cmd] Mapping coding guidelines to checkers

CodeChecker checkers --details command now prints which coding
guidelines are checked by a specific checker. A new filtering option
named --guideline has been introduced where a guideline name or a rule
identifier can be given. The mapping is described in
config/checker_guideline_map.json.

 Here is an overview of what got changed by this pull request:

Complexity increasing per file
==============================
- analyzer/tests/functional/cmdline/test_cmdline.py  3
- analyzer/codechecker_analyzer/cmd/checkers.py  6
- analyzer/codechecker_analyzer/analyzer_context.py  1

See the complete overview on Codacy

This output format is pretty raw and this is for human (and not machine) consumption:

unix.Malloc                                                    clangsa    MEDIUM      {'sei-cert': ['mem30-c', 'mem31-c', 'mem34-c']}                                                                           Check for memory leaks, double free, and use-after-free problems. Traces memory managed by malloc()/free().

Add some formatting to it e.g.:
Related sei-cert coding guideline rules: mem30-c, mem31-c, mem34-c

./build/CodeChecker/bin/CodeChecker checkers --guideline
(without extra argument) should list the available guidelines and all of its rules.
Then the user knows what to select from.
I can imagine cpp-coreguidelines to be added in the future.

I suggest to implement the option to enable coding guidelines directly:
CodeChecker analyze ... -e guideline:sei-cert
we should use the prefix guideline for guidelines
we should use the prefix profile for profiles

 Here is an overview of what got changed by this pull request:

Complexity increasing per file
==============================
- analyzer/tests/functional/cmdline/test_cmdline.py  3
- analyzer/codechecker_analyzer/cmd/checkers.py  13
- analyzer/codechecker_analyzer/analyzer_context.py  1

Clones removed
==============
+ analyzer/codechecker_analyzer/analyzer_context.py  -1

See the complete overview on Codacy

@dkrupp I fixed the pull request according to your comments except for enabling checkers with guideline: prefix. This will be the part of #2383.

 Here is an overview of what got changed by this pull request:

Complexity increasing per file
==============================
- analyzer/tests/functional/cmdline/test_cmdline.py  3
- analyzer/codechecker_analyzer/cmd/checkers.py  14
- analyzer/codechecker_analyzer/analyzer_context.py  1

Clones removed
==============
+ analyzer/codechecker_analyzer/analyzer_context.py  -1

See the complete overview on Codacy

 Here is an overview of what got changed by this pull request:

Complexity increasing per file
==============================
- analyzer/tests/functional/cmdline/test_cmdline.py  2
- analyzer/codechecker_analyzer/cmd/checkers.py  14
- analyzer/codechecker_analyzer/analyzer_context.py  1

Clones removed
==============
+ analyzer/codechecker_analyzer/analyzer_context.py  -1

See the complete overview on Codacy

 Here is an overview of what got changed by this pull request:

Complexity increasing per file
==============================
- analyzer/tests/functional/cmdline/test_cmdline.py  2
- analyzer/codechecker_analyzer/cmd/checkers.py  14
- analyzer/codechecker_analyzer/analyzer_context.py  1

Clones removed
==============
+ analyzer/codechecker_analyzer/analyzer_context.py  -1

See the complete overview on Codacy

 Here is an overview of what got changed by this pull request:

Complexity increasing per file
==============================
- analyzer/tests/functional/cmdline/test_cmdline.py  2
- analyzer/codechecker_analyzer/cmd/checkers.py  14
- analyzer/codechecker_analyzer/analyzer_context.py  1

Clones removed
==============
+ analyzer/codechecker_analyzer/analyzer_context.py  -1

See the complete overview on Codacy

 Here is an overview of what got changed by this pull request:

Complexity increasing per file
==============================
- analyzer/tests/functional/cmdline/test_cmdline.py  3
- analyzer/codechecker_analyzer/cmd/checkers.py  14
- analyzer/codechecker_analyzer/analyzer_context.py  1

Clones removed
==============
+ analyzer/codechecker_analyzer/analyzer_context.py  -1

See the complete overview on Codacy

 Here is an overview of what got changed by this pull request:

Complexity increasing per file
==============================
- analyzer/tests/functional/cmdline/test_cmdline.py  3
- analyzer/codechecker_analyzer/cmd/checkers.py  14
- analyzer/codechecker_analyzer/analyzer_context.py  1

Clones removed
==============
+ analyzer/codechecker_analyzer/analyzer_context.py  -1

See the complete overview on Codacy

Tests are now passing except for osx because of clang installation...

 Here is an overview of what got changed by this pull request:

Complexity increasing per file
==============================
- analyzer/tests/functional/cmdline/test_cmdline.py  3
- analyzer/codechecker_analyzer/cmd/checkers.py  16
- analyzer/codechecker_analyzer/analyzer_context.py  1

Clones removed
==============
+ analyzer/codechecker_analyzer/analyzer_context.py  -1

See the complete overview on Codacy

 Here is an overview of what got changed by this pull request:

Complexity increasing per file
==============================
- analyzer/tests/functional/cmdline/test_cmdline.py  3
- analyzer/codechecker_analyzer/cmd/checkers.py  16
- analyzer/codechecker_analyzer/analyzer_context.py  1

Clones removed
==============
+ analyzer/codechecker_analyzer/analyzer_context.py  -1

See the complete overview on Codacy


1.15.0

Updated README to reflect 1.15.0
Added logging functions to SYM
Functions inside SYM have been rearranged to work with new logging functions

Thanks for doing this, Rob …
… I never knew logs could look soooo goooood!


Can't compile on Linux

Hey,
I'm trying to build a simple Kitura project (based on the starter guide) within the 'ibmcom/kitura-ubuntu:latest' Docker container. Within macOS, everything compiles fine, on Linux, however, I get the following error:
Compile Swift Module 'POSIX' (11 sources)
/root/testcsp/.build/debug/CHTTPParser.build/module.modulemap:2:14: error: umbrella directory '/root/testcsp/Packages/CHTTPParser-0.14.0/Sources/include' not found
    umbrella "/root/testcsp/Packages/CHTTPParser-0.14.0/Sources/include"
             ^
/root/testcsp/.build/debug/CHTTPParser.build/module.modulemap:2:14: error: umbrella directory '/root/testcsp/Packages/CHTTPParser-0.14.0/Sources/include' not found
    umbrella "/root/testcsp/Packages/CHTTPParser-0.14.0/Sources/include"
             ^
/root/testcsp/.build/debug/CHTTPParser.build/module.modulemap:2:14: error: umbrella directory '/root/testcsp/Packages/CHTTPParser-0.14.0/Sources/include' not found
    umbrella "/root/testcsp/Packages/CHTTPParser-0.14.0/Sources/include"
             ^
Compile CLibvenice dns.c
/root/testcsp/.build/debug/CHTTPParser.build/module.modulemap:2:14: error: umbrella directory '/root/testcsp/Packages/CHTTPParser-0.14.0/Sources/include' not found
    umbrella "/root/testcsp/Packages/CHTTPParser-0.14.0/Sources/include"
...

I'm just running
swift build
What am I doing wrong?
Cheers,
Benedikt

@terhechte Looks like a similar issue to the one here: https://github.com/IBM-Swift/Kitura/issues/822#issuecomment-262602964
Have you tried deleting the .build folder and then running swift build again?

@terhechte From the messages in your compile it would seem that you are not trying to build a Kitura project, but rather a Zewo project. Kitura never used libvenice nor did ever have a CHTTPParser repository tagged at 0.14.
Can you please post your Package.swift file?

Sorry. I managed to find the culprit. My build script (which automatically starts up a docker with the correctly mounted folder, etc) was accidentally referencing the wrong folder. Everything is working fine now. Thanks for writing all this awesome code.


Can not add data to Excel data where column contains / in their name

Describe the Bug with repro steps
Full repro steps here: Bug 28938461: [v3] [LAUX] Can not add data to Excel data where column contains / in their name
What type of Logic App Is this happening in?
Consumption (Portal)
Are you using new designer or old designer
New Designer
Did you refer to the TSG before filing this issue? https://aka.ms/lauxtsg
Yes
Workflow JSON
No response
Screenshots or Videos
No response
Browser
Chrome
Additional context
No response

I'm not able to repro this at all in Logic Apps using Azure portal. Everything works as expected. I suspect something is going on in the PA Host side to cause this.


Massive UI Improvement Concept

          @Garsondee Well, good sir, that's something I can help with! I'm a solution architect in my day job, so collaborating on the design and UX of things for programmers to make manifest IS something I can do. :)

Here's a quick wireframe I threw together in Balsamiq. It's rough, but I think it covers some big ideas and current layout challenges.
Like I said, the central design approach you present is great - it's quick, graphic, and self-explanatory. I knew how to use it just by looking at it, from both the GM and Player sides. That's HUGE! Auto-closing the roll display that you introduced this past release nailed the only real pain point I had; the exit button was getting forgot by players and would cause it to get stuck if another roll request came through while it was still up...
The ambitiousness of the actions and search you included really inspired me as well, but this is a full vision concept that you're likely going to want to break apart into 3 or more milestones of functionality. Let me know if you have any questions! I am doing a bit more research before I tackle the follow the expert impacts, if any, to this.
Note: The Untrained --> Master buttons would all have the names on them. I got sloppy with it. :) Basically the idea is whatever adjustment "DC range increments" are being shown would have the name and number on each button. It would be more compact to leave just the number or just the word, but for me this is one of the key examples of how your design made it so accessible to me as a new GM. It's enough to help, but it really doesn't take up enough space where I'm mad at it being there as I get comfortable with it.
Maybe settings to hide the title / number down the road because not everyone will be happy, but as-is for defaults for sure imo.
Note 2: The All button toggles between Select all if 0 to all but one characters (N-1) are selected, and Clear All if all characters (N) is selected
Originally posted by @Truncated in https://github.com/Garsondee/pf2e-roll-manager/issues/46#issuecomment-2214505714

Hey guys, I really like this module, but I'd also like to add some UX related requests.  Rarely a session goes by without me referencing the Level Based DC chart (https://2e.aonprd.com/Rules.aspx?ID=2629&Redirected=1) and the basic DC chart.
Is there any way the UI could be enhanced to include some ability to pick DC by level(Or add some detents to the DC adjustment slider bar for quick reference?).  What you've done with the Basic DC's is really nice and easy to use, and something like that to roll up the level/spell rank DC's into referenceable or selectable elements would be awesome and essentially avoid the need for a GM to cross reference that chart entirely during play.


focused button

Pressing tab should inform the user which button is focused.

Which kind of user informing do you mean? There's the outline for buttons.

hmm my bad, same color for outline and button tricked me

Yeah, default color for the outline in Chrome/Safari is blue, which is almost similar to the Confirm button color.
In Firefox/IE/Edge there's default dotted outline for buttons


Add missing dependencies to package.json

Add specific references to these packages in package.json so that npm install works in npm 2:

broccoli-stew
exists-sync

THANK YOU!!

Woohoo!


[GDExtension] Expose some low level functions and String operators.

Exposes some low level functions (for XMLParser, FileAccess, WorkThreadPool, and String) used by TextServer, for better performance and portability.
Renames some internal C++ functions to match GDScript/GDExtension names.
godot-cpp side counterpart - https://github.com/godotengine/godot-cpp/pull/939

I don't have a strongly formed opinion but it seems a bit weird to me that we'd need to start exposing methods like this for an arbitrary set of core classes. It seems to break encapsulation somewhat and raises the question of which criteria should we use to decide what gets to be exposed in gdextension_interface.h.
As seen in the godot-cpp counterpart https://github.com/godotengine/godot-cpp/pull/939 these new methods are exposed via a low_level.cpp translation unit, which seems pretty arbitrary and might eventually grow a lot if many more such methods are needed as more advanced modules get converted to extensions.
I'm not saying this isn't the right solution - just voicing this gut feeling for further discussion on what the potential solutions can be.

Thanks!

This is already merged but I share @akien-mga concerns. IMO this struct should be changed rarely (if ever) since changing it breaks ABI (except adding things at the end but that also has versioning issues).
For instance, I don't see why String needs a special += operator function, especially since String is supposed to be immutable. Why couldn't it be implemented as *this = *this + p_other in godot-cpp? Sure it's slower but String concatenation shouldn't be perceived as a fast operation anyway.
If anything, we could consider adding a new discovery API for low-level functions so those can also be properly versioned without having to bind them to existing registries.


Is there a way to fallback to icon instead of brokenImage?

In our project we use webfont icons for the nodes, but some nodes can also use custom images and with images some can have the problem of not loading. For this problem there is the field brokenImage, but in our case we don't have images but webfont icons we would like to show incase the custom image does not load.
So is there a way to fall back to the icon instead of the brokenImage?
i tried to set both image and icon, but this did not work (i guess this is because they use different node shapes).

Yeah, sadly the broken image is a feature of the image shape. There's no way to switch from one shape to another unless, of course, you want to do it manually.

Thanks for the reponse, thought that would be the case.


cannot import name 'HTTPResponse' from 'mitmproxy.http'

Problem Description
hi gyse, i`m usage pymultitor, and have
Traceback (most recent call last):
File "C:\Users\User\Desktop\pymultitor-3.1\pymultitor.py", line 14, in
from mitmproxy.http import HTTPResponse
ImportError: cannot import name 'HTTPResponse' from 'mitmproxy.http' (C:\Users\User\Python\lib\site-packages\mitmproxy\http.py)
Steps to reproduce the behavior:

System Information
Paste the output of "mitmproxy --version" here.

Mitmproxy: 8.1.1
Python:    3.10.5
OpenSSL:   OpenSSL 3.0.5 5 Jul 2022
Platform:  Windows-10-10.0.22000-SP0

Unless you can provide steps to reproduce this with just mitmproxy, then this is an issue with pymultitor https://github.com/realgam3/pymultitor/issues/33


Improve README

Current we have just the bare minimum README.md file, which also has a couple of typos.  We should flesh it out a bit with instructions on how to use the docker image created by this repo.

@brianmacy wanted to chime in on this README as it also shows up at https://hub.docker.com/r/senzing/senzingapi-runtime

PR merged


Missing getAccountStatement()

In this version, I miss getAccountStatement() function to call this: https://doc.gopay.com/cs/#generování-výpisu-obchodního-účtu

It look's pretty simple to implement it, would you try it?

Working on it.

Well, not as easy as it looks on the first sight. API call /accounts/account-statement returns application/octet-stream
When called, the Markette\GopayInline\Http\Response does not contain the content of the file, just headers. Any idea how to fix this and not break everything else?

Mmm. Can you check return header/content-type?
https://github.com/Markette/GopayInline/blob/master/src/Http/Curl.php#L34-L44

 object(Markette\GopayInline\Http\Response)#94 (4) {   ["data":protected]=>   NULL   ["headers":protected]=>   array(26) {     ["url"]=>     string(52) "https://gate.gopay.cz/api/accounts/account-statement"     ["content_type"]=>     string(24) "application/octet-stream"     ["http_code"]=>     int(200)     ["header_size"]=>     int(598)     ["request_size"]=>     int(379)     ["filetime"]=>     int(-1)     ["ssl_verify_result"]=>     int(0)     ["redirect_count"]=>     int(0)     ["total_time"]=>     float(0.232824)     ["namelookup_time"]=>     float(3.1E-5)     ["connect_time"]=>     float(0.008602)     ["pretransfer_time"]=>     float(0.039469)     ["size_upload"]=>     float(101)     ["size_download"]=>     float(60416)     ["speed_download"]=>     float(259492)     ["speed_upload"]=>     float(433)     ["download_content_length"]=>     float(-1)     ["upload_content_length"]=>     float(101)     ["starttransfer_time"]=>     float(0.224169)     ["redirect_time"]=>     float(0)     ["redirect_url"]=>     string(0) ""     ["primary_ip"]=>     string(13) "<IP_ADDRESS>"     ["certinfo"]=>     array(0) {     }     ["primary_port"]=>     int(443)     ["local_ip"]=>     string(13) "<IP_ADDRESS>"     ["local_port"]=>     int(40482)   }   ["code":protected]=>   int(200)   ["error":protected]=>   NULL }
The problem is in line
https://github.com/Markette/GopayInline/blob/master/src/Http/Curl.php#L41
$result contains binary content of the file (xls/abo or csv).
json_decode($result) then makes it NULL.

My idea is to rewrite  https://github.com/Markette/GopayInline/blob/master/src/Http/Curl.php#L40-44 to:
} else {
$response->setCode(curl_getinfo($ch, CURLINFO_HTTP_CODE));
$response->setHeaders(curl_getinfo($ch));
$info = curl_getinfo($ch);
if($info['content_type'] == 'application/json') {
    $response->setData(json_decode($result));
} else {
    $response->setData($result);
}
What do you say?
}

Nice idea, that's what I was thinking about. Could we also check application/octet-stream content type? Just for sure.

So like this?
if($info['content_type'] == 'application/json') {
$response->setData(json_decode($result));
} elseif($info['content_type'] == 'application/octet-stream' {
$response->setData($result);
} else {
$response->setData($result);
}

At this moment we had just application/json. Your plan is to add a application/octet-stream. And I would like to throw an exception if neight of these conditions is mached. Do you agree or do you think it's pointless?

I wouldn't throw an Exception as it poses a risk of breaking things, that currently work (we would have to check that all the current calls do return application/json correctly to be sure). Saying this, I would restate my suggestion to this:
if($info['content_type'] == 'application/octet-stream') {
    $response->setData($result);
} else {
    $response->setData(json_decode($result));
}

This way we make sure, that everything works exactly as now (and we don't break something by accident), with the exception of application/octet-stream that has newly added behaviour.

Ouk.

Resolved via #25


upstream: fix oss-fuzz issue #11095.

Description:
Fix a crash found by oss-fuzz (see https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=11095). The bug is caused by trying to request IP information from a unix domain socket address.
Risk Level: low
Testing: local fuzzing and a regression test for HostDescriptionImpl constructor

Makes sense. I added a patch which does that.

@ipuustin LGTM, but needs DCO fix https://github.com/envoyproxy/envoy/blob/master/CONTRIBUTING.md#fixing-dco

/retest

@htuch Sure, I can help with them. There's also still a bunch of already open ones in the fuzzer backlog.


fix postgres tests

not sure what you mean....the visualizer env is there:
https://github.com/igorbernstein/luigi/blob/fix-postgres-tests/.travis.yml#L31

also: https://travis-ci.org/spotify/luigi/jobs/92587989

hmm not sure why the visualizer env is failing on class parameter tests now...investigating

oops, I see what you mean...I screwed up with the original rebase :(

@igorbernstein no worries, it's Sunday :)

yep, it was misplaced...its used by nose to select which tests to run & needs to go on the test itself not on the luigi task

I think I put the attr() annotation there and I can confirm that I had no idea what I was doing. :)
LGTM.
As a follow up PR, you might want to look at this. :)

:+1: Nice work!


Vote in new maintainer volunteers for distribution-spec

We've had a great set of active volunteers to become maintainers on the distribution spec:

[ ] @jonjohnsonjr [Google]: https://github.com/opencontainers/tob/issues/95#issuecomment-811522802
[ ] @ImJasonH [Red Hat]: https://github.com/opencontainers/tob/issues/95#issuecomment-812609220
[ ] @SteveLasker [Microsoft]: https://github.com/opencontainers/tob/issues/95#issuecomment-818837736
[ ] @rchincha [Cisco?]: https://github.com/opencontainers/tob/issues/95#issuecomment-818968500
[ ] @amouat [Container Solutions]: https://github.com/opencontainers/tob/issues/95#issuecomment-819372249

The next step in the process after the call for volunteers is to initiate a PR and vote by the existing @opencontainers/distribution-spec-maintainers to add them as official maintainers, this will be done on a one by one basis: https://github.com/opencontainers/distribution-spec/blob/main/MAINTAINERS

All the votes for the volunteers have been kicked off:
https://github.com/opencontainers/distribution-spec/pull/267
https://github.com/opencontainers/distribution-spec/pull/268
https://github.com/opencontainers/distribution-spec/pull/269
https://github.com/opencontainers/distribution-spec/pull/270
https://github.com/opencontainers/distribution-spec/pull/271
The @opencontainers/distribution-spec-maintainers will just need to provide LGTMs in the coming week

hrm, this seems a confusing format :thinking:

sorry, i'm just pondering on the voting logistics. If maintainers get a 2/3 approval, then their addition would shift the votes needed for other's 2/3 approval.
Also, I'm curious if there is a particular goal for number of maintainers for distribution-spec, as the current maintainers are already active.

@vbatts I figured it was fairer than doing all at once, we can leave things open for a week and close them all the same time (if everyone passes)

I am voting to reject all the new maintainers at this time. These are my reasons:

each candidate deserves to be considered individually rather than as a group
the distribution-spec does not have an issue with inactive maintainers which requires such an intervention
making a large change which impacts voting right before release 1.0 is not a good idea in my view

I look forward to discussing each candidate and proposing them individually after we finish the 1.0 release. Having a dedicated group of maintainers who are focused on preserving the stability of 1.x is important and I am happy to have those discussions about bringing individuals in. Normally maintainers will have time to discuss candidates before opening a PR to add them into the maintainers file. This allows maintainers to have conversations with candidates about what the maintainer expectations are and when it is a good time to become a maintainer. This prevents maintainers from having to openly reject candidates when the timing or fit just isn't there yet. In this case, I don't think it is fair to accept some and reject others, so I am rejecting not based on any individual, but on the process.

we can leave things open for a week

Any objection to closing PRs 267-271? I agree with @dmcgowan that the distribution-spec doesn't need any kind of intervention.

closing for now


Not working for Angular 6+ version

It is showing rxjs issue due to the path of
import { Observable } from 'rxjs/Observable';
import { merge } from 'rxjs/observable/merge';
import { share } from 'rxjs/operator/share';
import { Subject } from 'rxjs/Subject';
can you please update it for version 6+?

Same here. I'm looking forward to find a replacement to this that works but no luck until now.

Going to node_modules\angular-io-slimscroll\package.json and changing the dependencies to match the ones in my project's package.json made it work. Not elegant, but makes it work.