Unable to pull image from Insecure Registry on GKE

I have a GKE cluster with containerd as the Container Runtime. I have a insecure registry that is running on a IP.
I have added that IP in all GKE nodes in /etc/hosts that corresponds to a domain, and the same domain is used to push images. e.g. my.registry.domain
But K8s is unable to pull images and gives error
Failed to pull image "my.registry.domain/IMAGE_NAME:IMAGE_TAG": rpc error: code = Unknown desc = failed to resolve image "my.registry.domain/IMAGE_NAME:IMAGE_TAG": no available registry endpoint: failed to do request: Head https://my.registry.domain/IMAGE_NAME:IMAGE_TAG: x509: certificate signed by unknown authority

Below is my /etc/containerd/config.toml
# Kubernetes doesn't use containerd restart manager.
disabled_plugins = ["restart"]
oom_score = -999

[debug]
  level = "info"

[grpc]
  gid = 412

[plugins.cri]
  stream_server_address = "<IP_ADDRESS>"
  max_container_log_line_size = 262144
[plugins.cri.cni]
  bin_dir = "/home/kubernetes/bin"
  conf_dir = "/etc/cni/net.d"
  conf_template = ""
[plugins.cri.registry.mirrors."docker.io"]
  endpoint = ["https://mirror.gcr.io","https://registry-1.docker.io"]
[plugins.cri.registry.configs."my.registry.domain".tls]
  insecure_skip_verify = true

And output of crictl info
{
  "status": {
    "conditions": [
      {
        "type": "RuntimeReady",
        "status": true,
        "reason": "",
        "message": ""
      },
      {
        "type": "NetworkReady",
        "status": true,
        "reason": "",
        "message": ""
      }
    ]
  },
  "config": {
    "containerd": {
      "snapshotter": "overlayfs",
      "defaultRuntime": {
        "runtimeType": "io.containerd.runtime.v1.linux",
        "runtimeEngine": "",
        "PodAnnotations": null,
        "runtimeRoot": "",
        "options": null
      },
      "untrustedWorkloadRuntime": {
        "runtimeType": "",
        "runtimeEngine": "",
        "PodAnnotations": null,
        "runtimeRoot": "",
        "options": null
      },
      "runtimes": null,
      "noPivot": false
    },
    "cni": {
      "binDir": "/home/kubernetes/bin",
      "confDir": "/etc/cni/net.d",
      "confTemplate": ""
    },
    "registry": {
      "mirrors": {
        "docker.io": {
          "endpoint": [
            "https://mirror.gcr.io",
            "https://registry-1.docker.io"
          ]
        }
      },
      "auths": null
    },
    "streamServerAddress": "<IP_ADDRESS>",
    "streamServerPort": "0",
    "enableSelinux": false,
    "sandboxImage": "k8s.gcr.io/pause:3.1",
    "statsCollectPeriod": 10,
    "systemdCgroup": false,
    "enableTLSStreaming": false,
    "x509KeyPairStreaming": {
      "tlsCertFile": "",
      "tlsKeyFile": ""
    },
    "maxContainerLogSize": 262144,
    "disableProcMount": false,
    "containerdRootDir": "/var/lib/containerd",
    "containerdEndpoint": "/run/containerd/containerd.sock",
    "rootDir": "/var/lib/containerd/io.containerd.grpc.v1.cri",
    "stateDir": "/run/containerd/io.containerd.grpc.v1.cri"
  },
  "golang": "go1.11.2"
}

It is unable to pull image, I even tried to pull manually by running
crictl pull my.registry.domain/IMAGE_NAME:IMAGE_TAG
FATA[0000] pulling image failed: rpc error: code = Unknown desc = failed to resolve image "my.registry.domain/IMAGE_NAME:IMAGE_TAG": no available registry endpoint: failed to do request: Head my.registry.domain/IMAGE_NAME:IMAGE_TAG: x509: certificate signed by unknown authority

Is there anything I am missing or is this a bug?

version of containerd?
Config looks old.
Did you want to use http or https?

if you want insecure http... try this:
[plugins.cri.registry.mirrors."docker.io"]
  endpoint = ["https://mirror.gcr.io","https://registry-1.docker.io"]
[plugins.cri.registry.mirrors."my.registry.domain"]
  endpoint = ["http://my.registry.domain"]
#[plugins.cri.registry.configs."my.registry.domain".tls]
#  insecure_skip_verify = true

containerd github.com/containerd/containerd 1.2.8 a4bc1d432a2c33aa2eed37f338dceabb93641310
I want to use http

Added above and restarted containerd service, still same error
Output of crictl info
{
  "status": {
    "conditions": [
      {
        "type": "RuntimeReady",
        "status": true,
        "reason": "",
        "message": ""
      },
      {
        "type": "NetworkReady",
        "status": true,
        "reason": "",
        "message": ""
      }
    ]
  },
  "config": {
    "containerd": {
      "snapshotter": "overlayfs",
      "defaultRuntime": {
        "runtimeType": "io.containerd.runtime.v1.linux",
        "runtimeEngine": "",
        "PodAnnotations": null,
        "runtimeRoot": "",
        "options": null
      },
      "untrustedWorkloadRuntime": {
        "runtimeType": "",
        "runtimeEngine": "",
        "PodAnnotations": null,
        "runtimeRoot": "",
        "options": null
      },
      "runtimes": null,
      "noPivot": false
    },
    "cni": {
      "binDir": "/home/kubernetes/bin",
      "confDir": "/etc/cni/net.d",
      "confTemplate": ""
    },
    "registry": {
      "mirrors": {
        "my.registry.domain": {
          "endpoint": [
            "http://my.registry.domain"
          ]
        },
        "docker.io": {
          "endpoint": [
            "https://mirror.gcr.io",
            "https://registry-1.docker.io"
          ]
        }
      },
      "auths": null
    },
    "streamServerAddress": "<IP_ADDRESS>",
    "streamServerPort": "0",
    "enableSelinux": false,
    "sandboxImage": "k8s.gcr.io/pause:3.1",
    "statsCollectPeriod": 10,
    "systemdCgroup": false,
    "enableTLSStreaming": false,
    "x509KeyPairStreaming": {
      "tlsCertFile": "",
      "tlsKeyFile": ""
    },
    "maxContainerLogSize": 262144,
    "disableProcMount": false,
    "containerdRootDir": "/var/lib/containerd",
    "containerdEndpoint": "/run/containerd/containerd.sock",
    "rootDir": "/var/lib/containerd/io.containerd.grpc.v1.cri",
    "stateDir": "/run/containerd/io.containerd.grpc.v1.cri"
  },
  "golang": "go1.11.2"
}

same error as above for crictl pull my.registry.domain/IMAGE_NAME:IMAGE_TAG

same error? it said trying https? on my.registry.domain?

old release though fixes went in for insecure registry support between 1.2.8 and 1.3.latest and still more in 1.4...

did you restart containerd?

Yes I restarted containerd by running systemctl restart containerd
Got https again
FATA[0000] pulling image failed: rpc error: code = Unknown desc = failed to resolve image "my.registry.domain/IMAGE_NAME:IMAGE_TAG": failed to fetch anonymous token: Get https://my.registry.domain/service/token?scope=repository%3A-REPO_NAME%2FIMAGE_NAME%3Apull&service=name-reigstry: x509: certificate signed by unknown authority

you definitely commented out the tls config?

Yes, adding the output from there
cat /etc/containerd/config.toml
# Kubernetes doesn't use containerd restart manager.
disabled_plugins = ["restart"]
oom_score = -999

[debug]
  level = "info"

[grpc]
  gid = 412

[plugins.cri]
  stream_server_address = "<IP_ADDRESS>"
  max_container_log_line_size = 262144
[plugins.cri.cni]
  bin_dir = "/home/kubernetes/bin"
  conf_dir = "/etc/cni/net.d"
  conf_template = ""
[plugins.cri.registry.mirrors."my.registry.domain"]
  endpoint = ["http://my.registry.domain"]
[plugins.cri.registry.mirrors."docker.io"]
  endpoint = ["https://mirror.gcr.io","https://registry-1.docker.io"]
#[plugins.cri.registry.configs."my.registry.domain".tls]
#  insecure_skip_verify = true

any chance you can try out more current release?  see thread: https://github.com/containerd/cri/issues/1433

Basically we are using GKE,and they have setup containerd, so not sure if I can update it?

I see. @Random-Liu .. thoughts?

IIRC, the insecure_skip_verify support was added in 1.3.2 and above, so containerd 1.2.8 won't have it. https://github.com/containerd/containerd/pull/3864


configure-opsman: allow updating the UAA tokens expiration

This PR allows users to update the UAA tokens expiration using the configure-opsman subcommand.  This change is useful for environments with strict compliance requirements such that the default access token and refresh token expiration are too long.

Tested out locally. Applied the updated values as 10 and the subsequent om curl got it back.
go run main.go --env ~/workspace/pivotal/platform-automation-deployments/reference-gcp/env.yml curl --path /api/v0/uaa/tokens_expiration
Status: 200 OK

{
  "tokens_expiration": {
    "access_token_expiration": 10,
    "refresh_token_expiration": 10,
    "session_idle_timeout": 10
  }
}


Mute NativeIoException

Mute NativeIoException

Codecov Report

Merging #1658 into master will increase coverage by 0.03%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##             master    #1658      +/-   ##
============================================
+ Coverage     73.63%   73.67%   +0.03%
- Complexity     8705     8711       +6
============================================
  Files           617      617
  Lines         47769    47771       +2
  Branches       6037     6038       +1
============================================
+ Hits          35174    35193      +19
+ Misses        10751    10741      -10
+ Partials       1844     1837       -7

Impacted Files
Coverage Δ
Complexity Δ

...b/ambry/network/http2/Http2ChannelPoolHandler.java
76.92% <0.00%> (-6.42%)
3.00 <0.00> (ø)

.../src/main/java/com/github/ambry/store/Journal.java
85.54% <0.00%> (-1.21%)
30.00% <0.00%> (-1.00%)

...in/java/com/github/ambry/store/BlobStoreStats.java
85.48% <0.00%> (-0.36%)
141.00% <0.00%> (+2.00%)
:arrow_down:

.../main/java/com/github/ambry/store/HardDeleter.java
77.27% <0.00%> (-0.29%)
49.00% <0.00%> (-1.00%)

...ava/com/github/ambry/store/BlobStoreCompactor.java
89.85% <0.00%> (-0.29%)
121.00% <0.00%> (ø%)

...java/com/github/ambry/router/GetBlobOperation.java
90.92% <0.00%> (-0.16%)
48.00% <0.00%> (-1.00%)

...ain/java/com/github/ambry/router/PutOperation.java
92.73% <0.00%> (ø)
123.00% <0.00%> (ø%)

...src/main/java/com/github/ambry/commons/BlobId.java
93.37% <0.00%> (+0.34%)
73.00% <0.00%> (+1.00%)

...rc/main/java/com/github/ambry/store/BlobStore.java
88.65% <0.00%> (+0.46%)
147.00% <0.00%> (ø%)

...java/com/github/ambry/network/SSLTransmission.java
70.46% <0.00%> (+0.92%)
72.00% <0.00%> (ø%)

... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d63382b...8fc558a. Read the comment docs.


Support for proxy URL for gemini

OpenAI and Anthropic each have ENV variables that you can set in the .env file and their clients will pick them over the default if they are set.
The Gemini client however does not do that, so in order to provide a custom host URL it needs to be passed explicitly on gemini client instantiation.
The code changes for the chatbot to support this are negligible but I am not sure how to contribute, and, I think one of the files I changed should not be edited directly. In essence all we need to do is add the env variable, and then pass it to the gemini client with the following change
from
    const googleModel = genAI.getGenerativeModel(
      { model: chatSettings.model }
    )

to
    const googleModel = genAI.getGenerativeModel(
      { model: chatSettings.model },
      { baseUrl: profile.google_gemini_base_url }
    )

I attached a diff.txt file so maybe a dev can try git apply diff.txt or even copy by hand, it's like 4 changed lines to support this.
diff.txt

Gemini has make the same way to call openAI.Now u can use baseURL of Gemini's to use gemini.

I'm not sure exactly what you mean, but the whole point is not to use the base url of Gemini, but to use a proxy base url that leads to Gemini. For example if I can access
openai at openai.kong.svc.cluster.local, right now I can go to .env file of chatbot, add OPENAI_BASE_URL=openai.kong.svc.cluster.local, and the openai client the chatbot is using will make use of that env variable and point requests at the proxy not openai. Anthropic is the same. Gemini though is not using an env variable and the value needs to be passed explicitly, hence the feature request.

To drive the point home, this is my current chat-ui config file and that works fine (other than gemini of course). My api-keys come from a proxy, and the base_urls of openai and anthropic can be redirected to the proxy as well.


Allow locking axes on Follow modifier

This functionality is used for sidescroller (2.5D) and top-down views.

There's possibility to group variables in inspector, but it doesn't look much better.
Inspector plugin could be a solution to make it cleaner but is it overkill?

Oh, I'm specifically referring to using the variables in code.
//C++
#include <iostream>

struct AxisFlags
{
  // Each of these will take up 1 bit abd be packed into a single byte
  bool x : 1{ false };
  bool y : 1{ false };
  bool z : 1{ false };
};

void main()
{
  AxisFlags enabledAxes{};
  std::cout << sizeof(enabledAxes) << '\n'; // 1
  enabledAxes.x = true;
  if (enabledAxes.y)
  {
    //Much easier to read this way
  }
}

Ah sorry I must have been half asleep. That definitely would be a nice functionality! Currently enums are closest we have (but for use case as simple and unchanging as XYZ I felt hardcoding the bits were better fit).


Fail to use mxnet.numpy.prod(a.shape)

>>> mx.np.prod(a.shape)
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "<string>", line 31, in prod
AssertionError: Argument a must have NDArray type, but got (5,)

while numpy supports that.

We might postpone to support it after 2.0. Let's still leave the v2.0 label and revisit if we have time before the release.


Equals sign in species labels breaks restart

When parsing a Chemkin-like reaction equation (e.g. in reading restart files, or appending "(+M)" to pressure-dependent reactions), we assume that the reactants and products do not contain equals signs, so that the only equals sign is the reaction arrow. This implies that we cannot allow equals signs to be used in species from condition files or seed mechanisms, which is unfortunate because it would disallow the use of SMILES. However, RMG does not currently check the species labels for forbidden characters like this when starting a job, leading to issues if trying to parse a restart file.
Possible solutions:

Forbid equals signs (and perhaps other such characters) in all species labels. This is probably not too difficult of a fix, but it removes quite a bit of flexibility (read: I like using SMILES).

Fix our restart file reading to handle equals signs in species labels. Since we have to specify all the species labels in another place, it should be possible to parse the species labels from the restart/Chemkin reaction equations. I don't think this would be too difficult either, but I'm not an expert in restart file reading/writing.

Change the reaction arrow to "<=>" instead of "=". This is probably not the best approach, since it means we can only use up to nine characters per species label (down from the current ten).

(This is also an issue in RMG-Py, where we have been merrily using SMILES in our generated species labels since its inception. However, the issue is limited to reading and writing of Chemkin files, as restart is provided by another mechanism that doesn't break when this issue occurs. For Py I will probably just fix the Chemkin reader to handle equals signs in species labels.)

Being able to import "real world" chemkin files with minimal translation would be nice.
Non-alphanumeric characters I have come across in a brief survey just now:
Princeton (Dryer/Dooley)  *-()
JetSurF (Hai Wang) (),-
LLNL (Westbrook etc.) -()
So it would be good to allow those. Nobody is using =.


Update doc to fix a typo strng -> string

Sorry I just cannot unsee it after spotted the error :)

Ooops! Thanks:)!


Replace NSURLRequest with Result<NSURLRequest, Moya.Error> in RequestClosure.

So this is my take on #465. Of course this is a draft and if you have any ideas for upgrade or a change, please let me know! 🎉
P.S. Sorry for the white lines, dunno what happened ¯_(ツ)_/¯

Push CI failure is the intermittent one, merging.
Looks great, thanks!


fix: refactor ActionManager component to conform to react hooks rules

Closes #135.
This fixes the error: Rendered more hooks than during the previous render.

LGTM! Thanks!


chore: fix typos

:tada: This PR is included in version 1.1.2 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Superenhancers only .bed file

Problem
ROSE outputs a .bed file in which it ranks all stitched enhancer loci by their background corrected density signal. In the same .bed file a section containing only superenhancer stitched loci are added. I feel it's correct to instead of adding a second section to the end of the file, to output superenhancers only section as a new .bed file.
Location
'output.R' is the script that outputs the final .bed files.
Solution
Create a new output filename and output the superenhancers only stitched loci to this new output .bed file. Also, consider removing the 'splitSuper' argument, as the original ROSE by default has this as 'TRUE' and it isn't an argument users can toggle from the command line.

The function 'convert_stitched_to_bed' doesn't properly split the output file into all stitched enhancer loci and superenhancers only stitched enhancer loci, but 'convert_stitched_to_gateway_bed' does. These functions have quite some code in common, so maybe try to merge these into 1 function?

Issue was solved with conversion of R code to Python.


run a postproccesor plugin in with --skip-download

DO NOT REMOVE OR SKIP THE ISSUE TEMPLATE

[X] I understand that I will be blocked if I intentionally remove or skip any mandatory* field

Checklist

[X] I'm asking a question and not reporting a bug or requesting a feature
[X] I've looked through the README
[X] I've verified that I'm running yt-dlp version 2023.03.04 (update instructions) or later (specify commit)
[X] I've searched known issues and the bugtracker for similar questions including closed ones. DO NOT post duplicates
[X] I've read the guidelines for opening an issue

Please make sure the question is worded well enough to be understood
To address the issue with odd subtitles when you convert auto generated subtitles from YouTube to SRT , I wrote srt_fix. A postprocessor plug-in. It works so far, but I am stuck as to how to make the plugin run when the flag --skip-download is passed. e.g. when one wants only the SRT files and not the videos.
@pukkandan suggested this:
from yt_dlp.postprocessor import FFmpegSubtitlesConvertorPP
info, files_to_delete = FFmpegSubtitlesConvertorPP(self._downloader, 'srt').run()
# Do your stuff
return info, files_to_delete

But I don't understand where to add these lines in my code. Inside the PP class of my plugin or the head of the file did not work.
Provide verbose output that clearly demonstrates the problem

[ ] Run your yt-dlp command with -vU flag added (yt-dlp -vU <your command line>)
[ ] If using API, add 'verbose': True to YoutubeDL params instead
[ ] Copy the WHOLE output (starting with [debug] Command-line config) and insert it below

Complete Verbose Output
No response

--use-postprocessor srt_fix:when=before_dl is what you need
The problem is, at least via CLI, this will run before the subtitles converter PP runs. I think this is where pukkandan's suggestion comes in.
This works for me
yt-dlp -v --skip-download --use-postprocessor srt_fix:when=before_dl --write-sub test:youtube

if I make these changes
diff --git a/yt_dlp_plugins/postprocessor/srt_fix.py b/yt_dlp_plugins/postprocessor/srt_fix.py
index 3cf7d96..4370ffd 100644
--- a/yt_dlp_plugins/postprocessor/srt_fix.py
+++ b/yt_dlp_plugins/postprocessor/srt_fix.py
@@ -1,4 +1,5 @@
 #  Don't use relative imports
+from yt_dlp.postprocessor import FFmpegSubtitlesConvertorPP
 from yt_dlp.postprocessor.common import PostProcessor

 # start
@@ -216,6 +217,7 @@ class srt_fixPP(PostProcessor):

     # ℹ See docstring of yt_dlp.postprocessor.common.PostProcessor.run
     def run(self, info):
+        files_to_delete, info = FFmpegSubtitlesConvertorPP(self._downloader, 'srt').run(info)
         subtitles = info.get('requested_subtitles')
         if not subtitles:
             self.to_screen('There aren\'t any subtitles to process')
@@ -261,21 +263,6 @@ class srt_fixPP(PostProcessor):
         #files_to_move = info['__files_to_move']
         #self.to_screen(f'Initial files_to_move: {files_to_move}')

-        # HACK: The replacement set of subtitles is never written. We proably are called too late. Do it ourselves for now.
-        for lang, sub_info in subtitles.items():
-            new_file_path = sub_info.get('filepath')
-            text = sub_info.get('data')
-
-            with open(new_file_path, "w", encoding="utf8") as new_file:
-                new_file.write(text)
-
-            info['__files_to_move'][new_file.name] = os.path.basename(new_file_path)
-            #self.to_screen(f'Wrote postprocessed {lang}')
-
-        #files_to_move = info['__files_to_move']
-        #self.to_screen(f'Modified files_to_move: {files_to_move}')
-
-        '''
         filepath = info.get('filepath')

         if filepath:  # PP was called after download (default)
@@ -286,6 +273,5 @@ class srt_fixPP(PostProcessor):
             filepath = info.get('_filename')
             self.to_screen(f'Pre-processed {filepath!r} with {self._kwargs}')
             self.process_all(filepath)
-        '''

-        return [], info  # return list_of_files_to_delete, info_dict
+        return files_to_delete, info

--use-postprocessor srt_fix:when=before_dl is what you need

Where is the documentation about how to pass parameters to postprocessors?

https://github.com/yt-dlp/yt-dlp#post-processing-options
--use-postprocessor NAME[:ARGS]
                                The (case sensitive) name of plugin
                                postprocessors to be enabled, and
                                (optionally) arguments to be passed to it,
                                separated by a colon ":". ARGS are a
                                semicolon ";" delimited list of NAME=VALUE.
                                The "when" argument determines when the
                                postprocessor is invoked. It can be one of
                                "pre_process" (after video extraction),
                                "after_filter" (after video passes filter),
                                "video" (after --format; before
                                --print/--output), "before_dl" (before each
                                video download), "post_process" (after each
                                video download; default), "after_move"
                                (after moving video file to it's final
                                locations), "after_video" (after downloading
                                and processing all formats of a video), or
                                "playlist" (at end of playlist). This option
                                can be used multiple times to add different
                                postprocessors


How to inject DLL

dont use fullscreen

不要使用全屏 不要使用全屏

What does it have to do with full screen

And you didnt start..

you didn't start the program您没有启动程序

you didn't start the program

Started, but shows no injection

Do not play in full screen mode ,Play in frameless screen mode

Still ineffective

Unable to inject

delete the files and the files from documents and download the again.

delete the files and the files from documents and download them again.

Where should I put the prepared files?

wherever you want the new files as always


app-npm-webpack example is not working in dev server mode

I was trying to follow the readme file to run webpack dev server for the app-npm-webpack example.
"npm start" script throws with the following exception:
70% 1/1 build modulesevents.js:85
throw er; // Unhandled 'error' event
^
Error: listen EACCES
at exports._errnoException (util.js:746:11)
at Server._listen2 (net.js:1129:19)
at listen (net.js:1172:10)
at net.js:1270:9
at GetAddrInfoReqWrap.asyncCallback [as callback] (dns.js:81:16)
at GetAddrInfoReqWrap.onlookup [as oncomplete] (dns.js:99:10)
FYI: production build ("npm run build") works fine

Do you have another app/server running on the same port?

I didn't. But I've changed the port and worked.
Thanks for the hint.


pull request for e2e test at 11/21/2016 17:56:05

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

optest/docs/updated_at.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Incorrect warnings on elements with multiple controllers

I have an element that has multiple controllers - and I'm getting The Stimulus target is not inside the Stimulus controller warnings.
The _checkStimulusTargetsNesting method in src/lib/diagnostics_checker.js is only looking for a parent element that is an exact match for the controller name - rather than allowing an element to have multiple controllers such as <body data-controller="search list-selection">

Uh good catch, thank you @mtownsend81!
A total blunder on my part.
I'll try to fix it as soon as possible.
Thanks for reporting!

Hi @mtownsend81, I've just publish a new version that should fix this issue.
Let me know if you encounter any other problems.


GPIO value not being set by api

Values are not being correctly set by the API.
I believe value is being overwritten during the valid check within value.rb
# Validate the value
value         = ValidateValue.new value
return value.error_message unless value.valid?

Possible fix:
# Validate the value
value_         = ValidateValue.new value
return value_.error_message unless value_.valid?

Hey @brendon1555, your observation and fix are both correct. That is what I get for doing a refactor and not testing thoroughly afterwards ;-)
Version 1.0.1 of the GEM pushed with the fix. Just do a "gem update udooneorest".
Cheers


[Readme] Fix Spaces/typos

Description

Fix Spaces/typos in the README.
Expected Behavior

Screenshots

Environment:

Host OS:
Browser:

HI, @legendarykamal can I work on this ?

sure.


Tea napkin parser

TeaNapkin parser is the new cleanup tool for cleaning the Haxe output for our plugins.

[x] Clean prototype assignments and declerations from bracket notation prototype['myMethod''] to prototype.methodName

[x] Cleanup stray semicolons ;

[ ] Cleanup comments, they contain quotes or @ symbols

[ ] Minify haxe classes and functions and place at bottom of iife

Closing pull request as this now has its own repository here https://github.com/LunaTechsDev/LunaTeaNapkin


Unable to read from Control Logix PLC

Unable to read anything from a control logic PLC.
Unable to display controller properties, unable to read a tag value.
Current Behavior

When connecting to PLC, an UnhandledPromiseRejectionWarning is given.
I am able to ping the PLCs IP. (EN2TR card) I am able to go online with Studio 5000 programming software.
PLC is in Run mode.
Expected Behavior

Connection to PLC should complete, and plc properties would be written to console
Steps to Reproduce

Download current version of Node and install. node-v9.9.0-x64
Create a project directory and install node-ethernet-ip ("npm install ethernet-ip --save")
Create plc01.js file with sample connection code
Run node plc01.js
Receive error on console

Your Environment

Package version (Use npm list - e.g. 1.0.6):
<EMAIL_ADDRESS><EMAIL_ADDRESS>Node Version (Use node --version - e.g. 9.8.0):
v9.9.0
Operating System and version:
Windows 7 - SP1 - x64
Controller Type (eg 1756-L83E/B):
1756-L75
Controller Firmware (eg 30.11):
28.012

4 slot rack, plc is in slot 0. EN2TR cards in slot 1 and slot 2. Slot 3 is open.
Error output
(node:14792) UnhandledPromiseRejectionWarning: #
(node:14792) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 1)
(node:14792) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
Test Code
const { Controller } = require("ethernet-ip");
const PLC = new Controller();
// Controller.connect(IP_ADDR[, SLOT])
// NOTE: SLOT = 0 (default) - 0 if CompactLogix
PLC.connect("<IP_ADDRESS>", 0).then(() => {
 console.log("Connected to PLC!");
 console.log(PLC.properties);
});

Hey man, sorry to hear about the issue.  If you have a few minutes, can you run the following code and let me know what it prints?
const { Controller } = require("ethernet-ip");
const PLC = new Controller();

// Controller.connect(IP_ADDR[, SLOT])
// NOTE: SLOT = 0 (default) - 0 if CompactLogix
PLC.connect("<IP_ADDRESS>", 0).then(() => {
    console.log("Connected to PLC!");
    console.log(PLC.properties);
}).catch(e => {
    console.log(PLC.properties);
    console.log("=========================");
    console.log(e);
});

This should give some more insight into what might be happening.

C:\NodeJS\PLC01>node plc01.js
{ name: '1756-L75/B LOGIX5575',
serial_number: 14878836,
slot: 0,
time: null,
path: <Buffer 01 00>,
version: '28.12',
status: 12384,
faulted: false,
minorRecoverableFault: false,
minorUnrecoverableFault: false,
majorRecoverableFault: false,
majorUnrecoverableFault: false,
io_faulted: false }
{ generalStatusCode: 8, extendedStatus: [] }
Time Settings. Only issue is DST adjustment is off.

ahhhh, yep this is definitely related to #1.  The readWallClock method in the connect method is causing the issue, apparently this feature only works with the latest rockwell releases (e.g. L8 series controllers).  We will update the code soon and release a patch today.  @patrickjmcd or myself will update the thread once the changes are live. Thanks for helping to track this down =].

You should be able to upgrade the npm package npm install --save --upgrade ethernet-ip and your issue should be resolved. The call to readWallClock has been removed so you should no longer get that error.

@MattCost v1.1.1 has been released (thanks to @patrickjmcd).  Run npm update ethernet-ip to get the latest version.  After that, try running your code again and let us know if this resolves your issue.

@MattCost Can you confirm that v1.1.1 resolves your issue?

Yup! All working now

Awesome! 🎉 Closing this.

HI Can Some one please help me I Have a Similar problem. But I keep getting this error:
caught error!Error Code:undefined { generalStatusCode: 5, extendedStatus: [] }.
Does this mean information is missing in the readtag parameters?
This is my Code:
var test = new Tag("CCW_Roll_RRCtrl", null, DINT);
PLC.connect("<IP_ADDRESS>", 2).then(async () => {
var { name } = PLC.properties;
console.log(`\n\nConnected to PLC ${name}...\n`);
await PLC.readTag(test);
console.log(tes.value);

}).catch(error => {
console.error('caught error!' + 'Error Code:' + error.Code, error);
});
Secondly:
Does this module connect with the Allen bradley Rockwell 1756-EN2T/D\u0003\u0000\u0000\u0000 PLC

1756-EN2T is an Ethernet card, not a PLC. You are connecting to slot 2. Is that where the EN2T is? Because that would be wrong. You need to enter the slot number for the processor, the one with a keyswitch and probably a 1756-Lxx part number. As a reminder, slot counting starts at 0.

Okay great, I did not take that in consideration. I will test today and see what is my results. Thanks for the assistance


Embedding TS definitions

Hi,
I would like to contribute TypeScript definitions for this package. Would you agree to embed them in the package?

Hi Tomas, thanks for your offering and motivation to contribute.
Yes, I would be glad to embed it and have you as a contributor.
Regards
On Thu, Apr 4, 2019, 12:15 PM Thomas Corbière<EMAIL_ADDRESS>wrote:

Hi,
I would like to contribute TypeScript definitions for this package. Would
you agree to embed them in the package?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/jkyberneees/ana/issues/27, or mute the thread
https://github.com/notifications/unsubscribe-auth/AD6DXFD-IXVYO54LTaRNiYMFF9y5BVG0ks5vddDdgaJpZM4ccbrL
.


[Improvement][dolphinscheduler-task-api] Support for multi-level environment variables

Search before asking

[X] I had searched in the issues and found no similar feature requirement.

Description
I am trying to set some basic environment variables through dolphinscheduler_env.sh, and at the same time set some project-specific and volatile environment variables through the Environment manage feature.
However, under the existing logic, this idea does not work. I can only make a copy of the basic environment variables in the Environment manage to take effect.
I think it might be possible to improve this experience by setting and overriding multiple levels of environment variables
Use case
E.g
In a Python task, I can export PYTHONPATH=xxx in dolphinscheduler_env.sh to make all projects reference some base packages without having to go through Environment manage or Resources authorization to set them one by one.
In the project-specific Environment manage or  Resources authorization, only the specific part of the project is concerned. Such as export PYTHONPATH=yyy:$PYTHONPATH.
Related issues
No response
Are you willing to submit a PR?

[X] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Then this seems to be a bug. I tried it on our project. When there is a value in my Environment manage, the settings in dolphinscheduler_env.sh did not take effect.

I found the following code in org.apache.dolphinscheduler.plugin.task.api.ShellCommandExecutor#createCommandFileIfNotExists.

It seems that dolphinscheudler_env.sh will only take effect if there is no value in Environment manage.

I can't reproduce your problems in my environment. Which version you are using?  Can you provide steps for accurate reproduction?

I can't reproduce your problems in my environment. Which version you are using? Can you provide steps for accurate reproduction?

Same thing I said yesterday about python_home

I have replied in #10533 yesterday. @stalary

I have replied in #10533 yesterday. @stalary

This issue and me facing the same problem, need global environment merge environment manager.

I have replied in #10533 yesterday. @stalary

I think we can have a detailed communication on wechat, my wechat is<PHONE_NUMBER>9.

I can't reproduce your problems in my environment. Which version you are using? Can you provide steps for accurate reproduction?

The version I am using is 2.0.5
Perhaps, you can reproduce with the following steps:

Set the environment variable PYTHONPATH in /opt/dolphinscheduler/conf/env/dolphinscheduler_env.sh. Such as export PYTHONPATH=/opt/env_test
In the /opt/env_test directory, create a new file, such as env_test.py
Set up some values in Environment manage to create an environment test, such as export TEST_ENV=xxx
Create a new Python task and set the Environment Name to test in Current Node Settings, and the task content is import env_test
Start the above tasks through the test Environment start
You will get exception ModuleNotFoundError: No module named 'env_test'

I'm not quite familar about PYTHONPATH. PTAL @zhongjiajie

I'm not quite familar about PYTHONPATH. PTAL @zhongjiajie

PYTHONPATH is similar to java's CLASSPATH, both specify dependencies search paths.

@CFlyGoo Yeah, currently that the behavior, and your requests make sense to me, you want to have some like global env and local env, priority is local > global but if the env missing in local you want to get them in the global default(if they have). Do you have time to create a PR and correct it?


Feature Request: Colored Titles

The user will be able to configure colors for their titles (similarly to the todo-highlight extension).
The pattern could possibly be similar to: <dash><padding><title<padding><dash>

colors would be super neat!
did some tinkering
ended up basically just exposing the styles object that you pass to vscode in order to style a range
got the styles object from the main config object
skipped tests and moved some stuff around, just to get things working..
you can checkout the branch
i think this feature would be best implemented if it enabled the user to the following:
1 -  pre-define section titles with a custom styles object (maximum styling flexibility)
2 - inline styling with the title,  something like  %title_color %title_backgoung %dash_color my title
thoughts??

Nice work! I also thought of a styles object (perhaps with nested stylings for the variations) and the inline stylings are a nice touch as well (perhaps also add the option of inlining other options as well?).
Regardless - will go over and think about this. Thanks so much for the contribution 💯


[Task] ShenYu Admin Cluster

Description
As ShenYu is popular, ShenYu Gateway has supported cluster mode(shenyu-nginx, nginx, and so on), But ShenYu Admin does not support cluster mode, we need to design admin cluster mode.
Task List

[ ] Design shenyu admin cluster model
[ ] Admin distributed  lock by spring-integration-mysql
[ ] Implement ShenYu admin cluster model
[ ] Add e2e shenyu admin cluster test case

Admin distributed lock by spring-integration-mysql pls assigne me .

Implement ShenYu admin cluster model   I  want to try it.

Implement ShenYu admin cluster model I want to try it.

can u add my wechat : aias00

实现神宇管理员集群模型我想尝试一下。

可以加我微信吗：aias00
ok ,I've added.


Spacy lemmatizer to use blank model

Description
Fixes https://github.com/wellcometrust/WellcomeML/issues/271 by using blank spacy model.
Running on 1000 grant description: the previous method took 33 secs (when tagger is disabled) and 14 secs (when tagger is not disabled). This new method takes 2 secs.
I also noticed some unusual performance where other methods don't seem to actually lemmatize the text.
X = ['the cats sat on the sitting room floors enjoying the sun']

Original method (when the model is already downloaded)
nlp = spacy.load("en_core_web_sm", disable=["ner", "tagger", "parser", "textcat"])
output= [[token.lemma_.lower() for token in doc] for doc in nlp.pipe(X)]

gives loads of warning for every token of the form "spacy WARNING: [W108] The rule-based lemmatizer did not find POS annotation for the token 'sun'. Check that your pipeline includes components that assign token.pos, typically 'tagger'+'attribute_ruler' or 'morphologizer'" (allenai seem to have had a similar issue with it)
and the output is:
[['the', 'cats', 'sat', 'on', 'the', 'sitting', 'room', 'floors', 'enjoying', 'the', 'sun']]

I realise this had a bug in it where the tagger shouldn't have been disabled, i.e.
nlp = spacy.load("en_core_web_sm", disable=["ner", "parser", "textcat"])
output= [[token.lemma_.lower() for token in doc] for doc in nlp.pipe(X)]

does seem to lemmatize correctly.
I also tried the following method:
from spacy.lang.en import English
from spacy.pipeline.lemmatizer import Lemmatizer
nlp = English()
lemmatizer = Lemmatizer(nlp, model=None,  mode= "lookup")
output= [[lemmatizer.lookup_lemmatize(token)[0].lower() for token in doc] for doc in nlp.pipe(X)]

which also gave:
[['the', 'cats', 'sat', 'on', 'the', 'sitting', 'room', 'floors', 'enjoying', 'the', 'sun']]

The final method, which I've commited is:
nlp = spacy.blank("en")
nlp.add_pipe("lemmatizer", config={"mode": "lookup"})
nlp.initialize()
output= [[token.lemma_.lower() for token in doc] for doc in nlp.pipe(X)]

gives:
[['the', 'cat', 'sit', 'on', 'the', 'sit', 'room', 'floor', 'enjoy', 'the', 'sun']]

Checklist

[ ] Added link to Github issue or Trello card
[ ] Added tests

Nice find. Is it much quicker then?

Running on 1000 grant descriptions the previous method took around 14 secs (when tagger is not disabled) and this new method takes 2 seconds.

Nice find. Is it much quicker then?

Running on 1000 grant descriptions the previous method took around 14 secs (when tagger is not disabled) and this new method takes 2 seconds.

⚡

Pipeline seems to fail with a weird error.

Pipeline seems to fail with a weird error.

@aCampello :( seems to be the same one as you got when you opened https://github.com/wellcometrust/WellcomeML/issues/270. Did you do anything to get your PR to pass in the end? As @nsorros said "Some non deterministic test fail here showing up again."

Don't know, I re-ran and it passed! I assume some memory error again.

Let me have a look. Does tox pass locally?

Let me have a look. Does tox pass locally?

@aCampello it's still running locally for 3.8, but has passed for 3.7

I re-triggered your pipeline. Let's see.


Rework auto-update system to use github pages instead of v8 API

📒 Description
Rework auto-update system to use github pages instead of v8 API
🕶 Types of changes
Breaking change (fix or feature that would cause existing functionality to change)
🤯 List of changes

Use updates.json from github pages for auto-update instead of v8 API
Auto-update from 32-bit versions on 64-bit systems to 64-bit versions on Windows
Fixed error in google-astyle (make fmt didn't work on my machine due to this error)

👫 Relationships
Closes #3097
🔎 Review hints

The Windows and Linux applications are now using https://toggl.github.io/toggldesktop/assets/releases/updates.json for update checking.
On a 64-bit Windows users get a 64-bit Toggl Desktop update.
On a 32-bit Windows users get a 32-bit Toggl Desktop update.
The app does not crash when the JSON file does not have the expected format.

@MartinBriza I've addressed your comments, please check out the review again


Hot reload not working when navigating with arguments

I tried to investigate the source of this bug
Decided to go through flutter tutorials again and found that they have the same problem. Not clear is it flutter tutorial issue or bug in routing/hot reload system.
Steps to Reproduce
See reproduction video

Copy interactive example from named routes tutorial.
Run code.
Try to change anything visible on the second screen and save.
Observe it changing in with hot reload.
Copy interactive example from navigate with arguments tutorial in the same file.
Hot restart.
Navigate to line:66.
Try to edit any of the arguments and save.
Witness no change.
Navigate back to home
Navigate to extract arguments screen - witness the change.

Expected results: To see hot reload results right away without navigating back and forth.
Actual results: Hot reload not refreshing widgets for a secondary screens.
Details:
Flutter version: 1.17.1

After further investigation, I realised that the widget changes do update indeed.
It's only arguments changes which do not get updated, I presume because they only run once when the navigation button is pressed.
So it works as expected it seems.


WIP fwupd: 1.0.5 -> 1.0.7

We override the ESP mount point in the config file /etc/fwupd/uefi.conf
(available since version 1.0.6), as it is set to a path in the nix store
during build time.
Current issues: See issue #39386
Also:
Tests are disabled as it needs /etc/os-release, which is not available
when building with sandboxing enabled.
I also get a lot of bash: warning: setlocale: LC_ALL: cannot change locale (en_US.UTF-8) during the build, but am not sure if this is an issue with my system configuration.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Fits CONTRIBUTING.md.

You are running into this problem regarding locales: https://github.com/NixOS/nixpkgs/issues/38991

cc @jtojnar

From the changelog, the only thing that caught my eye were bash completions, but they use an exact path so it works for us. Upstream should probably switch to something like the following, as per https://www.bassi.io/articles/2018/03/15/pkg-config-and-paths/.
bash_completion_dep = dependency('bash_completion')
completionsdir = bash_completion_dep.get_pkgconfig_variable(
  'completionsdir',
  define_variable: [ 'prefix', prefix ],
)

@Mic92 I do not think that is #38991, the packages are built in sandbox so there should be no conflict with system archive. I have always seen the warning when setting LC_ALL.
@Moredread Regarding /etc/os-release, that should be reported upstream, it was already fixed once (by skipping the test IIRC).
Could you add a comment saying that /etc/fwupd/uefi.conf is created manually in the NixOS module, next to filesInstalledToEtc, so that we have the mismatch documented?
@GrahamcOfBorg test fwupd

No attempt on aarch64-linux (full log)
The following builds were skipped because they don't evaluate on aarch64-linux: tests.fwupd
Partial log (click to expand)

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

Success on x86_64-linux (full log)
Attempted: tests.fwupd
Partial log (click to expand)
machine: exit status 1
syncing
machine: running command: sync
machine: exit status 0
test script finished in 22.88s
cleaning up
killing machine (pid 593)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
/nix/store/zcwgkamrvyjw071qxafl11sz8jgpsbvf-vm-test-run-fwupd

@jtojnar I'll try to get to it later today but I'm on vacation the next week or so, so I am not sure when I have the time.

@jtojnar have added the comment and created an upstream issue for the failing test.

@jtojnar the issue for the missing os-release file has been closed upstream as nofix

Besides the test issue the PR seems to be working and could be merged IMHO.

Could you use the fix from https://github.com/NixOS/nixpkgs/issues/40872?

In principle that would work (although I'd prefere to add the /tmp/os-release path to the list).
This would expose the os-release parser to a potential attacker with arbitrary rights on a  misconfigured system without the file in the default location. I'm not sure how much that'd an issue.

Sounds reasonable.
By the way, 1.0.8 is out: NEWS

@jtonar The patch we apply doesn't work there anymore. I'm not sure when I'll have time to look at the issue, but will leave a comment when I work on that.

Looks like the patch needs to update the context of po/make-images.sh @@ -7,6 +7,7 @@ from gzip -f ${x} to gzip -fn9 ${x}.

I will try to update it. The 1.10 changes look interesting.

Pushed. It would be great if anyone with relevant hardware could test this.

Since this is a huge improvement we should probably merge it even if the UEFI update is still broken.

@peterhoeg I had a few problems with permission, sometimes it worked, sometimes it didn't. (See https://github.com/NixOS/nixpkgs/issues/39386)
You also have to copy over the UEFI files for fwupd manually, and remove them after the update has finished.
I did a successful FW upgrade on an older version on my Dell laptop a few months ago so it should work in principal.

Thanks all! Gave this a go, generally looks good and UEFI situation same as @moredread reports above-- best I could figure out was to just copy the things over (and remove after).  Finally updated my laptop's BIOS xD.


During decode process, instead of AgentRemoteId, AgentCircuitId is updated.

Instead of AgentRemoteId, AgentCircuitId is updated, during decode process. The link to issue in code is:
https://github.com/bluecatengineering/dhcproto/blob/44fe6c9115bb39b17db74b66bb357839da8f4c5c/src/v4/relay.rs#L137
It should be
          RelayCode::AgentRemoteId => {
                let len = d.read_u8()? as usize;
                let data = d.read_slice(len)?.to_vec();
                AgentRemoteId(data)
          }

It should be
RelayCode::AgentRemoteId => {                 let len = d.read_u8()? as usize;                 let data = d.read_slice(len)?.to_vec();                 AgentRemoteId(data)             }

MR is raised here: https://github.com/bluecatengineering/dhcproto/pull/66

Thank you!

closed in #66


nixos/librenms: init at 23.9.1

Description of changes
This PR adds a module and a package for the LibreNMS network monitoring system.
Closes #239566
Things done

Built on platform(s)

[X] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[X] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[X] (Module addition) Added a release notes entry if adding a new NixOS module

[X] Fits CONTRIBUTING.md.

Are LDAP configs part of the normal settings json, or in a separate configuration file? In other words is it still possible to configure LDAP after the refactor

Yes, they are part of the normal settings json --> it is still possible to configure LDAP.

I just saw that LibreNMS 23.6.0 has been released meanwhile -> draft until I have updated the PR

Updated to 23.6.0

Done. Separated commits and added release notes.

Made some changes to move dependencies from the module into the package

Wow, just wanted to say thank you for this.

Draft until distributed pollers and switch to new PHP builder.

@ofborg test librenms


H264Decoder module not terminating

Describe the bug
While closing the pipeline we found out that H264Decoder module is stuck in a thread joining phase, As there are 2 unclosed while loop which is running
To Reproduce
Steps to reproduce the behavior:

Add module "Camera Source -> Decoder " to the pipeline
Run pipeline

Expected behavior
The pipeline should end when we terminate pipeline

@mraduldubey @mohammedzakikochargi  this is an important issue to fix


HTTP\Client setCookie fail

This fail:
<?php
// getClient() is Zend\Http\Client
$response = $this->getClient()->setUri('http://domain.com')->send();
$this->cookieJar = Cookies::fromResponse($response);

// Later on fail...

$jar = $this->cookieJar->getAllCookies();
$this->getClient()->setCookies($jar);

It does success if I replace
https://github.com/zendframework/zf2/blob/master/library/Zend/Http/Client.php#L569
with
$this->addCookie($value, $name);

This issue has been closed as part of the bug migration program as outlined here - http://framework.zend.com/blog/2016-04-11-issue-closures.html


SUBSTRING function for MsSqlDialect queries is regenerated incorrectly

For Microsoft SQL Server, the syntax of the SUBSTRING function (described at https://learn.microsoft.com/en-us/sql/t-sql/functions/substring-transact-sql?view=sql-server-ver16) is SUBSTRING(expr, start, len). With sqlparser-rs, this parses correctly:
SELECT SUBSTRING('foobar', 1, 2)

but then is regenerated from the AST as
SELECT SUBSTRING('foobar' FROM 1 FOR 2);

which is not valid for Microsoft SQL Server with the error message [S0001][156] Line 1: Incorrect syntax near the keyword 'FROM'.
For other database dialects, variants such as SUBSTRING(expr [FROM start] [FOR len]) are supported, but Microsoft SQL Server does not appear to support these variants.
From looking at the Display impl for Expr, the dialect does not appear to be available, so would an acceptable alternative be to modify the Expr::Substring type and parser to store information describing the specific SUBSTRING variant?

From looking at the Display impl for Expr, the dialect does not appear to be available, so would an acceptable alternative be to modify the Expr::Substring type and parser to store information describing the specific SUBSTRING variant?

Hi @jmaness  -- thanks for filing the ticket.
Yes, I think that is consistent with how similar situations are handled elsewhere in this crate. For example CURRENT_TIMESTAMP vs CURRENT_TIMESTAMP() in
https://github.com/sqlparser-rs/sqlparser-rs/blob/eb288487a6a938b45004deda850e550a74fcf935/src/ast/mod.rs#L3494-L3496

Thanks @alamb, I'll follow a similar pattern and file a PR.


HashCodeCombiner should not be public

The HashCodeCombiner class is a purely internal helper class. If it's shared, it should be shared via source code sharing (using a shared-source package or a reference in the project.json compile project).
It's extremely unrelated to the project and collides heavily with other types, causing weird things like this:

Above I was pressing Ctrl-. to see if the project I was working in had HashCodeCombiner lying around and saw this :).
@NTaylorMullen and I chatted and suggested just making copies of the class with different namespaces. It's not pretty but it works. This isn't a huge deal, but it is weird that Razor would be leaking such an internal infrastructure class to the public.

How is this an issue for our customers? HashCodeCombiner is hidden away in the Microsoft.Internal.Web.Utils namespace.

As I said, it's probably not a big issue. Unfortunately, Ctrl-. and package search means it isn't fully hidden as it can easily appear in those lists. You do have to know what you're looking for (at least partly, in the case of package search) but it still seems like we're "productizing" a hack used to work around compiler issues :)

I'm missing something. Similar things could be said about every public class in one of our .Internal namespaces. Why is HashCodeCombiner different?

I'd argue HashCodeCombiner is different from other classes in Internal. It is not a component that anyone outside the assembly could ever be expected to use, even in the most contrived scenario. Public things in Internal are cases where it's useful for testing for the things to be public or we can't be completely sure there isn't value in closing this away. This class literally just does some math with ints in order to combine multiple hash codes into an aggregate hash code for an object. It should be in a sources package maybe, but it's not something Razor should leak out as a public class. Other projects define this class in this namespace (not 100% sure if there's any in DNX, but I know MVC <=5 and earlier versions of Razor did) and mark it internal so the now-public version can cause collisions if anyone who is using this class references Razor, as it will now collide. The class used to be internal and was made public to fix issues caused by tag helper tests and InternalsVisibleTo (per @NTaylorMullen) and I think it would be better to solve those issues a different way.
If there are other things in .Internal that fit this case, I would be concerned. At the very least, this should be moved to a Razor-specific Internal namespace instead of the much more general Microsoft.Internal.Web.Utils namespace it is in today. Regardless, this isn't worth arguing over if there are concerns about doing it. It was just something that seemed off to me and unlike other things. I leave it entirely in your hands :)

Since you're doing https://github.com/aspnet/Common/pull/30, have fun with this too :smile:

Well, this usage would be an exception and probably can't use the Common version. The problem is that two different projects in Razor use it and because of InternalsVisibleTo, there is a collision. Razor may have to have an actual copy of the code.

@anurse src/Microsoft.AspNet.Razor is the only src project that uses HashCodeCombiner. It makes internals visible to both test projects, which also use HashCodeCombiner. So it shouldn't matter where the source of the internal HashCodeCombiner actually is as long as neither test/... project has a build-time reference to this new Common project.

We shouldn't have IVT between any two runtime projects. If we do, that is a mistake.

@Eilon we don't in Razor at least. src/Microsoft.AspNet.Razor has an IVT for test/Microsoft.AspNet.Razor.Test and test/Microsoft.AspNet.Razor.Runtime.Test. Put another way, there's only one HashCodeCombiner class in Razor, src/Microsoft.AspNet.Razor/Common/HashCodeCombiner.cs, and it is not used in the src/Microsoft.AspNet.Razor.Runtime project (the only other product project in Razor).
@anurse exactly what is your concern with replacing that source file with the Common project? Making the contained class internal should have no impact. Overall, a few using updates should be the worst of it.

@NTaylorMullen indicated that there was a problem. I might be mistaken in interpreting this :). I'll give it a shot and if it works then great!

e722f9048140b2c47978746cbb1eef8dc548a9da


Make favicon reflect the status color

I have Kopf open in a Chrome tab all the time but its favicon is useless.
It would be very useful if the favicon reflected the cluster's status - a simple background colour same as the status (red, yellow, green) would be very useful.

makes sense. will try to come up with some meaningful icon for kopf, and then handle the color changes :+1:

Thanks. It looks great.

@amos-stan thank you actually. really nice idea, my colleagues also really liked it :+1:

It does not work here; and I don't know why. Firefox 35.0.1 & kopf 1.4.8. kopf is behind a reverse-proxy in a subdirectory but all requests are answered by HTTP/200. /elasticsearch-kopf/favicon.ico is loaded successfully (a black disc).
Kopf is working, the top bar is green/yellow according to my cluster status, but the favicon is completely transparent.

@koocotte did you try with a different browser? I don't really test on anything other than chrome :)

No, sorry, I can't install chrome here. Anyway it's a minor problem. Thanks.

I've just installed Firefox on my Mac to test this and it doesn't show the Favicon for me either.
I use the public hosted Kopf at http://lmenezes.com/elasticsearch-kopf/.
Google'ing about Firefox and Favicon comes up with many pages about issues regarding this (i.e. Firefox not displaying favicon which is displayed fine by other browsers).


Servelet1

Week 3 steo 1
-edited DataServlet.java

I see that i am confused as how those got there but im trying to fix it  is it posible that I close this request and open a new one

@zyelcrier might be easier to start a new PR and branch. Tomorrow at sync-up we can go over how to dig out of situations like this with git.


tryint to get spyder plugins to works (maybe too early ?)

Description
What steps will reproduce the problem?

install spyder plugins into spyder 3.2.0dev on winpython-3.5.3
start spyder
spyder shows an error at start

What is the expected output? What do you see instead?
hoped to see the notebook and terminal extensions
maybe did I miss a commit ?
Please provide any additional information below
plugin.initialize_plugin_in_mainwindow_layout()
self.on_first_registration()
self.main.tabify_plugins(self.main.extconsole, self)
self.tabifyDockWidget(first.dockwidget, second.dockwidget)

AttributeError: 'NoneType' object has no attribute 'dockwidget'
WARNING:traitlets:kernel died: 6.001145601272583
Version and main components

Spyder Version: 3.2.0.dev0
Python Version: 3.5.3
Qt Versions: 5.9.1, PyQt5 5.9 on Windows

Dependencies
pyflakes >=0.6.0 :  1.5.0 (OK)
pycodestyle >=2.3:  2.3.1 (OK)
pygments >=2.0   :  2.2.0 (OK)
pandas >=0.13.1  :  0.20.3 (OK)
numpy >=1.7      :  1.13.1 (OK)
sphinx >=0.6.6   :  1.6.3 (OK)
rope >=0.9.4     :  0.10.5 (OK)
jedi >=0.9.0     :  0.10.2 (OK)
nbconvert >=4.0  :  5.2.1 (OK)
sympy >=0.7.3    :  1.1 (OK)
cython >=0.21    :  0.25.2 (OK)
qtconsole >=4.2.0:  4.3.0 (OK)
IPython >=4.0    :  6.1.0 (OK)
pylint >=0.25    :  1.7.2 (OK)

ok, so:

the terminal extension has problems,
unselecting it and selecting the noteebook extension:

the notebook extension works,
it just fails at first opening of the day because of slow start of jupyter

now, the notebook extension works as advertised https://youtu.be/Hf07PmwQwPQ?list=PLYx7XA2nY5GfdAFycPLBdUDOUtdQIVoMf&t=329

awesome !

@stonebig What problems do you have with the terminal?

spyder complains at start, so I remove the toolbar.
If  I re-add it now, I see  this unworkable terminal window:

the `' of windows have diseappeared, maybe a UTF-8 / latin code page issue ?

Do you have the winpty binaries on your path? Did you install pywinpty?

Is this the latest commit from spyder-terminal repo?

ah,  I may have missed that two ones... will check

@stonebig by judging the screenshot, it seems that you installed spyder-terminal v0.1.1 which is uncompatible with Windows. Our great milestone was to bring it compatible on v0.2, so it would be great if you can give it a test :-)

can't recompile winpty from source ?
winpty/cywinpty.c(445): fatal error C1083: Cannot open include file: 'winpty.h': No such file or directory

Do you have winpty's binaries on your path @stonebig?

maybe not, and I don't have "bower" to compile spyder-terminal.... I see I'm badly equipped to digg on this issue... will wait official wheels

@stonebig, thanks for your effort. Our official v0.2 release will occur after the official release of spyder v3.2, however, any comment is welcome!

it would be nice if the "winpty" terminal feature was reproduced also per jupyterlab team

@stonebig, @ccordoba12 told me that the people at JupyterLab might be interested on this terminal server, however, we don't know yet if they are going to use it

I would prefer to have spyder-notebooks and spyder-reports well polished and stable today. Terminal may have a lot of incompatible  iteration to go to awesomness; jupyterlab and xonsh cross-sharing, powershell, ...

@stonebig, thanks a lot for trying our new plugins and for thinking to include them already in WinPython!

I would prefer to have spyder-notebooks and spyder-reports well polished and stable today.

I'd say they are pretty stable already, but we will know for sure when people start to use them. I really like the output of spyder-reports, it's beautiful!

Terminal may have a lot of incompatible iterations to go to awesomness

Spyder-terminal will be awesome on Windows! That has been the great work of @andfoy for its 0.2 version.

@stonebig Spyder-terminal is now available on Windows via PyPi, would you mind if you can give it a test run?
pip install -U spyder-terminal

will retry spyder-terminal today. I don't understand evolution state of spyder-unittest, so I may leave it aside


AWS: Request Access to ECR , s3, & ECS/EKS

Account Name
JimmyJuarez10
Project(s) Name
CivicTechJobs
Reason for access
ECR - Read/Write Docker Containers for our Application
S3 - Static File Hosting for Static Pages
ECS/EKS - Leaning towards ECS because it should be easier but need to investigate where to deploy our application.
Additional Information
No response

We need to move this issue over to incubator where we need to create these resources. Will need to understand who created the configuration files (in state file but not checked into codebase. @JimmyJuarez10 will investigate.


Stickers Won't Import Without Valid Emoji

If you try and send "" as the emoji field for your sticker data the import to Telegram never finishes and there is no error reported back to the base app

https://github.com/TelegramMessenger/TelegramStickersImport/pull/23


Permanently Deleting Data

Hi, I want to delete some specified segments and removes them from deep storage by kill task.
I posted my request of killTask after the datasource was disabled:
curl --request POST 'http://overload:8090/druid/indexer/v1/task' -H 'Content-Type:application/json' -d @killTask.json
killTask.json:
{
"type": "kill",
"id": "clean-2017-05-27T16:00:00.000Z",
"dataSource": "qns-cost",
"interval": "2017-05-27T16:00:00.000Z/2017-05-28T16:00:00.000Z"
}
it returned:
{"task":"clean-2017-05-27T16:00:00.000Z"}
But ,unfortunately , it seems that nothing happened to these segments, there still exist the segments I want to delete in HDFS.
There is an error in log from Coordinator Console:
2017-06-07 18:06:00,510 Thread-2 ERROR Unable to register shutdown hook because JVM is shutting down. java.lang.IllegalStateException: Not started
at io.druid.common.config.Log4jShutdown.addShutdownCallback(Log4jShutdown.java:45)
at org.apache.logging.log4j.core.impl.Log4jContextFactory.addShutdownCallback(Log4jContextFactory.java:273)
at org.apache.logging.log4j.core.LoggerContext.setUpShutdownHook(LoggerContext.java:256)
at org.apache.logging.log4j.core.LoggerContext.start(LoggerContext.java:216)
at org.apache.logging.log4j.core.impl.Log4jContextFactory.getContext(Log4jContextFactory.java:145)
at org.apache.logging.log4j.core.impl.Log4jContextFactory.getContext(Log4jContextFactory.java:41)
at org.apache.logging.log4j.LogManager.getContext(LogManager.java:182)
at org.apache.logging.log4j.spi.AbstractLoggerAdapter.getContext(AbstractLoggerAdapter.java:103)
at org.apache.logging.slf4j.Log4jLoggerFactory.getContext(Log4jLoggerFactory.java:43)
at org.apache.logging.log4j.spi.AbstractLoggerAdapter.getLogger(AbstractLoggerAdapter.java:42)
at org.apache.logging.slf4j.Log4jLoggerFactory.getLogger(Log4jLoggerFactory.java:29)
at org.slf4j.LoggerFactory.getLogger(LoggerFactory.java:284)
at org.apache.commons.logging.impl.SLF4JLogFactory.getInstance(SLF4JLogFactory.java:155)
at org.apache.commons.logging.impl.SLF4JLogFactory.getInstance(SLF4JLogFactory.java:132)
at org.apache.commons.logging.LogFactory.getLog(LogFactory.java:685)
at org.apache.hadoop.hdfs.LeaseRenewer.(LeaseRenewer.java:72)
at org.apache.hadoop.hdfs.DFSClient.getLeaseRenewer(DFSClient.java:699)
at org.apache.hadoop.hdfs.DFSClient.close(DFSClient.java:859)
at org.apache.hadoop.hdfs.DistributedFileSystem.close(DistributedFileSystem.java:853)
at org.apache.hadoop.fs.FileSystem$Cache.closeAll(FileSystem.java:2407)
at org.apache.hadoop.fs.FileSystem$Cache$ClientFinalizer.run(FileSystem.java:2424)
at org.apache.hadoop.util.ShutdownHookManager$1.run(ShutdownHookManager.java:54)
@gianm: Could your please help me solve this problem?

encountered the same issue here.

@PanYifeng @stevenchen3 Can you paste a gist link with the complete logs


No LQ_dataset.py

def create_dataset(dataset_opt):
mode =  "LQ" # dataset_opt["mode"]
if mode == "LQ":  # Predictor
from data.LQ_dataset import LQDataset as D
dataset = D(dataset_opt)
elif mode == "LQGT":  # SFTMD
from data.LQGT_dataset import LQGTDataset as D
dataset = D(dataset_opt)
elif mode == "GT":  # Corrector
from data.GT_dataset import GTDataset as D
dataset = D(dataset_opt)
Hello,
Thank you for sharing your code. I'm interested in testing it using LQ (Low Quality) images, but I noticed that the repository only includes GT_dataset.py and LQGT_dataset.py. Could you please upload the LQ_dataset.py file as well? It would be very helpful for my tests.
Appreciate your help.

Thank you for being so interested in our project. If you are only testing with LQ, we have just provided interface.py for reference aimed at the task of deraining. For more details, please refer to the latest version of the readme file.


Add static library creation

I'm using vlfeat in a hadoop pipes process, thus instead of installing vlfeat shared libraries on all hadoop nodes i just create a static library of vlfeat and compile it into the rest of my code.
Maybe somebody else would like to have option for static library and not just shared library of vlfeat

Hi,
thanks for the patch. However, VLFeat has a global state that is automatically initialised as part of the DLL construction to deal with things such as the random number generator and multiple threads. I am not sure what would happen with a statically linked version, but my guess is that the initialisation/destruction code would not be called automatically anymore.
Andrea

hey,
::: i'm using vl_dsift_* functions like this, and it runs good, although i haven't checked whether multithreading is working... but yeah as said i'm using it in a cluster so for me it's more important that i run it on different machines one process per core.


crash / stack overflow with malformed input pdf

Passing this pdf to qpdf will cause a crash:
https://crashes.fuzzing-project.org/qpdf-crash.pdf
Looking at the stack trace this seems to be an endless recursion causing a stack overflow.
Here's (part of) the stack trace when compiling qpdf with address sanitizer (latest git code):
==10615==ERROR: AddressSanitizer: stack-overflow on address 0x7ffdede32820 (pc 0x7f5ddac0dce7 bp 0x7ffdede33e50 sp 0x7ffdede32810 T0)
    #0 0x7f5ddac0dce6 in pcre_compile2 (/lib64/libpcre.so.1+0xace6)
    #1 0x78342b in PCRE::PCRE(char const*, int) /mnt/ram/qpdf/libqpdf/PCRE.cc:144:18
    #2 0x5ece64 in QPDFTokenizer::resolveLiteral() /mnt/ram/qpdf/libqpdf/QPDFTokenizer.cc:62:10
    #3 0x5f19be in QPDFTokenizer::presentCharacter(char) /mnt/ram/qpdf/libqpdf/QPDFTokenizer.cc:432:9
    #4 0x5f5091 in QPDFTokenizer::readToken(PointerHolder<InputSource>, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) /mnt/ram/qpdf/libqpdf/QPDFTokenizer.cc:519:6
    #5 0x5c461b in QPDFObjectHandle::parseInternal(PointerHolder<InputSource>, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, QPDFTokenizer&, bool&, QPDFObjectHandle::StringDecrypter*, QPDF*, bool, bool, bool) /mnt/ram/qpdf/libqpdf/QPDFObjectHandle.cc:873:13
    #6 0x5c4c07 in QPDFObjectHandle::parseInternal(PointerHolder<InputSource>, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, QPDFTokenizer&, bool&, QPDFObjectHandle::StringDecrypter*, QPDF*, bool, bool, bool) /mnt/ram/qpdf/libqpdf/QPDFObjectHandle.cc:939:15
    #7 0x5bcf0c in QPDFObjectHandle::parse(PointerHolder<InputSource>, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, QPDFTokenizer&, bool&, QPDFObjectHandle::StringDecrypter*, QPDF*) /mnt/ram/qpdf/libqpdf/QPDFObjectHandle.cc:841:12
    #8 0x53b4d0 in QPDF::readObject(PointerHolder<InputSource>, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, int, int, bool) /mnt/ram/qpdf/libqpdf/QPDF.cc:1020:31
    #9 0x550b21 in QPDF::readObjectAtOffset(bool, long long, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, int, int, int&, int&) /mnt/ram/qpdf/libqpdf/QPDF.cc:1396:27
    #10 0x565da2 in QPDF::resolve(int, int) /mnt/ram/qpdf/libqpdf/QPDF.cc:1477:7
    #11 0x5a71e7 in QPDF::Resolver::resolve(QPDF*, int, int) /mnt/ram/qpdf/include/qpdf/QPDF.hh:520:13
    #12 0x5a71e7 in QPDFObjectHandle::dereference() /mnt/ram/qpdf/libqpdf/QPDFObjectHandle.cc:1520
    #13 0x5a88ca in QPDFObjectHandle::isInteger() /mnt/ram/qpdf/libqpdf/QPDFObjectHandle.cc:145:5
    #14 0x53d465 in QPDF::readObject(PointerHolder<InputSource>, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, int, int, bool) /mnt/ram/qpdf/libqpdf/QPDF.cc:1121:23
    #15 0x550b21 in QPDF::readObjectAtOffset(bool, long long, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, int, int, int&, int&) /mnt/ram/qpdf/libqpdf/QPDF.cc:1396:27
    #16 0x565da2 in QPDF::resolve(int, int) /mnt/ram/qpdf/libqpdf/QPDF.cc:1477:7
    #17 0x5a71e7 in QPDF::Resolver::resolve(QPDF*, int, int) /mnt/ram/qpdf/include/qpdf/QPDF.hh:520:13
    #18 0x5a71e7 in QPDFObjectHandle::dereference() /mnt/ram/qpdf/libqpdf/QPDFObjectHandle.cc:1520
    #19 0x5a88ca in QPDFObjectHandle::isInteger() /mnt/ram/qpdf/libqpdf/QPDFObjectHandle.cc:145:5
    #20 0x53d465 in QPDF::readObject(PointerHolder<InputSource>, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, int, int, bool) /mnt/ram/qpdf/libqpdf/QPDF.cc:1121:23

Note to self: saved as qpdf/misc/bugs/51.pdf
I don't see a crash, but this looks like it may be addressed by the fixes to several other issues involving handling malformed dictionaries. See #36, #45, #64.

Hmm, surprised you don't see the crash. Still crashes for me with the latest git code.
As the crash actually happens in libpcre it may be a bug in there...

One of the things I hope to do in the next update is to use  from c++11 if building with a c++11 compiler and using pcre as a fallback if not available. What version of pcre are you using?

8.39, latest upstream version.

I  can reproduce this issue.

I am able to reproduce the issue. I am hoping to get to it imminently. I have found fixes for #100 and #101. Next I am going to investigate this and #99.

This one also has an easy fix.

This has been assigned CVE-2015-9252


Deployments with dynamic network fail unless director.local_dns.enabled is true

After upgrading my BOSH Director to v260, my Concourse deployment started failing on the next redeploy. The relevant error from the failing Concourse job was dial tcp: lookup f90b8b87-da14-4f2b-aa6c-8b70eea63f61.concourse.public-concourse.conco urse.bosh on <IP_ADDRESS>:53: no such host. Because my deployment used a dynamic network, BOSH decided to return a DNS record when one of the Concourse templates asked for spec.address. This is unexpected as I had not opted in to the new local_dns feature and these DNS records are all invalid. I would have expected the old spec.address behavior to be preserved if local_dns was not enabled, or an error message that prevented me from deploying with a dynamic network unless local_dns was enabled.

we are not yet ready to enable local_dns by default; however, i also do not want us to use IPs for links on dynamic networks since that's getting us farther from where we want to end up.

@cppforlife still, that's a breaking change – I don't think you should just do it like that.

this was always links behaviour for dynamic networks.
Sent from my iPhone

On Dec 6, 2016, at 12:55 AM, Marco Voelz<EMAIL_ADDRESS>wrote:
@cppforlife still, that's a breaking change – I don't think you should just do it like that.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

Then I maybe misunderstood @ljfranklin's statement. Lyle, did this work before?

this was always links behaviour for dynamic networks.

Maybe I jumped the gun a bit on the title.  I used a dynamic network to deploy this VM as I didn't require any fixed internal IPs. Prior to the latest BOSH director release (v260), the Concourse templates were able to resolve spec.address correctly, e.g. here. I'm not sure if spec.address was returning localhost or similar before, but the Concourse deployment was definitely working. Maybe this issue only affects single VM deployments that use links and dynamic networks?

@ljfranklin im pretty sure we werent using dynamic networks.

@cppforlife this was for my personal Concourse deployment.

I'm having the same issue with bosh and dynamic networks.  In my case, I'm using dynamic networks but bosh knows the IP addresses associated with the jobs and I do not have BOSH DNS enabled.  In a situation like this, I don't understand why links would generate DNS names instead of using the IP. Without BOSH DNS, there's little hope of resolving the addresses out of band - even if it is possible.
To me, this is behavior that should be configurable at the director level. There should be a small bit of configuration that says to prefer IP addresses (when known) to DNS names - even when using a dynamic network.

I'll also add that the user experience here is pretty awful. In the case of concourse, the my deployment was successful but ATC never started because the link to the postgres pointed to a black hole.
/cc @vito

I was also bitten by this, and the documentation is not clear:
Available instance object methods:
* address [String, non-empty]: IPv4, IPv6 or DNS record

Hi all,
Seeing as bosh-dns is post v1, this seems like less of an issue. We don't have plans to fix the underlying behavior because of this.
We're going to close this issue, but please feel free to reopen if you have any other concerns.
Best,
@jfmyers9 && @belinda-liu, CF BOSH


Cannot connect the server to agar.io

the server is not working now

I see you have an extension active. Disable your extension and try again.

I pull requested this issue. Fix is in #1156


Update eslint-plugin-unicorn to v40

I just ran generate:rules, is this correct way?

Theoretically yes, but after the generation I manually go through each file and check it.
Also I only comment those which are relevant, in this case please only commit the unicorn stuff and ignore the other rules.

Looks like you already did that, will review and double check it later when I have more time :slightly_smiling_face:

Hope I will find time in the next two evenings, sry for that delay

I don't really use this package, I'm just trying to help. No  rush.


question: registering without using "import"

Hi,
Is it possible to register the component without using a transpiler?
What component name should I be using?
my question is similar to the one in the following thread:
Can I register a third party component without importing it
Thanks on advance

Currently Vue-ECharts only provides the uncomipled source and the all-in-one UMD bundle on npm.
The UMD bundle can be used directly without transpiler:
// for CommonJS
var ECharts = require('vue-echarts')

thanks a lot!!!


internal/shader: support for integer vectors (ivec2, ivec3, and ivec4)

I was wondering if it was possible to provide support for more vector types since scalar types are already handled by Kage ?
I know glsl supports a vector type for each of them:

Each of the scalar types, including booleans, have 2, 3, and 4-component vector equivalents. The n digit below can be 2, 3, or 4:

bvecn: a vector of booleans
ivecn: a vector of signed integers
uvecn: a vector of unsigned integers
vecn: a vector of single-precision floating-point numbers
dvecn: a vector of double-precision floating-point numbers

Vector values can have the same math operators applied to them that scalar values do. These all perform the component-wise operations on each component. However, in order for these operators to work on vectors, the two vectors must have the same number of components.

Sure, I don't determine the priority but I can do.

This requires a lot of work. Let me defer this to v2.4.0.

I'm working on ivec. bvec would be another issue. I don't support uvec or dvec as WebGL doesn't.

https://registry.khronos.org/OpenGL/specs/es/3.0/GLSL_ES_Specification_3.00.pdf

vec3(float) // initializes each component of the vec3 with the float
vec4(ivec4) // makes a vec4 with component-wise conversion
vec4(mat2) // the vec4 is column 0 followed by column 1

Some vary basic tests didn't pass.


wrong function name

I love your plugin fantastic, i slowly come out from microsoft visual studio,
Unfortunately just after below code, function name is always displayed as Parse.
hope fixing this will make the plugin more robust.
LONG
Parse(
__in int argc,
__in_ecount(argc) char argv[]
)
/++
Routine Description:
Called by main() to parse command line parms

Arguments:
argc and argv that was passed to main()

Return Value:
Sets global flags as per user function request

--*/
{
int i;
BOOL ok;
LONG error = ERROR_SUCCESS;
for (i=0; i<argc; i++) {
    if (argv[i][0] == '-' ||
        argv[i][0] == '/') {
        switch(argv[i][1]) {
        case 'V':
        case 'v':
            if (( (i+1 < argc ) &&
                  ( argv[i+1][0] != '-' && argv[i+1][0] != '/'))) {
                //
                // use version in commandline
                //
                i++;
                ok = ValidateCoinstallerVersion(argv[i]);
                if (!ok) {
                    printf("Not a valid format for coinstaller version\n"
                           "It should be characters between A-Z, a-z , 0-9\n"
                           "The version format is MMmmm where MM -- major #, mmm - serial#");
                    error = ERROR_INVALID_PARAMETER;
                    break;
                }
                if (FAILED( StringCchCopy(G_coInstallerVersion,
                                          MAX_VERSION_SIZE,
                                          argv[i]) )) {
                    break;
                }
                G_versionSpecified = TRUE;

            }
            else{
                printf(USAGE);
                error = ERROR_INVALID_PARAMETER;
            }
            break;
        case 'l':
        case 'L':
            G_fLoop = TRUE;
            break;
        default:
            printf(USAGE);
            error = ERROR_INVALID_PARAMETER;

        }
    }
}
return error;

}

Are you able to format this into a pull request?

I've looked into this and I don't think that there's anything I can do about it.
The plugin uses SublimeText's scope system to find the closest meta.function that above the current line and assumes that we're in that function. There isn't a scope for "function has finished", so we can't detect when we leave the function.
If anyone has an idea on how to do this, then I'm all ears!