Infinite loop in TextEngine.getLayoutGroups()

I encountered that issue with html5 target on latest haxelib and npm distributions (8.8.0 at moment)
I extracted reproducible project with problematic swf asset at https://github.com/mrchnk/openfl-issue-textengine
That loop:
https://github.com/openfl/openfl/blob/8.8.0/src/openfl/_internal/text/TextEngine.hx#L1083
OS (Windows 10 x64)
Haxelib version 3.3.0
Haxe version 3.4.7
haxelib list
openfl-issue-textengine> haxelib list
actuate: [1.8.9]
box2d: [1.2.3]
format: [3.4.1]
hxcpp: [4.0.4]
hxp: [1.0.5]
layout: [1.2.1]
lime-samples: [7.0.0]
lime: 7.2.0 [7.2.1]
openfl-samples: [8.7.0]
openfl: 8.7.0 [8.8.0]

Any update on this one?
Simply having a TextField with "

" after some other string seems to reproduce this bug (also on the current development branch of openfl and lime 7.2.1). Like the following:
class Main extends openfl.display.Sprite {

    public function new () {
        super();
        var tf = new openfl.text.TextField();
        tf.htmlText = "
Hello

";
        addChild(tf);
    }
}

I get this in the console of firefox:
Error: Script terminated by timeout at:
setFormattedPositions@http://localhost:2000/BacklineIssue.js:49428:11
getLayoutGroups@http://localhost:2000/BacklineIssue.js:49583:5
update@http://localhost:2000/BacklineIssue.js:49865:4
__updateLayout@http://localhost:2000/BacklineIssue.js:69149:4
__renderGL@http://localhost:2000/BacklineIssue.js:68554:5
__renderGL@http://localhost:2000/BacklineIssue.js:3885:6
__renderGL@http://localhost:2000/BacklineIssue.js:3885:6
__renderGL@http://localhost:2000/BacklineIssue.js:3885:6
__render@http://localhost:2000/BacklineIssue.js:56063:4
__onLimeRender@http://localhost:2000/BacklineIssue.js:58581:5
f@http://localhost:2000/BacklineIssue.js:73462:233
dispatch@http://localhost:2000/BacklineIssue.js:14428:16
handleApplicationEvent@http://localhost:2000/BacklineIssue.js:351:6
exec@http://localhost:2000/BacklineIssue.js:327:3
exec@http://localhost:2000/BacklineIssue.js:602:10
ApplicationMain.create@http://localhost:2000/BacklineIssue.js:975:15
$hx_exports.lime.embed@http://localhost:2000/BacklineIssue.js:22175:4
@http://localhost:2000/:43:3

Something that may help:

"
Hello

" fails
"

" works
"
Hello

Hello
" works

It sounds like these are two separate issues, as the second one doesn’t look like it has anything to do with SWFs.

When there is a line break in the text field of a SWF, it becomes

 in OpenFL, which I think could be the origin of the issue

Ahhhhh ok now we’re getting somewhere if that’s correct.

Ok nice, I can replicate this as well with the htmlText "a

". I'll try to debug it when I can, likely this weekend. Trying to put some coding time back into my week

Temporary fix, haven't compiled units or anything: htmlparser diff.txt
The issue seems to be that although
 and
 add a newline, the text format ranges are not updated to reflect the fact that you just added a new character to the parsed string. This is in src/openfl/_internal/formats/html/HTMLParser.hx

@MSGhero This also looks interesting:
https://github.com/Kixeye/openfl/pull/3/files

@jgranick I was thinking about that recently... but we wouldn't necessarily know if there was an issue, versus a very hard "there's something wrong with text layout." I guess from your perspective, the lib not crashing internally is pretty good :D

A Log.warn might be a compromise to prevent and infinite loop, but still know that something is not right

Got it

Well, I haven't committed the fix for this issue specifically, where the format range isn't being adjusted on


Doesn't work at all.

I think this project is completely abandoned at this point.
The demo example just gets you a 404 page.
And, when i tried to work with this lib, the compiler shouted errors about the library itself (in the core node_modules files): "Cannot read property 'bool' of undefined".

Same for me.
Upgraded my React project from React15 to React16 and I get the same error
Uncaught TypeError: Cannot read property 'bool' of undefined at Object.1037../Utilities/DOMPositionUtils
Looks like I might have to find an alternative to replace the current functionality. any ideas?

PropTypes has moved to it's own library, hence the error. Just copy the component into your project instead and you can resolve yourself.

PropTypes has moved to it's own library, hence the error. Just copy the component into your project instead and you can resolve yourself.


C&P from plain text viewer is missing line feeds

If you try to copy and paste the contents of the plain text viewer line feeds are missing from the pasted data.

I can't reproduce this. When I copy a section into a plaintext editor, new lines are there. In fact an extra new line per line is pasted....

Fixed with new viewer


Add issue template configuration to redirect users

Resolves #3435

This is a release management task, as per our policy, we are are self approving it.


Symlinked pg_xlog errors when combined with archive-copy

pg_xlog (or any other top-level postgres directory) should be created in the repo as a directory, then recreated as a symlink on restore.
Warnings should be generated when restoring symlinks.

Closed in 9ab0dd80f70cc69a6edc9e61b6053752.


Restoring Terminal (Powershell)

Type: Bug
Each time VSCode terminal 'restores a session', it puts the directory at the root folder that is open within VSCode. It does not open to the last directory used. This is inconvenient, as my class folder has a pre-populated folder for each week, and a folder for each assignment within it. I have to renavigate to each week's folder and the selected assignment folder. Some assignments require more than one terminal, and this makes it inconvenient.
VS Code version: Code 1.71.2 (74b1f979648cc44d385a2286793c226e611f59e7, 2022-09-14T21:03:37.738Z)
OS version: Windows_NT x64 10.0.19044
Modes:
Sandboxed: No

System Info

Item
Value

CPUs
Intel(R) Core(TM) i5-7300U CPU @ 2.60GHz (4 x 2712)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: disabled_offdirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okskia_renderer: enabled_onvideo_decode: enabledvideo_encode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabledwebgpu: disabled_off

Load (avg)
undefined

Memory (System)
15.86GB (10.39GB free)

Process Argv
--crash-reporter-id 66fcb6a2-4c36-4c8e-9732-f2b505c554e9

Screen Reader
no

VM
0%

Extensions (12)

Extension
Author (truncated)
Version

doxdocgen
csc
1.4.0

better-cpp-syntax
jef
1.15.19

python
ms-
2022.14.0

vscode-pylance
ms-
2022.9.40

remote-containers
ms-
0.251.0

remote-ssh
ms-
0.84.0

remote-ssh-edit
ms-
0.80.0

remote-wsl
ms-
0.66.3

cmake-tools
ms-
1.12.27

cpptools
ms-
1.12.4

cpptools-extension-pack
ms-
1.3.0

cmake
twx
0.0.17

(1 theme extensions excluded)

A/B Experiments
vsliv368:30146709
vsreu685:30147344
python383cf:30185419
vspor879:30202332
vspor708:30202333
vspor363:30204092
vswsl492cf:30256860
vslsvsres303:30308271
pythonvspyl392:30443607
vserr242cf:30382550
pythontb:30283811
vsjup518:30340749
pythonptprofiler:30281270
vshan820:30294714
vstes263:30335439
vscoreces:30445986
pythondataviewer:30285071
vscod805:30301674
binariesv615:30325510
bridge0708:30335490
bridge0723:30353136
cmake_vspar411cf:30557515
vsaa593cf:30376535
pythonvs932:30410667
cppdebug:30492333
vsclangdf:30486550
c4g48928:30535728
hb751961:30553087
dsvsc012:30540252
azure-dev_surveyone:30548225
2144e591:30553903
fc301958:30573243

Please provide a screenshot or a gif illustrating the problem (attaching images won't work via email, you need to go to github.com). See this wiki page for more general info on how to report actionable terminal issues.
Also, check your terminal.integrated.cwd setting as that will take precedence
/label info-needed terminal

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.
Happy Coding!


Do you want logo?

Hi,
I am graphic designer. I would like to prepare a logo for your application.
If you accept I can prepare this logo for you with great pleasure.
I wait for your response.

I'm glad you can see my project，
How is going specifically?


Tools installation docs are not entirely true about apt repository signing key and Kubernetes version

This is a Bug Report

Problem:
https://kubernetes.io/docs/tasks/tools/install-kubectl-linux/#install-using-native-package-management says

The same signing key is used for all repositories so you can disregard the version in the URL:

This is not entirely true, as the current key is only present in versions 1.28 and above, while 1.27 and below have expired key. I understand that versions below 1.27 are no longer supported, but it's likely that the same problem occurs after the current key expires on 2026-12-29, only with different version numbers.
Proposed Solution:
Rephrase the statement about signing key and Kubernetes version so it's clear that it's not the same key for all repositories, e. g. changing it to "all supported versions".
Page to Update:
https://kubernetes.io/docs/tasks/tools/install-kubectl-linux/#install-using-native-package-management

What repositories are you thinking of @slabstone? I don't think there's a repository for v1.27 Kubernetes, at least not one published by the Kubernetes project.

You can add repository for versions 1.24 throught 1.27 using the current docs and install kubectl if you bypass apt signature verification.
Selected version '1.24.17-1.1' (isv:kubernetes:core:stable:v1.24:pkgs.k8s.io [amd64]) for 'kubectl'
...
Get:1 https://prod-cdn.packages.k8s.io/repositories/isv:/kubernetes:/core:/stable:/v1.24/deb  kubectl 1.24.17-1.1 [9543 kB]

AIUI we don't document that https://prod-cdn.packages.k8s.io/ works; this is an internal implementation detail. You should not rely on this.
For the documented ways to download Kubernetes, see https://kubernetes.io/releases/download/

/priority awaiting-more-evidence


Use C++20 function std::popcount

High Level Overview of Change
Remove the custom code and special compiler functions and use C++20 function std::popcount and make inline for optimization of the code. The changed code is good when compiled and  produces same or even better assembly code which you can see on the compiler explorer

Context of Change

Type of Change

[X] Refactor (non-breaking change that only restructures code)

CI has reported failures; please review them.

This change is required to compile on macOS: https://github.com/HowardHinnant/rippled/commit/ab5e386a39e9f77c91051262e06ca80127d9552a
Explanation:  The expression isBranch_ | (1 << m) promotes to int which is then sent to std::popcount.  But popcount has a constraint that its argument be an unsigned integral type.  Adding the u suffix makes the expression unsigned.

@a-noni-mousse please review the comments above.

@a-noni-mousse for future reference - there's no need to force push, as this PR will be squashed when it is merged.
Keeping historical commits may help reviewers to more easily see how the PR has changed over time.

@a-noni-mousse - going forward, please sign your commits, as mentioned in CONTRIBUTING. (Past commits are fine to leave as-is)

There's a branch protection rule that requires commits to be signed in order to be merged. It can be bypassed, but it's preferable to sign commits to provide some assurance about their integrity.

Suggested commit message for squashed commit:
refactor: use C++20 function std::popcount (#4389)

- Replace custom popcnt16 implementation with std::popcount from C++20
- Maintain compatibility with older compilers and MacOS by providing a
  conditional compilation fallback to __builtin_popcount and a lookup
  table method
- Move and inline related functions within SHAMapInnerNode for
  performance and readability

@manojsdoshi - be sure to squash this PR when merging, as requested above.


moved described-as and is matchers

#139

@rultor merge

@rultor merge

@graur OK, I'll try to merge now. You can check the progress of the merge here

@rultor merge

@graur Done! FYI, the full log is here (took me 3min)


STOP_AND_RESET_ENCODER often doesn't stop motors

tl;dr:  Switching a DcMotorEx into STOP_AND_RESET_ENCODER mode doesn't always stop the motor -- the motor continues to receive power.  Here's the bottom-line image of the issue at work, where a motor is in STOP_AND_RESET_ENCODER mode but the motor is drawing nearly 7 amps as it has reached its mechanical limit of travel and is stalled:

This issue was first identified and has been discussed at https://ftc-community.firstinspires.org/t/stop-and-reset-encoder-sometimes-doesnt-stop-motor/922 , along with some potential workarounds.  I've also made a YouTube video that demonstrates the problem at https://youtu.be/rkFPpIvgoFs .
The bottom line so far seems to be that executing .setMode(STOP_AND_RESET_ENCODER) within 470ms (0.47s) of switching a motor to RUN_USING_ENCODER or RUN_TO_POSITION will reset the encoder value but will continue powering the motor according to the previous mode.   A simple program demonstrating this behavior is attached as TRunMode.java.txt .  I can also provide additional video demonstration if desired.
This incorrect/undocumented behavior seems to have been the "silent killer" for many of our team's burnt-out (literally) motors and degraded batteries over the past several seasons, as motors ended up in stall conditions for long periods of time when the program indicated they should be idle/depowered.
The Javadocs (https://javadoc.io/doc/org.firstinspires.ftc/RobotCore/latest/com/qualcomm/robotcore/hardware/DcMotor.html) claim that a side effect of STOP_AND_RESET_ENCODER is that power is removed from the motor.  There's a blurb mentioning that some motor controllers will "automatically transition to a different mode after the reset" but if this is occurring, it's happening silently -- i.e. .getMode() still reports STOP_AND_RESET_ENCODER even as it continues sending power to the motor.  It would also surprise me if the REV controllers are part of the category of "automatically transitioning controllers", but perhaps they are the reason for the additional blurb in the Javadocs.
At the least, the fact that STOP_AND_RESET_ENCODER doesn't actually remove power to a motor in some circumstances should be mentioned in the documentation.  As our team has now discovered, mechanisms using limit switches and having mechanical limits on travel can easily find the motors placed in a stall condition because the STOP_AND_RESET_ENCODER didn't actually remove power as expected/documented.
Ideally the mode would be fixed so that the 0.4sec delay isn't needed and STOP_AND_RESET_ENCODER always does what it claims.
If the REV controllers are in the class of controller that automatically transitions to another mode after resetting the encoder, then the .getMode() method should reflect the results of that transition.
Another improvement might be to provide a .resetEncoder() API method that doesn't change the mode of the DcMotor at all -- a lot of beginner-level programming could be greatly simplified if this feature were available.  The most common example is switching between RUN_USING_ENCODER and RUN_TO_POSITION for manual and "automatic preset" positioning of hardware mechanisms.  Yes, a work around for this is for programmers to maintain their own "zero offset" variable in code, but this adds some level of complexity to coding and a rich source of bugs/edge cases to consider, which is more challenging for newer programmers and coaches.  Setting a zero-point without changing the run state really feels like it's a fundamental operation that should be made more available in the API.
I'm glad to provide more details as needed, either in this issue ticket or on the community forum thread.  Thanks for reading.

Hi  I read this and was pretty surpized that I had never encountered it....
I will say that I have always beleived that STOP_AND RESET_ENCODERS did remove power from the motors, but I admit I typically explicitly set the motor power to zero as well.    There were some very odd timing constraints when resetting the motor controller encoders back in the days of ModernRobotics, but none of that code should exist any more....
While you do further tests, I would be interested to see if any of this is triggered explicitly from using DCMotorEx rather than DC Motor.  I know DCMotorEx is required for setVelocity, but if you were to temporarilty replace this with setPower, you could revert to using plain DCMotor.

It does actually reset to zero.  Keep in mind that it resets the encoder at the point where .setMode(STOP_AND_RESET_ENCODER) is performed, but if the mechanism continues moving while in the mode the encoder will continue to update from the new zero point.   So the -13 and -11 values that are being displayed in the video are because the elevator has continued moving past the magnetic limit switch detection point to its physical limit, not because the mode failed to reset the encoder.
If you try the experiment with the TRunMode.java sample attached to this issue ticket with a motor that isn't mechanically limited (as the elevator is mechanically limited in the youtube video), you can easily observe that the encoder does get reset to zero when STOP_AND_RESET_ENCODER is invoked, but then the current position updates from that new zero position as the motor continues spinning.  (I went ahead and made a video of this, at https://www.youtube.com/watch?v=J2L_vV2dSN0 .)
I'll test with DcMotor at some point... but we really prefer to use .setVelocity() on our devices (it's the current recommendation, as I understand it), and not have to go back to .setPower() as a workaround.
Pm

There is a checkered history behind RESET_ENCODER (same as STOP_AND_RESET_ENCODERS) that goes back to Modern Robotics motor controllers. So this is a possible clue to this issue.
Note:  I wasn't suggesting a switch to setPower(), simply proposing a test to see if it changed the behavior.  So, if you get a chance it may accelerate finding a solution.
Phil.

I tried .setPower() overnight and found a funny behavior; described in https://ftc-community.firstinspires.org/t/stop-and-reset-encoder-sometimes-doesnt-stop-motor/922/7 .
The tl;dr is that performing a .setPower() while in RUNNING_WITHOUT_ENCODER mode seems to make any subsequent STOP_AND_RESET_ENCODER modes work entirely as expected, even after going into RUN_USING_ENCODER or RUN_TO_POSITION and then quickly switching back.
In the case of the TRunMode.java test script, simply executing .setPower(0) at any point prior to the while(opModeIsActive()) loop makes everything work properly in my tests.
As described in the community forum post... why a single .setPower(0) invocation in a seemingly unrelated RunMode has this effect is a complete mystery to me, and it's those sorts of mysteries that keep me awake at night because we can't be sure that some other bizarre behind-the-scenes behavior won't cause it all to stop working again.
Pm


fixed system_services.sh

I needed to change system_services.sh in order to run
docker build image

successfully. The installation of syslog-ng failed because apt-get install will try to start the syslog-ng service before system_services.sh has the chance to modify the syslog-ng configuration.
Running RUNLEVEL=1 apt-get install ... will prevent this.

Your changes appear to be specific for armv7. I do not believe these changes are appropriate for the upstream repository.

Hi,
thank you for taking the time reviewing my pull request. The request was meant to consider the changes in system_services.sh only. The changes there are not armv7 specific and shouldn't cause any harm on other ubuntu platforms. The Dokerfile of course is bound to a specific cpu platform. You may include a Dockerfile.armv7 or Dockerfile.armhf in your project with the contents of my version. This seems to be the canonic way how to differentiate between the cpu platforms (see for example https://github.com/resin-io/docker).

Am 20.01.15 um 11:04 schrieb Hongli Lai:

Your changes appear to be specific for armv7. I do not believe these
changes are appropriate for the upstream repository.
—
Reply to this email directly or view it on GitHub
https://github.com/phusion/baseimage-docker/pull/177#issuecomment-70630600.

Hi,
thank you for taking the time reviewing my pull request. The request was
meant to consider the changes in|system_services.sh|only. The changes
there are not armv7 specific and shouldn't cause any harm on other
ubuntu platforms. The|Dokerfile|of course is bound to a specific cpu
platform. You may include a |Dockerfile.armv7|or|Dockerfile.armhf|in
your project with the contents of my version. This seems to be the
canonic way how to differentiate between the cpu platforms (see for
examplehttps://github.com/resin-io/docker).


Relations as members of Relations

Relations can also have other Relations as their members. Currently they are simply ignored by overpy.
I'll provide a fix later.

Your fix has been merged into the master branch. Thanks for your contribution.


Update index.yml

@mimckitt : Thanks for your contribution! The author(s) have been notified to review your proposed change.


Adding dynamic additional value?

Is it possible to add a dynamic value to log entry? SPecifically, i want to add request ID, but so far I saw no mechanism. Seems like pretty frequently required feature

Hello, maybe you figured it out already, but I managed to make it work. I don't know if it is the proper way though. But it works for me :
What I did was :
I defined the class "MyJsonProvider" in my project, as described in the readme, and added two variables, one representing the value-name for the property I wanted to add, and an other one for the value of the property itself. It looks like that :
package my.package;

import javax.inject.Singleton;
import java.io.IOException;

import io.quarkiverse.loggingjson.JsonProvider;
import io.quarkiverse.loggingjson.JsonGenerator;
import org.jboss.logmanager.ExtLogRecord;

@Singleton
public class MyJsonProvider implements JsonProvider {

    public String FIELD_NAME= "field.name";
    public String FIELD_VALUE= null;

    @Override
    public void writeTo(JsonGenerator generator, ExtLogRecord event) throws IOException {
        generator.writeStringField(FIELD_NAME, FIELD_NAME);
    }
}

Then, in the class where I wanted to use this property dynamically, I injected the dependence like so :
package my.other.package

import javax.inject.Inject;

public class MyClass {
    // ...
    @Inject
    MyJsonProvider jsonProvider;
    // ...

    public void myMethod() {
        // defining my value
        String value = "Value1234";

        jsonProvider.FIELD_VALUE = value;
    }
}

Without doing anything else besides adding the proper configuration in my application.properties as explained in the readme, this works for me.
I assume this works for as many fields as you want. Using this method I couldn't tell the limitations but yeah, give it a try.


Adding arguments to bash script

Hello, I would like to know if there is possible to add arguments when execute a bash script.
I'm able to execute scripts from the Execute Command/Script/Program with no issues when there are no arguments. Like this:
/home/username/Scripts/./Activity1.sh
I have one script that controls almost all of my stuff but I just need to add the proper argument. I would like to run some like this:
/home/username/Scripts/./Master.sh TVON
This works great from my terminal.
In HA-bridge I get a success message when I push the Test ON button but the script is executed without the argument added to the line.
I haven't found any information in the documentation nor googling.
Any ideas?
Thanks!
V5.3.0

Hey @feriniguez,
Yes, I use a bash script to control blinds with arguments, my ON / DIM / OFF items in HA-Bridge are the following:

ON: /home/pi/habridge/blinds.py True
DIM: /home/pi/habridge/blinds.py True ${intensity.percent}
OFF: /home/pi/habridge/blinds.py False

Ok, it is good to know that the feature is there... however I can not get it working.
I have tried adding | sh | bash | exec:// | at the beginning of the line but no success...
The script have (just for testing) 777 permissions.

Ok I found the solution...
My script used the paths to files in the form:
~/directory/to/file.txt
It worked without issues directly from the terminal or ssh'ing to the host and running the script.
It didn't work from ha-bridge.
I did some testing and noticed that the script wasn't getting the info from the files. So I changed the paths to:
/home/username/directory/to/file.txt
and worked!
I don't really know why just from ha-bridge you need the absolute path but I'm happy I found the solution.
Closing.


In certain situations, 1.5.1 adds duplicate dependency declarations to the gemspec

If 1.5.1 sees a Gemfile, it puts the dependencies found in the :production and :development groups into the generated .gemspec. However, if those same dependencies are also declared in a Rakefile inside a Jeweler::Tasks.new definition, jeweler ends up listing the same dependencies twice in the .gemspec file it generates.
The workaround is to only put the dependency declarations into one place for now. So if the project has a Gemfile, the easiest thing to do is to just remove the dependency declarations from the Rakefile.

@technicalpickles This runs counter to the README.md Dependencies section

Use gem.add_dependency to register them.

There is an issue with the documentation, and I will take a look at this shortly.


Docker EACCES permission denied

SUMMARY

I'm running Node-RED in a docker container. Everything else works fine. I've even used the contrib-alexa-local palette with no problems. The nodered container is running as root (--user 0, and also tried --user root). I'm using --network host (also tried --net=host). I'm still getting the Error: listen EACCES: permission denied <IP_ADDRESS>:80.
I've tried the iptables settings on the host system (i.e. outside the container), the Node RED container doesn't have iptables installed.
ECHO DEVICES

2x Echo Dot 2nd generation
1x Echo Dot 3rd generation
MODULE VERSION

0.1.8

CONFIGURATION

![image](https://user-images.githubusercontent.com/45885373/52917323-e2096980-329e-11e9-93da-4a50eef2b9d0.png)

Not sure if the image is showing, but basically, I've just got the Amazon Echo Hub, and under it is a red warning stating Unable to start on port 80

CONSOLE OUTPUT

17 Feb 18:27:55 - [info] Starting flows
17 Feb 18:27:57 - [info] Started flows
17 Feb 18:27:57 - [error] Error: listen EADDRINUSE :::80
    at Server.setupListenHandle [as _listen2] (net.js:1360:14)
    at listenInCluster (net.js:1401:12)
    at Server.listen (net.js:1485:7)
    at new AmazonEchoHubNode (/data/node_modules/node-red-contrib-amazon-echo/index.js:47:20)
    at createNode (/usr/src/node-red/node_modules/node-red/red/runtime/nodes/flows/Flow.js:305:18)
    at Flow.start (/usr/src/node-red/node_modules/node-red/red/runtime/nodes/flows/Flow.js:89:35)
    at start (/usr/src/node-red/node_modules/node-red/red/runtime/nodes/flows/index.js:328:29)
    at tryCatchReject (/usr/src/node-red/node_modules/when/lib/makePromise.js:845:30)
    at runContinuation1 (/usr/src/node-red/node_modules/when/lib/makePromise.js:804:4)
    at Fulfilled.when (/usr/src/node-red/node_modules/when/lib/makePromise.js:592:4)
    at Pending.run (/usr/src/node-red/node_modules/when/lib/makePromise.js:483:13)
    at Scheduler._drain (/usr/src/node-red/node_modules/when/lib/Scheduler.js:62:19)
    at Scheduler.drain (/usr/src/node-red/node_modules/when/lib/Scheduler.js:27:9)
    at _combinedTickCallback (internal/process/next_tick.js:132:7)
    at process._tickCallback (internal/process/next_tick.js:181:9)

STEPS TO REPRODUCE

Not much to describe
EXPECTED RESULTS

ACTUAL RESULTS

Using root rights on node red produces unexpected and indesiderabile results. Avoid it. I suggest you install all again with no root.
Port mapping as described some times around here works simply perfect. I suggest you to use wha alreadyt people guarantee it's working, and not experiment yourself, save your time! )

Hmm... OK, will try without root. Will report results.

It works. Thanks @Barabba11


SSL pinning not working on the Webview request domain

Hi,
When loading the request URL on the UIWebview and do intercept the request URL using  Charles we can see the all the request and response.
Does TrustKit support Webview SSL pinning?
SDK TrustKit version 1.6.5
We are passing the valid kTSKPublicKeyHashes.
Sample code snippet
        let trustKitConfig = [
            kTSKSwizzleNetworkDelegates: true,
            kTSKPinnedDomains: [
                “www.requestdomain.com”: [
                    kTSKIncludeSubdomains : true,
                    kTSKPublicKeyAlgorithms: [kTSKAlgorithmRsa2048],
                    kTSKPublicKeyHashes: [
                        “HashKey1”,
                        "HashKey2”
                    ],]]] as [String : Any]
        TrustKit.initialize(withConfiguration: trustKitConfig)

Please assist on this issue.

Hello,
Trustkit does not support UIWebView,, but it does support WKWebView (https://developer.apple.com/documentation/webkit/wkwebview?language=objc).

Hi @nabla-c0d3
Thanks for details.
We used WKWebView only but it is in the react-native library
We load the URL on WKWebView but TrustKit used from Native side. SSL pinning happened API domain request(API layer managed from React native side).
The SSL pinning not happened  WKWebView URL request.
Please let me know if any changes need to be done from the Native side?

@nabla-c0d3 Any help on this?
We load the URL on WKWebView but TrustKit used from Native side. SSL pinning happened API domain request(API layer managed from React native side).


changes to calc_streak to prevent silent failure

This function was a little too specialized before. In the probability lab, students were accidentally running it on a sequence of "heads" and "tails", saving the results, and trying to plot them. They knew the plot looked wrong (one tall bar at 0 instead of a distribution) but it was hard for them to troubleshoot back to the source.

Added a warning message so it is clear when it has failed.
Parameter streakvar allows the function to be used on other types of streaks if desired.

That error message is very helpful. I'm less sure about if we need to generalize this function. What is the primary benefit? I guess I see it as: it would serve those students who either didn't quite follow directions or went off experimenting on their own. The cost would be having a bit more complicated tab-complete menu and help file. I don't think the latter is non-trivial. I've seen students think they need to specify every available argument and spend a lot of time trying to figure out what each of those arguments mean.
In general, attuning students to more complicated functions can be a good learning goal of these labs, but this is often taught as the third lab, which seems a bit early.

Hmm, I see your point. We did this lab in week 8, so the parameter thing isn't as big a deal. Still, I think the function could be a little bit more generally useful. For example, @beanumber has an exercise in the class notes where students try to generate random sequences of heads and tails, then we show we can pick that sequence out based on the streak lengths. We use rle() there, but it might be a little nicer to use calc_streak() for consistency.


Base font size not propagating correctly across token sets

Describe the bug
When using two token sets with Font Size and Base Font Size tokens, the base font size does not propagate until the token set is disabled and enabled twice.
To Reproduce

Create a token set labeled set A
Add a few Font Size tokens in REM (ex: 50 = 0.75rem, 100 = 1rem, 200 = 1.50rem), label the group of tokens fontSizes
Create a base font size token in px (ex: 16px) as a Font Size type, label the group baseFontSize
Set the base font size in the settings panel to reference the baseFontSize token.
Create an additional token set, labeled set B
Duplicate the group fontSizes to set B
Duplicate the baseFontSize group to set B
Style text in Figma using tokens from set A
With set A activated, enable set B

Expected behavior

Font size tokens update
Base font size tokens update

Actual behavior

Font size changes
Base font size does not change

It will work if...
Toggle set B on and off twice it will first change the font size tokens, then on the second activation it'll update the base font size.

Test File for this Issue

@six7 I am not able to replicate this bug with the V2B build so I believe it can be closed for now.


Quantum - bakeApiIntoBundle broken by uglification

When bakeApiIntoBundle is set the Quantum bundle writer will attach the fuse-box api to the front of the given file and then append a newline, if uglify is enabled this newline will get removed.
targetBundle.generatedCode = new Buffer(this.core.api.render() + "\n" + targetBundle.generatedCode);
This produces (after uglification):
!function(){ *api bundle* }()(function(n){ *our bundle* })($fsx)
When trying to run this the browser will error:
Uncaught TypeError: (intermediate value)(...) is not a function
I'm assuming it reads the above code as: api bundle gets called, then its result gets called with the next bundle, which gets called with $fsx - this seems wrong to me.

@UncleDave I think you need to update fuse-box
It has been fixed 2.2.0-beta.13

Oh cool I've just been sitting on 2.1.0

@UncleDave check betas from time to time. there is a major update coming

That is a juicy one.


Failed AZD Up locks docker engine

Created issue from user's feedback:
https://teams.microsoft.com/l/message/19:ug5DKpbpRJbBtgoSQAXdynHgthpALgePNJ8wb5AI8HM1@thread.tacv2/1698779928463?tenantId=72f988bf-86f1-41af-91ab-2d7cd011db47&groupId=c99e8504-1250-4d95-a824-9778e0e626c7&parentMessageId=1698779928463&teamName=Azure Developer CLI (azd) Partners&channelName=General&createdTime=1698779928463
Description:
I am deploying my container to an Container App and it failed. When it failed it also locked the docker engine to where any command to unlock failed. If you run any docker command you get an error asking if the Docker Daemon is running. The only way I've been able to proceed has been to reboot my computer. I am using WSL 2 Ubuntu 20.04 with the lastest AZD version. How can I resolve this in case of future build errors

@vhvb1989 ran into this issue lately?

Didn't hear about this again


Apify.launchPuppeteer() now supports proxyUrl with socks4, socks5 and https schemes

Fixes https://github.com/apifytech/apify-js/issues/420

Does it also fix https://github.com/apifytech/apify-js/issues/389 ?

Does it also fix #389 ?

Only partially - Socks is supported only if used without authentication.


error

Traceback (most recent call last):
  File "/Library/Python/2.7/site-packages/gevent/greenlet.py", line 327, in run
    result = self._run(*self.args, **self.kwargs)
  File "crackmapexec.py", line 1766, in connect
    smb.login('' , '')
<<redacted>>
<Greenlet at 0x1047b1190: connect('<<x.x.x.x>>')> failed with error

needs to handle the exception may be ?

@pr4jwal I need the original traceback without redactions to understand whats going on :P
also any exception from that function call is handled https://github.com/byt3bl33d3r/CrackMapExec/blob/master/crackmapexec.py#L1766

@pr4jwal I'm closing this since, I can't reproduce this in any way.. feel free to comment below


Fix like and dislike buttons in display question page

All the changes are detailed in the commits comments,
Also, see the issue below to see how the page looks with the buttons
fix #89

I see that in a lot of tests you are fetching user from DB and then login.
In my last PR (#113 ) I added the file conftest.py that there are some useful fixtures there (you are invited to add some if you think that they will be relevant to the rest of us) , one of them is
authenticated_user  , that is do just that (fetching and login user). you don't need to import anything just add to your function parameters the parameter: authenticated_user.
then the client will be already logged in and you can test the rest of the logic.
you can se examples to the use of this fixture here

I see that in a lot of tests you are fetching user from DB and then login.
In my last PR (#113 ) I added the file conftest.py that there are some useful fixtures there (you are invited to add some if you think that they will be relevant to the rest of us) , one of them is
authenticated_user  , that is do just that (fetching and login user). you don't need to import anything just add to your function parameters the parameter: authenticated_user.
then the client will be already logged in and you can test the rest of the logic.
you can see examples to the use of this fixture here

Thanks for the comment and suggestion.
In my case, I need to use Rebecca's user for the specific likes/dislikes test data,
Also, I'm using the client.force_login instead of client.login, as suggested by Barak, and from reading about it, this way the tests are less time-consuming because force_login does login quicker by skipping all the authentication part.

The button appearance has changed, you can see the images in the linked issue.


Strange Line Breaks

I am wrapping the entire contents of a layout template in minify tags – but the output is still over 500 lines long. Possibly attributable to breaks like these which seem to be added in following the opening of new tags.

This is actually an intentional effect of the Minify library that my Minify plugin is using.  If you copy that page source text out, and look at it carefully, you'll see that that's happened is where there used to be a space character after an opening tag, it's been replaced with a line feed character \n
I can guess that they did this because it makes the text somewhat more readable, while still being as compressed as possible.
It's valid as part of the HTML spec as well.  Kinda nifty.

OK – but I don't minify to make source code more readable. On the contrary, I minify to obscure hacky and/or hastily written code. Oh, and performance.

Here's the official answer from the Minify FAQ:
Why do the CSS & HTML minifiers add so many line breaks?
TL;DR: Ignore them. They don't add to the output size and if you absolutely want all content on one line you will have to use another tool.
It's rumored that some source control tools and old browsers don't like very long lines. Compressed files with shorter lines are also easier to diff.
Since both Minify classes are regex-based, it would be very difficult/error-prone to count characters then try to re-establish context to add line breaks. Instead, both classes trade 1 space for 1 line break (\n) wherever possible, adding breaks but without adding bytes.
If you can think of another safe & efficient way to limit lines in these two tools without adding bytes, please submit a patch, but this is not something anyone should be worrying about.

I love that the felt compelled to dedicate four paragraphs to this – must be a lot of other developers with low-level OCD frustrated not to see one long single line of code.

Compressed files with shorter lines are also easier to diff.

But I don't buy this – or at least, it doesn't seem to be a issue for extremely large chunks of JS. Also, I guess there could be a good use case for needing to diff compressed code, but it might also be an edge case.
Anyway. Thanks! I'll live with it. ;-)

yeah it sounds like he was annoyed by the number of people saying "but how come my minified HTML isn't minified, it has line breaks!" or such.
But it's perfectly harmless.


fix: serializing date and carbon objects

When trying to serialize properties that have date objects or carbon objects like when queuing a closure, I'm facing bugs/warnings similar to this:

PHP Warning:  serialize(): "date" returned as member variable from __sleep()
The DateTime object has not been correctly initialized by its constructor

I found that the issue is with serializing the date objects and php version. Also found similar PRs.
https://github.com/opis/closure/issues/75
https://github.com/opis/closure/pull/113

This is my exact use case:
dispatch(function () {
    AuditLog::create($this->attributes);
 })->onQueue('audit_logs');

$attributes is an array sometimes contains date and date time objects to be saved per model, ie: 'expired_at' => now()->addMonth().
After the changes of this PR it works fine. cc @nunomaduro

@yamenarahman Can you add tests on this pull requests please?

@nunomaduro Sure, can you please elaborate where to write the test? because I see 5 Reflection closures and multiple tests for PHP versions.

Take a look at the tests folder. There is hundreds of examples.

Please ask to this pull request to be re-open, once you add the tests.


[FEA]: Support mlflow 2.7+

Is this a new feature, an improvement, or a change to existing functionality?
Improvement
How would you describe the priority of this feature request
Medium
Please provide a clear description of problem this feature solves
In #1192 we noticed mlflow 2.7 caused one test to fail, the short-term fix was to simply restrict mlflow versions to those prior to 2.7.
Describe your ideal solution
Assuming this isn't a bug in mlflow itself, determine if this release actually broke the DFP pipeline, or if it just broke the test.
Fix as needed, preferably supporting 2.7 and prior versions.
Additional context
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct
[X] I have searched the open feature requests and have found no duplicates for this feature request

Issue appears to only break the tests and not the actual production code.


Error implementing asyncio.run(bot.ask(---)) with Flask API

An error occurs when two consecutive calls are made to the chatgpt instance. The first call always works correctly, but not the second or consecutive ones
"Firefox is already running but is not responding. The old firefox porcess must be closed to open a new window."

Can you provide some example code please? I'm not completely understanding your issue.

I have same error when have multiple request
shutil.copytree("/tmp/playwright", self.user_data_dir)
shutil.Error: [('/tmp/playwright/lock', '/tmp/06c62870-c894-4e7d-be3d-05756cee97c8/lock', "[Errno 2] No such file or directory: '/tmp/playwright/lock'")]

Async functionality has been deprecated, guessing this is no longer an issue.


[enhancement]: Maven Task README should mentions SpotBugs, not FindBugs

Task name
Maven
Describe your feature request here
Maven Task README should mentions SpotBugs, not FindBugs
https://github.com/microsoft/azure-pipelines-tasks/blob/master/Tasks/MavenV4/README.md

Some trigger failed when creating this issue:
https://github.com/microsoft/azure-pipelines-tasks/actions/runs/4818044079

@in-fke Thanks for reporting, we'll take a look at it

Yes, Bot, this is still relevant.


Add regression_errors

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (1fff219) to head (b6ec87d).
Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #275   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           96        97    +1
  Lines         2348      2358   +10
  Branches       214       214
=========================================
+ Hits          2348      2358   +10

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Support for azure storage

I am trying to implement Azure Storage.
I am facing difficulties in creating a AzureDataSegmentKiller particularly for creating an instance of AzureCloudBlobIterableFactory.
Do you have any idea to do that?

I solved the issue and as I cannot push my modification to this repo, I created a fork with Azure support for Druid 29.0.0 here https://github.com/fabricebaranski/rovio-ingest/tree/hdfs_azure_storage_support


Code formatting shouldn't happen during merge resolutions

Issue Type: Bug
If you're writing C++ code and have clang-format enabled as well as format on save enabled, the results can be really annoying when dealing with merge conflicts. clang-format will automatically mess with the merge markers, which makes VS Code unable to highlight them. I imagine this isn't a problem unique to C++ or clang-format.
A simple solution would be to not run code formatting when merge markers are detected.
VS Code version: Code 1.28.2 (7f3ce96ff4729c91352ae6def877e59c561f4850, 2018-10-17T00:23:12.403Z)
OS version: Windows_NT ia32 10.0.17134

System Info

Item
Value

CPUs
Intel(R) Xeon(R) CPU E5-1650 v3 @ 3.50GHz (12 x 3492)

GPU Status
2d_canvas: enabledchecker_imaging: disabled_offflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onnative_gpu_memory_buffers: disabled_softwarerasterization: enabledvideo_decode: enabledvideo_encode: enabledwebgl: enabledwebgl2: enabled

Memory (System)
15.92GB (4.18GB free)

Process Argv
.

Screen Reader
no

VM
0%

Extensions (18)

Extension
Author (truncated)
Version

path-intellisense
chr
1.4.2

githistory
don
0.4.3

tslint
eg2
1.0.40

vscode-highlight
fab
1.3.2

vscode-todo-plus
fab
4.9.4

beautify
Hoo
1.4.7

latex-workshop
Jam
5.15.1

vscode-clang
mit
0.2.3

prettify-json
moh
0.0.3

python
ms-
2018.10.0

cpptools
ms-
0.20.1

PowerShell
ms-
1.9.0

vscode-docker
Pet
0.3.1

reloaded-cpp
rel
0.1.6

llvm
RRe
0.0.3

code-spell-checker
str
1.6.10

cmake
twx
0.0.17

gitblame
wad
2.6.0

(2 theme extensions excluded)

Debatable... In the presence of syntax errors (that's what merger markers usually are) a formatter shouldn't do anything. I'd say that's an issue with that specific formatter. E.g. TypeScript understand merge markers (and treats them like comments) and then not formatter wouldn't be correct

First, you need to teach VS Code what a merge marker is, then you need honour some setting to disable formatters in that case.

VS code now know that a file is in a merging state. Is it possible to disable formatting during this stage only?

Can we reopen this issue? Its still a problem in 2024 with c++ code formatting. It regularly makes quite a bit of work when you just save a file during merge issue resolution.


Unable to resolve dependencies.

Running gb vendor restore. It results in a FATAL error message as 'unknown command "vendor"'. When I run the  gb-vendor command, it returns a error message as 'it is meant to be run as gb vendor ...'.
How do I resolve dependencies?

From gb help:
gb supports git style plugins.

A gb plugin is anything in the $PATH with the prefix gb-. In other words
gb-something, becomes gb something.

gb plugins are executed from the parent gb process with the environment
variable, GB_PROJECT_DIR set to the root of the current project.

gb plugins can be executed directly but this is rarely useful, so authors
should attempt to diagnose this by looking for the presence of the
GB_PROJECT_DIR environment key.

So it looks like gb-vendor is not in your $PATH.

It is not in the path; but, I am using full path to invoke gb-vendor. It doesn't work that way? I have never worked with Go before.

Setting the GB_PROJECT_DIR to the folder for horizon seems to be doing the trick ...

Also, you don't have to build the project if you just want to use it. There are binaries to download here: https://github.com/stellar/horizon/releases


Update readme to describe new JS host binding generation process

I just started looking into wit-bindgen yesterday and tried generating some bindings for use in JS. The instructions here say to use  wit-bindgen host js --import example.wit however doing so yields an error:
> wit-bindgen host js --import example.wit
error: unexpected argument '--import' found

  note: to pass '--import' as a value, use '-- --import'

Usage: wit-bindgen host js [OPTIONS] <COMPONENT>

For more information, try '--help'.

I dug a little further and found this issue which led me to js-component-tools.
So for those stumbling down the same path as me trying to generate some JS host bindings, take a look at js-component-tools.

Thanks for the report! I've got an updated README ready-to-go once https://github.com/bytecodealliance/wit-bindgen/pull/463 lands since the repository has shifed so much in the meantime.


hyperstart: Change the path where rootfs is bind-mounted

The agent currently bind-mounts the rootfs for container in a pod
in /tmp/hyper/shared. Since /tmp can be accessed by any user,
change this to /run.
Signed-off-by: Archana Shinde<EMAIL_ADDRESS>

cc @sboeuf

LGTM


Update PrometheusAdapter config based on "MetricRules" objects

Component(s)
No response
What is missing? Please describe.
Operator updating PrometheusAdapter config based on available MetricRules objects, similarly to how it already updates Prometheus config based on PodMonitor and ServiceMonitor objects.
Describe alternatives you've considered.
When one would want to automate installation of some component and its associated application metric rules...

Helm refuses to overwrite existing config as it's already "owned" by another chart (kube-prometheus one), so user would need to manually edit the config
User needs to restart PrometheusAdapther after config has been updated

This is rather aggravating and unfriendly.  Operator providing automation for updating adapter config would IMHO make custom/external metrics much more usable!
Environment Information.
Environment
Kubernetes Version: 1.30
Prometheus-Operator Version: see https://github.com/prometheus-community/helm-charts/tree/main/charts/kube-prometheus-stack

Moved to https://github.com/prometheus-operator/kube-prometheus since it's more an ask for kube-prometheus than prometheus-operator itself.

I second @ArthurSens that the Prometheus operator isn't the right place to support Prometheus adapter. Its API surface is already large enough + I have doubts about the future of the Prometheus adapter.

https://docs.google.com/document/d/1FE4AQ8B49fYbKhfg4Tx0cui1V0eI4o3PxoqQPUwNEiU/edit#heading=h.sxa3e6gwwwq4 (notes from 2022-12-08)

prometheus-metrics-adapter: should we consider archiving? There’s now a good replacement, KEDA, with bigger scope (https://keda.sh/docs/1.4/scalers/prometheus/). Hasn’t been well-maintained, project needs a rewrite because the codebase is hard to understand, UX is suboptimal, debugging is very complex and tedious. Maybe write a migration guide rather than cleaning up KSM.


GH-38703: [C++][FS][Azure] Implement DeleteFile()

Rationale for this change
Completed the modifications to implement the DeleteFile() method to support deletion of files on ADLS.

What changes are included in this PR?
Modified:
~cpp/src/arrow/filesystem/azurerefs.cc
~cpp/src/arrow/filesystem/azurerefs_test.cc
These modifications implement the method and provide regression testing, respectively.

Are these changes tested?
I tested the modification by creating a file via the web browser on our internal ADLS, then ran a sample program that deleted the file.  I added three regression tests to cover the use case scenarios of:

A valid delete attempt, where "valid" means that the file exists and is indeed a file
An intentional failure where a file delete is attempted, but the file does not exist
An intentional failure where a file delete is attempted, but the target is not a file

Are there any user-facing changes?
This is my first contribution to the Arrow library.  Therefore I am not certain if the addition of a relatively low-level feature such as this would propagate to external documentation.  That said, given the target audience of the library (developers), I would imagine that such a method would have documentation.

Closes: #38703

@av8or1

Could you read the auto generated comment https://github.com/apache/arrow/pull/39648#issuecomment-1895183294 and follow the description?
Could you fill our pull request template?
Could you rebase on main and resolve a conflict?

OK, #1 and #2 are completed.  Working on the rebase ...


E2E tests for all screens

For regression it would be great if we can add tests for our main screens in the app. Currently we only have tests for navigating to the first level tab.
It may be a good idea to try some user flows along with testing getting to each screen. E.g. navigate to an event, refresh content, applying filters, save an event etc.
Screens:

Home - Tested

Featured Events

Events - Tested

Category Filter
Date Filter
Filter? Filter (area, price etc)
Event Details

Parade - Tested
Saved - Tested
Support - Tested

Donate
Sponsor (Partner)

E2E tests are written here: https://github.com/redbadger/pride-london-app/blob/master/e2e/firstTest.spec.js

Also feel free to restructure in any way. Would be good to get at least one example of each type of test we'd like then we can fill out as we have time.

Related to #302

Closing this as we now have tests for navigating to all screens. We are still missing tests for filtering etc, but can add these as part of #302


Config elasticsearch installed in minikube host

Renamed patch from https://github.com/kubernetes/website/pull/18843

@davidgfolch, could you change the title of the PR to summarize the change you want to make? Those titles are really helpful to reviewers and to people looking at the history of changes.

Done

/lgtm
/approve


Use real garn.io URL in examples

Just in examples so far.

Closing until we actually have import maps.


feat(announcements): hide post announce button when not admin

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#148
#147
#146  👈
#145
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @tamrivera05 and the rest of your teammates on  Graphite


Getting the following error when trying to send messages

Hi
I am getting the following message when I try to send new messages. Please help me with this error.
Uncaught TypeError: Cannot read property 'userId' of null
at Function.I.build (SendBird.min.js:5)
at r.sendUserMessage (SendBird.min.js:4)
at HTMLTextAreaElement. (chat.js:1166)
at HTMLTextAreaElement.dispatch (jquery-1.11.3.min.js:4)
at HTMLTextAreaElement.r.handle (jquery-1.11.3.min.js:4)

It looks like you haven't called "connect() before" or not calling send after successful connection @rajdeep225


cairo on macOS draws nothing

Seems cairo on macOS has been broken for a long time, I thought it was me doing something wrong on DPF side but I just built the pugl cairo examples and still end up with an empty window.
Running macOS 12.6.1, cairo installed via homebrew. Using f6f0ecfa0aa9872a582e22f2b839d500105aafa1
Build log:
% meson build
The Meson build system
Version: 1.1.1
Source dir: /Users/falktx/Source/DISTRHO/DPF/dgl/src/pugl-upstream
Build dir: /Users/falktx/Source/DISTRHO/DPF/dgl/src/pugl-upstream/build
Build type: native build
Project name: pugl
Project version: 0.5.3
C compiler for the host machine: ccache cc (clang 14.0.0 "Apple clang version 14.0.0 (clang-14<IP_ADDRESS>)")
C linker for the host machine: cc ld64 820.1
Host machine cpu family: x86_64
Host machine cpu: x86_64
C++ compiler for the host machine: ccache c++ (clang 14.0.0 "Apple clang version 14.0.0 (clang-14<IP_ADDRESS>)")
C++ linker for the host machine: c++ ld64 820.1
Objective-C compiler for the host machine: ccache cc (clang 14.0.0)
Objective-C linker for the host machine: cc ld64 820.1
Objective-C++ compiler for the host machine: ccache c++ (clang 14.0.0)
Objective-C++ linker for the host machine: c++ ld64 820.1
Library dl found: YES
Run-time dependency appleframeworks found: YES (foundation, corevideo)
Library m found: YES
Found pkg-config: /usr/local/bin/pkg-config (0.29.2)
Run-time dependency gl found: YES
Run-time dependency cairo found: YES 1.16.0
Compiler for C supports arguments -Wno-documentation: YES
Compiler for C supports arguments -Wno-documentation-unknown-command: YES
Compiler for C supports arguments -Wno-reserved-identifier: YES
Run-time dependency vulkan found: NO (tried pkgconfig and system)
Compiler for Objective-C++ supports arguments -Wno-c++98-compat: YES
Compiler for Objective-C++ supports arguments -Wno-c++98-compat-pedantic: YES
Compiler for Objective-C++ supports arguments -Wno-deprecated-declarations: YES
Compiler for Objective-C++ supports arguments -Wno-direct-ivar-access: YES
Configuring Info.plist using configuration
Configuring Info.plist using configuration
Configuring Info.plist using configuration
Configuring Info.plist using configuration
Configuring Info.plist using configuration
Configuring Info.plist using configuration
Configuring Info.plist using configuration
Configuring Info.plist using configuration
Program doxygen found: NO
Program sphinxygen found: NO
Program sphinx-build found: NO
Downloading sphinxygen source from https://download.drobilla.net/sphinxygen-1.0.0.tar.gz
Download size: 13894
Downloading: ..........

Executing subproject sphinxygen

sphinxygen| Project name: sphinxygen
sphinxygen| Project version: 0.0.1
sphinxygen| Program python3 (argparse, textwrap, xml.etree.ElementTree) found: YES (/usr/local/bin/python3) modules: argparse, textwrap, xml.etree.ElementTree
sphinxygen| Program sphinxygen found: YES (/Users/falktx/Source/DISTRHO/DPF/dgl/src/pugl-upstream/subprojects/sphinxygen-1.0.0/src/sphinxygen/sphinxygen.py)
sphinxygen| Build targets in project: 31
sphinxygen| Subproject sphinxygen finished.

Program sphinxygen found: YES (overridden)
Build targets in project: 31
NOTICE: Future-deprecated features used:
 * 0.64.0: {'copy arg in configure_file'}

pugl 0.5.3

  Configuration
    Platform      : mac

  Backends
    Cairo         : YES
    OpenGL        : YES
    Stub          : YES
    Vulkan        : NO

  Components
    Tests         : YES
    Examples      : YES
    Documentation : NO

  Directories
    Install prefix: /usr/local
    Headers       : /usr/local/include
    Libraries     : /usr/local/lib
    Executables   : /usr/local/bin

  Subprojects
    sphinxygen    : YES

Found ninja-1.11.1 at /usr/local/bin/ninja

output of otool:
% otool -L ./build/examples/pugl_cairo_demo.app/MacOS/pugl_cairo_demo
./build/examples/pugl_cairo_demo.app/MacOS/pugl_cairo_demo:
	@rpath/libpugl_mac-0.0.dylib (compatibility version 0.0.0, current version 0.0.0)
	@rpath/libpugl_mac_cairo-0.0.dylib (compatibility version 0.0.0, current version 0.0.0)
	/usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current version 1319.0.0)
	/usr/local/opt/cairo/lib/libcairo.2.dylib (compatibility version 11603.0.0, current version 11603.0.0)

When running pugl_cairo_demo this is what I see on screen:

I think I found the culprit, the line https://github.com/lv2/pugl/blob/f6f0ecfa0aa9872a582e22f2b839d500105aafa1/src/mac_cairo.m#L99
According to the example in https://cairographics.org/manual/cairo-Quartz-Surfaces.html we should use
CGContextTranslateCTM (cgContext, 0.0, height);

while current pugl uses -heightas the 3rd argument there.
is there a reason for this? maybe a leftover thing from OpenGL setup where Y/height coordinates are inverted?
with that change I get stuff drawn on the window:

the pugl example is a bit simplistic (understandably) so I went to try the fix with something more involved.
confirmed to work correctly with https://github.com/DISTRHO/elements-template-plugin

Hm.  The cairo demo on current main works fine for me on MacOS 13.6.  I was previously working on MacOS 11 and it worked there, too.  There's been some issues specifically around embedding somewhat recently, but programs not working is a new one as far as I know.
That offset code is 3 years old and quite a lot of people have used it successfully.  IIRC the negative offsets are to deal with the inverted Y axis.  Your change breaks it for me.
Where is your cairo from?

I tried with both homebrew and self-built cairo as part of https://github.com/DISTRHO/PawPaw
I never had pugl and cairo working on any of my systems, though I mostly test on a M1 machine so maybe that is the difference? Actually seems weird to me that it works as-is for you, rather than the contrary.

This is on an M2 with homebrew's cairo.  Machine is fresh out of the box with nothing screwed with aside from installing XCode and homebrew.  I was previously using a self-built cairo on Intel.

macbook with retina display? just in case high-dpi has something to do with it... the tests I did above were with an old intel macbook, so it has high-dpi stuff in place.

Both Macbook Pros using the built-in "Retina" display.

Repro'd in main

mfisher@MacMini-M1 pugl % meson setup build
The Meson build system
Version: 0.63.0
Source dir: /Users/mfisher/workspace/lad/pugl
Build dir: /Users/mfisher/workspace/lad/pugl/build
Build type: native build
Project name: pugl
Project version: 0.5.3
C compiler for the host machine: ccache cc (clang 13.0.0 "Apple clang version 13.0.0 (clang-13<IP_ADDRESS>)")
C linker for the host machine: cc ld64 711
Host machine cpu family: aarch64
Host machine cpu: arm64
C++ compiler for the host machine: ccache c++ (clang 13.0.0 "Apple clang version 13.0.0 (clang-13<IP_ADDRESS>)")
C++ linker for the host machine: c++ ld64 711
Objective-C compiler for the host machine: ccache cc (clang 13.0.0)
Objective-C linker for the host machine: cc ld64 711
Objective-C++ compiler for the host machine: ccache c++ (clang 13.0.0)
Objective-C++ linker for the host machine: c++ ld64 711
Library dl found: YES
Run-time dependency appleframeworks found: YES (foundation, corevideo)
Library m found: YES
Found pkg-config: /opt/homebrew/bin/pkg-config (0.29.2)
Run-time dependency gl found: YES
Run-time dependency cairo found: YES 1.16.0
Compiler for C supports arguments -Wno-documentation: YES
Compiler for C supports arguments -Wno-documentation-unknown-command: YES
Compiler for C supports arguments -Wno-reserved-identifier: NO
Run-time dependency vulkan found: NO (tried pkgconfig and system)
Compiler for Objective-C++ supports arguments -Wno-c++98-compat: YES
Compiler for Objective-C++ supports arguments -Wno-c++98-compat-pedantic: YES
Compiler for Objective-C++ supports arguments -Wno-deprecated-declarations: YES
Compiler for Objective-C++ supports arguments -Wno-direct-ivar-access: YES
Configuring Info.plist using configuration
Configuring Info.plist using configuration
Configuring Info.plist using configuration
Configuring Info.plist using configuration
Configuring Info.plist using configuration
Configuring Info.plist using configuration
Configuring Info.plist using configuration
Configuring Info.plist using configuration
Program doxygen found: YES (/opt/homebrew/bin/doxygen)
Program sphinxygen found: NO
Program sphinx-build found: YES (/Users/mfisher/Library/Python/3.8/bin/sphinx-build)
Downloading sphinxygen source from https://download.drobilla.net/sphinxygen-1.0.0.tar.gz
Downloading: 100%|████████████████████████████████████| 13894/13894 [00:00<00:00, 4502136.88bytes/s]

Executing subproject sphinxygen

sphinxygen| Project name: sphinxygen
sphinxygen| Project version: 0.0.1
sphinxygen| Program python3 (argparse, textwrap, xml.etree.ElementTree) found: YES (/opt/homebrew/bin/python3) modules: argparse, textwrap, xml.etree.ElementTree
sphinxygen| Program sphinxygen found: YES (/Users/mfisher/workspace/lad/pugl/subprojects/sphinxygen-1.0.0/src/sphinxygen/sphinxygen.py)
sphinxygen| Build targets in project: 31
sphinxygen| Subproject sphinxygen finished.

Program sphinxygen found: YES (overridden)
Configuring conf.py using configuration
Configuring Doxyfile using configuration
Build targets in project: 35

pugl 0.5.3

  Configuration
    Platform      : mac

  Backends
    Cairo         : YES
    OpenGL        : YES
    Stub          : YES
    Vulkan        : NO

  Components
    Tests         : YES
    Examples      : YES
    Documentation : YES

  Directories
    Install prefix: /usr/local
    Headers       : /usr/local/include
    Libraries     : /usr/local/lib
    Executables   : /usr/local/bin

  Subprojects
    sphinxygen    : YES

Found ninja-1.10.2 at /opt/homebrew/bin/ninja
mfisher@MacMini-M1 pugl % meson compile -C build
ninja: Entering directory `/Users/mfisher/workspace/lad/pugl/build'
[73/74] Generating doc/c/singlehtml with a custom command
/Users/mfisher/Library/Python/3.8/lib/python/site-packages/requests/__init__.py:102: RequestsDependencyWarning: urllib3 (1.26.6) or chardet (5.0.0)/charset_normalizer (2.0.1) doesn't match a supported version!
  warnings.warn("urllib3 ({}) or chardet ({})/charset_normalizer ({}) doesn't match a supported "
/Users/mfisher/workspace/lad/pugl/build/doc/c/deployment.rst:36: WARNING: Pygments lexer name 'meson' is not known
[74/74] Generating doc/c/html with a custom command
/Users/mfisher/Library/Python/3.8/lib/python/site-packages/requests/__init__.py:102: RequestsDependencyWarning: urllib3 (1.26.6) or chardet (5.0.0)/charset_normalizer (2.0.1) doesn't match a supported version!
  warnings.warn("urllib3 ({}) or chardet ({})/charset_normalizer ({}) doesn't match a supported "
/Users/mfisher/workspace/lad/pugl/build/doc/c/deployment.rst:36: WARNING: Pygments lexer name 'meson' is not known
mfisher@MacMini-M1 pugl % ./build/examples/pugl_cairo_demo.app/MacOS/pugl_cairo_demo

Monitor I have is 4k: https://www.viewsonic.com/eu/products/sheet/VX2475Smhl-4K

I noticed in the same docs: say "If the CGContext is in the Quartz coordinate space (with the origin at the bottom left), then it should be flipped before this function is called"  And it then recommends doing the flip with two function calls, not simply flipping to -height.
CGContextTranslateCTM (cgContext, 0.0, height);   // no -height
CGContextScaleCTM (cgContext, 1.0, -1.0);             // the real flip as recommended?

MacOS 13.6. I was previously working on MacOS 11

See comment in #106 - @falkTX and I both can repro v12 macs.  Not sure what my laptop version is but I'll check that one in a bit.

Being like this for 12 only would be... quite something, although I wouldn't put it past Apple these days 🤷
I dunno.  I can try on an external monitor when I get home, which is maybe a relevant variable, but I'm away right now.  Try a different fix I guess, one will stick eventually.

Well... my macbook is version 11... but home brew wants me to update Xcode and is failing.  Unfortunately this machine is a build agent for a handful of projects that I can't risk breaking.
And yeah, to be a 12 specific problem is unlikely, I just noticed we're on 12 and you're not.
My new theory is that somehow the sizePt.height is negative for some reason on @drobilla 's machines.
// ....
const CGSize sizePt = CGContextConvertSizeToUserSpace(context, sizePx);
if (sizePt.height < 0)
  sizePt.height = -sizePt.height

// ....

^^^ I'd put money that fixes it across the board, but I can't test without risk of breaking the build bots.

Ok, might have a winner:  I pulled @falkTX 's branch and added a few things:
https://github.com/lv2/pugl/compare/main...mfisher31:pugl:fix-cairo-quartz-translate
First, I fixed the logical scaling of the demo itself by using puglGetScaleFactor  (couldn't resist) and second, apply the inverse scale factor to the CG translate call.  Visually it doesn't really change anything for, aside from the sizing.  Hopefully this works for @drobilla  too.

My new theory is that somehow the sizePt.height is negative for some reason on @drobilla 's machines

Yep, it is.

Could just... ram an fabs in there I suppose, but why is this inverting on some machines and not others?

also it does not happen with opengl, I always had that working correctly on macOS, issue is only with cairo.
I can try with vulkan, if there is a demo, but pugl does not have that enabled by default on macOS. do we need to install something extra?

This code is in the Cairo backend, so it won't affect anything else.  Vulkan unfortunately stopped working on MacOS.  I need to update the demo to "register" with the new compatibility extension required to make things work on non-conformant implementations (like MoltenVK on Metal).
I'd like to understand why mirroring is happening sometimes here, but ultimately if
CGContextTranslateCTM(context, 0.0, fabs(sizePt.height));
CGContextScaleCTM(context, scale, -scale);

works for both of you as well, well, that's a fix.

Try with -r, and what scale factor is reported on these machines?

Well I can't figure out why this is acting weird, so maybe we can just avoid it entirely... try e33b2f6

No ability to reproduce and no feedback for 6 months, so I'm assuming the above change fixed the issue.

FYI I got no more reports of breakages either.


how to measure vector load performance

Hi,
I find your benchmark to be very valuable. Do you have any good ideas or suggestions for testing the performance (throughput or latency) of various vector load instructions? I would like to explore the vector load performance on the K1 and K230.
Thanks

Hi, I played around with adding the vector load/stores to the single instructions measurements, but I came to the conclusion that it would be more useful in a separate benchmark.
https://github.com/camel-cdr/rvv-bench/issues/12 has some measurements that show how different stride values perform. Ideally we'd measure  something like that, with data from the different caches and from memory. I'm not sure how to properly do those measurements, though. This should probably also take into account different prefetch strategies.
For now you can look at the LUT4, and ascii to utf16/utf32, where indexed, strided and segmented loads are used in some of the implementations.
If you have suggestions please share them, I was planing to look at some memory measurements done on other ISAs, but I haven't gotten around to that yet.


Loaded JPG image, returns ndarray with 4 channels?

I expected the JPG image to have three channels. Renamed file to have JPEG extension, but same result. Any ideas? Cheers.
>         var img = "";
undefined
>         getPixels("test/images/file000555007525.jpeg", function(err, pixels) {
...             if(err) {
.....                 console.log("Bad image path");
.....                 return
.....             }
...             console.log("got pixels", pixels.shape.slice())
...             img = pixels;
...         });
undefined
> got pixels [ 2240, 1680, 4 ]
img
View3dbuffer {
  data: <Buffer 6c 88 c6 ff 6c 88 c6 ff 6a 88 c6 ff 6d 89 c7 ff 6d 8b c9 ff 70 8b cc ff 70 8e ce ff 72 90 d0 ff 6e 8e cd ff 70 90 cf ff 72 92 d1 ff 6e 8e cd ff 68 88 ... >,
  shape: [ 2240, 1680, 4 ],
  stride: [ 4, 8960, 1 ],
  offset: 0 }
>

Currently all the channel values are hard-set to 4, and not actually read from the images, though it should be possible to compute most if not all of them using our existing dependencies.
Is this blocking your project? I would assume in your case it's safe to assume any jpg will have three channels, though this may not be the case if the image is CMYK-encoded, or includes the rare Jpeg alpha transparency channel.

I was also very confused by this behaviour. I expected 3 channels, but got 4.


Honor CPU counts from CFS.

Close https://github.com/dmlc/xgboost/issues/7653 .
Need some testing.

I verified that the PR can correctly detect the docker argument --cpus.

@hcho3 Could you please take a look?  Your expertise regarding container env would be really helpful.

@hcho3 Could you please take another look?


Chart.defaults.global y AXIS/Tooltip Formating Example

Can I please get an example of using the global options to setup a simple comma formatted Y and tooltip label? I am not able to get anything to work right.

@cgountanis what are you looking to achieve?

I was hoping that I could get away with using a global setting to set the y
axis and the tool tips with in the chart. I have a web service that
generates the Json file it's just kind of a pain to alter it after the
fact. Mostly numbers with commas, formatting. Honestly I think it should be
built in maybe within the dataset or the access different types of settings
is it a dollar format do you want to see commas things like that I think
people would use the heck out of it.
On Sep 12, 2016 6:46 PM, "Evert Timberg"<EMAIL_ADDRESS>wrote:

@cgountanis https://github.com/cgountanis what are you looking to
achieve?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/chartjs/Chart.js/issues/3294#issuecomment-246530389,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AONaaadKlsD-Lrmghk2lu_j_EzRVAtRLks5qpeRLgaJpZM4J6x5n
.

You can definitely use global options to control that.
For instance, here's how you would update so that all linear scales (the default Y axis) will format using dollar signs and nice numbers
Chart.scaleService.updateScaleDefaults('linear', {
  ticks: {
    callback: function(tick) {
      return '$' + tick.toLocaleString();
    }
  }
});

Here's how you could also do the same for a tooltip
Chart.defaults.global.tooltips.callbacks.label = function(tooltipItem, data) {
  var dataset = data.datasets[tooltipItem.datasetIndex];
  var datasetLabel = dataset.label || '';
  return datasetLabel + ": $" + dataset.data[tooltipItem.index].toLocaleString();
});

I've hesitated to push to include these in the core because there are so many different options and trying to support each and every one would dramatically increase the size of the already large library. It may make sense to encourage someone to create a library of formatters that essentially automates the creation of these functions to speed up development.

I am leaving the stack post here including working JSFiddle which might help others someday.
http://stackoverflow.com/questions/39453720/chartjs-number-formated-labels

Thanks @cgountanis


Object val

Introduce common enum for all objects stored in object storage

Rebased

My earlier comments on this: https://github.com/zenithdb/zenith/pull/268#issuecomment-866660476

I pushed refactored version of this (PR #287), so closing.


TilingSprite is broken in latest dev commit

Title says it pretty much, check http://pixijs.github.io/examples/?v=dev#/basics/tiling-sprite.js with latest dev

OK, my bad, fixing

Fix is here: https://github.com/pixijs/pixi.js/pull/4060


Virtual Machine

This pull request adds structures and methods for interactions related to virtual machines.
It is split into separate commits and only adds the base structure as well as NIC creation. Other parts, such as adding disks, etc. are to follow.

code looks good to me, just the generation question and I'll approve


fix clippy warnings

Yes, there are. I didnt fix edition related stuffs because I had no idea which edition is intended for libc

That is a good question that I have been meaning to bring up. I think we will target e2021 on main, it just hasn't been discussed anywhere yet. So good to leave those lints as-is until we have a policy.

I was going to backport this but almost all of this doesn't work on our oldest version, so I guess there isn't much need.


Could you add function set_static_ip in BOS.

I see that you add function set_static_ip in antminer and bmminer backend. Could you add this function in BOS backend ?

Should be there in 0.36.3.

I tested func for BOS and it does not work for me.
I wrote simple code for test.
    miner = await pyasic.get_miner(input_ips)
    await miner.set_static_ip(miner.ip, dns, gateway, subnet_mask)
    await miner.reboot()
    print("PASS")```

```asyncio.run(set_static("<IP_ADDRESS>", "<IP_ADDRESS>", "<IP_ADDRESS>"))```
And after reboot i check BOS GUI.
![image](https://github.com/UpstreamData/pyasic/assets/37435132/b85d4a63-191a-4659-9255-cbd83cec886d)

i checked your func and data has value
"cat: can't open '/etc/config/network': No such file or directory\n"

Are you running a BBB X19?  Not sure if they still have LuCI in there or what.  Ill have to do some more testing to be able to do this it seems.


improve error message in  beta-group-significance

If a metadata column has 1 group with 1 sample, the error displayed is:
Plugin error from diversity:

  All values in the grouping vector are unique. This method cannot
  operate on a grouping vector with only unique values (e.g., there are
  no 'within' distances because each group of objects contains only a
  single object).

Debug info has been saved to /var/folders/17/c40mmrx56w918s7lp6ds2jvw0000gq/T/qiime2-q2cli-err-prbsm9i6.log

and the log:
Traceback (most recent call last):
  File "/Users/antoniog/miniconda3/envs/qiime2-2017.9/lib/python3.5/site-packages/q2cli/commands.py", line 218, in __call__
    results = action(**arguments)
  File "<decorator-gen-283>", line 2, in beta_group_significance
  File "/Users/antoniog/miniconda3/envs/qiime2-2017.9/lib/python3.5/site-packages/qiime2/sdk/action.py", line 201, in callable_wrapper
    output_types, provenance)
  File "/Users/antoniog/miniconda3/envs/qiime2-2017.9/lib/python3.5/site-packages/qiime2/sdk/action.py", line 393, in _callable_executor_
    ret_val = callable(output_dir=temp_dir, **view_args)
  File "/Users/antoniog/miniconda3/envs/qiime2-2017.9/lib/python3.5/site-packages/q2_diversity/_beta/_visualizer.py", line 193, in beta_group_significance
    permutations=permutations)
  File "/Users/antoniog/miniconda3/envs/qiime2-2017.9/lib/python3.5/site-packages/q2_diversity/_beta/_visualizer.py", line 110, in _get_pairwise_group_significance_stats
    permutations=permutations)
  File "/Users/antoniog/miniconda3/envs/qiime2-2017.9/lib/python3.5/site-packages/skbio/stats/distance/_permanova.py", line 93, in permanova
    distance_matrix, grouping, column)
  File "/Users/antoniog/miniconda3/envs/qiime2-2017.9/lib/python3.5/site-packages/skbio/stats/distance/_base.py", line 1024, in _preprocess_input
    "All values in the grouping vector are unique. This method cannot "
ValueError: All values in the grouping vector are unique. This method cannot operate on a grouping vector with only unique values (e.g., there are no 'within' distances because each group of objects contains only a single object).

Even with all this info, it's not clear that the problem is that there is 1 group with 1 sample. Additionally, it will be good to know which are the problematic groups.

The error message is saying that there are no groups within the metadata column, every value is unique. Listing the problematic groups won't help users, because every "group" having n=1 is the problem. Do you have suggestions for improving the error message?

An example of the problem I had is: in category "phenotype" we have 3 groups: "treatment" (n = 10), "control" (n =12) and "blank" (n=1). So my suggestion is that the output says that group blank has only has one sample. Remember that in the command you actually pass "phenotype" so it's fine not to add it. BTW the solution to move forward, as you can imagine, was to filter the sample "blank".

This error message shouldn't have been triggered in that case -- it's only intended to be triggered when all groups are n=1. So in your example, the phenotype column would need to have treatment n=1, control n=1, and blank n=1 to trigger the error message.
Can you double-check the groups in your metadata column? And also consider that there may be samples in your metadata that aren't in your distance matrix, so those extra samples will be ignored.

@antgonza sent me some data to reproduce the issue. The error message is accurate, and it's occurring when pairwise tests are run (--p-pairwise). There were at least two "groups" of samples in @antgonza's metadata column that each contained only a single sample, which makes the error trigger as expected.
I can see this situation coming up frequently when running pairwise tests, and the error message isn't all that clear from a user's perspective. It may be useful to catch these errors when running pairwise tests and report that the tests couldn't be run for certain group pairs in the resulting visualization. That way users can still run pairwise tests without having to filter out those groups manually. @antgonza @gregcaporaso thoughts? If you guys like this plan, I'll create a new issue.

Thanks for clarifying the exact situation when this happens. I thought it was always in beta-group-significance but it only happens with --p-pairwise. I think your suggestion will work and the error could even have an example of the filtering --p-where parameter.
I'm gonna rename this issue so it's more accurate.

I like that plan @jairideout.

Great, thanks guys! Closing in favor of #155.


Make backtrace dependency optional

I was going through my dependencies, trying to slim down the dependency tree. I saw that backtrace depends on cc, which might be expensive. So I tried to put backtrace inside a feature that can be turned off.
The results aren't all that impressive though

I got to shave off around 5 crates for a full recompile. Might translate into 1 second of CI time.
Maybe a 10 ms reduction in incremental compile times, if anything at all.

Fyi I've been working on removing this crate altogether in favour of stabilized/builtin support since Rust 1.65. It was tricky back then because of ownership and clones, but might be more manageable since recent changes:
https://github.com/Traverse-Research/gpu-allocator/compare/std-backtrace

@MarijnS95 Oh that's so cool! Any way I could help?
There doesn't seem to be a test nor example for the log_stack_traces or store_stack_traces, is that right?

@MarijnS95 Okay, I took a look at it. From what I can tell, there are two options.

Rc<Option<Backtrace>
Lifetimes, like turning the DedicatedBlockAllocator into a DedicatedBlockAllocator<'a>

Do you have any preferences?
Also, I wish there were a visualizer example. But that's a future request, I suppose.

@MarijnS95 Oh that's so cool! Any way I could help?

No, I'll probably revise and submit it later :wink:

@MarijnS95 Sounds good. I did make a PR for it, but I'll leave it up to you to figure out the optimal solution :)

@stefnotch as promised, a PR from that branch is now open at https://github.com/Traverse-Research/gpu-allocator/pull/186. In particular I've addressed the TODOs left in that branch such as using proper Display instead of Debug prints, and making practical use of Backtrace::disabled() :tada:

Also, I wish there were a visualizer example. But that's a future request, I suppose.

On this note, these were unfortunately all removed: https://github.com/Traverse-Research/gpu-allocator/pull/176
In part because we identified a problem way back in the beginning where Vulkan and Dx12 visualizers were basically a massive (verbose, hard to maintain) copy-paste of each-other, rather than going through a cross-compatible interim data-structure saving us all that overhead. Contributions in this area are welcome I think, but let's hear from @tosti007 whether any of this is already in-progress on a branch somewhere.


e2e tests no longer started by master job

related to https://github.com/fabric8io/fabric8-test/issues/581

@kbsingh @jmelis could you please review?


Do not filter features unless apply_filter is called

Filtering features can take some time, so it should be avoided when it isn't needed.
Now the dataframes are filtered only when apply_filter is called.

Codecov Report
Attention: Patch coverage is 94.11765% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 92.10%. Comparing base (2406a1c) to head (2c2fea3).

Files
Patch %
Lines

src/blueetl/features.py
94.11%
1 Missing :warning:

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #30   +/-   ##
=======================================
  Coverage   92.10%   92.10%
=======================================
  Files          45       45
  Lines        2508     2508
  Branches      495      495
=======================================
  Hits         2310     2310
  Misses        126      126
  Partials       72       72

Flag
Coverage Δ

pytest
92.10% <94.11%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


[Question] where do i run "make build" command?

it was successful with script "docker run groken/redis-cluster"
but where do i run "make run" command?
i am a newbie for docker.
but i need to use docker version to test redis-py-cluster.
can you give more detail guide to run docker?

sorry
I confused because step 1 (clone repo) is not mentioned.
I started from docker hub repo.
so i did

docker pull grokzen/redis-cluster
where do i need to run command make build?
maybe this will work docker run grokzen/redis-cluster

You should really go out and read up on some of the differences between building your own image from source, and downloading and running a image from dockerhub.
You do not mix the 2 methods becuase that is what you have described in your last post. When you run from dockerhub and using the prebuilt images that i have built and uploaded you run steps 1 & 3 as you described. When you pull down the container from dockerhub there is no make ... commands that you have to run to get everything started, you have to run the commands by your self in this mode.
If you however want to build your own image from source then you follow this description https://github.com/Grokzen/docker-redis-cluster#usage and use the make ...commands


Add formula for FLANN

Please add FLANN: https://github.com/Homebrew/homebrew-science/blob/master/flann.rb
And its dependency cmake: https://github.com/Homebrew/homebrew/blob/master/Library/Formula/cmake.rb

since homebrew-science already has it bottled, and that bottle is listed as cellar: any, you should be able to depend on it without needing to do anything special via homebrew/science/flann

OK - perhaps I got the instructions wrong.
Can you explain why brew (on my Yosemite system) pours from the bottle, but in Julia (0.3.10) Homebrew.add("flann") installs from source?
$ brew install flann
==> Installing flann from homebrew/homebrew-science
==> Downloading https://homebrew.bintray.com/bottles-science/flann-1.8.4_1.yosemite.bottle.tar.gz
...

julia> Pkg.update()
julia> Homebrew.update()
julia> Homebrew.add("flann")
==> Installing flann from staticfloat/homebrew-juliadeps
==> Downloading http://people.cs.ubc.ca/~mariusm/uploads/FLANN/flann-1.8.4-src.z
...

I would like to update FLANN.jl to use Homebrew, but I am not sure how to test that it uses the bottle as intended.

What happens if you do Homebrew.add("homebrew/science/flann") ?

Ambigious reference to hdf5:
julia> Homebrew.add("homebrew/science/flann")
==> Tapping homebrew/science
Cloning into '/Users/jsa/.julia/v0.3/Homebrew/deps/usr/Library/Taps/homebrew/homebrew-science'...
remote: Counting objects: 541, done.
remote: Compressing objects: 100% (538/538), done.
remote: Total 541 (delta 3), reused 158 (delta 2), pack-reused 0
Receiving objects: 100% (541/541), 427.05 KiB | 0 bytes/s, done.
Resolving deltas: 100% (3/3), done.
Checking connectivity... done.
Tapped 534 formulae (561 files, 2,8M)
==> Installing flann from homebrew/homebrew-science
Error: Formulae found in multiple taps:
 * homebrew/science/hdf5
 * staticfloat/juliadeps/hdf5

Please use the fully-qualified name e.g. homebrew/science/hdf5 to refer the formula.
ERROR: failed process: Process(`/Users/jsa/.julia/v0.3/Homebrew/deps/usr/bin/brew install --force-bottle homebrew/science/flann`, ProcessExited(1)) [1]

hm, that's annoying. we probably can't use the homebrew-science version of hdf5 directly since it isn't cellar: any (relocatable), but maybe the flann formula could be copied with only minor changes to https://github.com/staticfloat/homebrew-juliadeps to depend on the relocatable hdf5 from that tap.

Or update homebrew/science/hdf5 to be relocatable? Would that be hard?

@stemann can you try installing staticfloat/juliadeps/flann?

It works (also just flann).


Loot tracker - Filter by session

Would be nice to have an option to filter the loot tracker to show only the current session, or perhaps even options for previous sessions as well as showing everything together.
Sorry if something like this was already suggested, tried searching but didn't see it.

if you disable the Synchronize panel contents option in the Loot Tracker settings, old data wont be loaded on client start.


Checkbox customization void

Is there a way pass in a custom checkbox component when using mode: "checkbox"
<BootstrapTable
     selectRow={{mode:"checkbox"}}
     checkboxComponent={MyCheckbox}
     .....

If not, what about adding some props for the checkbox, for example checkboxClasses="some-class"
In the meantime, what is the recommended in which to apply styling to the checkboxes?
Thank you

After reading (many, many) of other open issues and a search for a similar experience I found that we can use something like:
selectRow = {
    mode: 'checkbox',
    customComponent: MyComponent
}

Which is exactly what I wanted!
Keep up the good work :)


[WFLY-17651] Add a new "Getting Started" archetype.

https://issues.redhat.com/browse/WFLY-17651
Starting off as a draft as a couple of additional points still to consider:

Check CDI works
Look at the test profiles
Consider do we need Helm charts?

Consider do we need Helm charts?

We would need a Helm Chart to deploy the application on Kubernetes (instead of a plain container image deployment).
However this implies that the user pushes the container image that is created by the wildfly:image plugin to a public container registry (ghcr.io or quay.io)
The Helm chart could be as simple as:
image:
  name: <name of the image in the container registry>
build:
  enabled: false
deploy:
  route:
    enabled: false

The underlying question is how far do you want to push the getting started experience?
If its's up to local development, the image is fine.
If it's up to kubernetes deployment, then we need the configuration/templating to push the image to a container registry and a Helm chart to deploy on a k8s cluster

@jmesnil I think after this the next discussion is documentation of user stories, as the Helm chart is so simple I don't think it fits in the archetype, instead it feels like it is a next user story re using a Helm Chart to deploy the project.

Thanks @jmesnil I have merged that first PR

@darranl thanks! If you look at the GitHub action, you will now have the execution of the mvn verify for a generated project (eg https://github.com/wildfly/wildfly-archetypes/actions/runs/5808924000/job/15746706526#step:4:4206).

@jmesnil second PR merged ;-) thank you

@darranl you need to bump the wildfly-maven-plugin to 4.2.0.Final to be able to provision WildFly 29.

@jmesnil sorry I had made that change locally, hadn't pushed the last commit.

@darranl starting with #40, all dependencies are configured in the parent pom.xml and propagated to the generated archetypes. This requires an update in your PR to move the generated pom.xml in a separate directory and some escaping of its variables. This should be very similar to what was done for the jakartaee-webapp archetype (starting from https://github.com/wildfly/wildfly-archetypes/pull/40/files#diff-03e5203acbea22fcd42193af53307eb5b7ac9ffd50ede79de2bf4ad7b4e4cd64)

@darranl starting with #40, all dependencies are configured in the parent pom.xml and propagated to the generated archetypes

done in https://github.com/jmesnil/wildfly-archetypes/commit/d792dd3579eaa25526ac98bfb390f7fe5be14bfa

FYI I am going to close this PR as I opened https://github.com/wildfly/wildfly-archetypes/pull/47 as a continuation after merging in main and syncing from Jeff's topic branch.


update to latest sling mock versions

It looks like some of the tests are failing with the same root cause:
java.lang.RuntimeException: Unable to invoke method 'bindAdapterFactory' for class org.apache.sling.testing.mock.sling.MockAdapterManagerImpl Caused by: java.lang.NoSuchMethodError: org.apache.sling.adapter.internal.AdapterFactoryDescriptor.<init>

@badvision do you have a specific example? Does that happen on the CLI or in your IDE?

No I was just reading the log from the failed build via Travis CI -- I haven't tried to build with this change yet.

weird. I can't reproduce locally. I'll try moving the dependencies around

Coverage remained the same at 23.791% when pulling 436d96a188f7f9937190f788580b1473973c4ecb on justinedelson:feature/update-sling-mock-versions into d4e4dfaf2af1bf73cdf66eb6b2f920e90ee2ed66 on Adobe-Consulting-Services:master.

Coverage remained the same at 23.791% when pulling ffabfd1592cc3c25b1ea3049212c1ca4244fce2e on justinedelson:feature/update-sling-mock-versions into d4e4dfaf2af1bf73cdf66eb6b2f920e90ee2ed66 on Adobe-Consulting-Services:master.

looks like it is working now after removing the old testing dependency