sql-ddl-parser: parser ignores valid string tokens that are also keywords

The following is valid in sqlite.
CREATE TABLE version (    schema TEXT PRIMARY KEY,    version INT NOT NULL);

The parser doesn’t recognise the column name schema, though.

Example
The parser returns the following.
[
  {
    "type": "create.table",
    "name": "version",
    "comment": "",
    "columns": [
      {
        "name": "",            // Missing `schema`
        "dataType": "TEXT",
        "default": "",
        "comment": "",
        "primaryKey": true,
        "autoIncrement": false,
        "unique": false,
        "nullable": true
      },
      {
        "name": "version",
        "dataType": "INT",
        "default": "",
        "comment": "",
        "primaryKey": false,
        "autoIncrement": false,
        "unique": false,
        "nullable": false
      }
    ],
    "indexes": [],
    "foreignKeys": []
  }
]

The tokenizer returns the following.
[ {"type":"keyword"    , "value":"CREATE" }
, {"type":"keyword"    , "value":"TABLE"  }
, {"type":"string"     , "value":"version"}
, {"type":"leftParen"  , "value":"("      }
, {"type":"keyword"    , "value":"schema" } // Not a keyword!
, {"type":"keyword"    , "value":"TEXT"   }
, {"type":"keyword"    , "value":"PRIMARY"}
, {"type":"keyword"    , "value":"KEY"    }
, {"type":"comma"      , "value":","      }
, {"type":"string"     , "value":"version"}
, {"type":"keyword"    , "value":"INT"    }
, {"type":"keyword"    , "value":"NOT"    }
, {"type":"keyword"    , "value":"NULL"   }
, {"type":"rightParen" , "value":")"      }
]

I wouldn’t use a keyword as a column name, but it seems the zotero developers haven’t run into any issues with it…

I don’t know what’s best here… this is valid sql, and so if sql-ddl-parser is going to handle valid sql then it should handle this. The current token handling ignores the keyword context, though, making this tricky.
https://github.com/vuerd/vuerd/blob/ef85789d778219d4b5e8fe412fbab7ee3599783f/packages/sql-ddl-parser/src/SQLParser.ts#L173-L179
It would be great if sql-ddl-parser were to handle this, but I appreciate adding context would be a whopping change, that might not be worthwhile.
The context is available in the parser. A hacky alternative might be to allow keywords here.
https://github.com/vuerd/vuerd/blob/ef85789d778219d4b5e8fe412fbab7ee3599783f/packages/sql-ddl-parser/src/sqlParser/create.table.ts#L121-L125
Of course, not all keywords are allowed as unquoted column names; commit, for example, causes an error.
A more prinicpled approach might be to identify and then allow valid keywords here.

What do you think?

I think it's working after rewriting the parser
erd-editor v3.0.1
erd-editor-vscode v1.0.1


[Bug Report] IE11, clicking on the selection box of the select component, prompts the text to disappear and displays the hint of the cursor to be entered (so the non editable input box has the compatibility problem)

Element UI version
2.3.9
OS/Browsers version
windows
Vue version
2.5.17-beta.0
Reproduction Link
https://jsfiddle.net/L3ufgbmr/
Steps to reproduce
1、点击选择框
What is Expected?
选择框placeholder提示文字不消失，不出现待输入的光标，不对用户造成可输入的误解
What is actually happening?
选择框提示文字消失，出现提示可输入的光标

@shudery 给 el-select 设置 filterable 属性。https://jsfiddle.net/zhiyang/L3ufgbmr/3/


Failed to run on flutter 2.0.3

I got this error when trying to run flutter on andoird simulator.
/flutter_math-0.2.1/lib/src/widgets/selection/overlay.dart:302:46: Too few positional arguments: 8 required, 7 given. child: selectionControls.buildToolbar ...

The same happens for me with flutter 2.0.2 on the iphone simulator.

I got this error when trying to run flutter on andoird simulator.
/flutter_math-0.2.1/lib/src/widgets/selection/overlay.dart:302:46: Too few positional arguments: 8 required, 7 given. child: selectionControls.buildToolbar ...

I am also experiencing the same problem. Please, give it a higher priority to debug it. - Developer.

flutter_math has not been maintained. Someone already fixed this on the fork flutter_math_fork, and it's on pub.dev until this project is maintained again. https://pub.dev/packages/flutter_math_fork

flutter_math has not been maintained. Someone already fixed this on the fork flutter_math_fork, and it's on pub.dev until this project is maintained again. https://pub.dev/packages/flutter_math_fork

Thank you, any idea whether this package is gonna be maintained again or not?

flutter_math has not been maintained. Someone already fixed this on the fork flutter_math_fork, and it's on pub.dev until this project is maintained again. https://pub.dev/packages/flutter_math_fork

Awesome, thanks, buddy. It is working fine.

Yes,i too feaced the same issue today when building my old flutter web app.
The issue is in thie lib/src/widgets/selection/overlay.dart file whete the selection.buildToolbar is expecting 8 arguments instead of 7,
The last argument that's missiing is for the offset.So i solved this issue by passing the offset as the last argument there.
child: selectionControls.buildToolbar(           context,           editingRegion,           manager.preferredLineHeight,           midpoint,           [             TextSelectionPoint(endpoint1, TextDirection.ltr),             TextSelectionPoint(endpoint2, TextDirection.ltr),           ],           manager,           clipboardStatus,           midpoint,//This right here is the missing argument that was not passed before         ),


Preprocessor does not work with the official cypress image

Current behavior
Preprocessor does not work with the official cypress image (https://hub.docker.com/r/cypress/included) v10.3.0 (built FROM node 12.22.12).  Unfortunately, I think this is because of the issue the FAQ states: https://github.com/badeball/cypress-cucumber-preprocessor/blob/master/docs/faq.md#i-get-fs_1promisesrm-is-not-a-function
Desired behavior
Expected to be able to use the preprocessor with an official cypress image
Versions

Cypress version: 10.3.0
Preprocessor version: 11.4.0
Node version: 12.22.12

Checklist

[X] I've read the FAQ.
[X] I've read Instructions for logging issues.
[X] I'm not using<EMAIL_ADDRESS>(package name has changed and it is no longer the most recent version, see #689).

nevermind, i think my image is non official


sooperlooper: Add alsa library build dependency

Motivation for this change
Currently, sooperlooper is built without alsa support:
checking alsa/asoundlib.h usability... no
checking alsa/asoundlib.h presence... no
checking for alsa/asoundlib.h... no

This causes sooperlooper to have no midi ports, which prevents it from being controlled by a hardware midi controller.
Things done
This change adds alsaLib as a build dependency. With this change the package is build with support for alsa midi ports.
This is my very first nixpkgs pull request, if anything is suboptimal I will happily fix it. Just give me a note.
I have built and tested the package on nixOS 20.03 without problems. The change should not affect any other package.

Built on platform(s)

[X] NixOS
[ ] macOS
[ ] other Linux distributions

[X] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[X] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[X] Fits CONTRIBUTING.md.

While reviewing your PR I noticed the package could be updated and there is another dependency (fftw) missing. I created new PR here: https://github.com/NixOS/nixpkgs/pull/86610 - can you please review this one whether it works for you? Thanks!


Masks

@janper
This adds two things:

The masks features we talked about: See wfc_world_state_slot_mask_set and Features::MASKED_SLOTS (0x04). If the mask is true, the slot is ignored.. maybe this is unintuitive?

wfc_world_state_init_ex. It is like wfc_world_state_init, but you can set initial values for slots (fully zeroed vs fully unobserved), weights (just a number that will be copied everywhere), and masks. It should simplify your initialization code slightly.

I didn't have time to test this at all, so please do test and let me know if you find any problems. If all goes well, I can make a new release out of this for you.
I still need to benchmark this. It adds a condition to an existing branch in hot code. It should be easily predictable, but who knows.
Fixes:
#28
#18

Thank you!
I'll test it but it requires quite some work on my side, too.

If the mask is true, the slot is ignored.. maybe this is unintuitive?

Yes, this is counterintuitive. I'll test it this way but for the release I prefer it the other way around. Or is there any reason/convention to keep it this way?

wfc_world_state_init_ex

Learnt from Microsoft? :)

Could we have something like uint32_t wfc_feature_masked_slots();?

Yeah, I forgot to add it. Will do.

I'm getting an exception.

Does the regular init work? You are sending an integer for a weight.

Does the regular init work? You are sending an integer for a weight.

I've removed the regular init. i'll try to specify that the numbers are uints

            [DllImport("monoceros-wfc-0.5.0-debug.dll", CallingConvention = CallingConvention.StdCall)]
            internal static extern unsafe WfcWorldStateInitResult wfc_world_state_init_ex(IntPtr* wfc_world_state_handle_ptr,
                                                                                AdjacencyRule* adjacency_rules_ptr,
                                                                                UIntPtr adjacency_rules_len,
                                                                                ushort world_x,
                                                                                ushort world_y,
                                                                                ushort world_z,
                                                                                uint features,
                                                                                uint featuresslot_init_value,
                                                                                float slot_module_weight_init_value,
                                                                                uint slot_mask_init_value);

Hopefully brought it up to speed. Merging.


minimum linux requirements

Handler, name and PID not yet implemented. Clicking works, rest waits for somebody else.

Awesome, thanks for the PR pcdeni! A couple changes and we'll get you merged:

Change target branch from master to develop
Pull in any more recent changes from develop


Azerbaijani translates

Translates word for of int to Azerbaijani

Thanks! :heart:

I've just tagged + released 1.8.0 which includes this patch.


Source Point is not visible on cards

Source Point is not visible on cards only destination is visible

I have fixed this issue

and committed into my branch.


Feature Request : Have symbol with padding applied resize when nested symbols are set to "none"

Feature request / enhancement
(Please detail the request; any mockup examples are also helpful)
Feature Request : Have symbol with padding applied resize when nested symbols are set to "none"
I'm looking to mockup an adaptive field group (label, text field, info text and validation)

The field group is a symbol made up of the following grouped layers:
{Group}
{text} Label
{Rectangle} (the field itself)
{symbol} info text
{symbol} Validation Text
{Rectangle} fieldset [10 20]

Bug report
Expected behavior: group resizes when nested symbols are set to "none"
The info text and validation layers are optional -in most cases they won't be shown. In order to hide them I set their override value to "none".

What I would like to happen in this instance is for the field group to resize around the visible content (the Label and field) in the same way it does if I remove the nested symbols from the fieldset rectangle

Actual behavior:
(Please include a screenshot or screen recording if possible)
What actually happens is that the fieldset rectangle doesn't resize :

The ideal behaviour I'd like to present is a whole form created from these elements where the height and relative positioning of the field groups is dependent upon the content presented: Like this

Steps to reproduce:
(Please attach a Sketch file if possible)
paddy-example.zip
I'm assuming here that what actually happens behind the scenes when a symbol's override is set to "none" is that it is simply not displayed (When you detach a symbol configured this way, then the nested symbols set to "none" appear hidden) - so I suppose the underlying feature I want is for Paddy to recognise "hidden" layers as triggers

Thanks @oddjones for the detailed feature request. I really appreciate it.
This is a great idea! Something I definitely want to do. Right now, there's a few things broken with handling Symbols; so I'll look into incorporating this when I reimplement how symbols work.
Cheers,
Dave 👍


Preview in Interface Builder

I'm a quite heavy Interface Builder user because I like to be able to see what my view code or markup will look like before even starting the app. It's also super useful to see what translations do to your layout. Also it's good way to sort of document things as you can see what you will get from every class even when it's a code-only view class.
Since JSQMessagesViewController is a complete ViewController instead of a separate control there's seems to be no real way to pre-render it in Interface Builder, so basically I'm looking at an empty screen in my storyboard. There's also no way to quickly check how font changes, color changes, size changes etcetera reflect in my UI.
I would like to be able to do the following:

Render the basic interface (new message controls) so I don't have an empty view controller in my storyboard
If it renders, it would probably be possible too to also seed it with mock data through prepareForInterfaceBuilder so I can see chat bubbles as well that would reflect all my changes in code

It seems that the current massive view controller approach will prevent me from doing this, but perhaps I've overlooked a possibility? If not, I read in other tickets that the next version will probably be more decoupled from the ViewController. Would it allow me to render it in Interface Builder or would it still be too hard wired to a ViewController?

Hello everyone!
I'm sorry to inform the community that I'm officially deprecating this project. 😢 Please read my blog post for details:
http://www.jessesquires.com/blog/officially-deprecating-jsqmessagesviewcontroller/
Thus, I'm closing all issues and pull requests and making the necessary updates to formally deprecate the library. I'm sorry if this is unexpected or disappointing. Please know that this was an extremely difficult decision to make. I'd like to thank everyone here for contributing and making this project so great. It was a fun 4 years. 😊
Thanks for understanding,
— jsq


Milestone 1 Tasks

Tasks:

[x] Team Contract (Adam)

[ ] Create Repo & Project Structure

[ ] Download Data

[ ] Combine to CSVs

[ ] Load CSV to memory and complete simple EDA

[ ] EDA in R

Markdown Machine Comparison:
| Team Member | Operating System | RAM | Processor | Is SSD | Time taken | |:-----------:|:----------------:|:---:|:---------:|:------:|:----------:|
| Adam Morphy    |  MacOS Big Sur   |  8GB  |   1.8 GHz Dual-Core Intel Core i5   |  Yes   |            |
| Mukund Iyer   |                  |     |           |        |            |
| Julien Gordon   |                  |     |           |        |            |
| Shiva Shankar Jena    |                  |     |           |        |            |

| Mukund Iyer | MacOS Monterey | 8GB | 1.4 GHz Quad-Core Intel Core i5 | Yes | |

| Julien Gordon | Ubuntu 20.04.4 LTS | 16GB | AMD® Ryzen 7 5800h with radeon graphics | Yes | |


[FEATURE] Display random profile on homepage

Description

api to get random profiles (list of users from environment variable)
display randomly selected profile from list on the homepage

note: use code from here to created UI https://github.com/EddieHubCommunity/LinkFree/pull/6998/files#diff-bd5cb53f7f62529ac08cd24699132a88e8567b73d93b5289764cfa29442b5720R139-R197

Screenshots
No response
Additional information
No response

Can I work on this?

Can I work on this?

Can i also work on this as well? is that possible? I'm aware it has been assigned to someone already. I also need clarity please as this is my very first. thanks

I am fine collaborating with someone else.

Can I work now?

Can I work now?

@webstar0103 your message is not clear.  Are you asking this to be assigned to you? This has already been assigned - please read the history and familiarise yourself with the Contributing Guide so that you are aware of project's requirements.

Can I work on this?

Can i also work on this as well? is that possible? I'm aware it has been assigned to someone already. I also need clarity please as this is my very first. thanks

@samthatcode I have assigned this to you and suggest you discuss this with @Vishrut19

I am fine collaborating with someone else.

Hello Dev @Vishrut19 , I also got assigned to feature that was assigned to you and the message said to discuss with you how to go about it. What do you propose and how do you think we should start with the collaboration?. This is my first time and i welcome suggestions and what to do. I have seen your Github profile as well and i think you're more experienced than i am. Looking forward to working with you on this one. I have Installed necessary dependencies and got everything working on ly local machine, Ran the server with mongoDB and it was a success and the database was populated. Kindly get back to me so we can get started. Need more clarification on the description above and this issue that was mentioned by SaraJaoude
[FEATURE] Add user profile in the Navbar #4995. thanks

Need more clarification on the description above and this issue that was mentioned by SaraJaoude
[FEATURE] Add user profile in the Navbar https://github.com/EddieHubCommunity/LinkFree/issues/4995

Please ignore issue #4995 this has been done and is in a PR. Just focus on this issue

Need more clarification on the description above and this issue that was mentioned by SaraJaoude
[FEATURE] Add user profile in the Navbar https://github.com/EddieHubCommunity/LinkFree/issues/4995

Please ignore issue #4995 this has been done and is in a PR. Just focus on this issue

Okay thanks

Hello there,
I can't install node_modules.
@.***: Permission denied (publickey).
fatal: Could not read from remote repository.
this is error message.
Can you help me?
On Thu, Jun 15, 2023 at 8:46 AM Samuel Osho @.***>
wrote:

Need more clarification on the description above and this issue that was
mentioned by SaraJaoude https://github.com/SaraJaoude
[FEATURE] Add user profile in the Navbar #4995
https://github.com/EddieHubCommunity/LinkFree/issues/4995
Please ignore issue #4995
https://github.com/EddieHubCommunity/LinkFree/issues/4995 this has been
done and is in a PR. Just focus on this issue
Okay thanks
—
Reply to this email directly, view it on GitHub
https://github.com/EddieHubCommunity/LinkFree/issues/7575#issuecomment-1592532870,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A3O5ONNC5YXGLDZCAOKXOULXLK4VZANCNFSM6AAAAAAZF5XAK4
.
You are receiving this because you were mentioned.Message ID:
@.***>

I have implemented the [FEATURE] Display random profile on homepage
#7575 in my local machine by { 1. api to get random profiles (list of users from environment variable),
2. display randomly selected profile from list on the homepage }
and its working by displaying a random profile in the homepage just after the LinkFree 100% OpenSource paragraph but haven't pushed yet.  I'm having a question which is the screenshot provided above for clarification and also to ask if the profile should display subsequent profile at random say every 5 seconds just to be dynamic(just my opinion). thanks and will expect feedback

@samthatcode I commented on the PR
@Vishrut19 are you collaborating on this PR?

@Vishrut19 I have unassigned this from you for the following reasons: https://github.com/EddieHubCommunity/LinkFree/issues/7637 In the future if you do not want to collaborate then please unassign yourself.
@samthatcode please do reach out if you need any help with this, particularly as we understand that when you asked to work on this you were under the impression you would be doing so with another community member.

Closing as PR has been merged.


Improved handling of ETABS install configuration

Aim is to remove the need for the settings.py
Possible solutions: configparser, tomlib

Closed with #9


Improved: VIEW permissions Commission Run (OFBIZ-12433)

Currently, when using a userId with only VIEW permission, the Commission Run trigger (menuItem) presents a screen to search and find invoices applicable for the underlying service of creating commission invoices.
On the result shown, the user has access to triggers (functionalities) reserved for users with CREATE/UPDATE permissions.
See (test with): https://demo-trunk.ofbiz.apache.org/accounting/control/CommissionRun and from date= 12/1/1999 12:00:00 AM
Modified:
InvoiceScreens.xml (in AP) - screen CommissionRun

restructured the screen to show result based on permissions
added reference to template for users with VIEW permissions

Added:
CommissionRunSearchResult.ftl template for users with VIEW permissions

Hi Pierre,
Why using Freemarker rather than Widgets?

Good afternoon Jacques,
For several reasons:

There is already a template file for users with CREATE/UPDATE permissions, and to keep contribution experience similar to that
This ticket is not about conversions of template code to xml code.

I was only interested in point 1, but thanks

Then you can regard point 2 as a bonus. :)


no-invalid-this: false positive for method syntax

Keep track of evaluation context: look to the closest parent function
and decide if it is allowed to refer to this
Fix a false negative in the tests from #3267

PR checklist

[x] Addresses an existing issue: #4033
[x] New feature, bugfix, or enhancement

[X] Includes tests

[ ] Documentation update

Overview of change:
Previously, the no-invalid-this rule only had shallow tracking of context. this should be allowed if any only iff the closest parent non-arrow function is either a) a class method, or b) a function with a this type parameter.
There were several drawbacks of not tracking context directly:

The rule didn't treat method declaration syntax the same as function declaration syntax on object literals, causing a false positive on method declaration syntax in object literals (#4033)
The rule could not distinguish between a correct function with a this type parameter and a function inside a function with a this type parameter - in fact, there was a test checked in which enforced bad behavior: https://github.com/palantir/tslint/blob/b104e5ad8fdbbb75f1271a1016ff6272f1aafb9d/test/rules/no-invalid-this/enabled/test.ts.lint#L12 - the this on this line does not inherit type parameter

Is there anything you'd like reviewers to focus on?

CHANGELOG.md entry:

[bugfix] no-invalid-this rule fixes false positives on method-like syntax and false negatives on nested functions

Thanks for your interest in palantir/tslint, @amacleay! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request.

cc @aervin  - I changed a line you added which I believe to be a mistake (https://github.com/palantir/tslint/pull/4034/files#diff-7062f9042aeae109e75e6f78d7430418R33) so my changes deserve extra scrutiny because I'm pretty often wrong!

Hi all! Feedback would be much appreciated if someone has an opportunity to provide it. I think this should be ready to go as-is if the changes seem appropriate to fix the bug (or, what I believe to be a bug).

Please see #4141 before you contribute to this project. Thank you!

Pushing a rebase to hopefully resolve the failure


[Feature]: Update logo format for documentation

What problem does this feature solve?

What does the proposed API look like?
<img src="https://lf3-static.bytednsdoc.com/obj/eden-cn/uhbfnupenuhf/rspress/rspress-logo.webp" alt="Rspress Logo">

Yeah, the optimization is neccesary for user experience.


Fixed issue #604 - Harshfeudal

Done: https://github.com/brainboxdotcc/DPP/issues/604

you updated zlib on windows - does this need an update to zlib headers too? what about the .lib file?

actually just the .lib is updated not dll or header files so this will cause linking issues...

I refactor all, removing old pull request and fix like @Commandserver said :">

no mergeable and needs redoing under a new branch


adds international hellenic university

Official Website: https://ihu.gr
Official Website (Engish): https://www.ihu.gr/en/enhome
URL of Dept of Informatics, Computers and Telecommunications Engineering: http://ict.ihu.gr/
URL of Dept of Informatics, Computers and Telecommunications Engineering (English): http://ict.ihu.gr/en/home
Webmail (Serres Campus): https://mail.cm.ihu.gr/
The university may have other email domains for other campuses (Sindos, Thermi, Kavala).
The university professors have emails on ihu.gr domain (for example, defstat@ihu.gr), students from Serres Campus have emails on cm.ihu.gr (for example, iordkost@cm.ihu.gr).
Example of Professor's email from Sindos Campus - Dept of Informatics and Electronic Engineering<EMAIL_ADDRESS>https://www.iee.ihu.gr/en/staff/chatzimisios-periklis/

Iordanis Kostelidis, Informatics, Computers and Telecommunications Engineering Student

@IordanisKostelidis Pull request merged. Thank you!


[material-ui][Autocomplete] Link in the Paper component is not keyboard accessible

Duplicates

[X] I have searched the existing issues

Latest version

[X] I have tested the latest version

Steps to reproduce 🕹
Link to live example:
Steps:

Current behavior 😯
I have a link in the PaperComponent of AutoComplete which is not keyboard accessible, When pressing 'Tab' key, the autocomplete get collapsed and hence the link cannot be accessed.
Expected behavior 🤔
Should be able to access the link .
Context 🔦
No response
Your environment 🌎

npx @mui/envinfo
  Don't forget to mention which browser you used.
  Output from `npx @mui/envinfo` goes here.

It doesn't look like this bug report has enough info for one of us to reproduce it.
Please provide a CodeSandbox (https://material-ui.com/r/issue-template-latest), a link to a repository on GitHub, or provide a minimal code example that reproduces the problem.
Here are some tips for providing a minimal example: https://stackoverflow.com/help/mcve.

Here is the codesandbox example.

In this autocomplete, I can access the options through keyboard but cannot access the Go to Google link that is in the PaperComponent.
Please let me know if u need some more help.

When you include the open prop, the link becomes focused upon pressing Tab. The problem isn't that the link is inaccessible via the keyboard. You just need to figure out how to maintain the Autocomplete open when the Tab key is pressed. For such help, please use StackOverflow.

Hey @Anubhav-Joria, you found a solution for this?


Direct Navigation to Composable with Control or Command + Click on Destination

Description of the Proposed Enhancement
Currently, when clicking on a destination created by the library without any modifier keys, it performs navigation based on the specified route. However, it would be useful to have the option to directly navigate to the corresponding composable when clicking with Control (on Windows/Linux) or Command (on macOS) held down.
Use Case Example
Within an application that utilizes the library, there is a screen with a list of items that have different destinations configured. Currently, when a user clicks on one of these destinations, the application navigates to the specified route instead of taking the user directly to the corresponding composable. This can be inconvenient and require more steps to access the desired content.
With the proposed enhancement, users could click with Control (on Windows/Linux) or Command (on macOS) held down on a destination and be directly taken to the corresponding composable, avoiding the need to navigate through the complete route.
Benefits of the Enhancement

Increased efficiency and speed in accessing desired composables.
Reduction of steps and clicks required for navigation within the application.
Greater flexibility and control for users in choosing how to navigate the interface.

Additional Considerations

This feature request aims to improve the user experience and provide a more convenient option for navigation within the application.
It would be important to retain the current behavior for cases where no modifier keys are used, as some users may prefer that option.

@xavijimenezmulet I must admit I am a little confused with the proposal. Is this improvement targeting the IDE time for developers or runtime behaviour of navigation? 😅
If you want to control-click on IDE and get to Composable instead of the generated Destination, that would probably require an IDE plugin, so I think it's hard work for little benefit, imo.
BUT what I am doing now is that each generated Destination is commented with the Composable and does so with a link. So navigating to a Destination you'll see the link to the Composable right above the Destination, so you can quickly go to the Composable.
How does this sound? Without a LOT more work, it's what we can do :)

@raamcosta I think what you have said is enough. Simply having a link that allows you to navigate is enough.
Thanks for your quick response! The solution is perfect.

To get around this I've been adding a typealias above each composable and then using that, eg:
typealias ProfileScreenDestination = com.myapp.destinations.ProfileScreenDestination // deliberately not importing so it's easier to check the type aliases are being used by using Find in project.

@Destination
@Composable
fun ProfileScreen(isMember: Boolean) { ... }

and then doing: navigator.navigate(ProfileScreenDestination(isMember = true))
Not sure if there are any downsides, apart from it being a bit unobvious which one to use in the IDE autocomplete so it would be nice if there was an option for the library to generate the Destinations with a underscore prefix or something. But I realise this is kind of a niche option.


Allow inline plural, gender and select expressions in messages

Allows to have messages which are containing a plural, gender or select expression besides other parts. This allows to have messages like:
{
  "sendMessageConfirm": "Are you sure that you want to send {count, plural, =1{one message} other{{count} messages}}?",
  "messageResponse": "{name} has sent you a message. Do you want to answer {gender, select, female{her} male{him} other{them}}?"
}

This makes it also more conform ti the ICU standard.

Thanks @maximilianschelbach for the PR!
We will check it out in the upcoming days

Hi @maximilianschelbach,
Thanks for the effort!
I've checked it, LGTM.
I've just updated the tests.
These changes will be available in the next release.


SASSC-rails support

Hey there!
I was wondering if there are any plans to switch to sassc-rails gem since dependency sass-rails has been deprecated.
I'm willing to work on this but before I put in the work, I'd like to know if you guys will merge it when done?
Reason:
I was updating all my gems in my repo and got deprecation warning on sass-rails favoring sassc-rails. Tried to upgrade but it seems rails_admin has sass-rails as a peer dependency and I'm unable to run both gems side by side.

This happened in #3156.

@jjjcheetah Great! Thanks.


[C++][Parquet] Loading big parquet files leads to huge memory consumption

Loading big parquet files (23GB file) leads to high memory consumption, ending in OOM. Memory consumption surpass my machine limit of 64GB ram. Happens on Linux, arrow 17.0.0, Ubuntu 22
Reader is set up similar as  demonstrated on docs page via  parquet::arrow::FileReaderBuilder with key difference of
passing custom allocator. Huge usage of memory is not report by my custom allocator nor by memory pool passed to reader.
After invastigation iI encouter thath RangeReadeCache created lot of  cache entries, 735 to be exact witch each about 33MiB of length. Each with it's future with use count 1.

Also for some reason this uses default memory pool

Component(s)
C++

Is the parquet file using compression?

Yes it uses compression, although it shouldn't take so much memory, it's read by batches limited to 8192

It's of course hard to say without a minimal reproducible example but it sounds like your inadvertently loading the entire file into memory (735*33 ~ 23G) and is then decompressed which results in OOM as 23G compressed can easily surpass 64G uncompressed.

here is my minimal example of that behavior https://gist.github.com/KuczaRacza/4ddcae7d39aef7bfbe352017b96e15f9. I was wrong about 20+GiB file  swelling to 60+ GiB in RAM other components in my workflow contributed to this high usage. But it look like reading by batches takes roughly same amount of memory as size of the file. It's too much to handle any files bigger than  few GiBs

After invastigation iI encouter thath RangeReadeCache created lot of cache entries, 735 to be exact witch each about 33MiB of length. Each with it's future with use count 1.

Sorry for late reply.
By default, RangeReadCache will try to cache all file you need, it assume you're reading the object storage and need optimization.
You can disable it and using buffer reader, which creates a buffer for each column just in one row-group to avoid OOM


feat(trace): add trace_get method

This pr implements trace_get  from the following tracking issue: https://github.com/alloy-rs/alloy/issues/926

Motivation

Solution

PR Checklist

[x] Added Tests
[ ] Added Documentation
[ ] Breaking changes

Oops I didn't there is already a pr #987 open for that. Closing for now


feat: Axiomatise b ≠ 0 → a * b / b = a

This lets us unify a few lemmas between GroupWithZero and EuclideanDomain and two lemmas that were previously proved separately for Nat, Int, Polynomial.

!bench


experiment: Sparse file support

I decided to take a stab at #89 just to see how feasible it is. In order to facilitate this, I have temporarily changed the API of print_all to take Input with a new generic Box <dyn Read> variant as a fallback.
So far, this implementation is only able to use sparseness when there is non-sparse content at the end of the file, and the rest of the file, including the start, is sparse. Otherwise, it will cause strange errors.
It also only works for Linux, because this was the simplest OS to implement sparse support for.
How to test this:
truncate -s 16G startzero
echo "Lorem ipsum" >> startzero
cargo run --release -- startzero

The position will be slightly wrong but it will finish extremely quickly.
Tasks:

[ ] correct position indexing
[ ] handle fully sparse files
[ ] handle when the file starts with non-sparse data
[ ] handle non-sparse data interspersed in files (this might work already to some extent)
[ ] fully support Linux
[ ] fully support Windows
[ ] fully support MacOS

I decided to take a stab at #89 just to see how feasible it is. In order to facilitate this, I have temporarily changed the API of print_all to take Input with a new generic Box <dyn Read> variant as a fallback.

Just a few comments for now:

I said from the beginning that I'm only going to maintain hexyl-as-a-library on a best-effort basis. I have no problems with breaking changes to the API. Especially if it can advance hexyl-as-an-application. It's also not like we have hundreds of dependents.
I really appreciate your effort here. If you are interested in the problem itself - great! But I just want to warn you that this might very well turn out to be too complex (or too risky in terms of bugs) for an actual merge. I'm not saying it definitely will. Just want to mention that this is a possibility.
Maybe it would be useful to use sth like nix instead of libc directly?

If you are interested in the problem itself - great! But I just want to warn you that this might very well turn out to be too complex (or too risky in terms of bugs) for an actual merge.

Yeah, I'm pretty aware of this, at least at my progress so far. That's why I'm labeling this PR as an experiment, I just want to see how possible it is. At least so far, it seems to work fine on Linux (with a major caveat that I'm trying to work around at the moment).
I hadn't looked into nix before, only rustix. It seems that nix supports SEEK_DATA while rustix doesn't, so I think I'll replace this use of libc with nix (and also maybe raise an issue for rustix).


Modify wording of blood donation question

Make it clearer that this is a separate thing from the service that they've
just registered for.
Raised after comments on https://github.com/nhsalpha/nhs_prototype_kit/pull/77
in order to allow that one to go ahead.
May require rebase

OK let's try out "Are you willing to donate blood?" and see what happens

Works for me. You need to do any rebase type mucking about or shall I merge?

It's rebased :)


ignoreRelatedModels (but include foreign key fields)

Great work on this!
I was thinking of using a generated schema as a starting point for user input validation.
In most cases, I would have no use for the relations.
model agedivision {
  id                  Int                   @id @default(autoincrement())
  ageDivName          String               @db.VarChar(30)
  agedivision_athlete agedivision_athlete[]
  athlete             athlete[]
}

Currently produces:
{
  "agedivision": {
    "type": "object",
    "properties": {
      "id": {
        "type": "integer"
      },
      "name": {
        "type": "string"
      },
      "agedivision_athlete": {
        "type": "array",
        "items": {
          "$ref": "#/definitions/agedivision_athlete"
        }
      },
      "athlete": {
        "type": "array",
        "items": {
          "$ref": "#/definitions/athlete"
        }
      }
    }
  }
}

I would have liked:
{
  "agedivision": {
    "type": "object",
    "properties": {
      "id": {
        "type": "integer"
      },
      "name": {
        "type": "string"
      }
    }
  }
}

Foreign keys would be included.
Is this a feature that you have plans for?

I also really need this.
My usecase: I want to generate Mongo $jsonSchema out of Prisma schema.

@Flax95 Thank you for opening up this issue!
Should the relations only be dropped, If they are not available in the schema or always?

Always.

Let me take the opportunity to further explain my use case:
I am working on an Express REST api.
In my project I divided the different parts of my API into modules. My user module looks like this:

.routes contains routes where, if needed, a validator is called as middleware.
After the validator ran (and if no validation/parsing errors where thrown), the controller calls a service that interacts with prisma.
user.routes.js example:
  import userValidators from './user.validation';
  ...
  userRouter.post('/', userValidators.createUser, createUser);

  userRouter.get('/', getAllUsers);

user.validation.js example:
import { createUserSchema } from './schemas';
import { validateJsonSchema } from '../../utils/validation.util';

const createUser = (req, res, next) => {
  const user = {
    ...req.body,
    userRoleId: parseInt(req.body.userRoleId, 10),
  };

  validateJsonSchema(createUserSchema, user);

  req.body.user = user;
  next();
};

const userValidators = {
  createUser,
};

export default userValidators;

createUserSchema.json example:
{
  "type": "object",
  "properties": {
    "firstName": { "type": "string" },
    "lastName": { "type": "string" },
    "email": { "type": "string", "format": "email" },
    "password": { "type": "string", "minLength": 8 },
    "userRoleId": { "type": "integer", "minimum": 1 }
  },
  "additionalProperties": false,
  "required": ["firstName", "lastName", "email", "password", "userRoleId"]
}

validateJsonSchema(schema, data) is using the Ajv schema validator to validate an object of user inputs against a JSON schema.
What I wish to do is generate something as close to createUserSchema as possible.
Currently the JSON schema generated from my Prisma schema contains userRole[] instead of userRoleId.
"user": {
      "type": "object",
      "properties": {
        "id": {
          "type": "integer"
        },
        "firstName": {
          "type": ["string", "null"]
        },
        "lastName": {
          "type": ["string", "null"]
        },
        "email": {
          "type": ["string", "null"]
        },
        "password": {
          "type": ["string", "null"]
        },
        "userRole": {
          "anyOf": [
            {
              "$ref": "#/definitions/userRole"
            },
            {
              "type": "null"
            }
          ]
        }
      }
    },

You are already able to also generate the relational scalar fields by enabling it in the settings:
generator jsonSchema {
  provider = "prisma-json-schema-generator"
  keepRelationScalarFields = "true"
}

Then userRoleId will be generates as well.

Correct.


Try to reword Dilation specification

At the moment it is written more as the documentation of the Python implementation. In the end, we want it to be a standalone document that helps others implement that protocol too, without having to know any of the Python internals or Twisted.

Thanks for the review

I still see benefits in keeping layers distinct, or at least describing them that way. […]
We don't have to strictly follow what's already there, but some separation of concerns is a big benefit I think.

I don't like the concept of "layer" because to me it invokes feeling of an "OSI layers" stack, which is only true for parts of it. I'd rather think of them as interdependent components, and treat them as such. But you are right, the new wording could make the separation a bit more clear again.
One thing to note is that sometimes the boundaries are a bit fuzzy: For example while Python has L5 stacked on top of L4, one could also write the code that mostly does both at once, but delegates parts of it to a "subchannel manager". (Basically the reverse from what Python does.)

Have you read the latest draft of the python specification? Also it would be good to link that in this document.

Not really no, these changes here are mostly a rebase from my work in last autumn. I think it has changes over there that I should incorporate here? (If possible, I'd like to delegate that too to a future PR)


Make use of matic-bag

I wrote simple storage system on IPFS - https://matic.network/bag which may useful to store these data + ABI too. Let me know. I would be happy to send pull request to integrate.

Link is not active anymore


change readme file introduction

change readme file introduction to this :
A simple web application that permits users to input Markdown and instantly view a preview of the formatted text. This project encompasses HTML, CSS, and JavaScript. Novices can focus on designing the input and output layout, while slightly more experienced beginners can implement real-time updating functionalities.

i would like to work on this issue

Can you assign me this task? @hirentimbadiya


alive multiple state in ui router

Hi, how can i maintain multiple state at a time, in the ui route I have seen that when one state is called by go or transitionTo then execute onEnter or onExit But my requirement is onExit method won't fire when I called second state. is it possible? I want to fire onExit method programmatically and manage popup window side by side. i.e multiple states will be alive not one by one.
Thanks.

@mdshohelrana Check out https://github.com/christopherthielen/ui-router-extras.
It supports sticky states which may get you what you need.

@acollard Thanks


Update short description again

To more closely fit our current target audience, please change the app's short description to read:

Write, compile, and download code to your Parallax Boe-Bot Robot or your custom BASIC Stamp microcontroller-based electronic creations.

@urbantumbleweed - can we fit this issue into Sprint 10?

Verified done.


[WIP] Handle person and role related link expansion

This should be helpful with getting person pages out of Whitehall
frontend.

Done in https://github.com/alphagov/publishing-api/pull/1628.


[FEATURE] Filling missing examples for basic data types

Description of Problem
--contrib-openapi-fill-missing-examples not working as expected along with --hypothesis-phases=explicit
let us say i have a field name, and i use --hypothesis-phases=explicit and --contrib-openapi-fill-missing-examples
schemathesis generates name: '' which is not valid json
type of name is string
also, i have noticed that it will generate empty string for the name field only if it is in the required list, otherwise it skips it altogether
issue with both swagger 2.0 and openapi 3.0
Steps to Reproduce

take attached schema
tree-openapi30.txt
change extension from txt to yaml (github not allowing yaml upload)
run st run -v --hypothesis-phases=explicit --contrib-openapi-fill-missing-examples --validate-schema=true --hypothesis-verbosity=debug tree-openapi30.yaml --dry-run

after testing, i notice the missing examples being filled only when a pattern is specified
for the year, i see 0000 if pattern given is ^\d{4}
for basic schema types like https://swagger.io/docs/specification/data-models/data-types/
expecting examples to be filled, for examples :-
string: abcd ( or consider random from [a-zA-Z0-9]+)
integer: 1 ( or consider random from range 1-100)
number: 1.0 ( or consider random with single decimal)
boolean: random between true or false
Workaround
workaround would be to specify patterns everywhere
if this was intended, it was missing in the documentation!
Version
st, version 3.33.1
Expectation
expecting generated values to be filled for default data types if explicit examples are missing irrespective of required list.
For example, for a field name of type: string, name: 'qwrgte3q5w' is generated irrespective of whether name is required.

hi @ravy
Schemathesis indeed skips optional properties to produce minimal valid examples

schemathesis generates name: '' which is not valid json type of name is string

This is a bit unclear to me, I assume that Schemathesis generates an empty string which at the end is serialized to "" when a test request is sent. The generation strategy which comes from Hypothesis leans towards simpler examples tried at the beginning of the generation process.
It could be changed, i.e. adjusting subschemas so Schemathesis produces some more specific subset of valid values as you mentioned. Optional values could be generated as well.
I think we can trade some minor performance hit (actually really small) to generate optional values too, but examples won't be minimal anymore and I am not sure to what degree it should be changed.


Add ability to specify custom xcodebuild arguments

Thanks. I'll publish to the marketplace later tonight.


For "my opinion" and "others opinion" "undefined" is shown

If I open the dialogue list and then open a dialogue,  my opinion and the others opinion are not shown. Instead it says "undefined"

solved.


env: node\r: No such file or directory

I'm getting this error on MacOs sierra. I found some similar issues with other packages and apparently it has to do with line ending format?

I can solve it in the following way.
$vim /your/oni/path/oni

:set ff=unix
:w

I solved by building it myself.

Thanks @TomatoMus  and @pacuna  for the details!
Ya, looks related to the issue with npm/npm#12371. I've been doing the publish from a Windows machine, which hits this issue. Hopefully the fix to convert the line endings prior to publish will address this.
Cloning and building will work fine, since git auto-converts the line endings when you check out. Glad that works ok :)


[DO NOT MERGE] Merge upstream

This is experimental to help understand the level of drift/effort and UX change.
I've generally kept the micro:bit version of "page" components and tried to pull in other stuff.
We either do this soon or we cherry-pick the translations work and do this later but it will only get harder.
TODO:

[x] Translations are based converting the ml-trainer translations.ts file and so likely missing strings for upstream ML machine changes. Some won't be relevant (e.g. if entire UI sections are enabled) but some will be.
[ ] UX and new feature review. Discussion of next steps.
[ ] Check if the gesture local storage use has changed and needs updating in the cookie dialog config.

Notable upstream changes:

Newer samples go first rather than last. Seems like an improvement to me.
Updates to the filters UI. I think this cannot be accessed from the micro:bit pages. In ML machine it's top left on the Trainer route./
New playground route (presuambly could be dev only) in support of a fair amount of refactoring.
X/Y/Z labels on the right-hand side of the live graph.
...? More review needed.

Translations update
The most practical approach was to look at two diffs and apply any relevant changes:

The upstream diff between base and the point just before we introduced svelte-i18n

git diff $(git merge-base main upstream/main) 773038a9b6c840a3c87613bbae314bf05c808176 -- src/translations.ts

(a fair amount to work through)

The upstream diff between the introduction of svelte-i18n and main

git diff 5f7c11e46056610f3df7ab58eeffe9be3de7560b upstream/main  -- src/messages

(only one string)
I've also made translation updates for the subsequent changes on ml-trainer/main as part of resolving conflicts.

Bug: in the merged version "Train model" on the Trainer screen does not update its disabled status as samples are added/removed


Cannot handle more than 1000 objects of a given type in cron-based labeling

This possible never worked, even in Iris2. After you execute a batch object, it still holds the old requests; it is not cleared. Reusing a batch object means adding more and more objects to it.
Fix:

Recreate self._batch object after executing the batch
Reduce batch limit to 990 to avoid off-by-one errors (since the GCE API has an internal limit of 1000)

Fix in branch nogke-and-over1k-obj
Diff here
https://github.com/doitintl/iris3/compare/master...nogke-and-over1k-obj#diff-08655555cc53ca79554ba180d1ae7e6ebe5c9b0a25e1772ce248fdd8b83dab34R97

Quite likely this was never tested. The fix is as described above


Perf improvement

Consider doing something like this:
https://github.com/microsoft/vscode/blob/0f8c499d1014b9079f01a63c097cc2354400e9ed/src/vs/workbench/contrib/terminal/browser/terminalProfileResolverService.ts#L51-L55
instead of:
https://github.com/microsoft/vscode/blob/8f3a47cc88c2745feed8c1506e93c8dae2082e62/src/vs/workbench/contrib/terminal/browser/terminalService.ts#L370-L376

The slight perf benefit probably isn't worth the extra variable member var on terminal service.


Instruction to implement controllers for scenarios

Need help to implement a controller for scenarios.
Is there a standard set of function the controller need to implement?
Is there a recipe that I can use?
The only controller that I found is manual_control.py but this code is a bit too coupled with pygame. All I need is a 'headless' controller that it receive sensor information and output control information.
Thanks for any help

This issue is better answered in the CARLA main repo. I will move it there.


Convert jib..auth.username and jib..auth.password to properties

Fixes https://github.com/GoogleContainerTools/jib/issues/2905
The following are now properties and not plain strings:

from.auth.username
from.auth.password
from.image
to.auth.username
to.auth.password

@googlebot I signed it!

Sorry for the delay. I'm trying to run some integration tests locally on this branch but having some issue.

Sorry for the delay. I'm trying to run some integration tests locally on this branch but having some issue.
No worries; can I help?

Thank you!


fix(ci): fixed shasum computation for bump-libs CI.

What type of PR is this?
/kind bug
Any specific area of the project related to this PR?
/area CI
What this PR does / why we need it:
As seen in #3378 , we are computing the wrong shasum in bump-libs CI; that is because we are computing the shasum of https://github.com/falcosecurity/libs/archive/refs/heads/master.tar.gz and not https://github.com/falcosecurity/libs/archive/${commit-hash}.tar.gz; even if commit hash is of course the same.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

NONE

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: FedeDP
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [FedeDP]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/milestone 0.40.0

bump-libs workflow run against this branch: https://github.com/falcosecurity/falco/pull/3380
It works!

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Andreagit97, FedeDP
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [Andreagit97,FedeDP]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Installed v0.11.9, it says the version is 0.11.6

Operating system
Microsoft Windows [Version 10.0.22635.3286]
YouTube Music Desktop App Version
v.0.11.9
Bug description
I have installed version 0.11.9, but app thinks it's 0.11.6 and it bothers me all the time with update. When I try to update it restarts, but still says it's 0.11.6.
There is no logs file in the installation directory
Steps to reproduce

Download YouTube-Music-for-Desktop-0.11.9_x64.exe
Install it
Open app

And it should say it's at version 0.11.6
Relevant log output
No response

Same issue on MacOs 14.1 (23B74)
Not updating, had to manually install from github

0.11.9 is a prerelease with new builded platform flags, it may cause issues while upgrading from stable

Yeah, but I wasn't upgrading from stable. I tried to install it from provided instalator.

Yeah, but I wasn't upgrading from stable. I tried to install it from provided instalator.

i added a note to the pre release that its required to download from github instead the of the stable updater.
due to changes made on the building parameters..


Merge cardano-sl-0.5 to master

This includes changes made in #1316

@Martoon-00 there are conflicts, resolve them please. Also please request review more intrusively.

❤


Update maturin, consolidate config towards pyproject.toml

Update maturin requirement.
Consolidate all config in pyproject.toml and remove setup.cfg
Fixes #218

Can you try running the CI Build Wheel workflow on the branch in your repository?

I'm not sure what you mean by that

Can you try running the CI Build Wheel workflow on the branch in your repository?

I'm not sure what you mean by that

Go to https://github.com/dvzrv/cmsis-pack-manager/actions
Select CI Build Wheel workflow on the left side.
On the right side you should see "This workflow has a workflow_dispatch event trigger.". Click on the drop-down Run workflow, select dvzrv/update_maturin branch in for Use workflow from parameter and click on the green button Run workflow. See also GitHub documentation (https://docs.github.com/en/actions/using-workflows/manually-running-a-workflow) if the instructions are not clear.

The Continuous Integration action (https://github.com/pyocd/cmsis-pack-manager/actions/workflows/ci.yml) only runs on different versions of Python on Ubuntu. The CI Build Wheel builds for many different targets.

Tested in https://github.com/mbrossard/cmsis-pack-manager/actions/runs/8590759703


Is it possible to turn 1x4 stribs into 2x2 to maximise screen usage?

First off I have to say thank you for making this tool, it works fantastically! I just started rereading some of my old favorite comic strips on my kindle and I immediately noticed that a good chucnk of the screen is squandered. So my question is this: is it possible to output a strip in 1x4 as a 2x2 grid?
Images below to better illustrate:
This 1x4 strip

When converted results in these two pages:

should be possible, I'll have a look

I added a new option in the GUI

check the beta version here
https://github.com/darodi/kcc/releases

Thank you so much! I'll give that a try!

I’m sorry for the late response—it works great! Thank you so much for adding the feature!


GRXWriter, GRXBufferedPipe takes too long time, when switching connection from offline to online. ObjC, ios, swift.

Device is:  ipad-2, ios 9.3.5, grpc 1.2.0. Server: golang grpc.
When starting app, reaching server over wi-fi(good connection) very fast.
But if i switch wi-fi to OFF, then again switch it to ON, for me it takes 15-20 seconds to reach server.
I also tested it over local  golang server, same, takes too long time. What can cause this issue?

Find mistake, this is already my mistake.


Job list: add retries column

Closes #2424

Coverage decreased (-0.01%) to 52.647% when pulling ce849bf09b7544e66c319ee7e1a8c62d69d6f3c9 on qixcheng/webportal/master/job-list-retries into d181ca177f3bbd07c214d4d8c4198060a52a96fd on master.


Allow cwd in options

For example:
copy: {
    dev: {
        cwd: '<%= project.source.base %>',
        src: '<%= project.dev.copy %>',
        dest: '<%= project.dev.base %>',
    },

    dist: {
        cwd: '<%= project.source.base %>',
        src: '<%= project.dist.copy %>',
        dest: '<%= project.dist.base %>'
    },

    options: {
        expand: true
    }
}

becomes
copy: {
    dev: {
        src: '<%= project.dev.copy %>',
        dest: '<%= project.dev.base %>',
    },

    dist: {
        src: '<%= project.dist.copy %>',
        dest: '<%= project.dist.base %>'
    },

    options: {
        cwd: '<%= project.source.base %>',
        expand: true
    }
}

It also looks like expand is ignored in the top level options object.

expand is not an option. It's something passed directly to grunt.


Can we add on-hold reorder items without handles when reordering for ionic 2?

Hope we can do reorder without handles. God bless!

@2arcz6 I will close this issue since I want to keep all the v2 reorder progress in the same place #5595.
but yes! I am going to start working on reordering for v2 and it will support doing so without handlers, thanks for the idea!

Alright I'm glad to hear that, Thanks. God Speed.
On Thu, Jun 9, 2016 at 4:21 PM, Manu Mtz.-Almeida<EMAIL_ADDRESS>wrote:

@2arcz6 https://github.com/2arcz6 I will close this issue since I want
to keep all the v2 reorder progress in the same place #5595
https://github.com/driftyco/ionic/issues/5595.
but yes! I am going to start working on reordering for v2 and it will
support doing so without handlers, thanks for the idea!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/driftyco/ionic/issues/6439#issuecomment-224829841,
or mute the thread
https://github.com/notifications/unsubscribe/AIvUkTgEc7N7k_lKg0GGL1V_0kBVHEqiks5qJ80agaJpZM4IX373
.


List of requested packages : missing "installed version" in edit mode

In edit mode, the list of requested packages shows empty rows for the "installed version" column :

This seems to happen when the requested package is at its "latest" version.

PR: https://github.com/Quansight/conda-store-ui/pull/70

Done


Dublication

see https://scrutinizer-ci.com/g/moip/moip-sdk-php/issues/master/files/src/Resource/Account.php?orderField=path&order=asc&honorSelectedPaths=0#inspectioncomment-68652969
This method seems to be duplicated in your project.

see https://scrutinizer-ci.com/g/moip/moip-sdk-php/issues/master/files/src/Resource/Customer.php?orderField=path&order=asc&honorSelectedPaths=0#inspectioncomment-66118116


Make the SDK work with Node.js

Add and end-to-end test as well

In theory this only requires finding http and promise libraries to pass in during initialization, right?

And then creating a nodejs-wrappers.js file and updating intit.js to properly detect when nodejs is being used.
Shouldn't be too bad...

Exactly right.
For the promise library you should be able to use https://github.com/kriskowal/q . Angular's promise library is modeled after this library.
For the http library you could consider using http://nodejs.org/api/http.html#http_http_request_options_callback

sorry - the previous comment was made by me.

Closed by #81. But not entirely useful until multiple instances are supported #42.


Unterminated Jinja block...Expected end tag: ({% endfor %})

Describe the bug
sqlfmt encountered an error: Encountered unterminated Jinja block at position 720. Expected end tag: ({% endfor %})
To Reproduce
Steps to reproduce the behavior. If this is a formatting issue, include the input code here.
{% macro get_unique_attributes(source_table, node_col) %}

{% set attribute_query %}
    select
        distinct x.key as attributes
    from {{ source_table }} x
    where startswith(x.key, '@')  -- attributes get parsed as keys that start with '@'
        and length(x.key) > 1 -- but keys of just '@' designate the node itself
        and regexp_count(x.path, '\\[') > 1 -- we don't need the attributes from the xml root node
        and not startswith(x.key, '@xmlns') -- we don't need attributed data about xml namespaces
{% endset %}

{% set results = run_query(attribute_query) %}

{% if execute %}
    {% set results_list = results.columns[0].values() %}
{% else %}
    {% set results_list = [] %}
{% endif %}

{% for attribute in results_list %}
    , get({{ node_col }}, '{{ attribute }}')::varchar(256) as attribute_{{ dbt_utils.slugify(attribute) | replace("@", "") }}
{% endfor %}

{% endmacro %}

Expected behavior
sqlfmt produces an error about an unterminated Jinja block and missing a endfor tag, but that tag does exist, and there doesn't appear to be any other incorrectly terminated items.  The macro works without issue on Snowflake
Actual behavior
        1 file had errors while formatting.
        0 files left unchanged.
        dbt/macros/get_unique_attributes.sql
            sqlfmt encountered an error: Encountered unterminated Jinja block at position 720. Expected end tag: ({% endfor %})

Additional context
What is the output of sqlfmt --version?
Using VS Code extension, Trunk, which looks to be using<EMAIL_ADDRESS>The same error occurs when attempting the macro on the sqlfmt.com website.

Thanks for the report! I'll investigate next week. I think the issue is that we hit get() without first parsing select, since that's inside of a set block. GET is also Snowflake DDL that we don't yet support, so we skip ahead to the end of the query and miss the ending jinja tag


[POP]Make messages in reviveTopic more evenly written to different queues

FEATURE REQUEST

Please describe the feature you are requesting.

The CK and ACK msgs shuold be more evenly written to different queues

Provide any additional detail on your proposed use case for this feature.
There is one thread for each queue of reviveTopic to process the CK and ACK msgs. If the msgs are evenly written to different queus, that will make the pressure of each thread more balanced.

Indicate the importance of this issue to you (blocker, must-have, should-have, nice-to-have). Are you currently using any workarounds to address this issue?
should-have

If there are some sub-tasks using -[] for each subtask and create a corresponding issue to map to the sub task:

merged


Fix nit in ConfigDataSelector

Fixing one last nit, @tmrts PTAL

Shouldn't ConfigDataName field just be Name? Having that prefix seems redundant

@tmrts, @bgrant0607 pointed out that we should follow the pattern in SecretVolumeSource.  We also try to avoid fields with the name "Name" except for the ObjectMeta field.

Understood LGTM

LGTM, thanks.


"Hello world" program won't compile

When I try to compile any Swift file with swiftc, it complains:
<unknown>:0: error: unable to load standard library for target 'x86_64-unknown-windows-msvc'`

Nothing I do will get it to succeed. This occurs even on swiftc -c empty.swift (where empty.swift is a zero-length file). I am using the installer.exe from this build. What am I doing wrong? Thanks!

If I add the following flag to the compiler command line, it works just fine:
swiftc -sdk C:\Library\Developer\Platforms\Windows.platform\Developer\SDKs\Windows.sdk -c empty.swift

Closing this issue as it is resolved for me.

https://github.com/compnerd/swift-build/issues/203


add Layer.pathOriginal to list all route paths

This PR is to solve the problem of listing all routes. Right now, it is not possible to get the full path of a route. A new member pathOriginal is added to Layer.

Can you provide the expected code that would work in conjunction with this change? How you are expecting to handle regular expression values, arrays, and the like?

A test case has been added to the original PR. I thought it would have been sufficient. Would you like another test case ?
Suppose the following code:
let usersRouter = UserRouter(app, app.auth);
app.use('/users', usersRouter);

The current implementation does not save /users, it is just to used to set the regexp.
The idea behind this change is to retrieve the full URL of all routes.

Hi @FredericHeem , the test case included doesn't show any use-case for adding this API and is even using an undocumented property, _router. In order to justify adding new features to the public API, we need to know exactly what the use-case is, how people are going to use it, how are we going to describe the feature and show examples of how to use the feature, etc.

The use case is to display the url for all registered routes:

http://stackoverflow.com/questions/14934452/how-to-get-all-registered-routes-in-express
http://thejackalofjavascript.com/list-all-rest-endpoints/
https://github.com/labithiotis/express-list-routes
https://groups.google.com/forum/#!msg/express-js/UeYMnR8pZ-c/jcgTzbaJBw4J

This is a feature already requested by several people.
Unfortunately, it only works some simple cases.
When the router is given to express app with use function:
  let app = express();
  let router = new express.Router();
  //Add routes here...
  app.use('/users', router);

Then is no way right now to retrieve the path /users
Example of such a code: see https://github.com/FredericHeem/starhackit/blob/master/server/src/app.js#L57
Let me know if you need more info. I'll do my best to get this PR included, maintaining a separate fork just for this issue doesn't make sense and it would be a maintenance debt.

I know it's an often-requested item, but we cannot simply accept a hack that only works in simple cases, otherwise we're on the hook to implement the rest, as people will come in asking why other cases are not supported.
I'm definitely willing to add the support, but it needs to work robustly, with all the different ways routes can be declared in a simple to use manor that does not used undocumented properties like stack.

The modification is an improvement to the current situation which only work is the most simple use case. The "hack" makes it work in at leat one more use case and doesn't break any current one.
What more can I do to make this PR go ahead ?

Adding a hack we are going to have to maintain is not an improvement for us. If your goal is to get a list of all the routes, then the PR should accomplish that task.
Adding something that is not used by any of the code in Express is by definition a public API, and this is not a usable public API for all the reasons said above.


Weekly community hangout

In the interest of collaboration and transparency I'd like to propose a short open online meet-up perhaps once a week for anyone who is working on Express issues/pull requests to share their plans, progress and thoughts on what they are working on.
I would suggest a Google Hangout and a scrum format (what have you been working on? what are you going to work on? are you blocked?) plus questions/any other business. Suggestions for alternatives welcome.
To start the ball rolling on a time/date, how about: a 10-30 minute hangout on Tuesdays at 5:30pm EST / 10:30pm GMT.
Feedback and expressions of interest welcome in this thread.

If you are interested I could also stream the hangout on my site, which would provide a group chat and way for people to view the meeting without necessarily participating.  Hopefully then expanding the participation beyond the people who feel comfortable getting on a hangout call.
This [is the channel[(https://www.stream.me/js) I have used in the past for streaming javascript related stuff, but I could also get the expressjs channel if you were interested.  Let me know.

So my coworkers just told me that there is a public google hangout feature, which I did not know about.  Don't know if that means it allows anyone to join, or if there is a way to not join and just watch.  So disregard my comment if there is a way for people to just watch and not participate.

Can the meeting be later in the day? I'm not able to attend during working hours.

@tunniclm ... perhaps a doodle poll with a broader range of options would be better?
@dougwilson ... which timezone are you in and what time range tends to work best for you?

I'm in Eastern time, but have to commute home, so 5:30pm ET is part of commuting. I think a Doodle poll would be good. If it's a recurring meeting, then 6pm ET or later is good, 7pm or later is best. Otherwise 9am ET or earlier is good as well.

Hangouts on air provides a way to have a youtube channel that people can use to just watch.  Also provides a recording which can be watched later on.

We should probably just roll this into the TC meetings for now?

@Fishrock123 ... +1 that would likely be easiest. The original thought was to have something temporary but it looks like we can get moving on this rather quickly

I assume it will still be useful to poll for days/times, so here's a doodle poll:
http://doodle.com/poll/5hn5eap2w73y5ncc
Let me know if any more options need to be added. Check the "Time zone" setting to make sure it is correct for your location.

@tunniclm could you add a couple of morning times e.g. 8am ET as an option to the Doodle, just to see if that's a possibility?  Most of the current options are 12:00am or later UK time.

@sjanuary Done!

Hi @tunniclm, is that Doodle for a generic weekly meeting, or is it for a one-time meeting next week? Sorry, the dates being on there is what is confusing me.

Nevermind, I didn't realize Doodles had a comments section. It's generic weekly.

All of those times are pretty bad for me. 8am or > 6pm. Later than 6pm is only really possible for me on wednesdays, and wednesdays are already quite busy in general.

oh hmmm, I see doug can't do during work hours... wednesday could work then, I'll fill in.

I have added a few more options: 09:00 EST and 18:30 EST on weekdays.

I updated my line for the new times.

Should we start by doing Wednesday at 6:30 PM then?
@jasnell you sent an email to the existing org owners, did you point them to this thread?

/cc @expressjs/express-tc

I assume that's 6:30 Eastern? That's generally good but won't be able to make it this next week due to a conference.

@mscdex / @ritch / @blakeembrey are any of you able to attend on Wednesday at 6:30 PM EST? (Or fill out http://doodle.com/poll/5hn5eap2w73y5ncc ?)

Most weeks this will also work for me :)

Works for me, I'll fill in the poll.

Was the hangout starting this week? I can't recall seeing any specifics pass my way.

I think ideally, yeah.
Ideally, we should generate a meeting issue like a day beforehand. Gona try to do one now via https://github.com/rvagg/make-node-meeting
Standard meeting tool is google hangouts. @mikeal do you know off-hand how to make a hangout on-air?

Bah, unless anyone wants to setup something makeshift, maybe we should do it properly for next week.
I think we need everyone's google account emails or something for hangouts on air but I'm not really sure, I'll wait for @mikeal to chime in.

I think it really needs to happen, as we've had weeks to get this meeting going. I'm on Google Hangouts and trying to get people together right now and got @tunniclm in the call.

Are you making it public? I would love to listen in 😀
On Wed, Feb 24, 2016 at 5:34 PM Douglas Christopher Wilson <
<EMAIL_ADDRESS>wrote:

I think it really needs to happen, as we've had weeks to get this meeting
going. I'm on Google Hangouts and trying to get people together right now
and got @tunniclm https://github.com/tunniclm in the call.
—
Reply to this email directly or view it on GitHub
https://github.com/expressjs/express/issues/2885#issuecomment-188515064.

Yes, please do a hangout on air. Unfortunately won't be able to make it for
this week but I'd love to catch the replay.
 I would love to listen in 😀
On Wed, Feb 24, 2016 at 5:34 PM Douglas Christopher Wilson <
<EMAIL_ADDRESS>wrote:

I think it really needs to happen, as we've had weeks to get this meeting
going. I'm on Google Hangouts and trying to get people together right now
and got @tunniclm https://github.com/tunniclm in the call.
—
Reply to this email directly or view it on GitHub
<https://github.com/expressjs/express/issues/2885#issuecomment-188515064
.

—
Reply to this email directly or view it on GitHub
https://github.com/expressjs/express/issues/2885#issuecomment-188522131.

I have no idea how to do a hangout on air, unless someone can walk me through it.

I can stream it on my site like i offered up above if you want, would mean I have to be on the call.

https://support.google.com/plus/answer/2553119?hl=en has all the info. Link
at the bottom for Starting a Hangout on Air.
When you launch it as a participant copy the URL and send that to the other
participants. It's a bit annoying and manual.
On Feb 24, 2016 3:53 PM, "Douglas Christopher Wilson" <
<EMAIL_ADDRESS>wrote:

I have no idea how to do a hangout on air, unless someone can walk me
through it.
—
Reply to this email directly or view it on GitHub
https://github.com/expressjs/express/issues/2885#issuecomment-188524088.

Gotcha. Yea, I tired it and it wants me to confirm and setup a YouTube account before I can do anything. Since a bunch of us don't have much time and it's already 30 minutes past the time, we're just doing what works for now that we can immediately have.

Yep, understood. Will catch up the minutes later. We can work on the on air
process later.
On Feb 24, 2016 4:00 PM, "Douglas Christopher Wilson" <
<EMAIL_ADDRESS>wrote:

Gotcha. Yea, I tired it and it wants me to confirm and setup a YouTube
account before I can do anything. Since a bunch of us don't have much time
and it's already 30 minutes past the time, we're just doing what works for
now that we can immediately have.
—
Reply to this email directly or view it on GitHub
https://github.com/expressjs/express/issues/2885#issuecomment-188526367.

seriously you can add me to the call and I will have a live stream with archiving up in the instant<EMAIL_ADDRESS>is the gmail

https://www.stream.me/js

Thanks everyone for the meeting! Sorry I have never done this before and really don't even use Google Hangouts at all anyway (I was hoping for one of the appointed mentors to help with this), so thanks to @wesleytodd for jumping in there and streaming/recording it! As this was not a TC meeting but a community hangout (see issue title), there were no decisions made, only general discussions, ideas, and history discussed.
In the future, let's get a designated person who will make the meeting Hangout and will be at the meeting so we don't end up in ad-hoc mode again. Also, I think in addition to specifying the time the meeting will start, it's also important to specify the duration of the meeting before hand as well, not only to help drive to a conclusion, but so people (including myself) have an idea of when I can do something after the meeting.
I'm closing this issue since I think we have a good time to have the weekly community hangout, though a meeting for TC needs to be worked out at some point, ideally in an issue about making a TC meeting.
To help close the gap of making a ton of meta issues in this repository, since we have an organization, I created the repository https://github.com/expressjs/discussions/issues for now.

Very happy to see this happen. I'm sorry I could not attend as one of the
mentors. Will definitely be one the next one and will help with the
hangouts stuff.
On Feb 24, 2016 6:27 PM, "Douglas Christopher Wilson" <
<EMAIL_ADDRESS>wrote:

Thanks everyone for the meeting! Sorry I have never done this before and
really don't even use Google Hangouts at all anyway (I was hoping for one
of the appointed mentors to help with this), so thanks to @wesleytodd
https://github.com/wesleytodd for jumping in there and
streaming/recording it! As this was not a TC meeting but a community
hangout (see issue title), there were no decisions made, only general
discussions, ideas, and history discussed.
In the future, let's get a designated person who will make the meeting
Hangout and will be at the meeting so we don't end up in ad-hoc mode again.
Also, I think in addition to specifying the time the meeting will start,
it's also important to specify the duration of the meeting before hand as
well, not only to help drive to a conclusion, but so people (including
myself) have an idea of when I can do something after the meeting.
I'm closing this issue since I think we have a good time to have the
weekly community hangout, though a meeting for TC needs to be worked out at
some point, ideally in an issue about making a TC meeting.
To help close the gap of making a ton of meta issues in this repository,
since we have an organization, I created the repository
https://github.com/expressjs/discussions/issues for now.
—
Reply to this email directly or view it on GitHub
https://github.com/expressjs/express/issues/2885#issuecomment-188570013.

Hi, y'all, I'd like to listen/watch/read any minutes from these meetings if possible.  Are the minutes for this recent meeting anywhere?  I checked the https://www.stream.me/js stream, but there only seems to be a chat session.
I also checked the  https://github.com/expressjs/discussions/issues site--am now watching it--but there doesn't seem to be anything there yet.
Thanks in advance!
--Monico
Austin, TX area

@cdnadmin I will post the video as soon as it is done transcoding.  You must have missed the stream.

And as we continue these meetings, I would like to eventually get them all up on the Express.js website, including information about when the meetings are so people know when to live-stream in. Ideally it was really cool to help people get involved if the Express.js com website had a way to tell people "a live stream is happening right now!" or otherwise a block of information about these meetings and such. Related to the ideas in #2902 to get flushed out at some point.

@wesleytodd thx!  will look for it soon.
@dougwilson that'd be really nice.  looking forward to all these new changes, etc.  btw, saw #2902  Looking forward to seeing that implemented.
Exciting times!

The archive is available now: https://www.stream.me/vod/expressjs-community-hangout/emleAZ3pld
I will also make sure to download the mp4 so that once we want to host them somewhere we can add them to the collection.

@wesleytodd Thx, man!

Awesome, @wesleytodd! I'm not familiar with the steam.me site, but is that link a video host, similar to YouTube? I don't think whatever place the website will end up being will have the capacity to host an mp4 file directly, so we would need to keep the recording on some video site, like that or YouTube or something. I couldn't immediately see what Node.js does, if someone can point me to their archive.

Ahh, right.  We do host videos, but usually only for 45 days.  Seeing as I am an employee I might be able to circumvent he normal rules and provide permanent hosting but let me see :)
If I can, then we would just be able to use the video embeds and I could set it up to keep them forever.  Ill update here when I can get an answer, hopefully tomorrow.

Thanks for posting the recording @wesleytodd, the timing didn't work out for me to be able to attend in the end but it was good to be able to watch it through afterwards and hear all the thoughts etc.

NP @sjanuary :)
And Im glad you commented because I forgot to follow up on keeping the videos around.  We can keep them, and provide the video embed for when we want to add them to the website.  I think it will be nice for people to be able to go back and watch them.


Internal/everyone group  not retrieve in unique id read and write Ldap

User store: unique id read and write Ldap
Internal/everyone group not retrieve from SCIM2 list
Request:
curl -v -k --user admin:admin https://localhost:9444/scim2/Groups/?attributes=displayName
Response:
{"totalResults":4,"startIndex":1,"itemsPerPage":4,"schemas":["urn:ietf:params:scim:api:messages:2.0:ListResponse"],"Resources":[{"displayName":"Application/User Portal","id":"ff4617fb-7eb7-4258-a3e7-060bab171073"},{"displayName":"isTestUserRole","id":"5c4d8bd6-a818-4bad-9eea-7a1ed7b3d898"},{"displayName":"Internal/system","id":"70db7029-b355-41ad-8387-9dc5874cc11b"},{"displayName":"admin","id":"275b9e61-4caa-470d-910c-2c60c996602a"}]}

Internal/everyone role is for IS internal use, thus decided not to return. Therefore, this is the expected behaviour.
Please refer to the related issue: https://github.com/wso2/product-is/issues/7254


PowerVS create infra expects transit gateway location even when we pass existing transit gateway

When user tries to use existing transit gateway, location is not required as transit gateway name is unique across different locations.

/assign @aman4433

/cc @aman4433

/assign


BUG: "Icon" size does not match other types

The Icon has some inner padding that results in not corresponding size to other image types.
Icon:

Color:

It is impossible to properly align the icon or to make transitions and css animations due to this.

That is a shame, it does look great on hover to transition from flat to plastic. Anyway I can't see any shadow on it, what did you mean? Also the top touches the border anyway.


Merge master into null safety

This brings the following changes from master branch:

Support optional proto3 fields (#444)
Fix handling of oneofs in dart proto3 json parsing. (#447)
Use @dart = 2.7 in generated files (#455)
Migrate from Travis to GitHub Actions (#460)
Emit binary coded descriptors from dart protoc_plugin. (#406)

Github Actions config modified to run only on dev sdk. Also modify analyzer flags to remove --fatal-infos, there's one mixin-related violation:
hint • The library 'package:protoc_plugin/testing/mixins.dart' is legacy, and should not be imported into a null safe library. • out/protos/mixins.pb.dart:12:8 • import_of_legacy_library_into_null_safe

Also slightly speeding up a build by removing make protos step from format stage: generated protos are not checked in and formatted anyway, but generating and checking format takes 3-4 minutes.

No, see https://github.com/dart-lang/protobuf/pull/440, until protoc_plugin
is null safe we can't really migrate those. I'll send a separate PR to
change version on protoc sources to 2.11 and then regenerate bootstrap
protos, WDYT?

No, see https://github.com/dart-lang/protobuf/pull/440, until protoc_plugin
is null safe we can't really migrate those. I'll send a separate PR to
change version on protoc sources to 2.11 and then regenerate bootstrap
protos, WDYT?

until protoc_plugin is null safe we can't really migrate those.

Ah of course!

I'll send a separate PR to
change version on protoc sources to 2.11 and then regenerate bootstrap
protos, WDYT?

Sounds good!


chore: fix new rust and clippy lints

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.60%. Comparing base (29097dc) to head (583c09a).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #166      +/-   ##
==========================================
+ Coverage   98.58%   98.60%   +0.01%
==========================================
  Files          79       79
  Lines       24437    24364      -73
==========================================
- Hits        24092    24023      -69
+ Misses        345      341       -4

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Import fails when a torrent consists of a single file

When trying to import a torrent containing example.epub (without any directory), it checks for
/base-dir/example.epub/example.epub
instead of
/base-dir/example.epub
Creating a directory named "example.epub" and copying example.epub in it solves the problem, but it would be a good thing to correct this if possible.

Generally, it would be a good thing to fix it, but it is some effort and since these should be replaced by proper torrent-name/file-name.ext torrents (even if they contain a single file), I didn't think it's worth the effort at the time. Maybe just fix them and replace the old ones. If anyone else wants to fix that...

Is it mandatory to have a folder even for one file ? I wasn't aware of this rule, in this case it's probably not worth it. karamanolev/WhatManager2 wrote:Generally, it would be a good thing to fix it, but it is some effort and since these should be replaced by proper torrent-name/file-name.ext torrents (even if they contain a single file), I didn't think it's worth the effort at the time. Maybe just fix them and replace the old ones. If anyone else wants to fix that...
—Reply to this email directly or view it on GitHub.
Sent Using Firefox OS

Hmmm that seems only to apply to music, but since that's what I use WM for ... I guess anyone who needs that could fix it and I'll merge the pull request.

Yeah, I've encountered this too. The rules about single file torrents requiring an enclosing directory only apply to music, so there are valid torrents (books, apps, etc.) that fail to import because of this. I just throw all my torrents in WM rather than having a separate setup for non-music, so it'd be nice to see this fixed. I will see if I can take a look at it myself...


Remove header focus outline.  Fixes react-tools/react-table#685

My project relied heavily on react-table. Sticked with 6.7.4 so far.

It was fixed and someone "unfixed" it - we are battling between a "clean" look and "accessibility".

@gary-menzel what is the goal then?  To keep the blue hover outline but not have it overlap the next column?

@maccuaa Personally, I prefer the "clean" look. I don't want a blue line at all.  It was introduced accidentally as part of eslint checking and took quite a while to resolve.  ReactTable is FAR from meeting accessibility guidelines (no keyboard support - for example) so I don't think the focus box should be there at all - but I am not focussed on accessibility.
I think the solution is fine - but I'd say this is more of a "fix recommendation" rather than a PR.  The react-table CSS is meant to be copied and hacked to suit the end-user needs.
But, that is really only my opinion.  I've not upgraded since 6.7.6.

Since I was going to commit the same fix again. 👍


stdlib: fix -Wnullability-completeness warning

Annotate the return of _NSGetEnviron to be complete with nullability.
This would show up as warnings when building the shims.  NFC.

Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

Resolves SR-NNNN.

@swift-ci please test

Build failed
Swift Test OS X Platform
Git Sha - 2610936aa30a8fb67a15a0aeecd25d924b4d8bd3

We can assume that two of the three pointer levels of _NSGetEnviron are non-null. (The process will have crashed long before if they are null).
_NSGetEnviron can be _Nullable _Nonnull _Nonnull
_stdlib_getEnviron can be _Nullable _Nonnull.

Hmm, the implementations of getenv and setenv appear to handle the case of null environ. Swift's Process.environ implicitly assumes it is never null, and I don't know if it can be null in reasonable circumstances.

I based the attributes on the basis that getenv and setenv have to support that.  I don't know if that is really possible in most cases, but because they need to be supported, I opted for the precision.  I can change it if you feel strongly about it.

@swift-ci please test macOS platform

Build failed
Swift Test OS X Platform
Git Sha - 2610936aa30a8fb67a15a0aeecd25d924b4d8bd3

@swift-ci please test

Build failed
Swift Test Linux Platform
Git Sha - 2610936aa30a8fb67a15a0aeecd25d924b4d8bd3

Build failed
Swift Test OS X Platform
Git Sha - 2610936aa30a8fb67a15a0aeecd25d924b4d8bd3

Hold on. This is now a source-incompatible API change. If you want to make the public environ property nullable you'll need to take it to swift-evolution.

@gparker42 there, that should restore source compatibility

@swift-ci please test

Build failed
Swift Test Linux Platform
Git Sha - 8c3826e08cdd92d376e6b241798031233a2a9d26

Build failed
Swift Test OS X Platform
Git Sha - 8c3826e08cdd92d376e6b241798031233a2a9d26

@swift-ci please test

Build failed
Swift Test OS X Platform
Git Sha - 3ce000e3ffc2660242b38dd1d8f6417e64fcc2bf

Build failed
Swift Test Linux Platform
Git Sha - 3ce000e3ffc2660242b38dd1d8f6417e64fcc2bf

I am confused how what you wrote even compiles. What does UnsafePointer(nil) do?

Just builds a null pointer (at least, it used to build at one point).  Im usually building on Linux, but I suppose I should try to build this on Darwin.

It might do that, but the return type should be an optional pointer when it does it. That wouldn't match the return type.

@jrose-apple, yeah, and thats where I am getting stuck.  That involves a source incompatible change, which would require going through the swift-evolution process.

That's why I'm trying to convince you not to handle it. :-)

Well, no, really I'm trying to convince you not to handle it because it makes everything worse if you do. I would honestly rather deterministically trap on wmain Windows saying "you must call _getenv before accessing this, sorry, that's what Windows does" than make _environ optional.

@jrose-apple oh, if that were the case, Id be happy.  Im trying to address the POSIX behavior here.  If you look at libc, you will find that _NSGetEnviron is actually char * _Nullable * _Nullable * _Nonnull _NSGetEnviron(void).  This makes environ of type char * _Nullable * _Nullable which is what Im trying to reflect here.  Its silly and probably unlikely, its just a matter of obscure case correctness (Im fine with a swift_fatal as well in that case.

Greg, are you okay with that on Darwin? That's 90% the behavior we have today, except by accident.

Alternately we could special-case the Darwin case to point to a single static NULL pointer somewhere in memory, which is a valid non-null environment.

@jrose-apple Im almost certain that Linux has the same problem (environ itself may be NULL, only &environ - _NSGetEnviron is guaranteed) as this is permissible by the standard (someone else can argue the case of whether this design choice is good or bad).

It depends which "the standard" you're talking about. It's not permitted by POSIX, as cited above.

@jrose-apple ooh, did I misread/misremember something?  Which citation are you referring to?

See citations in https://github.com/apple/swift/pull/13254#discussion_r155301957.

I guess that doesn't preclude assigning to environ.

@jrose-apple @gparker42 also, POSIX.1 was supposed to have a clearenv but that never made it in.  POSIX.9 does require it for Fortran though.  clearenv will actually reset environ to NULL.

Oh yuck. Well, maybe we eventually need to handle this, then. For now, though, please don't change the public interface.


fix motion justified text

This PR is attempting to resolve #2135.
While this fixes the motion text within the client this breaks the pdf export of justified text completely. When investigating this I was not able to find a way to manually add line breaks within justified text in pdfmake.
For that reason it is possible that the issue is not fixable.

The following results in a text with a line break after sure. This might be helpful for a workaround.
text: [
		'Another paragraph, this time a little bit longer to make sure\t\t\t\t\t\t\t\t\t\t\t\t\t\t\t\t\t\t\t\t\t\t\t\t\t\t\t\t\t\t\t\t\t\t\t\t\t\t\t\t\t\t\t\t\t\t\t\t\t\t\t\t\t\t\t\t\t\t\t\t\t\t\t\t\t\t\t\t\t\t\t\t\t\t\t\t\t\t\t\t\t\t\t\t',
		'Another paragraph, this time a little bit longer to make sure, this line will be divided into at least two lines',
]


Update SDK to support both int/string lifetime_in_seconds [CLI-155]

Currently lifetime_in_seconds is already int. There are older tenants though in string.
We'll need to fix this on the SDK level.

Tracking in card CLI-155.

SDK PR: https://github.com/go-auth0/auth0/pull/213


Backports

This is failing with etcd problems which I think are likely resolved by a re-write of our etcd support which I wouldn't want to backport. Instead we smile and nod.


edit custom lore

Hello plugin's author, I suggest that users should be able to customize food lore, in the true sense of the word, because currently food lore only allows users to translate or modify it slightly, not to customize it extensively.
For example like

anyway, currently some players are complaining about not being able to stack food together because they are cooked at a very short interval of time, if it was a few hours or a few hours then I wouldn't say anything, but this is only a few seconds.

Hello and thank you for opening this issue.
I think the proposal is important in terms of customization and that it is necessary to add more customization to the plugin.
I'll add this enhancement for 1.0
Your player complaints will be dealt with in ticket #21.
I won't be restarting development until September 1, due to my vacation as you can see, but I hope 1.0 will solve your problems and improve your players' experience on the server.
Thank you for your patience.

Hello !
About your players' complaints, here's a solution to follow that solves the problem
https://github.com/The-Zandrax/NoMoreCooked/issues/21#issuecomment-2329446056
Keep me informed, have a nice day !

Version 0.1 of NoMoreCooked has been released on Spigot with the custom stage feature.
This is a first version that doesn't yet implement all the features I'd like to enable with this mode, but I'm waiting to get some feedback before going any further on these implementations.
Here's the current configuration for the various stages :

Even when using the stage, the items still could not be stacked.
I thought it was probably because the expiration date values recorded in the NBT(?) were different.
To work around this, I thought that one way would be to tie the expiration date of the item to the UUID and store it in a DB such as SQLite.

I think I've misunderstood the gist of the problem, when you say that it doesn't stack, are you talking about food with a different expiry date or different stage or are you talking about food that would have been cooked at a different time and whose stage or expiry date is the same ?

As I understand it, the essence of this problem is that the inventory will be overflowing with food groups with different expiration dates.
Ultimately, it would be best if foods with different expiration dates could be stacked. Then, the lore of the food would display the one with the shortest expiration date, and when the food is consumed, it will be consumed from the one with the shortest expiration date.
However, if this process is not devised to be done as much as possible on the player side, the server may be overloaded when the number of foods increases.

So I understood the problem, which is why expiration dates are now rounded to the hour above the set time so that they can be stacked.
In fact, two foods with different expiry dates will not be stacked. Firstly, for the item's lore and secondly, for the persistent data it contains.
If we wanted to be able to stack as many foods with different expiry dates as we wanted, we'd have to store additional information on the different dates in the persistent data. This isn't impossible, but it's a method that would require a lot of modification.
And I won't be able to guarantee performance to the same extent, especially if players decide to spam the grouping and ungrouping of items.
Let's imagine we move to a system where expiration dates are different for a group of items, which can be stacked together, and we store the data in the persistent data. If a player decides to separate the stack, he'll have to modify the persistent data at every moment, re-calculate the expiration date and modify the lore.
And if he right-clicks with a stack with multiple expiry dates, on a slot that already contains another stack with multiple expiry dates, a lot of data will have to be calculated and modified at the same time, and if the clicks are quick, this will cause problems if the information update takes longer than the time between two quick clicks by the player.
So while I can see the appeal of the feature, I doubt it's going to be interesting in terms of performance and potential bugs.


Publish 8.0-20221228191444+0000

Publish 8.0-20221228191444+0000

@bot-gradle test and merge

I've triggered a build for you.