TypeScript snippets in VS

Moving this over from CodePlex (23 votes, assigned to jonturner, http://typescript.codeplex.com/workitem/938):
I would really like to be able to use a TypeScript version of the JavaScript code snippets when writing TypeScript in Visual Studio.

Add TS language to Code Snippets Manager, please!

12 more votes for TS Code Snippets!!!!
I am repping my colleagues :)

An auto curry interface generator would be nice too:
http://stackoverflow.com/questions/28566969/create-programmable-snippet-for-visual-studio-with-node-js-code

Can we expect this to be in 1.5 tools?

@vilic this looks like something we would add for 1.6, most of the work is probably in the creation of the snippet files (inc. translation, setup etc.).

Good to know, thanks! @paulvanbrenk

I hope the new snippets are a bit radical - along the lines of @danquirk's suggestion:

Personally I don't think snippets should be in their own menu with a long, awkward key chord to invoke. There's no reason they can't be treated like any other completion result as many other languages/editors do.

I should just be able to start typing my-custom-snippet anywhere on a code file, and the snippet should be rendered at the point of the cursor upon selection.

@NoelAbrahams unfortunately we (TypeScript) don't control that part of the snippet experience without a lot of customization (for my-custom-snippet), it will work that way for inbox-snippets. I will bring this up with the team that is responsible for the overall snippet experience, and you can add that as an item on http://visualstudio.uservoice.com.

+1

region snippet missing in Visual Studio 2015 :'(

Some others I'd like to see that aren't mentioned yet
forof -> for(let el of elements) { ... }
forr -> for(let i = length-1; i >= 0; i--) { ... }
```

can we make this happen? As in, all of it?

This is a real problem, from your team but also from VS Team. Why snippets need to be activated or whatever other limitation. Code snippet should always be accessible for all language supported by VS... From C#, I never write a complete for or property accessor...even javascript have a better support on Visual Studio!
Sublime already have snippets for Typescript and from to long time Typescript run better on sublime...

+1 It would be really nice to have this feature. I was going to create my own snippet for TS and then realized that it's not possible.

+1

+1

+1 - how is this not already there, seriously?

if anyone has time please consider implementing and sharing a working example of this:

https://msdn.microsoft.com/en-us/library/ff926100.aspx

Actually you'll want to reference the Roslyn implementation[0].. since that'll solve you a bunch of time.
[0] https://github.com/dotnet/roslyn/blob/a4e375b95953e471660e9686a46893c97db70b0e/src/VisualStudio/CSharp/Impl/Snippets/CSharpSnippetInfoService.cs

+1

Man, I just assumed this would be supported in the latest version of Visual Studio 2015, and found this while starting to create some Angular 2 snippets. I can't believe this is something that VSCode handles perfectly, but the flagship product can't...

Which project do we need to post on to make this a feature in Visual studio 2015?

Which project do we need to post on to make this a feature in Visual studio 2015?

you are in the right place.

sorry, is this something that is going to be incorporated into Visual Studio 2015 soon?

It is on the list of committed features. I do not have an ETA at the time being. there are other features/bugs that we are working on as well, and we are a small team.

Can the community help in any way?

Can the community help in any way?

Unfortunately no. this is part of the VS plugin code that is not open source at the moment.

Just adding typescript in the list of languages supported by the built in snippet engine would allow the community,  or companies to define the snippets themselves.  Not created by MS, but usable by anyone.

Yep, totaly agree with that!! I've already make custom ones for JS and C# and it will take me 1h to get the most used like if,for's,get,set,class,namespace...
It's a huge lost of time to write a complete and boring for-i !!
Unlock it on VS or give the way to add a language.

I actually already added typescript snippets to side waffle, I'm just waiting for the typescript team to finish their piece.

On Jun 4, 2016, at 1:53 AM, Ákos Lukács<EMAIL_ADDRESS>wrote:
Just adding typescript in the list of languages supported by the built in snippet engine would allow the community, or companies to define the snippets themselves.  Not created by MS, but usable by anyone.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

+1

+1

Thank you all for the suggestions.
So far, here's the list of snippets that are being added to VS:

alert
cl: console.log
class
do: do while
else
for
forin
forr
function
if
iife : (function(x) { })();
switch
try
while
with

Please, let me know if you have further suggestions.

Omar,
It’s more the ability to “create new” snippets that is the real rub.  The community has a ton of snippets ready to go (me included).  Any idea of when that will be available?
From: Omar Mefire<EMAIL_ADDRESS>Reply-To: Microsoft/TypeScript<EMAIL_ADDRESS>Date: Monday, June 6, 2016 at 12:43 PM
To: Microsoft/TypeScript<EMAIL_ADDRESS>Cc: Matt Kruczek<EMAIL_ADDRESS>Comment<EMAIL_ADDRESS>Subject: Re: [Microsoft/TypeScript] TypeScript snippets in VS (#312)
Thank you all for the suggestions.
So far, here's the list of snippets that are being added to VS:
alert
cl: console.log
class
do: do while
else
for
forin
forr
function
if
iife : (function(x) { })();
switch
try
while
with
Please, let me know if you have further suggestions.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

Yes, included with these changes, will also be the ability to add custom snippets.

Omar,
IIFE on typescript feels kind of strange with namespaces and modul
systems...
But the main news is that ts snippets are coming to VS, thanks!
On 6 Jun 2016 18:43, "Omar Mefire"<EMAIL_ADDRESS>wrote:

Thank you all for the suggestions.
So far, here's the list of snippets that are being added to VS:

alert
cl: console.log
class
do: do while
else
for
forin
forr
function
if
iife : (function(x) { })();
switch
try
while
with

Please, let me know if you have further suggestions.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/Microsoft/TypeScript/issues/312#issuecomment-224015667,
or mute the thread
https://github.com/notifications/unsubscribe/AAziKx16sMlvjWqliU4myNWrw7I1UPQ5ks5qJE4hgaJpZM4CSceb
.

@omefire

Please, let me know if you have further suggestions.

I would say ctor to create a constructor for the containing class, which is quite handy snippet in C#

@omefire
consider allowing javascript or c# expressions in the scripts placeholders so that they are not just dumb templates but capable of some transformations

@aleksey-bykov we will consider that, but not for the initial release... the snippet infrastructure in VS doesn't allow that, and we don't want to delay this feature further ;). Do you have an example where that would be useful.

here is an example of regex transformations  https://manual.macromates.com/en/snippets

@aleksey-bykov I was looking for a TypeScript specific example what is a case where you would use this?

@paulvanbrenk, as far as see it snippets are language agnostic, because they just generate output text (that happened to be a piece of code) based on some input text or lack of thereof
back to your question, in my pet project in TypeScript I use the following snippet a lot:
export type SomeSingletonKind = 'some-singleton-kind';
export const someSingletonKind : SomeSingletonKind = 'some-singleton-kind';

Example: https://github.com/aleksey-bykov/commandlining/blob/master/failing.ts
export type UnexpectedCharacter = 'unexpected-character';
export const unexpectedCharacter: UnexpectedCharacter = 'unexpected-character';

export type UnhandledState = 'unhandled-state';
export const unhandledState: UnhandledState = 'unhandled-state';

export type UnspecifiedParameterName = 'unspecified-parameter-name';
export const unspecifiedParameter: UnspecifiedParameterName = 'unspecified-parameter-name';

export type UnfinishedArgument = 'unfinished-argument';
export const unfinishedArgument: UnfinishedArgument = 'unfinished-argument';

export type UnspecifiedArgument = 'unspecified-argument';
export const unspecifiedArgument: UnspecifiedArgument = 'unspecified-argument';

export type UnspecifiedCommand = 'unspecified-command';
export const unspecifiedCommand: UnspecifiedCommand = 'unspecified-command';

export type UnexpectedEndOfInput = 'unexpected-end-of-input';
export const unexpectedEndOfInput: UnexpectedEndOfInput = 'unexpected-end-of-input';

export type UnspecifiedCommandOrParameter = 'unspecified-command-or-parameter';
export const unspecifiedCommandOrParameter: UnspecifiedCommandOrParameter = 'unspecified-command-or-parameter';

export type UnattendedCharacter = 'unattended-character';
export const unattendedCharacter: UnattendedCharacter = 'unattended-character';

export type UnexpectedCommand = 'unexpected-command';
export const unexpectedCommand: UnexpectedCommand = 'unexpected-command';

export type UnexpectedBuilderState = 'unexpected-builder-state';
export const unexpectedBuilderState: UnexpectedBuilderState = 'unexpected-builder-state';

export type UnexpectedParameterName = 'unexpected-parameter-name';
export const unexpectedParameterName: UnexpectedParameterName = 'unexpected-parameter-name';

export type ErrorCode = UnhandledState | UnspecifiedParameterName | UnfinishedArgument
    | UnspecifiedArgument | UnexpectedCharacter | UnattendedCharacter
    | UnexpectedEndOfInput | UnspecifiedCommand | UnspecifiedCommandOrParameter
    | UnexpectedCommand | UnexpectedBuilderState | UnexpectedParameterName;

As you can see the spellings of type-literal, type-alias-name and constant-identifier are all different: Pascal, Dashed, Camel
It means I cannot use snippets based solely on templates, because I need to apply a transformation to get the case I need. This is where I wish snippets had transformations.

i desperately need these for TypeScript: https://visualstudiogallery.msdn.microsoft.com/5d11e28f-0f7c-4f6e-ae50-699fcd5a3500
would save me a LOTTA of time

for those who can't wait anymore, VS Code can do TypeScript very well and it has snippets

Snippets will be part of VS "15" post Preview 4.
For smarter snippets I opened: #10309

I installed Microsoft Visual Studio Enterprise 15 Preview 4, but I don't see any options to insert snippet.
Tried with:

Edit -> InstalliSense -> Insert snippet (doesn't exist)

Ctrl + k, Ctrl + x

Right click -> Insert Snippet

In Tools -> Code Snippets Manager I don't see TypeScript in Language drop down.
How can I insert snippet?

@MaklaCof Snippets for TypeScript is not available in Preview 4, but will be in the next release.

Then someone should fix Milestone to avoid confusion.

@paulvanbrenk, as you mentioned "Snippets will be part of VS "15" post Preview 4."
what about VS 2015?


BUG: linkedinbot is no longer running, need to fix and refactor entire code to make it easier to maintain

done


model_name as an additional optional parameter for azure open ai client.

Presentation of the new feature
The Azure OpenAI documentation explains that model instances have two properties: deployment_name and model_name. While model_name refers to the well-known OpenAI models (e.g., GPT-4, GPT-3.5-turbo), deployment_name specifies a specific instance within an Azure tenant. There can be cases where these names differ, such as deploying multiple versions of the same model. If these names do not match, the code may attempt to select a tokenizer based on the deployment_name and fail. Allowing model_name to be passed as an optional parameter would enable the correct selection of the tokenizer, avoiding errors.
Where does it fit in Outlines?
Since Azure OpenAI is already integrated, fixing this costs nothing.
Are you willing to open a PR?
Yes I will, it takes like 20 ASCII characters max to fix this while being backwards compatible.

Perfect, thanks Rémi


Change "a href" to "an href"

Description
We are using both "an href attribute" and "a href attribute" in the challenge instructions.
I guess both are correct as they depend on how we pronounce the "H" ("aich-ref" vs "haich-ref"), but since we write "an HTML element", I think we would want to be consistent and use "an href attribute".
Changes needed

Change all "a href" instances to "an href"
While we're at this, change "a HTML" to "an HTML" in https://github.com/freeCodeCamp/freeCodeCamp/blob/main/curriculum/challenges/english/01-responsive-web-design/basic-css/override-styles-in-subsequent-css.md

"An href" and "an HTML" seem more commonly used. I'm new to contributing so I would love to work on this issue!

I vote for "an href"
it sounds more natural to me

Hello @jdwilkin4 and @huyenltnguyen, if I understand correctly, in this pull request,  you both need to change "a href" to   "an href" and "a html" to "an html".

Has anyone fixed this issue, I can't see any pull request for this.

Hi @mercy-manynge, I'm currently working on it. I'll raise the pull request within the next hour.

hello, @mercy-manynge I will rise the pull request for this

Hi @Lalithkumarponnambalam, it's great to hear that.


Yamlcreate.ps1 throws exception: "Join-Path : A positional parameter cannot be found that accepts argument"

Brief description of your issue
Ran the YamlCreate.ps1 script from directly from the tools directory results in invalid argument exception when the tool goes to build manifest due to a package id folder not existing
Steps to reproduce
Run YamlCreate.ps1 directly from the tools directory.  Below are the specified values I entered:
Id: skylot.jadx
Version: 1.1.0
Name: jadx
Publisher: skylot
License: Apache License 2.0
LicenseUrl: https://github.com/skylot/jadx/blob/master/LICENSE
AppMoniker: jadx
Tags: Java, Dex, android, APK
Description: Command line and GUI tools to produce Java source code from Android Dex and APK files
Homepage: https://github.com/skylot/jadx
Arch: Neutral
Url: https://github.com/skylot/jadx/releases/download/v1.1.0/jadx-gui-1.1.0-no-jre.exe
Sha256: D2D8FBB71BAEC7FFE99633231397DFF419AB12D09C18171E75DAE6D994C79984
InstallerType: exe
Expected behavior
YamlCreate.ps1 doesn't throw an exception and creates manifest in a package id folder
Actual behavior
Exception is thrown during script execution:
Join-Path : A positional parameter cannot be found that accepts argument 'System.Object[]'.
At C:\repos\winget-pkgs\Tools\YamlCreate.ps1:247 char:21
+     $FileLocation = Join-Path "\" "manifests" $id.Split('.')[0..1]
+                     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : InvalidArgument: (:) [Join-Path], ParameterBindingException
    + FullyQualifiedErrorId : PositionalParameterNotFound,Microsoft.PowerShell.Commands.JoinPathCommand

Environment
Windows 10 2004 OS Build 19041.450
[winget --info]
Windows: Windows.Desktop v10.0.19041.450
Package: Microsoft.DesktopAppInstaller v1.10.42101.0

I have tried to reproduce the issue but I am unable to do so. I did however use PowerShell Core 7. I did also use x86 as the arch.

@philnach are you able to reproduce the issue?
If so, which version of PowerShell/Terminal are you using?

@denelon, I'll attach the PowerShell execution transcript for you later today.

@denelon , I tried with x86 as well, still the same failure.  Attached is the PowerShell transcript
YamlCreateTranscript.log

@denelon, I think I figured it out.
I'm on PowerShell 5.1 and in PowerShell 6.0 "-AdditionalChildPath" was added which let's you append multiple paths together StackOverflow suggestion.  We could fix the line by doing the following:
$FileLocation = Join-Path "" -ChildPath "manifests" | Join-Path -ChildPath $id.Split('.')[0] | Join-Path -ChildPath $id.Split('.')[1]
I'm more than happy to create a PR, unless you think we should require a minimum of PowerShell 6 for running the script?

@philnach as long as this isn't going to be a breaking change for other versions of PowerShell, I'm fine with supporting multiple earlier versions.

@denelon, perfect, I'll get the change coded up and verify PowerShell 5.1, 6.0 and 7.  Probably send out a PR tomorrow (8/21).

@philnach If you're going to submit a PR please don't submit a fix that looks like this
$FileLocation = Join-Path "" -ChildPath "manifests" | Join-Path -ChildPath $id.Split('.')[0] | Join-Path -ChildPath $id.Split('.')[1]

That code that is hard to maintain and does not follow PowerShell best practices. It probably makes sense to add a minimum version requirement to the script. This can be done by beginning the YamlCreate.ps1 script with the line:
#Requires -Version 5.1

You can then use PSScriptAnalyzer to tell you about incompatible version specific features.

@megamorf, thanks for the feedback, I'm not an expert when it comes to PowerShell, it would be awesome if you could fix the script to work with PowerShell 5.1?  I had something slightly different, but it's good you brought up that it doesn't follow best practice.


Add Additional Install Instructions to the README

I recently set up a new computer and came to this repository to get the latest version of quill.  I had trouble with the installation that required me to get assistance from @chmllr.  The solution was relatively simple and I thought it might be helpful to document it in the README.md file.
I first attempted to Build the quill file using rustup as well as Nix according to the instructions.  In both cases I ran into errors even though I installed the latest version of both rustup and Nix for this purpose.  I didn't troubleshoot further since I assumed I could just copy/paste the binary.
I am running the Ubuntu distribution of Linux on Windows with WSL2.  Hence, I downloaded the quill-linux-x86_64 binary from the release link in the Download section.  Once on my computer, I changed the filename to simply quill and moved it into the Ubuntu\home\<user>\bin folder, which is where the dfx binary is also installed.  After closing the terminal and opening a new terminal, I tried running the quill --version command and received an error (see image below).  This is where I got stuck and needed to reach out to Christian.  He immediately recognized that I needed to run the chmod +x ./quill command in order to change the permissions assigned to the file by default.  At my current level of developer experience, I would not have figured this out on my own.  Hence, it would be nice if this instruction could be provided in the Download section of the README file.

Fixed in #149.


RangeCheck gadget - two-limbs input mode - or Matthew's optimised approach

[ ] Add “2-limbs input mode” using coeff
[ ] Add a bunch of tests for the new mode

This was created against the wrong repo.  Closing in order to open one in proof-systems -> #900


Analytics - error tracking and print intent - don't run on load

As the JS for these two analytics 'plugins' will often be bundled by default, they shouldn't run automatically. This is because they might not have been loaded after the main Tracker file.
So instead, they should be run explicitly from the code in the analytics 'init' file, after the Tracker has been set up. See the docs for details and example.

Looks good to me. (Diff best viewed with ?w=1 in the URL)
@edds do you have any thoughts?


Update dependencies for testing and development

requirements.txt has the exact version numbers for dependencies used in both local development and tests run on CircleCI. We should update the version numbers to their latest according to PyPI.
Changes needed:

In requirements.txt, update the version numbers of all the listed packages to their latest according to PyPI.
Add a new entry in CHANGELOG.md.
(In the unfortunate though hopefully unlikely event that the builds on CircleCI fail in your pull request due to the version updates, please tag @jacksonllee.)

Guidelines for contributors

Closed by #239


Package as TPKX

Is there any document or specification on building archive of TPKX from folder of compact cache v2 .bundle tiles ?

The TPK/TPKX is simply a zip archive of the compact cache.
Assuming you've created your bundle/bundlx files, you should have (mostly) what you need to create a TPKX.  You will need to create the Conf.xml and Conf.cdi, which I don't think ESRI has defined on the github.  However, I think the format is pretty simple, and you can mostly recreate it by looking at examples you can generate using ArcMap.
I'm not sure how TPKX differs, but TPK files required that the archive be set to "STORE".  Any sort of compression with the zip would prevent ArcGIS runtime from opening the archive.  There is also a folder structure you will need to follow.
The easiest way to see what Im talking about is to create a TPK or TPKX from ArcMap.  Open the TPK using 7Zip, and observe the structure.  If you follow the folder structure, and provide a valid Conf.xml/cdi, along with your bundles, you should have a valid TPK/TPKX file.
I've successfully created TPK files which can be opened by ArcGIS Runtime anyway.

You can use the Tile package specification available at https://github.com/Esri/tile-package-spec.
The details of conf.xml and conf.cdi files will be available shortly

@gari0000 Just a question: Is there a reason the Compact Cache v1 and TPK format isn't also released?

@GuidedByCthulhu  Compact Cache V1 format does not perform well when consuming caches over network file shares and Blobstores, hence we at Esri recommend using "Compact V2" which address these issues.

@gari0000 I understand the reasoning for developing the new format.  I was asking why the older formats were also not released as well.  Many people would be interested in official documentation about the CCv1 and TPK formats, if just to validate their reverse engineered solutions.
Many clients move slowly, and won't be moving to the CCv2/TPKX format for some time (governments, 3rd party legacy mapping tools, etc).
Heck, having the CCv1/TPK format opened would be wonderful for the GDAL, as they could possibly add support for the older format, so people wouldn't need to immediately update to 10.7.

Unfortunately we would not be able to open the specification for TPK format.
However, we would recommend using the following geoprocessing tools to achieve backward compatibility and create compactV1 cache and tpk files:

Convert Map Cache Storage Format
Export Tile Cache tool
Export Map Server Cache Tool

The specification of conf.xml and conf.cdi is now available at https://github.com/Esri/raster-tiles-compactcache/blob/master/CompactCacheV2.md


Preview

Can I pull request

@googlebot I signed it!
[image: Mailtrack]
https://mailtrack.io?utm_source=gmail&utm_medium=signature&utm_campaign=signaturevirality5&
Sender
notified by
Mailtrack
https://mailtrack.io?utm_source=gmail&utm_medium=signature&utm_campaign=signaturevirality5&
03/10/19,
13:33:08
On Thu, Oct 3, 2019 at 1:25 PM googlebot<EMAIL_ADDRESS>wrote:

Thanks for your pull request. It looks like this may be your first
contribution to a Google open source project (if not, look below for help).
Before we can look at your pull request, you'll need to sign a Contributor
License Agreement (CLA).
📝 Please visit https://cla.developers.google.com/
https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here with @googlebot
I signed it! and we'll verify it.
What to do if you already signed the CLA Individual signers

It's possible we don't have your GitHub username or you're using a
different email address on your commit. Check your existing CLA data
https://cla.developers.google.com/clas and verify that your email is
set on your git commits
https://help.github.com/articles/setting-your-email-in-git/.

Corporate signers

Your company has a Point of Contact who decides which employees are
authorized to participate. Ask your POC to be added to the group of
authorized contributors. If you don't know who your Point of Contact is,
direct the Google project maintainer to go/cla#troubleshoot (Public
version https://opensource.google.com/docs/cla/#troubleshoot).
The email used to register you as an authorized contributor must be
the email used for the Git commit. Check your existing CLA data
https://cla.developers.google.com/clas and verify that your email is
set on your git commits
https://help.github.com/articles/setting-your-email-in-git/.
The email used to register you as an authorized contributor must
also be attached to your GitHub account
https://github.com/settings/emails.

ℹ Googlers: Go here
https://goto.google.com/prinfo/https%3A%2F%2Fgithub.com%2Factions-on-google%2Factions-on-google-nodejs%2Fpull%2F361
for more info.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/actions-on-google/actions-on-google-nodejs/pull/361?email_source=notifications&email_token=AJHAO2W7NA2TMVZJPIBVQKLQMWQO5A5CNFSM4I47VYDKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEAHKW2A#issuecomment-537832296,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AJHAO2T2JPTJ4DFP3SPIV43QMWQO5ANCNFSM4I47VYDA
.

--
K ChinnapaReddy

https://www.linkedin.com/in/chinnapareddy-kanakanti-053ab812a/*

I don't see what files you've changed.


Bad interaction between tabs when using localStorage

If I have two tabs open at the login screen (logged out) and try to login I end up being logged out again immediately.
The cause is that when the user logs into the first tab the localstorage events are fired in the second tab which then fires a sessionDataUpdated event. At https://github.com/simplabs/ember-simple-auth/blob/master/packages/ember-simple-auth/lib/simple-auth/session.js#L321 the content included with the sessionDataUpdated event is checked for a 'secure' property which is never present. Because it isn't present ember-simple-auth clears the session which causes the first tab to go through the same process, it checks for the secure 'property' and because it isn't there also clears the session.
I couldn't work out where the secure property was supposed to be set. What's the expected lifecycle here?

I cannot reproduce this. Can you setup an example repo maybe?

I had the same issue and it turned out I was not passing data through in my authenticator restore() method promise resolution.

I always have this problem.
Whenever there are 2 tabs opened of the same app, if I try to login in one tab, I instantly get logged out.
I am passing data in my restore method.

@tehmaestro: please provide sample code that illustrates the problem or, even better, set u a JSBin.

I'll try and make one.

Any updates on this?

I was seeing this too locally using the devise authenticator. I was passing back authentication_token instead of token from my rails api. When ember simple auth tried to synchronize the tabs it looked for token in the session and could not find it. Therefore it logged me out of both tabs. When I started passing token instead of authentication_token it worked perfectly.

@marcoow it looks like this is a bug in op-firebase-auth (which provides an authenticator for firebase). The problem seems to be that firebase doesn't update it's logged in status in other tabs until after authenticator.restore is called (due to the localStorage key being updated), https://github.com/tbarho/op-firebase-auth/blob/master/addon/authenticators/firebase.js#L12. It's probably best to close this issue and I'll open a new one on that repo.

@opsb: not sure how firebase works but if this is actually an issue in the other repo this one should be closed.

@marcoow I've confirmed the issue is on the op-firebase-auth project, so I'll close this one.


Port kafka consumer v4.1.3 to 7.48.x (#15985)

What does this PR do?
Port kafka consumer release v4.1.3 to 7.48.x
Motivation
https://github.com/DataDog/integrations-core/pull/15960
Additional Notes

Review checklist (to be filled by reviewers)

[ ] Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
[ ] Changelog entries must be created for modifications to shipped code
[ ] Add the qa/skip-qa label if the PR doesn't need to be tested during QA.

License header validation failure expected in this scenario. Details here. Merge overriding this failure

Included in https://github.com/DataDog/integrations-core/pull/15988


Mobile text area scaling bug

When a user is on mobile, the text input areas do not scale to fit text (should be minimum one line if not text on area)

This issue only occurs when there is text saved within a section and the page is reloaded.


Add missing casts.

Essentially all of these are the void* variety.

None of these are necessary in C since void* can be coerced to any pointer type.  Are you building libuv as a C++ project?

Yes, I happen to be, and you're right they're not necessary for C, but basically the project is C++ clean otherwise.  Also, a fairly large number of places in libuv already have similar casts, so this improves consistency across the project.  Plus, I think it's good C coding style (admittedly that's personal opinion).

a fairly large number of places in libuv already have similar casts

If you mean in src/win, they're remnants of when Visual Studio used to complain if you didn't put them in (really because it treated C as if it was C++ minus a few keywords.)
I'll leave this PR open so other collaborators can chime in but I personally don't see it happening, it's not idiomatic C.

If we don't need it, I'd say -1 to avoid the git history churn.

I'm not sure what you mean by "git history churn"?  Isn't the whole point of git to track history and changes?  It makes a change, yes, but I'm not seeing that it will cause increased long term churn of multiple changes.  Once the cast is there, it should be fine essentially forever.  The reason I upstreamed this PR is that without it merged, it makes tracking upstream changes much more difficult than it needs to be (due to merge conflicts) when the code is so close to compiling cleanly with C++ anyway.
I noticed that I rolled some const changes in here too (e.g. strchr returns a const char*).  Is that something that would be considered for merging even if the void* casts aren't?

e.g. strchr returns a const char*

It doesn't, it returns a mutable pointer. :-)
If you're referring to uv__basename_r(), I think that's an acceptable change.

I'm not sure what you mean by "git history churn"?

Sorry, I just meant that it makes tools like git blame a little less useful for what seems like no gain.

If you're referring to uv__basename_r(), I think that's an acceptable change.

@PeterJohnson Do you want to follow up on this or should we close this out?

No follow up. Closing for now.


Increase the usability with parameter aliases

AzureAD commands use the -ObjectId parameter.
Microsoft Graph PowerShell commands use the specific parameter names like -UserId, -GroupId...
Add parameter aliases when it's appropriate, so that users can run:
Get-EntraUser -ObjectId ...
Get-EntraUser -UserId ...
Get-EntraApplication -ObjectId ...
Get--EntraApplication -ApplicationId ...

@alexandair Thanks for raising the issue, We are looking into it.

@alexandair: We're close to finalizing work on this issue and wanted to give you a heads-up for early feedback. You can expect to see a lot of PRs coming in for this.

@alexandair: I’d like to close this issue as the main work is complete. We’ll raise PRs for any edge cases or missed commands as needed.

Sure, go ahead.


The demo segfaults on iOS 15

Hi,
I was checking SolidScroll out to, but unfortunately, when running on Xcode 13.2 and iOS 15.2, it crashed when I ran the demo in the simulator. Is this way unsupported in iOS 15?

It is supported, please provide more details about the issue you're facing - the call stack of the crash, and model of the device of the simulator.


docs: Add DMA, SSR and FREP usage in the tutorial

Addressed in https://github.com/pulp-platform/snitch_cluster/pull/196.


update columns for get

Includes both standard and changes for -o wide
@sushmarchandran includes change to metric name as we discussed
@fabolive includes changes to experiment yaml we discussed

Fixes issues https://github.com/iter8-tools/iter8/pull/247 and https://github.com/iter8-tools/docs/issues/170


input-date-range: await updateComplete for opened test

I'll rerun several times to make sure this is helping
1st failure was d2l-dropdown-content mobile-right-tray-no-close (off by 1 px)
2nd failure was d2l-dropdown-content bottom-right (dropdown looked to be slightly off in position)

I've run 3 times in a row without the opened test flaking. I'll run again.


Added SetJsLinkCustomizations site and list fields

Added a Field extension method to add jsLink to field.
Added a List extension method to add jsLink to list fields (takes a field name and calls the previous method)
This is very useful for client side rendering templates, where you want to be able to jsLink your csr template to a field rather than to a web part, enabling the csr javascript to run on multiple views.

Will make pull request for dev.


how to generate "WITH SET" and "WITH MEMBER"by olap4j

Hi,I recently use olap4j to generate mdx query, but I don't know how to generate "WITH SET" and "WITH MEMBER" in my program. could you give me some suggests to solve this problem?  Furthermore, I want to know if olap4j 2.0 has support this way to generate query schema.

You can do that in 1.X using something like this:
final SelectNode selectNode = new SelectNode();
final List withList = selectNode.getWithList();
withList.add(new WithMemberNode(...));
withList.add(new WithSetNode(...));


Added option to add icon to buttons

Added an option to add icon to buttons

To be clear on how to implement it (only using Fontawesome at this time in the core):
<NavigationBar leftButton{{ icon: 'angle-left', iconSize: 22}}/>


Disable Camera2 for first release

Sadly there are still many unresolved issues in Camera2. To not delay the release we'll turn off Camera2 implementation and will bring it back in future versions. API and design for supporting different Camera implementations remain untouched.

Done

waiting for the very first release


pull base images (from) before building

Currently I did not manage to build an image from a base image when the base image is not available locally and the private registry requires authentication.
For example building my.registry.com/example:latest from my.registry.com/dependant:latest.
The problem is that the BuildMojo is not adding the authConfig to the request. I tried adding it but to no effect on the docker daemon side. Thus now the "from" image is being pulled before the actual image is being build.
After that I had the problem, that during pull the "registry" parameter was not being honored by the docker daemon, prefixing the image name with the registry name works however.

Thanks for the pull request !
You are right, a base image should be pulled if the option autoPull is enabled. This is currently not supported. Your solution to unconditionally pull the base image when doing the build is a  bit to much, though. I'll open an issue for this.
The registry handling however has been improved quite a bit alread, although not yet released. You can try out 0.11.0-SNAPSHOT (which is available in Maven central), which already includes the private registry support as documented in the manual. I would be curious, whether this works for you, so that we could tune it before the release.

Sounds good, i'll give it a try.

I ran into 2 problems:

PushMojo does not use docker.registry or imageConfig.registry for building the authConfig, thus the push failes
autoPull doesn't seem to be true by default also it is documented that way

Also I think the global registry could get problematic when the "from" image is in a different registry, maybe something like the following is needed.
<from>
   <name></name>
   <registry></registry>
</from>


What directory does Paleofetch install under?

I think it's ~/bin/paleofetch, am I right or wrong?
Thanks in advance.

depends how you install it.

1st: Thanks for the reply in under a minute
2nd: If I wanted to read a file in the directory where the c file is running, could I just do
"example = fopen("~/example.txt","r")"?

idk much C, so google is your best bet. You should close this issue.

Ok, thanks.


Support Rails 7.1

Picked up from https://github.com/DatabaseCleaner/database_cleaner-active_record/pull/78 to get the CI passing.

@etagwerker Any chance we can get specs running and (assuming its green) get this merged?  And even more ideally, get it into a gem release?

@sebaherrera07 Thanks for taking a stab at this! I decided to go with this solution: https://github.com/DatabaseCleaner/database_cleaner-active_record/pull/78


Audit exceptions to see what issues are currently triggering exceptions and pager duty alerts

Problem statement
We don't know all of the issues that are currently triggering exceptions and pager duty alerts
What you need to know
Last 30 days
Acceptance criteria

[ ] List of known issues that have triggered exceptions and/or pager duty alerts
[ ] Identify (with input from Tech Lead) which issues should trigger exceptions, which should not trigger exceptions, and how to add more clarity to the exception when it is triggered for faster disposition
[ ] Work with Chris and Victor to identify next steps on follow-on work

Query to group exceptions in last 30 days
exceptions
// additional filters can be applied here
| where client_Type == "Browser"
| where timestamp > ago(30d)
| summarize Count=count() by type, tostring(customDimensions), client_Browser
| order by Count
| project Count, type, client_Browser, customDimensions

https://cdc.sharepoint.com/:x:/r/teams/USDSatCDC/_layouts/15/Doc.aspx?sourcedoc=%7B282E6448-4489-4E72-8892-87D0FDE4E6BE%7D&file=Top_Exceptions_Last_30_Days.csv&action=default&mobileredirect=true


clang-13 not getting upgraded?

so 5.10 (and mainline) are failing for arm32 allnoconfig:
https://github.com/ClangBuiltLinux/continuous-integration2/runs/1996403133?check_suite_focus=true
This looks like https://github.com/ClangBuiltLinux/linux/issues/1296 which has been fixed for a few days.
CI1 had a check for the clang version being too old (older than 5 days). I think we need to port that check to CI2.

The log says:
{
        "version_full": "Debian clang version 13.0.0-++20210223111116+16ede0956cb1-1~exp1~20210223101845.3803"
}

So 2021-02-21. https://reviews.llvm.org/rG1e204ac78952cf7e4fcf335423e80007388d3979 was merged 2 days later, today is 2021-02-28.
I've created https://github.com/ClangBuiltLinux/linux/wiki/Debian-Ubuntu-packages quickly; it looks like a few of the llvm-binaries builds are red for a couple days.

Yeah, this is now fixed. I was on holidays and some changes (run-clang-tidy renamed) was breaking the CI


updating doc and example for _accordion.scss and _tooltip.scss

updating example for _accordion.scss
adding doc for _tooltip.scss

per issue #3838

Hi @leoz0610  -- could you respond to the review comments above? Thanks!

Hi @leoz0610 - thank you for this PR.
I am going to close it, as we have / will be updating these components as part of our accessibility updates.  The documentation will be updated/checked over as part of #6482 .
Thanks again!


Signature fix - GeneralBytes

This may address the issue

This was found not to resolve the issue.

This PR did not solve the issue.  Closing.


Update examples to ansible 2.0

Hello!,
I found your repo super useful, but now we are using ansible 2.0 and some of the examples that are written here are no longer valid.
Would be useful to have them updated to 2.0 version.
Regards,

that's a great idea, I had totally forgotten about this repo

See https://github.com/locationlabs/ansible-action-plugins/pull/2 and https://github.com/locationlabs/ansible-action-plugins/pull/3 . CC: @sginn (not really my place to be merging things into Location Labs repos any more)

Or just remove this repo to avoid confusion


Not all email notifications are being triggered

Description
Not all email notifications are being triggered when specific actions are made. Notifications related to document transitions (e.g., curator notified when reviewers conclude review) is very important. These will be especially important soon as we have several ATBDs that will potentially be moving between stages. We want to ensure that the curator doesn't cause any user delays, but also ensure authors/reviewers are aware of where the documents stand. For now, the curator can check the dashboard daily and send author/reviewers email if needed.
Spreadsheet - This sheet shows the higher priority notifications that need to be fixed/implemented.
**Tasks:

[ ] determine why these specific notifications aren't working
[ ] implement fix
[ ] test to ensure these are working after the fix

Acceptance Criteria

[ ] The 6 highlighted notifications are working on production and have been tested

Sorry to hear that @bwbaker1. @thenav56, could you look into this when you get the chance?

Hi @bwbaker1, if you see this before our meeting today, could you give a few more details? Which user noticed this (and email address), and for which actions? Or is this list from internal testing?
@thenav56 tested this locally and didn't find anything wrong with the notification code itself. The issue is either coming from AWS or that the user's email domain is blocking the email. We had similar issues with SNWG for the latter reason.
We currently don't have deny_publication_request implemented on the frontend (i.e., that's not an action that authors can currently take, so we'll need to implement that in the frontend before that email is triggered.

@wrynearson This is the document that first caught my attention ([Chlorophyll a) (Guoqing Wang - guoqing.wang@nasa.gov). I didn't receive a notification when the author requested review. She reached out to me via email.
Then Camille and I tested internally (bwbaker1 -<EMAIL_ADDRESS>and cw0045 - cw0045@alumni.uah.edu). We tested all of the listed actions above and neither of us received notifications. We checked spam mailboxes as well.

OK thanks @bwbaker1, this is good to know. I'll chat with the team to look into this.

@bwbaker1 Do you have the approximate time for those actions? That would help us filter the logs.
@wrynearson since this is on production, we will need @naomatheus's help to look for the logs.

Hi @bwbaker1, we think that the email issues are related to AWS Simple Email Service (SES) account permissions. According to the documentation, SES accounts are first placed in a "sandbox" which applies restrictions.  The number of emails that can be sent per 24h is limited to 200, which could be an issue in the future.
Most likely, the current issue is that emails can only be sent to and from verified email addresses. Is it possible that Guoqing's email is not verified in the system? If hers is verified, the issue could be that our email sending service isn't verified.
I'd suggest that someone at IMPACT requests to move your Amazon SES account out of the sandbox by following these instructions.

@wrynearson I double-checked and Guoqing's email is verified.
@xhagrg @michaelsfoley  See comment. Is this something that either of you can help with? Or can you direct me to who could help?

We should also check that the sender email identity is verified. We had a similar issue on SNWG  that @xhagrg helped us fix by verifying the sender email address on SES

@xhagrg @bwbaker1 is there anything else we need to do on this ticket?

@wrynearson I think this is done, but let us do some testing over the next few days. Will close if everything is working properly.

@wrynearson I'm now aware that two notifications are not being triggered from users. 1. When document review is requested and 2. When document publication is requested.

@thenav56 would you have the chance to look into this?
@bwbaker1 I want to flag that on staging, your account is both a contributor and a curator. If you were testing there with your account, that could explain why you weren't receiving some emails, but I'm not sure how both roles would interfere with each other in regards to email notifications.

@wrynearson This is happening on production. A user requested a document be published, and I didn't receive anything. She sent me an email several days later asking to publish she. She also said that she did not get a notification when she made the request.

@bwbaker1 I would recommend that we find time to have DevSeed sync with you to be able to see the production logs, as we're having a difficult time debugging email notifications. There are many potential reasons for emails not being delivered, so we should first see if there's anything blocking us sending the emails in the first place.

@wrynearson Sure. Let me know some day/times that works for you all and I will pick a time.


added chatbot for enhanced user experience

What does this PR do?

Fixes #33

https://github.com/user-attachments/assets/5722d4a1-6a48-49a2-857d-707759c29f08
Type of change

Bug fix (non-breaking change which fixes an issue)
Chore (refactoring code, technical debt, workflow improvements)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update

How should this be tested?

[ ] Test A
[ ] Test B

Mandatory Tasks

[x] Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

@GauravKesh
https://github.com/user-attachments/assets/c8e887fc-6a80-460c-8f3d-3264993cbc0a
Currently, the chatbot is trained solely on the content available from your repository. If you’d like to enhance the chatbot's responses with more detailed and dynamic information, hosting the website and providing the production link would allow me to train it further using the live content. This will ensure the chatbot is up-to-date and aligned with the full scope of your website's offerings.


drop support for Java 6

since we can no longer securely publish from Java 6, and it's probably
time anyway
references: https://github.com/scala/sbt-scala-module/issues/41
also add CoC, NOTICE

oh hi Dan!

Hi Seth!


feat: trigger client release 2nd try

:tada: This PR is included in version 1.10.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


mavlink: 2015.7.7-0 in 'hydro/distribution.yaml' [bloom]

Increasing version of package(s) in repository mavlink to 2015.7.7-0:

upstream repository: https://github.com/mavlink/mavlink.git
release repository: https://github.com/mavlink/mavlink-gbp-release.git
distro file: hydro/distribution.yaml
bloom version: 0.5.20
previous version for package: 2015.6.12-0

Trying to retrigger Travis with closing and reopening the PR.


feat: fire events on failed sync

I think we need better monitoring of core parts of our system. If syncs fail we need to quickly be notified and check our electrs service, or reach out to users who may be unable to sync for whatever other reason and provide as much help as we can.

is there anything else that we can do? what does the user then need to do? restart?

is there anything else that we can do? what does the user then need to do? restart?
If it's a temporary issue on startup (e.g. they run Alby Hub locally and have a bad internet connection) then yes, they can just try again.

If it fails consistently though or for multiple users, it would be a good indicator there is something wrong on our side that we need to look into.


Modals on results page don't return focus to triggering button on close

Area or Component
Result page - actions menu for each result
Also on the person page with the "archive person" modal
Quick Summary
The keyboard focus doesn't return to the triggering button when a modal is closed for most of the actions on the result page (print result, text result, etc)
Accessibility Violation
Modal is closed, focus is not returned to trigger: https://cdc-devtools.dequecloud.com/rule-help/en/focus-modal-not-returned
Action Requested
Return keyboard focus to the triggering element instead of to the <body>.
Original Deque Issue
https://docs.google.com/spreadsheets/d/1b6xjubAN5Uw11DV4_B5zvSu7HeDI6Z-DpV4DMcToqAY/edit#gid=1978534823&range=7:7

Is it enough to return focus to the actions button (the three dots)

or should the focus be returned to the specific button (like print results)?

@BobanL ideally we'd return focus to the specific button, like print results.


performance problem when using @quasar/typescript

Since I added @quasar/typescript for using typescript in my project, my debug is quite slow, some time for quasar dev I should wait around 10 minutes, furthermore, after running when I save my changes I have to wait at least 30 seconds to see my changes.

because I'm working on a project with a limited deadline, it is an acute problem for me

Same in @quasar/typescript

Since I added @quasar/typescript for using typescript in my project, my debug is quite slow, some time for quasar dev I should wait around 10 minutes, furthermore, after running when I save my changes I have to wait at least 30 seconds to see my changes.

because I'm working on a project with a limited deadline, it is an acute problem for me

After a research i found a solution for fast dev build with @quasar/typescript :
https://github.com/IlCallo/quasar-typescript-starter/blob/master/quasar.conf.js
It is not necessary to create a quasar.conf.ts nevertheless you need too optimized your tsconfig.json file

@quasar/typescript is soon to be deprecated. Please upgrade your Quasar dependencies and use the embedded support --> https://quasar.dev/quasar-cli/cli-documentation/supporting-ts


Disable test 'can read previous version's cache'

This test is currently broken as a current version of stacker cannot read an old version's cache.  The change was intended, to clean up /stacker under c68147cba8d.

What type of PR is this?

Which issue does this PR fix:
What does this PR do / Why do we need it:
If an issue # is not available please add repro steps and logs showing the issue:
Testing done on this change:

Automation added to e2e:

Will this break upgrades or downgrades?
Does this PR introduce any user-facing change?:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

We will re-enable this test with: https://github.com/project-stacker/stacker/pull/484

Merging is blocked
The base branch requires all commits to be signed. Learn more about signing commits.


Revisions not working: getting React error

Link to reproduction
private repo
Describe the Bug
Opening the revisions page produces a React error in any collection with revisions activated.
Example:
http://localhost:3000/admin/globals/site/versions/6568de9ae04b3fc4b44c739c
React error:
Objects are not valid as a React child (found: object with keys {de, en, fr, it}). If you meant to render a collection of children, use an array instead.
From the error message an object with translation data is added to the JSX tree. After that the SPA is broken i.e. back navigation fails. We can reproduce it on our development and production systems. We tried to get more details but the React developer tools show no info in this case.
To Reproduce
Open revisions detail page. Getting blank screen with error in JavaScript console.
Payload Version
2.3.1
Adapters and Plugins
db-mongodb, bundler-webpack, live-preview

I guess Payload expects a string and does not support translations.

Full stack trace:
main.aa84253b4ab011b8cd39.js:63 Error: Minified React error #31; visit https://reactjs.org/docs/error-decoder.html?invariant=31&args[]=object%20with%20keys%20%7Bde%2C%20en%2C%20fr%2C%20it%7D for the full message or use the non-minified dev environment for full errors and additional helpful warnings.
    at aJ (main.aa84253b4ab011b8cd39.js:63:54264)
    at l (main.aa84253b4ab011b8cd39.js:63:59257)
    at il (main.aa84253b4ab011b8cd39.js:63:71124)
    at u (main.aa84253b4ab011b8cd39.js:63:121237)
    at lR (main.aa84253b4ab011b8cd39.js:63:99083)
    at main.aa84253b4ab011b8cd39.js:63:98950
    at lz (main.aa84253b4ab011b8cd39.js:63:98957)
    at lO (main.aa84253b4ab011b8cd39.js:63:95709)
    at lS (main.aa84253b4ab011b8cd39.js:63:96098)
    at r3 (main.aa84253b4ab011b8cd39.js:63:44823)

I tried to find the component but it's hard to find any details in the minified code.

@JessChowdhury it's part of a large company project. Is there a way to activate the React debug mode? This would allow us to check which component is failing.
I will try to deactivate some translated texts. Probably once it will run without error.

@cbratschi it would be great if you could follow the issue guide. That would allow us (and you) to pinpoint what is causing the issue for you. It is recommended that you try to isolate your issue when creating a reproduction. This means adding as few fields as possible to the reproduction to recreate the issue. Thanks!

Found the root cause: in Payload config I am using:
    //i18n
    localization: {
        defaultLocale: defaultLanguage,

        locales: languages.map(item => {
            return {
                code: item.lang,
                label: item.labels
            };
        }),

        fallback: true
    },

It works as soon as localization.locales is a string array:
locales: ['de', 'en'],

The label value must be the issue. It gets passed to React as is without filtering the active language.


Reboot tenant buttons in AdminUI

After a investigate dependencies of OpenIdSettings on Microsoft.AspNetCore.Builder.JwtBearerOptions and AspNet.Security.OAuth.Validation.OAuthValidationOptions @sebastienros saw there is no other alternative to restart the tenant if we want changes on those settings take effect.
How a user not always can restart the server we need to provide a button for restarting it. That button will be only available to users with an specific permission.

I would add a method to ShellDescriptorManager that allows to restart a tenant without the need of enable or disable a module. Like this https://github.com/OrchardCMS/Orchard2/pull/553/commits/849d3bafa6501b2144d4cade54f15cdd28ce9a8f
The question is where do you think should be added the code (view, controller, ...) for that button? In the Orchard.Environment.Shell project or in an extra module?

I don't think there is any method to add anywhere. Use IOrchardHost.ReloadShellContext() and pass the ShellSettings that is resolved from DI.
Next request will reload the tenant.

As I commented, we know have a way to restart the site when a setting changes. We just need to warn the user on the screens that will do it.


ci: run tests in Chrome to test WASM platform support

Description
It would be very helpful if we add some E2E/platform-specific workflow to check WASM support using Chrome.
References
https://github.com/agnivade/wasmbrowsertest

We can use chromedp here, pretty trivial


flir camera captures falling objects

Sorry, I saw this tutorial on the webpage of https://coral.ai/projects/teachable-sorter/. After running the sorter.py program, I encountered some problems TypeError: is_good_photo() missing 1 required every time I value the line. positional argument:'sliding_wind ow' such an error, the camera model I use is flir's BFS-U3-04S2C-CS USB 3.1.
The following is my main program Spinnaker.py
123.zip

@87878877 what arguments did you passed into it? The error message states that you are missing an argument, the expected arguments are defined here as img, width, height, mean, sliding_window

@ 87878877您傳遞了哪些參數？錯誤消息指出您缺少參數，此處將預期參數定義為img，寬度，高度，均值，sliding_window

The values I returned are img, width, height, mean, sliding_window, but cmd tells me NameError: name'img' is not defined when I execute it, is there any solution?

The error is: Name Error: name 'img' is not defined
That means you haven't initialed a variable calls 'img' yet.


shrink max_bytes

Congrats with a round review number! :) 💯

The idea is to 'predict' the next batch size when shrinking
In some cases, MaxMessageBytes in history might still be too big for regular messages.
e.g. few 10M messages appear every once in a while in a regularly 1K message stream.
The subscriber may starve while waiting for the consumer to fetch such a big batch.
(unless the prefetch count is large enough)
Regarding

add a clause for maybe_shrink_max_bytes which does nothing if max_bytes == max_bytes_orig
This would imply that the avg_bytes is only calculated in the message set right after a successful expansion, which would over estimate the average value.

This is also to allow a really small max_bytes in config, and slowly adjust to a 'smart' number to fetch a predictable number of messages in each request.
But we need to also respect a large max_bytes in config (not to shrink to a lower value)


Network access: Restrict clients allowed to make remote calls to SAM

Please update this document to indicate that the Azure AD connect on-prem connector service account must have permission to make remote calls to SAM for password writeback to be successful.  That Group policy is called "Network access: Restrict clients allowed to make remote calls to SAM" and can be found at "Policies\Windows Settings\Security Settings\Local Policies\Security Options\Other"

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 115ae83a-95dd-5643-bc88-f5447ebb2b99
Version Independent ID: 7462ce84-0a9f-4bfd-7eba-c00928d77865
Content: Enable Azure Active Directory password writeback
Content Source: articles/active-directory/authentication/tutorial-enable-sspr-writeback.md
Service: active-directory
Sub-service: authentication
GitHub Login: @iainfoulds
Microsoft Alias: iainfou

@jafrittsMSFT  Thanks for the feedback. We will engage the content development team for further investigation, they will verify and perform necessary changes in the document as needed.
@iainfoulds   Can you have a look at this ?


Updated Polish translation

Please make sure these boxes are checked before submitting your pull request - thanks!

[x] Run the unit tests with gradlew app:connectedGmsDebugAndroidTest to make sure you didn't break anything (with an emulator running or phone connected)

[x] If you have multiple commits please combine them into one commit by squashing them.

Hi,
I've improved the Polish translation.

Thank you so much! Feel free to credit yourself in the Polish help file for the translations.


Support Composite Primary Keys gem

Makes RailsAdmin compatible with Composite Primary Keys. The compatibility logic is implemented within a newly-created adapter as much as possible, so it doesn't affect existing implementation much.

Coverage decreased (-2.02%) to 94.012% when pulling 74a5a78dc98ffe5c8c1641df680e5087a3fdc04c on composite-primary-keys into 974c54a2a3372690ca189f6e7e90ce365bcd4ff5 on master.

Let me merge this in!


Change wget to curl in setup-test.sh?

On my MacOS X system wget is not available. But curl is. Thus setup-test.sh works with:
curl -OL https://github.com/strongloop/express/archive/3.18.1.tar.gz

AFAIK curl is more commonly available than wget in *nix distributions. Maybe it makes sense switching to curl. However, I am not too familiar with all that command line stuff...

curl -OL works too. I've been blissfully mac-free for most of this year so I didn't notice :)


rm install_cuda_compatible_cmath

I'm working reenable cuda tests in vision.
It will be splitted to multiple simple and clear PRs.
This PR is only to remove obsolete step install_cuda_compatible_cmake

@malfet @NicolasHug @seemethere ,
could you take a look at this PR?
Only 3 MACOS workflow failed now. I think it's nothing with this PR.
It'd better to be merged soon to avoid merging conflicts with my following PR to enable CUDA tests.

I can confirm the macos failures are unrelated.
@seemethere I'll let you approve this one, since you introduced these changes in https://github.com/pytorch/vision/pull/3609 it seems
@mszhanyi It looks like we could remove the entire .circleci/scripts directory, would you mind pushing a commit with the removal? Thanks!


feat: default values for schema fields

Describe your changes

default values can now be set for schema fields as in this example
No more automatically inserting a primary key

How best to test these changes

Unit tests

Issue ticket number and link
TIG-810

Codecov Report
Base: 90.79% // Head: 91.79% // Increases project coverage by +0.99% :tada:

Coverage data is based on head (2b30f24) compared to base (789f459).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #203      +/-   ##
==========================================
+ Coverage   90.79%   91.79%   +0.99%
==========================================
  Files          24       19       -5
  Lines        4260     4169      -91
  Branches      509      499      -10
==========================================
- Hits         3868     3827      -41
+ Misses        385      340      -45
+ Partials        7        2       -5

Impacted Files
Coverage Δ

src/db.ts
90.59% <100.00%> (ø)

src/decorators/tigris-field.ts
96.12% <100.00%> (+1.33%)
:arrow_up:

src/schema/decorated-schema-processor.ts
100.00% <100.00%> (ø)

src/tigris.ts
65.09% <100.00%> (ø)

src/types.ts
92.83% <100.00%> (+0.19%)
:arrow_up:

src/utility.ts
93.00% <100.00%> (-0.83%)
:arrow_down:

src/decorators/options/embedded-field-options.ts

src/decorators/metadata/primary-key-metadata.ts

src/decorators/metadata/collection-metadata.ts

... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Body part logic missing

Still can't filter tags by body part attachment.
This may be unnecessary and would need me to rewrite the gen() function to accommodate it.

This is not important.
Will reconsider in the future.


uncatched wallet functionality errors

send nonexistingassetid {address} {amount}
throws an uncatched AttributeError.
The wallet can actually do more than is currently described in the readme and I'll update that once the current pull request is worked in.

This should now be resolved.


python3.pkgs.watchfiles: fix sandbox darwin build

Description of changes
This package relies on the FSEvents API and needs access to it in its tests. By default, this is not allowed in a sandboxed build on macOS.
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[x] aarch64-darwin

[x] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

@ofborg build python310Packages.watchfiles python310Packages.watchfiles.passthru.tests


[Other] Prep for release

Summary
Resolves #124.
The purpose of this PR is to prepare the recorder for release. The most notable reason, as noted in #124, is to unify the updated Play/Pause/Restart flow with the new header we recently merged.
We should also look for any glaring UX/export issues. The recorder is in a transitional UI state, but there is a lot of improved functionality we would like to release in the meantime until the UI re-vamp is complete.
Implementation details
Most notable is the move from the original start/end buttons to the header.
How to validate this change
Try starting/pausing/stopping journey recording to make sure the recorder is working.

:grey_exclamation: Build Aborted

There is a new build on-going so the previous on-going builds have been aborted.

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

Reason: Aborted from #2

Start Time: 2021-12-20T19:40:59.861+0000

Duration: 6 min 56 sec

Commit: 1b8771c416a70fe4736fbf5d21895fca82f9ef88

Test stats :test_tube:

Test
Results

Failed
0

Passed
52

Skipped
0

Total
52

:robot: GitHub comments
To re-run your PR in the CI, just comment with:

/test : Re-trigger the build.


Add await as future reserved keyword

await is (similar to enum which is already part of esutils) a future reserved keyword in ES6
http://www.ecma-international.org/ecma-262/6.0/#sec-future-reserved-words
This came up in https://github.com/babel/babel/issues/4198 and babel is using esutils to get the reserved keywords.

Friendly push :)
@michaelficarra

friendly ping again :) would love to see this merged

await is only treated as a FutureReservedWord when Module is the goal symbol of the syntactic grammar.

var await is a valid Script. Having this function say that await is unconditionally a FutureReservedWord would be wrong. We could possibly add another parameter, moduleIsTheGoalSymbol/isModule.


⚠ Bofrost.at has degraded performance

In da9c977, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1005 ms

Resolved: Bofrost.at performance has improved in 8e7567c after 7 minutes.


Error: No mbedtls_ms_time available (IDFGH-11632)

Answers checklist.

[X] I have read the documentation ESP-IDF Programming Guide and the issue is not addressed there.
[X] I have updated my IDF branch (master or release) to the latest version and checked that the issue is present there.
[X] I have searched the issue tracker for a similar issue and not found a similar issue.

IDF version.
v5.1.1-577-g6b1f40b9bf
Operating System used.
macOS
How did you build your project?
Command line with idf.py
If you are using Windows, please specify command line type.
None
What is the expected behavior?
Build correctly
What is the actual behavior?
Build failed on C Object
[49/1166] Building C object esp-idf/mbedtls/mbedtls/library/CMakeFiles/mbedcrypto.dir/platform_util.c.objFAILED: esp-idf/mbedtls/mbedtls/library/CMakeFiles/mbedcrypto.dir/platform_util.c.obj
Steps to reproduce.
Installing ESP-Matter on main, ESP-IDF on v5.1.1-577-g6b1f40b9bf
Build or installation Logs.
[5/1285] Generating ../../partition_table/partition-table.bin
Partition table binary generated.

More Information.
No response

Only happening after switching IDF Version, not on new project.

I have it enabled and still same error!

Hello @Tim4497,
Could you share a small reproducible code and the sdkconfig that you have used?
I was unable to reproduce the above error with the following minimal code:
#include <stdio.h>
#include "mbedtls/platform_time.h"
#include "esp_log.h"

void app_main(void)
{
    mbedtls_ms_time_t current = mbedtls_ms_time();
    mbedtls_ms_time_t elapsed_ms;

    elapsed_ms = mbedtls_ms_time() - current;
    ESP_LOGE("", "%llu", elapsed_ms);
}

with the config CONFIG_MBEDTLS_HAVE_TIME being enabled or disabled.

Closing due to lack of response, feel free to reopen if you are still facing the problem


kvm: upgrade libvirt-java to v0.5.3

Reference: https://gitlab.com/libvirt/libvirt-java/-/issues/6
Types of changes

[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] New feature (non-breaking change which adds functionality)
[ ] Bug fix (non-breaking change which fixes an issue)
[x] Enhancement (improves an existing feature and functionality)
[ ] Cleanup (Code refactoring and cleanup, that may add test cases)

Minor nit - jar is at https://libvirt.org/maven2/org/libvirt/libvirt/ but not sync'd yet on https://mvnrepository.com/artifact/org.libvirt/libvirt

@blueorangutan package

UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6472 (SL-JID-1780)

Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 3600

@GabrielBrascher not necessary, if the upstream project publishes their own repo, we can add it in pom.xml.

@blueorangutan test

Trillian test result (tid-4344)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 37111 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6472-t4344-kvm-centos7.zip
Smoke tests completed. 98 look OK, 0 have errors
Only failed tests results shown below:

Test
Result
Time (s)
Test File


Are we CUDA yet?

What do you think about creating a simple website with similar to Are we async yet?, Are we learning yet? and many others?
It could serve as an overview of our progress on the roadmap, and a central place to store links to blogs and announcements.

Well... for what it's worth, I registered arewegpgpuyet.com a while back. Meant to set up a site behind it but never did.

Sounds good!

@bheisler if you don't mind, that would be very helpful!
We could keep it as overall GPGPU overview, and mention that CUDA currently has best (IIRC) Rust support so far and the only (once to become official) WG.
It also helps us to ensure the website is future-proof: information about other GPGPU platforms can be added later when it will be ready.

I'd be happy to point the DNS records for arewegpgpuyet.com at a server, but I doubt I'll get a chance to generate a website or set up a server to serve it any time soon.

FWIW if anyone's interested, there are some parallel efforts in the Rust graphics/game dev ecosystem for GPGPU through Vulkan/Metal/DirectX compute shaders. Projects like gfx-hal abstract over all of them to accept only SPIR-V, and there are other projects to compile OpenCL kernels (not a Rust project) and Rust to SPIR-V.
I'm not sure if this is useful or if there are opportunities for collaboration anywhere, but perhaps some of this would at least fit into some kind of category on a page like arewegpgpuyet :)

+1. An arewegpgpuyet website should be more general than just CUDA.

I enjoyed reading your blog about rust cuda interoperability issues:
https://bheisler.github.io/post/state-of-gpgpu-in-rust/
I totally agree with everything you mentioned.
I think c++'s thrust and arrayfire-rust are a very useful set of apis.
Apis that are lacking:

string indexing and searching(targetting text-based files)
byte array indexing and searching(targetting binary-based files)
working with prep work from 1., have search and replace within text files and/or memory.
working with prep work from 2., have search and replace within binary files and/or memory.

When I was looking at vulkano(rust binding for vulkan), I was surprised to not find any gpgpu string processing functions.  Ditto for opencl.  The cuda rapids nvstrings/nvcategory apis are the closest to this but still very low-level and less featureful than I would have expected considering the number of generations of gpus we have had with coined gpgpu terminology in existence for at least 10 years.

so among all projects so far, is there anything on a path towards being able to write rust code and be competitive with hand-optimized cuda c++, for an algorithm that depends on device intrinsics and shared memory and such? I'm concerned that the multi step compilation through spir-v may not expose the full capability of the CUDA toolkit, and I'm wondering what would need to be done to get a PTX target working again. it would be sweet if the same rust code that compiles to spir-v could compile to cuda.

Hi! Just wondering around the ever lasting topic of gpgpu in Rust.

and I'm wondering what would need to be done to get a PTX target working again.

Is it not that Rust PTX Linker solves this problem? I mean, generating .ptx files from Rust code (although Windows users still need to wait for now).
I understand that once you have the .ptx file, you can go ahead and do the integration with RustaCUDA, and that this is the "safest" and "default" way to use cuda in Rust, am I wrong?
Cheers!

Hi! Just wondering around the ever lasting topic of gpgpu in Rust.

and I'm wondering what would need to be done to get a PTX target working again.

Is it not that Rust PTX Linker solves this problem? I mean, generating .ptx files from Rust code (although Windows users still need to wait for now).
I understand that once you have the .ptx file, you can go ahead and do the integration with RustaCUDA, and that this is the "safest" and "default" way to use cuda in Rust, am I wrong?
Cheers!

i think the current status is that these two projects need work, but i've only had time to shop, not set up and try out:
https://github.com/denzp/rust-ptx-builder
https://github.com/termoshtt/accel

i think the current status is that these two projects need work, but i've only had time to shop, not set up and try out:
https://github.com/denzp/rust-ptx-builder
https://github.com/termoshtt/accel


kubeconfig for gateway APIServer

https://github.com/kubewharf/kubegateway/blob/main/docs/zh/quick_start.md
然后通过 kubectl 把它应用到 KubeGateway 的控制面去
kubectl --kubeconfig <path-to-kube-config> apply -f cluster-a.kubegateway.io.yaml
path-to-kube-config ?

Thanks for the feedback.
I will add a pre-configured kubeconfig for local testing only and add a section in doc to describe it.

@vsxen PR #11 adds a new way to quick start kubegateway environment on local，please refer to the doc https://github.com/kubewharf/kubegateway/blob/main/docs/zh/manually-setup.md
Thanks


expose log tags for clients to use

What was changed
Making the log tags public
Why?
I was copying and pasting these tags into my own projects because they correlate to very similar tags in our own logging libraries.  Exposing them might help us implement better loggers
Checklist

Is there a different way people would prefer this to be refactored/handled?

Closes

How was this tested:

Any docs updates needed?

HI @nknordeen, I don't think we would wan't to expose these tags as part of our public API we don't in any other SDK and could limit us in the future. If your using a logger supplied by the SDK then it should already have the relevant info set on it.

That's fair.  Thanks for the feedback!


Improve section of failed/pending statuses :test_tube:

Type of issue
Feature Request
Description
The current state isn't readable when there are many pending/failing checks. For example:
🔴 Failed or pending statuses - Testing Farm - RHEL9 - 1.20[pending],Testing Farm - RHEL8 - 1.22[pending],Testing Farm - RHEL9 - 1.22[pending],Testing Farm - RHEL9 - Unsubscribed host - 1.20[pending],Testing Farm - RHEL9 - Unsubscribed host - 1.22[pending],Testing Farm - RHEL8 - 1.22-micro[pending],Testing Farm - RHEL8 - 1.24[pending],Testing Farm - RHEL9 - 1.24[pending],Testing Farm - RHEL9 - Unsubscribed host - 1.24[pending],Testing Farm - CentOS Stream 10 - 1.26[pending],Testing Farm - Fedora - 1.26[pending]
Describe the solution you'd like
Possible solutions:
1)
🔴 Failed or pending statuses:
Testing Farm - RHEL9 - 1.20[pending]
Testing Farm - RHEL8 - 1.22[pending]
Testing Farm - RHEL9 - 1.22[pending]
Testing Farm - RHEL9 - Unsubscribed host - 1.20[pending]
Testing Farm - RHEL9 - Unsubscribed host - 1.22[pending]
Testing Farm - RHEL8 - 1.22-micro[pending]
Testing Farm - RHEL8 - 1.24[pending]
Testing Farm - RHEL9 - 1.24[pending]
Testing Farm - RHEL9 - Unsubscribed host - 1.24[pending]
Testing Farm - CentOS Stream 10 - 1.26[pending]
Testing Farm - Fedora - 1.26[pending]
2)
🔴 Failed or pending statuses - 11
Testing Farm - RHEL9 - 1.20[pending]
Testing Farm - RHEL8 - 1.22[pending]
Testing Farm - RHEL9 - 1.22[pending]
Testing Farm - RHEL9 - Unsubscribed host - 1.20[pending]
Testing Farm - RHEL9 - Unsubscribed host - 1.22[pending]
Testing Farm - RHEL8 - 1.22-micro[pending]
Testing Farm - RHEL8 - 1.24[pending]
Testing Farm - RHEL9 - 1.24[pending]
Testing Farm - RHEL9 - Unsubscribed host - 1.24[pending]
Testing Farm - CentOS Stream 10 - 1.26[pending]
Testing Farm - Fedora - 1.26[pending]

3)
🔴 Failed or pending statuses:
Testing Farm - RHEL9 - 1.20[pending]
Testing Farm - RHEL8 - 1.22[pending]
Testing Farm - RHEL9 - 1.22[pending]
show more
Testing Farm - RHEL9 - Unsubscribed host - 1.20[pending]
Testing Farm - RHEL9 - Unsubscribed host - 1.22[pending]
Testing Farm - RHEL8 - 1.22-micro[pending]
Testing Farm - RHEL8 - 1.24[pending]
Testing Farm - RHEL9 - 1.24[pending]
Testing Farm - RHEL9 - Unsubscribed host - 1.24[pending]
Testing Farm - CentOS Stream 10 - 1.26[pending]
Testing Farm - Fedora - 1.26[pending]

@phracek What would you prefer?


any difference with the textual version

In your code, I saw that you mainly employed the textual version framework. I wanted to know the mainly difference is that you only used single image to embed the style and the textual version method used 3~5 images?

In a sentence: our method can learn the text embedding from a single image in a faster, more accurate and better-generalized way without fine-tuning the generative model.
Thanks to Gal et al. who present a textual inversion baseline so that we can make further developments.
Firstly, they used optimization-based methods to directly optimize the text embedding of the concept, which requires a longer training time (See Figure 5 in our paper).
At the same time, the text embedding obtained by their method may be out of the manifold, resulting in an unsatisfying generalization of generated images (See Figure 6 in our paper).
Our inversion method is different in using a cross-attention-based network; during training, only the attention-related parameters are optimized, instead of the text embedding itself.
In this way, our method only needs one-tenth to one-fifth of the training iterations of them and is more robust to additional text descriptions, able to generate results that match both the additional textual descriptions and the reference image.
Therefore, our method achieves better performance in speed, accuracy and generalization.
In addition to a novel textual inversion approach, we also propose a stochastic inversion method that better preserves image semantics. An ablation study of this module can be found in our supplementary material.

Are all of the cross attention parameters trained or only the ones that are related to '[C]' trained? How can you make sure that after this finetuning, the stable diffusion model maintains the ability to generate images based on text prompts?

We use an external plug-and-play cross-attention module to learn the text embedding of the image, instead of fine-tuning the parameters of the stable diffusion model.

Thanks!

Hi, where can find the supplementary material?


Generate compile_commands.json by default

This is low overhead (it only affects the make-generation step, not the actual build) and makes developer tooling like clangd work much better, so we should have it on by default instead of off (which is CMake's default). If necessary, it can be disabled with
cmake -DCMAKE_EXPORT_COMPILE_COMMANDS=0 ...

or adding this to config.cmake
set(CMAKE_EXPORT_COMPILE_COMMANDS OFF)

cc @areusch

Yeah usually we need compile_commands.json by default, so I'm in favor of doing so. Not a cmake expert, just curious, is it better to put this in CMakeList.txt or config.cmake? What if TVM is used as a CMake submodule by other projects?

I think it's better in CMakeLists.txt since everyone will get it automatically rather than having to update any cmake configs they use, but the point about avoiding messing with parent projects is good. It looks like that can be detected so it can avoid setting anything in that case

Thank you @driazati for the explanation!!


Support for unified Integer class in Ruby 2.4+

Ruby 2.4 unifies Fixnum and Bignum into Integer: https://bugs.ruby-lang.org/issues/12005.
This PR is to remove the warnings related the the Fixnum usage in this gem.
This PR includes testing against multiple versions of Ruby. It seems that the specs are broken for Ruby 2+ so a new issue has been raised here and those tests have now been skipped.

@MiroslavCsonka any idea when this may get merged and a new gem released?

@iamliamnorton I just released 0.9.0. Let me know if anything goes wrong.
PS: Thanks for the PR


Add support function for router NavigationEnd event

Let's add an util function for catching whenever router navigation NavigationEnd event occur
e.g
export const routerNavigationEnd = () => {
  const router = inject(Router);

  return router.events.pipe(
    filter((event): event is NavigationEnd => event instanceof NavigationEnd)
  );
};

I am eager to add it if you would be interested with that one.

Hello @va-stefanek
Can you give some usecases please? They will be valuable when creating the docs for the util.

Hello @va-stefanek
Can you give some usecases please? They will be valuable when creating the docs for the util.

We found it valuable because we had multiple instances where we needed to react to the end of navigation, such as hiding banners, changing page titles, and more. We had multiple router injections and the same filter across the entire app.

@va-stefanek this makes sense. Do you have any proposal API of what the helper(s) should look like?

Honestly I am not sure, was thinking about something like that
import { Observable } from 'rxjs';
import { filter } from 'rxjs/operators';
import { NavigationEnd, Router, Event } from '@angular/router';

/**
 * Creates an Observable that emits when a navigation ends.
 * @returns An Observable of NavigationEnd events.
 */
export function routerNavigationEnd(): Observable<NavigationEnd> {
  const router = inject(Router);

  return router.events.pipe(
    filter((event: Event): event is NavigationEnd => event instanceof NavigationEnd)
  );
}

Additionaly like in some other helpers in the repo we can check whether it's in injection context and allow to pass 	injector?: Injector as parameter

I have a very common use-case in my projects -
When a user is being redirect to the /error route (ie “Something went wrong, please reload the page and try again”) (lets say the server went down, then after the navigation to the /error page it went back up)
We need to detect refresh event”in order to navigate him back to the root of the app.
this.router.events
   .pipe(filter((rs): rs is NavigationEnd => rs instanceof NavigationEnd))
   .subscribe(event => {
     if (
       event.id === 1 &&
       event.url === event.urlAfterRedirects
     ) {
         // the user made page refresh - do your logic here (ie navigate to root page to try again)
     }
   })

@nartc I like this! I think a PR would be welcome @tomer953 @va-stefanek (also having the optional injector just in case) 🙌

Ok so I will open an PR @eneajaho

@nartc  There's a small inconsistency regarding the filenames and operator names. the filename is navigation-end, while the operator name is injectNavigationEnd. This is inconsistent with inject-destroy, where the filename and the operator name are the same.
This naming discrepancy also causes an issue in the Astro docs sidebar. The two inject operators are separated due to the sidebar being autogenerated based on filenames.

@tomer953 I have been following resize. I agree that might be good to agreed some consistency in naming of files and utils.