Support installation via Bower

I already read the discussion in #579...
In this thread @gaearon said "I'm up for supporting Bower if there is enough interest in it." but if the thread is locked no one can express their interest.
"We won't put build products into Git repo. Otherwise every second new PR will contain changes to the built files, because people will keep doing this." Just do this: https://github.com/reactjs/react-bower
React/Flux does provide distribution via Bower, so it is bizarre to declare that "Using Bower is a bad idea" and leave it at that.
Ultimately I've had to spend the most time out of all of the dependencies in my project to include redux

In this thread @gaearon said "I'm up for supporting Bower if there is enough interest in it."

Yes, and later in that same thread I said

Using Bower is a bad idea. If you use Bower and want to fork the repo, please do it, but we won't support it. I explained above that it makes little sense with Redux's ecosystem because most of complementary packages are small and are all on NPM.

I've made a decision and won't change it, sorry.

"We won't put build products into Git repo. Otherwise every second new PR will contain changes to the built files, because people will keep doing this." Just do this: https://github.com/reactjs/react-bower

Do you honestly think maintaining an additional repo is free and takes no time?
Also, If I start maintaining Redux Bower package, people will expect me also to maintain Redux DevTools Bower package, React Redux, Redux Thunk, etc. Redux is not backed by a company, unlike React, and I don't have the horsepower to do what they do.

React/Flux does provide distribution via Bower, so it is bizarre to declare that "Using Bower is a bad idea" and leave it at that.

We are neither React nor Flux. This is not a Facebook repository. If Facebook chooses to maintain Bower packages for their repos, it's cool. But we won't.
And yes, we can claim that using Bower is a bad idea because it really is. It is your choice to ignore this and use an inferior tool, but then please feel free to create redux-bower and maintain the releases yourself. Contribute back!

Ultimately I've had to spend the most time out of all of the dependencies in my project to include redux

Here, let me help you:
bower install https://cdnjs.cloudflare.com/ajax/libs/redux/3.0.4/redux.js

Hi @gaearon, I'll be making a redux-bower repo when I have some time.  Hoping to get my hands dirty with rollupjs to produce a nice build.
Are you against using the cloudfare version as a starting point?

@cetra3
Please be careful about Rollup because we might later change build process in a way that isn't compatible with Rollup. See #611.
Yes, you can use the UMD build from Cloudfare. I'm not sure what exactly is the point of maintaining a Bower package if you can point Bower to a CDN url just fine.
Also, @mjackson recently made a thing called npmcdn.com, so you may also point Bower at<EMAIL_ADDRESS>

Ok, I'll keep that in mind about rollupjs.
The intention is to have a version which uses globals rather than depending on UMD, as this makes it a challenge to introduce it into some of the existing webapps we integrate for.  This is opposed to a library such as angular, which doesn't really depend on webpack/browserify so you can just drop it in anywhere.
Not sure if there's a webpack way of producing an iife/globals only version, as that would solve the problem!
As for using the URL, among other things it's not totally compatible with resolvers.  It's also much nicer to have proper tagged releases.

I might have not made this clear.
UMD is globals.
UMD is a module format that works by detecting the current environment and it supports both AMD, CommonJS and globals.
If you drop a UMD build in a browser as a script tag you'll end up with Redux global. However it will also work if you require it in an AMD or CommonJS project. That's why it's called a "universal" module definition.
Does this help?

Redux does not depend in any way on Webpack or Browserify. We say this in README. We recommend them but explicitly say you can use globals.
Is there some way we can make this more obvious? It would be a bummer if many people make the same mistaken assumption. :-( Please see the README:

This assumes that you’re using npm package manager with a module bundler like Webpack or Browserify to consume CommonJS modules.

If you don’t yet use npm or a modern module bundler, and would rather prefer a single-file UMD build that makes Redux available as a global object, you can grab a pre-built version from cdnjs. We don’t recommend this approach for any serious application, as most of the libraries complementary to Redux are only available on npm.

As for using the URL, among other things it's not totally compatible with resolvers.

Curiously the docs you linked to say custom resolvers can be used to install packages from NPM. Wouldn't that solve the problem in the first place?

@cetra3 I would strongly recommend against using bower. The project is not actually maintained by anyone and places an unnecessary burden on package authors.

@mjackson Neither of these things is true. Here's the Bower release history: https://github.com/bower/bower/blob/master/CHANGELOG.md
Many projects continue to recommend Bower for their distribution; for example Polymer (and WebComponent libraries in general): https://www.polymer-project.org/1.0/docs/start/getting-the-code.html
Further, it is currently not possible to use npm to install Polymer: http://stackoverflow.com/questions/31128784/can-i-install-polymer-1-0-with-npm
If you think you know better than the silly people that require support for this package manager, that's fine. Don't support it. But it's bizarre to discourage outside workarounds. @cetra3 I would be glad to see redux-bower

@klebba I'm getting my information directly from people who started and maintain the bower project. New feature development is effectively stopped and everyone who either started the project or built any major piece of it has effectively stepped away.
As for the burden that bower places on package authors, this very issue is evidence of that. I've experienced similar issues in every OSS project I've ever worked on, and I'm not the only one.
As for my part, I will do my best to use what influence I have to convince people to stop using bower until such time as I see they fix the issues with the project and develop a serious strategy for moving it forward. I refuse to support it on any of the rackt projects that I maintain and I encourage other rackt authors to do the same.
As it currently exists, bower is bad for the JavaScript ecosystem. Plain and simple.

@mjackson Do you have an alternative solution to offer for projects that depend on WebComponents such as Polymer elements? I'm not here in defense of Bower; it's just a tool that I must use. I couldn't care less if you use it.

We are not the ones making things difficult for you here. Polymer is.
Literally every other js library I know publishes to npm. It boggles the
mind that Polymer does not.
Why don't you make a polymer-npm repo? It will be at least as much work as
creating a redux-bower repo, and then you get to use npm and never have
this conversation with anyone ever again.
On Sun, Nov 8, 2015 at 12:57 PM Casey<EMAIL_ADDRESS>wrote:

@mjackson https://github.com/mjackson Do you have an alternative
solution to offer for projects that depend on WebComponents such as Polymer
elements https://elements.polymer-project.org/? I'm not here in defense
of Bower; it's just a tool that I must use. I couldn't care less if you use
it.
—
Reply to this email directly or view it on GitHub
https://github.com/rackt/redux/issues/944#issuecomment-154871380.

@gaearon The webapp has a lot of other frameworks loaded, and unless we tippy toe around them, we run into really strange errors, especially if the define global is continuously reimplemented.  It's something sort of out of my hands, as we're only changing a small part in a 5+ year old code base.
@mjackson I understand that bower is not welcome in some circles, and is quickly turning legacy.  But, we need a strong migration path if this is the case to allow devs to dip their feet in the water without having to make changes to their build infrastructure and tooling.  It means we can reduce the amount of changes necessary to start using it, if that makes sense.

The webapp has a lot of other frameworks loaded, and unless we tippy toe around them, we run into really strange errors, especially if the define global is continuously reimplemented. It's something sort of out of my hands, as we're only changing a small part in a 5+ year old code base.

UMD build should work just fine unless there's a global define or module variable. Of course, if there is, it will assume we're in AMD environment. If you have a global define which is not AMD, that's a problem with your setup. If you solve it, you'll be able to use UMD build.

But, we need a strong migration path if this is the case to allow devs to dip their feet in the water without having to make changes to their build infrastructure and tooling.

Add package.json
Put redux there
Grab node_modules/redux/dist/redux.min.js
Eventually start using npm for more dependencies

You don't have to stop using Bower to begin using npm. In fact that's how most project migrate—by using both for some time.

@gaearon in that scenario, how do we compile/minify our js assets to the one vendor.js file?  I can imagine it getting messy when you introduce thunk & react, having to explicitly include js files.

in that scenario, how do we compile/minify our js assets to the one vendor.js file? I can imagine it getting messy when you introduce thunk & react, having to explicitly include js files.

You can use UMD builds of React, Redux, ReactRedux. They all ship with NPM packages. Smaller packages like redux-thunk don't have UMD builds—for them, you need to either use a bundler or contribute a UMD build pull request to them. However, redux-thunk is a five-liner and unlikely to ever change, so you might as well copy it to your project. This should give you a good enough start.

@gaearon Thanks for the advice!
I'm wondering if there might be a good article that describes how to migrate from bower that can be linked somewhere.

There it is:
http://gofore.com/ohjelmistokehitys/stop-using-bower/

@mjackson Maybe you should check out WebComponents some time. Then you can let me know if you still think npm is the right tool for their distribution.
@gaearon I have no reason to keep this issue open any more; feel free to close it.

It's already closed. Nevertheless I'm grateful for your input and if you'd like to continue discussing what keeps you from adding npm to you workflow, I'm happy to. It might help others in the same situation.

Maybe you should check out WebComponents some time. Then you can let me know if you still think npm is the right tool for their distribution.

In my opinion this is not a great way to have a conversation. For example, I have an idea about web components, but I don't know at all why npm doesn't fit their model. In fact googling "web components npm" gives me plenty results both for the polyfills and the components themselves.
Don't forget npm is just a package manager. It's a thing that lets you host files. People saying it's just for JavaScript (and you can't put HTML, CSS, or whatever web components need there) are misleading you. It's not true.
Unless you enlighten us as to why npm is a poor fit for web components it's hard to continue the conversation.
Still, if you have specific concerns about NPM or using UMD builds we provide for the core projects, please write them up, and we'll try our best to figure out a solution to your case. But please don't assume we're just being unhelpful for the sake of doing this, or that we have an irrational hate for Bower. I used Bower in my own projects, and migrated to npm later. I'm not just hating on the tech I don't use. I want to help you stop using it because it's problematic software, for users and maintainers.

@gaearon Let me start by saying my intention here is not to start a discussion which will persuade you and others to change your opinion of Bower. I don't care if you use this tool, but I've already stated that I must at the moment. You seem to think that I should wise up and use npm. But npm is simply not a drop-in replacement for Bower in every scenario. The npm blog from 2014 outlines why in this article, under "Front-end pain points":
http://blog.npmjs.org/post/101775448305/npm-and-front-end-packaging
Bower's flat dependency list is an important design choice for projects built around WebComponents. How do you reproduce this behavior this with npm?

(npm@3 is flat by default)

The npm blog from 2014 outlines why in this article, under "Front-end pain points":

A year has passed since then. ;-)

Bower's flat dependency list is an important design choice for projects built around WebComponents. How do you reproduce this behavior this with npm?

NPM 3 has been stable for about a month now, and it also implements a flat dependency list. Unlike Bower, it is also able to handle version conflicts by nesting dependencies, but unless you have version conflicts between several dependencies, NPM 3 maintains a flat dependency list.

But npm is simply not a drop-in replacement for Bower in every scenario.

As said above, even if you have problems using NPM for all your dependencies, you can start using it for some projects. Like Redux.

Ok, that's great -- when the dependencies of my project cut over to npm I will gladly do the same. I can't combine npm and Bower dependencies; every package must be a sibling of the other packages in the project

bower install bower install<EMAIL_ADDRESS>works, so ...

You guys.  You should all quit using hammers because everyone is switching to screwdrivers.  So you should definitely use a screwdriver.  Plus I heard nobody is actively developing hammers now.

Everybody, thank you for your concern and the discussion.
At this point I think we've made our position clear and offered both good rationale for switching to npm 3 (Bower no longer being actively maintained, npm 3 having flat dependencies and superior conflict resolution), and a possible workaround (point Bower to npmcdn or cdnjs and use the UMD build).
Being snarky about it doesn't help anyone.
This is why I'm locking this thread.


feat: add a query to get own address via callee's get caller address …

…to dynamic_caller_contract
Description
This feature will be used in some integration tests.
Types of changes

[ ] Bug fix (changes which fixes an issue)
[x] New feature (changes which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] ETC (build, ci, docs, perf, refactor, style, test)

Checklist

[x] I followed the contributing guidelines.
[ ] I have updated the documentation accordingly. (not needed)
[ ] I have added tests to cover my changes. (not needed)
[x] The PR title and commits are followed conventional commit form.

Where are some integration tests?

https://github.com/Finschia/finschia/pull/219


[otbn] Make zero sized loops impossible to encode

As discussed in #3934 we'd like to alter the encoding of LOOP so a zero sized loop isn't possible. This will require some minor changes to the ISA yaml/documentation, ISS and RTL.
@rswarbrick will any changes be required to the RIG to support this?

estimate 4

No changes needed in the RIG (it doesn't yet support LOOP/LOOPI).


GSD Request

--- GSD JSON ---
{
  "vendor_name": "Linux",
  "product_name": "Kernel",
  "product_version": "versions from v5.13 to before v5.15.24",
  "vulnerability_type": "unspecified",
  "affected_component": "unspecified",
  "attack_vector": "unspecified",
  "impact": "unspecified",
  "credit": "",
  "references": [
    "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=eac2f3059e02382d91f8c887462083841d6ea2a3",
    "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=71f46f3d1bf29ee5b0a53dc21462125f754491dd"
  ],
  "extended_references": [
    {
      "type": "commit",
      "value": "eac2f3059e02382d91f8c887462083841d6ea2a3",
      "note": "introduced"
    },
    {
      "type": "commit",
      "value": "71f46f3d1bf29ee5b0a53dc21462125f754491dd",
      "note": "fixed"
    }
  ],
  "reporter": "joshbressers",
  "reporter_id": 1692786,
  "notes": "",
  "description": "riscv: eliminate unreliable __builtin_frame_address(1)\n\nThis is an automated ID intended to aid in discovery of potential security vulnerabilities. The actual impact and attack plausibility have not yet been proven.\nThis ID is fixed in Linux Kernel version v5.15.24 by commit 71f46f3d1bf29ee5b0a53dc21462125f754491dd, it was introduced in version v5.13 by commit eac2f3059e02382d91f8c887462083841d6ea2a3. For more details please see the references link."
}
--- GSD JSON ---

This issue has been assigned GSD-2022-1000421


Create fields for application model

New fields which are CompanyName, ContactNumber, Email and PositionApplied are created. They are properties in Application class. Relevant predicates and exceptions are also created.
Codes are duplicated instead of modified directly. Person and its fields are to be deleted later.

Codecov Report

Merging #53 (41f06ba) into master (d742f1a) will decrease coverage by 7.38%.
The diff coverage is 2.06%.

 Learn more


Add case for 'Pimple\Psr11\Container' in HP

Add case for new Pimple containerName in HomePageHandler

Hello @Ocramius @xtreamwayz,
I added a test case for the home-page response content (writing it made mw also aware of another skipped case, namely the auryn wrapper). I have an issue with test with deps=lowest on travis: zend-servicemanager minimum version is 3.3. In that version the AbstractPluginManager only accepts a Interop\Container\ContainerInterface and not a Psr\Container\ContainerInterface. Any hint for solving this?
The @dataProvider for the test cases is similar to the ones I found in other test files: i create combination for 2 different install type [flat, modular] x all the supported containers x all the supported renderers x 1 router option (FastRoute) only.
The minimal install type is not tested, as that information is added to json responses in my next PR.

@Ocramius @xtreamwayz
Ok, skipping the zend-view / non zend-sm combinations solved it.
I was wondering if we could just use php imports and class constants like it's done for the router and the renderer and even if it would be worth parametrizing (container|router|template)(Name|Docs) by turning the HomePageHandler.php file into as an install resource itself.

This repository has been closed and moved to mezzio/mezzio-skeleton; a new issue has been opened at https://github.com/mezzio/mezzio-skeleton/issues/4.

This repository has been moved to mezzio/mezzio-skeleton. If you feel that this patch is still relevant, please re-open against that repository, and reference this issue. To re-open, we suggest the following workflow:

Squash all commits in your branch (git rebase -i origin/{branch})
Make a note of all changed files (`git diff --name-only origin/{branch}...HEAD
Run the laminas/laminas-migration tool on the code.
Clone mezzio/mezzio-skeleton to another directory.
Copy the files from the second bullet point to the clone of mezzio/mezzio-skeleton.
In your clone of mezzio/mezzio-skeleton, commit the files, push to your fork, and open the new PR.
We will be providing tooling via laminas/laminas-migration soon to help  automate the process.


MinidumpStream::STREAM_TYPE should just be a u32

https://github.com/luser/rust-minidump/blob/2dc7ecc384f8ed123387cace30157c5288b6b5f3/minidump/src/minidump.rs#L103-L113
While it is technically correct that it "should" be a MINIDUMP_STREAM_TYPE, this prevents a user of minidump from implementing MinidumpStream for their own custom stream that we have no knowledge of. While this is not a usecase I have put any explicit effort into, it Just Works in our architecture.
This value is literally only coverted to a u32 in our codebase, and if you want the MINIDUMP_STREAM_TYPE it's trivial to convert back from a u32, so there's no advantage to keeping the stronger type safety.
Sentry is interested in doing this for one of their custom streams, although I also wouldn't oppose them upstreaming their impl into rust-minidump (we already support a bunch of Mozilla and Google extensions in-tree, and doing so allows minidump-processor and minidump-stackwalk to handle it). But maybe the flexibility is useful to them.

Yeah, that seems fine. The only nice thing about having the known values in an enum is preventing us from making a typo and accidentally including a duplicate value, but that's marginal at best.

Note that we should be able to write
const STREAM_TYPE: u32 = MINIDUMP_STREAM_TYPE::MY_STREAM as u32;
So we still get the primary advantages of using the enum in our code.

Just thinking out loud there. The motivation here is very sensible and I don't feel strongly about any part of the existing design. Even changing the whole thing from an enum to a list of const WHATEVER_STREAM: u32 = 123; would be totally fine. (Maybe in a mod known_streams or similar?)


Backport/rocko/secondaries and ci improvement

oe-selftest hasn't been executed yet

No need to backport a patch and then remove it. :) Also looks like 5ce9387025581813b3db3d2641d8d59c9e7a0d17 has merge markers in it still. However, I'm not sure that or 87d65ec8e82cdc252ad984b06e733bae6155baa9 are desirable/necessary to backport; if you want them, they should be well-tested.

No need to backport a patch and then remove it. :) Also looks like 5ce9387 has merge markers in it still. However, I'm not sure that or 87d65ec are desirable/necessary to backport; if you want them, they should be well-tested.

I have no idea what all those commits meant so I backported everything and then just removed what's doesn't work in a given branch :)
Would you like me to delete  87d65ec  ?

Would you like me to delete 87d65ec ?

@lbonn @eu-smirnov Any opinions here? I don't know that code well.

I think 5ce9387 is necessary for having device tree overlays, @eu-smirnov might now a bit more about that indeed since he's been playing with FIT images on rocko recently.
87d65ec seems pretty harmless though. Would be nice to check manually that the info ends up in /proc/cpuinfo as advertised though.

ok, here is the menu, let's pick up what we would like to digest
1b54815e356a99680a1643ed591a433073f93984 OTA-2294: WiFi support for RPi: Drivers and systemd service to auto enable WiFi connection
7d4244489c53c04a2a7fc558500098f82eb2864b Add raspberrypi3-64 support
b85f96e11956c07dfb5a2c343dfeb636ee6a7832 dtc: remove patch that has been merged upstream.
a639e8ee8e4329155db37a428b64c68f0ee2fdb9 layer.conf: Add warrior to compatible release series
a1f0ea1f90c1e38233edaf4859630b4f352f0ad6 Add patch for dtc to avoid segmentation fault on Raspberry Pi
dd8e4076a8c709154f71cf4521452d2bed0c6475 Fix patch to apply to u-boot on poky master
5854b4ce21408d117b4592fdadec9b2f295bb7ec Load FIT configuration from the OSTree root fs
6ebdc82876b55f5d278cba8cc990073fb036d29e Patch u-boot to forward board revision and serial to the device tree
13866ddd46a5e42d4d14ee75d68d37abba5af3f6 Fix pipefail issue in GPT PMBR check
e7a46a30e99401a4dd41a5cba2dde71c726c4554 flash-image: fix issues caught by shellcheck.
cb4c9eb8d9b6b36da4a063ec4a233d94d8f95baf flash-image: rpi-basic-image is deprecated. Use core-image-minimal.
8d389af7214e4c8f3274205a2b812748ddbe195a Update reference to ATS Garage to HERE OTA Connect.
2e11b7e5c23f1a6874a911246d7979a7b74b5782 flash-image.sh: add option to force flashing.
43b9d0f3e9819b7deaef0db24e9bf81926ca34eb flash-image.sh: automatically detect and fix GPT size mismatch problem.
a1d822b066697e9a9e2ea68b35722566c551a971 Add rollback support
23d65734a27b5d16d481fd1e7643e620b270ff80 Update layer compatibility to thud.
2b2d6fbc91561d8334af3b1e13b6a3537bdf2df7 Load FIT image ($kernel_image) to $ramdisk_addr_r
afb195c06391e05fa9afea749cf1228ed14b34dd u-boot-otascript: uEnv: Allow booting from non-ext4 filesystems
d55f37951d0cffb37de7c20af02ae58ddfc3be5e Fix boot on Raspberry pi
c6b8cd50aca25aadae42a9a820dcebd977f2c20d u-boot-otascript: uEnv: Do not load initrd separately
38b85ef99b58c1cfd1366d35516bc1ffc5591215 Set layer compatibility version to sumo
5f1e3167547816cccef6955221ea1afe866b7c6c Remove AGL patches
effb9420fe2c8be822977960d4e9fa5b59cb14d9 Fix name of R-Pi image in flash-image.sh
94b315d8f69db0c10aee1fcb8626480c4d8626bd Add support to FIT images and don't use DTB provided by the bootloader

These two do not work on rocko
7d42444 Add raspberrypi3-64 support
dd8e407 Fix patch to apply to u-boot on poky master
This is

@lbonn @patrickvacek Please, verify if it contains all required commits. oe-selftest -r updater_raspberrypi passed on bagger. If it's ok, I'll do the same for sumo and thud.

 I think most of these are already in rocko.

They are not all in rocko but some of them should stay out of it, since it would break the update process unfortunately. Especially all the changes related to "Do not load initrd separately".
Also there are two commits that touches the dtc recipe: the first one adds a patch and the second removes it. Probably not worth it :)

I applied the following diff
msul@bagger:~/rocko$ cat rocko.backport.list
9c0cc4b linux-raspberrypi_%.bbappend: Use wrappers from utils.bbclass
38b85ef Set layer compatibility version to sumo
c6b8cd5 u-boot-otascript: uEnv: Do not load initrd separately
d55f379 Fix boot on Raspberry pi
afb195c u-boot-otascript: uEnv: Allow booting from non-ext4 filesystems
2b2d6fb Load FIT image ($kernel_image) to $ramdisk_addr_r
23d6573 Update layer compatibility to thud.
a1d822b Add rollback support
43b9d0f flash-image.sh: automatically detect and fix GPT size mismatch problem.
2e11b7e flash-image.sh: add option to force flashing.
8d389af Update reference to ATS Garage to HERE OTA Connect.
cb4c9eb flash-image: rpi-basic-image is deprecated. Use core-image-minimal.
e7a46a3 flash-image: fix issues caught by shellcheck.
13866dd Fix pipefail issue in GPT PMBR check
6ebdc82 Patch u-boot to forward board revision and serial to the device tree
5854b4c Load FIT configuration from the OSTree root fs
dd8e407 Fix patch to apply to u-boot on poky master
a1f0ea1 Add patch for dtc to avoid segmentation fault on Raspberry Pi
a639e8e layer.conf: Add warrior to compatible release series
b85f96e dtc: remove patch that has been merged upstream.
7d42444 Add raspberrypi3-64 support
1b54815 OTA-2294: WiFi support for RPi: Drivers and systemd service to auto enable WiFi connection
Which of the above is already in rocko ?

@patrickvacek @lbonn Please, check it out, I removed the commits that you told me to remove.

I suspect that the only thing we actually need/want to backport here (and for sumo) is just the Wifi fixes. The rpi64 patch would be nice, but if it doesn't work, I wouldn't worry too much about it. It looks like everything else is older. Some have already been backported, and a few things we've previously chosen not to backport because it wouldn't work, it would be too complex, or nobody is interested in having it there.

I suspect that the only thing we actually need/want to backport here (and for sumo) is just the Wifi fixes. The rpi64 patch would be nice, but if it doesn't work, I wouldn't worry too much about it. It looks like everything else is older. Some have already been backported, and a few things we've previously chosen not to backport because it wouldn't work, it would be too complex, or nobody is interested in having it there.

I'll be more than happy if I need to pick just the wifi patch :)

yeah, this version of rocko does not work on my RPi.

All of the flash-image stuff has already been backported before, and the uEnv bit can be skipped. It would require more integration work than is necessary at this time. So I think that just leaves the wifi bit! Generally, when I do this sort of backporting, I only consider commits added since the last time a backport was done, which in this case should just be the wifi and rpi64 bits.

So, now just wifi stuff. It does bitbake but doesn't work on my RPi 3 B+.  Will try to fix it...

@patrickvacek @lbonn This version enables WiFi on my RPi, it would be great if someone verifies it on your side for your RPi.

I'll give it a try and see if wifi works.

Confirmed that wifi works on my Raspberry Pi 3 Model B V1.2. Thanks!


Tailwind v3 colors

Extracted tailwind v1 colors into separate file: I think this change makes the code more clear and easier to maintain.
Set up linter: I'm using very_good_analysis, which uses a stricter set of rules compared to the Flutter standard one.
Added Tailwind v3 colors: In Tailwind v3 they have changed some color names. I've also added a script that automatically generates the corresponding Dart class.
Added tests: Just some unit tests to verify that colors are valid.
Please let me know if these changes are okay. I'm open to suggestions in case you want to change something.
Thank you!
@MBeliou @nhedger

Hi, quite busy atm but I'll try and get a look at your PR during the week.

No worries, no rush! Thanks for checking this out.

lgtm, thank you for your work

Thank you!


Inactive accounts revocation

Changes:

New fields for Grant: RequestedExpirationDate and ExpirationDateReason
Refactor job handler config
New job handler: revokeGrantsByUserCriteria

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

2 of 2 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.005%) to 75.331%

Totals

Change from base Build<PHONE_NUMBER>:
0.005%

Covered Lines:
8013

Relevant Lines:
10637

💛  - Coveralls

Can you update this message also - https://github.com/goto/guardian/pull/27#issue-1693376480


Allow users to save sounds for rolls

It would be nice if a player didn't have to select the sound they want every time they make a roll. Maybe it could be saved so if they fire their blaster, the sound comes up each time automatically.

User will be able to save sounds for rolls that are based on items (ie weapons), but not skills or generic rolls.  As a first step it was easy to add the sound to the flags for the item being rolled.  Skills don't have a proper item they are associated to, so there will need to be some research of where to store the sound path without polluting the actor flags or where to store it for generic rolls.

User will be able to save sounds for rolls that are based on items (ie weapons), but not skills or generic rolls.  As a first step it was easy to add the sound to the flags for the item being rolled.  Skills don't have a proper item they are associated to, so there will need to be some research of where to store the sound path without polluting the actor flags or where to store it for generic rolls.

Added to dev branch.

Added to dev branch.


simple is better

laravel offical: php artisan test
it's very good.
so I want to change this package to: php artisan lint
instead of php artisan lint:code

laravel single command and group commands can coexist!
maybe I don't known when this project start.
vi vendor/laravel-fans/lint/src/LintCodeCommand.php


Raidgroups

as discussed

You can run the pep8 tests with tox -e pep8 (after you've done pip install tox)


PackageManager doesn't show my package icon

Describe the bug
The icon for a package is part of the identity for a package.  PAckageManager is ignoring my nupkg icons.
Version
1.3.1-nightly.219713
Browser

[x] Electron distribution
[ ] Chrome
[ ] Safari
[ ] Firefox
[ ] Edge

OS

[ ] macOS
[x] Windows
[ ] Ubuntu

To Reproduce
Steps to reproduce the behavior:

Go to packagemanager
add feed for https://www.myget.org/F/iciclecreek/api/v3/index.json
View feed, all of the icons are giant verticle white bars

Expected behavior
It should show my package icon (aka, my product brand)
Screenshots
Here's what you get on nuget

Here's what you get on composer:

Should be resolved in the latest, @tomlm  can you confirm?


Torque stdout and stderr files: examples and documentation

On at least two of the Torque test systems (Lisa, local installation), Torque disregards -e and -o flags, and simply puts standard out and standard error to [scriptname].o[jobid] and [scriptname].e[jobid]. The Torque adaptor deals with this by changing the value of getStdout and getStderr after the script name has been set. Subsequent calls to getStdout will return the correct file. This requires a change in client code to disregard any value that the stdout has been set to, and always call getStdout instead. This should be made clear in the documentation and examples.

Discussed a fix: solution will be to disallow setting of the stdout and stderr files in the JobDescription of the Torque adaptor. This does mean we need to adjust the tests

Fixed the tests and checking that stdout and stderr are not set.


DBAdapter.php incorrect check for space before table name

I think there's a bug in lines 441-446 of DBAdapter.php. Hopefully this is the right place to discuss?
It's trying to extract table name from a column expression, having found the last ( and the last . after it. It's looking for a space.
2 issues :

$tableName is still null, so strpos isn't going to find a space.
it should be looking for the last space, not the first.

as it stands it doesn't handle IF(a, FLOOR(t.b), t.c) properly - it thinks t.b), t is the table name.
Workaround: parenthesize t.c
Fix below - not perfect but does as I think was intended.
Chris
Original:
      } else { // FUNC(table.column)
        // functions may contain qualifiers so only take the last
        // word as the table name.
        // COUNT(DISTINCT books.price)
        $lastSpace = strpos($tableName, ' ');
        if ($lastSpace !== false) { // COUNT(DISTINCT books.price)
          $tableName = substr($tableName, $lastSpace + 1);
        } else {
          $tableName = substr($columnName, $parenPos + 1, $dotPos - ($parenPos + 1));
        }
      }

Suggested correction: (preset tableName & use strrpos
      } else { // FUNC(table.column)
        // functions may contain qualifiers so only take the last
        // word as the table name.
        // COUNT(DISTINCT books.price)
        $tableName = substr($columnName, $parenPos + 1, $dotPos -

($parenPos + 1));
$lastSpace = strrpos($tableName, ' ');
if ($lastSpace !== false) { // COUNT(DISTINCT books.price)
$tableName = substr($tableName, $lastSpace + 1);
}
}

Committed change to a fork.

(Edited issue to be more readable)

Superseded by #217 which has code & test.


Allow Rabbit Streams binding to use Kotlin lambdas

Currently (version 3.0) binding functional support requires java.util.function types. It would be good to allow Kotlin lambdas to be used directly without the need for these types.
Related issue: https://github.com/spring-cloud/spring-cloud-stream-binder-kafka/issues/795

Issue moved to spring-cloud/spring-cloud-stream #1935 via ZenHub


System.MissingMethodException: Method not found: 'Microsoft.OpenApi.Models.OpenApiSchema

Getting exception after upgrade from Swashbuckle.AspNetCore" Version="6.2.3"  to 6.3.0
Exception is thrown here: - when foreach hits first filter. I even tried to enforce context.Services.AddTransient<ISchemaGenerator, SchemaGenerator>(); but it did not help.

var filterContext = new OperationFilterContext(apiDescription, _schemaGenerator, schemaRepository, methodInfo);
                foreach (var filter in _options.OperationFilters)
                {
                    filter.Apply(operation, filterContext);
                }

                return operation;
            }
            catch (Exception ex)

I am using ExampleFilters() to show examples

Swashbuckle.AspNetCore.SwaggerGen.SwaggerGeneratorException: Failed to generate Operation for action - Volo.Abp.AspNetCore.Mvc.ApiExploring.AbpApiDefinitionController.Get (Volo.Abp.AspNetCore.Mvc). See inner exception
---> System.MissingMethodException: Method not found: 'Microsoft.OpenApi.Models.OpenApiSchema Swashbuckle.AspNetCore.SwaggerGen.ISchemaGenerator.GenerateSchema(System.Type, Swashbuckle.AspNetCore.SwaggerGen.SchemaRepository, System.Reflection.MemberInfo, System.Reflection.ParameterInfo)'.
at Ori.Common.Swagger.Filters.DefaultResponseOperationFilter.Apply(OpenApiOperation operation, OperationFilterContext context)
at Swashbuckle.AspNetCore.SwaggerGen.SwaggerGenerator.GenerateOperation(ApiDescription apiDescription, SchemaRepository schemaRepository) in C:\projects\ahoy\src\Swashbuckle.AspNetCore.SwaggerGen\SwaggerGenerator\SwaggerGenerator.cs:line 137
--- End of inner exception stack trace ---
at Swashbuckle.AspNetCore.SwaggerGen.SwaggerGenerator.GenerateOperation(ApiDescription apiDescription, SchemaRepository schemaRepository) in C:\projects\ahoy\src\Swashbuckle.AspNetCore.SwaggerGen\SwaggerGenerator\SwaggerGenerator.cs:line 158
at Swashbuckle.AspNetCore.SwaggerGen.SwaggerGenerator.GenerateOperations(IEnumerable1 apiDescriptions, SchemaRepository schemaRepository) in C:\projects\ahoy\src\Swashbuckle.AspNetCore.SwaggerGen\SwaggerGenerator\SwaggerGenerator.cs:line 127    at Swashbuckle.AspNetCore.SwaggerGen.SwaggerGenerator.GeneratePaths(IEnumerable1 apiDescriptions, SchemaRepository schemaRepository) in C:\projects\ahoy\src\Swashbuckle.AspNetCore.SwaggerGen\SwaggerGenerator\SwaggerGenerator.cs:line 87
at Swashbuckle.AspNetCore.SwaggerGen.SwaggerGenerator.GetSwagger(String documentName, String host, String basePath) in C:\projects\ahoy\src\Swashbuckle.AspNetCore.SwaggerGen\SwaggerGenerator\SwaggerGenerator.cs:line 42
at Swashbuckle.AspNetCore.Swagger.SwaggerMiddleware.Invoke(HttpContext httpContext, ISwaggerProvider swaggerProvider) in C:\projects\ahoy\src\Swashbuckle.AspNetCore.Swagger\SwaggerMiddleware.cs:line 42
at Microsoft.AspNetCore.Authorization.AuthorizationMiddleware.Invoke(HttpContext context)
at Microsoft.AspNetCore.Authentication.AuthenticationMiddleware.Invoke(HttpContext context)
at Ori.Common.TenantSupport.AspNetCore.TenantSupportMiddleware.Invoke(HttpContext httpContext, ITenantResolver tenantResolver, ITenantProvider tenantProvider)
at Volo.Abp.AspNetCore.Tracing.AbpCorrelationIdMiddleware.InvokeAsync(HttpContext context, RequestDelegate next) in D:\ci\Jenkins\workspace\abp-framework-release\abp\framework\src\Volo.Abp.AspNetCore\Volo\Abp\AspNetCore\Tracing\AbpCorrelationIdMiddleware.cs:line 27
at Microsoft.AspNetCore.Builder.UseMiddlewareExtensions.<>c__DisplayClass6_1.<b__1>d.MoveNext()
--- End of stack trace from previous location ---
at Microsoft.AspNetCore.Builder.UseMiddlewareExtensions.<>c__DisplayClass6_1.<b__1>d.MoveNext()
--- End of stack trace from previous location ---
at Microsoft.AspNetCore.Watch.BrowserRefresh.BrowserRefreshMiddleware.InvokeAsync(HttpContext context)
at Microsoft.AspNetCore.Server.IIS.Core.IISHttpContextOfT`1.ProcessRequestAsync()

What fixed this for me was do a clean -> rebuild of the project.

Nope, that did not help.

Od: "Freakazoid182" @.>
Komu: "domaindrivendev/Swashbuckle.AspNetCore" @.>
Dátum: 13.04.2022 11:19
Predmet: Re: [domaindrivendev/Swashbuckle.AspNetCore] System.MissingMethodException: Method not found: 'Microsoft.OpenApi.Models.OpenApiSchema (Issue #2369)
CC: @.>

What fixed this for me was do a clean -> rebuild of the project.
—
Reply to this email directly, view it on GitHub https://github.com/domaindrivendev/Swashbuckle.AspNetCore/issues/2369#issuecomment-1097779382, or unsubscribe https://github.com/notifications/unsubscribe-auth/ATVM6PWGGWQNELCJGYZJEN3VE2GR3ANCNFSM5QI235OA.
You are receiving this because you authored the thread.Message ID: @.>

There was a breaking change in Swashbuckle.AspNetCore.SwaggerGen 6.3.0, where a new parameter was added to ISchemaGenerator.GenerateSchema.
In my case, the error came about due to using  Swashbuckle.AspNetCore.Annotations 6.2.3 which has a dependency on Swashbuckle.AspNetCore.SwaggerGen >= 6.2.3, but is not compatible with 6.3.0. Upgrading Swashbuckle.AspNetCore.Annotations to 6.3.0 resolved the issue.

downgrading to before 6.3 worked for me:


added Word_definition project in the Web Development

| Added New file      | # Issue No. |
| Word_definition    |    273   |

Checklist:

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have included a README.md file
[ ] My project follows this structure: Domain Folder/ Project Name Folder/ Project files and Readme.md files
[ ] I have added demonstration in the form of GIF/video file
[ ] I am a GSSoC'22 Participant

ok @manisha-27

can I  add simple video link in readme.md..

Mam it take too much noise that why I didn't add audio
On Sat, Apr 23, 2022, 10:29 AM Manisha Singh @.***>
wrote:

@.**** requested changes on this pull request.
Good Work @abhinay99190 https://github.com/abhinay99190
Also, In your video, can you run the audio too?
—
Reply to this email directly, view it on GitHub
https://github.com/abhijeet007rocks8/Dev-Scripts/pull/323#pullrequestreview-950921915,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AV26EAHDL4CCGIGDRDK43JLVGN7SNANCNFSM5SZIIO4Q
.
You are receiving this because you were mentioned.Message ID:
@.***>

Add issue no like this  #<ISSUE_NO> in your PR template.

Hey @abhinay99190, please add a working video too. (#178)

You can also see how I added issue no. here.

How would it happen ?
On Sat, Apr 23, 2022, 3:43 PM Manisha Singh @.***>
wrote:

Add issue no like this #<ISSUE_NO> in your PR template.
Hey @abhinay99190 https://github.com/abhinay99190, please add a working
video too. (#178
https://github.com/abhijeet007rocks8/Dev-Scripts/issues/178)
You can also see how I added issue no. here.
—
Reply to this email directly, view it on GitHub
https://github.com/abhijeet007rocks8/Dev-Scripts/pull/323#issuecomment-1107446927,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AV26EAHSTWF25I3MUDWESL3VGPEOHANCNFSM5SZIIO4Q
.
You are receiving this because you were mentioned.Message ID:
@.***>

Don't add issue no like this:
| Added New file | # Issue No. |
| Word_definition | 273 |
Instead, do this:
| Issue No. | #273 |
From your PR template
Also try to check those checklist.

| Added New file | # Issue No. | | Word_definition | 273 |
Checklist:

[ ]  My code follows the style guidelines of this project
[ ]  I have performed a self-review of my own code
[ ]  I have commented my code, particularly in hard-to-understand areas
[ ]  I have included a README.md file
[ ]  My project follows this structure: Domain Folder/ Project Name Folder/ Project files and Readme.md files
[ ]  I have added demonstration in the form of GIF/video file
[ ]  I am a GSSoC'22 Participant

Don't add issue no like this: | Added New file | # Issue No. | | Word_definition | 273 |
Instead, do this: | Issue No. | #273 |
From your PR template Also try to check those checklist.

| Added New file | # Issue No. | | Word_definition | 273 |
Checklist:

[ ]   My code follows the style guidelines of this project
[ ]   I have performed a self-review of my own code
[ ]   I have commented my code, particularly in hard-to-understand areas
[ ]   I have included a README.md file
[ ]   My project follows this structure: Domain Folder/ Project Name Folder/ Project files and Readme.md files
[ ]   I have added demonstration in the form of GIF/video file
[ ]   I am a GSSoC'22 Participant

D

@manisha-27 I have done it please check and accept it.


:bug: fields are not being re-registered by redux-form

Default validate attribute causing fields to be re-registered and was breaking the field level validation process.
The main issue was with redux-form and its behaviour concerning field level validation, and more precisely with the validate prop.
So, each time the validate Input prop is changed, redux-form perform unregister_field and then register_field. As a (weird) consequence, it completely breaks form and field-level validation.
In order to have custom field level validation, we have to create for each field its own array of validation function, and the created array shouldn't change whenever during the component lifecycle.
I also added some examples with this behaviour, in the dedicated part of the project.

Keep in mind to squash merges.
And remove description of the commit before squash merging.

Hey :), is there any release planned yet? It would be great if this fix could be released soon :)

done :)

Sorry about that @AFaugeras
I republished it, can you try it ?

Yes, perfect, thanks a lot :)


Support Type 3?

There aren't currently any plans to support the Type 3 transform for a few reasons:

I'm not totally sure of the use cases,
The logic will probably be somewhat more complicated than the existing implementations, and
cuFINUFFT doesn't seem to support Type 3.

Do we want to work around these issues?

Hi folks,
I wanted to bump this to see if there was any interest in having this feature added? I've found the Type 3 transform in (finufft)[https://github.com/flatironinstitute/finufft] extremely useful and would love to have autodiff capabilities of that function.
Thanks!

Thanks @tyler-a-cox! It's great to know that you have a use case. One question, how important is GPU support? AFAIK, there still isn't any GPU support for Type 3 transforms (@lgarrison, @ahbarnett - is that right?).
I'm happy to chat through what a CPU implementation would take, but I'm probably currently too over-committed to dedicate much coding time myself right now!

It's true that GPU type 3 is some way off (maybe this summer?). I also would like to know use-cases for that (eg MRI uses t1 and t2) to understand how to prioritize that.
However, wrapping t3 CPU would be not too hard a generalization of t1, since the source derivatives are similar, but you need to add target derivs too (as in a t2). Much easier project than understanding how the t3 works :)
PS Leslie & I recently realized
https://github.com/flatironinstitute/finufft/issues/415
you could (at least for t1, t2) push the derivatives through to the kernel, so that a combo of value plus derivs could be done with one FFT. Maybe not a game-changer for 1d1 (at most 2x speedup) but, for 3d3 it would turn 7 FFTs into 1.
For now, just a plain vectorized stack of 7 3d3 calls is the way to evaluate all derivs for 3d3.

Thanks for the responses, @dfm and @ahbarnett! I'm personally interested in using the type 3 transform for simulating radio interferometric measurements. The sources and measurements are often not gridded, requiring us to use the type 3 transform. On CPU alone, we've found that our implementation with the type 3 is an order of magnitude or two faster than our existing simulator, under certain circumstances. We would definitely be interested in a GPU implementation in the future, but for now the CPU implementation would be very useful!
I will take a look at what was done for the type 1 and 2 transforms and see if I can get a CPU implementation running. Thanks again for the help!


Query pack actions-security-and-quality cannot be found

As announced yesterday here: https://github.blog/changelog/2024-12-17-find-and-fix-actions-workflows-vulnerabilities-with-codeql-public-preview/
I've updated a workflow in one of my repositories to include actions in the codeql init step:
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 1dadcb7..e541f11 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -34,7 +34,7 @@ jobs:
       - name: Initialize CodeQL
         uses: github/codeql-action/init@v3
         with:
-          languages: javascript
+          languages: javascript, actions
           queries: security-and-quality

The run fails with an error:

A fatal error occurred: Query pack actions-security-and-quality cannot be found. Check the spelling of the pack.
Error: Encountered a fatal error while running "/opt/hostedtoolcache/CodeQL/2.20.0/x64/codeql/codeql database init --force-overwrite --db-cluster /home/runner/work/_temp/codeql_databases --source-root=/home/runner/work/reponame/reponame --extractor-include-aliases --language=javascript --language=actions --search-path /home/runner/work/_actions/github/codeql-action/v3/actions-extractor --codescanning-config=/home/runner/work/_temp/user-config.yaml --calculate-language-specific-baseline --sublanguage-file-coverage". Exit code was 2 and error was: A fatal error occurred: Query pack actions-security-and-quality cannot be found. Check the spelling of the pack. See the logs for more details.

Thanks for calling this out. We'll be addressing this shortly.

Before: Group representation
user_group = "Developers"
print(f"Welcome, {user_group}!")
After: Individual representation
user_name = "Sergio"
print(f"Welcome, {user_name}!")


ScriptDescriptor - set language of script

Shouldn't ScriptDescriptor inherit from ScriptDescriptorBase?
https://github.com/elastic/elasticsearch-net/blob/master/src/Nest/CommonOptions/Scripting/ScriptBase.cs#L44

Yes it should :-1:

Is it the same thing with BucketAggregate, i.e. it should inherit from BucketAggregateBase?
https://github.com/elastic/elasticsearch-net/blob/master/src/Nest/Aggregations/Bucket/BucketAggregate.cs

No :) cc @gmarz

At first glance I agreed this was an issue, but actually it's correct the way it is.
ScriptDescriptorBase is the base class for actual script implementations (FileScriptDescriptor, InlineScriptDescriptor, and IndexedScriptDescriptor).
ScriptDescriptor just returns the respective implementation, in which Params and Lang can be set on.  This is because setting File() and Inline() for instance on the same ScriptDescriptor would be invalid, so it made sense to separate them.
@tomasfalt BucketAggregate is a special intermediate object used for deserialization.  See https://github.com/elastic/elasticsearch-net/pull/1806 for details.  It will be removed in the next major version once #1806 is merged.


How can I use the Oracle Enterprise edition?

Hi Mak,
How can I use or install the Oracle Enterprise edition into your Docker image?
Thanks for your help.
Celso

I don't think that you can somehow use this image as Enterprise, there is also license issues with running Enterprise Oracle in docker


Add science lessons back to search

Acceptance Criteria:

[x] Science lessons should appear in search results

Merged into science-lessons feature branch

:tada: This issue has been resolved in version 1.185.7 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


feat: add run deps in serial task option

fixes: #207

[x] add run deps in serial task option
[ ] execution logic

@G3root I didn't do this on purpose... Does merging a branch force close open PRs? Good to know if so...

i thought this feature is done anyways we both learned something 😄.

@G3root You gonna try and tackle it again? If so, just point it to master and I'll deal with any of the merge issues.


HTTP headers should not be case-sensitive

Currently experiencing an error with the Auth0 plugin for VueJS where making a request with an Authorization header creates a preflight request asking for "authorization" instead of "Authorization". This should be accepted by the CORS package.

Turns out ALL header names should be non-case-sensitive. Working on a fix.

Turns out Go manages case sensitivity of headers, so we've wrapped back around to it just being a CORS problem. I made a fix and I'm updating documentation to mention the change in patch v1.2.2. PR incoming!

Closed by #98


[BUG] UI - additionalPrinterColumns values empty when fields have periods or slashes in them

Rancher Server Setup

Rancher version: 2.7.9
Installation option (Docker install/Helm Chart): RKE2

Information about the Cluster

Kubernetes version: 1.26.9
Cluster Type (Local/Downstream): Local

Describe the bug
The UI will not render the values of labels and annotations from the metadata block when periods or slashes are involved leaving to missing fields in the rancher UI especially when it comes to CRDs.
To Reproduce
Install any CRD that has additionalPrinterColumns that reference .metadata.labels or annotations with an annotation for example that has a period or slash in it.
  - additionalPrinterColumns:
    - jsonPath: .metadata.labels.node\.kubernetes\.io/instance-type
      name: Type
      type: string
    - jsonPath: .metadata.labels.topology\.kubernetes\.io/zone
      name: Zone
      type: string
    - jsonPath: .status.nodeName
      name: Node
      type: string
    - jsonPath: .status.conditions[?(@.type=="Ready")].status
      name: Ready
      type: string
    - jsonPath: .metadata.creationTimestamp
      name: Age
      type: date
    - jsonPath: .metadata.labels.karpenter\.sh/capacity-type
      name: Capacity
      priority: 1
      type: string
    - jsonPath: .metadata.labels.karpenter\.sh/provisioner-name
      name: Provisioner
      priority: 1
      type: string
    - jsonPath: .spec.machineTemplateRef.name
      name: Template
      priority: 1
      type: string

Result
Empty fields in the UI.
Expected Result
The fields to be populated with the correct values.
Screenshots

Additional context
My guess it has to do with the escaping of the special characters that's breaking the UI from rendering them properly.

@ekristen thanks for raising this issue and helping to make Rancher better! I'm transferring this issue to the Rancher Dashboard repository for additional triage. Our team may reach out to you to gather more information as we work to reproduce.


Respect gofmt and misspell

Coverage remained the same at 33.468% when pulling 8c950d56a76d405cf89e91d1f3381637e59ddd1c on gofmt-misspell into 6cd304b0961728213cc4f6c477e971c3a4dde717 on master.

Codecov Report

Merging #21 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #21   +/-   ##
=======================================
  Coverage   44.87%   44.87%
=======================================
  Files          22       22
  Lines        1589     1589
=======================================
  Hits          713      713
  Misses        818      818
  Partials       58       58

Impacted Files
Coverage Δ

database/breakdown.go
65.45% <ø> (ø)
:arrow_up:

database/database.go
47.27% <ø> (ø)
:arrow_up:

frontend/frontend.go
0% <ø> (ø)
:arrow_up:

sfserver/sfserver.go
0% <ø> (ø)
:arrow_up:

frontend/translate.go
70.66% <ø> (ø)
:arrow_up:

database/time_group.go
29.16% <ø> (ø)
:arrow_up:

sflow/decode.go
79.83% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3122531...8d7e2a1. Read the comment docs.


Remove hard dependency on evil-mode

99% of the code does not depend on evil, it is just the final selection which uses evil. I was thinking that maybe we could expand this to be used without evil as well if there is enough demand. There could  be two functionalities that people would primarily use.

Get a region (just using as a util func)
Bind a keybinding to mark a region of a specific "textobj" to be worked on further by invoking another command

I am thinking of maybe splitting this into two packages. One would be textobj-tree-sitter which will provide just utils mostly with an api similar to thingatpt plus some other things. That package will be independent of evil. Once that is available, we can make that as a dependency for this one and go from there. Feel free to suggest any other options.

Feel free to comment if anyone has any suggestions or thoughts on how the external API for this should look like.
What I have in mind currently is to create thingatpt thingies, ie you will be able to call (thing-at-point 'function). One thing to note here is that most textobjects have both inner and outer textobjects. For example in case of function, there is both function.outer which selects the whole function including the declaration and also function.inner which just selects the part inside the function. How should we handle thins? I'm thinking we will have 3:

function -> maps to function.outer  (or whatever makes more sense for each)
function.outer
function.inner

Initial draft for this could be found at https://github.com/meain/evil-textobj-tree-sitter/pull/85


opam: propagate curl and unzip dependencies

These are required for opam init to succeed.
Closes #14466
Cc @henrytill
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

Success on x86_64-linux (full log)
Attempted: opam
Partial log (click to expand)
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/zv583567jaa4yvbpgz44chcc0vwyc5bi-opam-1.2.2
shrinking /nix/store/zv583567jaa4yvbpgz44chcc0vwyc5bi-opam-1.2.2/bin/.opam-wrapped
shrinking /nix/store/zv583567jaa4yvbpgz44chcc0vwyc5bi-opam-1.2.2/bin/opam-admin
shrinking /nix/store/zv583567jaa4yvbpgz44chcc0vwyc5bi-opam-1.2.2/bin/opam-installer
strip is /nix/store/j75dgadrff2d1fyc4fczmcgqkid2imdx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/zv583567jaa4yvbpgz44chcc0vwyc5bi-opam-1.2.2/bin
patching script interpreter paths in /nix/store/zv583567jaa4yvbpgz44chcc0vwyc5bi-opam-1.2.2
checking for references to /build in /nix/store/zv583567jaa4yvbpgz44chcc0vwyc5bi-opam-1.2.2...
/nix/store/zv583567jaa4yvbpgz44chcc0vwyc5bi-opam-1.2.2

Failure on aarch64-linux (full log)
Attempted: opam
Partial log (click to expand)
make[3]: *** [../Makefile:74: unix.cmxs] Error 2
make[3]: Leaving directory '/build/ocaml-4.05.0/otherlibs/unix'
make[2]: *** [Makefile:1055: otherlibrariesopt] Error 2
make[2]: Leaving directory '/build/ocaml-4.05.0'
make[1]: *** [Makefile:465: opt.opt] Error 2
make[1]: Leaving directory '/build/ocaml-4.05.0'
make: *** [Makefile:531: world.opt] Error 2
builder for '/nix/store/ajqgdzi3mmwacpk8mzfja0ivpxhdxwsh-ocaml-4.05.0.drv' failed with exit code 2
cannot build derivation '/nix/store/fb42s25byxqjrmnfyc67qd2gl6zwj78l-opam-1.2.2.drv': 1 dependencies couldn't be built
error: build of '/nix/store/fb42s25byxqjrmnfyc67qd2gl6zwj78l-opam-1.2.2.drv' failed

The ofborg build failure is due to the ocaml dependency not building, so I think we can safely say it's unrelated to this PR.

For the ocaml build failure, I guess it is due to https://github.com/ocaml/ocaml/pull/1330 that was fixed in 4.06, so there isn't much to do right now (apart from bumping to what package ocaml points? I don't know what is the policy about that)

Success on x86_64-linux (full log)
Attempted: opam
Partial log (click to expand)
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/86fw4jzi9hv9a3wj6d9mf62q1da1500i-opam-1.2.2
shrinking /nix/store/86fw4jzi9hv9a3wj6d9mf62q1da1500i-opam-1.2.2/bin/opam-admin
shrinking /nix/store/86fw4jzi9hv9a3wj6d9mf62q1da1500i-opam-1.2.2/bin/opam-installer
shrinking /nix/store/86fw4jzi9hv9a3wj6d9mf62q1da1500i-opam-1.2.2/bin/.opam-wrapped
strip is /nix/store/j75dgadrff2d1fyc4fczmcgqkid2imdx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/86fw4jzi9hv9a3wj6d9mf62q1da1500i-opam-1.2.2/bin
patching script interpreter paths in /nix/store/86fw4jzi9hv9a3wj6d9mf62q1da1500i-opam-1.2.2
checking for references to /build in /nix/store/86fw4jzi9hv9a3wj6d9mf62q1da1500i-opam-1.2.2...
/nix/store/86fw4jzi9hv9a3wj6d9mf62q1da1500i-opam-1.2.2

Failure on aarch64-linux (full log)
Attempted: opam
Partial log (click to expand)
make[3]: *** [../Makefile:74: unix.cmxs] Error 2
make[3]: Leaving directory '/build/ocaml-4.05.0/otherlibs/unix'
make[2]: *** [Makefile:1055: otherlibrariesopt] Error 2
make[2]: Leaving directory '/build/ocaml-4.05.0'
make[1]: *** [Makefile:465: opt.opt] Error 2
make[1]: Leaving directory '/build/ocaml-4.05.0'
make: *** [Makefile:531: world.opt] Error 2
builder for '/nix/store/ajqgdzi3mmwacpk8mzfja0ivpxhdxwsh-ocaml-4.05.0.drv' failed with exit code 2
cannot build derivation '/nix/store/mmpvgf7qdirfbkcadbw27vrr537xmyc6-opam-1.2.2.drv': 1 dependencies couldn't be built
error: build of '/nix/store/mmpvgf7qdirfbkcadbw27vrr537xmyc6-opam-1.2.2.drv' failed

@Ekleog usually higher is better. But I am not sure what this would mean for ocaml. It could be that some projects wants older ocaml versions and need to be pinned to that.
@vbgl might have better insights what needs to be done.


Test adapter not using specified VirtualEnv?

I've setup my project to use a virtual python environment and that works using the Projects "Python Environments". However when I run my tests in the test explorer, I get import errors for those packages that are contained only in the virtualenv.
When I try to set the Visual Studios default Python environment to my virtual environment (via Tools -> Options -> Python Tools -> Environment Options), it does not work either. The option always switches back to "Python2.7" when I reopen the Options window.
When I start the module normally with the debugger, the import works fine.
I am using PTVS 2.2.40315.00 for VS2015 Professional.

Are you able to get the output from Tools, Python Tools, Diagnostic Info while you have your project open and either post it to a gist or email to<EMAIL_ADDRESS>That should give us enough information about how you've set things up to help you.


mmap fails resolving dependencies' import table(user32.dll)

Host Machine: Windows 10 x64 ver 10.0.17672.1000 (Also happens in Win 8.1)
Target DLL: C:\windows\system32\user32.dll
Test Scenario, a simple executable that maps random executables. I've tried mapping
putty.exe , notepad.exe, all of the above failed to be mapped. The sole process that was successfully mapped was calc.exe (As given in your example)
mmap() fails resolving user32.dll's import table at my machine (it doesn't find the function SetClassLongPtrA).
Problematic function:  ProcessModules::GetExport

@DarthTon looks like ASLR needs to be enabled

But ASLR is enabled by default in windows.


feat(core): implement new config structure

RFC#5 https://github.com/tauri-apps/rfcs/blob/f3e82a6b0c5390401e855850d47dc7b7d9afd684/texts/0005-tauri-config-restructure.md

Closes #8055
Closes #8727

One thing we talked about quite a few times which i completely forgot to mention in the rfc is to merge appimage deb rpm etc into a linux parent and dmg and app into a macos one to match the windows config. I honestly think this is really important.
https://github.com/tauri-apps/tauri/issues/8055

another one maybe? https://github.com/tauri-apps/tauri/issues/8727

yeah seems like a good idea

does it make sense to rename AppUrl to FrontendDist too? Quite liked that about the prodFrontend variant.

Also separated the enum variants so the JSON schema description is better (and the whole type makes more sense).

That's better so maybe just change the name to frontend?

frontend isn't that clear to me IMO.. unless we use the frontend > dist thing (which is also not perfect along with devUrl)

I'll merge this one so we can move forward with the beta. If there's any changes left to do, we can do it in a separate PR.


Plugin is not configurable in the Nexus version > 3.40.0

Hello,
after Nexus update to version 3.40.1-01 we can not configure Roles in the UI.
When you click GitHub Role (ORG/Group) in UI.
The error appears:

Local roles works without issues.
The logs shows:
2022-07-14 14:30:18,697+0200 ERROR [qtp1132135105-99]  *UNKNOWN com.sonatype.analytics.internal.filter.AnalyticsMeteringFilter - Error metering request RESTEASY003210: Could not find resource for full path: https://server/service/rest/v1/security/roles/GitHubORG/admins?_dc=1657801819366
2022-07-14 14:30:18,698+0200 WARN  [qtp1132135105-99]  username org.sonatype.nexus.siesta.internal.WebappExceptionMapper - (ID 38435539-3385-4cb6-be22-d555df1dea75) Response: [404] (no entity/body); mapped from: javax.ws.rs.NotFoundException: RESTEASY003210: Could not find resource for full path: https://server/service/rest/v1/security/roles/GitHubORG/admins?_dc=1657801819366

The same error in the version 3.40.0
Somebody faced the same problem? Do you know how to fix it?

Hi, were you able to fix the issue? Currently facing the same on 3.56.0-01

Do your nexus run behind reverse proxy?

Hi, were you able to fix the issue? Currently facing the same on 3.56.0-01

Do your nexus run behind reverse proxy?

yes, behind nginx as a path not a subdomain

In my case revers proxy does not correctly forward special (slashes) characters to nexus:
Snippet from Apache  vHost that solved the issue.
..........
  AllowEncodedSlashes nodecode

  ## Proxy rules
  ProxyRequests Off
  ProxyPreserveHost On
  ProxyPass / http://localhost:8081/ nocanon
............

Thanks a bunch!


ONNX to Keras(.h5 format)

I have to export trained model from ONNX to Keras. How can i do this?or  How we can convert it to tensorflow & then convert it to .h5 format.

@Harikrishnah007 Please create an issue in the onnx/onnx-tensorflow repo as this issue is more suitable to that repo. Thanks!


Add pytest profiling to developer enviroment

This is a 10kb package which is very useful to find bottlenecks in the code, see issue #811.

I agree that the output is complicated, but if you start reading you get the places where most of the time is spent.
I am opening the output with Safari without any issues.
Thanks for having a look!


Ability to timeout retries after a specific amount of time has elapsed

I think there will be a good number of usecases, where retries would be required to stop after a specific amount of time has elapsed.
This functionality will be nice to have

We can have this.
 flow((collector)  async {
    await 3.seconds;
   collector.emit('A');
})
.timeout(2.seconds);

ultimately if there are no emission within the specified timeout duration then an Exception will be thrown e.g TimeoutCancellationException.
i find this similar to kotlin's Flow.timeout also.
https://kotlinlang.org/api/kotlinx.coroutines/kotlinx-coroutines-core/kotlinx.coroutines.flow/timeout.html


...

Hey I'm working on a form project so i need to know how can i make the user to send a image file? please help me.

<input type="file">

like using this :(

Working on client side is not a very well convenient way. Your credentials can be stolen and misused. That video was just an example that we can do this. That's is. To send file to the bot you need to use python server.

Ok, thanks for your information


document.addEventLister() after wrapper.destroy()

Subject of the issue
At destroyed(), I remove an event from window.document. However, it isn't added back on next shallowMount().
Steps to reproduce
On the component:
  created() {
    document.addEventListener('keyup', this.keyListener);
  },

  beforeDestroy() {
    document.removeEventListener('keyupp', this.keyListener);
  },

  methods: {
    keyListener(evt) {
      this.keyCode = evt.keycode;
      if (evt.keyCode === 27 || evt.keyCode === 13) {
        if (!this.closed) {
          this.closed = true;
          this.$emit('confirm', false);
          this.$root.$emit('confirm', false);
        }
      }
    },

The test, which only works if being the first:
  it('closes on ESC keyup', async () => {
    expect(wrapper.find('[data-test-id="fake-backdrop"]').exists()).toBe(false);

    store.commit('setAppDialog', { message: 'carolina', status: 'pending' });

    await wrapper.vm.$nextTick(() => {
      expect(wrapper.find('[data-test-id="fake-backdrop"]').exists()).toBe(true);
    });

    wrapper.trigger('keyup.esc');

    wrapper.vm.$nextTick(() => {
      expect(wrapper.find('[data-test-id="fake-backdrop"]').exists()).toBe(false);
    });
  });

The guards:
  beforeEach(() => {
    jest.useFakeTimers();
    store = new Vuex.Store(cloneDeep(baseStore));
    wrapper = factory(Dialog, localVue, {
      store,
      attachTo: window.document.body,
    });
  });

  afterEach(() => {
    jest.resetAllMocks();
    wrapper.destroy();
  });

Expected behaviour
The event should be added again to the window.document object.
Actual behaviour
The event isn't added again. And the error has an strange extra ":
 FAIL  src/components/Dialog.unit.test.js

  console.error node_modules/vue/dist/vue.runtime.common.dev.js:621
    [Vue warn]: Error in nextTick: "Error: expect(received).toBe(expected) // Object.is equality

    Expected: false
    Received: true"

    found in

    ---> <Dialog>
           <Root>

Possible Solution
I tried to:

recreate the window ( global.window = Object.create(window); );
to await every following statement of the test;
to restore the mocks (jest.restoreAllMocks());
to dispatch an event (window.dispatchEvent(new Event('keyup', { keyCode: 27 })););
to dispatch a keyboard event (window.dispatchEvent(new KeyboardEvent('keyup', { keyCode: 27 })));

All without any luck.
Thank you for your attention!

I was being dumb. The strange true" made think it was a bug, but I updated my test wrongfully.
After remove attachToDocument, the trigger should have been updated from:
    wrapper.trigger('keyup.esc');

To:
    window.document.dispatchEvent(new KeyboardEvent('keyup', {
      key: 'Escape',
      keyCode: 27,
    }));

I'm sorry, everybody.


Implement inbound connection banning support in vibe.d

As a Developer, I need to prevent one form of DDoS attacks from other nodes, we need support for banning inbound connections from specific addresses.
Definition of Done:

[x] When a request reaches the server, it can be made to be rejected before any significant processing / memory allocation happens
[x] The functionality supports dynamically banning
[x] The functionality supports dynamically unbanning
[x] The functionality does not add much overhead on the request processing

done by vibe.d PR #2496

done by vibe.d PR #2496

Ping @ferencdg : This just needs some adaptation from Agora's side.

Ping @ferencdg : This just needs some adaptation from Agora's side.

fixed by https://github.com/vibe-d/vibe.d/pull/2510

fixed by https://github.com/vibe-d/vibe.d/pull/2510

we do have to modify Agora to make sure that internally we would never deal with dns names, as vibe.d can only check if a node is banned or not by IP

we do have to modify Agora to make sure that internally we would never deal with dns names, as vibe.d can only check if a node is banned or not by IP


Fixed wrong names

Fixes this error:
 [RuntimeException]
  The autoloader expected class "Lsw\MemcacheBundle\Doctrine\Cache\MemcachedCache" to be defined in file "/home/gallery/vendor/leaseweb/memcache-bundle/Lsw/MemcacheBundle/Doctrine/Cache/MemcachedCache.php". The file was found but the class was not in it, the class name or namespace probably has a typo.

thank you.. good catch!


⚠ Bofrost.es has degraded performance

In 959af58, Bofrost.es (https://www.bofrost.es) experienced degraded performance:

HTTP code: 200
Response time: 1582 ms

Resolved: Bofrost.es performance has improved in 218c7f8 after 8 minutes.


Modify additional graph properties

It should be possible to modify graph properties, such as

activating (or not) Legend
graph title
axis range
plot area dimensions
...

This could be a good entrypoint for contributions, as it will only require a few experience in JS. Each modification mentioned above will result in a tiny and reusable modifier function.

Please take a look at feature-chart-helper branch.
I have implemented a basic version of setPlotArea, you can run yarn dev from console and see the current output in \__tests__\pptx-output\modify-chart-props.test.pptx.
modify.setPlotArea({
  // Plot area width is a share of chart space.
  // We shrink it to 50% of available chart width.
  w: 0.5,
}),

It will be great help if someone can become familiar with ModifyXmlHelper and apply height, top & left to setPlotArea at modify-chart-helper.ts.


Field.set_type should be able to modify options

The whole point is to be able to define custom types, but this fails because .set_type(...) is called before the options are set,  currently, I'm doing things like this:
foo = Field(FooStr, True, size=14)

And this is what set_type kind of looks like:
    def set_type(self, field_type, field_options):
        super(Field, self).set_type(field_type, field_options)
        if issubclass(field_type, FooStr):
            self._interface_type = str
            self.serializer = ""

And I would like to be able to set the size and stuff in options under self.serializer = ""

At some point between April 29 and June 25, 2021 this got addressed


Updated the VAE and GP regression notebook.

Update the VAE and GP regression notebook with additional content.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Codecov Report

Merging #174 into develop will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           develop    #174      +/-   ##
==========================================
+ Coverage     88.1%   88.1%   +<.01%
==========================================
  Files           79      79
  Lines         4001    4002       +1
  Branches       680     680
==========================================
+ Hits          3525    3526       +1
  Misses         308     308
  Partials       168     168

Impacted Files
Coverage Δ

mxfusion/modules/gp_modules/svgp_regression.py
97.43% <100%> (+0.01%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf19138...d311f86. Read the comment docs.


BUG: cannot import name '_get_dtype' from 'scipy.sparse.linalg.interface'

Describe your issue.

Hello,
I'm quite new to Python. Currently, I'm trying to use the _get_dtype function from scipy and got this error. Can someone help me? I tried install-uninstall difference versions of other packages. It still happens.
Reproducing Code Example
import scipy.sparse.linalg.interface
from scipy.sparse.linalg.interface import _get_dtype

Error message
cannot import name '_get_dtype' from 'scipy.sparse.linalg.interface'

SciPy/NumPy/Python version and system information
python : 3.10.12
scipy : 1.11.2
numpy : 1.24.3

Hi @mirmusz , could I ask why you are trying to import _get_dtype? The name starting with an _ means that it is not a part of the public API of scipy.sparse.linalg (https://docs.scipy.org/doc/scipy/reference/sparse.linalg.html), so it is not intended for end-users (just internal SciPy use).
If you really want to import this function, you can do so by using:
from scipy.sparse.linalg._interface import _get_dtype

However, this is not recommended as it could break in a future version of SciPy. There is no guarantee that private functions stay in the same place (or stay in the project at all).
If you just want to use the function in your own project, I recommend copying it to your own files:
def _get_dtype(operators, dtypes=None):
    if dtypes is None:
        dtypes = []
    for obj in operators:
        if obj is not None and hasattr(obj, 'dtype'):
            dtypes.append(obj.dtype)
    return np.result_type(*dtypes)

Note: please keep in mind SciPy's license if using any of its code in your own work: https://github.com/scipy/scipy/blob/main/LICENSE.txt

As @lucascolley this function is not designed for public consumption

Hi @lucascolley and @j-bowhay , thank you for the reply. Actually I'm using pylops-distributed for my study and the error is coming when using the package and the pylops-distributed is calling for the _get_dtype
Here is the example of the codes:

I'm not sure why.

I would raise this as an issue with pylops

Noted that. Thanks.


printing not correct for landscape

This pdf file is landscape, and is displayed as such in the browser.  When I print it, it appears as half of a portrait page. If I use Print Preview I can change to landscape but I don't want to have to remember to do this.
Sample file - http://services.land.vic.goc.au/pdfjs/map1.pdf
Screen grab - http://services.land.vic.goc.au/pdfjs/map1.jpg

Does anyone have any fix for this issue?

Acrobat has an orientation parameter in the printing  dialog that can be set to auto, such as in:

Image linked from Adobe and it has another property selected.
Maybe it would be helpful that PDF.js implements page auto-orientation as default.

Could something like this help in adapting to the unknown orientation the browser will use:
@media print and (orientation: portrait) {
  /* Rotate page if it is landscape */
}
@media print and (orientation: landscape) {
  /* Rotate page if it is portrait */
}

I've changed the following lines of code:
return pagesOverview.map(function (size) {         if (isFirstPagePortrait === (0, _ui_utils.isPortraitOrientation)(size)) {           return size;         }
to
return pagesOverview.map(function (size, index) {         if ((index == 0 && isFirstPagePortrait || index > 0 && (0, _ui_utils.isPortraitOrientation)(size))) {           return size;         }
and it works fine for me. Didn't test it much, since our app with embedded PDF.js will be deployed to end users in fall.

Closing since this is fixed by the PR above.


Pagination: possibility of combining active and disabled on page-item

I am asking for this feature because I can't think of an example where I would need to click on the active item in a pagination component. If I leave it active, the cursor shape on hover invites the user to click there, even if I disabled any action on that click.
Thanks in advance

First of all, thanks for the explanation. I reviewed again my code looking for what made me asking this, and I found that bootstrap.css does the following on disabled page-item's:
.page-item.disabled .page-link {
  color: #6c757d;
  pointer-events: none;
  cursor: auto;
  background-color: #fff;
  border-color: #dee2e6;
}

I think that pointer-events: none; is affecting the behavior of the page-link. And even that cursor:auto; makes cursor look different than when hovering active elements.

It makes sense to be able to click on an active link(tab) for reloading, so that you can click the "Issue" tab on this page. Of course, there are cases where you want to be disabled it, but that is by design. Bootstrap is taking an "clickable active" approach.


GitLab CI external repo

Resolves #1044
It is common for code repos to be hosted on Github while using
Gitlab only as a CI/CD service.
Info on using Gitlab only as CI/CD service for external repos:
https://docs.gitlab.com/ee/ci/ci_cd_for_external_repos/
Current limitations:

Unfortunately, Gitlab currently does not expose the external repo's
url, so users will have to manually set the repo's URL as an ENV var
DANGER_PROJECT_REPO_URL
(for ex., DANGER_PROJECT_REPO_URL=https://github.com/procore/blueprinter).
Additionally, RequestSources::Github#validates_as_ci? is tricky now because
the git remote -v returns origin as gitlab.com rather than github.com. The
reasoning is that even though the actual repo is on Github.com, GitlabCI maintains a
mirror on Gitlab.com and the CI checkout the code from the Gitlab.com mirror.

          1 Error

:no_entry_sign:
Please include a CHANGELOG entry.
You can find it at CHANGELOG.md.

  Generated by :no_entry_sign: Danger

I applied your suggestions @yg
Please let me know if anything else requires changing.

@orta What do you think of this and are there any changes you want to see?

If you rebase I'll merge 👍

          1 Error

:no_entry_sign:
Tests have failed, see below for more information.

Tests:

File
Name

gitlab_spec.rb
Danger::RequestSources::GitLab valid server response #update_pull_request! supports inline comments deletes non-sticky comments if no violations are present

gitlab_spec.rb
Danger::RequestSources::GitLab valid server response #update_pull_request! supports inline comments edits existing inline comment instead of creating a new one if file/line matches

gitlab_spec.rb
Danger::RequestSources::GitLab valid server response #update_pull_request! supports inline comments deletes inline comments if those are no longer relevant

gitlab_spec.rb
Danger::RequestSources::GitLab valid server response #update_pull_request! supports inline comments skips inline comments for files that are not part of the diff

  Generated by :no_entry_sign: Danger

          1 Error

:no_entry_sign:
Tests have failed, see below for more information.

Tests:

File
Name

gitlab_spec.rb
Danger::RequestSources::GitLab valid server response #update_pull_request! supports inline comments edits existing inline comment instead of creating a new one if file/line matches

gitlab_spec.rb
Danger::RequestSources::GitLab valid server response #update_pull_request! supports inline comments deletes non-sticky comments if no violations are present

gitlab_spec.rb
Danger::RequestSources::GitLab valid server response #update_pull_request! supports inline comments deletes inline comments if those are no longer relevant

gitlab_spec.rb
Danger::RequestSources::GitLab valid server response #update_pull_request! supports inline comments skips inline comments for files that are not part of the diff

  Generated by :no_entry_sign: Danger

@orta, I rebased the PR, but tests are failing because a new gitlab gem was released on July 6th, v4.16.0, and it contains a bug: https://github.com/NARKOZ/gitlab/issues/574
I believe a solution would be to specify gitlab < 14.6.0

Nah, not need to lock. I don't want to be accidentally missing something in the future by locking the version. I'm OK with CI being red until it's figured out, there's enough greens to validate that you didn't break something.

@orta, I rebased the PR, but tests are failing because a new gitlab gem was released on July 6th, v4.16.0, and it contains a bug: NARKOZ/gitlab#574
I believe a solution would be to specify gitlab < 4.16.0

I've released version 4.16.1 with a fix.

<3


Allow scala version to be explicitly declared

Fixes #18435 by allowing scala version to be declared and adding scala dependency automatically.
Fixes #27309 by avoiding detached configurations
Provides workaround for #27226, since scala version inferring can be completely bypassed with this new API
Reviewing cheatsheet
Before merging the PR, comments starting with

❌ ❓must be fixed
🤔 💅 should be fixed
💭 may be fixed
🎉 celebrate happy things

@bot-gradle test this

I've triggered the following builds:

Pull Request Feedback (Trigger) (Check)

Build Scan

The following builds have failed:

Pull Request Feedback (Trigger) (Check)

Build Scan

@bot-gradle test this

I've triggered the following builds:

Pull Request Feedback (Trigger) (Check)

Build Scan

The following builds have passed:

Pull Request Feedback (Trigger) (Check)

Build Scan

This looks like it would fix https://github.com/gradle/gradle/issues/29286 as well


Feature Request: WMS/WMTS

Hi, would it be possible to integrate WMS/WMTS as user defined layer?

A WMTS service compatible with the OSM/Leaflet tile definition and projection should work, like that:
http://gpp3-wxs.ign.fr/6qyeeg75b526mac4g4qmjazn/wmts?LAYER=GEOGRAPHICALGRIDSYSTEMS.MAPS.SCAN-EXPRESS.STANDARD&EXCEPTIONS=text/xml&FORMAT=image/jpeg&SERVICE=WMTS&VERSION=1.0.0&REQUEST=GetTile&STYLE=normal&TILEMATRIXSET=PM&&TILEMATRIX={z}&TILEROW={y}&TILECOL={x}
or
https://sgx.geodatenzentrum.de/wmts_topplus_open/tile/1.0.0/web/{Style}/{TileMatrixSet}/{TileMatrix}/{TileRow}/{TileCol}.png
as
https://sgx.geodatenzentrum.de/wmts_topplus_open/tile/1.0.0/web/default/WEBMERCATOR/{z}/{y}/{x}.png
WMS and extended WMTS support would require choosing and extending one or two Leaflet plugins.
See #294.

Thanks for the explanation.


move classes from oeo-shared(-axioms) to original modules

Summary of the discussion
From #1592
Type of change (CHANGELOG.md)
Added

Added a new class #

Updated

Updated a definition #

Removed

Removed a broken link #

Workflow checklist
Automation
Closes #
PR-Assignee

[ ] 🐙 Follow the Pull Request Workflow
[ ] 📝 Update the CHANGELOG.md
[ ] 📙 Add #'s to term tracker item

Reviewer

[ ] 🐙 Follow the Reviewer Guide
[ ] 🐙 Provided feedback and show sufficient appreciation for the work done

Special to dos for this PR
After moving all classes we should clean the files by checking oeo-shared and oeo-shared-axioms for remnants of classes (unnecessary class declarations) and delete them.

[ ] oeo-shared
[ ] oeo-shared-axioms

Also there are classes (e.g. person) which in the end stay untouched in oeo-shared. For those we do not need an updated term tracker item. Deleting for them the addition to the term tracker would reduce the overall change that we eventually bring to the dev branch.

[ ] Check term tracker items of remaining oeo-shared classes for unnecessary term tracker additions.

In the end, oeo-shared-axioms should contain no annotations (except term tracker items that might be fine in some cases). Especially there should be no definitions in oeo-shared-axioms.

[ ] Checked: No definitions in oeo-shared-axioms.
[ ] Checked: No other unnecessary annotations in oeo-shared-axioms.

TODO: After moving all classes we should clean the files by checking oeo-shared and oeo-shared-axioms for remnants of classes (unnecessary class declarations) and delete them.

[ ] oeo-shared
[ ] oeo-shared-axioms

From the ToDos:

Also there are classes (e.g. person) which in the end stay untouched in oeo-shared. For those we do not need an updated term tracker item. Deleting for them the addition to the term tracker would reduce the overall change that we eventually bring to the dev branch.

I had in mind that we wanted to add the term tracker "rework module structure" to the classes that remain in oeo-shared on purpose. It would indicate, that they stay there intentiuonally, and were not just forgotten. But we can discuss that.

I had in mind that we wanted to add the term tracker "rework module structure" to the classes that remain in oeo-shared on purpose. It would indicate, that they stay there intentiuonally, and were not just forgotten. But we can discuss that.

If this is the purpose, then we should have it at all entries in oeo-shared and not only some. In the current state, only some entries will get a changed term tracker items and some not.

Ups! I thought I was pushing the whole time to a new branch, my bad

I will work further in a new branch, please let me know if anything from the last commits needs to be fixed

As far as I see, PR #1697 of @areleu is the last class moving PR that has to integrated here, right?

All PRs are merged now.
I start now with checking double definitions and axioms in oeo-shared-axioms.

Some bugs I found when opening the modules separately:
oeo-physical:

Potential solutions:

Move direct equivalent method, physical method and substitution method to oeo-model where already their parent class primary energy consumption calculation method (OEO_00010296) is.
OEO_00030015 is energy system model in oeo-model, hence the axiom 'energy system model' models some 'energy system' has to be moved to oeo-shared-axioms.

oeo-social:

Potential solutions:

Move energy demand, electricity demand and fuel demand to oeo-physical, where already their parent demand (OEO:00140040) is.
Move CO2 emission value to oeo-physical, where already its parend emission value (OEO_00260008) is.

There are still some duplicated annotations and/or axioms in oeo-shared-axioms for the following classes:

[ ] life cycle assessment (annotations and axioms)
[ ] unit of measurement (duplicated SubClassOf axiom)
[ ] kilowatt-hour (duplicated annotations)
[ ] prefix (tripled(!) SubClassOf axiom)
[ ] person and organisation role (duplicated DisjointWith axiom)
[ ] study (annotations and axioms)
[ ] process attribute (duplicated SubClassOf axiom)
[ ] emission value (duplicated axiom 'has economic value' some 'social cost of emission')

Further bugs:

[ ] economic life time is now a subclass of both time span and operational life time. According to its defintion[^1] its parent should be `operational life time
[ ] spatial resolution and temporal resolution have their DisjointWith axiom in oeo-shared-axioms. This should be moved to oeo-model where both classes are.

[^1]: An economic life time is the operational life time during which an artificial object is profitable to the owner.

@stap-m @areleu : How do we finalise the remaining work of this PR? Directly with commits to the branch feature-1592-move-classes-to-original-modules or like with the moves with side branches and PRs?

@stap-m @areleu : How do we finalise the remaining work of this PR? Directly with commits to the branch feature-1592-move-classes-to-original-modules or like with the moves with side branches and PRs?

As I wrote above, I already started checking and cleaning the doubles axioms. I just did not push yet. Let's discuss the rest in person in out meeting today.

[x]  person and organisation role (duplicated DisjointWith axiom)

I was wondering, if this disjointness makes sense. If at all, person and organisation should be disjoint, right?

Thanks for the good teamwork @l-emele @areleu @nelekoehler @chrwm !!


Upgrade to 2.13.0-M5

To validate this pull request against other sbt modules, please visit this link.

@eed3si9n To correctly upgrade to 2.13.0-M5 I need published versions of:

[ ] scalatest
[ ] sbt-io
[ ] sbt-util-logging
[ ] scalacheck

ScalaTest and ScalaCheck have both published JVM artifacts for M5.
can sbt-io and sbt-util-logging be published...?

See https://github.com/sbt/zinc/pull/453. The compiler bridge itself depends only on compiler|util-interface, which are both Java library. What requires IO and Util Logging is the unit tests for compiler bridge for making a harness for testing called ScalaCompilerForUnitTesting - https://github.com/sbt/zinc/blob/v1.2.3/internal/compiler-bridge-test/src/test/scala/xsbt/ScalaCompilerForUnitTesting.scala
As it stands, we should be able to proceed without the unit test.
We can still do testing using the scripted test, which accepts scalaVersion. I put them in, but it seems like they were removed in https://github.com/sbt/zinc/pull/584/commits/d5b8a53b14e28c07044065d1c9aecea115fdde2c. The bridge check scripted tests go through the motion of actually compiling something, so I think we should bring them back as a quick check that the bridge functions.
We should then port the compiler bridge unit tests to actual Zinc harness that does not require IO and Util cross built to 2.13.0-M5. Getting Util Logging to compile is going to take a while since it depends on series of (somewhat old) JSON libraries.

We should then port the compiler bridge unit tests to actual Zinc harness that does not require IO and Util cross built to 2.13.0-M5.

https://github.com/sbt/zinc/pull/607

This was superseded by https://github.com/sbt/zinc/pull/607


Css loader doesn't load css code as in example

From the css-loader docs this should be possible:
./App.js
const css = require('./App.css').toString()
console.dir(css)

But instead it returns an empty object.

Works in the server, so probably MiniCssExtractPlugin or OptimizeCSSAssetsPlugin causes this.

Works in the server, so probably MiniCssExtractPlugin or OptimizeCSSAssetsPlugin causes this.

https://github.com/jaredpalmer/razzle/issues/1591#issuecomment-813474885

https://razzlejs.org/docs/customization#css-modules
Use import and not require


Add Slider Dungeon

[ ] Structure
[ ] Sliders
[ ] Slider Boss
[ ] Loot tables for chests

No longer a dungeon we are allowed to make

No longer a dungeon we are allowed to make
what???

Sliders are Aether IP and so we will not be making a slider dungeon since we are not allowed to use their ideas. Dungeons will be added but not a slider dungeon


RFC: Major redesigns

First of all, master is currently breaking from 0.18, so hold off on publishing a new version until this issue is resolved.
async-graphql, as it is, has a bit of a confusing API. I propose a major overhaul of many parts to it, which I think will simplify things.
First of all, we can make a fully public Query type. It should look something like this:
pub struct Query {
    pub source: String,
    pub operation_name: Option<String>,
    pub variables: Variables,
    pub ctx_data: Data,
}

It should have many helper functions, similar to the QueryBuilder today. I'm not sure about whether to add extensions to the query struct - is it necessary, since extensions can be added to the schema also?
Then, Schema can be simplified to just two main methods:
async fn execute_query(&self, query: Query) -> QueryResponse;
async fn execute_query_stream(&self, query: Query) -> impl Stream<Item = QueryResponse>;

The Result<QueryResponse> can be replaced with adding an errors field to the QueryResponse; this will make more sense to people who are used to GraphQL as from the spec:

If the operation encountered any errors, the response map must contain an entry with key errors.

If we then allow the QueryResponse to be serialized we can ditch the GQLResponse entirely. Similarly, allowing Query to be deserialized allows us to ditch GQLRequest
Calling execute_query_stream on a query or mutation will just send one result, and calling execute_query on a subscription will panic.
Now that Schema has been reduced to a GraphQL-only API instead of handling lots of things including the transport, we could remove the ConnectionTransport trait altogether since it's handled at a higher level.
We can then feature-gate (or maybe move into a separate crate) the WebSocket implementation. Since it's no longer restricted by the ConnectionTransport trait it can have any API that is appropriate for it, I'm thinking that it could just wrap a Schema and AsyncRead + AsyncWrite.
Handling Multipart can be as simple as having a function:
pub async fn receive_multipart(multipart: impl AsyncRead) -> Query;

And also:
pub async fn receive_request(content_type: Option<impl AsRef<str>>, body: impl AsyncRead) -> Query;

Which is the same code as impl IntoQueryBuilder for (Option<CT>, Body) we had before.

I think this suggestion is very good, but since Async-graphql has been used by many projects(https://github.com/timberio/vector), I hope to create a new 2.0 branch and make changes based on that branch. At this stage, I don't want a lot of breaking changes in the 1.x version. 🙂

It should have many helper functions, similar to the QueryBuilder today. I'm not sure about whether to add extensions to the query struct - is it necessary, since extensions can be added to the schema also?

It may be necessary, but I am not sure, for example, allowing different extensions to be applied to different queries?

The naming of Query may conflict with the schema definition. How about GQLQuery?

I am trying to refactor and when I am almost done, I will submit a PR.

I don't know whether we should have the GQL prefix, it feels like duplication from the crate name; async_graphql::GQLQuery has GQL twice. It makes more sense for users to use async_graphql as gql; gql::Query or use async_graphql::Query as GQLQuery if they want that.

I don't know whether we should have the GQL prefix, it feels like duplication from the crate name; async_graphql::GQLQuery has GQL twice. It makes more sense for users to use async_graphql as gql; gql::Query or use async_graphql::Query as GQLQuery if they want that.

Yes, I don't like the name GQLQuery, but if it is named Query, there will be a lot of conflicts. 😂

Maybe Request would work. It would also be symmetric with Response.


Only show the favorite charts in a dashboard on user level

Is your feature request related to a problem? Please describe.
We maintain a dashboard for a project. We have 20+ projects ongoing. We usually have 500+ charts on each of the projects. We have to use the tabs in each of dashboards to group charts together that lie on the similar interests.
Usually, we have 40+ charts in one tab. However, the people who look at the same tab in the same project (dashboard) might not need to be interested in all of 40 charts. They might just be interested in some of them. So having the favorite charts in user level in a dashboard would be very helpful for us. It's even more beneficial to our customers when we turn on the alert and reporting so that our customers can receive the charts that they like in email.
Describe the solution you'd like
On each of the dashboards that users allow to view, If user add one of the charts in favorite, then the dashboard will show the favorite charts only. This favorite charts might be different from those favorite charts on chart list though.
Describe alternatives you've considered
The favorite charts on charts list could be combined with the favorite charts within a dashboard. It would be up to your team to decide the best solution
Additional context
Add any other context or screenshots about the feature request here.

You could use DASHBOARD_RBAC feature flag and the assign users to roles and roles to dashboard for user to be able to access specific dashboards
Other then that, favourite are just an application attribute on top of access

Now I see you were asking for charts .
Such functionality does not exist and you'd better separate to different dashboards logically

@graceguo-supercat @etr2460
You are familiar with such a setup mentioned above , maybe you can shed light on how this is done on your side ?

Hi @kevinwen2k @amitmiran137, in airbnb we have some use cases like a large dashboard shared by different teams with 500+ unique users per week. For dashboard with 40+ charts in one dashboard view, the dashboard performance will be really bad. If user apply dashboard filters and filter apply to all charts in the current view, the perf is even worse that may freeze browser.
I don't think make dashboard show favorite charts only solution will work. This problem is more like how to organize large number of charts (or large amount of data), simply hide and show inside a single dashboard can't handle it completely.

Tab(s) and nested tabs are supposed to organize data inside dashboard. If each tab has  a lot charts and impacts performance, please consider create multiple dashboards.
another use case is, all users shared a big set of charts, but each user only care a small set of charts, and each users' interested charts are not overlap. You should consider let user to build their own dashboard, but pick charts from the same pool. So that the same chart will be re-used in different dashboards. And once the chart is updated, all different dashboard should show this change accordingly.