2022/23 Software Architecture and Communication

Change Summary
[Briefly summarise the changes that you made. Just high-level stuff]
Change Form
Fill this up (NA if not available). If a certain criteria is not met, can you please give a reason.

[ ] The pull request title has an issue number
[ ] The change works by "Smoke testing" or quick testing
[ ] The change has tests
[ ] The change has documentation

Other Information
[Is there anything in particular in the review that I should be aware of?]

Looks good to me! But I kind of wished it showed one of the importance of MVC - if you follow the pattern, you can replace each component with a particular set of framework... This is what makes it easy to switch from one framework to another if one understands what they represent

It's in my speech when talking about the pros of MVC under the point of "does great job at separating concerns"

But thank you, Frinze!


CE NAME

About the Prison Core and Advanced Enchantment
Then i drag book and into pickaxes, then the ce Name Trench that gotten remove name however it still work with mining ,
look at the site
https://gyazo.com/7d7114507f31ff93c04831d2da5b1ca0
Please reslove this

Hello, currently you can't use another Enchantments plugin along with our enchantment system. That does not make sense. Please decide whether to use our enchanting system or someones else.


Remove GlusterFS bits

This PR removes unused GlusterFS descriptors, scripts, Ansible tasks, and README instructions.
There main issue we have now is that some workloads were using the glusterfs storage class (which we didn't use, yet).
Close #120

if there are workloads that are using the glusterfs storage... we could tag a version as the latest one that supports glusterfs ??

It's the 2.1.0 (tagged this morning)


[Enhancement] Reduce the Fade In/Fade Out Animation Time for Viewer UI elements

Is your feature request related to a problem? Please describe.
Currently, the UI elements take almost an entire second to appear and then vanish when the screen is tapped. This makes taking actions on the images delayed and sluggish.
Describe the solution you'd like
Reducing the duration of the animation to somewhere between 300ms - 500ms would be awesome.
Describe alternatives you've considered
The only alternative at present is to wait that entire duration for the UI elements to appear or disappear.
Additional context
Adding screen recordings from Google Photos & the Fossify Gallery app as references.
Google Photos:
https://github.com/user-attachments/assets/a1c81c36-9a10-4e64-9e06-f85f302cc4b5
Fossify Gallery:
https://github.com/user-attachments/assets/501e6435-c31c-4348-8894-7d9c38a2d3de

Fixed in the latest release


[4283] Fix DQT country mapping

Context
https://trello.com/c/ee2KkgeM/4283-fix-dqt-country-mapping
While investigating an issue with updating a trainee's DQT record, it was discovered that the country value was missing from the DQT payload. Further investigation revealed that the degree country data can sometimes have two variations of the same country, e.g. "Hong Kong" and "Hong Kong (Special Administrative Region of China) [Hong Kong]" or "Iran" and "Iran [Iran, Islamic Republic of]". The Hesa::CodeSets::Countries::MAPPING only holds one variation.
Changes proposed in this pull request

Update Dqt::Params::TrnRequest to lookup country code using partial string search instead of the whole string

Important business

[ ] Does this PR introduce any PII fields that need to be overwritten or deleted in db/scripts/sanitise.sql?
[ ] Does this PR change the database schema? If so, have you updated the config/analytics.yml file and considered whether you need to send 'import_entity' events?

NB: Please notify the #twd_data_insights team and ask for a review if new fields are being added to analytics.yml

 Fix DQT country mapping


[vcpkg] Teach vcpkg.targets to emit a .tlog, enabling up-to-date checks

See title.
Even a no-op check on Windows can take several seconds due to running vcvars.bat. This change fixes this in two ways:

Add Inputs and Outputs to VcpkgInstallManifestDependencies, causing it to not execute vcpkg.exe if the manifest has not been changed.
Add steps to emit a .tlog file, plugging in to the VCTools/MSBuild "fast up to date" system. Without this step, modifying only vcpkg.json will not cause Ctrl-B to actually build anything; with this step, it will correctly invoke vcpkg.exe and rebuild anything that has changed (due to header changes etc).

Due to limitations in the fast up-to-date system, vcpkg.json will be compared against any .ilk files. We therefore need to always trigger a re-link via Link_MinimalRebuildFromTracking=false if vcpkg.json is modified.
@strega-nil @yuehuang010

/azp run

/azp run


Crashes when PropertyChangedEventArgs.PropertyName is null

When using a WhenAny for instance on an object that sends out PropertyChangedEventArgs with PropertyName set to null a NullReferenceException is thrown.
Note that this is valid value according to INotifyPropertyChanged specifications. A workaround is to send an empty string instead of null.
This is a regression by the way, because it worked in the 5 branch.

I'm still getting a NullReferenceException even with this fix, am I missing something ?
I am using nuget version <IP_ADDRESS>
The exception is thrown by x.EventArgs.PropertyName.Equals(memberInfo.Name + "[]") but this piece of code should not even execute....

Ok version <IP_ADDRESS> does not have this fix includedsince nuget package was release on 12 feb and fix is 22 feb. Sorry, my fault.

What do you mean? The fork mentioned above has not been merged.

looking at the history it was merged on 22 feb
https://github.com/reactiveui/ReactiveUI/commits/master/ReactiveUI/INPCObservableForProperty.cs
am I wrong ?
I built the nuget packages from master and used in my prject and the error is gone

i'm not a great expert on github merge, pulls etc etc but I see also a merge done by paulcbetts on 6 april in the master commits log
https://github.com/reactiveui/ReactiveUI/commits/master

@paulcbetts, @jlaanstra or @frogger3d  Could you close this issue? https://github.com/reactiveui/ReactiveUI/pull/811 fix the issue (the same way as I recommended) and has been merged a while ago.


passport-oauth2 update in security-middleware dep

related issue: https://github.com/open-cluster-management/backlog/issues/16636
Signed-off-by<EMAIL_ADDRESS><EMAIL_ADDRESS>

/hold


Eval Problem

Hi,
I trained my own dataset. Then I get the following error when I want to do eval my dataset. There is no clear solution to this error on the Internet. Have you encountered this error? Please help me...

Your GUI is broken.


Update export-user-data-from-project-online.md

Adding documentation about an unsupported scenario

@JohanFreelancer9 Copy editing is needed for this PR. Thanks.

@SerdarSoysal PR has been copyedited and is ready for final review, could you please check and merge? Thanks!


Horizontal scrollbar not working on list

I’m trying to add horizontal and vertical scrollbars in a list, but only the vertical scrollbar works. The horizontal scroll bar is visible but does not move with the mouse (example below).
| list hBar vBar   |
list := ToListElement new nodeBuilder: [ :node :dataItem :holder | | e |
		        	e := BlElement new size: 1000@200.
					e background: Color random.
					node addChild: e ].

list dataAccessor addAll: { <IP_ADDRESS>.<IP_ADDRESS>.9 }.

hBar := BlHorizontalScrollbarElement new
		        constraintsDo: [ :c |
			        c ignoreByLayout.
			        c ignored vertical alignBottom ];
		        yourself.
hBar thumb: (BlElement new
		height: 16;
		geometry: (BlRoundedRectangleGeometry cornerRadius: 10);
		background: Color blue;
		yourself).
hBar track background: Color transparent.
hBar zIndex: 100.
hBar attachTo: list next.

vBar := BlVerticalScrollbarElement new
		        constraintsDo: [ :c |
			        c ignoreByLayout.
			        c ignored horizontal alignRight ];
		        yourself.
vBar thumb: (BlElement new
		width: 16;
		geometry: (BlRoundedRectangleGeometry cornerRadius: 10);
		background: Color blue;
		yourself).
vBar track background: Color transparent.
vBar zIndex: 100.
vBar attachTo: list next.

list addChild: hBar.
list addChild: vBar.
list openInSpace

I found a workaround to get both scroll bars using a ScrollPane.
|pane list vBar scrollableElement hBar scrollPane |

list := ToListElement new nodeBuilder: [ :node :dataItem :holder | | e | e := BlElement new size: 1000@200.
					e background: Color random.
					node addChild: e ].
list dataAccessor addAll: { <IP_ADDRESS>.<IP_ADDRESS>.9 }.

scrollableElement := BlScrollableElement new
		                     constraintsDo: [ :c |
			                     c horizontal matchParent.
			                     c vertical matchParent ];
		                     yourself.

vBar := BlVerticalScrollbarElement new
		        constraintsDo: [ :c |
			        c ignoreByLayout.
			        c ignored horizontal alignLeft ];
		        yourself.

hBar := BlHorizontalScrollbarElement new
		        constraintsDo: [ :c |
			        c ignoreByLayout.
			        c ignored vertical alignBottom ];
		        yourself.

pane := ToPane vertical fitContent.
pane constraints horizontal fitContent.
pane constraints vertical matchParent.

scrollPane := ToPane vertical matchParent.

hBar attachTo: scrollableElement.
vBar attachTo: list next.
list addChild: vBar.
pane addChild: list.
scrollableElement addChild: pane.
scrollPane addChild: scrollableElement.
scrollPane addChild: hBar.

scrollPane openInSpace

thanks for your workaround.
Now this is a real issue with Infinite.
The main direction scrolling is made efficient but the secondary direction scrolling is not managed currently

Hello, after some seconds of scrolling like crazy, I got this error while trying the work-around script:

Running on:

Build information: Pharo-13.0.0+SNAPSHOT.build.253.sha.d44a93265706570936135ce91e2475ab5876aff4 (64 Bit)
Macbook Pro 18

I wonder what is the expected behavior. I'm playing on Mac's Finder (file browser) and notice that when I start scrolling in one of the directions, the other seems to be muted.
I write it in other words, more concrete: I have a window with both bars. I start scrolling down with the trackpad, and in the middle I move finder to the right, and I notice that vertical movement cancels the horizontal movement. But it's not that vertical wins always. If the stronger movement is vertical, then the horizontal is muted.
I may be wrong. What do you think is the expected behavior? I'd like to check how it works typically on Windows now.


[Infra] Beta MacOS arm binaries not showing on docs.flutter.dev

Since the release of the Flutter 3.8 beta, MacOS binaries have not been appearing on the website for the beta channel.
The binaries are available for use however, and the normal flow of upgrading still works.
To verify:
flutter channel beta
flutter upgrade
You should be able to see the new flutter beta.

Does this work on an arm machine? it seems like the packages were never created for arm64

Does this work on an arm machine? it seems like the packages were never created for arm64

The engine binaries already exist on GCS, which is what the tool will pull from after a flutter channel beta && flutter upgrade. We just never generated the compressed archive.

aaaah now I understand, the release bundle does not exist but the engine artifacts do exist. Thanks for the explanation.

The website is now showing 4 different entries for beta 3.9.0-0.1.pre.

That was caused by the direct push to beta. As soon as we get the SLSA workflow ready we'll remove individuals access to prevent this from happening.


Drug repurposing task prediction files?

Hello - I was wondering if the prediction results for the drug repurposing task are available anywhere? I took a look at the supplementary data and this repository, but was unable to find them. This would be a great source of information for mining new drug predictions!

Hi,
thanks a lot for your interest! We used the PrimeKG database and the TxGNN TxData.prepare_split command to generate the splits, which were processed into the right format for BioPathNet. The whole procedure can be reproduced using reproduce/primekg/01_get_datasplit.py, e.g. python 01_get_datasplit.py --seed 42 --split cell_proliferation --source ../data/ .
Hope this helps. Best


The Cron Job

Hello
your guide is great and only one which I managed to integrate and use with HA.
Struggle a little with the Cron job setup.
would this be the way to do it? In this picture the Cron should update every 5 min.
the command after python ... works by it self and it pushed data to HA.
Also I plan to change */5 yo */60 once I figure out how Cron works

getting this error "(CRON) info (No MTA installed, discarding output)"

MTA means "Mail Transport Agent".  Meaning you haven't installed a mail server like Postfix or similar.  So it's just cron saying it can't send you mail.
I think you have one too many '*'s there.

Also, "*/60" is the same as 1-hour.  So if you want it to run every hour, you would do:
0 * * * * python -m ......
and it'll run at the 0th minute every hour.
you have the correct number of '*'s.

it worked, it worked it worked.
had to install Postfix and add MAILTO="" into crontab then it worked.
I have HA showing me the RADON levels!
Thank you, great work!


exception: Cannot find type for ctor #568a748

Version: 3.4.2
When: simple LoginUserIfNeeded and listen updates
An exception occured in the reactor: WTelegram.WTException: Cannot find type for ctor #568a748
   at TL.Serialization.ReadTLObject(BinaryReader reader, UInt32 ctorNb)
   at TL.Serialization.ReadTLValue(BinaryReader reader, Type type)
   at TL.Serialization.ReadTLVector(BinaryReader reader, Type type)
   at TL.Serialization.ReadTLValue(BinaryReader reader, Type type)
   at TL.Serialization.ReadTLObject(BinaryReader reader, UInt32 ctorNb)
   at TL.Serialization.ReadTLValue(BinaryReader reader, Type type)
   at TL.Serialization.ReadTLVector(BinaryReader reader, Type type)
   at TL.Serialization.ReadTLValue(BinaryReader reader, Type type)
   at TL.Serialization.ReadTLObject(BinaryReader reader, UInt32 ctorNb)
   at TL.Serialization.ReadTLValue(BinaryReader reader, Type type)
   at TL.Serialization.ReadTLObject(BinaryReader reader, UInt32 ctorNb)
   at TL.Serialization.ReadTLValue(BinaryReader reader, Type type)
   at TL.Serialization.ReadTLObject(BinaryReader reader, UInt32 ctorNb)
   at TL.Serialization.ReadTLValue(BinaryReader reader, Type type)
   at TL.Serialization.ReadTLVector(BinaryReader reader, Type type)
   at TL.Serialization.ReadTLValue(BinaryReader reader, Type type)
   at TL.Serialization.ReadTLObject(BinaryReader reader, UInt32 ctorNb)
   at WTelegram.Client.ReadFrame(Byte[] data, Int32 dataLen)
   at WTelegram.Client.Reactor(Stream stream, CancellationTokenSource cts)

ERROR While deserializing vector<%Message>: WTelegram.WTException: Cannot find type for ctor #568a748
   at TL.Serialization.ReadTLObject(BinaryReader reader, UInt32 ctorNb)
   at TL.Serialization.ReadTLValue(BinaryReader reader, Type type)
   at TL.Serialization.ReadTLVector(BinaryReader reader, Type type)
   at TL.Serialization.ReadTLValue(BinaryReader reader, Type type)
   at TL.Serialization.ReadTLObject(BinaryReader reader, UInt32 ctorNb)
   at TL.Serialization.ReadTLValue(BinaryReader reader, Type type)
   at TL.Serialization.ReadTLVector(BinaryReader reader, Type type)
   at TL.Serialization.ReadTLValue(BinaryReader reader, Type type)
   at TL.Serialization.ReadTLObject(BinaryReader reader, UInt32 ctorNb)
   at TL.Serialization.ReadTLValue(BinaryReader reader, Type type)
   at TL.Serialization.ReadTLObject(BinaryReader reader, UInt32 ctorNb)
   at TL.Serialization.ReadTLValue(BinaryReader reader, Type type)
   at TL.Serialization.ReadTLObject(BinaryReader reader, UInt32 ctorNb)
   at TL.Serialization.ReadTLValue(BinaryReader reader, Type type)
   at TL.Serialization.ReadTLVector(BinaryReader reader, Type type)
   at TL.Serialization.ReadTLValue(BinaryReader reader, Type type)
   at TL.Serialization.ReadTLObject(BinaryReader reader, UInt32 ctorNb)
   at WTelegram.Client.ReadMsgContainer(BinaryReader reader)

Such errors may happen initially (right after LoginUserIfNeeded) when you just updated your version of WTelegramClient.
(this is because old updates based on previous version of the API layer have accumulated while your client was stopped)
In which case, some errors like this may show up in the logs but WTelegramClient should be able to ignore the errors and continue execution normally. After the initial batch of updates, that error should not show up again.
Keep me informed if you still see this error (for that user account), or if it no longer happens.

should me remove .session file and relogin?
i see this errors already few days...

can you provide some logs?

should me remove .session file and relogin? i see this errors already few days...
i see no reason this would help

WorkerService.Threads.RealtimeCmdThread.log

a temporary workaround should be to downgrade to WTC v3.3.3 or 3.3.2

see also https://t.me/tdlibchat/71969

In any case, I will close this issue because I don't think it's an issue in the library, it's server-side so this problem should be tracked with Telegram teams.


cmd/go: GO19CONCURRENTCOMPILATION not working as expected

Please answer these questions before submitting your issue. Thanks!
What version of Go are you using (go version)?
go1.9rc1
What operating system and processor architecture are you using (go env)?
linux/amd64
What did you do?
time GO19CONCURRENTCOMPILATION=1 go1.9rc1 build ./*.go

vs.
time GO19CONCURRENTCOMPILATION=0 go1.9rc1 build ./*.go"

If possible, provide a recipe for reproducing the error.
This was tested with github.com/ponzu-cms/ponzu by running:
$ go get github.com/ponzu-cms/ponzu/...
$ ponzu new github.com/nilslice/go19test
$ cd $GOPATH/src/github.com/nilslice/go19test
$ time GO19CONCURRENTCOMPILATION=0 ponzu build --gocmd=go1.9rc1
# (equal to: time GO19CONCURRENTCOMPILATION=0 go1.9rc1 build cmd/ponzu/*.go)
# vs.
$ time GO19CONCURRENTCOMPILATION=1 ponzu build --gocmd=go1.9rc1
# vs.
$ time ponzu build # with go 1.8.3

A link on play.golang.org is best.
What did you expect to see?
I expected to see the build time / CPU usage change more dramatically when toggling concurrent compilation with the GO19CONCURRENTCOMPILATION var set/unset.
What did you see instead?
# go 1.9 with concurrent compilation
time GO19CONCURRENTCOMPILATION=1 go1.9rc1 build -o ponzu-server cmd/ponzu/*.go
GO19CONCURRENTCOMPILATION=1 go1.9rc1 build -o ponzu-server cmd/ponzu/*.go  8.62s user 0.43s system 249% cpu 3.628 total
# ---

# go 1.9 without concurrent comilation
time GO19CONCURRENTCOMPILATION=0 go1.9rc1 build -o ponzu-server cmd/ponzu/*.go
GO19CONCURRENTCOMPILATION=0 go1.9rc1 build -o ponzu-server cmd/ponzu/*.go  8.80s user 0.51s system 245% cpu 3.787 total
# ---

# go 1.8.3
time ponzu build # with go1.8.3 linux/amd64
ponzu build  17.48s user 0.96s system 278% cpu 6.630 total

It appears that there is no difference with or without GO19CONCURRENTCOMPILATION feature, and after looking through go/internal/work/build.go, it seems that the -C or -c flag is not defined, which the surrounding code suggests it would influence the parallel build. In fact, running the build command with either of these flags explicitly set causes a failure: flag provided but not defined: -C or flag provided but not defined: -c
I may have this all wrong, and I couldn't create a more concurrent-happy build (so it may just be that parallel compilation doesn't help me much), but I thought I'd still report what I dug up!

@josharian

I just realized the -c flag is nested in -gcflags , which my initial tests did not reflect.. here are the same ones under go1.9, still showing little or no difference among them.
time GO19CONCURRENTCOMPILATION=0 go1.9rc1 build -gcflags=-c=1 -o ponzu-server cmd/ponzu/*.go
GO19CONCURRENTCOMPILATION=0 go1.9rc1 build -gcflags=-c=1 -o ponzu-server   1.50s user 0.16s system 132% cpu 1.259 total

# ---

time GO19CONCURRENTCOMPILATION=1 go1.9rc1 build -gcflags=-c=1 -o ponzu-server cmd/ponzu/*.go
GO19CONCURRENTCOMPILATION=1 go1.9rc1 build -gcflags=-c=1 -o ponzu-server   1.48s user 0.19s system 132% cpu 1.255 total

# ---

time GO19CONCURRENTCOMPILATION=1 go1.9rc1 build -gcflags=-c=2 -o ponzu-server cmd/ponzu/*.go
GO19CONCURRENTCOMPILATION=1 go1.9rc1 build -gcflags=-c=2 -o ponzu-server   1.74s user 0.14s system 139% cpu 1.346 total

# ---

time GO19CONCURRENTCOMPILATION=1 go1.9rc1 build -gcflags=-c=4 -o ponzu-server cmd/ponzu/*.go
GO19CONCURRENTCOMPILATION=1 go1.9rc1 build -gcflags=-c=4 -o ponzu-server   1.71s user 0.19s system 113% cpu 1.680 total

Assigning to @josharian .  We can still get doc changes into 1.9 if appropriate.

Thanks for the report.
I took a look at package github.com/ponzu-cms/ponzu/cmd/ponzu. Concurrent compilation is working as anticipated, and seems to have an impact in the 30-35% range. However, build time for this package is dominated the by linker, you so can't really tell.  On my machine, I see concurrent compilation taking ~0.09s and non-concurrent compilation taking ~0.14s. Linking takes about 0.65s. There's another 0.25s spend in the go command itself and related overhead, like making directories and moving files around, for a total of ~1s. So the 0.05s (35%) that concurrent compilation buys here ends up being only 5% in the context of the complete build, in this particular case.
As for the place where "nBackendWorkers is set to 1", that's addressed in change 41503, which was intentionally held for 1.10. But it's not obvious to me that that is an important factor in this case. If you want to experiment, or if that change makes your life much better now, feel free to cherry-pick that change and rebuild the toolchain.
So I think everything is working as intended here. I don't see any obvious doc changes to make, although I'm open to suggestions.
For now, I'm going to close this, but will re-open if there's new information or suggestions.

-toolexec='time'

That's cool. Wasn't aware of this -- thanks for pointing it out.

As for the place where "nBackendWorkers is set to 1", that's addressed in change 41503, which was intentionally held for 1.10. But it's not obvious to me that that is an important factor in this case. If you want to experiment, or if that change makes your life much better now, feel free to cherry-pick that change and rebuild the toolchain.

I see -- thank you for pointing this out as well. I couldn't tell how much of each package could be compiled before the nBackendWorkers was reduced there, or if it was done prior to any compilation in some cases.
This was reported entirely out of experimentation, and I hope it didn't cause you many wasted cycles :grimacing: .. figured I would share what I was seeing before 1.9 hits master. The concurrent compilation is a great feature - thank you for your work on it!! If I have any doc suggestions pre 1.10, I will report back here.

I couldn't tell how much of each package could be compiled before the nBackendWorkers was reduced there

FWIW, this makes a noticeable difference in (generally autogenerated) packages that define thousands of types.

figured I would share what I was seeing before 1.9 hits master.

Appreciated! Very glad you're kicking the tires.


Added Direct Download Link

Description
Adds a small url to the sideload download page to directly download the package
Motivation and Context
As a workaround for those not using Windows 10/11, and the ms-appinstaller protocol being disabled
Screenshots:

I'm working on a new download page right myself, so this won't be needed.


[6.4.x] JBPM-5398 - Transaction issues with Timer catch event

@sutaakar here is a change we talked about that should fix the problem with kie server tests

jenkins retest this

jenkins retest this

won't be included in 6.4.x


Single line functions - trying to fit too much on one line

E.g.,
-    fn read_struct<T, F>(&mut self, s_name: &str, len: usize, f: F)
-                         -> Result<T, Self::Error>
-        where F: FnOnce(&mut Self) -> Result<T, Self::Error>;
+    fn read_struct<T, F>(&mut self, s_name: &str, len: usize, f: F) -> Result<T, Self::Error> where F: FnOnce(&mut Self) -> Result<T, Self::Error>;

This has been fixed by @Marwes! :tada:


Add timezone role

This way we can cleanup some inline tasks in several Freyfiles

Good stuff! Can you please also add an entry to CHANGELOG.md as part of this PR?

Sure

Do you want me to update the changelog every pull request?

Yes that would be great 👌 Currently I'm updated the changelog myself but it's harder to keep track that way, so I think they feature changes / bugfixes might as well carry themselves into the CHANGELOG 👍

Will do!

Done


[bug]: Dialog / AlertDialog not styled properly

Describe the bug
Description:
I am encountering an issue with the styling of Dialog and AlertDialog components in my project. Despite following the documentation, the components do not render as expected, and the styling appears to be broken or missing. I am unsure of the root cause and have tried to troubleshoot without success.
import { Button } from "@/lib/shadcn/ui/button";
import {
  Dialog,
  DialogContent,
  DialogDescription,
  DialogFooter,
  DialogHeader,
  DialogTitle,
  DialogTrigger,
} from "@/lib/shadcn/ui/dialog";

export const AlertDialog = () => {
  return (
    <Dialog>
      <DialogTrigger asChild>
        <Button variant="outline">Edit Profile</Button>
      </DialogTrigger>
      <DialogContent className="sm:max-w-[425px]">
        <DialogHeader>
          <DialogTitle>Edit profile</DialogTitle>
          <DialogDescription>
            Make changes to your profile here. Click save when you're done.
          </DialogDescription>
        </DialogHeader>
        <DialogFooter>
          <Button type="submit">Save changes</Button>
        </DialogFooter>
      </DialogContent>
    </Dialog>
  );
};

Expected Behavior:
Dialog and AlertDialog should render with the proper styling as documented.
Actual Behavior:
The styling for Dialog and AlertDialog is either missing or broken. The components render with incorrect or no styles applied.
Affected component/components
Dialog, AlertDialog
How to reproduce
Steps to Reproduce:

Install ShadCN components as per the documentation.
Import and use Dialog or AlertDialog in a project.
Observe that the components do not have the correct or expected styling.

Codesandbox/StackBlitz link
https://ui.shadcn.com/docs/components/dialog
Logs
No response
System Info
**Environment:**
- **Framework:**<EMAIL_ADDRESS>- **Browser:** Chrome / Brave
- **OS:** Windows
- **Node.js version:** 20.14.0

Before submitting

[X] I've made research efforts and searched the documentation
[X] I've searched for existing issues

can you assign me this issue would love to resolve it

@Gurvinder-Singh02 Do you have an idea about what is causing such behavior?

Am hoping to use this Component asap, so would be good to know what's causing this bug.

Yeah i think it would be issue in tailwind.config but will figure out the root cause if you assign it to me

@imMatheus Tailwind is working as expected, all other shadcn component works as expected except for the Dialog and the AlertDialog

@imMatheus Tailwind is working as expected, all other shadcn component works as expected except for the Dialog and the AlertDialog

@bennaaym Alright, could it be possible for you to create a codesandbox or similar, I cant seem to reproduce this issue :/

My guess would be as Dialog and AlertDialog are rendered in a portal, that could mess something up. Im thinking ig all other shadcn components are working but these components in a protal don't work, that seems like it could be the issue in some way :)

As @imMatheus , the styling issues are occurring because these components are being rendered in a portal.
I was experiencing some styling issues as well and I believe I was able to find a solution. I am using pages router, but I believe this should work for app router projects as well.
I was mainly having issues with typography in dialog and alert components. The font for these components was defaulting to times new roman, instead of jakarta sans which I chose for my project.
1 - export my font variable from the _app.tsx file:
export const jakartaSans = Plus_Jakarta_Sans({
  subsets: ['latin'],
  variable: '--font-jakarta-sans',
});

2 - import this variable in the _document.tsx file and add the following to the html element:
import { Html, Head, Main, NextScript } from 'next/document';
import { jakartaSans } from './_app';
export default function Document() {
  return (
    <Html lang='en' className={jakartaSans.variable}>
      <Head />
      <body className='antialiased'>
        <Main />
        <NextScript />
      </body>
    </Html>
  );
}

Adding the font variable to the HTML element ensures that the font is available at the root level, which means it should be inherited by all elements, including portal elements.
I came up with this solution after reading through Radix's typography documentation, since I tried implementing my own dialog component usin Radix and experienced the same styling issues.
If you are working with next.js's app router, it looks like Radix has some notes about common styling issues that you may encounter due to css import order when working with the app router: https://www.radix-ui.com/themes/docs/overview/styling#nextjs-import-order
If you are creating your own dialog or portal components using Radix, then you need to wrap your portal content with the Theme component. You can find this information in Radix's documentation here: https://www.radix-ui.com/themes/docs/overview/styling#missing-styles-in-portals
I hope this resolves your styling issues.


Empty list placeholder is not visible when filtering roles with domain

Describe the issue:
When filtering roles with Application Domain the list of roles are empty. Hence there should be a empty list placeholder indicating the list is empty. Instead here and empty div is displayed.
This behaviour is not visible when filtering with both general search filter and domain filter at the same time.
Proof
https://user-images.githubusercontent.com/47152272/211482924-5cfa6603-adfd-4c14-95a1-5ad742476a17.mov
How to reproduce:

Log into console
Goto Manage -> Roles
From the domain filter on the right top corner choose Application Domain.
You will see the following GUI.

Expected behavior:
Should display a placeholder which says the list is empty.
Environment information (Please complete the following information; remove  any unnecessary fields) :

Product Version: IS 6.1.0-alpha2
OS: Mac
Database: Postgres
Userstore: jdbc

This issue is being closed due to extended inactivity. Please feel free to reopen it if further attention is needed. Thank you for helping us keep the issue list relevant and focused!


Upgrade from 1.10 to latest

What are the things that need to be check before upgrading from the old version to the current version?
Replacing my old jquery.validate.js file into a new one is that enough or else need some other changes ?
Currently am using v1.10.0 I need to go with v1.19.3

Have a look at the changelog to grasp what you get: https://github.com/jquery-validation/jquery-validation/blob/master/changelog.md
AFAIR there are not intentional breaking changes in the core.
You should also check whether you are using additional plugins which also need to be updated

Hi,
jquery(#id).valid() function return a string value in v1.19.3 is there any way to get it in a boolean type.


Homebrew Install Error - Wiretrustee Refference

Describe the problem
Installing the client via Homebrew on MacOS presented an error
To Reproduce
brew install netbirdio/tap/netbird
Expected behavior
No errors
Screenshots
Error message:

==> Installing netbird from netbirdio/tap
Warning: netbird: No available formula with the name "wiretrustee". Did you mean wiredtiger?
'conflicts_with "wiretrustee"' should be removed from netbird.rb.
Please report this issue to the netbirdio/tap tap (not Homebrew/brew or Homebrew/core)!

Hello, @tomtom215, some homebrew executions fail due to the HOMEBREW_DEVELOPER and HOMEBREW_INSTALL_FROM_API being set. Can you check if running the following before running the install command will help?
export HOMEBREW_DEVELOPER=0;
export HOMEBREW_INSTALL_FROM_API=0;

I've also removed the conflict flag from the formulae in #615

Thank you, @tomtom215, for opening, it definitely will help others resolve this issue.


Enforce supplying the export option to checkpoint command

What happened:
Make troubleshooting of this: https://github.com/kubernetes-sigs/cri-tools/issues/1233#issuecomment-1670120523 easier
What you expected to happen:
Export argument needs to be required and better documented as a tar file path.
How to reproduce it (as minimally and precisely as possible):
See https://github.com/kubernetes-sigs/cri-tools/issues/1233#issuecomment-1670120523
cc: @adrianreber
/help

I can look into this.


Updating Kubectl & Helm Deployments to apiVersion:app/v1

Hello,
I received some validation errors when trying to install this into my cluster. I bumped

the deployments to apiVersion: app/v1 (from extension/betav1)
added the selector.matchLabels per the validation of app/v1
pulled out the app_name to the helm chart values.yaml
added a namespace option to the helm chart values.yaml

Since https://github.com/ExpediaGroup/kubernetes-sidecar-injector/pull/19 covers all of this and uses the more accepted namespace from helm chart, app name from the common helm .Release.Name,  and k8s recommended labels as match labels, I am going to close this.


[Feature Request]: Use symfony/uid instead of ramsey/uuid

Description
Symfony UID supports both UUIDs and ULIDs.
To be honest, this is mainly a personal preference, as I like to use ULIDs instead of UUIDs in my code, but I also think Symfony's UID code is nicer and simpler than Ramseys UUID.
Benefits
Support for both UUIDs and ULIDs.
Developed and supported by big respected company.
Minimum PHP version PHP 8.2 instead of 8.0.
Seems to be faster: https://github.com/laravel/framework/discussions/47631

I'd be glad to give a try on this topic if nobody has already started or is planning to do :)

I don't have a strong opinion on it. I'm open for a PR :)


SyntaxError: invalid syntax

Thank you for your great work!
Some syntax error:

out_logits is not defined.
https://github.com/Nmegha2601/activitygraph_transformer/blob/6f25049f68907d27126e2aa3a7376b4ca780d239/src/models/agt.py#L282
target here

Thanks for pointing out


Docs: Document library evolution restrictions for @inlinable functions

As documented in the SE-244 proposal, it is illegal to change the concrete return type of an @inlinable function with an opaque return type. This ought to be documented since it is an extremely subtle rule that authors of ABI stable libraries should be aware of.

@swift-ci please smoke test


fix: zero first byte of grpc data frame, which could be random data from mcache

What type of PR is this?
fix
Check the PR title.

[x] This PR title match the format: <type>(optional scope): <description>
[x] The description of this PR title is user-oriented and clear enough for others to understand.

(Optional) Translate the PR title into Chinese.
修复：将 GRPC Data Frame 的首字节清零（compressed flag=0）；从mcache取得的buf里可能有任意数据
(Optional) More detailed description for this PR(en: English/zh: Chinese).
en: grpc data frame requires the first byte to be compressed flag, which should be 0/1, but kitex is using a buffer allocated by the mcache pkg which may contain random data.
zh(optional):
Which issue(s) this PR fixes:

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.felix.fengmin seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


(feature) Send usage of flag in Openfeature web provider

Requirements
We are missing the data evaluation collection for the web provider.
Following the example of the iOS and Android providers we should implement it for the web provider.
There is already a hook available for the JS server SDK that could be a base for the Openfeature Web SDK.

/assign-me


Specific versions of elasticdump

My company needs to build specific versions of elasticdump available to build from a Dockerfile but we cannot use anything other than FROM taskrabbit/elasticsearch-dump:version
in the file for security reasons.  It appears that when I add a version for instance
FROM taskrabbit/elasticsearch-dump:6.8.3 I get
failed to build: manifest for taskrabbit/elasticsearch-dump:6.8.3 not found: manifest unknown:

You should look at the tag names
https://cloud.docker.com/u/taskrabbit/repository/docker/taskrabbit/elasticsearch-dump
FROM taskrabbit/elasticsearch-dump:v6.8.3


Add an option to accept whatever the suggestion is

Feature request
I want aicommits to have an option to just take yes for an answer as a flag and take the generated commit message without bothering to ask yes / no as a separate prompt.
for example:
aicommits -y

Why?
(hypothetically) I  don't care what the commit message is sometimes, I want the message written but don't want to bother with validating it.
Alternatives
alternative is to feed a key from the shell to hit yes.
Additional context
No response

I was thinking to just enable it for all messages. I can clearly see your idea as well.
I can alter my PR here - and add that possibility as well.
Or i can make a new PR that only allows your suggestion.

@davidawad I've forked the repo, since this seems to no longer be maintained.
https://www.npmjs.com/package/@negoziator/ai-commit
In my version you can set it to auto-confirm commit messages 😄
aicommit config set auto-confirm=true

Yes I would really like this feature!


hide campaign type from regional admins on /node/add/campaign

is this the only field which is no longer being hidden? if thats the case can we verify that the field is marked as translatable

hmm actually @deadlybutter everything looks good on thor. staging seems to be missing a lot of the global stuff.

gotcha and yeah that makes sense, most of the global work isn't on the dev branch and we only deploy dev to staging.
but based on that meeting i imagine this is changing soon

yeah https://github.com/DoSomething/phoenix/pull/5120 was meant to be merged in but wasn't before staging was deployed. looking all good now.


Error with parsing token "app owns data"

Hi,
First of all, let me say I'm not a coder, so this could be a silly question. I'm trying to embed a PowerBi report in a website with JavaSript. I've completed the steps, register the app, so I have the ClientID, Picked up the GroupID from the Azure ADGroup en filled that in in Web.config. I Also provided the necessary credentials.
After I run tha application, I can choose dashboard, app or tile to embed en when I click report I'm getting an error:
"error":"invalid_client","error_description":"AADSTS70002: The request body must contain the following parameter: 'client_secret or client_assertion'."
 Regel 43:             // Authenticate using created credentials  Regel 44:             var authenticationContext = new AuthenticationContext(AuthorityUrl);  Regel 45:             var authenticationResult = await authenticationContext.AcquireTokenAsync(ResourceUrl, ClientId, credential);  Regel 46:   Regel 47:             if (authenticationResult == null)
I can't find anywhere to leave My Client_secret, so I'm a bit lost. The documentation on The PowerBi.com Is not very clear in this matter, so any help would be welcome.
Jordy

It seems that you are running "User Owns Data" sample.
This sample need a web application to be registered in AAD.
once you register a web app, you get client Id and client secret.
please follow the steps here and try:
https://github.com/Microsoft/PowerBI-Developer-Samples#user-owns-data-samples
let me know if it solves your issue.

Hi Ali,
Thanks for the quick response! I'm running the AppOwnsData solutionfile for Visual Studio. Filled in all required info en then Run the app.
in the error the path is there as well:
PowerBI-Developer-Samples-master\App Owns Data\PowerBIEmbedded_AppOwnsData\Controllers\HomeController.cs    Regel: 45
Any more ideas?

So it must be the opposite. you registered web app, and you need to register native app. AppOwnsData  needs native app.

you were right! was the wrong app registration.
Get a different Error now though:
"error":"invalid_grant","error_description":"AADSTS65001: The user or administrator has not consented to use the application with ID '

click "Grant Permissions" in portal.azure.com while selecting the app you registered.

it works! thanks for your patience


Look up the UTXOs in the transaction verifier, then pass them to verify_transparent_inputs_and_outputs

Motivation
Currently, Zebra's script verifier looks up UTXOs. But we also need those same UTXOs to verify transaction and chain value balances in the transaction verifier.
So we should look up the UTXOs in the transaction verifier, and send them to verify_transparent_inputs_and_outputs,  which can send them to the script verifier as part of the request.
Designs
This will be needed for the implementation of value pools: https://github.com/ZcashFoundation/zebra/blob/6e1606ba8e1ddbc7dd7aa7e5921185c422b57ef6/book/src/dev/rfcs/0012-value-pools.md#create-a-method-in-transaction-that-returns-valuebalancenegativeallowed-for-the-transaction
TODO: use the latest design once PR #2430 merges.
Related Work
https://github.com/ZcashFoundation/zebra/pull/2430

This change doesn't guarantee us correct UTXOs, for details, see:
https://github.com/ZcashFoundation/zebra/pull/2486/files#r677190254

Turns out we need this to calculate mempool fees.

Conflicts with the NU5 block validation code freeze, moving after NU5 testnet activation.


logToJournal breaks when journald is stopped and started

Issue description
services.xserver.displayManager.logToJournal uses systemd-cat to achieve writing session error logs to journald. Unfortunately, this breaks when journald is restarted by stopping and starting, i.e. during nixos-rebuild switch. After this, all applications that try to write something to stderr immediately fail (with SIGPIPE I presume).
I suspect that's because while (usually) journald is accessed through its own API or syslog(3) its restarts are handled gracefully -- however, what systemd-cat must be doing is opening some pipe or socket, dup2ing it into STDERR_HANDLE and execing the target program. This, of course, would fail when the handle is invalidated (e.g. because the target process is stopped), and there's nothing to reopen it properly.
Steps to reproduce

Run gajim from the system menu or somehow else inside X11, not from a terminal where stderr and stdout are hooked. I use XMonad.Prompt.
Observe that it works.
Run:

# systemctl stop systemd-journald
# systemctl start systemd-journald

Try running gajim again. Observe that it fails.
Try running gajim from a terminal. Observe success.

Not only gajim of course, other apps start to misbehave in strange ways. For example taffybar fails after some time running like this and I cannot longer restart it from XMonad prompt, only from a terminal.
This can be workarounded by setting logToJournal = false.
Technical details

System: (NixOS: nixos-version, Ubuntu/Fedora: lsb_release -a, ...) 16.09.git.5607ab6 (Flounder)
Nix version: (run nix-env --version) nix-env (Nix) 1.12pre4523_3b81b26
Nixpkgs version: (run nix-instantiate --eval '<nixpkgs>' -A lib.nixpkgsVersion) 16.09.git.5607ab6M

cc @edolstra

Maybe we want to disable this by default for 16.09 to avoid people running into this, and document that there is an issue?

I've experimented more, thinking to fix this before a release. I see two ways:

Conservative: services.xserver.displayManager.logToJournal = false.
Better but can have issues: systemd.services.systemd-journald.restartIfChanged = false.

@edolstra , what do you think? I'll go the first way if it's not agreed the second is okay -- cc @domenkozar  (ping me before a release to push the patch, please).

Any idea why running systemd-cat in one terminal, then systemctl restart systemd-journal in another does not break the systemd-cat in the first process? A minimal example would be helpful to see what exactly causes the error. Imo the desktop-/window-manager should log to the journal itself, so our systemd-cat is only useful for our xsession.script, right?

It breaks, you just don't know it yet -- try running systemd-cat cat, entering several lines, then stopping-starting and trying to add yet another line. Stopping-starting is what nixos-rebuild does.

Restart can also break things, but not always. I've succeeded in breaking the session after several consecutive restarts. I'm not sure if it's a race condition or something else -- either way, stopIfChanged = false didn't fix this.

logToJournal is hardly special in this regard. All services that log to stdout/stderr break if you restart the journal.

Indeed, that's why I think that just disabling logToJournal is just hiding the true cause. What do you think of systemd.services.systemd-journald.restartIfChanged = false? I'm not sure if it can be bad, for example when systemd updates...

From the systemd 219 release notes:
        * systemd now provides a way to store file descriptors
          per-service in PID 1.This is useful for daemons to ensure
          that fds they require are not lost during a daemon
          restart. The fds are passed to the daemon on the next
          invocation in the same way socket activation fds are
          passed. This is now used by journald to ensure that the
          various sockets connected to all the system's stdout/stderr
          are not lost when journald is restarted. File descriptors
          may be stored in PID 1 via the sd_pid_notify_with_fds() API,
          an extension to sd_notify(). Note that a limit is enforced
          on the number of fds a service can store in PID 1, and it
          defaults to 0, so that no fds may be stored, unless this is
          explicitly turned on.

I guess we should set that limit to something > 0...

Hm, it's already set to 1024 for systemd-journald.

Hmmm, maybe journald detects that it's restarted instead of stopped-started somehow and saves fd? That explains why restart doesn't break things always, but doesn't explain why it breaks them anyway sometimes...

BTW, I just tested restarting systemd-journald while systemd-cat is running and the latter keeps logging just fine.

And so does my xsession BTW :-)

Oh, I did a systemctl restart. I guess stop/start will prevent the FDs from being saved.

Well, I'm not sure why I had occasional failures even with restarts, but let's say that I just had a bad luck then. I propose:
systemd.services.systemd-journald.stopIfChanged = false;

and also, as a bonus:
systemd.services.systemd-journald.restartTriggers = [ config.environment.etc."systemd/journald.conf".source ];

(Do I understand correctly that stopIfChanged will make it restart instead of stop-start?)

Yeah, stopIfChanged = false sounds like the right thing to do.

I'll prepare a patch and test then. Thanks!

Ugh, I think that what I really did hit was not a journald's problem but switch-to-configuration.pl's:
 nixpkgs git:(stable) ✗ sudo nixos-rebuild switch
...
stopping the following units: systemd-journald.service
Warning: Stopping systemd-journald.service, but it can still be activated by:
  systemd-journald-dev-log.socket
  systemd-journald-audit.socket
  systemd-journald.socket
activating the configuration...
setting up /etc...
restarting the following units: systemd-journald.service
starting the following units: systemd-journald.service
 nixpkgs git:(stable) ✗ cat /etc/systemd/system/systemd-journald.service.d/overrides.conf
...
X-StopIfChanged=false

 nixpkgs git:(stable) ✗

Any ideas?

Notice that journald is both stopped, restarted and started!

@edolstra I think I found the source of a problem, but I need some advice. See these lines: https://github.com/NixOS/nixpkgs/blob/master/nixos/modules/system/activation/switch-to-configuration.pl#L216

Do we need to restart sockets at all? I thought that they would be "restarted" automatically when the service is restarted.
We add a service to stop and start lists instead of a socket in line 227. I think that's a bug;
Even if we do need to restart sockets, we don't want to do this when X-StopIfChanged is disabled. Therefore we probably want to move socket restarting logic under else (line 242).

I think the main reason for stopping the socket is to ensure the (old) service doesn't get restarted via the socket before we've switched to the new configuration (which would prevent the subsequent start from doing anything). So yeah, in the case of stopIfChanged = false, stopping the socket is unnecessary.
Does look like a bug at line 227.

Aha, I haven't thought of that (regarding service restarts while switch is in progress)! I have prepared a patch; see #19108.

Backported to 16.09. Thanks @edolstra, @groxxda for help and testing!


review: changes for dev and prod config

Haven't tested this, so not sure if it works.
We assume 2 profiles:

Dev profile (default). Uses JKube's base image which allows debugging and other stuff to work out of the box
prod profile (-Pprod). Has a manual image configuration that uses the image specified in buildConfig.yaml (this file should not be necessary). I configured it to add a single layer with the bootable wildfly artifact. The rest of configuration is preserved from the Dev profile.

Considering that the jolokia and prometheus agents are not added in the image's entryPoint (copied from buildConfig), the services and routes don't seem necessary for that profile. OR maybe we need to modify the entrypoint to enable those agents (probably also add those required agent jars to the image build configuration).

I close the pull request since I have already implemented the way to produce an image based on OpenJDK image runtime only, following the hint given me by Marc Nuri San Felix.


Run multi-node clusters

Now that hostpath driver supports topology, we should run a kind cluster with 2 nodes so we can better test topology
/help

I'm working on this issue.


Support anonymous resource groups

Fixes https://github.com/Azure/azure-sdk-for-net/issues/42230

API change check
APIView has identified API level changes in this PR and created following API reviews.
Azure.Provisioning


feat: collect analytics if callback passed in

We would like to collect analytics from the VM in order to understand which components receive the most views and are the most utilized among other stats.
Monitoring the VM will give us insights beyond just traffic usage as it can help to discover bugs in the VM to make it more performant.
You are not required to pass in an anlayticsCallback. In fact, you can leave it out and your VM should work as is.

If we can have PR 131 merged or something similar, we won't need this PR anymore


Is there an interest in/need for a inRange function?

inRange: Ord a => a → a → a -> Boolean
R.inRange(10, 20, 11);   //   10 < 11 < 20
> true
R.inRange(10, 30, 100); // 100 > 30
> false

you can using R.median([10, 20, 11]) === 11

This strikes me as a particular case of a function that represents a set of constraints. allPass is the more general, conjuctive case of this type of function (anyPass would work for disjunction):
const inRange = (low, high) => R.allPass([
    x => x > low,
    x => x < high
]);

inRange(10, 20)(11) //=> true
inRange(10, 20)(100) //=> false

See previous discussions in #1603 and #2497.
While this function can be useful, it is a better foot for one of the auxiliary libraries or the Cookbook.


[TO_REVIEW] Add TarS method

This PR implements the TarS method from  http://proceedings.mlr.press/v28/zhang13d.pdf (mainly eq.6).
Related issue: #43

Hello,
Yes, solving constrained QP is possible with scipy link. There are three available solvers for that: trust-constr, SLSQP and COLYBA. I tested them, and SLSQP is the fastest. Giving the Jacobian (computed analytically) fasten the computation also.
Indeed, CVXOPT is faster (perhaps 10 times faster than scipy for 1000 samples). However, I do not recommend including it in the requirements. I did it for adapt, but run in multiple bugs after new cvxopt releases...
My suggestion is to provide a faster optimization solver, using the Frank-Wolfe algorithm, which can be easily implemented. Frank-Wolfe works well for weighting methods based on MMD or KL minimization, such as KLIEP and KMM. It really speeds up the optimization. cf this paper : https://webdocs.cs.ualberta.ca/~dale/papers/ijcai15.pdf . It could be proposed as an alternative for the user via a solver argument, to keep track of the original algorithm that uses classic QP solvers.

Thanks for all the infos @antoinedemathelin !


[incubator/druid] coordinator uses mysql which is already exists.

By default, the helm will setup a mysql in k8s.
This can set the mysql info in the values.yaml. It can use the mysql server which is created on AWS   / Kingsoft Cloud/Google cloud.

@jinleileiking
you can try [incubator/druid] chart version 0.2.0+

I am now using druid-operator, druid helm charts is not good. CONSIDER DO NOT USE IT use operator


Dispatch uploaded patient data from CSV

In #54 we created basic functionality to screen and process a patient CSV file. This is loaded into an object and displayed for review. One the upload is confirmed, this data needs to be loaded into the data store for the application (which is currently incomplete).
Reference:
https://github.com/CDCgov/prime-data-input-client/blob/main/frontend/src/app/patients/ManagePatients.jsx

Good rows are kept in the jsonImport.data object
These are sent to CSVModalForm.jsx in the CSVModalForm function via the data object

https://github.com/CDCgov/prime-data-input-client/blob/main/frontend/src/app/patients/CSVModalForm.jsx

On confirmation, good data exists in the data.data object
The Confirm Import buttons currently have empty on-click functions, this is where the function needs to be built to add data into the data store

Depends on #90 and associated implementation tickets. Related to #46 as these two tickets will likely use the same dispatch code.

Prioritize for AFTER the backend is built to figure out the best approach for this


Update to Xcode 10.2 and Swift 5.0

Thanks @taher-mosbah I will merge this once Swift 5.0 is out of beta.

Thanks for you PR! The codebase has actually under gone a major refactor and should be updated for Swift 5. Feel free to check it out here #653. Feedback welcomed!

I'm going to go ahead and close this out as it is related to the old 3.X.X codebase. Thanks again for the PR!


[WIP] Mock IQ backend - Multiple Qubit Support

Summary
Updating the mock_iq_backend.py to support multiple qubits.
Details and comments
Changes that are needed to the base class:

[x]  Need to change "self._iq_cluster_width" and " self._iq_cluster_centers" to be lists for each qubit:

[x]  The variable "iq_cluster_centers" will be List[Tuple[float, float, float, float]] - can change to different
[x]  the variable "iq_cluster_width" will be List[float]

[x] Need to change the method "self._compute_probability(circ)" that it will return a dictionary in the following
template: {"output vector": probabilty_for_output_vector}. for example on 2 qubits bell state:
self._compute_probability(circ) = {"00": 0.5, "01": 0, "10": 0, "11": 0.5}
[x] Need to change to multinomial distribution instead of binomial at "np.sum(self._rng.binomial(1, prob, size=shots))".
This is because we now have multiple output like a dice.
[x] Need to change "run_result["data"]" to have all the possible outcomes.
[x] Need to change that the method "_draw_iq_shots(self, prob, shots)" as following:

[x] Need to change that all the qubit will be measured.
[x] What we will do append is to all the qubit, meaning it should look like this for 2 qubits.:
a.append([[point_i_1, point_q_1],[point_i_2,point_q_2]])
[x] The variable "prob" will now be dictionary for all outputs.
[x] The attribute "self._iq_cluster_width" is a list. Need to take the one relevant to the corresponding qubit.
[x] The attribute "self._iq_cluster_centers" is now List[Tuple[float, float, float, float]]. Need to take the one relevant to the corresponding qubit.
[x] Need to add function that will get a index number like '1' and return the qubit values (for 3 qubit it will be "001")

Checks needed to be add to the base class:

[x]  check probability, sum need to be 1.

Additional changes that are needed after the update:

[x] update DragBackend(MockIQBackend).
[x] update RabiBackend(MockIQBackend).
[x] update MockFineAmp(MockIQBackend).
[x] update MockFineFreq(MockIQBackend).
[x] update MockRamseyXY(MockIQBackend).
[x] update test_half_angle.py
[x] update test_qubit_spectroscopy.py
[ ] update tutorial - with parallel experiment use.

New Features:

[ ] Parallel experiment handler
[ ] Test for Parallel experiment handler.

In my review earlier today, I gave a bunch of comments about stuff that moved from the qiskit_experiments/test to the test folder, hence became inaccessible for those who pip install, and therefore have to return to qiskit_experiments. I think that at least some of these functions were originally in test. Functions that were originally in test should remain there.


[#113824903] Work around terraform diffs bug

What
Terraform currently throws an error with this specific combination of
interpolation functions when the EIPs' public IPs can't be known ahead of
time (ie when they're also being created in the same terraform run).
Splitting these into separate ingress blocks avoids runing into this
issue.  See hashicorp/terraform#5301 for more details.
This also includes @saliceti's change to use the new terraform container. This is so that I can upgrade this to use terraform 0.6.12. On earlier versions terraform will update the security group on every run when it's configured with multiple ingress blocks with matching port ranges.
How to review
Run the cloudfoundry terraform job against a clean environment (ie either a brand new deployment, or one that's had the cloudfoundry terraform destroy job run), and verify that it succeeds first time.
Additionally, point the terraform container at the branch with the updated version (docker:///governmentpaas/terraform#bump_terraform), and verify that the security group doesn't get updated on every run (it will be updated on the first run with the new version, but shouldn't be on subsequent runs).
Who can review
Anyone but @dcarley or myself.

Indeed this works cleanly now.


[FEA]  Get only embeddings from model.item_embeddings()

🚀 Feature request
when we run the following command we do not only get item embeddings but also item feature columns in the item_embeddings dataframe. It'd be useful to add an arg in the item_embeddings() to exclude other columns.
item_embs = model.item_embeddings(Dataset(item_features, schema=schema), batch_size=1024)
item_embs_df = item_embs.compute(scheduler="synchronous")

Motivation
We save item_embeddings for E-2-E and we only want to have the embedding columns. In doing so, we need an extra manual process to drop the item features from the item-embeddings dataframe.

Has been fixed but PR wasn't linked


The label "version" is barely visible on mobile

In the title bar (Vacuum), the label "version" is barely visible.
The page shown is: https://duckdb.org/docs/sql/statements/vacuum

Fixed by #1423


baby_trigger_for is incorrectly labeled as being a list (or returned incorrectly as a single object)

I am working on the c# wrapper over at https://gitlab.com/PoroCYon/PokeApi.NET and set up a test that calls every all 746 items.
baby_trigger_for does not seem to be an array in any of them.

@M-Zuber Yeah this is weird. I'll tinker with this too. Thanks again, Mordechai.


Drag&drop support between two grids

Hi,
Thanks for a fantastic grid/treegrid component!
As far as I understand DnD of nodes between different grids is not currently supported? Do you have plans on adding such feature, maybe you can share your thought on how difficult it would be to create it?
Thanks,
Vasiliy

I don't think it would be that difficult since the full data object comes in the drop event, I'm not sure if the stateKey does, however. That would be easy enough to add. I will mark this as help-wanted and get to it as soon as I can. As always, pull requests are very welcome!

Hi Ben,
Thanks for the nice grid module.
Could you already find time for the feature?


Ensure builds happen with cython 0.29.x

Change Summary
Ensure builds happen with 0.29.x instead of 3.x since 3.x is not compatible
Related issue number
fixes #7689
Checklist

[ ] The pull request title is a good summary of the changes - it will be used in the changelog
[ ] Unit tests for the changes exist
[ ] Tests pass on CI
[ ] Documentation reflects the changes where applicable
[ ] My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

Closing per https://github.com/pydantic/pydantic/issues/7689#issuecomment-1739658104


flannel network config cannot specify more than one interface

Rancher Server Setup

Rancher version: 2.5.9
Installation option (Docker install/Helm Chart): Helm Chart (rancher-stable)

If Helm Chart, Kubernetes Cluster and version (RKE1, RKE2, k3s, EKS, etc): RKE2

Proxy/Cert Details:

Information about the Cluster

Kubernetes version: 1.20
Cluster Type (Local/Downstream):

If downstream, what type of cluster? (Custom/Imported or specify provider for Hosted/Infrastructure Provider): Custom Baremetal

Describe the bug
Flannel networking config in RKE can only specify one network interface like this
  network:
    options:
      flannel_iface: eth0
    plugin: flannel

This translates to flannel daemonset
containers:
  - args:
    - --ip-masq
    - --kube-subnet-mgr
    - --iface=eth0

However flannel doc states that we can use the --iface multiple times. In my case I have nodes with different interface names. So I would like to do something like
  network:
    options:
      flannel_iface: eth0,ens192,eno1
    plugin: flannel

so as to become
containers:
  - args:
    - --ip-masq
    - --kube-subnet-mgr
    - --iface=eth0
    - --iface=ens192
    - --iface=eno1

But this does not work.
Result
Expected Result
There should be a way to specify multiple interfaces or IP addresses to flannel network config.

It is likely that in a situation with a mix of hardware this would come up and we are hitting this too.
There are situations also where aliasing or renaming the devices is not a satisfactory work around. (eg tun0, eth0.100, ib0)


Playground: improve location selection

The playground has become harder to use with the increasing number of feeds available.

@drewda I added additional location filters. Please review PR https://github.com/transitland/playground/pull/132.

I found a bug in the way the list clears, so this isn't ready for prod yet.


solved issue #212

Created a login and signup page with email verification and password matching, also add features that input field get cleared after  details  submission . @yatulearn  please review the PR and merge it accordingly.

make it a working login/signup page i.e it should receive and store data at the backend or link it with firebase I have given it level3 it you're not able to do that kindly tell me

yes , i can connect the firebase database to it. But how will i know that its working or not , saving information to the database or not , as i didn't have access to the firebase details.

@yatulearn  i am unable to add functionality  to the login and signup page . if y0u want to remove level3 tag please at least provide level 2 tag as creating login and signup page also took time . Looking forward to work with you .

ok

@yatulearn  please merge the PR.

@yatulearn please merge the PR.

we are reviewing the pr will merge it soon if it fits the condition


[WIP] omnibus-f4sd osd integration

This PR adds the driver for the osd chip on the omnibus-f4sd board (MAX7456 or AT7456). The chip is controlled via SPI from the F4 micro controller and adds an overlay to the analog FPV video stream before it is transmitted from the transmitter on the vehicle.
Currently the battery voltage, the accumulated current, altitude and flight time are shown. Soon also attitude, heading and velocity will be added. Moreover it would be cool to have a config file on the sdcard to decide what to show on the overlay and where to place it on the screen.
Currently a parameter was added (OSD_TX_MODE) to choose between NTSC and PAL transmission mode (I still need to figure out if somehow it can be done automatically).
In the next days the remaining features will be pushed and also some RAM usage analysis will be done because in one situation I ran out of RAM.

If this is only running every 500ms you might as well grab all data you need every cycle. You can skip storing most of the state or even bothering to orb_check.

Yes that makes sense. I still don't know at what frequency I will update. I will try to fly with it and then decide. Anyway it will be between 2 and 5 Hz.

Currently the battery voltage, the accumulated current, altitude and flight time are shown. Soon also attitude, heading and velocity will be added. Moreover it would be cool to have a config file on the sdcard to decide what to show on the overlay and where to place it on the screen.

Depending on how much control you think people really need here I'd consider exposing it via parameters. It ends up being far more user accessible and to some extent self documenting. We could also have a handful of opinionated premade configurations selectable with a single parameter.

Yes, parameters are sufficient for now.

@DanielePettenuzzo worth rebasing and getting a partial version of this committed?


coap: changes related to canceling replies created by sol_coap_send_packet_with_reply - v3

Changelog from v2:

Using correct RFC to implement unobserve packets
fix a possible overflow
Fix mistake in "Fix memory leak if error" commit

Replaces #1061

Some of them merged. The one left behind is now on #1106


Fix for empty grain response  deseriaslized to null

Description
Bug: when a grain responses with empty class or class containing all default data, it will be deserialized  to 'null' on the receiving end.
After fix - it will be deserialized to empty class

Purpose
This pull request is a:

[x] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation (if appropriate)

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Ivan V seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Manager Crashes Consistantly Trying To Auto-Update Mods.

The update description is giving, begins download, tries to extract, then shuts down. Every time, without exception. This has applied to Lantern Engine and Tweaked Cutscenes mods specifically.

This should be fixed with the last update. (I'd recommend installing it manually.)

Yep, that's sorted it. Much obliged!


ADD Tarrant County College

Tarrant County College

HOMEPAGE:https://www.tccd.edu/
COURSE INCLUDED:https://catalog.tccd.edu/preview_program.php?catoid=7&poid=1176

@rousseauwu This domain is blacklisted because the college allows to register an email address there even if you are not a student of the college. If you are the student of this college, please apply with official document ("OFFICIAL DOCUMENT" tab at https://www.jetbrains.com/shop/eform/students).


Domain wildcard group in routes and url generation for named routes

I have route group with domain wildcard. Something like this:
Route::group(
    [
        'domain' => '{subdomain}.domain.com',
    ],
    function ($router) {
        Route::get(
            '/',
            [
                'uses' => function ($subdomain) {
                    return route('subhome');
                },
                'as' => 'subhome'
            ]
        );
    }
);

Route is working well, catching only subdomain request. But there is a problem in url generation for named route. Above code will produce:
http://%7Bsubdomain%7D.domain.com

{subdomain} wildcard is not converted to current subdomain, and named routes are not usable. I found dirty solution to this:
Route::group(
    [
        'domain' => '{subdomain}.domain.com',
    ],
    function ($router) {
        Route::get(
            '/',
            [
                'uses' => function ($subdomain) use ($router) {
                    $route = $router->getCurrentRoute();
                    $action = $route->getAction();
                    $action['domain'] = $subdomain . '.domain.com';
                    $route->setAction($action);

                    return route('subhome');
                },
                'as' => 'subhome'
            ]
        );
    }
);

It is now outputting correct route url:
http://subdomain1.domain.com

This solution works, but it is a dirty one. It can be probably taken out from there and made into its own middleware or event handler class, but I'm wondering if there is, or should be any better solution?
EDIT
My solution is not quite right. Because you need to update all routes actions with correct subdomains. This probably can be done through RouteCollection class, but this is not optimal in case of performance. And ugly as well.

Maybe the UrlGenerator route(...) method could be changed as such:
public function route($name, $parameters = array(), $absolute = true)
{
    if ( ! is_null($route = $this->routes->getByName($name)))
    {
        if (count($parameters)) {
            return $this->toRoute($route, $parameters, $absolute);
        } else {
            //If no parameters are specified grab them from the current request...
            $parameters = $route->bind($this->getRequest())->parameters();
            return $this->toRoute($route, $parameters, $absolute);
        }
    }
    throw new InvalidArgumentException("Route [{$name}] not defined.");
}

If this works for you then maybe make a pull request...

We're open to pulls. If it's a change in behaviour send to the master, otherwise, to 5.0 please. :)


[smallfile] Adding pip upgrade and missing dependencies

Signed-off-by: Vicente Zepeda Mas<EMAIL_ADDRESS>Description
Adding pip upgrade to Dockerfiles and missing dependencies due to build failures.
Fixes

Results for SNAFU CI Test

Test
Result
Runtime

snafu/smallfile_wrapper
PASS
00:05:50


Acceleration based control/feed-forward

Describe problem solved by this pull request
More or less last step to finish splitting up and QAing PX4/Firmware#12072. It's based on #245 and introduces processing acceleration setpoints.  It also heavily reduces dependence between collective thrust and vehicle tilt making the demanded tilt less jerky when the altitude control output is changing.
Describe your solution
I make the velocity control output acceleration in m/s² which in theory would make the controller tuning more independent of the vehicle's thrust to weight ratio (~hover thrust) but for the initial introduction I introduce a scaling factor using the hover thrust to make the existing gains compatible. To separate the high-frequency altitude control changes from the collective thrust from the demanded tilt I'm switching control strategy to apply horizontal acceleration setpoints assuming hover/gravitational acceleration in the vertical direction effectively directly mapping it to the vehicle's tilt. The vertical acceleration gets projected onto the planned tilt and then executed by setting the collective thrust accordingly. Only in the limit case of more than the maximum thrust tilt gets coupled by being limited using vertical acceleration demand to ensure prioritizing altitude control over horizontal navigation.
Test data / coverage
For the basic limit cases, input combinations, failsafe and zero thrust inputs there are unit tests now. I did a lot of SITL testing and multiple outdoor tests with a 250 size, one test on a big multicopter.
Additional context
Refactorings that made this change possible: https://github.com/PX4/Firmware/pull/13247, https://github.com/PX4/Firmware/pull/13248, https://github.com/PX4/Firmware/pull/13262, https://github.com/PX4/Firmware/pull/13347, https://github.com/PX4/Firmware/pull/13701, https://github.com/PX4/Firmware/pull/14017

[x] I still need to change the jerk limits for manual and auto since the tracking is tighter now.
I discussed with @Jaeyoung-Lim to expose the acceleration on the offboard interface to allow more dynamic flights and a different kind of input that doesn't rely on vehicle internal velocity estimate.

I rebased on master and removed the draft since the configuration default changes are also there.

@MaEtUgR I tried offboard acceleration feedforward with this PR, but couldn't enter offboard mode. Am I missing something?

@Jaeyoung-Lim Thanks for testing offboard!!
The provided logs show that instead of actually setting acceleration the normalized collective thrust vector is set to the value you probably want to give in m/s^2

I presumably fixed that with this pr: https://github.com/PX4/Firmware/pull/14212/files#diff-f58f83b125f08a9604e2b91bb9f94b1bL231-L233
I don't know why you can't enter offboard mode, maybe we can have a quick look together to get a clue?

@MaEtUgR Ah, sorry for not being clear. That was the logs from master since I couldn't make it go in offboard mode. Would be great if we can dig in!

@MaEtUgR Disarming shortly after arming in offboard mode : Log

tested on pixhawk4 v5 f-450
Modes Tested*
Position Mode: Good.
Altitude Mode: Good.
Stabilized Mode: Good.
Mission Plan Mode (Automated): Good.
go to: Good.
RTL: Good.

Procedure
Arm and Take off in position mode, after flying for approximately one minute, switched to altitude then stabilized mode proceed to switch to mission plan mode then make sure that vehicle follows all waypoints as shown in QGC, once completed all waypoin activate RTL

Notes:
No issues noted, good flight in general.
Log:
https://review.px4.io/plot_app?log=d2109f81-1651-4b5d-91de-92147ee43378

Tested on NXP FMUK66 v3
Modes Tested

Mission Plan Mode (Automated):
Good.Go To Mode (Automated): Good.
RTL (Return To Land): Good.

Procedure
Note: Vehicle was sent to a "Go To" point then RTL was triggered
Arm and Take off in mission plan mode then make sure that vehicle follows all waypoints as shown in QGC, once all waypoints are completed make sure vehicle triggers RTL.
Notes
Good flight in general.
Logs
https://review.px4.io/plot_app?log=b3dfd093-4eb9-457b-9723-ddbe76de9ccf
Tested on NXP FMUK66 v3
Modes Tested

Mission Plan Mode (Automated):
Good.Go To Mode (Automated): Good.
RTL (Return To Land): Good.

Procedure
Note: Vehicle was sent to a "Go To" point then RTL was triggered
Arm and Take off in mission plan mode then make sure that vehicle follows all waypoints as shown in QGC, once all waypoints are completed make sure vehicle triggers RTL.
Notes
Good flight in general.
Logs
https://review.px4.io/plot_app?log=c8254650-1392-4e7a-94fc-de6d030a939f

Tested on PixRacer V4
Tested Modes
Position Mode
Mission plan mode (automated):
Good. Go to (Automated) mode: Good.
RTL (Back to Earth): Good.
Process
Note: the vehicle was sent to a "Go to" point in the middle of mission and then RTL was activated
Assemble and take off in Position mode after flying one minute, switch to mission plan, then make sure the vehicle follows all the waypoints as shown in QGC, once all waypoints are completed, make sure of the vehicle activating RTL.
Notes
Good flight overall.
Logs
https://review.px4.io/plot_app?log=7286d189-3cdf-4a76-aa01-2edfe1a6633d
https://review.px4.io/plot_app?log=6aa51b7b-f999-4aea-bcdd-1a4cb0bde0ac
Tested on CUAV nano V5
Tested Modes
Position Mode
Mission plan mode (automated):
Good. Go to (Automated) mode: Good.
RTL (Back to Earth): Good.
Process
Note: the vehicle was sent to a "Go to" point in the middle of mission and then RTL was activated
Assemble and take off in Position mode after flying one minute, switch to mission plan, then make sure the vehicle follows all the waypoints as shown in QGC, once all waypoints are completed, make sure of the vehicle activating RTL.
Notes
Good flight overall.
Logs
https://review.px4.io/plot_app?log=ac76803a-1689-420b-9516-fb67c423614c
https://review.px4.io/plot_app?log=d12827ac-cfd1-48d1-babe-b85b10c54264

@dagar As we discussed I rebased (without conflict) and removed the in my eyes deprecated FlightTaskSport to make it fit in the flash of the omnibus. Here's the commit message explaining:
This mode was just kept as an example after
its usage in a single case.  It's implementation only switched
hte configuration parameter of the velocity resulting
from maximum stick deflection to be
MPC_XY_VEL_MAX instead of MPC_VEL_MANUAL.
This is according to todays understanding undesired
because when hitting that limit the position
controller has no room for corrections anymore.

Also it saves some flash space on omnibus to remove
the task at this point and makes romm for the
acceleration feed-forward.

I rebased on master and tried to reproduce the offboard issues by using the MAVSDK offboard integration tests:
./build/src/integration_tests/integration_tests_runner --gtest_filter="SitlTest.Offboard*"
But they all pass and seem to be doing what is expected looking at the simulation UI.
What do the two different errors I had come from, could they be glitches?
before rebasing: http://ci.px4.io:8080/blue/organizations/jenkins/PX4_misc%2FFirmware-SITL_tests/detail/PR-14212/6/pipeline
after rebasing: http://ci.px4.io:8080/blue/organizations/jenkins/PX4_misc%2FFirmware-SITL_tests/detail/PR-14212/7/pipeline
Now also jenkins seems to cancel my build NuttX builds only one shows in the UI and whole test fails even though the GitHub workflow builds succeed and "dronecode-macmini" cannot be contacted for the Mac build.

@MaEtUgR Any docs impact to all this?

@hamishwillee Good point. Sport mode was never documented since it wasn't too different. But the control diagram https://dev.px4.io/master/en/flight_stack/controller_diagrams.html#multicopter-position-controller needs to be adjusted a little bit. Time to look into how these diagrams 😬

I was able to reproduce what CI is flying and it found a real issue that I'm currently looking into.

It is a problem with the scaling and anti-windup of the integrator, I need to find good unit tests to capture this and find a solution.

I rebased on master and resolved conflicts with https://github.com/PX4/Firmware/commit/3049a3d14d0f4f0309cf324b9a6c3b64d4e1825c because I needed this change already for #312.

I think I found the problem: The Rundqwist anti-windup requires to know the setpoint before and after limiting and the tilt limit is already applied in the "before setpoint" and hence gets neglected. I need to bring them under the same denominator. I might just revert the new limiting mechanism to get the execution working and then have new limiting in a separate pr, let me see

I rebased on master and looked through it again and saw that the last corrections changed the shape of the integrator plots in an unexpected way. I removed them to have the following basically identical shape to master with just the horizontal integrator fix compared to when it was tested last:

I can add additional improvements in the next pr.

@MaEtUgR Since the integrator is in the velocity controller, could you add a plot that shows the velocity response, please? (I'm just curious to see how the step response looks like)

Rebased on master and lowered the maximum jerk in the VTOL defaults based on @fury1895's valuable VTOL testing feedback 🎉 . That concludes testing and fixes from my side and I consider it ready to merge 👍

@MaEtUgR Maybe this is too late, but I have tried this with offboard control, but this doesn't seem to work with offboard control.

@Jaeyoung-Lim It's never too late. Is there an easy way to reproduce such that we can find the issue?

@MaEtUgR You can use the ROS node I created, but if this is too much overhead I can also create a simple mavsdk app for testing

I can also create a simple mavsdk app for testing

I think that would be useful not just for me but also to put in CI to make sure it does not break again.


Add support for hydration

I removed the support for islands (and other hydrated components) because Twind v1 breaks the official plugin.
The main issue is that snapshots are completely different in Twind v1.

Hydration is working... sorta. But now there are duplicated styles. Not sure how to fix it.


Fix bug when IQVIA API fails to return data

Description:
A situation arose where individual IQVIA APIs would return valid responses (including 200 statuses), but the response data would be empty. Combined with some erroneous ZIP code validation logic, this created a condition where the integration would error out on startup. This PR fixes the issue.
Marking as 0.93.1 since the integration fails to load properly without this fix.
Related issue (if applicable): fixes https://github.com/home-assistant/home-assistant/issues/23910
Pull request with documentation for home-assistant.io (if applicable): N/A
Example entry for configuration.yaml (if applicable):
iqvia:
  zip_code: "10752"

Checklist:

[x] The code change is tested and works locally.
[x] Local tests pass with tox. Your PR cannot be merged unless tests pass
[x] There is no commented out code in this PR.
[x] I have followed the development checklist

If the code communicates with devices, web services, or third-party tools:

[x] The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
[x] New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.

Removing this from the milestone. Because of the moved config flow, this patch does not cleanly apply to rc.


ERROR: open Procfile: no such file or directory

I don't know if this is an issue with docker-compose, I'm really new to docker so don't get mad at me :).
proxy:
  image: jwilder/nginx-proxy
  ports:
    - "80:80"
  volumes:
    - "/var/run/docker.sock:/tmp/docker.sock"
  volumes_from:
    - web
db:
  image: postgres
web:
  build: .
  volumes:
    - .:/app
  links:
    - db
  environment:
    VIRTUAL_HOST: app.dev

If I try so start the containers with compose and give the nginx container a container volume with volumes_from: I get this issue with the Procfile.
proxy_1 | ERROR: open Procfile: no such file or directory
If I remove the volumes_from: the container starts succesfully.
Also, If I run the container with the docker command line: docker run -p 80:80 --volumes-from=c25c0356833f -v /var/run/docker.sock:/tmp/docker.sock:ro jwilder/nginx-proxy there is no problem at all.
My Dockerfile looks like this:
FROM ruby:2.2.0

RUN apt-get update -qq && apt-get install -y build-essential

# Postgres support
RUN apt-get install -y libpq-dev

# Nokogiri support
RUN apt-get install -y libxml2-dev libxslt1-dev

# JS runtime
RUN apt-get install -y nodejs

ENV APP_HOME /app

RUN mkdir $APP_HOME
RUN mkdir $APP_HOME/tmp
RUN mkdir $APP_HOME/log

# Copy the Gemfile and Gemfile.lock into the image.
# Temporarily set the working directory to where they are.
WORKDIR /tmp
ADD Gemfile Gemfile
ADD Gemfile.lock Gemfile.lock

# Install ruby dependencies
RUN bundle install

# Add app to container
ADD . $APP_HOME

# Add container working directory
WORKDIR $APP_HOME

# Expose puma port
EXPOSE 3000

# Precompile js/scss assets
RUN bundle exec rake assets:precompile

# Expose the assets directory
VOLUME ["/app/public"]

# Run puma server
CMD bundle exec puma -C /app/puma.rb

Any idea ?

It looks like the problem is that you're using volumes_from: web. This seems to be causing the /app directory in the proxy container to be masked by the VOLUME ["/app/public"] in the web container.
It seems to me like all that should do is make the public directory under /app point to /app/public from the other container without having any effect on /app itself. Since this works from the normal docker run command, this seems like a docker-compose bug.

Thanks @md5


Earlgrey: keccak_2share.sv doesn't work in Verilator

It gives errors:
keccak_2share.sv:235:24: Parameter without initial value is never given value (IEEE 1800-2017 6.20.1): 'Offset'
keccak_2share.sv:236:24: Parameter without initial value is never given value (IEEE 1800-2017 6.20.1): 'ShiftAmt'

I created test of that module: https://github.com/chipsalliance/UHDM-integration-tests/pull/408

Errors about local parameters can be reproduced by LocalParamInNestedForLoops from https://github.com/chipsalliance/UHDM-integration-tests/pull/409

Tests passed and all dependencies are removed from the list. When I try to remove keccak_2share, there is and error:
%Error: Internal Error: ../V3Width.cpp:134: Width dtype request on self-determined or preliminary VUP

I created the test of keccak_round module which is the only module that uses keccak_2share: https://github.com/chipsalliance/UHDM-integration-tests/pull/469
The error is reproduced.

It can be reproduced on the simpler example: https://github.com/chipsalliance/UHDM-integration-tests/pull/470

Removed from the list in https://github.com/antmicro/verilator/pull/496


[BUG] Azure Functions - Operations that change non-concurrent collections must have exclusive access

Library name and version
latest
Describe the bug
We are receiving a random error suddenly where APIM detects a 404 on a Function Invocation. This function simply gets a HTTP Incoming Requests and publishes it on Event Hub so we are a bit puzzled why this might happen.
What we could find back already is: “Operations that change non-concurrent collections must have exclusive access. A concurrent update was performed on this collection and corrupted its state. The collection's state is no longer correct."
After debugging together with internal Microsoft people, it seems that this might be causing it (to be validated again):
https://github.com/Azure/azure-sdk-for-net/blob/b407041de4f43cf9397a45bb3943e0aae736f731/sdk/eventhub/Microsoft.Azure.WebJobs.Extensions.EventHubs/src/Triggers/EventHubAsyncCollector.cs#L65
Expected behavior
No crashes in the runtime
Actual behavior
Runtime crash causing Azure Functions to stop working with error: "Operations that change non-concurrent collections must have exclusive access. A concurrent update was performed on this collection and corrupted its state. The collection's state is no longer correct."
Reproduction Steps

Create an Azure Function with the Code Below
Connect an Event Hub to it
Trigger the endpoint a lot under load

#r "Newtonsoft.Json"
#r "Microsoft.Azure.WebJobs.Extensions.Http"

using System.Net;
using Microsoft.AspNetCore.Mvc;
using Microsoft.Extensions.Primitives;
using Newtonsoft.Json;
using Microsoft.Azure.WebJobs.Extensions.Http;

public static async Task<IActionResult> Run(HttpRequest req, ILogger log, IAsyncCollector<string> outputEventHub2)
{
    string message = await req.ReadAsStringAsync();
    await outputEventHub2.AddAsync(message);
    return new OkResult();
}

Environment
Azure Functions

Thank you for your feedback.  Tagging and routing to the team member best able to assist.

Any update on this?

Hi @XavierGeerinck,
Any chance you can provide us with the full stack trace related to the exception? Or the relevant functions logs would also be helpful.
From looking at the code that you've referenced, the _batches dictionary already ensures exclusive access by virtue of the _batchSemaphore.

Hi @JoshLove-msft,
How would we be able to get a full stack trace of the Azure Function?

You should be able to see this in Functions monitoring from the Portal:
https://docs.microsoft.com/en-us/azure/azure-functions/functions-monitoring

@JoshLove-msft
I have been working with Xavier on this issue.
From the documentation it is not clear how to get a full stack trace. Can you please be more specific ? Most detailed information we were able to get is the following :

See reply of Gerdy

Are you able to click on the row that contains the error in App Insights?


Multiple sprites using the same animation multiplies the framerate

I have 3 sprites playing the "skeleton" animation, and they are playing their animation at 3x speed. When there's 2, it goes 2x, etc. Seems the animation data is being shared and the update function is being called for each.

Odd. How are you sharing the animation? kontra.sprite should clone the animation when created https://github.com/straker/kontra/blob/master/src/sprite.js#L152-L159. Though looking at the code I wonder if line 159 is assigning the firstAnimation to a non-cloned version and thus sharing accidentally.

And a quick test shows that the first animation is indeed not cloned due to that line.

Scratch that, the test was mocking animation.clone so it should be cloning properly in the sprite.

Here's a way to reproduce it.
https://jsfiddle.net/fav1rjn8/1/
in this fiddle, on line 39 I'm setting the animations right there. Guess I gotta clone them then?

Let me know if the latest version doesn't fix the problem.

Problem still exists. You can see in this fiddle:
https://jsfiddle.net/b6v1wtmn/8/
change the top line to a number to make it go real fast.

Ah, I see.  Yes that would cause them all to share all animations. If instead you pass kontra.sprite an animations property, then the sprite will clone all the animations for you so they don't share.
let sprite = {
    width: 72 * 2,
    height: 97 * 2,
    anchor: {
      x: 0.5,
      y: 0.5,
    },
    x: 300,
    y: 200,
    animations: spriteSheet.animations
  }

  // pass the animations to the sprite
  window.sprites = []
  for (let i = 0; i < SPRITE_COUNT; i++) {
    let s = kontra.sprite(sprite)
    s.x += i * s.width
    s.playAnimation('walk')
    window.sprites.push(s)
  }

The reason I'm assigning the animation object afterwards is because I'm defining the sprites I use beforehand, then on loading/resetting I'm loading the spritesheet images and creating the game sprites.

Ok, so would it make sense to add a setAnimations() function to Sprite, so I can use it to get a fresh copy when I assign it later?

Possibly. I'm wondering if I should must make animations a setter and then auto clone there since that's pretty important to making it work correctly.

Yeah, that's what I'm trying. I can send a PR.


Add missing goog.provides in drawinteraction.js

This PR adds missing goog.provides to the drawinteraction.js file. The compilation of applications fails without these goog.provides if the draw interaction is not used.

The build failure is a reminder (to me) that it will be nice to remove the need for test_requires.js.

Do you understand why the build fails? I don't right now.

I understood (with help from @tsauerwein) and fixed the problem with an additional commit.

LGTM

This deserves some comments before merging:
So https://github.com/elemoine/ol3/commit/879307da1bde22363c01548804cfdd6910e43e4b just added goog.provide's for ol.interaction.Draw.GeometryFunctionType and ol.interaction.DrawMode. But with just that commit I get an error when attempting to run the tests:
[wrk12 ol3 ((879307d...) $%)]$ make test
node tasks/test.js
goog.require could not find: ol.interaction.Draw.GeometryFunctionType
Error: goog.require could not find: ol.interaction.Draw.GeometryFunctionType

  http://<IP_ADDRESS>:3001/test/loader.js/home/elemoine/src/ol3/node_modules/closure-util/.deps/library/b0b32b6477e735055b8f53284d5cf6a4af1b29da/closure/goog/base.js:677
  http://<IP_ADDRESS>:3001/test/loader.js/home/elemoine/src/ol3/build/test_requires.js:173
make: *** [test] Error 1

Closure Library complains that the goog.require to ol.interaction.Draw.GeometryFunctionType in test_requires.js cannot be satisfied because it cannot find a corresponding goog.provide. Me: « What?! I just added that goog.provide, so Closure Library should be able to find it! ».
Actually doing the following is wrong:
goog.provide('ol.interaction.Draw.GeometryFunctionType');

/**
 * @constructor
 */
ol.interaction.Draw = function() {
  // ...
};

Because the definition of the ol.interaction.Draw constructor "destroys" the GeometryFunctionType that the goog.provide created on the (initial) ol.interaction.Draw object! So a goog.require to ol.interaction.Draw.GeometryFunctionType later in the code will fail with the error reported when attempting to run the tests.
So I decided to change ol.interaction.Draw.GeometryFunctionType to ol.interaction.DrawGeometryFunctionType, which is consistent with the way we define @typedefs elsewhere.
And for consistency with other files commit https://github.com/elemoine/ol3/commit/531b35d7c247159421a767bd9ce749e0ceb28554 also ol.DrawEvent and ol.DrawEventType to ol.interaction.DrawEvent and ol.interaction.DrawEventType.
I also added commit e766d00 that adds an upgrade note related to the renaming of the DrawEvent and DrawEventType  types.
Thanks @bartvde for the review.

Thanks for the explanation


have a plan to support the  Shelley  mainnet？

When cardano-cli is used to submit a transaction, txID cannot be returned in real time. Is there any method to obtain TXID when submitting a transaction? Or is there any plan to support Shelley main network

Hi @bocaigo, the txid is already known before submitting the transaction.
You can see it with the cardano-cli transaction txid command.

hi,This method can solve my problem. plan to deal with it this way. thx
------------------ 原始邮件 ------------------
发件人:                                                                                "input-output-hk/cardano-transactions"<EMAIL_ADDRESS>发送时间: 2020年12月29日(星期二) 上午10:27
收件人<EMAIL_ADDRESS>抄送: "~海~"<985433536<EMAIL_ADDRESS>主题: Re: [input-output-hk/cardano-transactions] have a plan to support the  Shelley  mainnet？ (#29)
Hi @bocaigo, the txid is already known before submitting the transaction.
You can see it with the cardano-cli transaction txid command.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.

This method can solve my problem. plan to deal with it this way. thx @rvl


Is react-cookie working well in multi-node environment?

I am currently using jwt as authentication and server-side rendering react web application.
Since some react component has some graphql query requiring retrieving some user information like email , if I directly input the link which is containing those components, the way is to get the email is from localStorage. However, server-rendering has no localStorage defined and therefore the graphql query would throw error after the component has been mounted.
It could be solved by react-cookie which could replace the function of localStorage. But if I deploy nodejs application to multiple nodes, is it possible for react-cookie to work well in multiple node environment without using ip-hash load balancing ?

Yes it is. react-cookie is the perfect solution for this because the cookies are automatically sent on every request by the browser. You should have no problem with load-balancers if your app share the same credentials for your users.


[W6.1f][F11-B1] Law Keng Ying

Implementation for abstract class

Accepting this PR after minimal review because another of your PRs for this tutorial was reviewed in detail.


fix(table-setting): hide column checkbox and lock icon when scroll

Summary

Raised by Jaideep M V when we scroll the row then it overlaps the header and shows lock icon and checkbox.
Resolved by setting z-index

:tada: This PR is included in version 1.24.13 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


sql: re-add GC job on schema element deletion

PR: https://github.com/cockroachdb/cockroach/pull/45962
From release notes:

Previously, after deleting an index, table, or database, the relevant schema change job would change its running status to waiting for GC TTL. The schema change and the GC process are now decoupled into two jobs. [#45962][#45962] {% comment %}doc{% endcomment %}

AFAICT, https://github.com/cockroachdb/cockroach/pull/45962 does not affect the user-facing syntax/behavior/output of online schema changes.
@pbardea Please reopen if you disagree. :)


store: check the ACI file's UID instead of the diskv dir

To check if we can remove an image we were checking the UID of the
diskv directory where the image is located.
This is wrong because several images can end up in the same diskv
directory and be fetched by different users, so we would be checking
against the first user that imported an image there.

Is there a way to test this? Without creating 257 different images...?

Is there a way to test this? Without creating 257 different images...?

Can't think of any way right now without doing very nasty manual modifications to the store an copying files around...

This is broken. See https://github.com/coreos/rkt/issues/2477#issuecomment-212999626

LGTM. I am OK we give users in rkt group access to all images. But this seems good enough for now? cc @sgotti

@steveeJ This PR and #2477 don't work, as discussed above. You had plans to have several stores in rkt instead of only one in /var/lib/rkt. Should this PR be closed then?

It seems we're doing this https://github.com/coreos/rkt/issues/2477#issuecomment-229930420
Closing.


UnhandledPromiseRejectionWarning: Unhandled promise rejection

Hello, since this weekend the Azure Devops we have , which use this task , send us the following error message
2021-09-06T13:16:49.0557733Z (node:1244) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 1): Error: Forbidden
This problem appear between the 4-6 September and it's the first time we met that (we use it since last year without any issue - thanks again).
I'm still looking for if the problem does not come from our infrastructure (I already check but no change was applied in the meanwhile in our infra, I still need to redo a check in case of).
Thanks for your advice
Miguel

it is not this plugin issue but you must add valid sender and verify in the smtp service you are using.
if using sendGrid, you can see add like mentioned below.
https://docs.sendgrid.com/ui/sending-email/senders