Move the "description" out of "allOf"-declaration

Problem description
"allOf" including a $ref and a 'description' is not compatible with openapi - generators for later implemantation usage.
    CreateSession:
      description: Attributes required to create a session
      type: object
      properties:
        <...>
        devicePorts:
          allOf:
            - description: The ports used locally by the device for flows to which the requested QoS profile should apply. If omitted, then the qosProfile will apply to all flows between the device and the specified application server address and ports
            - $ref: "#/components/schemas/PortsSpec"
        applicationServerPorts:
          allOf:
            - description: A list of single ports or port ranges on the application server
            - $ref: "#/components/schemas/PortsSpec"
        <...>

Expected behavior
The description should be out of the "allOf".
    CreateSession:
      <...>
        devicePorts:
          description: The ports used locally by the device for flows to which the requested QoS profile should apply. If omitted, then the qosProfile will apply to all flows between the device and the specified application server address and ports
          allOf:
            - $ref: "#/components/schemas/PortsSpec"
        applicationServerPorts:
          description: A list of single ports or port ranges on the application server
          allOf:
            - $ref: "#/components/schemas/PortsSpec"
         <...>

@maxl2287 Thanks for sharing your issues with open api generators.
The allOf with the description was added so that when the OpenAPI documentation is rendered it displays the top level description and not the description of the $ref.  We use this in both redoc and the swagger editor
To my knowledge, this is consistent with the Open API 3.0 specification.  Please share if you find a reference in the spec where this isn't compliant.
Which openapi generators are you having issues with?  Have you confirmed that this isn't a bug with the generator?
@jlurien I believe that you helped with this formating.  Can you comment as well?

Both the Swagger editor and ReDoc appear happy with this alternative construct, so I would support this for v0.10.0 onwards.
For v0.9.0 however, I think that should remain as it is, as this is a tooling rather than specification issue, and a release candidate version was available for some time to give developers an opportunity to pick up on such issues with their tooling. It is not so difficult to make the changes manually if it is desired to implement v0.9.0 and your tooling objects.
Alternatively, if we update v0.10.0-wip now, then that updated version (which will remain available through github, even if subsequent changes are made) will still effectively be v0.9.0, and can be used for implementation with tooling that experiences this issue.
It was proposed in Commonalities that we adopt OAS v3.1 so that we can use reference objects that support descriptions without the need for the allOf workaround. If you have an opinion on this, please comment that issue.

@RandyLevensalor

I use OpenApiTools -> openapi-generator
Yes I was already in communication with the developers of the openapi-generator-maven-plugin.
See here the issue and the confirmation that there is no bug in the generator: https://github.com/OpenAPITools/openapi-generator/issues/16332

@eric-murray I guess when we will have v3.1 then maybe these "allOf"-behaviours may also be gone, yes.

Hi @maxl2287,
I had the same problem and offered to migrate to oas 3.1.0 in commonalities/issue#11.
Please take a look and add your comments.

The alternate proposal is OK as it preserves the principle of $ref not having sibling elements. OAS 3.1 would also solve this but migrating to it has other implications. It allows to use all the potential JSON-schema to define more complex schemas for objects, which is nice, but many tools don't support it properly, so we'd probably have to limit in the guidelines how to use it or face many issues complaining about certain tools not supporting this or that.

I'm here with @eric-murray and @jlurien

we should not change v0.9.0
we shouldn't rush to OAS 3.1, at least not without additional guidelines
if it works fine for all we can accept the PR from @maxl2287 for v0.10.0-wip

The new feature in OAS 3.1 is not supported by the viewers (Redoc, Swagger editor), while the alternate proposal is, so I would stick to the new alternate version. About fixing 0.9.x, it depends on the severity of the issue with the tooling. It is not a functional change so release scope is not altered.

Hi all,
Openapi-generator 7.0.0-beta supports allOf with description inside but generates unwanted extra models...as explained in [commons issue 11](https://github.com/camaraproject/ Commonalities/issues/11) I had to rewrite all the definitions before generating the code. I provided a rewritten version of the spec in PI2 that one could use as a workaround.
And as I said in commonalities, editor-next.swagger.io supports version 3.1 as a redocly viewer in IntelliJ.
I vote to accept PR for 0.10.0-wip ... because we can live with this workaround in 0.9.0.


docs(cn):coc.md done

Description of Problem
Chinese translation of coc.md document
Proposed Solution
Additional Information

LGTM.


fix beta release

Alaska Airlines Pull Request
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Resolves: # (issue, if applicable)
Summary:
Please summarize the scope of the changes you have submitted, what the intent of the work is and anything that describes the before/after state of the project.
Type of change:
Please delete options that are not relevant.

[ ] New capability
[ ] Revision of an existing capability
[ ] Infrastructure change (automation, etc.)
[ ] Other (please elaborate)

Checklist:

[ ] My update follows the CONTRIBUTING guidelines of this project
[ ] I have performed a self-review of my own update

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.
Thank you for your submission!
-- Auro Design System Team

Summary by Sourcery
Fix the beta release by updating the design tokens version in the README, enhancing the hover container color in the demo API, and updating the icon version in the source code.
Bug Fixes:

Update the CSS stylesheet link in the README to use the correct version 4.9.2 of the design tokens.

Enhancements:

Modify the hover container color inverse value in the demo API documentation for better visual contrast.

Chores:

Update the icon version in the source code to reflect the latest version.

:tada: This PR is included in version 4.0.0-beta.1 :tada:
The release is available on:

npm package (@beta dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Make reserved visibility switcher for Reserved links

Should be implemented after https://github.com/deep-foundation/deeplinks/issues/140


fix new cases with const and let

(Here comes a bunch of PRs after a code fragments mass test with ESLint checks and Node.js runnings.)

Looks good! Thanks for fixing that $scope.model example. That was an oversight on my part, meant to fix that just recently.


double to sensor_val

Is your feature request related to a problem? Please describe.
I want to convert a double to sensor_val
Describe the solution you'd like
I would like a function double_to_sensor_value the way sensor_value_to_double exists.
Describe alternatives you've considered
Googled allot.
Additional context
None.

would like to get assigned to this issue

Any progress made on this? I'm currently using this function as an inline<EMAIL_ADDRESS>I included the test cases from: https://docs.zephyrproject.org/latest/reference/peripherals/sensor.html#c.sensor_value

A helper function sensor_value_from_double(struct sensor_value *, double) was added in commit 3c36cd4242ae94971ebe4d6dfcc6ade6ea9a6cb8.
Closing.


Low resolution CivicDataLab logo in the website footer

The resolution of the logo is much lower than its size in the website's footer.

thanks for pointing it out. I will need the original file of the logo, hopefully as an SVG. @gggodhwani

fixed in latest merge https://github.com/CivicDataLab/civicdatalab.github.io/commit/893fe4eb9dabc6cf61fde4c017af0e6c9d6ee465


Try to run doc build in mechanical container

I'm going to attempt to implement a docker run option for ansys.dyna.core.run


corber start "Could not find cordova.js script tag. Plugin loading may fail."

When trying to use corber start I get this error in the console, there is no cordova referenced in the index.html.
When I build the apk and look in the built source I can see the cordova.js
DEBUG: -------------------------------
DEBUG: Ember             : 3.18.1
DEBUG: Ember Data        : 3.18.0
DEBUG: Ember Postcss     : 6.0.1
DEBUG: Ember Simple Auth : 3.0.0
DEBUG: -------------------------------

I get this error in the console, too, but only when I'm opening my app in a browser rather than in an emulator or on a device.  I assumed that this is a warning I can ignore b/c the build I'm testing with corber start is not for the browser.
Our plan is to make two different builds - one for the browser using ember build... and one for mobile using corber build...

Can this be ignoried or do we ned to set actions?

I can not replicate the issue. Can you let me know:
-If you are Mac/Windows;

If the build is still successful despite the error?

I'm actually new to corber.
I'm on windows.
Cordova 9.0.0
Corber 1.4.3
Reproduce:

ember init
corber init
corber platform add android
add to environment.js
ENV.locationType = 'hash';
ENV.rootURL = '';
corber start  (in my case use no emulator)
Ember welcome page is visible. And hot reload is working.
access local host or via chrome inspect: "Could not find cordova.js script tag. Plugin loading may fail. "
The Error is coming from cordova.js - line 1739
"
// Tries to load all plugins' js-modules.
// This is an async process, but onDeviceReady is blocked on onPluginsReady.
// onPluginsReady is fired when there are no plugins to load, or they are all done.
"

Further Testing
Testing plugins.
ember-cordova-events  works
ember-cordova-platform works
also cordova-plugin-device works.
corber build --platform=android --environment=production --release
Works but I'm not able to install the apk on my device. Not sure yet where the problem is. Message is simple "not installed"
I just saw, that after building produktion - the index.js is gone anyway. So I have to move the stuff from there to the ember side?
I'm actually trying to migrate an older cordova project to corber.

Anyway there I got a bunch of errors naming "onPluginsReady". Saidly I broke it for now and it#s not possible for me to give ou more infos.

I have the same problem, corber start in my android phone. cordova.js & cordova_plugins.js is not find.
vue project


Distinguish capacity and no. of addressable bytes. (#1485)

Motivation:
Whilst the semantics of the capacity property are well defined, a
distinction between the number of addressable bytes in the buffer and
the total number of bytes allocated to the buffer would be clearer (note
that these values are not necessarily the same for example, when
constructing of COW slice from the original buffer:
buf.readSlice(length: 1)).
Modifications:

Repurposed the capacity property to always report the capacity of the
allocation underlying the storage.
Added new length property to show the number of addressable bytes of
the buffer (or derived COW slice).

Result:
The capacity of the original buffer and a COW slice with remain the same
as the original buffer until data is written to the slice. The length
property reports the number of addressable bytes e.g. the length of the
buffer obtained by buf.readSlice(length: 1) is 1.

@swift-nio-bot add to whitelist

In this case, given that capacity is used elsewhere in the implementation and has a well-defined meaning, I think I'd like to propose that we invert the patch:

I did give some thought to that. I concluded that inverting the meaning possibly introduces a weird semantic mismatch between  readSlice(length: 1) and .length/.capacity. On the other hand, it is true that now the meaning of capacity has changed and there may be behaviour that is dependent on the existing meaning (though I could find none in SwiftNIO itself). So I'm happy to take advice as to the best course.
Maybe a compromise is to leave capacity as is, and add a new property with clearly different semantics. Something like backingCapacity, allocatedCapacity?

I think a new property with a well distinguished name (I like allocatedCapacity) is good. The test failures in the build logs demonstrate that there are parts of NIO that do rely on this information, and it also happens to be used when resizing buffers in various cases (e.g. it interacts with reserveCapacity)


Warning: SPDX license identifier not provided in source file.

Warning: SPDX license identifier not provided in source file. Before publishing, consider adding a comment containing "SPDX-License-Identifier: " to each source file.

closed for inactivity


RSpec/Capybara/FeatureMethods auto-correct is not safe

Given the following file:
RSpec.feature 'Shifts report show' do
end

RSpec/Capybara/FeatureMethods  will auto-correct to:
RSpec.expect 'Shifts report show' do
end

But that correction is not safe, since the example group now no longer has type: :feature, which can lead to certain helpers not getting loaded (which is how I discovered the issue).
Either the correction should lead to type: :feature getting added:
RSpec.expect 'Shifts report show', type: :feature do
end

Or the cop should not have auto-correct marked as safe.
Rubocop version: 1.57.2
Rubocop-rspec version: 2.25.0

memo) RSpec/Capybara/FeatureMethods is a cop belonging to rubocop-rspec

Or the cop should not auto-correct top-level groups.
Thanks for reporting!

I am closing this issue, since the RSpec/Capybara/FeatureMethods cop was removed in #1876 / v3.0.0.


Remove version: Tableau.Public version 23.3.345

[Automated] It returns code over 400 in all urls
Microsoft Reviewers: Open in CodeFlow

Close with reason: Duplicate;


Use CodeClimate

We could start using Code Climate to have some static code analysis. It seems more efficient than Landscape, as far as I can see - it identifies hotspots, identical code, complexity, etc...
I opened an account for NoteOrganiser, I don't know if it is publicly visible yet. Could you confirm, @egolus?

The page works for me so it looks like it's public. Does it comment with updates in a PR as Landscape does?


[Infrastructure] - Automatic cherry pick to stable PRs aren't triggering the usual CI checks

I just merged the first successful automatic cherry pick PR using our new GitHub action. However, the cherry pick PR didn't cause any of our usual PR checks/tests to run.
Figure out how to get our usual checks to run for automatic cherry pick PRs.

The problem is that GitHub doesn't want one workflow triggering another workflow.
There are some possible workarounds for this. We need to pick an acceptable one:
https://github.com/peter-evans/create-pull-request/issues/48
https://github.com/peter-evans/create-pull-request/blob/main/docs/concepts-guidelines.md#triggering-further-workflow-runs


Compliance Summary: Emissions allocation data to be auto-populated in compliance summary

Description:
As a Regulated Operation Reporter, I want my emissions allocation data from the Allocation of Emissions page to be auto-populated in the compliance summary report so that I can review it as part of compliance,
Acceptance Criteria:
Given
When
Then
Development Checklist:

[ ] Checklist item
[ ] Checklist item
[ ] Checklist item
[ ] Meets the DOD

Definition of Ready (Note: If any of these points are not applicable, mark N/A)

[ ] User story is included
[ ] User role and type are identified
[ ] Acceptance criteria are included
[ ] Wireframes are included (if required)
[ ] Design / Solution is accepted by Product Owner
[ ] Dependencies are identified (technical, business, regulatory/policy)
[ ] Story has been estimated (under 13 pts)

Definition of Done (Note: If any of these points are not applicable, mark N/A)

[ ] Acceptance criteria are tested by the CI pipeline
[ ] UI meets accessibility requirements
[ ] Configuration changes are documented, documentation and designs are updated
[ ] Passes code peer-review
[ ] Passes QA of Acceptance Criteria with verification in Dev and Test
[ ] Ticket is ready to be merged to main branch
[ ] Can be demoed in Sprint Review
[ ] Bugs or future work cards are identified and created
[ ] Reviewed and approved by Product Owner

Notes:

Is this is relevant?

@patriciarussellCAS I think so, it is for capturing the dependency between the Allocation of Emissions page and Compliance Summary. More back-end-y stuff I imagine though, about how we feed in the data from Allocation of Emissions into Compliance. A dev can determine if we need separated out tickets like this of various screens feeding into Compliance Summary, or is one catch-all ticket enough though! @dleard @pbastia


Make Pinot minion stateless service

Ideally minion should be a K8s deployment instead of statefulset.
We may want to implement the auto cleanup feature for zk garbage for minion instances as well.

The auto cleanup minion is already implemented, so I guess we can directly move the the deployment side

@xiangfu0 Can you share the PR of auto-cleanup the minion? I lost track of it

There was an old issue : https://github.com/apache/pinot/issues/6526 and corresponding PR: https://github.com/apache/pinot/pull/6543
So the only thing left is the k8s changes which I can do it very soon.

https://github.com/apache/pinot/pull/8936


Combine Garage and Rollershutter Components -> Cover

Description: Combine Garage and Rollershutter Components -> Cover
Related issue (if applicable): fixes #1949
Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#597
Example entry for configuration.yaml (if applicable):
Multiple, included in changes to homeassistant.io
Checklist:
If user exposed functionality or configuration variables are added/changed:

[x] Documentation added/updated in home-assistant.io

If code communicates with devices:

[x] Local tests with tox run successfully. Your PR cannot be merged unless tests pass
[ ] New dependencies have been added to the REQUIREMENTS variable (example).
[ ] New dependencies are only imported inside functions that use them (example).
[ ] New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
[ ] New files were added to .coveragerc.

If the code does not interact with devices:

[ ] Local tests with tox run successfully. Your PR cannot be merged unless tests pass
[ ] Tests have been added to verify that the new code works.

I will have a look at this after the next release, kinda busy right now 👍

No rush, it still needs some work.

All tests should be migrated over too.

I think this is off to a very good start ! 🍻
We should break the converge to cover project into multiple PRs. Keep this one focussed on the initial component + the few platforms that it currently converts. That way other people can jump in to help with the migration of other platforms.

Great, thanks! I'm excited to have a contribution, no matter how small. I'll work on splitting up the PR and moving over the tests. If it's okay, I'd like to include command_line covers in the initial PR, since that's what I use and I can hopefully make sure it's working.

I'm having a hard time figuring out what to do with current_position (from rollershutter) vs the more simple state (from garage_door) --
It seems like a lot of duplication of code an function to keep both, so I started removing position -- figuring that few devices can report an exact position, but almost all can at least report open / closed.
stop_cover is similar -- it seems like a number of devices don't have any way to use this, so should I still include it as a core part of Cover?
On the other hand, without these, cover is getting closer and closer to being just a renamed garage_door.

It's fine to have position be a state attribute that is optional. For lights, it doesn't matter how bright, any brightness means it's on.
Same with stop, keep it there as an optional service that some might implement.

Just throwing out that Z-Wave calls anything that blocks something a "barrier" if anyone was unhappy with the "cover" name.

This PR seems to have gone stale. Closing it. You can reopen it when you're ready to finish it.


[#591] Update dotnet bots to target net 6 - Add .NETCore3.1 bots to the pipelines

Fixes # 591
Description
This PR adds the SimpleHostBotDotNet-3.1 and the EchoSkillBotDotNet-3.1 bots to the testing matrix.
Detailed Changes

Updated host bots' appsettings.json to include configuration for the new EchoSkillBotDotNet31 bot.
Added the new bots to the SingleTurn scenario in the test project.
Added the new bots to the pipelines:

01.Create Shared Resources
02.A Deploy skill bots
02.B Run skill test scenarios
FunctionalTests-CI

Added the new bots to the Docs/availableBotsList document.
Increased in 2 the default number of AppRegistrations to be created in the CreateAppRegistrations script.

Testing
The following images show the pipelines working after the changes.

/Promoted 595


Crash when using new lightweight isolates

Cross-posting this bug that I've managed to easily reproduce when using new Flutter lightweight engines, but looks like it much likely caused by some race-conditions inside the dart vm itself (given that with regular flutter engines the same never happens).
https://github.com/flutter/flutter/issues/79335
https://github.com/flutter/flutter/files/6228137/MultipleFluttersIos.30-03-21.05-08.crash.zip

Tracked by flutter bug.


Start tagging releases

Hey, I just noticed that you're not currently tagging releases. I was trying to debug a specific Chainpoint node version but it's a lot harder to find the code without tags.

The git SHA1 of the commit in chainpoint-node-src Is carried over to chainpoint-node in it's docker-compose.yaml file. Public releases only emerge from chainpoint-node repo and are tagged there as commits+tags on master branch.


Signal processes to stop on error and don't start new ones

Closes #7.
Bug was introduced in https://github.com/ash2k/bazel-tools/pull/1: new jobs were being started even if an error has occurred.
This PR brings back the old correct behavior and also changes the behavior to send SIGTERM to currently running jobs on error. This is how it works if the main process receives SIGTERM, so it makes sense to be consistent with that.
FYI @sluongng

ack-ed. Essentially this allow us to cancel the concurrent goroutine if 1 were to fail correct?
Thanks for the fix 👍

Yes, correct.

Another case - sequential execution (jobs=1) stops when a job fails.


AADSTS50196: The server terminated an operation because it encountered a client request loop

First of all thank you for this wonderful wrapper around msal. It really helped to simplify our code. We use the following code to retrieve a valid access token:
$msalParams = @{
    ClientId              = $azureClientId
    TenantId              = $azureTenantId
    IntegratedWindowsAuth = $true
    Scopes                = "https://outlook.office.com/EWS.AccessAsUser.All"
}
$token = Get-MsalToken @msalParams

This code is invoked multiple times by different PowerShell scripts. We assume it would retrieve a valid token from the cache and if there's no valid token it will try to acquire a new token silently. However, after multiple invocations the following error is thrown:

AADSTS50196: The server terminated an operation because it encountered a client request loop. Please contact your app vendor. Trace ID: 46e48f1f-ecfc-4b82-90a1-10b591f2a500 Correlation ID: c52d4881-e115-4a02-be39-9e46686e47fc Timestamp: 2020-06-17 07:52:06Z

Looking further into this, this seems to be a reported issue at msal. A remark from @jasonnutter:

Correct, if you get this error, it is because your requests are being throttled, which is due to making too many request in a short period of time. This can be mitigated by reducing the number of tokens you are requesting, and/or ensuring that you are retrieving tokens from the cache.

Is it possible that the CmdLet Get-MsalToken is not looking into the cache but requesting a token from Azure each time on invocation?
To reproduce this issue:

(0..50) | ForEach-Object {
    $msalParams = @{
        ClientId              = $azureClientId
        TenantId              = $azureTenantId
        IntegratedWindowsAuth = $true
        Scopes                = "https://outlook.office.com/EWS.AccessAsUser.All"
    }
    $token = Get-MsalToken @msalParams
}

I found the -Silent switch which can be used to accommodate the desired behavior. The only issue is it cannot be combined with the the switch -IntegratedWindowsAuth. Ideally one would like to do this:
(0..50) | ForEach-Object {
    $msalParams = @{
        ClientId              = $azureClientId
        TenantId              = $azureTenantId
        IntegratedWindowsAuth = $true
        Scopes                = "https://outlook.office.com/EWS.AccessAsUser.All"
    }
    $token = Get-MsalToken @msalParams -Silent
}

Because that is not possible we now require two steps to get the same result:

Acquire a token with -IntegratedWindowsAuth :

$msalParams = @{
    ClientId              = $azureClientId
    TenantId              = $azureTenantId
    IntegratedWindowsAuth = $true
    Scopes                = "https://outlook.office.com/EWS.AccessAsUser.All"
}
$token = Get-MsalToken @msalParams

Refresh the token:

$msalParams = @{
    ClientId              = $azureClientId
    TenantId              = $azureTenantId
    Scopes                = "https://outlook.office.com/EWS.AccessAsUser.All"
}
$token = Get-MsalToken @msalParams -Silent

Would it be possible to combine both steps?

Do you have requirement to only allow IntegratedWindowsAuth? I have not tried this myself but do you get the desired behavior when you remove the IntegratedWindowsAuth parameter? By default, the Get-MsalToken command will attempt a silent auth first, then IWA, and finally if all else fails it will do interactive in a web browser.
    $msalParams = @{
        ClientId              = $azureClientId
        TenantId              = $azureTenantId
        Scopes                = "https://outlook.office.com/EWS.AccessAsUser.All"
    }
    $token = Get-MsalToken @msalParams
}

If I remember correctly I really need the switch IntegratedWindowsAuth = $true because in the Azure App Registration I have the following :

That switch determines what client application types the AAD service principal will accept which is either Public or Confidential.
https://docs.microsoft.com/en-us/azure/active-directory/develop/msal-client-applications
The Get-MsalToken command will always use public client application object in MSAL when ClientSecret and ClientCertificate parameters are omitted.

In any case, I can tell you with certainty that when I did my test I really needed to add the -silent switch to have the token refreshed silently. If this was omitted it would not renew the token. Might have been my setup in Azure or something else, I just wanted you to know.

Just to clarify, MSAL will continue to return the same Access Token from the token cache until it expires or you specify the -ForceRefresh parameter.
I just tested without -IntegratedWindowsAuth or -Silent and it all appears to work silently as expected. Maybe this got fixed somewhere along the way but let me know if you are still unable to get it working.
## The same command does Integrated Windows Auth the first time and Silent for all subsequent call.
Get-MsalToken -ClientId $ClientId -TenantId mytenant.onmicrosoft.com


Allow multiple underscores inside a code block

If I do this indside a code block:
____
____

The output is:
____
____

Might be related: https://github.com/TryGhost/Ghost/pull/1552

To make sure I understand this issue, is what's happening such as below:
[my_link](https://mylink.tld)

Displays as mylink instead of my_link?
The only I've found to overcome that is to escape the underscore.


Colorpicker: Added color names to default validator

Fixes #2399

CONTRIBUTOR checklist (do not remove)
Please complete for every pull request

[ ] First-time contributors should sign the Contributor License Agreement.  If you haven't before, wait a few minutes and a bot will comment on this pull request with instructions.
[ ] npm run lint:fix has been run and linting passes.
[ ] Mocha, Jest (Storyshots), and components/component-docs.json CI tests pass (npm test).
[ ] Tests have been added for new props to prevent regressions in the future. See readme.
[ ] Review the appropriate Storybook stories. Open http://localhost:9001/.
[ ] Review tests are passing in the browser. Open http://localhost:8001/.
[ ] Review markup conforms to SLDS by looking at DOM snapshot strings.

REVIEWER checklist (do not remove)

[ ] TravisCI tests pass. This includes linting, Mocha, Jest, Storyshots, and components/component-docs.json tests.
[ ] Tests have been added for new props to prevent regressions in the future. See readme.
[ ] Review the appropriate Storybook stories. Open http://localhost:9001/.
[ ] The Accessibility panel of each Storybook story has 0 violations (aXe). Open http://localhost:9001/.
[ ] Review tests are passing in the browser. Open http://localhost:8001/.
[ ] Review markup conforms to SLDS by looking at DOM snapshot strings.

Required only if there are markup / UX changes

[ ] Add year-first date and commit SHA to last-slds-markup-review in package.json and push.
[ ] Request a review of the deployed Heroku app by the Salesforce UX Accessibility Team.
[ ] Add year-first review date, and commit SHA, last-accessibility-review, to package.json and push.
[ ] While the contributor's branch is checked out, run npm run local-update within locally cloned site repo to confirm the site will function correctly at the next release.

@kevinparkerson Please add a test for this.

This does work in the working color field.

Actually, the label says HEX, so I think it's OK not to have it work inside the dialog.

@interactivellama added a quick and simple test so it's ready for re-review!


pod update doesn't update to Facebook 5.5.0

I ran pod update GBHFacebookImagePicker and it did not pull the latest facebook core / login kits. Is there a way to run command to get 5.5.0 Facebook SDK?
Installing FBSDKCoreKit 4.42.0 (was 4.40.0 and source changed to `https://github.com/CocoaPods/Specs.git` from `https://github.com/cocoapods/specs.git`)
Installing FBSDKLoginKit 4.42.0 (was 4.40.0 and source changed to `https://github.com/CocoaPods/Specs.git` from `https://github.com/cocoapods/specs.git`)
Installing GBHFacebookImagePicker 2.6.0 (was 2.5.1 and source changed to `https://github.com/CocoaPods/Specs.git` from `https://github.com/cocoapods/specs.git`)

Please update the GBHFacebookImagePicker version in tour Podfile. The latest version is v3.1.2 which contain the FBSDK v5.


Pokecord features and ideas update

So as the title say, Features and Ideas. I know you can catch fishes and such. But since fishing is in the bot, allow users to catch certain items depending on the rod. To help them improve their pokes maybe ?
Only idea I have for now 😂
-UltPanda

This was the intention when fish was a private cog back on Pikachu but as
its public now it won't be in it. Its still in consideration for bring a
private feature. Items will all be bought via a store or trading


Bebop driver change to conform to right-hand convention

Negated angular.z. Now bebop driver follows right-hand convention, meaning +angular.z results in counter-clockwise turn.

Thank you for this fix. Could you please fix the error reporting, rebase this branch on top of arsdk_37, then update the PR. Apparently v3.6 SDK does not build anymore because one of its dependencies is not available from its old URLs: https://travis-ci.org/AutonomyLab/bebop_autonomy/jobs/100737806#L5982

I rebased on top of arsdk_37, but I'm still having the same build issue.

@jacob I patched indigo-devel to fix the 404 problem: #25 (I reported it upstream as well) . I also rebased arsdk_37 to include these changes. I will merge arsdk_37 into indigo_devel pretty soon. If you can update this PR as well, I will release 0.4 shortly after.

I must also add that unit tests also need to updated. I will add the instructions to the docs.

I ended up making another fork with the update. I'll close this and make a new PR after verifying I can build.


[ROX-8023] : Added Allow Privilege Escalation Policy criteria

Description
A detailed explanation of the changes in your PR.
Feel free to remove this section if it is overkill for your PR, and the title of your PR is sufficiently descriptive.
Checklist

[ ] Investigated and inspected CI test results
[x] Unit test and regression tests added
[ ] Evaluated and added CHANGELOG entry if required
[ ] Determined and documented upgrade steps
[ ] Documented user facing changes (create PR based on stackrox/openshift-docs and merge into rhacs-docs)

If any of these don't apply, please comment below.
Testing Performed

CI Testing
Added unit test to default policies test
Tested UI manually to see if 'Allow Privilege Escalation' policy criteria is listed.
Created a policy using the criteria on a local cluster, added a deployment with AllowPrivilegeEscalation set to true and checked if a violation shows up.

@charmik-redhat Added @vjwilson to eyeball the UI code as well.

@vjwilson, we should aim to show the policy criteria in alphabetical order within each group. Just for user's convenience.


Add support for action_results

Change Description
ABCABC
Change Type
Select ONE

[ ] Documentation

[ ] Stability bug fix

[x] Other

[ ] Other - special case

Consensus Changes

[ ] Consensus Changes

API Changes

[ ] API Changes

Documentation Additions

[ ] Documentation Additions

Can fill out the description of the change. I copied the PR template from eos


Add tmp_to_dst_file context manager to Dataset class

tmp_to_dst_file() takes final_dst argument, yields a temporary file path that you can write to. When the context manager exits, it moves the temporary file to final_dst
Resolves #148

I've tested the basic functionality of this PR with cru_ts. Here is an example of it being used.

Slight issue was encountered when using an NFS mounted dir for the tmp directory where the .nfs file cannot be removed from the tmpdir and causes the tempdir context manager's dir cleanup to fail and raise an exception (rmtree fails on .nfs file w/ OSError: [Errno 16] Device or resource busy: '.nfs000 error). See MRC below w/ originall CM commented out and solution implemented.
99% solution seems to be just manually creating the tmpdir ourselves (rather than using a context manager). Since the tmp_to_dst_file context manager is only for a single file, which we move from the tmp_dir, there isn't really a need to delete the full tmp dir.
import os
import time
import shutil
from tempfile import TemporaryDirectory, mkstemp, mkdtemp
from contextlib import contextmanager

@contextmanager
def tmp_to_dst_file(final_dst, tmp_dir=None):
    # with TemporaryDirectory(dir=tmp_dir) as tmp_sub_dir:
    tmp_sub_dir = mkdtemp(dir=tmp_dir)
    tmp_file, tmp_path = mkstemp(dir=tmp_sub_dir)
    # tmp_file.close()
    print(tmp_file, tmp_path)
    print(f"Created temporary file {tmp_path} with final destination {str(final_dst)}")
    yield tmp_path
    try:
        shutil.move(tmp_path, final_dst)
        # shutil.remove(tmp_path)
    except:
        print(f"Failed to transfer temporary file {tmp_path} to final destination {str(final_dst)}")
    else:
        print(f"Successfully transferred {tmp_path} to final destination {str(final_dst)}")
        # tmp_file.close()
        # shutil.rmtree(tmp_sub_dir)
        time.sleep(5)
        print(os.listdir(tmp_sub_dir))
        print(tmp_sub_dir)

final_dl_path = '/sciclone/home20/smgoodman/test.txt'
# tmp_dir = '/sciclone/home20/smgoodman/'
tmp_dir = None

with tmp_to_dst_file(final_dl_path, tmp_dir=tmp_dir) as dl_dst:
    print(f"Starting")
    try:
        print(f"Trying")
        with open(dl_dst, 'w') as f:
            f.write('test')
    except:
        print(f"Failed")
    else:
        print(f"Success")

# when using scr20, tmpdir still has .nfs file in it until python session ends
# print(os.listdir(tmp_sub_dir))


Deterministic global sampling of corpus ids

Tasks (corpus ids) are now sampled in a deterministic way such that all TaskQueueManagers can be aware of which task all other devices are training.
One benefit is that it is no longer necessary to communicate ready_t during gradient sync. This simplifies the algorithm, but does not seem to have any performance impact.
The PR includes refactoring of multiple locations in the code to use a joint representation of DistributedComponents, to determine which parameters are on which devices, and how they need to be communicated.

broadcast of initial model parameters
gradient communication during training
optimizer

There are additional places that could be refactored in future work:

model_builder
module splitter

This PR also includes a SimpleLookAheadBucketing, which provides dynamic minibatching with guarantees on the maximum batch size. This allows increasing the minibatch size without causing VRAM OOM.

LGTM, but I'm not sure about dropping the sentence-level batching + max len padding trick, which thus far is the one with the best tok/s, right? to what extent could this be added back in, given the current implementation?

The sentence-level batching + max len padding trick is implemented as a special case of the spiral bucketing data loader.
If we want both dynamic batching and the sentence-level batching + max len padding trick, then the easiest way is to keep all 3 implementations. However, it would be quite confusing to have two different ways of doing dynamic batching, of which one is known to be flaky. So maybe the dynamic spiral bucketing would be there but inaccessible through the config.
A better solution would be to refactor the sentence-level batching + max len padding trick so that it doesn't need the spiral bucketing data loader.
For benchmarking, it was just easier to rip it out.

(Apparently issues with logging the TQM on this branch. Has this been smoketested / tested? if so I'll dismiss this second review)

In commit fbe4f5c8a1f14cab9eb428cc1504539e07fb3893
I tried to reduce the log spam somewhat, and one of the actions was to only log a single TQM (the global one) instead of each device logging their own. It seems that a local TQM could be represented, but the __repr__ of the global one was broken.
I fixed the bug.

fix linting and this should be GTG

LGTM! will let you the honors of merging :']

Closes #8


aws-operator - fix lifecycle hook for instance coming up

The command is never send to AWS for instance health status when the nodes takes too long to 'be up'.

Done in this PR https://github.com/giantswarm/aws-operator/pull/3494


Client: Enable kingdom creation with specified attribute groups predefined

Choose which attribute groups will be copied to a new kingdom (kingdom.resources, kingdom.common, ...).

Closing - leave this to editation.


bug(button): mat-icon-button vs mat-button hover inconsistency

Is this a regression?

[ ] Yes, this behavior used to work in the previous version

The previous version in which this bug was not present was
No response
Description
I have a Tool Bar with 3 icons, 2 mat-icon-button and one mat-button:

When Hovering, the background color is different and inconsistent.
mat-button hover has a hint of the theme color:

mat-icon-button only has some opacity with a state layer color that ignores the theme.

Why this inconsistency?
Reproduction
StackBlitz link: Could not make one
Steps to reproduce:

Create a
Inside create a mat-button and a mat-menu-item
Icons are optional

Expected Behavior
I expect the same behaviour for both buttons.
Actual Behavior
They have different hover background colors.
Environment

Angular: 18.1.0
CDK/Material: 18.1.0
Browser(s): MS Edge
Operating System (e.g. Windows, macOS, Ubuntu): Windows 11

Should be resolved by https://github.com/angular/components/pull/29433.

Just updated to 18.1.1 and the inconsistency remains exactly the same.

What does your markup look like? You might also have to add the same color attribute on both of the buttons.

I am not using the color attribute. I'm using the m3 theme without the color-variants-backwards-compatibility.
<mat-toolbar class="header">
   <mat-toolbar-row class="mat-elevation-z6 sticky-top">
     <button mat-icon-button (click)="onMenuClick()" matTooltip="Menú">
       <fa-icon
         [icon]="faBars"
         class="inline-flex text-lg align-top"
         [fixedWidth]="true" />
     </button>
     <button
       mat-button
       [matMenuTriggerFor]="menuUsuario"
       matTooltip="{{ nombreUsuario | titlecase }}">
       <fa-icon
         matMenuItemIcon
         [icon]="faCircleUser"
         [fixedWidth]="true"
         class="text-xl align-middle" />{{ nombreUsuario | titlecase }}
     </button>
   <button mat-icon-button [matMenuTriggerFor]="theme" matTooltip="Tema">
     <fa-icon
       [icon]="faPaintBrush"
       class="inline-flex text-lg align-top"
       [fixedWidth]="true" />
   </button>
   </mat-toolbar-row>
 </mat-toolbar>

And my styles.scss
@use "@angular/material" as mat;
@use "sass:map";

@tailwind base;
@tailwind components;
@tailwind utilities;
@import url("https://fonts.googleapis.com/css2?family=Roboto+Flex:opsz,wght@8..144,100..1000&display=swap");

@import "./themes/m3-theme.scss";

@include mat.core();

@mixin app-theme($theme) {
  @include mat.all-component-themes($theme);
  @include mat.system-level-colors($theme);
  @include mat.system-level-typography($theme);
  // @include mat.color-variants-backwards-compatibility($theme);

  .accent {
    color: mat.get-theme-color($theme, secondary);
  }

  @include mat.progress-bar-color($theme, $color-variant: tertiary);
  @include mat.progress-spinner-color($theme, $color-variant: tertiary);

  ::-webkit-scrollbar {
    width: 5px;
    height: 5px;
  }
  ::-webkit-scrollbar-thumb {
    background: mat.get-theme-color($theme, outline);
    border-radius: 2px;
  }

  ::-webkit-scrollbar-thumb:hover {
    background: mat.get-theme-color($theme, outline-variant);
  }
}

html {
  .app-light-theme {
    @include app-theme($light-theme);
  }

  .app-dark-theme {
    @include app-theme($dark-theme);
  }

  @media (prefers-color-scheme: light) {
    .app-auto-theme {
      @include app-theme($light-theme);
    }
  }

  @media (prefers-color-scheme: dark) {
    .app-auto-theme {
      @include app-theme($dark-theme);
    }
  }
}

I'd have to look into it more, but I suspect that you'll have to use the color backwards compatibility, because by default icon buttons don't have a color in M3 while regular buttons take the primary color.

Thanks for the response. Is that behaviour by design or just something that will be fixed? Cause our aim is to use the native m3 theme and not use a compatibility layer and avoid having to set the color atribute everywhere.

In that case shouldn't mat-button also not use by default the primary color if there is no color property?
And if you see in my examples I don't use and don't expect to use de color attribute.
But if I use the these buttons as-is (without color) at least shouldn't they look the same? Including ripple, active, hover, etc?

@crisbeto Seems like this fell off you radar
@blogcraft Some context here - The styles for our components is not decided by us. We follow the specification described on https://m3.material.io/ which is a separate team / project


Pilot start fail when istio discovery service flag --registries=Mock is set.

Bug description
Istio discovery service flag --registries is set, then pilot start fail.
The description of flag --registries is : https://preliminary.istio.io/latest/docs/reference/commands/pilot-discovery/ .
Comma separated list of platform service registries to read from (choose one or more from {Kubernetes, Mock}) (default [Kubernetes])
So, i set --registries=Mock , but pilot 1.8 start fail.
[ ] Docs
[ ] Installation
[ ] Networking
[X] Performance and Scalability
[ ] Extensions and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
[ ] Upgrade
Expected behavior
Pilot start success when  istio discovery service flag --registries is set.
Steps to reproduce the bug
1.Download install package from https://github.com/istio/istio/releases/tag/1.8.0-alpha.2.
2. Add  --registries=Mock into file:  manifests/charts/istio-control/istio-discovery/templates/deployment.yaml.
...
         args:
          - "discovery"
          - --registries=Mock
          - --monitoringAddr=:15014
{{- if .Values.global.logging.level }}
          - --log_output_level={{ .Values.global.logging.level }}
{{- end}}
{{- if .Values.global.logAsJson }}
          - --log_as_json
{{- end }}
          - --domain
          - {{ .Values.global.proxy.clusterDomain }}
{{- if .Values.global.oneNamespace }}
          - "-a"
          - {{ .Release.Namespace }}
{{- end }}
{{- if .Values.pilot.plugins }}
          - --plugins={{ .Values.pilot.plugins }}
{{- end }}
          - --keepaliveMaxServerConnectionAge
          - "{{ .Values.pilot.keepaliveMaxServerConnectionAge }}"
...

Use istioctl to install pilot.

istioctl install --charts=./manifests --set profile=minimal -y

See istod deployment args, --registries=Mock is added.

...
   spec:
      containers:
      - args:
        - discovery
        - --registries=Mock
        - --monitoringAddr=:15014
        - --log_output_level=default:info
        - --domain
        - cluster.local
        - --keepaliveMaxServerConnectionAge
        - 30m
...

5.Pilot has errors as follows:
2020-11-19T15:19:51.562648Z	info	version: 1.8.0-alpha.2-ec349ef2a8a0bc846a87c8c10e02511e4865c9cc-Clean
2020-11-19T15:19:51.563031Z	info	flags:
2020-11-19T15:19:51.563453Z	info	initializing mesh networks
2020-11-19T15:19:51.563930Z	info	mesh networks configuration: {
   "networks": {
   }
}
2020-11-19T15:19:51.564032Z	info	initializing mesh handlers
2020-11-19T15:19:51.564058Z	info	initializing controllers
2020-11-19T15:19:51.564068Z	info	No certificates specified, skipping K8S DNS certificate controller
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x108 pc=0x240ad43]

goroutine 1 [running]:
istio.io/istio/pilot/pkg/config/kube/crdclient.New(0x0, 0x0, 0xc000078009, 0x7, 0x0, 0x0, 0x0, 0x0, 0xdf8475800, 0x7ffc6575c86f, ...)
	istio.io/istio/pilot/pkg/config/kube/crdclient/client.go:142 +0x123
istio.io/istio/pilot/pkg/bootstrap.(*Server).makeKubeConfigController(0xc001282ea0, 0xc00143e780, 0x7, 0x7fd677a08e98, 0x2, 0x8)
	istio.io/istio/pilot/pkg/bootstrap/configcontroller.go:428 +0xb8
istio.io/istio/pilot/pkg/bootstrap.(*Server).initK8SConfigStore(0xc001282ea0, 0xc00143e780, 0xb26800, 0xc00013e5a0)
	istio.io/istio/pilot/pkg/bootstrap/configcontroller.go:132 +0x50
istio.io/istio/pilot/pkg/bootstrap.(*Server).initConfigController(0xc001282ea0, 0xc00143e780, 0x0, 0x0)
	istio.io/istio/pilot/pkg/bootstrap/configcontroller.go:84 +0x993
istio.io/istio/pilot/pkg/bootstrap.(*Server).initControllers(0xc001282ea0, 0xc00143e780, 0x17, 0xc00181b778)
	istio.io/istio/pilot/pkg/bootstrap/server.go:1030 +0x11e
istio.io/istio/pilot/pkg/bootstrap.NewServer(0xc00143e780, 0x0, 0xc00144a420, 0x0)
	istio.io/istio/pilot/pkg/bootstrap/server.go:242 +0x8ca
main.glob..func1(0x4d471c0, 0xc000a59340, 0x0, 0x7, 0x0, 0x0)
	istio.io/istio/pilot/cmd/pilot-discovery/main.go:70 +0x175
github.com/spf13/cobra.(*Command).execute(0x4d471c0, 0xc000a592d0, 0x7, 0x7, 0x4d471c0, 0xc000a592d0)
	github.com/spf13/cobra@v1.0.0/command.go:842 +0x47c
github.com/spf13/cobra.(*Command).ExecuteC(0x4d46f20, 0x0, 0x0, 0x0)
	github.com/spf13/cobra@v1.0.0/command.go:950 +0x375
github.com/spf13/cobra.(*Command).Execute(...)
	github.com/spf13/cobra@v1.0.0/command.go:887
main.main()
	istio.io/istio/pilot/cmd/pilot-discovery/main.go:198 +0x31

Version (include the output of istioctl version --remote and kubectl version --short and helm version if you used Helm)
$ istioctl version --remote
client version: 1.8.0-alpha.2
control plane version: 1.8.0-alpha.2
data plane version: 1.8.0-alpha.2 (6 proxies)

How was Istio installed?
istioctl install --charts=./manifests --set profile=minimal -y

Can someone assign this issue to me?  I'm happy to create a PR to fix it.

Can someone assign this issue to me? I'm happy to create a PR to fix it.

@woyaodeyangguang  The same issue with me. I have fixed it. Here  https://github.com/istio/istio/pull/29049

Yours issue is not same with me. Because you don't specify config source or the file path for ConfigController, so the server will choose to adpot the default ConfigController which is KubeClient. The logic is correct, because you must need a ConfigController for reciving Istio Config to data plane. So you can specify config source or the file path for ConfigController, then it works. The following example is below.
spec:
      containers:
      - args:
        - discovery
        - --registries=Mock
        - --configDir=/tmp
        - --monitoringAddr=:15014
        - --log_output_level=default:info
        - --domain
        - cluster.local
        - --keepaliveMaxServerConnectionAge
        - 30m

@woyaodeyangguang The same issue with me. I have fixed it. Here #29049

Your issue is not same with me. Pilot run in k8s environment，so i can just change registry.

@woyaodeyangguang The same issue with me. I have fixed it. Here #29049

Your issue is not same with me. Pilot run in k8s environment，so i can just change --registries param.

If you don't specify K8s as your config source or don't set the registries as K8s，the server won't initial KubeClient. You can try the method as I mentioned above.
--registries=Mock
--configDir=/tmp

@woyaodeyangguang The same issue with me. I have fixed it. Here #29049

Your issue is not same with me. Pilot run in k8s environment，so i can just change --registries param.

If you don't specify K8s as your config source or don't set the registries as K8s，the server won't initial KubeClient. You can try the method as I mentioned above.
--registries=Mock
--configDir=/tmp

In some cases, in stead of specifying config source or file path for ConfigController  i think pilot should  use k8s as default config source in k8s environment. I have solved this issue in this case, I will create a PR later.


add jobs to support logging 3.11

Add job to support logging in 3.11.
i.e. https://github.com/openshift/openshift-ansible/pull/10328

/lgtm


while ( false ) Label: continue Label; parses even though it must not

Hello
continue's label when present must refer to a loop construct; in the above though, the label actually refers to a non-loop construct (in this case a continue.)

This is a duplicate of #1052.


Show field when not empty

what would be the condition if i want to show the next field when the first field has some value in it e.g show field 2 when field 1 is not empty.

Hi,
Have you tried something like data-condition="#field1 != ''"?

It works on your codepen but when i set this as an option in my application it throws error so i used this data-condition="#field1 != [ ]" and it worked just fine, thanks and btw are you working on that name [ ] and multiple checkboxes and radio button problem, i could really use that right now, thanks :)

Hmm.. That is interesting. Can you show your code?
Haven't started yet. But I am planning to start the next week.


Further token efficiency on in conditions

Thinking about conditions such as where SOMETHING in ['aaa', 'bbb', 'ccc'] say a model produces a token a for SOMETHING, can LMQL be made more efficient to infer that the only possibility is then aaa and skip to the end of SOMETHING?

Yes it can, and we actually have a first working implementation for this. I just need to finalize the last parts on the HF side. Should be ready soon :)


LangStringSet in JSON and RDF

The LangStringSet class is not modeled in RDF (https://github.com/admin-shell-io/aas-specs/blob/6ee8a5148153831ac81ff0d8408aad03219a207e/schemas/rdf/shacl-schema.ttl#L1171) or JSON (for instance https://github.com/admin-shell-io/aas-specs/blob/6ee8a5148153831ac81ff0d8408aad03219a207e/schemas/json/aas.json#L55) but in XML (https://github.com/admin-shell-io/aas-specs/blob/6ee8a5148153831ac81ff0d8408aad03219a207e/schemas/xml/AAS.xsd#L319). I recommend to:
a) introduce it in RDF and JSON, or
b) change the metamodel to List and adjust the XML only.

Decision from the working group: LangStringSet is not a class and therefore the current representation in JSON and RDF stays.


Allows the value in a JSON CredentialStore to be treated as base64 or hex encoded

Add hex and base64 encoder/decoders (only decode is actually needed here but adding encode for completeness sake). The codec pieces are separated out into their own standalone classes
in case custom credential store providers want to use them.

Add a new encoding_type param to config that defaults to hex (which
was previously the only supported option)

@htran1 is it possible for you take a look?


Allow disabling of systems by right clicking

Proposed Changes
Allowed disabling of systems by right clicking them in the system list. Additionally, I have also added a tooltip for when a system's name is truncated.
Related issues
Closes #110.

Is this ready for review at this stage?

Is this ready for review at this stage?

Yeah, ready for review! Feel free to checkout the branch and test on your end if you wish to see it more closely. 😄


2758 feature customisation

Handled CustomSettings through json file.

@keval-finimble this PR uses git merge instead of git rebase master.
Previously I stated don't use git merge as it makes it impossible to see the code change.

@keval-finimble please revert the git merge / restart the PR from current baseline master.
When doing a sync use > git rebase origin/master
If there are merge conflicts you'll have to go through each one and resolve it by hand.


more corruption

in the build area tests/interp area, run
rm -rf testdb
echo "yr../../../tests/date/checkjd2date.ll" |
../../src/liflines/llines testdb
Runtime Error at line 7: Error at line 7: jd2date: the arg #1 must be a float.
date: the arg must be a node.free(): double free detected in tcache2
looks like 2 issues maybe interperter is corrupting the script, and getting a double free on exit.
likewise, (probably the same issue)
in the  build area tests/interp directory (or in same directory as 1st case)
echo "yr../../../tests/interp/ifelse.ll" |
../../src/liflines/llines testdb
Report file: ../../../tests/interp/ifelse.ll
Runtime Error at line 47: ``(null)'': mismatched args and params
double free or corruption (fasttop)

I cannot reproduce this with recent master (9f5028db15c6b459d20d696fe01a4580aa33af29)

@stevedum I can't reproduce this.  Please let me know if I can close this issue.


Path Tool: Changed reference coordinates and added different behaviors for Mouse and Keyboard Inputs

Closes #2083
Hello, this is my first contribution. Hope the issue is resolved as intended.
If I've made any mistake or there is room for improvement, do let me know :)
Details:

The move_selected_points function is used in dragging as well as for keyboard nudging, so modifying its default coordinate system initially resulted in undesirable dragging behaviour.
Edited move_selected_points function. Added a bool parameter to check whether we're using keyboard (1) or dragging (0).
If we use keyboard it will now use document coords as reference, but for dragging it uses default coordinate system

Hi, welcome! Please be sure to run cargo fmt, and set up your text editor to run it automatically when saving the file. (This should already be the default in VS Code if you have the Rust Analyzer extension installed, but you'll have to figure out how to do that in other editors yourself.) Once you commit the formatted code, I can begin reviewing this. Thanks!

Hello Again. Although I had rust-analyser installed. I have ran the formatting command. Kindly review and let me know if any further changes are required.

It looks like the code doesn't compile. Have you thoroughly tested everything, including both the intended functionality and other likely regressions? I'll mark this as a draft until you have it working. Thanks!

When I tried to fix it manually idk what happened and some lines got deleted :') (i noticed that much later)
im fixing that issue and will submit it in a few minutes

#2083 was closed by #2095 last week.


Error "The selected action has not been completed"

In Sonoma 14.1.1 with Macmini M1
When i try command "Remove selected item locally" I've always got an error notification "The selected action has not been completed"

In Sonoma 14.1.1 with Macmini M1 When i try command "Remove selected item locally" I've always got an error notification "The selected action has not been completed"

Sorry that it's taken me a while to respond – only just saw this.
I've just tested the action on my M1 MacBook Pro running Sonoma 14.2.1, and it's working as intended for me. Could you please confirm the type of file (or files within the directory) that you are trying to remove locally? Also, are you positive that the file you select before the action is stored in iCloud Drive?

I've just tested the action on my M1 MacBook Pro running Sonoma 14.2.1, and it's working as intended for me. Could you please confirm the type of file (or files within the directory) that you are trying to remove locally? Also, are you positive that the file you select before the action is stored in iCloud Drive?

Thanks for the reply)
I don't think it depends on the file type, as I've tried many different files and even whole folders. Of course they were was synced to iCloud a long time.
Can the extension somehow depend on the iCloud's "Optimize Mac Storage" settings?

I've just tested the action on my M1 MacBook Pro running Sonoma 14.2.1, and it's working as intended for me. Could you please confirm the type of file (or files within the directory) that you are trying to remove locally? Also, are you positive that the file you select before the action is stored in iCloud Drive?

Thanks for the reply) I don't think it depends on the file type, as I've tried many different files and even whole folders. Of course they were was synced to iCloud a long time. Can the extension somehow depend on the iCloud's "Optimise Mac Storage" settings? Because a few days ago I had to enable this option as the iCloudControl was not working and so today I reinstalled it and everything seems to work. Can you confirm that iCloudControl will work with "Optimise Mac Storage" turned off ?

iCloud Control actually works better with Optimise Mac Storage disabled. Optimise Mac Storage basically does what iCloud Control does, except automatically. While they get along most of the time, Optimise Mac Storage will sometimes decide to reverse any actions the user makes through iCloud Control. It has a mind of its own when it comes to file synchronisation. So if you happen to need complete manual control over files synced to iCloud, it's best to disable Optimise Mac Storage.
Just confirming that you are running iCloud Control 1.8.1? iCloud Control 1.5.0 and below contain a bug which cause the situation you've described. And regarding the file types, very rarely, iCloud Control will have trouble managing uncommon file extensions. These issues have been mostly ironed out with updated releases, but with so many different file extensions in existence, it's hard to know for sure. If you are trying to manage common files (.docx, .pages, .pdf, etc.), then you should be fine there.

I apologise for taking so long to respond. Took a while to try different options.
I conclude that for me it is just after turning off the "Optimise Mac Storage" setting - your add-on stops working and I've always got an error notification "The selected action has not been completed"

I apologise for taking so long to respond. Took a while to try different options. I conclude that for me it is just after turning off the "Optimise Mac Storage" setting - your add-on stops working and I've always got an error notification "The selected action has not been completed"

Very odd. Never experienced or heard about this issue before. You could try an older version of the software (i.e. 1.8.0 or 1.7.0), but I highly doubt that will resolve your problem. Having tested iCloud Control on many different Macs, along with many users testing it too, I suspect that something about your particular Mac is preventing iCloud Control from running correctly. I have no idea what that may be, however.
There are instructions on the repo's README detailing how you can take advantage of the native macOS functions for iCloud synchronisation. These should work for you.


404 when going to a url directly

Describe the bug
I've compiled my sveltekit website with adapter-static. But when I compile the page and set it live I get an error when I go to a page directly. for example .nl/contact. Then I receive a 404.
I tried to fix this with a .htaccess file, but that caused problems like a page load when navigating.
When adding contact.html it works fine, but navigating to .nl/contact gives a 404
uses case:
-> *.nl -> contact button -> .nl/contact works fine
-> *.nl/contact.html works fine
-> *.nl/contact gives a 404.
Reproduction
-> *.nl -> contact button -> .nl/contact works fine
-> *.nl/contact.html works fine
-> *.nl/contact gives a 404.
Logs
No response
System Info
System:
    OS: macOS 12.5
    CPU: (8) x64 Intel(R) Core(TM) i7-7700HQ CPU @ 2.80GHz
    Memory: 163.46 MB / 16.00 GB
    Shell: 5.8.1 - /bin/zsh
  Binaries:
    Node: 14.17.5 - ~/.nvm/versions/node/v14.17.5/bin/node
    npm: 6.14.14 - ~/.nvm/versions/node/v14.17.5/bin/npm
  Browsers:
    Chrome: 101.0.4951.64
    Firefox: 96.0.3
    Safari: 15.5
    Safari Technology Preview: 15.4
  npmPackages:
    @sveltejs/adapter-node: 1.0.0-next.73 => 1.0.0-next.73
    @sveltejs/adapter-static: ^1.0.0-next.29 => 1.0.0-next.34
    @sveltejs/kit: 1.0.0-next.326 => 1.0.0-next.326
    svelte: 3.48.0 => 3.48.0

Severity
blocking all usage of SvelteKit
Additional Information
svelte.config.js
import preprocess from 'svelte-preprocess';
// import node from '@sveltejs/adapter-node';
import adapter from '@sveltejs/adapter-static';

/** @type {import('@sveltejs/kit').config} */
const config = {
	// Consult https://github.com/sveltejs/svelte-preprocess
	// for more information about preprocessors
	preprocess: preprocess(),

	kit: {
		adapter: adapter({
			// default options are shown
			pages: 'build',
			assets: 'build',
			fallback: null,
			precompress: false,

		}),

		prerender: {
			// This can be false if you're using a fallback (i.e. SPA mode)

			default: true
		}
	}
};

export default config;

my .htaccess is empty.

See #4404.


GPU allocated

Thank you for your excellent work on the paper.
I encountered a CUDA out-of-memory error with a batch size of 2 on an A100 GPU. I noticed in Table 3 that the GPU memory allocated is significantly larger than the number of trainable parameters. Could you please tell me why there is such a difference?
Thank you.

Hi, for this, may i ask which encoder you are using?
To take Vit-H as an example, even though the trainable parameters can be saved bc of parameter-efficient learning, the entire encoder needs to be put into GPU (bc even those parameters are not updated, but you still needs to calculate gradients going through them as they connected to other trainable Adapters during propagation).
In this case, even the trainable parameters is siginicantly lower, but the occupied GPU size is almost the same (or even more bc you add additional Adapters) as you train all the paramters.
Thus, to the best of my knowledge, parameter-efficient learning can mostly accelerate the training speed and prevent collapse but not help reduce the size of GPU occupation.
There might be some other PEFTs that can save GPU size, like Ladder-network or side-network, but i think Adapter/LoRA don't belong to that category, see the reference in https://www.reddit.com/r/MachineLearning/comments/186ck5k/d_what_is_the_motivation_for_parameterefficient/.


Only use bundled libgeos on Lambda

Allows local development

Coverage decreased (-0.02%) to 55.024% when pulling 90f85e02aca81a6f97a580f1c31667b84c55a243 on switch-libgeos into b80cac5853d0b868e1314b699af131b44a4f2ab9 on master.


Quantum and classical registers can be set by floats

Information

Qiskit Terra version: 0.19.6
Python version:
Operating system:

What is the current behavior?
This works:
qc = QuantumCircuit(3.7, 3.5)

Steps to reproduce the problem
What is the expected behavior?
Suggested solutions

Can I give take this?

sure...

Hey! can I give it a shot too?

There is a pending PR already for this issue

Hi! Is this issue open?

I think the pending PR is close to be merged.

Closed via https://github.com/Qiskit/qiskit-terra/pull/4858


Netmon Tool Download broken and not accesible

[Network Monitor Tool download link is broken on the URL https://docs.microsoft.com/en-us/windows-hardware/drivers/portable/using-the-netmon-tool which is being shared to customers and CSS]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 0c542807-0787-c386-43d7-79f230e23bcd
Version Independent ID: beec032f-ad86-4615-3702-c243454f3eb8
Content: Using the Network Monitor Tool - Windows drivers
Content Source: windows-driver-docs-pr/portable/using-the-netmon-tool.md
Product: windows-hardware
Technology: windows-devices
GitHub Login: @EliotSeattle
Microsoft Alias: eliotgra

The tool has been reinstated and is available for download once again.
Thanks so much, @somajagadeesh!!!
Eliot


Getting data from Google analytics

Hello.
I have set analytics for my mobile application which sends track data to GA. According to this gems readme, I can send tracking data to google via my rails application. However, there isn't written anything about retrieving data from GA.
Is it even possible?

no it isn't.
the scope of rack-tracker is to remove the need to handle all the tracking services without messing with partials or helpers directly within the controller
maybe google-api-client is something that you're looking for.


Bug in pfio (nonstandard Fortran)

In the code snippet below, we have use cases (e.g. ExtData1G_case12) which send down a zero-sized array.   c_loc() is not permitted on zero sized arrays, and NAG flags this.
One possibility is that the array should not be zero sized, in which case @bena-nasa should track down why that happens, and a runtime check should be added to trap it in the code below.     The other possibility is that this is intentional, in which case @weiyuan-jiang should devise an extension to support this.
https://github.com/GEOS-ESM/MAPL/blob/d3085a106ebdb62c9b13ccd6b2c642e34059765a/pfio/ArrayReference.F90#L48-L59

@tclune case12 is exactly the one that intentionally exercises the case when the grid cannot be decomposed so yes, some processes have no data or 0 sized arrays

Will this branch fix the issue ? @tclune
https://github.com/GEOS-ESM/MAPL/tree/feature/wjiang/bypass_cloc

@weiyuan-jiang
All the extdata tests are here:
https://github.com/GEOS-ESM/MAPL/tree/main/Tests/ExtData_Testing_Framework/test_cases
To run any one of them you copy the files from the test case somewhere and run ExtDatDriver.x using the appropriate number of processors.
So to run test 12 you could copy the contents of case12 to a directory
In CAP1.rc and CAP2.rc add "USE_EXTDATA2G: .true. "
Then mpirun -np 216 path_to_install/bin/ExtDataDriver.x


Enrichment during parsing

Note: This is based on #18, so review only after that one is merged to reduce diff volume.
With #17 we parse files now in the correct order to theoretically resolve all dependencies right away, thus making manual enrichment essentially superfluous. However, for this to take effect, we have to provide the already parsed program units as definitions to make_complete, which is added in this PR.
Although it should allow to entirely retire the _enrich step in the Scheduler, I have kept it for the moment to avoid fallout in edge cases where this doesn't work for some reason. It works on ecrad, though.
Accompanied with this are tests for nested derived types, where intermediate type definitions can only be resolved via this enrichment method.
With this in place, I have hit a situation in the frontends, where imports include symbols that we have for some reason not in the symbol table of the module they are imported from, although we have the corresponding module parsed. This happens, when these symbols themselves stem from an unqualified import from another module. Such situations are now handled gracefully in the same way as when the corresponding module was not available. We should be able to resolve this in the future cleanly by chasing also imports as dependencies in the Scheduler.
Lastly, piggy-backed is a workaround for wrongful classification of inline calls as array subscripts in the fparser frontend. We repair this already later on with type information from the symbol table, however, in the process we would only convert the Array node to a ProcedureSymbol, thus loosing the information about the inline call and its arguments. This is now being taken care of in the LokiIdentityMapper by detecting such conversions and creating a new InlineCall node with the previous dimensions attributes as parameters.

Codecov Report

Merging #22 (817e0b8) into main (44cfc04) will increase coverage by 0.33%.
The diff coverage is 95.79%.

@@            Coverage Diff             @@
##             main      #22      +/-   ##
==========================================
+ Coverage   90.91%   91.25%   +0.33%
==========================================
  Files          85       76       -9
  Lines       14289    13444     -845
==========================================
- Hits        12991    12268     -723
+ Misses       1298     1176     -122

Flag
Coverage Δ

lint_rules
?

loki
91.25% <95.79%> (+0.09%)
:arrow_up:

transformations
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

loki/tools/util.py
75.46% <75.00%> (-0.01%)
:arrow_down:

loki/subroutine.py
94.85% <80.00%> (-0.44%)
:arrow_down:

loki/bulk/scheduler.py
75.29% <88.88%> (+0.80%)
:arrow_up:

loki/tools/strings.py
93.68% <90.00%> (-0.70%)
:arrow_down:

loki/frontend/fparser.py
92.66% <96.15%> (+0.55%)
:arrow_up:

loki/__init__.py
92.10% <100.00%> (+0.21%)
:arrow_up:

loki/backend/cgen.py
89.70% <100.00%> (+0.05%)
:arrow_up:

loki/backend/fgen.py
96.88% <100.00%> (+0.02%)
:arrow_up:

loki/backend/maxgen.py
82.02% <100.00%> (+0.10%)
:arrow_up:

loki/backend/pygen.py
82.48% <100.00%> (+0.12%)
:arrow_up:

... and 29 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


glob breaks nim CI

I've pushed https://github.com/nim-lang/Nim/pull/15647 until this is fixed, please remember to revert https://github.com/nim-lang/Nim/pull/15647 after this is fixed
https://github.com/nim-lang/Nim/pull/15642/checks?check_run_id=1277836246

 PASS: Vindaar/ggplotnim C                       (24.69 sec)
  FAIL: citycide/glob C
  Test "citycide/glob" in category "nimble-packages-1"
  Failure: reBuildFailed
  package test failed
  $ nimble test
    Executing task test in /Users/runner/work/Nim/Nim/pkgstemp/glob/glob.nimble
    Verifying dependencies for<EMAIL_ADDRESS>        Info: Dependency on regex@>= 0.7.4 already satisfied
    Verifying dependencies for<EMAIL_ADDRESS>        Info: Dependency on unicodedb@>= 0.7.2 already satisfied
    Verifying dependencies for<EMAIL_ADDRESS>        Info: Dependency on unicodeplus@>= 0.5.0 already satisfied
    Verifying dependencies for<EMAIL_ADDRESS>        Info: Dependency on unicodedb@>= 0.8 already satisfied
    Verifying dependencies for<EMAIL_ADDRESS>        Info: Dependency on segmentation@>= 0.1 already satisfied
    Verifying dependencies for<EMAIL_ADDRESS>        Info: Dependency on unicodedb@>= 0.8.0 already satisfied
    Verifying dependencies for<EMAIL_ADDRESS>    Compiling tests (from package glob) using c backend
  /Users/runner/work/Nim/Nim/pkgstemp/glob/src/glob/regexer.nim(10, 25) Warning: inherit from a more precise exception type like ValueError, IOError or OSError. If these don't suit, inherit from CatchableError or Defect. [InheritFromException]
  /Users/runner/work/Nim/Nim/pkgstemp/glob/src/glob.nim(345, 49) Warning: Use `re` instead; toPattern is deprecated [Deprecated]
  /Users/runner/work/Nim/Nim/pkgstemp/glob/src/glob.nim(380, 16) Warning: Use `re` instead; toPattern is deprecated [Deprecated]

  [Suite] globToRegex

  [Suite] procs accept both string & glob
      /Users/runner/work/Nim/Nim/pkgstemp/glob/tests.nim(62, 35): Check failed: "src/dir/foo.nim".matches("src/**/*.nim", false)
      /Users/runner/work/Nim/Nim/pkgstemp/glob/tests.nim(63, 35): Check failed: "src/dir/foo.nim".matches(glob("src/**/*.nim", false))
    [FAILED] matches
      /Users/runner/work/Nim/Nim/pkgstemp/glob/tests.nim(81, 19): Check failed: seqsEqual(toSeq(walkGlob("temp/**/*.{jpg,nim}")), expected)
      /Users/runner/work/Nim/Nim/pkgstemp/glob/tests.nim(82, 19): Check failed: seqsEqual(toSeq(walkGlob(glob("temp/**/*.{jpg,nim}"))), expected)
    [FAILED] walkGlob, walkGlobKinds

  [Suite] regex matching
      /Users/runner/work/Nim/Nim/pkgstemp/glob/tests.nim(121, 21): Check failed: isMatchTest("src/**/*.nim", "src/foo.nim")
      /Users/runner/work/Nim/Nim/pkgstemp/glob/tests.nim(122, 21): Check failed: isMatchTest("src/**/*.nim", "src/foo/deep.nim")
      /Users/runner/work/Nim/Nim/pkgstemp/glob/tests.nim(123, 21): Check failed: isMatchTest("src/**/*.nim", "src/foo/deep/deeper/dir/file.nim")
    [FAILED] wildcards & globstars
      /Users/runner/work/Nim/Nim/pkgstemp/glob/tests.nim(244, 21): Check failed: isMatchTest(pattern, "src/file.nim")
      /Users/runner/work/Nim/Nim/pkgstemp/glob/tests.nim(245, 21): Check failed: isMatchTest(pattern, "src/file.js")
      /Users/runner/work/Nim/Nim/pkgstemp/glob/tests.nim(246, 21): Check failed: isMatchTest(pattern, "src/deep/file.nim")
      /Users/runner/work/Nim/Nim/pkgstemp/glob/tests.nim(247, 21): Check failed: isMatchTest(pattern, "src/deep/deeper/dir/file.nim")
      /Users/runner/work/Nim/Nim/pkgstemp/glob/tests.nim(248, 21): Check failed: isMatchTest(pattern, "src/deep/deeper/dir/file.js")
    [FAILED] medium complexity

  [Suite] pattern walking / listing
      /Users/runner/work/Nim/Nim/pkgstemp/glob/tests.nim(323, 21): Check failed: seqsEqual(toSeq(walkGlob("temp/**/*.{nim,jpg}")), @[p"temp/deep/dir/file.nim",
      p"temp/not_as/deep.jpg", p"temp/not_as/deep.nim", p"temp/shallow.nim"])
      /Users/runner/work/Nim/Nim/pkgstemp/glob/tests.nim(334, 21): Check failed: seqsEqual(toSeq(walkGlob("temp/**/*.nim")), @[p"temp/deep/dir/file.nim",
      p"temp/not_as/deep.nim", p"temp/shallow.nim"])
    [FAILED] basic

  [Suite] utility procs
      /Users/runner/work/Nim/Nim/pkgstemp/glob/tests.nim(436, 32): Check failed: "src/foo.nim".contains(g.regex)
      /Users/runner/work/Nim/Nim/pkgstemp/glob/tests.nim(437, 36): Check failed: "src/dir/foo.nim".contains(g.regex)
    [FAILED] glob
  Error: execution of an external program failed: '/Users/runner/work/Nim/Nim/pkgstemp/glob/tests '
         Tip: 13 messages have been suppressed, use --verbose to show them.
       Error: Execution failed with exit code 256
          ... Command: /Users/runner/work/Nim/Nim/bin/nim c --noNimblePath -d:NimblePkgVersion=0.9.0 --path:/Users/runner/.nimble/pkgs/regex-0.17.0 --path:/Users/runner/.nimble/pkgs/unicodedb-0.9.0 --path:/Users/runner/.nimble/pkgs/unicodeplus-0.8.0 --path:/Users/runner/.nimble/pkgs/unicodedb-0.9.0 --path:/Users/runner/.nimble/pkgs/segmentation-0.1.0 --path:/Users/runner/.nimble/pkgs/unicodedb-0.9.0 --hints:off --hints:off --verbosity:0 -r tests
  stack trace: (most recent call last)
  /private/var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/nimblecache-946033505/nimscriptapi_435504397.nim(187, 16)
  /Users/runner/work/Nim/Nim/pkgstemp/glob/glob.nimble(13, 8) testTask
  /Users/runner/work/Nim/Nim/lib/system/nimscript.nim(260, 7) exec
  /Users/runner/work/Nim/Nim/lib/system/nimscript.nim(260, 7) Error: unhandled exception: FAILED: nimble c -y --hints:off --verbosity:0 -r tests.nim [OSError]
         Tip: 1 messages have been suppressed, use --verbose to show them.
       Error: Exception raised during nimble script execution

  PASS: dvolk/gnuplot.nim C                       ( 1.48 sec)

The cause of this breakage is that glob does not work with regex 0.17.0. 0.16.2 works as expected.

Thanks for the hint @squattingmonk — I've soft-pinned the regex package to < 0.17.0 for now. I'm not sure specifically what the breakage is caused by yet.


Update post_handler.py

Add more subreddits

I'll need to talk to the moderators of those subreddits to see if they will allow the bot

I opened the bot to /r/all's "hot" posts, so I will close this issue


add utc helper and computed property macro

Adds support for moment.utc so that you can do things like:
{{utc interval=1000}}
{{utc (moment now)}}    {{!-- Mon Feb 12 2018 21:30:20 GMT+0000 --}}
{{moment-format (utc) 'YYYY-MM-DD HH:mm:ss Z'}}    {{!-- 2018-02-12 21:30:20 +00:00 --}}
{{utc '2018-01-01T00:00:00+01:00' 'YYYY-MM-DD HH:mm:ssZ'}}  {{!-- Sun Dec 31 2017 23:00:00 GMT+0000 --}}

Also included a utc computed property macro, which I think takes care of Issue #270 .

Thank you!  It will be part of the next release :)


Support multiline string in " quoted string

\ is for removing \n from the value.
foo "line1
line2" # => value is "line1
line2"
bar "line1\
line2" # value is "line1line2"

@repeatedly Do you know how to delete 2dfc442(https://github.com/llby/fluentd/tree/2dfc442b237b9c26c00821c14d35df432e2a7aff)?

I'm not sure but it seems no problem.

Merged the patch. This will be available in the next version.


Raspberry pi does not display OAK-D devices

I installed the depthai dependency on the Raspberry Pi according to the tutorial, but the device still does not display after connecting the OAK-D device, I want to know what is the reason, could it be because of insufficient power supply? The device I use is a Raspberry Pi 4B.

Hi @2640546445 ,
Could you also share the error log? You might also want to check preconfigured RPI image for OAK cameras.
Thanks, Erik

I did not use preconfigured RPI image,beacuse I am using my owe Raspberry Pi image.My problem is that the OAK-D has been connected to the raspberry pi through the data cable, but the raspberry pi shows that there are no devices available.

Raspberry Pi does not recognize OAK-D device

Hi @2640546445 ,
I would suggest the following:

Follow the troubleshooting docs
Use a preconfigured RPI image, or, follow installation steps that were used when creating this image (here)

Thanks, Erik

Sorry to bother you again. I used a preconfigured RPI image, but still the same problem. I want to supply power through the power jack, but the OAK-D-lite does not have a power port. So what should I do, does not OAK-D-Lite support Raspberry Pi?

Hi @2640546445 ,
Could you send a photo of how you have the OAK-D-Lite connected to the RPI? Which RPI do you have? You could use something like a Y-adapter (or maybe powered usb3 hub) to power the OAK-D-Lite externally (not with the RPI).
THanks, Erik

Sorry to bother you for so long. The problem is solved, there is a problem with the data cable, and it is solved by changing one.
Thanks for your patience

No worries, great to hear that you solved the issue!


Windows: Filename too long

I'm getting a filename too long warn when unzipping Boost/1.59.0@lasote/stable on my Win7 machine. It's just a doc file, but I thought reporting it could help none the less.
Error extract boost_1_59_0/libs/geometry/doc/html/geometry/reference/spatial_indexes/boost__geometry__index__rtree/rtree_parameters_type_const____indexable_getter_const____value_equal_const____allocator_type_const___.html

The build itself was successful.

I am seeing this as well but more than initially reported. My conan install path is only set to E:\conan. Attaching a txt file with a list of them.
conan-boost-long-filenames.txt

@ksmith-mm It was fixed in Boost 1.60.0 package (with short_paths = True attribute). Do you need to use 1.58.0? I could make the patch to this version.


POST /users

POST /users
Story

As a developer
I want an api that creates a single user
so that I can add a user

Acceptance Criteria

Create the POST /users api use a mongo collection called 'users'
To create, use something like .insert(req.body)
your response line should be something like res.json(result);
Update your test to pass under with the new mongo connection

Approach

Use the API listed here:

http://mongodb.github.io/node-mongodb-native/2.2/api/Db.html
http://mongodb.github.io/node-mongodb-native/2.2/api/Collection.html

@Dea-K Sprint due Tuesday 3/28


hetkmers.py is computing after it saved coverages_2.tsv file

I made a small trick to avoid the dump file in my computer (I asked kmc to save the output to std out stream and piped it in the hetkmers.py). The log suggest that the job should be finished

but it's still actively computing on a single core. This is a htop screenshot:

The output seems correct I managed to create a smudgeplot so I killed, but it's strange no?

This is indeed something I have seen before as well. It is odd. Perhaps it is because the code is incorrectly closing either the q queue or the results queue? I will test some changes and update if I can fix it.

I am afraid that the problem still persist, but only for a big file. When I take just the first 1000 lines it works as expected.

I am not re-opening this issue because I don't have a small reproducible example and because I don't this it's a big issue right now (we have better things to do). I just want to keep a record.

I think it is still the hetkmers script because I also got that error with really large files, and I wasn't piping. I still think it has something to do with not correctly closing/joining the queues, but I'm not exactly sure.

Till now I was running smudgeplot on a server therefore I had no problem with manually killing the job. However, now I tried to use our cluster and there it's a pain in the butt because the job just get killed by the time limit which occupies cluster way longer than it should.
I could reproduce this behavior with genome size of 1.3G. But I still don't have a reproducible example. One way to go could be using a debugger for python pdb or alternatively asking on a stack exchange where there are tons of python gurus.

I asked on Bioinformatics.stackexchange.
So far they confirmed your suspicion, "this is probably caused by a deadlock in multi-threading." – user172818. Using better keywords I found this question that seems to deal with exactly the same behaviour.

I have a suggestion how to resolve this problem.
Let's add a simple test that if user loads more than certain number of kmers, the program quits suggesting to use the fast algorithm discussed #24 (I can check what is the smallest genome when I have encountered this bug)

implicitly resolved by #27. If this problem occurs again, we will reopen this issue.


Fix an incorrect autocorrect for Rails/TimeZone when Time.new has a string argument

This PR fixes incorrect autocorrect for Rails/TimeZone when Time.new has a string argument.
Expected Behavior
# Before autocorrect
Time.new("2024-12-21 12:00:00")

# After autocorrect
Time.zone.parse("2024-12-21 12:00:00")

Actual Behavior
# Before autocorrect
Time.new("2024-12-21 12:00:00")

# After autocorrect
Time.zone.local("2024-12-21 12:00:00")

Autocorrected code doesn't work.
irb(main):002> Time.zone.local("2024-12-21 12:00:00")
(irb):2:in `<main>': invalid value for Integer(): "2024-12-21 12:00:00" (ArgumentError)

      time = Time.utc(*args)
                      ^^^^^

Steps to reproduce the problem
Run bundle ex rubocop -a --only Rails/TimeZone on the code below:
Time.new("2024-12-21 12:00:00")

RuboCop version
❯ rubocop -v
1.68.0

Replace this text with a summary of the changes in your PR.
The more detailed you are, the better.

Before submitting the PR make sure the following are checked:

[x] The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
[x] Wrote good commit messages.
[ ] Commit message starts with [Fix #issue-number] (if the related issue exists).
[x] Feature branch is up-to-date with master (if not - rebase it).
[x] Squashed related commits together.
[x] Added tests.
[x] Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
[x] Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.
[ ] If this is a new cop, consider making a corresponding update to the Rails Style Guide.

@koic
Thanks!
I totally agree with your suggestion and apply it.

@mterada1228 This looks good to me. Can you squash your commits into one?

@koic
Thank you for your review.
I squashed my commits into one.

Thanks!


When can we expect the multimodal model to be released?

Hi, thanks for your interest in our work. We have released the inference code. In the next few days, we will also release the training scripts.

I want to know when the new model will be released, it looks interesting 👀

Thanks for your interest. We have released the model.


Added SnowTrace integration

Added a few basic account apis into the SnowTrace node.

@abdullahranginwala thanks for taking this! are there more apis to be implemented?
would be better to have just the snowtrace logo without the word

There are more apis to be implemented, I'm working on them. I'll update the logo as well.

@abdullahranginwala I had updated the logo and added more APIs, if you pull from latest master branch you will see it. Feel free to add more API if you like


Strip strings in Carbide parser

Right now, the Carbide parser doesn't strip strings before doing parsing, so a string like "a += b" would be transformed into "a = a + b" despite being in a string.

Fixed with 0ba4fce!


Streaming quality issues

Hello, We're working on a new product using lf.swift that streams and records simultaneously.
Our recordings are very nice, high quality but the stream is not.
We're looking for help with this and can provide any information as far as configuration, code etc.
We'd also be willing to pay someone for their consulting time as this is an urgent matter.
Thanks!

Please see the Settings Section. https://github.com/shogo4405/lf.swift/blob/master/README.md#settings
Try change "bitrate" properties.
Best regards.

What is the default bitrate?

Video -> 160 * 1024 = 160kbps
Audio -> 32 * 1024 = 32kbps


Fix #113

Hi, first try at contributing.
This fixes the bug of the usual keypress not working when the email text is selected.
I narrowed down the problem to the read email sandbox iframe not having attached handlers, and this is fixed by attaching keypress handlers in read-sandbox.js similar to how click handlers are attached in the same file.
The handlers then sends a message to the parent frame.
The issue I faced here is that the Event object cannot be directly sent in the message, so I sent the attributes that are needed keyCode, ctrlKey, and metaKey, to the parent frame, which reconstructs a keypress event object with those attributes, and dispatches it.
This PR is lacking test, would love advice on how to go about doing that, thanks!

hi! that's actually a pretty cool way to handle the events, thanks for that! we'll probably need to get a contributor license agreement in place before we can accept the pr (sry about that), but this is definitely going ibto the code base :) :+1:

@felixhammerl yea sure! ping me if you need me to sign any agreement, else feel free to use this code (or any variation) for the purposes of this project :) thanks!

i am unsure what the security implications of this are, since we fire events directly from an untrusted source to the "safe" part of the site.

I've been looking to contribute to this amazing project for a while and, seeing this pull request history, I'd like to know more about such constributor license. How can I have more info about that?

thank you


TheSpokenWord Final Commit

Final commit of TheSpokenWord app project for SwordMinder

I don't need it in sword minder, if you like the idea and want to maintain it I would have no issue with that at all. But unfortunately I dont think I'll have the time in the future to maintain it

Logan,
Thanks for your work on this. I may try to use your work with reciting the verse but incorporate it into the memorize portion of the game.
Dr. Delano


Method/class level cops can't really do thar thing

The existing line number check for methods/classes/blocks is based on the starting line number of the node. If the starting line hasn't been changed, then a cop that might otherwise have an opinion about changes within the method/class/block/what-have-you will be ignored.

#5 in progress...


[Bug]: Unresolvable dependencies from scratch

Your contact details
No response
What happened?
Create react app with this template
npm install fails with much errors
Version
fresh
What browsers are you seeing the problem on?
No response
Relevant log output
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

Hi @bvn13, I've released a new project version which should fix this issue. I've already tested it but please try it and let me know if the same is true for you.
This is the commit that solved all the problems linked with the creation process.

It works now

Amazing! Thanks for taking the time to report this bug.

I'm still having the same issue when running npx create-react-app my-app --template complete-web-app.  Is there a specific way I should be using to pull the latest version with this fix?

Hi @JuanEspin0sa, sorry for the late reply.
I've published a new release (v1.1.16) that includes a fix described in https://github.com/facebook/create-react-app/issues/13080#issuecomment-1515280885. Let me know if it solves all your issues.
I'll soon publish a new template for a complete React app configuration using Vite as suggested by the React community.
Sadly Create React App seems like a dead project, but I won't stop the support for this template yet.

Going to close this one due to inactivity. Feel free to re-open in case the problem recurs.


model_save method crashing python

Issue type
Bug
Have you reproduced the bug with TensorFlow Nightly?
Yes
Source
binary
TensorFlow version
tf 2.12.1
Custom code
Yes
OS platform and distribution
Linux Ubuntu 20.04
Mobile device
No response
Python version
3.8
Bazel version
No response
GCC/compiler version
No response
CUDA/cuDNN version
11.8/8.6
GPU model and memory
NVIDIA Quadro P3200 6GB
Current behavior?
I am currently having problems to save a model. After the training is completed, python crashes when calling save_model or creating a ModelCheckpoint
Standalone code to reproduce the issue
### Training: ###
history = model.fit(train_data, validation_data=val_data,
                    epochs=EPOCHS, callbacks=callbacks)
print("finished fitting model")

# Saving model:
if not os.path.exists(MODEL_FOLDER):
    print("path doesn't exist")
    os.makedirs(MODEL_FOLDER)

tf.keras.models.save_model(model, MODEL_FOLDER, save_format='tf')
print("Model has been saved at" + MODEL_FOLDER)

Relevant log output
Epoch 1/2
[ Warnings...]
210/210 [==============================] - ETA: 0s - loss: 0.4397
Epoch 1: val_loss did not improve from 0.10000
210/210 [==============================] - 53s 131ms/step - loss: 0.4397 - val_loss: 0.2221
Epoch 2/2
210/210 [==============================] - ETA: 0s - loss: 0.1960
Epoch 2: val_loss did not improve from 0.10000
210/210 [==============================] - 27s 125ms/step - loss: 0.1960 - val_loss: 0.1421
finished fitting model
WARNING:absl:Found untraced functions such as _jit_compiled_convolution_op, _jit_compiled_convolution_op, _jit_compiled_convolution_op, _jit_compiled_convolution_op, _jit_compiled_convolution_op while saving (showing 5 of 68). These functions will not be directly callable after loading.
Traceback (most recent call last):
  File "/home/user/repos/drivan/model/train_model.py", line 147, in <module>
    tf.keras.models.save_model(model, MODEL_FOLDER, save_format='tf')
  File "/home/user/repos/drivan/.venv/lib/python3.8/site-packages/keras/saving/saving_api.py", line 145, in save_model
    return legacy_sm_saving_lib.save_model(
  File "/home/user/repos/drivan/.venv/lib/python3.8/site-packages/keras/utils/traceback_utils.py", line 70, in error_handler
    raise e.with_traceback(filtered_tb) from None
  File "/home/user/repos/drivan/.venv/lib/python3.8/site-packages/tensorflow/python/saved_model/nested_structure_coder.py", line 196, in do_encode
    encoded_dict.dict_value.fields[key].CopyFrom(encode_fn(value))
TypeError: bad argument type for built-in operation

Hi @rejahn ,
Please submit minimal repro code snippet. We need details like callback code and MODEL_FOLDER you are using to check with dummy model.

Making a small change in the tensorflow/python/saved_model/nested_structure_coder.py here will solve the problem.
Change:
encoded_dict.dict_value.fields[key].CopyFrom(encode_fn(value))
to
encoded_dict.dict_value.fields[str(key)].CopyFrom(encode_fn(value))
Do you guys have maybe an idea what the problem could be?

What if you change str with repl in the suggested fix?

Actually, that shouldn't matter, it's just a key in a dict.

Changing str with repr works as well - I am able to save our subclassed model.

What if you try hash(key) just before trying to insert into the dict?

using hash(key):
Traceback (most recent call last):   File "/home/user/repos/drivan/model/train_model.py", line 141, in <module>     tf.keras.models.save_model(model, MODEL_FOLDER)   File "/home/user/repos/drivan/.venv/lib/python3.8/site-packages/keras/saving/saving_api.py", line 145, in save_model     return legacy_sm_saving_lib.save_model(   File "/home/user/repos/drivan/.venv/lib/python3.8/site-packages/keras/utils/traceback_utils.py", line 70, in error_handler     raise e.with_traceback(filtered_tb) from None   File "/home/user/repos/drivan/.venv/lib/python3.8/site-packages/tensorflow/python/saved_model/nested_structure_coder.py", line 199, in do_encode     encoded_dict.dict_value.fields[hash(key)].CopyFrom(encode_fn(value)) TypeError: bad argument type for built-in operation

Oh, no, I meant just printing it before. Something like
print(hash(key))
encoded_dict.dict_value.fields[key].CopyFrom(encode_fn(value))

Sorry about the confusion.
I am getting following:
-6062824253216937473
-696857728539794345
-696857728539794345
-696857728539794345
-696857728539794345
-696857728539794345
-696857728539794345
-696857728539794345
-696857728539794345
-5821025861464018857
-6062824253216937473
-696857728539794345
1
2
4
8
16
-696857728539794345
1
2
4
8
16
-696857728539794345
1
2
4
8
16
-696857728539794345
1
2
4
8
16
-696857728539794345
1
2
4
8
16
-696857728539794345
1
2
4
8
16
-696857728539794345
1
2
4
8
16
-696857728539794345
1
2
4
8
16
1
2
4
8
16
-696857728539794345
1
2
4
8
16
-696857728539794345
1
2
4
8
16
-696857728539794345
1
2
4
8
16
-696857728539794345
-696857728539794345
-696857728539794345
-696857728539794345
-696857728539794345
-696857728539794345
-696857728539794345
-696857728539794345
-696857728539794345
-696857728539794345
-696857728539794345
-696857728539794345
-696857728539794345
-696857728539794345
-696857728539794345
-696857728539794345
-696857728539794345
-696857728539794345
-696857728539794345
-696857728539794345
-696857728539794345
-696857728539794345
-696857728539794345
-696857728539794345
-696857728539794345
-696857728539794345
-696857728539794345

So no crash if I understand correctly?
In this case, I think it would be nice if you can provide us with a minimal model architecture (I don't think we need training data, but some randomized input could work) that could reproduce the issue. I'm out of guesses for what could go wrong :(

Hi @rejahn ,
It seems we may not able to help without model architecture. I just tried a dummy model with your provided details and its working fine as per attached gist.
Thanks!

I will try to work on a minimal reproducible example. For now, I will close the issue and open again as soon as I have an example.


Fix/kucoin get fees multiple pairs

Before submitting this PR, please make sure:

[x] Your code builds clean without any errors or warnings
[x] You are using approved title ("feat/", "fix/", "docs/", "refactor/")

A description of the changes proposed in the pull request:
Fix in KucoinAuth when preparing the string to generate the signature. There was a problem processing the request parameters when any of the parameters contained a comma separated list.
The PR also includes a fix to a couple of CoinFlex unit tests that were failing.
Tests performed by the developer:
Added a new unit test with the same scenario from the issue.
Tested with a script that updated the fees on a Kucoin connector instance configured to use more than one trading pair.
Test summary:

Installed the feature branch without any issue
Run a liquidity mining strategy with multiple markets for more than 6 hrs
Reviewed the logs and confirmed that the error with the fee is no longer seen
Check the fees paid after a filled order took place and confirmed they are correct.
Build a docker image and create a docker instances
Repeat the same step done on source build and confirm not seeing the fee error.

Tips for QA testing:
To test the fix it is required to use a strategy that works with more than one trading pair.
Fixes https://github.com/hummingbot/hummingbot/issues/5273
This PR comes from https://github.com/CoinAlpha/hummingbot/pull/253
PRP: https://snapshot.org/#/hbot-prp.eth/proposal/0x4d9ee5f562c4b377bc30b3799cc869191dec4a2abe6db66cf1d954a84e5f13e5

Test performed:
Installed the feature branch without any issue - OK
Run a liquidity mining strategy with multiple markets for around 3 hours - OK
The error with the fee is no longer seen in the logs - OK
Correct fees after a filled order - OK
Build a docker image and create a docker instances - OK
Docker Bot long run - pending test