typegen fails if multiple remote/local references are used in "responses"

This is a bug report.
Thanks for creating great library 👍
I am trying to use typegen on some swagger.yaml files.
Those API definitions leverage remote/local reference (e.g. $ref: "path/to/entity")  a lot, to minimize duplication of codes.
As far as I tested, typegen works finely with such remote/local references, ... except references in responses fields 😭
Those API definitions work finely with other Swagger-based tools (e.g. Swagger editor and Redoc), so I suspect this is an issue in openali-client-axios-typegen.
versions

typegen: 1.0.7

What happend
The below is a reproducible swagger file definitions.
We prepare 2 files.

swagger.yaml
shared-api-components.yaml

swagger.yaml
openapi: "3.0.0"
info:
  version: 0.66.7
  title: My API
servers: []
paths:
  /login:
    post:
      summary: login
      security: []
      requestBody:
        required: true
        content:
          application/json:
            schema:
              type: string
      responses:
        200:
          $ref: "./shared-components.yaml#/responses/LoginSuccess"
        503:
          $ref: "./shared-api-components.yaml#/responses/ServiceUnavailable"

shared-api-components.yaml
schemas:
  ErrorCode:
    type: string
    enum:
      - Unauthorized
      - UnderMaintenance
  ErrorUnauthorizedApi:
    type: object
    properties:
      errors:
        type: array
        items:
          $ref: "#/schemas/ErrorCode"
  ErrorUnderMaintenance:
    type: object
    properties:
      errors:
        type: array
        items:
          $ref: "#/schemas/ErrorCode"
responses:
  ErrorUnauthorizedApi:
    content:
      application/json:
        schema:
          $ref: "#/schemas/ErrorUnauthorizedApi"
  ErrorUnderMaintenance:
    content:
      application/json:
        schema:
          $ref: "#/schemas/ErrorUnderMaintenance"

Then, run typegen swagger.yaml > foo.d.ts and we will got
(node:630) UnhandledPromiseRejectionWarning: Error: The $ref targets root is not found: #/paths/~1login/post/responses/503/content/application~1json/schema/properties/errors/items
    at ReferenceResolver.<anonymous> (/usr/local/lib/node_modules/openapi-client-axios-typegen/node_modules/@anttiviljami/dtsgenerator/dist/core/referenceResolver.js:105:35)
    at step (/usr/local/lib/node_modules/openapi-client-axios-typegen/node_modules/tslib/tslib.js:136:27)
    at Object.next (/usr/local/lib/node_modules/openapi-client-axios-typegen/node_modules/tslib/tslib.js:117:57)
    at /usr/local/lib/node_modules/openapi-client-axios-typegen/node_modules/tslib/tslib.js:110:75
    at new Promise (<anonymous>)
    at Object.__awaiter (/usr/local/lib/node_modules/openapi-client-axios-typegen/node_modules/tslib/tslib.js:106:16)
    at ReferenceResolver.resolve (/usr/local/lib/node_modules/openapi-client-axios-typegen/node_modules/@anttiviljami/dtsgenerator/dist/core/referenceResolver.js:26:24)
    at DtsGenerator.<anonymous> (/usr/local/lib/node_modules/openapi-client-axios-typegen/node_modules/@anttiviljami/dtsgenerator/dist/core/dtsGenerator.js:22:50)
    at step (/usr/local/lib/node_modules/openapi-client-axios-typegen/node_modules/tslib/tslib.js:136:27)
    at Object.next (/usr/local/lib/node_modules/openapi-client-axios-typegen/node_modules/tslib/tslib.js:117:57)

Note
I observed some cases where  typegen runs successfully with references on some cases.
Case 1. Limit the occurence of remote reference in responses to 1.
In swagger.yaml,
      responses:
        # 401:
        #  $ref: "swagger-api-components.yaml#/responses/ErrorUnauthorizedApi"
        503:
          $ref: "swagger-api-components.yaml#/responses/ErrorUnderMaintenance"

But this is not desirable, since I want to use remote reference/local reference to minimize code duplication.
Case 2. Limit the occurence of same local reference in external files to 1.
In shared-api-components.yaml, changed like below
schemas:
  ErrorCode:
    type: string
    enum:
      - Unauthorized
      - UnderMaintenance
  ErrorUnauthorizedApi:
    type: object
    properties:
      errors:
        type: array
        items:
          $ref: "#/schemas/ErrorCode"
  ErrorUnderMaintenance:
    type: object
    properties:
      errors:
        type: array
        items:
          type: string
          # HERE:  Removed local reference that already used above.
          # $ref: "#/schemas/ErrorCode"
responses:
  ErrorUnauthorizedApi:
    content:
      application/json:
        schema:
          $ref: "#/schemas/ErrorUnauthorizedApi"
  ErrorUnderMaintenance:
    content:
      application/json:
        schema:
          $ref: "#/schemas/ErrorUnderMaintenance"

But this is not desirable, since I want to use remote reference/local reference to minimize code duplication.

Hi @exoego. Sorry for such a late response. This seems like a bug in the underlying https://github.com/horiuchi/dtsgenerator library. Unfortunately there's not much we can do on typegen side.

Thanks for investigating.
Grad to see someone is working on dtsgenearator.
https://github.com/horiuchi/dtsgenerator/pull/414
I will suggest to keep this issue open until dtsgenerator support that.


Review compatibility with 2024 IEEE Word template

This task is to review compatibility with the 2024 IEEE Word template.
wordtemp.zip
You will want to check the DOCX files under: DOCX_NO_MACROS/.

Boilerplate updated. The stylesheets turn out to be identical, which is consistent with the report from IEEE that they've been unable to update their macros in Word, implying that they are not updating their stylesheet.


Warning: React.createElement: type should not be null

I have a very simple component that uses LazyLoad a bit like this:
var LazyLoad = require('react-lazy-load')
var View = React.createClass({
    render: function() {
        return (
            <LazyLoad>
                <img src={…}/>
            </LazyLoad>
        )
})

But when displayed by browser, I get this error in the console:
Warning: React.createElement: type should not be null, undefined, boolean, or number. It should be a string (for DOM elements) or a ReactClass (for composite components). Check the render method of `View`.
Invariant Violation: Element type is invalid: expected a string (for built-in components) or a class/function (for composite components) but got: object. Check the render method of `View`.

What am I doing wrong? I am using 2.0.2 on Node 5.4.1.

Hello, @zoul. Try to require it as var LazyLoad = require('react-lazy-load').default;

Perfect, that was it! Thank you for the quick reply.

This is an issue of babel 6.0, I'll rollback on plain old module.exports until they fix it. You can use require('react-lazy-load') without default when next release will be available.

Great!

Maybe I should have waited on jumping to babel 6 :/ heh things like this are why we haven't at work.


repeated words, non-English language

Help me please, what should I turn on so that the words do not repeat? I tried to turn on VAD, language Russian 52 minutes

Pls help, idk what to do, If i do vad too high and the quality is lost, if too low and the words are repeated

No, there's just louder and louder voices.

No, there are louder and quieter voices.

There's also extraneous noises like wind.

By the way, why can't I select a model from my computer? Like #Const-me/Whisper

extraneous noises

This is a whisper hallucination that happens when there's background music or noise in the audio.
I'm closing this because this is the same as #152, please continue there!

By the way, why can't I select a model from my computer?

I don't understand what you mean, but if you want to use custom model (like faster-whisper-large-v2-japanese-5k-steps) then you can put any faster-whisper model into WebUI-Path\models\Whisper\faster-whisper directory and use it.

can i install this? it large-v3 but in WebUI-Path\models\Whisper\faster-whisper i have only large-v1

@jhj0517

Yes, if you manually download the model and place it into the WebUI-Path\models\Whisper\faster-whisper,
It should work fine. Let me know if you encounter any errors

step 1

step 2

@jhj0517

This is related to #253 and I think it's a cuDNN & CUDA & torch version incompatibility problem.
You have some options to resolve this:

If you're using CUDA versions other than 12.4, install 12.4.

Remove the venv directory and run install.bat again.

If you still face the error, follow Perfview's solution

Or alternatively, if you're finding these cumbersome, use Docker for the application.
You can see Running with Docker guide.
( You will need to install and run docker-desktop first.)


App fails to submit after running deliver

Issue Description
We're trying to submit our app for review through fastlane deliver command through shell. However, submit returns success but in reality, app will be still enabled with "Submit for Review". We need to do it manually by selecting export compliance and add id info uses idfa options.
We're running following command for this:
fastlane deliver --skip_binary_upload --submit_for_review -x false -f true  -b "export_compliance_compliance_required: false" -b "add_id_info_uses_idfa:false"-u <user_id>
Complete output when running fastlane, including the stack trace and command used
/Library/Ruby/Gems/2.0.0/gems/fastimage-2.1.0/lib/fastimage.rb:67: warning: already initialized constant URI::DEFAULT_PARSER
/System/Library/Frameworks/Ruby.framework/Versions/2.0/usr/lib/ruby/2.0.0/uri/common.rb:545: warning: previous definition of DEFAULT_PARSER was here
[13:25:57]: Get started using a Gemfile for fastlane https://docs.fastlane.tools/getting-started/ios/setup/#use-a-gemfile
[13:25:59]: Login to iTunes Connect (<user_id>)
[13:26:05]: Login successful
+--------------------------------------+--------------------------------------+
|                           deliver 2.56.0 Summary                            |
+--------------------------------------+--------------------------------------+
| skip_binary_upload                   | true                                 |
| submit_for_review                    | true                                 |
| run_precheck_before_submit           | false                                |
| force                                | true                                 |
| submission_information               | add_id_info_uses_idfa:false          |
| username                             | <user_id>                       |
| app_identifier                       | com.<pkg_name> |
| screenshots_path                     | ./screenshots                        |
| metadata_path                        | ./metadata                           |
| app_version                          | 1.10                                 |
| edit_live                            | false                                |
| ipa                                  | FastlaneTest.ipa                     |
| platform                             | ios                                  |
| skip_screenshots                     | false                                |
| skip_metadata                        | false                                |
| skip_app_version_update              | false                                |
| automatic_release                    | false                                |
| overwrite_screenshots                | false                                |
| precheck_default_rule_level          | warn                                 |
| ignore_language_directory_validation | false                                |
+--------------------------------------+--------------------------------------+
[13:26:06]: Making sure the latest version on iTunes Connect matches '1.10' from the ipa file...
[13:26:08]: '1.10' is the latest version on iTunes Connect
[13:26:14]: Uploading metadata to iTunes Connect
When you create a new app name or update an existing one, it must now be 30 characters or fewer. Also, you can only update an app’s description when submitting a new version of that app. Learn more
[13:26:16]: Successfully uploaded set of metadata to iTunes Connect
[13:26:17]: Starting with the upload of screenshots...
[13:26:17]: Successfully uploaded screenshots to iTunes Connect
[13:26:20]: Selecting the latest build...
[13:26:22]: Selecting build 1.10 (1.18)...
[13:26:24]: Successfully selected build
[13:26:24]: Submitting the app for review...
Looking for related GitHub issues on fastlane/fastlane...
Found no similar issues. To create a new issue, please visit:
https://github.com/fastlane/fastlane/issues/new
Run fastlane env to append the fastlane environment to your issue
#######################################################################
fastlane 2.58.0 is available.
You should use the latest version.
Please update using sudo gem install fastlane.
#######################################################################
2.58.0 Bugfixes and improvements

Add "fastlane update_fastlane" command to tab autocompletion (#10375) via Omer Faruk Yilmaz
Print out the languages that are being updated for set_changelog action (#10369) via Felix Krause
Add in-app purchase scanning support in precheck (#10372) via Joshua Liebowitz
Revert commits that caused bugs with the package name for transporter (#10376) via Felix Krause

2.57.2 snapshot improvements

Add missing "Apple TV" device in snapshot report generator devices (see #10365) (#10366) via Julien Quéré
Allow snapshot to handle multiple tvOS devices (closes #10347) (#10350) via Julien Quéré

2.57.1 Fix regression in match

Revert "Fix creation of certificate when a keychain is specified. (#10321)" via Felix Krause (this fixes the regression of the last release
Use underscore instead of parentheses when copying IPA file (#10357) via Dennis Torbichuk
Fix error in GitHub issue list (#10352) via Rishabh Tayal

To see all new releases, open https://github.com/fastlane/fastlane/releases
Please update using sudo gem install fastlane
/Library/Ruby/Gems/2.0.0/gems/fastlane-2.56.0/deliver/lib/deliver/submit_for_review.rb:18:in submit!': [!] undefined method each' for "add_id_info_uses_idfa:false":String (NoMethodError)
from /Library/Ruby/Gems/2.0.0/gems/fastlane-2.56.0/deliver/lib/deliver/runner.rb:153:in submit_for_review'         from /Library/Ruby/Gems/2.0.0/gems/fastlane-2.56.0/deliver/lib/deliver/runner.rb:37:in run'
from /Library/Ruby/Gems/2.0.0/gems/fastlane-2.56.0/deliver/lib/deliver/commands_generator.rb:73:in block (2 levels) in run'         from /Library/Ruby/Gems/2.0.0/gems/commander-fastlane-4.4.5/lib/commander/command.rb:178:in call'
from /Library/Ruby/Gems/2.0.0/gems/commander-fastlane-4.4.5/lib/commander/command.rb:178:in call'         from /Library/Ruby/Gems/2.0.0/gems/commander-fastlane-4.4.5/lib/commander/command.rb:153:in run'
from /Library/Ruby/Gems/2.0.0/gems/commander-fastlane-4.4.5/lib/commander/runner.rb:476:in run_active_command'         from /Library/Ruby/Gems/2.0.0/gems/fastlane-2.56.0/fastlane_core/lib/fastlane_core/ui/fastlane_runner.rb:64:in run!'
from /Library/Ruby/Gems/2.0.0/gems/commander-fastlane-4.4.5/lib/commander/delegates.rb:15:in run!'         from /Library/Ruby/Gems/2.0.0/gems/fastlane-2.56.0/deliver/lib/deliver/commands_generator.rb:176:in run'
from /Library/Ruby/Gems/2.0.0/gems/fastlane-2.56.0/deliver/lib/deliver/commands_generator.rb:12:in start'         from /Library/Ruby/Gems/2.0.0/gems/fastlane-2.56.0/fastlane/lib/fastlane/cli_tools_distributor.rb:58:in take_off'
from /Library/Ruby/Gems/2.0.0/gems/fastlane-2.56.0/bin/fastlane:20:in <top (required)>'         from /usr/local/bin/fastlane:23:in load'
from /usr/local/bin/fastlane:23:in `'
Environment
/Library/Ruby/Gems/2.0.0/gems/fastimage-2.1.0/lib/fastimage.rb:67: warning: already initialized constant URI::DEFAULT_PARSER
/System/Library/Frameworks/Ruby.framework/Versions/2.0/usr/lib/ruby/2.0.0/uri/common.rb:545: warning: previous definition of DEFAULT_PARSER was here
[13:28:40]: Get started using a Gemfile for fastlane https://docs.fastlane.tools/getting-started/ios/setup/#use-a-gemfile
[13:28:43]: Generating fastlane environment output, this might take a few seconds...
🚫 fastlane environment 🚫
Stack

Key
Value

OS
10.12.4

Ruby
2.0.0

Bundler?
false

Git
git version 2.11.0 (Apple Git-81)

Installation Source
/usr/local/bin/fastlane

Host
Mac OS X 10.12.4 (16E195)

Ruby Lib Dir
/System/Library/Frameworks/Ruby.framework/Versions/2.0/usr/lib

OpenSSL Version
OpenSSL 0.9.8zc 19 Mar 2015

Is contained
false

Is homebrew
false

Is installed via Fabric.app
false

Xcode Path
/Applications/Xcode.app/Contents/Developer/

Xcode Version
8.3.3

System Locale

Error

No Locale with UTF8 found 🚫

fastlane files:
No Fastfile found
No Appfile found
fastlane gems

Gem
Version
Update-Status

fastlane
2.56.0
🚫 Update available

Loaded fastlane plugins:
No plugins Loaded
Loaded gems

Gem
Version

slack-notifier
1.5.1

CFPropertyList
2.3.5

claide
1.0.2

colored2
3.1.2

nanaimo
0.2.3

xcodeproj
1.5.0

rouge
2.0.7

xcpretty
0.2.8

terminal-notifier
1.8.0

unicode-display_width
1.3.0

terminal-table
1.8.0

plist
3.3.0

public_suffix
2.0.5

addressable
2.5.1

multipart-post
2.0.0

word_wrap
1.0.0

tty-screen
0.5.0

babosa
1.0.2

colored
1.2

highline
1.7.8

commander-fastlane
4.4.5

excon
0.57.1

faraday
0.12.1

unf_ext
<IP_ADDRESS>

unf
0.1.4

domain_name
0.5.20170404

http-cookie
1.0.3

faraday-cookie_jar
0.0.6

fastimage
2.1.0

gh_inspector
1.0.3

mini_magick
4.5.1

multi_json
1.12.1

multi_xml
0.6.0

rubyzip
1.2.1

security
0.1.3

xcpretty-travis-formatter
0.0.4

dotenv
2.2.1

bundler
1.15.1

faraday_middleware
<IP_ADDRESS>

uber
0.0.15

declarative
0.0.9

declarative-option
0.1.0

representable
3.0.4

retriable
2.1.0

mime-types-data
3.2016.0521

mime-types
3.1

little-plugger
1.1.4

logging
2.2.2

jwt
1.5.6

memoist
0.16.0

os
0.9.6

signet
0.7.3

googleauth
0.5.1

httpclient
2.8.3

google-api-client
0.13.4

json
2.1.0

generated on: 2017-09-21

Looking for related GitHub issues on fastlane/fastlane...
➡  Pilot reported "invalid byte sequence in US-ASCII" after token expiration
https://github.com/fastlane/fastlane/issues/9689 [closed] 6 💬
03 Aug 2017
➡  invalid byte sequence in UTF-8 when using update_info_plist
https://github.com/fastlane/fastlane/issues/6998 [closed] 11 💬
2 days ago
➡  Invalid byte sequence with invalid strings file
https://github.com/fastlane/fastlane/issues/7661 [closed] 8 💬
01 Jun 2017
and 24 more at: https://github.com/fastlane/fastlane/search?q=invalid byte sequence in US-ASCII&type=Issues&utf8=✓
🔗  You can ⌘ + double-click on links to open them directly in your browser.
#######################################################################
fastlane 2.58.0 is available.
You should use the latest version.
Please update using sudo gem install fastlane.
#######################################################################
Run sudo gem cleanup from time to time to speed up fastlane
#######################################################################
2.58.0 Bugfixes and improvements

Add "fastlane update_fastlane" command to tab autocompletion (#10375) via Omer Faruk Yilmaz
Print out the languages that are being updated for set_changelog action (#10369) via Felix Krause
Add in-app purchase scanning support in precheck (#10372) via Joshua Liebowitz
Revert commits that caused bugs with the package name for transporter (#10376) via Felix Krause

2.57.2 snapshot improvements

Add missing "Apple TV" device in snapshot report generator devices (see #10365) (#10366) via Julien Quéré
Allow snapshot to handle multiple tvOS devices (closes #10347) (#10350) via Julien Quéré

2.57.1 Fix regression in match

Revert "Fix creation of certificate when a keychain is specified. (#10321)" via Felix Krause (this fixes the regression of the last release
Use underscore instead of parentheses when copying IPA file (#10357) via Dennis Torbichuk
Fix error in GitHub issue list (#10352) via Rishabh Tayal

To see all new releases, open https://github.com/fastlane/fastlane/releases
Please update using sudo gem install fastlane

Any help would be highly appreciated!

Sorry, I don't understand the problem, could you describe it a bit more?

Here is the problem:
~ head -1 /usr/local/bin/fastlane
#!/System/Library/Frameworks/Ruby.framework/2.0/Current/usr/bin/ruby

There is no that directory in the FS:
~ ls -la /System/Library/Frameworks/Ruby.framework
total 0
drwxr-xr-x    5 root  wheel   160 Sep 26 12:15 .
drwxr-xr-x  143 root  wheel  4576 Sep 26 12:15 ..
lrwxr-xr-x    1 root  wheel    26 Sep 26 12:14 Resources -> Versions/Current/Resources
lrwxr-xr-x    1 root  wheel    21 Sep 26 12:14 Ruby -> Versions/Current/Ruby
drwxr-xr-x    4 root  wheel   128 Sep 26 12:15 Versions
~


Pointwise fusion for GPU

Description
This PR enables fusion of pointwise ops for GPU context, using runtime compilation (NVRTC). I will make and post a design doc in the near future.
Work done by me, @Caenorst and @nvchai.
Important note: this is NOT meant to compete with other long term compilation strategies for MXNet (like integration with TVM etc.). It is intended as a short term solution (and so e.g. does not tackle harder problems like fusion with convolutions/gemms) while those long term solutions are in development.
This is the first stage of this effort, focusing on pointwise ops that do not change the shape of the output (+ slices). Future PRs will tackle broadcast ops.
FYI @zheng-da @junrushao1994 @eric-haibin-lin @szha @KellenSunderland @nvchai
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.

[x] Changes are complete (i.e. I finished coding on this PR)
[x] All changes have test coverage:
Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
[x] Code is well-documented:
For user-facing API changes, API doc string has been updated.
For new C++ functions in header files, their functionalities and arguments are documented.
For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
[x] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

[ ] Feature1, tests, (and when applicable, API doc)
[ ] Feature2, tests, (and when applicable, API doc)

Comments

The fusion is controlled by MXNET_USE_FUSION env variable and currently on by default for GPU context (mostly to see how it will behave in the CI environment) - I will probably change it to opt-in later in the review process.
It supports both forward and backward pass
It supports rebinding with different shapes without the need of recompilation of the generated kernel.
It currently supports Symbol, Module and Gluon (only hybridized without inlining, so mostly static_alloc=True) API.

@ptrendx Can you look at the CI failures on this PR ?
@mxnet-label-bot Add [pr-awaiting-review, Operator]

Design doc: https://cwiki.apache.org/confluence/display/MXNET/GPU+Pointwise+fusion

Did we document MXNET_USE_FUSION in docs/faq/env_var.md and add that is supported only for CUDA?

Did we document MXNET_USE_FUSION in docs/faq/env_var.md and add that is supported only for CUDA?

I added this in the latest commit.

Thanks for addressing the comments.

@szha @KellenSunderland @eric-haibin-lin Do you have any comments to this PR?

@ptrendx gentle ping!

@cjolivier01 That is simply not true (and "I could post examples but I will not" as well as the single line that you gave as an example, which is actually trivial use case for auto, does not prove your point). In fact the line you pointed at:
const auto& inode = idx[nid];

without auto would look like this
const nnvm::IndexedGraph::Node& inode = idx[nid];

which makes the code less readable (the fact that inode is a node is given by its name, so the typing the type name gives you the same redundant information and actually makes it harder to spot the name of the variable which is more important).
Here are actual examples of guidelines:

C++ Core Guidelines
video of a discussion in C++ 2012 and beyond discussing auto usage

The conclusion form those guidelines is that you should be using auto nearly everywhere because it makes the code more future proof (e.g. when implementation of the function change and the type returned is different but still has the same properties, you do not need to change the code that actually uses the function) AND more readable (because it is shorter and you only need to think about the properties of the type that you get from the function call instead of the type itself).

I looked at those “core guildelines” and it’s basically what I was saying — stuff like ::iterator and repetition or obvious type on same line. where you get the “always use auto” I don’t know. from the video? videos are TLDR-ish, but I certainly wouldn’t trust anyone who makes a video saying to use auto everywhere. that’s just crazy :)

If you did not want to put the effort to watch the video (portion about auto takes ~4 minutes there) then using "change request" does not seem valid. And if you think that arguments of C++ standard committee members are "just crazy" then maybe you should reconsider your usage of C++?
Also, did you even read what I posted? C++ Core Guidelines (again, maintained by ISO C++ Foundation) text has 1 exception for using auto:
Exception
Avoid auto for initializer lists and in cases where you know exactly which type you want and where an initializer might require conversion.

There are no other exceptions, so I don't know where you get your stuff like ::iterator and repetition or obvious type on same line from.

We apparently have very different interpretation of those guidelines. I don’t see anything in that which implies “use it everywhere for everything”. I’m more of the opinion stated here:
While I am not i. the habit of posting stack overflow nonsense as “evidence”, seems to be a consistent understanding about proper auto use:
https://www.acodersjourney.com/c-11-auto/
https://stackoverflow.com/questions/6900459/the-new-keyword-auto-when-should-it-be-used-to-declare-a-variable-type
Using auto everywhere makes C++ code no more readable than something like python.

Considering Python is quite widely believed to be "easier" language than C++, the Using auto everywhere makes C++ code no more readable than something like python. comment is slightly counter intuitive.
Even the blog post you link to actually is saying the same thing - you should be using auto most of the time. And for the example that he starts with (that is supposedly bad use of auto):
auto a = ConjureMagic();
SetMagic(a);

is just wrong, since the alternative (non auto) form of let's say
std::vector<SuperMagicType> a = ConjureMagic();
SetMagic(a);

does not give me any more info on what the code does, but if later the ConjureMagic function changes to give back, let's say std::array<SuperMagicType> or something, then the second code will either not compile anymore or, even worse, a costly conversion will occur. The actual solution to his problem would be to refactor the ConjureMagic function name to actually state what is the result (and not in a ConjureMagicInteger way, but in business logic way, like GetComputationEngine or something).
In the StackOverflow thread you posted there was an (not the most upvoted, I will give you that) answer citing this blog post by the principal developer of C# compiler about var (which is equivalent to auto in C++), which ends with this conclusion:
Summing up, my advice is:

Use var when you have to; when you are using anonymous types.
Use var when the type of the declaration is obvious from the initializer, especially if it is an object creation. This eliminates redundancy.
Consider using var if the code emphasizes the semantic "business purpose" of the variable and downplays the "mechanical" details of its storage.
Use explicit types if doing so is necessary for the code to be correctly understood and maintained.
Use descriptive variable names regardless of whether you use "var". Variable names should represent the semantics of the variable, not details of its storage; "decimalRate" is bad; "interestRate" is good.

I agree with this, so if you believe that there is necessity to use explicit typing somewhere in this PR in order for it to be correctly understood and maintained, please point me to the specific places in the code where this situation occurs and I will reevaluate those cases - otherwise your feedback is not really actionable.

Guys, let's keep the conversation constructive and focused on architecture and approaches rather than nits. In some cases some judicious use of "using" to import namespace can help. for example:
const nnvm::IndexedGraph::Node& inode = idx[nid];

This can be rewritten to
const Node& inode = idx[nid];

In this case is better to use the type and reduce long namespace resolution if you are constantly using classes in some namespace.
This would be my preference and advice.
Maybe we need to write a guideline approved by the community? Having these discussions in individual PRs slows things down too much.
❤

@larroy I don't think it's recommended as there is nnvm::Node and nnvm::IndexedGraph::Node.
I don't how this is a problem as this line is already in master: https://github.com/apache/incubator-mxnet/blob/01fae12e58d73d5989a23cfc8b7519f4772fdf1f/src/executor/graph_executor.cc#L109 https://github.com/apache/incubator-mxnet/blob/01fae12e58d73d5989a23cfc8b7519f4772fdf1f/src/executor/graph_executor.cc#L1214 for instance

@larroy I don't think it's recommended as there is nnvm::Node and nnvm::IndexedGraph::Node.
I don't understand how this is a problem as this line is already in master: https://github.com/apache/incubator-mxnet/blob/01fae12e58d73d5989a23cfc8b7519f4772fdf1f/src/executor/graph_executor.cc#L109 https://github.com/apache/incubator-mxnet/blob/01fae12e58d73d5989a23cfc8b7519f4772fdf1f/src/executor/graph_executor.cc#L1214 for instance

mxnet doesn’t yet have a c# interface — are you volunteering?  The functionality would be welcomed :)

i randomly picked that line as representative of auto used for pretty much everything
pointing out this or that line is “already in master” at some random place is interesting. If you got cancer, would you have the attitude like “I already have some cancer in me, so clearly more cancer is acceptable”, or would you try to get rid of the cancer if possible, or at the very least slow its growth? If it was a couple of autos here and there, it could pass, but this PR kind of takes that to another level and sets a bad precedent for future code (in case someone wants to point out, well they use “auto” everywhere in this code)...

@Caenorst yes in this case you are right. I was trying to convey a general example.

@ptrendx @cjolivier01 To help move this effort forward, shall we do the following?

let's start a discussion on dev@ on the specific topic of auto usage, present the arguments, and try to reach consensus there.
if @cjolivier01 is willing, we can unblock this PR for now and if necessary address the concern once the discussion concludes.
alternatively, if @ptrendx is willing, we could avoid the auto usage in this PR to get it unblocked immediately, or wait until the discussion to conclude.

@eric-haibin-lin Support for fusion without hybridization would be really tricky (you do not know what is the next operation in your graph) and would effectively end up being very similar to hybridization (in order to know what to do you would need to trace the graph and run it only during some sync points). Also if you really need imperative execution (because you have some condition to run different portions of the graph for example) then the overhead of compilation may not be worth it.
Optimizers are interesting use case for fusion - is there any reason to not use Gluon HybridBlocks to implement them?

@szha As I stated in one of the previous comments - I am open to reevaluating specific cases of auto usage in this PR (and they were not given yet). That said, I believe that the main problem with understanding the code that uses auto is not the auto keyword itself, but the functions that produce values captured by it (that e.g. have a name that does not really say properly what the function is supposed to do).
The discussion on dev@ would be nice.

Google c++ style guide says basically the same thing as what I’m encouraging:
https://google.github.io/styleguide/cppguide.html#auto
I’d like to review this PR, but it’s unreadable in its current state, imho. I do not intend to have extended arguments on a case-by-case basis, as I don’t think that sort of turnabout would ultimately be constructive.

Okay, so lets have a discussion on dev@ and then agree on a style.

I am removing my block on this PR and letting in this "auto-abuse" in since I am in a similar industry to NVidia and don't wish to make it look like I am blocking a performance improvement for NVidia GPU's.  I hope that the auto-abuse will be fixed before merging, however.

@cjolivier01 you are no longer active in this project and are just blocking PRs and preventing contributions, do the right thing for the community and resign from the PMC.

@ptrendx Does this support AMP? Do you observe any speedup when training mask rcnn?

@Jerryzcn Yes, it does support AMP. I saw a (pretty small, 1-2%) speedup in the non-FPN version of MaskRCNN from GluonCV.

Hi @DickJC123 looks like this PR increases the CI centos-gpu testing time by over 100%, which is caused by some gpu tests running time increasing by over 20 times. For example:
test_operator_gpu.test_sparse_mathematical_core goes from ~13s to ~350s, test_operator_gpu.test_lstm_bidirectional goes from ~15s to ~450s,
test_operator_gpu.test_rnnrelu_bidirectional goes from ~4s t0 ~250s.
It means this PR may cause some regression, so can you take a look? I did the comparison between this PR and previous PRs.

@ptrendx @Caenorst @nvchai

Would it be more appropriate to turn off fused_op by default? We can still provide documentation for the user to turn on it manually.

Thanks for pointing out this large perf change.  I will investigate.

I would say it is expected - the whole point of the feature is compile the portion of the model (which is much more expensive than just running that part) in other for subsequent iterations to run faster. Since CI runs unit tests, it creates a large number of models and never reuses them, so the compilation overhead can't be amortized. In order to reduce the overall ci time I would say the best way would be to enable fusion only on 1 or 2 configs in CI instead of all of them.
@sxjscience That approach traditionally did not work well - if you have a nonobvious feature that is not enabled by default users have no chance of actually getting benefit from it because that don't know they should be enabling it. Also, the CI example aside, there should never be a usecase where you do not want to enable fusion as it makes the training faster.

@ptrendx Okay, I just think that we may need more time to test for the cases in GluonNLP and GluonCV.

After some investigation, I have an explanation and planned fix for the perf regression. To repeat what @ptrendx mentions, the real-time compilation of fused kernels takes additional time up front, with the idea that over many kernel invocations, the compile time will be more than made up for by the increase efficiency of the fused op.  This matches the typical use case (unlike CI), so I believe that fusion should be left enabled by default.
Now one saving thing for each of the 3 tests mentioned by @rondogency is that most of the fused-ops in the test are duplicates of others seen earlier in the test.  In fact <2% of the created fused-ops are unique.  To fix this then I will submit a PR to introduce a 'fused op cache' that will map (source-code, gpu_arch) -> runnable kernel.  This should eliminate most of the runtime compilations and correct in large part the issue flagged here.


Access to windows host service from WSL2

Windows Version
Version 10.0.23531.1001
WSL Version
<IP_ADDRESS>
Are you using WSL 1 or WSL 2?

[X] WSL 2
[ ] WSL 1

Kernel Version
<IP_ADDRESS>
Distro Version
Ubuntu 22.04
Other Software
No response
Repro Steps
Ive got http service on windows host and iam not able to access to it from WSL2. From WSL2 iam not able to ping windows host ip, but all other ip address in network are accessable (computers, routers, NAS...). From windows host iam able to ping WSL2.
WSL ip is <IP_ADDRESS>, windows 192.168.8... and windows WSL adapter is <IP_ADDRESS>.
Expected Behavior
I just need to open service from windows host (<IP_ADDRESS>, <IP_ADDRESS> ....) in WSL.
Actual Behavior
wsl is not comunicating with windows host computer over ip.
Diagnostic Logs
No response

Have you tried using the host address on that subnet you see on eth0? In your case <IP_ADDRESS>


[Language Server] Add "create undefined function" code action support to language server

Purpose
Add "create undefined function" code action support for basic scenarios.
Fixes #27424
Approach
Works for

Simple function calls:

   addTwoIntegers(a, c, true);

Function calls in var declarations:

   int d = addTwoIntegers2(a, b);

Function calls with parameters of different modules:

    module1:Student student = createStudent(name, age);
    addStudent(student);
    module1:Student converted = convertStudent(student);

Doesn't work for assignment statements, let expressions, assignments within record types, etc yet.
Samples

addTwoIntegers(a, c, true); will result:

function addTwoIntegers(int a, float b, boolean c) {

}

module1:Student student = createStudent(name, age); will result in a function like:

function createStudent(string a, any b) returns module1:Student {

    return {};
}

int d = addTwoIntegers2(a, b); will result in:

function addTwoIntegers2(int a, int b) returns int {

    return 0;
}

and etc.
Remarks

List any other known issues, related PRs, TODO items, or any other notes related to the PR.

Check List

[x] Read the Contributing Guide
[ ] Updated Change Log
[ ] Checked Tooling Support (#)
[x] Added necessary tests

[x] Unit Tests
[ ] Spec Conformance Tests
[ ] Integration Tests
[ ] Ballerina By Example Tests

[x] Increased Test Coverage
[ ] Added necessary documentation

[ ] API documentation
[ ] Module documentation in Module.md files
[ ] Ballerina By Examples

@nadeeshaan It doesn't honor module aliases as of now. Working on it.

@nadeeshaan I have added support for module aliases. And this works with pre-declared lang libs. I have added tests for both scenarios.
Overall, this implementation works for simple name references, assignment statements and variable declarations. Complex scenarios like let expressions, function calls when creating records, methods inside classes/services are not supported yet.
Furthermore, in the following scenario, the typeSymbol.signature() returns { string recField; anydata...; } while the expected value is {| string recField; anydata...; |}. Need to address that in a separate issue.
record {
      string recField = "";
    } testRec = {};
    record {
      int recField = 1;
    } testRec2 = thisIsANewFunction(testRec);


When will the training code open sourced?

Thanks for your great job. When will the training code open sourced?

We definitely have the plan to opensource everything (including previous LLaVA-NeXT's training code, data) to benefit community.
However, there're still lot of works to do and more releases to be expected~

Can you please tell me if there is any obvious difference between the training code and the one in https://github.com/haotian-liu/LLaVA? I'm trying to finetune it on my data set.

There's no major difference, if you wish to finetune our 8b/72b/110b. Only diff is that you need to apply new conversation templates.

Indeed, I found that the special tokens of llama3-8B are different from those of vicuna-7B. Could you please tell me what the conversation template is like you use to finetune llama3-8B?

you can find in llava/conversations.py, we use llama-3.
But it's for inference, in training, you need to implement the masking logic for llama-3 your side.

OK thanks, I'll try it.

To adapt LLaMA3-8B to the training code in https://github.com/haotian-liu/LLaVA, I manually add pad_token and unk_token like
if tokenizer.pad_token is None:
        print("\n add unk_token \n\n")
        smart_tokenizer_and_embedding_resize(
            special_tokens_dict=dict(
                unk_token="<unk>"
            ),
            tokenizer=tokenizer,
            model=model,
        )
tokenizer.pad_token = tokenizer.unk_token

I wonder whether it will cause bad pre-train performance or not? If this is not correct, how can I set padding_value in this line input_ids = torch.nn.utils.rnn.pad_sequence()?

Hi @jimchenhub have you figured it out?


[Search] Refactor Samples, Include Tests, and Prepare for 11.6.0-beta.1 Release

This PR involves cleaning up the existing samples, adding test cases, and updating the changelog to prepare for the 11.6.0-beta.1 preview release.
Fixes: Issue #40931

API change check
API changes are not detected in this pull request.


Queue only runs 0 or 1 task per refresh interval per worker

Describe the bug
The queues package is only able to run up to 1 task per refresh interval, per worker. For example, a system configured with 1 worker and a 10 second refresh interval, running tasks that take 1 second, cannot be utilised beyond 10%, and cannot run more than 1 task every 10 seconds.
To Reproduce
In a project with queues and a task configured...

Set the number of workers to 1
Set the refresh interval to 10 seconds
Enqueue 10 tasks.

Expected behaviour
All 10 tasks complete one after the other with effectively zero gap between them.
Actual behaviour
The first task completes, and the queue waits until 10 seconds have elapsed before running the next.
Environment
queues 1.12.1
vapor-queues-fluent-driver 3.0.0-beta1
Additional context
I'm not sure whether this is worth filing on the fluent driver repo as well. I think there are two possible scenarios here:

queues intends that the pop method in the driver API blocks until a job is available, likely intended for use with BRPOPLPUSH/etc on Redis. Therefore making this a "bug" in vapor-queues-fluent-driver or the queues documentation.
(and/or) This is unintentional behaviour in queues, and it should instead re-pop if any job is run until there is nothing.

While the intention of refreshInterval isn't documented (that I can tell), I think it's most reasonable and would be most expected by those who have used other queueing systems, that it be a period to wait when there is no available work so the tuning of this value only impacts the polling of storage and does not impact the utilisation of queue workers.

@0xTim hey, what do you think of this? Is this a bug in the queues package, or a bug in the fluent driver due to a mismatch in expectations. Or, am I just using it wrong!

First pass fix in #134.

@danpalmer sorry for the delay in this! Got buried in GH notifications. I've had a quick look at the PR and it makes sense, but well need to update it to avoid breaking the API


each element in the array

similar to #83
should remove the "missing each" warning here:

https://libraries.openmodelica.org/branches/master/BuildingSystems/files/BuildingSystems_BuildingSystems.Buildings.Constructions.Examples.SlidingWindow.err
https://libraries.openmodelica.org/branches/master/BuildingSystems/files/BuildingSystems_BuildingSystems.Buildings.Examples.BuildingThermalMultiZone.err
https://libraries.openmodelica.org/branches/master/BuildingSystems/files/BuildingSystems_BuildingSystems.Buildings.Constructions.Examples.Door.err
https://libraries.openmodelica.org/branches/master/BuildingSystems/files/BuildingSystems_BuildingSystems.Applications.HeatingSystems.SolarHeatingSystem.err

Note: To find all missing each warnings, run the following commands on Linux
mkdir temp
cd temp
wget -r -np -nd --accept=err https://libraries.openmodelica.org/branches/master/BuildingSystems/files/
grep "missing" *.err

You are right !


Sync eng/common directory with azure-sdk-tools for PR 8119

Sync eng/common directory with azure-sdk-tools for PR https://github.com/Azure/azure-sdk-tools/pull/8119  See eng/common workflow

@RickWinter we suspect it's related to new sanitization changes made in go by @chlowell. CC @scbedd

It's because the updated proxy applies its default sanitizers during playback, not just in recording as we've done until now (and as I did in #22745). Applying sanitizers to playback breaks tests in ~80 modules; I'm working to fix the easy ones and skip the rest.

It's because the updated proxy applies its default sanitizers during playback, not just in recording as we've done until now (and as I did in #22745). Applying sanitizers to playback breaks tests in ~80 modules; I'm working to fix the easy ones and skip the rest.

With the internal update, you can work at your own pace with an update to eng/target_proxy_version.txt. Closing this PR. Once everyone has gotten the proxy with common sanitizers working, I'll bump universally and delete the override file.


A random business name

When user register, a random business name is associated to the user.
Since business name is mandatory for any user, it should be filled on registration.
If possible can be added to a user model.

The business name should be blank = true and null = true, He/she should fill when login to their dashboard.

If that is the case, its logic should be removed from sign up view.

The logic is, After user signup => login => fill business form, => Dashboard


amend load print

Add a final print to log at the end of init.lua to indicate the mod was loaded successfully. This idea was derived from other mods which are specifically aimed at MT servers.
This could be useful not only for player support (e.g. in the MT forum) but would certainly be useful for MT server admins using the CLI and reading their server logs.

I think this kind of verbose loading message ought to be something added to core Minetest, e.g. with a --verbose command line argument.

in general, always use minetest.log, not print.
the success and amount of time it takes to load a mod is already part of the info log-level stream. set debug_log_level = info in minetest.conf, or pass the --info arugment to minetest when you launch it.
--verbose  already exists as well

From the start my PR was aiming at compatibility with legacy clients and servers. If you scan the MT forum you will become aware that there seem to be quite many MT 0.4 servers around which are actively used by many players.
However, the best solution may be this example of a new piece of improved code, if I understand the MT Lua code correctly.

-- print to log after mod was loaded successfully
local load_message = "[MOD] XXX loaded"
if minetest.log then
	minetest.log("info", load_message) -- aims at state of the art MT software
else
	print (load_message)  -- aims at legacy MT software used in the field
end

Hope this helps. I may provide a new PR in due time.

I am quite aware that devs have the state of the art in their mind. However, as community effort MT projects including this mod should always have the majority of MT players in the field in their mind as long this would be reasonable, I presume.
IMHO it should be worth some considerateion and would be quite unfortunate too much MT server admins would become unhappy or loosing MT players.

My apologies and obviously I made false assumptions.
closed


[BUG] NO graph being plotted.

Expected Behavior
Hello ,
Till yesterday candlestick chart used to be plotted and displayed. But now just a blank screen is being shown.
Current Behaviour
Blank screen , no chart is loading.

Reproducible Example
import yfinance as yf
import pandas as pd
from lightweight_charts import Chart

# 1. Fetch TCS Stock Data
ticker = "TCS.NS"
data = yf.download(ticker, period="1y")

# 2. Convert Time Index to Datetime and Format for Charting
df_reset = data.reset_index()

df_reset = df_reset.rename(columns={'index': 'time', 'Open':'open', 'High':'high', 'Close':'close' ,'Low':'low', 'Volume':'volume'})
# 3. Create and Customize the Chart
chart = Chart(toolbox=True, maximize=True, on_top=True)

chart.legend(visible=True, font_size=14)

chart.set(df_reset)

chart.show(block=True)

Environment
- OS:
- Library:

I am also facing same issue with even simple code
[import pandas as pd
from lightweight_charts import Chart
if name == 'main':
chart = Chart()

# Columns: time | open | high | low | close | volume
df = pd.read_csv('ohlcv.csv')
chart.set(df)

chart.show(block=True)](url)

Could it because TradingView release new version
https://github.com/tradingview/lightweight-charts

@louisnw01  Can you please check why this is  not working

@louisnw01 May i request to please check this ?

I'm not sure where the problem is, everything looks fine.

I have same problem

it would work after some time

dupe


Add github action auto build multi-arch images

It seems #2 had discussed the nextcloud-exporter for different arch machines, like raspberry pi.
However, we still lack a place for community easily pull down and integrate into kubernetes or helm.

Note
Before merging, please add secrets DOCKER_USERNAME and DOCKER_TOKEN to the project secrets, enabling login into docker hub.

Thanks for the contribution! Currently this project is using Docker's own build environment for building the images, but I have thought about giving Github actions a try.
That said, I don't know if all the steps, for example qemu, are really needed for cross-architecture builds as Go already has good cross-compilation abilities. What's left is building a Docker image from the binary.
I'll soon have a look at this, but I can not promise it will be in the next week, as I'm busy with something else.

Hi, thanks for your quick reply.
I think using qemu and docker buildx is a gereral but a kind of slow method building multi-arch images (taking about 6~10min).
It will be better and quicker utilizing Go cross compiling feature.
That's nice if we have a mult-arch images like v0.3.0, cause the repo is integrated in https://github.com/nextcloud/helm, However, In my own experience before, it is a little annoying dealing with the docker manifest if I want to build separately and push together using same semver tag. So... maybe tag as v0.3.0-arm is great for now. Just do everything at your own pace :)

I've now played around with buildx myself a bit, current state is in the cross-build branch. I've pushed a version supposedly containing support for amd64, arm64 and armv8 to the registry as xperimental/nextcloud-exporter:0.4.0-4-g2af5ccb. I have built this on amd64 and there the multi-arch image works fine, but I have not yet tested it on different platforms, would it be possible for you to test if it works?
I'll also still need to figure out how to either integrate it into the current build on Docker Hub or move to GH actions using your PR as a starting point.

I just tested on my Raspberry Pi and it works ;)

Sorry for my late reply. I just test and it works great on Raspberry Pi 4 (armv8 image) using thanos, prometheus-operator and grafana.

Sorry, it took a while for the "coming weekend" to arrive...
I have played around with Github actions on another repository a few weeks ago and now adapter nextcloud-exporter to use the same script.
The latest tag should now have both amd64 and arm64 architectures and the next tagged release will as well.
Thank you very much for your input!

Seems I forgot to close this earlier. Again: thanks for the input!


question: how to load custom json files

First of all, thanks for this great tool! I am trying to use it to render molecules in the terminal.
The attached JSON file should render the formic acid molecule, which is made of 5 atoms. It should be as simple as 5 triangles with three different colors. I could not test it, because I did not manage to load the JSON file. Could you give us a tutorial on how to do this?
formic.json

Hi! Thank you for the comment.
I was able to load and view your formic.json model. Can you share your scene json file? The default configured is "demo.json". It is possible that the model just isn't in the viewport and needs to be moved in the scene, or that the camera needs to be moved.

I have not created a particular scene JSON file. The problem is that I did not understand where and how the program loads these JSON files. I just ran the "terminal_renderer" in the terminal, which automatically loaded the default JSON files. From the main.rs I understand now that I have to set the JSON files before compiling in the following:
const SCENE_FILE: &str = include_str!("../scenes/demo.json");
const MODEL_DIR: include_dir::Dir = include_dir!("models/");
Am I getting this correct now? Or is there a command-line argument to specify other JSON files in the compiled program?


[SYSRST_CTRL] ulp_status register is not updated when pwrb_det_pulse is detected

The ulp_status register reads value 0 even when the pwrb_det_pulse is detected. The ulpfsm is at DONE_ST state. the pulse is detected when the bus clk is disable and I am reading the register after enabling the bus clock.
The command to run the test and re-generate the issue is
./util/dvsim/dvsim.py hw/ip/sysrst_ctrl/dv/sysrst_ctrl_sim_cfg.hjson -i sysrst_ctrl_ultra_low_pwr --waves --tool xcelium --fixed-seed<PHONE_NUMBER>
The draft PR is
https://github.com/lowRISC/opentitan/pull/9962

@msfschaffner Could you please have a look at this issue?

Hi @patel-madhuri, I took a look at the waves. The RTL seems to behave correctly. The problem we're seeing here is due to the fact that the TL-UL read transaction is issued at the same time as the bus clock. Hence, the status values have not had any time to propagate through the synchronizer to the bus clock domain and we are reading 0 therefore. I suggest to wait a couple of cycles (at least 2-3) after re-enabling the bus clock.
FYI @weicaiyang @tjaychen I believe this should not be a real issue in the system, since a full wakeup is going to take many many bus cycles until the processor can execute again.

yes i think that's generally true. But just in case software needs to poll for any reason, is this something they could reasonably just keep reading until they get the right data?

We probably can, if needed, since we're expecting the ULP status register to be set to 1 after getting a wakeup request from sysrst_ctrl.

sounds good.

Thank you for the feedback. As we now have clear understanding, I am closing this issue.


KSS RSI driver pimp up with ros control

Heap allocations in control loop should also be removed!
RSICommand heap-allocates in consctructor, and it is instantiated in every cycle (write)

Tasks:

[ ] Heap allocation in udp server
[ ] Heap allocation in control loop and RSI Command
[ ] Redesign RSI Command and RSI State so it makes direct connection between buffer and hw param
[ ] working stop action when ROS side stopped
[ ] working stop action when robot side stopped
Low prio tasks:
[ ] IP set via config file
[ ] add cartesi control
[ ] controller handler and control mode change integration

Evaluating PUGI XML
After creating my own xml parser i implemented the pugi  xml parser too. The parser is capable of working on C style character strings which is compatible with the udp library i use. The user is also able to redefine the allocation functions. I redefined them with the memory resources library so the memory is allocated at the start of the algorithm.
Results
As the following diagrams shows there is a significant difference between the two xml parser both in encodeing and decodeing.
Decode

Encode

Conclusion and Tasks
The driver for encodeing and decoding messages to and from the RSI should use the PUGI XML parser. However further tests should be created to prove the real-time nature. The PUGI can be configured multiple ways.


DBZ-4415 oplog mode is not supported for MongoDB 5+

https://issues.redhat.com/browse/DBZ-4415

@gunnarmorling Comments addressed.


Adding Facebook Authentication

Fixes Issue #2101

Changes proposed
@codervivek5 I have added the Facebook Authentication yo the website.
Create a new Project with name VigyBag.
Get yor own Firebase Sdk file containing the Api Keys.
Add the Api Keys into the Firebase.js file.
Allow the authentication for Facebook from the Authentication Option.
Screenshots

Note to reviewers

Summary by CodeRabbit

New Features

Introduced Facebook authentication for social login via Firebase.
Added Firebase as a dependency to support enhanced features like real-time database and cloud storage.
Created a new firebase.js file to streamline Firebase authentication setup.

Bug Fixes

Improved layout alignment for "Remember me" and "Forgot password?" elements to enhance user experience.

is it possible to add this functionality without Firebase

@codervivek5 Not possible

@codervivek5 Sir is this ok?

actually we was planning to do not use firebase that's why I was asking to you

https://www.scaler.com/topics/react/facebook-login-react/
try this one

@codervivek5 Actually I am not aware of this but I will try to do so. It would take some more time if that's ok to you sir

Ok you can take your time ... But if possible then try to update me once a day

@codervivek5 ok

@codervivek5 Sorry sir but I am not able to do this. Kindly review this only. Sorry for the inconvenience.

@codervivek5 Sir please tell because tomorrow is last day for gssov

ok ..... kindly solve conflict then I'll merged
first pull the code then fix

@codervivek5 done

@codervivek5 Please review this sir as soon as possible as Gssoc Deadline is there.


helm-ff-directory and helm-ff-file have the same color

These two faces are used to separate between directory and file in helm-find-files. However, ujelly treats both the same colors and so does jbeans. This should be fixed.

Any suggestions on the color?


the order of entrypoint tasks doesn't work for all set-ups

v1.2.4-rc2
using redis for example, needs drivers but init winter runs first in the entrypoint script, this means the container crashes when trying to connect to redis for cache.

order of entrypoint tasks change to resolve this in develop


readme updates

Codecov Report
Base: 86.23% // Head: 86.23% // No change to project coverage :thumbsup:

Coverage data is based on head (44b9745) compared to base (a8a4006).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #84   +/-   ##
=======================================
  Coverage   86.23%   86.23%
=======================================
  Files          45       45
  Lines        5195     5195
=======================================
  Hits         4480     4480
  Misses        609      609
  Partials      106      106

Flag
Coverage Δ

go_tests
86.23% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Repeated sub_settings begin to drop fields and miscalculate branching logic after an arbitrary number of repetions

Description
When multiple repeated fields which contain sub-fields are created, eventually some of the sub-fields stop appearing under certain conditions.
Specifically this issue can be seen with CTS-IT's module Form Render Skip Logic. When creating new Control Fields - after a varying number of Control fields options are spawned, creating more will stop showing the 2nd dropdown under the Fields row and a normally hidden text box controlled by branching logic will appear (see picture):

Reproducing
While it appears under varying circumstances on our projects, it seems to be most easily recreated by:

Creating a new project using the Classic Database template.
Activating the FRSL external module.
Opening its configuration menu, pressing the + button ~12 times.
Scrolling to the bottom of the configuration menu window.
Pressing the + button _on the last Control Fields row.

Additional Information
In normal blocks, the Field row is under a tr with attribute field="control_field_key" immediately followed by a tr with attributes class="frsl_moved" value="control_event_id" containing the expected select element.
This <tr class="frsl_moved" value="control_event_id"> element and its children are not present in malformed blocks.
My guess is there is something going on with jQuery checking the page/window height to decide where to place the elements. Repeatedly pressing + on the last Control Field will deliver more  Control Fields missing the 2nd dropdown, but scrolling back up (not necessarily to the top) and clicking the + button on a sufficiently early block will deliver a normally formatted block beneath it, offsetting all others by one.

Mainly the issue is in ExternalModules.Settings.prototype.processBranchingLogicCondition by not adding the correct suffix to the new added element. the fix is to extract the suffix from the element triggered the function and append it to the new field.
We faced the same issue and fixed it. The fix currently in QA along with new features in config.json.
I will create pull request and add it here once we are ready to push.
Thanks,

Is this the same issue?
https://community.projectredcap.org/questions/68943/external-module-configuration-branching-logic-with.html

Hi @mmcev106
That does appear similar, but in our particular manifestation of this bug branching logic does not begin to fail until around the 10th sub setting instance or later.


Cannot build WinRPM on windows 10

Version 0.5.0-dev+2224 (2016-01-20 18:55 UTC)
Commit 275c7e8 (2 days old master)
x86_64-w64-mingw32
hi, I installed julia on my windows 10 just now, and running into the following problem. Is this a bug? I cannot decide and don't know how to fix it. Thanks!
julia> Pkg.add("HDF5")
INFO: Installing WinRPM v0.1.13
INFO: Removing Docile v0.5.23
INFO: Removing FileIO v0.0.3
INFO: Building WinRPM

Please submit a bug report with steps to reproduce this fault, and any error mes
sages that follow (in their entirety). Thanks.
Exception: EXCEPTION_ILLEGAL_INSTRUCTION at 0x221f503a -- unknown function (ip:
00000000221F503A)
while loading C:\Users\lizz\.julia\v0.5\WinRPM\src\WinRPM.jl, in expression star
ting on line 501
unknown function (ip:<PHONE_NUMBER>1F503A)
jl_apply_generic at /home/Administrator/buildbot/slave/package_win6_2-x64/build/
src\gf.c:1947
[inline] at C:\Users\lizz\.julia\v0.5\LibExpat\src\LibExpat.jl:141
xp_parse at C:\Users\lizz\.julia\v0.5\LibExpat\src\LibExpat.jl:300
jl_apply_generic at /home/Administrator/buildbot/slave/package_win6_2-x64/build/
src\gf.c:1947
update at C:\Users\lizz\.julia\v0.5\WinRPM\src\WinRPM.jl:153
__init__ at C:\Users\lizz\.julia\v0.5\WinRPM\src\WinRPM.jl:41
unknown function (ip:<PHONE_NUMBER>14CA64)
jl_apply_generic at /home/Administrator/buildbot/slave/package_win6_2-x64/build/
src\gf.c:1947
[inline] at /home/Administrator/buildbot/slave/package_win6_2-x64/build/src\juli
a.h:1576
jl_eh_restore_state at /home/Administrator/buildbot/slave/package_win6_2-x64/bui
ld/src\module.c:623
jl_eval_module_expr at /home/Administrator/buildbot/slave/package_win6_2-x64/bui
ld/src\toplevel.c:210
jl_toplevel_eval_flex at /home/Administrator/buildbot/slave/package_win6_2-x64/b
uild/src\toplevel.c:425
jl_parse_eval_all at /home/Administrator/buildbot/slave/package_win6_2-x64/build
/src\ast.c:747
jl_load_ at /home/Administrator/buildbot/slave/package_win6_2-x64/build/src\topl
evel.c:575
include at .\boot.jl:262
jl_apply_generic at /home/Administrator/buildbot/slave/package_win6_2-x64/build/
src\gf.c:1922
include_from_node1 at .\loading.jl:401
jl_apply_generic at /home/Administrator/buildbot/slave/package_win6_2-x64/build/
src\gf.c:1922
do_call at /home/Administrator/buildbot/slave/package_win6_2-x64/build/src\inter
preter.c:66
eval at /home/Administrator/buildbot/slave/package_win6_2-x64/build/src\interpre
ter.c:214
jl_toplevel_eval_flex at /home/Administrator/buildbot/slave/package_win6_2-x64/b
uild/src\toplevel.c:546
[inline] at /home/Administrator/buildbot/slave/package_win6_2-x64/build/src\juli
a.h:1576
jl_eh_restore_state at /home/Administrator/buildbot/slave/package_win6_2-x64/bui
ld/src\builtins.c:590
eval at .\boot.jl:265
jl_apply_generic at /home/Administrator/buildbot/slave/package_win6_2-x64/build/
src\gf.c:1922
[inline] at .\sysimg.jl:14
require at .\loading.jl:332
unknown function (ip:<PHONE_NUMBER>E96257)
jl_apply_generic at /home/Administrator/buildbot/slave/package_win6_2-x64/build/
src\gf.c:1922
eval_import_path_ at /home/Administrator/buildbot/slave/package_win6_2-x64/build
/src\toplevel.c:369
jl_toplevel_eval_flex at /home/Administrator/buildbot/slave/package_win6_2-x64/b
uild/src\toplevel.c:444
jl_parse_eval_all at /home/Administrator/buildbot/slave/package_win6_2-x64/build
/src\ast.c:747
jl_load_ at /home/Administrator/buildbot/slave/package_win6_2-x64/build/src\topl
evel.c:575
include at .\boot.jl:262
jl_apply_generic at /home/Administrator/buildbot/slave/package_win6_2-x64/build/
src\gf.c:1922
include_from_node1 at .\loading.jl:401
jl_apply_generic at /home/Administrator/buildbot/slave/package_win6_2-x64/build/
src\gf.c:1922
do_call at /home/Administrator/buildbot/slave/package_win6_2-x64/build/src\inter
preter.c:66
eval at /home/Administrator/buildbot/slave/package_win6_2-x64/build/src\interpre
ter.c:214
jl_toplevel_eval_flex at /home/Administrator/buildbot/slave/package_win6_2-x64/b
uild/src\toplevel.c:546
[inline] at /home/Administrator/buildbot/slave/package_win6_2-x64/build/src\topl
evel.c:415
jl_toplevel_eval_flex at /home/Administrator/buildbot/slave/package_win6_2-x64/b
uild/src\toplevel.c:481
[inline] at /home/Administrator/buildbot/slave/package_win6_2-x64/build/src\juli
a.h:1576
jl_eh_restore_state at /home/Administrator/buildbot/slave/package_win6_2-x64/bui
ld/src\builtins.c:590
[inline] at .\sysimg.jl:14
evalfile at .\loading.jl:417
evalfile at .\loading.jl:417
jl_apply_generic at /home/Administrator/buildbot/slave/package_win6_2-x64/build/
src\gf.c:1947
anonymous at .\none:14
cd at .\file.jl:57
jl_apply_generic at /home/Administrator/buildbot/slave/package_win6_2-x64/build/
src\gf.c:1947
anonymous at .\none:9
open at .\iostream.jl:114
jl_apply_generic at /home/Administrator/buildbot/slave/package_win6_2-x64/build/
src\gf.c:1947
do_call at /home/Administrator/buildbot/slave/package_win6_2-x64/build/src\inter
preter.c:66
eval at /home/Administrator/buildbot/slave/package_win6_2-x64/build/src\interpre
ter.c:214
jl_toplevel_eval_flex at /home/Administrator/buildbot/slave/package_win6_2-x64/b
uild/src\toplevel.c:546
[inline] at /home/Administrator/buildbot/slave/package_win6_2-x64/build/src\topl
evel.c:415
jl_toplevel_eval_flex at /home/Administrator/buildbot/slave/package_win6_2-x64/b
uild/src\toplevel.c:481
[inline] at /home/Administrator/buildbot/slave/package_win6_2-x64/build/src\juli
a.h:1576
jl_eh_restore_state at /home/Administrator/buildbot/slave/package_win6_2-x64/bui
ld/src\builtins.c:590
eval at .\boot.jl:265
jl_apply_generic at /home/Administrator/buildbot/slave/package_win6_2-x64/build/
src\gf.c:1922
[inline] at .\sysimg.jl:14
process_options at .\client.jl:222
_start at .\client.jl:301
unknown function (ip:<PHONE_NUMBER>D0C424)
jl_apply_generic at /home/Administrator/buildbot/slave/package_win6_2-x64/build/
src\gf.c:1922
true_main at /home/Administrator/buildbot/slave/package_win6_2-x64/build/ui\repl
.c:515
wmain at /home/Administrator/buildbot/slave/package_win6_2-x64/build/ui\repl.c:6
26
__tmainCRTStartup at /usr/src/debug/mingw64-x86_64-runtime-4.0.2-1/crt\crtexe.c:
334
mainCRTStartup at /usr/src/debug/mingw64-x86_64-runtime-4.0.2-1/crt\crtexe.c:214

BaseThreadInitThunk at C:\WINDOWS\system32\KERNEL32.DLL (unknown line)
RtlUserThreadStart at C:\WINDOWS\SYSTEM32\ntdll.dll (unknown line)
ERROR: Build process failed.
 in build! at .\pkg\entry.jl:554
 [inlined code] from .\dict.jl:483
 in build at .\pkg\entry.jl:573
 in resolve at .\pkg\entry.jl:489
 in edit at .\pkg\entry.jl:414
 in anonymous at .\task.jl:435
 in sync_end at .\task.jl:401
 [inlined code] from .\task.jl:410
 in add at .\pkg\entry.jl:57
 in add at .\pkg\entry.jl:78
 in anonymous at .\pkg\dir.jl:31
 in cd at .\file.jl:57
 in cd at .\pkg\dir.jl:31
 [inlined code] from .\pkg\dir.jl:25
 in add at .\pkg.jl:83
 in eval at .\boot.jl:265

julia>

probably the same as https://github.com/JuliaLang/WinRPM.jl/issues/63, LibExpat is broken on nightly. Use release Julia for now.

release version is okay. Thanks!


[Guided Setup Stage 3] Onboarding message not sent when VBBA selected

Details

Adds a completePaymentOnboarding call directly into AddPaymentMethodMenu so it always runs on payment confirmation, even if the user has to setup bank info afterwards.
Fixed Issues

$ https://github.com/Expensify/App/issues/50027
PROPOSAL:
Tests

Preconditions
Account of the sender has to set it's currency to USD, which you can do by logging into oldDot (expensify.com) and following the example video, setting your account currency to USD at the end.
https://github.com/user-attachments/assets/c2389875-f6ea-4321-a248-f2500ca8e0b5

On the first account submit an expense
To it as a recipient add an email that doesn't have an account made for it yet, also make sure it's currency is set to USD
Submit it and then navigate to your emails
Press on the magic link on the bottom of the message you've received inviting you to the expense (for dev purposes replace the link from new.expensify.com to dev.new.expensify.com:8082)
When navigated into expensify on the new account, go into the expense and for payment choose Business Bank Account
Confirm that the expense has been moved into the users workspace and a new message from Concierge was received with a task list that is read-only and an onboarding video appears, even if the user is redirected afterwards to complete forms required for this option.

[x] Verify that no errors appear in the JS console

Offline tests

QA Steps

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

MacOS: Chrome / Safari
https://github.com/user-attachments/assets/9aabbd85-bad8-491d-a407-00b8694913eb

@cdOut why I don't see pay with expensify? Are there any missing precondition?

Needs to be USD.

@cdOut why I don't see pay with expensify? Are there any missing precondition?

The sender account has to have its currency set to USD and then you also need to set it to USD for the expense itself, I’ll add steps for it in the descriptions in a sec

This functionality is not platform dependent so I don't think testing it on all platforms is necessary.

Yeah, agreed. Let's get this over to @deetergp for the secondary review and merge. 👍

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

The reported performance regression can be ignored, see:

https://github.com/Expensify/App/issues/50141


fix: support ConsumerGroups in KongRawStateToKongState

What this PR does / why we need it:
Support properly ConsumerGroups when fallback to the last valid configuration. Function configfetcher.KongRawStateToKongState now supports ConsumerGroup entities. It means that if KIC fetches the last valid configuration from Gateways, it will include all ConsumerGroups that a Gateway may return.

Which issue this PR fixes:
Fixes https://github.com/Kong/kubernetes-ingress-controller/issues/5377

Special notes for your reviewer:
Having explicitly omitted checking this in internal/dataplane/configfetcher/kongrawstate_test.go:318 caused that the test hasn't caught it during the work on ConsumerGroup. I thing the same may happen for Vault 🤔

PR Readiness Checklist:
Complete these before marking the PR as ready to review:

[x] the CHANGELOG.md release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR

Having explicitly omitted checking this in internal/dataplane/configfetcher/kongrawstate_test.go:318 caused that the test hasn't caught it during the work on ConsumerGroup. I thing the same may happen for Vault 🤔

Yup, the intention was that once implementing a new field in KongState we will remove the exclude from the test. But I think we might improve that and instead of asserting all of KongRawState - excluded fields to be covered in tests to assert all of kongstate.KongState fields to be covered as that's the struct KIC defines and once we add anything there, it should be also covered in the mapping from KongRawState. That would be something like this:
--- a/internal/dataplane/configfetcher/kongrawstate_test.go
+++ b/internal/dataplane/configfetcher/kongrawstate_test.go
@@ -277,7 +277,7 @@ func TestKongRawStateToKongState(t *testing.T) {

                        // Collect all fields that are tested in this test case.
                        if tt.kongRawState != nil {
-                               testedKongRawStateFields.Insert(extractNotEmptyFieldNames(*tt.kongRawState)...)
+                               testedKongRawStateFields.Insert(extractNotEmptyFieldNames(*tt.expectedKongState)...)
                        }

                        var state *kongstate.KongState
@@ -290,12 +290,12 @@ func TestKongRawStateToKongState(t *testing.T) {
                })
        }

-       ensureAllKongRawStateFieldsAreTested(t, testedKongRawStateFields.UnsortedList())
+       ensureAllKongStateFieldsAreTested(t, testedKongRawStateFields.UnsortedList())
 }

-// extractNotEmptyFieldNames returns the names of all non-empty fields in the given KongRawState.
+// extractNotEmptyFieldNames returns the names of all non-empty fields in the given KongState.
 // This is to programmatically find out what fields are used in a test case.
-func extractNotEmptyFieldNames(s utils.KongRawState) []string {
+func extractNotEmptyFieldNames(s kongstate.KongState) []string {
        var fields []string
        typ := reflect.ValueOf(s).Type()
        for i := 0; i < typ.NumField(); i++ {
@@ -308,22 +308,13 @@ func extractNotEmptyFieldNames(s utils.KongRawState) []string {
        return fields
 }

-// ensureAllKongRawStateFieldsAreTested verifies that all fields in KongRawState are tested.
+// ensureAllKongStateFieldsAreTested verifies that all fields in KongState are tested.
 // It uses the testedFields slice to determine what fields were actually tested and compares
-// it to the list of all fields in KongRawState, excluding fields that KIC doesn't support.
-func ensureAllKongRawStateFieldsAreTested(t *testing.T, testedFields []string) {
-       kongRawStateFieldsKICDoesntSupport := []string{
-               // These are fields that KIC explicitly doesn't support.
-               "SNIs",
-               "ConsumerGroups",
-               "CustomEntities",
-               "Vaults",
-               "RBACRoles",
-               "RBACEndpointPermissions",
-       }
-       allKongRawStateFields := func() []string {
+// it to the list of all fields in KongState, excluding fields that KIC doesn't support.
+func ensureAllKongStateFieldsAreTested(t *testing.T, testedFields []string) {
+       allKongStateFields := func() []string {
                var fields []string
-               typ := reflect.ValueOf(utils.KongRawState{}).Type()
+               typ := reflect.ValueOf(kongstate.KongState{}).Type()
                for i := 0; i < typ.NumField(); i++ {
                        fields = append(fields, typ.Field(i).Name)
                }
@@ -331,11 +322,7 @@ func ensureAllKongRawStateFieldsAreTested(t *testing.T, testedFields []string) {
        }()

        // Meta test - ensure we have testcases covering all fields in KongRawState.
-       for _, field := range allKongRawStateFields {
-               if lo.Contains(kongRawStateFieldsKICDoesntSupport, field) {
-                       t.Logf("skipping field %s - explicitly unsupported", field)
-                       continue
-               }
+       for _, field := range allKongStateFields {
                assert.True(t, lo.Contains(testedFields, field), "field %s not tested", field)
        }
 }

This catches Vaults, ConsumerGroups and Licenses as not tested. 👍

Neat idea @czeslavo. I checked it and it detects the field Plugins too as false-positive I think. The option is to explicitly ignore it... Also, I discovered that KongRawState doesn't contain the field Licenses, it has to be added


Scattered docs

Our documentation is currently scattered in

the CCL note
multiple READMEs
code examples (C and python)
the wiki
the CCL paper
doxygen
readthedocs

We should consolidate docs in as much as possible. The proposal is to put python code example snippets in the README, and ensure we maintain this as well as readthedocs and the README in the benchmark folder.
In this proposal, the CCL note and wiki would be deprecated (with the relevant information moved to the README) and the jupyter notebooks would move to a dedicated repository.

I think we should keep descriptions of the core equations in the note, but remove the information on the code in it.

We should remove doxygen too.


Update README.md

🙏 Describe the pull request
README.md is updated.
✅ Checklist

[x] Code follows the project's coding conventions and style.
[x] Tests have been added or updated to cover the changes.
[x] Documentation has been updated, if necessary.

LGTM


why sam not save when training ends.

Hi, I ran through your program. Why is it that only the lora weights are saved at the end of the fine tuning, the promt encoder and mask decoder downstream of sam are HOT parameters, don't they need to be saved?
In your inference_eval.py also only the lora parameters are loaded, not considering the parameters downstream of sam at all!

Hi,
For the training checkpoints, you can read in the readme "limitation" part. It is explained why I chose to save at the end.
For the loading of weights, I am freezing all weights of SAM (loading a SAM model is enough). Therefore I only need to load the LoRA checkpoint.


Sync all todos with a file

Currently, exporting todos from all to a markdown file is as easy as:
notes todos > todos.md

It will group them based on the files they were found in.
However, there are few considerations:

It is useful to export all of your current todos in the same notes folder. This helps if you want to commit them in version control so you can have a single list of todos on mobile after pushing to GitHub.
When exporting to your notes folder, then future runs of notes todos would give you duplicate todos. You'd need to always put notes in folders and filter by them.
It'd be better if we have a notes todos --export flag which exports to a specific file like $NOTES_PATH/todos.md and then this file is excluded when running notes todos.
This would help with future syncing. E.g. notes todos --sync could sync todos from $NOTES_PATH/todos.md back to every individual file it came from. This would be really nice to run after checking off todos from the common list. E.g. checking off on GitHub or from your mobile and then syncing back on your computer.
Even better would be to run notes todos --sync in automatic action when changing $NOTES_PATH/todos.md. Could use run-if-changed locally in a git hook or even  GitHub Action in your private notes repo so it works when checking checklist items from github.com.

Checklist:

[x] notes todos --export
[ ] notes todos --sync
[ ] Git hook for exporting/syncing
[ ] GitHub action for exporting/syncing

notes todos --export is now implemented in #4.

It would be interesting to consider the use case of ordering todos from all of your notes in priority order in todos.md when they are all in one place. How do  you do that if notes todos --export is meant to always overwrite this "summary" todos file from your current notes?


Provisioning documentation shows wrong type

What happened:
I wanted to provision a Redshift data source. I followed the README and used:
datasources:
  - name: redshift-data
    type: redshift
    ...

Whereas a new data source is provisioned, it's of an unknown type.
When I change to type: grafana-redshift-datasource, it's nicely provisioned and usable 👍
What you expected to happen:
How to reproduce it (as minimally and precisely as possible):
Anything else we need to know?:
Probably it doesn't matter, but we're adding the plugin via
GF_INSTALL_PLUGINS=....,grafana-redshift-datasource

Environment:

Grafana version: 9.5.3
Plugin version: 1.11.1
OS Grafana is installed on: Linux

please let me know if I should file a PR to update the README.

Hi @StephenKing, thanks for the report.

please let me know if I should file a PR to update the README.

Please feel free to open a PR.

I assume this defines the data source type:
https://github.com/grafana/redshift-datasource/blob/be82734ac176927387d7e5da71523a6191fcea73/src/plugin.json#L5

Yes, that's correct.

sorry, took me a while to make that two-line change PR ;)


NPM is installed every time

Whenever I try to install a new version of Node using nvm install <version-number>, it also installs the same version of NPM again. The application should have a check to see if:

NPM is already installed
the installed NPM version matches the one it is trying to install

It should proceed to install a fresh copy of NPM only after any of the cases fail.

Are you reinstalling an existing version of Node?
There is no version of Node that ships with the same version of npm, so the only way a conflict would arise is if you're installing a version again.

Currently, I have installed 3 Node versions on the system:
* 14.18.3 (Currently using 64-bit executable)
    12.22.6
    10.21.0

I think it installed the same NPMs every time when I installed these. As you are implying that all Node versions have a different version of NPM for them, it seems fine. I'll just confirm that this is really the case.

I was mistaken, it looks like the 12.x and 14.x branches both use npm 6.14.15. However; Node 10.21.0 uses npm 6.14.4. The full list can be found at https://nodejs.org/download/release/index.json
That said, most versions of Node have a different version of npm shipped with them.
Keep in mind, this still isn't a bug. NVM4W intentionally installs an isolated copy of npm for each version of Node. This allows developers to add global modules to each instance of Node without interfering with each other.
There is one possible improvement. NVM4W could store the installation source files for each version of npm. When a new version of Node is installed, it could search for any pre-existing downloads before downloading a new copy of npm.
I don't think the work-to-reward tradeoff is worth it. The file system will become bloated if NVM4W stores/archives each version of npm it downloads, especially when it won't really be used very often. It cannot use an "existing" installation from a previously installed version of Node because the previous version may include globally installed modules or native add-ons that do not work in the new version (i.e. not a clean install of npm).
If people are concerned about bandwidth consumption, please make a note in the discussions. I'd like to know how big of a concern this is for people/organizations. So far, most concerns I've been made aware of have to do with how much diskspace Node/npm takes up.


InternalError: GPU sync failed

sess = tf.Session(config=tf.ConfigProto(log_device_placement=True))
K.set_session(sess)
elmo = hub.Module("https://tfhub.dev/google/elmo/2", trainable=False)
sess.run(tf.global_variables_initializer())
sess.run(tf.tables_initializer())

model = prepare_model()
noHistory = model.fit(x_train, ytrain, epochs = 8, verbose = 1, batch_size = 32)

my prepare_model method is called to get the compiled model built in keras with tensorflow in back-end . the model has additional LSTM layers. I use the elmo in my model at the beginning.
Entire thing worked fine when I had trainable = True , after I set it to False I am getting this error precisely after two epochs, If I run the model on CPU irrespective of trainable flag it works fine. Can anybody tell me what is the issue here.
I am using,
Windows 10,
Nvidia 1050 Ti
Python 3.5
tensorflow-gpu 1.11
Cuda 8
Below is the stack trace of my error.
Epoch 1/8
48128/48128 [==============================] - 1548s 32ms/step - loss: 3.0862 - acc: 0.4062
Epoch 2/8
48128/48128 [==============================] - 1537s 32ms/step - loss: 1.4460 - acc: 0.6718
Epoch 3/8
26176/48128 [===============>..............] - ETA: 11:40 - loss: 1.0091 - acc: 0.7678Traceback (most recent call last):
File "", line 5, in
batch_size = batch_size)
File "C:\Users\demopc\AppData\Local\Continuum\anaconda3\lib\site-packages\keras\engine\training.py", line 1039, in fit
validation_steps=validation_steps)
File "C:\Users\demopc\AppData\Local\Continuum\anaconda3\lib\site-packages\keras\engine\training_arrays.py", line 199, in fit_loop
outs = f(ins_batch)
File "C:\Users\demopc\AppData\Local\Continuum\anaconda3\lib\site-packages\keras\backend\tensorflow_backend.py", line 2715, in call
return self._call(inputs)
File "C:\Users\demopc\AppData\Local\Continuum\anaconda3\lib\site-packages\keras\backend\tensorflow_backend.py", line 2675, in _call
fetched = self._callable_fn(*array_vals)
File "C:\Users\demopc\AppData\Local\Continuum\anaconda3\lib\site-packages\tensorflow\python\client\session.py", line 1399, in call
run_metadata_ptr)
File "C:\Users\demopc\AppData\Local\Continuum\anaconda3\lib\site-packages\tensorflow\python\framework\errors_impl.py", line 526, in exit
c_api.TF_GetCode(self.status.status))
InternalError: GPU sync failed

same issue, hope someone can explain

same issue, hope someone can explain
@xwzhong  Did you try running it with lesser batch size.

@ameyyadav09 yes, i did, but it still occured. after that, I fix other bug, the "GPU sync failed" bug disappeared(running for 3day+), thanks much

This seems very unrelated with hub. Closing.

same problem ! please Help ...


file_input uses a reasonable default for max_concurrent_files

Description of Changes
Please check that the PR fulfills these requirements

[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)
[ ] Add a changelog entry (for non-trivial bug fixes / features)
[ ] CI passes

Log Files
Logs / Second
CPU Avg (%)
CPU Avg Δ (%)
Memory Avg (MB)
Memory Avg Δ (MB)

1
1000
1.5000546
-0.034436345
127.724945
-1.0408173

1
5000
5.0345483
-0.10353184
138.13443
+0.021820068

1
10000
10.345002
+0.17221832
144.03934
-0.8076477

1
50000
49.98382
-5.066799
171.18723
-0.94667053

1
100000
106.01578
-3.6419754
245.30334
-3.4971619

10
100
1.9828336
+0.25869453
134.03354
+0.64601135

10
500
6.775978
+0.74148417
140.29431
+2.0787964

10
1000
11.879361
-1.7245035
149.3416
+2.3935852

10
5000
57.696472
+2.317276
180.33904
+1.4684753

10
10000
110.42671
-8.425774
226.45798
-10.451233

This will make it impossible for the user to specify "unlimited" by explicitly setting max_concurrent_files: 0. However, it's not clear that this behavior is really ever desired anyways. If so, it can be approximated by setting max_concurrent_files: HUGE_NUMBER.


Maya: Deadline - fix limit groups

Bug
Submitting job from Maya to Deadline was ignoring Limits and Groups set in Settings.
Close #2172

Task linked: OP-1917 Maya: Deadline limit groups are not working


[Accessibility] Consider adding audio cues for diffs (added / deleted code)

CC @isidorn and @hediet
It would be so much nicer if screen reader users could hear any unique audio cues for added and deleted lines when comparing git diffs. Currently, it is only possible by tediously reviewing plus (+) and minus (-) signs.

@jooyoungseo so your suggestion is to have two different sounds. One for an added line, and one for a deleted line. Right?
I think this makes sense. I suggest that we leave this open for now and we can add it in the future.
fyi @gino-scarpino

Cool idea. I also hear your tonal logic for add and delete. Will add to the backlog. Thanks!

@gino-scarpino and @isidorn -- I know you are already swamped with other prioirity work, but I was wondering if you had any specifically planned milestone for this feature.
These days, I have seen many discussions and concerns about accessible git diffs among blind programmers in the program-l listserv. Although F7/Shift+F7, Alt+F5/Shift+Alt+F5 are very instrumental, having more discernable and discoverable audio tones would be much more accessible. A related issue (#88695) filed few years ago by another screen reader user also suggested this idea using sounds for diffs, but audio cues were not supported in VSCode back then. #152511, while it's closed, also reveals the discoverability challenges of diff accessibility features among screen reader users.
Given that VSCode audio cues are highly appreciated by many blind programmers recently, I believe it is the right timing to introduce this feature for diffs. I also believe this addition would be potentially helpful for sighted users as well (see #15371).

@jooyoungseo great feedback thanks!
@meganrogge I think this is one of the features we should look into in November or December milestones. Assigning also to you and we can discuss more.

@AFre100 could you pls add these sounds to the vscode repo?

@meganrogge  Yes! We have Diff sounds for VS Windows that are shipped. Sent via chat.

One interesting thing about this is the cursor skips over deleted lines in the diff view. So we can play the diff deleted cue on the line above or below the deletion perhaps?

For some reason Git won't let me view this on the site even though I'm
logged in. Anyways, I've been testing and trying to trigger sounds in VSC
and VS. I made a python file to test sounds as a template where anyone
can click around to listen to playback while experiencing the actual
interaction. Been gathering footage as well, of interactions.
Any chance you could record your screen (w/its audio) of this issue and
show me?
On Tue, Nov 15, 2022 at 12:24 PM Megan Rogge @.***>
wrote:

One interesting thing about this is the cursor skips over deleted lines in
the diff view. So we can play the diff deleted cue on the line above or
below the deletion perhaps?
—
Reply to this email directly, view it on GitHub
https://github.com/microsoft/vscode/issues/147226#issuecomment-1315639529,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AZ3VLGSPYR7EKOZDWRU4BMDWIPBLPANCNFSM5TDOHOIQ
.
You are receiving this because you were mentioned.Message ID:
@.***>

@jooyoungseo from what I see, the DiffReview editor has only two states - lines added and deleted.
When I modify a line, in the editor, I see one line deleted and one added.

Thanks for your prompt reply, @meganrogge. I guess that happens within DiffReview pane (F7/Shift+F7). However, what does happen in editor? You know, you can jump between changes by pressing Alt+F5 and Alt+Shift+F5 in editor. Do we hear audio cues for modified lines there?

@jooyoungseo I don't think there are audio cues for the normal editor corresponding to the git decorations.
I looked into implementing them there when I initially started this work bc didn't realize the request was for the diff review editor and it seems more involved, but doable

@meganrogge  It would be greatly appreciated if the diff audio cues could be triggered in normal editor as well b/c there's no semantic clues for screen readers for this in the editor besides the explicit DiffReview (F7) call. If I return to my suggestions above, there might be three cases representing changes in normal editor: added, deleted, and modified lines. I was suggesting adding one more audio cue indicating the modified line; otherwise, we may hear both deleted and added audio cues simultaneously, which may not that obvious. What do you think?

Hey @jooyoungseo yes that makes sense and I agree with that approach for the normal editors.
My linked PR will only fix this for diff review mode/editors - in which there is no such thing as a modified state.
I can consider working on this for normal editors in the coming iterations

@AFre100 I'm not sure what you are asking

@meganrogge -- After updating to the latest insider build, all the audio cues stopped working.
Version: 1.74.0-insider (system setup)
Commit: d9a70c4236a8bde4fe7435df3ecdd333c7bc939c
Date: 2022-11-17T05:26:03.777Z
Electron: 19.1.3
Chromium: 102.0.5005.167
Node.js: 16.14.2
V8: <IP_ADDRESS>-electron.0
OS: Windows_NT x64 10.0.22621
Sandboxed: Yes

@meganrogge https://github.com/meganrogge  Ah yes, was asking -- if
you're already testing these interactions in VSC, could you record your
screen and send it to me? Just want to make sure I'm aligned with what
you're describing...If you've moved on though, no worries!
On Wed, Nov 16, 2022 at 5:54 PM Megan Rogge @.***>
wrote:

@AFre100 https://github.com/AFre100 I'm not sure what you are asking
—
Reply to this email directly, view it on GitHub
https://github.com/microsoft/vscode/issues/147226#issuecomment-1317783072,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AZ3VLGUMT7LEXYEP3LM6ESLWIVQYXANCNFSM5TDOHOIQ
.
You are receiving this because you were mentioned.Message ID:
@.***>

@jooyoungseo it would be great if you could verify that this feature works for you today in insiders

@meganrogge Yes, verified. It works nicely. Thanks!