Fix pending approvals query

For https://github.com/ProfessionalWiki/PageApprovals/issues/77

My guess is that the SQL query in DatabasePendingApprovalRetriever is wrong

After exhausting Claude and using ChatGPT to rethink just the getLatestApprovalSubquery() logic, it seems like it is working now. I didn't review this query in detail. At a high level it moved the sub-subquery to the select section.


LEDs are not working

The LEDs are working with neopixel as in this example:
http://noob-nerd.de/nodemcu-led-effekt-via-ws2812b/
It seems that my WS2812B and FastLed won't work together.
I also tried several FastLed versions.
Do you have any idea?
Thanks!

Oh, how stupid, I use pin D4, so I typed D4 instead of 4:
#define DATA_PIN 4
Not it works like a charm!
Thanks very much!!!


No available pre-compiled binaries

Nice project.
I plan to test it but without docker image available or pre-compiled binaries inside the releases page, it can be hard.
I downloaded the .rar, there is no executable file.

Wow, I just figured out that the list of platform was link to tar.gz.... Sorry for inconvenience.


Gnina installation on HPC

Issue summary
Hi, I'am trying to install gnina on HPC and i occured following problem during cmake/make step. I installed obabel elsewhere due to lack of root access on the cluster an I think that's the main problem, but i have no idea how to handle it.
Steps to reproduce
git clone https://github.com/openbabel/openbabel.git
cd openbabel
git checkout openbabel-3-1-1
mkdir build
cd build
cmake -DCMAKE_INSTALL_PREFIX=/home2/sfglab/mwisniewski/Software/openbabel -DWITH_MAEPARSER=OFF -DWITH_COORDGEN=OFF -DPYTHON_BINDINGS=ON -DRUN_SWIG=ON ..
make
make install

export OpenBabel3_DIR=/home2/sfglab/mwisniewski/Software/openbabel

git clone https://github.com/gnina/gnina.git
cd gnina
mkdir build
cd build
~/Software/cmake/bin/cmake -DCMAKE_INSTALL_PREFIX=/home2/sfglab/mwisniewski/Software/gnina  ..
make
make install

Outputs from gnina cmake and make attached
cmake.txt
make.txt

still it doesnt work ;/

If your HPC systems supports Spack, you might give https://github.com/gnina/gnina/pull/184 a try.
spack install gnina

might work.

my HPC doesnt support Spack and pre-built executable doesnt work

What happens when you try to run the prebuilt executable?


DOCS: How to make mount permanent

Tell us more about this new feature.
I would like to know how to permanently mount the S3 bucket, so that when the linux server is rebooted the mount is persisted.
Can anyone provide a recommendation for how to do it?

Hi @ixodie ! One of the workaround you may try is automount your bucket on your instance reboot by using systemd. You can track how to do it from #441 .
We also have a feature request open for Compatibility with fstab #44 which supports mounting a folder to a bucket after reboot. Please do thumbs up if that's important for you. Thanks.

Thanks for the documentation update request. I think we should add a note for this, even if we don't have the perfect solution yet. I'll leave this open until we have documentation updated for this.


Don't throw exception if the header has authorization and a token set…

… to undefined
A common pattern with Single Pages Applications is to add an http interceptor that would add the Authorization header to all calls even those that are not meant to be under auth. They just set an 'undefined' token and lets the credentials do the rest.
This change allows such request to pass through the same way as if they don't had the Authorization header.

Hey,
Thanks for contributing to the package!
I have tried to look on the internet for this common pattern, but I could not find a single place this is a common and best practice.
The "authorization" header has a well-known set of use cases (Basic authentication or using a token - a prefix and the token itself)
Putting the word "undefined" in the header looks like a bad coding (maybe from JS when you are trying to put a token and it's not defined).
I think that case is your personal case and not a common pattern and therefore I don't think it's the best idea to add it to a package that should match to the standards.
A solution to this is to add a middleware in Starlette which removes the "Authorization" header if it equals to "undefined" before the request hits this middleware.
This will fix your issue without adding more "custom" changes to this package.
Thanks,
Amit.


[WIP] Add DropDownController component

Part 1: https://github.com/airbnb/react-dates/pull/1360
This is part of some continued efforts to rearchitect the library allow for asynchronous loading of the DayPicker tree.
The diff is quite big, but the general gist of the PR is to create an in-between layer of the component tree called the DropDownController. In the future, both the DateRangePicker and the SingleDatePicker (and any other pickers we can imagine) will leverage this component.
The current architecture transforms the SingleDatePicker into a much simpler component that basically does:
function SingleDatePicker(props) {
  return (
    <DropDownController
      {...props}
      input={SingleDatePickerInputController}
      inputProps={SingleDatePickerInputControllerProps}
      dropdown={DayPickerSingleDateController}
      dropdownProps={DayPickerSingleDateControllerProps}
    />
  );
}

The DropDownController handles all the shared input/picker logic like focus state between the input and the dropdown, rendering portals appropriately, responsively styling the picker, styling the input and picker containers, showing/hiding the keyboard shortcuts panel, etc.
The thing I'm doing now that I'd love some guidance on is with the props. There are some challenges in this area because:

there are props that are unique to the SDP or the DRP in addition to those that are shared
there are props that are controlled by the DropDownController that need to be spread onto the input and picker directly

You can see in the first commit that my initial approach was to have the DropDownController only take the props that it uses directly and to have the SingleDatePicker pass down nodes for the input and dropdown. That was much simpler as far as the code (and propTypes went), BUT because the DropDownController had to spread on props like isDayPicker/InputFocused and some handlers, it required cloning the element which was such a performance disaster that it made a difference on my high-powered macbook pro. :|
Anyways, any advice on a good approach would be appreciated!
@lencioni @ljharb @noratarano @amhunt

Coverage decreased (-1.9%) to 83.007% when pulling 5999dbde72d00448d3e6109b6e46f577d34195dd on maja-add-dropdowncontroller into d857a247d0869e06a0f54b20b158d3f510970dd8 on master.

Hmmm - could we use objects to contain the props for each of these different types of props (e.g. shared props for SDP/DRP, additional props for SDP, additional props for DRP, props for the dropdown component itself).
I see that you're currently creating objects like this within the component, but could we just have the user pass in those objects instead?

The only challenge with that approach @amhunt is that if we did


Separate DataFilesDict and MetadataConfigs

I did a few changes:

MetadataConfigs.resolve_data_files_locally returns a DataFilesDict given a config name
MetadataConfigs.get_builder_config returns a BuilderConfig given a config name
DatasetModule has optional attributes:

dataset_infos: to passinfo= to builder_cls() if the requested config has a dataset_info
metadata_configs: to update the builder's hash if the requested config has a metadata_config
builder_configs: to configure the builder class
default_config_name: to configure the builder class

@dataclass
class DatasetModule:
    module_path: str
    hash: str
    builder_kwargs: dict
    dataset_infos: Optional[DatasetInfosDict] = None
    metadata_configs: Optional[MetadataConfigs] = None
    builder_configs: Optional[List[BuilderConfig]] = None
    default_config_name: Optional[str] = None

other minor improvements

removed get_dataset_info_from_dataset_metadata since we can just use DatasetInfosDict.from_metadata
removed get_dataset_info_from_dataset_infos_json since we need the full dataset_infos now - I reused the old code

Therefore MetadataConfigs is not modified in place anymore, which makes the logic easier to manipulate IMO

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

I switched to passing None by default instead of "default" for the config name @polinaeterna
I also added some tests. Let me know what you think :)


Translations update from Hosted Weblate

Translations update from Hosted Weblate for Morse/Morse.
Current translation status:

Thank you so much for your support, @CloneWith! 😘


plotly 0.8.1 seems not work with kaleido 0.3.0

Is there anything wrong with this?
Envrionment:
Toolchain: stable-x86_64-pc-windows-msvc
Rust/Cargo: 1.64.0
Steps to reproduce:
cargo init app_name
cd app_name
cargo add plotly
cargo add plotly --features kaleido
cargo check
Output:
....
   Compiling plotly_kaleido v0.3.0
    Checking plotly v0.8.1
error[E0308]: mismatched types
   --> C:\Users\mwim\.cargo\registry\src\github.com-1ecc6299db9ec823\plotly-0.8.1\src\plot.rs:385:17
    |
383 |             .save(
    |              ---- arguments to this function are incorrect
384 |                 filename.as_ref(),
385 |                 &serde_json::to_value(self).unwrap(),
    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ expected `str`, found enum `Value`
    |
    = note: expected reference `&str`
               found reference `&Value`
note: associated function defined here
   --> C:\Users\mwim\.cargo\registry\src\github.com-1ecc6299db9ec823\plotly_kaleido-0.3.0\src\lib.rs:124:12
    |
124 |     pub fn save(
    |            ^^^^

For more information about this error, try `rustc --explain E0308`.
error: could not compile `plotly` due to previous error

I can confirm the same behavior. Compling plotly as a dependency in a standalone project gives the above error. Strangely, building any example in master branch works fine.
Minimal example below.
Cargo.toml
[package]
name = "rust-plotting"
version = "0.1.0"
edition = "2021"

# See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html

[dependencies]
plotly = { version = "0.8.1", features = ["kaleido"]}

main.rs
use plotly::common::{AxisSide, Font, Title};
use plotly::layout::{Axis, GridPattern, Layout, LayoutGrid, Legend, RowOrder, TraceOrder};
use plotly::{color::Rgb, Plot, Scatter};

use plotly::ImageFormat;

fn main() {
    let trace1 = Scatter::new(vec![1, 2, 3], vec![4, 5, 6]).name("trace1");
    let trace2 = Scatter::new(vec![20, 30, 40], vec![50, 60, 70])
        .name("trace2")
        .x_axis("x2")
        .y_axis("y2");

    let mut plot = Plot::new();
    plot.add_trace(trace1);
    plot.add_trace(trace2);

    let layout = Layout::new()
        .x_axis(Axis::new().domain(&[0., 0.7]))
        .y_axis2(Axis::new().anchor("x2"))
        .x_axis2(Axis::new().domain(&[0.8, 1.]));
    plot.set_layout(layout);
    if show {
        plot.show();
    }

    // The following will save the plot in all available formats and show the plot.
    plot.write_image("scatter", ImageFormat::SVG, 1024, 680, 1.0);
    println!("{}", plot.to_inline_html(Some("custom_sized_subplot")));
}

I am new to rust, but after digging deeper, it seems that the Cargo published version of plotly_kaleido is wrong. Doing a diff between what Cargo downloads in the registry at .cargo/registry/src/github.com-1ecc6299db9ec823/plotly_kaleido-0.3.0 and what is in the github version for tag 0.8.1 shows major differences.

I agree with your findings, @andrei-ng. It looks like I need to bump the version of plotly_kaleido and publish it to crates.io, as well as making the appropriate change to the plotly_kaleido dependency in the main plotly Cargo.toml manifest.
I'll need to ask @igiagkiozis for shared ownership of the plotly_kaleido crate on crates.io and then I can push the changes asap.

@mfreeborn , I noticed you were hard at work to refactor and close all the PRs :)
Any update on this one since the release of v0.8.2 would likely have the same issue ?

I'm just chasing up access to the plotly_kaleido crate on crates.io now,
at which point I can push out a new release.
On Thu, 3 Nov 2022 at 14:28, Andrei @.***> wrote:

@mfreeborn https://github.com/mfreeborn , I noticed you were hard at
work to refactor and close all the PRs :)
Any update on this one since the release of v0.8.2 would likely have the
same issue ?
—
Reply to this email directly, view it on GitHub
https://github.com/igiagkiozis/plotly/issues/106#issuecomment-1302199849,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AHSVKWGBSEX7G346L6SY7W3WGPDYVANCNFSM6AAAAAARDPCBUA
.
You are receiving this because you were mentioned.Message ID:
@.***>

OK, thank you!

@andrei-ng @m-wim I would expect this to be fixed now in 0.8.3 :)

I can confirm all works well now. Thank you very much for the effort @mfreeborn !


MAINT: fix compiler warnings for python setup.py build_clib.

Current coverage is 86.23% (diff: 100%)

Merging #265 into master will increase coverage by 0.05%

@@             master       #265   diff @@
==========================================
  Files            20         20
  Lines          3045       3043     -2
  Methods          45         45
  Messages          0          0
  Branches        521        520     -1
==========================================
  Hits           2624       2624
+ Misses          370        369     -1
+ Partials         51         50     -1

Powered by Codecov. Last update 45cf2a5...b2a0f82

Current coverage is 86.23% (diff: 100%)

Merging #265 into master will increase coverage by 0.05%

@@             master       #265   diff @@
==========================================
  Files            20         20
  Lines          3045       3043     -2
  Methods          45         45
  Messages          0          0
  Branches        521        520     -1
==========================================
  Hits           2624       2624
+ Misses          370        369     -1
+ Partials         51         50     -1

Powered by Codecov. Last update 45cf2a5...b2a0f82

thanks!


Support for obsidian projects plugin

I don't know if you heard about the projects plugin. But it wants to integrate other plugins as views. You can check this article to get an overview of the plugin.
I would like to suggest adding this plugin as a view to the projects plugin, you can check the related issue or the custom view API for context, or you can reach out to the maintainer on discord (marcusolsson#5186), he said he'd be happy to help you in the process.

I love this direction. I'm a bit short on plugin development time at the moment, but will definitely put this integration in my shortlist.


Possible new capture method - CaptureExceptionWithMessage()

So the common usage I had for Sentry was to capture an error, alongside a message indicating some hints as to what was happening then. The exact method used was raven.CaptureError(), which accepted the error, a map of context and details, and the string I passed in.
Is there any alternative to that I might be missing here?
The current options are:

CaptureException(); CaptureMessage() - this is what I was doing, but it inflates the amount of errors, and it can be hard to correlate them.
errors.Wrap() / errors.WithMessage() - this loses the stack trace, which is a critical part of the context required to sort the issue out.
revert to raven-go lol

Regards,
Ani
EDIT: forgot to mention, I am more than happy to give this a shot myself. However, I was not sure if this is open source as in source available but only the cool insider kids can commit cough Google, or if it was actually open source :)

the common usage I had for Sentry was to capture an error, alongside a message indicating some hints as to what was happening then.
Is there any alternative to that I might be missing here?

Might not be as ergonomic, but possible today.
sentry.WithScope (or hub.WithScope if you're doing this concurrently from multiple goroutines) allows you to do a lot of things that alter events.
You could use Breadcrumbs or set the Message on the event using an EventProcessor:
sentry.WithScope(func(scope *sentry.Scope) {
	scope.AddEventProcessor(func(event *sentry.Event, hint *sentry.EventHint) *sentry.Event {
		event.Message = "custom message"
		return event
	})
	sentry.CaptureException(err)
})

sentry.AddBreadcrumb(&sentry.Breadcrumb{
	Message: "custom message",
})
sentry.CaptureException(err)

As for adding new APIs, the new Sentry SDKs try to follow an unified design https://develop.sentry.dev/sdk/unified-api/.

I was not sure if this is open source as in source available

The project is open source and we do accept external contributions, not only to the SDKs but also to Sentry itself https://github.com/getsentry/sentry.

Sweet, that worked  perfectly for my use case :)
It's not ideal in ideal in terms of elegance, but it'll do! Maybe the documentation could explain this a bit better, unless I missed it? More specifically, the raven -> sentry migration guide.

Sweet, that worked perfectly for my use case :)

Glad it helped!

Maybe the documentation could explain this a bit better, unless I missed it? More specifically, the raven -> sentry migration guide.

We'd be happy to try to improve it.
@sk0g, were you following the guide in https://docs.sentry.io/platforms/go/migration/ or https://github.com/getsentry/sentry-go/blob/master/MIGRATION.md (or somewhere else?!)?
Which one of the solutions I proposed did you decide to use?  (Maybe a quick note on your decision process would be helpful too).
Thanks!

Hey, I ended up writing the capture exception event like this:
                sentry.WithScope(func(scope *sentry.Scope) {
			scope.AddEventProcessor(func(event *sentry.Event, hint *sentry.EventHint) *sentry.Event {
				event.Message = m
				return event
			})
			sentry.CaptureException(err)
		})

I saw all the other options for additional information in the event struct, and decided that was a cleaner way to do it.
https://docs.sentry.io/platforms/go/migration/ is the guide I was following. It did mention messages but more as a separate process. I didn't realise you can use it as scope while capturing an error to propagate the message alongside the error, very cool!
I guess if the APIs are being kept consistent, there would be no point to this, but I think this hack/ workaround deserves a mention in the migration guide :sweat_smile:


Add react-native-ultimate-config

Why
Add new library react-native-ultimate-config

Checklist

If you added a new library:

[x] Added it to react-native-libraries.json

If you added a feature or fixed a bug:

[ ] Documented in this PR how to use the feature or replicate the bug.
[ ] Documented in this PR how you fixed or created the feature.

hi, @brentvatne I noticed a handful of prs have been merged since I opened this one, is there anything missing? why is it not getting merged? Thanks.

hey! sorry about that, i think there was some merge conflict and then i forgot to come back


Add a convenient method to compute the highest level of compatibility of all the sub-projects aggregated by a project

Just to let you know, I've added a stub GitHub Workflow script to etag-caching in https://github.com/guardian/etag-caching/pull/22 (at the moment, hard-coded to 'Breaks Binary Compatibility') that could probably consume the output of this sbt task!


KafkaChannel upgrade tests

Proposed Changes

Upgrade tests for KafkaChannel

Release Note

Docs

&{{KafkaChannel messaging.knative.dev/v1beta1} {sut  eventing-e2e11  1bfc08c1-a179-4eed-88d9-e4d281d26d82 12783 1 2022-03-31 11:02:44 +0000 UTC <nil> <nil> map[] map[messaging.knative.dev/subscribable:v1] [] [kafkachannels.messaging.knative.dev]  [{Go-http-client Update messaging.knative.dev/v1beta1 2022-03-31 11:02:44 +0000 UTC FieldsV1 {"f:metadata":{"f:annotations":{".":{},"f:messaging.knative.dev/subscribable":{}}},"f:spec":{".":{},"f:delivery":{".":{},"f:backoffDelay":{},"f:backoffPolicy":{},"f:retry":{}},"f:numPartitions":{},"f:replicationFactor":{},"f:retentionDuration":{}}} } {kafka-controller Update messaging.knative.dev/v1beta1 2022-03-31 11:02:44 +0000 UTC FieldsV1 {"f:metadata":{"f:finalizers":{".":{},"v:\"kafkachannels.messaging.knative.dev\"":{}}}} } {kafka-controller Update messaging.knative.dev/v1beta1 2022-03-31 11:02:44 +0000 UTC FieldsV1 {"f:status":{".":{},"f:conditions":{},"f:observedGeneration":{}}} status}]} {1 [{Addressable Unknown  {2022-03-31 11:02:44 +0000 UTC}  } {ConfigMapUpdated Unknown  {2022-03-31 11:02:44 +0000 UTC}  } {ConfigParsed Unknown  {2022-03-31 11:02:44 +0000 UTC}  } {DataPlaneAvailable False  {2022-03-31 11:02:44 +0000 UTC} Data plane not available Did you install the data plane for this component?} {ProbeSucceeded Unknown  {2022-03-31 11:02:44 +0000 UTC}  } {Ready False  {2022-03-31 11:02:44 +0000 UTC} Data plane not available Did you install the data plane for this component?} {TopicReady Unknown  {2022-03-31 11:02:44 +0000 UTC}  }] map[]}}

Interesting...

@aliok see https://github.com/knative-sandbox/eventing-kafka-broker/blob/1695e55f3f3ab27b6f941cdbef38049874f2142a/test/e2e-common.sh#L134

LOL I found it around the same time you wrote me :)

/test unit-tests_eventing-kafka-broker_main

/unhold
ok, test passing, no need to hold

/test unit-tests_eventing-kafka-broker_main

/test unit-tests_eventing-kafka-broker_main

/test channel-integration-tests-ssl_eventing-kafka-broker_main


[WIP] Add use case instructions to docs

- Summary
Adds context to the available commands, replacing the existing Get Started and intro docs pages.
I couldn't get the docs:build command to work for me locally, so we still need to run that to generate the ToC and Command reference with Markdown Magic.
- A picture of a cute animal (not mandatory but encouraged)

Coverage remained the same at 70.233% when pulling da5e82b2449b7c98e5c9e5fbbe09207e9c24216d on more-docs into f7c373f53ce4b49e019d14778697c769f43429e2 on master.

Coverage remained the same at 70.233% when pulling da5e82b2449b7c98e5c9e5fbbe09207e9c24216d on more-docs into f7c373f53ce4b49e019d14778697c769f43429e2 on master.


⚠ Pihole-KA has degraded performance

In 81a023a, Pihole-KA ($URL_PIHOLE_MERZ_NIMBUS) experienced degraded performance:

HTTP code: 200
Response time: 12721 ms

Resolved: Pihole-KA performance has improved in e2936ac.


6 high severity vulnerabilities when running npm install netlify-cms-app

trim  <0.0.3
Severity: high
Regular Expression Denial of Service in trim - https://github.com/advisories/GHSA-w5p7-h5w8-2hfq
No fix available
node_modules/trim
  mdast-util-to-hast  <=6.0.2
  Depends on vulnerable versions of trim
  node_modules/netlify-cms-widget-markdown/node_modules/mdast-util-to-hast
    remark-rehype  <=5.0.0
    Depends on vulnerable versions of mdast-util-to-hast
    node_modules/netlify-cms-widget-markdown/node_modules/remark-rehype
  remark-parse  <=8.0.3
  Depends on vulnerable versions of trim
  node_modules/netlify-cms-widget-markdown/node_modules/remark-parse
    netlify-cms-widget-markdown  *
    Depends on vulnerable versions of remark-parse
    node_modules/netlify-cms-widget-markdown
      netlify-cms-app  *
      Depends on vulnerable versions of netlify-cms-widget-markdown
      node_modules/netlify-cms-app

Are there any plans to upgrade these packages? Also reported here: https://snyk.io/test/npm/netlify-cms

Yup, came here to report the same. netlifycms unusable atm

Following this issue as well. This vulnerability was reported via Dependabot 10 months ago - are there plans to resolve?

I know there's work being done to refactor and revive the project, but since this is a security vuln, I hope for this to be a top priority.

Following this issue as well. Still experiencing this reported issue as of 6/12/2023

There is also a vulnerability reported for validate-package when installing the latest version of decap-cms:
✗ Denial of Service (DoS) [High Severity][https://security.snyk.io/vuln/SNYK-JS-VALIDATECOLOR-2935878] in<EMAIL_ADDRESS>    introduced by<EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>  No upgrade or patch available

Same issue as well in 2024

Since this has been opened a while I might have a look to see if it's easy to add a PR for this

This issue is still persistent in decap-cms-app as of today. All versions of the package trim prior to 0.0.3 are affected by CVE-2020-7753 ReDoS. I know trim can't be updated because of conflicting dependencies:
<EMAIL_ADDRESS>requires<EMAIL_ADDRESS>via a transitive dependency on<EMAIL_ADDRESS><EMAIL_ADDRESS>requires<EMAIL_ADDRESS>via a transitive dependency on<EMAIL_ADDRESS>No patched version available for trim

I will try to fix this or find a workaround for the time being.


Text Extractor misrecorgnize DPI

Microsoft PowerToys version
0.77.0 and 0.78.0
Installation method
PowerToys auto-update
Running as admin
Yes
Area(s) with issue?
TextExtractor
Steps to reproduce

enable dual monitor with display extend in project
make DPI scaling of secondary monitor diffrent to primary
launch text extractor

✔ Expected Behavior
text extractor recognize primary monitor DPI
❌ Actual Behavior
text extractor is confuse DPI between primary and second so draws overzoomed capture for grayout
Other Software
No response

Can you please send a screenshot of what's happening?
Information about configuration and exact DPIs might also help in reproducing.
/needinfo

1920×1080 100%
1920×1080 100%
2560×1600 250%
text extractor doesn't have many config you know

@TheJoeFin , Managed to repro dpi issues :)

@jaimecbernardo I'm glad we finally are able to repro this! Can you include your Text Extractor logs so I can see exact screen coordinates?

These are my logs, although I played with it a bit:
[11:35:55.9627132] [Info] App::Application_Startup
    TextExtractor started from the PowerToys Runner. Runner pid=15928
[11:35:58.5190807] [Info] WindowUtilities::LaunchOCROverlayOnEveryScreen
    Adding Overlays for each screen
[11:35:58.5236288] [Info] WindowUtilities::LaunchOCROverlayOnEveryScreen
    screen Screen[Bounds={X=0,Y=0,Width=1920,Height=1200} WorkingArea={X=0,Y=0,Width=1920,Height=1152} Primary=True DeviceName=\\.\DISPLAY1
[11:35:59.0885515] [Info] WindowUtilities::LaunchOCROverlayOnEveryScreen
    screen Screen[Bounds={X=1920,Y=-835,Width=1920,Height=1080} WorkingArea={X=1920,Y=-835,Width=1920,Height=1032} Primary=False DeviceName=\\.\DISPLAY6
[11:35:59.2287259] [Info] WindowUtilities::LaunchOCROverlayOnEveryScreen
    screen Screen[Bounds={X=3840,Y=-843,Width=3840,Height=2160} WorkingArea={X=3840,Y=-843,Width=3840,Height=2040} Primary=False DeviceName=\\.\DISPLAY5
[11:36:11.8672080] [Info] <RegionClickCanvas_MouseUp>d__25::MoveNext
    Getting clicked word, en-US
[11:36:14.3472605] [Info] WindowUtilities::LaunchOCROverlayOnEveryScreen
    Adding Overlays for each screen
[11:36:14.3474915] [Info] WindowUtilities::LaunchOCROverlayOnEveryScreen
    screen Screen[Bounds={X=0,Y=0,Width=1920,Height=1200} WorkingArea={X=0,Y=0,Width=1920,Height=1152} Primary=True DeviceName=\\.\DISPLAY1
[11:36:14.5429070] [Info] WindowUtilities::LaunchOCROverlayOnEveryScreen
    screen Screen[Bounds={X=1920,Y=-835,Width=1920,Height=1080} WorkingArea={X=1920,Y=-835,Width=1920,Height=1032} Primary=False DeviceName=\\.\DISPLAY6
[11:36:14.6374042] [Info] WindowUtilities::LaunchOCROverlayOnEveryScreen
    screen Screen[Bounds={X=3840,Y=-843,Width=3840,Height=2160} WorkingArea={X=3840,Y=-843,Width=3840,Height=2040} Primary=False DeviceName=\\.\DISPLAY5
[11:36:18.7407553] [Info] <RegionClickCanvas_MouseUp>d__25::MoveNext
    Standard region capture, en-US
[11:36:23.8198462] [Info] WindowUtilities::LaunchOCROverlayOnEveryScreen
    Adding Overlays for each screen
[11:36:23.8201868] [Info] WindowUtilities::LaunchOCROverlayOnEveryScreen
    screen Screen[Bounds={X=0,Y=0,Width=1920,Height=1200} WorkingArea={X=0,Y=0,Width=1920,Height=1152} Primary=True DeviceName=\\.\DISPLAY1
[11:36:24.0190042] [Info] WindowUtilities::LaunchOCROverlayOnEveryScreen
    screen Screen[Bounds={X=1920,Y=-835,Width=1920,Height=1080} WorkingArea={X=1920,Y=-835,Width=1920,Height=1032} Primary=False DeviceName=\\.\DISPLAY6
[11:36:24.0977970] [Info] WindowUtilities::LaunchOCROverlayOnEveryScreen
    screen Screen[Bounds={X=3840,Y=-843,Width=3840,Height=2160} WorkingArea={X=3840,Y=-843,Width=3840,Height=2040} Primary=False DeviceName=\\.\DISPLAY5
[11:36:35.2026430] [Info] WindowUtilities::LaunchOCROverlayOnEveryScreen
    Adding Overlays for each screen
[11:36:35.2030080] [Info] WindowUtilities::LaunchOCROverlayOnEveryScreen
    screen Screen[Bounds={X=0,Y=0,Width=1920,Height=1200} WorkingArea={X=0,Y=0,Width=1920,Height=1152} Primary=True DeviceName=\\.\DISPLAY1
[11:36:35.3974083] [Info] WindowUtilities::LaunchOCROverlayOnEveryScreen
    screen Screen[Bounds={X=1920,Y=15,Width=1920,Height=1080} WorkingArea={X=1920,Y=15,Width=1920,Height=1032} Primary=False DeviceName=\\.\DISPLAY6
[11:36:35.4789626] [Info] WindowUtilities::LaunchOCROverlayOnEveryScreen
    screen Screen[Bounds={X=3840,Y=7,Width=3840,Height=2160} WorkingArea={X=3840,Y=7,Width=3840,Height=2040} Primary=False DeviceName=\\.\DISPLAY5
[11:36:41.6752480] [Info] WindowUtilities::LaunchOCROverlayOnEveryScreen
    Adding Overlays for each screen
[11:36:41.6754293] [Info] WindowUtilities::LaunchOCROverlayOnEveryScreen
    screen Screen[Bounds={X=0,Y=0,Width=1920,Height=1200} WorkingArea={X=0,Y=0,Width=1920,Height=1152} Primary=True DeviceName=\\.\DISPLAY1
[11:36:41.8415841] [Info] WindowUtilities::LaunchOCROverlayOnEveryScreen
    screen Screen[Bounds={X=1920,Y=15,Width=1920,Height=1080} WorkingArea={X=1920,Y=15,Width=1920,Height=1032} Primary=False DeviceName=\\.\DISPLAY6
[11:36:41.9137651] [Info] WindowUtilities::LaunchOCROverlayOnEveryScreen
    screen Screen[Bounds={X=3840,Y=7,Width=3840,Height=2160} WorkingArea={X=3840,Y=7,Width=3840,Height=2040} Primary=False DeviceName=\\.\DISPLAY5
[11:36:46.6032574] [Info] WindowUtilities::LaunchOCROverlayOnEveryScreen
    Adding Overlays for each screen
[11:36:46.6034154] [Info] WindowUtilities::LaunchOCROverlayOnEveryScreen
    screen Screen[Bounds={X=0,Y=0,Width=1920,Height=1200} WorkingArea={X=0,Y=0,Width=1920,Height=1152} Primary=True DeviceName=\\.\DISPLAY1
[11:36:46.8110246] [Info] WindowUtilities::LaunchOCROverlayOnEveryScreen
    screen Screen[Bounds={X=1920,Y=15,Width=1920,Height=1080} WorkingArea={X=1920,Y=15,Width=1920,Height=1032} Primary=False DeviceName=\\.\DISPLAY6
[11:36:46.9005205] [Info] WindowUtilities::LaunchOCROverlayOnEveryScreen
    screen Screen[Bounds={X=3840,Y=7,Width=3840,Height=2160} WorkingArea={X=3840,Y=7,Width=3840,Height=2040} Primary=False DeviceName=\\.\DISPLAY5
[11:36:50.4351905] [Info] WindowUtilities::LaunchOCROverlayOnEveryScreen
    Adding Overlays for each screen
[11:36:50.4354760] [Info] WindowUtilities::LaunchOCROverlayOnEveryScreen
    screen Screen[Bounds={X=0,Y=0,Width=1920,Height=1200} WorkingArea={X=0,Y=0,Width=1920,Height=1152} Primary=True DeviceName=\\.\DISPLAY1
[11:36:50.6370473] [Info] WindowUtilities::LaunchOCROverlayOnEveryScreen
    screen Screen[Bounds={X=1920,Y=-460,Width=1920,Height=1080} WorkingArea={X=1920,Y=-460,Width=1920,Height=1032} Primary=False DeviceName=\\.\DISPLAY6
[11:36:50.7290825] [Info] WindowUtilities::LaunchOCROverlayOnEveryScreen
    screen Screen[Bounds={X=3840,Y=-468,Width=3840,Height=2160} WorkingArea={X=3840,Y=-468,Width=3840,Height=2040} Primary=False DeviceName=\\.\DISPLAY5
[11:38:31.2271017] [Info] WindowUtilities::LaunchOCROverlayOnEveryScreen
    Adding Overlays for each screen
[11:38:31.2273668] [Info] WindowUtilities::LaunchOCROverlayOnEveryScreen
    screen Screen[Bounds={X=0,Y=0,Width=1920,Height=1200} WorkingArea={X=0,Y=0,Width=1920,Height=1152} Primary=True DeviceName=\\.\DISPLAY1
[11:38:31.4265175] [Info] WindowUtilities::LaunchOCROverlayOnEveryScreen
    screen Screen[Bounds={X=1920,Y=-460,Width=1920,Height=1080} WorkingArea={X=1920,Y=-460,Width=1920,Height=1032} Primary=False DeviceName=\\.\DISPLAY6
[11:38:31.5232236] [Info] WindowUtilities::LaunchOCROverlayOnEveryScreen
    screen Screen[Bounds={X=3840,Y=-466,Width=1920,Height=1080} WorkingArea={X=3840,Y=-466,Width=1920,Height=1032} Primary=False DeviceName=\\.\DISPLAY5
[11:38:38.1308457] [Info] WindowUtilities::LaunchOCROverlayOnEveryScreen
    Adding Overlays for each screen
[11:38:38.1311477] [Info] WindowUtilities::LaunchOCROverlayOnEveryScreen
    screen Screen[Bounds={X=0,Y=0,Width=1920,Height=1200} WorkingArea={X=0,Y=0,Width=1920,Height=1152} Primary=True DeviceName=\\.\DISPLAY1
[11:38:38.3077260] [Info] WindowUtilities::LaunchOCROverlayOnEveryScreen
    screen Screen[Bounds={X=1920,Y=-677,Width=1920,Height=1080} WorkingArea={X=1920,Y=-677,Width=1920,Height=1032} Primary=False DeviceName=\\.\DISPLAY6
[11:38:38.3926136] [Info] WindowUtilities::LaunchOCROverlayOnEveryScreen
    screen Screen[Bounds={X=3840,Y=-683,Width=1920,Height=1080} WorkingArea={X=3840,Y=-683,Width=1920,Height=1032} Primary=False DeviceName=\\.\DISPLAY5
[11:39:32.8032678] [Info] WindowUtilities::LaunchOCROverlayOnEveryScreen
    Adding Overlays for each screen
[11:39:32.8035408] [Info] WindowUtilities::LaunchOCROverlayOnEveryScreen
    screen Screen[Bounds={X=0,Y=0,Width=1920,Height=1200} WorkingArea={X=0,Y=0,Width=1920,Height=1152} Primary=True DeviceName=\\.\DISPLAY1
[11:39:32.9762269] [Info] WindowUtilities::LaunchOCROverlayOnEveryScreen
    screen Screen[Bounds={X=-1920,Y=10,Width=1920,Height=1080} WorkingArea={X=-1920,Y=10,Width=1920,Height=1032} Primary=False DeviceName=\\.\DISPLAY6
[11:39:33.0670316] [Info] WindowUtilities::LaunchOCROverlayOnEveryScreen
    screen Screen[Bounds={X=1920,Y=10,Width=1920,Height=1080} WorkingArea={X=1920,Y=10,Width=1920,Height=1032} Primary=False DeviceName=\\.\DISPLAY5
[16:53:36.0766507] [Info] App::<Application_Startup>b__10_0
    PowerToys Runner exited. Exiting TextExtractor

Are these helpful?

@MuscularPuky , are you able to upload a /bugreport as well?

Hi there!We need a bit more information to really debug this issue. Can you add a "Report Bug" zip file here?  Then drag the zipfile from your desktop onto the GitHub comment box in this issue. Thanks!

sure.
PowerToysReport_2024-02-07-09-49-09.zip

@donlaci thank you for all this investigation work! I have been trying to figure out why this issue pops up sometimes and I feel validated that the issue is not an easy fix.

Do you know what win32 APIs are being by the WinForms Screens API?
Is the issue in WinForms or the win32 API?
How do other 'screen capture' apps for Windows do this work?

@TheJoeFin great questions :-)
I don't know the answers, but I'll investigate them.

After further investigation I found another proof that there is a Framwork bug.
The details:
In debug mode I've tried to bring the wrongly positioned overlay window to the right place. The overlay window's position was (4480, 0), corresponding to the left-top point of the 3rd monitor, which was correct but was displayed with an offset around 1000 pixels (appeared more to the right on the 3rd monitor). When I've tried to change the window's position to 4400, 4300, ... it came closer to its desired place. Modifying the coordinate to lower and lower values after a while the window jumped to its right position - in the middle of the 2nd monitor. After modifying back the coordinate to 4480 it finally jumped to the correct position (3rd monitor left-top point). When playing around with it the wrong offset was sometimes present (for higher coordinate-nubers), sometimes not (for lower numbers).
I still believe that TextExtractor sets the good coordinates and there is a bug in the framework.
@TheJoeFin while testing, I've reimplemented the scale handling part. It does not solve this issue (no wonder), but has some advantages, ok mainly in these errorous scenarios. The current implementation results to have a small overlay window on monitor 1 (see original picture above) which would be the overlay window for the 3rd monitor. (due the error the position is set to (0,0)). My implementation sets the right coordinates with right scaling (and size),  of course if the faulty offset is "present" the overlay window is "shifted" to the right. Are you interested in this modification?

@donlaci I am okay with any fix which improves this issue even a little.
I was looking into using a package which is built by the same person who built Greenshot. The package is open source and MIT license. This is another way of getting the screen details, but since I was never able to reproduce the bug, I could not see if this package fixes the issue.
https://github.com/dapplo/Dapplo.Windows/blob/master/src/Dapplo.Windows.User32/DisplayInfo.cs
Let me know if that gives any different behavior at all.

Hi @MuscularPuky
There is a solution candidate for the issue. I would like to ask you to test it, it is included in this PT release:
https://github.com/donlaci/PowerToys/releases/tag/v0.78.2Test
You will need to delete your PT version and install the test version.
Thank you!

Hi @MuscularPuky There is a solution candidate for the issue. I would like to ask you to test it, it is included in this PT release: https://github.com/donlaci/PowerToys/releases/tag/v0.78.2Test You will need to delete your PT version and install the test version. Thank you!

THX I'll try this tomorrow

I tested for 2 days and now Text Extractor works perfectly.


failed to get CA certs at https://server_add:6443/cacerts - When trying to add new k3s worker node

ERRO[2019-05-16T02:18:54.984314601Z] failed to get CA certs at https://<IP_ADDRESS>:6443/cacerts: Get https://<IP_ADDRESS>:6443/cacerts: dial tcp <IP_ADDRESS>:6443: connect: connection timed out

Closing as a resolved network configuration issue, from Rancher user slack:

It's working now. I was able to Join K3s ... I had deployed in OpenSTACK - Ubuntu Instance, I was trying to add through Public IP / hostname as server address. That was not working... Once I spin up instace on same private_subnet as master & use private IP as server address ... It's worked ...

Is there an official recommendation on how to deal with this issue?

I've had a similar problem when trying to set up a high availability control plane.
What I did wrong: I've used the --server and the --token parameter. (They are not needed at all for the masters connected via an external backing database like etcd.)
How I was able to solve my specific problem: Use the --bind-address parameter.


WorkspaceStat.TAGS asks for trouble

I am not sure who added this, but I see access to WorkspaceStat.TAGS from some places (e.g. experiments). I find this a very weird way of reaching into something that should be internal. E.g. can we not have the diagnostics service expose this information as a method and then consumers use that service into having a dependency to workspace stats?

Currently experiments service is depending on workspace stats and this dependency is very weird. Workspace stats is exposing a static constant which is used by experiments service.
For such usages we use services. So, please create a service for workspace stats and let experiment service depend on it.
It will also help in moving experiments service electron-browser namespace to browser namespace so that we can use it in web.

Looks like WorkspaceStats is being used at multiple places. May be its best to have a WorkspaceStatsService.
@RMacfarlane FYI


Remove role="main" from main element.

This was needed for Internet Explorer 11.

Putting this on hold until we have a consensus about IE support.

We need to come to a consensus about IE support. When this happens, we'll decide how we proceed.

I agree with @XhmikosR, we must be strict which will make it way easier for us to make decisions about things.

Closing since we are going to keep IE11 support in v5.


Build errors for different examples

Please take a look at https://travis-ci.org/Infineon/platformio-infineonxmc and fix examples.
Thanks!

Hi Ivan,
this is due to some bugs in the latest release of the XMC core, the current code in master worked fine in previous builds.
I'll update travis as soon as a new release is made!

Travis now passing

Please enable AppVeyor https://www.appveyor.com/ , we should also process tests on Windows
I added config a few days before.


Microsoft.NetworkCloud MGMT Plane Namespace Review

Thank you for submitting this review request. Thorough review of your client library ensures that your APIs are consistent with the guidelines and the consumers of your client library have a consistently good experience when using Azure.
The Architecture Board reviews Track 2 libraries only. If your library does not meet this requirement, please reach out to Architecture Board before creating the issue.
Please reference our review process guidelines to understand what is being asked for in the issue template.
To ensure consistency, all Tier-1 languages (C#, TypeScript, Java, Python) will generally be reviewed together.  In expansive libraries, we will pair dynamic languages (Python, TypeScript) together, and strongly typed languages (C#, Java) together in separate meetings.
@ronniegeraghty  @kyle-patterson - please review this and rename title API Review/API Sign Off to management and/or client libraries Introducing .NET Microsoft.NetworkCloud  approval
Before submitting, ensure you adjust the title of the issue appropriately.
Note that the required material must be included before a meeting can be scheduled.
Contacts and Timeline

Responsible service team: Bryan Strassner<EMAIL_ADDRESS>Marina Bashtovaya<EMAIL_ADDRESS>Jared Stein<EMAIL_ADDRESS>Main contacts: Vaishali Belsare<EMAIL_ADDRESS>Uma Devi Chedalla<EMAIL_ADDRESS>Expected code complete date:
Expected release date: 1/6/2023

About the Service

Link to documentation introducing/describing the service: AODS Solution-Document 2022-11-15.docx](https://microsoft.sharepoint.com/:w:/t/AFO-NC/EQqHS0BD3QdOlHsjz7rgvYMBEAqpQgZiAU3EJp1GZTSQ6w?e=Gd4esf)
Link to the service REST APIs: azure-rest-api-specs-pr/specification/networkcloud/resource-manager/Microsoft.NetworkCloud/preview/2022-09-30-preview at RPSaaSMaster · Azure/azure-rest-api-specs-pr (github.com)
Link to GitHub issue for previous review sessions, if applicable:  NA

About the client library

Name of the client library:  NA
Languages for this review:

management plane (ARM): Microsoft.Networkcloud.NET
Languages for this review: .NET
.NET

APIView Link: azure-rest-api-specs-pr/specification/networkcloud/resource-manager/Microsoft.NetworkCloud/preview/2022-09-30-preview at RPSaaSMaster · Azure/azure-rest-api-specs-pr (github.com)](https://github.com/Azure/azure-rest-api-specs-pr/tree/RPSaaSMaster/specification/networkcloud/resource-manager/Microsoft.NetworkCloud/preview/2022-09-30-preview
Link to Champion Scenarios/Quickstart samples:

•	Go/Golang
Resource Management - Confidentialledger
sdk/resourcemanager/networkcloud/armnetworkcloud
•	Python
Resource Management - Confidential Ledger
azure-mgmt-networkcloud
And these should follow the same:
•	.NET
Resource Management - Confidential Ledger
Azure.ResourceManager.NetworkCloud
•	Java
Resource Management - Confidential Ledger
azure-resourcemanager-networkcloud
•	JavaScript
Resource Management - Confidentialledger
@azure/arm-networkcloud
Thank you!

@ronniegeraghty  @kyle-patterson - please review this and rename title API Review/API Sign Off to management and/or client libraries Introducing .NET Microsoft.NetworkCloud  approval

@vabelsare before we can begin the namespace review, you need to add the proposed namespaces for each of the tier 1 programing languages the SDK team supports as well as Go. You can find examples of namespaces for each programming language at the bottom of this page.

@ronniegeraghty @kyle-patterson  - Updated the Go, Python, Java Script related namespaces entry above per request.

Updated the Microsoft.NetworkCloud MGMT Plane Namespace Review * Issue #5263 * Azure/azure-sdk (github.com)https://github.com/Azure/azure-sdk/issues/5263 with required updates.
Thank you,
Vaishali
From: Ronnie Geraghty @.>
Sent: Monday, December 19, 2022 1:17 PM
To: Azure/azure-sdk @.>
Cc: Vaishali Belsare @.>; Mention @.>
Subject: Re: [Azure/azure-sdk] Microsoft.NetworkCloud MGMT Plane Namespace Review (Issue #5263)
@vabelsarehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fvabelsare&data=05|01|vabelsare%40microsoft.com|c4f170b7d00849aa764408dae1f5949d|72f988bf86f141af91ab2d7cd011db47|1|0|638070742119944624|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=piUzQohSIVU7a2kTJUPoPY7ITjTMQsHnK8kDphn9%2B4M%3D&reserved=0 before we can begin the namespace review, you need to add the proposed namespaces for each of the tier 1 programing languages the SDK team supports as well as Go. You can find examples of namespaces for each programming language at the bottom of this pagehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdev.azure.com%2Fazure-sdk%2Finternal%2F_wiki%2Fwikis%2Finternal.wiki%2F821%2FNaming-for-new-initial-management-or-client-libraries-(new-SDKs)&data=05|01|vabelsare%40microsoft.com|c4f170b7d00849aa764408dae1f5949d|72f988bf86f141af91ab2d7cd011db47|1|0|638070742119944624|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=PydsMwqag31JkeqPIBxl%2BQIawtuYhqk9uYLCf5bcB1Y%3D&reserved=0.

Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2Fazure-sdk%2Fissues%2F5263%23issuecomment-1358140063&data=05|01|vabelsare%40microsoft.com|c4f170b7d00849aa764408dae1f5949d|72f988bf86f141af91ab2d7cd011db47|1|0|638070742119944624|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=rx2xZphryRs8c3gYgWrw8dqc2EORjRCJ3C333EGM6tw%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FA4VGNWBLHBMVUA7FMRS7MQLWOCYCDANCNFSM6AAAAAATADOWQA&data=05|01|vabelsare%40microsoft.com|c4f170b7d00849aa764408dae1f5949d|72f988bf86f141af91ab2d7cd011db47|1|0|638070742119944624|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=loWSVQeCNxSiIARzW%2F%2F5CCoenJitKKXa0LVJxzgefQM%3D&reserved=0.
You are receiving this because you were mentioned.Message ID<EMAIL_ADDRESS>

Starting offline review

Package name good for Python

Package name azure-resourcemanager-networkcloud is good for Java.

Good for .Net

@ronniegeraghty @kyle-patterson - Based on comments, am I to assume that only 2 approvals is now remaining - for Go and Javascript?

@vabelsare We are also still waiting on an approval from a .NET architect. I'll be sending out reminder messages to our architects today, to review this issue.

sdk/resourcemanager/networkcloud/armnetworkcloud is good for Go

@ronniegeraghty -I see Arthur approved for .Net. So Go, Java, ,Net, Python have approved. So now only JavaScript is remaining, right?

@ronniegeraghty @kyle-patterson  - Do we have ETA for these pending approvals? The way I understand, we cannot start till we get these approvals.

@ronniegeraghty Ronnie Geraghty FTE @kyle-patterson Kyle Patterson FTE - Do we have ETA for these pending approvals? The way I understand, we cannot start till we get these approvals.

Were just waiting on JS now. I'll remind them again today, to take a look here.

@azure/arm-networkcloud for JS looks good to me

Looks like all the languages have gotten approval.
@vabelsare your good to move forward.

Thank you so much!
From: Ronnie Geraghty @.>
Sent: Thursday, January 19, 2023 4:55 PM
To: Azure/azure-sdk @.>
Cc: Vaishali Belsare @.>; Mention @.>
Subject: Re: [Azure/azure-sdk] Microsoft.NetworkCloud MGMT Plane Namespace Review (Issue #5263)
Looks like all the languages have gotten approval.
@vabelsarehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fvabelsare&data=05|01|vabelsare%40microsoft.com|81fc48623c174bce1ff908dafa7040da|72f988bf86f141af91ab2d7cd011db47|1|0|638097657286754368|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=%2BMZv5LC0p1141oB1ED2bv0zE4OHfsJBLWNRDCT%2BW%2BLA%3D&reserved=0 your good to move forward.

Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2Fazure-sdk%2Fissues%2F5263%23issuecomment-1397716616&data=05|01|vabelsare%40microsoft.com|81fc48623c174bce1ff908dafa7040da|72f988bf86f141af91ab2d7cd011db47|1|0|638097657286754368|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=DdLhZKVvntJVEVVc4uirI6WWzL49Ti3oQKovQ3ajPow%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FA4VGNWFYUTDPF2AIH5QIR5LWTHA53ANCNFSM6AAAAAATADOWQA&data=05|01|vabelsare%40microsoft.com|81fc48623c174bce1ff908dafa7040da|72f988bf86f141af91ab2d7cd011db47|1|0|638097657286754368|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=nUWDr0cVLXwssDVm9MZnLPIwq0rLEjDoQM9YVhjbbN0%3D&reserved=0.
You are receiving this because you were mentioned.Message ID: @.***>


Add Package.swift for Swift 4.2

This allows Stencil to be compiled with Swift 4.2
We should wait for new releases including https://github.com/kylef/PathKit/pull/56 and https://github.com/kylef/Spectre/pull/37
Also once Swift 4.2 is officially released we can add a CI job for it.

It would be nice once this was merged if there was a new release with this for upstream libraries

Do we really need a separate package.swift for this? Can't we just add the supported versions to the existing one?

The format for supported versions changed from an array of integers to an array of a new set of enum values with the 4.2 compiler.

There's a possibility we could use a compiler version check in the Package.swift to set the right type, I can try that path if you'd like

I don't know if all that's necessary.
With the old format, we can only say [4] right? But can you confirm that, as it stands right now, Stencil doesn't work with Swift 4.2? Or is this just to have the nicer syntax with the enums?

Right now if a package depends on Stencil, it will build it with the 4.0 mode of the 4.2 compiler. By adding this file and these supported versions, it would build it with the 4.2 mode of the 4.2 compiler. Users can continue to use it in the 4.0 mode successfully, but at some point it makes sense to support 4.2 like this

Right, but we only just added 4.1 support, partially (see #226). I agree that, when we migrate to 4.2 (if there's anything to migrate), we should update our podspec and Package.swift to reflect this.
For now, I think this is too early.

Whoa, I wouldn't close it, let's keep it for when we're ready. I'm pretty sure that once we figure #226 out, we can do the 4.2 migration.
(I can't seem to reopen this)

Ah, I thought you meant longer term. I deleted my fork which is why you can't reopen

Going through #226 again, I'm pretty sure that full Swift 4.1 migration is going to take a while...
Well when we do the migration we'll base the package.swift on this one.


Update PDB links

Updates two old links to correct ones.

Thanks for catching that - careless searching by me.


I've been running Win-Acme on this web server for 2+ years and suddenly none of my domains validate

I've had Win-Acme configured on our web servers for 2+ years and suddenly none of my sites pass validation. I have this across 30+ sites on 3 different web servers and suddenly none of them are working.
Here is a sample of the error output:
[marquisassetmgmt.com] Authorization result: invalid
[marquisassetmgmt.com] {"type":"urn:ietf:params:acme:error:connection","detail"
:"During secondary validation: <IP_ADDRESS>: Fetching http://marquisassetmgmt
.com/.well-known/acme-challenge/59_zA7hmNvZzMn0xILZEFWncuZikZ1P1dkBbzF0_xHU: Tim
eout during connect (likely firewall problem)","status":400,"instance":null}
There have been no configuration changes and no network changes. Any help would be appreciated.

It may help to also know that we've always used the default settings and never changed anything in the settings.json file

Please disregard


all: fix misspelled comments

PR Checklist
PR Structure

[X] This PR has reasonably narrow scope (if not, break it down into smaller PRs).
[X] This PR avoids mixing refactoring changes with feature changes (split into two PRs
otherwise).
[X] This PR's title starts with name of package that is most changed in the PR, ex.
services/friendbot, or all or doc if the changes are broad or impact many
packages.

Thoroughness

[ ] This PR adds tests for the most critical parts of the new functionality or fixes.
[ ] I've updated any docs (developer docs, .md
files, etc... affected by this change). Take a look in the docs folder for a given service,
like this one.

Release planning

[ ] I've updated the relevant CHANGELOG (here for Horizon) if
needed with deprecations, added features, breaking changes, and DB schema changes.
[ ] I've decided if this PR requires a new major/minor version according to
semver, or if it's mainly a patch change. The PR is targeted at the next
release branch if it's not a patch change.

What
This PR fix misspelling in the source code.
Why
Misspelling in the source code aren't perceived as a production grade, professional code.
Known limitations
N/A

@tsachiherman now that misspellings are clean, would you consider adding a mispell  check to CI?

@tsachiherman now that misspellings are clean, would you consider adding a mispell  check to CI?

It's already enabled; however, it would add a comment to the PR only if you added a misspleed text in the PR.
if you want to run all the enabled linters against the codebase, you can run:
? golangci-lint run


Don't send real emails on -dev/stage other than user confirmation

Fixes bug 1237899
This makes sure that no email is ever sent for real on -dev/stage/local, other
than the two emails that require user confirmation:

registering
changing email address

r+


[Xcode] adds script for updating Settings bundle

Task/Issue URL: #497
Description:
This adds:

a config file that defines MARKETING_VERSION–Version.xcconfig;
a settings bundle–Settings.bundle;
a script file–set_version.sh.

The script file pulls MARKETING_VERSION from the config file, and writes it to the settings bundle.
Steps to test this PR:

Run chmod +x set_version.sh to ensure it is executable;
Run set_version.sh 7.33.1

Known Issues:
This script should be run prior to build the app for a release, and the resulting changes committed.

Internal references:
Software Engineering Expectations
Technical Design Template

Run the script, passing in the version; e.g.,: ./set_verion 7.33.1.

@bwaresiak should be ready for another review; I squashed all script-related changes into a single commit.
Also,  I rebased develop (10e736e) on my branch, so I needed to set the current version to 7.33.1, but also adjust the four target's "Build Settings" so that they aren't overriding the value for MARKETING_VERSION. Please double that's having the correct effect for your own builds.

@KevinVitale great, neat and tidy. :) Bumping version number is much easier now. Thanks for doing that.
I've tested it and it works for me. I've also made sure that app passes AppStore validation. 👍
There are two things I'm thinking about:

I wonder if there is a good (simple, not hacky) way of embedding build number in the settings, so the version has it appended at the end: <IP_ADDRESS>. For me this is optional tho.
We need to remember to not change version number from Xcode just use the script (as Xcode will create MARKETING_VERSION within project file and override config file). Should not be a problem.

@brindy Since this will become part of our release process, do you have any comments?

I haven't ran this myself yet, but off the top of my head:

I don't think we need this really.  That extra version number is fairly meaningless the way we do releases.  If we had an encoded date there or something it would be more useful (e.g. 20191129)

If this script is part of our release process then it would be good if it failed noisily if someone has changed that by accident and then maybe can be run as part of our CI too?

Otherwise, looking forward to to this change. It will definitely save time! :)

Let's ignore the timestamp/build number thing and rather focus on making this foolproof and failing in case:

Someone changes the version manually.
Xcode somehow adds MARKETING_VERSION back to project file.

@KevinVitale My first idea is to simply add script before the build phase, that greps project file during build time and fails in case marketing version is present there:
if grep -q MARKETING_VERSION DuckDuckGo.xcodeproj/project.pbxproj
then
    echo "Error: 'MARKETING_VERSION' is present in project file."
    exit 1
fi

Other idea is to compare MARKETING_VERSION value with what we have in the settings plist file to make sure these two match (in case project file overrides our value) - maybe we should actually do both? 🤔
I'm open for other (better 😄 ) solutions if anything comes to your mind.

@bwaresiak comparing the project file's override to what's in the settings plist feels brittle to me, and would be error prone once an additional "build tag" (some computed value, such as an encoded date or the git short commit hash) gets included.
So, acknowledging that Version.xcconfig is the source of truth: I think your pre-build script step is the simplest approach. I would expect a step needs to be included on the four existing targets, and any new targets where MARKETING_VERSION is a valid value, correct?
I'll give this a go in bit.

Pre-build script won't work; looks like we've got an old-fashioned recursion problem 😅
grep MARKETING_VERSION DuckDuckGo.xcodeproj/project.pbxproj
			shellScript = "if grep MARKETING_VERSION DuckDuckGo.xcodeproj/project.pbxproj \nthen\n    echo \"Error: 'MARKETING_VERSION' is present in project file.\"\n    exit 1\nfi\n";

@bwaresiak / @brindy: Added check_version.sh, with accompanying Run Script Phases for each relevant target. 🤞 .


Measurement gate

A measurement gate would be useful, even if it is exactly equivalent to a controlled-not onto an otherwise unused qubit.

Done in dev. It's even simpler than cnot-onto-hidden-qubit: it just blocks future operations on the bit (except for classical-safe ones).


silence clang 3.9 -Wundefined-var-template

/Users/travis/build/BioDynaMo/biodynamo/build/Vc/src/Vc/scalar/../common/../sse/const_data.h:69:103: warning: instantiation of variable 'Vc_1::SSE::c_log<float>::data' required here, but no definition is available [-Wundefined-var-template]
    static Vc_ALWAYS_INLINE Vc_CONST const float *d(int i) { return reinterpret_cast<const  float *>(&data[i * Size]); }
                                                                                ^
/Users/travis/build/BioDynaMo/biodynamo/build/Vc/src/Vc/scalar/../common/../sse/vectorhelper.h:260:126: note: in instantiation of member function 'Vc_1::SSE::c_log<float>::d' requested here
                return _mm_castsi128_ps(_mm_cmpeq_epi32(_mm_castps_si128(abs(x)), _mm_castps_si128(_mm_load_ps(c_log<float>::d(1)))));
                                                                                ^
/Users/travis/build/BioDynaMo/biodynamo/build/Vc/src/Vc/scalar/../common/../sse/const_data.h:70:43: note: forward declaration of template entity is here
    alignas(64) static const unsigned int data[];
                                          ^
/Users/travis/build/BioDynaMo/biodynamo/build/Vc/src/Vc/scalar/../common/../sse/const_data.h:69:103: note: add an explicit instantiation declaration to suppress this warning if 'Vc_1::SSE::c_log<float>::data' is explicitly instantiated in another translation unit
    static Vc_ALWAYS_INLINE Vc_CONST const float *d(int i) { return reinterpret_cast<const  float *>(&data[i * Size]); }

seems to be resolved (no warnings coming from travis anymore)


Pipeline should use submodules to lock to a version

The bc-wallet pipeline checks out the hyperledger repo. It would be better to use a submodule so we can be locked to a specific commit in the repo and always be sure our build will work.

Will need to get the SSH deployment keys working so we can keep using that method. Using HTTPs is tough on developers because of the way it authenticates.


Add rhel-8 packages

Description
This adds support for rhel-8
Issues Resolved
[List any existing issues this PR resolves]
Check List

[ ] All tests pass. See https://github.com/sous-chefs/apache2/blob/master/TESTING.md
[ ] New functionality includes testing.
[ ] New functionality has been documented in the README if applicable

          2 Errors

:no_entry_sign:
Please add labels to this Pull Request

:no_entry_sign:
Please include a CHANGELOG entry.

  Generated by :no_entry_sign: Danger

Agreed it's a bit of a mess right no. Ignore MR @kitchen-porter
It's due to all the test failing and it being pretty hard to test this cookbook on Virtual infrastructure.

Can you check this runs and works locally as expected, and post the results here please?
Thanks!

Oh and you have some linting problems. Click on the Details for the lint step to get the linting errors from CircleCI 👍

The linting warnings seem the be unrelated rspec problems.
I have validated that the cookbook works on rhel-8 with these changes:
       Recipe: selinux::default
         * selinux_install[selinux os prep] action install
           * dnf_package[policycoreutils, selinux-policy, selinux-policy-targeted, libselinux-utils, mcstrans] action install (up to date)
           * directory[/etc/selinux] action create (up to date)
            (up to date)
         * selinux_state[SELinux Enforcing] action enforcing
           * execute[selinux-enforcing] action run (skipped due to not_if)
           * template[enforcing selinux config] action create (up to date)
            (up to date)
       Recipe: selinux_policy::install
         * selinux_policy_install[install] action install
           * dnf_package[policycoreutils-python-utils, selinux-policy-devel, setools-console, make] action install
             - install version 0:3.14.1-46.el8.noarch of package selinux-policy-devel
             - install version 0:4.1.1-11.el8.x86_64 of package setools-console
             - install version 1:4.2.1-9.el8.x86_64 of package make

Hey, this has been release to the supermarket as 2.2.0


Feat/lesq 1046/threads styling wrap up

Description
Music year: 2011

Replace radio tile component with oakRadioTile from components library

How to test

Go to https://deploy-preview-2795--oak-web-application.netlify.thenational.academy/teachers/programmes/english-primary-ks1/units
Click on thread filters on the right
You should see the list of units updating on selection
Navigating with a keyboard should apply filters as they are moved through, without reloading the page
Look and behaviour should match production

thanks @mikeritson-oak I'll open a separate ticket for that issue as it will be a fix in the components library. Also apologies but there have been a lot of new changes merged into this since I've been off so re-requesting a review, lmk if you'd rather I pass it to another QA (not sure who is on teacher squad duties this sprint!)

:tada: This PR is included in version 1.578.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Fixes CurlHook to return integer HTTP status codes

Context
As discussed in #136, the Braintree SDK uses strict comparison (===) against the HTTP status code obtained via cURL. This test currently fails when using PHP VCR canned responses, because PHP VCR stores and returns the HTTP status code as a string.
What has been done

Adjusted CurlHook to cast HTTP status codes to int before returning them. This matches PHP curl's behaviour, which seems to always returns an int for CURLINFO_HTTP_CODE.
Considered but ultimately decided not to change VCR\Response to return status codes as integers: although this fixed the problem, it felt like changing the type of data that is returned from a public method could break other people's code.

How to test

Run the new unit test CurlHookTest::testShouldReturnCurlInfoStatusCodeAsInteger
Run the new version of PHP VCR code with Braintree SDK and observe that Braintree no longer throws a status code exception.

What needs to be done

75ed534 should be reverted if this PR is merged.

It looks like the build was failing because the WSDL file used in tests is no longer available:
http://wsf.cdyne.com/WeatherWS/Weather.asmx?WSDL
I've fixed this as well by using the Internet Archive's most recent working URL:
https://web.archive.org/web/20161213164919/http://wsf.cdyne.com/WeatherWS/Weather.asmx?WSDL

It seems that using Internet Archive's mirror wasn't reliable, so I've brought the WSDL into the Git repo. It can now be served by Github to the CI environment:
https://raw.githubusercontent.com/louismrose/php-vcr/issue136-integer-status-codes-for-braintree/tests/fixtures/weather.wsdl
Note that 75ed534 should be reverted if this PR is merged.
https://raw.githubusercontent.com/php-vcr/php-vcr/master/tests/fixtures/weather.wsdl

Hi there, @adri @castarco. Is there anything I could do to help along a review of this PR?
I believe that it fixes a bug (which prevents PHP-VCR from being used with Braintree #136), and also has fixed an issue with builds on the CI server (which might be causing other PRs to fail the build).

Hello @louismrose
Thanks for the effort on it and sorry for the delay!
I'm afraid to know what happens when someone had a strict comparison using the strings in their code, this means we might be breaking BC, what do you think about it?
I'll also check with adri what he thinks about it!

Thanks for the feedback @renatomefi! You make a good point about the potential for breaking BC with strict comparisons.
I wonder how often this might arise though, because curl_getinfo(..., CURLINFO_HTTP_CODE) returns an integer. So perhaps it would be unusual for a strict comparison against a string returned from PHP VCR, because that code would break when PHP VCR was turned off and PHP's normal curl functions were active?

@louismrose sure, for the normal user it shouldn't be a problem, I was afraid of user with custom matchers or wrappers, but it should be a really small number.
Thanks for fixing the tests, do you mind splitting it in another PR? Only if it's not too much work for you, the reason being is if we have an issue with any of them reverting is easier, and I can also in the other PR see where I can host the wsdl!

@louismrose we've fixed the tests in master, could you please rebase your PR?
I'm considering putting this feature on 1.4.0

@louismrose I've cherry-picked your fix and put it on #220
Thanks so much for your contribution!


Blanket GNOME app

Project description

Blanket is a new desktop app for Linux designed solely for the purpose of playing background noises like nature sounds (e.g., rain, storm), indistinct ambient noise (e.g., coffee shop), as well as white noise and pink noise. Nothing more, nothing less.

https://www.reddit.com/r/gnome/comments/jn7ldo/cool_gnomeish_app_i_found_on_flathub_blanket/

Metadata

homepage URL: https://github.com/rafaelmardojai/blanket/
source URL: https://github.com/rafaelmardojai/blanket/
license: gpl3
platforms: linux

FTR: This requires an update of libhandy.


PR for updating networks.py

update networks.py like this, the train.py can run successfully.
Otherwise, it will meet the problem:
RuntimeError: mat1 dim1 must match mat2 dim0.

您好，您的邮件已收到，我会尽快处理！


CPU_TIME reduction

Currently the time reduction uses MPI_Allreduce simply because some reduction routines already existed in mpi_routines.h
This performs an extra unnecessary step of sending the result back out to all procs, but I believe only proc 0 needs the reduced data. MPI_Reduce should suffice.

With some refactoring this could also be an asynchronous call, no need for the result until the next time that timer is called.

FYI, the average reduction OneTime::End actually does need to be an allreduce since it's used to check if that rank is particularly slow.


update check problem

Codecov Report

Merging #277 into master will decrease coverage by 0.02%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##             master     #277      +/-   ##
============================================
- Coverage     25.05%   25.03%   -0.03%
  Complexity      335      335
============================================
  Files           127      127
  Lines          4270     4274       +4
  Branches        313      313
============================================
  Hits           1070     1070
- Misses         3121     3125       +4
  Partials         79       79

Impacted Files
Coverage Δ
Complexity Δ

.../com/webank/wecross/routine/htlc/HTLCResource.java
53.38% <0.00%> (-1.66%)
19.00 <0.00> (ø)


[GameType] Spatial Fear release 1.2

The list of Packaged Files does not include the 14 maps which are the core of this mod - these maps have the suffix .sfp which possibly is the reason they have not been parsed.
I thought it was odd that there were no maps in the list so downloaded the zip and, sure enough, they are included in the zip.

URL: https://unrealarchive.org/gametypes/unreal-tournament/S/spatial-fear/12/index.html
Hash: None
Current name: Spatial Fear

Why do people make it hard.
Damn we thought we were cool back in the day, with our custom map extensions and custom launchers and custom EXEs that break as soon as UT gets patched... :sweat_smile:

Indexed them


Hello! Update dev dep - node-css-mqpacker

Hey! Could you please update dev dep - node-css-mqpacker  because with new webpack 5 it writes a warning:
(node:7231) [DEP_WEBPACK_COMPILATION_OPTIMIZE_CHUNK_ASSETS] DeprecationWarning: optimizeChunkAssets is deprecated (use Compilation.hooks.processAssets instead and use one of Compilation.PROCESS_ASSETS_STAGE_* as stage option)
(Use node --trace-deprecation ... to show where the warning was created)

Deprecation warning sending it's from last-call-webpack-plugin
I hope a PR with fix will be merged https://github.com/NMFR/last-call-webpack-plugin/pull/9

Fixed
npm i<EMAIL_ADDRESS>-D


feat: implement get events

🤖 Linear
Closes GRT-143
Description

Implementation of getEvents—still have to fix type issue

@jahabeebs there might be something wrong with some cached files on the GH actions env? Merge dev into this branch and let's see if it fixes the issue, I'm seeing some error messages as if tsc was trying to check this branch types against dev last merged types.


Up for adoption?

When an original owner no longer has time to maintain the addon, there is a place where the addon can be "put up for adoption." Melanie Sumner has created adopted-ember-addons.
@aexmachina - would you consider allowing us to adopt this addon so that it may continue to provide useful service to the community?

@aexmachina I am able to help with the transfer as well as @knownasilya

@simonexmachina checking in on this. Can you get in contact with @Alonski and arrange the transfer of ownership?

I thought I'd already done this, my apologies. @Alonski I'll add you as a collaborator, and I'll complete the transfer once it's ready. Thanks for your help! :)

Thanks @simonexmachina.
Are you planning on finishing the transfers?
BTW thanks for all the great work you've done!

As I understand, there are some steps that need to be done to the code
first to get it ready. See the adopted add-ons repo above for more
information

@simonexmachina Yes :) My question is are you planning to do the necessary changes or should I? I'd love of you had the time to do it as I'm currently a bit busy with finals 😅

I thought you were offering. I'm not able to do it until next week at the earliest. I'm not even using Ember any more, but I'll try to hand it over to the community. If you find the time please go ahead, but otherwise I'll do it.

I'll see what I can do. One of us will find the time 😁
BTW I don't think I have admin status so I can only do so much

@simonexmachina Is this repo ready to transfer ownership?

Yes it is, just waiting on @MelSumner to perform the steps from her end.


Fix the bug that HDFS iterator doesn't work

Fix the bug that HDFS iterator doesn't work

alluxio-bot, merge this please.


GPX: fix timestamp representation

Peter I think that in GPX the timestamps should be in UTC with ISO 8601 representation and end with the 'Z' suffix.
http://www.topografix.com/gpx_manual.asp#time
And to conform with spec, probably it's not necessary to provide the timezone as parameter to the createGPX method.

Thanks, this would be really a nice cleanup :) ! Did you try some of the common GPX programs if they are okay with this? (basecamp, some online tools, josm, osm.org?)

Most readers (online, apps) are versatile enough to parse more than one timestamp patterns.
And I have found gpx files that don't follow the standard.
But going the other way, wherever I checked for official produced gpx files, I saw them following the spec.
(please inform us if someone has additional info)

When we use 'Z' shouldn't we force +0? I.e.:
SimpleDateFormat formatter = new SimpleDateFormat("yyyy-MM-dd'T'HH:mm:ssZ");
formatter.setTimeZone(TimeZone.getTimeZone("UTC"));
System.out.println(formatter.format(new Date()));

Otherwise I'll get incorrect time when using default time zone here in Germany.

What do you mean, don't you get with the above code the UTC time ?

It will correctly use the local or specified time but ignores the offset as we always write 'Z'. I think you can easily try on your own. It should give you different times (except you are in london :)) but it will give you identical times

Right not it gave me 2015-03-23T21:15:00Z

That's the correct UTC time, what do you get?
(or I'm missing something here)

Strange, that you get it correctly. I get 2015-03-23T22:18:42Z
Also it makes sense to force UTC and avoid the default or a specific time zone when we always use +0

The UTC timezone is needed or else as you said we'll get our current time.
I don't remember Java to have changes in that part (I'm in Linux with 7).

Okay, but then this old code is wrong with your change:
TimeZone tz = TimeZone.getDefault();
if (!Helper.isEmpty(timeZoneId))
   tz = TimeZone.getTimeZone(timeZoneId);

and we should always use UTC and remove the timeZone parameter, right?

Yes you are corrent, to be with the spec we shouldn't provide the user any timezone option, but use internally only UTC.

Peter I pushed a new commit removing the timezone parameter and making the UTC default.
Also I think that in case of not provided startTimeMillis, the current date should be used and not the 0.

Thanks & yes, you are right regarding the startTimeMillis

I pushed another commit regarding startTimeMillis.

Thanks!


Implement Executive ports/edges in node graph

There's no easy way to visually alter a port other than its color, so all I've done is set the executive port color to pure white.


calculating "MultipartBodyLengthLimit" quota in byte

hello there, in upload document Multipart Body Length Limit is set to 268435456 byte (which is 2 raised to power of 28) and added a snippet and comment which I am quoted in bellow:

Set the limit to 256 MB
services.AddRazorPages(options => { options.Conventions .AddPageApplicationModelConvention("/FileUploadPage", model.Filters.Add( new RequestFormLimitsAttribute() { // Set the limit to 256 MB MultipartBodyLengthLimit = 268435456 }); });

, my question is when we want 256 MB body length limit, shouldn't value set to 256_000_000 byte instead?
or is there any hidden calculation which I am unaware of it?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 9a5cfa38-0e6c-4346-dafc-84ea5c513fcf
Version Independent ID: c6787f0f-3e9a-6efb-0e6e-5ccb957d3f4a
Content: Upload files in ASP.NET Core
Content Source: aspnetcore/mvc/models/file-uploads.md
Product: aspnet-core
Technology: aspnetcore-mvc
GitHub Login: @Rick-Anderson
Microsoft Alias: riande

We don't use the IEC naming under IEEE 1541 ("MiB"), but we do use the calculation based on powers of two. You'll find this convention throughout the framework and the documentation.

Thank you for your response


Dropship package configuration issues

Hello there,
I am using bagisto v1.1.2.  Here are some of the issues that have.
1st Issue: In the dropship configuration page under "Product Price" accordion, the input fields "Custom Price," "Increase (%)," and "Decrease (%) " are all inactive. I had the same Issue with the laravel-6-compatible version. That is the main reason why I move to bagisto version 1.1.2.
2nd Issue: the dropship icon doesn't appear in the fare left navbar.
3rd Issue: the package is still using the fire() method of Laravel Event class, causing an error when trying to fetch product information using the chrome extension. fire() should be replaced with dispatch() on the "Order Repository" and the "Product Repository." I did that on my end, and it fixed the error. However, the chrome extension is not able to pull most products' (99.99%) data from AliExpress. I got the following error message: "Warning: there is some error to fetch product data, please try it again". The only product for which I was able to fetch the data could not be imported into my website. I got the following error message: "Warning: product could not be imported successfully and next process like variations and reviews could not be imported, please try it again." Note that I downloaded the chrome extension from your Github because the one on google extensions store is not working at all.
Please let me know when you fix these issues

Hi @WendK
You may raise this bug in this repo https://github.com/bagisto/laravel-aliexpress-dropship


[MINOR][DOCS] Fix the example value in the docs

What changes were proposed in this pull request?

fix the example value
Why are the changes needed?

for doc
Does this PR introduce any user-facing change?

Yes
How was this patch tested?

Just example value in the docs, no need to test.
Was this patch authored or co-authored using generative AI tooling?

No

Thank you all, merged to master/3.5/3.4/3.3


[WebAPI] Remove unused WebGL test cases

BUG=https://crosswalk-project.org/jira/browse/CTS-1551

sync with @BruceDai  and @haoxli , we remove unreferenced files to enable all webgel test cases run smoothly on WTS.
@zqzhang ptal, thanks a lot~

Per offline talk to @renchenglei , in future if Khronos runs these tests in its testing, we will add them back. At current being, let's remove these test files to get consistent test results between regular packaged test suite and web testing service. Thanks.


The whole note viewed as an answer

Could you make it possible to make the whole note be viewed as an answer? Or, if not, to be able to open the note associated with the flashcard without aborting the review session?

You mean open the entire note as another modal/pop-up above the flashcard session?

You mean open the entire note as another modal/pop-up above the flashcard review session? It's not clear.

I mean to make it possible to view the entire note directly in the flashcard window, within its borders. In other words, entire note serves as an answer in the answer field after you hit 'show answer' button. With a possibility to scroll long notes down (I have already requested this feature).
And the 'question' could be some line from this note (marked specifically). Thus it would be possible to not create separate notes for reviewing/learning, but to use existing  notes, rich in text and all other things.
I have made a fake-shot for better understanding. You can see a flashcard window and - inside it - my entire note, as if shown after I have hit 'show answer'. You can also see a scroll bar. Many of my notes are pretty long so it is crucial for me to be able to scroll them down.
Another great bonus of this whole thing  - is that the review session will not be aborted. Because now, when I need some more information on my question and hit 'Open file', the review session is aborted.

Hello,
I think the reviewing-entire-notes workflow is more suitable for this (described here).
Apart from that, we can have the Open File link open the file inside the modal as you have demonstrated above. But the problem is, the Obsidian API doesn't let you render the markdown properly (documented in issue #25): we'll end up losing most of the rich text features like images and links. I'll look into other solutions.

It's much easier to save the state of the session. The only problem is that the user might go as far as deleting flashcards text which would lead to file corruption when they try to continue the session.
On the other hand, I find that most people will want to use the Open File option to edit their files. Which again, might lead to file corruption if we don't scan for the flashcards afresh.
There's no easy way out either way.


Social.following api shows the deleted site in the following list of sites

What type of issue is this?
Question
What SharePoint development model, framework, SDK or API is this about?
SharePoint REST API
Target SharePoint environment
SharePoint Online
What browser(s) / client(s) have you tested

[ ] 💥 Internet Explorer
[X] 💥 Microsoft Edge
[X] 💥 Google Chrome
[ ] 💥 FireFox
[ ] 💥 Safari
[ ] mobile (iOS/iPadOS)
[ ] mobile (Android)
[ ] not applicable
[ ] other (enter in the "Additional environment details" area below)

Additional environment details

browser version
SPFx version
Node.js version
etc

Issue description
We have the deleted sites still appearing in the social.following/my/followed api results. How many days it would take for the deleted sites to disappear from the following list of sites?

It can take a couple of days (sometimes weeks, I've seen) for the deleted sites to be removed from there. This is the same experience you get from SharePoint Home.
How long has it been for you?

It has been more than 3 weeks now. But it is still appearing in the following list.


chore(nargo): Use Display impl for InputValue

Description
Creates a wrapper around InputValue in order to enable using an AbiType with a Display impl.
Problem*
Resolves #1988
Summary*
Decoding a list of field elements to an InputValue and then converting it into a JsonType requires an AbiType. I made a wrapper around InputValue purely to impl the Display trait. This wrapper will contains the InputValue to display and the AbiType. The wrapper's Display implementation will then does the conversion into JsonTypes inside the noirc_abi crate so that we don't expose format types outside of the Abi crate.
Documentation

[] This PR requires documentation updates when merged.

[] I will submit a noir-lang/docs PR.

[ ] I will request for and support Dev Rel's help in documenting this PR.

Additional Context

PR Checklist*

[X] I have tested the changes locally.
[X] I have formatted the changes with Prettier and/or cargo fmt on default settings.

@TomAFrench Is this along the lines what you were thinking?


[Packager] can't reconnect to chrome after being closed.

If the packager is closed and re-opened, and a debugging tab in chrome still exists, the packager has issues connecting to the tab.
When "Launching Dev Tools..." in the packager, Chrome switches to the correct tab, but the page does not refresh. This give the error (in the simulator):
Runtime is not ready. Make sure Chrome is running and not paused on a breakpoint or exception and try reloading again.

Additionally, the chrome tab shows:
Status: Disconnected from proxy. Is node server running?

Currently, my solution is to remember to close the debugging tab and then refresh iOS. This needs to be done every time the packager needs to be re-opened.

I've found that reloading the web page works.

@uber5001 - does @jtremback's solution work for you?

Yup. Both refreshing and closing it work.

@amasad - is this something that can be easily fixed?

Should be fairly easy to fix, see debugger.html, just need to add some code that tries to reconnect. Anyone fancy a PR?

Should be fairly easy to fix, see debugger.html, just need to add some code that tries to reconnect. Anyone fancy a PR?

Added reconnection in #1992. This was a fun one because the platform impl for WebSocket (e.g. WebSocket.ios.js) and setTimeout would override the browser impl and would stop working when the packager went down. I had to alias them on startup so I could reference them later to reconnect.

@brentvatne seems like this was fixed and imported.


Make error_class work on inner wrapper

Fix for https://github.com/heartcombo/simple_form/issues/1727

@carlosantoniodasilva If you have some time to look at this, it would be greatly appreciated!

@rafaelfranca If you have some time to look at this, it would be greatly appreciated!

@lafeber I did get your initial ping and should've commented back that'd get to it here, that was my bad, but please be a little patient. :) Thanks!

@carlosantoniodasilva I'm truly sorry, I didn't mean to be impatient. I appreciate all the work you put in this gem - it's one of my all time favourites.

This change solves some issues I was having as well, would be great if it was merged in!

@rafaelfranca @lafeber I updated this PR with a fix to how we check for input's errors. Previously it wasn't properly checking it so my newly added spec was failing. I fixed that. @rafaelfranca @carlosantoniodasilva if PR looks good to you I'll merge it and will update Changelog/README afterward.


Expanded monitoring of user interactions with proxied applications

What should we add or change to make your life better?
I'd like a feature/documentation on monitoring the timing of user activity to proxied applications, including http requests and websocket messages.  Minimally I'd like to know how long it has been since any user was active on a site behind the proxy.  For this I need a way to know the DateTime of (or TimeSpan since) the most recent request and/or websocket message (excluding ping/pong).  Ideally this would take the form of a callback that I can handle to record the most recent time of activity, but I'd be ok if there is something I can poll too.  I tried to find something of this nature in the telemetry API documents but it's a difficult read, not already knowing telemetry more generally.
On a barely related note, is there a reason that RouteConfig and ClusterConfig metadata should be readonly?  It seems like a reasonable place to keep arbitrary state info related to the route or cluster, like a most recent activity timestamp, but we can't add or update anything after initialization.  Assuming there is a good reason, maybe add a separate read/write collection that can be used to track evolving state information? Allowing values beyond string (e.g. object) would be nice to enable more flexibility too.
Why is this important to you?
My proxy application needs to know idle time of each application behind the proxy. We proxy for containerized applications and after a period of no utilization for a defined TimeSpan (typically this means overnight after late users are finished) we want to terminate containers and remove the corresponding YARP routes. This can make a LARGE difference in the cost of maintaining warm containers.

Check out keda.sh it sounds like what you need with scale to zero
Get Outlook for Androidhttps://aka.ms/AAb9ysg

From: tom-puckett @.>
Sent: Thursday, June 9, 2022 8:51:06 PM
To: microsoft/reverse-proxy @.>
Cc: Subscribed @.***>
Subject: [microsoft/reverse-proxy] Expanded monitoring of user interactions with proxied applications (Issue #1758)
What should we add or change to make your life better?
I'd like a feature/documentation on monitoring the timing of user activity to proxied applications, including http requests and websocket messages. Minimally I'd like to know how long it has been since any user was active on a site behind the proxy. For this I need a way to know the DateTime of (or TimeSpan since) the most recent request and/or websocket message (excluding ping/pong). Ideally this would take the form of a callback that I can handle to record the most recent time of activity, but I'd be ok if there is something I can poll too. I tried to find something of this nature in the telemetry API documents but it's a difficult read, not already knowing telemetry more generally.
On a barely related note, is there a reason that RouteConfig and ClusterConfig metadata should be readonly? It seems like a reasonable place to keep arbitrary state info related to the route or cluster, like a most recent activity timestamp, but we can't add or update anything after initialization. Assuming there is a good reason, maybe add a separate read/write collection that can be used to track evolving state information? Allowing values beyond string (e.g. object) would be nice to enable more flexibility too.
Why is this important to you?
My proxy application needs to know idle time of each application behind the proxy. We proxy for containerized applications and after a period of no utilization for a defined TimeSpan (typically this means overnight after late users are finished) we want to terminate containers and remove the corresponding YARP routes. This can make a LARGE difference in the cost of maintaining warm containers.
—
Reply to this email directly, view it on GitHubhttps://github.com/microsoft/reverse-proxy/issues/1758, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AA56HTOZ33AFJSXMHRPT76LVOJDKVANCNFSM5YLGRV4Q.
You are receiving this because you are subscribed to this thread.Message ID: @.***>
CAUTION: This email and any attachments transmitted with it contain information that is CONFIDENTIAL and may be privileged or otherwise protected from disclosure. If you are not the intended recipient please notify us immediately and delete all copies of this email message and any attachments transmitted with it from your system. If you are not the intended recipient, any use, disclosure or copying of this email message and any attachments transmitted with it is strictly prohibited. This email message and any attachments transmitted with it cannot be guaranteed to be secure or error free as information could be intercepted, corrupted, lost, destroyed or incomplete. Although we routinely screen for viruses, it makes no representation or warranty as to the absence of viruses in this email or any attachments. The views expressed in this email are those of the sender and not necessarily those of Gabriel Cloud Systems LTD; if you require clarification please contact the sender.

Ok, I think I understand the scenario - you have an elastic scaling system that is creating containers based on load, and then you want to be able to monitor when the load is diminished so you can cleanup the unused resources.
This is best going to be handled by middleware in the proxy pipeline - after the route so that you know what destination the requests are going to be going to. It sounds like you have a dynamic configuration story, where routes and clusters are being created on the fly? How is that state being maintained?
One of the design principles of the proxy is that configuration can be updated while the proxy is running, and all in-flight requests will be processed using the configuration based on the time the request was first handled. So we have a snapshot mechanism, and the config objects passed around are intended to be immutable, new objects will be created if any state changes.
I would suggest that you look at having your own dictionary or weak ref table to store the time information of the last request. The challenge is to make it thread safe as there can be multiple simultaneous requests to each destination. The more you can avoid locks etc, the better as they will affect performance. In some ways you can cheat, as the accuracy of the timestamp doesn't need to be perfect - if one thread grabs a lock, and another then tries to access it - you could decide that the update that the thread with the lock is sufficient and not have to wait. Similarly your timer code that will look at what to purge can probably also fast fail if it cannot get a lock on the object for the state for a cluster - as it means that somebody else is updating it.
If YARP tried to provide APIs that would manage state, we wouldn't know how they were being used, and therefore what optimizations can be made.

Because the application does a lot more than proxy, my intent is to capture and save activity time stamps in a request transform rather than general middleware, so that it is only attempted for each request that has matched a proxy route.

Proxy middleware will only apply when the proxy is routing the request, so that would be a good place to track it.

We'll be hosting some containers with R Shiny applications and it's my understanding that after the page loads there could be nothing but websocket messages. Is there anything available?

There is the WebsocketTelemetry that will tell you when a WS is closed, but it doesn't give message by message events. If you configure a timeout for the web socket, is that sufficient - but it will still stay open if a client is keeping it open with active pings?

Triage: Seems to be answered. Closing. Feel free to reopen if we missed anything, or if there is additional info available. Thanks!

Just a note about the last reply.  To achieve the true goal of tracking user activity with a proxied application that uses only websocket messages, it would be necessary to have a message related event (e.g. in WebsocketTelemetry) that could be handled in my proxy application.  I can interpret a closed websocket event as last activity and it would be an adequate approximation since Azure closes all inactive sockets after 100 seconds, but if the application uses ping (which I expect them to do) then I have nothing.  At least that is what I think I'm hearing.


Clarification Needed regarding "Domain Administrator"

Under the heading, Rehost all GCs:
Warning.
The password of the Domain Administrator account for all domains must be ready for use in case a problem prevents access to a GC for logon.
I believe this statement needs clarification. Does it need the password of a member of the Domain Admins group in each domain or does it need the password for each domain's builtin administrator account?

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 7da3553a-7bbe-7091-9584-9ff912a2d817
Version Independent ID: 24b20a1e-7610-848b-276b-91246172dff9
Content: AD Forest Recovery - Recovering a single domain in a multidomain forest
Content Source: WindowsServerDocs/identity/ad-ds/manage/AD-Forest-Recovery-Single-Domain-in-Multidomain-Recovery.md
Product: windows-server
Technology: ad-ds
GitHub Login: @iainfoulds
Microsoft Alias: daveba

We hugely appreciate your contribution, feedback, and support to our technical documentation.
We’ve phased out GitHub Issues on this repository as the feedback mechanism for content and have replaced it with a new feedback system. For more information see, Content User Feedback. As part of this rollout, we are migrating your issue where our team will use your comments to improve the documentation experience. Unfortunately, this does mean you won't be able to access this issue after the migration is complete.
All issues will be migrated by Thursday 29th August 2024.
Once again, thank you for your valuable feedback, we hope you’ll continue to contribute using our new feedback system.


Create conda package

Probably something that we should try at some point...
conda-forge I guess

@wxicu just assigned you for now. Let's do this soon, but after your pertpy tasks


Executing Viewport.notification() crashes Godot

Godot version
3.4.beta.custom_build. 01ae4888e
System information
Ubuntu 21.10 - Nvidia GTX 970, Gnome shell 3.38 X11
Issue description
When executing
	var temp_variable2716 = Viewport.new()
	temp_variable2716.notification(91, true)
	temp_variable2716.notification(26, true)

Godot crashes with this backtrace
ERROR: Condition "!data.tree" is true. Returned: nullptr
   at: get_tree (./scene/main/node.h:269)
scene/main/viewport.cpp:376:48: runtime error: member call on null pointer of type 'struct SceneTree'
scene/main/viewport.cpp:376:48: runtime error: member access within null pointer of type 'struct SceneTree'

================================================================
handle_crash: Program crashed with signal 11
Engine version: Godot Engine v3.4.rc.custom_build (11d1b0387e51bf1582ba6e87c37e3e721d702339)
Dumping the backtrace.
-- END OF BACKTRACE --
================================================================

This example was found by fuzzer, so it is quite unlikelly that this code could be used in real project, but still this should be handled gracefully.
Steps to reproduce
Above
Minimal reproduction project
No response

Hello there, I'd like to see if I can jump in and figure this out. I'm new to OSS but I'd like to help! This bug has only been reproduced in a Linux env? Only asking because I have windows.
Thanks

Hi,
Yes, this was only reproduced on Linux, but I think that this also should crash on Windows.
To be sure that this crashes, code may be used in loop

I've tried it in MacOS, also crashes


ionic pwa angular gulp babel

Feature request

What is the expected behavior?
What is motivation or use case for adding/changing the behavior?
How should this be implemented in your opinion?
Are you willing to work on this yourself?
yes

webpack-4
documentation
performance

Thank you for creating this issue. However, issues need to follow one of our templates so that we can clearly understand your particular circumstances.
Please help us help you by recreating the issue using one of our templates.


Kotlin performance remarks

Hi,
Saw your post on medium and I was intrigued why the kotlin vm benchmark is slower then the go one. And I think I found at least a part of it.
The Instructions typealias copies the bytearray in a couple of extension functions (offset/onset). I suspect the slices in go don't copy the array but just have a wrapper referencing the same array with some variables to point to start and length. You could off course also do this in Kotlin and get a better comparison.
As a test I changed the copy code in Instructions.offset to System.arraycopy and this made it >20% faster already (bit of a hassle as this doesn't work on UByteArray and I had to change it to ByteArray). After this change I see time being spend in MInteger.getValue() calls, which looks like a Kotlin specific performance issue.
Anyway just wanted to share my findings, thanks for the go comparison article.

It is my understanding that Go does indeed "go" directly to the byte array references without creating copies. My implementations of offset and onset were using the take and takeLast from the Kotlin collections library that wraps everything on List<T> and are very slow
I'll try to experiment with System.arrayCopy.
Thanks for your kind words