Nx support

Is Your Feature Request related to a Problem? Please Describe
Iam trying to use the extension with a project that uses nx to build.
We use angular + karma + jasmine.
With default settings, the server crashes with:
19 06 2023 14:21:33.457:ERROR [karma-server]: Server start failed on port 9976: Error: The '@angular-devkit/build-angular/plugins/karma' karma plugin is meant to be used from within Angular CLI and will not work correctly outside of it.
Setting in manually to angular also doesnt work, since there is only an nx.json and the extension falls back to karma.
I use a custom batch file containing only "C:\Program Files\nodejs\npx.cmd" nx test --karma-config %2  as "karmaTestExplorer.karmaProcessCommand",
since passing anything but an absolute path without options to this option results in in the command not beeing found.
Iam not really a web developer and would be thankfull for any guidance on this.
Did i overlook an obvious solution?

No you didn't overlook anything. I'm not familiar with Nx, but Karma Test Explorer currently relies on the angular.json file to be able to both identify an Angular workspace as well as discover its sub-projects.
If you would like to work on contributing this feature, it could probably be addressed by adding provider implementations that detect and supply full project configuration for different kinds of setups, including the case for Nx.

@Siltyx :
We also use nx in our project. As a temporary solution we created angular.json beside every project.json. Example:
{
  "$schema"<EMAIL_ADDRESS>  "version": 1,
  "newProjectRoot": "projects",
  "projects": {
    "subProjectName": {
      "projectType": "application",
      "root": "",
      "sourceRoot": "src",
      "architect": {
        "test": {
          "builder": "@angular-devkit/build-angular:karma",
          "options": {
            "karmaConfig": "../../karma-explorer/karma-explorer.config.js",
            "tsConfig": "tsconfig.karma.spec.json",
            "polyfills": ["src/polyfills.ts", "zone.js", "zone.js/testing"],
            "styles": ["src/styles/styles.scss"<EMAIL_ADDRESS>            "assets": ["src/favicon.ico", "src/assets"],
            "stylePreprocessorOptions": {
              "includePaths": ["src/styles"]
            },
            "include": ["src/**/*.spec.ts"]
          }
        }
      }
    }
  }
}

@lucono Thanks for the reply. Sadly, I do not have the expertise. Maybe if I find the time. I suppose I need to add something like the code in src/api/frameworks/angular for nx?
@justdanpo thank you, I will try that :) My custom cmd file is not really working great.

@Siltyx I'm not very familiar with Nx. If you could share a minimal working sample Angular project (having multiple sub-projects) using Nx, I'll take a closer look.

Closing as no response. @Siltyx please reopen if still an issue.

@lucono here is an example project containing two apps.
Each app has project.json file which looks similar to angular.json though with some differences.
To run tests from commandline:
export CHROME_BIN=pathtochrome
npx nx run-many -t test --verbose

@Siltyx @lucono could you please reopen the issue?

Thanks @justdanpo. Without knowing much about Nx, my thinking is that this could probably be supported by parsing the Nx project files that exist in place of the angular.json config. Currently, Angular config parsing happens in the angular-util.ts file, which provides that information to the ProjectFactory.
I'm open to a PR - see my earlier comment on possibly using config providers to support both Angular and Nx project configs (and potentially others). Each provider would be capable of discovering a specific type of config and providing that information to the existing ProjectFactory implementation.

Sorry, i forgot about this. I will be able to take a look at the end of August.

Closing (see comment here).


Updating verifyinstall URL

Overview
While going to http://localhost:5984/_utils/verify_install.html returns Not found., browsing to http://localhost:5984/_utils/#/verifyinstall works. Maybe the url is outdated
Testing recommendations
Follow INSTALL.Unix.md until the "First Run" section and then browse to the http://localhost:5984/_utils/verify_install.html
Related Issues or Pull Requests

Checklist

[ ] Code is written and works correctly;
[ ] Changes are covered by tests;
[ ] Documentation reflects the changes;

good find, thanks!


Clarify top-level resource usage

It would be worth it to clarify if a third-party resource in the top-level document can use this to take advantage of the storage-access permission. My gut says that it doesn't make sense to allow that, but I wasn't certain what your intent was after reading this.

I'm not sure if I'm misunderstanding your question, but the main example (https://github.com/cfredric/storage-access-headers#new-flow) is a subresource of the top-level document that requires authentication in order to be retrieved from the cross-site server. The intent is to allow the server to opt in, by responding with the Activate-Storage-Access: retry header, so that the fetch is retried with auth credentials this time. (In the case of iframes, this just saves time. The site could alternatively load a placeholder iframe that calls requestStorageAccess() and then navigates to the "real" content, with credentials on the fetch.)
I think you might be considering iframes and other kinds of subresources to be different categories? If so, I'd be interested in hearing why.
My thinking was that if the browser ensures that this kind of credentialed subresource fetch is still gated behind a server opt-in (the response header), there shouldn't be a privacy risk to allowing it for non-iframe subresources. (By assumption, the storage-access permission has already been granted, so there's effectively no privacy boundary between the sites if they want to cooperate; just a security boundary, which we uphold by requiring the header opt-in.) I think expanding the ways to opt into storage-access such that non-iframes can participate, makes the permission a lot more useful to sites that serve non-iframe resources which still require credentials.

Oh, I went in thinking about iframes so I didn't see the main example as another resource.

The point I'm trying to illustrate is that iframes are just one kind of subresource, and the fetches of their content can require authentication too, just like an image/etc.

Mostly from a performance perspective. Creating a way to get top-level cross-site resources with credentials, but it requires two HTTP requests to do seems like a bad idea.

I agree that the latency required for the two HTTP requests isn't ideal, and I also agree that we ought to think in bigger terms here. To that end, https://github.com/privacycg/storage-access/issues/72 shows that web devs want/expect to be able to embed cross-site, non-iframe subresources (that require auth) in the top-level document. So the question for browsers is, do we believe that is a legitimate use case? I don't see a reason why it shouldn't be, so IMO browsers should make it possible (even if the latency is higher than in other use cases).

Doing this double-request once per subdocument is less bad.

I think this is a site UX concern, rather than a browser concern. If the web dev can design the experience to avoid the extra network request here, then performance is a good incentive for them to do so. But https://github.com/privacycg/storage-access/issues/72 shows that some use cases do not have that option.

Thinking in big-ideas, only documents can "have storage-access" as of now, so this is a big change beyond just adding headers to improve the ergonomics of getting storage access.

Agreed, I tried to call this out in the introduction and in the key scenarios section.

FWIW, CORS preflight requests are a precedent where the browser makes an extra network request before doing something sensitive, to make sure the server is ok with it first.
In the case of CORS, the "sensitive thing" is to make a non-idempotent cross-origin request.
Here, the "sensitive thing" is to make a credentialed cross-site request. (That's sensitive due to CSRF concerns, of course.)

Fair enough. I think I buy that use of top-level resources is probably reasonable. However could we restrict it some...
I'm going to move the CORS discussion to a new issue...

Closing this issue, continuing discussion in the other one.


MapWolverineEndpoints authorization?

I'm trying to figure out how to enable authorization for all Wolverine endpoints using the HTTP features. I have successfully applied the [Authorize] attribute to an endpoint, but I'd like to apply it globally. I can add an authorization policy, but I'm not sure how to get it applied to the Wolverine endpoints. Any thoughts?
I think I'm looking for the equivalent to MVC's:
app.UseEndpoints(endpoints =>
{
    // Require Authorization for all your Controllers
    endpoints.MapControllers().RequireAuthorization();
});

You could use an IHttpPolicy that news up and adds AuthorizationAttribute to each chain. It'd be a relatively quick PR, but I'm already working up a 1.3 release today anyway. Want me to add a pre-built, opt in policy for this?
It'll be something like MapWolverineEndpoints(opts => opts.Policies.RequireAuthorization());

I feel like it is a common enough feature that it should probably exist, especially since there's parity in the existing MVC and endpoint routing of ASP.NET.

Actually, temporarily, can you use:
app.MapWolverineEndpoints(opts =>
{
    // This is strictly to test the endpoint policy

    opts.ConfigureEndpoints(chain =>
    {
        chain.Metadata.RequireAuthorization();
    });

I'm just out of time for the day and need to kick out Wolverine 1.3. But totally agree with you here.

Or actually, this would work:
app.MapWolverineEndpoints(opts =>
{
    // This is strictly to test the endpoint policy

    opts.ConfigureEndpoints(chain =>
    {
        chain.RequireAuthorization();
    });

That would also be fine. Sorry I don't have a strong opinion about this! Thanks for the help though.

Closed by https://github.com/JasperFx/wolverine/commit/c46285135c9d18c8d4d4fd2547417adda3904bca


Fixed gru bwd/upd for cases C==K and K%2048==0

I will take the PR, but can you please pull and double-check rnndriver_nc_ck.c:324?
In your original code j was not initialized, but even if it is initialized (as I did) it looks somewhat cumbersome i.e., the purpose of j is not fully clear to me.


P2815 update layers here basemaps

Task to update layers to match configuration https://github.com/CartoDB/cartodb-platform/issues/2815

I think we lose more by starting to add those kind of special cases to the importer than what we gain from the little amount of imports we would have with Here maps. If the import does not display the correct basemap, it's an easy fix for the user anyway. @xav1jam also agrees on this. Do you?


Release jupyterhub/oauthenticator

Z2JH and TLJH are due for a major version release, including JupyterHub 5. For this, I'd like to also see us flush out an oauthenticator release.
I'm not sure if its a major or minor or patch release that's due.
Steps

[x] Look through the list of open PRs
[x] Verify changelog generation with github-activity doesn't have PRs that can be categorized under Other pull requests heading.
[x] Conclude if there are breaking changes (major version needed)

If so, look if something else, especially any open PRs considered breaking, should be expited to be part of the release
CONCLUSION: One breaking change, so v17

[ ] Open changelog PR (see RELEASE.md)

Definition of done

OAuthenticator is released according to the projects RELEASE.md

Thanks for opening this, @consideRatio.
In order to better connect the work engineering does to the goals of the organization, I'd like you to instead:

Create an issue about upgrading 2i2c infrastructure to JupyterHub 5
We use that to collectively figure out what work is needed to make that happen
More importantly, we can use that to collectively decide what timeline it should happen in
And then we can split off that into multiple tasks, and have the engineering team as a whole tackle that, rather than just you as an individual.

This forms part of how I think 2i2c's overall approach should change, so we can meet the goals laid out in https://github.com/2i2c-org/meta/issues/1289. I think some of these tasks would end up as internal engineering, while some tasks would end up as product dev. For example, I'd consider getting these two PRs deployed (https://github.com/jupyterhub/kubespawner/pulls?q=is%3Apr+author%3Asunu+is%3Aclosed) to be product dev work in favor of accomplishing https://2i2c.productboard.com/roadmap/7803626-product-delivery-flow/features/26496575, and this all helps us prioritize appropriately.

So specific action items would be:

Create an EPIC to say 'upgrade 2i2c infrastructure to JupyterHub' (I think you should do this)
Split it into subtasks that need to happen (You should also do this)
Prioritize these subtasks and decide on a timeline (I think right now, this is my responsibility, with input from everyone)
We collectively perform these tasks, scheduled through sprint planning, rather than have a single person do all of them.

I opened a release planning issue in https://github.com/jupyterhub/oauthenticator/issues/753.
This is upstream work blocking other upstream work, such as a tljh release, and that is someting i prioritize spending volunteer time working on as a jupyterhub maintainer. Due to this, I'm picking up work related to getting this (major) release out.

@yuvipanda I've made a personal todo-note to spend 2i2c time refining a high level 2i2c epic to upgrade to the future z2jh 4, as asked via https://github.com/2i2c-org/infrastructure/issues/4678#issuecomment-2310006686.

Done on my free time in between sprints.


RL-prompt MLP loss

Hey, I'm a student trying to replicate the sentiment analysis aspect of RLPrompt, and was wondering how exactly the MLP in the LM is trained? I see that you're getting a ground truth from the teacher_forcing method, so is it basically taking the previous step's prompt that got the best reward, calculating a loss based on current prompt's reward and previous best prompt's reward, then backproping on it?
Another clarification that would be helpful is  when formulating this as a RL problem, are the states essentially the time steps themselves and the prompts being the action that best rewards our problem? In that case, are you updating time step t's Q value based on t+1's generated prompts and their rewards? I'm a little confused on this because in this case the actions you can take grows every time step by a factor of how many prompts you generate per time step?

Hi, thank you for your interest! Please find the answers below:
How is the MLP in the LM trained? What's the role of the `teacher_forcing` function?

We train the MLP using the Soft Q-Learning (SQL) algorithm based on this paper. The algorithm trains the MLP using a regression loss for predicting the reward you will receive for selecting each prompt token. The loss usually uses a target network to provide the regression target. This regression target is computed in the teacher_forcing function. For more details, please refer to the paper linked above.
Definition of state and action

Following previous work on RL for text generation, we define the state as previous tokens, and the action as the next token to select from a vocabulary.
I hope these answer your questions. Please let us know if you have other questions. I am closing this issue now because it is a clarification question.


cannot upload an image to media gallery file uploader

Note: for support questions, please use stackoverflow. This repository's issues are reserved for feature requests and bug reports.

I'm submitting a ...

[x] bug report
[ ] feature request
[ ] support request => Please do not submit support request here, see note at the top of this template.

Do you want to request a feature or report a bug?
bug

What is the current behavior?
error in an attempt to upload an image to gallery file uploader

If the current behavior is a bug, please provide the steps to reproduce, ideally also a screenshot or gif if it's a style issue

open a file upload page
try to upload an image to the first uploader from the list
console error
e.filter is not a function at o.validateFiles

What is the expected behavior?
all types of uploaders should work correctly

What is the motivation / use case for changing the behavior?

Other information (e.g. detailed explanation, stacktraces, related issues, suggestions how to fix, links for us to have context, eg. stackoverflow, gitter, etc)

Probably would be closed by epicmaxco/vuestic-ui#268

We removed the component for now


Tests a merge of the AdminExperience repository

At this stage this is just to test merging the admin experience repository into the main repository, please do not merge yet.

Tested locally and this looks really good for me - thanks @valadas!

I looked at this also, this looks great.
Administrative question - do we squash merge this, or do we retain history?  (If not squashed, @valadas you are going to get a lot of internet points for this one!)

For people reviewing this, mainly looking for developer experience.

git clone -b pb-merge https://github.com/valadas/Dnn.Platform
open powershell as admin and run ./Build.ps1 -Target BuildAll
Let it build then verify the following

** Status should be clean **
git status should show nothing to commit (providing there was no build errors that stopped the buidl midway in which case, you should run git reset --hard and try again fixing what caused the error.
** You should have 4 zips in the Artifacts folder **
Try a clean install.
Try an upgrade.
Verify the Persona Bar works and gets 9.4.2 version

Per agreement with the Approvers group, I am merging this with a single approval as part of the Build Support processes.


⚠ Bofrost.fr has degraded performance

In 2331ba5, Bofrost.fr (https://www.bofrost.fr) experienced degraded performance:

HTTP code: 200
Response time: 1952 ms

Resolved: Bofrost.fr performance has improved in 15cb2c8 after 16 minutes.


Fix callbacks race in SelectorLoop.sock_connect.

While testing uvloop on recent CPython 3.5.2 I found a regression in loop.sock_connect, introduced in ed17848b271b07bc0de8fa08d8777128ca9ca789.
The bug breaks loop.sock_* in a very serious way, making programs that use those methods prone to random hangs after socket is connected.
How to trigger
Let's imagine we have a server, that sends some data (let's say b'hello') to the client immediately after connect.  And the client program is the following:
data = await self.recv_all(sock, 5)
assert data == b'hello'
await self.loop.sock_sendall(sock, PAYLOAD)

If the PAYLOAD is big enough, the client program will hang forever.
Explanation
The cause of the hang is a race between callbacks -- one related to loop.sock_connect and one to sock_sendall.
Here's the relevant piece of code from selector_events.py:
    def sock_connect(self, sock, address):
        """Connect to a remote socket at address.

        This method is a coroutine.
        """
        if self._debug and sock.gettimeout() != 0:
            raise ValueError("the socket must be non-blocking")

        fut = self.create_future()
        if hasattr(socket, 'AF_UNIX') and sock.family == socket.AF_UNIX:
            self._sock_connect(fut, sock, address)
        else:
            resolved = base_events._ensure_resolved(
                address, family=sock.family, proto=sock.proto, loop=self)
            resolved.add_done_callback(
                lambda resolved: self._on_resolved(fut, sock, resolved))

        return fut

    def _on_resolved(self, fut, sock, resolved):
        try:
            _, _, _, _, address = resolved.result()[0]
        except Exception as exc:
            fut.set_exception(exc)
        else:
            self._sock_connect(fut, sock, address)

    def _sock_connect(self, fut, sock, address):
        fd = sock.fileno()
        try:
            sock.connect(address)
        except (BlockingIOError, InterruptedError):
            # Issue #23618: When the C function connect() fails with EINTR, the
            # connection runs in background. We have to wait until the socket
            # becomes writable to be notified when the connection succeed or
            # fails.
            fut.add_done_callback(functools.partial(self._sock_connect_done,
                                                    fd))
            self.add_writer(fd, self._sock_connect_cb, fut, sock, address)
        except Exception as exc:
            fut.set_exception(exc)
        else:
            fut.set_result(None)

    def _sock_connect_done(self, fd, fut):
        self.remove_writer(fd)

    def _sock_connect_cb(self, fut, sock, address):
        if fut.cancelled():
            return

        try:
            err = sock.getsockopt(socket.SOL_SOCKET, socket.SO_ERROR)
            if err != 0:
                # Jump to any except clause below.
                raise OSError(err, 'Connect call failed %s' % (address,))
        except (BlockingIOError, InterruptedError):
            # socket is still registered, the callback will be retried later
            pass
        except Exception as exc:
            fut.set_exception(exc)
        else:
            fut.set_result(None)

Before ed17848b271b07bc0de8fa08d8777128ca9ca789, sock_connect called _sock_connect directly:

sock_connect created a fut Future.
If the address wasn't already resolved it raised an error.
If the address was resolved, it called _sock_connect, which attached a callback to the fut -- _sock_connect_done.
sock_connect then returned fut to the caller.
If the caller is a coroutine, it's wrapped in asyncio.Task. Therefore, fut now have two callbacks attached to it: [_sock_connect_done, Task._wakeup]

After that commit:

sock_connect creates a fut Future.
Then calls _ensure_resolved (linked fut to the result of that call's Future).
sock_connect returns fut to the caller.
If the caller is a coroutine, its Task will add a callback to the fut, eventually resulting in this: [Task._wakeup, _sock_connect_done]

Therefore, after ed17848b271b07bc0de8fa08d8777128ca9ca789, _sock_connect_done can be called after await loop.sock_connect() line. If the program calls loop.sock_sendall after sock_connect, _sock_connect_done will remove writer callback that sock_sendall set up.
/cc @gvanrossum @ajdavis @haypo

Another change: I had to make sock_connect and actual coroutine. Before this PR it returned a Future (although it was documented that the result of the call is coroutine).

The more I'm trying to fix this thing, the more tests break in interesting ways. Maybe we should just partially revert ed17848b271b07bc0de8fa08d8777128ca9ca789.

Call in the author of that commit?

Yes, I put Jesse in cc. I was the one who reviewed it though, so the responsibility is on me.

 Bugs happen. Life goes on.

Alright, the tests are passing; please review.

Thanks for continued guidance and effort on this, @1st1. I'll review it soon, if you like.
I keep thinking, though, maybe we should revert this whole idea: the idea of skipping getaddrinfo if we can detect that the address is already resolved? It seems to be a bug factory. First because getaddrinfo's AI_NUMERICHOST is harder to simulate in Python, in all platforms, than we thought. Second, because my attempt to fallback to getaddrinfo in https://github.com/python/asyncio/commit/ed17848b271b07bc0de8fa08d8777128ca9ca789 introduced an additional yield, which caused the current race condition.
Now that we've made getaddrinfo concurrent on Mac and BSD, AI_NUMERICHOST is no longer such a bottleneck. Would rolling back this whole line of changes be simpler and safer than continuing to whack bugs?

Would rolling back this whole line of changes be simpler and safer than continuing to whack bugs?

Probably yes.  On the other had, I like how sock_connect works now, accepting any kind of address.  Please take a look at my patch.

I like Jesse's idea. It's good to be thinking about the maintainability of
this code.
--Guido (mobile)

This LGTM, I think. It's getting pretty complicated and my confidence is shaken that either of us can detect bugs by inspection. I propose we merge this--it's valuable both to fix the bug for now, and to add tests to guard against regression.
Then, I think (and Guido agrees) that we should revert this whole idea. So let's keep the new tests, as much as possible, but stop trying to simulate getaddrinfo's AI_NUMERICHOST.
I regret this idea was released in Python 3.5.2. I'm glad it's still "provisional". =)

Then, I think (and Guido agrees) that we should revert this whole idea. So let's keep the new tests, as much as possible, but stop trying to simulate getaddrinfo's AI_NUMERICHOST.

I'm -1 on reverting anything TBH.

Trying to parsing with pton in create_connection and create_server is harmless, at least with the current implementation (that ships with 3.5.2). That's considered to be a good practice actually.

For sock_connect - parsing vs not parsing is not an issue, now we just call loop.getaddrinfo.  It's actually a different question: do we want to sock_connect to require resolved addresses or we can make it to resolve them.  I think that the latter is much more preferable.

To conclude - I think we should just leave things as is (after this PR is merged).

This fix will go in b2.

Merged in d6dcf25324eb438f35746fc2901de6d9979e6f4d.

The test fails at least on one buildbot, "AMD64 FreeBSD CURRENT Non-Debug 3.x", please have a look:
http://bugs.python.org/issue28176#msg276736

Note that we've removed test_sock_connect_sock_write_race in http://bugs.python.org/issue28283, but it was added back in the last sync. Perhaps we should add a comment?

The test has been removed from CPython and this repo. Closing this PR.


Standardize options

Bugfixes

[sc-13892]    Standardize flow viewer, starter, and administrator arguments -- and their aliases -- throughout the CLI and API.
Although this change fixes bugs that prevented documented CLI options from working,
it also introduces breaking changes:

--flow-viewer, --flow-starter, and --flow-administrator are the canonical CLI options.

The CLI option aliases will continue to work, but the alias behavior has changed:

If an alias is used, a warning is written to STDERR.
If the canonical option name is combined with one of its aliases,
an error will be written to STDERR and the Automate client will exit.
The exit code will be 1.
If more than one of the acceptable aliases is used (like --starter and --runnable-by),
an error will be written to STDERR and the Automate client will exit.
The exit code will be 1.

In addition, there are breaking changes in the API:

flow_viewers, flow_starters, and flow_administrators are the canonical API argument names.

The API argument aliases will continue to work, but the alias behavior has changed:

If an alias is used, a Python warning will be issued.
Applications can control the warning behavior using Python's warnings module.
If the canonical option name is combined with one of its aliases, a ValueError will be raised.
If more than one of the acceptable aliases is used (like starters and runnable_by), a ValueError will be raised.

Discovered an incomplete sentence in the changelog fragment. This is fixed now.


DevLogin -> DevAuth

DevAuth has added neoforge support in their latest release, so I've ported from DevLogin.
config.toml is stored in ~/.config/devauth or C:\Users\<user>\.devauth. You can have multiple accounts configured there.
You can also set defaultEnabled = true and dump the devauth jar in run/mods/ when debugging other projects, that way the project doesn't have to be configured to support devauth.
See the configuration section of their README for more detail.
You can copy IDE run configs and add -Ddevauth.account=someaccount if you have multiple accounts configured in your devauth config, for example.
Note: I've put this together on my laptop, which has an opengl issue meaning I can't test/run the game. Therefore this PR is currently untested.

If you prefer, we can drop the "logged in" run configs, and instead rely on setting up defaultEnabled manually based on preference.
We could even drop baked-in devauth support entirely, since you can just drop the jar into run/mods...

In fact, we could even drop baked-in devauth support entirely, since you can just drop the jar into run/mods...

Honestly, I think this would be the better option. Less maintenance going forward, and keeps the run configs tidy.

In fact, we could even drop baked-in devauth support entirely

Honestly, I think this would be the better option.

Ok, I'll do that.


Homepage + Iconic incompat

Details
When setting a custom icon for the settings menu, Homepage seems to disable pointer events for it and remove the icon that Iconic sets on startup. I'd appreciate if this code could be reviewed to see if there's anything to be done to let Iconic do its job.
I don't even really understand what/why Homepage is doing with the settings icon, and am kinda curious after a fairly excruciatingly thorough debugging session, so that would be appreciated, but absolutely not necessary.
styles.css seems to contain a pointer-events: none !important, and that, I'm even more confused about. I tried removing styles.css and reloading purely for testing, but it seems to be something in the Javascript which is incompatible too.
Cheers
Steps to reproduce

Install Iconic
Set a custom icon for the settings cog in the left sidebar (occurred on mobile, not sure about PC)
Reload
Icon gone, holding to set an icon doesn't do anything

Debug information
Callout Integrator
Commander
Default New Tab Page
File Info Panel
Folder Notes
Full Calendar
Homepage
Hover Editor
Iconic
Lazy Plugin Loader
Line Commands
MySnippets
PDF++
Remotely Save
Snippet Commands

Note: All of them are disabled except for Homepage and Iconic, the two needed to reproduce this issue

Checklist

[X] I updated to the latest version of the plugin.

How Homepage works (in the default "replace all notes" mode) is that it essentially opens a new workspace with the left and right sidebars the same as before, but the central pane replaced.
I've tested opening a workspace manually (with Homepage disabled), and Iconic indeed doesn't correctly propagate the settings icon. Since the other icons still work correctly, this is probably best solved on Iconic's end.
There's a bunch of other logic but most of that is fairly inconsequential to what's going on here. The pointer-events: none !important is for Homepage's settings pane and won't affect anything when the pane isn't displayed.


Fix type of salary

tasks 🦾

[ ] Fix the type of salary from enum to a decimal with 12 number and 2 decimal

Done with #40


Fix epsilon comparison when splitting

resolves #6307
What does this PR change?
This PR improves the epsilon comparison to be more tolerant of different values. The existing comparison is invalid when the values have high or low exponents. In these cases, it can lead to a non-splitting split, which in turn leads to assertion failures.
I'm not sure of the purpose of this comparison, but it seems like it's just trying to ensure that the split value computed below will actually lie between the two neighboring values. If that's true, then I think this change is valid and doesn't change behavior.

The build failed, but I'm not certain that the errors are due to my changes. I'd love some assistance in getting a local test environment set up; can't find anything in the docs for running tests locally.

You can take a look on used commands during tests here: http://pullrequest.opencv.org/#/summary/
Or add "debug" printf() before changed line and update this PR to restart tests:
printf("eps=%g curr=%g next=%g    old=%s new=%s\n",
    (double)epsilon, (double)values[curr], (double)values[next],
    ((values[curr] + epsilon < values[next]) ? "TRUE" : "FALSE"),
    (((values[next]/values[curr] - 1.f) > epsilon) ? "TRUE" : "FALSE"));

(only idea, it is not tested - some errors are possible)

Thanks for your suggestion. I discovered my initial solution was broken for negative values. But because the array is already sorted, we don't need to ensure the ordering again in this condition, so I added fabsf.
The new version passes tests locally; hopefully the buildbot likes it too.

The buildbot failed, but it doesn't look like the failure was due to my changes. Trying again.

@ezheidtmann, thanks for the patch! the suggested formula fails when values[curr] is zero. Also, when both the numerator and denominator are very small or very big, division may be very inaccurate. Need some more robust solution, otherwise the new formula creates more problems than solves

Thanks for taking a look, @vpisarev. I agree that division by zero is a problem (I will work on a fix!). But I don't see a problem when both numbers are small or large. The exponents will be subtracted, then the mantissas divided. If you could provide a counter-example where my patch produces bad results, I would very much appreciate it!
Thanks,
Evan

Thanks again for catching the division-by-zero bug. Latest commit avoids that problem and also avoids division. If I'm understanding the purpose of this check correctly, this version will test directly that the computed split value differs from both inputs, thus avoiding the case I described in my original bug report #6307.

@vpisarev I'd appreciate your review of my latest version. I've avoided the possibility of division-by-zero and I'm interested to hear what you think. Thanks!

thanks! the new solution looks great! :+1:


Investigate Requirements for Patch/Minor/Major

Motivation
As discussed in our initial brainstorming session we need to find a clear guideline to define when a change is a Patch/Minor/Major release. For this we need to cover cases like what is a breaking change - like is rolling a node already breaking, because it breaks single node CPs?
Todo

[ ] Create some initial draft for the different use cases we need to cover
[ ] Create a meeting to discuss the different use cases
[ ] Derive some guideline rules that can be transformed into a checklist used when versioning changes

Outcome

We have a clear guideline what change is which versioning level and some use cases to back it up.

Document is published here.


Ratings by course

Coverage remained the same at 94.253% when pulling f08185796dbb6bc0b79d93a47ec446ff1ba720ac on ratingsByCourse into 3cbf14b97e57cd75adda27dd9e669065cba6c715 on master.


Filament does not encode square brackets in the URL by default

Package
filament/filament
Package Version
v3.2.68
Laravel Version
v11.10
Livewire Version
v3.5.0
PHP Version
PHP 8.2
Problem description
Filament does not encode square brackets [ ] in the URL by default.
Expected behavior
Square brackets should be encoded according to RFC 3986.
Steps to reproduce
I encountered this problem when I was redirecting a user from a certain action to another resource with a filter applied, like so:
return $table
    ->...
    ->actions([
        ActionGroup::make([
            Action::make('...')
                  ->...
                  ->action(
                      fn($record) => redirect()->to(
                          ListOtherResourceFilament::getUrl([
                              'tableFilters' => [
                                  'unit' => [
                                      'reservable' => [
                                          'code' => $record->id
                                      ],
                                  ],
                              ],
                          ])
                      )
                  )
            ,
        ]),
    ]);

As you can see here, I add a filter (query string) to the URL the user is redirecting to. Since redirect()->to() is a Laravel function, it encodes the full URL, as it should!, and I end up on:
https://example.local/....?tableFilters%5Bunit%5D%5Breservable%5D%5Bcode%5D=UN100000

This works. Filament does understand the filter and applies it on load. But whenever I change the current filter to another value on that page, Filament ADDS the whole filter again, this time unencoded. So I end up with the URL that has the filter twice.
https://example.local/....?tableFilters%5Bunit%5D%5Breservable%5D%5Bcode%5D=UN100000&tableFilters[unit][reservable][code]=UN100001

And it even gets worse when I apply another filter.
In my opinion there are 2 solutions.

Filament should encode square brackets globally. Impact might be big...
Filament keeps using square brackets unencoded (which is easier to read, but against RFC), and tries to fix applying filters to URL's that have those square brackets encoded.

If you want to make this working, as a workaround you can do the following (special thanks to @dissto):
return $table
    ->...
    ->actions([
        ActionGroup::make([
            Action::make('...')
                  ->...
                  ->url(function ($record) {
                      $query = http_build_query([
                          'tableFilters' => [
                              'unit' => [
                                  'reservable' => [
                                      'code' => $record->code,
                                  ],
                              ],
                          ],
                      ]);

                      return ListOtherResourceFilament::getUrl() . '?' . urldecode($query);
                  })
            ,
        ]),
    ]);

Reproduction repository
https://github.com/Tklaversma/filament
Relevant log output
No response

Donate 💰 to fund this issue

You can donate funding to this issue. We receive the money once the issue is completed & confirmed by you.
100% of the funding will be distributed between the Filament core team to run all aspects of the project.
Thank you in advance for helping us make maintenance sustainable!

Filament uses the route() helper to generate URLs, so what can we do here? Is this not an issue in Laravel?

@danharrin the filters itself are handled by Filament and they don't get encoded. That's the issue.

Where do we handle constructing the URL then? I don't recall writing anything like that. The getUrl() method just wraps the route() helper

@danharrin I can dig in if you want. Up till now I just confirmed it's happening in Filament and not in Laravel.

Yes please

@danharrin after some digging, Laravel is applying RFC3986 correctly. Under the hood \Illuminate\Support\Arr::query() is called, which builds the query string like so:
    /**
     * Convert the array into a query string.
     *
     * @param  array  $array
     * @return string
     */
    public static function query($array)
    {
        return http_build_query($array, '', '&', PHP_QUERY_RFC3986);
    }

Hence the PHP_QUERY_RFC3986. This will make sure that the query string is encoded accordingly. And the RFC3986 rules state that square brackets may only be used in the host part of the URL.
So, coming back to my original post, Filament is NOT using Laravel to apply filters, since square brackets are visible in the URL whenever any filter is applied by the user clicking it. But whenever we route to a resource page with given filters applied accordingly (encoded square brackets), Filament does apply the filter, but after that breaks, whenever it tries to apply any other filters.
So, as mentioned earlier, in my opinion there are 2 solutions.

Filament should encode square brackets globally.
Or Filament keeps using square brackets unencoded (which is easier to read, but against RFC), and tries to fix applying filters to URL's that have those square brackets encoded.

@danharrin I think we should dive into that. I mean using unencoded square brackets in the url is nice, readable and works, but it's incorrect and Laravel is correctly encoding them. Are we breaking from Laravel ways or are we fixing Filament?

Laravel is responsible for generating URLs, Livewire is responsible for updating the URL when filters are used (through JavaScript), Filament handles neither of those things

@danharrin Guess this is a Livewire thing then. Then I'll make an issue there.

Should be relatively easy to reproduce, add an array property with the Url attribute on it. Gonna close this but if there is anything we can do to fix this in Filament let me know

See https://github.com/livewire/livewire/discussions/8553


July release of KeyVault for JS

Features

[ ] (Preview) Support local key encryption for CryptographyClient (#7278)

[ ] [KeyVault-Keys] The CryptographyClient should allow to be created with a KeyVaultKey #7140

[ ] (Preview) Support Role-based Access Control (RBAC) for data plane (#7279)
[ ] Allow customers to parse certificate, key, and secret IDs from URLs (#7443)

[ ] [KeyVault] Expose the parser of the KeyVault identifier #7139

[ ] [KeyVault] Implement a new client with vault backup and restore operations #9215

This issue can be considered resolved. We will only be releasing what we have added to master so far. Our main target for this July release is this PR https://github.com/Azure/azure-sdk-for-js/pull/7501 And anything we might have in master right now. All of the other tasks have been moved to September.


Taking forever to building schema

When I did npm start, the process is stuck forever on building schema part and not going forward, help please.

same for me

clear your terminal. Ctrl + C
This: npm install --force
will resolve your issue.
Steps I took:

Deleted the cloned project as I have messed a lot of things up.
Cloned it from github again
Deleted the yarn.lock file
Run npm install -g gatsby-cli
npm install --force
npm start
I was then able to view v4 project in my browser on using http://localhost:8000/

clear your terminal. Ctrl + C This: npm install --force will resolve your issue.
Steps I took:

Deleted the cloned project as I have messed a lot of things up.
Cloned it from github again
Deleted the yarn.lock file
Run npm install -g gatsby-cli
npm install --force
npm start
I was then able to view v4 project in my browser on using http://localhost:8000/

clear your terminal. Ctrl + C This: npm install --force will resolve your issue.
Steps I took:

Deleted the cloned project as I have messed a lot of things up.
Cloned it from github again
Deleted the yarn.lock file
Run npm install -g gatsby-cli
npm install --force
npm start
I was then able to view v4 project in my browser on using http://localhost:8000/

this worked for me

6. npm start

Helped! Thanks


'rating' is not a known element:

very odd, I am getting the error of:
Unhandled Promise rejection: Template parse errors:
'rating' is not a known element:
1. If 'rating' is an Angular component, then verify that it is part of this module.
2. If 'rating' is a Web Component then add "CUSTOM_ELEMENTS_SCHEMA" to the<EMAIL_ADDRESS>of this component to suppress this message. ("ss="list-group">
                        <li class="list-group-item">
                            [ERROR ->]<rating></rating>

I did import the modules
import {DropdownModule} from 'ng2-bootstrap/ng2-bootstrap';
import {RatingModule} from 'ng2-bootstrap/ng2-bootstrap';

and drop down works fine... but yet RatingModule generates an error... mmm
any ideas?
ver 1.1.2
Regards,
Sean
Angular 2 Kitchen sink: http://ng2.javascriptninja.io
and source@ https://github.com/born2net/ng2Boilerplate

Please show us your complete ngmodule definition and the template which throws the error.

sure:
here:
https://github.com/born2net/studioDashboard/blob/master/src/App.ts
and used here:
https://github.com/born2net/studioDashboard/blob/master/src/comps/app1/adnet/network/AdnetNetworkTargetProps.html

and the controller:
https://github.com/born2net/studioDashboard/blob/master/src/comps/app1/adnet/network/AdnetNetworkTargetProps.ts

The rating component needs an ngModel binding.

haaaa.. it must? seems odd, as I was going to use it in reactive form with no ngModel (manual updates), trying now

I'm not 100% sure but the rating definition says: selector: 'rating[ngModel]' :)

ya that's a problem for me, as I am using
[formGroup]="contGroup"

for reactive form and now will get an error of:
EXCEPTION: Error in http://localhost:9089/src/comps/app1/adnet/network/AdnetNetworkTargetProps.html:13:36 caused by:
      ngModel cannot be used to register form controls with a parent formGroup directive.  Try using
      formGroup's partner directive "formControlName" instead.  Example:

    <div [formGroup]="myGroup">
      <input formControlName="firstName">

mmm
:/

will open bug as rating should not force ngModel in selector for reactive forms


Rebuild for r-base-3.6.1

Needed for https://github.com/conda-forge/staged-recipes/pull/8853

Checklist

[x] Used a fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[x] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@conda-forge/r-rnetcdf This is ready for review/merge.


File operations using flutter differently executed in different versions of Android.

I've found that the file operations in flutter when using path_provider are differently executed in different versions of Android:

Android 5.1 (Samsung 6): recursive creation of folders works without problems both in the application space: getApplicationDocumentsDirectory(), and on external memory: getExternalStorageDirectory(). Creation of files is also performed without problems.
Android 6.0.1 (LG G5 SE) and Android 7.0 (LG-V520): in the application space you can create a file or folder, but recursive creation of folders like getApplicationDocumentsDirectory () + "/a/bb/ccc" is impossible, but this issue not critical. Creating files on external memory is simply impossible:

I/flutter (23327): /storage/emulated/0 -- exists
E/flutter (23327): [ERROR:topaz/lib/tonic/logging/dart_error.cc(16)] Unhandled exception:
E/flutter (23327): FileSystemException: Cannot open file, path = '/storage/emulated/0/scheme.json' (OS Error: Permission denied, errno = 13)
E/flutter (23327): #0      _File.open.<anonymous closure> (dart:io/file_impl.dart:368:9)
E/flutter (23327): #1      _RootZone.runUnary (dart:async/zone.dart:1381:54)
E/flutter (23327): #2      _FutureListener.handleValue (dart:async/future_impl.dart:129:18)
E/flutter (23327): #3      Future._propagateToListeners.handleValueCallback (dart:async/future_impl.dart:633:45)
E/flutter (23327): #4      Future._propagateToListeners (dart:async/future_impl.dart:662:32)
E/flutter (23327): #5      Future._completeWithValue (dart:async/future_impl.dart:477:5)
E/flutter (23327): #6      Future._asyncComplete.<anonymous closure> (dart:async/future_impl.dart:507:7)
E/flutter (23327): #7      _microtaskLoop (dart:async/schedule_microtask.dart:41:21)
E/flutter (23327): #8      _startMicrotaskLoop (dart:async/schedule_microtask.dart:50:5)
I/FlutterActivityDelegate(23327): onResume setting current activity to this
I/Timeline(23327): Timeline: Activity_idle id: android.os.BinderProxy@7dfa1da time:695440093

In principle, this is not an error of path_provider. There are some problems with the permissions of the file system. Inclusion in AndroidManifest.xml file the next lines:
    <uses-permission android:name="android.permission.WRITE_EXTERNAL_STORAGE"/>
    <uses-permission android:name="android.permission.READ_EXTERNAL_STORAGE"/>

doesn't solve the problem, although this is actual for Android 5.1 when working with external memory. Perhaps someone has come across this errors and knows how to solve problem?

This problem is solely related to the problem of permissions of Android since version 6. If manually change the permissions of the application: settings-> Apps -> [application name] -> Permissions [Storage] -> [ON], the error disappears. In fact, in Android, if use java, such situations are processing special (as in iOS) way. In flutter, too, there is some mechanism to do this, but need to write additional code in java wrapper, i.e. in MainActivity.java. Ideal: if the problem was solved in the plugin itself.


fix potential deadlock

Fix a potential deadlock at TestQueryConcurrency:
https://github.com/prometheus/prometheus/blob/664b39157381239c7c5e568ca9dcebc8732beae4/promql/engine_test.go#L59-L75
If promql/engine_test.go line 74 happened first, promql/engine_test.go line 72 will not be executed and leave sender's goroutine blocked forever after promql/engine_test.go line 75 stops .
Similar to #8964

As this has never happened in practice, I'd leave this as is. It would be worse to not block if we create a bug in the tests. WDYT?

I am with @roidelapluie here. If it ever deadlocks, maybe it's hinting towards some issue in the actual code.

I updated the PR with fixing potential deadlock at two places: processing and block. It can gracefully terminate the child goroutine if test exit with any issue.

@codesome updated it.

@charlesxsh could you please fix the DCO (it's failing now)? And possibly also sync this PR with the main branch to fix other failing tests.

@codesome Hi there, I fixed the DCO. Would you like to merge it if everything ok?


Azure SDK Review - [ACS Auth Service]

New SDK Review meeting has been requested.
Service Name: ACS Auth Service
Review Created By: Maqsood Jafferi
Review Date: 11/07/2023 04:05 PM PT
Hero Scenarios Link: Not Provided
Architecture Diagram Link: Not Provided
Core Concepts Doc Link: Not Provided
APIView Links: .NET, Javascript, Java, Python,
Description: Presently, the range of user capabilities within ACS spans from high-level tasks, like initiating a new call/chat, to more granular actions, such as adding participants, deleting messages, muting their own microphone during an ongoing communication. This feature (Granular Tokens) addresses modifications aimed at granting resource-level control over users' capacity to perform Create or Delete operations on Calls and Chat through the introduction of new scopes.
'chat.join' : To allow access to Chat APIs but without the authorization to create, delete or update chat threads.
'chat.join.limited': A more limited version of chat.join that doesn't allow to add or remove participants. Use this scope when the token bearer is not fully trusted, for example in guest scenarios.
'voip.join': To allow access to Calling APIs but without the authorization to start new calls.
REST API Specification PR : https://github.com/Azure/azure-rest-api-specs/pull/26108
Detailed meeting information and documents provided can be accessed here

Cancelled by: Maqsood Jafferi


Why gifs in android works very slow?

I have page with few gifs on it and it works very slow.
Does it bug ? or is suppose to be so slow?
As i understand react is working in native component and not in webview.
Please assist.

Could you give more information? How about the gif size ?

You're right, React Native is working in native components and not in WebView as Cordova/Phonegap do.
On Android, images are handled by Fresco library and it shouldn't be slow.
Are you in remote debugging JS mode? Go to the dev settings and unchecked JS Dev.

@facebook-github-bot label Needs more information

@roysG  You tried this on web view of React Native or you have created separate screen, to render it in Native code itself.

I have also ran into this issue
when I call the image via
<Image source={require('path-to-gif')} />
(gif loads super fast)
vs
<Image source={{uri: 'path_to_gif_found_in_drawable'}} />
(gif is painfully slow)
I even ensured in my dev settings, dev was turned off.
Any thoughts?


Error has occurred while trying to sign in

When I try to run Broadcast-Development-Kit-Web-UI solution as described in this document the login screen shows up after I run "npm run start".  Just clicking on the "Login to your account" button causing the following error message:

Trying to navigate to localhost:3000 in "In Private" doesn't change the behavior
Question 1: How to fix this
Question 2: Do I need to have an MSA account to sign in to run this sample?

Please double check that the settings in your config.json file match the ones in the Configure the solution section. When running locally, you should have the DISABLE_AUTHENTICATION flag enabled to skip the authentication flow in the UI, unless you are trying to configure the solution to run with authentication "on" in your local machine.
The backend should also be configured to run in the local environment.

Sorry, my bad, the json I had was malformed. I can bypass authentication after fixing it.  Now when I try to join the meeting, the status changes to Establishing and then to terminated.

I see status change in the BotService as well.  What would be the best way to investigate why the bot cannot connect a meeting?
Also please let me know if you'd like me to close this issue and open a new one for the latter problem.

When the status changes from Establishing to Terminated it usually means that the Graph API was not able to complete the handshake with the BotService, which is needed to obtain the information of the meeting. When running the solution locally this can be caused by problems related to the Ngrok configuration (e.g. Ngrok was not running, the appSettings file was not updated with the latest parameters that Ngrok is using, etc.). Please double check that:

The BotService's appSettings.local.json file matches with the values shown by Ngrok as explained in this document. Note that you need to update these settings each time you run Ngrok.
The SSL certificate you obtained was properly installed in your local machine.

Since this problem is more related to the backend of the solution, you can create a new issue in the backend repository if you keep seeing these problems.

Closing this issue and opening a new one in backend repository


MUI.Windows conflict with Google Maps API

In this version, when I use the Google Maps API, I can not open new windows, after that, just do not open the windows and also does not show any error in firebug. In version (0.9.7), everything works fine.

Without further info or an example, I can not really diagnose this with you.  I have had a similar problem with something else in that last few days. In core.js search for and comment out the hide: and show: functions.  Somewhere around line 399.  This code is no longer needed, but creates side effects when it is there.  Like when a window goes to create itself but then hides the content panel, this cause Mocha to hide the window.
-Chris


Don't touch my licence

It'd be neat if cobra didn't touch an already existing LICENCE file. I have to revert changes every time I use cobra.

Hi all - I've transferred this issue here to spf13/cobra-cli since this is specifically about the bootstrapping tool that was moved out of the core spf13/cobra repository.
This is still relevant, so re-opening.
PR welcome!

Shouldn't the default behavior to warn user if an existing LICENSE file is detected? And suggest to explicitly use  a flag to not replace the LICENSE?

@laureanray The PR in place, lists down the current licenses and warns / reconfirms from the user before overwriting the license.
https://github.com/spf13/cobra-cli/blob/6ed77f4e42e5ff07a6c7741a8902c3baf4ed74de/cmd/project.go#L116

Sorry didn't see the PR. Great job. Looking forward for it to be merged.

Hello 👋
My PR is ready for review https://github.com/spf13/cobra-cli/pull/60.
Thanks

This PR is long-awaited to be merged. https://github.com/spf13/cobra-cli/pull/4
Is any action required?

This license thing is so annoying. Please merge this PR already.

Why hasn't this been merged yet? "Don't overwrite my license file" and "Don't add nonsensical license headers if the relevant flags aren't supplied" seem like sane defaults. It's very frustrating trying to use this tool and having to manually remove the file headers constantly.


WebSockets error: TypeError: null is not an object (evaluating 'res.status')

WebSockets always throw errors when attempting to connect:
129 |                 message: (ws, msg) => router.handleWebSocket(ws).message(msg),
130 |             },
131 |             async fetch(req, server) {
132 |                 let ctx = new Context(req, server);
133 |                 const res = await router.handle(ctx);
134 |                 return res.status === 404 ? notFoundHandler(ctx) : res;
                             ^
TypeError: null is not an object (evaluating 'res.status')
      at node_modules/baojs/dist/bao.js:134:24

All I've done here is setup a simple websocket connection:
app.ws("/ws/room", {
  close(ws) {
  },
  message(ws, msg) {
  },
  open(ws) {
  },
});

It looks like the route handler doesn't create any Response object, but the fetch() method expects one to always be present.
Bao version: 0.2.1
Bun verions: 1.0.18

This pull request #30 will fix that issue.


Can't scaffold identity in new project.

Using 2.1 Preview 2.
Following directions from blog post, want to scaffold identity using the command
dotnet aspnet-codegenerator identity -dc WebApplication1.Data.ApplicationDbContext
I receive this error:
dotnet : No executable found matching command "dotnet-aspnet-codegenerator"
What does my csproj file need to look like to find this command? I've tried installing all sorts of packages and adding tools but can't get it to work. What's this supposed to look like?

@javiercn who owns this bit?

@seancpeters Owns this.
I think the blog post might be missing instructions. If I remember correctly, the scaffolder is a global tool now. So it needs to be installed with dotnet intall tool dotnet-aspnet-codegenerator --version 2.1.0-preview2-final" @natemcmaster can confirm

I'm not sure of the answer here, but dotnet-aspnet-codegenerator was cut from preview2 due to issues in the global tools feature in the CLI. We hope to ship it in RC

@natemcmaster Ah, you are right. @blowdart Who wrote the documentation for this? @danroth27?
In any case, I'll figure out what to do here.

You should be able to go thru Add New Scaffolded Item -> Identity

You have to add scaffolding as a DotNetCliToolReference. If you run the Identity scaffolder from VS it will take care of that for you. In Preview1 we didn't have the VS experience so the command-line was your only option, but our main focus is on the VS experience.

To see how to add the DotNetCliToolReference, add the following item in your project file:
<DotNetCliToolReference Include="Microsoft.VisualStudio.Web.CodeGeneration.Tools" Version="2.0.3" />

Ahhh. Yep, it's there and worked great. I suppose an updated Preview 2 blog post will go into such a thing when posted, but that Preview 1 one was all I had to work on :) Thanks


[FLINK-11728] [table] Deprecate CalciteConfig temporarily

What is the purpose of the change
Deprecates the CalciteConfig to unblock FLINK-11067.
Brief change log

Deprecation added.

Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): no
The public API, i.e., is any changed class annotated with @Public(Evolving): no
The serializers: no
The runtime per-record code paths (performance sensitive): no
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no
The S3 file system connector: no

Documentation

Does this pull request introduce a new feature? no
If yes, how is the feature documented? JavaDocs

@flinkbot approve all
LGTM

+1 to merged
Merging...


getbootstrap.com: npm install instructions get mangled by CloudFlare

If a visitor to the Getting Started page has JavaScript disabled, the instructions for installing Bootstrap with npm are converted from npm install bootstrap@3 to npm install [email protected], with a link to https://getbootstrap.com/cdn-cgi/l/email-protection. Is it possible to disable this protection? I can't find any email addresses on the site that need protecting, so it seems more than a little pointless.

Ping @mdo for Cloudflare access. You'll need to turn Email Address Obfuscation off on this page.

Just fixed it in Cloudflare. I imagine it might take a bit to propagate out and what not.


Bugfix in macro

resolves #356

Description
Add the name of the catalog to the Iceberg CTE to prevent the error. This is already done for the drop table CTE, so I believe this was a bug.
Checklist

[x] I have signed the CLA
[x] I have run this code in development and it appears to resolve the stated issue
[x] This PR includes tests, or tests are not required/relevant for this PR
[x] I have updated the CHANGELOG.md and added information about my change to the "dbt-glue next" section.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

The integration test failed. Could you please fix it?
https://github.com/aws-samples/dbt-glue/actions/runs/8262136038


Service unavailable but process state is up

I'm getting a "Service unavailable" but the processes are up
ID                                              TYPE  STATE  CREATED         RELEASE
ip1002132-4ece72e7-08cb-4937-b9fd-fabd44caf358  web   up     48 minutes ago  3339ebba-0d09-4df8-868d-4532bd96e508
ip1000179-c2ce2a49-62f8-455c-83b4-72b3b0e46838  web   up     38 minutes ago  3339ebba-0d09-4df8-868d-4532bd96e508

In the logs I found some timeouts > 30secs
2016-10-13T19:01:54.572769Z app[web.ip1002132-4ece72e7-08cb-4937-b9fd-fabd44caf358]: source=rack-timeout id=16571b9b-8b2b-4243-8883-436f9818f416 wait=89985ms timeout=30000ms state=expired
2016-10-13T19:01:15.446029Z app[web.ip1000179-c2ce2a49-62f8-455c-83b4-72b3b0e46838]: source=rack-timeout id=71d17b02-6e56-4090-a020-8a64a2e8cf38 wait=50561ms timeout=30000ms state=expired
2016-10-13T19:01:16.777842Z app[web.ip1000179-c2ce2a49-62f8-455c-83b4-72b3b0e46838]: source=rack-timeout id=b449b408-e89f-4e38-a952-0c98d3096e6c wait=50561ms timeout=30000ms state=expired
2016-10-13T19:01:56.559324Z app[web.ip1002132-4ece72e7-08cb-4937-b9fd-fabd44caf358]: source=rack-timeout id=4a57b49c-8c71-41ec-b69f-a496c346b783 wait=89985ms timeout=30000ms state=expired
2016-10-13T19:05:37.294029Z app[web.ip1000179-c2ce2a49-62f8-455c-83b4-72b3b0e46838]: source=rack-timeout id=388e6409-d742-4d50-8352-61825147408d wait=50565ms timeout=30000ms state=expired
2016-10-13T19:06:17.150818Z app[web.ip1002132-4ece72e7-08cb-4937-b9fd-fabd44caf358]: source=rack-timeout id=eef0dcb5-9727-435c-9064-c27a817b0822 wait=89991ms timeout=30000ms state=expired
2016-10-13T19:06:17.725459Z app[web.ip1002132-4ece72e7-08cb-4937-b9fd-fabd44caf358]: source=rack-timeout id=e14a7254-7227-48ba-a23b-75d41ea8609d wait=89990ms timeout=30000ms state=expired
2016-10-13T19:05:38.580842Z app[web.ip1000179-c2ce2a49-62f8-455c-83b4-72b3b0e46838]: source=rack-timeout id=36e20a30-8da3-4449-a3b2-8d25ff8c675d wait=50565ms timeout=30000ms state=expired
2016-10-13T19:05:39.023807Z app[web.ip1000179-c2ce2a49-62f8-455c-83b4-72b3b0e46838]: source=rack-timeout id=4e16b58b-111c-4358-88f9-980751ad7be3 wait=50565ms timeout=30000ms state=expired
2016-10-13T19:05:39.312458Z app[web.ip1000179-c2ce2a49-62f8-455c-83b4-72b3b0e46838]: source=rack-timeout id=4e9d8f31-3522-4495-bf16-d4cda1c7726b wait=50564ms timeout=30000ms state=expired
2016-10-13T19:05:39.920419Z app[web.ip1000179-c2ce2a49-62f8-455c-83b4-72b3b0e46838]: source=rack-timeout id=ca711bde-f795-4a0f-a6b9-5840b179cab1 wait=50564ms timeout=30000ms state=expired
2016-10-13T19:05:40.191876Z app[web.ip1000179-c2ce2a49-62f8-455c-83b4-72b3b0e46838]: source=rack-timeout id=57703167-1659-489e-8c38-7c4a025f89d5 wait=50565ms timeout=30000ms state=expired
2016-10-13T19:06:20.067519Z app[web.ip1002132-4ece72e7-08cb-4937-b9fd-fabd44caf358]: source=rack-timeout id=15fe788a-935f-4e23-be73-dfad2bddb309 wait=89990ms timeout=30000ms state=expired
2016-10-13T19:05:41.249378Z app[web.ip1000179-c2ce2a49-62f8-455c-83b4-72b3b0e46838]: source=rack-timeout id=a44d1618-eb05-49ff-b260-2045f71107e3 wait=50564ms timeout=30000ms state=expired

Is your application listening on $PORT?

Yes port        ENV['PORT']     || 3000 and the app was running fine. The "Service unavailable" appeared maybe 15 minutes after the last deployment

Actually, the whole story is:

I deployed the app for the first time. It was running fine and some minutes later I got the "Service Unavailable"
I ran flynn ps --all and saw some processes down (that's why I opened #3494)
I didn't find a way to restart the app so I scaled up the process to 2 flynn scale web=2
The app was running again
Some minutes later I got the "Service Unavailable" error again

Please post the output of flynn -a router log -n 100. How much memory does the app need?

I didn't do anything and the app is up again.
Output of flynn -a router log -n 100 https://gist.github.com/simon0191/44756d6b126827ac3bfdbf95192dbd11

And "Service unavailable" again

What language/framework/webserver does the app use?

Ruby on Rails and Puma

and I'm using multibuildback to compile some JS assets
https://github.com/heroku/heroku-buildpack-nodejs.git#v91
https://github.com/heroku/heroku-buildpack-ruby.git#v146

Does the app use more than 1GB of memory? You could try bumping the memory limit:
flynn limit set web memory=3GB

What version of puma are you using?

Puma version: puma (2.12.2)
The app was running fine with 512MB in heroku. I just increased the limit to 2GB and now some requests are successful and some respond with "Service unavailable"

You could try bumping to v3.6.0 and setting the persistent_timeout setting to a much higher number, the default of a few seconds could cause what you're seeing (the router might be reusing connections that have just been closed by puma).

It was made configurable in this commit: https://github.com/puma/puma/commit/78d62e975b18c5f764d4bc30381391c45510ce0b

Looks like the app is stable again. Here's what I did:

I updated puma to 3.6.0, made the persistent_timeout 20 (but I think that that's the default)

I removed rack-timeout


Needs tests

It'd be good if there were tests so that I could verify everything is working.

Agreed! I'm planning to add tests and examples and maybe a longer tutorial this week.

I might get into the tests today if @lukewestby has not started yet.

:beers:

@Istar-Eldritch feel free!

@cjhowe @Istar-Eldritch i've added some unit tests (still waiting on a PR to node-elm-test before i can get good coverage on some of the Body stuff), we'll still need integration tests to verify that things work correctly end-to-end and function as working examples for folks. Gonna leave this issue open until those are complete.

I also want to add tests to some of the internal task translation stuff, but we'll wait on that until I can do some restructuring after this is re-released as elm-http-builder for 0.17


Not working on android 5.1 aosp rom

As I mentioned here https://github.com/SebiderSushi/sdcard-w_inject/issues/1#issuecomment-645194452
Logs
Android logs.zip
Im using magisk 20.4

Please refer to the README on what information to include when reporting issues. What you shared seems to include just recovery logs (unrelated) and a Magisk log from a boot where my module was being removed.
Since you say you're running Lollipop, could you also send me the output of ls -Zahl /system/bin/ in addition to the remaining data as mentionen in the README?
To my knowledge the /system/bin/sdcard binary is not used on Lollipop AOSP and should not even be present. In that case, the approach from this module will not work and i do not intend to make it work as another approach would be necessary, which is out of scope of this particular module.
However, as you stated that your storages did not appear when booting with this module installed i am quite confused since this module shouldn't have that effect in the absence of the /system/bin/sdcard binary.

Thanks

So does your system not contain a file at /system/bin/sdcard?
Because i'm still curious how my module could have had any affect at all on a lollipop device.

On another note: Did you already try the ExSDCard module on the Magisk Modules repo?
As far as i know, the method used in that method should work on android Lollipop.

I did some more research and on my OnePlus X, the Lollipop ROMs do, in fact, have an sdcard binary, the -w option was just different back then. I'm just a little puzzled still, since the vold source code from back then i already linked does not mention the /system/bin/sdcard binary in any way.
However, as a consequence, supporting Lollipop could (wasn't able to make it work) be possible with the approach from this module (i.e. by injecting command line options to the /system/bin/sdcard binary which would allow the group for apps with storage permission SD Card write access as well). But the cleaner way on Lollipop is definitely to just make sure your storage apps are being added to the sdcard_rw group which should be granted sdcard write access by default. And that is already done by said ExSDCard module.


suggested improvements

First of all congratulations on the extension.
I had been waiting for something like this for a long time but since I don't know how to program I couldn't do it.
Since I see that you are capable of working with the tool, I am going to ask you what values to add a plugin that I have been waiting for for a long time.
Being able to add the photo of what you want to add
https://huggingface.co/spaces/adirik/ChangeIt

Now change the dress for... these sneakers

and also see the way if you can add something of this
https://huggingface.co/spaces/Fantasy-Studio/Paint-by-Example
https://github.com/Fantasy-Studio/Paint-by-Example

THansk!!

Thanks for your suggestion. In v1.6.0, I have added the Reference-Only Control function to the ControlNet options in the ControlNet Inpaint tab. The Reference-Only Control can be used when the Multi ControlNet setting is configured to 2 or higher.

Thank you very much for taking it into account. As it is, the extension is spectacular. if "reference only" is already included as an image it can be incredible. Let's see if I learn to use it. :) thank you!! :):)


Performance issues when Label has lots of text inside

Hey, I have a simple layout with a TextEdit, Dropdown and Label.
As soon as the rendered string in the Label (whether it is plain text, markdown or html) goes over 5000 chars, all the reactive events get a noticeable slow down.
e.g. when typing into the TextEdit, you can then notice a huge delay.. the same when you select a dropdown item, huge delay
text, text_set = ed.use_state("")
with ed.VBoxView(
    style={
        "align": "top",
    },
):
    with ed.HBoxView():
        ed.TextEdit(
            text,
            on_change=lambda x: text_set(x)
        )

    with ed.VScrollView(style={"align": "top", "padding": "12px"}):
        ed.Label("hello " * 1000, selectable=True, word_wrap=True) # try increase the number to 5k, 10k

Is there a way to mitigate this?

Usually the way to improve performance in Edifice (and React) is by preventing things from re-rendering every time there is an event.
And the usual way to prevent things from re-rendering every time is to wrap them in a new @component. Try making a new wrapper @component for that Label, that might help. A @component will only re-render if its props or its use_state hooks change.


Web view base error

Hi,
Issue with accessing transaction on web browser after installing server on local machine.
Here is the error log
[2018-05-22 17:04:15] [ERROR] (bigchaindb.web.views.base) HTTP API error: 404 - GET:/api/v1/transactions/f78ed7deee65ec6818c25311b7a72a05173b69fb421100837422855c96e0b5d9 - Not found (webapi     - pid: 15199)
bigchaindb-errors.log

One possibility is that the transaction was never posted/sent to the server.
Another possibility is that the transaction was posted, but it was invalid, and therefore discarded.
We will need more information to know for sure what happened.

Hi Thanks for response!!
First I have created transaction and it is showing created transaction on terminal, please find created transaction screenshot and code to create transaction.
But when I access same created transaction in the browser using this url : http://localhost:9984/api/v1/transactions/f78ed7deee65ec6818c25311b7a72a05173b69fb421100837422855c96e0b5d9
showing 404 status as in the attached screenshot

code.txt

I am afraid the transaction is not created as you are getting a 500 error.

We can not really help you with that log. Please check which bigchaindb version you are running, which driver version, and try to see the logs of BigchainDB.

I really don't know what to do next, also find same issue I am facing https://github.com/bigchaindb/bigchaindb/issues/2225, but no solution.

The same code I used, working fine on testnet server but not on my local setup

Can you please check your version of BigchainDB. Are you running BigchainDB using docker? This issue https://github.com/bigchaindb/bigchaindb/issues/2225 was happening for me while posting 60 tx per second. I don't think you have the same issue.
If your script is running properly on the test network and not on your local environment, then you are not running bigchaindb properly. Follow the documentation and update to the latest version of BigchainDB

Below is the screenshot showing the version and errors after the command bigchaindb start!!
Can you please check the errors in attached screenshot and suggest me solution for that

Below is the server configuration, is there anything I am missing??
{
"server": {
"bind": "localhost:9984",
"loglevel": "info",
"workers": null
},
"wsserver": {
"scheme": "ws",
"host": "localhost",
"port": 9985,
"advertised_scheme": "ws",
"advertised_host": "localhost",
"advertised_port": 9985
},
"database": {
"backend": "localmongodb",
"connection_timeout": 5000,
"max_tries": 3,
"ssl": false,
"ca_cert": null,
"certfile": null,
"keyfile": null,
"keyfile_passphrase": null,
"crlfile": null,
"host": "localhost",
"port": 27017,
"name": "bigchain",
"replicaset": null,
"login": null,
"password": null
},
"keypair": {
"public": null,
"private": null
},
"keyring": [],
"backlog_reassign_delay": 120,
"log": {
"file": "/home/bigchain/bigchaindb.log",
"error_file": "/home/bigchain/bigchaindb-errors.log",
"level_console": "info",
"level_logfile": "info",
"datefmt_console": "%Y-%m-%d %H:%M:%S",
"datefmt_logfile": "%Y-%m-%d %H:%M:%S",
"fmt_console": "[%(asctime)s] [%(levelname)s] (%(name)s) %(message)s (%(processName)-10s - pid: %(process)d)",
"fmt_logfile": "[%(asctime)s] [%(levelname)s] (%(name)s) %(message)s (%(processName)-10s - pid: %(process)d)",
"granular_levels": {},
"port": 9020
},
"CONFIGURED": true
}


Create a test runner script in python to run unit tests

Coverage decreased (-0.08%) to 90.074% when pulling b0740bce60182e10dd2ca8012afaed1f1c3e78c1 on test-runner into 032e24b2049075577625282ae5d79d69f99aedff on master.


Video API no longer in beta?

The docs pages I was using, at diffbot.com/docs seem to be outdated from the new ones on docs.diffbot.com. Video doesn't say beta, there's a new Events (beta) API, and a new accounts API.
I might want to check if anything in the bigger API has changed, and remove the (beta) label in my readme.
It also might be a good idea to see if any of the other APIs are different in any way.

It is no longer in beta. 7b82613f3291f00b08bd448d5a35e5072e804fab


Feature - Create Figma design high fidelity

Checklist ✅

[x] The issue is present in the latest release.
[x] I have searched the issues of this repository and believe that this is not a duplicate.

Summary 💡
mockups of the different views with possible functionalities of the admin platform in high fidelity.
Requirements 🌈
model to follow for the construction of the frontend
Motivation 🔦
model to follow for the construction of the front with the possible functionalities (high fidelity).

I have designed all the views of the admin panel. Here is the result


[ADP-3093] Temporarily reenable macOS tests

This pull request temporarily re-enables our macOS tests.

Closing in favor of https://github.com/cardano-foundation/cardano-wallet/pull/4258 .


Non nullable mutation response fix

When trying to generate functions for a schema that had mutations that returned a NonNull object I get the following error in ast.py.
def iter_fields(node):
    """
    Yield a tuple of ``(fieldname, value)`` for each field in ``node._fields``
    that is present on *node*.
    """
    for field in node._fields:

AttributeError: 'tuple' object has no attribute '_fields'

I have tweaked the beasts schema to cover this case and traced the root cause to a branch in recurse_outputtype_annotation() that returns a tuple. I don't think this should happen so I changed this line to return an ast.Name instead.

Thanks a lot sean! Merging now


Document how to use virtualenv and install HyperGAN's dependencies.

This would have helped me when I was starting out. :)

:+1:


MM-13091 Review, improve and test the push proxy docker image

This PR moves the push-proxy Docker scripts from the mattermost-kubernetes into mattermost-push-proxy repo.

After this PR gets approved another PR will handle the removal of the Docker scripts from mattermost-kubernetes repo (https://github.com/mattermost/mattermost-kubernetes)

/check-cla

/check-cla

Is this ready to merge?