Fix type validation in configstore DC client value updating

Fixed a misleading check that was allowing config_store_client#UpdateValue to return no error, despite actually failing the operation and corrupting the dynamic config storage in the process.
Added a more verbose log message when the type check fails, to aid users in understanding the issue.

Why?
This is a temporary change mitigating a more widespread issue described in #5109 -- in summary, inconsistent assumptions about input data types across different implementations of the functions outlined in the Dynamicconfig.Client interface lead to instances in the codebase where the success / failure of calls to a dynamic config client depends on its specific implementation.
By making this change, the config_store_client will no longer attempt to update its values when itsUpdateValue implementation is passed data in the format currently expected by the file_based_config client. This is an improvement because it will stop users inadvertently corrupting their dynamic config, and by consulting the updated log message, they will be informed that they can update their config via the CL instead.
However, long-term, a priority should be addressing issue #5109 and eliminating the inconsistency in this DC client interface.

How did you test it?
Tested locally.

Ran Advanced Visibility Cadence server with the config store dynamic config client enabled (config available in development.yaml)
Added an initial value to the dynamic config for frontend.validSearchAttributes in the CLI: cadence admin config updc --dynamic_config_name frontend.validSearchAttributes --dynamic_config_value '{"Value": '{"testAttribute": 2}',"Filters":[]}'
Verified that the config value has been added: cadence admin config listdc
Triggered the AddSearchAttribute handler: cadence admin cluster asa --search_attr_key testAttribute2 --search_attr_type 2. Note that this handler calls the UpdateValue function with the problematic input data format.
Reran: cadence admin config listdc. The prior set value for frontend.validSearchAttributes remains the same; by constrast, in the current master implementation, the prior set value would be gone.
Checked the Cadence logs, and confirmed that the updated log message shows.

Potential risks
No notable risks from this change; we are simply fixing a type validation so that it serves its intended purpose.

Release notes
Not notable.

Documentation Changes
N/A

@charlese-instaclustr maybe test is failing somehow?

@allenchen2244 good pickup, apologies, the tests picked up an edge case where the update value is nil. Added handling for the edge case to my change if you could rereview please. Thanks

Pull Request Test Coverage Report for Build 0186f18b-64da-446c-b19d-eadac9691f7c

2 of 2 (100.0%)  changed or added relevant lines in 2 files are covered.
9 unchanged lines in 4 files lost coverage.
Overall coverage increased (+0.03%) to 57.109%

Files with Coverage Reduction
New Missed Lines
%

common/task/fifoTaskScheduler.go
2
84.54%

common/task/weightedRoundRobinTaskScheduler.go
2
88.6%

common/util.go
2
52.31%

service/history/execution/mutable_state_task_refresher.go
3
56.65%

Totals

Change from base Build 0186f0f3-f0db-4e0e-ab38-a4ae3852f931:
0.03%

Covered Lines:
85273

Relevant Lines:
149317

💛  - Coveralls


Documents "404 - File not found" for all links including !!! ????

When trying to view the document for Method Interception in "Basic Interceptors >> Method Interception" I'm getting "404 - File not found" for all links including !!! ????

Sorry for that... Last push has deleted the doc folder I think. I was too busy to see that...
Sorry again.


defaultProject field in angular.json doesnt seem to do it's job when running ng g c xyz

🐞 Bug report
Command (mark with an x)
ng generate

[ ] new
[ ] build
[ ] serve
[ ] test
[ ] e2e
[x] generate
[ ] add
[ ] update
[ ] lint
[ ] extract-i18n
[ ] run
[ ] config
[ ] help
[ ] version
[ ] doc

Is this a regression?
Not sure if it worked prior.
Description

I get:
The generate command requires to be run in an Angular project, but a project definition could not be found.

however:
"defaultProject": "desktop-main"

is set in angular.json
🔥 Exception or Error

The generate command requires to be run in an Angular project, but a project definition could not be found.

🌍 Your Environment

     _                      _                 ____ _     ___
    / \   _ __   __ _ _   _| | __ _ _ __     / ___| |   |_ _|
   / △ \ | '_ \ / _` | | | | |/ _` | '__|   | |   | |    | |
  / ___ \| | | | (_| | |_| | | (_| | |      | |___| |___ | |
 /_/   \_\_| |_|\__, |\__,_|_|\__,_|_|       \____|_____|___|
                |___/

Angular CLI: 11.0.4
Node: 15.3.0
OS: darwin x64

Angular:
...
Ivy Workspace:

Package                      Version
------------------------------------------------------
@angular-devkit/architect    0.1100.4 (cli-only)
@angular-devkit/core         11.0.4 (cli-only)
@angular-devkit/schematics   11.0.4 (cli-only)
@schematics/angular          11.0.4 (cli-only)
@schematics/update           0.1100.4 (cli-only)

It appears that you are running the generated command outside of the Angular workspace directory.
Kindly run the generate command in the workspace directory.


[App Service] Fix #25497: az webapp deploy: Fix extension parsing if src-path has multiple '.'s

Related command
az webapp deploy
Description
Changing the file extension parsing logic to work with file paths that have multiple '.'s. Previous logic was written with the assumption that there would only be a single '.' character that splits the file name from the extension.
Testing Guide
az webapp deploy --resource-group [rg-name] --name [app-name] --src-path "[path-to-zip-file]" --type zip
If --src-path has multiple '.'s such as 'test.app.zip' this command used to default to type=static. With this fix, the command will correctly select type=zip when passed the same filename.

This checklist is used to make sure that common guidelines for a pull request are followed.

[X] The PR title and description has followed the guideline in Submitting Pull Requests.

[x] I adhere to the Command Guidelines.

[x] I adhere to the Error Handling Guidelines.

App Service


s3-credentials create name-of-bucket --create-bucket --public fails with error

s3-credentials create test-public-bucket-simonw --create-bucket --public

Created bucket: test-public-bucket-simonw
Traceback (most recent call last):
  File "/Users/simon/.local/bin/s3-credentials", line 8, in <module>
    sys.exit(cli())
  File "/Users/simon/.local/pipx/venvs/s3-credentials/lib/python3.10/site-packages/click/core.py", line 1157, in __call__
    return self.main(*args, **kwargs)
  File "/Users/simon/.local/pipx/venvs/s3-credentials/lib/python3.10/site-packages/click/core.py", line 1078, in main
    rv = self.invoke(ctx)
  File "/Users/simon/.local/pipx/venvs/s3-credentials/lib/python3.10/site-packages/click/core.py", line 1688, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/Users/simon/.local/pipx/venvs/s3-credentials/lib/python3.10/site-packages/click/core.py", line 1434, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/Users/simon/.local/pipx/venvs/s3-credentials/lib/python3.10/site-packages/click/core.py", line 783, in invoke
    return __callback(*args, **kwargs)
  File "/Users/simon/.local/pipx/venvs/s3-credentials/lib/python3.10/site-packages/s3_credentials/cli.py", line 406, in create
    s3.put_bucket_policy(
  File "/Users/simon/.local/pipx/venvs/s3-credentials/lib/python3.10/site-packages/botocore/client.py", line 535, in _api_call
    return self._make_api_call(operation_name, kwargs)
  File "/Users/simon/.local/pipx/venvs/s3-credentials/lib/python3.10/site-packages/botocore/client.py", line 980, in _make_api_call
    raise error_class(parsed_response, operation_name)
botocore.exceptions.ClientError: An error occurred (AccessDenied) when calling the PutBucketPolicy operation: Access Denied

Split from:

#87

My best guess is that AWS changed something and now this code here:
https://github.com/simonw/s3-credentials/blob/6f46d5d97b828894eca4e9018e535ea796f87b68/s3_credentials/cli.py#L376-L378
https://github.com/simonw/s3-credentials/blob/6f46d5d97b828894eca4e9018e535ea796f87b68/s3_credentials/cli.py#L405-L409
Is failing because I should have run this first:
s3.put_public_access_block(
    Bucket=bucket,
    PublicAccessBlockConfiguration={
        "BlockPublicAcls": False,
        "IgnorePublicAcls": False,
        "BlockPublicPolicy": False,
        "RestrictPublicBuckets": False,
    },
)

Here's what a --dry-run looks like now:
s3-credentials create simonw-test-public-access2 --create-bucket --public --dry-run

Would create bucket: 'simonw-test-public-access2'
... then this public access block configuration:
{"BlockPublicAcls": false, "IgnorePublicAcls": false, "BlockPublicPolicy": false, "RestrictPublicBuckets": false}
... then attach the following bucket policy to it:
{
    "Version": "2012-10-17",
    "Statement": [
        {
            "Sid": "AllowAllGetObject",
            "Effect": "Allow",
            "Principal": "*",
            "Action": [
                "s3:GetObject"
            ],
            "Resource": [
                "arn:aws:s3:::simonw-test-public-access2/*"
            ]
        }
    ]
}
Would create user: 's3.read-write.simonw-test-public-access2' with permissions boundary: 'arn:aws:iam::aws:policy/AmazonS3FullAccess'
Would attach policy called 's3.read-write.simonw-test-public-access2' to user 's3.read-write.simonw-test-public-access2', details:
{
    "Version": "2012-10-17",
    "Statement": [
        {
            "Effect": "Allow",
            "Action": [
                "s3:ListBucket",
                "s3:GetBucketLocation"
            ],
            "Resource": [
                "arn:aws:s3:::simonw-test-public-access2"
            ]
        },
        {
            "Effect": "Allow",
            "Action": [
                "s3:GetObject",
                "s3:GetObjectAcl",
                "s3:GetObjectLegalHold",
                "s3:GetObjectRetention",
                "s3:GetObjectTagging"
            ],
            "Resource": [
                "arn:aws:s3:::simonw-test-public-access2/*"
            ]
        },
        {
            "Effect": "Allow",
            "Action": [
                "s3:PutObject",
                "s3:DeleteObject"
            ],
            "Resource": [
                "arn:aws:s3:::simonw-test-public-access2/*"
            ]
        }
    ]
}
Would call create access key for user 's3.read-write.simonw-test-public-access2'

And debug-bucket against a bucket created with those options:
s3-credentials debug-bucket simonw-test-public-access2

Bucket ACL:
{
    "Owner": {
        "DisplayName": "swillison",
        "ID": "36b2eeee501c5952a8ac119f9e5212277a4c01eccfa8d6a9d670bba1e2d5f441"
    },
    "Grants": [
        {
            "Grantee": {
                "DisplayName": "swillison",
                "ID": "36b2eeee501c5952a8ac119f9e5212277a4c01eccfa8d6a9d670bba1e2d5f441",
                "Type": "CanonicalUser"
            },
            "Permission": "FULL_CONTROL"
        }
    ]
}
Bucket policy status:
{
    "PolicyStatus": {
        "IsPublic": true
    }
}
Bucket public access block:
{
    "PublicAccessBlockConfiguration": {
        "BlockPublicAcls": false,
        "IgnorePublicAcls": false,
        "BlockPublicPolicy": false,
        "RestrictPublicBuckets": false
    }
}

And uploading a file to it:
s3-credentials put-object \
  simonw-test-public-access2 chicken.png \
  ~/Desktop/Archive/black_and_white_spotted_chicken,_realistic_photo,_garden.png

Resulted in:
https://s3.amazonaws.com/simonw-test-public-access2/chicken.png
So this worked.


Don't start file write if not needed

The file writer thread is a  100% CPU usage while loop that checks for file changes. This is questionable already and might be improved by a sleep interjection, but this is for another PR.
This PR simply suggests that if the access mode to the DB is "r" = read-only, then we do not need to run this 100% CPU load thread anyways.

Are you planning to bring another PR with a sleep injection, or perhaps another solution (Event()?) ?

I am not sure what kind of solution would generalize best to all use cases. I wrote a simple version that sleeps for 1 second every iteration but can imagine cleaner/simpler/more general ways.
Not planned to make that a PR hence


Adding myself to contributor's page

sending the new pull request again. closing this for now. (will open separate issue for commit https://github.com/arcolife/crowdsource-platform/commit/c8c397c2dc188a41307bf1a7971326ea71685389


[SPARK-27829][SQL] In Dataset.joinWith inner joins, don't nest data before shuffling

What changes were proposed in this pull request?
In order to support outer joins with null top-level objects, SPARK-15441 modified Dataset.joinWith to project both inputs into single-column structs prior to the join.
For inner joins, however, this step is unnecessary and actually harms performance: performing the nesting before the join increases the shuffled data size. As an optimization for inner joins only, we can move this nesting to occur after the join (effectively switching back to the pre- SPARK-15441 behavior; see #13425).
How was this patch tested?
Existing tests, which I strengthened to also make assertions about the join result's nullability (since this guards against a bug I almost introduced during prototyping).

Test build #105750 has started for PR 24693 at commit 33bb4af.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/11005/
Test PASSed.

Test build #105750 has finished for PR 24693 at commit 33bb4af.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/105750/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/11008/
Test PASSed.

Test build #105753 has started for PR 24693 at commit ec2bb32.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/11010/
Test PASSed.

Test build #105755 has started for PR 24693 at commit ec4d785.

Test build #105753 has finished for PR 24693 at commit ec2bb32.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/105753/
Test PASSed.

Test build #105755 has finished for PR 24693 at commit ec4d785.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/105755/
Test PASSed.

@cloud-fan, could you take a look at this change since you worked on the PR which originally introduced the nesting here?

thanks, merging to master!


Add a redirect for the virus scanning page that Google has indexed

Google has indexed the old URL (manual/virus-scanning.html) and so
it 404s. Redirect to what appears to be the actual page.

Naughty Google.  They need some sort of link checker 🤔


clap wrapper target lib rename changes continued

Fix a target which had missed the rename sweep (due to merge order difference)
Rename the AUv2 targets symmetrically with the VST3 ones

Thanks, Paul


Travis CI: The sudo tag is now deprecated

Travis are now recommending removing the sudo tag.
"If you currently specify sudo: false in your .travis.yml, we recommend removing that configuration"

Closing in favor of #113


pythonPackages.setuptools_scm: 1.15.0 -> 1.15.5

Also add missing dependencies
Motivation for this change
The packages is broken as it stands.
Things done

[X] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[X] NixOS
[ ] macOS
[ ] Linux

[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[X] Fits CONTRIBUTING.md.

The packages is broken as it stands.

What is broken?

Using this as a build input without also specifying git or mercurial.
On 7 May 2017 at 19:59, Frederik Rietdijk<EMAIL_ADDRESS>wrote:

The packages is broken as it stands.
What is broken?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/NixOS/nixpkgs/pull/25581#issuecomment-299726936, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAt6pSGN0WGTXPSPUMDspzr0YYWngmiSks5r3hSQgaJpZM4NTO6j
.

--
Arthur Noel
<EMAIL_ADDRESS>+44 (0)7967 385514

This is still a problem - comment out the propagatedBuildInputs line and you will see test failures.
Just rebased off master and updated from 15.5.5 to 15.5.6.

How do you work with this package?

Using this as a build input without also specifying git or mercurial.

Alright, then it indeed makes sense. Note that with the current infra we cannot add mercurial as propagatedBuildInput because it will mess up PYTHONPATH.

OK, I'll pull it out
It might be nice to add a little comment explaining why - could you expand
on the PYTHONPATH issue?
On 23 Jul 2017 11:11, "Frederik Rietdijk"<EMAIL_ADDRESS>wrote:
Using this as a build input without also specifying git or mercurial.
Alright, then it indeed makes sense. Note that with the current infra we
cannot add mercurial as propagatedBuildInput because it will mess up
PYTHONPATH.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/NixOS/nixpkgs/pull/25581#issuecomment-317242537, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAt6peha1frKRpSJOi08GihAy0wySnoKks5sQxxCgaJpZM4NTO6j
.

Sorry, don't bother, I see the problem now I think about it.

The issue is that mercurial is implemented in Python. We still need to properly isolate Python applications like mercurial.

Thinking again, the propagatedBuildInputs get put on PYTHONPATH, but setuptools_scm should only ever be referenced in buildInputs, so this shouldn't be an issue I think?
I've just reviewed usage of setuptools_scm and fixed the instances where is is referenced in propagatedBuildInputs.

Before I rebase again, are you happy in principle to merge this?

84c6e6b4d708faae843ea00a2335dd80b57fd107 is in, but it doesn't include the extra dependencies.
Adding git as propagatedBuildInput is fine, but adding mercurial is not due to the mentioned isolation.
Although, a good solution that will work is replacing in the following file calls to git with the full path, and the same in for mercurial in https://github.com/pypa/setuptools_scm/blob/v1.15.6/setuptools_scm/hg.py.
If you want to pursue this I suggest you ask @RonnyPfannschmidt if he is willing to introduce GIT = "git" and `HG = "hg" so that we only need to replace those two lines.

as far as i understood its only needed for the builds from scm repos its not needed to propagate
its not quite clear why build only requitrements need to propagate, just add them to PATH in the build


Only receiving single error when using "Standalone validation code" in AJV ?

I have used compiled time schema as per https://ajv.js.org/standalone.html.
const compiledSchema = require('src/assets/json/validate_schema.js');
const valid = compiledSchema(catalogObj);
console.log("compiledSchema.errors:", compiledSchema.errors)
I am receiving only first error only. How to get all errors when using compiled schema ?

I have added --all-errors while running CLI command and that works hence closing this issue.


Bug(Slider): Slider in vertical orientation does not work

Hi! I realise the slider UI is not correct under the vertical orientation:
<Slider
  orientation="vertical"
  onValueChange={...}
  value={...}
  min={0}
  max={100}
/>

In the source code, I realise the data-[orientation=vertical] is not utilised in CSS styles?

@xmliszt still no fixes for this?

@xmliszt still no fixes for this?

let me add in vertical orientation support over this weekend

@xmliszt still no fixes for this?

I think @rishabhbizzle  has a fix in the PR, but anyway I will also look into this. The PR needs @shadcn team to approve

This issue has been automatically closed because it received no activity for a while. If you think it was closed by accident, please leave a comment. Thank you.

This isn't resolved, should not be closed.

‼ The issue is still not resolved ‼

Its still not closed 😢


Update 04-02-association-and-plural-publics.md

Added information about Threads launching and the plan to begin interoperating using ActivityPub with the Fediverse.

There is a conflict here; can you please resolve and resubmit?


Is this alive?

Hi there,
I like this chart
But the last update 9month ago..
Will you continue?

Hi, yes this is alive. I have plans to add more chart types, but because of my tight schedule, I am not able to get time for it for so long. If you want, you can also contribute to it. Just raise a PR if you want


Add Pulumi Function Serialisation by Example

Interesting deep dive into how Pulumi serialises inline lambda code.

@marksmithson thank you to submit this interesting article. 👍🏻


[Web] Keyboard arrow keys does not work inside a ScrollView

When the QuillEditor is a child of SingleChildScrollView, cannot move the cursor with keyboard arrow keys.

Don't make it a child of SingleChildScrollView
Not our problem

Found a workaround:
Wrap QuillEditor with a RawKeyboardListener to intercept KeyEvent and prevent it from propagating to parents.
SingleChildScrollView(
        child: RawKeyboardListener(
              onKey: (RawKeyEvent event) {},
              focusNode: FocusNode(onKey: (FocusNode node, RawKeyEvent event) {
                  return KeyEventResult.skipRemainingHandlers;
              }),
              child: QuillEditor(
                    ...
              ),
       ),
)

Found a workaround:
Wrap QuillEditor with a RawKeyboardListener to intercept KeyEvent and prevent it from propagating to parents.
SingleChildScrollView(
        child: RawKeyboardListener(
              onKey: (RawKeyEvent event) {},
              focusNode: FocusNode(onKey: (FocusNode node, RawKeyEvent event) {
                  return KeyEventResult.skipRemainingHandlers;
              }),
              child: QuillEditor(
                    ...
              ),
       ),
)

I was trying to create shortcuts to toggle bold and italic using FocusableActionDetector. But because of this workaround, I think the shortcut events are not triggered. I was thinking, it would be a really nice option to provide actions and shortcuts directly from the library.
Or can anyone suggest another approach to create shortcuts while using the editor?


quark-engine: relax prompt-toolkit constraint

Motivation for this change
Fix build (https://hydra.nixos.org/build/163299212)
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 153726 run on x86_64-linux 1

1 package built:

quark-engine


Remove the signchromium target from make.js

According to the IRC discussion starting at http://logs.glob.uno/?c=mozilla%23pdfjs&s=18+Apr+2017&e=18+Apr+2017#c59676, and in particular http://logs.glob.uno/?c=mozilla%23pdfjs&s=18+Apr+2017&e=18+Apr+2017#c59682, this build target is unused and can thus be removed.

Nice clean-up!


Warnings fixed when compiling with iOS 7>

Deprecated warnings have been fixed; library can be used with iOS 6 < and also works fine with iOS 7 >; Could you please serve check this PR and merge if it looks fine to you.
Thanks.

Have anyone had chance to check this out?
Thanks.

Checking it our right now

Thank you...

Merged. ill push to cocoapods soon

Great!! See you around ;)


Hi!

Version
@vueup/vue-quill version [e.g. 1.0.0-beta.6]
Describe the bug
interactive toolbar elements is not working. So i am trying with basic usage and seems like i can not change font size, first drop down is not working
To Reproduce
Steps to reproduce the behavior:
i just tried to use  <quill-editor :theme="'snow'"></quill-editor> with default toolbar  and 'Normal' is not clickable in chrome. But demo works fine for me. In firefox everything ok

Browser (please complete the following information):

Browser chrome version 91.0.4472.77

Thanks!

Hmm, I'm not sure about this problem, because I tested it and it works:
https://codesandbox.io/s/vue-quill-text-editor-forked-5jhod?file=/src/App.vue

@luthfimasruri seems like problem with browser, dont know exactly what happened but reinstall helps me. Thanks for sandbox!


Add tests for FavouriteCommand, FavouriteCommandParser, ListCommand, ListCommandParser, DeleteAppointmentCommand, DeleteAppointmentCommandParser

#250

Codecov Report

Merging #284 (a04034b) into master (871ce2f) will increase coverage by 1.20%.
The diff coverage is 66.66%.

@@             Coverage Diff              @@
##             master     #284      +/-   ##
============================================
+ Coverage     60.67%   61.88%   +1.20%
- Complexity      690      701      +11
============================================
  Files           123      123
  Lines          2670     2676       +6
  Branches        335      337       +2
============================================
+ Hits           1620     1656      +36
+ Misses          920      888      -32
- Partials        130      132       +2

Impacted Files
Coverage Δ
Complexity Δ

...seedu/address/logic/commands/FavouriteCommand.java
88.88% <0.00%> (+88.88%)
6.00 <1.00> (+6.00)

...u/address/logic/parser/FavouriteCommandParser.java
100.00% <100.00%> (+100.00%)
5.00 <0.00> (+5.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 871ce2f...a04034b. Read the comment docs.

Added more tests


Use memcmp to improve ForEachStore's performance

This PR's proposes to use memcmp to return early if the identifiers of a ForEachStore can't be different. This should improve the rendering performance when the IdentifiedArray's identifiers are unchanged.
With the current approach, ForEachStore's internal ViewStore compares OrderedSet<ID>'s using the canonical == to decide if successive values it receives are duplicate or not. OrderedSet stack memory consists of two pointers to some internal reference type storage. Because OrderedSet is Copy-on-Write, a copy of this private storage is performed when an OrderedSet is mutated, and this mutated OrderedSet gets new pointers to its own storage. For this reason, if two OrderedSets are sharing the same pointers, their content can't be different. Comparing these references is fast and allows us to respond very quickly by the affirmative in this occurrence.
In any case pointers differ, the comparison falls back to == where elements are checked one by one, as it is currently performed.
As an example, here are the results when comparing:

Two independent OrderedSet values of 10000 Ints with the same elements.
A given OrderedSet of 10000 Int's with itself (or a non-mutated "copy").

name                         time          std        iterations
----------------------------------------------------------------
Current, same elements       149583.000 ns ±   4.16 %       9211
PR, same elements            149583.000 ns ±   4.31 %       9227

Current, same OrderedSet     149542.000 ns ±   4.63 %       9220
PR, same OrderedSet              42.000 ns ± 247.31 %    1000000

In all these cases, the isDuplicate comparison returns true.
This shouldn't affect noticeably the comparison performance of OrderedSet with different elements.
This approach should work as long as ID is a value type, or an immutable reference type.
It can't really be applied to general ViewStores where the state's behavior on mutation is unknown.

@tgrapperon Awesome work buddy. This is a great improvement!

Would this be something for swift-collections as well?

This is possible, but it maybe has some very intricate side-effects in the general picture that I'm not prepared to delve into, especially if I would need to discuss it in Swift forums[^1]. I've asked Karoy Lorentey on Twitter about the change, but the tweet format was maybe too short to detail the use case and implementation[^2]. According to his response, this check should already be performed. However, the two last benchmarks and the code suggest that this isn't the case.
Because we're falling back to == in case of discrepancy, the only case where it would be problematic for us would be if it would return 0 (hence true) with the two values containing different elements. Because OrderedSet has a value semantic, this is not possible, as it would mean that the same private storage would be containing different elements at the same time.
[^1]: For example, if implemented from the library, one has access to the storage, and one can rely on direct pointer comparison instead of memcmp. It's also possible that this can be applied to other types in swift-collection, etc.
[^2]: I understand that you can't start to randomly recommend low-level tricks on Twitter when you're in his position. It was already very kind from him to respond.

Awesome find @tgrapperon!


Any advice on how to handle a widget with a UITextView inside it?

General information

JSQMessagesViewController version:
iOS version: 10.2.1
Devices/Simulators: device
Reproducible in the demo project? (Yes/No): No
Any related issues: -

What happened?
I'm doing a heavy customization on JSQMessagesViewController, including custom cells that have UITextView inside it. Everything looked ok on the simulator and then I tried it on a device. See this bug video.

Hello everyone!
I'm sorry to inform the community that I'm officially deprecating this project. 😢 Please read my blog post for details:
http://www.jessesquires.com/blog/officially-deprecating-jsqmessagesviewcontroller/
Thus, I'm closing all issues and pull requests and making the necessary updates to formally deprecate the library. I'm sorry if this is unexpected or disappointing. Please know that this was an extremely difficult decision to make. I'd like to thank everyone here for contributing and making this project so great. It was a fun 4 years. 😊
Thanks for understanding,
— jsq


Option switch to choose if minifying or not

🚀 Feature
Adding a new param in the config file to choose if we want to minify the code during building or not.

[x] I have read the Contributing Guidelines on issues?

Unminified code is not a problem for low traffic websites where the bandwidth will not be a problem if serving unminified code.
Pitch
See motivation. Reading the optional param in the config file, instead of blindly minifying.

Try filing this on https://v2.docusaurus.io/feedback


ja: fix inconsistent translation of "init container"

This is a Bug Report

Problem:
/language ja
I found an inconsistent translation of "init container" in /ja/docs/concepts/workloads/pods/init-containers/ and  /ja/docs/tasks/debug-application-cluster/debug-init-containers/.
On the concept page, it is expressed as "Initコンテナ".
But on the task page, it is expressed as "Init Container".
What do you think about it? Which expression is better or others?
Proposed Solution:
In my opinion just a direct expression "Init Container" is better for the Japanese to understand that it is a term of k8s.
Page to Update:
https://kubernetes.io/ja/docs/concepts/workloads/pods/init-containers/
or
https://kubernetes.io/ja/docs/tasks/debug-application-cluster/debug-init-containers/

/assign

/close


Which permissions does the github token require?

@simonweil - you can take a look at this comment

Thanks @kunalnagar


⚠ Bofrost.lu has degraded performance

In 5bf13d5, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1992 ms

Resolved: Bofrost.lu performance has improved in a6951ce after 9 minutes.


Addressed technical debt on accessing options

No review needed.

Coverage remained the same at 37.528% when pulling 34832d3915fc678ad4fe8d38116c8f2fc977f2b9 on andy/fix-options-2 into 09f6e4da7d3384bf4906b546b44b66e9a5d7067d on master.


Add toml to dependency list

It's used in pessimist.util, and no longer in transitive deps.

I'm pretty sure there's a static analysis tool (not this or importall) that ensures the toplevel names you're importing are available in the first-order deps.  Sigh.


Implement Oklab and Oklch

Oklab is a simple perceptual color space that aims to be a more uniform replacement of CIE Lab. It mostly delivers on that goal in its intended use of D65 whitepoint SDR colors.
Oklch is natural cylindrical variant of Oklab. The author also had the idea of a sRGB-in-Oklch boundary in gamut mapping, which I mentioned in #221.
The basic XYZ-to-oklab definition is based on an assumption of D65 whitepoint. Any chromatic adaptation would be an extension. For that I recommend going with the CAM16-UCS matrix, since that's where its data for fitting comes from (Bradford is probably close enough too). (You could use the pseudo-LMS implied by the M1 matrix to do that, but it's not designed for that purpose and there's probably no real computational savings.)
(I am super fine with putting this off until we figure out how to write less boilerplate. In my dream world you would just tell a very intelligent thing which are which, but macros need humans to write too.)

Implemented in #200.


Added nrfjprog support to Adafruit feather nrf52840 board

The Adafruit Feather nrf52840 has a jlink port that can be used for flashing and debugging.
This patch adds the support for it.

This patch should be applied directly to upstream zephyr https://github.com/zephyrproject-rtos/zephyr/ since that is where the board is. Then these changes will be picked up and reflected here.

Closing this PR, needs to be submitted upstream.


EngSys changes for rename of master branch

This issue/epic is to group together all the changes that will be required across the engineering system when we eventually rename the master branch to main (or whatever we choose). Some of this work may be able to be done ahead of the transition through use of parameters/variables where other changes will need to be merged simultaneously with when the branch rename occurs. There are still some unknown unknowns but this is the list that I can see so far:

[ ] Change references to master in all the ci.yml/test.yml files.
[ ] Search all scripts that have baked in assumptions about master branch
[ ] We have some of our archetype templates which switch behaviors based on master branch
[ ] Switch all of the pipelines branch defaults to refs/heads/main
[ ] Any updates to Pipeline Generator??
[ ] Updates to health metrics reports that filter/refer to master
[ ] Updates to resources sections in YAML files
[ ] Should we also be renaming the master branch in azure-sdk-build-tools?
[ ] Code generation configurations (multiple locations)
[ ] Links. We have direct links to things in our master repo in lots of places from our github.io to docs.microsoft.com to blogs to other places. Depending on features we get from git/github we might need to leave the master branch around to preserve these links, at least for now.
[ ] When we make the switch all active pull requests targeting master will need to be closed and retargeted.
[ ] We will need documentation to help guide folks how to fix their forks and local clones. Also probably helpful to given instructions on how to fix any branches they have work in.

We are going to need to think through the impact from a servicing perspective too. If we rename, will it break some of our old versions of build pipelines. We'll probably need to maintain a list of common issues when we do servicing so folks can get the pipelines up and running again when servicing is required.
What did I miss?

SDK Automation config should be updated from our side.

Other things that will be broken:

[ ] Links. We have direct links to things in our master repo in lots of places from our github.io to docs.microsoft.com to blogs to other places. Depending on features we get from git/github we might need to leave the master branch around to preserve these links, at least for now.
[ ] When we make the switch all active pull requests targeting master will need to be closed and retargeted.
[ ] We will need documentation to help guide folks how to fix their forks and local clones. Also probably helpful to given instructions on how to fix any branches they have work in.

Thanks Wes.

I guess we will have some time with main and master exist together if github/git don't have anything to help. In that case maybe we should have a list of things to do in order.

I think that having main and master co-exist for a period of time might be a really good approach. Perhaps we could have a model where we continue getting everyone committing to refs/heads/master but then repoint refs/heads/main to the latest master in automated way. Then we start transitioning all of our automation to work off refs/heads/main ... such as live test runs and other tooling like pipeline generator etc.
/cc @weshaggard thoughts on this approach?

I definitely think that would be a reasonable approach that we would likely need to take. However I'd like to not do any movement until the larger git and/or github decision is made and designed/implemented as the last thing we want to do is move twice because they ended up with a different design.

Agreed. Holding pattern for now until we see the fruits of the work that GitHub is doing.

GitHub has put out their guidance: https://github.com/github/renaming
There is also some internal 1ES guidance which I won't link here. Its not super urgent, but is important so I'll read through the material that has now been provided and see how that impacts our list above.

Have a pipeline to find all occurrences of master. https://dev.azure.com/azure-sdk/playground/_build/results?buildId=732192&view=results
It is currently scanning azure-sdk-tools repo. Able to scan other repos by changing the Clone repo step.

Master branch impact analysis

One thing that I thought of was that we possibly have quite a few links that point to master out there in the wild. We need to figure out whether the GitHub rename mechanism creates a synonym for the branch to avoid broken links.

Update, looks like GitHub handles the broken link scenario (yay!):

Source: https://github.com/github/renaming


[Broken] YouTube: Removed channels redirect to homepage when cookies are provided

Checklist

[x] I'm reporting a broken site support
[x] I've verified that I'm running yt-dlp version 2<IP_ADDRESS>
[x] I've checked that all provided URLs are alive and playable in a browser
[x] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[x] I've searched the bugtracker for similar issues including closed ones

Verbose log

$ yt -s --cookies ~/cookies.txt -vvv 'https://www.youtube.com/user/ForensicFilesChannel'
[debug] Command-line config: ['-s', '--cookies', 'cookies.txt', '-vvv', 'https://www.youtube.com/user/ForensicFilesChannel']
[debug] Loading archive file None
[debug] Encodings: locale UTF-8, fs utf-8, out utf-8, pref UTF-8
[debug] yt-dlp version 2<IP_ADDRESS>
[debug] Python version 3.9.2 (CPython 64bit) - macOS-10.15.7-x86_64-i386-64bit
[debug] exe versions: ffmpeg 4.3.2, ffprobe 4.3.2, phantomjs 2.1.1, rtmpdump 2.4
[debug] Proxy map: {}
WARNING: A channel/user page was given. All the channel's videos will be downloaded. To download only the videos in the home page, add a "/featured" to the URL
[youtube:tab] ForensicFilesChannel: Downloading webpage
[download] Downloading playlist: ForensicFilesChannel
[youtube:tab] ForensicFilesChannel page 1: Downloading API JSON
[youtube:tab] ForensicFilesChannel page 2: Downloading API JSON
[youtube:tab] ForensicFilesChannel page 3: Downloading API JSON
[youtube:tab] ForensicFilesChannel page 4: Downloading API JSON
[youtube:tab] ForensicFilesChannel page 5: Downloading API JSON
[youtube:tab] ForensicFilesChannel page 6: Downloading API JSON
[youtube:tab] ForensicFilesChannel page 7: Downloading API JSON
[youtube:tab] ForensicFilesChannel page 8: Downloading API JSON
[youtube:tab] ForensicFilesChannel page 9: Downloading API JSON
[youtube:tab] ForensicFilesChannel page 10: Downloading API JSON
[youtube:tab] ForensicFilesChannel page 11: Downloading API JSON
[youtube:tab] ForensicFilesChannel page 12: Downloading API JSON
[youtube:tab] ForensicFilesChannel page 13: Downloading API JSON
[youtube:tab] playlist ForensicFilesChannel: Downloading 333 videos
[download] Downloading video 1 of 333
...

Description

https://www.youtube.com/user/ForensicFilesChannel
There used to be a channel located at this URL which has since been hidden or deleted. Without --cookies, it responds with a 404 page and behaves as expected.
When --cookies are provided, the URL will redirect to another page instead. Depending on whether the associated Google account has set up a YouTube channel or not, it appears that the redirect ends up either on the user's own channel or the YouTube homepage with a prompt asking if you want to create a YouTube channel. In the latter case, yt-dlp starts downloading videos from the YouTube homepage instead. This is obviously not what the user intended.
When a URL for what turns out to be a deleted channel is provided, it would probably be better not to follow redirects to these locations and instead show an error message.

The issue is that youtube does not give any indication that the channel doesn't exist before redirecting. afaik there is no way to differentiate this from an actually valid redirect

If a link to a specific channel is given, I would assume that the only useful redirect in this situation from a yt-dlp user's perspective would be to the same channel under a new name.
It seems like yt-dlp could choose to ignore any other unwanted redirect based on where it leads, such as when the destination is the YouTube homepage. I don't think it'd break any legitimate use case if a URL like  'https://www.youtube.com/user/ForensicFilesChannel' was prevented from redirecting to the YouTube homepage.

https://www.youtube.com/user/ForensicFilesChannel redirects me to https://www.youtube.com/channel/UCKcqXmCcyqnhgpA5P0oHH_Q
https://www.youtube.com/AsapSCIENCE redirects to https://www.youtube.com/channel/UCC552Sd-3nyi_tk2BudLUzA
The issue is how to distinguish these two cases

It looks like there's a 303 redirect to https://www.youtube.com/profile in the former case when the target is your own channel. Could we simply cancel the redirections if 'https://www.youtube.com/profile' is part of the chain (in addition to when the target is non-channel locations such as the YouTube homepage)?

There are many invalid youtube URLs that redirect back to the home page. (Eg: https://www.youtube.com/playlist?list=notaplaylist) It is impossible to fix for all such cases. Not to mention that youtube changes these redirect behaviors on a whim.

Interesting - that link does not actually perform a redirect to the home page. It includes the video listing from the home page while remaining on the playlist URL. We could probably detect this special case by looking at the markup, but assuming that this only happens for URLs that don't follow the pattern of _PLAYLIST_ID_RE this should be very rare.
We could at least try to solve it for playlists which have been valid/existed at one point. Based on the examples so far, I believe the following rule would help:
If the provided URL matches that of a valid playlist/channel/user page and responds with HTTP code...

200

Download the playlist.

303

Follow the chain of redirects. If the chain leads to a path matching / or /profile, throw an error. This not the playlist you're looking for.

404

Throw an error. There is no playlist here.

Can you think of a situation where this would cause problems, or other special cases to consider?

The redirect itself is handled by libraries. Modifying it to do conditional redirects is very difficult
I had discussed the matter with @colethedj  and we could not find any other reliable way to fix this.
I honestly don't want to spend too much effort on what is essentially a youtube bug - especially one that is only an issue in these edge cases.
In general, if the URL doesn't work as expected in browser, don't expect it to work in yt-dlp.

I see. I regularly archive a set of around 8300 channels and playlists so I can't always be there to actively watch the process and see if it starts downloading unrelated videos because a page has disappeared.
But I can certainly also understand your desire to not add further complexity/maintenance burden to the already complex YouTube extractor, so I'm fine with writing my own script to detect when unrelated videos start being downloaded. You can close the issue if you want. Thanks for the discussion!

I do understand your issue. I will keep this open in case someone else wants to try their hand at fixing this.
In the meantime, I recommend you use either channel URLs or direct URLs instead of User ones.

https://www.youtube.com/ForensicFilesChannel does not cause this issue.
Invalid channel URLs like https://www.youtube.com/channel/UCKcqXmCcyqnhgpA5P0oHH_s also give correct message.
The issue is only when using /user/ URLs

Ah, I had no idea that made a difference. Do all /user/ URLs have that equivalent at the root path? If so, I'm tempted to suggest that yt-dlp does that rewrite automatically. Either way, thanks for the tip. That's very helpful :-)

Do all /user/ URLs have that equivalent at the root path

No. See https://support.google.com/youtube/answer/6180214

Think YouTube has fixed this issue - I now get a 404 page when logged in when I go to https://www.youtube.com/user/ForensicFilesChannel.
[debug] Command-line config: ['--flat-playlist', '--verbose', '--cookies', '~/Desktop/cookies.Youtube.txt', 'https://www.youtube.com/user/ForensicFilesChannel']
[debug] Encodings: locale UTF-8, fs utf-8, out utf-8, pref UTF-8
[debug] yt-dlp version 2<IP_ADDRESS> (source)
[debug] Plugin Extractors: ['SamplePlugin']
[debug] Git HEAD: 5a9aae9e5
[debug] Python version 3.9.2 (CPython 64bit) - Linux-5.10.23-1-MANJARO-x86_64-with-glibc2.33
[debug] exe versions: ffmpeg 4.3.2, ffprobe 4.3.2, rtmpdump 2.4
[debug] Proxy map: {}
[youtube:tab] ForensicFilesChannel: Downloading webpage
WARNING: A channel/user page was given. All the channel's videos will be downloaded. To download only the videos in the home page, add a "/featured" to the URL
ERROR: Unable to download webpage: HTTP Error 404: Not Found (caused by <HTTPError 404: 'Not Found'>); please report this issue on https://github.com/yt-dlp/yt-dlp . Make sure you are using the latest version; see  https://github.com/yt-dlp/yt-dlp  on how to update. Be sure to call yt-dlp with the --verbose flag and include its complete output.
  File "/home/colethedj/Development/yt-dlp/yt_dlp/extractor/common.py", line 666, in _request_webpage
    return self._downloader.urlopen(url_or_request)
  File "/home/colethedj/Development/yt-dlp/yt_dlp/YoutubeDL.py", line 2822, in urlopen
    return self._opener.open(req, timeout=self._socket_timeout)
  File "/usr/lib/python3.9/urllib/request.py", line 523, in open
    response = meth(req, response)
  File "/usr/lib/python3.9/urllib/request.py", line 632, in http_response
    response = self.parent.error(
  File "/usr/lib/python3.9/urllib/request.py", line 561, in error
    return self._call_chain(*args)
  File "/usr/lib/python3.9/urllib/request.py", line 494, in _call_chain
    result = func(*args)
  File "/usr/lib/python3.9/urllib/request.py", line 641, in http_error_default
    raise HTTPError(req.full_url, code, msg, hdrs, fp)

Though invalid playlist urls still redirect to a broken home https://www.youtube.com/playlist?list=notaplaylist.


Input box resizing can have some wonky behavior

This generally doesn't really impact use and is mostly a nitpick, but it'd be nice to bound the input box to the edge of the image so that it remains easily selectable.

wonkiness hopefully fixed with Shiny interface


Changed ForceClient._serviceHttpClient to protected

Issue #211 - Changed ForceClient._serviceHttpClient to protected so that the ForceClient class can be extended.

This particular update will fail based on subsequent changes to the ServiceHttpClient (which is now JsonHttpClient). I'm going to close this PR but I'll make the change to resolve your issue.


DINO onnx conversion

Hi,
I am currently working on ONNX conversion for DINO model. The MSDeformAttention function is currently implemented only on GPU which causes error while conversion of the model. Is there any workaround for this?

We did not try onnx before, so currently, we could not offer any suggestions.

@Simardeep27 @FengLi-ust  ME too.
I Gusess OpenMMLab mmdeploy maybe a walk around as it supports DETR and DeformableDETR. And DINO is integrating now. https://github.com/open-mmlab/mmdetection/pull/9149


Unable to delete bookmarks

Attempting to delete a bookmark throws the following error:

Edit: This seems to only be the case if you delete/move the original file that the bookmark is pointed to. Restoring the file does not fix the issue.

Thanks for pointing that out, that is definitely a bug and I will look into it. 👍

Testing on Version 1.1.0, it seems the issue persists for specific file paths.
Deletion of bookmarks seem to work on file paths outside of the Program Files (x86).
For example, I stored .XML files on C:\Users\xxx\Desktop which functions as intended and allows deletion, however, when stored in:
 D:\Program Files (x86)\Steam\steamapps\common\Dwarf Fortress\LegendsBrowser
The issue persists:

Tested on 1.1 issue persists, can't delete world bookmarks after deleting xml files manually. Where is this data cached, there should be a 'reset' feature.

https://github.com/Kromtec/LegendsViewer-Next/issues/35#issue-2679343253

I am still investigating why this happens, because it does not for me.
For now you can go to the file %AppData%\LegendsViewer\bookmarks.json and

delete the whole file to clear all bookmarks, or
if you are familiar with json files, alter it and delete only the book marks you no longer want


Devicelab Mac4 is dead

Mac4 has been dead since a failure on 08/22/2021
Dead | Bot has been missing longer than 10 minutes

https://chromium-swarm.appspot.com/bot?id=flutter-devicelab-mac-4

I will be in the lab this afternoon, will look at it.

Rebooted the host, and its now recovered and running jobs.


Problem with https://kubernetes.io/docs/tasks/administer-cluster/ip-masq-agent/ after Hugo conversion

Most of the page content is truncated, as you can see when you view the source. I couldn't immediately figure out what's wrong, but I suspect it's with the Hugo short tags.

The button at the bottom of the page to create a new issue results in a 404 instead of actually going to the Github issue-creation screen. Maybe also related to the first point.

Setting this to P1 because most of the topic isn't readable.
/assign @zparnold

@mistyhacks It seems to work for me? Could it be a temporary CDN issue? Both the topic renders and the button opens up a new GH issue properly.

Weird, it works for me again. I must have caught Netlify mid-deploy.


We might need a new target or cfg for the ESP32 Pico Mini 02

I have an Adafruit ESP32 Feather V2 : https://www.adafruit.com/product/5400
The thing that has me puzzled is that its silkscreen shows SCL/20 on one of the pins.  https://learn.adafruit.com/adafruit-esp32-feather-v2/pinouts
The gpio.rs clause for #[cfg(esp32)] does not include gpio20.  Other esp32 variants do have a gpio20, but adafruit has different feathers for those.
According to the admin response to my Adafruit forum post the processor on this feather is actually an ESP32-PICO-MINI-02, and he provides the data sheet: https://cdn-shop.adafruit.com/product-files/5400/esp32-pico-mini-02_datasheet_en.pdf
Comparing figure 3 (pin layout) from the pico mini's datasheet against figure 2 (pin layout from the ESP32 datasheet shows major differences.
As I have transcribed the tables for Pin Definitions the pico mini has pins
0 1 2 3 4 5 7 8 12 13 14 15 19 20 21 22 25 26 27 32 33 34 35 36 37 38 39
while the ESP32 has pins
0 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 21 22 23 25 26 27 32 33 34 35 36 37 38 39
Is this Pico Mini 02 different from the esp32, esp32s2, esp32s3 and esp32c3 ?  I suspect it need its own mod chip.  Does that mean it is a new rust target as well?  What is the best way to upgrade the crate to support this board?

If the problem is only Gpio20, we can just add it to the definitions for esp32. The rest of this Pico thing looks pretty much esp32 to me.
Why don't you just patch the definitions for esp32 in the hal crate, see if then gpio20 works for you, and if yes - you can open a PR. We could include the Gpio20 with a comment that it is available only on some esp32 variations.

I have started work on a patch.  Since there are so many pins missing from the pico mini 02, I have decided it is safer to have them gated behind a feature which I am calling esp32-pico-mini-02 for now.
I am currently staring at the SPI1 implementation, and how it locks its SCLK, MISO, and MOSI pins to the same as SPI0, but I have not yet dug far enough to figure out how this plays out on a pico mini 02.  The ESP32 datasheet marks pins 6,7,and 8 as SPICLK, SPIQ, and SPID, but the pico mini 02 only has HSPI* and VSPI*, not SPI* in its Pin Definitions table.

It may be worth looking at the micropython issue linked on the pinout page regarding that exact pin

addressed with #370


Check that the venv and pycache stuff is in .gitignore

venv can be a bit tricky, you have to figure out where it it.. maybe ask os for the current interpreter path?

Fixed


set up documentation site

maybe docusaurus?
explain

architecture
each probe
each detector
what's loaded when
philosophy (small, fast)

done in 582b66, 03f231076d9601c59a74140b271950f545e070a8


Format template reading to certain decimal points

Have an issue with formatting the message field. I have this as my message
var message = ' {{index .Tags "device"}} is at level: {{.Level}} Space Temperature {{ index .Fields "m1.spaceTemp" }}°F Cooling Setpoint: {{index .Fields "m2.effCoolingSP"}}°F and Heating Setpoint: {{index .Fields "m3.effHeatingSP"}}°F '
but I want to format the value fields into 2 decimal places. I have tried
{{ printf "%.2f" index .Fields "m1.spaceTemp" }}
But it is throwing an error that the value is a string and not a float.
Any suggestions?

Correction: I am using {{ printf "%.2f" .Fields "m1.spaceTemp" }}
This is the error I am getting:
VAV109 is at level: CRITICAL Space Temperature map[%!f(string=m1):63.43 %!f(string=m2):73.79 %!f(string=m3):71.79]%!(EXTRA string=m1.spaceTemp)°F Cooling Setpoint: 73.7890853881836°F and Heating Setpoint: 71.7890853881836°F
it Looks like it is correctly changing them.


Vs2015u3pre3rollup

Fixes a bunch of issues around accessibility, and smaller UI fixes.

No this is still winforms.
I pulled all the localization from the page specific resx files, and added that to the general resx file. This makes it much easier to make changes in the future. (And will make the move to the new localization file much easier).


Add "share_UNL" to config, exposing the currently used validators in /crawl

While it would be a rather informal way to share your UNL (and could of course be faked etc.), it still would give at least some hints about validator topology which would be needed for decentralizing.
Additionally, a signature with your validator's key might be added, to give some more concrete proof that if the node fakes this statement, it is done knowingly and deliberately.

UNLs can be exposed via /crawl now (and by default are...). They don't carry signatures though, so they are fairly easy to plausibly deny.
Since the current implementation fulfills the ticket's title, I'll close this.
@garay-daniel, feel free to comment or reopen.


Can't use the plugin

This is my code, i'm trying all the paths possible, but it doesn't work
const withNextJsObfuscator = require("nextjs-obfuscator")({}, {
enabled: "detect",
patterns: [".//.js", "./.js", "./.js", "./public/.js", "./public/**/.js"],
obfuscateFiles: {
buildManifest: true,
ssgManifest: true,
webpack: true,
additionalModules: ["es6-object-assign"],
},
log: true,
});
const nextConfig = withNextJsObfuscator({
//next config
});

Could you provide the build log, the expected behavior and the actual behavior. Thanks.

Could you provide the build log, the expected behavior, the actual behavior, the next.js version and the plugin version. Thanks.

I have a folder "public" in the same directory, and i want to obfuscate the files in it and the files of the folders as well, this is the log:
(Plugin) Obfuscated: static/chunks/webpack-14a650d399173556.js 4924 -> 12466  (Plugin) Obfuscated: static/cRgrQbcZ-90sOYKFQWVMU/_ssgManifest.js 77 -> 1199  (Plugin) Obfuscated: static/cRgrQbcZ-90sOYKFQWVMU/_buildManifest.js 2073 -> 4350

@HenriqueValente09 Make sure your pattern is a regular expression "regex".
Try this one below (Note: if you're using typescript then it should be "./**/*.tsx")
patterns: ["./**/*.js"],

If that doesn't work, try without including any pattern in your pluginOptions. That way it should fallback to the default pattern value.
const pluginOptions = {
  enabled: true,
  obfuscateFiles: {
    buildManifest: true,
    ssgManifest: true,
    webpack: true,
    additionalModules: ["es6-object-assign"],
    },
  log: true,
 };

The files in public folder aren't transformed by nextjs's compiler. If you'd like to obfuscate js files placed in the folder, you have to obfuscate manually by javascript-obfuscator or something.

Closing due to housekeeping purpose. If you still have been experiencing the problem, please reopen the issue.


Request to add ACCELQ plugin to auto upload

Description
https://github.com/jenkinsci/accelq-ci-connect-plugin

Submitter checklist for adding or changing permissions

Always

[x] Add link to plugin/component Git repository in description above

When enabling automated releases (cd: true)
https://github.com/jenkinsci/accelq-ci-connect-plugin/commit/4ed1a51b6be2df5f7d51d7f93bc13c6af12745fc -Directly ran on main branch - hope this doesn't causes any issue.

[x] Add a link to the pull request, which enables continuous delivery for your plugin or component.
Follow the documentation to ensure, your pull request is set up properly.

When adding new uploaders (this includes newly created permissions files)

[ ] Make sure to @mention an existing maintainer to confirm the permissions request, if applicable
[ ] Use the Jenkins community (LDAP) account name in the YAML file, not the GitHub account name
[ ] Make sure to @mention the users being added so their GitHub account names are known if they require GitHub merge access (see below).
[ ] All newly added users have logged in to Artifactory and Jira at least once

Reviewer checklist (not for requesters!)

[ ] Check this if newly added person also needs to be given merge permission to the GitHub repo (please @ the people/person with their GitHub username in this issue as well). If needed, it can be done using an IRC Bot command
[ ] Check that the $pluginId Developers team has Admin permissions while granting the access.
[ ] In the case of plugin adoption, ensure that the Jenkins Jira default assignee is either removed or changed to the new maintainer.
[ ] If security contacts are changed (this includes add/remove), ping the security officer (currently @Wadeck) in this pull request. If an email contact is changed, wait for approval from the security officer.

There are IRC Bot commands for it

@accelq Please include a link to the PR enabling CD in your plugin, as advised by this PR template.

And if you are at it, make sure to remove https://github.com/jenkinsci/accelq-ci-connect-plugin/blob/4ed1a51b6be2df5f7d51d7f93bc13c6af12745fc/pom.xml#L79-L85
Currently you are distributing .jar files only, while Jenkins plugins expect a .hpi file too, causing to produce invalid plugin releases.

What is this PR link? I don't get it. As per the below screenshots it does not mention of any other PR.

It's a jar we use as a library for all our core functionalities, Uptil our previous releases this was fine, why does it need to be removed now?

To 1)The link to the pr where you enable cd in your plugin relates to the pr where you committed the changes to prepare your plugin for CD, like incrementals and all other changes according to the docs.To 2)You used to publish hpi files before but stopped doing at a point. I asked for the rationale behind. If it's not a Jenkins plugin, it shouldn't be suffixed as plugin and outlines to be a plugin.Typically, libraries are setup differently, notably, you don't turn a plugin into a library. See my comment on the hpi removal.On 20. Apr 2023, at 12:21, accelQ Inc @.***> wrote:
What is this PR link? I don't get it. As per the below screenshots it does not mention of any other PR.
It's a jar we use as a library for all our core functionalities, Uptil our previous releases this was fine, why does it need to be removed now?
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because your review was requested.Message ID: @.***>

The link to the pr where you enable cd in your plugin relates to the pr where you committed the changes to prepare your plugin for CD, like incrementals and all other changes according to the docs.

I did find https://github.com/jenkinsci/accelq-ci-connect-plugin/commit/4ed1a51b6be2df5f7d51d7f93bc13c6af12745fc (which has githubRepo listed twice)

To 2) You used to publish hpi files before but stopped doing at a point. I asked for the rationale behind. If it's not a Jenkins plugin, it shouldn't be suffixed as plugin and outlines to be a plugin.Typically, libraries are setup differently, notably, you don't turn a plugin into a library. See my comment on the hpi removal.

I don't think they are publishing a jar as far as I can tell, its just loading the jar from disk for compiling (from what I read last night, thats what system scope means)

I don't think they are publishing a jar as far as I can tell, its just loading the jar from disk for compiling (from what I read last night, thats what system scope means)

Then I fail to see what your concerns are?

Updated the docs. Please let me know if there are any more issues.
2. So earlier we used to deploy manually the plugin, but earlier I had raised a ticket concern that flow always fails and wanted to migrate to this automated flow, so ideally I think no code change should be required for the plugin.

core.jar is a dependency on the jenkins plugin. So it should be in POM right?

Right, could you include the link to the source code hosting this dependency is at, please?

So, the code is in the github repo itself, its just the way we package it
https://github.com/jenkinsci/accelq-ci-connect-plugin/tree/main/core

hi @NotMyFault is there anything more I can help with or can we merge this PR?

hi @NotMyFault is there anything more I can help with or can we merge this PR?

To facilitate an easier and faster review, you can provide a link to the PR preparing your plugin for releases via CD, as advised by the PR template and my prior comment.
Please take a look at the documentation, how to setup the .github folder structure properly.

Hi, adding the PRs
https://github.com/jenkinsci/accelq-ci-connect-plugin/pull/18
https://github.com/jenkinsci/accelq-ci-connect-plugin/pull/17
https://github.com/jenkinsci/accelq-ci-connect-plugin/pull/16


We should also have a test that checks that a peer is added to the established set

          That we should/could check that whenever there's a `Unnegotiated -> Negotiated Outbound` transition the peer is eventually added to the established set

Originally posted by @bolt12 in https://github.com/IntersectMBO/ouroboros-network/pull/4757#discussion_r1435119371

This is related to the bug fixed in #4748.


online-install fails on expect of postgresql image

Type: local, online installation
System: RHEL8
podman: podman version 3.3.1
command: ./mirror-registry  install
Errror:
TASK [mirror_appliance : Check if Postgres image is loaded] *******************************************************************************************************************************************************
fatal: [root@localhost]: FAILED! => {"changed": true, "cmd": ["podman", "inspect", "--type=image", "registry.redhat.io/rhel8/postgresql-10:1-161"], "delta": "0:00:00.109087", "end": "2022-01-20 10:06:24.411485", "msg": "non-zero return code", "rc": 125, "start": "2022-01-20 10:06:24.302398", "stderr": "Error: error inspecting object: registry.redhat.io/rhel8/postgresql-10:1-161: image not known", "stderr_lines": ["Error: error inspecting object: registry.redhat.io/rhel8/postgresql-10:1-161: image not known"], "stdout": "[]", "stdout_lines": ["[]"]}
...ignoring
Resolution:
Manually pull the image:
podman pull registry.redhat.io/rhel8/postgresql-10:1-161
The same happens for radis as well. I would expect the installer to pull the images.

@rhodain at the moment online installation requires podman to be logged into registry.redhat.io so that it can pull the required images. Can you confirm that podman is able to pull the image outside of installation?

Created https://issues.redhat.com/browse/PROJQUAY-3076 to track and fix this issue. We should add validation before progressing with the Ansible playbook.

HI,
yes, I confirm that I logged in registry.redhat.io as just after the error from the installer I ran:
podman pull registry.redhat.io/rhel8/postgresql-10:1-161
Trying to pull registry.redhat.io/rhel8/postgresql-10:1-161...
Getting image source signatures
Checking if image destination supports signatures
Copying blob 63f9f4c31162 done
Copying blob ce3c6836540f done
Copying blob d49355ce848e done
Copying blob fcfe904ac5ff done
Copying config a6f45d5014 done
Writing manifest to image destination
Storing signatures
a6f45d501410cf8f33d6acd339e131937bd9ecc5a5fc40bb2adf5e2d9a8914af

I reran the installer and I failed again on the radis package. podman inspect works only on already downloaded images.

The Ansible playbook is executing the podman commands as root. If you do a sudo podman login registry.redhat.io and then run the installer, does it still error out? I think what's happening here is the user is logged into registry.redhat.io but not root.

All the commands are run as root directly. I do not use sudo. Here is the output of the ocmands:
[root@rhodain-quay install]# podman login registry.redhat.io
Username: *******
Password: *******
Login Succeeded!
[root@rhodain-quay install]# ./mirror-registry  install  --quayHostname rhodain-quay.redhat.com
   __   __
  /  \ /  \     ______   _    _     __   __   __
 / /\ / /\ \   /  __  \ | |  | |   /  \  \ \ / /
/ /  / /  \ \  | |  | | | |  | |  / /\ \  \   /
\ \  \ \  / /  | |__| | | |__| | / ____ \  | |
 \ \/ \ \/ /   \_  ___/  \____/ /_/    \_\ |_|
  \__/ \__/      \ \__
                  \___\ by Red Hat
 Build, Store, and Distribute your Containers

INFO[2022-01-21 13:27:02] Install has begun
INFO[2022-01-21 13:27:02] Found execution environment at /root/install/execution-environment.tar
INFO[2022-01-21 13:27:02] Loading execution environment from execution-environment.tar
INFO[2022-01-21 13:27:10] Detected an installation to localhost
INFO[2022-01-21 13:27:10] Found SSH key at /root/.ssh/quay_installer
INFO[2022-01-21 13:27:10] Attempting to set SELinux rules on /root/.ssh/quay_installer
INFO[2022-01-21 13:27:10] Running install playbook. This may take some time. To see playbook output run the installer with -v (verbose) flag.
INFO[2022-01-21 13:27:10] Detected an installation to localhost
....
TASK [mirror_appliance : Check if Postgres image is loaded] *******************************************************************************************************************************************************
fatal: [root@localhost]: FAILED! => {"changed": true, "cmd": ["podman", "inspect", "--type=image", "registry.redhat.io/rhel8/postgresql-10:1-161"], "delta": "0:00:00.130061", "end": "2022-01-21 13:27:36.704703", "msg": "non-zero return code", "rc": 125, "start": "2022-01-21 13:27:36.574642", "stderr": "Error: error inspecting object: registry.redhat.io/rhel8/postgresql-10:1-161: image not known", "stderr_lines": ["Error: error inspecting object: registry.redhat.io/rhel8/postgresql-10:1-161: image not known"], "stdout": "[]", "stdout_lines": ["[]"]}
...ignoring

TASK [mirror_appliance : Pull Postgres image] *********************************************************************************************************************************************************************
fatal: [root@localhost]: FAILED! => {"changed": false, "msg": "Failed to pull image registry.redhat.io/rhel8/postgresql-10:1-161"}

PLAY RECAP ********************************************************************************************************************************************************************************************************
root@localhost             : ok=13   changed=4    unreachable=0    failed=1    skipped=7    rescued=0    ignored=1

ERRO[2022-01-21 13:27:39] An error occurred: exit status 2

[root@rhodain-quay install]# podman image ls
REPOSITORY                             TAG         IMAGE ID      CREATED        SIZE
quay.io/quay/mirror-registry-ee        latest      e7fd2cab0796  2 minutes ago  397 MB
<none>                                 <none>      0dd6d0b21e93  5 minutes ago  397 MB
<none>                                 <none>      0823293a16d3  27 hours ago   397 MB
<none>                                 <none>      f6a8a9747166  27 hours ago   397 MB
<none>                                 <none>      fb48e528d8d4  27 hours ago   397 MB
<none>                                 <none>      61c7588f9d77  27 hours ago   397 MB
<none>                                 <none>      d72a274a892c  27 hours ago   397 MB
<none>                                 <none>      7790ca633ed0  27 hours ago   397 MB
<none>                                 <none>      857c005b30b9  28 hours ago   397 MB
<none>                                 <none>      be84b1831289  28 hours ago   397 MB
registry.access.redhat.com/ubi8/pause  latest      23b27449fc42  4 weeks ago    3.49 MB

[root@rhodain-quay install]# podman inspect --type=image registry.redhat.io/rhel8/postgresql-10:1-161
[]
Error: error inspecting object: registry.redhat.io/rhel8/postgresql-10:1-161: image not known

[root@rhodain-quay install]# podman pull registry.redhat.io/rhel8/postgresql-10:1-161
Trying to pull registry.redhat.io/rhel8/postgresql-10:1-161...
Getting image source signatures
Checking if image destination supports signatures
Copying blob 63f9f4c31162 done
Copying blob ce3c6836540f done
Copying blob d49355ce848e done
Copying blob fcfe904ac5ff done
Copying config a6f45d5014 done
Writing manifest to image destination
Storing signatures
a6f45d501410cf8f33d6acd339e131937bd9ecc5a5fc40bb2adf5e2d9a8914af

[root@rhodain-quay install]# podman inspect --type=image registry.redhat.io/rhel8/postgresql-10:1-161
[
    {
        "Id": "a6f45d501410cf8f33d6acd339e131937bd9ecc5a5fc40bb2adf5e2d9a8914af",
        "Digest": "sha256:9a0e4988e56a75291b50ee506f4cfd3e373bfe916ce45d1dd562007ca265e820",
        "RepoTags": [
            "registry.redhat.io/rhel8/postgresql-10:1-161"
        ],
...

Got it, thanks for the logs. Will keep you updated.

@rhodain I was taking a closer look at this today. You do need to use sudo. Podman stores images separately and currently the playbook uses root. Please give that a shot and let me know if you have any questions.


fix-ContributorsFragment-error-message

Issue

Overview (Required)

Fix the error message

Links

Screenshot

Before
After

LGTM!

Good catch! 👍


loadImageFromURL not loading image into editor

Summary
I have a setup where the editor needs to be initialized and then an image should be loaded, which doesn't work using loadImageFromURL function. I don't want to initialize the editor every time I change an image. If I use the loadImageFromURL function then the toolbar doesn't work anymore.
Version
^3.5.1
Additional context
How to use loadImageFromURL properly?

I found an answer here. Other people searching this might find the below helpful. Thanks.
https://stackoverflow.com/a/54155433/5120049


Improves docs

Removes ambiguity from namely docs, renames LICENSE.md to fix spelling error

Coverage remained the same at 100.0% when pulling f6ff66c47279bad05cd29dcded7fa30bb6213915 on timmil:improves_docs into 77cf11b37b24d827ccc1df8bafbc03da17235c99 on jonathanchrisp:master.

Hey @timmil,
Was just about to comment on the order of the callback args but I've seen you've added another commit. Just to note licence is the British spelling but happy to change to the American equivalent.
If possible can we change the doc example so it uses the profiles method, the send method is a helper method and shouldn't really be called directly although this is feasible.
Thanks for contributing, as soon as the changes have been done above I'll be happy to merge. Please can you also rebase the changes down to one commit.

Ah, sorry, just saw this.
So after making some changes, I've realized that my use case was completely different here: I was using the send method to make posts to the events api, which profiles couldn't do for me.
The most recent PR I've submitted was made to make send more flexible, but maybe the real solution here is to leave send as is and build out a new function events for interfacing with the events api, which uses send. What are your thoughts on that?
And my apologies, I didn't realize Licence is a british spelling. As a notoriously bad speller myself, I just assume other people make typos too :)

@timmil - No problems, I can see why you would have done that. I've only just recently started on this project and need to add all the other endpoints, putting the events request in another method was part of the plan.
I've started work on some additional changes which relate to your second PR, would you mind holding off until I can get these changes in? Basically I think each API call should call a request verb function which then call down to the send function. I'll try and prevent users from calling these functions so only the API function can be used e.g. profiles, events etc.
I'm going to close your second PR until I can get these changes in. No worries about the spelling as in theory I should have been using the American equivalent anyhow :+1:

Hey @timmil, I've raised a new PR #5 here, please can you update this PR if you get chance? Please see my previous comments. Please also note that options passed through the namely requests go straight through to request.js so we need to pass something like:
options = {
  body: {
    limit: 1,
    after: '83809753-615b-44ee-914b-3821fe2ee7ae'
  }
}

@timmil - do you have time to update this PR?


Spotdl on Multiple Terminal

What is the purpose of your issue?

[x] Bug
[ ] Feature Request
[ ] Question
[ ] Other

Description
I Open spotdl where downloaded using pip3 . In multiple terminal, I run the spotdl and start downloading different music then the error alway showing.
Attached Image

This should now be possible as of v2.0.0.


CentOS: LVM thin provisioning tools package

On CentOS, the package which provides the LVM thin_check program
is different than on Ubuntu.
@shr3kst3r

LGTM

Tests will be run on the continuum-chef PR to pull this update in.


help

[Enter feedback here]
#include <iostream>
using namespace std;
int main()
{
	double n;
	cout << "Please enter your age: ";
	cin >> n;
	if (n < 21)
	{
		cout << "You are not qualify for loan." << endl;
	}
	double x;
	cout << "Please enter your credit score: ";
	cin >> x;
	if (x >= 680)
	{
		cout << "You are not quality for loan." << endl;
		if (x == 'n')
		{
		}
	return 0;

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a94c20cf-53ed-f41c-f21d-a9cb7695f3b5
Version Independent ID: f02d4617-2d5f-a0b5-f6e5-d9a9712284ca
Content: Fatal Error C1075
Content Source: docs/error-messages/compiler-errors-1/fatal-error-c1075.md
Product: visual-cpp
Technology: cpp-diagnostics
GitHub Login: @corob-msft
Microsoft Alias: corob

Could anyone help me out? I don't know which part is wrong.

@nazary11
This is the error message you get when you have more (or fewer) opening braces, brackets, or parens than closing ones. You're missing a couple of closing braces at the end.
This isn't a support forum, and the only people who read it consistently are the documentation maintainers, so you're unlikely to get timely help here. Closing, as this doesn't appear to be a documentation issue.


Follow Hadley's style guide

Was following Google's, but let's follow Hadley's instead. Make changes where appropriate:
http://stat405.had.co.nz/r-style.html

premature

previous code cleaned in https://github.com/stattleship/stattleship-r/pull/12


access $['someid'] in moustage binding

This issue was originally filed by @zoechi

I tried to reference a method of a sibling as event handler inside a moustache expression.
articles
Should this work? how?
I get
Transform ScriptCompactor on bwu_polymer_routing|example/example_01.html threw error: Bad state: invalid symbol name: "$['routelink'].parentRoute"
Polymer 0.12.1
Dart VM version: 1.6.0-edge.39058 (Fri Aug  8 15:50:20 2014) on "linux_x64"

This issue has been moved to dart-lang/polymer-dart#266.


MonitorNodeStatus() in NodeController needs to retry updates in a loop, to handle conflicts

The call to
_, err = nc.kubeClient.Nodes().Update(node)
from MonitorNodeStatus() can fail due to conflict with kubelet updating the same node at the same time.
MonitorNodeStatus() needs to be re-worked so that it does something like this (note: this code is largely copied from the way kubelet handles conflict retries; see updateNodeStatus() in kubelet.go):
for (each node) {
   for i := 0; i < nodeStatusUpdateRetry; i++ {
                < fetch latest node info (kubelet retry loop calls GetNodeInfo() in pkg/client/kubelet.go) >
               < run the logic to decide what to do >
		_, err = nc.kubeClient.Nodes().Update(node)
		if err != nil {
			glog.Errorf("error updating node status, will retry: %v", err)
		} else {
			return nil
		}
	}
}

Fixed by #6156


0.3.0

Move register_* suite to register submodule.
Added:

Add a better regular calling strategy and warn for ambiguity
Support #11

Breaking changes:

Rename register_piping_sign to register_piping

Closing #11 as well.

Close #11


trying to edit the title of the week but shows erro

hi,
I amying to edit the title when week is selected . I just want to show the month and year only in the title . not week number. but when i try to add it it shows error . here is my code.

but when i compile i get the error as follow.
19:36  error  'title' is defined but never used  vue/no-unused-vars
✖ 1 problem (1 error, 0 warnings)
@ ./src/main.js 6:0-28 7:10-13
@ multi (webpack)-dev-server/client?http://localhost:8080&sockPath=/sockjs-node (webpack)/hot/dev-server.js ./src/main.js
i tried somany options but none of them are working. what should i do?
also i want to add an 'add event button' next to the title also. is there ony one option of adding today button next to title.
i am using vue 3
please reply as soon as possible

Hi!
Pure usage-related questions are probably better to post on Stack Overflow than as an issue in this repo.
In any case, a minimal reproduction demonstrating the issue using CodePen, CodeSandbox or similar is needed to be able to help you.


Constraint offsets

Could you add an optional field constr_offsets to canonInterface.get_problem_matrix that takes a list of constraint offsets? In other words, if the argument to constr_offsets is [3,5,7] then constraint 0 starts at row 3, constraint 1 starts at row 5, and constraint 2 starts at row 7.
You might want to check that the offsets make sense, but it's also ok if you don't and just throw an error at some point. Another option would be for constr_offsets to expect a map of constraint id to offset. Either way is fine with me. The default behavior should be to assume all the constraints are stacked with no gaps, as in the current implementation.
This feature will make it much easier to handle parameters.

I just added an optional field constr_offsets to canonInterface.get_problem_matrix. If the const_offsets argument is supplied, the function expects a list [x_1, x_2, ..., x_n], where x_i is the vertical offset of the i-th constraint.
If a list is supplied, the code currently expects an offset for each constraint. Would this be sufficient to handle parameters? Or is the desired use case to only specify offsets for some subset of the constraints and then use the default stacking behavior for the other constraints?
In terms of error checking, would it be reasonable to assume the offset for constraint i is less than the offset for constraint i+1? Or can you imagine a case where the list of constraints would be something like [10, 3, 12]?

Thanks! Requiring offsets for every constraint is good. You can
assume/require that the constraints are monotonically increasing.
On Tuesday, July 21, 2015, jpmpentwater<EMAIL_ADDRESS>wrote:

I just added an optional field constr_offsets to
canonInterface.get_problem_matrix. If the const_offsets argument is
supplied, the function expects a list [x_1, x_2, ..., x_n], where x_i is
the vertical offset of the i-th constraint.
If a list is supplied, the code currently expects an offset for each
constraint. Would this be sufficient to handle parameters? Or is the
desired use case to only specify offsets for some subset of the constraints
and then use the default stacking behavior for the other constraints?
In terms of error checking, would it be reasonable to assume the offset
for constraint i is less than the offset for constraint i+1? Or can you
imagine a case where the list of constraints would be something like [10,
3, 12]?
—
Reply to this email directly or view it on GitHub
https://github.com/jacklzhu/CVXcanon/issues/3#issuecomment-123057989.

Okay. I added error checking code and pushed the changes. I'm in the process of testing of the edge cases, but it's a bit difficult without modifying cvxpy too. Definitely let me know if you run into any issues!


function-call-argument-newline rule since ESLint 6.2.0

The function-call-argument-newline rule has been added since ESLint 6.2.0.
This rule looks to detect stylistic issues, so should eslint-config-prettier disable this rule?
The following is a test case:
$ eslint -v
v6.2.0

$ prettier -v
1.18.2

$ cat test.js
/*eslint function-call-argument-newline: ["error", "always"]*/

function foo(a, b, c) {
  return a + b + c;
}

foo("one", "two", "three");

$ eslint --no-eslintrc test.js

/tmp/test.js
  7:11  error  There should be a line break after this argument  function-call-argument-newline
  7:18  error  There should be a line break after this argument  function-call-argument-newline

✖ 2 problems (2 errors, 0 warnings)
  2 errors and 0 warnings potentially fixable with the `--fix` option.

$ prettier --no-config -c test.js
Checking formatting...
All matched files use Prettier code style!

Yes, this rule should be disabled. :+1:
Do you want to make a PR?

No. I would be glad if you could make a PR instead of me. 😺

Released in 6.1.0. Thanks for the report! 👍

Thank you!


wrong field name exception isn't being reported in BulkIndexer

Let's say I have a mapping with a single field of type long
{"my-index": {
  "mappings": {
    "my-type": {
      "properties": {
        "field-1": {
          "type": "long"}}}}}}

If I try to index a document where field-1's value is a non-number string i.e. "hello" (can't be converted to a long), I will get an exception. This isn't reported to the error channel and should be.

any progress on ths?

Hi @oryband,  I have a full time job so the time I can spend on this project has limitations. Things that would make it easier for me to fix this would be a test case, or if you are feelin' it, you could attempt the fix yourself. I can't give you an ETA at the moment, I'm sorry.

I've tracked down where the fix should be: https://github.com/mattbaird/elastigo/blob/09363f92cd44e47b5034719cdef78da73190d847/lib/corebulk.go#L333
Items is an objects of elasticsearch methods (create, index, etc.), where each method is a list of objects, where each of these has an error field. These should be reported to the standard error channel or some other designated channel.
Anybody care to help?


[fpv/tool] parse results calculation

This PR updates the parse result script to change the way we calculate
pass_rate. We categorize undertermined as passed because that means -
with the limited run time, the FPV engines could not find any
countercases or identify them as unreachables.
Signed-off-by: Cindy Chen<EMAIL_ADDRESS>

That is a good point! Thanks Rupert, yeah diverging tests, if they are truly unreachable, they should be caught by  unreachables, otherwise for V3, we will review this items and manually check if we can waive them. V3 requires all the properties to be proven :)


Finalizing Setup with Clever Support

Before you can Test single sign-on, You have to ask Clever support to enable Office 365 SSO in the back end.
Finalizing Setup with Clever Support
Once you've finished the above, please reach out to Clever Support, and send us your metadata file. We'll finalize the setup on our end!  https://support.clever.com/hc/en-us/requests/new

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: ee4671de-22be-bbf3-3af5-29d8c958a91a
Version Independent ID: df970875-9c2c-e201-a463-210b7dc8e0da
Content: Tutorial: Azure Active Directory integration with Clever
Content Source: articles/active-directory/active-directory-saas-clever-tutorial.md
Service: active-directory
GitHub Login: @jeevansd
Microsoft Alias: jeedes

@chetansriv and @v-viinde Can you please add this step in to the doc please?

Hi @prestoncooper @jeevansd Before you can Test single sign-on, You have to ask Clever support to enable Office 365 SSO in the back end.
-- Do we have to mention this in the pre-requisites section or in the Configure Azure AD single sign-on section where are setting the SSO config URLs
-- Intially in the your tutorial, we were sending both the metadata XML as well as the metadata URL. Ideally only one thing is required to configure SSO. Do we need to change the current tutorial from metadata URL to XML.

@v-viinde and @prestoncooper  Please mention this in the SSO Configuration on the app side section.
Before you can Test single sign-on, You have to ask Clever support to enable Office 365 SSO in the back end.
We suggest to use the Federation Metadata XML URL as far as possible. I think Clever does support auto rollover of the certificate if the URL is provides. Please correct me if I am wrong here. Also passing the XML which has certificate in it over the email is security risk. So URL option is preferred.

#please-close


Unit testing schemas

Hi,
I'm currently reviewing dry-validations for usage on one of my projects. One thing I wanted to know is if there is a way to unit test the schema definitions. eg.
describe "email" do
  it "gets validated with presence" do
    # ????
  end

  it "gets validated with my_custom_predicate (eg. email)" do
    # ????
  end
end

I would then create a couple of unit tests for my_custom_predicate and just verify that the schema is using the my_custom_predicate. Without testing the schema I would have to test all possibilities of my_custom_predicate everywhere it is used. The only thing which matters to my tests is that attribute x is verified with predicate my_custom_predicate.
Thanks for your advice.

The custom_predicate can be unit tested easily.
You can do something like:
expect(MyApp::Predicates[:custom_predicate?].call(valid_input).to eql true

I'm not sure how you should test that your schema is using the custom_predicate on the right field.
Usually I do test my custom predicates directly where the Schema is using them, usually this is done within an operation, so it makes sense to know that if the operation is called with wrong input I receive the expected errors.
This might be too repetitive for complex schemas, another options is to unit test the Schema, and then test that it's been used where it should be.

Just check behavior, absolutely no need to check which predicate was used, the outcome should be that the error message is correct. Otherwise you're testing implementation details.


CBMC: Add spec & proof for poly_frombytes()

Looks good to me too. Tests, lints and proofs all OK. Great first proof! Let's merge.

Looks good to me too. Tests, lints and proofs all OK. Great first proof! Let's merge.

Definitely not the first, but good to get going again! Thanks for the review 🙏


docs: Use IntoDataFrame in docs

What type of PR is this? (check all applicable)

[ ] 💾 Refactor
[ ] ✨ Feature
[ ] 🐛 Bug Fix
[ ] 🔧 Optimization
[ ] 📝 Documentation
[ ] ✅ Test
[ ] 🐳 Other

Related issues

Related issue #386
Closes #

Checklist

[ ] Code follows style guide (ruff)
[ ] Tests added
[ ] Documented the changes

If you have comments or can explain your changes, please do so below.

thanks @luke396 ! I think these ones are fine, I was thinking more about using these type hints in the docstrings

thanks @luke396 ! I think these ones are fine, I was thinking more about using these type hints in the docstrings

Ah, I notice some differences between the user guide/tutorial and the docstring. Are the changes in the tutorial necessary? If so, I'd like to make further modifications; if not, closing the PR is perfectly acceptable.
Regarding the IntoDataFrame and IntoDataFrameT in the method's docstring, I plan to look into them later.

I think the tutorial is probably the first thing that a lot of people will see, so improving it is certainly a good idea 👍 If there are places in the tutorial which don't have type annotations, then I think adding them would be beneficial

Absolutely, adding type annotations where they're missing is a great idea.
I'm slightly confused about other type annotations, especially those changed in the current PR. To be honest, I'm not entirely sure which ones to use in the tutorial. I've read their definitions, and it seems they have some inclusion relationships or minor differences in certain subtypes. So, which one to choose is a question.
My question is, should we update them in the tutorial based on a specific principle? Or have we already settled on annotations, and I've just missed something?


Error in comment links created with steem-js

I'm a bit surprised to have found an issue in steem-js. I'm even more surprised to see that this bug has been there since the very first commit of the code. Documentation is still severely lacking and I had to hack my way through this issue. When using steem-js to make a comment on a post one has to provide a comment permlink. steem-js has a function commentPermlink to help with creating this permlink. I have been using this function without any issues until today when I used it to comment on a blog post by @diana.catherine.
When using this snippet:
var parentAuthor = 'diana.catherine';
var parentPermlink = 'the-first-physical-steem-coin-ready-to-be-shipped';
var commentPermlink = steem.formatter.commentPermlink(parentAuthor, parentPermlink);
console.log(commentPermlink);

The permlink created looks like this:
re-diana.catherine-the-first-physical-steem-coin-ready-to-be-shipped-20180126t105335010z

Using this permlink to post a comment results in an error:
This is an invalid permlink and when posting an error is returned:
: RPCError: 10 assert_exception: Assert Exception
false: Invalid permlink character: .

Checking the block explorer revealed a second hint. This is just from a random comment on the mentioned post. It shows the dot is removed from the permlink:

I did some further digging and found that condenser has this extra code to further format the permlink in their own function. It is limited to 255 chars and only letters, numbers and dashes are allowed. Excerpt from the TransactionSaga.js
if (permlink.length > 255) {
    // STEEMIT_MAX_PERMLINK_LENGTH
    permlink = permlink.substring(permlink.length - 255, permlink.length);
}
// only letters numbers and dashes shall survive
permlink = permlink.toLowerCase().replace(/[^a-z0-9-]+/g, '');

When using commentPermlink it is best to apply the above logic on your code or write your own function to bypass this error.
Posted on Utopian.io -  Rewarding Open Source Contributors

Good to finally meet you sir.. I've been trying to solve the problem but it is quite complex.  I tried to upload videos on dtube but I got response like "invalid permlink character: ${s}". Please i need your advice on what to do.


Feature Request: Coverage for template files

Which @angular/* package(s) are relevant/related to the feature request?
core
Description
I was wondering if it is possible to have a coverage of the templates too. Sometimes the component typescript has no logic but everything exist in the .html file. It would be nice that the coverage could see that an *ngIf has been triggered in at least one test.
Proposed solution
Test coverage should say 50% branch coverage for this kind of template
@Component({
  selector: 'ng-if-simple',
  template: `

First 50% code coverage

Last 50% code coverage

`
})
export class NgIfSimple {
  show = true;
}

Alternatives considered
I haven't tried anything yet. I wanted to see if the community has some input to give. Or if this idea of having coverage of templates isn't feasible at all.

It is possible to get template code coverage by enabling AOT for tests.
It is currently possible with Vitest and PRs are open for Karma & Jest.
You can read more about this here: https://marmicode.io/blog/angular-template-code-coverage-and-future-proof-testing


Add compatibility with encoding UUID values

This PR should take care of this issue.
Simply cast UUID values to str in the prepare_value method of the ArrayFormField class.

Hi. Thanks for this PR.
This has been released in v2.21.3. Please update and test it out.


issue-1 Remove insecure Db2 transport

Pull request questions
Which issue does this address
ISSUE-1

#1


fix the secondary key issue: update checking index

#455

Coverage increased (+0.008%) to 65.106% when pulling 0041dcf622495f0e8596556e551ee6c4a77facad on Michael-Tieying-Zhang:master into 15f952a15b31e2b40aeffbeb2e0b73d7b472d1ab on cmu-db:master.


Transaction size restrictions

Summary
Currently the blockchain has very high limits for full block size (21MB, 60M gas  on mainnet and 21MB, no gas limit on testnet).  In addition there is no limit on the number of message or the amount of gas spent within a single transaction.  There should be more reasonable limits set on both of these values
Problem Definition
Without limits on transactions a single one can take up an entire block.  In addition the resource consumption for a single block is high enough to prevent smooth operation of the network.
Proposal
Update an upgrade proposal within the 1.8.0-RC framework that lowers the block size limit and enforces a maximum amount of gas per block.  In addition modify the antehandler such that a single tx can account for no more than 50% of a given block's resources.
For reference:
// Osmosis
"max_bytes": "5242880",
"max_gas": "6000000",
// Cosmos Hub
"max_bytes": "200000",
"max_gas": "2000000",
// Provenance
"max_bytes": "22020096",
"max_gas": "60000000",

For Admin Use

[ ] Not duplicate issue
[ ] Appropriate labels applied
[ ] Appropriate contributors tagged
[ ] Contributor assigned/self-assigned

Roughly the following for the
params := app.GetConsensusParams(ctx)
params.Block.MaxBytes = 1024 * 1024 * 5 // 5MB
params.Block.MaxGas = 60_000_000        // note that 5MB for a block represents ~52M gas @ 10 per byte.
app.StoreConsensusParams(ctx, params)


Change leaderboard's default filter

Currently, when you go to the leaderboard page, it defaults to the All feature. Change this such that it defaults to 7d

@angle943 Could you assign this to me, please?

@dahelg I don't mean to undercut you, but I think the line to change is here

@johnjacobkenny And this is why I ask before doing any work in parallel to anyone else... We should respect that every work takes some time. ✌

@dahelg Yep :smiley: