[BUG] Error trying to install custom plugin

System information

OS Platform and Distribution (e.g., Linux Ubuntu 16.04): 18.04
FiftyOne installed from (pip or source): source
FiftyOne version (run fiftyone --version): v0.17.2
Python version: 3.9.12

Commands to reproduce
I tried to follow this guide: https://github.com/voxel51/fiftyone-plugins/tree/main/hello-world
Describe the problem
I follow the following steps:
npm install
cd $MY_FIFTYONE_SRC_DIR/app/packages;
cd aggregations;
npm link;
cd ../plugins;
npm link;
cd ../state;
npm link;
cd $HELLO_WORLD_DIR;
npm link @fiftyone/aggregations;
npm link @fiftyone/plugins;
npm link @fiftyone/state;

Then, i run:
yarn build

and I got this error:
[vite]: Rollup failed to resolve import "@fiftyone/plugins" from "src/HelloWorldPlugin.tsx".
This is most likely unintended because it can break your application at runtime.
If you do want to externalize this module explicitly add it to
build.rollupOptions.external
error during build:
Error: [vite]: Rollup failed to resolve import "@fiftyone/plugins" from "src/HelloWorldPlugin.tsx".
This is most likely unintended because it can break your application at runtime.
If you do want to externalize this module explicitly add it to
build.rollupOptions.external
    at onRollupWarning (/home/musausr/fiftyone/plugins/hello-world/node_modules/vite/dist/node/chunks/dep-689425f3.js:41797:19)
    at onwarn (/home/musausr/fiftyone/plugins/hello-world/node_modules/vite/dist/node/chunks/dep-689425f3.js:41613:13)
    at Object.onwarn (/home/musausr/fiftyone/plugins/hello-world/node_modules/vite/node_modules/rollup/dist/shared/rollup.js:23216:13)
    at ModuleLoader.handleResolveId (/home/musausr/fiftyone/plugins/hello-world/node_modules/vite/node_modules/rollup/dist/shared/rollup.js:22466:26)
    at /home/musausr/fiftyone/plugins/hello-world/node_modules/vite/node_modules/rollup/dist/shared/rollup.js:22427:26
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

So, I thought that what was going wrong were the links created with npm. In the files "HelloWorld.tsx" and "HelloWorldPlugins.tsx" I tried to substitute those lines:
import * as fop from '@fiftyone/plugins';
import * as fop from '@fiftyone/aggregations';
import * as fop from '@fiftyone/state';

with:
import * as fop from './../../../fiftyone/app/packages/plugins';
import * as fos from './../../../fiftyone/app/packages/aggregations';
import * as fop from './../../../fiftyone/app/packages/state';

Now the
yarn build

command is successful, but I ran into another error. Starting the server with the following commands:
cd $FIFTYONE
python fiftyone/server/main.py

I got the following problem in the web console:
Uncaught Invariant Violation: graphql: Unexpected invocation at runtime. Either the Babel transform was not set up, or it failed to identify this call site. Make sure it is being used verbatim as `graphql`. Note also that there cannot be a space between graphql and the backtick that follows.
    at b1 (http://localhost:5151/plugins/hello-world/dist/index.umd.js:28:673)
    at Object.pW [as graphql] (http://localhost:5151/plugins/hello-world/dist/index.umd.js:29:4255)
    at http://localhost:5151/plugins/hello-world/dist/index.umd.js:58:79798
    at http://localhost:5151/plugins/hello-world/dist/index.umd.js:1:64
    at http://localhost:5151/plugins/hello-world/dist/index.umd.js:1:70

import * as fop from './../../../fiftyone/app/packages/plugins';
import * as fos from './../../../fiftyone/app/packages/aggregations';
import * as fop from './../../../fiftyone/app/packages/state';

This is not supported. The plugin needs to refer to the package itself so that it can be externalized. This part of the config is also required: https://github.com/voxel51/fiftyone-plugins/blob/main/hello-world/vite.config.ts#L17
Try running a yarn install in your plugin dir after creating the links.

The config part is ok.
I tried running yarn install after creating the npm links and it was successful. I started the server and i got this error in the web console:
GET http://<IP_ADDRESS>:5151/plugins/hello-world/dist/index.umd.js net::ERR_ABORTED 500         index.1e70dfa6.js:704
I also tried to run yarn build and I got again this error:
[vite]: Rollup failed to resolve import "@fiftyone/plugins" from "src/HelloWorldPlugin.tsx".
This is most likely unintended because it can break your application at runtime.
If you do want to externalize this module explicitly add it to
build.rollupOptions.external
error during build:
Error: [vite]: Rollup failed to resolve import "@fiftyone/plugins" from "src/HelloWorldPlugin.tsx".
This is most likely unintended because it can break your application at runtime.
If you do want to externalize this module explicitly add it to
build.rollupOptions.external
at onRollupWarning (/home/musausr/fiftyone/plugins/hello-world/node_modules/vite/dist/node/chunks/dep-689425f3.js:41797:19)
at onwarn (/home/musausr/fiftyone/plugins/hello-world/node_modules/vite/dist/node/chunks/dep-689425f3.js:41613:13)
at Object.onwarn (/home/musausr/fiftyone/plugins/hello-world/node_modules/rollup/dist/shared/rollup.js:23216:13)
at ModuleLoader.handleResolveId (/home/musausr/fiftyone/plugins/hello-world/node_modules/rollup/dist/shared/rollup.js:22466:26)
at /home/musausr/fiftyone/plugins/hello-world/node_modules/rollup/dist/shared/rollup.js:22427:26
at processTicksAndRejections (node:internal/process/task_queues:96:5)
error
This is the terminal of the server:
Traceback (most recent call last):
File "/home/musausr/anaconda3/lib/python3.9/site-packages/hypercorn/asyncio/task_group.py", line 23, in _handle
await app(scope, receive, send, sync_spawn, call_soon)
File "/home/musausr/anaconda3/lib/python3.9/site-packages/hypercorn/app_wrappers.py", line 33, in call
await self.app(scope, receive, send)
File "/home/musausr/anaconda3/lib/python3.9/site-packages/starlette/applications.py", line 112, in call
await self.middleware_stack(scope, receive, send)
File "/home/musausr/anaconda3/lib/python3.9/site-packages/starlette/middleware/errors.py", line 181, in call
raise exc
File "/home/musausr/anaconda3/lib/python3.9/site-packages/starlette/middleware/errors.py", line 159, in call
await self.app(scope, receive, _send)
File "/home/musausr/anaconda3/lib/python3.9/site-packages/starlette/middleware/cors.py", line 84, in call
await self.app(scope, receive, send)
File "/home/musausr/anaconda3/lib/python3.9/site-packages/starlette/middleware/base.py", line 57, in call
task_group.cancel_scope.cancel()
File "/home/musausr/anaconda3/lib/python3.9/site-packages/anyio/_backends/_asyncio.py", line 662, in aexit
raise exceptions[0]
File "/home/musausr/anaconda3/lib/python3.9/site-packages/starlette/middleware/base.py", line 30, in coro
await self.app(scope, request.receive, send_stream.send)
File "/home/musausr/anaconda3/lib/python3.9/site-packages/starlette/exceptions.py", line 82, in call
raise exc
File "/home/musausr/anaconda3/lib/python3.9/site-packages/starlette/exceptions.py", line 71, in call
await self.app(scope, receive, sender)
File "/home/musausr/anaconda3/lib/python3.9/site-packages/starlette/routing.py", line 656, in call
await route.handle(scope, receive, send)
File "/home/musausr/anaconda3/lib/python3.9/site-packages/starlette/routing.py", line 408, in handle
await self.app(scope, receive, send)
File "/home/musausr/anaconda3/lib/python3.9/site-packages/starlette/staticfiles.py", line 98, in call
await response(scope, receive, send)
File "/home/musausr/anaconda3/lib/python3.9/site-packages/starlette/responses.py", line 285, in call
raise RuntimeError(f"File at path {self.path} does not exist.")
RuntimeError: File at path  does not exist.

import * as fop from './../../../fiftyone/app/packages/plugins';
import * as fos from './../../../fiftyone/app/packages/aggregations';
import * as fop from './../../../fiftyone/app/packages/state';

This is not supported. The plugin needs to refer to the package itself so that it can be externalized. This part of the config is also required: https://github.com/voxel51/fiftyone-plugins/blob/main/hello-world/vite.config.ts#L17
Try running a yarn install in your plugin dir after creating the npm links.

The config part is ok.
I tried running yarn install after creating the npm links and it was successful. I started the server and i got this error in the web console:
GET http://<IP_ADDRESS>:5151/plugins/hello-world/dist/index.umd.js net::ERR_ABORTED 500         index.1e70dfa6.js:704
I also tried to run yarn build and I got again this error:
[vite]: Rollup failed to resolve import "@fiftyone/plugins" from "src/HelloWorldPlugin.tsx".
This is most likely unintended because it can break your application at runtime.
If you do want to externalize this module explicitly add it to
build.rollupOptions.external
error during build:
Error: [vite]: Rollup failed to resolve import "@fiftyone/plugins" from "src/HelloWorldPlugin.tsx".
This is most likely unintended because it can break your application at runtime.
If you do want to externalize this module explicitly add it to
build.rollupOptions.external
at onRollupWarning (/home/musausr/fiftyone/plugins/hello-world/node_modules/vite/dist/node/chunks/dep-689425f3.js:41797:19)
at onwarn (/home/musausr/fiftyone/plugins/hello-world/node_modules/vite/dist/node/chunks/dep-689425f3.js:41613:13)
at Object.onwarn (/home/musausr/fiftyone/plugins/hello-world/node_modules/rollup/dist/shared/rollup.js:23216:13)
at ModuleLoader.handleResolveId (/home/musausr/fiftyone/plugins/hello-world/node_modules/rollup/dist/shared/rollup.js:22466:26)
at /home/musausr/fiftyone/plugins/hello-world/node_modules/rollup/dist/shared/rollup.js:22427:26
at processTicksAndRejections (node:internal/process/task_queues:96:5)
error
This is the terminal of the server:
[2022-10-11 09:25:20 +0200] [3185] [ERROR] Error in ASGI Framework
Traceback (most recent call last):
File "/home/musausr/anaconda3/lib/python3.9/site-packages/hypercorn/asyncio/task_group.py", line 23, in _handle
await app(scope, receive, send, sync_spawn, call_soon)
File "/home/musausr/anaconda3/lib/python3.9/site-packages/hypercorn/app_wrappers.py", line 33, in call
await self.app(scope, receive, send)
File "/home/musausr/anaconda3/lib/python3.9/site-packages/starlette/applications.py", line 112, in call
await self.middleware_stack(scope, receive, send)
File "/home/musausr/anaconda3/lib/python3.9/site-packages/starlette/middleware/errors.py", line 181, in call
raise exc
File "/home/musausr/anaconda3/lib/python3.9/site-packages/starlette/middleware/errors.py", line 159, in call
await self.app(scope, receive, _send)
File "/home/musausr/anaconda3/lib/python3.9/site-packages/starlette/middleware/cors.py", line 84, in call
await self.app(scope, receive, send)
File "/home/musausr/anaconda3/lib/python3.9/site-packages/starlette/middleware/base.py", line 57, in call
task_group.cancel_scope.cancel()
File "/home/musausr/anaconda3/lib/python3.9/site-packages/anyio/_backends/_asyncio.py", line 662, in aexit
raise exceptions[0]
File "/home/musausr/anaconda3/lib/python3.9/site-packages/starlette/middleware/base.py", line 30, in coro
await self.app(scope, request.receive, send_stream.send)
File "/home/musausr/anaconda3/lib/python3.9/site-packages/starlette/exceptions.py", line 82, in call
raise exc
File "/home/musausr/anaconda3/lib/python3.9/site-packages/starlette/exceptions.py", line 71, in call
await self.app(scope, receive, sender)
File "/home/musausr/anaconda3/lib/python3.9/site-packages/starlette/routing.py", line 656, in call
await route.handle(scope, receive, send)
File "/home/musausr/anaconda3/lib/python3.9/site-packages/starlette/routing.py", line 408, in handle
await self.app(scope, receive, send)
File "/home/musausr/anaconda3/lib/python3.9/site-packages/starlette/staticfiles.py", line 98, in call
await response(scope, receive, send)
File "/home/musausr/anaconda3/lib/python3.9/site-packages/starlette/responses.py", line 285, in call
raise RuntimeError(f"File at path {self.path} does not exist.")
RuntimeError: File at path  does not exist.


Gulp node-bourbon issue

Hi,
I'm trying to use bourbon, but I ran into some issues. I'm resolving my paths via the gulp-sass package (includePaths) to my bootstrap and bourbon. Bootstrap works, but somehow I can't get it to work with Bourbon. It doesn't get imported in my css files. I do not get any helpful error messages either.
To test if it was the bourbon packages I tried to include normalize.css alone (not the inbuild one of bootstrap), and and I got normalize.css working, so it has to be something with bourbon?
This is how I try to access bourbon:
 includePaths: [         "./node_modules/bootstrap-sass/assets/stylesheets/",         require('node-bourbon').includePaths,         require('node-normalize-scss').includePaths       ]
I import it in my main.scss file with @import 'bourbon';.
Does someone know what to do to fix this?
Thanks!

require('node-bourbon').includePaths returns an array, so you would want to handle it along the lines of:
includePaths: [].concat(
  './node_modules/bootstrap-sass/assets/stylesheets/',
  require('node-bourbon').includePaths,
  require('node-normalize-scss').includePaths
)

Still not got it working, even with your answer... It's including normalize and bootstrap perfectly but it does not with bourbon. Even giving the path manually
 includePaths: [].concat(        './node_modules/bootstrap-sass/assets/stylesheets/',        **'./node_modules/bourbon/app/assets/stylesheets/',**        require('node-normalize-scss').includePaths       )
does not seem to work.
Any ideas :/ ?
Thanks

require('node-bourbon').includePaths,
require('node-normalize-scss').includePaths[1]
You are welcome


Load more button on Who is using Svelte section is gone

If I recall correctly there was a load more button on the Who's using Svelte? section of the site. The button is no longer to be found.

Also, this page is archived: https://github.com/sveltejs/community/blob/master/whos-using-svelte/WhosUsingSvelte.js
Don't know exactly whata that means.

See this PR: https://github.com/sveltejs/svelte/pull/6409

Yes, we decided to remove that section. Only a small fraction of the logos were being displayed and it generated continuous requests to maintain it


Step2-1,failed with tables

Hello Wenhu:
When I run the step 2-1, after converting all examples to features, the code repeated the procedure and shows a lot of 'failed with table...' and the code is stuck. Can you help me solve this problem? I would appreciate it

.

**AlfredLiu6 ** commented on 11 Aug

Hello, have you solved this problem?

**AlfredLiu6 ** commented on 11 Aug

Hello, have you solved this problem?

Not yet.

Hello all,
I got some "failed with table ...."  but it doesn't stuck, it run for all tables.
Do any of you solve this problem?
Thanks in advance,


Release date 5.3

What release date laravel 5.3? :)

It'll be some time in August most probably. :)


cut_molecule

Dear all,
I was trying to use the lammps interface with the test cif IRMOF-1.cif you provide in the test folder (as well as with some other cifs). For all the tested cif files I get this error message:
_main.py", line 1532, in cut_molecule
mgraph.coordinates = self.graph.coordinates[indices,:].copy()
TypeError: 'NoneType' object is not subscriptable
I would be very glad for help to fix this issue.
Kind regards,
Michelle Ernst

Thanks for the report @michelleernst - this really highlights the fact that we absolutely should be adding automatic tests, which would prevent such failures on the test structures in the repository.
I've just added a pull request that starts running some of those and I'm able to reproduce your issue.
Interestingly, it seems to depend on the python version - in a fresh local python 3.6 environment, the code runs fine, while in a python 3.8 environment it doesn't.

@peteboyd It seems to me there is some remaining issue with the upgrade to networkx 2.4
Would you mind having a look into this?
@michelleernst In the meanwhile, you should be able to use the code in a python 3.6 environment (which you can create, for example, using conda)

It was an issue with the module time. A while ago had merged a pull request that printed the time for computing each force field element in a cif file. It was calling time.clock() which is apparently deprecated.

@michelleernst As demonstrated by the passing tests in https://github.com/peteboyd/lammps_interface/pull/41 , the current master branch of the repository should work.
Once the PR is merged, I will make a 1.4.0 release on PyPI as well.

I've just pushed out v0.2.0 to pypi. Should be available in a few minutes.


Onboarding: map for districs and neighborhoods

This issue is to be done after MVP.
Add map for districs and neighborhoods selection.
Low priory for now.

Assigned to me for later delegation.

Relates to issue 46.


Use cookie as a variable for Query in Nuxt

I'm using https://github.com/S64/vue-universal-cookies to use cookies on both server side and client side. This library works perfectly. However if I use it as a variable in the query, it doesn't work. Any idea?
<template>
 <div>
  {{ $cookies.get('customerId') }} // this works
 </div>
</template>
<script>
import CUSTOMER from "~/graphql/queries/CUSTOMER.gql";

export default {
created() {
  console.log(this.$cookies.get('customerId)) // this works on both server and client
},
  apollo: {
    customer: {
      query: CUSTOMER,
      prefetch: true,
      variables(){
        return {
         customerId: this.$cookies.get('customerId) // this doesn't work
        }
      }
   }
 }
}

@gijo-varghese I don't use the vue-universal-cookies module. But one take is:
instead of doing prefetch:true you should try to pass your $cookies argument to the app scope of Nuxt and do something like:
      prefetch: ({ app }) => {
      const customerId = app.$cookies.get('customerId') // => this is totally not tested but what you should try to do, adding cookies to the app scope
      return {
          customerId
        }
      },

The reason why its not working its the prefetch:true argument as far as I remember. Because on SSR there is no this context in prefetch that is why you need to be careful when you use it. Hope this helps you out to solve your issue

Ok. let me try that

will close this issue due to inactivity @gijo-varghese feel free to re-open if you still have problems

@dohomi this one finally worked: https://github.com/Akryum/vue-apollo/issues/227
Can you pls take a look

@gijo-varghese looking good to me.


[bug] Running moon via bun

Describe the bug
Installing bun as a (monorepo root) dep of a project that is installed via 'bun install' leaves the moon cli unable to be ran
Steps to reproduce

`bun add @moonrepo/cli'
(bun install)
'bun moon' // leads to below error

$ bun moon
/Users/matt/dev/org-repo-moonrepo/node_modules/.bin/../@moonrepo/cli/moon: line 1: This: command not found

Debugging suggests that bun installs the bin file of moonrepo/cli as the file with contents:
This file is necessary for package managers to link the core binary

Note that the same project can then do the following successfully:

'pnpm install'
'pnpm moon' // leads to expected moon help default

Expected behavior

Screenshots

Environment

System:
    OS: macOS 13.0.1
    CPU: (10) x64 Apple M1 Pro
    Memory: 22.47 MB / 16.00 GB
    Shell: 5.8.1 - /bin/zsh
  Binaries:
    Node: 18.14.2 - /usr/local/bin/node
    Yarn: 1.22.19 - ~/dev/org-repo-moonrepo/node_modules/.bin/yarn
    npm: 9.5.0 - /usr/local/bin/npm
    pnpm: 7.30.0 - /usr/local/bin/pnpm
    Watchman: 4.9.0 - /usr/local/bin/watchman
  Managers:
    Composer: 1.5.2 - /usr/local/bin/composer
    Homebrew: 4.0.10 - /usr/local/bin/brew
    pip3: 22.3.1 - /usr/local/bin/pip3
    RubyGems: <IP_ADDRESS> - /usr/bin/gem
  Utilities:
    Make: 3.81 - /usr/bin/make
    GCC: 14.0.3 - /usr/bin/gcc
    Git: 2.39.0 - /usr/local/bin/git
    Clang: 14.0.3 - /usr/bin/clang
    Curl: 7.84.0 - /usr/bin/curl
  Servers:
    Apache: 2.4.54 - /usr/sbin/apachectl
  Virtualization:
    Docker: 18.09.0 - /usr/local/bin/docker
  IDEs:
    Android Studio: 3.4 AI-183.6<IP_ADDRESS>22156
    PhpStorm: 2017.3.3
    Sublime Text: 4143 - /usr/local/bin/subl
    VSCode: 1.78.2 - /usr/local/bin/code
    Vim: 9.0 - /usr/local/bin/vim
    Xcode: /undefined - /usr/bin/xcodebuild
  Languages:
    Bash: 5.2.15 - /usr/local/bin/bash
    Java: 11.0.2 - /usr/bin/javac
    Perl: 5.36.0 - /usr/local/bin/perl
    PHP: 8.2.0 - /usr/local/bin/php
    Python3: 3.11.2 - /usr/local/bin/python3
    Ruby: 2.6.10 - /usr/bin/ruby
  Databases:
    SQLite: 3.39.4 - /usr/bin/sqlite3
  Browsers:
    Brave Browser: <IP_ADDRESS>
    Chrome: 117.0.5938.149
    Edge: 117.0.2045.55
    Safari: 16.1
  Monorepos:
    Yarn Workspaces: 1.22.19

Additional context

User error - I see a postinstall is required for moon and bun requires whitelisting - https://bun.sh/guides/install/trusted


feat(wiki): create staff wiki

wiki.js doesn't work properly work with mysql 5.7, unfortunately, so this plan has fallen through


[Query] Does NeuVector support DPI for TLS traffic?

Description
We expect to monitor/protect all our external and internal TLS communications through NeuVector network security features. In that case, would the built-in network attack detections (https://open-docs.neuvector.com/policy/networkrules#built-in-network-threat-detection) as well as WAF and DLP sensors (https://open-docs.neuvector.com/policy/dlp) support these TLS communications via any TLS decryption and subsequent inspection method or would they just be limited to only HTTP traffic? @jayhuang-suse @becitsthere @garyduan

@jayhuang-suse @becitsthere @garyduan Any update on this?
and I am expecting a feature similar to this: https://docs.cilium.io/en/v1.12/gettingstarted/tls-visibility

If Istio sidecar encrypt the traffic, we can inspect the traffic before encryption. In other cases, we don't support DPI on TLS yet.


Check rocksdb oldest snapshot before executing delete_files_in_range_cf

Feature Request
Is your feature request related to a problem? Please describe:
TiKV uses delete_files_in_range_cf to speed up RocksDB reclaim space, however, it may break existing snapshots.
The current workaround is to delay delete_files_in_range_cf about 10min(it also is the max txn time for tidb).
It has a few downsides:

it may still break some outstanding snapshots.
reclaim space is slow which makes PD hard to balance store size.

Describe the feature you'd like:
Check RocksDB oldest snapshot before delete_files_in_range_cf.
Describe alternatives you've considered:
Set a larger delay, it may reduce the possibility of 1, but make 2 even worse.
Cc @5kbpers @shuning @Connor1996

you mean record the current RocksDB sequence number when destroying peer, and call delete_files_in_range_cf once the oldest snapshot's sequence number exceeds the previously recorded one? but seems sequence number is hard to get from outer /cc @yiwu-arbug

I am not sure the seq number would work, my initial thought is the db->snapshots().GetOldestSnapshotTime, it returns an unix timestamp which can be compared with region workers StalePeerInfo.timeout.
https://github.com/tikv/tikv/blob/e355e6d66ce2668020037cf943f3f65c0b4eccbc/src/raftstore/store/worker/region.rs#L98-L104

Oh, I didn't notice that there was a snapshot time in Rocksdb snapshot. Check the code and find Rocksdb's property kOldestSnapshotTime would be useful for us~


[#979] Configure drainer pod to expose it's IP address

Set it as draft as it depends on https://github.com/artemiscloud/activemq-artemis-broker-kubernetes-image/pull/106

The test is supposed to fail until this PR is merged.

I find it difficult to reason about this change in the context that the pod wants to be a client of the cluster but is also not part of the cluster. The IP will probably work, but that is transient. I think if the first attempt to scaledown fails it will cause another similar problem as there will be two different IPs in play.
I wonder if we should take the first step to a different approach and keep the scaling down pod alive? All of the other logic can remain similar, with the jmx call etc, but at least the cluster logic will be preserved. What we may need to do in addition is stop/pause the acceptors (or add in a connection router that rejects all)
This may be a step to far, but it may also be a good step in the right direction.

I find it difficult to reason about this change in the context that the pod wants to be a client of the cluster but is also not part of the cluster. The IP will probably work, but that is transient. I think if the first attempt to scaledown fails it will cause another similar problem as there will be two different IPs in play. I wonder if we should take the first step to a different approach and keep the scaling down pod alive? All of the other logic can remain similar, with the jmx call etc, but at least the cluster logic will be preserved. What we may need to do in addition is stop/pause the acceptors (or add in a connection router that rejects all)
This may be a step to far, but it may also be a good step in the right direction.

As we discussed that we can improve this in the next release as part of the effort to refactor the whole scale down mechanism. For the the IP solution should work as expected and is a valid fix for the current implementation.

Until next release to bring in fix on the broker container image, this PR should not be merged as the test will fail.

@gaohoward I updated the related images, see https://github.com/artemiscloud/activemq-artemis-operator/commit/58bcb0b3c714a750500a13a1360b7d77a1b267a5
Can you rebase your branch?

@gaohoward I updated the related images, see 58bcb0b
Can you rebase your branch?

will do.

@howardgao the test Scale down controller scaledown to the right pod failed 3 times in a row on my laptop, could you double-check?
  [FAILED] Timed out after 180.001s.
  The function passed to Eventually failed at /home/dbruscin/Workspace/brusdev/artemiscloud/activemq-artemis-operator/controllers/activemqartemisscaledown_controller_test.go:388 with:
  Expected
      <string>: {"request":{"mbean":"org.apache.activemq.artemis:address=\"DLQ\",broker=\"amq-broker\",component=addresses","attribute":"MessageCount","type":"read"},"value":0,"timestamp":1721729906,"status":200}
  to contain substring
      <string>: "value":2
  In [It] at: /home/dbruscin/Workspace/brusdev/artemiscloud/activemq-artemis-operator/controllers/activemqartemisscaledown_controller_test.go:390

@howardgao the test Scale down controller scaledown to the right pod failed 3 times in a row on my laptop, could you double-check?
  [FAILED] Timed out after 180.001s.
  The function passed to Eventually failed at /home/dbruscin/Workspace/brusdev/artemiscloud/activemq-artemis-operator/controllers/activemqartemisscaledown_controller_test.go:388 with:
  Expected
      <string>: {"request":{"mbean":"org.apache.activemq.artemis:address=\"DLQ\",broker=\"amq-broker\",component=addresses","attribute":"MessageCount","type":"read"},"value":0,"timestamp":1721729906,"status":200}
  to contain substring
      <string>: "value":2
  In [It] at: /home/dbruscin/Workspace/brusdev/artemiscloud/activemq-artemis-operator/controllers/activemqartemisscaledown_controller_test.go:390

will take a look. Thanks

Hi Dom, regarding the test failure I think we should revert the test  to align with this revert
https://github.com/artemiscloud/activemq-artemis-broker-kubernetes-image/commit/4b3d68c8631bbf5340c9614a416303e8e350a9a3
Without this commit the test would fail for sure.
I'll revert the test in another PR if you agree.

Hi Dom, regarding the test failure I think we should revert the test to align with this revert artemiscloud/activemq-artemis-broker-kubernetes-image@4b3d68c Without this commit the test would fail for sure. I'll revert the test in another PR if you agree.

@howardgao alternatively, you could push a separate commit to revert that test in this same branch you are using for this PR. In this way we can validate and merge both changes at the same time.

Hi Dom, regarding the test failure I think we should revert the test to align with this revert artemiscloud/activemq-artemis-broker-kubernetes-image@4b3d68c Without this commit the test would fail for sure. I'll revert the test in another PR if you agree.

@howardgao alternatively, you could push a separate commit to revert that test in this same branch you are using for this PR. In this way we can validate and merge both changes at the same time.

@brusdev Test reverted.

Full test-suite passed.

Thank you Dom


setting up and $ yarn prisma init foo -- what choices to make?

First I am presented with:
? How to set up a new Prisma service? (Use arrow keys)

❯ Minimal setup: database-only
  GraphQL server/fullstack boilerplate (recommended)

I chose the second option. Next I see:
? Choose GraphQL boilerplate project: (Use arrow keys)
❯ node-basic              Basic GraphQL server (incl. database)
  node-advanced           GraphQL server (incl. database & authentication)
  typescript-basic        Basic GraphQL server (incl. database)
  typescript-advanced     GraphQL server (incl. database & authentication)
  react-fullstack-basic   React app + GraphQL server (incl. database )

I chose "typescript-advanced". Next I see:
? Please choose the cluster you want to deploy "foo@dev" to (Use arrow keys)

❯ prisma-eu1      Public development cluster (hosted in EU on Prisma Cloud)
  prisma-us1      Public development cluster (hosted in US on Prisma Cloud)
  local           Local cluster (requires Docker)

  Log in or create new account on Prisma Cloud

  Note: When not logged in, service deployments to Prisma Cloud expire after 7 days.
  You can learn more about deployment in the docs: http://bit.ly/prisma-graphql-deployment

I chose "prisma-us1". Then I ran yarn dev and everything started up fine. I opened a new terminal and ran yarn deploy and got the following error:
[~/Sites/este (Prisma)]$ yarn deploy
yarn run v1.3.2
$ node ./scripts/deploy
TODO: Deploy DB with config etc.
/bin/sh: now: command not found
child_process.js:644
    throw err;
    ^

Error: Command failed: now --env APP_VERSION="138922a9c30515bf0592d255adcf0eacb70414c9"
    at checkExecSyncError (child_process.js:601:13)
    at execSync (child_process.js:641:13)
    at Object.<anonymous> (/Users/rkoberg/Sites/este/scripts/deploy.js:17:1)
    at Module._compile (module.js:643:30)
    at Object.Module._extensions..js (module.js:654:10)
    at Module.load (module.js:556:32)
    at tryModuleLoad (module.js:499:12)
    at Function.Module._load (module.js:491:3)
    at Function.Module.runMain (module.js:684:10)
    at startup (bootstrap_node.js:187:16)
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
[~/Sites/este (Prisma)]$

OK, I did not have now installed globally and don't know anything about it. I installed it globally. It says I need to login, so I ran:
$ now login
> We sent an email to<EMAIL_ADDRESS>Please follow the steps provided
  inside it and make sure the security code matches Zealous Golden Lion Tamarin.
✔ Email confirmed
✔ Fetched your personal details
> Ready! Authentication token and personal details saved in "~/.now"

Then I ran yarn deploy again. I got an error about "next" not being there, but it is in the package.json dependencies, so not sure what is going on?
[rkoberg@imac ~/Sites/este (Prisma *)]$ yarn deploy
yarn run v1.3.2
$ node ./scripts/deploy
TODO: Deploy DB with config etc.
> Deploying ~/Sites/este under<EMAIL_ADDRESS>> Using Node.js 8.9.4 (requested: `8.x.x`)
> Ready! https://este-eroigchetg.now.sh (copied to clipboard) [55s]
> You<EMAIL_ADDRESS>are on the OSS plan. Your code and logs will be made public.
> NOTE: You can use `now --public` to skip this prompt
> Synced 164 files (1.23MB) [20s]
> Initializing…
> Building
> ▲ npm install
> ✓ Using "package-lock.json"
> ⧗ Installing 66 main dependencies…
> ✓ Installed 476 modules [20s]
> ▲ npm run build
> > este@ build /home/nowuser/src
> > next build
> sh: next: not found
> npm ERR! file sh
> npm ERR! code ELIFECYCLE
> npm ERR! errno ENOENT
> npm ERR! syscall spawn
> npm ERR! este@ build: `next build`
> npm ERR! spawn ENOENT
> npm ERR!
> npm ERR! Failed at the este@ build script.
> npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
> npm ERR! A complete log of this run can be found in:
> npm ERR!     /home/nowuser/.npm/_logs/2018-02-05T18_41_38_587Z-debug.log
> Error! The build step of your project failed. To retry, run `now --force`.
child_process.js:644
    throw err;
    ^

Error: Command failed: now --env APP_VERSION="138922a9c30515bf0592d255adcf0eacb70414c9"
    at checkExecSyncError (child_process.js:601:13)
    at execSync (child_process.js:641:13)
    at Object.<anonymous> (/Users/rkoberg/Sites/este/scripts/deploy.js:17:1)
    at Module._compile (module.js:643:30)
    at Object.Module._extensions..js (module.js:654:10)
    at Module.load (module.js:556:32)
    at tryModuleLoad (module.js:499:12)
    at Function.Module._load (module.js:491:3)
    at Function.Module.runMain (module.js:684:10)
    at startup (bootstrap_node.js:187:16)
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
[rkoberg@imac ~/Sites/este (Prisma *)]$

I tried deleting package-lock.json, the yarn.lock as well as adding --force to the deploy script, but get an error:
[rkoberg@imac ~/Sites/este (Prisma *)]$ yarn deploy
yarn run v1.3.2
$ node ./scripts/deploy
TODO: Deploy DB with config etc.
> Deploying ~/Sites/este under<EMAIL_ADDRESS>> Using Node.js 8.9.4 (requested: `8.x.x`)
> Ready! https://este-zzugozaddy.now.sh (copied to clipboard) [8s]
> You<EMAIL_ADDRESS>are on the OSS plan. Your code and logs will be made public.
> NOTE: You can use `now --public` to skip this prompt
> Synced 1 file (19.54KB) [7s]
> Initializing…
> Error! The build step of your project failed. To retry, run `now --force`.
child_process.js:644
    throw err;
    ^

Error: Command failed: now --env APP_VERSION="138922a9c30515bf0592d255adcf0eacb70414c9"
    at checkExecSyncError (child_process.js:601:13)
    at execSync (child_process.js:641:13)
    at Object.<anonymous> (/Users/rkoberg/Sites/este/scripts/deploy.js:17:1)
    at Module._compile (module.js:643:30)
    at Object.Module._extensions..js (module.js:654:10)
    at Module.load (module.js:556:32)
    at tryModuleLoad (module.js:499:12)
    at Function.Module._load (module.js:491:3)
    at Function.Module.runMain (module.js:684:10)
    at startup (bootstrap_node.js:187:16)
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
[rkoberg@imac ~/Sites/este (Prisma *)]$

Learn Prisme outside of Este, then you will understand.


Add support for delete animation in LayoutAnimation on Android

Android follow up to #6779
Test plan
Tested add/removing views in the UIExample explorer with and without setting a LayoutAnimation. Tested that user interation during the animation is properly disabled.

@janicduplessis updated the pull request.

#socool
Let me send a link to this PR to Olivier who implemented the LayoutAnimation on Android.
Also cc @astreet and @kmagiera

@ericvicenti would you mind taking a look at this pull request? It's been a while since the last commit was reviewed.

@janicduplessis I just pinged @astreet and Olivier.

Thanks for taking this on, looks like the right direction! I'd also like to get Oli's thoughts

@janicduplessis updated the pull request.

@janicduplessis updated the pull request.

@janicduplessis updated the pull request.

@janicduplessis updated the pull request.

@astreet Thanks for reviewing this! Addressed most of the things you pointed out.

Sorry about the late review, looks great, thanks for updating! :)
@facebook-github-bot shipit

Thanks for importing. If you are an FB employee go to Phabricator to review.


SGDET task

Sorry to ask again, I have been puzzled by a problem recently, that is, when conducting SGDET task training tests, single-card training always interrupts during the evaluation test, as shown in the figure. My command bashsize=1 doesn't work either. Have you ever encountered this situation, or have you any suggestions? Thank you for your help.

Apologies for the late reply.
The cause of this error might be a memory issue, where the SGDET mode requires at least 64G of memory.
As for the suggestions, you can run in the debug mode using pycharm or vscode. Then check what exactly the error is.

Thank you very much for your answer.


⚠ ClamAV has degraded performance

In 0169dad, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 99 ms

Resolved: ClamAV performance has improved in b919db0 after 5 minutes.


add a flag to skip SIGINT and SIGTERM signals registration

What's the reasoning behind this change?

@seemethere, because I need the app running in a second thread, and this signals can just be listen from the main thread. (If you try to run the app in a second thread you got a error).

Seems like a fine idea -- can you fix the merge conflicts?

Also adding a complete example to the examples/ would help illustrate the usefulness.


Click on PDF to jump to text does not work after TEST with #show "TEST": text.with(hyphenate: false)

Description
Having
#show "TEST": text.with(hyphenate: false).
The jumping to the text does not jump to the right position. It appears as after TEST the position starts egain from the beginning of the line. What I mean by that is that when I click on 5 it works, but clicking one 7 jumps to 2.
1 2 3 4 5 TEST 6 7 8 9
Reproduction URL
No response
Browsers
Chrome
OS
macOS

any updated on that?

No update so far. Click-to-jump in combination with text show rules is a best-effort.


Missing tests for the groups argument in convolution Links

The common groups argument to the constructors of the Convolution{2,N}D, Deconvolution{2,N}D Links are not tested in their corresponding unit tests.
I suggest we add tests to cover this argument (e.g. check invalid groups and weights shapes).

Merged to #4332.


Keyboard Shortcut Interactions

Do you know if Chrome OS keyboard shortcuts override/collide with a Chrome App's shortcuts, or vice versa?
NOTE: Issue #93 is loosely related.

With most of the keyboard shortcuts completed I have at least a tentative answer that seems correct in most situations regarding your question on overriding/colliding.  Most of the shortcuts you have sent to us do not overlap with those defined for ChromeOS so we been significantly obstructed yet.  We have found that in some cases you need to enable or disable default behavior. Other keyboard combinations, namely those that include ‘Tab’, have limited functionality by default for accessibility reasons.
In ChromeIDE we deal with some overrides and force the app to take precedent by explicitly preventing browser default behavior.  We have yet to test whether this approach will work on ChromeOS.  So far we have found that our browser-based testing environment is not the same as the App, and we tend to encounter less keyboard mapping conflicts in the App; this is promising.  We have yet to complete our testing on the Chromebook though so I’ll need to get back to you.
Some resources that might help satisfy your curiosity.
ChromeOS keyboard shortcuts
ChromeApp command API

Thanks @urbantumbleweed.  Hopefully we don't run into a big problem that is difficult to resolve.  The Tab issue concerns me.

Please see the response on #88


Update UIKit with local cache

connect #52

I am a bit confuse on the reason on having this.async at RealmStore. And it has no effect on delete related function... will it make the usage on get/delete asymmetry? It seems not a good API to use.

If everything is sync, the android ui would throw a lot of warnings, becoz the load more messages call is mostly likely triggered by a scroll event.
However, the store is also used by test, and I want to keep the test case simple and synchronous, so the realm store has this option.
Oh, I was just being lazy, becoz the warnings only throw on get, I will also make write and delete take care of the async flag.

@rickmak I am going to merge this when steven made some minor changes I requested

I am going to make the changes and merge to master.

@Steven-Chan sorry the pull request is failing

@cheungpat Updated and travis passed.


don't accept empty string or / as app id

Currently, the marathon API allows to create apps with "id": "". Not only do I think that doesn't make sense, it also caused issues with mesos: It will create tasks with an empty name which are not removed from mesos when deleting the app.

Ugh just realised that check is not exhaustive enough, things like " " will probably cause issues too. Are there validation rules for this I can reuse already?

This requires more validation. For example, sending "id":"/" has the same problems as the empty string before. Am i correct in assuming that the "root" path can never be suitable as an app id?

Zombie tasks in Mesos, which are not removed by marathon when DELETEin the rooth path:

@c089 Yes, the root is a group where all top level tasks live, so it may not be used as an app id.

So this should fix it for now. I'm not familiar enough with the codebase to make up my mind, but I feel it might be a good idea to change the AppDefinition class itself to use a custom type instead of PathId.

@c089 Could you please add the constraint that an app id can not be / in the Reads and add a test for this case? Also please squash this into a single commit, thanks!

I'd love to but right now I fail at understanding this :/
How would I add an "and not equal to"?

It should be enough to append .filter(_.isRoot)

thanks! squashed and rebased onto master

:100: Thanks!


A delta typo

First of all, Thanks a lot for your great website! Really hats off!
In the link, generative should be discriminative in the second bullet point.
Apologies for opening an issue for a very small thing.
Thanks.

You are right - thank you a lot for the help! Fixed.
Best,
Lena.


Please move to ng-template to support ng4

From @born2net on March 26, 2017 1:40
Please move to <ng-template/> to support ng4
tx
Sean
Copied from original issue: isaacplmann/angular2-contextmenu#60

From @born2net on March 27, 2017 13:12
great tx!

Yes, thanks for the reminder.  I'll shoot for the end of the week.

Fixed with the rename to ngx-contextmenu.

From @born2net on March 31, 2017 20:50
do we need to change anything in the code?

Yeah, there are some breaking changes.  See https://github.com/isaacplmann/ngx-contextmenu.  Documentation is a bit sparse now.  I'll try to write more through upgrade steps on Monday.

From @born2net on March 31, 2017 20:52
great will look fwd to it.. TX!!!!
Angular 2 Kitchen sink: http://ng2.javascriptninja.io
and source@ https://github.com/born2net/Angular-kitchen-sink
Regards,
Sean

Upgrade documentation now in readme.

tx!!!

In latest version from today  when I make a selection on the context menu, the context menu does not close.
Should I open a separate bug?

Yes, separate bug please.  The context menu is closing for me.


fix(remix-react): detect index route from manifest in useFormAction

The useFormAction hook detects the file ID ending in "/index" to determine whether or not to return a form action with the  ?index search param. This holds true in Remix's default route convention. However, in the case where the consumer defines custom routes, this may not hold true anymore.

Testing Strategy:
I'm using the Remix Flat Routes flat-folders convention in my project.
Let's say I have a route _auth.dashboard.index/_routes.tsx. That's considered to be an index route in the flat-folders convention. However, rendering a <Form> in that route results in a form with the action "/dashboard" while the action should be "/dashboard?index".

@penspinner Could you please also add a test for this change?

Awesome work @penspinner. BTW: I did fix remix flat routes to work around this issue. I append /index to all the index route ids so Remix works properly. Once this PR lands, I'll be able to remove the hack. Thanks!

Hi @penspinner!
Are you still interested in getting this one merged?
If so, please rebase onto latest dev & resolve conflicts

@MichaelDeBoey This seems to have been fixed in React Router. Gonna close this.


shiiit

Use the commit message structure we agreed on.

Use proper commit message structure

I more than approve your comment

@SecioreanuStefanita  UPPP

@Costinteo what should we do lol


SAK-43277 - Group Manager: Create New Group: Members are in no partic…

…ular order

 Here is an overview of what got changed by this pull request:

Complexity increasing per file
==============================
- site-manage/site-group-manager/src/main/java/org/sakaiproject/groupmanager/util/UserComparator.java  1

See the complete overview on Codacy

 Here is an overview of what got changed by this pull request:

Complexity increasing per file
==============================
- site-manage/site-group-manager/src/main/java/org/sakaiproject/groupmanager/util/UserComparator.java  1

See the complete overview on Codacy


Slack channel invite link incorrect

For the website - https://openmined.org/
The url - Slack invite
returns as

This invite link is no longer active. Please check with the person who shared it with you to see if there's a new link available.

Deployed.


globalSetup doesn't process styleMocks / moduleNameMappers

🐛 Bug Report
globalSetup does not work with moduleNameMappers. In most setups this would be ok, but there are situations such as SSR where you want to setup a server once, you can run into issues with this.
Related to: https://github.com/facebook/jest/issues/5164
To Reproduce

Set up a styleMock and a globalSetup file
import a React component that imports a stylesheet in a globalSetup file

Expected behavior
globalSetup processes moduleNameMappers. The idea that globalSetup runs before "everything" is not practical. Setup will generally require some configuration options for things to work.
Run npx envinfo --preset jest
Paste the results here:

  System:
    OS: macOS Sierra 10.12.6
    CPU: x64 Intel(R) Core(TM) i7-3615QM CPU @ 2.30GHz
  Binaries:
    Node: 8.9.4 - ~/.nvm/versions/node/v8.9.4/bin/node
    Yarn: 1.5.1 - /usr/local/bin/yarn
    npm: 6.0.0 - /Users/Shared/java/projects/react/projects/mobile-minds/node_modules/.bin/npm
  npmPackages:
    jest: 22.4.3 => 22.4.3

The workaround I currently use for both this issue and the related babel-transpile issue:
require('babel-register');
require('babel-polyfill');
['.css', '.eot', '.woff', '.ttf'].forEach(ext => {
  require.extensions[ext] = () => ({});
});

['.svg', '.png', '.jpg'].forEach(ext => {
  require.extensions[ext] = () => '';
});

Any updates on this issue?

same

Here is a runnable reproduction of the bug:
https://codesandbox.io/s/boring-wilbur-ibkmj
Reproduction steps
1 - Un-comment globalSetup line in jest.config.js:
globalSetup: './tests/globalSetup.js'

2 - Run the following in the terminal:
yarn test

Error output:
Error: Cannot find module '@/utils'
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:636:15)
    at Function.Module._load (internal/modules/cjs/loader.js:562:25)
    at Module.require (internal/modules/cjs/loader.js:690:17)
    at require (internal/modules/cjs/helpers.js:25:18)
    at Object.<anonymous> (/sandbox/tests/globalSetup.js:3:5)
    at Module._compile (internal/modules/cjs/loader.js:776:30)
    at Module._compile (/sandbox/node_modules/pirates/lib/index.js:99:24)
    at Module._extensions..js (internal/modules/cjs/loader.js:787:10)
    at Object.newLoader [as .js] (/sandbox/node_modules/pirates/lib/index.js:104:7)
    at Module.load (internal/modules/cjs/loader.js:653:32)

Would be really nice to have this working!
@rickhanlonii @SimenB

This seems like a feature request, can you post a full example of the bug?

I disagree, don't think this is a feature request but rather a bug:
The moduleNameMapper configuration is correctly respected in all setupFilesAfterEnv and setupFiles for example. globalSetup and globalTeardown surprisingly don't respect that :/
Reproduction on latest jest version
I prepared a simple reproduction on the latest jest version 25.2.7, see https://codesandbox.io/s/jest-globalsetup-modulenamemapper-bug-g1ol7 and the README.
This is currently preventing us from speeding up our test setup substantially, because we cannot re-use a service for all tests and instead have to re-create it for every test file by putting it in a setupFiles entry. We'd love to see this fixed, let me know if I can be of any more help!
Thank you :)

Thanks for the repro cases, I agree this is a bug now (or a feature request to change the behavior, however you want to look at it). If anyone wants to submit a PR to fix it I'm happy to review!

If anyone wants to submit a PR to fix it I'm happy to review!

@rickhanlonii I'm happy to take a look at it. Do you have any recommendations into where I might start looking as a first-time contributor? Thanks!

@stnwk I do not - I would grep for setupFilesAfterEnv and track down how it uses moduleNameMapper, and then grep for globalSetup to see why it doesn't use it. Let me know if you have any questions 👍


Customizable Rollups: API to Retrieve Rollup Definitions - serialization fix

After testing with the bata package, it's not possible to serialize the response when it's returned as an object that is not global. As a result, the api needs to return a serialized string rather than List<CRLP_Rollup> so that the contents can be maintained stateful in the bridge as well as written into the Big Object for persistent storage of the summaries.
Critical Changes
Changes
Issues Closed
New Metadata
Deleted Metadata

@force2b - I'm guessing this doesn't need any release notes. Is that correct?

@sam-knox Correct. The api is an early release for the DSO Bridge. I'd prefer that we not include it in the release notes until we're positive that it's finalized and usable by customers.


Change the default location for annotation processor generated sources to a source directory

The annotation processors default behavior is to write the generated sources to the /build/classes/java/<sourceSet>/ folder. This pollutes the compiled classes directory and implementation JAR with source code. Also, the sources are not available in the sources JAR file and are not included as source folders in the IDEs (https://github.com/gradle/gradle/issues/4499).
Expected Behavior

The options.annotationProcessorGeneratedSourcesDirectory should default to a source directory. For example: build/generated/src/<sourceSet>/java
Gradle should automatically create and clean the generated source directories.
The generated source directories should be included as source folders in sources in the IDEs (https://github.com/gradle/gradle/issues/4499).
The generated sources should be included in the *-sources.jar

Current Workaround
Example to configure a different output directory for the main source set in samples/java/incrementalAnnotationProcessing/user/build.gradle:
compileJava {
    String relativePath = "build/generated/src/main/java"
    sourceSets.main.java { srcDir relativePath }
    File generatedSourceDir = project.file("build/generated/src/main/java")
    println "Creating and configuring generated source directory $generatedSourceDir"
    project.mkdir(generatedSourceDir)
    options.annotationProcessorGeneratedSourcesDirectory = generatedSourceDir
    outputs.dir(generatedSourceDir)

    doFirst {
        // force a clean of generatedSourceDir to prevent java.lang.IllegalStateException: endPosTable already set. This shouldn't be need if using Gradle 4.8+ or Java 9+.
        project.delete(generatedSourceDir)
        project.mkdir(generatedSourceDir)
    }
}

Related: https://github.com/gradle/gradle/issues/2300

converting from the apt plugin and got bitten by this with error prone, because I had, had the sources output to generated so they weren't scanned, then surprise! they are again.


[BUG] Dispenser water sometimes wont flow in claims.

Versions
Spigot/Paper/Sponge: 1.16.5
GriefDefender: Latest
LuckPerms:

Describe the bug
In some instances water wont flow when dispensed by a dispenser inside the claim. This issue only happens inside claims.

Steps to reproduce the behavior
This was found in a regular creeperfarm. Some of the layer's dispensers are firing the water but it's not spreading unless updated. Some of the layer's water does flow

Expected behavior
The water should be flowing over the dispenser as normal.

GDDEBUG

Screenshots

Fill out the requested information correctly please, and provide a debug. 1.16.5 tells us nothing of the platform used, and latest is not a GD version.


[UI] Replicate Imports for Filters and Application

Current Behavior
The file import buttons are in the table toolbar for filters and applications

Desired Behavior
Change it accordingly to the patterns UI import buttons to have a smooth user experience across all configurations

Implementation
Refer to the current implementation of import buttons in patterns UI

Contributor Guides and Resources

🎨 Wireframes and designs for Meshery UI in Figma
🖥 Contributing to Meshery UI
🙋🏾🙋🏼 Questions: Layer5 Discussion Forum and Layer5 Community Slack

Can I work on this issue @Chadha93

@Chadha93 Can I please take up this issue in case @Akshit42-hue is not working on this?
P. S. I have approxiametely implemented the solution locally.

Go ahead @SAEb-ai . I am unassigning myself


Can´t deploy my Vanilla Emmy app on Github Pages

When I don´t use my username repo, it doesn't work

We'll add the Emmy.js + Vite documentation


feat(cmd):  custom p2p key flag

About
Currently, only start cmd works with a custom private key.  To make init work #291 and #292 have to be merged.
Closes #284

Ok, closing this PR:

Flags should now be implemented and based over #313
Approach with the flag is not the way to go, as we figured out.


[Suffix] Add suffix as a column to applicants table

Description
Adding a column suffix to applicant table. More details see design doc.
Checklist
General
Read the full guidelines for PRs here

[x] Added the correct label: < feature | enhancement | bug | under-development | dependencies | infrastructure | ignore-for-release | database >
[x] Assigned to a specific person, civiform/developers, or a more specific round-robin list
[x] Added an additional reviewer from outside your organization as FYI (if the primary reviewer is in the same organization as you)

Database evolutions
Read the guidelines here

[x] Assigned two reviewers
[x] Guarded against already existing resources using IF NOT EXISTS and IF EXISTS
[x] Downs created to undo changes in Ups

Issue(s) this completes
Fixes #8167

One naming question / suggestion. Otherwise, confirming you ran this locally without any issues in the evolution?

yeah I ran this locally, seems good to me here's the screenshot


DeviceMesh Feature Support for creating submesh views

Initial supported implemented in: https://github.com/tenstorrent/tt-metal/pull/10872


Unimportant: ask to speak button is slightly off center

The ask to speak button appears to be slightly to the left of where it should be. I hope not many programmers have OCD.

@DeanHuffnagle Seems that this issue has already been resolved. Consider closing it.

I didn't know it was up to me to close the issue. I am new to github, My apologies.

@DeanHuffnagle No problem.


Using ejs with Forge v6 and electron-compile

[X] I have read the contribution documentation for this project.
[X] I agree to follow the code of conduct that this project follows, as appropriate.
[X] I have searched the issue tracker for an issue that matches the one I want to file, without success.

Please describe your issue:
I'm currently using the ejs-electron module (https://www.npmjs.com/package/ejs-electron) and it works perfectly with electron (if I run npm start it works perfectly but if run electron-forge start it doesn't ). When I run electron-forge make and execute the squirrel.windows exe it throws the following error: https://prnt.sc/kkw5dp.
I'm not sure what is the cause of the error, if it is the ejs module not loaded by electron-forge or something else.
The very strange thing is that npm start actually call the electron-forge start command, so why it works with npm and not directly with electron-forge?
My project folder setup:
root folder/
|- node_modules/
|- package.json
|- build/ (contains the icons to be used by electron-forge)
|- src/
   |- public/ (contains css and js files)
   |- routes/ (contains js file for each part of my app)
   |- views/ (contais the ejs files)
      |- partials/ (contains ejs file to be included inside others)
   |- index.js

Here's my package.json -> https://hastebin.com/qajularece.json

Console output when you run electron-forge with the environment variable DEBUG=electron-forge:*. (Instructions on how to do so here). Please include the stack trace if one exists.
A:\Programmi\JetBrains\apps\WebStorm\ch-0\182.3911.37\bin\runnerw.exe C:\Users\filip\AppData\Roaming\npm\node_modules\electron-forge\script\vscode.cmd C:\Users\filip\Desktop\LauncherForge\src\index.js
WARNING: DEBUG environment variable detected.  Progress indicators will be sent over electron-forge:lifecycle

C:\Users\filip\AppData\Roaming\SoulNetworkLauncher
C:\Users\filip\Desktop\LauncherForge
DONE
(node:2600) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 1): URIError: URI malformed
(node:2600) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

What command line arguments are you passing?
start
What does your config.forge data in package.json look like?
"config": {
    "forge": {
      "packagerConfig": {},
      "makers": [
        {
          "name": "@electron-forge/maker-squirrel",
          "config": {
            "authors": "Tito Tigi, SoulNetwork",
            "description": "Launcher ufficiale di SoulNetwork",
            "exe": "SoulNetwork Launcher",
            "iconUrl": "build/icon.ico",
            "loadingGif": "build/loadingGif.gif",
            "setupExe": "SoulNetwork Launcher Installer",
            "setupIcon": "build/icon.ico"
          }
        }
      ]
    }
  },

Please provide either a failing minimal testcase (with a link to the code) or detailed steps to
reproduce your problem. Using electron-forge init is a good starting point, if that is not the
source of your problem.

You should probably use the electron-compile plugin for Electron Forge v6, if you're going to use v6 instead of v5. Unfortunately, the docs for that haven't been written yet, as v6 is still in beta.

The very strange thing is that npm start actually call the electron-forge start command, so why it works with npm and not directly with electron-forge?

If you run electron-forge start you're running the globally installed electron-forge. You might want to check that it's the same version as the one that's installed in your app.

It worked, thank you very much!


Can't validate playstore license: functionality restricted

Used the LL build here; was working fine until today when I tried to edit a desktop, and it showed a message "Can't validate playstore license", then refused to allow me to edit. I checked on playstore and realized that LL got removed
Is there a way to avoid this error, so that I can get back to editing desktops again? Rest of LL functionality seems to be fine (app drawer, shortcuts, etc.)

An update that fixes this would be great. The bug also prevents one from restoring a backup, and I mistakenly uninstalled/reinstalled LL trying to fix the bug but created a bigger issue now of not being able to restore any backups ...

Can confirm that toggling airplane mode on and off is a workaround for now at least.

Thank you! Airplane mode works for now

Update: the current version here should not have that issue, but as already noticed the backup/restore functionality is not working due to storage permission issues.
I saw that @SnowVolf was working on a full rewrite of that screen, but in the meantime I'll try to upload today/tomorrow a quick fix.

Update: I added a quick workaround to allow restoring backup in the debug version. Creating backups may take a bit more time, but at least this way you should be able to use the app with existing data.
If you have any issues, just say so.

I understand that this issue is being worked on, appreciate that LL still works on Android 14!
Cannot upgrade to debug version that was posted today, it tells me that the package appears to be invalid.

The current version is not signed, and even if it were it will never be signed with the same key (it's private to Pierre) so I'm afraid you will never be able to update the current installation (maybe with root).
This means that you need to uninstall the existing app to be able to install the new one.
However I'm going to change the app id so that it can be installed as an independent version (I should have made that from the start to be honest). You can wait until that's done if you prefer.

For anyone following this, I was able to upgrade to the debug version from TrianguloY's original release using the following ADB commands:
 adb uninstall -k net.pierrox.lightning_launcher
 adb install -r lightning_launcher-extreme-armv64-debug-330.apk

I am happy that something is happening about Lightning Launcher... because I have new phone, and now I discovered I can not install LL anymore. I bought it years and years ago... and didnt find better launcher till today...

Sorry for the lack of updates. This post should explain the current situation:
First of all, I've always been a power user of LL, and it's been a really important part of my life. Seeing it being discontinued was hard, so that's why I pushed to publish the source code. Personally I'm still using LL as my main launcher, and I continue to do so until it is really impossible to use.
As for updates, even though I would love to, truth be told I have my own personal projects and this app is very complex and big to maintain. I'm sorry if this is disappointing, but most probably I won't spend time working on new features.
Then SVolf offered to do it. I took a role of reviewer, and even though I didn't like some of the decisions (Kotlin/koin/minsdk) I didn't want to stop the only person that offered to really update the app. I personally continued to use the original version, but I wanted to see how far this updated one went.
And finally, the end-of-license arrived. All Pierre apps have been removed from play store (either/google deleted his account or the apps were removed due to being very outdated). This made the app fail the license check, and it became a trial that expired and forced you to buy something that no longer exists.
SVolf version doesn't have this issue, but since the app is compiled for newer android versions (with a lot more restrictions) some things are broken. I managed to easily fix the restore functionality, but the backup was just too much because, as I said, it feels like a burden and...it's hard to describe (it's like trying to preserve a very old painting you love, even if you know it needs a restoration).
So, I made the following:
First, I went back to the original 14.3 version and removed the license check (trying to preserve all the non-license code intact as much as possible). Then I changed the package id (from net.pierrox.lightning_launcher_extreme to net.pierrox.lightning_launcher_community) as well as other ids in order to be able to install the app alongside the original. This breaks some scripts (if you have the original package hard-coded) but it allowed me to "migrate" and use this new launcher while keeping the original installed (even if it's in a "read-only" state, I don't want to lose it...).
I'm publishing this patched_community version, as well as a patched one without the package id change (for those of you who don't mind removing the original and/or keep scripts working). All these versions are signed with my own developer key, and they are intended to be a replacement "patch".
More details in the release description.
I don't know what will happen in the future, but I'm sure that I'll continue using the 14.3 version (patched community) until I can (or until someone wants to continue SVolf's work).

Much appreciated! Fine solution.

@TrianguloY could you please build the permission apks? I would like to use your patched_community build, but the permission apks need to be signed with the same developer key.

@TrianguloY could you please build the permission apks? I would like to use your patched_community build, but the permission apks need to be signed with the same developer key.

Here you have: patched and patched community.
Hopefully it works, if not please tell me (I must admit that I've never used them).
Note: it is a single apk with all permissions, instead of one apk for each. Both because it is way easier for me to build them (I do it manually) and also because on latest android versions you need to explicitly grant them anyway.

Hopefully it works, if not please tell me (I must admit that I've never used them).

All works great, the only thing is that clear text HTTP traffic is not permitted, like it was in the original LL apks. You can refer to my commit to the internet permission APK some time ago or I can make a request to this new APK tomorrow.

Hopefully it works, if not please tell me (I must admit that I've never used them).

All works great, the only thing is that clear text HTTP traffic is not permitted, like it was in the original LL apks. You can refer to my commit to the internet permission APK some time ago or I can make a request to this new APK tomorrow.

arg, you are right.
Originally I tried to create the apk with the original permission minsdk, and the clear text http traffic tag was simply not supported so I had to remove it. Later I increased the sdk (it had some issues but also I preferred to use the same as the launcher itself) and just forgot to add the tag again.
Sorry! I'll add it tomorrow.

The permissions apks have been updated
@summer-son

Thanks @TrianguloY but looks like it still doesn't work. I've checked the source code, all seems fine. The only thought that comes to my mind is that Cleartext should be also allowed in the launcher app itself too (maybe as the request is coming from it). I assume so since on my modified launcher version it worked, just cause I added all the permissions directly to the launcher app, and didn't use a separate permission APK.

Did it work in the original launcher? The original internet permission apk had a lower minsdk. Not sure if decreasing it could work... Or maybe increasing it? That extra tag is not needed on newer apis. Maybe the launcher needs to be increased...is the debug version working?

The original internet permission APK didn't work as-is (obviously, since it was not allowing Cleartext), and if I'm not mistaken (since it was like 7-8 years ago), I couldn't make it work, because rebuilding permissions APK will build them with a different developer key. Eventually I modified the LL APK to have all the permissions, added Cleartext and built it with my key. I didn't bother to have a separate APK for permissions. This is how I use it until now.
From API 28 the default value is false so one have to set to true manually, other than that I'm not aware of any SDK version requirements.

If your releases are not intended for the Play Store, maybe it's also worth getting rid of a separate APK for permissions? It will be much easier to maintain.

I don't understand the use of this separate permission app. Is it just to automate the manual setting of all permissions in Android's app settings (Settings > Apps > LL > Permissions)?
I just tried to install it (I have the community patch, just uninstalled for good Pierrot's LL), but it won't install.

I don't understand the use of this separate permission app. Is it just to automate the manual setting of all permissions in Android's app settings (Settings > Apps > LL > Permissions)?
I just tried to install it (I have the community patch, just uninstalled for good Pierrot's LL), but it won't install.

The purpose of having a separate app with the permissions, as oppose of adding the permissions to the app directly, was probably to avoid issues with play store (which rejects apps with most permissions). But then:

If your releases are not intended for the Play Store, maybe it's also worth getting rid of a separate APK for permissions? It will be much easier to maintain.

And this is true. However I would still prefer to keep them separate, or at least have an original app without permissions. Personally I don't need them and since the app can arbitrarily run any scripts, even if I'm in control of it I prefer to avoid having them in the first place (specially the internet permissions because for some reason [^1] you cannot disable it without root)
Having a version without permissions and another with them is a possibility, and it may be a good idea to add in the developer branch version, but for the 'patch' that should be just a minimum-changed replacement it's just too much work. What I can add is the cleartext tag, without the internet permission it should be useless after all. (but again, the only person that apprently really needs it has already a custom version so...still if someone needs it just say so and I can try to build it)
[^1]:  (this is a lie, I know the reason, right ad-company-that-develops-android?)

the only person that apprently really needs it has already a custom version

He doesn't 😁 he uses your patches community build, as the old custom version is not working on Android 14...
Not urgent, but for the next build would be nice if you could include the tag!

He doesn't 😁 he uses your patches community build, as the old custom version is not working on Android 14...

Oh! I see, In that case I'll try to generate the version with the tag. But I have other issues to solve in other projects, that I would like to do first, so unfortunately I don't know when I'll be able to.
I mean, it's just a line and pressing a button...it still takes 15 minutes but doesn't require my attention...let me try to do it now...

Done. Please tell me if there is any issue!

Done. Please tell me if there is any issue!

Works perfectly, thank you very much!!!

@TrianguloY thanks for updating the permissions apk with the new signature. But I couldn't find the internet permission there. Is it missing?

It should...but remember that the internet permission is not usually shown (it's like they assume all apps must have access to the internet...).
Please try any internet-related script, if it doesn't work then we can investigate.

Thanks - I tried it and gives me a pop-up box saying I'm missing the INTERNET permission. My workaround now is to reinstall the old ll.apk (with the playstore license issues) and the old ll-internet-permission.apk (which still works)
And when I need the backup/restore functionality, or ability to edit the desktop, use your patched app to make these edits. Then go back to the original ll.apk as daily driver
Bit clunky I know ... but thanks for your help!

thanks for the tip @summer-son! internet permission works now after a reboot


Blank page

Hey thank you for this repo!
Not sure what I am doing wrong, but I am just getting a blank page when I run start and navigate to http://localhost:8080/client/public/ which is where the app is accessible from a docker container.
The docker container itself is from https://github.com/btassone/docker-wasm-rust/
and I had trouble with it as well so perhaps this is the issue: https://github.com/btassone/docker-wasm-rust/issues/1
So, I figured I would just install the pitch-detection-app and resolve any dependancies as needed. Only, I am not quite sure if I was supposed to install each of the components first?
Anyway, Here are the warnings I see:
``
npm run start

<EMAIL_ADDRESS>start /var/www/html/project/pitchperfect/www/dist/client
npm run build:worker && react-scripts start

<EMAIL_ADDRESS>build:worker /var/www/html/project/pitchperfect/www/dist/client
rollup -c

worker/index.ts → public/pitch-detection/worker.js...
(!) Plugin typescript: @rollup/plugin-typescript TS5055: Cannot write file '/var/www/html/project/pitchperfect/www/dist/client/src/constants/colors.js' because it would overwrite input file.
(!) Unresolved dependencies
https://rollupjs.org/guide/en/#warning-treating-module-as-external-dependency
pitch-detection-wasm (imported by worker/index.ts)
created public/pitch-detection/worker.js in 16.8s
Compiled with warnings.
src/components/loader/index.tsx
Line 3:10:   'BACKGROUND' is defined but never used                                                                                @typescript-eslint/no-unused-vars
Line 36:67:  Using target="_blank" without rel="noreferrer" is a security risk: see https://html.spec.whatwg.org/multipage/links.html#link-type-noopener  react/jsx-no-target-blank
Line 45:71:  Using target="_blank" without rel="noreferrer" is a security risk: see https://html.spec.whatwg.org/multipage/links.html#link-type-noopener  react/jsx-no-target-blank
Line 85:11:  img elements must have an alt prop, either with meaningful text, or an empty string for decorative images                                    jsx-a11y/alt-text
src/components/pitch/index.tsx
Line 6:33:   'SECONDARY_LIGHT' is defined but never used                                                                @typescript-eslint/no-unused-vars
Line 6:66:   'PRIMARY_LIGHT' is defined but never used                                                                  @typescript-eslint/no-unused-vars
Line 99:13:  img elements must have an alt prop, either with meaningful text, or an empty string for decorative images  jsx-a11y/alt-text
Search for the keywords to learn more about each warning.
To ignore, add // eslint-disable-next-line to the line before.

Thanks again!

I got it resolved. I just gave up on the docker image and built it directly in a nodeenv directory


Consider Using Segues

Currently the navigation controller requires manual instantiation and for all subsequent view controllers to be manually pushed and popped. The use of storyboard segues would be a powerful addition and could even be used to define the root view controller in the same way they are used on SRTabBarController

Absolutely, why not!
I will work on it 👍

Awesome, let me know if I can help out at all. I started writing my own nav controller but stopped once I saw yours.

Done 👍

Nice work 😄


[INVE-12447] Add eslint rule to ensure dependency versions match kibi-internal

Add eslint rule that is able to parse package.json and check dependencies if GITHUB_TOKEN is set. This means that it'll always run on the repo's Jenkins PR builder and can optionally also run on locally if the developer wants quicker feedback time.

Yet to be done:

Documentation
Unit tests

@szydan @fabiocorneti @colmose I've made a prototype of an eslint rule that verifies that versions of dependencies match those in kibi-internal. Can you take a look and let me know if this might be a good way of approaching this problem.

Tested with several repos. There will be an associated change with most other repos to bump the version of this eslint plugin as well as to include package.json in the linted file lists.


Feature/bound periods when transforming

The will limit the periods we request so that we don't try and request a period that is currently incomplete.
For example if we requesting weeks and we are currently mid week we should not be able to pull data and transform the current week. We should only request fully complete periods.
@jcbashdown it would be good if you could have a look at this at it should subsume the code that you wrote specifically for user_satisfaction.

LGTM and discussed with @jcbashdown.