how to remove subtitle?

Hi,
if subtitle are working on video then how to stop there?
there is not on and off button for this... how to handle this? nothing in your demo also...
guide please..

You will like to hide the subtitle? Currently, there isn't a way to do it and I plan to add this functionality.
Meanwhile, you can have some hacky solution with css. You can temporarily hide the class "vjs-caption-overlay", which wraps all the caption text.

Yes have done it already. Thanks for this awesome plugin...Sent from Yahoo Mail for iPhoneAt 15-Jul-2015 1:53:37 am, spchuang wrote:You will like to hide the subtitle? Currently, there isn't a way to do it and I plan to add this functionality.
Meanwhile, you can have some hacky solution with css. You can temporarily hide the class "vjs-caption-overlay", which wraps all the caption text.
—Reply to this email directly or view it on GitHub.


Issues with spaces and deleted users and/or groups

Describe the bug
Deleting users and groups can lead to spaces with no more managers and/or the spaces can become fully inaccessible.
There doesn't seem to be a way to add managers to spaces as system admin or spaces admin.
Also deleted users and groups are still considered existent, somehow, but cant be deleted from the space managers' memberships view.
Steps to reproduce

create group or user (doesn't matter, both lead to the same set of issues).
create space.
add group or user (as manager) to said space.
delete group or user.

Expected behavior

Refuse to delete user and/or group if they are still mapped to some space.
Allow system/space admins to edit every space's memberships.
Allow removing or automatically remove deleted users and/or groups from space memberships.

Actual behavior

Not only did I end up with an inaccessible space as I deleted all members, the admin page still displays 3 members (2 deleted users + 1 deleted group) which no longer exist, there seems to be no way to fix this.

Also if im still a spaces' manager, I cant remove deleted users/groups from space memberships, since they dont show up in the membership view...

... yet they somehow show up in the administrative space membership view...
Setup
Localhost test setup.
OCIS_INSECURE=true PROXY_HTTP_ADDR=<IP_ADDRESS>:9200 OCIS_URL=https://localhost:9200 ./ocis server

There is already a proposed fix: https://github.com/owncloud/ocis/issues/5967

Closing here, duplicate has already been linked above.


Autocorrect on Annotation keywords loops forever

simply write a comment like
# TODO:I18n

and run rubocop with autocorrection and it will loop forever

Didn't we fix this already https://github.com/bbatsov/rubocop/pull/1908
What version of RuboCop are you running?

I just checked on this. It does not appear to be an issue in 0.32.1.

Was still in place for 0.32.0 but has been fixed in 0.32.1 now.


Counterfeit cash factory

I can't get the printers and the money on the table to spawn in i have tried everything but i can't get it to work  so if you could help me out i would be happy

You're right, I messed up on some values when I renamed the main object...
Hopefully it is fixed now on GitHub.
Thank you for reporting this!

Well that solved it!. well no problem thanks for solving it so quik


Crash with Android 4.1 with ArrayMap

Hi,
i'm using your component but it will crash when i use my app on android 4.1, follow the trace
FATAL EXCEPTION: RxCachedThreadScheduler-1                                                                              java.lang.IllegalStateException: Fatal Exception thrown on Scheduler.Worker thread.                                                                                at rx.internal.schedulers.ScheduledAction.run(ScheduledAction.java:62)                                                                                at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:390)                                                                                at java.util.concurrent.FutureTask.run(FutureTask.java:234)                                                                                at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:153)                                                                                at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:267)                                                                                at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1080)                                                                                at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:573)                                                                                at java.lang.Thread.run(Thread.java:856)                                                                               Caused by: java.lang.ExceptionInInitializerError                                                                                at com.pavlospt.rxfile.RxFile.isMediaUri(RxFile.java:479)                                                                                at com.pavlospt.rxfile.RxFile.access$300(RxFile.java:49)                                                                                at com.pavlospt.rxfile.RxFile$4.call(RxFile.java:191)                                                                                at com.pavlospt.rxfile.RxFile$4.call(RxFile.java:180)                                                                                at rx.internal.operators.OnSubscribeFromCallable.call(OnSubscribeFromCallable.java:32)                                                                                at rx.internal.operators.OnSubscribeFromCallable.call(OnSubscribeFromCallable.java:17)                                                                                at rx.Observable.unsafeSubscribe(Observable.java:8171)                                                                                at rx.internal.operators.OperatorSubscribeOn$1$1.call(OperatorSubscribeOn.java:62)                                                                                at rx.internal.schedulers.ScheduledAction.run(ScheduledAction.java:55)                                                                                at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:390)                                                                                at java.util.concurrent.FutureTask.run(FutureTask.java:234)                                                                                at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:153)                                                                                at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:267)                                                                                at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1080)                                                                                at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:573)                                                                                at java.lang.Thread.run(Thread.java:856)                                                                                Caused by: java.lang.NoClassDefFoundError: android.util.ArrayMap                                                                                at com.pavlospt.rxfile.Constants.<clinit>(Constants.java:79)                                                                                at com.pavlospt.rxfile.RxFile.isMediaUri(RxFile.java:479)                                                                                at com.pavlospt.rxfile.RxFile.access$300(RxFile.java:49)                                                                                at com.pavlospt.rxfile.RxFile$4.call(RxFile.java:191)                                                                                at com.pavlospt.rxfile.RxFile$4.call(RxFile.java:180)                                                                                at rx.internal.operators.OnSubscribeFromCallable.call(OnSubscribeFromCallable.java:32)                                                                                at rx.internal.operators.OnSubscribeFromCallable.call(OnSubscribeFromCallable.java:17)                                                                                at rx.Observable.unsafeSubscribe(Observable.java:8171)                                                                                at rx.internal.operators.OperatorSubscribeOn$1$1.call(OperatorSubscribeOn.java:62)                                                                                at rx.internal.schedulers.ScheduledAction.run(ScheduledAction.java:55)                                                                                at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:390)                                                                                at java.util.concurrent.FutureTask.run(FutureTask.java:234)                                                                                at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:153)                                                                                at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:267)                                                                                at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1080)                                                                                at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:573)                                                                                at java.lang.Thread.run(Thread.java:856)
ArrayMap was introduced in Api level 19, but it was also released in the compatibility library v4, so it would be enough to change the import to android.support.v4.util.ArrayMap instead of android.util.ArrayMap.
Can you fix it?
Thanks in advance.

@princeHago Hello, you can always submit a PR fixing this :)

i do it (i hope, is the first commit for me on github). can you approve it?

Thanks for the PR, will try to upgrade the repo in whole as well and import your change!

why you change the minimum api level? now is 19 but before was 17, my api level...

@princeHago API level was bumped due to the following issue https://github.com/pavlospt/RxFile/issues/8. If this is breaking for your app I am sorry but I can not support below 19 :)

API >= 19 is too lastest, can we try a workaround for #8 and decrease the api level?

I am also planning to upgrade to RxJava2 as well which means that null is out of the game! Not sure if there is a workaround!


Provide autocomplete suggestions in SearchRouterList

Details

This PR adds autocomplete in SearchRouter for simple keys like categories, tags, etc.. Searching with 'in:' keyword is not yet fully supported(reportIDs instead of full names will be visible in text input)
Fixed Issues

$ https://github.com/Expensify/App/issues/50942
$ https://github.com/Expensify/App/issues/50947
$ https://github.com/Expensify/App/issues/50957
$ https://github.com/Expensify/App/issues/50952
$ https://github.com/Expensify/App/issues/50953
$ https://github.com/Expensify/App/issues/50954
$ https://github.com/Expensify/App/issues/50955
$ https://github.com/Expensify/App/issues/50956
$ https://github.com/Expensify/App/issues/50948
$ https://github.com/Expensify/App/issues/50945
PROPOSAL:
Tests

Open SearchRouter and test these autocomplete keys: category, tag, taxRate, type, expenseType, card, from, to, status,  and currency.
Verify that when category, tag or currency keys are working the way this comment specified it.
Verify that after clearing input or single autocomplete key the autocomplete suggestions are cleared.
Verify that after clicking on autocomplete suggestion it is added correctly to text input.

Offline tests

QA Steps

[ ] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
https://github.com/user-attachments/assets/9df88b21-d26f-44e3-94f9-91827a930f7a

Android: mWeb Chrome
https://github.com/user-attachments/assets/d8f6d256-c08b-470f-b743-a3d78f388961

iOS: Native
https://github.com/user-attachments/assets/81c1a2c7-7135-42c2-9097-18982e80c36c

iOS: mWeb Safari
https://github.com/user-attachments/assets/3940ed06-b698-456a-95d7-22bcfde089a1

MacOS: Chrome / Safari
https://github.com/user-attachments/assets/430ee71e-c4a1-4088-b4c2-d19b3c055fee

MacOS: Desktop
https://github.com/user-attachments/assets/4bd54f7e-4518-494e-8065-0132a8a99450

Should we somehow limit the list of autosuggestions @luacmartins? This is POC implementation of autosuggestions for some of filters(the ones linked in description)
https://github.com/user-attachments/assets/46bbf9ba-b956-4ffa-9f5e-0adeb9cb6a3c
I don't see much designs connected to autocomplete.

@SzymczakJ I think we should only offer suggestions once the user typed at least one character after the filter key, e.g. currency:A. tagging @trjExpensify @JmillsExpensify for your thoughts as well.

Agree with Carlos that we'd suggest on the first character after the filter key.

@SzymczakJ we discussed internally and the behavior we want for this is:

category: would show a list of 10 "recently used" across all policies, from the RecentlyUsedTags, etc Onyx key. This can be an empty list.
category:a would filter results from all policyCategories for categories starting with a and show those suggestions.

Does that make sense?

Both @rayane-djouah and @ikevin127 have been involved and reviewing Search PRs for a while, so they both have context and should be able to handle these PRs.

BUG?: Pressing tab cycles through the options as it should, but it also removes the focus from the text input so the user has to click back into the input. This doesn't happen with the arrow navigation so users can keep typing into the input. We should make this behavior consistent.
Tab:
https://github.com/user-attachments/assets/969dad70-5d93-46b8-a903-8959ed3a9326
Arrows
https://github.com/user-attachments/assets/c559ac2c-6b8e-437d-86b1-6230e1337056

BUG: We should make suggestions case insensitive. For example, when searching for a currency, it correctly returns the results if I search in upper case, but nothing when searching in lower case
https://github.com/user-attachments/assets/8dbd18bd-baa8-41f2-9897-ced0be5867e5

BUG: Searching for categories with space results in no results and incorrect final syntax.
https://github.com/user-attachments/assets/dc6f7884-9032-4ed4-a8e5-80c3ac70740f

BUG?: Pressing tab cycles through the options as it should, but it also removes the focus from the text input

This was also the tab behaviour of ChatFinderPage. I tried to make it not defocus TextInput but after investigating it for some time, I think we would need to modify https://github.com/Expensify/react-native-key-command library, which makes this "bug" harder to fix.
I think this is a good candidate for Search 2.5 polish, or maybe, let's decide that's not a bug 😄 ? As I said before ChatFinderPage had identical behaviour. WDYT @luacmartins?

@ikevin127 kind bump 🙇

This was also the tab behaviour of ChatFinderPage. I tried to make it not defocus TextInput but after investigating it for some time, I think we would need to modify https://github.com/Expensify/react-native-key-command library, which makes this "bug" harder to fix.

I think it's ok to do this as a polish or wait until we get feedback that we should implement this.

I'll start reviewing in ~ 1 hour.

Reviewer Checklist

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[ ] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[ ] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If any new file was added I verified that:

[ ] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[ ] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[ ] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[ ] I verified that all the inputs inside a form are aligned with each other.
[ ] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[ ] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[ ] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

⚠ Found two issues while reviewing:

Multiple options for 1 autocomplete key results in infinite loading

[!note]
Explanation
When selecting 2 or more options and performing search we're stuck with infinite loading for the following keys: type, taxRate and status.
Below video demonstrates the behaviour for the type key.

https://github.com/user-attachments/assets/defa47b7-67a6-4013-ac2b-949a530b89b7

[UX] Selecting 1 autocomplete option adds [space] then when comma is added after space, no autocomplete options are shown

[!note]
Explanation
The issue here is that when selecting 1 autocomplete option, [space] is added in the input after the option which if we type , (comma) after the space, other autocomplete options don't show up. The only way options continue to show up is if we delete the space that is added automatically, then type , (comma) right after the first selected option.
Below video demonstrates the behaviour.

https://github.com/user-attachments/assets/b7b04207-11fd-46ce-833e-c23d0ea78702

cc @SzymczakJ @luacmartins
I'll move forward with the reviewer checklist in the meantime, and will approve once the above issues are addressed and conflicts resolved.

@ikevin127 @luacmartins @SzymczakJ
In order to speed implementing things up, I'm already branched from this PR and working on the next steps of autocomplete.  Mainly the accountID/reportID <---> user login/chatname substitution, so that the query the user sees is always correct.
Because of that I would like to suggest any NAB's and other improvements are not done here, but I will instead do them in my PR 😁 it will greatly help me.
Let's fix only critical and problematic bugs here.

Multiple options for 1 autocomplete key results in infinite loading

It results in infinite loading, because it doesn't make sense from UI point of view(we cannot be on an Expense tab and on Chat tab on the same moment). On the other hand I think that we shouldn't limit the user, even though his query may produce something which doesn't make sense. Maybe we could provide some modal on SearchResultsPage that tell user that 'This query doesn't make sense'. WDYT @luacmartins

[UX] Selecting 1 autocomplete option adds [space] then when comma is added after space, no autocomplete options are shown

No autocomplete was added for input "category:X ,"  because of the limitations of our parser. Here is my solution for this: when user adds "," to add another autocomplete then the spaces before "," are trimmed so our parser can parse it properly. Please check it out @luacmartins @ikevin127
https://github.com/user-attachments/assets/7bcd7ea4-04a4-44ec-9a21-4f80ada7df49

NAB I think we can get smarter with the suggested statuses and only suggest statuses that apply to the current type


⚠ Bofrost.es has degraded performance

In 4ca15bb, Bofrost.es (https://www.bofrost.es) experienced degraded performance:

HTTP code: 200
Response time: 1467 ms

Resolved: Bofrost.es performance has improved in 7b1c0df after 7 minutes.


Exposes socket connection error into pony level

net/tcp_connection_notify: added connect_error method -
extended version of connect_failed

This fails on Windows.

Change src/libponyrt/lang/socket.c line 737 to the following to build on Windows.  On Windows getsockopt() takes a char * instead of a void * there:
if(getsockopt((SOCKET)fd, SOL_SOCKET, SO_ERROR, (char*)&sockerr, &errlen))

It looks like this breaks code which depends on connect_failed, but that method hasn't been removed from the interface.
Also, I think a change like this needs to go through the RFC process, to get community input - especially for a breaking change like this.

It does not break existing code with connect_failed, since default implementation for connect_error calls cannect_failed
Btw it could be useful to have something like \deprecated\ annotation to mark API changes while keeping compatibility

I'm very new to pony, don't know the procedures needed to accept the code. I see there is RFC 23 already exist with related subject

I'm very new to pony, don't know the procedures needed to accept the code

Sorry, I should have provided a better explanation.  For an API change like this, we'd like to see an RFC first, so we can get community input about the best approach.  The hope is that with more eyes on the process, coming from different perspectives and thinking about different use cases, we're likely to come to better solutions than individuals will, leading to better and more stable APIs overall.
The process for creating an RFC is described here: https://github.com/ponylang/rfcs/blob/master/README.md
The TLDR is that you create a pull request with the RFC, get community input on the idea and the approach, then get it accepted for work.  We try not to have the process be too formal, because we don't want to slow down innovation too much, but we do want to slow things down a little bit to get you and the rest of us thinking seriously about the motivation for the idea, impact of the change and the best way to go about it.
If you need any help figuring out the RFC process, please let us know.

We can discuss more in the RFC, but I personally get the feeling that exposing the errno directly is likely to be too low-level.  Ideally, the errors could be expressed somehow in the Pony type system instead of as (platform dependent?) numbers.  We do something like this both in the process package and in the files package.

aha, thanks.  Will try to compose RFC

As the RFC for this is now open, I'm closing this.
https://github.com/ponylang/rfcs/pull/78


Review comments

https://github.com/webburza/payum-setefi/blob/master/src/Action/AuthorizeAction.php#L60 - so a user gets a blank page with OK? is it?

The rest looks great. Good job!

Hi @makasim,
The response is to the server-to-server request which their backend does in order to confirm the transaction (so, the server get's an "OK", not the user).
The docs say we CAN send a payload here containing a different redirect URL (success instead of capture, for instance), but it doesn't say HOW the payload should look, how it's supposed to be serialized etc. We need to talk to the provider directly to clear this up.
We'll do another pass at this, add tests and a README, how to set it up stand-alone and with Sylius, will also clear this up until then.
Thank you very much for the review.

well, than I believe the action's name is misleading. Shouldn't it be NotifyAction?

That's the reason why this review is great. :+1: I had some trouble figuring out which action represents which activity from Payum docs, it wasn't really clear to me, authorize seemed most appropriate.
When reviewing the lib, we'll rename the action, yes.


Uncaught TypeError: Cannot read property 'replace' of undefined

[Enter steps to reproduce below:]

...
...

Atom Version: 1.2.1
System: Mac OS X 10.10.3
Thrown From: Remote-FTP package, v0.7.10
Stack Trace
Uncaught TypeError: Cannot read property 'replace' of undefined
At /Users/sofiane/.atom/packages/Remote-FTP/lib/client.js:82

TypeError: Cannot read property 'replace' of undefined
    at /Users/sofiane/.atom/packages/Remote-FTP/lib/client.js:82:44
    at FSReqWrap.readFileAfterClose [as oncomplete] (fs.js:380:3)

Commands
     -0:45.9.0 application:add-project-folder (ol.tree-view.full-menu.list-tree.has-collapsable-children.focusable-panel)
     -0:32.9.0 remote-ftp:create-sftp-config (ol.tree-view.full-menu.list-tree.has-collapsable-children.focusable-panel)
     -0:23.4.0 core:paste (atom-text-editor.editor.is-focused)
  2x -0:20.4.0 core:save (atom-text-editor.editor.is-focused)
     -0:00.7.0 remote-ftp:connect (ol.tree-view.full-menu.list-tree.has-collapsable-children.focusable-panel)

Config
{
  "core": {}
}

Installed Packages
# User
Remote-FTP, v0.7.10

# Dev
No dev packages

You have to set the remote field (remote path on server, e.g. "/") in your .ftpconfig
See the readme for the example config :)

I'm getting the same issue, my remote field is set to:
"remote_path": "/",

Atom: 1.23.1 x64
Electron: 1.6.15
OS: Mac OS X 10.13.2
Thrown From: remote-ftp package 2.1.1
Stack Trace
Uncaught TypeError: Cannot read property 'replace' of undefined
At /Users/icetee/DEV/_forks/remote-ftp/lib/helpers.js:18

TypeError: Cannot read property 'replace' of undefined
    at splitPaths (/Users/icetee/DEV/_forks/remote-ftp/lib/helpers.js:18:39)
    at /Users/icetee/DEV/_forks/remote-ftp/lib/connectors/ftp.js:266:22
    at Array.forEach (native)
    at /Users/icetee/DEV/_forks/remote-ftp/lib/connectors/ftp.js:260:12
    at tryApply (/Users/icetee/DEV/_forks/remote-ftp/lib/connectors/ftp.js:12:14)
    at error (/Users/icetee/DEV/_forks/remote-ftp/lib/connectors/ftp.js:116:29)
    at /Users/icetee/DEV/_forks/remote-ftp/lib/connectors/ftp.js:139:29
    at final (/Users/icetee/DEV/_forks/remote-ftp/node_modules/@icetee/ftp/lib/connection.js:507:11)
    at Object.cb (/Users/icetee/DEV/_forks/remote-ftp/node_modules/@icetee/ftp/lib/connection.js:544:11)
    at Parser.<anonymous> (/Users/icetee/DEV/_forks/remote-ftp/node_modules/@icetee/ftp/lib/connection.js:127:20)
    at emitTwo (events.js:111:20)
    at Parser.emit (events.js:191:7)
    at Parser._write (/Users/icetee/DEV/_forks/remote-ftp/node_modules/@icetee/ftp/lib/parser.js:61:10)
    at doWrite (_stream_writable.js:332:12)
    at writeOrBuffer (_stream_writable.js:318:5)
    at Parser.Writable.write (_stream_writable.js:245:11)
    at Socket.ondata (/Users/icetee/DEV/_forks/remote-ftp/node_modules/@icetee/ftp/lib/connection.js:298:20)
    at emitOne (events.js:96:13)
    at Socket.emit (events.js:188:7)
    at readableAddChunk (_stream_readable.js:176:18)
    at Socket.Readable.push (_stream_readable.js:134:10)
    at TCP.onread (net.js:551:20)

Commands
     -5:12.2.0 remote-ftp:disconnect (ol.ftptree-view.full-menu.list-tree.has-collapsable-children.focusable-panel)
     -5:08.9.0 core:save (input.hidden-input)
     -2:58.2.0 datatip:toggle (input.hidden-input)
     -2:58.1.0 editor:toggle-line-comments (input.hidden-input)
     -2:57.9.0 datatip:toggle (input.hidden-input)
     -2:57.3.0 core:save (input.hidden-input)
  3x -1:32.7.0 core:backspace (input.hidden-input)
  2x -1:32 core:save (input.hidden-input)
     -1:25.7.0 core:move-down (input.hidden-input)
     -1:25.2.0 core:move-right (input.hidden-input)
     -1:24.4.0 core:move-left (input.hidden-input)
  3x -1:24 core:backspace (input.hidden-input)
     -1:22.9.0 core:save (input.hidden-input)
  3x -1:18.7.0 core:backspace (input.hidden-input)
  2x -1:18.1.0 core:save (input.hidden-input)
     -0:36.5.0 remote-ftp:download-selected (span.name.icon.icon-file-directory)

Here seems to happen with corrupted files on server side.
I also noticed that no file is downloaded from folders with a space " " in its name.
Maybe should only detect them, avoid them and report it at the end of the download process.

Happened to me today, Remote FTP can see 4 files within a folder (receipt.php, receipt2.php, undefined, undefined). The only actual file with the folder is receipt.php, I cannot understand where the others come from (they're not on the server, only Remote FTP sees them).
The error is triggered when I try to download these non-existent files


mdns example panics on Windows in release mode, but not in debug mode

First of all, thanks for making such a nice crate. After looking at the source code, I realize what I would be getting into had I needed to implement multicast on all interfaces myself for both Windows and Linux. 😄
But I am having a bit of a problem. Just like the title says, I can run the mdns example in debug mode, and it works perfectly fine, but it panics in release mode with this error:
thread 'main' panicked at 'could not broadcast message to ips being listened: Os { code: 10022, kind
: InvalidInput, message: "An invalid argument was supplied." }', examples\mdns.rs:25:10

I'm also running into this issue in my own project using this crate. It can send out a multicast (checked with Wireshark) in debug mode, but in release, it panics with the same error.
I have multiple different network adapters, WSL's vEthernet, VirtualBox's Host-Only Network, my WiFi adapter, Ethernet (that I'm not using), and ZeroTier One. I ended up on your crate due to my multicasts ending up on WSL's interface, rather than my WiFi adapter's.
If I can provide any more system information, or do some more testing, I'd be happy to help.

Hello there. This is an interesting issue. I also have the same setup on my
development machine, including the ZeroTier One adapter and WSL vEthernet.
Indeed, running on release mode panics the sample example. I'm curious if
this is an issue on the sample or an optimization triggering a bug in the
library.
I currently don't have much time on my hands to troubleshoot this, but I
can test any patches on my dev environment to validate changes.
Sorry for not having time to help at this moment.
Kind regards,
Em qui., 5 de mai. de 2022 às 20:07, Dudemanjude @.***>
escreveu:

First of all, thanks for making such a nice crate. After looking at the
source code, I realize what I would be getting into had I needed to
implement multicast on all interfaces myself for both Windows and Linux.
😄
But I am having a bit of a problem. Just like the title says, I can run
the mdns example in debug mode, and it works perfectly fine, but it panics
in release mode with this error:
thread 'main' panicked at 'could not broadcast message to ips being listened: Os { code: 10022, kind
: InvalidInput, message: "An invalid argument was supplied." }', examples\mdns.rs:25:10
I'm also running into this issue in my own project using this crate. It
can send out a multicast (checked with Wireshark) in debug mode, but in
release, it panics with the same error.
I have multiple different network adapters, WSL's vEthernet, VirtualBox's
Host-Only Network, my WiFi adapter, Ethernet (that I'm not using), and
ZeroTier One. I ended up on your crate due to my multicasts ending up on
WSL's interface, rather than my WiFi adapter's.
If I can provide any more system information, or do some more testing, I'd
be happy to help.
—
Reply to this email directly, view it on GitHub
https://github.com/bltavares/multicast-socket/issues/14, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAA2XIVVPTFPGKQELLPYVVTVIRIDVANCNFSM5VGQC3LA
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

Out of curiosity, and since windows-rs is the new hotness, I rewrote the lib to use it. It changed absolutely nothing and produced the same error 😅 One red herring down!


Configuration & data are not in expected (XDG) locations

Several related issues here that could be fixed together.

ixmp-config places a file at ~/.local/ixmp/config.json. This does not conform to the XDG base directory specification. The file should be at either:

~/.local/share/ixmp/config.json — i.e. using $XDG_DATA_HOME or its default.
~/.config/ixmp.json or ~/.config/ixmp/config.json — i.e. using $XDG_CONFIG_HOME or its default.

Likewise the localdb directory created with ixmp.Platform(dbtype='HSQLDB') is incorrectly at ~/.local/ixmp/localdb instead of ~/.local/share/ixmp/localdb.
ixmp.config.get() raises an exception if the configuration file is missing. Sensible defaults should be used instead.

An example of item 3: on #128 @danielhuppmann wrote:

in the current setup, the local default HSQLDB is touched every time a user re-installs and runs the tests on the tutorial notebooks. So the default database files become quite bloated over time. Would it be possible to connect the tutorial-notebook tests to a temporary db?

This could be fixed by the following new functionality:
—check for an environment variable, IXMP_CONFIG.
—look in that directory for config.json, before any other path such as the current defaults.
Then the tests could pass a specific value of IXMP_CONFIG in order to not modify the user's configuration.


fix: correctly allow to load from a databased setup with subindices

context
ATM we could not read from a database which has been setup with sub indices. This pr fix this (original issue here )

from docarray import Document, DocumentArray, dataclass
from docarray.typing import Image, Text

@dataclass
class MyDocument:
    image: Image
    paragraph: Text

# extend with Documents, including embeddings
_docs = [(MyDocument( image='https://docarray.jina.ai/_images/apple.png', paragraph='hello world'))]

da = DocumentArray(
    storage='sqlite',  # use SQLite as vector database
    config={'connection': 'jina4.db', 'table_name': 'test4'},
<EMAIL_ADDRESS>{'connection': 'jina4.db', 'table_name': 'test5'}<EMAIL_ADDRESS>{'connection': 'jina4.db', 'table_name': 'test6'}},  # set up subindices for image and description
)
da.summary()

for item in _docs:
  d = Document(item)
  da.append(d)

da = DocumentArray(
    storage='sqlite',  # use SQLite as vector database
    config={'connection': 'jina4.db', 'table_name': 'test4'},
<EMAIL_ADDRESS>{'connection': 'jina4.db', 'table_name': 'test5'}<EMAIL_ADDRESS>{'connection': 'jina4.db', 'table_name': 'test6'}},  # set up subindices for image and description
)
da.summary()

This will now work

All tests are passed, and we can close this ticket.

@samsja , @dongxiang123  let's close this PR and have @dongxiang123 open a new one


[SPARK-30323][SQL] Support filters pushdown in CSV datasource

What changes were proposed in this pull request?
In the PR, I propose to support pushed down filters in CSV datasource. The reason of pushing a filter up to UnivocityParser is to apply the filter as soon as all its attributes become available i.e. converted from CSV fields to desired values according to the schema. This allows to skip conversions of other values if the filter returns false. This can improve performance when pushed filters are highly selective and conversion of CSV string fields to desired values are comparably expensive ( for example, conversion to TIMESTAMP values).
Here are details of the implementation:

UnivocityParser.convert() converts parsed CSV tokens one-by-one sequentially starting from index 0 up to parsedSchema.length - 1. At current index i, it applies filters that refer to attributes at row fields indexes 0..i. If any filter returns false, it skips conversions of other input tokens.
Pushed filters are converted to expressions. The expressions are bound to row positions according to CSVFilters.readSchema. The expressions are compiled to predicates via generating Java code.
To be able to apply predicates to partially initialized rows, the predicates are grouped, and combined via the And expression. Final predicate at index N can refer to row fields at the positions 0..N, and can be applied to a row even if other fields at the positions N+1..readSchema.lenght-1 are not set.

Why are the changes needed?
The changes improve performance on synthetic benchmarks more than 9 times (on JDK 8 & 11):
OpenJDK 64-Bit Server VM 11.0.5+10 on Mac OS X 10.15.2
Intel(R) Core(TM) i7-4850HQ CPU @ 2.30GHz
Filters pushdown:                         Best Time(ms)   Avg Time(ms)   Stdev(ms)    Rate(M/s)   Per Row(ns)   Relative
------------------------------------------------------------------------------------------------------------------------
w/o filters                                       11889          11945          52          0.0      118893.1       1.0X
pushdown disabled                                 11790          11860         115          0.0      117902.3       1.0X
w/ filters                                         1240           1278          33          0.1       12400.8       9.6X

Does this PR introduce any user-facing change?
No
How was this patch tested?

Added new test suite CSVFiltersSuite
Added tests to CSVSuite and UnivocityParserSuite

Test build #115633 has started for PR 26973 at commit f0cc83c.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/20432/
Test PASSed.

Test build #115633 has finished for PR 26973 at commit f0cc83c.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/115633/
Test FAILed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/20435/
Test PASSed.

Test build #115636 has started for PR 26973 at commit f24e873.

Test build #115636 has finished for PR 26973 at commit f24e873.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/115636/
Test PASSed.

@HyukjinKwon @dongjoon-hyun @cloud-fan May I ask you to review this PR.

Thank you for pinging me. cc @aokolnychyi and @dbtsai

jenkins, retest this, please

@MaxGekk, sorry I am rushing but mind if I ask to summerise the idea of this PR? If the pushed filters are converted to back Spark's expressions, I think there's no point of doing it (as Spark's optimizer should do that instead).

@HyukjinKwon I have updated the PR description. Please, tell me if something is unclear.

jenkins, retest this, please

Test build #115651 has started for PR 26973 at commit 170944c.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/20450/
Test PASSed.

Test build #115651 has finished for PR 26973 at commit 170944c.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/115651/
Test FAILed.

jenkins, retest this, please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/20498/
Test PASSed.

Test build #115704 has started for PR 26973 at commit 170944c.

Test build #115704 has finished for PR 26973 at commit 170944c.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/115704/
Test FAILed.

jenkins, retest this, please

Test build #115732 has started for PR 26973 at commit 170944c.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/20526/
Test PASSed.

Test build #115732 has finished for PR 26973 at commit 170944c.

This patch fails to generate documentation.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/115732/
Test FAILed.

Test build #115748 has started for PR 26973 at commit c18ea7b.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/20542/
Test PASSed.

Test build #115748 has finished for PR 26973 at commit c18ea7b.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/115748/
Test PASSed.

If the pushed filters are converted to back Spark's expressions, I think there's no point of doing it (as Spark's optimizer should do that instead).

@HyukjinKwon Spark's optimizer applies filters to an entire row fully converted to desired types but pushed filters are applied to some parts of the row. So, we can skip some value conversions.

@HyukjinKwon @cloud-fan @dongjoon-hyun @maropu Could you take a look at the PR, please.

@hvanhovell WDYT?

retest this please

Test build #116235 has started for PR 26973 at commit c18ea7b.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/21028/
Test PASSed.

Test build #116235 has finished for PR 26973 at commit c18ea7b.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/116235/
Test PASSed.

Test build #116355 has started for PR 26973 at commit 17e742f.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/21146/
Test PASSed.

Test build #116355 has finished for PR 26973 at commit 17e742f.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/116355/
Test FAILed.

jenkins, retest this, please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/21163/
Test PASSed.

Test build #116372 has started for PR 26973 at commit 17e742f.

Test build #116372 has finished for PR 26973 at commit 17e742f.

This patch fails SparkR unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/116372/
Test FAILed.

Test build #116415 has started for PR 26973 at commit f296259.

Build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/21204/
Test PASSed.

Test build #116415 has finished for PR 26973 at commit f296259.

This patch passes all tests.
This patch does not merge cleanly.
This patch adds no public classes.

Build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/116415/
Test PASSed.

Test build #116474 has started for PR 26973 at commit 61eaa36.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/21261/
Test PASSed.

jenkins, retest this, please

Test build #116485 has started for PR 26973 at commit 61eaa36.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/21272/
Test PASSed.

Test build #116474 has finished for PR 26973 at commit 61eaa36.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/116474/
Test FAILed.

Test build #116485 has finished for PR 26973 at commit 61eaa36.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/116485/
Test FAILed.

Test build #116538 has started for PR 26973 at commit f0aa0a8.

Build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/21324/
Test PASSed.

Test build #116540 has started for PR 26973 at commit 1cc46b1.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/21326/
Test PASSed.

Test build #116538 has finished for PR 26973 at commit f0aa0a8.

This patch passes all tests.
This patch does not merge cleanly.
This patch adds no public classes.

Build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/116538/
Test PASSed.

Test build #116540 has finished for PR 26973 at commit 1cc46b1.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
  case class FilterStatistics(
class EventLogFileCompactor(
case class CompactionResult(code: CompactionResultCode.Value, compactIndex: Option[Long])
case class AlterNamespaceSetOwner(

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/116540/
Test PASSed.

@HyukjinKwon @dongjoon-hyun @cloud-fan Could you review this PR, please.

How did you fix https://github.com/apache/spark/pull/27112/files#r365539740 ? I took a quick look and not sure what was wrong before.

@cloud-fan The problem was in the line https://github.com/apache/spark/pull/26973/commits/f0aa0a88bfa0c87007f8781ba7fac8f9cd3057ba#diff-faa3cfad03552057c3cb431c5ce87f03L52 where I returned an empty array.
The comment for pushFilters says that I should return filters that should be evaluated after scanning
https://github.com/apache/spark/blob/053dd858d38e6107bc71e0aa3a4954291b74f8c8/sql/catalyst/src/main/java/org/apache/spark/sql/connector/read/SupportsPushDownFilters.java#L31
I guessed if I consumed all filters then I should return nothing. But looking at ORC and Parquet, I noticed that they return all filters:
https://github.com/apache/spark/blob/5114389aef2cacaacc82e6025696b33d6d20b2a6/sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/parquet/ParquetScanBuilder.scala#L65
https://github.com/apache/spark/blob/5114389aef2cacaacc82e6025696b33d6d20b2a6/sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/orc/OrcScanBuilder.scala#L65

And in pushedFilters, I store only filters that refers to the schema, and the filters that I can handle.

Test build #116620 has started for PR 26973 at commit a3a99b1.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/21401/
Test PASSed.

Test build #116620 has finished for PR 26973 at commit a3a99b1.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/116620/
Test FAILed.

Test build #116621 has started for PR 26973 at commit 4a25815.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/21402/
Test PASSed.

Test build #116624 has started for PR 26973 at commit c03ae06.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/21405/
Test PASSed.

@cloud-fan I am still worry how does this behave in different modes, especially in the PERMISSIVE mode. Let me write tests for that. In the PERMISSIVE mode, we return nulls if we cannot convert/parse a CSV field. What happens if I apply predicates for null. I guess it should be covered properly by expression implementations.

I believe it's the same problem as column pruning. When we return data earlier, we may skip parsing some columns and treat a malformed record as normal. My feeling is that, we don't have a clear definition about what is a malformed record, if we don't need to parse the whole record.

Test build #116621 has finished for PR 26973 at commit 4a25815.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/116621/
Test PASSed.

Test build #116624 has finished for PR 26973 at commit c03ae06.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/116624/
Test PASSed.

Test build #116647 has started for PR 26973 at commit e302fa4.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/21426/
Test PASSed.

Test build #116649 has started for PR 26973 at commit 96e9554.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/21428/
Test PASSed.

Test build #116647 has finished for PR 26973 at commit e302fa4.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/116647/
Test PASSed.

Test build #116649 has finished for PR 26973 at commit 96e9554.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/116649/
Test PASSed.

Looks pretty good but I will take a final look after the comments were addressed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/21472/
Test PASSed.

Test build #116694 has started for PR 26973 at commit 9217536.

Test build #116694 has finished for PR 26973 at commit 9217536.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/116694/
Test PASSed.

Test build #116722 has started for PR 26973 at commit 15c9648.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/21497/
Test PASSed.

Test build #116722 has finished for PR 26973 at commit 15c9648.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
class CSVFilters(filters: Seq[sources.Filter], requiredSchema: StructType)

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/116722/
Test PASSed.


Support for web based Augmented Reality in Android and iOS

Description
Currently web based Augmented Reality (AR) is not supported in the plugin. I would like to see this support being added. For Android I think scene viewer could be considered.
For iOS UIWebView was always working well with embedded AR content, but not sure about WKWebView.

Need this <3 !
For the moment in my navigation interceptor I do as follow, that allow me to well saw JS model displaying 3D model and when user want to open a model, that well trigger Android AR intent. But for iOS i'm bit stuck :/
bool isIntent(Uri uri) => uri.hasScheme && <String>[intent].contains(uri.scheme);

if (Platform.isAndroid && isIntent(uri)) {
   unawaited(_openIntent(uri));
   return NavigationActionPolicy.CANCEL;
}

Future<bool> _openIntent(Uri uri) async {
    if (uri.toString().startsWith(intent)) {
      try {
        final String formattedUrl = uri
            .toString()
            .replaceFirst('$intent://', '$https://')
            .replaceFirst('#Intent', '?')
            .replaceFirst(';end;', '');

        final Uri launchUri = Uri.parse(formattedUrl);
        return await launchUrl(launchUri);
      } catch (err, stack) {
        debugPrintStack(label: err.toString(), stackTrace: stack);
      }
    }
    return false;
  }

(response updated)


Add websocket to the project

Add socket.io to both client and server.
In the scope of this issue, just create utilities that establish a connection between client and server.

Related issue: https://github.com/muke1908/chat-e2ee/issues/113

@muke1908 I am not able to understand the socket.io implementation referring the official docs. Can you help me ?

Hi @nafees87n, all the socket related code is written in https://github.com/muke1908/chat-e2ee/tree/master/backend/socket.io


RTL languages support

It would be great if Materialize supported RTL layouts ...

https://github.com/MetaiR/materializeCss-rtl


C bindings

Ok, so first, thanks for making this! It's awesome.
This PR adds a Makefile that can build and install static/dynamic libraries and headers suitable for C-compatible language clients. This is just automation that makes the parser easier to use.
All the components are standardized and parser-agnostic aside from the name, version, and some informational comments in the .pc file. I didn't find any version info, so I just put in "0.1.0". Shouldn't affect anything.
The backstory: https://github.com/tree-sitter/tree-sitter/issues/1488
The first implementation: https://github.com/tree-sitter/tree-sitter-go/pull/56

Very nice! I'm not really able to provide a proper review due to my complete uselessness with Make, but given this looks like a standardized solution for all tree-sitter grammars, I'll defer to the reviews already done on the linked PRs. Thanks!

Thanks for merging! This is a big quality-of-life upgrade for those using C.
Yeah, this took me many revisions to get right. I started with the runtime's Makefile, but supporting parsers in a general way required me to learn just enough make to be dangerous.


import-blocks doesn't seem to work

When I try to run --import-blocks it just seemingly stucks.
    Finished release [optimized] target(s) in 0.92s
     Running `target/release/substrate import-blocks blocks.blocks`
2019-06-28 18:18:28 Importing 1241 blocks
2019-06-28 18:18:28 #0 blocks were added to the queue
2019-06-28 18:18:28 #1000 blocks were added to the queue

There is no CPU activity coming from substrate while import so which suggests that there might be an issue with locking or dispatching the tasks.

Ah, my bad. We're using tokio::run instead of a method that exits immediately once the future passed as parameter has ended.

The fix is quite easy. Replace tokio::run with something like:
tokio::runtime::Runtime::new()
	.expect("Failed to initialize tokio")
	.block_on(fut)
	.expect("Error while importing blocks");

However the other part of the issue would be to add a CI test.

Hey, thanks for the fix! However, unfortunately, it doesn't work. The symptoms are the same. There is no activity and no results.

Works for me in master.
Initializing Genesis block/state (state: 0xea93…a60c, header-hash: 0x4830…833c)
2019-07-02 12:18:33 Loaded block-time = 4 seconds from genesis on first-launch
2019-07-02 12:18:33 Loading GRANDPA authority set from genesis on what appears to be first startup.
2019-07-02 12:18:33 Importing 1148 blocks
2019-07-02 12:18:33 #0 blocks were added to the queue
2019-07-02 12:18:33 #1000 blocks were added to the queue
2019-07-02 12:18:46 #1000 blocks were imported (#148 left)
2019-07-02 12:18:48 Imported 1147 blocks. Best: #1148

@pepyakin try importing to an empty DB

Yes, I did the purge-chain before the import.
Just checked with the latest master:
./target/release/substrate purge-chain -y --dev  && time ./target/release/substrate factory --dev --mode MasterTo1 --num 500
./target/release/substrate export-blocks --dev blocks.blocks
./target/release/substrate import-blocks --dev blocks.blocks

the result is the same.

Apparently the root issue here is that factory command produces invalid blocks.
2019-07-08 12:50:15.113 tokio-runtime-worker-0 TRACE sync  Starting import of 1 blocks  (1)
2019-07-08 12:50:15.113 tokio-runtime-worker-0 TRACE sync  Header 0x0136…3829 has 0 logs
2019-07-08 12:50:20.835 tokio-runtime-worker-0 TRACE sync  Verifying 1(0x0136…3829) failed: Header 0x0136ef67f325fd563f0c42acdaaaab5ba3864a83b6ad4db792d56fd0c0dc3829 is unsealed

aha! then it is the factory not the import-blocks!
is it expected behavior @cmichi ?

After the recent changes to the extrinsic format, I added a reminder for myself to add more tests to factory and subkey code to make sure they generate extrinsic that are correctly constructed and composed. This issue rings a bell now.
I will try to look into this soonish. Maybe end up seeing what the issue is with the import as well.

The fact that the operation never stops is probably fixed by #3240 .


Added feature Factorial Trailing Zeroes in Java and C++

Factorial Trailing Zeroes (LeetCode) #108
Closes: #108[Factorial Trailing Zeroes (LeetCode) ]

@ShudhanshuSingh Nice work :) Just try to use pull request template given.


global variables not showing

Global variables are not showing in the extension pane. ("Show Global Vars" is turned on in the settings.)
"Print Output" works as expected.

me too!!!!!!!!!why?

一样 查不到什么原因

metoo 解决踢我感谢

metoo 解决请踢我

This works in AREPL (https://github.com/Almenon/AREPL-vscode), so you can
use AREPL until it is fixed here.
这适用于 AREPL (https://github.com/Almenon/AREPL-vscode)，因此您可以使用 AREPL，直到此处修复为止。
On Tue, Sep 12, 2023 at 8:52 PM banjiao @.***> wrote:

[image: image]
https://user-images.githubusercontent.com/28124733/267530380-b3903e45-badc-489a-9cd5-4b2b36e0731f.png
metoo 解决请踢我
—
Reply to this email directly, view it on GitHub
https://github.com/Xirider/LiveCode/issues/14#issuecomment-1716901144,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADDZTBM3XEW5FHVDWXQVYVDX2EUYXANCNFSM6AAAAAA4E65KBI
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>


Test succeeds but should fail. Plus sign in the test name.

This test succeeds in Mocha 3.0.2 but should fail.
const assert = require('assert');

it('+ ', function () {
    assert(false);
});

This test is failing under Mocha 2.5.3 as expected.
Output:
Test Name:	+
Test Outcome:	Passed
Result StandardOutput:
1..0
# tests 0
# pass 0
# fail 0

Visual Studio 2015 Pro v.14.0.25425.01 Update 3
Node.js Tools 1.2.40726.00
TypeScript <IP_ADDRESS>
Mocha 3.0.2

Hey @Andreyul! 🙂
I have tried to reproduce and didn’t quite succeed: https://asciinema.org/a/35iycay1hn60b6d7bjyyq5ks9. 😑
Could you please take a quick look and see what I may have missed? 🤓

Node.js Tools for Visual Studio calls mocha.grep(testName) when running tests.
Before Mocha 3.0.0 strings passed to mocha.grep were escaped. Now it is a Regexp.
Probably they should change mocha.grep(testName) to
if (typeof mocha.fgrep === 'function')
    mocha.fgrep(testName); // since Mocha 3.0.0
else
    mocha.grep(testName); // prior Mocha 3.0.0

Pull request have been merged into NTVS.


Document Git as a build dependency

@ben-muldrow and I discovered that Topsoil has a build dependency on Git. While there's no reason to change this, it would be good to document this on the Development page in the wiki.
@ben-muldrow, do you mind tackling this?

@ben-muldrow, looks good. Thanks for taking care of this.
Next time, please comment on the issue after finishing. GitHub doesn't always make changes easy to find.


chore(main): release pixels 0.14.0

:robot: I have created a release beep boop
0.14.0 (2024-07-05)
Features

added Badge component (157266a)

This PR was generated with Release Please. See documentation.

:robot: Created releases:

pixels-v0.14.0
:sunflower:


Runtime plugin enable/disable

Rather than have the plugins statically defined via a list in Main.hs, it would probably be more useful to have them be able to be turned on/off in the config file, as to avoid recompilation.

Added by #27


Used compressed images to improve load time

removed large filed and used compressed assets, quality was not affected

just a random message:
I will actively contribute to this project ❤ after 25 February as my exams are going on.


Option to set hook that described locally in project

So, as I can see there is only one way that to create own hook, it's post it to library in this repo.
But sometimes need to create hooks locally, for private project especially.
For now, I found a dirty way, with passing ../../../path to the hooks config.
  "hooks": [
    "../../../copy-files2"
  ]

But I think, that thc-hooks should check if hook name starts with './' it's  an local script, else it library script. (like require do)

Yeah this is actually already supported, I have just been too lazy to add it to the docs 😆
Take a look here https://github.com/swimauger/tsc-hooks/blob/main/lib/utils/requireHook.js,
As you may be able to tell, tsc-hooks first attempts to see if the developer has entered a URL in hooks, if they have not, then it checks if the developer has specified a relative path, and then again if they have not, then it will use tsc-hooks already integrated hooks.
Currently, I have it setup, so that it reads the extension first to determine if it is not a hook from tsc-hooks, so you have to end the hook with .js if you want to use a local or externally hosted hook.
So to answer this, if you want a local hook specify:
  "hooks": [
    "./copy-files2.js" // Where copy-files2.js is in the same directory as your tsconfig.json
  ]

If you want a hook from a url, specify:
  "hooks": [
    "https://somewebsite.com/myhooks/hook.js" // Just paste a url in with the .js extension (and uses the tsc-hooks framework)
  ]

In the future, I may change this so the .js extension is not needed, but for now there are some other priority items to finish.

@swimauger
Ah, sorry, I did not see that in this case I should also add extension ending.
So, I think that error in this case could be more helpfully, now they throw only one path, but checks more.
npx tsc
Cannot find module '.\node_modules\tsc-hooks\hooks\scripts\ci\copy-files\scripts\ci\copy-files.hook'

Another thing, that if module know that I pass a relative path (started with ./) he could throw more concreted error with path that he really check. (or of arrays of paths)
And yes, looks like some documentations or examples can help much early.


Broken submodule

https://github.com/project-everest/hacl-star/commit/05e0b0049aa4f6f2ca362ef44ff4548dbfda8f7b#diff-e111e895b719e3cbf8a5ac9cd36dba1b added a git submodule to dist/test/c/kremlin. But I don't see any .gitmodule file or other submodule definition. This breaks using hacl-star as a git submodule
git submodule update --init --recursive
fatal: No url found for submodule path 'hacl-star/dist/test/c/kremlin' in .gitmodules

Looks like this should be closed per https://github.com/project-everest/hacl-star/pull/363 ?
Please reopen if I am mistaken.


resolve '@waiting' counter problem

if a thread is in the wait state, but transitions into a killed state the @waiting counter will not be decremented leaving the pool to believe there is a thread available and waiting to complete work when that is not the case. Introduce a begin..ensure block so that any thread exception raised while in the wait state properly balances the @waiting counter.

:thumbsup::thumbsup: Looks great, and worthy of an upstream pull once we've run problem-free with it for a while.  Do we know what's up with Travis?  I would expect green goodness here.
(Great commit message, btw, and perfectly formatted.  Though for your upstream pull, you may want remove the hard newlines from the pull request description version of the message for maximum prettiness.  i.e. the actual commit message has its proper newlines, but when github converts it to a pull request description, you just manually delete them there.)

A few notes on the Travis test failures listed above:

Running the tests locally on MRI Ruby 2.3.x and JRuby <IP_ADDRESS>, all tests pass
Review the travis failures on the PR here, they all appear due to environmental problems with the old Travis images that are used.  Each failed run in the test matrix appears to be caused by different environmental problems.  I will work on an upgrade to Puma in a separate branch to bring it up to the most recent stable build.  I will not be fixing these old environmental build errors, but do expect that once Puma is upgraded to the most recent stable build, we will be back to all green.  If that has failures, then I will for sure work on sussing out why.

bah.  merge conflicts.  Opening up another PR to keep this clean.


✨  CI/CD Update

This PR

improves the CI/CD workflows
implements multiple small improvements revealed by the more comprehensive tests

@burgholzer Although all tests are green, the warning handling currently is a bit too generic because I had problems figuring out where exactly the warnings appeared to exclude them more specifically.

Reminder: Before merging, MQT Bench needs a new release and we need to update the dependency here accordingly.


Change architecture to improve mockability of modules for unit testing

Is there are any interest in refactoring the code to improve the mockability of modules.  The last time I unit tested a meanjs application, I had to create a testing database and set up a testing server to send and receive actual http requests.  In my experience, this is more of an end-to-end test rather than a unit test, and In general, a testing strategy like this is a pain in the butt for development and discourages frequent testing of the code.  Disclaimer - I haven't run unit tests with meanjs in awhile, so if this is no longer the case, you can disregard this issue.
I propose a refactoring of the modules in meanjs to improve unit testability.  I've created a commit where I've refactored the Articles controller, model, policy, and routes modules so that dependencies are properly injected and can subsequently be mocked in unit tests.  In my commit, I bootstrap these objects with their appropriate dependencies in the articles.server.config module.
For example, when unit testing articles.server.controller this refactor enables you to inject mocks of the mongoose and errorHandler dependencies so that the controller functionality can be properly isolated and tested.
The commit I linked above is purely for theoretical purposes and hasn't been tested or run.  I'm 100% sure that if you try to run the code it will fail.  Also, github's diff tool really stinks so it's hard to see exactly what's going on.
If this is something of interest to the community, I'd be happy to discuss it more and also take the task of implementation.  I wanted to propose the idea first though before getting too involved as it is a pretty significant refactor.

@rdelhommer totally understood and you're right. Your refactoring eases testing because you essentially created a poor-man's DI by providing a mongoose object which you can mock during your testing but now your controller is tightly coupled to your database. What happens if you want to switch to Sequelize or anything else?
Don't get me wrong. The current code is also pretty much coupled to the mongoose object by using it and the model directly to query items. A better approach would've been to implement a repository design pattern that will access the database.
In the meanwhile what I can suggest is that you may use a library like proxyquire for your unit test so that you can mock all the requires that are happening on the controller with mocked objects.

@lirantal That's a fair critique.
I think if the intention is to create a stack that is independent of the database layer, we need some form of DI and an adapter interface anyways (I could be wrong here).  If the intention is to stick with mongoose, then proxyquire is a simpler solution (which would require some legwork to be implemented), but keeps the stack hardened against any future modularity.
Either way, it seems to me that some legwork is required to make the stack unit-testable.  Why not go with a solution that keeps it flexible?

I don't think the MEAN.js project will ever reach out to be a technology-agnostic framework, simply because it's not what it was/is intended for. The idea is that the project is indeed opinionated (for example: coupled to mongoose db), but in the same time it is (or should be) flexible enough to give you room to make changes and introduce another db driver without too much fuss and abstractions that will "get in the way".
I'm not against fixing things up to ease unit-tests, by all means I full support it but these days @simison and @mleanos are largely supporting the MEAN.js roadmap while I'm focused on the evolution of it on https://github.com/lirantal/Riess.js where I'll be more than happy to get some help with and continue the discussion on architecture and design.

Sure that sounds good.  I'll check out Riess and let you know


feat: assume txt files with "requirements" in their name are requirements.txt files

This relaxes our logic for deciding if we can parse a file as a requirements.txt: we now assume any file that has "requirements" in its name and ends with .txt is probably a requirements.txt, which matches logic found elsewhere in the wild (e.g. dependabot).
Resolves #1266
Resolves #370
Resolves #67

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 69.18%. Comparing base (6d17d98) to head (7c1f0ad).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1271      +/-   ##
==========================================
+ Coverage   68.37%   69.18%   +0.80%
==========================================
  Files         175      175
  Lines       16784    13083    -3701
==========================================
- Hits        11476     9051    -2425
+ Misses       4677     3399    -1278
- Partials      631      633       +2

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Bee API stops to return data on GET requests (again!)

Context
Using Bee 1.5.1 with Docker, with addition of patch from #2909
Summary
Very similar to #2909, node looks like blocked on reply to GET requests. Tried with a wget, it stays hanged.
@mrekucci @acud
I'm attaching logs from abort signal.
abortLogs.txt
Expected behavior
It should reply with contents.
Actual behavior
It doesn't reply, keeping connection open.
Steps to reproduce
Don't know
Possible solution
Don't know

Using Bee 1.5.1 with Docker, with addition of patch from #2909

Are you sure? the trace you've attached shows this line:
goroutine 23502523 [select, 13 minutes]:
github.com/ethersphere/bee/pkg/sharky.(*Store).Read(0xc00003e240, {0x187da00, 0xc00e34ce70}, {0x0, 0x0, 0x0}, {0xc008d4d950, 0x0, 0x0})
	github.com/ethersphere/bee/pkg/sharky/store.go:128 +0x205

Which should not be the case because if you've cherry picked the commit (using git cherry-pick) this now points to a comment which is not possible. Can you please attach your current sharky/store.go file?

In the bee repository do the following:
git fetch --tags
git checkout tags/v1.5.1 -b v1.5.1
git cherry-pick 6ce1d595
make binary

You'll find the built bee binary under the ./dist/ directory.

I'm pretty sure that I did it right. I cherry picked 46ddd5c and a7751db over tag v1.5.1, and I compiled with docker build ..
I still have sources, so I'm able to attach sharky/store.go: store.zip
I'm not at desk today, I can try to build again tomorrow.
Anyway, if it is useful, I also published the container that I'm currently using here https://hub.docker.com/r/etherna/bee-fix-2909

ok we found the problem. should be fixed with https://github.com/ethersphere/bee/pull/2948. thanks again for reopening the issue. an eventual write to the result channel was missing in my last fix. it should be sorted now.


Does this library to work with firebird events?

I'm not author of the Firebird backend, but I don't think so events mechanism is supported. You may need to grep through the backend source code to see exactly what parts of the Firebird API is used.


Update managed-dependencies.md

From #runtime-totw, @akkrishnakumar (and Emir Uner) should be able to confirm.

Approved from my side.


added add_graph_from_neo4j method and example notebook

Simplified code and run black.

Regarding tests, the example notebook is probably the best I can come up with. The problem with testing this functionality is that a running Neo4j Graph Database is required. The example notebook connects to our COVID Neo4j database. The repo https://github.com/sbl-sdsc/neo4j-ipycytoscape runs an instance of the Neo4j database on the Pangeo binder (doesn't work on mybinder.org because of blocked ports), but that cannot be integrated with this repo.

Don't worry about dealing with the conflicts if you don't want to, I can deal with them once the review is done :)

I can also finish this PR if @ianhi and @pwrose are okay :)

@marimeireles please go ahead and finish this PR. Let me know if you have any questions. Thanks!

I think the neo4j example is not working anymore? @pwrose
I can't make it work locally. It gets stuck in the following cell:
graph = Graph("bolt://<IP_ADDRESS>:7687", user="reader", password="demo")

I can't access the logs, but I suppose it's the same issue. You have any ideas of what's up with this address?

Our COVID-19-Net database update got stuck last night. It should work again.
From: Mariana Meireles @.>
Reply-To: QuantStack/ipycytoscape @.>
Date: Wednesday, April 21, 2021 at 4:40 AM
To: QuantStack/ipycytoscape @.>
Cc: Peter Rose @.>, Mention @.***>
Subject: Re: [QuantStack/ipycytoscape] added add_graph_from_neo4j method and example notebook (#245)
I think the neo4j example is not working anymore? @pwrosehttps://urldefense.com/v3/__https:/github.com/pwrose__;!!Mih3wA!WcTo10cNgjCn8saOUfodh5s2wblEcL49niIPyGF6jpwqKcIjU94rG9OX2OtWxqI$
I can't make it work locally. It gets stuck in the following cell:
graph = Graph("bolt://<IP_ADDRESS>:7687", user="reader", password="demo")
I can't access the logs, but I suppose it's the same issue. You have any ideas of what's up with this address?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https:/github.com/QuantStack/ipycytoscape/pull/245*issuecomment-823994005__;Iw!!Mih3wA!WcTo10cNgjCn8saOUfodh5s2wblEcL49niIPyGF6jpwqKcIjU94rG9OX9zEdI6M$, or unsubscribehttps://urldefense.com/v3/__https:/github.com/notifications/unsubscribe-auth/AA53AEBWW53R7SIRRWKX3ILTJ22R7ANCNFSM4YMAZD6A__;!!Mih3wA!WcTo10cNgjCn8saOUfodh5s2wblEcL49niIPyGF6jpwqKcIjU94rG9OXV0d3Cv8$.

Funny, now I can load the graph locally but can't query it at all, I get stuck in this cell:
query1 = """
MATCH p=(:City{name:'San Francisco'})-[:IN*]->(:World) RETURN p
"""
subgraph1 = graph.run(query1).to_subgraph()

But apparently the CI can go further? But something goes wrong on the next query, because when it tries to use the graph queried it throws a NoneType error.
widget2.graph.add_graph_from_neo4j(subgraph2)

I'm thinking about removing this notebook from our tests because the server seems a bit unstable, but still keep it around so people can understand how to use the neo4j plug.

Thanks for the work @pwrose, the contribution and the patience for taking the time to create the PR and merge it :)
Really appreciated, this is a really awesome addition!

It’s a good idea to remove this notebook from the test. Our COVID database is under active development, so it’s not always available or data will be incomplete during our daily update around 7:00 – 10:00 UTC.
From: Mariana Meireles @.>
Reply-To: QuantStack/ipycytoscape @.>
Date: Thursday, April 22, 2021 at 2:39 AM
To: QuantStack/ipycytoscape @.>
Cc: Peter Rose @.>, Mention @.***>
Subject: Re: [QuantStack/ipycytoscape] added add_graph_from_neo4j method and example notebook (#245)
Funny, now I can load the graph locally but can't query it at all, I get stuck in this cell:
query1 = """
MATCH p=(:City{name:'San Francisco'})-[:IN*]->(:World) RETURN p
"""
subgraph1 = graph.run(query1).to_subgraph()
But apparently the CI can go further? But something goes wrong on the next query, because when it tries to use the graph queried it throws a NoneType error.
widget2.graph.add_graph_from_neo4j(subgraph2)
I'm thinking about removing this notebook from our tests because the server seems a bit unstable, but still keep it around so people can understand how to use the neo4j plug.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https:/github.com/QuantStack/ipycytoscape/pull/245*issuecomment-824693790__;Iw!!Mih3wA!QC75OtFDPIaFV93qjSSy4EnA6Cwm9Jq5GFBeuCEl7uGcndCzxFg2UmfKD4F2of8$, or unsubscribehttps://urldefense.com/v3/__https:/github.com/notifications/unsubscribe-auth/AA53AEEQ27UN4R3CIMUTR7DTJ7VERANCNFSM4YMAZD6A__;!!Mih3wA!QC75OtFDPIaFV93qjSSy4EnA6Cwm9Jq5GFBeuCEl7uGcndCzxFg2UmfKzJ3OIVU$.


Cleaned up deprecated pages

Removed the following:
Pages/Controller/Route: about, hello, staff, team
Removed old references in routes that were no longer in use throughout the application.
Fixes #160

Still haven't gotten around to this...apologies. I'll try and take a look tomorrow.


Add hook example

SSIA

Codecov Report

Merging #31 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #31   +/-   ##
=======================================
  Coverage   83.28%   83.28%
=======================================
  Files           6        6
  Lines         317      317
=======================================
  Hits          264      264
  Misses         53       53

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 525703c...7147763. Read the comment docs.


How to increase effect of text prompt?

Is there anyway we can increase the relative weight of the SD text conditioning? The reason for this is sometimes the additional condition is too strong and what we are trying to bring out using text is unfulfilled.

@lllyasviel

the attention layers in controlnet also receives text. Technically it should be able to mix them appropriately if trained properly.

might be related:
[New Feature] Control Mode https://github.com/Mikubill/sd-webui-controlnet/issues/1011#issuecomment-1529035570
On "Balanced", "My prompt is more important" and "ControlNet is more important"


Microsoft Remote Desktop (MRD) 10.3.8 - MacOS - Bulk Import

I manage a set of 800 VMs and I can't find a way to import an XML or RDG file with multiple VMs.
A developer mentioned (app feedback in App Store) using a script to import them but I can't find any information on how to build said script and run it for this application.
Can this information be added to the documentation?

Hey PREngineer,
Thanks for contacting Microsoft. We value your feedback.
As we understand it, you're describing a potential issue with a Windows product or service, rather than the documentation itself.
GitHub issues in the Windows Server repo are monitored for content issues that we can address, such as broken links, grammar or wording, typos, updates, or incorrect code in examples. We offer other channels for engaging with us, whether you have a support question, product feedback, or other feedback.
We cannot assist with the following as it's outside our scope of work:

Support cases or support tickets
Bug submittal or Feature requests
Extended troubleshooting, technical support, or product support

Instead, please use one or more of the following:

On a Windows OS, use Windows Feedback Hub or press Windows + F. You can also provide feedback with using our Feedback Portal.
Open a ticket with Microsoft Support.
Search or engage with Microsoft TechNet.
Search or engage with the Microsoft Developer Network.
Search or engage with the Microsoft Support Community.

As this is a non-documentation issue, we’re closing this thread.
Thank you and have a most pleasant day.
#please-close


Document existing CF credential_client_id bind ressource

What is the problem this PR solves?
credential_client_id is provided by cloudfoundry cloudcontroller in the binding resource since late 2017. See background at https://www.pivotaltracker.com/n/projects/966314/stories/151111701
Checklist:

[ ] The swagger.yaml doc has been updated with any required changes

Existing profile fields seems not described in the current swagger.yml ServiceBindingResourceObject

[ ] The openapi.yaml doc has been updated with any required changes

Existing profile fields seems not described in the current openapi.yaml ServiceBindingResource

Thanks for adding this to the spec @gberche-orange !
There seem to be some legitimate travis failures to investigate when you have the change: https://travis-ci.org/github/openservicebrokerapi/servicebroker/builds/661911797?utm_source=github_status&utm_medium=notification

thanks @mattmcneeney for your review and heads up on failed test.
I've fixed the formatting violations reported by the build.
Remains the following error in build 663828758 which I assume is false negative since the PR is not touching schemas

Errors:

Could not find components/schemas/# in contents of http://json-schema.org/draft-04/schema

Yep you’re right. I’ve opened a PR to fix that so once that’s merged I’ll retrigger this build!

@gberche-orange the PR makes sense, a quick question how would the broker discover the url of the credhub its supposed to put credentials in. OR that does not come thru the spec, its configured on the broker

@tinygrasshopper thanks for the heads up. My reverse engineering of the presence of this field was incomplete (I haven't yet used this credhub ref feature but I'm keen to have it documented in the spec as I'm still observing it in OSB payloads my service brokers receive).
Following a deeper read of https://www.pivotaltracker.com/n/projects/966314/stories/151111701 and credhub documentation, I've updated the PR to introduce the CloudFoundry service binding, service key and credhub reference concepts, and make it clear that the provisioning of credhub url and authN/authZ to Service Brokers is performed out of band.
It might make sense to add to the specs the credential format when using credhub reference, likely in #683 or #116

@gberche-orange The way I read this change now is that Service Brokers may return a credhub reference for a 'service key' request, but not for a normal 'service binding'. Is that the correct reading or am I missing something?

@mattmcneeney

The way I read this change now is that Service Brokers may return a credhub reference for a 'service key' request, but not for a normal 'service binding'. Is that the correct reading or am I missing something?

Yes, this is correct.
For a service binding, service brokers should grant the bound app (through its provided appguid) permission to read the CredHub reference
For a service key, it is instead assumed that the credential will be looked up by the cloudcontroller (or another credhub client), and therefore the specified credhub client id should be granted permission to read the CredHub reference
See
https://www.pivotaltracker.com/story/show/151111701/comments/180009415

verified service key request contains client
2017-09-21T16:21:11.11-0700 [APP/PROC/WEB/0] OUT INFO: Request body: {"service_id":"f929f899-1818-4fc2-9454-f8def6c3f0e8","plan_id":"1faef310-2c21-4a1a-88ce-1fe06df77f76","bind_resource":{"credential_client_id":"cc_service_key_client"},"context":{"platform":"cloudfoundry","organization_guid":"d65a9c3f-0507-447c-bd4b-2e63c8088bfd","space_guid":"524df9a7-2236-4793-b0da-606066c6a214"}}
verified bind request does not contain client
2017-09-21T16:22:15.18-0700 [APP/PROC/WEB/0] OUT INFO: Request body: {"service_id":"f929f899-1818-4fc2-9454-f8def6c3f0e8","plan_id":"1faef310-2c21-4a1

Does it make sense ?
Maybe @zrob which contributed this feature back in 2017 can provide more background if necessary

@mattmcneeney
Sorry,credhub references can be returned in both SB and SK, but the client_id is included in the bind resource for SK. I'll double check the wording

@mattmcneeney
Double reading the proposed changed, I did not spot where the could have an ambiguity about service binding responses not supporting credhub references. Can you please use github review feature to point the specific line and if possible suggest a better wording ?

I mistook the bind_resource object being part of the response rather than the request. I think this actually makes sense to me now! Thanks for the explanation

Trying to retrigger Travis

@tinygrasshopper / @rsampaio if one of you can approve this one before Friday we can try to include it in the release!