Question about testing conda installation

Hi Nicklas,
I'm happy to test this out but am not sure exactly how to do it, as it does not seem to be (yet) a normal conda install. Also, I don't want to mess up my current GRASS source git folder if I can avoid it (not a big deal). Can you give a bit more details on the work flow?  Thanks

I'm know I have been short on description (intend to work on that).
I'm using, as far as I know, a perfectly normal (default) anaconda installation. So that shouldn't be an issue.
If you checkout e.g master or releasebranch_7_8, with no other alterations (that you wish to keep), the instructions on Readme will restore to original state. If you really want to play safe (not really needed) you can always branch before.
The script assumes anaconda is located in ~/opt/anaconda3. If this isn't the case for you, then the script has to be modified. Other than that, it should be safe. I put as many safety check as I could – so not much can go wrong (only fail).
This script package does all (almost) of the steps you wrote in grasswiki: patches, installs miniconda, compiles and installs.
If you already have a /Applications/GRASS-7.X.app that you wish to keep, please temporarily rename it (there is a check for this too).
Make sure to cd to the script directory (grass-conda), and fill in your configs in configure-build.sh and execute ./build-grass.sh.

I made a major update, use current repo state in case of testing.
See also the updated Readme.
One notable difference is that the patched files are automatically reverted when finished or in case of failure: no need to worry about that.
I also did a restructuring of the main script file ./build-grass.sh, which now is better self-explanatory if you wish to review the code.
Additionally, the ~/opt/anaconda3 issue should be any problem.
PS. I also successfully tested building with SDK 10.13!

Beware, the patches are updated for – and only works for – 7.9.dev at present.
Looking for a more general solution...

Beware, the patches are updated for – and only works for – 7.9.dev at present.
Looking for a more general solution...

This is now fixed. Current repo state handles 7.8.3, 7.8.4dev and 7.8.9dev.

@cmbarton, I have updated again. Now it is also possible to create dmg file, see updated readme.

This is very exciting @nilason. I hope to be able to try it out soon, once I have other obligations out of the way

This is very exciting @nilason. I hope to be able to try it out soon, once I have other obligations out of the way

It is exciting! As it is a work-in-progress, I only want you to be informed for the moment when you'll have the time...

This week is pretty crazy, but maybe I'll be able to run some tests.
Just to make sure I understand, to compile this into a binary as I have been doing previously, I simply need to update to the newest versions of 7.9 and 7.8.4, apply your new patches, and compile. Right?
I will set configure to look for the current Mac SDK. Do you have a way to test whether this runs on Mojave? My computers are all at Catalina.
If that goes OK, I'll venture out to try your Anaconda recipe. Thanks again for all your work on this.

The script will do all the steps you described in grasswiki, including patching.
To build and install you need to configure:

SDK full path to the SDK that will be set to -isysroot, this is what will be used on building, you may preferably use one older one for broader support (e.g. 10.12 or 10.13) I tried successfully with 10.13.
GRASSDIR full path to the GRASS GIS source directory
CONDA_ENV name of conda environment

Regardless which SDK you use in compiling, the script will change the path to sysroot in Platform.make after installation to a hardlinked (but non-versioned) /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk. This means a user have to install Command Line Tools to be able to compile extensions. I don't think there is a way to get around that.
If you add --dmg-out-dir [path] argument to ./build-grass.sh a dmg will be created at "path".
Please, do read the readme.

Sounds great. I’ll certainly read through the readme before I try it. A related question (maybe in readme). Does it create an app packaged with all dependencies inside, or does it use a local condo installation?

Everything is inside the app bundle.

I had some time and it seems very simple to run this. So I tried it several times.  I include a short example below. But what I think the problem is that the patches are not being applied. The error is for a missing dylib as was the case before you fixed the patches. I did not apply them manually, but can try that this week. I looked at aclocal.m4 and I'm pretty sure that it has not been patched.
A couple other things I noticed. In the configure script, there is an argument for --without-readline. And at the end, is --with-readline and the needed paths.
Also, the process stops at install to ask for a sudo password. I was under the impression that installing with sudo could cause problems for users down the line. Maybe this is just old and no longer relevant. But at least you might want to note that users will need to enter an admin password during the installation.
Example error from one of the modules
(base) cmbarton@TCLASHE-C02Q40UVFY14 ~ % cd /Users/cmbarton/grass_source/grass/lib/vector/diglib

(base) cmbarton@TCLASHE-C02Q40UVFY14 diglib % make
if [ "" != "" -a -f "".html ] ; then /Applications/Xcode.app/Contents/Developer/usr/bin/make html ; fi
==============TEST=============
/Applications/Xcode.app/Contents/Developer/usr/bin/make test
cd OBJ.x86_64-apple-darwin19.6.0 && GISRC=/Users/cmbarton/grass_source/grass/dist.x86_64-apple-darwin19.6.0/demolocation/.grassrc79 GISBASE=/Users/cmbarton/grass_source/grass/dist.x86_64-apple-darwin19.6.0 PATH="/Users/cmbarton/grass_source/grass/dist.x86_64-apple-darwin19.6.0/bin:/Users/cmbarton/grass_source/grass/dist.x86_64-apple-darwin19.6.0/bin:/Users/cmbarton/grass_source/grass/dist.x86_64-apple-darwin19.6.0/scripts:$PATH" PYTHONPATH="/Users/cmbarton/grass_source/grass/dist.x86_64-apple-darwin19.6.0/etc/python:/Users/cmbarton/grass_source/grass/dist.x86_64-apple-darwin19.6.0/gui/wxpython:$PYTHONPATH" DYLD_LIBRARY_PATH="/Users/cmbarton/grass_source/grass/dist.x86_64-apple-darwin19.6.0/bin:/Users/cmbarton/grass_source/grass/dist.x86_64-apple-darwin19.6.0/bin:/Users/cmbarton/grass_source/grass/dist.x86_64-apple-darwin19.6.0/scripts:/Users/cmbarton/grass_source/grass/dist.x86_64-apple-darwin19.6.0/lib:/Users/cmbarton/grass_source/grass/dist.x86_64-apple-darwin19.6.0/lib:" LC_ALL=C LANG=C LANGUAGE=C ./test
dyld: Library not loaded: @rpath/libzstd.1.dylib
  Referenced from: /Users/cmbarton/grass_source/grass/dist.x86_64-apple-darwin19.6.0/lib/libgrass_gis.7.9.dylib
  Reason: image not found
/bin/sh: line 1: 48232 Abort trap: 6           GISRC=/Users/cmbarton/grass_source/grass/dist.x86_64-apple-darwin19.6.0/demolocation/.grassrc79 GISBASE=/Users/cmbarton/grass_source/grass/dist.x86_64-apple-darwin19.6.0 PATH="/Users/cmbarton/grass_source/grass/dist.x86_64-apple-darwin19.6.0/bin:/Users/cmbarton/grass_source/grass/dist.x86_64-apple-darwin19.6.0/bin:/Users/cmbarton/grass_source/grass/dist.x86_64-apple-darwin19.6.0/scripts:$PATH" PYTHONPATH="/Users/cmbarton/grass_source/grass/dist.x86_64-apple-darwin19.6.0/etc/python:/Users/cmbarton/grass_source/grass/dist.x86_64-apple-darwin19.6.0/gui/wxpython:$PYTHONPATH" DYLD_LIBRARY_PATH="/Users/cmbarton/grass_source/grass/dist.x86_64-apple-darwin19.6.0/bin:/Users/cmbarton/grass_source/grass/dist.x86_64-apple-darwin19.6.0/bin:/Users/cmbarton/grass_source/grass/dist.x86_64-apple-darwin19.6.0/scripts:/Users/cmbarton/grass_source/grass/dist.x86_64-apple-darwin19.6.0/lib:/Users/cmbarton/grass_source/grass/dist.x86_64-apple-darwin19.6.0/lib:" LC_ALL=C LANG=C LANGUAGE=C ./test
make[1]: *** [OBJ.x86_64-apple-darwin19.6.0/test.tmp] Error 134
make: *** [default] Error 2
(base) cmbarton@TCLASHE-C02Q40UVFY14 diglib %

I have remade the patches, separate for 7.8.3, 7.8.4dev and 7.9dev, so that they are applied without error messages. I have tried them all, so they should work.
Please try with an absolutely clean source directory, I suggest for testing purposes download https://github.com/OSGeo/grass/archive/master.zip, unzip and set that directory to GRASSDIR config. Then if it still fails, please do email me the complete terminal output.
Thanks for noting, I will remove --without-readline, it's a leftover (but overridden by the others). Shouldn't cause any problems though.
Re: sudo. I will try removing it, I use it habitually to make install (in unix style install to default location in /usr/local/). Regardless of this, if I install from the resulting dmg by dragging to /Applications the app's file(s) owner is the user
's (no need for sudo for the user!).

I will try this and let you know.

Found a bug in this script and updated, please re-download this repo before testing.

I think I spotted the problem. Right off the start, I get this message:
./build-grass.sh: line 183: (ASU)/GitHub/grass-conda/patches/7.9.dev/*.patch: No such file or directory
So the patches are not applied. I cloned your code to my GitHub folder, which is at:
/Users/cmbarton/Dropbox\ (ASU)/GitHub/grass-conda
This shows up in the finder as:
/Users/cmbarton/Dropbox (ASU)/GitHub/grass-conda
Somehow this is not getting parsed correctly

I copied the grass-conda folder to a local home folder with no spaces or special characters. It did the patching and built the app without errors. Still asking for admin password.
The dmg creation failed, possibly because I gave it an output folder in my dropbox (with spaces and parentheses in the name). Here is the error generated in the terminal
Create dmg file of /Applications/GRASS-7.9.app ...
...........................................................................
created: /tmp/org.osgeo.grass.pCzBic/grass-tmp-12222.dmg
hdiutil: convert: only a single input file can be specified
Usage:	hdiutil convert -format <format> -o <outfile> [options] <image>
	hdiutil convert -help

Yes, should have mentioned. The script isn't space safe. Try again with changing --dmg-out-dir to e.g ~/Desktop and add  --repackage argument. It will then not build again, only try to (re-)create the dmg.

I just tried the whole thing again (before getting your comment) using my regular GRASS source git clone and aiming the dmg out to a local folder: --dmg-out-dir /Users/cmbarton/grass_dmg.
Again, patching, compiling, and app building went well. This time it DID create a dmg, but it put it in my home folder not the one I specified.
I just tried the repackaging adding a / to the output for dmg.
--dmg-out-dir /Users/cmbarton/grass_dmg/
It put it in the right place now.

It put it in the right place now.

Voilà, great!

I just tried this with my grass git repository for 7.8, using git checkout releasebranch_7_8. Worked great. I will be spoiled and forget how to deal with the details of doing this.
One thing to note, I tried different dmg output folders. It seems like the script will not work with any folder path that has spaces or special characters, even if quoted or escaped with backslashes. I assume this will be the same for the path to a GRASS source folder.  Not a big deal, but worth a mention.

I just tried this with my grass git repository for 7.8, using git checkout releasebranch_7_8. Worked great. I will be spoiled and forget how to deal with the details of doing this.

Splendid! Good thing you've already written it down then :-).

So @cmbarton , I updated with the following changes:

no more need of sudo
spaces in path allowed for grass-conda directory and --dmg-out-dir, but not for GRASSDIR  or SDK (updated docs accordingly)
GRASS version (in Info.plist) changed for dev versions, short git commit hash included in this format:
7.8.4dev (c0c9afe0f) to be able to address issues that may come up

I just tried to install a binary made with this set up. Here is a suggestion. Make a symlink to /Applications in the dmg so that users can easily drag and install the app..

Here is a suggestion. Make a symlink to /Applications in the dmg so that users can easily drag and install the app..

That has been the plan from the start, with a nice background too.

Even better!

I forgot to remind you that you need to make a symlink to the correct python version, because updating python after a miniconda installation manages to install 2 different versions. This causes 2 instances of python to be launched when GRASS is started. One of them then immediately crashes. It causes no harm for the main GRASS app, but can be confusing to users. Here is what I do for v. 7.9. (same thing but a different path for 7.8)
ln -sf /Applications/GRASS-7.9.app/Contents/Resources/bin/python /Applications/GRASS-7.9.app/Contents/Resources/python.app/Contents/MacOS/python

I forgot to remind you that you need to make a symlink to the correct python version, because updating python after a miniconda installation manages to install 2 different versions. This causes 2 instances of python to be launched when GRASS is started. One of them then immediately crashes. It causes no harm for the main GRASS app, but can be confusing to users. Here is what I do for v. 7.9. (same thing but a different path for 7.8)
ln -sf /Applications/GRASS-7.9.app/Contents/Resources/bin/python /Applications/GRASS-7.9.app/Contents/Resources/python.app/Contents/MacOS/python

Is the following (from present code):
https://github.com/nilason/grass-conda/blob/d8e742256bea48160ea0e43d9de2fd30083a5344/build-grass.sh#L389-L390
not enough, or should it be changed to what you suggested? I didn't experience any problem yet with current code and at the moment I cannot test.

This causes the issue you noted awhile back of 2 instances of Python getting launched, and then one of them crashing. It happens right after GRASS launches and then GRASS runs fine. But it shouldn't happen. This may fix itself when miniconda moves up to Python 3.8.

I assumed that was the case, but I couldn't reproduce it.
Should the present
ln -sf /Applications/$GRASS_APP_NAME/Contents/Resources/python.app/pythonapp/Contents/* \
     /Applications/$GRASS_APP_NAME/Contents/Resources/python.app/Contents

be changed to:
ln -sf /Applications/$GRASS_APP_NAME/Contents/Resources/bin/python \
     /Applications/$GRASS_APP_NAME/Contents/Resources/python.app/Contents/MacOS/python

or should the latter be added?

It should be changed. The first was for Python 3.6. This is for 3.7.8.

Just tested with existing code again and it works fine:
GRASS 7.9.dev (nc_spm_08_grass7):~ > echo $GRASS_PYTHON
/Applications/GRASS-7.9.app/Contents/Resources/bin/pythonw
GRASS 7.9.dev (nc_spm_08_grass7):~ > /Applications/GRASS-7.9.app/Contents/Resources/bin/pythonw --version
Python 3.7.8

I couldn't find any other python version in the bundle. Maybe the python version in conda environment must be in sync with what's stated in the file conda-requirements.txt, which is now defaulting to 3.7.8, to avoid the double installation.

I'll try a new compile soon and let you know. Thanks.

I just updated GRASS and your conda app builder code and compiled GRASS 7.9. Two things I'll put in 2 comments.
First, when I launched the newly compiled code, it again gave me the python crash error :

I can click "ignore" and all seems well for the rest of the session. But this happens whenever I launch GRASS. After entering:
ln -sf /Applications/GRASS-7.9.app/Contents/Resources/bin/python /Applications/GRASS-7.9.app/Contents/Resources/python.app/Contents/MacOS/python
This no longer happens.

The second issue may not be an issue, but I want to let you know. At the end of the compiling procedure, when it makes a dmg, I got a Mac dialog to enter my PW. I did, and a dmg seems to have been created (haven't tested it yet). In the terminal, I got this output: an "authentication error", followed by out that seems to indicate the dmg has been produced correctly. Does it look OK to you too?

Create dmg file of /Applications/GRASS-7.9.app ...
/Applications/GRASS-7.9.app/Contents/Resources/ssl/misc/tsget.pl: Authentication error
........................................................................................................
created: /tmp/org.osgeo.grass.Vvl1F7/grass-tmp-84387.dmg
Preparing imaging engine…
Reading Protective Master Boot Record (MBR : 0)…
   (CRC32 $81302BA4: Protective Master Boot Record (MBR : 0))
Reading GPT Header (Primary GPT Header : 1)…
   (CRC32 $CE8C27E7: GPT Header (Primary GPT Header : 1))
Reading GPT Partition Data (Primary GPT Table : 2)…
   (CRC32 $578D46AE: GPT Partition Data (Primary GPT Table : 2))
Reading  (Apple_Free : 3)…
   (CRC32 $00000000:  (Apple_Free : 3))
Reading disk image (Apple_HFS : 4)…
......................................................................................................
   (CRC32 $6E100324: disk image (Apple_HFS : 4))
Reading  (Apple_Free : 5)…
..............................................................................................................
   (CRC32 $00000000:  (Apple_Free : 5))
Reading GPT Partition Data (Backup GPT Table : 6)…
..............................................................................................................
   (CRC32 $578D46AE: GPT Partition Data (Backup GPT Table : 6))
Reading GPT Header (Backup GPT Header : 7)…
..............................................................................................................
   (CRC32 $0DFFFCAD: GPT Header (Backup GPT Header : 7))
Adding resources…
..............................................................................................................
Elapsed Time: 28.527s
File size: 429500235 bytes, Checksum: CRC32 $3F0B666A
Sectors processed: 3474702, 3043812 compressed
Speed: 52.1Mbytes/sec
Savings: 75.9%
created: /Users/cmbarton/Dropbox (ASU)/GRASS_dropbox/compiling/binary_pkg/condabuild//grass-7.9.dev.dmg```

I have not been able to follow all the PRs in detail. So I don't know if this is a bug or not. With the version of master I just compiled today, it no longer launches the GRASS startup screen with the option to pick a location and mapset.

I have not been able to follow all the PRs in detail. So I don't know if this is a bug or not. With the version of master I just compiled today, it no longer launches the GRASS startup screen with the option to pick a location and mapset.

It’s on master only, see eg https://github.com/OSGeo/grass/projects/1

The data tab is the new hub, replacing the startup dialog.

Some background :
https://trac.osgeo.org/grass/wiki/wxGUIDevelopment/New_Startup

Some background :
https://trac.osgeo.org/grass/wiki/wxGUIDevelopment/New_Startup

Thanks

The second issue may not be an issue, but I want to let you know. At the end of the compiling procedure, when it makes a dmg, I got a Mac dialog to enter my PW. I did, and a dmg seems to have been created (haven't tested it yet). In the terminal, I got this output: an "authentication error", followed by out that seems to indicate the dmg has been produced correctly. Does it look OK to you too?

This happens for me too, didn’t notice though. Seems to not impact the workings. Maybe need to reintroduce sudo.

I think I found the cause and a fix for the python problem. Updated the build source.
Seems Miniconda installs things at the wrong place, files that should go to
/Applications/GRASS-7.9.app/Contents/Resources/python.app/Contents
went to
/Applications/GRASS-7.9.app/Contents/Resources/python.app/pythonapp/Contents.
My fix moves them to the right place. It works for me, hopefully it works for you as well.
I also added sudo for creating dmg, so don't be surprised.

Updated with (hopefully now) fixed language detection for multi language setups (fallback should now work as well).

Updated the code: now no longer necessary to cd to grass-conda script directory, additionally a background is added to the dmg file (together with Application alias).

@cmbarton Added support for 7.8.4RC1.
If you'd like to test:
cd [grass source dir]
git checkout 7.8.4RC1
./build-grass.sh [...]

Thanks. A bit complicated right now but hope to test it soon.

I just tried building 7.8.4 and got a lot of errors. Should I assume that is because this does not yet support that version?

Seems to be a linker problem
make: *** [default] Error 1
Compilation failed, you may need to reset the GRASS git repository.
This can be made with: "cd [grass-source-dir] && git reset --hard".

(base) TCLASHE-C02V435YJ1GQ:grass-7.8.4 cmbarton$
(base) TCLASHE-C02V435YJ1GQ:grass-7.8.4 cmbarton$ cd /Users/cmbarton/grass_source/grass-7.8.4/lib/proj
(base) TCLASHE-C02V435YJ1GQ:proj cmbarton$ make
/Applications/GRASS-7.8.app/Contents/Resources/bin/clang -dynamiclib -compatibility_version 7.8 -current_version 7.8 -install_name @rpath/libgrass_gproj.7.8.dylib -liconv -Wl,-pie -Wl,-headerpad_max_install_names -Wl,-dead_strip_dylibs -Wl,-rpath,/Applications/anaconda2/lib -L/Applications/anaconda2/lib  -arch x86_64 -isysroot /Library/Developer/CommandLineTools/SDKs/MacOSX10.14.sdk   -L/Applications/GRASS-7.8.app/Contents/Resources/lib -Xlinker -rpath -Xlinker /Applications/GRASS-7.8.app/Contents/Resources/lib -Xlinker -rpath -Xlinker /Users/cmbarton/grass_source/grass-7.8.4/dist.x86_64-apple-darwin19.6.0/lib -o /Users/cmbarton/grass_source/grass-7.8.4/dist.x86_64-apple-darwin19.6.0/lib/libgrass_gproj.7.8.dylib -L/Users/cmbarton/grass_source/grass-7.8.4/dist.x86_64-apple-darwin19.6.0/lib -L/Users/cmbarton/grass_source/grass-7.8.4/dist.x86_64-apple-darwin19.6.0/lib -Wl,-pie -Wl,-headerpad_max_install_names -Wl,-dead_strip_dylibs -Wl,-rpath,/Applications/anaconda2/lib -L/Applications/anaconda2/lib  -arch x86_64 -isysroot /Library/Developer/CommandLineTools/SDKs/MacOSX10.14.sdk   -L/Applications/GRASS-7.8.app/Contents/Resources/lib -Xlinker -rpath -Xlinker /Applications/GRASS-7.8.app/Contents/Resources/lib -Xlinker -rpath -Xlinker /Users/cmbarton/grass_source/grass-7.8.4/dist.x86_64-apple-darwin19.6.0/lib   OBJ.x86_64-apple-darwin19.6.0/convert.o OBJ.x86_64-apple-darwin19.6.0/datum.o OBJ.x86_64-apple-darwin19.6.0/do_proj.o OBJ.x86_64-apple-darwin19.6.0/ellipse.o OBJ.x86_64-apple-darwin19.6.0/get_proj.o  -lgrass_gis.7.8 -L/Applications/GRASS-7.8.app/Contents/Resources/lib -lgdal -L/Applications/GRASS-7.8.app/Contents/Resources/lib -lproj
ld: warning: -pie being ignored. It is only used when linking a main executable
Undefined symbols for architecture x86_64:
  "_proj_get_remarks", referenced from:
      _GPJ_init_transform in do_proj.o
  "_proj_get_scope", referenced from:
      _GPJ_init_transform in do_proj.o
ld: symbol(s) not found for architecture x86_64
clang-10: error: linker command failed with exit code 1 (use -v to see invocation)
make: *** [/Users/cmbarton/grass_source/grass-7.8.4/dist.x86_64-apple-darwin19.6.0/lib/libgrass_gproj.7.8.dylib] Error 1

You need to disable anaconda2 first. Clashes with miniconda.

No way for it to find anaconda2 since it's not in my path.
I did it again today, untarring the original again and it works fine.
No idea.

Not only the $PATH is involved. See the prompt: (base) TCLASHE-C02V435YJ1GQ:grass-7.8.4 cmbarton$ – the "(base)" part indicates conda is active. conda deactivate might work.
When you see something like [...],-rpath,/Applications/anaconda2/lib -L/Applications/anaconda2/lib[...] you know something will go wrong for this build (and where to start looking for solution).
Glad it worked out though!
Sidenote: You can also use the git repo instead of the tarball with cd [grass-source-dir] && git checkout 7.8.4.

Thanks for adding the conda environment at the end of the compilation. It makes it easier to create a config file to go along with the binaries.

Thanks for adding the conda environment at the end of the compilation. It makes it easier to create a config file to go along with the binaries.

I'm glad to assist!

@cmbarton Now I have updated with the possibility to build with libLAS by adding the flag --with-liblas. This enables the modules r.in.lidar, r3.in.lidar, v.in.lidar and v.out.lidar.
As libLAS is not available with conda, the build script downloads the source code, compiles and installs into the GRASS app bundle.
Please do give it a test.


Design QA: Market Creation

All remaining issues organized into release/2.x with appropriate labels -- closing.


Upload to PyPI proper

And reserve the name 📌

Done: https://pypi.org/project/colorsysx/
pip install colorsysx


[SPARK-33479][Doc] Make the API Key of DocSearch configurable

What changes were proposed in this pull request?

Make the API key of DocSearch configurable and avoid hardcoding in the HTML template
Why are the changes needed?

After https://github.com/apache/spark/pull/30292, our Spark documentation site supports searching.
However, the default API key always points to the latest release doc. We have to set different API keys for different releases. Otherwise, the search results are always based on the latest documentation(https://spark.apache.org/docs/latest/) even when visiting the documentation of previous releases.
As per discussion in https://github.com/apache/spark/pull/30292#issuecomment-725613417, we should make the API key configurable and set different values for different releases.
Does this PR introduce any user-facing change?

No
How was this patch tested?

Manual test

cc @beliefer @gatorsmile @maropu @sarutak , since you have reviewed https://github.com/apache/spark/pull/30292

Test build #131276 has started for PR 30409 at commit 2da48ff.

Test build #131276 has finished for PR 30409 at commit 2da48ff.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35880/

Seems fine to me except the minor issue @maropu pointed out.
By the way, though it's not the thing done in this PR, we should also update the release process right?

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35880/

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/35880/
Test PASSed.

Test build #131280 has started for PR 30409 at commit b42cf1f.

By the way, though it's not the thing done in this PR, we should also update the release process right?

@sarutak sure, we should update it after this one is merged.

Test build #131280 has finished for PR 30409 at commit b42cf1f.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/131280/
Test PASSed.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35884/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35884/

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/35884/
Test FAILed.

Thanks! Merged to master.

@maropu @sarutak @beliefer Thanks for the review.
As for updating the release process, I am trying to apply a new API key for https://spark.apache.org/docs/3.1.0 . I would like to see if I can get the API key before the doc site actually published.

@maropu @sarutak @beliefer Thanks for the review.
As for updating the release process, I am trying to apply a new API key for https://spark.apache.org/docs/3.1.0 . I would like to see if I can get the API key before the doc site actually published.

Yes, we should try it.


CSS_Buttons(Animated)-Frontend web development html css js

Description 📜
For issue number#1507

Review of creating buttons with HTML
Tutorial of CSS Properties to style buttons and most used button styles.
Code tutorial for animated buttons

Fixes # 1507

Type of change 📝

[ ] Au#dio (Should be in mp3 format Includes speech clarity, Concise ,Low distortion)
[ ] Vi#deo (Animations, screen-recordings, presentations and regular explanatory films are all possibilties etc)
[ ] Documentation (Content Creation in the form of codes or tutorials)
[ ] Other (If you choose other, Please mention changes below)

Domain of Contribution 📊

[ ] Android Dev #(Flutter)
[ ] Android Dev #(Java)
[ ] Android Dev #(Kotlin)
[ ] Backend Dev #(Java)
[ ] Backend Dev #(.NET)
[ ] Backend Dev #(PHP)
[ ] Backend Dev #(Python)
[ ] C/#CPP
[ ] Competitive #Programming
[ ] Cyber #Security
[ ] DS#A
[ ] Data#base
[ ] Datascience with #Python
[ ] Datascience with #R
[ ] Frontend Dev HTML/CSS/JS
[ ] Frontend Dev #React/Angular/Vue
[ ] Go#lang
[ ] Interview #Prep
[ ] Java_#Domain
[ ] Java#Script
[ ] ME#RN
[ ] Machine #Learning
[ ] Open #Source
[ ] Python_#Domain
[ ] Ru#st
[ ] Statis#tics
[ ] UI/#UX

Checklist ✅

[ x] I follow Contributing Guidelines & Code of conduct of this project.
[x ] I have performed a self-review of my own code or work.
[x ] I have commented my code, particularly in hard-to-understand areas.
[x ] My changes generates no new warnings.
[x ] I'm GWOC'21 contributor

Screenshots / Gif (Optional) 📸

/assign

This was my issue ,my pull request. How did you assigned your name as assigneee? This is wrong

@krupesh87 When can I get a report of your review on this PR? Can it be done in an hour? Else I am unassigning you and reviewing it myself.

@praveenscience how can it  be done in an hour? people are creating issues by themselves while issues should have been created by you. we are not getting issues at all. kindly look into it.

@krupesh87 I thought you wanted to "review" this "pull request", which took me just 10 mins! Are you kidding? 😅

So very congested here!!

Let the content breathe (Give proper space, heading , sub-heading, and so on).
Write code properly the way it's written in md , not  the simple text.

@VAISHNAVI0715 No updates or changes done.

No updates for a long time.
Close this PR, @praveenscience


Modifying avs-device-sdk SampleApp response to custom questions.

Hello,
Background:
I've installed avs-device-sdk [v1.2] on Raspberry Pi 3 Model B. I'm running SampleApp and using voice trigger to wake Alexa.
Aim:
User asks few questions specifically related to our project. As an example: "Change temperature" or "Change brightness" etc. I want Alexa to NOT respond back with speech output but instead print a message on the console whenever these custom questions have been asked.
Question:
As of now, by going through the documentation provided for speech recognizer and speech synthesizer audio information is converted to binary code. Is there a way to capture user's question? If so, can we stop streaming if it's a custom question to cloud and just print a reply on console? Please do provide a direction to modify the code.

Hi tkamaal,
Maybe you need to write an Alexa skill to handle these custom requests. The SDK forwards all requests to the Alexa AVS.

@jjamazon Thank you.

@jjamazon : We want to be able to control the GPIO of the RPi 3 board using AVS C/C++ SDK.
As an example:
"Alexa, turn on the fan."
And we want to be able to see one of the GPIO to be set High.
In order to do so, do we need to write an Alexa skill for that?

Hi @jayEmbedded,
That's correct.  The AVS client code is only concerned with basic voice interaction with the cloud service.  The interpretation of user speech and decision of how to respond to that speech is handled entirely in the cloud.  For your example, you would need to create a skill in the cloud which knows how to interpret your specific commands ("Alexa, tell MySkill to turn on the fan"), and then your skill would communicate with your hardware through a separate channel (direct connection, AWS IoT, etc) to send a command that turns the fan on.
Ken

@jayEmbedded - I'm going to close this issue as the original question has been answered.  Feel free to open a new issue if you have further questions.


Cold/Flu - Update content

AC

[ ] Update "Registration for the 2024 Flu Clinic Program is now open" to "Registration for the 2024 Influenza Worksite Clinic Registration is now open"

ready to test

Updated!

looks good

Live in Prod look perfect - closing tix


Update npm descriptions

Clarified something that tripped me up and noticed some of the docs were wrong.

Thank you!


Fix infinite loop in query iterator

wrapping_sub, as the name suggests, wraps around to the maximum value of usize. I intended to use saturating_sub, which stops when it hits 0. Very sorry about that.

Thanks for the fix! I did a version bump with it so it's available by default


Revert "Verify early OK behavior"

Reverts grpc/grpc#14687
These test are flaky internally, and will block future imports. We should revert

cc @nathanielmanistaatgoogle
Approving the PR to unblock imports.

Did you mean to approve this?

Sorry, approved.


[Map Pack] Cwl Maptestingpack Wk98

This isn't an Unreal Map Pack - all of the maps are for UT99.

URL: https://unrealarchive.org/mappacks/unreal/mixed/C/cwl-maptestingpack-wk98_f471fc54.html
Hash: f471fc5487f76100428fbdde353f99815cda6bdb
Current name: Cwl Maptestingpack Wk98

Fixed


Fix enclave_retrieve_key repeatability bug.

The local private key parameter was being cleared, so it couldn't be re-used in other key requests.

The code will allow for other key requests but it still has an issue with clean up of child processes.  The child processes are not being exited so they show up on the process list.


[SPARK-12327] Disable commented code lintr temporarily

cc @yhuai @felixcheung @shaneknapp

Test build #47688 has started for PR 10300 at commit 2523e65.

lgtm

Test build #47688 has finished for PR 10300 at commit 2523e65.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/47688/
Test PASSed.

Merging this in master and branch-1.6


occurrenceStatus

Should be extant (= present) for all taxa, asextinct will be removed (see #9). As this is a very simple mapping, the column occurrenceStatus should be removed from the spreadsheet.

If all regions have ? (e.g. Chenopodium album L. x probstii), should the occurrenceStatus be presence unknown?

This issue is a problem for the vocabulary we are suggesting, because if occurrenceStatus only refers to the date or date range in eventDate then there will never be a reason to use the occurrenceStatus of extinct. However, checklists frequently contain this information as it refers to the status at the time of publication.
Any suggestions on how best to handle this?

Ok, there are two questions here:

Your question: will there ever be a reason to use extinct and a date range? I would think so, as you can definitely say the dodo has been extinct since 1663. For species that are extinct in a certain region (e.g. wolfs in Belgium?), I think you can still use that. And, you might not always have date information, but still like to say something is extinct.

My question: how should I handle the occurrence status if all regions are ? or blank (see also #24)

To close this issue, some quick answers:

There are in fact species that are considered to be extinct in the manual. For these species, we use the date range between the last observation and today. See also #60 and #62

When all regions are ?, we keep the records and state that occurrenceStatus = presence uncertain for each region.

When all regions are blank, we exclude the records from the checklist.

See also https://github.com/trias-project/alien-plants-belgium/issues/45


Add Through The Fire and Flames by DragonForce

Song Name
Through The Fire and Flames
Artist Name
DragonForce
Source
Youtube
Youtube Link
DZyYapMZSec
Direct File Link
No response
Song ID
533927
Start Offset [ms]
No response
Extra
Created from Auto Nong.
Created for level: 73977718

reject
song has nothing to do with nine circles, which is too popular to serve as the replaced song


build(ci): add missing dependencies

Pull Request Test Coverage Report for Build 397119003

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 47.92%

Totals

Change from base Build 397006436:
0.0%

Covered Lines:
1348

Relevant Lines:
2813

💛  - Coveralls


[FR]: In the file ScrollbarExt.kt there is room for reducing the logic and code repeating in order to improve the reusability and maintainability

Is there an existing issue for this?

[X] I have searched the existing issues

Describe the problem
In the file ScrollbarExt.kt file there is room for reducing the logic and code repeating in order to improve the reusability and maintainability.
Moreover, this improvement will make it better for developers who use the nia sample to study, and learn ways to use Kotlin to increase resusability.
The scrollbarState extension function for the LazyListState, LazyGridState, LazyStaggeredGridState have a lot of common logic that could be unified.
Describe the solution
My suggestion is to unify into a more generic extension function:
<LazyState : ScrollableState, LazyStateItem> LazyState.genericScrollbarState
Additional context
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

Hi there,
I would like to contribute to Now In Android sample.
I've already developed such improvement, but I'm not able to upload it.
I've already signed the Google Individual CLA.
I can upload new PRs to my repositories, but for Now in Android it says to check if I have the correct access rights.
I am trying to upload the branch where I developed the improvement: scrollbarext-improvement
git push --set-upstream origin scrollbarext-improvement
This is the error I got:
ERROR: Permission to android/nowinandroid.git denied to rodrigodiasferreira.
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.`

Anyone can help me to check if I am doing something wrong?
Thanks.

Follow these steps.

Fork this repository into your repository.
Open 'your forked repository' on the Android Studio.
Edit your code, and push to your forked repository.
Make PR at this origin repository.

Hi @Jaehwa-Noh, thanks a lot for the tips.
I've just upload the PR: https://github.com/android/nowinandroid/pull/1550, I mentioned this issue on the PR, but maybe it should be linked through the development right side bar on this issue, but I don't have permission to do that.
I also do not have permission to self assign this issue to me.
It's my first contribution, so if there is any adjustment, or anything that I should improve, please let me know, I will do my best to conform to your standards.
Thanks!

I am closing this issue, as commented by @tunjid on PR: https://github.com/android/nowinandroid/pull/1550, the split of the functions and logic duplication was done on purpose, in order to improve readability.


"RECS0117 Local variable '' hides member ''" shouldn't consider classes to be "members"

The following code reports "RECS0117 Local variable 'entity' hides member 'entity'", even though entity is still referenceable as a type:
public class SomeClass
{
    public void Test()
    {
        var entity = 123;
        var x = new entity();
    }
}

public class entity
{
}

Thanks for reporting, should be fixed now.

Hey @Rpinski, I've just installed "Refactoring Essentials for Visual Studio 2017" v<IP_ADDRESS>  and it looks like this bug has returned.


docs(api): hide API reference entries for post-2.20 features

Overview
🤫 Hides 2.21 features from the 2.20 docs.
Test Plan and Hands on Testing
Sandbox
Things you shouldn't see:

RobotContext stuff
Future liquid level stuff

Changelog

:meta private: tags for ProtocolContext.robot and Well.meniscus
Bumped the required version for ProtocolContext.robot because it's not useful in 2.20.

Review requests
OK with the version change? It will still be 2.20 in the release branch. I can revert that line if we prefer.
Risk assessment
v low

Looks good as long as the test failure is understood.

I believe this is the hanging test fixed by #16317, so the squash commit should pass.


Ignore key inputs with modifier keys in media

This makes it possible to use browser search functions (Command-f or control-f) without accidentally toggling full-screen in the media viewer!

sounds good to me.


Provide access to Z/OS instance.

I am new to mainframes and would like to try out Zowe. However, I don't have access to any Z/OS machines. Please provide a way to try out Zowe.

From slack conversation with Joe winchester ,

....This is something we’ve got a fair few requests for so we need to start to think about how to do this, whether it’d be private sandbox instances using an emulator on cloud machines, or a shared instance that had Zowe pre-installed that folks could test drive.

Preferably, a private sandbox so that I may get to experiment with Z/OS environment too.

Do you want a pre-installed instance to use, and would you be OK with sharing one with other users or want a private one.  How long would you want this for.

Again, preinstalled with zowe but a private one. As for the duration, a month seems fine.

What other software would you want on the z/OS instance.

I think, it would be nice if Zowe is combined with the master the mainframe tutorials. Would allow newbies like me to explore the mainframe world better.

That is ok for people new to mainframe.  I have been for decades on mainframe but would like to convince colleagues, management to modernise z environment. Showing zowe in action without installation would be a great help. So one basic common system should be ok for me.

This todo is bigger than the ZLC.  I'm not sure what we can do apart from tracking the issue.  I believe this is different than the effort with VCU as that is all about CI/CD

Update website with a page directing people to resources for private instances.

Can we please review the attached proposal from MtM for a hands-on tutorial at the next ZLC meeting?
Zowe Hands-On Trial.pptx
This would be a temporary solution for people without access to z/OS to at least play around with the Zowe Web-UI.

@fbeyl we have made some progress, but the functionality is limited to the Web UI component. I have updated our website to provide a "Hands on Tutorial"... it is not a trial, as it is limited to the function described in the tutorial.

Link to the hands on tutorial is here: https://developer.ibm.com/tutorials/zowe-step-by-step-tutorial/

This issue is being worked at the OMP for all projects.  The ZLC will be working on this effort but not driving it.


debug console find causes tree to jump to bottom

have a debug console filled with output
search using ctrlCmd+alt+f
as you type input, the tree jumps and scrolls to the bottom

https://github.com/user-attachments/assets/58833f7a-470b-47c1-9294-1256b2a8e257

This is coming from the tree refilter which happens when the value changes
https://github.com/microsoft/vscode/pull/225300#issuecomment-2284329792

expected: didChange: false, unexpected: -333 height difference

no other users have reported this, thus closing


Page Control

Looking at the example, it looks quite easy to implement UIPageControl.  But when I use the same code in my own app, i don't see a PageControl.
Are there instructions for UIPageControl for BMPageViewController?

Nevermind, needed to set it to scroll instead of page curl...


Fix Dev chain balance values.

all explained in #2301.
Will probably either get merged as is, as a quick temp fix (after removing prints) or will be changed to in-progress for a while.

i guess this is ok for now, but i'd really like to implement multiplication/overflow properly rather than relying on mismatched sizes of votes & balances.

i guess this is ok for now, but i'd really like to implement multiplication/overflow properly rather than relying on mismatched sizes of votes & balances.

agreed but even if we had floating point numbers available (= no worrying about arithmetic), this issue would still be an option. They are related but not 100% the same thing.
The emphasis here is that if balances less than N bit are deemed to be dust, it should be indicated somewhere as a parameter because a module might depend on it. This is exactly the relationship between Staking and how polkadot implements balance in a way that 32 bits is dust.
I actually don't have a strong inclination to merge this as-is and prefer discussing it more first (was expecting a bit more feedback on the issue honestly). Maybe this new parameter should be stated somewhere else (e.g. in balances)?
But if we want a cleaner dev chain asap this can be merged and will not have much of an impact except one new parameter to Staking's genesis. The entire feature is also effectively disabled if the value is 0.

If we didn't need to worry about precision then we'd not bother shifting at all and that would all become moot.


#791 solved. Updated Upgrade to v5 Link

close #791
Updated the Upgrade to v5 Link

Closing as it is a duplicate of #741. We should instead merge #741.

Closing as it is a duplicate of #741. We should instead merge #741.


AWS::ElasticLoadBalancingV2::TargetGroup was added with https://github.com/spulec/moto/pull/1314

Judging from that output are you using the latest moto version?

I'm going to close as this seems to be working now. Test here
Feel free to reopen with code to reproduce if it isn't fixed.


Can't translate to pt-br

When trying to select pt-br listed on the googletrans doc's doesn't return anything.

I would add that the issue is NOT appearing while choosing other languages that require an hyphen such as Simplified Chinese or Traditional Chinese.


Fix introduced incompatibility for ConfigurableFormatting#message

For context https://github.com/rubocop-hq/rubocop/commit/51ff1d7e29c985732fe129082c98d66c531a2611#r43837211
@pirj @bbatsov
@marcandre maybe you have other ideas on how to implement that?

@marcandre maybe you have other ideas on how to implement that?

I have other ideas, but nothing as straightforward as that 👍

Thank you!
@pirj Thanks for the pragmatic feedback from RuboCop RSpec!


Construct span from a pair of iterators

The following code does not compile:
#include <vector>
#include <span>
#include <https://raw.githubusercontent.com/martinmoene/span-lite/master/include/nonstd/span.hpp>

#define s nonstd::span
// #define s std::span

void consume(s<int>);

int main () {
    std::vector a{1, 2, 3};

    consume(s(a.begin() + 1, a.end()));
}

"The following code does not compile" seems to hold for both std::span and nonstd::span, see this code at godbolt.

@slsyy can this issue be closed?


Cannot change themes after the update

Hello!
First of all thanks for this amazing fork.
I have updated to version 1.5.0 but now I can't change the themes. I was using Dark theme but now it comes directly with the White one and I cannot change it.

UDATE
I found it! You have to right click the icon in the task bar and from the Visual menu you can change it. Previously, it was with right clicking the chat itself.
Anyway, this issue is solved! :)

Yes I found that right click on chat should only be for Copy/Paste options :)

err, how could i change it in ubuntu @Sytten ? Right click not working anymore

What do you mean not working?

In ur previous ver, i still can right click to change theme, reload, autohide. But in current ver, right click show nothing. Dunno how to change theme anymore :-s

PaskoZhelev commented on Sep 1
UDATE
I found it! You have to right click the icon in the task bar and from the Visual menu you can change it. Previously, it was with right clicking the chat itself.
Anyway, this issue is solved! :)

i thought it's solution for windows =)))
ubuntu has no taskbar, bruh :-s

you can install a software to make it available again.
Ubuntu deprecated their, but alternative exists.
Beside dont use Unity, its crappy :D


think this syntax is right

It's only going to solve the problem for all.yml, but it won't automatically pick up other variables from group_vars I guess ?


[Release-1.27] - Support scanning k3s images with grype

Backport fix for Support scanning k3s images with grype

#8618

$ k3s -v
k3s version v1.27.10-rc2+k3s1 (ce6158f8)
go version go1.20.13

$ grype /usr/local/bin/k3s --add-cpes-if-none
 ✔ Vulnerability DB                [no update available]
 ✔ Indexed file system                                                                                /usr/local/bin
 ✔ Cataloged contents                                                                                9419923b825a8ad1631526c09d09137c230e42336ec8610ec2830c100feb55be
   └── ✔ Packages                        [32 packages]
 ✔ Scanned for vulnerabilities     [0 vulnerability matches]
   ├── by severity: 0 critical, 0 high, 0 medium, 0 low, 0 negligible
   └── by status:   0 fixed, 0 not-fixed, 0 ignored
No vulnerabilities found


1176 task release 1.20.0 for eventsBB

Description
Release 1.20.0.
Issue #1150 was not released in v 1.19.0. Added the event category update to v1.20.0. Only eventsBB changes are done. No other BB yaml file version is updated.
Fixes #1176
Review Time Estimate
Please give your idea of how soon this pull request needs to be reviewed by selecting one of the options below. This can be based on the criticality of the issue at hand and/or other relevant factors.

[ ] Immediately
[x] Within a week
[ ] When possible

Type of changes
Please select a relevant option:

[ ] Bug fix (non-breaking change which fixes an issue).
[ ] New feature (non-breaking change which adds functionality).
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected).
[x] Other (any another change that does not fall in one of the above categories.)

Checklist:
Please select all applicable options:

[ ] I have signed the Rokwire Contributor License Agreement (CLA). (Any contributor who is not an employee of the University of Illinois whose official duties include contributing to the Rokwire software, or who is not paid by the Rokwire project, needs to sign the CLA before their contribution can be accepted.)
[x] I have updated the CHANGELOG.
[ ] I have read the Contributor Guidelines.
[x] I have performed a self-review of my own code.
[ ] I have commented my code, particularly in hard-to-understand areas.
[ ] My change requires updating the documentation.
[ ] I have made necessary changes to the documentation.
[ ] I have added tests related to my changes.
[ ] My changes generate no new warnings.
[ ] New and existing unit tests pass locally with my changes.
[ ] Any dependent changes have been merged and published in downstream modules.

Tested in local. GET localhost:9000/events/categories responds with categories list and subcategories as expected.
[
    {
        "category": "Big 10 Athletics",
        "subcategories": [
            "Baseball",
            "Men's Basketball",
            "Men's Cross Country",
            "Football",
            "Men's Golf",
            "Men's Gymnastics",
            "Men's Tennis",
            "Men's Track Field",
            "Wrestling",
            "Women's Basketball",
            "Women's Cross Country",
            "Women's Golf",
            "Women's Gymnastics",
            "Women's Soccer",
            "Softball",
            "Swim Dive",
            "Women's Tennis",
            "Women's Track Field",
            "Volleyball"
        ]
    },
    {
        "category": "Campus Visits"
    },
    {
        "category": "Career Development"
    },
    {
        "category": "Ceremonies & Services"
    },
    {
        "category": "Club Athletics"
    },
    {
        "category": "Conferences & Workshops"
    },
    {
        "category": "Exhibits"
    },
    {
        "category": "Festivals & Celebrations"
    },
    {
        "category": "Film Screenings"
    },
    {
        "category": "Performances"
    },
    {
        "category": "Receptions & Open House Events"
    },
    {
        "category": "Recreation, Health & Fitness",
        "subcategories": [
            "Group Fitness",
            "Aquatics",
            "Ice Skating",
            "Personal Training",
            "Student Wellness",
            "Adventure Rec",
            "Summer Camp"
        ]
    },
    {
        "category": "Social & Informal Events"
    },
    {
        "category": "Speakers & Seminars"
    }
]

Ready for review.

Proceeding with dev deployment

Thanks, @minump.
@bingzhang, Could you please test the below request in the DEV instance?
http://api-dev.rokwire.illinois.edu/events?startDate.lte=2023-09-12T14:19:02&endDate.gte=2023-09-06T14:19:02&targetAudience=faculty&targetAudience=staff&category=Receptions%20&%20Open%20House%20Events

The primary thing to test is the categories part -> category=Receptions%20&%20Open%20House%20Events
I think there should be some events under this category, but 0 are being returned. Please test this locally by changing some event data (if needed). This and other similar requests with ampersand in category need to succeed to be backward compatible with Illinois app 4.0. Thanks.

Thanks, @minump.
@bingzhang, Could you please test the below request in the DEV instance?
http://api-dev.rokwire.illinois.edu/events?startDate.lte=2023-09-12T14:19:02&endDate.gte=2023-09-06T14:19:02&targetAudience=faculty&targetAudience=staff&category=Receptions%20&%20Open%20House%20Events

The primary thing to test is the categories part -> category=Receptions%20&%20Open%20House%20Events
I think there should be some events under this category, but 0 are being returned. Please test this locally by changing some event data (if needed). This and other similar requests with ampersand in category need to succeed to be backward compatible with Illinois app 4.0. Thanks.

this request has wrong url encoding. there is &. If you use the below one it works.
Receptions%20%26%20Open%20House%20Events

Tested in local.
curl --location 'http://localhost:9000/events?category=Recreation%2C%20Health%20%26%20Fitness' \
--header 'ROKWIRE-API-KEY: key'

gives expected response.

Merging PR.
Will proceed with release deployment to dev and request for deployment to TEST and PROD.


[FEATURE] Bitcart payment gateway

Support  bitcart as a payment gateway.
This is one of the best solutions for accepting payments in cryptocurrency.

I did it myself, so it’s no longer relevant - PaymenterBitcart


[Network] Add flow log format to NSG flow logs

Close #7524.

This checklist is used to make sure that common guidelines for a pull request are followed.

[X] The PR has modified HISTORY.rst describing any customer-facing, functional changes. Note that this does not include changes only to help content. (see Modifying change log).

[X] I adhere to the Command Guidelines.

@yugangw-msft ping


Move cookie button

Try and use .css to force the cookie option icon so it's not overlapping the nav buttons

moved the cookie button into the footer so it's not in the way of other functionality


Missing clusterrole prometheus-k8s permissions

Bug description
Without the next permissions we cannot node-problem-detector or kubelet-stats-exporter
- apiGroups:
  - ""
  resources:
  - services
  - pods
  - endpoints
  verbs:
  - get

What's the procedure to add this permissions?
Steps to reproduce

Expected behavior
No response
Example repository
No response
Anything else?
No response

:wave: @meysholdt , is this something that y'all can help with this week?
Without having the above permissions, some dashboards are don't work.
We can manually add the cluster role as a workaround, but, it would be ideal for the permissions to be added as part of the monitoring-satellite installation.


Sanitizes code reviews README and adds information about metrics

Moves guidance solely focused on how to create PRs into its own file
Sanitizes and restructures README.md
Adds information on code reviews metrics
Adds useful resources

Fixes issues #168 and #120.

I noticed that this PR was closed and reopened fresh without the context of old comments and conversations. I am wondering if this is best practice as you might be losing some context and having to switch back and forth to figure if something changed but it also keeps the review clean in terms of changes.
Also, should we add something about it in the playbook? Like when to start fresh?

I noticed that this PR was closed and reopened fresh without the context of old comments and conversations. I am wondering if this is best practice as you might be losing some context and having to switch back and forth to figure if something changed but it also keeps the review clean in terms of changes.
Also, should we add something about it in the playbook? Like when to start fresh?

There was a ghost filename conflict (due to case change in a filename) that would've been possibly to resolve, but I felt this was a cleaner solution. No history will be lost due to starting fresh.


Suggest including Azure NetApp Files in this page

[Enter feedback here]
Hi I'm Penny Ko in MSFT.
I noticed ANF wasn't being mentioned here, suggest including ANF in this page.
ANF document team member<EMAIL_ADDRESS>
Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 2550031e-4cf6-8d15-84e3-1c2b58951f80
Version Independent ID: 1a927119-0540-dfd9-9435-5c29c014daff
Content: Introduction to Azure Storage - Cloud storage on Azure
Content Source: articles/storage/common/storage-introduction.md
Service: storage
Sub-service: common
GitHub Login: @tamram
Microsoft Alias: tamram

@pinyuko Thanks for the question! We are investigating and will update you shortly.

@pinyuko Can you provide more information, what data needs to be added.
We have article which provides deatiled information based on the customer scenario https://docs.microsoft.com/en-us/azure/cloud-adoption-framework/ready/considerations/storage-options

@pinyuko Since we have not heard back from you we will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply. We will gladly reopen the issue and continue the discussion.

Hi @SumanthMarigowda ,
Apologize for late reply. Thanks for providing the CAF doc, I'm aware of that. I think it's still different for having introduction in Azure Storage doc https://docs.microsoft.com/en-us/azure/storage/common/storage-introduction and in CAF doc.
Also, for the CAF document https://docs.microsoft.com/en-us/azure/cloud-adoption-framework/ready/considerations/storage-options , I would suggest to add Azure NetApp Files too to "I have an SAP or SAP HANA deployment."  and "I have a relational database or data warehouse workload, such as SQL Server or Oracle."
Reference for SAP Storage options: (Doc written by SAP PG) https://docs.microsoft.com/en-us/azure/virtual-machines/workloads/sap/planning-guide-storage#azure-netapp-files-anf
Reference for Oracle: https://docs.microsoft.com/en-us/azure/azure-netapp-files/solutions-benefits-azure-netapp-files-oracle-database

Hi @SumanthMarigowda @pinyuko Your observation is correct, Azure NetApp Files should be mentioned in CAF and WAF and additional choices for SAP and HANA should point to Azure NetApp Files as well. This is work in progress and may take some time to publish.


Manifest and Template Details

"Modern Web" requires some basic details to be present in the HTML formatting.
This is a simple fix, but it should help the site look better overall.
Look at lighthouse to learn more about auditing other projects

Thank you!!!!


Codify the creation of test containers

Not ready for review.
Meant as a starting point to address:
https://github.com/kata-containers/kata-containers/issues/9360
Open topics for this draft:

The ssh-demo is here and here. This PR codifies/automates parts of that. We should probably update those places with at least a pointer to this new infra code, right?
We are checking in keys. How are those keys made? Some notes that I made while doing this are incorporated into the PR as a README. Is this the best place for that?

Hi, here are the code changes for building and pushing multi-arch images:
diff --git a/.github/workflows/build-test-containers.yaml b/.github/workflows/build-test-containers.yaml
index 16474c0..e1d8a1a 100644
--- a/.github/workflows/build-test-containers.yaml
+++ b/.github/workflows/build-test-containers.yaml
@@ -13,6 +13,12 @@ jobs:
     steps:
       - name: Checkout
         uses: actions/checkout@v4
+
+      - name: Set up QEMU
+        uses: docker/setup-qemu-action@v3
+      - name: Set up Docker Buildx
+        uses: docker/setup-buildx-action@v3
+
       - name: Check out guest-components
         uses: actions/checkout@v4
         with:
@@ -55,4 +61,6 @@ jobs:
               fi
           done
           echo "coco-keyprovider is ready"
+          docker buildx create --name mybuilder --use
+          docker buildx inspect mybuilder --bootstrap
           make all
diff --git a/container-images/Makefile b/container-images/Makefile
index fb0b10b..2b1f089 100644
--- a/container-images/Makefile
+++ b/container-images/Makefile
@@ -19,6 +19,22 @@ busybox

 SHELL=/bin/bash

+PLATFORMS := linux/amd64 linux/s390x
+
+define build_and_push_image
+       @for platform in $(PLATFORMS); do \
+               image_name="$(1)"; \
+               if [ "$$platform" = "linux/s390x" ]; then \
+                       image_name="$(1)-s390x"; \
+               fi; \
+               echo "Building for $$platform with image name $$image_name..."; \
+               docker buildx build \
+                 -t $$image_name \
+                 -f $(2) \
+                 --platform $$platform --provenance=false --load $(3); \
+               docker push $$image_name; \
+       done
+endef

 # FIXME need to choose sane package URLs/names/tags
 COCO_PKG=bbolroc/test-container
@@ -39,19 +55,11 @@ all: \

 unsig:
-       docker build \
-         -t ghcr.io/$(COCO_PKG):unsig \
-         -f dockerfiles/alpine-with-sshd/Dockerfile \
-         .
-       docker push ghcr.io/$(COCO_PKG):unsig
+       $(call build_and_push_image,ghcr.io/$(COCO_PKG):unsig,dockerfiles/alpine-with-sshd/Dockerfile,.)

 cosign-sig:
-       docker build \
-         -t ghcr.io/$(COCO_PKG):cosign-sig \
-         -f dockerfiles/alpine-with-sshd/Dockerfile \
-         .
-       docker push ghcr.io/$(COCO_PKG):cosign-sig
+       $(call build_and_push_image,ghcr.io/$(COCO_PKG):cosign-sig,dockerfiles/alpine-with-sshd/Dockerfile,.)
        # FIXME Replace expect script with something better
        ${CURDIR}/scripts/make-cosign-sig.exp $(COCO_PKG) cosign-sig

@@ -96,11 +104,7 @@ enc-cosign-sig: cosign-sig

 test-container-unencrypted:
-       docker build \
-         -t ghcr.io/$(COCO_PKG):unencrypted \
-         -f dockerfiles/alpine-with-sshd/Dockerfile \
-         .
-       docker push ghcr.io/$(COCO_PKG):unencrypted
+       $(call build_and_push_image,ghcr.io/$(COCO_PKG):unencrypted,dockerfiles/alpine-with-sshd/Dockerfile,.)

 # NOTE: see enc-unsig about coco-keyprovider
@@ -114,5 +118,4 @@ test-container-encrypted: test-container-unencrypted

 busybox:
-       docker build -t ghcr.io/$(COCO_PKG_IMGRS):busybox dockerfiles/busybox
-       docker push ghcr.io/$(COCO_PKG_IMGRS):busybox
+       $(call build_and_push_image,ghcr.io/$(COCO_PKG_IMGRS):busybox,dockerfiles/busybox/Dockerfile,dockerfiles/busybox)

The workflow has been verified at https://github.com/BbolroC/coco-infra/actions/runs/11611183620/job/32331994493
Feel free to make changes as needed. Thanks!

Oh, I have realized that I missed building a s390x rust binary. I will update that part soon. Thanks!


normalize

Is this method correct? One give it tuple of 3 floats ant it round it and return as int? Round if i am correct means 5.4 = 5 and 5.5=6 and 5.8=6. Is that correct? If yes i am repairing that test
def normalize(position):     x, y, z = position     x, y, z = (int(round(x)), int(round(y)), int(round(z)))     return x, y, z

If anyone is googling this error, it's because we only support python > 3.4


Black Delay screen when navigating to a specific page

Thank you sir, am very grateful for this package.

Whenever I accept an incoming call when navigating to a new page it first relaunch the app by showing black Delay screen before navigating to that specific screen

https://user-images.githubusercontent.com/10984801/163981542-8635d8d2-1e67-4737-a8ed-5a2ce5e77d25.mp4

When device is on lock screen and I accept an incoming call, it does not take me to the specific page, it just relaunch the app

https://user-images.githubusercontent.com/10984801/163983315-373581a8-5cd8-4777-aaa5-1ff7bc801351.mp4

When app is on Background and I received an incoming call, it just relaunch the app, it does not take me to the specific page as well

When app is not amongst the recent open apps, when I accept an incoming call, it relaunch the app again

Am using the package latest version +7

hello @zionnite want to know how i solved this?
I did a shared pref. save in case CallEvent.ACTION_CALL_ACCEPT: (you can never navigate here, not in a 100 years)
Once i pick the call the app saves my shared pref (with all the call event data) and does a reload (as u said) right?
The next thing is that your first screen will show after the reload (lets say your splash screen).
In my splash screen (first screen), inside the initState() method, i check the shared pref. for the call data if returns null it means no call, i can proceed with life normally.
if its not null then the screen is launched as a result of a call, hence i can navigate the user to the audio or video call screen as i have saved the call data in my shared pref.
This is more of a flow thing NOT some complex programming as you would have thought.
(onDispose and onEndCall of your call page, always clear the call shared pref. to avoid it intercepting your first screen)

i will check the issue relaunch. maybe it's me

hello @zionnite and @hiennguyen92 want to know how i solved this?
I did a shared pref. save in case CallEvent.ACTION_CALL_ACCEPT: (you can never navigate here, not in a 100 years)
Once i pick the call the app saves my shared pref (with all the call event data) and does a reload (as u said) right?
The next thing is that your first screen will show after the reload (lets say your splash screen).
In my splash screen (first screen), inside the initState() method, i check the shared pref. for the call data if returns null it means no call, i can proceed with life normally.
if its not null then the screen is launched as a result of a call, hence i can navigate the user to the audio or video call screen as i have saved the call data in my shared pref.
This is more of a flow thing NOT some complex programming as you would have thought.
(onDispose and onEndCall of your call page, always clear the call shared pref. to avoid it always intercepting your first screen)

have done something similar before posting this question, am not using shared pref. am using firebase snapshot with stream builder to detect the behavior of where to navigate to but yet issue persists.
thanks for your warm response.

I had similar issue too.

@hiennguyen92
it's of joyful heart I write this statement Mr @hiennguyen92 , everything I needed your package for has been accomplished but the issue I have right now is those highlighted above.
and I Yet highlight them again

Whenever I accept an incoming call when navigating to a new page it first relaunches the app by showing a black Delay screen before navigating to that specific screen

When the device is on the lock screen and I accept an incoming call, it does not take me to the specific page, it just relaunches the app

When app is in the Background and I received an incoming call, it just relaunches the app, it does not take me to the specific page as well

When the app is not among the recent open apps when I accept an incoming call, it relaunches the app again

I Am using the package's latest version +7

Temporarily  downgrade to version : flutter_callkit_incoming: 1.0.1+6 solved my problem hope this can help you

Temporarily  downgrade to version : flutter_callkit_incoming: 1.0.1+6 solved my problem hope this can help you

Thanks for quick reply.
I thought version 1.0.1+6 has some bugs like duplication of incoming calls?
Please, what's the downside you are experiencing with 1.0.1+6??

Temporarily downgrade to version : flutter_callkit_incoming: 1.0.1+6 solved my problem hope this can help you

just tried 1.0.1+6??, it did not work
@hiennguyen92 have u taken a look into this?

Temporarily downgrade to version : flutter_callkit_incoming: 1.0.1+6 solved my problem hope this can help you

just tried 1.0.1+6??, it did not work
@hiennguyen92 have u taken a look into this?

Make sure you are on 1.0.1+6
I check it from here : flutter pub outdated
if your version is still on 1.0.1+7 you have to delete ^ from your version number.

just did that unfortunately it did not work for me
On Mon, Apr 25, 2022 at 8:23 AM WilliandyMTMH @.***>
wrote:

Temporarily downgrade to version : flutter_callkit_incoming: 1.0.1+6
solved my problem hope this can help you
just tried 1.0.1+6??, it did not work
@hiennguyen92 https://github.com/hiennguyen92 have u taken a look into
this?
Make sure you are on 1.0.1+6
I check it from here : flutter pub outdated
if your version is still on 1.0.1+7 you have to delete ^ from your version
number.
—
Reply to this email directly, view it on GitHub
https://github.com/hiennguyen92/flutter_callkit_incoming/issues/93#issuecomment-1108172746,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACTZ2YKTPBTBNXY4HC2BRILVGZB5HANCNFSM5TYMICOQ
.
You are receiving this because you were mentioned.Message ID:
@.***>

Sorry. I will check it

flutter pub outdated

I've downgraded it, and the app still restarts

flutter pub outdated

I've downgraded it, and the app still restarts

Me too

hello @zionnite and @hiennguyen92 want to know how i solved this?
I did a shared pref. save in case CallEvent.ACTION_CALL_ACCEPT: (you can never navigate here, not in a 100 years)
Once i pick the call the app saves my shared pref (with all the call event data) and does a reload (as u said) right?
The next thing is that your first screen will show after the reload (lets say your splash screen).
In my splash screen (first screen), inside the initState() method, i check the shared pref. for the call data if returns null it means no call, i can proceed with life normally.
if its not null then the screen is launched as a result of a call, hence i can navigate the user to the audio or video call screen as i have saved the call data in my shared pref.
This is more of a flow thing NOT some complex programming as you would have thought.
(onDispose and onEndCall of your call page, always clear the call shared pref. to avoid it always intercepting your first screen)

the problem is  not with splash screen , before splash screen there's a black screen for flutter before launching app , i have no splash screen in my app even though routing causes relaunching app , and routing is done in widgets binding post frame call back and  not in  CallEvent.ACTION_CALL_ACCEPT:`

still facing issue with routing , any fix available? please help

@hiennguyen92 😭😭😭😭

can you use version master branch for check?

can you use version master branch for check?

please, how do I do that

flutter_callkit_incoming:
git:
url: git@github.com:hiennguyen92/flutter_callkit_incoming.git
ref: master

I just published v1.0.1+8, please check again.

new version v1.0.1+8, it's working no restart anymore, thank @hiennguyen92
but now ringtone, do we have to setup a parameter to activate the ringtone?

@hiennguyen92 thanks alot for the support, this is appriciated.
The latest versionflutter_callkit_incoming: ^1.0.1+8 is not working on Android OS but works on IOS, I think its a gradle compatibility issue as stated below:
issue https://github.com/hiennguyen92/flutter_callkit_incoming/issues/102
Thanks Again!

@Condelab i facing the same issue, but i just delete package cache from previous version and do flutter clean, and it's working fine in android

I just published v1.0.1+8, please check again.

@hiennguyen92 this is the only package was stable till previous version with small problems, and thank you for this package , since the latest update ,

app is crashing on receiving the call accept (checked in vivo, oneplus, redmi, samsung phones)
call is not accepted when clicked and tapping two three times somewhat opens the app
black screen is gone in debug mode , but app needs restart to route to the specific page , and all was fine working in previous version in profile mode (no crashing , routing properly ,).
receiving 2 call popup for a single call.
all routing doesn't working in debug and profile mode

https://github.com/hiennguyen92/flutter_callkit_incoming/blob/542c69ba4b956141423352f2fc885ff2eae08c58/example/lib/main.dart#L70
please with WidgetsBindingObserver

@hiennguyen92  tried every thing , app crashes , I already mensioned details in top comment please check .

I just published v1.0.1+8, please check again.

It's working perfectly.
Bravo for this fixed.

But sir, when app is killed or terminated, push notifications does not display.
How can this be resolved?

@hiennguyen92 thanks alot for the support, this is appriciated.
The latest versionflutter_callkit_incoming: ^1.0.1+8 is not working on Android OS but works on IOS, I think its a gradle compatibility issue as stated below:
issue https://github.com/hiennguyen92/flutter_callkit_incoming/issues/102
Thanks Again!

@Condelab check again, it's working perfectly for me

But sir, when app is killed or terminated, incoming call does not display.
How can this be resolved?

@hiennguyen92

@zionnite Please make sure to receive notifications. it working fine for me both android/iOS

@zionnite Please make sure to receive notifications. it working fine for me both android/iOS

Let me double check again

you can try new version 1.0.2(check example)).

Foreground it's working perfectly
Background it's working perfectly
No more relaunch
But when app is terminated or killed incoming call do not show.?
It's this beyond the scope of this package?

you can try restarting the device.  There is some reason some VoIP or FCM push won't be received

you can try restarting the device. There is some reason some VoIP or FCM push won't be received

@hiennguyen92 , I have checked, doubled checked, and triple checked
once app is killed or remove from recent app, it does not get any incoming notification

I think this is beyond the scope of this issue, and the issue in this thread has been fixed, you should create a new issue


Words in  not appearing.

Words in angled brackets don't appear in the reader, seems like a html thing? If theres a way to turn this feature off I'd love to know :)

This was fixed in v1.1.16.
If the issue still persists open another issue and follow the issue template.


File "/usr/local/lib/python2.7/site-packages/macaca/webdriver.py", line 697     *, asserter=lambda x: x)

File "macaca-desktop-sample.test.py", line 3, in
from macaca import WebDriver
File "/usr/local/lib/python2.7/site-packages/macaca/init.py", line 25, in
from .webdriver import WebDriver
File "/usr/local/lib/python2.7/site-packages/macaca/webdriver.py", line 697
*, asserter=lambda x: x):

装个 Python 3.4, python 2 不支持 keyword-only 参数。


NC-Negate offset when ZIP_SOURCE_SEEK from SEEK_END

Intending to fix issue #69
custom_zip_source_callback from the zip library where the cmd is ZIP_SOURCE_SEEK and whence is SEEK_END specifies a negative offset.  pImportStream takes an unsigned positive value to indicate the distance to seek back.  The value must be negated between the two APIs.

I see now that this is a bit more complicated as the implementations used by COM and the unit tests cast this value back to a signed value without conversion.
This feels like a problem with the API passing signed values around like they are unsigned.  This works for some conversions, but is not safe as I already ran into a problem with my implementation turning the negative values into large positive values due to the implicit type conversion in the math.

Thanks for your contribution, @kokuda !


点选开关按钮无效

点击不了，没反应

Issue not in english will be autoclosed.

Some of the toggles can't be clicked. I don't need them myself, but I came here to thank you for making this awesome plugin - well done.

Yeah, it's normal!
I updated the plugin to indicate why they can't be enabled.
It must follow some condition, aka the existance of a regex groups like (.*) for example. I set a link in the settings to help.


More configuration options

Describe the solution you'd like
I was wondering if it would be possible to add a few more variables to the defaults -> main.yml file on the Zabbix_Agent role?  I was thinking that it would be great to be able to specify the hostname, hostmetadata, hostmetadataitem, and timeout options.
Describe alternatives you've considered
I have been using a shell script to deploy Zabbix agents and edit the config until now, so using different modules to manipulate lines in the zabbix_agent.conf isn’t an issue.  However it would be great to be able to specify a few more items using your role.
Additional context
This report came in on the mail by Christopher Hale. Thanks for that!

Thanks for generating this for me.  Here are all of the additional options I set during install with my shell script.  I incorrectly listed HostMetaDataItem and left out the remote commands options.
Hostname
HostMetadata
Timeout
EnableRemoteCommands
LogRemoteCommands

Just tested the new options.  I've confirmed that it's working on two test boxes, running Ubuntu 18.04 LTS.

Cool, I'll release a version in a moment.

Release is done, I'll close this issue, thanks a lot for helping @chaleyeah!


Fix Utils.joinURLs on Windows

This PR fixes an issue where spark-redshift would not work properly on Windows because the Utils.joinUrls method implicitly used the platform-specific path separator via File.

Current coverage is 94.81%

Merging #93 into master will decrease coverage by -0.03% as of dfc171c

@@            master     #93   diff @@
======================================
  Files           11      11
  Stmts          446     444     -2
  Branches       109     109
  Methods          0       0
======================================
- Hit            423     421     -2
  Partial          0       0
  Missed          23      23

Review entire Coverage Diff as of dfc171c

Powered by Codecov. Updated on successful CI builds.

Going to merge this now.


garden-of-coloured-lights: add -fcommon workaround

Workaround build failure on -fno-common toolchains like upstream
gcc-10. Otherwise build fails as:
ld: main.o:src/main.c:58: multiple definition of
  `eclass'; eclass.o:src/eclass.c:21: first defined here

Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 177089 run on x86_64-linux 1

1 package built:

garden-of-coloured-lights


Adding the Loom base modules with empty files.

Progress in #2928

Proposed Changes

Added both loom-based modules with Java 19 as the latest Maven shade plugin does not support Java20 till now.
Lower the Java version to 19 in tests as Every version has its exact preview feature and does not work in other versions.
Updates in latter comment

Removed the shade plugin as it is not needed at least for now. and use docker.io/library/eclipse-temurin:20-jre

@pierDipi It's ready to review.

/retest-required

/retest-required


Update to newest version broken

Microsoft PowerToys version
0.57.2
Running as admin

[X] Yes

Area(s) with issue?
Installer
Steps to reproduce
Run update from prompt or installer from Releases
✔ Expected Behavior
Update installs
❌ Actual Behavior

powertoys-bootstrapper-msi-0.62.0_20220908005955.log
Other Software
No response

Use source field:
C:\ProgramData\Package Cache\{FA34C80E-34B4-4747-94DA-D2AB8BFDC612}v0.56.1\

Hi @alucard87pl , if you need an old msi to be able to uninstall, please check out: https://docs.microsoft.com/en-us/windows/powertoys/install#extracting-the-msi-from-the-bundle
It's likely your computer deleted the msi from its cached location.
I hope this helps. /needinfo


Implemented Daily Demand dataset

This is a time series dataset on Daily Demands of a Logistic Company in Brazil.
Implementing this to the pattern of the Iris dataset as a sample of what to do.

@programmer290399 Hey, about this one, this PR was aimed at implementing the Daily Demand Dataset... I was having problems with branching in my fork, so it somehow got merged with my next PR #1363, and by the time I noticed I had already cited it in my GSoC proposal. Please deal with this appropriately.
Thanks

You can cherrypick the commits you need and leave the rest.


Input with dolby vision, HDR 10 compatibility not preserved

I'm not sure if this is a problem with ffmpeg, other-transcode, or just a loose nut behind the keyboard, but here goes...
(also this HDR stuff is really confusing, so apologies if I'm not using the right terminology or maybe even having the wrong understanding of it all)
I have some UHD h.265 sources with Dolby Vision profiles and an HDR 10 compatibility layer (I think this is the right terminology). As I understand it the HDR 10 compatibility is important as a fallback for when DoVI (what I've seen dolby vision called?) isn't supported the video can still render properly
I need to re-encode the sources for size, and I think what I'm seeing is after transcoding with other-transcode, only the DoVI remains, but the HDR 10 compatibility wasn't preserved. This of course results in mostly unusable videos. If the viewing device doesn't support Dolby Vision, either:
(1) Plex tries to transcode but fails, complaining about an incompatible color space, or
(2) Plex allows the client to direct play, but the color is all out of whack
If I just load the source video into Plex, it plays & transcodes fine
Is there an option to either other-transcode or to ffmpeg to handle this correctly?
Happy to share samples if it helps
Also: thank you so much for this project. I've been using it and video_transcoding for years

@zcutlip My apologies for taking so long to respond to this.
Can you give me more information about the original input and then about the problematic output? Please attach MediaInfo output for both files to this issue. Also attaching the .log file generated during transcoding will help.
Thanks.

My apologies for taking so long to respond to this

No apologies necessary for responding to my question about your completely unpaid project ;-)
Sadly (or fortunately?), I can no longer reproduce. Before I thought to file an issue I'd already deleted and required the source, and now it seems to encode properly, preserving the HDR 10 compatibility layer.
I suppose I'll chalk this up to a bad source originally. If I come across another where Plex can handle the input but not the resulting output, I'll open another issue


Planning firestore-one-to-many extension 🧠

Implements the one-to-many relationship between Firestore collections.
Params 🛠
Target Collection Path
The path to the collation containing the documents represents the first side of the relation, the "one" side.
Example: authors
Destination Collection Path
The path to the collation containing the documents represents the second side of the relation, the "many" side.
Example: books
Target Ref Field Name
The name of the field in the destination collection that contains the reference of the document in the target collection.
Example: authorId
Destination Ref Field Name
The name of the field in the target collection where the id of the destination document will be stored.
Example: bookId
Default: id
Target Data Field Name
The name of the field in the target document where the list of the destination documents will be stored.
Example: books
Destination Data Field Name
The name of the field in the destination document where the data from the target document will be stored.
Example: author
Fields to copy from the target collection
A comma-separated list of field names to copy from the target collection to the destination collection.
Example: name,biography
Fields to copy from the destination collection
A comma-separated list of field names to copy from the destination collection to the target collection.
Example: title,summary
Target document deletion behaviour
What should happen to the documents in the destination collection when a related target collection is deleted?

Hey! I think I was able to add this features to my project - would you like to check my code and take a look if you could use it?


Stable Tagged version available on bower

Thanks for this great module.
I experienced the same problem as https://github.com/AllanBishop/angular-img-cropper/issues/26
So I tried the master version (following the README) which doesn't seem to work : "$ is not defined".
Then I replaced $ by angular.element but I can't use resize and move controls : http://jsbin.com/muququbowo/edit?html,js,output
Do I do something wrong ?
Can anyone fix and make a stable tagged release on bower ?
Thanks

have u got any solution..??

I finaly use a modified version from 1.1.0, with a new crop object generated for each update of the source image :
`            angular.element(document).ready(function () {
            scope.$watch('image', function (newValue) {
                if (newValue != null) {

                    var el = angular.element(element[0]);
                    var canvas = el[0];
                    var width = scope.cropWidth;
                    var height = scope.cropHeight;
                    var keepAspect = scope.keepAspect;
                    var touchRadius = scope.touchRadius;
                    crop = new ImageCropper(canvas, canvas.width / 2 - width / 2, canvas.height / 2 - height / 2, width, height, keepAspect, touchRadius);

                    var imageObj = new Image();
                    imageObj.addEventListener("load", function () {

                        crop.setImage(imageObj);
                        var img = crop.getCroppedImage(scope.cropWidth, scope.cropHeight);
                        scope.croppedImage = img.src;
                        scope.$apply();
                    }, false);
                    imageObj.src = newValue;
                }
            }
        );`


Error 'could not retrieve ScriptResult' when calling contract on Beta-3 testnet

I'm running a script to initialize many smart contracts, at random points in the deployment it will produce this error:
'panicked at 'could not retrieve ScriptResult''
Since I need to initialize 8 contracts, running it a few times with the hopes that it doesn't randomly produce this issue is not an option. I can successfully deploy/upload the contracts, only when it's time to call the initialize function on them does it break. I am using Beta-3 Fuel testnet on this script, but I also have local tests that never break when running the same code
I believe this is an error with Beta-3 either timing out, or bugging out after successive smart contract calls (though I have await statements wrapping the calls)

Hey, can you please provide a code example if it's not too hard? After checking, I do think it's a problem with the client rather than the SDK, but some code would help to make sure of that.

Upgraded packages, and no longer an issue

Jk it's back
`let tx_params = TxParameters::default().set_gas_price(1);
    let res = manager
        .methods()
        .initialize(admin)
        .tx_params(tx_params)
        .call()
        .await
        .unwrap();

    return res;`

it basically break in these initialization contract calls when going through beta-3

We're looking into this. The most likely culprit is, as I said before, the client's response, that would IMO not contain the receipts the SDK expects to.

@diyahir As @iqdecay mentioned before, could you please provide a minimal reproducible example for me?


High cpu comsuming cause gitea very slow

Gitea version (or commit ref): 1.13.2
Git version: <IP_ADDRESS>
Operating system:

Database (use [x]):

[ ] PostgreSQL
[x] MySQL
[ ] MSSQL
[ ] SQLite

Can you reproduce the bug at https://try.gitea.io:

[ ] Yes (provide example URL)
[x] No

Log gist:

Description

...
I don't know what action will be causing this problem yet. But it happened frequently.
Screenshots

The cpu high usage will last for tens of minutes.

I found some related issue. https://github.com/go-gitea/gitea/issues/9642

Please update - this is likely fixed by #14649 which is in 1.13.3

The latest point release for 1.13 is 1.13.6 - you should always try the latest point release.

Thank you.
I will try the latest stable version to see if the problem remains.

Closing, please re-open if it remains.

Please re-open this issue, because after upgrade to 1.13.6 the problem remains.

tree model

@techknowlogick

what should i do?

I am pretty sure that merge pr will cause this problem, although this pr is very small.

The PR may be small, but does that repo have a long history (i.e. > 10.000 commits)?

The PR may be small, but does that repo have a long history (i.e. > 10.000 commits)?

It is very fast if I merge the branch in the local.

I think pprof would be useful here:
[server]
ENABLE_PPROF = true

Just before the slow merge please start:
wget -O cpuprofile.out http://localhost:6060/debug/pprof/profile?seconds=60
Then do the merge and either attach the profile here or talk to me on discord.
I will need to know what version of gitea you are running exactly.

cpuprofile.zip

gitea.0330.log
merge action happend at 2021-03-30 14:35:38

@zeripath Can you analyze this problem for me? thank you very much!

OK you've only sent me the xorm logs which are the least useful logs. Please read: https://docs.gitea.io/en-us/logging-configuration/#debugging-problems.
And the profile doesn't actually contain all of the merge - however, it probably does show where the inefficiency is:
43% of the time in that profile is spent in https://github.com/go-gitea/gitea/blob/6dfa92bb1ca97d4e93e07dd5c289a8035761d89c/modules/git/repo_language_stats.go#L23-L91
In particular 27.3% (3.46s) is spent in go-enry.IsVendor:
// IsVendor returns whether or not path is a vendor path.
func IsVendor(path string) bool {
	return matchRegexSlice(data.VendorMatchers, path)
}

Which is remarkably inefficiently written because it simply iterates over a list of regexps checking each one in turn without combining the regexps in to a single regexp.
There are a number of other inefficiencies that this flame graph identifies but I think this is a particularly glaring issue.

@81519434 would it be possible to for you give us a profile file for this push on 1.14-rc2 and master?
(I think at least a few things should have been improved even without the isvendor pr I've proposed above but it would be good to know for sure.)

We can see git rev-list is the reason why CPU keeps high consumption from the htop.
Is that mean gitea incorrectly triggered the git command line?
If it is like this, I think that pprof will not find the cause. Because git command line is not managed by go.
Of course, I am not familiar with go. This is all my guess.

What happens if you create a new repo on the same server, push the original data and open the same pull request? Your git directory (on the server) might be damaged if git itself is very slow.
More recent versions of git also contain speedups to the mentioned functions, but it should be a fast operation anyway.

I will try to upgrade the latest git client verstion, and see if the problem remains.

@0000005 Has the problem been resolved? Since Gitea 1.16 is coming and a lot of code was changed(improved), I think we can close this one. If there is any performance problem, we can continue to improve on 1.16


chore(translations): Add missing i18n

SUMMARY
This PR adds the missing *.ts to babel.cfg, so messages in typescript files get extracted.
Addditionally, a few missing i18n calls are added and the pot file updated.
ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Required feature flags:
[ ] Changes UI
[ ] Includes DB Migration (follow approval process in SIP-59)

[ ] Migration is atomic, supports rollback & is backwards-compatible
[ ] Confirm DB migration upgrade and downgrade tested
[ ] Runtime estimates and downtime expectations provided

[ ] Introduces new feature or API
[ ] Removes existing feature or API

Another topic for the developer tutorial: ${t('string-to-translate')}  in backticks seems not be extracted by babel. Not sure, if this is a bug or expected behavior, which needs to be worked around in superset.
Further, I find some translations in .po files (e.g. Pie Chart in 'sl/LC_MESSAGES/messages.po' or 'zh/LC_MESSAGES/messages.po') which I don't find in the superset project and which are, in consequence, not extracted to the .pot file
Finally, there are a some fragments, where messages are split in multiple sections, because in between there is an HTML element (e.g. ). These are somewhat harder to translate as the fragments on it's own sometimes are not meanigful. Not sure, if there is a better way to handle these.

Regarding the additional translations in the 'sl/LC_MESSAGES/messages.po', I included the 'superset-ui' repo in extraction process (if I am right, that won't be problem anymore with monorepo). I also added some strings manually to the po file (I couldn't find the way to extract them with the babel).
Thumbs up for properly solving i18n issues.

@villebro I think I need your assistance here. I tried to figure out why the test cases fail but see no causing change in this PR. Wat might be the reason and how could I fix it?

@hbruch I think it's just a flaky test. I restarted the test, let's see if that resolves it


➕ [RESOURCE] - Dart Programming Language

Idea Contribution

[X] I have read all the resource request issues.
[X] I'm interested in working on this issue
[X] I'm part of GSSOC organization

Where do you want to add the resource? Specify the category and section.
I want to add a new youtube video resource for Dart programming language.
Provide the URLs of the resources you are adding
https://www.youtube.com/watch?v=Ej_Pcr4uC2Q
Any alternative approaches/features
No response
Additional Context
No response
Code of Conduct

[X] I follow the CONTRIBUTING GUIDELINE of this project.

This is already present in the project, ill close this issue for now


ERROR: The method 'subtract' isn't defined for the type 'Point'.

Thanks for the report, this should be sorted in the latest release.


Adding industry-specific codes to a new "Industry" class.

Many industrial fields (the petroleum industry, electrical engineering, chemical engineering, etc.) have industry specific codes and formatting that would be useful to generate synthetically.
Examples:

API well numbers for exploratory wells - water, energy
Stock-Keeping Units (SKUs) and Price Look-up Codes (PLCs)
Global Trade Item Numbers
etc.

Is there interest to include these variations in an "Industry" class? Am open to changing the name! :)
Thanks,
pb

Most of the data can be added to built-in providers, so there is no need in another one provider.


Surprising runs list result for 0.9 (new Guild home behavior)

This may not be an issue after all but I want to capture it for discussion.
When running guild runs, Guild locates a Guild home directory to show the applicable runs. This is a .guild directory in the cwd or any of its parents. If Guild does not find such a directory it silently creates one under user home (i.e. ~/.guild). This can cause confusion as the list now depends on the cwd and when running outside a "repo" (e.g. a project where guild init was run) Guild shows a list of runs located under user home.
The scheme of looking up the cwd hierarchy for a repo is similar to a number of programs - notably git. However, Guild deviates from these programs in silently creating a valid repo under user home. I think this may be the source of the surprise.
A couple of options occur to me:

Show a warning/message to the user that the default location is being use (probably a message)
Behave like git and fail with an error when being run outside an initialized repo

Maybe we should only create a directory if user accepted with an interactive prompt?


Update pathping.md

@Subha0627 : Thanks for your contribution! The author(s) have been notified to review your proposed change.


TargetECRRepositoryName does not exist in CloudFormation Template

Getting error message "An error occurred (ValidationError) when calling the CreateStack operation: Parameters: [TargetECRRepositoryName] do not exist in the template" when executing the create-stack CLI command. Issue appears to be incorrect parameter name in the parameters file.

Thank you for filing this issue.
Can I can which CloudFormation template you were trying to deploy when you ran into this error?

Resolved in https://github.com/aws-samples/amazon-ec2-image-builder-samples/pull/19.
Thank you!


Property 'appearance: none' doesn't exist.

If anything, consider it an optimisation :) Thanks

So appearance:none still has an effect on many browsers, including mobile Webkit. While I believe the property is going to be deprecated, for now, it still prevents mobile Webkit from adding default inset shadows, outlines, etc that feel inappropriate for Skeleton's style. I'm going to keep appearance:none in until a critical mass of browsers no longer support it.
Thanks so much for the contribution and definitely something I will consider again in the future.


Release Google.Cloud.AIPlatform.V1 version 3.9.0

Changes in this release:
New features

Add a dynamic retrieval API (commit 39346c1)
Add continuous sync option in feature_view.proto (commit de039c0)
Add psc_automation_configs to DeployIndex v1 (commit 100ccd6)

Created release for Google.Cloud.AIPlatform.V1-3.9.0