Outbound schedule creation fail

Outbound schedule creation fails when any one of image_activities, maintenance_activites or downlink_activities is missing

The values for image_activities, maintenance_activites and downlink_activities are checked and three different function handle outbound schedule creation for each case.


geom_who and friends are now geoms. (also fixes small tests)

Fixes issue: #9

merging even though the tests fail.  this is because the failing tests fail also in master.


Car detection using deep learning

This issue involves implementing car detection using MobileNetSSD. MobileNetSSD is chosen for its efficiency and accuracy in real-time object detection tasks. The task includes:

Implementing MobileNetSSD for car detection
Fine-tuning the model on specific datasets
Processing input images to identify and localize cars
Post-processing with non-max suppression
Application in autonomous driving, traffic monitoring, and surveillance systems

Please assign this issue to me for implementation and refinement of the car detection system using MobileNetSSD.

Hii @sanjay-kv ,
could u please assign this issue under GSSOC'24 with respective levels


import error

Information

Qiskit Metal version:0.0.4
Python version:3.9
Operating system:win 10

What is the current behavior?
I can't find qiskit_metal.qlibrary.connectors in 0.0.4
Steps to reproduce the problem
from qiskit_metal.qlibrary.connectors.cpw_finger_cap import CPWFingerCap
is error
What is the expected behavior?
I want to import CPWFingerCap
Suggested solutions
Where can I find qiskit_metal.qlibrary.connectors's files in 0.0.4?  Thank you!

The qlibrary has been updated to a new structure, please check the files and make sure are up to date with your version of the main branch.
You will probably find what you are looking for in qiskit_metal.qlibrary.lumped


Ability to inject times outside of default time interval

Proposed feature according to https://github.com/Hacker0x01/react-datepicker/issues/1328

Nice work!


Allow any email address from the ghost domain

With members feature Ghost has now option to send newsletters directly from the dashboard but it restricts the "FROM" address to the installation domain. Rather than it should just check if the email originating from the same domain.
For example:
If ghost site is live/installed at:

example.com, or
www.example.com, or
subdomain.example.com

Then using<EMAIL_ADDRESS>is perfect option. Rather than forcing users to choose from<EMAIL_ADDRESS>or<EMAIL_ADDRESS>For sake of user experience please allow all subdomains. Of course we could verify if the email address belongs to the user or not.

This is neither how Ghost works currently, nor the correct place to discuss feature requests.


Adding the IAM Role to an Amazon Neptune Cluster.

Hi,
please provide an example cloud-formation template to add IAM Role to an Amazon Neptune Cluster.
Manual steps are described here:
https://docs.aws.amazon.com/neptune/latest/userguide/bulk-load-tutorial-IAM.html
I would like to have this on my cloud-formation template
Thanks

Great request. I've labeled it as an enhancement in need of an author. Thanks!

@niroshanaj You can use the Lambda client to do this currently. Here is an example.

Wow! I whole pile of awesome in there, @beebs-systap!  Does that get you what you need, @niroshanaj?
As a follow-on, we're working on a new repo that will try to aggregate links to all of these great little pockets of CloudFormation goodness. I'll make sure to put a pointer from here when it goes up.

I need feature too, looks like it's not supported by CF yet. Is there any ETA for this feature ?

How is this not supported yet?  This is a key feature of neptune and is still a manual console action for end users after deploying a cloudformation template.

Any news on this topic?

@beebs-systap can you please provide an update? This was reported almost 1.5 years ago.

@namedgraph Thanks for bumping. The CFN support is there now. I'll update this thread once we have an update.

@beebs-systap Which is the new function/feature that allows us to assign a role to Neptune?
I am not a CF expert, and I am facing the same issue now. I would like to avoid to use Lambda.
Thanks!

@provcristianmaluenda We need to push some updates on the Neptune-side to make it available. I'll update this issue.

@beebs-systap any ETA for the release?

Any update/ETA when this will be released?

The AssociatedRoles property is now supported. The documentation is rolling out over the next week.

DBCluster:
--
  | Type: "AWS::Neptune::DBCluster"
[snip]
  | AssociatedRoles :
  | - "arn:aws:iam::account-number:role/iam-role-name"

Properties
AssociatedRoles
Provides a list of the AWS Identity and Access Management (IAM) roles that are associated with the DB cluster. IAM roles that are associated with a DB cluster grant permission for the DB cluster to access other AWS services on your behalf.
Required: No
Type: List of DBClusterRole
Update requires: No interruption

@beebs-systap great news. Is this now in the CDK as well?

The AssociatedRoles property is now supported. The documentation is rolling out over the next week.

DBCluster:
--
  | Type: "AWS::Neptune::DBCluster"
[snip]
  | AssociatedRoles :
  | - "arn:aws:iam::account-number:role/iam-role-name"

Properties
AssociatedRoles
Provides a list of the AWS Identity and Access Management (IAM) roles that are associated with the DB cluster. IAM roles that are associated with a DB cluster grant permission for the DB cluster to access other AWS services on your behalf.
Required: No
Type: List of DBClusterRole
Update requires: No interruption

Hi...Added Associated role in cloudformation but didnt work? can u give detail samples

Cleaning up stale issues in preparation for refreshing this repository. Please re-open if this still needs to be addressed.


TypeError: save_pil_to_file() got an unexpected keyword argument 'format'

This issue occurred when updating to the latest version
To create a public link, set share=True in launch().
Startup time: 11.2s (import torch: 1.0s, import gradio: 0.7s, import ldm: 0.3s, other imports: 0.6s, load scripts: 3.3s, create ui: 2.9s, gradio launch: 2.4s).
number of faces: 1
prompt for the face: <lora:face (1):1>
Traceback (most recent call last):
File "D:\sd-webui-aki\sd-webui-aki-v4\py310\lib\site-packages\gradio\routes.py", line 422, in run_predict
output = await app.get_blocks().process_api(
File "D:\sd-webui-aki\sd-webui-aki-v4\py310\lib\site-packages\gradio\blocks.py", line 1326, in process_api
data = self.postprocess_data(fn_index, result["prediction"], state)
File "D:\sd-webui-aki\sd-webui-aki-v4\py310\lib\site-packages\gradio\blocks.py", line 1260, in postprocess_data
prediction_value = block.postprocess(prediction_value)
File "D:\sd-webui-aki\sd-webui-aki-v4\py310\lib\site-packages\gradio\components.py", line 4457, in postprocess
file = self.img_array_to_temp_file(img, dir=self.DEFAULT_TEMP_DIR)
File "D:\sd-webui-aki\sd-webui-aki-v4\py310\lib\site-packages\gradio\components.py", line 355, in img_array_to_temp_file
return self.pil_to_temp_file(pil_image, dir, format="png")
TypeError: save_pil_to_file() got an unexpected keyword argument 'format'
提示：Python 运行时抛出了一个异常。请检查疑难解答页面。
number of faces: 1
prompt for the face: <lora:face (1):1>
Traceback (most recent call last):
File "D:\sd-webui-aki\sd-webui-aki-v4\py310\lib\site-packages\gradio\routes.py", line 422, in run_predict
event_id = getattr(body, "event_id", None)
File "D:\sd-webui-aki\sd-webui-aki-v4\py310\lib\site-packages\gradio\blocks.py", line 1326, in process_api
):
File "D:\sd-webui-aki\sd-webui-aki-v4\py310\lib\site-packages\gradio\blocks.py", line 1260, in postprocess_data
output = []
File "D:\sd-webui-aki\sd-webui-aki-v4\py310\lib\site-packages\gradio\components.py", line 4457, in postprocess
File "D:\sd-webui-aki\sd-webui-aki-v4\py310\lib\site-packages\gradio\components.py", line 355, in img_array_to_temp_file
TypeError: save_pil_to_file() got an unexpected keyword argument 'format'
提示：Python 运行时抛出了一个异常。请检查疑难解答页面。

@777777lkj
Thanks for the error report.
I have never seen this error before, so at this point I cannot imagine either the cause or the solution.
If there is a case where the error does not occur, could you please tell me the difference in settings and environment from that case? If you can give me that information, I may be able to reproduce the phenomenon and determine the cause from that information.

@ototadana I'm not entirely sure, but I think this problem is not with this extension, but the webui instead.
Many other extensions have the same issue.
For example, you might wanna check out https://github.com/opparco/stable-diffusion-webui-two-shot/issues/54#issuecomment-1585055946

@iamrohitanshu
Thanks!
Just now I was looking at that too.
The cause seems to be that the def save_pil_to_file method overridden by SD Web UI (-1.3.2) does not match the arguments required by gradio.

https://github.com/gradio-app/gradio/blob/b51112811c3f3d689c80994695f8919c9cee8620/gradio/components.py#L355
https://github.com/AUTOMATIC1111/stable-diffusion-webui/blob/baf6946e06249c5af9851c60171692c44ef633e0/modules/ui_tempdir.py#L34C5- L34C21

However, the latest version of the Web UI (1.4.0) has the following fixes and should work fine.

https://github.com/AUTOMATIC1111/stable-diffusion-webui/blob/394ffa7b0a7fff3ec484bcd084e673a8b301ccc8/modules/ui_tempdir.py#L34

I am not sure why this problem is occurring. It may be a distribution-specific problem that does not occur with the original Web UI.
@777777lkj @player99963
If your Web UI version is not 1.4.0, please try upgrading. I think there is a good chance that this problem can be solved.

If your Web UI version is not 1.4.0, please try upgrading. I think there is a good chance that this problem can be solved.

After testing, the problems have all been solved.
Thank you for your efforts.


Bare bones set up for functionality

@boylea Does this mean we can delete the second (nested) /api folder? If yes, maybe you could do that in this PR?

+1


Fix link to Channel Factories paper

Looks like the URL changed at some point.

@bitschmidty fixed, thanks!


Remove event based listeners

Observing resource changes via the OSGi event mechanism is deprecated in favor of using the ResourceChangeListener API. This PR aims to get rid of all deprecated observation code, which should ideally allow Sling to stop generating the legacy OSGi events entirely and improve performance.
There is one case where the internals of the event mechanism are exposed in a component configuration so the switch cannot be cleanly made without breaking backwards compatibility. In this case, I've added a new configuration setting that enables the clean use of the ResourceChangeListener API, and fall back to registering an event handler if only an event filter is provided.

Pull Request Test Coverage Report for Build 4209

8 of 35 (22.86%)  changed or added relevant lines in 3 files are covered.
3 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-0.05%) to 51.347%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

bundle/src/main/java/com/adobe/acs/commons/wcm/notifications/impl/SystemNotificationsImpl.java
8
10
80.0%

bundle/src/main/java/com/adobe/acs/commons/replication/packages/automatic/impl/ConfigurationUpdateListener.java
0
3
0.0%

bundle/src/main/java/com/adobe/acs/commons/httpcache/invalidator/event/JCRNodeChangeEventHandler.java
0
22
0.0%

Files with Coverage Reduction
New Missed Lines
%

bundle/src/main/java/com/adobe/acs/commons/mcp/impl/ProcessErrorReportExcelServlet.java
1
66.22%

bundle/src/main/java/com/adobe/acs/commons/httpcache/invalidator/event/JCRNodeChangeEventHandler.java
2
0.0%

Totals

Change from base Build 4204:
-0.05%

Covered Lines:
12867

Relevant Lines:
25059

💛  - Coveralls

The build is failing on an unrelated unit test. The test also seems to be flaky since it only failed in one of the five builds. I think this is still OK to merge like this, but please let me know if I need to make further changes.


other package managers support like brew?

Consider/do research on including other popular package managers

Implemented brew. Will consider others in the future.


Replace the reddit.com/place palette with the superior db16 palette.

As demonstrated in this thread on PixelJoint, db16 is a really nice color palette. Better than the reddit palette, methinks.
Palette infographic:

Cool art made with it (not mine):

This is what the Current board would look like if palette was changed img
Thanks to Jaron780 from discord

@Sbrown-WilliamsCrusher I see absolutely nothing wrong with that!
In all seriousness though, we probably shouldn't change the colorscheme without clearing the board, which probably shouldn't be done just to change the color scheme. Also, some may disagree, but I'd switch black and white. I didn't realize the whole board would be painted with the first color.

That mockup isn't quite representative, since the two palettes are in different orders. Here's a more representative mockup:
current:

dba16:

this reorder was just done by eye, there might be a more optimal reorder, and some of the artwork certainly would have made different choices with a different palette. The biggest notable difference is that the current palette has two subtly different whites, where dba16 has a white and a grey.

The PR was just pulled to a dev environment with no reordering that's why it looks odd. I did reorder them but didn't get a chance to screenshot it. Guess I don't have to anymore, thanks @YenTheFirst

Not gunna happen. We might add colors in the future, but we have no intention of ever replacing the current core 16 pallette


Support reverse pagination (previous page, has-previous-items)

I need this for datasette-graphql for full compatibility with the way Relay likes to paginate - using cursors for paginating backwards as well as for paginating forwards.

This may be the kick I need to get Datasette pagination to work in reverse too.
Originally posted by @simonw in https://github.com/simonw/datasette-graphql/issues/2#issuecomment-668305853

Yes, this would be nice!
I using Datasette v0.56 and don't see a previous page button.

I found one example of an implementation of reversed keyset pagination here: https://github.com/tvainika/objection-keyset-pagination/blob/cb21a493c96daa6e63c302efae6718d09aa11661/index.js#L74-L79

I think my ideal implementation for this would be to reverse the order, grab the previous page-size-plus-one items, then return a ?_next=x token that would provide the previous page sorted back in the expected default order.
The alternative would be to have a ?_previous=x token which can be used to paginate backwards in reverse order, but I think this would be confusing as it would result in "hit next page, then hit previous page" returning you to a new state which features rows in the reverse order.

Let's figure out the SQL for this. The most complex case is probably this one: https://latest.datasette.io/fixtures/compound_three_primary_keys?_next=a%2Ch%2Cr
Here's the SQL for that page: https://latest.datasette.io/fixtures?sql=select+pk1%2C+pk2%2C+pk3%2C+content+from+compound_three_primary_keys+where+((pk1+>+%3Ap0)
++or
(pk1+%3D+%3Ap0+and+pk2+>+%3Ap1)
++or
(pk1+%3D+%3Ap0+and+pk2+%3D+%3Ap1+and+pk3+>+%3Ap2))+order+by+pk1%2C+pk2%2C+pk3+limit+101&p0=a&p1=h&p2=r
select pk1, pk2, pk3, content from compound_three_primary_keys where ((pk1 > :p0)
  or
(pk1 = :p0 and pk2 > :p1)
  or
(pk1 = :p0 and pk2 = :p1 and pk3 > :p2)) order by pk1, pk2, pk3 limit 101

Where p0 is a, p1 is h and p2 is r.
Given the above, how would I figure out the correct previous link? It should be https://latest.datasette.io/fixtures/compound_three_primary_keys?_next=a%2Cd%2Cv - a, d, v.

I tried flipping the direction of the sort and the comparison operators and got this: https://latest.datasette.io/fixtures?sql=select+pk1%2C+pk2%2C+pk3%2C+content+from+compound_three_primary_keys+where+((pk1+<+%3Ap0)
++or
(pk1+%3D+%3Ap0+and+pk2+<+%3Ap1)
++or
(pk1+%3D+%3Ap0+and+pk2+%3D+%3Ap1+and+pk3+<+%3Ap2))+order+by+pk1+desc%2C+pk2+desc%2C+pk3+desc+limit+1+offset+99&p0=a&p1=h&p2=r
select pk1, pk2, pk3, content from compound_three_primary_keys where ((pk1 < :p0)
  or
(pk1 = :p0 and pk2 < :p1)
  or
(pk1 = :p0 and pk2 = :p1 and pk3 < :p2)) order by pk1 desc, pk2 desc, pk3 desc limit 1 offset 99

Which returned a-d-v as desired. I messed around with it to find the limit 1 offset 99 values.

Same query again with a, d, v returns 0 results, which is also as we would want: it signifies that we are back to the very first page: https://latest.datasette.io/fixtures?sql=select+pk1%2C+pk2%2C+pk3%2C+content+from+compound_three_primary_keys+where+((pk1+<+%3Ap0)
++or
(pk1+%3D+%3Ap0+and+pk2+<+%3Ap1)
++or
(pk1+%3D+%3Ap0+and+pk2+%3D+%3Ap1+and+pk3+<+%3Ap2))+order+by+pk1+desc%2C+pk2+desc%2C+pk3+desc+limit+1+offset+99&p0=a&p1=d&p2=v

Relevant code is some of the most complex in all of Datasette.
https://github.com/simonw/datasette/blob/0a7621f96f8ad14da17e7172e8a7bce24ef78966/datasette/views/table.py#L530-L594
And
https://github.com/simonw/datasette/blob/0a7621f96f8ad14da17e7172e8a7bce24ef78966/datasette/views/table.py#L743-L771
I'll need to think hard about how to refactor this out into something more understandable before implementing previous links.


WSS Webrtc Info packet not reaching Jambonz

Below is a sample info packet sent from webrtc client , this packet get discarded because it has via tag
INFO sip:u-35f91b60-d3f1-53eb-9db6-68421d0ee2e7@<IP_ADDRESS>:8443;transport=wss SIP/2.0
Via: SIP/2.0/WSS kryyrqmo1osq.invalid;branch=z9hG4bK7649180
Max-Forwards: 69
To: sip:u-35f91b60-d3f1-53eb-9db6-68421d0ee2e7@<IP_ADDRESS>:38210;tag=eaggSa8jH473D
From: "Krithi H (Manager)" sip:supportdevelopment419@<IP_ADDRESS>:38210;tag=miipl2j5fv
Call-ID: 759416e1-4ff1-123c-30a7-0e9f95109ce9
CSeq: 6151 INFO
X-AC-Action: resume-siprec;recording-ip-group="SIPRec1"
Allow: INVITE,ACK,CANCEL,BYE,UPDATE,MESSAGE,OPTIONS,REFER,INFO,NOTIFY,SUBSCRIBE
Supported: outbound
User-Agent: AudioCodes-WebRTC
Content-Length: 0
Logs drachtio enclosed
info.log

actually, it does get sent to the feature server
2023-04-07 14:15:33.586315 send 629 bytes to udp/[<IP_ADDRESS>]:5060 at 14:15:33.586263:
INFO sip:u-35f91b60-d3f1-53eb-9db6-68421d0ee2e7@<IP_ADDRESS>:5060 SIP/2.0
Via: SIP/2.0/UDP <IP_ADDRESS>;rport;branch=z9hG4bKUta20S9FKea0j
Max-Forwards: 69
From: "Krithi H (Manager)" <sip:supportdevelopment419@<IP_ADDRESS>:38210>;tag=FK98t5rpeDypS
To: <sip:u-35f91b60-d3f1-53eb-9db6-68421d0ee2e7@<IP_ADDRESS>:38210>;tag=eaggSa8jH473D
Call-ID: 759416e1-4ff1-123c-30a7-0e9f95109ce9
CSeq: 65884696 INFO
User-Agent: AudioCodes-WebRTC
Allow: INVITE, ACK, CANCEL, BYE, UPDATE, MESSAGE, OPTIONS, REFER, INFO, NOTIFY, SUBSCRIBE
Supported: outbound
Content-Length: 0
X-AC-Action: resume-siprec;recording-ip-group="SIPRec1"

No connected clients found to handle incoming info request
No providers available for INFO
is error log in drachtio from FS
2023-04-10 06:03:47.389713 recv 631 bytes from udp/[<IP_ADDRESS>]:5060 at 06:03:47.389677:
INFO sip:u-35f91b60-d3f1-53eb-9db6-68421d0ee2e7@<IP_ADDRESS>:5060 SIP/2.0
Via: SIP/2.0/UDP <IP_ADDRESS>;rport;branch=z9hG4bKcv0H5K0jyecgD
Max-Forwards: 69
From: "Krithi H (Manager)" sip:supportdevelopment419@<IP_ADDRESS>:11056;tag=Uc7Z5rS5FXZeF
To: sip:u-35f91b60-d3f1-53eb-9db6-68421d0ee2e7@<IP_ADDRESS>:11056;tag=Stme22QyNBK9Q
Call-ID: f94f75a8-5207-123c-30a7-0e9f95109ce9
CSeq: 65999513 INFO
User-Agent: AudioCodes-WebRTC
Allow: INVITE, ACK, CANCEL, BYE, UPDATE, MESSAGE, OPTIONS, REFER, INFO, NOTIFY, SUBSCRIBE
Supported: outbound
Content-Length: 0
X-AC-Action: resume-siprec;recording-ip-group="SIPRec2"
2023-04-10 06:03:47.389738 No connected clients found to handle incoming info request
2023-04-10 06:03:47.389745 processNewRequest - No providers available for INFO
2023-04-10 06:03:47.389793 send 397 bytes to udp/[<IP_ADDRESS>]:5060 at 06:03:47.389771:
SIP/2.0 503 Service Unavailable
Via: SIP/2.0/UDP <IP_ADDRESS>;rport=5060;branch=z9hG4bKcv0H5K0jyecgD;received=<IP_ADDRESS>
From: "Krithi H (Manager)" sip:supportdevelopment419@<IP_ADDRESS>:11056;tag=Uc7Z5rS5FXZeF
To: sip:u-35f91b60-d3f1-53eb-9db6-68421d0ee2e7@<IP_ADDRESS>:11056;tag=Stme22QyNBK9Q
Call-ID: f94f75a8-5207-123c-30a7-0e9f95109ce9
CSeq: 65999513 INFO
Content-Length: 0
2023-04-10 06:03:47.392806 recv 640 bytes from udp/[<IP_ADDRESS>]:5060 at 06:03:47.392769:
INFO sip:u-35f91b60-d3f1-53eb-9db6-68421d0ee2e7@<IP_ADDRESS>:5060 SIP/2.0
Via: SIP/2.0/UDP <IP_ADDRESS>;rport;branch=z9hG4bKD5Sa7eHpUQ22r
Max-Forwards: 69
From: "Krithi H (Manager)" sip:supportdevelopment419@<IP_ADDRESS>:11056;tag=Uc7Z5rS5FXZeF
To: sip:u-35f91b60-d3f1-53eb-9db6-68421d0ee2e7@<IP_ADDRESS>:11056;tag=Stme22QyNBK9Q
Call-ID: f94f75a8-5207-123c-30a7-0e9f95109ce9
CSeq: 65999514 INFO
User-Agent: AudioCodes-WebRTC
Allow: INVITE, ACK, CANCEL, BYE, UPDATE, MESSAGE, OPTIONS, REFER, INFO, NOTIFY, SUBSCRIBE
Supported: outbound
Content-Length: 0
X-AC-Action: resume-siprec;recording-ip-group="VAIC-AgentAssist"
2023-04-10 06:03:47.392832 No connected clients found to handle incoming info request
2023-04-10 06:03:47.392845 processNewRequest - No providers available for INFO
2023-04-10 06:03:47.392893 send 397 bytes to udp/[<IP_ADDRESS>]:5060 at 06:03:47.392868:
SIP/2.0 503 Service Unavailable
Via: SIP/2.0/UDP <IP_ADDRESS>;rport=5060;branch=z9hG4bKD5Sa7eHpUQ22r;received=<IP_ADDRESS>
From: "Krithi H (Manager)" sip:supportdevelopment419@<IP_ADDRESS>:11056;tag=Uc7Z5rS5FXZeF
To: sip:u-35f91b60-d3f1-53eb-9db6-68421d0ee2e7@<IP_ADDRESS>:11056;tag=Stme22QyNBK9Q
Call-ID: f94f75a8-5207-123c-30a7-0e9f95109ce9
CSeq: 65999514 INFO
Content-Length: 0


Pyside6 GitHub actions

I added what was needed to run the Github Actions to run test using PySide6 as a Qt backend. I also made two small modifications in the source code, otherwise these tests failed:

in file tcp_server_client.py removed super().__init__() in TCPClientTemplate that doesn't inherit anything. When  TCPClient(TCPClientTemplate, QObject) was instanciated, it was calling  QObject.__init__(self), then  TCPClientTemplate.__init__(self, ...), which was then doing the super().__init__() call that is now removed. As TCPClientTemplate doesn't inherits anything, it ended up calling QObject.__init__()  a second time and that made some test fails. Now it is only called once, in TCPClient.__init__().
in file utils.py and in class ParameterControlModule, a QObject.__init__() call was also removed for similar reasons, it was called lower in the inheritance hierarchy, by a class directly inheriting QObject.

We should maybe rationalize the number of combination we are testing. I was thinking to focus on 3.11:

3.8 pyqt5
3.9 pyqt5
3.10 pyqt5
3.11 pyqt5
3.11 pyside2
3.11 pyqt6
3.11 pyqt6 windows
3.11 pyside6
3.12 pyqt6

The readme should reflect this testing matrix

maybe we can check on how other project are doing because it starts to be a lot of tests... and then we have to update the readme accordingly when we add a new test... maybe adding some automation would be could

I agree, I actually already started to implement it with a matrix strategy like in River, so that github actions automatically try all the combinations, but it seems it's not possible to have a badge for a specific config this way, only the global badge for all combinations (so if one config fails, it's considered as failed).
I will investigate, maybe some external tools or actions allow to generate badges.

yes I was doing this before, but I like the fact to know which combination fail and which doesn't... thanks for the investigation

that's quite an awesome githubaction!
however seeing the output on the readme, I figure it would be better to have a smaller table with just a green check and a red cross to have the same effect! Do you think you can produce this simpler table in the readme from the githubaction?

and sorry it seems you spend quite some time on those badges...

Yes, it's possible to change them, I tried a few but the check marks are never centered. Do you prefer something like:

Or maybe:

Or:

I prefer the text based ones, anyways, it's configurable in the workflow file.
(If it's ok, don't accept the PR right know, it needs a little bit of setup that I will explain and it's preferable to start with pymodaq_utils and pymodaq_data before going to pymodaq_gui and pymodaq)

I'm happy to go with the passing string!


Adding/updating 3rd party backup solutions links provided by them

Our 3rd party backup partners would like customers to be directed to the links they provided for more information about their solutions.

@charleskwwong : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#sign-off Thanks, looks good to merge!

Hi @charleskwwong - This pull request was opened in the public repo. PMs should work in the private repo, per the Microsoft Docs contributor guide. Would you make future content updates in the private repo? Thank you!


Bump Devfile library to latest commit (04a8b3f)

What type of PR is this:
/area dependency
What does this PR do / why we need it:
This bumps the Devfile library to the latest commit [1], which fixes the issue with parsing child Devfiles
referencing parents via URIs (GitHub blob, raw or any hosted URL).
See [2] for more context.
[1] https://github.com/devfile/library/commit/04a8b3fc66c0ca7a33d03190f3a026a3d9e6a940
[2] https://github.com/devfile/api/issues/1119
Which issue(s) this PR fixes:
Related to https://github.com/devfile/api/issues/1119
PR acceptance criteria:

[ ] Unit test

[ ] Integration test

[ ] Documentation

How to test changes / Special notes to the reviewer:
Given the following Devfile:
metadata:
  description: Java application using Spring Boot® and OpenJDK 17
  name: my-java-sb
  version: 1.3.0
parent:
  components:
  - container:
      image: registry.access.redhat.com/ubi9/openjdk-17:latest
    name: tools
  uri: https://registry.stage.devfile.io/devfiles/java-springboot/1.2.0
schemaVersion: 2.1.0

Before this PR, odo dev won't be able to parse it:
$ odo dev
 ✗  failed to parse the devfile /tmp/bug-odo-parent/devfile.yaml: failed to populateAndParseDevfile: url host should be a valid GitHub, GitLab, or Bitbucket host; received: registry.stage.devfile.io

It should now work with this update of the Devfile library:
$ odo dev
  __
 /  \__     Developing using the "my-java-sb" Devfile
 \__/  \    Namespace: default
 /  \__/    odo version: v3.10.0
 \__/

 ⚠  You are using "default" namespace, odo may not work as expected in the default namespace.
 ⚠  You may set a new namespace by running `odo create namespace <name>`, or set an existing one by running `odo set namespace <name>`

↪ Running on the cluster in Dev mode
 •  Waiting for Kubernetes resources  ...
 ✓  Added storage m2 to component
 ⚠  Pod is Pending

...

/override windows-integration-test/Windows-test
  [odo]  !  Unable to attach or mount volumes: unmounted volumes=[auto-pvc-automount-mount-path-pvc auto-pvc-automount-readonly-pvc], unattached volumes=[kube-api-access-kb2qd odo-shared-data auto-secret-automount-access-mode-secret auto-cm-automount-access-mode-subpath-configmap auto-pvc-automount-default-pvc auto-cm-automount-access-mode-configmap auto-cm-automount-default-configmap auto-cm-automount-subpath-configmap auto-secret-automount-subpath-secret odo-projects auto-pvc-automount-mount-path-pvc auto-cm-automount-access-mode-configmap-decimal auto-secret-automount-default-secret auto-secret-automount-mount-path-secret auto-secret-automount-access-mode-subpath-secret auto-cm-automount-mount-path-configmap auto-pvc-automount-readonly-pvc]: timed out waiting for the condition


v1.3.0-pre

We've released 1.2.0-rc so we need to increment the pre.

Not really sure how to resolve the dashboard dep issue here, now that we've cut out migrations/npm package builds...maybe we just don't update the dashboard keep-core dep?

So far, I was doing two PRs - one for contracts that published them on merge and another for dashboard using previously published contracts.

Closing since we went with setting master to mainnet versions for now.


images: Bump Hubble CLI to v0.8.2

LGTM once the lint job failure is addressed: https://github.com/cilium/cilium/runs/3566389926?check_suite_focus=true

Ok now I understand the printf trick at https://github.com/cilium/cilium/blob/5cd67b7be6e9ebb177c6fe8854e4c559f65306b4/images/scripts/make-image-tag.sh#L57


inputstream.adaptive not available

I'm submitting a ...

[ x ] bug report
[ ] feature request
[ x ] support request

General infomration
Prerequisites

[ x ] Are you running the latest version?

Description
[Description of the bug or feature]
Steps to Reproduce

[installed the repository]
[tried to install the plugin from repository]
[2 oldest versions available can be installed, but can't login, newer versions won't even install]

Expected behavior: [The addon installs]
Actual behavior: [nothing happens]
Context (Environment)
Installation

[ ] I installed the plugin via zip from the Releases page
[x ] I´m using the Netflix Repo
[ ] I´m using a different source (Please tell which)

Operating System

[ ] Linux (x86/x64)
[ ] OSX (x86/x64)
[x ] Windows (x86/x64)
[ ] Linux (ARM)
[ ] Android

Additional informatin on the environment
Getting an error saying inputstream.adaptive isn't available
Debug log
[Please include a link to your debug log (use something like http://sprunge.us/) or similar, please do not paste]
Other information
[e.g. detailed explanation, related issues, suggestions how to fix, links for us to have context, etc.]
Screenshots
[Please add a screenshot if that helps understanding your problem]
[You can erase any parts of this template not applicable to your Issue.]

never mind, I had to enable it through the addons library, now I can install it


Websql throws an error when Remote js debug disabled

Hi
Hope you are doing good.I need a help from you
var db = new PouchDB('test');
var rdb = new PouchDB('https://XXXXX.cloudant.com/test', {skipSetup: true});
How to Sync two database withpout websql..If websql is the only way means how it will work in android application if remote js debug disabled?
Please advise

Hi,
have you tried the sample Application?
It should not require any remote debugging.


Use multiple GPUs

How to use multiple UGPUs to train together，thanks。

You can use tools/dist_train.py.


Draft - Update utils path with parent directories

Utils module was updated with parent directories to eliminate conflict with utils.py from lm-evaluation-harness
https://github.com/EleutherAI/lm-evaluation-harness/pull/1862

@eaidova, can you please take a look?

@eaidova could you approve and merge this PR? There is no new changes after Sylwia's approval, the only merge with the latest changes from master. This PR was verified with benchmark and convert jobs as well:
https://ci-dlbenchmark-icv.iotg.sclab.intel.com/job/DL-Benchmark/job/prod/job/WW33-2024.4.0-16355/job/X_W_LS_convert_optimum/3/
https://ci-dlbenchmark-icv.iotg.sclab.intel.com/job/DL-Benchmark/job/prod/job/WW33-2024.4.0-16355/job/X_W_LS_convert_calibr/1/
https://ci-dlbenchmark-icv.iotg.sclab.intel.com/job/DL-Benchmark/job/prod/job/WW33-2024.4.0-16355/job/LS_GPU.1_long_windows11_i9-11900K-arc/6/


Structure map authoring through XLS form

Purpose

Make it easy to author StructureMaps for developers, PMs and users
Make it faster
Reduce mistakes
Make it more intuitive. Provide better errors

How to author a structure map using XLS

A single QuestionnaireResponse maps to multiple resources
Provide a template XLS structure map authoring form
Run it through a CLI tool that generates the final QuestionnaireResponse that is going to be uploaded to the server
Save these XLS forms in the current OpenSRP fhir-resource repository

Functions of the CLI tool

Convert XLS to structure map JSON
Provide useful errors to users
Validate the XLS
Connect to the current validator tool to generate results when given a questionnaire response

Tasks

[ ] Design sample XLS file from the current structure maps
[ ] Note down weaknesses and complexities that might not be covered by XLS
[ ] Request review
[ ] Develop a beta version for use

@AnnieMungai @ageryck @Gental-Giant @samkanga. You can keep track of this as it may help in authoring of StructureMaps for the various app content to fulfil project workflows

I'd like to consider using a format other than XLS Form. I think we are biased towards XLS Form because we have experience with it and we have built other tools that use it.
Maybe it is in fact the best option, but I want us to come up with a list of some other formats and look at the pros and cons of them as well before we make a decision.


NO_KEY error messages incorrectly refer to "context.request"

Versions
All stable versions.
Describe the bug
Error messages in the State classes incorrectly reference "context.request".
To Reproduce
Steps to reproduce the behavior:

Go to UserState, ConversationState or PrivateConversationState.
Examine the NO_KEY value and see references to "context.request". For example:

const NO_KEY: string = `UserState: channelId and/or conversation missing from context.request.`;

Expected behavior
Should refer to context.activity instead.
[bug]

The getStorageKey method is public and can be easily overwritten with a user's own specific storage key generation logic. In C# the getStorageKey method is a protected override, so users can also provide their own key logic.
While our implementation for the getStorageKey method will not trigger the NO_KEY error message, our default implementation of the StorageKeyFactory will check to see if the key exists before attempting to do any reads or writes.

Thanks Steven, I hadn't thought about overriding getStorageKey. If that's the only way for the NO_KEY message to show up, shouldn't the message reflect that? Anything could be in getStorageKey and it might have nothing to do with context.activity. Perhaps the message should be Overridden UserState.getStorageKey method did not return a key


Error when running Mandalorion_just_align.py

I got this error when running the script on the ONT reads from the paper:
Traceback (most recent call last):
  File "Mandalorion_3_Remove_ISPCR_Sequences.py", line 109, in <module>
    find_ispcr(path+'/'+input1)
  File "Mandalorion_3_Remove_ISPCR_Sequences.py", line 52, in find_ispcr
    reverse_b=reverse_complement(b)
  File "Mandalorion_3_Remove_ISPCR_Sequences.py", line 25, in reverse_complement
    Seq=Seq+complement[item]
KeyError: '3'

The script continued to run, but I am not sure whether the results are correct and complete. Please fix this.
Thanks!

I too am seeing this error. The output files are empty, except for the 2D.fastq. So I don't think anything has happened with the data. Any help on this thread is much appreciated.

I get this error as well. Any help?


Multi user chat

Allows admin to create a closed room and register users to get access

LGTM

I am not fan of this pattern
 case ex: IllegalStateException if ex.getMessage == "Creation failed - User already joined the room." ⇒ ...
+              case ex: XMPPErrorException if ex.getXMPPError.getCondition == XMPPError.Condition.forbidden && ex.getXMPPError.getType == ...
+              case ex: IllegalStateException if ex.getMessage == "Creation failed - User already joined the room." ⇒ ...
+              case ex: SmackException if ex.getMessage == "Creation failed - Missing acknowledge of room creation." ⇒ ...
...

exception holding data on which control flow is decided is veeery weird in my opinion. Is there not a better way ? I obviously don't have all the context.

It’s not really control flow, all it’s doing is translating the internal smack messages to more readable akka failures that are then sent as a message back to sender.
From: Marek Kadek
Reply-To: springnz/smack-scala
Date: Thursday, 15 October 2015 3:12 pm
To: springnz/smack-scala
Cc: Mikkel Fishman
Subject: Re: [smack-scala] Multi user chat (#9)
I am not fan of this pattern
case ex: IllegalStateException if ex.getMessage == "Creation failed - User already joined the room." ⇒ ...

         case ex: XMPPErrorException if ex.getXMPPError.getCondition == XMPPError.Condition.forbidden && ex.getXMPPError.getType == ...

         case ex: IllegalStateException if ex.getMessage == "Creation failed - User already joined the room." ⇒ ...

         case ex: SmackException if ex.getMessage == "Creation failed - Missing acknowledge of room creation." ⇒ ...

...
exception holding data on which control flow is decided is veeery weird in my opinion. Is there not a better way ? I obviously don't have all the context.
—
Reply to this email directly or view it on GitHubhttps://github.com/springnz/smack-scala/pull/9#issuecomment-148257325.

That doesn't really make it better. So if client is handling that specific error, and stringly typed message is changed, he will be a bit surprised for getting just the generic message.
It looks a bit weird that now actor turned into 100% receive-respond type of thing -> I don't really see benefit of returning success messages, especially since none of them hold any data.
I would delete all ActorSuccess and ActorFailure responses, let exception bubble to parent of Client, and let him handle the situation (whether its resuming operation normally, restarting or killing it all together). Usage of actors like this don't 100% make sense to me! But if it works for you / @mpollmeier thats fine and feel free to ignore me :)

also  uploadAdapter.upload(file, description) should take ExecutionContext, it should not be hardcoded in implementation of the adapter. Either
a) make adapter not return Future, thus being synchronous, then client knows he needs to start future
b) put EC as argument, so client can specify which ec he wants the future to run on
I prefer (b)


[BUG] DenoiseModel and CellposeDenoiseModel returning image flattened across one axis

Describe the bug
I have a script for running Cellpose and after adding options to use the DenoiseModel or CellposeDenoiseModel, the output for a 3D image is flattened across one of the axes when using the denoising related models. I've confirmed that the tiff file is being loaded properly and the default CellposeModel is acting as expected, returning a 3D image.  I'm thinking there's a setting I am getting wrong or missing, but I'm unable to find a solution so far.
Run log
INFO:cellpose.io:reading tiff with 350 planes
100%|██████████| 350/350 [00:10<00:00, 34.12it/s]
INFO:cellpose.denoise:>> denoise_cyto3 << model set to be used
INFO:cellpose.core:** TORCH CUDA version installed and working. **
INFO:cellpose.core:>>>> using GPU
INFO:cellpose.denoise:>>>> model diam_mean =  30.000 (ROIs rescaled to this size during training)
Scan_Iter_0003_CamA_ch0_CAM1_stack0000_488nm_0000000msec_0018536711msecAbs_decon.tif has shape (350, 1480, 1879)
Denoised image has shape (1, 350, 1480, 1)

sorry I think this should be fixed now, please also use z_axis, let us know if not


Remove top level setup.py & requirements.txt

Removes top-level setup.py and requirement.txt as these are no longer used.
Also, Some of the code in top-level setup.py was merged into mlcommons_box/setup.py

LGTM


README request: CredHub vs Vault

It would be awesome to summarize "CredHub vs Vault" in the readme. This will help explain to everyone why we are going down a path that's independent of the Vault ecosystem of existing tooling; and for non-CF/BOSH users it would explain why they'd deploy CredHub rather than Vault.

Hi Dr. Nic -
I am a bit skeptical about whether a 'CredHub vs. Vault' document is valuable. I certainly agree that we need better documentation of our goals and use-cases, which is something on my to-do list.
The goal of the CredHub project is to provide an extendable and well integrated open source credential management solution for Cloud Foundry use-cases. We felt that we could cover these use-cases better by implementing a new product as opposed to wrapping Vault. Beyond UX and dependency concerns, some of the features that CF users want, e.g. HSM support, are only available in the commercial distribution of Vault.
All of that said - our goal is not to tell you not to use Vault. We are providing a product that will hopefully cover these use-cases very well, but you will always have the option to use Vault + wrappers if that is your preference.
Hope that helps.
Dan

Ok thanks for writing that up. I think much of what wrote would go well in
the readme. Copy + paste FTW.

this is an interesting one! actually, we are currently investigating whether to use credhub natively or wrap vault (the free version) in a bosh release. vault seems more mature and established atm, credhub may become the de facto standard for cf-based deployments (does it?).
@drnic is there already a version of that readme available?
thanks!

@domdom82 There is an existing Vault bosh release (Thanks @drnic) so don't create your own
https://github.com/cloudfoundry-community/vault-boshrelease

Seems like this issue is getting a lot of traffic since it is the number 1 result when searching vault vs. credhub.
@danjahner Can we link the document/readme (if one exists) describing the goals and use cases for credhub as mentioned in this comment?

// , This question has come up at some important architecture meetings I have attended, and I didn't know what PCF CredHub was.
This page is also the top result for a search for credhub vs on duckduckgo.com:
https://duckduckgo.com/?q=credhub+vs&t=hi&ia=web
It's worth addressing, even in a more general "Credhub vs. Other Tools" type of document.
It seems that Vault is more of a general-purpose tool designed without any particular Cloud Platform, Cloud Service or OS in mind, and it seems like PCF CredHub is the best choice for architecture tied to PCF. But I would welcome any guidance "from the horse's mouth."

Let me add that other tools like Ansible or Jenkins come with a hashicorp vault integration but do not yet integrate with credhub (if I was mean I would mention that even concourse supported vault before credhub integration was added). So you end up with having both.
It would be nice if bosh and cloud foundry supported vault, too.

If vault and credhub both implement the config spec, I don't see why one cant use the other as a backend. Is there something about the storage model in credhub that makes it challenging to support vault as a backend? I'm comfortable with storing credentials in vault because they're only stored encrypted in memory and never sent over a network, but I can't find anything on credhub comparing the approach. Credhub having the goals of easy of use and built in backup process that seem to have dictated here, but the whole concept of backups can't exist in the leasing model use case for credentials where they are created on demand based on user roles usually in Active Directory and removed immediately after use. Vault does all that with spring cloud/integration support too. We really need a comparison. Those are necessary features for us after being in the news over a breach last year, and really I just assumed this was the model implemented. I'd really like to know why if it wasn't, and what opportunity there is for adding that feature. It could even be an issue I or one of our teams could take on if we had some background


Error: Expected [object Object] to be a GraphQL schema.

Describe the bug
I am seeing this 👇
Error: Expected [object Object] to be a GraphQL schema.
--
May 24 2019 07:13:35:271    at invariant (/home/nowuser/src/node_modules/apollo-server-core/node_modules/graphql/jsutils/invariant.js:19:11)
May 24 2019 07:13:35:315    at validateSchema (/home/nowuser/src/node_modules/apollo-server-core/node_modules/graphql/type/validate.js:55:60)
May 24 2019 07:13:35:374    at assertValidSchema (/home/nowuser/src/node_modules/apollo-server-core/node_modules/graphql/type/validate.js:80:16)
May 24 2019 07:13:35:425    at Object.validate (/home/nowuser/src/node_modules/apollo-server-core/node_modules/graphql/validation/validate.js:58:35)
May 24 2019 07:13:35:445    at doRunQuery (/home/nowuser/src/node_modules/apollo-server-core/dist/runQuery.js:111:42)
May 24 2019 07:13:35:466    at /home/nowuser/src/node_modules/apollo-server-core/dist/runQuery.js:21:56
May 24 2019 07:13:35:487    at <anonymous>
May 24 2019 07:13:35:507    at process._tickCallback (internal/process/next_tick.js:188:7)

On the PlayGround, I see this 👇

To Reproduce
Steps to reproduce the behavior:

Here's the complete repository to clone
Create a .env file that contains 👇

NODE_ENV="production"
ENDPOINT="https://prodpaprink-5f26e1e0b6.herokuapp.com/paprink-backend/prod"
FRONTEND_URL="."..
PROD_FRONTEND_URL="..."
GOOGLE_LOGIN_APP_ID="..."
JWT_SECRET="..."
GRAPH_ACCESS_TOKEN="..."
FB_APP_SECRET="..."
FB_APP_ID="..."
PRISMA_SECRET="..."

Run now --dotenv .env
Visit the deployment and see the error or check the now logs

Expected behavior
I expected the error to not appear just like it didn't on heroku... but due to DNS problems, I am trying to host it on now.
The same code works on heroku when deployed using GitHub 👉 https://paprink-server.herokuapp.com
Versions (please complete the following information):

Connector: Postgres
Prisma Server: 1.32.2
prisma CLI: prisma/1.31.1 (darwin-x64) node-v11.4.0
OS: OSX Mojave
other dependencies: prisma-client-lib, prisma-binding, graphql-yoga, graphql-cli, and graphql

Additional context
Thanks for helping 🙏

This is caused by the classic duplicate graphql module compatibility(https://github.com/graphql/graphql-js/issues/491). One of the errors that plagued all of the graphql package users when v14 was released. You are using graphql-cli which asks for graphql v0.13 as a peer dep. GraphQL version 0.13.x is not compatible with 14.x. To solve this use yarn and add the following to the package.json:
{
  // ...
  "dependencies":{
      "graphql":"14.3.1"
       // ...
  },
  "resolutions":{
      "graphql": "14.3.1"
   },
}

For me, it happened locally as well. So I will also recommend to rm -rf node_modules && yarn after you have added these.
Here is working now deploy(I have just re-enabled the playground in prod for demonstration): https://paprink-backend-juieyjlzdf.now.sh/


Integration with text selector

Nice to see expect-playwright 😃 Considering starting using it, but I could not find info about this and was curious about a few things.
Playwright supports text selector engines like so:
    const text = await page.waitFor('text=Unauthorized');
    expect(await text.evaluate((el) => el.innerText)).toBe('Unauthorized');

That I would have wished to replace with:
await expect(page).toHaveText('Unauthorized'); // using the underlying text selector

The first thing I noticed is that the example at https://github.com/mxschmitt/expect-playwright#why-do-i-need-it does not show the above (nicer) way to get a text element that Playwright already supports.

I also wrote another issue that text selectors should be case insensitive and "partial match" by default, which landed in another MR, see new description here https://github.com/microsoft/playwright/blob/master/docs/selectors.md#text

The second thing I know is that an issue I wrote https://github.com/microsoft/playwright/issues/1375 just landed its first merge request https://github.com/microsoft/playwright/pull/1619. The text selector now pierces open shadow roots.

NOTE Text engine searches for elements inside open shadow roots, but not inside closed shadow roots or iframes.

Should/are all these features taking into consideration with these new expect functions?

Hi Max,
All the above depends a bit on your internal implementations of the current functions.

I.e. your example for toEqualText here https://github.com/mxschmitt/playwright-jest-examples/pull/1/files seems to indicate it is an exact match. Although https://github.com/mxschmitt/expect-playwright#toequaltext does not mention "exact" in the description, one could imagine this is the case from the wording "toEqual", but it would still be good to indicate in the README. Maybe saying exactly which underlying version of the text selector you use?

Doesn't https://github.com/mxschmitt/expect-playwright#tohavetext use the text=Something version of the text selector, indicating case-insensitivity and substring match? If so you should maybe mention that for that already existing selector?

I'd also recommend tracking this to see if it lands https://github.com/microsoft/playwright/issues/1658. if it lands, it would change the logic of your toEqualText selector.

Hi :)

I think we speak about two different things. toEqualText, does make a strict comparison with the value / exact match with it. But internally it just will use page.$(selector) to get the element from the DOM. So from my understanding you can use whatever selector with whatever custom selector engine in the end of Playwright.

I'm doing the comparison of the text currently by myself (not in the browsers engine), so I don't use the text based selectors there. Also they are currently case sensitive, same for toHave (which is basically a .includes in the end).

These text selectors are definitely kinda confusing right now in Playwright in my mind which one's are case sensitive or which ones not. Also not sure if they can contain spaces e.g.

I think the internal implementation in the matchers here should use the text selectors by default, as they pierce the open shadow DOM now. It would make sense to kind of align toEqualText to use the exact matching of the text selector engine (i.e. text="something")and toHaveText to equal the case-insensitive, partial matching (i.e. text=something).
Aligning the nomenclature for the various matchers you add to this project with the Playwright nomenclature/wording for what they do might help? At least for me 😝

@mxschmitt I really want to start using this package, but I do have concerns between how the current expect functions are implemented for text selections. It'd be nice to completely align them and have 3 separate functions to alight to the exact playwright three different options for the text selector engine.

@thernstig are you on the Playwright slack? Feel free to ping me there, so we can talk about that. :)

@mxschmitt Let me try to install this package next week and test some things, so I have better feedback.

@mxschmitt After lots of other issues at hand, I've come back to this. I think my deduction from all this is that maybe this should be closed. The reasons are that await expect(page).toHaveSelector('text=Playwright') works fine. Even though I'd of course have wished to use toHaveText if it was using the Playwright text based selectors. Reason being that it would be one less API to learn in essence, making it simpler for users.
So If I'd given one suggestion, it would have been to only keep toHaveText but indicate it uses the text selector engine and there are three options to use  toHaveText("some text"), toHaveText('"some text'") (or toHaveText("'some text'") or toHaveText("/some text/i") to  be consistent with the Playwright text selectors.
Or possibly to keep toHaveText and toEqualText and add toEqualTextRegex or something to match all Playwright text selector options.
Another thing is that this package seem to use textContent which means hidden elements will be included in the results, whereas I'd assume a user wants the visible text only. Which the Playwright text selectors give.
I'll leave this issue open for a while if you want to comment/keep it open and I am also still available to join slack to discuss more if you want!

@mxschmitt Closing this since it garnered no reply.
The conclusionis that we are using await expect(page).toHaveSelector('text=Playwright') for now to make it non-ambiuous to users to exactly what is being done.


Make the tests more stable

I'm seeing frequent test failures that eventually resolve themselves after restarting the Travis job.  Given how long it takes to run a CI job, it is getting pretty painful to prepare a pull request.  I'm going to use this ticket to list the failed tests as they come up:

Edge 15.15063.0 (Windows 10 0.0.0) ol.render.canvas ol.render.canvas.checkFont() clears the label cache for fonts that become available FAILED

yes saw this one as well in https://github.com/openlayers/openlayers/pull/7420#issuecomment-342116814

Found two more:

Edge 15.15063.0 (Windows 10 0.0.0) ol.View #animate() clears the ANIMATING hint when animations are cancelled FAILED  Error: expected 1 to equal 2
Edge 15.15063.0 (Windows 10 0.0.0) ol.View #animate() completes multiple staggered animations run in parallel FAILED  Error: expected false to equal true

I've seen those as well.  I copied those up to the list at the top.  Feel free to edit and add more.
I also updated the title to reflect that our goal should really be to determine why these are failing.

Another one?  Adding a checkbox to an example in #9931 doesn't seem related to ol.TileQueue
Chrome 77.0.3844 (Linux 0.0.0) ol.TileQueue #loadMoreTiles() works when tile queues share tiles FAILED
	Error: Uncaught Error: expected 5 to equal 0 (/home/circleci/repo/node_modules/expect.js/index.js:102)


feat: Add Notion database document loader

This PR adds Notion DB loader for langchain.
It reads content from pages within a Notion Database. It uses the Notion API to query the database and read the pages. It also reads the metadata from the pages and stores it in the Document object.

NotionDBLoader
NotionDBLoader is a Python class for loading content from a Notion database. It retrieves pages from the database, reads their content, and returns a list of Document objects.
Requirements

A Notion Database
Notion Integration Token

Setup
1. Create a Notion Table Database
Create a new table database in Notion. You can add any column to the database and they will be treated as metadata. For example you can add the following columns:

Title: set Title as the default property.
Categories: A Multi-select property to store categories associated with the page.
Keywords: A Multi-select property to store keywords associated with the page.

Add your content to the body of each page in the database. The NotionDBLoader will extract the content and metadata from these pages.
2. Create a Notion Integration
To create a Notion Integration, follow these steps:

Visit the (Notion Developers)[https://www.notion.com/my-integrations] page and log in with your Notion account.
Click on the "+ New integration" button.
Give your integration a name and choose the workspace where your database is located.
elect the require capabilities, this extension only need the Read content capability
Click the "Submit" button to create the integration.

Once the integration is created, you'll be provided with an Integration Token (API key). Copy this token and keep it safe, as you'll need it to use the NotionDBLoader.
3. Connect the Integration to the Database
To connect your integration to the database, follow these steps:

Open your database in Notion.
Click on the three-dot menu icon in the top right corner of the database view.
Click on the "+ New integration" button.
Find your integration, you may need to start typing its name in the search box.
Click on the "Connect" button to connect the integration to the database.

4. Get the Database ID
To get the database ID, follow these steps:

Open your database in Notion.
Click on the three-dot menu icon in the top right corner of the database view.
Select "Copy link" from the menu to copy the database URL to your clipboard.
The database ID is the long string of alphanumeric characters found in the URL. It typically looks like this: https://www.notion.so/username/8935f9d140a04f95a872520c4f123456?v=.... In this example, the database ID is 8935f9d140a04f95a872520c4f123456.

With the database properly set up and the integration token and database ID in hand, you can now use the NotionDBLoader code to load content and metadata from your Notion database.
Usage
NotionDBLoader is part of the langchain package's document loaders. You can use it as follows:
from langchain.docstore.document import Document
from langchain.document_loaders import NotionDBLoader

integration_token = "your_notion_api_key"
database_id = "your_notion_database_id"
loader = NotionDBLoader(integration_token, database_id)
docs = loader.load()

@hwchase17 where is it best to add the setup instructions?

i would add a notebook showing how to use this, and put the instructions there!
since there are such detailed instructions in the pr description, i can also do it

A notebook sounds good, I will add one and fix the linting issues

@hwchase17, notebook added and lint errors fixed

Getting timeout errors while using this. Any ideas?
Traceback (most recent call last):
  File "/Library/Frameworks/Python.framework/Versions/3.10/lib/python3.10/site-packages/urllib3/connectionpool.py", line 449, in _make_request
    six.raise_from(e, None)
  File "<string>", line 3, in raise_from
  File "/Library/Frameworks/Python.framework/Versions/3.10/lib/python3.10/site-packages/urllib3/connectionpool.py", line 444, in _make_request
    httplib_response = conn.getresponse()
  File "/Library/Frameworks/Python.framework/Versions/3.10/lib/python3.10/http/client.py", line 1374, in getresponse
    response.begin()
  File "/Library/Frameworks/Python.framework/Versions/3.10/lib/python3.10/http/client.py", line 318, in begin
    version, status, reason = self._read_status()
  File "/Library/Frameworks/Python.framework/Versions/3.10/lib/python3.10/http/client.py", line 279, in _read_status
    line = str(self.fp.readline(_MAXLINE + 1), "iso-8859-1")
  File "/Library/Frameworks/Python.framework/Versions/3.10/lib/python3.10/socket.py", line 705, in readinto
    return self._sock.recv_into(b)
  File "/Library/Frameworks/Python.framework/Versions/3.10/lib/python3.10/ssl.py", line 1274, in recv_into
    return self.read(nbytes, buffer)
  File "/Library/Frameworks/Python.framework/Versions/3.10/lib/python3.10/ssl.py", line 1130, in read
    return self._sslobj.read(len, buffer)
TimeoutError: The read operation timed out

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/Library/Frameworks/Python.framework/Versions/3.10/lib/python3.10/site-packages/requests/adapters.py", line 489, in send
    resp = conn.urlopen(
  File "/Library/Frameworks/Python.framework/Versions/3.10/lib/python3.10/site-packages/urllib3/connectionpool.py", line 787, in urlopen
    retries = retries.increment(
  File "/Library/Frameworks/Python.framework/Versions/3.10/lib/python3.10/site-packages/urllib3/util/retry.py", line 550, in increment
    raise six.reraise(type(error), error, _stacktrace)
  File "/Library/Frameworks/Python.framework/Versions/3.10/lib/python3.10/site-packages/urllib3/packages/six.py", line 770, in reraise
    raise value
  File "/Library/Frameworks/Python.framework/Versions/3.10/lib/python3.10/site-packages/urllib3/connectionpool.py", line 703, in urlopen
    httplib_response = self._make_request(
  File "/Library/Frameworks/Python.framework/Versions/3.10/lib/python3.10/site-packages/urllib3/connectionpool.py", line 451, in _make_request
    self._raise_timeout(err=e, url=url, timeout_value=read_timeout)
  File "/Library/Frameworks/Python.framework/Versions/3.10/lib/python3.10/site-packages/urllib3/connectionpool.py", line 340, in _raise_timeout
    raise ReadTimeoutError(
urllib3.exceptions.ReadTimeoutError: HTTPSConnectionPool(host='api.notion.com', port=443): Read timed out. (read timeout=10)

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/Users/kermankohli/dev/langchain-fun-2/main.py", line 7, in <module>
    docs = loader.load()
  File "/Library/Frameworks/Python.framework/Versions/3.10/lib/python3.10/site-packages/langchain/document_loaders/notiondb.py", line 46, in load
    return list(self.load_page(page_id) for page_id in page_ids)
  File "/Library/Frameworks/Python.framework/Versions/3.10/lib/python3.10/site-packages/langchain/document_loaders/notiondb.py", line 46, in <genexpr>
    return list(self.load_page(page_id) for page_id in page_ids)
  File "/Library/Frameworks/Python.framework/Versions/3.10/lib/python3.10/site-packages/langchain/document_loaders/notiondb.py", line 74, in load_page
    data = self._request(PAGE_URL.format(page_id=page_id))
  File "/Library/Frameworks/Python.framework/Versions/3.10/lib/python3.10/site-packages/langchain/document_loaders/notiondb.py", line 144, in _request
    res = requests.request(
  File "/Library/Frameworks/Python.framework/Versions/3.10/lib/python3.10/site-packages/requests/api.py", line 59, in request
    return session.request(method=method, url=url, **kwargs)
  File "/Library/Frameworks/Python.framework/Versions/3.10/lib/python3.10/site-packages/requests/sessions.py", line 587, in request
    resp = self.send(prep, **send_kwargs)
  File "/Library/Frameworks/Python.framework/Versions/3.10/lib/python3.10/site-packages/requests/sessions.py", line 701, in send
    r = adapter.send(request, **kwargs)
  File "/Library/Frameworks/Python.framework/Versions/3.10/lib/python3.10/site-packages/requests/adapters.py", line 578, in send
    raise ReadTimeout(e, request=request)
requests.exceptions.ReadTimeout: HTTPSConnectionPool(host='api.notion.com', port=443): Read timed out. (read timeout=10)

Thinking it might be you need to paginate through the API or something but thought I'd ask in case I'm the only one running into these issues

This is very much appreciated. May I ask what would man do now with documents created by this loader?
I got up to here so far :)
NOTION_TOKEN = getpass()
DATABASE_ID = getpass()

loader = NotionDBLoader(NOTION_TOKEN, DATABASE_ID)
docs = loader.load()

what now?

I tried this.  Ran into an issue when trying to load the metadata into chromadb.  Tags is a list and that won't work for chroma (at least).

Okay, ran into a few issues here.  One is around handling of metadata.  The code has cases for multi-select, richtext and title.... but there are several other built-in types - plus the default vector store for langchain (chromadb) doesn't handle things stored as List or None... so this makes it very hard to get started with.  I fixed a few things and added a fallback str conversion for all scalars... I can submit a PR for the same.
However, I'm also hitting timeouts regularly touching the API.  For this to be really usable, we'll need to support idempotency and some kind of retry mechanism.
I'm not sure I've got the time to work on it TBH, but leaving here for some other poor soul if they decide to.   The Directory exporter does the job more or less and could be edited to support metadata from the csv export, but of course it doesn't provide real-time updates.

Thanks @jacobSingh, for sharing your experience. I will look at the metadata issue if I find the time. I can't find a reference on Chromadb as the default vector store, but I see metadata handled by Optional[List[dict]] in wrappers.
 I haven't encountered a time-out yet and will be interested in reproducing it.

350 nodes. Lots if properties and blocks. I found in my case the magic
number was 60 nodes at a time. Manually paginated by overriding the number
of docs to process in one go and got them all in.
On Tue, 2 May, 2023, 14:22 Stéphane Busso, @.***> wrote:

Thanks @jacobSingh https://github.com/jacobSingh, for sharing your
experience. I will look at the metadata issue if I find the time. I can't
find a reference on Chromadb as the default vector store, but I see
metadata handled by Optional[List[dict]] in wrappers.
 I haven't encountered a time-out yet and
will be interested in reproducing it.
—
Reply to this email directly, view it on GitHub
https://github.com/hwchase17/langchain/pull/2056#issuecomment-1531109176,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAA5ZBRBBA5OQWM5ONPOBJTXEDDOBANCNFSM6AAAAAAWJWHFLE
.
You are receiving this because you were mentioned.Message ID:
@.***>

note for the thread, Notion has requests limits and needs to handle retry https://developers.notion.com/reference/request-limits


feature/#147 - local look-up - first step towards autocomplete text field

Implemented a look-up on the local database, and linked it to the text field.
For the moment, the matching products are only printed in the console.
The next step would be to display the results with an autocomplete text field.
Impacted files:

dao_product.dart: new method List<Product> getSuggestions(String)
home_page.dart: added an onUpdate method on the text field to print the products that match locally

Thank you @stephanegigandet!
@M123-dev If you feel like implementing the actual autocomplete text field, don't be shy! I tried to implement it but faced some issues with the package you recommended. I tried with other autocomplete packages and faced different issues :)
I believe "your" package is a good choice, but I was caught in the middle of UI, init and iOS build issues - I preferred to PR the database part of it now instead of postponing the delivery for days because of the text field part.


[refactor](group commit) refactor group commit wal code

Proposed changes
This pr refactor wal code of group commit, and add some TODO to be fixed in later pr.
Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

run buildall

run clickbench

run p0


Time entries list missing in Macos Desktop 7.4.484

💻 Environment

Platform: MacOS
OS Version: 10.13.6
Toggl Version: 7.4.484 (web install, not apple store)
🐞 Actual behavior
The toggle window shows only the current tasks.
💯 Expected behavior
The toggle window has a list of recent tasks, as shown in https://support.toggl.com/en/articles/2410817-toggl-desktop-for-mac (to be more precise  - https://downloads.intercomcdn.com/i/o/137902648/ec8c4a8087d5add88d6dd5fa/image.png
🔨 Steps to reproduce

Start Toggle
Add a task "foo"
Stop foo
Add "reporting bugs"
Expect to see foo in waterfall.

📦 Additional info

@adamshostack Thank for the report. We have a question about it since I couldn't reproduce it as a new or old user.

When app launch at the first time, do you see the list and empty label? (see the screenshot)

I suppose that for some reason, the size of windows is collapse and set a minimal size, which is the size if Timer Bar.
If it happens, please try to resize the window, I suppose that we can see the list.


add FISTA algorithm and example with deconvolution

SeisConv generate seismic data based on convolution model

Hi Wenlei
this failed. Mauricio


Apply optimizer functions to dask collections

I find myself very, very frequently needing to optimize the graph of a dask array and then put it back into the dask array itself. This is a boring and laborious work, which could be eased with a couple of straightforward changes:

Change the dask collection interface to specify that a collection that defines __dask_graph__ must also specify a copy(dsk=None) method. When it's invoked with dsk not None, the method creates a copy of the collection with a replaced dask graph.
Create a new module dask.collection.optimization which defines cull, fuse, inline, inline_functions:

from ... import optimization as oz
def cull(coll):
    dsk, dependencies = oz.cull(coll.__dask_graph__(), coll.__dask_keys__())
    return coll.copy(dsk=dsk), dependencies

Alternatively, one could modify the current cull, etc. functions to dynamically detect if the first argument is a dask collection - but I find it a bit more convoluted.

Would the dask.optimize function work for you? This runs the default optimization for that collection and returns an equivalent collection. This coupled with optimization customization may yield what you want without requiring us to add additional api.

@crusaderky any update here?  Does dask.optimize work?

Sorry, #3549 has been taking all of my time recently - I still have to figure this one out.

So I assume you mean this:
with dask.config.set(array_optimize=dask.optimization.cull):
    b, = dask.optimize(a)

This COULD work, and removes the need for changing the dask collection interface.
Problem 1
One major problem with writing the above all over the user code is that if there is a typo in array_optimize, there won't be any crash but the user application will slow down. The slowdown will most likely be unnoticeable until you run everything with production-sized data, which is very likely not to happen until very late in a given development cycle (either because of laziness in setting up the CI tests, or because running a whole production dataset costs money).
This could be solved by having dask.optimize accept the kwargs array_optimize=None,              dataframe_optimize=None, delayed_optimize=None:
b, = dask.optimize(a, array_optimize=dask.optimization.cull)

This change by itself however would be useless as dask.array.optimization.optimize, dask.dataframe.optimize.optimize, and dask.bag.core.optimize silently discard any unexpected kwargs:
b, = dask.optimize(a, blah=1)  # this should crash but doesn't

I see the same unused argument **kwargs in all 3 functions; was it deliberate? What's the rationale behind it? Can it be removed?
Problem 2
I'm writing an intermediate optimization function which only needs to tamper with the top level keys (__dask_keys__()). This function will need to be called tens of thousands of time across my application, so I wrote it as follows:
def my_oz(dsk, keys, fast=True):
    """
    Parameters
    ----------
    dsk : dict-like
        Dask graph
    keys: list
        Keys of the graph that need to be preserved
    fast: bool
        If True and dsk is a :class:`~dask.sharedict.ShareDict`, do not inspect
        dicts that are not expected to contain the keys. This is safe only
        if all keys are top-level keys of dask collections and the ShareDict
        was built in a standard way.

    Returns
    -------
    If fast is True and dsk is a ShareDict, a new ShareDict where some of
    the dicts have been replaced with new ones. Otherwise, a new dict.
    In both cases, the original is unaltered.
    """
    def _my_actual_oz(this_dsk):
        """Actual optimization function. Acquires a dict and returns a new optimized dict.
        """
        # snip

    keys = flatten(keys)
    if not fast or not isinstance(dsk, ShareDict):
        return _my_actual_oz(ensure_dict(dsk))

    names = {k[0] if type(k) is tuple else k for k in keys}
    out = ShareDict()
    out.dicts = {
        key_i: (_my_actual_oz(dsk_i) if key_i in names else dsk_i)
        for key_i, dsk_i in dsk.dicts.items()
    }
    return out

The issue is that dask.optimize does not seem to care and blindly invokes ensure_dict on the ShareDict I just returned, nullifying my effort. This would need to be fixed.

Re. problem 1:
I now understand that the dummy **kwargs are there to allow for additional optimization functions using the optimizations param. A poor design IMHO. I don't see how it can be fixed without breaking the API - suggestions are welcome!
Re. problem 2:
This is also for the same reason. Of course when you are going through a sequence of multiple optimization functions, you do want to invoke ensure_dict before you even start.
This could be solved by

removing ensure_dict from the dask.optimize wrapper
adding ensure_dict at the top of all functions in dask.optimization
notifying the users that they need to do the same in their own custom optimization functions, or they'll suddendly receive a ShareDict and perform abysmally slow.

To be clear: none of the above is necessary with a dask.collection.optimization variant of the dask.optimization functions:
from ... import optimization as oz
def cull(coll):
    dsk = ensure_dict(coll.__dask_graph__())
    dsk, _ = oz.cull(dsk, coll.__dask_keys__())
    func, args = coll.__dask_postpersist__()
    return func(dsk, *args)


Integrate SEGGER SystemView

Summary
Integrate SEGGER SystemView so we can use SystemView to track CPU load and gain visibility into the RTOS. The embedded SEGGER SystemView sources were downloaded from https://www.segger.com/downloads/systemview/ and added into a new submodule under the UBCFormulaElectric organization.
Using SEGGER SystemView should now be as simple as:

Updating Git submodules.
Installing it from https://www.segger.com/downloads/systemview/.
Connecting a J-Link and opening up SystemView.

I also removed the old SEGGER RTT and TraceRecorder sources since SystemView comes bundled with RTT, and TraceRecorder integration with SystemView looked difficult (both couple tightly with FreeRTOS). TraceRecorder is also paid, while SystemView is free, so I think we should just stick with SystemView.
TraceRecorder does offer student licenses however, so it might be worth looking into getting one and trying it out.
Testing Done

[x] Tested on old DCM.
[x] More testing on board.

Looks good to me, we should add documentation on how to use SystemView to confluence, I think you're the only person who's used it before

Yeah this could be a good thing to add to the week 3 onboarding, I'd like to rely on this more significantly this year.


Licensing Issue

Question
Currently Reactive Streams dependency has a license of CC0
Issue - Due to some reason the place where I work have some legal issue with the license.

Main concern regarding the license is that patent rights are expressly reserved. The license is only for copyright which eventually creates a risk of an IP claim.

Is there any way if reactive-streams can be offered under Apache-2.0 license??

Was CC0 + patents considered as an option for this library? ( https://wiki.creativecommons.org/wiki/CC0_FAQ#May_I_apply_CC0_to_computer_software.3F_If_so.2C_is_there_a_recommended_implementation.3F )

@reactive-streams/contributors Would it make sense to dual license under Apache V2?

Related: #434.
How do you express in dependent libraries that you have chosen RS with the Apache v2 license?

@akarnokd Good question—and I have no idea. I don't even know if this [patent clauses] is an imaginary problem or not.

I would not mind adding a 2nd license but would be good to get some confirmation legal wise how to pull that off and if we are solving a real issue etc.

I attended a keynote earlier this year by the head of the Open Source Initiative (Simon Phipps), and he talked about the importance of patent grants.
The specific problem that patent grants seek to address is when a contributor who works for big tech company that has a large patent portfolio, makes a contribution, and that contribution, whether it's known to the contributor or not, contains IP covered by their employers patents. A license that contains a patent grant protects the users of that software from that company coming after them with a patent suit.
Applied to Reactive Streams, a hypothetical situation might be one where Microsoft had some patents surrounding Reactive Extensions, and through RxJava and the adoption of those interfaces here, Reactive Streams may have inherited some code or approaches covered by those patents. Using a license with a patent grant would prevent Microsoft from suing any users of Reactive Streams.
I'm not sure that technically, we could retroactively apply any license containing a patent grant to a CC0 project, we would need to first get agreement from all the past contributors that their contributions be made available under a license with a patent grant.

To bring this topic to life again: I'm also working for a bigger company that consults lawyers regarding open source software licenses. Our opinion on this is that reactive-streams could keep CC0 license if you would add a statement like the following to the license declaration and have all authors / contributors sign it:

The author / contributor does not hold any patent or trademark rights connected to the source code of this project. Furthermore the author / contributor does not know of any patent or trademark rights that could be connected to the source code of this project.

This statement helps companies that want to use this project in their commercial software (directly or indirectly via transitive dependencies) to be more on the legally safe side. Please consider this solution.

Chipping in from another company user. Our legal team sees another problem with the following part of CC0:
(4c in https://creativecommons.org/publicdomain/zero/1.0/legalcode)

Affirmer disclaims responsibility for clearing rights of other persons that may apply to the Work or any use thereof, including without limitation any person's Copyright and Related Rights in the Work. Further, Affirmer disclaims responsibility for obtaining any necessary consents, permissions or other rights required for any use of the Work.

Our legal department considers this a huge problem, since it basically says "may contain parts of other works not licensed under CC0"...
Dual- or multi-licensing is pretty simple technically, see jruby as an example. Unfortunately, you probably have to contact all current copyright holders (contributors to this package) if they are okay with such a relicensing (at least if there is no CLA in place which asked for relicensing permission beforehand)

@TobiX While I can sympathize with the concern for the license in itself, remember that we're talking about 4 interfaces where one of them is simple 2 of them joined at the hip. Which code are they concerned about more specifically?

@viktorklang I didn't realize those are only 4 interfaces, I came here after a license review :D
Those are probably even exempt from copyright where I live (Germany)...

@TobiX :D

@TobiX Oh, and also, there's this which converts between those 4 interfaces, and the exact same 4 interfaces which was included in the JDK for Java9. :)

@reactive-streams/contributors @TobiX @skylap @kdani41
MANDATORY "I AM NOT A LAWYER AND THIS IS NOT LEGAL ADVICE" DISCLAIMER.
I'm raising this concern in order to settle this topic once and for all, hopefully. :)
Please read this for background on why CC0 is not OSI Approved:
http://lists.opensource.org/pipermail/license-review_lists.opensource.org/2012-February/001565.html
Moving to something more widely accepted, yet still as permissive as absolutely possible, MIT-0 (a.k.a "MIT: No Attribution") looks promising, and is something which could become OSI approved: https://spdx.org/licenses/MIT-0.html
Is this something that everyone would be fine with? (If we make any modifications to licensing, I'd prefer to only do it once, and then let this rest.) One option is to keep CC0 for everything non-code, and MIT-0 for code, this change would be the least change, while still moving to a "code" rather than "text" license for code.
Thoughts? Opinions? Alternatives?
Cheers,
√

IMHO MIT would be an excellent choice.
Best Regards.

Discussions of CC0 vs MIT-0 seem like angels on pinheads to me. If people would like to placate lawyers, MIT-0 is a fine way to do it.l

No issue with MIT-0, thanks for checking @viktorklang!
@jroper and @TobiX bring up great points about complexities of retroactive re-licensing above. I would advise seeking legal council to confirm the original concerns are being addressed in a way that won't introduce new problems, and the process/impact to the community is well understood.

No issue with MIT-0, thanks for checking @viktorklang!
@jroper and @TobiX bring up great points about complexities of retroactive re-licensing above. I would advise seeking legal council to confirm the original concerns are being addressed in a way that won't introduce new problems, and the process/impact to the community is well understood.

Could a new minor revision be released with the MIT license applied in order to avoid retroactive licensing?
From a license compliance standpoint I can imagine that considering the licence applied to file header/package/library at time of download by the consumer would take legal precedence and what confusion retroactive license application may cause is difficult to judge. (In particular if all code-contributing parties at said download time were not in agreement with said re-licensing and not available to parlay. (I did in fact just re-watch the Pirates of the Caribbean series if anyone notes a peculiarity in this comment.) Savvy.) ... and perhaps a nap is in order. Take care all.

There is some contention as to whether the MIT license constitutes a patent grant, but most agree that it includes patent grant.
But here's the issue - and let's not forget, it's not just a question of what legally works, which to prove requires going to court, it's a question of what a companies lawyers, who when reviewing whether their developers can use this project, will accept. There are 31 contributors to Reactive Streams:
https://github.com/reactive-streams/reactive-streams-jvm/graphs/contributors
Of which I am one. Let's say, I was malicious, and I actually had a patent, and I contributed something that my patent covered to Reactive Streams. I signed the copyright waiver, where I agreed that I was making my contribution under the terms of CC-0. But CC-0 explicitly excludes patent grants, in the summary it says "in no way are the patent or trademark rights of any person affected by CC0". So, I kept my right to sue anyone that uses my Reactive Streams code when I made my contribution.
Now, you decide to re license it as MIT-0, but I never agreed to that. So I still maintain my right to sue anyone that uses my Reactive Streams code when I made my contribution.
Yes, Reactive Streams is only 4 interfaces, but will the lawyers care about that? We have the email address of every contributor, would it be that hard to contact them all and ask them to submit a new PR to a new document that adds their name saying they make their contribution under MIT-0?

MIT is perfectly OK for me =)

Everyone,
the process to relicense to MIT-0 has begun, once all contributors have accepted the relicensing proposal to MIT-0 by adding themselves to Relicensing.txt we can then go ahead and officially update the LICENSE to MIT-0
Thanks for all your input and thoughts on this!

@briantopping @JakeWharton @seratch @kiiadi @Scottmitch Please let me know whether you received the email(s) regarding steps required to re-license to MIT-0.

Hi Victor, I’ll get on this shortly.
Thanks, Brian

On Aug 18, 2020, at 6:51 AM, Viktor Klang (√<EMAIL_ADDRESS>wrote:
@briantopping https://github.com/briantopping @JakeWharton https://github.com/JakeWharton @seratch https://github.com/seratch @kiiadi https://github.com/kiiadi @Scottmitch https://github.com/Scottmitch Please let me know whether you received the email(s) regarding steps required to re-license to MIT-0.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/reactive-streams/reactive-streams-jvm/issues/438#issuecomment-675459217, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABGTIZUAY2X5DRZUTQFD23SBJ2OLANCNFSM4FUZRAJQ.

@viktorklang I'll try to get to this today.

@kiiadi Awesome, that'd be perfect—you're the last signature :)

done : https://github.com/reactive-streams/reactive-streams-jvm/pull/524

Perfect, thanks @kiiadi!

The latest build of ractive-streams is 1.0.3 which is still points to CC0 license in its .pom file.
https://search.maven.org/artifact/org.reactivestreams/reactive-streams
  <licenses>
    <license>
      <name>CC0</name>
      <url>http://creativecommons.org/publicdomain/zero/1.0/</url>
      <distribution>repo</distribution>
    </license>
  </licenses>

Please point here, if there is any build available that fixes the license from CC0 to MIT-0?

@tuxdna There's no published binary with the new license, but nothing prevents you from building your own artifact, or including the sources, until there's a new version published.

@viktorklang I think that is the way to go, until a new release is available. Thanks!


Add base shortcuts

This is part of the request #1645   , it adds shortcuts to the UI
Adding the media control for:
Mute
Volume Up/Down
Play/Pause
Stop
Prev/Next track
Unfortunately  you need to have the window focus to make it work since mediaSession doesnt seems to work with my integration

I've just tested this PR and it was not working, especially not in the subpages.
So back to the drawing board, we might want to look into mediaSession again

@max246 Do you want to progress this?

superseded by #769


Wait till machine config pool is in updated state

Recently we found out that due to mcp is not in updated state, created bundles had issue with machine config like following
Marking Degraded due to: machineconfig.machineconfiguration.openshift.io "rendered-master-5e0b4b6fd5ad9c5c64801e18039b9233" not found

when the mcp is not updated properly
$ oc get mcp
NAME     CONFIG                                             UPDATED   UPDATING   DEGRADED   MACHINECOUNT   READYMACHINECOUNT   UPDATEDMACHINECOUNT   DEGRADEDMACHINECOUNT   AGE
master   rendered-master-5e0b4b6fd5ad9c5c64801e18039b9233   False     True       True       1              0                   0                     1                      3d13h
worker   rendered-worker-e6687df4c217440327c4dc1dcf0f507c   True      False      False      0              0                   0                     0                      3d13h

/test e2e-microshift

/retest

/lgtm
/approve

/cherry-pick release-4.14


Multiarch support

This PR adds multiarch support for nri-kubernetes.

Build pipeline now runs for several GOOS/GOARCH pairs
docker buildx is used to produce multiarch images

rebased main


Request with empty path ignoring query parameters

For example, if I want to get response from www.site.com?q=param, the actual request would be on www.site.com, which is not correct.

Thanks for creating this issue @GrigoriiBerezin. This has been fixed in #529 which is a part of the v<IP_ADDRESS>-RC18 release.
Closing this issue.


Always on top. Add the item to the System menu for all Windows

Description of the new feature / enhancement
It would be nice to give users the option to enable/disable the "Always on top" option for a window via the window's system menu. Because it is often inconvenient to use a keyboard shortcut.
Scenario when this would be used?
The user can enable/disable "Always on top" even if he forgot the keyboard shortcut :)
If the user has forgotten the keyboard shortcut, they can right-click the window title and select this option from the system menu.
Supporting information
Implement it in the same way as it is implemented in Linux (for example Ubuntu).

Have a look at SmartSystemMenu


Swift 5 compatibility

No source changes are needed for Swift 5. I will release an update that marks up the version to 5.0, but 4.2 and 5.0 are identical here.


fix: update to eye v10.20.5

fix: update to eye v10.20.5

:tada: This issue has been resolved in version 16.22.3 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release
v16.22.3

Your semantic-release bot :package::rocket:


docs: Clarify interruption queue setting in docs

Fixes #N/A
Description
Clarifies the interruption queue description in the settings reference documentation
How was this change tested?
make presubmit
Does this change impact docs?

[ ] Yes, PR includes docs updates
[ ] Yes, issue opened: #
[x] No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 82.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
5371

Relevant Lines:
6550

💛  - Coveralls


Increase unit-test code coverage for node remove

Why is this PR needed?
The current code coverage for remove node is low (25.0%). Increase unit-test code coverage helps to enhance feature hardening.
What does this PR do?
Added new unit tests for remove node.
Test Includes:
* should remove master from cluster
* should remove worker from cluster
Other Changes:
* rewording of existing tests
Anything else a reviewer needs to know?
Minor refactor to suit unit-test
Info for QA
This adds unit-test for remove node
Related info
https://github.com/SUSE/avant-garde/issues/823
Status BEFORE applying the patch
Unit test code coverage: 25.0%
Status AFTER applying the patch
Unit test code coverage: 84.4%
Docs
N/A
Merge restrictions
(Please do not edit this)
We are in v4-maintenance phase, so we will restrict what can be merged to prevent unexpected surprises:
What can be merged (merge criteria):
    2 approvals:
        1 developer: code is fine
        1 QA: QA is fine
    there is a PR for updating documentation (or a statement that this is not needed)

Ouch, this PR needs to be rebased on top of master :(


Fix race condition during debugging restart

#142
@AndreSayreMSFT @HuanhuanSunMSFT

Build failed?

Tried build again, and it's halting on ShouldBreakOnBreakPoint.

Looks good!


Added Kadane's Algorithm and Readme in D-Dynamic Programming Folder

Related Issue
-#49
Proposed Changes

Change 1 = Added Kadane's Algorithm
Change 2 = Added Readme for Kadane's Algorithm explaination.

Additional Info

I have used popular problem of Largest Sum of Contiguous Subarray to explain this Kadane's Algorithm better.

Checklist

[ *] ✅ My code follows the code style of this project.
[ ] 📝 My change requires a change to the documentation.
[ *] 🎀 I have updated the documentation accordingly.
[* ] 👀 I have read the CONTRIBUTING document.
[* ] ✨ I have added tests to cover my changes.
[ ] 🚩 All new and existing tests passed.
[* ] 🌟 ed the repo

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Output Screenshots

Screenshot #1
Screenshot #2

Title goes here
Title goes here

Image goes here
Image goes here

A mentor will review this pull request shortly , please have patience.

Please complete your checklist

Let me show you how to check the check list , there should be no space inside brackets like [x]

[x]

Checklist

Or you can just check them from outside without doing any of these

[x] ✨ I have added tests to cover my changes.
[ ] 🚩 All new and existing tests passed.
[ ] 🌟 ed the repo

Starr the repo if you haven't
Have you watched this video

kindly look at the checklist

Mentors Please Review this

Looks good to me @Lakhankumawat

@shivanithorve01  LGTM let's merge your PR 🎉


Add test for get_call

#592  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @rohinb2 and the rest of your teammates on  Graphite


Create sharepoint_sus_link_body.yml

Description
Email links to Sharepoint with either suspicious display text or non-matching link attributes (link does not match any known sender attributes), along with suspicious body text.
Associated samples

https://platform.sublime.security/messages/c4c87f9ccdd831065adce476ee50647b1e0ddf6e172f66fc5a6054bf0d797503

/update-test-rules

/update-test-rules


Issue with bastion creation

Error: Invalid index
on .terraform/modules/base/modules/bastion/datasources.tf line 40, in data "template_cloudinit_config" "bastion":
40:     content      = data.template_file.autonomous_cloud_init_file[0].rendered
|----------------
| data.template_file.autonomous_cloud_init_file is empty tuple

You need to enable the admin host:
admin_enabled = true

You need to enable the admin host:
admin_enabled = true

admin host is enabled and its the same issue

Found out the issue, bastion image id was set to "NONE"
bastion_image_id = "NONE"
correct value should be set to "Autonomous"

Ok thanks. Make sure you don't use Autonomous for admin for the time being.


default_local_values: use the element type of the input values

Codecov Report
Patch coverage: 100.00% and no project coverage change.

Comparison is base (df0d0ec) 84.69% compared to head (e7505e8) 84.69%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #103   +/-   ##
=======================================
  Coverage   84.69%   84.69%
=======================================
  Files          10       10
  Lines        2541     2541
=======================================
  Hits         2152     2152
  Misses        389      389

Impacted Files
Coverage Δ

src/p_vector.jl
88.85% <100.00%> (ø)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Fix setLogFunction(null)

setLogFunction() is typed to take a null value, but this doesn't actually work since it validates that logger is a function.
Change the logic so it only validates when logger is not null.
Looking at how setLogFunction() is used, it seems that it should be called with null instead of a no-op function. If this is contentious that commit can be reverted.

Is the commit convention check complaining about the PR title?!

Thanks for this change! I am happy to take it.


feat: provide temp dir customization

closes #42

:tada: This PR is included in version 3.2.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release
v3.2.0

Your semantic-release bot :package::rocket:


Significant increase in time it takes to run tests on Ubuntu

Summary
With the release of 2.0.0, and the breaking change of swapping to Ubuntu, we saw a dramatic increase in the amount of time it took to execute our custom plugin tests when using Pongo.
We opted to pin to 1.3.0 as that allowed us to get back to our sub 2-minute run time. However, ideally, we'd like to remain up to date with the most recent items added to Pongo.
We believed the increase in time was part of having to install Python, and appears to be (as this fix did speed things up). However, we are still seeing a significant increase in the amount of time it takes to run these tests. Here is the overall run time of our CI job in the different scenarios:

Scenario
Time

When pinned to 1.3.0
1m 58s

When forced to install Python
7m 46s

No Python, currently whats on master
5m 15s

Specifically in regards to the test run times:
Alpine: 50742.63 ms total vs. Ubuntu: 235222.28 ms total.
Options
Would it be possible to support the ability to choose which image you want to run on? I.e. the default is Ubuntu, but i'd like to override that default to run on Alpine.
I attempted this, by hardcoding the KONG_IMAGE to kong:2.8.1-alpine in my pongo run -- however, it fails, as the default shell was also changed to /bin/bash.
Step 20/27 : RUN apt update     && apt install -y zip make jq m4 curl build-essential wget git libssl-dev zlib1g-dev
 ---> Running in 407cbc1f6756
/bin/sh: apt: not found
The command '/bin/sh -c apt update     && apt install -y zip make jq m4 curl build-essential wget git libssl-dev zlib1g-dev' returned a non-zero code: 127
[pongo-ERROR] Error: failed to build test environment

In addition, I'd ideally not like to have to pass in the Kong version into the image -- just specify alpine or ubuntu and it would do the right thing.

I implemented the option to select an operating system a while ago (https://github.com/Kong/kong-pongo/commit/70c4d9d47df84118e9170a745e8f3b938535b511), but we felt that it would complicate pongo and the duplication of the Dockerfiles is a bit bothersome.  We suffer from the long build times ourselves and will try to address it in the near future.

closing this for now.