update UI of deals section

#1419
[Enhance UI of Exclusive Deals]
Related Issue
Fixes: #1419
Description
This PR fixes the issue #1419  by changing theme of Exclusive Deals section.

Type of PR

[ ] Bug fix
[x] Feature enhancement
[ ] Documentation update
[x] CODE CHANGE

Screenshots / videos (if applicable)
Before:

After:

Checklist:

[x] I have made this change from my own.
[ ] I have taken help from some online resources.
[x] My code follows the style guidelines of this project.
[x] I have performed a self-review of my own code.
[ ] My changes generate no new warnings.
[x] I have tested the changes thoroughly before submitting this pull request.
[x] I have provided relevant issue numbers and screenshots after making the changes.

@PriyaGhosal please guide me on how to fix PR Description Check

@Jetshree Please see the conflicts . Resolve the conflicts .

@Jetshree Please see the conflicts .

@PriyaGhosal  I have solved the conflicts and created a new pr. Please check pr #1557


feat: upgrade chrono

I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.
What's changed and what's your intention?
As the title
Checklist

[x] I have written necessary rustdoc comments
[x] I have added necessary unit tests and integration tests
[x] All checks passed in ./risedev check (or alias, ./risedev c)

Refer to a related PR or issue link (optional)
close #6418

Sorry I did not anticipate it would touch this many places. Some suggestions:

We do not need to hard-code 0.4.23 everywhere. 0.4 should be enough.
Enhance the wrapper types so that they help us centralize similar API changes in the future.
Are there places where unwrap is better replaced with proper error handling?

Agree on all of them. 🤣 Probably we can improve this PR before merging.

... it seems that most of the usage of chrono still directly unwrap instead of handling errors?

... it seems that most of the usage of chrono still directly unwrap instead of handling errors?

I design some xxx_uncheck functions to meet xiangjin's second demand. We think it will be easier for us to make similar modification about chrono in the future.
These xxx_uncheck will call unwrap() directly. You can look up where they are used. In most situation when we use these functions of chrono, we know that input will be valid and there will never panic.


fix: use resource_bundles for privacy manifest

This is done to avoid getting build issues with multiple commands trying to produce xcprivacy file in application bundle.
For a more detailed explanation see: https://github.com/google/promises/pull/226#discussion_r1447871477

Hi guys I'm afraid this doesn't work. I just tried to install version 6.2.1 to our project and it still seems to collide with our main app's PrivacyInfo.xcprivacy. Here are the changes when installing, I notice there's PrivacyInfo.xcprivacy line added in our [CP] Copy Pod Resources.

Meanwhile with other SDKs, installing them doesn't that line, it'd be SDK.bundle or SDK_Privacy.bundle only

Could you guys help to take a look?

@harrynguyen22 could you share more about the error via a screenshot? Maybe a sample app with just the CT SDK?

hi sorry false alarm, turns out it's due to another SDK which is SVProgressHUD, I'm checking the comments there. Thanks for the response tho.


Incorrect information regarding subnet integration

Line:
"The integration subnet can be used by only one App Service plan"
is incorrect / outdated.
When I have an app service in an app service plan integrated to a subnet, if I create an empty app service plan and move the app service, vnet integration remains functional.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a7a98803-1438-b1b5-f543-7dd88bc4294e
Version Independent ID: 37ff1d0f-ed8e-5e4d-1f4c-1b9f6cffb938
Content: Integrate app with Azure Virtual Network - Azure App Service
Content Source: articles/app-service/web-sites-integrate-with-vnet.md
Service: app-service
GitHub Login: @ccompy
Microsoft Alias: ccompy

@crystalgeek, Thanks for the feedback! We are taking a look into this and will get back to you soon.

crystalgeek, Apologies for the delayed response! We have raised a PR on this and have submitted for author's review. Upon review and merge, the doc would reflect the appropriate changes.  Thanks again for taking time to share your feedback on this, we will close this for now, if you have any further questions this topic, please tag me in your reply.

crystalgeek, The statement in the doc is correct '"The integration subnet can be used by only one App Service plan" - You can only have one app service plan using the integration subnet. If you have any questions, please let us know. Thanks again for your feedback.

@AjayKumar-MSFT
I experienced the following scenario
Create an app service plan (A)
Add multiple App Services
Associated app services with subnet
Create new app service plan (B)
Move a single app service to new app service plan (A to B)
Vnet / Subnet integration remains on both app services in app service plans A & B
If I create a new app service in app service plan B - I can not integrate this to the same subnet as the app service that was moved from A to B.


[epic] Overhaul theme and UX of site for alpha launch (May 2017)

Do another round on site UX and have everything working (=> hiding/removing things that are not yet working well enough like publishing).
Acceptance Criteria (for epics or "big" issues)

[x] Site looks awesome
[x] Nothing left that is not working

Tasks

[x] showcase page - #363
[x] Front page @shiewie @anu

[x] Redesign
[x] Show Best packages and Examples packages - #364

[x] Tidy up examples @irakli @meiran - #333

[x] Publishing section (and explain it is coming soon)

[x] Design @shi

[x] Theme

[x] Navbar - change the links

[x] Find data search box should just be a link
[x] API should move into footer (if it is anywhere) - not relevant for most users
[x] Sign in / sign up should be redirected in some way (see below on disable publishing stuff)

[x] Footer - with logos

[x] Disable publishing stuff

[x] Disable sign up

A: Just hide it all!
B: redirect to "give us your email" info (probably on front page down below ...)

[ ] About section (low priority)

Explain what this is, who is behind it etc

[x] General UI - https://github.com/frictionlessdata/dpr-api/issues/330
[x] Search page #375

FIXED - browse the website for current look:
https://staging.datapackaged.com/

Current website look:


Add minimal version of the agent command

Fixes https://github.com/jetstack/preflight/issues/85
Fixes https://github.com/jetstack/preflight/issues/86
This is my go at the most simple implementation of the above issues. We needed an agent with some config. All the config parts are in place to run datagatherers and upload data.
Why did I not use the existing preflight yaml? Wil is working on this today - I would have needed to add a more fields to the config. I might well end up using what Wil refactors but this allows the work on the agent to continue either way.

I have mixed feelings about having the agent baked into the same binary than the "normal" CLI. Let's do it like this for now as it seems to simplify things.

/lgtm


Add support for preferred_element_type arg in convolutions

XLA recently added support for integer convolutions on CPU in https://github.com/tensorflow/tensorflow/commit/89fc1ddd96f25aa9d8eb6a0104ca1fdb11b26753.
This PR adds support for the preferred_element_type parameter in the conv, conv_general_dilated, conv_with_general_padding, conv_general_dilated_patches and conv_transpose which is passed through to XLA.
This PR is analogous to #5213 which added support for preferred_element_type in lax.dot.
Please note that I don't know if this has any implications for GPU since GPUs don't have support integer convolution yet, but hopefully CI will catch any potential problems related to GPUs. Please let me know if I am missing something.
Do you know if there is a timeline integer GPU convolution support in XLA which would be very useful for research on quantized neural networks?

Thanks for the fast review 🚀
I improved the dtype checking in 2ec096d08f5220fc299ba807b767f36777a4a66e and extended it to also handle complex types.

@jakevdp Out of curiosity, do you know whether there is support for integer convolutions on GPUs planned in XLA? I think this could be incredibly useful for research on quantized neural networks if XLA is able generate fast integer kernels.

do you know whether there is support for integer convolutions on GPUs planned in XLA?

I'm not certain... I see you're already following #4012 which is probably the relevant issue for that.

@lgeiger I have not seen integer convolutions in the plans for GPU for the next quarter. Have you filed a feature request with XLA?

I wasn't aware of the complex number support so 7870ecb0c48f9d2753f322270b56c811cdfd4bf1 fixes the handling of complex numbers when expand_complex_convolutions=True and extends the unittests.

I have not seen integer convolutions in the plans for GPU for the next quarter. Have you filed a feature request with XLA?

Thanks for the info. No, I haven't filled an issue yet. Would tensorflow/tensorflow be the right place for this?
I've only seen a reference to an internal issue so far:
https://github.com/google/jax/blob/0f1ddf6dc39ea29d39b256d4009406c6c1c5c844/tests/lax_test.py#L496

Final request: can you squash all the changes into a single commit and force-push to the branch?

Ah sorry missed that, I thought that would happen during merge via GitHubs "Squash and merge" option. I rebased the PR and squashed everything into one commit.

It looks like this is causing some failures in jax2tf, because it doesn't handle the new preferred_element_type argument (these tests are not currently run in by the github CI).
You can run them locally by making sure you have the most recent version of tensorflow installed, and run pytest -n auto jax/experimental/jax2tf/tests

It looks like this is causing some failures in jax2tf, because it doesn't handle the new preferred_element_type argument (these tests are not currently run in by the github CI).

:+1: I updated jax2tf and rebased the PR.  Let's see what CI thinks

Thanks for the help. I updated the tests to handle the complex cases on GPU and TPU.

Thanks for sticking with this! Looks like we can get this merged now.

Thanks for sticking with this! Looks like we can get this merged now.

Sure, thanks for the help and the fast review. Really appreciate it 👍

I have not seen integer convolutions in the plans for GPU for the next quarter. Have you filed a feature request with XLA?

For reference, I now opened an issue at https://github.com/tensorflow/tensorflow/issues/49140


Error when trying to create videos from CS2 matches

Describe the bug
Trying to create a video export from a replay results in the following error and no replay being recorded:
Sun, 03 Dec 2023 12:14:18 GMT | LOG | server | WS:: game process socket disconnected 1006 { type: 'Buffer', data: [] }
Sun, 03 Dec 2023 12:14:28 GMT | ERROR | server | Error while generating videos
Sun, 03 Dec 2023 12:14:28 GMT | ERROR | server | Error: ENOENT: no such file or directory, scandir 'C:\program files (x86)\steam\steamapps\common\Counter-Strike Global Offensive\game\csgo\csdm\movie'
Sun, 03 Dec 2023 12:14:28 GMT | LOG | renderer | WS:: message with name "videos-generation-error" received from server
Sun, 03 Dec 2023 12:14:39 GMT | LOG | server | WS:: renderer process socket disconnected 1001 { type: 'Buffer', data: [] }

Demo links
No response
Steps to reproduce
Start application, select demo, go to video tab, create or autogenerate a sequence and record it, cs2 launches but stays in the main menu, the mentioned error appears in the UI as well as the log
Expected behavior
Demo is recorded and converted to video
How often does this bug happen?
Every time
Log file
No response
Environment information
Version: 3.0.1
OS: win32 x64 10.0.22631
Electron: 27.1.3
Chrome: 118.0.5993.159
Last database migrations:
v1 - 2023-12-03T12:39:02.663Z
Additional context
No response

Thanks for the report!
It will be fixed in the next version.

Thanks for all the hard work :)

I'm not sure if this is actually the same issue or potentially a different one but I'm still unable to get demo recording going:
Full logfile of 3.0.2 is attached at this post.
csdm.log


2252880(me-leader)_2252442_2213973_2252608

Algorithm:

Pattern Generation - Branch and Bound: Generate various "patterns" (cutting layouts) and then select the most optimal pattern that maximizes the utilization of the stock’s area.

First-Fit-Decreasing (FFD): Find the smallest stock that can fit all (or most) of the product in the sorted product's list.

Result:
PG-B&B:

FFD:

Please revise the PR in Dec 16. Otherwise, your group will get 0 score for code.

I am truly sorry for seeing this comment this late, please give us a chance to fix and merge

I am truly sorry for not checking mails frequently, please give us a chance
to submit the assignment. I have made a new pull request and fix the policy
name and conflict. Please forgive us.
Vào Th 3, 17 thg 12, 2024 lúc 8:17 CH Duc Quang Nguyen <
@.***> đã viết:

Close PR as it does not comply with the submission guidelines.
—
Reply to this email directly, view it on GitHub
https://github.com/martinakaduc/MM241-Assignment/pull/281#issuecomment-2548438343,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BENDA4BVGELNQOOWGTZ4IZL2GAP75AVCNFSM6AAAAABTUSKOZCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNBYGQZTQMZUGM
.
You are receiving this because you authored the thread.Message ID:
@.***>


add a future specfication 3.0.2.md fix issue/1449

Fixes #1449

Hi @weimengxi, I've tried to change the base branch of this PR to the v3.0.2-dev branch, but it created conflicts. Please could you resubmit as an edit to the versions/3.0.2.md file on that branch, as per the  the development guidelines?


Disable Lint/MissingSuper rule

Closing in preference of https://github.com/davidrunger/runger_style/pull/18 , to which I have cherry-picked this PR's commit.


IDEA: interactive_similarity()

Interactive function that allows the user to click points on plot area, the hit esc and:

Visualize vectors,
Obtain a data frame of coordinates,
Obtain a recommendation matrix.

Additionally a function "plot_similarity" would be created to make the plotting possible, and it could also be used to plot the vectors from a given set of data points.


updating checkout page

making things look nicer and more user friendly

hotkeys
made buttons look nicer
made increment/decrement look nicer
added item search by name
made responsive (different layout for xtra small screens

wow


Redshift fails to access location services

When logging into any desktop session, redshift produces the failed to retrieve location information. The current redshift config uses manual mode, but the error is still present. Why didn't this happen when aludra was upgraded to 20.04?
Also, when logging in to i3 session, there are 3 instances of redshift running. One is from i3 config and there are two others that get restarted even after kill -9.
Right now, redshift has been uninstalled because the errors never go away and while the error message is present, the CPU is maxed out.

Made some progress that seems stable

Removed `exec --no-startup-id "sleep 3; redshift-gtk" from i3 config
Removed ~/.config/autostart/redshift.desktop

Overcoming "failed to connect to geoclue-2.0"

Added redshift entry to /etc/geoclue/geoclue.conf. Did not work.
Added exec --no-startup-id /usr/libexec/geoclue-2.0/demos/agent to i3 config (thanks to this comment)
Started redshift and redshift-gtk manually and no errors for geoclue-2.0, but now config file was not being read correctly.

Overcoming "permission denied" when reading config file

Tried these locations for config, all resulted with fopen: Permission denied

~/.config/redshift/redshift.conf (v1.12 preferred location)
~/.config/redshift.conf (v1.11 preferred location)
~/redshift.conf (tried with -c option)
/etc/redshift.conf (v1.11 and v1.12 system default, if present)

Found this thread which suggests that the changes in v1.12 do not play nicely when app is packaged by distros.

Suggested work around was to use the preferred location in v1.11, ~/.config/redshift.conf. I tried this but still didn't work.

Still based on the same thread, decided to compile from source
uninstall redshift
Added the following packages
- autopoint
- intltool
- libdrm-dev
- libxcb1-dev (already installed)
- libxcb-randr0-dev
- libx11-dev (already installed)
- libxxf86-dev
- libglib2.0-dev
- libtool
- geoclue-2.0
Built redshift from source, checked out to v1.12

Download and apply Ayatana AppIndicator3 patchcurl -o 757.patch https://github.com/jonls/redshift/pull/757.patch
git am 757.patch

Do the build./bootstrap
./configure
make
sudo make install

During the build, bootstrap compailed about configure.ac:15: error possibly undefined macro AC_PROG_LIBTOOL ....

Thinking that some of the libraries needed for autoconf were not where they were supposed to be, created symlink ln -s /usr/share/aclocal /usr/local/share/aclocal. Did not work
Then tried installing libtool. That worked.

Restarted and redshift worked as expected. Except the indicator is not the same one that Ubuntu Mate uses.

It seams that compiling redshift from source added ~/.config/autostart/redshift.desktop back. So there is no need to keep it in the i3 config?

Todo

[ ] Update packages.csv
[ ] Remove redshift from /etc/geoclue/geoclue.conf to see if it is needed.
[ ] Create systemd service to start geoclue-demo-agent after geoclue-2.0.service
[ ] Add redshift as submodule. Add build steps.
[ ] Investigate how to restore app indicator icon to be the one that gets used when install from Ubuntu repo.
[ ] Determine if Ayatana AppIndicator3 patch needs is applicable to aludra.
[ ] Determine how to restore geoclue usage to jet. Converted to manual mode late last year due to geoclue connection error. Maybe starting the demo agent as a service will fix the problem?

Redshift does not need an entry in /etc/geoclue/geoclue.conf
redshift-gtk is only started on first login. If I log out and log back in, redshift-gtk does not start.

[ ] Get redshift to always start on every login.

To enable app indicators like the ones that are installed from the Ubuntu repo, need to call ./configure with --enable-ubuntu.

Copied redshift-gtk.service from redshift/data/systemd after build to ~/.config/system/user/. Updated to restart elements under Service so app would restart correctly after first login.

Everything appears fixed. Will push changes once other issues have been fixed.


Upgraded dependencies

Previously there were 12 security issues with npm modules that were
dependencies of the wallet app. After this commit, there will be only
five security issues. This commit upgrades most of the npm packages
to new versions. An effort will still need to be made to upgrade
submodules dependencies to make sure the app is free of any security
issues.

This branch is having problems building android. Btczgod is working on resolving the android issues, so we will wait until he has a build working and rebase off that branch.

Sounds good.

Android issues should be resolved now.


Immediate redirect to Provider signIn

Describe the feature
We're aiming to implement a unified authentication experience across our two Nuxt applications, which are hosted on separate subdomains. The primary application is available at example.com, while the secondary application resides at app.example.com. Additionally, our Keycloak authentication server is hosted on auth.example.com. The goal is to facilitate a smooth user journey where a user can log in once at example.com, and then navigate to app.example.com via a button click, all while remaining authenticated.
Currently I can login at example.com then redirect to app.example.com (with globalAppMiddleware activated). I will then get the nuxt-auth Sign In page where I can click the button "Sign In with Keycloak" and I'm logged in since all the cookies and request headers are set correctly. Would it be possible to add a configuration to skip the signIn page and immediately redirect to the keycloak login?
Maybe I'm overseeing something and it's already possible to achieve this but I couldn't find anything about it.
How would you implement this?
No response
Additional information

[ ] Would you be willing to help implement this feature?

Provider

[X] AuthJS
[ ] Local
[ ] Refresh
[ ] New Provider

Nevermind, I achieved the wanted behaviour by just intercepting while bootstrapping and calling useAuth.signIn

I am unsure why this issue was closed, as it seems the behavior is not aligning with the documentation provided here. According to the documentation, setting the defaultProvider should redirect unauthorised users directly to the provider’s sign-in page instead of displaying the app-login page.

Additionally, I wanted to note that this behaviour worked as expected in version 0.7.2, but there seems to be a regression in version 0.8.0.

Additionally, I wanted to note that this behaviour worked as expected in version 0.7.2, but there seems to be a regression in version 0.8.0.

Thanks for catching this! I had yet to notice this. I reopened the issue and will investigate the issue!

Hi @dhondtlaurens 👋
I just tried to reproduce the error you outlined above and could not reproduce the issue. Here is the link to my test playground for this issue: https://github.com/zoey-kaiser/nuxt-auth-starters/tree/721/test-default-provider/starters/authjs-github
I set defaultProvider to github and when I navigated to a protected page, I was redirected to the Github OAuth connection page. (r1).
Would you be so kind to create a reproduction of this error? You are welcome to clone the repository I linked above and attempt to reproduce the issue 😊
R1:
https://github.com/user-attachments/assets/f5aae2fd-ea5c-4aa5-a63f-c213962cc225

Hi @zoey-kaiser 👋
I’ve successfully reproduced the issue. You can find the forked repository I used for testing at this link: https://github.com/dhondtlaurens/nuxt-auth-starters-issue-735.
In my setup, I configured the defaultProvider to github in nuxt.config.ts and disabled the custom sign-in page in [...].ts. With globalAppMiddleware enabled, unauthenticated users are redirected to the GitHub OAuth page when clicking on the Secured Page link. However, if navigating directly to http://localhost:3000/secure, the app-login page is displayed instead. (R1)
Additionally, I encountered the following error when navigating directly to the secured page:
[nuxt] [request error] [unhandled] [500] The first argument must be of type string or an instance of Buffer, ArrayBuffer Array, or an Array-like Object. Received an instance of URLSearchParams

R1:
https://github.com/user-attachments/assets/9a6104d8-05c1-42b1-b1f2-88fab50d4456

Hi @dhondtlaurens 👋
Thanks for the fantastic reproduction! The only difference between our setups is that I did not remove the custom login page! I'll test out removing that from my app, too; otherwise, I work based on your reproduction!
Ill have some time tomorrow and keep you updated on the progress!

Hello, any progress? I'm implementing IBM Verify and I wanted it to be redirected directly to the provider, and I'm also getting the error mentioned above:
ERROR  [nuxt] [request error] [unhandled] [500] The first argument must be of type string or an instance of Buffer, ArrayBuffer, or Array or an Array-like Object. Received an instance of URLSearchParams

Hi @zoey-kaiser
Thank you for your continued support with this issue. I wanted to check in to see if there have been any updates since I provided the reproduction. If there are any plans to address this, I’d be happy to assist further in identifying the issue or working on a fix. I appreciate all the effort you’re putting into resolving this.
Looking forward to your feedback.
Best regards,
Laurens D’Hondt

Hi @dhondtlaurens 👋
I have this issue on my TODO for the next steps after the last 0.9.0 release! I was sadly still pretty busy with the changes for that release and deprioritized this, as it needs a small investigation! Ill keep you posted 😊

Hi, this happens for me in the Middleware, I suspect initially the page doesn't set the CSRF cookies and thats why app login page instead of the provider login page. There is a similar issue #928


Documentation fix. Change configuration file from laravel-backup to l…

…aravel-medialibrary

Thanks!


What should an Appointment card display?

The Appointment class has datetime fields. This should be displayed.
It should also display some fields of its linked Person. Which fields should be displayed? Name?

Should be resolved already, @minreiseah can close this issue?

Closed @chengjunyuan.


TypedPropertyFromToOneRelationTypeRector should taken into account parent definition

Demo https://getrector.com/demo/7b7afb36-937e-4e66-8561-c9a0ea2cc01a

Thank you for your report and demo link!
We'll need a failing test case in a pull-request, so we have it covered in Rector.
You can click "Create a Test" button at demo page.


Slow graph loading on heroku

It seems that the loading of the graphs is very slow in Heroku app (R version). Probably it runs in single thread and only fetches each app callback at a time. Suggest to explore grouping the charts in one single callback function.
Docs to reference: https://dash.plotly.com/r/basic-callbacks#dash-app-with-multiple-outputs

This is implemented by #13


Alternate delete method workaround, from IG staff

Delete doesn't work unless you use this workaround: https://labs.ig.com/node/36
This pull request factors this in to the request() method.

@wagerfield can you please merge this pull request in?
without it, it's impossible to close trades - which kinda makes automated testing pointless...


Adding typescript definition file

Brief description of the changes [REQUIRED]
Adding TypeScript definitions allows integration with TypeScript based projects
What browsers and operating systems have you tested these changes on? [REQUIRED]
N/A
Are all automated tests passing? [REQUIRED]
I haven't written tests for this yet
Is this pull request against develop or some other non-master branch? [REQUIRED]
yes

I'll make this as "in progress" for now. Please do let me know when you have a question or need a code review.

Related #1688.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Sukhdeep Singh seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.

The element and template options are not listed in core api options, but they are needed if the id of the element is different than default.
I think they should be listed on the api core options page along with others.
Also, in fine-uploader.spec.ts fle, If I use the 'new' keyword to instantiate FineUploader, TypeScript is complaining.
If I don't use the 'new' keyword, things seem to be okay. I'll do more testing once I'm done writing everything

http://docs.fineuploader.com/branch/master/api/options-ui.html#thumbnails.placeholders
the notAvailablePath option is listed twice

Thanks for finding that issue in the docs. I'll push a fix for that next.
Regarding new - you definitely have to new up a qq.FineUploader instance. Not doing so will result in a function return type, and, as a result, you won't be able to access any API methods. Also, the internal code expects qq.FineUploader to be properly constructed, otherwise the value of this will be window instead of the qq.FineUploader instance.
Not sure if Typescript provides some magic that makes new unnecessary. I'm not very familiar with the language myself.

http://docs.fineuploader.com/branch/master/api/options-azure.html#signature.endpoint
In description here where it says "The endpoint that Fine Uploader can use to send GET for a SAS before sending requests off to S3"
I think instead of S3 it should be Azure.

Thanks for catching that. Fixed!

Note that your branch should be based off of Fine Uploader develop

I see that you have changed the base branch from master to develop.
I should have forked from develop.
Is there anything else I need to do to base off of develop branch?
In this thread I'm seeing this message
Add more commits by pushing to the master branch on SinghSukhdeep/fine-uploader.
Which branch should I push my changes now?

it probably doesn't matter much since, at the time you forked, master and develop were identical.

http://docs.fineuploader.com/branch/master/api/qq.html#qq.each
the description for parameter iterable is incorrect.

I'd suggest leaving any of the qq util functions out. I'd like to remove those entirely in a future major release.

Okay, well so far I've written about 80% of util functions already. I'll take them out then.
If there is anything else you have in mind which is to be removed in future releases, please let me know before I write it all.

Sorry. If you're almost done with util functions, you are free to proceed. I can just remove them once 6.0 is released, which may not be for a while anyway.
I'll fix the docs for qq.each too.

docs are updated

I've written down everything that is there in the API's.
Please do a code review when you get a chance.
I'm gonna do some testing meanwhile and will push if I find any issues.
Thanks 😃

I'll try to take a close look in the next few days. Other than creating the definition files, what else, if anything, needs to be done to ensure Fine Uploader can be used w/ TS in an Angular2 project? I'm also wondering how these TS def files are picked up.

Creating a definition file enables the use of FineUploader in any TypeScript project.
Angular 2 is itself written in TypeScript, so this facilitates the use of FineUploader in Angular 2 project as well.
But still, something like import qq from 'fine-uploader' won't be possible, because that requires class declarations and named exports. (To do that, I'll need to do some more research).
So now with TS def file, If someone wants to use FineUploader, they can just have the FineUploader JS globally scoped and just start writing TypeScript.
Here is how we can publish our TS def file.
Let me know and we'll proceed further.
TS def files are picked up automatically by TypeScript aware editor such as Visual Studio Code (which I've used to write declarations), we just have to publish it properly.

TS does support CommonJS modules.
I can do let qq = require('fine-uploader') and it will work fine.
But to use the import syntax, A library needs to have an index file at the root which would do named export of ES6 modules.
I can get an Angular 2 project working using the require syntax, but I won't be able to generate a production bundle using Rollup, which needs the import syntax rather than require to effectively apply tree-shaking.
Having said that, I wouldn't call myself a GURU on those things, but that's what I've figured since I've been working with TS and Angular 2

But to use the import syntax, A library needs to have an index file at the root which would do named export of ES6 modules.

The package.json file already handles this.

I'm currently trying to follow the TS module resolution
Following that, if I place my TS def file index.d.ts in the node_module/fine-uploader/ directory
and place a default export in index.d.ts like this
declare var qq: FineUploader.qq;

export default qq;

then the import qq from 'fine-uploader' seems to be okay.
I need to do some more work/research/testing on it to make sure things go well all the way up to generating a production bundle using Rollup.
I'll keep you posted

I'm guessing exports will be needed for all Fine Uploader builds, similar to what already exists in the lib directory.

Ok so, I've done some basic testing in a dummy Angular 2 app and everything seems to be working fine.
Not doing any named imports/exports as of now (need to do more research on it to make it work), just including fine-uploader.js globally.

Sorry, haven't gotten around to reviewing this yet. Hopefully over the U.S. holidays I'll find some time to do so.

something appears to be wrong here. the changed file list seems to be missing a number of files.

Okay, I'll push all my changes to the develop branch and change the fork's base branch to develop.
Is that what you're saying?

Yes, I think that will fix the issue

doesn't look like that worked - you can see in the "changes" tab at the top of this PR. Looks like a new PR is needed instead.

The changed file list shows two files changed (which is all what I've added), I'm not sure what is missing?

Oh, ok. The def file was not automatically expanded in the diff viewer due to its size, which is probably why I overlooked it.

Just started to look at this again. Sorry for the delay, but I'm only able to pick up a few minutes here and there for the foreseeable future.
What exactly is typescript/fine-uploader.spec.ts?

Just started to look at the definition file. I can safely say that I'll never have enough time to review all of that, nor will I be able to verify since I don't use TS in any projects. So I'm included to just merge this through. But I'm wondering - how do projects pick up this definition file? How does TS locate this? Where does it have to reside inside of the package retrieved from npm?

The typescript/fine-uploader.spec.ts is just a test file showing the use of proper syntax in TS.
About how will TS pickup the def file please read this
Either we put the def file in a directory and point "types" property in package.json to that path or we just put the file at the root and name it index.d.ts or we publish it separately from the project under Github's DefinitelyTyped and then users can install the def file as npm install @types/fine-uploader.
I'm currently using it as if installed using third option.
The def file will be then located at<EMAIL_ADDRESS>They do recommend the first approach though.

Fine with the first approach. To complete this:

[ ] update to package.json as specified in your last message
[ ] update to Makefile to ensure the proper TS files are included in the zip files & the npm package. It's probably best to include these in the /client/commonJs directory in the source tree. The contents of that dir will be included in the lib/ dir in the npm package.

I think it would be nice if a feature page was created or something somewhere in the docs was updated to reflect TS support.
Related: Are you interested in becoming a contributor for this project? Seems you now have a better understanding of the API than most at this point.

As of TS v2.1, the first approach seems to be working properly (Wasn't working before, that's why I was using @types approach).
I'll review the def file once more and will let you know when I think everything is okay.
And yes I have no issues with becoming a contributor. What do I have to do in order to be so?

My bad, I can get it working only by using @types approach.
TS compiler is complaining with other two ways, It has something to do with the way fine-uploader file structure is.
Works only if I put the def file at<EMAIL_ADDRESS>I have to do some more digging on this

@SinghSukhdeep Was wondering if you have any updates on your progress, or if you need anything from me?

@rnicholus sorry didn't get any time during the holidays and had some tight deadlines before that, will have some time this week to look at it.

No rush at all. Just checking in.

Please merge this!

@SinghSukhdeep Just wanted to bring to your attention DefinitelyTyped/DefinitelyTyped#13768. It just came onto my radar a few days ago. It's not clear to me how this affects your efforts here. Was wondering if you had some comments.

I looked at it, they are also preparing a similar definitions file as we are.
Maybe somehow we can merge their progress with ours and get someone to review our code.
About removing a package, once we publish fine-uploader with the definitions included, then they can deprecate that package, we don't have to do it.
In this pull I need to set the types property to point to our bundled declaration file in order to locate the definition file, which I haven't done yet as I'm unable to get it to work that way.
I've looked at some of the TS docs but haven't found a resolution to the problem yet. I'll keep looking

Hi @SinghSukhdeep, I'd be willing to help, but could you explain to me the way this library is used? On the DefinitelyTyped tests, everything uses a qq global variable. But the NPM package appears to have module.exports. Can this library be used as a module?

The library can be used as a module. Examples/details at http://docs.fineuploader.com/branch/master/features/modules.html.

After looking at this closer, could it be that the definition file is not included with the packaged library, and that is the cause of this issue? The entire source tree is not published to npm. There is a build step that only includes the bundled code and a subset of the project root. This is something I mentioned in a comment a while back.

@andy-ms okay got it, I also came to this resolution because I'm not using the library as a module and I was missing that triple slash directive.
Including the dependency like that does the job.
Thanks for your help.
Any chance someone can review our code before we publish the package?
I would really appreciate that.

@SinghSukhdeep I think you did some really nice thorough work here.
@rnicholus I think we need to set up CI for this TypeScript component. Treating the TypeScript definitions as first class is much better than having it maintained in the DefinitelyTyped repository, and I'd be happy to contribute. Would it be possible to have a feature branch that both @SinghSukhdeep and I could work out of?

I'd be happy to add you both as contributors to fine-uploader. Then, this PR could be merged into a local feature branch where work could continue. How does that sound?

Sounds great to me

I've sent both of you invitations. In order to bring this into the repo without merging it into develop (since it's not complete yet), I think the next steps should be:

Create a new branch in this repo based off of develop.
Change the target branch of this PR to the branch created in step 1 & merge it in.
Open up a new PR and begin to collaborate and make changes on the branch created in step 1. Please reference this PR in the new one.

Everything done. New PR #1719


Standardisation of data in example head.npy provided

I see in the example head data snippet provided for the Traj_Generation.ipynb that some of the columns have been standardised (all bar the first and last two columns pertaining to time start interval, sid, and eid).
Is this something we have to do to the input head dataset for the model? I am trying to replicate your results on the Chengdu dataset, but do not have access to the head.npy dataset so am deriving it from the trajectory dataset. Thanks in advance.

Hello, I'm just following the general practice here. I think it can isolate the effects caused by the numerical magnitude of the different attributes.

Could you please provide the calculation method of head.npy? Thanks in advance.


WindowsIdentityLayoutRenderer not disposing WindowsIdentity

Hi!
I think WindowsIdentityLayoutRenderer should dispose WindowsIdentity instance in Append method.
NLog version:
4.7.15
Platform:
.Net 4.5

Yes always wondered why it was never diposed, since it would leak SafeHandles, that would fill the finalizer queue.

WindowsIdentity.GetCurrent() returns an instance which you should dispose, otherwise you temporarily leak a user handle. (Its a safehandle so its not a huge deal). Infact, most times you use WindowsIdentity it is good to dispose of the item. Except for one case.

If you call Impersonate() on a WindowsIdentity instance, disposing it will cause hard to diagnose crashes.

Have now created #4867


Update MacOS .NET 7: Series: Get started with ASP.NET Core MVC

Internal Review - 1 - Get Started
Fixes #27383
Fixes #28215
Update the 10 tutorials in the Get started with ASP.NET MVC series for MacOS and .NET 7.
Update and verify instructions, screenshots, code and includes.

Closing and reopening to force build...

Closing and opening to force a rebuild.  New content changes are not showing.

@tdykstra, all suggestions in!  Thanks for the great detailed review of all the tutorials.


Fix a few other issues in the user-state doc

This PR fixes a few typos and a minor issue in the script at the bottom. Continuation of PR #353 .

Also improved the formatting of the metadata doc.


Indra Client: Unrecognized field "mt"

Indra Version: lambdacube/indra:2.0.2 (docker)
Indra Client Version: 2.0.3-rc 24ef31f
javax.ws.rs: 2.0.1
Jersey: 2.25.1
Jackson: 2.8.6
Problem
Request gets serialized with unrecognized field "mt"
Request:
RelatednessPairRequest request = new RelatednessPairRequest()
                .corpus("googlenews300neg")
                .language("EN")
                .scoreFunction(ScoreFunction.COSINE)
                .model("W2V")
                .mt(false)
                .pairs(pairs);
WebTarget webTarget = this.client.target(this.url);
RelatednessPairResponse response = webTarget.request().buildPost(Entity.entity(request, MediaType.APPLICATION_JSON_TYPE)).invoke(RelatednessPairResponse.class);

Debug output:
1 > POST http://<IP_ADDRESS>:8916/relatedness
1 > Content-Type: application/json
{"corpus":"googlenews300neg","model":"W2V","language":"EN","mt":false,"applyStopWords":null,"minWordLength":-1,"scoreFunction":"COSINE","pairs":[{"t1":"mother","t2":"love"},{"t1":"father","t2":"love"}]}

Nov 09, 2017 8:29:16 PM org.glassfish.jersey.logging.LoggingInterceptor log
INFO: 1 * Client response received on thread main
1 < 400
1 < Connection: close
1 < Content-Length: 421
1 < Content-Type: text/plain
1 < Date: Thu, 09 Nov 2017 19:29:16 GMT
Unrecognized field "mt" (class org.lambda3.indra.client.RelatednessRequest), not marked as ignorable (7 known properties: "minWordLength", "corpus", "language", "model", "pairs", "applyStopWords", "scoreFunction"])
 at [Source: org.glassfish.jersey.message.internal.ReaderInterceptorExecutor$UnCloseableInputStream@8d36676; line: 1, column: 70] (through reference chain: org.lambda3.indra.client.RelatednessRequest["mt"])

javax.ws.rs.BadRequestException: HTTP 400 Bad Request

	at org.glassfish.jersey.client.JerseyInvocation.convertToException(JerseyInvocation.java:1011)
	at org.glassfish.jersey.client.JerseyInvocation.translate(JerseyInvocation.java:819)
	at org.glassfish.jersey.client.JerseyInvocation.access$700(JerseyInvocation.java:92)
	at org.glassfish.jersey.client.JerseyInvocation$2.call(JerseyInvocation.java:701)

Hi @blang, thanks for the notification. In fact, we are working on a new high-changed version, which is expected to be ready in few days.
I guess the commit f81cfb423f012e2476134de0617996f3067d14fe from my fork (branch pp_filter) is free of bugs. It might be useful for you now.

Hi @julsal, thanks for the quick response. I'll have a look at the commit you mentioned.
It's pretty late in my project so i just need a stable pair relatedness.
I managed to get the request working by crafting the request by myself now which was the quickest option now.
The only question remains if the backend (lambdacube/indra:2.0.2) is stable in this situation (only pair requests)
Any experience with this version?
To use your commit f81cfb4, is a backend (docker) update necessary or does it work with lambdacube/indra:2.0.2?
Thanks,
Best,
Ben

Hi @blang, yes it is a large backend update. In the case that you managed to work with the current version, I don't recommend updating now. I hope up to the next week we have a new well-tested version.
Best,

@julsal Ok thank you, i will stay with the current version. I was using a much older version of indra for development and was forced to update since the w2v-wiki2014 dataset for the old mongo version was no longer available on the dataset server.
If the current version does not work properly, i will have to downgrade again.
Are the old python updater based datasets for the old mongo version still available online?

@blang For sure it is available in the one of the versions of https://github.com/Lambda-3/IndraComposed, but unfortunately I can't precise the version.

The new version solves this problem.


[NT-685] Abstract TrackingClient to be configurable

📲 What
Renames our existing KoalaTrackingClient to TrackingClient and adds TrackingClientConfiguration which is a struct with which we can initialize TrackingClient so that we can use it for more than one tracking endpoint.
Note: We could even create a TrackingClient to forward our events to something like Crashlytics for our breadcrumbs. Currently we do this with a callback at the time of tracking, but I think we should move that to be its own TrackingClient.
Also note: Koala itself will be renamed separately too. Currently it really just behaves as an interface for sending the events to the clients.
🤔 Why
We're going to be sending tracking events to two endpoints until we're able to fully deprecate Koala, this allows us to do so in a somewhat controlled manner and still keeps things testable.
🛠 How

Abstracted any endpoint-specific functionality from TrackingClient to TrackingClientConfiguration either via simple properties or closures.
Updated Koala's initializer so that it can be initialized with two tracking clients.

Koala will send all tracking events to both clients, we will be doing some filtering of whitelisted events one we know what they are. I would suggest that we do this filtering in Koala so that we can test it through mocked clients.

Wrote tests for these endpoint-specific parts of TrackingClientConfiguration, this actually gives us a bit more test coverage than before because these parts of KoalaTrackingClient weren't tested.

✅ Acceptance criteria
With the simulator set to staging, return true for isKoalaTrackingEnabled (to be renamed) in EnvironmentVariables.swift. Use Charles Proxy to inspect traffic.

[ ] Observe that tracking events are sent to both the DataLake and Koala endpoint.
[ ] Observe that both requests return 200 and are in the correct structure for each endpoint (e.g. POST for Koala, PUT for DataLake, etc.).

⏰ TODO

[ ] Additional tests once we have whitelisted events.
[ ] Additional clean-up noted in comments.

          1 Warning

:warning:
Big PR

  Generated by :no_entry_sign: Danger


Port legacy perl TO extension checks from perl to go

What does this PR (Pull Request) do?

This change ports (most) of the legacy perl server checks to go.
Performance (and logic problems) of the original DSCP check script was the primary motivation - in our environment, the DSCP scan was taking ~20 hours to run, and the results were unreliable.
ADD support for performing DSCP checks of SSL delivery services, which was previously missing.
ADD option to FQDN check for validating PTR records
Other scripts were ported over for sake of consistency.

Standalone programs only, and no changes are made to existing Traffic Ops API components, hence no integrated testing is included.
Which Traffic Control components are affected by this PR?

Traffic Ops Extensions (server checks)

What is the best way to verify this PR?

If this is a bug fix, what versions of Traffic Control are affected?

The following criteria are ALL met by this PR

[x] This PR includes tests OR I have explained why tests are unnecessary
[x] This PR includes documentation OR I have explained why documentation is unnecessary
[x] This PR includes an update to CHANGELOG.md OR such an update is not necessary
[x] This PR includes any and all required license headers
[x] This PR ensures that database migration sequence is correct OR this PR does not include a database migration
[x] This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY (see the Apache Software Foundation's security guidelines for details)

Additional Information

Can one of the admins verify this patch?

What's the motivation for this? Check extensions just run as scripts with no actual dependency on the Perl TO codebase, right?

ok to test

@ocket8888 I just emailed the dev/users lists with some more info regarding motivation.
The only dependency was an update to the go client library (https://github.com/apache/trafficcontrol/pull/3470) which has already been merged.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/4607/

Can we add those to the Traffic Ops build? Would be nice to be available and compiled when installing traffic_ops RPM.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/4644/

Do not merge - there were changes in #ccff78a that broke the code in this PR, that I was not anticipating. I need to sort that out now.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/4654/

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/4656/

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/4659/

I'm satisfied that the code in this PR is now building and running satisfactorily with the go client library version that are in currently master.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/4660/

Can you rebase to fix those conflicts?
I also think you probably have a better chance of getting this reviewed if each extension is a separate PR, but that's just my opinion.

@guzzijason Can we rebase this on master again please? Some issues with the Traffic Ops client versioning (my guess)

@smalenfant yes, I've recently updated the ones we're using internally here. I'll work on updating this PR.

@guzzijason In light of TC 6 to remove the API 1.x API, could we resolve the conflict on this one?

How do we build those components?  I tried to "wget" them but I can't figure how to compile them. I would like to install them on a different server than my Traffic Ops as well.

It actually looks like they would be packaged in the Traffic Ops RPM. But the build failed.
github.com/apache/trafficcontrol/traffic_ops/app/bin/checks imports
	github.com/apache/trafficcontrol/traffic_ops/client: no matching versions for query "latest"
+ echo 'Could not vendor go module dependencies'

The unversioned client import path was deprecated in 4.0 or 4.1 and disabled/removed in 5.0, I believe. Needs to add a version prefix - should probably just use v4- since it's packaged with TO.


I've wrote an article about Emu on Russian

Link: https://habr.com/en/post/454678/
I'll translate it to English in the near future, but someone else can do it instead (just write a comment before you'll do it).

Nice! This looks great 👌


chore: add botonic to repositories.toml

Botonic is the open source framework developed by Hubtype for building amazing Chatbots for any Platform with React. Botonic is an easy to learn, open-source framework that lets you create powerful conversational interfaces that work on the most popular messaging apps (Whatsapp, Facebook Messenger, Telegram and more), your website or even your native mobile apps (Android/iOS).

Link to issues: https://github.com/hubtype/botonic/issues

Hi @jai-deepsource I cannot see the project listed in the main site, can this failed ci test be somehow related? https://github.com/deepsourcelabs/good-first-issue/runs/1320347233
Thanks 😊


OpenGL.raw.EGL._errors.EGLError: EGLError

$python train.py agent=baku suite=libero dataloader=libero suite/task=libero_90 suite.hidden_dim=256
when run above command, after all training steps are done and all snapshots are saved, I got below error. I did a bit debugging, and it seems that all BAKU python code are correctly run, but got below error.
Anybody knows why?  You can ignore this error for now since the model training seems to go on till completion. Hope that helps!


Javascript

#Javascript
##User Story
As a boot camp student
I want the prework notes to be structured on a webpage
So that I can easily find and read the information
##Acceptance Criteria
GIVEN a Prework Study Guide website
WHEN I view the study guide
THEN I can see the four topics I learned listed along with a suggestion on what I should study first

Resolved as part of #9

Fully resolved as part of #10


commas missing after export

@NobodyForNothing I found that commas in notes and all characters following that comma inside that same note, are swallowed after the re-import. Doesn't break anything after/outside the note, but swallows the next comma-text incidence inside a note again. (Yes, the mime type switch is activated.)

Originally posted by @uli-on in https://github.com/NobodyForNothing/blood-pressure-monitor-fl/issues/23#issuecomment-1587499836

This is unrelated to the UTF-8 conversion issue. I will look into properly escaping them


Metadata: erengy.Taiga v1.3.1

[X] Have you signed the Contributor License Agreement?
[X] Have you checked that there aren't other open pull requests for the same manifest update/change?

[X] Does your manifest conform to the 1.0 schema?

Microsoft Reviewers: Open in CodeFlow

This runs perfectly fine on my 32-bit machine.


Added a LOT of websites

included changes from @tamas646 from #81
added sites from other porn HOST file aggregates, which also included CDNs for porn sites

Thanks for you help! Really appreciated guys


Enhance application search

Enhance the search within the application perspective.
Ideas: auto-completion instead of first matching.

@Malte-Hansen introduced a simple but synchronous solution to this problem in 890bfa0eaa0c443f64a135775412a3cfb5b229f1l. This might work for our dummy landscape, but its runtime is dependent on the applications size, therefore will probably freeze the UI element (dunno if this is actually true).
I didn't tackle this enhancement, since I wanted to use the Ember-Concurrency addon for an asynchronous data retrievement.

Added ember-power-select.
TODO: Apply CSS style of ExplorViz to this element.

[ ] Remove arrow in input box
[ ] enable substring search via input pattern, e.g., *i would show explorviz

Closed with ee1f482f7270c6c83ca2800a6fe8a84e2425be43

Entitiy categories should be distinguished by using a delimeter. Something like:
------- Packages
X
Y
Z
------- Classes
X
Y
Z


Include generation timestamp in json-delta endpoint

As a user I want to know when a delta was generated. To do so, if would help me if this was included in the /json-delta API endpoint.
e.g.
{
  "reset": true,
  "session": "1678702338",
  "serial": 2698,
  # new attributes, same style as in `/json`
  "generated":<PHONE_NUMBER>,
  "generatedTime": "2023-03-24T10:46:20Z",
  # ...original payload...
  "additions": [...

Sounds good! I’ve added it to the 0.13 cycle.

I do not know if this information is available for previous deltas as well. With that information you could track when the addition/removal of a entry was first "observed" by routinator

It’s currently only available for the current version, but that is easy to change. But the ‘delta protocol’ works like RTR in the sense that you can only ask to be updated to the current version, not ask for the delta for a specific serial number. Or do I misunderstand your comment?

Indeed. The idea was to basically do what RTR does only with JSON as the transfer format and HTTP as the transfer protocol.


Docker login during CI doesn't work with docker:19.03.8 (docker:19.03.8-dind as service)

Hi,
I've been using the same pipeline to build and push docker images for almost a year without any problems, but lately I'm getting the following error:
$ docker login -u "${CI_REGISTRY_USER}" -p "${CI_REGISTRY_PASSWORD}"
WARNING! Using --password via the CLI is insecure. Use --password-stdin.
Error response from daemon: Get https://registry-1.docker.io/v2/: unauthorized: incorrect username or password

Authenticating with credentials from /root/.docker/config.json
ERROR: Job failed: exit code 1

Both CI_REGISTRY_USER and CI_REGISTRY_PASSWORD haven't changed, so I thought that the password, which is an access token, had expired. I tried creating a new token and even using my personal password, but everything I tried resulted in the same error. The CI_REGISTRY_USER is a variable holding just the userid of the account, not the email.
To verify I tried the same docker login command on my notebook and it logged in without a problem.
Just in case I'm adding the stage of gitlab-ci.yml related to this:
release_docker_image_qa:
  image: docker:19.03.8
  stage: release_docker_image_qa
  when: manual
  services:
    - name: docker:19.03.8-dind
  script:
    - mv erp-*.jar ./docker/
    - cd docker
    - ls -lah
    - docker info
    - sed -i "s/__CONF_BRANCH__/${CI_MERGE_REQUEST_TARGET_BRANCH_NAME}/" Dockerfile
    - docker login -u "${CI_REGISTRY_USER}" -p "${CI_REGISTRY_PASSWORD}"
    - echo "$A_CONF" > conf
    - echo "$A_CRED" > cred
    - docker build -t "${CI_REGISTRY_IMAGE}:latest" .
    - docker tag "${CI_REGISTRY_IMAGE}:latest" "${CI_REGISTRY_USER}/${CI_REGISTRY_IMAGE}:${CI_MERGE_REQUEST_TARGET_BRANCH_NAME}-${CI_COMMIT_SHORT_SHA}-qa"
    - docker push "${CI_REGISTRY_USER}/${CI_REGISTRY_IMAGE}:${CI_MERGE_REQUEST_TARGET_BRANCH_NAME}-${CI_COMMIT_SHORT_SHA}-qa"
  only:
    - merge_requests

Did someone already had this problem or have a guess on what I'am missing?
Thanks

docker:19.03.8 hasn't changed since March https://github.com/docker-library/docker/commit/0bab8e3d0ebe6dc4b7a122bb1d0b2e017925c50d
All those variables are gitlab-specific https://docs.gitlab.com/ee/ci/variables/predefined_variables.html So I don't think there's anything actionable we could do to alleviate this
You could try asking over at the GitLab-runner repo, Docker Community Forums, Docker Community Slack, or Stack Overflow

Indeed, the docker:19.03.8 image hasn't been pushed since 5 May 2020, so any change in how login works with the Docker Hub would have to occur on the Gitlab CI runner infrastructure or possibly related to Docker Hub (like this, but it doesn't go into effect until November and only is on pull, not login). The Docker Hub should be compatible with all recent versions of docker, but you could try using the latest 19.03.13 image to rule it out.

Thanks for the reply @wglambert and @yosifkit,
It seems that they changed from where the variables are picked up. Before every user would have to add a variable e.g. CI_REGISTRY_PASSWORD and the pipeline would run with user defined variables, because the pipeline would run "in user space" . Now it seems that these variables are picked from the project owner (from where it was forked).
Thanks for the help


[WIP] v1.3.0

Adds /api/v1/services/dnsmasq endpoint to read the entire dnsmasq conifguration
Adds /api/v1/services/dnsmasq/host_override endpoint to create, read, update and delete dnsmasq host overrides
Adds /api/v1/services/dnsmasq/host_override/alias endpoint to create dnsmasq host override alias entries
Adds /api/v1/services/dnsmasq/start endpoint to start the dnsmasq service
Adds /api/v1/services/dnsmasq/stop endpoint to stop the dnsmasq service
Adds /api/v1/services/dnsmasq/restart endpoint to restart the dnsmasq service
Adds HA sync feature to API settings
Adds /api/v1/system/ca endpoint to manage system CA certificates

Beta builds are available. I'll try to keep these updated:
pfSense 2.5
pkg add https://github.com/jaredhendrickson13/pfsense-api/files/6216326/pfSense-2.5-pkg-API-1.3_0beta.zip && /etc/rc.restart_webgui

pfSense 2.6
pkg add https://github.com/jaredhendrickson13/pfsense-api/files/6216327/pfSense-2.5-pkg-API-1.3_0beta.zip && /etc/rc.restart_webgui

pfSense-2.5-pkg-API-1.3_0beta.zip
pfSense-2.6-pkg-API-1.3_0beta.zip

Hi Jared,
I don't see beta package for 2.4 version of pfsense. Is this not supported for 2.4?

@degas2226 yes, with Netgate deprecating the 2.4 package repos it unfortunately becomes very difficult to maintain and perform automated testing for the package on 2.4 releases. Going forward (starting with v1.3.0) 2.5 will be the primary supported platform with 2.6 as a development preview. This also allows me to start implementing features that are specific to pfSense 2.5 and remove the extra code required to make the package backwards compatible with 2.4, which greatly increased the complexity for some of the code.
That being said, it may still be possible to force the installation of the package on 2.4 using the -f flag after the pkg add command. I haven't tried this myself, but I would think most endpoints and functions would still operate. I would however expect things to start breaking as time goes on so doing so would be at your own risk.


Option for sourceroot to be relative to targetroot (or another parameter that is)

Current the sourceroot option is treated as being relative to the cwd, rather than the targetroot. Unfortunately this causes issues in Gradle.
Sorry it's a little complicated to explain, but reason is:

Gradle doesn't use the project root as it's cwd. Instead it has N workers that run under their own directories, but point the scalac task to a particular scala file and output location (which is under the project).

If you set sourceroot as a compiler option this breaks caching in Gradle, as any differences in compiler options (between machines) forces Gradle to recompile, rather than to download existing compiled artifacts. In our particular case, this is a signifiant overhead. We rely on Gradle's caching to make compiling our very large (almost mono) repo tractable.

However, having an option (either sourceroot, or a new option) that you can set relative to targetroot solves this. As the targetroot is automatically derived from scalac's output directory, which is already set to the right place.

Related gradle-scalafix issue. https://github.com/cosmicsilence/gradle-scalafix/issues/58

Thanks for reporting! I wonder, would it be possible (as a workaround) to set sourceroot to maybe something like ../ based on where the Gradle worker directories are located? Are they deterministic?
We could add another option for sure, this seems like a valid use case to have the artifacts machine independent. I wonder though if it will be easy to figure out the sourceroot based on targetroot. Wouldn't it be the same case as trying to determine sourceroot from the workers' cwd ?

If you are open to it, I could make a PR that adds -P:semanticdb:relative_sourceroot which will create a source_root by resolving from the targetroot.
Should I prepare that PR?

I've dug a bit deeper to see what's going on. I think the following:

Gradle doesn't use the project root as it's cwd. Instead it has N workers that run under their own directories, but point the scalac task to a particular scala file and output location (which is under the project).

might not be true. The real issue here is that Scalafix (+ semanticdb, most likely) doesn't allow the source root to be relative. Here's the place where the check is made
https://github.com/scalacenter/scalafix/blob/a543de1ee943cc8aacf00cef5cbd7a0370563c03/scalafix-cli/src/main/scala/scalafix/internal/interfaces/ScalafixArgumentsImpl.scala
This is impeding us from using a relative path that can be safely cached by Gradle.
The fix for making the scalafix gradle cache work and cacheable involves making Scalafix accept a relative path and resolve it based on the working directory that was configured for Scalafix via withWorkingDirectory or the default one.
This solution feels less hacky than making the sourceroot relative to the targetpath.
I don't think it'll be necessary to make the sourceroot option in the SemanticDB. So long as Scalafix is launched in the gradle project or root dir --pretty confident this is the case--, we're good because we can pass the right relative path for it.

@aishfenton pointed out that we will need the relative sourceroot option to also work in semanticdb, I missed that scalafix is just locating the previously compiled semanticdb files, so this ticket is still relevant in this repository.

I also confirmed that the CWD in Gradle's compile tasks isn't the project root, it's GRADLE_USER_HOME/workers. And from this issue, seem unlikely that there's an option to change it: https://github.com/gradle/gradle/issues/7323

If you set sourceroot as a compiler option this breaks caching in Gradle, as any differences in compiler options (between machines) forces Gradle to recompile, rather than to download existing compiled artifacts. In our particular case, this is a signifiant overhead. We rely on Gradle's caching to make compiling our very large (almost mono) repo tractable.If you set sourceroot as a compiler option this breaks caching in Gradle, as any differences in compiler options (between machines) forces Gradle to recompile, rather than to download existing compiled artifacts. In our particular case, this is a signifiant overhead. We rely on Gradle's caching to make compiling our very large (almost mono) repo tractable.

Alternatively, could we filter that compiler option to not be taken into account for caching?
If not, it seem that we will need the additional setting relativeSourceroot, which would be able to derive the semanitcdb location based on the output directory. If anyone is willing to take a stab at it by all means please do :pray:

Alternatively, could we filter that compiler option to not be taken into account for caching?

This is what we're investigating, will keep you posted. If we don't manage to do this, then we'll most likely need to add a setting similar to relativeSourceRoot.

Related (but slightly different issue) https://github.com/scalameta/scalameta/issues/2518


NuGetCommandV2 failed when NU1603

Note
Issues in this repo are for tracking bugs, feature requests and questions for the tasks in this repo
For a list:
https://github.com/Microsoft/azure-pipelines-tasks/tree/master/Tasks
If you have an issue or request for the Azure Pipelines service, use developer community instead:
https://developercommunity.visualstudio.com/spaces/21/index.html )
Required Information
Entering this information will route you directly to the right team and expedite traction.
Question, Bug, or Feature?
Type: Bug/Question
Enter Task Name:  NuGetCommandV2
list here (V# not needed):
https://github.com/Microsoft/azure-pipelines-tasks/tree/master/Tasks
Environment

Server - Azure Pipelines or TFS on-premises?

If using TFS on-premises, provide the version:

If using Azure Pipelines, provide the account name, team project name, build definition name/build number:

Agent - Hosted or Private:

If using Hosted agent, provide agent queue name:

If using private agent, provide the OS of the machine running the agent and the agent version:

Issue Description
the restore command fails with an error when NU1603 warning happend
Task logs
[Enable debug logging and please provide the zip file containing all the logs for a speedy resolution]
Troubleshooting
Checkout how to troubleshoot failures and collect debug logs: https://docs.microsoft.com/en-us/vsts/build-release/actions/troubleshooting
Error logs

##[error]The nuget command failed with exit code(1) and error(NU1603: <package-name> x.x.x depends on <package-name> (>= x.x.x) but <package-name> x.x.x was not found. An approximate best match of <package-name> x.x.x was resolved.

Is this repo maintained?


fix: duplicate key in test dict

Codecov Report
Base: 90.95% // Head: 90.95% // No change to project coverage :thumbsup:

Coverage data is based on head (72ba87e) compared to base (72ba87e).
Patch has no changes to coverable lines.

:exclamation: Current head 72ba87e differs from pull request most recent head 3869b63. Consider uploading reports for the commit 3869b63 to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1126   +/-   ##
========================================
  Coverage    90.95%   90.95%
========================================
  Files          179      179
  Lines         5084     5084
========================================
  Hits          4624     4624
  Misses         460      460

Flag
Coverage Δ

py3.8-ubuntu-latest-pandas
90.95% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Feat(Core): Add support for MHW build 421631. Really Capcom?

Thanks for update! DPS panel seems not work at v<IP_ADDRESS>, is that a bug?


fix: use absolute Deno bin path as possible

In some special environments, for example, Netlify CI, deno won't exist in $PATH by default. This PR fixes this problem to avoid crash.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Done.


[Feature] Firestore DB needs additional API support to ingest certain data types / formats

Description
When the user tries to use unix time stamp moment(EventAddStartDatePicker.selectedDate).unix() in the firestore API, the DB treats is as a map instead of timestamp. Instead when the user tries to use the firestore wrapper to do so, the function works properly admin.firestore.Timestamp(moment(EventAddStartDatePicker.selectedDate).unix(), 0)
The user wants support for the Firestore fields such as references, geocoordinates, etc.

Important Details

Version: [Cloud / Self-Hosted vx.x]
OS: [e.g.MacOSX]
Browser [e.g. chrome, safari]
Environment [production, release, deploy preview]

Yes, something like this might be useful at least for the Timestamp field building a document reference would also be needed
{{
{
  "code": EventAddCodeInput.text,
  "title": EventAddTitleInput.text,
  "start": EventAddStartDatePicker.selectedDate ? new admin.firestore.Timestamp(moment(EventAddStartDatePicker.selectedDate).unix(), 0),
  "end": EventAddEndDatePicker.selectedDate ? new admin.firestore.Timestamp(moment(EventAddEndDatePicker.selectedDate).unix(), 0)
  "extPlatform": EventAddExtPlatformSelect.selectedOptionValue,
  "extReference": EventAddExtReferenceInput.text,
  "createdBy": appsmith.user.email
}
}}

Somewhat related is Firebase is moving to a more modular API, v9. I wonder if you need to wrap this API then maybe the new v9 API might make that task easier.

Thanks for the additional info here @tazmaniax

This is similar to https://github.com/appsmithorg/appsmith/issues/3741

Hi, is there a rough timeline when this might be resolved? thx!

Now it's Hactoberfest, maybe I need to roll up my sleeves! 😄

Another user is requesting support for Firebase timestamps:
https://discord.com/channels/725602949748752515/1221163808706400317/1221163808706400317

Hello @tazmaniax , I have raised the PR for this task, Could you please review it.


is_last naming bikeshed

I came here from your recent talk "A Safer Iteration Model for C++ - Tristan Brindle - C++ on Sea 2023", and generally I like it. 😎
The naming of is_last though is confusing because it's not testing whether the current points to the last thing, but rather whether it points after the last thing. The name first is fine for the starting point, but for the stopping point, you really want to know whether the cursor is at the limit (like limits in math, an element one past which is not actually ever reached). I considered possible alternate names 🤔:

is_limit (not too long and very clear, that you're at the limit)
is_past (coincidentally rhymes with is_last for the one-past 😉)
is_done (works, but then it's counterpart flux::done() counterpart doesn't sound so nice)
is_stopped (would use pairs flux::start() and flux::stop(), which sounds a bit weird, but not weirder than begin/end)
is_complete (hmm, maybe)
is_terminated (bit long)
is_terminal (maybe)
is_final (oops, C++ keyword, so can't use that)

And conversely for the counterpart of flux::first(v):

flux::limit(v) (noun works well here)
flux::past(v) (clearly evokes the "one past" concept)
flux::done(v) (😕 hmm, sounds weird because it sounds like a boolean function rather than returning a one-past sentinel marker)
flux::stop(v) (can be a noun like "gradient stop" or a verb, where verb is weird like "end")
flux::complete(v) (😕 also sounds like weird like done)
flux::terminal(v) (but not to be confused with a command line interface 😅)
flux::final(v)  (oops, C++ keyword, so can't use that)

And yes, using any of the above counterparts above would not form a pair like first and last do, but then end-exclusive ranges are already an asymmetric concept [ ).
From your talk, where you say "That's called chain in my library, because that's a better name" and "sum, because that's easier to spell than accumulate", I can see you're not strongly attached to existing names. Do any of the above alternate names convey the concept for you nicely, especially limit or past, because if the 62 upvotes from here mean anything, using last is an non-ideal name? Cheers from Seattle.

Hi, thanks for filing the issue! As it happens, I was thinking about this as well after I saw that Reddit thread.
In my defence, the name last makes more sense if you think about it as meaning "the last cursor position" rather than "a cursor pointing to the last element" -- since a sequence with N elements has N+1 possible cursor positions. That said, I'm not particularly strongly attached to it, and I can see that there is an ambiguity that isn't ideal.
Back when I started working on the library, cursors were called indices and the sequence functions were called begin_idx(), end_idx() and is_done(). If we went back to using the term "index" rather than "cursor" then I think these function names are pretty good... but the whole reason I changed in the first place was that "index" has strong associations with integers whereas "cursor" makes it clear that in Flux it's a more general concept, so I don't know how I'd feel about changing back now.
Of the names you suggest (thank you for coming up with a list!), I think we actually could use final, because it's not a true keyword and wouldn't conflict with anything. It might be my favourite, in fact. I also like limit as it conveys the past-the-end-ness very nicely.
I'd be keen to get more feedback on this before changing anything so if anyone has any suggestions or preferences then please leave a comment!

if you think about it as meaning "the last cursor position ... That said ... I can see that there is an ambiguity

Yeah, thinking in terms of possible valid index values, last is/was reasonable.

I think we actually could use final

True, it's a contextual keyword. 🤔

I'd be keen to get more feedback

Certainly, leaving it open a while for further comments is wise. Thanks for listening. ⏳👂...

I had similar thoughts while watching that talk.

I always considered end() being one past the end a naming smell.
Testing against end() to see if find() has a result is just crazy imo.
But one got used to it. With 'end' being kind of an abstract term it seems fine.

'first' and 'last', however, sound much more concrete, (even more so than front and back) so the abstraction that last is one past the last is much much harder.

If I were to reinvent this, I would probably choose to get rid of is_last() anyway in favor for the iterator simply being invalid. I would also have last() wrap the last valid index. After 25+ years of STL brainwash, nobody would like that, though ;-)

I had similar thoughts while watching that talk.

I always considered end() being one past the end a naming smell.
Testing against end() to see if find() has a result is just crazy imo.

"Did we find what we were looking for or did we reach the end of our search range" isn't all that crazy IMO. And in any case, Flux has flux::contains which just returns a bool if that's what you want.

But one got used to it. With 'end' being kind of an abstract term it seems fine.
2. 'first' and 'last', however, sound much more concrete, (even more so than front and back) so the abstraction that last is one past the last is much much harder.
3. If I were to reinvent this, I would probably choose to get rid of is_last() anyway in favor for the iterator simply being invalid. I would also have last() wrap the last valid index. After 25+ years of STL brainwash, nobody would like that, though ;-)

If you use closed rather than half-open ranges then it means you can't call first() or last() on an empty sequence. So then you need to make is_empty() a customisation point instead of is_last() and have all algorithms check for that, and so you haven't actually simplified anything. This is similar to what D ranges does, which is an interesting model but less powerful and not what I want to do for Flux. Half-open ranges, with their natural treatment of empty sequences, are here to stay I'm afraid -- and it's certainly not "brainwashing".

sigh
I was just trying to make the point that a random person would guess (with odds>80%) that - given a list - begin and end refer to the first and last elements. Now what might these odds be if we replaced begin, end with first, last?

Python uses start and stop for half-open index ranges (as well as other things, though not 100% consistently), and I remember it being much more immediately clear on first sight compared to C++'s begin and end, to the inexperienced programmer that I was at the time. I also do think that it helps to use two words that are a natural pair in English. is_stop() might have an advantage in that it grammatically forces "stop" to be taken to be a noun, which then nudges you to recognize that it is a term with a specific meaning -- but that might just be for me.
Just came to this repo from your wonderfully presented CppNorth talk.

I'd be keen to get more feedback on this before changing anything so if anyone has any suggestions or preferences then please leave a comment!

Rewatching your CppCon talk tonight (Iteration Revisited: A Safer Iteration Model for Cpp - Tristan Brindle) reminded me of this issue. Is half a year enough time for feedback collection? :b

I like the reversed is_in_bounds() idea very much.
The naming is OK, but a simple valid() also seems appropriate for a loop condition as well as for testing the result of a find.
the naming of the _cur things...
begin_cur end_cur would seem more natural to the occasional user coming from STL
in my mind you either go with STL or invent 2 new terms
then again the whole naming dilemma only occurs when manually dealing with iterators, which should be mitigated when using ranges

Is the _cur suffix redundant, given the flux:: namespace primarily deals with cursors already? Otherwise the new naming is fine with me, being clear/unambiguous (now that exclusive last becomes end*). Thanks.
(feel free to close at your discretion once you feel any other folks' feedback is addressed)

Is the _cur suffix redundant, given the flux:: namespace primarily deals with cursors already?

These can be member functions as well, so we need to differentiate end_cur() from the traditional end() as classes can have both (and there's also a flux::end() free function that returns a ranges-compatible sentinel).


Move from Standalone MongoDB to replica set

At the moment we are using a standalone mongoDB instance. We are starting to grow fast and will need to upgrade our server for more capacity (we currently use 35 gigs of data on our 80 gig server).
To move to a replica set we will need to shutdown the server to restart it in replica mode. This cause a temporary outage.
Once this is done we can then add replica databases.
What this gives us is the ability to expand the database later on without needing to shutdown. This should also increase the read speed of MongoDB.

Sounds good. Is there any progress on this?

Since this is DevOps and not actionable on this repo I'm going to close this issue.


Feature: allow checks based on toJSON() from react-testing-library

It would be nice if the engine could work on the toJSON output of react-native testing libraries render function.
This would solve the problem that we would not have repeat the components tests for a11n checks again:
// Before
const rendered = ender(
  <DropDown
    style={Styles.dropDown}
   items={[]}
   disabled
 />
).toJSON()
expect(rendered).toMatchSnapshot()

expect(() =>
  AccessibilityEngine.check(
    <DropDown
      style={Styles.dropDown}
      items={[]}
      disabled
    />
  )
).not.toThrow()

// After
const rendered = render(
  <DropDown
    style={Styles.dropDown}
   items={[]}
   disabled
 />
).toJSON()
expect(rendered).toMatchSnapshot()

expect(() => AccessibilityEngine.check(rendered)).not.toThrow()
// Or with #104 maybe even better like this:
expect(rendered).toBeAccessible()

This issue was resolved by #125 and the fix released in v1.6.0 😁 Closing!


Stone cutter extra recipes

[ ] Cobblestone can be turned into gravel
[ ] Gravel can be turned into sand

This would have to be implemented by the Core plugin as ItemsAdder only supports recipes on the crafting table.
It might be an idea to expand on the SMRemoveRecipes feature?

SMRemoveRecipes class has been renamed to SMRecipes and expanded to being able to add new stonecutter recipes. This has also change the config format


1.6-stable: cherry-pick Fix IsPackageDeploymentFeatureSupported (#4598)

cherry-pick 1cd3034c41f33fd1cb0775967e429765b3ebe5f4 from main
Fix IsPackageDeploymentFeatureSupported (#4598)
ALSO: DevCheck -SyncDependencies to update stale dependency references reported by DevCheck -CheckDependencies

/azp run

FYI for future xref https://task.ms/52846619


It would look like so for the developer:
DISCORD_TOKEN=<GET YOUR DISCORD TOKEN>
GENERAL_CHANNEL_ID=<GET YOUR GENERAL CHANNEL ID>
DISCORD_SERVER_ID=<YOUR SERVER_ID>

Would also need to change the package.json start local command to be:
dotenv npm run build && node dist/index.js

Of course the .env would also need to be added to .gitignore as you do not want to release those out to the world.
Didn't want to just add it in with another commit. Was curious what you guys thought of this, or if there is another way you do it similar to this that maybe doesnt require another module?

Good thinking, I like to lower the barrier to entry. I usually do something like this before the commands in npm source envars.tmp {COMMAND}
envars.secret file
export DISCORD_TOKEN=<GET YOUR DISCORD TOKEN>
export GENERAL_CHANNEL_ID=<GET YOUR GENERAL CHANNEL ID>
export DISCORD_SERVER_ID=<YOUR SERVER_ID>

with *.secret in the .gitignore file

Cool, I transferred over my envars into a env.secret.tmp, and it works just fine. Since that is already in the gitignore as well I will close this issue.

Thanks @garretcharp 👍 - lets see how this goes, we can always revisit this in the future if we need to 🤓


Make .update consistent with .initialize

When we initiailize, we check if attribute can be assigned. What if we make the same for .update?

@TheSmartnik Hi, why this feature request? Update expects an entity as input. So the control is provided by entity and update can indirectly take advantage of it.

@jodosha Hi, sorry not sure we are on the same page. I meant entity update method, which accepts hash

@TheSmartnik The goal is to remove soon mutable state for entities. So it's very likely that Entity#update will be deprecated/removed in a few months.

@jodosha Oh, I see. Thanks :smile:


feat: update docs to reflect OS 2024

The OS requires an update before this can be merged

Thanks for the PR!

I've reverted this for now, since people are confused about the image which is not released. Will remerge once the image is done.


How to mutate state and react in a component

Hi!
I am trying to use this brilliant ORM to store a collection and use the state inside a component.
The documentation makes this example:
static state ()  {
    return {
      fetching: false
    }
  }

can be mutated with
.commit(state => state.fetching = true).
However, the change appears to not be reflected in the component where I do
computed: {
 fetching() {
  return User.state().fetching;
 }
}

Am I doing something wrong?
When doing a console.log straight after the commit, the state does look updated (it prints out the observer reference) but I didn't manage to get it working.
Had also a look at https://github.com/vuex-orm/vuex-orm/issues/523 but it seems to be referring to accessing the state in models rather than .vue files
Cheers!

For reactivity in components, use:
this.$store.state.entities.users.fetching

Great thanks. We should probably make it clearer in the documentation though

@flaviotulino thanks for your feedback! The docs have been updated to provide more clarity. Feel free to open a PR if you feel in a contributing mood. 👍


Fix for issue 185.

This will recompile the catalog when a different :hiera_config value is detected (much the same as is done when different facter facts are used).  When this condition is detected, Puppet's internally cached instance of Hiera is also cleared so that the catalog can be recompiled against the differently configured Hiera.

I could reproduce the problem local, setting :hiera_config seems to leak across specs. I can also attest to the fact that the fix works for me with puppet 3.8.1 and puppet 4.
Moving the second chunk to before_each_test() works, but still requires the first chunk to get the local caching right.


Docker build fails

Hi,
I'm trying to build the image locally with the command docker build -t rustpad .. However it exits with the following error:
=> ERROR [wasm 6/6] RUN wasm-pack build --target web rustpad-wasm                                                                                187.6s
------
 > [wasm 6/6] RUN wasm-pack build --target web rustpad-wasm:
#15 187.5 Error: Error during execution of `cargo metadata`:     Updating crates.io index
#15 187.5
------
executor failed running [/bin/sh -c wasm-pack build --target web rustpad-wasm]: exit code: 1

Any clues how this could be solved?
Thanks!

I am unable to reproduce.

Thanks, @orhun. I've tried to delete everything including node_modules and still the same error, even if I get fresh from GIT:
edgarmkrtchyan@Edgars-MBP rustpad % docker build -t rustpad .
[+] Building 274.4s (20/27)
 => [internal] load build definition from Dockerfile                                                                                0.0s
 => => transferring dockerfile: 833B                                                                                0.0s
 => [internal] load .dockerignore                                                                                0.0s
 => => transferring context: 127B                                                                                0.0s
 => [internal] load metadata for docker.io/amd64/node:lts-alpine                                                                                2.2s
 => [internal] load metadata for docker.io/library/rust:alpine                                                                                2.2s
 => [internal] load metadata for docker.io/amd64/rust:alpine                                                                                2.2s
 => [wasm 1/6] FROM docker.io/amd64/rust:alpine@sha256:3963de6b13ca26a8ca3e8964fe82810b9e84814e97feb8a7319578d1fcd045fd                                                                                0.0s
 => [internal] load build context                                                                                0.0s
 => => transferring context: 352.01kB                                                                                0.0s
 => [backend 1/6] FROM docker.io/library/rust:alpine@sha256:f5e5330fe415bdd15bb4449c2e61789580f187fb0549b82345721e530c198985                                                                                0.0s
 => [frontend 1/7] FROM docker.io/amd64/node:lts-alpine@sha256:4e36c3dee7c32cef5bfce5bc1b5013d1c3cc542cfdefde2a545ec641e7c94243                                                                                0.0s
 => CACHED [backend 2/6] WORKDIR /home/rust/src                                                                                0.0s
 => CACHED [backend 3/6] RUN apk --no-cache add musl-dev openssl-dev                                                                                0.0s
 => CACHED [frontend 2/7] WORKDIR /usr/src/app                                                                                0.0s
 => CACHED [frontend 3/7] COPY package.json package-lock.json ./                                                                                0.0s
 => CACHED [wasm 2/6] WORKDIR /home/rust/src                                                                                0.0s
 => CACHED [wasm 3/6] RUN apk --no-cache add curl musl-dev                                                                                0.0s
 => CACHED [wasm 4/6] RUN curl https://rustwasm.github.io/wasm-pack/installer/init.sh -sSf | sh                                                                                0.0s
 => [wasm 5/6] COPY . .                                                                                0.0s
 => [backend 4/6] COPY . .                                                                                0.0s
 => CANCELED [backend 5/6] RUN cargo test --release                                                                                272.1s
 => ERROR [wasm 6/6] RUN wasm-pack build --target web rustpad-wasm                                                                                271.5s
------
 > [wasm 6/6] RUN wasm-pack build --target web rustpad-wasm:
#15 271.4 Error: Error during execution of `cargo metadata`:     Updating crates.io index
#15 271.4
------
executor failed running [/bin/sh -c wasm-pack build --target web rustpad-wasm]: exit code: 1

What's the specs of the computer Edgars-MBP that you are running this on? CPU architecture and OS with version. And what version of Docker Desktop for Mac do you have installed?

@ekzhang I'm on an M1 Mac with the latest Docker Desktop. I suppose that's the problem but not sure what argument should this be run with.

Hi, thanks for the information. I also develop on an M1 Mac. Could you tell me your operating system version as well? That would help me diagnose.
Please provide the version number of Docker Desktop.

I'm on Monterey, 12.2 (21D49) and the Docker Desktop version is 4.12.0 (85629).

Thanks, I'm able to reproduce this issue. Looking into it.

Sorry, I can't figure out how to get this to build on M1 Macs. There's just a collection of unsupported features that makes the cargo metadata command not work, since M1 Macs run Docker, which is an ARM64 Linux VM, but also virtualize x86-64 through Rosetta 2 again through that, and that messes up the build process. You can build it on any x86-64 Mac, or x86-64/arm64 Linux machine though.

Thanks for spending time on this @ekzhang. I've successfully built the Docker image on a Linux VM.


Write stream on error doesn't work properly [error thrown directly from MongoDB native]

Say you enforce an unique index on some metadata like so:
db.fs.files.ensureIndex({ 'metadata.id': 1 }, { unique: true })
Then if you're trying to insert a duplicate this happens:
MongoError: E11000 duplicate key error index: sample-gridfs.fs.files.$metadata.id_1  dup key: { : null }
    at Object.toError (/Users/alexandruvladutu/www/node_modules/mongodb/lib/mongodb/utils.js:110:11)
    at /Users/alexandruvladutu/www/node_modules/mongodb/lib/mongodb/collection/core.js:633:24
    at Server.Base._callHandler (/Users/alexandruvladutu/www/node_modules/mongodb/lib/mongodb/connection/base.js:442:41)
    at /Users/alexandruvladutu/www/node_modules/mongodb/lib/mongodb/connection/server.js:485:18
    at MongoReply.parseBody (/Users/alexandruvladutu/www/node_modules/mongodb/lib/mongodb/responses/mongo_reply.js:68:5)
    at null.<anonymous> (/Users/alexandruvladutu/www/node_modules/mongodb/lib/mongodb/connection/server.js:443:20)
    at EventEmitter.emit (events.js:95:17)
    at null.<anonymous> (/Users/alexandruvladutu/www/node_modules/mongodb/lib/mongodb/connection/connection_pool.js:191:13)
    at EventEmitter.emit (events.js:98:17)
    at Socket.<anonymous> (/Users/alexandruvladutu/www/node_modules/mongodb/lib/mongodb/connection/connection.js:418:22)

The writeStream should throw the error.
The sample code:
var fs = require('fs');
var mongo = require('mongodb');
var Grid = require('gridfs-stream');

// create or use an existing mongodb-native db instance.
// for this example we'll just create one:
var db = new mongo.Db('sample-gridfs', new mongo.Server("<IP_ADDRESS>", 27017), {safe: true});

// make sure the db instance is open before passing into `Grid`
db.open(function (err) {
  if (err) { throw err; }

  var gfs = Grid(db, mongo);

  // streaming to gridfs
  var writeStream = gfs.createWriteStream({
    filename: 'sample_file.js'
  });

  writeStream.on('error', function(err) {
    throw err;
  });

  fs.createReadStream(__filename).pipe(writeStream).on('close', function() {
    // streaming from gridfs
    var readstream = gfs.createReadStream({
      filename: 'sample_file.js'
    });

    //error handling, e.g. file does not exist
    readstream.on('error', function (err) {
      throw err;
    });

    readstream.pipe(process.stdout);
    readstream.on('end', function() {
      db.close();
    });
  });
});

Could you please test this issue in the just released 1.0.0? If the issue still exists, can you let us know and contribute a unit test?
Thanks


TypeScript + Monorepo + Various fixes

Based on the conversation at #143
This PR is a complete rewrite in TypeScript using lerna to include the 3 main renderers and jest/babel for testing. It also introduces a new package, listr-core which has the classes and types shared between Listr and a renderer.
The build results contain the type definitions, so there will be no need for @types/listr anymore.
One of the main issues while using listr was its dependency on RxJS, that has been removed and replaced by a barebone Observable + Observer implementation to preserve the spirit of the base code as best as possible while also minimising changes to the Task-Renderer interface.
Some bugs/odd behaviours have been fixed and they will affect end users and should be considered breaking changes, although they were strange and buggy behaviours. You can see these by looking at the differences between the old tests and the new ones
There are also breaking changes in the Task - Renderer interface, so any custom renderer out there will have to update to the new interface and inherit from BaseRenderer in list-core.
Code coverage is not reflected properly as listr-core is mostly tested via tests in listr that use the builded .js files and not the actual source code, so the metric itself is not representative right now. All the tests have been preserved and even some additional checks have been added.
i've set lerna in singl-version mode bumping all packages to 0.15.0, but that is of course subject to change. I thought it was convenient to publish all the packages at the same time with the same version.
No features have been added on purpose, to limit the scope of the PR.

Rewriting in TypeScript is definitely something I want to do as well. But first I believe we should solve some low-hanging fruit issues and PRs. (Sam)

@SamVerschueren @LitoMore any comments on this?

I'll try to review it shortly. Thanks for this massive PR :).


Sensitivty agent data serve json

The data_serve_controller.py now returns a json object directly if no csv object with the same name can be found.
Example:
We ask for the contents of a file called table_of_data using ...&component=table_of_data
As before, if table_of_data.csv exists, it returns the contents of this file using json in records format
If table_of_data.csv does not exist but table_of_data.json does it returns the contents of table_of_data.json as is.

Closed as the directory model/sobol is empty and therefore untracked, giving gave an error when it tried to save a file to a non existent directory. To remedy this a line which creates the directory if it is not already present was added. This problem was not discovered during testing as the empty directory was there.