Fix markdown for a mermaid graph

Fixes the markdown for the embedded Mermaid graph so it works.

https://deploy-preview-33100--kubernetes-io-main-staging.netlify.app/docs/concepts/services-networking/ingress/ doesn't look right to me, @bentito
You can follow preview your changes locally to see if a proposed change has fixed the issue.
In this case, I think you were trying to fix #31960
A fix for that is very welcome, but it has to work.

Not sure what's up with that preview, because when I go to edit the page for it, the source doesn't reflect the change made in the PR?
I made the same changes to the source and it seems to render okay here: https://github.com/bentito/scratch/blob/main/README.md

Ah!
@bentito when you edit pages in GitHub, you're seeing how GitHub renders those pages. However when you visit https://k8s.io/docs/ you see the pages rendered by Hugo, using our custom styling and the third-party Docsy theme.
As you can imagine, https://kubernetes.io/docs/concepts/services-networking/ingress/ and https://github.com/kubernetes/website/blob/919c6a07fd96d43db3ff9272c6e57e566992af52/content/en/docs/concepts/services-networking/ingress.md are connected, but they are not the same page when you look at them. We're aiming to improve how https://kubernetes.io/docs/concepts/services-networking/ingress/ looks; the appearance of https://github.com/kubernetes/website/blob/919c6a07fd96d43db3ff9272c6e57e566992af52/content/en/docs/concepts/services-networking/ingress.md isn't important.

Ah okay but ultimately it needs to render properly on Github where people
are seeing it, right? Currently I just see a JS syntax error graphic
instead of the Mermaid graph.That's what the PR is trying to fix. I think
the changes in the PR accomplish the fix on Github?
Brett Tofel
he/him/his
Sr. Software Engineer
Red Hat (OpenShift Operator Portfolio Enablement  / OLM)
On Fri, Apr 22, 2022 at 9:39 AM Tim Bannister @.***>
wrote:

Ah!
@bentito https://github.com/bentito when you edit pages in GitHub,
you're seeing how GitHub renders those pages. However when you visit
https://k8s.io/docs/ you see the pages rendered by Hugo, using our
custom styling and the third-party Docsy theme.
As you can imagine,
https://kubernetes.io/docs/concepts/services-networking/ingress/ and
https://github.com/kubernetes/website/blob/919c6a07fd96d43db3ff9272c6e57e566992af52/content/en/docs/concepts/services-networking/ingress.md
are connected, but they are not the same page when you look at them. We're
aiming to improve how
https://kubernetes.io/docs/concepts/services-networking/ingress/ looks;
the appearance of
https://github.com/kubernetes/website/blob/919c6a07fd96d43db3ff9272c6e57e566992af52/content/en/docs/concepts/services-networking/ingress.md
isn't important.
—
Reply to this email directly, view it on GitHub
https://github.com/kubernetes/website/pull/33100#issuecomment-1106526422,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABB6HLY2YYSWMY5QIOAEP6TVGKTZ7ANCNFSM5T76ZQ7A
.
You are receiving this because you were mentioned.Message ID:
@.***>

/hold
The intent (“fix” how GitHub renders the docs) seems to misunderstand how the Kubernetes project publishes its documentation. https://github.com/kubernetes/website/ does have a link to the actual docs website.

Oh thanks for explaining. And, it does actually render on kubernetes.io/docs fine for me on Firefox right now. Closing this due to that.

/hold cancel


Admin Panel - Create an interface that allows the admin to manage geographic areas

Ugh, who even knows.


add nest_filters/3

Coverage increased (+0.05%) to 96.706% when pulling 7bd6a27e7de387b5256be726a9454c02c3389d95 on nest-filters into 631e996e996ad193ab17a6c0823f8beb4cb942a2 on main.


Promise fulfil/reject have broken architecture

Promise class should not have fulfil() and reject() methods — instead, they must be moved to separate class like PromiseSource.
Because currently it is a leak in incapsulation: methods of class that return promises for underlying scheduled operations should not allow fulfillment and rejection of these operations by external user.

@shoumikhin Yes, all of the above.
Promise and its source (aka Future & Promise in terms of some other implementations) should be separate, so that any API (or any protocol or interface for that matter) that returns the Promise object can be sure that user will not be able to interfere with fulfilment and rejection of that promise by API's internal implementation.
Promises should be read-only objects in the sense that they can only be used to monitor pending error/value, not influence their outcome.
Naturally, it implies separating resolving logic into separate class like PromiseSource that will strongly retain corresponding Promise object (but not the other way around).

I think that's an interesting idea. I'll convey it to the rest of folks directly involved into Promises development at Google. Feel free to provide a PR or further details or examples on how you'd like to have that implemented. Thanks again for the suggestion!

@shoumikhin I don't think there is much to be added in terms of details.
The rationale behind this proposal is the same as with regular mutable/immutable value and value types in general (as in Swift's value types): when you suppling promise as method argument (or returning it from your method) you want to be sure that method's code (or caller of your method) will not be able to interfere with promise's underlying process.
Such interference should be optional and completely separate from Promise class in form of CancelToken #75 (that can also be used for cancellation of async processes, not just unregistration of promise blocks).

Hey @virl, I think you bring up a good point about the potential pitfalls of exposing an API that returns a promise that the caller can modify in some way (i.e. by calling fulfill/reject). We are currently looking into potential solutions for addressing this and will hopefully have an update shortly.
Thank you!

Hi @virl, please let us know what you think about the proposal made by @shoumikhin in the comment above. Feel free to reopen this PR if this approach is worth pursuing.
Thank you!


feat: #47 Add support of managing template

This change adds a new resource terrakube_organization_template and an additional parameter template_id to terrakube_workspace_vcs.
fix #47

Thank you @stanleyz

I have created a new release with all of your changes
https://github.com/AzBuilder/terraform-provider-terrakube/releases/tag/v0.5.0
Thank you for your contribution

I have created a new release with all of your changes
https://github.com/AzBuilder/terraform-provider-terrakube/releases/tag/v0.5.0
Thank you for your contribution

Great, thanks for your prompt actions.


False Positive: Variable Shadowing reports incorrectly on lambda

The following code:
  val list = new JList[Int]
  list.setCellRenderer((_: JList[_], value: Int, _: Int, _: Boolean, _: Boolean) => render(value))

  private  def render(value: Int) = new JLabel(value.toString)

Results in the following warning (tried with Scala 2.13.1):
VariableShadowing
def render(value: Int) = ...
           ^

My best guess is that this is caused by the bytecode that is generated for the lambda, but I do not agree that this is shadowing. This issue is probably related to https://github.com/sksamuel/scapegoat/issues/342.

I haven't tested it, but I assume it's fixed by #357


Make OwnedMemory.Dispose virtual

I'd like to implement automatic disposing via ref counting. Today I had to explicitly implement IDisposable to replace the built in behavior:
https://github.com/davidfowl/Channels/blob/fc37daff25a961a3e8f3467582e0f8aca4c1c5d3/src/Channels/ReferenceCountedBuffer.cs#L32
/cc @KrzysztofCwalina

Why don't you override DisposeCore? ... or what would you want to do instead of implementing IDisposable explicitly?

#934 shows how to implement auto-disposable OwnedMemory

@KrzysztofCwalina Because I want to change the meaning of dispose and not calling the underlying dispose until the ref count is 0

@davidfowl, Dispose (the virtual method on OwnedMeory) needs to have one meaning: shuts down this instance, or decrements the ref count. Subclasses shoudl not change the meaning. This is why I added Release in the sample. Will such Release not work for you?

I don't ever want to expose a derived class. Callers just call Dispose() and it will do the right thing. If I exposed a new API I may as well keep the abstraction I currently have.

DisposeCore isn't what I want, I overrode that as well and use it to return memory to the pool when the underlying dispose is called

I added Release to the base class.

Oh no 😄

As I said before, methods on abstractions must have clear semantics. Dispose cannot decrement the ref count in some cases and really dispose (shut down the object) in others. I feel we have a similar problem with Reserve(). It should not make an observable copy in some cases and not others. It's impossible to write code over such abstractions because you never know what the code does.
I know we talked about making ref counting an implementation detail, but I am not sure we can make it work.
Having said that, I will try to tweak the design a bit; I just need you understand your requirements in more detail, i.e. I need to understand which of you asks are wishes and which are hard requirements.

@KrzysztofCwalina I changed the code to always call release, the problem is this doesn't always work because as a caller, I need to understand that the backing memory is reference counted because Release will not call dispose automatically for me. If we made that happen with the default implementation, then always calling Release works and I would be ok with that. (Maybe the type shouldn't be disposable)

Should be resolved by #944? with example of AutoDispose pooling

@ahsonkhan, can you triage this issue? I would like to remove all System.Memory issues from corfxlab. thanks.

/cc @GrabYourPitchforks


[User Profile - Epic]  Enhance User Profile (Mobile/Desktop) Public Viewing Profile & User modifying Profile

To have two designs for profiles per use of platform.
One for desktop
One for mobile

Design for public profile viewing
Design for user editing / viewing public profile

To be similar, but the user will have more commands and actions to edit / modify content within their profile.

See YouTube channels as an example of how long a channel has been there.
Have the ability to search for users from a search engine as well?
See link for table and grid https://mui.com/x/react-data-grid/

Enhancements

[x] Prioritize user info from name to email
Name
User Name?
Email (If user wants it public)
Social Medias
Phone Number (If user wants it public)
[x] Show adopted trees, for personal view have the maintenance feature available to edit each tree.
[x] A Title you given yourself
Tree Care
Engineer
Flower Expert
[x] Add a bio
Show it have a character limit?
Show it be unlimited text?
[x] Add message/email button or call it contact info
Message
Contact Info
[x] Cover Photo for Profile
The Hero Image
[x] Add data on how many trees planted, photos taken, and followers
[x] Add location
Can be the specific location
Can be a general area (ex: San Francisco Bay Area)
Can be disabled for privacy reasons
[x] Tree Table Enhancement (Build off the existing table)
Design the user table
Design viewer tree table
Future Design to add to the Trees

List if the tree is part of an organization
List multiple owners if has more than 1
Original date planted
Awards
Past names

[x] Invite friend through email / text (See issue #215 ) (NEEDS ENGINEER TO BUILD OUT)
Design Graphic for Invite Friend
[x] Design Weather Section Right Column (See issue #321 ) (NEEDS ENGINEER TO BUILD OUT)
To have 4 scenarios

[x] Sunny
[ ] Cloudy
[ ] Rainy
[ ] Night

[x] Report Bug (FUTURE PLANS / COMING SOON) (See Issue #304 )
Design a lady bug to add to report bug
Redirect users to report bug page
[x] Have upcoming events / calendar events show up on the right column (FUTURE PLANS / COMING SOON) (See Issue #272 )
Be color coded per event type
[ ] Add badges (FUTURE PLANS / COMING SOON) #287
[ ] Add a follow/add friend button (FUTURE PLANS / COMING SOON)
[ ] Show any organizations they are part of (FUTURE PLANS / COMING SOON) wtt_front #267
https://docs.github.com/en/organizations/collaborating-with-groups-in-organizations/customizing-your-organizations-profile
[ ] Have default images for users to pick from (Design generic profile icons) (FUTURE PLAN)
https://support.mightycause.com/hc/en-us/articles/360031005092-How-to-Make-Your-Giving-Event-Profile-Awesome
[ ] Add how long the user has been a member (FUTURE PLANS / COMING SOON)
Do we just add the year?
The specific date?
Months?
Have this disabled for people who want it private?
[ ] Add interest (FUTURE PLAN)
Interest can be a category related to trees or unrelated
Can be a person who is an arborist
Can say interest is music
Cooking
Dogs
[ ] Photos Taken (FUTURE PLAN)
Can create folders of types
Favorites

Add Sections or tabs in profile

[ ] Trees adopted
[ ] Comments / Reviews (FUTURE PLANS / COMING SOON)
[ ] Photos Taken (FUTURE PLANS / COMING SOON)
[ ] Followers (FUTURE PLANS / COMING SOON)
[ ] Badges owned (FUTURE PLANS / COMING SOON) #287
[ ] Checked in locations (FUTURE PLANS / COMING SOON)
[ ] Organizations associated with (FUTURE PLANS / COMING SOON) #267

I can contribute. Assign me @ri0nardo

@saimaheshtaduri hi will you be able to work on this issue?

@jazhen @zoobot Started the redesign for the user profile. I am following the theme that was developed from the about us & contact us redesign.
Sort of alot going on that is new, but new fun things have been implemented.

Wanted your thoughts on the data where the cover photo is.
The weather report on the top right.
Having a public profile where people can come view what you did & a personal profile view where you can edit info.
I reorganized the table for trees. I wanted to limit the specificity of each category and bunch them.
Lastly, what do you think of the lady bug for reporting a bug? Thought it was a more appropriate bug people can feel comfortable with rather than a cockroach or other insects.

Note from 10/19/2022 meeting:

[ ] Jason comments how does the table adapt to mobile?
[ ] Jason comments how does the tree info bar come into play when a user wants to view details regarding their tree? Either goes to the map or the side bar comes out where the right column is. If sidebar appears, needs a button to go to map where the tree is.

Will proceed with a personal view of the profile. Public view of a profile will come later on once other things get implemented to have that option. The right column is not going to be implemented soon since the software isn't built out yet or hasn't even started.
Will need to clean up the tree table to proceed and be built.

@zoobot the column with weather etc would bring up the tree info sidebar. If the user wanted to do maintenance from their profile they could bring up all the info there. So no need for a placeholder tree image. It was a good suggestion by jason.

@zoobot would potentially look like the image below.

Mobile view.

I am reconsidering the design for the user profile. I am looking at a previous design from someone else that was working on this project and found a solution that may work better than what I currently designed for the user profile.
This list all the trees and you would click the tree to see the tree history rather than using a table. I do like this idea and want to take this further with the design I did have in place. The table does work on desktop, but for mobile it not ideal.
@zoobot what do you think of this previous design? I would have to revise and iterate on it to fit what I designed, but I do like this idea.

will update with mobile being a focus (not an after thought)
will have 3 main sections

trees
achievements
organizations
will be a tab sections with trees being the default.
will reuse the redesign profile section and use a previous design from someone else for the sections.
will add separate sections below the tabs, for other things related to a user profile.

currently liking this redesign that is mobile first. Its tab based where the default is trees. For the future we will have badges and organization list if needed (teams may not be that great of a use in this case).
I want to change the user tags, currently its

Name
User type
Location

I want to change it to

Name
Member since
N/A
The last one I dont really know what is really important.

Rather than listing the tree history with a table and checkbox, we can just create a list / box component of what maintenance was performed. Similar to what the tree history is. I dont want to have the color anymore, Ill want it to be more generic to begin with.


Fix broken link

Fix link to "What's new in 3.0" to correctly reference file name

Thanks

Just happy that I could contribue


Ignore specific instances of an Linter Error

Hey,
I would like to ask if it is possible to ignore specific instances of an Linter error.
I have following code:

which is showing an error but actually I want to unbind context of an not named model so this is exactly what I want to do. I don't want to disable WrongParametersLinter for the whole project, I would just like to ignore it in this line. Is there anything I can do to achieve this?

@iljapostnovs

Hi,
This works as documented by SAP, but you can add this method to exceptions in ui5 -> ui5linter un package.json:

Hey,
this method I am aware of. I don't want to do this as this will stop checking this method overall. What I am looking for is just ignore line below, something like @ts-ignore - i.e. ignoring next line with check, not all occurrences of it.

Yeah, there is no such feature currently. Probably will leave this as enhancement for the future.


Undefined index: 'direction'

https://github.com/howardjones/network-weathermap/blob/d081cc176e291c73dcfecd8f8c064d0d30fbacb2/lib/Weathermap/Core/Map.php#L1270
2018/09/14 10:32:09 - CMDPHP PHP ERROR NOTICE Backtrace: (/poller.php[676]:api_plugin_hook(), /lib/plugins.php[74]:api_plugin_run_plugin_hook(), /lib/plugins.php[177]:weathermap_poller_bottom(), /plugins/weathermap/lib/Weathermap/Integrations/Cacti/cacti-plugin-poller.php[176]:Weathermap\Poller\runMaps(), /plugins/weathermap/lib/Weathermap/Poller/poller-common.php[85]:Weathermap\Poller\MapRuntime->run(), /plugins/weathermap/lib/Weathermap/Poller/MapRuntime.php[178]:Weathermap\Poller\MapRuntime->writeHTMLFile(), /plugins/weathermap/lib/Weathermap/Poller/MapRuntime.php[261]:Weathermap\Core\Map->makeHTML(), /plugins/weathermap/lib/Weathermap/Core/Map.php[1210]:Weathermap\Core\Map->calculateImagemap(), /plugins/weathermap/lib/Weathermap/Core/Map.php[1270]:CactiErrorHandler())
--
2018/09/14 10:32:09 - ERROR PHP NOTICE in Plugin 'weathermap': Undefined index: direction in file: /var/www/cacti/plugins/weathermap/lib/Weathermap/Core/Map.php on line: 1270

Yes, it would seem that this commit https://github.com/howardjones/network-weathermap/commit/8a466469a87278b5a6dec77ddd7bfea8977257ac introduced the $info as an array but never defines any elements.  As such, there is no key 'direction'.  Changing the array() to array('direction'=>'') would resolve your issue temporarily, but I presume Howie just forgot to prime the direction when creating the object.

I also think that he simply forgot. Created a issue to see it.

Hmm, it worked in my tests... I will investigate shortly. It should only be looking for 'direction' on things where it has been set (the link drawing code sets it).

Is there anything unusual about your map, @pautiina? (like one-way links etc)

No, I have all the usual parameters. Until the last commit everything worked well.
Approximately everything looks like this:
# Automatically generated by php-weathermap v1.0.0dev

TITLE ISTEC NETWORK
WIDTH 1900
HEIGHT 1800
HTMLSTYLE overlib
KEYFONT 3

KEYTEXTCOLOR 0 0 0
KEYOUTLINECOLOR 0 0 0
KEYBGCOLOR 255 255 255
BGCOLOR 255 255 255
TITLECOLOR 0 0 0
TIMECOLOR 0 0 0

# All settings for scale DEFAULT
        SCALE DEFAULT 0    0      32 32 32
        SCALE DEFAULT 0    10     255 255 255  0 0 255
        SCALE DEFAULT 10   40     0 0 255  0 255 0
        SCALE DEFAULT 40   55     0 255 0  255 255 0
        SCALE DEFAULT 55   100    240 240 0  255 0 0
        SCALE DEFAULT 100  110    255 0 0  139 0 0

# All settings for legend DEFAULT
        KEYPOS DEFAULT 0 0 Traffic
        KEYSTYLE DEFAULT horizontal 400

# All settings for scale cactiupdown
        SCALE cactiupdown 0    0.5    192 192 192
        SCALE cactiupdown 0.5  1.5    255 0 0
        SCALE cactiupdown 1.5  2.5    0 0 255
        SCALE cactiupdown 2.5  3.5    0 255 0

# All settings for scale IFSTATUS
        SCALE IFSTATUS 0    1.5    0 255 0   Up
        SCALE IFSTATUS 1.5  2.5    255 0 0   Down

SET key_hidezero_DEFAULT 1

# End of global section

# TEMPLATE-only NODEs:
NODE DEFAULT
        LABELFONT 2
        USESCALE cactiupdown in percent
        MAXVALUE 100

# regular NODEs:
NODE IST_2
        LABEL IST_2
        OVERLIBGRAPH /cacti/graph_image.php?rra_id=0&graph_nolegend=true&graph_height=100&graph_width=300&local_graph_id=257
        ICON images/Host.png
        TARGET cactihost:4
        POSITION 200 350

NODE SWITCH
        LABEL SWITCH
        ICON images/PAD.png
        TARGET cactihost:527
        POSITION 850 270

NODE GATE
        LABEL GATE
        OVERLIBGRAPH /cacti/graph_image.php?rra_id=0&graph_nolegend=true&graph_height=50&graph_width=150&local_graph_id=3728 /cacti/graph_image.php?rra_id=0&graph_nolegend=true&graph_height=50&graph_width=150&local_graph_id=3729 /cacti/graph_image.php?rra_id=0&graph_nolegend=true&graph_height=50&graph_width=150&local_graph_id=3730 /cacti/graph_image.php?rra_id=0&graph_nolegend=true&graph_height=50&graph_width=150&local_graph_id=3731 /cacti/graph_image.php?rra_id=0&graph_nolegend=true&graph_height=50&graph_width=150&local_graph_id=3732 /cacti/graph_image.php?rra_id=0&graph_nolegend=true&graph_height=50&graph_width=150&local_graph_id=3733 /cacti/graph_image.php?rra_id=0&graph_nolegend=true&graph_height=50&graph_width=150&local_graph_id=3734 /cacti/graph_image.php?rra_id=0&graph_nolegend=true&graph_height=50&graph_width=150&local_graph_id=3735 /cacti/graph_image.php?rra_id=0&graph_nolegend=true&graph_height=50&graph_width=150&local_graph_id=3736 /cacti/graph_image.php?rra_id=0&graph_nolegend=true&graph_height=50&graph_width=150&local_graph_id=3737 /cacti/graph_image.php?rra_id=0&graph_nolegend=true&graph_height=50&graph_width=150&local_graph_id=3738 /cacti/graph_image.php?rra_id=0&graph_nolegend=true&graph_height=50&graph_width=150&local_graph_id=3739
        ICON images/Router.png
        TARGET cactihost:751
        POSITION 650 200

# TEMPLATE-only LINKs:
LINK DEFAULT
        ARROWSTYLE compact
        BWFONT 1
        BWLABELPOS 65 35
        BANDWIDTH 1000M

LINK GATE-CORE-SWITCH
        WIDTH 4
        INFOURL /cacti/graph.php?rra_id=all&local_graph_id=3743
        OVERLIBGRAPH /cacti/graph_image.php?rra_id=0&graph_nolegend=true&graph_height=100&graph_width=300&local_graph_id=3743
        TARGET /var/www/cacti/rra/751/3741.rrd
        NODES GATE CORE-SWITCH
        BANDWIDTH 10000M

It was simpler than that - I only committed half of the change! Should be working now. There are also now tests to check for the original issue (INNOTES being ignored).

The problem is not solved, as before, this error jumps out.

It doesn't for me... I'll make a fresh install and retest.
On Mon, 17 Sep 2018, 08:51 Alex<EMAIL_ADDRESS>wrote:

The problem is not solved, as before, this error jumps out.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/howardjones/network-weathermap/issues/154#issuecomment-421918422,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA3sJRpzI9ssBCSwCFvX20jlhvBo0b9Mks5ub1RwgaJpZM4Wow3O
.

While I did this way:
if (isset($area->info['direction']) and $area->info['direction'] == $dir) {

And do your NOTES/OVERLIBGRAPH all actually work if you do that? The fact that the info entry is missing makes me think that they won't. Anything which has overlib stuff attached should have the direction.

OVERLIBGRAPH - does not work

@netniV  can you test this bug on you system?

I haven’t setup weather maps yet on my test systems, guess I should do. I’ll try over the weekend.

Thanks

Fixed on some latest commit but NOTES/OVERLIBGRAPH not working

How about now? I've just spent a couple of hours going through the imagemap code...

on last commit I have forbiden

OK - so the new map display thing shouldn't be fetching files directly from the output/ directory. That needs to be fixed.

Opened #163 to track that.

This issue fixed


Replace ops fetch memories call

Instead of using the OPS API method ops_dat_fetch_data to get data from GPU, we are now using ops_dat_get_raw_pointer method. Because the first method do not bring back the data from the halo region.

Some issues when I did the rebase. I'll need to look in more detail.
I'll close this PR and then when ready I'll submit it again.


Kubernetes Manifest

I have set up my first draft of a Kubernetes manifest to run 1 Coordinator pod and 2 Worker pods. cloud-game-example.yaml.txt
Just to let you know I am using k3s for my Kubernetes cluster. It uses Traefik as the default Ingress Controller, and I am using NFS for the Persistent Volume to store the game files. So this manifest file is specifically built for that, but can be easily adjusted for other Ingress Controllers or Storageclasses.
The pods start up, and I am able to get to the web interface from my ingress address, but the list of games is empty. I can verify that the files exist in the running containers in the /cloud-game/assets/games folder.
I even did a test where I only spun up one container with the coordinator and worker as per the Make file. Not mounting the share in /cloud-game/assets/games and just using the games provided from the repo, that are saved in the image, gives the same result.
Using the same image with Docker on my desktop works as expected. I am using the following commands as I found out I do not need to run the containers as privileged for them to work.
docker run -v /data/cloud-game-2.2.0/assets/games:/cloud-game/assets/games -d --name cloud-game-front -p 8000:8000 -p 9000:9000 cloud-game.slim bash -c "coordinator --v=5"
docker run -v /data/cloud-game-2.2.0/assets/games:/cloud-game/assets/games -d --name cloud-game-worker1 cloud-game.slim bash -c "worker --coordinatorhost <IP_ADDRESS>:8000"
docker run -v /data/cloud-game-2.2.0/assets/games:/cloud-game/assets/games -d --name cloud-game-worker2 cloud-game.slim bash -c "worker --coordinatorhost <IP_ADDRESS>:8000"
So looking at the logs for the coordinator in the Kubernetes cluster, I do not see the line:
I0419 00:43:34.728558       1 handlers.go:133] A user connected to coordinator  /ws?room_id=&zone=  or anything past that.
The last line I have is:
Is public: false zone:  which seems like it is missing something.
So I have taken a quick look at the existing issues, and nothing seems to match. I will need to dig into the actual code to find out what is going on, but hopefully I can get some hints. :-)
For reference, here are the log files.
Kubernetes-worker2.log
Kubernetes-worker1.log
Kubernetes-coordinator.log
Local-worker2.log
Local-worker1.log
Local-coordinator.log
Thanks and have a good one.

Seems like the peer connection cannot set up with Kubernetes environment. Can you open all ports in kubernetes container to ease the p2p connection first to check if it work?

Hi @giongto35, sorry I am not the service management is a 1 to 1 ratio, so I would need to know what ports are being used by the coordinator to communicate with the browser client. I can then set that up.
I will also try my local docker setup, but try to access port 8000 from another computer.

I had some time to do some more tests, and I am getting the proper response from my Pixel 3 over Wi-Fi, but not from any of my desktops.
I updated the ingress to include an address using xip.io, so I didn't have to mess around with hosts files or setting up a live DNS record for my phone.
apiVersion: extensions/v1beta1
kind: Ingress
metadata:
name: cloud-game
spec:
rules:

host: <IP_ADDRESS>.xip.io
http:
paths:

path: /
backend:
serviceName: cloud-game-coordinator
servicePort: 8000

host: games.example.com
http:
paths:

path: /
backend:
serviceName: cloud-game-coordinator
servicePort: 8000

So right now it looks like my pi-hole, is causing an issue with resolving xip.io addresses on any of my computers at home (Linux and Windows). So I might have to set up a live DNS record that can resolve properly to fix this issue.
Otherwise, the game list shows up on my phone using the built-in games from the repo and the list of games from my NFS mount. So that is working. :-)

Thank you for a very detailed analysis. Seems like you are making a good progress when it's working with your phone (y).
Peer Connection is set up by random port, so we cannot know the specific one.
When I run docker for production, I run docker in host mode. Which is open all port to container
docker run --privileged -d --network=host -v /cloud-game/games:/cloud-game/assets/games.
I think Kubernetes should have the way to do the same :-?
I don't know much about Kubernetes set up (need to read about it first), so I think I'm not able to help now.

By design, you can not access all ports of a container running in Kubernetes. There is security in place to make sure that only ports that are necessary are shared outside the cluster or even between pods of containers. Is there a range of ports that would be used for the end user connections? Such as 10000-20000 ? I Should see that in the code as well, but I haven't had time to dig in yet.

Hi @tobimook ,
Thank you so much indeed, you made a very good foundation. I spent last weekend to read some documents about Kubernetes and K3s to help you. Currently, I can configure my staging environment based on your yaml file. I made some progress but may take more time to have it fully works. Can you commit your yaml file to kube/kubeconfig.yaml and I will take over your work from now. I will let you know when it is completed.
BTW I have a question why you set this flag "imagePullPolicy: Never". Is it kind of good practice? what is the problem of pulling image.

https://github.com/kubernetes/kubernetes/issues/23864 seeing the same problem here. Maybe it's not achievable :-


Fixed threading in the ProjectSystemPackage to make sure it uses the …

…UI thread when necessary. Tagging @dotnet/project-system @davkean for review.

@srivatsn for rc3 approval.


Validation PSNR not reflected after model is loaded when using batchnorm module

I have trained a denoiser using BFBatchNorm2d. In training, my validation dataset gives me ~37 dB. However, when I load the same model checkpoint and evaluate the network on the same dataset, I get an accuracy of 25 dB.
I am loading the trained model using:
model = model.load_from_checkpoint(checkpoint, strict=True)
My model was originally trained using PytorchLightning and the checkpoint successfully loads the batchnorm weights, running_mean, running_variance and bias (although unused).
I have tried to test with a batch size of 1 and 32 and this does not change things. All other functions are the same as my training code.
Is it possible that extra measure should be taken when loading or evaluating a model which includes BFBatchNorm2d?

My problem was that I was using Pytorch Lightning with the Trainer(syncbatchnorm=True) option. This redefined the custom batch norm layers in training. I have not had success bypassing this yet but closing the issue as it is not related to the custom batchnorm code itself.


Support for backstage integration in CLI

Describe the bug
The cli should give an option to generate files needed for backstage integration.
Expected behavior
The generated monorepo and microservices should have mkdocs.yml and catalog-info.yml files to integrate with backstage.
Additional context
Refer this doc for more info - https://roadie.io/blog/backstage-monorepo-guide/

Already done


no number of balls remaining

GG, But, Number Of Balls Remaining Is Not Available.

Need few more infos on this. Since v1.3 the ball number is shown on the bottom of the screen in portrait mode and in the sidebar in landscape mode. Is that not available?

I Mean To Say, In Original Pinball Game On WinXP, There Is 3/3, 2/3, 1/3 Type Of Display To Show How Much Balls Are Remaining. That's What Missing.

I Am Able To Use v1.2 (Since v1.3 Is Unable To Run On My Redmi 7A). In That, Even If You Are Playing Your Last Ball, Or Even Game Is Over, It Says "Balls 3". I Think That Issue Is Fixed In v1.3. I'm Not Sure.

That's the intended behavior. The games only shows the number of the current ball, with "Ball 3" meaning "you're playing your 3rd ball". That's the original behavior

I was also thinking that it would be useful to report how much balls are remaining (also to check if one got an extra/replay ball). I'm aware that this deviates from the original game and may be undesired.

Tracking the proposal of @mherrmann3 in #51 to keep things tidy


HiFA and prolificdreamer+HiFA

Fixed z-variance loss by normalizing weights. This is crucial to ensure that the model isn't encourage to generate empty pixels(since empty pixels have zero z-variance)
Added other HiFA(image space loss, annealing) changes to stable-diffusion-vsd-guidance, and created 2 corresponding configs(for prolificdreamer and prolificdreamer-scene). All changes are option based and do not change normal behavior if use_img_loss and sqrt_annealing are both set to false in config.  I had to pass the value of trainer's max_steps to system.guidance in launch script, since this is the only way to do annealing based on global steps.
Added HiFA config which is based on dreamfusion-sd. I made minor changes to dreamfusion-sd to look out for z-variance loss, and changed stable-diffusion-guidance similar to how i changed stable-diffusion-vsd-guidance.
Will do another pull request soon to update readme and link to my official repo(which was recently released). I'm still running experiments to search for the best z-variance hyperparameter in threestudio, will update that later too in that PR.

Hi Joseph, thank you for the contribution! I saw you're using stable-diffusion-guidance instead of stable-diffusion-unified-guidance for the HiFA implementation, where the latter provides useful options like return_rgb_1step_orig and return_rgb_multistep_orig which can make HiFA implementation much easier and keep a clean code structure. Could you please take a look?

sounds good, will take a look asap. One question: I only see this guidance used in magic123 and experimental/dreamfusion-sd. Isn't this going to make the changes I propose harder to adapt to existing systems since the guidance needs to be switched?

@JunzheJosephZhu Sorry for the inconvenience. stable-diffusion-unified-guidance covers all the functionality of stable-diffusion-guidance and ideally should be used in all systems. Feel free to use it in HiFA system and I'll switch the guidance in other systems to the unified guidance soon.

sounds good. all my code has been pushed. Could you go review the commit and approve it please?

Sounds good. All my code has been pushed. Could you go through the commit and approve it please?

Could we have a quick call? My wechat is<PHONE_NUMBER>1, would like to clarify
a few implementation details
On Mon, Dec 18, 2023 at 20:10 Ruizhi Shao @.***> wrote:

@.**** requested changes on this pull request.
Thank you for your work and effort! However, I noticed that there are many
modifications in this commit, some of which may not be necessary. We aim to
keep the original system unchanged to ensure rigorous academic comparison
with the original method. If there are new systems like HIFA, it would be
better to create new configurations and systems rather than modifying the
existing ones. In addition, modifications to the guidance should ideally be
integrated into the unified guidance.
I think the most important thing is to maintain the consistency and
clarity of our codebase. I appreciate your understanding and look forward
to your next commit.
On configs/dreamfusion-sd.yaml
https://github.com/threestudio-project/threestudio/pull/367#discussion_r1430014825
:
I think this modifications were not necessary.
On configs/experimental/co3d-imagecondition.yaml
https://github.com/threestudio-project/threestudio/pull/367#discussion_r1430015152
:
I think this modifications were not necessary.
On configs/experimental/imagecondition.yaml
https://github.com/threestudio-project/threestudio/pull/367#discussion_r1430015391
:
I think this modifications were not necessary.
On configs/experimental/imagecondition_zero123nerf.yaml
https://github.com/threestudio-project/threestudio/pull/367#discussion_r1430015611
:
I think this modifications were not necessary.
On configs/experimental/imagecondition_zero123nerf_refine.yaml
https://github.com/threestudio-project/threestudio/pull/367#discussion_r1430016802
:
I think this modifications were not necessary.
On configs/experimental/prolificdreamer-importance.yaml
https://github.com/threestudio-project/threestudio/pull/367#discussion_r1430016934
:
I think this modifications were not necessary.
On configs/experimental/prolificdreamer-neus-importance.yaml
https://github.com/threestudio-project/threestudio/pull/367#discussion_r1430017296
:
I think this modifications were not necessary.
On configs/experimental/prolificdreamer-propnet.yaml
https://github.com/threestudio-project/threestudio/pull/367#discussion_r1430018112
:
I think this modifications were not necessary.
On configs/experimental/unified-guidance/dreamfusion-sd.yaml
https://github.com/threestudio-project/threestudio/pull/367#discussion_r1430018644
:
I think this modifications were not necessary.
On configs/fantasia3d-texture.yaml
https://github.com/threestudio-project/threestudio/pull/367#discussion_r1430019152
:
I think this modifications were not necessary.
On configs/fantasia3d.yaml
https://github.com/threestudio-project/threestudio/pull/367#discussion_r1430019361
:
I think this modifications were not necessary.
On configs/gradio/dreamfusion-sd.yaml
https://github.com/threestudio-project/threestudio/pull/367#discussion_r1430019649
:
I think this modifications were not necessary.
On configs/gradio/fantasia3d.yaml
https://github.com/threestudio-project/threestudio/pull/367#discussion_r1430019821
:
I think this modifications were not necessary.
On configs/gradio/latentnerf.yaml
https://github.com/threestudio-project/threestudio/pull/367#discussion_r1430020040
:
I think this modifications were not necessary.
On configs/gradio/sjc.yaml
https://github.com/threestudio-project/threestudio/pull/367#discussion_r1430020237
:
I think this modifications were not necessary.
On configs/latentnerf-refine.yaml
https://github.com/threestudio-project/threestudio/pull/367#discussion_r1430020537
:
I think this modifications were not necessary.
On configs/latentnerf.yaml
https://github.com/threestudio-project/threestudio/pull/367#discussion_r1430020727
:
I think this modifications were not necessary.
On configs/magic123-coarse-sd.yaml
https://github.com/threestudio-project/threestudio/pull/367#discussion_r1430020995
:
I think this modifications were not necessary.
On configs/magic123-refine-sd.yaml
https://github.com/threestudio-project/threestudio/pull/367#discussion_r1430021220
:
I think this modifications were not necessary.
On configs/magic3d-coarse-sd.yaml
https://github.com/threestudio-project/threestudio/pull/367#discussion_r1430021422
:
I think this modifications were not necessary.
On configs/magic3d-refine-sd.yaml
https://github.com/threestudio-project/threestudio/pull/367#discussion_r1430023217
:
I think this modifications were not necessary.
On configs/prolificdreamer-geometry.yaml
https://github.com/threestudio-project/threestudio/pull/367#discussion_r1430023484
:
I think this modifications were not necessary.
On configs/prolificdreamer-patch.yaml
https://github.com/threestudio-project/threestudio/pull/367#discussion_r1430023675
:
I think this modifications were not necessary.
On configs/prolificdreamer-scene.yaml
https://github.com/threestudio-project/threestudio/pull/367#discussion_r1430023905
:
I think this modifications were not necessary.
On configs/prolificdreamer-texture.yaml
https://github.com/threestudio-project/threestudio/pull/367#discussion_r1430024104
:
I think this modifications were not necessary.
On configs/prolificdreamer.yaml
https://github.com/threestudio-project/threestudio/pull/367#discussion_r1430024280
:
I think this modifications were not necessary.
On configs/sjc.yaml
https://github.com/threestudio-project/threestudio/pull/367#discussion_r1430024542
:
I think this modifications were not necessary.
On configs/sketchshape-refine.yaml
https://github.com/threestudio-project/threestudio/pull/367#discussion_r1430024711
:
I think this modifications were not necessary.
On configs/sketchshape.yaml
https://github.com/threestudio-project/threestudio/pull/367#discussion_r1430024930
:
I think this modifications were not necessary.
On threestudio/systems/prolificdreamer.py
https://github.com/threestudio-project/threestudio/pull/367#discussion_r1430026530
:
I think this modifications were not necessary.
On launch.py
https://github.com/threestudio-project/threestudio/pull/367#discussion_r1430029948
:
I think this modifications were not necessary. You can set
system.guidance.trainer_max_steps=${trainer.max_steps} in config.
On threestudio/models/renderers/nerf_volume_renderer.py
https://github.com/threestudio-project/threestudio/pull/367#discussion_r1430034268
:
How about adding an option to choose z_variance or z_variance_hifa?
On threestudio/systems/magic123.py
https://github.com/threestudio-project/threestudio/pull/367#discussion_r1430035022
:
I think this modifications were not necessary.
On threestudio/systems/dreamfusion.py
https://github.com/threestudio-project/threestudio/pull/367#discussion_r1430035478
:
I think this modifications were not necessary.
On threestudio/models/guidance/stable_diffusion_guidance.py
https://github.com/threestudio-project/threestudio/pull/367#discussion_r1430039116
:
I think this modifications were not necessary. These changes can be merged
into unified guidance.
On threestudio/models/guidance/stable_diffusion_vsd_guidance.py
https://github.com/threestudio-project/threestudio/pull/367#discussion_r1430039641
:
I think this modifications were not necessary. These changes can be merged
into unified guidance.
On configs/experimental/unified-guidance/prolificdreamer.yaml
https://github.com/threestudio-project/threestudio/pull/367#discussion_r1430042744
:
How about creating a new config file named prolicdreamer-hifa.yaml?
—
Reply to this email directly, view it on GitHub
https://github.com/threestudio-project/threestudio/pull/367#pullrequestreview-1786724397,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AF2C6G34DBJWIRHTGLVOYYTYKAXC3AVCNFSM6AAAAABAXXWDVSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTOOBWG4ZDIMZZG4
.
You are receiving this because you were mentioned.Message ID:
@.***>

Hi @JunzheJosephZhu ,
I have invited you to join threestudio project. It would be better if you could create a branch and submit a new pull request.


Can we release scala 2.12 support in central maven repository

Currently I only see scala 2.11 support for mleap-xgboost-spark and mleap-xgboost-runtime in central maven repository, can you add release for scala 2.12, spark 2.4.5 has to use scala2.12

Hey billyean, I've been having a look at this today
Unfortunately it's not so easy. A package on which we depend (xgboost, see https://github.com/combust/mleap/blob/master/project/Dependencies.scala#L70) is not published for 2.12
But on the plus side, it seems that xgboost cross publishes for scala 2.12 starting from version 1.0.0

I'm trying to tackle that in https://github.com/combust/mleap/pull/708

thank you for update @lucagiovagnoli

+1 for this.
@lucagiovagnoli , maybe a good idea to separate the 2 goals of the PR? I'd be very interested in the xgboost upgrade.

+1

Hi everyone, sorry about the delay, I've been busy with some urgent internal work. I should get back to this by this week, hopefully today

+1 for this.
@lucagiovagnoli , maybe a good idea to separate the 2 goals of the PR? I'd be very interested in the xgboost upgrade.

Yes, in that PR I'm only upgrading xgboost 1.0.0

In case you're considering moving to a version beyond 1.0.0 (e.g. 1.1.1), it's available following these instructions: https://github.com/dmlc/xgboost/issues/6081#issuecomment-692301931

Found some issues with 1.1.1, there's some code out here: https://github.com/combust/mleap/pull/718 but I probably won't have time to dig deeper


Add autoImportSpecifierExcludeRegexes preference

Closes #55092
This has the limitation that it doesn't compose very intelligently with the importModuleSpecifierEnding preference—you can set that to "js" and then write a regex that excludes \.js$ and the result will be that you get no (relative) auto imports at all. But I think I'd like to try this and get feedback.

@sandersn yes, they will, after the corresponding VS Code PR.

not sure if it is worth opening separate issue as it might already been discussed.
Would it be an option to improve this feature to allow specifying for which files the exclusion apply?
In other words, as an example, while in shared-package, i want auto imports for all files, however, while in another-package, i only want to allow shared-package/index.ts and nothing else from there.

I’m assuming you’re using relative imports within shared-package, so you can just exclude ^shared-package/ everywhere.


broken out Impacket - smbexec, wmiexec

Details
What does this PR have in it? Screenshots are worth 1000 words 😄
Checklist

[ ] Validate name matches <platform>_<mitre att&ck technique>_<short description> nomenclature
[ ] CI/CD jobs passed ✔
[ ] Validated SPL logic.
[ ] Validated tags, description, and how to implement.
[ ] Verified references match analytic.

looks great!


TypeError: Cannot read property 'appendChild' of null

Have you read the FAQ and checked for duplicate open issues?
What version of Shaka Player are you using? 2.5.4
Can you reproduce the issue with our latest release version? Yes
Can you reproduce the issue with the latest code from master? Yes
Are you using the demo app or your own custom app? Custom app
If custom app, can you reproduce the issue using our demo app?
What browser and OS are you using?
Chrome 75 in macOS Mojave
For embedded devices (smart TVs, etc.), what model and firmware version are you using?
What are the manifest and license server URIs?

Any stream with subtitles
What did you do?

Load the video and unload+destroy
What did you expect to happen?
No errors in the console
What actually happened?

Error shown in the console:
shaka-player.ui.js?:formatted:18944 Uncaught (in promise) TypeError: Cannot read property 'appendChild' of null
    at new mq (shaka-player.ui.js?:formatted:18944)
    at new eval (player-control.js:1081)
    at Ha.eval [as b] (shaka-player.ui.js?:formatted:12356)
    at Ma (shaka-player.ui.js?:formatted:498)
    at Na.next (shaka-player.ui.js?:formatted:529)
    at eval (shaka-player.ui.js?:formatted:334)
    at new Promise (<anonymous>)
    at ma (shaka-player.ui.js?:formatted:330)
    at t (shaka-player.ui.js?:formatted:339)
    at fl (shaka-player.ui.js?:formatted:12349)
    at eval (shaka-player.ui.js?:formatted:11972)
    at Object.vf (shaka-player.ui.js?:formatted:12015)
    at Ha.eval [as b] (shaka-player.ui.js?:formatted:11545)
    at Ma (shaka-player.ui.js?:formatted:498)
    at Na.next (shaka-player.ui.js?:formatted:529)

I noticed you skipped the question "If custom app, can you reproduce the issue using our demo app?"  I tried in our demo, v2.5.4, and I can't reproduce the issue.  Here are my steps:

Load the compiled version of the demo app (since I see compiled code referenced above).
Click "Play" under "Angel One".
Use the controls UI to turn on subtitles.
Open the JS debugger and run:

player = shakaDemoMain.controls_.getPlayer();
// I assume this is what you mean by "unload+destroy"?
player.unload();  player.destroy();

Can you be more specific about how you're reproducing this error?  What particular methods are you calling on the player object?

I'm using the Shaka Player UI but only the Text displayer. The rest is custom (my app is written in angularjs) and the problem is reproduced the destroy the component.
const videoContainer_ = document.getElementById('videoplayer');
const video_ = document.getElementById('video');
const player_ = new shaka.Player(video_);
player_.configure(
  'textDisplayFactory',
  () => {
    return new shaka.ui.TextDisplayer(video_, videoContainer_);
  }
);

I found that the TextDisplayer it not checking that video and videoContainer exists in the constructor. With the next lines the issue it's not longer reproduced:

I found that the TextDisplayer it not checking that video and videoContainer exists in the constructor.

These are required arguments, so I think you are using shaka.ui.TextDisplayer wrong.  If there's no video element, for example, we can't time the display of captions to the video.  And if there's no video container, we have nowhere to place the DOM elements that display the captions.

I'll try to find another solution. Thanks


Support for tagging in Lambda functions

Now that Lambda functions support tagging, please add the following for the lambda resource type:

Include tag information in output
Filters: marked-for-op
Actions: auto-tag-user, mark-for-op, remove-tag, tag

@kapilt I'll take care of this

Resolved with https://github.com/capitalone/cloud-custodian/pull/1092


TypeError: Cannot read property 'element' of undefined

open ts file
trigger IntelliSense
select an item with the mouse
type space, trigger IntelliSense again
select an item with the mouse
💥 the list widget explodes

index.js:31 [uncaught exception]: TypeError: Cannot read property 'element' of undefinedonError @ index.js:31(anonymous function) @ index.js:100emitOne @ events.js:96emit @ events.js:188window.onerror @ init.js:120
index.js:34 TypeError: Cannot read property 'element' of undefined
    at ListView.element (file:////Users/jrieken/Code/vscode/out/vs/base/browser/ui/list/listView.js:96:37)
    at file:////Users/jrieken/Code/vscode/out/vs/base/browser/ui/list/listWidget.js:366:91
    at Array.forEach (native)
    at file:////Users/jrieken/Code/vscode/out/vs/base/browser/ui/list/listWidget.js:366:25
    at EventBufferer.bufferEvents (file:////Users/jrieken/Code/vscode/out/vs/base/common/event.js:338:13)
    at List.setFocus (file:////Users/jrieken/Code/vscode/out/vs/base/browser/ui/list/listWidget.js:364:32)
    at MouseController.onPointer (file:////Users/jrieken/Code/vscode/out/vs/base/browser/ui/list/listWidget.js:198:23)
    at file:////Users/jrieken/Code/vscode/out/vs/base/browser/ui/list/listWidget.js:187:89
    at ListView.fireScopedEvent (file:////Users/jrieken/Code/vscode/out/vs/base/browser/ui/list/listView.js:187:13)
    at HTMLDivElement.handler (file:////Users/jrieken/Code/vscode/out/vs/base/browser/ui/list/listView.js:174:55)

Let me know if this is suggest using the list widget wrong.

Oh, and after that the suggest widget is totally broken. Keep throwing the same error until reload

Needs these settings:
	"files.autoSave": "onFocusChange",
	"files.trimTrailingWhitespace": true

Reverted.

@bpasero The root cause for this is that "files.autoSave": "onFocusChange" saves to early, namely when the cursor loses focus, not when the editor loses focus. That also repos with other things like Cmd+F. In this particular issue the cursor loses focus when an element is clicked, triggers trim tailing whitespace, cancelling suggest. Now the exploding list widget just covers the real mess which is that you cannot insert a suggestion via click in the presence of certain settings. So unless I miss something instead of onDidBlurEditorText the onDidBlurEditor-event should be used.

An event emitted when the text inside this editor or an editor widget lost focus.

Reading the API doc actually not sure anymore. @alexandrudima does above mean there is no editor blur event which is basically 'this editor orand an editor widget lost'

@jrieken @alexandrudima I once had used onDidBlurEditorText and onDidBlurEditor for auto save and got bugs that under some situations auto save was not triggered (including yourself). So I reverted that back to my solution because I did not want and do not plan to break auto save like that. I am not sure why the event seems to sometimes not fire...

@bpasero This is the first I hear about the blur event not firing. That would mean the cursor would still be blinking... even though focus is somewhere else. If you have a repro please let me know.

Unsure how #17729 is related to that but I think if there is an issue blur not being fire that should be fixed. Today, the behaviour is pretty bad because all those save participants (format, trim whitespace, apply quick fix) kick in as soon as the cursor blurs, e.g when searching inside the editor

Yeah I agree. I can either bring back to use the editor events (which I like provided the work reliably) or add a timeout to my blur listener to avoid running save during the event bubbling phase.

The timeout won't work for things like Search, F8 error navigation or any other peek view. We should go back to the before event and understand why it doesn't work at times

Fixed via https://github.com/Microsoft/vscode/issues/21273


Change font-family of CNRichTextEditor

How to change my font-family in CNRichTextEditor ?

Not able to reset write any text on CNRichTextEditor  like TextInput reset . Please tell me if any one about of this

Not able to change font family in CNRichTextEditor using react-native-cn-richtext-editor@next

same problem.

Not able to change font family in CNRichTextEditor using react-native-cn-richtext-editor@next

same problem. do you fix it?


fix: allow for parsing json parsing when timestamps are empty

The Tailscale API returns blank strings for non-existing timestamps, such as the "created" timestamp for Tailscale managed devices. One example is the "hello" device that is returned in the get devices endpoint.
This will introduce a new struct called MaybeEmptyTime which wraps stdlib's time.Time struct and is able to Unmarshal Tailscale's representation of a missing timestamp.

Hey @pellegrino, thanks for another good contribution! I'm just in my way home from a weekend trip but will do a proper review this evening.

Thanks for the review! I've just made the changes you suggested. Just let me know if you would like to have it changed further.

This looks good to me, I'll merge this and publish a new release.


Ideograms do not have a key

It would be nice to have a key to explain the colours.

Solved in 53bc65d.


Cannot use framework in Swift

I'm able to build and generate the xcframework just fine, but when it comes to using it, both in my own project and the provided demo project, I can't import the framework in code. i.e. import openssl or import OpenSSL using xcode 12.2

Maybe some new entry in Xcode "Build settings" regarding xcframeworks specifically (search paths come to my mind)? To be honest I use this in ObjC code only.

To use it from Swift, you'll need to add a Modules/module.modulemap file inside each openssl.framework folder that tells Swift what the the module definition is. This one has worked for my needs, though I haven't tested whether it exposes the full API:
framework module openssl [system] {
    umbrella "."
    textual header "e_os2.h"
    textual header "opensslconf.h"
    textual header "opensslv.h"
    exclude header "asn1_mac.h"

    export *
}

@keeshux was this implemented? I cannot figure out what I need to import in Swift or what header I need to include in my bridging header to make  to make this work. The Demo project includes neither in its source code. I've tried adding the cocoapod to my project, installing via the SwiftPM, and copying the final xcframework to my project after checking out the project.
I also tried adding objective-c files to my project, but it fails on #include <OpenSSL/OpenSSL.h>.  And I'm not sure what header to replace it with.
Any kind of guidance would be helpful.

In Obj-C, you may want to try @import OpenSSL;. For explicit headers, use #import over #include.

With @import OpenSSL (and @import openssl) are still giving me module not found errors with the xcframework copied to my project.


Add a <Switch> to non-repeating <Route>s in App.js

Some <Route>s need to be on every page (like the one for the header). Those ones shouldn't be in the <Switch>. Others cancel each other out - if we're on the About page, none of the form stuff matters.
We need to put a <Switch> in the appropriate place and maybe switch up which order the routes appear in so that we can always get to the right place (one 'load' may need to be in a different order).

Yeah this makes sense to me. Although it works the way it is now, semantically having a <Switch> for the main content makes sense, and I think it could enable more flexibility for routing in the future.


♻ refactor rspec files

I will implement shared_context and shared_examples in the future. Before that, I would like to refactor rspec files to map library files to rspec files.
This structure is supported by rspec-mode of emacs or "rails go to spec" plugin of vscode.

@st0012
I understood.
I fix *_spec.rb path.
Could you recheck it?


Verify workflow commit SHA against list of SHAs in repository

In repositories where commits will frequently be squashed and force pushed, the list of workflow runs will contain commit SHAs that are no longer actually in the repository. When using commands that depend on a valid SHA (such as the nx affected command), this will cause problems in subsequent steps.
This PR introduces an optional, disabled by default, way to validate the SHA of a workflow run against the list of commits actually in the repository.
Note that this will require the checkout step to increase the depth of the checked out tree - the README has been updated to reflect this requirement.

Thanks for the quick reply. We use this in our CI right now, and while it's not without flaws (e.g. we're not handling pagination in the list of workflow runs) it should cover most usecases.
Will update our CI to use your version as soon as you've released it.

It is already tagged as v2


Timx 283 oaidc field method refactor

Purpose and background context
Field method refactor for base transform class OaiDc.
Note: Linters are failing for transmogrifiers.sources.xml.springshare, which will be addressed in a later PR!
How can a reviewer manually see the effects of these changes?

Run make test and verify all tests are passing.

Includes new or updated dependencies?
NO
Changes expectations for external applications?
NO
What are the relevant tickets?

https://mitlibraries.atlassian.net/browse/TIMX-283

Developer

[ ] All new ENV is documented in README
[ ] All new ENV has been added to staging and production environments
[ ] All related Jira tickets are linked in commit message(s)
[ ] Stakeholder approval has been confirmed (or is not needed)

Code Reviewer(s)

[ ] The commit message is clear and follows our guidelines (not just this PR message)
[ ] There are appropriate tests covering any new functionality
[ ] The provided documentation is sufficient for understanding any new functionality introduced
[ ] Any manual tests have been performed and verified
[ ] New dependencies are appropriate or there were no changes

And let's resolve the Signature of "get_dates" linter issue before we merge this PR, happy to assist

@ghukill @ehanson8 Please see the latest three (3) commits for updates based on our sync yesterday! See Summary of changes via Field Method Refactor
 for more details.


Develop preprocessing

This branch includes Python code to replicate the parser pre-processing that is undertaken by the scala code in the beta.

Yes, you are correct. The original lambda was more complicated than just calling the function. I think I ended up putting all the code in a separate function but forgot to review the map code. :-\
I’ll fix it later – I doubt it’ll have a major effect on performance. ;-)
James
From: Alexandre Bedrytski<EMAIL_ADDRESS>Sent: 17 May 2017 09:25
To: ONSdigital/address-index-data<EMAIL_ADDRESS>Cc: James Hoskisson<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [ONSdigital/address-index-data] Develop preprocessing (#74)
@Mironor approved this pull request.
All good aside from this optional lambda

In DataScience/ProbabilisticParser/common/tokens.pyhttps://github.com/ONSdigital/address-index-data/pull/74#discussion_r116937443:

@@ -222,6 +249,43 @@ def tokens2features(tokens):

 return feature_sequence

+def replaceSynonyms(tokens):

"""

This function replaces all of the words in the synonym list with their synonyms.

:param tokens: the list of tokens to replace with synonyms.

:type tokens: list of strings.

:return tokens: the synonymized list.

:type iterator: iterateas throught the list of strings.

"""

tokens = map(lambda x: synonym(x), tokens)

Correct me if I'm wrong, but can't you do map(synonym, tokens) instead?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/ONSdigital/address-index-data/pull/74#pullrequestreview-38598379, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AZeht3QyqkfhtwM85OO8889i7ZCorAkiks5r6q75gaJpZM4NckM_.


Doesn't mixed complementarity constraint require lower and upper bounds on the variable?

The package promises a support for the Mixed Complementarity Problem (MCP). From the short description in the QuickStart guard it appears that it is just the Linear Complementarity Problem (LCP), that is supported instead. Am I right?

Nope - this supports general MCPs, i.e. the functions G(.) and H(.) need not be linear in x and y. The example in the readme was just an LCP though as you’ve identified. Regarding lower and upper bounds, this package and the description in the readme follow the definition of MCPs provided in chapter 1 of the book by Facchinei and Pang; there are other equivalent formulations though and PrimalDualMCP structs can be constructed with lower and upper bounds (with some caveats per the docstrings of those functions). Does this help?

Thanks for the response.
I have checked the reference you give. Indeed, they define MCP (MiCP, as they call it) the way you describe. That is, besides the (nonlinear) complementarity constraint given by $0\leq v \bot H(u,v) \geq 0$ they also impose the additional constraint $G(u,v) = 0$.
I think I might need some time to see if it is consistent with the definitions used elsewhere, in particular the existence of lower and upper bounds (by quickly looking at your source code, I cannot find any discussion of these in the docstrings). Besides the Wikipedia pages I have already linked, this is how MCP is understood in JuMP: https://jump.dev/JuMP.jl/stable/tutorials/nonlinear/complementarity/. Similarly in PATH: as described in their paper.
I would not be surprised to learn that these two formulations are somehow equivalent. It is just that at this moment I cannot see it.
Perhaps it can be useful for the authors of the package to learn that there are potential users of their package who are coming with a different definition of MCP in mind.

Yep 100% agree. One day soon there should be a tutorial on this - whether it is here or in ParametricMCPs I am not yet sure. For the moment, you can see the connection by reading off the KKT conditions:

the G(x, y) = 0 part corresponds to “gradient of Lagrangian wrt primal variables is zero, and equality constraints must be satisfied” parts of KKT
the 0 \le H(x, y) \perp y \ge 0 similarly reconstructs the inequality constraints on the primal and appropriate dual variables, and complementarity

So, this establishes the correctness of the G-H formulation. To see the connection fully, we can reconstruct these conditions from the lower and upper bound formulation:

define K(x, y) = [G; H]
define z = [x; y]
Write out the formulation for the MCP as K(z) \perp lb \le z \le ub, where lb = -\infty for entries corresponding to y and lb = 0 for entries corresponding to x; ub = \infty for all entries

for entries where z = lb = 0 we see that K \ge 0 recovers primal feasibility for inequality conditions, ie. H \ge 0, and part of complementarity
otherwise, z will never be equal to \pm \infty so we will force K = 0, which recovers the other part of complementarity and Lagrangian stationarity

Closing this issue for now. Please do reopen it (or a separate one) as appropriate!


Updated IntrepidSwiftWisdomTesting for Swift 3.

I updated the version of IntrepidSwiftWisdomTesting.podspec to 0.7.3 because its source is https://github.com/IntrepidPursuits/swift-wisdom.git.
Updated Readme to refer to swift-wisdom instead of intrepid-wisdom for installing testing additions.
Updated IntrepidSwiftWisdom dependency.

I would just run it through a test project if you haven't already done so, but it looks good, thanks for taking this on!

This pod predates the unified Intrepid pod and it's subspecs. It seems like this would be a good time to migrate this into being a Intrepid subspec too.


Remove recursion from MatchFinder

Summary
This replaces a somewhat complicated recursive method with an almost equally complicated loop. The advantage is that loops are faster than recursion. More refactoring can be done in the future to clean up the code.
The benchmark code changes take an average of running the code many, many times so that the measurements can be more accurate.
Benchmark

Before: 12.3 ms
After: 10.4 ms
Difference: 1.9 ms
Improvement: 15%

Side Note
I tried to remove the NoMatch class and replace it with simply returning nil.  It actually was slower than keeping the NoMatch class and I have no idea why!

@jwoertink Would you be able to review this?

I always forget about this repo 😂

@jwoertink any chance you meant to merge this?

Not quite. I'm going to wait for 1 more approval on this. @paulcsmith will take a look after he has some free time, but it might be a bit. We just want to make sure we have all the edge cases covered. We might need to add a few specs in just to be sure, but we're hoping that there's no weird side affects from this 😄

I'd love to take a look at this to make sure it handles some of the trickier edge cases that most routers don't get. Especially since routing is so core to Lucky. I've been very busy, but will try to take a look soon!


chore: update eslint to newer version

With previous configuration running npm install would install eslint
packages that did not work together.
Closes #28

Why closed?
Thanks, could you change the commit message to follow our convention please?


Http1ObjectEncoder.combine may fail if both futures fail for the same reason

With Armeria 1.22.1, on an unstable connection with many timeouts, I am observing the following issue once in a while
java.lang.IllegalArgumentException: Self-suppression not permitted
	at java.base/java.lang.Throwable.addSuppressed(Throwable.java:1064)
	at com.linecorp.armeria.internal.common.Http1ObjectEncoder$1.operationComplete(Http1ObjectEncoder.java:156)
	at io.netty.util.concurrent.DefaultPromise.notifyListener0(DefaultPromise.java:590)

Root cause, which is likely not relevant to this issue, is :
Caused by: io.netty.handler.ssl.SslClosedEngineException: SSLEngine closed already
	at io.netty.handler.ssl.SslHandler.wrap(SslHandler.java:861)
	... 53 common frames omitted

I suppose that addSuppressed should be skipped if firstCause == secondCause

Caused by: io.netty.handler.ssl.SslClosedEngineException: SSLEngine closed already
at io.netty.handler.ssl.SslHandler.wrap(SslHandler.java:861)
... 53 common frames omitted

I'm curious how often this occurs and which version this warning log started to appear 🤔
May I ask what the previous version was before upgrading?

It didn't appear on an upgrade, but when using a particularly bad HTTPS endpoint. I couldn't reproduce.


Fix difference link in readme

Codecov Report

Merging #84 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master    #84   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files           3      3
  Lines         175    175
  Branches       27     27
=====================================
  Hits          175    175

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af8f646...5484609. Read the comment docs.

thanks

:tada: This PR is included in version 1.5.17 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Redis SCAN cursor exceeds Long.MAX_VALUE resulting in NumberFormatException

Redis SCAN cursor exceeds Long.MAX_VALUE resulting in NumberFormatException. The issue with Java signed long value decoding/parsing with Redis scan unsigned long cursor id. (https://github.com/spring-projects/spring-data-redis/issues/2796)
Expected behavior
SCAN command must work without any errors or exceptions
Actual behavior
Throws below exceptions
java.lang.NumberFormatException: For input string: "9286422431637965696"
org.redisson.client.RedisException: Unexpected exception while processing command
Steps to reproduce or test case
We are cleaning up Redis cache on System startup using RedissonClient.getKeys().getKeysByPattern("abc*", 1000);
Redis-cli output
somevalue.serverless.use1.cache.amazonaws.com:6379> SCAN 0 MATCH "abc*" COUNT 100

"9286422431637964944"

"abc-715E466A-3090-4DB7-A8A5-0E242B60DD06"
"abc-8AD311AA-C36A-48AE-A431-C7DF57497439"

Redis version
We are using AWS Elasticache Redis 7.1 Serverless
Redisson version
Redissson v3.20.0 and v3.24.0
For Redisson v3.25.0 and v3.25.1 throws RedisTimeoutException/RedisConnectionException - The same configuration is working for Redissson v3.20.0 and v3.24.0
Redisson configuration
singleServerConfig:
idleConnectionTimeout: 10000
connectTimeout: 10000
timeout: 120000
retryAttempts: 3
retryInterval: 1500
username: null
password: null
subscriptionsPerConnection: 0
clientName: ReeferServiceClient
address: rediss://somevalue.serverless.use1.cache.amazonaws.com:6379
subscriptionConnectionMinimumIdleSize: 25
subscriptionConnectionPoolSize: 100
connectionMinimumIdleSize: 24
connectionPoolSize: 100
database: 0
dnsMonitoringInterval: 5000
pingConnectionInterval: 30000
threads: 16
nettyThreads: 32
codec: !<org.redisson.codec.SerializationCodec> {}
transportMode: NIO
lockWatchdogTimeout: 20000

Fixed. Can you try the master branch?


Fixed #32193 -- Deprecated MemcachedCache.

ticket-32193

buildbot

@pope1ni Thanks :+1: Updated.

Thanks both :+1:


chore: runtime JAR files in the classpath should have the same version

Fixes #335
Changes:

we set the reflect version manually from the versions file

@iamareebjamal @mariobehling @yashk2000 please review

Just a warning which may get cleared in recent version. Not an error in our code, hence no addition should be made in our code


Loosen ActiveRecord restriction to < 6.2

This is blocking me from upgrading from 0.6.0 (which works fine with AR 6.1), any chance of a 0.7.1 with this merged?


Standardise 'related-area-of-need' in edit-goal controller

Whilst creating the edit-goal controller, I somehow switched from 'related-area-of-need' to 'other-area-of-need'
This PR just goes through and updates any references to 'other area of need' to be 'related area of need'

Apologies, looks like merging has ruined the history on this. All you need to do is review the content in this commit https://github.com/ministryofjustice/hmpps-sentence-plan-ui/pull/114/commits/773a5efcaade473d529d9d04f98fdfd880bc0f10

This looks good. Could we also get refactors of the selectOtherAreasOfNeed and selectOtherAreasOfNeedRadio used in create-goal.cy.ts please?

Addressed in https://github.com/ministryofjustice/hmpps-sentence-plan-ui/pull/114/commits/fd4f7983020cebc31a2951c6b06f13c47d8ca7a8


[Bug]: ADS Dropdown component empty state UI broken

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior

Steps To Reproduce

Create datasource with incorrect configs
Generate CRUD page using it.
Open table dropdown
See the error

Environment
Release
Version
Cloud

This issue is fixed.


Header is not responsive

The header isn't working on smaller viewport sizes.  We should get it working on any screen size.

I didn't considered this during the development process. Can I be assigned for this to fix the issue?

@Ririio you never need to ask, go ahead and fix any/all bugs we have.

Closed with #212


[mempool] add extra protection against txn expiration in pulled block

Motivation
On validators, consensus uses system time to determine block timestamp
In mempool, we can take advantage of this to add extra protection against expired txns in blocks pulled by consensus, by gc'ing txns that are expired at the time of pulling a block based on system time

@bors-libra r=phoenix-antigravity

:pushpin: Commit a9ab5fb has been approved by phoenix-antigravity

:hourglass: Testing commit a9ab5fb3c12115c51ebf24c4bb3f7afc624cac53 with merge eaaf8e0b231423d8025a5cd4aeaa7a07cfa1e61f...

:sunny: Test successful - checks-actions_land_blocking_test, checks-circle_commit_workflow
Approved by: phoenix-antigravity
Pushing eaaf8e0b231423d8025a5cd4aeaa7a07cfa1e61f to master...


bug:

Unable to get partial results while fetching entities via DGS federation.
Expected behavior
Both errors and data are returned based on the entities fetched by DGS federation:
{
  "errors": [
    {
      "message": "Child with id 12345 not found",
      "extensions": {
        "code": "DOWNSTREAM_SERVICE_ERROR",
        "serviceName": "child_service",
        "errorType": "INTERNAL",
        "exception": {
          "message": "Child with id 12345 not found",
          "locations": [],
          "path": [
            "_entities"
          ],
          "stacktrace": [
            "GraphQLError: Child with id 12345 not found",
            "    at downstreamServiceError (/dev/apollo-gateway/node_modules/@apollo/gateway/src/executeQueryPlan.ts:633:10)",
            "    at /dev/apollo-gateway/node_modules/@apollo/gateway/src/executeQueryPlan.ts:448:9",
            "    at Array.map (<anonymous>)",
            "    at sendOperation (/dev/apollo-gateway/node_modules/@apollo/gateway/src/executeQueryPlan.ts:447:38)",
            "    at processTicksAndRejections (node:internal/process/task_queues:95:5)",
            "    at async /dev/apollo-gateway/node_modules/@apollo/gateway/src/executeQueryPlan.ts:360:41",
            "    at async executeNode (/dev/apollo-gateway/node_modules/@apollo/gateway/src/executeQueryPlan.ts:243:9)",
            "    at async executeNode (/dev/apollo-gateway/node_modules/@apollo/gateway/src/executeQueryPlan.ts:223:17)",
            "    at async executeNode (/dev/apollo-gateway/node_modules/@apollo/gateway/src/executeQueryPlan.ts:191:32)",
            "    at async /dev/apollo-gateway/node_modules/@apollo/gateway/src/executeQueryPlan.ts:76:27"
          ]
        }
      }
    },
    // More errors go here...
  ],
  "data": {
     "getParents": [
            {
                "id": 45,
                "children": [
                    {
                        "child": {
                            "id": "70207"
                            "name": "child-name"
                        }
             },
     ]
  }
}

Actual behavior
data: null along with bunch of errors are returned:
{
  "errors": [
    {
      "message": "Child with id 12345 not found",
      "extensions": {
        "code": "DOWNSTREAM_SERVICE_ERROR",
        "serviceName": "child_service",
        "errorType": "INTERNAL",
        "exception": {
          "message": "Child with id 12345 not found",
          "locations": [],
          "path": [
            "_entities"
          ],
          "stacktrace": [
            "GraphQLError: Child with id 12345 not found",
            "    at downstreamServiceError (/dev/apollo-gateway/node_modules/@apollo/gateway/src/executeQueryPlan.ts:633:10)",
            "    at /dev/apollo-gateway/node_modules/@apollo/gateway/src/executeQueryPlan.ts:448:9",
            "    at Array.map (<anonymous>)",
            "    at sendOperation (/dev/apollo-gateway/node_modules/@apollo/gateway/src/executeQueryPlan.ts:447:38)",
            "    at processTicksAndRejections (node:internal/process/task_queues:95:5)",
            "    at async /dev/apollo-gateway/node_modules/@apollo/gateway/src/executeQueryPlan.ts:360:41",
            "    at async executeNode (/dev/apollo-gateway/node_modules/@apollo/gateway/src/executeQueryPlan.ts:243:9)",
            "    at async executeNode (/dev/apollo-gateway/node_modules/@apollo/gateway/src/executeQueryPlan.ts:223:17)",
            "    at async executeNode (/dev/apollo-gateway/node_modules/@apollo/gateway/src/executeQueryPlan.ts:191:32)",
            "    at async /dev/apollo-gateway/node_modules/@apollo/gateway/src/executeQueryPlan.ts:76:27"
          ]
        }
      }
    },
    // More errors go here...
  ],
  "data": null
}

Steps to reproduce

Have the following schema definitions on parent service side:

type Parent @key(fields: "id") {
    id: Long!
    children: [Child!]!
}
type ChildRelation @key(fields: "id") {
    id: String!
    child: Child!
}
type Child @key(fields: "id") @extends{
    id: String! @external
}

Have the following schema definitions on child service side:

type Child @key(fields: "id") {
    id: String!
    name: String!
}

Have the following components defined in child service:
entity fetcher:

@DgsComponent
class ChildEntityFetcher {
    @DgsEntityFetcher
    fun childEntityFetcher(
        values: Map<Any, Any>,
        dfe: DgsDataFetchingEnvironment
    ): CompletableFuture<Child> {
        val childId: String = values["id"].toString()
        val loader: DataLoader<String, Child> = dfe.getDataLoader(ChildDataLoader::class.java)
        return loader.load(childId)
    }
}

Data loader:
@DgsDataLoader
class ChildDataLoader(
    private val myParentService: MyParentService
) : MappedBatchLoader<String, Try<ParentData>> {

    override fun load(keys: MutableSet<String>): CompletionStage<Map<String, Try<ParentData>>> {

        return CompletableFuture.supplyAsync {
            val results = myParentService.getParentDataByIds(keys)
                .associate { it.id to Try.succeeded(it) }
                .toMutableMap<String, Try<MyParentData>>()
            for (key in keys) {
                results.putIfAbsent(key, Try.failed(DgsEntityNotFoundException("Child with id $key not found")))
            }
            results
        }
    }
}

As far as I understand the fact that I return Try wrapper instead of data should make it possible to do a partial loading though it seems this is not the case.

Make any request to parent service to fetch parent with its children, for example:

query getAllParents {
    getAllParents {
        id
        children {
            id
            child {
                id
                name
            }
        }
    }
}

Make sure data and errors blocks are filled in the response.

I upgraded some DGS dependencies and this seems to be working now, thank you!


Trouble importing Tqdm in Swift 5.9

Hi, thanks for porting tqdm over to Swift! For some reason though, I have trouble using your library in the Swift 5.9. When I do swift build, the compiler keeps complaining about:
product 'Tqdm' required by package 'test-swift-tqdm' target 'test-swift-tqdm' not found.

I made a minimal repro by creating a blank Swift executable using swift package init --type executable: https://github.com/AlienKevin/test-swift-tqdm

I don't know what changed in SPM, but I found two solutions for the error:

Specify target dependency product:

// ...
targets: [
   // Targets are the basic building blocks of a package, defining a module or a test suite.
   // Targets can depend on other targets in this package and products from dependencies.
   .executableTarget(
     name: "test-swift-tqdm", dependencies: [.product(name: "Tqdm", package: "swift-tqdm")])
 ]

Specify package name in the dependencies. Note that, this pattern is deprecated and I don't recommend this:

.package(name: "Tqdm", url: "https://github.com/ebraraktas/swift-tqdm.git", from: "0.1.2")

Anyway, it may be better to rename rename the repository and package, but for now I will keep it this way and update related part in the README.


Update vendor/golang.org/x/sys

Please ignore this PR for now (see #4817). I am trying to use the CI to see if updating vendor/golang.org/x/sys builds fine as pointed out by @techknowlogick .

Thanks for PR ❤ You may also need to commit the lock file.
Can you try running make vendor too. that may help clear up the CI Fail. I'm sorry for not giving you the correct instructions.

@techknowlogick I don't know what I'm doing wrong. These are my steps:

Modify Gopkg.toml
Run 'make vendor' and commit all the files it produces on vendor/
Run 'make test-vendor' and no errors are emitted.

The CI is generating a patch, is that supposed to be generated by some script and committed prior pushing?

@tuxillo
edit Gopkg.toml to  follow master
[[constraint]]
branch = "master"
name = "golang.org/x/sys"
Execute :
dep ensure -update golang.org/x/sys
git add Gopkg.toml Gopkg.lock vendor/golang.org/x/sys

and you should be good to commit and push to PR.
From what you have already done, I think you just forgot to add change of Gopkg.lock (git add Gopkg.lock)

@sapk no luck. I tried exactly with your instructions with both branch and revision but none worked. I must be missing something.
The results of the failure show as if some files should not be there.

@tuxillo I test those in #5169 but the diff of your lock file seems strange. For exemple digest where removed and not updated. What version of dep are you using ?

Let me describe my process.
I'm using Ubuntu 18.04.1 LTS. So from https://docs.gitea.io/en-us/install-from-source :

go get -d -u code.gitea.io/gitea
cd ~/go/src/code.gitea.io/gitea/
git checkout master
git pull
git checkout -b patch-1

And then from there I do the instructions you guys provided. dep version is:
$ dep version
dep:
 version     : devel
 build date  :
 git hash    :
 go version  : go1.8.3
 go compiler : gc
 platform    : linux/amd64

Try to do go get -u github.com/golang/dep/cmd/dep to update to the latest version of dep.

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@e500b82). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff            @@
##             master   #5059   +/-   ##
========================================
  Coverage          ?   37.5%
========================================
  Files             ?     309
  Lines             ?   45791
  Branches          ?       0
========================================
  Hits              ?   17174
  Misses            ?   26156
  Partials          ?    2461

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e500b82...6cc33de. Read the comment docs.

@sapk that did it! Thanks.

The constraint is only use for dep ensure -update or dep status ortherwise dep ensure will only follow the lock file. For example you can update to master the toml and let the lock to the current commit it shouldn't complain.

@tuxillo Thanks to @sapk explaining to me in another PR, what he has suggested is the better course of action. I was too cautious when there was no need for it.

For information, the constraint where lock to a specific commit at the migration from the previous vendor tool to limit the number of change during the migration.

@sapk @techknowlogick I've just done the change including the master branch. Please check.

😄 Thanks for the PR
Looks like #5169 will probably be merged before this one, but I'll be sure to merge this one right after

Excellent! Thanks a lot for guiding me.
I think after updating x/sys gitea will build in some systems where it didn't before. NetBSD and SmartOS at the very least.

@tuxillo alright. This has been merged. Thank you again for the PR 😄 Hopefully it works for the platforms that you need it to.


freebsd port www/nginx-devel patch

Add file for freebsd ports tree patch

Hi, what is the difference from other OS ?

Hi.
This PR not actual now.
Differences - filename, path for file.


Fix issue of not being able to open the browser action on mac

Fixes #58
Adding the "mac" key I could get this to work successfully.

Shortcut is actually working fine for me on a Mac, did you verify it doesn't work for you without adding the mac key? If so, can you check under about:addons if the shortcut is set correctly and doesn't conflict with some other extension?

You are right about this, it is working without this. So closing this PR.