Docker image size

Hi I found this project yesterday and it looks amazing. It was really cool to be able to play a PSX game from a browser.
I started with the 2.2.0 release, so there might be some changes in master already.
I am going to get this up and running on my Kubernetes cluster, but the first thing I noticed is that the docker image is quite large. (1.6 GB).
So I used one of my favorite docker tools https://dockersl.im/ and made it more manageable. When I have some time I would like to look more into the docker build process and set up a multi-stage build so it is cleaner from the start.
Here is the command that I used:
./docker-slim build --target cloud-game:2.2.0 --entrypoint 'bash -c "coordinator --v=5 & worker --coordinatorhost localhost:8000"' --include-path /cloud-game/ --include-shell
And the results:

REPOSITORY
TAG
IMAGE ID
CREATED
SIZE

cloud-game.slim
latest
b81ff8b56dc6
6 seconds ago
261MB

cloud-game
2.2.0
9feaf879f08a
2 hours ago
1.63GB

golang
1.12
ffcaee6f7d8b
2 months ago
810MB

Once I have the Kubernetes manifest, I will share with here to help someone else get it up and running.

I also have trouble with docker build size, I think it is quite slow indeed. One of the reasons is that I upload Golang vendor into the docker build I think. But it's truly amazing that docker slim can help reduce the size from 1.63GB -> 261MB without any manual manipulation.
Multi-stage can help some speed up, I would love to have your help on that. :D Thank you very much.

Doesn't even run properly on Windows, and who needs it anyway (:

Multi-stage can help some speed up

Multi-stage build won't help with docker build speed (proper context or .dockerignore do help), it helps in shrinking the size of the resulting image. It's even possible to shrink it to ~50Mb or less with Alpine and release build of the app (~30Mb).
I'm looking forward to see proper k8s config wich is interesting. Thanks for help/

@sergystepanov  thank you for correct my understanding on multi-stage docker build :+1:
I think I'm going to check k8s config as well.

HI guys,
Yes I am a Linux users, so most of what I use doesn't work in Windows without a VM ;-).
I agree the main reason to use a multi-stage build would be to have a smaller image at the end.
I have finished my first draft of my Kubernetes manifest, but I am having an issue, so I will open a new issue for that. Once I take a look at the Dockerfile, I will update here.

Fixed in #190.


Adding pull_secret_rotated.json

This adds a template for when SRE has rotated an account's pull secret and the customer is being informed of the action.
This will accompany a SOP update to https://github.com/openshift/ops-sop/blob/master/v4/howto/rotate_pull_secret.md which will reference this template.
Non-goals, but something to look at in a future PR:

Removing some of these other pull secret related templates, if they contradict or don't align with our current processes around pull secrets.

/approve

/lgtm


WARNING ocrd_exif - ImageMagick 'identify' not available

For example ocrd-sbb-textline-detector --overwrite -I OCR-D-IMG-BIN -O OCR-D-SEG-LINE-SBB-TLD -P model "/var/lib/textline_detection gives this warning:
16:42:12.171 WARNING ocrd_exif - ImageMagick 'identify' not available, Consider installing ImageMagick for more robust pixel density estimation

This comes from OCR-D/core. The pixel density calculation of ImageMagick is more robust than PIL in my experience, hence we delegate to identify if it is available in $PATH. If it is not, we fall back to PIL to get the PPI.

Yeah, I thought so, I just need to include ImageMagick in the core images.


The link for angular_components code-lab in README is broken

https://codelabs.developers.google.com/codelabs/your-first-angulardart-web-app shows Forbidden 403.
Adding a / at the end of the URL can fix the problem.
https://codelabs.developers.google.com/codelabs/your-first-angulardart-web-app/
The link on https://webdev.dartlang.org/angular/ is broken for the same reason.

Thank you! Care to send a PR? I'll merge it immediately @furrary

Sorry, I really want to help out, but I'm a total beginner and really don't know how to send a PR. 😢

Strangely, those URLs work for me. But I believe you. I can fix this bug.

/cc @Sfshaza: codelab URLs might fail without the trailing /.

I've reported this issue against the codelab infrastructure. Thanks very much for letting us know about it, @furrary!

This should be fixed now on the codelabs website.
Thanks again for noticing.

The codelabs team has quickly responded with a workaround that makes URLs like https://codelabs.developers.google.com/codelabs/your-first-angulardart-web-app work. (But it doesn't hurt to have / there.)

https://codelabs.developers.google.com/codelabs/your-first-angulardart-web-app is now working for me


Search

Nice tool, works great.  Is there a function to search for specific messages?
thanks,

There isn't. However, it would be fairly simple to add one that searched through headline information (subject, to, from). Would this be of any use to you? A full text search of email content is rather beyond the intended scope of the tool.
Dijji

Hello and thanks.  Yes!  A search as you describe would be incredibly useful.  Thanks again.

This has been addressed in the release of Version 1.6
Let me know what you think.

Search works -yeah!!!
I think would be better highlighting matching messages and/or filtered list

Thank you for the feedback, it is always much appreciated.
I could claim artistic differences (I believe that you can get everything done either way, e.g., searching backwards through 2010 for a mail with bread in the subject), but actually, my clincher here was degree of difficulty.  Outlook deals with this by presenting partial results, then adding to them as a background worker comes up with more. Pretty complex. But if you only look for one message at a time, the implementation is much simpler and you only get the delays in the extreme cases of long stretches between hits, not on every search through a large folder.
Dijji


[Question] Any chance to implement only remove images option?

I have a use case where in development I want to keep running, exited and created containers, and only remove images that are not used by them.
Apologies for not knowing bash well enough to make a PR.

We are currently in the process of overhauling our flags to allow for more flexible options so this should be an option in our new release!

If you take a chance to look through some of the new options you should be able to make this work.  If you are simply looking to remove unused images running docker-clean -i -t (or --images --tagged) will remove all untagged and tagged images that aren't being used by any containers and will not remove any containers.  Trying with a --dry-run will demonstrate this for you as well, like this: docker-clean -i -t -n

Awesome, thanks


Remove GenericLocations and persist orientation

I think this should be fixed now.  This was a problem with orientation not being set in the Location that comes from SBOL Designer.  Actually, it appears that SBOL Designer gives each SA two Locations.  One is a Range and the other is a GenericLocation.  The GenericLocation appears to contain the orientation, but the Range does not.  I’ve changed iBioSim to search all the locations looking for the orientation.
Michael: you might consider copying the orientation into the Range to make them consistent.  You also might prune the GenericLocation when there is a Range.
It actually does not harm to be there, as long as we remember to search all locations and not just grab the first.  It is also not wrong to be there.  If it is easier to deal with in the cases where perhaps a sequence is removed, that is okay.  It is just a matter of bookkeeping.

Done.


chore(package): update flow-bin to version 0.79.1

Closes #41

Pull Request Test Coverage Report for Build 161

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 87.179%

Totals

Change from base Build 126:
0.0%

Covered Lines:
63

Relevant Lines:
70

💛  - Coveralls


Updates README.md

 You should sign our Contributor License Agreement in order to get your pull request merged.


WIP: feat(generate-config): create config with existing service account

rhoas generate-config should not create service-account.
Verification Steps

Generate configuration by specifying --type to be configmap

rhoas generate-config --type=configmap

It should create a configmap object.
Unlike previous version, rhoas generate-config shouldn't create a service account.

ToDo:

Add validation for flag combinations
Add validation to check if the service account credentials provided are valid
Add a message for the breaking change

Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation change
[ ] Other (please specify)

Service accounts (generally any credentials cannot be passed thru flags due to bash history. We had initial design for that case in docs. Idea was to use json file provided from service account command

We had initial design for that case in docs. Idea was to use json file provided from service account command. WDYT?

I was planning to go with it in the beginning, but it occurred to me that credntial can be in some other format too, for which user wll have to reconstruct it, that could be bit time taking, hence dropped the idea to have it as main method to get the credentials.

Service accounts (generally any credentials) cannot be passed thru flags due to them being saved in plain form to bash history.

I will agree, hence there are twoflags - --client-secret-stdin that will take up the secret from standard input and --client-secret to pass as argument for CI/CD environment. WDYT?

We can use json file as input and env variables presence(user running .env file) Do we need more options?

some other format too

I would not be worried about it because:

Json is default
User will generate service account specifically for this purpose
We will add validation and description
guide/docs will reflect it

Since we designed that command many things changed:

we now have secret in service accounts as output - enabling openshift integration there

I'm wondering if we actually approached problem right:
Do we really want to supply users service account?
Remember that we would have that already in user desired format. Maybe we just want to stop creating service account as part of generate command?
That will have numerous benefits:

Generate can be called many times without side effects and paired with service account file
We can better reflect openshift story:
Credentials would be in secret but urls can be configmap

@rkpattnaik780 we need to put some research on this as there are different opinions how we should do it.
Mainly there is big trend in current users to disable sa creation in context generate command.
Another option is to provide flag for that use case etc. We might need to drive some proper pros and cons and see how this affects our future roadmap (helm etc.)

FYI (low priority) @jackdelahunt @dimakis

Is that good to be verified?

Is that good to be verified?

Yes, I will be updating help texts and examples in a while.

I think we might need to add some documentation/msg. Something like:
Generate config finished successfully. You can now create new service accounts in order to connect to the service

Verification steps work 👍


build-rs crate API design

The #12432 issue adopted the build-rs crate, but I haven't seen discussion on how its API should look like.
The API of the already-released versions happens to be a very direct mapping of functions to the existing printed cargo:… directives. This has an advantage of being immediately familiar to Rust/Cargo users, but because the API keeps using global state and emitting Cargo directives as a side effect, it remains difficult to coordinate interaction with Cargo across build-time dependencies.

Build-time dependencies have a dilemma whether they should emit cargo: directives automatically to have a convenient robust API, or not, and let the caller decide what to emit. cc and pkg-config crates have an option to disable printing of cargo: directives, but this is all-or-nothing, and it's not easy for callers to customize and filter the directives.

Build-time dependencies can't emit cargo:error from Result-based APIs, because the caller of the function could recover from the error. However, this prevents libraries from emitting well-formatted Cargo errors when their callers use library.call().unwrap().

Build-time dependencies can't emit rerun-if-changed by default, because presence of any such directive disables Cargo's standard heuristics. This needs to be configured on case-by-case basis for each build dependency, because there's no standard way for build scripts to specify whether they want the standard heuristics or not.

The global stateless functions don't have ability to be customized in the future, unless the configuration would be global as well. However, global configuration doesn't compose well, so build-time dependencies would struggle to use it without causing issues for other parts of the build script.

Cargo doesn't have first-class support for handling build scripts failing via a panic. Cargo just gets usual rustc output as an opaque text, which isn't formatted like a native Cargo error (with color output, etc.), and includes a panic stack trace that is irrelevant for most build scripts, especially sys crates.

Some of these issues could be solved by build dependencies themselves offering richer APIs, but I think there's an opportunity for the build-rs crate to improve Cargo's interface and offer a standard way of composing build dependencies.

At least for now, I do not see us trying to offer this as a stable enough API for build script libraries to expose in their API.
For myself, I see this overall as low level, offering users the building blocks for a build script in a more type safe manner without providing opinions on how to do things.  The most high level I've considered adding is env variable tracking like build_env

I think the API could be future-proofed with a very small change: move the global stateless functions to be methods on an object.
let b = build_rs::Build::new();
b.rerun_if_changed(path);
b.

For now this would be a zero-sized object, but eventually it could become configurable to e.g. discard or buffer the directives instead of printing them immediately, and that could be passed to other dependencies as the build environment to use.

For myself, I think its important that we offer a low level API that maps to the bare interface that Cargo provides.  I have been wondering about having a type that the API is built around but more so what we print to and read from can we swapped out for testing purposes.  I think any other higher level constructs would be out of scope for that type.

Note that I didn't say that build-rs (or another crate) should never support anything more.  I said specifically that we should have an API that allows people to do low level operations that forms the basis of anything else on top.  Maybe one way to think of what I am suggesting is that we start with is a type-safe, rust-analyzer integrated version of Build Scripts and Environment variables Cargo sets for build scripts.
One crate can offer APIs that fill different roles (high level or low level).  I do think its too early to be designing such a thing as we're still figuring out what the low level API should be!  We need to iterate and get this API right, figure out what MSRV expectations are especially post-MSRV-aware resolver, what people's build-time expectations are, etc.  Any of those could tank this effort.
We then need to look at and maybe help with experimenting with what to build on top.  What patterns exist?  What policy works generally?  If you have an idea for this, please, go and create a crate and let us see what we can learn from the effort.


Add Knowledge Gradient candidates functions

Motivation
Knowledge gradient acquisition functions can perform better on certain problems since they have lookahead unlike myoptic acquisition functions such as Expected Improvement.
Description of the changes
I've added 2 new candidates functions:

qkg_candidates_func for single objective problems
qhvkg_candidates_func for multi-objective problems
both of which support constraints.

Although the user could implement these themselves, it is non-trivial so it makes sense to add them to optuna-integration IMO.
The tests have also been updated to test these acquisition functions.

@alxhslm Thank you for this PR!
@eukaryo Could you review this PR?


Feature request: unknown function

I would love to have an "unknown" function like the one in Tcl. No more, no less. Just a "port" to Zrc with the same design and behavior.
Not extremely important or urgent, I just thought I should ask while I still can log in to Github. :-\
Thank you.

Seems pretty trivial to implement. We just check if fn unknown exists and call that procedure.
I'll implement this along with everything else in the following days, because school started again and I didn't have time to work on the shell this week.


Merge in narrative display object updates

The major changes were to make display objects for Taxons.

Merging.

need to change your target branch to narr-integrate again


scipy.stats.binned_statistic_dd sample and values dims mismatch

Hi, I'm getting this error
AttributeError: The number of `values` elements must match the length of each `sample` dimension.

while using binned_statistic_2d function as in  this example
import numpy as np
from scipy import stats

data  = np.random.randn(1000, 119)
stats.binned_statistic_dd(data, data, statistic='mean', bins=(2, 2, 1))

I took a small peak at the code and noticed that the dimensions for the values and sample are stored in values that are reversed i.e
https://github.com/scipy/scipy/blob/b4bfa9de3e838122d31722194dc273fffeabadf0/scipy/stats/_binned_statistic.py#L472
and
https://github.com/scipy/scipy/blob/b4bfa9de3e838122d31722194dc273fffeabadf0/scipy/stats/_binned_statistic.py#L483
while this is being done
https://github.com/scipy/scipy/blob/b4bfa9de3e838122d31722194dc273fffeabadf0/scipy/stats/_binned_statistic.py#L486
Could this be a bug ?
Also is it possible to have an example for this function included in the docs? There seems to be none.
Thanks

This is not a bug. The first argument is coordinates at which to sample, documented as (N, D) - numbers of elements, number of dimensions. You're asking for a 119-dimensional histogram here.
This works:
data = np.random.randn(1000, 3)
stats.binned_statistic_dd(data, np.arange(1000), statistic='mean')

That said, the documentation is indeed pretty confusing, and this needs a good example. For now look at the example in binned_statistic_2d.

@rgommers thanks! this works

fixed in gh-10392, thanks all


Possibility to get 1,5,10,15,20 random flashcards from deck

Adding methods and tests to dao and resources to get random flashcards. Method in FlashcardDao is adapted to h2 database and temporary.

There are some minor issues, but everything seems to be all right :)

Thanks!


USB connectivity should always be preferred over WIFI

overview
I operate my OT2 from a laptop which is physically adjacent. I always plug in the USB cable. However, it's hit and miss as to whether when I scan for my bot in the Opentrons App whether it shows up as WIFI connectable or USB connectable.
And even after being connected for a long time, this is still the case: I just completed a run lasting more than two hours for example, went to the app, did a 'refresh list' on the Robot pane, and my bot still comes up as WIFI connectable, not USB.
This is significant because the USB connection (when available) is more reliable and can have significantly less latency than the WIFI connection. Using WIFI, I have, for example, experienced lag of nearly a second or so during calibration in response to my pressing an arrow key. And full-on dropouts occur from time-to-time when using WIFI (really annoying during calibration, as I then have to reload my protocol, which takes nearly ten minutes; less annoying once the protocol is running).
current behavior
USB connectivity is rarely availalbe in the app, even when the robot is physically connected.
steps to reproduce
See above.
expected behavior
If the OT2 is physically connected by USB, the USB cable should always be used for connectivity.

The OT2 is definitely connected, yet is not discovered over USB by the app:

@rgatkinson, thanks for ticketing this.
The intent is definitely for the app to prefer USB when it's available. But the way USB connections work is a little temperamental. So, the app isn't preferring Wi-Fi – it's falling back to Wi-Fi when USB doesn't work, which is often.
Current workarounds include:

Restarting the computer
Restarting the network adapter
Using Command Prompt to release the network adapter's IP and let it autoassign a new one for itself

This issue has proven difficult to track down because it only happens on some Windows 10 computers. If you could provide some system information, it would be very helpful in our investigation. You can email it to<EMAIL_ADDRESS>if you'd prefer.

System info is as follows:
OS Name	Microsoft Windows 10 Pro
Version	10.0.18362 Build 18362
Other OS Description 	Not Available
OS Manufacturer	Microsoft Corporation
System Name	RGATKINSON
System Manufacturer	System manufacturer
System Model	System Product Name
System Type	x64-based PC
System SKU	SKU
Processor	Intel(R) Core(TM) i7-6700K CPU @ 4.00GHz, 4008 Mhz, 4 Core(s), 8 Logical Processor(s)
BIOS Version/Date	American Megatrends Inc. 3801, 2018-03-14
SMBIOS Version	3.0
Embedded Controller Version	255.255
BIOS Mode	UEFI
BaseBoard Manufacturer	ASUSTeK COMPUTER INC.
BaseBoard Product	MAXIMUS VIII EXTREME
BaseBoard Version	Rev 1.xx
Platform Role	Desktop
Secure Boot State	On
PCR7 Configuration	Binding Not Possible
Windows Directory	C:\WINDOWS
System Directory	C:\WINDOWS\system32
Boot Device	\Device\HarddiskVolume2
Locale	United States
Hardware Abstraction Layer	Version = "10.0.18362.387"
User Name	RGATKINSON\bob
Time Zone	Pacific Standard Time
Installed Physical Memory (RAM)	32.0 GB
Total Physical Memory	31.9 GB
Available Physical Memory	19.3 GB
Total Virtual Memory	36.7 GB
Available Virtual Memory	22.0 GB
Page File Space	4.75 GB
Page File	C:\pagefile.sys
Kernel DMA Protection	Off
Virtualization-based security	Not enabled
Device Encryption Support	Reasons for failed automatic device encryption: TPM is not usable, PCR7 binding is not supported, Hardware Security Test Interface failed and device is not Modern Standby, Un-allowed DMA capable bus/device(s) detected, TPM is not usable
Hyper-V - VM Monitor Mode Extensions	Yes
Hyper-V - Second Level Address Translation Extensions	Yes
Hyper-V - Virtualization Enabled in Firmware	No
Hyper-V - Data Execution Protection	Yes

System info from laptop is as follows:
OS Name	Microsoft Windows 10 Pro
Version	10.0.18362 Build 18362
Other OS Description 	Not Available
OS Manufacturer	Microsoft Corporation
System Name	RGATKINSON-2019
System Manufacturer	LENOVO
System Model	20KHCTO1WW
System Type	x64-based PC
System SKU	LENOVO_MT_20KH_BU_Think_FM_ThinkPad X1 Carbon 6th
Processor	Intel(R) Core(TM) i7-8550U CPU @ 1.80GHz, 1992 Mhz, 4 Core(s), 8 Logical Processor(s)
BIOS Version/Date	LENOVO N23ET65W (1.40 ), 2019-07-02
SMBIOS Version	3.0
Embedded Controller Version	1.15
BIOS Mode	UEFI
BaseBoard Manufacturer	LENOVO
BaseBoard Product	20KHCTO1WW
BaseBoard Version	SDK0J40697 WIN
Platform Role	Mobile
Secure Boot State	On
PCR7 Configuration	Elevation Required to View
Windows Directory	C:\Windows
System Directory	C:\Windows\system32
Boot Device	\Device\HarddiskVolume1
Locale	United States
Hardware Abstraction Layer	Version = "10.0.18362.387"
User Name	RGATKINSON-2019\bob
Time Zone	Pacific Standard Time
Installed Physical Memory (RAM)	16.0 GB
Total Physical Memory	15.9 GB
Available Physical Memory	6.80 GB
Total Virtual Memory	18.2 GB
Available Virtual Memory	6.35 GB
Page File Space	2.38 GB
Page File	C:\pagefile.sys
Kernel DMA Protection	Off
Virtualization-based security	Not enabled
Device Encryption Support	Elevation Required to View
Hyper-V - VM Monitor Mode Extensions	Yes
Hyper-V - Second Level Address Translation Extensions	Yes
Hyper-V - Virtualization Enabled in Firmware	Yes
Hyper-V - Data Execution Protection	Yes

FYI: If it's useful, I can arrange for y'all to be able to temporarily remote into this unit for debugging.

Thank you! I'll let you know if we decide to take you up on that offer.

The screenshot posted may be indicative of the robot failing to bring up its own link-local interface. We've observed this happen on one robot in house, but were not able to reproduce once we fixed it. Ping @sfoster1

Update, don't know if it's relevant, thought I'd relate just in case. Just rebooted both laptop and OT2 this Monday morning, and at the moment at least it's visible over USB:

Additional update:

Rebooting OT2 (using 'reboot' command from ssh) caused loss of USB connectivity once reboot completed.

Subsequent reboot of laptop restored same.

Closing this ticket because:

The app already prefers the USB-to-Ethernet IP address of a given robot if it can reach the robot at that IP address
The lack of interface availability appears to be related to the computer itself in some way, in that rebooting the computer fixes the issue

The app doesn't interact with the interface / adapter directly; it just tries to hit IP addresses it knows about. If your computer isn't properly assigning a link-local address to the adapter and/or setting up routes, then the app isn't going to be able to reach the IP address of robot on the other end of the USB-to-Ethernet adapter and there's nothing the app can do about it.
There's definitely the possibility that there's also a problem on the robot side of things, but I'm unable to reproduce any sort of robot-side failure to self-assign a link-local address (via hard power cycle or via SSH reboot). Will continue to investigate and re-open and/or update this ticket accordingly


Error Message (for all actions) HttpResponse[Status=Not Found, StatusCode=404] [{"errorCode":"NOT_FOUND","message":"The requested resource does not exist"}]

Full error message:
Phase: EXECUTE Message: Invoke Action Error: System.HttpResponse[Status=Not Found, StatusCode=404]
[{"errorCode":"NOT_FOUND","message":"The requested resource does not exist"}]
System.HttpRequest[Endpoint=callout:Mass_Action/services/data/v47.0/actions/custom/flow/Create_AMCCs_PPCC, Method=POST]
{ "inputs" : [ { "VarAMR_ID" : "a1j3c000002bDv8" } ] } ExceptionType: dca_mass_action.MA_Exceptions.InvokeActionException
StackTrace: Class.dca_mass_action.MA_MassActionUtils.sendHttpRequest: line 1080, column 1
I double checked the report and flow, alongside re-creating the mass action however it keeps coming back to this issue....
Please assist as this action has a core role in our org.

I had this error after skipping a few versions when upgrading. I deleted the connected app, auth provider and named credential, then recreated using the MAS setup wizard.
This resolved it just I was weighing up the difficult decision of either doing a fresh install and rebuilding all of the configurations, or killing myself.

This worked for me as well, thank you for posting!


API access to incontrols()

There is a use case (or several?) for wanting to know if a link or node participates in a simple or rule-based control. The one I have in mind is network simplification, where you want to preserve elements that do participate. This is possible using the current API functions, but I believe it's cumbersome and requires a fair amount of knowledge about the control/rule structures.
On the other hand, incontrols() in project.c does exactly this. It would be simple to expose that, for example as another case in getlinkvalue/getnodevalue.

this is a great addition, in the category of convenience functions. Plus we have the benefit of the implementation already existing in the engine code. I will create a branch dev_feature_in_control to receive a PR. Thanks @jamesuber !

further conversation on this issue will be directed to #596


move: automated address mgmt for pkg upgrades

Description
This PR adds automated address management support for sui client upgrade. I'm building this out iteratively so that it's easier to reason about and ensure backwards-compatibility during the transition when a package does not yet have info tracking in Move.lock (i.e., supporting package publish will come next).
High-level:

If a package contains a Move.lock that contains info to support a package upgrade, then that is used, and a user does not have to (nor should they) maintain a published-at address in their Move.toml.

If a package does not have any Move.lock information to support a package upgrade, we will still fallback to Move.toml as we do today. Nothing changes.

If a package has both a Move.lock and Move.toml, then the Move.lock will be used (the user is free to delete published-at in their Move.toml). Caveat: If a published address is in both of these files, they must be the same (we will raise a Conflict error message otherwise).

Note after this PR it is still required to set [addresses] to 0x0 in Move.toml. This requirement will be removed after publish support is added (which also requires setting to 0x0 still). I didn't want to meddle with that logic all at once.

Test plan
How did you test the new or updated feature?
We cover three cases:

Upgrade with Move.toml only (existing package upgrade test)
Upgrade with Move.lock only (extension of existing package management test)
Upgrade with Move.lock and Move.toml with conflicting addresses error condition (new test)

Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.

[ ] Protocol:
[ ] Nodes (Validators and Full nodes):
[ ] Indexer:
[ ] JSON-RPC:
[ ] GraphQL:
[ ] CLI:
[ ] Rust SDK:

thanks for your enthusiasm @stefan-mysten! There is a snag and I need to update some things in this PR, but we are indeed close!!

thanks for your enthusiasm @stefan-mysten! There is a snag and I need to update some things in this PR, but we are indeed close!!

Cool, let me know when that's fixed and I will get a review in!


Add a scanner status section

I think this was lost while we were working on the scanner.
We should have a place in the header where we indicate what's the status of the scanner (Analyzing, Finished).
Maybe in the top right of the header of the results summary?

@ststimac, @qzhou1607 assigning this to you.

We never had a status so this is a new piece to add.


Date-Range and Format

I have a problem with date-range. I want to set a different format (dd-mm-yyyy), this works fine if I use just date-time, for that I changed the format the hard way in: dateTimeConfig. But this doesn't work on date-range. I'm new to angular, but wanted to use this datepicker in the angular-grid. It works fine, except for this format problem :confused:
Is there a way to get the wanted format also in the date-range?
Thanks :)

It's not possible right now, but for what i can see it's not a hard job to add this. i will look into it.


Allow to configure the prefix of the commands that are executed internally

Allows you to set the prefix of the command to be executed with the following commands.

bundle install
bin/rails redmine:plugins:migrate

This is to allow these commands to be executed in environments where Redmine is running in a docker container, such as docker compose or redmined.

As a just idea, i'm considering the following specs for this feature:
# .extensiosns.rb
config command_prefix: "docker compose exec app"

plugin :any_plugin, github: { repo: "any/plugin.git" }
...

With the above configuration, the commands such as bundle install will be executed as follows:
docker compose exec app bundle install
docker compose exec app bin/rails redmine:plugins:migrate

Since #9 has been reverted, i reopened.

First, allow to configure a prefix of the commands with REXER_COMMAND_PREFIX environment variable.


Update Incident Log Section with examples

Backlog Task
Improve our incident management process documentation (the incident log section) to include some prose on what makes a good log or log statement.  E.g. "James searched logs" isn't helpful.  "James searched the TI logs and found the reportId of 1234" is more useful.
Completion Criteria

[ ] Incident Log section of the Process page in Notion has been updated

Tasks

[ ] Add examples to the Incident Log section

Other Notes

Incident Process page

@brick-green Is this ticket a duplicate of https://github.com/CDCgov/trusted-intermediary/issues/1328?

@brick-green Is this ticket a duplicate of #1328?

@csweet92 I don't think these are duplicates. This ticket is meant to give more guidance for an incident commander on how they should be logging the tasks that they complete during the incident response. Those logs would just be for our internal purposes. #1328 seems to be more about how we communicate out to the external partners about an incident.

Sorry, wrong ticket number. I meant this closed ticket #1349

Oh yep definitely looks like a duplicate! Good call :) closing


high CPU usage when viewing *.js files and nodejs is connected to localhost

Prerequisites

[yep] Can you reproduce the problem with Debug -> Reload Without Extensions?
[yep] Did you perform a cursory search to see if your bug or enhancement is already reported?
[yep ] Did you read the Troubleshooting guide?

os: windows 10x64 (latest)
brackets vers: 1.11x32
###What's wrong:
When viewing js file, node.js.exe process increases CPU usage, i can't change project folder. When I exit Brackets, all processes are working in shadow (node.js.exe with high CPU usage)
If node.js.exe socket connection is terminated (terminate node.js.exe in task manager), the problem resolves until the next connection is established
:(

i looks like issue happens when my local web server uses "localhost" domain

No, it still persists.
it is somehow connected to file watchers :(
HELP

it happens if js file contains something like this: {{some.strings}}

Came across this on google, because it just happened to me.
I'm trying:
npm installl fsevents (if already installed, try npm rebuild fsevents)

This is also happening to me.  I'm on a Mac OS Version 10.15.4.


Ability to animate container size changes?

I feel like what i'm asking is crazy, but maybe someone else can lead me on the right path. I have a container element centered on the page. The height and width are determined by the children. Initially i have a larger child, but then transition out that react-spring's 2-state transition. Everything animates well enough. The problem is, once that larger child is finally removed from the dom, the container element "snaps" to a smaller size. I was hoping there was a way to have the width and height animate to the smaller size. As far as I can tell, there's no way to do that with pure CSS. Is it possibly that react-spring could somehow magically do that? If not, what's the suggested way?

Hard to do anything without something to toy with, a codesandbox with your example really is the best way to figure out solutions. From how it sounds it's probably some css related thing and i guess it would be easy to solve.


iosevka: 5.0.2 -> 7.0.4, iosevka-bin: 5.0.5 -> 7.0.4

Motivation for this change
There has been a few new glyphs added to Iosevka since this package was last updated, I noticed as I was trying to compile a custom version and it didn't work with the current package.
Things done

[X] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[X] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[X] Fits CONTRIBUTING.md.

/marvin opt-in
/status needs_reviewer

@figgyc please resolve the merge conflict.

Result of nixpkgs-review pr 126664 at 410b187b run on aarch64-linux 1

1 package failed to build:

vscode-extensions.vadimcn.vscode-lldb

3 packages skipped due to time constraints:

iosevka
iosevka-bin
lumo

7 packages built successfully:

bat-extras.prettybat
discourse
nixos-install-tools
parity-ui
teleprompter
vscode-extensions.matklad.rust-analyzer
zerobin

Note that build failures may predate this PR, and could be nondeterministic or hardware dependent.
Please exercise your independent judgement. Does something look off? Please file an issue or reach out on IRC.

sorry for the new merge conflict. Please hit someone up on matrix when you resolved it that we can merge this asap.

@SuperSandro2000 I've resolved the merge conflict, can you (or someone else) take another look? I did ask on matrix before I went to bed last night but seems like nobody did.


[Twilio Adapter] Replace interfaces with classes

Proposed Changes
Replace interfaces with classes to allow versioning.
Detailed changes

Remove ITwilioClient interface.
Convert interface ITwilioAdapterOptions in a class
Rename TwilioApi class as TwilioClientWrapper and made its methods virtual.
Adjust TwilioAdapter class and unit tests to these changes.
Replace explicit types with var

Replaced with PR# 2462


Formik prop "initialValues" - TS error

🐛 Bug report
Hi, I using Formik in my company's main project. and i faced this problem
Current Behavior
Type '{ FIO: string; email: string; phone: string; dob: string; country: string; city: string; }'
is not assignable to type 'FormEvent<Element> &
{ FIO: string; email: string; phone: string; dob: string; country: string; city: string; }'.
  Type '{ FIO: string; email: string; phone: string; dob: string; country: string; city: string; }'
is missing the following properties from
type 'FormEvent<Element>': nativeEvent, currentTarget, target, bubbles, and 11 more.

Expected behavior
https://codesandbox.io/s/formik-boilerplateexample-64ugl?file=/src/App.tsx
I expect no TS errors
Suggested solution(s)
How could I solve this bug? Why this happended?
Additional context
VSCode said that initialValues should be that kind of type
(property) initialValues: React.FormEvent<Element> & {
    FIO: string;
    email: string;
    phone: string;
    dob: string;
    country: string;
    city: string;
}

The expected type comes from property 'initialValues' which is declared here - types.d.ts(143, 5)
Your environment

Software
windows 64-x

Formik
2.1.4

React
16.13.1

TypeScript
3.8.2

Browser
Chrome

npm/Yarn
yarn

Operating System
windows

I really can't move on cause i stuck with this problem(((

@Manimall What is the type signature of your onSubmit function? Formik will infer the generic type for Values in the form from the onSubmit prop if a generic is not passed directly:
Shortened version of the interface for <Formik> prop:
interface FormikConfig<Values> {
  /**
   * Submission handler
   */
  onSubmit: (
    values: Values,
    formikHelpers: FormikHelpers<Values>
  ) => void | Promise<any>;
}

If your onSubmit function's type signature is updated to not include FormEvent<Element>, then the type issue should be resolved.

@HipsterBrown thank you so much!


Missing MaxExpansions method in MatchPhrasePrefixQuery of v5

Which version of Elastic are you using?
[ ] elastic.v2 (for Elasticsearch 1.x)
[ ] elastic.v3 (for Elasticsearch 2.x)
[x] elastic.v5 (for Elasticsearch 5.x)
Please describe the expected behavior
In elastic.v3, the MatchPhrasePrefixQuery had a MaxExpansions method:
https://godoc.org/gopkg.in/olivere/elastic.v3#MatchQuery.MaxExpansions
but in v5 it was refactored in a new struct type MatchPhrasePrefixQuery but the MaxExpansions is missing.
Please describe the actual behavior
No way to cap the max expansions of a prefix phrase query.
Any steps to reproduce the behavior?

@olivere Would you accept a PR for adding the method? Or this is working as intended?

@tiago4orion Ah well... the field is there, but the method is missing. A PR would be helpful, thanks in advance.

Will be available soon in 5.0.48.

Thanks ;)


[Feature Request] Add 'readonly' flag to visdom.server

How can I share my work with other people such that they could only view the plots? It'd be nice to have the ability to block any changes made by a user to the server.

Your best bet is to look into how the server handles incoming requests from the frontend. Everything comes in through the SocketHandler class. You could potentially add a flag that makes modifying calls to on_message no-ops, and then update the main.js file such that the online indicator had a third option (read-only?) which would disable the buttons in the same way that state.connected is used to enable/disable those buttons. You would also need a way to broadcast the fact that it's a read-only state to the frontend, which is handled through the socket in _handleMessage in main.js.

Hello @JackUrb, I would like to take up this issue.
I was looking at the source and the incoming commands on SocketHandler.on_message that need to filtered for readonly flag would be: close, delete_env, save_layouts.
Am i correct in grasping this?

@xssChauhan Yup that's correct! Nothing else would necessarily need to change for a read-only mode

@JackUrb Thank you! I am currently thinking of setting a global variable/environment variable to indicate the read-only state if an argument is passed from the cli. And returning early in the on_message method when the read-only state is set and the cmd is one of the actions that needs to be blocked.

Seems like a perfectly valid approach to me.
As an extension, if you're interested it'd be appreciated if you also send that as a parameter in the open function of the SocketHandler, this way the frontend could render "read-only" rather than just "online" in the top right corner.
Currently register only sends the socket id, but this would be where you could also send the read-only status: https://github.com/facebookresearch/visdom/blob/8779e3862412edc99176f4d17e20a2ba61f6280a/py/visdom/server.py#L233
And then if you're really interested you can then use that in the JS client by making read-only a part of the react state, and changing this text based on that state: https://github.com/facebookresearch/visdom/blob/8779e3862412edc99176f4d17e20a2ba61f6280a/js/main.js#L1071

My aim is to provide a complete solution to the issue.
I'll definitely take care of the rest of the implementation as well.
Thank you for the references.


cargo-tauri: 1.6.3 -> 1.6.5

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/tauri-apps/tauri/releases.
meta.description for cargo-tauri is: Build smaller, faster, and more secure desktop applications with a web frontend
meta.homepage for cargo-tauri is: https://tauri.app/
Updates performed

Rust version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 1.6.5 with grep in /nix/store/cz7raiqq0658kk4nq7vn92kv2f2jnb6r-tauri-1.6.5
found 1.6.5 in filename of file in /nix/store/cz7raiqq0658kk4nq7vn92kv2f2jnb6r-tauri-1.6.5

Rebuild report (if merged into master) (click to expand)

8 total rebuild path(s)

8 package rebuild(s)

First fifty rebuilds by attrpath

cargo-tauri
cinny-desktop
insulator2
kiwitalk
pot
surrealist
treedome

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/cz7raiqq0658kk4nq7vn92kv2f2jnb6r-tauri-1.6.5 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A cargo-tauri https://github.com/r-ryantm/nixpkgs/archive/7594481365a984c8b51ea39dc459f50bac4ac1d6.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/7594481365a984c8b51ea39dc459f50bac4ac1d6#cargo-tauri

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/cz7raiqq0658kk4nq7vn92kv2f2jnb6r-tauri-1.6.5
ls -la /nix/store/cz7raiqq0658kk4nq7vn92kv2f2jnb6r-tauri-1.6.5/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review --extra-nixpkgs-config '{ allowInsecurePredicate = x: true; }' run on x86_64-linux 1

1 package failed to build:

insulator2

6 packages built:

cargo-tauri
cinny-desktop
kiwitalk
pot
surrealist
treedome

Maintainer pings
cc @dit7ya @happysalada for testing.

Result of nixpkgs-review pr 311667 run on x86_64-linux 1

1 package failed to build:

insulator2

6 packages built:

cargo-tauri
cinny-desktop
kiwitalk
pot
surrealist
treedome


preserve_initdb_archive endpoint should also work for broken tenants

The preserve_initdb_archive endpoint added by #6387 should also work for tenants which are marked as Broken, because often it's those tenants that we want to disaster recover.

Related for deletion: #5080
(both are needed for WAL DR to work)


Auto-generate README from docs

Background
In #109, we found a way to use GitHub actions to auto-generate a README file from a specified list of markdown files in the project repo. We now need to productionise this proof of concept.
Work Required

Add the following files from the prototype branch (SLVUU109-combine-docs):

generate-readme.sh
generate-readme.yml
readme_contents.txt

Change any references to README_AUTO.md with README.md
Edit readme_contents.txt to specify the intended list of files to be included

❓ Which files/folders are to be included?

Edit generate-readme.yml to generate any further commentary/intro that may be required

Notes
If it is neccessary to include a significant amount of markdown content to the README that is not intended for the Docusaurus site, this can be written in .md files stored outside of the docs folder, and referenced in readme_contents.txt.

Cannot proceed until we know what content is required for the README. Draft PR raised into Finos repo as handover.


Fix issues

Apply Givens rotations directly to whole H in single_shift! and double_shift!, preallocate V_locked and fix a bug with Arnoldi relation

Fixes #12


Support of WebHDFS

My idea is to add possibility to read from WebHDFS.
It would probably need to be implemented as some wrapper on top of WebHDFS API.
https://hadoop.apache.org/docs/r1.0.4/webhdfs.html
Based on the observations from API:

Streaming seems to be possible
It will involve probably requests library dependency (is this possible?)
It might involve necessity of creating some config file with details about login to WebHDFS

Would this addition be appreciated in smart_open? I can try to work on PR, hopefully in the near future.

Yes, we accept any new functionality that fits the mission of smart_open = Pythonic API read/write access to large (streamed) data files, no matter the protocol.
Requests is a stable library, depending on it is no problem.
Authentication / login configs: as long as it doesn't affect the other (existing) code paths and is conceptually sane (maintainable).

Implemented in #29 #31


MINOR Removed unused CommittedOffsetsFile class.

We will introduce the same when it is required for enhancing TBRLMM to consume from a specific offset when snapshots are implemented.
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

Should we also avoid creating the remote_log_snapshot file under each partition directory?

Task :core:compileTestScala FAILED

Please fix the test compilation failure


python312Packages.folium: 0.18.0 -> 0.19.2

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python312Packages.folium is: Make beautiful maps with Leaflet.js & Python
meta.homepage for python312Packages.folium is: https://github.com/python-visualization/folium
meta.changelog for python312Packages.folium is: https://github.com/python-visualization/folium/blob/v0.19.2/CHANGES.txt
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 0.19.2 with grep in /nix/store/5qry726qcb98h8ixh3hvbd8qbngb2562-python3.12-folium-0.19.2
found 0.19.2 in filename of file in /nix/store/5qry726qcb98h8ixh3hvbd8qbngb2562-python3.12-folium-0.19.2

Rebuild report (if merged into master) (click to expand)

33 total rebuild path(s)

33 package rebuild(s)

First fifty rebuilds by attrpath

python311Packages.bsuite
python311Packages.folium
python311Packages.geoarrow-pandas
python311Packages.geoarrow-pyarrow
python311Packages.geodatasets
python311Packages.geopandas
python311Packages.geoparquet
python311Packages.inequality
python311Packages.libpysal
python311Packages.mapclassify
python311Packages.momepy
python311Packages.msticpy
python311Packages.osmnx
python311Packages.plotnine
python311Packages.shimmy
python311Packages.wktutils
python312Packages.bsuite
python312Packages.folium
python312Packages.geoarrow-pandas
python312Packages.geoarrow-pyarrow
python312Packages.geodatasets
python312Packages.geopandas
python312Packages.geoparquet
python312Packages.inequality
python312Packages.libpysal
python312Packages.mapclassify
python312Packages.momepy
python312Packages.msticpy
python312Packages.osmnx
python312Packages.plotnine
python312Packages.shimmy
python312Packages.wktutils

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/5qry726qcb98h8ixh3hvbd8qbngb2562-python3.12-folium-0.19.2 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A python312Packages.folium https://github.com/r-ryantm/nixpkgs/archive/e357c86dad473033d86bfaf8480996713b67f73f.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/e357c86dad473033d86bfaf8480996713b67f73f#python312Packages.folium

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/5qry726qcb98h8ixh3hvbd8qbngb2562-python3.12-folium-0.19.2
ls -la /nix/store/5qry726qcb98h8ixh3hvbd8qbngb2562-python3.12-folium-0.19.2/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review

x86_64-linux

:fast_forward: 2 packages marked as broken and skipped:

python312Packages.shimmy
python312Packages.shimmy.dist

:white_check_mark: 62 packages built:

python311Packages.bsuite
python311Packages.bsuite.dist
python311Packages.folium
python311Packages.folium.dist
python311Packages.geoarrow-pandas
python311Packages.geoarrow-pandas.dist
python311Packages.geoarrow-pyarrow
python311Packages.geoarrow-pyarrow.dist
python311Packages.geodatasets
python311Packages.geodatasets.dist
python311Packages.geopandas
python311Packages.geopandas.dist
python311Packages.geoparquet
python311Packages.geoparquet.dist
python311Packages.inequality
python311Packages.inequality.dist
python311Packages.libpysal
python311Packages.libpysal.dist
python311Packages.mapclassify
python311Packages.mapclassify.dist
python311Packages.momepy
python311Packages.momepy.dist
python311Packages.msticpy
python311Packages.msticpy.dist
python311Packages.osmnx
python311Packages.osmnx.dist
python311Packages.plotnine
python311Packages.plotnine.dist
python311Packages.shimmy
python311Packages.shimmy.dist
python311Packages.wktutils
python311Packages.wktutils.dist
python312Packages.bsuite
python312Packages.bsuite.dist
python312Packages.folium
python312Packages.folium.dist
python312Packages.geoarrow-pandas
python312Packages.geoarrow-pandas.dist
python312Packages.geoarrow-pyarrow
python312Packages.geoarrow-pyarrow.dist
python312Packages.geodatasets
python312Packages.geodatasets.dist
python312Packages.geopandas
python312Packages.geopandas.dist
python312Packages.geoparquet
python312Packages.geoparquet.dist
python312Packages.inequality
python312Packages.inequality.dist
python312Packages.libpysal
python312Packages.libpysal.dist
python312Packages.mapclassify
python312Packages.mapclassify.dist
python312Packages.momepy
python312Packages.momepy.dist
python312Packages.msticpy
python312Packages.msticpy.dist
python312Packages.osmnx
python312Packages.osmnx.dist
python312Packages.plotnine
python312Packages.plotnine.dist
python312Packages.wktutils
python312Packages.wktutils.dist

Maintainer pings
cc @autra @imincik @l0b0 @nh2 @nialov @sikmir @willcohen for testing.

[!TIP]
As a maintainer, if your package is located under pkgs/by-name/*, you can comment @NixOS/nixpkgs-merge-bot merge to automatically merge this update using the nixpkgs-merge-bot.

Add a :+1: reaction to pull requests you find important.

nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 365970

x86_64-darwin

:white_check_mark: 12 packages built:

python311Packages.folium
python311Packages.folium.dist
python311Packages.msticpy
python311Packages.msticpy.dist
python311Packages.osmnx
python311Packages.osmnx.dist
python312Packages.folium
python312Packages.folium.dist
python312Packages.msticpy
python312Packages.msticpy.dist
python312Packages.osmnx
python312Packages.osmnx.dist

Code looks good, untested.


feat(auto-balance): disk in pressure

Which issue(s) this PR fixes:

Issue longhorn/longhorn#4105
What this PR does / why we need it:
Introduce file local sync to copy the file when there is another running replica on the same node so the data transfer doesn't need to go through TCP.
Special notes for your reviewer:
None
Additional documentation or context
None

Need to wait https://github.com/longhorn/longhorn-engine/pull/1015. cc @FrankYang0529

@c3y1huang  Is it ready?

@derekbit , this is ready for review.


WIP grants page

Description:
Currently we are not showing full list of wip grants anywhere to the admins.
EDIT: I think we are already showing full list of WIP grant in home page?
https://github.com/BuidlGuidl/grants.buidlguidl.com/blob/7230af2f0e3fa886940b2901f7127149f2f92167/packages/nextjs/app/_components/ActiveGrants.tsx#L21C30-L21C48
This is what its called on home page

Completed at #134


ignore_unannotated isn't recognized when using build.yaml from docs.

When using the default build.yaml from the docs i get an error after running flutter pub run build_runner build:
Bad state: Could not parse the options provided for `json_serializable`.
Unrecognized keys: [ignore_unannotated]; supported keys: [any_map, checked, create_factory, create_to_json, disallow_unrecognized_keys, encode_empty_collection, explicit_to_json, field_rename, generate_to_json_function, include_if_null, nullable, use_wrappers]

Seems as though ignore_unannotated is no longer valid and shouldn't be included in the docs.

It is valid, but it requires v3 of json_annotation


New Crowdin translations

Enjoy!

Hey @teolemon,
Something went wrong with the build.
TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.
View build log
TravisBuddy Request Identifier: 320a1880-d8db-11e8-b9f2-b1fbc111596d


remove licensemanager remnants

Makes make licensemanager=no unnecesssary.
Issue #11

Thanks, looks good! 👍🏻
However, to build vmatch from scratch there might be more changes needed, at least replacing skproto with gt dev skproto or something like that. See https://salsa.debian.org/med-team/vmatch/-/blob/master/debian/patches/skproto.patch


[FR] Displaying of hex colors

Gitea version (or commit ref): v1.3.0

Description
GitHub added displaying of hex colors in rendered markdown some time ago, I just noticted it today. have to admit, to like it very much and find it useful, so suggesting it for gitea too. See screenshot below how it is visualized, or the referenced issue. I usually paste them in some color viewer, or guess colors, but having them directly shown is a really nice idea.
https://github.com/gsantner/markor/issues/144

activity

Yes, indeed, this would be nice to have.
@lunny what does the label you added mean?  It is since 2017 on milestone 1.x.x and we have 1.14.6 right now ;-)

That label will prevent stale bot mark it as stale. That means I think the issue should not be closed directly.

this is how it looks nowadays on github:


Give make environment variables for install location

See: #2

cfengine binary locations might be useful if make decides to run cf-promises.
But could simply rely on it being in PATH.
A variable containing the install location would be most useful.
The primitive makefile that I have been using small variations on:
https://github.com/nickanderson/cfengine-lynis/blob/master/makefile
MASTERFILES environment variable ... path to root of policy to install to (where I am not editing masterfiles directly on the server, this is a path to my masterfiles repo clone.
My makefile installs into services/NAME OF package repo. So for github.com/nickanderson/cfengine-lynis it installs into cfengine-lynis. I guess an environment variable for that would be useful.


Change forgot password link color

Too close to the background in color and provides low contrast. Focus state is also bad for accessibility.

Moving to https://github.com/heroku/signup ...


init: ported To_Unicode_From_String primitive function

Since case changing functions are required for all level-2 libraries, we have to start from the beginning. Let's port the To_Unicode_From_String primitive function into HestiaKERNEL library.
This patch ports To_Unicode_From_String primitive function into HestiaKERNEL library in init/ directory.

Skip review since it's a port and it's not affecting the actual production.


support raw strings

For example:
$ echo 'r"(raw "quotes" string)"' > raw-string.R; tree-sitter parse raw-string.R
(program [0, 0] - [1, 0]
  (identifier [0, 0] - [0, 1])
  (string [0, 1] - [0, 8])
  (identifier [0, 8] - [0, 14])
  (string [0, 14] - [0, 24]))

As an aside, R is very permissive for raw strings; e.g. these are all valid raw strings:
    ## More raw strings:
     r"{(\1\2)}"
     r"(use both "double" and 'single' quotes)"
     R"---[\1--]-]---"

It's unlikely we'll be able to describe R's raw strings directly in grammar.js; however, we should be able to define a custom scanner here:
https://tree-sitter.github.io/tree-sitter/creating-parsers#external-scanners
See, for example:
https://github.com/tree-sitter/tree-sitter-cpp/blob/master/src/scanner.cc
https://github.com/tree-sitter/tree-sitter-cpp/blob/master/grammar.js#L26-L2

Assuming I am reading the code at https://github.com/wch/r-source/blob/52b730f217c12ba3d95dee0cd1f330d1977b5ea3/src/main/gram.y#L3102 correctly https://regex101.com/r/DPmEw0/1 gets us pretty close. The main thing I think you would have to do is add an additional check that the opening bracket matches the closing one.

It looks like tree-sitter doesn't support regular expressions containing backreferences:
$ tree-sitter generate
Error processing rule string_token1

Caused by:
    regex parse error:
        [rR](['"])(-*)\[.*\]\2\1
                            ^^
    error: backreferences are not supported


dns-search functionality appears not to work

This is my fault, and my problem to fix - am assigning to myself.

@ianmiell @jperville In addition the that point, I have just realised we were not setting the dnsIP correctly on nodes... :/
Should be the IP of the current node not the kubernetes svc (Since version 1.2+,3.2+)
Will send a PR shortly

Did you change this? If not, I can just remove my code as a first step (as it just doesn't work...)

Yes it has been fixed by commit 5793e7bf516943ec6ab6d651952b02deeb60740e


Remove dependency on github.com/grpc-ecosystem/grpc-gateway

As far as I can tell, we are not using it today. The motivation for it was to have a canonical proto-based JSON API that would be used by the UI as well as a public API. But there are issues with proto-based JSON (e.g. IDs are represented in base64 instead of hex)
and updating the UI is a large task that we don't have the cycles for. I suggest we remove this dependency altogether until the time we actually need it.
$ grx grpc-gateway .
./idl/proto/api_v2/sampling.proto:34:// Enable registration with golang/protobuf for the grpc-gateway.
./idl/proto/api_v2/query.proto:37:// Enable registration with golang/protobuf for the grpc-gateway.
./idl/proto/api_v2/collector.proto:35:// Enable registration with golang/protobuf for the grpc-gateway.
./idl/proto/api_v2/model.proto:38:// Enable registration with golang/protobuf for the grpc-gateway.
./go.mod:35:	github.com/grpc-ecosystem/grpc-gateway v1.14.5
./Makefile:476:	# Generate gogo, gRPC-Gateway, swagger, go-validators, gRPC-storage-plugin output.
./Makefile:484:	# --grpc-gateway_out generates gRPC-Gateway output.
./Makefile:485:	# --swagger_out generates an OpenAPI 2.0 specification for our gRPC-Gateway endpoints.
./Makefile:506:		### grpc-gateway generates 'query.pb.gw.go' that does not respect (gogoproto.customname) = "TraceID"
./Makefile:507:		### --grpc-gateway_out=$(PROTO_GOGO_MAPPINGS):$(PWD)/proto-gen/ \
./proto-gen/api_v2/sampling.pb.go:14:	_ "github.com/grpc-ecosystem/grpc-gateway/protoc-gen-swagger/options"
./proto-gen/api_v2/query.pb.go:15:	_ "github.com/grpc-ecosystem/grpc-gateway/protoc-gen-swagger/options"
./proto-gen/api_v2/collector.pb.go:13:	_ "github.com/grpc-ecosystem/grpc-gateway/protoc-gen-swagger/options"
./plugin/storage/grpc/proto/storage.proto:34:// Enable registration with golang/protobuf for the grpc-gateway.
./tools.go:23:	_ "github.com/grpc-ecosystem/grpc-gateway/protoc-gen-swagger"
./go.sum:313:github.com/grpc-ecosystem/grpc-gateway v1.9.0/go.mod h1:vNeuVxBJEsws4ogUvrchl83t/GYV9WGTSLVdBhOQFDY=
./go.sum:314:github.com/grpc-ecosystem/grpc-gateway v1.9.5/go.mod h1:vNeuVxBJEsws4ogUvrchl83t/GYV9WGTSLVdBhOQFDY=
./go.sum:315:github.com/grpc-ecosystem/grpc-gateway v1.14.5 h1:aiLxiiVzAXb7wb3lAmubA69IokWOoUNe+E7TdGKh8yw=
./go.sum:316:github.com/grpc-ecosystem/grpc-gateway v1.14.5/go.mod h1:UJ0EZAp832vCd54Wev9N1BMKEyvcZ5+IM0AwDrnlkEc=

Hi, I would like to take this one

/assign

@jeffy-mathew it's yours

@yurishkuro I need some help in generating proto files, how to remove the dependency from generated proto files?

oh, you may need to make a change to jaeger-idl repo and remove the respective annotations from these files:
./idl/proto/api_v2/sampling.proto
./idl/proto/api_v2/query.proto
./idl/proto/api_v2/collector.proto
./idl/proto/api_v2/model.proto

about the changes in submodule jaeger-idl, do I need to raise a separate PR in that repo?

Yes, a PR there and after it's merged update the submodule in this repo.


Check for active object before switching to object mode

When the exporter iterates through each mesh to export, it needs to enter edit mode to work with the mesh data.
Before this must happen, we must enter object mode so we can pick the mesh we want to use.
However, in some cases, there will be no mesh selected - causing mode_set() to fail, as there is no active object, causing a crash.
This fixes this crash by just not bothering to switch into object mode if nothing is selected, as it's a redundant operation at that point.
Additionally, blender safeguards against misbehavior here - if you try to deselect bpy.context.view_layer.objects.active by setting it to none while in any mode other than object mode, it kicks you back into object mode, allowing you to select a new mesh.
Fixes #70

Thank you very much !


Error 'Subtitles are disabled for this video' on youtube_transcript_api cli

To Reproduce
Execute cli
$ youtube_transcript_api https://www.youtube.com/watch?v=--t7xdzBiQ4
Which Python version are you using?
python 3.10.6, 3.9.0 and 3.8.8
Which version of youtube-transcript-api are you using?
0.5.0
What code / cli command are you executing?
$ youtube_transcript_api https://www.youtube.com/watch?v=--t7xdzBiQ4
Expected behavior
Show transcript
Actual behaviour
Could not retrieve a transcript for the video https://www.youtube.com/watch?v=https://www.youtube.com/watch?v=--t7xdzBiQ4! This is most likely caused by:

Subtitles are disabled for this video

If you are sure that the described cause is not responsible for this error and that a transcript should be retrievable, please create an issue at https://github.com/jdepoix/youtube-transcript-api/issues. Please add which version of youtube_transcript_api you are using and provide the information needed to replicate the error. Also make sure that there are no open issues which already describe your problem!

I tried on different machines and different IPs, but same error using the cli.
This video was working before and I used it as a reference because I already downloaded the transcript of it.
When using a piece of code, it shows a different message but I believe it is related. I tried on different machines and also different IPs:
transcript = YouTubeTranscriptApi.get_transcript('--t7xdzBiQ4', languages=['pt'])
print (transcript)

Error
Traceback (most recent call last):
  File "/usr/local/lib/python3.10/dist-packages/youtube_transcript_api/_transcripts.py", line 33, in _raise_http_errors
    response.raise_for_status()
  File "/usr/lib/python3/dist-packages/requests/models.py", line 943, in raise_for_status
    raise HTTPError(http_error_msg, response=self)
requests.exceptions.HTTPError: 429 Client Error: Too Many Requests for url: https://www.google.com/sorry/index?continue=https://www.youtube.com/watch%3Fv%3D--t7xdzBiQ4&q=EhAqAX4BAAAAAPA8k__-DygrGOmNk5wGIjAa21GTvhu3UKzoT46i6CEC7Fz0sJ1Gl6wYXLfYlCAOSKUlP1_IMKDreZewrRBSpX4yAXI

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/root/Projects/youtube-transcripts/test.py", line 20, in <module>
    transcript = YouTubeTranscriptApi.get_transcript('--t7xdzBiQ4', languages=['pt'])
  File "/usr/local/lib/python3.10/dist-packages/youtube_transcript_api/_api.py", line 132, in get_transcript
    return cls.list_transcripts(video_id, proxies, cookies).find_transcript(languages).fetch()
  File "/usr/local/lib/python3.10/dist-packages/youtube_transcript_api/_api.py", line 71, in list_transcripts
    return TranscriptListFetcher(http_client).fetch(video_id)
  File "/usr/local/lib/python3.10/dist-packages/youtube_transcript_api/_transcripts.py", line 47, in fetch
    self._extract_captions_json(self._fetch_video_html(video_id), video_id)
  File "/usr/local/lib/python3.10/dist-packages/youtube_transcript_api/_transcripts.py", line 79, in _fetch_video_html
    html = self._fetch_html(video_id)
  File "/usr/local/lib/python3.10/dist-packages/youtube_transcript_api/_transcripts.py", line 89, in _fetch_html
    return unescape(_raise_http_errors(response, video_id).text)
  File "/usr/local/lib/python3.10/dist-packages/youtube_transcript_api/_transcripts.py", line 36, in _raise_http_errors
    raise YouTubeRequestFailed(error, video_id)
youtube_transcript_api._errors.YouTubeRequestFailed:
Could not retrieve a transcript for the video https://www.youtube.com/watch?v=429 Client Error: Too Many Requests for url: https://www.google.com/sorry/index?continue=https://www.youtube.com/watch%3Fv%3D--t7xdzBiQ4&q=EhAqAX4BAAAAAPA8k__-DygrGOmNk5wGIjAa21GTvhu3UKzoT46i6CEC7Fz0sJ1Gl6wYXLfYlCAOSKUlP1_IMKDreZewrRBSpX4yAXI! This is most likely caused by:

Request to YouTube failed: --t7xdzBiQ4

If you are sure that the described cause is not responsible for this error and that a transcript should be retrievable, please create an issue at https://github.com/jdepoix/youtube-transcript-api/issues. Please add which version of youtube_transcript_api you are using and provide the information needed to replicate the error. Also make sure that there are no open issues which already describe your problem!

Hi @eddieoz,
your CLI command is failing because you have to provide the ID of the video, not the URL. Also, your video's ID starts with - so you'll have to escape that. Additionally, the video doesn't have an English transcript (which is the default if no language is provided), therefore, you'll have to provide the language you want to get the transcript for. Try this:
youtube_transcript_api "\--t7xdzBiQ4" --languages pt
The script you posted is failing because you have exceeded YouTube's rate limit, as the error message suggests. There unfortunately is not much you can do here, except for waiting until they remove the IP ban on you.

Thanks for your reply.
I will review it and run the bot under tor or another VPN to update my channel's transcripts db. Unfortunately seems Youtube listed my 3 IPs.
Best regards,


logstash 5.0.0's log4j2 doesn't allow logging an array object, causing crash

see https://github.com/logstash-plugins/logstash-output-gelf/blob/master/lib/logstash/outputs/gelf.rb#L190
While this works in logstash 2.x, in logstash 5.x it causes:
[2016-10-28T14:52:17,756][INFO ][logstash.pipeline        ] Pipeline main started
[2016-10-28T14:52:17,817][INFO ][logstash.agent           ] Successfully started Logstash API endpoint {:port=>9600}
[2016-10-28T14:52:18,594][FATAL][logstash.runner          ] An unexpected error occurred! {:error=>#<NameError: no method 'debug' for arguments (org.jruby.RubyArray,org.jruby.RubyHash) on Java::OrgApacheLoggingLog4jCore::Logger
  available overloads:
    (org.apache.logging.log4j.Marker,java.lang.String,java.lang.Object[])
    (org.apache.logging.log4j.Marker,java.lang.String,org.apache.logging.log4j.util.Supplier[])
    (java.lang.String,org.apache.logging.log4j.util.Supplier[])
    (java.lang.String,java.lang.Object[])>, :backtrace=>["C:/SDKs/logstash-5.0.0/logstash-core/lib/logstash/logging/logger.rb:41:in `debug'", "C:/SDKs/logstash-5.0.0/vendor/bundle/jruby/1.9/gems/logstash-output-gelf-3.1.1/lib/logstash/outputs/gelf.rb
:190:in `receive'", "C:/SDKs/logstash-5.0.0/logstash-core/lib/logstash/outputs/base.rb:92:in `multi_receive'", "org/jruby/RubyArray.java:1613:in `each'", "C:/SDKs/logstash-5.0.0/logstash-core/lib/logstash/outputs/base.rb:92:in `multi_receive'", "C:/S
DKs/logstash-5.0.0/logstash-core/lib/logstash/output_delegator_strategies/legacy.rb:19:in `multi_receive'", "C:/SDKs/logstash-5.0.0/logstash-core/lib/logstash/output_delegator.rb:42:in `multi_receive'", "C:/SDKs/logstash-5.0.0/logstash-core/lib/logst
ash/pipeline.rb:297:in `output_batch'", "org/jruby/RubyHash.java:1342:in `each'", "C:/SDKs/logstash-5.0.0/logstash-core/lib/logstash/pipeline.rb:296:in `output_batch'", "C:/SDKs/logstash-5.0.0/logstash-core/lib/logstash/pipeline.rb:252:in `worker_loo
p'", "C:/SDKs/logstash-5.0.0/logstash-core/lib/logstash/pipeline.rb:225:in `start_workers'"]}

see more in https://discuss.elastic.co/t/logstash-output-gelf-plugin-not-working-with-logstash-5-0-0/64575

related to https://github.com/logstash-plugins/logstash-output-stomp/pull/15

Would be great if the fix to the plugin could be published. Right now it breaks all gelf outputs and kills Logstash.

Verified the specs fail:
Failures:

  1) LogStash::Outputs::Gelf#send sends the generated event to gelf
     Failure/Error: @logger.debug(["Sending GELF event", m])

     NameError:
       no method 'debug' for arguments (org.jruby.RubyArray,org.jruby.RubyHash) on Java::OrgApacheLoggingLog4jCore::Logger
         available overloads:
           (java.lang.String,java.lang.Object[])
           (org.apache.logging.log4j.Marker,java.lang.String,org.apache.logging.log4j.util.Supplier[])
           (org.apache.logging.log4j.Marker,java.lang.String,java.lang.Object[])
           (java.lang.String,org.apache.logging.log4j.util.Supplier[])
     # /home/jls/.rvm/gems/jruby-1.7.24/gems/logstash-core-5.0.0-java/lib/logstash/logging/logger.rb:41:in `debug'
     # ./lib/logstash/outputs/gelf.rb:190:in `receive'
     # ./spec/outputs/gelf_spec.rb:32:in `(root)'
     # /home/jls/.rvm/gems/jruby-1.7.24/gems/rspec-wait-0.0.9/lib/rspec/wait.rb:46:in `(root)'

Due to this problem.

https://github.com/logstash-plugins/logstash-output-gelf/pull/22

@magicdude4eva as a workaround, Logstash 2.x can be used instead of 5.0.0. #22 provides a patch that should fix this. Testing welcome.

#22 is a dup of #21; so I closed #22.

Thanks - I patched gelf.rb in the meantime. We were running 2.x and wanted to upgrade to 5.0.0 - but ran into quite a few issues (gelf.rb was easy to fix, other issues still remain open)

@magicdude4eva can you open issues with the other problems you're observing?

@jsvd I have open some already (most of them are already in the pipeline) - unfortunately all the issues I came across are showstoppers (such as the LS_NICE issue or the gelf issue).
I am surprised that the Logstash breaking changes documentation does not make note if it as many of the issues I reported have been acknowledged as existing but yet no ETA. Makes it very difficult for people wanting to migrate from 2.x.

@magicdude4eva I'm sorry that you're having such a bad experience. I see some of your other issues are being addressed by others, ping me or others if something else is being ignored.
closing this since pr #21 has been merged and v3.1.2 has been published.

Thanks @jsvd. The only blocker for us is https://github.com/elastic/logstash/pull/6199 which seems to have been fixed but I read somewhere that those fixes are marked for 5.0.1 which would be a pity as it makes logstash unusable in a high throughput environment (without doing a renice myself)

@magicdude4eva we're expecting to release 5.0.1 very soon

"Unusable in a high throughout environment"
I am not understanding your claim. Do you have data? Are you lowering or
raising the 'nice' value? Nice only affects scheduling priority, it doesn't
make Logstash faster.
On Monday, November 14, 2016, Gerd Naschenweng<EMAIL_ADDRESS>wrote:

Thanks @jsvd https://github.com/jsvd. The only blocker for us is
elastic/logstash#6199 https://github.com/elastic/logstash/pull/6199
which seems to have been fixed but I read somewhere that those fixes are
marked for 5.0.1 which would be a pity as it makes logstash unusable in a
high throughput environment (without doing a renice myself)
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/logstash-plugins/logstash-output-gelf/issues/20#issuecomment-260334373,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAIC6lf_WxstVnO0A1fE1gjU4FkJZT4cks5q-GJAgaJpZM4KnIpm
.

The LS_NICE only works with the fix in 5.0.1 as the installer has changed and did not setup the systemctl commands correctly. In our production environment (we process 400m messages per month across 8 servers) Logstash without the LS_NICE fix spins loadaverage to 30 and pretty much kills everything else.
I am not sure how this could have been missed as part of the 5.0 release testing. It's a pity as the 5.0 release would have been otherwise almost be good.
It would have also helped if the breaking changes document had mentioned those open bugs. The 5.0 release did not make it past our staging environment and the verdict is still out on what other issues arise once we push 5.0.1 into production.


vimPlugins.wezterm-nvim: init at 2024-09-26

Created for https://github.com/nix-community/nixvim/pull/2597 . Tested on my env via https://github.com/samos667/nivis/commit/15ed3107457fd08e71d2ac72d4d986902c026b89#diff-cbf6f300dc2c874d85281d69b76107a1ea0ff415d2548078773fce518e9c0fba
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 360822

x86_64-linux

:white_check_mark: 2 packages built:

vimPlugins.wezterm-nvim
vimPluginsUpdater

aarch64-linux

:white_check_mark: 2 packages built:

vimPlugins.wezterm-nvim
vimPluginsUpdater

x86_64-darwin

:white_check_mark: 2 packages built:

vimPlugins.wezterm-nvim
vimPluginsUpdater

aarch64-darwin

:white_check_mark: 2 packages built:

vimPlugins.wezterm-nvim
vimPluginsUpdater

This dependents on wezterm here. We might start specifying runtimeDeps? (https://github.com/NixOS/nixpkgs/pull/358587)

Going to merge, as is, sounds like https://github.com/NixOS/nixpkgs/pull/360800#issuecomment-2510243615 his preference would be to not merge those changes, yet until https://github.com/NixOS/nixpkgs/pull/358587 is available.


Missing '=' in README.md

Just what it says on the tin 😄
Awesome input by the way 👍

Whoops. I should've compiled that.
Thank you ;)


⚠ Minecraft has degraded performance

In d4d80e5, Minecraft (https://www.minecraft.net) experienced degraded performance:

HTTP code: 200
Response time: 1571 ms

Resolved: Minecraft performance has improved in f721b73.


Issue template not very suitable to the project

Is your feature request related to a problem? Please describe.
The current template is not suitable for this project.
Describe the solution you'd like
Include only commonly-used info.

Fixed 909b48f3f493389f1f6560a8123b4046758f76bf


Create data on submit

When the user submits the firm
Then the data is persisted into the data store

Use service as data store


Cask request: PokerstarsEU

Cask details
PokerstarsEU
(Please fill out as much as possible)
Name -
PokerStarsEU
Homepage -
https://www.pokerstars.eu/
License -
:freemium
Download URL -
https://www.pokerstars.eu/PokerStarsEU.app.zip
Description -

This is available in the versions repo.

ups missed that sorry ;)


Create DB backups in production

Is your feature request related to a problem? Please describe.
no
Describe the solution you'd like
We have the application running in a production cluster. We should have an automation DB backups. We can run a cronjob that do the backup and save it in a S3 bucket or something similar. And of course we have to try to load the backup as well.
Because you know: "if you have a backup that you never tried, you don't have a backup"

Some ideas with diff approaches:

https://github.com/wal-e/wal-e
https://github.com/tsileo/bakthat
https://github.com/django-dbbackup/django-dbbackup


Return error instead of logging it

In order to make code more homogenous it would make sense to return error in methods like SyncCluster and Delete instead of just logging it

👍

👍


Generate the MSBuild files instead of the template.json files

Workaround https://github.com/dotnet/templating/issues/1302

@natemcmaster,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by .NET Foundation. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot

This is only for the 2.0.3 patch, and won't be needed in dev, is that right @natemcmaster?

I believe @mlorbetske has added a fix to the 2.1 templating engine for https://github.com/dotnet/templating/issues/1302. Unless that get's back-ported to the template engine in 2.0, we have to be cautious about this bug for any templates package that might be installed into a 2.0 CLI. So, maybe?
@seancpeters @mlorbetske  is there a way for a template to require a minimum version of the SDK?

I really don't want this change in dev so I definitely hope the 2.0.x CLI can be fixed. @seancpeters @mlorbetske

:+1: We should re-open https://github.com/dotnet/templating/issues/1302#issuecomment-339808277 (I don't have permissions on that repo)

I've replied to the issue on dotnet/templating. The short of it is unless we also update the engine in VS and VS for Mac and get partner sign off from Windows Template Studio and Xamarin, porting the engine fix to the 2.0.x CLI doesn't help with this issue.

Additionally, older versions of VS that look in the CLI location for templates would have the behavior we're looking to avoid. The engine fix must first be included in what we consider to be the oldest supported versions for consuming those templates before the change to use the new process can be used.

Ok, good to have the context. It sounds like it will be a while before we can use the constant generator then. @SteveSandersonMS I'll ping you again before any of this makes it back to dev.


Remove the breaking change of disallowing zero sized tensors.

Some files out there might exist with this.
While being questionnable, it's not worth doing a breaking change
since there doesn't seem to be either a security implication
nor a performance hit.
https://github.com/huggingface/safetensors/pull/205

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.


Print

What's Changing and Why
Expose final y value in print callback so users can easily stagger text
closes #506
What else might be affected
nothing
Tasks

[x] Add tests
[x] Update Documentation
[x] Update jimp.d.ts
[x] Add SemVer Label

If we expose the y value, we might as well expose the x value to have the full coordinate of the last letter, no ?

If you think the same, I would prefer to expose an object with both values :
coordinate = {x: x, y: y}

@edi9999 comments addressed. Added the x value as well


fix logging of sent ACK frames

Fixes #1910.

Codecov Report

Merging #1911 into master will decrease coverage by 0.03%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #1911      +/-   ##
==========================================
- Coverage   86.43%   86.41%   -0.03%
==========================================
  Files          98       98
  Lines        6701     6703       +2
==========================================
  Hits         5792     5792
- Misses        651      653       +2
  Partials      258      258

Impacted Files
Coverage Δ

session.go
75.88% <0%> (-0.21%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8afed81...555737b. Read the comment docs.


Set quickfix/location list title always

It seems to be done only with -open (https://github.com/mhinz/vim-grepper/blob/57f7669bc3a4b3d8a647d7645f0fb1fb064b7418/autoload/grepper.vim#L450-L452).
The following pattern could be used (because the title arg is new):
try
  call setqflist(getqflist(), 'r', qftitle)
catch /E118/
endtry

Additionally, it would be nice to also apply the mappings / settings once an initially closed qf/loclist window gets opened.