event parameter request - page 6510 "Item Tracking Lines" - AssignSerialNoBatch() - OnAssignSerialNoBatchOnAfterInsert() - CreateLotNo

Please can you pass the CreateLotNo parameter to event subscribers? Not var, just by copy/value.
local procedure AssignSerialNoBatch(QtyToCreate: Integer; CreateLotNo: Boolean; CreateSNInfo: Boolean)
[...]
    for i := 1 to QtyToCreate do begin
        [....]
        Rec.Insert();

        OnAssignSerialNoBatchOnAfterInsert(Rec, Create LotNo);
[....]

Please see also https://github.com/microsoft/ALAppExtensions/issues/15528 to include the sending page from the same publisher.
Thanks!

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.


Issue #744 Tuya Curtain Motor Updates

Clean up of code in init.py and also added device signature for _TZE200_rddyvrci

Pull Request Test Coverage Report for Build 756603692

28 of 63 (44.44%)  changed or added relevant lines in 1 file are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-0.2%) to 82.992%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

zhaquirks/tuya/init.py
28
63
44.44%

Files with Coverage Reduction
New Missed Lines
%

zhaquirks/tuya/init.py
1
73.63%

Totals

Change from base Build 752924628:
-0.2%

Covered Lines:
3728

Relevant Lines:
4492

💛  - Coveralls

Codecov Report

Merging #856 (5619f91) into dev (1d1d32d) will decrease coverage by 0.18%.
The diff coverage is 44.44%.

@@            Coverage Diff             @@
##              dev     #856      +/-   ##
==========================================
- Coverage   83.17%   82.99%   -0.19%
==========================================
  Files         182      182
  Lines        4457     4492      +35
==========================================
+ Hits         3707     3728      +21
- Misses        750      764      +14

Impacted Files
Coverage Δ

zhaquirks/tuya/ts0601.py
100.00% <ø> (ø)

zhaquirks/tuya/__init__.py
73.87% <44.44%> (-1.77%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d1d32d...5619f91. Read the comment docs.

I'll make a PR for fixing the documentation but all of the formatting issues that you're running into are handled automatically by the Git pre-commit hook:
$ pip install pre-commit
$ pre-commit install  # installs itself as a git pre-commit hook
$ # Make your changes
$ git commit -a  # will automatically format your code

I'll make a PR for fixing the documentation but all of the formatting issues that you're running into are handled automatically by the Git pre-commit hook:
$ pip install pre-commit
$ pre-commit install  # installs itself as a git pre-commit hook
$ pre-commit run -a  # auto-format your existing code, only needs to be run once
$ # Make your changes
$ git commit -a  # will automatically format your code

Hi I will do it now.. thank you

This looks good to me. Can be merged in my opinion. this is a welcome improvement on the original code.


[RFC]: add C implementation for @stdlib/math/base/special/fast/uint32-sqrt

Description
This RFC proposes add C implementation for @stdlib/math/base/special/fast/uint32-sqrt
  uint32_t stdlib_base_fast_uint32_sqrt( uint32_t  x );

Related Issues
Related issues #1917 .
Questions
No.
Other
No.
Checklist

[X] I have read and understood the Code of Conduct.
[X] Searched for existing issues and pull requests.
[X] The issue name begins with RFC:.

Hellow,working on it.

Hey @Rejoan-Sardar I will recommend you to first let https://github.com/stdlib-js/stdlib/pulls/Rejoan-Sardar merged. Let this be open and others may work on it. Thank you :)

can you please populate issue description with proper C API and documentation?

Hey @Rejoan-Sardar I will recommend you to first let https://github.com/stdlib-js/stdlib/pulls/Rejoan-Sardar merged. Let this be open and others may work on it. Thank you :)

Hey @Pranavchiku I have addressed all the issues and some issues needs review.

The proposed signature is incorrect.

Hey @Rejoan-Sardar, are you still working on this one ?


fix: improve file tree navigator

Types

[x] 🐛 Bug Fixes

Background or solution
improve keybinding behavior
Changelog
improve file tree navigator

#814 中提到的内容还没有实现：

其他的 behavior works good，跟预期一样~

没注意看，#814 的需求单独开 PR 实现好了

/publish

给删除添加了队列操作逻辑，整体删除更加顺滑

Codecov Report

Merging #818 (3365940) into main (c512d51) will increase coverage by 0.00%.
 Consider uploading reports for the commit d32bcb9 to get more accurate results

@@           Coverage Diff           @@
##             main     #818   +/-   ##
=======================================
  Coverage   58.56%   58.57%
=======================================
  Files        1211     1211
  Lines       75003    75064   +61
  Branches    15593    15616   +23
=======================================
+ Hits        43929    43966   +37
- Misses      28319    28337   +18
- Partials     2755     2761    +6

Impacted Files
Coverage Δ

...ackages/debug/src/browser/debug-session-manager.ts
67.00% <0.00%> (-0.23%)
:arrow_down:

...ges/editor/src/browser/workbench-editor.service.ts
62.68% <0.00%> (-0.07%)
:arrow_down:

...c/browser/abstract-resource-preference-provider.ts
83.33% <0.00%> (+0.09%)
:arrow_up:

packages/search/src/common/content-search.ts
67.90% <ø> (ø)

...ages/file-service/src/node/file-service-watcher.ts
68.88% <40.00%> (-2.30%)
:arrow_down:

...xt/src/browser/services/file-tree-model.service.ts
54.22% <40.81%> (+0.34%)
:arrow_up:

...rences/src/browser/folders-preferences-provider.ts
65.77% <50.00%> (-0.90%)
:arrow_down:

...kages/components/src/recycle-tree/tree/TreeNode.ts
77.03% <74.57%> (-0.52%)
:arrow_down:

packages/search/src/browser/search.service.ts
41.25% <75.00%> (-0.10%)
:arrow_down:

...es/file-tree-next/src/browser/file-tree.service.ts
62.58% <79.16%> (+0.25%)
:arrow_up:

... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b9316c...d32bcb9. Read the comment docs.


Check and Refactor the development work in exp branch of easyDiffractionLib

The exp branch of easyDiffractionLib contains the first work of implementing different experiment types in easyDiffraction. The current work is pre-alpha and need to be looked at before polarized experiments can be implemented

needs proper review and discussion on how this should be implemented

TOF is already based on this, isn't it?


Remove Extra Whitespaces Between The Main Content And Footer - #314

Fixes

Fixes  #314 by @nandu-99

Description

This PR aims to remove the extra whitespaces present on the website to make the soothing experience.

Technical details

Reduced the bottom margin from 8em to 2em of the main content to vocabulary.css
Reduced the padding from 100px to 50px of the resource navbar to style.css
Removed the bottom padding of the main content to style.css

Type Of PR
This PR is a bug fix.
Screenshots

Checklist

[x] My pull request has a descriptive title (not a vague title like Update index.md).
[x] My pull request targets the default branch of the repository (main or master).
[x] My commit messages follow best practices.
[x] My code follows the established code style of the repository.
[ ] I added or updated tests for the changes I made (if applicable).
[x] I added or updated documentation (if applicable).
[x] I tried running the project locally and verified that there are no
visible errors.

Developer Certificate of Origin

For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

This is likely to be resolved by the earlier PR:

#316

Closing for now.


When using Promise.all to start connections, Kafka Broker times out

I had some code that essentially started two Kafka consumers (each for different topics), when doing:
await Promise.all([
  consumer1.start(),
  consumer2.start()
])

I'd receive errors (via logs) about the Kafka broker being unable to be connected to, but only for one of the consumers.
Finally, I changed it to:
await consumer1.start()
await consumer2.start()

And everything worked as expected.
The consumer start() code is essentially just:
  async start() {
    await this.consumer.connect();
    await this.consumer.subscribe({
      topic: this.topic,
      fromBeginning: true
    });

    await this.consumer.run({
       // ....
    })
  }

My gut feeling on this is that there's some sort of race condition triggered in the Broker connection code when starting multiple consumers (or potentially multiple consumers and producers) in parallel.

Perhaps further on this, what's the difference between await consumer.run({ and consumer.run({ — the docs use both, but aren't clear as to why you wouldn't want to await the promise from consumer.run()

My gut feeling on this is that there's some sort of race condition triggered in the Broker connection code when starting multiple consumers (or potentially multiple consumers and producers) in parallel.

Sounds like it, right? The first thing I wondered after this suggestion is whether the consumers are identical (subscribe to the same topics, etc.). That might be some useful info for whomever is going to dig into this.

Nope, totally different consumers (different topics & group-id's). I could probably try digging into it further, initially I thought it was an issue with my local kafka only having one broker (docker) so I added another, still didn't fix the issue: one consumer still failed repeatedly.
I also thought maybe it was due to a topic not existing, so I added admin code to ensure the topics existed, still no change.
I can probably add a breakpoint in and try to debug, but I'm not sure whether I'll get far.

On 26. Aug 2019, at 09:38, Jaap van Hardeveld<EMAIL_ADDRESS>wrote:
My gut feeling on this is that there's some sort of race condition triggered in the Broker connection code when starting multiple consumers (or potentially multiple consumers and producers) in parallel.
Sounds like it, right? The first thing I wondered after this suggestion is whether the consumers are identical (subscribe to the same topics, etc.). That might be some useful info for whomever is going to dig into this.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

@ThisIsMissEm we have a similar code running, and so far we haven't seen any issues. KafkaJS establishes a connection with each broker it has to interact, and due to the way the authentication mechanisms work it has to syncronize the connection.
So following your code:

connect will lock the connection to the specific broker, establish the TCP connection, fetch the available versions and execute the flow of the selected authentication mechanism.
subscribe will fetch metadata for the given topics
run will do a lot of things: join and syncronize the consumer group being the main tasks.

Can you post the error message you are receiving? I suspect that all consumers are trying to connect to the same broker, this will depend on the size of the cluster, and the connection is taking longer than the current timeout. You can try to increase the authenticationTimeout, e.g:
new Kafka({
  clientId: 'my-app',
  brokers: ['kafka1:9092', 'kafka2:9092'],
  authenticationTimeout: 5000,
})

what's the difference between await consumer.run({ and consumer.run({

Sorry about that, we should document this better. consumer.run never ends, it chains one promise after the other. Awaiting the first promise blocks your code until the consumer has joined the group and the group is in sync. We await sometimes to make the tests more stable, to only execute the test bits after the group is stable but in reality, you don't have to await for consumer.run.

Here's what the full log looks like (I've just changed a few names/verbs to redact internal information, the log is still consistent with what I see)
mock-api $ yarn start
yarn run v1.17.3
$ nodemon
[nodemon] 1.19.1
[nodemon] to restart at any time, enter `rs`
[nodemon] watching: /REDACTED/src/**/* .env
[nodemon] starting `ts-node -r tsconfig-paths/register src/index.ts | pino-pretty`
[1566941229752] INFO  (mock-api/68093 on QL000000870): Before Start
[1566941229753] INFO  (mock-api/68093 on QL000000870): Start
[1566941229753] INFO  (mock-api/68093 on QL000000870): starting consumer: products
    module: "ProductsConsumer"
[1566941229755] INFO  (mock-api/68093 on QL000000870): starting consumer: stores
    module: "StoresConsumer"
[1566941229795] INFO  (mock-api/68093 on QL000000870): kafkajs: Starting
    module: "KafkaConnector"
    namespace: "Consumer"
    groupId: "products-11c947b08e778a786280cf16c51ceb28f0a5095a0a79860724202d98977df3d2"
[1566941230762] INFO  (mock-api/68093 on QL000000870): kafkajs: Connection timeout
    module: "KafkaConnector"
    namespace: "Connection"
    broker: "localhost:9092"
    clientId: "store-service"
[1566941230764] INFO  (mock-api/68093 on QL000000870): kafkajs: Failed to connect to seed broker, trying another broker from the list: Connection timeout
    module: "KafkaConnector"
    namespace: "BrokerPool"
    retryCount: 0
    retryTime: 346
[1566941232119] INFO  (mock-api/68093 on QL000000870): kafkajs: Connection timeout
    module: "KafkaConnector"
    namespace: "Connection"
    broker: "localhost:9092"
    clientId: "store-service"
[1566941232119] INFO  (mock-api/68093 on QL000000870): kafkajs: Failed to connect to seed broker, trying another broker from the list: Connection timeout
    module: "KafkaConnector"
    namespace: "BrokerPool"
    retryCount: 1
    retryTime: 566
[1566941232830] INFO  (mock-api/68093 on QL000000870): kafkajs: Consumer has joined the group
    module: "KafkaConnector"
    namespace: "Runner"
    groupId: "products-11c947b08e778a786280cf16c51ceb28f0a5095a0a79860724202d98977df3d2"
    memberId: "store-service-dc827a15-a317-4d5d-a8fa-f3124e9cf6bc"
    leaderId: "store-service-dc827a15-a317-4d5d-a8fa-f3124e9cf6bc"
    isLeader: true
    memberAssignment: {
      "fake-qwell.products": [
        0
      ]
    }
    groupProtocol: "RoundRobinAssigner"
    duration: 3034
[1566941232866] INFO  (mock-api/68093 on QL000000870): Processing message at offset 0
    module: "ProductsConsumer"
    offset: "0"
    key: "27694a02-6410-43dd-9fd4-2377fb6017fa"
[1566941232866] INFO  (mock-api/68093 on QL000000870): Upserting product: 27694a02-6410-43dd-9fd4-2377fb6017fa
    module: "Repository"
[1566941233690] INFO  (mock-api/68093 on QL000000870): kafkajs: Connection timeout
    module: "KafkaConnector"
    namespace: "Connection"
    broker: "localhost:9092"
    clientId: "store-service"
[1566941233691] INFO  (mock-api/68093 on QL000000870): kafkajs: Failed to connect to seed broker, trying another broker from the list: Connection timeout
    module: "KafkaConnector"
    namespace: "BrokerPool"
    retryCount: 2
    retryTime: 1206
[1566941235903] INFO  (mock-api/68093 on QL000000870): kafkajs: Connection timeout
    module: "KafkaConnector"
    namespace: "Connection"
    broker: "localhost:9092"
    clientId: "store-service"
[1566941235903] INFO  (mock-api/68093 on QL000000870): kafkajs: Failed to connect to seed broker, trying another broker from the list: Connection timeout
    module: "KafkaConnector"
    namespace: "BrokerPool"
    retryCount: 3
    retryTime: 2384
[1566941239295] INFO  (mock-api/68093 on QL000000870): kafkajs: Connection timeout
    module: "KafkaConnector"
    namespace: "Connection"
    broker: "localhost:9092"
    clientId: "store-service"
[1566941239296] INFO  (mock-api/68093 on QL000000870): kafkajs: Failed to connect to seed broker, trying another broker from the list: Connection timeout
    module: "KafkaConnector"
    namespace: "BrokerPool"
    retryCount: 4
    retryTime: 3926
[1566941244230] INFO  (mock-api/68093 on QL000000870): kafkajs: Connection timeout
    module: "KafkaConnector"
    namespace: "Connection"
    broker: "localhost:9092"
    clientId: "store-service"
[1566941244230] INFO  (mock-api/68093 on QL000000870): kafkajs: Failed to connect to seed broker, trying another broker from the list: Connection timeout
    module: "KafkaConnector"
    namespace: "BrokerPool"
    retryCount: 5
    retryTime: 7920
[1566941244237] ERROR (KafkaJSNumberOfRetriesExceeded/68093 on QL000000870): Connection timeout
    KafkaJSNumberOfRetriesExceeded
      Caused by: KafkaJSConnectionError: Connection timeout
        at Timeout.onTimeout [as _onTimeout] (/REDACTED/node_modules/kafkajs/src/network/connection.js:149:23)
        at ontimeout (timers.js:436:11)
        at tryOnTimeout (timers.js:300:5)
        at listOnTimeout (timers.js:263:5)
        at Timer.processTimers (timers.js:223:10)

That was with the await on consumer.run removed. Even increasing the authenticationTimeout to 10,000 has no effect. We're usually operating against a single broker (development + staging environments, in production, we do have more brokers, but we still would like to see things reliable in our non-production environments.

I can see that you are not using authentication in your test environment, so the authenticationTimeout won't be used. It's common for a single broker to delay things a bit, try to increase the connectionTimeout, the default value is 1s.

Aha! Okay, yeah, increasing the connectionTimeout up to 10,000 helped, and the service started as expected. What’s a generally good amount of time to allow here? 1 second seems too low

On 28. Aug 2019, at 10:43, Túlio Ornelas<EMAIL_ADDRESS>wrote:
I can see that you are not using authentication in your test environment, so the authenticationTimeout won't be used. It's common for a single broker to delay things a bit, try to increase the connectionTimeout, the default value is 1s.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/tulios/kafkajs/issues/480?email_source=notifications&email_token=AAAHQ242XKII625SERMOTJTQGY3BVA5CNFSM4IPGVLU2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5KLLYA#issuecomment-525645280, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAHQ2Y4JQW4R45C3KACMP3QGY3BVANCNFSM4IPGVLUQ.

I don't know how to answer that :D
We have our services colocated with the Kafka cluster on AWS, so they have minimal latency. Since KafkaJS have long-lived connections, I would say that more significant value is not the problem, we need a timeout to catch connectivity errors or machines going down.
I think 10s looks good, we keep the defaults small so you have to think about your setup, but maybe we should increase this value a bit.

Having worked with time-outs before in previous deployments with other kafka clients: it should be less than the session timeout to prevent big issues, but network latency is definitely something to be tolerated too. We actually found 10s to be a good trade-off as well!


Feature: sub steps

Feature description:
Possibility to define substeps, eg:
How it is currently:
// stepDefinition.ts
Then(/"(.*?)" register step 1/, ... );
Then(/"(.*?)" register step 2/, ... );
Then(/"(.*?)" register step 3/, ... );
// If I would like to group them I have to create new step and copy/paste implementation.

// A.feature
Then "device_1" register step 1
Then "device_1" register step 2
Then "device_1" register step 3

// B.feature
Then "device_2" register step 1
Then "device_2" register step 2
Then "device_2" register step 3

How it may looks like:
// stepDefinition.ts
const registerStep1 = Then(/"(.*?)" register step 1/, ... );
const registerStep2 = Then(/"(.*?)" register step 1/, ... );
const registerStep3 = Then(/"(.*?)" register step 1/, ... );
Then(/"(.*?)" complete register/, async (deviceName) => {
  return [registerStep1(deviceName) , registerStep2(deviceName) , registerStep3(deviceName) ]
});

// A.feature
Then "device_1" complete register

// B.feature
Then "device_2" complete register

We can also resue substeps in feature files
// C.feature
Then "device_3" register step 3
// ...
Then "device_3" register step 1

Example html report:
Each step that contains substeps can contain folding/unfolding button (just like featrue and scenario).

Why this feature is important:

Wrapping cucumber steps into other steps allows me to keep granulation in test steps, reuse code and save a lot of time (eg. let's assume that I just added new steps to "complete register" sequence - I have to update it only in one place instead of 2 or even 50).
Without this functionality writing code using cucumber is like programming in language that do not allows you to nest functions calls.
I am aware of fact that I can wrap code of "step 1", "2" and "3" into "register complete" but then I will not be able to use each step as standalone fragment of code. Putting whole code into single step limits functionality and make reports less clear.

You may have already considered scenario outlines, but it seems that scenario outlines could get you a lot of the re-use you're looking to accomplish:
Scenario Outline: Registering Devices
....
Then "<DeviceName>" register step <StepNumber>
...

Examples:

| DeviceName | StepNumber |
| device_1   | 1          |
| device_2   | 2          |

Generally, this library is intended to bring idiomatic Cucumber to Jest, and leverages the official Cucumber feature file parser. This is delving into territory that, while may be useful to some people, is a pretty major departure from idiomatic Cucumber, and would require custom feature file parsing.

Closing due to staleness. Feel free to create a new issue if there is more to discuss.


Contribution duplication

@MichaelButkovic @mparent61

Coverage increased (+0.01%) to 86.41% when pulling 0ac788783b143740206dda8fa494896a9b0cf224 on contribution-duplication into 5f2d3557ce31bee06013657b5f9fa7feac17699d on master.

👍

Coverage increased (+0.01%) to 86.41% when pulling e59efaf911cd85513f06ea621c9bd911463283ce on contribution-duplication into b60e6139c7b4060416da6e0187b3cbaf3116979a on master.


Providing long-term support for gollvm

Hi.
Your project successfully compiles with gollvm  (Go 1.15.2 - I am currently working on re-building the bleeding edge version of gollvm, to target Go 1.15.3) .
You could update your README and mark the project as the one which could be built with gollvm.

@advancedwebdeveloper Can you help to push a PR for that?

How could I do that?


feat: Add markdown management and Plausible

Checklist

[ ] I did't over-scoped my PR
[x] My PR title match the commit convention
[x] I did not include breaking change
[ ] I included unit test that cover my changes
[ ] I added/updated the documentation about my changes
[x] I made my own code-review before requesting one

Description of the changes
Implementation of markdown content combined with the components API. Adding plausible.
Technical highlight/advice

I've changed the Nginx function params to manage optional ones.

:tada: This PR is included in version 1.0.0 :tada:
The release is available on:

GitHub release
v1.0.0

Your semantic-release bot :package::rocket:


Why do all the examples use app.csproj when mvc generates dotnet.csproj?

So I'm using odo with the examples.
We take this example (s2i-dotnetcore-ex) for our usage with Devfile.
I'm curious why the files in this example are named app.csproj when dotnet generates dotnet.csproj ?
Shouldn't the default be dotnet.csproj so it aligns with how dotnet generates examples?

In practice, project files get named like .NET namespaces, so you'll have something like `MyCompany.Xyz.AbC.FrontEnd.csproj.
app is a nice short name and conveys the project is an application (and not a library).


Error when trying to start mainflux-docker.sh

Hello,
I tried to start the mainflux-docker.sh script, unfortunately, I get some error with NATS and Cassandra :
Starting nats      ... error
Starting cassandra ... error

ERROR: for nats  Cannot start service nats: failed to create endpoint mainflux-nats on network bridge: failed to add the host (vethfbbd79a) <=> sandbox (vethfad9c8f) pair interfaces: operation not supported

ERROR: for cassandra  Cannot start service cassandra: failed to create endpoint mainflux-cassandra on network bridge: failed to add the host (vetha22aa05) <=> sandbox (vethd88054d) pair interfaces: operation not supported
ERROR: No containers to start
Aborting due to errexit on line 78. Exit code: 1

I'm using archlinux if that matter
docker version 17.10.0-ce
docker-compose version 1.17.0

Strange... Looks like you can not even start NATS and C* in the Docker.
Can you try running docker-compose just giving it this file: https://github.com/mainflux/mainflux/blob/master/bin/docker/docker-compose.infrastructure.yml
Otherwise fallback o manual installation: https://github.com/mainflux/mainflux/blob/master/bin/mainflux-install.sh

Ah, well.
No error there. And the mainflux-docker script works as well now.
My guess is one of the requirement needed a reboot (docker-compose maybe). I should have checked that, sorry.

Well,
No error here. And the docker script worked as well.
My guess is, one of the dependency needed a reboot (docker-compose maybe) to work properly. I should have checked that, sorry.


Error: Cannot find module '../../ts-force'

I am using ts-force-gen in a repository that is using rush/pnpm for handling dependencies and it fails with
Error: Cannot find module '../../ts-force'

I noticed there are indeed relative imports to import the ts-force module. They work locally in development and apparently also with npm because it places the dependency in the same relative position. In order to support all environments these relative imports should be changed to an absolute import of ts-force.

exact same issue here, also using pnpm


SKY-1862 experiment duration estimate docs

Dev Docs PR
Add documentation on Experiment Duration Estimate
Description
Describe your changes.
Deadline
When do these changes need to be live on the site?
Hopefully, by the August 26.
Change type

[ ] Doc bug fix. Fixes #[insert issue number]. Amplitude contributors include Jira issue number.
[ ] Doc update.
[ ] New documentation.
[ ] Non-documentation related fix or update.

PR checklist:

[ ] My documentation follows the style guidelines of this project.
[ ] I previewed my documentation on a local server using mkdocs serve.
[ ] Running mkdocs serve didn't generate any failures.
[ ] I have performed a self-review of my own documentation.

@amplitude-dev-docs
@caseyamp

2 suggestions:

Since the info box is the first thing readers will see, we should make sure that it clearly states all the antecedents. So instead of This is only for the primary metric and sequential testing right now. This is not supported in Experiment Results. I would clarify what This refers to.
The Types of Errors sections feels like it needs an intro. Is the purpose here to say "there are multiple ways the duration estimate can be off" or "all duration estimates are subject to uncertainty, here is how we mitigate them" or something else?

2 suggestions:

Since the info box is the first thing readers will see, we should make sure that it clearly states all the antecedents. So instead of This is only for the primary metric and sequential testing right now. This is not supported in Experiment Results. I would clarify what This refers to.
The Types of Errors sections feels like it needs an intro. Is the purpose here to say "there are multiple ways the duration estimate can be off" or "all duration estimates are subject to uncertainty, here is how we mitigate them" or something else?

I can make those changes
A little bit of both of those and that this is an estimate don't assume we are always correct. Don't be surprised if we are off by a couple of days

Talked with @bgiori and concluded that this should be a help center article and not a dev docs article. So I am closing this PR.


Vue.js support

Summary
I would love to use tinacms with Vue.js. Vue.js is a great framework with a good learning curve.
Motivation
I'm a vue.js junior dev and we don't have much open source alternative with git-based cms. Tinacms seems very interesting for jamstack websites. I noticed that there was no issue asking for a vue.js support.
List of packages that should be adapted :

[ ] react-tinecms
[ ] react-dismissible
[ ] react-tinacms-editor
[ ] react-tinacms-github
[ ] react-tinacms-inline

The core team is currently focused on tailoring a good editing experience with React, we're still pre v1.0 and a lot of things are moving.  TinaCMS could work with Vue.js, but we'll need help from the VueJS community to adapt and maintain all the packages for VueJS.

This is awesome! Definitely needed, but not a small enhancement to take on. The entire Tina UI is built with React. We've discussed converting it to web components (with Stencil) to mitigate this issue. I would take a look at this PR to see previous discussion.

hello I'm interested in this, is there any current development that I could help with this?

👀

👀

eyes

Please open this issue to track the progression of Vue.js

Vue is currently on v3.2.47
Nuxt is on v3.3.1
BTW Nuxt has a Content module among others. That module has MDC support.

Would love to see if there are any plans to add Vue or Nuxt support.

To have this in the docs as "planned" and then having it basically "dead" for 3 years? Not sure that's the best way to get new customers. I was so excited by finding it to support Vue/Nuxt… guess not.

Nuxt Studio is built on to of Nuxt Content module and is a really good alternative if you love working with Vue.

I use netlify to manage markdown content in git in vue nuxt.
# start netlify cms, make sure to have a sep port, if running more than one website at a time
# change port in static\admin\config.yml
yarn start:cmsProxy
yarn dev
# navigate to localhost:3000/admin to see cms system

here's my package.json
{
  "name": "nuxt-content-article",
  "version": "1.0.0",
  "private": true,
  "scripts": {
    "dev": "nuxt",
    "build": "nuxt build",
    "start": "nuxt start",
    "generate": "nuxt generate",
    "lint:js": "eslint --ext .js,.vue --ignore-path .gitignore .",
    "lint:style": "stylelint **/*.{vue,css} --ignore-path .gitignore",
    "lint:stylefix": "stylelint **/*.{vue,css}  --fix  --ignore-path .gitignore",
    "lint:fix": "eslint --ext .js,.vue  --fix --ignore-path .gitignore .",
    "lint": "yarn lint:js && yarn lint:style",
    "start:cms": "netlify dev --port=8891",
    "start:cmsProxy": "npx netlify-cms-proxy-server"
  },
  "lint-staged": {
    "*.{js,vue}": "eslint",
    "*.{css,vue}": "stylelint"
  },
  "dependencies": {
    "@nuxt/content": "^1.11.1",
    "nuxt": "^2.14.12",
    "prism-themes": "1.5.0"
  },
  "devDependencies": {
    "@nuxtjs/eslint-config": "^5.0.0",
    "@nuxtjs/eslint-module": "^3.0.2",
    "@nuxtjs/stylelint-module": "4.0.0",
    "@nuxtjs/tailwindcss": "^3.4.2",
    "babel-eslint": "10.1.0",
    "eslint": "^7.17.0",
    "eslint-config-prettier": "^7.1.0",
    "eslint-plugin-nuxt": "^2.0.0",
    "eslint-plugin-prettier": "^3.3.1",
    "husky": "^4.3.7",
    "jquery": "^3.5.1",
    "lint-staged": "^10.5.3",
    "netlify-cli": "^2.69.10",
    "prettier": "^2.2.1",
    "stylelint": "13.8.0",
    "stylelint-config-prettier": "8.0.2",
    "stylelint-config-standard": "20.0.0"
  }
}


Suggestions for clarification

Hey, I have tried some challenges and here are some small suggestion of things I was confused by / did not directly get.

First: https://github.com/microsoft/azure-health-data-services-workshop/tree/main/Challenge-04 - Query and Search FHIR#exercise-task-6
Step 7, task 4: It might makes sense to add the clarification, that the operation is not successful as long as the first entry in the bundle is an OperationOutcome, stating "The search parameter 'race' is not supported for resource type 'Patient'.". Because on the first look it still returns many (all?) Patients and it could look like a successful operation. After waiting a moment and resending the request, the response is as expected.

Second: https://github.com/microsoft/azure-health-data-services-workshop/tree/main/Challenge-05 - Export and Anonymize Data#step-2-configure-storage-account-for-export
The note of Step 2 contains this part:

"The name of this storage account ends with "expsa". Keep in mind that you are configuring the storage account in this step (and not the FHIR service!). In the storage account, be careful not to add a role assignment to a service client or a service principal by mistake!"

It gave me the impression that in the dialogs I have to select the blob storage as target for the role assignment. In contrast to the previous sentences.
In my flow of adding the role I haven't interacted with the storage name or resource. I just gave the FHIR service the role:
As logged by an Azure notification (fhirtrn is the FHIR Service resource):

"Added Role assignment:
xyz…hdsws/fhirtrn was added as Storage Blob Data Contributor for $resourcegroupname."

Everything else worked great! Thanks 👍

@jakesmolka Thanks Jake for testing the challenges and giving your feedback! I'll take a look at how we can fix these two issues you pointed out.

Resolved


Update the Functions example README to use the new .env.enc

https://github.com/smartcontractkit/smart-contract-examples/blob/main/add-functions-to-project/README.md
The readme still refers to using the .env file. It should now use .env.enc as found in the new docs. https://github.com/smartcontractkit/documentation/pull/1256#pullrequestreview-1394906074

Can I work on this ?


Suggestion A way to Lock screens.

Any way really, use the wrench on it or just a button inside but a way to lock screens so you can no longer open there settings but are still usable. So when your done configuring them you dont have to worry about clicking them by mistake.

Preferably a way that prevents other players from editing them, too...


Auto Populate Affiliation Lookup Field on Student Course Connection

Note: FOR INTERNAL USE ONLY. For support questions, please use the EDA Chatter group in The Power of Us Hub.
For feature requests, please use the Ideas tab in The Power of Us Hub.

Do you want to request a feature or report a bug?
Bug

What is the current behavior?
When a user creates a Student Course Connection and a Program Enrollment is associated to that new Student Course Connection, the Affiliation lookup field on Student Course Connection is not auto populated even if an Affiliation record exist on the Program Enrollment.

What is the expected behavior?
When a user creates a Student Course Connection and a Program Enrollment is associated to that new Student Course Connection, the Affiliation lookup field on Student Course Connection should be auto populated if an Affiliation record exist on the Program Enrollment and the Program Enrollment is associated to the new Student Course Connection.

What is the motivation / use case for changing the behavior?
We want to mimic the behavior for new Faculty Course Connection where Affiliation is auto populated if an Affiliation exists on Program Enrollment and Program Enrollment is associated to the new Faculty Course Connection.

**lurch : attach W-037612

@kdy618 Hmm I'm not sure that worked - I think you might not need a space between lurch and :

@kdy618 Hmm I'm not sure that worked - I think you might not need a space between lurch and :

ty for that catch!

Tracking W-037612

This issue was delivered in May 2020.


Hide notification on swipe

Not hide the notification view on swipe gesture like system notification

I've created a pull request with this.
https://github.com/nhdang103/HDNotificationView/pull/4

thanks @vCrespoP

Thanks


build/cargo: touching unrelated file triggers unnecessary re-link

There seems to be a problem in our incremental build system. I discovered this when comparing uutils against GNU coreutils in a semi-automated way, and my script wrote to some new, unrelated files, because surely that won't impact uutils, right?
Turns out, cargo re-links the coreutils binary whenever a new file pops up:
$ cargo +stable build --all-features
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.14s
$ cargo +stable build --all-features
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.14s
$ cargo +stable build --all-features
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.17s
$ cargo +stable build --all-features
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.14s
$ touch completely_unrelated
$ cargo +stable build --all-features # ?!
   Compiling coreutils v0.0.27 (/home/user/workspace/coreutils-rs)
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 2.74s
$ cargo +stable build --all-features
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.14s
$ cargo +stable build --all-features
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.14s
$ cargo +stable build --all-features
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.17s

Notice the extra 2.6 seconds in the middle? that makes everything quite slow. I'm not sure where the bug lives, or even whether it's uutil's fault at all (and perhaps a missed optimization in cargo?), but let's start here.

I may not be the authority here, but it looks like a cargo thing to me. As far as I'm aware, there is no way for cargo projects to force the rebuild without user interaction. I may be wrong though, feel free to correct me.

I don't understand? This issue is about cargo rebuilding too often, and not too seldomly.

What I tried to say was that I don't think it's uutils' fault, rather a bug in cargo. Have you perhaps tried a similar thing on other cargo projects to see if the issue persists?

The build string build.rs does not emit any cargo::rerun-if-changed= directive, which causes the build script to be rebuilt (and the link to retrigger) every time any file is changed within the package.


close mix server when configStore failure occurred

Close mix server when configStore failure occurred.

Hi @zhuguihua. Thanks for your PR.
I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/ok-to-test

/lgtm

@zhuguihua: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
b0aff2acb161e0b3421f4d64b3a0e4d08a794a9d
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


keybase connection issue

Keybase client won't connect after I updated it
my log id: 8b8a3994ac1da3183bca171c

Still an issue after update this morning. Currently on version 1.0.36-20171121163324+f68b10e

Fixed by re-install.


how to execute omnicore????

I downloaded from https://github.com/OmniLayer/omnicore/releases/download/v0.3.1/omnicore-0.3.1-aarch64-linux-gnu.tar.gz
There was an error where i executed ./omnicored..
error is -bash: ./omnicored: cannot execute binary file

Hi, which OS are you running?

Seems you download the wrong version, this is for linux x64, https://github.com/OmniLayer/omnicore/releases/download/v0.3.1/omnicore-0.3.1-x86_64-linux-gnu.tar.gz


docs.rs failing to compile dependent crate

Hello everyone. I hope you are having a good start to the year.
I'm having problems compiling the docs for my crate (map-engine) probably because docs.rs' build system doesn't have GDAL installed.
I saw that you guys have a custom build script that mentions a similar (?) problem. I was hoping that docs.rs would execute that and that everything would work :smile:
I also noticed that many of the crates that depend on gdal (not as a development dependency) have the same problem.
Do you have any recommendations on how to deal with this?
For future reference, I also created an issue on their repo: https://github.com/rust-lang/docs.rs/issues/1591
Thanks

Looks like we're taking this branch in the gdal (not gdal-sys) build script.

@spadarian can you add
[package.metadata.docs.rs]
all-features = true
rustdoc-args = ["--cfg", "docsrs"]

to your manifest?

I will give that a try tomorrow.
Is there a way of checking if that works locally? I guess I can use their docker container...
Just to confirm... not rustc-args = ["--cfg", "docsrs"] like you have in your Cargo.toml?

I also have the same problem in rasters crate.  I have included the [package.metadata.docs.rs] section, but the build still errors out.
The previous version of the crate (which used gdal 0.7.2) did build successfully: https://docs.rs/crate/rasters/0.6.2 .  Upgrading to latest, broke docs.

I seem to have added rustc-args = [...], which worked in previous versions of the rasters crate (that uses gdal 0.7.2).
However, I tried locally (as explained using docs.rs github) using rustdoc-args = [...] and it still fails.
Intersetingly, even the previous version that did build successfully on docs.rs now fails when tried locally.  It suggests that this may be a bug in the docs.rs build process.

Apparently, the guys from docs.rs have reported a bug in cargo, which is still blocked on https://github.com/rust-lang/cargo/issues/10206

The cargo issue above seems to be fixed now;  should it work now?

I tried locally and it still fails...

i think we had that issue before...  Then it was caused by docs.rs but it might be something different this time

The cargo issue is fixed but docs.rs may also need to fix things (ref. https://github.com/rust-lang/docs.rs/issues/1580 , https://github.com/rust-lang/docs.rs/issues/1591).

Builds are still failing (https://docs.rs/crate/geozero/0.9.5-beta1/builds/597082)

I noticed this fix in proc-macro2 crate that has a similar problem.  Would it work for us?
https://github.com/dtolnay/proc-macro2/pull/310/files

It wouldn't work. The compiler would try to compile both branches of the if statement, failing to find gdal_sys::GDALVersionInfo.

@spadarian @pka can you check your gdal-dependent crates and verify the docs do build?  I checked rasters.rs locally and it builds;  it doesn't even seem to need the rustc-args configuration anymore.

docs.rs build for geozero is working again, thanks!

Great!  Closing this as completed.


expand_nested bug fix and changing model.summary style

The bug fixing is based on PR #15251.
There were 2 bugs with the expand_nested:
Bug1:

After Changes Bug1:

Bug2:
text_file = open('summary.txt', 'w');
def print_text(text, end = "\n"):
    print(text, end = end, file = text_file)

Use of end = \n additionally.  Without it, throws an error.
After changes Bug2:
text_file = open('summary.txt', 'w');
def print_text(text):
    print(text, file = text_file)

Also, I have tried to change the style of model.summary by replacing _ with space that looks good and less chaotic with and without expand_nested
expand_nested=False

expand_nested=True

Note: I need to update the test cases also. But before that, please look into the changes.

Thanks for the PR! Please add a simple test for the fixes. It could be an integration test checking the output of the summary for a given model.

Should I add the test cases or make changes to the existing ones?

@gbaned please merge this PR!


Fixed User Details Validation

Issue Number
fixes #4

Describe the changes you've made

Used RegEx module to find matching pattern for Name, Contact & Email ID.
If a user enters invalid details (which is not recognized by the pattern specified in program) such as name, number, email id, the user is prompted with an error.

Describe if there is any unusual behaviour of your code(Write NA if there isn't)
NA
Additional context (OPTIONAL)
Add any other context or screenshots about the feature request here.
Test plan (OPTIONAL)
A good test plan should give instructions that someone else can easily follow.
How someone can test your code?
Checklist

[ ] I have added my name in the contributors list at the end of README.md file.
[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.
[x] The title of my pull request is a short description of the requested changes.
[x] Open Source Program names (LGM-SOC)

Resolve conflicts.

Working on it.

check it @QAZIMAAZARSHAD

Nope.
Fetch upstream. Try with a separate branch.


[CLIP]Fix gpu tests

Stack from ghstack (oldest at bottom):

#291
-> #290
#288

Codecov Report

Merging #290 (4dc46c5) into gh/ankitade/16/base (9fea279) will not change coverage.
The diff coverage is n/a.

@@                 Coverage Diff                  @@
##           gh/ankitade/16/base     #290   +/-   ##
====================================================
  Coverage                91.85%   91.85%
====================================================
  Files                       52       52
  Lines                     3107     3107
====================================================
  Hits                      2854     2854
  Misses                     253      253

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ankitade has imported this pull request.  If you are a Facebook employee, you can view this diff on Phabricator.

#17


Consolidate project config under pyproject

See the latest docs at: https://packaging.python.org/en/latest/ and a sample project at: https://github.com/pypa/sampleproject
Summary of changes:

consolidate project setup/config under pyproject.toml

this makes setup.cfg and more importantly setup.py no more

some doc: https://packaging.python.org/en/latest/discussions/setup-py-deprecated/

git-ignore bio2zarr/_version.py

scm was configured to write this file, I'm not entire sure we need it, but to keep this consistent I have copied it over, but that also means we probably want to gitignore it?

configure build-system
include readme in the project config
urls include links to both documentation and repo
zip-safe is deprecated, and include-package-data is true by default

see: https://setuptools.pypa.io/en/latest/userguide/pyproject_config.html#setuptools-specific-configuration

update tool.ruff target version to the minimal specified supported python - py3.9

this also forces to use list vs typing.List etc

use ruff's isort support

some setting are not available in ruff - do we need them?

remove obsolete flake8 config
git-ignore IDE directories including .idea and .vscode
update pre-commit ruff version from 0.3.7 to 0.4.2

I have tested this setup using:

python3 -m build --wheel

The resulting package:

unzip -l dist/bio2zarr-0.0.7.dev6+gc03b708-py3-none-any.whl

Archive:  dist/bio2zarr-0.0.7.dev6+gc03b708-py3-none-any.whl
  Length      Date    Time    Name
---------  ---------- -----   ----
       49  04-29-2024 08:11   bio2zarr/__init__.py
      527  04-29-2024 08:11   bio2zarr/__main__.py
      445  04-29-2024 10:01   bio2zarr/_version.py
    14397  04-29-2024 08:11   bio2zarr/cli.py
     9006  04-29-2024 08:11   bio2zarr/core.py
     6768  04-29-2024 08:11   bio2zarr/plink.py
      142  04-29-2024 08:11   bio2zarr/provenance.py
       79  04-29-2024 08:11   bio2zarr/typing.py
    83310  04-29-2024 09:56   bio2zarr/vcf.py
    17328  04-29-2024 09:56   bio2zarr/vcf_utils.py
    11357  04-29-2024 10:01   bio2zarr-0.0.7.dev6+gc03b708.dist-info/LICENSE
    16931  04-29-2024 10:01   bio2zarr-0.0.7.dev6+gc03b708.dist-info/METADATA
       92  04-29-2024 10:01   bio2zarr-0.0.7.dev6+gc03b708.dist-info/WHEEL
      131  04-29-2024 10:01   bio2zarr-0.0.7.dev6+gc03b708.dist-info/entry_points.txt
        9  04-29-2024 10:01   bio2zarr-0.0.7.dev6+gc03b708.dist-info/top_level.txt
     1323  04-29-2024 10:01   bio2zarr-0.0.7.dev6+gc03b708.dist-info/RECORD
---------                     -------
   161894                     16 files

You can see the files included in the dist-info in a gist here.
Test install/run was successful:

pip install projects/bio2zarr/dist/bio2zarr-0.0.7.dev6+gc03b708-py3-none-any.whl

Follow by:

vcf2zarr explode sample.vcf.gz sample.exploded


Rename variables in compliance with the convention

👏 解決掉的 issue / Resolved Issues

#3
#38

📝 相關的 issue / Related Issues
⛏ 變更內容 / Details of Changes

s/Id/ID
fix typos
remove redundant names and codes
catch errors from Write()

Codecov Report

Merging #42 (adca900) into development (2963132) will increase coverage by 0.03%.
The diff coverage is 8.06%.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2963132...adca900. Read the comment docs.

internal/delivery/http/route_token.go:15:13: Error return value of `r.ParseForm` is not checked (errcheck)
	r.ParseForm()

用 _ = r.ParseForm() 處理

internal/delivery/http/http.go:16:47: exported func NewHTTPDelivery returns unexported type *github.com/Ptt-official-app/Ptt-backend/internal/delivery/http.httpDelivery, which can be annoying to use (golint)
func NewHTTPDelivery(usecase usecase.Usecase) *httpDelivery {
                                              ^

httpDelivery改成exported

internal/delivery/http/route_classes.go:58:2: S1023: redundant `return` statement (gosimple)
	return
	^

查一下API設計文件看後面的程式碼是否需要，不然return跟後面的comment可以砍掉

internal/delivery/http/route_classes.go:14:31: func `(*httpDelivery).getClass` is unused (unused)
internal/delivery/http/route.go:24:31: func `(*httpDelivery).routeClass` is unused (unused)

這兩個method補上註解 如果沒有在API設計文件內那就先加上// nolint

剩下的我這兩天看看能不能用.golangci.yml的設定處理掉

目前可能需要重開 PR 把它變成 merge 到 development_enable_lint 喔

已修復


(Windows 10) During plugin load it throws error

Actual behavior (Required!)
Error detected while processing function javacomplete#Start[1]..javacomplete#server#Start:
line   44:
Traceback (most recent call last):
File "", line 1, in
File "C:\Users\Parrot.vim\bundle\javacomplete2\autoload\javavibridge.py", line 55, in setupServer
os.mkdir(logdir)
FileNotFoundError: [WinError 3] The system cannot find the path specified: '\tmp\javavi_log'
Expected behavior (Required!)
Plugin load should be completed successful in windows
The steps to reproduce actual behavior (Required!)

... Just normal plugin install on windows should give this error, because \tmp folder doesn't exist in windows.
...
...

Environment (Required!)

OS: Windows 10
Vim version: 8.0.134
Neovim version:

Q&A

Yes, I tried minimal .vimrc configuraion.
Yes, I have enabled logs with JCdebugEnableLogs and can put here content of JCdebugGetLogContent command, if you need.
Even, if you wish, I can set g:JavaComplete_JavaviDebug to 1, than set g:JavaComplete_JavaviLogfileDirectory, and put here server logs, too.

Screenshot (Optional)
The output of :redir and :message (Optional)

Should be fixed on develop branch


Generator messes with activity analysis

MWE, similar in spirit to #1266 (maybe it is the same underlying issue):
using Enzyme
using Distributions

N = 1000
c₀ = rand(Poisson(1.2), N)
λ₀ = rand(N)

loss_vec(c, λ) = sum(logpdf.(Poisson.(λ), c))
loss(c, λ) = sum(logpdf(Poisson(λ[i]), c[i]) for i in eachindex(c, λ))

Enzyme.autodiff(Reverse, loss_vec, Active, Const(c₀), Duplicated(λ₀, Enzyme.make_zero(λ₀)))  # succeeds
Enzyme.autodiff(Reverse, loss, Active, Const(c₀), Duplicated(λ₀, Enzyme.make_zero(λ₀)))  # fails

Stacktrace:
julia> Enzyme.autodiff(Reverse, loss, Active, Const(c₀), Duplicated(λ₀, Enzyme.make_zero(λ₀)))  # fails
ERROR: Enzyme execution failed.
Mismatched activity for:   store {} addrspace(10)* %0, {} addrspace(10)** %.fca.0.gep30, align 8, !dbg !105, !noalias !108 const val: {} addrspace(10)* %0
Type tree: {[-1]:Pointer, [-1,0]:Pointer, [-1,0,-1]:Integer, [-1,8]:Integer, [-1,9]:Integer, [-1,10]:Integer, [-1,11]:Integer, [-1,12]:Integer, [-1,13]:Integer, [-1,14]:Integer, [-1,15]:Integer, [-1,16]:Integer, [-1,17]:Integer, [-1,18]:Integer, [-1,19]:Integer, [-1,20]:Integer, [-1,21]:Integer, [-1,22]:Integer, [-1,23]:Integer, [-1,24]:Integer, [-1,25]:Integer, [-1,26]:Integer, [-1,27]:Integer, [-1,28]:Integer, [-1,29]:Integer, [-1,30]:Integer, [-1,31]:Integer, [-1,32]:Integer, [-1,33]:Integer, [-1,34]:Integer, [-1,35]:Integer, [-1,36]:Integer, [-1,37]:Integer, [-1,38]:Integer, [-1,39]:Integer}
You may be using a constant variable as temporary storage for active memory (https://enzyme.mit.edu/julia/stable/#Activity-of-temporary-storage). If not, please open an issue, and either rewrite this variable to not be conditionally active or use Enzyme.API.runtimeActivity!(true) as a workaround for now

Stacktrace:
 [1] MappingRF
   @ ./reduce.jl:100
 [2] _foldl_impl
   @ ./reduce.jl:58
 [3] foldl_impl
   @ ./reduce.jl:48
 [4] mapfoldl_impl
   @ ./reduce.jl:44
 [5] mapfoldl
   @ ./reduce.jl:175
 [6] mapreduce
   @ ./reduce.jl:307
 [7] sum
   @ ./reduce.jl:535
 [8] sum
   @ ./reduce.jl:564
 [9] loss
   @ ~/Downloads/logpdf.jl:11

Stacktrace:
  [1] throwerr(cstr::Cstring)
    @ Enzyme.Compiler ~/.julia/packages/Enzyme/KJgKj/src/compiler.jl:1319
  [2] MappingRF
    @ ./reduce.jl:100 [inlined]
  [3] _foldl_impl
    @ ./reduce.jl:58 [inlined]
  [4] foldl_impl
    @ ./reduce.jl:48 [inlined]
  [5] mapfoldl_impl
    @ ./reduce.jl:44 [inlined]
  [6] mapfoldl
    @ ./reduce.jl:175 [inlined]
  [7] mapreduce
    @ ./reduce.jl:307 [inlined]
  [8] sum
    @ ./reduce.jl:535 [inlined]
  [9] sum
    @ ./reduce.jl:564 [inlined]
 [10] loss
    @ ~/Downloads/logpdf.jl:11 [inlined]
 [11] diffejulia_loss_8145wrap
    @ ~/Downloads/logpdf.jl:0
 [12] macro expansion
    @ Enzyme.Compiler ~/.julia/packages/Enzyme/KJgKj/src/compiler.jl:5310 [inlined]
 [13] enzyme_call(::Val{…}, ::Ptr{…}, ::Type{…}, ::Type{…}, ::Val{…}, ::Type{…}, ::Type{…}, ::Const{…}, ::Type{…}, ::Const{…}, ::Duplicated{…}, ::Float64)
    @ Enzyme.Compiler ~/.julia/packages/Enzyme/KJgKj/src/compiler.jl:4988
 [14] (::Enzyme.Compiler.CombinedAdjointThunk{…})(::Const{…}, ::Const{…}, ::Vararg{…})
     Use `show(err)` to see complete types.

Julia v1.10.0, Enzyme v0.11.14

Issue renamed because I realized that the following fix works:
function loss2(c, λ)
    l = 0.
    for i in eachindex(c, λ)
        l += logpdf(Poisson(λ[i]), c[i])
    end
    return l
end

Is the generator type-unstable?

I believe this should be fixed by https://github.com/EnzymeAD/Enzyme.jl/pull/1212 . Please reopen if it persists.

Also fixed on main, thanks!


add root marker by default in channels

Thanks for the great app, I enjoy it!
But I have a problem. The events I post in the app do not show up correctly in other apps.
I have found that adding a root marker in the e tag solves the problem.
Please confirm when you have time, thank you.

Confirmed that NIP-28 messages should have a root tag pointing to the channel event https://github.com/nostr-protocol/nips/blob/master/28.md#kind-42-create-channel-message
Sorry it took me so long to look at this PR


Fix incorrect execution path when pickling rp_trees for sparse data.

I'm getting the following error while pickling a fitted UMAP object. While this happening using umap it looks like the problem is in pynndescent
Traceback (most recent call last):
  File "pipeline.py", line 236, in <module>
    fire.Fire()
  File "/usr/local/lib/python3.8/site-packages/fire/core.py", line 141, in Fire
    component_trace = _Fire(component, args, parsed_flag_args, context, name)
  File "/usr/local/lib/python3.8/site-packages/fire/core.py", line 466, in _Fire
    component, remaining_args = _CallAndUpdateTrace(
  File "/usr/local/lib/python3.8/site-packages/fire/core.py", line 681, in _CallAndUpdateTrace
    component = fn(*varargs, **kwargs)
  File "pipeline.py", line 72, in process
    joblib.dump(doc_to_vec_transform, f'/doc2vec.pk.gz.{site}')
  File "/usr/local/lib/python3.8/site-packages/joblib/numpy_pickle.py", line 480, in dump
    NumpyPickler(f, protocol=protocol).dump(value)
  File "/usr/local/lib/python3.8/pickle.py", line 487, in dump
    self.save(obj)
  File "/usr/local/lib/python3.8/site-packages/joblib/numpy_pickle.py", line 282, in save
    return Pickler.save(self, obj)
  File "/usr/local/lib/python3.8/pickle.py", line 603, in save
    self.save_reduce(obj=obj, *rv)
  File "/usr/local/lib/python3.8/pickle.py", line 717, in save_reduce
    save(state)
  File "/usr/local/lib/python3.8/site-packages/joblib/numpy_pickle.py", line 282, in save
    return Pickler.save(self, obj)
  File "/usr/local/lib/python3.8/pickle.py", line 560, in save
    f(self, obj)  # Call unbound method with explicit self
  File "/usr/local/lib/python3.8/pickle.py", line 971, in save_dict
    self._batch_setitems(obj.items())
  File "/usr/local/lib/python3.8/pickle.py", line 997, in _batch_setitems
    save(v)
  File "/usr/local/lib/python3.8/site-packages/joblib/numpy_pickle.py", line 282, in save
    return Pickler.save(self, obj)
  File "/usr/local/lib/python3.8/pickle.py", line 578, in save
    rv = reduce(self.proto)
  File "/usr/local/lib/python3.8/site-packages/pynndescent/pynndescent_.py", line 935, in __getstate__
    self._init_search_function()
  File "/usr/local/lib/python3.8/site-packages/pynndescent/pynndescent_.py", line 1178, in _init_search_function
    def tree_search_closure(point, rng_state):
  File "/usr/local/lib/python3.8/site-packages/numba/core/decorators.py", line 221, in wrapper
    disp.compile(sig)
  File "/usr/local/lib/python3.8/site-packages/numba/core/compiler_lock.py", line 32, in _acquire_compile_lock
    return func(*args, **kwargs)
  File "/usr/local/lib/python3.8/site-packages/numba/core/dispatcher.py", line 857, in compile
    cres = self._compiler.compile(args, return_type)
  File "/usr/local/lib/python3.8/site-packages/numba/core/dispatcher.py", line 81, in compile
    raise retval
  File "/usr/local/lib/python3.8/site-packages/numba/core/dispatcher.py", line 91, in _compile_cached
    retval = self._compile_core(args, return_type)
  File "/usr/local/lib/python3.8/site-packages/numba/core/dispatcher.py", line 104, in _compile_core
    cres = compiler.compile_extra(self.targetdescr.typing_context,
  File "/usr/local/lib/python3.8/site-packages/numba/core/compiler.py", line 602, in compile_extra
    return pipeline.compile_extra(func)
  File "/usr/local/lib/python3.8/site-packages/numba/core/compiler.py", line 352, in compile_extra
    return self._compile_bytecode()
  File "/usr/local/lib/python3.8/site-packages/numba/core/compiler.py", line 414, in _compile_bytecode
    return self._compile_core()
  File "/usr/local/lib/python3.8/site-packages/numba/core/compiler.py", line 394, in _compile_core
    raise e
  File "/usr/local/lib/python3.8/site-packages/numba/core/compiler.py", line 385, in _compile_core
    pm.run(self.state)
  File "/usr/local/lib/python3.8/site-packages/numba/core/compiler_machinery.py", line 339, in run
    raise patched_exception
  File "/usr/local/lib/python3.8/site-packages/numba/core/compiler_machinery.py", line 330, in run
    self._runPass(idx, pass_inst, state)
  File "/usr/local/lib/python3.8/site-packages/numba/core/compiler_lock.py", line 32, in _acquire_compile_lock
    return func(*args, **kwargs)
  File "/usr/local/lib/python3.8/site-packages/numba/core/compiler_machinery.py", line 289, in _runPass
    mutated |= check(pss.run_pass, internal_state)
  File "/usr/local/lib/python3.8/site-packages/numba/core/compiler_machinery.py", line 262, in check
    mangled = func(compiler_state)
  File "/usr/local/lib/python3.8/site-packages/numba/core/typed_passes.py", line 94, in run_pass
    typemap, return_type, calltypes = type_inference_stage(
  File "/usr/local/lib/python3.8/site-packages/numba/core/typed_passes.py", line 72, in type_inference_stage
    infer.propagate(raise_errors=raise_errors)
  File "/usr/local/lib/python3.8/site-packages/numba/core/typeinfer.py", line 1071, in propagate
    raise errors[0]
numba.core.errors.TypingError: Failed in nopython mode pipeline (step: nopython frontend)
Invalid use of type(CPUDispatcher(<function select_side at 0x7f17395dbb80>)) with parameters (readonly array(float32, 2d, C), float32, readonly array(float32, 1d, C), array(int64, 1d, C))
Known signatures:
 * (array(float32, 1d, C), float32, array(float32, 1d, C), array(int64, 1d, C)) -> bool
 * (readonly array(float32, 1d, C), float32, readonly array(float32, 1d, C), array(int64, 1d, C)) -> bool
During: resolving callee type: type(CPUDispatcher(<function select_side at 0x7f17395dbb80>))
During: typing of call at /usr/local/lib/python3.8/site-packages/pynndescent/pynndescent_.py (1181)

File "../../../../../usr/local/lib/python3.8/site-packages/pynndescent/pynndescent_.py", line 1181:
        def tree_search_closure(point, rng_state):
            <source elided>
            while tree_children[node, 0] > 0:
                side = select_side(
                ^

Things seem to go wrong here:
  File "/usr/local/lib/python3.8/site-packages/pynndescent/pynndescent_.py", line 935, in __getstate__
    self._init_search_function()

as it should be using:
    self._init_sparse_search_function()
When it uses _init_search_function() it ends up trying to use select_side (instead of sparse_select_side) which can't deal with the sparse_hyperplane_type:
dense_hyperplane_type = numba.float32[::1]
sparse_hyperplane_type = numba.float64[:, ::1]

Hence the signature missmatch:
(readonly array(float32, 2d, C), float32, readonly array(float32, 1d, C), array(int64, 1d, C))
Expected: (readonly array(float32, 1d, C), float32, readonly array(float32, 1d, C), array(int64, 1d, C))
The hyperplane array being 2d instead of 1d in the sparse case.
I've just added the if statement to test for sparse that I see elsewhere in the code:
            if self._is_sparse:
                self._init_sparse_search_function()
            else:
                self._init_search_function()

So that it will choose a code path designed for sparse data.
This seems to fix the problem with pickling and unpickling.

Wow, great analysis and great catch! I should probably add sparse data to the pickle/unpickle tests so that we can catch this if it breaks again for some reason in the future. Thanks so much for digging in and fixing this.

Thanks.
I just realised I made a mistake and my commit didn't contain the test in setstate (as well as getstate) so unpickle will still fail.
The full fix is in #119


Mccalluc/remove react pins

What is the advantage in/why are we making the requirements on these packages less-stringent than they were before?

@ilan-gold : With that motivation explained, is this good? Can't remember if this branch had other problems...

yes, all good!


Add dark/light mode

Added a dark and light mode, avoided FOUC, used Tailwind and CSS vars().
This might not be the cleanest implementation but as far as I can tell this works and will result in cleaner styling going forward. My biggest criticism of this would be the use of invert on the code blocks and the orama search. I tried to avoid that but I couldn't see any way around flashing some styles in some edge cases when trying to use the markdown and orama theme options.
Closes #817

Thanks for getting the ball rolling on this! Just checked out the branch locally and it looks great!
The only thing

@davis9001 Thanks for all of this! Just noting that we're going to chat about this at our docs design meeting later this week and figure out how we want to move forward. Some of the things we'll want to figure out are whether additional colors should be added to our palette to help with the dark mode styles and how we want to handle the use of color inversion (like should we wait to release until we come up with manually selected dark mode colors).

The only thing I'd change is to keep the blue links. We don't have yellow anywhere in our color scheme. Same for the code blocks.

Excellent point! I added to the pull request to fix the links in the markdown blocks. I haven't fixed the code blocks yet, I think the best long term solution for that would be to override the styling coming from gfm.css.

Some of the things we'll want to figure out are whether additional colors should be added to our palette to help with the dark mode styles and how we want to handle the use of color inversion (like should we wait to release until we come up with manually selected dark mode colors).

Makes sense! In any case I would definitely recommend having a well documented style guide that includes both light and dark theme color schemes. Do let me know if there is anything I can do to help!

Closing now that #1038 was merged 🥳


UVI Request

--- UVI JSON ---
{
  "vendor_name": "Linux",
  "product_name": "Kernel",
  "product_version": "versions from v2.6.35 to before v4.14.241",
  "vulnerability_type": "unspecified",
  "affected_component": "unspecified",
  "attack_vector": "unspecified",
  "impact": "unspecified",
  "credit": "",
  "references": [
    "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=bece7b2398d073d11b2e352405a3ecd3a1e39c60",
    "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=ffe31dd70b70a40cd6b21b78c1713a23e021843a"
  ],
  "extended_references": [
    {
      "type": "commit",
      "value": "bece7b2398d073d11b2e352405a3ecd3a1e39c60",
      "note": "introduced"
    },
    {
      "type": "commit",
      "value": "ffe31dd70b70a40cd6b21b78c1713a23e021843a",
      "note": "fixed"
    }
  ],
  "reporter": "joshbressers",
  "reporter_id": 1692786,
  "notes": "",
  "description": "net: fix uninit-value in caif_seqpkt_sendmsg\n\nThis is an automated ID intended to aid in discovery of potential security vulnerabilities. The actual impact and attack plausibility have not yet been proven.\nThis ID is fixed in Linux Kernel version v4.14.241 by commit ffe31dd70b70a40cd6b21b78c1713a23e021843a, it was introduced in version v2.6.35 by commit bece7b2398d073d11b2e352405a3ecd3a1e39c60. For more details please see the references link."
}
--- UVI JSON ---

This issue has been assigned UVI-2021-1001404


IntelliSense doesn't recognise PHP snippets inside HTML blocks

VSCode Version: 1.43.2
OS Version: Windows 10

Steps to Reproduce:

Create php snippet with "scope": "php,html"
Enter the trigger word inside a HTML block

Does this issue occur when all extensions are disabled?: Yes

Please share the snippet, the html-file, the position at which you have tried, and how you have tried this

I think I worked round this, I'm new to VSCode so learning/working my way through it.
If I want to create a commonly used code snippet that includes PHP tags like:
<?php include 'header.php'; ?>
Then I need to put the snippet inside my html.json snippets file and intellisense will show it when cursor is inside a html block/code.
The alternative snippet for PHP blocks would be to add the following to my php.json:
 include 'header.php';
I'm assuming that this behaviour is deliberate in VSCode ... Thanks for coming back to me.

Yes - that's how it work.


[Compile] Add pluginRepository for java-cup-plugins

Proposed changes
the cup-maven-plugin of net.sourceforge.czt.dev is missing in maven central repo.
It has been moved to https://repository.cloudera.com/content/groups/public/
Fix #4637
Types of changes

[x] Bugfix (non-breaking change which fixes an issue)

The same issue with released version 0.12.0. I had add the following in the fe/pom.xml file to get fe compiled successfully.
              <!-- for cup-maven-plugin -->                 <pluginRepository>                     <id>cloudera-plugins</id>                     <url>https://repository.cloudera.com/content/groups/public/</url>                 </pluginRepository>

this also cannot resolve the problem, replace https://repository.cloudera.com/content/groups/public/ with  https://repository.cloudera.com/artifactory/cloudera-repos/ , then it worked

I've found this package in: https://repository.cloudera.com/artifactory/ext-release-local/net/sourceforge/czt/dev/cup-maven-plugin/1.6-cdh/cup-maven-plugin-1.6-cdh.jar , and I put it in my .m2 dir.
then it worked.

I've found this package in: https://repository.cloudera.com/artifactory/ext-release-local/net/sourceforge/czt/dev/cup-maven-plugin/1.6-cdh/cup-maven-plugin-1.6-cdh.jar , and I put it in my .m2 dir.
then it worked.

You can just use fe/pom.xml in trunk to replace your local repo file, and it will work.

I've found this package in: https://repository.cloudera.com/artifactory/ext-release-local/net/sourceforge/czt/dev/cup-maven-plugin/1.6-cdh/cup-maven-plugin-1.6-cdh.jar , and I put it in my .m2 dir.
then it worked.

You can just use fe/pom.xml in trunk to replace your local repo file, and it will work.

:thumbsup: My code base is 0.13.0 and it work with you suggestion.


php --ini has unexpected output when built with xml extension

Describe the bug
A clear and concise description of what the bug is.
I noticed a warning with our new php build that I was hoping we might be able to dig into.
To Reproduce
Steps to reproduce the behavior:

build php.withExtensions ({ all, enabled }: with all; [ bcmath ctype fileinfo json mbstring openssl pdo pdo_mysql tokenizer xml ])
run php binary built from above expression: /nix/store/zrbqc3i9fbi2znb0sb23p2j7j2xad1lh-php-with-extensions-7.4.6/bin/php --ini

UNexpected behavior
A clear and concise description of what you didn't expect to happen.
PHP Warning:  Module 'xml' already loaded in Unknown on line 0
Configuration File (php.ini) Path: /nix/store/mzd7225qpg6m005fqnlhd5b97yg07dpi-php-7.4.6/lib
Loaded Configuration File:         (none)
Scan for additional .ini files in: /nix/store/zrbqc3i9fbi2znb0sb23p2j7j2xad1lh-php-with-extensions-7.4.6/lib
Additional .ini files parsed:      /nix/store/zrbqc3i9fbi2znb0sb23p2j7j2xad1lh-php-with-extensions-7.4.6/lib/php.ini

Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
Add any other context about the problem here.
Notify maintainers

ping @etu @talyz
Metadata
Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.
Running on a recent copy of master.
Maintainer information:
# a list of nixpkgs attributes affected by the problem
attribute: php
# a list of nixos modules affected by the problem
module:

The xml extensions is one of very few that we actually have enabled by default in the minimal build.

Ah, OK. Should we document that, issue a warning when something has been added multiple times, or filter out duplicates internally, etc... Thoughts?

Shouldn't we make sure that this doesn't happen in the first place?

"filter out duplicates internally" would accomplish that. What did you have in mind?

We could remove php.extensions.xml

I understand that we want to keep it as separate package as well. But I mean, why not filtering already loaded extensions during eval or build?

@Ma27 Well, mainly because it doesn't really have a way of knowing what extensions are built into PHP right now - we would need to expose that from the PHP derivation somehow, but it's probably not worth the effort, since this only is a warning and can be easily solved by disabling the xml extension until we can build PHP without it.

@talyz what would it take for us to compile without? Are there any major obstacles?

We have two problems to compile without XML:

pearSupport requires XML

And even if we were to ditch pearSupport by default (who uses that?), we ran into:
2) It seems like mysql, but worse, needs patching, and not sure how much or little patching.

I'm still interested in coming back to this at some point so I'll mention now to remove the stale marker.


Finalize the interface of the Fixtures struct

[closes #163]
In the process of making the APIServer constructor take 0 arguments (#162), we naturally find ourselves making the Fixtures constructor take 0 arguments (#163).
We'll be cleaning things up even more as we continue to work on #162, but this seems like a reasonable mid-point where there's already some user-value. In particular, the main interface to the test framework (The Fixtures constructor and methods) ought to be stable now:
myFixtures, err := test.NewFixtures()
err = myFixtures.Start()
myServerURL = myFixtures.APIServerURL()
// Run tests using myServerURL
err = myFixtures.Stop()

Cc @hoegaarden @apelisse

/assign @apelisse


Fix typo in the redirect after training a custom model

Pull Request Test Coverage Report for Build 1740

0 of 1 (0.0%)  changed or added relevant line in 1 file are covered.
3 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-0.03%) to 66.808%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

routes/luinet_models.js
0
1
0.0%

Files with Coverage Reduction
New Missed Lines
%

routes/my_conversation.js
1
62.83%

model/entity.js
2
65.71%

Totals

Change from base Build 1735:
-0.03%

Covered Lines:
6757

Relevant Lines:
9516

💛  - Coveralls


scheduling based on day

e.g. different schedule on Monday, Tuesday etc

yes, please, this would be very cool! (also thinking about different programming on weekends)

I'd love this feature.

Planning for a new block scheduling feature (including day templates) has started. If anyone has specific scheduling needs please hop in the discord #block-scheduling channel and let me know.

This is already implemented, right? Probably should close?


An error occurred while logout

When I logout WeChat, the following error will be reported, causing the logout event to fail to trigger.
Manual WeChat Logout

Call Logout Api

I submitted a small fix to improve the logout logic, please verify this issue still happened for the new version v0.9.27. If not, please close this issue :)


support arm64 architecture

I was use this image build on arm64 and successed , So I think it can be support arm64 and we can add it to https://hub.docker.com/u/arm64v8/ .
See https://github.com/docker-library/official-images#architectures-other-than-amd64 and https://github.com/docker-library/official-images#multiple-architectures for more information about multi-architecture official images.

Note to self: look at https://github.com/docker-library/official-images/blob/master/library/php and apply to https://github.com/docker-library/official-images/blob/master/library/rakudo-star

@hoelzro I can help out as well (I help maintain https://github.com/Perl/docker-perl.)  This is probably as minimal as https://github.com/docker-library/official-images/blob/master/library/perl

I have no permission to modify the file of https://github.com/docker-library/official-images/blob/master/library/rakudo-star

@zakame That would be great!
@longquan7 You need to create your own fork, work in that, and then submit a PR.  If you do that, you can tag me and I'll help review the change.

@zakame OK,thanks

Just a reminder that JIT only works on amd64. Depending on the case this will result in a slower Rakudo in other platforms (including i386).


Corrupted store while bootstrapping a tezos node with hangzhounet

A corrupted store was obtained while boostrapping with hangzhounet  (available on comanche at /bench/ioana/corrupt_hnet/hangzhounet-backup.tgz) and it fails when validating block 643736 (https://hangzhounet.tzkt.io/BM8ZkiT9TVe7XZaEqUkJWZqCjT96TQSEzBYfgqsPug3xnX33eSt):
node_1                   | 2022-03-15T14:25:21.901850755Z Mar 15 14:25:21.902 - validator.block: Inconsistent hash:
node_1                   | 2022-03-15T14:25:21.901852606Z Mar 15 14:25:21.902 - validator.block:   got: CoUviMZNKiSiqH8kyKtPqCXF217ckVScGdbvovMhy4guFWfThRUk
node_1                   | 2022-03-15T14:25:21.901854390Z Mar 15 14:25:21.902 - validator.block:   expected: CoWGVAvBtcjkqzLrhT1XFiQ1uq6scD1396mv9CiBG1wD1ETzrXRg

I reproduced the error twice, the procedure seems to be:
1/ launch a bootstrap with hanghzhounet and the patch below to stop the validation at block 643735
2/ stop the node when it stops validating blocks
3/ modify the patch to validate two more blocks
4/ relaunch the node - it will validate one block successfully (the  643735) and then raise the inconsistent hash error for  block 643736.
Debug logs for step 4 are available at /bench/ioana/corrupt_hnet/logs_after_35. A “correct” stores containing 643736 and not corrupted is available at /bench/ioana/corrupt_hnet/correct_minimal.tar.gz.
The patch to stop the validation at level 42:
diff --git a/src/lib_validation/block_validation.ml b/src/lib_validation/block_validation.ml
index 15ad14d60e..4af7c84738 100644
--- a/src/lib_validation/block_validation.ml
+++ b/src/lib_validation/block_validation.ml
@@ -377,6 +377,10 @@ module Make (Proto : Registered_protocol.T) = struct
       ~predecessor_context ~(block_header : Block_header.t) operations =
     let open Lwt_tzresult_syntax in
     let block_hash = Block_header.hash block_header in
+    let level_to_stop = 42l in
+    if block_header.shell.level = level_to_stop then (
+      Format.printf "Stopping the node at level<EMAIL_ADDRESS>level_to_stop ;
+      assert false) ;
     match cached_result with
     | Some (({result; _} as cached_result), context)
       when Context_hash.equal

@icristescu I'm guessing this can be closed (?) Re-open if not!


Remove non-contributory reason

Remove the non-contributory reason "VUS/LB/B claim when a mutually exclusive disease association is P/LP" from reason list

@dazzariti What should I do with the 20 curations that have the Non-Contributory reason VUS/LB/B claim when a mutually exclusive disease association is P/LP?   Should these be translated to the only remaining Unnecessary conflicting submissions reason Unnecessary VUS/LB/B claim for distinct condition when other interpretations are pathogenic?


Update decoder.ts

Lemme know when it's final and ready for merge @BusinessDuck

I have tested this, all looks good


Fix KeyError by Correcting Key Name in Dataset Loading Process

Description
This pull request addresses issue an issue, where the key name used to access label names in the dataset loading process was incorrect. The key 'lac' has been replaced with the correct key 'label' to ensure proper retrieval of label names.
Motivation and Context:
The motivation behind this change is to rectify the KeyError that occurs during the dataset loading process due to the incorrect key name usage. By replacing the key with the correct one, we ensure that the code functions as intended and retrieves the label names successfully.
Type of change

Bug fix (non-breaking change which fixes an issue)

Dependencies:
No new dependencies are introduced by this change.
How Has This Been Tested:

[x] Ran the updated code with the fix applied.
[x] Verified that the KeyError no longer occurs during the dataset loading process.
[x] Ensured that label names are retrieved correctly.
[x] Ran unit tests to verify the correctness of the fix.

Instructions for Testing:

Pull the latest changes from the repository.
Apply this pull request to your local environment.
Run the dataset loading process.
Verify that the process completes without encountering KeyError.
Check that label names are retrieved correctly.

Checklist

[x] I have read the contributing guidelines
[ ] I have updated the HISTORY.rst and AUTHORS.rst files
[ ] Linting passes successfully : make lint
[ ] Typing passes successfully : make type-check
[ ] Unit tests pass successfully : make tests
[ ] Coverage is 100% : make coverage
[ ] Documentation builds successfully : make doc

Hey @mohliyet,
Thank you for this PR! For the moment it doesn't pass some tests, but we have fixed the issue. So you can git merge upstream/main and everything should work!
Thank you!

Hello @mohliyet, are you still working on that PR?
Happy to help.
Cheers,


Added Dance Page using YouTube API

Description

Added Dance Page getting videos from YouTube API
Its completely responsive too

Fixes Issue #36
Checklist

[x] I am making a proper pull request, not a spam.
[x] I've checked the issue list before deciding what to submit.

screenshots

Awesome @ShwetKhatri2001

It is ready to be merged ? or anything else required ?

LGTM @ShwetKhatri2001


video not play if not make it to tiny window

I try in recyclerview
when I click to play, It just loading but not play video
but when I scroll down, video become to tiny window and video play instantly
how to fix this
this is my code in onBindViewHolder
viewHolder.video.setUp(video_url,JZVideoPlayerStandard.SCREEN_WINDOW_NORMAL,"");           Glide.with(viewHolder.video.getContext()).load(picture_url).into(((ViewHolder2)holder).video.thumbImageView);

ok , solved by fix height 200dp on videoplayer
at first I use wrap_content

good


add job.Arg() to get arg directly

@sillydong I'm curious about the use-case here? Why would you want an interface{} version of the argument instead of using the typed arg extractors?

I found that the Args[] is accessable from outside, sorry for the inconvenience.


v1 Refactor

Issue to track/discuss upcoming features/changes.

[ ] Allow controlling parent/child mapping (in case it doesn't quite correlate with dom output - eg. imagine a contextual menu being mounted through a portal)
[ ] Higher order component api
[ ] Allow bubbling of event/hotkeys https://github.com/chrisui/react-hotkeys/issues/52

[ ] Explore "hotkey event" api as discussed in https://github.com/Chrisui/react-hotkeys/issues/20

[ ] Tests
[ ] Explore possible single mousetrap/dom binding - https://github.com/chrisui/react-hotkeys/issues/2
[ ] Expose Mousetrap reference (ie. import {Mousetrap} from 'react-hotkeys';)
[ ] Investigate binding (inputs?) issues https://github.com/chrisui/react-hotkeys/issues/51

Potentially provide first class support for initial focus state?
See: https://github.com/Chrisui/react-hotkeys/issues/25

@chrisui In my project, I'm already working on an HOC API wrapper around this project that I may be able to port over to this project. However, without PR #40 (or at least allowing the wrapping div to be styled), it has some issues.
The working prototype I have provides

@registerKeyMap class decorator that takes in a keyMap argument, and wraps the class's render method in a  component
@keydownHandler method decorator that takes in a string command argument. It then wraps the class's render method with a  method with a map of all decorated methods in the class.

However, I want to be sure this project is still open to development before spending effort porting my prototype to this project.

 First priority has been getting everything updated (a lot has changed in 2 years!) and ensuring we have a robust way of testing the hotkey events so we can have good coverage. Still working on that latter part but hopefully have something to show soon!

Closing to track the issues individually - milestones are now being used to group issues.


Added NetworkBehaviour OnEnableClient() & OnDisableClient()

This PR adds an simple OnEnableClient() and an OnDisableClient() method for the NetworkBehaviour.
Will be called if the NetworkBehaviour gets "visible" or "hidden" on the client or host.
If an InterestManagement is used, this callbacks will also be called if the NetworkBehaviour gets visible or hidden on the client/host.
OnDisableClient() will also be called when the object gets destroyed on the server and is visible to an client or the host

A little bit late but also added OnEnableServer() & OnDisableServer() if someone is interested in it.
OnEnableServer()
Like OnEnable(), called on server and host - will be called if the object becomes visible to atleast 1 client and was hidden (Disabled) before
OnDisableServer()
Like OnEnable(), called on server and host - will be called if the object gets hidden and no one can see it anymore or if the object gets destroyed and the object is visible to atleast 1 client

This is actually very helpful to understand if it's possible to send NetworkServer.send and if the client will be able to register it in time

I don't really see the value in this over OnStartClient / OnStopClient overrides where you can set your own flags to suit your purposes.

Main purpose was to use this in some scenarios where this server is also an player (host).
OnStartClient / OnStopClient is only called once for the host.
Example:
Lets say you want to call something for the Player when the NetworkBehaviour gets visible to the player.
And OnEnableServer/OnDisableServer just some extra features that gets called when Object is completly hidden to all players or when it becomes visible to atleast 1 player.
Example:
You only want to do something with the Object on the Server when its visible to atleast 1 player.
All these things can solved in other ways.. correct, this are only functions/callbacks that can easier be used.
Saved me a lot of time in some projects.

closing because 2 years old and see mrg's comment above


Remove cfe_es_devsrvr code

cfe_es_devsrvr.c and .h appear to be stale/obsolete and not being called or referenced by anything else in cFE.
Furthermore, it should be deprecated anyway since device-support code logically fits better within the PSP.  At the cFE layer it should be all hardware-independent code.
If this is correct, these two files should be removed from the build.

Imported from trac issue 16.  Created by jphickey on 2015-01-02T14:53:13, last modified: 2019-03-05T14:57:55

Trac comment by jphickey on 2015-04-06 11:37:49:
This is ready for review/merge

Trac comment by jphickey on 2015-01-26 14:56:09:
Branch "trac-16-remove_devsvr_code" pushed for this -- Commit [changeset:13569c321]

Removes unused API calls CFE_ES_RegisterDriver() and CFE_ES_UnloadDriver().  These only returned "CFE_ES_NOT_IMPLEMENTED".
Removed cfe_es_devsvr.c and cfe_es_devsvr.h.  These two files were not even being built.

It does not make much sense to have device driver load/unload functions within the CFE.  Device drivers fit more logically as component of the PSP.
See [https://babelfish.arc.nasa.gov/trac/cfs_psp/ticket/3] for a proposal on an easy way to do this as part of the PSP.

Trac comment by acudmore on 2015-04-07 08:58:32:
We were keeping this in the cFE source tree, hoping to finish it one day. We certainly have this code in CM and old release tar files if we ever want to get it back.
I agree that we should remove it until we decide what to do. It is worth taking a fresh look at the device model before trying to implement it. The PSP location is a good thought too.
Recommend accept.

Trac comment by jphickey on 2015-04-07 09:52:13:
I think a device model (in general) is a very necessary thing in order to keep device access consistent and sane particularly if we are looking at promoting app sharing/re-use.
FYI - CCSDS SOIS has a proposed reference architecture for dealing with devices.  This architecture describes both an application level and a platform level abstraction.  I think whatever we do in cFE should at least be compatible with what SOIS has defined.  The PSP would serve as the platform level abstraction and I think the application level abstraction could be done as a separate CFS application.

Trac comment by glimes on 2015-04-07 12:53:34:
Tested changeset [changeset:13569c3] as part of the ic-2015-03-10 merge.

Trac comment by glimes on 2016-02-25 10:17:32:
these will be fixed in CFE 6.5

Trac comment by glimes on 2015-04-13 15:20:15:
Part of integration candidate 2015-03-10,
committed to cFS CFE Development branch on 2015-04-10
as part of merge [changeset:7d6f6d0].

Trac comment by jhageman on 2019-03-05 14:57:55:
Milestone renamed


Use isNull for matching JNull in Decoder

This is another tiny optimization that came up during profiling. Because Json's == delegates to the Eq instance, pattern matching on JNull calls Json.eqJson.eqv, which is much slower than isNull.
This is probably negligible 99.99% of the time, but since the alternative here isn't any less readable I figured we might as well do it.

Current coverage is 81.75% (diff: 100%)

Merging #465 into master will increase coverage by 0.13%

@@             master       #465   diff @@
==========================================
  Files            80         80
  Lines          2149       2149
  Methods        2052       2045     -7
  Messages          0          0
  Branches         97        104     +7
==========================================
+ Hits           1754       1757     +3
+ Misses          395        392     -3
  Partials          0          0

Powered by Codecov. Last update 8b5c238...f840827


Adding test to compare output of csg_reupdate

Part of votca/votca#71

Good point, let me shrink that a bit!

@JensWehner: Done


Multiple Banner?

Hi there
since there is already an option to show (or not show) the banner on some pages, is it possible to extend the thought towards having more than one banner at hand? So you can show banner1 on page1 and banner2 on page2-10 but not on page1.
For instance you could link the banner to a related youtube channel while writing about your vacations and link it to the instagram page while talking about your camera equipment.
Yes, you COULD do that inline in the firstplace ... but maybe you can do it with some more style, too :D

Thinking "out-loud":

We could take the configuration options and put them in an list which we iterate over in the back-end.
We probably want it to be possible to display multiple banners on each page, so the CSS will need looking at to ensure this looks nice.
We'd have to ensure that the cookie that stores the dismiss behaviour stores this preference for each banner, which will mean each banner needs a unique identifier. We may be able to use the Unique ID field for this.

Good suggestion, thanks - I'll give it a go!

Converting the existing options into a list would be a breaking change to the plugin config and would mean a config migration would be required when the plugin was updated. Instead we could simply add a list config option as well for additional banners, with our existing config being treated as the first item in the list.
Another potentially desirable addition would be to allow banners to be defined in a pages YAML frontmatter so that they could be added to individual pages this way rather than throught he plugin config.

Maybe use the plugin as a mere "layout" for a template or module or thelike and just add the actual content right on the site.
But this would be more complicate for rather big installations with loads of pages ... everyone of them where you want a banner has to have the code included, right? so you can't just tell the banner "Oh, yeah, show yourself on pages 1-100, 122 and 153-158"
That would not be a problem for myself as my Grav installation will never exceed 20 pages at most I guess XD
But we're thinking for more people, right? ;)
I am technical-wise a noob and cannot tell anything about the realisation of this ... I can only throw ideas, sry ;)


Bot not responding on Livechat

Hi, congrats for your nice work.
In my tests Watson bot responds on Livechat only if you put the bot name as the first word.
I need the bot to respond even if his name is not in the phrase, like an normal DM.
Is there any configuration I am missing?
Using RESPOND_TO_DM=true works on DMs but not on Livechat.
➔ +---------------------------------------------------------+
➔ | SERVER RUNNING |
➔ +---------------------------------------------------------+
➔ | |
➔ | Rocket.Chat Version: 0.53.0 |
➔ | NodeJS Version: 4.8.0 - x64 |
➔ | Platform: linux |
➔ | ReplicaSet OpLog: Disabled |
➔ | Commit Hash: cbdc26d |
➔ | Commit Branch: HEAD |
➔ | |
➔ +---------------------------------------------------------+

I ran into this issue too, addingRESPOND_TO_LIVECHAT=true did the trick


DatChecker needs update

DatOutput is changed, it causes Test build and Torxakis build checks to fail.
DatChecker should be updated as necessary.

Observed at #97


Remove web from the Module

In this PR we remove the codebase of the Spine Web module. Removed modules:

web;
firebase-web;
client-js;
client-js-proto;
web-tests.

Also, in this PR we migrate this repository to the latest Spine:

added config submodule and updated dependencies according to definitions in config;
removed final from local variables;
migrated to Java 8 API where possible;
migrated to JUnit 5 API and code conventions.

@armiol, PTAL.


Fix SwiftLint errors with the latest version

:pushpin: References

Issue: None
Related pull-requests: None

:tophat: What is the goal?
The latest version of SwiftLint (0.17.0) introduce a breaking change with rule variable_name.
How is it being implemented?
Ignore the rule so the project can compile.

Thanks @dagio for catching the issue👍👍👍
IMO, it's good to update .swiftlint.yml to disable the lint to keep our source code cleaner. Would you disable variable_name in .swiftlint.yml❓

It depends what strategy Swinject wants to adopt regarding new rules in general. This PR just make sure at least it can build.

I would prefer the approach of disabling the rule for specific identifiers - disabling it for the entire project would imo be like saying "we do not care about identifier names at all".

I'm sorry that I took 10 days to come back. Let me just check whether SwiftLint has a way to disable a rule for specific identifiers. If it doesn't have it (and probably), I'll merge this pull request👍

Thanks @dagio for your pull request and @jakubvano for your idea👍 I checked some projects using SwiftLint, and disabling some exceptional cases works very well. Sorry, @dagio, for taking time to merge your pull request😔


Assistance with Metrc APIs

Hi,
Not an issue but there's no way to DM users on github.
Would you be willing to help me with a few questions about Metrc API?
Thanks!

Hey @vonschnappi, you can either post the questions here or email them to<EMAIL_ADDRESS>Thanks for reaching out!

Hi @Alchez!
Thanks for posting back. I finally made it with the help of Metrc support.
Thanks again for being willing to help.


Response for 'bye'

Currently Jarvis responds with-
"I'm sorry; I'm not sure I understand what you're trying to say sir.
Try typing "help" or "request" for a "bye"
It should have a better system to deal with keywords such "bye" ,"thanks you" etc

Agreed, this module is planned.
You are welcome to contribute as well! :smile:

I implemented a simple bye module and have created a pull request.

#97


New entry does not save

Upon adding a new entry, closing the program, and reopening the program, the entry is not saved.

Version 0.90.63

New entry will not be saved until you configure both From key and To key.

I know, I did that, but with my other keyboard.
On the builtin keyboard I can't reproduce it.


returned data should not be at the top-level or the json response

I know this could be easily dismissed as "a matter of taste", but I just wanted to mention that returning the model data at the top level of the json document hierarchy is considered a bit of an antipattern and something that I see other open source codebases moving away from.
I don't remember where I last saw this matter discussed but a quick 1 minute google search I was able to find a couple of guidelines around which corroborate this approach:
https://google.github.io/styleguide/jsoncstyleguide.xml?showone=data#data
and also:
http://jsonapi.org/format/#document-top-level

I'm really appreciating your participation. Thank you very much. 😊
Just to justify my decision to send the actual data on the top level, I became to ponder on this in the past, but I came to the conclusion that the vast majority of the metadata which I would send along the response I should do via HTTP headers (if there's not a native header for that, I should send some X-Custom-Header instead). So it became pointless to envelop the response.
Another reason is to make things simpler and let the user (the developer who uses the generator) decides the better approach. As this project greatly implements separation of concerns, it should be easy to implement by just changing the services/response module. :)

This project is heavily influenced by this post: http://www.vinaysahni.com/best-practices-for-a-pragmatic-restful-api
It talks about enveloping responses here


Can't fetch token

Hi!
I'm trying to fetch token from google api, but the link provided by plexdrive is always saying "Error: invalid_request" in my browser.
Could anyone help me please?
Thanks!

I added my client_Id and client_secret in config.json and now I can fetch my token.
Regards