dfget pull images always from the remote registry.

Ⅰ. Issue Description
Deployed dragonfly in a containerd cluster using KinD, and dfget pull images always from the remote registry.
Ⅱ. Describe what happened
dfget pull images always from the remote registry.
Ⅲ. Describe what you expected to happen
dfget pulls image from peers if the image has already been pulled by others and not expired.
Ⅳ. How to reproduce it (as minimally and precisely as possible)
Prepare enviroment:
docker build -t stargz-kind-node https://github.com/containerd/stargz-snapshotter.git
cat >multinode.yml <<EOF
kind: Cluster
apiVersion: kind.x-k8s.io/v1alpha4
nodes:
- role: control-plane
- role: worker
- role: worker
EOF
kind create cluster --name stargz-demo --config multinode.yml --image stargz-kind-node --retain
kubectl --context  stargz-demo create ns dragonfly
kubectl --context  stargz-demo -n dragonfly apply supernode.yml dfclient.yml

kubectl --context  stargz-demo exec -it stargz-demo-worker
# within worker container
cat >>/etc/containerd/config.toml <<'EOF'
# See also: https://github.com/containerd/cri/blob/master/docs/registry.md
[plugins."io.containerd.grpc.v1.cri".registry.mirrors]
  [plugins."io.containerd.grpc.v1.cri".registry.mirrors."docker.io"]
    endpoint = ["http://<IP_ADDRESS>:30081"]
EOF
cat >>/etc/containerd-stargz-grpc/config.toml <<'EOF'
[[resolver.host."docker.io".mirrors]]
  host = "http://<IP_ADDRESS>:30081"
EOF
systemctl restart stargz-snapshotter
systemctl restart containerd

kubectl  --context  stargz-demo exec -it stargz-demo-worker2
# within worker2 container
cat >>/etc/containerd/config.toml <<'EOF'
# See also: https://github.com/containerd/cri/blob/master/docs/registry.md
[plugins."io.containerd.grpc.v1.cri".registry.mirrors]
  [plugins."io.containerd.grpc.v1.cri".registry.mirrors."docker.io"]
    endpoint = ["http://<IP_ADDRESS>:30081"]
EOF
cat >>/etc/containerd-stargz-grpc/config.toml <<'EOF'
[[resolver.host."docker.io".mirrors]]
  host = "http://<IP_ADDRESS>:30081"
EOF
systemctl restart stargz-snapshotter
systemctl restart containerd

Now crictl pull docker.io/library/alpine:3.9 on different worker node one by one. dfdaemon's log will show that dfget download from dockerhub every time it crictl pull
Ⅴ. Anything else we need to know?
Ⅵ. Environment:
dragonfly version
supernode version  1.0.0
Git commit:     ac262d5
Build date:     20191119-17:45:07
Go version:     go1.12.10
OS/Arch:        linux/amd64
dfdaemon version  1.0.0
Git commit:     ac262d5
Build date:     20191119-17:44:51
Go version:     go1.12.10
OS/Arch:        linux/amd64

OS (e.g. from /etc/os-release):

host:
NAME="CentOS Linux"
VERSION="7 (Core)"
ID="centos"
ID_LIKE="rhel fedora"
VERSION_ID="7"
PRETTY_NAME="CentOS Linux 7 (Core)"
ANSI_COLOR="0;31"
CPE_NAME="cpe:/o:centos:centos:7"
HOME_URL="https://www.centos.org/"
BUG_REPORT_URL="https://bugs.centos.org/"
CENTOS_MANTISBT_PROJECT="CentOS-7"
CENTOS_MANTISBT_PROJECT_VERSION="7"
REDHAT_SUPPORT_PRODUCT="centos"
REDHAT_SUPPORT_PRODUCT_VERSION="7"
container:
NAME="Alpine Linux"
ID=alpine
VERSION_ID=3.8.4
PRETTY_NAME="Alpine Linux v3.8"
HOME_URL="http://alpinelinux.org"
BUG_REPORT_URL="http://bugs.alpinelinux.org"

Kernel (e.g. uname -a):
Linux instance-aai99beh 3.10.0-1062.18.1.el7.x86_64 #1 SMP Tue Mar 17 23:49:17 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Install tools:
kind v0.8.0 go1.13.6 linux/amd64

Others:

dfdaemon will trigger a dfget download task when accepted a pull request. Dragonfly has a plan to make the dfget can download the data from source server directly, but for now it never download from dockerhub directly, it will download from supernode or other peers which have the data.

@lowzj Sure, that is the expected case, but after first crictl pull, at least one dfget or supernode got the image, now dfget should download from peer or supernode, but it didn't. You can see this from dfdaemon's log, worker1 download blob 4780acaf at 01:24:41.022, within less one minute, worker2 donwload the same blob from dockerhub again.
worker1
2020-05-11 01:24:39.473 INFO sign:1 : start download url:https://index.docker.io/v2/library/golang/blobs/sha256:4780acafd98c2f2b2139f70862bf40ecb6c3a84abd2afa853260460edb3fc112 to abc51efa-a17f-4624-adf7-06805c228a7e in repo
2020-05-11 01:24:39.488 INFO sign:1 : start download url:https://index.docker.io/v2/library/golang/blobs/sha256:fbf24695ef9896635c70eaf51fb67c6cc91f306a893b30ab38a29d4dd131c4c9 to c229472b-7c42-4769-a08b-d29aceccda4f in repo
2020-05-11 01:24:41.022 INFO sign:1 : dfget url:https://index.docker.io/v2/library/golang/blobs/sha256:4780acafd98c2f2b2139f70862bf40ecb6c3a84abd2afa853260460edb3fc112 [SUCCESS] cost:1.550s
2020-05-11 01:24:54.097 INFO sign:1 : dfget url:https://index.docker.io/v2/library/golang/blobs/sha256:fbf24695ef9896635c70eaf51fb67c6cc91f306a893b30ab38a29d4dd131c4c9 [SUCCESS] cost:14.608s

worker2
2020-05-11 01:25:13.259 INFO sign:1 : start download url:https://index.docker.io/v2/library/golang/blobs/sha256:4780acafd98c2f2b2139f70862bf40ecb6c3a84abd2afa853260460edb3fc112 to 831d1209-eba8-4948-ba98-1c2e3f2bb8ad in repo
2020-05-11 01:25:13.266 INFO sign:1 : start download url:https://index.docker.io/v2/library/golang/blobs/sha256:38b1453721cb272cf531587daa8f79cc38641a9750dc269d7f2f08feb80f6602 to 2a982fab-ea6b-4425-958a-d72dd3185108 in repo
2020-05-11 01:25:13.359 INFO sign:1 : dfget url:https://index.docker.io/v2/library/golang/blobs/sha256:4780acafd98c2f2b2139f70862bf40ecb6c3a84abd2afa853260460edb3fc112 [SUCCESS] cost:0.100s
2020-05-11 01:25:15.816 INFO sign:1 : scan repo and clean expired files
2020-05-11 01:25:19.168 INFO sign:1 : dfget url:https://index.docker.io/v2/library/golang/blobs/sha256:38b1453721cb272cf531587daa8f79cc38641a9750dc269d7f2f08feb80f6602 [SUCCESS] cost:5.902s

These logs in dfdaemon.log don't mean that dfget downloads blobs from remote dockerhub, it just means that a download task starts. Only supernode downloads data from dockerhub, caches it and sends it to dfget when no other dfget has the same data.
You can see the cost time of worker2 is much less than the worker1 because that supernode has downloaded the data after first pulling on worker1.
The detailed download task logs are in dfclient.log: https://github.com/dragonflyoss/Dragonfly/blob/master/FAQ.md#how-to-view-all-the-dfget-logs-of-a-task


ban access to system paths on shared hosting

Hi,
Isn't it possible that some shared hosting ban access to these system paths or these files will be always accessible?
https://github.com/guzzle/guzzle/blob/master/src/functions.php#L160

Good question. Is there an actual error that you met?

Isn't cURL able to find default system path without this way? It seems it can. So why are you using this way?

Actually it tries to find the CA automatically then falls back to the list. The exception bellow contains information about the problem:
https://github.com/guzzle/guzzle/blob/master/src/functions.php#L197
Alternatively you can download a common ca to your path and configure it.

I am still not sure about your problem without the exact error. You should also ask your provider whether they block access. Or you can just download a CA.

I want to use it in my product and give it away. So I will not know if end-user can use it I guess sharedhosting may block access to paths and end-users are not tech to define their own ca.
I think libcurl can find system default ca, without any need to method you fave the link? No?

Yes, cURL can do that and this method actually tries to find that CA first:
https://github.com/guzzle/guzzle/blob/master/src/functions.php#L183-L189
But it only works if the PHP ini is configured/default is not changed.
This method provides help in case it does not work for any reasons. I don't think shared hosting may block access to these files, but if they do, you really can't do anything (apart from turning verification completely off) since falling back to default does not help either.

I meant for example why not letting libcurl find  '/etc/pki/tls/certs/ca-bundle.crt' or other paths, rather than searching path by php? libcurl cannot find it itself?

Please read the exception message that I linked above. Also the process cannot access the file if the permissions do not allow that.


Make an async waiter for places where a botocore waiter is not available

There are several places where we need to keep checking for a particular response, and wait in between checks to avoid overloading the APIs.
We should abstract this into an async waiter that applies this pattern once.

Closing down project: #52


No matching distribution found for cv2 - Dockerfile

🐛 Bug Report

------
ERROR: Could not find a version that satisfies the requirement cv2 (from versions: none)
ERROR: No matching distribution found for cv2
failed to solve: rpc error: code = Unknown desc = executor failed running [/bin/sh -c pip install -r requirements.txt]: exit code: 1

hey @aryasoni98  assign this issue to me . !!!! happy to contribute in your project

The package name may be opencv-python instead of cv2.


SQLLAB - Postgres Error when column is not quotations

A clear and concise description of what the bug is.
Expected results
User should be able to write a query without having to wrap all columns in quotations marks.
SELECT
      DATE_TRUNC('week', year) AS __timestamp,
      SUM(NY_GNP_PCAP_CD) AS "(NY_GNP_PCAP_CD)"
FROM wb_health_population
GROUP BY DATE_TRUNC('week', year)
LIMIT 10000

Actual results
When writing a query to postgres and the column doesn't have quotation the user will receive the following error:
postgresql error: column "ny_gnp_pcap_cd" does not exist
LINE 5:       SUM(NY_GNP_PCAP_CD) AS "(NY_GNP_PCAP_CD)"
                  ^

SELECT
      DATE_TRUNC('week', year) AS __timestamp,
      SUM("NY_GNP_PCAP_CD") AS "(NY_GNP_PCAP_CD)" -- this works
FROM wb_health_population
GROUP BY DATE_TRUNC('week', year)
LIMIT 10000

Screenshots
If applicable, add screenshots to help explain your problem.
How to reproduce the bug

Go to 'sqllab'
Select a postgres database
Write a query with columns not wrapped in columns (see the example above)
See error

Environment
(please complete the following information):

superset version: superset version
python version: python --version
node.js version: node -v

Checklist
Make sure to follow these steps before submitting your issue - thank you!

[ ] I have checked the superset logs for python stacktraces and included it here as text if there are any.
[ ] I have reproduced the issue with at least the latest released version of superset.
[ ] I have checked the issue tracker for the same issue and I haven't found one similar.

Additional context
Add any other context about the problem here.

🏷 sql_lab

🏷 sql_lab

🏷 sql_lab:editor

This still seems to be the case these days. Adding a screenshot for good measure:

Closing this as stale since it's been silent for so long, and we're trying to steer toward a more actionable Issues backlog. If people are still encountering this in current versions (currently 3.x) please re-open this issue, open a new Issue with updated context, or raise a PR to address the problem. Thanks!


[Feature Request] Add mechanism to skip formatting specific comments

rustfmt usually leaves comments alone, but will edit comments when wrap_comments=true is enabled, Additionally rustfmt sometimes removes leading / trailing spaces. However, in some cases its desirable to prevent modifications for specific comments. The #[rustfmt::skip] attribute exists to prevent rustfmt from modifying annotated code, and although this will sometimes prevent comments from being modified it's not ideal because it also prevents the code from being formatted.
Related Issues where modifying comments isn't desirable:

#5725
#5440
#5638

If anyone has ideas for how this mechanism could work please comment them down bellow.

The only way I can think of for supporting this is something along the lines of what I mentioned in https://github.com/rust-lang/rustfmt/issues/5440#issuecomment-1183280504
Basically, we establish some kind of marker/keyword/magic phrase/whatever that rustfmt will recognize and support, and if found in the supported position (or positions, not sure) then rustfmt will do nothing.
I suggested rustfmt::avert-your-eyes somewhat cheekily, but the important part of the idea is the notion of a marker (e.g. similar to // @generated which we already support for different purposes) and can bikeshed on the actual ident of the marker later

My thoughts, for doc comments at least, is that the marker should be an HTML comment so it won't mess with rustdoc output.
We could define something like this:
const SKIP_DOC_COMMENT_MARKER: &'static str = "<!--- rustfmt::skip --->"

There's probably more scenarios that we'd need to think through, but I also wonder if we'd need to handle the case where users want to prevent rustfmt from modifying their markdown, but also want to continue formatting their code blocks. The way I've defined it in my proof of concept branch is to skip the doc comment entirely if the marker is present.

I don't have an opinion or preference one way or the other about the specifics of the marker approach. As long as it works and is practical in any and all comment types I'd be content

I'll think on this a little more. I like the idea of keeping with rustfmt::skip as the marker for consistency with attribute skips. If we eventually added a markdown parser for doc comments then the marker could still be rustfmt::skip, but we'd just check for an HTML comment with rustfmt::skip.


Multiple Application Support

Currently, support for adding multiple applications to the main application is being developed in the multiple-apps branch.
The concept of "multiple applications" is the same as the flask application itself. However, this application will be added to the main application and you can use the commands listed in the application, run it, etc.
But the problem is when you invoke another application's command with the "flask command" in the zemfrog project root directory, it won't work.
AFAIK, If you use the flask command, it will load the application in the current directory. So, this will load the main application not the sub-application :fearful:
I'm working on this feature right now, but I'm also open to any ideas!
Thanks :pray:

For now, one way to manage sub-applications is by using the FLASK_APP environment.
Example:
$ zemfrog create test-multiple-apps
$ cd test-multiple-apps
$ flask app new sub
$ export FLASK_APP=sub.wsgi
$ flask run

The multiple-apps branch is already merged into the master branch. But this issue remains open because I haven't found the best way to manage nested apps.


Review batchClaimEntries suspicious log

Seen in the field:
DBBackedQueue-notif-analytics_notifications: batchClaimEntries only claimed partial entries 100/98

Why can this still happen?

While I don't fully understand the issue, https://github.com/killbill/killbill-commons/pull/70 most likely works around it (get + claim done in one transaction).
Will close after verifying we don't see these anymore in production logs.


When I run the process.cs from cortexexamples.sln I am able to create a session. However, I keep getting the "EEG data received" message and the training never begins HELP?!

I am sure I am making a silly mistake thus i wanted to see if anyone else is running into the same problem and any fixes others used

@binaryboi10101 , which project you run from cortexexamples.sln ? may you are running example get eeg data.

@nguoithichkhampha I am running process.cs


Updates for 0.59.1 API

Updates for 0.59.1:

New encryption with TwoFish
Updates to Unknown25 and versions.
Update hashing server API url
Change CheckHasherVersion to allow non-forced API to be used.  Currently 0.57.4 is the forced API version, but we should still be allowed to use 0.59.1.
Update POGOProtos to 2.8.0

References:
https://github.com/Grover-c13/PokeGOAPI-Java/pull/898/files

Thanks 😃


remote ftp dosen't work for some file

I add a new file by romote-ftp in working host. it's done but when i try to upload changes to it, remote dosen't work. some time work for several file and dosen't work several. my remote-ftp is update.

Is it the same as this issue (which we are still having) https://github.com/icetee/remote-ftp/issues/1197


Add joystream network with prefix 126

AFAICT, we need to make a PR to parity from our own fork in order to get this reserved.
See issues 3389, 181 and 2531 for context.
In the former, @Lezek123 confirms we'll not only get a j but also 4 as an unintended bonus for j4 as prefix.

Changes look good, I suggest however to make a separate branch called joystream. I'll branch off main and re-target the PR.

FYI I have already "consumed" this version in carthage substarte v3 update successfully and confirm that it works as required:
$ ./target/release/joystream-node key generate -n joystream
Secret phrase:       super riot crater primary noise any fever globe squeeze twice control frequent
  Network ID:        joystream
  Secret seed:       0x110b82ec463742d3c3359e606c5877170815634de59e443bf5f9018ca48b788e
  Public key (hex):  0x9c429bf76640ef9234c018120009b1a75a7b48b98f4ccd4e97c5efc8fca2c07f
  Account ID:        0x9c429bf76640ef9234c018120009b1a75a7b48b98f4ccd4e97c5efc8fca2c07f
  Public key (SS58): j4UrVgcqi3o24nyafVuPPjXMHNRiaUYv24hTKF7RhabPwLBY6
  SS58 Address:      j4UrVgcqi3o24nyafVuPPjXMHNRiaUYv24hTKF7RhabPwLBY6


Testing CI

Signed-off-by: Hasan Turken<EMAIL_ADDRESS>
Description of your changes

Fixes #
I have:

[ ] Read and followed Crossplane's contribution process.
[ ] Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

/test-examples="examples/repository/repository.yaml"

/test-examples="examples/repository/repository.yaml"


Get tags by pagination

we use this action to tag multiple packages in a mono repo and it stopped working properly at it could not find all the tags.
This fixes that issue.

@gislikonrad can you please review this?


[Teams] Add descriptions to network logs

Add descriptions to network logs
Move selective logging to Activity logs
Tutorials cleanup

في الجمعة، 12 نوفمبر 2021 3:39 م abracchi-tw @.***> كتب:

Add descriptions to network logs
Move selective logging to Activity logs
Tutorials cleanup

You can view, comment on, or merge this pull request online at:
https://github.com/cloudflare/cloudflare-docs/pull/2686
Commit Summary

delete screenshot + network logs
https://github.com/cloudflare/cloudflare-docs/pull/2686/commits/496bd2f879c44f09f12ba3df8204a42be2b8fc38

File Changes
(21 files https://github.com/cloudflare/cloudflare-docs/pull/2686/files)

M products/cloudflare-one/src/content/analytics/gateway.md
https://github.com/cloudflare/cloudflare-docs/pull/2686/files#diff-0101ca0871f8af5e76902ff40b61f381b1fde3ab8c9f6cb47b9fb10b762bfbfb
(11)
M
products/cloudflare-one/src/content/analytics/logs/activity-log.md
https://github.com/cloudflare/cloudflare-docs/pull/2686/files#diff-88089febd011c090954d9720c3ffce5596a3c6409a027a9ed2f7655674f88861
(34)
D
products/cloudflare-one/src/content/static/documentation/logs/gateway-analytics-overview.png
https://github.com/cloudflare/cloudflare-docs/pull/2686/files#diff-4c0782d85b06191acef65a2ff890a3332c0b8872b561ec24692e7ddd1e52904d
(0)
D
products/cloudflare-one/src/content/static/secure-origin-connections/mongodb-tunnel/apps.png
https://github.com/cloudflare/cloudflare-docs/pull/2686/files#diff-761e9ed9ad8ab8d101d2128d36790b88dfd7cbad765a1a5f6f0c50db0ba8904d
(0)
D
products/cloudflare-one/src/content/static/secure-origin-connections/mongodb-tunnel/self-hosted.png
https://github.com/cloudflare/cloudflare-docs/pull/2686/files#diff-a0f892bfc48794a3b23a64fa66336cf4d674f46a35a7cf62579802277f0d8ab9
(0)
D
products/cloudflare-one/src/content/static/secure-origin-connections/share-new-site/applications.png
https://github.com/cloudflare/cloudflare-docs/pull/2686/files#diff-db5fe9331734310f8b7193963aa3d4809db24dc7ab92c810abfc4cc45e1affac
(0)
D
products/cloudflare-one/src/content/static/secure-origin-connections/share-new-site/self-hosted.png
https://github.com/cloudflare/cloudflare-docs/pull/2686/files#diff-0feb0af73b17754561a36c2b736b0e094c03fc702b713cc3895ccdc43dad2d2f
(0)
D
products/cloudflare-one/src/content/static/secure-web-gateway/block-football/block-espn-action.png
https://github.com/cloudflare/cloudflare-docs/pull/2686/files#diff-34e5088e369a5fb9e8c8b9c1200bafe4f0d3f938649e9eba7b8fee8d69f3f51d
(0)
D
products/cloudflare-one/src/content/static/secure-web-gateway/block-football/device-enrollment-settings.png
https://github.com/cloudflare/cloudflare-docs/pull/2686/files#diff-ebc11a0de6821e3ecad7cbc40fa1ac1b395249254ad08cae86bf77ecf107a02d
(0)
D
products/cloudflare-one/src/content/static/secure-web-gateway/block-football/expand-list.png
https://github.com/cloudflare/cloudflare-docs/pull/2686/files#diff-bc0e3d6903631a0206722df705dfd04143094c80a34c966defb04b05d9ff0a29
(0)
D
products/cloudflare-one/src/content/static/secure-web-gateway/block-football/policy-start.png
https://github.com/cloudflare/cloudflare-docs/pull/2686/files#diff-eb5fa70449fb1d9584092d959f600eb709acb6a82e95b837daa30100d0df31ac
(0)
D
products/cloudflare-one/src/content/static/secure-web-gateway/exempt-cert-pinning/starter-list.png
https://github.com/cloudflare/cloudflare-docs/pull/2686/files#diff-95537661c1b0059e1345045c9a88a0758e86d0e1b66720a8610cfe3d839f5c92
(0)
M
products/cloudflare-one/src/content/tutorials/block-football-users.md
https://github.com/cloudflare/cloudflare-docs/pull/2686/files#diff-1dd99641bcac3128a9b3988a2423459974dfcb15c991626da4a16c05800e891e
(8)
M products/cloudflare-one/src/content/tutorials/block-football.md
https://github.com/cloudflare/cloudflare-docs/pull/2686/files#diff-296e89535871673cbe3c2677939c21c441b9c05c6370292c1a230a6fc20d7894
(10)
M products/cloudflare-one/src/content/tutorials/block-uploads.md
https://github.com/cloudflare/cloudflare-docs/pull/2686/files#diff-9978639bdedcd7cea731c346679a0b473e82e41de96c4d3241fff0b393a60066
(2)
M products/cloudflare-one/src/content/tutorials/do-not-decrypt.md
https://github.com/cloudflare/cloudflare-docs/pull/2686/files#diff-e43cee0a724b8892f4dd69253e5e3c5e40d5ffec32780e46ae24d8fae7fa5d8a
(16)
M products/cloudflare-one/src/content/tutorials/mongodb-tunnel.md
https://github.com/cloudflare/cloudflare-docs/pull/2686/files#diff-7694f3176bc7634fe9300ddaa7d0c9d20980a6e553e62c2cfd2d1ff255dec24c
(20)
M products/cloudflare-one/src/content/tutorials/require-swg.md
https://github.com/cloudflare/cloudflare-docs/pull/2686/files#diff-45f5df45240c08552b81f6d815b4d51b1e2699886daec7be8f9d979a8f463dca
(2)
M
products/cloudflare-one/src/content/tutorials/secure-dns-devices.md
https://github.com/cloudflare/cloudflare-docs/pull/2686/files#diff-5a8dd8711bf09d51903c34164117d82f8d6c4ccac274fb031dcec7076bf9463f
(2)
M products/cloudflare-one/src/content/tutorials/share-new-site.md
https://github.com/cloudflare/cloudflare-docs/pull/2686/files#diff-1a968c91f0127d3830f7c2007543070f1feb4ea8a41679a34652328c6c388e03
(16)
M products/cloudflare-one/src/content/tutorials/warp-to-tunnel.md
https://github.com/cloudflare/cloudflare-docs/pull/2686/files#diff-51c862174669440f50b886e35d74143c097a9fe6fcd497d039e175051b33ed28
(2)

Patch Links:

https://github.com/cloudflare/cloudflare-docs/pull/2686.patch
https://github.com/cloudflare/cloudflare-docs/pull/2686.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/cloudflare/cloudflare-docs/pull/2686, or unsubscribe
https://github.com/notifications/unsubscribe-auth/ASDJYIDRXLJEDI33MAXI5X3ULUDGJANCNFSM5H4YCUVQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.


Clean up scripts directory

Move outdated ingest scripts to old/ directory. Maybe old-2023/.

Also think about module naming.


⚠ Bofrost.be has degraded performance

In 0972e66, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 1434 ms

Resolved: Bofrost.be performance has improved in d057058.


Allow for Trip Icon Selection

I guess pick from all SF symbols, don't shove it in the users face though.
Maybe have like 20 icons, and then an advanced section where it's either type in a string, or a preview for all of them. I'm not sure about if the show all of them is allowed though.
Don't forget to filter out the forbidden ones too.

Narrowing the scope for this issue to just have the a set of prepicked icons. Custom icons later.


Optimization: Emit ClassDef1 if smaller

This is an optimization to reduce GDEF size, implemented by makeotf. See https://github.com/adobe-type-tools/afdko/issues/89.

Note that we do emit ClassDef1 if smaller.  The issue at hand is to include items with classDef 0, to reduce the number of ranges that need to be emitted in a ClassDef1.

Ie. if you have classes for glyphs 10..13 and 15..19, then it's more efficient to include glyph 14 with class 0, such that only one range is emitted...

Humm.  I was wrong.  It looks to me like we do this optimization correctly already.  Maybe the difference is only when the format 1 and format 2 will be the same size?

I've checked again; I don't think there's anything to do here.


Adds Run v2

I added Run V2 to the autogeneration list; it will get generated and updated automatically from this point.


[Views] layers: image and voxel sizes not updated

How to see this problem:

Add a data in a view with an image and voxel sizes.
Add a new layer with different image and voxel sizes.
The annotations do not change on the view : patient, study, series.

Edit: the image and voxel size after reslice in vtkImageView2D::SetInputLayer should be the same?

solved by https://github.com/medInria/medInria-public/pull/550


Discussion: Add test to show inline projection rebuilds stopping at gaps.

This test is to reproduce an issue we noticed in one of our environments, where inline projection rebuilds would get stuck on gaps in the event stream.  Early gaps within the event stream were caused by some catastrophic failures, though I'd expect the projection rebuilds to be able to deal with gaps and move on.

@dionfoster Got a fix coming in for this. I pulled your repro test in with a rebase, so closing this. Thank you for the reproduction steps, that's over half the battle for some things like this.


Start on use-case oriented documentation

What about adding another type of documentation, one that is use-case oriented?
E.g. show how to assert when you have a list. Give tips and tricks both regarding the Intent API as well as practices on writing good tests (regardless of framework)?
I think such a document would serve new users as well as developers new to TDD / testing well. Intention is to showcase common situations and let the API specification (or matchers.md) cover the details.
Related to #27

@provegard any thoughts on this style of documenting?

Very nice!

I'll merge this to master and we'll keep it up-to-date there on common scenarios.


Uncaught TypeError: Cannot read property 'split' of null

Hello, I've created doc files with sample js file. There is an error in browser console.(index.html)
Error:
docma-web.js:38 Uncaught TypeError: Cannot read property 'split' of null     at Function.t.fromID (docma-web.js:38)     at window.onload (docma-web.js:38)

Can you provide a sample project and your docma configuration?

My config:
{
  "src": "./src/MyClass.js",
  "dest": "./docs",
  "app": {
    "title": "My Documentation",
    "routing": "path"
  },
  "template": {
    "path": "default"
  }
}

My sample js:
/**
 * This is MyClass.
 * @example
 * let myClass = new MyClass();
 */
export default class MyClass {

   /**
   * this is a constructor description.
   * @param {number} a this is first number.
   * @param {number} b this is second number.
   * return {Object} an instance
   */
  constructor(a, b) {
	  this.a = a;
	  this.b = b;
  }

  /**
   * @param {number} a - this is a value.
   * @param {number} b - this is b value.
   * @return {number} result of the numbers.
   */
  sum(a, b){
    return this.a + this.b;
  }

}

Console error:
Uncaught TypeError: Cannot read property 'split' of null
    at Function.t.fromID (docma-web.js:38)
    at window.onload (docma-web.js:38)

The reason is that your config does not set app.entrance and Docma had no default value for it. With the new release v1.4.0 it now defaults to "api". Pls update to the latest.
Additional Notes:
If you export your class in the same line with class definition (as in your example), you should explicitly document the name and type. Example:
/**
 * This is MyClass.
 * @class MyClass
 * @example
 * let myClass = new MyClass();
 */
export default class MyClass { }

Otherwise, export default class SomeClass { .. } will document as module.exports.
I suggest, you export your class on a separate line:
/**
 * This is MyClass.
 * @example
 * let myClass = new MyClass();
 */
class MyClass { }

/**
 * @private
 */
export default MyClass;

Also, see build configuration docs for how to ignore symbols like module and for other useful configurations.
Finally, your constructor's documentation has a typo. return should be @return or @returns.

Thank you so much for helping. Sorry for my bad. I was looking a lot of documentation tool and I did a mistake.
Best regards, have a nice day!

No problem at all. Glad to help.


xaringan package - consider it over beamer (?)

Related to another science question, I was introduced to an end product presentation built by xaringan.  During discussions Ian noted that upon first glance the xaringan package seems to be clearly far better than Beamer (at least in looks).  Maybe this is something we want to consider for our presentations - though admittedly Beamer works just fine for our hake process purposes.
See this presentation and the acknowledgments slide:
https://www.dicook.org/files/visec2020/slides#1

I have done several presentations using xaringen. It's cool but it is rendering webpages as slides. Try opening that with Internet Explorer... FireFox and Chrome render it similarly but IE Edge is in a different font. We would have to say "Must use Chrome" or something.
Also, this means re-formatting all the slides on all the presentations. Many are easy but those ones with column percentages for plot vs text and such would have to be redone. Maybe we could do the shortest one as a testbed first?

I would vote for keeping status quo right now given that we have plenty of other work to do and the IT capabilities of many of our readers is "challenged".

Agree with Kelli - beamer and .pdf works just fine, and the slides are somewhat automated. Plus that's the few days we get between submitting and the meeting, so keeping it simple gets my vote! I've seen people try and give talks from web slides and it doesn't really work well.

sounds good to me - closing this then


Strange insiders crash

VSCode Version: Code - Insiders 1.6.0-insider (602155bb781f509c7a4ddcd700b57cb9b9f5286d, 2016-10-01T00:34:33.697Z)
OS Version: Linux x64 4.4.0-38-generic, Ubuntu 16.04
Extensions: EditorConfig.EditorConfig-0.3.3, Tyriar.lorem-ipsum-1.0.0, Tyriar.sort-lines-1.1.0, Tyriar.theme-glacier-0.0.10, Tyriar.vscode-terminal-here-0.0.5, christian-kohler.path-intellisense-1.0.2, cssho.vscode-svgviewer-1.2.0, dbaeumer.vscode-eslint-1.0.7, eg2.tslint-0.5.39, felipecaputo.git-project-manager-0.1.15, ms-vscode.csharp-1.4.1, ms-vscode.typescript-javascript-grammar-0.0.2, rebornix.Ruby-0.8.0, rebornix.nova-0.0.5, redhat.java-0.0.4, ryu1kn.annotator-0.10.0, ryzngard.vscode-header-source-1.0.4

Steps to Reproduce:

I was coding in a JavaScript file, syntax highlighting was broken due to the issue with ms-vscode.typescript-javascript-grammar-0.0.2
All of a sudden I got a crash dialog and got asked to relaunch, I did
The instance of VS Code I was working on remained fine
Another Insiders instance launched with 2 files open I did not recognize:

This has only happened once.

@Tyriar is this reproducible? did you have 2 windows open when this happened?

No idea how this happened.

Not sure if I had more than one Window open before the crash, I certainly didn't have server.js open. Haven't been able to reproduce and I doubt I will, if you both have no idea then feel free to close the issue. @bpasero do you see any way https://github.com/Microsoft/vscode/blob/6fa85223efb25ad7ce3e534c7eb07edd9524bd6d/extensions/typescript/src/utils/electron.ts#L118 could break?

It is indeed very wired but I have no idea how VS Code could decide to open files from an extension implementation. I opt to close.

@bpasero feel free to close

Some more info, this is in my storage.json:
{
    "openedPathsList": {
        "files": [
            "/home/daniel/.vscode-insiders/extensions/dbaeumer.vscode-eslint-1.0.7/server/server.js",
            "/home/daniel/.vscode-insiders/extensions/dbaeumer.vscode-eslint-1.0.7/node_modules/vscode-languageclient/lib/utils/electronForkStart",
            "/home/daniel/playground/ts-pg/src/a.ts",
            "/home/daniel/Downloads/google44a591bcde78497c.html",
            "/home/daniel/dev/Microsoft/vscode/appveyor.yml",
            "/home/daniel/Downloads/vttest-20140305/vttest.h",
            "/home/daniel/Downloads/xterm-325/input.c",
            "/home/daniel/Downloads/xterm-325/charsets.c",
            "/home/daniel/Downloads/xterm-325/charproc.c",
            "/home/daniel/temp/shiporder.xsd",
            "/home/daniel/dev/dotfiles/waderyan.gitblame",
            "/home/daniel/dev/dotfiles/ryzngard.vscode-header-source",
            "/home/daniel/dev/dotfiles/ms-vscode.csharp"
        ],
...

I am not sure what that JSON file is telling us? If an instance decides to open electronForkStart, those files will show in the openedPathsList.
I am moving this to you to provide more steps to reproduce so that we can work on a fix.

Haven't seen since


fix: Modified indicators incorrectly displayed for some UI5 controls in Adaptation Project

https://github.com/SAP/open-ux-tools/issues/2263

the usage of the fl library looks fine. I will document in openui5 that they are used here


Problem with adding children to the grid after it is initially displayed.

I have problem with adding children to the grid after it is initially displayed (for example after button click). I have small example demonstrating the problem. Can you please take a look.

This example demonstrates problem with adding children to the grid after it is initially displayed. Before attaching to visual tree “TestGrid” (custom control inheriting Grid) method “Additem” is called and it adds evenly sized rows to row definitions and children (in this case borders) to Children collection set to each row. It works as expected. However same method is called on button click and in that case added children are no longer visible.

Okay, will take a look at this later


Signup: Create Signup Form

In this PR, I was able to:

create a form to register a new user
validate the form for appropriate inputs

Thanks @iLynette for the warm feedback


Make use of Relation in the Shelley exec spec

make use of Leder.Core.Relation typeclass to have a better correspondance between the written spec and the code

the bulk of this is done, what's left will be scoped up by https://github.com/input-output-hk/cardano-ledger-specs/issues/683


Console log output every time file is modified

Every time frontmatter is generated, I can see a console log output being generated from here: https://github.com/HananoshikaYomaru/Obsidian-Frontmatter-Generator/blob/636a9fcf58edca8ddd0b2da4ad9070c59f283d5d/src/utils/obsidian.ts#L59C4-L59C20
Seems like a debug log?

It is. 😅haven't touch the code for a while. Really need to clean this up.


Modify recipe to build most recent version of library

Checklist

[ ] Used a personal fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

Updated version numbers and hashes related to the new version of the library. Copied automated commit to update tool versions.

@conda-forge-admin please rerender

@conda-forge-admin, please restart ci

Hi @matthewgilbert, I've gotten all the builds to succeed, is there anything else I should do in order to get this PR merged? Thanks!

@reggied happy to add you as a maintainer if you are interested?

Thanks @matthewgilbert that would be great.


Initial operation definition/handler abstraction

What was changed
Initial operation abstraction was added with interfaces to define and implement operations. There are obvious missing pieces that are to come in successive PRs:

The ability to match a @ServiceImpl with a @Service (and the @Operation/@OperationImpl pieces within)
Nexus server and client

After some discussion, we are making a fairly significant update to this PR including having a handler package and a top-level handler like Go has with a service handler builder. We will also have context and details objects for the handlers. I will update this PR when done (it may take a bit).

I am closing this PR. There will be a new PR with much more code than is here.


#300 fix: S3Proxy is not compatible with official AWS' extended library

fixes #300. There are 2 formats of a pointer:

Legacy format

{"s3BucketName": "bucket", "s3Key": "key"}

Correct format

["software.amazon.payloadoffloading.PayloadS3Pointer", {"s3BucketName": "bucket", "s3Key": "key"}]

consumer is compatible with both legacy and correct formats
sender.usingS3Proxy(...) is still using the legacy format, but is the method deprecated
sender.usingS3ProxyCustomEncoder(...) allowing user to use the correct format
default codec is using new format
added test checking if this is actually compatible with The Amazon SQS Extended Client

Looks great! Please add a section to migration guide on how to adapt to the new version and we'll be good to merge


chore(test): add macro performance test for Subject composition

Since we're experimenting with "lifted Subjects" (aka Subjects that when operators are applied still return a Subject), it's definitely worthwhile to see how this affects performance. In order to do so, we'll need some macro performance tests.

I'm closing this one for now, because I'm no longer convinced it's worthwhile, perhaps we'll revisit this after beta.


[Bug] Colors are present in the html version however when converting to pdf there are no colours.

Asciidoctor & Asciidoctor PDF Versions
Asciidoctor 2.0.18 [https://asciidoctor.org]
Runtime Environment (ruby 2.7.6p219 (2022-04-12 revision c9c2245c0a) [x86_64-linux])
Asciidoctor PDF 2.3.4 using Asciidoctor 2.0.18 [https://asciidoctor.org]
Runtime Environment (ruby 2.7.6p219 (2022-04-12 revision c9c2245c0a) [x86_64-linux])
The issue
When using a .adoc file and converting it to html, it works flawlessly however, when using asciidoctor-pdf to convert from .adoc to pdf, colors are missing.

Running the command asciidoctor-pdf test.adoc -o test.pdf, does not show colors.

Full command execution
[root] # asciidoctor-pdf test.adoc -o test.pdf -v -w -t --failure-level INFO

asciidoctor: INFO: possible invalid reference: ETAT_TEST_VIE
asciidoctor: INFO: possible invalid reference: ETAT_TEST_VIE
Input file: test.adoc
  Time to read and parse source: 0.01569
  Time to convert document: 2.57354
  Total time (read, parse and convert): 2.58923

More
Let me know if you need anything else.
Gbye.

In previous issues, we've been very clear about the fact that cell colors are deprecated and not supported in Asciidoctor PDF. They are likely being removed from the AsciiDoc language as well. They've never been documented and are thus not considered standard. The HTML converter retains them in the current version only for backwards compatibility.
Related discussions:

https://asciidoctor.zulipchat.com/#narrow/stream/279642-users/topic/.E2.9C.94.20Table.20cell.20background.20colour
https://github.com/asciidoctor/asciidoctor-pdf/issues?q=is%3Aissue+sort%3Aupdated-desc+cellbgcolor+is%3Aclosed


The Scrape button does not respond

Everything seems fine but the Scrape button does not respond Tried it locally and with the Docker. no blink or anything it just does not respond at all

Hi there,
Please provide a bit more information.

What video URL are you trying to scrape?
What OS and Browser are you using?

Thanks!


How can i convert image to grayscale

I want to make image black and white, please help me to create grayscale filter color combination.

@ervinod You can use Saturation Subfilter with value 0 to create grayscale effect.


Add more explanation and faq

Some more info about what the tool does, how it works (eg secure random), etc would be handy to include.

Stub:
FAQ
How does it work?
How am I supposed to use this?
Are there other implementations of SLIP39? Are they compatible?


[#145] fix test and documentation issues

fix #145

Codecov Report

Merging #146 (4f6f520) into master (859e1dd) will decrease coverage by 1.11%.
The diff coverage is 33.33%.

@@             Coverage Diff              @@
##             master     #146      +/-   ##
============================================
- Coverage     73.22%   72.11%   -1.12%
+ Complexity      563      558       -5
============================================
  Files            89       89
  Lines          1733     1750      +17
  Branches        187      187
============================================
- Hits           1269     1262       -7
- Misses          402      425      +23
- Partials         62       63       +1

Impacted Files
Coverage Δ

...rc/main/java/seedu/address/logic/LogicManager.java
76.19% <ø> (ø)

...va/seedu/address/logic/commands/CommandResult.java
69.56% <ø> (ø)

...java/seedu/address/logic/commands/NextCommand.java
0.00% <ø> (ø)

.../seedu/address/logic/commands/PreviousCommand.java
0.00% <ø> (-80.00%)
:arrow_down:

...java/seedu/address/logic/commands/CommandList.java
36.36% <33.33%> (ø)

.../seedu/address/storage/JsonAddressBookStorage.java
70.58% <0.00%> (-29.42%)
:arrow_down:

src/main/java/seedu/address/model/UserPrefs.java
78.12% <0.00%> (-1.88%)
:arrow_down:

src/main/java/seedu/address/MainApp.java
0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 859e1dd...4f6f520. Read the comment docs.


feat: add app recommender components

No design was prepared in figma.
An image is attached below for for inspiration purpose

Make sure the font and color you used should match with website theme.

Should it be displayed only in mobiles and tablets?

Should it be displayed only in mobiles and tablets?

Only mobile


Added output formatting for Fusion 360 and Python code.

I added equation formatting for Fusion 360, and Python.
Here's some Python code that will plot the equations that I used to validate the Python functions.
`import numpy as np
import matplotlib.pyplot as plt
ax = plt.figure().add_subplot()
Rotor
t = np.linspace(0, 2 * np.pi, 1000)
x = (45.0np.cos(t))-(6.5np.cos(t+np.arctan(np.sin(-15t)/((15/8)-np.cos(-15t)))))-(1.5np.cos(16t))
y = (-45.0np.sin(t))+(6.5np.sin(t+np.arctan(np.sin(-15t)/((15/8)-np.cos(-15t)))))+(1.5np.sin(16t))
z = 0
R
Ra = np.linspace(0,2* np.pi, 150)
Rx = 45 * np.cos(Ra)
Ry = 45 * np.sin(Ra)
Rr
Rra = np.linspace(0,2* np.pi, 150)
Rrx = 6.5 * np.cos(Rra) - (45)
Rry = 6.5 * np.sin(Rra)
ax.plot(x, y, z, label='Rotor')
ax.plot(Rx,Ry, label='R')
ax.plot(Rrx,Rry, label='Rr')
ax.set(aspect=1)
plt.legend(loc="center")
plt.grid()
plt.show()`

Hi Sean,
Wow! This is a great update! I haven't played too much with Fusion360 so I had no idea that there was a different way it understood arctan than SolidWorks. This should help make this more accessible to more people!
I'll merge the pull request! After that I'm gonna change lines 137 and 183 a little. I'm gonna change the variable name a little so that it is a bit easier to follow. I didn't realize of was a variable name, so I started Googling what match of: did in Python.
I'm going to change it from:
of = outputformat.get()
to
outputformat_value = outputformat.get()
Again, thank you so much for this update! It is really great!

Hi @seanalford,
I'm not sure if you can see this but hopefully you do. I was playing with code you posted in your first comment (the one used to graph the drive), and added some stuff to it.
It can now plot all the rollers in the right spot and check to see if the rollers match the rotor.
Here is the code:
`
import numpy as np
import matplotlib.pyplot as plt
########################################
Settings
########################################
R = 10					# Rotor Radius (The radius of the center of the rollers)
Rr = 1.5				# Roller Radius
E = 0.75				# Eccentricity
N = 10 					# Number of Rollers
ax = plt.figure().add_subplot()
########################################
Main Code
########################################
Rotor Equations
‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾
t = np.linspace(0, 2 * np.pi, 1000)		# Number of points
psi = np.arctan((np.sin((1-N)t))/((R/(EN)) - np.cos((1-N)t)))
x = (Rnp.cos(t))-(Rrnp.cos(t+psi))-(Enp.cos(Nt)) + E
y = (-Rnp.sin(t))+(Rrnp.sin(t+psi))+(Enp.sin(N*t))
ax.plot(x, y, label="Rotor")
Rotor Radius (Center of rollers position) Equations
‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾
Rt = np.linspace(0, 2 * np.pi, 150)
Rx = R * np.cos(Rt)
Ry = R * np.sin(Rt)
ax.plot(Rx, Ry, '--g', label="Roller Positions")
Roller Equations
‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾
theta = np.linspace((np.pi / 2), (5/2 * np.pi), (N + 1))
Rrt = np.linspace(0, 2 * np.pi, 150)
for index, radian in enumerate(theta):
Rrx = Rr * np.cos(Rrt) + (R * np.sin(radian))
Rry = Rr * np.sin(Rrt) + (R * np.cos(radian))
if index == 0:
	ax.plot(Rrx, Rry, 'r', label="Roller")
else:
	ax.plot(Rrx, Rry, 'r')

Plotting
‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾
ax.set(aspect=1)		# Locks the axes so the curve is show properly
plt.legend()
plt.grid()
plt.show()
`
I thought you might be interested. Enjoy! :)


export interfaceValues since it is returned from DisticntReduce

I need to be able to convert the values returned from Reduce function into something meaning full on my end. Since interfaceValues was not exported I could not type assert it and then iterate over its values. Exporting it allows for this behavior. Exporting seemed better than iterating over it after sorting in order to return a []interface{}.

Fine with me. I feel @benbjohnson should be informed since he's working in this are (I believe).

Works for me.


Automate generation of @en-tagged versions of annotations

See issue #685.
This will go into a separate file, so the main files have canonical, untagged versions.
This will be generated as part of the pre-commit hook so that they are up-to-date for development purposes.
Assigning to @Jamie-SA, to be delegated if desired.

TBD: File naming conventions, file and directory structure

One directory for each language or a shared directory for all languages?
One file per language, or mirroring the canonical files with 5 separate files? If the latter, there should be a directory per language to avoid clutter.
The release package generates multiple serializations of each file, so having one directory per sub-language seems cleaner and more manageable.
Adding status "under review" until these questions are answered.

Not sure if this helps, but ontology-toolkit provides an example of how this could be done using onto_tool:
SPARQL tools apply a SPARQL Update query to each input file and serialize the resulting graph into the output file. RDF format is preserved unless overridden with the format option. If the query is specified inline, template substitution will be applied to it, so bundle variables can be used, but double braces ({{ instead of {, }} instead of }) have to be used to escape actual braces.
  - name: "add-language-en"
    type: "sparql"
    query: >
      prefix skos: <http://www.w3.org/2004/02/skos/core#>
      DELETE {{
        ?subject skos:prefLabel ?nolang .
      }}
      INSERT {{
        ?subject skos:prefLabel ?withlang
      }}
      where {{
        ?subject skos:prefLabel ?nolang .
        FILTER(lang(?nolang) = '')
        BIND(STRLANG(?nolang, '{lang}') as ?withlang)
      }}

Team discussion on 2023-05-25 led to the following conclusions:
  * Related issues:
	  * [Automated generation of en version](https://github.com/semanticarts/gist/issues/840)
	  * [Sample French version](https://github.com/semanticarts/gist/issues/841)
	  * [Sample Spanish version](https://github.com/semanticarts/gist/issues/851) (Pat McBennett to submit PR)
	  * [Documentation](https://github.com/semanticarts/gist/issues/842)
* Open discussion points
    * Language or language+subtag? Subtag could be region or script. E.g., in Chinese the script is of primary significance in written text, not the region. From John Cowan.
      * Maybe language only if there are no significant regional distinctions, otherwise language+region? (Note, for accuracy the subtags are not always 2 letters).
      * Don't need to prescribe, just let people submit what they want to? We could reject a region tag where there are no regional distinctions.
      * What do we want to do for our versions?
	      * English - use language only, may change in future
	      * French - use language only, may change in future
     * How do we review PRs in language we have no expertise in?
         * Trust factor
         * In-house expertise
	     * Test in Google translate (to English), if they look OK accept them. If not, reject the whole batch.
	     * Add disclaimer for those we haven't been able to review, and also that they may not be up-to-date as gist evolves.
	     * SA in-house expertise:
		     * French: Doug, Jess
		     * German: Rebecca
		     * Arabic: Dalia
		     * Simplified and Traditional Chinese: Katie (some)
		     * Japanese: Katie (some)
		     * Russian: Irina
		     * Italian: Irina
    * No default untagged version - our default should be `en-US`. From John Cowan.
      * Then this is a major change.
      * Decision: keep untagged versions as defaults in ontology files. Can change later in a major release.
    *  File names and directory structure.
	    * Only release in Turtle.
	    * Most likely only gistCore, not supplementary ontologies, will be translated.
	    * There might be a translation of the readme if someone wants to do it.
	    * So, we'll only have one ontology file per language. Naming conventions:
		    * `gistCore.en.ttl`
		    * `README.en.md`
	    * So use one directory. [We didn't decide on a directory name, I propose `language_tagged_annotations` or similar.]

Rebecca - Do nothing
Mark - Don't put language tags in the primary gist file.
Questions:

Do we add any language tags?
If yes, do we offer a non-tagged version?
If we are adding tags, do they go in the main file or ancillary files?

DECISION:

Do nothing until we have a business case.

Disrupts SPARQL queries
Large maintenance issue
No current business driver

If/when a need arises, we will create the infrastructure to do so


Include a pow function

Issue description
I have in math.nix:
let
pow = n : i :
          if i == 1 then n
          else if i == 0 then 1
          else n * pow n (i - 1);
in
{pow = pow; }

, but I think this should be part of the standard library under lib.

Recent attempt to add binary shifts (pow 2 actually) got stuck in the discussion of should the integers remain 64-bits or become arbitrary-large

We could also just call it pow64, if that works on 32 bits platforms.
My concern with this thread is that it would become a bikeshed issue. Even if the name pow_pow_pow_pow_pow would be used, that would be better than everyone having their own version of basic functions.
I don't know of the performance overhead of having almost everything in <math.h> (or in some existing functional programming language's math library) as primitives, but I would perhaps just generate a corresponding Nix standard library out of that. For documentation one can then just write a link to some other system and there is no extra investment if you already happen to know that other language. To a certain extent this has been done with the list functions already.
If backwards compatibility is a concern, we could just introduce lib1.math and lib2.math, and keep the various lib versions around either forever or for a decade.

Speaking of bikeshedding:
let
  pow = base: exponent:
    if exponent > 0 then
      let
        and1 = x: (x / 2) * 2 != x;
        x = pow base (exponent / 2);
      in
assert and1 0 == false;
assert and1 1 == true;
assert and1 2 == false;
assert and1 3 == true;
        x * x * (if and1 exponent then base else 1)
    else if exponent == 0 then
      1
    else
      throw "undefined";
in
assert pow 0 1000 == 0;
assert pow 1000 0 == 1;
assert pow 2 30 ==<PHONE_NUMBER>;
assert pow 3 3 == 27;
assert pow (-5) 3 == -125;
  {
    inherit pow;
  }

and1 = x: (x / 2) * 2 != x;

builtins.bitAnd 1 will be in Nix soon (already in master, not in 2.0.4)

@volth Yes. But while we are in transition, nixpkgs would need to implement backup versions in pure nix before we can use those.

Also both versions may need toInt or assert isInt to catch passing float arguments

@coretemp did you end up getting resolution on this, or is it still sitting?

"still important to me"


Fix some OpenAPI issues

Good PR (fixing all the outstanding issues in one go, didn't look at the code yet though)

code looks good

Three fixes in one stroke, very nice.
How about some entries in the changelog?

Changelog updated, corrections added.


a chart with no colors defaults to the identity color scale

[ ] Should this be undefined instead? See discussion in #744.

fixes #744
cc: @yurivish

superseded by #756 and #757


NewEnterpriseClient method with custom urls

With this PR I have completed the following, addressing the issues discussed in #756:

Introduced new func to create a new enterprise client
Ensured base and upload urls are formatted with a trailing slash
Added appropriate comment documentation
Extended test cases to cover this new creation method

Did I cover everything? :)

Added the changes as requested in the feedback!

Merged. Thank you @chriskingnet and @gmlewis (for reviewing)!


Allow binary integers/bitmasks

Maybe this is already possible and I just didn't find how... but, if not:
It would be nice to be able to define integers in the config file using standard C notiation for hexadecimal and binary, e.g.:
CONFIG_ADC_PIN_MASK = 0b0010
CONFIG_ADC_MAX_IDX = 0xFFFF

A CFG_INT is converted from string to int using strtol(3), so 0xffff works, but not 0b0010. Patches or pull requests are welcome.

Pull Request 151 should do this.


Implemented replace_batch() #1652. Definitely plenty of use cases for this.

Instead of making people compile the query and then replace the "INSERT" string it's better to have this feature.

Already has been suggested and rejected - see not just #1652, but also #4452 - and your reasoning in support of it isn't any better.

Just because you don't have any use case for it doesn't mean there isn't any. I wasn't the first person to open an issue and I won't be the last. Many developers will not even bother and just use a sql workaround which is not required if they have this code aND defeats the entire purpose of active record. I think this feature warrants a larger vote by the community.
One use cases involve inserting many rows of user profile settings into a table where it's inefficient to select the rows then update them one by one. There is no other efficient way to both insert and update multiple rows efficiently without replace, or on conflict update.
Consider also creating multiple shopping cart items that the user clicks save and updates multiple quantities at once, you don't want to have to check each one to see which ones changed or got added. What you want is to insert or update all of them in one query, aka batch replace.
If you're a domain registrar and want to update multiple domain owner data at once including adding ones that don't exist you need this.
I could literally think of thousands of use cases.
There's a reason all good ORM solutions in every language and platform include a batch replace. There's no valid reason to not support this, especially when the query builder class cannot be extended. If you allowed users to extend the query builder I would say there is possibly a reason.
We have insert, replace, batch insert, but no batch replace? It's obviously a missing feature. It doesn't make sense, especially when you have a pull request. Isn't the framework supposed to grow and get better based on the needs of the community? How could this possibily make it worse? If you're concerned about supporting it, I can volunteer to make any required changes.
I think you're holding something back that the community actually needs, and I'm not really sure how that benefits the any of us.

Just because you don't have any use case for it doesn't mean there isn't any.

You're basing this on my very first comment on #1652 4 years ago. I didn't point you to #4452 for nothing.
And you're twisting my words on top of that.

I wasn't the first person to open an issue and I won't be the last.

Yep, you're the 3rd in the 5 years since I've been involved with the project. This doesn't mean anything.

Many developers will not even bother and just use a sql workaround which is not required if they have this code

I don't see a problem with that.

aND defeats the entire purpose of active record.

We don't have Active Record.

I think this feature warrants a larger vote by the community.

I don't.

One use cases involve inserting many rows of user profile settings into a table where it's inefficient to select the rows then update them one by one.

I'd say it is highly likely that you have a poor database design if you need to do this.

There is no other efficient way to both insert and update multiple rows efficiently without replace, or on conflict update.

You're saying "efficient", but really mean "easy".

Consider also creating multiple shopping cart items that the user clicks save and updates multiple quantities at once, you don't want to have to check each one to see which ones changed or got added. What you want is to insert or update all of them in one query, aka batch replace.

Fair enough - one half-decent use case.
I'm saying half-decent for a reason though - cart contents are temporary, and as such I don't believe they should be stored in a persistent database in the first place.

If you're a domain registrar and want to update multiple domain owner data at once including adding ones that don't exist you need this.

You'll have a very hard time convincing me that this ever happens, even more so with CodeIgniter being the engine underneath.

I could literally think of thousands of use cases.

You're thinking of ways to use it, not of cases that require its usage or where it is overwhelmingly better than an alternative - that's a completely different thing.

There's a reason all good ORM solutions in every language and platform include a batch replace.

ORMs are a different beast; we don't have an ORM.

There's no valid reason to not support this, especially when the query builder class cannot be extended.
If you allowed users to extend the query builder I would say there is possibly a reason.

By your logic so far, there's no valid reason to reject any feature ever.
Again, please read through #4452, and more specifically this comment.
Besides, everything that adds tens (and in this case hundreds) lines of code just to replace a single keyword is bloat in my book.

We have insert, replace, batch insert, but no batch replace? It's obviously a missing feature.

Features are not collection items.

It doesn't make sense, especially when you have a pull request.

I appreciate that you did make the effort to actually write the code, which few people do. However, that doesn't mean I must merge it.
Honestly, this expectation that all contributions must be accepted is quite annoying.

Isn't the framework supposed to grow and get better based on the needs of the community?

You know, I get similar pleas almost every time I reject a feature ...
Yes, it is supposed to do that. It's also supposed to consider the usefulness and safety of proposed features, whether they fit in within its philosophy, guard itself against from feature creep, bloat and technical debt, etc.
What you feel is a "need" for you personally may not be one for the community as a whole, and can very often be exaggerating what is actually a "nice to have sometimes", or poor judgement in the sense that you "need" it only because something else you do makes this seem like an ideal tool (see my "poor database" comment above for an example).

How could this possibily make it worse?

Lack of (known) negatives doesn't mean a definite positive.

If you're concerned about supporting it, I can volunteer to make any required changes.

I am also concerned about supporting it, and I would still be a part of my efforts regardless of whether you'd be helping with it or not.

I think you're holding something back that the community actually needs, and I'm not really sure how that benefits the any of us.

Passive-aggressive remarks like this one don't help your case.

Well, I guess if that's how you want to respond to new contributors I won't try to contribute anymore. I was trying to help because I really appreciate the work you have done on CI so far. I would be ok if you at least made the query builder class extendable. Could you at least consider that? I don't want just open an issue so you can just reject it.


Allow markdown_body_is_field to be set to something to disable that feature

As it defaults to body, you currently can't

It's ---


MixedDensityEstimator should be able to have an embedding_net

As all neural networks in sbi, the MixedDensityEstimator should also be allowed to have an embedding_net. This is especially critical if we intent to use the MixedDensityEstimator also to estimate mixed posteriors with NPE.
This issue was suggested in #1066

closed by #1203


Spain’s “A-roads” do not necessarily have blue shields

Currently, this project assumes that every route relation tagged network=ES:A-road is an autopista or autovía that has a blue shield. Neither assumption is correct with respect to OSM. In reality, Spain’s route designation situation is almost as complex and inconsistent as in the U.S. Although the national government often applies a blue shield and “A-” or “AP-” prefix to autopistas and autovías, many have the prefix “R-” (for radial) or “AP-” (for autopista de peaje), making it less clear whether these routes should be considered “A-roads”.
Meanwhile, each of the autonomous communities has its own conflicting scheme for local autovías. For example, in Andalusía (which happens to start with an A), Autovía A-92 has an orange shield, while Autovía A-382 has a green shield. In Castile and León, Autovía A-231 has a blue shield. In the Basque Country, Autovía AP-1 is neither nationally operated nor tolled but still has the “AP” prefix and blue shield.
Due to the large number of idiosyncrasies, the Spanish community has adopted the ref:colour key to indicate the shield color independently of the route network. It would be better to base the shield selection on this data than to maintain an override list ourselves, since the assigned colors apparently change regularly. The vector tiles would need to expose ref:colour, ideally coalescing similarly hexadecimal color references into more predictable color keywords. In the meantime, maybe we should remove the existing blue-only implementation to avoid confusion:
https://github.com/ZeLonewolf/openstreetmap-americana/blob/e5fe35be2653a0cf96acec634e49fe3df829dce1/src/js/shield_defs.js#L3324-L3328

The vector tiles would need to expose ref:colour, ideally coalescing similarly hexadecimal color references into more predictable color keywords.

Since it's tagged at the network level, this is feasible.  However, remember that network and ref are packed into a single tile attribute per route, so you have something like:
route_1=ES:A-road=AP-1
The ref:color key has 35K usages, so it's not unreasonable to use it. I would need to implement some scheme that packs the value into the string to make this work, perhaps by adding another :<color> on the end of the network portion, for example.
However, this will mean that any other network that happens to use ref:color tag will also get its network value modified as well, so we'd need to be wary of second order effects.
This is exactly the kind of craft-mapped boutique output that I'd encourage in this project...

Once #1032 lands, we’ll be able to make the route’s color part of the image name format. The style will pass this color to the shield rendering code to use verbatim instead of the hard-coded blue background.

As of #1032, each feature has a route_#_color property based on the route relation’s ref:colour=* tag. The name gets plumbed through to the application’s shield selection code, which can now parse it out of the image ID that the stylesheet requests.

We’ll need to modify the shield library’s public interface to pass in an optional color:
https://github.com/ZeLonewolf/openstreetmap-americana/blob/cbad54bf616645bd93f218a079268f52450cee39/shieldlib/src/types.ts#L125-L129
At this point, routeDef.color is still set to the raw tagged color, which could be either a CSS keyword or a hexadecimal triplet. We need to match it to the nearest color in our color palette before passing it into the graphics code:
https://github.com/ZeLonewolf/openstreetmap-americana/blob/cbad54bf616645bd93f218a079268f52450cee39/shieldlib/src/shield.js#L335-L342


The active state on our breaking news signup button is unreadable

Click the button
Return to page
...

wow that was a pretty big typo

thought i fixed that. turns out it's a problem on focus not active


Fixes CDK-895

Hi Joey,
Sorry about that. I thought mvn clean compile had run till the end when  I submitted the code.
I just pushed a new version in.

No worries. Also, have you submitted a CLA? If not, there are details in the how to contribute page on the wiki.

Merged in https://github.com/kite-sdk/kite/commit/022941d87a0388f6a84249e5008f8a6a07ba31b9


Turn on ABT unit tests with SPM

Thanks to https://forums.swift.org/t/finding-swift-package-manager-resources/38058/6 handle resources for SPM unit tests
#no-changelog

Firebase 6.29.0 not configure - FirebaseApp.configure() don't work - what now work ?


Improve deploy to Github Pages

Based on https://angular.io/guide/deployment#deploy-to-github-pages and https://github.com/angular-schule/angular-cli-ghpages

Not necessary


Fix mousewheel eventname on IE11<=

Description
The only way to test support for the wheel event in IE9+ is check the feature Events.wheel on the document.implementation.hasFeature object, instead of window. (see here)
Without this test, the eventname on IE11< is mousewheel, instead of wheel:
const eventName = 'onwheel' in window ? 'wheel' : 'mousewheel' // mousewheel ❌
const eventName = 'onwheel' in window || document.implementation.hasFeature('Events.wheel', '3.0') ? 'wheel' : 'mousewheel' // wheel 👍
Using wheel event, wheel data on IE11< is more similar than other browser, with benefit for the user experience.
The package normalize wheel normalize data across browsers and OS in a more accurate way.
Types of changes

[X] Bug fix (non-breaking change which fixes an issue)

Alright, normalize-wheel package again 🤷♂
Anyway I don't think the delta normalizing function in that package is correct. In my tests evt.wheelDeltaY = -3 * evt.deltaY, but in that package it's evt.wheelDeltaY = -12 * evt.deltaY.

Pull request is about detection of mousewheel event on IE11, use normalize-wheel is secondary.
Using 'mousewheel' instead of 'wheel' in IE11 is wrong, scrolling delta normalized by your function is very low.
With 'wheel', wheeldelta is similar to other browser.
Please, consider to use this ternary for detect of events name:
const eventName = 'onwheel' in window || document.implementation.hasFeature('Events.wheel', '3.0') ? 'wheel' : 'mousewheel';

Yep I got your point. I just have no idea about the normalizing function in normalize-wheel package.
I must admit that the current normalizing function in this lib is a bit too simple. Maybe it's a good idea to use normalize-wheel package because the comments inside it are somehow reasonable 😆.
I just noticed that there's a getEventType method in the package. Can we use it to get correct event name like:
const eventName = normalizeWheel. getEventType();

Yes, i try to use normalizeWheel. getEventType(), but i obtain on Firefox 'DOMMouseScroll', which have wrong mousewheel data.

Hmmm...
Then what about fixing the event name only? We can discuss the matter with normalize-wheel later in another PR or issue if necessary.

Ok for fixing only the event name for now.

But I still can see a lot of deletion in files...
I think you just need to commit this line: https://github.com/idiotWu/smooth-scrollbar/pull/124/files#diff-481b84199b44eee82e410719c6df9216R11

It's ok? 😀


Need InteractiveUtils in Project.toml

Just a typicallity:
┌ Warning: Package OSMMakie does not have InteractiveUtils in its dependencies:
│ - If you have OSMMakie checked out for development and have
│   added InteractiveUtils as a dependency but haven't updated your primary
│   environment's manifest file, try `Pkg.resolve()`.
│ - Otherwise you may need to report an issue with OSMMakie
└ Loading InteractiveUtils into OSMMakie from project dependency, future warnings for OSMMakie are suppressed.
WARNING: Method definition registration_setup!(Any, GraphMakie.GraphInteraction) in module GraphMakie at C:\Users\datse\.julia\packages\GraphMakie\tEQ8U\src\interaction.jl:45 overwritten in module OSMMakie at C:\Users\datse\.julia\dev\OSMMakie\src\interaction.jl:6.
  ** incremental compilation may be fatally broken for this module **

Standard library packages still need to be added to project.toml

Oops, didn't know that. Will fix it on interaction branch because that's where I've added the dep.

Fixed in d854f7262e42f7670035c8b99a1eade3acfaf010


Crash when sending messages over wifi

Problem
While doing #1660 I did a mistake in the last commit that broke the wifi part of the chip-tool. This PR fix that so it does not crash anymore while sending Wifi messages via the device controller.

Minor comment left. I'm approving the PR to not block the merge, but I would like the comments addressed / acknowledged.

I thought I fixed it. Anything special that I missed ?


[WIP] Adding view of DogStatsD metrics received by the agent into agent flare

What does this PR do?
When dogstatsd_metrics_stats_enable is set to true, in addition to having the ability to run agent dogstatsd_stats for the stats of the metrics that are being collected by the agent from dogstatsd, it also automatically generate dogstatsd-stats log file that keep track of all metric instances that are sent to the agent.
Example of what the log file look like:

Motivation
Challenges:
Currently, the support team lacks method to troubleshoot missing Dogstatsd metrics.
Support generally will have to either recreate similar logic as the customer's code to test out the metric to identify if the missing metric is happening between DogstatsD and the Agent or the Agent and our endpoint.
Solution:
This feature allows some logging on the agent so we can identify whether a Dogstatsd metric has been successfully delivered to the agent.
The log file specifically will also help in identifying time bucket when a metric goes missing.
Additional Notes
This feature also introduce 2 new env var for the agent config:

dogstatsd_log_file: file path with default path datadog-agent/logs/dogstatsd_info/dogstatsd-stats.log
dogstatsd_log_file_max_rolls with default value being: 3 at 10mb

Possible Drawbacks / Trade-offs
Describe how to test/QA your changes

datadog.yaml config includes:

api_key: <api_key>
use_dogstatsd: true
dogstatsd_port: 8125
dogstatsd_metrics_stats_enable: true
dogstatsd_log_file_max_rolls: 5
log_file_max_size: 3072

Logging is sucessful if dogstatsd log file are generated with path: /dogstatsd_info/dogstatsd-stats.log* by default along with 6 different log files
Reviewer's Checklist

[ ] If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
[ ] Use the major_change label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.
[ ] A release note has been added or the changelog/no-changelog label has been applied.
[ ] Changed code has automated tests for its functionality.
[ ] Adequate QA/testing plan information is provided if the qa/skip-qa label is not applied.
[ ] At least one team/.. label has been applied, indicating the team(s) that should QA this change.
[ ] If applicable, docs team has been notified or an issue has been opened on the documentation repo.
[ ] If applicable, the need-change/operator and need-change/helm labels have been applied.
[ ] If applicable, the k8s/<min-version> label, indicating the lowest Kubernetes version compatible with this feature.
[ ] If applicable, the config template has been updated.

CI is failing.
You are missing an import to satisfy this line
You have an unused import
You can run the tests locally with inv test --skip-linters and it will show you these problems.

Also - I think we can add a changelog (reno) to this PR.

I don't fully understand the reno failure here. I can replicate locally and reno is claiming that the same file is present multiple times in the same git commit, but I only see it once in the directory tree.
$ reno lint
...
ValueError: dd29f9ae1c40e18d: found several files in one commit (b'04b7430ded26718d579990a13685b3f23fc40474') with the same UID: ['dogstatsd-adding-dogstats-log-file-in-flare-dd29f9ae1c40e18d.yaml', 'dogstatsd-adding-dogstats-log-file-in-flare-dd29f9ae1c40e18d.yaml']
$ git co 04b7430ded26718d579990a13685b3f23fc40474
$ find . -name "*dd29f9ae1c40e18d.yaml" | wc -l
1

The commit it flags says in the commit msg there were local changes (adding release note) and a merge in the same commit, so my guess is that this is confusing to reno in some way, but my git/reno knowledge starts to break down past this :)
My best suggestion to get unblocked would be to squash this branch into a single commit and force-push and I imagine this check will start passing.


MM-22401 Refactor Post Draft

Summary
Refactored of the Post Draft component
Ticket Link
https://mattermost.atlassian.net/browse/MM-22401
Note: We should update the modulesPaths after this PR goes in https://github.com/mattermost/mattermost-mobile/pull/4120

@migbot great catch! should be fixed now..

Building app in separate branch.

Successfully building:
https://circleci.com/gh/mattermost/mattermost-mobile/5711
https://circleci.com/gh/mattermost/mattermost-mobile/5710

@josephbaylon the issues you found are iOS only, right ?

confirm issue was only on iOS and fix has been submitted

Building app in separate branch.

Successfully building:
https://circleci.com/gh/mattermost/mattermost-mobile/5751
https://circleci.com/gh/mattermost/mattermost-mobile/5750

Artifact links:
https://5751-70265724-gh.circle-artifacts.com/0/~/mattermost-mobile/Mattermost_Beta.ipa
https://5750-70265724-gh.circle-artifacts.com/0/~/mattermost-mobile/Mattermost_Beta.apk

@enahum Issue only happens on iOS. I retested with the latest build. However, the issue still persists. Make sure to select an item from the autocomplete list to repro the crash.

@josephbaylon I did and is working fine, did you trigger the build before the tests passed? Cause is working fine for me over here

Building app in separate branch.

Successfully building:
https://circleci.com/gh/mattermost/mattermost-mobile/5751
https://circleci.com/gh/mattermost/mattermost-mobile/5750

Artifact links:
https://5751-70265724-gh.circle-artifacts.com/0/~/mattermost-mobile/Mattermost_Beta.ipa
https://5750-70265724-gh.circle-artifacts.com/0/~/mattermost-mobile/Mattermost_Beta.apk


Fetch components without openlcs_scan_url

LGTM

I think we should also filter nested type component's sub component like OCI and RPMMOD when get data from provides  field.

That's why it was not merged as I highlighted in previous meeting, it doesn't make sense for oci and rpmmod as there is no scan url provided.

Ok, got it

There is a data problem in populating subscription purls, bug filed, will add a check after that issue fixed, close this.


[FEATURE] Allow hashed_columns to see derived columns to allow concatenated business keys

I've come across a few instances where I need to hash a derived column in my staging area. Sometimes this is because I simply want to append a manual string to my BK, other times I want to rename something in my staging for use down the line, but I don't have access to it in the hashed_columns section so I have to write SQL or use a field name I'm renaming (or be forced to create an extra model to feed the stage macro)
for example, I have to do the following:
          hstg_sfdc__lead_core:
            vars:
              source_model:
                salesforce: Lead
              hashed_columns:
                HUB_FUNNEL_HK:
                  - "(SELECT 'sfdc.Lead' AS SCOPE_BK)" # SCOPE_BK
                  - Website # DOMAIN_BK
              derived_columns:
                SCOPE_BK: '!sfdc.Lead'
                DOMAIN_BK: Website

What I'd like to do:
          hstg_sfdc__lead_core:
            vars:
              source_model:
                salesforce: Lead
              hashed_columns:
                HUB_FUNNEL_HK:
                  - SCOPE_BK
                  - DOMAIN_BK
              derived_columns:
                SCOPE_BK: '!sfdc.Lead'
                DOMAIN_BK: Website

Additionally, I'm finding an enterprise-wide unique natural key is hilariously difficult. For example imagine I have an HR system, Contractor system, and a partner company system and I want to represent a single concept of Employee.

As you can see the unique keys here are different in each case, so my Business Key has to be a concatenation of multiple keys in the source system. This is what is referred to as src_nk in your hub macro.
In the above example, if I had a 2-part key, passing both keys as src_nk to the hub macro would result in 2 columns SCOPE_BK and DOMAIN_BK, however, I'm only after a single concatenated column.
It would be amazing if dbtvault could support this concatenation as a first-class concept (using the same transformation built into the hash function)
In this case, I might simply have, in each of the staging configs that feed into the hub, something like:
          hstg_sfdc__lead_core:
            vars:
              source_model:
                salesforce: Lead
              hashed_columns:
                HUB_FUNNEL_HK: FUNNEL_BK
              derived_columns:
                HUB_FUNNEL_BK:
                  - '!sfdc.Lead'
                  -  Website

This would generate a table that looks like this:

HUB_FUNNEL_HK
HUB_FUNNEL_BK

98a7sd8a9s7da9fgag7a98a7sda
sfdc.Lead||abc.com

98a7sd8a9gsdf3ggag7a98a7sda
sfdc.Lead||def.com

98a7sd8a9s7da9fgag7a98a123a
sfdc.Lead||efg.com

Currently, I don't even have access to the hash concat macro by itself cause it's a part of the hash macro.
Anyway, I know this is kinda multiple issues, but I wanted to put it out there to see if others felt similar pains.
Of course, as with everything else dbt, you can work around this by adding a separate model before your dbtvault one, but I felt I was doing this all the time and something that can be easily factored out.

Great ideas. Both of these features are quite and straight forward to implement. Derived columns bring accessible by hashed columns is something we already have in the backlog, and the derived column concatenation syntax is certainly very useful!

Added in v0.7.1 Close if working as expected

Closing as we have implemented the primary suggested feature. The concatenation of columns in the derived_columns configuration has been separated into a new issue (#20)

Closing as we have implemented the primary suggested feature. The concatenation of columns in the derived_columns configuration has been separated into a new issue (#20)

Closing as we have implemented the primary suggested feature. The concatenation of columns in the derived_columns configuration has been separated into a new issue (#20)

Closing as we have implemented the primary suggested feature. The concatenation of columns in the derived_columns configuration has been separated into a new issue (#20)


Optional Errors

These two lines return an optional value now, and are throwing the error Value of optional type 'String?' not unwrapped; did you mean to use '!' or '?'?
I'm not sure what the best way to handle this would be for this project, but in the return line, maybe doing something like return (codes, text ?? "")
https://github.com/onevcat/Rainbow/blob/5d5e3d3facd3a46edc260c383f15261b07abcf98/Sources/ModesExtractor.swift#L47
https://github.com/onevcat/Rainbow/blob/5d5e3d3facd3a46edc260c383f15261b07abcf98/Sources/ModesExtractor.swift#L78

The overload set for that initializer should not be different between the package build and the Xcode build.  Subscript should be giving us a Substring which is trivially convertible to a String without needing optionality - which is what Xcode sees.

@anthonycastelli @CodaFi Thanks for reporting this. I will update the Package.swift soon to solve it.


Edited src documentation and docs

I've re-edited the documentation in the source folder and in the docs. I hope I did everything properly this time. Thanks for the PR documentation!

Looks great!  Many thanks for cleaning this up :)


test: in coverage runs, log stacktraces directly to stderr

Description:
Coverage tests run with -l trace --log-path /dev/null, in order to ensure that all of the code-paths from the maximum level of tracing are covered in tests, but we don't wind up filling up CI with useless detailed artifacts.
The downside of this is that if there's a crash, the backtrace is lost, as the backtracing mechanism uses logging. This PR resolves this by redirecting crash logs to stderr for coverage tests only.
Forcing a segv in a test, I see this from coverage with this PR:
[ RUN      ] IpVersions/MainCommonTest.ConstructDestructHotRestartDisabledNoInit/IPv4
#0 Envoy::SignalAction::sigHandler() [0xfc1a564]
#1 __restore_rt [0x7f3da788f390]
#2 __llvm_coverage_mapping [0x53f0501]
#3 __llvm_coverage_mapping [0x53f02f9]
#4 std::__1::operator<< <>() [0x542c838]
#5 Envoy::MainCommonBase::run() [0x7b84ef0]
#6 Envoy::MainCommon::run() [0x7b63693]
#7 Envoy::MainCommonTest_ConstructDestructHotRestartDisabledNoInit_Test::TestBody() [0x7b5a9cf]
#8 testing::internal::HandleSehExceptionsInMethodIfSupported<>() [0x10fabfc6]
#9 testing::internal::HandleExceptionsInMethodIfSupported<>() [0x10f98501]
#10 testing::Test::Run() [0x10f82dd2]
#11 testing::TestInfo::Run() [0x10f838d8]
#12 testing::TestSuite::Run() [0x10f84049]
#13 testing::internal::UnitTestImpl::RunAllTests() [0x10f91056]
#14 testing::internal::HandleSehExceptionsInMethodIfSupported<>() [0x10fb0e66]
#15 testing::internal::HandleExceptionsInMethodIfSupported<>() [0x10f9b321]
#16 testing::UnitTest::Run() [0x10f90aa0]
#17 RUN_ALL_TESTS() [0xf6bc105]
#18 Envoy::TestRunner::RunTests() [0xf6bb8db]
#19 main [0xf6b9f98]
#20 __libc_start_main [0x7f3da74d4830]
external/bazel_tools/tools/test/collect_coverage.sh: line 128: 17456 Segmentation fault      (core dumped) "$@"

Note that this was tested manually; we do not have a test for this test behavior.
Risk Level: medium -- mostly because this messes with the crash handler
Testing: //test/..., plus a manual coverage run with a segv injected.
Docs Changes: n/a -- this does not add an option for envoy servers; just for tests.
Release Notes: n/a

Sorry can you re-approve? Formatting issue needed to be fixed.


Week view with Month like day spanning

A week view calendar that works just like the month calendar but in a week view. So the each day wouldn't show times, it would show events/spanning like the month view. Is this something easily achievable?

Thanks for your interest.
It shouldn't be hard to implement, but that mode is completely different from ical/google calendars and I don't think the UI is common for everyone.


Uupdate CONTRIBUTORS.md

Proposed changes
This PR adds CONTRIBUTORS.md.
Types of changes
What types of changes does your code introduce to the project: Put an x in the boxes that apply

[ ] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[X] Update only documentation, not any source code.

Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of
them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before
merging your code.

[X] I have read the CONTRIBUTING doc
[X] I have signed the CLA
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation (if appropriate)
[ ] Any dependent changes have been merged and published in downstream modules

Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you
did and what alternatives you considered, etc...

Coverage remained the same at 100.0% when pulling<PHONE_NUMBER>ea1534312f66937afafe7881b7ecf1 on fisuda:hardening/contributors into c641e3835d64fbd4214647a86bb0868a0a43f09f on lets-fiware:main.

Coverage remained the same at 100.0% when pulling<PHONE_NUMBER>ea1534312f66937afafe7881b7ecf1 on fisuda:hardening/contributors into c641e3835d64fbd4214647a86bb0868a0a43f09f on lets-fiware:main.


helm ksec set secretname field=value doesn't work

Hello!
I'm testing the set command but it is not working, is it possible to add verbosity to log an error?

found the problem i was using the command on a FILE as secret.


Add rewrite strategy generator app

Summary
This is part 4 of a new feature data layout optimization.
Added Spark app wrapper. This PR builds on top of https://github.com/linkedin/openhouse/pull/116
The following 3 components will be added eventually:
DLO library that has primitives for generating data layout optimization strategies (done)
App that generates strategies for all tables (this PR)
Scheduling of the app
Changes

[ ] Client-facing API Changes
[ ] Internal API Changes
[ ] Bug Fixes
[x] New Features
[ ] Performance Improvements
[ ] Code Style
[x] Refactoring
[ ] Documentation
[ ] Tests

For all the boxes checked, please include additional details of the changes made in this pull request.
Testing Done

[x] Manually Tested on local docker setup. Please include commands ran, and their output.
[ ] Added new tests for the changes made.
[ ] Updated existing tests to reflect the changes made.
[ ] No tests added or updated. Please explain why. If unsure, please feel free to ask for help.
[ ] Some other form of testing like staging or soak time in production. Please explain.

For all the boxes checked, include a detailed description of the testing done for the changes made in this pull request.
TODO: add result of docker testing
Additional Information

[ ] Breaking Changes
[ ] Deprecations
[ ] Large PR broken into smaller PRs, and PR plan linked in the description.

For all the boxes checked, include additional details of the changes made in this pull request.

Curious on the renames from DataLayout to RewriteStrategy


Not able to use large chunk sizes

When I make the chunk size anything much larger than 0.3GB, uploads will work for a while on uploading the first chunk before finally giving up and saying Killed, force closing the application. I am not yet sure what is doing this, but the simple fact that the application itself closes out is indicative of a memory limitation. I need to investigate to be sure, as Telegram should not be imposing hidden limits like this.

I have now had success sending a file in chunks which were 1.0GB pre-encryption (1365.3MB post-encryption). Not sure what the limit is, and still don't know why it says Killed for larger files. I didn't have success sending 3.0GB files.

It seems like there might be a hard limit of 1.5GB per file allowed by user bots. It would be good if I could encrypt large files in a streaming manner instead of encrypting each chunk separately; then I could partition into chunks exactly according to the file size limit. This is worth investigating further; I may make another issue for it. I am considering this issue resolved.

No! This seems like a local error. I think I'm running out of memory on my machine. From the Telethon docs:

client.upload_file() now works better when streaming files (anything that has a .read()), instead
of reading it all into memory when possible.
I should try using this.

Just found out this is due to the encryption. Parallax chunking should fix.


Ability to use map.define on all Map classes in inheritance chain

At the moment it's not possible to use map.define plugin to define properties both on parent and child Map instances. Define config in child class completely overrides parent's "define" section. It should extend instead.
Please check the example: http://jsfiddle.net/njuw9sss/1/

Any update on this issue?
Or there is a workaround, which allows to create MapA -> MapB -> can.Map inheritance chain and define properties both on MapA and MapB level?

For my notes, the issue is when the inheriting constructor has a define property like:
var ParentModel = can.Map.extend({
    define: {
        rawProp: {
            type: '*',
            value: {}
        }
    }
});

var ChildModel = ParentModel.extend({
    define: {
         //
    }
});
``

@isadovskiy There's been no progress on this, but it's probably an easy fix.  First, you need access to the base can.Map in Map.setup: https://github.com/bitovi/canjs/blob/minor/map/map.js#L29.  It's the first argument so make that line something like:
setup: function (baseMap) {

Then, you need to copy everything in baseMap.prototype.define to a new object and then everything in this.prototype.define to that object.  Finally, set that object to this.prototype.define.  Something like the following might work:
if(baseMap.prototype.define) {
  var defines = can.simpleExtend({}, baseMap.prototype.define)
  can.simpleExtend(defines, this.prototype.define);
  this.prototype.define = defines;
}

Now this will only copy properties, but not allow you to overwrite specific values within a property. For example, the following wouldn't work as someone might expect:
var ParentModel = can.Map.extend({
    define: {
        rawProp: {
            type: 'number',
            value: 7
        }
    }
});

var ChildModel = ParentModel.extend({
    define: {
         rawProp: {
           value: 8
         }
    }
});

For that to work, you need to recursively copy all properties over.  You might be able to use can.extend(true, dest, source), but I think that might have unexpected results.
Better would be to only copy values two levels deep.  Maybe create a small helper function at the bottom of can/map/map.js like:
var twoLevelDeepExtend = function(d, s){
  for(var prop in s) {
     d[prop] = d[prop] || {};
     can.simpleExtend(d[prop] , s[prop])
  }
};

And then:
if(baseMap.prototype.define) {
  var defines = twoLevelDeepExtend({}, baseMap.prototype.define)
  twoLevelDeepExtend(defines, this.prototype.define);
  this.prototype.define = defines;
}

hit me up on gitter if you want to work on it.

Closing for https://github.com/canjs/can-map-define/issues/2 and https://github.com/canjs/can-define/issues/18.  Hopefully @chasenlehara can make this work over there.

@justinbmeyer I have some other open source stuff I want to work on, so if someone takes those before I get a chance, they can use my PR: https://github.com/canjs/canjs/pull/2222


pre-trained available through google drive does no unzip properly

Thanks for your interest in our research!
If you have problems running our code, please include

Your operating system Windows 10
Your tensorflow version TF 1.5
Your python version 3.6
The stack trace of the error that you see there s no error: after unzipping the pretrained file, the folder is much much smaller than the zip file. Several big files inside the compressed archive are placed in the same directory and override each other during extraction.

This is research code, and its primary purpose is to reproduce the scientific results that you see in our paper.

Hi,
I am new to deep learning. I want to do my research in Human Pose Estimation and want to run this code and understand how Dense Pose Estimation is working, but when I tried the code it gives me errors.
Ubuntu: 14.04
Tensorflow: I have installed Tensorflow by anaconda3 and I run this command to print the version:
python -c 'import tensorflow as tf; print(tf.version)'
output: 0.9.0
Python: 3.6

@kanza-ali your problem is related with CUDA. check cuda installation, and cuda paths. you should upgrade your cuda version to 9.0.
https://docs.nvidia.com/cuda/cuda-installation-guide-linux/index.html


555: Add support for Python 3.9

Closes #555
Why is this the best possible solution? Were any other approaches considered?
A GitHub Actions yaml file was in place already with a release job for creating a build with Py3.8 and linux (ubuntu) and uploading it to PyPI. This PR updates the yaml to add jobs for:

lint, with Py3.8 on linux, by running black, isort, flake8, and pycodestyle
test, with Py3.7, 3.8, and 3.9 on linux, macos, and windows, by running nosetests

At the end of the test job the sdist and wheel are uploaded as Artifacts (example here).

The above more or less covers what the AppVeyor and CircleCI configurations are doing. So if this all looks good I could add removal of those CI dotfiles to this PR to close out #568 as well.
Some minor changes were required for Py3.9 compatibility. These are noted in e9c77ab and 3b21ce9, and involved removing a method call and a kwarg which were deprecated since Py3.2 and Py3.1 respectively.
What are the regression risks?
Unlikely, but maybe the test CI environments are slightly different. But the tests pass all the same.
Does this change require updates to documentation? If so, please file an issue here and include the link below.
No, it would only affect developers.
Before submitting this PR, please make sure you have:

[x] included test cases for core behavior and edge cases in tests
[x] run nosetests and verified all tests pass
[x] run black pyxform tests to format code
[x] verified that any code or assets from external sources are properly credited in comments

Codecov Report

Merging #580 (3b21ce9) into master (bb2497d) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #580   +/-   ##
=======================================
  Coverage   83.59%   83.59%
=======================================
  Files          25       25
  Lines        3761     3761
  Branches      930      930
=======================================
  Hits         3144     3144
  Misses        474      474
  Partials      143      143

Impacted Files
Coverage Δ

pyxform/utils.py
78.08% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb2497d...3b21ce9. Read the comment docs.

./.circleci/config.yml and ./appveyor.yml have been deleted so these checks failed. ./.coveragerc also deleted.