[WIP] api docs: Document the /users/me/<stream_id>/topics endpoint.

Testing Plan: Made sure the docs display correctly and test-api passed.

Renaming this as WIP since I don't know what's happening with the tests yet.
I also have the feeling that the changes in requirements/ have to be improved somehow. Maybe merging all the deps that are duplicate in common, dev and prod into common? Only modifying common.in wasn't causing any effects when I tried it, so I guess that dev.txt overrides the deps we have there.

@timabbott, @YagoGG: It may not be an internal mypy thing, but that's just what happened to break when I tested this locally. I can't see why this PR would cause the build failures here though.

Updated the PR after addressing your comments, @eeshangarg. Thanks for reviewing!

Updated the PR to fix the requirements as discussed in Zulip.

The mypy error is interesting; I'm debugging.

I fixed the mypy thing (was unrelated consequence of the upgrade).  I also merged the first two commits.  You should do a separate commit for the upgrade, since that's mergable now (and it'd be nice to separate it from the rest).
I can't merge the new /topics docs because the max_message_id values are randomly determined every time one does populate_db, so that test won't pass for other folks' systems.  I think we'll need to do a mock or something in the API test for that feature to work around the issue...

I think probably we just need to have the test be tolerant of any int in those positions, rather than requiring the exact value.  That, or the test needs to do a database query to get the right answers.
@eeshangarg any ideas on how to configure that behavior?

I was thinking about something similar to the DB query, but using the bindings themselves: using them to fetch the corresponding IDs, and then modify the fixture after loading it into memory.
Anyways, is there any reason in special why we don't make do-destroy-rebuild* always produce the same result?

Basically, the content of the development environment test messages is randomly generated because you kinda want some variability.  We maintain some consistency on a given machine, but it's painful to manage keeping the randomization constant as we expand what goes in the dev environment.
I think we could potentially have a deterministic template database used for this test (I think we basicall do that with that backend and casper tests...).

We can bear with some duplication (like the code currently in this PR, that shows description both in the OpenAPI and Markdown files), or implement a reader for the responses like we've done with other fields (like the arguments, for instance).

My opinion is that our priority is to have decent docs, and using the OpenAPI format is very much secondary (in part because I'm not sure we'll ever end up displaying the OpenAPI files directly).
But yes, if we wanted to share the descriptions, we'd want to do something like the fixture thing.

Thanks for reviewing, @timabbott! I just updated the PR addressing your comments.
mypy does seem to be complaining about the zulip imports, both in code I've touched and code I haven't. I tried dropping the python-zulip-api upgrade commit just to check if it's what you were talking about, but it seems to be unrelated.

I merged the first two commits.  The last bit is blocked on that mypy thing, which I'm hoping to debug via  #9487.


Light Client: Evidence reporting

Closes #217

[ ] Referenced an issue explaining the need for the change
[ ] Updated all relevant documentation in docs
[ ] Updated all code comments where relevant
[ ] Wrote tests
[ ] Updated CHANGES.md

That didn't work as expected, will close this and open a new one with the cherry-picked commits.


Fix login with python-bcrypt 2.0 (issue #6)

This commit fixes issue #6.
I don't know if it will work with existing passwords already in database. But It works. :)

Will merge after I test this with an existing database. Not willing to break passwords for existing databases.

Okay, thanks!


Made most __device__ functions/methods __host__ __device__

Is blocked by #8. Current branch (host-device_instead_of_device) is based on move_copy_mechanisms, so the corresponding PR should be approved before approving this, and new commits at move_copy_mechanisms should be merged into this branch if there are any
I think it's wrong to make most functions/methods __device__ only because if their parameters are allocated in host memory, they should be executed on host. This enhancement also makes it possible to perform some object setup while it's in host memory and then copy it to device memory (before it was only possible to create an object in device memory and set it up there). However, it's absolutely ok if some function used in setup or simulation uses some CUDA feature(s) and therefore is made __device__ only (of course, it also requires all "parent" functions (which call that function) to be __device__ either)

I haven't edited SimulationMap, because it has a __global__ method friend function, so I'd say SimulationMap is designed to only exist in device memory, but probably I'm wrong


Use routes to implement regex in service url ?

Routes:
https://pypi.python.org/pypi/Routes
Should be very easy to do. But before that I need to figure out an issue:
What is the 'name' attribute in StackInABoxService used for ?

@tonytan4ever 'name' is used to identify the service, and becomes part of the URL.
For instance: https://github.com/BenjamenMeyer/openstackinabox/blob/master/openstackinabox/services/keystone/v2.py - the name keystone/v2.0 identifies the service as providing Keystone v2.0 and places the service URL root at http://localhost/keystone/v2.0/.
StackInABox matches on partial strings:

First match matches http://localhost to determine which URLs get picked up by StackInABox
Second match is against the service name, e.g keystone/v2.0
The route is then extracted (https://github.com/BenjamenMeyer/stackInABox/blob/master/stackinabox/stack.py#L149) and mapped against the service object (https://github.com/BenjamenMeyer/stackInABox/blob/master/stackinabox/services/service.py#L80), also typically called the URL Path. It will not contain any of the information from the first two matches. For instance, http://localhost/keystone/v2.0/tenants the route portion will only be /tenants.

The HTTP Verb is mapped after the route it mapped, that is the same pattern match for the route can have multiple HTTP Verbs (GET, PUT, MyNewHttpVerb, etc) mapped to it through individual registrations.

FYI - please keep in mind the minimal dependency. I'm okay with pulling some things in, but I don't want things to be too complex or get in the way of what is being tested.
routes pulls in two things: webob (for its middleware, and not installed by default) and respoze.lru (for its mapping, installed by default).

PR #24 satisfies this enough for release 0.8

give then minimal dependency goal I don't think we'll end up using routes so closing this out for now. We can re-open if we want to continue any discussion on this.


Set limits for how much memory docker build can use

This prevents builds from gobbling all the RAM on a node!

Merged!

https://travis-ci.org/jupyter/repo2docker/jobs/309908787 this is the build for the merge. Deploy failed. :-/


Migrated http_ipv6_test from SDK.

Travis is having issues with binding to the IPv6 loopback adapter. Following the issue here.

@zanderso, looks like I've managed to enable IPv6 for our Travis instances. PTAL.


evdev_read callback denies non-zero ABS_MT_TRACKING_ID in touchscreen.

Sorry for my english first because english is not my first language :(
I'm new in embedded part, and also new in LVGL. Not that old in programming, actually.
I've tried to write simple sample code that rotates image with screen touch, but it doesn't work after first touch.
Plus, it doesn't work at all if I touch screen before app starts.
So I assumed it my code's problem, and uploaded to my board demo app already exists - but it also have same symptom.
I tried to debug as insert printf() at many points, and I found these lines in evdev.c. (152 - 157)
            else if(in.code == ABS_MT_TRACKING_ID) {
                                if(in.value == -1)
                                    evdev_button = LV_INDEV_STATE_REL;
                                else if(in.value == 0)
                                    evdev_button = LV_INDEV_STATE_PR;
            }

So I searched linux documents about that flag, and found this section. Multi-touch Protocol, 3.2. Protocol Usage.

For type B devices, the kernel driver should associate a slot with each identified contact, and use that slot to propagate changes for the contact. Creation, replacement and destruction of contacts is achieved by modifying the ABS_MT_TRACKING_ID of the associated slot. A non-negative tracking id is interpreted as a contact, and the value -1 denotes an unused slot. A tracking id not previously present is considered new, and a tracking id no longer present is considered removed. Since only changes are propagated, the full state of each initiated contact has to reside in the receiving end. Upon receiving an MT event, one simply updates the appropriate attribute of the current slot.

Some devices identify and/or track more contacts than they can report to the driver. A driver for such a device should associate one type B slot with each contact that is reported by the hardware. Whenever the identity of the contact associated with a slot changes, the driver should invalidate that slot by changing its ABS_MT_TRACKING_ID. If the hardware signals that it is tracking more contacts than it is currently reporting, the driver should use a BTN_TOOL_*TAP event to inform userspace of the total number of contacts being tracked by the hardware at that moment. The driver should do this by explicitly sending the corresponding BTN_TOOL_*TAP event and setting use_count to false when calling input_mt_report_pointer_emulation(). The driver should only advertise as many slots as the hardware can report. Userspace can detect that a driver can report more total contacts than slots by noting that the largest supported BTN_TOOL_*TAP event is larger than the total number of type B slots reported in the absinfo for the ABS_MT_SLOT axis.

and it also says type A devices has been deprecated at section 3.1:

Note
MT protocol type A is obsolete, all kernel drivers have been converted to use type B.

So I understand it as ABS_MT_TRACKING_ID should increase for identify each touch events - at least to multi-touch device - so I tried to evtest. and this is result. It seems too long but I didn't cut because If upper section of device helps:
No device specified, trying to scan all of /dev/input/event*
Available devices:
/dev/input/event0:      gpio_keys_polled
/dev/input/event1:      ssd253x
Select the device event number [0-1]: 1
Input driver version is 1.0.1
Input device ID: bus 0x18 vendor 0x0 product 0x0 version 0x0
Input device name: "ssd253x"
Supported events:
  Event type 0 (EV_SYN)
  Event type 1 (EV_KEY)
    Event code 330 (BTN_TOUCH)
  Event type 3 (EV_ABS)
    Event code 0 (ABS_X)
      Value      0
      Min        0
      Max      799
    Event code 1 (ABS_Y)
      Value      0
      Min        0
      Max      479
    Event code 47 (ABS_MT_SLOT)
      Value      0
      Min        0
      Max        9
    Event code 53 (ABS_MT_POSITION_X)
      Value      0
      Min        0
      Max      799
    Event code 54 (ABS_MT_POSITION_Y)
      Value      0
      Min        0
      Max      479
    Event code 57 (ABS_MT_TRACKING_ID)
      Value      0
      Min        0
      Max    65535
    Event code 58 (ABS_MT_PRESSURE)
      Value      0
      Min        0
      Max       16
Properties:
  Property type 1 (INPUT_PROP_DIRECT)
Testing ... (interrupt to exit)
Event: time<PHONE_NUMBER>.958962, type 3 (EV_ABS), code 57 (ABS_MT_TRACKING_ID), value 9
Event: time<PHONE_NUMBER>.958962, type 3 (EV_ABS), code 53 (ABS_MT_POSITION_X), value 398
Event: time<PHONE_NUMBER>.958962, type 3 (EV_ABS), code 54 (ABS_MT_POSITION_Y), value 209
Event: time<PHONE_NUMBER>.958962, -------------- EV_SYN ------------
Event: time<PHONE_NUMBER>.975913, type 3 (EV_ABS), code 58 (ABS_MT_PRESSURE), value 11
Event: time<PHONE_NUMBER>.975913, -------------- EV_SYN ------------
Event: time<PHONE_NUMBER>.985108, type 3 (EV_ABS), code 53 (ABS_MT_POSITION_X), value 397
Event: time<PHONE_NUMBER>.985108, type 3 (EV_ABS), code 54 (ABS_MT_POSITION_Y), value 208
Event: time<PHONE_NUMBER>.985108, type 3 (EV_ABS), code 58 (ABS_MT_PRESSURE), value 9
Event: time<PHONE_NUMBER>.985108, -------------- EV_SYN ------------
Event: time<PHONE_NUMBER>.002052, type 3 (EV_ABS), code 54 (ABS_MT_POSITION_Y), value 207
Event: time<PHONE_NUMBER>.002052, type 3 (EV_ABS), code 58 (ABS_MT_PRESSURE), value 5
Event: time<PHONE_NUMBER>.002052, -------------- EV_SYN ------------
Event: time<PHONE_NUMBER>.011285, type 3 (EV_ABS), code 53 (ABS_MT_POSITION_X), value 394
Event: time<PHONE_NUMBER>.011285, type 3 (EV_ABS), code 54 (ABS_MT_POSITION_Y), value 205
Event: time<PHONE_NUMBER>.011285, type 3 (EV_ABS), code 58 (ABS_MT_PRESSURE), value 1
Event: time<PHONE_NUMBER>.011285, -------------- EV_SYN ------------
Event: time<PHONE_NUMBER>.024135, type 3 (EV_ABS), code 57 (ABS_MT_TRACKING_ID), value -1
Event: time<PHONE_NUMBER>.024135, -------------- EV_SYN ------------
Event: time<PHONE_NUMBER>.874388, type 3 (EV_ABS), code 57 (ABS_MT_TRACKING_ID), value 10
Event: time<PHONE_NUMBER>.874388, type 3 (EV_ABS), code 53 (ABS_MT_POSITION_X), value 413
Event: time<PHONE_NUMBER>.874388, type 3 (EV_ABS), code 54 (ABS_MT_POSITION_Y), value 213
Event: time<PHONE_NUMBER>.874388, -------------- EV_SYN ------------
Event: time<PHONE_NUMBER>.891331, type 3 (EV_ABS), code 54 (ABS_MT_POSITION_Y), value 214
Event: time<PHONE_NUMBER>.891331, type 3 (EV_ABS), code 58 (ABS_MT_PRESSURE), value 11
Event: time<PHONE_NUMBER>.891331, -------------- EV_SYN ------------
Event: time<PHONE_NUMBER>.908274, type 3 (EV_ABS), code 58 (ABS_MT_PRESSURE), value 9
Event: time<PHONE_NUMBER>.908274, -------------- EV_SYN ------------
Event: time<PHONE_NUMBER>.942142, type 3 (EV_ABS), code 54 (ABS_MT_POSITION_Y), value 213
Event: time<PHONE_NUMBER>.942142, type 3 (EV_ABS), code 58 (ABS_MT_PRESSURE), value 5
Event: time<PHONE_NUMBER>.942142, -------------- EV_SYN ------------
Event: time<PHONE_NUMBER>.959085, type 3 (EV_ABS), code 54 (ABS_MT_POSITION_Y), value 211
Event: time<PHONE_NUMBER>.959085, type 3 (EV_ABS), code 58 (ABS_MT_PRESSURE), value 1
Event: time<PHONE_NUMBER>.959085, -------------- EV_SYN ------------
Event: time<PHONE_NUMBER>.965738, type 3 (EV_ABS), code 57 (ABS_MT_TRACKING_ID), value -1
Event: time<PHONE_NUMBER>.965738, -------------- EV_SYN ------------
Event: time<PHONE_NUMBER>.638183, type 3 (EV_ABS), code 57 (ABS_MT_TRACKING_ID), value 11
Event: time<PHONE_NUMBER>.638183, type 3 (EV_ABS), code 53 (ABS_MT_POSITION_X), value 436
Event: time<PHONE_NUMBER>.638183, type 3 (EV_ABS), code 54 (ABS_MT_POSITION_Y), value 185

Most of ABS_MT_TRACKING_ID seems to have non-zero value - so I changed evdev.c to following lines:
            else if(in.code == ABS_MT_TRACKING_ID) {
                                printf("in.code is ABS_MT_TRACKING_ID: %d\n", in.value);
                                if(in.value == -1)
                                    evdev_button = LV_INDEV_STATE_REL;
---                                else if(in.value == 0)
+++                                else
                                    evdev_button = LV_INDEV_STATE_PR;
            }

Because I thought all of non-negative value of ABS_MT_TRACKING_ID means touchscreen has pressed.
And then I tested my app and demo app again - It works fine.
I think it could be merge to origin because it will be no harm, but I'll be appreciated to tell me if I missed something or wrong.

Nevermind. It was device's malfunction :( ABS_MT_TRACKING_ID has to be clear when touch releases but strangely it doesn't. sorry to bother you

Happy to hear that it was resolved :slightly_smiling_face:


An error occurred during software account synchronization. Procedure

I changed my Microsoft email account, and the result is that vscode always prompts the following every time I open it
You have been deregistered because stored authentication information could not be read.

/duplicate https://github.com/microsoft/vscode/issues/145189
(It has slightly more information)


Version 16.4.6 is translated into Version 16.4。6 in zh_cn page

Link to article:
your page is worng
Problem:
Version 16.4.6 is translated into Version 16.4。6 in zh_cn page

fixed


Add hammerdb load generator

does not work on Arm64.

looks like hammerdb uses odbc and not jdbc.


Change the UI copy from Connections to Accounting

Details

Change a UI copy. Got a Spanish check for the UI copy.
Fixed Issues

$ https://github.com/Expensify/App/pull/38900#issuecomment-2039551368
PROPOSAL: N/A
Tests / QA Steps

Make sure that you're added to the accountingOnNewExpensify beta
Make sure that your account has a collect workspace. You can create a new workspace on New Expensify if you don't have any. Because of a recent change, any workspace you create on New Expensify is now a collect workspace.
Click on your avatar on the far right of the bottom tab -> Workspaces -> More features
Confirm that you see the Integrate/Accounting section below the Organize section. Ensure that the UI text for the menu item is Accounting as you can see in the screenshot below.

Offline tests
N/A
PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
Because this is a simple UI copy change, I tested only on the web browser on desktop
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/bondydaa in version: 1.4.61-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
cancelled 🔪

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/Julesssss in version: 1.4.61-8 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Not loading

Not sure what I have done wrong, but I copied the skin from the Skin Manipulator, brought it into my mc launcher, with optifine, on forge, and the mod itself loads just fine, just the tail texture doesn't sadly, any suggestions?

Please post the log .minecraft/logs/debug.log to Gist.

Closing due to no response and no actionable info in original report.


Make splitting the sidebar up in two sections possible

Something among these lines

The size of the containers should be adjustable.
I was thinking of having right click assign the secondary menu since I don't see when you'd want to do this on a phone.

Another idea actually, allowing users to slide the buttons around on the bar and if gets dragged down a certain amount it spawns the second menu. This method would also make this feature available on thinner screen (phones).


Tensor::dropout2d bindings not generated?

It seems like no bindings are created for Tensor::dropout2d (or higher dimensions). I'm probably missing something, but is there a way to currently achieve this in tch-rs? Or, would it be possible to generate these bindings? Also, do you think it would make sense to generate dropout modules in tch::nn, similar to the Python API?
I've found #136, is the process described there still up-to-date? If the process does not involve too much knowledge of OCaml, I could also try adding these bindings, maybe with a little bit of help from your side.
Regardless, I wanted to thank you again for creating this crate. It continues to be of tremendous value to me and my research.

Looking at the Pytorch implementation of torch.nn.functional.dropout2d (which is used by torch.nn.Dropout2d), we should be able to just call tch::Tensor::feature_dropout without generating the bindings.

Indeed there doesn't seem to be anything specific for this in the C++ api that tch-rs binds to. The feature_dropout is properly generated and hopefully should do the trick.
If you think it would be convenient to have some dropout2d/dropout3d functions in the nn module so that it's easier to discover these, this should be straightforward (maybe dropout should also be added there in this case).

I'll work with feature_dropout a bit.

If you think it would be convenient to have some dropout2d/dropout3d functions in the nn module so that it's easier to discover these, this should be straightforward (maybe dropout should also be added there in this case).

Once, I'm confident that it works as expected I will open a PR.

@LaurentMazare Could we get binding generation process documented? Even though we have a Makefile at the root, it requires  OCaml toolchain. Potential contributors may not have knowledge about it.


chore: update viem

Update viem to 1.0.2
Question
Should we keep the previous partial decode behavior in decodeEventLog or let it throw error when not conform to the ABI
https://viem.sh/docs/migration-guide.html#minor-decodeeventlog-behavior-change

It should be fine to let it throw, as we don't have any cases where we partially decode.


Update country codes

Hi,
I've made a few updates to the international dialling code data (country_code in countries.yaml) and wondered if you'd consider adding them in?
Some countries had missing country_code data as follows:

IM: Isle of Man (44)
IO: British Indian Ocean Territory (246)
BL: Saint Barthélemy (590)
EH: Western Sahara (212)
GG: Guernsey (44)
JE: Jersey (44)
AQ: Antarctica (672)
MF: Saint Martin (590)
AX: Åland Islands (358)
GS: South Georgia and the South Sandwich Islands (500)

and the following weren't right:

CX: Christmas Island (change from 610 to 61)
PN: Pitcairn (change from 872 to nothing)

The data source I've used is http://en.wikipedia.org/wiki/List_of_country_calling_codes
Thanks very much,
Deb

Thank you for the updates!


Wrong locale evaluation on Unix-like systems without codeset but with modifier

According to this specification, the POSIX locale is defined as:
language[_territory][.codeset][@modifier]

For example, the locale De_DE@dict is valid.
However, the current implementation of the library does not check for the @ character, leading to an invalid locale detection when the codeset is not present but the modifier is.
Example:
let fr_FR_euro = "fr_FR@euro".to_owned();
let mut env = MockEnv::new();
env.insert("LANGUAGE".into(), fr_FR_euro);
env.insert("LC_ALL".into(), fr_FR_euro);
env.insert("LC_MESSAGES".into(), fr_FR_euro);
env.insert("LANG".into(), fr_FR_euro);
env.insert("LC_CTYPE".into(), fr_FR_euro);
let locale = _get(&env);
// locale is equal to "fr-FR@euro" which is not a valid BCP 47 locale

The simplest possible solution would be:

[ ] Crop the POSIX locale at the minimum index of . and @ characters.

However, since some POSIX modifiers might be convertible to BCP 47, a more complex solution would be:

[ ] Implement full support for POSIX modifiers, meaning the library would use the modifier information to form the resulting BCP 47 locale.

Implement full support for POSIX modifier

Do you have a rough idea what this would entail? This is an area I'm not familiar with. The level 2 canonicalization described here look close to what you are mentioning, but I'm not 100% sure!
Generally I'd be fine making this handling more robust at the cost of complexity as long as we don't need to drag in any large ICU crates to handle bundling various chunks of locale/region data used for mapping correctly.

Do you have a rough idea what this would entail? This is an area I'm not familiar with. The level 2 canonicalization described here look close to what you are mentioning, but I'm not 100% sure!

I'm not an expert it this field either. The link that you attached is about ICU locales. As I understand it, this is the third locale type along with POSIX and BCP 47.
Your library is working with BCP 47 locales, as far as I know, so the conversion algorithm should be different.
For now I'm unsure, what the algorithm should be exactly.
Some useful links for further investigation:

The Open Group Base Specifications Issue 7, 2018 edition 7. Locale: https://pubs.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap07.html (old version)
The Open Group Base Specifications Issue 7, 2018 edition 8. Environment Variables: https://pubs.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap08.html (old version)
The Open Group Base Specifications Issue 8 7. Locale: https://pubs.opengroup.org/onlinepubs/9799919799/basedefs/V1_chap07.html (new version)
The Open Group Base Specifications Issue 8 8. Environment Variables: https://pubs.opengroup.org/onlinepubs/9799919799/basedefs/V1_chap08.html (new version)
BCP 47 specification: https://www.ietf.org/rfc/bcp/bcp47.html
BCP 47 extensions: https://github.com/unicode-org/cldr/tree/main/common/bcp47

Your library is working with BCP 47 locales, as far as I know, so the conversion algorithm should be different.

The reason I mentioned it is because the ICU one appears incredibly similar to the BCP47 format and places like MSDN say "This format is used by Windows and many other environments, including ... ICU, ...". The ICU formalization seems to have, at minimum, cribbed the region code variants and handling.
If the above holds up (I could try doing a more detailed comparison), then this statement is valid for sys-locale's considerations because we are parsing POSIX locales:

Level 2 canonicalization is designed to translate POSIX and .NET IDs, as well as nonstandard ICU locale IDs.

This should be reopened due to the unresolved conversation about POSIX to BCP 47 modifiers conversion.

Whoops, you're right. The GitHub autoclose syntax grabbed it by mistake in your PR.

That's because I wrote "partially resolves ..." there.
GitHub didn't recognize the word "partially".


default leafHost/leafPort to null

@xhl1988 Could you please take a look? Thanks

@mmchen we can remove the migrator related code in https://github.com/uber/kafka-logger/blob/c0f2494cb53d0139b99613ba3e8f9722b93ad3e1/index.js#L114

@Raynos Could you please help take a look at this?

@xhl1988 Done

lgtm


Server still runs on SPA if there's a store

Describe the bug
Reproduction

Files
Error
Real-world code

Logs
System Info
Severity
Additional Information

Describe the bug
So basically the issue is that ive turned my application into an SPA mode app and i know everything is set correctly. everything is working fine and its all clientside until all of these things happen at once:

A export const load: PageLoad = async ({ params }) => { on a page
This load function imports a writable store
The page is refreshed

Some of the code will then run in the server. Because stores are volatile, step 3 makes it so the store gets initiated again but on the server. Say you have writable(myInit()), this will run on clientside like a good SPA until you refresh it. Then myInit() will run in the server, and probably a lot of the rest of the code.
The problem i'm having is that for some reason step 1 and 2 make it so the store init runs serverside even though it shouldnt be. On first load it runs clientside properly, it only happens if you refresh the page.
Reproduction
Files
Say you have the following code in lib/store.ts:
// lib/store.ts
import { writable } from "svelte/store";

export interface YarkStore { x: string, y: string, z: string }

export const yarkStore = writable(yarkStoreInitial())

function yarkStoreInitial(): YarkStore {
    console.log("You should see this in inspect element, not in the server console!!!")
    let x = window.localStorage.getItem("just_an_example") // <-- this wont work if running on server
    return /** code below and then return here */
}

Then this is accessed in some route which has a load function that uses the store (+page.ts):
import { get } from "svelte/store";
import { yarkStore } from "$lib/store";

export const load: PageLoad = async ({ params }) => {
    const store = get(yarkStore)
    // more stuff
}

Error
The first time the app runs and the page it loaded (through first load or through navigating to the page), the app will work fine. However, if you refresh the page the store will run on the server even though it's an SPA app. This will give the following error in the server console:
You should see this in inspect element, not in the server console!!!
ReferenceError: window is not defined
    at yarkStoreInitial (/Users/owen/Projects/yark/yark-pages/src/lib/store.ts:29:24)
    at /Users/owen/Projects/yark/yark-pages/src/lib/store.ts:12:34
    at async instantiateModule (file:///Users/owen/Projects/yark/yark-pages/node_modules/vite/dist/node/chunks/dep-5e7f419b.js:52224:9)

Attached is a video of me navigating to a the affected page, this happens when I click the poland button. It works the first time because the store loaded in the clientside, but the second time doesnt work because I refreshed the page and it's now running serverside for some reason:
https://user-images.githubusercontent.com/30081702/217298492-77d4a2e7-5c23-4a77-b09d-0e55a314f61b.mov
(See console at bottom at 9 seconds in)
Real-world code

The store.ts library file: https://github.com/Owez/yark/blob/sveltekit/yark-pages/src/lib/store.ts
The +page.ts file: https://github.com/Owez/yark/tree/sveltekit/yark-pages/src/routes/archive/[kind]

To run this code, clone https://github.com/Owez/yark and then run the following commands with Python 3.11 installed:

pip3 install poetry
cd yark-api
poetry install
poetry run poe dev

Then, open a new terminal and then run the following commands to launch the actual GUI:

cd yark-pages
npm install
npm run tauri dev

Once you've done this, press the load panel and import any random folder and give it a name; once you press the button youll be on the trouble page. Sorry about the Python steps, they're needed to get the API up and running.
Logs
BROWSER LOGS
============
Everything up to and including the warning was before a page refresh. I think the warning is weird, but the warning here is happening when `window` is available and everything else works alright so I'm not sure.
Logs here:
https://ibb.co/6HVGWdh

SERVER LOGS
===========

owen@Owens-MacBook-Air yark-pages % npm run tauri dev

><EMAIL_ADDRESS>tauri
> tauri dev

     Running BeforeDevCommand (`npm run dev`)

><EMAIL_ADDRESS>dev
> vite dev

  VITE v4.0.4  ready in 505 ms

  ➜  Local:   http://localhost:5173/
  ➜  Network: use --host to expose
        Info Watching /Users/owen/Projects/yark/yark-pages/src-tauri for changes...
   Compiling app v0.1.0 (/Users/owen/Projects/yark/yark-pages/src-tauri)
    Finished dev [unoptimized + debuginfo] target(s) in 3.53s
4:12:10 PM [vite-plugin-svelte] ssr compile done.
package         files     time     avg
yark-pages          1   25.1ms  25.1ms
You should see this in inspect element, not in the server console!!!
ReferenceError: window is not defined
    at yarkStoreInitial (/Users/owen/Projects/yark/yark-pages/src/lib/store.ts:25:24)
    at /Users/owen/Projects/yark/yark-pages/src/lib/store.ts:12:34
    at async instantiateModule (file:///Users/owen/Projects/yark/yark-pages/node_modules/vite/dist/node/chunks/dep-5e7f419b.js:52224:9)

System Info
ABOUT
=====

Macbook Air from 2021, the same thing happens on another NixOS computer.

SYSTEM INFO
===========

  System:
    OS: macOS 12.5.1
    CPU: (8) arm64 Apple M1
    Memory: 123.59 MB / 8.00 GB
    Shell: 5.8.1 - /bin/zsh
  Binaries:
    Node: 18.12.1 - /usr/local/bin/node
    npm: 8.19.2 - /usr/local/bin/npm
  Browsers:
    Firefox: 109.0.1
    Safari: 15.6.1
  npmPackages:
    @sveltejs/adapter-auto: ^1.0.0 => 1.0.2
    @sveltejs/adapter-static: ^1.0.0-next.50 => 1.0.0-next.50
    @sveltejs/kit: ^1.0.0 => 1.3.1
    svelte: ^3.54.0 => 3.55.1
    vite: ^4.0.0 => 4.0.4

Severity
blocking all usage of SvelteKit
Additional Information
The SPA config I used is from the docs with static files also included. Here's my relevant svelte config:
import adapter from '@sveltejs/adapter-static';
// etc..
		adapter: adapter({
			fallback: 'index.html',
			pages: 'build',
			assets: 'build',
		}),

And in routes/+layout.ts I've got a simple export const ssr = false. This has been working fine up to this point and everywhere with window has been rendering on the client until this issue.
I'm using Tauri for filesystem stuff which is why I need an SPA. I think Tauri has a very low chance of being the problem here, as it just runs the stock sveltekit dev server as if i was doing npm run dev.

Please provide a minimal reproduction - not just a few files - and not one that involves installing all of the dependencies of your app.
That said, top-level stores on the server side like what you're doing are a bad idea because they will be shared across all users of the app. And even if you're building your production app as an SPA, the adapter you're using is ignored in dev mode. There will always be a server-side component of your application, which will share this state across all users (and across page reloads).

Soved with https://github.com/Owez/yark/pull/111


docs: should not need index files in every parent sidebar element

From https://github.com/iterative/dvc.org/issues/727#issuecomment-545756811

Using  "source": false, on sidebar.json doesn't work unless it is the top level (e.g. understanding-dvc)... It breaks the engine.
Consider also automatically generating a list of H2s in child documents when no source field is used for a parent slug.

index.js -> index.md? (or actually just index file, since it can have a custom name). Also, I would mention that source: false should be just working for 2+ level of the items in sidebar.

source: false should only be working for 2+ level of the items in sidebar

Why not the top level as it works now, @shcheklein? Maybe I'm not getting this comment.

oh, it's my "russian" english when I'm typing too quick :) ... what I wanted to say is that source: false must work for all levels, including top level.


Error while importing a federated component in a single spa app

So what i am trying to do is to import a federated module (mfe-component/TestComponent)  to my single-spa application (single-spa-child). The implementation can be found here.
Overview of the repo
mfe-component contains TestComponent that is exposed using module federation.
single-spa-host is the root config for single spa application.
single-spa-child is a single spa application that consumes TestComponent using module federation.
The Issue
The issue here is that ,the application loads fine when the federated component isnt using any hooks. However, the moment we introduce hooks , we get the below error
Error: Invalid hook call. Hooks can only be called inside of the body of a function component. This could happen for one of the following reasons:
1. You might have mismatching versions of React and the renderer (such as React DOM)
2. You might be breaking the Rules of Hooks
3. You might have more than one copy of React in the same app
See https://reactjs.org/link/invalid-hook-call for tips about how to debug and fix this problem.
    at resolveDispatcher (react.development.js:1440)
    at useState (react.development.js:1470)
    at TestComponent (TestComponent.jsx:21)
    at we (react-dom.production.min.js:84)
    at He (react-dom.production.min.js:97)
    at zj (react-dom.production.min.js:228)
    at Th (react-dom.production.min.js:152)
    at tj (react-dom.production.min.js:152)
    at Te (react-dom.production.min.js:146)
    at react-dom.production.min.js:61

mfe-component/TestComponent.jsx (the federated component)
import React, {useState} from 'react'

export default function TestComponent() {
  const [count,setCount] = useState(0)
  return (

      Hi,you are in test component.You have successfully federated
      TestComponentModule

  )
}

mfe-component/webpack.config.js
.
.
.
  },
  plugins: [
    new ModuleFederationPlugin({
      name: 'MFApp',
      filename: 'remoteEntry.js',
      library: { type: 'var', name: 'MFApp' },
      exposes: {
        './TestComponent': './src/TestComponent.jsx'
      },
      shared: {
        react: {
          eager: true,
          singleton: true,
          strictVersion: true,
          requiredVersion: deps.react
        },
        'react-dom': {
          eager: true,
          singleton: true,
          strictVersion: true,
          requiredVersion: deps['react-dom']
        },
        'react-router-dom': {
          eager: true,
          singleton: true,
          strictVersion: true,
          requiredVersion: deps['react-router-dom']
        }
      }
    }),
    new HtmlWebpackPlugin({
      template: './public/index.html',
    }),
  ],
.
.
.

single-spa-child/webpack.config.js (the single-spa-app consuming the federated component)
const { merge } = require("webpack-merge");
const singleSpaDefaults = require("webpack-config-single-spa-react");
const ModuleFederationPlugin = require("webpack/lib/container/ModuleFederationPlugin");

const customConfig = {
  plugins: [
    new ModuleFederationPlugin({
      name: "single-spa-child",
      remotes: {
        MFApp: "MFApp@http://localhost:8081/remoteEntry.js"
      },
      shared: {
        react: {
          eager: true,
          singleton: true,
        },
        "react-dom": {
          eager: true,
          singleton: true,
        },
      },
    }),
  ],
};

module.exports = (webpackConfigEnv, argv) => {
  const defaultConfig = singleSpaDefaults({
    orgName: "dc",
    projectName: "single-spa-child",
    webpackConfigEnv,
    argv,
  });

  return merge(defaultConfig, customConfig);
};

single-spa-child/rootComponent.jsx (the single-spa-app consuming the federated component)
import React from 'react'
const TestComponent = React.lazy(() => import("MFApp/TestComponent"));

export default function Root(props) {
  return (
    <>

{props.name} is mounted as a single spa app!

      <React.Suspense fallback={
Loading...
}>
        <TestComponent />
      </React.Suspense>
    </>
  );

This error means that you have two separate instances of React on the page and you have a parent component using one instance of react but the child component using another instance of react.
The solution is to make sure react is a shared dependency so that it's not downloaded more than once. When using module federation, this is done in your webpack configs
The problem here isn't related to single-spa-react, so I'm closing this.


Minor borders/transparency update

I propose those minor updates:

button stroke: 3px width, 3% black (both dark and light mode)
transparent part of the button with sats: 3px width, 2% of brand color (both themes)
modal itselft: 3px width, 3% black for light theme and 3% white for dark theme

@rolznz seems like it, right?

I think so

Hello @stackingsaunter  Can you please tell me exactly in which place in the bitcoin connect website this changes needed?

It's not for a website, it's for the library/component itself (bitcoin connect button)

@stackingsaunter It is for the marked component in black color. Am I correct?

@stackingsaunter I am not clear what should be in here. Can  you please explain me a bit? You mean border with the word of stroke?


Move init.php to config.php

this makes more sense.
also, we're down to 5 files in the lib/ folder! :tada:

Killer. People always ask me where they should put things and this should help reduce some of that confusion :+1:


Invalid syntax and unterminated string literal? Running Reptyl on Windows 11

Running Reptyl with Windows 11 using PowerShell and Python 3.10, it seems some longer strings return a different answer.

Running Reptyl with Windows 11 using PowerShell and Python 3.10, it seems some longer strings return a different answer.
hello, yes this is a common error, I'm working on it. it simply means that the code generated by the request includes syntax errors. However, ask no questions but give orders. don't treat it as chatgpt but as a terminal


Convert data to source does not support preview

When Vorto tries to convert the data to the source preview is set to false. When you try to preview the content you will still see the preview version of the content (because that is what Vorto is trying to convert), but internal links in the RTE to unpublished content will not will work.

Pull request: https://github.com/mattbrailsford/umbraco-vorto/pull/56


function constructor name changed after bundled as a library

my webpack.config.js
module.exports = {
	mode: 'production',
	devtool: 'source-map',
	target: 'node',
	entry: './src/index',
	output: {
		libraryTarget: 'umd',
		path: path.resolve('./dist'),
		filename: 'index.js',
	},
	externals: nodeExternals(),
	module: {
		rules: [
			{
				test: /\.js?$/,
				use: 'babel-loader',
				exclude: '/node_modules/',
			},
		],
	},
};

creator.js
export function NError(fields) {
	if (!(this instanceof NError)) {
		return new NError(fields);
	}
	Object.keys(fields).forEach(key => {
		this[key] = fields[key];
	});
	Error.captureStackTrace(this, NError);
	return this;
}

test result in jest
     - Snapshot
    + Received

    - NError {
    + a {
        "category": "FETCH_NETWORK_ERROR",
        "code": "MOCKED_FETCH_NETWORK_ERROR_CODE",
        "message": "mocked fetch network error",
      }

here the constructor name NError has changed to a

It looks like you just deleted our lovely crafted issue template. It was there for good reasons. Please help us solving your issue by answering the questions asked in this template. I'm closing this. Please either update the issue with the template and reopen, or open a new issue.


Bug Fix for Reading Sit-and-stare WCS info

This PR addresses Issue #78 which reveals that the CDELT3 value of sit-and-stare files is 0.  This causes a SingularMatrixError when reading the WCS info into an astropy WCS object.  The solution is to change CDELT to 1e-10 in these cases.
In addition, this PR changes the output when reading single sit-and-stare files to IRISSpectrogramCube for each spectral window rather than an IRISSpectrogramCubeSequence since single sit-and-stare files are 3D, not 4D like for raster data.

ping @tiagopereira.  This PR addresses issue #78.  Will you give it a quick code review?  Feel free to take a look as well @byrdie

Hi @DanRyanIrish, sorry I haven't had time to look at this. Travelling and currently at a course for the rest of the week.

No problem @tiagopereira!


Consensys zkEVM - Linea is now able to be added

Since more data is released about Linea -> https://docs.linea.build/architecture it now can be documented

Hey !
If you have some time anytime soon, feel free to fill a PR ! :)

https://github.com/kkrt-labs/zk-evm-exploration/pull/11


robotidy --list doesn't list all supported transformers

Calling robotidy --list returns the following for version 1.2.0:
Run --desc <transformer_name> to get more details. Transformers:
NormalizeSeparators
DiscardEmptySections
MergeAndOrderSections
RemoveEmptySettings
AssignmentNormalizer
OrderSettings
OrderSettingsSection
AlignSettingsSection
AlignVariablesSection
NormalizeNewLines
NormalizeSectionHeaderName
NormalizeSettingName
ReplaceRunKeywordIf
SplitTooLongLine

This list doesn't include the SmartSortKeywords transformer.
It would also be good if this list is sorted before it is returned.

Thanks for your report, it's already fixed in https://github.com/MarketSquare/robotframework-tidy/issues/114 and it will be released in 1.3.0 - I will check if I can release it soon since we have few upcoming changes and I don't want people to trip over issues that are already fixed ;)


Add damage application to the combat tracker

In GitLab by @Asacolips on Jun 9, 2020, 09:27
Acceptance Criteria

[ ] Apply damage to selected targets, less armor (reduce armor by piercing)

In GitLab by @Asacolips on Jul 6, 2021, 17:03
Added damage buttons to chat cards in 1.1.0-beta1


EXISTS support...?

Any suggestions how you would implement a EXISTS?.
i.e.
select id, course_file, status_package from publications_course c
 where exists(select 1 from configurations_courseinstance i where i.id=:idInstance and
 ((i.start_date is null and i.end_date is null)
 or (i.end_date is null and i.start_date <= now())
 or (i.start_date is null and i.end_date >= now())
 or (now() between i.start_date and end_date))
 and i.course_id=c.id and
 exists(select 1 from configurations_userinstance where
 instance_id=i.id and exists(select 1 from
 academic_academicuser where id=student_id and username=:username)));

Regards

Am closing this due to lack of interest. I think the present solution (as outlined in the last comment) suffices.

@hiddentao Sorry to resurrect after so long. If I want to use data from the user inside my EXISTS subquery, is there a way I can parameterize that and join it with the rest of my parameterized query to help me avoid injection attacks? (Not necessarily important to this question, but my EXISTS will be in a .field().)

@raddevon Squel 5 has more flexible architecture which allows for unlimited parameterized query nesting, so with the latest squel (5.4.2) you should be able to do something like:
squel.select()
  .from('table')
  .where('b = ?', 4)
  .where(squel.str('EXISTS(?)', squel.select().from('blah').where('a = ?', 5)))
.toParam()

/*
{
    text: "SELECT * FROM table WHERE (b = ?) AND (EXISTS((SELECT * FROM blah WHERE (a = ?))))",
    values: [4,5]
*/


Question about data processing in pretrain data.

Why the following actions were taken. Is there anything special about cc12m I missed?
https://github.com/OFA-Sys/OFA/blob/a36b91ce86ff105ac8d9e513aa88f42b85e33479/data/pretrain_data/unify_dataset.py#L321-L323
Looking forward to your reply.

Another question.
When computing the loss AdjustLabelSmoothedCrossEntropyCriterion, sample_patch_num is added into the model input(sample[0], which I think is correspond to sample_v1, the vision-language data)
https://github.com/OFA-Sys/OFA/blob/a36b91ce86ff105ac8d9e513aa88f42b85e33479/criterions/label_smoothed_cross_entropy.py#L177-L178
It seems that sample_patch_num can select fixed number of image features. So why it's just used in VL data?
https://github.com/OFA-Sys/OFA/blob/a36b91ce86ff105ac8d9e513aa88f42b85e33479/models/ofa/unify_transformer.py#L759-L769


Fix vm2 import for browsers (ignore vm2 as it is not compatible)

Signed-off-by: Vincent de Chefdebien<EMAIL_ADDRESS>

Thanks for the PR! I see you're configuring browser-resolve in the package.json, but I can't find where you're actually using it. Shouldn't you call resolve() from jsSandbox.js?

In fact, I believe it works with webpack and browserify because these tools use enhanced-resolve and browser-resolve, respectively, hence processing the browser field in our package.json. Since this overloading of this field is not standard, maybe we should call resolve() from jsSandbox.js to avoid a case in which a user of docx-templates uses a tool that doesn't support that field.

I did some tests, and I cannot find a satisfying way of doing this ... So maybe the best solution is to add some directives in the documentation, and to update browserify and webpack examples to ignore vm2 at build time ?


DOC: Update tutorial notebook

Still need to update the section that uses load_bars_from_yahoo as that is deprecated, maybe with information about using a custom bundle with yahoo data? Or something more simple
The notebook changes are in line with the guidelines from Quantopian 2, using the migration guide
Otherwise, this should fix #1469 and #1614

Coverage decreased (-0.05%) to 87.359% when pulling 45736e180d7c482626810edfee8267f3d6697c4b on update-beginner-tutorial into 153f6636c7abea5cae11385da4d2fcdb63de93a1 on master.

Coverage increased (+0.02%) to 87.43% when pulling 978dbcc35039eb448dc4262286a307130f185f0a on update-beginner-tutorial into 153f6636c7abea5cae11385da4d2fcdb63de93a1 on master.

Coverage increased (+0.02%) to 87.429% when pulling dc405acde26cd2a473e42318ff9b219d953e3ac0 on update-beginner-tutorial into 153f6636c7abea5cae11385da4d2fcdb63de93a1 on master.

Coverage increased (+0.07%) to 87.485% when pulling eda12ee5f867941398bb5501dff2bc0853ed512b on update-beginner-tutorial into 153f6636c7abea5cae11385da4d2fcdb63de93a1 on master.

Changes Unknown when pulling 0e3e7472da3a4031390d055f071c9b55508dd093 on update-beginner-tutorial into ** on master**.

Coverage remained the same at 87.512% when pulling 0e3e7472da3a4031390d055f071c9b55508dd093 on update-beginner-tutorial into 123398d0e47f2087f545ca155aa5ee01a0c64c09 on master.

Coverage remained the same at 87.739% when pulling df776bbfab02666ee6bc17b5a61a66f819b91d33 on update-beginner-tutorial into ca26208569b1465cd86e8fba5c746ca96c32967e on master.

Coverage increased (+0.05%) to 87.547% when pulling 198d23ac0d16a7fb931e181774a5d7af0a518b90 on update-beginner-tutorial into c2e011440e87417e0d790ebfdd1a0d80da3efcfc on master.

Talked IRL with @richafrank to merge


Create tasks files

Split the constructions data set in tasks according to the task boundaries. In order to properly detect all the geometries inside a task boundary, it's necessary to mark the task number that each geometry belongs before simplifying it's applied to the data or the boundaries.
The task number should be in the task name of the file to upload and must follow the same order of the tasks in the geojson file for the tasks manager, so the final number of the task in the task manager matches with the corresponding task file to upload.

Urban tasks will contain buildings in or touching any zone of 'urban_zoning.geojson'.
Rustic tasks will contain buildings in any zone of 'rustic_zoning.geojson' if the building is not in any urban task.

Done in version 2017-06-07

Done in version 2017-06-07


To allow Windows compilation of sageattention v2: Update math.cuh

For windows to compile, had to modify "unsigned"

legendary


add conflicting taint to the logs

Following issue https://github.com/kubernetes-sigs/descheduler/issues/752, I updated the taint validation workflow to add logging of the taint blocking the pod eviction

This change will add more info in the verbose v=5 logs when pod toleration and taints does not align.
Sadly, this PR will not help the case described in the issue https://github.com/kubernetes-sigs/descheduler/issues/752 as we don't have a specific taint  associated with the rejection when the toleration and taint count mismatch

/ok-to-test

sorry for i don't have the permission to /ok-to-test, i review the code and lgtm actually.

@prune998 Thank you for the improvements. Would you mind squashing the commits into a single commit?

Isn't squash a parameter when merging ? :)
I'll do it ASAP

done @ingvagabund !

Isn't squash a parameter when merging ? :)

Unless it is configured by default. We label PRs and have the infra do the merging. Which is out of our control.

Thank You!!!
/lgtm
/approve

/test pull-descheduler-unit-test-master-master


Amount of magic for publishing metrics

Looking for feedback on how automatical publishing metrics should be?
Right now I have 2 approaches, a procedural, but verbose one and a magical macro one.
Here's the syntax for the two:
// FilesystemStore example.
impl<Fe: FileEntry> MetricsComponent for FilesystemStore<Fe> {
    fn gather_metrics(&self, c: &mut CollectorState) {
        c.publish(
            "read_buff_size",
            self.read_buffer_size,
            "Size of the configured read buffer size",
        );
        c.publish(
            "active_drop_spawns",
            &self.shared_context.active_drop_spawns,
            "Number of active drop spawns",
        );
        c.publish(
            "temp_path",
            &self.shared_context.temp_path,
            "Path to the configured temp path",
        );
        c.publish(
            "content_path",
            &self.shared_context.content_path,
            "Path to the configured content path",
        );
        c.publish("evicting_map", &self.evicting_map, "");
    }
}

// VerifyStore example.
impl MetricsComponent for VerifyStore {
    fn gather_metrics(&self, c: &mut CollectorState) {
        c.publish(
            "verify_size",
            self.verify_size,
            "If the verification store is verifying the size of the data",
        );
        c.publish(
            "verify_hash",
            self.verify_hash,
            "If the verification store is verifying the hash of the data",
        );
        c.publish(
            "size_verification_failures",
            &self.size_verification_failures,
            "Number of failures the verification store had due to size mismatches",
        );
        c.publish(
            "hash_verification_failures",
            &self.hash_verification_failures,
            "Number of failures the verification store had due to hash mismatches",
        );
    }
}

// MemoryStore example.
impl MetricsComponent for MemoryStore {
    fn gather_metrics(&self, c: &mut CollectorState) {
        c.publish("evicting_map", &self.evicting_map, "");
    }
}

The macro version would look like this:
// FilesystemStore example.
publish_metrics! {
    FilesystemStore<Fe> {
        evicting_map,
        read_buff_size "Size of the configured read buffer size" Bytes,
        shared_context {
            active_drop_spawns "Number of active drop spawns",
            temp_path "Path to the configured temp path",
            content_path "Path to the configured content path",
        }
    }
}

// VerifyStore example.
publish_metrics! {
    VerifyStore {
        verify_size "If the verification store is verifying the size of the data",
        verify_hash "If the verification store is verifying the hash of the data",
        size_verification_failures "Number of failures the verification store had due to size mismatches",
        hash_verification_failures "Number of failures the verification store had due to hash mismatches",
    }
}

// MemoryStore example.
publish_metrics! {
    MemoryStore {
        evicting_map,
    }
}

These two examples would do 100% identical things, except the macro one would also make it easy to denote the type (which is a bit tricky to do with the procedural one.
Thoughts?

cc: @chrisstaite-menlo

Oh, I do love the macros...

Although, it is going to be confusing because of the "magic" self... I think on second thoughts could you go half way...
impl<Fe: FileEntry> MetricsComponent for FilesystemStore<Fe> {
    fn gather_metrics(&self, c: &mut CollectorState) {
        publish_metrics!(
            c,
            {
                self.read_buffer_size "Size of the configured read buffer size",
                self.shared_context.active_drop_spawns, "Number of active drop spawns"
            }
         );
      }
}

If I was to go that far, I'd use something like:
impl<Fe: FileEntry> MetricsComponent for FilesystemStore<Fe> {
    fn gather_metrics(&self, c: &mut CollectorState) {
        publish!(c, read_buffer_size, "Size of the configured read buffer size");
        publish!(c, active_drop_spawns, "Number of active drop spawns");
      }
}

This would allow you to also do your custom stuff when needed.

Keep in mind though... This won't be a normal macro, this will require a procedural macro, which is way more difficult to understand, because it rewrites the AST tree.
I also considered something like this:
#[metrics]
pub struct SharedContext {
    // Used in testing to know how many active drop() spawns are running.
    // TODO(allada) It is probably a good idea to use a spin lock during
    // destruction of the store to ensure that all files are actually
    // deleted (similar to how it is done in tests).
    #[metric("Number of active drop spawns")]
    pub active_drop_spawns: AtomicU64,

    #[metric("Path to the configured temp path")]
    temp_path: String,

    #[metric("Path to the configured content path")]
    content_path: String,
}

#[metrics]
pub struct FilesystemStore<Fe: FileEntry = FileEntryImpl> {
    #[metric]
    evicting_map: EvictingMap<Arc<Fe>, SystemTime>,

    #[metric]
    shared_context: Arc<SharedContext>,

    #[metric("Size of the configured read buffer size")]
    read_buffer_size: usize,
}

I really like this idea, but it makes it incredibly difficult to do some edge case management.

Hmm hard question :sweat_smile: I wonder how complex a procedural macro publish_metrics actually is. If it roughly rewrites Option 2 to something like Option 1, it might be on the simpler side where we could get away with more-or-less straightforward templating. Then again, that's basically the same thing as implementing the traits explicitly.
From another angle, could a custom serde serializer/deserializer impl be useful here? With the container attributes that might allow behavior somewhat similar to the #[metric] approach. https://serde.rs/impl-serialize.html


Implement onGroupTransaction

Authored by @Neztore
Implement onGroupTransaction, resolves #307
Interval is set to 60 sec due to issues with very low rate limits.

This is amazing, cheers!


Tweak README

Goal: contextualize this package (especially compared to a normal SDK).

weird, it appears to have lost my comment? :(


Improve repo filtering

Reponames suffixed with -qa and -test are filtered out by default when listing repositories with no way to override from the CLI. Should show everything and/or allow the user to apply their own filters.

Should also fetch views, or make a separate subcommand view and --view options so they don't get mixed unintentionally leading to multiple searches on the same data when using wildcards that match both a view and repos included in that view


BarWidth doesn't affect width of Lollipop plot - 4.1

The Lollipop.BarWidth property does not affect line thickness. Similar problem in ClevelandDot.
Setting the BarWidth to be super wide compared to your data makes the axis data padding expand, so it's doing something.
After reading the Lollipop implementation thread #842 I'm still a bit confused why Bar is used instead of something like the Line in Scatterplots. Then we could use LineWidth.
I'm interested in working on this issue. If y'all think bars are still the way to go then no problem.
Example:
var plt = new ScottPlot.Plot();

var xs = new double[] { 2, 3, 4, 5 };
var ys = new double[] { 4, 5, 6, 7 };

var lp = plt.AddLollipop(xs, ys);
lp.BarWidth = 100.0;  // Doesn't change width

plt.SaveFig("D:\\lptest.png");

plt.Clear();
var cb = plt.AddClevelandDot(xs, ys);
cb.BarWidth = 5;  // Doesn't change width

plt.SaveFig("D:\\cdtest.png");

System Details

ScottPlot Version: 4.1.60
Operating System: Win10
Application Type: Both Console AND WPF
.NET Version: (.net 7.0)

Hi @benton-anderson, thanks for bringing this to our attention!
Not having an easy way to customize the step width seems to be an oversight. Based on your feedback here I added a LineWidth property to Lollipop and Cleveland plots which I believe resolves this issue (#2557). Feel free to offer additional suggestions for improvement if you have any!
ScottPlot.Plot plt = new(400, 300);
var lp = plt.AddLollipop(xs, ys);
lp.LineWidth = 5;
lp.LollipopRadius = 10;

ScottPlot.Plot plt = new(400, 300);
var cb = plt.AddClevelandDot(xs, ys);
cb.LineWidth = 5;
cb.DotRadius = 10;

Lollipop
Cleveland

I'm still a bit confused why Bar is used instead of something like the Line in Scatterplots ... I'm interested in working on this issue. If y'all think bars are still the way to go then no problem.

Knowing what we know now, I think if we created these plot types today we would do so without inheritance. I can see how the original implementer created a plot type for Y data which is evenly-spaced on the X axis, similar to bar plots. In practice it seems like it would have been more flexible if it didn't require inheritance and permitted arbitrary X values. Changing the API now risks breaking existing users, so I'm satisfied adding functionality to make it easier to use and taking the lessons learned here to ScottPlot 5 where we will permit breaking changes, and hopefully end-up with an easier to use and more extensible plot type.
Thanks again for your input, and feel free to reach out if you have any further questions or ideas for improvements! 🚀


Blender import crash due to spelling error

The glTF import is throwing an error due to a spelling error in the file "/glTF-Blender-IO/addons/io_scene_gltf2/blender/imp/gltf2_blender_gltf.py" row 106 "mettalic_factor" instead of "metallic_factor".

Thanks for the report, this is now fixed in 2b1fa0f0424f85dae8c39f1be95e1d407db95686


multiple with tags appears all as tags (not the selected ones)

I am trying to use vue-next-select with multiple and taggable (i want to display the selected options)
    <vue-select
        :options="cats"
        v-model="modelCats"
        label-by="category"
        track-by="id"
        value-by="id"
        close-on-select
        multiple
        taggable
        hide-selected
    />

an in data() i have this:
 cats: [
    {id: 1, category: 'Cat 1'},
    {id: 2, category: 'Cat 2'},
    {id: 3, category: 'Cat 3'},
    {id: 4, category: 'Cat 4'},
    {id: 5, category: 'Cat 5'},
    {id: 6, category: 'Cat 6'},
    {id: 7, category: 'Cat 7'},
    {id: 8, category: 'Cat 8'}
 ],
 modelCats: [1,4]

and it apears all 8 cats as tags (see the picture)
What I did wrong?

I create a minimal demo for your case, it seems to work fine.
Maybe you can check the tags' class:
for selected tags:

...

for non-selected tags:

...

https://codesandbox.io/s/vue-next-select-forked-c26uh?file=/src/App.vue

I cleared all the custom style made for vue-select and load only the index.min.css
// vue-next-select scss
@import '~vue-next-select/dist/index.min.css';
``
I was thinking that I did something wrong in css

As you can see in the pictures attached, all the 8 items appears in the select

You can see that 1 and 4 appears as selected (with class="vue-tag selected")

but... I click on "vue-tag" it still has the css display:flex (instead of none)

I think is an issue in the css (index.min.css)

![Screenshot from 2020-12-08 13-38-22](https://user-images.githubusercontent.com/49674076/101479953-ad770e00-395b-11eb-90cc-f2988f2e88ba.png)
![Screenshot from 2020-12-08 13-38-41](https://user-images.githubusercontent.com/49674076/101479957-ae0fa480-395b-11eb-8ca8-aa4d501f8978.png)
![Screenshot from 2020-12-08 13-39-11](https://user-images.githubusercontent.com/49674076/101479959-ae0fa480-395b-11eb-8ee8-00ae1bc117f5.png)
![Screenshot from 2020-12-08 13-39-22](https://user-images.githubusercontent.com/49674076/101479962-aea83b00-395b-11eb-9918-3ee8c0e72acd.png)

I think the problem is here
.vue-tag, .vue-tag.selected {
    display: flex;
    align-items: center;
    justify-content: center;
    background-color: #999;
    border-radius: 4px;
    padding: 0 4px;
    font-size: .8rem;
}

it should be
.vue-tag.selected {
    display: flex;
    align-items: center;
    justify-content: center;
    background-color: #999;
    border-radius: 4px;
    padding: 0 4px;
    font-size: .8rem;
}

without
.vue-tag,

@bci24 Thanks for lot of detail, It works now~


Support for DNS solutions like nip.io or sslip.io

snc-library.sh will abort installation when CRC_BASE_DOMAIN is:
<IP_ADDRESS>.nip.io
or
<IP_ADDRESS>.sslip.io
A workaround would be to patch snc-library.sh. For example:
sed -i '/if echo $${ping_status}/c\        if false; then' snc-library.sh
Is this a user case that the SNC should support?

You can put a PR to introduce another ENV variable SNC_PING_STATUS which default value would be true and then user can set it according to their usecase.


GH-24: Implement Alliance Managment Frame

Note: In this PR, response from the get_alliance API method is hard-coded, as the methods are currently broken. @ItsNeil17 said to leave testing to him, once the API methods are fixed. The update part is entirely untested. PR also includes changes to frame initialization, moving it to after the API key is verified. This is to allow for use of the API in the __init__  functions of frames.

Issue: gh-24

API issue was fixed & the application has been tested.


Hover on commits selected strange effect

Description
https://user-images.githubusercontent.com/20476002/188224145-dac76280-44b6-4d60-a13d-608f3191aa28.mov
To Reproduce

open a file
open the right side menu

Version information
Aurora Editor: 1.0 (1)
Commit: 9b046a05a46c4bb308ea87ae9adbeca2b98a1ac3
MacOS: 12.5.1
Xcode: 13.4.1

Again, that's a Mac OS issue, nothing we can do about it. As you can see this issue doesn't exist in new versions.


FR - Provide a way to get Task/Extension information

Environment
azure-pipelines-task-lib version: 4.4.0
Issue Feature request description
Little feature request as I didn't find any API in 'azure-pipelines-task-lib/task' to provide information from task.json or extension-vss.json from within task context.
Example of usage:

Getting meta information as id, version, ..
Getting possible "hard-coded" configuration

Task.json should be easy. The file is usually next to the index.js/ps1 and since it's plain Json can easily be parsed. In both PowerShell and Node it's easy to request the folder of the currently executing file.
The vss-extension.json is a bit of a nightmare due to several reasons:

A task doesn't have to be shipped by an extension.
the vss-extension.json is broken into a Json and an xml manifest during publish. The original manifest is lost.
at publish time multiple manifest files can be merged together.
the name isn't fixed during publishing.
it's not available on the agent, since it's lost during the installation of the task in the Azure DevOps org/project collection.

I think you can still request it from the REST API using the marketplace/extensions API. Each extension has a list of published files and there are specific asset types for the extension manifests. You can query the task's extension id through the Distributed task API.

Hi @Herve-M, thank you for your request.
We are currently working on higher-priority issues, but we will investigate this issue later.

re-open for tracking.


Layer order (z-index) not true to add (method) order

Implementing 3 layers in this order...
layer1 = new L.TileLayer
map.add(layer1);

layer2 = new lvector.CartoDB
layer2.setMap(map);

layer3 = new L.TileLayer
map.add(layer3);

displays a map with layers in this order:
layer1,layer3,layer2

Just a few questions to help me troubleshoot:
What version of Leaflet Vector Layers are you using:
lvector.VERSION

What vector types are layers 1, 2 and 3 (markers, polylines, polygons)?

VERSION:"1.1.1"

Here is a snippet of my code:
function initialize() {

    var map = new L.Map("map", {
        center: new L.LatLng(45.58,-73.66),
        zoom: 9
    });

	var bgTiles = new L.TileLayer("http://{s}.acetate.geoiq.com/tiles/acetate-bg/{z}/{x}/{y}.png", {
		maxZoom: 18,
		subdomains: ["a1", "a2", "a3"],
		attribution: '© 2012 Michael Markieta, GEOIQ, Stamen, OSM; CC-BY-SA.'
	});

	map.addLayer(bgTiles);

	var mntrlCMA = new lvector.CartoDB({
	    user: "spatialanalysis",
	    table: "montcma2011",
		map: map,
	    fields: "cartodb_id,the_geom,pop_dens,area,pop",
	    symbology: {
	        type: "range",
	        property: "pop_dens",
	        ranges: [
	            {
	                range: [5001,100000],
	                vectorOptions: {
	                    fillColor: "#BD0026",
	                    fillOpacity: 0.5,
	                    color: "#000",
	                    opacity: 1.0,
	                    weight: 0.25
	                }
	            }
	        ]
	    },
		popupTemplate: '
Population Density: {pop_dens} persons ⁄ km²

Total Population: {pop} persons

Total Area: {area}km²
',
		singlePopup: true,
		popupOptions:({ maxWidth:350 }),
	    showAll: true
	});

		var lblTiles = new L.TileLayer("http://a2.acetate.geoiq.com/tiles/acetate-labels/{z}/{x}/{y}.png", {
			maxZoom: 18
		});

		map.addLayer(lblTiles);

	}

Not sure I've ever ran into this before... Perhaps an issue on my end?

I'm not sure but I think Leaflet might always put tiled layers below (behind) vector layers.
I'll check into this further tomorrow.

I didn't think of such use case earlier (it's quite rare), I'll take a look into it...

Closing this here.
To achieve your desired results it looks like you'll need to customize Leaflet or Leaflet would have to support promoting tiled layers above vector ones.


InvalidOperationException when trying to update Genshin Impact

The registry value of selectedServerName is null, but gets casted to an int which throws.
https://github.com/neon-nyan/CollapseLauncher/blob/main/Hi3HelperCore/Classes/Preset/Classes/PresetConfigClasses.cs#L141
For context, I reinstalled windows since installing genshin and haven't played it since before so some registry keys don't exist

Hi there,
Thank you for reporting this issue.
Seems like the throw comes from value while at the same time it:s trying to set the first value of the keys which doesn't exist, or doesn't it?
I will try to look into this later.

I checked the registry and the GENERAL_DATA key did exist, but the JSON data inside were all default values. selectedServerName was "". I changed that to "2" and then the launcher didn't crash when clicking the update button.

Hi there,
This issue should've been addressed in this commit.
You can check that out and if there's another thing went wrong with it, please leave a comment here.

LGTM, thanks


practice with stream api

@don-bigdad hello! I'm glad you've started practicing with this exercise. Please note that we accept Pull Requres if you introduce some changes, but in this case there is no need to create a PR.


Remove things related to IAS in src/app/zap-templates/zcl/data-model/…

…silabs and src/app/clusters
Problem
There is some IAS related code in the tree that is not working for a long time. Stop pretend it works and just remove it until there is something properly spec'ed and implemented.

As a note that should remove some warnings from the matter_idl parser:
ERROR:root:Bitmap IasZoneStatus could not find its cluster (code 1280/0x500)
ERROR:root:Bitmap IasZoneStatus could not find its cluster (code 1281/0x501)
ERROR:root:Bitmap WarningInfo could not find its cluster (code 1282/0x502)
ERROR:root:Bitmap SquawkInfo could not find its cluster (code 1282/0x502)

I have updated the PR. There is now README.md files in src/app/clusters/ias-zone-client and src/app/clusters/ias-zone-server


Listing document titles

Hi!
I'm quite new to Python (so this might be an easy fix), but I found LitStudy really interesting to look into.
I have tried to load documents from different files (from different databases) and used litstudy.types.DocumentSet.union to get a DocumentSet without duplicates. However, I would like to know which papers are then in this new collection/dataset. Is it possible to get LitStudy to list (e.g. in a Pandas DataFrame?) the titles of the documents in a specific dataset? Or provide a list/table of the titles just at any stage in the process?

Hi Astrid! Thanks for using litstudy and thanks for reporting this issue!
Unfortunately, at the moment there is no functionality to see which papers were removed when taking the union of multiple document sets.
Issue #68 discussed a similar problem where the is now way to find the papers removed by unique(). An idea there was to add a duplicates() method that returns the papers removed by unique() (such that len(docset) == len(docset.unique()) + len(docset.duplicates()). Something similar could be implemented for union().
We are open to contributes and will accept relevant pull requests that add this functionality.

You can always print the documents like this:
docs_csv = docs_ieee | docs_springer

for doc in docs_csv:
  print(doc.title)

Would that work? Each document has many attribute that you can access (such as the title, authors, publisher, etc.). See here: https://nlesc.github.io/litstudy/api/types.html#litstudy.types.Document


Allow to add custom annotations to RBAC Manager.

What problem are you facing?
I need to add custom annotations to RBAC Manager.
There is little more to add.
How could UXP help solve your problem?
I am directly preparing a PR to resolve this.

Closed with https://github.com/crossplane/crossplane/pull/5243


Combo Box v3 (multi-select + pills)

### Checklist
- [ ] Density (HD, MD, LD, TD)
- [ ] Mode (Light, Dark)
- [ ] Fill (Primary, Secondary, Tertiary)
- [ ] State (Default, Hover, Selected/Active, Disabled, Read-only, Other)
- [ ] Controlled API
- [ ] UITK accessibility parity (screen reader + keyboard interactions)

### Deliverables
- [ ] Characteristics spec
- [ ] Interactions spec, where necessary
- [ ] In Code & Figma (Component + Guide)
- [ ] Supporting site documentation

### Features
- [ ] Create dependency: Tokenized Input replaced by #2541
- [ ] Multiple selection as pills replaced by #2413
- [ ] Pill group expand and collapse, with truncation replaced by #2414
- [ ] Preselected values, with option to make non-removable

Close, replace with per feature issues


[WIP] Subplots

@alexcjohnson or @etpinard or @monfera, as I'm playing around with subplots I notice that for some chart types .domain is in gd.data, vs others in gd.layout:
domain:
in data
pie.domain
parcoords.domain
sankey.domain
table.domain
in layout
layout.xaxis.domain
layout.yaxis.domain
layout.ternary.domain
layout.scene.domain
layout.geo.domain
layout.mapbox.domain
layout.polar.domain
layout.radialaxis.domain
layout.angularaxis.domain
Is it because the trace types that have it in gd.data are considered to have no axes? Or was there some other reason. Trying to find generalizations here. Thanks!

@VeraZab yes, something similar, I think it boils down to Cartesian-like vs. not. Technically, parcoords does have axes, but it's a bunch of parallel axes and there's currently no overlay, ie. one can't superimpose multiple parcoords atop of one another. It is on the other hand possible to have multiple elements in the data array that are plotted in different places, controlled via the domain in data[i]. So the difference, I believe, is that axes - if present at all - are controlled at the data level in the first group and jointly, at the layout level in the second group.

I guess  you could say these trace types have no axes - I think of it as whether the trace lives inside a subplot, in which case the subplot needs to describe its placement within the plot with a domain, vs the trace standing on its own, in which case it's the trace that needs the domain.
Every subplot (and cartesian axis) needs a domain.
Every trace either has a subplot attribute or attributes (subplot, scene, geo, or xaxis and yaxis) or it has its own domain.


[Feature Request]: Support blade components <x-label

Feature Description
Please add support for
https://laravel.com/docs/10.x/blade#components

Thanks for your feature request! We're actively considering it for our Laraphense extension.
We are rewriting the Laravel Intelephense extension into a new extension named Laraphense, If you haven't already, please install Laraphense for the latest features.
While we cannot provide a specific timeline for implementation at this moment, please rest assured that your feedback is taken seriously.

Thx I was not aware the Intelephense is not marked as deprecated and also the readme is just taken from the Laraphense so I was not aware how they should be related.
I replaced the extension, and I am looking forward to seeing your progress.
Thanks for explanation


[ENH] MrSEQLClassifier wrapper

What does this implement/fix? Explain your changes.
Start of a mrseql wrapper. Unfortunately, I can't quite find how to parameterise it currently after installing on Windows 🙂.
If anyone can find it in the source that that would be helpful: https://github.com/lnthach/Mr-SEQL
Does your contribution introduce a new dependency? If yes, which one?
mrseql

@lnthach Hi Thach, I am having a bit of trouble figuring out what parameters your MrSEQL pypi package has and what defaults I should set for them. Would you be able to comment and help me with this?

@MatthewMiddlehurst Hi Matthew, I just updated mrseql (v0.0.4) on pypi so I hope it would make things easier for you. I also remove sktime dependency but use fftw3 library instead (same dependencies as mrsqm).
Currently there are three parameters for MrSEQLClassifier and the default values are as follows:
 MrSEQLClassifier(seql_mode='fs', symrep=('sax'), custom_config=None)
Please let me know if it works for you.

@lnthach Thanks for this. Raised the version found but it seems to be failing to install on our Linux runner (https://github.com/aeon-toolkit/aeon/actions/runs/10247769782/job/28347641403?pr=1756). mrsqm installs fine by the look of things

@MatthewMiddlehurst This one is strange. Both uses the same sfa implementation so both depends on fftw3. One possible reason is that mrsqm installed from built distribution hence the installation somehow bypassed this dependency (not sure if this is possible to be honest). I have some issues with generating the built distribution for mrseql so I uploaded only the source distribution. Do you think this could be the reason ?

@lnthach I think thats likely, not really sure how to resolve it through as I dont have much experience wrapping C, let alone distributing it 🙂. If the parameters used are the same I can restrict it to 0.0.2 for now?

@MatthewMiddlehurst I just uploaded the built distribution for v0.0.4. Could please you check if it still fails ?

Seems to all be running fine @lnthach


Forgot to add debanding to config object

When changing the rendering code from sending lots of parameters to our render buffers configuration object, to a configuration object so it's more extendable future proof, we forgot to set the debanding flag.
This may fix #80751

Resolved the issue.

Thanks!


specs: model not generated for requestBody with array type

Description
requestBody of type array does not:

preserve the name of their schema, ref, title or anything.
generate a type for the array model

Seems to be related to some of the opened issues on that subject, which leads to having properties named after the object name:

rule parameter of the saveRules method is created from the rules schema

Related issues:

https://github.com/OpenAPITools/openapi-generator/issues/9150
https://github.com/OpenAPITools/openapi-generator/issues/7802

Expected behavior

(optional) The array version of the model should be generated
The expected parameter should have the name of the model to keep the usage consistent

saveRules allow multiple rules to be saved, you expect the name of the list to be plural.

Workaround
Investigate the generateAliasAsModel option as logged from the generator:
Model rules not generated since it's an alias to array (without property) and `generateAliasAsModel` is set to false (default)

Environment

Client: Search
Language: All
Client version: All

cc @millotp as we discussed this before


cache video

你好，How to cache video？

Flutter cache manager --> You can use this library to cache files locally and then fetch them using your own custom logic.

@shatanikmahanty Thanks for the suggestion :D
The caching of videos is also something more related to the underlying video_player, so maybe there are even more ideas.
Here after a quick search I found this (also using flutter_cache_manager): https://honesdev.com/playing-and-caching-videos-in-flutter/

Related:
https://github.com/jhomlala/betterplayer/pull/123/files


Update UI of Contact Us Form with Navbar

Will create a new contact us form with responsiveness & navbar in Contact Page.

I want to work on this issue under JWOC

@tanya-gupta25 Sure, we look forward to  your changes for the Contact US form.
Some Suggestions:

The title of the page should be centre aligned and the text can be "Get in Touch"
Try to use some Text Animation for the title
The contact form should be strict checks for email validity, name length more than 2 and message length more than 3 (number of words)
Try to use some Helper text animations if you wish
For the send button,  look up microanimations
Lastly, integration with formcarry

i want to contribute in this problem solution


Improve docs of maxout

This is PR for improving docs of functions/links. Related issue: #2182
Modified functions/links:

maxout

Jenkins test has also passed.

LGTM


Flyway cannot find migration scripts

Which version and edition of Flyway are you using?
9.8.1
If this is not the latest version, can you reproduce the issue with the latest one as well? (Many bugs are fixed in newer releases and upgrading will often resolve the issue)
Which client are you using? (Command-line, Java API, Maven plugin, Gradle plugin)
Java API
Which database are you using? (Type & version)
SQLite
Which operating system are you using?
Windows 10
What did you do? (Please include the content causing the issue, any relevant configuration settings, the SQL statement(s) that failed (if any), and the command you ran)
I tried packaging the jar file with the flyway migrations
What did you expect to see?
A log of Flyway executing 2 migration files.
What did you see instead?
Flyway executing 0 migration files.

Hi @MatthisVanHoecke2 , I see question marks marked at the db/migration folders, can you confirm the location of the folder is actually OK?

When I add classpath:db/migration to the locations in the java code, it doesn't give me an error or anything like that when I run it. The scripts just don't get recognized. From what I understood from the flyway documentation, when using a maven project, I am supposed to put the db/migration folder inside the resource folder. Is there a better way to check whether the location is ok?

From the documentation im not even sure the java API will check .sql files have you tried running it with the maven cmd ?
On my side the maven plugin works but i'm not able to initiate a connecter wit hthe Java API.
repos:
https://github.com/Izocel/Minecraft-Whitelist-Discord-Bot

Hi @MatthisVanHoecke2 , did you run Maven clear/install for your project?
I locally verified that, one you run Maven clear/install, any migration files will be automatically copied from src\main\resources\db\migration
to
target\classes\db\migration

I run the clean install command when generating the sources, I checked the generated .jar file as well and it has all the required files

I'll try this and get back to you if it works or not.


MB-8053 open tracing adr

Description
Describe the thought process around choosing OpenTelemetry for instrumenting code for Distributed Tracing
Code Review Verification Steps

[x] Request review from a member of a different team.

References

This article just happened to come across my notice when the ADR was half written in my head already.

Some call it art:

This is very exciting, I had dug into what their client side libraries look like and it seemed very extensible.  I did see the Zap support was still a WIP PR is that a concern?

@duncan-truss Interesting find on the Zap instrumentation!
IMO, the main cases where you would want to instrument your logging framework is if: a) you are in a VERY high-performance/performance-critical computing environment where nanoseconds are at stake; b) you have already instrumented EVERYTHING ELSE already; or c) something has gone REALLY wrong with how you've set up your logging egress and there's back-pressure happening.
I don't believe either of those things apply to us right now, so I don't we should treat Zap instrumentation as a blocking condition.

@transcom/truss-sr-eng Github tells me I need to get one of y'all to approve before I can merge this ADR... Is there anything else I can do to facilitate that?

@duncan-truss Interesting find on the Zap instrumentation!
IMO, the main cases where you would want to instrument your logging framework is if: a) you are in a VERY high-performance/performance-critical computing environment where nanoseconds are at stake; b) you have already instrumented EVERYTHING ELSE already; or c) something has gone REALLY wrong with how you've set up your logging egress and there's back-pressure happening.
I don't believe either of those things apply to us right now, so I don't we should treat Zap instrumentation as a blocking condition.

@nelztruss Oh if that's the case I misunderstood then, I thought it was a way to continue using Zap in a way that implements open telemetry's spec.

@duncan-truss Interesting find on the Zap instrumentation!
IMO, the main cases where you would want to instrument your logging framework is if: a) you are in a VERY high-performance/performance-critical computing environment where nanoseconds are at stake; b) you have already instrumented EVERYTHING ELSE already; or c) something has gone REALLY wrong with how you've set up your logging egress and there's back-pressure happening.
I don't believe either of those things apply to us right now, so I don't we should treat Zap instrumentation as a blocking condition.

@nelztruss Oh if that's the case I misunderstood then, I thought it was a way to continue using Zap in a way that implements open telemetry's spec.

@duncan-truss Oops, actually you are correct, and I was mistaken.
I didn't look deep enough into the code, and was going by the Issue title "Add instrumentation for Zap"... But upon digging deeper into the referenced OpenTracing library, the task does seem that it's more akin to "have Zap participated in instrumentation of traces".
Yes, if that was available, that could help us "automagically" add more stuff to the tracing! But it's lack right now shouldn't stop us from doing initial implementation.


TypeError: comp(...) is undefined

Hello!
I've updated the extension from the repository, and downloaded the latest player version.
When trying to run the following code I get a 'TypeError: comp(...) is undefined' message. What could be the reason?
var object = bodymovin.loadAnimation({
        container: document.getElementById('test'), // the dom element
        renderer: 'svg',
        loop: true,
        autoplay: true,
        name: 'test',
        animationData: digitalLogoAnimData // the animation data
    });

digitalLogoAnimData is equal to the contents of the exported data.json.

it seems you have an expression pointing to an external composition.
If that's the case, you need to include it as an extra asset on the "Extra Comp" settings of the composition in the plugin.

@bodymovin Wow, thanks for the fast reply! I'll try that.

@bodymovin Checked the extra comp settings in the plugin, still getting the error. I also get the error on the generated demo.html

can you share the .ae so I can take a look?

@bodymovin
Pencil.aep.zip

The issue is because "Comp 1" is the main comp and it can't be referenced from other comps. I need to fix that.
In the meantime, you can precomp Comp 1 into another comp and export that one. It will work like that.
On another topic, you are using repeaters in your animation and they are not yet supported. They are first on my pipeline but it will take some time.

Ok, thank you very much for your help!


Calendar not displaying on board index even if board index options are selected

See title.
My members would freak if they couldn't see birthdays >_>

That's actually a cache bug... :-\
The following diff will fix it:
diff --git a/sources/subs/Cache.class.php b/sources/subs/Cache.class.php
index 00ed406..b18b082 100644
--- a/sources/subs/Cache.class.php
+++ b/sources/subs/Cache.class.php
@@ -107,9 +107,6 @@ class Cache
 	 */
 	public function quick_get($key, $file, $function, $params, $level = 1)
 	{
-		if (!$this->isEnabled())
-			return array();
-
 		call_integration_hook('pre_cache_quick_get', array(&$key, &$file, &$function, &$params, &$level));

 		/* Refresh the cache if either:
@@ -119,12 +116,12 @@ class Cache
 			4. The cached item has a custom expiration condition evaluating to true.
 			5. The expire time set in the cache item has passed (needed for Zend).
 		*/
-		if ($this->level < $level || !is_array($cache_block = $this->get($key, 3600)) || (!empty($cache_block['refresh_eval']) && eval($cache_block['refresh_eval'])) || (!empty($cache_block['expires']) && $cache_block['expires'] < time()))
+		if (!$this->isEnabled() || $this->level < $level || !is_array($cache_block = $this->get($key, 3600)) || (!empty($cache_block['refresh_eval']) && eval($cache_block['refresh_eval'])) || (!empty($cache_block['expires']) && $cache_block['expires'] < time()))
 		{
 			require_once(SOURCEDIR . '/' . $file);
 			$cache_block = call_user_func_array($function, $params);

-			if ($this->_cache_enable >= $level)
+			if ($this->isEnabled() && $this->_cache_enable >= $level)
 				$this->put($key, $cache_block, $cache_block['expires'] - time());
 		}


Features/upgrade blacksmith

Codecov Report

Merging #10 (c47564a) into main (e63cd4e) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main       #10   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            6         6
  Lines          242       252   +10
=========================================
+ Hits           242       252   +10

Impacted Files
Coverage Δ

src/pyramid_blacksmith/binding.py
100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


fix: Broken link in meshery sistent docs

Notes for Reviewers

This PR fixes #

Signed commits

[ ] Yes, I signed my commits.

🚀 Preview for commit ceedab6adcd2ad2e376be2bb48be505a6c786d73 at: https://672fc500fd824eafb4f2a0be--meshery-docs-preview.netlify.app