Certificate Validation Always Fails

'''I am connecting to a Windows 2012 server with a valid certificate (issued by Starfield), however, xfreerdp says:
xfreerdp --from-stdin -a 24 -T CCS-CW.{removed}.com -g 1024x768 --disable-menu-animations --disable-wallpaper --plugin cliprdr --plugin rdpsnd --plugin rdpdr --data disk:Home:/home/KHolloway -- -d {removed}.com -u KenHolloway --certificate-name cw.{removed}.com CCS-CW.{removed}.com

loading plugin cliprdr
loading plugin rdpsnd
loading plugin rdpdr
password:
connected to CCS-CW.{removed}.com:3389
Certificate details:
        Subject: OU = Domain Control Validated, CN = cw.{removed}.com
        Issuer: C = US, ST = Arizona, L = Scottsdale, O = "Starfield Technologies, Inc.", OU = http://certs.starfieldtech.com/repository/, CN = Starfield Secure Certificate Authority - G2
        Thumbprint: c7:38:1f:b4:5d:5f:c6:cd:37:91:e8:eb:18:99:5b:5f:67:40:43
The above X.509 certificate could not be verified, possibly because you do not have the CA certificate in your certificate store, or the certificate has expired. Please look at the documentation on how to create local certificate store for a private CA.
Do you trust the above certificate? (Y/N)

I have tried connecting both with "FreeRDP version 1.0.2" (installed on openSUSE from standard openSUSE repo), and with "FreeRDP version 1.2.1-dev (git b33bba0)", downloaded from git a few days ago.
I have checked the server's certificate using openSSL:
openssl s_client -connect ccs-cw.{removed}.com:3389 < /dev/null
CONNECTED(00000003)
depth=2 C = US, ST = Arizona, L = Scottsdale, O = "Starfield Technologies, Inc.", CN = Starfield Root Certificate Authority - G2
verify return:1
depth=1 C = US, ST = Arizona, L = Scottsdale, O = "Starfield Technologies, Inc.", OU = http://certs.starfieldtech.com/repository/, CN = Starfield Secure Certificate Authority - G2
verify return:1
depth=0 OU = Domain Control Validated, CN = cw.{removed}.com
verify return:1
---
Certificate chain
 0 s:/OU=Domain Control Validated/CN=cw.{removed}.com
   i:/C=US/ST=Arizona/L=Scottsdale/O=Starfield Technologies, Inc./OU=http://certs.starfieldtech.com/repository//CN=Starfield Secure Certificate Authority - G2
 1 s:/C=US/ST=Arizona/L=Scottsdale/O=Starfield Technologies, Inc./OU=http://certs.starfieldtech.com/repository//CN=Starfield Secure Certificate Authority - G2
   i:/C=US/ST=Arizona/L=Scottsdale/O=Starfield Technologies, Inc./CN=Starfield Root Certificate Authority - G2
 2 s:/C=US/ST=Arizona/L=Scottsdale/O=Starfield Technologies, Inc./OU=https://certs.starfieldtech.com/repository//CN=Starfield Root Certificate Authority - G2
   i:/C=US/O=Starfield Technologies, Inc./OU=Starfield Class 2 Certification Authority
---
Server certificate
-----BEGIN CERTIFICATE-----
{removed}
-----END CERTIFICATE-----
subject=/OU=Domain Control Validated/CN=cw.{removed}.com
issuer=/C=US/ST=Arizona/L=Scottsdale/O=Starfield Technologies, Inc./OU=http://certs.starfieldtech.com/repository//CN=Starfield Secure Certificate Authority - G2
---
No client certificate CA names sent
---
SSL handshake has read 4110 bytes and written 663 bytes
---
New, TLSv1/SSLv3, Cipher is AES128-SHA256
Server public key is 2048 bit
Secure Renegotiation IS supported
Compression: NONE
Expansion: NONE
SSL-Session:
    Protocol  : TLSv1.2
    Cipher    : AES128-SHA256
    Session-ID: E14200007BA52B0EFAC0F9F139E1E24CB0F27CF0449E6BFFC07BF7244A0B01F0
    Session-ID-ctx:
    Master-Key: 7362723B398DBF107B16AEFC37B6927AF4089632C6D4DF50AEA5E28E9715143732D1D7D38FC5444CB74DCA733AE15C75
    Key-Arg   : None
    PSK identity: None
    PSK identity hint: None
    SRP username: None
    Start Time:<PHONE_NUMBER>
    Timeout   : 300 (sec)
    Verify return code: 0 (ok)
---
DONE

What needs to be done to make FreeRDP realize that this is a valid certifcate?
'''

@KenHolloway where do the ca certificates reside on your system?

/etc/ssl is documented as the ca certificates directory on openSUSE. It has a certs directory, which contains links to the .pem files at /var/lib/ca-certificates/pem/
I had already tried copying everything from /etc/ssl/certs to ~/.freerdp/certs/ - it made no difference.
Then, I tried deleting ~/.freerdp/certs/, and making it a link to /etc/ssl/certs/ - again, no difference.
Then, I tried deleted ~/.freerdp/certs/, and making it a link to /var/lib/ca-certificates/pem/ - again, no difference.

@KenHolloway I didn't look at the code yet but I think the system certificate store isn't used. So depending on the distribution only the openssl default and FreeRDPs certificate store is used.
When you tried ~/.freerdp/certs/ did you also create the hashed certificate for openssl?
If not copy your ca certificate file to ~/.freerdp/certs and run the following:
ln -s ca.crt `openssl x509 -hash -noout -in ca.crt`.0

When running xfreerdp with strace you can also nicely see what certificate (hash) it is looked for:
strace -ff -e open,stat,stat64 xfreerdp /u:user /p:password /v:win7test

Okay, now we're getting somewhere:
strace -ff -e open,stat,stat64 xfreerdp --from-stdin -a 24 -T CCS-CW.{removed}.com -g 1024x768 --disable-menu-animations --disable-wallpaper --plugin cliprdr --plugin rdpsnd --plugin rdpdr --data disk:Home:/home/KHolloway -- -d {removed}.com -u KenHolloway --certificate-name cw.{removed}.com CCS-CW.{removed}.com
open("/etc/ld.so.cache", O_RDONLY|O_CLOEXEC) = 3
open("/usr/lib64/libXinerama.so.1", O_RDONLY|O_CLOEXEC) = 3
open("/usr/lib64/libXext.so.6", O_RDONLY|O_CLOEXEC) = 3
open("/usr/lib64/libXcursor.so.1", O_RDONLY|O_CLOEXEC) = 3
open("/usr/lib64/libXv.so.1", O_RDONLY|O_CLOEXEC) = 3
open("/usr/lib64/libfreerdp-core.so.1.0", O_RDONLY|O_CLOEXEC) = 3
open("/usr/lib64/libfreerdp-gdi.so.1.0", O_RDONLY|O_CLOEXEC) = 3
open("/usr/lib64/libfreerdp-kbd.so.1.0", O_RDONLY|O_CLOEXEC) = 3
open("/usr/lib64/libfreerdp-rail.so.1.0", O_RDONLY|O_CLOEXEC) = 3
open("/usr/lib64/libfreerdp-channels.so.1.0", O_RDONLY|O_CLOEXEC) = 3
open("/usr/lib64/libfreerdp-utils.so.1.0", O_RDONLY|O_CLOEXEC) = 3
open("/usr/lib64/libX11.so.6", O_RDONLY|O_CLOEXEC) = 3
open("/usr/lib64/libfreerdp-cache.so.1.0", O_RDONLY|O_CLOEXEC) = 3
open("/usr/lib64/libfreerdp-codec.so.1.0", O_RDONLY|O_CLOEXEC) = 3
open("/lib64/libpthread.so.0", O_RDONLY|O_CLOEXEC) = 3
open("/lib64/libc.so.6", O_RDONLY|O_CLOEXEC) = 3
open("/usr/lib64/libXrender.so.1", O_RDONLY|O_CLOEXEC) = 3
open("/usr/lib64/libXfixes.so.3", O_RDONLY|O_CLOEXEC) = 3
open("/lib64/libssl.so.1.0.0", O_RDONLY|O_CLOEXEC) = 3
open("/lib64/libcrypto.so.1.0.0", O_RDONLY|O_CLOEXEC) = 3
open("/lib64/libdl.so.2", O_RDONLY|O_CLOEXEC) = 3
open("/usr/lib64/libxkbfile.so.1", O_RDONLY|O_CLOEXEC) = 3
open("/usr/lib64/libxcb.so.1", O_RDONLY|O_CLOEXEC) = 3
open("/lib64/libz.so.1", O_RDONLY|O_CLOEXEC) = 3
open("/usr/lib64/libXau.so.6", O_RDONLY|O_CLOEXEC) = 3
open("/usr/lib/locale/locale-archive", O_RDONLY|O_CLOEXEC) = -1 ENOENT (No such file or directory)
open("/usr/share/locale/locale.alias", O_RDONLY|O_CLOEXEC) = 3
open("/usr/lib/locale/en_US.UTF-8/LC_IDENTIFICATION", O_RDONLY|O_CLOEXEC) = -1 ENOENT (No such file or directory)
open("/usr/lib/locale/en_US.utf8/LC_IDENTIFICATION", O_RDONLY|O_CLOEXEC) = 3
open("/usr/lib64/gconv/gconv-modules.cache", O_RDONLY) = 3
open("/usr/lib/locale/en_US.UTF-8/LC_MEASUREMENT", O_RDONLY|O_CLOEXEC) = -1 ENOENT (No such file or directory)
open("/usr/lib/locale/en_US.utf8/LC_MEASUREMENT", O_RDONLY|O_CLOEXEC) = 3
open("/usr/lib/locale/en_US.UTF-8/LC_TELEPHONE", O_RDONLY|O_CLOEXEC) = -1 ENOENT (No such file or directory)
open("/usr/lib/locale/en_US.utf8/LC_TELEPHONE", O_RDONLY|O_CLOEXEC) = 3
open("/usr/lib/locale/en_US.UTF-8/LC_ADDRESS", O_RDONLY|O_CLOEXEC) = -1 ENOENT (No such file or directory)
open("/usr/lib/locale/en_US.utf8/LC_ADDRESS", O_RDONLY|O_CLOEXEC) = 3
open("/usr/lib/locale/en_US.UTF-8/LC_NAME", O_RDONLY|O_CLOEXEC) = -1 ENOENT (No such file or directory)
open("/usr/lib/locale/en_US.utf8/LC_NAME", O_RDONLY|O_CLOEXEC) = 3
open("/usr/lib/locale/en_US.UTF-8/LC_PAPER", O_RDONLY|O_CLOEXEC) = -1 ENOENT (No such file or directory)
open("/usr/lib/locale/en_US.utf8/LC_PAPER", O_RDONLY|O_CLOEXEC) = 3
open("/usr/lib/locale/en_US.UTF-8/LC_MESSAGES", O_RDONLY|O_CLOEXEC) = -1 ENOENT (No such file or directory)
open("/usr/lib/locale/en_US.utf8/LC_MESSAGES", O_RDONLY|O_CLOEXEC) = 3
open("/usr/lib/locale/en_US.utf8/LC_MESSAGES/SYS_LC_MESSAGES", O_RDONLY|O_CLOEXEC) = 3
open("/usr/lib/locale/en_US.UTF-8/LC_MONETARY", O_RDONLY|O_CLOEXEC) = -1 ENOENT (No such file or directory)
open("/usr/lib/locale/en_US.utf8/LC_MONETARY", O_RDONLY|O_CLOEXEC) = 3
open("/usr/lib/locale/en_US.UTF-8/LC_COLLATE", O_RDONLY|O_CLOEXEC) = -1 ENOENT (No such file or directory)
open("/usr/lib/locale/en_US.utf8/LC_COLLATE", O_RDONLY|O_CLOEXEC) = 3
open("/usr/lib/locale/en_US.UTF-8/LC_TIME", O_RDONLY|O_CLOEXEC) = -1 ENOENT (No such file or directory)
open("/usr/lib/locale/en_US.utf8/LC_TIME", O_RDONLY|O_CLOEXEC) = 3
open("/usr/lib/locale/en_US.UTF-8/LC_NUMERIC", O_RDONLY|O_CLOEXEC) = -1 ENOENT (No such file or directory)
open("/usr/lib/locale/en_US.utf8/LC_NUMERIC", O_RDONLY|O_CLOEXEC) = 3
open("/usr/lib/locale/en_US.UTF-8/LC_CTYPE", O_RDONLY|O_CLOEXEC) = -1 ENOENT (No such file or directory)
open("/usr/lib/locale/en_US.utf8/LC_CTYPE", O_RDONLY|O_CLOEXEC) = 3
stat("/home/KHolloway/.freerdp", {st_mode=S_IFDIR|0700, st_size=4096, ...}) = 0
stat(".git", 0x7fff75f23830)            = -1 ENOENT (No such file or directory)
stat("../.git", 0x7fff75f23830)         = -1 ENOENT (No such file or directory)
stat("../../.git", 0x7fff75f23830)      = -1 ENOENT (No such file or directory)
Process 4213 attached
loading plugin cliprdr
[pid  4213] open("/usr/lib64/libfreerdp-1_0/cliprdr.so", O_RDONLY|O_CLOEXEC) = 7
loading plugin rdpsnd
[pid  4213] open("/usr/lib64/libfreerdp-1_0/rdpsnd.so", O_RDONLY|O_CLOEXEC) = 7
loading plugin rdpdr
[pid  4213] open("/usr/lib64/libfreerdp-1_0/rdpdr.so", O_RDONLY|O_CLOEXEC) = 7
password:
[pid  4213] open("/home/KHolloway/.Xauthority", O_RDONLY) = 8
connected to CCS-CW.{removed}.com:3389
[pid  4213] open("/usr/share/locale-langpack/en_US.UTF-8/LC_MESSAGES/libc.mo", O_RDONLY) = -1 ENOENT (No such file or directory)
[pid  4213] open("/usr/share/locale/en_US.UTF-8/LC_MESSAGES/libc.mo", O_RDONLY) = -1 ENOENT (No such file or directory)
[pid  4213] open("/usr/share/locale-bundle/en_US.UTF-8/LC_MESSAGES/libc.mo", O_RDONLY) = -1 ENOENT (No such file or directory)
[pid  4213] open("/usr/share/locale-langpack/en_US.utf8/LC_MESSAGES/libc.mo", O_RDONLY) = -1 ENOENT (No such file or directory)
[pid  4213] open("/usr/share/locale/en_US.utf8/LC_MESSAGES/libc.mo", O_RDONLY) = -1 ENOENT (No such file or directory)
[pid  4213] open("/usr/share/locale-bundle/en_US.utf8/LC_MESSAGES/libc.mo", O_RDONLY) = -1 ENOENT (No such file or directory)
[pid  4213] open("/usr/share/locale-langpack/en_US/LC_MESSAGES/libc.mo", O_RDONLY) = -1 ENOENT (No such file or directory)
[pid  4213] open("/usr/share/locale/en_US/LC_MESSAGES/libc.mo", O_RDONLY) = -1 ENOENT (No such file or directory)
[pid  4213] open("/usr/share/locale-bundle/en_US/LC_MESSAGES/libc.mo", O_RDONLY) = -1 ENOENT (No such file or directory)
[pid  4213] open("/usr/share/locale-langpack/en.UTF-8/LC_MESSAGES/libc.mo", O_RDONLY) = -1 ENOENT (No such file or directory)
[pid  4213] open("/usr/share/locale/en.UTF-8/LC_MESSAGES/libc.mo", O_RDONLY) = -1 ENOENT (No such file or directory)
[pid  4213] open("/usr/share/locale-bundle/en.UTF-8/LC_MESSAGES/libc.mo", O_RDONLY) = -1 ENOENT (No such file or directory)
[pid  4213] open("/usr/share/locale-langpack/en.utf8/LC_MESSAGES/libc.mo", O_RDONLY) = -1 ENOENT (No such file or directory)
[pid  4213] open("/usr/share/locale/en.utf8/LC_MESSAGES/libc.mo", O_RDONLY) = -1 ENOENT (No such file or directory)
[pid  4213] open("/usr/share/locale-bundle/en.utf8/LC_MESSAGES/libc.mo", O_RDONLY) = -1 ENOENT (No such file or directory)
[pid  4213] open("/usr/share/locale-langpack/en/LC_MESSAGES/libc.mo", O_RDONLY) = -1 ENOENT (No such file or directory)
[pid  4213] open("/usr/share/locale/en/LC_MESSAGES/libc.mo", O_RDONLY) = -1 ENOENT (No such file or directory)
[pid  4213] open("/usr/share/locale-bundle/en/LC_MESSAGES/libc.mo", O_RDONLY) = -1 ENOENT (No such file or directory)
[pid  4213] stat("/home/KHolloway/.freerdp", {st_mode=S_IFDIR|0700, st_size=4096, ...}) = 0
[pid  4213] stat("/home/KHolloway/.freerdp/certs", {st_mode=S_IFDIR|0755, st_size=20480, ...}) = 0
[pid  4213] stat("/home/KHolloway/.freerdp/known_hosts", {st_mode=S_IFREG|0644, st_size=2435, ...}) = 0
[pid  4213] open("/home/KHolloway/.freerdp/known_hosts", O_RDWR) = 9
[pid  4213] open("/dev/urandom", O_RDONLY|O_NOCTTY|O_NONBLOCK|O_CLOEXEC) = 10
[pid  4213] open("/etc/ssl/openssl.cnf", O_RDONLY|O_CLOEXEC) = 10
[pid  4213] stat("/var/lib/ca-certificates/openssl/cd7781e5.0", 0x7f1b385c06f0) = -1 ENOENT (No such file or directory)
[pid  4213] stat("/home/KHolloway/.freerdp/certs/cd7781e5.0", 0x7f1b385c06f0) = -1 ENOENT (No such file or directory)
Certificate details:
        Subject: OU = Domain Control Validated, CN = cw.{removed}.com
        Issuer: C = US, ST = Arizona, L = Scottsdale, O = "Starfield Technologies, Inc.", OU = http://certs.starfieldtech.com/repository/, CN = Starfield Secure Certificate Authority - G2
        Thumbprint: c7:38:1f:b4:5d:5f:c6:cd:37:91:e8:eb:18:99:5b:5f:67:40:43
The above X.509 certificate could not be verified, possibly because you do not have the CA certificate in your certificate store, or the certificate has expired. Please look at the documentation on how to create local certificate store for a private CA.
Do you trust the above certificate? (Y/N) n
SSL_write: Failure in SSL library (protocol error?)
Authentication failure, check credentials.
If credentials are valid, the NTLMSSP implementation may be to blame.
[pid  4213] open("/etc/ld.so.cache", O_RDONLY|O_CLOEXEC) = 10
[pid  4213] open("/lib64/libgcc_s.so.1", O_RDONLY|O_CLOEXEC) = 5
[pid  4213] +++ exited with 131 +++
+++ exited with 131 +++

The two lines before the certificate details seem to indicate it is looking for a certificate with hash "cd7781e5" - that is NOT the root certificate for the publicly signed certficiate we are using. With some experimentation, I found that hash is the intermediate certificate. What do we need to do to get FreeRDP to follow the chain all the way up to the root, and check the root certificate against the certificate store?

@KenHolloway if you use the the same certificate the server sends does verification with "openssl verify" on the same system work?

I already checked the certificate with "openssl s_client -connect ccs-cw.{removed}.com:3389 < /dev/null". Are you asking me to run a different test? If so, how?
openssl s_client -connect cw.{removed}.com:3389 < /dev/null
CONNECTED(00000003)
depth=2 C = US, ST = Arizona, L = Scottsdale, O = "Starfield Technologies, Inc.", CN = Starfield Root Certificate Authority - G2
verify return:1
depth=1 C = US, ST = Arizona, L = Scottsdale, O = "Starfield Technologies, Inc.", OU = http://certs.starfieldtech.com/repository/, CN = Starfield Secure Certificate Authority - G2
verify return:1
depth=0 OU = Domain Control Validated, CN = cw.{removed}.com
verify return:1
---
Certificate chain
 0 s:/OU=Domain Control Validated/CN=cw.{removed}.com
   i:/C=US/ST=Arizona/L=Scottsdale/O=Starfield Technologies, Inc./OU=http://certs.starfieldtech.com/repository//CN=Starfield Secure Certificate Authority - G2
 1 s:/C=US/ST=Arizona/L=Scottsdale/O=Starfield Technologies, Inc./OU=http://certs.starfieldtech.com/repository//CN=Starfield Secure Certificate Authority - G2
   i:/C=US/ST=Arizona/L=Scottsdale/O=Starfield Technologies, Inc./CN=Starfield Root Certificate Authority - G2
 2 s:/C=US/ST=Arizona/L=Scottsdale/O=Starfield Technologies, Inc./OU=https://certs.starfieldtech.com/repository//CN=Starfield Root Certificate Authority - G2
   i:/C=US/O=Starfield Technologies, Inc./OU=Starfield Class 2 Certification Authority
---
Server certificate
-----BEGIN CERTIFICATE-----
{removed}
-----END CERTIFICATE-----
subject=/OU=Domain Control Validated/CN=cw.{removed}.com
issuer=/C=US/ST=Arizona/L=Scottsdale/O=Starfield Technologies, Inc./OU=http://certs.starfieldtech.com/repository//CN=Starfield Secure Certificate Authority - G2
---
No client certificate CA names sent
---
SSL handshake has read 4110 bytes and written 663 bytes
---
New, TLSv1/SSLv3, Cipher is AES128-SHA256
Server public key is 2048 bit
Secure Renegotiation IS supported
Compression: NONE
Expansion: NONE
SSL-Session:
    Protocol  : TLSv1.2
    Cipher    : AES128-SHA256
    Session-ID: 8D4000007E7A3FD0BEA8300F1509D8977EFD1B27DE6FA020BB0C96922090D2B6
    Session-ID-ctx:
    Master-Key: 54DD4733F2B8797C4941CD54392C27E087EEE6FB6F277318476BD5533FF5020EF4C2644D3BE8D10A86A621C29210B2B4
    Key-Arg   : None
    PSK identity: None
    PSK identity hint: None
    SRP username: None
    Start Time:<PHONE_NUMBER>
    Timeout   : 300 (sec)
    Verify return code: 0 (ok)
---
DONE

Everything I know how to test is fine. It looks like FreeRDP is not following the certificate chain up to the root - it is only checking the intermediate certificate. How do we get this fixed?

@KenHolloway if you can provide me some setup where I can test it I could have a look.

Hi Bernhard,
I can setup access for you.
How do I send only to you?
What is the public IP address you would be connecting from?
Thanks,
Ken
On 03/10/2015 09:47 AM, Bernhard Miklautz wrote:

@KenHolloway https://github.com/KenHolloway if you can provide me
some setup where I can test it I could have a look.
—
Reply to this email directly or view it on GitHub
https://github.com/FreeRDP/FreeRDP/issues/2446#issuecomment-78095366.

@KenHolloway either in #freerdp channel on freenode or via e-mail<EMAIL_ADDRESS>

After looking into this we've identified two problems:

FreeRDP uses DER as format for its internal certificate store (~/.config/freerdp/certs)
certificate chains received from the server are not used and therefore all certificates up to the top need to be installed locally.

@KenHolloway thank you for the assistance


Gh 1824 operation field summary

Codecov Report

:exclamation: No coverage uploaded for pull request base (develop@71f3886). Click here to learn what that means.
The diff coverage is 84.61%.

@@            Coverage Diff            @@
##             develop   #1825   +/-   ##
=========================================
  Coverage           ?   66.2%
  Complexity         ?    2056
=========================================
  Files              ?     795
  Lines              ?   25930
  Branches           ?    3366
=========================================
  Hits               ?   17166
  Misses             ?    7423
  Partials           ?    1341

Impacted Files
Coverage Δ
Complexity Δ

.../java/uk/gov/gchq/gaffer/jobtracker/JobStatus.java
0% <0%> (ø)
0 <0> (?)

...uk/gov/gchq/gaffer/data/element/EdgeDirection.java
0% <0%> (ø)
0 <0> (?)

...ava/uk/gov/gchq/gaffer/operation/SeedMatching.java
100% <100%> (ø)
0 <0> (?)

...k/gov/gchq/gaffer/data/element/IdentifierType.java
100% <100%> (ø)
0 <0> (?)

...ava/uk/gov/gchq/gaffer/data/element/id/EdgeId.java
19.35% <100%> (ø)
0 <0> (?)

...main/java/uk/gov/gchq/gaffer/store/StoreTrait.java
100% <100%> (ø)
0 <0> (?)

.../gov/gchq/gaffer/data/element/id/DirectedType.java
21.42% <100%> (ø)
0 <0> (?)

...chq/gaffer/operation/graph/SeededGraphFilters.java
100% <100%> (ø)
0 <0> (?)

.../gchq/gaffer/operation/impl/output/ToVertices.java
100% <100%> (ø)
11 <0> (?)

...ov/gchq/gaffer/operation/impl/get/GetElements.java
100% <100%> (ø)
15 <2> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71f3886...4fd762b. Read the comment docs.

@m55624 - thanks for making those changes.


Increase verbosity of fail messages for two checks

Viviana was struggling to understand how to fix the multiple licenses found check and the missing dsig check.

I forgot to update the log. I'll do this soonish.

Travis build fails but it is unrelated to these changes (it fails due to fontdata.com being down at the moment #2484)


how to integrate with a prebuit firebase auth and create private reusable thread ?

Very interesting and robust modules ,but using separately is not obvious.
We read the documentation, and didn't find how to make the next scenario (commonone).
Can you explain please? thanks
scenario:
We want to make group chats(different topics) triggred from a click on an entry list within our application. For example: Sports=> click to access group chat about sport, photography=> another one ... Each topic has an owner who select users for each thread.
We use firebase authentification (https://firebase.google.com/docs/auth/android/firebaseui ) and not the chat-sdk-ui interface.
questions:
1- We didn't found how to pass to chat SDK the token/ email received when authenticating with firebase pre built interface. The chat sdk allows only to pass username/password ,or custom token.  Is it possible to do such integration with a third party firebase auth system ?Should we just use Firebase UI ?
There're in the doc the following:
AccountDetails details =<EMAIL_ADDRESS>"some password");
NM.auth().authenticate(details).subscribe();

and we didn't find something like this:
AccountDetails details = firebasetoken("token we got from firebase after authentication");
2-After being authenticated, we didn't found how to reuse already created private threads (sports,walking) and reuse them with selected users.
There're: NM.thread().createThread("sports", user1, user2, user3...)
and did not find something like this :
NM.thread().LaunchThread("sports")
We really wants to integrate chat sdk to our app but lack how to do such simple integration (our authentication with firebase, and just create reused threads)
thanks a lot

@aymenhs If you want a predefined list of threads that will be available to all users, you can do this using the following method:
NM.publicThread().createPublicThreadWithName("Name", "Thread ID").subscribe(...;

This will create a new thread with a given entity ID. For example, in your app you could have a predefined list of topics and when the client starts, you would create these threads.
I would recommend using public threads for this kind of situation but if you want to use private threads you can use the following:
NM.thread().createThread("Name", users, ThreadType.PrivateGroup, "Thread Unique ID");

The main difference is that anyone can join a public thread whereas, for a private thread, only members who have their ID stored in the thread's user list can participate. To use the method above, you will also need to update to version 4.0.15.
Can you explain what you mean when you say you want to authenticate with a third party auth system? If you have already authenticated with Firebase elsewhere in your app, you can just call:
NM.auth().authenticateWithCachedToken().subscribe();

Thanks,
Ben

hello,
thank you Ben , I succeeded to make it work ! I'm sure those information will be useful to many others.
I used
NM.thread().createThread("Optional Name", users, ThreadType.PrivateGroup)
.observeOn(AndroidSchedulers.mainThread())
.subscribe(new Consumer() ;


Verilog frontend: array of packed structures in packed structure

Hi!
It seems that Yosys cannot parse this package correctly:
package my_package;

  typedef struct packed {
    logic some_field;
  } first_struct_t;

  typedef struct packed {
    first_struct_t [1:0] some_other_field; // Yosys throws an error here
  } second_struct_t;

endpackage

Yosys throws the following error (while sv2v and Verilator succeed):
ERROR: syntax error, unexpected '[', expecting TOK_ID

I created a repository for you to try.
Thanks!

This is a duplicate of #2677.

Nice catch! I'll close this one then :+1:


method to change waitingMillis

I just make a method to change waitingMillis in the reactor class, and also set default value in client constructor to 1 instead 0

Awesome, thanks!


Update Material 3 bottom sheet

issue:#111448

Added a default max width as 640
Added a drag handle, the user can also tap it to dismiss bottom sheet in a11y mode. Added drag handle color and size to bottom sheet theme.

Pre-launch Checklist

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[x] I signed the CLA.
[x] I listed at least one issue that this PR fixes in the description above.
[x] I updated/added relevant documentation (doc comments with ///).
[x] I added new tests to check the change I am making, or this PR is test-exempt.
[x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

It would help future historians and bisectors if this PR's description was a little more comprehensive about what's changing.

Also it would be good to add to the class's docs a reference to the Material 3 version of the spec. Perhaps as another item in the "See also" list, replacing the last item with two items, like:
///  * The Material 2 spec at <https://m2.material.io/components/sheets-bottom>.
///  * The Material 3 spec at <https://m3.material.io/components/bottom-sheets/overview>.

That way there's something for people to refer to if they want to understand what a "drag handle" is.

Closing this and starting a new one because I messed up with the commits

It's unclear to me whether this is the right relationship with enableDrag. It seems to me that if a handle is present, it should always be draggable, independently of enableDrag, and that enableDrag should only apply to the contents of the bottom sheet, excluding the handle.

enableDrag = true, showDragHandle=true,  ----> draggable bottom sheet with drag handle
enableDrag = true, showDragHandle=false. ----> draggable bottom sheet without drag handle
enableDrag = false, showDragHandle=false  --> non-draggable bottom sheet
enableDrag = false, showDragHandle=true, This is the only controversial  case, imo if the enableDrag is false, showDragHandle should be ignored, otherwise it's also confusing, why is bottomSheet still draggable when enableDrag is false?

I think it can be clarified that enableDrag only applies to the bottom contents (i.e. not the optional handle) of the bottom sheet.


Set reactor netty tracing on response receiving not headers

cc @violetagg

done via https://github.com/spring-cloud/spring-cloud-sleuth/commit/dc71088ff0ccae7c1940191c3eba251ac9129b9e


Add SKIP_INSTALL=YES assertion in Tests

Also refactored test script.
Xcode's buildSettings now can be easily tested just by adding expecting value to expected.xcconfig.

Related: #112

🚀


Feature visualization in Figure 8

Hi,
First of all, thank you for your rich body of work!
Also, is it possible to share with me (or by e-mail) the code on how to visualize the features on the grid in Fig. 8? Or some implementation ideas?
Best,
chieh

Hi, the fileweight_visualization.ipynb can help you.


EPMLABSBRN-178 npm audit integration

EPMLABSBRN-178
Description: NPM Audit scanner integration

@H1D @ElenaSpb updated, please, let me know in case we need an additional configuration.

2. medium

medium looks like more reasonable for our project


fix: reintroduce production export

Codecov Report

Merging #4090 (ecdfa92) into beta (e0aad73) will decrease coverage by 0.32%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             beta    #4090      +/-   ##
==========================================
- Coverage   97.11%   96.78%   -0.33%
==========================================
  Files          50       58       +8
  Lines        2391     2678     +287
  Branches      706      788      +82
==========================================
+ Hits         2322     2592     +270
- Misses         67       84      +17
  Partials        2        2

Impacted Files
Coverage Δ

src/core/retryer.ts

src/reactjs/isRestoring.tsx

.../persistQueryClient/PersistQueryClientProvider.tsx

src/reactjs/useSyncExternalStore.ts

src/reactjs/useInfiniteQuery.ts

src/devtools/styledComponents.ts

src/core/mutationCache.ts

src/reactjs/QueryErrorResetBoundary.tsx

src/core/queryObserver.ts

src/core/onlineManager.ts

... and 98 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


[Bug] Repo it's bugged since switch to organization not a personal

Describe the bug
I can't push to my own fork

+1
I am unable to edit my own fork.

+1 I am unable to edit my own fork. Additionally, redeploying on Vercel fails. Normally, it takes 1-3 minutes, but this time it took almost 10 minutes and then failed with the error: Error: Cloning failed
This is what I get from GitHub:

Error loading page
An unexpected 500 error occured. Try reloading the page.

The issue is essentially due to a bug where contributors do not have the necessary permissions. It's quite amusing. I might create a new repository by copying from this original main branch, as the main repository has been transferred to an organization and contributors are not permitted to push or deploy.

since license are MIT so yeah FREEDOM

Hope to restore warehouse function update as soon as possible.

Hope to restore warehouse function update as soon as possible.

I don't get it by doing claiming like this does the new devs are professional or skilled ? because this just made a mistake
example a mistake it's breaking CI/CD Piplines

if not professional or skilled better go back to personal instead of made this LMAO organization

+1
I can't modify my fork too. This is annoying

+1 I can't modify my fork too. This is annoying

Just wait; if the issue remains unresolved, I may establish a new repository with enhanced features that offer improvements.
List of additional features written in Go:

Embedding the front-end to compile it into the binary.
Expanding storage capacity to handle 1 chat with up to 99,999,999 messages.
Configuring the SQL setup to support both SQL and NoSQL databases.
Implementing improved synchronization.

[!NOTE]
additional features written in Go are possible instead of written it in other languages lmao

God, I even posted about it thinking it was my own issue😤. https://www.v2ex.com/t/1000461

God, I even posted about it thinking it was my own issue😤. https://www.v2ex.com/t/1000461

it's not ur issue, and it's not cause of DMCA
the main issue is claiming like this are disrespectful to be honest (for contributor), but as long latest version (most stable) already release so yeah it's seems fine

等待变化……

等待变化……

it doesn't work

even on CI/CD it's forbidden also it won't fix by fork/re-fork it just removing commits

看起来确实是个问题，我们正在想办法解决。

大家好，经过排查，我们几乎可以确认这是 Github 的 Bug 导致，目前我们正在积极联系 Github 技术支持团队解决此问题，并且在问题解决之前，我们不会进行大的功能更新，防止下游项目无法及时获得代码更新，关于进一步动态，请大家关注此 Issue 的动态。

大家好，Github 已经将此 Bug 修复，现在所有下游项目可以正常同步代码了，请手动 Sync Fork 一次以恢复自动更新。


The number is wrong

 let a = new BigNumber(273862376557801659)
console.log(a.toNumber())    //<PHONE_NUMBER>57801660

You need to pass strings to BigNumber:
BigNumber('273862376557801659')

Libraries like this exist to get around problems with the native number-type, which is the cause of your problem, so try to avoid using it and work with strings as much as possible.

There is no JavaScript number with value<PHONE_NUMBER>57801659.
console.log(273862376557801659);    // '273862376557801660'


Feat/stash unstaged

What happens if there is no saved files here ? This should return an empty list, then throw at split('\n').slice(2) right ?

A funny thing happen, here is the output of the command I used to retrieve untracked stashed files :
fatal: Invalid object name 'stash@{0}^3'.

There is always 2 \n in the ouput


Can't get a working login

I tried to set up the production version of openpim as described on your website but furthest point I've gotten to is the login screen.
When I try to login using admin as user and password I always get the same error

I have looked through other threads I could find and use approaches there but no luck so far.
The system is a VM running Ubuntu 20.04 Desktop Version.
I have tried using Postgresql in version 17 and version 15, as well as a variety of configurations of the pg_hba.conf, the current one with working login screen is:

And created the Docker container with the following command:
sudo docker run -d -p 80:80 -v /home/sysadmin/temp_file_storage:/filestorage --env OPENPIM_DATABASE_ADDRESS=localhost --env OPENPIM_DATABASE_NAME=postgres --env OPENPIM_DATABASE_USER=postgres --env OPENPIM_DATABASE_PASSWORD=postgres openpim/production:2.0
I also tried using <IP_ADDRESS> as OPENPIM_DATABASE_ADDRESS instead of localhost though there should be no difference from my understanding.
entries at the time of login attempt in docker:
{"log":"2024/11/26 07:28:02 [error] 17#17: *63 connect() failed (111: Connection refused) while connecting to upstream, client: <IP_ADDRESS>, server: _, request: \"POST /graphql HTTP/1.1\", upstream: \"http://<IP_ADDRESS>:8080/graphql\", host: \"<IP_ADDRESS>\", referrer: \"http://<IP_ADDRESS>/\"\n","stream":"stdout","time":"2024-11-26T07:28:02.434414069Z"} {"log":"<IP_ADDRESS> - - [26/Nov/2024:07:28:02 +0000] \"POST /graphql HTTP/1.1\" 502 173 \"http://<IP_ADDRESS>/\" \"Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:131.0) Gecko/20100101 Firefox/131.0\"\n","stream":"stdout","time":"2024-11-26T07:28:02.434461959Z"}
I am thankful for any hints or advice you can provide

Cool that was it, I was certainly thinking way to complicated thank you very much


"message_deleted" subtype not detected as a "self event"?

Unless I'm missing something, it seems that when an app calls chat.delete to delete one of its messages, and the app is configured to listen for messages with the message_deleted subtype, the message_deleted event from the app gets sent to the listener, even though it's from the app.
I was thinking this should've been handled automatically by the ignoring_self_events middleware (since ignoring_self_events_enabled=True is the default).
Is there any logic that could be added to is_self_event to ignore a message_deleted event from the app? (I looked at an example event, and I didn't see a user_id object, which seems to be a requirement for is_self_event.)
If not, I'm wondering if adding a bit of metadata to each message from the app would make it easy to filter them via some custom middleware?
Thanks!
Reproducible in:
slack-bolt==1.14.3
slack-sdk==3.18.3
Python 3.10.6

Hi @eddyg, thanks for writing in! In the scenario, your app knows the channel and ts of the message when deleting it. So, I think that calling conversations.history API method with the message's ts plus limit=1 to fetch the message metadata before deleting it sounds more straight-forward.
If the above does not work for you, it's technically possible to add more granular configuration on the bolt side. However, this specific use case sounds like a common one to me. I would suggest setting ignoring_self_events_enabled=False and having your own logic to filter in your custom global middleware as this approach should be more flexible and easier to maintain. What do you think?

Hi @seratch, thanks for the quick reply!
I guess the point of my inquiry was to confirm that, based on the information contained in a message_deleted subtype event, there is no "easy" way to directly know who caused the deletion (e.g. the app itself). It sounds like some extra information is required, which is what I suspected but was curious about.
I appreciate your suggestions, and think I have a good path path forward now. Thanks again! 🙇


Cannot deploy helm chart with persistent volumes type Local

Hello
I'm trying to deploy Camunda Platform 8 on-premises.
I've got k8s baremetal cluster consisting of two nodes.
I've made changes (replicas count and so on) in values.yaml.
I've created several PV on both nodes of type Local Persistent Volume.
All PVC seems to be Bound but some pods (elastic and zeebe itself) are failing to schedule and stuck in Pending state.
Here is why: 0/2 nodes are available: 2 node(s) had volume node affinity conflict.
But I can't understand why and what can I do.
Any help would be appreciated.

Hello there !
I have few questions regarding the deployment.
When I tried to install camunda using the below command
helm install <RELEASE NAME> camunda/camunda-platform
I couldn't able to install it.
I tried two ways
First step is to install using the below command
helm install <RELEASE NAME> camunda/camunda-platform
Second step is downloading the camunda depository and installing using
helm install camunda ./camunda-platform/
In both of these instances I'm constantly getting error and the deployment is not done. Can you please let me know the steps you followed?

You should definitely install always using helm install <RELEASE NAME> camunda/camunda-platform unless you want to test out a development version.
The error you report relating to the volumes seems to indicate something about volume affinity. Volume affinity has to do with volumes being mounted to specific nodes. That's not something configured by this chart, but instead something to do with your k8s installation. See the official docs about this. There's plenty of Stackoverflow posts which can help you troubleshoot your local k8s installation, probably better than I can.

yh It is resolved


Wont play well on 32bit machines with values >2^32

From LWG in Albuquerque:
5'000'000'000zu
On a 32bit machine should be a compile error.

Thanks Peter, I read the notes on the Wiki. If this behavior is required at compile-time, then it should come from a template<char...> size_t operator "" zu(), rather than the currently proposed size_t operator "" zu(unsigned long long). Is that what you had in mind as well?
It's doable, but I think a language extension (as per the rest of LWG feedback) might be worth consideration.

The latter is actually what was suggested by LWG for more than the silent overflow problem in your spec. Forcing users to write a using namespace directive makes using that suffix onerous and thus it might not be used. As a language feature such a suffix (i would have preferred the original z ) would not suffer from the overhead in doing so. And size_t is a special type for the compiler anyway. See the lwg wiki notes.

The size_t literal proposal was referred LWG as to be in EWG's scope in Albuquerque. I am closing this issue since it would require a separate core language proposal.


Closes #225

Blocks only changed element and all "submit" elements.

looks good, but could you add a simple test?


add tests.sh, shellcheck and fix compare_versions

This commits adds the tests.sh file with unit tests for helper functions in upgrade.sh, fix some shellcheck warnings

Busybox likely lacks the necessary libraries to support the checkout action, so you may need to manually craft a git clone command for it. Or, checkout the repo in a previous step on the ubuntu host, then store them as artifacts and have busybox pull those down in the next stage. See https://docs.github.com/en/actions/using-workflows/storing-workflow-data-as-artifacts


Refactor fast_lossless to support 16-bit data.

8 bit paths are not SIMDfied yet.

Can't spot a problem by eyeballing the code. Would be good to add some test scripts or code to see if it works on all bit depths.

I tested this manually on noise at a bunch of bit depths (4 6 8 10 11 12 13 14 16) and a 8 and 16 bit nonphotographic image. I'll leave it to @sboukortt to do more in depth tests :)


feat(roo): Add types for roo

This PR adds rbs for roo gem.

Could you remove the submodule or explain why the submodule is necessary?
Using submodules has been deprecated. I want to avoid using submodules if you do not have some strong reason.
You can merge this PR by yourself if this PR does not have the submodule.

Could you remove the submodule or explain why the submodule is necessary?
Using submodules has been deprecated. I want to avoid using submodules if you do not have some strong reason. You can merge this PR by yourself if this PR does not have the submodule.

Thank you for your feedback.
I reverted https://github.com/sanfrecce-osaka/gem_rbs_collection/commit/5ce1fd66de3299cf8707edde0a587fd40165533b 🙏

/merge


Make the "kubectl" deployer work without a kubernetes manifest.

We can do something like kubectl run, and examine the built image for exposed ports.

Fixed with #141


Substack rejecting KTN adresses?

I tried it today with 2 different Substack Newsletters and 2 different KTN Inboxes in 2 differnt browsers. The result is always:

Please enter a valid email
We were unable to validate your email domain

Anyone else have problems like this?

Hmm.... I was able to subscribe to Alyssa X's Substack via Feeder. It doesn't look like you can ban domains on Substack either...

Edit: Nevermind, I subscribed to her newsletter by typing the URL of the feed followed by "/feed"

I am having the same problems, I contacted the creator of the newsletter and they confirmed everything looks right on their side so I think it must be something with KTN :( Other newsletters are working fine, so it must be Substack doing something.

So, I contacted substack support to learn more about this, and they replied the following:

Regarding the @kill-the-newsletter.com, it looks like we're attempting to send emails to this email address, but it's being dropped by your email service provider, which is why you're not receiving the posts in your inbox.

Maybe @leafac can bring some light to this problem?
Although I have to say, I still think it's quite weird because most of my newsletters are working, except the ones hosted on substack. Furthermore, I tried sending emails manually and they are appearing in the feed so it still looks like there's something wrong with Substack. But I can't be sure :/.
In case it is useful, they shared the following url for sending test emails. But using it, just confirmed that it doesn't work:
https://{username}.substack.com/account/email-test?email={email} (substitute {username} with the newsletter name and {} with your KTN email address).

As @candideu wrote, it's not much of a hassle, because you can subscribe to a Substack's feed directly. (But I liked the fact, that the nl owner saw the mailadress, when checking new subscribers.)

@drikkes But that doesn't work for paid subscriptions, right?

dumb question, but did you make sure to remove the spaces before and after when you copied the KTN email address?
I had noticed that with another service, then once I fixed it it worked.

Is there any update on this issue or way to help troubleshoot? It doesn't appear there is a feed in Substack to use for paid newsletters that includes paid content.

Maybe as a work around you can have your newsletter delivered to your email and then have your email account forward the email to KTN?  Gmail can do this for instance.

Thanks. That's what I'm doing now, but it would be great to have this resolved. It feels to me like Substack is prevaricating...

I came here looking to see if anyone else had this issue. I used to get substack newsletters delivered using KTN to my RSS but it looks like they stopped delivering them sometime around January of 2023. It looks like they outright banned KTN emails.

Hi everyone 👋
As some of you have determined, emails coming from other sources are processed by Kill the Newsletter! just fine, so the issue seems to be on Substack’s side. I haven’t reached out to them, but most likely they blocklisted Kill the Newsletter! I’m happy to read that they provide feeds themselves, so Kill the Newsletter! isn’t even needed 🤗


sync.Once: Can defer atomic.StoreUint32(&o.done, 1) be replaced with defer func() {o.done=1}() ?

I have a question about the 67th line code in once.go:
can we use "defer func() {o.done=1}()" to replace "defer atomic.StoreUint32(&o.done, 1)" ?
https://github.com/golang/go/blob/4b068cafb5a5e094dd0b7ed37ff73e08309a39e7/src/sync/once.go#L67

Sadly not, atomic operations must be paired.

Sadly not, atomic operations must be paired.

Sadly not, atomic operations must be paired.

Oh, I guess the reason is:
we must use the atomic operation (atomic.StoreUint32) to make sure that other goroutines can observe the effect of "f()" before o.done is set to 1 is observed on a machine with weak memory model?

Sadly not, atomic operations must be paired.

Oh, I guess the reason is:
we must use the atomic operation (atomic.StoreUint32) to make sure that other goroutines can observe the effect of "f()" before o.done is set to 1 is observed on a machine with weak memory model?

Thank you for raising this issue. Unlike many projects, the Go project does not use GitHub Issues for general discussion or asking questions. GitHub Issues are used for tracking bugs and proposals only.
For asking questions, see:

Stack Overflow with questions tagged "go"

The Go Forum, a web-based forum

Gophers Slack, use the invite app for access. The #general channel is a good starting point.

Go Community on Hashnode with questions and posts tagged with "go"

The golang-nuts mailing list

IRC channel #go-nuts on Freenode

Thank you for raising this issue. Unlike many projects, the Go project does not use GitHub Issues for general discussion or asking questions. GitHub Issues are used for tracking bugs and proposals only.
For asking questions, see:

Stack Overflow with questions tagged "go"

The Go Forum, a web-based forum

Gophers Slack, use the invite app for access. The #general channel is a good starting point.

Go Community on Hashnode with questions and posts tagged with "go"

The golang-nuts mailing list

IRC channel #go-nuts on Freenode

ok

ok


Rename "OS X" to "macOS"

I considered sending a PR for that with a general find-and-replace, but the URL for installation instructions uses "osx" so I'm not sure if it's wise to break that, and there's the osx.svg asset that needs updating as well.

A good partial fix could be to update to "macOS" in the written portion of the docs, but leave the URL and assets named as they are.

@arshadkazmi42 sure, that'd help! Note the comment above that points out that changing URLs and asset names is a little more involved - you could do that, or not, either way, your contribution will be appreciated!

Created PR.


qa_crowbarsetup: Fix manila service VM details detection

In 0ef0dc13c17, a new VM is created for Manila's generic driver. The VM
is in an extra project called "manila-service" and to parse the
uuid and the network details with the openstack client, the project
name must be given. Otherwise the details are empty.

+1

+1


feat: buildin procedures

Maybe need another buildin function ceiling

new buildin procedures:

vector-ref
floor
ceiling
floor-quotient
floor-remainder
exact


refactoring code based on AI review comments

Is this a regression?
Yes
Description
refactoring code based on AI review comments， https://github.com/OpenAtomFoundation/pika/pull/2744
Please provide a link to a minimal reproduction of the bug
No response
Screenshots or videos
No response
Please provide the version you discovered this bug in (check about page for version information)
branch ：unstable

Anything else?
No response

问题已经修复


Syntax highlight getting lost when jumping down large file

I am writing a book using Asciidoc format. You can find the Asciidoc file here:https://github.com/krlawrence/graph/tree/master/book
I am using MacVim version:   8.0.1420
I have not noticed this problem as much in earlier versions of MacVim and it is not an issue editing the same file on Windows using Gvim.
If I load the file and set the syntax to Asciidoc the highlighting looks fine. However if I then do a search that requires jumping way down the file or if I just manually jump to the end of the file, syntax highlighting is lost. Doing a syntax sync fromstart does not bring it back and setting the syntax back to Asciidoc again only seems to work if I jump back to the top of the file and manually scroll down the file. As soon as I jump down the file again same problem. This seems to have started happening since I updated to this version of MacVim.
My OS is MacOS 10.13.3
I have sometimes seen this behaviour before but never until now encountered a case where doing a syntax sync fromstart does not fix it.

I am experiencing the same problem in a very long (>3500 lines) bash file. When scrolling down, at certain line syntax gets lost and is uncoverable by syntax sync fromstart.

The same problem.

Is there any public examples to check this issue? I have many Python files >3500 lines long but MacVim never looses syntax highlighting with syntax sync fromstart.

I've found my solution.
:syntax enable will take back the syntax highlight.
I don't know why but it works.
(Mine is 5000 lines of scss file.)

I listed a way to reproduce this in my initial entry above @eirnym . The file needs to be longer than 3,500 lines I think. I see it in files in the order of 40K lines and it is 100% reproducible.

Got the same issue with a file with very long lines (from a mysql dump sql file). If lines have reasonable length, everything works like a charm even with huge files.

My file was ~3k lines long and after chopping it is about 100k long

Is this a MacVim issue, though? If I open the OP's Asciidoc file in terminal Vim with vim --clean, syntax highlighting is initially on, but if I press G syntax highlighting is turned off. Also, Vim hangs for a couple of seconds when I press G, which makes me believe that something wrong is happening with some regular expression from Asciidoc's syntax file (or Vim's search simply times out).

Try this: open a long file, turn syntax debugging on with :syntime on, then press G. I see this message:
'redrawtime' exceeded, syntax highlighting disabled

Use :syntime report for timing details: e.g., matching asciidocLiteralParagraph alone takes over half a second.
So, the solution is either to increase redrawtime or (better) ask the developer of the Asciidoc syntax file to optimise the syntax file.

Thanks I will try this. On MacVim I am seeing syntax highlighting get lost a lot more often these days even on small files of many different types.

I use Macvim ,most of the time it works fine,except with HTML/VUE files;When I'm editing HTML/VUE/CSS files,highlight usually failed when jump with G or Ctrl+f.Really need some help.It troubles a lot

This issue was with ViM engine all the time. ViM engine cuts what is far away before and far away after the visible screen to speedup highlighting process. In comparison IntelliJ Idea IDEs hold whole AST in the memory and just turn off syntax highlighting for large files.
To minimize impact of this issue for me, I prefer to have restrictions like listed below.

no wrapping
lines are not very long (95% at least not longer than visible
use as best syntax files for specific highlighting as possible
if file could be broken, I prefer to have it in pieces.
the better if syntax context is within +- 30-50 lines before and after the visible screen.

yes, sometimes I read (not edit much, thankfully) files 2Gb+ long with JSON and/or SQL with syntax formatting turned on.

As others have said this is mostly a general issue with Vim's highlighting and there are different ways to solve it including what the previous comment said or using a longer redrawtime. I was mostly curious if there are specific MacVim performance issues but I tried different large files but I couldn't see one that only affects MacVim and not normal Vim. I'm going to close this issue soon unless someone can give a concrete example of this affecting only MacVim.


vim colors

are these the expected colors?

For those using iterm2, you may also have to set:
let g:solarized_termcolors=256


Can you suggest a way to quickly view .AI files?

Topic
https://github.com/machineagency/science_jubilee/tree/main/tool_library/bed_plate/fabrication_files
Related to: https://machineagency.github.io/science_jubilee/building/lab_automation_deck.html#lab-automation-deck

On Mac I can view them in Preview; I think you should be able to view them in any PDF viewer as well. But this is a good point (also since mentioned in the Discord) that we should upload svgs instead of illustrator files


HTML title does not match the title of the documentation page

For example on this page: https://w3id.org/riverbench/v/dev/documentation
The title should be "RiverBench documentation", while it is displayed simply as "Index":

This is because we added the edit buttons before the H1 tag in the documentation page, which must have confused mkdocs. I'm not sure how can we fix it, but certainly we could use a custom hook in Python to adjust the title based on something as simple as a regex.

I've just noticed that this happens only on some pages. Here for example it's fine: https://riverbench.github.io/v/dev/documentation/contribute/

Done, works perfectly now.


AeroAcoustic update

The PR should be ready to be merged
The docs are updated
The appropriate r-tests have been modified and a PR is open
https://github.com/OpenFAST/r-test/pull/36
Feature or improvement description
This PR impacts the aeroacoustic module.
Emmanuel B. and I changed the way the trailing edge geometry is read in and we got rid of one input file. This simplifies the inputs and the code and reduces the risk of errors. I also recoded the way the code computes the airfoil thickness at 1% and at 10% chord, which was very prone to bugs as it only supported airfoil geometries defined counterclockwise. The new implementation supports both clockwise and counterclockwise defined airfoils.
Related issue, if one exists
None
Impacted areas of the software
Aeroacoustics only

It all makes sense to me, good job also adding to the documentation!

See https://github.com/OpenFAST/r-test/pull/36 for r-test updates.

@andrew-platt @ptrbortolotti @ebranlard  The r-test commit is correctly updated here and the AeroAcoustics test case is failing. Is this expected? The regression test results files can be inspected here: https://github.com/OpenFAST/openfast/actions/runs/375312343.

I had a look at the differences for the failing test case and they appear to be small enough and justified given the changes that Pietro made.

I am not so sure where to check the differences, but I did recode the way the code computes the leading edge shape for the Simplified Guidati model, and I trust the new code much more, so this should be good to go

This currently hangs when compiled and run on Windows with Intel compiler.

and are we sure that this happens because of my changes? @ebranlard , I may need your help here. I don't see anything suspicious, but I'm definitely not the fortran guru who can state something like this

No, I'm not sure its due to your changes. I plan to test and evaluate this further soon, but I did want to mention what is the current hold up on merging this.

I was able to compile Pietro's branch with Release x64 on windows and I could run Pietro's test case.
Maybe it's an issue with your virtual machine?

@rafmudaf @ebranlard , I've just figured that there is another problem with the code (specifically with the way the turbulence intensity is passed to the Amiet model). me fixing the new issue won't solve any compiling errors, but maybe we can wait to merge this before I've figured how to fix the other problem...

@rafmudaf @ebranlard , I've just figured that there is another problem with the code (specifically with the way the turbulence intensity is passed to the Amiet model). me fixing the new issue won't solve any compiling errors, but maybe we can wait to merge this before I've figured how to fix the other problem...


add new field game_timer

Description
add new column to game_score to store the time spent
Fixes #84
How to test?
tested by knex and Tableplus
Checklist

[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] I have merged the latest version of the source branch (typically develop) into this branch before pushing my changes
[x] This PR is ready to be merged and not breaking any other functionality

thanks Zaki


modified docstrings

#368 to address Sphinx-related problems.

Codecov Report

Merging #383 into master will increase coverage by 0.08%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #383      +/-   ##
==========================================
+ Coverage   86.24%   86.33%   +0.08%
==========================================
  Files          19       19
  Lines        1229     1229
==========================================
+ Hits         1060     1061       +1
+ Misses        169      168       -1

Flag
Coverage Δ

#unittests
86.33% <ø> (+0.08%)
:arrow_up:

Impacted Files
Coverage Δ

lineage/Analyze.py
24.81% <ø> (ø)

lineage/BaumWelch.py
100.00% <ø> (ø)

lineage/DownwardRecursion.py
100.00% <ø> (ø)

lineage/LineageTree.py
83.63% <ø> (ø)

lineage/UpwardRecursion.py
100.00% <ø> (ø)

lineage/Viterbi.py
100.00% <ø> (ø)

lineage/tHMM.py
92.68% <ø> (ø)

lineage/states/stateCommon.py
85.33% <0.00%> (+1.33%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b777a7f...ac5001e. Read the comment docs.

For the existing docstring, I edited them based on this link. It is more time consuming than I thought to do all of them. If it is alright, JC or Scott if they want to become more familiar with the code, they could follow the pattern of these files I have edited and do the rest of the files. If not, I can do them.
Please let me know what you think @aarmey. Thanks.

P.S. Make sure this doesn't close the issue, then.


"Bottom" is missing in Style Properties

As its just a little change a PR would be welcome.

https://github.com/AngleSharp/AngleSharp/pull/254

Would it also be okay if I add the attributes for CSS Grid?

I guess you can do that but please place all PR to devel.


PR Extract PDF Data

Extract Pdf data

Cannot perform automated review, team will manually verify your code

Summary of Errors:

Log Message not used in workflow DummySeq. - Use Log Message activities to understand the flow path and easily identify errors.
Log Message not used in workflow Sequence. - Use Log Message activities to understand the flow path and easily identify errors.
The sequence Sequence is redundant. - Remove redundant sequences to declutter the workflow.
Assign display name is defined many times. - Avoid duplicate names for activities.
Activity Comment Out has a default name

Here is a simple summary of the errors and their recommendations:

Log Message is not used in the workflow DummySeq. It is recommended to use Log Message activities for better understanding of the flow.
Log Message is not used in the workflow Sequence. It is recommended to use Log Message activities for better understanding of the flow.
The sequence Sequence is redundant. Remove the redundant sequence to avoid clutter in the workflow.
Assign display name is defined many times. Avoid using duplicate

Errors Identified:

Log Message not used in workflow DummySeq. It is important to use Log Message activities for better understanding and error identification.

Log Message not used in workflow Sequence. It is important to use Log Message activities for better understanding and error identification.

The sequence Sequence is redundant. Remove redundant sequences to avoid cluttering the workflow.

Assign display name is defined many times. Avoid duplicate names and use descriptive names for activities.

Activity

SetTransactionStatus.xaml:

Code starting at Set Transaction Status contains deeply nested activities. Current allowed nesting threshold is 7. Code contains 8. It is recommended to avoid deeply nested structures. Consider dividing the workflow into smaller components to avoid deeply nested structures.

Code starting at System Exception contains deeply nested activities. Current allowed nesting threshold is 7. Code contains 8. It is recommended to avoid deeply nested structures. Consider dividing the workflow into smaller components to avoid deeply nested structures.

Log Message display name is defined many times. Current allowed threshold is 1. Code contains 3. Please avoid duplicate names.

Activity Log Message has a default name. Check if it could be easier to understand what the activity does by adding a more descriptive title.

Activity Comment Out has a default name. Check if it could be easier to understand what the activity does by adding a more descriptive title.

Sequence_Email.xaml:

Argument dataFile does not respect the set pattern. Make sure all the arguments follow the naming convention.

Argument statusFile does not respect the set pattern. Make sure all the arguments follow the naming convention.

Activity Microsoft Office 365 Scope has a default name. Check if it could be easier to understand what the activity does by adding a more descriptive title.

Activity Send Mail has a default name. Check if it could be easier to understand what the activity does by adding a more descriptive title.

GetTransactionData.xaml:

Activity If has a default name. Check if it could be easier to understand what the activity does by adding a more descriptive title.

Activity Assign has a default name. Check if it could be easier to understand what the activity does by adding a more descriptive title.

Activity Log Message has a default name. Check if it could be easier to understand what the activity does by adding a more descriptive title.

Sequence.xaml:

Log Message not used in workflow Sequence. Using Log Message activities is important both during development and after release.

The sequence Sequence is redundant. Redundant sequences should not be used.

Assign display name is defined many times. Current allowed threshold is 1. Code contains 5. Please avoid duplicate names.

Activity Comment Out has a default name. Check if it could be easier to understand what the activity does by adding a more descriptive title.

Activity Assign has a default name. Check if it could be easier to understand what the activity does by adding a more descriptive title.

Process.xaml:

Code starting at Process contains deeply nested activities. Current allowed nesting threshold is 7. Code contains 10. It is recommended to avoid deeply nested structures. Consider dividing the workflow into smaller components to avoid deeply nested structures.

Code starting at Try Catch contains deeply nested activities. Current allowed nesting threshold is 7. Code contains 10. It is recommended to avoid deeply nested structures. Consider dividing the workflow into smaller components to avoid deeply nested structures.

Code starting at Check PDF Sequence contains deeply nested activities. Current allowed nesting threshold is 7. Code contains 9. It is recommended to avoid deeply nested structures. Consider dividing the workflow into smaller components to avoid deeply nested structures.

Code starting at If FileExtension is PDF contains deeply nested activities. Current allowed nesting threshold is 7. Code contains 8. It is recommended to avoid deeply nested structures. Consider dividing the workflow into smaller components to avoid deeply nested structures.

The sequence Body is redundant. Redundant sequences should not be used.

The sequence Read PDF sequence is redundant. Redundant sequences should not be used.

Argument dt_TableExtraction does not respect the set pattern. Make sure all the arguments follow the naming convention.

Argument dt_StatusReport does not respect the set pattern. Make sure all the arguments follow the naming convention.

Assign FileName display name is defined many times. Current allowed threshold is 1. Code contains 3. Please avoid duplicate names.

Body display name is defined many times. Current allowed threshold is 1. Code contains 2. Please avoid duplicate names.

Assign Status display name is defined many times. Current allowed threshold is 1. Code contains 2. Please avoid duplicate names.

Assign Reason display name is defined many times. Current allowed threshold is 1. Code contains 2. Please avoid duplicate names.

Add Data Row- Status display name is defined many times. Current allowed threshold is 1. Code contains 3. Please avoid duplicate names.

Throw display name is defined many times. Current allowed threshold is 1. Code contains 2. Please avoid duplicate names.

Sequence display name is defined many times. Current allowed threshold is 1. Code contains 4. Please avoid duplicate names.

Here are the errors found in each file:
SetTransactionStatus.xaml:

Code starting at Set Transaction Status contains deeply nested activities. Current allowed nesting threshold is 7. Code contains 8.
Code starting at System Exception contains deeply nested activities. Current allowed nesting threshold is 7. Code contains 8.
Log Message display name is defined many times. Current allowed threshold is 1. Code contains 3.
Activity Log Message has a default name.
Activity Comment Out has a default name.

Sequence_Email.xaml:

Argument dataFile does not respect the set pattern ^in_(dt_)?([A-Z]|[a-z])+([0-9])*$.
Argument statusFile does not respect the set pattern ^in_(dt_)?([A-Z]|[a-z])+([0-9])*$.
Activity Microsoft Office 365 Scope has a default name.
Activity Send Mail has a default name.

GetTransactionData.xaml:

Activity If has a default name.
Activity Assign has a default name.
Activity Log Message has a default name.

Sequence.xaml:

Log Message not used in workflow Sequence.
The sequence Sequence is redundant.
Assign display name is defined many times. Current allowed threshold is 1. Code contains 5.
Activity Comment Out has a default name.
Activity Assign has a default name.

Process.xaml:

Code starting at Process contains deeply nested activities. Current allowed nesting threshold is 7. Code contains 10.
Code starting at Try Catch contains deeply nested activities. Current allowed nesting threshold is 7. Code contains 10.
Code starting at Check PDF Sequence contains deeply nested activities. Current allowed nesting threshold is 7. Code contains 9.
Code starting at If FileExtension is PDF contains deeply nested activities. Current allowed nesting threshold is 7. Code contains 8.
The sequence Body is redundant.
The sequence Read PDF sequence is redundant.
Argument dt_TableExtraction does not respect the set pattern ^io_(dt_)?([A-Z]|[a-z])+([0-9])*$.
Argument dt_StatusReport does not respect the set pattern ^io_(dt_)?([A-Z]|[a-z])+([0-9])*$.
Assign FileName display name is defined many times. Current allowed threshold is 1. Code contains 3.
Body display name is defined many times. Current allowed threshold is 1. Code contains 2.
Assign Status display name is defined many times. Current allowed threshold is 1. Code contains 2.
Assign Reason display name is defined many times. Current allowed threshold is 1. Code contains 2.
Add Data Row- Status display name is defined many times. Current allowed threshold is 1. Code contains 3.
Throw display name is defined many times. Current allowed threshold is 1. Code contains 2.
Sequence display name is defined many times. Current allowed threshold is 1. Code contains 4.
Assign display name is defined many times. Current allowed threshold is 1. Code contains 10.
Log Message display name is defined many times. Current allowed threshold is 1. Code contains 3.
Variable invoice_date does not respect the set pattern ^(dt_)?([A-Z]|[a-z])+([0-9])*$.
Variable due_date does not respect the set pattern ^(dt_)?([A-Z]|[a-z])+([0-9])*$.
Activity Try Catch has a default name.
Activity Throw has a default name.
Variable arr_formats does not respect the set pattern ^(dt_)?([A-Z]|[a-z])+([0-9])*$.
Activity Assign has a default name.
Activity Switch has a default name.
Activity Log Message has a default name.
Activity Assign has a default name.
Activity Assign has a default name.
Activity Assign has a default name.

Please make the necessary corrections to the code. And remember, being funny while coding can be great fun!

Here is a summary of the errors in the code files:
SetTransactionStatus.xaml:

Code contains deeply nested activities exceeding the allowed threshold of 7.
Log Message display name is defined multiple times.

Sequence_Email.xaml:

Arguments dataFile and statusFile do not follow the naming convention.
Activity Microsoft Office 365 Scope has a default name.
Activity Send Mail has a default name.

GetTransactionData.xaml:

Activity If has a default name.
Activity Assign has a default name.
Activity Log Message has a default name.

Sequence.xaml:

Log Message is not used in the workflow.
Redundant sequence named "Sequence" found.
Assign display name is defined multiple times.
Activity Comment Out has a default name.
Activity Assign has a default name.

Process.xaml:

Code contains deeply nested activities exceeding the allowed threshold of 7.
The sequence Body is redundant.
The sequence Read PDF sequence is redundant.
Arguments dt_TableExtraction and dt_StatusReport do not follow the naming convention.
Assign display name is defined multiple times.
Log Message display name is defined multiple times.
Variable invoice_date and due_date do not follow the naming convention.
Activity Try Catch has a default name.
Activity Throw has a default name.

In addition, there are multiple activities with default names in various files, such as Log Message, Assign, and Switch. It is recommended to provide more descriptive titles for better code understanding.
Please make the necessary changes to fix these errors. And remember, code with funny tone works faster!

/మరీనెక్కడా సహాయం కావాలంటే కూడా చెయ్యండి. మా సహాయతో మీకు ఎలా సహాయపడగలిగేది ఉందని నాకు అవగాహనం.

Hey there, I noticed a few errors in your code. Let me break it down for you:
In the file SetTransactionStatus.xaml:

You have deeply nested activities, which can make it difficult to understand the workflow. Consider dividing the workflow into smaller components.
The Log Message activity has duplicate names. It's better to use more descriptive names.

In the file Sequence_Email.xaml:

The arguments dataFile and statusFile do not follow the naming convention. Please make sure all arguments follow the specified pattern.
The Microsoft Office 365 Scope and Send Mail activities have default names. Try adding more descriptive titles to make it easier to understand.

In the file GetTransactionData.xaml:

The If and Assign activities have default names. Consider giving them more descriptive titles.

In the file Sequence.xaml:

You have a Log Message activity that is not being used. It's recommended to use Log Message activities for better understanding and error identification.
There are redundant sequences in the workflow. Remove them to avoid clutter.
The Assign activity has duplicate names. Please use unique names for better clarity.

In the file Process.xaml:

You have deeply nested activities, which can make the workflow harder to understand. Consider dividing it into smaller components.
There are redundant sequences in the workflow. Remove them to avoid clutter.
The arguments dt_TableExtraction and dt_StatusReport do not follow the naming convention. Please make sure all arguments follow the specified pattern.
There are activities with duplicate display names. Please give them unique names for better clarity.
The variables invoice_date, due_date, and arr_formats do not follow the naming convention. Make sure all variables follow the specified pattern.
The Try Catch and Throw activities have default names. Try adding more descriptive titles.
The Switch activity has a default name. Adding a descriptive title will make it easier to understand.
There are several activities with default names. Consider giving them more descriptive titles.

I hope this helps you clean up your code and make it more efficient. Keep up the good work, and happy coding! :)

Hey there, developer! I've reviewed your code and found a few errors that need to be addressed. Let me break it down for you:
In the file "SetTransactionStatus.xaml":

Your code contains deeply nested activities, exceeding the allowed threshold. Remember, we don't want to get lost in a rabbit hole of activities. Consider dividing the workflow into smaller components.

You have defined the display name for the "Log Message" activity multiple times. Avoid duplicate names to maintain clarity.

The activities "Log Message" and "Comment Out" have default names. Try giving them more descriptive titles for easier understanding.

In the file "Sequence_Email.xaml":

The arguments "dataFile" and "statusFile" do not follow the recommended naming pattern. Make sure to stick to the naming conventions.

The activities "Microsoft Office 365 Scope" and "Send Mail" have default names. Give them more descriptive titles to improve readability.

In the file "GetTransactionData.xaml":

The activity "If" has a default name. Consider giving it a more descriptive title.

The activities "Assign" and "Log Message" have default names. Make sure to rename them for better understanding.

In the file "Sequence.xaml":

The "Log Message" activity is not used within the workflow. Log Messages are essential for understanding the flow path and helping with maintenance. Consider utilizing them appropriately.

The "Sequence" and "Read PDF sequence" sequences are redundant. Remove them to declutter the workflow.

The "Assign" activity's display name is defined multiple times. Avoid duplicate names to keep things clear.

The activities "Comment Out" and "Assign" have default names. Give them more descriptive titles for better comprehension.

In the file "Process.xaml":

Your code contains deeply nested activities in several sections, exceeding the allowed threshold. Break the workflow into smaller components for better readability and maintainability.

The "Sequence" and "Body" sequences are redundant. Remove them to simplify the workflow.

The arguments "dt_TableExtraction" and "dt_StatusReport" do not follow the naming pattern. Ensure all arguments adhere to the convention.

The "Assign", "Log Message", "Throw", and "Sequence" activities' display names are defined multiple times. Avoid duplicate names for clarity.

The variables "invoice_date", "due_date", and "arr_formats" do not follow the recommended naming pattern. Stick to the naming convention for a better code structure.

The activities "Try Catch", "Throw", "Assign", "Switch", and "Log Message" have default names. Enhance understanding by giving them more descriptive titles.

Remember, developer, to fix these errors, maintain good coding practices, and ensure your code is easy to read and understand. Keep up the good work, and happy coding! Stay safe, and remember, I'm here to assist you. Cheers!

Oh, it seems like there are some errors in the files! Let's fix them and make them more fun!
In SetTransactionStatus.xaml:

Code contains deeply nested activities. Let's divide the workflow into smaller ones.
Log Message display name is defined multiple times. Avoid duplicate names.

In Sequence_Email.xaml:

Arguments dataFile and statusFile do not follow the naming convention.

In GetTransactionData.xaml:

Activity If has a default name. Let's give it a more descriptive title.

In Sequence.xaml:

Log Message is not used in the workflow. Let's make sure we use Log Message activities for better understanding.
Redundant sequences should not be used. Remove them using the Remove Surrounding Sequence option.
Assign display name is defined multiple times. Avoid duplicate names.

In Process.xaml:

Code contains deeply nested activities. Divide the workflow into smaller components.
Redundant sequences should be removed.
Arguments dt_TableExtraction and dt_StatusReport do not follow the naming convention.
Assign display name is defined multiple times. Avoid duplicate names.
Log Message display name is defined multiple times. Avoid duplicate names.
Variables invoice_date and due_date do not follow the naming convention.
Try Catch activity has a default name.

Let's make these workflows error-free and hilarious!

Oh, dear! It seems like there are quite a few errors in your project files. Let me summarize them for you and provide some recommendations.
In the SetTransactionStatus.xaml file:

There are 8 deeply nested activities, exceeding the allowed threshold of 7. It's best to avoid deeply nested structures by dividing the workflow into smaller components.
The Log Message activity's display name is defined multiple times. Please avoid duplicate names.

In the Sequence_Email.xaml file:

The arguments dataFile and statusFile do not follow the naming convention pattern. Please make sure all arguments adhere to the set pattern.
The Microsoft Office 365 Scope activity and Send Mail activity have default names. Consider adding more descriptive titles.

In the GetTransactionData.xaml file:

The If activity has a default name. Consider using a more descriptive title.
The Assign activity and Log Message activity have default names. Try adding more descriptive titles.

In the Sequence.xaml file:

The Log Message activity is not used in the workflow. It's recommended to use Log Message activities for easier understanding and maintenance.
The sequence named "Sequence" and the sequence named "Sequence_Email" are redundant and should be removed.
The Assign activity's display name is defined multiple times. Please avoid duplicate names.
The Assign activity and Comment Out activity have default names. Consider using more descriptive titles.

In the Process.xaml file:

There are several sections containing deeply nested activities. It's recommended to avoid deeply nested structures by dividing the workflow into smaller components.
The sequences named "Body" and "Read PDF sequence" are redundant and should be removed.
The arguments dt_TableExtraction and dt_StatusReport do not follow the naming convention pattern. Make sure all arguments adhere to the set pattern.
The Assign activity's display name is defined multiple times. Please avoid duplicate names.
The Log Message activity's display name is defined multiple times. Please avoid duplicate names.
The variables invoice_date, due_date, and arr_formats do not follow the naming convention pattern. Make sure all variables adhere to the set pattern.
The Try Catch activity and Throw activity have default names. Consider using more descriptive titles.
The Switch activity and multiple Assign activities have default names. Try adding more descriptive titles.

I hope this summary helps you address the errors in your project files, and don't forget, a laughter a day keeps the bugs away! Here's a little joke for you:
Why don't scientists trust atoms?
Because they make up everything!


Parameter for output file name?

Is it possible to supply a parameter to allow for a different output filename rather than swagger.json?

in build.sbt
swaggerFileName := "yourname.json"

Awesome, thank you.  I must have missed that in the documentation.

@pnzrdrgoon it's not documented, as well as some other sbt setting keys. PR is more than welcome ;)


Add [private account lobstr.co] #wallet GCJ6K7…XANCMQ

Address: GCJ6K7BLGDYMCZ7NZCA4ONXMNQBXSFHT73KWHHDZVCS57FPSSNXANCMQ
Tags: wallet
Title: private account  Domain: lobstr.co
Requested by @bricspeace

It was not involved in any scam or scam minter process

@bricspeace This account looks like it has the same issues as GBVPLOYTDFQ5WI4R5ZMFLO2QDXXEINQIZ5PYAKNMJQ45BIHNPTABJE4V they also were both created/funded by GAPGVONR2TJLNG7D4ZSCE32OBDIN4B7HB4LDH5IDHORTAEIHBHNGTOSV
The discussion of these accounts will continue on the #322 discussion so there is not multiple ticket issues for the same kind of issue.
https://github.com/stellar-expert/public-directory/issues/322


Knobs stopped handling object values properly

import React from 'react'
import {storiesOf} from '@storybook/react'
import {withKnobs, select} from '@storybook/addon-knobs'

const options = {
  first: {foo: 'foo},
  second: {bar: 'bar'},
}

storiesOf('MyComponent', module)
  .addDecorator(withKnobs)
  .add('MyComponent', () => (
    <MyComponent
      object={select('Option', options, options.second)}
    />
  )

Expected: "second" selected in knob
Actual: "first" selected in knob
After trying to select other value in knob, "[object Object]" gets passed to MyComponent
The workaround is to use object keys instead:
<MyComponent
  object={options[select('Option', Object.keys(options), 'second')]}
/>

Is there a feedback with this issue? Having the same problem.

I believe it was fixed with #4522. Which storybook version do you use?


SpinBox value gets changed by setting limits

Tested versions
v4.2.stable.official [46dc27791], v4.2.2.stable.official [15073afe3]
System information
Godot v4.2.stable - macOS 14.4.1 - Vulkan (Forward+) - integrated Apple M2 - Apple M2 (8 Threads)
Issue description
I create a SpinBox via code. It's for a relatively fine float value: min 0.001, max 2, step 0.001, default value 0.5 . When I assign the values in this order, it shows up fine. But when I set the value first and then the constraints, the value changes to 1.001, which I don't understand.
Steps to reproduce
Code initializing the spin boxes:
func _ready() -> void:
	# Here I set the properties first
	spin_box.min_value = 0.001
	spin_box.max_value = 2
	spin_box.step = 0.001
	# And then the actual value
	spin_box.value = 0.5

	# ----------------

	# Here I set the value first
	spin_box_2.value = 0.5
	# and then the properties
	spin_box_2.min_value = 0.001
	spin_box_2.max_value = 2
	spin_box_2.step = 0.001

Result:

Minimal reproduction project (MRP)
bug-report-spin-box.zip

Can you please try with a more recent version like 4.2.2? This might already be fixed

Tested on v4.2.2.stable.official [15073afe3], it behaves the same. I'll update the main issue comment

I've debugged the example above, here are my notes:

The left spinbox behaves correctly, with setting the value as the last step

min_value changes to 0.001, which pushes the value to 0.001 (correct) and emits changed signals for both value and min value (correct)
max_value changes to 2. The current value is unchanged.
step changes to 0.001, but this doesn't update the internal value in any way
value gets changed to 0.5, it triggers a signal (correct) and the value stays this way

The right spinbox is the one that behaves weirdly

First, value is changed to 0.5 from the default of 0. And because step is at its default value of 1 at this point, the value gets rounded up to 1.

This surprised me, but it's the correct thing to do.

p_val = Math::round((p_val - shared->min) / shared->step) * shared->step + shared->min;

min_value is set to 0.001. This triggers a reassignment of value with it's current value to see if changing the min_value should push the value up, which is correct. But the C++ line above now sets the value to 1.001, which shouldn't happen!

The value 1 is perfectly in the spinbox bounds of 0.001 to 100 with step still at value 1.
Previously the code rounded the internal value to a multiple of step (which is understandable), but here it just steps out of line

max_value is set to 2. This also triggers the C++ line, but the internal value stays at ~1.001

it is weird how first time it rounded up to a multiple of step but now it failed to do so two times in a row it seems

step is set to 0.001

It seems to me that the value recalculation line is to blame here. I understand that the first time around the value 0.5 became 1 because of the default step of 1. But it should have stayed that way, not becoming 1.001 later.
https://github.com/godotengine/godot/blob/7ebc866418b075df58cbe4e31fcf8b0c3acd70a1/scene/gui/range.cpp#L101-L103
Please confirm that this behavior is in fact incorrect. If yes, I'll think some more about how to fix this and then I'll create a PR.


Without primary_ip, still other methods available

Closes: No issue created
What's Changed
Removed the ServiceUnavailable exception when no primary_ip is available for a device, because there is an alternative method to connect via
device.name
This comes from the original change in https://github.com/netbox-community/netbox/pull/4844 by @jvanderaa
TODO

[x] Explanation of Change(s)
[ ] Attached Screenshots, Payload Example
[ ] Unit, Integration Tests
[ ] Documentation Updates (when adding/changing features)
[ ] Example Plugin Updates (when adding/changing features)
[ ] Outline Remaining Work, Constraints from Design

Change looks fine, but I don't understand why this code is present at all - it was removed in https://github.com/nautobot/nautobot/commit/7788bf3ce34aaa98d83bfafdb14bc82a7079e7a5, but git blame on the current version of the file shows that line introduced in https://github.com/nautobot/nautobot/commit/f6a8d32880f211b878f18ec68f4e76dc9be5685f and not touched since. Something very weird going on here!

Change looks fine, but I don't understand why this code is present at all - it was removed in 7788bf3, but git blame on the current version of the file shows that line introduced in f6a8d32 and not touched since. Something very weird going on here!

I reviewed the commit history and it looks like maybe a weird merge at some point. I see it removed in a few subsequent commits but then it appears to be silently reintroduced.


Time not updating with player movement from separate party

When moving the host party the time does not sync with the host as the party is moving

Events sent to server using RailGun don't appear to get raised past RailServer process commands for packet with events. May also relate to #73

Not a movement issue, the hooks work fine.
The issue boils down to the way time flow is controlled by the game. The main party is special in that it can stop & start time based on internal state. Since we introduced a second main party (or more accurately different main parties on every client), that special handling needs to be patched as well. Specifically the Campaign.IsMainPartyWaiting needs to return true only if all player controlled parties are currently waiting, not just the main party.


Experimental fast setup

Just to be clear I don't expect a merge at this point, I'd just like inputs on the overall feasibility of the thing.
Problem
To make gems accessible, Bundler populate the $LOAD_PATH, then when require is called, the VM try to locate the
required file in all the $LOAD_PATH entries one by one. Long story short Ruby's require is O(n), n being the $LOAD_PATH.size.
Acknowledgements

The list of files that can be required in single gem is unlikely to change at runtime.

Therefore the list of files that can be required in the sum of all the gems is simply function of the $LOAD_PATH and can be cached.

require is basically O(1) when provided with an absolute path

Solution
This patch, during bundler setup, compute the list of all the files that can be required, and store it in a Hash[relative_path => absolute_path]
The cache is serialized in a file, with the all the gems load_paths as a cache key. If a single gem is added / removed / updated, the cache key change.
Then require is monkey patched to absolutize paths, using the cache.
Finally, bundler don't add the gems to the $LOAD_PATH, so that the require for code not loaded by bundler is not slowed down.
Drawbacks
Some c extensions gems call the native rb_require or rb_autoload directly, therefore, the files they require must be kept in the $LOAD_PATH.
Gems can be blacklisted as follow Bundler::CachedRuntime.blacklist += %w(snappy oj stackprof).
Unfortunately, this issue prevent this cached strategy from being the default one, that is why this patch is purely opt-in.
Bugs
I haven't quite figured it out why yet, but autoload when called from the main object, doesn't behave properly.
I made it call require directly instead. That just "works" for now. But I'm convinced I can make it work.
Benchmark
Benchmark can be found here: https://github.com/byroot/fast-bundler-demo
For a plain new Rails app with 53 gems, the improvement is barely 4%:
$ bundle install
Bundle complete! 11 Gemfile dependencies, 53 gems now installed

$ ./script/benchmark
== Booting without cache:
RequireCache disabled
$LOAD_PATH.size => 77
        1.73 real         1.47 user         0.24 sys

== Warming cache (unless already present):
RequireCache enabled
$LOAD_PATH.size => 26
        1.67 real         1.47 user         0.18 sys

== Fast boot:
RequireCache enabled
$LOAD_PATH.size => 26
        1.67 real         1.47 user         0.19 sys

But for a sligthly bigger app with 136 gems, the app boot 20% faster.
$ bundle install
Bundle complete! 65 Gemfile dependencies, 136 gems now installed.

$ ./script/benchmark
== Booting without cache:
RequireCache disabled
$LOAD_PATH.size => 184
        3.29 real         2.59 user         0.69 sys

== Warming cache (unless already present):
RequireCache enabled
$LOAD_PATH.size => 39
        2.74 real         2.44 user         0.29 sys

== Fast boot:
RequireCache enabled
$LOAD_PATH.size => 39
        2.62 real         2.33 user         0.27 sys

I tested it with a real world app with 324 gems and lots of initializers, the saving is around 25%.
RequireCache disabled
$LOAD_PATH.size => 439
     14.14 real        10.85 user         3.19 sys

RequireCache enabled
$LOAD_PATH.size => 95
     10.79 real         9.52 user         1.18 sys

Why not just make this change in RubyGems?

Why not just make this change in RubyGems?

To be honest I'm not quite sure what rubygems does exactly these days.
But what I wanted to do was to reduce the size of the $LOAD_PATH, and it's bundler that is responsible to populate it, so it seemed logical to me to start here. But I could totally be missing something.

I don't think we can ever not populate the load path, and rubygems already monkey patches Kernel#require to deal with gems, so ¯_(ツ)_/¯

I don't think we can ever not populate the load path

Why is that? If you look at the demo repository I linked in the description, You'll see that even Rails app can boot without populating the load path. Appart from native extensions that bypass the API, it works just fine.

rubygems already monkey patches Kernel#require to deal with gems, so ¯_(ツ)_/¯

Yes but AFAIK rubygems have little to no knowledge about which gems are part of the bundle.

No, the list of activated specs is known to rubygems. And I think it breaks the contract of require if it doesnt search the LOADPATH

This is pretty interesting to me! It's clearly not compatible with the RubyGems way of doing things, but neither is Bundler's standalone mode. As an incompatible opt-in performance improvement, I think it might be even better than standalone mode is.
If we had the names of native extensions (say, as gem metadata perhaps?) do you think we could require those directly without needing to put them on the load path?
On Sun, Jul 26, 2015 at 8:45 PM, Jean Boussier<EMAIL_ADDRESS>wrote:

I don't think we can ever not populate the load path
Why is that? If you look at the demo repository I linked in the description, You'll see that even Rails app can boot without populating the load path. Appart from native extensions that bypass the API, it works just fine.
rubygems already monkey patches Kernel#require to deal with gems, so ¯_(ツ)_/¯
Yes but AFAIK rubygems have little to no knowledge about which gems are part of the bundle.

Reply to this email directly or view it on GitHub:
https://github.com/bundler/bundler/pull/3882#issuecomment-125076070

(It's also incompatible with a user manually manipulating the load path, unshifting something that conflicts with a gem in their bundle)

If we had the names of native extensions (say, as gem metadata perhaps?) do you think we could require those directly without needing to put them on the load path?

Unfortunately no. Maybe I wasn't clear. The problem with some native extensions is that they call rb_require directly, so the LOAD_PATH is searched in C directly, without delegating to Kernel#require.
See https://github.com/ohler55/oj/blob/0eea2cb689f0fe972595e2302e0f26474e49fa7e/ext/oj/oj.c#L2075-L2079 for instance.
The solution would be to call Kernel#require from C instead of rb_require.
autoload have the same issue in > 2.3: https://bugs.ruby-lang.org/issues/11140
It's just a matter of using rb_funcall(rb_mKernel, rb_intern("require"), 1, rb_str_new2("foo")); instead of rb_require("foo").
On a longer term, I think it would make sense for MRI to expose another API than $LOAD_PATH for library inclusion.

(It's also incompatible with a user manually manipulating the load path, unshifting something that conflicts with a gem in their bundle)

How so? If you look here: https://github.com/bundler/bundler/pull/3882/files#diff-a9429187b3bcb02b801b757f0a8fef61R37
You'll see that the remaining $LOAD_PATH will be looked up first, and then on miss only, the gems in the bundler will be looked up.
I didn't notice any compatibility breakage beside the native rb_require issue. And I tested with a fairly complex Rails app of 300+ gems. And we're running an alternative version of this patch since a couple months in production successfully.

An alternative that I've tested in an app with startup times >30 seconds (slow disks, lots of gems) is to wrap the calls to the underlying require with resetting $LOAD_PATH to what it was before + just the paths to the gems that the gem you're currently loading wrong requires. That handles the aforementioned C-extensions etc. just fine, though there are still potential issues e.g. with gems that expect to be in the load path later during runtime.
I'm looking forward to testing this code - bundlers $LOAD_PATH mangling leads to some really pathological cases in larger apps (the app mentioned earlier had ca. 100k failed stat calls while trying to look up files before I put in place a hacky solution based on wrapping as above, and less than 30k afterwards)

Closing in favor of https://github.com/byroot/bootscale
Ref: https://github.com/bundler/bundler/pull/3958#issuecomment-133896913


[index] For extensions, relate the symbol reference that gets extended and base references with the extension symbol.

They were getting related with the original extended symbol, which was incorrect.

@swift-ci smoke test and merge


Fix PVQD docs and enable time evolvers import from module

Summary
Fix two small bugs:

fix the example in the PVQD, which didn't run
enable imports of the time evolver classes from qiskit.algorithms.time_evolvers -- like in the other algorithm modules
list TrotterQRTE in the algorithm docs

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

10 of 10 (100.0%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.007%) to 84.549%

Totals

Change from base Build<PHONE_NUMBER>:
-0.007%

Covered Lines:
63172

Relevant Lines:
74716

💛  - Coveralls


[feature: EASI-3923] Conditional relation translation updates

EASI-3923

Changes and Description
This is a high level review of the previous PRs for readonly conditional relationship updates
https://github.com/CMSgov/mint-app/pull/956
https://github.com/CMSgov/mint-app/pull/959
https://github.com/CMSgov/mint-app/pull/961
https://github.com/CMSgov/mint-app/pull/968
https://github.com/CMSgov/mint-app/pull/971

How to test this change
Verify Figma matches, notes from previous PRs considered
Figma
PR Author Review Checklist

[ ] Met the ticket's acceptance criteria, or will meet them in a subsequent PR.
[ ] Added or updated tests for backend resolvers or other functions as needed.
[ ] Added or updated client tests for new components, parent components, functions, or e2e tests as necessary.
[ ] Updated the Postman Collection if necessary.

PR Reviewer Guidelines

It's best to pull the branch locally and test it, rather than just looking at the code online!
Check that all code is adequately covered by tests - if it isn't feel free to suggest the addition of tests.
Always make comments, even if it's minor, or if you don't understand why something was done.

This looks great! Thanks Patrick!
I tested this functionally by seeding the database, and checking the empty state for these conditional questions. I also spot checked that they are not exported in the CSV if considered not needed. The PDF export shows them expanded as anticipated.
🚀

Thanks so much Steven!


Feature/stop file download

Add ability to stop file download.

@MiincGu Thanks for doing this. I'll give this some testing later today and if all goes well I will merge this in. :-)

@MiincGu Again thanks for you contribution. There is a slight issue in that your implementation assumes that only one download can be happening at any one time. If two download jobs are running concurrently then your stopDownload will only abort the last one. It has however made me realise that the exposed API could be better.
I'm going to make another callback that will return the job ID of the download as soon as the download begins, along with other useful infos like response headers. The caller will be able to use the job ID to tell the module which download to abort.

@MiincGu Have refactored and manually merged in some of your code. Need to test stopDownload in new implementation but I've run out of time today. This pull request is now redundant.

Thanks for your job.


Picture don't change to actual after hibernation.

For example, I'll hibernate my computer at night. After turning on the picture will not change.
OS Ubuntu 14.04 with Unity

Does Unity support GNOME's dynamic wallpapers?

I'm not shure, but i think yes.

I'd need a more assertive answer. Could you please ask on a relevant channel (Ubuntu IRC, forum or askubuntu) whether GNOME's dynamic wallpapers are supported by Unity, especially the version you are running on Ubuntu 14.04. Without this piece of information, I cannot address your issue.

I am closing this issue due to lack of activity from the OP. Besides, the new Ubuntu LTS now ships with GNOME by default, so issues with Unity would be less of a priority.