[Request] ZombiU graphics pack

ZombiU works perfect in the latest release of cemu (1.14.0) so, I think it´s time to add a graphics pack for this awesome game, at least for the resolution.

I have a basic pack up and running...
But It'll need some more love  before committing.  Chromatic aberration and noise fixes among other things.

Initial commit done.
Known issues:

Texture jitter when rotating view, Cemu issue
Shadows wonkey, Cemu issue
5120x2880 some lights too bright, graphic pack issue.. Need Nsight to check-> later

Anything else, report back and we'll see what we can do.

Fixed colour banding/truncation

A new bug was introduced in 1.14.0 Graphic Packs: V210, in this case there´s a lot of flickering, you can see by moving quickly the camera from side to side like saying "no"
Another bug encountered is that the lights came across the walls, "all emergency lights, red and white" but this happens in the previous graphic pack too.

This kind of flickering, like the light is lagging behind?
I get that with graphics pack disabled.

This one it´s only 30fps recorded with my mobile phone (Ignore the all-blue color, I don´t know why the record looks all blue) but you can see a bit better the clipping I said:
Record.zip

Like this poster? Smearing  in the direction you are moving?   Also happens on the floor when looking up/down.

It happens for me without the graphics pack.. If its some sort of texture corruption, it does make sense that graphics pack can make more common.
The biggest difference between the two versions  are format changes
[TextureRedefine]
width = 1280
height = 720
formats = 0x019,0x01a
overwriteFormat = 0x01f

[TextureRedefine]
width = 320
height = 192
formats = 0x01a,0x019
overwriteFormat = 0x01f

[TextureRedefine]
width = 320
height = 180
formats = 0x01a,0x019
overwriteFormat = 0x01f

Add # and see if un-commenting them helps.
#[TextureRedefine]
#width = 1280
#height = 720
#formats = 0x019,0x01a
#overwriteFormat = 0x01f

Ok, I tested with your latest release "V.214" I don´t know what you changed but now the problem is solved.

:/   I added more stuff.. so it should have been even worse.
I don't doubt that you, its just that this sounds more like luck if it breaks or works, not because of the graphics pack.  For example when I switch between full-screen and windowed it tends to be good for a while.
Anyway if you want to check out different versions and compare, all old builds are here.
https://github.com/slashiee/cemu_graphic_packs/releases

Edit: Deleted my last comment, because I was testing with the resolution pack disabled, so forget it, It solves nothing, sorry :S

Ok, after some more and more testing, I found the problem.
The "lights came across the walls" is a Cemu´s problem, indeed, it happens too with graphic pack disabled.
All the versions of the graphic pack "v.208,210, 214" has the flickering problem for me, I thought that the first pack is Ok, because, sometimes, when I delete the folder "ZombieU" containing the graphic pack and copy the new one, cemu disables it, (I think this doesn´t happen with other graphic packs, since the lesslentdirt doesn´t have this problem) and I was running the game with the graphics pack disabled.
So, in short:
Light across the walls - Cemu problem
All resolution graphic packs have the flickering problem, this doesn´t happen with the resolution graphic pack disabled (at least for me) maybe (If this happens for you even withouth graphic pack) you have the vsync disabled? I have enabled for all apps in my Nvidia control panel. But this doesn´t explains why the problem happens with the resolution pack enabled.

Tested 5 or 6 times and now without the graphic pack has the flickering too, I don´t know why this happens now since I tested a lot of times before and worked Ok with the graphic pack disabled... this game are trolling me... ¬¬ sorry, closing the issue, let´s hope that the Cemu team solves the remaining issues, thanks a lot for your help and my apologies for wasting your time.


Update and simplify botocore loaders to new dir layout

This reworks and greatly simplifies the loaders used in botocore.
This is part paying off technical debt as well as standardizing
on a shared common format.
In terms of the new layout, the loaders docstring discusses how it
looks like, but we now support the directory layout used by the
other AWS SDKs.
In terms of the loaders themselves:

Remove any fuzzy API version matching, you either can specify an
exact API version or you can get the latest API version.
Move up the service type names ('service-2', 'paginators-1', etc)
out of the loader.  The session/client objects should know about
those details, but not the loader.
Remove all file extensions from the loader class.  This actually
allows pluggable loader types besides JSON.  This wasn't
actually possible previously.

cc @kyleknap

Coverage decreased (-0.62%) to 93.84% when pulling 68be91d8480a1d83fe0a92db7692a86ff6ecd951 on jamesls:simple-loaders into 60e72b22bdebfa83e9b964aca232c7cad572212e on boto:develop.

There's actually a few changes I'm going to need to make based on updating boto3, specifically with list_available_services and determine_latest_version.
The problem is that both of these assume that the directory structure is sufficient to extract meaningful data about what is or isn't available (in fact, I even comment on this in this PR: https://github.com/boto/botocore/pull/527/files#diff-f8c1b99f0b4538cf77c2052b498c9630R219).
We actually need to be able to specify the type name (services-2, paginators-1, resources-1) when asking about the latest available and the list of all services.  For example, the latest available service for services-2 may not necessarily mean that there's a resources-1 model for that same API version.  Similarly listing all the available resources may differ we only care about resources (i.e boto3).
A concrete example of breakage is doing loader.load_service_model('ec2', 'resources-1') in boto3.  It will try to find the latest API version for EC2 and assuming it can load a resource for it, which it currently cannot so it will raise an exception.
To fix this I'll be adding these changes:

Modify determine_latest_version and list_available_services to require a type_name param, just like load_service_model.
Update the file loader interface (currently only JSONFileLoader is implemented) to add an exists() method that will return True/False if the resource exists.

@kyleknap I've updated with the necessary changes for boto3 as well as the latest model updates from develop.  Should be ready now for another look.  Thanks.

Coverage decreased (-0.06%) to 94.39% when pulling 12cc84bcc717b0d4cfd1302b99d8975526e30ccb on jamesls:simple-loaders into ad1d6e298fd46c9b5994d1a073d40bb1ca838726 on boto:develop.

https://github.com/boto/boto3/pull/104 is an example of how this new loader API can be used.  Now boto3 simply needs to add its internal directory to the search path and then specify the type name when dealing with services that must contain a resource definition.

Coverage decreased (-1.06%) to 93.4% when pulling 56d4f48b718489cbea5ba89abd680067770bebe0 on jamesls:simple-loaders into ad1d6e298fd46c9b5994d1a073d40bb1ca838726 on boto:develop.

It looks good. Looks like you updated the code after my pep8 comment through the pr-check script. Had a couple of comments about tests and docstrings, but nothing too significant :ship:
Looks like you also need to rebase on develop and pull in the latest model changes, which should only be dynamodb (not sure if you rebased after my ec2 pr).

The PR should have been rebased on develop as of the latest release a few hours ago.  I'll double check this is the case.

Hmm the merge button is grey right now. Usually means that I need to rebase.

Probably because I merged in the _retry bugfix PR.

@kyleknap pushed a commit to extract out all the test boilerplate.  I think the tests are much easier to read now.

Also rebased against develop.  Looks like it's because of the _retry PR I merged, which makes sense.  Any changes to anything in botocore/data/ in develop will require a rebase to merge cleanly:
$ git rebase develop
First, rewinding head to replay your work on top of it...
Applying: Update and simplify botocore loaders to new dir layout
Applying: Move services to standard directory structure
Using index info to reconstruct a base tree...
M	botocore/data/aws/_retry.json
Falling back to patching base and 3-way merge...
Applying: Fix pr-check issues
Applying: Fix docstring
Applying: Move out boiler plate for dir patching to helper method

Recent commits look good. Those tests look much cleaner. :ship: again.

Coverage increased (+0.06%) to 94.52% when pulling f5d2c33311fd99c613d2ee30c001501000c88ae1 on jamesls:simple-loaders into 5eb99b9e09702057ba5772d86af2d7751d75a459 on boto:develop.


strobealign-aemb module for metagenomic binning

Hi,
This is the aemb (abundance estimation for metagenomic binning) module,  the usage is :
strobealign ref.fa read1.fq read2.fq --aemb > abun.txt
In my benchmarking, aemb can output similar results, but decrease more than 90% running time.
Sincerely
Shaojun

Thanks Shaojun. I think Marcel is a bit busy right now but I am sure he will have a look when there is sufficient time.

This looks good now! I think this deserves a slightly longer section in the documentation, but I’ll do that after merging.


Log4J CVE Mitigation for Ontology-Neo4j

Per suggestion from https://community.neo4j.com/t/log4j-cve-mitigation-for-neo4j/48856
dbms.jvm.additional=-Dlog4j2.formatMsgNoLookups=true
dbms.jvm.additional=-Dlog4j2.disable.jmx=true
I've done this to the neo4k-docker containers, will need to do the same to ontology-neo4j.

Addressed via PR #127 and tested on DEV, will rebuild the neo4j image on PROD.


Update subgraph entities

What does this PR do and why?

Adds previously unsupported subgraph entities DeployedERC20Event and PrintPremineEvent, and adds some missing properties to existing entities
Makes type definitions for entities more uniform by removing conditional? properties and using Partial<>s

Acceptance checklist

[x] I have evaluated the Approval Guidelines for this PR.
[x] I have tested this PR in all supported browsers.

Fixes #470

okay, leaving the other subgraph entity typing alone for now.

This looks pretty good. I know we can't solve the typing issue which is why you're leaning on Partial.
Out of scope here, but long-term I wonder if we can go with something perhaps radical... Like using a GraphQL schema generator to create our interfaces with the subgraph. Completely dev-only TypeScript definitions (I suppose we could use a build process to validate graph usage, but don't commit the .d.ts). I really don't like code generation, but it might be better than misleading types. They have a live demo view

Cool idea, and I think @aeolianeth was talking about something similar as well?
Right now the app uses some runtime-computed graph queries for things like projects search and the volume/balance graph. Would this work with those?

Nice improvement @peripheralist , thank you!
We could look at type generation from our graphql schema. I will say that in other graphQL codebases I've worked in, queries are always defined in .graphql files which is much more flexible and maintainable. The schema would be generated from our subgraph definition (maybe it already is, haven't checked), and this schema can be used by a linter to validate query properties.
Frankly I don't think we have the capacity for a full overhaul of our graphql strategy right now, but it's certainly something I'm keen on improving eventually.
@peripheralist happy to approve, just a couple of conflicts to resolve.


Add hooks to allow the use of different test frameworks

Currently the library is fairly strongly tied to RSpec. In order to support
different ruby testing frameworks it makes sense to re-use the logic in this
library around reporting and sockets, rather than creating separate gems for
each testing framework.
Adding a hook system will allow different code to setup each test framework
that we want the gem to work with, I'll be working on minitest support after
these changes are merged.
The structure of the hooks is lifted from the VCR gem which already uses
this mechanism. In this change I've updated the library to only require
RSpec as a development dependency as with each added hook the
dependencies for the gem will grow and there's no use in having projects
rely on multiple test frameworks.
If we want to go down this path it would make sense to rename the library to
buildkite-analytics (which seems available on rubygems) as it'll no longer be
RSpec specific and create a plan to migrate existing users of the
rspec-buildkite-analytics library over to the new one.

Thanks @mariovisic!!

Adding a hook system will allow different code to setup each test framework
that we want the gem to work with, I'll be working on minitest support after
these changes are merged.

Awesome, this is the direction I was thinking of heading as well. Awesome to see it coming together 🙌

I've updated the library to only require
RSpec as a development dependency as with each added hook the
dependencies for the gem will grow and there's no use in having projects
rely on multiple test frameworks.

Nice!

If we want to go down this path it would make sense to rename the library to
buildkite-analytics (which seems available on rubygems) as it'll no longer be
RSpec specific and create a plan to migrate existing users of the
rspec-buildkite-analytics library over to the new one.

There was some talk about merging this with the buildkite gem as well. I'll raise it with the team and get back to you with our decision. Either way, keen to follow this approach.
We're not currently building PRs from forks so I'll need to check the config and update it so we can get a build for this PR. In the meantime I'll pull this down and give it a test locally.
Thanks again!


Insecure TLS/SSL trust manager

Description
We updating to AGP 4.1 and it reports SUBJ issue for the OkHttpFactory inner class in the library:
com/twilio/messaging/transport/OkHttpFactory$1.class: checkClientTrusted is empty, which could cause insecure network traffic due to trusting arbitrary TLS/SSL certificates presented by peers

Steps to Reproduce

Add Twilio chat SDK to project with AGP 4.1
Run lint

Expected Behavior
No lint reports around Twilio library
Actual Behavior
Reported above error
Reproduces how Often
Always
Chat Android SDK
Which SDK version did you use? 6.1.0

This is red-herring warning, code is valid.

@berkus Do you mean instrumental tests? Do you have documentation how to use it in test?

@emartynov you don't, this is for sdk tests only.

@berkus Then why to ship production library with code that is used in the internal tests?

@berkus Should i pass it to your support?

@emartynov pass what?

We are aware of your concern with ssl testing, we will handle it. No need to worry.

@berkus Does it mean next update lint will not report me about the class that is used in the internal tests?

No, it does not.

@berkus I'm sorry for the harsh comment. I was just triggered by "you don't need to worry" phrase. I should say instead:
Can I hope that in the nearest releases you will fix it and I can remove lint rule ignorance? If yes, do you have ETA for it?

I don't have an ETA, but we have this in our short-term plans. As soon as one of our developers is available to review your dependencies update PR he will most probably also look at the warnings this update produces and hopefully fix them, too.


How to add plots without resetting axis limits?

Bill asked via email

If I have a chart displayed and have used the mouse to pan and zoom, is there a way I can save the pan and zoom values so the newly rendered plots appear with the same settings?

There are times when I would like to add another plot to the data set without resetting the zoom and pan parameters.

Hi Bill,
Questions like this are always welcome! They help me identify which parts of ScottPlot are intuitive (and which aren't) and can help me adjust the API and documentation as needed to improve discoverability in the future.
It sounds like your goal is to copy the axis limits from one plot to another, or save axis limits so you can recall them later. When adding new plots you've found that the axes get reset (to automatically fit the new data), but it sounds like you want to override this behavior. You can retrieve axis limits using a line something like:
var originalLimits = plt.Axis();

... then add your new plot, then recall those axis limits like:
plt.Axis(originalLimits);

... or specify just X or Y limits using one of the overloads of the Axis() method.
Does this help answer your question?
Scott

I tried your suggestion, but the chart seemed to return to the initial zoom and pan. Here's the code in case you can spot something else I'm doing wrong. Thanks again for your assistance!

private void plotButton_Click(object sender, EventArgs e) {

	// Pressed button to initiate update with new or updated dataset.

	var originalLimits = plotPanel.plt.Axis();

	// get name of axis to use for X Axis with time values
	string xAxis = this.xAxisComboBox.SelectedItem.ToString();
	if (xAxis != "") {
		if (this.selectedDataListBox.Items.Count > 0) {

			// Clear out existing plot values
			this.plotPanel.plt.Clear();
			int colorIndex = 0;
			var xData = from x in data[xAxis] select (x - data[xAxis][0])/TimeSpan.TicksPerSecond;

			// Plot each parameter the user has dropped into the listbox
			foreach (var item in this.selectedDataListBox.Items) {
				string yAxis = item.ToString();
				this.plotPanel.plt.PlotScatter(
					xData.ToArray(), data[yAxis].ToArray(),
					color: colors[colorIndex],
					label: yAxis,
					markerSize: 0
					);
				colorIndex = (colorIndex + 1) % colors.Count;
			}

			var plt = plotPanel.plt;
			plt.Legend(fixedLineWidth: false);
			plt.Title(this.fileName);
			this.plotPanel.Render();
			if ( !this.firstPlot) {
				// add logic to restore pan and zoom
				this.plotPanel.plt.Axis(originalLimits);
			} else {
				this.firstPlot = false;
			}
		}
	}
}

Hi Bill, I think the problem is caused at the very end where you call the Render() method before updating the axis limits.
If you move that render call so it happens after you set the axis limits I suspect it will work as expected.
// restore pan and zoom
if ( !this.firstPlot) {
	this.plotPanel.plt.Axis(originalLimits);
} else {
	this.firstPlot = false;
}

// then render an updated plot
this.plotPanel.Render();

Thanks Scott. You are right, the location of render was the problem. Working just like I want now.


Fixes to body element animation

I am slightly inclined into making the new $body service an undocumented service. That a side, LGTM

I also think $body should be $$body.

@petebacondarwin please review so we can merge this in tomorrow.

It looks fine to me. The only comment I have is that since $$body is only used once in the core ng module, we should move the definition of $$body over to the ngAnimate module so we don't need to make angular.js file any bigger.

Merged in as https://github.com/angular/angular.js/commit/44ce9c8288fc6c12043567027271a09bd0594d74. Excellent work @OlenDavis.


GCD IN JAVA AND PRIME FACTORIZATION

Assigned Issue Number ?
#250  #263
Language Opted ?
Java, CPP
Number of files added or updated ?
2
Name of these files ?
Maths_And_Stats/Algebra/GCD/gcd.java
Maths_And_Stats/Algebra/Prime_Factorization/prime.cpp
Checklist

I've read the contribution guidelines.
I've referred the correct issue number.
I've fill up this entire template correctly.

Hi @AnshMishra2001, Please remove the unnecessary files


Framegrabs have Venetian blind effect

Framegrabs have Venetian blind effect when annotating from Pro-res files
no fine control makes it difficult to select a good frame for a frame grab

Looks like low-light conditions cause #1 above.

Hoping #1 won't happen after we go to progressive (1080p). In the meantime, people should be informed that applying a de-interlace filter in Photoshop is advised.

Using finer control in shartopoda as a work around to #2; makes for slow annotation


💄(frontend) little relifts and fixes of some dashboard ui

Purpose
Little relifts and fixes of some dashboard ui

Before
After

de4e1-8759-4b98-a65b-bccf750cb5c5">

Proposal

[x] Fix Syllabus link rendered in TeacherDashboardCourseSidebar
Rework sidebar padding.
Remove overflow on dashboard layout which causes layout issue
Remove title as link in course and organization course views.
Fix some translations on CourseRunList
Fix Dashboard height issue

Il love these changes 😍 I saw one more small mis-alignment on the screenshot 👀

Spoiler : I relift the contract view in my PR to add organization sign ^^


gbkToUtf16Map and utf16ToGBKMap should be constants

Using gbkToUtf16Map and utf16ToGBKMap as constant (by using const modifier) could save around 1MB on release output when not used.

Thanks you for your suggestion .
see release 2.0.1


Update README

Motivation
I am updating the README to reflect the correct init.
Modifications
Correct sample code to reflect working code.
Result
Copy-pasting sample code now compiles.
Test Plan
N/A

@swift-server-bot test this please


Self documenting f-strings

Fixes #3796

There's some examples in "test/run/test_fstring.pyx" that are currently commented out
https://github.com/cython/cython/blob/cedbd5840fde2c63549b64c35cd05ea5fb9fc524/tests/run/test_fstring.pyx#L1125-L1229
They're stolen from the CPython test-suite I believe. Uncommenting them should be fine for this PR.

There's some examples in "test/run/test_fstring.pyx" that are currently commented out
https://github.com/cython/cython/blob/cedbd5840fde2c63549b64c35cd05ea5fb9fc524/tests/run/test_fstring.pyx#L1125-L1229
They're stolen from the CPython test-suite I believe. Uncommenting them should be fine for this PR.

Oh, so you store them on .pyx to compile them, should have thought about that one (got overwhelmed by so many tests and didnt know where to start :sweat_smile:). Thanks for the heads up

@da-woods Fixed. Btw, you guys dont seem to have auto-cancellation of builds on pr's, which might be worth turning on specially due to the pipelines being limited to 1 concurrently and taking really long to run.

python3 runtests.py test_fstrings should at least let you check that that specific test runs on your PC.

It looks reasonable to me (although my knowledge of the parser is a little vague)

It looks reasonable to me (although my knowledge of the parser is a little vague so wouldn't like to comment too much on that bit)

Ok, thanks for having a look :+1:

Little bump :) @scoder

@scoder both fixed

Looks good now. We need a work-around for Py2.7, though:
ERROR: test_debug_conversion (test_fstring.TestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests/run/test_fstring.pyx", line 1131, in test_fstring.TestCase.test_debug_conversion (test_fstring.c:44342)
    self.assertEqual(f'{x=!a}', 'x=' + ascii(x))
NameError: name 'ascii' is not defined

Looks good now. We need a work-around for Py2.7, though:
ERROR: test_debug_conversion (test_fstring.TestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests/run/test_fstring.pyx", line 1131, in test_fstring.TestCase.test_debug_conversion (test_fstring.c:44342)
    self.assertEqual(f'{x=!a}', 'x=' + ascii(x))
NameError: name 'ascii' is not defined

I havent been able to replicate ascii on python2 or find any backport. The docs state that repr produces a similar result in python2, but just to stay safe and avoid edge cases, they will only run on python3.
Source: https://docs.python.org/3/library/functions.html#ascii

I havent been able to replicate ascii on python2 or find any backport. The docs state that repr produces a similar result in python2, but just to stay safe and avoid edge cases, they will only run on python3.

We actually map !a to repr() in Cython for Python 2.7. Just define ascii = repr if IS_Py2 at the top of the file.

Ah, ok, will do 👍

@scoder Small bump on this one, everything should be working

Let's get this feature merged. Thanks for working it up!


As a content editor, I want the card image URLs in footnotes updated to resolve to Figgy after content is migrated so that I can access images in their new location.

Note: some of the accounts that were split out have correct file paths in the location part of the footnote but are associated with the wrong card bibliography record - @elspethgreen and I have determined this is not worth editing manually, since it will be tedious and can probably done programmatically. Probably makes sense to clean that up when we do the figgy url migration.
I'll increase estimate from 2 to 3 to account for the additional work.

Increasing to 5pt to account for the additional work resolving repeated paths in the spreadsheet and the cleanup needed in the footnote locations.

Here's the script output from running in test:
$ python manage.py import_figgy_cards mep/accounts/fixtures/pudl-to-figgy-mapping.csv
Found 624 bibliographies with pudl image paths
Could not identify card for c/catel/00000001,c/catel/00000002
Could not identify card for e/edel/00000001,e/edel/00000002
Migration complete.
Found 0 bibliographies and 137 footnotes with pudl paths

The "could not identify" errors are expected - these are cases where there are two objects in Figgy but we consolidated the bibliography record in our database (Catel/Villars; Mr and Mrs Edel).

YES, the admin dashboard includes a section with IIIF Manifests and Canvases under a "Digitized Content" heading
YES, bibliography section now has manifest and thumbnail image and there is a full bibl note in the bibl note section. Ex: Sylvia Beach, Akrata von Shrader Carroll Lending Library Card, Box 43, Sylvia Beach Papers, Department of Rare Books and Special Collections, Princeton University Library.
YES, in the footnotes section there are images associated with records. Ex: Raphael, Borrow for account #23 1936-04-24/??. The Figgy image location is now in the "location" box, without any PUDL. The only thing is: if I try to copy this into my address bar, it says "the page you're looking for doesn't exist." Is this OK? Is it because I'm not logged into Figgy?

I can't see any leftover pudl image paths in bibliography

@clmahoney great question, I should have probably noted that somewhere - the IIIF image IDs don't actually resolve in Figgy. I mentioned this to the team and asked if they could add something to resolve the image ID to an appropriate URL - I think they're considering it, but don't expect it to happen anytime soon. If you remove the end of the url and just leave the part ending with /manifest/ you will get the JSON representation of the IIIF manifest.

YES, I checked footnote on Prevost, Gerard, Mme. There's a log note! "Migrated from pudl to figgy." Checked footnote on Caresse Crosby, too, and there was the same log note.

YES, I checked Bibliography for Christine Poirson, and there's a log note that says "Migrated from pudl to figgy." Checked Bibl for CK Ogden, too, and same log note.

@clmahoney regarding this note:

It looks like only 2 events were "not supported": one is a google book link, one doesn't have any link (to pudl or otherwise): Lescure, Yvonne and Acheson, Sam, Mr.

I meant to have you search the footnotes directly, not the events (although this was a useful thing to check that I didn't think of!).
If you go to the main admin dashboard, and select Footnotes under the Footnotes section (next to the bibliography records), you can access the footnotes directly instead of as attached to the events. When I search on pudl I find 137 records, but they don't have full paths that I can update in my script. These will have to be fixed manually no matter what, so I wanted to make sure you look at them as part of checking this migration.

Lescure is apparently in the Paul Leon bibliography. To fix this manually, do I just copy the figgy link? I.e. https://figgy.princeton.edu/catalog/8d66f39f-2c38-452e-8c38-07f6d9013aa3

I don't understand this question enough to answer. Can discuss on Slack so you can share links and explain what you mean?
Your question raises a point that is worth noting: as part of the migration, I'm putting the IIIF image ids in the footnote locations in addition to associating the image. That's redundant, since we're already linking to the image in the database. It occurs to me now, there's no easy way for you or other project team members to find the image identifiers to do that. We could add logic to have the image identifier automatically added based on the associated image when the record is saved, but I didn't implement that yet because we said we weren't going to be doing new footnotes anytime soon. We didn't account for clean up work after this migration (didn't know about it yet).
I think we should do one of two things:

I revise my code to drop the image identifier in the footnote location, and rely only on associated image
Leave the code as is, and whoever does manual clean up on the 137 footnotes will associate image but not enter a location.

@clmahoney you removed the awaiting testing label, but didn't close or add any other labels. When you get a chance (probably after we discuss the above), please let us know where this stands in your estimation - do you have questions that still need to be answered, are there any problems I need to resolve before you can accept?

@rlskoeser Sorry! I should have added a question tag. You answered both of them.
re: Footnotes that are still in PUDL: I see them now! I wasn't sorting by location, which would have made it so much simpler for me to find, and which I finally did now. I see the 137 that you do. I will be able to fix them manually.

I will close this now!

@rlskoeser What date should I have this manually fixed by?


Any plans to support setting shadow color/offset on android?

Hey, nice plugin! The only thing i noticed there is no support for custom offsets and shadow colors on android, unfortunately. Maybe u can get some inspiration from freshly created Sharpnado.Shadows? I think this functionality will be very popular among us, xamarin developers. Also i have a question. As i've understood from the source code there will be no shadows under api level 21?

Hi there, yeah, for shadows Sharpnado is definitely the better go-to at this point in time. It uses a completely different technique of custom drawing them. I have no plans on implementing that amount of detail though. The approach in PancakeView uses the Elevation property, which isn't around before API 21, which is why that distinction is made.

Ok, thx for the answer!


Command filtering

Might help fix the issue with chat channels not being filtered.
Possible Unique Permission seperate from chat filtering.

Fixed as of 5dd505e066165718c589daa5886bcae6a8d4069f


Adding option to Dynamically updating the profile by adding a import data option

The user can import his profile details and the profile card will update as per it

@thestarsahil In the 'Our Contributors' page all the contributors are not from GSSOC, right ???


Assign map width as percentage in st_folium

Hi there, I am wondering is it possible to assign the map width as percentage in st_folium? If this option is not offered, why?
Not an expert in streamlit component yet. Could anybody explain the reason behind that? Thanks!

This is somewhat a streamlit problem and general responsive design in streamlit problem. You can track the issue [here].(https://github.com/streamlit/streamlit/issues/708)


Changes to allow OAuth integration with nDelius users

Initial implementation of nDelius user oAuth for review

Hi @awhodgson256, I feel, we should keep only minimal things to get the auth working. Any other things can be added later on. This will avoid any confusion and when we request a review from a lead dev, there won't be any unnecessary comments and our initial skeleton project structure would be in good shape.


chore(pr comments): reuse pr comments so we don't have dozens of identical links

What does this PR do?
chore(pr comments): reuse pr comments so we don't have dozens of identical links cluttering up PRs
Signed-off-by: rhdh-bot service account<EMAIL_ADDRESS>Screenshot/screencast of this PR
N/A
What issues does this PR fix or reference?
N/A (or see commit message above for issue number)
How to test this PR?
N/A
PR Checklist
As the author of this Pull Request I made sure that:

[x] The Eclipse Contributor Agreement is valid
[x] Code produced is complete
[x] Code builds without errors
[ ] Tests are covering the bugfix
[x] The repository devfile is up to date and works, if one exists
[x] Sections What issues does this PR fix or reference and How to test this PR completed
[x] Relevant user documentation updated
[x] Relevant contributing documentation updated
[x] CI/CD changes implemented, documented and communicated

Reviewers
Reviewers, please comment how you tested the PR when approving it.

@hmanwani-rh @Gerry-Forde @themr0c PTAL


how to make better resolution and save images?

I dont undestand how to make better resolution or save directly? why command show([pil_image for pil_image, score in sorted(zip(pil_images, scores), key=lambda x: -x[1])] , 6)  show pictrues so small ? and if i  use
top_images, clip_scores = cherry_pick_by_clip(pil_images, text, ruclip, ruclip_processor, device=device, count=1)
show(top_images, 3)
there will be full resolution? how to make all generated photos in full ress or how to save them directly to file?

for making super-resolution and saving images to directory you can use this code in version 0.0.1rc5:
sr_images = super_resolution(top_images, realesrgan)
show(sr_images, 3, save_dir='my_images')


Can't get any POST body in my remote host

ELK and sentinl version 5.4.2
My action config like this:
"actions": {
  "New webhook action aq9e6jb31lt": {
    "throttle_period": "0h0m1s",
    "webhook": {
      "method": "POST",
      "host": "hostname",
      "port": 8080,
      "proxy": false,
      "path": "/alert/sentinl_alert",
      "body": "{\"hello\": \"world\"}"
    }
  }
}

But I cant't get any request body in my remote host built by Django.
The interface(/alert/sentinl_alert) I built to print POST body.
request body:
[20/Jul/2017 02:19:15]"POST /alert/sentinl_alert HTTP/1.1" 500 73711

The two examples slightly discord, so I'm not sure what to suggest ( /alert/prometheus_alertvs /alert/sentinl_alert) Please capture the request being sent out for debugging, or check what's causing the 500 on the remote server specifically?

@lmangani  Thank you for your replay.
I'm sorry to write the wrong response info.
I have modified the issue yet.

Hi @RickyHuo as the 500 error comes back from your app it probably explains the issue best - based on that, we can "cure" the watcher config accordingly. Thanks!


Add Xbox controller holders on robot cart

Add 2 Xbox controller holders on the robot cart drive station. You should be able to find 3d printables online.

In Progress
Prototype V2 should be 3D printed by Monday.


Can't download modlist

Describe the bug
Its seem some file does not available.
Screenshots
https://i.imgur.com/39baXgb.png
Modlist version
0.3.3

Yeah I'm sorry


help request: Keep Admin API /apisix/ssl available for apisix-ingress-controller 1.5 compatibility

Description
apisix-ingress-controller 1.5 crashed without Admin API /apisix/ssl
Environment

APISIX version (run apisix version): 3.0
Operating system (run uname -a):
OpenResty / Nginx version (run openresty -V or nginx -V):
etcd version, if relevant (run curl http://<IP_ADDRESS>:9090/v1/server_info):
APISIX Dashboard version, if relevant:
Plugin runner version, for issues related to plugin runners:
LuaRocks version, for installation issues (run luarocks --version):

@tao12345666333
Which version of apisix-ingress-controller will support APISIX 3.0?

maybe v1.7
v1.5 can work with APISIX v2.15

we can use #1339 for track


Add 29 icons, Link 2

Description

Fixes #(issue)

Type of change

:x: Bug fix (non-breaking change which fixes an issue)
:white_check_mark:  Icon addition (non-breaking change that adds/modifies Lawnicons's icons)
:x: General change (non-breaking change that doesn't fit the above categories, such as copyediting)

Icons addition information

Icons added

aodNotify (com.jamworks.aod.notificationlightled/com.jamworks.aod.notificationlightled.SettingsHome)
Audio Recorder (com.dimowner.audiorecorder/com.dimowner.audiorecorder.MainActivity)
Bunpo (com.bunpoapp/com.bunpoapp.ui.splash.SplashActivity)
Casio (jp.co.casio.CasioMusicCity/jp.co.casio.cordanaplay.lib.ChordanaPlayActivity)
FindMyDevice (de.nulide.findmydevice/de.nulide.findmydevice.ui.MainActivity)
GameSpace (io.chaldeaprjkt.gamespace/io.chaldeaprjkt.gamespace.settings.SettingsActivity)
Ideme vlakom (sk.zssk.mobapp.android/sk.zssk.mobapp.android.ui.SplashActivity)
KeyMapper (io.github.sds100.keymapper/io.github.sds100.keymapper.SplashActivity)
Knizka (pk.tappdesign.knizka/pk.tappdesign.knizka.MainActivity)
Liturgicke citania (sk.bouli.lc/sk.bouli.lc.MainActivity)
ManMan (com.adonai.manman/com.adonai.manman.MainPagerActivity)
Mapy.cz (cz.seznam.mapy/cz.seznam.mapy.MapActivity)
MHD Kosice (sk.mhdapp.ke/sk.mhdapp.MainActivity)
MHD Presov (com.nolimit.sk.mhdpresov/sk.mhdapp.MainActivity)
Mi Buds M8 (bz.zaa.mibudsm8/bz.zaa.mibudsm8.ui.activities.MiuiHeadsetActivity)
Moja 4ka (sk.stvorka.moja4ka/sk.stvorka.moja4ka.MainActivity)
MRepo (com.sanmer.mrepo/com.sanmer.mrepo.ui.activity.main.MainActivity)
MTG Familiar (com.gelakinetic.mtgfam/com.gelakinetic.mtgfam.FamiliarActivity)
OBS Blade (com.kounex.obsBlade/com.kounex.obsBlade.MainActivity)
OCR (io.github.subhamtyagi.ocr/io.github.subhamtyagi.ocr.MainActivity)
Packeta (cz.zasilkovna.app/cz.zasilkovna.app.dashboard.view.MainActivity)
Sharik (dev.marchello.sharik/dev.marchello.sharik.MainActivity)
SpyDroid (net.majorkernelpanic.spydroid/net.majorkernelpanic.spydroid.ui.SpydroidActivity)
Sygic (com.sygic.aura/com.sygic.aura.activity.NaviNativeActivity)
SysInfo (com.kl3jvi.sysinfo/com.example.sysinfo.activities.SplashScreen)
Task (info.tangential.task/info.tangential.task.MainActivity)
TetherFi (com.pyamsoft.tetherfi/com.pyamsoft.tetherfi.main.MainActivity)
Tower Collector (info.zamojski.soft.towercollector/info.zamojski.soft.towercollector.SplashActivity)
VsZP (sk.vszp.vszp/com.asseco.ce.vszp.patient.presentation.ui.EntryActivity)
XiaoFlasher (eScooter.m365Info/eScooter.m365Info.MainActivity)

Icons linked
These all +
*QR & Barcode Scanner (linked com.example.barcodescanner/com.example.barcodescanner.feature.tabs.BottomTabsActivity to @drawable/qr_reader)
*Saikou (linked  ani.saikou/ani.saikou.MainActivity to @drawable/saikou)

pls tell me how to do this PRs automated, without typing it all. Some recommendation. I don't get which one are simple enough to use 14px instead of 12px. Some will need rescaling probably.

pls tell me how to do this PRs automated

You can speed up some parts of the process via icontool.py.

I don't get which one are simple enough to use 14px instead of 12px. Some will need rescaling probably.

12px is basis. You can check the guidelines to make sure that your submissions are correct. A lot of them don't fit.

12px is basis. You can check the guidelines to make sure that your submissions are correct. A lot of them don't fit.

Yeah I don't get like, if letters can be picked from any font to fit icon or reworked. Also there is said icons shouldn't be filled, but found some like microsoft_admin_foreground not following rule. I was learning how to use inkscape. I think I have all propotions of lines (apart from 160, 144 sizes) good. Template would be appreciated.

You can speed up some parts of the process via icontool.py.

Yeah I know I thought if it has some flag to output changed only/new files. Instead of copy/paste memory.

@Darukutsu I don't think there's a template for Inscape, only the guidelines in Figma. You probably could create it by yourself. The core rules is simple: an icon viewbox is 192×192px, the svg fit the 160×160px content area, all shapes are rounded and the base line thickness is 12px.
There are 2300+ icons, so some of them didn't fit the guidelines, but most of them are correct. Any contributor can fix wrong ones.
I'm not entirely sure what you want to automate. If it can't be done through tables or tools that are out there, you can't do it without development.

I find that some icons didn't have appropriate stroke width. I messed my template. I refit some of square icons to 144. Please tell which icons will need what to change.

I only checked for size compliance with the guidelines. The result is 4 out of 29.

Resized all to fit 160x160. I didn't change com.dimowner.audiorecorder pk.tappdesign.knizka & sk.zssk.mobapp.android because I think they wouldn't fit original. Also added 7 new icons and 1 link. Therefore I edited first message.

Well I messed up something, while trying to figure out how github ui works :smile: . How to link pull request to closed one?  Sorry for trouble.

ln meantime while I will search where is problem with not saving opacity properly I've added few more icons + updated original comment.


ycsb.sh and ycsb.bat don't work from source checkout

The core dependencies aren't added to the classpath when bindings are used.

See comments in #873

Same issue reported under #865


[MKL-DNN] Design document on acquire API

This PR is providing document on design and usage (for developers of paddle mkl-dnn kernels) of Acquire API.
Rendered version:
https://github.com/jczaja/FluidDoc/blob/prv-acquire/doc/fluid/design/mkldnn/acquire_api/acquire_api.md
@grygielski, @Sand3r-, @bingyanghuang, @luotao1  Please review

@luotao1 Could you please review this PR?

@bingyanghuang Thanks for reviewing my changes. I have followed your suggestions.

@jczaja LGTM. @luotao1 Please start your review.


suggestion

just a suggestion: any hope to add these features? cus i couldn't find elsewhere:
login WITH bazaar
check up-to-date status

Thanks for your suggestions
I think check up-to-date status can be added easily, please feel free to send PR for this.
but login WITH bazaar should be a separated package as it's not just an intent as has several other methods and dependencies.

I think check up-to-date status can be added easily, please feel free to send PR for this.
I wish i knew how. thx for replying anyway

you need to add a new @ReactNative like this.

you need to add a new @ReactNative like this.

i would give it a try


Improve wording of retention period options

Just as describe in this comment for stream retention settings, we should make the same changes to the retention settings in the Settings > Organization settings menu:

[ ] Replace the "Retain for N days after posting" option with "Custom"
[ ] Only show the spot for entering the time if that option is selected.
[ ] Label the custom time like we do for message editing: "Retention period (days): [   ]"

@zulipbot claim

@zulipbot claim

Hello there, I'm a new member here and I was looking to make my first contribution, I saw that this issue is labeled "good-first-issue". Any tips on getting started, I have already set up the dev environment.

@zulipbot claim

Hi @alya ! I fixed this issue in #23717. It was a quick fix in HTML since #23616 made revisions on javascript.

@zulipbot The invitation link was expired. Could you send me a new one? Thanks!

@zulipbot claim

@zulipbot claim

@zulipbot claim

@zulipbot claim

Does this issue still need to be fixed?

Want to work on this issue. Can you please assign this issue to me?

@zulipbot claim

Just as describe in this comment for stream retention settings, we should make the same changes to the retention settings in the Settings > Organization settings menu:

[ ]  Replace the "Retain for N days after posting" option with "Custom"
[ ]  Only show the spot for entering the time if that option is selected.
[ ]  Label the custom time like we do for message editing: "Retention period (days): [   ]"

Just as describe in this comment for stream retention settings, we should make the same changes to the retention settings in the Settings > Organization settings menu:

[ ]  Replace the "Retain for N days after posting" option with "Custom"
[ ]  Only show the spot for entering the time if that option is selected.
[ ]  Label the custom time like we do for message editing: "Retention period (days): [   ]"

Hey, @alya, I was going through this issue, and after checking it on zulip, I came to know that it is already fixed.

Now can you make me clear what still needs to be changed here?

@Ankitsharma991 This issue already has a PR which is almost complete. Feel free to pick up another issue.

@Ankitsharma991 This issue already has a PR which is almost complete. Feel free to pick up another issue.

Thanks for your response @sahil839, I checked by running the server and found everything corrected there. Yet found this issue open so, claimed it.

You might be checking the stream setting, this issue is for organization setting and thus the issue is open. But as I said there is already a PR which fixes it.


Connection problem

Im using workerman websocket in wamp server (apache, mysql, php). So i maked some configuration, to enable my mobile can access the server with ipv4 address.
The problem is: When i access from my computer (the server), workerman listen the connection (all ok), but when i enter with mobile, workerman cant listen this.
Its can be a problem with some workerman configuration? How can i resolve?

I'm not sure why.
If your network environment supports IPv6, try to let workman listen IPv4 and IPv6 at the same time which codes may like this.
$worker = new Worker('websocket://[::]:8080');

Incidentally, workman should be started using the command line, similar to 'php start.php start' or 'php start.php start - d' as daemon.

@walkor I tried, but unsuccessful.  Only changed the port, because i didnt uderstanding the [::] in your answer.
How i start the workerman (in cmd):
> cd path_folder
> php websocket.php

My worker now:
$ws_worker = new Worker('websocket://***.***.***.***:8080');
The mask ***.***.***.*** refers to the ipv4, i tried to access with mobile (multiple tests with browsers) and keep having the same problem, workeman cant listen connections that comes from outside devices, only connections in the sever (my computer, that running the script).
Javascript:
var conn = new WebSocket('ws://<IP_ADDRESS>:8080');

Looks like your port 8080 was blocked by firewall.
You should test can you access other port from your device.
You can visit your service from local machine because firewall not block localhost.

@xpader For other devices (mobiles that i tested),i access my pages without a problem (css, html and js working ok).
Apache running on port 80.


シミュレーション開始でChodeonoidが落ちる

Choreonoid開発版のドキュメントのROSとの連携に沿って，Ubuntu 20.04 + ROS Noetic環境でインストールを行いました．
roslaunch cnoid_tank_bringup rtf_plant.launch

を実行すると，Choreonoidが起動し，プラントの環境とタンクのモデルが表示されます．メッセージビューには何もエラーは出ていません．しかし，Start simulation from beginningをクリックすると，Choreonoidが落ちます．ローンチから落ちた時点までに端末に表示された内容を以下に付けます．
... logging to /home/ubuntu/.ros/log/7931542e-df2d-11ec-ac76-0242ac110002/roslaunch-906b47b223e3-3360.log
Checking log directory for disk usage. This may take a while.
Press Ctrl-C to interrupt
Done checking log file disk usage. Usage is <1GB.

xacro: in-order processing became default in ROS Melodic. You can drop the option.
started roslaunch server http://<IP_ADDRESS>:34043/

SUMMARY
========

PARAMETERS
 * /Tank/base_controller/angular/z/has_acceleration_limits: True
 * /Tank/base_controller/angular/z/has_velocity_limits: True
 * /Tank/base_controller/angular/z/max_acceleration: 1.57
 * /Tank/base_controller/angular/z/max_velocity: 6.28
 * /Tank/base_controller/angular/z/min_acceleration: -1.57
 * /Tank/base_controller/angular/z/min_velocity: -6.28
 * /Tank/base_controller/cmd_vel_timeout: 1.0
 * /Tank/base_controller/enable_odom_tf: False
 * /Tank/base_controller/left_wheel: TRACK_L
 * /Tank/base_controller/linear/x/has_acceleration_limits: True
 * /Tank/base_controller/linear/x/has_velocity_limits: True
 * /Tank/base_controller/linear/x/max_acceleration: 1.0
 * /Tank/base_controller/linear/x/max_velocity: 4.0
 * /Tank/base_controller/linear/x/min_acceleration: -1.0
 * /Tank/base_controller/linear/x/min_velocity: -4.0
 * /Tank/base_controller/pose_covariance_diagonal: [0.001, 0.001, 10...
 * /Tank/base_controller/publish_rate: 50.0
 * /Tank/base_controller/right_wheel: TRACK_R
 * /Tank/base_controller/twist_covariance_diagonal: [0.001, 0.001, 10...
 * /Tank/base_controller/type: diff_drive_contro...
 * /Tank/base_controller/wheel_radius: 1.0
 * /Tank/base_controller/wheel_radius_multiplier: 1.0
 * /Tank/base_controller/wheel_separation: 0.44
 * /Tank/base_controller/wheel_separation_multiplier: 1.0
 * /Tank/robot_description: <?xml version="1....
 * /Tank/turret_controller/gains/TURRET_P/d: 1
 * /Tank/turret_controller/gains/TURRET_P/i: 10
 * /Tank/turret_controller/gains/TURRET_P/p: 100
 * /Tank/turret_controller/gains/TURRET_Y/d: 1
 * /Tank/turret_controller/gains/TURRET_Y/i: 10
 * /Tank/turret_controller/gains/TURRET_Y/p: 100
 * /Tank/turret_controller/joints: ['TURRET_Y', 'TUR...
 * /Tank/turret_controller/type: position_controll...
 * /rosdistro: noetic
 * /rosversion: 1.15.14
 * /use_sim_time: True

NODES
  /
    choreonoid_ros (choreonoid_ros/choreonoid)
    tank_controller_spawner (controller_manager/spawner)
  /Tank/
    robot_state_publisher (robot_state_publisher/robot_state_publisher)

ROS_MASTER_URI=http://<IP_ADDRESS>:11311

process[choreonoid_ros-1]: started with pid [3376]
process[Tank/robot_state_publisher-2]: started with pid [3377]
process[tank_controller_spawner-3]: started with pid [3378]
QStandardPaths: XDG_RUNTIME_DIR not set, defaulting to '/tmp/runtime-ubuntu'
[INFO] [1653816975.172670, 0.000000]: Controller Spawner: Waiting for service Tank/controller_manager/load_controller
[WARN] [1653817005.330036, 0.000000]: Controller Spawner couldn't find the expected controller_manager ROS interface.
[tank_controller_spawner-3] process has finished cleanly
log file: /home/ubuntu/.ros/log/7931542e-df2d-11ec-ac76-0242ac110002/tank_controller_spawner-3*.log
[tank_controller_spawner-3] restarting process
process[tank_controller_spawner-3]: started with pid [3449]
[INFO] [1653817006.258564, 0.000000]: Controller Spawner: Waiting for service Tank/controller_manager/load_controller
[WARN] [1653817036.462038, 0.000000]: Controller Spawner couldn't find the expected controller_manager ROS interface.
[tank_controller_spawner-3] process has finished cleanly
log file: /home/ubuntu/.ros/log/7931542e-df2d-11ec-ac76-0242ac110002/tank_controller_spawner-3*.log
[tank_controller_spawner-3] restarting process
process[tank_controller_spawner-3]: started with pid [3473]
[INFO] [1653817037.378991, 0.000000]: Controller Spawner: Waiting for service Tank/controller_manager/load_controller
[INFO] [1653817037.681626, 0.000000]: Controller Spawner: Waiting for service Tank/controller_manager/switch_controller
[INFO] [1653817037.683365, 0.000000]: Controller Spawner: Waiting for service Tank/controller_manager/unload_controller
[INFO] [1653817037.684932, 0.000000]: Loading controller: turret_controller
[INFO] [1653817037.697499, 0.000000]: Loading controller: base_controller
[INFO] [1653817037.716302, 0.000000]: Controller Spawner: Loaded controllers: turret_controller, base_controller
terminate called after throwing an instance of 'std::runtime_error'
  what():  Time is out of dual 32-bit range
[INFO] [1653817039.239208, 0.000000]: Started controllers: turret_controller, base_controller
[choreonoid_ros-1] process has died [pid 3376, exit code -6, cmd /home/ubuntu/cnoid_ws/devel/lib/choreonoid_ros/choreonoid /home/ubuntu/cnoid_ws/src/cnoid_tank_pkgs/cnoid_tank_bringup/project/RTFPlant/Tank.cnoid __name:=choreonoid_ros __log:=/home/ubuntu/.ros/log/7931542e-df2d-11ec-ac76-0242ac110002/choreonoid_ros-1.log].
log file: /home/ubuntu/.ros/log/7931542e-df2d-11ec-ac76-0242ac110002/choreonoid_ros-1*.log

昨年の夏頃は，Ubuntu 18.04ですが，正常に動作していたと記憶しています．

@y-masutani 一応こちらでは問題の解決を確認していますが，もし症状が続くようであればお知らせいただければと思います．

応答が遅くなり申し訳ありません．問題解決しました．


UWP Bug: Can't achieve font weight of SemiBold in HostConfig (500 and 600 do same thing)

Action Center needs to use SemiBold, and while the HostConfig supports assigning 100-900, for some reason assigning 500 doesn't result in SemiBold, 500 actually ends up identical to 600, which is simply bold.

HostConfig
Result

400

500

600

This is possibly a bug in XAML itself since in the code we're directly assigning the number to the font weight value. I'll look into why it's not working and possible fixes.

Nvm, font weight 500 and 600 are SemiBold. Font weight 700 is Bold. Font weight 800-900 are ExtraBold

Weight number
Weight enum

400
Normal

500
SemiBold

600
SemiBold

700
Bold

800
ExtraBold

900
ExtraBold

So there's some other reason it's not matching Action Center's title text. Maybe they actually use Normal for most of their text and the designer was incorrect


Model with optimistic locking (lock_version) and trackable devise module

Environment

Ruby 2.3.3
Rails 4.2.10
Devise 3.5.0

Current behavior
My Admin model has optimistic locking switched on using Rails' lock_version column in the database. I also have trackable module switched on for this model.
When admins login to the application, we trigger a number of ajax requests to the server and some of them fail randomly with ActiveRecord::StaleObjectError: Attempted to update a stale object: Admin error. We also use the authenticate helper in the routes.rb file. Previously I have tried to use request.env['devise.skip_trackable'] = true in the controllers as a prepended filter to avoid doing tracking on certain requests but the exception pesists.
The stacktraces indicate that the exception happens before the code hits the controller i.e. during request routing due to the use of authenticate helper. This happens randomly due to race conditions depending on when/how the requests for the same admin reach the server. Because the model has lock_version two requests at the same time will be unable to update the admin object at the same time.
Expected behavior
update_tracked_fields! should recover gracefully from the ActiveRecord::StaleObjectError error by either retrying or ignoring.

Hi @asanghi, I'm not sure devise should handle this. Locking strategy is very application-specific, and it seems strange that you're hitting trackable simultaneously multiple times for the same Admin. Would you mind to explain why this is happening?

The UI fires multiple AJAX requests which hit the application at the same time.
The requests hit the authenticate routing helper and because Admin model is trackable, multiple requests cause a race condition. This wouldnt be a problem unless your model also has optimistic locking turned on.
To answer your original question, it is because we have ajax requests originating from our dashboard.

@asanghi I see, then this looks like something very specific from your application. Something that would probably fix it is to first authenticate the user and only fire the dashboard requests after the user is authenticated.
I don't think we should handle locking in Devise because it would be hard to cover the possible cases - since the business rules changes from company to company.

#4584 and this ticket have mixed similar concerns.

Hm, got it. I thought that you were sending requests to authenticate explicitly, but if it's because of what was mentioned in #4584 then I guess the best approach is to change that behavior. That way we won't call trackable every time and therefore you won't have lock issues.
I'm going to close this in favor of #4584 then. Thanks!


fix(folders): Use real folder names instead of splicing slugs

In breadcrumbs and folder pages (both folder page titles and page lists) the name of the folder was derived from the slug unless overriden, which is.. wonky.
This is much more noticeable if you change the slugify function to make all slugs lowercase - which I did, and which may be a followup PR.
The patch was pretty straightforward though, we just use the real folder names from the relativePath.
Just noticed that the explorer did not have this issue and it did use the relativePath just like I'm doing here, so this is also consistency ig
With this fix lowercase slugs seem to work?. Other than that I haven't noticed any issues yet.

fwiw we should get from title from frontmatter for folder that contains index.md, otherwise iirc the reason why we slice slug is that slug is final/atomic (i might be wrong here, cc @jackyzha0 on this)

yeah we use the title by default and fallback to slug segment, im ok changing it to real folder name

we should get from title from frontmatter for folder that contains index.md

In breadcrumbs we do that and my change does not break it.
The other thing is folderPage title and nested folders in the page list - currently those just use slugs, we should add resolving folder titles from index.md frontmatter there too.

slug is final/atomic

Slugs are for better URLs, and being final/atomic makes total sense, since we use slugs as keys for lookups etc, sure.
But this change is only for what's emitted in the final html visually (esp. the folderPage title where it's not even a link lol) - slugs there look very ugly - and even surprising(!), compared to actual directory names they come from.
As I've mentioned, this is especially noticeable if you want lowercase slugs for nicer URLs - which btw is very easy to do, just add a little .toLowerCase() to the slugify function, I havent noticed any issues besides visual folder names so far

Also I think resolveFrontmatterTitle option in Breadcrumbs is not needed, the doc says there's performance issues, but all it does is add a single loop through the content (a single per build, not per component instance aka per page, since it's cached), which a lot of plugins/components do
Maybe I'm missing something tho

Also I think resolveFrontmatterTitle option in Breadcrumbs is not needed, the doc says there's performance issues, but all it does is add a single loop through the content (a single per build, not per component instance aka per page, since it's cached), which a lot of plugins/components do Maybe I'm missing something tho

we should update the docs, i fixed the perf there but forgot to update it lol

Well if the option was there for perf issue that was fixed we could just remove it
Maybe leave it in the interface for it to not be a breaking change for a while and just ignore it

Well if the option was there for perf issue that was fixed we could just remove it
Maybe leave it in the interface for it to not be a breaking change for a while and just ignore it

turns out i updated the docs but not the docstring in the actual interface, feel free to just remove that warning, i think keeping the option there is fine 🤷

I think the option is useless, because you need to explicitly make an index.md and put a title in there to make use of the feature, so having an option to enable that is redundant.
It made some sense with the perf issue, but now it only technically saves you some unnoticeable amount of time 🤷
But if you're sure you want to keep it then okay


bumping bwc test version for 3.0.0

Description
2.x has been bumped to 2.11 (PR), updating main branch BWC test version to match
Check List

[ ] New functionality includes testing.

[ ] All tests pass

[ ] New functionality has been documented.

[ ] New functionality has javadoc added

[X] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Failing BWC tests due to :
Execution failed for task ':opensearch-job-scheduler-sample-extension:jobSchedulerBwcCluster#oldVersionClusterTask1'.
> Could not resolve all files for configuration ':opensearch-job-scheduler-sample-extension:opensearch_distro_extracted_testclusters-opensearch-job-scheduler-sample-extension-jobSchedulerBwcCluster1-0-2.11.0-SNAPSHOT-'.
   > Could not resolve opensearch-distribution-snapshot:opensearch:2.11.0-SNAPSHOT.
     Required by:
         project :opensearch-job-scheduler-sample-extension
      > Could not resolve opensearch-distribution-snapshot:opensearch:2.11.0-SNAPSHOT.
         > Could not get resource 'https://artifacts.opensearch.org/snapshots/core/opensearch/2.11.0-SNAPSHOT/opensearch-min-2.11.0-SNAPSHOT-linux-x64-latest.tar.gz'.
            > Could not HEAD 'https://artifacts.opensearch.org/snapshots/core/opensearch/2.11.0-SNAPSHOT/opensearch-min-2.11.0-SNAPSHOT-linux-x64-latest.tar.gz'. Received status code 403 from server: Forbidden


Failed to compile proto to dart with import "google/protobuf/struct.proto"

Generated a relative path; it appears to be that there isn't a global dart package for well known proto types and the compiler just treated the import as an average file import

We don't treat the well known protos special. You have to include it in your project.
It can be downloaded here: https://github.com/protocolbuffers/protobuf/blob/master/src/google/protobuf/struct.proto
This has been discussed here: https://github.com/dart-lang/protobuf/issues/170


K8s modular upgrade validations

Issue #, if available:
Description of changes:
Validations for modular k8s upgrades
Testing (if applicable):
Documentation added/planned (if applicable):
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Are we going to add some e2e tests in another PR?

yes

/lgtm

/approve


Can I change class_weight during training in Keras?

I want to change my class_weight during training in Keras.
I used fit_generator and Callback method like below.
model.fit_generator(
                decoder_generator(x_train, y_train),
                steps_per_epoch=len(x_train),
                epochs=args.epochs,
                validation_data=decoder_generator(x_valid, y_valid),
                validation_steps=len(x_valid),
                callbacks=callback_list,
                class_weight=class_weights,
                verbose=1)

and
class Valid_checker(keras.callbacks.Callback):
    def __init__(self, model_name, patience, val_data, x_length):
        super().__init__()
        self.best_score = 0
        self.patience = patience
        self.current_patience = 0
        self.model_name = model_name
        self.validation_data = val_data
        self.x_length = x_length

    def on_epoch_end(self, epoch, logs={}):
        X_val, y_val = self.validation_data
        y_predict, x_predict = model.predict_generator(no_decoder_generator(X_val, y_val), steps=len(X_val))
        y_predict = np.asarray(y_predict)
        x_predict = np.asarray(x_predict)

decoder_generator and no_decoder_generator are just custom generator.
I want to change the class weight every time the epoch ends. Is it possible? then how can I do?
My data is imbalanced data, and overfitting is continued for one class.
At the end of the epoch I want to increase the weight for classes with low accuracy by calculating the accuracy by class.
How can I do?

I don't think it's possible using fit_generator, you can try using train_on_batch instead.
another possibility custom the loss function and do class balancing at there.


ArchLinux ARM UTM crash

I have updated my 2018 iPad Pro 12.9 to 14.2 and running UTM 2.0b7.
I had downloaded the ArchLinux ARM from the list of official VMs and have heavily modified it to run a GUI.  I copied it to a backup directory before upgrading to 2.0b7.  After upgrading I copied it back to the UTM directory, restarted UTM got the nice pretty new interface and started this VM.  It stopped without showing anything.  My x86_64 VMs work ok.  My Debian ARM did not start either.  I downloaded the Debian UTM from the official downloads and it started up.  So, back to my ArchLinux ARM.  I removed mine and re-downloaded the console ArchLinux ARM from the official VM location and tried it.  It crashed too.
I will add the debug and the crash log.  However, since it does it from the VM from the official site, it might be easier to get it from there and see if it does the same for you.
Debug log:
at debug.log
UTMTerminalIO does not support debug mode.
2020-11-05 09:48:36.894 UTM[929:523841] UTMTerminalIO does not support debug mode.
Loading libqemu-system-aarch64.utm.dylib
2020-11-05 09:48:36.942 UTM[929:523841] Loading libqemu-system-aarch64.utm.dylib
Running:  -L /private/var/containers/Bundle/Application/69E96230-85DE-46B8-AD4B-E8CC28CE753C/UTM.app/qemu -S -qmp tcp:localhost:4000,server,nowait -nographic -chardev pipe,id=term0,path=/private/var/mobile/Containers/Data/Application/46096553-A24A-4B2F-B113-50F32CB77EAC/tmp/ArchLinux-ARM.terminal -serial chardev:term0 -smp cpus=4,sockets=1 -machine virt, -accel tcg,mirror-rwx=on -cpu cortex-a72 -device virtio-gpu-pci -boot order=d -m 2048 -soundhw ac97 -name ArchLinux-ARM -drive if=virtio,media=disk,id=drive2,file=/var/mobile/Containers/Data/Application/46096553-A24A-4B2F-B113-50F32CB77EAC/Documents/ArchLinux-ARM.utm/Images/disk.qcow2 -device rtl8139,netdev=net0 -netdev user,id=net0 -device usb-ehci -device usb-tablet -device usb-mouse -device usb-kbd -device virtio-serial -device virtserialport,chardev=vdagent,name=com.redhat.spice.0 -chardev spicevmc,id=vdagent,debug=0,name=vdagent -uuid E3459327-D6AC-409C-ABCA-08EAAC345F57 -rtc base=localtime -append "root=/dev/vda rw"
2020-11-05 09:48:36.958 UTM[929:523841] Running:  -L /private/var/containers/Bundle/Application/69E96230-85DE-46B8-AD4B-E8CC28CE753C/UTM.app/qemu -S -qmp tcp:localhost:4000,server,nowait -nographic -chardev pipe,id=term0,path=/private/var/mobile/Containers/Data/Application/46096553-A24A-4B2F-B113-50F32CB77EAC/tmp/ArchLinux-ARM.terminal -serial chardev:term0 -smp cpus=4,sockets=1 -machine virt, -accel tcg,mirror-rwx=on -cpu cortex-a72 -device virtio-gpu-pci -boot order=d -m 2048 -soundhw ac97 -name ArchLinux-ARM -drive if=virtio,media=disk,id=drive2,file=/var/mobile/Containers/Data/Application/46096553-A24A-4B2F-B113-50F32CB77EAC/Documents/ArchLinux-ARM.utm/Images/disk.qcow2 -device rtl8139,netdev=net0 -netdev user,id=net0 -device usb-ehci -device usb-tablet -device usb-mouse -device usb-kbd -device virtio-serial -device virtserialport,chardev=vdagent,name=com.redhat.spice.0 -chardev spicevmc,id=vdagent,debug=0,name=vdagent -uuid E3459327-D6AC-409C-ABCA-08EAAC345F57 -rtc base=localtime -append "root=/dev/vda rw"
Stream error Error Domain=NSPOSIXErrorDomain Code=61 "Connection refused" UserInfo={_kCFStreamErrorCodeKey=61, _kCFStreamErrorDomainKey=1}
QMP stream error seen: Error Domain=NSPOSIXErrorDomain Code=61 "Connection refused" UserInfo={_kCFStreamErrorCodeKey=61, _kCFStreamErrorDomainKey=1}
QMP connection failed, retries left: 29
2020-11-05 09:48:36.960 UTM[929:525096] Stream error Error Domain=NSPOSIXErrorDomain Code=61 "Connection refused" UserInfo={_kCFStreamErrorCodeKey=61, _kCFStreamErrorDomainKey=1}
2020-11-05 09:48:36.960 UTM[929:525096] QMP stream error seen: Error Domain=NSPOSIXErrorDomain Code=61 "Connection refused" UserInfo={_kCFStreamErrorCodeKey=61, _kCFStreamErrorDomainKey=1}
2020-11-05 09:48:36.960 UTM[929:525096] QMP connection failed, retries left: 29
qemu-system: -append only allowed with -kernel option
changeFont error: (null)
2020-11-05 09:48:37.070 UTM[929:523841] changeFont error: (null)
setCursorBlink error: (null)
2020-11-05 09:48:37.072 UTM[929:523841] setCursorBlink error: (null)
RPC: Error Domain=com.osy86.utm Code=-1 "No connection for RPC." UserInfo={NSLocalizedDescription=No connection for RPC.}
2020-11-05 09:48:37.110 UTM[929:525096] RPC: Error Domain=com.osy86.utm Code=-1 "No connection for RPC." UserInfo={NSLocalizedDescription=No connection for RPC.}
Terminal resize: (
189,
66
)
2020-11-05 09:48:37.524 UTM[929:523841] Terminal resize: (
189,
66
)
Connected to stream
QMP connection successful! (readStream:1)
Connected to stream
2020-11-05 09:48:38.059 UTM[929:525097] Connected to stream
QMP connection successful! (readStream:0)
2020-11-05 09:48:38.059 UTM[929:525097] QMP connection successful! (readStream:1)
2020-11-05 09:48:38.059 UTM[929:525097] Connected to stream
2020-11-05 09:48:38.059 UTM[929:525097] QMP connection successful! (readStream:0)
Stop operation timeout
2020-11-05 09:49:07.156 UTM[929:524865] Stop operation timeout
Successfuly disconnected!
2020-11-05 09:49:07.156 UTM[929:524865] Successfuly disconnected!

Cleanup completed!
Source got cancelled
2020-11-05 09:49:07.158 UTM[929:525291] Cleanup completed!
2020-11-05 09:49:07.158 UTM[929:525291] Source got cancelled
Exit operation timeout
Crash log file 1
at UTM-2020-11-05-093349.ips
{"app_name":"UTM","timestamp":"2020-11-05 09:33:49.00 -0600","app_version":"2.0b7","slice_uuid":"fb4a076f-4026-36ff-85ce-e0a84f69ff87","adam_id":0,"build_version":"7","platform":2,"bundleID":"com.osy86.UTM.Beta","share_with_app_devs":0,"is_first_party":0,"bug_type":"109","os_version":"iPhone OS 14.2 (18B91)","incident_id":"C09BC7BC-AD25-4344-9163-5508E6BF67F5","name":"UTM"}
Incident Identifier: C09BC7BC-AD25-4344-9163-5508E6BF67F5
CrashReporter Key:   9980b7b35239f60a1b6bda075fb837e46bb7b628
Hardware Model:      iPad8,7
Process:             UTM [907]
Path:                /private/var/containers/Bundle/Application/69E96230-85DE-46B8-AD4B-E8CC28CE753C/UTM.app/UTM
Identifier:          com.osy86.UTM.Beta
Version:             7 (2.0b7)
Code Type:           ARM-64 (Native)
Role:                Foreground
Parent Process:      launchd [1]
Coalition:           com.osy86.UTM.Beta [643]
Date/Time:           2020-11-05 09:33:49.1502 -0600
Launch Time:         2020-11-05 09:28:13.7532 -0600
OS Version:          iPhone OS 14.2 (18B91)
Release Type:        User
Baseband Version:    3.01.01
Report Version:      104
Exception Type:  EXC_BAD_ACCESS (SIGSEGV)
Exception Subtype: KERN_INVALID_ADDRESS at 0x0000000000000008
VM Region Info: 0x8 is not in any region.  Bytes before following region:<PHONE_NUMBER>
REGION TYPE                 START - END      [ VSIZE] PRT/MAX SHRMOD  REGION DETAIL
UNUSED SPACE AT START
--->
__TEXT                   102eb4000-103178000 [ 2832K] r-x/r-x SM=COW  ...C/UTM.app/UTM
Termination Signal: Segmentation fault: 11
Termination Reason: Namespace SIGNAL, Code 0xb
Terminating Process: exc handler [907]
Triggered by Thread:  7
...
Thread 5 name:  com.apple.uikit.eventfetch-thread
Thread 5:
0   libsystem_kernel.dylib              0x00000001bd7632d0 0x1bd75f000 + 17104
1   libsystem_kernel.dylib              0x00000001bd762660 0x1bd75f000 + 13920
2   CoreFoundation                      0x0000000190f09c30 0x190e69000 + 658480
3   CoreFoundation                      0x0000000190f03c14 0x190e69000 + 633876
4   CoreFoundation                      0x0000000190f0321c 0x190e69000 + 631324
5   Foundation                          0x00000001921afdf0 0x1921a7000 + 36336
6   Foundation                          0x00000001921afcbc 0x1921a7000 + 36028
7   UIKitCore                           0x00000001939effe4 0x192d75000 + 13086692
8   Foundation                          0x0000000192321a34 0x1921a7000 + 1550900
9   libsystem_pthread.dylib             0x00000001d9682b40 0x1d9681000 + 6976
10  libsystem_pthread.dylib             0x00000001d968b768 0x1d9681000 + 42856
Thread 6 name:  Dispatch queue: com.apple.root.background-qos
Thread 6:
0   libsystem_kernel.dylib              0x00000001bd76330c 0x1bd75f000 + 17164
1   libdispatch.dylib                   0x0000000190b83318 0x190b7f000 + 17176
2   libdispatch.dylib                   0x0000000190b839e0 0x190b7f000 + 18912
3   UTM                                 0x0000000102ec3e18 0x102eb4000 + 65048
4   libdispatch.dylib                   0x0000000190b8124c 0x190b7f000 + 8780
5   libdispatch.dylib                   0x0000000190b82db0 0x190b7f000 + 15792
6   libdispatch.dylib                   0x0000000190b93a68 0x190b7f000 + 84584
7   libdispatch.dylib                   0x0000000190b94120 0x190b7f000 + 86304
8   libsystem_pthread.dylib             0x00000001d96847c8 0x1d9681000 + 14280
9   libsystem_pthread.dylib             0x00000001d968b75c 0x1d9681000 + 42844
Thread 7 Crashed:
0   libphodav-2.0.0.utm.dylib           0x0000000104d616a4 0x104d1c000 + 284324
1   libphodav-2.0.0.utm.dylib           0x0000000104d6169c 0x104d1c000 + 284316
2   libphodav-2.0.0.utm.dylib           0x0000000104d61650 0x104d1c000 + 284240
3   ...client-glib-2.0.8.utm.dylib      0x000000010565d28c 0x10563c000 + 135820
4   ...client-glib-2.0.8.utm.dylib      0x000000010565d008 0x10563c000 + 135176
5   libgio-2.0.0.utm.dylib              0x0000000105303a00 0x105274000 + 588288
6   libgio-2.0.0.utm.dylib              0x00000001053027e4 0x105274000 + 583652
7   libgio-2.0.0.utm.dylib              0x0000000105302e54 0x105274000 + 585300
8   ...client-glib-2.0.8.utm.dylib      0x000000010567bed4 0x10563c000 + 261844
9   libglib-2.0.0.utm.dylib             0x00000001058c5920 0x10587c000 + 301344
10  libglib-2.0.0.utm.dylib             0x00000001058c9ab4 0x10587c000 + 318132
11  libglib-2.0.0.utm.dylib             0x00000001058c98ec 0x10587c000 + 317676
12  libglib-2.0.0.utm.dylib             0x00000001058c9e20 0x10587c000 + 319008
13  libglib-2.0.0.utm.dylib             0x00000001058ca330 0x10587c000 + 320304
14  UTM                                 0x0000000102ecc1d4 0x102eb4000 + 98772
15  libsystem_pthread.dylib             0x00000001d9682b40 0x1d9681000 + 6976
16  libsystem_pthread.dylib             0x00000001d968b768 0x1d9681000 + 42856
Thread 8:
0   libsystem_kernel.dylib              0x00000001bd7871ac 0x1bd75f000 + 164268
1   libsystem_pthread.dylib             0x00000001d9686458 0x1d9681000 + 21592
2   ...mu-system-aarch64.utm.dylib      0x000000011bfbe840 0x11b9b4000 + 6334528
3   ...mu-system-aarch64.utm.dylib      0x000000011bfc6710 0x11b9b4000 + 6366992
4   ...mu-system-aarch64.utm.dylib      0x000000011bfbea10 0x11b9b4000 + 6334992
5   libsystem_pthread.dylib             0x00000001d9682b40 0x1d9681000 + 6976
6   libsystem_pthread.dylib             0x00000001d968b768 0x1d9681000 + 42856

what specifications of the VM did you use?

I didn't set anything different then what the downloaded ArchLinux ARM UTM already had.  I did try using the graphic console rather then the text console once to see if that would make any difference.  Otherwise, that UTM has a QEMU option: -append "root=/dev/vda rw" which is different then the Debian ARM UTM VM.  Also, it had the kernel initrd and base disk all set to whatever was set originally.  Bottom line I didn't change anything, just downloaded the VM start UTM and tried to start the VM


[AMORO-2888] Can't establish connections when rebooting ams

Why are the changes needed?

Close #2888.
Brief change log

How was this patch tested?

[ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

[ ] Add screenshots for manual tests if appropriate

[ ] Run test locally before making a pull request

Documentation

Does this pull request introduce a new feature? (yes / no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@tcodehuber Thanks for the contribution!
But I am not sure if allowPublicKeyRetrieval=true is a common property to all MySQL versions.

allowPublicKeyRetrieval=true

Although it's imported by mysql8, adding it in the con url will not affect other editions of mysql. It will be ignored if connecting to the mysql below version 8, which will not take side effort.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 27.56%. Comparing base (4e3e5c6) to head (3190af3).
Report is 4 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2889      +/-   ##
============================================
+ Coverage     27.47%   27.56%   +0.08%
  Complexity     2483     2483
============================================
  Files           360      360
  Lines         37213    37099     -114
  Branches       5432     5367      -65
============================================
+ Hits          10226    10227       +1
+ Misses        26027    25912     -115
  Partials        960      960

Flag
Coverage Δ

trino
27.56% <ø> (+0.08%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Although it's imported by mysql8, adding it in the con url will not affect other editions of mysql. It will be ignored if connecting to the mysql below version 8, which will not take side effort. I have tested that in my own env.

Thanks for the information.


raidboss: add forcejump timeline command

Rather than adding a loop, add a variant of jump called forcejump to the timeline language.  If the sync does not occur, the jump will always happen when the time passes. This allows the timeline controller to automatically add loop lookahead rather than manually specifing it.
There's some manual testing of this in the Frankenstein manual test.txt test case.
To track this, nextEvent now has a whole bunch more state to track where it is in the lookahead so that when adding additional events as timer bars, it doesn't duplicate its efforts.
Additionally, since the same event could be added twice (or more) times on the screen, they need to have different ids (now strings instead of numbers, that include the "jump count" of the number of times we've gone through a lookahead jump to differentiate them from their pre-jump selves). Similarly, they also need different sort keys, although this is kind of a hack for now.
This also adds some grumpy documentation of a bunch of issues found in the code and potential followups.
Sorry that this code is a mess, but I didn't want to rewrite the world at this time.
Closes #5144.

I'll leave this up for another week or so.  If anybody has any opinions here on either top-level direction or implementation details (@JLGarber? @valarnin?), please feel free to chime in (or ask for more time if you want it too!)
I ended up going with forcejump rather than loop for a couple of reasons.
One is just naming: sometimes the jump is forwards (such as when we have a branch into A and B and then A and B come back together again into a common timeline), and so it's not always a loop jumping backwards (where eventually you'd hit the loop / forcejump again).  It felt weird to call the former a loop.
The other reason is that while implementing the lookahead (and also in discussion on #5144), I realized that it got confusing to try to think about what happens if the time got past the loop point without syncing.  I could imagine going forward in time in some virtual timeline space where we map real time back onto the loop itself with modulo math, but then ... how do you know which syncs apply where?  I decided it was easier to just forcejump and say "if you ever get to this point, the timeline will just adjust its real time back to where you're going, and any syncs there will still apply".
I think the only downside to this is that if you have a forcejump window 20,20 or something, it's really always forcejump window 20,0 as the forward looking part of the sync window will never apply.  I can't think of any examples where we have a loop, but the loop itself is inconsistent.  We do sometimes add big windows, but that's usually as a "just in case" and less a "this has high variability".  However, if we wanted to add such "just in case" windows now, we'd need to do it at both the source and destination of the forcejump rather than just in one place.  (We could add timeline linting so force users to have to write window 20,0 for forcejump so that it's clear in the timeline as well? Maybe that's obnoxious.)
I guess one final alternative here is that we could add a fake sync in at the jump destination as well such that after you forcejumped, if you see a belated sync from the forcejump point, it would adjust your timing.  This is ... a bit weird to think about code-wise, but I could do it.

I guess my two points are:

Is this necessary before we end up reworking the format and therefore the underlying classes? Seems like potential breakage mid-raid-tier that we'll end up throwing out anyways later isn't really great? I'd like to get transitioned to a new timeline format before 7.0...
We do sometimes add big windows, but that's usually as a "just in case" and less a "this has high variability".

There is variance if bosses are being dragged, especially in older content but even in new trials and stuff there's still some variance.

Is this necessary before we end up reworking the format and therefore the underlying classes?

Uh, when and who is reworking this format? I haven't seen any momentum or discussion on this front, and personally haven't heard enough pain points to understand the motivation here.

I think the only downside to this is that if you have a forcejump window 20,20 or something, it's really always forcejump window 20,0 as the forward looking part of the sync window will never apply. I can't think of any examples where we have a loop, but the loop itself is inconsistent. We do sometimes add big windows, but that's usually as a "just in case" and less a "this has high variability". However, if we wanted to add such "just in case" windows now, we'd need to do it at both the source and destination of the forcejump rather than just in one place. (We could add timeline linting so force users to have to write window 20,0 for forcejump so that it's clear in the timeline as well? Maybe that's obnoxious.)
I guess one final alternative here is that we could add a fake sync in at the jump destination as well such that after you forcejumped, if you see a belated sync from the forcejump point, it would adjust your timing. This is ... a bit weird to think about code-wise, but I could do it.

I went ahead and did this.  There is now an extra synthetic sync after force jumping that contains any "overhang window" time.  If there's ever any sync or jump (or the window expires naturally), the synthetic sync will be removed.

I think my biggest issues with the current format (aside from what you already mentioned) can be summarized as:

There's no way to handle logic as part of the timeline. Something like GolbezEx would benefit greatly from some sort of logic control due to the way the stored mechanics work, similarly with e12s's stored mechanics
There's no way for a trigger to interact with the timeline (be that a normal triggers trigger, or a timelineTriggers trigger).

By interact, I mean something like:
check some conditions, and jump to this time
alter the text of this timeline entry based on some condition
hide this timeline entry based on some condition
adjust the duration of this timer bar based on some condition

There's no good way to reference a specific timeline entry. e.g. let's say I want to change the p9s 272.2 "Gluttony's Augur" entry to be something like 272.2 "Gluttony's Augur (heal check)", there's no way to target that specific timeline entry and override it without also clobbering any other entry with the same text of Gluttony's Augur
The timeline format really doesn't handle multiple different encounters in the same zone very well. e.g:

the variant dungeon conversation that was part of the discord conversation you linked
something like Delubrum Reginae where parties are handling different sets of mechanics
The Copied Factory's Hobbes fight

As for discussion about a new format, I remember some other conversation in Discord where some new example formats were thrown about, something about a yml type format and something else that I can't recall off the top of my head. Discord search is just as bad as always though and I can't find them.

jumps to numbers is fragile (we could probably add named labels)

I haven't thought too much about what would be nice to have in the timeline format, but being able to jump to a label instead of a time would definitely be on the list.  It's very easy to modify a timeline and forget to adjust the jumps currently.
It also feels kind of hacky right now the way encounters in the same zone have to be separated by arbitrarily increasing the times of the subsequent encounters.  If there was a way to say, label an encounter block and then jump to that block at the appropriate time, instead of increasing the later encounters by +1000, +2000, etc., like we currently do.  Bozjan Southern Front and Zadnor are good examples of where it would be really useful.

I split off an issue in #5619 to discuss further improvements rather than it being trapped in a PR that will be harder to find in the future.
In terms of this issue, my feeling is that the future falls into one of these buckets:

if nothing is changed about timelines, this is a positive step
if we incrementally change timelines, this is still a positive step
if we fundamentally and completely change timelines, my argument is that any new timeline format will either:

have a way to convert from old to new format (this seems important to me, but I guess it's not fundamentally required), and if so I think having a "this jump is a loop with lookahead" is important meta-information about timelines that would help with conversion and at worst could just be treated as a jump
no way to convert and we just have two timeline formats side by side, in which case maybe this is slightly wasted work but it's already done and I suspect that we'll easily get through all of the remaining 7.0 things before any "completely changed timeline" work occurs given that  the discussion is at the "what do we even need" stage

Hey y'all, this has kinda been sitting for ~2.5w without much feedback. Not that there's true urgency, but there were other timeline things I was interested in doing and felt like it made sense to take care of this one first.
If any of y'all are busy but want to take a closer look at that, that's fine. Just let me know what your schedule looks like. Otherwise, I'll likely plan on landing this in the next week barring any major objections.

Sorry, I don't really have much to offer beyond "this seems to make sense, let's land it and see what breaks". As far as using this to abstract away the whole lookahead process for fixed timelines, I can get behind that.
To be clear, when the comment notes:

This is intended for loops that will always be taken in an encounter.
When this is used, no "lookahead" loop unrolling is needed,
and the timeline will use the forcejump destination to list events in the future,

Therefore, to handle something like Ultima Warrior in Fractal Continuum (hard), we would still have to use the current unrolled lookahead, right?

Therefore, to handle something like Ultima Warrior in Fractal Continuum (hard), we would still have to use the current unrolled lookahead, right?

Yeah, this doesn't handle that. I think a potential followup here is to add a maybejump (or some sort of thing) which would do lookahead text but with question marks and no forced jump.  I thought about doing that here, but it got more complicated so I left this as-is.

I'm in the same camp as others -- conceptually it sounds like a useful, well-thought-out addition.  It sounds like forcejump will be the default for handling straightforward loops (e.g. normal raids & trials), and we'd continue to use jump for the more nuanced situations, e.g., multiple branches, multiple encounters in the same zone, etc?  (Not trying to oversimplify or generalize, just trying to articulate the default use cases.)

Sorry about the lack of feedback on my end, I've been sick the past two weeks or so.
I think this is fine to merge as-is as well, and we can continue discussion in the issue you opened for further adjustments to timeline format when I've got the mental capacity for it again.

Sorry about the lack of feedback on my end, I've been sick the past two weeks or so.

No worries! Hope you feel better!


Test with SQLShell (clapper)

On this tool I can make some queries, but I have never seen the result, only the update count.

It's working now on the master branch (6b166ec31bdb61f76279be717aa1f30ada5c553e)

Copy Neo4j JDBC driver into SQLSHELL_HOME/lib folder
Edit the configuration file SQLSHELL_HOME/sample.cfg for :
Adding neo4j driver :

[drivers]
neo4j = org.neo4j.jdbc.Driver

Adding your database

[db_neo4j]
aliases: neo
driver: neo4j
url: jdbc:neo4j:bolt://localhost
user: neo4j
password: test

Now execute sqlshell with the configuration file to open neo database :
$> SQLSHELL_HOME/bin/sqlshell -c SQLSHELL_HOME/sample.cfg neo

Execute some queries !


Export InstantClick.preload for manual preloading

Allowing manual preloading via InstantClick.preload would be very handy. Hope this can be exposed.

+1 on this. Would be great to manually preload a page.

That's planned. Would go hand in hand with #97.


Content-Type without modeled body in input

A content-type must not be set and the body empty when there is no modeled input. Is it the same when the input is modeled with only members with @httpHeader traits?
https://github.com/awslabs/smithy-rs/pull/1723#discussion_r967033105

Related PR has been merged, closing issue.


GPUImagePoissonBlendFilter how to?

I thought GPUImagePoissonBlendFilter is used in the same way any two image filters. However, when I run the below code, I only see one of the images, and I dont see any blending. What could be going wrong?
GPUImagePoissonBlendFilter *overlayBlendFilter = [[GPUImagePoissonBlendFilter alloc] init];
GPUImagePicture *pic1 = [[GPUImagePicture alloc] initWithImage:image1];
GPUImagePicture *pic2 = [[GPUImagePicture alloc] initWithImage:image2];

overlayBlendFilter.mix = .5;
overlayBlendFilter.numIterations = 2000;

[pic1 addTarget:overlayBlendFilter atTextureLocation:0];
[pic1 processImage];

[pic2 addTarget:overlayBlendFilter atTextureLocation:1];
[pic2 processImage];

[overlayBlendFilter useNextFrameForImageCapture];

UIImage *blendedImage = [overlayBlendFilter imageFromCurrentFramebuffer];

return blendedImage;

I'm guessing you're experiencing the same issue as https://github.com/BradLarson/GPUImage/issues/1709.  Try moving all your filters to strongly retained instance variables.


adapter.js using require.js breaks with HTML tag id 'global'

Browsers and versions affected
Assuming all, definitely broken on Safari and Chrome.
Description
Using require.js, if I have, say, a div tag like so in my HTML:

Then the global variable in the main require.js callback gets interpreted as that DOM node, and not the global window object.
While it's trivial to change the ID of the HTML element, what's not trivial is the three hours it took me to figure out why adapter.js wasn't working properly :)
Steps to reproduce
Place the above-mentioned div tag in the HTML of a page that loads adapter.js, load the page, inspect the global variable in the main require callback.
Expected results
global should be the window object.
Actual results
global is a DOM node.

Could you try the adapter_no_global.js build instead?

Lots of strangeness going on. I replaced adapter_no_edge.js with adapter_no_edge_no_global.js, then with adapter_no_global.js.
With both of the _no_global variants, adapter was undefined inside my require.js callback. The 'global' div made no difference either way in this case.
Digging further into the logic at the top of the files that detects environments, I discovered that the one with the global has a very different detection logic.
Bundle with global included:
(function(f) {
  if (typeof exports === "object" && typeof module !== "undefined") {
    module.exports = f()
  } else if (typeof define === "function" && define.amd) {
    define([], f)
  } else {
    var g;
    if (typeof window !== "undefined") {
      g = window
    } else if (typeof global !== "undefined") {
      g = global
    } else if (typeof self !== "undefined") {
      g = self
    } else {
      g = this
    }
    g.adapter = f()
  }
})

Bundle without global included:
(function e(t, n, r) {
  function s(o, u) {
    if (!n[o]) {
      if (!t[o]) {
        var a = typeof require == "function" && require;
        if (!u && a) return a(o, !0);
        if (i) return i(o, !0);
        var f = new Error("Cannot find module '" + o + "'");
        throw f.code = "MODULE_NOT_FOUND", f
      }
      var l = n[o] = {
        exports: {}
      };
      t[o][0].call(l.exports, function(e) {
        var n = t[o][1][e];
        return s(n ? n : e)
      }, l, l.exports, e, t, n, r)
    }
    return n[o].exports
  }
  var i = typeof require == "function" && require;
  for (var o = 0; o < r.length; o++) s(r[o]);
  return s
})

The code compaction makes the logic a bit hard to reason about, but, stepping through the code in the second case listed above, it doesn't appear to properly detect a require.js environment. However, the detection logic in the global bundle does properly detect it.
I'll note that this was all tested against the latest 5.x release, but I did check the latest 6.x release, and the files seem to be structured the same way.


assignment of regions to folders

Would be possible to assign regions to certain groups or folders? I start to lose track of different data sets I have uploaded and now also generated in the software

Definitely a bit thumbs up for this!


Angular-JS Checkbox-Radio Button

Im working with Angular-JS, and the Radiobuttons events and checkbox events, doesn´t trigger, and i can´t get the values of the selected item, any idea?

Have you added this to the end of your code (just before the </body> tag)?
<script>
$('.ui.radio.checkbox')
  .checkbox()
;
</script>

Have you also included a jQuery script?
If so, could you create a jsfiddle to show what you have done? That would make it easier to find the problem.

same here. not working!

I'm not sure if this is related, but there is a conflict between Semantic UI's ".checkbox()" and Angular's ng-model binding on the input values.  Trying to figure out a way around, but might have to end up ditching Semantic's styling because I can't see another way to access value Angular side.


Use (prefers-reduced-motion: no-preference) by default

Prerequisites

[X] I have searched for duplicate or closed feature requests
[X] I have read the contributing guidelines

Proposal
Currently, Bootstrap sets the transition value if transitions are enabled and then sets transition: none; in (prefers-reduced-motion: reduce):
@if $enable-transitions {
  @if nth($transition, 1) != null {
    transition: $transition;
  }

  @if $enable-reduced-motion and nth($transition, 1) != null and nth($transition, 1) != none {
    @media (prefers-reduced-motion: reduce) {
      transition: none;
    }
  }
}

Instead, transitions should be set in (prefers-reduced-motion: no-preference).
@if $enable-transitions {
  @if nth($transition, 1) != null {
    @if $enable-reduced-motion and nth($transition, 1) != none {
      @media (prefers-reduced-motion: no-preference) {
        transition: $transition;
      }
    } @else {
      transition: $transition;
    }
  }
}

Motivation and context
The prefers-reduced-motion media query has 94.76 % global support.
If someone uses a browser that does not support this media query, they will see the transitions.
It is preferable that websites are accessible by default, which means that animations should be enabled when the browser indicates no-preference.
This is open for debate because perhaps some browsers do not set prefers-reduced-motion to no-preference by default.

in essence, this https://codepen.io/patrickhlauke/pen/YzPPdeo

i've actually just given it a try in a branch, but the changes (to _progress.scss, _spinners.scss, and _transition.scss) end up being a bit more annoyingly repetitive than the suggested change above. taking the example in the OP, it would need to be (unless I'm mistaken)
@if $enable-transitions {
  @if nth($transition, 1) != null {
    transition: $transition;
    @if $enable-reduced-motion and nth($transition, 1) != none {
      transition: none;
      @media (prefers-reduced-motion: no-preference) {
       transition: $transition;
      }
    }
  }
}

similarly, in the others, you get the same dance, a la
@if $enable-transitions {
  .progress-bar-animated {
    animation: $progress-bar-animation-timing progress-bar-stripes;

    @if $enable-reduced-motion {
      animation: none;
      @media (prefers-reduced-motion: no-preference) {
        animation: $progress-bar-animation-timing progress-bar-stripes;
      }
    }
  }
}

@if $enable-reduced-motion {
  .spinner-border,
  .spinner-grow {
    --#{$prefix}spinner-animation-speed: #{$spinner-animation-speed * 2};
    @media (prefers-reduced-motion: no-preference) {
      --#{$prefix}spinner-animation-speed: #{$spinner-animation-speed};
    }
  }
}

considering that IE11 has now been officially sunsetted by MS for ages, that most browsers support the media query, and that users that DO require reduced motion at this point will likely transition to using a browser that actually provides them with this option that they need, I'd say the extra "define, then undefine, then redefine" dance required here is unnecessary and makes the SCSS more difficult to understand.


Color formatting

Finish the implementation of the foreground/background color writing to the System.Console.

Closed by 57bc72549e95fd18854685a0aac9647ce34ad33d


feat: add addRouteMiddleware test

🔗 Linked issue

❓ Type of change

[ ] 📖 Documentation (updates to the documentation or readme)
[ ] 🐞 Bug fix (a non-breaking change that fixes an issue)
[ ] 👌 Enhancement (improving an existing functionality like performance)
[ ] ✨ New feature (a non-breaking change that adds functionality)
[ ] ⚠ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description
I would like to add addRouteMiddleware as it was not tested.
📝 Checklist

[ ] I have linked an issue or discussion.
[ ] I have updated the documentation accordingly.

@danielroe
Is the following usage of defineNuxtRouteMiddleware acceptable?
I think it would be difficult for the Nuxt Bridge to handle this.
(Because it would have to be converted to Nuxt 2 middleware.)
const authMiddleware = defineNuxtRouteMiddleware((to, from) => {
  ...
});

export default defineNuxtPlugin((_nuxt) => {
  addRouteMiddleware('auth', authMiddleware, { global: true })
})

Related to https://github.com/nuxt/bridge/issues/826.

I would be happy to add a note that this is not supported (if we can't) 👍

Thanks!
I added documentation on defineNuxtRouteMiddleware and stated that it is not supported.
https://github.com/nuxt/nuxt/pull/21718


GL E-Ink Permanent Config form validation

Asana task: [Perm config] Form validation
Description
This PR implements form validation for GL E-ink permanent config.

FYI, I resolved merge conflicts before review to help with testing the changes.