[Question] Get result for new request

I need results from request promise then() after, and use again result for new request ?? How do that?
I hope, have someone support my question. Thanks !
   let opt = {
        method: 'POST',
        uri: API,
        body: {
            news_id: id
        },
        json: true
    };

    rp(opt).then(function (result) {
        rpt(opt2).then(function () { // error
        })
    })

Hi @Vietworm , your code looks good already. I would further improve the way you use the promises:
rp(opt)
    .then(function (result) {
        let opt2 = { /* with data from result */ };
        return rp(opt2); // The `return` inserts the second request into the promise chain.
    })
    .then(function (resultOfSecondRequest) {
        // Process resultOfSecondRequest here...
    })
    .catch(function (err) {
        // Handle any error from the first, the second request, or the final processing here...
    });

Does this help?

@analog-nico thanks for answer :)
I've been tried it but throw error
Unhandled rejection RequestError: Error: Argument error, options.body.

Since it says Argument error, options.body you got something wrong with the body option. You find some details about this option here.
Since it is also saying Unhandled rejection means that you did not properly add a .catch(...) handler. My code above does this properly.
If you need both results then you may use:
rp(opt)
    .then(function (result) {
        let opt2 = { /* with data from result */ };
        return [result, rp(opt2)];
    })
    .spread(function (resultOfFirstRequest, resultOfSecondRequest) {
        // Process both results here...
    })
    .catch(function (err) {
        // Handle any error from the first, the second request, or the final processing here...
    });

Thanks so much @analog-nico.
My fault, i defined options not enough. As the forgotten json: true option.

You are welcome.


Scheduler options in example workflows ignored

The scheduler options in the example workflows:
run_options:
  l: short

seem to be ignored. This is MatFlow issue, but reported here for completeness. I didn't catch this before because I had previously set default_preparation_run_options in my config.

Nope, this isn't a bug. The example workflows don't specify any specific preparation or processing scheduler options, and by default no default_preparation_run_options are set in the config file, so this is expected behaviour. I have updated the README with a note about how to set the default scheduler options.

There was actually an associated bug (https://github.com/LightForm-group/matflow/issues/42), fixed now in v0.2.1.


stellar client get_balance doesn't work with address in jsng

Getting the balance for a different address only brings the balance of current wallet.
Note: works in jsx

verified


chore: publish version 0.2.15

This updates gotrue_client to have the updated signIn with OpenID to help support native auth
Related:
https://github.com/supabase-community/gotrue-dart/pull/61
I then need to update https://github.com/supabase-community/supabase-flutter

@dshukertjr Feel free to comment and then merge for me if it looks good to you!

ot: for you not to be blocked on timezones, you can use git dependencies


Remove value span usage

ValueTextEquals will handle escaping correctly, whereas checking the UTF8 bytes explicitly will not.
This would only affect custom clients that for some reason escape the property names in the negotiate, or some weird proxy that escaped stuff on the wire?!
@anurse I'm proposing this for 3.1 since it's low pri, but I could see us moving it to 5.0.
cc @ahsonkhan

Would it also affect a client that used Newtonsoft while connecting to a server that uses System.Text.Json?

If so, I could see this for 3.0 (there is no 3.1 yet ;)). If not, I think it'd be defered to 5.0

Would it also affect a client that used Newtonsoft while connecting to a server that uses System.Text.Json?

Yes, but newtonsoft shouldn't be escaping ascii property names (I hope) when writing the negotiate request.

Right, but the bar for 3.1 is the same as the bar for 3.0 :).

Rebased on 5.0

Can we add a test?

Given your comments about this only really affecting custom clients, I don't think this would meet the 3.0 or 3.1 bar. We can always backport if we get customer feedback.

Can we add a test?

I guess... it's kind of silly

@BrennanConroy Have you looked for any other places we're currently using SequenceEqual and perhaps should be using ValueTextEquals?

How did you find this? Is there an associated issue?

Have you looked for any other places we're currently using SequenceEqual and perhaps should be using ValueTextEquals?

Yes, we only missed this one when switching to ValueTextEquals

How did you find this? Is there an associated issue?

Ahson was searching for uses of ValueSpan and found it.

There was only one use of valuespan/valuesequence:
https://github.com/aspnet/AspNetCore/search?q=valuespan&unscoped_q=valuespan
Here's the issue: https://github.com/aspnet/AspNetCore/issues/8969


try/catch in tasks/config/project/release.js covers too many cases.

The try/catch block in tasks/config/project/release.js will bail to catch if either semantic.json or package.json is missing, whereas it should only do this if both are missing.
The changes introduced to this file in 57b35d2 need to be moved after the try/catch into a separate try/catch block.  Note also that this commit stores the version in the variable version whereas the value exported is package.version.

Yeah this looks wrong. I'll check it out.


Vertical node attribute not applied if used in base class

The Vertical attribute doesn't seem to work if its used in a derived class via inheritance

Nevermind, this is also being caused by not working for lists of inputs
https://github.com/alelievr/NodeGraphProcessor/issues/134


Provide an option to disable syncing for absolute paths

Testing https://github.com/microsoft/vscode/issues/103613
I've been using my windows PC for the last couple months and went to test on my mac. At this point I realized that I've had a bunch of absolute paths creeping into my settings file which I hadn't yet manually went and excluded from settings.
Since absolute paths in settings are likely to break between computers, it would be nice if there was some kind of prompt the first time settings sync is enabled which would discover absolute paths in the user settings and let them easily exclude these settings before the first sync happens.

Unfortunately we do not know if a setting is a path setting or not, instead we allow extensions to provide a scope for a setting. Settings defined with machine or machine-overridable scopes are ignored during sync.


Add "hacktoberfest" repository topic

Please add the "hacktoberfest" repository topic to allow completion of the Hacktoberfest challenge 🙏
It's already present on the 30-seconds-of-code repository 😉

Sorry, but we've made a conscious decision here to not accept snippets in all repositories due to the high amounts of new users trying to contribute and the large amount of spam PRs we are getting. For this year's Hacktoberfest we are only accepting content in the JS and Python repos, so no hacktoberfest topic or hacktoberfest-accepted on any other repos. Cheers.


Patrick Kumi (new edits)

Describe yourself
5 years ago, Patrick left South Sudan due to the civil war that broke out in his hometown, He grew up with a single parent, and because of this, he never really knew what it meant to be a kid. Since the adults were quite unsupportive, he didn’t learn how to relate well with other kids and had not learned self-awareness until years later.
Patrick Kumi is a Brand and Online Marketing Strategist and a social worker who works together with professional persons, CEOs, and executives to grow their professional and personal brands. He has six years of experience in both working in social work and brand marketing for expensive brands and organizations.
He also worked for new start-up organizations and businesses, have afforded Patrick the knowledge of what drives sold-out launches, and conversions. But what makes Patrick successful in his work areas isn’t the mastery of marketing flavors or community projects, but how well he can make a connection with the general public, he tries to help.
Patrick Kumi graduated from Uganda Christian University with a bachelor’s degree in social work and social science, he also holds a diploma in business administration from the Institute of Accountants and Commerce and a certificate in digital marketing. I have more than 5 years of experience in online marketing, specializing in extensive sales training or enablement, project leadership, Organizational development, and digital marketing among others. As a Brand and Online Marketing Strategist, Patrick is capable of identifying and developing Websites and graphics design projects, his experience extends to programming and launching an internal blog for E-Communications. These featured product articles and alerts cover SEO, SEM, eCommerce, mobile, social media marketing, and display advertising.

https://lead.asknet.community/profiles/Patrick-Kumi/

@dutkulang @timmwille

This profile has been shortened to improve readability and precision. @timmwille and @dutkulang, kindly my proposed edits on HedgeDoc.

profile bio has been updated


Is there a way to silence logging?

About this issue
When this plugin's prepareLibraryDefinitions task is run, we see lots of build output like:
> Task :app:prepareLibraryDefinitionsDebug
--> Retrieved POM for: com.atlassian.commonmark:commonmark from com.atlassian.commonmark:commonmark-parent:0.13.0
----> Retrieved POM for: com.atlassian.commonmark:commonmark from com.atlassian.pom:central-pom:5.0.13
------> Retrieved POM for: com.atlassian.commonmark:commonmark from com.atlassian.pom:base-pom:5.0.13
...
...
...

We like to minimize such output as it makes identifying newly-introduced warnings easier.
Is there a way to disable this output? (I scanned docs, but didn't see anything; apologies if I missed something!)
Details
Library version 10.6.2.
Checklist

[x] Searched for similar issues
[x] Checked out the sample application
[x] Read the README
[x] Checked out the CHANGELOG
[x] Read the MIGRATION GUIDE

Actually this looks like a bug as this uses a println statement instead of the LOGGER.info tag it's supposed to:

https://github.com/mikepenz/AboutLibraries/blob/bebaf725623879ab8e2afa36f46fea63c67bdbce/plugin-build/plugin/src/main/kotlin/com/mikepenz/aboutlibraries/plugin/util/PomLoader.kt#L42

Would that solve the need? (E.g. have INFO log level for that item)

(Also to answer the pure question, there is no setting or option to fully turn off logs at this time)

Ah, yes, I suspect that using the logger and marking this output as informational would be perfect; I'm pretty sure we only log statements that are warnings or more severe!

Thank you for the quick response!


Support multiple natively-routed CIDRs in ENI mode

This is a draft PR for discussion only.

This isn't quite right. Will open a replacement.


examples for react

Hello!
Could you please add some examples with react?
I understand you are using this package for ssr server.
Perhaps you could share the minimum configuration for this purpose? Were there any problems with integration?
I would like to use this library in conjunction with babel register.

babel-register is a nonstarter because that is CommonJS. You don't need it though because TypeScript can transpile JSX to JS. You want a loader and not a registration hook (the old way of doing things). We use https://github.com/braidnetworks/loaderkit/tree/main/packages/ts. There is a more popular package here: https://github.com/privatenumber/tsx/blob/7c47074652790e8225bb9c0d3123fc92e75d3695/docs/dev-api/node-cli.md. We use a custom loader for consistent values of import.meta.url [https://github.com/privatenumber/tsx/issues/448].
React is tough because it is a client/server interdisciplinary project. Getting SSR working is easy enough but showing how to combine the client & server requires at least Webpack or Vite. It would be a very complicated "minimal" example.

Thanks for the reply! I will check out your links.
As for babel-register - I've already sorted it out, it really doesn't fit. (maybe in the future when they add esm support).
The main problem I am facing is the inability to read css modules files. And most likely the same problem will occur for other files, such as pictures. + alias paths.

Yup, these would all be loaders. The problem with a simple example is that you end up needing to build an entire framework. We've actually built the framework for our site but it contains some custom behavior that would need to be generalized before open sourcing. I would definitely like to do that work eventually since I think the loader feature in nodejs is really cool and powerful.
Each loader is 100-200 lines of code, it's nothing too complicated--
The CSS loader uses postcss and dispatches the same plugins that we have configured in Webpack. The main thing is that we use exported CSS class names which allows compression on CSS classnames (ex: .component-name becomes .xyz).
For the file loader it starts a local HTTP service which hosts the files and then forwards those URLs to both the SSR pipeline and the client Webpack bundle.

Sounds very interesting! Perhaps you could share the code for these loaders? I would be very grateful :) I haven't had to write them myself yet, but I think I could figure it out and adapt the code to my needs. Thank you.


Modify: Google.Chrome.Beta version 127.0.6533.26

Checklist for Pull Requests

[X] Have you signed the Contributor License Agreement?
[ ] Is there a linked Issue?

Manifests

[X] Have you checked that there aren't other open pull requests for the same manifest update/change?

[X] Does your manifest conform to the 1.6 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Adds arm64 architecture

Microsoft Reviewers: Open in CodeFlow

/azp run

@stephengillie anything I can do on my end to get this to pass?

/azp run

/azp run

Hi @aisgbnok,
This manifest adds Apps and Features entries that aren't present in previous PR versions. These entries should be added to the previous versions, or removed from this version.
(Automated response - build 886.)


feat(Data/Sign): some more API for SignType

Since Real.sign etc are being deprecated in favour of the generic SignType.sign, this PR adds some more API for the latter: in particular, compatibility of the canonical maps in and out of SignType with maps satisfying suitable assumptions. This is a prerequisite for #10011.

maintainer merge


[Bug]: TDS Stream crash when selecting a N/VARCHAR(MAX) variable

Contact Details
<EMAIL_ADDRESS>What happened?
Receiving a "SQL Error [08S01]: The TDS protocol stream is not valid." on the following code
DECLARE @variable VARCHAR(max) = '';
set @variable = 'a'
select @variable

Expected result:
@variable
a

Version
BABEL_1_X_DEV (Default)
Extension
babelfishpg_tsql (Default)
What flavour of Linux are you running into the bug?
Ubuntu (Default)
Relevant log output
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

Executing the above code block twice this from a tsql client, I get the following error:
~ tsql -S ${BBF_IP} -p 1433 -U bbf -v master
Password:
locale is "en_US.UTF-8"
locale charset is "UTF-8"
using default charset "UTF-8"
Changed database context to 'master'.
1> DECLARE @variable VARCHAR(max) = '';
2> set @variable = 'a'
3> select @variable
4> GO
@variable
(0 rows affected)
1> DECLARE @variable VARCHAR(max) = '';
2> set @variable = 'a'
3> select @variable
4> GO
Error 20006 (severity 9):
        Write to the server failed
tds_submit_query() failed

Also, all executed commands after the error, even after attempting to use master to reconnect -- but this, could be specific to the tsql client.

When executing this code with 'sqlcmd' , it works correctly.

@3manuek or @gutosantos82, can you try this with sqlcmd instead of tsql (which we currently don't formally support...)


Gift sats:UI issue

Wallet name should be on same line.In case of large wallet name it appears on second line.

Verified this issue on dev app v2.0.71(451)


added ANSI Escape Sequence Injection

ANSI Escape Sequence Injection is a topic that hasnt been researched much on. I'd like to add this to PayloadsAllTheThings so that we can have a small knowledge base on this topic

@sdushantha : did you deliberately remove your branch with the commit?

@drwetter I deleted my fork withing thinking that it would close this PR as the branch would be deleted. I'll recreate it, thank you for notifying me!

I'm not able to reopen this PR even though my new fork as the same branch. So I'll create a new PR. Sorry for inconvenience


Fix spacing to enable old workflows

Description
[Describe what this change achieves]
Category
[Enhancement, New feature, Bug fix, Test fix, Refactoring, Maintenance, Documentation]
Why these changes are required?
What is the old behavior before changes and new behavior after changes?
Issues Resolved
[List any issues this PR will resolve (Is this a backport? If so, please add backport PR # and/or commits #)]
Testing
[Please provide details of testing done: unit testing, integration testing and manual testing]
Check List

[ ] New functionality includes testing
[ ] New functionality has been documented
[ ] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@derek-ho Please update the description on this pull request

Closing in favor of: https://github.com/opensearch-project/security-dashboards-plugin/pull/1728


Refactor on JavaScript code

Changes:

Create new widget named LanguageSwitcher to reduce repeating HTML tag on Nav.vue
Reduce repeating code to switch language on Nav.vue
Reduce repeating code to open modals on apply.vue
Remove console.log on home.vue

@sendz
Thanks for your contribution 👍


Remove postgres specific database collection information from diagnostics

Updated lakefs diagnostics to work with kv.
Removed all specific postgres database related information collection.
Close #3575

Thanks @N-o-Z for the review - updated the with single initialization code block for the auth service. Let me know if this makes the code cleaner and easy to read.


BucketNotFoundException: 404 gs://bert-nq bucket does not exist. while downloading Bert Joint model

Hi there
I am tyring to download Bert Joint pre-trained model following instructions on -
https://github.com/google-research/language/tree/master/language/question_answering/bert_joint
specifically - while running gsutil cp -R gs://bert-nq/bert-joint-baseline ., I get the following error
BucketNotFoundException: 404 gs://bert-nq bucket does not exist.
Could you kindly update the download instructions or correct me incase I am making a mistake.

Hello. Check https://www.kaggle.com/philculliton/bertjointbaseline/version/1. Maybe I'm too late.


[Feature request] Case insensitive search for Cyrillic words

Firstly, I want to thank you for the project, this is exactly what I have been looking for for years.
I'm missing only two features, the first one is already requested (list of tags), the second one is a case insensitive search for Cyrillic words like it works for Latin.
The search works fine for Катеринівка:

but fail with катеринівка:

The same with tags. Works with Сергей:

and don't with сергей:

UPD: Unfortunately the issue related to sqlite. This solution looks like a good workaround for all non-latin languages.

Switch to MariaDB solves the issue.


[GDExtension] Fix _property_can_revert and _property_get_revert methods using incorrect string type.

GDExtension method signatures use StringName instead of String (which is also consistent with other similar methods).

Would be good to also check if this is indeed StringNames which are passed predominantly to this method, or Strings that would now be converted to StringName at a performance cost.

Would be good to also check if this is indeed StringNames which are passed predominantly to this method, or Strings that would now be converted to StringName at a performance cost.

It's mostly called for editor inspector, which pass StringName, only documentation generation seems to use it with String.

Thanks!


Add SPM support

Added Swift Package Manager Support
Since there are already tagged build versions, nothing more is needed.

Let's make sure we cover the Installation section for the SwiftPM


Issue 1671 clear Go Report card issues/warnings in membersrvc

Minor gofmt issues and not using a returned err value from StopServer() in one of the tests.
Description
Ran gofmt -s -w on the "offending" files + calling t.Logf() + t.Fail() on  error.
Motivation and Context

Fixes #1671
How Has This Been Tested?

Checklist:

[x] I have added a Signed-off-by
[x] Either no new documentation is required by this change, OR I added new documentation
[x] Either no new tests are required by this change, OR I added new tests
[x] I have run goimports, go vet, and golint. I have cleaned up all valid errors and warnings in code I have added or modified. These tools may generate false positives.  The goal is clean, consistent, and readable code.

Signed-off-by: JonathanLevi

LGTM. Thanks!


Having trouble installing via pip (python 2.7). No module keyboard/ PIL

Hi,
When trying to install lackey via pip, I was getting an error that said something along the lines of no module named keyboard. I managed to fix this error by 'pip install keyboard.' However, I ran into another error, soon after; 'no module named PIL'
I tried 'PIP install PIL' but am running into the following error:
Could not find a version that satisfied the requirement PIL...no matching distribution found for PIL.
Any ideas what I'm doing wrong? Thanks.

It's not you, it's me.
While trying to streamline versioning I accidentally broke the pip install if the requirements aren't already installed. I've created a hotfix that should fix this. Pushing it out shortly.

I've pushed the new version to Pypi, but I'm having some weird issues on my end. It keeps trying to install version 0.5.0 unless I explicitly tell it pip install --upgrade lackey, in which case it downloads and installs 0.5.1.
Can you try it and see if it does the same thing for you?

Hi, what exactly would you like me to try out?  You want me to try to install lackey once again?

Yes. Try it with pip install lackey first, and see if it correctly installs version 0.5.1.
If that doesn't work, try pip install --upgrade lackey.
It might just have been Pypi updating slowly.

It seems to have installed 0.5.1 but I'm now getting the following error when I try to import lackey:
  File "<pyshell#0>", line 1, in <module>
    import lackey
  File "C:\Python27\lib\site-packages\lackey\__init__.py", line 18, in <module>
    from .PlatformManagerWindows import PlatformManagerWindows
  File "C:\Python27\lib\site-packages\lackey\PlatformManagerWindows.py", line 16, in <module>
    from .Settings import Debug
  File "C:\Python27\lib\site-packages\lackey\Settings.py", line 126, in <module>
    class SettingsMaster(object):
  File "C:\Python27\lib\site-packages\lackey\Settings.py", line 159, in SettingsMaster
    BundlePath = os.path.dirname(os.path.abspath(os.path.join(os.getcwd(), __main__.__file__)))
AttributeError: 'module' object has no attribute '__file__'```

This seems to be a separate issue, affecting the Python console specifically. Lackey imports in scripts properly.

It seems I got the error when I was writing code directly through shell. By creating a file via Idle and saving it, the error disappeared.

Tracking this in a new issue, #42. Closing this task as the original problem has been fixed.


Add a SQL Authentication Method for AzureCli credential

In integration tests we don't want to use the ActiveDirectoryDefault as the whole token chain is being processed.
To improve the speed of integration tests that use Azure CLI to authenticate we would like to add an Authentication method purely for AzureCLI.

@dotnet-policy-service agree

Thanks for the submission.
We've been trying to resist adding public APIs (and connection string settings would be considered public API) that contain "Azure" in them.
Can you not use the new AccessTokenCallback property (#1260)? Or create a custom SqlAuthenticationProvider to accomplish what you want?
Note: A SqlAuthenticationProvider can be a DLL that is configured to be used via another app's config like in SSMS:
<?xml version="1.0" encoding="utf-8"?>
<configuration>
    <configSections>
        <section name="SqlClientAuthenticationProviders"
            type="Microsoft.Data.SqlClient.SqlClientAuthenticationProviderConfigurationSection,Microsoft.Data.SqlClient, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=23ec7fc2d6eaa4a5"/>
    </configSections>

    <SqlClientAuthenticationProviders applicationClientId="a94f9c62-97fe-4d19-b06d-472bed8d2bcf">
      <providers>
         <add name="active directory interactive"
           type="Microsoft.SqlServer.Management.UI.AadInteractiveAuthProvider.AadAuthenticationProvider, ConnectionDlg.AadInteractiveAuthProvider"/>
      </providers>
    </SqlClientAuthenticationProviders>
</configuration>

Hi David,
We feel like like all of the Azure.Identity authentication methods should be more easily supported.
As Identity is clearly the way forward in a passwordless future.
eg:
TokenCredential tokenCredential  = //any of the Azure.Identity token credentials
var connectionString = new ConnectionStringBuilder.AddIdentity(tokenCredential).ToString()

But this would introduce more changes, that's why I added an extra authentication method. Since there are already issues complaining about the DefaultTokenCredential speed, because of chaining see: https://github.com/dotnet/SqlClient/issues/2072
This drastically reduces the time of our integration tests. (From 5m to 30s)
If you have 50+ projects you don't want to configure or write AccessTokenCallback for each project, which is custom code = introduces more risk.
We expect this out of the box, as these are both Microsoft projects and SqlClient is atm not aligned with the default way of working with identity in Azure.

@David-Engel the problem is even worse if you use powershell and Invoke-SqlCmd.
Since it's not able to handle parallel processing of the token and you receive: Azure CLI authentication timed out.
You can work around this by providing an -AccessToken to Invoke-SqlCmd. But this are all sub optimal solutions.
If we want to improve global security, these kind of hassles make it very hard for developers that are starting out.
Honestly It should be easier to connect with managed identity then with sql authentication.

This can be done directly by implementing AccessTokenCallback.
Closing the PR as we don't intend to support this new API as of now.


Bug: Ayon Maya Review Creation - Profile key Error - 3.15.6-nightly.1 next-minor

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior:
Doesn't create a Review subset
Expected Behavior:
Create a review subset node
Version
3.15.6-nightly.1
What platform you are running OpenPype on?
Windows
Steps To Reproduce:
From Ayon menu in Maya

Create...
Select review
Create button
Error dialog

Are there any labels you wish to add?

[X] I have added the relevant labels to the bug report.

Relevant log output:
Failed to create Subset: "reviewMain" Family: "review" in Asset: "chr"

Error: 'profiles'

Traceback (most recent call last):
  File "E:\ayon\OpenPype-release-next-minor\build\exe.win-amd64-3.9\openpype\tools\creator\window.py", line 431, in _on_create
    legacy_create(
  File "E:\ayon\OpenPype-release-next-minor\build\exe.win-amd64-3.9\openpype\pipeline\create\legacy_create.py", line 197, in legacy_create
    plugin = Creator(name, asset, options, data)
  File "E:\ayon\OpenPype-release-next-minor\build\exe.win-amd64-3.9\openpype\hosts\maya\plugins\create\create_review.py", line 44, in __init__
    preset = lib.get_capture_preset(
  File "E:\ayon\OpenPype-release-next-minor\build\exe.win-amd64-3.9\openpype\hosts\maya\api\lib.py", line 3931, in get_capture_preset
    if plugin_settings["profiles"]:
KeyError: 'profiles'

Additional context:
release-next-minor
Maya 2023.2
Windows 11
[cuID:OP-5887]

just tested in 3.17.5-nightly.2 and it seems it's working. Fixed by #4975


useLazyFetch works in Development but not Production

Environment
Production:

Operating System: Windows_NT
Node Version:     v20.11.1
Nuxt Version:     -
CLI Version:      3.10.1
Nitro Version:    -
Package Manager:  unknown
Builder:          -
User Config:      -
Runtime Modules:  -
Build Modules:    -

Develoment:

Operating System: Windows_NT
Node Version:     v20.11.1
Nuxt Version:     3.10.3
CLI Version:      3.10.1
Nitro Version:    2.9.3
Package Manager<EMAIL_ADDRESS>Builder:          -
User Config:      devtools, app, nitro, experimental, srcDir, components, modules, css, vite, build,
runtimeConfig
Runtime Modules<EMAIL_ADDRESS>Build Modules:    -

Reproduction
https://doctorjs.ir/article/fastApi-websocket-send-recieve-file
Describe the bug
i dont know why after some years, yet there are problems on fetch data on nuxt...
why working on development is different with production...
Additional context
No response
Logs
No response

Based on your description, it is almost certainly an issue with your production API endpoint differing in some way from your development API endpoint.

in nuxt config define something like this:
   runtimeConfig: {
        SOME_SECRET_KEY: process.env.SOME_SECRET_KEY,
        public: {
          API_URL: process.env.NODE_ENV === 'development' ? 'http://<IP_ADDRESS>:9300/api' : 'https://doctorjs.ir/api',
        },
      },

@RezaErfani67 This will not work as your runtimeConfig is not set up correctly. See https://www.youtube.com/watch?v=_FYV5WfiWvs

i compeltely removed runtimeConfig and use fetch...
here is resullt...

<script setup>

async function myfetch1(url, options, emits) {
  const { data, pending, error, refresh } = await useFetch(url, {
    key: hash(["api-fetch", url, options]),
    baseURL: "https://doctorjs.ir/api",
    initialCache: false,
    headers: new Headers({
      authorization: process.client ? localStorage.getItem("token") : "",
    }),
    ...options,
    onResponse({ response }) {
      return response._data;
    },
    onResponseError({ response }) {
      return response._data;
    },
  });
  const resData = data.value;
  const resPending = pending.value;
  const resError = error.value;
  return resData;
}

let response = await myfetch1("/article/artPost/view/" + props.enTitle, {
  method: "GET",
});
form.title = response.data.title;
form.enTitle = response.data.enTitle;
form.abstract = response.data.abstract;
form.description = response.data.description;
form.createdAt = response.data.createdAt;
form.cover = response.data.cover;
useHead({
  title: (title) => `${form.title}`,
  link: [
    {
      rel: "canonical",
      href: "/article/" + props.enTitle,
    },
  ],

  meta: [
    { name: "description", content: form.abstract },
    { name: "article:published_time", content: form.createdAt },
    { name: "twitter:card", content: form.abstract },
    { hid: "og:type", property: "og:type", content: "article" },
    { hid: "og:url", property: "og:url", content: "/article/" + props.enTitle },
    { hid: "og:brand", property: "og:brand", content: uuu().public.BRAND },
    {
      hid: "og:site_name",
      property: "og:site_name",
      content: uuu().public.SITE_NAME,
    },
    { hid: "og:locale", property: "og:locale", content: "fa" },
    {
      hid: "twitter-url",
      name: "twitter:url",
      content: "/article/" + props.enTitle,
    },

    { hid: "og:title", property: "og:title", content: form.title },
    { hid: "twitter:title", name: "twitter:title", content: form.title },

    {
      hid: "og:description",
      property: "og:description",
      content: form.abstract,
    },
    {
      hid: "twitter:description",
      name: "twitter:description",
      content: form.abstract,
    },

    {
      hid: "og:image",
      property: "og:image",
      content: "/api" + form.cover?.replace(/\\/g, "/"),
    },
    {
      hid: "twitter:image",
      property: "twitter:image",
      content: "/api" + form.cover?.replace(/\\/g, "/"),
    },

    { property: "og:site_name", content: uuu().public.TITLE },
    { name: "twitter:site", content: uuu().public.TITLE },
  ],
});

</script>

@RezaErfani67 can you provide a standalone reproduction? Most likely a userland problem
Also, why setting resData etc. manually and not just returning useFetch as is, then destructure from there?

aha...
i added console.log() to above code and see this error:
unable to verfy the first certificate...

after about one week , solved problem...
i changed  my certificate  and it produce this error because self sign ...
it should run with this command:
NODE_TLS_REJECT_UNAUTHORIZED='0' node index.mjs

Isn't the issue above that you are using useFetch within a function and therefore the best practice should be to use $fetch instead as you are creating a js function?

@svenvreenen
base on this stack  i'm using $fetch when i want post data to server

@RezaErfani67  In Nuxt 3, the useFetch function is typically used directly inside the setup function or in a composable function. so from the docs we can see this: https://nuxt.com/docs/api/composables/use-fetch.
if you try something like this, does it solve your issue?
const props = defineProps({
  enTitle: {
    type: String,
    required: true,
  },
});

const { data: response, pending, error, refresh } = await useFetch(`/article/artPost/view/${props.enTitle}`, {
  method: "GET",
  baseURL: "https://doctorjs.ir/api",
  initialCache: false,
  headers: new Headers({
    authorization: process.client ? localStorage.getItem("token") : "",
  }),
  onResponse({ response }) {
    return response._data;
  },
  onResponseError({ response }) {
    return response._data;
  },
});`````


Version 2: Fixing do_action due to deprecated endpoints on incident.

incidents/{id}/{verb} has been deprecated with v2 of the PagerDuty API. Now it requires a PUT request to incidents/{id} with data detailing the verb (acknowledge,resolve, escalate, etc).
Added a test to check that this works.

Sorry for the delay here. This has been released in pygerduty-0.36.2


[Feature-docker][ui] Update dolphinscheduler.conf

/ui下的资源访问不应该发送到api-server
Tips

Thanks very much for contributing to Apache DolphinScheduler.
Please review https://dolphinscheduler.apache.org/en-us/community/index.html before opening a pull request.

What is the purpose of the pull request
(For example: This pull request adds checkstyle plugin.)
Brief change log
(for example:)

Add maven-checkstyle-plugin to root pom.xml

Verify this pull request
(Please pick either of the following options)
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)

Added dolphinscheduler-dao tests for end-to-end.
Added CronUtilsTest to verify the change.
Manually verified the change by testing locally.

@shi-hailong Please resolve Unit Test failed

@shi-hailong Please resolve Unit Test failed

UT MODULE  gc problem,Refer to this solution #3264，Comment out those GC problem tests

@shi-hailong Please resolve Unit Test failed

this is not his problem,he just change nginx config

thanks for your first contribution, looking forward to your next contribution, if you need any help, please send mail to<EMAIL_ADDRESS>or contact my wechat(510570367), when added, please tell me your github id, thx


Update cellery setup create inline command

Added flag "--force-download" to cellery setup create local to download vm image regardless it is already downloaded.

Codecov Report

Merging #603 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #603   +/-   ##
=======================================
  Coverage   64.63%   64.63%
=======================================
  Files          34       34
  Lines        1179     1179
  Branches       98       98
=======================================
  Hits          762      762
  Misses        363      363
  Partials       54       54

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b27483...a9e21d6. Read the comment docs.


CASMINST-4176 retry skew check three times to reduce false positives

Signed-off-by: Jacob Salmela<EMAIL_ADDRESS>Summary and Scope
Wraps the existing check in a loop that tries three times.
Issues and Related PRs

Resolves CASMINST-4176

Testing

redbull
fanta

Test description:
ncn-m001:~/jsalmela # ./!$
./test
Checking clock skew...attempt 1 of 3...
Epoch seconds by node (allowing 1 seconds of drift):
ncn-s001:<PHONE_NUMBER>
ncn-s002:<PHONE_NUMBER>
ncn-s003:<PHONE_NUMBER>
ncn-s004:<PHONE_NUMBER>
ncn-m001:<PHONE_NUMBER>
ncn-m002:<PHONE_NUMBER>
ncn-m003:<PHONE_NUMBER>
ncn-w001:<PHONE_NUMBER>
ncn-w002:<PHONE_NUMBER>
ncn-w004:<PHONE_NUMBER>
ncn-w003:<PHONE_NUMBER>

Checking clock skew...attempt 2 of 3...
Epoch seconds by node (allowing 1 seconds of drift):
ncn-s001:<PHONE_NUMBER>
ncn-s003:<PHONE_NUMBER>
ncn-s002:<PHONE_NUMBER>
ncn-s004:<PHONE_NUMBER>
ncn-m001:<PHONE_NUMBER>
ncn-m002:<PHONE_NUMBER>
ncn-m003:<PHONE_NUMBER>
ncn-w001:<PHONE_NUMBER>
ncn-w002:<PHONE_NUMBER>
ncn-w004:<PHONE_NUMBER>
ncn-w003:<PHONE_NUMBER>

Checking clock skew...attempt 3 of 3...
Epoch seconds by node (allowing 1 seconds of drift):
ncn-s002:<PHONE_NUMBER>
ncn-s001:<PHONE_NUMBER>
ncn-s003:<PHONE_NUMBER>
ncn-s004:<PHONE_NUMBER>
ncn-m001:<PHONE_NUMBER>
ncn-m002:<PHONE_NUMBER>
ncn-m003:<PHONE_NUMBER>
ncn-w001:<PHONE_NUMBER>
ncn-w002:<PHONE_NUMBER>
ncn-w004:<PHONE_NUMBER>
ncn-w003:<PHONE_NUMBER>

ncn-m001:~/jsalmela # echo $?
0
ncn-m001:~/jsalmela #

Risks and Mitigations
Low.  This just loops existing code three times with a small delay.
Pull Request Checklist

[ ] Version number(s) incremented, if applicable
[ ] Copyrights updated
[ ] License file intact
[ ] Target branch correct
[ ] CHANGELOG.md updated
[ ] Testing is appropriate and complete, if applicable
[ ] HPC Product Announcement prepared, if applicable

wrong branch.  See https://github.com/Cray-HPE/csm-testing/pull/228


:tada::one::one: pos_wechat_miniprogram continue

commits from https://github.com/it-projects-llc/addons-dev/commits/pos-addons-11.0-pos_wechat_miniprogram

I approve to merge it now


[CLOSED] Added booter support, NullBooter and NetBooter

 Issue by insomniacslk
Tuesday May 15, 2018 at 13:31 GMT
Originally opened as https://github.com/insomniacslk/systemboot/pull/15

Added pkg/booter and updated uinit to use it.
pkg/booter defines a Booter interface that allows the creation of booting logic, e.g. network booting, local booting, and specific configuration.
A NullBooter and a NetBooter object have been included.
The booters follow a specification based on JSON, and the current implementation stores the content on VPD variables, but any key-value store can be used.

insomniacslk included the following code: https://github.com/insomniacslk/systemboot/pull/15/commits

 Comment by insomniacslk
Tuesday May 15, 2018 at 13:32 GMT

Things to fix before reviewing:

fixing linter warnings
adding unit tests

 Comment by insomniacslk
Tuesday May 15, 2018 at 18:29 GMT

odd test failure. Only fails with go 1.10 and master, but doesn't fail with the same go version on my machine, and the output looks just ok, except that the exit code is 2.

 Comment by zaolin
Tuesday May 15, 2018 at 20:20 GMT

What about the localboot / netboot stuff ?

 Comment by insomniacslk
Tuesday May 15, 2018 at 20:59 GMT

What do you mean?


why need to remove underline in tablename

I have a sql server database,many  tables  named like "by_xxx_yyy";
when using  "Dapper.FastCrud.ModelGenerator",it changed the table name from "by_xxx_yyy" to "byxxxyyy".
I read the t4 temple which  include the code below.is it OK to comment them?
 tbl.CleanName = tbl.CleanName.Replace("_",""); tbl.ClassName=Singularize(RemoveTablePrefixes(tbl.CleanName));

Sorry for the late reply. The reason why we're cleaning up class names is to keep them in line with the C# naming conventions. But you are free to change that template in any way you want.


Custom value objects

Hello, i'm trying to use this library with custom value objects but it seems like it does not work as expected.
For example:
public class UserId
{
    public UserId(string value) => Value = value;
    public string Value { get; set; }
}

public class User
{
    public UserId Id { get; set; }
    public string Email { get; set; }
    public DateTime RegisteredAt { get; set; }
}

public class UserEntityTypeConfiguration : IEntityTypeConfiguration<User>
{
    public void Configure(EntityTypeBuilder<User> builder)
    {
        builder.HasKey(x => x.Id);
        builder.Property(x => x.Id)
            .ValueGeneratedNever()
            .HasConversion(i => i.Value, i => new UserId(i));
        builder.Property(x => x.Email);
        builder.Property(x => x.RegisteredAt);
    }
}

var keysetBuilderAction = (KeysetPaginationBuilder<User> b) =>
{
    b.Ascending(x => x.CreatedAt).Ascending(x => x.Id);
};

var queryable = context.Users.AsQueryable();

var reference = await context.Users.FirstOrDefaultAsync(x => x.Id == new UserId(query.After));
var keysetContext = queryable.KeysetPaginate(keysetBuilderAction, KeysetPaginationDirection.Backward, reference);

It throws an exception:
The binary operator GreaterThan is not defined for the types 'App.ValueObjects.UserId'
Is there anyway to use UserId.Value for comparison?

Hello. With the way you're defining the keyset above, it would be the same as trying to write .Where(x => x.Id > ...) yourself, which of course is not defined for your custom UserId type. So it makes sense that this is not supported.
However, you can try just adding the .Value in the keyset definition itself, just as you would have written .Where(x => x.Id.Value > ...):
b.Ascending(x => x.CreatedAt).Ascending(x => x.Id.Value);

I've tried this one before also. It throws different error:
The LINQ expression 'DbSet<User>()
    .OrderByDescending(p => p.RegisteredAt)
    .ThenByDescending(p => p.Id.Value)' could not be translated. Either rewrite the query in a form that can be translated, or switch to client evaluation explicitly by inserting a call to 'AsEnumerable', 'AsAsyncEnumerable', 'ToList', or 'ToListAsync'. See https://go.microsoft.com/fwlink/?linkid=2101038 for more information.

The generated expression looks fine. This is EFCore itself having trouble translating this. I don't usually use custom types for ids like this so I can't tell you why. This problem is not from this library, you'll have to figure out why EFCore is failing to translate Id.Value.
To confirm, try writing a normal offset query yourself using this same ordering, and see if that gives you the same error or not.

So, i've written queries without using this library and here are the results.
var x = await dbContext.Users
        .OrderByDescending(p => p.RegisteredAt)
        .ThenByDescending(p => p.Id.Value)
        .ToListAsync();

This one results in the LINQ expression exception. The same one as in my previous comment.
var x = await dbContext.Users
        .OrderByDescending(p => p.RegisteredAt)
        .ThenByDescending(p => p.Id)
        .ToListAsync();

This one works as expected and properly applies sorting.
So it seems like EFCore properly utilizes value converters and converts value object into string.

I see. The thing is, a keyset query will include both an ordering expression as above, but will also include generated conditional expressions (mainly comparison and equality), like p.Id.Value > "the reference value". Even if I allowed the ordering to work, this second conditional expression will give you a compilation error if you write it by hand (as again, this library only generates these which you could have written by hand).
First step here is to find a way to make the hand written manual expression work in your case (in particular, the comparisons on the prop), and then I could think if it can be supported in this library. It might for example invovle implementing the comparison and equality operators on your custom type. Even if you do this though, I can't promise I can support the use case in this library, will have to see how that will look like.

I'm closing this for now as I can't think of a way this can work in a keyset query as mentioned above. If you come up with a hand written keyset query that works with your case feel free to open this issue again and I'll have another look.


[Dev] Improve the link script to avoid extra comment

Describe the enhancement requested
Currently the link script used a dedicated comment to track that the link script had already run for that PR
https://github.com/apache/arrow/blob/master/.github/workflows/dev_pr/link.js#L86-L96
This is suboptimal because it leads to an extra comment, we could inspect the PR body/description itself for the "Closes: X" message instead of inspecting a comment.
Component(s)
Developer Tools

For reference here are the docs with all available keywords: https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword
close
closes
closed
fix
fixes
fixed
resolve
resolves
resolved

@assignUser I don't think we have to check for all those? We explicitly want to check for the addition of the bot, which will always be * Closes: #xxx. Because I assume we still want to run the bot (since this also checks for other things) even if the user who opened the PR wrote a "fixes #.." in the top post.

Ah I see, makes sense. I thought we would also check if the user has already added the keyword but I guess that's not really necessary as doubling the keyword doesn't have any negative consequences

I never checked, but would issue_url or _links.issue be a good guard in this case? Given that when you add the "Closes: X" text GitHub links the PR to the ISsue, maybe we can simply check the value of those instead of having to parse the body.

Let me check the api docs, I know that there is no endpoint to link the issue but maybe that info is in the issue/pr object

There is no "linked_pr|issue" field or something in the issue object and there also is no endpoint to link issues and prs... seems to be handled in some hidden way in the backend?

Also, if we would check for "issue linked" through github APIs, we would still need to check that the issue number is correct and matching with the title (because you can easily type something like "this might also fix#xxx" or "this does not fix #xxx" in your top post, which creates such a link on github unintentionally).

There is no "linked_pr|issue" field or something in the issue object and there also is no endpoint to link issues and prs... seems to be handled in some hidden way in the backend?

The PullRequest object has a issue_url and _links.issue don't those point to the linked issue?


get.docker.com fails on Debian 8 unprivileged

Description
Installing docker-engine via curl -fsSL https://get.docker.com/ | sh fails when run from a nonprivileged user.
ERROR: This command can only be used by root.
Steps to reproduce the issue:

have a fresh Debian 8
switch to a nonprivileged - but sudo enabled user ("debian" from openstack)
run curl -fsSL https://get.docker.com/ | sh

Describe the results you received:
ERROR: This command can only be used by root.
from echo "$docker_key" | apt-key add - in
Describe the results you expected:
should use sudo call as needed and succeed.
Additional information you deem important (e.g. issue happens only occasionally):
error exists since: https://get.docker.com/
Last-Modified:Wed, 05 Apr 2017 23:50:48 GMT
Output of docker version:
unable to install

Output of docker info:
unable to install

Additional environment details (AWS, VirtualBox, physical, etc.):
Openstack spawned via docker-machine (0.10)

I'm seeing the same problem on ubuntu as well.

Same issue here, Ubuntu 16.04.  Totally killed my planned evening to learn Docker. :(

@jordonbaade the recommended installation path is the manual procedure, as explained in https://docs.docker.com/engine/installation/linux/ubuntu/. The install.sh script is only to get you "going fast".

Why is this issue closed despite unresolved?
Is this an official feedback that get.docker.com is not going to be officially supported going forward?

I would expect there to be auto-tests. This script is a go-to point for many.

Could this be re-opened until the fix is deployed to https://get.docker.com/ ?
docker-machine (0.8.2, build e18a919, not sure about later) currently fails to provision ubuntu (and likely other) instances.

We close issues when a fix is merged.

I would expect there to be auto-tests. This script is a go-to point for majority.

There are automated tests in place; I'm not sure why this issue was not picked up by those; possibly they're executed as root on the test-boxes, but I cannot tell for sure

Is there a place where such infrastructure issues are tracked then?  Since the issue doesn't quite fit under docker/machine (although this probably should be curl-ing the script).
It appears one has already been created for this particular problem: https://github.com/docker/machine/issues/4051

This also break docker-machine.

Oh, sorry, didn't see your comment; the script was updated on get.docker.com, but may still be in the CDN cache, so it's possible the updated version is not yet available in all locations

Just trying to learn how to use Docker @thaJeztah -- realize there are probably more manual ways to get it taken care of, but I'd expect the official 'quick start' script to not be just completely broken and for our concerns to be brushed off.

Just refreshed the script, additions have been added -- will test docker-machine now.

Works!  Thanks @thaJeztah

great!


UX upgrades for Bounty work

🚀 Feature Request
People landing on the website should be able to see all the open bounties associated with the paper. For now we have the staking bounty, so let's build just for that. People can click on "view open bounty" and they will see Staking. Then they can click on "Participate in the bounty", or something like that: that will send them to edit the paper.md, as you proposed today.
The main version associated with the website and the bounty link will have a section about the bounty with a "quickstart". Staking; requirements, deadline, interesting references...
People can edit and when they are done proposing their thing, they can click "submit", and this will fork our repo, push the edits to the forked repo and open a pull request on the repo.
To Do List

multiple paper in mutliple repository

each paper is associated with one repository

each paper should be associated with views styles [pdf, html, mp4?, mp3?]

each paper should be associated with a token [erc20, native, ...]

a paper can have multiple bouties

a paper can be read/downloaded

someone can propose a change to a paper for (or not) a bounty

a bot will act as the middleman between an user and github (if they want to)

Paper:
Bountry: A goal -modification of a paper- to be achieved in exchange to a reward.
🔈 Motivation
Some of the bounties are about design choices associated with the DAO. It is both more efficient to perform and easier to follow if members of the DAO interact with the bounty only via this repository.

Feeback on current UX. The description of the issue is partially outdates, will not waste time iterating on it, we know what we need. So the current feedback is not based on the initial proposal.

[ ] I would like to reach the desci domain from the main crunchdao page. DeSci button in the landing page of the website once we move everything from staging to https://desci.crunchdao.com/
[ ] The IPFS link with the logo close to the github one
[ ] remove dummy paper
[ ] the cover does not render well
[ ] once you metamask logged in, clicking brings you to etherscan, does not logout.
[ ] pdf rendering, remove second useless bar on the right.
[ ] make a request: show progress bar or something similar when I am waiting. And/or clone in the background.
[ ] check for title missing in proposal before making me sign the metamask message
[ ] remove md render. Gejnerate a pdf on the fly (same docker image, same options), Overleaf style, but with markdown:

[ ] prevent horizontal scrolling in markdown editing

Great work @Caceresenzo. Closing.


Link to API Demo broken

A user reported that the link to the API demo is broken.  Please find the link and remove from OrgBook.

Demo has been migrated to StackBlitz now at https://stackblitz.com/edit/angular-ivy-rjbxsj

@wadeking98 Could you please update the docs to reflect this demo link?


PHP8 support

Please add php8 support.

Do you have any examples of this not working on PHP8?
I'm on 8.0.6 with no problems.

I'm using this on PHP 8.0.7 with no issues

What about 8.1?


Add Java17 to gh-actions

Thank you for opening a pull request and contributing to AsciidoctorJ!
Please take a bit of time giving some details about your pull request:
Kind of change

[ ] Bug fix
[x] New non-breaking feature
[ ] New breaking feature
[ ] Documentation update
[ ] Build improvement

Description
What is the goal of this pull request?
Add support for Java 17.
How does it achieve that?
Adds automated tests and any other build/code related change.
Are there any alternative ways to implement this?
:man_shrugging: we'll see...
Are there any implications of this pull request? Anything a user must know?
Added matrix to Windows build to test Java 11 and 17.
Issue
If this PR fixes an open issue, please add a line of the form:
Fixes #Issue
Release notes
Please add a corresponding entry to the file CHANGELOG.adoc

Seeing the pipeline I wonder why do we have the special Windows setup?

There might be some "CI-commit driven development", I'll mark the PR as draft until ready.

Do you mean why we build on windows at all or why do we have a custom flow for that?
The custom flow is for ./gradlew vs. gradlew.bat.

Thanks for taking this 🙏
I had it on my list for after vacation, so thanks a lot for this PR 🙂🎉🙏

why do we have a custom flow for that?
The custom flow is for ./gradlew vs. gradlew.bat.

For maven we just invoke ".mvnw" and seems to work https://github.com/asciidoctor/asciidoctor-maven-plugin/blob/main/.github/workflows/build.yaml, I can try if we can get rid of the custom tomorrow.


Updates will change items in code fences when identical to other, normal items

While we normally skip task list items embedded in code fences for updates, we rely on code fence items being unique from items outside of code fences. This can result in updates matching items in code fences and updating those instead.
Reproduction:
```
- [ ] identical
```
- identical

No immediate remediation steps known.

This issue was moved to deckar01/task_list#3


chore(MvPowerSeries/Basic): remove superfluous DecidableEq

Found by the linter in #10235.

Thanks! :tada:
bors merge


Api data

Allowing arbitrary datasets by users as children of now implemented abstract class 'data'.
Catalog dataset adult is now a child of abstract data.
Restructuring of data folder for better clarity with new data api.

Nice use of abstract classes! What would be for example another subclass implementation of Data other than DataCatalog?

Thanks :)
It could be every other arbitrary dataset we're not offering in our catalog

Thanks :)
It could be every other arbitrary dataset we're not offering in our catalog

Ah yeah great, so any implementation that doesn't automatically collects the data from the hosted datasets, since the DataCatalog calls load_data() which is only loading data from the repo. Love it!

Thanks :)
It could be every other arbitrary dataset we're not offering in our catalog

Ah yeah great, so any implementation that doesn't automatically collects the data from the hosted datasets, since the DataCatalog calls load_data() which is only loading data from the repo. Love it!

Exactly, an arbitrary dataset from a user can define its own load_data() for a local dataset, for example.
I try to keep this idea for ML - and CF- models.


Broad updates to keys to their latest available versions from keys.openpgp.org

Depends on #5.
In this changeset, I use the following script...
KEY_IDS="$(xargs < keys.list)"

GNUPGHOME=gpg gpg --keyserver keys.openpgp.org --receive-keys ${KEY_IDS}

for KEY_ID in ${KEY_IDS}; do
  if [ -n "${KEY_ID}" ]; then
    GNUPGHOME=gpg gpg --export --armor "${KEY_ID}" > "keys/${KEY_ID}.asc"
  fi
done

...to pull the latest keys from keys.openpgp.org, as of 2021-06-28.
The resulting output is as follows:
gpg: key D3A89613643B6201: "Danielle Adams<EMAIL_ADDRESS>not changed
gpg: key 7D33FF9D0246406D: "Timothy J Fontaine (Personal<EMAIL_ADDRESS>not changed
gpg: key 50A3051F888C628D: "Julien Gilli<EMAIL_ADDRESS>not changed
gpg: key 23EFEFE93C4CFFFE: "Italo A. Casas<EMAIL_ADDRESS>not changed
gpg: key B0A78B0A6C481CF6: "isaacs (http://blog.izs.me/<EMAIL_ADDRESS>not changed
gpg: key 6D5A82AC7E37093B: "Christopher Dickinson<EMAIL_ADDRESS>not changed
gpg: key 97B01419BD92F80A: "Ruy Adorno<EMAIL_ADDRESS>not changed
gpg: key F13993A75599653C: "Shelley Vohr (security is major key<EMAIL_ADDRESS>not changed
gpg: key F07496B3EB3C1762: "Ruben Bridgewater<EMAIL_ADDRESS>not changed
gpg: key C273792F7D83545D: "Rod Vagg<EMAIL_ADDRESS>not changed
gpg: key C43CEC45C17AB93C: "Richard Lau<EMAIL_ADDRESS>1 new user ID
gpg: key C43CEC45C17AB93C: "Richard Lau<EMAIL_ADDRESS>1 new signature
gpg: key E73BC641CC11F4C8: "Myles Borins<EMAIL_ADDRESS>1 new user ID
gpg: key E73BC641CC11F4C8: "Myles Borins<EMAIL_ADDRESS>1 new signature
gpg: key 770F7A9A5AE15600: "Michaël Zasso (Targos<EMAIL_ADDRESS>not changed
gpg: key 09FE44734EB7990E: "Jeremiah Senkpiel<EMAIL_ADDRESS>not changed
gpg: key C97EC7A07EDE3FC1: "keybase.io/jasnell<EMAIL_ADDRESS>not changed
gpg: key B01FBB92821C587A: "Gibson Fahnestock<EMAIL_ADDRESS>not changed
gpg: key B63B535A4C206CA9: "Evan Lucas<EMAIL_ADDRESS>1 new user ID
gpg: key B63B535A4C206CA9: "Evan Lucas<EMAIL_ADDRESS>4 new signatures
gpg: key 92EF661D867B9DFA: "danielleadams<EMAIL_ADDRESS>revocation certificate added
gpg: key 92EF661D867B9DFA: "danielleadams<EMAIL_ADDRESS>1 new signature
gpg: key 7434390BDBE9B9C5: "Colin Ihrig<EMAIL_ADDRESS>not changed
gpg: key D7062848A1AB005C: "Beth Griggs<EMAIL_ADDRESS>1 new user ID
gpg: key D7062848A1AB005C: "Beth Griggs<EMAIL_ADDRESS>8 new signatures
gpg: Total number processed: 20
gpg:              unchanged: 15
gpg:           new user IDs: 4
gpg:         new signatures: 15

I then committed the resulting changes, omitting gpg/pubring.kbx~, which should probably be added to .gitignore.

Each person I've requested to review this PR has a key that has been updated in this changeset. I wasn't able to tag Evan Lucas for review, although there are some changes for Evan as well.

@canterberry, I'm not entirely sure what and how I can verify this - is that the ask here?
I assumed it would be a case of comparing my key in this PR with the ASCII armored output I get locally and from https://keys.openpgp.org/, but they all differ. After that, I tried a comparison with gpg --export --armor <KEY> | gpg --list-packets --verbose, but they also differ for me. I'm not entirely sure if that is because my key is out of sync somewhere or I'm just comparing/validating the wrong things.
Any guidance would be appreciated, i'm a noob at GPG.

@BethGriggs Thanks for taking a look at this so quickly, and I apologize for not being on top of things yesterday and only just now following up.
Here is what keys.openpgp.org has for your key: https://keys.openpgp.org/vks/v1/by-fingerprint/4ED778F539E3634C779C87C6D7062848A1AB005C

If that does not match what you get from running gpg --export --armor 4ED778F539E3634C779C87C6D7062848A1AB005C locally, then could you copy/paste the correct public key in a comment on this MR? Then I'll update this MR with that key and you can review to ensure it is correct.

If that link does match what you expect, but isn't what you see in this PR's changeset, then I may have mucked something up and I'll investigate and fix it right away.

I'm thinking that going forward, if this repo is to be the source of truth for release keys, part of the release team onboarding/offboarding process will involve updating this repo, and I'm happy to help put together scripts/processes to assist in that, as well as easy ways to verify changes or automate some of this.

I've done some research on what is and isn't on keys.openpgp.org, and I'm seeing that is not a reliable source of truth for the current set of release team keys. Thus, a better path forward might be to have a script for a release team member to run to update this repo with any key used for signing prior or future Node.js releases (instead of me hunting for them on an unreliable third party keyserver).

Created #8 to provide a self-service option for release team members to add their own signing keys to this repo.
cc @BethGriggs Assigned you for review of that one, and if it looks good to you, I think I'll close this PR in favor of having you, Richard, et al run the script to update your own keys with the appropriate values.

ping @BethGriggs

Superceded. Closing.


hide menu-icon for PC view and add drop-down in mobile view

On the homepage menu icon is not hidden in PC view. And add  drop-down in the mobile view.

Hide the menu-icon in the PC view
In the mobile view, menu-icon should be visible and Lessons, Sign in, Log in should be in the drop-down.
Make a good looking drop-down and add transition.

@KanjiyaJinesh  Assign this to me.

Assigning to you.

Hey @KanjiyaJinesh I wanna to solve this issue , will u please assign it to me?

still open?

On the homepage menu icon is not hidden in PC view. And add drop-down in the mobile view.

Hide the menu-icon in the PC view
In the mobile view, menu-icon should be visible and Lessons, Sign in, Log in should be in the drop-down.
Make a good looking drop-down and add transition.

Can I work on this?

@Ardent10  yes it is still open. : )
@rockingrohit9639  you can work on this.

@Ardent10 yes it is still open. : ) @rockingrohit9639 you can work on this.

Hey @KanjiyaJinesh is it necessary to create a dropdown, or I can create a side menu for mobile?


config from environment variables

I'd like to run isso from docker and it would be much easier if the config could be passed as environment variables and not as a file on a mapped filesystem.
I could create a PR just for that if you'd accept it.
thanks
Gabor

sorry, I realized its a duplicate of https://github.com/posativ/isso/issues/397


How to just select some filed from input json use state Data Filter ？

What is the question:
inputJson ：
{
"inputkey1": "value1",
"inputkey2": "value2",
"inputkey3": "value3",
"inputkey4": "value4"
}
if I want
outputJson ：
{
"outputkey1": "value1",
"outputkey2": "value2"
}
When two fields inputkey1 and inputkey2 need to be taken from datainputpath JSON data to construct an output JSON, how should dataoutputpath be set ？

@sky132333 filters as they are defined now can just filter the input data based on an jsonpath expression. they do not define atm data manipulation as you are describing atm. However we are looking at supporting this in the future, see Issue https://github.com/serverlessworkflow/specification/issues/149. (@ricardozanini there you go , a good use-case for it :) ).
The issue linked deals with adding JsonPatch support. With this you could do manipulations as what you are describing.
Hope this helps!

@sky132333 I'll draft a document to support RFC 6902 and will ping you to review.

For this use case, assuming this input once #149 is incorporated:
{
    "inputkey1": "value1",
    "inputkey2": "value2",
    "inputkey3": "value",
    "inputkey4": "value4"
}

We could have a function like:
{
   "name":"MyState",
   "type":"inject",
   "stateDataTransform":{
      "dataInputPatch":[
         {
            "op":"move",
            "from":"/inputkey1",
            "path":"/outputkey1"
         },
         {
            "op":"move",
            "from":"/inputkey2",
            "path":"/outputkey2"
         }
      ],
      "dataOutputFilter":"{{ $.outputkey1 $.outputkey2 }}"
   },
   "transition":{
      "nextState":"someNextState"
   }
}

@tsurdilo @sky132333 what do you guys think?

For this use case, assuming this input once #149 is incorporated:
{
    "inputkey1": "value1",
    "inputkey2": "value2",
    "inputkey3": "value",
    "inputkey4": "value4"
}

We could have a function like:
{
   "name":"MyState",
   "type":"inject",
   "stateDataTransform":{
      "dataInputPatch":[
         {
            "op":"move",
            "from":"/inputkey1",
            "path":"/outputkey1"
         },
         {
            "op":"move",
            "from":"/inputkey2",
            "path":"/outputkey2"
         }
      ],
      "dataOutputFilter":"{{ $.outputkey1 $.outputkey2 }}"
   },
   "transition":{
      "nextState":"someNextState"
   }
}

@tsurdilo @sky132333 what do you guys think?

Does only inject state support this?

@sky132333 please follow the comments in the original issue #149 . We are brainstorming around this use case and we should bring up this topic in today's meeting 1pm EST.

This also could be handled by the jq implementation if we decide to go ahead #216

This also could be handled by the jq implementation if we decide to go ahead #216


Boost version compatibility

https://github.com/hazelcast/hazelcast-cpp-client/blob/2de5385101a19a2da0dd24c60341d898fd759288/CMakeLists.txt#L145
the find_package command has find_package(<PackageName> [version] ....) syntax. The referenced Latest bootstrap versions are often not packaged and need custom compilation/install, yet this is silently ignored by the build and later leads to more cryptic compilation issues.
Adding the [version] parameter can clarify this issue.

@onavratil-monetplus I did not understand what you mean in this issue. What exactly is the problem? Currently, without the version it will try find the boost available and will try to work with it. What do you mean by Latest bootstrap versions ?

@onavratil-monetplus We will put back the version. It was there before as 1.72 as the minimum but we need to first explore what is the smallest version we can support given the current code base and put the lowest possible version number, 1.72 is really high for a lot of systems default installations.

I just researched what would be the minimum version we can put considering our code base. I tried versions starting with 1.52 and here are my findings:

Can not be less than 1.65 since boost::atomic_shared_ptr was introduced by this version.
Endian library: endian_load, endian_store came with 1.71. We can do work around solutions (
workaround_load_store_endian.txt) like using boost::endian::endian_load<boost::uint16_t, 2, boost::endian::order::big>(*) but it does not look very good.

Hence, I think that it is best to keep 1.72 as the boost minimum required version in the library.

I just researched what would be the minimum version we can put considering our code base. I tried versions starting with 1.52 and here are my findings:

Can not be less than 1.65 since boost::atomic_shared_ptr was introduced by this version.
Endian library: endian_load, endian_store came with 1.71. We can do work around solutions (
workaround_load_store_endian.txt) like using boost::endian::endian_load<boost::uint16_t, 2, boost::endian::order::big>(*) but it does not look very good.

Hence, I think that it is best to keep 1.72 as the boost minimum required version in the library.

@onavratil-monetplus We merged the PR to fix the minimum required boost version and we also made cmake install available at the current master. Can you check and share your thoughts on how it looks?

@onavratil-monetplus We merged the PR to fix the minimum required boost version and we also made cmake install available at the current master. Can you check and share your thoughts on how it looks?

Closing this issue. If you have any further questions/concerns, please re-open it. Thanks.

Closing this issue. If you have any further questions/concerns, please re-open it. Thanks.


Video Player - Lightbox version QA testing - Production level version

User Story

As a [user role below]:
developer using the ibm.com Library lightbox video player

I need to:
have a version of the pattern or component that has been tested for accessibility compliance as well as on multiple browsers and platforms

so that I can:
be confident that my ibm.com web site users will have a good experience

Additional information

Browser Stack link
Browser Standard
Browser versions to be tested:  Tier 1 browsers will be tested with defects created as Sev 1 or Sev 2.  Tier 2 browser defects will be created as Sev 3 defects.
Platforms to be tested, by priority:  1)  Desktop  2)  Mobile  3)  Tablet
Mobile & Tablet iOS versions: 13.1 and 13.3
Mobile & Tablet Android versions: 9.0 Pie and 8.1 Oreo
Browsers to be tested:  Desktop: Chrome, Firefox, Safari, Edge, Mobile: Chrome, Safari, Samsung Internet, UC Browser, Tablet: Safari, Chrome, Android
Accessibility Checklist
Creating a QA bug
the testing should focus on the lightbox functionality & visual and how it handle the video player
Lightbox visual specs
Video Player Functional specs
The aspect ratio for the video player should always be 16 x 9
The Kaltura video player is being used "as is".

Acceptance criteria

[ ] Accessibility testing is complete.  Pattern is compliant.
[ ] All browser versions are tested
[ ] All operating systems are tested
[ ] All devices are tested
[ ] Defects are recorded and retested when fixed

@Praveen-sr @chetankan This issue has been updated and ready for testing.

@Praveen-sr @chetankan Another example of an issue without status comments.  There should be multiple comments containing the ongoing status until the work is finished.

We have completed functional, design and accessibility testing for this component.


Active button style on mobile devices

After clicking the button will keep active style on mobile devices until some other component is clicked.

Fix is already in but well, not too proud of it, maybe you might know how to solve it correctly with SASS.
If you experience any bugs with the fix please let me know.
Tested the on Android Chrome, Desktop Chrome, Firefox and Edge.


East Feliciana Parish, LA Parcels

http://services1.arcgis.com/fe3XWHMASK948q2c/ArcGIS/rest/services/EastFelParcels/FeatureServer/0

North of Baton Rouge.


In the actor skills menu, display the list of all active bonuses/maluses for each skill

It would also be useful to first list the bodily ones, then equipment ones, then the temporary ones. Perhaps display in different colours, matching how they are displayed elsewhere in UI.

The function to modify is Game.LambdaHack.Client.UI.HandleHelperM.skillsOverlay. Obviously there is no space in the line devoted to a stat for more than one, sometimes two or three bonus names per stat. So, either each, say, temporary organ, should have a single-word abbreviation assigned, plus the numerical value, or only the symbol should be displayed, as displayed in the organs menu (but currently the symbols are not unique).
It's a bit misleading, that even organs that decrease a stat have the + sign and that detrimental organs have the same symbol (though different colour). Perhaps it would improve the normal organs menu if the symbols were more varied. Then just displaying the symbols in the stat lines would make some sense.
So perhaps instead, all the organs affecting the stat should be displayed in a normal item menu when a stat is selected. Right now only stat value and description is displayed. The menu will just be a filtered organs menu.


Android Java: 02.13 EditText vs TextInputLayout/TextInputEditText

Description :scroll:

Give a brief explanation on EditText vs TextInputLayout/TextInputEditText in Android (Java).
Required Documentation or Video or Audio.

Domain of Contribution :bar_chart:

[x] Android Dev (java)

References :
https://www.section.io/engineering-education/how-is-textinputlayout-different-from-edittext/

Please Read it Carefully Before Contributing

Changes should be made in Android_Development_With_Java/ directory under Android_Development_With_Java branch.
Inside Android_Development_With_Java directory/ creates a directory and names it according to the topic
Inside Topic Name directory/ add your task with subtopic number and name and make changes accordingly.
You have to push your PR to the Android_Development_With_Java branch only.
You can take help to the references but don't simply try to copy it. Just explain in your own word.
This issue is for GWOC'21 contributors only.
You need to push in a single commit. If there exists more than one commit then you need to squash your commits into one commit.
Will assign you on a first come first serve basis.
Please try to complete your assigned task within 7 days. If you need some more time then, please inform mentors and supervisors.
If you have two previously assigned issues on Android-Java pending then please first complete them.

Supervisor @VikasPandey121

/assign


Json.Portable throw an exception on deserialization UInt64.MaxValue

Hi,
Add to project Newtonsoft.Json.Portable, and run bellow code
class Program
{
    static void Main(string[] args)
    {
        //works fine
        var uInt64MaxValueStr = JsonConvert.SerializeObject(UInt64.MaxValue);

        //an exeption JSON integer<PHONE_NUMBER>3709551615 is too large or small for an Int64.
        JsonConvert.DeserializeObject<UInt64>(uInt64MaxValueStr);
    }
}

I found that HAVE_BIG_INTEGER wasn't defined for the Newtonsoft.Json.Portable project.
In ParseReadNumber method, call of ConvertUtils.Int64TryParse returns ParseResult.Overflow because UInt64.MaxValue.ToString() has length of 20 chars, and this value couldn't parse as BigInteger (HAVE_BIG_INTEGER not defined).

Portable doesn't support BigInteger and long.MaxValue is the largest that can be serialized without it

But on Json.Portable serialization for UInt64.MaxValue works fine.
I updated my example, please, have a look.
Why it couldn't use UInt64 for parsing instead Int64?

Reading != writing
It isn't supported.


Update Get-SPOStructuralNavigationCacheSiteState.md

The syntax in Example 1 contained an incorrect param; updated from -WebUrl to -SiteUrl

Docs Build status updates of commit e584b53:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

sharepoint/sharepoint-ps/sharepoint-online/Get-SPOStructuralNavigationCacheSiteState.md
:white_check_mark:Succeeded
View (sharepoint-ps)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Tried using example and encountered error:

Works fine with correct param:

@tseward

@tiburd Please merge this PR. Thanks

Docs Build status updates of commit 7527184:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

sharepoint/sharepoint-ps/sharepoint-online/Get-SPOStructuralNavigationCacheSiteState.md
:white_check_mark:Succeeded
View (sharepoint-ps)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 89dec2e:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

sharepoint/sharepoint-ps/sharepoint-online/Get-SPOStructuralNavigationCacheSiteState.md
:white_check_mark:Succeeded
View (sharepoint-ps)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


[GH-9961] Fix boolean setting not updating properly for plugins

Summary
In Admin Console page for plugin settings, boolean setting in plugins cannot be updated if their default value is true.
This PR fixes the above bug.
Ticket Link
https://github.com/mattermost/mattermost-server/issues/9961
Checklist

[x] Ran make check-style to check for style errors (required for all pull requests)
[x] Ran make test to ensure unit and component tests passed

Spintmint test server creation failed. See the logs for more information.

Setup Test Server label detected. Spinmint test server created if build succeeds (checks pass and no conflicts with base branch).

Setup Test Server label detected. Spinmint test server created if build succeeds (checks pass and no conflicts with base branch).

Spintmint test server creation failed. See the logs for more information.

@cpanato Looks like the spinmint isn't firing for this PR.

Setup Test Server label detected. Spinmint test server created if build succeeds (checks pass and no conflicts with base branch).

Spinmint test server created at: https://i-02ea449b83a181b6e.test.spinmint.com
Test Admin Account: Username: sysadmin | Password: sysadmin
Test User Account: Username: user-1 | Password: user-1
Instance ID: i-02ea449b83a181b6e

@jasonblais done

Thanks Carlos, @chetanyakan - would you happen to have a sample plugin I can use to verify the changes?
I checked with our existing plugins, and changing the settings work, but I didn't find one with a boolean value set to true by default.

@jasonblais
mattermost-plugin-sample-plugin-darwin-amd64.tar.gz
mattermost-plugin-sample-plugin-linux-amd64.tar.gz
mattermost-plugin-sample-plugin-windows-amd64.tar.gz
Please find the plugin files attached.

Spinmint test server destroyed

Thanks for the quick reviews. @chetanyakan can you help rebase and then this PR is ready to merge.

I merged it, that check is optional and there shouldn't be any problems with not rebasing

Thanks @chetanyakan !


Text message history is invisible

System: Windows 11, Android Message Desktop 3.1.0
I'm able to write a text message , but no text message (incoming or sent) is displayed in the right main window.
Only the very few words of the most recent text message is visible in the small left window showing all contacts with SMS-history.
Could you kindly advise how to rectify this behavior?
Cheers, Thomas

#287


ValueError: Cannot flatten integer dtype tensors

System Info
peft                     0.8.2
Python              3.9.18
accelerate               0.26.1
torch                    2.2.0
transformers             4.37.2
Who can help?
No response
Information

[ ] The official example scripts
[X] My own modified scripts

Tasks

[ ] An officially supported task in the examples folder
[X] My own task or dataset (give details below)

Reproduction
I am following Fine-tuning with 🤗 TRL and run with:
accelerate launch --config_file examples/accelerate_configs/multi_gpu.yaml --num_processes=4 \
    examples/scripts/sft.py \
    --model_name /nas/lili/models_hf/Mixtral-8x7B-Instruct-v0.1 \
    --dataset_name trl-lib/ultrachat_200k_chatml \
    --batch_size 2 \
    --gradient_accumulation_steps 1 \
    --learning_rate 2e-4 \
    --save_steps 200_000 \
    --use_peft \
    --peft_lora_r 16 --peft_lora_alpha 32 \
    --target_modules q_proj k_proj v_proj o_proj \
    --load_in_4bit \
    --output output \
    --use_auth_token false

It throws:
Traceback (most recent call last):
  File "/nas/lili/codes/pt/ft/trl/examples/scripts/sft.py", line 158, in <module>
    trainer.train()
  File "/home/ubuntu/.local/share/virtualenvs/ft-Zgps2Kz_/lib/python3.9/site-packages/trl/trainer/sft_trainer.py", line 315, in train
    output = super().train(*args, **kwargs)
  File "/home/ubuntu/.local/share/virtualenvs/ft-Zgps2Kz_/lib/python3.9/site-packages/transformers/trainer.py", line 1537, in train
    return inner_training_loop(
  File "/home/ubuntu/.local/share/virtualenvs/ft-Zgps2Kz_/lib/python3.9/site-packages/transformers/trainer.py", line 1821, in _inner_training_loop
    for step, inputs in enumerate(epoch_iterator):
  File "/home/ubuntu/.local/share/virtualenvs/ft-Zgps2Kz_/lib/python3.9/site-packages/accelerate/data_loader.py", line 448, in __iter__
    current_batch = next(dataloader_iter)
  File "/home/ubuntu/miniconda3/envs/torchshare/lib/python3.9/site-packages/torch/utils/data/dataloader.py", line 630, in __next__
    data = self._next_data()
  File "/home/ubuntu/miniconda3/envs/torchshare/lib/python3.9/site-packages/torch/utils/data/dataloader.py", line 674, in _next_data
    data = self._dataset_fetcher.fetch(index)  # may raise StopIteration
  File "/home/ubuntu/miniconda3/envs/torchshare/lib/python3.9/site-packages/torch/utils/data/_utils/fetch.py", line 54, in fetch
    return self.collate_fn(data)
  File "/home/ubuntu/.local/share/virtualenvs/ft-Zgps2Kz_/lib/python3.9/site-packages/transformers/data/data_collator.py", line 45, in __call__
    return self.torch_call(features)
  File "/home/ubuntu/.local/share/virtualenvs/ft-Zgps2Kz_/lib/python3.9/site-packages/transformers/data/data_collator.py", line 732, in torch_call
    batch = self.tokenizer.pad(examples, return_tensors="pt", pad_to_multiple_of=self.pad_to_multiple_of)
  File "/home/ubuntu/.local/share/virtualenvs/ft-Zgps2Kz_/lib/python3.9/site-packages/transformers/tokenization_utils_base.py", line 3259, in pad
    padding_strategy, _, max_length, _ = self._get_padding_truncation_strategies(
  File "/home/ubuntu/.local/share/virtualenvs/ft-Zgps2Kz_/lib/python3.9/site-packages/transformers/tokenization_utils_base.py", line 2707, in _get_padding_truncation_strategies
    raise ValueError(
ValueError: Asking to pad but the tokenizer does not have a padding token. Please select a token to use as `pad_token` `(tokenizer.pad_token = tokenizer.eos_token e.g.)` or add a new pad token via `tokenizer.add_special_tokens({'pad_token': '[PAD]'})`.

Besides this error, there are warning like:
/home/ubuntu/.local/share/virtualenvs/ft-Zgps2Kz_/lib/python3.9/site-packages/trl/trainer/sft_trainer.py:282: UserWarning: You passed a token
izer with `padding_side` not equal to `right` to the SFTTrainer. This might lead to some unexpected behaviour due to overflow issues when tra
ining a model in half-precision. You might consider adding `tokenizer.padding_side = 'right'` to your code.

my env:
torch                    2.1.2
transformers             4.36.2
trl                      0.7.8.dev0
accelerate               0.25.0
peft                     0.7.1
bitsandbytes             0.41.3.post2

I have added tokenizer.padding_side = 'right'. And it throws:
Traceback (most recent call last):
  File "/nas/lili/codes/pt/ft/trl/examples/scripts/sft.py", line 117, in <module>
    trainer.train()
  File "/nas/lili/codes/pt/ft/trl/trl/trainer/sft_trainer.py", line 326, in train
    output = super().train(*args, **kwargs)
  File "/home/ubuntu/.cache/pypoetry/virtualenvs/ft-zSqjAXBp-py3.9/lib/python3.9/site-packages/transformers/trainer.py", line 1539, in train
    return inner_training_loop(
  File "/home/ubuntu/.cache/pypoetry/virtualenvs/ft-zSqjAXBp-py3.9/lib/python3.9/site-packages/transformers/trainer.py", line 1687, in _inner_training_loop
    model, self.optimizer = self.accelerator.prepare(self.model, self.optimizer)
  File "/home/ubuntu/.cache/pypoetry/virtualenvs/ft-zSqjAXBp-py3.9/lib/python3.9/site-packages/accelerate/accelerator.py", line 1227, in prepare
    result = tuple(
  File "/home/ubuntu/.cache/pypoetry/virtualenvs/ft-zSqjAXBp-py3.9/lib/python3.9/site-packages/accelerate/accelerator.py", line 1228, in <genexpr>
    self._prepare_one(obj, first_pass=True, device_placement=d) for obj, d in zip(args, device_placement)
  File "/home/ubuntu/.cache/pypoetry/virtualenvs/ft-zSqjAXBp-py3.9/lib/python3.9/site-packages/accelerate/accelerator.py", line 1104, in _prepare_one
    return self.prepare_model(obj, device_placement=device_placement)
  File "/home/ubuntu/.cache/pypoetry/virtualenvs/ft-zSqjAXBp-py3.9/lib/python3.9/site-packages/accelerate/accelerator.py", line 1386, in prepare_model
    model = FSDP(model, **kwargs)
  File "/home/ubuntu/.cache/pypoetry/virtualenvs/ft-zSqjAXBp-py3.9/lib/python3.9/site-packages/torch/distributed/fsdp/fully_sharded_data_parallel.py", line 477, in __init__
    _auto_wrap(
  File "/home/ubuntu/.cache/pypoetry/virtualenvs/ft-zSqjAXBp-py3.9/lib/python3.9/site-packages/torch/distributed/fsdp/_wrap_utils.py", line 101, in _auto_wrap
    _recursive_wrap(**recursive_wrap_kwargs, **root_kwargs)  # type: ignore[arg-type]
  File "/home/ubuntu/.cache/pypoetry/virtualenvs/ft-zSqjAXBp-py3.9/lib/python3.9/site-packages/torch/distributed/fsdp/wrap.py", line 543, in _recursive_wrap
    wrapped_child, num_wrapped_params = _recursive_wrap(
  File "/home/ubuntu/.cache/pypoetry/virtualenvs/ft-zSqjAXBp-py3.9/lib/python3.9/site-packages/torch/distributed/fsdp/wrap.py", line 543, in _recursive_wrap
    wrapped_child, num_wrapped_params = _recursive_wrap(
  File "/home/ubuntu/.cache/pypoetry/virtualenvs/ft-zSqjAXBp-py3.9/lib/python3.9/site-packages/torch/distributed/fsdp/wrap.py", line 543, in _recursive_wrap
    wrapped_child, num_wrapped_params = _recursive_wrap(
  [Previous line repeated 2 more times]
  File "/home/ubuntu/.cache/pypoetry/virtualenvs/ft-zSqjAXBp-py3.9/lib/python3.9/site-packages/torch/distributed/fsdp/wrap.py", line 561, in _recursive_wrap
    return _wrap(module, wrapper_cls, **kwargs), nonwrapped_numel
  File "/home/ubuntu/.cache/pypoetry/virtualenvs/ft-zSqjAXBp-py3.9/lib/python3.9/site-packages/torch/distributed/fsdp/wrap.py", line 490, in _wrap
    return wrapper_cls(module, **kwargs)
  File "/home/ubuntu/.cache/pypoetry/virtualenvs/ft-zSqjAXBp-py3.9/lib/python3.9/site-packages/torch/distributed/fsdp/fully_sharded_data_parallel.py", line 503, in __init__
    _init_param_handle_from_module(
  File "/home/ubuntu/.cache/pypoetry/virtualenvs/ft-zSqjAXBp-py3.9/lib/python3.9/site-packages/torch/distributed/fsdp/_init_utils.py", line 594, in _init_param_handle_from_module
    _init_param_handle_from_params(state, managed_params, fully_sharded_module)
  File "/home/ubuntu/.cache/pypoetry/virtualenvs/ft-zSqjAXBp-py3.9/lib/python3.9/site-packages/torch/distributed/fsdp/_init_utils.py", line 606, in _init_param_handle_from_params
    handle = FlatParamHandle(
  File "/home/ubuntu/.cache/pypoetry/virtualenvs/ft-zSqjAXBp-py3.9/lib/python3.9/site-packages/torch/distributed/fsdp/_flat_param.py", line 573, in __init__
    self._init_flat_param_and_metadata(
  File "/home/ubuntu/.cache/pypoetry/virtualenvs/ft-zSqjAXBp-py3.9/lib/python3.9/site-packages/torch/distributed/fsdp/_flat_param.py", line 623, in _init_flat_param_and_metadata
    ) = self._validate_tensors_to_flatten(params)
  File "/home/ubuntu/.cache/pypoetry/virtualenvs/ft-zSqjAXBp-py3.9/lib/python3.9/site-packages/torch/distributed/fsdp/_flat_param.py", line 759, in _validate_tensors_to_flatten
    raise ValueError("Cannot flatten integer dtype tensors")

And I found this https://github.com/facebookresearch/llama-recipes/issues/240. It says fsdp can't use load_in_4bit. When I turn of load_in_4bit, it works.(It has another oom problem, you can see here but it's not related to peft)
Expected behavior
fix bug

Hi @fancyerii
Thanks a lot for the issue !
For the first issue you need to set tokenizer.pad_token = tokenizer.eos_token
Indeed FSDP + QLoRA are not compatible - yet ! @Titus-von-Koeller @pacman100  & external collaborators (@warner-benjamin @weifengpy) worked recently on adding QLoRA + FSDP support: https://github.com/TimDettmers/bitsandbytes/pull/970 can you try out to build bnb from source? (installation guideleines here: https://huggingface.co/docs/bitsandbytes/main/en/installation) - let us know how it goes !

I installed gcc/g++ 8.4. it still can't support -std=c++20:
/usr/local/cuda-12.1/bin/nvcc -gencode arch=compute_75,code=sm_75 -gencode arch=compute_80,code=sm_80 -gencode arch=compute_86,code=sm_86 -gencode arch=compute_89,code=sm_89 -gencode arch=compute_90,code=sm_90 -Xcompiler '-fPIC' -dlink /nas/lili/codes/pt/ft/bitsandbytes/build/ops.o /nas/lili/codes/pt/ft/bitsandbytes/build/kernels.o -o /nas/lili/codes/pt/ft/bitsandbytes/build/link.o
/usr/bin/g++ -std=c++20 -DBUILD_CUDA -shared -fPIC -I /usr/local/cuda-12.1/include -I /nas/lili/codes/pt/ft/bitsandbytes/csrc -I /home/ubuntu/miniconda3/include -I /nas/lili/codes/pt/ft/bitsandbytes/include /nas/lili/codes/pt/ft/bitsandbytes/build/ops.o /nas/lili/codes/pt/ft/bitsandbytes/build/kernels.o /nas/lili/codes/pt/ft/bitsandbytes/build/link.o /nas/lili/codes/pt/ft/bitsandbytes/csrc/common.cpp /nas/lili/codes/pt/ft/bitsandbytes/csrc/cpu_ops.cpp /nas/lili/codes/pt/ft/bitsandbytes/csrc/pythonInterface.c -o ./bitsandbytes/libbitsandbytes_cuda121.so -L /usr/local/cuda-12.1/lib64 -lcudart -lcublas -lcublasLt -lcusparse -L /home/ubuntu/miniconda3/lib
g++: error: unrecognized command line option ‘-std=c++20’; did you mean ‘-std=c++2a’?

I searched this post but still don't know which version of gcc/g++ can compile peft.

I installed gcc/g++-10 and build bitsandbytes successfully. Now I don't confront ValueError: Cannot flatten integer dtype tensors. But it still oom. So I enable gradient_checkpointing and it run correctly. it seems load in 4bit don't save that much gpu memory?

FSDP + QLoRA should be now fully integrated in HF ecosystem
Can you try to install latest accelerate & bitsandbytes from pypi and transformers / trl / peft from source and follow the script presented here: https://github.com/huggingface/peft/blob/main/examples/sft/run_peft_qlora_fsdp.sh
Please also have a look at the appropriate PEFT documentation: https://huggingface.co/docs/peft/main/en/accelerate/deepspeed#deepspeed

FSDP + QLoRA should be now fully integrated in HF ecosystem Can you try to install latest accelerate & bitsandbytes from pypi and transformers / trl / peft from source and follow the script presented here: https://github.com/huggingface/peft/blob/main/examples/sft/run_peft_qlora_fsdp.sh Please also have a look at the appropriate PEFT documentation: https://huggingface.co/docs/peft/main/en/accelerate/deepspeed#deepspeed

I tried, but the error still same,

FSDP + QLoRA should be now fully integrated in HF ecosystem Can you try to install latest accelerate & bitsandbytes from pypi and transformers / trl / peft from source and follow the script presented here: https://github.com/huggingface/peft/blob/main/examples/sft/run_peft_qlora_fsdp.sh Please also have a look at the appropriate PEFT documentation: https://huggingface.co/docs/peft/main/en/accelerate/deepspeed#deepspeed

great job. I can run it with 8 gpus in one node. later I will try with two nodes.

FSDP + QLoRA should be now fully integrated in HF ecosystem Can you try to install latest accelerate & bitsandbytes from pypi and transformers / trl / peft from source and follow the script presented here: https://github.com/huggingface/peft/blob/main/examples/sft/run_peft_qlora_fsdp.sh Please also have a look at the appropriate PEFT documentation: https://huggingface.co/docs/peft/main/en/accelerate/deepspeed#deepspeed

I tried, but the error still same,

here is my installation(I use PDM and this is exported requirements.txt)
requirements.txt

FSDP + QLoRA should be now fully integrated in HF ecosystem Can you try to install latest accelerate & bitsandbytes from pypi and transformers / trl / peft from source and follow the script presented here: https://github.com/huggingface/peft/blob/main/examples/sft/run_peft_qlora_fsdp.sh Please also have a look at the appropriate PEFT documentation: https://huggingface.co/docs/peft/main/en/accelerate/deepspeed#deepspeed

I tried, but the error still same,

here is my installation(I use PDM and this is exported requirements.txt) requirements.txt

Thank you very much for sharing. My pip installed version is exactly the same as yours accelerate & bitsandbytes、transformers、trl and peft from source. but the same error. below is my installed:
maybe I launch training by accelerate ? I don't know why.

FSDP + QLoRA should be now fully integrated in HF ecosystem Can you try to install latest accelerate & bitsandbytes from pypi and transformers / trl / peft from source and follow the script presented here: https://github.com/huggingface/peft/blob/main/examples/sft/run_peft_qlora_fsdp.sh Please also have a look at the appropriate PEFT documentation: https://huggingface.co/docs/peft/main/en/accelerate/deepspeed#deepspeed

I tried, but the error still same,

here is my installation(I use PDM and this is exported requirements.txt) requirements.txt

Thank you very much for sharing. My pip installed version is exactly the same as yours accelerate & bitsandbytes、transformers、trl and peft from source. but the same error.
maybe I launch training by accelerate ? I don't know why.

@shatealaboxiaowang
Hi, I am experiencing the same issue as you do. Have you managed to find a solution?

Hey, the bitsandbytes lead maintainer here 🤗
For anyone still hitting this issue due to FSDP + QLoRA, please make sure to read these docs about correctly configuring the bnb_4bit_quant_storage to a float dtype (as FSDP doesn't support int dtypes) and the dtype should exactly match the rest of the model tensors, enabling the FSDP wrapping logic to work correctly.

correctly configuring the bnb_4bit_quant_storage to a float dtype (as FSDP doesn't support int dtypes) and the dtype should exactly match the rest of the model tensors, enabling the FSDP wrapping logic to work correctly.

Am I not supposed to get this error with bnb_4bit_compute_dtype='bfloat16', bnb_4bit_quant_storage_dtype='bfloat16', bnb_4bit_quant_type='nf4'? It's still happening to me.


Error in Rule TechnicianDispatch_ScheduleArrivalDateTime_NotificationResponse: Unknown Message: Unable to parse duration string '3600000'.  Expected number followed by time unit.

Still ongoing issue in the collaboration TechnicianDispatch :
Error in Procedure 'startA_TechnicianDispatch_CustomerSchedulingAlert'
Execution Start Time: 2020-11-27 18:27:39.163
Execution End Time: 2020-11-27 18:27:39.478
Elapsed Time: 315ms
Code: Unknown
Message: Unable to parse duration string '3600000'.  Expected number followed by time unit.

fixed with latest commit https://github.com/Vantiq/Blueprints/pull/21/commits/cbe869f791cf82bb321d1988ae8654ac18dfa729


Change task background

test

@XiongxinXiao hope you don't mind, but I'm going to close this pull request as this repo is the starter template for the tutorial and doesn't contain any changes to the actual code.
Hope you have a great week!
Stay safe


Fix voucher limit value when checkbox unchecked

I want to merge this change because...

Screenshots

Pull Request Checklist

[ ] Privileged views and APIs are guarded by proper permission checks.
[ ] All visible strings are translated with proper context.
[ ] All data-formatting is locale-aware (dates, numbers, and so on).
[ ] Database queries are optimized and the number of queries is constant.
[ ] Database migration files are up to date.
[ ] The changes are tested.
[ ] The code is documented (docstrings, project documentation).
[ ] GraphQL schema and type definitions are up to date.
[ ] Changes are mentioned in the changelog.

If you want to clear usageLimit, use null instead of 0.

Now if a user clear input field (eg. Minimal order value, Limit of Uses) and save, the dashboard try to make mutation with "" as value for this field. This will cause an error. If a user clears any decimal input field, we should send null instead of "".

Here is the report for 60a03542cc9c90fdc89b0d87dab5f0ad8062b04c (mirumee/saleor @ fix-voucher-usage-limit-check)
Base comparison is c0984137c26304a1d0bd9b22cb6d31e48039959b.
No differences were found. (click me)

# api.benchmark checkout
  test name                           	left count 	right count	duplicate count
  ------------------------------------	-----------	-----------	---------------
  add billing address to checkout     	         34	         34	             20
  add shipping to checkout            	          7	          7	              0
  checkout payment charge             	         14	         14	              0
  complete checkout                   	          6	          6	              0
  create checkout                     	         43	         43	             21

# api.benchmark homepage
  test name                           	left count 	right count	duplicate count
  ------------------------------------	-----------	-----------	---------------
  retrieve main menu                  	          5	          5	              0
  retrieve product list               	          4	          4	              0
  retrieve secondary menu             	          5	          5	              0
  retrieve shop                       	          2	          2	              0

# api.benchmark product
  test name                           	left count 	right count	duplicate count
  ------------------------------------	-----------	-----------	---------------
  product details                     	         13	         13	              3

# api.benchmark variant
  test name                           	left count 	right count	duplicate count
  ------------------------------------	-----------	-----------	---------------
  retrieve variant list               	          9	          9	              2


add UI elements for tweaking the regression model

[ ] slider to specify the degree of polynomial regression

[ ] slider to specify the learning rate of the model

done in commit #6163e042be729b05a87628d40a6bdd8e85bc7d48


prepare release 1.3.2

Codecov Report

Merging #434 into 1.3 will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              1.3     #434   +/-   ##
=======================================
  Coverage   38.31%   38.31%
=======================================
  Files          20       20
  Lines        1665     1665
=======================================
  Hits          638      638
  Misses       1027     1027

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b2a221...9520457. Read the comment docs.


⚠ ClamAV has degraded performance

In fd55d15, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 208 ms

Resolved: ClamAV performance has improved in a1634e5 after 56 minutes.