Volume normalization

Something nice-to-have.
May`n songs are pretty loud in comparison to the rest.

Should be possible by setting
volume_normalization yes in mpd.conf via
This may affect stream quality though.

Oh cool. Nice.
On Mon, May 11, 2015 at 12:06 PM, Arlan Jaska<EMAIL_ADDRESS>wrote:

Should be possible by setting
volume_normalization yes in mpd.conf via
http://linux.die.net/man/5/mpd.conf
This may affect stream quality though.
—
Reply to this email directly or view it on GitHub
https://github.com/ATRAN2/fureon/issues/10#issuecomment-100758257.

--
Vincent

Better solution would be to have mpd use replaygain and have users reupload problematic albums with the appropriate replaygain metadata, since imo normalizing the entire stream has the potential to cause unexpected behavior.

I agree that replaygain is probably the best solution in terms of audio quality for pre-uploaded files, but there's a lot more effort involved (having a process to flag problematic albums, generate replaygain metadata, reupload, etc.)
mpd uses a pretty simple "normalization" algorithm and I doubt it would cause unexpected behavior. it also has the benefit of working on a stream of files that have not been pre-processed (e.g. the first play of new music or if someone is streaming directly)
I think it might be worth enabling the mpd configuration option temporarily and subjectively judging how it sounds? the effort involved in activating it is pretty low

Hmm, this seems pretty unobjectionable, true. The use of "normalization"
here is a bit of a misnomer though. May as well make it so.
On Sun, May 10, 2015 at 10:07 PM, Arlan Jaska<EMAIL_ADDRESS>wrote:

I agree that replaygain is probably the best solution in terms of audio
quality for pre-uploaded files, but there's a lot more effort involved
(having a process to flag problematic albums, generate replaygain metadata,
reupload, etc.)
mpd uses a pretty simple "normalization" algorithm
http://beesbuzz.biz/code/audiocompress.php and I doubt it would cause
unexpected behavior. it also has the benefit of working on a stream of
files that have not been pre-processed (e.g. the first play of new music or
if someone is streaming directly)
I think it might be worth enabling the mpd configuration option
temporarily and subjectively judging how it sounds? the effort involved in
activating it is pretty low
—
Reply to this email directly or view it on GitHub
https://github.com/ATRAN2/fureon/issues/10#issuecomment-100766862.

It's been activated on the test server. We can see how it goes for a while.

Seems to work pretty well.

Spooky algorithms.
On Mon, May 11, 2015 at 9:00 AM, Vincent Rodriguez<EMAIL_ADDRESS>
wrote:

Seems to work pretty well.
—
Reply to this email directly or view it on GitHub
https://github.com/ATRAN2/fureon/issues/10#issuecomment-100957717.


can forward example and change of value?

Hello all and thanks for your work!
I have been trying to work out how the can forwarding is working but to no avail! Also, sniffing around the code trying to make the can forwarding work I have notices that in the base.py the _comm_forward_can is set to 33 whereas in the Vedder_BLDC_Commands.py this is 34.
For the testing, I have tried both of the above values and manually changing in base.py the  cls.can_id = None to 1  - which is the id of the slave vesc and then just run a bare minimum script sending the rpm values.
In both cases, only the master led lights up and only the master motor is spinning.
I can verify that when manually changing the cls.can_id  to something other than None, it goes into the
def pack(instance, header_only=None):
if header_only:
if instance.can_id is not None:
Shall I send the command from my script differently?
Current way:
ser.write(pyvesc.encode(SetRPM(7500)))
as in the example.
Are there any examples on how to actually can forward the messages?
Am i missing something?
Thank you very much for your time!
Best,
Mike

Hi @ekptwtos , were you able to find a solution to this issue. I am facing the same issue, and have tried the things that you mentioned.
Let me know if there is way to solve it.
Thanks.


[4.0.0-rc-3]Error meta

Describe your problem
Error meta Description
Steps to reproduce the problem
Complete here.
Bludit version
4.0.0-rc-3

Can you please describe the problem, and how it can be reproduced.

Can you please describe the problem, and how it can be reproduced.

Sorry. Its work


Print on Chrome 45 prints extra blank pages

This was fixed by #5857 but break again on Chrome 45.0.2454.26 beta (64-bit) and OS X 10.10.4.
It is working on Chrome 44.
I tried many PDFs (including compressed.tracemonkey-pldi-09.pdf) and all of them have extra blank page before actual content page.

I found out the fix for Chrome 45 is change PRINT_OUTPUT_SCALE to 1 (https://github.com/mozilla/pdf.js/blob/master/web/pdf_page_view.js#L496)

Perhaps #6160 will help a bit as that touches the output scale too?

Yes #6160 fixes this problem. Any plan to merge it in?

We need more cross-browser tests that to make sure nothing regresses. Otherwise that patch looks good.

@timvandermeij what specific testing would you like to see? I had tested non-IE browsers and it doesn't appear to regress. I didn't test IE because presumably the OP was testing in IE to fix an IE issue.

We need to have manual testing results on that PR for various configurations to be reasonable sure that nothing regresses. I am thinking of the following tests:

Firefox stable on Windows, Linux and OS X
Firefox beta/aurora/nightly on Windows, Linux and OS X
IE 11/Edge on Windows
Chrome (latest) on Windows, Linux and OS X

On linux version 45 beta have the same problem, on windows too.

This is probably not a bug in PDF.js, it was a bug in Chrome: https://code.google.com/p/chromium/issues/detail?id=526098 (fixed in 47, as of writing 45 and 46 are affected).

I'm actually seeing a blank page inserted before every page, but only on Chrome 45.
Worth noting on an old version of the viewer we use/modified (1.0.1040) I see a single blank page inserted, newer versions (1.1.215 and your snapshot demo site) i see the blank page before every page.

@dankirberger Which version of Chrome are you using? This has been fixed in 45.0.2454.93.

Had to restart Chrome, I have 45.0.2454.93 now, an earlier 45.x before restarting. All is well now, thanks!

If this is fixed upstream, can we close this or is there anything else left to do here?

I saw the same issues the reporter did, and more, all were fixed by updating Chrome. I think this can be closed.

With Chrome 51 and Electron the Issue still exists, in Windows 10 and in MAC OS.

The problem is still present in Firefox 48 on Fedora 24 x84_64


feat: support hoist node linker

Support node-linker=hoist in .npmrc

Description
In some projects (eg. React Native), we must enable the node-linker=hoist, but Modern.js only search for the tsc inside the current workspace to build.

Related Issue
https://github.com/modern-js-dev/modern.js/issues/1985

Motivation and Context
https://pnpm.io/npmrc#node-linker
Modern.js can't build correctly if it's used together in React Native projects.

How Has This Been Tested
Change related code in demo repository and run build

Types of changes

[ ] Docs change / refactoring / dependency upgrade
[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist

[x] My code follows the code style of this project.
[x] I have updated changeset
[ ] No My change requires a change to the documentation.
[ ] No Need I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.

Tested manually, but don't know how to write the test in this case.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

There are some lint issues, you can use prettier to format the code: https://github.com/modern-js-dev/modern.js/actions/runs/3360727908/jobs/5570351996

There are some lint issues, you can use prettier to format the code: https://github.com/modern-js-dev/modern.js/actions/runs/3360727908/jobs/5570351996

Hi, I've fixed the issues reported in CI

👍🏻


NPE while scaling up a topology

I am getting the following NPE while trying to scale up a topology
Exception in thread "main" java.lang.NullPointerException
        at c.t.h.p.PackingPlanBuilder.addInstance(PackingPlanBuilder.java:97)
        at c.t.h.p.b.FirstFitDecreasingPacking.placeFFDInstance(FirstFitDecreasingPacking.java:307)
        at c.t.h.p.b.FirstFitDecreasingPacking.assignInstancesToContainers(FirstFitDecreasingPacking.java:269)
        at c.t.h.p.b.FirstFitDecreasingPacking.getFFDAllocation(FirstFitDecreasingPacking.java:248)
...

I am running ExclamationTopology.
Steps:

Initially I had 2 instances of word and 4 instances of exclaim bolt. There are 6 containers each with one instance.
I scaled up word to 3 instances. The total number of containers is 7 now.
I scaled word down to 2. Container 5 is removed. The makes the container ids non-continuous, i.e. 0-4,6,7 and 5 is removed.
Scaling up word component again will result in the NPE above.

@ashvina the only way that seems like it would happen would be if the same PackingPlanBuilder was used to pack/repack, then build() was called, and then add was called on the builder. The expected usage is that after build() is called, changes can no longer be made to that builder. We need to clarify that in the builder javadocs and throw a PackingException if that happens, instead of a NPE.

@billonahill - I was using heron update command for all the scaling related steps. Repacking happens on the client. As a new client process is launched for each update action, I dont think this issue is caused by reuse of PackingPlanBuilder. I have not been able to look into the issue in detail. I will try to add a test case for this issue tomorrow.

@ashvina let me know if you can reproduce. I'm puzzled because the first thing addInstance does is initialize the containers, where non-contiguous ids are supported:
https://github.com/twitter/heron/blob/master/heron/packing/src/java/com/twitter/heron/packing/PackingPlanBuilder.java#L260
Then we never delete containers, we just skip the empty one's when we generate the plan:
https://github.com/twitter/heron/blob/master/heron/packing/src/java/com/twitter/heron/packing/PackingPlanBuilder.java#L181

@ashvina @billonahill I think there might be a problem with the placeFFDInsatce method in binpacking.
There is a for loop assuming contiguous container Ids:
https://github.com/twitter/heron/blob/master/heron/packing/src/java/com/twitter/heron/packing/binpacking/FirstFitDecreasingPacking.java#L305
I will investigate tomorrow.

@avflor that looks like it. If that's the case I have a patch already written (for another reason) that would address it. I can submit it after #1565 ships, which it is built upon.

Great! The basic idea is that the containers should still be ordered for the FFD heuristic to work but we should not assume the container Ids are contiguous.

The patch in #1572 should address fix this issue, since it doesn't assume a contiguous id space. It sorts containers by id and iterates though each.

@ashvina I believe #1572 has addressed this issue since FFDP now places instances using a container scorer which ranks by id, instead of directly by id. Please re-open if you have a test that shows otherwise.


Introduce standard log fields and replace zap with logrus

To introduce standard logging fields and conventions, we need to fix the following limitations with the current codebase

go-logr logr.logger interface doesn't support log levels (they use verbose level number instead).
With zap implementation of go-logr, we managed to add support for debug loglevel, but warn is missing
Top level fields (ts, msg etc) are not as per google structured logging standard. This makes it difficult to view the logs in google console. https://cloud.google.com/logging/docs/structured-logging
If we use zap directly, we will have to change entire codebase to use the new methods from zap
logr.Logger interface is currently in use everywhere (even inside controller-runtime). So our only option is to use a logger which is an implementation of this interface.

To fix this, this PR introduces the following changes (more PRs to follow)

Replace zap with logrus. It is easier to migrate to logrus syntax in the current codebase than zap. See the difference below for the basic usage.

# logrus
log.WithFields("slice","green").Info("something")

# zap
log.Info("something", zap.string("slice", "green"))

Change log field names

level -> severity
msg -> message
ts -> timestamp

Added logrusr package to convert logrus to logr implementation (will replace with our own implementation in next PRs)
go fmt and go.mod changes

Next steps

Replace logrusr with our own implementation to support the log levels (https://github.com/bombsimon/logrusr/blob/main/logrusr.go)
Export log levels as constants and replace code blocks like below

log.V(1).Info("App pod is not part of the slice", "pod", pod.Name, "slice", slice.Name)
log.V(logger.DEBUG).Info("App pod is not part of the slice", "pod", pod.Name, "slice", slice.Name)

log.V(2).Info("App pod is not part of the slice", "pod", pod.Name, "slice", slice.Name)
log.V(logger.WARN).Info("App pod is not part of the slice", "pod", pod.Name, "slice", slice.Name)

Improve log messages and fields

report link  'https://kubeslice.github.io/e2e-allure-reports/Kind-worker-operator-2022-11-13T08:51:04-master-235/index.html'

HI @kmjayadeep , this is a great description. Thank you.
I am not clear about the following,

Replace logrusr with our own implementation to support the log levels (https://github.com/bombsimon/logrusr/blob/main/logrusr.go)
and
Export log levels as constants and replace code blocks like below
seem like the same steps to me or did I misunderstand you ?

The changes look good to me :+1:

thanks @gourishkb. I'm closing this PR. I found that it is easy to implement this with zap itself, without needing to maintain our own implementation of logr.Logger. I will raise a separate PR


Remove vagrant in file names

If you choose to build with a specific SSH_USERNAME, you mostly don't
want to have explicit vagrant-related stuff in your box

Cool. I was wondering about that.


Add type="button" to prevent form submission from embedded player

1 Upvote If the player is embedded inside a <form> element (e.g. on an ASP.NET site where the whole page is a giant form), trying to press one of the media control buttons could fire the form submission unexpectedly, which results in strange behavior on full-screen, back to live, etc.
By changing the button type to "button" (instead of default of "submit"), tapping the button does not submit the form any more.

:+1:

👍


This is done to prevent renovate updating own PR in a loop when it fails to properly auto-detect whether to use semantic commit messages.

By default, renovate tries to detect which style to use based on the commit history of the repo?
I'm wondering if this change will make our renovate PRs fail CI checks for repos that use semantic commits

By default, renovate tries to detect which style to use based on the commit history of the repo?

Yes, but sometimes it fails and does strange things:

I'm wondering if this change will make our renovate PRs fail CI checks for repos that use semantic commits

@chmeliik  it might. The idea is to not let renovate autodetect, so the situation on the screenshot above won't happen. We may turn semantic commits style on, so it won't fail the checks on repositories that require them.


Some devices fail to upload images

We have no stacktrace of such bugs but they clearly happen.
It is probably time to implement an exception handler and an error reporter.
There's several solutions

http://www.acra.ch/  (there's a CouchDb backend too)
https://github.com/tomquist/Android-Error-Reporter (no gradle, only a jar)
roll our own

There's also the solution of not catching critical exceptions and letting the OS handle reporting for us, which worked and reported that the server's max_upload_filesize was not set high enough.


Remove version: OSGeo.GeoServer version 2.23.0

[Automated] It returns code over 400 in all urls
Microsoft Reviewers: Open in CodeFlow

URL: https://sourceforge.net/projects/geoserver/files/GeoServer/2.23.0/GeoServer-2.23.0-winsetup.exe/download
OK
(Automated message - build 923)

URL: https://sourceforge.net/projects/geoserver/files/GeoServer/2.23.0/GeoServer-2.23.0-winsetup.exe/download
Status Code: 200
(Automated message - build 904)

Close with reason: Removal appears to be automated and in error;


fix:  Ensure Custom Domain for Purchase Page

If this environment variable is not set, users will be directed to the Vercel-generated random domain instead of the custom domain when entering the purchase page.
The issue lies in src\utils\get-url.ts.

The best approach should be to use relative paths

Not a maintainer but looks like a good addition; just adding a bump.


Require the Heroku app name for bin/setup

Users should be joining their own deployed Heroku app.

Ready for re-review.

:+1:


Readme (p2ui) generation

Add the p2ui readme generation to automate that as well
Make a functionality that automatically asks for the night astronomers and their data, if none provided leave empty.
Fetch the names of the nights from the OB folders if toggled.

Make README generation for both

[ ] Visitor Mode (Info about the run, parsed from the night-plan
[ ] Service Mode, information on the observers


fix moose interface to handle vector variables

Pull Request Description
What issue does this change request address? (Use "#" before the issue to link it, i.e., #42.)
Update moose interface to handle vector variables, close #868
What are the significant changes in functionality due to this change request?

For Change Control Board: Change Request Review
The following review must be completed by an authorized member of the Change Control Board.

[ ] 1. Review all computer code.
[ ] 2. If any changes occur to the input syntax, there must be an accompanying change to the user manual and xsd schema. If the input syntax change deprecates existing input files, a conversion script needs to be added (see Conversion Scripts).
[ ] 3. Make sure the Python code and commenting standards are respected (camelBack, etc.) - See on the wiki for details.
[ ] 4. Automated Tests should pass, including run_tests, pylint, manual building and xsd tests. If there are changes to Simulation.py or JobHandler.py the qsub tests must pass.
[ ] 5. If significant functionality is added, there must  be tests added to check this. Tests should cover all possible options.  Multiple short tests are preferred over one large test. If new development on the internal JobHandler parallel system is performed, a cluster test must be added setting, in  XML block, the node <internalParallel> to True.
[ ] 6. If the change modifies or adds a requirement or a requirement based test case, the Change Control Board's Chair or designee also needs to approve the change.  The requirements and the requirements test shall be in sync.
[ ] 7. The merge request must reference an issue.  If the issue is closed, the issue close checklist shall be done.
[ ] 8. If an analytic test is changed/added is the the analytic documentation updated/added?
[ ] 9. If any test used as a basis for documentation examples (currently found in raven/tests/framework/user_guide and raven/docs/workshop) have been changed, the associated documentation must be reviewed and assured the text matches the example.

@mandd Do you have time to review this PR?

@mandd I have resolved your comments.

PR is good to me. Test board is green.


[Bug] Functions declared after an uncovered return (hoisted) are both uncovered and covered

Describe the bug
A clear and concise description of what the bug is.
To Reproduce

Version: 2.8.3
Node Version: 20.12.0
Have you tried the latest version (including node), and does the issue still exist? Yes
Steps to reproduce the actual behavior:

Clone http://github.com/microsoft/TypeScript
npx c8 --experimental-monocart --reporter=v8 npm test -- --no-lint
npx serve coverage

Expected behavior
A clear and concise description of what you expected to happen.
Code for hoisted but called functions should be marked as covered.
Errors or Screenshots
Any captured error messages, or add screenshots to help explain your problem.

This code is marked as uncovered in red, but at the same time has the little green boxes showing that it really did execute.
Probably, this has something to do with how these functions are declared after the return but the return is never reached.
Make a minimal reproduction
Sorry, I don't know if I can make a small reproducer; I tried writing similar code like:
function doSomething() {
    return foo();

    function foo() {
        return 'Hello';
    }
}

doSomething();

But it didn't exhibit the same problem.
Additional context
Add any other context about the problem here.

Yeah, it seems to be related to that unreached return. Another example:

Actually for an easier repro, just clone https://github.com/microsoft/TypeScript/pull/58850 and do npm test -- --no-lint --coverage.

It seems like this problem occurs when there is a function defined after a return statement.
It doesn't seem very reasonable, but there's no syntax error. I will figure out how to fix it. thanks for the case.

This is super common code in our codebase as we don't use classes, but instead return plain objects closures for performance.

Built with your most recent change; it does fix some of it, but not all.
This bit works:

However, just a bit lower, there are still lines that are mis-marked:

I haven't checked all the lines, but it seems like it has been fixed.

@jakebailey Could you please try<EMAIL_ADDRESS>

Seems like it's working! Thank you!


fix: make feature = "optional_gas_refund" work

Now the is_gas_refund_disabled api is configured by feature optional_gas_refund, but it's never be used.

Would need to reintroduce this for mainnet. But this PR lgtm


error when adding a product variant to the cart a second time, when it does not have product customizations.

Basically we have products with an option for sample or full order. These products are not using product_customizations. The first time you add a sample to the cart it works fine. The second time we get the following error:
undefined method `product_customizations' for {}:Hash
Extracted source (around line #21):
    new_vals = Set.new a
  else
    new_customizations = new_customizations.product_customizations

    # if there aren't any customizations, there's a 'match'
    return true if existing_customizations.empty? && new_customizations.empty?

Rails.root: /Users/jeremy/Development/Rails/designyourwall_spree/dyw_on_rails

I added a guard statement at the top of order_decorator.rb
module Spree
Order.class_eval do
def product_customizations_match(line_item, new_customizations)
  # Guard against items without customizations.
  return true if new_customizations.empty?

  existing_customizations = line_item.product_customizations

It seems to prevent the error and allow the products with the customizations to still work properly.

Spree calls it to check if there's a match, so possibly it should return false in this case? I'm not quite Sure what that Spree API means. But yes it looks like a guard clause is necessary.

Based on the following line
    # if there aren't any customizations, there's a 'match'
    return true if existing_customizations.empty? && new_customizations.empty?

it seems like returning true is what it wants. Returning false creates a new line item while returning true will increment the quantity of the existing line item (more desirable, in my case at least.)

Perfect, I remembered seeing a line about that somewhere. Thank you for the fix and helpful comment; it's such a fiddly extension that comments like that are really useful.


cannot import name 'gen_rule_payload' from 'searchtweets'

Describe the bug
The  'gen_rule_payload' function is not being imported .
---------------------------------------------------------------------------
ImportError                               Traceback (most recent call last)
<ipython-input-11-cc6bdf300b6f> in <module>
----> 1 from searchtweets import ResultStream, load_credentials ,gen_request_parameters , gen_rule_payload

ImportError: cannot import name 'gen_rule_payload' from 'searchtweets' (/home/arnav/.local/lib/python3.8/site-packages/searchtweets/__init__.py)

To Reproduce
from searchtweets import ResultStream, load_credentials ,gen_request_parameters , gen_rule_payload

Expected behavior
I am trying to use the gen_rule_payload to define the rule for my queries.
Environment

OS: [Ubuntu 20.10]
Python version [3.8.5]

Additional context
jupyter-notebook : 6.0.3

Is this for v2 API or v1.1 ?
For v2, make sure https://pypi.org/project/searchtweets-v2/ is installed,
For v1.1 it's https://pypi.org/project/searchtweets/
gen_rule_payload is in https://github.com/twitterdev/search-tweets-python/blob/master/searchtweets/api_utils.py#L86 for v1.1, and this only applies to v1.1 API
For v2, gen_request_parameters serves the same function there: https://github.com/twitterdev/search-tweets-python/blob/v2/searchtweets/api_utils.py#L84

It works , Thanks !


New Theme: Dracula for AutoAO3App

I've coded a Stylus Dracula Theme for AutoAO3App. The app is a project which helps fans run exchanges on archiveofourown.org, but it currently doesn't have a dark mode available.
You can find the repo here: https://github.com/enigmalea/Dracula-For-AutoAO3App

Hey, very cool! ✨
I just sent you an invitation to join the organization.
I also cloned your repository for Dracula's organization, so you can go ahead and delete or archive yours:

Your repository.
New repository.

Thanks for building this! 🎉

Hi there! I've archived my copy of the repo, updated my screenshots and closed the issue over on the Dracula Org Repo, and also merged the image optimization PR. Let me know if there's anything else I need to do.

Thanks! I'll include it later, and it will be on the site soon; Until then, I'll leave this Issue open! 🚀

Hi, the theme is already on the site! Thanks for building this! 🎃


[Req] configurable query path for /announce & /scrape and more options

I found it's hardcoded in server.js

if (s[0] === '/announce') {
..
} else if (s[0] === '/scrape') {
..
error('only /announce and /scrape are valid endpoints')

I think it will be more flexible let user to config the announce path such as to '/', and optionally disable scrapping.

It is possible to set custom paths using the technique described in https://github.com/feross/bittorrent-tracker/issues/58#issuecomment-72343349, and since there's been no PR to support this feature more explicitly, I'm gonna close this issue.
PR still welcome.


Python open or closing parenthesis same 3 snippets

Hello!
When I open or close parenthesis in python I get the following 3 snippets no matter the function:

Can I disable them somehow? I use nvim-cmp. I don't think I had the same problem a couple of days ago.
Thank you in advance.

Ouh, difficult. I think, generally, optimizing completion is something better tackled in cmp_luasnip.
What could be done from luasnips' side is just removing the offending snippets altogether by iterating over luasnip.snippets.python, finding these snippets (via trigger/name) and setting them to nil.

Thanks for the answer. So I guess it's better to open an issue in cmp_luasnip which is responsible for the triggering? Because it doesn't make sense that these snippets are triggered whenever I close or open parenthesis.
I tried to delete it with your suggestion by setting nil the luasnip.snippets.python[66] but I get the following error:
Error detected while processing CompleteChanged Autocommands for "*":                                                                                E5108: Error executing lua ...e/pack/packer/start/cmp_luasnip/lua/cmp_luasnip/init.lua:15: attempt to index local 'snip' (a nil value)
I guess cmp and cmp_luasnip still know about the existence of the snippet and they cannot access it since it is nil.

Oooooh, yeah it probably errors because cmp_luasnip assumes that the table doesn't have holes (which is generally a fine assumption, you could probably move the following snippets up so the hole is filled).
In any case, best open an issue about it in cmp_luasnip, yes :+1: (going to close it here for now)


KEP-19: Versioning for operator packages

What this PR does / why we need it:
By adding a KUDO API version to package indexes, we will avoid that changes to the operator schema will affect existing KUDO versions and package definitions.
Closes #163

Before diving into the implementation details, I wanted to talk about the overall "versioning context". Having KUDO API version indexed, only solve a smaller part of the versioning chaos. Below a scenario that I would like to discuss:
tl;dr:

KUDO API version is part of the repo path e.g. storage.googleapis.com/kudo-repository/v1beta1/
Double semantic versioning: e.g. kafka_2.3.0_1.0.0 where 2.3.0 is Kafka version and 1.0.0 operator
Operator version alone is not unique

#
# The beginning. KUDO API version is v1beta1, only one kafka_2.3.0_1.0.0 operator with kafka 2.3.0 inside:
# ----
/kudo-repository/v1beta1/kafka_2.3.0_1.0.0
                /v1beta1/kafka_2.3.0_1.0.1 // operator update: operator 1.0.0 -> 1.0.1
                /v1beta1/kafka_2.3.0_1.0.2 // yaop update: operator 1.0.1 -> 1.0.2
                /v1beta1/kafka_2.3.1_1.0.3 // kakfa bugfix: kafka 2.3.0 -> 2.3.1, operator 1.0.2 -> 1.0.3
                /v1beta1/kafka_2.4.0_1.1.0 // new minor kakfa version: 2.3.1 -> 2.4.0, operator 1.0.3 -> 1.1.0

# New KUDO API version v1. We need to support at least two last kafka version so they are released with:
# ----
/kudo-repository/v1/kafka_2.3.1_1.0.4 // bumped operator version: 1.0.3 -> 1.0.4
                /v2/kafka_2.4.0_1.1.1 // bumped operator version: 1.1.0 -> 1.1.1

# Both, v1beta1 and v1 repos are suppored. Kafka releases bugfix versions for 2.3.x and 2.4.x.
# We need to update both repos:
# ----
/kudo-repository/v1beta1/kafka_2.3.2_1.0.4 // kafka 2.3.1 -> 2.3.2, operator 1.0.3 -> 1.0.4
                /v1beta1/kafka_2.4.1_1.1.1 // kafka 2.3.1 -> 2.4.0, operator 1.1.0 -> 1.1.1

/kudo-repository/v1/kafka_2.3.2_1.0.5 // kafka 2.3.1 -> 2.3.2, operator 1.0.4 -> 1.0.5
                /v2/kafka_2.4.1_1.1.2 // kafka 2.3.1 -> 2.4.0, operator 1.1.1 -> 1.1.2

# Note: With the above schema we now have two IDENTICAL operator versions 1.0.4, but with DIFFERRENT Kafka versions:
/kudo-repository/v1beta1/kafka_2.3.2_1.0.4
/kudo-repository/v1/     kafka_2.3.1_1.0.4

/cc @mpereira @nfnt @gerred @kensipe

Here is the same scenario from @mpereira (this time for Cassandra) in form of the table which resets operator version Semver every time a new major Cassandra version is released.

We will need an alternative registry for KUDO once this gets implemented as to not break 0.8.0, yeah?

This should not break 0.8.0, as it's only adding field to the index, which is backwards-compatible. However, once there are newer API versions, it becomes a bit more complicated: While operators versions that are compatible with 0.8.0 will still get list in the index, the user needs to explicitly select these versions (using the --version flag, or by directly installing from a tarball URL) to avoid using a newer version that's requiring a newer API.

An alternative would be the have separate URLs for each API version, e.g. https://kudo-repository.storage.googleapis.com/v1 once KUDO is at v1. This way there wouldn't be any of the issues with 0.8.0 described above once KUDO's API is updated.

Ah, yes, I misread the kafka section where it was updated and thought the list changed to a map. That makes sense.
On the surface, I do like the idea of having separate registries for each API version - although this presents a challenge when a user wants to upgrade from one Operator API version to another. I would see that as a major version change inside the same repository, and the KUDO tool could be aware of what API versions it works with and ones it doesn't (which could be useful for CLI tooling).

Been thinking about it for a while, actually I like having separate registries for each API versions a bit more. It would allow use to have backwards-incompatible changes to the repo index in the future.

Big topic.
I think one big topic is:

Is the appVersion optional?

I think it should be, as we've determined that we certainly have use cases where an appVersion doesn't make sense.
In that case, the big question is: Do we case enough about the appVersion to make it a primary part of our versioning, i.e. put the work in to support multiple (non-unique) operator-versions per appVersion.
If yes, the operator developer can still decide to ignore (and leave out) the appVersion and use the operatorVersion as the single source of truth, but it allows us to maintain multiple appVersions on a single operator. How the operator versions under each appVersion is organised is - again - left to the operator developer. She may decide to reset the operator version on each new appVersion, or he might decide to keep a certain schema to operator versions across appVersions. ( i.e. operatorVersion 1.5.x always has certain features, independent of the appVersion)

I've updated the KEP to present the "composite version" approach, as per our discussions. Many of the existing comments are outdated and I resolved them. If anyone feels that this is still not covered here, please unresolve these conversations.

There are still some open questions:

Is appVersion a required field now?

Do we provide a default of "0.0.0" or "" something?
Can we keep it optional, and if so how does a package file would look like?

What do we do when a user does not provide an --appVersion but the repository shows us having multiple appVersions? Do we just require a specified --appVersion in this case? Simple lexicographical ordering does not work.

@mpereira, this makes sense, yes. I'm fine with having a parameter --version that can use a single identifier, though this wouldn't be much different from having an additional --app-version parameter, IMO. We already surface all of these versions to users as part of the Operator, I'm not sure what the difference between this and surfacing a single identifier would be.

@ANeumann82

Do we provide a default of "0.0.0" or "" something?
If appVersion is required, do we need a default? Though, a default would make existing operators without appVersion work with the new schema.
What do we do when a user does not provide an --appVersion but the repository shows us having multiple appVersions? Do we just require a specified --appVersion in this case? Simple lexicographical ordering does not work.
My suggestion is to first try to sort operator versions as semver, then select the latest operator version. If that doesn't work, the installation will be aborted due to ambiguous operator versions and the user will be prompted to also supply an operator version.

Changing appVersion to a required field would make existing packages potentially invalid unless we specify a default.
Parsing the appVersion as semVer and bailing if it doesn't work seems like a reasonable approach, although I would prefer some other solution. But everything I can think of would have a lot more complexity.
One thing to keep in mind when implementing this: We currently generate the operatorVersion CRs from operatorName + operatorVersion. As we're now changing the uniqueness of the operatorVersion, we need to adjust the generated name of the operatorVersion CRs to include the appVersion.  Which will be a breaking change. Additionally, the generated CR name has a limited charset and length, which we need to keep in mind.

@ANeumann82, I agree, making appVersion required is a breaking change. This concern was raised in the team and it was agreed to proceed, given that the current landscape of KUDO operators is still small and we're in v1beta1.
Good point regarding the version in operator names. Let me update the KEP to include this.

Since this KEP is so sensitive, we're waiting on a supermajority of approvals to merge.

Thanks everyone for the healthy discussion and suggestions and helping to get this KEP into shape. I'm merging this now and will have an implementation soon.


cursor blink

Issue Type: Bug
Hey VSCode 🙂
Why is the cursor stop blinking after a while when I've selected other than the default blink?
 For custom animations, which actually run at 60FPS or more, we stop the blinking cursor after about 10 blinks or so. That is to not consume CPU when you are not doing anything (i.e. idle).


other tabs obscured on occasion in ForgeUi

sometimes when using infinite image tab, the other tabs become obscured and not visible in ForgeUi, not always but when it does happen the only way to get back to another tab like text2image, or whatever, is to close and reopen the browser, (happened in firefox and opera gtx)

Update to the latest IIB, and then open this option


Add support for \i and \j

These are non-italic versions of \imath and \jmath that are used in vector notation.

KaTeX_Main-Bold unfortunately contains the wrong glyphs for \i and \j.  This is because makeFF in https://github.com/Khan/MathJax-dev maps two different glyphs to the same code point.  Here are the conflicting lines:

https://github.com/Khan/MathJax-dev/blob/master/fonts/OTF/TeX/makeFF#L667-L668
https://github.com/Khan/MathJax-dev/blob/master/fonts/OTF/TeX/makeFF#L789-L790 (should be removed)


Fix on sharing image URL

This PR intends to fix the issue brought by @CharlyWargnier where thumbnail images aren't showing up when sharing content on twitter

LGTM @imjuangarcia! I had assumed, incorrectly, that we would have to add unique thumbnails to each article page.

That'd be another way to go about it. We have the ability to do that on the website, and default to the logo image when nothing is added. For the docs' site, I feel it's going to be a lot of work, that's why I kept the default image on all pages, but LMK if you prefer otherwise!

In that case, let's not pursue it. There are other eng and content tasks that take precedence.

For sure on the custom images part, maybe we can get an intern to do that


Is it possible to place datasets in a different directory?

Hello,
Thank you for sharing this great repo.
I am using your repo on a remote machine which has two disk partitions home and data. Their volume are 40GB and 1TB respectively, so datasets can't be placed in home. The data requires sudo to create new files or directories. I don't have the sudo password and I have to ask somebody to input it any time I want to make change to data. This makes it inconvenient for training.
My question is: is it possible to place the dataset in data and OpenPCDet repo in home?
Thank you in advance.

Sure. Try ln -s

https://www.cyberciti.biz/faq/creating-soft-link-or-symbolic-link/


Formatted output of date and time variables

I just added the two simple cases for date and time variables, it will take a little more work to add all the numeric types.

I was a bit unsure about the unit test. First I added the new tests to the existing find_value() method, but I later decided to add a new method instead. I hope you don't mind me using a slightly different naming convention there.


Design following recommendation mechanism

We need a mechanism to recommend users to follow.
Some options:

Given semantic scholar link, try to get the most related users from our exiting user base.
If we can compute a user embedding based on their past research, we can return the nearest neighbors.

Need to study the Semantic Scholar API. They compute citing and cited authors. If we have can get these, we can intersect them with our user pool, and identify users to recommend.

After the design, we should create issues to implement it under the current milestone.

Simple process:

Use all available sources to retrieve all papers for the user, and retain the 10 most recent ones.
Embed each one using something like fasttext.
Put all papers from all users in the same space, and somehow compute a recommendation top-k/distribution for each user. The ranking of recommended users is drawn from this set.


Remove OpenXmlPackage.Close and all references

/azp run

/azp run

@twsouthwick the pipeline build ran successfully on these changes but for some reason didn't report back to this PR on github. Can you just do a quick re-review?

/azp run


Ensure bulk edit works properly when changing post statuses

We should create a single action monitor action that contains multiple node id's for this

Moved this to our backlog todo list


MessageReceivedEvent will be triggered when a message is added through code

Describe the bug
When a message is sent to the client (for example calling Player.sendMessage("Hi");) a MessageReceivedEvent is fired, even though it (obviously) shouldn't
To Reproduce
Execute the following code: Player.sendMessage("Hi"); and listen for the onMessageReceived(MessageReceivedEvent event), using a System.out.println(event.getMessage()); to see that the event is fired
Expected behavior
In this case, the event should just not be fired
Screenshots
Will do as soon as possible
Versions:

OS: Windows 10
Java: JDK1_8, JRE1_8
IDE: Eclipse
Commit / Release: 36fb5799

This could probably be fixed by adding a third "addChatMessage...") method to the GuiChat with the boolean "fromClient" (or something like that), call that method from the other one in that class (default set to false) and if false fire the event.
There might be some fancier way to do so though

This could probably be fixed by adding a second "#printChatMessageWithOptionalDeletion()") method to the GuiNewChat with the boolean "fromClient" (or something like that), call that method from the other one in that class (default set to false) and if false fire the event.
There might be some fancier way to do so though

Since there are too many Minecraft classes calling the method, there is no fancier way

This has been fixed in the commit 366f82b


Add archive bytes limit option to config

This sets the max length of the archive in bytes. If the archive grows larger than this limit the archive is trimmed until it satisfies the limit.
For k8s products this limit is 1MiB or 1048576 bytes. If the limit is set to 0 there is no size limit. The archive can grow as large as the retention period.

Made changes per comments:

Dropped the default values as these are none functional. A value has to be provided in config anyway

Changed how the values are treated to the following:

Treat a 0 or 1 in bytes limit as "disable feature"
Treat a 0 in retention period as "disable feature"
Treat < 0 in bytes limit as no limit


SELinux context never gets applied for on MicroOS by the install script

Hello folks, we are testing k3s on MicroOS OpenStack Cloud image, which initializes with cloud-init on Hetzner, see https://github.com/kube-hetzner/kube-hetzner/pull/103. In doing so, found out that if we rely on the k3s install script to install the k3s-selinux RPM - the context actually never gets applied, because of the reboot needed for it to work!
In the following logic, the k3s-selinux RPM installs itself via transactional-update in a new snapshot, then the chcon -u system_u -r object_r -t container_runtime_exec_t ${BIN_DIR}/k3s command fails, and gives a message to reboot, and follows up with the k3s install.
https://github.com/k3s-io/k3s/blob/4b064b5d22ebd1c746763ddbf335a5acda61438a/install.sh#L496-L505
It works, but without SElinux because the context just never gets applied, unless manually applied after rebooting.
What we do now is first install the k3s-selinux RPM manually, reboot, install k3s with the INSTALL_K3S_SKIP_START=true & INSTALL_K3S_SKIP_SELINUX_RPM=true flags, and then apply the chcon command manually. Then start k3s.
Am I correct?

I suspect that this is related to the same failure to apply the policy that is described here: https://github.com/k3s-io/k3s/issues/5183

@brandond It could be, but I do not think so. Everything actually works, unlike in the above issue. It's just that by the logic of the install.sh file, the context will never get applied unless I got it wrong.

I believe that the chcon -u shouldn't be necessary since it's handled by the RPM postinstall once the transactional-update reboot is done. @galal-hussein can you confirm?

If that is the case, then perfect! Also, it's not a problem if k3s starts and runs for a few minutes before it reboots right? SELinux for k3s should still kick in upon reboot, without the need to issue any commands?

This command manually applies the policies, correct? /sbin/semodule -v -i /usr/share/selinux/packages/k3s.pp

I believe the answers to my questions above are Yes and Yes, but please correct me if I am wrong! Thank you and keep up the good work.


Support for standalone --from-env-file

This is a Bug Report

Problem:
--from-env-file argument is not supported.
Here is my step in workflow:
      - name: Create DEBUG secret for env file
        uses: azure/k8s-create-secret@v1
        with:
          namespace: develop
          secret-type: "generic"
          arguments: --from-file=./server/.env
          secret-name: debug-secrets

I get following error:
Run azure/k8s-create-secret@v1
/usr/local/bin/kubectl create secret docker-registry debug-secrets --docker-username  --docker***   -n develop
error: either --from-file or the combination of --docker-username, --docker*** --docker-server is required
Error: Error: The process '/usr/local/bin/kubectl' failed with exit code 1

There is difference in --from-env-file and --from-file hence i cannot use --from-file here.
Proposed Solution:
--from-env-file must work fine

hey @apgapg I want to work on that issue.

/assign

/unassign


Hobo 1.3: support enum_string I18n

When implementing the I18n workaround on enum_string fields described here 1, assumed as official workaround 2, hobo-metasearch stops working. Index page complains with:
undefined method `all' for Human::Htype:Class

where Human::Htype is the name used in the workaround:
# In the model:
class Human < ActiveRecord::Base

hobo_model

Htype = HoboFields::Types::EnumString.for(:real_human,:fake_human)

fields do
  ...
  type   Human::Htype
  ...
  timestamps
end

Nice work!


No error when attempting to create a new account for an email that is already registered

If you fill out the create account for and use an email address that already exists and click submit you are not presented with any information. The home page reloads but no error message is displayed.
Log indicates that its using an HTTP GET instead of DELETE now.

related to #680

@briri I can't test this because of a new bug that doesn't recognize if I tick the box to accept Terms (screenshot below)

displays appropriate error msg now. closing


Add recruiter field, added another func in Jobs, created migration and tests

Added recruiter as FK to jobboard/Job
Created new migration (saved as 0005)
Added a new function that returns all jobs posted by a specific recruiter ("get_jobs_by_recruiter_id")
Added test for that function
Changes recruiter's test - added recruiters saved instances in where they were matched to the expected result

We talked about adding a major field to the Job model.
Maybe wait until #52 is merged and then add a major field based on the Major text choices model in Student.

I think that pytest error might happen because the tests of recruiter are fixture tests, and the tests for job are'nt. As to that, I created an instances of recruiter, and saved it to the db.
It probably fails because of something with the tests of recruiter(?)
I have tried to add recruiter/test.py to the dependencies of 0002, but the test fails (without it, it passes) :\

I think you need to consider the new recruiters you created in the recruiter test functions because they functions will probably be accessing it in the class functions.

please squash the commits

please squash the commits

@guy9050 done :)

I will merge this PR this time, but basically it's too big - next time please divide it to few PR's.


Xbox One, Kodi 19.3.0 - erro no serviço: b'attributeError("module'_winapi' has no attribute 'CreateProcess'")'

Xbox one
Kodi 19.3.0
After doing the initial installation, when restarting kodi, the elementum performs the initialization process, but displays the message " service error: b'attributeError("module'_winapi' has no attribute 'CreateProcess'") '" and does not start.

@jonathansf
search can be used to find the answer - https://github.com/elgatito/plugin.video.elementum/issues?q=is%3Aissue+Xbox

Thank

Thanks @antonsoroko, my scenario is the same as ticket #844  open for  @v-hct, but it's still unresolved.

@jonathansf Xbox cannot run Elementum (that is not a limitation from Elementum). You can run only python based Kodi addons.


New version: Microsoft.Azure.QuickReview version 0.32.2

[ ] Have you signed the Contributor License Agreement?
[ ] Have you checked that there aren't other open pull requests for the same manifest update/change?
[ ] This PR only modifies one (1) manifest
[ ] Have you validated your manifest locally with winget validate --manifest <path>?
[ ] Have you tested your manifest locally with winget install --manifest <path>?
[ ] Does your manifest conform to the 1.5 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

/AzurePipelines run

Hi @stephengillie can you take a look at this one? There was an error and got stuck.
Thanks!


V2 Filtered Search Rate Limit

I am trying to use the v2 filtered search to monitor an handle, but i am getting "Rate Limit Exceeded" almost immediately the stream starts. Here is my code. What am i doing wrong?
           var stream = client.StreamsV2.CreateFilteredStream();

            stream.TweetReceived += Stream_TweetReceived;
            var pars = new StartFilteredStreamV2Parameters();
            pars.ClearCustomQueryParameters();
            pars.ClearAllFields();
            pars.Expansions = new HashSet<string>(new string[] { "in_reply_to_user_id", "author_id","referenced_tweets.id","referenced_tweets.id.author_id" });
            pars.UserFields = new HashSet<string>(new string[] { "created_at", "entities", "id", "name", "username", "in_reply_to_user_id", "profile_image_url" });
            pars.TweetFields= new HashSet<string>(new string[] { "author_id","conversation_id", "created_at","in_reply_to_user_id","referenced_tweets","text" });
            pars.CustomQueryParameters.Add(new Tuple<string, string>( "@", "permabot"));

            try
            {
                await stream.StartAsync(pars);
            }catch(Exception ee)
            {
                Debug.WriteLine(ee.Message);
            }

I know this is a very late response. Though if you managed to find an answer for it, I would be happy to learn what was your solution so that I can help others in the future.

Hi,
Never found a solution.
I had to implement this in nodejs eventually
if you find a solution,let me know too

So the same api (v2) worked for you in node but never worked with Tweetinvi?

Yes

Hi, where can I find the documentation for streamv2, sample and filtered?

@weirdyang Can you send a link for the docs, I can't find them and am confused how to use streamV2

@weirdyang  Yep, It would be helpful if you could share what you've found so that others who are trying to use this library without extensive documentation on the V2 can use it.
And also,
@linvi why there is almost no documentation on your website/github on the V2 filtered streams? Are you planning on adding it ever?

Hi
I based my code off of this comment:
https://github.com/linvi/tweetinvi/issues/1070#issuecomment-704780561
I have uploaded my incomplete but working implementation here:
https://github.com/weirdyang/tweet-stream/blob/main/tweet-stream-lib/Configuration/TweetConfiguration.cs


I would like to be able to analyze 1 minute ticker data for arbitrage opportunities

Create a notebook that generates the analysis framework for looking for arbitrage opportunities based on sample 1 minute candle data.

completed end-to-end test


Change url.query requirement level from recommended to conditionally_required (to match url.path)

Spinning this out from #109 as a separate issue.
Summarizing the discussion:
Pro: this seems like a bug that slipped into https://github.com/open-telemetry/opentelemetry-specification/pull/3355
Con: query is particularly prone to containing sensitive information

from @Oberon00's https://github.com/open-telemetry/semantic-conventions/pull/109#issuecomment-1590688151

it seems OK to be "just" recommended. I think that would allow instrumentations to provide an opt-out option which REQUIRED technically doesn't.

this is an interesting point

when sanitizing sensitive information, would we rather redact the values (i.e. foo=REDACTED&bar=REDACTED) or drop the attribute completely?
My preference is to preserve parameter names, order, etc rather than dropping the whole attribute.
I assume if users write sanitization, they do it as a processor (now) and will take the query attribute, parse, and sanitize individual properties.  If we provide a tracing configuration to sanitize arbitrary values, we'd do something similar.
TLDR: Opting-out needs configuration and this configuration would rather be a regex or a callback to sanitize than a boolean flag (drop/preserve).
Also, I feel we don't need to solve this problem prior to stability: it should not be breaking to switch between recommended vs conditionall_required: when available at any moment.


Complete Deliverables for Intr 0

• Vision *
• User stories (big and detailed ones)
- Big *
- Detailed
• The project plan including the stories’ costs and priorities and the release plan
• Technology choices plus their justification
• A working GitHub account including your discussion track
Itr0.pdf
CodeIgniter: https://www.codeigniter.com/

The user stories now have tables and better formatting.


Deprecated función

In src/main/java/com/baeldung/errorhandling/controllers/MyErrorController.java have a deprecatd function:
warning: [deprecation] getErrorPath() in MyErrorController has been deprecated
    public String getErrorPath() {
                  ^

Hi @WHK102 ,
Yes since 2.3.x version of Spring Boot this method has been deprecated. Our article here https://www.baeldung.com/spring-boot-custom-error-page mentions this explicitly.


Fix build error with kernel 6.1 due to prototype change

Tracked-On: OAM-112944

Android CI has started Engineering Build for this issue ,Please check the linked Tracked-On issue/Android CI Web  for more details.

Android CI has completed Engineering Build for this issue, build is SUCCESS.To merge the changes please click on APPROVE FOR MERGE button in Android CI WEB


Coloring Background is not working

Great panel, but the background coloring does not seem to work.

It used to work prior to last update to 6.7.3. Until yesterday, I was using 6.6.2 and the background color worked properly.

Thrid'ing. Just uncovered this after upgrading to 6.7.3.

Background color does not work on Grafana 7.0.0 either.

... and not on Grafana 7.2.2 and 7.3.1

Sorry all, I wasn't getting notifications for this repo for some reason. I suspect this panel needs to be completely rewritten with the new plugin model to really work as well as intended. I will try to do it before or during the holidays.


isSquare()

Return 1 if the matrix is a square matrix, else return 0

I'd like to work on this

i would like to work on it


bug with addItem

if add position less then firstVisiblePosition, the viewType is error

"... add: 7" is position to add, but it getItemViewType for position 70
getItemViewType add: 7
getItemViewType: 70
getItemViewType add: 8
getItemViewType: 113

Hi @wekin,
Sorry, the issue wasn't clear do you have a example project to share that can reproduce the issue?

@thagikura
FlexboxLayoutManager is not support multiType for adapter well;
it is easy to get error type for a invisible position to add a item;

@thagikura
the test project is https://github.com/wekin/test-flexlayout

Hi @wekin,
Thanks creating the example project!
Now I'm able to reproduce the issue.
I'll take a look.

Should be fixed by #311


Execute @@after_run check only for Ruby >= 2.7

Overview
This block was being run on versions of Ruby that do not generate SimpleCov coverage results, causing an error to be raised on the CI run. This if statement should prevent the errors from being raised.
Also, the rescue has been limited to NameError instead of globally rescuing any exception.

Warnings are still raised for the non-SimpleCov checks, but this PR brings us one step closer. I haven't figured out how to run steps in a workflow conditionally by Ruby version yet.


Removes mapped_id, to fix platforms that require sys_enter and sys_exit

Description
When using sys_enter and sys_exit, mapped_id remained set to the placeholder (-1) which was then used to determine high-level syscall filtering. This results in every event being dropped.
This PR removes mapped_id, in favor of populating or using the existing id.
Checklist

[ ] Investigated and inspected CI test results
[ ] Updated documentation accordingly

Automated testing

[ ] Added unit tests
[ ] Added integration tests
[ ] Added regression tests

If any of these don't apply, please comment below.
Testing Performed
TODO(replace-me)
Use this space to explain how you tested your PR, or, if you didn't test it, why you did not do so. (Valid reasons include "CI is sufficient" or "No testable changes")
In addition to reviewing your code, reviewers must also review your testing instructions, and make sure they are sufficient.
For more details, ref the Confluence page about this section.

cc @kcrane - these changes may affect s390x, could you have a look?


build: experimentally change default innodb_page_size to 32768 for Craft CMS monster rows with too many columns

The Issue
Strictly experimental:

https://github.com/orgs/ddev/discussions/6543

On Craft CMS, it huge field/row/column sizes may require increasing the innodb_page_size
How This PR Solves The Issue
Experiment with this. Note that it will require some additional work as mysql:5.5 and 5.6 don't seems to support this.
Manual Testing Instructions
Try using with mysql 8.0 on a new project. ddev mysql and SHOW GLOBAL VARIABLES LIKE 'innodb_page_size';
Try starting an existing project, should stay at default
Automated Testing Overview
mysql 5.5/5.6 will fail
Release/Deployment Notes
New projects created this way (or deleted and recreated) will have the new value. It shouldn't affect existing projects.

I would vote against this, because most hosts aren’t going to have the same setting. It’s better to find out you’re running against a database limit while developing locally, then to think everything is fine until you try to deploy to production.

…or at least it should be something the developer has to explicitly opt into, knowing the risks.

@brandonkelly 's argument is good, and this is probably not something that DDEV should be solving, as suggested also in https://github.com/orgs/ddev/discussions/6543
Closing this for now.


⚠ Samsung has degraded performance

In a2f7492, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 2155 ms

Resolved: Samsung performance has improved in 6b04d7c.


[Incremental] Write build record & test

Adds BuildRecordInfo to hold information needed to read and write build records. Writes build records whether incremental or not. Reads when incremental. Tests reading and writing.

@swift-ci please test

@swift-ci please test

@swift-ci please test

@swift-ci please test

@swift-ci Thanks, @owenv , for your help. I think I've fixed the problems. Would you like to take another look?

@swift-ci please test

@swift-ci please test


api permissions for binstar upload

I've created a token on an organisation with "api:write,api:read" permissions and a sufficient long expiration time. However during "binstar -t $NEW_TOKEN upload ..." binstar states, it does not have the api:read permission.
 [Unauthorized] Authentication token does not have the sufficent scope to perform this action expected: api:read

Willing to provide more info if needed.
Thanks for looking into this!

okay syntax of --scopes is "api:read api:write"


Saving activity with changes

Hi guys,
in fact this is a question rather than bug or error. How can I implement changes when i use activity helper. For instance :
$order = .....
activity('order-activity')
            ->by(auth()->user())
            ->on($order)
            ->withProperty('order_id', $order->id)
            ->withChanges() // Is it possible ??
            ->tap(function (Activity $activity) use ($order) {
                $activity->parent_id = $order->id;
            })
            ->log('Order ##LINK## has been updated');

as you notice ->withChanges() was added by me but I wonder any method or way to implement it.
Thanks in advance.
Cheers.

Hey,
not this way but it is - see below:
First, this is the point where the auto-logging trait magic happens https://github.com/spatie/laravel-activitylog/blob/2e451503a02ba98067de0f56a51ea7ceaf45487d/src/Traits/LogsActivity.php#L35-L38
like you see it utilises the DetectsChanges:: attributeValuesToBeLogged() method https://github.com/spatie/laravel-activitylog/blob/2e451503a02ba98067de0f56a51ea7ceaf45487d/src/Traits/DetectsChanges.php#L80-L112 this method is public so you can use it everywhere.
The solution would be:
activity('order-activity')
    ->by(auth()->user())
    ->on($order)
    ->withProperties($order->attributeValuesToBeLogged())
    ->withProperty('order_id', $order->id)
    ->tap(function (Activity $activity) use ($order) {
        $activity->parent_id = $order->id;
    })
    ->log('Order ##LINK## has been updated');

To let this work your Order model has to implement at least the DetectsChanges trait - the LogsActivity would be optional.
warning: the withProperties() overrides the properties, the withProperty() just puts the given one in. So if you want to use withProperties() multiple times you will have to merge them before collect()->merge() or you split them in withProperties() and multiple withProperty() calls.

@Gummibeer thanks for that m8. I did implement as you suggest but now it throws
Call to undefined method App\\Models\\Order::eventsToBeRecorded()
exception. Any idea?

Ok, you discovered something like a bug 👍 😂
The DetectsChanges trait has a direct dependency on the LogsActivity one (your first exception). The attributeValuesToBeLogged() method requires a $processingEvent - this is the name of your model event. Most times this will be created, updated or deleted. https://laravel.com/docs/5.8/eloquent#events
The eventsToBeRecorded() contains all 3 of these events https://github.com/spatie/laravel-activitylog/blob/2e451503a02ba98067de0f56a51ea7ceaf45487d/src/Traits/LogsActivity.php#L85-L102
To prevent duplicate logs - if you don't want the auto created ones I recommend to set protected $enableLoggingModelsEvents = false.
But after all this, if you want to log all these events (or just a set of these) have you checked this: https://docs.spatie.be/laravel-activitylog/v3/advanced-usage/logging-model-events#tap-activity-before-logged-from-event
You can log model events automatically and manipulate the Activity model before it's saved in the tapActivity() method (should be placed in the Order model).
This would reduce your work to 2 lines in this method:
class Order extends Model
{
    use LogsActivity;

    public function tapActivity(Activity $activity, string $eventName)
    {
        $activity->properties = $activity->properties->put('order_id', $this->getKey());
        $activity->description = 'Order ##LINK## has been updated';
    }
}

@Gummibeer :). What I want is maybe so specific lol. BTW I did again implement what you suggest but now got another exception which is
App\\Models\\Order and Spatie\\Activitylog\\Traits\\LogsActivity define the same property ($enableLoggingModelsEvents) in the composition of App\\Models\\Order. However, the definition differs and is considered incompatible. Class was composed
What I did is remove helper from controller.
public function update(Request $request, $id)
   {
       $order               = app(Order::class)->where('minja_id', $id)->firstOrFail();
       $order->mc_status_id = $request->mc_status_id;
       $order->save();

       return response()->json(['message' => 'success']);
   }

And modified Model as below
class Order extends Eloquent
{
    use LogsActivity;

    protected $enableLoggingModelsEvents = false;

    protected static $logAttributes = ['mc_status_id'];

.
.
.
.
.
.

/**
     * Spatie Activity
     * @param \Spatie\Activitylog\Models\Activity $activity
     * @param string $eventName
     */
    public function tapActivity(Activity $activity, string $eventName)
    {
        $activity->properties = $activity->properties->put('order_id', $this->getKey());
        $activity->description = 'Order ##LINK## has been updated';
    }
}

thanks for your time again!

Ok, this is something php related that you can't override trait properties.
But if you want to use the auto-logging you even don't need to disable it. Because you want to let the trait log all defined events. So remove the $enableLoggingModelsEvents property.
Otherwise you can set it in the construct.

Thanks @Gummibeer . I used another way to achieve what I want. Cheers.

Thanks @Gummibeer . I used another way to achieve what I want. Cheers.

Can you please share it? I am also looking same solution.


prepare release 2.0.4

Codecov Report

Merging #5891 into 2.0 will decrease coverage by 0.06%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##                2.0    #5891      +/-   ##
============================================
- Coverage     82.97%   82.91%   -0.07%
+ Complexity    11764    11763       -1
============================================
  Files          1390     1390
  Lines         45397    45397
  Branches       5614     5614
============================================
- Hits          37670    37641      -29
- Misses         5111     5140      +29
  Partials       2616     2616

Impacted Files
Coverage Δ
Complexity Δ

core/src/main/java/io/crate/Version.java
71.42% <100%> (ø)
12 <0> (ø)
:arrow_down:

...n/java/io/crate/exceptions/JobKilledException.java
0% <0%> (-66.67%)
0% <0%> (-1%)

...ion/aggregation/impl/GeometricMeanAggregation.java
59.09% <0%> (-22.73%)
11% <0%> (ø)

...o/crate/analyze/SafeExpressionToStringVisitor.java
83.33% <0%> (-16.67%)
7% <0%> (-1%)

...crate/executor/transport/TransportShardAction.java
72.97% <0%> (-13.52%)
8% <0%> (-1%)

.../distributed/TransportDistributedResultAction.java
66.15% <0%> (-12.31%)
8% <0%> (-1%)

core/src/main/java/io/crate/types/ShortType.java
80.76% <0%> (-11.54%)
16% <0%> (-3%)

...crate/planner/projection/MergeCountProjection.java
63.63% <0%> (-9.1%)
5% <0%> (-1%)

...in/java/io/crate/lucene/match/CrateRegexQuery.java
73.91% <0%> (-8.7%)
8% <0%> (-1%)

...io/crate/planner/projection/ProjectionVisitor.java
35.29% <0%> (-5.89%)
6% <0%> (-1%)

... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c997564...e70cd93. Read the comment docs.


Infinite scroll page would not trigger emojiParse

So I have infinite scroll page when it reach the bottom, it will load additional page.
like $(window).scroll( function()  { getData(); getEmojiParse(); }
function getEmojiParse() {$("#SourceText").emojiParse({})};
The emojiParse only works on the first preloaded page but won't trigger again when the second loaded page comes up.
I don't understand why I can re-initiate javascript again. I put alert in the emojiParse() and it seems to alert that it went through emoji Parse but don't seem to load :laugh:.
Please help!
Still loving your emoji!
Thanks in Advance!

I don't really understand what you mean, but I believe after the additional page been loaded, you should manually call scripts, it will work.


Enhancement: use content steps for creating new files in spfx tour upgrade report

In the SPFx project upgrade CodeTour report, we should use content steps to provide instructions for creating new files. Right now we fallback to package.json line 1 because the file to be created doesn't exist yet and the tour step needs a file.

Hi @waldekmastykarz, is it possible that this enhancement is already implemented. During my testing I noticed the tour points towards a "virtual" file named CodeTour when the user needs to create a new file.

Started to dig a bit deeper to check when it was introduced, which seemed to be PR #1708

Good catch! In that case, let's close this issue. Thank you for looking into it @Jwaegebaert 👏


support for osx-arm64 ?

There currently is not a pypandoc conda package that works on the new macos machines with M1 chips (osx-arm64). I tried to add pypandoc to the automatic osx-arm64 migrator to generate one (https://github.com/conda-forge/pypandoc-feedstock/issues/16), but it appears that this package can't be automatically migrated for some unknown reason. I am not familiar enough with this repo to understand the problem, but it appears that this might be related to the fact that this wrapper to pandoc downloads pandoc binaries, and that perhaps there isn't an osx-arm64 binary available.
In any case, I would really like to use this package on the new macs, so if anyone knows the origin of this problem, please speak up!

@MarkWieczorek
from this issue it seems like there are available pandoc pandoc builds for the m1.
Can you try the folliwing:

Install pypandoc with pip
Try to install pandoc through pypandoc by importing it and running pypandoc.download_pandoc()

Please lety me know what result you have with the above, and if you get any error output from conda in general

Installing pypandoc with pip seemed to work ok (no errors).
However, the second part didn't work:
In [1]: import pypandoc

In [2]: pypandoc.download_pandoc()
[INFO] Downloading pandoc from https://github.com/jgm/pandoc/releases/download/2.18/pandoc-2.18-macOS.pkg ...
[INFO] Unpacking pandoc-2.18-macOS.pkg to tempfolder...
x .
x ./usr
x ./usr/local
x ./usr/local/bin
x ./usr/local/bin/pandoc
x ./usr/local/bin/._pandoc
x ./usr/local/._bin
x ./usr/local/share
x ./usr/local/share/man
x ./usr/local/share/man/man1
x ./usr/local/share/man/man1/pandoc.1
x ./usr/local/share/man/man1/._pandoc.1
x ./usr/local/share/man/._man1
x ./usr/local/share/._man
x ./usr/local/._share
x ./usr/._local
x ./._usr
[INFO] Copying pandoc to /Users/lunokhod/Applications/pandoc ...
[INFO] Making /Users/lunokhod/Applications/pandoc/pandoc executeable...
[INFO] Copying pandoc-citeproc to /Users/lunokhod/Applications/pandoc ...
[ERROR] Didn't copy pandoc-citeproc
Traceback (most recent call last):
  File "/Users/lunokhod/.conda/envs/test310/lib/python3.10/site-packages/pypandoc/pandoc_download.py", line 152, in _handle_darwin
    shutil.copyfile(src, dst)
  File "/Users/lunokhod/.conda/envs/test310/lib/python3.10/shutil.py", line 254, in copyfile
    with open(src, 'rb') as fsrc:
FileNotFoundError: [Errno 2] No such file or directory: '/var/folders/n2/f1yzwck529q90x_3y32txg640000gn/T/tmpshop3zjz/tmp/usr/local/bin/pandoc-citeproc'
[INFO] Done.

And here is the conda output
(test310) ➜  ~ conda install pypandoc
Collecting package metadata (current_repodata.json): done
Solving environment: failed with initial frozen solve. Retrying with flexible solve.
Solving environment: failed with repodata from current_repodata.json, will retry with next repodata source.
Collecting package metadata (repodata.json): done
Solving environment: failed with initial frozen solve. Retrying with flexible solve.
Solving environment: -
Found conflicts! Looking for incompatible packages.
This can take several minutes.  Press CTRL-C to abort.
failed

UnsatisfiableError: The following specifications were found to be incompatible with each other:

Output in format: Requested package -> Available versions

and just to make sure. The result from pypandoc.download_pandoc() doesn't actually put pandoc in the "/Users/lunokhod/Applications/pandoc" folder?

It did put the pandoc executable in that folder, and the executable seems to work (./pandoc --version didn't fail...)

That's interesting.
So it seems like it's not a m1 error. But as you pasted above, it seems to get a FileNotFoundError, which should be handled correctly, if pandoc citeproc isn't present...
I'll look into it

@MarkWieczorek  the output from conda doesn't actually show what's wrong, just that it's failing.
From what I've gathered:

There are m1 builds available of pandoc, wich pypandoc are indeed downloading
The traceback in handle_darwin is expected

I'll try to see if I can add mac m1 to the ci here, before I say that this is an upstream issue.

hey @MarkWieczorek  as you can see from the testing added in #267  it seems to be an anaconda issue, not so much a pypandoc issue.

I'm not sure how travis ci tests work with macos, but its possible that they are being run on intel macs.

as you can see from this link I've set the travis build to be run on macOS 12.3, macOS 11.6 and macOS 10.15.7.
So form my understanding, since it's running macOS Big Sur, it should be running on m1 macs, right?

In "normal" times that would be ok. But, every 10 years apple decides to screw with us an make new hardware that runs on new chips that are incompatible with the old ones. Generally, this occurs 5 years before they come out with a new charging port for iphones.
The past 10 years, macs have used intel chips, but about a year or so ago they started selling macs that use their own "M1" chip. "Big sur" runs on both of them. To be honest, I haven't figured out how to run CI tests using the two different chips...

aha... I'll see if I can make it report if it's running on inten or m1 chips

@MarkWieczorek  as it turns out, you were right.
While it's running Big Sur, it's actually still running on intel chipsets.
TravisCI doesn't at the time of writing support MacOS M1 machines, so I have no way of testing pypandoc on M1 architecture

So the error is, that you are getting a "FileNotFoundError" when trying to install pandoc through PyPandoc.
The interesting part it, we do check for "FileNotFoundError" so don't know why you are getting this.

I don't know how to fix this... sorry!


Comment out concurrency since GH seems broken here

Problem
GH actions do not run because error in concurrency statements
Change overview
Comment those line out
Testing
CI will validate this.

Seems to have fixed itself. Closing PR


toggle control-sidebar with jquery

Hi,
how can I toggle control sidebar with jquery without clicking on something. I want after success close the control sidebar

To collapse the control sidebar, remove the CSS class control-sidebar-open from its <aside> container.

$($.AdminLTE.options.sidebarToggleSelector).click();


add support for scons

add support for scons

Cool. Would you mind adding a test for SCons as well?

I'm not 100% familiar with the test environment and I got about halfway through before I thought I should ask for advice.
I've written a few SConstruct files based on the Makefiles provided, and I started modifying /spec/build-spec.js but I'm not sure I'm on the right track. Is build-spec.js automatically generated?
Also... Ideally, I need to run scons with a few extra flags compared to normal:
scons -sc distclean -f SConstruct.escape
This is because scons generates a checksum file, and ideally it would be nice to clean that up after each test.
What are your thoughts?

It looks good! build-spec.js is not automatically generated, so what you're doing is the right thing.
It appears as the SConstruct.escape file (and the defined variable) is never used. Should it be removed?
Each test is run in a new clean directory which is removed after the test is done. Are the checksum files kept in a global state or would they be removed along with the directory?

Cool thanks for the advice :)
I hadn't got around to using  SConstruct.escape yet. I'll keep
working on it.
The checksum files are OK to let the framework remove. I just thought I had
to tidy up after myself, but if the framework does it, that's even better.
Thanks Alexander!
On 9 April 2015 at 15:57, Alexander Olsson<EMAIL_ADDRESS>wrote:

It looks good! build-spec.js is not automatically generated, so what
you're doing is the right thing.
It appears as the SConstruct.escape file (and the defined variable) is
never used. Should it be removed?
Each test is run in a new clean directory which is removed after the test
is done. Are the checksum files kept in a global state or would they be
removed along with the directory?
—
Reply to this email directly or view it on GitHub
https://github.com/noseglid/atom-build/pull/54#issuecomment-91123171.

--
Adam "carneeki" Carmichael
p: +61 415 37 1990
w: http://bigneek.com
e<EMAIL_ADDRESS>i: 2207644

Any updates on this?

Closing this out. Please re-open if you wish to finish this PR.


Issues with tooltip.showDelay

I was really waiting for a tooltip.showDelay option, so first, thanks for adding it!
But, I have two issues with it though. They're not bugs, it's how it works/reacts.

What was always bugging me a little, was that when hovering a chart and triggering the tooltip, the tooltip sort of 'flies' from the last location where it was visible. I think this is not really bad per se, but when triggering the tooltip for the first time, it flies from the bottom right corner right to your mouse cursor. This looks a little weird, and when placing a small chart (like a sparkline) at the very right side of your page, it triggers a horizontal scrollbar for a very short instance. What I hoped was when using the showDelay options, the tooltip flies to the correct location (your cursor) in the background (invisible), thereby skipping the flying animation, and then pops up (fades in) after the specified showDelay time. However it just delays the flying animation.

The other thing is that when using the showDelay option, it not only delays the initial trigger time (which is correct behaviour) it also delays the tooltip while it's already triggered and you're hovering over multiple datapoints. Which is not correct behaviour I think. I want to delay the tooltip a little, so it doesn't trigger every time you move your mouse over the chart (because that's kind of annoying if you have lots of charts on a page). But once it's triggered, it should act like it normally would; without a delay. It makes it look/behave kind of unresponsive, and is enough reason for me to not use showDelay.

Hi @JeffreyRoosendaal , thanks for the advise firstly.
About the second one. At first we add showDelay because in some case developer will add link in the tooltip. And without showDelay user may be hard to enter the tooltip and click the link since the tooltip will always move beside the mouse position. So we add a showDelay to avoid that situation.
I agree that it is really annoying. But i can't figure out a better way. And suggestions are always welcome. Thanks again:)


Add 3.9 job

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] Breaking change (change that would cause existing functionality to not work as before)
[x] New feature (non-breaking change which adds functionality)

Description

Add Python3.9 testing.
How has this been tested?

No.
Closes

closes #299

I had to install some release candidates tomae numba on 3.9 work, see https://github.com/numba/llvmlite/issues/669.
Apart from that, it works on 3.9 (only Napari tests fail, it's being dealt with in #302 ).


rpm: gvforwarder subpackage

This commit places the gvforwarder binary in a new gvforwarder subpackage. This subpackage will be a hard dependency for podman as its required in FCOS. This subpackage will also be a hard dependency for the main package to preserve upgrade path.

@baude we'll need to have gvisor-tap-vsock have a hard dependency on gvforwarder to preserve the files installed as we're moving the gvforwarder out of the main package. Will not affect fcos as the main package won't get pulled in.

@baude I'll build gvisor and podman (https://github.com/containers/podman/pull/19953) with these changes on Fedora, so you can use them on fcos asap. We should get these PRs in as well before the next release for packit to not blow things up.

/approve
/lgtm


test: copy address in identity component

Thank you for your contribution to the KodaDot NFT gallery.
👇 _ Let's make a quick check before the contribution.
PR type

[ ] Bugfix
[ ] Feature
[ ] Refactoring

What's new?

[x] test case for this bug https://github.com/kodadot/nft-gallery/issues/3851

Before submitting Pull Request, please make sure:

[x] My contribution builds clean without any errors or warnings
[x] I've merged recent default branch -- main and I've no conflicts
[x] I've tried to respect high code quality standards
[x] I've didn't break any original functionality
[ ] I've posted a screenshot of demonstrated change in this PR

Optional

[ ] I've tested it at </rmrk/collection/26902bc2f7c20c546a-1FVG7>
[ ] I've tested PR on mobile and everything seems works
[ ] I found edge cases
[ ] I've written some unit tests 🧪

Had issue bounty label?

[x] Fill up your KSM address: Payout

Community participation

[x] Are you at KodaDot Discord?

Screenshot

[ ] My fix has changed something on UI; a screenshot is best to understand changes for others.

@preschian tried to run this in GUI, got this on all tests:
Timed out retrying after 10000ms: Expected to find element: .tippy-popper, but never found it.
tried to run it locally in terminal, got this on all tests:
Error: Browser context management is not supported. 🤔

hhmm, let's try again

@preschian tried to run this in GUI, got this on all tests: Timed out retrying after 10000ms: Expected to find element: .tippy-popper, but never found it.

I put the config to disabled auto scroll on GUI. sometimes GUI auto scrolls to the bottom, so the test couldn't find the popover component

tried to run it locally in terminal, got this on all tests: Error: Browser context management is not supported. 🤔

on headless, try to run with --browser chrome. currently I use clipboard API for chrome only because on the pipeline e2e runs with chrome. and cypress have different clipboard APIs for electron https://github.com/cypress-io/cypress-example-recipes/blob/master/examples/testing-dom__clipboard/cypress/e2e/permissions-spec.cy.js#L11
I also change the 3d user to a non-3d user. maybe because sometimes it takes longer to render 3d assets

all good now, just a sidenote: I found out that if you have previously copied something to your clipboard at windows, and you run this in GUI, it's going to try to paste whatever is in your clipboard into the app. Weird, but not a problem.


Manipuliation transition component activation

// Describe the purpose of the pull request here and remove this line. Keep the checklist.
Checklist
The following aspects have been respected by the author of this pull request, confirmed by both pull request assignee and reviewer:

Changelog update (necessity checked and entry added or not added respectively)

[x] Pull Request Assignee
[ ] @maximilianpilz
[ ] @antipovi

README update (necessity checked and entry added or not added respectively)

[x] Pull Request Assignee
[ ] @maximilianpilz
[ ] @antipovi

replace

// Describe the purpose of the pull request here and remove this line. Keep the checklist.

in the initial comment


Moved IEnhancedRandom Methods to Extensions Methods, Misc Reorganization

Changes

Split the elements of IEnhancedRandom.cs out into their own files

BitExtensions -> BitExtensions.cs
IEnhancedRandom -> Generators/IEnhancedRandom.cs
AbstractRandom -> Generators/AbstractRandom.cs

Moved IEnhancedRandom and AbstractRandom to the ShaiRandom.Generators namespace
Removed some methods from IEnhancedRandom and AbstractRandom, and instead implemented them as IEnhancedRandom extension methods

Located in new file: Generators/IEnhancedRandomExtensionMethods.cs

End State/Goal
This PR focuses on two areas:

Creating a more consistent and manageable organizational structure
Attempting to limit the amount of repetitive work someone has to do to implement IEnhancedRandom without using AbstractRandom

Since EnhancedRandom.cs was getting to be a huge file, I figured it made sense to pull it out into components, especially as I would have ended up adding another class to it.  I was unsure on what namespace IEnhancedRandom should actually belong in, however since IEnhancedDistribution was in the Distributions namespace, it seemed that IEnhancedRandom in the Generators namespace made the most sense to me.
As for moving things to extension methods, I tried to adhere to the following guidelines:

If a method had to do with the actual method of generating a primitive (int, byte, bool, or otherwise), serialization, or state setting/initialization, I left in in IEnhancedRandom.
If a method instead took a primitive that was generated and did some useful transformation or check on it, I moved it to an extension method.  A non-inclusive list of things moved and why:

NextBool(float): Doesn't have to do with how to generate a random number; this method is simply an if-check around the result of a NextFloat call
NextSign(): Doesn't directly have to do with how to generate a number; rather takes a number generated adheres to the IEnhancedRandom contract, and generates a 1 or -1.
MinIntOf, MaxIntOf, and similar: These don't have to do with how to generate numbers; simply reporting results
NextNormal, NextTriangular: This is a method of taking numbers generated via the IEnhancedRandom contract for generating primitive numbers, and applying a particular distribution.

In short: methods that have to do with, or in some implementation could reasonably have to do with, how to generate a random number from a state stayed on the interface.  Wrappers around such methods moved to extensions.
The idea is that this will prevent someone from having to re-implement these methods even if they need to implement IEnhancedRandom from scratch without the help of AbstractRandom.  A good use case for this is KnownSeriesRandom, which is bugged due to its usage of new right now; and I would advocate that the best fix for that IMO would be to have KnownSeriesRandom implement IEnhancedRandom instead of inheriting from AbstractRandom.  In the previous implementation, this would require KnownSeriesRandom to implement  22 methods in addition to what it does right now; most of which would be completely non-sensical for KnownSeriesRandom to be implementing.  After this PR, it would only require manually implementing SetWith().  In fact, SetWith could technically be implemented as an extension as well; but I didn't do so in an effort to adhere strictly to my above criteria for an initial pass.
Please feel free to let me know what you think; if you don't like the extension methods or think certain things should or shouldn't be moved to extension methods, feel free to discuss and I can adapt the PR.  This is meant largely as a demonstration of what an extension method implementation could look like, as well as a starting point for a discussion on what to move.

I believe I've covered everything mentioned; let me know if I missed anything!


[crypto] remove snarkydef (part 3/3 to remove snarky AST)

the other side of https://github.com/o1-labs/snarky/pull/763
builds on top of https://github.com/MinaProtocol/mina/pull/12347

!ci-build-me

!ci-build-me

moving to https://github.com/MinaProtocol/mina/pull/12370


MAINT: prepend underscore to mask_to_limits; delete masked_var.

See issue #585

Looks good to me. I verified the ddof=1, is correct. Will merge in a day or so if no one comments.

Great! I'll continue working on gh-2914 once this is merged. In the meantime, I will try to get the ball rolling with the other issues that have already been indirectly addressed to some extent.

@aeklant tip for future commits: if you add "closes gh-xxxx" in the commit message, then the corresponding issue gets closed automatically.

Merged, thanks Abraham.

@rgommers noted. Thanks for the tip.


Icon not shown for custom context menu items

@Jaiganeshkumaran Can you please provide more details such as the app version and the context menu you are referring to here?

I'm referring to the custom context added by applications. I am running the latest version of Files UWP cloned from GitHub (0.10.2).
Files UWP:

File Explorer:

This has not been implemented yet, merging with #174.

This has been implemented with #1754.


The is_public setting for services appears to be ignored

I tried creating a service using the API but it seems to be ignoring the is_public setting.
I've also tried making it public by hand and then fetching services and I don't see it in the JSON. Is it just not supported?
I'm running cabotapp/cabot:0.11.16 Docker image.

Doesn't look like it - feel free to submit a PR
https://github.com/arachnys/cabot/blob/master/cabot/rest_urls.py#L50

So I guess the same goes for email_alert, which also appears to be ignored.

Based on the PRs currently open it doesn't seem like it has a high chance of getting merged.
Example: https://github.com/arachnys/cabot/pull/672

I have attempted to make this change in https://github.com/status-im/cabot/commit/6841f8f7 by adding is_public and email_alert but is_public works, but email_alert appears to have no effect. Not sure why that is.

I opened the PR: https://github.com/arachnys/cabot/pull/700
But I don't know why email_alert has no effect.


Re-implement count_aggregate() with weights.

Closes #14
Closes #11

Note, join_clause is no longer part of the MappingTable interface, because count_aggregate() always uses an equi-join.

Small update to the docs to make the isolated count_aggregate() function in tables_long.R more closely match the docs for the R6 class method of the same name and have explicit parameters to benefit from Rstudio's parameter pop-up helper. Great update!

Oh goodness - I keep forgetting about bare count_aggregate() now that we have MappingTable$count_aggregate()...
At any rate, thanks for the edits and review!


Installer: No message shown when starting already-installed Liana-managed bitcoind

During installation, if the user chooses a Liana-managed Bitcoin node and a Liana-managed bitcoind is already installed (e.g. from having created a wallet on a different network), no message is shown while bitcoind is starting:

In the case of a newly installed bitcoind, "Starting..." is shown:

Adding to v3 roadmap, should be relatively trivial to fix.


Search Bar is getting scrolled with the attendees list

On the Attendees page, search bar is getting scrolled with the attendees list. It must be fixed at its position.

@niranjan94 Shall we put it in the toolbar? Just like action bar search view in android.

@mariobehling @niranjan94 Is this fine- fixing search bar in toolbar?

@mejariamol sure ... make a PR


Bézier curves | Curved line

Points and Lines are first-class objects in mafs. I think curved lines should also be first class objects (I see an example on Bézier curves, perhaps there's a way to exact the curved lines from there, but it looks quite complicated).

It would be pretty easy to support Bézier curves since SVG supports them. Would just have to transform the control points into the coordinate space.

I see, this is really useful information. If I have any free time I'll look into this issue.


Suggested settings still break traditional sorting systems.

Tried this on a server, it absolutely breaks sorting systems, no matter what the tick speed or the items per transfer are set to. Items delete themselves from existence.

Hi! Could you tell me what MC version you're using, what your storage system looks like, and any other mods you're using? Thanks!

The version is 1.20.1. The storage system in question is exactly like in this video by Voltroxhttps://www.youtube.com/watch?v=PVzWp8QHkL0)
The only other mods being used are a few that fix issues with lighting, cpu and memory issues. then Plasmo Voice for prox chat. Everything else is client side, which shouldn't affect anything.
I am only OP for the server, so I don't have an exact list of the mods, but I assume none of those would have adverse affects on this mod.

sry for shittalk in there. but can you release your mod for Forge too ?

sry for shittalk in there. but can you release your mod for Forge too ?

no plans to do so right now.


(WIP) fix PairwiseFusion docs

Closes https://github.com/avik-pal/Lux.jl/issues/130

Why is this draft?

I was going to add tests for it, but I don't have time to do it right now.


I believe I have found the issue, or at least it works.
the default entrypoint ( dind script in this case ) expects to run a command ( as the last command is exec $
If, on the devcontainer.json I set overideCommand:false then vscode cannot execute the commands ( which are failing ).
For example, it cannot do uname -m or cat /etc/passwd
When I, however set overideCommand:true then it works as vscode can execute the pre-fly commands to determine x.y.z attributes
I feel I can close this issue now, however, I feel it is related to the extension as it is an extension setting vs the actual container itself.
Thanks anyway !!

FAO @bamurtaugh @chrmarti

When adding it as a feature, its entrypoint should be run also when not overriding the command. How are you adding it?
	"features": {
		"docker-in-docker": "latest"
	}

When adding it as a feature, its entrypoint should be run also when not overriding the command. How are you adding it?
	"features": {
		"docker-in-docker": "latest"
	}

Adding the script and then RUN it


[az containerap service create] add support for milvus dev service

This checklist is used to make sure that common guidelines for a pull request are followed.
Related command

General Guidelines

[ ] Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
[ ] Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)

For new extensions:

[ ] My extension description/summary conforms to the Extension Summary Guidelines.

About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

az containerap service create

Recommend title: [containerapp] az containerapp service milvus: Add support for milvus dev service
Here is the guidance: Format PR Title

@zhoxing-ms could you please take a look. thank you.

Can we reopen this PR given it was reverted and we need to have Milvus CLI ready for Ignite?


Add reference to pyenv back to fix the broken link on README

Description
Add back a link reference that got accidentally removed at the migration.
Issues Resolved
N/A
master

This branch

Just an FYI you do have permissions to branch out directly here on the cookbook and don't have to maintain a fork 👍


Android - Add namespace

Thank you for this contribution, but I don't have any time to maintain this package, so it is now marked as discontinued and app_links recommended replacement.


fix import error: cannot import name 'MEDSPACY_DEFAULT_SPAN_GROUP_NAME'

Bug:
Concurrent installation of medspacy and quickumls results in:
ImportError: cannot import name 'MEDSPACY_DEFAULT_SPAN_GROUP_NAME' from 'quickumls.constants'
when trying to run the first cell of 11a quickumls medspacy notebook.
Comparison with medspacy installation without quickumls installation revealed additional line on constants.py.
Fix:
add MEDSPACY_DEFAULT_SPAN_GROUP_NAME in constants.py

Thanks!


feat: Expose includes variable to actions

@gagoar please could you take a look at this?

@gagoar please could you take a look at this?

Thanks! looking...

Leaving it open till the end of day. Releasing on Friday!


Ensure the TLS min version is 1.2

The default is 1.1 which is deprecated & insecure
Details: https://github.com/projectcontour/contour/issues/2777
/kind good-first-issue

@tcnghia do we have any broader guidance here around compatibility?

Hey @mattmoor , can i give it a shot?

Awesome yeah!
/assign @guacamole

@dprotaso just wanted to make sure the repo to fork will be  projectcontour /contour and not  knative-sandbox /net-contour

@dprotaso Also, if i should remove the deprecation warning set by #2777 ?

@guacamole hey - this issue is for setting the default in this repository since some installations could be running older contours where it defaults to TLS 1.1

@dprotaso Also, if i should remove the deprecation warning set by #2777 ?

I'd reach out to the contour folks for any of the upstream work

/lifecycle frozen
Ping @dprotaso

/lifecycle frozen
Ping @dprotaso

Looks like we'll get this for free in contour 1.11
https://github.com/projectcontour/contour/issues/2777#issuecomment-756424691

Looks like we'll get this for free in contour 1.11
https://github.com/projectcontour/contour/issues/2777#issuecomment-756424691


Add Visual Studio Clang-CL build to CI

deleteWillNotThrowAnExceptionWhenDeletingUnallocatedMemoryButCanStillCauseTestFailures hangs so I disabled memory leak detection.

Coverage remained the same at 99.64% when pulling b409c6a2fb415043597c9bbc3444a3ce84c57b88 on thetic:vs-clang into c18f0c003ad30cff02a13f785c43241599769120 on cpputest:master.


Egress Controls

As a cluster operator running NGINX Gateway Fabric
I want to redirect egress traffic to another location within my organization
So that I can scan and potential block outgoing traffic that does not fit our organizations policies
And so that I can prevent data exfiltration.

@mpstefan Do you have any progress to share on this ?