Revert #3312 "Prevent dup consumers on same client cnx with shared subscrip

This reverts commit 231db030b9529737237721059b2a5b3044d4cab1.
<--
Contribution Checklist

Name the pull request in the form "[Issue XYZ][component] Title of the pull request", where XYZ should be replaced by the actual issue number.
Skip Issue XYZ if there is no associated github issue for this pull request.
Skip component if you are unsure about which is the best component. E.g. [docs] Fix typo in produce method.

Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.

Each pull request should address only one issue, not mix up code from multiple issues.

Each commit in the pull request has a meaningful commit message

Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.

(The sections below can be removed for hotfixes of typos)
-->
(If this PR fixes a github issue, please add Fixes #<xyz>.)
Fixes #
(or if this PR is one task of a github issue, please add Master Issue: #<xyz> to link to the master issue.)
Master Issue: #
Motivation
Explain here the context, and why you're making that change. What is the problem you're trying to solve.
Modifications
Describe the modifications you've done.
Verifying this change

[ ] Make sure that the change passes the CI checks.

(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)

Added integration tests for end-to-end deployment with large payloads (10MB)
Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:
If yes was chosen, please highlight the changes

Dependencies (does it add or upgrade a dependency): (yes / no)
The public API: (yes / no)
The schema: (yes / no / don't know)
The default values of configurations: (yes / no)
The wire protocol: (yes / no)
The rest endpoints: (yes / no)
The admin cli options: (yes / no)
Anything that affects deployment: (yes / no / don't know)

Documentation

Does this pull request introduce a new feature? (yes / no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
If a feature is not applicable for documentation, explain why?
If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

@lovelle This fix has some issue. a subscribe is identified by "sub-name" + "topic-name".
Would like to revert this change.

@jiazhai can you describe more on why you revert this commit? this would give context for other reviewers to review.
@lovelle please also review and discuss with @jiazhai why reverting this.

@sijie @lovelle Here is the error that user reported:

subscribes with different topic-name and same subscribe-name should get different subscribe, but it returns same subscribe instance.

@jiazhai @sijie Oh sorry! I apologize for this inconvenience.
@jiazhai is absolutelly right about this issue, I already have a bugfix with tests exploiting what is described here.
ASAP I will post a pr with the fix and tests if you agree.
Sorry again.

@sijie  @jiazhai #3746 should fix this issue, could you please take look?
Thanks!

@lovelle Thanks for the fix in #3746.
If it is reasonable for original use case(1 client has several share consumer with same subscribe), we may need to how to fix the original issue.
And also seems current way of fix leaks the check for pattern subscribe.

rerun java8 tests

close this issue for more discussion please reference pr #3746


[Bug] OpenFGA returning 500 on ListObjects

Hello, we are testing OpenFGA for a project and had some issues with the list_objects (normal) endpoint. Not missing data but server error.
Our tested model is as follows:
type organization
  relations
    define admin as self
    define editor as self or admin
    define member as self or viewer
    define viewer as self or editor
type type_1
  relations
    define owner as self
    define editor as self or owner
    define viewer as self or editor
type type_2
  relations
    define owner as self
    define editor as self or owner or editor from parent
    define viewer as self or editor or viewer from parent
    define parent as self

Server setup as the documentation shows for postgres engine:
docker network create openfga
docker run -d --name postgres --network=openfga -e POSTGRES_USER=postgres -e POSTGRES_PASSWORD=password postgres:14
docker run --rm --network=openfga openfga/openfga migrate --datastore-engine postgres --datastore-uri 'postgres://postgres:password@postgres:5432/postgres?sslmode=disable'
docker run --name openfga --network=openfga -p 3000:3000 -p 8080:8080 -p 8081:8081 openfga/openfga run --datastore-engine postgres --datastore-uri 'postgres://postgres:password@postgres:5432/postgres?sslmode=disable' --listObjects-max-results 50000  --listObjects-deadline 360s

First we added a user as admin of an organization ORG1: {"user": "user_1","relation": "admin","object": "organization:ORG1"}
We then performed 600 iterations of adding 25 tuples: {"user": "type_1: UUID_1","relation": "parent","object": "type_2:UUID_n"}
and 1 tuple giving members of ORG1 "editor" relation to each type_1 element: {"user": "organization:ORG1#member", "relation": "editor", "object": "type_1:UUID_1"}.
This created 600 type_1 elements and 15000 type_2 elements where each type_1 element is parent of 25 type_2 elements
When we tried listing the objects of type_2 that some user has by using the list_objects endpoint with {"type": type_2,"relation": "editor","user": "user_1"} we get the 15000 ids but if we try listing with a "viewer" relation rather than "editor" {"type": type_2,"relation": "viewer","user": "user_1"} we get a 500 response.
In the server we get the error:
2022-10-26T15:50:17.700Z        INFO    db_stats        {"method": "Check", "reads": 50, "writes": 0}
2022-10-26T15:50:17.700Z        INFO    db_stats        {"method": "Check", "reads": 38, "writes": 0}
2022-10-26T15:50:17.701Z        INFO    db_stats        {"method": "Check", "reads": 50, "writes": 0}
2022-10-26T15:50:17.702Z        INFO    db_stats        {"method": "Check", "reads": 32, "writes": 0}
2022-10-26T15:50:17.702Z        INFO    db_stats        {"method": "Check", "reads": 50, "writes": 0}
2022-10-26T15:50:17.702Z        INFO    db_stats        {"method": "Check", "reads": 29, "writes": 0}
2022-10-26T15:50:17.703Z        INFO    db_stats        {"method": "Check", "reads": 38, "writes": 0}
2022-10-26T15:50:17.710Z        INFO    db_stats        {"method": "Check", "reads": 38, "writes": 0}
2022-10-26T15:50:17.710Z        INFO    db_stats        {"method": "Check", "reads": 26, "writes": 0}
2022-10-26T15:50:17.710Z        ERROR   check_error     {"error": "postgres error: context deadline exceeded"}
github.com/openfga/openfga/pkg/logger.(*ZapLogger).ErrorWithContext
        /home/runner/work/openfga/openfga/pkg/logger/logger.go:80
github.com/openfga/openfga/server/commands.(*ListObjectsQuery).internalCheck
        /home/runner/work/openfga/openfga/server/commands/list_objects.go:233
github.com/openfga/openfga/server/commands.(*ListObjectsQuery).performChecks.func1
        /home/runner/work/openfga/openfga/server/commands/list_objects.go:207
golang.org/x/sync/errgroup.(*Group).Go.func1
        /home/runner/go/pkg/mod/golang.org/x/sync@v0.0.0-20220601150217-0de741cfad7f/errgroup/errgroup.go:75
2022-10-26T15:50:17.710Z        INFO    db_stats        {"method": "Check", "reads": 11, "writes": 0}
2022-10-26T15:50:17.710Z        INFO    db_stats        {"method": "Check", "reads": 11, "writes": 0}
2022-10-26T15:50:17.710Z        INFO    db_stats        {"method": "Check", "reads": 32, "writes": 0}
2022-10-26T15:50:17.710Z        ERROR   check_error     {"error": "rpc error: code = Code(4000) desc = Internal Server Error"}
github.com/openfga/openfga/pkg/logger.(*ZapLogger).ErrorWithContext
        /home/runner/work/openfga/openfga/pkg/logger/logger.go:80
github.com/openfga/openfga/server/commands.(*ListObjectsQuery).internalCheck
        /home/runner/work/openfga/openfga/server/commands/list_objects.go:233
github.com/openfga/openfga/server/commands.(*ListObjectsQuery).performChecks.func1
        /home/runner/work/openfga/openfga/server/commands/list_objects.go:207
golang.org/x/sync/errgroup.(*Group).Go.func1

Second step by step population of the database and listing:

With 50 type_1 worked returning 1250 type_2 ids
With 100 type_1 worked returning 2500 type_2 ids
With 150 type_1 worked returning 3750 type_2 ids
With 200 type_1 worked returning 5000 type_2 ids
With 250 type_1 worked returning 6250 type_2 ids
With 300 type_1 worked returning 7500 type_2 ids
With 350 type_1 worked returning 8750 type_2 ids
With 400 type_1 stoped working for viewer relation but for "editor" relation returned the 10000 ids.
Then we jumped to 750 type_1 elements and the "editor" listing failed too.

@fschulte-eiwa could you please build/run the main branch and confirm if this has been fixed with #315?

@fschulte-eiwa awesome! These changes will go out in our next release v0.2.5. Keep an eye out for that release notice. It'll probably be coming soon.

Do you have a date on when v0.2.5 is coming out? I am trying to evaluate openfga and this one is a blocker.

@wma1729 we'll cut the v0.2.5 release next Monday. Keep an eye out for the announcement.


PR: Fix debugging unsaved files

Description of Changes

Depends on https://github.com/spyder-ide/spyder-kernels/pull/369

Issue(s) Resolved

Fixes #16417.
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct:

@impact27, the tests in test_mainwindow.py started to hang randomly on Windows after PR #17205. Could you check that?
Also on Windows, test_ipythonconsole.py::test_set_elapsed_time started to fail frequently after that PR. Please skip it for that OS.

I think this is ready. I'll merge the corresponding PR in spyder-kernels and resync the subrepo here before merging.


Update dead link in README.md

Fixed dead link to HTable documentation, and pointed it directly to the appropriate method

Thanks, merged.
By the way, at some point I'll have to revamp the project to use 1.0 API as H-Something classes are now all deprecated. It means dropping support for 0.94 and 0.98, but I guess it's about time.


Getting the type of a transform returns the parent class.

Hi,
As discussed on Slack, type(my_builtin_transform) returns the parent class, i.e. <class 'PyOpenColorIO.Transform'> and not BuiltinTransform.
Currently using something like that for comparing, which is not super elegant: transform.getTransformType() == ocio.TransformType.TRANSFORM_TYPE_BUILTIN
Cheers,
Thomas

Hey Thomas,
I've been meaning to try to start digging into the OCIO backend a bit and finally have some extra time in my schedule. I started taking a peek at this issue (that Colab notebook you put in Slack was super helpful), and on a first glance it seems to me like it might be related to some quirks with polymorphism in PyBind where it might be binding to an incorrect pointer type. Just to confirm, we would be looking to be able to do a more standard typing functionality like type(transform) == ocio.TransformType.TRANSFORM_TYPE_BUILTIN, like what seems to be possible for all other transforms, correct?
I'd be happy to try to give this a shot in the near future if someone could assign me to it.
Best,
Frankie

Hey Thomas,
I've been meaning to try to start digging into the OCIO backend a bit and finally have some extra time in my schedule. I started taking a peek at this issue (that Colab notebook you put in Slack was super helpful), and on a first glance it seems to me like it might be related to some quirks with polymorphism in PyBind where it might be binding to an incorrect pointer type. Just to confirm, we would be looking to be able to do a more standard typing functionality like type(transform) == ocio.TransformType.TRANSFORM_TYPE_BUILTIN, like what seems to be possible for all other transforms, correct?
I'd be happy to try to give this a shot in the near future if someone could assign me to it.
Best,
Frankie

Assigning to you @frankieeder , thanks for your help!

Assigning to you @frankieeder , thanks for your help!

Thanks for your help @frankieeder . The goal would be to support this:
type(transform) == ocio.BuiltinTransform
Where it returns the Transform child class. Please note that there is some code in place in https://github.com/AcademySoftwareFoundation/OpenColorIO/blob/master/src/bindings/python/PyOpenColorIO.h which supports Transform type downcasting in pybind11 via polymorphic_type_hook. This results in behavior like iterating a GroupTransform returning it's various child *Transform instances instead of all parent Transform instances.

Thanks for your help @frankieeder . The goal would be to support this:
type(transform) == ocio.BuiltinTransform
Where it returns the Transform child class. Please note that there is some code in place in https://github.com/AcademySoftwareFoundation/OpenColorIO/blob/master/src/bindings/python/PyOpenColorIO.h which supports Transform type downcasting in pybind11 via polymorphic_type_hook. This results in behavior like iterating a GroupTransform returning it's various child *Transform instances instead of all parent Transform instances.

Got it! Thanks for the additional detail as well, looking into it now.

Got it! Thanks for the additional detail as well, looking into it now.

@frankieeder there are some additional clues in related issue #1254

@frankieeder there are some additional clues in related issue #1254

To consolidate issues, here's what I wrote for #1254:
check it:

import PyOpenColorIO as ocio

group_transform = ocio.Config().getProcessor(
...         BuiltinTransform("ARRI_ALEXA-LOGC-EI800-AWG_to_ACES2065-1")
...     ).createGroupTransform()

print(f"Looks as expected: \n\n", group_transform)

Looks as expected:
<GroupTransform direction=forward, transforms=
<LogCameraTransform base=10, logSideSlope=0.24719 0.24719 0.24719, logSideOffset=0.385537 0.385537 0.385537, linSideSlope=5.55556 5.55556 5.55556, linSideOffset=0.0522723 0.0522723 0.0522723, linSideBreak=0.010591 0.010591 0.010591, direction=inverse>
<MatrixTransform direction=forward, fileindepth=unknown, fileoutdepth=unknown, matrix=0.6802055051062792 0.2361366016064812 0.08365789328723973 0 0.08541497974214032 1.017470878607042 -0.1028858583491822 0 0.002056521669296831 -0.06256250038479215 1.060505978715495 0 0 0 0 1, offset=0 0 0 0>>
however...

print("[type(xf) for xf in group_transform])

[<class 'PyOpenColorIO.Transform'>, <class 'PyOpenColorIO.MatrixTransform'>]
As you can see, the second transform "unpacks" as a MatrixTransform instance, but the first transform is an instance of PyOpenColorIO.Transform -- meaning, none of the expected LogCameraTransform attributes or methods are attached to the instance.

To consolidate issues, here's what I wrote for #1254:
check it:

import PyOpenColorIO as ocio

group_transform = ocio.Config().getProcessor(
...         BuiltinTransform("ARRI_ALEXA-LOGC-EI800-AWG_to_ACES2065-1")
...     ).createGroupTransform()

print(f"Looks as expected: \n\n", group_transform)

Looks as expected:
<GroupTransform direction=forward, transforms=
<LogCameraTransform base=10, logSideSlope=0.24719 0.24719 0.24719, logSideOffset=0.385537 0.385537 0.385537, linSideSlope=5.55556 5.55556 5.55556, linSideOffset=0.0522723 0.0522723 0.0522723, linSideBreak=0.010591 0.010591 0.010591, direction=inverse>
<MatrixTransform direction=forward, fileindepth=unknown, fileoutdepth=unknown, matrix=0.6802055051062792 0.2361366016064812 0.08365789328723973 0 0.08541497974214032 1.017470878607042 -0.1028858583491822 0 0.002056521669296831 -0.06256250038479215 1.060505978715495 0 0 0 0 1, offset=0 0 0 0>>
however...

print("[type(xf) for xf in group_transform])

[<class 'PyOpenColorIO.Transform'>, <class 'PyOpenColorIO.MatrixTransform'>]
As you can see, the second transform "unpacks" as a MatrixTransform instance, but the first transform is an instance of PyOpenColorIO.Transform -- meaning, none of the expected LogCameraTransform attributes or methods are attached to the instance.

Where it returns the Transform child class. Please note that there is some code in place in https://github.com/AcademySoftwareFoundation/OpenColorIO/blob/master/src/bindings/python/PyOpenColorIO.h which supports Transform type downcasting in pybind11 via polymorphic_type_hook

Looks like adding LogCameraTransform and BuiltInTransform in there would solve this.

Where it returns the Transform child class. Please note that there is some code in place in https://github.com/AcademySoftwareFoundation/OpenColorIO/blob/master/src/bindings/python/PyOpenColorIO.h which supports Transform type downcasting in pybind11 via polymorphic_type_hook

Looks like adding LogCameraTransform and BuiltInTransform in there would solve this.

Good catch @remia . That's definitely the issue here.

Good catch @remia . That's definitely the issue here.

Thanks for the pointers all - I'm on it now (I've had some issues getting my dev environment set up). This is my first time contributing to OCIO, so I'm wondering if it would also be worth writing some Python tests per the contributing guide, and if so, whether I should include those and the patch on the same branch.

Thanks for the pointers all - I'm on it now (I've had some issues getting my dev environment set up). This is my first time contributing to OCIO, so I'm wondering if it would also be worth writing some Python tests per the contributing guide, and if so, whether I should include those and the patch on the same branch.

Adding tests in the same PR would be great. Thanks!

Adding tests in the same PR would be great. Thanks!

Opened #1260 for review!

Opened #1260 for review!

Closing as this was fixed in PR #1277.


Fix broken link in Readme

Description

Fixes # (issue)
Checklist

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I wrote unit tests for my code (if tests is required for my changes)
[ ] I have made changes in CHANGELOG.md file

Hi!
Did you test it? Current link is correct and works fine, but your suggestion is not.
Docker hub image is avtodev/markdown-lint

Hi @jetexe Yeah I tried here: https://github.com/bzah/git-training/actions/runs/1805127705/workflow
However, I only tried the second suggestion below #Or using current repository as action:
I though both links were broken but should have tried the first one as well !

Oh. I see. You brake part with docker image, but fix github action

My apologies, you are absolutely right


jade :markdown filter warning

I'm getting the following warning when I use :markdown with a jade view:
Transformers.markdown is deprecated, you must replace the :markdown jade filter, with :marked and install jstransformer-marked before you update to<EMAIL_ADDRESS>It looks like the jade filters are being separated out into another transformers package.
How will this be handled going forward -- and what should I do to suppress/handle the existing warning message?

Hi! You may want to open an issue at https://github.com/jadejs/jade , as Jade is not a part of Express, just another templating engine that can be used with Express :)

To anyone landing here from searching, all you need to do is install the transformer.
This worked for me:
npm install --save jstransformer-markdown

@Vestride -- can confirm that works!


Error for Site Owner: Invalid Domain for Site Key

with my phishlet i have made everything seems good but in the corner it says
Error for Site Owner: Invalid Domain for Site Key
and when i hover over the login button the loading icon loads over and over
any ideas

modified evilginx
https://youtu.be/CpR9lA81NzM?si=xy9HFmAg1Z0FTE5z


⚠ Bofrost.de has degraded performance

In 4aa25df, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1412 ms

Resolved: Bofrost.de performance has improved in e3790c3.


Please support SharedWorker.

Search Terms
SharedWorker
Checklist
My suggestion meets these guidelines:

[x] This wouldn't be a breaking change in existing TypeScript/JavaScript code
[x] This wouldn't change the runtime behavior of existing JavaScript code
[x] This could be implemented without emitting different JS based on the types of the expressions
[x] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)
[x] This feature would agree with the rest of TypeScript's Design Goals.

This does not seem to be a valid feature request as it does not contain all the required information from the template.
Likely duplicate of #24323

SharedWorker


Returned image buffer has Red and Blue channels swapped [b, g, r, a]

Expected Behavior
Image buffer should be in the format [r, g, b, a]
Current Behavior
Image buffer is in the format [b, g, r, a]
Possible Solution
Change how the internals read the buffer or flip the channels before returning to user
Context
When using this library with other modules like sharp it's expected that raw formats are [r, g, b] or [r, g, b, a]. This weird color channel setup makes it annoying to use with other image manipulation tools.

Images are in bgra because thats the preffered format for 99.999% of GPUs, so when they take the frame buffer, they keep the format.


Refactor nft fractionalisation pallet

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: cargo-check-benches
Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2188897

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: cargo-check-benches
Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2188896

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: cargo-check-benches
Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2193251

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: cargo-check-benches
Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2193250

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: cargo-check-benches
Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2198339

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: cargo-check-benches
Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2198338

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: cargo-check-benches
Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2202744

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: cargo-check-benches
Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2202743

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: cargo-check-benches
Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2207390

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: cargo-check-benches
Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2208512

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: cargo-check-benches
Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2208626

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable
Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2212546

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable
Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2212544

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable
Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2212545

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable-int
Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2213065

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable
Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2213058

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable-int
Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2213583

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable-int
Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2213631

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable-int
Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2213796

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: cargo-check-benches
Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2216720

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: cargo-check-benches
Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2217384

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: cargo-check-each-crate-macos
Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2226018

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable
Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2226005

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: cargo-check-benches
Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2226001

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: cargo-check-benches
Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2226000

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable
Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2226006

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: cargo-check-each-crate
Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2226016

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: cargo-check-each-crate
Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2226015

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable-int
Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2226011

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: cargo-check-benches
Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2227247

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: cargo-check-benches
Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2286306

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: cargo-check-benches
Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2308689

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable-int
Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2319848

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: cargo-check-benches
Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2319838

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: cargo-check-each-crate
Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2319852

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable
Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2319841


php sdk and codedeploy asg instance iam policy in cfn-init for enabling infrastructure describes

this is to provide main php codedeploy app with aws stack resources metadata details

duplicate


Password request - did not go through password setup.

I ran the update and it is requesting a password but it didn't go through the password setup. now i can't open switch...

Sorry about this, we'll try to investigate further!
Two possibilities I can think of: Switch is showing you the enter password screen when it shouldn't, or Switch somehow encrypted that config when it shouldn't.
Switch stores a configuration file locally with all your credentials and state, which is encrypted using the password (if you used an earlier version that didn't require a password, it's supposed to prompt to set a password). This file is in your home directory: on Mac, /Users/<username>/.switch/config.json, or on Windows, C:\Users\<username>\.switch\config.json. (To show this hidden folder, on macOS Sierra or later, press Cmd+Shift+. in Finder; on Windows 10, select "Show hidden files" within Windows Explorer)
Could you try to find that file and email it to me at<EMAIL_ADDRESS>If you configured any cards on mainnet, before sending it to me, make sure to remove your private keys from the file! Create a copy of that config.json file, open it in a text editor and search for your private keys, secrets, and/or LND credentials and remove them (just leave the quotes that surround them). If it turns out the file was mistakenly encrypted, searching the file won't find them, because they're encrypted within the ciphertext.


Set dataZoom.fillerColor is no use.

Version
4.2.1
Steps to reproduce
dataZoom: {
fillerColor: 'rgba(167,183,204,0.4)',
borderColor: 'rgba(167,183,204,0.4)'
}
What is expected?
The color of selected dataZoom changes into rgba(167,183,204,0.4).
What is actually happening?
But it's still the default grey.

I checked and the colors changed. Maybe it's just because 'rgba(167,183,204,0.4)' looks like gray. You may use 'red' to make it more visible.
If it doesn't work, please provide a demo based on https://jsfiddle.net/ovilia/yh76w9Lt/5/

In slider dataZoom it's ok but in rect-select circumstance it seems no use:( Or i use it in wrong way?

@0lddriv3r Can you provide an image to show what do you mean?

Just in the official example: dataZoom.
I change the toolbox option like that:
toolbox: {
        show: true,
        feature: {
            dataZoom: {
                yAxisIndex: 'none',
                fillerColor: 'red'
            }
        }
    }

And after i click the button of dataZoom and select an area, it's also the defualt grey:

Did i use it wrong?

There is no toolbox.feature.dataZoom.fillerColor. And dataZoom.fillerColor is worked for this part:

I didn't find an option for this.

Oh got it. But how could i change the color in my Area-dataZoom demo above？

As I said, I didn't find an option for your requirement. Maybe you should try changing the source code.

OK thank u so much! I'll try it


minDate and MaxDate not working

i tried the following code, but not working
var options = {
date: new Date(),
minDate :new Date(2012,12,12),
maxDate :new Date(2016,12,12),
mode: 'date'
};
        datePicker.show(options, function(date){
        alert("date result " + date);
        });

Is there any error in logs or console?

I can confirm, min and maxdate won't work on Android, but on iOS. I use moment.js to generate a specific JS-Date-Object.
            $scope.minDate =  moment().locale('de').subtract(90, 'years').toDate();
            $scope.maxDate =  moment().locale('de').subtract(13, 'years').toDate();

            var options = {
                date: new Date(),
                doneButtonLabel: $scope.trans.SET,
                cancelButtonLabel: $scope.trans.CLOSE,
                doneButtonColor: '#f39200',
                cancelButtonColor: '#000',
                minDate: $scope.minDate,
                maxDate: $scope.maxDate,
                mode: 'date'
            };

Thank you for your support. Let me try this solution
-----Original Message-----
From: "Hirbod"<EMAIL_ADDRESS>Sent: 25-02-2015 08:42 AM
To: "VitaliiBlagodir/cordova-plugin-datepicker"<EMAIL_ADDRESS>Cc: "harikrishnan992"<EMAIL_ADDRESS>Subject: Re: [cordova-plugin-datepicker] minDate and MaxDate not working (#60)
I can confirm, min and maxdate won't work on Android, but on iOS. I use moment.js to generate a specific JS-Date-Object.
$scope.minDate =  moment().locale('de').subtract(90, 'years').toDate();
$scope.maxDate =  moment().locale('de').subtract(13, 'years').toDate();
        var options = {
            date: new Date(),
            doneButtonLabel: $scope.trans.SET,
            cancelButtonLabel: $scope.trans.CLOSE,
            doneButtonColor: '#f39200',
            cancelButtonColor: '#000',
            minDate: $scope.minDate,
            maxDate: $scope.maxDate,
            mode: 'date'
        };

—
Reply to this email directly or view it on GitHub.

There is no solution. Just confirmed your bug

@VitaliiBlagodir anny suggestion why min and maxdate are broken on Android, while they work fine on iOS?

maxDate and minDate work on Android for me if I do Date.parse(new Date()) but not on iOS

Thanks for your inout @Yuripetusko, this is at least a good way to provide a fallback! Thank you very much. I've just installed Cordovas Device Plugin to check the system. Not really happy with that overhead, but at least, it works fine!

This is my solution in coffeescript that works both on iOS and Android
maxDate = if ionic.Platform.isIOS() then new Date() else (new Date()).valueOf()

I use OnsenUI, but they also have a platform detection. Thanks for the hint!

Thanks @Yuripetusko, Your hint worked for me !
Used device.platform to check for OS being iOS or Android.

As identified here:
http://forum.ionicframework.com/t/ngcordova-datepicker-show-twice/16158/11
minDate is a Date object for iOS and an integer for Android, so you need to account for that when using the plugin.  For example, with Ionic Framework, do something like this:
minDate = ionic.Platform.isIOS() ? new Date() : (new Date()).valueOf();

datePickerOptions = {
  date: new Date(),
  minDate: minDate,
  mode: 'date'
};

Someone should mention this inside of the documents. @VitaliiBlagodir

While updating the documentation, can you change "integer" to "millisecond precision unix timestamp"? I was struggling until I found this issue because I was using second precision unix timestamps.

This is the sort of thing that cordova is supposed to shield the user from. It should be consistent across both platforms.

How to format the date from "Mon Mar 04 2019" to "03/04/2019".Thanks.

@jenkinssgs moment("Mon Mar 04 2019").format("MM/DD/YYYY")

@jenkinssgs moment("Mon Mar 04 2019").format("MM/DD/YYYY")


Async support

The API functions are marked as async, but they use a synchronous HTTP client (minreq) internally. Do you plan on using an async HTTP client in the future?

When the macros were created they were async using reqwest, the change to minreq was made to lower dependencies. I think in the future the minreq client could be a feature flag and reqwest become the main client?

This would probably be the best option.


Proper generation of c# enums using the the OpenAPI 3.x spec

Thanks for contributing to Swashbuckle.AspNetCore! As per the contributing guidelines, please adhere to the following rules of thumb before submitting your issue:

If it's not a bug report, feature request or PR, don't submit it here. Post to Stackoverflow instead.
If your issue is specifically a UI concern, don't submit it here. Post to the swagger-ui repo.
For bug reports, specify the version your using and provide clear repro steps.

I'm using Swashbuckle.AspNetCore -Version 5.0.0-rc4
In my case I have the following issue:
I have a C# enum defined like so:
public enum ObjectState
{
Unchanged = 0,
Add = 1,
Update = 2,
Delete = 3
}
This get represented in the OpenAPI 3.x doc as
"components": {
"schemas": {
"ObjectState": {
"enum": [
0,
1,
2,
3
],
"type": "integer",
"format": "int32"
},
When I run the NSwag client generator all it has as a reference is the OpenAPI spec which of course is missing the name portion of the enum.  NSwag generates the following object for the client which is basically unusable:
public enum ObjectState
{
    _0 = 0,
    _1 = 1,
    _2 = 2,
    _3 = 3
}

Would it be possible to use oneOf from the OpenAPI spec instead to properly represent a C# enum
See the discussion here:
https://github.com/OAI/OpenAPI-Specification/issues/681
According to handrews the spec is not going to be changed regarding this issue and suggested using something like the following from the OpenAPI spec to represent the enum.
oneOf:

enum: [1]
title: Sunny
description: Blue sky
enum: [2]
title: Cloudy
description: Slightly overcast
enum: [3]
title: Rainy
description: Take an umbrella with you

Thoughts?  Work arounds???
Much appreciated
Kevin

I see there is a solution to this problem using Swashbuckle.AspNetCore.Filters  so I'm closing.

Can you provide solution?

@RouR I use the following (would require a little tweaking to yield the original ask above):
[DataContract]
public enum MyEnum {
  [EnumMember(Value="red")]
  Red,
  [EnumMember(Value="blue"]
  Blue
}

The filter itself:
public class DescribeEnumMemberValues : ISchemaFilter
    {
        public void Apply(OpenApiSchema schema, SchemaFilterContext context)
        {
            if (context.Type.IsEnum)
            {
                schema.Enum.Clear();

                //Retrieve each of the values decorated with an EnumMember attribute
                foreach (var member in context.Type.GetMembers())
                {
                    var memberAttr = member.GetCustomAttributes(typeof(EnumMemberAttribute), false).FirstOrDefault();
                    if (memberAttr != null)
                    {
                        var attr = (EnumMemberAttribute) memberAttr;
                        schema.Enum.Add(new OpenApiString(attr.Value));
                    }
                }
            }
        }
    }

And in your Startup, register the filter with:
services.AddSwaggerGen(c => {
  c.SchemaFilter<DescribeEnumMemberValues>();
});

The resulting enum will be described using the values within the EnumMember attribute values instead of their indices.

I wish there was a better way to do this, but using WhitWaldo solution I came up with this.  I like it a bit more because it uses the Description attribute.
And in your Startup, register the filter with:
services.AddSwaggerGen(c => {
  c.SchemaFilter<DescribeEnumMemberValues>();
});

public enum ConfidenceEnum
{
    [Description("Very xx")]
    Very = 1,

    [Description("SomeWhat xx")]
    SomeWhat,

    [Description("Low xx")]
    Low
}

public class DescribeEnumMemberValues : ISchemaFilter
{
    public void Apply(OpenApiSchema schema, SchemaFilterContext context)
    {
        if (context.Type.IsEnum)
        {
            var dictionary = Enum.GetValues(context.Type)
                .Cast<object>()
                .ToDictionary(value => (int)value, value => GetEnumDescription((Enum)value));
            schema.Description = "Enum values:" + string.Join(", ", dictionary.Select(x => $"{x.Key} = {x.Value}"));
        }
    }

    private static string GetEnumDescription(Enum value)
    {
        var fi = value.GetType().GetField(value.ToString());

        if (fi == null) return value.ToString();
        var attributes = (DescriptionAttribute[])fi.GetCustomAttributes(typeof(DescriptionAttribute), false);

        return attributes.Length > 0 ? attributes[0].Description : value.ToString();
    }
}

It produces this:
"ConfidenceEnum": {
                "enum": [
                    1,
                    2,
                    3
                ],
                "type": "integer",
                "description": "Enum values:1 = Very xx, 2 = SomeWhat xx, 3 = Low xx",
                "format": "int32"
            }


Add Jam (listentojam.com) to User Agents

Thanks - can you fix the invalid json?  Need to use \\ instead of \ inside json strings.

@johnspurlock sorry about that — should be fixed

Sorry, I didn't make of note of which repo this PR was for.  Most folks still submit PRs to the old repo.
I actually added user-agents-v2 support for Jam earlier today thinking it was a port of this PR, not a conflict!
Since it's already included, going to close this PR out.  Thanks again!


lightbox functionality

I'm adding this now because it cropped up in the discussion about additional plugins for the editor e.g. there is a lightbox plugin which uses lightbox2 http://lokeshdhakar.com/projects/lightbox2/
However although I think including that plugin would be useful and I think we might even have it or similar e.g. as part of the hotspot editor functionality I think it would also be good to replicate this functionality elsewhere e.g.

Allow an author to add text, icon or image links on a page which when clicked open up a lightbox and ideally not just an image and caption but if possible an html popup like we have in the hotspot image connector as an option.
In a tool like Articuate storyline it's possible to add a lightbox link to any slide/page which opens one of the other slides as a lightbox slide over the top of the existing slide. I'm not sure how easy this would be to achieve in Xerte but in the xot template we have a sequence of pages and it would be good to allow users to replicate this feature from Storyline in Xerte so that a single page with all its functionality could be opened over the top of any other page via a lightbox link.
If we think 2 is possible then perhaps even making use of the hide page functionality so that as authors any page that we intend to use as a lightbox could be hidden from the normal linear navigation and list of pages but that when linked as a lightbox page still displays to the viewer. This can be useful for help screens, note taking screens etc or just more dynamic and less linear pulling of content by the learner.

Perhaps for further discussion during the developer days.

Forgot to link to this issue from commit: https://github.com/thexerteproject/xerteonlinetoolkits/commit/0baba6887f76ef3072855a7b6d6abad1ebf1c527

Hmmm found this one too @ronm123. Now that the lightbox plugin is 99% complete (i hope) should we combine these perhaps into a new issue and see what is still outstanding and required and we can perhaps take a look at them with fresh eyes and having 3+ years of additional developments to bounce off?

@JohnSmith-LT yes I think it probably is worth combining this and #758 into a new issue and then closing the old ones. As I originated both those issues leave it with me and I'll put on my to do list to close the old issues and create a new one in time for our next dev day if not sooner. Some of this overlaps with what we had on the meeting agenda and discussed during the last meeting and obviously directly with what you've enabled via the editor plugin too.

Item no. 3 in Ron's list has just been committed - are the others done? Can we close this?

Closing as most of the issues have been dealt with & those that haven't are in issue #758


 While the test coverage for these new features is at 100%, I'm not yet considering them stable. I kindly request the community's help in testing these features with real-world scenarios.
Your feedback is invaluable in identifying any potential issues and ensuring the reliability of these functionalities. Please report any bugs or unexpected behaviors you encounter.
Thank you for your support and contribution to improving this project!

v6.1.0-beta.1 now support OCO Orders


Modify the yaml file to make it more readable

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Modify the file according to the recommended yaml file format。
Modify the yaml file to make it more readable

Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
None

/assign @sebgoa

/assign @idvoretskyi
PTAL

/assign @aledbf

/hold

@ZP-AlwaysWin please comment why this PR is needed. The YAML file in the current state is valid.

Yes ,you are right。The YAML file in the current state is valid. The reason I want to change this Yam file is that the official recommended Yam file is written in this way, and other Yaml files in this code repository are also in this style.
containers:
    - name: mysql
      image: mysql:latest
      env:
        - name: "MYSQL_USER"
          value: "mysql"
        - name: "MYSQL_PASSWORD"
          value: "mysql"
        - name: "MYSQL_DATABASE"
          value: "sample"
        - name: "MYSQL_ROOT_PASSWORD"
          value: "supersecret"
      ports:
        - containerPort: 3306

Current format
spec:
  containers:
    -
      name: mysql
      image: mysql:latest
      env:
        -
          name: "MYSQL_USER"
          value: "mysql"
        -
          name: "MYSQL_PASSWORD"
          value: "mysql"
        -
          name: "MYSQL_DATABASE"
          value: "sample"
        -
          name: "MYSQL_ROOT_PASSWORD"
          value: "supersecret"
      ports:
        -
          containerPort: 3306

Although this Yaml file is valid now, it has poor readability and is prone to indentation errors.


fix #593 upload file extension case insensitive

Fixes #593

Hi @nschonni reason there was a check beyond accept value is in the dialog, people can override and select "All files", and upload PDFs, word, etc. Thank you for reviewing.


Fix PickFirstTest flake in client_lb_end2end_test

Add delay to shutdown for PickFirstTest.CheckStateBeforeStartWatch to make sure server is properly shut down before being restarted. Otherwise, the test sometimes has broken pipe failures if the server is in some middle state.
Verified with blase - no failures after change.

https://github.com/grpc/grpc/pull/30698 properly fixes flake


Add the "component" and "type_line" fields in RelatedCard

I added the component and type_line field in the Related Card struct, as per the official documentation.

Pull Request Test Coverage Report for Build 57

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 58.656%

Totals

Change from base Build 56:
0.0%

Covered Lines:
227

Relevant Lines:
387

💛  - Coveralls

👍


Add new tasks to spanish_bench and fix duplicates

We added 3 new tasks to SpanishBench (copa_es, escola, and openbookqa_es) that were not ready for the first pull request, as they have been human translated and revised recently. Together with this new pull request, we remove some duplicate yamls for mgsm_es, paws_es, and xnli_es, which already have their corresponding yamls with the 'spanish_bench' suffix.

Hi! @zxcvuser. Just need you to fix the capitalization typo in escola, and also run the pre-commit. Not sure why the group config isn't working, so have asked Hailey or Lintang for feedback!

Hi! @zxcvuser. Just need you to fix the capitalization typo in escola, and also run the pre-commit. Not sure why the group config isn't working, so have asked Hailey or Lintang for feedback!

Done! Thank you

Hi @baberabb and @zxcvuser, I was having similar issues evaluating different models on spanish_bench, galician_bench, and basque_bench. The issue was the group key in the common_yaml files.
After removing these, the evaluation works for me.

Hi @haileyschoelkopf! Now sure if this is the place to say it, but the codexglue tasks like code2text_python still get "group" in it, causing "TaskConfig.init() got an unexpected keyword argument 'group'" error, and it might be fixed the same way. Thanks!


VisitedPcs trait in CachedState

This change introduces the trait VisitedPcs in CachedState for flexibility in the handling of visited program counters returned from an entry point call in cairo_vm.
The structure CachedState contains the field visited_pcs of type HashSet<usize> to contain the set of visited program counters. The development of a Cairo 1 profiler requires storage of the full list of program counters. To add this flexibility in the blockifier, the type of visited_pcs has been replaced with the trait VisitedPcs and an implementation replicating the current behaviour, using HashSet, has been added with the name VisitedPcsSet.
The default instantiation of CachedState in unit tests uses VisitedPcsSet.
Native blockifier is hardcoded to use VisitedPcsSet because it's only a bridge the legacy Python sequencer.

Also note that some of your CI is failing; not sure what "commitlint" is meant to do, but clippy should absolutely be passing.


Added additional system_info

Added collection of additional data for system_info, and updated method to collect Python package versions.
Closes #245

The new system_info code is now passing all the tests, including linux.  If you have access to a linux box or WSL, would you please run the new file I created, src/turnkeyml/common/system_info.py, as a script and check that the output looks good on those platforms.  Thanks!


Get All ARM Templates from subscription

I am trying to get ARM Templates deployed in my subscription and see which resources and type (VM vs API app vs App Service) of the resource are linked to the templates via python. Is this possible through python sdk?

@reach4bawer - Thanks for your question! I'm not sure whether there is information linked to a resource about how it was created (ex. Azure Portal vs. ARM template vs. REST API etc.), so I'm not aware of an SDK that would allow you to do this.
However, someone from the ARM Template service may have a better idea if there is information somewhere on how a resource was created. Directing this to the right people!

@reach4bawer Once deployed, ARM Templates become Deployments which you can list for a subscription (check the same doc for other scopes). The returned object has a list of output resources (their Resource Ids) which are the ones affected by the deployment.
Hope that covers what you are looking for.

@reach4bawer Just following up here... Hope my previous comment clears things up.

@PramodValavala-MSFT thank you for the example. Would reader role be able to pull all the attributes of the deployment?

@reach4bawer Yes. Any account with the reader role should be able to do it. For custom roles, ensure you have the Microsoft.Resources/deployments/*/read permission.


trouble getting started...

This looks really interesting!
I have loaded the three files into user/maya/2020/scripts, then started Maya, started a new scene, set the project, opened the Script Editor, opened the mayaCityGen.py script, and attempted to run it, and get:
Error: NameError: file  line 2206: global name 'scriptPath' is not defined
How can I resolve this error? Thanks!

Hi! Line 25 of the citygen script contains a definition of the scriptPath variable that only gets created if the project directory matches the location of the script. I would try deleting the if statement and setting the script path to user/maya/2020/scripts/cityGen.py by yourself.


LisaTest.runTest creates spurious results

I added a runTest method to LisaTest so that its subclasses could be instantiated conveniently. This is fine, but since nosetests discovers runTest as a test method it gets run (and always passes as it's empty) and produces a spurious result. E.g. for tests/eas/heavy_load.py:
test_tasks_spread (tests.eas.heavy_load.HeavyLoadTest) ... FAIL
runTest (tests.eas.heavy_load.LisaTest) ... ok

Can probably fix by removing runTest and instead overriding __init__ in LisaTest. Or perhaps setting LisaTest.runTest.__test__ = False.

Was not that runTest method added to have a more clean interface when used from a Notebook?
If that's the case I would go for the second solution you proposed, just disable it for nosetests.


[Feat] Add About us page to link to the footer

Description
There is About us n the footer but is not linked to any page I would like to add this feature.
@beRajeevKumar please assign me this issue under gssoc-ext level and hacktoberfest-accecpted tags
Screenshots

Checklist

[X] I have checked the existing issues
[X] I have read the Contributing Guidelines
[X] I'm a GSSoC'24-Extd contributor
[X] I'm a Hacktoberfest'24 contributor
[X] I am willing to work on this issue (optional)

@beRajeevKumar can you please review and accept the PR

hey do assign this to me

hey do assign this to me

I have already worked on this!!


Add state name to getUnregisteredStates

for each recorded state find if there's an existing state and add it's name to the api response

Done by tsachi


Prod uncaught frontend exceptions caught by PrimeErrorBoundary

Pagerduty is hit with these errors at 5-minute intervals; it makes up the bulk of our alerts page

alert

It would be nice to investigate and resolve these alerts permanently to reduce noise and clutter.

Most of these alerts relate to the "unexpected end of JSON input" that is often seen in the development console.


Created POST specification for /projects

Implemented POST for /projects. Implemented "NewProject" schema for request body content.

Hi @EM-John
I've finished updating the Projects OpenAPI spec and have tested it with our Java SDK.
There are a few issues at the API level that I've asked the team to look into, so I'll be commenting out endpoint/methods that don't currently function for JSON.
createTask
updateTask
deleteTask

Thanks @SidneyAllen.
Should I bother to make PRs in the future? The Projects API is important to me and I anxiously await the day it's complete. Would love to help accelerate it where I can. I made this small PR instead of a larger one to make sure I was doing things correctly.

Hey @EM-John
We appreciate your taking a first cut at this.
Yes PRs are welcome.  A fair amount of caution needs to be exercised as these specs are used to build our 5 (soon to be 6) language SDKs.
We have a process for building NEW specs.  We create the OAS and model them after existing patterns around components, etc, then we actually build our Java SDK with the new spec, make API calls with them and write unit tests to confirm objects are being serialized and deserialized properly.  Only then do we consider them "in release".
We've done all that with the Projects yaml file and have rolled it out to our Java SDK, with others to languages to follow.
Based on feedback from developers we'll continue to iterate on these and PRs are welcome.
As noted above, 3 operations on "tasks" endpoint are not functioning properly.  This is an issue at the API level and I've raised it with those teams - no ETA on when that will be addressed based on current roadmap and priorities.

@SidneyAllen sounds good! Hope my comments didn't come across as rude or angry. I was actually nervous to send a PR to begin with because I didn't want to submit something horribly wrong (imposter syndrome in full swing here). Wanted to make sure I was actually in-line with your process before submitting more work.

@EM-John - All good from my end!  Appreciate you taking the time to contribute.   As someone with 20 years exp. there is always something new to learn and new opportunities for me to feel like an "imposter" as well.
This is all new and we are figuring it out together. :-)


[7.2.5] PowerShell installer requires restart of PowerToys

Prerequisites

[X] Write a descriptive title.
[X] Make sure you are able to repro it on the latest released version
[X] Search the existing issues.
[X] Refer to the FAQ.
[X] Refer to Differences between Windows PowerShell 5.1 and PowerShell.

Steps to reproduce
PowerShell's installer wants to shut down PowerToys.Run for some reason.
Expected behavior
Installer installs/updates PowerShell, doesn't touch a running PowerToys.

Actual behavior
PowerShell installer wants PowerToys.Run to be restarted.

Error details
No response
Environment data
Not applicable.

Visuals

Didn't know it was powertoys, but when installing via winget the powershell installer just hangs at "Removing Previous Versions". And after reading this issue, I tried exiting powertoys when it "hung" and then the powershell installer continued successfully.

@PaulHigin That was my initial thought a while ago and I reported it to PowerToys, granted for PowerLauncher, and the response there was that there is nothing in PowerToys to warrant that.
@crutkas Can you help out here?

We have no control here.  Windows installer does the detection.  If any file we install is locked, then the process locking the file will have to be shut down.  This is external and by design.

PowerShell 7.2.7's MSI installer needs to stop PowerToys.Run. Annoying.

Agreed, the msiexec switch similar would be /qb!.
This causes problems with automated installation.


Fix pytest warning

Pytest thinks classes starting with "Test..." are test cases, which doesn't play nicely with dataclasses.

Kunne ikke kalt det MockData eller noe a?

Sure


Missing Content in Guide

Environment
Ubuntu 15.04
Node 4.4.3 LTS
Chrome
Content Appears to Be Missing in the Guide
Steps:

Go to "Write the Template"

Explanation:
There appears to be 1 box, under "Write the Template" that is missing data.
Example:

As seen in Chrome


Excalidraw drawings overwrite each other on same note

Each new drawing I do overwrites the other ones within the same notes when I close and open Obsidian. There's also an issue where the Excalidraw instance blocks out the typed math, though I was able to resolve that for now by uninstalling and reinstalling the plugin.

Sorry it took so long to get back to you, could you include a plain text version of the document this is happening in? I'm not positive, but it looks like your math blocks are sharing the same ID which could occur if the math blocks were copied and pasted instead of creating a new one using the command, but I can't be sure without seeing the metadata included in them.

Stale


VS2015!

With Visual Studio 2015 officially released, this PR removes the noreturn emulation and the now obsolete beast::static_initializer in favor of new magic statics, and makes use of the [[noreturn]] attribute.
This does not include a VS2015 project file, and, if merged, would mean that RippleD can no longer be compiled under VS2013.

:+1:

Reviewers: @vinniefalco @rec @HowardHinnant (for C++ comments)

@sublimator It might be smart to get AppVeyor switched over to VS 2015 before this pull request gets merged.

@rec: yes - my editor strips trailing whitespace and this happened without me realizing. I don't think it's a big deal.

Our project does not build in VS2015 yet. This pull request is premature.


use SERPAPI_KEY env var in tests

Minor change that adds a SERPAPI_KEY environment variable requirement to the test cases. This mirrors the current Ruby's query parser tests.
Will have to update TravisCI's environment variables before merging this in :wink:.

Thanks for your contribution. The tests are now aligned to the Ruby implementation in the release: 2.0.0


⚠ GitLab Server has degraded performance

In e1b9fb2, GitLab Server (https://gitlab01.its-telekom.eu) experienced degraded performance:

HTTP code: 200
Response time: 11750 ms

Resolved: GitLab Server performance has improved in d0fa184.


Add ability to show charts for all surveys, not just specific ones

Prerequisites

[x] Put an X between the brackets on this line if you have done all of the following:

Reproduced the problem in QA
Followed all applicable steps in the TROUBLESHOOTING guide: TODO
Checked for relevant discussions on Discord: https://discord.gg/pPERUuv
Checked that your issue isn't already filed: https://github.com/COVID-19-electronic-health-system/Corona-tracker/issues

Description
In the "Show Me More" view for all surveys, there doesn't appear to be the checkboxes to display graphs when there are many surveys (or, rather, they're rendered out of view)

Steps to Reproduce

Log in
Enter a bunch of surveys
Go to the "Show Me More" page for all surveys

Expected behavior:
We can still create appropriate charts
Actual behavior:
Checkboxes to view charts are hidden
Reproduces how often:
100%
Versions
1.0.15

Can take on this one


PurgeTimeout as a optional actor option

We need to add a option that purges all data related with the actor, it will clean its state and delete the entry from the Statestore after a configured time.
It can be called PurgeTimeout, DestroyTimeout or something like that, open to suggestions on the naming pattern.
Should it de-register from all hosts too? @sleipnir WDYT?

We need to add a option that purges all data related with the actor, it will clean its state and delete the entry from the Statestore after a configured time.

It can be called PurgeTimeout, DestroyTimeout or something like that, open to suggestions on the naming pattern.

Should it de-register from all hosts too? @sleipnir WDYT?

This is an old wish of mine.
I think we have to keep a few things in mind when implementing this:

We must stipulate a minimum default period for an actor without updating for more than N days to remain in the Statesstore. I would suggest 90 days.
User can allow data to never be deleted (maybe this is the best option for Default timeout).
We must consider the update date of the state, that is, the updated_at column
I suggest that the configuration has a name that addresses the question of the Actor's non-usefulness. Something like purgeUnusedActors or something like that.

@ping @marcellanz

@eliasdarruda we can add an option called ttl to the ActorSettings


Fix for cake github resource location in tests

Version bump and fix cake-build resources URLs in tests.

Changes included in #3 now.


Maintainers don't have matchmaking option

idk if it's intentional or not. @afiqzu

yeah it is, do you think they maintainers should be allowed to attempt questions and match as well hmm

Fixed in #205


Allow mapping of expected extensions in import/extension rule

Because all of the following requirements are true:

nodejs requires file extensions when using relative paths
typescript only supports "top-level await" when transpiling to ESM
nodejs modules (CJS) don't support "top-level await"

Then if someone wants to use Typescript to gereate nodejs apps that use "top-level await", it makes sens to start usiung nodejs's
newly supported ESM. (this is also probably going to apply to more and more module functionalities). To do so, while developping, people have to make sure that all relative imports comply with nodejs's requirement to specify the trailing ".js" file extension.
Typescript has no functionality to enforce ".js" file extensions. Because tslint was deprecated in favor of eslint, I feel
this eslint plugin would make a lot of people happy in filling out the gap.
Note this is currently a draft which more work

[x] implement feature/fix bug
[ ] write tests
[ ] update docs
[ ] make a note in change log

fixes https://github.com/benmosher/eslint-plugin-import/issues/2030

Coverage increased (+1.7%) to 71.201% when pulling e4bff8e904dedb0cf47ec0fbe7021356fa5fc253 on pwhissell:master into e871a9a2e18fd4d67a5a237789131b44cc705b5b on benmosher:master.

Coverage increased (+1.7%) to 71.201% when pulling e4bff8e904dedb0cf47ec0fbe7021356fa5fc253 on pwhissell:master into e871a9a2e18fd4d67a5a237789131b44cc705b5b on benmosher:master.

Coverage increased (+1.7%) to 71.201% when pulling e4bff8e904dedb0cf47ec0fbe7021356fa5fc253 on pwhissell:master into e871a9a2e18fd4d67a5a237789131b44cc705b5b on benmosher:master.

I'm still pretty confused here.
If you want to require an extension, configure the rule to do so.
If you want to only require an extension in .ts files, use overrides, set files to **/*.ts, and configure the rule to do so there.
What does this PR allow you to do that you can't already do with an eslint config?

I'm new to eslint so I wouldn't be suprised that I misunderstand something, but here is how I understand "overrides":
"overrides": [
    {
      "files": ["**/*.ts"],
      "rules": {
        "import/extensions": "#Some Config That Would Force All (or relative) Imports To Have .js extension#"
      }
    }
  ]

I havn't found any configuration that would enforce a specific (".js" in my case) extension for all imports

Given the following files:
tsconfig.json
file1.ts
file2.ts

if the content of file1.ts is:
import {something} from "./file2"
import {other} from "./file2.js"

the typescript module resolver resolves both "./file2" and "file2.js" to the following file: "./file2.ts" which is right because the resolution happens before transpilation.
When using the rule: import/extensions, the expected extension is chosen from the file name resolved by the module resolver. In this case because the resolved module is defined in the "./file.ts" file, the plugin expects the extension to be ".ts".
The linting error disapears if you right the import statement like so:
import {other} from "./file2.ts"
This import statement is invalid and flagged by Typescript as such.
This PR allows the developper to configure the "import/extensions" in a way that would rather make the linter expect ".js" extension in all import statements even if the resolved module is a file with another extension.
In my example, the linter would now expect and accept nothing other than:
import {other} from "./file2.js"

You’re trying to force an extension appear in code that doesn’t actually exist on the filesystem?

yes exactly. It isvreally awkward but typescript  ensures you that it will. Otherwise typescript raises an exception if it cant make that garantee

typescript should definately implement such a functionality but this plugin is 80 lines away from doing it

its a non-intrusive solution that would please any nodejs+typescript enthousiasts
even more so now that tslint is deprecated in favor of eslint.
perhaps the proposed solution could be extended to other transpilers or contexts in its flexibility. Or should I change the implementation to focuse on ts transpilation?

im linting the ts file and not the transpiled es file

The proper solution here would be to implement this as an option in the typescript resolver, not in this plugin itself.

I think your opinion is very defendable, but I would argue that the resolver is correct in that it resolves the module to the right file. Concerning separation of concerns, I also argue that enforcing a specific extension fits very well with this module's responsibility.
If this were an invasive solution, I wouldn't even have considered the option of a PR.

It’s that the extension doesn’t already exist that’s the problem. This plugin is only attempting to combine node’s CJS resolution algorithm with a style preference.

Hahah now I guess I'm confused :S

This plugin is only attempting to combine node’s CJS resolution algorithm
When reading the readme from the root of this repo, I found that typescript the resolver is supported. I also appreciated got inspired by existing unit tests, when specifying validating my functionality for all supported typescript versions.

I may have missinterpreted the readme when reading that this repo was "trying to support linting of ES2015+ (ES6+) import/export syntax, and prevent any issues with misspelling of file paths and import names."
I also think that linters are not ownly good for validating stylistic errors, but also (and probably more importantly) programmatic errors.

I think the un-introssiveness of the implementation makes this at least worth a second and third opinion
@benmosher, @jfmengels, @rfermann what do you guys think

It was only very recently that node changed the plan and decided not to auto-add extensions for ESM. As such, either we enforce what babel/ts does (no extensions, primarily) or what node does (.mjs or, sometimes, .js, but only when the files exist).
It seems like you’re trying to work around typescript’s poor integration with node’s native ESM support, rather than accepting that the two shouldn’t be used together yet.

Typescript should indeed improve esm support, but they wont, because they point to here saying that linting should be the solution.
Given the popularity of the MEAN stack I think having typescript accross the entire stack is goingg to be a trend for the future. Before this can happen, I think features like tgese need to be implemented.
In the context where the imported module exists (in a version not yet transpiled),
I honestly don't grasp the importance of the idea that the imported file needs to exist before linting

It seems like you’re trying to work around typescript’s poor integration with node’s native ESM support, rather than accepting that the two shouldn’t be used together yet.

I wouldn't call it working around, I woulf call it "improve"

As such, either we enforce what babel/ts does (no extensions, primarily)
Typescript does support imports with extensions:
given a file called "y.ts"
import x from y.js would

at transpile time resolve to the y.ts
at runtime time resolve to the y.js (which is the transpiled y.ts)

And prior to transpile time, would explicitly point to nothing - which is when the linter runs. It would likely work better to transpile your TS with babel, and transform the specifiers to add .js in the build process, and continue to omit them in your source code - then you don’t need to do somersaults in your linter config to support this case.

prior to transpile time, it does not point to nothing. When you use a typescript resolver, it points to the ts file

You suggest I don't transpile my ts files with Typescrtipt but rather do it with Babel?

Always, yes. Babel is much better at transpiling TS than tsc is.

When you use a typescript resolver, it points to the ts file

if that is true, then i'm not sure why any change is needed - the .js extension should Just Work already.

Exactly the js extension does work perfectly
typescript supports both "no extension" and ".js" extension.
The problem arizes when you want your project to always use one or the other but not both.
This is when eslint-plugin-import comes in.
Currently the plugin takes for granted that the path to file path to the resolved module has the module's correct extension.
In the case of typescript modules, the extension of the file that defines the module (.ts) doesn't correspond to the the extension of the module itself (.js)
this applies for any transpilers that require different extensions for pre-transpiled files (if there are any out there)

Always, yes. Babel is much better at transpiling TS than tsc is.

I think that this is a valid opinion which I share in some regards (it seems more and more so as time moves on). However until typed-objects become more stable I will be sticking to typescript (I don't think I will be the sole developper to do so out there)

transpiling with babel doesn't solve the problem. The workaround is to rename typescript files so that the extension is ".js" which is even more awkward
there really is no way to get this to pass is there? I'm not tied to the implementation at all, but allowing the linter to expect module extensions other than the extension of the file it is defined in seems perfectly aligned with the scope & goal of this repo.

this would fix https://github.com/microsoft/TypeScript/issues/16577

Just found this . You can basically configure how nodejs resolves esm modules. running nodejs with the following flag solves the initial problem behind this PR "node --experimental-specifier-resolution=node"

I am a little hesitant to add my voice in this thread with the hostility in it, but I am looking for a similar solution. I am sorry this has become a tough issue for those involved.
If this pull request is stuck between a rock and a hard place, is there a possibility of allowing resolver plugins to implement this mapping while we are in this uncanny valley of TypeScript + Node.js ESM? I imagine the rule primarily being used for TypeScript and gradually being faded out depending on whether the module specifier resolution aligns more with node, or TypeScript implements a solution for full import paths besides manually adding them in the TypeScript code with .js extensions.
From my testing, eslint-import-resolver-typescript supports resolving imports using .js extensions in TypeScript imports, even when they don't exist on the file system. I can imagine that plugin wanting to add support for the extension rule as well.

@evelynhathaway that's an interesting idea - I'm not sure yet how we'd rework things so that was done cleanly, but allowing a custom resolver to do this stuff is a lot safer/simpler than building it into the core plugin.


How to get 'No connection failed' error for FIRDatabaseReference.observeSingleEventOfType?

I am using

Xcode 9.2
Firebase SDK
Using Firebase (5.3.0)
Using FirebaseAnalytics (5.0.1)
Using FirebaseCore (5.0.4)
Using FirebaseDatabase (5.0.1)
Using FirebaseInstanceID (3.1.1)
Using FirebaseStorage (3.0.0)

I have integrated Firebase on my iOS project and use the Realtime database and Storage.
I want to get the JSON data and image files from Firebase using the following code.
FIRDatabaseReference *images = [[FIRDatabase database] child:kImagesKey];
[images observeSingleEventOfType:FIRDataEventTypeValue withBlock:^(FIRDataSnapshot * _Nonnull snapshot) {
        FIRStorageReference *imagesRef = [[FIRStorage storage] child:kImagesKey];
        for (NSString *path in snapshot.valueInExportFormat) {
            NSURL *localURL = [self localURLForStoragePath:path];
            [[imagesRef child:path] writeToFile:localURL completion:^(NSURL *URL, NSError *error) {
                 // Display Image here
            }];
        }
} withCancelBlock:^(NSError * _Nonnull error) {
    [self showErrorMessage:error];
}];

It works good when the connection is good, but when there is no connection, for ex, when the app launches in airplane mode, no callback is called.
I want to show the connection error alert when there is no connection.
Please help me about it.
Thanks

RTDB doesn't surface connection state in its public API. You can use SCNetworkReachability to detect connection state like airplane mode.
It's unlikely this will be added to RTDB in the near future.


vaultwarden service: Fix doubly-nested config value. Fixes evaluation

Description of changes
Fixes https://github.com/NixOS/nixpkgs/commit/080757c6c53d748717e86ab5faf15f62fc1e42a6#commitcomment-127533508
Tested with:
cat vaultwarden-test-vm-configuration.nix

{ config, pkgs, ... }:
{
  boot.loader.systemd-boot.enable = true;
  boot.loader.efi.canTouchEfiVariables = true;

  services.vaultwarden = {
    enable = true;
  };

  system.stateVersion = "23.05";
}

and VM build invocation:
NIX_PATH=nixpkgs=. nix-build '<nixpkgs/nixos>' -A vm -I nixos-config=./vaultwarden-test-vm-configuration.nix

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

CC @charmoniumQ
CC @hax404 @bjornfor @SuperSandro2000 from #188644

Commit message should begin with nixos/vaultwarden:, otherwise LGTM.

Commit message should begin with nixos/vaultwarden:, otherwise LGTM.

Fixed, thanks!
Merging.


feat: update all automatic retry behavior to be idempotency aware

Add new configuration option StorageOptions.Builder#setStorageRetryStrategy
Add new interface StorageRetryStrategy
Update all calls to be made idempotency aware
Change default behavior of automatic retries to only retry those operations which are deemed to be idempotent
Add @deprecated method StorageRetryStrategy.getLegacyStorageRetryStrategy providing access to a strategy which matches the previous sometimes unsafe behavior

Hehe, yeah the 10 lines felt great. Then the tests not setting IfGenerationMatch reared their head :(


Documention about Retries should mentione retryTo()

I think the retries section should make mention of the retryTo()

Thanks updated it


build.sh has incorrect file paths

We did not update the build.sh file when we updated out file managements so we need to modify the paths.

fixed in 	6948dc4


Update type of image parameters

This conversation started with @thomaspaulmann in #325. The idea is to improve the API of functions with image parameters by supporting UIImage and/or NSData parameters instead of NSURL.
Here are some points to consider:

Visual Recognition currently accepts an NSURL that can point to either an image file or compressed zip of images. It would probably improve the API if we create separate methods to handle these two cases.
These functions can be used to convert a UIImage to NSData.
UIImageJPEGRepresentation(_:_)
UIImagePNGRepresentation(_:_)
Since the conversion from UIImage to NSData requires some assumptions (format, compression rate, etc.) it might be useful to expose a function with an NSData parameter, too. The UIImage function would convert the UIImage to NSData then call the NSData version of the function.
Since we expect to add support for additional platforms (#129), we want the solution to be simple for both iOS and macOS developers.

This will be fixed in the upcoming major release by accepting all "file"-type parameters as Data.


Retry downloads of invalid zipfiles

Closes #92.

Codecov Report

Merging #132 (25a0d99) into master (37513a4) will decrease coverage by 2.02%.
The diff coverage is 57.14%.

@@            Coverage Diff             @@
##           master     #132      +/-   ##
==========================================
- Coverage   70.96%   68.94%   -2.03%
==========================================
  Files          10       10
  Lines         961      966       +5
  Branches      142      145       +3
==========================================
- Hits          682      666      -16
- Misses        223      246      +23
+ Partials       56       54       -2

Impacted Files
Coverage Δ

src/tinuous/github.py
52.55% <50.00%> (+0.01%)
:arrow_up:

src/tinuous/base.py
81.52% <57.69%> (-4.74%)
:arrow_down:

src/tinuous/appveyor.py
51.19% <0.00%> (-25.00%)
:arrow_down:

src/tinuous/__main__.py
52.44% <0.00%> (+0.69%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37513a4...25a0d99. Read the comment docs.

Thank you! Will test in smaug deployment


lt-lstmtraining: genericvector.h:720: T& GenericVector::operator const [with T = char]: Assertion `index >= 0 && index < size_used_' failed.

Hi,
I have been runnig about 130G data which are 4000 files. My command is
/home/kddlab/Desktop/tesseract-master/src/training/lstmtraining
--traineddata /home/kddlab/Desktop/tesseract-master/src/training/langdata/fas/fas/fas.traineddata   --net_spec '[1,48,0,1Ct3,3,16Mp3,3Lfys64Lfx96Lrx96Lfx192O1c165]'
--model_output /home/kddlab/Desktop/tesseract-master/src/training/langdata/fas/Out_Checkpoint/base --learning_rate 0.001
--train_listfile /home/kddlab/Desktop/tesseract-master/src/training/langdata/fas/fas.training_files.txt
--eval_listfile /home/kddlab/Desktop/tesseract-master/src/training/langdata/fas/v/fas.training_files.txt \ --max_iterations 150000 &>/home/kddlab/Desktop/tesseract-master/src/training/langdata/fas/Out_Checkpoint/basetrain.log
but after reading some files the tesseract gives the error and stop training:
Loaded 821/10179 pages (1-821) of document /home/kddlab/Desktop/tesseract-master/src/training/langdata/fas/AllLstm/fas.B_Lotus.exp2778.lstmf
lt-lstmtraining: genericvector.h:720: T& GenericVector::operator const [with T = char]: Assertion `index >= 0 && index < size_used_' failed.
Could you please help me?

reference: https://groups.google.com/d/msg/tesseract-ocr/FC8eb6ji3sY/DQtidKDACwAJ


jsx-no-undef undefined bug with deep object access

Following #172, with this:
import List from './List';

const label = <List.Item.Label>Hello</List.Item.Label>

I have the error 'undefined' is not defined.

Duplicate of #469, it was fixed in https://github.com/yannickcr/eslint-plugin-react/commit/ebab1800536c4abf0491c7afa73d6652ee133082 but not published yet (it should be published during the week-end)


Pass existing connection to new transaction

Is there anyway to pass an existing connection to a transaction? I know how to do it for queries:
http://knexjs.org/#Builder-connection
But I want to start a new transaction passing in an existing connection object.
const knex = require("knex");

const client = knex({
    client: 'postgres',
    connection: {...},
    pool: {
        min: 1,
        max: 1
    }
});

(async () => {
    let con = await client.client.pool.acquire().promise;

    //anyway to pass `con` into the transaction?
    await client.transaction(async trx => {
        await trx.select().from("table");
        console.log("Done");
    });
})();

At the moment .transaction attempts to acquire its own connection

After digging into the source code, I figured it out by adding {connection: con} after the callback function!

This would need documentation and to be verified that the feature has tests. Does knex.connection(con),transaction() work too? That would be currently the official way to do it, but I'm pretty sure there is no integration tests for that either.

No I believe .connection only exists when you start a query builder object by using something like knex("table"), knex.select() etc

Some caveats. Can't run a transaction inside another transaction both using the same connection. This is understandable.
Example: Expect table_b insert to rollback but table_a insert to commit but in reality both queries rollback on the same connection.
let con = await knex.client.pool.acquire().promise;
await knex.transaction(async trx => {

    await trx("table_a").insert({a: "foo"});

    await client.transaction(async trx => {
        await trx("table_b").insert({b: "bar"});
        throw "error";
    }, {connection: con})
    .catch(e => console.log("error", e)); //catch the error but don't rethrow

}, {connection: con});
await client.client.pool.release(con).promise;

I was expecting that if you release the connection in the middle of the transaction, that reviving the connection would cause the queries before it not to commit, but this isn't the case. This code actually works:
let con = await knex.client.pool.acquire().promise;
await knex.transaction(async trx => {

    await trx("table_a").insert({a: "foo"});

    //release connection, so I expect `COMMIT;` on table_a should never run
    await client.client.pool.release(con).promise;

    //at this point I expect the connection should be revived as a new connection
    //disconnecting the `BEGIN;` from the `COMMIT;`
    await trx("table_b").insert({b: "bar"});
}, {connection: con});
await client.client.pool.release(con).promise;

This should be documented at least and to add cookbook recipe... reopening until we have more specific issues what to do about this.

FYI: I'm actually doing some refactoring that will probably impact this.  You can see the experimental PR here:
https://github.com/knex/knex/pull/3708
(There's also a long comment on the PR that outlines the main concepts)
@Gregroam : Like you stated, knex currently obtains a new connection for each top-level Transaction.  This PR is basically a stepping stone towards changing this behavior.  It allows the caller to decide how the connection will be acquired / released.  (Instead of having the Transaction itself make a guess about this).
As you can see, this PR changes the internal Transaction API.  Unfortunately, that means that the {connection: connection} work-around will no longer work.  Instead, it would need to be changed to:
{withConnection: ReuseConnection(connection)}

Conceptually, it's very similar.  The main difference is that it allows the caller to directly influence the lifecycle of the connection.  For example:
{
  withConnection: async (cb)=> {
    // Obtain a connection from the pool when it is actually needed.
    const connection = await client.acquireConnection();
    try {
      return await cb(connection);
    } finally {
      // Automatically dispose of the connection once
      // the transaction has completed.
      await client.releaseConnection(connection);
    }
  }
}


Sergen Stop Working

Hi again, after using on 10 different forms/list vies sergen suddenly stop working.
sergen : The term 'sergen' is not recognized as the name of a cmdlet, function, script file, or operable program. Check the spelling of the name, or if a path was included, verify that the path is correct and
try again.
please help.

Restart Visual Studio

It's stated in guide that sometimes package manager console can't set paths correctly. Restart or use file explorer.


Fixed the packages URL

The URL for packages.csv was incorrect.

Incorrect link was fixed by @MalwareMechanic last PR.


SWC-47: Added registration test case, modified settings MIDDLEWARE se…

As "SWC-47/API_testing" branch contains better styled tests, and also implements the fix mentioned in SWC-55 branch, it is worth noting to continue with the API_Calls testing from this branch onward.

Looks all good to continue the test cases!


feat: support for multiple external network

[x] Make sure you have followed Kube-OVN Code Style.

What type of this PR
Examples of user facing changes:

Features

Which issue(s) this PR fixes:
Fixes #2679
WHAT

🤖 Generated by Copilot at d2a7462
This pull request adds support for multiple external subnets for NAT gateway and EIP scenarios. It introduces a new External field for the SubnetSpec type and a new ExternalSubnet field for the VpcNatSpec and IptablesEipSpec types. It also refactors the controller logic and the CRD schemas to use these fields instead of the hardcoded VpcExternalNet constant.

🤖 Generated by Copilot at d2a7462

ExternalSubnet
A new field for EIP, NAT
Autumn of hardcodes

HOW

🤖 Generated by Copilot at d2a7462

Add External field to SubnetSpec type and schema to indicate external subnets (link, link)
Add ExternalSubnet field to VpcNatSpec and IptablesEipSpec types and schemas to specify external subnet name for NAT gateway and EIP (link, link, link, link)
Use ExternalSubnet field of EIP to get IP and MAC from IPAM, set EIP CIDR, update EIP CR, and enqueue subnet for status update (link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link)
Use ExternalSubnet field of NAT gateway to get external gateway and CIDR, set attachment network annotation, and update route rules for NAT gateway pod (link, link, link)
Use External field of subnet to count and list EIPs in subnet usage and status (link, link)
Remove VpcExternalNet constant and checkVpcExternalNet function as they are no longer needed (link, link)
Remove MACVLAN_NAD_PROVIDER constant as it is no longer fixed to VpcExternalNet network attachment definition (link)

before you test this branch, you need to do the following steps:
# patch the external flag of subnet
kubectl patch subnets.kubeovn.io ovn-vpc-external-network --type merge --patch '{"spec": {"external": true}}'
# patch the externalSubnet of eip
kubectl patch iptables-eips.kubeovn.io {your eips} --type merge --patch '{"spec": {"externalSubnet": "ovn-vpc-external-network"}}'
# restart kube-ovn-controller
kubectl delete pod -n kube-system kube-ovn-controller

before you test this branch, you need to do the following steps:
# patch the external flag of subnet
kubectl patch subnets.kubeovn.io ovn-vpc-external-network --type merge --patch '{"spec": {"external": true}}'
# patch the externalSubnet of eip
kubectl patch iptables-eips.kubeovn.io {your eips} --type merge --patch '{"spec": {"externalSubnet": "ovn-vpc-external-network"}}'
# restart kube-ovn-controller
kubectl delete pod -n kube-system kube-ovn-controller

这些应该不需要做了吧？

before you test this branch, you need to do the following steps:
# patch the external flag of subnet
kubectl patch subnets.kubeovn.io ovn-vpc-external-network --type merge --patch '{"spec": {"external": true}}'
# patch the externalSubnet of eip
kubectl patch iptables-eips.kubeovn.io {your eips} --type merge --patch '{"spec": {"externalSubnet": "ovn-vpc-external-network"}}'
# restart kube-ovn-controller
kubectl delete pod -n kube-system kube-ovn-controller

这些应该不需要做了吧？

已删除

Please rebase the master and resolve the conflict

in order to keep the commit history clean, close the PR and create a new one. #2725


Patches (WIP; do not merge)

This branch includes changes from two forks.
It serves as a base for some more changes/fixes, primarily aimed at Windows.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 3 committers have signed the CLA.:white_check_mark: hslatman:x: mjg59:x: brandonweeksYou have signed the CLA already but the status is still pending? Let us recheck it.


Images to video generation cli command tests added (Resolves #11)

Images to video generation cli command tests added (Resolves #11)
This PR adds tests for a ffmpeg operation that takes in a group of images and an audio file and outputs a video file.

@matthew-carroll  Latest updates:

Moved use cases tests under use_cases folder.
Separate tests for generating video with/without audio file
Docs updated to include explanations for ffmpeg inputs
An additional input parameter added to make videos compatible with QuickTime and most other players due to pixel formatting issue.
More info here


mpl2: include macros in large flat cluster partitioning

Resolve #4539
Include macros in PAR partitioning when breaking flat clusters. The original code was only splitting the std cells between the generated partitions leading to something like the image below for flat megaBoom.

With the changes here:

secure CI?

Running secure-CI

@maliberty The only problem in CI was the crash report in #2019. Re-running the pipeline shows no errors. It looks unrelated to the changes here. I see no other failures, so this should be good to merge.


fix(controller): re-enable some metrics that were disabled by mistake

:tada: This PR is included in version 1.10.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Concatenating Models

I am trying to do something like this:
import keras

inputs         = keras.layers.Input((1,))
outputs        = keras.layers.Lambda(lambda x: x*x)(inputs)
model_a        = keras.models.Model(inputs=inputs, outputs=outputs)
model_a_output = model_a(inputs)

outputs_b = keras.layers.Lambda(lambda x: x*x, input_shape=(1,))(inputs)
model_b   = keras.models.Model(inputs=model_a_output, outputs=outputs_b)

This would allow me to abstract my entire model into smaller submodels. Executing the above code gives me the following error:
Using TensorFlow backend.
/home/hgaiser/.local/lib/python3.6/site-packages/keras/engine/topology.py:1562: UserWarning: Model inputs must come from a Keras Input layer, they cannot be the output of a previous non-Input layer. Here, a tensor specified as input to "model_2" was not an Input tensor, it was generated by layer model_1.
Note that input tensors are instantiated via `tensor = Input(shape)`.
The tensor that caused the issue was: model_1/lambda_1/mul:0
  str(x.name))
Traceback (most recent call last):
  File "/tmp/test.py", line 9, in <module>
    model_b   = keras.models.Model(inputs=model_a_output, outputs=outputs_b)
  File "/home/hgaiser/.local/lib/python3.6/site-packages/keras/legacy/interfaces.py", line 87, in wrapper
    return func(*args, **kwargs)
  File "/home/hgaiser/.local/lib/python3.6/site-packages/keras/engine/topology.py", line 1601, in __init__
    assert node_index == 0
AssertionError

In other words it seems like a Model can only have Input as input and not the output of another Model. Is this by design? I can see the value in allowing Models to be concatenated like this.

but you can do something like that :
img_a = Input(shape=input_shape_img)
out_a = Convolution2D(nb_filter, (kernel_size, kernel_size), padding='same', name=name, trainable=trainable)(img_a)
model_a = Model(inputs=img_a, outputs=out_a)

img_b = Input(shape=input_shape_img)
inter_b = model_a(img_b)
out_b = Convolution2D(nb_filter, (kernel_size, kernel_size), padding='same', name=name, trainable=trainable)(inter_b)
model_b = Model(inputs=img_b, outputs=out_b)

but you can do something like that :

Yes but that is something different. What you are showing is using an existing model as start for another model. A model has to have as inputs a list of Input layers, anything else doesn't seem to be allowed. If you violate this requirement Keras will give the above mentioned error.


Fix operator oder

For raw temperature value (x8) = 437
with out fix: Temp = 28.1 deg C;
with fix: Temp = 28.625 deg C

Thanks!


Dm 168 add unsubscription link to the sample update emails in sample notificator cli

This PR moves the logic of sending emails for project updates into the business domain and adds tests.
The emails sent contain an unsubscription link now.

You need to set the endpoint in the properties without a tailing /. Then it works 😉

I think it would also make a lot of sense to update the readme with the now necessary changed conditions:
1.) Setup subscription service locally
2.) Adapt config.properties to localhost
3.) Maybe add an extra section for adaptions necessary for deployment?

I added branch-specific documentation and confirmed that it works correctly.

Thank you @Steffengreiner and @jenniferboedker for detailed feedback and comprehensive testing :+1:


Install Foxx services in arangodb3 (beta) using docker (Mac)

I'm trying to install a Foxx service from Github but it doesn't work as expected.
I don't get a response from the UI and neither the service is created. But if I try again, clicking on install, at least I get an error 500 as there is already a service on this mount point.
Updated local repository information with 28 service(s) Updated local repository information with 28 service(s) Updated local repository information with 28 service(s) 2016-05-30T23:04:57Z [1] ERROR Error: An service is already installed at this location. 2016-05-30T23:04:57Z [1] ERROR     at _install (/usr/share/arangodb3/js/server/modules/@arangodb/foxx/manager.js:1048:11) 2016-05-30T23:04:57Z [1] ERROR     at Object.install (/usr/share/arangodb3/js/server/modules/@arangodb/foxx/manager.js:1108:17) 2016-05-30T23:04:57Z [1] ERROR     at Middleware.<anonymous> (/usr/share/arangodb3/js/apps/system/_admin/aardvark/APP/foxxes.js:92:29) 2016-05-30T23:04:57Z [1] ERROR     at next (/usr/share/arangodb3/js/server/modules/@arangodb/foxx/router/tree.js:366:15) 2016-05-30T23:04:57Z [1] ERROR     at next (/usr/share/arangodb3/js/server/modules/@arangodb/foxx/router/tree.js:362:7) 2016-05-30T23:04:57Z [1] ERROR     at next (/usr/share/arangodb3/js/server/modules/@arangodb/foxx/router/tree.js:362:7) 2016-05-30T23:04:57Z [1] ERROR     at /usr/share/arangodb3/js/node/node_modules/lodash/index.js:7363:25 2016-05-30T23:04:57Z [1] ERROR     at Middleware.router.use (/usr/share/arangodb3/js/apps/system/_admin/aardvark/APP/foxxes.js:49:3) 2016-05-30T23:04:57Z [1] ERROR     at next (/usr/share/arangodb3/js/server/modules/@arangodb/foxx/router/tree.js:366:15) 2016-05-30T23:04:57Z [1] ERROR     at next (/usr/share/arangodb3/js/server/modules/@arangodb/foxx/router/tree.js:362:7)

After that the UI get's unresponsive (in many cases) and shutting down the server leads to crashing V8 contexts.
2016-05-30T23:25:09Z [1] INFO control-c received, beginning shut down sequence 2016-05-30T23:25:15Z [1] WARNING sending termination signal to V8 context 2016-05-30T23:25:15Z [1] WARNING sending termination signal to V8 context 2016-05-30T23:25:15Z [1] WARNING sending termination signal to V8 context 2016-05-30T23:25:15Z [1] WARNING sending termination signal to V8 context 2016-05-30T23:25:15Z [1] WARNING sending termination signal to V8 context 2016-05-30T23:26:15Z [1] FATAL cannot shutdown V8 contexts
I'm using ArangoDB 3.0.x-devel [linux] 64bit, using VPack 0.1.30, ICU 54.1, V8 <IP_ADDRESS> on Docker for Mac (1.11.1-beta13.1 (build: 8193)).

Could you clarify what service you were trying to install? By "from GitHub" do you mean from the store or from a GitHub repository directly?

I've adjusted the store logic to properly patch services with the metadata from the store (e.g. to override the compatibility info). All services other than hello-foxx (which uses CoffeeScript) should now be installable, although some may not yet work properly in legacy mode. I've also changed the error handling for when a service already exists so a proper status code is returned by aardvark (CONFLICT instead of 500).
I'm not sure what is causing the behaviour you are describing, however.

@ifcologne can you try again with the latest devel some time? I'd be surprised if this issue still exists.

@m0ppers fixed a bug in the docker container recently, I think we can close this.