fix: don't mangle names

Using this library outside of this repo results that no generators can be found, see https://stackblitz.com/edit/typescript-duufnz?file=index.ts for an example.
This fix removes the Symbols, and uses the type names to filter schemas

Hrmmmm..... so looking into this, is it the use of Symbols or the fact that we're packaging Zod with our generators instead of using the Zod instance that's included as a peer dependency? I think it's the latter.
We can't really use the def.names because we need an identifier on the instance (not just the class). Specifically for matching with z.custom.
This is definitely an interesting problem.
I'm going to explore other possible solutions.
If we DO resolve the issue with the PR, we'll need a way for people to create custom generators for zod instances.

The issue with the generators is that they were constructed using a bundled version of zod. This meant that the symbols were placed on the zod constructors in the bundle but not on the constructors being used outside the library to define the schemas. You were correct to match the typeName of the instance to the name of the constructor. However, we still need symbols for zod instances (which aren't prebundled).
I also realized that the bundle size was being inflated by including zod when the only thing we need is the typeNames. I stubbed out zod constructors for us internally (so the API is consistent internally and externally). Still working on tweaking a couple things but here's the PR https://github.com/timdeschryver/zod-fixture/pull/47.
The bundle size was reduced from 91kb to 14kb.


Add support for sections

As far as I'm aware, sections are not supported (cloneWithRowsAndSections, renderSectionHeader)? This is an important feature for most apps

Hi @clauderic, you are correct, sections are not currently supported. For a start we would need to change the way data is passed, and it would also add additional complexity to dragging logic, and sorting logic (e.g. section 2, item 3 is dragged to section 1 item 2).
I'm happy to review pull requests, but I don't think there is a strong enough need to warrant the additional complexity.


OBSDATA-483 adapt OpenCensus and OpenTelemetry extensions to the introduction of SettableByteEntity

Fixes OBSDATA-483

Description

Key changed/added classes in this PR

MyFoo
OurBar
TheirBaz

This PR has:

[ ] been self-reviewed.

[ ] using the concurrency checklist (Remove this item if the PR doesn't have any relation to concurrency.)

[ ] added documentation for new or modified features or behaviors.
[ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
[ ] added or updated version, license, or notice information in licenses.yaml
[ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
[ ] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
[ ] added integration tests.
[ ] been tested in a test Druid cluster.

Tested by adapting existing tests. Will check test coverage to see if we are still missing any paths in the relevant classes.

A few more tests might be granted but taking this to a full review mode given that the changes are already being tested in staging.

Just rebased on top of 24.0.1

Rebased on top of druid-24.0.2 that now has been released (by rebasing the underlying branch) and reverted the changes of the tests that should not expect a call to open() anymore.

Happy to follow up on outstanding comments.
In the meantime I have updated the description.
We also got a green build with tests passing 🎉


Rule suggestion: no direct key lookups, prefer wrappers

Key lookups in TypeScript return the incorrect type, e.g.
const xs = [1];
xs[500] // number, should be number | undefined

Therefore, it is good practice to avoid using key lookups, and instead always prefer helper functions:
const getInArray = <T>(array: T[], index: number): T | undefined => array[index]
getInArray(xs, 500) // number | undefined

The same is true for objects, e.g. foo[bar].
As the TypeScript team do not want to fix this, it would be great if TSLint had a rule to enforce this.
In my experience, a lot of bugs come from unguarded key lookups like this.

@OliverJAsh this seems like it would be very disruptive. If enabled, it would basically ban direct uses of [] lookups, right?
-1 from me, but curious if there's a lot of desire for this.

Ha, always nice to see my opinions aligning with the TypeScript team. 😆
To recap, as RyanCavanaugh mentioned and you responded to, the problem is that this rule would flag all array lookups. It's hard to tell if this would help more than hurt the majority of users, which means it's hard to tell if this should be added to TSLint core.
Putting it another way: if we find that this hurts more than it helps, we're then stuck with maintaining this obscure rule for years (see no-use-before-declare).
Proposal: can you make a separate repository + npm package, publish the rule there, and ask users to try it out? That would let you iterate more quickly than sending PRs to this repository and waiting for TSLint releases to flight updates.

Closing for inactivity. Thanks all!


Create Sample Project

A sample project that shows off how to use lots of different aspects of groovy and demonstrates why groovy is a good choice to use on Android and how to properly use it to help explain and coincide with the documentation would be very beneficial.

Don't know if this is useful for what you are looking for but I worked on https://github.com/sdelamo/botconf for recent talk.
It illustrates several groovy goodies in an android app. The android app features a quite standard architecture. A SQLite persistence layer, a remote sever, etc.
The work is far from done but I want to continue working on it after christmas is over.

@sdelamo Possibly, the sample project I would want added as a module to this project.


fix: Modal padding and color fixes

Description
This PR includes the fixes for modal padding and colors.
Modal UI - https://www.figma.com/file/i80YbQLLs5mXthjIHclPpX/Appsmith-Design-System?node-id=4675%3A23087
Git Modal UI - https://www.figma.com/file/dHbJ2KNXa9597W6BzsFIuE/Local-Dev-Git-Sync?node-id=2606%3A17270
Fixes #11811
Type of change

Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Tested locally

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes

Test coverage results :test_tube:
:green_circle: Total coverage has increased
// Code coverage diff between base branch:release and head branch: fix/platform-modals-design-fixes

Status
File
% Stmts
% Branch
% Funcs
% Lines

:green_circle:
total
55.59 (0)
36.79 (0)
34.91 (0)
55.91 (0.01)

:red_circle:
app/client/src/components/ads/DialogComponent.tsx
86.49 (-0.69)
59.38 (0)
83.33 (-1.67)
85.71 (-0.78)

:green_circle:
app/client/src/pages/organization/OrgInviteUsersForm.tsx
42.59 (1.15)
26.92 (0)
0 (0)
44.23 (1.24)

/ok-to-test sha=5efd8af

/ok-to-test sha=671dc38

/ok-to-test sha=ac2707e

/ok-to-test sha=d78187e

/ok-to-test sha=24f05dc

/ok-to-test sha=543dad5


docs(api): add more gripper-supported labware

Overview

Expands the table in the Supported Labware § of Moving Labware to include all 18 labware whose definitions currently include gripper parameters.
Test Plan

Check formatting in the sandbox.
Check that the table lists all and only the labware that include grip force and offset info added to internal-release in #13233

Changelog

update list-table in moving_labware.rst

Review requests

@sanni-t @andySigler @ChrisYarka Confirm which labware we want to include in this section on August 21:

[ ] biorad_96_wellplate_200ul_pcr
[ ] nest_96_wellplate_100ul_pcr_full_skirt
[ ] biorad_384_wellplate_50ul
[ ] corning_12_wellplate_6.9ml_flat
[ ] corning_48_wellplate_1.6ml_flat
[ ] corning_96_wellplate_360ul_flat
[ ] corning_384_wellplate_112ul_flat
[ ] nest_1_reservoir_195ml

Risk assessment

Nil, docs.

@ecormany I am pretty sure nest_96_wellplate_100ul_pcr_full_skirt is not compatible with the gripper because the plastic is too flimsy. I might want to run this augmented list by the team before we officially merge the new labware listing

Playing it safe and holding off on adding many more labware at this point. We can always follow up to add more. Merging to include useful new info in the note below the chart.


Carry forward resource overrides when retrying run-nows.

love it when all checks have failed

@matthewyaspan unfortunately our travis build is a bit borked at the moment. Isn't quite indicative of things failing or not

🚢


Multiple view types

Hi @mikepenz,
Thank you for this amazing library! It has really sped up development for me and with all the features, there's so much I can do with a lot less code!
One thing I'm struggling with is handling different view types. I followed the examples (specifically the MultiTypeModelItemActivity.kt example) and it's working, however, I'm unsure if I'm doing it correctly.
I want something like:

Header
ViewType A
Header
ViewType A
ViewType B
Header
ViewType A

This is the code I have:
private lateinit var fastAdapter: GenericFastAdapter
//...
val itemAdapter = ModelAdapter { element: Any->
    when (element) {
        is HeaderSection-> HeaderSectionItem(element)
        is ViewTypeASection-> ViewTypeASectionItem(element)
        else -> {
            ViewTypeBSection(element)
        }
    }
}
//...
fastAdapter = FastAdapter.with(listOf(itemAdapter))
//...
itemAdapter.add(HeaderSection("Header"))
itemAdapter.add(ViewTypeASection("ATest1"))
itemAdapter.add(HeaderSection("Header"))
itemAdapter.add(ViewTypeASection("ATest2"))
itemAdapter.add(ViewTypeBSection("BTest1"))
itemAdapter.add(HeaderSection("Header"))
itemAdapter.add(ViewTypeASection("ATest3"))

Is this the correct way of approaching this? The reason I am asking this is because in the other examples (such as AdvancedSampleActivity.kt) multiple adapters have been created: a headerAdapter and itemAdapter. Does this mean I should create an adapter for each of them and pass them to fastadapter?
// Like this?
fastAdapter = FastAdapter.with(listOf(headerAdapter1, viewTypeAdapterA1, headerAdapter2, viewTypeAdapterA2)) //etc

Hopefully you can put me in the right direction! Thank you!
Checklist

[x] Searched for similar issues
[x] Checked out the sample application
[x] Read the README

@missphyrgames the answer to this is actually more of a "it depends".
Ultimately it depends on the exact usecase you want to achieve. If you have no real need to modify items in a section often, and if things stay stable then using a single adapter is for sure fine.
Using a different adapter per section will shine especially if you want to remove all items in a section, add items in a section without wanting to modify other elements.
Also it may be relevant also for type safety. as you can have a child adapter with only a specific item type.
So based on the very short example I would say stay with one adapter. As it won't scale if you have 10 adapters, ...
But if for example you have 3 sections. and those 3 sections then have a few hundreds items within. then it may make more sense to setup multiple adapters

Firstly, thank you for the quick reply!
Secondly, I found a concrete example of what I want to achieve. It's practically the same as the soundcloud library page. The elements of the page don't change or update at all. It's a completely static list.

Would you then recommend the going the single adapter route if no items change?

I would say so. there's no major reason for you to split it up into a huge amount of sub adapters. the adapter you have will just allow for all the different types and you put them in.
In any case, if you see you want to go more complex or want to take benefit of being able to clear out a single adapter or so at a later point, replacing it should be rather simple and not cause any much complications.

That's great! Thanks again!


Run from removable/external storage

From what I can tell currently the database gets installed into a private area (internal/database storage).
Is there a way to install the database into a public storage area (ideally onto an SD Card) so that it is accessible to other users/apps?

Yes, it normally goes to a private area.   Depending on the os you can put it in a common area.


What happens in the Invoker?

I read the invoker's code, but I still cannot understand how the invoker can execute users' fuctions. Furthermore, when I check the invoker's pod' logs, I find something like below. How can other components like ContainerPool, KubernetesClient print their logs in the pod when I cannot find them in the code ?
[2021-01-05T09:24:12.660Z] [INFO] [#tid_sid_invokerWarmup] [ContainerPool] found 0 started and 0 starting; initing 2 pre-warms to desired count: 2 for kind:nodejs:10 mem:256 MB
[2021-01-05T09:24:13.181Z] [INFO] [#tid_sid_invokerWarmup] [KubernetesClient] launching pod wskowdev-invoker-00-1-prewarm-nodejs10 (image:openwhisk/action-nodejs-v10:1.16.0, mem: 256) (timeout: 60s) [marker:invoker_kubeapi.create_start:6253]
[2021-01-05T09:24:13.181Z] [INFO] [#tid_sid_invokerWarmup] [KubernetesClient] launching pod wskowdev-invoker-00-2-prewarm-nodejs10 (image:openwhisk/action-nodejs-v10:1.16.0, mem: 256) (timeout: 60s) [marker:invoker_kubeapi.create_start:6253]
[2021-01-05T09:24:13.232Z] [INFO] [#tid_sid_invokerHealth] [InvokerReactive]  [marker:invoker_activation_start:680360168]
[2021-01-05T09:24:13.243Z] [WARN] [#tid_sid_invokerHealth] [InvokerReactive] revision was not provided for whisk.system/invokerHealthTestAction0
[2021-01-05T09:24:13.492Z] [INFO] [#tid_sid_invokerHealth] [CouchDbRestStore] [GET] 'test_whisks' finding document: 'id: whisk.system/invokerHealthTestAction0' [marker:database_getDocument_start:680360428]
[2021-01-05T09:24:13.524Z] [INFO] [#tid_sid_invokerHealth] [CouchDbRestStore]  [marker:database_getDocument_finish:680360461:33]
[2021-01-05T09:24:13.637Z] [INFO] [#tid_sid_invokerHealth] [KubernetesClient] launching pod wskowdev-invoker-00-3-whisksystem-invokerhealthtestaction0 (image:openwhisk/action-nodejs-v10:1.16.0, mem: 128) (timeout: 60s) [marker:invoker_kubeapi.create_start:680360574]
[2021-01-05T09:24:13.640Z] [INFO] [#tid_sid_invokerHealth] [ContainerPool] containerStart containerState: cold container: None activations: 1 of max 1 action: invokerHealthTestAction0 namespace: whisk.system activationId: 6fc606abe2f242578606abe2f2e257a2 [marker:invoker_containerStart.cold_counter:680360577]
[2021-01-05T09:24:40.910Z] [INFO] [#tid_sid_invokerWarmup] [KubernetesClient]  [marker:invoker_kubeapi.create_finish:33983:27728]
[2021-01-05T09:24:56.226Z] [INFO] [#tid_sid_invokerWarmup] [KubernetesClient]  [marker:invoker_kubeapi.create_finish:49297:43043]
[2021-01-05T09:25:10.816Z] [INFO] [#tid_sid_invokerHealth] [KubernetesClient]  [marker:invoker_kubeapi.create_finish:680417752:57178]
[2021-01-05T09:25:11.393Z] [INFO] [#tid_sid_invokerHealth] [KubernetesContainer] sending initialization to ContainerId(wskowdev-invoker-00-3-whisksystem-invokerhealthtestaction0) ContainerAddress(<IP_ADDRESS>,8080) [marker:invoker_activationInit_start:680418330]
[2021-01-05T09:25:11.820Z] [INFO] [#tid_sid_invokerHealth] [KubernetesContainer] initialization result: ok [marker:invoker_activationInit_finish:680418755:422]
[2021-01-05T09:25:11.823Z] [INFO] [#tid_sid_unknown] [ContainerProxy] resending up to 0 from 0 buffered jobs
[2021-01-05T09:25:11.825Z] [INFO] [#tid_sid_invokerHealth] [KubernetesContainer] sending arguments to /whisk.system/invokerHealthTestAction0 at ContainerId(wskowdev-invoker-00-3-whisksystem-invokerhealthtestaction0) ContainerAddress(<IP_ADDRESS>,8080) [marker:invoker_activationRun_start:680418762]
[2021-01-05T09:25:11.838Z] [INFO] [#tid_sid_invokerHealth] [KubernetesContainer] running result: ok [marker:invoker_activationRun_finish:680418774:9]
[2021-01-05T09:25:11.847Z] [INFO] [#tid_sid_invokerHealth] [ContainerProxy]  [marker:invoker_collectLogs_start:680418784]
[2021-01-05T09:25:11.967Z] [INFO] [#tid_sid_invokerHealth] [ContainerProxy]  [marker:invoker_collectLogs_finish:680418902:116]

There are those two in the sources.
https://github.com/apache/openwhisk/blob/master/core/invoker/src/main/scala/org/apache/openwhisk/core/containerpool/ContainerPool.scala#L58
https://github.com/apache/openwhisk/blob/master/core/invoker/src/main/scala/org/apache/openwhisk/core/containerpool/kubernetes/KubernetesClient.scala#L119

There are those two in the sources.
https://github.com/apache/openwhisk/blob/master/core/invoker/src/main/scala/org/apache/openwhisk/core/containerpool/ContainerPool.scala#L58
https://github.com/apache/openwhisk/blob/master/core/invoker/src/main/scala/org/apache/openwhisk/core/containerpool/kubernetes/KubernetesClient.scala#L119

There are those two in the sources.
https://github.com/apache/openwhisk/blob/master/core/invoker/src/main/scala/org/apache/openwhisk/core/containerpool/ContainerPool.scala#L58
https://github.com/apache/openwhisk/blob/master/core/invoker/src/main/scala/org/apache/openwhisk/core/containerpool/kubernetes/KubernetesClient.scala#L119

Hey, thanks for your reply. However, my question is not that I cannot find the source code of those two components. I do not understand how to combine these two components in core/invoker/src/main/scala/org/apache/openwhisk/core/invoker/Invoker.scala because I do not find any references of ContainerPool or KubernetesClient in the file.

There are those two in the sources.
https://github.com/apache/openwhisk/blob/master/core/invoker/src/main/scala/org/apache/openwhisk/core/containerpool/ContainerPool.scala#L58
https://github.com/apache/openwhisk/blob/master/core/invoker/src/main/scala/org/apache/openwhisk/core/containerpool/kubernetes/KubernetesClient.scala#L119

Hey, thanks for your reply. However, my question is not that I cannot find the source code of those two components. I do not understand how to combine these two components in core/invoker/src/main/scala/org/apache/openwhisk/core/invoker/Invoker.scala because I do not find any references of ContainerPool or KubernetesClient in the file.

ContainerPool is created as a member variable of InvokerReactive.
https://github.com/apache/openwhisk/blob/master/core/invoker/src/main/scala/org/apache/openwhisk/core/invoker/InvokerReactive.scala#L164
OpenWhisk takes advantage of SPI in many places.
And KubernetesContainerFactory which depends on KubernetesClient internally, is instantiated via SPI as well.
https://github.com/apache/openwhisk/blob/master/core/invoker/src/main/scala/org/apache/openwhisk/core/invoker/InvokerReactive.scala#L85
You may find this useful.
https://github.com/apache/openwhisk/blob/b00678d30604d0ffb45792fdcd4b61714cfffd1c/docs/spi.md
And I recommend using the slack channel for this kind of question instead of opening a new issue.
https://openwhisk.apache.org/slack.html

ContainerPool is created as a member variable of InvokerReactive.
https://github.com/apache/openwhisk/blob/master/core/invoker/src/main/scala/org/apache/openwhisk/core/invoker/InvokerReactive.scala#L164
OpenWhisk takes advantage of SPI in many places.
And KubernetesContainerFactory which depends on KubernetesClient internally, is instantiated via SPI as well.
https://github.com/apache/openwhisk/blob/master/core/invoker/src/main/scala/org/apache/openwhisk/core/invoker/InvokerReactive.scala#L85
You may find this useful.
https://github.com/apache/openwhisk/blob/b00678d30604d0ffb45792fdcd4b61714cfffd1c/docs/spi.md
And I recommend using the slack channel for this kind of question instead of opening a new issue.
https://openwhisk.apache.org/slack.html

Thank you very much! I will check the usage of slack.

Thank you very much! I will check the usage of slack.

Hello, everyone! I am reading the Invoker's source code. I am a little confused of what ContainerFactoryProvider here refers to. https://github.com/apache/openwhisk/blob/2c621c0733befdadadb5f25f167fe575d1b15739/core/invoker/src/main/scala/org/apache/openwhisk/core/invoker/InvokerReactive.scala#L85
In reference.conf, it points to org.apache.openwhisk.core.containerpool.docker.DockerContainerFactoryProvider . But it is not true when I print its class. It shoule be org.apache.openwhisk.core.containerpool.kubernetes.KubernetesContainerFactory  but I do not understand it.

Hello, everyone! I am reading the Invoker's source code. I am a little confused of what ContainerFactoryProvider here refers to. https://github.com/apache/openwhisk/blob/2c621c0733befdadadb5f25f167fe575d1b15739/core/invoker/src/main/scala/org/apache/openwhisk/core/invoker/InvokerReactive.scala#L85
In reference.conf, it points to org.apache.openwhisk.core.containerpool.docker.DockerContainerFactoryProvider . But it is not true when I print its class. It shoule be org.apache.openwhisk.core.containerpool.kubernetes.KubernetesContainerFactory  but I do not understand it.

Are you deploying to kubernetes / using the helm chart? The Kube container factory is the default container factory for k8s.

Are you deploying to kubernetes / using the helm chart? The Kube container factory is the default container factory for k8s.

Yes, I deployed it to kubernetes using the helm chart. I wonder how the project set the ContainerFactoryProvider to be org.apache.openwhisk.core.containerpool.kubernetes.KubernetesContainerFactory.

Yes, I deployed it to kubernetes using the helm chart. I wonder how the project set the ContainerFactoryProvider to be org.apache.openwhisk.core.containerpool.kubernetes.KubernetesContainerFactory.

It is configured by the default values.yaml for the helm chart: https://github.com/apache/openwhisk-deploy-kube/blob/6a860c8e0133047e0948539f656f08dc2a08e9dd/helm/openwhisk/values.yaml#L276

It is configured by the default values.yaml for the helm chart: https://github.com/apache/openwhisk-deploy-kube/blob/6a860c8e0133047e0948539f656f08dc2a08e9dd/helm/openwhisk/values.yaml#L276

Thank you very much!

Thank you very much!


Display views & downloads in search results

Closes https://github.com/inveniosoftware/invenio-app-rdm/issues/2143
Requires https://github.com/inveniosoftware/invenio-rdm-records/pull/1256

Search:

Landing page:

Update for the search:


Latest version published with -optimize

By compiling with -optimize means that code in classpath get's inlined. This of course will break the binary compatibility promises and that's why I encountered https://github.com/scala/bug/issues/11981.

Closed via #818


Issue 2903

added one example and explained.

OPS Build status updates of commit f30c652:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

sharepoint/sharepoint-ps/sharepoint-online/Set-SPOSite.md
:white_check_mark:Succeeded
View (sharepoint-ps)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

OPS Build status updates of commit 209475e:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

sharepoint/sharepoint-ps/sharepoint-online/Set-SPOSite.md
:white_check_mark:Succeeded
View (sharepoint-ps)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


doc: Initial release change log

Signed-off-by: Leonard Goodell<EMAIL_ADDRESS>

If your build fails  due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md
PR Checklist
Please check if your PR fulfills the following requirements:

[x] I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
[x] I am not introducing a new dependency (add notes below if you are)
[ ] I have added unit tests for the new feature or bug fix (if not, why?) N/A for Doc PR
[ ] I have fully tested (add details below) this the new feature or bug fix (if not, why?)  N/A for Doc PR
[ ] I have opened a PR for the related docs change (if not, why?)  N/A for Doc PR

Testing Instructions

New Dependency Instructions (If applicable)

Codecov Report

Merging #120 (c3e5251) into main (76f80a0) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##            main    #120   +/-   ##
=====================================
  Coverage   9.13%   9.13%
=====================================
  Files         18      18
  Lines       1795    1795
=====================================
  Hits         164     164
  Misses      1610    1610
  Partials      21      21

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76f80a0...c3e5251. Read the comment docs.

https://github.com/edgexfoundry/device-onvif-camera/issues/121


calendar navigation button disabled beyond valid date

is there a way, to disable browsing next month when the max date which can be chosen is Today?
similarly disallow navigating backwards beyond min-date?

@technimadhu, please do not use the issues forum for support-related requests.  Rather, please follow the instructions here as support-related questions are best served by and for the community.  The issues forum is reserved for bugs.  Thanks.

You can accomplish this by overriding the datepicker template for month (month.html) and adding an ng-disabled attribute with the appropriate condition.


skip deployment steps if build is triggered by cron job

Testing
https://travis-ci.org/aws-robotics/aws-robomaker-sample-application-helloworld/jobs/521791521
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Closing as the bug this PR was fixing is no longer an issue.


Require reviewers for pull requests

https://github.blog/2018-03-23-require-multiple-reviewers/

done


[BUG]: Stale entries in CSI PowerMax Samples of CSM operator

Bug Description
There are a few stale entries in samples of CSM operator that needs to be removed
modules:
# CSI Powermax Reverseproxy is a mandatory module for Powermax
- name: csireverseproxy
# enabled: Always set to true
enabled: true
forceRemoveModule: true
Both of the above values are not used anywhere and it is stale
Logs
https://github.com/dell/csm-operator/blob/b3d0f22c677f07f102375f0b146517bf0439b06d/samples/storage_csm_powermax_v2110.yaml
Screenshots
No response
Additional Environment Information
No response
Steps to Reproduce
Refer to https://github.com/dell/csm-operator/blob/b3d0f22c677f07f102375f0b146517bf0439b06d/samples/storage_csm_powermax_v2110.yaml
Expected Behavior
All stale entries not needed should be removed
CSM Driver(s)
CSI PowerMax
Installation Type
No response
Container Storage Modules Enabled
No response
Container Orchestrator
NA
Operating System
NA

@shanmydell , I installed powermax v2.11.0 using [sample CR|https://github.com/dell/csm-operator/blob/b3d0f22c677f07f102375f0b146517bf0439b06d/samples/storage_csm_powermax_v2110.yaml]
Observations:
1. Issues after removing the enabled,  forceRemoveModule fields in csireverseproxy module -
When the enabled and forceRemoveModule fields are removed from the csireverseproxy module, the driver pods fail to start with the following error:
CSI reverseproxy service host or port not found, CSI reverseproxy not installed properly
Reverseproxy is not coming up as a sidecars:

root@master-1-y7a9rL44hdBIv:~# kubectl get pod powermax-controller-cffb67c68-4jjlv -n powermax -o jsonpath="{.spec.containers[*].name}" resizer attacher provisioner snapshotter driver

Driver logs:

time="2024-11-20T08:17:37Z" level=error msg="CSI reverseproxy service host or port not found, CSI reverseproxy not installed properly" time="2024-11-20T08:17:37Z" level=info msg="configured csi-powermax.dellemc.com" PodmonFrequency= PodmonPort= ProxyServiceHost= ProxyServicePort= VsphereHostNames= VsphereHostURL= VsphereHostUsername= VspherePortGroups= autoprobe=false clusterprefix= drivername= enableblock=false enablechap=false endpoint= insecure=false isHealthMonitorEnabled=false isPodmonEnabled=false isTopologyControlEnabled=false isVsphereEnabled=false iscsichappassword= iscsichapuser= mode=node modifyHostName=false nodename= nodenametemplate= password= portgroups="[]" privatedir= replicationContextPreix= replicationPrefix= systemname= thickprovision=false transport= useProxy=false user= time="2024-11-20T08:17:37Z" level=info msg="removed sock file" path=/var/lib/kubelet/plugins/powermax.emc.dell.com/csi_sock time="2024-11-20T08:17:37Z" level=fatal msg="grpc failed" error="CSI reverseproxy service host or port not found, CSI reverseproxy not installed properly"

This indicates that the reverseproxy is not being properly instantiated, and the driver cannot find the necessary reverseproxy service.
2. Removed entire csirevreseproxy module in CR -
When the entire csireverseproxy module is removed from the CR, the driver pods start functioning as expected, and the reverseproxy comes up as a sidecar container:

root@master-1-y7a9rL44hdBIv:~/csm-operator/scripts# kubectl get pod powermax-controller-779bc7767b-4r6j7 -n powermax -o jsonpath="{.spec.containers[*].name}" resizer attacher provisioner snapshotter driver reverseproxy

Conclusion:
The fields enabled and forceRemoveModule under csireverseproxy module are important for properly setting up the reverseproxy as a module. If we remove these fields, we would have to remove the entire csireverseproxy module, which would deploy the reverseproxy as a sidecar with default configurations.
From powermax v2.12.0 onward, the reverseproxy will automatically be treated as a sidecar and will be installed with default configurations, so we won't need to manage it separately.


added dash to docker compose to README.md and run_example.py script

Submitting a pull request to add a dash to the README.md under the grafana integration examples as well as the run_example.py. There is a dash that is needed between docker and compose for docker-compose. Not having the dash for docker compose makes it so that the run_example.py errors out before building out the grafana and Prometheus dashboard.

Hello, in Docker docs two ways for running Docker compose are mentioned - via a separate docker-compose as an old-way and a new command docker compose https://docs.docker.com/compose/#compose-v2-and-the-new-docker-compose-command
We choose to use a new way, a separate command in docker
May be you can describe reasons for the replacement it to docker-compose?

Hi @jeff-ridgeway ,
Thank you for bringing this up.
We decided to keep using compose V2 , which is described here: https://docs.docker.com/compose/#compose-v2-and-the-new-docker-compose-command
If you believe it is wrong decision and we need to reconsider it, please feel free to comment on that and reopen this pull request.


Resource webhook trigger is misdocumented?

I am working on connecting an ADO YAML pipeline to be triggered by a webhook via service connection.
Looking at the documentation here on how to supply a filter
is not correct, as visible through the YAML intellisense.

I've been unable to get filtering to work on my ADO pipeline - some advice here would be appreciated :)

@joshspicer This is telling you that you need a - in front of "$.action". Filters is an array of mappings, not a mapping.

I was just copying the docs on this repo to illustrate the problem. Adding a - doesn't help :(

I don't get any syntactic errors when I set it up like below, but that doesn't actually work (my incoming webhooks are not filtered by this key/value pair

Am I missing something on how filters is supposed to behave in the first place?  I want to filter based on the JSON webhook data that I receive on this pipeline. From GitHub, when a "release" webhook is sent, it's sent 3 times (with three distinct actions.)
The JSON looks like this:
{
  "action": "SOME_VALUE",
 ...
 ...
}

When SOME_VALUE == "released" I want this pipeline to run, otherwise I don't want it to run.

@joshspicer Sorry I can't help more. The document you are referring to is a design doc and as stated in the README not maintained as permanent documentation of the product.

Hey @mjroghelia - I understand that perhaps this repo isn't the best source of information for how to use this feature. I've also tried referencing the permanent documentation on docs.microsoft.com (found here and announced here).
As you can see from my screenshot above, i've copied what is in the docs, but the filter does not get applied (My pipeline runs 3 times, even when my filter's value at the given path does not equal what is in the YAML.

For reference, this is what the docs say vs what I have in my pipeline.  The JSON webhook body is sent as I shared above.
I am sent three requests from Github when a release is created, with three different actions.  My goal is to filter by the action key.
The documentation
resources:
  webhooks:
    - webhook: MyWebhookTrigger          ### Webhook alias
      connection: MyWebhookConnection    ### Incoming webhook service connection
      filters:
        - path: repositoryName      ### JSON path in the payload
          value: maven-releases     ### Expected value in the path provided
        - path: action
          value: CREATED

My pipeline
# Triggered on a webhook sent from
# a GitHub repo
resources:
  webhooks:
    - webhook: DefaultImageCreationWebhook
      connection: DefaultImageCreationConnection
      filters:
        - path: "action"
          value: "released"

Hi @joshspicer I would suggest to create ticket on https://developercommunity.visualstudio.com/search?space=21 to get right eyes on it and further help - this repo is for yaml templates mostly

sure, ill do that.

Link to the devcon issue, for anyone that stumbles upon this issue in the future
https://developercommunity.visualstudio.com/t/filters-on-resource-webhook-trigger-are-not-applie/1404363?from=email


Updated Token Names to Follow Token Standard

Coverage decreased (-0.04%) to 91.821% when pulling 746071ad52b094ce444b81bd3e85ade5438d0c0b on paul/tweak/names into 788b9205c541e421cfc43a380485109e6ed6d11f on main.


Remove redundant intersphinx mapping

Motivation
Remove redundant intersphinx mapping from conf.py and fix API links in metadata doc merged in #144
How to test the behavior?
https://neuroconv--154.org.readthedocs.build/en/154/
Checklist

[x] Have you thoroughly read our Developer Guide?
[x] Have you ensured the PR description clearly describes the problem and solutions?
[x] Have you checked to ensure that there aren't other open or previously closed Pull Requests for the same change?
[x] If this PR fixes an issue, is the first line of the PR description fix #XXX where XXX is the issue number?
[x] Did you update the CHANGLOG.md file on your branch to describe your changes?

thanks @weiglszonja , looks great!


The MDFileManager crashes on android

Description of the Bug
When you open MDFileManager in the android root the app crashes. The same thing happens to me if I try to use the example from the file manager documentation. I don't know what was going on.
This is the last thing I get with logcat
Code and Logs
from kivymd.app import MDApp
from kivy.uix.boxlayout import BoxLayout
from kivymd.uix.list import MDList
from kivymd.uix.list import OneLineIconListItem,IconLeftWidget
from kivy.uix.screenmanager import ScreenManager,Screen
from kivy.uix.scrollview import ScrollView
from kivymd.uix.filemanager import MDFileManager
from PIL import Image
from android.storage import primary_external_storage_path

class mainApp(MDApp):

    def build(self):
        self.theme_cls.theme_style = 'Dark'

class FileExplorer(Screen):
    def __init__(self,**kwargs):
        super(FileExplorer,self).__init__(**kwargs)
        self.contador = 0
        self.SD_CARD = primary_external_storage_path()

        self.filemanager= MDFileManager(current_path=self.SD_CARD,exit_manager=self.exit_manager)
        self.filemanager.previous = True
        #self.filemanager.ext = ['.webp']

    def showManager(self):
        self.filemanager.show(self.SD_CARD+'/WhatsApp')

    def exit_manager(self,*args):
        self.filemanager.close()

    def init_explorador(self):
        pass

if __name__ == "__main__":

    mainApp().run()

Kv File:
NavigationLayout:
    id:Nav
    ScreenManager:
        id: sm
        Screen:
            name: 'principal'
            id: principal
        FileExplorer:
            id:file
            name:'file'

    MDNavigationDrawer:
        orientation: "vertical"
        padding: "8dp"
        spacing: "8dp"
        id:navigation

        AnchorLayout:
            anchor_x: 'left'
            size_hint_y: None
            height: avatar.height
            Image:
                id: avatar
                size_hint: None, None
                size: "56dp", "56dp"
                source: "bitmap.png"

        MDLabel:
            text: "Webp2png"
            size_hint_y: None
        ScrollView:
            MDList:
                OneLineIconListItem:
                    text: 'File Manager'
                    on_press: Nav.ids.file.showManager();Nav.ids.sm.current='file'
                    on_release: Nav.ids.navigation.set_state(new_state='close')
                    IconLeftWidget:
                        icon: 'folder'
                        on_press: None
                        on_release: None
<FileExplorer>:

Log
Screenshots
[INFO   ] [Base        ] Leaving application in progress...
07-04 23:05:32.224 19511 19539 I python  :  Traceback (most recent call last):
07-04 23:05:32.225 19511 19539 I python  :    File "/home/jesus/Documentos/kivy/prueba-almacenamiento/.buildozer/android/app/main.py", line 43, in <module>
07-04 23:05:32.225 19511 19539 I python  :    File "/home/jesus/Documentos/kivy/prueba-almacenamiento/.buildozer/android/platform/build-armeabi-v7a/build/python-installs/myapp/kivy/app.py", line 855, in run
07-04 23:05:32.226 19511 19539 I python  :    File "/home/jesus/Documentos/kivy/prueba-almacenamiento/.buildozer/android/platform/build-armeabi-v7a/build/python-installs/myapp/kivy/base.py", line 504, in runTouchApp
07-04 23:05:32.227 19511 19539 I python  :    File "/home/jesus/Documentos/kivy/prueba-almacenamiento/.buildozer/android/platform/build-armeabi-v7a/build/python-installs/myapp/kivy/core/window/window_sdl2.py", line 747, in mainloop
07-04 23:05:32.227 19511 19539 I python  :    File "/home/jesus/Documentos/kivy/prueba-almacenamiento/.buildozer/android/platform/build-armeabi-v7a/build/python-installs/myapp/kivy/core/window/window_sdl2.py", line 479, in _mainloop
07-04 23:05:32.228 19511 19539 I python  :    File "/home/jesus/Documentos/kivy/prueba-almacenamiento/.buildozer/android/platform/build-armeabi-v7a/build/python-installs/myapp/kivy/base.py", line 339, in idle
07-04 23:05:32.228 19511 19539 I python  :    File "/home/jesus/Documentos/kivy/prueba-almacenamiento/.buildozer/android/platform/build-armeabi-v7a/build/python-installs/myapp/kivy/clock.py", line 591, in tick
07-04 23:05:32.229 19511 19539 I python  :    File "kivy/_clock.pyx", line 384, in kivy._clock.CyClockBase._process_events
07-04 23:05:32.230 19511 19539 I python  :    File "kivy/_clock.pyx", line 414, in kivy._clock.CyClockBase._process_events
07-04 23:05:32.230 19511 19539 I python  :    File "kivy/_clock.pyx", line 412, in kivy._clock.CyClockBase._process_events
07-04 23:05:32.231 19511 19539 I python  :    File "kivy/_clock.pyx", line 154, in kivy._clock.ClockEvent.tick
07-04 23:05:32.231 19511 19539 I python  :    File "kivy/_clock.pyx", line 86, in kivy._clock.ClockEvent.get_callback
07-04 23:05:32.232 19511 19539 I python  :    File "/home/jesus/Documentos/kivy/prueba-almacenamiento/.buildozer/android/platform/build-armeabi-v7a/build/python-installs/myapp/kivy/weakmethod.py", line 56, in is_dead
07-04 23:05:32.234 19511 19539 I python  :  ReferenceError: weakly-referenced object no longer exists
07-04 23:05:32.234 19511 19539 I python  : Python for android ended.

OS: Android
Python: 3.8.3
Kivy: 1.11.1
KivyMD: 0.104.1

With the kivy FileChooser this doesn't happen

The error ReferenceError: weakly-referenced object no longer exists is not related to the KivyMD library.

I also got the same issue when I give preview=True, even after only using the example code on kivymd documentation.

Whomever has that issue, it's because of python 3.8 and Kivy, not because of kivyMD, in your requirements use kivy==2.0.0rc1 , the problem will be solved.

I tried both kivy 1.11.1 and kivy 2.0.0 but the problem is still same.

@PunitSolanki1999 Did you run buildozer Android clean before trying with kivy==2.0.0rc1?

@ArtemSBulgakov thanks, I did not try this. after doing this the application works fine on android.


update to the latest whisper.cpp(2022-11-23)

returned value on the whisper_sample_best method is changed, so I defined the whisper_token_data.
https://github.com/ggerganov/whisper.cpp/commit/eba62e0fa1531db4f7c987e657cc7437dd6c7bcb

Sorry this took me so long to get around to, given what else has changed since you made this PR, I decided to just manually update everything myself. 0.3 has been published to crates.io if you want to use it.

Thanks!


run_cqlsh_process always fails because of Python 3 string/bytes issues

On the cassandra-test branch, in ccmlib/node.py::Node, run_cqlsh_process splits and concatenates its cmds parameter with string arguments (which will fail if cmds was a bytes object), and writes it to a subprocess pipe to stdin (which will fail if cmds was a string object).
I propose to address this issue by adding a check near the beginning of run_cqlsh_process to encode cmds in utf-8 if it's not a bytes object, and by changing the string objects used for splitting and concatenation to bytes objects.
I'll submit a pull request to address this issue.

I should modify this description slightly: run_cqlsh_process always fails if a cmds parameter is provided. I haven't tested what happens if a cmds parameter isn't provided.

My analysis was totally off. Actually, run_cqlsh_process works just fine when cmds is a string object, and it only fails if cmds is provided as a bytes object. This is because subprocess.Popen is called with universal_newlines=True.

I ran some more tests, and the problem here was user error. The cmds parameter must be provided as a string object, not a bytes object.


Week numbers

Is there any way to get week numbers (1, 2, .. 52..) into the calendar?
Would be great with these settings:
lengthOfTime: {
    months: null,
    days: 7,
    interval: 7
}

@fractalf Please check the docs/Readme, you can do that in your template :)

@mikegioia Thank you for a quick response! :)
I have scanned the docs/Readme several times on this already, are you sure it contains any information about how to the the week number ? Did you mean by using the moment lib?
I know it contains the lengthOfTime which I used as an example above, but not how to get the week number..

Yea, unfortunately that's just the day of the week's name in there :( You would need to use the moment object in intervalStart I think.


Delete work-around function from vulnmanagement clusterCves integration test

Description
Test failure
Follow up after #3414
Vulnerability Management Cluster (Platform) CVEs should display links for clusters

Timed out retrying after 4000ms: Expected to find element: [data-testid="side-panel"] [data-testid="panel-header"]:contains(0 clusters)

Side panel (above) has 1 cluster text (with uppercase style) which is consistent with list (below) which has 1 cluster link.

Brad, I downloaded clusterCvesListPages.test.mp4 file from videos folder to be able to drag the timeline to the preceding frame (second image) immediately preceding the (first) image of the failure in the screenshots folder.
Analysis
I added work-around function when side panel incorrectly displayed 0 clusters.
After the problem was solved, the test started failing consistently.
Solution
Delete function definition and optional argument, so verifySecondaryEntities calls the default function to get the count and noun from link results.
Checklist

[ ] Investigated and inspected CI test results
[x] Edited integration test

Testing Performed

/test gke-ui-e2e-tests


Fix Split expense with deleted workspace

Explanation of Change
Broken options are shown during quick split actions - after removing workspace
Fixed Issues
$ https://github.com/Expensify/App/issues/53392
PROPOSAL:
Tests

Go to staging.new.expensify.com
Go to workspace chat
Split an expense in the workspace chat
Delete the workspace
Open FAB
Click Split expense under Quick action section
Enter amount > Next
Select any workspace
Verify that selection is working correctly

[x] Verify that no errors appear in the JS console

Offline tests
No changes
QA Steps

Go to staging.new.expensify.com
Go to workspace chat
Split an expense in the workspace chat
Delete the workspace
Open FAB
Click Split expense under Quick action section
Enter amount > Next
Select any workspace
Verify that selection is working correctly

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x]  I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
https://github.com/user-attachments/assets/21283392-282d-4047-95cd-ef662f0137c5

Android: mWeb Chrome
https://github.com/user-attachments/assets/868b29c5-6a7a-4c63-8ce0-6c6001b72000

iOS: Native
https://github.com/user-attachments/assets/6c79b367-d5af-4815-90ee-4769baaf6b05

iOS: mWeb Safari
https://github.com/user-attachments/assets/8011d32f-a990-4485-be0a-11069527e71c

MacOS: Chrome / Safari
https://github.com/user-attachments/assets/bf698941-bd93-42be-978f-f9dcbc7aca37

MacOS: Desktop
https://github.com/user-attachments/assets/5044e445-dbce-49f9-b6de-4120f299a9f1

@Ollyws friendly ping on that one

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.


Fix version generation for release builds, #5308

In the case of a release build tag (ex "v1.5.0") the branch to decode version type is never triggered and int32_t type = -1 is bitwise OR'd to the version.
This fix ensures that we catch the release case and never return version number with -1 OR'd to the ver unsigned.

Awesome, thanks!


CFE support for late lowering

Can this be closed?

Issues in this area seem to pop up so some work is still needed.


Introduce Picture in Picture

Description

This PR introduces Picture in Picture handling on Android including a sample usage.
Prework PRs:
https://github.com/bitmovin/bitmovin-player-flutter/pull/85
https://github.com/bitmovin/bitmovin-player-flutter/pull/86
Changes

Add and use the FlutterPictureInPictureHandler
Relay PiP related events
Basic PiP sample

Tests

Checklist (for PR submitters and reviewers)

[x] 🗒 CHANGELOG.md entry for new/changed features, bug fixes or important code changes
[ ] 🧪 Tests added and/or updated
[ ] 📢 New public API is fully documented

I see that the PictureInPictureAvailabilityChanged event is not implemented for Flutter. As it's Android only, do you think it would make sense to expose it?

I actually missed this event. I'll create a follow up ticket and we can tackle this in another PR 🙂

As discussed on Slack, when _player.loadSourceConfig(_sourceConfig); is commented out in the PiP sample (no source loaded into the player), PiP does not work anymore on my personal Android device. The floating window does not appear and the player view just goes to Fullscreen mode.

I looked into this and found some limitation in the native SDK DefaultPictureInPictureHandler. We discussed it with @strangesource and decided for a workaround until we improve the situation on the native side. https://github.com/bitmovin/bitmovin-player-flutter/pull/87/commits/edce49e1ae8664ea9b4282907de88757e1540396


🌟 Community Feature Challenge: Policy Playground 🌟

Are you thinking of cool ways AI can enhance the authorization game?  This is one of our 10 community feature challenges, and we want your input on how we can enhance the Permit CLI in the area of policy playground. This is a space for you to share your ideas on what would make this part of the CLI even better!
How to Participate

Submit Your Proposal: Comment below with your detailed feature idea. Be sure to explain how it would work and why it would be valuable for users.
Vote for Your Favorites: Show support for your favorite ideas by upvoting them. Your votes will help us identify the most impactful proposals.
Win a Bounty: The idea with the most upvotes will be selected, and we’ll put a bounty on it! This means that you (or another contributor) could bring this feature to life and earn a reward.

Why Join In?

Shape the Future: Your input will directly influence Permit CLI’s growth.
Community Recognition: Contributing ideas or supporting others’ ideas lets you stand out as a valuable community member.
Collaborative Ownership: Together, we’ll build a CLI that truly reflects the community’s needs and creativity.

What’s Next?
We’ll keep this challenge open for proposals and upvotes until November 10th, 2024. Once the top idea is chosen, we’ll update this issue with details on the bounty and the next steps for development.
Thank you for helping us make the Permit CLI even better. We can’t wait to see what you come up with! 🌟

/bounty 200

/attempt #9
Proposal: AI-Powered Policy Builder and Testing Environment
Description: Implement an AI-powered interactive policy builder that allows users to create and visualize policies directly in the CLI. Additionally, include a sandbox testing environment to simulate policy behavior.
FEATURES

Interactive Builder: Users can initiate a command (permit playground build) to create policies through a step-by-step interface, with visual representation and prompts for input.
AI Suggestions: Based on user context, the AI suggests policy structures and rules to streamline policy creation.
Testing Environment: Users can test their policies in real-time by running scenarios (permit playground test) to see access results and evaluation logs.

BENEFITS
This feature enhances usability, reduces the time needed for policy creation, and allows for thorough validation, ensuring more secure and effective authorization strategies.

Hey, @vishwamartur, your basic idea sounds good, but the PR wasn't the direction we should go with (it uses APIs that are not exist).
Please let me know in the next 48 hours if you have a practical idea for an MVP, and I'll assign it to you. Please include design/implementation plan/timeline.

Closing as there's now answer from @vishwamartur


=begin Html doesn't emit raw HTML

Instead, things that look like paragraphs are still wrapped in  tags, which generates broken HTML

perl6/doc project is impacted by this.

Guessing this block: https://github.com/perl6/Pod-To-HTML/blob/62fa37d3a2db6157d39119dad6fab919638eb607/lib/Pod/To/HTML.pm#L350


Extending default routes don't work

router.get('/', async function(ctx, next) {
    ctx.state = {
        title: 'koa2 title'
    };

    await ctx.render('index', {});
})

router.get('/test', async function(ctx, next) {
    let data = {a:1, b:2}
    ctx.status = 200;
    ctx.body = data;
    await next();
});

// -> /test - 404

Do I made any mistakes? Thanks.

Because there is router.use('/', index.routes(), index.allowedMethods()); in app.js.
When you wtrit router.get('/test', ...), the router becomes //test, so /test got 404
You can change to router.get('test', ...),

@sinalvee Yes, I found out that Koa routes behave differently comparing to Express. I think the generated code is quite misleading. Root route is actually '//' and user route is actually '/user/', which coincidentally behaves the same as '/'  and '/user'. Your generator does confuse many newbies like me and even a Koa user.
So, would you like to improve your example code or just add some comment on it?


groonga: 9.0.2 -> 9.0.3

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/groonga/versions.
meta.description for groonga is: '"An open-source fulltext search engine and column store"'.
meta.homepage for groonga is: '"http://groonga.org/"

Checks done (click to expand)

built on NixOS
/bin/sh passed the binary check.
1 of 1 passed binary check by having a zero exit code.
0 of 1 passed binary check by having the new version present in output.
found 9.0.3 with grep in /nix/store/75vw81qrw76yvcgpfnqkyirfcwyxvpaj-groonga-9.0.3
directory tree listing: https://gist.github.com/a0cb956f436844a0e60cfd0e1f7f359b
du listing: https://gist.github.com/6b1bfe960059bb5d9593a17c946c6e1a

Rebuild report (if merged into master) (click to expand)

4 total rebuild path(s)
2 package rebuild(s)
2 x86_64-linux rebuild(s)
1 i686-linux rebuild(s)
0 x86_64-darwin rebuild(s)
1 aarch64-linux rebuild(s)
First fifty rebuilds by attrpath
groonga
postgresqlPackages.pgroonga

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/75vw81qrw76yvcgpfnqkyirfcwyxvpaj-groonga-9.0.3 \
  --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
  --option trusted-public-keys '
  r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(r-ryantm's Cachix cache is only trusted for this store-path realization.)
Or, build yourself:
nix-build -A groonga https://github.com/r-ryantm/nixpkgs/archive/925e62349e9bf694defcfcc584b87ed50a1cd142.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/75vw81qrw76yvcgpfnqkyirfcwyxvpaj-groonga-9.0.3
ls -la /nix/store/75vw81qrw76yvcgpfnqkyirfcwyxvpaj-groonga-9.0.3/bin

cc @ericsagnes for testing.

@GrahamcOfBorg build postgresqlPackages.pgroonga


DocsArchive-<IP_ADDRESS>Auto archive content

Please don't merge this PR until target archive repo PR https://github.com/OPS-E2E-PPE/docs-archive-test-target_9142c832-3a34-43fa-b5fc-7e04f0290ee5/pull/1 is merged into live branch.
Auto archive content to https://github.com/VSC-Service-Account/docs-archive-test-target_9142c832-3a34-43fa-b5fc-7e04f0290ee5.git

Docs Build status updates of commit 78ba808:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error-BackendEngineExceptionError] An exception occurred during the build process. Please check the raw log and retry building your content again. If the issue persists, please open a ticket in https://SiteHelp and include the URL of publishing report as well as below information: One or more errors occurred..

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


Memory leak from RequestInterceptor.swift file

[x] I've read, understood, and done my best to follow the *CONTRIBUTING guidelines.

What did you do?
I utilized the leak instrument and detected the memory leak originating from the function adapt in the file RequestInterceptor.swift. In fact, this function failed to add a weak reference in its closure.

What did you expect to happen?
I expected to add weak or unowned into the adapt function's closure, as this would prevent the memory leak from occurring.
What happened instead?
It still retained the reference that caused the memory leak.
Alamofire Environment
Alamofire Version: 5.7.1
Dependency Manager: SPM
Xcode Version: 14.3.1 (14E300c)
Swift Version: 5
Platform(s) Running Alamofire: iOS Simulator
macOS Version Running Xcode: 13.5.1 Ventura

Can you provide an example project that reproduces this leak? There really shouldn't be a leak here, as all of the captures should be released once the nested adapt calls are complete.

@thinhnguyenext I add memory leak test function and apply it to InterceptorTests. It turn out that no memory leak has been found.
More detail: https://github.com/Alamofire/Alamofire/pull/3859


Updated readme.  Fixes to English, etc.

Hey!  you had asked for help: "Fix mistakes in this Readme and docs. My English so bad. Good create pull request.".  I'm happy to help, and I love using your project.  I have edited the readme, and here are the changes.   Thank you!

Many thanks for your help!


Swift Package Manager compatibility

hello,
do you plan to add SPM support? or will you accept PR providing it?

Not sure if author will respond but I made my fork with that and created the PR #8 .


Cannot Resolve Package ‘Graph’

Swift playground app(on iPad)
Could not resolve package graph. Cannot continue.
[DependencyResolver] derived 'swift-markdown' requirement '0.1.0..<1.0.0'
[DependencyResolver] resolving 'swift-markdown'
Could not find branch: 'gfm' in https://github.com/apple/swift-markdown

I'm having the same issue trying to use this package in Swift Playgrounds:
Could not resolve package graph. Cannot continue.
Dependencies could not be resolved because root depends on 'swift-markdown' 0.1.0..<1.0.0.
'swift-markdown' >= 0.1.0 cannot be used because no versions of 'swift-markdown' match the requirement 0.1.1.. <1.0.0 and package 'swift-markdown' is required using a stable-version but
'swift-markdown' depends on an unstable-version package 'swift-cmark'

Yes, swift-markdown have a branch dependency on swift-cmark:gfm.
Since we are releasing versioned release of swift-markdown, can we also release a version for swift-cmark, update swift-markdown's dependency to cmark from branch "gfm" to version "xx" in "swift-markdown-0.2" branch and release a new version to fix this?
I can do the step 2. But I do not have the relevant permission to release a new version in swift-cmark. cc @QuietMisdreavus

Swift-Markdown's 0.2.0 tag was already using a tag requirement for swift-cmark; the issue mainly comes in when you're also using a branch requirement for Swift-Markdown itself, since development versions also use a branch requirement.
Regardless, today i tagged 0.3.0, based on the Swift 5.9 release.

The original version issue is fixed when 0.2 release is created. And you can choose 0.2 or 0.3 now.
However you still can't use this package on Swift Playground because it contains a Clang target. This is an expected behavior and you can file a feedback to Apple.


[GUI] BUG Error occurred in handler for 'downloadItem'

Program version
3.0.2
Service
Both
Command used
[GUI]
Show ID
4036736
Episode
,7,8
7,8
7-8
Console Output
Error occurred in handler for 'downloadItem': Error: ENOENT, config\archive.json not found in C:\Users\W\AppData\Local\Programs\multi-downloader-nx\resources\app.asar
    at createError (node:electron/js2c/asar_bundle:5:1243)
    at Object.func [as openSync] (node:electron/js2c/asar_bundle:5:1962)
    at Object.writeFileSync (node:fs:2153:35)
    at addToArchive (C:\Users\W\AppData\Local\Programs\multi-downloader-nx\resources\app.asar\modules\module.downloadArchive.js:113:8)
    at downloaded (C:\Users\W\AppData\Local\Programs\multi-downloader-nx\resources\app.asar\modules\module.downloadArchive.js:121:9)
    at Funi.<anonymous> (C:\Users\W\AppData\Local\Programs\multi-downloader-nx\resources\app.asar\funi.js:706:69)
    at step (C:\Users\W\AppData\Local\Programs\multi-downloader-nx\resources\app.asar\funi.js:67:23)
    at Object.next (C:\Users\W\AppData\Local\Programs\multi-downloader-nx\resources\app.asar\funi.js:48:53)
    at fulfilled (C:\Users\W\AppData\Local\Programs\multi-downloader-nx\resources\app.asar\funi.js:39:58) {
  code: 'ENOENT',
  errno: -2
}

Additional Information
Program works at startup with a fresh command, downloads first episode perfectly the first time, but should you wish to do multiple episodes, it does not carry out the command. If you try to manually input the next episode exclusively after the first episode, the above error is logged, and the command is not carried out. I tried 3 different episode strings all yielding the same problem "7,8" ",7,8" and "7-8" none of them downloaded both episodes.  The program does not allow for a different show to be called afterwards either; say I download an episode of show A and then want to go to show B, I have to manually restart the program ending the task and starting it again between each cycle ("force reload" isn't enough.) "DOWNLOAD ALL" also does not work and spits the same error as above after the first episode completes. "DOWNLOAD ALL BUT" and selecting every episode of the series but the two I want, also only downloads the first of the two.

The "Report a Bug" feature seems to be messed up, and won't let me submit a labeled, assigned bug report.

The "Report a Bug" feature seems to be messed up, and won't let me submit a labeled, assigned bug report.

Fixed. Thanks for the report.

As for the reset. I will investigate now, but I've I don't respond, please know that I am on vacation for one week and therefor I can't work on the project.

Vielen dank. Ich kann versuchen, das Problem selbst zu beheben und einen Pull-Request senden. Ruhe gut mein Freund.

Wenn bis morgen nichts von mir hörst, leg ich es in deine Hände

Dein Problem sollte mit dem neusten commit behoben sein.
Eigentlich sind es sogar zwei Fehler gewesen:

Funimation has a false episode number -> It downloaded the requested items but showed it has 1 and 2.
A file has been configured with the wrong path which led to the crash.

Hier in Englisch damit auch andere wissen was wir besprechen :).
Wenn du aber noch andere Sachen hast du hinzufügen oder beheben willst freue ich mich immer über Pull-Requests.


Enhance! improvements, features

0.3.X

[x] Added "answer" result
[x] Integrated "lyrics" source
[x] Improved "aside" return values
[x] Updated primp version
[x] Updated user agent and impersonation

Incoming

[ ] Unit tests
[ ] Additional results
[ ] Optimization
[ ] Consistency improvements

Missing

[ ] README.md
[ ] Tests across different Python versions

Perhaps #3 along with the README?


[Test] ActiveTableObject serialization test

Wanted to mock up a quick unit test and see if you have any feedback on my organization or methodology.
Tests can be run in Visual Studio using the Test Explorer. They are also run on the command line
Example of a failing test job: https://github.com/scowalt/RTCV/runs/1216897591?check_suite_focus=true#step:6:11

I'm not opposed to MSTest, although I tend to see a lot more usage of NUnit and xUnit. That may just be because NUnit has established itself by existing for so long and xUnit is seen as the "better replacement" for xUnit. No strong opinions on that front. Either of you have opinions @NullShock78 @ircluzar ?
On the approach, I'm not the biggest fan of extending the classes to test equality as that tends to result in a lot of extra code, as well as the fact that you shouldn't be modifying the application domain so the test domain can function.
We would probably be better off using a library such as FluentAssertions which does all the hard work of writing fancy generic assertions for us (e.g. Object.AllProperties.ShouldBeEqual() will compare all properties using reflection so you don't have to implement custom equality checks).
Other than that, I see this as a good natural progression.

I'm not opposed to MSTest, although I tend to see a lot more usage of NUnit and xUnit.

I don't have a strong opinion here either. One thing that's nice about MSTest/VSTest is that it's built into the existing Visual Studio tooling, so I don't need to worry about getting everyone to have a consistent Visual Studio experience or setting up third party tooling in CI. However, I could see switching if another framework unlocks a new feature. (For example, I want to look into measuring test coverage, and maybe a different framework will enable that more easily.

I'm not the biggest fan of extending the classes to test equality as that tends to result in a lot of extra code

Agreed. Thanks for suggesting that third party library! That's exactly what I wanted to accomplish, but I didn't consider looking for a library to help me.

None of them have great coverage tools built in, but there's plenty of services that offer coverage reports for FOSS projects.  Looking around, looks like xUnit hasn't even been upgraded for .Net Core 3 so I doubt it'll be compatible with 5 any time soon. nUnit does have 3 support and will presumably have 5 down the line, but doing some extra research it looks like MSTest got a nice overhaul a few years back to bring it more on-par with the other frameworks.

Got it! I'm happy sticking with MSTest then. I also implemented FluentAssertions and that library is amazing.

Codecov Report

:exclamation: No coverage uploaded for pull request base (506@f1505eb). Click here to learn what that means.
The diff coverage is n/a.

Codecov Report

❗ No coverage uploaded for pull request base (506@f1505eb). Click here to learn what that means.
The diff coverage is n/a.

Looks like it's not going to pick up on this one because it wasn't enabled with the base, but it seems as if it's working. Going to merge it so everything picks up and it scans the full repo, giving us a nice F.


LIGHT_POSITION in canvas shader Light processor does not work as expected.

Godot version
4.0.dev
System information
Windows 10, Vulkan, NVIDIA GeForce GTX 1070
Issue description
Given a DirectionalLight2d's light doesn't have a position like normal point lights do, I was expecting some sort of difference in how I need to handle LIGHT_POSITION. However, LIGHT_POSITION doesn't seem to return anything useful for processing directional lights at all. As far as I can tell, for DirectionalLight2d lights, LIGHT_POSITION returns the position of the top-left corner of the active camera. This appears independently true within and without the editor:

I think it'd be preferable to return the LIGHT_VEC as in the 3.x stable Light processor if possible. But, I'm no shader pro. Maybe this is actually useful in some way I don't understand.
Steps to reproduce
I discovered this while porting over a cel shader I found on shaderfrog, but you can find this by using LIGHT_POSITION for anything you'd want to use it for I'd think. For posterity, this is my shader:
shader_type canvas_item;

uniform vec3 cameraPosition = vec3(0.0f);
uniform float specularAdd = 0.5f;
uniform vec4 edgeColor : source_color = vec4(0.0f);

void light() {
    vec3 worldPosition = FRAGCOORD.xyz;

    // Calculate the normal including the model rotation and scale
    vec3 worldNormal = NORMAL.xyz;
    vec3 lightVector = normalize( LIGHT_POSITION - worldPosition );
    vec3 cameraVector = normalize(LIGHT_POSITION - cameraPosition - worldPosition );
    vec4 finalColor = (texture(TEXTURE, UV) + LIGHT_COLOR) / 2.0f;

    // Adding the difference from the main color for the highlighted part
    vec3 specularColor = vec3(finalColor.x + specularAdd, finalColor.y + specularAdd, finalColor.z + specularAdd);
    vec3 reflectance = normalize(2.0 * dot(lightVector,worldNormal)*worldNormal-lightVector);

    if(dot(lightVector,worldNormal)<0.3){
        LIGHT = edgeColor;
    } else {
        if (dot(worldNormal,lightVector)>0.0){
            LIGHT = finalColor;
            if (length(cameraVector - reflectance)<0.6){
                    LIGHT = vec4(specularColor, 1.0);
            }
        }
    }
}

Minimal reproduction project
directionallight.zip

For directional lights LIGHT_POSITION.xy is the direction but LIGHT_POSITION.z is still the lights height. The docs should be updated to reflect this.
There is also a is_directional boolean in the shader code that needs to be exposed to users so you can have different logic for directional lights

For anyone that needs a workaround to this like myself, it's not a perfect solution, but since we know that LIGHT_POSITION.xy and generally an actual light position won't be, we can use that as the conditional. Floating point precision makes it a bit less simple than we want it to be, but this works for me:
if( ceil(abs(LIGHT_POSITION.x) + abs(LIGHT_POSITION.y)) == 2.0f || floor(abs(LIGHT_POSITION.x) + abs(LIGHT_POSITION.y)) == 0.0f) {
	// handle directional lights
}


Fix interactive music docs saying it's "not implemented"

Self-explanatory title. Interactive music functionality has been added in 4.3.

Thanks!


Fixed inconsistent display results because of error in generateColumns()

closes #7

@A-Communist thanks for all PRs, I can check it only a week later.


enhancement concurrent authcontext calls

Proposal to avoid DRY for concurrent authcontext calls. Working out further your data structures and working with interfaces may improve further this implementation. But with the current data structures, this is the best I could come up with.
IMO, right now, the additional structure copies and the deteriorated code legibility does not pay off. But up to you. With better data structures, it can be interesting.
PS: Sorry about all the formatting "noise". That is the output of go fmt, which is the standard one. My IDE executes go fmt every now and then. Focus on the refactor of GetIDObject, GetMDObject and GetAuthObject.

Great! That's what I was trying with the callback, but couldn't make it work with types!
If you don't mind, I could cherry pick only the auth_context, and leave the linting and renaming of the internal module that are a bit out of scope for this PR. Most probably these last changes will be part of another one ;)
Thanks again!

Great! That's what I was trying with the callback, but couldn't make it work with types!
If you don't mind, I could cherry pick only the auth_context, and leave the linting and renaming of the internal module that are a bit out of scope for this PR. Most probably these last changes will be part of another one ;)
Thanks again!

Thanks for the work and suggestions! closing this, will link to keep the changes and comments handy for the next refactors

Thanks for the work and suggestions! closing this, will link to keep the changes and comments handy for the next refactors


Remove-AzureADGroupMember documentation incomplete

https://docs.microsoft.com/en-us/powershell/module/azuread/remove-azureadgroupmember?view=azureadps-2.0 should mention that this command ONLY works on Azure AD standard (security) groups, or at least specifically mention that it does not work with distribution groups.

@jflieben
Thank you for your issue.  This content is auto-generated and only includes what the developers add.  I have created a work item to have them check to see if they want to add this.  Thank you!
Bill


"Rosetta Code: Date format" sample day is incorrect

Describe your problem and how to reproduce it:
The sample output in the sidebar has the date Sunday, November 23, 2007.  The date should read Friday, November 23, 2007.  Source: https://howlongagogo.com/date/2007/november/23 and many other websites.
Add a Link to the page with the problem:
https://www.freecodecamp.org/learn/coding-interview-prep/rosetta-code/date-format
Tell us about your browser and operating system:

Browser Name: Firefox
Browser Version: 82
Operating System: Linux Mint

Return an array with the current date in the formats:

2007-11-23

Sunday, November 23, 2007

Example output: ['2007-11-23', 'Sunday, November 23, 2007']

Looks like a fix would entail editing the challenge description - the tests themselves appear to be accurate.
I will open this up to first timers. @ylevental thanks for the catch! 😁


pull request for e2e test at 11/18/2016 00:26:01

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

optest/docs/updated_at.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


propose HIPE: Message Trust Contexts

Signed-off-by: Daniel Hardman<EMAIL_ADDRESS>

I'm looking at how these flags would apply within the context of an Indy agent with pairwise connections. It might be helpful to have a summary of the identifiers in the HIPE, I borrowed these from the python code.
SIZE_OK: The binary message isn't too large.
DESERIALIZE_OK: It's JSON.
KEYS_OK, VALUES_OK: It matches an expected schema.
These flags seem to apply to loading and decrypting a wire message, and then again to validating the contents as a known agent message. They also don't matter at all to the message handlers, as the handler wouldn't be called if any of these failed. In terms of what might be returned in a problem report, something like message trust context failed: -s seems a lot more opaque than just message size too large, so I can't say I really see the value in tracking these.
CONFIDENTIALITY: Presumably true for an encrypted message. At the agent level I may not have enough information about the transports used (TLS etc) to say whether an unencrypted message was confidential. Even if my incoming transports are secure I don't know that the sender hasn't forwarded it through unsecure transports.
INTEGRITY: Mostly the same context as CONFIDENTIALITY, I believe. I suppose a MITM could substitute an entirely different message if they intercepted an anon-crypted one, but without knowing what the original contained.
AUTHENTICATED_ORIGIN: If the message is auth-crypted then I can associate it with a connection and whatever trust I've assigned to that. As to "were multiple factors of auth required to use the keys that encrypted the message? Were biometrics at play?" – I don't know how that could be attested in a trustable way, and that seems to imply multiple levels of authentication instead of a yes/no value.
NONREPUDIATION: I think this would require a wire message format that also included signatures? Following the signing HIPE, only portions of the agent message can be assigned signatures, not the message itself.
PFS: This might apply at the transport layer or it might not, I don't think the agent is qualified to say. Maybe if there were an additional layer of automatic key rotation built in?
UNIQUENESS: If the agent stored hashes of every incoming message that might be enough to determine this, but that seems like a trade-off that probably isn't worth implementing in most cases.
LIMITED_SCOPE: It looks like this one the agent can determine by whether the recipient key used in the wire message is one from the agent's public DID Document. But in that case the message wouldn't be associated with a pairwise connection, so it would have limited trust anyway.
I can see PFS and UNIQUENESS being optionally enforced at the agent level for all pairwise communication, but they seem unlikely to be selectively required at the handler level. Otherwise, message handlers only seem to vary in whether they require an auth-crypted message associated with an existing pairwise connection. Most do, and the rest would have specific conditions under which they would accept the message, like if it's associated with a connection invitation. I could see non-repudiation being important in some message handlers in some contexts but I'm not sure how that would be implemented at the moment.

@cywolf Thank you for the detailed feedback!
I'd like to explore some nuances related to your comments; depending on how we settle them in the comment thread, we may need to update the HIPE to simplify, or to clarify why the complexity is possible.
Regarding DESERIALIZE_OK equating to "It's JSON": I deliberately didn't name this "JSON_OK" because I could imagine CBOR or other technologies being used in some future version of DIDComm, and I didn't want the JSON assumption to be overly strong. Also, it is possible for something to be JSON but to not deserialize OK, as with JSON that repeats a key.
I agree that these attributes of a message trust context are most likely to be relevant early in the processing cycle (e.g., when turning a wire message into plaintext). However, I'm not sure the division of responsibilities will always be perfectly crisp; for example, I could imagine a handler evaluating VALUES_OK. I could even imagine a handler being implemented as a derived class hierarchy, where a base class does some of the evaluation, and derived classes do specialized validation for specific versions of the protocol. I also don't think we can assume that message trust context evaluation will be purely sequential; I could imagine multiple forms of validation happening in parallel (e.g., on different threads, in different classes).
You are correct that CONFIDENTIALITY is generally true if a message is encrypted. We are in the habit of assuming that all messages are encrypted in DIDComm (whether authcrypted or anoncrypted)--but we already have at least one example where this is not true--the connection invitation. Other low-security protocols (e.g., tictactoe) might be usable over an insecure channel as well. And Tobias has proposed non-confidential but signed operations as a general mode of operation for connectionless ("ephemeral") interactions. So we can't assume that confidentiality will always be true. When it is not true because of encryption, then you are correct that we could impute it based on transport--but only if we know with certainty the entire transmission pipeline.
If you have CONFIDENTIALITY, you probably also have INTEGRITY. But this is not guaranteed, and in fact certain crypto algorithms are susceptible to chosen ciphertext attacks exactly because the two are not identical. You can also have integrity without confidentiality, as when a message is signed but plaintext.
You are right that if AUTHENTICATED_ORIGIN considers the issue of biometrics, it's no longer binary. So the HIPE is inconsistent on this point, and needs to be fixed to either remove the mention of biometrics and keep the flag binary, or to propose some way to deal with non-binary-ness. Authcrypted messages give us authenticated origin, but there might be additional ways to achieve this goal, so I wouldn't make the equivalence between this flag and the authcrypt mechanism overly strong.
NONREPUDIATION: yes, only possible if whole message become signed. Otherwise the flag would be false.
PFS is the subject of indy HIPE 0024; we would not depend on transport to provide it. It should be possible to set this flag without knowledge of transport. If the wire format switches to use MLS (as @kdenhartog has talked about), PFS remains transport-independent.
UNIQUENESS was intended to just ask if the message has a nonce or ID that should guard against replay attack. I think most of our messages will automatically be checked for unique ID since we will have to look up thread status as we process--so I'm not sure this adds any overhead.
LIMITED_SCOPE is just a way to gauge privacy based on whether the DID is a public one or is n/pair-wise. The combination of LIMITED_SCOPE=false and NONREPUDIATION=true has ramifications that agents should understand.

This is superseded by Aries RFC 0029.


Light2D energy propertys do not transition when created programatically

Godot version
3.4.2
System information
Windows 10, GLES3, GTX3080
Issue description
When programattically creating an animation, on the Light2D:energy property, the keyframes will not have a transition between them, instead once a keyframe is reached it's value is immediately applied in full.
By "transition" I mean there is no interpolation, there is not effect.
Steps to reproduce
Simple example:
var anim_player = AnimationPlayer.new()
anim_player.name = "AnimationPlayer"
self.add_child(anim_player)

var fade = Animation.new()
anim_player.add_animation("day_to_night", fade)
fade.length = 10

var track_index = fade.add_track(0)
fade.track_set_path(track_index, "Light2D:energy")
fade.track_insert_key(track_index, 0, 0)
fade.track_insert_key(track_index, 10, 1)

I then played the scene, paused the scene, went into "Remote" node explorer, found the AnimationPlayer and saved it's branch as a Scene.
I opened the saved AnimationPlayer, manually inserted it into the corrosponding Scene with the Light2D(s), fixed up the node path references in the Animation (e.g. /Root/Some/Path/To/Light2D:energy to Light2D:energy). Then inspected the Animation in the editor.
The Animation in the editor works incorrect, same as in game, in that the keyframes are fired asif there is no transition (no interpolation?) between them.
Minimal reproduction project
light2d-issue.zip

I was able to reproduce this issue using the attached reproduction project with v3.4.4.stable.official [419e713a2].
The issues seems to happen exclusively when both the start end end values are integers. Setting either or both of these values to a float value causes the Light2D:energy property to correctly interpolate.
Here is the GDScript showing the issue and the resolution using float variables:
# Github issue #58046 reproduction:
var start: int = 1
var end: int = 0

# Fix for issue that interpolates correctly:
#var start: float = 1
#var end: float = 0

# Alternative fix for issue that interpolates correctly:
#var start: float = 1
#var end: int = 0

# Alternative fix for issue that interpolates correctly:
#var start: int = 1
#var end: float = 0

fade.track_insert_key(track_index, 0, start)
fade.track_insert_key(track_index, 10, end)

I literally just started working with Godot a couple of days ago, so I'm not sure what the resolution for this issue should be, but my gut says that this is actually intended behaviour: The animation system seems to be correctly interpolating between integers, as it was asked to.
Unless maybe the animation system should perform casts to the final property type before interpolating? I'm not sure what the best behaviour is here.

I guess for int values, the default is DISCRETE track, so I think I just need to make it CONTINUOUS. Maybe it is a documentation issue.


Not working image set function

Whenever i have tried to set image for team or player I got prompt with info:

I have copied cURL and here is result from this try
{     "cause2": "java.io.IOException: Missing content for multipart request",     "cause1": "org.eclipse.jetty.io.RuntimeIOException: java.io.IOException: Missing content for multipart request",     "cause0": "javax.servlet.ServletException: org.eclipse.jetty.io.RuntimeIOException: java.io.IOException: Missing content for multipart request",     "message": "javax.servlet.ServletException: org.eclipse.jetty.io.RuntimeIOException: java.io.IOException: Missing content for multipart request",     "url": "/app/_/service/com.enonic.app.officeleague/set-image",     "status": "500" }

Thanks for reporting this Bestils.
Hmm 500 error on the image upload.
What format is the image your are trying to upload?

@poi33  all of them, png, jpg jpeg


fix: variable name in keystore import

Description
Correct the variable name used in the keystore import, introduced in https://github.com/opensearch-project/helm-charts/pull/434
Issues Resolved
https://github.com/opensearch-project/helm-charts/issues/433
Check List

[X] Commits are signed per the DCO using --signoff

For any changes to files within Helm chart directories:

[X] Helm chart version bumped
[X] Helm chart CHANGELOG.md updated to reflect change

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Thanks @hobti01 LGTM.


Make method names case insensitive during direct schema access

Resolves #246

Codecov Report

Merging #250 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d92ff9...d3f52f2. Read the comment docs.


Cannot find module 'webpack-cli/bin/config-yargs'

Cannot find module 'webpack-cli/bin/config-yargs'
When I run webpack-dev-server I got this error
my Version:
"webpack": "^5.2.0",
"webpack-cli": "^4.1.0",
"webpack-dev-server": "^3.11.0"

Author(s)
GuoRuiyang
Additional information
I want not to uninstall my webpack, So is there an other way to solve it?

I've worked it out.  use "start": "cross-env NODE_ENV=development webpack serve --mode development --env development --config ./build/webpack.config.js" replace "start": "cross-env NODE_ENV=development webpack-dev-server --config ./build/webpack.config.js",


Is json.decode clever enough to not parse the entire object unless needed?

Assume that we have such JSON:
{
  "property": 42,
  "list": [ 0, 1, 2 ]
}

Then we do:
String myJson;

final result = json.decode(myJson);
print(result['property']);

Then, was list parsed or not?
Because we never accessed result['list'], then the decoder may be clever enough to not decode it, and do so only when requested.
The documentation doesn't state anything about it, so it is unclear.

Note that this question originates from me realizing that on dart-pad, json.decode returns a _JsonMap instead of your typical _InternalHashMap – and the implementation seems to have some lazy-loading
https://github.com/dart-lang/sdk/blob/a75ffc89566a1353fb1a0f0c30eb805cc2e8d34c/sdk/lib/_internal/js_dev_runtime/patch/convert_patch.dart#L146

Both Dart VM and dart2js parse JSON eagerly.
dart2js is lazy with regards to creating Dart objects from the underlying JavaScript objects. dart2js uses JS'es JSON.parse underneath which returns JS objects not Dart Map/List types.


[wasm] Disable building embedded stdlib when cross-compiling for wasm

The stdlib build configuration for wasm is incompatible with the embedded targets (e.g. SWIFT_STDLIB_COMPACT_ABSOLUTE_FUNCTION_POINTER=TRUE), so we need to disable building the embedded stdlib

@swift-ci test WebAssembly

@swift-ci smoke test

This fixes the current CI issue https://ci.swift.org/job/oss-swift-pr-test-crosscompile-wasm-ubuntu-20_04/1028/console that is happening while building embedded stdlib for all possible targets as a part of wasmstdlib product. We already build embedded stdlib as a part of the main swift build-script product, so we don't need to build them twice and this does not make the embedded wasm target unavailable.


multipart/digest not handled correctly

Fatal error: Call to a member function getParent() on null in /var/task/vendor/zbateson/mail-mime-parser/src/Message.php on line 477
multipart-digest.txt

Hi Meint,
Fixed in the just released 0.3.2 :) please reopen/let me know if you have any issues.

Hi Zaahid, fix works correctly, thank you!


[SE-0258] Ensure that we fully check the property type vs. wrapper's value type

Various optimizations / shortcuts in type checking property wrappers meant
that we weren't consistently verifying that a wrapped property type is
identical to the type of the 'value' property of the wrapper. Do so.
Fixes SR-10899 / rdar://problem/51588022.

@swift-ci please smoke test and merge


Fix : Cmake build error on macOS

I tried building nana library on my mac using cmake.
While I was working on it, the output said some necessary header was not included.
So I included the header file and now I can get libnana.a

Thanks for your PR!


feat: migrating and updating docker functionality + publish pipeline

feat: migrating and updating docker functionality + publish pipeline
Moves content and updates to make sense in new context within source code, from https://github.com/gbrrestoration/adria-docker (this repo is private so not all will be able to see).
Updates the README based on the content from the previous readme. See the new section at the bottom. A
Adds a github actions workflow which publishes the adria-base layer by installing ADRIA from the Julia Hub package repository at a specified version. This version is informed by the release tag if available, but can be overridden as is currently configured to allow debugging/version pinning.
You can test out the latest base image with a command such as
docker run --tty --interactive ghcr.io/open-aims/adria.jl/adria-base:latest "--project=@adria"

There still seems to be problems with the precompilation step being necessary to run adria again.


[KYUUBI #5690][AUTHZ] Support insert into/overwrite path-based table for Delta Lake in Authz

Why are the changes needed?
To close #5690 .
Support insert into/overwrite path-based table for Delta Lake in Authz plugin.
How was this patch tested?

[x] Add some test cases that check the changes thoroughly including negative and positive cases if possible

[ ] Add screenshots for manual tests if appropriate

[ ] Run test locally before make a pull request

Was this patch authored or co-authored using generative AI tooling?
No.

== Analyzed Logical Plan ==
AppendData RelationV2[id#1569, name#1570, gender#1571, birthDate#1572] spark_catalog.delta./var/folders/gc/c__qhntd7s502txfp0ltxh880000gn/T/kyuubi-9b160b53-b135-4bfd-bcde-4960b670370d delta.file:/var/folders/gc/c__qhntd7s502txfp0ltxh880000gn/T/kyuubi-9b160b53-b135-4bfd-bcde-4960b670370d, false
+- Project [id#1565, name#1566, gender#1567, birthDate#1568]
+- SubqueryAlias spark_catalog.delta_ns.table2_delta
+- Relation spark_catalog.delta_ns.table2_delta[id#1565,name#1566,gender#1567,birthDate#1568] parquet

Codecov Report
Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (2568b0d) 61.46% compared to head (704ce2c) 61.38%.
Report is 1 commits behind head on master.

Files
Patch %
Lines

...ubi/plugin/spark/authz/serde/tableExtractors.scala
50.00%
0 Missing and 3 partials :warning:

...yuubi/plugin/spark/authz/serde/uriExtractors.scala
71.42%
0 Missing and 2 partials :warning:

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5691      +/-   ##
============================================
- Coverage     61.46%   61.38%   -0.09%
  Complexity       23       23
============================================
  Files           604      604
  Lines         35697    35703       +6
  Branches       4889     4892       +3
============================================
- Hits          21942    21916      -26
- Misses        11380    11399      +19
- Partials       2375     2388      +13

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

thanks, merged to master

Thanks, @yaooqinn


training with a single gpu did not work initially

I was training with the following command:
python train.py --class_choice=car --dir_name log/atlasnet_singleview_25_squares_tmp --nb_primitives 25 --template_type SQUARE --SVR --reload_decoder_path training/trained_models/atlasnet_autoencoder_25_squares/network.pth   --train_only_encoder --multi_gpu 0
I got a map location error, when loading the weights. I had to make the following change to model/trainer_model.py, line 49

       network.module.load_state_dict(torch.load(opt.reload_decoder_path))

       network.module.load_state_dict(torch.load(opt.reload_decoder_path, map_location='cuda:0'))

Hi ! Thanks for the feedback.
Both version work fine for me so i incorporated your change in the latest commit.
Feel free to give me any further feedback
The new version of the code is not a unanimous improvement. cf #42
Cheers,
Thibault


MAJOR BUG ON 1.20.2 DELTA DATAPACK (this time for real)

I can't really see why but everytime you enter you have to do /reload in order to make the delta datapack work, also it seems to have lots of flaws when used with other datapacks, I thought it had to do with the Tick.txt file so... yeah

Going into the files, into data/delta/functions/internal/summon/summon_creepers_recursive and changing the summon command location to ~ ~ ~ instead of ~ ~1000 ~ fixed it for me