About the test-time computation experiments on search methods

Dear OpenR authors,
Thank you very much for the excellent work! Could you please kindly provide more details on how the figure below, illustrating the scaling inference law, was generated? Many thanks!

Cheers,

Hi ycjing,
Sorry for the late reply, thanks for your interest in our project. Can you show us which part you are not clear in this figure? The x-axis or y-axis or different prm-voting methods?

Dear @ziyuwan
Thank you very much for your response. I appreciate it. I'm very interested in the x-axis and trying to reproduce the diagram. Could you please kindly provide some instructions on how to control the average tokens per question for reproducing this diagram?
Many thanks!

Dear @ziyuwan
Thank you very much for your response. I appreciate it. I'm very interested in the x-axis and trying to reproduce the diagram. Could you please kindly provide some instructions on how to control the average tokens per question for reproducing this diagram?
Many thanks!

In fact, we've made a typo here, the generation budget is not the average number of tokens per question. 1 generation budget means 1 answer for a question. Namely for Best-of-N, the generation budget is the same as N. And for beam search with a max tree width of 4, and beam_size N, the generation budget here is 4N.


Change Jest configuration to also work on Windows

Summary
Due to Windows file paths, jest wasn't able to find any test files
and due to rm not being available on Windows, coverage could
not be created.
Updating the test matcher and replacing rm with rimraf (a node dependency)
allows Windows to run this project properly when developing locally
Requirements (place an x in each [ ])

[x] I've read and understood the Contributing Guidelines and have done my best effort to follow them.
[x] I've read and agree to the Code of Conduct.
[ ] I've written tests to cover the new code and functionality included in this PR.
[x] I've read, agree to, and signed the Contributor License Agreement (CLA).

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Thank you for this. I implemented your changes in my fork: https://github.com/melloware/csp-webpack-plugin


[BUG] Unnecessary try block without except

Current Behaviour
Code broken.
Expected Behaviour

Can you reproduce the bug

Can you fix the bug by yourself?

[x] YES
[ ] NO

Additional Information
The personal savings endpoint has a unnecessary try block and that too with a missing except block. Also, the variable names are incorrect. Seems that the commit is done in haste and the PR was not reviewed before merge.


CI: add testing for Radical connector

Blocked by: https://github.com/ExaWorks/SDK/issues/47

ExaWorks/SDK#47 is closed. Ready to be worked on. Assigned to @andre-merzky


does not seem to recreate local global index. global secondary index missing as well?

LocalSecondaryIndexes is missing from the schema.
GlobalSecondaryIndexes is missing as well, but that one could be created later

Hi, I've created a similar script here https://github.com/Bobtron/dynamodb-copy-table that should fix this issue - it will recreate the source table's setting such as indexes in the destination table.


Update anchor selection if split by patching style

Problem
Setting styles using $patchStyleText does not update the selection when the anchor node is split. This causes the selection to contain a node that is not part of the selection. As a result, the toolbar/$getSelectionStyleValueForProperty is not able to determine the correct selection style.
https://github.com/facebook/lexical/assets/1575198/e438e605-4d4d-4c78-9967-e3176ed531f8
Solution
Update the selection anchor with the new text node after splitting.
https://github.com/facebook/lexical/assets/1575198/22c177ae-fd17-4b30-bb68-2adab21a9b78

Failed tests seem spurious 😏


b9run test crashes if an empty function is invoked in JIT mode

b9run will crash if test/interpreter_test.src:b9main() remains an empty function [no return statement or anything in the function body]. It's better to return gracefully rather than producing a segmentation fault.

Issue is fixed by PR #96. Thanks @NigelYiboYu for reporting the problem.


Tuned services initialization, get rid of initServiceFallback [#408].

Hi @shurwit, this is the suggested rework for removing initServiceFallback API from Services.
In short:

Services dependency graph is optimized towards minimum dependency;
Service.notifyInitialized notification is introduced. It is used to perform some post initialization of other services that have loose dependency on the initialized service but can be initialized independently on it.
Removed config environment switching from Debug panels because it never worked well and it was a mistake to create this at all.

If you notice some minor tweaks please fell free to fix them straightly. If you have some more fundamental comments or concerns please let me know for them.
This PR is tight to #713 PR in Vogue app.
Thanks.

Hi @roberlander2 ,
There were not exactly issues with your additions, I would call them rather drawbacks.
1. _ServicesInitializer._canStartService
This is a boolean predicate whose only purpose is to determine whether a service can be started or not. It could be invoked several times for the same service. It is not the right place to iterate through the services looking for potential dependency inconsistency. This is now handled by _ServicesInitializer._prepareServices, that is executed just once before the initialization process starts. Instead of throwing an error it simply adds for initialization the services that are not listed in Services.create list but are referred by the other services as dependancy.
2. _ServicesInitializer._findServiceCycle
I am trying to keep the plugin's source code (or at least its core) short, tight and clear. In this line of thought I find this function just adds unnecessary complexity. For the 5 years of life of this project this error has never been raised yet. If this happens anyway the developer can always debug and detect the dependency cycle that he or she has just created, assuming that it will get raised on the first app launch right after it was introduced. That's why I decided that this helper makes more noise than brings benefits and I removed it.


Result Pattern

Hi everyone,
Does anyone have an example or suggestions on how to implement monads or the result pattern with MediatR?
I’m looking for a way to return a Result with errors instead of throwing exceptions during validation, and registering this in the pipeline behavior.
Or a way to make the pipeline behavior always work with Result types.
Most examples I’ve found either rely on throwing exceptions or using libraries like ErrorOr, which is great, but I’m aiming for a simpler Result type.
Cheers,
Thanks!

There are plenty of libraries that can help you with that:

CSharpFunctionalExtensions
FluentResults
error-or

But I do warn you to be careful not do overdo it. Heavily personalized code is a nightmare to read for outsiders.


Part 7: Add Height option in User profile; #186 - subtask.

This subtask is for the enhancement
Issue 186
Add components for adding the Height (In Centimeters) and saving it in local storage so that it can be used by the other parts of the app.
Location: src/main/res/xml/settings_user_profile.xml and src/main/res/values/strings.xml
After making the necessary changes, merge it with the branch [group_9_case_2]

The above changes are committed and pushed to the mentioned branch.
Commit Link: https://github.com/rilling/OpenTracksConcordia/commit/9b9b7edef6f776ab3a6a52a1189971fb2bbb8b5d


[ADAM-1959] Support VCF rows at position 0.

Resolves #1959.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/2734/
Test PASSed.

Thank you, @fnothaft


Fix app crash with optional chaining

Details

Fixed Issues

$ https://github.com/Expensify/App/issues/40481
PROPOSAL: https://github.com/Expensify/App/issues/40481#issuecomment-2064703058
Tests

Test 1

Create a workspace.
Go to 'More Features' and turn on 'Distance Rates.'
Navigate to 'Distance Rates' and click on any distance rate to open the Right-Hand Panel.
In the URL, modify the workspace ID to an invalid string.

Test 2

Create a workspace.
Go to 'More Features' and turn on 'Distance Rates.'
Navigate to 'Distance Rates' and click on Settings
In the URL, modify the workspace ID to an invalid string.

Test 3

Create a workspace.
Go to 'More Features' and turn on 'Distance Rates.'
Navigate to 'Distance Rates' and click on any distance rate to open the Right-Hand Panel.
Click on a rate, and the Edit Rate page will open.
In the URL, modify the workspace ID to an invalid string.

[x] Verify that no errors appear in the JS console

Offline tests

Same as above
QA Steps

Test 1

Create a workspace.
Go to 'More Features' and turn on 'Distance Rates.'
Navigate to 'Distance Rates Settings' and click on any distance rate to open the Right-Hand Panel.
In the URL, modify the workspace ID to an invalid string.

Test 2

Create a workspace.
Go to 'More Features' and turn on 'Distance Rates.'
Navigate to 'Distance Rates' and click on Settings
In the URL, modify the workspace ID to an invalid string.

Test 3

Create a workspace.
Go to 'More Features' and turn on 'Distance Rates.'
Navigate to 'Distance Rates' and click on any distance rate to open the Right-Hand Panel.
Click on a rate, and the Edit Rate page will open.
In the URL, modify the workspace ID to an invalid string.

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

https://github.com/Expensify/App/assets/93134676/7900e445-2057-47b6-a5fa-478712a7995e

iOS: Native

iOS: mWeb Safari

https://github.com/Expensify/App/assets/93134676/4cb9252d-fbdb-4db6-8a9a-16d7d837172d

MacOS: Chrome / Safari

https://github.com/Expensify/App/assets/93134676/1df7aec7-7830-4e5d-881a-5950a50f4df2
https://github.com/Expensify/App/assets/93134676/67da1d6e-e3c1-4d52-8b4c-71037de6ea1f

MacOS: Desktop

@ishpaul777 gentle bump

@ishpaul777 Do you think we should fix this here? I feel it's unrelated to this ticket.

@Nodebrute can you please merge main

Done.

@ishpaul777 Apologies,  I've fixed the issue on two pages PolicyDistanceRateDetailsPage and PolicyDistanceRateEditPage. Could you please test to see if there are any other bugs?

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/AndrewGable in version: 1.4.74-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

Bug #40481 is still reproducible in web mweb and android
https://platform.applause.com/services/links/v1/external/ad1419479349fde42b6c3c5f18f5381f9711465e1ff34dfd2218435e66af1065
https://platform.applause.com/services/links/v1/external/a2a5351bcd459e38f9860b19b7b8479ea027bd196d50632932dc58504a5368f1

I think we can just implement this as a follow up issue to the original issue

🚀 Deployed to production by https://github.com/chiragsalian in version: 1.4.74-6 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


[WIP] Completion descriptions

Closes #18
The completion menu results should be pretty good now.  Many of the kind strings are shortened to a maximum of 5 characters and are aliased to be less ambiguous.  g:deoplete#sources#jedi#statement_length is now used to only shorten function signatures.
g:deoplete#sources#jedi#statement_length = 0 - Zero value means it's disabled and the full function is shown.

g:deoplete#sources#jedi#statement_length = 50 - It first removes kwarg default values to shorten it first.  If it's still too long, it will remove args until it's short enough.

g:deoplete#sources#jedi#statement_length = 1 - Impossible value, but makes it so that all function args are removed and replaced with ...

deoplete-jedi can distinguish properties from functions:

@tweekmonster At first, I timeit profiled.
It will reduce about 0.0005 sec. OK.
but, types conversion is I think a little excessive.
Our goal is not a jedi-vim compatible. but it is very altered.
Understanding is easy, but users who were using the jedi-vim will be surprised.
Please let us know what you think.

@zchee

It will reduce about 0.0005 sec. OK.

:scream:

but, types conversion is I think a little excessive.

I feel that it's vim-jedi that's excessive:

Understanding is easy, but users who were using the jedi-vim will be surprised.

How about an option to enable kind abbreviation and make it disabled by default?

@tweekmonster Now deoplete-jedi completion time is 0.015 sec. Fast enough :)
My comment was the lack.
I think jedi-vim had been displayed types items should not be changed.
e.g. In your post screenshot, jedi-vim displayed function, statement.
but, this pull-request will change the

function -> def
statement -> var

I said that these problems.
Maybe (not tested) jedi-vim did not display method_descriptor or etc. That is OK.
and, type format 5 characters is little small.
I think important for programmers is completion candidates immediately can understand.
It is better you do not skip as much as possible the word type.
prop...? rugby football's scrum? lol
also, e.g. YouCompleteMe (also deoplete-clang) displayed f.
f? function...?
===
but, These are my trivial prejudice. No offense!
If you can not agree with them, I will consider merge this remains.

but, this pull-request will change

I think you missed my question about making this configurable.  I updated with an option to disable this by default.

Maybe (not tested) jedi-vim did not display method_descriptor or etc. That is OK.

The _descriptor types are for C modules.  I don't think Jedi displayed them because Jedi didn't display local variable completions.
Jedi:

deoplete-jedi:

It is better you do not skip as much as possible the word type.

I think I have a bias for less information on the screen.  I want to reduce screen draws as much as I can in the popup menu.

also, e.g. YouCompleteMe (also deoplete-clang) displayed f.

I thought about that, but if f is for function, c for class, but m for module might get confusing with deoplete's [M] for members.  Also, I'm not creative enough to shorten the other types without making it more confusing.

No offense!

私は愚かな外国人＃ 1 USA私はアイスクリームの靴を持つことができます！I will never take offense :see_no_evil:
私は、合計で18年間、沖縄+日本に住んでいました。残念ながら、私は（私の父は空軍にあった）の言語を学ぶことがなかったです。しかし、私は文化を理解し、道の単語が使用されています。あなたの英語は共感を欠いているように見えるとき、私は理解することができます。

@tweekmonster I got it. I misunderstanding Jedi behavior :(
I will check again jedi-vim was displayed context. Just a moment.
but likely this pull request is no problem.

I thought about that, but if f is for function, c for class, but m for module might get confusing with deoplete's [M] for members. Also, I'm not creative enough to shorten the other types without making it more confusing.

also,

commit: Added option to disable short types

LGTM!

No offense!

私は愚かな外国人＃ 1 USA私はアイスクリームの靴を持つことができます！I will never take offense :see_no_evil:

The meaning that I said is '悪気はありません'.
but 'offense' is 犯罪？ Crime? Oh... I made a mistake :worried:

私は、合計で16年間、沖縄+日本に住んでいました。残念ながら、私は（私の父は空軍にあった）の言語を学ぶことがなかったです。しかし、私は文化を理解し、道の単語が使用されています。あなたの英語は共感を欠いているように見えるとき、私は理解することができます。

Realy!? I was surprised!
I am thankful for your helping me. ありがとうございます :laughing:

I am thankful for your helping me. ありがとうございます :laughing:

^^;

The meaning that I said is '悪気はありません'.

English is very contextual. (文脈に大きく依存)
I understood your comment as: 私の意見の相違は強力ではありません
'offense' =  犯罪、侮辱、攻撃などがしかし、重力は、被写体（人物、エンティティ）に依存します。言葉の感情的な投影が、あまりにも、重要です。翻訳することは困難になります。
私は日本を読み取ることができません。私の経験がそれを可能にするため。より良い日本語訳のための互換性のある英単語を成形。しかし、それは完璧ではありません。コンテキストの外挿を防止するために、多くの文章の区切り。
私は完全な会話を翻訳するために長い時間がかかります。しかし、私は日本に翻訳することができます。まばら。より良い理解を容易にします。

@tweekmonster Thanks for reply in Japanese :)
Your Japanese can fully understand.
I am considering trying to merge this PR.
but, I want to discussion just a little bit.
Can I discussion with you on Twitter?
https://twitter.com/_zchee_

@zchee Sure.  This is me: https://twitter.com/cloudsiphon

@tweekmonster LGTM !


Unable to set the alarm

Hello
I have following shown in the log. Were is the problem?

Other issue is that i'm getting error Failed to call service alarm_control_panel/alarm_arm_away. must contain at least one entity_id, area_id
Thank you very much

Never  worked before  or before worked  and now  stops? In second  case  try  to change  pin  code from alarm  panel... let me know

Hello. I’ve just set up it and launched. It has never worked so far. Maybe because I’m noob in HA and Mqtt. PIN is right but I think I did not made right HA configuration file so I would appreciate if you could help me with this by sending some examples of code that I need to put into configuration file.
On 13 Sep 2020, at 02:02, Luca Calcaterra<EMAIL_ADDRESS>wrote:

Never worked before or before worked and now stops? In second case try to change pin code from alarm panel... let me know
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/lucacalcaterra/risco-mqtt-bridge/issues/35#issuecomment-691568172, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AHXRW4UWPUIYVDDMLWZHZCLSFP4WVANCNFSM4RKAPIPA.

Of it's to difficult to setup, wait untill Thursday in next release 115, then it's a official integration...
No need anymore for a seperate docker or mqtt

You mean it will be available as an home assistant official integration like these? https://www.home-assistant.io/integrations/#alarm
Or it will be part of HACS?
Thursday, you mean 17th of September?
Will app.js still be require to be launched?

Yes, official, no hacs, and yes, this Thursday when beta is over... You can already install beta if you want

https://rc--home-assistant-docs.netlify.app/integrations/risco/

Hello
I see that Risco is now officially released. I’ve installed it, added account and and pin. Connection was successful, but I cannot add alarm card because entity for risco is not found.
There is no drop down for risco in entity list
Many thanks
From<EMAIL_ADDRESS>Sent: svētdiena, 2020. gada 13. septembris 13:23
To<EMAIL_ADDRESS>Cc<EMAIL_ADDRESS><EMAIL_ADDRESS>Subject: Re: [lucacalcaterra/risco-mqtt-bridge] Unable to set the alarm (#35)
https://rc--home-assistant-docs.netlify.app/integrations/risco/
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/lucacalcaterra/risco-mqtt-bridge/issues/35#issuecomment-691652399, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AHXRW4XPO37B6CSRO5LUNZLSFSMTTANCNFSM4RKAPIPA.

no idea, working fine here :), also updated

Do you use standard alarm panel card?
Can you send me a code from the card? Maybe i can manually add it. I’ve now installed risco on 3 different HA installations including a fresh one without and no luck.
From<EMAIL_ADDRESS>Sent: ceturtdiena, 2020. gada 17. septembris 23:26
To<EMAIL_ADDRESS>Cc<EMAIL_ADDRESS><EMAIL_ADDRESS>Subject: Re: [lucacalcaterra/risco-mqtt-bridge] Unable to set the alarm (#35)
no idea, working fine here :), also updated
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/lucacalcaterra/risco-mqtt-bridge/issues/35#issuecomment-694480296, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AHXRW4ROHUPIAABOOBQC4GDSGJWFZANCNFSM4RKAPIPA.

Yeah, just default lovelace card, no code

Sorry for asking so much questions, but do you have wifi connected system? I have GSM based, maybe this is the problem as HA cannot find wifi device on my network.
From: pergolafabio<EMAIL_ADDRESS>Sent: Friday, September 18, 2020 12:39 AM
To: lucacalcaterra/risco-mqtt-bridge<EMAIL_ADDRESS>Cc: karlismaj<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [lucacalcaterra/risco-mqtt-bridge] Unable to set the alarm (#35)
Yeah, just default lovelace card, no code
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/lucacalcaterra/risco-mqtt-bridge/issues/35#issuecomment-694513493, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AHXRW4W3C3OB5A3GCKSOPITSGJ6YLANCNFSM4RKAPIPA.

You need riscocloud indeed

I do have. I use iRISCO mobile app. I was able to connect HA to my Rus iCloud account. It recognized all my zones. But I don’t see entity in the list so I could not add it to alarm card. What is the code for that? Maybe I could just write it manually...
Get Outlook for iOShttps://aka.ms/o0ukef

From: pergolafabio<EMAIL_ADDRESS>Sent: Friday, September 18, 2020 8:52:23 PM
To: lucacalcaterra/risco-mqtt-bridge<EMAIL_ADDRESS>Cc: karlismaj<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [lucacalcaterra/risco-mqtt-bridge] Unable to set the alarm (#35)
You need riscocloud indeed
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/lucacalcaterra/risco-mqtt-bridge/issues/35#issuecomment-695003270, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AHXRW4RDQZQ2GLTREAIL7BLSGOM5NANCNFSM4RKAPIPA.

No idea, no coded needed, there must be an entity created the same like the other sensors and binary sensors

Can you make some screenshots from the entities created in the risco integration? Do you only see binary sensors there? Also is there an error in your log file?
But discuss here please :
https://community.home-assistant.io/t/risco-lightsys-alarm-component/82359/156
It has nothing to do with this docker anyway

#close for inactivity


Domain is case sensitive

Hi, recognized that the name of the AD Doomain is case sensitive.
In my case "demo.local" is not working if the Domain is defined with "Demo.local"
Thanks for your effort here, Good to have an real API for GD.

Hi
I suspect this is an issue with the GlobalDashboard API and not the powershell module. The code is not doing anything to the domain/directory.
I have switched jobs since I created this module and have no access to a GlobalDashboard environment so can't really verify.
If you want to investigate and verify this your self I would suggest trying logging in directly to the API , check this post for more info

you are absolutly right.
Thanks for your help


Isolate data from this repository.

Todo:

[ ] Remove dependency on direct access of data file, use rest API.
[ ] Migrate backend to timetable_oauth Repo  and rename to timetable_backend.
[ ] Add data files in a new repo for better access management, security and maintainability.

Assess the feasibility of integrating lowdb for this task https://github.com/typicode/lowdb.

I'm interested in contributing to this issue, I can start working on it without a bounty. Please assign me this issue.

I’d like to work on this issue. While I have no prior experience with REST APIs, I have a solid understanding of backend development, repository management, and implementing secure workflows. I’m eager to learn and take on this challenge. Could you please assign this issue to me?

HI, I’m interested in working on this issue. While I’m new to REST APIs and secure workflows, I’m eager to learn and apply best practices. I have a basic understanding of backend development and repository management, and I’m confident I can contribute effectively with guidance. Could you please assign this issue to me?

Hi @USER1043, I have assigned you the issue, You have time till Jan 2nd to come up with a partially completed pull request, after which the issue will be reassigned to other participants, if there is no progress.

Thanks for assigning this! I'll begin working and let you know if I have any questions.


fix: prevent command execution from triggering unnecessary response generation

Accidentally pushed this to master which broke --non-interactive in the subagent test.
Reverted and fixing it here.

:x: 1 Tests Failed:

Tests completed
Failed
Passed
Skipped

92
1
91
0

View the full list of 1 :snowflake: flaky tests

tests.test_cli::test_subagent

Flake rate in main: 14.29% (Passed 24 times, Failed 4 times)
Stack Traces | 15.2s run time

args = ['--name', 'test-47337-test_subagent', 'test the subagent tool by computing `fib(15)` with it, where `fib(1) = 1` and `fib(2) = 1`']
runner = <click.testing.CliRunner object at 0x7f92e1711210>

    @pytest.mark.slow
    @pytest.mark.flaky(retries=2, delay=5)
    def test_subagent(args: list[str], runner: CliRunner):
        # f14: 377
        # f15: 610
        # f16: 987
        args.append(
            "test the subagent tool by computing `fib(15)` with it, where `fib(1) = 1` and `fib(2) = 1`"
        )
        print(f"running: gptme {' '.join(args)}")
        result = runner.invoke(gptme.cli.main, args)
        print(result.output)

        # apparently this is not obviously 610
        accepteds = ["377", "610"]
>       assert any([accepted in result.output for accepted in accepteds])
E       assert False
E        +  where False = any([False, False])

.../gptme/tests/test_cli.py:329: AssertionError

To view more test analytics, go to the Test Analytics Dashboard
:loudspeaker:  Thoughts on this report? Let us know!

I've still seen this happen every now and then, but I don't think this PR is salvageable.


High Seirra media keys locked up

Since moving to High Sierra after being open for a period of time the wrapper locks up the media keys. The play button caused a notification sound to ding, and no longer interacts with other media apps such as itunes. Is it possible to disable media key usage with the wrapper?

Can confirm this for me as well. Using macOS 10.13.1

I'm Also having this issue on 10.13.2, There should be somewhere to tell the OS to no give media controls to the webview, I tried fixing it myself, but im very bad at Objective-C and macOS desktop apps.
Maybe a plist entry can do that who knows.

Can also confirm on 10.13.2


tabletserver: schema info should use dba creds

@alainjobart
b/28999540
SchemaInfo should not be blocked by permission while performing
its functions. So, it should use dba creds instead of app creds.

This change is

LGTM this is even simpler!


blend_kv doesn't support other Llama bsaed models

I am trying microsoft/Phi-3-mini-128k-instruct on the blend_kv.py, where I run the scripts according to the README file but only changed the init of llm instance as below:
llm = LLM(model="microsoft/Phi-3-mini-128k-instruct",
          gpu_memory_utilization=0.8,
          tensor_parallel_size=1, max_model_len=8000)

I encountered the following bugs:

I further printed out the shape of kv cache as shown in the line 447, and found out the value is: [3994, 49152]. 49152 should be related to the hidden dimension (16*3072)
Could you help me to figure out how to adapt the kv cacheblend to microsoft Phi-3 model?
Thank you very much!

Hey @yifan1130 , thanks for the issue! We will look into this soon!


No special display for Console.Error

Describe the bug
This link says that StandardError has special coloration. In my notebook:
Console.Out.WriteLine("Oh dear");
Console.Error.WriteLine("I ate too much fruit!");

Resulted in both lines appearing the same.
Please complete the following:
Version: 1.0.460101+f1a6f50a1171b8a13119a20811674d5079e2f61b
Library version: 1.0.0-beta.23601.1+f1a6f50a1171b8a13119a20811674d5079e2f61b
Build date: 2023-12-02T22:15:47.3640630Z

The screen shots are from Jupyter Lab (where it works as expected), not from Polyglot Notebooks. It's possible the Polyglot Notebooks code is writing error output to the wrong API. Otherwise, this would be a VS Code issue.

Same behaviour for me. It should perhaps be stated more explicitly that this is for C# code cells, as Powershell cells to format Write-Warning in yellow and Write-Error in red (for example)


Resolves AirlockVisualizer is Obsolete

About the PR

Splits the AirlockVisualizer into a component/system pair.
TODO:

[ ] Testing

Media

[ ] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Pretty sure airlock is a component already

It's in shared. Do you want me to move the visual data to shared (and thus the server) or give AirlockComponent a client version?

A bit broken somehow. Tested because I was wondering if it'd fix the airlock bolted/ea lights sometimes not showing.

Reopen when you come back to this.

@DrSmugleaf
Ready to reopen. I've fixed the last bug I found (airlocks having active boltlights by default).

Ready to reopen. I've fixed the last bug I found (airlocks having active boltlights by default).

i think it reopens automatically as soon as you push to your branch

I've already pushed to the branch and it hasn't reopened so there may be
something wrong on my end if it's not getting the commits.
On Fri, Mar 24, 2023, 9:32 PM AJCM-git @.***> wrote:

Ready to reopen. I've fixed the last bug I found (airlocks having active
boltlights by default).
i think it reopens automatically as soon as you push to your branch
—
Reply to this email directly, view it on GitHub
https://github.com/space-wizards/space-station-14/pull/13884#issuecomment-1483719758,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AMYZV6DSMPDJY4Q52RE5ZM3W5ZYNHANCNFSM6AAAAAAUP6C5DU
.
You are receiving this because you authored the thread.Message ID:
@.***>


Ready for production?

First things first: thanks for your great work so far!
I've a simple question: Would you consider connect to be ready for production use?
If not: what are the blockers?

@AlexZeitler thanks for your kind words.
This code has been run in production by several enterprise and web users for more than one year with no reported operational issues.
We do not yet have a "stable" release, meaning parts of the code are still in flux and there may will be a few breaking changes as we continue to make improvements to the design and usability of the software.
We're hoping to release an 0.2.0 branch by the end of this year. That branch will only receive bug fixes and security patches, while further breaking changes will take place in master or 0.3.0.
The biggest blockers for adoption at the moment I believe are related to usability. We need better documentation and we're hard at work improving the developer experience. If you're willing to get your hands dirty and participate in the discussions on Gitter, Slack or IRC, Anvil Connect is ready to go.

@christiansmith Thanks for your fast reply.
I'll try to get things ready and will hop in to Slack if I need some guidance.
If possible I'll try to contribute to the docs at least.


How do I make this use my gpu instead of cpu

How do I force it to use my GPU with only 4gb of VRAM. I do not care about memory errors and would like to try it. I have no trouble running RVC and figured I could give this is a try but waiting 15 minutes for a cover is just too much.

Maybe there is an easier way, but I am not really a programmer. And since this isnt solved since three weeks I wasted a whole day to find a solution:

Create a virtual environment: cd to your main AICoverGen folder and then "python -m venv venv"
Activate venv: venv\Scripts\activate
pip install -r requirements.txt
Close that, create a .bat file (I called it run.bat) in your AICoverGen folder with the code:
"@echo off
cd C:\Users\Dennis\Downloads\AICoverGen-main
call venv\Scripts\activate
python src/webui.py
call venv\Scripts\deactivate"
Start AICoverGen using your venv by just doubleclicking it. For me it uses GPU now. From me I reduced the time for a long song from over 7 Minutes to 50 seconds.

Maybe there is an easier way, but I am not really a programmer. And since this isnt solved since three weeks I wasted a whole day to find a solution:

Create a virtual environment: cd to your main AICoverGen folder and then "python -m venv venv"
Activate venv: venv\Scripts\activate
pip install -r requirements.txt
Close that, create a .bat file (I called it run.bat) in your AICoverGen folder with the code:
"@echo off
cd C:\Users\Dennis\Downloads\AICoverGen-main
call venv\Scripts\activate
python src/webui.py
call venv\Scripts\deactivate"
Start AICoverGen using your venv by just doubleclicking it. For me it uses GPU now. From me I reduced the time for a long song from over 7 Minutes to 50 seconds.

Was it working (with cpu) before you used a virtual environment?


arch: x86: fix build with ACPI disabled

arch/x86/core/intel64/cpu.c has been changed recently to always include zephyr/acpi/acpi.h, but at the same time the acpica module has also been changed to only expose the headers when enabled, so this file does not build anymore if CONFIG_ACPI=n
Fix this by excluding the ACPI code here entirely when ACPI is not enabled.

Uh, dup: https://github.com/zephyrproject-rtos/zephyr/pull/62680


Validator Fields with Mask

Is it possible to have a Validator field with a regex mask? like "xxx-xxx-xxxx"
I want it automatically adds the extra characters. If the user inputs "1234567890" it shows "123-456-7890" but without compromising the validations.
Any tips?

I think a textField mask is beyond the scope of this library as it really has nothing to do with validation but the appearance of the text. That being said, there are open source projects on github that accomplish just what you're looking for. One off the top of my head is [!link]https://github.com/artemkrachulov/AKMaskField


Consumer complaint API workshopper?

@contolini and I very briefly talked about this a long time ago...
Wouldn't it be cool if we developed a nodeschool style workshopper for working with the consumer complaint database?
I'm not really sure what that would look like, but let's talk about it here! I'm volunteering to work on this, but I'd like to collaborate with someone on it.
For some inspiration, 18F used the CCDB for a data visualization workshop

We should check in with @OpenGlobe and @ErieMeyer before writing the curriculum. I'm curious how the workshop went.

Very happy to help!

Closing, though this would be a great project for CFPB's hack day!


look at bringing list--touch styles from _new-start-flow.scss to sq2

won't fix - this variant is not necessary


Enable unit testing for ciao-storage

requires ceph support to test the ceph driver.

I discussed this with @markdryan today and we decided it would be best to move this to being a test inside the BAT infrastructure so that it would a.) run on release cluster / b.) could run under singleVM c.)  not need to worry about getting ceph working on travis

@rbradford ok. you can modify the title to reflect the work that will be done.


Monorepo assets serving error

Describe the bug
This is a break from 2.0.4, this worked in 2.0.3
This is an issue for a monorepo. All of the dependencies are in the node_module folder in the monorepo root folder.
In dev mode, when importing library that import assets (e.g. fonts), the dependencies are resolved from the monorepo root (with an absolute path in comparison with classic repo that is relative), the URL of the asset is<EMAIL_ADDRESS>but it return an Not Found Error
It not work in dev mode but the build work
Reproduction
Reproduction repo: https://github.com/louisduhalberruer/vite-fs-issue
I locked vite with 2.0.4 version
System Info

vite version: 2.0.4
Operating System: macOS
Node version: 15.2
Package manager (npm/yarn/pnpm) and version: npm v7.6

Logs (Optional if provided reproduction)

Run vite or vite build with the --debug flag.
Provide the error log here.

Also encountering the same error. Not a monorepo setup, just loading assets files from node_modules. The @fs url is correct and files exist, but returns 404.
Pinning to 2.0.3 resolves the issue.

closed via 4f942bef

Thank you for your responsiveness and efficiency


Regex to adapt

Hi ! Thanks for this package ;)
But my notion URL is not notion.so but notion.site , I think that you'll need to adapt to accept other domain name.
Can I open a PR for that pls ? ;)
https://github.com/asnunes/notion-page-to-html/blob/f0de0d77895bcfd71fa6b258e3b25dff82eb43bc/src/infra/usecases/to-page-id/url-validator.ts#L16

Bumping this, my URL samarthdave.notion.site/... is throwing an Invalid Page URL error and I've temporarily changed the code to:
private _isNotionPargeUrl(): boolean {
  return true;
}

Not ideal. Also it isn't getting the cover image or a table correctly... Might be because I hardcoded true in but I'm not sure.


Minimum Path Sum

Provide a well-documented solution for the leetcode problem : https://leetcode.com/problems/minimum-path-sum/

I want to work on this issue.


[Feature]support dataSketches include Quantile Sketches、Theta Sketch、Frequency…

… Sketches.
Why I'm doing:
What I'm doing:
Fixes #50671
What type of PR is this:

[ ] BugFix
[x] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Does this PR entail a change in behavior?

[ ] Yes, this PR will result in a change in behavior.
[x] No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

[ ] Interface/UI changes: syntax, type conversion, expression evaluation, display information
[ ] Parameter changes: default values, similar parameters but with different default values
[ ] Policy changes: use new policy to replace old one, functionality automatically enabled
[ ] Feature removed
[ ] Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

[x] I have added test cases for my bug fix or my new feature
[x] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

[ ] This is a backport pr

Bugfix cherry-pick branch check:

[ ] I have checked the version labels which the pr will be auto-backported to the target branch

[x] 3.3
[ ] 3.2
[ ] 3.1
[ ] 3.0
[ ] 2.5

Thanks for you contributions. Can you fix failed tests and try it again?
The new agg functions cannot be used in AggState, so you can add them into UNSUPPORTED_AGG_STATE_FUNCTIONS to skip uts.
    // Unsupported functions for agg state combinator.
    public static final Set<String> UNSUPPORTED_AGG_STATE_FUNCTIONS =
            new ImmutableSortedSet.Builder<>(String.CASE_INSENSITIVE_ORDER)
                    // TODO: Add unsupported functions here.
                    .add(GROUP_CONCAT) // Unsupported function
                    // UNSUPPORTED functions
                    .add(COUNT_IF) // count_if is a syntax sugar in fe
                    .add(HLL_RAW) // hll_raw use `hll` as input, use existed `hll_union` instead
                    // Internal functions are not supported.
                    .add(FLAT_JSON_META)
                    .add(EXCHANGE_BYTES)
                    .add(EXCHANGE_SPEED)
                    .add(FIRST_VALUE_REWRITE)
                    .add(HISTOGRAM)
                    .add(DICT_MERGE)
                    // Functions with constant contexts in be are not supported.
                    .add(WINDOW_FUNNEL)
                    .add(APPROX_TOP_K)
                    .add(INTERSECT_COUNT)
                    .add(LC_PERCENTILE_DISC)
                    .add(MAP_AGG)
                    .build();

@

Thanks for you contributions. Can you fix failed tests and try it again?
The new agg functions cannot be used in AggState, so you can add them into UNSUPPORTED_AGG_STATE_FUNCTIONS to skip uts.
    // Unsupported functions for agg state combinator.
    public static final Set<String> UNSUPPORTED_AGG_STATE_FUNCTIONS =
            new ImmutableSortedSet.Builder<>(String.CASE_INSENSITIVE_ORDER)
                    // TODO: Add unsupported functions here.
                    .add(GROUP_CONCAT) // Unsupported function
                    // UNSUPPORTED functions
                    .add(COUNT_IF) // count_if is a syntax sugar in fe
                    .add(HLL_RAW) // hll_raw use `hll` as input, use existed `hll_union` instead
                    // Internal functions are not supported.
                    .add(FLAT_JSON_META)
                    .add(EXCHANGE_BYTES)
                    .add(EXCHANGE_SPEED)
                    .add(FIRST_VALUE_REWRITE)
                    .add(HISTOGRAM)
                    .add(DICT_MERGE)
                    // Functions with constant contexts in be are not supported.
                    .add(WINDOW_FUNNEL)
                    .add(APPROX_TOP_K)
                    .add(INTERSECT_COUNT)
                    .add(LC_PERCENTILE_DISC)
                    .add(MAP_AGG)
                    .build();

@LiShuMing Fixed, but the CreateTableWithAggStateTest.testCreateTableWithAggStateHllSketch test fails. Can I remove CreateTableWithAggStateTest.testCreateTableWithAggStateHllSketch?

@merigify rebase

@mergify rebase


Add a more realistic API Key example

Current Behavior
The current API Key example is simple, as seen below

Expected Behavior
A more realistic default example of an API Key and the ability to update the example itself
Example API key: k2KJBhmW5LvzleNv7JKLV1j2brjbUlxpUnV3XCXFBDTc5Dj2vKLkMAd1cAIjSg4g

Agree. I believe OpenAPI doesn't allow examples here, but would be nice to add a "x-stoplight-example" until OpenAPI supports?


At the end of the only one limit period, number of lines suppressed is not logged.

If there's only one limit period, there's no message at the end showing the number of lines suppressed.
For example for the following code:
private static final Logger logger = LoggerFactory.getLogger(getClass());
private static final RateLimitedLog rateLimitedLog = RateLimitedLog
            .withRateLimit(logger)
             .maxRate(20)
            .every(Duration.ofMinutes(1))
            .build();

I think this should output "(suppressed 5 logs similar to 'Testing: {}' in PTxxS)", but it's not.
for (int i = 0; i < 25; i++)
    logger.info("Testing: {}", i);
logger.info("End");

In contrast, the following code works. Notice each number is output after 2s sleep, so it's 30 logs per minute, for more than 2 mins. Then it logs "(suppressed 10 logs similar to 'Testing: {}' in PT21.944S)"
for (int i = 0; i < 90; i++) {
     logger.info("Testing: {}", i);
     Thread.sleep(2000);
}
logger.info("End");

I am not sure whether this is by design or a potential bug?

I think https://github.com/Swrve/rate-limited-logger/pull/12/files should fix it....

ok, that's in version 2.0.1, just released -- please reopen if this issue isn't fixed :)


Fixes #16

Fixes https://github.com/google/pygtrie/issues/16

I signed CLA.

test install
C:\Users\wannaphong\Desktop>git clone https://github.com/wannaphongcom/pygtrie.git
C:\Users\wannaphong\Desktop\pygtrie>pip install -e .
Obtaining file:///C:/Users/wannaphong/Desktop/pygtrie
Installing collected packages: pygtrie
  Running setup.py develop for pygtrie
Successfully installed pygtrie

Thanks, applied.


Add foreignKey attribute to Model class

Give the abity to change the default foreign key of a model, so when we have a custom foreign key we don't have to passe the $foreignKey each time whe add a relationship

Could you include tests please?

I'm a newbie I don't know how to do it

Just override getForeignKey in your own  models.


Populating property to DateTime from DateTime truncates milliseconds.

Lets say I have the following table:
CREATE TABLE MY_TABLE( Id Number, CreateDate DateTime)
I have the following class:
public class MyClass {    public int Id {get; set;}    public DateTime CreateDate {get; set;} }
I have inserted values with milliseconds in the database and they show up in the database as:
1,3/25/2022 10:34:34.123
If I execute: var result = await _client.QueryAsync<MyClass>("SELECT * FROM MY_TABLE WHERE ID=1;")
result.CreateDate comes back as 3/25/2022 10:34:34.000

Hi!
That's weird, I can't reproduce this.
Can you please get a raw response and ensure that raw value actually contains milliseconds?
var rawResponse = await _client.QueryRawResponseAsync("SELECT * FROM MY_TABLE WHERE ID=1;");
var dateTimeCellValue = rawResult.Rows[0][1]; // should have milliseconds (.123)

In case of 2022-03-25 10:34:34.123 it should return exactly<PHONE_NUMBER>.123000000.

This can be closed,  truncation occurred before actually writing to snowflake.  There was no issue.

Ok - good.


remove left over text fragment

PR #23 was incomplete since I missed to also remove the last line of a removed sentence. This PR fixes it.

@cupracer , thank you!


PostgresDsn multiple hosts without TLD

Initial Checks

[X] I have searched GitHub for a duplicate issue and I'm sure this is something new
[X] I have searched Google & StackOverflow for a solution and couldn't find anything
[X] I have read and followed the docs and still think this is a bug
[X] I am confident that the issue is with pydantic (not my code, or another library in the ecosystem like FastAPI or mypy)

Description
Hi!
I have two questions:

From docs "PostgresDsn: user info required, TLD not required, host required, as of V.10 PostgresDsn supports multiple hosts". User info required but postgresql docs has example "postgresql://host1:123,host2:456/somedb?target_session_attrs=any&application_name=myapp"
It seems PostgresDsn doesn't work properly with multiple hosts without TLD

Thank you
Example Code
In [1]: import pydantic
   ...: from pydantic import BaseModel, PostgresDsn
   ...:
   ...: class M(BaseModel):
   ...:     url: PostgresDsn
   ...:

# Not ok
In [2]: M(url="postgresql://host1:123,host2:456/somedb?target_session_attrs=any&application_name=myapp")
---------------------------------------------------------------------------
ValidationError                           Traceback (most recent call last)
Cell In [2], line 1
----> 1 M(url="postgresql://host1:123,host2:456/somedb?target_session_attrs=any&application_name=myapp")

File ~/.local/share/virtualenvs/.../lib/python3.8/site-packages/pydantic/main.py:342, in pydantic.main.BaseModel.__init__()

ValidationError: 1 validation error for M
url
  userinfo required in URL but missing (type=value_error.url.userinfo)

# Not ok
In [3]: M(url="postgresql://u:p@host1:123,host2:456/somedb?target_session_attrs=any&application_name=myapp")
---------------------------------------------------------------------------
ValidationError                           Traceback (most recent call last)
Cell In [3], line 1
----> 1 M(url="postgresql://u:p@host1:123,host2:456/somedb?target_session_attrs=any&application_name=myapp")

File ~/.local/share/virtualenvs/.../lib/python3.8/site-packages/pydantic/main.py:342, in pydantic.main.BaseModel.__init__()

ValidationError: 1 validation error for M
url
  build() needs keyword-only argument host (type=type_error)

# Add .com
# Ok
In [4]: M(url="postgresql://u:p@host1.com:123,host2.com:456/somedb?target_session_attrs=any&application_name=myapp")
Out[4]: M(url=PostgresDsn('postgresql://u:p@host1.com:123,host2.com:456/somedb?target_session_attrs=any&application_name=myapp', ))

Python, Pydantic & OS Version
pydantic version: 1.10.2
            pydantic compiled: True
                 install path: /home/vagrant/.local/share/virtualenvs/.../lib/python3.8/site-packages/pydantic
               python version: 3.8.6 (default, Dec 22 2020, 17:04:29)  [GCC 7.5.0]
                     platform: Linux-4.15.0-192-generic-x86_64-with-glibc2.27
     optional deps. installed: ['dotenv', 'email-validator', 'typing-extensions']

Affected Components

[ ] Compatibility between releases
[X] Data validation/parsing
[ ] Data serialization - .dict() and .json()
[ ] JSON Schema
[ ] Dataclasses
[ ] Model Config
[X] Field Types - adding or changing a particular data type
[ ] Function validation decorator
[ ] Generic Models
[ ] Other Model behaviour - construct(), pickling, private attributes, ORM mode
[ ] Plugins and integration with other tools - mypy, FastAPI, python-devtools, Hypothesis, VS Code, PyCharm, etc.

There are a couple of problems here.

PostgresDsn(...) has some slightly weird behaviour and isn't expected to work like this. I agree that this is very confusing, it should either work properly, or fail completely.
There are a whole host of problems with URL types see #4470 for some explanation, basically we run some different logic only if there's a TLD, the problem as per #4470 is that if we run that logic on all URLs, a whole bunch of tests fail.

The medium term solutions is to move to a dedicated URL validation library in V2, there is'nt really a good short term solution I'm afraid, you might be best to implement your own validation.

This is already working on V2. 🙏


Automated cherry pick of #3950: fix: 1. service-config not support key=value pair 2. sync_purge_removed_resources not working

Cherry pick of #3950 on release/2.12.
#3950: fix: 1. service-config not support key=value pair 2. sync_purge_removed_resources not working

Codecov Report

:exclamation: No coverage uploaded for pull request base (release/2.12@ae4ac10). Click here to learn what that means.
The diff coverage is n/a.

@@              Coverage Diff               @@
##             release/2.12   #3951   +/-   ##
==============================================
  Coverage                ?   6.92%
==============================================
  Files                   ?     500
  Lines                   ?   84458
  Branches                ?       0
==============================================
  Hits                    ?    5850
  Misses                  ?   78114
  Partials                ?     494

Flag
Coverage Δ

#aFlag
6.92% <ø> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae4ac10...940626f. Read the comment docs.


Tab UI

A simple tabs UI was implemented in https://github.com/alanshaw/planetarybrowser/commit/0b2dbc3db6df9a0c2a6a53ddaa0d72e2f05a6948 - it's far from perfect, but lets track improvements in separate issues.


Resources without generation will not skip events

Fixes #2108
If the metadata.generation is 0, the event will now still trigger a
reconciliation.

Description of the change:
Motivation for the change:

/lgtm


TikZ

Would you mind adding TikZ support like in this Obsidian plugin? https://github.com/artisticat1/obsidian-tikzjax

PGF/TikZ and Asymptote would be a dream

There is a PR for kroki to support PGF/TikZ that I will keep an eye on: https://github.com/yuzutech/kroki/pull/1440

There is a PR for kroki to support PGF/TikZ that I will keep an eye on: yuzutech/kroki#1440

Merged yesterday

Thanks for the info.
I will release a new plugin version with Tikz support, as soon as the Kroki PR also has been released and deployed. (The latest Kroki release does not include the new feature yet)

Now that the latest Korki release, v0.21.0, includes PGF/Tikz support, I've released a new version of the plugin to leverage this.


Integer ConfigItems always default to zero

New Issue Checklist

[x] Updated fastlane to the latest version
[x] I have read the [Contribution Guidelines] (https://github.com/fastlane/fastlane/blob/master/CONTRIBUTING.md) 🔑

Issue Description
ConfigItem incorrectly causes all instances with data_type Integer to default to 0.
The issue is the auto_convert_value method on ConfigItem. If the data_type is Integer, that method unconditionally casts value to Integer. Casting nil to Integer results in 0, not nil. That means that by the time that control reaches here, value is not nil, so the default value is not properly substituted.
A specific example of the bug is in pilot's wait_processing_interval parameter. It should default to 30, but instead it is read as 0 here, in the BuildManager. As a result, the sleep has no effect, and instead just loops as fast as possible, constrained only by the response time of iTunes Connect, which is about a second in my tests. You can see the evidence of this issue in my log output, below:
[12:05:25]: Waiting for iTunes Connect to process the new build
[12:05:27]: Waiting for iTunes Connect to process the new build
[12:05:28]: Waiting for iTunes Connect to process the new build
[12:05:29]: Waiting for iTunes Connect to process the new build
[12:05:30]: Waiting for iTunes Connect to process the new build

showing that we're hitting iTunes Connect about once per second, instead of the intended default once per thirty seconds.
The fix should be pretty straightforward, and I may even take a swing at it after #3888. We'll want to check all ConfigItems that use the type Integer, though, to make sure we're not introducing any regressions.
Complete output when running fastlane, including the stack trace and command used
▶ fastlane-test-app (master) $ fastlane beta
[12:03:55]: -------------------------------------------------
[12:03:55]: --- Step: Verifying required fastlane version ---
[12:03:55]: -------------------------------------------------
[12:03:55]: fastlane version valid
[12:03:55]: ------------------------------
[12:03:55]: --- Step: default_platform ---
[12:03:55]: ------------------------------
[12:03:55]: Driving the lane 'ios beta' 🚀
[12:03:55]: ------------------------------------
[12:03:55]: --- Step: increment_build_number ---
[12:03:55]: ------------------------------------
[12:03:55]: $ cd /Users/ravron/src/oss/fastlane-test-app && agvtool next-version -all
[12:03:56]: ▸ Setting version of project fastlane-test-app to:
[12:03:56]: ▸ 7.
[12:03:56]: ▸ Also setting CFBundleVersion key (assuming it exists)
[12:03:56]: ▸ Updating CFBundleVersion in Info.plist(s)...
[12:03:56]: ▸ Updated CFBundleVersion in "fastlane-test-app.xcodeproj/../fastlane-test-app/Info.plist" to 7
[12:03:56]: ▸ Updated CFBundleVersion in "fastlane-test-app.xcodeproj/../fastlane-test-appTests/Info.plist" to 7
[12:03:56]: ▸ Updated CFBundleVersion in "fastlane-test-app.xcodeproj/../fastlane-test-appUITests/Info.plist" to 7
[12:03:56]: ------------------------
[12:03:56]: --- Step: git_commit ---
[12:03:56]: ------------------------
[12:03:56]: $ git commit -m 'Bump build number' .
[12:03:56]: ▸ [master 22c80ca] Bump build number
[12:03:56]: ▸ 4 files changed, 5 insertions(+), 5 deletions(-)
[12:03:56]: Successfully committed "." 💾.
[12:03:56]: -----------------
[12:03:56]: --- Step: gym ---
[12:03:56]: -----------------
[12:03:56]: Installing provisioning profile...
[12:03:56]: xcrun xcodebuild -list -project './fastlane-test-app.xcodeproj'

+---------------------------+----------------------------------------------------------------------+
|                                      Summary for gym 1.6.2                                       |
+---------------------------+----------------------------------------------------------------------+
| scheme                    | fastlane-test-app                                                    |
| project                   | ./fastlane-test-app.xcodeproj                                        |
| provisioning_profile_path | /Users/ravron/src/oss/fastlane-test-app/AppStore_com.ravron.fastl... |
| destination               | generic/platform=iOS                                                 |
| output_name               | fastlane-test-app                                                    |
| clean                     | false                                                                |
| output_directory          | .                                                                    |
| silent                    | false                                                                |
| use_legacy_build_api      | false                                                                |
| buildlog_path             | ~/Library/Logs/gym                                                   |
+---------------------------+----------------------------------------------------------------------+

[12:03:58]: $ set -o pipefail && xcodebuild -scheme 'fastlane-test-app' -project './fastlane-test-app.xcodeproj' -destination 'generic/platform=iOS' -archivePath '/Users/ravron/Library/Developer/Xcode/Archives/2016-04-23/fastlane-test-app 2016-04-23 12.03.58.xcarchive' archive | tee /Users/ravron/Library/Logs/gym/fastlane-test-app-fastlane-test-app.log | xcpretty
[12:03:59]: ▸ Building fastlane-test-app/fastlane-test-app [Release]
[12:03:59]: ▸ Check Dependencies
[12:04:00]: ▸ Compiling ViewController.swift
[12:04:00]: ▸ Compiling AppDelegate.swift
[12:04:00]: ▸ Compiling ViewController.swift
[12:04:00]: ▸ Compiling AppDelegate.swift
[12:04:00]: ▸ Compiling fastlane-test-app_vers.c
[12:04:00]: ▸ Compiling fastlane-test-app_vers.c
[12:04:00]: ▸ Linking fastlane-test-app
[12:04:00]: ▸ Linking fastlane-test-app
[12:04:01]: ▸ Compiling LaunchScreen.storyboard
[12:04:01]: ▸ Compiling Main.storyboard
[12:04:01]: ▸ Processing Info.plist
[12:04:01]: ▸ Generating 'fastlane-test-app.app.dSYM'
[12:04:02]: ▸ Touching fastlane-test-app.app
[12:04:04]: ▸ Signing /Users/ravron/Library/Developer/Xcode/DerivedData/fastlane-test-app-aaesqqfcggjaxuehimezpfbmtnaj/Build/Intermediates/ArchiveIntermediates/fastlane-test-app/InstallationBuildProductsLocation/Applications/fastlane-test-app.app
[12:04:04]: ▸ Touching fastlane-test-app.app.dSYM
[12:04:04]: ▸ Archive Succeeded
[12:04:04]: Successfully stored the archive. You can find it in the Xcode Organizer.
[12:04:04]: $ /usr/bin/xcrun /Library/Ruby/Gems/2.0.0/gems/gym-1.6.2/lib/assets/wrap_xcodebuild/xcbuild-safe.sh -exportArchive -exportOptionsPlist '/var/folders/g7/rfpy5fcx4k9_vx_v7yqpkpy5wz1tvr/T/gym20160423-58703-i1y9fb_config.plist' -archivePath '/Users/ravron/Library/Developer/Xcode/Archives/2016-04-23/fastlane-test-app 2016-04-23 12.03.58.xcarchive' -exportPath '/var/folders/g7/rfpy5fcx4k9_vx_v7yqpkpy5wz1tvr/T/gym20160423-58703-1jpw430.gym_output'
[12:04:17]: Compressing 1 dSYM(s)
[12:04:17]: $ cd '/Users/ravron/Library/Developer/Xcode/Archives/2016-04-23/fastlane-test-app 2016-04-23 12.03.58.xcarchive/dSYMs' && zip -r '/Users/ravron/src/oss/fastlane-test-app/fastlane-test-app.app.dSYM.zip' *.dSYM
[12:04:17]: ▸ updating: fastlane-test-app.app.dSYM/ (stored 0%)
[12:04:17]: ▸ updating: fastlane-test-app.app.dSYM/Contents/ (stored 0%)
[12:04:17]: ▸ updating: fastlane-test-app.app.dSYM/Contents/Info.plist (deflated 52%)
[12:04:17]: ▸ updating: fastlane-test-app.app.dSYM/Contents/Resources/ (stored 0%)
[12:04:17]: ▸ updating: fastlane-test-app.app.dSYM/Contents/Resources/DWARF/ (stored 0%)
[12:04:17]: ▸ updating: fastlane-test-app.app.dSYM/Contents/Resources/DWARF/fastlane-test-app (deflated 73%)

[12:04:17]: Successfully exported and compressed dSYM file
[12:04:17]: Successfully exported and signed the ipa file:
[12:04:17]: /Users/ravron/src/oss/fastlane-test-app/fastlane-test-app.ipa
[12:04:17]: -------------------
[12:04:17]: --- Step: pilot ---
[12:04:17]: -------------------
[12:04:17]: Login to iTunes Connect<EMAIL_ADDRESS>[12:04:20]: Login successful
[12:04:20]: Ready to upload new build to TestFlight (App:<PHONE_NUMBER>)...
[12:04:20]: Going to upload updated app to iTunes Connect
[12:04:20]: This might take a few minutes, please don't interrupt the script
[12:05:25]: iTunes Transporter successfully finished its job
[12:05:25]: ------------------------------------------------------------------------------------------------------
[12:05:25]: Successfully uploaded package to iTunes Connect. It might take a few minutes until it's visible online.
[12:05:25]: ------------------------------------------------------------------------------------------------------
[12:05:25]: Successfully uploaded the new binary to iTunes Connect
[12:05:25]: Waiting for iTunes Connect to process the new build
[12:05:27]: Waiting for iTunes Connect to process the new build
[12:05:28]: Waiting for iTunes Connect to process the new build
[12:05:29]: Waiting for iTunes Connect to process the new build
[12:05:30]: Waiting for iTunes Connect to process the new build
<snip>
[12:15:52]: Waiting for iTunes Connect to process the new build
[12:15:53]: Waiting for iTunes Connect to process the new build
[12:15:53]: Waiting for iTunes Connect to process the new build
[12:15:54]: Waiting for iTunes Connect to process the new build
[12:15:55]: Waiting for iTunes Connect to process the new build
[12:15:58]: Waiting for iTunes Connect to finish processing the new build (1.0 - 7)
[12:15:58]: Successfully finished processing the build
[12:15:58]: You can now tweet:
[12:15:58]: iTunes Connect #iosprocessingtime 11 minutes
[12:15:58]: Distributing new build to testers
[12:16:00]: Successfully distributed build to beta testers 🚀

+------+-------------------------------------+-------------+
|                     fastlane summary                     |
+------+-------------------------------------+-------------+
| Step | Action                              | Time (in s) |
+------+-------------------------------------+-------------+
| 1    | Verifying required fastlane version | 0           |
| 2    | default_platform                    | 0           |
| 3    | increment_build_number              | 0           |
| 4    | git_commit                          | 0           |
| 5    | gym                                 | 20          |
| 6    | pilot                               | 703         |
+------+-------------------------------------+-------------+

[12:16:00]: fastlane.tools just saved you 12 minutes! 🎉

Configuration Files
Fastfile:
▶ fastlane (master) $ cat Fastfile
# This is the minimum version number required.
# Update this, if you use features of a newer version
fastlane_version "1.81.0"

default_platform :ios

platform :ios do
  desc "Submit a new Beta Build to Apple TestFlight"
  desc "This will also make sure the profile is up to date"
  lane :beta do
    # match(type: "appstore") # more information: https://codesigning.guide
    increment_build_number
    git_commit(path:".", message:"Bump build number")
    gym(scheme: "fastlane-test-app") # Build your app - more options available
    # Note that wait_processing_interval is not specified here, so it *should* default to 30
    pilot
  end
end

Environment
fastlane version: 1.81.0
Do you use bundler to execute fastlane (i.e. bundle exec fastlane)? No
Do you use a Ruby environment manager (e.g. chruby, rbenv, rvm)? No

@ravron Thanks for reaching out about this and including such detailed investigation. We are going to investigate this over here. But, if anyone wants to submit a PR we can have preliminary discussions about that here too. Thanks! 👍

@TKBurner No problem. A note: though this issue affects pilot, it's really more of fastlane_core bug, so that label might be more appropriate. Of course, I defer to your judgement.

@ravron Thanks for following up. I'll mark it that way 👍

This will go out in the next release of fastlane_core


Respect what the APIs consume

Fixes #287.
Changes proposed in this pull request:

If application/json is not listed in the consumes then don't parse and validate the request body.

@31z4  Thanks for you PR. Could you please write at least one test covering this issue?

@rafaelcaricio of course. Will do this a bit later as well as fix the emerged failures.

Coverage decreased (-0.3%) to 99.725% when pulling 927e8a01544b003bd3662f744ab2aec135ffe375 on 31z4:consumes into 58c99a0988ee2aa2a08d81a48826a913611b21d9 on zalando:master.

Coverage decreased (-0.3%) to 99.725% when pulling 6abd065f0c9b68ba0f70b6f2e48521288f97ac40 on 31z4:consumes into 58c99a0988ee2aa2a08d81a48826a913611b21d9 on zalando:master.

Coverage decreased (-0.2%) to 99.817% when pulling 91aeb691c7f715d5f476e881393b174c9df36672 on 31z4:consumes into 58c99a0988ee2aa2a08d81a48826a913611b21d9 on zalando:master.

Coverage decreased (-0.2%) to 99.817% when pulling 58da2b308d5e34119366c209d0cfa6ccf33c15ae on 31z4:consumes into 58c99a0988ee2aa2a08d81a48826a913611b21d9 on zalando:master.

Coverage remained the same at 100.0% when pulling 1fb776ebbd11ee3849e2f11297ef6107b0cbc745 on 31z4:consumes into 58c99a0988ee2aa2a08d81a48826a913611b21d9 on zalando:master.

@jmcs Thanks for your feedback!

Coverage remained the same at 100.0% when pulling e01171a6ac62644f0323af1e7f7d668fd6aee7f8 on 31z4:consumes into 58c99a0988ee2aa2a08d81a48826a913611b21d9 on zalando:master.

Coverage remained the same at 100.0% when pulling 0d014d093c153feba94e4302695b474915001509 on 31z4:consumes into 58c99a0988ee2aa2a08d81a48826a913611b21d9 on zalando:master.

👍


Compile - no matching function error

Hello,
I get the error Clang : no matching function for call to 'GetProcessAffinityMask' when trying to compile. No problems compiling in Visual Studio C++. The function is declared in WinBase.h which is included in Windows.h which is included in my company's standard header which is included in StdAfx.h (precompiled header).
Using Visual Studio 15.6.7
Thanks
.

I think the problem is that it thinks I'm compiling in 64 bit mode.
PDWORD_PTR is defined as a an unsigned long pointer in 32 bits; as a unsigned long long pointer in 64 bits. How do I tell clang that I'm compiling in 32 bits?

Hello,
First of all we're sorry for the long response delay.
We've tested this scenario using the -m32 flag and we think it should work for you.
We don't have UI support for it right now so you'll have to manually enable it:

locate clang-build.ps1 in %LOCALAPPDATA%
open script and locate function Get-CompileCallArguments
add "-m32" to the clang argument list variable$projectCompileArgs
restart Visual Studio and try compiling again using Clang Power Tools

Note that the -m32 flag is incompatible with x64 builds of LLVM so you'll need to make sure the x86 LLVM is installed and added to the PATH environment variable.
Please test this and let us know if your code compiles.

We looked a bit further into this and it looks like -m32 can be set from General > Compile flags
You can skip the manual instructions I mentioned above.

This issue will be addressed as part of #380
Thanks for the feedback 👍


[CI] Automatically roll pinned toolchain versions

This is prototyped in #408, but it's blocked because the PRs which are generated are submitted by the github-actions bot, which Google's CLA bot doesn't recognize. There are workarounds available; I just need to get around to implementing one of them.

Closed in https://github.com/google/zerocopy/pull/408.


FoBo Components - bootstrap3-wysihtml5

Consider this as a component in FoBo's Component sub module
#50 my be better candidate
http://waxolunist.github.io/bootstrap3-wysihtml5-bower/
or try find something over at http://ngmodules.org/

Will wait for ng2 and its component approach


Fixed broken links in the READMEs for KV Certificates and ACS Job Router

Fixes: #39444 and #39445.

/check-enforcer override


Auto Detect which linter to use based on config files in current project

It would be really nice if this could look at my currently open project for linter config files and if present, use whichever (supported) linter they are for and the settings contained within.
Ex. Recognize that I have .eslintrc and .eslintignore files in the root project folder.  Enable eslint with the settings contained in the two files.

@OffByNone Interesting idea. The way interactive linter works is that it will look at the folder for file you open and traverse the folder hierarchy searching for a settings file corresponding to the configured linter.  I am not sure how well your approach would work simply because of performance.
Would you be interested in creating a PR?

At the moment I am quite busy, and don't have the time.  If I get some time I will see what I can do.


About WeightedBCEWithLogitLoss

Hi, I have  a problem in understanding your code of class WeightedBCEWithLogitLoss, showed as follow. It seems the input is logits, but there isn't any sigmoid or softmax operation done on it. And I'm confused of that two lines. Is the loss computation same as pytorch BCEWithLogitLoss???

Yes，the designed loss is different from the vanilla BCEWithLogitLoss. Besides the weights,  it is implemented without the sigmoid or softmax operation.

Yes，the designed loss is different from the vanilla BCEWithLogitLoss. Besides the weights, it is implemented without the sigmoid or softmax operation.

Hi, I see the codes of weighted mechanism. But does the computaion of that two lines really means crossentropy loss as paper said? I still don't undestand the meanning of that two lines. Could you explain the relationship between the computation and the formular in original paper? If that I'll be appreciated.

A balanced adversarial learning requires the loss of discriminator to converge around 0.5. However, the value of M(P1,P2) tends to be very small in the late epochs, and the discriminator using vanilla BCE loss would tend to bias to the "real samples", resulting in an unbalanced  training course . Such designed loss (without softmax) in this repository aims to guarantee larger gradients to be backpropagated to G and D in even later epochs, thus stablizing the training.  Under the premise of consistent gradient decent direction with paper, such WeightedBCEWithLogitLoss allows a more balanced adversarial course.

A balanced adversarial learning requires the loss of discriminator to converge around 0.5. However, the value of M(P1,P2) tends to be very small in the late epochs, and the discriminator using vanilla BCE loss would tend to bias to the "real samples", resulting in an unbalanced training course . Such designed loss (without softmax) in this repository aims to guarantee larger gradients to be backpropagated to G and D in even later epochs, thus stablizing the training. Under the premise of consistent gradient decent direction with paper, such WeightedBCEWithLogitLoss allows a more balanced adversarial course.

Hi, I guess I've undestood the computation of the two lines. It in fact computes the BCEWithLogitLoss
and contains the sigomoid operation in it. An good  implementation!!! But you said  it is implemented without the sigmoid or softmax operation, I hope I didn't understand wrong. Thanks a lot.

You are welcome. Thank you again for your interest in CLAN!


add yarg’s strict() to chain. add walletUrl, contractName as options

Different approach to https://github.com/nearprotocol/near-shell/issues/259
Also enabled recommendations. So near fake will fail, list possible commands, and say, "Did you mean near stake?"
I think the issue was .config(config) loaded src/config.js which has keys that weren't explicitly set as options.
This is quite separate from the PR where most of the discussion on this issue has been happening.
https://github.com/nearprotocol/near-shell/pull/262
If we choose to merge this PR, we can close the other.

I think the issue was .config(config) loaded src/config.js which has keys that weren't explicitly set as options.

yes, that was the problem
not sure if it's not confusing to keep these as options for all commands (as most commands would ignore --contractName for example) or also what may happen given that it's alias to --accountId – we might end up using value from src/config.js for commands which don't operate on contracts.
for this reason I feel that long-term we need to figure out solution where we load config in different way

@mikedotexe this is failing the tests BTW

@mikedotexe this is failing the tests BTW

Yes, I haven't seen any PRs pass tests the past two days.
Unknown argument: masterAccount
++RESULT='{ networkId: '\''shared-test'\'',
  nodeUrl: '\''http://shared-test.nearprotocol.com:3030'\'',
  contractName: undefined,
  masterAccount: '\''test.near'\'' }'
./test/test_generate_key.sh FAIL
error Command failed with exit code 1.

masterAccount is not something I've touched, which is odd.
Locally, when I run rm -rf neardev && yarn test on master it's also failing, but for a different reason.
Account has existing key pair with ed25519:EsyKEPeLbgPk9qorxLZ2thLghLXJXdfMubF8muy5mg2j public key =~ .*Account has existing key pair with ed25519:.+ public key.* ]]
./test/test_generate_key.sh SUCCESS
error Command failed with exit code 1.

I've had to somewhat ignore errors as it seems something is awry.

The latest commit reduces that confusion. When a user types near or near --help it does not show the walletUrl or contractName flags.
I hear what you're saying, @vgrichina, about loading the config. I think this approach will work. I also sense there are going to be a significant changes to shell that are coming soonish. This is a fairly quick approach. I feel we want to improve UX the original issue soon, giving users feedback on what went wrong when they type something incorrect.

Looks good! Have you tested it on windows? Do you mind commenting on the PR with how you tested it? LGTM after making sure it works on diff platforms

On Windows I run near fake and nothing happens. Then when I'm on this branch I can run:
node bin\near fake and it'll suggest a similar, valid command.

Same thing on OS X, except this time I'll use an errant argument.
near state --fake argie mikedotdmg
makes it look like everything is fine, leading the user to believe they may need this --fake argument.
running on this PR:
./bin/near state --fake argie mikedotdmg
It tells the user that fake isn't a thing.

The first line of this PR's description links to the issue created by Illia who was trying to run:
near transfer acc1 my_validator 1
This has the same behavior.


Fixed username visible after logout bug

Description
Username is now only visible to logged-in users.
Fixes #3645
Tests performed
Tested prodDebug on Google Pixel 2 with API level 29
Screenshots

this issue is irrelevant after #3649 is fixed, you shouldn't be able to see the navigation drawer after a logout.

this issue is irrelevant after #3649 is fixed, you shouldn't be able to see the navigation drawer after a logout.

I can confirm that the username issue is resolved now but if I click on that particular region where the username was supposed to be visible (but not visible) I can still jump to the Achievements Activity. Merging this PR would resolve that issue.

Yes because you shouldn't be on this screen, you should get redirected to loginActivity which will happen with #3649 . Fixing a problem inside an invalid state is not a good use of time or resource.

@macgills The original issue was that when a person Login then Logout then redirected to Login Screen again and then click on skip login then the username remains visible or click event is triggered. Just confirming if this will be resolved after the #3649 is merged?

The username is not visible but on the 2nd click you get brought to an achievements page that will not load

But that is a different issue to this issue "Username remains visible even after logout"
Please open a new ticket to fix being able to launch the achievements activity from an invisible username


unable to install node-v9.11, calculated checksums prepended with a ''

Operating system and version:
macOS Sierra Version 10.12.6

nvm debug output:

nvm --version: v0.33.11
$TERM_PROGRAM: Apple_Terminal
$SHELL: /bin/bash
$SHLVL: 1
$HOME: /Users/mhowlesbanerji
$NVM_DIR: '$HOME/.nvm
Saving session...
...copying shared history...
...saving history...
...completed.
Deleting expired sessions...453 completed.'
sed: 1: "s#/Users/mhowlesbanerji ...": unterminated substitute pattern
$PATH:
sed: 1: "s#/Users/mhowlesbanerji ...": unterminated substitute pattern
$PREFIX: ''
sed: 1: "s#/Users/mhowlesbanerji ...": unterminated substitute pattern
$NPM_CONFIG_PREFIX: ''
$NVM_NODEJS_ORG_MIRROR: ''
$NVM_IOJS_ORG_MIRROR: ''
shell version: 'GNU bash, version 3.2.57(1)-release (x86_64-apple-darwin16)'
uname -a: 'Darwin 16.7.0 Darwin Kernel Version 16.7.0: Thu Jun 21 20:07:39 PDT 2018; root:xnu-3789.73.14~1/RELEASE_X86_64 x86_64'
OS version: Mac 10.12.6 16G1510
curl: /usr/bin/curl, curl 7.54.0 (x86_64-apple-darwin16.0) libcurl/7.54.0 SecureTransport zlib/1.2.8
wget: /usr/local/bin/wget, GNU Wget 1.19.5 built on darwin16.7.0.
git: /usr/bin/git, git version 2.14.3 (Apple Git-98)
grep: /usr/bin/grep, grep (BSD grep) 2.5.1-FreeBSD
awk: /usr/bin/awk, awk version 20070501
sed: illegal option -- -
usage: sed script [-Ealn] [-i extension] [file ...]
       sed [-Ealn] [-i extension] [-e script] ... [-f script_file] ... [file ...]
sed: /usr/bin/sed,
cut: illegal option -- -
usage: cut -b list [-n] [file ...]
       cut -c list [file ...]
       cut -f list [-s] [-d delim] [file ...]
cut: /usr/bin/cut,
basename: illegal option -- -
usage: basename string [suffix]
       basename [-a] [-s suffix] string [...]
basename: /usr/bin/basename,
rm: illegal option -- -
usage: rm [-f | -i] [-dPRrvW] file ...
       unlink file
rm: /bin/rm,
mkdir: illegal option -- -
usage: mkdir [-pv] [-m mode] directory ...
mkdir: /bin/mkdir,
xargs: illegal option -- -
usage: xargs [-0opt] [-E eofstr] [-I replstr [-R replacements]] [-J replstr]
             [-L number] [-n number [-x]] [-P maxprocs] [-s size]
             [utility [argument ...]]
xargs: /usr/bin/xargs,
sed: 1: "s#/Users/mhowlesbanerji ...": unterminated substitute pattern
nvm current:
sed: 1: "s#/Users/mhowlesbanerji ...": unterminated substitute pattern
which node:
sed: 1: "s#/Users/mhowlesbanerji ...": unterminated substitute pattern
which iojs:
sed: 1: "s#/Users/mhowlesbanerji ...": unterminated substitute pattern
which npm:
sed: 1: "s#/Users/mhowlesbanerji ...": unterminated substitute pattern
npm config get prefix:
sed: 1: "s#/Users/mhowlesbanerji ...": unterminated substitute pattern
npm root -g:

nvm ls output:

sed: 2: "
            s#/Users/m ...": unterminated substitute pattern
            N/A
sed: 2: "
            s#/Users/m ...": unterminated substitute pattern
node -> stable (-> N/A) (default)
sed: 2: "
            s#/Users/m ...": unterminated substitute pattern
sed: 2: "
            s#/Users/m ...": unterminated substitute pattern
iojs -> N/A (default)
sed: 2: "
            s#/Users/m ...": unterminated substitute pattern
lts/* -> lts/carbon (-> N/A)
lts/argon -> v4.9.1 (-> N/A)
lts/boron -> v6.14.3 (-> N/A)
lts/carbon -> v8.11.3 (-> N/A)

How did you install nvm? (e.g. install script in readme, Homebrew):
curl -o- https://raw.githubusercontent.com/creationix/nvm/v0.33.11/install.sh | bash

What steps did you perform?
nvm install v9.11

What happened?
Attempts to download and install, but getting failed checksums, as the calculated checksum is prepended with a \:

$ nvm install v9.11
Downloading and installing node v9.11.2...
sed: 1: "s#/Users/mhowlesbanerji ...": unterminated substitute pattern
Local cache found:
Computing checksum with shasum -a 256
Checksums do not match: '\9f2441d902d3dd6c02a21099ee1f579a91bd55916c925a1ab7a3b9011fe7dda6' found, '9f2441d902d3dd6c02a21099ee1f579a91bd55916c925a1ab7a3b9011fe7dda6' expected.
Checksum check failed!
Removing the broken local cache...
Downloading https://nodejs.org/dist/v9.11.2/node-v9.11.2-darwin-x64.tar.xz...
######################################################################## 100.0%
Computing checksum with shasum -a 256
Checksums do not match: '\9f2441d902d3dd6c02a21099ee1f579a91bd55916c925a1ab7a3b9011fe7dda6' found, '9f2441d902d3dd6c02a21099ee1f579a91bd55916c925a1ab7a3b9011fe7dda6' expected.
Binary download failed, trying source.
Clang v3.5+ detected! CC or CXX not specified, will use Clang as C/C++ compiler!
sed: 1: "s#/Users/mhowlesbanerji ...": unterminated substitute pattern
Local cache found:
Computing checksum with shasum -a 256
Checksums do not match: '\06484eac7f6b7c87e96983a039422347c0047284bc4d373d90884ae3966dc213' found, '06484eac7f6b7c87e96983a039422347c0047284bc4d373d90884ae3966dc213' expected.
Checksum check failed!
Removing the broken local cache...
Downloading https://nodejs.org/dist/v9.11.2/node-v9.11.2.tar.xz...
######################################################################## 100.0%
Computing checksum with shasum -a 256
Checksums do not match: '\06484eac7f6b7c87e96983a039422347c0047284bc4d373d90884ae3966dc213' found, '06484eac7f6b7c87e96983a039422347c0047284bc4d373d90884ae3966dc213' expected.

What did you expect to happen?
node v9.11 would be installed, checksums should match.

Is there anything in any of your profile files (.bashrc, .bash_profile, .zshrc, etc) that modifies the PATH?

.profile:
```sh
export PATH=$PATH:/usr/local/bin/vault:/usr/local/bin
export PATH=$PATH:$HOME:$HOME/dev:$M2_HOME/bin
export PATH=$PATH:~/perforce/www/expweb/expdevtools/jdk/1.8.0_144/MacOSX64/
export PATH=./node_modules/.bin:$PATH
# Add RVM to PATH for scripting. This must be the last PATH change!!
export PATH=$PATH:$HOME/.rvm/bin
```

If you are having installation issues, or getting "N/A", what does curl -I --compressed -v https://nodejs.org/dist/ print out?

*   Trying <IP_ADDRESS>...
* TCP_NODELAY set
* Connected to nodejs.org (<IP_ADDRESS>) port 443 (#0)
* TLS 1.2 connection using TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256
* Server certificate: *.nodejs.org
* Server certificate: COMODO RSA Domain Validation Secure Server CA
* Server certificate: COMODO RSA Certification Authority
> HEAD /dist/ HTTP/1.1
> Host: nodejs.org
> User-Agent: curl/7.54.0
> Accept: */*
> Accept-Encoding: deflate, gzip
>
< HTTP/1.1 200 OK
HTTP/1.1 200 OK
< Date: Tue, 14 Aug 2018 19:15:45 GMT
Date: Tue, 14 Aug 2018 19:15:45 GMT
< Content-Type: text/html
Content-Type: text/html
< Connection: keep-alive
Connection: keep-alive
< Set-Cookie: __cfduid=d5325a50bd432466e9f0832200869ac471534274145; expires=Wed, 14-Aug-19 19:15:45 GMT; path=/; domain=.nodejs.org; HttpOnly
Set-Cookie: __cfduid=d5325a50bd432466e9f0832200869ac471534274145; expires=Wed, 14-Aug-19 19:15:45 GMT; path=/; domain=.nodejs.org; HttpOnly
< CF-Cache-Status: HIT
CF-Cache-Status: HIT
< Vary: Accept-Encoding
Vary: Accept-Encoding
< Expires: Tue, 14 Aug 2018 23:15:45 GMT
Expires: Tue, 14 Aug 2018 23:15:45 GMT
< Cache-Control: public, max-age=14400
Cache-Control: public, max-age=14400
< Expect-CT: max-age=604800, report-uri="https://report-uri.cloudflare.com/cdn-cgi/beacon/expect-ct"
Expect-CT: max-age=604800, report-uri="https://report-uri.cloudflare.com/cdn-cgi/beacon/expect-ct"
< Server: cloudflare
Server: cloudflare
< CF-RAY: 44a5c0822e002a91-SEA
CF-RAY: 44a5c0822e002a91-SEA
< Content-Encoding: gzip
Content-Encoding: gzip

<
* Connection #0 to host nodejs.org left intact

The issue is shown by the contents of $NVM_DIR - including that "saving session" stuff. Whatever's doing that is going to break nvm's output.
Closing per https://github.com/nvm-sh/nvm/issues/1610#issuecomment-444727975


Pass pointer address of texture instead of colors32

I believe the repo is awesome, but having some FPS or milliseconds improvement is a good thing to develop
So , one thing in my mind for some time is that in unity you can get the texture image pointer address and I ask if it could be passed directly,so mediapipe access it instead of Colors32 that is a very expensive operation. I simply had the idea don't know how to implement it tough.
Thanks and great job.
Bruno

@homuler here there's more info about how to get the pointer adress https://docs.unity3d.com/ScriptReference/Texture.GetNativeTexturePtr.html

@elblogbruno  Thank you for reporting the issue.
Currently, DemoGraph#PushInput copies GPU buffer to ImageFrame (CPU memory) and copies ImageFrame data to GPU buffer again. The good thing is that it needs less native APIs (so I can implement fast), but those operations are unnecessary and expensive as you pointed out.
I'll change the code to pass the GL texture name to MediaPipe directly, but it looks difficult to do with the current architecture (because Unity have to know when to release which GL texture), so it may take time.

Glad my comment was useful for you and that it can be implemented in the near future!
I believe in the URL I had passed previously, there are algorithm examples.
Cordially
Bruno

Finally...we can now pass the texture's native pointer (or texture name) to MediaPipe (OpenGL ES only).
https://github.com/homuler/MediaPipeUnityPlugin/blob/18e00a85ac271b123178e593184184e8715ed22e/Assets/MediaPipe/Examples/Scripts/DemoGraph.cs#L54-L63
We can also ask MediaPipe to render the output to a Unity Texture directly (cf. OfficialDemoGPU)
But in fact OfficialDemoGPU does not perform as well as the official APK, I'll continue to investigate to improve the performance.
Memo (performance tips)

Build a GpuBuffer object from the input texture's name and pass it to MediaPipe (OpenGL ES only)
Use CalculatorGraph#ObserveOutputStream and get output packets asynchronously (cf. OfficialDemoCPU)

I can't wait to try it! Glad the idea was able to be implemented, have you noticed improvement?
Thanks for all!
Great job

I am getting better performance (50-60fps 10ms) on OfficialDemoGPU than hand graph
https://user-images.githubusercontent.com/10481058/103406106-d3a65d00-4b59-11eb-8700-49935c42f868.mp4


Is it possible to run few tests using the same selendroid session in jsystem?

Hi,
I have quite a few test cases that test the same android application. Every TC opens and closes selendroid server session and the open/close takes sometimes more time than verification itself.  Is it possible to open the session in the beginning of the first test and close in the last? How can I connect to the running session from second, third etc. test?
Bellow my TC code example (the very short version). If I start and stop server in separate test,  will my driver connect to it?
Waiting for answers, suggestions, examples
Thanks in advance
The example of my TCs code:
public class TestingAppSMS extends SystemTestCase4 {
private SelendroidLauncher selendroidServer;
private SelendroidConfiguration serverConfig;
private int SelendroidPort = 4444;
private int SelendroidServerPort = 38080;
private long serverStartTimeout = 100000;
private String appPath = "C:/apk/app-release.apk";
private boolean forceReinstall = false;
private boolean clearData = false;
private LogLevelEnum serverLogLevel = LogLevelEnum.INFO;
private WebDriver driver;
private SelendroidCapabilities capabilities;
private String appUnderTestId = "com.cellact.secnum:1.0.1";
private	String serverUrl = "http://localhost:4444/wd/hub";
private boolean runOnEmulator = false;

@Before
public void setUp() throws Exception {
startServer(appPath, forceReinstall, clearData,serverLogLevel);
    /**Run DUT (Device under Test)**/
    initDriver(appUnderTestId, null, serverUrl, runOnEmulator);

}

@After
public void tearDown() {
    driver.quit();
    selendroidServer.stopSelendroid();
}

  @Test
@TestProperties(name = "Selendroid SMS Test")
public void selendroidTest() throws Exception {
           ///here my TC
   }

  private void startServer(String appPath, boolean forceReinstall, boolean clearData,LogLevelEnum serverLogLevel) {
	serverConfig = new SelendroidConfiguration();
        serverConfig.setServerStartTimeout(serverStartTimeout);//Maximum time in milliseconds (Default: 20000)
        serverConfig.addSupportedApp(appPath);
        serverConfig.setPort(SelendroidPort); //Specify the port for selendroid-standalone to run on, the default is 4444.
        serverConfig.setSelendroidServerPort(SelendroidServerPort);
        serverConfig.setForceReinstall(forceReinstall);
        serverConfig.setNoClearData(!clearData);//Specify if user data should not be cleaned after the test session has ended.
        serverConfig.setPrintHelp(true);
        serverConfig.setDeviceLog(true);//Specifies whether or not adb logging should be enabled for the device running the test (Default: true)
    	serverConfig.setLogLevel(serverLogLevel);
        selendroidServer = new SelendroidLauncher(serverConfig);
        selendroidServer.launchSelendroid();

    }

    private void initDriver(String appUnderTestId, String launchActivity, String serverUrl, boolean runOnEmulator)      throws Exception {

        capabilities = new SelendroidCapabilities();
        capabilities.setAut(appUnderTestId);

        if (launchActivity != null) {
            capabilities.setLaunchActivity(launchActivity);
        }
        capabilities.setEmulator(runOnEmulator);

        this.driver  = new SelendroidDriver(new URL(serverUrl), capabilities);
     }

}

Hi,
Created separate TCs for Server start and stop. In TCs left only driver starting and connecting to the running server. The server object is passed to stop server TC via SO object
IT works!!!! And now it takes much shorter time to run all TCs
Hope it can help to somebody else


Direct mode Namespace creation: compensate for smaller result

Recent alignment change broke size calculation,
and compensation for smaller creation was left out.
As the result, current code would create for example 2GB
namespace per 2.x GB request, because we would
align 2.x up to 3 GB, then libndctl creatng 3-1=2GB namespace.
We have to compensate for libndctl creating one alignment step smaller
namespace. Current change should handle all: check for
too small (i.e. zero), compensate for smaller creation,
and that it all works together with alignment.

This "libndctl creating one alignment step smaller namespace" sounds like a bug to me. Has this behavior been discussed with the maintainers of it?

This "libndctl creating one alignment step smaller namespace" sounds like a bug to me. Has this behavior been discussed with the maintainers of it?

yes, here:
https://github.com/pmem/ndctl/issues/79
Got explained having to do with difficulty to know the overhead beforehand, and owners were "not sure what to to do about this". So, after some time I thought, we can work around compensating, and let the issue get closed. Seems ndctl does not follow same policy as CSI forces on pmem-csi: "serve at least requested or fail", instead they try to have "something close to requested is ok". But let's note that no other user has complained about it, and issue 79 also did not get much feedback, so majority seems to be happy with current style.

So if I understand https://github.com/pmem/ndctl/issues/79 correctly, asking for 1GB size with 1GB alignment fails because libndctl allocates 1GB, then uses some of that space for meta data, and then not enough space is left for the actual data volume?
Then I would calculate the requested size as follows (same code as yours, just different comments):
// Pass align = 1 GB into creation request as that has proven to be reliable.
const align uint64 = 1024 * 1024 * 1024
if size <= 0 {
    // Allocating volumes of zero size isn't supported.
    // We use some arbitrary small minimum size instead.
    // It will get rounded up by libndctl to meet the alignment.
    size = 4096
}
// libndctl needs to store meta data and will use some of the allocated
// space for that (https://github.com/pmem/ndctl/issues/79).
// We don't know exactly how much space that is, just
// that it should be a small amount. But because libndctl
// rounds up to the alignment, in practice that means we need
// to request `align` additional bytes.
compensatedsize := size + align

pushed new, changed 4096 to 1, replaces comment text with proposed, these are indeed better.

extra space of 1 seems to work both in CI and in my local test. Other recent changes were comments text.
OK to merge?


Upload product and stemcell ignores stemcell metadata from pivnet

This line
https://github.com/pivotal-cf/pcf-pipelines/blob/master/tasks/upload-product-and-stemcell/task.sh#L11
Probably should use the -z bash option, otherwise it always ignores the Pivnet dependency metadata.

Please ignore.


Show select language button on all pages

NOTE - Needs a few PRs to merge before reviewing. Will update as they go in

Enable select language option in user drop down
Add select language button to landing-page (used in both log in and setup pages)
If the user has not previously selected a language prod $translate for a best guess browser language
Store the user's language chose
Allow languages to be stored in dirs with more than two chars
Convert 'en' lang to 'en_US'

 (2) Add language selector to setup screen and to the user menu. Validate language change works

 (1) Localisation: Set moment locale when locale changes (reminder)


Raise custom exception when service is unavailable (503 status).

Fitbit's servers seem to be extra flakey lately, and I'd like to handle an exception when they respond with a 503 (instead of a JSON::ParserError due to HTML being returned for the 503 error).

Looks good- thanks so much!


Figure out: unclassified publications are shown as "miscellaneous" in front-office, should we make it "Classification Pending?"

Discussed in https://github.com/ugent-library/biblio-backoffice/discussions/1199

Originally posted by mietcls June 20, 2023
Enhancement
Confusing: unclassified publications are shown as "miscellaneous" in front-office.
Edit: To Do Miet: Figure out whether "Classification pending" is a good port with Biblio team.
Steps to Reproduce

Find an unclassified record in the back-office
View it in the front-office

Example of an A1 publication

Expected behavior
Idea: Show "publication type" instead?
Additional context
See confused researcher: https://otrsdoza.ugent.be/otrs/index.pl?Action=AgentTicketZoom;TicketID=3426
Risk classification – Consequences
What's the impact?
3: Marginal, people get confused

Replaced by https://github.ugent.be/Universiteitsbibliotheek/biblio/issues/182


Bulk import

Typically, I'm importing several files in one go. Would be nice to have this supported in the UI.

On the other hand, it might not be worth the complexity in the UI. Plus, for files of the same format, I can just drag and drop in a new file and hit download. Pretty easy. Closing this as not needed/worth the effort.