Fails to compile with vendored dependencies

Component
Other (please describe)
Have you ensured that all of these are up to date?

[ ] Foundry
[ ] Foundryup

What version of Foundry are you on?
latest master
What command(s) is the bug in?
cargo build
Operating System
macOS (Intel)
Describe the bug
using cargo vendor to vendor dependencies, the project fails to compile with errors like
error[E0433]: failed to resolve: use of undeclared crate or module `ethers`
   --> /Users/raphael/dev/foundry/vendor/ethers-contract/src/multicall/multicall_contract.rs:903:9
    |
903 |         ethers_contract :: EthAbiCodec,
    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ not found in `ethers::core::abi`
    |
    = note: this error originates in the derive macro `ethers_contract::EthAbiCodec` (in Nightly builds, run with -Z macro-backtrace for more info)
help: consider importing one of these items
    |
9   |     use crate::multicall::Token;
    |
9   |     use ethers_core::abi::Token;
    |
help: if you import `Token`, refer to it directly
    |
903 -         ethers_contract :: EthAbiCodec,
903 +         ethers_contract :: EthAbiCodec,
    |

it's quite easy to reproduce. Use cargo vendor then inside the .cargo/config.toml file just add the following
[source.crates-io]
replace-with = "vendored-sources"

[source."https://github.com/bluealloy/revm"]
git = "https://github.com/bluealloy/revm"
replace-with = "vendored-sources"

[source."https://github.com/gakonst/ethers-rs"]
git = "https://github.com/gakonst/ethers-rs"
replace-with = "vendored-sources"

[source."https://github.com/roynalnaruto/svm-rs"]
git = "https://github.com/roynalnaruto/svm-rs"
replace-with = "vendored-sources"

[source.vendored-sources]
directory = "vendor"

Context: supporting vendored dependencies would enable forge to be added to nixos. Rust compilation on nixos can only be done through vendored dependencies.
I understand that this might not be a priority, no worries!
Thanks again for making great software!

oh this looks like an issue with how the ethers_core vs ethers path is determined in ethers derive macros here
I guess the manifest dir is something different when running cargo vendor?
https://github.com/gakonst/ethers-rs/blob/master/ethers-core/src/macros/ethers_crate.rs#L51

vendor creates a vendor directory with all the dependencies.
Judging by the logic of the link you posted, it seems that the CARGO_MANIFEST_DIR env var is not set when using cargo vendor.
The "ethers-contract" crate fails to compile, because the cargo.toml file dependencies doesn't contain "ethers"
[dependencies]
ethers-providers = { version = "^0.17.0", path = "../ethers-providers", default-features = false }
ethers-core = { version = "^0.17.0", path = "../ethers-core", default-features = false }
ethers-contract-abigen = { version = "^0.17.0", path = "ethers-contract-abigen",  default-features = false, optional = true }
ethers-contract-derive = { version = "^0.17.0", path = "ethers-contract-derive", optional = true }
ethers-derive-eip712 = { version = "^0.17.0", path = "../ethers-core/ethers-derive-eip712", optional = true }

Adding it there however generates a cyclic dependency.
hmmm I'm not sure how to solve this one.
it looks like the macro shouldn't return
 return ("ethers::core", "ethers::contract", "ethers::providers")

but not sure what it should return.

Hi @happysalada, would be great if you could re-run this to see if this is still valid considering Ethers has been replaced by Alloy
cargo vendor runs without issue on my end now

I was waiting for a stable release to try again packaging this for nixos. Any release on the horizon by any chance ?

I was waiting for a stable release to try again packaging this for nixos. Any release on the horizon by any chance ?

Makes sense - hopefully within the next few months. Would it be OK if I close this ticket in favor of https://github.com/foundry-rs/foundry/issues/3895 + https://github.com/foundry-rs/foundry/issues/545?

Sure go ahead !


In certain cases, spelling "ignore all" can cause previous results to be revisited

In GitLab by @nwalczak on Jun 24, 2019, 15:14
When searching for the next term in the result set with the ignored term removed, the search index starts at 0 instead of starting at the initial starting index.  This means that if any instances of the next term had been ignored previously, they will get revisited.

In GitLab by @nwalczak on Jun 24, 2019, 15:14
created branch 56-in-certain-cases-spelling-ignore-all-can-cause-previous-results-to-be-revisited

In GitLab by @nwalczak on Jun 24, 2019, 15:14
mentioned in merge request !9

In GitLab by @nwalczak on Jun 24, 2019, 15:17
closed via merge request !9

In GitLab by @nwalczak on Jun 24, 2019, 15:17
closed via commit ef2851d0d46ba058c6a835bc774a4d8854d5b0e8

In GitLab by @nwalczak on Jun 25, 2019, 13:32
mentioned in commit ef2851d0d46ba058c6a835bc774a4d8854d5b0e8


Introducing NumericInput Component

Resolves #443

This PR introduces the NumericInput component.
Allow increment or decrement of the number based on the step size
Contains all the relevant properties of the <input type="number">
Can be used as both controlled and uncontrolled components based on the provided props.

Right now, this PR introduces the skeleton of the component without the relevant styling, which will be addressed in a follow-up commit.
Also, this PR has introduced the NumericInput bar at the top of lesson content for easier testing by reviewers. This, too, shall be cleaned up in a follow-up commit.
@afterburn
Please have a look through the code and functionality, and confirm if it satisfies our needs for the NumericInput component.

I am unable to see the Uncontrolled NumericInput component in Vercel deployment link, although it is visible when I am running this PR locally.

Updated from 1c7cd6cb913ce1305fa02df9af0a4e5b9c955001 to 704c28130b7e87852932dc490720f50780f9e2a2 (pr453.02 -> pr453.03, diff)
Addressed @vinayaksh42 comment

Introduced onKeyDown event in the NumericInput component.

Updated from cc34c09e6c252ca8d298e44167934c24bd670b70 to<PHONE_NUMBER>a473147c9092f6fb5753def89be919  (pr453.04 -> pr453.05, diff)
Addressed @afterburn comment
Update

Removed the test code for NumericInput from the page.tsx


Port-restricted IP addresses do not work with VLAN tagging

So far what I have done is to clone the end-to-end tests so packets and configuration files have VLAN tagging activated #108 . There are some tests that pass and others don't. Code is merged in lwaftr_olive now (end-to-end-vlan.sh).
Many of the tests that don't pass are related with ICMP packets. I believe #99 will fix those. So I'm focusing instead on those which are not ICMP related. My next step is to go through every failing test and see what are the differences between packets generated.
With regard to spotting the bug directly in the source code, I didn't try that much.

One failing test is:
Testing: from-internet IPv4 packet found in the binding table, needs IPv6 fragmentation (3).
done
../data/vlan/tcp-afteraftr-ipv6-3frags.pcap /tmp/endoutv6.pcap differ: byte 33, line 1

tcp-afteraftr-ipv6-3frags.pcap headers
$ tcpdump -e -qns 0 -r ../data/vlan/tcp-afteraftr-ipv6-3frags.pcap
reading from file ../data/vlan/tcp-afteraftr-ipv6-3frags.pcap, link-type EN10MB (Ethernet)
01:00:00.000000 22:22:22:22:22:22 > 44:44:44:44:44:44, 802.1Q, length 1282: vlan 1638, p 0, ethertype IPv6, 8:9:a:b:c:d:e:f > 127:11:12:13:14:15:16:128: frag (0|1216) truncated-ip - 1504 bytes missing! <IP_ADDRESS>.2300 > <IP_ADDRESS>.2700: tcp 2680
01:00:00.000000 22:22:22:22:22:22 > 44:44:44:44:44:44, 802.1Q, length 1282: vlan 1638, p 0, ethertype IPv6, 8:9:a:b:c:d:e:f > 127:11:12:13:14:15:16:128: frag (1216|1216)
01:00:00.000000 22:22:22:22:22:22 > 44:44:44:44:44:44, 802.1Q, length 354: vlan 1638, p 0, ethertype IPv6, 8:9:a:b:c:d:e:f > 127:11:12:13:14:15:16:128: frag (2432|288)

/tmp/endoutv6.pcap headers
$ tcpdump -e -qns 0 -r /tmp/endoutv6.pcap
reading from file /tmp/endoutv6.pcap, link-type EN10MB (Ethernet)
01:00:00.000000 22:22:22:22:22:22 > 44:44:44:44:44:44, 802.1Q, length 1274: vlan 1638, p 0, ethertype IPv6, 8:9:a:b:c:d:e:f > 127:11:12:13:14:15:16:128: frag (0|1208) truncated-ip - 1512 bytes missing! <IP_ADDRESS>.2300 > <IP_ADDRESS>.2700: tcp 2680
01:00:00.000000 22:22:22:22:22:22 > 44:44:44:44:44:44, 802.1Q, length 1274: vlan 1638, p 0, ethertype IPv6, 8:9:a:b:c:d:e:f > 127:11:12:13:14:15:16:128: frag (1208|1208)
01:00:00.000000 22:22:22:22:22:22 > 44:44:44:44:44:44, 802.1Q, length 370: vlan 1638, p 0, ethertype IPv6, 8:9:a:b:c:d:e:f > 127:11:12:13:14:15:16:128: frag (2416|304)

The difference is the truncation of the first packet. It's one byte shorter (1208 bytes vs 1216 bytes). The diff reports a difference in byte 33, but I think that's PCAP header control information because it's data before the payload.
tcp-afteraftr-ipv6-3frags.pcap
0000000: d4c3 b2a1 0200 0400 0000 0000 0000 0000  ................
0000010: ffff 0000 0100 0000 0000 0000 0000 0000  ................
0000020: fa04 0000 fa04 0000 4444 4444 4444 2222  ........DDDDDD""
0000030: 2222 2222

/tmp/endoutv6.pcap
0000000: d4c3 b2a1 0200 0400 0000 0000 0000 0000  ................
0000010: ffff 0000 0100 0000 0000 0000 0000 0000  ................
0000020: 0205 0000 0205 0000 4444 4444 4444 2222  ........DDDDDD""
0000030: 2222 2222

I'm explicitly not addressing fragmentation problems until fixing  #100 . If this persists after #100 is fixed, ping me. Byte 33 is indeed part of the pcap header.

After all the bug fixes we are not able to reproduce this issue.  We're asking for more information but in the meantime we'll roll a v1.1 with all we have.  Reassigning to v1.2.

For future reference: the bug @dpino mentioned is fixed, via https://github.com/Igalia/snabbswitch/issues/100 (redefining MTUs to be L3), which depends on https://github.com/Igalia/snabbswitch/pull/105 (vlan/header handling refactorings). I don't think it's related to the externally-reported bug.

Can we close this? I believe the vlan tests (and associated code fixes) we did for 1.1 (and on lwaftr_olive) resolve every issue related to this that we can reproduce, although not every issue that has been reported. Thoughts, @andywingo , @dpino ?

@kbara SGTM. It seems most of the cases, if not all, are solved now. If there are new bugs related with this issue in the future, we can open a new issue with a narrower scope.


Added kramdown=0 attribute til mermaid div tag

It turns out that when using Kramdown in Jekyll all > and < (greater than/lesser than) are transformed into entities > regardless of what I configure for entity_output in _config.yaml.
By adding
<div class="mermaid" kramdown="0">

to the output, the problem disappears.
What do you think?

Still got a problem. I will get back to it.


update for 1.0.0 path

Update istio GCP DM template for release-1.0.0.  (https://github.com/istio/istio/issues/7049).
Pls do not merge at this time.
Note, the DM script here does not run as-is.  It expects the release-1.0.0  tar.gz file to exist here:
https://github.com/istio/istio/releases/download/{{ properties['installIstioRelease'] }}/istio-{{ properties['installIstioRelease'] }}-linux.tar.gz

where installIstioRelease==1.0.0
So far, i tested this script against the daily build here:
https://gcsweb.istio.io/gcs/istio-prerelease/daily-build/release-1.0-20180711-09-15/

I used the hardcoded path to it and staged it on my own gitrepo here .
I recognize the code thested there is hardcoded compared to whats in this PR.  The PR looks like a lot of changes but in reality the changes made to release-0.8.0 for the GKE DM template never made it to this branch
(eg, see changes for 0.8 here
Note, if you use that directly, please first enable the GKE roles specified here

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: salrashid123
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: ijsnellf
Assign the PR to them by writing /assign @ijsnellf in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

install/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Hi @salrashid123. Thanks for your PR.
I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

/ok-to-test

/lgtm

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: andraxylia, salrashid123
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

install/OWNERS [andraxylia]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@costinm @hklai we will have to merge this as soon as 1.0 is posted. For now I added the hold label.


Questions for Training

Hi, thanks for your great work! I have download every dataset and json file in order to train from the begin following the code in README. However, I got an error:
Dataset 'SUNRGBD_val' is empty!
File "/home/yh/lab/ovmono3d/cubercnn/data/build.py", line 67, in get_detection_dataset_dicts
assert len(dicts), "Dataset '{}' is empty!".format(dataset_name)
File "/home/yh/lab/ovmono3d/cubercnn/data/build.py", line 82, in _train_loader_from_config
dataset = get_detection_dataset_dicts(
File "/home/yh/miniconda3/envs/ovmono3d/lib/python3.8/site-packages/detectron2/config/config.py", line 245, in _get_args_from_config
ret = from_config_func(*args, **kwargs)
File "/home/yh/miniconda3/envs/ovmono3d/lib/python3.8/site-packages/detectron2/config/config.py", line 207, in wrapped
explicit_args = _get_args_from_config(from_config, *args, **kwargs)
File "/home/yh/lab/ovmono3d/tools/train_net.py", line 152, in do_train
data_loader = build_detection_train_loader(cfg, mapper=data_mapper, dataset_id_to_src=dataset_id_to_src)
File "/home/yh/lab/ovmono3d/tools/train_net.py", line 446, in main
if do_train(cfg, model, dataset_id_to_unknown_cats, dataset_id_to_src, resume=args.resume):
File "/home/yh/miniconda3/envs/ovmono3d/lib/python3.8/site-packages/detectron2/engine/launch.py", line 84, in launch
main_func(*args)
File "/home/yh/lab/ovmono3d/tools/train_net.py", line 546, in
launch(
File "/home/yh/miniconda3/envs/ovmono3d/lib/python3.8/runpy.py", line 87, in _run_code
exec(code, run_globals)
File "/home/yh/miniconda3/envs/ovmono3d/lib/python3.8/runpy.py", line 194, in _run_module_as_main (Current frame)
return _run_code(code, main_globals, None,
AssertionError: Dataset 'SUNRGBD_val' is empty!
<class 'itertools.chain'>
special variables
function variables
the I debug and found:

many dataset's samples are filtered out, what should I do to fix this? looking forward to your early reply, thanks!

Hi, what's your command for training? I used the one in the README and I didn't encounter the problem:

Also, could you let me know if you made any changes to some of the files?

Hi, my command is "CUDA_VISIBLE_DEVICES=4,5 python tools/train_net.py --config-file configs/OVMono3D_dinov2_SFP.yaml --num-gpus 2 OUTPUT_DIR  output/ovmono3d_lift VIS_PERIOD 500 TEST.EVAL_PERIOD 2000 MODEL.STABILIZE  0.03 SOLVER.BASE_LR 0.000375 SOLVER.CHECKPOINT_PERIOD 1000 SOLVER.IMS_PER_BATCH 2" and I did not make ant changes to the yaml file, and the is my dataset folder:

It looks like the dataset folder structure is correct. I have tried your command, but I can't reproduce the problem. Could you share the log file in the output folder?

I had solved this! After I delete the output folder generated from other yaml file, it works! I think it's a bug, the yaml file in output folder will override the real input yaml file.

Cool. This problem is inherited from the Omni3D codebase. I will try to fix it later.

OK, thanks again.


Update jsonrpsee to 0.19.0

Depends on #371.
Part of #370.
This one allows us to get the latest version of ring, so it compiles in risc-v.

Closing in favor of #374


Authentication not working in Scalar Open Source API Management

What happens?
Authentication is showing as none even though I added the Authentication header. This prevents adding authentication to requests.

What did you expect to happen?
The Authentication header should be detected and applied correctly to enable authentication.
Request for fix:
Please investigate and fix this issue so that authentication can be applied successfully. Let me know if further details are required.

hello @NotReallyPrince we actually put up a fix for that earlier today, could you try on the latest version?

Yes, it's working now. Thanks

Awesome!


Dist folder missing after installing

Hey there, love the functionality here! Accessibility is so often ignored and it's great to see such a useful package.
I unfortunately ran into a small issue as it looks like the build step is not being run (not sure if that would typically be pre-publish or on install), and thus the dist folder is not present. Not sure if this is in fact something that should be configured on my side, but currently I'm unable to use the plugin as it is. I've opted to inline the code in my project for now, but would certainly prefer to work from your version if possible.

You are correct,
The dist directory is not available in NPM right now.
Maybe something has changed, but I was under the impression that in Svelte projects, via the svelte-rollup-plugin, would consume the svelte property from the package.json:

Considering this exports a plain old JS module (nothing is svelte specific) I didn't spend time tinkering with it any further.
I will take a stab at getting a compiled dist built and available in NPM... but I am curious as to why it is not working for you as-is.
FWIW, I could not convince my team to use Svelte, so I am not actively using this repo.  Happy to transfer ownership or make you a contributor.

I’m guessing what you’re saying about Rollup projects is true as I’ve seen similar issues (that seem to not affect other users) on svelte projects. I’m personally using it in the context of a rails app so using webpack.
Sorry to hear you lost the effort to bring in Svelte! I’d be happy to join as a collaborator if you’re interested. I’d love to poke at the typescript definitions as those gave me some issue as well.
Thanks again for the great work here!

@christoomey Sorry it has taken me so long to look into this more deeply, but I was able to put together a PR that could fix this ^.
https://github.com/Duder-onomy/svelte-focus-trap/pull/9
It should be fixed now as we used the SvelteKit Library generator and the 'dist' is most certainly part of the 'published' code.
I will merge that PR in a few days and cut a 1.3.0 release.


[DCOS-51637] Remove Elastic from dcos-commons.

Only merge after https://github.com/mesosphere/dcos-commons/pull/3046 is merged.

Thanks @samvantran and @zmalik. The references to "elastic" in the diagnostics directory should stay. I've removed the other ones here: a0fe917b1c4d795c595445ad981e1fb2f6029086


How to set SVG width and height in percents?

Hi! Is there way to set width for e.g to 100%?

Can`t do that in react-native.
SVG like other components in react-native.
It can`t set dimensions style in percent.

I hit this problem too. And FWIW, I've had no problem specifying height and width using percents in other React Native components. The problem with the Svg element here is that it deliberately sanitizes the height and width parameters, with this code in render():
        const {opacity, width, height, viewBox, preserveAspectRatio, style, ...props} = this.props;
        let dimensions;

        if (width && height) {
            dimensions = {
                width: +width,
                height: +height,
                flex: 0
            };
        }

I'm guessing that the + coerces the value to a number, making percent values into NaN. I found that if I removed the + everything worked as expected. I expect RN to have standardized sanitization for width and height values, and I'm not sure why the Svg element feels the need to do anything additional.

Apparently, support came about a year ago: https://github.com/facebook/react-native/commit/3f49e743bea730907066677c7cbfbb1260677d11
Feel free to make a PR, otherwise I'll come around to changing this after testing it out.

@msand This give man a cookie!

@msand percentages in width & height work on iOS, but on Android I'm seeing this error:
SurfaceView should have explicit width and height set
Any ideas?

@mlazari Are you using Expo? I think they have an earlier version, from before the percent support was merged.

@msand No, I don't use Expo. I had version 6.2.2 and updated now to 6.3.1, but still seeing the error. I tried to reproduce it in a new sample project, but there it works, so it must be something in my project.

Have you tried cleaning the android build?
cd android
gradlew clean

@msand Cleaning the project doesn't change anything. I can reproduce the error message in a new project with something like this:
render() {
return (
<View style={{flex: 1, alignItems: 'center', justifyContent: 'center'}}>
<View style={{ flex: 1 }}>
<MySVGComponent style={{ width: '50%', height: '100%' }} />

);
}
On iOS it's simply not visible (because the inner View has width 0), but doesn't show any errors. On Android it's showing "SurfaceView should have explicit width and height set" error.
In my project the width / height of the container is not zero, but I get the same error.


FEAT: Use templates for issues

Create folder/file at: /.github)/ISSUE_TEMPLATE/bug-report.md
Create this template:

---
name: Bug Report
about: Create a report to help us squash bugs!

---

<!-- < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < ☺
v                            ✰  Thanks for opening an issue! ✰
v    Before smashing the submit button please review the template.
v    Please also ensure that this is not a duplicate issue :)
☺ > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > >  -->

## Summary of Bug

<!-- Concisely describe the issue -->

## Expected Behaviour

<!-- What is the expected behaviour? -->

## Version

<!-- git commit hash or release version -->

## Steps to Reproduce

<!-- What commands in order should someone run to reproduce your problem? -->

____

#### For Admin Use

- [ ] Not duplicate issue
- [ ] Appropriate labels applied
- [ ] Appropriate contributors tagged/assigned


Add support for upstream and downstream FCM messages using XMPP

Add support for upstream and downstream xmpp server for fcm which are de coupled from each other allowing us to run them in different threads and also to just run any one of them if other is not needed (for example if/when we use REST endpoints)

Fixed in #5


Assignment11 - 6ITA - dhyan

For #630
📋 Description
All 5 question solved
📸 Screenshots

Please amend the commit message in the desired format as specified in the issue description!


Introduction of the Types API Builders

Purpose

The set of builders to create types in the Types API.

Fixes #35415
Approach
Samples
Remarks

TODO:

Add support for the union type builder #36415
Complete #36786 and enable the test case related to inferred array type builder

Check List

[x] Read the Contributing Guide
[ ] Updated Change Log
[ ] Checked Tooling Support (#)
[x] Added necessary tests

[x] Unit Tests
[ ] Spec Conformance Tests
[ ] Integration Tests
[ ] Ballerina By Example Tests

[x] Increased Test Coverage
[ ] Added necessary documentation

[ ] API documentation
[ ] Module documentation in Module.md files
[ ] Ballerina By Examples

Closing since the source branch was changed and a new PR is created at #36828


Add projections

Projections are a system for creating replicated ETS caches available on all members of a Khepri cluster. A new function khepri_projection:new/3 creates a projection resource:
ProjectionName = wood_stocks,
ProjectionFun = fun([stock, wood, Kind], Stock) -> {Kind, Stock} end,
Options = #{type => set, read_concurrency => true},
Projection = khepri_projection:new(ProjectionName, ProjectionFun, Options).

The projection resource may then be registered to a pattern of nodes with khepri:register_projection/4:
StoreId = stock,
PathPattern = "/:stock/:wood/*",
RegisterOptions = #{},
khepri:register_projection(
  StoreId, PathPattern, Projection, RegisterOptions).

Once registered, the projection's ETS table is created and then filled with any existing records matching the pattern. Paths and data are passed through the ProjectionFun to create records which are then stored in the table. Any future changes to records which match the PathPattern are also applied to the projection table.
The projection table is a named ETS table which may be queried directly with ets:
khepri:put(StoreId, "/:stock/:wood/oak", 100),
ets:lookup_element(ProjectionName, <<"oak">>, 2).
%%=> 100

Projections should be used to maximize query throughput and/or minimize query latency at the cost of consistency and memory consumption. Projections have the same consistency guarantees as queries tried with the #{favor => low_latency} option. Data stored in the projection table is at least partially duplicated between the store and the projection table, so increased memory consumption is expected for projections with path patterns matching many nodes.

Thanks for the feedback @dumbbell!
I like the idea of passing khepri:node_props() around rather than payloads :+1:. I switched to that and now khepri_projection:extended_projection_fun()s take full node-props maps too.
For the {simple | extended, Fun} part: originally I thought we could avoid using standalone funs for simple projections (we can't because the funs are persisted to the log) and that tag is a relic from that. I switched to just holding on to a standalone fun and checking the arity.


Overload StartOperation to specify operation Id and parent Id

Fixes #163

Hi @pharring, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

It looks like you're a Microsoft contributor (Paul Harrington). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;

Would you mind to make another overload that takes an entire RequestTelemetry?

@SergeyKanzhelev

Would you mind to make another overload that takes an entire RequestTelemetry?

Certainly. Done.

I'll merge later today. Giving chance @dnduffy and @cijothomas to review.


Fix CR duplication in ASCII mode download

If a file has CRLF already, LF has been still replaced by CRLF, which resulted in CRCRLF line endings.

Coverage remained the same at ?% when pulling b03b4181a6a9603b9dde4fff4ee4cc5464dfe6ed on andrew-shulgin:ascii_crlf_fix into 9cf85c1f38fc993b4a256578b1a43d586f8ef6f9 on giampaolo:master.

How does this compare with what other FTP servers do in ASCII mode?

How does this compare with what other FTP servers do in ASCII mode?

PureFTPd has the same issue.
https://support.microfocus.com/kb/doc.php?id=7008378
https://winscp.net/eng/docs/faq_line_breaks#known_issues
ProFTPd handles it correctly and does not convert CRLF to CRCRLF.

Could you please update HISTORY file describing the problem? That aside this LGTM.

...and CREDITS (add your name)

Should I bump the version up to 1.5.5 in HISTORY.rst?

Also, should I create an issue here on GitHub describing the problem in order to conform the HISTORY.rst format (#issue reference) or may I just refer to this PR?

Thanks.

Thank you!

Given that the code no longer uses os.linesep, should _posix_ascii_data_wrapper also be converting "\r not followed by \n" into "\r\n" for those OSes where os.linesep is \r ?

Regarding os.linesep == '\r', support, I agree with you, I didn't take tis into account, but AFAIK only MacOS 9 and lower use this separator; the latest Python version for it is 2.3. Am I correct? Does pyftpdlib support it?
Also, I believe we should not rely on os.linesep at all, and try to convert LF endings to CRLF even when os.linesep == '\r\n' but I tried to keep modifications as small as possible.

We support from 2.6 onwards. I'm not sure if there are systems other than OSX9 where os.sep == '\r'.

Just to clarify - I don't need support for \r line endings, I was just pointing it out in case it was something that got overlooked... :wink:
(i.e. I won't be upset if support doesn't get added)

that goes without saying :)
thanks for pointing it out
On Wed, 27 Mar 2019 at 18:30, Andrew Scheller<EMAIL_ADDRESS>wrote:

Just to clarify - I don't need support for \r line endings, I was just
pointing it out in case it was something that got overlooked... 😉
(i.e. I won't be upset if support doesn't get added)
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/giampaolo/pyftpdlib/pull/492#issuecomment-477268912,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAplLLaazLlP8o1RMT8rVkdiyitw4TpQks5va6q1gaJpZM4cMIjd
.

--
Giampaolo - http://grodola.blogspot.com

I've added support of CR to CRLF converion in https://github.com/giampaolo/pyftpdlib/pull/494.


Add worker persisted cluster ID

What changes are proposed in this pull request?
Add persisted clusterID
Why are the changes needed?
fixed the issue: https://github.com/Alluxio/alluxio/issues/14209
DESIGN DOC
Two main functions in this PR

Add a file DB implementation  for worker use to  persist the clusterId of worker

Add a preRegistration phase before the worker register to master. The worker will not do anything about register(include getWorkerId with master) until this phase is completed when the worker starts
In this stage, the worker will report the persisted clusterID to the master. The master will compare it with current
clusterId and return command to the worker.

if the worker is new, it will report the "INVALID_CLUSTER_ID" to master and the master will return a Persist command and the clusterId string. Then the worker will persist the clusterId.
if the worker is beginning another cluster , it will report the different clusterId with the current cluster to master and the master will return a Reset command and the clusterId string. Then the worker will reset itself(reset == clear all blocks in tier and resetState) and persist the new clusterId (this is todo).
the most normal case, the worker will report the same clusterId with the current cluster to master. So master  will return a Nothing command, and the worker needn't do anything

usage:
[root@linux alluxio_home]# bin/alluxio-start.sh local
//...
-----------------------------------------
Starting to monitor all local services.
-----------------------------------------
//...
[root@linux alluxio_home]# cat clusterid  // the file use to persist clusterId
#generated by worker process, don't edit it
#Tue Oct 19 16:25:03 CST 2021
clusterId=d177aeaa-a7cf-4938-8859-3f3e54ffde16

[root@linux alluxio_home]# rm clusterid  // simulate a new worker, worker save cluster in the file "clusterid"
[root@linux alluxio_home]# bin/alluxio-start.sh worker
//...
[root@linux alluxio_home]# cat clusterid
#generated by worker process, don't edit it
#Tue Oct 19 16:27:31 CST 2021
clusterId=d177aeaa-a7cf-4938-8859-3f3e54ffde16

[root@linux alluxio_home]# vim clusterid // simulate a another cluster worker, worker will reset and save cluster in the file "clusterid"
[root@linux alluxio_home]# cat clusterid
#generated by worker process, don't edit it
#Tue Oct 19 16:27:31 CST 2021
clusterId=d177aeaa-a7cf-4938-8859-3f3e54ffde17
[root@linux alluxio_home]# bin/alluxio-start.sh worker
//...
[root@linux alluxio_home]# cat clusterid
#generated by worker process, don't edit it
#Tue Oct 19 16:28:16 CST 2021
clusterId=d177aeaa-a7cf-4938-8859-3f3e54ffde16
[root@linux alluxio_home]#

There are two more features about this "clusterid feature" that will be implemented but may not be included in this PR

clear all blocks in tier  when worker receive Reset command
report the clusterId in workerMasterSync heartbaet

Does this PR introduce any user facing changes?
no

Codecov Report

Merging #14258 (543db8c) into master (c061b93) will decrease coverage by 27.85%.
The diff coverage is 42.85%.

@@              Coverage Diff              @@
##             master   #14258       +/-   ##
=============================================
- Coverage     43.10%   15.25%   -27.86%
+ Complexity     9292     2145     -7147
=============================================
  Files          1437     1438        +1
  Lines         83695    83981      +286
  Branches      10140    10156       +16
=============================================
- Hits          36079    12809    -23270
- Misses        44614    70117    +25503
+ Partials       3002     1055     -1947

Impacted Files
Coverage Δ

...ient/journal/RetryHandlingJournalMasterClient.java
0.00% <ø> (ø)

...ore/common/src/main/java/alluxio/util/IdUtils.java
26.66% <ø> (-20.01%)
:arrow_down:

...in/java/alluxio/master/meta/DefaultMetaMaster.java
42.68% <ø> (-1.98%)
:arrow_down:

...ain/java/alluxio/worker/block/BlockMasterSync.java
0.00% <0.00%> (-65.58%)
:arrow_down:

.../java/alluxio/stress/cli/WorkerHeartbeatBench.java
0.00% <0.00%> (ø)

...n/java/alluxio/worker/block/BlockMasterClient.java
14.45% <30.00%> (-64.49%)
:arrow_down:

...in/java/alluxio/worker/block/BlockWorkerState.java
33.33% <33.33%> (ø)

.../java/alluxio/worker/block/DefaultBlockWorker.java
20.88% <40.00%> (-46.71%)
:arrow_down:

.../master/block/BlockMasterWorkerServiceHandler.java
13.58% <50.00%> (-53.09%)
:arrow_down:

.../java/alluxio/master/block/DefaultBlockMaster.java
20.56% <60.00%> (-59.22%)
:arrow_down:

... and 755 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71165a5...543db8c. Read the comment docs.

As you are proposing an RPC before worker registers, this can probably be merged with https://github.com/Alluxio/alluxio/pull/14220?

@jiacheliu3 the DESIGN DOC has been updated, please take a look.

@jiacheliu3 the WORKER_CLUSTERID_PATH default is ${ALLUXIO_HOME}/persist, this is the path used to save the clusterId file. By default, the worker must have permission to this directory, so that the clusterId can be persisted. If there is no permission, the worker will throw an RuntimeException and exit. This directory (/opt/alluxio/persist/) does not have permission in the community test environment. So many unit tests failed.
Can we add permissions to this directory? Otherwise, I need to set WORKER_CLUSTERID_PATH of all related tests set to the temporary directory.

// TODO Integration Tests

@jiacheliu3 I have merged preRegister into getWokreID and changed the signature of getWokreID

Hi @xichen01 & @jiacheliu3,
@LuQQiu and I have some discussion offline, we think this pr might help for cleaning the staled blocks to prevent the storage leak also.     So both of us propose to consider the worker's format op also, because the worker's format might be interrupted or failed to delete some of the files(see https://github.com/Alluxio/alluxio/issues/15171).  We just have a rough idea,  we could put the last format timestamp in the worker's storage path, something like
{master_last_format_timestamp}/{worker_last_format_timestamp}/block_files
master_last_format_timestamp is identical to your cluster_id, then it would be much easier to clean the staled or dirty block files

@beinan If the leader of the raft-HA cluster changes, will the new master have the same {master_last_format_timestamp} as the old master?

@beinan If the leader of the raft-HA cluster changes, will the new master have the same {master_last_format_timestamp} as the old master?

Great question!  but I'm afraid I don't know. @jiacheliu3 do you have any ideas?

@beinan If the leader of the raft-HA cluster changes, will the new master have the same {master_last_format_timestamp} as the old master?

Great question! but I'm afraid I don't know. @jiacheliu3 do you have any ideas?

Can we use the first leader master up time, and master_last_format_time can be one of the earliest journal entry?

Hi @xichen01 & @jiacheliu3, @LuQQiu and I have some discussion offline, we think this PR might help for cleaning the staled blocks to prevent the storage leak also. So both of us propose to consider the worker's format op also, because the worker's format might be interrupted or failed to delete some of the files(see #15171). We just have a rough idea, we could put the timestamp of last format in the worker's storage path, something like {master_last_format_timestamp}/{worker_last_format_timestamp}/block_files
master_last_format_timestamp is identical to your cluster_id, then it would be much easier to clean the staled or dirty block files

@beinan I see your point. I think handling the format time (at master and worker and probably consider HA master too) will add too many states and corner cases for this single PR to handle. If you have a github issue or WIP PR feel free to link to this PR, we'd like to stay tuned on that idea as well.

@xichen01 I see some outstanding comments and some conflicts in this PR, is this still actively worked on?


How to rerender an item?

I have some cards with buttons on them. When the buttons pressed the cards need rerendering as the information on them will change according to the button press. How could I trigger this rerender - ideally such that only the impacted card gets rerendere?
Thanks!

⚠ You did not follow the contributing guidelines!
As stated in these:

You need to fill out the issue template. This step is mandatory! Not doing so will result in your issue getting closed. Don't take this personally if this happens, and feel free to open a new issue once you've gathered all the information required by the template.

Regarding your question, and since the Carousel component extends the FlatList one, you can try to use prop extraData={this.state} and see if this solves your issue. You can take a look at the RN doc for more info.
Note that this has already been mentioned in #133 and #180.

It helped thanks!


Use short IDs in git dependencies checkout path

… in order to contribute less to the path length limit on Windows: https://github.com/servo/servo/pull/14397

r? @alexcrichton
(rust_highfive has picked a reviewer for you, use r? to override)

@bors: r+
Neat!

:pushpin: Commit 03d5e31 has been approved by alexcrichton

:hourglass: Testing commit 03d5e31 with merge 0dc56d3...

:broken_heart: Test failed - cargo-linux-64

Updated to split the 101 characters comment line.

@bors: r+

:pushpin: Commit ed6a622 has been approved by alexcrichton

:hourglass: Testing commit ed6a622 with merge 97b99df...

:sunny: Test successful - cargo-cross-linux, cargo-linux-32, cargo-linux-64, cargo-mac-32, cargo-mac-64, cargo-win-gnu-32, cargo-win-gnu-64, cargo-win-msvc-32, cargo-win-msvc-64
Approved by: alexcrichton
Pushing 97b99dfafe8233f4cb362d7a31623eb1a08e7b4e to master...


Fixed ConcurrentModificationException error in StaticEntryPusher.java

There was a ConcurrentModificationException error occurring when the LoadBalancer module was used with httperf (relatively high rates) and python's SimpleHTTPServer.
After modifying HashMap to ConcurrentHashMap as can be seen below, no such errors occurred.

Looks good to me. Thanks!


Create some Colab notebooks that demonstrate SwiftFusion

I'm going to work on this one first, and send some PRs for some example notebooks as I create them. I don't have permissions in this repo to assign issues, so this comment will be my self-assignment for now :)

@dellaert I think I do not have the admin rights to this repo after the move, so you need to add Marc :)

Done

Thanks!

I'll put my previous notebook here:
https://colab.research.google.com/drive/1wdcqpf19MPHhjZx_F4uaZMcWGilCCNjn

Added one using the G2O reader @marcrasi created: https://colab.research.google.com/drive/1R0hbs8agGYlEPAMU-OITrT8W6c9bBozz?usp=sharing

Those are really cool! Let's keep collecting links to notebooks in this issue. I'll unassign myself since clearly I'm not really working on this :)

That is pretty awesome! Note G2O is the file format here, but naming the colab with G2O in the name might cause confusion, as G2O is another inference toolbox.

Should we not check those notebooks into the repo as well? Colab has GitHub integration...

I changed the name to SwiftFusion Pose2SLAM Demo (Public).ipynb
I think we can check them in to the docs folder, I'll do it shortly


Add support for Kubernetes v1.31.0

Description of the feature or enhancement:
Publishing a new cdk8s-plus-31 library based on k8s 1.31.0 schema
Use Case:
Supporting https://kubernetes.io/blog/2024/08/13/kubernetes-v1-31-release/
Proposed Solution:
Following instructions: https://github.com/cdk8s-team/cdk8s-plus/blob/k8s-30/main/rotate.md

This is a :rocket: Feature Request

Done: https://cdk8s.io/docs/latest/reference/cdk8s-plus-31/typescript/


FPS consultation

hi,
i want to know the fps on the mobile phone just like android and ios, thanks!

It can reach about 200ms on 820 with ncnn.


Update requirements.txt

What does this PR do?
Fixes # (issue)
Before submitting

[ ] Did you read the contributor guideline?

LGTM!


Fix code scanning alert-Incorrect conversion between integer types

What type of PR is this?
/kind bug

What this PR does / why we need it:
Fix code scanning alert-Incorrect conversion between integer types
Which issue(s) this PR fixes:
Fixes #551
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

@ghostloda thanks your contribution :) , you need to fix the DCO

@ghostloda thanks your contribution :) , you need to fix the DCO

ok，fixed

good job 👍

@wawa0210   I also want to fix other scanning-Incorrect issues, but I can't see the specific error message. Can you help me?

@wawa0210 I also want to fix other scanning-Incorrect issues, but I can't see the specific error message. Can you help me?

I have attached the details in another issues.


ci: enhance monorepo release flow with changesets

PR Type
Enhancement, Configuration changes

Description

Added a README file for Changesets with introductory information and links to documentation.
Added configuration file for Changesets with schema, changelog, and repository details.
Added GitHub Actions workflow for releasing packages using Changesets.
Updated package.json to include Changesets dependencies and scripts for publishing, and modified existing publish scripts to include build steps.

Changes walkthrough 📝
Relevant filesDocumentation

README.mdAdd README for Changesets with documentation links

.changeset/README.md
Added a README file for Changesets with introductory information and links to documentation.

+8/-0

Configuration changes

config.jsonAdd Changesets configuration file

.changeset/config.json
Added configuration file for Changesets with schema, changelog, and repository details.

+11/-0

changesets-release.ymlAdd GitHub Actions workflow for Changesets release

.github/workflows/changesets-release.yml
Added GitHub Actions workflow for releasing packages using Changesets.

+44/-0

Enhancement

package.jsonUpdate package.json with Changesets dependencies and scripts

package.json
Added Changesets dependencies and scripts for publishing.  Modified existing publish scripts to include build steps.

+7/-4

💡 PR-Agent usage:
Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

Reference:

Send data into Slack using the slack-send GitHub Action:
https://github.com/slackapi/slack-github-action

/review


exports vs export

I noticed that both examples use the exports syntax. I was wondering if that is a requirement?
https://github.com/devongovett/unplugin-parcel-macros/blob/d523d9f7c768050e83e5bedc503df75377a3d68a/examples/next/macro.js#L1
https://github.com/devongovett/unplugin-parcel-macros/blob/d523d9f7c768050e83e5bedc503df75377a3d68a/examples/vite/macro.js#L1
When changing the syntax to EcmaScript modules (export const css) I get the following error:
[plugin:unplugin-macros] × Error loading macro: Unexpected token 'export'
   ╭─[test.js:1:1]
 1 │ import './style.css'
 2 │ import { readFileSync } from 'fs' with {type: 'macro'};
 3 │ import { setupCounter } from './counter.js'
 4 │ import { css } from "./macro" with {type:'macro'};
   · ──────────────────────────────────────────────────
 5 │
 6 │ document.querySelector('#app').innerHTML = `
 7 │   <div>
   ╰────

Are EcmaScript modules supported? Do I need to change the configuration to enable ESM support?

Yeah. It uses node's module loader so you need to either use the .mjs extension or add "type": "module" to your package.json.

Thanks a lot for the quick clarification. In hindsight it's embarrassingly obvious.


hotfix: Add SPSP 2015; disable old conferences.

Purpose
Add SPSP conference and disable old conferences.
Changes
See above
Side effects
None expected
@sloria: The requested admin user for SPSP2015 didn't exist on production as of this morning, so @KatyCain526 did/will talk to her/him and confirm when the account exists. At that point, we can run populate_conferences.
Resolves #1444
Resolves #1456

@sloria Just so you know, we would like the presentation service stuff to be up as soon as possible.


esque edit & apply doesn't apply changes to partitions and replication

The replication thing is a little more complicated. Not even "official" topic edit command line tool can do this. You'll have to start a partition reassignment, where every partition gets assigned to the desired number of brokers. Meaning that you'll have to consider balancing if you don't want to assign/remove them randomly.

 The least we can do for now is failing loudly if the user attempts to change those settings then

This issue also applies to esque apply

With #27 esque edit will no longer show the non-editable properties and esque apply will warn that it won't change those settings on existing topics. Removing the "bug" label and adding "enhancement"


pip install version of chromecast - PyChromecast-<IP_ADDRESS>-py3.4.egg-info

Has a bug causing it to fail talking to chromecasts. the bug was fixed in
https://github.com/balloob/pychromecast/commit/ac4eb58ac19eddc773f1756573b7db462d9a5439
but anyone installing from pip will have a failure.
I went and fixed it and was going to put in a pull request - only to find it was tracked down and done.
Is it possible for you to rebuild and republish the pychromecast library for pip referred to in requirements.txt  or put a forked version up that fixes the problem and add that to the requirements.txt
(env)marchon@cargo:~/home-assistant/env/lib/python3.4/site-packages/PyChromecast-<IP_ADDRESS>-py3.4.egg-info$ cat *
../pychromecast/upnp.py
../pychromecast/websocket.py
../pychromecast/config.py
../pychromecast/dial.py
../pychromecast/error.py
../pychromecast/init.py
../pychromecast/youtube.py
../pychromecast/pycache/upnp.cpython-34.pyc
../pychromecast/pycache/websocket.cpython-34.pyc
../pychromecast/pycache/config.cpython-34.pyc
../pychromecast/pycache/dial.cpython-34.pyc
../pychromecast/pycache/error.cpython-34.pyc
../pychromecast/pycache/init.cpython-34.pyc
../pychromecast/pycache/youtube.cpython-34.pyc
./
not-zip-safe
SOURCES.txt
requires.txt
PKG-INFO
top_level.txt
dependency_links.txt
Metadata-Version: 1.1
Name: PyChromecast
Version: <IP_ADDRESS>
Summary: Python module to talk to Google Chromecast.
Home-page: https://github.com/balloob/pychromecast
Author: Paulus Schoutsen
Author-email<EMAIL_ADDRESS>License: MIT
Description: UNKNOWN
Platform: any
Classifier: Intended Audience :: Developers
Classifier: License :: OSI Approved :: MIT License
Classifier: Operating System :: OS Independent
Classifier: Programming Language :: Python
Classifier: Programming Language :: Python :: 2
Classifier: Programming Language :: Python :: 3
Classifier: Topic :: Software Development :: Libraries :: Python Modules
requests
ws4py
setup.cfg
setup.py
PyChromecast.egg-info/PKG-INFO
PyChromecast.egg-info/SOURCES.txt
PyChromecast.egg-info/dependency_links.txt
PyChromecast.egg-info/not-zip-safe
PyChromecast.egg-info/requires.txt
PyChromecast.egg-info/top_level.txt
pychromecast/init.py
pychromecast/config.py
pychromecast/dial.py
pychromecast/error.py
pychromecast/upnp.py
pychromecast/websocket.py
pychromecast/youtube.pypychromecast

the error that was generated was
Traceback (most recent call last):
  File "/home/marchon/home-assistant/homeassistant/__init__.py", line 273, in job_handler
    func(arg)
  File "/home/marchon/home-assistant/homeassistant/__init__.py", line 757, in _execute_service
    service(call)
  File "/home/marchon/home-assistant/homeassistant/components/chromecast.py", line 325, in <lambda>
    play_youtube_video_service(service, "eyU3bRy2x44"))
  File "/home/marchon/home-assistant/homeassistant/components/chromecast.py", line 297, in play_youtube_video_service
    pychromecast.play_youtube_video(video_id, cast.host)
  File "/home/marchon/home-assistant/env/lib/python3.4/site-packages/pychromecast/youtube.py", line 14, in play_youtube_video
    _start_youtube(data, host, cast, **filters)
  File "/home/marchon/home-assistant/env/lib/python3.4/site-packages/pychromecast/youtube.py", line 36, in _start_youtube
    cast = get_chromecast(strict=False, **filters)
  File "/home/marchon/home-assistant/env/lib/python3.4/site-packages/pychromecast/__init__.py", line 98, in get_chromecast
    results = get_chromecasts(**filters)
  File "/home/marchon/home-assistant/env/lib/python3.4/site-packages/pychromecast/__init__.py", line 62, in get_chromecasts
    if chromecast.host != filter['ip']:
TypeError: 'type' object is not subscriptable

The current Chromecast support broken. Chromecasts have migrated to use a new API last year based on Google Protobuf. PyChromecast has been updated but it does not support Python 3 yet, it is waiting for the new release of Protobuf 3 that will support Python 3 to push a new version to PIP.

pip currently supports cloning over git, git+http and git+ssh:
git+git://git.myproject.org/MyProject#egg=MyProject
git+http://git.myproject.org/MyProject#egg=MyProject
git+ssh://git.myproject.org/MyProject#egg=MyProject
On Sat, Feb 21, 2015 at 1:06 PM, Paulus Schoutsen<EMAIL_ADDRESS>wrote:

The current Chromecast support broken. Chromecasts have migrated to use a
new API last year based on Google Protobuf. PyChromecast has been updated
but it does not support Python 3 yet, it is waiting for the new release of
Protobuf 3 that will support Python 3 to push a new version to PIP.
—
Reply to this email directly or view it on GitHub
https://github.com/balloob/home-assistant/issues/32#issuecomment-75383934
.

--
P THINK BEFORE PRINTING: is it really necessary?
This e-mail and its attachments are confidential and solely for the
intended addressee(s). Do not share or use them without approval. If
received in error, contact the sender
and delete them.

protobuf 3 currently has alpha2 on PyPi with alpha3 in the works. Is it worth spending time/effort trying to get this to work with pychromecast / python 3 / home assistant?

It shouldn't be too hard to get it working with Protobuf 3. There have been some API breaking changes between PyChromecast 0.5 and 0.6, but nothing major.

have a look at https://github.com/balloob/pychromecast/pull/44 :)

I think that this bug can be closed since new chromecast support is in the works and a new pychromecast version is on PyPi


Take into account the current user for message displaying

Show the user icon on the left of the message if it's the current user, on the right if it's another user
Screencast from 2022-12-15 15-19-03.webm

I took your comments into account! Thanks for the review

Thanks!


Unexpected build errors with SNITCH_DO_TEST enabled and SNITCH_WITH_ALL_REPORTERS disabled

When configuring Snitch with tests but not reporters as follows, for example:
cmake -S . -B /tmp/snitch/build -DSNITCH_DO_TEST=ON -DSNITCH_WITH_ALL_REPORTERS=OFF

and then building
cmake --build /tmp/snitch/build

The build fails with the error messages shown at the bottom. However, the problem does not occur when
disabling the reportes by setting both the SNITCH_WITH_CATCH2_XML_REPORTER and SNITCH_WITH_TEAMCITY_REPORTER flags.
$ cmake --build /tmp/snitch/build

<...>

/home/user/Projects/snitch/tests/approval_tests/reporter_catch2_xml.cpp: In function ‘void DOCTEST_ANON_FUNC_2()’:
/home/user/Projects/snitch/tests/approval_tests/reporter_catch2_xml.cpp:21:37: error: ‘catch2_xml’ is not a member of ‘snitch::reporter’
   21 |     std::optional<snitch::reporter::catch2_xml::reporter> reporter;
      |                                     ^~~~~~~~~~
/home/user/Projects/snitch/tests/approval_tests/reporter_catch2_xml.cpp:21:57: error: template argument 1 is invalid
   21 |     std::optional<snitch::reporter::catch2_xml::reporter> reporter;
      |                                                         ^
/home/user/Projects/snitch/tests/approval_tests/reporter_catch2_xml.cpp: In lambda function:
/home/user/Projects/snitch/tests/approval_tests/reporter_catch2_xml.cpp:22:58: error: request for member ‘emplace’ in ‘reporter’, which is of non-class type ‘int’
   22 |     auto init      = [&](snitch::registry& r) { reporter.emplace(r); };
      |                                                          ^~~~~~~
/home/user/Projects/snitch/tests/approval_tests/reporter_catch2_xml.cpp: In lambda function:
/home/user/Projects/snitch/tests/approval_tests/reporter_catch2_xml.cpp:24:25: error: request for member ‘value’ in ‘reporter’, which is of non-class type ‘int’
   24 |         return reporter.value().configure(r, k, v);
      |                         ^~~~~
/home/user/Projects/snitch/tests/approval_tests/reporter_catch2_xml.cpp: In lambda function:
/home/user/Projects/snitch/tests/approval_tests/reporter_catch2_xml.cpp:27:25: error: request for member ‘value’ in ‘reporter’, which is of non-class type ‘int’
   27 |         return reporter.value().report(r, e);
      |                         ^~~~~
/home/user/Projects/snitch/tests/approval_tests/reporter_catch2_xml.cpp: In lambda function:
/home/user/Projects/snitch/tests/approval_tests/reporter_catch2_xml.cpp:29:62: error: request for member ‘reset’ in ‘reporter’, which is of non-class type ‘int’
   29 |     auto finish = [&](snitch::registry&) noexcept { reporter.reset(); };
      |                                                              ^~~~~
/home/user/Projects/snitch/tests/approval_tests/reporter_catch2_xml.cpp: In function ‘void DOCTEST_ANON_FUNC_2()’:
/home/user/Projects/snitch/tests/approval_tests/reporter_catch2_xml.cpp:31:36: error: no matching function for call to ‘snitch::registry::add_reporter(const char [4], DOCTEST_ANON_FUNC_2()::<lambda(snitch::registry&)>&, DOCTEST_ANON_FUNC_2()::<lambda(snitch::registry&, std::string_view, std::string_view)>&, DOCTEST_ANON_FUNC_2()::<lambda(const snitch::registry&, const data&)>&, DOCTEST_ANON_FUNC_2()::<lambda(snitch::registry&)>&)’
   31 |     framework.registry.add_reporter("xml", init, configure, report, finish);
      |     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /home/user/Projects/snitch/include/snitch/snitch_macros_check_base.hpp:6,
                 from /home/user/Projects/snitch/include/snitch/snitch_macros_check.hpp:6,
                 from /home/user/Projects/snitch/include/snitch/snitch.hpp:16,
                 from /home/user/Projects/snitch/tests/testing.hpp:16,
                 from /home/user/Projects/snitch/tests/approval_tests/reporter_catch2_xml.cpp:1:
/home/user/Projects/snitch/include/snitch/snitch_registry.hpp:211:22: note: candidate: ‘template<class T>  requires  reporter_type<T> std::string_view snitch::registry::add_reporter(std::string_view)’
  211 |     std::string_view add_reporter(std::string_view name) {
      |                      ^~~~~~~~~~~~
/home/user/Projects/snitch/include/snitch/snitch_registry.hpp:211:22: note:   template argument deduction/substitution failed:
/home/user/Projects/snitch/tests/approval_tests/reporter_catch2_xml.cpp:31:36: note:   candidate expects 1 argument, 5 provided
   31 |     framework.registry.add_reporter("xml", init, configure, report, finish);
      |     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /home/user/Projects/snitch/include/snitch/snitch_macros_check_base.hpp:6,
                 from /home/user/Projects/snitch/include/snitch/snitch_macros_check.hpp:6,
                 from /home/user/Projects/snitch/include/snitch/snitch.hpp:16,
                 from /home/user/Projects/snitch/tests/testing.hpp:16,
                 from /home/user/Projects/snitch/tests/approval_tests/reporter_catch2_xml.cpp:1:
/home/user/Projects/snitch/include/snitch/snitch_registry.hpp:202:36: note: candidate: ‘std::string_view snitch::registry::add_reporter(std::string_view, const std::optional<snitch::function_ref<void(snitch::registry&) noexcept> >&, const std::optional<snitch::function_ref<bool(snitch::registry&, std::basic_string_view<char>, std::basic_string_view<char>) noexcept> >&, const report_function&, const std::optional<snitch::function_ref<void(snitch::registry&) noexcept> >&)’
  202 |     SNITCH_EXPORT std::string_view add_reporter(
      |                                    ^~~~~~~~~~~~
/home/user/Projects/snitch/include/snitch/snitch_registry.hpp:205:58: note:   no known conversion for argument 3 from ‘DOCTEST_ANON_FUNC_2()::<lambda(snitch::registry&, std::string_view, std::string_view)>’ to ‘const std::optional<snitch::function_ref<bool(snitch::registry&, std::basic_string_view<char>, std::basic_string_view<char>) noexcept> >&’
  205 |         const std::optional<configure_report_function>&  configure,
      |         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~
gmake[2]: *** [tests/CMakeFiles/snitch_approval_tests.dir/build.make:118: tests/CMakeFiles/snitch_approval_tests.dir/approval_tests/reporter_catch2_xml.cpp.o] Error 1
gmake[1]: *** [CMakeFiles/Makefile2:232: tests/CMakeFiles/snitch_approval_tests.dir/all] Error 2
gmake: *** [Makefile:146: all] Error 2

Thanks for catching this. Definitely a bug, i'll push a fix soon (currently traveling).
The fact that this works when using SNITCH_WITH_CATCH2_XML_REPORTER=OFF and SNITCH_WITH_TEAMCITY_REPORTER=OFF is because SNITCH_WITH_ALL_REPORTERS is ON by default, and that takes precedence. To disable a reporter, both SNITCH_WITH_ALL_REPORTERS and SNITCH_WITH_***_REPORTER (replacing *** with the name of the reporter) must be set to OFF. That bit at least is working as intended.

Should be fixed now, thanks!

Thank you very much!


setting for default download quality

I download for watching on an iPhone SE, which has a smaller screen than 1080p (closer to 720p). As such, I do not need to download 1080p videos and always change the quality manually to 720p60. However, downloading a lot of videos at once, I have to manually configure this quality every time. It would be nice if I could choose a default download quality for videos in the settings.

Impossible since the streaming quality is dependent on the streamer

I thought as much. Would it instead be possible to remember the last selected streaming quality, even if only while the program is open?

Nope, sorry :) The streaming qualities can differ not only between channels but even between single videos (even if that's not very often the case, it is still possible). Just because one video is 720p@60fps, does not mean the next video from the same streamer has this exact quality as well. There is no coherence and for that reason I cannot implement somthing like a default quality reliably.


markers_data

Added choice for marker data type, user can use directly a table with marker position, a c3d file or just use the path to the c3d file.
#11

LGTM


Patch win unix compat

https://github.com/conda-forge/lcms2-feedstock/pull/3#discussion_r362735346
@kmilos

Checklist

[ ] Used a fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

Not too sure how this affects abi compatibility, but this used to be the default in 4.0
This means that 4.1 did break ABI compatibility on windows, but that change went on silently.

I can't be sure yet, but I think this new build is breaking libtiff (the python package on PyPI) being able to use libtiff (the C library on conda-forge) on Appveyor. I'll try forcing the old build and see if that helps.

This may be true. :/ We might have to revert.

Forcing build 1 (this PR is build 2) gets me further in my testing on appveyor. I'm also in dependency hell with my CI environment trying to install numpy 1.18 from PyPI and it breaking things which is what the above referenced commit got to. Using this PR's build seems to cause a segmentation fault of sorts. The appveyor log just goes from test output to stating the exit status of the appveyor script(s).

can you wait on numpy 1.18?
Reverting htis in an other PR.

Sorry for the late reply. I came down with a cold and it hit me hard Friday night.
And yes, I can hold off on numpy 1.18, it wasn't something I actually want but has become the new default "stable" version used by astropy's ci-helpers tool. Things seem to be passing with build 1 on appveyor.

FYI, build 3 has been released, reverting build 2, so the solver should find that by default now.

Yep, build 3 works for me. Thanks. Let me know when the next build of this PR is available and i can try it out.

If you are super inclined you can adding my channel
mark.harfouche
https://anaconda.org/mark.harfouche/libtiff/files
It has build 4, which is the same as the live PR i have
https://github.com/conda-forge/libtiff-feedstock/pull/51
That said, that PR does quite a bit more testing, so it should be safer ;)


return fix

return fix

Thanks for the corrections, but please be more descriptive than 2 words next time - that's really vague and anybody searching through issues/pull requests in the future will hate it.


doesn't appear mixpanel will work in the background if data protection is enabled

it writes data using the simple [NSKeyedArchiver archiveRootObject:p toFile:filePath] method, but instead it should probably create the files with an explicit data protection mode that allows it to collect events from the background?

Hey @ericcj I'm happy to make any changes that might be required to support explicit data protection. However, I'm not really clear on what iOS feature you're describing. Would you mind showing me some documentation that describes this feature?

e.g., use the following instead to make mixpanel available after the user first unlocks their device, or let the user specify this option when initializing mixpanel:
[[NSKeyedArchiver archivedDataWithRootObject:p] writeToFile:filePath options:NSDataWritingFileProtectionCompleteUntilFirstUserAuthentication error:&error]

@ericcj This option is actually more restrictive than what we're currently doing. It appears that the default is NSDataWritingFileProtectionNone, which will allow Mixpanel to write to the file in the background.

Closing this issue. If you have issues with Mixpanel working successfully in the background, please open another issue and we'll get it resolved.


Forkchoice compute_pulled_up_tip

Motivation

Follow the spec to make the implementation easier to maintain in the future

Description

Spec: https://github.com/ethereum/consensus-specs/blob/dev/specs/phase0/fork-choice.md#compute_pulled_up_tip
Remove pullUpStoreCheckpoints() which is not in the spec
Add updateUnrealizedCheckpoints() similar to the spec
This is a continuation of https://github.com/ChainSafe/lodestar/pull/5126

:tada: This PR is included in v1.7.0 :tada:


Deadlock in dependency resolution

Current Behavior
After upgrading from 8.2.1 (we skipped 8.3 as advised) to 8.4 resolving dependencies in all resolvable configurations in all projects (triggered by running ReportTask from com.github.jk1.dependency-license-report  across all projects in parallel execution mode) hangs the build.
Expected Behavior
Resolving dependencies in all resolvable configurations in all projects does not hang the build on 8.4.
Context (optional)
We've not seen any deadlocks on 8.2.1 or earlier but after switching to 8.4 this deadlocked in 90% of so far executed builds on CI.
I'm not sure if this is significant but it happens in a 1300 project build which includes a build that has an included build.
I'll happily provide more information that is needed to track this down, just please tell me what you need.
Steps to Reproduce
I've attached a thread dump taken upon the stuck build being killed. Issue only occurs in CI, I wasn't able to reproduce it locally so I believe that the problem is somewhat transient.
I did not dig too deep but you can see that three threads are waiting on 0x0000000674bd6000 and another thread which is waiting on another lock is holding it and the waiting threads seem to have org.gradle.api.internal.artifacts.repositories.resolver.ExternalResourceResolverDescriptorParseContext.resolveMetaDataArtifactFile in the stack.
Gradle version
8.4
Build scan URL (optional)
No response
Your Environment (optional)
No response

Thank you for providing a valid report.
The issue is in the backlog of the relevant team and is prioritized by them.
Related:

https://github.com/gradle/gradle/issues/26790

Hey @erdi!  I think I have a fix for this problem.  Can you give the following nightly a try and see if the issue still happens?
$ ./gradlew wrapper --gradle-version=8.6-20231116190533+0000

👀

Unfortunately it's still getting deadlocked on that version.
I'm attaching a threadump taken upon the stuck build using 8.6-20231116190533+0000 being killed. Hopefully that helps.

I got mixed up and copied the wrong nightly version (8.6-20231116190533+0000 does not have my fix).  Can you try the following version instead?
8.6-20231118001259+0000

I got 3 successful builds on 8.6-20231118001259+0000 whereas on 8.6-20231116190533+0000 I had three failures so it looks like your fix is working, @ghale.


[Question] Cant this work with wasm?

wasm-pack build

It does work with wasm (as long as you have a C++ standard library that supports wasm -- for example emscripten or wasi-sdk, although there are other ones that might also be viable).
For example I confirmed that https://github.com/dtolnay/cxx/tree/master/demo can be compiled to wasm32-unknown-emscripten and running the result produces the correct output on console.

@dtolnay can you please share the workflow of how you compiled the demo to wasm32-unknown-emscripten ?

cargo build --target wasm32-unknown-emscripten in the demo directory. This produces demo.wasm, and a demo.js to load it, if you need that. For running in a browser here is a minimal HTML file:
<!DOCTYPE html>

Open the console to see the output!

@dtolnay I have a C++ project compiled to wasm by emscripten, is it possible to add some rust helper functions in that project with the help of cxx? Thanks in advance.

Yes that seems like a good fit for cxx because you are interested in calling Rust from C++, which is a thing that cxx is built for.

@dtolnay
I'm trying to compile the demo https://github.com/dtolnay/cxx/tree/master/demo for wasm under macOS
The command is the following:
cargo build --target=wasm32-wasi

But getting an error:
  cargo:warning=In file included from /Users/asd/workspace/cxx/src/cxx.cc:1:
  cargo:warning=/Users/asd/workspace/cxx/src/../include/cxx.h:2:10: fatal error: 'algorithm' file not found
  cargo:warning=    2 | #include <algorithm>
  cargo:warning=      |          ^~~~~~~~~~~
  cargo:warning=1 error generated.

What could be wrong?


Can't get Orders back due to "signature_invalid" error

I'm having real trouble getting this working. I've used the Authenticator to get my temp details for the app and then applied for permanent details as well. That all seemed to work as it should. If I rerun that I get the same details back which makes me think its working as it should.
I've created the app to have permissions to "transactions_w", "transactions_r", "address_r".
However when I then use my oAuthToken and oAuthTokenSecret that came back on the GetPermanentCredentials call in a GetOrdersAsync call I keep getting "signature_invalid" and I can't see why?
var config = new EtsyConfig( shopName, oAuthToken, oAuthTokenSecret, 500 );
var throttler = new Throttler(config.ThrottlingMaxRequestsPerRestoreInterval, config.ThrottlingRestorePeriodInSeconds, config.ThrottlingMaxRetryAttempts);
var orderService = new EtsyAccess.Services.Orders.EtsyOrdersService(apiKey, sharedSecret, config, throttler);

var startDate = DateTime.Now.AddDays(-1);
var endDate = DateTime.Now;
var orders = orderService.GetOrdersAsync(startDate, endDate, CancellationToken.None);

This is the url its building up (with secrets removed):
https://openapi.etsy.com/v2/shops/PetesTestStore/receipts?oauth_consumer_key=MY-KEY&oauth_nonce=B179D2CC138&oauth_signature_method=HMAC-SHA1&oauth_timestamp=1568848379&oauth_version=1.0&oauth_token=MY_TOKEN&includes=Transactions,Listings,Country&limit=100&min_last_modified=1568765418&max_last_modified=1568851818&oauth_signature=MY_SIGGY=
When run it just seems to hang as it retries over and over getting the same error back.
What am I doing wrong? Do you have some example code or way to sanity check this at all?
Cheers
Pete

@PeteDuncanson - Given its been over a year I assume you found the issue or found another options but FYI see here: https://github.com/skuvault/etsyAccess/issues/16
I was having a similar issue, it was failing over and over which was making it take an age to do anything.

I was having a similar issue, it was failing over and over which was making it take an age to do anything.

I guess, HttpUtility.UrlEncode would fix it.

I don't know why here implemented EscapeUriData method if System.Web contains HttpUtility.UrlEncode.


feature request: Do not wrap imports in the identity function un-necessarily

I'm submitting a feature request
Webpack version:
2.1.0-beta.22
Please tell us about your environment:
Windows 8
Current behavior:
// test.js
import {a} from './a.js';
a();

// a.js
export function a() {
   console.log('a');
}

output:
/***/ function(module, exports, __webpack_require__) {

"use strict";
/* harmony export (immutable) */ exports["a"] = a;
function a() {
    console.log('a');
}

/***/ },
/* 1 */
/***/ function(module, exports, __webpack_require__) {

"use strict";
/* harmony import */ var __WEBPACK_IMPORTED_MODULE_0__a__ = __webpack_require__(0);

__webpack_require__.i(__WEBPACK_IMPORTED_MODULE_0__a__["a"])();

/***/ }

Expected/desired behavior:
__webpack_require__.i(__WEBPACK_IMPORTED_MODULE_0__a__["a"])();

becomes
__WEBPACK_IMPORTED_MODULE_0__a__["a"]();

What is the motivation / use case for changing the behavior?

Smaller bundle size, less executed code. Because the function being imported does not reference this, it does not need to be wrapped in identity function. Because actually most exported functions will not reference this.
Further if I have this code
import * as a from './a';
a.a();

then identity is not added, meaning the exports object is provided to the function when I call it - so that is inconsistent.

Yep, I'm also a bit annoyed by this. We will do many optimizations after webpack 2. We want to get to a stable working version before optimizing. The cost is small: r.i(b.a)() compared to b.a().

I'd like to keep this open. If someone could give me some pointers to where to start, I might be able find some time for a pr. Spent a while searching but it's really hard to guess the best approach and find the right code to modify.

@sokra would you be able to help with a where to start?

Scope Hoisting should eliminate most of these.
I'm currently not sure how to solve this.

Good point. I will check how many of these are left after hoisting.


Fix keyboard shortcut collisions

For example, Command+M on macOS.

https://support.apple.com/en-us/HT201236

I've changed Command+M (Image Controls) to Command+B, and Command+H (Auto-Hide) to Shift+Command+H which fixes the major collisions on macOS. It might be good to align some of the other shortcuts with the standard macOS shortcuts in the link above, though on the other hand now that the shortcuts are customizable maybe that's not necessary...


Update documentation links to point to monorepo

Problem

@krysal reports that the Documentation guidelines document includes links to the openverse-api repository.
Description

Search the repository for references to openverse-api and openverse-frontend and openverse-catalog and update them all to reference the monorepo. Where appropriate, add a note about the fact that the code was moved (not sure if necessary but it may be useful context for some specific cases).
Additional context
Marked as high because links to the old repositories are "extra" stale in that they'll never have up to date information.

These references were fixed and further documentation restructuring took place which removed the file referenced here.


No images found

Seems like I am getting something very similar to issue #3.
Trying to get fits images as demonstrated in the documentation but when I run
panstamps stack 09:55:52.2 +69:40:47

I get this:
default settings have been added to '/home/username/.config/panstamps/panstamps.yaml'. Tailor these settings before proceeding to run panstamps
* 18:27:21 - WARNING: /home/username/.local/lib/python2.7/site-packages/panstamps/downloader.py:get:228 > No images found. Your options may not be set correctly. Here's the requested URL:
http://plpsipp1v.stsci.edu/cgi-bin/ps1cutouts?filter=g&filter=r&filter=i&catlist=&autoscale=99.500000&verbose=0&output_size=1200&filetypes=stack&pos=09%3A55%3A52.2+%2B69%3A40%3A47&size=240

Which is saying that no images are found but there are clearly images in the link. I have run this off a fresh install, so I have not changed anything in panstamps.yaml. Any ideas on what might be the problem here?

Hi jermainegug, can you try and do a 'pip install fundamentals --upgrade' then the command again? I think there may have been a bug in the underlying download code I use.

Yep. That has fixed it! :)
Thanks heaps.


Brpoplpush does not set Jedis client timeout to infinite

The blocking call brpoplpush does not call setTimeoutInfinite() and will throw a socket timeout exception after the default 2 seconds.
blpop makes the correct call to setTimeoutInfinite() and brpoplpush should replicate this behaviour.

Hi @xetorthio.
Should the timeout be really indefinite?
In last couple of weeks we are observing that our service hangs on method:
jedis.brpoplpush(REDIS_QUEUE_NAME_BYTES, redisWorkQueueNameBytes,                            REDIS_POP_BLOCKING_TIMEOUT_IN_SECONDS).
It can hang for minutes.
REDIS_POP_BLOCKING_TIMEOUT_IN_SECONDS is set to 1 second. It is quite possible that our Redis server provider restarted or terminated our redis server while brpoplpush was running. At least we've got notification from provider, that in this time redis had some maintenance.


Enable tests for opensearchservice

Issue #, if available: https://github.com/aws-controllers-k8s/community/issues/991
Description of changes:
Enable Prow tests and management for the new opensearchservice repository.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

/lgtm


Update Safari srcset usage

Hi :),
Unfortunately, I figured support is still partial for sizes on Safari. Especially, the min/max expressions are not supported (work properly on Chrome and Firefox) which cause Safari to always use the largest image available when finding such expressions. I opened a bug report here: https://bugs.webkit.org/show_bug.cgi?id=259812

Thanks!


why AppHealthCheck didn't send health check request?

In what area(s)?

kubernetes+dapr 1.10.4

Ask your question here
When i add appHealthCheck in deployment annotation and Dapr CRD config ,the health check request didn't be sent.
Is there any another config need me to add?
Deployment Annotation:

Dapr Crd config :

Daprd log:

application log:

doc:

https://docs.dapr.io/developing-applications/building-blocks/observability/app-health/
https://docs.dapr.io/operations/configuration/preview-features/
https://docs.dapr.io/operations/support/support-preview-features/

ok,i had change them to that is without ",but it didn't check health.

i had found the reason!
These annotations should be add in spec.template.metadata.annotations instead of metadata.annotations


@font-face improvement

As Boosted v4 officially only supports IE10+, we should remove .eot, .ttf and .svg from @font-face stack (both for Helvetica Neue and Orange Icons) — and delete associated files, of course. Please note that it'll also work with IE9.
It would result as a smaller package and a performance improvement since .woff is lighter and smarter than other formats.
Also maintaining files would be easier since there would be only two of them :)

thanks @ffoodd


TS - Selective imports

https://github.com/microsoft/kiota-typescript/pull/520.
fixes #1969

modular augmentation and selective import has been implemented for the root segments only in the service libraries, it won't be implemented at every level as it'd be detrimental to the developer experience. closing


Tabular: Added documentation of name suffix meaning

Issue #, if available: #961
Description of changes:

Added documentation of name suffix meaning

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Job PR-965-1 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-965/1/index.html


does xrdp's pulseaudio sink and source work with pulseaudio's TCP network capability?

Pulseaudio supports networked sound.
By that I mean I can have a machine running the Pulseaudio "server" and various remote client machines play audio via that Pulseaudio "server" remotely.
The setup on the server is simple and just needs the following added to the Server's
/etc/pulse/system.pa config file:
load-module module-native-protocol-tcp auth-ip-acl=<IP_ADDRESS>;x.x.x.x/yy auth-anonymous=1
load-module module-zeroconf-publish
The 1st line loads Pulseaudio's TCP connection support and the auth-ip-acl statement says to permit pulseaudio connections from <IP_ADDRESS> and from some remote network/subnet x.x.x.x/yy
the auth-anonymous-1 just authorizes audio from anyone on the ACL permitted networks.
On Client machines you only need to have an environment variable set for the Users that ID's the remote Pulseaudio "server" to use ...
example assuming the Pulseaudio server setup as above has the IP of <IP_ADDRESS> a user's environment would have to have:
PULSE_SERVER=<IP_ADDRESS>
And pulseaudio requests will be forwarded to that remote <IP_ADDRESS> pulseaudio server.
My question for XRDP is:
Do the XRDP Pulseaudio SINK and SOURCE modules support connection to a remote Pulseaudio "server"  via TCP like this?
The reason I ask is that with XRDP the SINK/SOURCE get loaded in /etc/xrdp/pulse/default.pa but Pulseaudio at user login will default to the remote Pulseaudio server (<IP_ADDRESS>) not the local user's pulseaudio.
I am using Guacamole with XRDP.
So if my "session" is to a local machine via xrdp but the Pulseaudio Server is via a TCP connection to a different machine ... is the XRDP SINK/SOURCE designed to work with that... or does the XRDP SINK/SOURCE "assume" the Pulseaudio server is locally installed/running?
I hope this makes sense as I've been fighting this for well over a year but finally thought maybe I am assuming too much.
thanks
brian

On a previous thread related to my attempts to get xrdp's pulseaudio SINK/SOURCE to work in containers "speidy" commented on Jul 13, 2016...

there are 2 things to be aware of:  PA must load our sink (aka module-xrdp-sink.so).
in a normal per-user session we set (xrdp-sesman) the PULSE_SCRIPT env var in the USER session to point to /etc/xrdp/pulse/default.pa file, which instructs PA to load our pulse config file instead of the default per-user config /etc/pulse/default.pa when X11rdp session  starts.
when pulseaudio loads our sink, it is relying on the DISPLAY env var in order to send the audio data to the right xrdp-chansrv socket matching the current session (aka channel server, which wraps the audio data into the RDPSND channel and send it back to client). (you can look at: https://github.com/neutrinolabs/xrdp/blob/devel/sesman/chansrv/pulse/module-xrdp-sink.c#L311 )
The thing is, when you run pulse audio in a system-wide mode (as root), the DISPLAY env var might be wrong / not set.

I think Speidy's comment above/below is the heart of my problem and the reason XRDP fails sound/audio when using Pulseaudio's TCP network audio capability...

/etc/xrdp/pulse/default.pa file, which instructs PA to load our pulse config file instead of the default per-user config /etc/pulse/default.pa when X11rdp session  starts.
when pulseaudio loads our sink, it is relying on the DISPLAY env var in order to send the audio data
to the right xrdp-chansrv socket matching the current session (aka channel server, which wraps the
audio data into the RDPSND channel and send it back to client).

When using Pulseaudio TCP network audio the "user" session ennvironment contains PULSE_SERVER=x.x.x.x  where x.x.x.x is the remote Pulseaudio Server that  audio/sound is supposed to be sent to... which is NOT the same Pulseaudio server running on the User's local session/machine!
This is often used with containers (lxc, lxd/docker etc).
EVEN without using a "container" you could test this by setting a User Session environment variable  PULSE_SERVER=x.x.x.x to point to a different machine or KVM VM.
in that different machine or KVM VM (virtualbox etc)... the /etc/pulse/default.pa file will need the following statement added:
load-module module-native-protocol-tcp auth-ip-acl=<IP_ADDRESS>;<IP_ADDRESS>/24 auth-anonymous=1
where:
module-native-protocol-tcp loads Pulseaudio network module
acl says accept audio connections from localhost or 192.168.1.x network devices and auth-anonymous says accept from anyone on those 2 network/subnets.
So with xrdp's /etc/xrdp/pulse/default.pa the xrdp SINK/SOURCE get loaded BUT I don't think they "know" to use & send audio to the remote Pulseaudio server ID's by the PULSE_SERVER= environment variable..??
Brian

Pop


new version vscode display error data on special conditions

hey,guys. i am an old vscode user from China, a few days ago when i updated my vscode to version 1.15.1, i encountered some problems. i saw different contents in vscode vs other text editors(like vim and sublime3) while those editors show correct, so i wonder is it my fault or something goes wrong with vscode. following is details.
the plain txt is there:
issue.txt

my computer is Windows 7 64 bit(the same on ArchLinux)
here is vscode infos:
version: 1.15.1
commit: 41abd21afdf7424c89319ee7cb0445cc6f376959
date: 2017-08-16T18:07:2S.676Z
Shell: 1.6.6
render: 56.0.2924.87
Node: 7.4.0
arch: x64

@rebornix any ideas based on what it says?


imp: remove --no-redis cli argument

The original idea was to have a dual database implementation, one pure
python implementation in-memory for testing and developing purposes and
one full featured redis database in production.
It proves cumbersome to maintain an in-memory database and the
implementation was removed. The recent introduction of unittests showed
it is easy to mock the various models.
Many contributers now share the idea that running bin without a redis
database is a bad idea.

@fusetim ça faisait longtemps qu'on en parlait :p


React v0.14

Hello maintainers! I have good news for you! In the general case, this library seems to just work without any changes.
 If that sounds weird it's because it is and I'm not 100% on what's up. Nor am I sure you should worry about it because it seems like an edge case in React that may be solved by release. Just didn't want you to be blindsided by this.
Thanks for the lib!

Thanks for the notice. Really appreciate =)

:+1:


add function to update z value

It's added to v0.11 with teh xy-duplicate handling: you insert point at same xy-location and ensure that "Latest" for xy-duplicates


Add formula for Cassandra 1.2.19

It was removed from the homebrew/homebrew-versions tap in https://github.com/Homebrew/homebrew-versions/commit/e102cc897ae1330b021c10f128197546b29ac543

@sgerrand 👀

LGTM. 👍


Subsetting an ontology

Is there a way to subset an ontology by namespace. For example  for the gene ontology (GO) if I'm only interested in the biological process namespace. Is there a way of creating a subontology that only has biological process terms?

This will get you all a subgraph with descendants of GO:0008150 (biological process):
from nxontology.imports import read_gene_ontology
from nxontology import NXOntology
go_nxo = read_gene_ontology(release="2021-02-01")
bp = go_nxo.node_info("GO:0008150")  # biological process
go_bp = NXOntology(go_nxo.graph.subgraph(bp.descendants))
print(go_nxo.n_nodes, go_bp.n_nodes)

Reduces from 44085 nodes to 28748.
But I noticed when doing this that node metadata is missing from go_nxo, so the method I wanted to use, which was filter for namespace, is not available. Will look into this.

But I noticed when doing this that node metadata is missing from go_nxo

will be fixed by https://github.com/related-sciences/nxontology/pull/18

Here's the second method I wanted to show you that uses the namespace node attribute rather than descendants of the biological process root node:
bp_nodes = {node for node, data in go_nxo.graph.nodes(data=True) if data["namespace"] == "biological_process"}
go_bp = NXOntology(go_nxo.graph.subgraph(bp_nodes))

They are the same because the each GO domain/namespace is disconnected from the other domains. If there were cross-domain connections, then only this namespace method would work.

Thanks! I was actually thinking of the first method but I wasn't sure that it would work if I wanted to retrieve ancestors of terms from the subset graph. For some reason I thought that ancestors that are derived from terms in the subgraph may still contain  those that are derived from other relations such as 'part of' and those that are present in MF and CC  given that the ontology object is created from a multi-graph. The main reason why I'm going through nxontology is that I wanted to add the GO Universal semantic similarity calculation method that is described in this paper https://www.researchgate.net/publication/225187134_A_Topology-Based_Metric_for_Measuring_Term_Similarity_in_the_Gene_Ontology. It uses a different method for calculating IC than the Resnik method which is prominent in the methods that you've already implemented.


VRTK_Interact_Grab NullReferenceException

Using the interact_grab script on the controller on a default steamvr 1.1.0 camera rig will yield two  nullreferenceexceptions.
NullReferenceException: Object reference not set to an instance of an object
VRTK_InteractGrab.Start () (at Assets/SteamVR_Unity_Toolkit/Scripts/VRTK_InteractGrab.cs:95)
NullReferenceException: Object reference not set to an instance of an object
VRTK_InteractGrab.Update () (at Assets/SteamVR_Unity_Toolkit/Scripts/VRTK_InteractGrab.cs:395)

which is
controllerAttachPoint = transform.GetChild(0).Find("tip").GetChild(0).GetComponent<Rigidbody>();
These is quite logical when looking at the order. SteamVR initializes the models lazily so the "tip" will only be created after some frames when the model is loaded. The lookup for the attachpoint should therefore also be delayed. A better way of doing it is probably to not do it once but wrap it into a "getAttachPoint" method that does the lookup ondemand if it is not done already or got reset (think of exchanging the controller model during play).
I was curious why it works in the examples and as it seems the model hierarchy was baked into the scene. That explains the difference but will only work with the example setup and not with the pure steamvr prefab.

The reason the camera rig prefab is different is because the steam vr plugin comes with 2. The one in the prefabs folder (the one you're referring to) and the one in the test_throw example scene with the elements there in the editor (as explained in the readme of this repo).
The camera rig prefab included in this repo is the one from the test throw scene. I need to understand why valve included two in their repo before feeling comfortable removing the prefab from this repo.
In short, your issue is being caused because you're not using the prefab from this repo

Thanks for the super quick response. That let's me continue to experiment :-) I have the feeling using a prefab from some test folder is probably not the way to go but indeed it would be great to understand how they envision it. I kind of suspect it was simply a shortcut for the examples to have them synchronous because they did not want to implement the delayed attachment handler I proposed above. This cannot work if the model is exchanges at runtime.

I'd love to understand some of their choices! :)
Some of their code is great and some is just broken, I wish they were more vocal about their work.
Even their last release (1.0.9) broke builds, not sure how basic checks got past them :/

Oh was it the SteamVR release that broke the build? Is it controller related?

@tgilmo5 If you're referring to your issue when you build, it's not related to this ticket, check out the FAQ link I sent, it will solve your problem

There's a PR open in regards to this issue.
Discussion continues over there!
https://github.com/thestonefox/SteamVR_Unity_Toolkit/pull/135

Hi,
I am getting the same error because I attached a child object to my Controller. Without wanting to mess with your code - I believe this should be made a bit more stable, not relying exact on the child positions.
Check the image - this setup will lead to the error
https://i.imgur.com/pcwf1kt.png

@spaggi there is a PR open to deal with this issue

Perfect, thanks for letting me know!

Fixed with commit https://github.com/thestonefox/SteamVR_Unity_Toolkit/commit/aa3dcf0d90e97dd3f97b0a1de175278e0f847954


Add OG tags to index.html

Fixes #112.

@Khronoswebmaster would it be better for us to copy the image (https://www.khronos.org/assets/uploads/apis/2019-gltf-ecosystem_1_17.jpg) into this repository? Or maybe there's a better image for this? I'm guessing it's better to host the image here, but it seems like this image changes often, too.
FYI the glTF landing page has some similar issues when posted to social media sites:

The glTF image gets updated fairly regularly (17 in the name is the version number). If you are open to updating it on GitHub, we can include you in update notifications. Options on how to best handle this are welcome.
Seems the template didn't get proper social media treatment when we moved to the dark side... is this style you are looking for?


Support more OTLP outputs by introducing cumulativeToDelta conversion

Description
There are different vendors like datadog or dynatrace which works best with delta aggregation temporality for monotonic sums, histograms, and exponential histograms. They strongly to recommend to directly emit the metrics using the delta aggregation temporality (see datadog hints), and if not possible, the cumulativetodeltaprocessor should be used in the metrics processing otel-collector. The challenge here, the processor is stateful and requires that the clients are sending to the same instance always.
As this topic is common for several vendors and popular when using prometheus based metrics, supporting the conversion in the kyma metrics-gateway will be of benefit.
Goal

Have an option in a MetricPipeline to enable the conversion, probably as part of the output configuration
The option will assure that the mentioned processor gets active for that specific pipeline
The option will enable session stickiness for the ingest endpoint

Criterias

New API element to enable the conversion per pipeline
Enabling the API will activate the conversion only for the pipeline and activates the session stickyness overall
Documentation outlines new feature (feature page + CRD spec) and outlines in the limitations the stickyness problem
Integration tests assuring working functionality with new test framework
Memory footprint is observed for setup with and without activated processor to understand the impact

Added cumulativetodelta processor into the otel collector configuration, added flag new flag for metricpipelines to enable metric conversion


generate upcoming changelog

This is a work-in-progress PR to generate the upcoming changelog.
The only problem that I couldn't solve nicely is that changed.d requires all dlang repos in the usual ../phobos, ../installer, ... way - this means we would have to clone all these repos :/ (at least tools and installer aren't expected in the current dlang.org setup)
This PR depends on:
https://github.com/dlang/phobos/pull/4228
https://github.com/dlang/tools/pull/186
Ping @CyberShadow

Closing this as it is superseded by #1549


Add documentation

Better documentation should be added via a docs folder.
The example folder can then be removed.

Implemented with 2a88f0279defb348d0105ecb719b2215632e787d
Example folder also removed: a83c2565dd4ea0e121465d0ecfc66927e76f7fe1


Hybrid iOS - Push notification for failed scanning opens OD page with error instead of ND

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 9.0.49-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers<EMAIL_ADDRESS>Issue reported by: Applause - Internal Team
Action Performed:

Launch hybrid app
Switch to ND
Go to workspace chat
Submit a scan expense with a receipt that will fail the scanning
Wait for the push notification from Expensify regarding the receipt
Open the push notification.

Expected Result:
The push notification will open the transaction thread on hybrid ND because the expense is created on ND
Actual Result:
The push notification opens home page on hybrid OD with the error "We were unable to open that violation, please fix it from your homepage"
On ND app (standalone app), the push notification opens LHN instead
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[ ] Android: mWeb Chrome
[x] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/user-attachments/assets/dbda1b64-ed9a-45ce-9544-87a13eb6ebff
View all open jobs on GitHub

@kadiealexander  FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

I don't think this is an error worth investing massive amounts into fixing. If you disagree, please reopen!


Fully support twitch helix api

Need HTTP handler + wrapping models

Current routes:

means implemented

means not implemented

+ post commercial
- get extension_analytics
- get game_analytics
+ get bits_board
- get cheermotes
- get extension_transactions
+ post create_reward
+ patch update_reward
+ delete custom_reward
+ get reward_redemptions
+ patch reward_redemption_status
+ post create_clip
+ get clips
- post entitlements_upload
- get entitlements
- get giftcode_status
- post redeem_code
- get top_games
- get games
- get hype_train
- post automod_check
- get channel_ban_unban_events
- get channel_bans
- get channel_moderators
- get channel_mod_events
- get search_categories
- get search_channels
- get stream_key
- post stream_marker
- get stream_markers
+ get channels
- patch channel
- get channel_subscriptions
- get stream_tags
- get channel_tags
- put replace_channel_tags
- post follow_channel
- delete unfollow_channel
- get users
- get user_follows
- get channel_extensions
- get user_active_extensions
- put user_extensions
- get videos
- get webhook_subs

Current routes:

means implemented

means not implemented

+ post commercial
- get extension_analytics
- get game_analytics
+ get bits_board
- get cheermotes
- get extension_transactions
+ post create_reward
+ patch update_reward
+ delete custom_reward
+ get reward_redemptions
+ patch reward_redemption_status
+ post create_clip
+ get clips
- post entitlements_upload
- get entitlements
- get giftcode_status
- post redeem_code
- get top_games
- get games
- get hype_train
- post automod_check
- get channel_ban_unban_events
- get channel_bans
- get channel_moderators
- get channel_mod_events
- get search_categories
- get search_channels
- get stream_key
- post stream_marker
- get stream_markers
+ get channels
- patch channel
- get channel_subscriptions
- get stream_tags
- get channel_tags
- put replace_channel_tags
- post follow_channel
- delete unfollow_channel
- get users
- get user_follows
- get channel_extensions
- get user_active_extensions
- put user_extensions
- get videos
- get webhook_subs

As of now, the api is fully supported with the exception of analytics, transactions, and gift related endpoints