Improvements to nullable references.

Motivation
A common pattern in OpenAPI schemas I have seen uses oneOf with references like the following:
oneOf:
  - $ref: '#/components/schemas/Thing'
  - type: 'null'

Prior to this patch, this returns a enum for the possible variants of this schema, but an Optional<T> would be more expected and ergonomic.
Modifications
In addition to the basic support for explicit nulls (#557, included in this PR too), I've introduced a notion of an "optional root", which is a schema / type usage in which the optionality occurs at the top level and not through some indirection of references. This undoes the prior behavior of propagating optionality all the way to the top, instead adding it only where needed.
This new model of optionality relies on relies on enhancements to TypeMatcher isOptional to look for explicit nulls and to support following references and dealing with potentially recursive schemas.
Finally, TypesFileTranslator detects the {oneOf: [{type: 'null'}, ...]} pattern and returns a Swift Optional<...remaining cases...> instead.
Result
The added testOneOfRefOrNull test shows the new behavior in action.
This would be a breaking change for anyone using this common pattern. A few places where enums were needed will need to be migrated to use optionals instead of the generated enums. It's a mechanical and straightforward migration, resulting in less and cleaner code.
Test Plan
Several new unit tests were added. See diff.

Hi @brandonbloom,
thank for the PR! We might just need to split this up a bit before merging.
First thing - this is a breaking change, and if merged as-is, would require us to tag a 2.0. That's not really desirable at this stage, so I wonder what you suggest we do here.
Can you talk more about the reasoning of why you think the generated code needs to change? We've avoided special-casing specific patterns so far, as they don't evolve very well when a new case is added. Can you provide more details of why we should diverge from that approach here?

We might just need to split this up a bit before merging.

Understood. I broke up the steps as separate commits for that reason.

Can you talk more about the reasoning of why you think the generated code needs to change?

I found the behavior that exists prior to this change very confusing. The generated types don't match the schemas that they are generated from as it pertains to optionality. Instead, the optionality is bubbled up to the top level, and baked into the usage sites. This means that if you use a typealias for something that is expected to be T?, you actually just get a T.
However, the main justification is the {oneOf: [{type: 'null'}, ...]} pattern, which is used widely in a pair of OpenAPI specs I'm working with. In one case, it works way because the spec it itself generated from bespoke schema system which produces a referenceable schema for each named type and then uses the oneOf-null pattern everywhere. In the other case, the upstream schema used to use nullable: true keyword, but that's deprecated now in OpenAPI 3.1 and hence the move to the oneOf:null/... pattern.

We've avoided special-casing specific patterns so far, as they don't evolve very well when a new case is added.  Can you provide more details of why we should diverge from that approach here?

That makes sense. Only null is handled specially in this change. I preserved the behavior that a single-case enum remains if null is not involved. I'm sensitive to the evolution argument, but I think that there are enough ergonomics for Optionals in Swift that it's worthwhile. With this change, my usage code has eliminated numerous case-lets and switches and other heavy syntax is favor of much lighter if-lets and ?. operators.

would require us to tag a 2.0. That's not really desirable at this stage, so I wonder what you suggest we do here.

There are two separate breaking changes. The "optional root" behavior and then the subsequent rule for simplifying the oneOf:null/... pattern. The former supports the latter, but the latter could be a setting or preference quite easily, if that's appropriate. Not sure if/how the former can be mitigated.

This reminds me a lot of this comment (and the preceeding/following one). Are we talking about a different situation in this case?

If I recall correctly, one reason I want to avoid removing the .null() schema from the oneOf (and similar) is because it is lossy so OpenAPIKit no longer knows where to put the "nullability" when re-encoding (it could be a part of any of the subschemas).

Good call, I forgot about that other issue. So a null case already gets propagated to the parent anyOf/allOf today? If so, does that mean we just need to filter out the null case in the generator and the rest should work?

does that mean we just need to filter out the null case in the generator and the rest should work?

Correct; OpenAPIKit currently sets any/one/all-of schemas as nullable if any of the subschemas are nullable.
Also, I keep waking up more as the morning goes on and now I'm thinking there is no current bug with the way OpenAPIKit handles oneOf (I speculated there was in my previous comment's EDIT).

Ok great - @brandonbloom would you be interested in opening a PR for the filtering of nulls, which should hopefully improve how we handle these cases? It's my understanding we completely skip such anyOf/allOfs today, so they don't get generated. If we filter the null out, it should start getting generated as an optional anyOf/allOf, which I what I think we want.
I see that https://github.com/apple/swift-openapi-generator/pull/557 is open so I assume some work is being done to address this, but is there anything I can do to work around this issue?

Hi @jmg-duarte - as a workaround, you could remove the anyOf that wraps your schema and a null. If the property isn't included in the object's required array, it'll be generated as optional anyway, so the extra wrapping in anyOf that also includes a null is not necessary, and in fact will make the generated code uglier in Swift.

Can this be merged given it is now approved? It would help us avoid using scattered workarounds to make this work 🙏 thanks.

Hi @jasondiab, this PR is not approved by any of the maintainers, and still needs work. If landed as-is, it'd be a major breaking change.

https://github.com/simibac/ConfettiSwiftUI.git

Could this become an opt in feature? It is breaking, but it (along with #557) are causing a lot of churn in having to hand tweak OpenAPI being ingested by the parser. A required opt in would prevent it from breaking semantic versioning.

If I understand the above conversation fully then this PR might not represent the easiest solution which would hopefully simply involve filtering out .null() schemas before generating code. Food for thought if someone has time to try that.


Don't use hostname for CN in CSR

ziti/enroll/enroll.go uses hostname for CN in CSR used during enrollment. Hostnames can contain underscores. This is a problem because the golang asn1 parser does not support underscores in printablestring fields of asn1 structures (like CSRs). Upshot is that attempts to enroll from hosts that have a name containing an underscore will fail.

@rentallect any thoughts on what the right thing to do is here? Strip the underscores out? Use the identity id? Use a UUID?

Someone's reading old issues! This is kind of a problem since there's really 'no good way'. Maybe base64 encoding the CN is the only good answer here? I'm surprised this hasn't been an issue before... Makes me want to make a hostname with underscores just to try it.
I'm inclined to close it as a 'known issue' though...

Stripping the (potential) underscores out of the hostname seems like an expedient way out of this (admittedly limited) edge-case predicament.  Given that it has been almost 3 years since this issue was encountered, and never re-encountered since then, the @dovholuknf suggestion of closing as a known issue is fine too.

I just worry there are people out there that have done:

server1
server_1

Those people will have a 'bad time' and it'll be a hard bug to track down and other silly things like that. I'm for "closed as known issue" :) or base64'ing a hostname containing an underscore (and maybe padding to avoid equals signs? if base 64'ed)
But as @rentallect says, since this is 3 yrs old, i vote "just close it" for now

According to @andrewpmartinez CN isn't used for validation, SANs are used instead. Also, these are all client certs, so we're not checking those anyway. I'm going to switch it to use the identity id, which only use characters that are allowed by asn1 printablestrings.

using id makes it consistent with other SDKs


Occasionally unable to remove services

We have occasionally bumped into the problem of not being able to remove services.
After a service remove, the service state is stuck in deleting. In some of the cases executing remove again will successfully remove the service. In other nothing happens and the state remains in deleting. It has taken hours for some of the services to be removed once stuck in that state.

`
juhazi:kontena-localgyver/ (master) $ kontena service ls                                                                                [17:16:19]
NAME                                                         INSTANCES  STATEFUL STATE      EXPOSED PORTS
⊝ localgyver-registry                                        1 / 1      yes      running
⊝ localgyver-redis-sentinel-monitor                          5 / 5      yes      running
⊝ localgyver-redis-sentinel-node                             5 / 5      yes      running
⊝ localgyver-redis-sentinel-loadbalancer                     1 / 1      no       running
⊝ localgyver-postgres                                        0 / 1      yes      deleting   <IP_ADDRESS>:15432->5432/tcp
⊝ localgyver-loadbalancer                                    1 / 1      no       running    <IP_ADDRESS>:80->80/tcp, <IP_ADDRESS>:443->443/tcp, <IP_ADDRESS>:12222->12222/tcp
juhazi:kontena-localgyver/ (master) $ kontena service show localgyver-postgres                                                                                [17:16:24]
localgyver/localgyver-postgres:
status: deleting
image: postgres:9.5
revision: 1
stateful: yes
scaling: 1
strategy: ha
deploy_opts:
min_health: 0.8
wait_for_port: 5432
dns: localgyver-postgres.localgyver.kontena.local
net: bridge
ports:
- 15432:5432/tcp
volumes:
- localgyver-postgres:/var/lib/postgresql
instances:
localgyver-postgres-1:
rev: 2016-09-01 14:07:17 UTC
service_rev: 1
node: moby
dns: localgyver-postgres-1.localgyver.kontena.local
ip: <IP_ADDRESS>
public ip: <IP_ADDRESS>
status: dead
juhazi:kontena-localgyver/ (master) $ kontena container show localgyver-postgres-1                                                                                [17:16:47]
ERROR: No such sub-command 'show'
See: 'kontena container --help'
juhazi:kontena-localgyver/ (master) $ kontena container inspect localgyver-postgres-1                                                                                [17:17:02]
{"code":500,"message":"Docker::Error::NotFoundError: No such container: 4efac48e99a7764d87f90b8a724c9317a721ee1270708b7901afdc70109be013\n","backtrace":["/usr/lib/ruby/gems/2.3.0/gems/docker-api-1.26.2/lib/docker/connection.rb:46:in rescue in request'","/usr/lib/ruby/gems/2.3.0/gems/docker-api-1.26.2/lib/docker/connection.rb:38:in request'","/usr/lib/ruby/gems/2.3.0/gems/docker-api-1.26.2/lib/docker/connection.rb:65:in block (2 levels) in \u003cclass:Connection\u003e'","/usr/lib/ruby/gems/2.3.0/gems/docker-api-1.26.2/lib/docker/container.rb:284:in get'","/app/lib/kontena/rpc/docker_container_api.rb:131:in inspect'","/app/lib/kontena/rpc_server.rb:40:in handle_request'","/app/lib/kontena/websocket_client.rb:108:in block in on_message'","/usr/lib/ruby/gems/2.3.0/gems/eventmachine-<IP_ADDRESS>/lib/eventmachine.rb:1067:in block in spawn_threadpool'"]}
juhazi:kontena-localgyver/ (master) $ kontena service stop localgyver-postgres                                                                                [17:17:14]
juhazi:kontena-localgyver/ (master) $ kontena service ls                                                                                [17:17:32]
NAME                                                         INSTANCES  STATEFUL STATE      EXPOSED PORTS
⊝ localgyver-registry                                        1 / 1      yes      running
⊝ localgyver-redis-sentinel-monitor                          5 / 5      yes      running
⊝ localgyver-redis-sentinel-node                             5 / 5      yes      running
⊝ localgyver-redis-sentinel-loadbalancer                     1 / 1      no       running
⊝ localgyver-postgres                                        0 / 1      yes      stopped    <IP_ADDRESS>:15432->5432/tcp
⊝ localgyver-loadbalancer                                    1 / 1      no       running    <IP_ADDRESS>:80->80/tcp, <IP_ADDRESS>:443->443/tcp, <IP_ADDRESS>:12222->12222/tcp
juhazi:kontena-localgyver/ (master) $ kontena service show localgyver-postgres                                                                                [17:17:38]
localgyver/localgyver-postgres:
status: stopped
image: postgres:9.5
revision: 1
stateful: yes
scaling: 1
strategy: ha
deploy_opts:
min_health: 0.8
wait_for_port: 5432
dns: localgyver-postgres.localgyver.kontena.local
net: bridge
ports:
- 15432:5432/tcp
volumes:
- localgyver-postgres:/var/lib/postgresql
instances:
localgyver-postgres-1:
rev: 2016-09-01 14:07:17 UTC
service_rev: 1
node: moby
dns: localgyver-postgres-1.localgyver.kontena.local
ip: <IP_ADDRESS>
public ip: <IP_ADDRESS>
status: dead
juhazi:kontena-localgyver/ (master) $ kontena container inspect localgyver-postgres-1                                                                                [17:17:49]
{"code":500,"message":"Docker::Error::NotFoundError: No such container: 4efac48e99a7764d87f90b8a724c9317a721ee1270708b7901afdc70109be013\n","backtrace":["/usr/lib/ruby/gems/2.3.0/gems/docker-api-1.26.2/lib/docker/connection.rb:46:in rescue in request'","/usr/lib/ruby/gems/2.3.0/gems/docker-api-1.26.2/lib/docker/connection.rb:38:in request'","/usr/lib/ruby/gems/2.3.0/gems/docker-api-1.26.2/lib/docker/connection.rb:65:in block (2 levels) in \u003cclass:Connection\u003e'","/usr/lib/ruby/gems/2.3.0/gems/docker-api-1.26.2/lib/docker/container.rb:284:in get'","/app/lib/kontena/rpc/docker_container_api.rb:131:in inspect'","/app/lib/kontena/rpc_server.rb:40:in handle_request'","/app/lib/kontena/websocket_client.rb:108:in block in on_message'","/usr/lib/ruby/gems/2.3.0/gems/eventmachine-<IP_ADDRESS>/lib/eventmachine.rb:1067:in block in spawn_threadpool'"]}
juhazi:kontena-localgyver/ (master) $ kontena service rm localgyver-postgres                                                                                [17:17:56]
Destructive command. To proceed, type "localgyver-postgres" or re-run this command with --force option.

^C%                                                                                juhazi:kontena-localgyver/ (master) $ kontena service rm --force localgyver-postgres                                                                                [17:18:30]
juhazi:kontena-localgyver/ (master) $ kontena service show localgyver-postgres                                                                                [17:18:37]
localgyver/localgyver-postgres:
status: deleting
image: postgres:9.5
revision: 1
stateful: yes
scaling: 1
strategy: ha
deploy_opts:
min_health: 0.8
wait_for_port: 5432
dns: localgyver-postgres.localgyver.kontena.local
net: bridge
ports:
- 15432:5432/tcp
volumes:
- localgyver-postgres:/var/lib/postgresql
instances:
localgyver-postgres-1:
rev: 2016-09-01 14:07:17 UTC
service_rev: 1
node: moby
dns: localgyver-postgres-1.localgyver.kontena.local
ip: <IP_ADDRESS>
public ip: <IP_ADDRESS>
status: dead
juhazi:kontena-localgyver/ (master) $ kontena container inspect localgyver-postgres-1                                                                                [17:18:42]
{"code":500,"message":"Docker::Error::NotFoundError: No such container: 4efac48e99a7764d87f90b8a724c9317a721ee1270708b7901afdc70109be013\n","backtrace":["/usr/lib/ruby/gems/2.3.0/gems/docker-api-1.26.2/lib/docker/connection.rb:46:in rescue in request'","/usr/lib/ruby/gems/2.3.0/gems/docker-api-1.26.2/lib/docker/connection.rb:38:in request'","/usr/lib/ruby/gems/2.3.0/gems/docker-api-1.26.2/lib/docker/connection.rb:65:in block (2 levels) in \u003cclass:Connection\u003e'","/usr/lib/ruby/gems/2.3.0/gems/docker-api-1.26.2/lib/docker/container.rb:284:in get'","/app/lib/kontena/rpc/docker_container_api.rb:131:in inspect'","/app/lib/kontena/rpc_server.rb:40:in handle_request'","/app/lib/kontena/websocket_client.rb:108:in block in on_message'","/usr/lib/ruby/gems/2.3.0/gems/eventmachine-<IP_ADDRESS>/lib/eventmachine.rb:1067:in block in spawn_threadpool'"]}
juhazi:kontena-localgyver/ (master) $

`

I'm still having this same issue with 0.15.5

@aleksijohansson are you running kontena locally (for example with docker for mac)?

@jakolehm I've been testing with kontena vagrant based local master and nodes and also running master and a node locally on the host machine (macOS with Docker for Mac) with docker-compose. I've encountered this issue with both cases.

It seems that the running instance of the service is killed and removed, but the service stays in deleting state.

Just got this in AWS: service was crashing constantly and 1/3 was left deleting even if I
a) stopped and deleted again
b) restarted all agents
c) rebooted all nodes
what helped: I deleted the service where the service was trying to connect (there was no linking, not sure how this would make any difference)

...okaaaay: now the service is not listed in kontena service ls, but it's still running and outputting to kontena grid logs

Can confirm this behavior with kontena app rm --force as well. Regarding @matti's comment on linking, if the services are linked it is impossible to delete them via CLI. Since the containers aren't running on the nodes (despite being listed as 'deleting'), I usually docker exec -it kontena-server-mongo /bin/bash in order to manually delete the records from mongoDB. This seems to have no adverse side effects on the next deploy.

So to clarify: if a service is crashing on the start it's a) flooding grid logs with the exceptions b) stuck in deleting with 1/3 or 2/3 no matter how hard you try to stop/delete until something magical happens and kontena/docker is able to stop this loop.

okay, seems like rebooting all nodes cleared the service now.

if a service is crashing on the start it's a) flooding grid logs with the exceptions b) stuck in deleting with 1/3 or 2/3 no matter how hard you try to stop/delete until something magical happens and kontena/docker is able to stop this loop.

This is exactly how it happened for me.

Yep, I can reproduce this 100%

So to reproduce this one would need a container image that just crashes on start (Docker keeps restarting) and now Kontena is not able to remove the service?

Deploying this (3.2 causes infinite restarting) https://github.com/matti/kontena-mongodb32-bomb works as a 100% way to get this bug reproduced [as shown live to jnummelin a few minutes ago]

yep, I have couple of ideas that might cause this. Docker might not emit the events agent is expecting when removing restarting container. Or the container deletion might need some extra force on Docker API to remove restarting container. Or some combination of these. :)
Will reproduce locally and debug.

Some explanation why this happens: https://github.com/docker/docker/issues/26372

It appears #1196 fixes this if you stop the service that is currently deploying before performing a k app rm --force or similar.

An update: kontena app rm --force without performing kontena app stop is far more volatile. For some reason sending the stop signal then removing works, yet force removing without stopping doesn't. However it seem that this should be convention anyways to prevent any sort of corruption.

Saw this with my Azure setup yesterday. kontena app stop + kontena app rm --force worked every time, without stop did not.

Happened for me today with Kontena 1.0.4. Seems to affect every service that I try to remove. Stopping works and I see that the containers are not running, but deleting is stuck indefinitely, and the services are left in 'deleting' state accroding to kontena service ls.


Dark theme enabled

fixes issue #130

When I click on View all Tags in Home page. The text All Tags is not visible. Make it white in color.

Answer Question Page is not looking very good. (Go to Home, click on pencil icon for any question you will see this). Same goes for text inside textbox. Make text color white.

@Nikhil7174 just saw that there is not dark mode toggle button in that view all tags page.
Check other pages too, dark mode button should be there in all pages.

added toggle switch to all pages which contains top-icons bar

LGTM @Nikhil7174 :heart:. I will merge it after one more review.. In the meantime you are free to take other issues.


Add CRIImageService.RemoveImage()

PR adds new CRIImageService.RemoveImage() and moves out functionality from GRPCCRIImageService.RemoveImage()

@dmcgowan @cpuguy83 this would be helpful to have for image pull per runtime class changes as well (kep 4216)

All tests are passing now!

cc @cpuguy83  could you please take a look when you have some time please?


bagit upload: investigate non-existent bags after upload

sometimes bags are not available for the archive service to collect... logging has been raised to allow better investigation

not reproducable


one-sided time stencils using space order instead of time order?

Hi!  Hopefully this one isn't too tricky.  On current master 7da13ecbee.
Cheers,
Tim
In [1]: import devito

In [2]: grid = devito.Grid(shape=(10,10,10))

In [3]: u = devito.TimeFunction(name='u', grid=grid, space_order=8, time_order=2)

In [4]: u.dt
Out[4]: -0.5*u(t - dt, x, y, z)/dt + 0.5*u(t + dt, x, y, z)/dt

In [5]: u.dtl
Out[5]: 0.45*u(t, x, y, z)/dt - 0.00357142857*u(t - 5*dt, x, y, z)/dt + 0.0357142857*u(t - 4*dt, x, y, z)/dt - 0.166666667*u(t - 3*dt, x, y, z)/dt + 0.5*u(t - 2*dt, x, y, z)/dt - 1.25*u(t - dt, x, y, z)/dt + 0.5*u(t + dt, x, y, z)/dt - 0.0714285714*u(t + 2*dt, x, y, z)/dt + 0.00595238095*u(t + 3*dt, x, y, z)/dt

This generates OOB access by the time stencil in the 'dtl' (and 'dtr' case), which later manifests as a segfault.  The size of these seems to be determined by the space order rather than the time order?

@mloubout ?

Fixed in #711
Upwind/downwind not implemented yet though, only shifted by 1-2 pioints left or right centered FD, if have a name idea for upwind/downwind I'll add it to the PR too

fixed, closing


Yatin: Watch kumarprateek.blogspot.com

Yatin requests the watch of the watch_keyword kumarprateek\.blogspot\.com. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

kumarprateek\.blogspot\.com has been seen in 3 true positives, 0 false positives, and 0 NAAs.

kumarprateek\.blogspot\.com has been seen in 3 true positives, 0 false positives, and 0 NAAs.

Approved by Spevacus in Charcoal HQ

Approved by Spevacus in Charcoal HQ


Update Colors Docs

Summary

Updated Colors docs to use CSF stories with separate categories.
Added samples/previews for all General/Base tokens.
Moved Themes to their own file/section for future use. Noted work in progress.
Fixed a couple typos in color tokens.
Some changes to colors vars file caused by auto-formatter can be ignored. Using Prettier plugin here.

:tada: This PR is included in version 1.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Add plot locations for teros and other applicable TEMPEST sensors in L1 data

Add grid cells to teros and other applicable sensors in TEMPEST for spatial identification

Do we want to add this to the L1 data Itself? It'll be a column that (1) is only used for TEMPEST and (2) is very redundant (because TEROS sensors are always in the same place).
What about including the location data in the L1 metadata, or telling users where they can find it?

I think we should include it as a file in the L1 and L2 metadata, and make sure it can be joined easily with any new columns we add via #124


One way video - SIP doorbell

I successfully launched integration with my intercom. I tried using Video over SIP and everything works fine until I want to run this feature on a device without a camera. Is it possible to use this function only to receive video? The intercom only receives voice, so sending video is not necessary. I don't want to use the camera entity with HA because it scales poorly and have freeze frame at the beginning.

I successfully launched integration with my intercom. I tried using Video over SIP and everything works fine until I want to run this feature on a device without a camera. Is it possible to use this function only to receive video? The intercom only receives voice, so sending video is not necessary. I don't want to use the camera entity with HA because it scales poorly and have freeze frame at the beginning.

Hi - I am struggling with Doorbir config - would you mind sharing your config (hassio and doorbird)?

I have this working using video: false. I still receive the feed from the doorbell.


[token-CLI] Add command_initialize_group to Token Cli

I have added the necessary clap commands and functions to drive token_group_initialize_with_rent_transfer() from the Token CLI.  I am running into error 0xc InvalidInstruction and cannot find what is causing this. Is there anything obvious that I cannot see? #5937
Thank you!
Edit: To recreate this error, run
spl-token --program-id TokenzQdBNbLqP5VEhdkAS6EPFLC1PHnBqCXEpPxuEb create-token --enable-group

then I initialize the group using the mint address created
spl-token initialize-group A6iv673L7PEZDxYDwQbMZsgmS5bGzExavADQSAcKA3Tt 3

@buffalojoec please let me know what you think!

I am running into error 0xc InvalidInstruction and cannot find what is causing this. Is there anything obvious that I cannot see?

Are you running this test with Token2022's feature flag enabled for token-group?

Yes I believe it is enabled. And the error comes before the token-group processor checks if it is enabled.

Yes I believe it is enabled. And the error comes before the token-group processor checks if it is enabled.

And you're using the CLI from the repo? target/debug/spl-token?

Yes, and I can see the new clap subcommand I added.

The subcommand is just on the CLI side. We'll have to configure the tests to use Token2022's program .so file with the features enabled.
To test it manually, you can do:
cargo build-sbf --manifest-path token/program-2022/Cargo.toml --features token-group zk-ops
solana-test-validator --bpf-program TokenzQdBNbLqP5VEhdkAS6EPFLC1PHnBqCXEpPxuEb target/deploy/spl_token_2022.so

And then we'll just have to configure that same BPF program override in the test validator config of the tests. This might be outside the scope of this PR though.
If you manage to crack it, great! If not, we can wait on this and rebase after I add that support.

I had a fundamental misunderstanding lol. The deployed devnet token-22 program doesn't have the token-group enabled. I followed the steps for testing the cli and enabled it correctly. I also wrote a test that simply creates the mint and initializes it. The test passes. What else should I add to the test? Maybe check the max_size? Since the GroupPointer struct does not have a max_size field, would I need to read it directly from the raw data?

Actually I think this can be done with the spl-token-group-interface! Would it make sense to roll command_update_max_size into this pr? For example it seems the metadata test includes multiple commands.

Actually I think this can be done with the spl-token-group-interface! Would it make sense to roll command_update_max_size into this pr? For example it seems the metadata test includes multiple commands.

Maybe just try fetching the mint and unpacking TokenGroup and checking the values for things like update authority/mint?

Okay I believe this is ready to go!


Weird simulation behavior in mjx tutorial

Hi,  I ran the tutorial in mjx on Colab without any modification.
When I tried to visualize the Humanoid Env (corresponding Visualize a Rollout block in tutorial), I found that the robot showed strange behavior.
Here is a video, illustrating my question:
https://github.com/google-deepmind/mujoco/assets/37854077/f9c2e169-dbb6-436a-a348-4e925fe7c1f5

OK. I've got it. Thanks again for this exceptional upgrade!


Gon attributes are not being cleared between rspec controller tests

In an Rspec controller test:
context 'value is set' do
  # some condition required to make gon variable available

  it 'should return value' do
    get :new
    expect(controller.gon.foo).to eq 'bar'
  end
end

it 'should not return value' do
  # some condition required to make gon variable available

  it 'should return value' do
    get :new
    expect(controller.gon.foo).to eq nil
  end
end

The first test passes and the second test passes  as long as it's run sequentially before the first. If it gets run after the first test it fails.
If I ask it to output value before running the test:
  it 'should return value' do
    puts controller.gon.foo
    get :new
    expect(controller.gon.foo).to eq nil
  end

...it outputs the value from the previous test.
Seems like the values are not being cleared between tests.
[Rails 4.2.1,  Rspec 3.2.0, Gon 5.2.3]

Thank you for opening issue.
Reason
Gon gem uses RequestStore gem for storing data.
RequestStore uses Rack middleware to clear data.(value is not held in another request)
Controller spec does not use Rack middleware. As a result, data is not cleared in another request.
Solution
Please clear data in after hook like below.
after do
  Gon.clear
end


Run predicate pushdown test without dynamic filtering too

cc @sopel39 @kokosing

again it's fine, but I don't see much benefit in it. just a single test would be fine

I understand Karol. As you see i have different opinion (hence this PR).
Fortunately it doesn't hurt to have this doubled.
Thanks for review!

Fortunately it doesn't hurt to have this doubled.

Actually, it does. Whenever somebody adds a new test, he will have to probably duplicate it in both classes. This is confusing.


Use process library, remove unix from dependency

In Example.hs, Use System.Process instead of System.Posix.Process to enable cross-compilation.
https://github.com/input-output-hk/cardano-shell/issues/149

Runnning  ./nix/regenerate.sh to apply the patch in the buildkite artifact
https://buildkite.com/input-output-hk/cardano-shell/builds/531#07812c03-ce8e-4e9c-ba5a-91a8f7d26f5c

@HirotoShioi I would recommend against running  ./nix/regenerate.sh yourself. Instead, git the patch file that CI generates and apply that. The patch file is under the "artifacts" tab of the "stack2nix" job.

@erikd I would do that! Thank you.

Yep, I agree, I should definitely polish the exception handling. I was rushing to make the demo work.
And I'm a bit concerned about the CI. I don't think the CI is running the test. I'm going to take a look at it tomorrow.

So I finally have the CI running tests, and it seems like there's no stack available on the CI.
  test/NodeIPCSpec.hs:135:13:
  1) NodeIPC.startIPC.Examples should return Started, Pong with createProcess
       uncaught exception: IOException of type NoSuchThing
       stack: createProcess: runInteractiveProcess: exec: does not exist (No such file or directory)
       (after 1 test)

I'm currently compiling with nix to see if there's any workaround.

Created new PR which points to the develop branch.
https://github.com/input-output-hk/cardano-shell/pull/173


[KOGITO-3864] - KogitoInfra got delete when refering KogitoRuntime/Ko…

…gitoSupportingService delete
Jira issue : https://issues.redhat.com/browse/KOGITO-3864
Many thanks for submitting your Pull Request :heart:!
Please make sure that your PR meets the following requirements:

[x] You have read the contributors' guide
[x] Pull Request title is properly formatted: [KOGITO-XYZ] Subject
[x] Pull Request contains a link to the JIRA issue
[x] Pull Request contains a description of the issue
[x] Pull Request does not include fixes for issues other than the main ticket
[x] Your feature/bug fix has a unit test that verifies it
[x] You've tested the new feature/bug fix in an actual OpenShift cluster

I am closing this PR and creating new PR to incorporate finalizer changes


Owen/cli integration test

Add integration tests to bitseed
Fix the infinite loop that occurs when there is printf in the WASM code.

@jolestar @steelgeek091 help review.


fixed missing else statement when creating nats connection

Hi,
I forgot an else statement... And could you please push the newest version to the docker hub ? Would be nice.

Afaik every master push will be pushed to the edge tag on Docker Hub.

@lennycampino
Please verify that the edge docker image is working for you. There's a scheduled release coming up in the next week that will include your change.
Also could you update the webhooks docs on the Tile38 documentation site to include the nats endpoint?
The doc repo is https://github.com/tile38/tile38.github.io
Thanks again.

Okay thank you and yes i can update the webhook docs.

Thanks. I just pushed your doc update


Multiple subdomain DNS failed for *.k8s.orb.local

Describe the bug
When add multiple subdomain in the ingress *.k8s.orb.local, the DNS is not working properly:

gitlab.k8s.orb.local -> WORKING
console.application.minio.k8s.orb.local -> NOT WORKING
application.minio.k8s.orb.local -> NOT WORKING

To Reproduce
No response
Expected behavior
DNS should be able to resolve not matter the number of subdomaine
Diagnostic report (REQUIRED)
No response
Screenshots and additional context (optional)
No response

Multi-level wildcard support added for the next version.

Hi @kdrag0n is it in canary version 1.4.0-rc.1 ? Thx

It'll be in stable v1.4.0.

Released in v1.4.0.


Store additional properties in ASE calculator

These changes allow for a user to calculate and store non-standard properties in the ASE calculator. For relatively experienced users, this is also a fix for #655 (one can set "energy", "forces", "stress" as properties_to_store, these will be calculated at each step, and then the inherited get_property function will not re-trigger a calculation but just read from the calc.results dict).
Contributor (creator of pull-request) checklist

[ ] Tests updated (for new features and bugfixes)?
[x] Documentation updated (for new features)?
[x] Issue referenced (for PRs that solve an issue)?

Reviewer checklist

[ ] CHANGELOG updated with public API or any other important changes?

📚 Download documentation preview for this pull-request

Why did you go with this approach instead of automatically storing energy/energies when computing the forces and stress? The fact that one has to explicitly set these is not ideal, and I feel like a solution to #655 that works without explicit user action would be nicer.

This was not intended as a fix for #655 (although it is if one knows the internals). It's just to propagate potentially more outputs to the user

Ok, the initially intended API for doing outputs outside of ASE specification was the run_model function. Why is it not suitable in your case?

It looks to me like it recomputes everything...
IMO the only way not to recompute if one wants additional properties is to save stuff to the calculator.results dict, because that is what's checked to avoid recomputations (if the Atoms object hasn't changed)

It looks to me like it recomputes everything...

No, because this function is not integrated with the rest of ASE interface (get_property & friends). This should be used like this:
calculator = MetatensorCalculator(...)
outputs = {...}

calculator.run_model(atoms, outputs)

Since the user is explicitly calling this function themself, it will only recompute if the users call it again manually.

In general there are two separate issues IMO: #655 is about storing multiple that ASE knows about (storing energy when computing forces, etc.); while run_model is about computing properties ASE does not know about (i.e. mtt::last_layer_features, nmr_shielding, etc.).
We need a fix for #655, but I don't think that properties_to_store is the best solution. I would rather do this automatically without any user intervention.

The fact that it is not integrated with the rest of ASE is why the recomputations are necessary. If I need a quantity at some step of MD, I have to recompute

Hello,
Yuxuan and I have ported a preliminary chemical shielding model to an ase-MetatensorCalculator.
This model returns atom centered non standard properties, namely the chemical shieldings.
I would feel like, that the most natural way to compute these properties woule be like this (ideally even without having to specify the domain name itself):
calc = MetatensorCalculator("model.pt")
frame.set_calculator(calc)
cs_iso = frame.get_properties(["mtt::cs_iso"])

However, currently it requires doing this, which I find not so intuitive:
output = calc.run_model(frame, outputs)
cs_iso = output['mtt::cs_iso'].block(0).values.detach().numpy()

I personally feel like the results should be stored in the results dict as numpy arrays, that way models can be used from users outside the metatensor universe.

This PR would remove the need to explicitly call run_model and instead put the data in a dict, but you would still have to provide the ModelOutput and you would get the results as TensorMap.

I personally feel like the results should be stored in the results dict as numpy arrays, that way models can be used from users outside the metatensor universe.

This is not possible for fully generic metatensor outputs, since they could have multiple keys/blocks, and then this function would not know what to do with them.
I agree that doing things like this would be nice, but it does not fit in the ASE calculator framework. We could however define a new API that could do what you are asking for standardized outputs, with something like this
calc = MetatensorCalculator("model.pt")
cs_iso = calc.get_metatensor_property(atoms, "scalar_chemical_shielding")

assert isinstance(cs_iso, np.ndarray)

This requires first defining what the standard outputs are and what get_metatensor_property should do for these outputs.
For example, what does this function do if there are multiple blocks in the output? What does it do if there are missing samples? How does it differentiate per atom or per structure outputs?
I'll open a separate issue to discuss this further, this PR is mainly aimed at things that should be computed together with the energy/forces.


Why are my cors headers being ignored?

When doing an introspection query, the koa integrated service seems to ignore the cors headers being set by the aplication. Cors headers are set this way,
ctx.status = 200;
ctx.set('access-control-allow-credentials', 'true');
ctx.set('access-control-allow-origin', host);
ctx.set('access-control-allow-headers', corsHeadersAccepted);
ctx.set('access-control-allow-methods', 'OPTIONS');
ctx.set('access-control-allow-methods', 'GET,HEAD,PUT,POST,DELETE,OPTIONS');
/*
  response: {
    status: 200,
    message: 'OK',
    header: [Object: null prototype] {
      'access-control-allow-credentials': 'true',
      'access-control-allow-origin': 'http://localhost:3001',
      'access-control-allow-headers': 'content-type,authorization,accept,accept-language',
      'access-control-allow-methods': 'GET,HEAD,PUT,POST,DELETE,OPTIONS'
    }
  }
*/

Using the new apollo server integration, cors requests are failing here, and introspection queries from different hosts fail
app.js
const apolloServer = new ApolloServer({
  schema: executableSchema,
  formatError: (formattedError, error) => ({
    console.log(error.extensions.http.headers) // { status: 400, headers: HeaderMap(0) [Map] {} }
    console.log(error)
    // BadRequestError [GraphQLError]: This operation has been blocked as a potential
    // Cross-Site Request Forgery (CSRF). Please either specify a 'content-type' header
    // (with a type that is not one of application/x-www-form-urlencoded,
    // multipart/form-data, text/plain) or provide a non-empty value for one of the
    // following headers: x-apollo-operation-name, apollo-require-preflight
    return formattedError;
  })
})

thanks for any reply you may give

Apollo 4 seems to dependent on this non-standard behaviour, found in @koa/cors.
app.use(async (ctx, next) => {
  ctx = attachCorsHeaders(ctx);

  // apollo fails here, unless await next() is called
  if (apolloKoa && ctx.request.method !== 'OPTIONS') {
    await next();
  }

  return ctx;
});

I am a little busy this week but will try and look into this more, in the mean time please feel free to open a PR they are more than welcome!

@iambumblehead I don't quite follow what your exact issue is. This seems relevant but I can't quite piece together what the actual problem is:

because Apollo4 is tested with @koa/cors, which always calls next() when request method is not OPTIONS. If cors headers are attached before the Apollo4 middleware are run, Apollo removes the headers or has some other problem. The apollo middleware must run last, forcing cors middleware do be attached before apollo.

Are you suggesting that @koa/cors is doing the wrong thing? Are we testing the integration incorrectly in some way? Can you share a reproduction that demonstrates the issue clearly? We have a codesandbox which makes for a good jumping off point if that's helpful: https://codesandbox.io/s/apollo-server-typescript-3opde?file=/src/index.ts (you'll have to add the Koa bits).


Fix citation import check

Description
Fix the python import with pip install pybamm[cite]
Fixes #4432
Type of change

[x] Bug fix (non-breaking change which fixes an issue)

Key checklist:

[x] No style issues: $ pre-commit run (or $ nox -s pre-commit) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)
[x] All tests pass: $ python run-tests.py --all (or $ nox -s tests)
[x] The documentation builds: $ python run-tests.py --doctest (or $ nox -s doctests)

You can run integration tests, unit tests, and doctests together at once, using $ python run-tests.py --quick (or $ nox -s quick).
Further checks:

[x] Code is commented, particularly in hard-to-understand areas
[x] Tests added that prove fix is effective or that feature works

This would stop the error, but also would break the citations class. Pushed the wrong branch, closing this


Reference to deprecated package

Under Use a managed identity heading:
Point 4 instructs to add a deprecated package Microsoft.Azure.Services.AppAuthentication (not available for .net 8): https://www.nuget.org/packages/Microsoft.Azure.Services.AppAuthentication
On Point 5 it instructs to write:

            builder.Configuration.AddAzureAppConfiguration(options =>
    options.Connect(
        new Uri(builder.Configuration["AppConfig:Endpoint"]),
        new ManagedIdentityCredential()));

But AddAzureAppConfiguration does not exist in namespace because one can't add Microsoft.Azure.Services.AppAuthentication as a package.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: e0b5a566-084c-d77f-9d78-3bfd72b01080
Version Independent ID: b22f2729-2f31-a0cd-fc61-0ead183b0aab
Content: Use managed identities to access App Configuration - Azure App Configuration
Content Source: articles/azure-app-configuration/howto-integrate-azure-managed-service-identity.md
Service: azure-app-configuration
GitHub Login: @maud-lv
Microsoft Alias: malev

@Divan-VanZyl
Thanks for your feedback! We will investigate and update as appropriate.

Adding @zhiyuanliang-ms to this discussion as per conversation.

Hi Divan-VanZyl, thank you for opening this issue. I have reviewed this doc and removed the deprecated package. #please-close


Added optional merge property support via a database dialect.

Support for the merge command is dependent on the database dialect.
As a result, we need to extend the Database commands depending on the database.
This adds a dbStatements file for H2.  The MERGE_PROPERTY is optionally specified; if so, it is used and the database is updated with the merge command (or theoretically an upsert -- if more dialects are supported).  Otherwise the traditional update/insert strategy is employed.
Note that saveProperties method was broken (insert was never executed) and, since it was also unused, I chose to remove it (rather than fix it).
(I know that this may be a little crazy or controversial.  Curious if you'll find this approach acceptable.)

I really like the way you implemented this - much cleaner then what I had planed. Before merging this I will add an Oracle and MySQL dialect. I do see one small problem in that the ON DUPLICATE UPDATE may take more parameters... I may have to build a stored proc for MySQL.

Would a trick like this help?  Reusing an anonymous parameter in a prepared statement


Azure Metrics on the storage account as described on this page has been disabled/deprecated as of January 2024

This page advocates using Metrics tab under the storage account to determine traffic to storage account using SAS key.
That functionality has been discontinued.
Page should be updated to reflect the new procedure.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 69f22974-ee84-5d29-d12f-af2a68ca72bc
Version Independent ID: 6ed5e442-6ab8-b87b-0a13-c0479c2ba152
Content: Prevent authorization with Shared Key - Azure Storage
Content Source: articles/storage/common/shared-key-authorization-prevent.md
Service: azure-storage
Sub-service: storage-common-concepts
GitHub Login: @pauljewellmsft
Microsoft Alias: pauljewell

@nschuessler
Thanks for your feedback! We will investigate and update as appropriate.

@nschuessler Thanks so much for your feedback. Can you help me better understand where you're seeing the problem?
If I follow the steps in this section, I'm able to see both AccountKey and SAS as options when I add a filter for authentication:

Note: I'm using the Monitoring->Metrics section in the portal (not classic monitoring or metrics, which were deprecated in January, as you mention), and I'm creating the metric on a storage account where I know I've had recent SAS activity. If there's not been SAS activity then it won't show up in the list.
Maybe I'm misunderstanding the issue, though. If so, any clarification is much appreciated. Thanks!

Ug. Sorry. I found it later.  I was in the Metrics (classic) section originally and didn't realize there were two Metrics sections. I found the original and it worked as described.

Issue is resolved


Use appropriate ADK DISM if available

On WS2012R2 with Windows ADK 8.1 and 10 installed, I'm getting the following error:
PS C:>  new-labvm -Name NANO -MediaId 2016TP5_x64_NANO_EN -SwitchName VmNAT
WARNING: [5:30:26 PM] Using existing 'VmNAT' virtual switch.
New-LabImage : To service this Windows image requires the latest version of the DISM. See
http://go.microsoft.com/fwlink/?LinkId=293395 to find the latest version of DISM,
and http://go.microsoft.com/fwlink/?LinkId=293394 to learn how to install the latest version of DISM from the ADK on
your computer.
At C:\Program Files\WindowsPowerShell\Modules\Lability\0.10.0\Src\LabVM.ps1:326 char:27

... ef] $null = New-LabImage -Id $node.Media -ConfigurationData $Configur ...

            ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

CategoryInfo          : NotSpecified: (:) [Write-Error], WriteErrorException
FullyQualifiedErrorId : Microsoft.PowerShell.Commands.WriteErrorException,New-LabImage

It sounds like the ADK installs another DISM module. Can you run the following and post the output here?
Get-Module DISM -ListAvailable | Format-List
Import-Module DISM -Force -PassThru | Format-List

Transcript attached - It seems that the problem is that path and DISM module need to be explicitly set\imported for it to work per these instructions:  https://technet.microsoft.com/en-us/library/hh825010.aspx...  The ADK seems to install the Win10 DISM bits in "side-by-side" mode rather than upgrading the system's default DISM.  The version numbers of the ADK and WS2K12R2 DISM modules are the same (ModuleVersion=3.0), but in the WS2K12R2 dism.psd1 the Verb-WindowsCapability commandlets are missing from the DISM module, and it relies on the path to find the dependent assemblies and resources so it won't use the ADK files.
ws2k12r2-adk-dism.txt
ws2k12r2-default-dism.txt

Hi @brycem I'm not sure why you're getting errors about the CustomMedia.json file. This should always be created in $env:ALLUSERSPROFILE\Lability and never the installation folder. However, are we saying that if the ADK is installed, we have to use the ADK version of the DISM module or the built-in one?

@iainbrighton - As I read the ADK documentations, I think you're supposed to use a Win8.1 DISM to manipulate Win8.1 images and a Win10 DISM to manipulate Win10 images, though in practice a Win10 DISM appears to be backward compatible.

@brycem Right then. I have a 2012 R2 machine and have replicated the issue.

OK - getting PowerShell to use the correct version of the DISM module turned out to be intricate than it should be. Here's it working on a 2012 R2 host with a Server 2016 Nano Server image 😃.
PS C:\Users\Administrator> [environment]::OSVersion

Platform ServicePack Version    VersionString
-------- ----------- -------    -------------
 Win32NT             6.3.9600.0 Microsoft Windows NT 6.3.9600.0

PS C:\Users\Administrator> $lab = Import-Module Lability -Force -PassThru
PS C:\Users\Administrator> & $lab { Get-Module -Name Microsoft.Dism.Powershell | Select Path, Version }

Path                                                                                Version
----                                                                                -------
C:\Windows\System32\WindowsPowerShell\v1.0\Modules\Dism\Microsoft.Dism.PowerShell.dll <IP_ADDRESS>

PS C:\Users\Administrator> Set-LabHostDefault -DismPath 'C:\Program Files (x86)\Windows Kits\10\Assessment and Deployment Kit\Deployment Tools\amd64\DISM' -Verbose
WARNING: [16:50:49] Updating the Dism version requires a session reload. Please restart the PowerShell session to
ensure the required Dism version is loaded.
VERBOSE: [16:50:49] Loaded Dism module version '<IP_ADDRESS>'.

ConfigurationPath       : C:\Lability\Configurations
DifferencingVhdPath     : C:\Lability\VMVirtualHardDisks
HotfixPath              : C:\Lability\Hotfixes
IsoPath                 : C:\Lability\ISOs
ModuleCachePath         : C:\ProgramData\Lability\Modules
ParentVhdPath           : C:\Lability\MasterVirtualHardDisks
ResourcePath            : C:\Lability\Resources
ResourceShareName       : Resources
DisableLocalFileCaching : False
EnableCallStackLogging  : False
DismPath                : C:\Program Files (x86)\Windows Kits\10\Assessment and Deployment Kit\Deployment
                          Tools\amd64\DISM\Microsoft.Dism.Powershell.dll

PS C:\Users\Administrator> & $lab { Get-Module -Name Microsoft.Dism.Powershell | Select Path, Version } | fl

Path    : C:\Program Files (x86)\Windows Kits\10\Assessment and Deployment Kit\Deployment
          Tools\amd64\DISM\Microsoft.Dism.Powershell.dll
Version : <IP_ADDRESS>

PS C:\Users\Administrator>

Correct DLL is referenced, but module isn't reloaded correctly. Restart of PowerShell session is REQUIRED after calling Set-LabHostDefault -DismPath.
PS C:\Users\Administrator> $lab = Import-Module Lability -Force -PassThru
PS C:\Users\Administrator> & $lab { Get-Module -Name Microsoft.Dism.Powershell | Select Path, Version } | fl

Path    : C:\Program Files (x86)\Windows Kits\10\Assessment and Deployment Kit\Deployment
          Tools\amd64\DISM\Microsoft.Dism.Powershell.dll
Version : <IP_ADDRESS>

PS C:\Users\Administrator> New-LabImage -Id 2016_x64_Standard_Nano_EN_Eval -Force -Verbose

VERBOSE: [16:57:32] Removing disk image 'C:\Lability\MasterVirtualHardDisks\2016_x64_Standard_Nano_EN_Eval.vhdx'.
VERBOSE: [16:57:32] Resource 'C:\Lability\ISOs\2016_x64_EN_Eval.iso' checksum matches '18A4F00A675B0338F3C7C93C4F131BEB'.
VERBOSE: [16:57:32] Creating disk image 'Windows Server 2016 Standard Nano 64bit English Evaluation'.
VERBOSE: [16:57:32] Creating disk image 'C:\Lability\MasterVirtualHardDisks\2016_x64_Standard_Nano_EN_Eval.vhdx'.
VERBOSE: [16:57:33] Mounting disk image 'C:\Lability\MasterVirtualHardDisks\2016_x64_Standard_Nano_EN_Eval.vhdx'.
VERBOSE: [16:57:33] Initializing disk image 'C:\Lability\MasterVirtualHardDisks\2016_x64_Standard_Nano_EN_Eval.vhdx'.
VERBOSE: [16:57:34] Creating 'EFI' disk partition.
VERBOSE: [16:57:34] Formatting 'EFI' disk partition.
VERBOSE: [16:57:34] Creating 'MSR' disk partition.
VERBOSE: [16:57:34] Creating 'Windows' disk partition.
VERBOSE: [16:57:34] Formatting 'Windows' disk partition.
VERBOSE: [16:57:36] Mounting disk image 'C:\Lability\ISOs\2016_x64_EN_Eval.iso'.
VERBOSE: [16:57:36] Locating WIM image 'Windows Server 2016 SERVERSTANDARDNANO' index.
VERBOSE: [16:57:36] Applying Windows Image '1' to 'C:\Lability\MasterVirtualHardDisks\2016_x64_Standard_Nano_EN_Eval.vhdx'.
VERBOSE: [16:57:41] Adding Windows package(s) 'Microsoft-NanoServer-Guest-Package' to image 'E:\'.
VERBOSE: [16:57:41] Adding package 'Microsoft-NanoServer-Guest-Package' to image 'E'.
VERBOSE: [16:57:50] Adding localized Windows package(s) 'Microsoft-NanoServer-Guest-Package_en-US' to image 'E:\'.
VERBOSE: [16:57:50] Adding package 'Microsoft-NanoServer-Guest-Package_en-US' to image 'E'.
VERBOSE: [16:57:54] Adding Windows package(s) 'Microsoft-NanoServer-DSC-Package' to image 'E:\'.
VERBOSE: [16:57:54] Adding package 'Microsoft-NanoServer-DSC-Package' to image 'E'.
VERBOSE: [16:57:56] Adding localized Windows package(s) 'Microsoft-NanoServer-DSC-Package_en-US' to image 'E:\'.
VERBOSE: [16:57:56] Adding package 'Microsoft-NanoServer-DSC-Package_en-US' to image 'E'.
VERBOSE: [16:57:57] Dismounting disk image 'C:\Lability\ISOs\2016_x64_EN_Eval.iso'.
VERBOSE: [16:57:57] Repairing boot volume 'E:'.
VERBOSE: [16:57:57] Starting process 'bcdboot.exe E:\Windows /s D:\ /v /f UEFI'.
VERBOSE: [16:57:59] Process 'bcdboot.exe' exit code '0'.
PS C:\Users\Administrator>

Is there any chance you can check this fork fixes your problems?

I've just stumble upon the same issue at the moment, and abslutelly puzzled at the moment.
Os w2k16 core hyper-v
Platform ServicePack    Version        VersionString
-------- -----------    -------        -------------
 Win32NT Service Pack 1 6.1.7601.65536 Microsoft Windows NT 6.1.7601 Service Pack 1

Path                                                                                Version
----                                                                                -------
C:\Windows\System32\WindowsPowerShell\v1.0\Modules\Dism\Microsoft.Dism.PowerShell.dll <IP_ADDRESS>

DisableLocalFileCaching      : False
ResourcePath                 : C:\Lability\Resources
DifferencingVhdPath          : E:\Lability\VMVirtualHardDisks
EnableCallStackLogging       : False
ParentVhdPath                : E:\Lability\MasterVirtualHardDisks
IsoPath                      : C:\Lability\ISOs
ResourceShareName            : Resources
ConfigurationPath            : E:\Lability\Configurations
HotfixPath                   : E:\Lability\Hotfixes
ModuleCachePath              : C:\ProgramData\Lability\Modules
DismPath                     : C:\Windows\System32\WindowsPowerShell\v1.0\Modules\Dism\Microsoft.Dism.PowerShell.dll
RepositoryUri                : https://www.powershellgallery.com/api/v2/package
DisableSwitchEnvironmentName : True

and getting exact same warning once trying to provision w2k16 or w10 through lability :(
any guideance / help / direction much appreciated. Thank you!

@tansei What version of Lability are you using? There was an error creating Windows 10 images in 0.12.3 which should be fixed in 0.12.4.

@iainbrighton - thanks for your brilliant sessions in e2evc and channel9 videos, and thank you for the 0.12.4 indeed it is sorting out that problem and at least in my case the dism <IP_ADDRESS> does NOT appear anymore.


Fix CRD definition to be cluster-scoped

What type of PR is this?
/kind bug
What this PR does / why we need it:
Fix bug which makes the CRD namespaced when it should be cluster scoped.
Which issue(s) this PR fixes:
Fixes #23
Does this PR introduce a user-facing change?:
The yaml for the CRD now correctly installs VolumePopulator as a cluster-scoped object.

/retest

/retest

/lgtm
/approve


Negative sampling tree

[0, 1, 2, 3, 4]
[3) 1, 2, 0, 4]
[3, 1) 2, 0, 4]
[3, 1, 0) 2, 4]

https://people.csail.mit.edu/jshun/fast-arrays.pdf


[BUG Bash] Azure Cli and Azure ML SDK are incompatible.

Azure Cli and Azure ML SDK are incompatible. The CLI and ML SDK cannot be both used at the same time from the same cli.
To Reproduce
Try to install both in the latest azure-cli container:
docker run -it mcr.microsoft.com/azure-cli
pip install azureml-sdk azure-cli
Expected behavior
Both can be used in the same environment.
Setup

Python 3.9.6
azureml-sdk>=1.36.0
azure-cli>=2.30.0

The compatibility issue between azure cli and azureml-sdk  is because of lack of support for MSAL authentication in azureml-sdk. We are actively working on migrating from ADAL to MSAL authentication in azureml.


[WIP] Test Python 3.7

Part of #962
This pull request:

[x] Has a title summarizes what is changing
[ ] Includes a news entry file (remember to thank yourself!)
[ ] Has unit tests & code coverage is not adversely affected (within reason)
[x] Works on all actively maintained versions of Python (e.g. Python 2.7 & the latest Python 3 release)
[x] Works on Windows 10, macOS, and Linux (e.g. considered file system case-sensitivity)

Closing - all taken care of! :grin:


Add isRadio option via using {props.data}

origin data format like
{
checkbox : true,
label: "label",
children: []
}
now can use "isRadio" like
{
checkbox : true,
isRadio: true
label: "label",
children: []
}
then the treemenu will do the rest like usual.

What's the purpose of having a radio element in this situation? I'm trying to figure out why one would want a radio instead of a checkbox. Generally a radio is useful when you provide the name attribute, which puts radio components in a group, allowing the user to only select one per name group.

Hi, I apologize for such a offensive pull request.
In my situation, I have a tree data that list all the fire department and what country they belong to.
When user click one of department, they can decide how many fire engine they want to send.
If I use a checkbox, when user choose another department in list, they don't know what departs the focus now.
so I use a radio  instead.
Plz, ignore the pull request if is not necessary for this project.

@lincecumHao I wasn't offended at all :) No problem at all. I appreciate the PR, but I think I won't merge it as I haven't heard this requirement/request from anyone else thus far.


Quick select?

Hi, and thanks for developing this plugin, which I'm using because it seems a lot more thoughtful in its base design compared to e.g. Harpoon!
I think that what I expected... What I expected was a super-speedy "quick switch". In my "Vim Workshop" project, for example, I have the following files tagged:
[p] plugins.lua
[v] init.vim
[l] init.lua
[t] todo

I'd like to open a popup and immediately hit p, for example, to go to plugins.lua.
Now I really do like the normal-mode functionality you get from entering GrapplePopup tags, it's really nice to edit your tagged files like in an ordinary text document. So perhaps this could be a third modality, GrapplePopup quick.
This raises the question of how to iteratively select when you have many tags with tag length > 1. The interface could be similar to fzf or Telescope. Which in turn raises the question: How about Telescope integration?
Anyway, that's just something else to think about! Have you thought about adding this? (I might even pop you a PR when I have time for Vim hacking later next week). What other ideas have you imagined for future versions of Grapple? :smiley:

I'd also be interested in this feature!

Great suggestion. Apologies, I haven't had time to work on this project for a while.
I've been working on a rewrite that allows some more flexibility for operations like this. Right now it supports quick-selection from 1..9. Would that be sufficient? For example,

Feel free to try out the branch rewrite, if you're interested! There are more goodies than just quick selection 🙂 Please note, there are breaking changes in the file format so your previous tags won't be loaded (not deleted, however). Also, the user command has been updated:
GrappleTag -> Grapple tag
GrappleUntag -> Grapple untag
GrappleToggle -> Grapple toggle
GrapplePopup tags -> Grapple open_tags


🔧 Update package metadata, drop support for Python 3.6, move build internals from Flit to Hatch

Background
Hello there! The Python packaging ecosystem has standardized on the interface for build backends (PEP 517/PEP 660) and the format for metadata declaration (PEP 621/PEP 631).
So, I'm spending my free time updating important projects so that they are modernized and set an example for others 😄
The is a follow-up to https://github.com/samuelcolvin/pydantic/pull/4282
Summary of changes
Metadata
This implements PEP 621 and removes Flit as a development dependency, allowing pip to be used directly which simplifies the contributing workflow and CI/CD. The build backend hatchling (of which I am a maintainer in the PyPA) is now used as that is the default in the official Python packaging tutorial. Hatchling is available on all the major distribution channels such as Debian, Fedora, Arch Linux, conda-forge, Nixpkgs, Alpine Linux, FreeBSD, Gentoo Linux, MacPorts, OpenEmbedded, Spack, etc.
Python support
The earliest supported Python 3 version of Hatchling is 3.7, therefore I've also set that as the minimum here. Python 3.6 is EOL and other build backends like flit-core and setuptools also dropped support. Python 3.6 accounts for 3-4% of downloads in the last month: https://pypistats.org/packages/fastapi
If support is still desired for some reason, I can keep the existing cap and only require 3.7+ in CI/CD.
Documentation
I updated the contributing docs, which accounts for most of the diff. Luckily, they were written in such a way that going from flit to pip didn't alter semantics for any language!
Future

We now have the ability to ship optional wheels compiled with Mypyc, as Black recently did, to be even faster in benchmarks. Though as @tiangolo mentioned offline, it may be best to wait for the great work @samuelcolvin is doing on Pydantic v2 to be over to be sure we don't cause any disruptions in their test suite.
We could source the version from Git

Ah looks like the 3.6 job is hard coded in this repo's GitHub settings as required.

Awesome job, thanks a lot @ofek! FastAPI is now built with Hatch. :egg: :snake: :sunglasses:
Also, Python 3.6 is now officially NOT supported. :fire:


gift packages. checkitems

New attribute: "gift package" items are now "usable, package"
When you open a gift package, we print who it's from.
Now, we print that before processing results.
I added support for the "package" attribute in DebugModifiers
I ran "checkitems" and "checkpowers" and fixed a bunch of items.

I got NPEs on a bunch of items in checkModifiers because modifiers.txt contained a value for a modifier but when we parsed it, we got a null. As it happened, it was always the Thorns modifier.
I suspect it is because we have 2 patterns for it (3, now, since I found another one), and only one has a numeric value that we parse.
We actually do a bad value of parsing the number, since KoL expresses it as a range - and often has an element associated with it.
Here is a bunch of errors that checkitems now prints when it detects something like that.
Everything that says "missing a value" caused an NPE.
 I guess? Doesn't require opponent to hit you?
tailbone shield: Deals 80-100 [Stench Damage] to attackers
Item	tailbone shield	Stench Damage: +40, Damage Reduction: 16, Thorns: 1

Is that only when they attack (not stunned) and actually hit you?
In any case, it seems like Thorns and Damage Aura both need an element.
Perhaps Thorns needs a range - although many examples don't give a numeric value.
I think those two modifiers need some work.

Thorns and Damage Aura are intended to be used for Frosty or the Wall of Skin -- bosses where you care about how many sources of damage you have, but not how much damage they do, or of what element.

They're both working as I intended.

Ok. It's news to me that a bottle opener belt buckle does not operate the same way as a hippy protest button, but considering I have never used either, I am no expert.
There is still a bug with DebugDatabase not being able to parse Thorns correctly, but I will not be spending more time flailing at that; not throwing an NPE is good enough for now.
I plan no more new content for this PR.


Feature/check-env-vars-before-compiling

Check process.env vars before transpiling with webpack.

This pr can close #112 and close #113


Bump Spectre.Cli to version 0.35.0

Also removes the need for the custom command adapter since Spectre.Cli now supports adding non-generic commands.

Nice! I like removing large blocks of unnecessary code :). Thanks for keeping it updated.


List of FAB

From @ydeshayes on November 9, 2015 13:4
Hello,
Can you tell me if the adding the features to create a list of FAB is on the roadmap ?
https://www.google.com/design/spec/components/buttons-floating-action-button.html

Thanks !
Copied from original issue: driftyco/ionic2#475

From @adamdbradley on November 9, 2015 14:53
Yes, they're being implemented: http://ionicframework.com/docs/v2/components/#floating-action-buttons

From @adamdbradley on November 9, 2015 15:18
Gotcha, yeah this should be added.

From @nampdn on December 9, 2015 14:18
The list of option should have the label on the left of it like this, and have the option to enable the backdrop

From @ydeshayes on November 9, 2015 15:16
Yes the FAB buttons are, but I was talking about list of FAB (like de screenshot).
That is to say, when you click on the FAB, his behavior change and you got a list of action that pop-up.

is the feature added to rc.0? and if yes,  please give a link to the documentation.
thanks

Hello, this feature is indeed in the rc.0 release 😃 . We are currently working on updating the docs site for this release which will include docs of how to use this new feature. Expect that very soon. Thanks for using Ionic!

Something new here?


#199 impl compression

Signed-off-by: Daniel Nehrig<EMAIL_ADDRESS>TODO: either default true compress
or builder pattern from perseus side to enable gzip but then this needs to be read from main

If you edit your description of this PR to say 'Closes #199' at the bottom, it will be automatically closed when this is merged.
Btw, is this ready yet? If not, would you mind making it a draft?


Minimize features

Which issue does this PR close?
Closes #1398.
Rationale for this change
Give projects depending on datafusion more choice in what features to enable.
What changes are included in this PR?
Disabling default features for chrono and ahash in datafusion and ballista.
Are there any user-facing changes?
If projects depending on datafusion/ballista are making use of the coincidence that they turn on chrono or ahash features, this might mean they have to turn on the features themselves, but that would be a bug in that project's use of the crates.

oooops wrong upstream sorry edd!!!!


better sys.argv support

when running: visit cli s {script.py} arg_a, arg_b, arg_c ... Currently: Argv() returns [arg_a, arg_b, arg_c , ...] sys.argv returns everything passed to the cli: We want to: 1) move sys.argv values to some place (sys.argv_orig, or ArgvOrig()), just in case some one needs the full command line in python.2) replace sys.argv with something that matches the python interp style it would be sys.argv = [{script}, arg_a, arg_b, arg_c , ....]
-----------------------REDMINE MIGRATION-----------------------
This ticket was migrated from Redmine. As such, not all
information was able to be captured in the transition. Below is
a complete record of the original redmine ticket.
Ticket number: 1857
Status: Resolved
Project: VisIt
Tracker: Feature
Priority: Normal
Subject: better sys.argv support
Assigned to: Cyrus Harrison
Category: -
Target version: 2.8
Author: Cyrus Harrison
Start: 05/29/2014
Due date:
% Done: 0%
Estimated time:
Created: 05/29/2014 05:10 pm
Updated: 07/25/2014 07:22 pm
Likelihood:
Severity:
Found in version: 2.12.3
Impact: 3 - Medium
Expected Use: 3 - Occasional
OS: All
Support Group: Any
Description:
when running: visit cli s {script.py} arg_a, arg_b, arg_c ... Currently: Argv() returns [arg_a, arg_b, arg_c , ...] sys.argv returns everything passed to the cli: We want to: 1) move sys.argv values to some place (sys.argv_orig, or ArgvOrig()), just in case some one needs the full command line in python.2) replace sys.argv with something that matches the python interp style it would be sys.argv = [{script}, arg_a, arg_b, arg_c , ....]
Comments:
Cyrus will handle this. Hi Everyone,This commit includes two changes to the clis command line script file support:1) add new ni & noninteractive command line flags. These flags work in combination with s, to tell the clis python interpreter to exit after executing the passed script file.ni s is analogous topython script.pywhereas s is somewhat analogous to:python i script.pyThere are some other complexities (forceinteractivecli is still a meaningful option)2) use values after s as sys.argv.This makes VisIt's cli in "s" mode easier to use with things in the python ecosystem that consume sys.argv & brings it closer to an off the shelf python interpreter.I discovered that previously we actually had different sys.argv values visible to the s script and anything interactively. The reason for this was due to how Py_Main was used. I changed the control flow to use PyRun_InteractiveLoop to allow sys.argv to be consistent everywhere. Here is an example that illustrates this:##test.py #import sysprint sys.argv#[New Behavior]visit nowin cli s test.py arg1 arg2 arg3Running: cli dv nowin s test.py arg1 arg2 arg3Running: viewer noint arg1 arg2 arg3 dv nowin host <IP_ADDRESS> port 5601['test.py', 'arg1', 'arg2', 'arg3']print sys.argv['test.py', 'arg1', 'arg2', 'arg3'][Old Behavior]visit nowin cli s test.py arg1 arg2 arg3Running: cli2.7.3 nowin s test.py arg1 arg2 arg3Running: viewer2.7.3 noint arg1 arg2 arg3 nowin host <IP_ADDRESS> port 5601['/Users/harrison37/Desktop/VisIt.app/Contents/Resources/2.7.3/darwinx86_64/bin/cli', 'nowin', 's', 'test.py', 'arg1', 'arg2', 'arg3]Python 2.7.5 (default, Jun 5 2014, 16:46:00) [GCC 4.2.1 (Apple Inc. build 5666) (dot 3)] on darwinType "help", "copyright", "credits" or "license" for more information.print sys.argv['', 'nowin', 's', 'test.py', 'arg1', 'arg2', 'arg3']If you need access the full cli args, you can use:visit.argv_fullprint sys.argv['test.py', 'arg1', 'arg2', 'arg3'] print visit.argv_full['/Users/harrison37/Work/masonry/mbuildvisittrunkdarwinx86_64/build.debug/exe/cli', 'dv', 'nowin', 's', 'test.py', 'arg1', 'arg2', arg3'](this returns a list, b/c python uses lists for sys.argv)Since VisIt users have long leveraged the Source function (instead of importing scripts as modules) we introduced a way to distinguish between Sourceed files and the specific script file run on the command line. This is the convention used:if visit_script_file __visit_source_file: main()I preserved this.It is also worth noting that the standard python convention:if name main: main()Also works it just that Source() needs special logic. Source() is very useful for iterative development of scripts attempting to re "import" scripts as modules after edits is a perilous path.And the Argv() function still exists, and works just as before.##visit_argv_old_test.py #import sysprint sys.argvprint Argv()#visit nowin cli s visit_argv_old_test.py arg1 arg2 arg3Running: cli dv nowin s argv_test.py arg1 arg2 arg3Running: viewer noint arg1 arg2 arg3 dv nowin host <IP_ADDRESS> port 5601['visit_argv_old_test.py', 'arg1', 'arg2', 'arg3']('arg1', 'arg2', 'arg3')Finally, a change was required for the test suite:We were piping scripts into the test process. This is fine, however many of our scripts arent compatible with line by line execution in python.To avoid having to change all of our scripts, I used visit.Source() to execute them instead of stdin.Sending visitpy/cli/cli.CTransmitting file data .Committed revision r23882.Sending visit_test_main.pySending visit_test_suite.pyTransmitting file data ..Committed revision r23881.-Cyrus

1863_smime.p7s.zip


Add method in EDBPrimitives to check if two polygons are intersecting

Description of the feature
2 Methods are needed, one to check if 2 polygon are intersecting and 1 to check the intersection type.
Steps for implementing the feature
No response
Useful links and references
No response

closing already added


[FLINK-31084][connectors/dataGen] Add default value for dataGen seque…

What is the purpose of the change
The field configuration description of datagen is optional, but in actual sequence mode, start and end are required, as a user, I would expect the positive integer values to be returned starting from 0 if I don't specify anything here.
Brief change log

Added default value for sequence mode
Modify the original test method, because it is not applicable after adding the default
Modify the document default value description

Verifying this change
This change modifies the original testLackStartForSequence and testLackEndForSequence methods of DataGenTableSourceFactoryTest and replaces them with testDefaultValueForSequence and testStartEndForSequence methods to verify this change.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency):  no
The public API, i.e., is any changed class annotated with @Public(Evolving):  / no
The serializers:  no
The runtime per-record code paths (performance sensitive):  no
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper:  no
The S3 file system connector:  no

Documentation

Does this pull request introduce a new feature?  no

@XComp Can you take a look? Thank you

How come we're not touching the safeDivide method, which you mentioned in the corresponding Jira issue comment?

I see that you did not reply to me, so I did not modify this method. Now I will correct this method.

@XComp  The problem of safeDivide has been modified. Could you please help me review it? Thank you!

@XComp If you have time, please come and have a look again, thank you.

@XComp 感谢您的review,我已经完成了修改. PTAL.

@XComp This is a good proposal, and if it solves the problem in #22010, then our tests can increase the test of sequence integrity.
I will solve the problem of #22010 recently.


Connection details: received and published messages (all/received/published filter)

Finished on #70


Can I specify a photo overlay for Android?

Feature Request:
I want to use the camera api used here but I want to have a custom camera page with specific buttons and overlap on top of the camera page of the MediaPlugin. Can I do that currently for Android?

It is not possible because it launches an external app and there is no api do to that.
You will have to look into the Camera2 api's to embed it into your app.


refactor: Migrate Firebase Storage to nnbd

Description
NNBD migration work for Firebase Storage.
Related Issues
Replace this paragraph with a list of issues related to this PR from the issue database. Indicate, which of these issues are resolved or fixed by this PR. Note that you'll have to prefix the issue numbers with flutter/flutter#.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
[x] All existing and new tests are passing.
[x] I updated/added relevant documentation (doc comments with ///).
[x] The analyzer (flutter analyze) does not report any problems on my PR.
[x] I read and followed the Flutter Style Guide.
[x] I signed the CLA.
[x] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?

[X] Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
[ ] No, this is not a breaking change.

@googlebot I consent.

@googlebot I consent.

firebase_storage/pubspec.yaml still references the old _web and _interface and thus introduces the old http, clashing with other updated plugins

I had to remove customMetadata as a param on SettableMetadata due to it causing this error on web e2e tests:
Expected a value of type 'Map<String, String>?', but got one of type 'IdentityMap<String, dynamic>'

Not really sure why it is casting to a different type, apparently no documentation on IdentityMap either.  Either way, I couldn't figure it out within the time constraints, and I thought it more important to get this over the line. I've raised a ticket internally for this.
I also commented out a test as it is apparently supposed to error but it doesn't. This just needs confirmation on expected behaviour should also be included as part of the ticket.

This PR: https://github.com/FirebaseExtended/flutterfire/pull/5014 ought to be merged into this PR first to fix a number of issues described in the description.


dataset

Why is the provided dataset orange dataset instead of apple dataset?

Thanks for letting me know about this mistake.. the link is fixed now.
best

Thank you very much , wish you a happy work!


feat(admin-lte): Set wallet section as default if no wallet exists

:tada: This PR is included in version 1.15.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

31.85 PSF tokens rewarded. TXID:
8cd59fdd020473ac3aaf460bd8e8085bf333cb3b0a42a3c8a28e61d695c5f44d


Explore SDoHO

Download link on this page https://sbmi.uth.edu/bsdi/project.htm

The SDoHO ontology (OWL) was transformed into a tabular format with preserved hierarchy and incorporated into the SDOH OMOP vocabulary in the OMOP pre-stage format (see attached).
sdoho_prestage.csv

Committed to main in cb150be


tests: Split up PlannerTest

Current coverage is 81.21% (diff: 100%)

Merging #4576 into master will not change coverage

@@             master      #4576   diff @@
==========================================
  Files          1294       1294
  Lines         44105      44105
  Methods           0          0
  Messages          0          0
  Branches       7013       7013
==========================================
  Hits          35821      35821
+ Misses         5586       5583     -3
- Partials       2698       2701     +3

Powered by Codecov. Last update 54cd50a...8f7b3f7


[Augmentations] No error is reported by the analyzer if augmented is used in switch in augmentation

The following expected error is not reported by the analyzer.
// main.dart
import augment 'aug_lib.dart';

const augmented = "Constant augmented, shouldn't be used";
void set topLevelSetter(String value) {}

// aug_lib.dart
augment library 'main.dart';

augment void set topLevelSetter(String value) {
  switch ("") {
    case augmented:
//       ^^^^^^^^^
// [analyzer] unspecified
// [cfe] unspecified
    default:
  }
  var x = switch("") {
    augmented => 1,
//  ^^^^^^^^^
// [analyzer] unspecified
// [cfe] unspecified
    _ => 0
  };
}

See, for example, https://github.com/dart-lang/co19/blob/master/LanguageFeatures/Augmentation-libraries/augmented_expression_A02_t24.dart

@scheglov

Ping on a P1 issue; feel free to re-categorize this as an "enhancement."


filter: Check if search operand is valid.

Add a function check_operand_valid to check if
operand is valid else consider it as a broken
search term. Also update/add test for the same.
Fixes #17175

Testing plan:
tested manually as well as tests

@timabbott These changes look pretty good to me.  We still have the annoying double maintenance of two search-suggestion modules, one of which has been bit-rotting for a couple years now, and that might be something that gets aggravated by this PR, unfortunately.

Can you post a screenshot/screencast showing what the UI behavior is for invalid search operands before and after this change?

This is the screenshot .Basically we are treating the invalid search operator as a broken search term.

@timabbott I have made the changes.

@showell @thedeveloperr @YashRE42 I'm not entirely sure how I feel about the change this makes to the typeahead -- my read of the test changes is that typing has:l and then Enter will result in searching for has:l rather than has:link, which I think is a UX regression.  Am I missing something?
Also, I kinda want the test that we consider all the operators we test to be valid to in the group of checks for those operators, so that when we copy/paste filter.js test blocks, we verify this for them.  E.g. I'm imagining we'd call for each block just above what we're patching something like:
assert(all_operators_valid(operators));

We'd need to write a little test helper function that loops through the operators in the list, or something.


Spanner transactions

@balopat PTAL, read-write transactions.
the unit test is a good example of how these are used.
This is like a real transaction where we provide a block of code and NOT just a list of mutations as in the POC.

@balopat read-only transactions also added now

@balopat changes made


Issue regarding my vaccine certificate

I got my first dose of covishield and authorities record my gender incorrectly which is being displayed in my certificate as well.
Anyone can help me in this???
I want to correct my gender information on certificate....

Please guide me how to correct it???

Vaccine taken on 13.05.2021 but the employees not update to system.


Run a new build to get latest packages in image

Not a code change, just want a new build to get latest packages to
fix a CVE
Refs:

https://github.com/stolostron/backlog/issues/22451

Signed-off-by: Gus Parvin<EMAIL_ADDRESS>

/cherry-pick release-2.5


Good code

The program deserve some credit, with good quality codes like these; it should run

Thanks :)


Move flagger.app domain under CNCF

I'm happy to file the relevant ServiceDesk request once we have all the relevant info in one place.
Paging @stefanprodan for once he's back from holidays. :beach_umbrella:

Filed ticket with CNCF to get this looked at: https://cncfservicedesk.atlassian.net/servicedesk/customer/portal/1/CNCFSD-1234

Moved to https://jira.linuxfoundation.org/plugins/servlet/theme/portal/2/IT-23979

This is done now.


dmd browser schedule 2 confusion

The schedule 2 flag on the dm+d browser at ampp level has caused some confusion. Schedules commonly refer to controlled drug listings however these are help at VMP level.
The schedule 2 held at ampp level is actually

Indication as to whether the actual product pack is included in Part XVIIIB of the Drug Tariff
(England & Wales) as being prescribable for specific classes of patient for a specific purpose.

or more commonly known as SLS (selected list scheme). It appears that Part XVIIIB of the Drug Tariff is a rewrite of   schedule 2 of the  National Health Service (General Medical Services Contracts) (Prescription of Drugs etc.) Regulations 2004.  Hence the new name.
Without investigating I think it might make sense to change the field name on the public facing browser  as an immediate first step (i do think there is another issue about making fields interactive so you can hover and display field description).
I think it might also be worth checking in with BSA team to see if there is any other information in dealing with this issue as it must've come up before.

or possibly and/or https://github.com/ebmdatalab/openprescribing/blob/4b08fd00a4e8cf88c4562ae0c2331dc52c70178b/openprescribing/dmd/migrations/0001_initial.py#L304


Salted userID creation

Added date to userID creation.  Fixes https://github.com/Microsoft/sqlopsstudio/issues/1169

@abist this no longer needed since we've removed the user ID field from the telemetry.


[ERROR:flutter/lib/ui/ui_dart_state.cc(186)] Unhandled Exception: MissingPluginException(No implementation found for method getAll on channel plugins.flutter.io/shared_preferences)

[ERROR:flutter/lib/ui/ui_dart_state.cc(186)] Unhandled Exception: MissingPluginException(No implementation found for method getAll on channel plugins.flutter.io/shared_preferences)
sdk: ">=2.7.0 <3.0.0"
shared_preferences: ^2.0.5

Duplicate of https://github.com/flutter/flutter/issues/66833. Please follow up on there for updates.


ci: change release-please pr labels on release

#248
#247  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @AngelOnFira and the rest of your teammates on  Graphite


DatabaseError: DatabaseWrapper objects created in a thread can only be used in that same thread.

Django==1.8.6
celery==3.1.19
django-celery==3.1.17
Postgresql
I keep getting this error, I've tried both eventlet and the default worker type:
Task mysite.giftcards.tasks.EDeliverTask with id 32b60bb3-a538-4990-b854-775f3c97383e raised exception: ‘DatabaseError("DatabaseWrapper objects created in a thread can only be used in that same thread. The object with alias \'default\’ was created in thread id<PHONE_NUMBER>42032 and this is thread id<PHONE_NUMBER>24816.",)'

Task was called with args: [] kwargs: {'order_pk': 1}.

The contents of the full traceback was:

Traceback (most recent call last):

File "/srv/mysite.co/.venv/local/lib/python2.7/site-packages/celery/app/trace.py", line 253, in trace_task
  I, R, state, retval = on_error(task_request, exc, uuid)
File "/srv/mysite.co/.venv/local/lib/python2.7/site-packages/celery/app/trace.py", line 201, in on_error
  R = I.handle_error_state(task, eager=eager)
File "/srv/mysite.co/.venv/local/lib/python2.7/site-packages/celery/app/trace.py", line 85, in handle_error_state
  }[self.state](task, store_errors=store_errors)
File "/srv/mysite.co/.venv/local/lib/python2.7/site-packages/celery/app/trace.py", line 118, in handle_failure
  req.id, exc, einfo.traceback, request=req,
File "/srv/mysite.co/.venv/local/lib/python2.7/site-packages/celery/backends/base.py", line 121, in mark_as_failure
  traceback=traceback, request=request)
File "/srv/mysite.co/.venv/local/lib/python2.7/site-packages/celery/backends/base.py", line 257, in store_result
  request=request, **kwargs)
File "/srv/mysite.co/.venv/local/lib/python2.7/site-packages/djcelery/backends/database.py", line 29, in _store_result
  traceback=traceback, children=self.current_task_children(request),
File "/srv/mysite.co/.venv/local/lib/python2.7/site-packages/djcelery/managers.py", line 42, in _inner
  return fun(*args, **kwargs)
File "/srv/mysite.co/.venv/local/lib/python2.7/site-packages/djcelery/managers.py", line 181, in store_result
  'meta': {'children': children}})
File "/srv/mysite.co/.venv/local/lib/python2.7/site-packages/djcelery/managers.py", line 87, in update_or_create
  return get_queryset(self).update_or_create(**kwargs)
File "/srv/mysite.co/.venv/local/lib/python2.7/site-packages/djcelery/managers.py", line 70, in update_or_create
  obj, created = self.get_or_create(**kwargs)
File "/srv/mysite.co/.venv/local/lib/python2.7/site-packages/django/db/models/query.py", line 405, in get_or_create
  return self.get(**lookup), False
File "/srv/mysite.co/.venv/local/lib/python2.7/site-packages/django/db/models/query.py", line 328, in get
  num = len(clone)
File "/srv/mysite.co/.venv/local/lib/python2.7/site-packages/django/db/models/query.py", line 144, in __len__
  self._fetch_all()
File "/srv/mysite.co/.venv/local/lib/python2.7/site-packages/django/db/models/query.py", line 965, in _fetch_all
  self._result_cache = list(self.iterator())
File "/srv/mysite.co/.venv/local/lib/python2.7/site-packages/django/db/models/query.py", line 238, in iterator
  results = compiler.execute_sql()
File "/srv/mysite.co/.venv/local/lib/python2.7/site-packages/django/db/models/sql/compiler.py", line 838, in execute_sql
  cursor = self.connection.cursor()
File "/srv/mysite.co/.venv/local/lib/python2.7/site-packages/django/db/backends/base/base.py", line 160, in cursor
  self.validate_thread_sharing()
File "/srv/mysite.co/.venv/local/lib/python2.7/site-packages/django/db/backends/base/base.py", line 421, in validate_thread_sharing
  % (self.alias, self._thread_ident, thread.get_ident()))

DatabaseError: DatabaseWrapper objects created in a thread can only be used in that same thread. The object with alias ‘default’ was created in thread id<PHONE_NUMBER>42032 and this is thread id<PHONE_NUMBER>24816.

— Just to let you know, py-celery at<EMAIL_ADDRESS>

@SeanHayes Did you find a solution for this problem? We're seeing it.

I'm especially interested in how to fix this for gevent worker type.  Any solution yet?

+1

fix for this issue https://github.com/celery/django-celery/pull/476


[CUDA kernel performance about MQA & GQA]

It seems that the custom attention kernel will load kv-cache num_heads / num_heads_kv times from the global memory, is this the optimal solution or is there a plan to optimize it?

We are still investigating further optimization opportunity.

It’s not necessarily clear what the best approach is. Even if the code gives the impression that the data is loaded from Global Memory, it may actually come from the L2 cache. We are actively working on this kernel and we might change that in the future if we find that doing things differently helps. For now, I’m closing that issue but feel free to reopen it if needed.


Take a stab at porting existing components to Vue3

Related to #19902
Since there are only a few components right now, I skipped the migration build and went straight with updating the dependencies and fix the webpack.
So far, the webpack compiles. I haven't launched a web interface to check for runtime errors (therefore the WIP in the title).

productionTip is removed: https://v3-migration.vuejs.org/breaking-changes/global-api.html#config-productiontip-removed
There is an app object passed around instead of Vue.component: https://v3-migration.vuejs.org/breaking-changes/global-api.html#a-new-global-api-createapp - I therefore used it as an argument in the different functions („factory pattern”?)
Vue.extend become new createApp calls: https://v3-migration.vuejs.org/breaking-changes/global-api.html#vue-extend-removed
Vue.set is no longer needed: https://stackoverflow.com/a/70442272
nextTick is now an import: https://vuejs.org/api/general.html#nexttick

I have yet to walk over https://v3-migration.vuejs.org/breaking-changes/
Signed-off-by: André Jaenisch<EMAIL_ADDRESS>

Note to self: run Frontend linter before declaring this PR as „ready for review”

I addressed the linter complaint and tested each change locally. I'm confident that this will work out (if not, we have several weeks to fix regressions).
Vue3 should allow me to consult more recent documentation to add a test suite.

Yeah, I also encounter errors, hence I discarded my approval:

Looking at this now.

make frontend and make watch-frontend runs flawlessly :grimacing:

Okay, I can observe some runtime errors.
Is there a way to make TAGS="bindata sqlite sqlite_unlock_notify" make build && ./gitea not serve minified JavaScript?

make frontend and make watch-frontend runs flawlessly grimacing

Interesting. I encounter these errors both in make watch and make build.
What's "wrong" with your system not throwing these errors?

I encounter these errors both in make watch and make build.

Nope. No errors on the console with them either. BUT If I first start the build command (with the options above, because SQLite locally) and then run watch in another terminal and then look at runtime errors, I can observe them non-minified (but still bundled…).
E.g.

Uncaught TypeError: dataOptions.call is not a function

=> https://stackoverflow.com/questions/70822554/uncaught-typeerror-dataoptions-call-is-not-a-function-when-load-entry-in-vue-3 and that like.
Will work on it next time I can sit on my computer! Thanks.

Is there a way to make TAGS="bindata sqlite sqlite_unlock_notify" make build && ./gitea not serve minified JavaScript?

You can prefix the command with NODE_ENV=development which will make webpack skip the minification. Thought generally, I recommend just use make watch which automatically enabled this.

Hey @silverwind,
I had to pause (and informed Lois) due to doctor's appointments in the past weeks.
I have this on my mind, though.

Is it active?

No, I'm swamped right now. You can reach out to me on Matrix if you have questions.
I'm happy if someone else adopts this. Otherwise I will pick it up once I have more time at hand again.

I will take this one.

OK, all Vue components in js/components work well now.

Thank you so much!

Now, it's on try.gitea.io . A TODO issues has been opened for the refactoring.

https://github.com/go-gitea/gitea/issues/21311


feat: support jemalloc

What problem does this PR solve?
support jemalloc. No code changed actually.
Checklist
Tests

No code

https://github.com/apache/incubator-pegasus/issues/819

The failed CI tell us the third-parties is missing jemalloc built.

The failed CI tell us the third-parties is missing jemalloc built.

Got it. I am going to fix it.

The failed CI tell us the third-parties is missing jemalloc built.

Got it. I am going to fix it.

Have you fix it?

The failed CI tell us the third-parties is missing jemalloc built.

Got it. I am going to fix it.

Have you fix it?

It's hard to fix it because we should fix all of the failures in pegasus-docker :(


Add snphost CI PR test

Performs snphost cargo tests on the self-hosted runner

Looks like you have a linting error @LakshmiSaiHarika

Hi Reviewers, I edited this PR to add manual PR event and did some code cleanup.
Please review this and let me know if any additional changes are required.


ERROR amdgpu_config::fan > Curve fan temps should be monotonically increasing, found 70 then 60

I'm getting the following error message if I run:
sudo amdguid

output:
 ERROR amdgpu_config::fan > Curve fan temps should be monotonically increasing, found 70 then 60
thread 'main' panicked at 'No FAN config: UnsortedFanTemp { current: 60.0, index: 8, last: 70.0 }', amdguid/src/main.rs:22:14
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

may I ask what I should do here?
I'm running arch linux, the amdgui-helper.service is enabled and running.

It appears that your config file contains bad data. Please edit or delete it.
If you are familiar with nano or vim please use one of the following command:
vim /etc/amdfand/config.toml
nano /etc/amdfand/config.toml

Then find config line with non monotonic values (example 70 then 60) and remove them
If you will have any issues please don't hesitate to contact me here or via email<EMAIL_ADDRESS>or via Matrix etaden (kind there's t instead t, eraden was taken)
Yours sincerely
Eraden

Thank you for the quick answer! I could find a weird-order and removed it but I can't test it currently. I'll reopen this, if there will be some other problems. Thank you.


Documentation:  Template R code

Please select a category the issue is focused on?
Developer Guides
Let us know where something needs a refresh or put your idea here!
Develop a Vignette to demonstrate how the {sdtm.oak} functions and algorithms can be used to create SDTM domains.

What library needs to be installed to use the functions read_raw_data_csv, read_sdtm_spec_csv, and read_study_ct_csv. ? I'm quite new to GitHub and not sure if I'm doing it correctly.

Hi @joybvictor ,
Those functions are to be understood as pseudocode. Their implementation is actually not provided as of yet. It can nonetheless read the CSV with any CSV importer, e.g. read.csv() or readr::read_csv(). I hope that helps.

Understood. I've already loaded the library(readxl), but I want to confirm that I'm on the right path.


Hextof workflow notebook can not be used by documentation

As the notebook is restricted to maxwell, we can not do the execution on github actions and put those changes in the documentation. Of course, we can have the notebook unexecuted but thought other solutions should be discussed.
Executing and putting it on the repo isn't a good idea as notebooks generally don't well with version control.

The execution is not restricted to maxwell, only getting the data at the moment relies on the gamma portal. The example data are public anyhow. Why not putting them as well somewhere on Zenodo or so?

I agree with that. @kutnyakhov what do you think?

I agree with that

me to!

Current update: Dima is still looking in into that

Finally, I've managed to upload and make it available on
Zenodo
Hopefully, I did it the right way :)

Seems to be fine. I'll close this as completed.


"Contact us" page - additional UX upgrade

While Aoife and my sister were asked to contact us, the question came up what if the user doesn't have a email software installed on his device? At the moment the standard software opens a new email and the user can write us a email.
As a solution we might take in consideration creating a simple contact us page with a simple email contact form, like the book a call form.
High end solution:
When the user goes on the new contact us page, he will see two options "Write us a email" and "Book a call". After choosing one of the options, the respective form shows up (collapses like an accordion for ex.)

Duplicate of #72

Reopening as this is not a duplicate of #72

The page have been created. We just need to populate them. Tell me how is this different from #72?

Ok, we really need to clarify what an issue is or isn't, otherwise it's messy for everybody. Here, we are talking about a specific feature called the contact page, we do not need two different issues.

If we have a dedicated contact-us page where we can place a contact form, then this can be closed.
Here's an example of what I mean with

As a solution we might take in consideration creating a simple contact us page with a simple email contact form, like the book a call form.

https://enterpriseelectrical.ie/contact/

@buckwierd From now on we will follow the rules described here for issues and commit.
https://medium.com/@danielfeelfine/commit-verbs-101-why-i-like-to-use-this-and-why-you-should-also-like-it-d3ed2689ef70

Thanks Loic. We will. A step forward towards a better workflow :)

This is a duplicate of #113