[FLINK-29436][build] Upgrade spotless for running on JDK 17

This blocker is fixed by: https://github.com/diffplug/spotless/pull/1224 and https://github.com/diffplug/spotless/pull/1228.

Could there be a bug in that spotless version that the skip parameter is being ignored?

@zentol with this change I tested JDK 17 can work with spotless:
gh pr checkout 20911
mvn -nsu spotless:apply

... while it generates diff on:

flink-connectors/flink-sql-connector-hive-3.1.2/src/main/java/org/apache/hadoop/hive/conf/HiveConf.java
flink-connectors/flink-sql-connector-hive-3.1.2/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java

And I pushed a second commit for the change.

It seems the version bump cause this configure not work, I will try to find a reasonable followup:
			<!-- disable spotless since we need copy hive code -->
			<plugin>
				<groupId>com.diffplug.spotless</groupId>
				<artifactId>spotless-maven-plugin</artifactId>
				<configuration>
					<skip>true</skip>
				</configuration>
			</plugin>

Pushed a workaround on the plugin configs. I'm submitting a patch for upstream to avoid such a workaround.

@zentol thanks for your reviewing.
I've submitted a patch to the upstream https://github.com/diffplug/spotless/pull/1353.
Supposed 1) we're not in a hurry on this change 2) it is not easily to conflict with other patches 3) upstream uses auto-release after a patch is merged. I suggest after CI passes we wait a few days (e.g., after the Chinese National Day holiday I'll come back on Oct. 8th) to try to eliminate the workaround in this patch.

Sure, let's wait for the release.

Upgrade to 2.27.1 and eliminate the workaround. Wait for the new CI report and merge.

@flinkbot run azure

Although test fails should be unrelated, IIRC someone said you should get CI passed to merge a patch, lol. Rerun.


⚠ Bofrost.at has degraded performance

In f16d6e0, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 813 ms

Resolved: Bofrost.at performance has improved in cf6f4e8.


Update Tiling Overlap and No Image fields to reflect that they only accept point values

Currently, these fields appear as any other measurement field and accept strings. These parameters in the API require number datatype, but if a user submits a string it doesn't behave as a user expects.
Need to update the field descriptions to reflect that they accept values in Points, and also restrict the datatype to a number.

Fixed in https://github.com/tilialabs/tilia-phoenix-connect/commit/cf41e6cfa24a781c57afa021fdae3e91d96f6c11


lastest commit doesn't build

Hyprland Version
 System/Version info
<Paste the output of the command here>

Bug or Regression?
Bug
Description
udis86| CMake configuration: SUCCEEDED
udis86| CMake project udis86  has 3 build targets.
udis86| Generated Meson AST: /home/alek/.cache/paru/clone/hyprland-git/src/Hyprland/build/subprojects/udis86/meson.build
udis86| Project name: udis86
udis86| Project version: undefined
udis86| C compiler for the host machine: cc (gcc 13.2.1 "cc (GCC) 13.2.1 20230801")
udis86| C linker for the host machine: cc ld.bfd 2.42.0
udis86| Build targets in project: 138
udis86| Subproject udis86 finished.
Library execinfo found: NO
Found CMake: /usr/bin/cmake (3.29.2)
Run-time dependency epoll-shim found: NO (tried pkgconfig and cmake)
WARNING: You should add the boolean check kwarg to the run_command call.
It currently defaults to false,
but it will default to true in future releases of meson.
See also: https://github.com/mesonbuild/meson/issues/9300
Dependency wayland-protocols found: YES 1.35 (cached)
Run-time dependency hyprland-protocols found: NO (tried pkgconfig and cmake)
Looking for a fallback subproject for the dependency hyprland-protocols
Executing subproject hyprland-protocols
hyprland-protocols| Project name: hyprland-protocols
hyprland-protocols| Project version: 0.2
hyprland-protocols| Configuring hyprland-protocols.pc using configuration
hyprland-protocols| Build targets in project: 138
hyprland-protocols| Subproject hyprland-protocols finished.
Dependency hyprland-protocols found: YES 0.2 (overridden)
Dependency wayland-scanner found: YES 1.22.0 (cached)
Program /usr/bin/wayland-scanner found: YES (/usr/bin/wayland-scanner)
Build-time dependency hyprwayland-scanner found: YES 0.3.2
Program /usr/bin/hyprwayland-scanner found: YES (/usr/bin/hyprwayland-scanner)
protocols/meson.build:63:18: ERROR: File pointer-constraints-unstable-v1.xml does not exist.

Aborting...
error: failed to build 'hyprland-git-0.38.0.r105.582d6233-1':
error: packages failed to build: hyprland-git-0.38.0.r105.582d6233-1
How to reproduce
looks like it is missing pointer-constraints-unstable-v1.xml
Crash reports, logs, images, videos
No response

+1

Same issue here.

I am wondering about this new dependency upon epoll-shim

I am wondering about this new dependency upon epoll-shim

It isn't new and it's for the BSD bros

It isn't new and it's for the BSD bros. (You don't need it on linux)
After creating a PKGBUILD and installing it, I've realized that Linux users do not need this -_-

Same issue here.

It isn't new and it's for the BSD bros. (You don't need it on linux)

After creating a PKGBUILD and installing it, I've realized that Linux users do not need this -_-

I was in the middle of writing an ebuild and I saw this haha!

for future reference dont use meson we always prefer cmake (meson is just there because fuf prefers it for nix for whatever reason)


noteTweenY isn't working properly

Bug report
Hi,
I tried moving the arrows with Lua script and it works finde with the right arrow from boyfriend,
but the other arrows (left,down,up) aren't moving
Do I need to change something in the code?
(I noticed when I change the first defaultPlayerStrumY3 to something random then the up arrow can also move)
function onUpdate(elapsed)
	if curStep >= 0 and curStep < 769 then
		songPos = getSongPosition()
		local currentBeat = (songPos/1000)*(curBpm/60)

		noteTweenY(defaultPlayerStrumY0, 4, defaultPlayerStrumY0 + 16*math.cos((currentBeat+4*0.25)*math.pi), 0.1)
		noteTweenY(defaultPlayerStrumY1, 5, defaultPlayerStrumY1 + 16*math.cos((currentBeat+5*0.25)*math.pi), 0.1)
		noteTweenY(defaultPlayerStrumY2, 6, defaultPlayerStrumY2 + 16*math.cos((currentBeat+6*0.25)*math.pi), 0.1)
		noteTweenY(defaultPlayerStrumY3, 7, defaultPlayerStrumY3 + 16*math.cos((currentBeat+7*0.25)*math.pi), 0.1)
	end
end

I added a new option and a event on keypress but I don't think that this relates to the notes.(the new option just changes the rating system)

same


map storage by pallet name instead of prefix

This is not correct as pallet prefix can be changed between runtimes?, yet it is hardcoded in the generated code
Here is a plan.
....
Right, forgot about that.

By the way, which part should be backwards compatible? I thougth it was about runtime.description.storage[prefix]


Bounty - Allow multiple buttons to be mapped to one pin

While we may not want to have this be part of the main pin configuration, it would make for a neat add-on or addition to the extra button add-on.
The use case is for builds where controls can be simplified or condensed through the use of combo buttons.
An example of this is in the upcoming Sea of Stars game which uses one set of controls while exploring the world and one set while in combat.  Since the buttons in one do not affect the other they can be combined.  In this case Y and ZR can be mapped to the same pin to avoid having separate buttons.

This will be addressed in an upcoming pin mapping change - closing


[Modules] Added Web PubSub module

Description
Added a module and docs for Web PubSub implementing the following general features:

Private endpoints
Resource locks
RBAC

Type of Change
Please delete options that are not relevant.

[ ] Bugfix (non-breaking change which fixes an issue)
[X] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Update to documentation

Checklist

[X] I'm sure there are no other open Pull Requests for the same update/change
[X] My corresponding pipelines / checks run clean and green without any errors or warnings
[X] My code follows the style guidelines of this project
[X] I have commented my code, particularly in hard-to-understand areas
[X] I have made corresponding changes to the documentation (readme)
[X] I did format my code

Great contribution @itpropro, thanks. Just a few comments to align the module structure and add any missing files.


Windows11右键菜单！windows11右键菜单！说了多少遍了不知道加这个功能吗？

Windows11文件夹/文件右键菜单添加【通过 Code 打开】，求你了，没这功能体验至少打5折。
能找个会英语翻译一下我的 Issue 吗？

感谢您创建此问题！
然而，由于您没有使用英语，我们很难进行处理。如果可能，请您将此问题描述修改为英文。请您直接编辑此问题，不要提交回复或新问题。
请注意，机器翻译服务通常无法处理用于讨论软件问题所需的技术性语言，所以我们推荐您寻找一位熟悉相关技术的人来协助翻译。
如果您无法做到，没有关系。此问题已经被标记为需要翻译，等待社区成员志愿进行翻译。

Thanks for creating this issue!
Unfortunately, as the description is not in English, it's hard for us to work on. If possible, please edit the original issue to be in English.
In our experience, automatic translation services are not able to handle the technical language needed to effectively communicate about software issues, so we recommend finding a human translator who is familiar with our technology to help.
Otherwise, we have marked this as needing translation and a community member may be able to help out.

The option "Open in VSCode" in Windows 11 right-click menu.

The option "Open in VSCode" in Windows 11 right-click menu.

Thanks man.

Yup, totally agree with @jesse51076008, we totally need this, it is problematic as it needs a click on "More Options..." before we can finally open this folder in VSCode. That's a design flaw and an UI need for all devs that open a lot of different folders.

/duplicate of #127365

Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for similar existing issues. See also our issue reporting guidelines.
Happy Coding!


Sample SVG not rendering: official Firefox logo

The paths use numbers written in scientific notation
All fills are radial or linear gradients

Fixed by a1ba95e265a9c2928efff62a18aede3ca5b8c978
For this particular image, anyway. My SVG parser is really a hackjob. It doesn't really compare to yours. Your parser with my shader would probably make for pretty decent SVG rendering results. With the notable exception that my rendering model doesn't have a concept of "host coordinate system", since it's not painted inside a box, so any SVGs that try to be "responsive" would necessarily behave weird.

Yeah it looks like perhaps the coordinate space for some of the gradients is not being calculated correctly? Or maybe alpha values in the gradients are being treated as fully opaque?

Maybe it would make sense to merge these projects at some point, but I'm going to at least POC everything the mesh conversion approach can do first. I am curious if the path simplification + triangulation can be done fast enough for a sensible animation use case. So much of the code is "get it working" and not "get it running fast" right now.

Odd. It's working fine for me. Did you re-import it after getting on the latest patch? Godot can be annoying on re-import. It's usually necessary to turn the plugin on and off, and delete the .import file, then switch away from Godot and switch back, and only then it re-imports. If you try the "reimport" button it will usually ask for a (completely superfluous) restart.
The issue was that it was assuming gradient stop offsets are represented as percentage, so it was dividing everything by 100 unnecessarily. Note that representing as a percentage is valid, but only if the % sign appears

Oh, yeah reimport worked.


WinUI version schema sometime can't applied to MinVersion

Add PackageDependency like below:

Run into build error:
error : Error info: error C00CE169: App manifest validation error: The app manifest must be valid as per schema: Line 14, Column 51, Reason: '2.62101.13002' violates pattern constraint of '(0|[1-9][0-9]{0,3}|[1-5][0-9]{4}|6[0-4][0-9]{3}|65[0-4][0-9]{2}|655[0-2][0-9]|6553[0-5])(.(0|[1-9][0-9]{0,3}|[1-5][0-9]{4}|6[0-4][0-9]{3}|65[0-4][0-9]{2}|655[0-2][0-9]|6553[0-5])){3}'.

That version string passes the regex in the error message. I suspect MakeAppx has a bug that it's using different code to validate the string.
Regardless we will legitimately start failing this in WinUI 2.7 if we continue with this scheme for the package versions (because the 2nd component would be 7xxxx > 65535). So we'll need to do something soon. The framework package version doesn't really matter as long as it's always increasing. Maybe we just drop the major version out of the framework package version string and start the version with the minor component? Then the version is Minor.YYMM.DDRRR which will always fit in this scheme.

That version string passes the regex in the error message. I suspect MakeAppx has a bug that it's using different code to validate the string.
Regardless we will legitimately start failing this in WinUI 2.7 if we continue with this scheme for the package versions (because the 2nd component would be 7xxxx > 65535). So we'll need to do something soon. The framework package version doesn't really matter as long as it's always increasing. Maybe we just drop the major version out of the framework package version string and start the version with the minor component? Then the version is Minor.YYMM.DDRRR which will always fit in this scheme.

Will there be a 2.7 release?

This has been fixed.


Fix regression issue in Triton front end for the argument with None as input.

A quick fix to make the torch inductor work with the Triton LLVM target on Intel GPU.
I will upstream the fix formally to Triton repo with regression cases.

Where is the issue associated with this PR ? Create one if it does not exist and also create another one to remember to upstream.

I've linked an issue which track the fix.
@chengjunlu please create a new issue to track upstreaming.

#719 should have already fixed this issue.

Great. Close this PR and related issues.


The resolution is unable to recover when network quality is back to good or excellent

We are trying to use the SDK to build an Android app with 4G networking.
While the resolution seems ok at the beginning of the experiment (network state excellent), when the network quality dropped significantly to the poor state, the resolution also dropped, but when the network quality returned to excellent, the resolution did not increase.
Here is our setting:
const preset = VideoPresets.h720
  const [room] = useState(
    () =>
      new Room({
        dynacast: true,
        videoCaptureDefaults: {
          resolution: preset.resolution,

        },
        publishDefaults: {
          videoEncoding: preset.encoding,
          simulcast: false,
        },
      }),
  );

Move to https://github.com/livekit/livekit/issues/817


feat: add py client release action

Implemented an action to release a python client for our web API on push to main. This should be useful for the CLI to interact with our web platform @pfliu-nlp .
How to use it?

Copy the released whl file URL and run pip install https://github.com/neulab/explainaboard_web/releases/download/latest/explainaboard_api_client-1.0.0-py3-none-any.whl to install the python client. (Please replace the URL with the latest URL.
The generated package has a detailed README. I think it contains all the information.

This is just a quick implementation. Here are some things I think that may need more work on:

This repo doesn't have a version number so all the python clients released are tagged with "latest". I think pip will reinstall if the whl URL is different but it's not ideal because there's no obvious way of distinguishing versions. Also, I don't think GitHub will keep a roster of all the historical versions.
The generated client may be bad. I haven't really tested it.

cool! @lyuyangh I wonder if we also make this as a package that users can install from pypi or maybe here the way you implemented (using github action) is better?

cool! @lyuyangh I wonder if we also make this as a package that users can install from pypi or maybe here the way you implemented (using github action) is better?

Yeah! That's definitely a good idea. I wonder if users want to use the python client directly though.
For example, the client submits system output to the API in a base64 encoded string. If a user wants to use this client directly, they need to write their own code to encode files. If we have a user account system, it might also require extra work to make the client work with that.
I think it might be enough to release the CLI (a wrapper/UI for this client) on pypi? Maybe we could start another repo and build the CLI first and hold off on deciding if we need to release this client on pypi. What do you think?

I think we can set up a separate repo which only focuses on the python client features: here is one example project which does similar thing: https://github.com/ExpressAI/EaaS_API_dev, where two important scripts:

https://github.com/ExpressAI/EaaS_API_dev/blob/main/eaas/client.py
https://github.com/ExpressAI/EaaS_API_dev/blob/main/setup.py

I think we can set up a separate repo which only focuses on the python client features: here is one example project which does similar thing: https://github.com/ExpressAI/EaaS_API_dev, where two important scripts:

https://github.com/ExpressAI/EaaS_API_dev/blob/main/eaas/client.py
https://github.com/ExpressAI/EaaS_API_dev/blob/main/setup.py

Sounds good! Would this new repo also become the CLI that handles uploading system outputs, viewing analysis, etc?

"Sounds good! Would this new repo also become the CLI that handles uploading system outputs, viewing analysis, etc?"
Does it make sense? I think it would be a good feature for users who don't want to use sdk locally. Or do you think we have too many pips lol

"Sounds good! Would this new repo also become the CLI that handles uploading system outputs, viewing analysis, etc?"
Does it make sense? I think it would be a good feature for users who don't want to use sdk locally. Or do you think we have too many pips lol

I think that makes a lot of sense! I imagine we would have three repositories:

explainaboard_sdk (programmatic): the core analysis logic (loaders and processors). Users can run analysis locally with this SDK. They can also import the SDK to their training/eval code.
explainaboard_web (web UI and open API): provides a web-based platform for users to submit system outputs, visualize analysis and potentially share results with other users
explainaboard_cli (command-line interface): provides a terminal UI for users to submit system outputs and visualize analysis.

It can also allow users to run analysis locally if they don't want to share their system outputs. This feature is currently implemented in explainaboard_sdk. It's probably easier to implement it in the SDK so we could keep it that way for now. But I think maybe it would make sense to move it to the cli repo in the future.

This is actually quite similar to AWS. They have boto (SDK), web console, and AWS cli.
Dependency graph:
explainaboard_web -> explainaboard_sdk
explainaboard_cli -> explainaboard_web ->(indirect) explainaboard_sdk
explainaboard_cli -> explainaboard_sdk (if we want to move local analysis to the CLI in the future)
If you think this is good. I can go ahead and create a repo for the CLI.

Yeah, we can go with it. I usually like pythonic client based on web api. (based on that, we have eaas, which is a wrapper based on flask api, which is based on a python sdk)

I agree with @lyuyangh on the repositories and dependency graph. 👍 @lyuyangh Do you wanna open issues to keep track of the two todos you mentioned? The yml file looks good to me.

I agree with @lyuyangh on the repositories and dependency graph. 👍 @lyuyangh Do you wanna open issues to keep track of the two todos you mentioned? The yml file looks good to me.

Sounds good! I have created the CLI repo. Do you think we can merge this PR just so the CLI can get the latest version of the python client? We probably need to do more work in the future on the CI to add version (and maybe publish to pypi instead of a whl file on GitHub).

Yes, I agree. Merging now.


add speed up demonstration of datashader

Little benchmark to demonstrate in which cases it is helpful to use datashader to increase rendering speed

Thanks for the PR, this is very informative! Just a few minor comments:

[ ] I'd remove the variables mpl_sds and ds_sds as they are not used (also, maybe you have already seen, the developers don't recommend to compute these statistics https://docs.python.org/3/library/timeit.html#timeit.Timer.repeat).
[ ] The empirical indication that for ~1000 polygons on datashader is faster is very useful! Could you please also add a section to check this for points and circles?

Thanks a lot!

[ ] Regarding the failing docs, it seems that it can be fixed by using this myst configuration setting: https://github.com/executablebooks/MyST-Parser/issues/519#issuecomment-1037239655, in conf.py.

[ ]  Regarding the failing docs, it seems that it can be fixed by using this myst configuration setting: WARNING reference target not found, even though reference exists executablebooks/MyST-Parser#519 (comment), in conf.py.

We actually already seem to have that. Will try a html workaround

@Sonja-Stockhaus @LucaMarconato I fixed some things that were causing warnings in other notebooks. Apparently, this fixed it.

@Sonja-Stockhaus I modified your notebook slightly to have less redundant code. For testing I reduced the number of points. Will rerun over-night with enough Points to see the effect.
However, for merging I'd wait until your main PR is merged because I want these to be real version accessible from PyPi.

@timtreis ready to merge??

Not yet. On the one hand is datashader not faster for points, so that's weird. And then I wanted to first release sonjas feature branch so that the watermark has an actual release version attached and not a GitHub commit


sync: update ggml

ggml update is required to fix issues with FLUX.1 on Vulkan backend (https://github.com/leejet/stable-diffusion.cpp/pull/291#issuecomment-2306743114) and to improve performance. The fix was recently synced to ggml https://github.com/ggerganov/ggml/issues/938
EDIT: resolves #384 fixes #385

Should be fixed by https://github.com/leejet/stable-diffusion.cpp/pull/380


Fixes #3625 Add a static constant

Add a constant
What is the purpose of the change
Fixes #3625
Remove magic number 5 in line 92 of org.apache.dubbo.configcenter.support.zookeeper.CacheListener#childEvent.
Brief changelog
Add a static constant.
Verifying this change
XXXXX
Follow this checklist to help us incorporate your contribution quickly and easily:

[x] Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[x] Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
[x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
[x] Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
[ ] If this contribution is large, please follow the Software Donation Guide.

Codecov Report

Merging #3722 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master    #3722      +/-   ##
============================================
+ Coverage      63.6%   63.62%   +0.01%
  Complexity       71       71
============================================
  Files           703      703
  Lines         31001    31001
  Branches       5022     5022
============================================
+ Hits          19719    19723       +4
+ Misses         9016     9008       -8
- Partials       2266     2270       +4

Impacted Files
Coverage Δ
Complexity Δ

.../configcenter/support/zookeeper/CacheListener.java
62.16% <100%> (ø)
0 <0> (ø)
:arrow_down:

...apache/dubbo/common/config/ConfigurationUtils.java
64% <0%> (-8%)
0% <0%> (ø)

...ava/org/apache/dubbo/config/DubboShutdownHook.java
75% <0%> (-6.25%)
0% <0%> (ø)

.../apache/dubbo/remoting/transport/AbstractPeer.java
63.04% <0%> (-4.35%)
0% <0%> (ø)

...dubbo/remoting/exchange/support/DefaultFuture.java
73.46% <0%> (-2.05%)
0% <0%> (ø)

...che/dubbo/remoting/transport/mina/MinaChannel.java
53.94% <0%> (-1.32%)
0% <0%> (ø)

.../exchange/support/header/HeaderExchangeServer.java
66.98% <0%> (-0.95%)
0% <0%> (ø)

...pache/dubbo/registry/support/AbstractRegistry.java
80.7% <0%> (-0.4%)
0% <0%> (ø)

.../java/org/apache/dubbo/config/ReferenceConfig.java
60.72% <0%> (-0.37%)
0% <0%> (ø)

...exchange/support/header/HeaderExchangeHandler.java
62.79% <0%> (+2.32%)
0% <0%> (ø)
:arrow_down:

... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e4ff91...10ede29. Read the comment docs.


document job scheduling

The job scheduling is done by triggers whose logic is not that complicated but hard to understand without documentation.

When are which jobs triggered?

duplicate of #134


RoBERTa: Fix BOS token in encode

Sorry the format isn't super clear. Every sequence begins with a beginning-of-sentence (<s>) symbol. Every sentence ends with an end-of-sentence (</s>) and we use an extra end-of-sentence (</s>) as a separator.
Example (single sentence): <s> a b c </s>
Example (sentence pair): <s> d e f </s> </s> 1 2 3 </s>
So the current code should be correct.
The origin for this format is that we organized the training data as one sentence per line and and extra blank line between documents. We take chunks of tokens and prepend a single <s> at the beginning of each chunk.

I see. Thanks!


cawbird: backport gnutls patches fixing TLS connection issues

Motivation for this change
Cawbird suffers from frequent TLS connection issues due to a gnutls bug. I backported the fixes for TLS session resumption from gnutls master to gnutls-3.6.9 used in our stable branch. Cawbird now uses a vendored, patched gnutls.
I decided not to apply these changes to nixpkgs master, as gnutls-3.6.11 containing these fixes is supposed to be released in November 2019 and thus will land in the next stable release anyways.
already includes the backport of #72339
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Determined the impact on package closure size (by running nix path-info -S before and after): increased by 2965304 Bytes
[x] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Notify maintainers
cc @

Looks like this needs some further work, unfortunately not all TLS issues are resolved :(


Azure DevEx Architecture Board: Review of IC3 ACS Calling

New SDK Review meeting has been requested.
Service Name: IC3 ACS Calling
Review Created By: Jorge Garcia Hirota
Review Date: 2/8/2023 2:05 PM PT
Hero Scenarios Link: Not Provided
Architecture Diagram Link: Not Provided
Core Concepts Doc Link: Not Provided
APIView Links: .NET,
Description: GA version of the Windows SDK
Detailed meeting information and documents provided can be accessed here

Cancelled by: Jorge Garcia Hirota


Small refactor of ForeignClient::build_update_client* methods

Description

Improve legibility of loop condition when waiting for source chain to reach target_height
Use Option<Height>::None instead of Height::zero() in ForeignClient::build_update_client*` methods

For contributor use:

[ ] Updated the Unreleased section of CHANGELOG.md with the issue.
[ ] If applicable: Unit tests written, added test to CI.
[ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
[ ] Updated relevant documentation (docs/) and code comments.
[ ] Re-reviewed Files changed in the Github PR explorer.

Let's address this (#1009) all at once in another PR.


[flink] unaware-bucket table insert topology in flink engine

Flink insert topology for unaware-bucket table. We can assign compaction while inserting.
Topology will be like this:
compactor coordinator      ------->  compaction worker   -------> committer   <--------   writer  <-------- other input

Fixed comment and find out a way to disable fromEmptyWriter call from outside without add new method.
please review and check if the solution meet requests.

fixed expected


use tag instead of creating new commit when versioning

I changed the behaviours of finding current version and versioning

original way was using configed file to track version, I think using tag would be more straight forward. it returns 0.0.0 as default when it fails to find any version tag
instead of changing file content, I simply use tag to tract commits. I'm not sure this is a good way of versioning since I'm not a professional programmer.

Thanks you for submitting this. Why do you think this is a better approach?

Simply because it won’t touch any existed file & create a new commit for indicating a new version.
A tag for me is an additional marker to a commit, so I think this could keep git history only focuses on changes.

On 14 Mar 2016, at 17:07, Rolf Erik Lekang<EMAIL_ADDRESS>wrote:
Thanks you for submitting this. Why do you think this is a better approach?
—
Reply to this email directly or view it on GitHub https://github.com/relekang/python-semantic-release/pull/54#issuecomment-196160866.

Makes sense. How would this work with a package, e.g. a tarball, that does not contain the git history? If you unpack and run python setup.py <command> will it then default to '0.0.0'?
I guess it would be nice to have the choice between the two approaches, can you change your PR to add this as an option? With the old as default, I would like to test this a bit before considering changing the default behaviour.

Seems like a great option to have to work with tags only, as long as it's an option and not mandatory :)

if a dir is not a git repo, this will simply fail because of init part of the code
sure, I'll start working on it as an option ASAP

added a option for choosing versioning by commit or tag with the key: versioning_by_tag in the config file
it will version by using tag unless it is explicitly set True with versioning_by_tag

@relekang I'm having some problem with the tests. like the repo owner, I have to change it to me to pass the local test, but this will cause the ci test fail.
How should I solve this?

If the test is not related what you are working on leave it be :)
I think a few tests will be fixed if you rebase on master, could you please do that?

seems everything works fine after rebasing.
for the question about package you mentioned, I think it won't contain any version info in the package source code since it will not be automatically added/updated.
but version info could be contained in the file specified for it. I think this won't cause any issue. But I'm not a professional programmer, I'm not sure about it.

BTW, I think the doc is not very easy to understand for people like me. I tried days to setup travisci and other tool to work properly.
This tool is very useful if dev can setup a CI or workable environment.

What about renaming the option to version_source with variable and tag as options and add version_source=variable to defaults.cfg?

seems everything works fine after rebasing.

:+1:

BTW, I think the doc is not very easy to understand for people like me. I tried days to setup travisci and other tool to work properly.

Are you talking about this http://python-semantic-release.readthedocs.org/en/latest/automatic-releases/travis.html ?

@relekang I've made changes. But I'm facing a problem in writing a test.
Since using version_source as a string, I need to patch the configparser.get to return specific value some version_source while leave other untouched.

@relekang After a long absence, I finally have time to finish these tests. Can you review it?
😸

I hope to have time in the next few days. Thanks for your patience ✌

LGTM, thanks 👍


⚠ Mobitopup has degraded performance

In 85d63a2, Mobitopup (https://napcard.voz.tech) experienced degraded performance:

HTTP code: 200
Response time: 3901 ms

Resolved: Mobitopup performance has improved in 6aefbf9.


Examples

Actually the libraries dont have an example of use

Can you be more specific here?

@EisenbergEffect I believe @svzosorio want to say that each repo doesn't have much documentation (at least examples) of how to use the package. For example, aurelia-templating have lots of powerful stuff like managing DOM using ViewSlot and View and ViewFactory but in order to understand all that you  forced to look into code and tests.
And even though that's not enough. It's really a big issue. I was considering to use Aurelia for our new big project but because of lack of docs and existing mobile integration we will proceed with Angular's dirty checking and boilerplate. That's a pity to be honest

just to clarify expected result:
It would be nice to see several examples in README of how library/package can used

FYI, you need to realize that if you are using Aurelia's APIs a lot, you are using Aurelia incorrectly. You shouldn't need to know most of that. Aurelia favors writing plain JS, not calling Aurelia APIs for things. The exceptions are DI and routing which are mostly documented in our cheat sheet. The fetch client would be another case. It's not released on our docs site, but the readme contains documentation on how to use it.
Yes, I understand we need to have better API docs. But, it's important to realize that Aurelia is fundamentally different from other frameworks. If you are using our APIs directly a lot, you are probably doing it wrong. We need to find a way to communicate this better because I know a lot of developers aren't familiar with this idea and get the wrong impression.
Having said that, more docs are coming. They take time to write though.
I'm closing this since we have docs needs tracked in the documentation repo.

If you are using our APIs directly a lot, you are probably doing it wrong

@EisenbergEffect I don't think that this statement is correct for developers who want to create libraries based on Aurelia (e.g., mobile framework) or for developers who wants to replace one of the core components of Aurelia (like create a custom logger implementation which sends logs to server or own BindingLanguage).
Another example is if custom attribute which uses ViewSlot and BoundViewFactory and @templateController which are not documented by the way, however it'd be very handy to know/understand how it works so then that knowledge can be used for creating own custom attributes.
Or child containers... It's not clear how to create and assign child container to subset of DOM/components tree.
And there a lot of such advanced questions which are important for contributors, for people who want to write good quality code with Aurelia, extend it or replace some functionality.

@stalniy Yes, I agree with you. What I meant is that the typical application developer should not be messing with APIs while developing an app. Absolutely, component and plugin authors are more likely to work with those APIs. We have some new content coming. We are documenting all of that. Mostly it takes time to organize the content, write it and...we also have to build some technology to actually provide the docs in a readable format. So, we are working on all of that to various degrees now. We've got two new articles in the docs as of yesterday. I'll be blogging about that this week. We also have a new update to the "docs" technology itself which will make the TOC of each article more visible and make the docs a more pleasant reading experience. It will introduce "the hub" and be a key shift that will enable us to add other features for the community. We are also looking at how we can get code samples directly inside the API docs themselves and doing some technology experiments there. So, more is coming.

Very good discussion, with even better outcome :-)

At the time I wrote this had confusion with a part of the api, however looking at google code base and found the way to do it. I am excited using aurelia in my company and look forward to more articles about their use


Error executing Jupyter command 'notebook': [Errno 2] No such file or directory.

When I run a notebook cell I get "Error executing Jupyter command 'notebook': [Errno 2] No such file or directory."
I tried reinstalling ipykernel and using different conda environments / python versions and neither seemed to have nay effect.
Environment data

VS Code version: 1.75.1
Jupyter Extension version: 2023.1.2010391206
Python Extension version: v2023.2.0
MAC M1
Python version: 3.10.9
Tried both venv and conda
Jupyter server running: Local | Remote | N/A

Expected behaviour
from pathlib import Path

cell runs properly

Actual behaviour
from pathlib import Path

Failed to start the Kernel.
Jupyter server crashed. Unable to connect.
Error code from Jupyter: 1
Error executing Jupyter command 'notebook': [Errno 2] No such file or directory.

Steps to reproduce:
Use vscode versions above on mac m1 above install jupyter notebook and run a cell.
Logs
Error code from Jupyter: 1
Error executing Jupyter command 'notebook': [Errno 2] No such file or directory

  at Sm.rejectStartPromise (/Users/robertcampbell/.vscode/extensions/ms-toolsai.jupyter-2023.1.2010391206/out/extension.node.js:17:254981)
  at t._complete (/Users/robertcampbell/.vscode/extensions/ms-toolsai.jupyter-2023.1.2010391206/out/extension.node.js:17:255541)
  at t.n (/Users/robertcampbell/.vscode/extensions/ms-toolsai.jupyter-2023.1.2010391206/out/extension.node.js:2:700797)
  at t.__tryOrUnsub (/Users/robertcampbell/.vscode/extensions/ms-toolsai.jupyter-2023.1.2010391206/out/extension.node.js:2:701037)
  at t.complete (/Users/robertcampbell/.vscode/extensions/ms-toolsai.jupyter-2023.1.2010391206/out/extension.node.js:2:700930)
  at t._complete (/Users/robertcampbell/.vscode/extensions/ms-toolsai.jupyter-2023.1.2010391206/out/extension.node.js:2:699446)
  at t.complete (/Users/robertcampbell/.vscode/extensions/ms-toolsai.jupyter-2023.1.2010391206/out/extension.node.js:2:699145)
  at ChildProcess.<anonymous> (/Users/robertcampbell/.vscode/extensions/ms-toolsai.jupyter-2023.1.2010391206/out/extension.node.js:2:1800927)
  at Object.onceWrapper (node:events:646:26)
  at ChildProcess.emit (node:events:538:35)
  at ChildProcess._handle.onexit (node:internal/child_process:291:12)] {
category: 'jupyterconnection'
}

@robcamp-code Sorry you are running into this issue, this has been fixed in  the latest pre-release version of the Jupyter extension
Closing this issue as fixed, if the following does not work, please do let me know and I will re-open this issue, optionally please feel freel to re-open this issue or create a new one.
Instructions for testing the fix:
Open the extensions page, search for Jupyter and click the button Switch to Pre-Release Version
Similarly please install the Pre-Release version of the Python extension.


SSL Verification Error in sample_rag_langchain.ipynb using AzureSearch

Hi,
I am experiencing an SSL verification error while working with the sample_rag_langchain.ipynb notebook in the Python folder of the Document Intelligence Code Samples repository. Specifically, this occurs in the section where embeddings and indexes are created using Azure Search.
Error Details
When running the cell that uses the AzureSearch class, the following error is raised:
ServiceRequestError: [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: unable to get local issuer certificate (_ssl.c:1000)
Repository: Azure Samples Document Intelligence Code Samples
Folder:Python(v4.0)/Retrieval_Augmented_Generation_(RAG)_samples)
Notebook: sample_rag_langchain.ipynb
Platform: Running within a company portal, windows 11.
Issue
In the native Azure Search library, I typically resolve this issue by setting the parameter connection_verify=False. However, the langchain library does not seem to have an option to disable SSL verification.
Request
Could you please provide guidance or an update to the notebook/library to include an option to disable SSL verification for AzureSearch in the langchain library? This would help in bypassing the SSL certificate verification error.
Thank you for your assistance.

Hi @sureshmoon ,
We just updated langchain to enable you to specify this property. Once a new version of langchain is published, we'll update the sample to use this version so you can specify connection_verify when creating the azure search vector store


Video demo in carla

Hi, would you please share the code for video generation in your project page? Thanks for your reply.
To my understand, the demo code only work for nuScenens
python tools/analysis_tools/visualization.py --result-path /path/to/inference/results --save-path /path/to/save/visualization/results

May I ask if you successfully deployed it on carla?


Update ConversationBubble.tsx

I have Consolidated Class Names .Class names are consolidated to reduce repetition and make the code more readable.

What kind of change does this PR introduce? ( docs update, ...)

please merge this

This is how messages look after the change, please check the design, as avatar for human should be on the right side,
Thank you!

I suggest you sync with main as there is a conflict now, Thank you!


ePayment not captured in Magento backend

Another problem occurs when trying to use ePayments. It's possible to create an order without problems, but if I try to capture the order in the Magento backend an error occurs. That makes sense, because an ePayment is captured up front. The problem is that it's not possible to create an Invoice for an ePayment. Thus, it's also not possible to do a refund.

According to Martin:
You need to set "Auto capture" to yes when using a payment that gets captured immediately

Danny comment:
Some payment methods do no support authorize only. The way the gateway handles this is that a merchant who has their setup set to authorize only and using a payment method not support authorizations, the gateway will automatically change the payment type to paymentAndCapture.
This should be something that the plugin should react on accordingly since this is an abstraction between payment methods that the merchant should not need to be concerned about (and will in many instances result in them misconfiguring Magento due to them not understanding or forgetting this).
I believe the Magento 1 plugin takes this correctly into consideration.

Is this a Magento limitation or a limitation of the implementation?

Im not sure - As Magento are not documented at all, its quite hard to say whats excactly needs to be done, or if its actual possible.
Though in Denmark its not allowed to capture money before the product has actually being shipped

I can see, there is no capture state. So there is no state, to tell, if a payment is reserved or capture, so I don't think this bug is relevant.


RuntimeError: CUDA error: device-side assert triggered

I'm trying to do lora finetune, but encounter this problem.
I ran this on Colab:
!python finetune/lora.py --data_dir data --out_dir out --checkpoint_dir checkpoints/lmsys/vicuna-7b-v1.5 --precision bf16-true
The cell said:
Traceback (most recent call last):
File "/content/lit-gpt/finetune/lora.py", line 319, in
CLI(setup)
File "/usr/local/lib/python3.10/dist-packages/jsonargparse/_cli.py", line 85, in CLI
return _run_component(component, cfg_init)
File "/usr/local/lib/python3.10/dist-packages/jsonargparse/_cli.py", line 147, in _run_component
return component(**cfg)
File "/content/lit-gpt/finetune/lora.py", line 82, in setup
fabric.launch(main, data_dir, checkpoint_dir, out_dir)
File "/usr/local/lib/python3.10/dist-packages/lightning/fabric/fabric.py", line 834, in launch
return self._wrap_and_launch(function, self, *args, **kwargs)
File "/usr/local/lib/python3.10/dist-packages/lightning/fabric/fabric.py", line 920, in _wrap_and_launch
return to_run(*args, **kwargs)
File "/usr/local/lib/python3.10/dist-packages/lightning/fabric/fabric.py", line 925, in _wrap_with_setup
return to_run(*args, **kwargs)
File "/content/lit-gpt/finetune/lora.py", line 135, in main
train(fabric, model, optimizer, train_data, val_data, checkpoint_dir, out_dir, speed_monitor)
File "/content/lit-gpt/finetune/lora.py", line 156, in train
validate(fabric, model, val_data, tokenizer, longest_seq_length)  # sanity check
File "/usr/local/lib/python3.10/dist-packages/torch/utils/_contextlib.py", line 115, in decorate_context
return func(*args, **kwargs)
File "/content/lit-gpt/finetune/lora.py", line 241, in validate
logits = model(input_ids)
File "/usr/local/lib/python3.10/dist-packages/torch/nn/modules/module.py", line 1518, in _wrapped_call_impl
return self._call_impl(*args, **kwargs)
File "/usr/local/lib/python3.10/dist-packages/torch/nn/modules/module.py", line 1527, in _call_impl
return forward_call(*args, **kwargs)
File "/usr/local/lib/python3.10/dist-packages/lightning/fabric/wrappers.py", line 117, in forward
output = self._forward_module(*args, **kwargs)
File "/usr/local/lib/python3.10/dist-packages/torch/nn/modules/module.py", line 1518, in _wrapped_call_impl
return self._call_impl(*args, **kwargs)
File "/usr/local/lib/python3.10/dist-packages/torch/nn/modules/module.py", line 1527, in call_impl
return forward_call(*args, **kwargs)
File "/content/lit-gpt/lit_gpt/lora.py", line 525, in forward
x, * = block(x, (cos, sin), max_seq_length)
File "/usr/local/lib/python3.10/dist-packages/torch/nn/modules/module.py", line 1518, in _wrapped_call_impl
return self._call_impl(*args, **kwargs)
File "/usr/local/lib/python3.10/dist-packages/torch/nn/modules/module.py", line 1527, in _call_impl
return forward_call(*args, **kwargs)
File "/content/lit-gpt/lit_gpt/model.py", line 160, in forward
n_1 = self.norm_1(x)
File "/usr/local/lib/python3.10/dist-packages/torch/nn/modules/module.py", line 1518, in _wrapped_call_impl
return self._call_impl(*args, **kwargs)
File "/usr/local/lib/python3.10/dist-packages/torch/nn/modules/module.py", line 1527, in _call_impl
return forward_call(*args, **kwargs)
File "/content/lit-gpt/lit_gpt/rmsnorm.py", line 19, in forward
norm_x = torch.mean(x * x, dim=self.dim, keepdim=True)
RuntimeError: CUDA error: device-side assert triggered
CUDA kernel errors might be asynchronously reported at some other API call, so the stacktrace below might be incorrect.
For debugging consider passing CUDA_LAUNCH_BLOCKING=1.
Compile with TORCH_USE_CUDA_DSA to enable device-side assertions.
Thanks for your help!

My bad. I didn't change the checkpoint dir when preparing the data.


feat: lemmas about natDegree and Monic

Various lemmas about Polynomial.natDegree
Co-authored-by: Pratyush Mishra

I think that adding some API around divX will help here.  For instance, this is an alternative proof of natDegree_divX_eq_natDegree_tsub_one that uses neither Nontriviality nor NoZeroDivisors:
import Mathlib.Data.Polynomial.EraseLead
import Mathlib.Data.Polynomial.Inductions

open Polynomial

-- no NoZeroDivisors assumption
variable {R : Type u} [Semiring R] {p : R[X]} {a : R}

namespace Polynomial

@[simp]
theorem divX_zero : divX (0 : R[X]) = 0 := leadingCoeff_eq_zero.mp rfl

@[simp]
theorem divX_one : divX (1 : R[X]) = 0 := by
  ext
  simpa only [coeff_divX, coeff_zero] using coeff_one (_ + 1)

theorem divX_C_mul : divX (C a * p) = C a * divX p := by
  ext
  simp

theorem divX_X_pow : divX (X ^ n : R[X]) = if (n = 0) then 0 else X ^ (n - 1) := by
  cases n
  · simp
  · ext n
    simp [coeff_X_pow]

noncomputable
def divX_hom : R[X] →+ R[X] :=
{ toFun := divX
  map_zero' := divX_zero
  map_add' := fun _ _ => divX_add }

@[simp] theorem divX_hom_toFun : divX_hom p = divX p := rfl

theorem natDegree_divX_eq_natDegree_tsub_one : p.divX_hom.natDegree = p.natDegree - 1 := by
  nontriviality R  -- gets rid of the nontriviality assumption
  apply map_natDegree_eq_sub (φ := divX_hom)
  · intro f
    simpa [divX_hom, divX_eq_zero_iff] using eq_C_of_natDegree_eq_zero
  · intros n c c0
    rw [← C_mul_X_pow_eq_monomial, divX_hom_toFun, divX_C_mul, divX_X_pow]
    split_ifs with n0 <;> simp [n0]
    exact natDegree_C_mul_X_pow (n - 1) c c0

theorem natDegree_divX_le : p.divX.natDegree ≤ p.natDegree :=
(natDegree_divX_eq_natDegree_tsub_one).trans_le (Nat.pred_le _)

@adomani Do you have any opinion on whether divX should exist at all? All these lemmas seem great but I feel like I might want them for p /ₘ X as well, so why even have this function?

bors r+


Audio component with 0 frequency doesn't function as intended

Audio components with adjusted frequency to 0 should stop the played channel until the frequency has changed, but it seems that BASS only supports frequencies from 100Hz to 100000Hz only, 0 is the original rate of the channel, unsure if there's a way around it but there is a way to potentially fix that by setting channel volume to 0, but is actually a hacky way

Another way this can be done which seems better for a workaround is to pause the channel and resume it on frequency changes (probably OnStateChanged)

If this is to be corrected for, it should be local to bass components. I'm not sure how straightforward this would be to do (probably maintaining an internal pause state).

If this is to be corrected for, it should be local to bass components. I'm not sure how straightforward this would be to do (probably maintaining an internal pause state).

I believe that's what I said above, pausing on 0 frequency.


Add autocomplete

Resolves #6

Please merge when the API key has been added to netlify

@kpham841 I have added the API key. Please, fix merge conflicts.


adding option to not gaussian filter transforms in motion_correct

Hey Greg,
Thanks for the great repo!
When using the pipeline to register functional data, we expect the transforms to have occasional large deltas (when the live specimen tries to move). Under such circumstances, smoothing the transform with a Gaussian filter does more harm than good. I can set the sigma to be very small but that feels suboptimal - a median filter would be more fitting for this case, or simply the option to have no filtering at all.
I think this is where it is hard coded:
https://github.com/GFleishman/bigstream/blob/f8f003e483fb3e31c9601f8a643a94af524343ea/bigstream/motion_correct.py#L180
Would it be possible to expose this option to users when you have a second? (or tell me that I've missed an existing functionality :) ).
Thanks in advance!
Best,
Ginny

Hi Ginny,
I definitely agree, there should be multiple options for smoothing over time (including no smoothing) exposed to the user. I’m preparing for a two week trip and won’t be programming until I get back. I’m happy to add this when I’m back or if you’re motivated I’d also be happy to review and merge a pull request.

I believe Ginny closed this issue with a PR - thanks very much @vruetten !


webpackbin url is broken

Thanks for submitting an issue to RGL!
Please mark the type of this issue:

[x] Bug
[ ] Feature Request
[ ] Question

If you have a question or bug report, please use the WebpackBin Template
to demonstrate. It is much easier for us to help you if you do.
I cannot use above link or any link at the readme.md.

https://www.webpackbin.com/bins/-Kvr2qCxorvGMgVMxkmI


Add generic OIDC login option

:warning: Note on feature completeness :warning:
We are narrowing the scope of acceptable enhancements to DefectDojo in preparation for v3. Learn more here:
https://github.com/DefectDojo/django-DefectDojo/blob/master/readme-docs/CONTRIBUTING.md
Description
This adds the option of using a generic OIDC identity provider for login, rather than a specific one like Google, Keycloak, etc...
Test results
Ideally you extend the test suite in tests/ and dojo/unittests to cover the changed in this PR.
Alternatively, describe what you have and haven't tested.
Tested logging in using an OIDC identity provider
Documentation
Please update any documentation when needed in the documentation folder)
Checklist
This checklist is for your information.

[ ] Make sure to rebase your PR against the very latest dev.
[ ] Features/Changes should be submitted against the dev.
[ ] Bugfixes should be submitted against the bugfix branch.
[ ] Give a meaningful name to your PR, as it may end up being used in the release notes.
[ ] Your code is flake8 compliant.
[ ] Your code is python 3.11 compliant.
[ ] If this is a new feature and not a bug fix, you've included the proper documentation in the docs at https://github.com/DefectDojo/django-DefectDojo/tree/dev/docs as part of this PR.
[ ] Model changes must include the necessary migrations in the dojo/db_migrations folder.
[ ] Add applicable tests to the unit tests.
[ ] Add the proper label to categorize your PR.

Hi @dandersonsw are you able to back out the formatting changes that aren not directly related to this PR? It is making review a little challenging

Hi @Maffooch I was able to back out the formatting changes on all the files except for the documentation file. Hopefully that makes it easier to review. Happy to make further changes if needed. Thank you.

@dandersonsw Just kicked off the tests :crossed_fingers:


prediction can not extract answer from full_prediction

why prediction can not extract 'A' from full_prediction? the whole .json file all face such problem.

Could you kindly point me to the file please?

Problem solved. Thank you very much
---Original---
From: "Xingyu @.>
Date: Mon, Jul 15, 2024 22:17 PM
To: @.>;
Cc: "Ziyu<EMAIL_ADDRESS>Subject: Re: [zeyofu/BLINK_Benchmark] prediction can not extract answer fromfull_prediction (Issue #7)
Could you kindly point me to the file please?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: @.***>

Glad to hear that!


Refactor "under 5 minutes" vs "5 to 15 (over5)" pages and js logic

Changes
Remove over5.js, rename under5.js to index.js, consolidate logic into index.js.
Pass in a flag variable from the html pages to configure all the different behavior / tweaked html elements.
Fixed over5 link for http://time-calc-under-5.s3-website-us-west-2.amazonaws.com/ (although http://time-calc-under-5.s3-website-us-west-2.amazonaws.com/index.html is generally better)
Impact
The main takeaway here is that since there is now just 1 JS file, that massively simplifies future maintenance and ensuring unity between the under 5 minutes / 5 to 15 minutes pages' logic.
Also, index.html and over5.html are now identical minus the flag variable for a few function calls, which simplifies future maintenance as well.

Looks good on S3


Revert "Fix connection reuse by delaying a poll cycle. (#73)"

This reverts commit bc63ae726147638c2bbb8e5df08f49f488bb21be.
Signed-off-by: Piotr Sikora<EMAIL_ADDRESS>

@istio/release-managers-1-1

@howardjohn @duderino please merge this, we're going to build proxy with the reverted change, since we suspect it might be the source of the issues we're seeing.

Stale PR.


WIP: Expose Rancher authentication as a k8s authentication webhook endpoint

For issue: rancher/rancher/issues/13698
Related authentication service: https://github.com/erikwilson/rancher-kube-api-auth/tree/rke-remote-kubectl
TODO:

[X] Refactor api-auth service to golang standards
[X] Better vendoring in api-auth service
[X] Clean up Kubeconfig generation
[X] Cluster scoped tokens using rancher token types
[X] PRs for related dependencies
[ ] Tests

Can you rebase and rework your commits to make this easier to digest?
I think some of the rke vendor changes that are showing up in your PR are actually from unrelated RKE updates.
I'm mainly looking for:

rebase
separate vendor updates from non-vendor code commits
separate script/packaging changes from code changes
squash into logical commits, instead of  a bunch of WIP commits. You dont need to get overly granular. If most of the cod changes are interdependent, a single commit (excluding the things mentioned above) is fine.


[Errors - Console Spam & Kicks]

Details
Spigot Version:
Paper-88 (MC: 1.17.1)
please run /ep debug and attach a screenshot
------------=== EasyPrefix DEBUG ===------------
[20:44:43 INFO]: Version: 1.7.7
[20:44:43 INFO]: Groups/Subgroups: 9/7
[20:44:43 INFO]: Users cached: 2
[20:44:43 INFO]: Genders cached: 0
[20:44:43 INFO]: Bukkit Version: git-Paper-88 (MC: 1.17.1)
[20:44:43 INFO]: Java Version: 16
[20:44:43 INFO]: Version Name: 1.17.1-R0.1-SNAPSHOT
[20:44:43 INFO]: Storage: local
[20:44:43 INFO]: active EventHandler: 6
[20:44:43 INFO]: Client ID: bb5467c7-95a3-40ee-8666-bceac8e94689
Describe the bug
I have a couple of issues.

First when a player logs on or logs off there is massive console spam
Player Join Error: https://hastebin.com/odobadafow.properties
Player Leave Error: https://hastebin.com/dexowayofe.properties
The other is when I make a tag with a color code in the name of the tag when I attempt to define that tag for a player from in-game I am kicked off the server
Command I try to run: /easyp user ArZor settag §7§lAFK
Kick Message: [20:55:48 INFO]: ArZor lost connection: Internal Exception: java.lang.IllegalStateException: PlayerKickEvent may only be triggered synchronously.

Expected behavior
No console spam or kicks
Screenshots
N/A

Thank you!
This seems to be a 1.17 issue. I'll upload a fix in a couple of hours.


Angle port Cannot open include file: 'glext_explicit_context_autogen.inc' not found

Windows 10

Hi @mediabuff, thanks for posting this issue. Could you please provide the reproduce steps and error log?

Ping @mediabuff

Thanks for posting this issue. Please reopen this issue if it still be a problem for you.


Regro

Checklist

[ ] Used a personal fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

Add setuptools <72 requirement so build doesn't break.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.


[Bug] messageDeduplication.inactiveProducers keeps growing if keep creating and closing producers

Search before asking

[X] I searched in the issues and found nothing similar.

Version
3.0.2
Minimal reproduce step
Keep creating and closing producers.

What did you expect to see?
We need a mechanism to prevent PersistentTopic.messageDeduplication.inactiveProducers keeps growing.
What did you see instead?

Anything else?
No response
Are you willing to submit a PR?

[ ] I'm willing to submit a PR!

https://github.com/apache/pulsar/pull/21193


Release the https:: fix

Describe the bug
I have upgraded to the latest version and still have the issue fixed by #15. I am guessing the PR didn't make it to the release. currently uploading files will store them with broken urls.
To Reproduce
1- use latest version
2- use the following env variables
AWS_ACCESS_KEY_ID=
AWS_ACCESS_SECRET=
AWS_REGION='us-west-004'
AWS_BUCKET=
CDN_BASE_URL=
AWS_ENDPOINT='https://s3.us-west-004.backblazeb2.com'

3- upload a file
4- get a broken url
Expected behavior
Urls should not start with https::// but with https://

Version 4.2.0

Additional context
Currently the latest release attached source code doesn't contain the fix

You are absolutely right, it never made its way to a release, but it's now online, thanks for reminding me!


Data sharing delivery [10193]

Build status:

Relaunched jenkins on the correct FastDDS branch
Build status:

Build status:

Build status:

Test only fail because https://github.com/eProsima/Fast-DDS/pull/1607 is not yet merge. See http://jenkins.eprosima.com:8080/job/FastRTPS Docs Manual/702/

Test only fail because https://github.com/eProsima/Fast-DDS/pull/1607 is not yet merge. See http://jenkins.eprosima.com:8080/job/FastRTPS Docs Manual/702/

Build status:

Build status:

Build status:

Build status:

Build status:

Build status:

Build status:

Build status:


Raise an exception if trailer Root is not a dict

Fixes #218
Fixes #219

Have pushed all those changes

Thanks!


Introduce maven-dependency-plugin

 <plugin>
          <groupId>org.apache.maven.plugins</groupId>
          <artifactId>maven-dependency-plugin</artifactId>
          <version>3.1.1</version>
          <executions>
            <execution>
              <id>analyze</id>
              <goals>
                <goal>analyze-only</goal>
              </goals>
              <configuration>
                <failOnWarning>true</failOnWarning>
              </configuration>
            </execution>
          </executions>
        </plugin>

Probably should do this once https://github.com/hyperledger/quilt/pull/222 is merged.

This is complete and merged to master.


[Request]: Kaspersky Virus Removal Tool

Prerequisites

[X] I have searched all issues/PRs to ensure it has not already been reported or fixed.

Criteria

[X] Reasonably well-known and widely used (e.g. if it's a GitHub project, it should have at least 100 stars and/or 50 forks)
[X] English interface (or at least English documentation)
[X] Latest stable version
[X] Full version (i.e. not a trial version)
[X] Fairly standard install (e.g. uses a version-specific download URL, no elaborate pre/post install scripts)

Name
Kaspersky Virus Removal Tool
Description
Virus Removal Tool
Homepage
https://www.kaspersky.com/downloads/free-virus-removal-tool
Download Link(s)
https://www.kaspersky.com/downloads/free-virus-removal-tool
Some Indication of Popularity/Repute
Kaspersky.

Relates to #12228


fixtures used lazily are not detected

Hi,
after I run  pytest --dead-fixtures I get an output e.g.

To double check if ii is so, I run grep -r 'almost_uniform_1d' tests
and get
.
So, the fixtures are clearly used, but not detected, because of lazy loading.
This is the plugin I use for lazy loading https://github.com/TvoroG/pytest-lazy-fixture

@aaarrti if you see source of pytest-lazy-fixture, you can notice that it is getting the fixture value from the method getfixturevalue from the built-in request fixture that pytest frameworks provides. So if you do this manually without using this plugin you will end up with same results.
Few days ago I've made a patch to this behaviour to solve a similar problem that I had that is also related to the issue https://github.com/jllorencetti/pytest-deadfixtures/issues/28 but the PR is sill open: https://github.com/jllorencetti/pytest-deadfixtures/pull/38
This could be a good use case to test if the changes to support this are working as expected, or if they need to be modified again to also work with the plugin pytest-lazy-fixture, so please use the fork that I made and then tell me if it also helps to solve your problem. https://github.com/jonatrios/pytest-deadfixtures/tree/feature/add_support_for_parametrize_fixtures

So, I installed pytest-dead-fixture from source. Not this is what I get as an output:
INTERNALERROR>   File "/Users/artemsereda/anaconda3/envs/Quantus-3.9/lib/python3.9/site-packages/_pytest/main.py", line 269, in wrap_session
INTERNALERROR>     session.exitstatus = doit(config, session) or 0
INTERNALERROR>   File "/Users/artemsereda/anaconda3/envs/Quantus-3.9/lib/python3.9/site-packages/pytest_deadfixtures-3.0.0-py3.9.egg/pytest_deadfixtures.py", line 219, in show_dead_fixtures
INTERNALERROR>     param_fixtures = get_parametrized_fixtures(session, available_fixtures)
INTERNALERROR>   File "/Users/artemsereda/anaconda3/envs/Quantus-3.9/lib/python3.9/site-packages/pytest_deadfixtures-3.0.0-py3.9.egg/pytest_deadfixtures.py", line 128, in get_parametrized_fixtures
INTERNALERROR>     return [
INTERNALERROR>   File "/Users/artemsereda/anaconda3/envs/Quantus-3.9/lib/python3.9/site-packages/pytest_deadfixtures-3.0.0-py3.9.egg/pytest_deadfixtures.py", line 128, in <listcomp>
INTERNALERROR>     return [
INTERNALERROR>   File "/Users/artemsereda/anaconda3/envs/Quantus-3.9/lib/python3.9/site-packages/pytest_deadfixtures-3.0.0-py3.9.egg/pytest_deadfixtures.py", line 131, in <lambda>
INTERNALERROR>     lambda x: x.fixturedef.argname in params_values, available_fixtures
INTERNALERROR>   File "/Users/artemsereda/anaconda3/envs/Quantus-3.9/lib/python3.9/site-packages/pytest_lazyfixture.py", line 197, in __eq__
INTERNALERROR>     return self.name == other.name
INTERNALERROR> AttributeError: 'str' object has no attribute 'name'

Unfortunately I'm not aware of the internals neither of pytest nor of the plugin, but it looks to me like the problem is that
because of lazy loading during the pytest-dead-fixture scan the fixture object is not there, but only the name of it, namely str.
So, should it be a feature request to pytest-dead-fixture? Should this be consider a bug in pytest-lazy-fixture?
Or should I just close the issue, as it will not work out?


CLOUDSTACK-8830 - [Vmware] VM snapshot fails for 12 min after instance creation

Error - "failed to create snapshot for vm:i-84987-16119-VM due to null"
Reason - vm.getName() returning null after 10 min due to change in API behavior in vCenter 6.0.
The name for VM Power On task is null on VMware vCenter 6.0, whereas PowerOnVM_Task in vCenter 5.5. Tested it manually and could create VM snapshot after 12min of instance creation in vCentre 6.0 .

@maneesha-p you could extract the content of this if-condition into a method to test the TaskInfo object, making the code a little more reusable and allowing you to build up an isolated TestCase for this scenario.
if (info == null || info.getEntityName() == null || info.getName() == null) {
      continue;
}

@alexandrelimassantana Updated plz check.Thank you.

Hi @maneesha-p I see you did the extraction, but could you also write the method javadoc along with it? As simple as it is, it can help people understand it when using it.
Thanks for your time.

@alexandrelimassantana Updated the javadoc. Thank you.

@maneesha-p  can you fix the PR title and its description?

ACS CI BVT Run
Sumarry:
Build Number 106
Hypervisor xenserver
NetworkType Advanced
Passed=104
Failed=14
Skipped=4
The follwing tests have known issues
test_vpc_remote_access_vpn
test_vpc_site2site_vpn
test_01_test_vm_volume_snapshot
test_02_vpc_privategw_static_routes
test_03_rvpc_privategw_static_routes
test_04_change_offering_small
ContextSuite context=TestNiciraContoller>:setup
test_01_primary_storage_iscsi
test02_internallb_haproxy_stats_on_all_interfaces
test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80
ContextSuite context=TestDeployVM>:setup
test_04_extract_template
test_04_extract_Iso
test_07_list_default_iso
Link to logs Folder (search by build_no): https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0
Failed tests:
integration.smoke.test_privategw_acl.TestPrivateGwACL
test_01_vpc_privategw_acl Failing since 2 runs
integration.smoke.test_guest_vlan_range.TestDedicateGuestVlanRange
test_dedicateGuestVlanRange Failing since 6 runs
Skipped tests:
test_vm_nic_adapter_vmxnet3
test_deploy_vgpu_enabled_vm
test_06_copy_template
test_06_copy_iso
Passed test suits:
integration.smoke.test_deploy_vm_with_userdata.TestDeployVmWithUserData
integration.smoke.test_affinity_groups_projects.TestDeployVmWithAffinityGroup
integration.smoke.test_portable_publicip.TestPortablePublicIPAcquire
integration.smoke.test_over_provisioning.TestUpdateOverProvision
integration.smoke.test_global_settings.TestUpdateConfigWithScope
integration.smoke.test_scale_vm.TestScaleVm
integration.smoke.test_service_offerings.TestCreateServiceOffering
integration.smoke.test_loadbalance.TestLoadBalance
integration.smoke.test_routers.TestRouterServices
integration.smoke.test_reset_vm_on_reboot.TestResetVmOnReboot
integration.smoke.test_snapshots.TestSnapshotRootDisk
integration.smoke.test_deploy_vms_with_varied_deploymentplanners.TestDeployVmWithVariedPlanners
integration.smoke.test_network.TestDeleteAccount
integration.smoke.test_non_contigiousvlan.TestUpdatePhysicalNetwork
integration.smoke.test_deploy_vm_iso.TestDeployVMFromISO
integration.smoke.test_public_ip_range.TestDedicatePublicIPRange
integration.smoke.test_multipleips_per_nic.TestDeployVM
integration.smoke.test_regions.TestRegions
integration.smoke.test_affinity_groups.TestDeployVmWithAffinityGroup
integration.smoke.test_network_acl.TestNetworkACL
integration.smoke.test_pvlan.TestPVLAN
integration.smoke.test_volumes.TestCreateVolume
integration.smoke.test_ssvm.TestSSVMs
integration.smoke.test_nic.TestNic
integration.smoke.test_deploy_vm_root_resize.TestDeployVM
integration.smoke.test_resource_detail.TestResourceDetail
integration.smoke.test_secondary_storage.TestSecStorageServices
integration.smoke.test_vm_life_cycle.TestDeployVM
integration.smoke.test_disk_offerings.TestCreateDiskOffering

@maneesha-p please rebase against latest master and push -f, update on status of your PR

It would be nice if this is resolved. The issue still exists in 4.9

@maneesha-p can you rebase and push so we can get this PR green?  I would love some code review as well.  Thx...

ACS CI BVT Run
Sumarry:
Build Number 126
Hypervisor xenserver
NetworkType Advanced
Passed=73
Failed=0
Skipped=3
Link to logs Folder (search by build_no): https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0
Failed tests:
Skipped tests:
test_vm_nic_adapter_vmxnet3
test_static_role_account_acls
test_deploy_vgpu_enabled_vm
Passed test suits:
test_deploy_vm_with_userdata.py
test_affinity_groups_projects.py
test_portable_publicip.py
test_vpc_vpn.py
test_over_provisioning.py
test_global_settings.py
test_scale_vm.py
test_service_offerings.py
test_routers_iptables_default_policy.py
test_routers.py
test_reset_vm_on_reboot.py
test_snapshots.py
test_deploy_vms_with_varied_deploymentplanners.py
test_login.py
test_list_ids_parameter.py
test_public_ip_range.py
test_multipleips_per_nic.py
test_regions.py
test_affinity_groups.py
test_network_acl.py
test_pvlan.py
test_volumes.py
test_nic.py
test_deploy_vm_root_resize.py
test_resource_detail.py
test_secondary_storage.py
test_vm_life_cycle.py
test_disk_offerings.py

Hi @maneesha-p,
This is a really nice feature and would be nice to include it in latest version. If you're not planning to continue with this PR, do you mind if I continue with it, by opening a new PR with this changes and continue the contribution process?
Thanks

@nvazquez I have the impression that @maneesha-p is not working with ACS anymore.
I guess you can go ahead and proper code this changes into a PR to be merged into master. If you need any assistance, just give me a heads up.
When you create your PR you can add the following to your commit message:
This closes #798
Then, when your PR gets merged, this one will also be closed.

This bug would be a good fix to include for LTS.  Therefore, it should be re-targeted to the 4.9 branch.
@nvazquez are you planning to pick up this PR?  If not, I can get someone to pick it up in the next 1-2 weeks.

Hi @jburwell, yes, actually I was working on other PRs but now I can pick up this one, is it ok?


Submitting result data causes component reload in Chromium

We have the official JATOS 3.2.3 Docker image deployed behind an Apache reverse proxy that’s using the proxy and rewrite configuration taken from the JATOS docs. Whenever the client submits data from the second component in a study run, we are thrown out of the study with the message:
It's not allowed to reload this component (ID: 37). Unfortunately it is neccessary to finish this study (ID: 8) at this point.

This is when the respective component has »allow reload« unset. When reloading is allowed, submitting data for the second component in a run will cause the current component to be reloaded (as opposed to proceeding to the next component in the run). I would assume that this is the underlying issue and the »not allowed to reload« error is just a side-effect.
I can reproduce this issue when using Chromium, e.g. with the jQuery UI example study and the survey.js UI example. When using Firefox, everything appears to work as expected.
The issue does not arise on the cortex.jatos.org installation (which looks like it’s runnig behind nginx), so this might be a deployment issue. However, jatos/test does not indicate issues and the websocket rewriting appears to work. Perhaps you can advise as to what might be causing this.

I’m attaching the access log when using Chromium (and Firefox for comparison). This shows HTTP  requests starting with the opening of the worker link. We submit data to the first component successfully, then we submit data for the second component, upon which we run into the reload error.
chromium.txt
firefox.txt

Okay, hopefully I have this figured out. Our server is adding Expires resp. Cache-Control headers. It appears that JATOS is issuing a GET for the same /nextComponent resource after each component in a study run, which will then do a redirect based on the study run state. I could also find the header on the JATOS responses to /nextComponent, which, I presume, is because GET is supposed to be idempotent. Chromium would then feel free to serve this request from the cache, which leads to us reloading the second component in the study run.
Would it make sense for JATOS to implement this differently, perhaps using POST (which does not presuppose idempotency), or using GET against a resource that also encodes study state? This should then prevent the caching issue.
I’m not quite sure, but shouldn’t this issue also arise when workers have a regular (forward) proxy between their browser and our JATOS instance, even when the server does not set any headers?
As a work-around, one can disable cache headers based on virtual hosts, at least in the reverse proxy case.

Solved in JATOS v3.3.1


NativeAOT support

It would be great if NativeAOT compilation would be supported by the library.
This would give the benefits of faster execution, and possibility to build native library (DLL) which can then be linked by any other program (regardless of programming language).
Right now, I get this error for most of demos:
Unhandled Exception: Google.Protobuf.InvalidProtocolBufferException: Protocol message contained an invalid tag (zero).
   at Google.Protobuf.ParsingPrimitives.ParseTag(ReadOnlySpan`1&, ParserInternalState&) + 0x133
   at CNETMsg_Tick.pb::Google.Protobuf.IBufferMessage.InternalMergeFrom(ParseContext&) + 0x1f
   at Google.Protobuf.MessageExtensions.MergeFrom(IMessage, ReadOnlySpan`1, Boolean, ExtensionRegistry) + 0xdb
   at Google.Protobuf.MessageParser`1.ParseFrom(ReadOnlySpan`1) + 0x2f
   at DemoFile.PacketEvents.ParseNetMessage(Int32, ReadOnlySpan`1) + 0xd3
   at DemoFile.DemoParser.OnDemoPacket(CDemoPacket msg) + 0x328
   at DemoFile.DemoEvents.ReadDemoCommand(EDemoCommands, ReadOnlySpan`1) + 0x1cf
   at DemoFile.DemoParser.<Start>d__46.MoveNext() + 0x824
--- End of stack trace from previous location ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw() + 0x20
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task) + 0xb6
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task) + 0x42
   at Program.<Main>d__0.MoveNext() + 0x2b6
--- End of stack trace from previous location ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw() + 0x20
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task) + 0xb6
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task) + 0x42
   at Program.<Main>(String[]) + 0x20
   at DemoFile.Example.Basic!<BaseAddress>+0x44a35b

It could be a bug in Google.Protobuf library, but I did not investigate further, for now.

nice job 👍

It's worth noting, from my benchmarks on an M1 MacBook Pro/.NET 8, Native AOT is slower than JIT when parsing a whole demo. I'd be interested to know if you see differently.

I did some measurements. For each runtime, I made a separate publish, then ran it from command line a couple of times (I didn't use BenchmarkDotNet).
I'm using win11 x64. All runs use navi-javelins-vs-9-pandas-fearless-m1-mirage.dem.

Runtime
Average

.NET 7
3.8 s

.NET 8
4.1 s

.NET 7 AOT
2.2 s

.NET 8 AOT
1.95 s

.NET 8 AOT with <OptimizationPreference>Speed</OptimizationPreference>
1.9s

It seems as AOT is twice as fast ? Am i missing something ? Also, you mentioned in Readme that you can parse 1 hour of gameplay in 1.5 sec, which doesn't seem possible for me.

You'll be measuring app startup time there too, which Benchmark.Net specifically excludes. Also process startup time on Windows is very slow compared to Unix-based OSes.
Suggest using Benchmark.Net (with the DemoFile.Benchmark project) to benchmark. Otherwise you're also testing your OS, antivirus and disk read speeds.

Sorry, I forgot to mention how I measure time. This is the running process:
public static async Task Main(string[] args)
{
    var path = args.SingleOrDefault() ?? throw new Exception("Expected a single argument: <path to .dem>");

    var stream = File.OpenRead(path);

    var sw = Stopwatch.StartNew();

    var demo = new DemoParser();

    await demo.Start(stream);

    var elapsedMs = sw.ElapsedMilliseconds;
    Console.WriteLine($"\nFinished!, elapsed {elapsedMs} ms, tick {demo.CurrentDemoTick.Value}");
}

As you can see, I measure only the processing time, no events, no file stream opening, etc.

Ok, it turns out I was measuring only the 1st run :D
So probably .NET runtime needs to warmup. After warmup, they run for ~1.6s. As for AOT, it runs for ~1.7s, so yeah it's slightly slower.


Administrator are lacking some privileges

How to categorize this issue?

/area user-management
/kind enhancement
/priority normal
What would you like to be added:
Currently, users bound to the gardener.cloud:system:administrators ClusterRole are not able to access events in the events.k8s.io API group.
When debugging one particular issue around events, I missed those permissions.
As an operator I would like to either have full access to all API groups or at least to all API groups, that I need to investigate some issues.
There might be a reason for not given operators full admin access, though I'm not sure, what the current argument for this is.
/assign @mvladev @donistz
Can you comment on that and clarify here?
Why is this needed:

There might be a reason for not given operators full admin access, though I'm not sure, what the current argument for this is.

@donistz @mvladev Can somebody elaborate on that and quickly clarify the reasons here?

From a security standpoint is better to remove add permissions as your go than to remove them post factum.


bin/brew: never use HOMEBREW_PATH from users.

Fixes https://github.com/Homebrew/brew/issues/13548

Review period skipped due to critical label.


chore: re-export vector index request types

ALL_VECTOR_METADATA and SimilarityMetric were not re-exported from the
libraries in the previous commit. This commit re-exports them from the sdk libraries.

ALL_VECTOR_METADATA and SimilarityMetric were not re-exported from the
libraries in the previous commit. This commit re-exports them from the sdk libraries.


Add blt namespace alias targets to mpi, cuda, cuda_runtime, and openmp

This creates an ALIAS target to the following targets:

cuda -> blt::cuda (done in a previous PR)
cuda_runtime -> blt::cuda_runtime (done in a previous PR)
mpi -> blt::mpi
openmp -> blt::openmp

Also updates documentation and internal tests to use the targets.
Note: I would like to do a breaking release of BLT soon and plan to rename the underlying targets to blt_<name>.

+1 to also changing the underlying targets to blt_{target}


Update heap_sort.cpp

The recursion root node in function 'heapify' should be the swapped one instead of length.
Description of Change

Checklist

[x] Added description of change

Notes:

The present implementation seems correct to me and works correctly.
What is the need for the change?
could you elaborate on the description?
@haowei790818

Hello


Cloning nodes in Machine Pools Page in Cluster details page in Cluster management results in removal of the existing node

On master-head commit id: 2e6926b

Deploy an RKE1 cluster - 1 etcd, 3 worker and 1 control plane
Go to cluster details page --> Machine pools
On the ellipsis for the worker nodes, click on Clone
Enter a name and select save.
Existing node gets removed and re provisioned.
And a new node also starts provisioning

Expected:
Existing node should not get removed.

Looks like some connection to https://github.com/rancher/dashboard/issues/3542 as well.

I'll disable the action, you can't really clone a machine (or node).. there's all sorts of references to secrets and other CAPI resources that still point to the old one because you didn't change them.

On master-head commit id: 94bca99

Deploy an RKE1/RKE2 cluster - 1 etcd, 3 worker and 1 control plane
Go to cluster details page --> Machine pools
On the ellipsis for the worker nodes, Clone option is not available


Use (more of) unambiguous float32 values

The same reason as for #516.

CI is failing, how can I fix that? It does not seem closely related to the changes that I made.
error: ✘ Deprecated: version: property is deprecated in @service. If wanting to describe a service versioning you can use the `@typespec/versioning` library. If wanting to describe the project version you can use the package.json version.: /home/runner/work/cadl-ranch/cadl-ranch/packages/cadl-ranch-specs/http/client/structure/common/service.tsp:32:3
error: ✘ ✘ Scenario client/structure/two-operation-group is invalid.
debug: Found scenario "/home/runner/work/cadl-ranch/cadl-ranch/packages/cadl-ranch-specs/http/client/structure/renamed-operation/client.tsp"
error: ✘ Deprecated: version: property is deprecated in @service. If wanting to describe a service versioning you can use the `@typespec/versioning` library. If wanting to describe the project version you can use the package.json version.: /home/runner/work/cadl-ranch/cadl-ranch/packages/cadl-ranch-specs/http/client/structure/common/service.tsp:32:3
error: ✘ ✘ Scenario client/structure/renamed-operation is invalid.
debug: Found scenario "/home/runner/work/cadl-ranch/cadl-ranch/packages/cadl-ranch-specs/http/client/structure/multi-client/client.tsp"
error: ✘ Deprecated: version: property is deprecated in @service. If wanting to describe a service versioning you can use the `@typespec/versioning` library. If wanting to describe the project version you can use the package.json version.: /home/runner/work/cadl-ranch/cadl-ranch/packages/cadl-ranch-specs/http/client/structure/common/service.tsp:32:3
error: ✘ ✘ Scenario client/structure/multi-client is invalid.
debug: Found scenario "/home/runner/work/cadl-ranch/cadl-ranch/packages/cadl-ranch-specs/http/client/structure/default/client.tsp"
error: ✘ Deprecated: version: property is deprecated in @service. If wanting to describe a service versioning you can use the `@typespec/versioning` library. If wanting to describe the project version you can use the package.json version.: /home/runner/work/cadl-ranch/cadl-ranch/packages/cadl-ranch-specs/http/client/structure/common/service.tsp:32:3

I think the cause is this
https://github.com/Azure/cadl-ranch/blob/7886a78b50ff297f9a1d3cb814152c231f17e5bb/packages/cadl-ranch-specs/http/client/structure/common/service.tsp#L32
May need to change to this @versioned + a Versions (name not matter) enum.
https://github.com/Azure/cadl-ranch/blob/7886a78b50ff297f9a1d3cb814152c231f17e5bb/packages/cadl-ranch-specs/http/resiliency/srv-driven/main.tsp#L10
@qiaozha for comment

Yeah this is just a test checking against latest dev version I need to update the specs. And no let's just remove the version property that should not be used, let's not use versioning everywhere and complexity every spec

should we remove @service.version after the new typespec is released or should we fix it now ?

should we remove @service.version after the new typespec is released or should we fix it now ?

we can do it now, removing here https://github.com/Azure/cadl-ranch/pull/528

Thanks!


htlcswitch: batch preimage writes/consistency fix

This PR adds batched writes for witnesses discovered in HTLC forwarding. At the same time, we correct a nuanced consistency issue related to a lack of synchronization with the channel state machine. Forcing the individual preimage writes to be synchronized with the link incurs a heavy performance penalty (about 80% from my measurements). Batching these allows us to minimize the number of db transactions required to write the preimages, allowing us to reinsert the batched write into the link's critical path and resolve the possible inconsistency. In fact, the benchmarks actually showed a slight performance improvement, even with the extra write in the critical path.
See commit messages for more details.

@joostjager @halseth ready for another round of review. the changes sprawled quite a bit as you'll see. I've also moved the lntypes
I plan to consolidate 696a5f9 (the move to lntypes) and d47aa70 (first commit), but wanted to get your feedback on the additional commits before doing so.
Along the way:

lnmock is born, avoiding the same mockPreimageCache implementation in 4 places in the code base.
lntypes is moved to lnhash
'channeldb.WitnessCachegained theAddSHA256Witnesseshelper, to avoid the extra copied in thepreimageBeacon`
modfiied the channeldb/witness_cache_test to test batch insertion
added a link-level test to assert that the changes in htlcswitch/link.go behave as expected.

ptal

@joostjager @halseth comments addressed and commits restructured, ptal

@joostjager revamped the witness cache to only expose the specific interface, makes everything much cleaner imo, ptal

note: planning to squash channeldb+witness_beacon: use sha256 lookup+delete witness down into channeldb/witness_cache: create AddSHA256Witnesses helper + test

@halseth @joostjager i took out the commits that removed the preimage cache from lnwallet, should be a little more contained now. it still includes the commits that make the switch to lntypes as requested, ptal


mobile/ci: Set large for swift tests by default

Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

seems this didnt solve the problem
INFO: 6065 processes: 5231 remote cache hit, 701 internal, 15 darwin-sandbox, 3 local, 115 remote.
//test/swift/cxx:test                                                   TIMEOUT in 904.1s
  /private/var/tmp/_bazel_runner/38952b625e1e7c72284b0f9be4a35639/execroot/envoy_mobile/bazel-out/darwin-fastbuild/testlogs/test/swift/cxx/test/test.log
//test/swift/integration:cancel_grpc_stream_test                        TIMEOUT in 904.7s
  /private/var/tmp/_bazel_runner/38952b625e1e7c72284b0f9be4a35639/execroot/envoy_mobile/bazel-out/darwin-fastbuild/testlogs/test/swift/integration/cancel_grpc_stream_test/test.log
//test/swift/integration:cancel_stream_test                             TIMEOUT in 906.7s
  /private/var/tmp/_bazel_runner/38952b625e1e7c72284b0f9be4a35639/execroot/envoy_mobile/bazel-out/darwin-fastbuild/testlogs/test/swift/integration/cancel_stream_test/test.log
//test/swift/integration:filter_reset_idle                              TIMEOUT in 902.3s
  /private/var/tmp/_bazel_runner/38952b625e1e7c72284b0f9be4a35639/execroot/envoy_mobile/bazel-out/darwin-fastbuild/testlogs/test/swift/integration/filter_reset_idle/test.log
//test/swift/integration:receive_data_test                              TIMEOUT in 902.0s
  /private/var/tmp/_bazel_runner/38952b625e1e7c72284b0f9be4a35639/execroot/envoy_mobile/bazel-out/darwin-fastbuild/testlogs/test/swift/integration/receive_data_test/test.log
//test/swift/integration:receive_error_test                             TIMEOUT in 903.2s
  /private/var/tmp/_bazel_runner/38952b625e1e7c72284b0f9be4a35639/execroot/envoy_mobile/bazel-out/darwin-fastbuild/testlogs/test/swift/integration/receive_error_test/test.log
//test/swift/integration:reset_connectivity_state_test                  TIMEOUT in 904.0s
  /private/var/tmp/_bazel_runner/38952b625e1e7c72284b0f9be4a35639/execroot/envoy_mobile/bazel-out/darwin-fastbuild/testlogs/test/swift/integration/reset_connectivity_state_test/test.log
//test/swift/integration:send_headers_test                              TIMEOUT in 905.6s
  /private/var/tmp/_bazel_runner/38952b625e1e7c72284b0f9be4a35639/execroot/envoy_mobile/bazel-out/darwin-fastbuild/testlogs/test/swift/integration/send_headers_test/test.log
//test/swift/integration:set_event_tracker_test                         TIMEOUT in 904.1s
  /private/var/tmp/_bazel_runner/38952b625e1e7c72284b0f9be4a35639/execroot/envoy_mobile/bazel-out/darwin-fastbuild/testlogs/test/swift/integration/set_event_tracker_test/test.log
//test/swift:test                                                         FLAKY, failed in 1 out of 2 in 904.6s
  Stats over 2 runs: max = 904.6s, min = 9.2s, avg = 456.9s, dev = 447.7s
  /private/var/tmp/_bazel_runner/38952b625e1e7c72284b0f9be4a35639/execroot/envoy_mobile/bazel-out/darwin-fastbuild/testlogs/test/swift/test/test_attempts/attempt_1.log
//test/swift/stats:test                                                   FLAKY, failed in 1 out of 2 in 903.5s
  Stats over 2 runs: max = 903.5s, min = 8.9s, avg = 456.2s, dev = 447.3s
  /private/var/tmp/_bazel_runner/38952b625e1e7c72284b0f9be4a35639/execroot/envoy_mobile/bazel-out/darwin-fastbuild/testlogs/test/swift/stats/test/test_attempts/attempt_1.log

https://github.com/envoyproxy/envoy/actions/runs/8020087565/job/21909202193#step:8:1150
just made it take longer


Python: interpreter changes and package updates

Motivation for this change

[x] Includes https://github.com/NixOS/nixpkgs/pull/39555
[x] Patch level updates.
[x] bootstrapped-pip updates

Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Fits CONTRIBUTING.md.

https://hydra.nixos.org/jobset/nixpkgs/python-unstable

Success on aarch64-linux (full log)
Attempted: python
Partial log (click to expand)
/nix/store/3zc1jxxz3xg93bvsp0gapm9pib9s054l-python-2.7.15

Success on x86_64-linux (full log)
Attempted: python
Partial log (click to expand)
these paths will be fetched (7.69 MiB download, 44.61 MiB unpacked):
  /nix/store/k87hjw6klpxg957mllvh7zvr14hw2v1w-python-2.7.15
copying path '/nix/store/k87hjw6klpxg957mllvh7zvr14hw2v1w-python-2.7.15' from 'https://cache.nixos.org'...
/nix/store/k87hjw6klpxg957mllvh7zvr14hw2v1w-python-2.7.15

Success on x86_64-linux (full log)
Attempted: busybox, python
Partial log (click to expand)
--------------------------------------------------

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/prx9hccshs6cz9n92fpzh8gsnfimckbf-busybox-1.28.4
shrinking /nix/store/prx9hccshs6cz9n92fpzh8gsnfimckbf-busybox-1.28.4/bin/busybox
strip is /nix/store/92d2ifxcni4n3zx9s8wnkcjlvnx5ajlc-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/prx9hccshs6cz9n92fpzh8gsnfimckbf-busybox-1.28.4/bin  /nix/store/prx9hccshs6cz9n92fpzh8gsnfimckbf-busybox-1.28.4/sbin
patching script interpreter paths in /nix/store/prx9hccshs6cz9n92fpzh8gsnfimckbf-busybox-1.28.4
checking for references to /build in /nix/store/prx9hccshs6cz9n92fpzh8gsnfimckbf-busybox-1.28.4...
moving /nix/store/prx9hccshs6cz9n92fpzh8gsnfimckbf-busybox-1.28.4/sbin/* to /nix/store/prx9hccshs6cz9n92fpzh8gsnfimckbf-busybox-1.28.4/bin

Success on aarch64-linux (full log)
Attempted: busybox, python
Partial log (click to expand)
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/rwkp3ip28d0w6idpw19k1cx3jhv0fscw-busybox-1.28.4
shrinking /nix/store/rwkp3ip28d0w6idpw19k1cx3jhv0fscw-busybox-1.28.4/bin/busybox
strip is /nix/store/8yfik687kfccisxnad42j19lfb7ij9b4-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/rwkp3ip28d0w6idpw19k1cx3jhv0fscw-busybox-1.28.4/bin  /nix/store/rwkp3ip28d0w6idpw19k1cx3jhv0fscw-busybox-1.28.4/sbin
patching script interpreter paths in /nix/store/rwkp3ip28d0w6idpw19k1cx3jhv0fscw-busybox-1.28.4
checking for references to /build in /nix/store/rwkp3ip28d0w6idpw19k1cx3jhv0fscw-busybox-1.28.4...
moving /nix/store/rwkp3ip28d0w6idpw19k1cx3jhv0fscw-busybox-1.28.4/sbin/* to /nix/store/rwkp3ip28d0w6idpw19k1cx3jhv0fscw-busybox-1.28.4/bin
/nix/store/rwkp3ip28d0w6idpw19k1cx3jhv0fscw-busybox-1.28.4
/nix/store/3zc1jxxz3xg93bvsp0gapm9pib9s054l-python-2.7.15

Success on x86_64-linux (full log)
Attempted: python
Partial log (click to expand)
/nix/store/k87hjw6klpxg957mllvh7zvr14hw2v1w-python-2.7.15

Success on aarch64-linux (full log)
Attempted: python
Partial log (click to expand)
/nix/store/3zc1jxxz3xg93bvsp0gapm9pib9s054l-python-2.7.15

Failure on x86_64-darwin (full log)
Attempted: python
The following builds were skipped because they don't evaluate on x86_64-darwin: busybox
Partial log (click to expand)
cannot build derivation '/nix/store/gmrwvzv1bw7012f6zrycvd58gmxradzh-python-2.7.15.drv': 14 dependencies couldn't be built
cannot build derivation '/nix/store/fkg25s6azcqrx6ckq0v70qz8q43ggvf5-libtool-2.4.6.drv': 5 dependencies couldn't be built
cannot build derivation '/nix/store/4azlamj6nijycwyzqycpvl71f3ia78v3-hook.drv': 6 dependencies couldn't be built
cannot build derivation '/nix/store/66yg6w5crh04v6s2g3859bzwiccsvbba-flex-2.6.4.drv': 7 dependencies couldn't be built
cannot build derivation '/nix/store/6j60v5b8cs7g33bsa1s72qhkahdxybdj-bootstrap_cmds-dev-tools-7.0.drv': 4 dependencies couldn't be built
cannot build derivation '/nix/store/jd9xb7lwas4xkyws8m13ynn9lz821rqg-xnu-osx-10.11.6.drv': 9 dependencies couldn't be built
cannot build derivation '/nix/store/n5c1sm0a3lg9sr9zmg6djl93xbndlpcy-IOKit-osx-10.11.6.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/f70a8fnffw2gkypa089rihw85ni5al55-configd-osx-10.8.5.drv': 9 dependencies couldn't be built
cannot build derivation '/nix/store/a4frgav02bkqngk23psf4kk0drff6a7i-python-2.7.15.drv': 15 dependencies couldn't be built
error: build of '/nix/store/a4frgav02bkqngk23psf4kk0drff6a7i-python-2.7.15.drv' failed

Failure on x86_64-darwin (full log)
Attempted: python
Partial log (click to expand)
cannot build derivation '/nix/store/gmrwvzv1bw7012f6zrycvd58gmxradzh-python-2.7.15.drv': 14 dependencies couldn't be built
cannot build derivation '/nix/store/fkg25s6azcqrx6ckq0v70qz8q43ggvf5-libtool-2.4.6.drv': 5 dependencies couldn't be built
cannot build derivation '/nix/store/4azlamj6nijycwyzqycpvl71f3ia78v3-hook.drv': 6 dependencies couldn't be built
cannot build derivation '/nix/store/66yg6w5crh04v6s2g3859bzwiccsvbba-flex-2.6.4.drv': 7 dependencies couldn't be built
cannot build derivation '/nix/store/6j60v5b8cs7g33bsa1s72qhkahdxybdj-bootstrap_cmds-dev-tools-7.0.drv': 4 dependencies couldn't be built
cannot build derivation '/nix/store/jd9xb7lwas4xkyws8m13ynn9lz821rqg-xnu-osx-10.11.6.drv': 9 dependencies couldn't be built
cannot build derivation '/nix/store/n5c1sm0a3lg9sr9zmg6djl93xbndlpcy-IOKit-osx-10.11.6.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/f70a8fnffw2gkypa089rihw85ni5al55-configd-osx-10.8.5.drv': 9 dependencies couldn't be built
cannot build derivation '/nix/store/a4frgav02bkqngk23psf4kk0drff6a7i-python-2.7.15.drv': 15 dependencies couldn't be built
error: build of '/nix/store/a4frgav02bkqngk23psf4kk0drff6a7i-python-2.7.15.drv' failed

I've rebased onto and pushed to staging.


Modified form generation to strip _NORMAL off of ids

After looking at  how the pokemon id's are created, and comparing those to form ids, I thought it would be better to strip the _NORMAL suffix off of the pokemon form ids so they match the pokemon ids.

Thanks a lot! Well done!!