Doesnt start?

Awesome project!
Tried to stream and consume across a few different peers, both on the same and different networks, but I was never able to get an actual video feed on the consumer end, it was just grey?

@bedeho thanks so much for logging this ^__^
There was a bug that came up in some of the dependencies for hypercore, one of the modules hypervision is built on top of. This was apparently fixed overnight.
Are you able to delete hypervision, re-clone it, and follow the installation instructions again? This should work now.
Let me know if there are still issues!

Thanks for the prompt reply.
I tried this literally a few minutes in advance of posting the issue, so if a fix was posted over the weekend, then I will not have missed it. This is the commit I am using, which is still what master points to as of now.
commit b269b94dca955fc14630f691f78e93d5d4983759
Author: Louis Center<EMAIL_ADDRESS>Date:   Tue Mar 21 17:28:25 2017 +1100

    Removed underline from "settings" button

@bedeho Apologies! I shouldn't have assumed it was to do with that, I just wanted to be sure it wasn't related because viewing was broken for me as well up until about 24 hours ago (by the weekend I should have said Monday evening Europe time).
If you cloned the repo fresh and did an npm install just before you posted the issue, then it shouldn't be related.
I'm doing a fresh install and test right now and have viewing working a-ok on my end.
What operating system are you running hypervision on?
Does viewing work across two instances of hypervision on the same computer, or does it only break across different computers/networks?

@louiscenter
I have tried on a bunch of different combinations of Ubuntu and OSX, all running pretty recent versions of node. I just now tried it locally on OSX, and that worked great, so perhaps this has something to do with NAT? do you have hole punching implemented?
A colleague of mine whom I tried this with also suspected it might be due to broken peer discovery on a p2p network with low peer liquidity, but from what we could tell, you are actually using the BitTorrent DHT as the peer discovery layer?

@bedeho yea we are using the dht and are doing hole punching. could you perhaps try installing p2p-test on the machines you are testing on and share the results? https://github.com/mafintosh/p2p-test
That will definitely help us debug.

@mafintosh hey, ok, will try that now.

@mafintosh
This is what I tried and got
./bin.js oslo-LAN
Network tested. Thank you for participating.
{ time: '2017-03-21T12:05:52.935Z',
  description: 'oslo-LAN',
  holePunchable: true,
  pings:
   [ { port: 45075, host: '<IP_ADDRESS>' },
     { port: 45075, host: '<IP_ADDRESS>' } ] }


The img tag raises a warning (vue/html-indent error)

Hi,
All is in the title: The raised error is about the closing parenthesis.
Note that it does not happen using any other html tag, only with the 'img' tag...
img(
  src="./assets/logo.png"
)

 20:1   warning  Expected indentation of 2 spaces but found 0 spaces  vue/html-indent

So prepending 2 spaces to the closing parenthesis fixes it but then, code is not really nice.
img(
  src="./assets/logo.png"
  )

Currently eslint-plugin-vue-pug only makes the existing eslint-plugin-vue rules work for pug templates. The upstream rules are designed for html and sometimes behave weirdly. Having dedicated rules for pug indentation is planned, but not there yet. If you don't want those kinds of warnings you get you can disable the rule vue/html-indent in your eslint config by addid "vue/html-indent": 0 to your rules section.

My mistake, I should read the README to the end...
Anyway, 'weird' is the good word: that appends only whit img at level 0, embedding it in another tag 'fixes' it, as in real life...
div
  img(
    src="./assets/logo.png"
  )

Sorry for the noise.

It's definitely not a noise and looks like a real bug if it shows error in one scenario and does not in another.

If I understood well both the  author's comment and the warn in README, this feature is not implemented for pug purposes yet.
So, it sounds a bite strange to leave my issue about it (even if it seems to work properly with indent in most cases).


Classic Network Contributor had wrong description.

The Classic Network Contributor had the description from Classic Virtual Machine Contributor. Updated the description to be correct.

Hi @animetauren, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no contribution license agreement is required at this point. Real humans will now evaluate your PR.

TTYL, AZPRBOT;

Approve this change.


Add check for min_dates and max_dates parameters in derive_vars_dt(m)()

Apparently a list of variable names is expected as input for these parameters. That wasn't clear to me and when I passed in  just a variable name I got a non-helpful error:
data(ae)
data(adsl)

ae %>%
  left_join(adsl, by = "USUBJID") %>%
  derive_vars_dt(
      new_vars_prefix = "AST",
      dtc = AESTDTC,
      date_imputation = "first",
      min_dates = TRTSDT,
      max_dates = TRTEDT
    )

Error: Argument min_date = 15541 is not a lubridate date.

What should be issued instead is something like:
Error: `min_dates` must be a list of variable names

@koegerr  the required check for min_dates and max_dates will impact the whole dates functions under derive_date_vars and not only derive_vars_dt to get the error message saying that the input for those parameters must be a list of variable names, which isn't the case for others date functions,
So this should be a specific /local check only for derive_vars_dt ?

@hamzarahal Please make this a specific check for the derive_vars_dt() and derive_vars_dtm() functions.

@thomas-neitmann  using assert_vars() call for both min_dates and max_dates parameters, it gives the following :
" Error: max_dates must be a list of unquoted variable names, e.g. vars(USUBJID, VISIT)"
I guess it gives the same meaning comparing with the expected "Error: min_dates must be a list of variable names"?

@thomas-neitmann for derive_vars_dtm(), I think no more need for the assert_character_vector(min_dates), we need to put assert_vars(min_dates/max_dates) instead, as we get "Error: min_dates must be a character vector but is NULL" even when min_dates() is not called


Run button is clickable without a valid connection

Azure Data Studio Version:

Steps to Reproduce:

Open a sql notebook
Make sure no valid connection
we can still click "run button"
Could we make "run button" is not clickable in this situation?

Closing as duplicate - main fix is to prompt for connection dialog


Provide alternative pre-builded css/sass instead of tailwind dep

It looks like really bad practice - to require tailwind as a component dependency, without default style

I'm facing issues when using tailwind JIT mode, it's inside node_modules, the css won't be generated. Having a default style with an option to use tailwind would be nice.

I would like to use this package, but I'm not using Tailwind in my projects, so +1 for this issue from me.

This issues can be resolved on v2.
I start working on next major release
Thanks...


Issue: Support for cloud speech & translation connectors

Ticket Contents
Develop connectors for AWS and GCP speech & translation connectors.
Goals
To provide support for the speech and translations of data for cloud providers such as GCP and AWS.
Expected Outcome
The stack should have capabilities to do speech and translation using GCP and AWS models by providing appropriate speech/translation keys in the environment.
Acceptance Criteria

The users should be able to do speech_to_text, text_to_speech and translation using GCP and AWS credentials
These two new classes for speech_processor and translator should be put into language/src/extension.py file as composite values along with the existing Dhruva and Azure instances.

Implementation Details

Write connectors for speech & translation services in GCP and AWS by following the Azure speech & translation connector files.
The translation code is present in language/src/translator.py. Create two new classes for GCP and AWS translator by extending the Translator base class.
The speech processor code is present in language/src/speech_processor.py. Create two new classes for GCP and AWS speech processors by extending the SpeechProcessor base class and implement the base methods.

Mockups/Wireframes

Product Name
Jugalbandi
Organisation Name
OpenNyAI
Domain
Legal
Tech Skills Needed
Python
Mentor(s)
@Lekhanrao @KaranrajM
Complexity
Low
Category
Backend

@c4gt-community-support, What are the sub-category types and where do we update that in the Issue template?

@Lekhanrao  Could you please assign me this issue. I would like to solve this.

Assigned ticket to @Ris-code

Assigned ticket to @Ris-code

Thank you for assigning me the task. I have already wrote the code but how to test it because I am not having the credentials. Will it work with my own keys ? or I need to make a PR for you to check.

Hi @Ris-code you can test with your own keys to test the individual translator and language services. Once you verify that it is working, you can raise a PR  and we will test code with the whole application and comment if there are any issues.

@Ris-code Please let us know if you have any update on this.

@Ris-code Please let us know if you have any update on this.

Where is the quickstart guide? I could not locate it on the readme.

@Ris-code Please let us know if you have any update on this.

could you please guide how to connect to Whatsapp I am having issues with it.

@Ris-code Please let us know if you have any update on this.

could you please guide how to connect to Whatsapp I am having issues with it.

Hi @Ris-code you need to have pinnacle (one of the business service providers of whatsapp) credentials to connect to whatsapp. But for testing speech and translator services, we can directly test these classes with GCP & AWS keys right? There wont be a need to run the whole chatbot in whatsapp and then test them. We can test them through whatsapp as well but we need pinnacle keys.

Can you assign this issue to me

@Ris-code Please let us know if you have any update on this.

could you please guide how to connect to Whatsapp I am having issues with it.

Hi @Ris-code you need to have pinnacle (one of the business service providers of whatsapp) credentials to connect to whatsapp. But for testing speech and translator services, we can directly test these classes with GCP & AWS keys right? There wont be a need to run the whole chatbot in whatsapp and then test them. We can test them through whatsapp as well but we need pinnacle keys.

Yes I can directly test the APIs. Thank you. Working on it.

I have made a PR changing the translator.py, speech_processor.py, extension.py, .env-dev.template and .env.template files. Please review it . I have already tested all the apis for gcp and aws, it  is working fine.

@yashpal2104, This issue is already being worked upon by Ris-code. Seems like it is almost done and waiting our Team lead's review. So I will get back to you after that review and if we still need help. Thankyou! Btw, there are other issues that you could pick up. I will encourage you to please review our open issues and pick the ones that's of interest to you.

@KaranrajM, could you please check the updates made by Ris-code and the PR request as well.

sure no problem I will get to other issues

@KaranrajM to review the PR and close by Friday 4th Oct.

@KaranrajM is this done?

@Lekhanrao Could you please assign me this issue, i would like to work on it!

@Lekhanrao Hello, could u please assign me this issue? i would like to work on it!!

@KaranrajM, Karan reviewed the code and found some issues (left some comments in the PR for ris-code to update) but he didnt revert back. But Karan confirms that 90% of the code is done. Remaining 10% Karan will pick it up and finish it.

@Lekhanrao Is the issue still open for contribution? I would like to work on it, if possible?

@KaranrajM, Karan reviewed the code and found some issues (left some comments in the PR for ris-code to update) but he didnt revert back. But Karan confirms that 90% of the code is done. Remaining 10% Karan will pick it up and finish it.

Sure!
I gave 3 proposals in the currently ongoing C4GT applications, all for OpenNyAI, please do give it a read and consider them, would love to work with OpenNyAI

@KaranrajM, Karan reviewed the code and found some issues (left some comments in the PR for ris-code to update) but he didnt revert back. But Karan confirms that 90% of the code is done. Remaining 10% Karan will pick it up and finish it.

@KaranrajM , wanted to check if you are able to complete this pending 10%?

@KaranrajM, Karan reviewed the code and found some issues (left some comments in the PR for ris-code to update) but he didnt revert back. But Karan confirms that 90% of the code is done. Remaining 10% Karan will pick it up and finish it.

Sure! I gave 3 proposals in the currently ongoing C4GT applications, all for OpenNyAI, please do give it a read and consider them, would love to work with OpenNyAI

@CraftyEngineer, sure will look into it.


Cannot train on multiple nodes, because port blocked by firewall

I followed the tutorial http://mxnet.io/how_to/multi_devices.html#distributed-training-with-multiple-machines to try to train example/image-classification/train_mnist.py. I failed with launcher mpi and ssh. I can successfully run the script it never trains nor does it report any error. It just stuck there until I kill it manually.
I set environment variables on all of the nodes:
export DMLC_INTERFACE=em3
export PS_VERBOSE=2
hosts:
158.1xx.x.80
158.1xx.x.81
SSH:
While the script is running, training processes are distributed to remover servers... Nothing happens afterwards.
$ ../../tools/launch.py --launcher ssh -n 2 -s 1 -H hosts  python train_mnist.py --network lenet --gpus 0,1,2,3 --kv-store dist_sync
[17:16:55] src/van.cc:69: Bind to role=scheduler, id=1, ip=158.1xx.x.80, port=9091, is_recovery=0
[17:17:00] src/van.cc:155: ? => 1. Meta: request=0, timestamp=0, control={ cmd=ADD_NODE, node={ role=server, ip=158.1xx.x.80, port=50368, is_recovery=0 } }
[17:17:00] src/van.cc:155: ? => 1. Meta: request=0, timestamp=0, control={ cmd=ADD_NODE, node={ role=worker, ip=158.1xx.x.80, port=51877, is_recovery=0 } }
Killed by signal 2.
Killed by signal 2.
Killed by signal 2.
2016-11-01 17:22:15,238 INFO Stop luancher
Then I try to increase the number of worker:
$ ../../tools/launch.py --launcher ssh -n 4 -s 1 -H hosts  python train_mnist.py --network lenet --gpus 0,1,2,3 --kv-store dist_sync
[17:25:19] src/van.cc:69: Bind to role=scheduler, id=1, ip=158.1xx.x.80, port=9092, is_recovery=0
[17:25:24] src/van.cc:155: ? => 1. Meta: request=0, timestamp=0, control={ cmd=ADD_NODE, node={ role=worker, ip=158.1xx.x.80, port=36202, is_recovery=0 } }
[17:25:29] src/van.cc:155: ? => 1. Meta: request=0, timestamp=0, control={ cmd=ADD_NODE, node={ role=server, ip=158.1xx.x.80, port=52936, is_recovery=0 } }
[17:25:29] src/van.cc:155: ? => 1. Meta: request=0, timestamp=0, control={ cmd=ADD_NODE, node={ role=worker, ip=158.1xx.x.80, port=45130, is_recovery=0 } }
Killed by signal 2.
Killed by signal 2.
Killed by signal 2.
Killed by signal 2.
Killed by signal 2.
2016-11-01 17:28:41,265 INFO Stop luancher
I find that all roles are assigned to 158.1xx.x.80 only, is it normal?
MPI(Open MPI 1.10.1):
Training processes can't even launch at remote server...
$../../tools/launch.py --launcher mpi -n 4 -s 1 -H hosts python train_mnist.py --network lenet --gpus 0,1,2,3 --kv-store dist_sync
2016-11-01 17:35:05,797 INFO Start 4 workers by mpirun
[17:35:06] src/van.cc:69: Bind to role=scheduler, id=1, ip=<IP_ADDRESS>, port=9091, is_recovery=0
2016-11-01 17:49:08,476 INFO Stop luancher
I've tested other MPI applications, they work fine. MPI bandwidth test can reach up to 105.93MB/sec.
Am I missing anything that makes training on multiple nodes fail? Please help. The document gives little info about this situation. Thanks in advance!

how long did you wait before killing it?

Few minutes to half an hour...

export DMLC_INTERFACE=em3; ../../tools/launch.py --launcher ssh -n 4 -s 1 -H hosts  python train_mnist.py --network lenet --gpus 0,1,2,3 --kv-store dist_sync
[10:23:14] src/van.cc:69: Bind to role=scheduler, id=1, ip=158.1xx.x.80, port=9091, is_recovery=0
[10:23:19] src/van.cc:155: ? => 1. Meta: request=0, timestamp=0, control={ cmd=ADD_NODE, node={ role=server, ip=158.1xx.x.80, port=34160, is_recovery=0 } }
[10:23:24] src/van.cc:155: ? => 1. Meta: request=0, timestamp=0, control={ cmd=ADD_NODE, node={ role=worker, ip=158.1xx.x.80, port=57697, is_recovery=0 } }
[10:23:24] src/van.cc:155: ? => 1. Meta: request=0, timestamp=0, control={ cmd=ADD_NODE, node={ role=worker, ip=158.1xx.x.80, port=55234, is_recovery=0 } }
Killed by signal 2.
Killed by signal 2.
Killed by signal 2.
Killed by signal 2.
Killed by signal 2.
2016-11-02 12:23:42,985 INFO Stop luancher
2 hours

it looks like these ports are blocked by firewall

Yeah, I confirmed that with the admin.
 I end up with changing the port number in the script and source code.
Here are the changes:
mxnet/dmlc-core/tracker/dmlc_tracker/tracker.py
change the default port number in class RabitTracker
change the default port number in class PSTracker
Hard-code the port number in function
ps-lite/src/network_utils.h: int GetAvailablePort()

I suggest to limit the port range rather than hard code a particular number
On Thu, Nov 3, 2016 at 1:35 AM XU Pengfei<EMAIL_ADDRESS>wrote:

Closed #3685 https://github.com/dmlc/mxnet/issues/3685.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/dmlc/mxnet/issues/3685#event-846043630, or mute the
thread
https://github.com/notifications/unsubscribe-auth/AAZv4SP_SIMoL5h9TyiBjyk9T7Lq9Ya1ks5q6ZzPgaJpZM4Kl8w4
.

@mli how to limit the port range....


Add bundle algorithms

This branch includes a set of new algorithms for what I'm calling "bundling".  That is to combine a set of TimeSeries objects into a set of Seismogram objects.   The algorithms are mostly C++ with very thin python wrappers.  There is also a  new C++ test program with proper asserts to validate the algorithm is working.  The tests there are pretty complete, but may not exercise all the features.  In particular, they weren't updated when I added new code to properly handle failed bundling.  The code here creates dead Seismogram objects whose elog and Metadata can be used postmortem to identify the body.
I attempted to merge this with the origin branch with a rebase operation as you (Ian) had advised but I got into a serious can of worms with conflicting commits done in the last week mainly on test_db.py and database.py.   After suffering through about 20 demands by git rebase to resolve conflicts manually (required edits, git add, git commit, and git rebase --skip for each conflict) I decided I was doing something dangerous and aborted the rebase.   Thus, this branch diverges from master a lot and it is going to take some work to resolve the conflicts.  I think you, Ian, are better prepared to resolve those because all the complaints rebase was throwing at me were about test_db.py and database.py.  You may have a better way to resolve this than the tedious approach I was doing with direct interaction with git with the unix shell.

I tested the revisions and they passed my test program.  However, I realized when finalizing the documentation that I should rethink the usage of BundleGroup.   That is, the original algorithm was supposed to be able to handle groups of multiple stations and return a vector of Seismograms.  I realized I hadn't tested that and found that the version at this moment does not do that anyway.
I am going to change BundleGroup to return only a single Seismogram.  Further, to make it more generic rather than receive an Ensemble it will only receive a std::vector.   That will make it more useful as a building block because it won't care how the data are sorted - it just wants a range of index positions.   The only thing it adds is small safeties on time alignment and a consistent error handled (returning a dead object with an elog entry if it fails).
My test program, by the way, is even less tranportable than I remembered.  It depends on an assembled data set indexed in MongoDB with the procedure in the raw_data_tutorial.   Nonetheless, here it is with the last test I did that will be no longer relevant removed (testing with a bundle of 6 instead of 3).
from mspasspy.db.database import Database
from mspasspy.db.client import Client
from mspasspy.preprocessing.seed.ensembles import (load_one_ensemble,
                                                   load_channel_data)
#from mspasspy.algorithms.signals import (bundle_seed_data,BundleGroup)
from bundle import(bundle_seed_data,BundleGroup)
from mspasspy.ccore.algorithms.basic import seed_ensemble_sort
def print_dead_logs(ens):
    count=0
    for d in ens.member:
        if d.elog.size() == 0:
            if d.dead():
                print("ERROR:  Ensemble member number ",count," is marked dead but has an empty elog")
        else:
            print("Member number ",count," has a elog entry")
            if d.live:
                print("DIFFERENT PROBLEM:  marked live with errors")
            for err in d.elog.get_error_log():
                print(err.algorithm,err.badness,err.message)
        count+=1
client=Client()
db=Database(client,'raw_data_tutorial')

dbwf=db.wf_miniseed
cursor=dbwf.find({}).limit(5)
n=0
for doc in cursor:
    print("Working on ensemble number ",n+1)
    ens=load_one_ensemble(doc,apply_calib=True,
                  ensemble_mdkeys=['source_id','starttime','endtime'])
    print("Number of TimeSeries in this ensemble=",len(ens.member))
    load_channel_data(db,ens)
    ens3c=bundle_seed_data(ens)
    print_dead_logs(ens3c)
    print("Number of Seismograms after bundle_seed_data=",len(ens3c.member))
    # quick test of sort and BundleGroup
    print("testing sort algorithm in isolation")
    seed_ensemble_sort(ens)
    print("Testing BundleGroup")
    # This explicitly uses first 3 channels as a group
    s=BundleGroup(ens,0,2)
    print("Type returned by BundleGroup=",type(s))
    print("Length of vector returned by BundleGroup (should be 1): ",len(s))
    n+=1

BTW:  I'm posting a related new discussion topic that emerged from the need for the small function in this test program

I tested the revisions and they passed my test program.  However, I realized when finalizing the documentation that I should rethink the usage of BundleGroup.   That is, the original algorithm was supposed to be able to handle groups of multiple stations and return a vector of Seismograms.  I realized I hadn't tested that and found that the version at this moment does not do that anyway.
I am going to change BundleGroup to return only a single Seismogram.  Further, to make it more generic rather than receive an Ensemble it will only receive a std::vector.   That will make it more useful as a building block because it won't care how the data are sorted - it just wants a range of index positions.   The only thing it adds is small safeties on time alignment and a consistent error handled (returning a dead object with an elog entry if it fails).
My test program, by the way, is even less tranportable than I remembered.  It depends on an assembled data set indexed in MongoDB with the procedure in the raw_data_tutorial.   Nonetheless, here it is with the last test I did that will be no longer relevant removed (testing with a bundle of 6 instead of 3).
from mspasspy.db.database import Database
from mspasspy.db.client import Client
from mspasspy.preprocessing.seed.ensembles import (load_one_ensemble,
                                                   load_channel_data)
#from mspasspy.algorithms.signals import (bundle_seed_data,BundleGroup)
from bundle import(bundle_seed_data,BundleGroup)
from mspasspy.ccore.algorithms.basic import seed_ensemble_sort
def print_dead_logs(ens):
    count=0
    for d in ens.member:
        if d.elog.size() == 0:
            if d.dead():
                print("ERROR:  Ensemble member number ",count," is marked dead but has an empty elog")
        else:
            print("Member number ",count," has a elog entry")
            if d.live:
                print("DIFFERENT PROBLEM:  marked live with errors")
            for err in d.elog.get_error_log():
                print(err.algorithm,err.badness,err.message)
        count+=1
client=Client()
db=Database(client,'raw_data_tutorial')

dbwf=db.wf_miniseed
cursor=dbwf.find({}).limit(5)
n=0
for doc in cursor:
    print("Working on ensemble number ",n+1)
    ens=load_one_ensemble(doc,apply_calib=True,
                  ensemble_mdkeys=['source_id','starttime','endtime'])
    print("Number of TimeSeries in this ensemble=",len(ens.member))
    load_channel_data(db,ens)
    ens3c=bundle_seed_data(ens)
    print_dead_logs(ens3c)
    print("Number of Seismograms after bundle_seed_data=",len(ens3c.member))
    # quick test of sort and BundleGroup
    print("testing sort algorithm in isolation")
    seed_ensemble_sort(ens)
    print("Testing BundleGroup")
    # This explicitly uses first 3 channels as a group
    s=BundleGroup(ens,0,2)
    print("Type returned by BundleGroup=",type(s))
    print("Length of vector returned by BundleGroup (should be 1): ",len(s))
    n+=1

BTW:  I'm posting a related new discussion topic that emerged from the need for the small function in this test program

Are you going to implement the changes? I guess after the vectors removed, the trick I add in https://github.com/wangyinz/mspass/commit/0f4f732c75de07c788357785f3ea538325ecef84 is no longer needed. We should probably remove that too, because making the bindings global may cause unexpected collision (although it is very unlikely).

Are you going to implement the changes? I guess after the vectors removed, the trick I add in https://github.com/wangyinz/mspass/commit/0f4f732c75de07c788357785f3ea538325ecef84 is no longer needed. We should probably remove that too, because making the bindings global may cause unexpected collision (although it is very unlikely).

Working on this.   The trick you used will simplify the binding code so I may try that.  Thanks for pointing that out - a detail there were no way I'd have seen otherwise

Working on this.   The trick you used will simplify the binding code so I may try that.  Thanks for pointing that out - a detail there were no way I'd have seen otherwise

Just pushed some fairly significant changes to the BundleGroup function to make it do more what I think it should.  Now returns just a single seismogram and has a lot of tests for consistency of seed net,sta,chan,loc codes before it attempts to bundle a group.
One point is the name BundleGroup is probably not what we should call this.  The reason is it is not at all generic but depends completely on seed naming keys (net,sta,loc,chan).   Maybe I should rename it "BundleSEEDGroup"?  Let me know if you think that wise and I'll push that change.
Related before we finalize this is where to put the python wrapper code?   I have a bundle.py file right now that just needs to be inserted into some other module.  I presume it should go in algorithms/signal although that isn't completely descriptive of what it does.   Maybe it belongs in preprocessing/seed since all the functions are seed centric BUT they aren't necessarily preprocessing functions either.   Not clear to me so let me know and I'll push that (hopefully) final change for this branch.

Just pushed some fairly significant changes to the BundleGroup function to make it do more what I think it should.  Now returns just a single seismogram and has a lot of tests for consistency of seed net,sta,chan,loc codes before it attempts to bundle a group.
One point is the name BundleGroup is probably not what we should call this.  The reason is it is not at all generic but depends completely on seed naming keys (net,sta,loc,chan).   Maybe I should rename it "BundleSEEDGroup"?  Let me know if you think that wise and I'll push that change.
Related before we finalize this is where to put the python wrapper code?   I have a bundle.py file right now that just needs to be inserted into some other module.  I presume it should go in algorithms/signal although that isn't completely descriptive of what it does.   Maybe it belongs in preprocessing/seed since all the functions are seed centric BUT they aren't necessarily preprocessing functions either.   Not clear to me so let me know and I'll push that (hopefully) final change for this branch.

Naming it _BundleSEEDGroup sounds good to me. This is gonna be a protected function, so I guess the naming doesn't matter that much.
For the python wrapper, the first place that I can think of is to put the bundle as a submodule of mspasspy.util. Or, if you don't want to make it a standalone module, maybe we could put it under mspasspy.util.converter. What do you think?

Naming it _BundleSEEDGroup sounds good to me. This is gonna be a protected function, so I guess the naming doesn't matter that much.
For the python wrapper, the first place that I can think of is to put the bundle as a submodule of mspasspy.util. Or, if you don't want to make it a standalone module, maybe we could put it under mspasspy.util.converter. What do you think?

Ok, after one last test I'll run after the setup.py job finishes I'll check in what I hope is the final revision of this.  Two things are subject to your editing and I leave them at your discretion:

I made the name BundleSEEDGroup - I'm assuming you will accept that one without any changes.
I'm going to put a file bundle.py in mspasspy/algorithms.   I decide that made more sense because the C++ code is in ccore/algorithms and it is descriptive of what it is.  That is, the python file is just wrappers for code that does match our model of a processing algorithm.

Worth pointing out, I think, that BundleSEEDGroup has two properties we might want to extend/exploit:

It is a good type example of how to write a C++ code that does everything and requires only a minimal wrapper.   i.e. this example handles ProcessingHistory internally and does the proscribed approach to handling errors (kill followed by writing a message to elog).
BundleSEEDGroup satisfies the reduce model, and I don't know how to map that into this framework.  The idea of this function is it should be the workhorse for reading data as TimeSeries (limited by data created from seed had having all the net, sta, loc, chan codes set) sorted properly into an RDD.   The C++ function just uses a range of  vector positions to define a bundle so a reduce wrapper should, I think, be able to take an RDD of sorted TimeSeries and produce an RDD of Seismogram objects.   I have only a rudimentary idea of how to do that so I'm passing the buck to you.

Ok, after one last test I'll run after the setup.py job finishes I'll check in what I hope is the final revision of this.  Two things are subject to your editing and I leave them at your discretion:

I made the name BundleSEEDGroup - I'm assuming you will accept that one without any changes.
I'm going to put a file bundle.py in mspasspy/algorithms.   I decide that made more sense because the C++ code is in ccore/algorithms and it is descriptive of what it is.  That is, the python file is just wrappers for code that does match our model of a processing algorithm.

Worth pointing out, I think, that BundleSEEDGroup has two properties we might want to extend/exploit:

It is a good type example of how to write a C++ code that does everything and requires only a minimal wrapper.   i.e. this example handles ProcessingHistory internally and does the proscribed approach to handling errors (kill followed by writing a message to elog).
BundleSEEDGroup satisfies the reduce model, and I don't know how to map that into this framework.  The idea of this function is it should be the workhorse for reading data as TimeSeries (limited by data created from seed had having all the net, sta, loc, chan codes set) sorted properly into an RDD.   The C++ function just uses a range of  vector positions to define a bundle so a reduce wrapper should, I think, be able to take an RDD of sorted TimeSeries and produce an RDD of Seismogram objects.   I have only a rudimentary idea of how to do that so I'm passing the buck to you.

I would like to make  a strong argument we put the bundle.py code where I placed it in the last push (mspasspy/algorithms).   I'm working on documentation at the moment and the writing reminds me there will be a need for other bundle algorithms that would belong in that module.  e.g. I have collected a number of multichannel data sets that have 3C sensors attached and there the "bundle" algorithm would require a channel number to define the component number and direction.  That would be a very different, and much simpler algorithm than the SEED version in this branch.

I would like to make  a strong argument we put the bundle.py code where I placed it in the last push (mspasspy/algorithms).   I'm working on documentation at the moment and the writing reminds me there will be a need for other bundle algorithms that would belong in that module.  e.g. I have collected a number of multichannel data sets that have 3C sensors attached and there the "bundle" algorithm would require a channel number to define the component number and direction.  That would be a very different, and much simpler algorithm than the SEED version in this branch.

Looks good to me.
Actually, in principle, any thing under the algorithm should accept Spark or Dask's parallel data format just like the algorithm.signal module, where we use the decorators to handle error logs and history. We still need to apply them to the other modules of algorithm. However, that reveals a deign problem of our current layout. First of all, the RFdeconProcessor is not defined as function, so we cannot apply the decorator directly. We will need to turn that into a function like we discussed before. Then, right now we have a dangling reduce module, which should be under a submodule of algorithm. Finally, we have this new BundleSEEDGroup which does not directly take a mspass object but a list of mspass object as its input. I don't think our current decorator handles that. Also, to make that work properly, before calling the BundleSEEDGroup in a map function, users also need do a grouping to turn the distributed data of type TimeSeries into that of a list with three entries. This is something that should go to the document since there is no way for us to enforce that in our library.
Anyway, I guess we should just merge this branch for now, and plan to implement the features later.

Looks good to me.
Actually, in principle, any thing under the algorithm should accept Spark or Dask's parallel data format just like the algorithm.signal module, where we use the decorators to handle error logs and history. We still need to apply them to the other modules of algorithm. However, that reveals a deign problem of our current layout. First of all, the RFdeconProcessor is not defined as function, so we cannot apply the decorator directly. We will need to turn that into a function like we discussed before. Then, right now we have a dangling reduce module, which should be under a submodule of algorithm. Finally, we have this new BundleSEEDGroup which does not directly take a mspass object but a list of mspass object as its input. I don't think our current decorator handles that. Also, to make that work properly, before calling the BundleSEEDGroup in a map function, users also need do a grouping to turn the distributed data of type TimeSeries into that of a list with three entries. This is something that should go to the document since there is no way for us to enforce that in our library.
Anyway, I guess we should just merge this branch for now, and plan to implement the features later.


jeep-sqlite element missing after manual page reload

Describe the bug
When reloading a page via F5 or the browser reload button, in a capacitor angular application running in a web browser, the jeep-sqlite element is not present anymore after the reload and an error gets thrown. The SQLite database subsequently does not work anymore.
To Reproduce
Steps to reproduce the behavior:

Serve your angular application
Open your app in a web browser
Go to a page that uses the SQLite DB, for example to display a chart.
Click on the reload button in the browser or press F5
Notice the "jeep-sqlite element not present in the DOM" error in the browser console (see screenshot below)
The chart using the SQLite DB does not show any data anymore since the SQLite integration does not work without the jeep-sqlite DOM-element.

Expected behavior
The page should reload, the jeep-sqlite element should be added again and the SQLite DB should work like normal
Screenshots

Desktop:

OS: Windows 10
Browser Chrome
Version 113

Additional context
I am not sure whether this is expected or I am doing something wrong. Any hints would be greatly appreciated.

@Blanner which version of jeep-sqlite are you using?

I am thinking it might be a problem of one of my components accessing the sqlite db before the jeepsqlite element was added again. Is there a best practice on how I can wait inside a component until everything is initialized correctly?

@Blanner you must have
Await customElements.whenDefined('jeep-sqlite ');

Prior to the checkConnectionsConsistency()
Like this it should work

You mean inside the component?
I currently don't have a call to checkConnectionConsistency in the component prior to starting the first sql queries.
I didn't find a reference on where to use it in the documentation.
Can you point me to where I can read up about it?

@Blanner look at the app example depending on your framework

I have been using your angular sqlite app starter project (https://github.com/jepiqueau/angular-sqlite-app-starter/tree/c9d86435acf2e5b21f3a19998d8040b0fb509abf) and basically mirrored the sqlite setup with repositories, a database service & an sqlite service.
However using the database service like shown there resulted in the above described error and I could not find a usage of  checkConnectionConsistency there. Are you refering to a different sample app?

The executeQuery function looks like below in the sample app:
`
async executeQuery(callback: SQLiteDBConnectionCallback, databaseName: string = environment.databaseName): Promise {
try {
let isConnection = await this.sqlite.isConnection(databaseName);
  if (isConnection.result) {
    let db = await this.sqlite.retrieveConnection(databaseName);
    return await callback(db);
  }
  else {
    const db = await this.sqlite.createConnection(databaseName, false, "no-encryption", 1);
    await db.open();
    let cb = await callback(db);
    await this.sqlite.closeConnection(databaseName);
    return cb;
  }
} catch (error) {
  throw Error(`DatabaseServiceError: ${error}`);
}

}
}`
When the page is reloaded manually by the browser, the isConnection.result is true when the page is loaded again but the callback(db) call throws the error that no db connection is available.
I've modified this like below to try to incorporate your feedback and get around this error. I mainly disabled the connection retrieving altogether and always create & close a new connection. I also added some code that waits for the jeep-sqlite element to be present and for the datastore to be open:
`
async executeQuery(callback: SQLiteDBConnectionCallback, databaseName: string = environment.databaseName): Promise {
await customElements.whenDefined('jeep-sqlite');
const jeepSqliteEl = document.querySelector('jeep-sqlite');
if(jeepSqliteEl != null) {
  console.log(`>>DbService: isStoreOpen ${await jeepSqliteEl.isStoreOpen()}`);
}

try {
  let isConnection = await this.sqlite.isConnection(databaseName);
  console.log('executing query, isConnection: ' + isConnection.result);

  if(isConnection.result) {
    console.log('closing previous Connection');
    await this.sqlite.closeConnection(databaseName);
  }

  console.log('creating connection');
  const db = await this.sqlite.createConnection(databaseName, false, "no-encryption", this.dbVersion);
  await db.open();

  let consistency: capSQLiteResult = await  this.sqlite.checkConnectionsConsistency();
  console.log('>>> Connection consistency: ' + consistency.result);
  let dbOpen: capSQLiteResult = await db.isDBOpen();
  console.log('>>> DB open: ' + dbOpen.result);
  let cb = await callback(db);

  console.log('closing Connection');
  await this.sqlite.closeConnection(databaseName);
  return cb;
  //}
} catch (error) {
  throw Error(`DatabaseServiceError: ${error}`);
}

}`
With this, I'm not getting the above described error anymore but when I have multiple components accessing the DB more or less at once (some using the same, some using different repositories), then the Database is sometimes not opened for some of these accesses after the call to db.open().
This is the current state that I'm at. If you have feedback for how I can improve this code or even resolve my new error, it would be greatly appreciated.

@Blanner can you share your app

@Blanner look at openDatabase in  sqlite.service.ts of ionic-angular-sqlite-starter

The app itself yes, but to try this yourself you would need a personal data-download from Spotify which includes sensitive data, so I can't share that data with you and obtaining it yourself would take 2-5 days (if you already have a spotify account)

Can you explain why a call to db.open might not actually open a database or why a createConnection might not be able to create a connection? Maybe this helps me to solve the problem myself.
Is there some sort of limit on how many connections to a database can be used simultaneously?

@Blanner ir is only due to the live reload  which requires to have the check connections consistency to make sure that the connections are aligned between the SQLiteConnection wrapper and the plugin. I was thinking to share the app or a repro app on github

@Blanner Did you make any progress? Is that solve by adding the checkConnectionsConsistency?

@Blanner look at lines 41-42 of sqlite.service.ts of ionic-angular-sqlite-starter app

@Blanner as you do not follow-up .i close the issue. Feel free to re-opens it if needed


Set drop-down menu option to be same as help text below

The drop down menu option was previously "Send Power Toggle" where the help text below it was referring to it as "Send Power Option"
This could probably be changed either way, however I think "option" makes more sense than toggle.

Please PR this into develop and not v0.6.0-beta.2.


[Event Processor Host] Test EPH end to end including checkpoint with proxy enabled

Test EPH features end to end including checkpoint with proxy enabled.

We want to ensure that the below works when using proxy

send events
receive using checkpoint store

update checkpoints
stop the program
restart the program: ensure it starts receiving from the checkpointed position

We want to ensure that the below works when using proxy

send events

receive using checkpoint store

update checkpoints
stop the program
restart the program: ensure it starts receiving from the checkpointed position

Verified above with @azure/event-hubs library and proxy interaction works as expected.
cc: @ramya-rao-a

Actually, I verified the events stop getting received on stopping the proxy.
But the process needed to be restarted (and then it receives events from checkpointed sequenece number as expected).
However, on restarting the process - the receive did not resume and it was just hanging indefinitely.
Is this an issue? Seems like a smoother user experience might be that the receive process resumes once proxy is disconnected / enabled back.

Ensuring that sending, receiving, receiving from checkpoint, recovering from network outage works as expected is good enough for the task being tracked in this issue.
Regarding issues for recovery from restarting the proxy itself, they are worth investigating. Please log a separate issue with details along with repro steps.
Regarding invalid consumer group, the client library does not have a way to validate consumer groups, therefore we have to rely on the error message that the service provides.


specify OpenGL version in AndroidManifest.xml

Running without this was causing no video to appear in RTCViews on my Android device.
May fix #18.

Which device and version you used has the problem?
@reactor81 @JoeLogan1981 do you guys have time to check?

Looking again, I think this was unrelated to the problem. You can close
this pull request.
Instead, the issue seems to happen because in using Live Reload to test my
code.
When I compile and push a new binary it works the first time. Whenever I
make a change and reload the element it shows no video and produces no
error.
Perhaps there's some global state that's not getting cleared? I'll keep
looking.
On Tue, Jun 14, 2016 at 02:05 zxcpoiu<EMAIL_ADDRESS>wrote:

Which device and version you used has the problem?
@reactor81 https://github.com/reactor81 @JoeLogan1981
https://github.com/JoeLogan1981 do you guys have time to check?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/oney/react-native-webrtc/pull/90#issuecomment-225661118,
or mute the thread
https://github.com/notifications/unsubscribe/AABvlXbRK7aTEIcsKb5wlLDlQvybUkskks5qLZwBgaJpZM4I0hxY
.

@maxhawkins
thanks!
So this PR did fix your problem when you are using Live Reload to test code?
If it fixed your problem as long as did not break anything, I think it's worthy to be included

my concern is: will specifying OpenGL Version in Manifest breaks the user who use webrtc audio only on a older device?
Given that react-native supports only API >= 17 , seems it won't hurt anything.
https://developer.android.com/guide/topics/graphics/opengl.html

OpenGL ES 1.0 and 1.1 - This API specification is supported by Android 1.0 and higher.
OpenGL ES 2.0 - This API specification is supported by Android 2.2 (API level 8) and higher.
OpenGL ES 3.0 - This API specification is supported by Android 4.3 (API level 18) and higher.
OpenGL ES 3.1 - This API specification is supported by Android 5.0 (API level 21) and higher.

https://developer.android.com/guide/topics/graphics/opengl.html#version-check

There are several versions of OpenGL ES available on Android devices. You can specify the minimum version of the API your application requires in your manifest, but you may also want to take advantage of features in a newer API at the same time. For example, the OpenGL ES 3.0 API is backward-compatible with the 2.0 version of the API, so you may want to write your application so that it uses OpenGL ES 3.0 features, but falls back to the 2.0 API if the 3.0 API is not available.

Hi Max,
Does this happen with the local video, remote video, or both when using LiveReload?
Joe

I thought it fixed my problem but it didn't. With the new xml entry it only works the first time, as before.
@JoeLogan1981 My test app shows a local video stream from the front camera only. It shows the image the first time I load. When I reload the JS the image is replaced with a gray rectangle.

@maxhawkins
can you reproduce the problem using demo?
p.s. you may have to change package.json to the latest version accordingly

@maxhawkins does the same thing happen with remote video?

Sorry I got pulled off onto another project. I'll have time to test this in a few weeks.

Inactive, closing. Please holler is this is still needed. (but test the latest version first, since we added some EGL rendering related fixes)


Handling permessage-deflate requests

Hello!
Is there a way to handle requests specifying compression header?
Sec-WebSocket-Extensions: permessage-deflate
Response should contain the same header (easy), but the request data ($msg in onMessage) would have to be inflated, so would the response data passed to send( ).
Advice appreciated!
Thanks,
Gabriel

In fact, it would help to have some Extenstions mechanism. Sec-WebSocket-Extensions header can have several values, and by definition it is supposed to be extensible.
I could force the response header
$response->setHeader('Sec-WebSocket-Extensions', 'permessage-deflate');

in https://github.com/ratchetphp/Ratchet/blob/master/src/Ratchet/WebSocket/WsServer.php#L125
and then the client (browser) sends deflated data, but then RFC6455.php is unable to handle it.
But then I found that if I bypass the check on $frame->getRsv1(), getRsv2() and getRsv3() in https://github.com/ratchetphp/Ratchet/blob/master/src%2FRatchet%2FWebSocket%2FVersion%2FRFC6455.php#L121 , and also of course bypass the UTF8 check in https://github.com/ratchetphp/Ratchet/blob/master/src%2FRatchet%2FWebSocket%2FVersion%2FRFC6455.php#L199  then the compressed data makes it through my applicative onMessage handler.
In turn, my onMessage handler must inflate the compressed data, but I found that it is not enough to gzinflate it: the header is a bit different (must OR the very first byte of the stream with 0x01 in order to obtain valid input for gzinflate).
I wish someone could help be in this direction so as to stabilize, and possibly propose a proper Extensions system for future protocol features.
Thanks.

For 0.4 we're refactoring the protocol handler into its own repo. This is leading to a more loosely coupled protocol handler so doing things like handling extensions should become easier. You're on the right path with finding the header and message frames. Checked out the psr7 RFC branch to see where we're going and feel free to help contribute!

Thanks!
About where in the https://github.com/ratchetphp/RFC6455/blob/psr7/README.md roadmad, do we stand currently?

v0.2 is almost done. We've actually already incorporated some performance enhancements in it as well (scheduled for v0.3). While extensions were slated for v0.4 if someone was willing to work on that feature I'd be happy to add it to the next release.

Hi, do you thing that it's possible to integrate the permessage-deflate work done in Ratchet soon, I'm curious to know how this is going :)
Thanks again for the awesome work !

I just spoke with @mbonneau. We're going to start outlining a roadmap to include this. We've looked at it a couple times and have always hit a road block with the API. We're going to start documenting this process more openly and make a decision to move forward.


0.30.4 release problems

there is release 0.30.4 here https://www.npmjs.com/package/mongo-express

but there is no such tag in git repository
middleware.js is missing in it and also in master branch

Please explain what a tag is required?

middleware.js is in the lib/ folder. If you feel the documentation is not clear enough, a PR would be most welcome.

I don't say it is required, but it was common before and makes it easier to track changes in npm package
thanks for the tip. PR seams not to be needed anymore because it is correct in README.md now

thank you


Revert "Add combined cluster to test in staging"

Reverts vespa-engine/sample-apps#260
@mpolden

Requires https://github.com/vespa-engine/sample-apps/pull/263


[Feature] Make the app auto lock after it was reduced (Home navigation button is used)

Is your feature request related to a problem? Please describe.
When the we exit the app by using the back navigation button the app locks automatically but when it is reduced using the home navigation button it doesn't lock automatically and stays open and can readily be accessed when using switch navigation button.
Describe the solution you'd like
Making the app lock automatically if if is reduced too, using the switch navigation button.

This is already implemented (kind of).
The lock timeout acts in the background. If you set it to "immediately" it will lock, once you navigate from it.

This is already implemented (kind of).
The lock timeout acts in the background. If you set it to "immediately" it will lock, once you navigate from it.

So basically, if its set so 3 Minutes, it will be locked if the app is in background for 3 Minutes.

So basically, if its set so 3 Minutes, it will be locked if the app is in background for 3 Minutes.

This is already implemented (kind of).
The lock timeout acts in the background. If you set it to "immediately" it will lock, once you navigate from it.

Yes you are right, sorry my bad, I didn't notice the lockout timer in settings.

This is already implemented (kind of).
The lock timeout acts in the background. If you set it to "immediately" it will lock, once you navigate from it.

Yes you are right, sorry my bad, I didn't notice the lockout timer in settings.


After filtering the items, use the up and down shortcut keys to make the item appear a second time.

After filtering the items, use the up and down shortcut keys to make the item appear a second time.

Normally, you should select the first one after filtering.

release. to 3.0.19-alpha.4


Prevent editing of emails on User

We currently allow users to edit their User email address. For example, log in as an adopter and go to dashboard > edit settings, or as staff, go to the dashboard, then top right, click on your avatar > account settings.
Please disable the email field so people cannot edit it.
Please also add a model validation on User that prevents changing of the email on update

Hey @kasugaijin can I be assigned this issue?

@MichaScant Have at it! Thanks

Hey, would something like this work for the model validation?

Hey, would something like this work for the model validation?

this is an example and the email field will be disabled. If someone tries to change the email on the user they should get this message

the field should be disabled. there should be a disabled attribute for the email input in the bootstrap form. This will make the field look like this and will prevent from a user clicking to focus on the input. Within the disabled field should show the value for their email address when editing user settings.

Sorry I should clarify that i took out the disabled attribute for Bootstrap just to test if the model validation for the user would prevent the email from updating if there was a change.
This is how the disabled version would look:

For the message, I added this in the User model which is called on update:
  validate :check_email_change, on: :update

  def check_email_change
      errors.add(:email, "Email cannot be changed") if (email_changed?)
  end

just to ensure there is no way for the user to change the email on update

Ah yea thy makes sense. Can you also disable the input as well? A disabled input is ideal so the user knows up front it’s not editable

yeh the input should be disabled in the second screenshot i sent
'''  <%= f.email_field :email, autofocus: true, autocomplete: "email", disabled: true, class: 'form-control' %> '''

yeh the input should be disabled in the second screenshot i sent, added disabled: true as shown below
<%= f.email_field :email, autofocus: true, autocomplete: "email", disabled: true, class: 'form-control' %>

Yes that looks good!

For the message, I added this in the User model which is called on update:
  validate :check_email_change, on: :update

  def check_email_change
      errors.add(:email, "Email cannot be changed") if (email_changed?)
  end

just to ensure the user cannot change the email on the update

Can you please add a comment above this method, something like
we do not allow updating of email on User because we also store email on Person, and the values should be the same

ok will do, thank you!


[CVE5274] Bump protobuf to 3.25.5 for 7.7.0-cp3

Bump protobuf to 3.25.5 for 7.7.0-cp3

The failed test does not relate to the changes.


Fixed Issue which uri encodes the share request quest query parameters

Fixes https://github.com/liyasthomas/postwoman/issues/435

Hey @asnimansari,
Your changes look good to me!
View build log
TravisBuddy Request Identifier: 29b102e0-1ff0-11ea-ba47-7f442aed9c1e

Fixed in https://github.com/liyasthomas/postwoman/commit/ae237f1ad3855293a0b81f2846bc318358c4dbd3


[Mention The Feature]: Add complete tutorial page for Fashion Recommendation System using Machine Learning in projects page website

Is your feature request related to a problem? Please describe.
add a tutorial page
Describe the solution you'd like.
No response
Describe alternatives you've considered.
No response
Additional context.
No response
Show us the magic with screenshots
No response
Checklist

[X] I have checked the Existing Issues
[X] I have read the Contributing Guidelines
[X] I want to work on this issue. (optional)

@DarshAgrawal14 assigning this issue to you.
Make sure to complete this.
And don't create multiple issues.
pls understand.

@DarshAgrawal14 assigning this issue to you.
Make sure to complete this.
And don't create multiple issues.
And please do contribute to other projects also.
pls understand.

i do , but since the repo is closing soon and i myself am going to get busy due to my upcoming exams so i am commiting as much as i can for next two days..


If format-on-save is not enabled, save immediately

There's absolutely no reason to call the document formatting since it is going to get ignored anyways.
Signed-off-by: Hanif Ariffin<EMAIL_ADDRESS>
[ ] Added an entry to CHANGELOG.md if this change could be valuable to users

Codecov Report

Merging #2088 (64ee88a) into master (258ffe1) will increase coverage by 0.04%.
The diff coverage is 0.00%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories.  Learn more


Added Starfy and Ni No Kuni EN banner

Oops, sorry I accidentally deleted the EN banner for NNK. Merged the other one, though.
We don't have support for secondary banners though. Just making sure you knew that. I reuploaded the image here if you wanted to recreate the PR.

.


Add Debian package registry

Co-authored-by: @awkwardbunny
This PR adds a Debian package registry.
You can follow this tutorial to build a *.deb package for testing.
Source packages are not supported at the moment and I did not find documentation of the architecture "all" and how these packages should be treated.

Part of #20751.
Revised copy of #22854.

By the way, the screenshot is now outdated.

I did not find a documentation of the architecture "all" and how these packages should be treated
So how does it currently treat .debs with architecture "all"? Does it refuse them? Does it add them but they aren't able to be installed via apt?

all packages are not refused and are available in an independent architecture all. Then it depends on the client (?) if it uses this all architecture when resolving packages. The all packages are not mixed into every architecture.


Resolve credential leak via ps while jenkins-cli is used during puppe…

…t runs

Pull Request (PR) description
Passes credentials to jenkins-cli as environement variables by default so passwords aren't visible in the output of ps during puppet agent runs.
This Pull Request (PR) fixes the following issues
Not sure if this has an associated issue

I made updates based on your feedback @ekohl. Let me know if it looks good now. Also I have a question about commit/merge practices. I usually like to rebase and squash updates on feature/bugfix branches. ex. my current fixes were squashed into my previous commit and pushed to my fork. I was wondering if there was a best pracitces/recommend process around this for this repo/org. (ie should we squash in fixes or keep them as separate commits)

Rebased on current master HEAD

@ekohl or @bastelfreak : are any other chages/updates required in this PR?
I agree with @ekohl that we need to centralize logic in a wrapper but i would prefer to do that in a separate PR to keep the changes easy to comprehend.

@ekohl , I added a couple of unit tests to ensure the auth args are added to enviornment when defined and they are absent when not defined.
Let me know if any other tests are required else please merge.

Hey @ekohl , just wanted to check if there were any updates required for this PR could be merged?


Reduce number of queries

This PR reduces number of queries on the product edit page.

Current coverage is 48.30%

Merging #352 into master will decrease coverage by -0.02% as of 0ebad30

@@            master   #352   diff @@
=====================================
  Files           85     85
  Stmts         3373   3385    +12
  Branches       318    321     +3
  Methods          0      0
=====================================
+ Hit           1630   1635     +5
  Partial         28     28
- Missed        1715   1722     +7

Review entire Coverage Diff as of 0ebad30

Powered by Codecov. Updated on successful CI builds.

@patrys Can you review and merge this PR?


Support for stdin?

Many thanks for creating this awesome tool, it's really appreciated. However, I would like to integrate the hosted devzat into my terminal dashboard. But I couldn't get it working.
When I'm trying to connect with ssh to my host with port number supplied, everything is fine.
When I use a terminal dashboard like WTF Util or Termui or Sampler and using the same arguments as I did for SSH, I get an 255 error (in case of WTF terminal) or an error from sampler that it was not a stdin terminal.
So I'm out of ideas and was curious if devzat coulld support stdin output, or be integrated in another way in a terminal dashboard?

Can you send the exact error message you get?

Sampler  gives error message: stdn is not supported on this terminal .
WTF Util gives the error message:
Exit code 255
I wish they were more descriptive too.

I'm not completely sure what that means, but I know that that error pops up in pty-related contexts. Are you sure your config is right? If yes, maybe we can make a GitHub issue on the repos of those dashboards to figure out what the problem is.

Thanks for the suggestion, I have reported to wtfutil tool, to see why it's causing issues with their dashboard:
https://github.com/wtfutil/wtf/issues/1286

alright, thanks!

@ReneFroger was the issue fixed?

It seems it's still not fixed yet. Will notify here when it got solved.


Drop Node.js 12 support

Waiting https://github.com/svg/svgo/pull/1763 to prevent regression with id conflicts with multiple SVGs.

Update svgo.config.s to generate unique id and add another SVG to check ID conflicts


GORA-426 Disable cursor timeout

Hi @AlexanderYastrebov !
I'm not sure that enforcing "QUERYOPTION_NOTIMEOUT" for all requests is the right way to fix this. I would at least prefer a way to allow configuration of this feature.
Regards,

Hello @drazzib
My point is following:

If you have mean page parse time (in nutch) greater than 6 seconds, you will end up with closed cursor and failed parse run (because of default 100 batchSize and 10 min cursor timeout).
There is no evidence at all (neither in API, not in docs) for lib user that cursor may be closed unexpectedly while reading result.
(MongoDB)Result has close() method and with proper use there will leak no cursors.
One more option to configure is worse than no option at all.

Hello @AlexanderYastrebov !
After second thought and based on your reasoning (especially 2 and 3) I agree with you.
I will merge this changes into master.
Thanks for your contribution !


Removed dom4j dependency from core Errai

Max,
Trying to get rid of the dom4j and use the jdk built-in XML  dom parser. This is only for the core Errai . I think reflections is the only one using dom4j. The demos are not touched and some of them still use dom4j.
Dom4j is also used by Hibernate and I thought the Errai stopped using hibernate, but I just noticed that the errai-jpa is back?

Can one of the admins verify this PR? Comment with 'ok to test' to start the build.

ok to test

@hrstoyanov errai-jpa is deprecated but not removed yet. It will remain in Errai 4.x, but probably not in Errai 5.

Thanks Max,
Can you help me understand which tests fail with my patch. I do see some failures with Codegen, but seems not related to Reflections?
[INFO] Running org.jboss.errai.codegen.test.AllStatementBuilderTests
package org.foo;

import java.io.Serializable;

public class Bar implements Serializable {
  private String name;
}
[ERROR] Tests run: 247, Failures: 2, Errors: 0, Skipped: 0, Time elapsed: 0.124 s <<< FAILURE! - in org.jboss.errai.codegen.test.AllStatementBuilderTests
[ERROR] testEncodeAnnotation(org.jboss.errai.codegen.test.AnnotationEncoderTest)  Time elapsed: 0.002 s  <<< FAILURE!
org.junit.ComparisonFailure: expected:<...tation.Target(value=[[METHOD]])"; } public java.la...> but was:<...tation.Target(value=[{METHOD}])"; } public java.la...>
	at org.jboss.errai.codegen.test.AnnotationEncoderTest.testEncodeAnnotation(AnnotationEncoderTest.java:38)

[ERROR] testEncodeAnnotationWithMultipleProperties(org.jboss.errai.codegen.test.AnnotationEncoderTest)  Time elapsed: 0 s  <<< FAILURE!
org.junit.ComparisonFailure: expected:<...yTestAnnotation(foo=[barfoo], testEum=FOURTH)"; ...> but was:<...yTestAnnotation(foo=[\"barfoo\"], testEum=FOURTH)"; ...>
	at org.jboss.errai.codegen.test.AnnotationEncoderTest.testEncodeAnnotationWithMultipleProperties(AnnotationEncoderTest.java:56)

[INFO] Running org.jboss.errai.codegen.test.IfBlockBuilderTest
[INFO] Tests run: 18, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.001 s - in org.jboss.errai.codegen.test.IfBlockBuilderTest
[INFO] Running org.jboss.errai.codegen.test.StatementBuilderTest
[INFO] Tests run: 51, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.011 s - in org.jboss.errai.codegen.test.StatementBuilderTest
[INFO]
[INFO] Results:
[INFO]
[ERROR] Failures:
[ERROR] org.jboss.errai.codegen.test.AnnotationEncoderTest.testEncodeAnnotation(org.jboss.errai.codegen.test.AnnotationEncoderTest)
[ERROR]   Run 1: AnnotationEncoderTest.testEncodeAnnotation:38->AbstractCodegenTest.assertEquals:43 expected:<...tation.Target(value=[[METHOD]])"; } public java.la...> but was:<...tation.Target(value=[{METHOD}])"; } public java.la...>
[ERROR]   Run 2: AnnotationEncoderTest.testEncodeAnnotation:38->AbstractCodegenTest.assertEquals:43 expected:<...tation.Target(value=[[METHOD]])"; } public java.la...> but was:<...tation.Target(value=[{METHOD}])"; } public java.la...>
[INFO]
[ERROR] org.jboss.errai.codegen.test.AnnotationEncoderTest.testEncodeAnnotationWithMultipleProperties(org.jboss.errai.codegen.test.AnnotationEncoderTest)
[ERROR]   Run 1: AnnotationEncoderTest.testEncodeAnnotationWithMultipleProperties:56->AbstractCodegenTest.assertEquals:43 expected:<...yTestAnnotation(foo=[barfoo], testEum=FOURTH)"; ...> but was:<...yTestAnnotation(foo=[\"barfoo\"], testEum=FOURTH)"; ...>
[ERROR]   Run 2: AnnotationEncoderTest.testEncodeAnnotationWithMultipleProperties:56->AbstractCodegenTest.assertEquals:43 expected:<...yTestAnnotation(foo=[barfoo], testEum=FOURTH)"; ...> but was:<...yTestAnnotation(foo=[\"barfoo\"], testEum=FOURTH)"; ...>
[INFO]
[INFO]
[ERROR] Tests run: 554, Failures: 2, Errors: 0, Skipped: 0
[INFO]
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Errai Internal BOM (Bill Of Materials) ............. SUCCESS [  0.001 s]
[INFO] JBoss Errai BOM .................................... SUCCESS [  0.886 s]
[INFO] Errai .............................................. SUCCESS [  0.261 s]
[INFO] Reflections parent ................................. SUCCESS [  0.267 s]
[INFO] Reflections ........................................ SUCCESS [  0.271 s]
[INFO] Errai::Common ...................................... SUCCESS [  2.681 s]
[INFO] Errai::CDI::EE6 API Overrides ...................... SUCCESS [  0.078 s]
[INFO] Errai::Codegen ..................................... FAILURE [  1.987 s]

Where are you seeing those test failures? On Jenkins it is org.jboss.errai.reflections.ReflecitonTest that is breaking.

Max, fixed the issues and now the ReflectionTest passes cleanly. Are you able to see the pull request?
... Forgot to squish the commits

Build finished. 2656 tests run, 5 skipped, 0 failed.  ... so why does it marked the tests as failed? Also, clicking "Details" link goes nowhere.

Jenkins, please retest this.

Max,
Fixed the comment on StandardAsyncServlet, I must have fat-fingered it:-)


chore: bump go jUnit to v2.0.0

Signed-off-by: Ross<EMAIL_ADDRESS>
Summary

bump go j unit to v2.0.0 https://github.com/jstemmer/go-junit-report/tags
How did you test this change?

Issue

Nice. We had to bump this version recently in some RA pipelines. Do you know where this tool is being used in this repo?


Bug: Duplicate groups/users in folder Properties -> Security

Description

Steps To Reproduce

Right click a random folder
Open Properties window
Switch to Security tab

Files Version
<IP_ADDRESS>
Windows Version
26100.2448
User ID
No response
Log File
debug.log

Thank you for the feedback.
I think this is not a bug. Look at the Advanced Security window of that folder in File Explorer. Presumably, it enumerates duplicated entries but those should be certainly different as for the inheritance option and the original path of inheritance. I know File Explorer has merging feature in that simple view unlike in the advanced view but if we do that in Files we might have to maintain very complicated code while this depends upon Yair.


Various typos fixed on new OPCUA documentation

Hi there,
Some fixes on new OPCUA pages
Signed-off-by: Didier Durand<EMAIL_ADDRESS>What this PR does / why we need it:
Improvements to new documentation
Special notes for your reviewer:
If applicable:

[X] this PR contains documentation
[ ] this PR contains unit tests
[ ] added code adheres to standard Rust formatting (cargo fmt)
[ ] code builds properly (cargo build)
[ ] code is free of common mistakes (cargo clippy)
[ ] all Akri tests succeed (cargo test)
[ ] inline documentation builds (cargo doc)
[ ] version has been updated appropriately (./version.sh)

Just added some additional fixes on extensibility.md

Just added some additional fixes on extensibility.md

Just added some additional fixes on extensibility.md

It is hard to see what the diffs are in github.com for your extensibility changes are (did the line endings change?)... the other files seem good.

Just added some additional fixes on extensibility.md

It is hard to see what the diffs are in github.com for your extensibility changes are (did the line endings change?)... the other files seem good.

@bfjelds : I fully agree with you. The diff is presented differently than it is usually. I am on MacOS (Linux convention for line ends): maybe the file was created on Windows?
The "real" changes are still highlighted by Github's diff in lines 138, 206, 366, 463 and 663.
Best
Didier

@bfjelds : I fully agree with you. The diff is presented differently than it is usually. I am on MacOS (Linux convention for line ends): maybe the file was created on Windows?
The "real" changes are still highlighted by Github's diff in lines 138, 206, 366, 463 and 663.
Best
Didier

@bfjelds : I fully agree with you. The diff is presented differently than it is usually. I am on MacOS (Linux convention for line ends): maybe the file was created on Windows?
The "real" changes are still highlighted by Github's diff in lines 138, 206, 366, 463 and 663.
Best
Didier

If I open the PR using the GitHub VS Code extension, it only highlights those few lines.

@bfjelds : I fully agree with you. The diff is presented differently than it is usually. I am on MacOS (Linux convention for line ends): maybe the file was created on Windows?
The "real" changes are still highlighted by Github's diff in lines 138, 206, 366, 463 and 663.
Best
Didier

If I open the PR using the GitHub VS Code extension, it only highlights those few lines.

@kate-goldenring and @bfjelds : the diff Eclipse also highlights only the lines that I mentioned. So, good to go. Didier

@kate-goldenring and @bfjelds : the diff Eclipse also highlights only the lines that I mentioned. So, good to go. Didier


Publish react native npm module

This depends on #2 .
We'll need to re-organize the repo layout for this.

For reference: http://andengineer.blogspot.com/2016/12/react-native-bridged-android-components.html


Creating a Library

Hello I am writing an Angular + Nativescript code sharing project and have realized it would be beneficial to create a Library. I have tried using schematics but I am unable to create a proper library. Any component that get's created within the library only has angular files not typescript.
Steps To reproduce:

Create a Workspace:  ng new <project-name> --create-application false
Create a Library:  ng generate library library-name
Create a module within the library: ng generate module navigation-module --project=Library
Create a component within the library: ng generate component ran within the module directory

Issue moved to NativeScript/nativescript-schematics #179 via ZenHub


start day of the week

Hi,
Is there a way to set the start day of the week? I want the first of the week to be 'Monday' instead of 'Sunday'.
I have created a pull request so you can take a look https://github.com/ng2-ui/ng2-datetime-picker/pull/74
Cheers.

This has been implemented with 'start-day-of-week' attribute


feat: add mime type  to ImageFile

Add mime_type to ImageFile to facilitate
generating Content-Type headers for images
While working on https://github.com/wagtail/wagtail/pull/8974 @jams2 noted that Pillow provided a content_type that was lost in the switch to Willow. I implemented a mapping of format_name to mime_type to resolve the issues, but it would be better if we could get the mime_type from the ImageFile instance returned by willow.open

@kaedroho @jams2 @zerolab I'd love a review on this. It's pretty small, but it is an interface addition.


Considering a split king and interested in the smart alarm features/ sleep phase data

I notice you suggested commenting in the issues tab. What considerations should I consider if I were to get this bed and I’m very interested in using these data for automation?

@DanSafdie feel free to jump on the discord to chat about this - Github issues isn't an ideal forum.


bug: When using fzf-lua ui.select adding a component fails

Neovim version (nvim -v)
0.10.0 commit f69937fdbd162630c35e119e67bbbf052558c0e0
Operating system/version
NixOS 24.11.20240531.57610d2
Describe the bug
When in the task editor, after hitting o the vim.ui.select window (as provided by fzf-lua) pops up, but the focus is maintained on the overseer window, and for all intents and purposes the vim.ui.select window is dead (even after navigating to the window the key binds dont work). I'm not sure if this an issue with the implementation of vim.ui.select by fzf-lua, but my best guess is that it has to do with the way that overseer manages the cursor in the edit popup. For clarity the selector provided by fzf-lua opens a floating window, and then the cursor immediately jumps back to the overseer editor window.
What is the severity of this bug?
breaking (some functionality is broken)
Steps To Reproduce

Create new task with overseer
hit o

Expected Behavior
The ui select window maintains focus until an item is selected.
Minimal example file
No response
Minimal init.lua
-- DO NOT change the paths and don't remove the colorscheme
local root = vim.fn.fnamemodify("./.repro", ":p")

-- set stdpaths to use .repro
for _, name in ipairs({ "config", "data", "state", "cache" }) do
  vim.env[("XDG_%s_HOME"):format(name:upper())] = root .. "/" .. name
end

-- bootstrap lazy
local lazypath = root .. "/plugins/lazy.nvim"
if not vim.loop.fs_stat(lazypath) then
  vim.fn.system({
    "git",
    "clone",
    "--filter=blob:none",
    "--single-branch",
    "https://github.com/folke/lazy.nvim.git",
    lazypath,
  })
end
vim.opt.runtimepath:prepend(lazypath)

-- install plugins
local plugins = {
  "folke/tokyonight.nvim",
  { "stevearc/dressing.nvim", config = true },
  {
    "stevearc/overseer.nvim",
    config = function()
      require("overseer").setup({
        -- add your overseer config here
      })
    end,
  },
  {
    'ibhagwan/fzf-lua',
    dependencies = { 'nvim-tree/nvim-web-devicons' },
    config = function(_, opts)
      local fzf = require('fzf-lua')
      fzf.setup(opts or {})
      fzf.register_ui_select(function(_, items)
        local min_h, max_h = 0.15, 0.70
        local h = (#items + 4) / vim.o.lines
        if h < min_h then
          h = min_h
        elseif h > max_h then
          h = max_h
        end
        return { winopts = { height = h, width = 0.60, row = 0.40 } }
      end)
    end
  },
}
require("lazy").setup(plugins, {
  root = root .. "/plugins",
})

vim.cmd.colorscheme("tokyonight")
-- add anything else here

Additional context
No response

Weirdly this behavior is also the same with telecsope-ui-select.nvim so maybe the issue is somewhere else in my config? There aren't really any other moving components with vim.ui.select though...

I tested this and managed to reproduce it sometimes. There seems to be a race condition when opening the vim.ui.select UI. I added a slight delay that seems to have fixed the issue for me, can you test it?

@stevearc Ah, interesting. For me it's 100%, whether it's telescope or fzf-lua. I can test it in about an hour, thanks for the quick fix.

@stevearc Seems to have addressed the issue, no problems now. Also there is no noticeable delay when editing the task, so that is nice!


Structurizr diagram options

allow structurizr diagrams to be processed as well (see https://docs.kroki.io/kroki/setup/install/ for default)
enable/pass on diagram options

Hi @pgrund ,
thanks for your PR, it looks really good. I'm going to test it and also wait for the minor changes I've requested.

sorry, late summer break ... will try to update PR accordingly this week


Fails on Selecting Album

Version of the custom_component
0.4.4
Describe the bug
After CONFIGURE, and SELECT ALBUM, it spins for a second and then says "Error".
P.S. Thanks for the integration - it's great, and much cleaner than the brutal hack I was doing before.
Apr 01 17:01:23 archlinux hass[626391]: 2023-04-01 17:01:23.357 ERROR (MainThread) [aiohttp.server] Error handling request
Apr 01 17:01:23 archlinux hass[626391]: Traceback (most recent call last):
Apr 01 17:01:23 archlinux hass[626391]:   File "/srv/homeassistant/lib/python3.10/site-packages/aiohttp/web_protocol.py", line 433, in _handle_request
Apr 01 17:01:23 archlinux hass[626391]:     resp = await request_handler(request)
Apr 01 17:01:23 archlinux hass[626391]:   File "/srv/homeassistant/lib/python3.10/site-packages/aiohttp/web_app.py", line 504, in _handle
Apr 01 17:01:23 archlinux hass[626391]:     resp = await handler(request)
Apr 01 17:01:23 archlinux hass[626391]:   File "/srv/homeassistant/lib/python3.10/site-packages/aiohttp/web_middlewares.py", line 117, in impl
Apr 01 17:01:23 archlinux hass[626391]:     return await handler(request)
Apr 01 17:01:23 archlinux hass[626391]:   File "/srv/homeassistant/lib/python3.10/site-packages/homeassistant/components/http/security_filter.py", line 67, in security_filter_middleware
Apr 01 17:01:23 archlinux hass[626391]:     return await handler(request)
Apr 01 17:01:23 archlinux hass[626391]:   File "/srv/homeassistant/lib/python3.10/site-packages/homeassistant/components/http/forwarded.py", line 227, in forwarded_middleware
Apr 01 17:01:23 archlinux hass[626391]:     return await handler(request)
Apr 01 17:01:23 archlinux hass[626391]:   File "/srv/homeassistant/lib/python3.10/site-packages/homeassistant/components/http/request_context.py", line 28, in request_context_middleware
Apr 01 17:01:23 archlinux hass[626391]:     return await handler(request)
Apr 01 17:01:23 archlinux hass[626391]:   File "/srv/homeassistant/lib/python3.10/site-packages/homeassistant/components/http/ban.py", line 80, in ban_middleware
Apr 01 17:01:23 archlinux hass[626391]:     return await handler(request)
Apr 01 17:01:23 archlinux hass[626391]:   File "/srv/homeassistant/lib/python3.10/site-packages/homeassistant/components/http/auth.py", line 234, in auth_middleware
Apr 01 17:01:23 archlinux hass[626391]:     return await handler(request)
Apr 01 17:01:23 archlinux hass[626391]:   File "/srv/homeassistant/lib/python3.10/site-packages/homeassistant/components/http/view.py", line 146, in handle
Apr 01 17:01:23 archlinux hass[626391]:     result = await result
Apr 01 17:01:23 archlinux hass[626391]:   File "/srv/homeassistant/lib/python3.10/site-packages/homeassistant/components/config/config_entries.py", line 241, in post
Apr 01 17:01:23 archlinux hass[626391]:     return await super().post(request, flow_id)
Apr 01 17:01:23 archlinux hass[626391]:   File "/srv/homeassistant/lib/python3.10/site-packages/homeassistant/components/http/data_validator.py", line 72, in wrapper
Apr 01 17:01:23 archlinux hass[626391]:     result = await method(view, request, data, *args, **kwargs)
Apr 01 17:01:23 archlinux hass[626391]:   File "/srv/homeassistant/lib/python3.10/site-packages/homeassistant/helpers/data_entry_flow.py", line 110, in post
Apr 01 17:01:23 archlinux hass[626391]:     result = await self._flow_mgr.async_configure(flow_id, data)
Apr 01 17:01:23 archlinux hass[626391]:   File "/srv/homeassistant/lib/python3.10/site-packages/homeassistant/data_entry_flow.py", line 267, in async_configure
Apr 01 17:01:23 archlinux hass[626391]:     result = await self._async_handle_step(
Apr 01 17:01:23 archlinux hass[626391]:   File "/srv/homeassistant/lib/python3.10/site-packages/homeassistant/data_entry_flow.py", line 367, in _async_handle_step
Apr 01 17:01:23 archlinux hass[626391]:     result: FlowResult = await getattr(flow, method)(user_input)
Apr 01 17:01:23 archlinux hass[626391]:   File "/home/hassio/.homeassistant/custom_components/google_photos/config_flow.py", line 192, in async_step_albumselect
Apr 01 17:01:23 archlinux hass[626391]:     data_schema = await self._get_albumselect_schema()
Apr 01 17:01:23 archlinux hass[626391]:   File "/home/hassio/.homeassistant/custom_components/google_photos/config_flow.py", line 163, in _get_albumselect_schema
Apr 01 17:01:23 archlinux hass[626391]:     album["title"], album["mediaItemsCount"]
Apr 01 17:01:23 archlinux hass[626391]: KeyError: 'mediaItemsCount'

Looks like the same issue as #4. Somehow in some cases the Google Api returns partial data. Should be easy fixable.

Please give v0.5.0 a try. There should be an entry in your albums list that has (? items) behind album name, if possible I would like to hear back what type of album that is, maybe some special album? It would help me to figure out what is causing these issues.

Installed 0.5.0 and it seems quite happy now - thank you!
There were four albums that had a ? after them (out of about 100 albums). Nothing special in those albums with the question mark (i.e., the ones that had the correct count had up to 20,000 photos in them and worked fine when selected).
In any event, it seems to be working well now.


Weird bug with tooltips and dbekel

If the word is already a root word, then it shouldn't show itself twice....

Fixed.

Problem was that it was adding root word when the english def is missing. Instead it should only add root word when english def is missing AND it is not already the root word.


⚠ ClamAV has degraded performance

In fea9675, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 75 ms

Resolved: ClamAV performance has improved in de3e629 after 7 minutes.


Same image but gibberish as output

Added two images to demo the issue.
Latest.png

Latest-paint.png

The only difference is how they are saved.
Latest.png: This one is saved directly in C# using the bitmap.Save method.
Latest-paint.png: Opened Latest.png in paint and Saved As Latest-paint.png
Image image1 = Image.FromFile("latest.png");
Image image2 = Image.FromFile("latest-paint.png");
Tesseract tesseract = new Tesseract();

Console.WriteLine(tesseract.Read(image1).Trim());
Console.WriteLine(tesseract.Read(image2).Trim());

Output
Seawe Wee agg
Great Axe of the Sage

Any idea what is going on?

Thinks I found the issue:
https://stackoverflow.com/questions/52100703/bug-in-windows-nets-system-drawing-savestream-imageformat-corrupt-png-pro
Something is going wrong with the bitmap save function.
I now skip the bitmap and use the OpenCV save function instead. Working fine now.


[chip-test] chip_rv_dm_access_after_hw_reset

Test point name
chip_rv_dm_access_after_hw_reset
Host side component
No response
OpenTitanTool infrastructure implemented
No response
Contact person
@tjaychen, @msf, @jeoongp
Checklist
Please fill out this checklist as items are completed. Link to PRs and issues as appropriate.

[ ] Check if existing test covers most or all of this testpoint (if so, either extend said test to cover all points, or skip the next 3 checkboxes)
[ ] Device-side (C) component developed
[ ] Bazel build rules developed
[ ] Host-side component developed
[ ] HJSON test plan updated with test name (so it shows up in the dashboard)
[ ] Test added to dvsim nightly regression (and passing at time of checking)

Looks like this test is already developed: https://github.com/lowRISC/opentitan/pull/15725

I am sorry I got confused by the title of PR #15725, which actually addresses #14152. Reassigning it back to myself.

Test development is now complete. Waves with JTAG DMI accesses before and after escalation reset:

I am running the CSR RW test on the DMI register space via JTAG on a loop. I have reused the SW test from chip_sw_alert_handler_escalation test for this test.


update singular collection link

to new website url

The link was set on collection creation and cannot be updated. This is note for future collections though. Will throw it into the sendout script repo as the changes need to be made on that code.


UnhandledPromiseRejectionWarning: TypeError: Cannot read property 'records' of null

Hi first of all, thank u for your extensions :)
Describe the bug
I tried to generate release notes using the sample template from the documentation.
This results in the following error:
(node:3680) UnhandledPromiseRejectionWarning: TypeError: Cannot read property 'records' of null
    at /home/vsts/work/_tasks/XplatGenerateReleaseNotes_7b0a5887-75c4-4ade-a915-f92a93c934cb/3.2.2/ReleaseNotesFunctions.js:565:74
    at Generator.next (<anonymous>)
    at fulfilled (/home/vsts/work/_tasks/XplatGenerateReleaseNotes_7b0a5887-75c4-4ade-a915-f92a93c934cb/3.2.2/ReleaseNotesFunctions.js:5:58)
    at process._tickCallback (internal/process/next_tick.js:68:7)
(node:3680) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 1)
(node:3680) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

Remember that there are a number of Azure DevOps (VSTS) extensions in this repo so please say which one you are using, and if an extension contains multiple tasks which task also
Extension: XplatGenerateReleaseNotes
To Reproduce
I use the following configuration:
- task: XplatGenerateReleaseNotes@3
  inputs:
    outputfile: '$(Build.ArtifactStagingDirectory)\releasenotes.md'
    outputVariableName: 'kycnow-dev-release'
    templateLocation: 'InLine'
    inlinetemplate: |
      **Release Notes**

      [[_TOC_]]

      # Notes for release  {{releaseDetails.releaseDefinition.name}}
      **Release Number**  : {{releaseDetails.name}}
      **Release completed** : {{releaseDetails.modifiedOn}}
      **Build Number**: {{buildDetails.id}}
      **Compared Release Number**  : {{compareReleaseDetails.name}}
      **Build Trigger PR Number**: {{lookup buildDetails.triggerInfo 'pr.number'}}

      # Associated Pull Requests ({{pullRequests.length}})
      {{#forEach pullRequests}}
      {{#if isFirst}}### Associated Pull Requests (only shown if  PR) {{/if}}
      *  **PR {{this.id}}**  {{this.title}}
      {{/forEach}}

      # Builds with associated WI/CS/Tests ({{builds.length}})
      {{#forEach builds}}
      {{#if isFirst}}## Builds {{/if}}
      ##  Build {{this.build.buildNumber}}
      {{#forEach this.commits}}
      {{#if isFirst}}### Commits {{/if}}
      - CS {{this.id}}
      {{/forEach}}
      {{#forEach this.workitems}}
      {{#if isFirst}}### Workitems {{/if}}
      - WI {{this.id}}
      {{/forEach}}
      {{#forEach this.tests}}
      {{#if isFirst}}### Tests {{/if}}
      - Test {{this.id}}
        -  Name: {{this.testCase.name}}
        -  Outcome: {{this.outcome}}
      {{/forEach}}
      {{/forEach}}

      # Global list of WI ({{workItems.length}})
      {{#forEach this.workItems}}
      {{#if isFirst}}### WorkItems {{/if}}
      *  **{{this.id}}**  {{lookup this.fields 'System.Title'}}
        - **WIT** {{lookup this.fields 'System.WorkItemType'}}
        - **Tags** {{lookup this.fields 'System.Tags'}}
        - **Assigned** {{#with (lookup this.fields 'System.AssignedTo')}} {{displayName}} {{/with}}
        - **Description** {{{lookup this.fields 'System.Description'}}}
        - **Parents**
      {{#forEach this.relations}}
      {{#if (contains this.attributes.name 'Parent')}}
      {{#with (lookup_a_work_item ../../relatedWorkItems  this.url)}}
            - {{this.id}} - {{lookup this.fields 'System.Title'}}
      {{/with}}
      {{/if}}
      {{/forEach}}
        - **Children**
      {{#forEach this.relations}}
      {{#if (contains this.attributes.name 'Child')}}
      {{#with (lookup_a_work_item ../../relatedWorkItems  this.url)}}
            - {{this.id}} - {{lookup this.fields 'System.Title'}}
      {{/with}}
      {{/if}}
      {{/forEach}}
      {{/forEach}}

      # Global list of CS ({{commits.length}})
      {{#forEach commits}}
      {{#if isFirst}}### Associated commits{{/if}}
      * ** ID{{this.id}}**
        -  **Message:** {{this.message}}
        -  **Commited by:** {{this.author.displayName}}
        -  **FileCount:** {{this.changes.length}}
      {{#forEach this.changes}}
            -  **File path (TFVC or TfsGit):** {{this.item.path}}
            -  **File filename (GitHub):** {{this.filename}}
      {{/forEach}}
      {{/forEach}}
    checkStage: true
    overrideStageName: 'dev'
    stopOnRedeploy: false
    sortWi: true
    dumpPayloadToConsole: false
    dumpPayloadToFile: false
    replaceFile: true
    getParentsAndChildren: true

Expected behavior
No error is being thrown and release notes get generated.
Screenshots
If applicable, add screenshots to help explain your problem.
Logs
Starting: XplatGenerateReleaseNotes
==============================================================================
Task         : Generate Release Notes (Crossplatform)
Description  : Generates a release notes file in a format of your choice from the build or release history
Version      : 3.2.2
Author       : Black Marble
Help         : Version: 3.2.2. [More Information](https://github.com/rfennell/AzurePipelines/wiki/GenerateReleaseNotes---Node-based-Cross-Platform-Task/)
==============================================================================
Getting the current build details
Overriding current stage '__default' with 'dev'
Getting items associated the builds since the last successful build to the stage 'dev'
Comparing 441 against 441
Ignore compare against self
Comparing 440 against 441
Comparing 439 against 441
Comparing 438 against 441
Comparing 437 against 441
Comparing 436 against 441
(node:3680) UnhandledPromiseRejectionWarning: TypeError: Cannot read property 'records' of null
    at /home/vsts/work/_tasks/XplatGenerateReleaseNotes_7b0a5887-75c4-4ade-a915-f92a93c934cb/3.2.2/ReleaseNotesFunctions.js:565:74
    at Generator.next (<anonymous>)
    at fulfilled (/home/vsts/work/_tasks/XplatGenerateReleaseNotes_7b0a5887-75c4-4ade-a915-f92a93c934cb/3.2.2/ReleaseNotesFunctions.js:5:58)
    at process._tickCallback (internal/process/next_tick.js:68:7)
(node:3680) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 1)
(node:3680) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
Finishing: XplatGenerateReleaseNotes

What is the issue see:

Azure DevOps Services (VSTS)

Additional context
Add any other context about the problem here.

The Problem does not occur, when setting
   checkStage: false

The issue appears to be that when looking for the last successful build it find a build but cannot get any timeline details. As I had assumed there is always a timeline it fails. My guess is that it is a cancelled build
I will add a null check to trap this and hopefully get a new release today

and yes  checkStage: false is a different code path, so that makes sense
Thank @Nerzal for the detailed fault report, it really helps

This is being released as 3.3.10
Let me know how it goes, re-open if you still have an issue

It seems to work, the log now shows for the problematic builds.
Thank you for the fast response and fix <3

Skipping check as no timeline available for this build


Add ECS Service scale up/down controls

Adds Scale Up / Scale Down controls for ECS services in the same manner as Kubernetes Replica Sets/Deployments.
Note this requires an additional permission "ecs:UpdateService". Documentation will need to be changed to include this.
However I don't know where that particular documentation is kept (perhaps an argument for keeping the documentation in-repo,
so it can be modified in conjunction with code changes instead of as an afterthought).
Partially addresses https://github.com/weaveworks/scope/issues/2051

rebased onto master now that https://github.com/weaveworks/scope/pull/2186 is merged.

Tests failed due to https://github.com/weaveworks/scope/pull/2220, retrying for now since this obviously isn't happening in most test runs.

Not AFAIK. But to be consistent with the rest (e.g. stop button for
containers) I think making it disappear is the right thing
On Feb 9, 2017 11:10 PM, "Mike Lang"<EMAIL_ADDRESS>wrote:

@ekimekim commented on this pull request.
In probe/awsecs/reporter.go
https://github.com/weaveworks/scope/pull/2197:

@@ -126,10 +149,11 @@ func (r Reporter) Tag(rpt report.Report) (report.Report, error) {
for serviceName, service := range ecsInfo.Services {
serviceID := report.MakeECSServiceNodeID(cluster, serviceName)
rpt.ECSService = rpt.ECSService.AddNode(report.MakeNodeWith(serviceID, map[string]string{

		Cluster:             cluster,

		ServiceDesiredCount: fmt.Sprintf("%d", service.DesiredCount),

		ServiceRunningCount: fmt.Sprintf("%d", service.RunningCount),

	}))

		Cluster:               cluster,

		ServiceDesiredCount:   fmt.Sprintf("%d", service.DesiredCount),

		ServiceRunningCount:   fmt.Sprintf("%d", service.RunningCount),

		report.ControlProbeID: r.probeID,

	}).WithLatestActiveControls(ScaleUp, ScaleDown))

Ack. Is there a way to have the minus button there but greyed out? I know
I can set it "dead" but that makes it disappear, not "disabled", iiuc?
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
https://github.com/weaveworks/scope/pull/2197, or mute the thread
https://github.com/notifications/unsubscribe-auth/ACQOJLZBkvjvB2NrkynGGChOq_ozO3cNks5ra47igaJpZM4L4y4E
.

@ekimekim ping

PTAL

ptal


cargo build --out-dir does not place tests in out dir

Problem
Test binaries are not copied to out dir.
Repro:

clone any repo with tests for example https://github.com/servo/rust-fnv
cargo build -Zunstable-options --out-dir 11 copies rlib to directory 11
cargo build -Zunstable-options --tests --out-dir 11 does not place test binary in 11 directory

cargo build --help says:
--out-dir <PATH>          Copy final artifacts to this directory (unstable)

Not clear what is "final artifact", but if a user requested to build a test, then the test binary must be the artifact?
Proposed Solution
Unknown. I built a test, and now I need to debug it. How do I find the test binary path?
Notes
No response

Thanks for the report and please see https://github.com/rust-lang/cargo/issues/11110.
https://github.com/rust-lang/cargo/issues/3670 may also have a possible route to the solution. I am not really sure though.


Ensure links don't overflow on mobile

On the index page, links don't break nicely on mobile.  This pr resolves that in a generic way

Watch out for rabbit holes here. And please consult with product owners if we should address these points.

Other then that this is a perfectly elegant change and improvement.


Rename get_decimals to get_spot_decimals

Imo we should get this in with 1.0 as it breaks the API. We can add get_generic_decimals and get_future_decimals later.

I noticed some of the code paths on the client were not tested, e.g. get_future is not an endpoint on the contract and even if it was implemented the typo would have meant the method is broken. Not sure what the best way is to increase testing (these paths aren't critical for operation but good for dev experience if methods aren't broken).

I noticed some of the code paths on the client were not tested, e.g. get_future is not an endpoint on the contract and even if it was implemented the typo would have meant the method is broken. Not sure what the best way is to increase testing (these paths aren't critical for operation but good for dev experience if methods aren't broken).

Typo?

I noticed some of the code paths on the client were not tested, e.g. get_future is not an endpoint on the contract and even if it was implemented the typo would have meant the method is broken. Not sure what the best way is to increase testing (these paths aren't critical for operation but good for dev experience if methods aren't broken).

Typo?

https://github.com/42labs/Empiric/pull/221/files#diff-a061301cba3dd3171df25d029beb6ff7423a75cf70171b4e6ed6f380c99d27e9L138

I noticed some of the code paths on the client were not tested, e.g. get_future is not an endpoint on the contract and even if it was implemented the typo would have meant the method is broken. Not sure what the best way is to increase testing (these paths aren't critical for operation but good for dev experience if methods aren't broken).

Typo?

I was referring to the typo here, the fn called get_futures inside get_future, when the endpoint on the oracle contract a) doesn't exist yet (this is expected due to prioritization) but b) if it existed would be called get_future. https://github.com/42labs/Empiric/pull/221/files#diff-a061301cba3dd3171df25d029beb6ff7423a75cf70171b4e6ed6f380c99d27e9L138
There was also a small bug here that mixed up pair_id and currency in the get_decimals call on the cli: https://github.com/42labs/Empiric/pull/221/files#diff-d799230821ccb1a49de9873e82e07c57c5e2c226987abdd6cbb2c64b0a8ec69dL166
Both of these a very basic test would have caught, so I created #222

ok that makes sense now, was super confused.  Yep, this looks good!