fix typo in argument description

@CodiumAI-Agent /review

PR Review

 ⏱ Estimated effort to review [1-5]
1, because the PR consists of a single, straightforward change: fixing a typo in an argument description. This change is easy to review and does not require in-depth analysis or testing.

 🧪 Relevant tests
No

 🔍 Possible issues
No

 🔒 Security concerns
No

 Code feedback:

 ✨ Review tool usage guide:
Overview:
The review tool scans the PR code changes, and generates a PR review. The tool can be triggered automatically every time a new PR is opened, or can be invoked manually by commenting on any PR.
When commenting, to edit configurations related to the review tool (pr_reviewer section), use the following template:
/review --pr_reviewer.some_config1=... --pr_reviewer.some_config2=...

With a configuration file, use the following template:
[pr_reviewer]
some_config1=...
some_config2=...

  Utilizing extra instructions
The review tool can be configured with extra instructions, which can be used to guide the model to a feedback tailored to the needs of your project.
Be specific, clear, and concise in the instructions. With extra instructions, you are the prompter. Specify the relevant sub-tool, and the relevant aspects of the PR that you want to emphasize.
Examples for extra instructions:
[pr_reviewer] # /review #
extra_instructions="""
In the 'possible issues' section, emphasize the following:
- Does the code logic cover relevant edge cases?
- Is the code logic clear and easy to understand?
- Is the code logic efficient?
...
"""

Use triple quotes to write multi-line instructions. Use bullet points to make the instructions more readable.

  How to enable\disable automation

When you first install PR-Agent app, the default mode for the review tool is:

pr_commands = ["/review", ...]

meaning the review tool will run automatically on every PR, with the default configuration.
Edit this field to enable/disable the tool, or to change the used configurations

  Auto-labels
The review tool can auto-generate two specific types of labels for a PR:

a possible security issue label, that detects possible security issues (enable_review_labels_security flag)
a Review effort [1-5]: x label, where x is the estimated effort to review the PR (enable_review_labels_effort flag)

  Extra sub-tools
The review tool provides a collection of possible feedbacks about a PR.
It is recommended to review the possible options, and choose the ones relevant for your use case.
Some of the feature that are disabled by default are quite useful, and should be considered for enabling. For example:
require_score_review, require_soc2_ticket, require_can_be_split_review, and more.

  Auto-approve PRs
By invoking:
/review auto_approve

The tool will automatically approve the PR, and add a comment with the approval.
To ensure safety, the auto-approval feature is disabled by default. To enable auto-approval, you need to actively set in a pre-defined configuration file the following:
[pr_reviewer]
enable_auto_approval = true

(this specific flag cannot be set with a command line argument, only in the configuration file, committed to the repository)
You can also enable auto-approval only if the PR meets certain requirements, such as that the estimated_review_effort is equal or below a certain threshold, by adjusting the flag:
[pr_reviewer]
maximal_review_effort = 5

  More PR-Agent commands

To invoke the PR-Agent, add a comment using one of the following commands:

/review: Request a review of your Pull Request.
/describe: Update the PR title and description based on the contents of the PR.
/improve [--extended]: Suggest code improvements. Extended mode provides a higher quality feedback.
/ask <QUESTION>: Ask a question about the PR.
/update_changelog: Update the changelog based on the PR's contents.
/add_docs 💎: Generate docstring for new components introduced in the PR.
/generate_labels 💎: Generate labels for the PR based on the PR's contents.
/analyze 💎: Automatically analyzes the PR, and presents changes walkthrough for each component.

See the tools guide for more details.
To list the possible configuration parameters, add a /config comment.

See the review usage page for a comprehensive guide on using this tool.

PR Analysis

🎯 Main theme: Fixing a typo in the description of a Python script
📝 PR summary: The PR is a simple one, fixing a typo in the description of a Python script. The typo is in the argument description of a parser in the script 'train_single_label_from_scratch.py'.
📌 Type of PR: Bug fix
🧪 Relevant tests added: No
⏱ Estimated effort to review [1-5]: 1, because the PR is straightforward and only involves a minor text change.
🔒 Security concerns: No

PR Feedback
💡 General suggestions: The PR is simple and straightforward, fixing a typo in the description of a Python script. No major suggestions are needed.

 ✨ Usage guide:
Overview:
The review tool scans the PR code changes, and generates a PR review. The tool can be triggered automatically every time a new PR is opened, or can be invoked manually by commenting on any PR.
When commenting, to edit configurations related to the review tool (pr_reviewer section), use the following template:
/review --pr_reviewer.some_config1=... --pr_reviewer.some_config2=...

With a configuration file, use the following template:
[pr_reviewer]
some_config1=...
some_config2=...

  Utilizing extra instructions
The review tool can be configured with extra instructions, which can be used to guide the model to a feedback tailored to the needs of your project.
Be specific, clear, and concise in the instructions. With extra instructions, you are the prompter. Specify the relevant sub-tool, and the relevant aspects of the PR that you want to emphasize.
Examples for extra instructions:
[pr_reviewer] # /review #
extra_instructions="""
In the code feedback section, emphasize the following:
- Does the code logic cover relevant edge cases?
- Is the code logic clear and easy to understand?
- Is the code logic efficient?
...
"""

Use triple quotes to write multi-line instructions. Use bullet points to make the instructions more readable.

  How to enable\disable automation

When you first install PR-Agent app, the default mode for the review tool is:

pr_commands = ["/review", ...]

meaning the review tool will run automatically on every PR, with the default configuration.
Edit this field to enable/disable the tool, or to change the used configurations

  About the 'Code feedback' section
The review tool provides several type of feedbacks, one of them is code suggestions.
If you are interested only in the code suggestions, it is recommended to use the improve feature instead, since it dedicated only to code suggestions, and usually gives better results.
Use the review tool if you want to get a more comprehensive feedback, which includes code suggestions as well.

  Auto-labels
The review tool can auto-generate two specific types of labels for a PR:

a possible security issue label, that detects possible security issues (enable_review_labels_security flag)
a Review effort [1-5]: x label, where x is the estimated effort to review the PR (enable_review_labels_effort flag)

  Extra sub-tools
The review tool provides a collection of possible feedbacks about a PR.
It is recommended to review the possible options, and choose the ones relevant for your use case.
Some of the feature that are disabled by default are quite useful, and should be considered for enabling. For example:
require_score_review, require_soc2_review, enable_review_labels_effort, and more.

  More PR-Agent commands

To invoke the PR-Agent, add a comment using one of the following commands:

/review: Request a review of your Pull Request.
/describe: Update the PR title and description based on the contents of the PR.
/improve [--extended]: Suggest code improvements. Extended mode provides a higher quality feedback.
/ask <QUESTION>: Ask a question about the PR.
/update_changelog: Update the changelog based on the PR's contents.
/add_docs 💎: Generate docstring for new components introduced in the PR.
/generate_labels 💎: Generate labels for the PR based on the PR's contents.
/analyze 💎: Automatically analyzes the PR, and presents changes walkthrough for each component.

See the tools guide for more details.
To list the possible configuration parameters, add a /config comment.

See the review usage page for a comprehensive guide on using this tool.


[BUG] Status reports podman preset while microshift is running

General information

OS: macOS
Hypervisor: hyperkit
Did you run crc setup before starting it: Yes
Running CRC on: Laptop

CRC version
CRC version: 2.16.0+05b62a75
OpenShift version: 4.12.9
Podman version: 4.4.1

CRC status
DEBU CRC version: 2.16.0+05b62a75
DEBU OpenShift version: 4.12.9
DEBU Podman version: 4.4.1
DEBU Running 'crc status'
CRC VM:          Running
RAM Usage:       1.196GB of 3.913GB
Disk Usage:      4.746GB of 16.1GB (Inside the CRC VM)
Cache Usage:     72.04GB
Cache Directory: /Users/yevhen/.crc/cache

CRC config
- consent-telemetry                     : no
- preset                                : microshift

Host Operating System
ProductName:		macOS
ProductVersion:		13.3
BuildVersion:		22E252

Steps to reproduce

Configure crc to use microshift bundle
Start crc with microshift bundle
Call curl -GET -i --unix-socket <home>/.crc/crc-http.sock http://localhost/api/status to get status in json

Expected
{"CrcStatus":"Running", "Preset":"microshift", ...}

Actual
{"CrcStatus":"Running", "Preset":"podman",  ...}

Logs

Looks like the problem there https://github.com/crc-org/crc/blob/0bce019118562bece4ac55fd99324bb59ee61d3a/pkg/crc/machine/status.go#L38-L45

@praveenkumar This should be fixed.


Say goodbye to arcoe

Basically what the title says.

bors r+

bors r-

bors r+

bors r-

bors r+

bors r-

bors r+


Load custom packages in bundle directory

A couple examples would be a third-party plugin such as PeepOpen, or for testing plugins and color schemes.

I'd like to +1 this. Just tried to install and run the eclim plugin. It has a GUI based installer the stores the vim plugin files int ~/.vim/eclim I tried to symlink it into the bundle folder but then couldn't figure out how to tell Vundle to load it into the runtime.
For now I think the solution is to bypass Vundle and use set rtp+=~/.vim/eclim for now.


Add kube-burner's cluster-density & kubelet-density-heavy

cc: @chaitanyaenr @mohit-sheth @jtaleric
Signed-off-by: Raul Sevilla<EMAIL_ADDRESS>

LGTM, we can remove mastervert and nodevert bits from the Jenkinsfile.

ok, will open a new PR to remove them


Support game titles

Describe the solution you'd like
From a user: "Would be nice if I could give the game/table a name or title"

The user didn't know about ~tag when they suggested this idea. Perhaps the real solution here is to make tag support more visible.
On idea: we could ask the user if they meant to use a tag when they run a command like !lfg modern. For example:
user> !lfg modern
spellbot> [game embed]
spellbot DM to user> Hello @user. I noticed you used the parameter "modern" in a recent command. Unfortunately I didn't know what to do with that parameter. Did you want it to be used as a tag? In that case you can use `~` to create tags. Such as `!lfg ~modern`.


Clickhouse/sink: support clickhouse-cloud

ClickHouse Cloud use special table engine, for now it's not supported as a target

Apparently current code works fine, just need to write demo-example how it works


Use sha256 in test

Some aggressive dependency checks flag the use of md5.
Switch to sha256 as it accomplishes the same purpose.

\cc @neild FYI, I've been using "squash+merge" rather than just "merge" to keep the code history cleaner.


Fit and finish

[x] more tests for ClickHouseInputStream
[x] use separate thread pool for I/O(instead of commonPool)
[ ] enhance prepared statement for below two use cases
[ ] support more AggregateFunction types

Bear in mind that a JDBC connection pool might create some dozens of connections ahead of time for reuse. If each of these connections spawns another threadpool, we might run into issues.

Bear in mind that a JDBC connection pool might create some dozens of connections ahead of time for reuse. If each of these connections spawns another threadpool, we might run into issues.

max_threads_per_client defaults to zero, but when it's configured with a number greater than zero, each client will have its own thread pool, instead of reusing ClickHouseClient.defaultExecutor. Maybe keep alive timeout should be set for core pool as well to avoid the situation of having too many idle threads.


Map remaining entities as well EntityRegistry.

Parent classes of entities still not mapped, let me know if things should be moved. The names should be correct though.

#12


Schematic (DSN) Support

Hi, thank you for providing this tool. It's a easy way for me to get images of OrCAD library parts. I would like to do the same for schematics. Do you have plans or already some code to convert OrCAD schematic XMLs into the KiCad format?
BR Dominik

Hi, no, I had that on my TODO list for some time but never worked on this.
I would be great to develop this tool directly as a KiCAD plugin. At some point I should also integrate this work as a KiCAD plugin.

Thanks for the feedback. In a few months I plan on starting to work on a OrCad importer but on the binary format in contrast to the XML file. Nonetheless, a lot of code could probably be shared.


Added new notebook editor field

Looks like the experimental notebook api has been deprecated. Solved it for now by adding an additional field name.
We should really think about updating to vscode version 1.68 and get these as proper types.
https://github.com/DefinitelyTyped/DefinitelyTyped/blob/1a72ad27159fcb85c0d951e6ff2fd19f47017ab0/types/vscode/index.d.ts#L12793
Checklist

[ ] I have added tests
[ ] I have updated the docs and cheatsheet
[ ] I have not broken the cheatsheet

Yes


Missmatch seaborn vs R?

@nitinef , I am either missing something or is not matching the charts I do with seaborn:

The 100% should be on the right side right?
Also the scatter points are not matching, something is wrong (seaborn or R)
Originally posted by @ssardina in https://github.com/ssardina-research/cfond-asp-private/issues/41#issuecomment-2306286575

@ssardina please check with a fresh pull?

Ohh great, much better now
Now the average CPU numbers are wrong in one of the two charts. They are the same but in the wrong places. I think the error must be in MY seaborn, I will check it:

See S2 has 1445 in the R version, but that number shows up under A1 in my script :laughing:

Seems the seaborn is not plotting well the scattered points against the correct solver

OK so after analysis with specific data spiky-tireworld domain and A2 solver:

Both have correct coverage %
R has correct scatter points, Python has it wrong (in another solver)
Python has correct cputime mean, R has it wrong (in another solver)

I have fixed the seaborn plot and improve its looks.
I confirm the scatter points are correctly placed now.

Fantastic @nitinef , great team-work. Now both Python and R match perfectly and I have verified numbers do correspond to tables (coverage + scatter points + cputime mean):


error file flv type

i use video type flv H.264+AAC and get error ....

A decode error may occurred.
Please provide the related logcat in chrome://media-internals

error Append: stream parsing failed. Data size=131072 append_window_start=0 append_window_end=inf

Can you provide your stream file for test?

You can download video demo test https://drive.google.com/file/d/0B9IY9Jqs0bRDQURQN2Q2ZE5jaGs/view?usp=sharing
Thank you

There're errors in the video track. If you remux it into an mp4 file, the video is complete black in the browser or Apple QuickTime player.


Add operations of MaxPane to command pallet

This is useful for windows/linux users that haven't mapped the commands to shortcuts, they can still use the commands right after installing.  Having the operations in the command pallet is also useful for users that aren't utilizing MaxPane often.

👍 Thanks

@jisaacks The *.sublime-commands file has a typo in its name, functionality wise that shouldn't be an issue, though.

Oops...lol


Fix syntax for app.toml variables

minimum_gas_prices should be minimum-gas-prices to match the contents of app.toml.

Fix in PR #73


Construct tree from inorder and postorder

hey @ayu8 I want to add this in binary tree folder. Pls assign me this and mark this under hacktoberfest label.

hey @ayu8 I want to add the solution in c++. Pls assign me this and mark this under hacktoberfest label.


Fix custom file input focus border color

Fixes #27112.
Also did a tiny optimalization for the border of the browse button. The left border from the ::after pseudo element is now inherited from the element so you don't have to define the border color for every state and the transition of the border color is also applied to the browse button.
Demo: https://codepen.io/MartijnCuppens/pen/bxEyrQ

LGTM 👍


flutter/packages Docker image is not hermetic

Most of flutter/plugins CI is run on a Docker image that is defined by https://github.com/flutter/plugins/blob/master/.ci/Dockerfile
Usually it's cached, so things are stable, but if it's rebuilt for any reason things tend to break. This can happen:

when we explicitly change it (e.g., to add a new requirement, such as the dependencies for a new platform or test type)
apparently for reasons outside our control (see https://github.com/flutter/flutter/issues/84706), which we're following up on

https://github.com/flutter/flutter/issues/84706 is a severe form of the problem, but we've also had issues in the past such as chromedriver breaking. We should try to eliminate things in the Dockerfile that are not pinned versions:

Use of google-chrome-stable (this is a common source of problems)
cirrusci/flutter:stable as a base image (likely the reason https://github.com/flutter/flutter/issues/84706 happened)
Potentially the rest of our apt-gets? I'm not familiar enough with the way it does version management to know whether pinning our base image is enough to make those effectively pinned. I assume the apt-get update step means it's not, and all of those are potentially sources of issues (e.g., clang-format version changing, thus failing formatter checks)

Potentially the rest of our apt-gets? I'm not familiar enough with the way it does version management to know whether pinning our base image is enough to make those effectively pinned. I assume the apt-get update step means it's not, and all of those are potentially sources of issues (e.g., clang-format version changing, thus failing formatter checks)

Provided that cirrusci doesn't change the underlying ubuntu release (which I'm not sure is a given), ubuntu stable releases are pretty good about only applying backwards-compatible bug fixes in updates. I think it's important that we still do apt-get update && apt-get upgrade when re-building docker images.

Provided that cirrusci doesn't change the underlying ubuntu release (which I'm not sure is a given)

We're now pinning the base image to a specific Flutter version image rather than stable, with the assumption that those are not regenerated.

For some additional context, my understanding is the reason we're not allowed to keep container images around for more than 6 months is because we're supposed to re-build and pick up OS backports.

the reason we're not allowed to keep container images around for more than 6 months

To clarify, there are two issues:

The Dockerfile is not hermetic (this one)
The Dockerfile is regenerated without warning or human involvement (https://github.com/flutter/flutter/issues/85041)

The retention policy, and how to make a system that works better in cooperation with it, is the second issue. They are related in that the combination of the two issues is dramatically worse than either one in isolation, but even before there was a retention issue (when we were using purely Cirrus), this issue was a problem because it made making any change to the Dockerfile potentially painful. E.g., when I needed to add Linux desktop dependencies, I had to debug and fix issues related to web tests failing due to getting a new version of Chrome, even though I didn't intend to change that.

the reason we're not allowed to keep container images around for more than 6 months

To clarify, there are two issues:

The Dockerfile is not hermetic (this one)
The Dockerfile is regenerated without warning or human involvement (flutter/plugins Docker images are discarded every 90 days #85041)

The retention policy, and how to make a system that works better in cooperation with it, is the second issue. They are related in that the combination of the two issues is dramatically worse than either one in isolation, but even before there was a retention issue (when we were using purely Cirrus), this issue was a problem because it made making any change to the Dockerfile potentially painful. E.g., when I needed to add Linux desktop dependencies, I had to debug and fix issues related to web tests failing due to getting a new version of Chrome, even though I didn't intend to change that.

Understood. I just mention the retention policy in the context of whether we should be doing apt-get upgrade in our Dockerfile, which I believe we should be, even though it technically makes the Dockerfile non-hermetic.

Downloading priority as the remaining unpinned items are much less problematic (and it's unclear per discussion above if pinning them is the right approach).
I do think we should consider a fully-pinned-with-roller approach for all of those dependencies though.

@stuartmorgan are there not plans to fully migrate this repo to LUCI?

There are, but at least one version of the plan involves having Docker support in LUCI. I'm not sure we will actually need that, but it's not a given at this point that this will go away.

There are, but at least one version of the plan involves having Docker support in LUCI. I'm not sure we will actually need that, but it's not a given at this point that this will go away.

Ahh ok, good to know.


copies

Hi Brian ,
the issue description has not been saved, would you mind adding the details about the issue?
Thank you in advance!

Hello Zdenek,
I have not forwarded any Debian CUPS bugs upstream in the pat week. Nor have I submitted any on my own behalf. Also, I would never use such an uninformative subject header.
I do have two computers connected to the same screen and, on occasion, use the wrong keyboard (the output would not be on the screen). Then, if I pressed a mouse button anf the ponter happened to be on Comment...
Closing. Apologies for the unintended noise.


Example: Switching to TypeScript

Hey! Love the repo and saw that some people mentioned TS so I wanted to provide a working example in case you decide to switch. The demo, tests and the build process are working and it's emitting both CJS and ESM modules in case you want to publish it to NPM. Right now it's allowing a lot of any types in the build since it would be a lot of work to specify all of those but I did add a few types here and there to get things working. If you run npm run check you'll see there are a lot of types to add but mixed in there will be some things that are potentially bugs.
I see that my branch is behind now so don't worry about merging this but feel free to use it as an example!

This is awesome. I'm looking through your code, and although I have made some alterations (so it is currently conflicting), I'll still definitely implement your suggestions on the current branch. Thank you so much for the help!

@eduardoleao052  Saw the article on hackernews and great job I'm a fan! Some good config suggestions in the commit!
I'm not a TS expert but it might be worth opening another PR specifically (or couple) for TS support and incrementally add type annotations as you go, you've got a good starting config setup that could be merged in this PR so might want to merge that with main.
Just my two cents and by no means should be followed, would be starting with method arguments and returns for those that should be annotated rather than inferred might be a good first step.

@eduardoleao052 I've applied the same changes to bring my branch up to date. I wouldn't mind changing the base branch that the PR is against if you want to keep main in JS, just let me know if you want to do that and what the branch name is. I think you could find quite a few potential bugs by running npm run check in this branch.
I also switched over to using tsx instead of ts-node and pkgroll for building to make the configuration simpler.

@eduardoleao052 I've applied the same changes to bring my branch up to date. I wouldn't mind changing the base branch that the PR is against if you want to keep main in JS, just let me know if you want to do that and what the branch name is. I think you could find quite a few potential bugs by running npm run check in this branch.
I also switched over to using tsx instead of ts-node and pkgroll for building to make the configuration simpler.

That’s great! I was about to try to it, great timing! I’ll review it during the weekend, and merge it in! Thank you so much @pparke and @medic-code!

No problem! Glad you like the changes! I did a rebase but you might still want to check the commits that re-applied the changes since I had to resolve those manually. They weren't too complex so I think I got everything but a quick review never hurts. I named the commits according to the ones they were re-implementing so it should be easy to do a side by side comparison.
The one thing I haven't done is to figure out how to include the JS for the demo. I think copying the file from dist to the demo dir during the build would be best.

Just made that change so that the demo will work without building first.

Just made that change so that the demo will work without building first.

Cool!

Ok, it's all working! Now I'll get into solving the 263 type errors! :D
The code is really nice, and pretty minimalistic! I just have a couple of questions (as I'm a bit of a TypeScript noob):

1 - About the dev dependencies: typescript, pkgroll, tsx and copyfiles are being used in package.json. But are del-cli, move-file-cli, and semantic-release being used at all?
2 - About TS: what is tsconfig.strict.json? Why is tsconfig.json not sufficient?
3 - And a more begginer-like question: when we run the scripts in package.json, such as test, it runs fine (because I have insntalled the dependency tsx). However, if I run tsx ./tests/test.ts directly on the terminal, I get the error message: tsx: command not found. Do you know why that is?

With these remarks out of the way, thank you so much for the help! I'm currently editing your branch on VS, and after adding all types, I'll merge it into main.

Was just making sure, thanks! Didn't want to remove them and blow your code up lol

Glad to hear it's working! That is a lot of errors but they'll go by quickly and you'll probably find some bugs or missed cases while you're addressing them, it's a good way to get familiar with the TS syntax as well. I can help out with them as well.

1 - Good catch! I completely forgot to uninstall those when I removed them from the scripts. I just pushed a change to remove them.
2 - tsconfig.strict.json only differs from tsconfig.json in that I re-enabled the rules against noUnusedLocals, noUnusedParameters and noImplicitAny. You don't have to have a separate config file normally but I thought it might be helpful in case you wanted to change things in the main tsconfig.json which will be used by default by VSCode or any editor that supports type checking. The check script in package.json is using the strict config so that it will output errors like so tsc -p ./tsconfig.strict.json --noEmit, the noEmit flag tells it to not output transpiled JS files.  Alternatively you can pass those options to tsc like this tsc --noUnusedLocals --noUnusedParameters --noImplicitAny. Once all of the type check errors are resolved the strict config can be deleted and the rules can be re-enabled in the main one.
3 - When you run a package.json script with npm run it will use the packages that are installed in the node_modules folder. If you want to run a package on the command line without using a script you should either install the package globally with npm i -g <package name> see https://docs.npmjs.com/downloading-and-installing-packages-globally or use npx https://docs.npmjs.com/cli/v7/commands/npx I'd recommend using npx unless you want to have the package as a command line tool that you use a lot.

I'm glad I could contribute to the project! I've been trying to learn more about ML and how Transformers work but it's been difficult because I learn best by trying things out in code and I'm not the best with Python so when I saw this repo I was really excited to have something I could experiment with while using all of the JS knowledge I have. I'd be happy to help out with any JS or TS questions you have or if you get stuck while trying to define a complex type or interface. TS can be frustrating sometimes but it's worth it to catch bugs and have better autocomplete.

Also happy to help with the TS, i'm trying to learn more about ML and Transformers myself, i do have python knowledge but spent most of my experience in web dev.
In terms of the other dev dependencies how should i best contribute ?  Its probable that this PR is going to be on going for a bit. Happy to add some commits to the branch in this PR.

@eduardoleao052 since @medic-code has kindly offered to help out as well it might be better for you to create a new branch in your repo called something like develop and then I can change the base of this PR to that branch instead of main. The benefit of doing that is that you could then merge this PR into develop and commit your changes as you work on resolving the type errors to that branch. That way @medic-code and I could make other PRs against the develop branch to also fix type errors or to add the tools that @medic-code was talking about. I didn't intend to make you fix all 200+ type errors yourself! 😄
This is known as the Gitflow Workflow which is sometimes necessary for large features like converting to TS if you don't want to merge things into main until they are 100% complete. Normally you would want to use the Feature Branch workflow and keep the features as small as possible. As you can see I'm also using the Forking Workflow which is usually best when contributing to someone else's repo.

Yep agreed @pparke a dev branch would be useful and yep it would allow us to incrementally fix these errors together and add additional improvements without the constraint.

Hello! Thank you for your answers @pparke, I think its all clear now.
I started adding types today, and npm run check is already throwing no errors for utils.ts, layers.ts and optim.ts.
I then pushed the PR into the develop branch (great idea, @medic-code!), so if you want to help with the other types (as well as chack that I have not messed something up) I would love it!
The only things I was not really familiar with were:

1 - When adding types for arrays, is it a better convention to use (number | string)[] or Array<number | string>?
2 - In layers.js, you created a Interface object. Does that mean that remove the necessity to annotate all methods manually? or just provides a blank slate on which you'll build your object normally (I ask because I've noticed that it's necessary to declare [key: string] and mode inside the object even though it was already typed in the Interface)?

All in all - it's all working really well, and the bug fixes are pretty quick to solve. Thanks for the help again @pparke @medic-code !

To my knowledge there's no real objective difference, the latter is using generic syntax and i may prefer this if i'm using lots of generics or the array elements are complex (objects with specific properties I want to declare types for).

i think but could be wrong (@pparke will be able comment better than i) that its more about that the interface informs about the shape of the class but the class is responsible for implementation, so TS uses the class index signature to check that the class actually implements the methods and properties.

Ok, pushing your current changes including those in this PR to develop works though normally you would create a new branch off of main and then I would rebase this PR onto it but it'll work this way too. I'll try changing the base of this PR though I'm not sure what will happen if there are no differences, but there's one way to find out 😄

1 - I normally write array types as (number | string)[] and I think that's considered the preferred form but it does mean the same thing as Array<number | string> so it's really up to you but it's best to choose one style and stick to it.
2 - You can certainly remove the type annotations from the methods if they are defined in the interface, the type checking, hover info, and autocomplete will still work. It's another one of those personal preference things, I like to keep the types in the method implementation so that I don't have to look at the interface or hover over the method name to see them but if you prefer having very terse and clean looking methods then you can leave them out.

Noticing the additional [key: string]: Module | Parameter | Tensor | any; annotation in the class is a good catch. I added it because I wasn't sure exactly which properties you were adding or if you intended to allow any property to be dynamically added later since you seemed to be extending the built in Object. If you want TS to be ok with it working like an Object and allowing any and all properties to be added then you'll need to keep that annotation in there. However, if you know which properties/members you'll be adding in all of the classes that derive from Module then you can define interfaces for those classes and add types for them.

A type for mode should be added to the interface as well to make sure it is clearly defined. If it should only accept certain values you can use the same literal type union that I was with "train" | "eval" and you can add more string values to it as needed.

Cool, thanks for the answers @pparke, @medic-code! If you want, I can do what you said, I just pushed a different branch since I had already made some changes (type annotations) on top of your code locally, with git fetch origin pull/fork/head:branch.
If you want (and if you have not started working on develop yet)  I could do what you asked, and branch it off main.
My only concern is making sure that you two are added as contributors as well if I merge the develop branch into main :D

@medic-code I notice you forked develop a while back, have you made any changes already? If not, I'll make a new develop branch off main to pass this PR onto.

Not to develop branch yet, i've branched off from it to add some configs, nothing that wont take 5 minutes to re-do on new develop branch, so go for it.

Glad to help! I haven't started working on the develop branch yet so if @medic-code hasn't committed any changes either then it should be ok. I'm just thinking about the order we'd need to do things in, if you reset develop back to what's currently in main then I'll have to rebase my PR on it and you'll need to merge it and then you would need to rebase your local copy with your changes onto develop I think.

We should still appear as contributors when you merge changes from develop into main as long as you don't squash all the commits into one.

Done!

Thanks! I've changed the base of this PR to develop.

Ok, added my local changes to develop. Sorry about the small mess @medic-code, hope it didn't jeopardize your progress too much.

Awesome! Good work everyone!

Good work! Btw, since this PR is merged, if I want to ask something or plan a push, how would it be best for me to contact you?

@eduardoleao052 you can email me directly at pparke at foxrock dot dev if I'm not responding to @ mentions on GitHub but like @medic-code suggested making a new issue or PR and tagging me should normally work 😄

I created a new issue and linked it to the develop branch. However, I couldn't yet tag you two to it @pparke @medic-code


[freeimage] correct ZLIB and LibRaw discovery

PR fixes #9450
No changes in supported triplets.  Tested on x64-linux

@Outurnate thanks for the PR!
We have a exist PR https://github.com/microsoft/vcpkg/pull/8707 to fix this issue.

Ah, darn!  I had a look around to see if there was one submitted already, somehow missed that.  Anything I can do to help get #8707 merged?

Closing as a duplicate


[SPARK-28996][SQL] Add tests regarding username of HiveClient

What changes were proposed in this pull request?
This patch proposes to add new tests to test the username of HiveClient to prevent changing the semantic unintentionally. The owner of Hive table has been changed back-and-forth, principal -> username -> principal, and looks like the change is not intentional. (Please refer SPARK-28996 for more details.) This patch intends to prevent this.
This patch also renames previous HiveClientSuite(s) to HivePartitionFilteringSuite(s) as it was commented as TODO, as well as previous tests are too narrowed to test only partition filtering.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Newly added UTs.

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Test build #110182 has started for PR 25696 at commit 8c1efd3.

Looks like renaming is not recognized though git status showed it correctly. (Shouldn't I reuse HiveClientSuite?) I'll try to play with this if someone concerns about the excessive lines of change.

Test build #110182 has finished for PR 25696 at commit 8c1efd3.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/110182/
Test PASSed.

Test build #110215 has started for PR 25696 at commit 0bdc71a.

cc. @cloud-fan @gatorsmile @dongjoon-hyun
I'm also asking to review #23952 in pair, as I feel #23952 is the right way but that should have test. I'm OK to rebase this to reflect #23952 if we would like to merge #23952 before this.

Test build #110215 has finished for PR 25696 at commit 0bdc71a.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
class HiveClientUserNameSuite(version: String)
class HiveClientUserNameSuites extends Suite with HiveClientVersions

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/110215/
Test PASSed.

shouldn't this and https://github.com/apache/spark/pull/23952 be put together and merged together as one PR?

There're some reasons to make this be separated PR:

I suggested adding UT in #23952 before, and the author didn't follow the suggestion so I had to put my own effort to deal with this. If I needed to raise the PR against author's fork, I should also persuade to merge it to reflect the PR, which seems to be unnecessary effort (and in my personal experience it has been progressed slowly on coordinating with other contributors). If this patch got merged before, #23952 will make new tests be broken so #23952 is forced to apply the change. If this patch got merged after I'm open to apply the change.
This patch can be independent with #23952, as the new tests are passing with current behavior. This patch is still valuable without #23952 as we should have to have tests to prevent changing behavior unintentionally. We didn't notice the behavioral change in latest change of SPARK-22846 - we thought it fixed NPE but it also changed the behavior. This is a non-trivial issue.
Minor, but authorship issue. IMHO I'm not sure who is the right main author of merged PR, as I expect there's similar amount of effort being put between #23952 and this.

Can one of the admins verify this patch?

Test build #110663 has started for PR 25696 at commit dfca82b.

Test build #110663 has finished for PR 25696 at commit dfca82b.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/110663/
Test PASSed.

Reflected the change of SPARK-26929 and test passed. Could we have a next round of review?

LGTM

Test build #110719 has started for PR 25696 at commit ef220ef.

Test build #110719 has finished for PR 25696 at commit ef220ef.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
class HiveClientUserNameSuite(version: String) extends HiveVersionSuite(version)

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/110719/
Test PASSed.

thanks, merging to master!

Thanks all for reviewing and merging!


Metadata fixes

Docs Build status updates of commit 252bef1:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error-PullRequestMergeConflict] Cannot sync git repo to specified state. Please make sure the pull request is mergeable.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit 5aa24b7:
:warning: Validation status: warnings

File
Status
Preview URL
Details

TerminalDocs/docfx.json
:warning:Warning

Details

TerminalDocs/new-terminal-arguments.md
:warning:Warning
View
Details

TerminalDocs/tips-and-tricks.md
:warning:Warning
View
Details

TerminalDocs/tutorials/powerline-setup.md
:bulb:Suggestion
View
Details

TerminalDocs/cascadia-code.md
:white_check_mark:Succeeded
View

TerminalDocs/command-line-arguments.md
:white_check_mark:Succeeded
View

TerminalDocs/command-palette.md
:white_check_mark:Succeeded
View

TerminalDocs/custom-terminal-gallery/custom-schemes.md
:white_check_mark:Succeeded
View

TerminalDocs/custom-terminal-gallery/frosted-glass-theme.md
:white_check_mark:Succeeded
View

TerminalDocs/custom-terminal-gallery/powerline-in-powershell.md
:white_check_mark:Succeeded
View

TerminalDocs/custom-terminal-gallery/raspberry-ubuntu.md
:white_check_mark:Succeeded
View

TerminalDocs/custom-terminal-gallery/retro-command-prompt.md
:white_check_mark:Succeeded
View

TerminalDocs/customize-settings/color-schemes.md
:white_check_mark:Succeeded
View

TerminalDocs/customize-settings/global-settings.md
:white_check_mark:Succeeded
View

TerminalDocs/customize-settings/key-bindings.md
:white_check_mark:Succeeded
View

TerminalDocs/customize-settings/profile-settings.md
:white_check_mark:Succeeded
View

TerminalDocs/dynamic-profiles.md
:white_check_mark:Succeeded
View

TerminalDocs/get-started.md
:white_check_mark:Succeeded
View

TerminalDocs/index.md
:white_check_mark:Succeeded
View

TerminalDocs/panes.md
:white_check_mark:Succeeded
View

TerminalDocs/search.md
:white_check_mark:Succeeded
View

TerminalDocs/troubleshooting.md
:white_check_mark:Succeeded
View

TerminalDocs/tutorials/ssh.md
:white_check_mark:Succeeded
View

TerminalDocs/tutorials/tab-title.md
:white_check_mark:Succeeded
View

TerminalDocs/docfx.json

Line 50, Column 33: [Warning-ms-prod-technology-invalid] Invalid value for 'ms.technology': 'terminal' is not valid with 'ms.prod' value 'dev-environment'.

TerminalDocs/new-terminal-arguments.md

Line 0, Column 0: [Warning-h1-missing] H1 is required. Use a single hash (#) followed by a space to create your top-level heading.

TerminalDocs/tips-and-tricks.md

Line 30, Column 233: [Warning-file-not-found] Invalid file link: './customize-settings/profile-settings'.
Line 34, Column 263: [Warning-file-not-found] Invalid file link: './customize-settings/profile-settings'.

TerminalDocs/tutorials/powerline-setup.md

Line 47, Column 0: [Suggestion-preserve-view-not-set] Did you mean to link to a specific version? If so, add &preserve-view=true to the URL: https://docs.microsoft.com/powershell/scripting/gallery/getting-started?view=powershell-7 NOTE: This Suggestion will become a Warning in early December, 2020.
Line 57, Column 0: [Suggestion-preserve-view-not-set] Did you mean to link to a specific version? If so, add &preserve-view=true to the URL: https://docs.microsoft.com/powershell/module/psreadline/?view=powershell-6 NOTE: This Suggestion will become a Warning in early December, 2020.
Line 61, Column 0: [Suggestion-preserve-view-not-set] Did you mean to link to a specific version? If so, add &preserve-view=true to the URL: https://docs.microsoft.com/powershell/module/microsoft.powershell.core/about/about_profiles?view=powershell-7 NOTE: This Suggestion will become a Warning in early December, 2020.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit 0344ed5:
:warning: Validation status: warnings

File
Status
Preview URL
Details

TerminalDocs/new-terminal-arguments.md
:warning:Warning
View
Details

TerminalDocs/tips-and-tricks.md
:warning:Warning
View
Details

TerminalDocs/tutorials/powerline-setup.md
:bulb:Suggestion
View
Details

TerminalDocs/cascadia-code.md
:white_check_mark:Succeeded
View

TerminalDocs/command-line-arguments.md
:white_check_mark:Succeeded
View

TerminalDocs/command-palette.md
:white_check_mark:Succeeded
View

TerminalDocs/custom-terminal-gallery/custom-schemes.md
:white_check_mark:Succeeded
View

TerminalDocs/custom-terminal-gallery/frosted-glass-theme.md
:white_check_mark:Succeeded
View

TerminalDocs/custom-terminal-gallery/powerline-in-powershell.md
:white_check_mark:Succeeded
View

TerminalDocs/custom-terminal-gallery/raspberry-ubuntu.md
:white_check_mark:Succeeded
View

TerminalDocs/custom-terminal-gallery/retro-command-prompt.md
:white_check_mark:Succeeded
View

TerminalDocs/customize-settings/color-schemes.md
:white_check_mark:Succeeded
View

TerminalDocs/customize-settings/global-settings.md
:white_check_mark:Succeeded
View

TerminalDocs/customize-settings/key-bindings.md
:white_check_mark:Succeeded
View

TerminalDocs/customize-settings/profile-settings.md
:white_check_mark:Succeeded
View

TerminalDocs/docfx.json
:white_check_mark:Succeeded

TerminalDocs/dynamic-profiles.md
:white_check_mark:Succeeded
View

TerminalDocs/get-started.md
:white_check_mark:Succeeded
View

TerminalDocs/index.md
:white_check_mark:Succeeded
View

TerminalDocs/panes.md
:white_check_mark:Succeeded
View

TerminalDocs/search.md
:white_check_mark:Succeeded
View

TerminalDocs/troubleshooting.md
:white_check_mark:Succeeded
View

TerminalDocs/tutorials/ssh.md
:white_check_mark:Succeeded
View

TerminalDocs/tutorials/tab-title.md
:white_check_mark:Succeeded
View

TerminalDocs/new-terminal-arguments.md

Line 0, Column 0: [Warning-h1-missing] H1 is required. Use a single hash (#) followed by a space to create your top-level heading.

TerminalDocs/tips-and-tricks.md

Line 30, Column 233: [Warning-file-not-found] Invalid file link: './customize-settings/profile-settings'.
Line 34, Column 263: [Warning-file-not-found] Invalid file link: './customize-settings/profile-settings'.

TerminalDocs/tutorials/powerline-setup.md

Line 47, Column 0: [Suggestion-preserve-view-not-set] Did you mean to link to a specific version? If so, add &preserve-view=true to the URL: https://docs.microsoft.com/powershell/scripting/gallery/getting-started?view=powershell-7 NOTE: This Suggestion will become a Warning in early December, 2020.
Line 57, Column 0: [Suggestion-preserve-view-not-set] Did you mean to link to a specific version? If so, add &preserve-view=true to the URL: https://docs.microsoft.com/powershell/module/psreadline/?view=powershell-6 NOTE: This Suggestion will become a Warning in early December, 2020.
Line 61, Column 0: [Suggestion-preserve-view-not-set] Did you mean to link to a specific version? If so, add &preserve-view=true to the URL: https://docs.microsoft.com/powershell/module/microsoft.powershell.core/about/about_profiles?view=powershell-7 NOTE: This Suggestion will become a Warning in early December, 2020.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit 2669fc0:
:warning: Validation status: warnings

File
Status
Preview URL
Details

TerminalDocs/new-terminal-arguments.md
:warning:Warning
View
Details

TerminalDocs/cascadia-code.md
:white_check_mark:Succeeded
View

TerminalDocs/command-line-arguments.md
:white_check_mark:Succeeded
View

TerminalDocs/command-palette.md
:white_check_mark:Succeeded
View

TerminalDocs/custom-terminal-gallery/custom-schemes.md
:white_check_mark:Succeeded
View

TerminalDocs/custom-terminal-gallery/frosted-glass-theme.md
:white_check_mark:Succeeded
View

TerminalDocs/custom-terminal-gallery/powerline-in-powershell.md
:white_check_mark:Succeeded
View

TerminalDocs/custom-terminal-gallery/raspberry-ubuntu.md
:white_check_mark:Succeeded
View

TerminalDocs/custom-terminal-gallery/retro-command-prompt.md
:white_check_mark:Succeeded
View

TerminalDocs/customize-settings/color-schemes.md
:white_check_mark:Succeeded
View

TerminalDocs/customize-settings/global-settings.md
:white_check_mark:Succeeded
View

TerminalDocs/customize-settings/key-bindings.md
:white_check_mark:Succeeded
View

TerminalDocs/customize-settings/profile-settings.md
:white_check_mark:Succeeded
View

TerminalDocs/docfx.json
:white_check_mark:Succeeded

TerminalDocs/dynamic-profiles.md
:white_check_mark:Succeeded
View

TerminalDocs/get-started.md
:white_check_mark:Succeeded
View

TerminalDocs/index.md
:white_check_mark:Succeeded
View

TerminalDocs/panes.md
:white_check_mark:Succeeded
View

TerminalDocs/search.md
:white_check_mark:Succeeded
View

TerminalDocs/tips-and-tricks.md
:white_check_mark:Succeeded
View

TerminalDocs/troubleshooting.md
:white_check_mark:Succeeded
View

TerminalDocs/tutorials/powerline-setup.md
:white_check_mark:Succeeded
View

TerminalDocs/tutorials/ssh.md
:white_check_mark:Succeeded
View

TerminalDocs/tutorials/tab-title.md
:white_check_mark:Succeeded
View

TerminalDocs/new-terminal-arguments.md

Line 0, Column 0: [Warning-h1-missing] H1 is required. Use a single hash (#) followed by a space to create your top-level heading.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


TI API: versioning

Problem description
the "version" filed is not correct.
Expected action
fix it removing the release number
Additional context
as discussed for the CFS API here: https://github.com/camaraproject/CallForwardingSignal/discussions/27#discussioncomment-9701045

fixed with: https://github.com/camaraproject/EdgeCloud/pull/278


Protocol upload fails when trying to upload make_sound.py

Overview
Protocol upload fails when trying to upload make_sound.py
Steps to reproduce
App on 5.0.0-beta.5
Firmware Version: v1.1.0-25e5cea
Wireless connection
Try to upload the make_sound.py protocol via the "Choose File..." button and by dragging and dropping.
Current behavior
App fails to complete protocol upload for make_sound.py, both when using "choose file" button and dragging and dropping. The spinning circle loading modal pops up and quickly disappears before returning to the empty state protocol upload view.
Screen capture of the behavior here: https://drive.google.com/file/d/1k3mAz8Gh6hEA9SvAdDWQtfVpo6dOw07V/view?usp=sharing
Expected behavior
Upon uploading make_sound.py on the protocol upload page (both via the "choose file" button and dragging and dropping), the spinning circle loading screen should pop up for a short while before the protocol overview/setup page pops up.
Protocol upload page designs here: https://www.figma.com/file/JCQNOTTK9tTmYPhRqeOfSj/Milestone-0%3A-Protocol-Upload-Revamp?node-id=3205%3A22

closing this since the protocol attached is an invalid python file. it misuses literal backslashes in python, which is why the server won't accept it. since this ticket was filed we implemented logic to properly display errors to users, so now they'd see that the python file is invalid


Fix cordova on iOS

Fix alasql for running in cordova on iOS. #410

We really need to get the change from pboos@656792d into the develop branch and not the master branch. I could just copy the single line changed into develop - but then you would not be credited with the edits.
Please provide a new pull request to the develop branch or let me know if I should just put it into the develop branch.

done :)


add: glow-deb

Progress

[x] Edit packagelist
[x] Add initial pacscript
[ ] Contact devs
[x] Add maintainer to pacscript

Add breaks

Can I add replace instead? I don't think this "breaks" any other pacstall package.

Sure


Add a way to customize how things are outlined

Description
For elements that can be outlined, there should be a way to specify content that represents them in the outline. Currently, this is hard-coded, and depends on the element type (for a heading, the body is used; for a figure, the caption body is used).
Use Case
One use case is being able to have headings that are formatted in a specific way within the document, but not in the outline. For example, you might want chapter titles to be formatted like the following, but not having the line break and different font sizes in the heading.

Duplicate of #1889

Duplicate of #1889


⚠ Bofrost.at has degraded performance

In ae88fbf, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 2230 ms

Resolved: Bofrost.at performance has improved in 831e914.


Break and continue in c++

Description
I will be giving brief note on break and continue statements in c++
Domain
C/CPP
Type of Contribution
Documentation
Code of Conduct

[X] I follow Contributing Guidelines & Code of conduct of this project.

/assign

/assign


Remove reference to start/stop handlers in comment.

The comment at top of file still talks about the removed start/stop handlers.

Thanks!


http: use a request queue in the http2 conn pool

Modifies the http2 connection pool to use a request queue similar to
how the http/1.1 connection pool does. This is done in order to defer
the connection pool callbacks until the connection has been established
instead of simply invoking the callback immediately.
Signed-off-by: Snow Pettersen<EMAIL_ADDRESS>Risk Level: High
Testing: UTs for new conn pool behavior
Docs Changes: n/a
Release Notes: n/a
Part of #4903

NOTE: not done, test coverage is lacking and not all integration tests are passing, but putting this up to get some feedback on the high level approach

So looking into my conn reset issue it seems like the issue is that with this change, when a stream resets before the connection has been established, newStream will not be called on the fake connection. This means waitForNewStream cannot be used to get a handle on streams that get reset.
Tests like the grpc json transcoder seems to use this to get access to the request that will be sent on that stream, but the stream is reset in certain cases due to the filter's usage of sendLocalReply. This is why the tests are now timing out waiting for a stream.
So the way I see it there's two options: 1) get waitForNewStream to work with the new connection pool setup or 2) update tests to not rely on on waitForNewStream for streams that will be reset
I assume waitForNewStream can't be used for this purpose for http/1.1 either due to their use of a request queue (or maybe I'm missing something obvious?), so maybe 2) is the way to go?
@mattklein123 thoughts?

@mattklein123 thoughts?

Sorry can you provide more detail on the flow that is failing/different? I'm not completely clear on what is happening now.

The grpc-json transcoder integration tests uses waitForNewStream to get the request sent through the filter: https://github.com/envoyproxy/envoy/blob/master/test/extensions/filters/http/grpc_json_transcoder/grpc_json_transcoder_integration_test.cc#L75
With the change in this PR, it seems like waitForNewStream won't return for requests that that hit sendLocalReply or are otherwise being reset before the upstream connection has been established. I'll push a change that removes the problematic expectations, and we can discuss options in review.

This should be ready for review now (just some clang-tidy stuff to... tidy up)
I extracted out the PendingRequest and queue management stuff from the  h1 connection pool so that I could reuse it in the h2 one, which significantly reduces the amount of duplicated code compared to earlier. Besides that there's some minor tweaks to some integration tests to handle the new behavior of waitForNewStream.

Actually, looks like tests are flaky. Looking into it

Ok, tests are green (except mac tests that are taking forever). ptal

Marking as waiting.
/wait

Ping on review on this. I think all the current comments have been addressed

@snowp will review today


siamfc++ source code

https://github.com/MegviiDetection/video_analyst

@lzx1413 Got it. Thanks for your support!


fix: npm scripts not working on windows

closes #53
Also includes .idea/ directory for intellij/webstorm on .gitignore file.

Emm, we can wrote a simple javascript to copy the files instead of using cli.


Harbor (docker-compose) fails installation on VIC

When selecting a VIC/VCH target the docker-compose installation of Harbor fails because VIC does not yet implement Load Image. If possible Harbor install should avoid using Load Image.

@lcastellano could you show me the error? And please also help to tell how do you run the offline installer.
Harbor packages all the fundamental docker images into one tgz file, then load it at the installation phase.

@lcastellano this is a known limitation, could you try to online install package?


Update changelog to account for ProductOrd impl change

          Since the right way to do this is changing, is this something that we'd want to call out in a migration section in the changelog? I know that generally we make the changelog at release time, but if there's some detail, it might be easier to capture it now rather than down the road.

Originally posted by @mccalluc in https://github.com/opendp/opendp/pull/1716#discussion_r1677881889

Closed in #1957


Clarification on Unused Parameters in TimeLLM Forecast Function

Hi Team,
Thanks for your great work! I'm currently working with the TimeLLM model as described in your ICLR paper, "Time-LLM: Forecasting and Understanding Time Series with Pretrained Language Models."
Upon reviewing the paper and the associated implementation, I noticed that the parameters x_mark_enc, x_dec, and x_mark_dec are passed to the forward method but do not appear to be utilized in the forecast function. Specifically, these parameters are passed through the method signatures but are not referenced within the function body for any operations or computations.
Here's the relevant code snippet in ./Time-LLM/models/TimeLLM:
def forward(self, x_enc, x_mark_enc, x_dec, x_mark_dec, mask=None):
    if self.task_name == 'long_term_forecast' or self.task_name == 'short_term_forecast':
        dec_out = self.forecast(x_enc, x_mark_enc, x_dec, x_mark_dec)
        return dec_out[:, -self.pred_len:, :]
    return None

def forecast(self, x_enc, x_mark_enc, x_dec, x_mark_dec):
    # ... various operations on x_enc ...
    return dec_out

Is this the intended behavior, or are these parameters supposed to be used in a specific way that I'm missing?
Thank you for your time and consideration. I look forward to your guidance on this matter.

Thank you very much for your interest in our work. Your understanding is correct. Currently, the variables x_mark_enc, x_dec, and x_mark_dec are not involved in the actual training process. We are using the Time-Series-Library framework for reference, and to maintain consistency, we have kept these parameters.


Duplicate entries in Documents

Hi Team,
I am seeing duplicate entries in docs for two items:

Incident Conversation Reference Command Doc
Incident FAQs

I was expecting they would begin Jira ticket name as other Docs.

@tomarv2 we are not prefixing them with the incident's name, because they're not specific to any incident. We create an object for them every time an incident is created, that's why you see duplicated entries for them. We're aware of it and will fix it. Thanks

Going forward this should be fixed by #461. Currently, I do no plan to create a migration to cleanup existing duplicates.


Build Warnings

Severity	Code	Description	Project	File	Line	Suppression State
Warning (active)	CS8622	Nullability of reference types in type of parameter 'value' of 'Task<IEnumerable> LanguageAutocomplete.SearchFunc_(string value, CancellationToken cancellation = default(CancellationToken))' doesn't match the target delegate 'Func<string?, CancellationToken, Task<IEnumerable>?>' (possibly because of nullability attributes).	CleanAspire.ClientApp	D:\repos\cleanaspire\src\CleanAspire.ClientApp\Components\Autocompletes\LanguageAutocomplete.cs	10
Warning (active)	CS8622	Nullability of reference types in type of parameter 'value' of 'Task<IEnumerable> TimeZoneAutocomplete.SearchFunc_(string value, CancellationToken cancellation = default(CancellationToken))' doesn't match the target delegate 'Func<string?, CancellationToken, Task<IEnumerable>?>' (possibly because of nullability attributes).	CleanAspire.ClientApp	D:\repos\cleanaspire\src\CleanAspire.ClientApp\Components\Autocompletes\TimeZoneAutocomplete.cs	9
Warning (active)	BL0007	Component parameter 'CleanAspire.ClientApp.Components.LoadingButton.MudLoadingButton.Loading' should be auto property	CleanAspire.ClientApp	D:\repos\cleanaspire\src\CleanAspire.ClientApp\Components\LoadingButton\MudLoadingButton.razor	69
Warning (active)	CS8618	Non-nullable property 'ChildContent' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the property as nullable.	CleanAspire.ClientApp	D:\repos\cleanaspire\src\CleanAspire.ClientApp\Components\LoadingButton\MudLoadingButton.razor	82
Warning (active)	CS8618	Non-nullable property 'LoadingContent' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the property as nullable.	CleanAspire.ClientApp	D:\repos\cleanaspire\src\CleanAspire.ClientApp\Components\LoadingButton\MudLoadingButton.razor	85
Warning (active)	CS1998	This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.	CleanAspire.ClientApp	D:\repos\cleanaspire\src\CleanAspire.ClientApp\Pages\Account\EmailChangeConfirm.razor	90
Warning (active)	CS1998	This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.	CleanAspire.ClientApp	D:\repos\cleanaspire\src\CleanAspire.ClientApp\Pages\Account\ForgetPasswordConfirm.razor	91
Warning (active)	CS1998	This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.	CleanAspire.ClientApp	D:\repos\cleanaspire\src\CleanAspire.ClientApp\Pages\Account\Profile\AccountSetting.razor	76
Warning (active)	CS8602	Dereference of a possibly null reference.	CleanAspire.ClientApp	D:\repos\cleanaspire\src\CleanAspire.ClientApp\Pages\Account\Profile\AccountSetting.razor	87
Warning (active)	CS8618	Non-nullable field 'browserFile' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the field as nullable.	CleanAspire.ClientApp	D:\repos\cleanaspire\src\CleanAspire.ClientApp\Pages\Account\Profile\ProfileSetting.razor	52
Warning (active)	CS1998	This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.	CleanAspire.ClientApp	D:\repos\cleanaspire\src\CleanAspire.ClientApp\Pages\Account\Profile\ProfileSetting.razor	58
Warning (active)	CS8601	Possible null reference assignment.	CleanAspire.ClientApp	D:\repos\cleanaspire\src\CleanAspire.ClientApp\Pages\Account\Profile\ProfileSetting.razor	66
Warning (active)	CS1998	This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.	CleanAspire.ClientApp	D:\repos\cleanaspire\src\CleanAspire.ClientApp\Pages\Account\SignupConfirmation.razor	26
Warning (active)	CS0105	The using directive for 'CleanAspire.Api.Client.Models' appeared previously in this namespace	CleanAspire.ClientApp	D:\repos\cleanaspire\src\CleanAspire.ClientApp\Pages\Account_Imports.razor	2
Warning (active)	CS8618	Non-nullable property 'OrderNumber' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the property as nullable.	CleanAspire.ClientApp	D:\repos\cleanaspire\src\CleanAspire.ClientApp\Pages\Home.razor	262
Warning (active)	CS8618	Non-nullable property 'Currency' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the property as nullable.	CleanAspire.ClientApp	D:\repos\cleanaspire\src\CleanAspire.ClientApp\Pages\Home.razor	264
Warning (active)	CS8618	Non-nullable property 'Status' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the property as nullable.	CleanAspire.ClientApp	D:\repos\cleanaspire\src\CleanAspire.ClientApp\Pages\Home.razor	265
Warning (active)	CS8618	Non-nullable property 'OverdueStatus' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the property as nullable.	CleanAspire.ClientApp	D:\repos\cleanaspire\src\CleanAspire.ClientApp\Pages\Home.razor	266
Warning (active)	CS8618	Non-nullable property 'CustomerName' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the property as nullable.	CleanAspire.ClientApp	D:\repos\cleanaspire\src\CleanAspire.ClientApp\Pages\Home.razor	268
Warning (active)	CS8618	Non-nullable property 'ShippingAddress' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the property as nullable.	CleanAspire.ClientApp	D:\repos\cleanaspire\src\CleanAspire.ClientApp\Pages\Home.razor	269
Warning (active)	CS8618	Non-nullable property 'Product' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the property as nullable.	CleanAspire.ClientApp	D:\repos\cleanaspire\src\CleanAspire.ClientApp\Pages\Home.razor	270
Warning (active)	CS8634	The type 'CleanAspire.ClientApp.Configurations.ClientAppSettings?' cannot be used as type parameter 'TService' in the generic type or method 'ServiceCollectionServiceExtensions.AddSingleton(IServiceCollection, TService)'. Nullability of type argument 'CleanAspire.ClientApp.Configurations.ClientAppSettings?' doesn't match 'class' constraint.	CleanAspire.ClientApp	D:\repos\cleanaspire\src\CleanAspire.ClientApp\Program.cs	27
Warning (active)	CS0618	'IDialogService.Show(string?, DialogParameters, DialogOptions?)' is obsolete: 'Use ShowAsync instead. This will be removed in future major version.'	CleanAspire.ClientApp	D:\repos\cleanaspire\src\CleanAspire.ClientApp\Services\DialogServiceHelper.cs	30
Warning (active)	CS1998	This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.	CleanAspire.ClientApp	D:\repos\cleanaspire\src\CleanAspire.ClientApp\Services\Identity\AccessTokenProvider.cs	22
Warning (active)	CS0414	The field 'CookieAuthenticationStateProvider.authenticated' is assigned but its value is never used	CleanAspire.ClientApp	D:\repos\cleanaspire\src\CleanAspire.ClientApp\Services\Identity\CookieAuthenticationStateProvider.cs	16
Warning (active)	CS8604	Possible null reference argument for parameter 'value' in 'Claim.Claim(string type, string value)'.	CleanAspire.ClientApp	D:\repos\cleanaspire\src\CleanAspire.ClientApp\Services\Identity\CookieAuthenticationStateProvider.cs	36
Warning (active)	CS8604	Possible null reference argument for parameter 'value' in 'Claim.Claim(string type, string value)'.	CleanAspire.ClientApp	D:\repos\cleanaspire\src\CleanAspire.ClientApp\Services\Identity\CookieAuthenticationStateProvider.cs	37
Warning (active)	CS8604	Possible null reference argument for parameter 'value' in 'Claim.Claim(string type, string value)'.	CleanAspire.ClientApp	D:\repos\cleanaspire\src\CleanAspire.ClientApp\Services\Identity\CookieAuthenticationStateProvider.cs	38
Warning (active)	CS8618	Non-nullable property 'Userid' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the property as nullable.	CleanAspire.ClientApp	D:\repos\cleanaspire\src\CleanAspire.ClientApp\Services\UserInfo.cs	5
Warning (active)	CS8618	Non-nullable property 'Username' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the property as nullable.	CleanAspire.ClientApp	D:\repos\cleanaspire\src\CleanAspire.ClientApp\Services\UserInfo.cs	6
Warning (active)	CS8618	Non-nullable property 'Nickname' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the property as nullable.	CleanAspire.ClientApp	D:\repos\cleanaspire\src\CleanAspire.ClientApp\Services\UserInfo.cs	7
Warning (active)	CS8618	Non-nullable property 'Email' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the property as nullable.	CleanAspire.ClientApp	D:\repos\cleanaspire\src\CleanAspire.ClientApp\Services\UserInfo.cs	9
Warning (active)	CS8618	Non-nullable property 'Token' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the property as nullable.	CleanAspire.ClientApp	D:\repos\cleanaspire\src\CleanAspire.ClientApp\Services\UserInfo.cs	10
Warning (active)	CS8618	Non-nullable property 'Role' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the property as nullable.	CleanAspire.ClientApp	D:\repos\cleanaspire\src\CleanAspire.ClientApp\Services\UserInfo.cs	11
Warning (active)	CS0108	'MudEnumSelect.Logger' hides inherited member 'MudComponentBase.Logger'. Use the new keyword if hiding was intended.	CleanAspire.ClientApp	D:\repos\cleanaspire\src\CleanAspire.ClientApp_Imports.razor	30
Warning (active)	CS0108	'MudLoadingButton.Logger' hides inherited member 'MudComponentBase.Logger'. Use the new keyword if hiding was intended.	CleanAspire.ClientApp	D:\repos\cleanaspire\src\CleanAspire.ClientApp_Imports.razor	30
Warning (active)	CS8618	Non-nullable property 'Id' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the property as nullable.	CleanAspire.Domain	D:\repos\cleanaspire\src\CleanAspire.Domain\Entities\AuditTrail.cs	13
Warning (active)	NU1608	Detected package version outside of dependency constraint: EFCore.NamingConventions 8.0.3 requires Microsoft.EntityFrameworkCore (>= 8.0.0 && < 9.0.0) but version Microsoft.EntityFrameworkCore 9.0.0 was resolved.	CleanAspire.Infrastructure	D:\repos\cleanaspire\src\CleanAspire.Infrastructure\CleanAspire.Infrastructure.csproj	1
Warning (active)	NU1608	Detected package version outside of dependency constraint: EFCore.NamingConventions 8.0.3 requires Microsoft.EntityFrameworkCore.Relational (>= 8.0.0 && < 9.0.0) but version Microsoft.EntityFrameworkCore.Relational 9.0.0 was resolved.	CleanAspire.Infrastructure	D:\repos\cleanaspire\src\CleanAspire.Infrastructure\CleanAspire.Infrastructure.csproj	1
Warning (active)	NU1608	Detected package version outside of dependency constraint: EFCore.NamingConventions 8.0.3 requires Microsoft.EntityFrameworkCore (>= 8.0.0 && < 9.0.0) but version Microsoft.EntityFrameworkCore 9.0.0 was resolved.	Migrators.MSSQL	D:\repos\cleanaspire\src\Migrators\Migrators.MSSQL\Migrators.MSSQL.csproj	1
Warning (active)	NU1608	Detected package version outside of dependency constraint: EFCore.NamingConventions 8.0.3 requires Microsoft.EntityFrameworkCore.Relational (>= 8.0.0 && < 9.0.0) but version Microsoft.EntityFrameworkCore.Relational 9.0.0 was resolved.	Migrators.MSSQL	D:\repos\cleanaspire\src\Migrators\Migrators.MSSQL\Migrators.MSSQL.csproj	1
Warning (active)	NU1608	Detected package version outside of dependency constraint: EFCore.NamingConventions 8.0.3 requires Microsoft.EntityFrameworkCore (>= 8.0.0 && < 9.0.0) but version Microsoft.EntityFrameworkCore 9.0.0 was resolved.	Migrators.PostgreSQL	D:\repos\cleanaspire\src\Migrators\Migrators.PostgreSQL\Migrators.PostgreSQL.csproj	1
Warning (active)	NU1608	Detected package version outside of dependency constraint: EFCore.NamingConventions 8.0.3 requires Microsoft.EntityFrameworkCore.Relational (>= 8.0.0 && < 9.0.0) but version Microsoft.EntityFrameworkCore.Relational 9.0.0 was resolved.	Migrators.PostgreSQL	D:\repos\cleanaspire\src\Migrators\Migrators.PostgreSQL\Migrators.PostgreSQL.csproj	1
Warning (active)	NU1608	Detected package version outside of dependency constraint: EFCore.NamingConventions 8.0.3 requires Microsoft.EntityFrameworkCore (>= 8.0.0 && < 9.0.0) but version Microsoft.EntityFrameworkCore 9.0.0 was resolved.	Migrators.SQLite	D:\repos\cleanaspire\src\Migrators\Migrators.SQLite\Migrators.SQLite.csproj	1
Warning (active)	NU1608	Detected package version outside of dependency constraint: EFCore.NamingConventions 8.0.3 requires Microsoft.EntityFrameworkCore.Relational (>= 8.0.0 && < 9.0.0) but version Microsoft.EntityFrameworkCore.Relational 9.0.0 was resolved.	Migrators.SQLite	D:\repos\cleanaspire\src\Migrators\Migrators.SQLite\Migrators.SQLite.csproj	1
Warning (active)	NU1608	Detected package version outside of dependency constraint: EFCore.NamingConventions 8.0.3 requires Microsoft.EntityFrameworkCore (>= 8.0.0 && < 9.0.0) but version Microsoft.EntityFrameworkCore 9.0.0 was resolved.	CleanAspire.Api	D:\repos\cleanaspire\src\CleanAspire.Api\CleanAspire.Api.csproj	1
Warning (active)	NU1608	Detected package version outside of dependency constraint: EFCore.NamingConventions 8.0.3 requires Microsoft.EntityFrameworkCore.Relational (>= 8.0.0 && < 9.0.0) but version Microsoft.EntityFrameworkCore.Relational 9.0.0 was resolved.	CleanAspire.Api	D:\repos\cleanaspire\src\CleanAspire.Api\CleanAspire.Api.csproj	1

Warnings can be ignored. I am waiting for EFCore.NamingConventions upgrade to dotnet 9


Need to move Andy's documentation to an NCAS location

And move all the links in the various setup, readme, etc code.

Hi @bnlawrence, thanks for raising this. I agree! I was due to start compiling issues for cf-view (of which this would be one the first as most urgent) though I am still trying to work through some major work towards getting cf-plot in a state I'd feel comfortable developing on (e.g. code standards, modularisation and getting the docs hosted centrally via NCAS-CMS, likewise there). But I should show cf-view some love too at this stage!
Andy provided a tarball of cf-view docs, so I can start work on that next week (I'm at a workshop today until Thursday inclusive so not much time this week). Hope that timeline sounds OK.


This is a bad idea...

What I'm going to say is my opinion and only mine.
This is a bad idea...

You lost readability of your commits in environments where emojis are not readable, which represents a lot of environments!
Readers must learn the meaning of an emoji instead of just reading a more-efficient keyword.

... full of bad ideas

Not only you have to learn the meaning of the emojis, but it changes depending on the tools !

🐘 	:elephant: 	PostgreSQL Database specific (Migrations, Scripts, Extensions, ...)
🐬 	:dolphin: 	MySQL Database specific (Migrations, Scripts, Extensions, ...)
🍃 	:leaves: 	MongoDB Database specific (Migrations, Scripts, Extensions, ...)
🏦 	:bank: 	        Generic Database specific (Migrations, Scripts, Extensions, ...)
🐳 	:whale: 	Docker Configuration

If it is not enough, you encourage users to extend the lists!
You force to add at least one emoji, which means that you think about putting plenty of them, which takes a lot of place if not translated!

:emoji1: :emoji2: Subject

There are some contradictions in your guide:

    All WIP(Work In Progress) Commits MUST have the WIP Emoji(see below).
    ...
    All WIP Commits Should be Avoided!.

While the WIP commit is obviously a residual mistake, I should mention that you authorize to commit bugs!!

🐛 	:bug: 	when reporting a bug, with @FIXMEComment Tag

I thus think one should not follow this guideline, or at least not in its current state.

Let me get this straight, you opened an issue on a project to express your opinions on why people shouldn't use this project. Couldn't you just avoid to use it and write a blog post in your blog to express your opinions? Open a project in your space to offer an alternative, seems another sensible Idea. This issue looks more like a publicity stunt, or an attempt to troll a simple good effort on improoving team comunication by getting the best out of our tool, includin git commit messages.

You seem offended and I apologize for that. But you are wrong about my motives.
This is not just about opinion. I also took the time to list some ways of improvement despite the fact that I will not use your guide. I'm pretty sure that's what issues are for...


Adding Track 2 Packages to Sphinx Config

NO_CI
Wondering if the CI skip check will actually work.

Can one of the admins verify this patch?

Ref: #6188


Is it possible to run grunt instead of node?

My application can simply start with grunt or grunt production.
I tried something like forever start -c grunt, but I can't get it works since the SCRIPT argument is required.
I have also tried using grunt-forever package, but facing the same problem, and it does not provide so much options as foreverjs originally provided, such as --spinSleepTime and --uid.
I want something like:
forever grunt or forever grunt production, which are equivalent to grunt or grunt production but run as daemon with foreverjs.

I am also interested in this! I have literally just tried to do the same things.

Can you share what you just tried?

Tried "forever gruntfile.js" - no luck. Tried "grunt forever:server:start" - no luck, but I don't think I had the settings correct in the gruntfile, as the app is using a script to launch (i didn't write the app) and the docs only mention an index file (e.g. app.js)

OK, got it working. In your gruntfile.js (or similar), use:
forever: {
server: { // this can be whatever, this is our app name
options: {
index: "./bin/www" // this is a script for me, could be a .js file
}
}
}

I guess grunt forever:server:start will work if you use grunt-forever and have correct config in gruntfile with the forever task.
I think the major limitation is that foreverjs requires a script file to get it works while grunt does not

See above, I got it working with a script file :)


WIP. HADOOP-17124. Support LZO Codec using aircompressor

Description of PR
This patch adds LZO Codec which includes LzoCompressor and LzoDecompressor (WIP).
See https://issues.apache.org/jira/browse/HADOOP-17124 for details.
How was this patch tested?
Unit test.
For code changes:

[ ] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
[ ] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

cc @sunchao @dbtsai

LzoCompressor is ready for review. I will work on LzoDecompressor next.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m  0s

Docker mode activated.

-1 :x:
patch
0m 18s

https://github.com/apache/hadoop/pull/3612 does not apply to trunk. Rebase required? Wrong Branch? See https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute for help.

Subsystem
Report/Notes

GITHUB PR
https://github.com/apache/hadoop/pull/3612

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3612/1/console

versions
git=2.17.1

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

Comparing with #2159, this adds LzoCompressor and LzoDecompressor (WIP) supports. I don't put this bridging classes with same name to com.hadoop.compression.lzo.LzoCodec etc. User might be unaware of the implicit change of codec, and I also think some users may still want to stick with original codec implementation.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m  0s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
12m 59s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
25m  3s

trunk passed

+1 :green_heart:
compile
24m 12s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
compile
20m  7s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
checkstyle
3m 55s

trunk passed

+1 :green_heart:
mvnsite
2m  4s

trunk passed

+1 :green_heart:
javadoc
1m 31s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
2m  2s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+0 :ok:
spotbugs
0m 32s

branch/hadoop-project no spotbugs output file (spotbugsXml.xml)

+1 :green_heart:
shadedclient
24m 19s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 19s

Maven dependency ordering for patch

-1 :x:
mvninstall
0m 11s
/patch-mvninstall-hadoop-common-project_hadoop-common.txt
hadoop-common in the patch failed.

-1 :x:
compile
0m 33s
/patch-compile-root-jdkUbuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04.txt
root in the patch failed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04.

-1 :x:
javac
0m 33s
/patch-compile-root-jdkUbuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04.txt
root in the patch failed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04.

-1 :x:
compile
0m 30s
/patch-compile-root-jdkPrivateBuild-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10.txt
root in the patch failed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10.

-1 :x:
javac
0m 30s
/patch-compile-root-jdkPrivateBuild-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10.txt
root in the patch failed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10.

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
3m 30s
/results-checkstyle-root.txt
root: The patch generated 24 new + 69 unchanged - 0 fixed = 93 total (was 69)

-1 :x:
mvnsite
0m 12s
/patch-mvnsite-hadoop-common-project_hadoop-common.txt
hadoop-common in the patch failed.

+1 :green_heart:
xml
0m  3s

The patch has no ill-formed XML file.

-1 :x:
javadoc
0m 12s
/patch-javadoc-hadoop-common-project_hadoop-common-jdkUbuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04.txt
hadoop-common in the patch failed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04.

-1 :x:
javadoc
0m 12s
/patch-javadoc-hadoop-common-project_hadoop-common-jdkPrivateBuild-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10.txt
hadoop-common in the patch failed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10.

+0 :ok:
spotbugs
0m 13s

hadoop-project has no data from spotbugs

-1 :x:
spotbugs
0m 12s
/patch-spotbugs-hadoop-common-project_hadoop-common.txt
hadoop-common in the patch failed.

-1 :x:
shadedclient
1m  1s

patch has errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
0m 12s

hadoop-project in the patch passed.

-1 :x:
unit
0m 11s
/patch-unit-hadoop-common-project_hadoop-common.txt
hadoop-common in the patch failed.

+1 :green_heart:
asflicense
0m 27s

The patch does not generate ASF License warnings.

130m  7s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3612/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3612

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell xml spotbugs checkstyle

uname
Linux 9194c18eb7ec 4.15.0-142-generic #146-Ubuntu SMP Tue Apr 13 01:11:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 426529446c52cdda37a9e8a3aab7bb9683dca263

Default Java
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3612/2/testReport/

Max. process+thread count
518 (vs. ulimit of 5500)

modules
C: hadoop-project hadoop-common-project/hadoop-common U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3612/2/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

Hmm, for the test, I built hadoop-lzo 0.4.21-SNAPSHOT locally with native-lzo library for Mac OS. Switched to 0.4.20 for CI to see if it works.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 56s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
13m 14s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
24m 12s

trunk passed

+1 :green_heart:
compile
23m 37s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
compile
21m 48s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
checkstyle
3m 52s

trunk passed

+1 :green_heart:
mvnsite
2m  0s

trunk passed

+1 :green_heart:
javadoc
1m 31s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
2m  2s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+0 :ok:
spotbugs
0m 32s

branch/hadoop-project no spotbugs output file (spotbugsXml.xml)

+1 :green_heart:
shadedclient
24m 23s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 31s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m 10s

the patch passed

+1 :green_heart:
compile
26m 28s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javac
26m 28s

the patch passed

+1 :green_heart:
compile
21m 25s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
javac
21m 25s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
4m 11s
/results-checkstyle-root.txt
root: The patch generated 24 new + 69 unchanged - 0 fixed = 93 total (was 69)

+1 :green_heart:
mvnsite
2m  9s

the patch passed

+1 :green_heart:
xml
0m  3s

The patch has no ill-formed XML file.

-1 :x:
javadoc
1m  5s
/patch-javadoc-hadoop-common-project_hadoop-common-jdkUbuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04.txt
hadoop-common in the patch failed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04.

-1 :x:
javadoc
1m 38s
/results-javadoc-javadoc-hadoop-common-project_hadoop-common-jdkPrivateBuild-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10.txt
hadoop-common-project_hadoop-common-jdkPrivateBuild-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 generated 3 new + 0 unchanged - 0 fixed = 3 total (was 0)

+0 :ok:
spotbugs
0m 31s

hadoop-project has no data from spotbugs

+1 :green_heart:
shadedclient
25m 37s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
0m 26s

hadoop-project in the patch passed.

-1 :x:
unit
17m 46s
/patch-unit-hadoop-common-project_hadoop-common.txt
hadoop-common in the patch passed.

+1 :green_heart:
asflicense
0m 52s

The patch does not generate ASF License warnings.

228m 17s

Reason
Tests

Failed junit tests
hadoop.io.file.tfile.TestTFileLzoCodecsStreams

hadoop.io.file.tfile.TestTFileLzoCodecsByteArrays

hadoop.io.compress.TestCodec

hadoop.io.file.tfile.TestTFileSeqFileComparison

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3612/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3612

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell xml spotbugs checkstyle

uname
Linux 158ecb1201cb 4.15.0-142-generic #146-Ubuntu SMP Tue Apr 13 01:11:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / e7d98ab66585cbae11162ae605bf001839705be0

Default Java
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3612/3/testReport/

Max. process+thread count
1261 (vs. ulimit of 5500)

modules
C: hadoop-project hadoop-common-project/hadoop-common U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3612/3/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

Hmm, seems not work.
[ERROR] testLzoCodec(org.apache.hadoop.io.compress.TestCodec)  Time elapsed: 0.004 s  <<< ERROR!
java.lang.RuntimeException: native-lzo library not available

I checked hadoop-lzo-0.4.20.jar. It includes native library for Linux-amd64-64 target, e.g.,
native/Linux-amd64-64/lib/libgplcompression.a
native/Linux-amd64-64/lib/libgplcompression.so

Maybe the CI is not the target?
So seems we cannot run the comparison test between the GPL lzo codec and this lzo codec.
I have run them locally to verify the comparison. The reviewers may build and install GPL lzo locally to run the test.
Once the reviewers think it is okay, I will remove GPL lzo codec stuffs.
@sunchao @dbtsai

Thanks @viirya , I'll take a look soon.

@viirya can you share how to test this locally? I got the same error as above and curious why it didn't work even hadoop-lzo is already a test dependency.

@sunchao I built and installed this https://github.com/twitter/hadoop-lzo locally. You may need to revert https://github.com/apache/hadoop/pull/3612/commits/e7d98ab66585cbae11162ae605bf001839705be0 to use 0.4.21-SNAPSHOT version built from the source.

Cool thanks. I verified locally and the relevant tests in TestCodec all passed.

Thanks @sunchao . So I think we verified the new Lzo compressor and GPL Lzo compressor.

Yes looks OK so far. For reference, in the PR description could you add what other projects are using aircompressor for the same purpose (it'd be nice if you have a link to the related code)?
Feel free to update the PR and mark it as ready for review.

Thanks @sunchao !
I think the mostly famous usage of aircompressor is trino.  Trino uses the library for its Lz4Codec, LzoCodec, SnappyCodec, etc. The code link is:
https://github.com/trinodb/trino/blob/fe608f2723842037ff620d612a706900e79c52c8/lib/trino-rcfile/src/main/java/io/trino/rcfile/AircompressorCodecFactory.java
I also updated in the description.