[jvm-packages] Added baseMargin to ml.dmlc.xgboost4j.LabeledPoint

Previously, in order to use baseMargin the user should've provided an RDD with exactly the same partitioning as the training RDD. This is hard/impossible to achieve in the general case. This PR integrates baseMargin into LabeledPoint making the partitioning requirement irrelevant. See individual commit messages for motivation on each change.

Codecov Report

Merging #2532 into master will increase coverage by 0.34%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2532      +/-   ##
==========================================
+ Coverage    76.6%   76.94%   +0.34%
==========================================
  Files          46       46
  Lines        2620     2620
  Branches      201      201
==========================================
+ Hits         2007     2016       +9
+ Misses        519      518       -1
+ Partials       94       86       -8

Impacted Files
Coverage Δ

src/metric/rank_metric.cc
91.35% <0%> (+0.54%)
:arrow_up:

src/data/sparse_page_dmatrix.cc
87.97% <0%> (+1.09%)
:arrow_up:

src/data/simple_dmatrix.cc
58% <0%> (+1.33%)
:arrow_up:

src/objective/regression_obj.cc
87.97% <0%> (+1.63%)
:arrow_up:

src/data/sparse_page_raw_format.cc
84.61% <0%> (+1.92%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4eb2552...400446d. Read the comment docs.

what happened on lint????@terrytang

Yeah, all the PRs seem to fail on lint :)

Could it be the new pylint version?

Should be fixed in #2537

The test failures are now due to the coverage false positive. Could we configure it not to evaluate PRs with [jvm-packages]?

do not worry, I will look at it tmr....looks like I can still merge it if the coverage is down

Thank you very much for the comments. I've pushed a fix for whitespace/imports and detailed my thoughts about the API compatibility above.
In my opinion we can be pretty relaxed about backward compatibility since there's no versioning/releases for the JVM packages, because is just no protocol for implementing a backward incompatible change in a safe manner (same goes for deprecating APIs, at no point we would be able to safely remove them).

regarding backward compatibility, my understanding is that's the thing we should pursue with the best effort, regardless of the existence of versioning
actually, if there is really released versions...we can easily change major/minor version number to indicate a broken backward compatibility....

update?

@CodingCat would you have time to do another pass on this this week?

sure, I can do it before Saturday

merged thanks


Update jackson.version to <IP_ADDRESS>91020 to address CVE

Update jackson.version in dropwizard-bom from 2.9.10 to <IP_ADDRESS>91020
This updates jackson-databind from 2.9.10 to <IP_ADDRESS>, and addresses three CVE, all with CVSS v3.1 score of 9.8

CVE-2019-16942
CVE-2019-16943
CVE-2019-17531

The update should be done release/1.3.x branch.
Master (2.0.x) is using jackson 2.10.0 which is not vulnerable to the CVE.

@msymons Thanks for your contribution!


Allow sys.path modifications between imports

Summary
It's common to interleave a sys.path modification between imports at the top of a file. This is a frequent cause of # noqa: E402 false positives, as seen in the ecosystem checks. This PR modifies E402 to omit such modifications when determining the "import boundary".
(We could consider linting against sys.path modifications, but that should be a separate rule.)
Closes: https://github.com/astral-sh/ruff/issues/5557.

I think these are all improvements -- it's nice to see so many # noqa comments being removed.

I gated this to preview for now, though honestly I'd be okay with shipping it to stable...

Looking at the ecosystem checks with entrypoint scripts and tests, this makes even more sense

Why modify sys.path? This sounds like a dirty fix for bad design, not something to encourage.

Hi @tooruu I'd recommend looking through the ecosystem checks as some of this usage is entirely valid.
We're not encouraging this behavior, we're simply fixing a false positive for a different lint rule. We can introduce a separate rule to suggest not making sys.path modifications to properly discourage this behavior.


The scrapper fails more ofter as of recently

Hello! recently, i noticed that the scrapper fails more often.
Here is a video showing what i mean: https://www.dropbox.com/s/bfn858cbaqo7b6m/video for youtube scrapper.mov?dl=0
When i have time, i will try to investigate this issue.

I had some time on my hands and did some tests.
It seems like the html returned now comes in two (or more) types. i made two files one. One contains html that is parsed successfully using your current method, called Goodhtml, and one that fails, called Badhtml.
here : https://www.dropbox.com/s/mwv8fbe6ctx9y4x/ytseachhtmlexamples.zip?dl=0

Alright, yeah it looks like a different format of html.
window["ytInitialData"] = {
   ...
};
window["ytInitialPlayerResponse"] = null;

vs
var ytInitialData = {
   ...
};

So looks like there need to be two methods or a more generic way of grabbing data from the html file to parse

And it also seems that the page parameter is not working anymore. It works only now and then, but more often not...

And it also seems that the page parameter is not working anymore. It works only now and then, but more often not...

That's interesting, from what I see, YouTube search results have infinite loading, but the page query still works on their website.

Yes, but if you try several times, finally will fail. It also works for me from time to time, but eventually it fails.

There is a temporary fix available.
html
  .split("ytInitialData = ")[1]
  .split("</script>")[0]
  .replace("// scraper_data_end", "")
  .replace(";", "");

this will be returning ytInitialData as string it can be parsed with JSON.parse().

Yes, but keep in mind that at the moment youtube pages also return the old version. So basically, you need to test before which version you have and then apply one pattern or the other.
        const txt = html.replace(/[\n\r]/g, '');
        const p1 = /^.*ytInitialData"[ ]*\][ ]*=[ ]*(.*);[ ]*window[ ]*\["ytInitialPlayerResponse"\].*$/;
        const p2 = /^.*ytInitialData[ ]*=[ ]*(.*);[ ]*\/\/ scraper_data_end.*$/;
        let jsonTxt = txt.replace(p1, '$1');
        if (!txt.match(p1)) {
            jsonTxt = txt.replace(p2, '$1');
        }
        const json = JSON.parse(jsonTxt);

Yes, but keep in mind that at the moment youtube pages also return the old version. So basically, you need to test before which version you have and then apply one pattern or the other.
        const txt = html.replace(/[\n\r]/g, '');
        const p1 = /^.*ytInitialData"[ ]*\][ ]*=[ ]*(.*);[ ]*window[ ]*\["ytInitialPlayerResponse"\].*$/;
        const p2 = /^.*ytInitialData[ ]*=[ ]*(.*);[ ]*\/\/ scraper_data_end.*$/;
        let jsonTxt = txt.replace(p1, '$1');
        if (!txt.match(p1)) {
            jsonTxt = txt.replace(p2, '$1');
        }
        const json = JSON.parse(jsonTxt);

Thanks, I've taken the initial idea here and made commit to fix issue. There is a PR #35  to merge into develop when I'm able to test later.

@HermanFassett you can have a look at: https://github.com/SoulHarsh007/youtube-scrape/blob/master/scraper.js, Hope it helps you 😄

@HermanFassett you can have a look at: https://github.com/SoulHarsh007/youtube-scrape/blob/master/scraper.js, Hope it helps you 😄

I have to say, i love how you optimized this code. Very elegant.

I see that in the new implementation you only display the first page of the results? Because my problem right now is that the page parameter is not working anymore.

https://github.com/FashionCStar/youtube-scrape
I also customized your scraper and now it's working well on page 1
but it returns the same result as page 2

@HermanFassett
When I run your project on my local, I am getting blank results.
{"results":[],"version":"0.1.1","parser":"json_format"}
so I changed the version to 0.1.2
but after a few times of request, it returns a blank results again.
{"results":[],"version":"0.1.2","parser":"json_format"}

@HermanFassett
When I run your project on my local, I am getting blank results.
{"results":[],"version":"0.1.1","parser":"json_format"}
so I changed the version to 0.1.2
but after a few times of request, it returns a blank results again.
{"results":[],"version":"0.1.2","parser":"json_format"}

Is there a specific example that causes it to run blank? Or just continued results? Any exception message you could see? I couldn't get it to return blank after a few minutes of testing.

@cosminadrianpopescu @FashionCStar okay, will check out pages in issue #36

@HermanFassett
http://youtube-scrape.herokuapp.com/api/search?q=angular&page=1
I got a blank result after this request 2 times
and when I run your project on my local, I am getting a blank result too
localhost:3000/api/search?q=angular&page=1

Okay, yeah my heroku deploy was old version 0.1.1 since I haven't merged to master yet, so I would expect that. I pushed changes and now I see consistent results. You're running locally on the latest develop branch change 0.1.2?

of course, I am running version 0.1.2 on my local

but after 2 or 3 times of api call request, it returns blank result

@HermanFassett
of course, I am running version 0.1.2 on my local

Okay, I asked because I did not expect you to get "parser":"json_format" in the results you posted previously. I expected either "parser": "json_format.scraper_data" or "parser": "json_format.original".

so should I change the parser to "json_format.scraper_data" ?

json["parser"] = "json_format.scraper_data";
like this @HermanFassett ?

so should I change the parser to "json_format.scraper_data" ?

You shouldn't need to make the changes if you pull the development branch down to your local machine. That branch has all the changes. I'll be merging those changes into master soon.
If you think you have all the changes and you've checked out development branch, run git log and verify the top commit says Fix youtube json parsing (#35) (30297509bd72979c596328303fb802ffea420115).

Cool
I will pull from development branch
BTW, did you find a solution for page number?

@cosminadrianpopescu @FashionCStar potential update coming to fix the page issue (#36) with initial work in eb6cc42c050bd1c326b18667c872dac96febe6a9 on secondary branch. Will need more work before merging to develop.
If this issue on intermittent failures appears to be fixed for you guys with the changes currently on develop, I can work on merging to master and closing this issue.

For me the current issue is solved. No problem with the fix from develop.

@cosminadrianpopescu
Did you fix the page number issue?

Did you fix the page number issue?

No, I was just saying that the current issue is solved. I will have a look at the PR that @HermanFassett  was talking about and see if this fixes the page issue. But at the moment, the page issue is there.

@HermanFassett
How are you doing?
Any good news for the page number issue?
Regards

@HermanFassett
How are you doing?
Any good news for the page number issue?
Regards

I'm out of town atm so I can't really work on changes. You can try out the branch update-pagination for my change that should give you a pageToken and key to use for next page results, but I need to clean it up more before I merge into develop and master. I don't think it's possible to have the code work with the page=n query string it used to use.

@HermanFassett
I am running your update-pagination branch and it's working well
I have one question
How can I get the channel title and channel URL of each video in the parseVideoRenderer function?

@HermanFassett
I am running your update-pagination branch and it's working well
I have one question
How can I get the channel title and channel URL of each video in the parseVideoRenderer function?

The result of that method is an object with a video child object and a uploader child object. You can get data for the channel like uploader.username and uploader.url associated with that video result.

oh...
uploader.username  and uploader.url is the info of channel ?

I've tested the update-pagination branch and it works for me.

Hello @HermanFassett and thank you for your efforts. Just wanted to give you heads up that starting last Wednesday, 28 Oct 2020, youtube returns the new format only so all responses from the current repo return with parser = .scraper_data.
I suggest that you tweak the code to skip the check for the old html_format and check for .scraper_data first before the  .original to optimize the code.
Best regards.


Setup Travis CI so that unit tests are run automatically

Also updated README.md to have badges for test and code coverage. Some existing tests that are failing include test_sox_effects.py and test_dataloader.py are commented out. Future PR will uncomment and fix them. See https://travis-ci.org/jamarshon/audio

@jamarshon can you send a PR that fixes the tests before we land this? I rather not land a lot of uncommented code.

sox is very buggy. initialize_sox() and shutdown_sox() can be called only once in the entire program execution. An example of segmentation fault would be:
torchaudio.initialize_sox()
torchaudio.load(...)
torchaudio.shutdown_sox()
torchaudio.initialize_sox()
torchaudio.load(...)

One solution is to call initialize_sox() when the torchaudio module is loaded because it is a singleton. Cleanup would be handled by atexit when the program terminates.
http://man7.org/linux/man-pages/man3/atexit.3.html
https://github.com/pytorch/pytorch/blob/dfcd7b0185d479f186ddb100c761f4df3495f8e8/caffe2/python/_import_c_extension.py#L52
The issue with fixing sox is out of the scope of this PR. Instead, we will fix the tests which do not call initialize_sox/shutdown_sox as python -m unittest or py.test does not call the __main__parts of the test.
https://github.com/pytorch/audio/issues/101
pytest defaults to running all tests in a single process in sequence which would have initialize_sox/shutdown_sox issues and when a seg fault occurs, the remaining tests are not executed. the solution is to use pytest-forked which runs each test on a separate process.


Arch Linux support for install_prereq.sh

I edited the script to detect OS (and fallback to debian-based install should detection fail) and added a relevant function for Arch Linux (and possibly its derivatives).
I have changed installing the pip modules as current user(root), not system-wide, as that conflicts with the system package manager.
I looked where the pip dependencies are used and it looks like they're all called from sudo screen, so installing as root user should be correct.
Tested with Ubuntu 20.10 and Arch.
EDIT: Went through with the flash on Arch successfully, but had to disable NM as it was interfering with the AP script, added note to the setup while I was at it.

The Network Manager service is also called NetworkManager on most Red Hat based distributions as well. It would be nice if there was a check for it (ie. check if network-manager or NetworkManager is a running service) to make the script was a tad more dynamic. I have no issues writing it and submitting a PR if that is something that will be accepted.

The Network Manager service is also called NetworkManager on most Red Hat based distributions as well. It would be nice if there was a check for it (ie. check if network-manager or NetworkManager is a running service) to make the script was a tad more dynamic. I have no issues writing it and submitting a PR if that is something that will be accepted.

Hi @C0rn3j, thanks for your contribution! I'll switch the base branch to development which is currently staging for the next release.
Regarding NetworkManager @C0rn3j and @jmiahman, this should already be handled automatically. If this is not working then that is an issue unto itself. See the relevant code here and let me know how we can improve. I will gladly take a PR for this.
The rest looks good to me, though I'm not able to test comprehensively.

Hi @C0rn3j, thanks for your contribution! I'll switch the base branch to development which is currently staging for the next release.
Regarding NetworkManager @C0rn3j and @jmiahman, this should already be handled automatically. If this is not working then that is an issue unto itself. See the relevant code here and let me know how we can improve. I will gladly take a PR for this.
The rest looks good to me, though I'm not able to test comprehensively.

Fixed the conflict due to rfkill being added (in util-linux on Arch), hopefully correctly

Fixed the conflict due to rfkill being added (in util-linux on Arch), hopefully correctly

@kueblc
I fixed the conflict that popped up a while ago, could you please pull this? I did test it when I originally made the commit.
Tried to test it now again but unfortunately it seems that newer version of BW-SHP6 Pro and other devices now do not ship with ESP8266 anymore...

Can this be merged?

Thanks for your contribution! I haven't had a chance to test but LGTM so it's now on dev branch

Side note, the latest commit can be improved to first try stopping NetworkManager and not network-manager, as network-manager is the old name, so it'd be best to try with the new name first instead to avoid needlessly spamming logs.
Thanks for pulling it!


Add testcase for Phony.normalize with/without :cc option for Japan.

Thanks for last PR #453 merged.
Unfortunately, Phony.normalize with :cc option is broken.
The following is telephone number in Japan (all is same number):
+81 3-1234-5634 (international)
03-1234-5634 (from all area in Japan)
1234-5634 (from same area, in ths case From Tokyo to Tokyo)
So, I want to "normalize method" behaves as follows:
Phony["81"].normalize('+81 3-1234-5634').assert == '0312345634'
Phony["81"].normalize('03-1234-5634').assert == '0312345634'
Phony.normalize('+81 3-1234-5634').assert == '81312345634'
Phony.normalize('03-1234-5634', cc: '81').assert == '81312345634'

But now:
Phony["81"].normalize('+81 3-1234-5634')   => "81312345634"  # wrong, expected to national format "0312345634"
Phony["81"].normalize('03-1234-5634')        => "0312345634"    # right
Phony.normalize('+81 3-1234-5634')            => "81312345634"   # right
Phony.normalize('03-1234-5634', cc: '81')    => "810312345634" # wrong, expected to international format "81312345634"

Could you please fix this problem?

Coverage decreased (-0.7%) to 97.067% when pulling 9e491ccc3dc3a1bb908eb4bd869de2142d790600 on nabetaro:national_number_in_japan into 0876f345317ebe4e5fe270269854561d271aa3b9 on floere:master.

I've merged two test cases from this branch that were not in #453 yet into master.


backend: endpoint for "adding new journal" and "listing journal for a particular email" added

fixes #11
fixes #12

Done in #22


Withdraw honey deposits for past proposals

When in the deposit manager I see the following:

Many of these proposals have been cancelled/withdrawn, so I should be able to withdraw my deposit. For example: https://gardens.1hive.org/#/xdai/garden/0x8ccbeab14b5ac4a431fffc39f4bec4089020a155/proposal/111
I would expect that in the deposit manager these would all be listed as "Unlocked" and I would have the option to reclaim/withdraw them.

Yeah i have same problem. Did you remember if that unlock automatically in the past?


Update certbot-dns-godaddy version requirements

Updated the version for certbot-dns-godaddy to 2.6.0.  This resolved #3103 for me.

This is a new file - not editing the existing file located at ./global/certbot-dns-plugins.js so this will have no effect on the build.


Minor changes to paper.md (mostly gramatical)

See my commit comment below; just minor edits here.
Submitting this pull request as part of the JOSS review process (openjournals/joss-reviews#2075)

Codecov Report

Merging #94 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master     #94   +/-   ##
======================================
  Coverage    83.1%   83.1%
======================================
  Files           9       9
  Lines         515     515
======================================
  Hits          428     428
  Misses         87      87

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e4e74ef...1b001a8. Read the comment docs.

@conlin-matt — thank you for these edits. I adjusted the SIS line a bit, LMK if this works for you:

... categorize impact in the context of the @Sallenger2000 Storm
Impact Scale...

@ebgoldstein Yeah, I think that text is good- true to the nature of the SIS and concise.


Use LogEvent.UnstableAssembleFromParts() to avoid a dictionary alloc

This PR may need to sit out here for a while due to the uncertain release timeline of Serilog 4.0; it uses LogEvent.UnstableAssembleFromParts() to knock around 216 bytes off of benchmark cases that trigger log event construction.
Plenty of other scenarios should now benefit from avoiding the need to allocate LogEventProperty instances that are subsequently thrown away, though there are a lot of low-hanging fruit still within reach in this area.
Minor version bump, since the package API is unbroken, but the move to Serilog 4 might end up warranting a major version bump here.

BenchmarkDotNet v0.13.12, Ubuntu 22.04.4 LTS (Jammy Jellyfish)
13th Gen Intel Core i7-13700K, 1 CPU, 24 logical and 16 physical cores
.NET SDK 8.0.201
  [Host]     : .NET 8.0.2 (<IP_ADDRESS>11), X64 RyuJIT AVX2
  DefaultJob : .NET 8.0.2 (<IP_ADDRESS>11), X64 RyuJIT AVX2

Before
Tracing on

Method
Mean
Error
StdDev
Ratio
RatioSD
Gen0
Allocated
Alloc Ratio

ActivitySourceBaseline
244.7 ns
1.18 ns
1.10 ns
1.00
0.00
0.0439
688 B
1.00

ActivityListenerOnly
450.8 ns
4.55 ns
4.03 ns
1.84
0.02
0.0920
1448 B
2.10

StartThenDispose
432.0 ns
2.06 ns
1.93 ns
1.77
0.01
0.0882
1384 B
2.01

StartThenComplete
836.9 ns
3.39 ns
2.83 ns
3.42
0.02
0.1411
2224 B
3.23

Tracing not configured

Method
Mean
Error
StdDev
Gen0
Allocated

StartThenDispose
324.6 ns
2.32 ns
2.17 ns
0.0792
1.22 KB

StartThenComplete
740.8 ns
3.44 ns
3.22 ns
0.1326
2.04 KB

After
Tracing on

Method
Mean
Error
StdDev
Ratio
RatioSD
Gen0
Allocated
Alloc Ratio

ActivitySourceBaseline
253.5 ns
1.20 ns
1.12 ns
1.00
0.00
0.0439
688 B
1.00

ActivityListenerOnly
411.4 ns
1.62 ns
1.52 ns
1.62
0.01
0.0782
1232 B
1.79

StartThenDispose
394.7 ns
1.70 ns
1.59 ns
1.56
0.01
0.0744
1168 B
1.70

StartThenComplete
798.1 ns
2.59 ns
2.42 ns
3.15
0.02
0.1278
2008 B
2.92

Tracing not configured

Method
Mean
Error
StdDev
Gen0
Allocated

StartThenDispose
302.3 ns
4.20 ns
3.93 ns
0.0658
1.01 KB

StartThenComplete
690.1 ns
3.32 ns
3.11 ns
0.1192
1.83 KB

This one should be ready to go now.


installation on 10.10.2 fails silently

I am an admin user.
I see this in the console log when the failure occurs:
4/12/15 9:02:40.853 PM Quicksilver[1039]: chown -R 0:80 /Volumes/Quicksilver/Quicksilver.app failed.

That’s weird. It seems to think the disk image is the destination, not the source.
The “installation” is only there as a safety net anyway. If you install it the real way (by dragging it from the disk image to /Applications before you launch it,  then launching it from there) it should be fine.

Thanks for the quick reply. I'll try the "real" way.
Regards,
--Jon Ruttenberg
On Apr 12, 2015, at 11:59 PM, Rob McBroom<EMAIL_ADDRESS>wrote:

That’s weird. It seems to think the disk image is the destination, not the source.
The “installation” is only there as a safety net anyway. If you install it the real way (by dragging it from the disk image to /Applications before you launch it, then launching it from there) it should be fine.
—
Reply to this email directly or view it on GitHub.


Some unit tests for the tools

Partial #1606

Review by @sjrd

Refer to this link for build results (access rights to CI server needed):
https://scala-webapps.epfl.ch/jenkins/job/scalajs-pr/3360/
https://scala-webapps.epfl.ch/jenkins/job/scalajs-matrix-build/4402/
Test PASSed.

That's all.

Ping @gzm0 ;-)

Updated.

LGTM :)

Refer to this link for build results (access rights to CI server needed):
https://scala-webapps.epfl.ch/jenkins/job/scalajs-pr/3368/
https://scala-webapps.epfl.ch/jenkins/job/scalajs-matrix-build/4415/
Test PASSed.


Build/Download DeepVariant Models Fails

https://github.com/tgen/jetstream_resources/blob/1c10027dc4e14f191437e3672364d5165d4679b5/shared_resource_creation_scripts/create_deepvariant_models.sh#L82
@bryce-turner

The final path defined by this does NOT match the phoenix YAML
The executed find to move the relevant files to the top does not work, given the variable provided is v0.9.0 and the files are "v3-0.9.0+data"

Script works now, but needs to be rerun and phoenix YAML needs to be updated


Does not install on Ubuntu 20.04

Following the installation instructions I ran out into an error that there must be a Conda environment called pytorch1.0.0 after running ./build.sh  – this is not mentioned in the compilation instructions. Well, I created a Conda environment called pytorch1.0.0 and installed pytorch v1.4.0 (I saw on issue #118 that newer versions of pytorch aren't compatible, this is also not on the instructions) and ran build.sh again. Now, I come to:
(pytorch1.0.0) luiz@luiz-Aspire-V3-772:[/media/luiz/Volume/Downloads/DAIN/my_package]: ./build.sh
Need pytorch>=1.0.0
./build.sh: line 4: activate: No such file or directory
Traceback (most recent call last):
  File "setup.py", line 16, in <module>
    ], extra_compile_args={'cxx': cxx_args, 'nvcc': nvcc_args})
  File "/media/luiz/Volume/anaconda3/envs/pytorch1.0.0/lib/python3.7/site-packages/torch/utils/cpp_extension.py", line 498, in CUDAExtension
    library_dirs += library_paths(cuda=True)
  File "/media/luiz/Volume/anaconda3/envs/pytorch1.0.0/lib/python3.7/site-packages/torch/utils/cpp_extension.py", line 577, in library_paths
    if (not os.path.exists(_join_cuda_home(lib_dir)) and
  File "/media/luiz/Volume/anaconda3/envs/pytorch1.0.0/lib/python3.7/site-packages/torch/utils/cpp_extension.py", line 1252, in _join_cuda_home
    raise EnvironmentError('CUDA_HOME environment variable is not set. '
OSError: CUDA_HOME environment variable is not set. Please set it to your CUDA install root.
Traceback (most recent call last):
  File "setup.py", line 16, in <module>
    ], extra_compile_args={'cxx': cxx_args, 'nvcc': nvcc_args})
  File "/media/luiz/Volume/anaconda3/envs/pytorch1.0.0/lib/python3.7/site-packages/torch/utils/cpp_extension.py", line 498, in CUDAExtension
    library_dirs += library_paths(cuda=True)
  File "/media/luiz/Volume/anaconda3/envs/pytorch1.0.0/lib/python3.7/site-packages/torch/utils/cpp_extension.py", line 577, in library_paths
    if (not os.path.exists(_join_cuda_home(lib_dir)) and
  File "/media/luiz/Volume/anaconda3/envs/pytorch1.0.0/lib/python3.7/site-packages/torch/utils/cpp_extension.py", line 1252, in _join_cuda_home
    raise EnvironmentError('CUDA_HOME environment variable is not set. '
OSError: CUDA_HOME environment variable is not set. Please set it to your CUDA install root.
Traceback (most recent call last):
  File "setup.py", line 16, in <module>
    ], extra_compile_args={'cxx': cxx_args, 'nvcc': nvcc_args})
  File "/media/luiz/Volume/anaconda3/envs/pytorch1.0.0/lib/python3.7/site-packages/torch/utils/cpp_extension.py", line 498, in CUDAExtension
    library_dirs += library_paths(cuda=True)
  File "/media/luiz/Volume/anaconda3/envs/pytorch1.0.0/lib/python3.7/site-packages/torch/utils/cpp_extension.py", line 577, in library_paths
    if (not os.path.exists(_join_cuda_home(lib_dir)) and
  File "/media/luiz/Volume/anaconda3/envs/pytorch1.0.0/lib/python3.7/site-packages/torch/utils/cpp_extension.py", line 1252, in _join_cuda_home
    raise EnvironmentError('CUDA_HOME environment variable is not set. '
OSError: CUDA_HOME environment variable is not set. Please set it to your CUDA install root.
Traceback (most recent call last):
  File "setup.py", line 16, in <module>
    ], extra_compile_args={'cxx': cxx_args, 'nvcc': nvcc_args})
  File "/media/luiz/Volume/anaconda3/envs/pytorch1.0.0/lib/python3.7/site-packages/torch/utils/cpp_extension.py", line 498, in CUDAExtension
    library_dirs += library_paths(cuda=True)
  File "/media/luiz/Volume/anaconda3/envs/pytorch1.0.0/lib/python3.7/site-packages/torch/utils/cpp_extension.py", line 577, in library_paths
    if (not os.path.exists(_join_cuda_home(lib_dir)) and
  File "/media/luiz/Volume/anaconda3/envs/pytorch1.0.0/lib/python3.7/site-packages/torch/utils/cpp_extension.py", line 1252, in _join_cuda_home
    raise EnvironmentError('CUDA_HOME environment variable is not set. '
OSError: CUDA_HOME environment variable is not set. Please set it to your CUDA install root.
Traceback (most recent call last):
  File "setup.py", line 16, in <module>
    ], extra_compile_args={'cxx': cxx_args, 'nvcc': nvcc_args})
  File "/media/luiz/Volume/anaconda3/envs/pytorch1.0.0/lib/python3.7/site-packages/torch/utils/cpp_extension.py", line 498, in CUDAExtension
    library_dirs += library_paths(cuda=True)
  File "/media/luiz/Volume/anaconda3/envs/pytorch1.0.0/lib/python3.7/site-packages/torch/utils/cpp_extension.py", line 577, in library_paths
    if (not os.path.exists(_join_cuda_home(lib_dir)) and
  File "/media/luiz/Volume/anaconda3/envs/pytorch1.0.0/lib/python3.7/site-packages/torch/utils/cpp_extension.py", line 1252, in _join_cuda_home
    raise EnvironmentError('CUDA_HOME environment variable is not set. '
OSError: CUDA_HOME environment variable is not set. Please set it to your CUDA install root.
Traceback (most recent call last):
  File "setup.py", line 16, in <module>
    ], extra_compile_args={'cxx': cxx_args, 'nvcc': nvcc_args})
  File "/media/luiz/Volume/anaconda3/envs/pytorch1.0.0/lib/python3.7/site-packages/torch/utils/cpp_extension.py", line 498, in CUDAExtension
    library_dirs += library_paths(cuda=True)
  File "/media/luiz/Volume/anaconda3/envs/pytorch1.0.0/lib/python3.7/site-packages/torch/utils/cpp_extension.py", line 577, in library_paths
    if (not os.path.exists(_join_cuda_home(lib_dir)) and
  File "/media/luiz/Volume/anaconda3/envs/pytorch1.0.0/lib/python3.7/site-packages/torch/utils/cpp_extension.py", line 1252, in _join_cuda_home
    raise EnvironmentError('CUDA_HOME environment variable is not set. '
OSError: CUDA_HOME environment variable is not set. Please set it to your CUDA install root.
Traceback (most recent call last):
  File "setup.py", line 16, in <module>
    ], extra_compile_args={'cxx': cxx_args, 'nvcc': nvcc_args})
  File "/media/luiz/Volume/anaconda3/envs/pytorch1.0.0/lib/python3.7/site-packages/torch/utils/cpp_extension.py", line 498, in CUDAExtension
    library_dirs += library_paths(cuda=True)
  File "/media/luiz/Volume/anaconda3/envs/pytorch1.0.0/lib/python3.7/site-packages/torch/utils/cpp_extension.py", line 577, in library_paths
    if (not os.path.exists(_join_cuda_home(lib_dir)) and
  File "/media/luiz/Volume/anaconda3/envs/pytorch1.0.0/lib/python3.7/site-packages/torch/utils/cpp_extension.py", line 1252, in _join_cuda_home
    raise EnvironmentError('CUDA_HOME environment variable is not set. '
OSError: CUDA_HOME environment variable is not set. Please set it to your CUDA install root.
Traceback (most recent call last):
  File "setup.py", line 16, in <module>
    ], extra_compile_args={'cxx': cxx_args, 'nvcc': nvcc_args})
  File "/media/luiz/Volume/anaconda3/envs/pytorch1.0.0/lib/python3.7/site-packages/torch/utils/cpp_extension.py", line 498, in CUDAExtension
    library_dirs += library_paths(cuda=True)
  File "/media/luiz/Volume/anaconda3/envs/pytorch1.0.0/lib/python3.7/site-packages/torch/utils/cpp_extension.py", line 577, in library_paths
    if (not os.path.exists(_join_cuda_home(lib_dir)) and
  File "/media/luiz/Volume/anaconda3/envs/pytorch1.0.0/lib/python3.7/site-packages/torch/utils/cpp_extension.py", line 1252, in _join_cuda_home
    raise EnvironmentError('CUDA_HOME environment variable is not set. '
OSError: CUDA_HOME environment variable is not set. Please set it to your CUDA install root.

This seems like your CUDA toolkit is not installed correctly, try the following command to check it torch is compatible with CUDA
import torch
torch.Tensor([1.]).cuda()

You should not get warnings or errors for this code.
Did you install cuda from nvidia? And is PyTorch from pip or conda, did you choose the correct cuda version?

I tried this after installing pytorch:
$ python -c "import torch; torch.Tensor([1.]).cuda()"
This is my result.
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/home/~/.local/lib/python3.8/site-packages/torch/cuda/__init__.py", line 172, in _lazy_init
    torch._C._cuda_init()
RuntimeError: Found no NVIDIA driver on your system. Please check that you have an NVIDIA GPU and installed a driver from http://www.nvidia.com/Download/index.aspx

This means you don't have an Nvidia GPU or the driver is not installed correctly.
You have to have an Nvidia GPU, not AMD or Integrated.

Run nvidia-smi to check the GPU status, you should get something like this

Make sure there's a CUDA Version at the top right.
And find the command to install torch on PyTorch 1.4.0 installation command, select the correct system, and CUDA version.

I reinstalled my nVidia drivers entirely (currently using nvidia 450, cuda v.11), created the conda environment called pytorch1.0.0 (conda create -n pytorch1.0.0) and ran what I found in the pytorch's website:
conda install pytorch==1.0.0 torchvision==0.2.1 cuda100 -c pytorch

It now compiled and installed. I will test it later. Thank you so much for the support.
I'll close the issue for now.

running conda install pytorch==1.0.0 torchvision==0.2.1 cuda100 -c pytorch got me:
failed

UnsatisfiableError: The following specifications were found
to be incompatible with the existing python installation in your environment:

Specifications:

  - torchvision==0.2.1 -> python[version='>=2.7,<2.8.0a0|>=3.5,<3.6.0a0|>=3.6,<3.7.0a0|>=3.7,<3.8.0a0']

Your python: python=3.8

Is it a requirement to run the installation as root?
Getting DAIN running on Ubuntu 20.04 turns out to be difficult.
./build.sh returns:

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "setup.py", line 10, in <module>
    setup(
  File "/home/nathaniel/anaconda3/lib/python3.8/site-packages/setuptools/__init__.py", line 153, in setup
    return distutils.core.setup(**attrs)
  File "/home/nathaniel/anaconda3/lib/python3.8/distutils/core.py", line 148, in setup
    dist.run_commands()
  File "/home/nathaniel/anaconda3/lib/python3.8/distutils/dist.py", line 966, in run_commands
    self.run_command(cmd)
  File "/home/nathaniel/anaconda3/lib/python3.8/distutils/dist.py", line 985, in run_command
    cmd_obj.run()
  File "/home/nathaniel/anaconda3/lib/python3.8/site-packages/setuptools/command/install.py", line 67, in run
    self.do_egg_install()
  File "/home/nathaniel/anaconda3/lib/python3.8/site-packages/setuptools/command/install.py", line 109, in do_egg_install
    self.run_command('bdist_egg')
  File "/home/nathaniel/anaconda3/lib/python3.8/distutils/cmd.py", line 313, in run_command
    self.distribution.run_command(command)
  File "/home/nathaniel/anaconda3/lib/python3.8/distutils/dist.py", line 985, in run_command
    cmd_obj.run()
  File "/home/nathaniel/anaconda3/lib/python3.8/site-packages/setuptools/command/bdist_egg.py", line 164, in run
    cmd = self.call_command('install_lib', warn_dir=0)
  File "/home/nathaniel/anaconda3/lib/python3.8/site-packages/setuptools/command/bdist_egg.py", line 150, in call_command
    self.run_command(cmdname)
  File "/home/nathaniel/anaconda3/lib/python3.8/distutils/cmd.py", line 313, in run_command
    self.distribution.run_command(command)
  File "/home/nathaniel/anaconda3/lib/python3.8/distutils/dist.py", line 985, in run_command
    cmd_obj.run()
  File "/home/nathaniel/anaconda3/lib/python3.8/site-packages/setuptools/command/install_lib.py", line 11, in run
    self.build()
  File "/home/nathaniel/anaconda3/lib/python3.8/distutils/command/install_lib.py", line 107, in build
    self.run_command('build_ext')
  File "/home/nathaniel/anaconda3/lib/python3.8/distutils/cmd.py", line 313, in run_command
    self.distribution.run_command(command)
  File "/home/nathaniel/anaconda3/lib/python3.8/distutils/dist.py", line 985, in run_command
    cmd_obj.run()
  File "/home/nathaniel/anaconda3/lib/python3.8/site-packages/setuptools/command/build_ext.py", line 79, in run
    _build_ext.run(self)
  File "/home/nathaniel/anaconda3/lib/python3.8/site-packages/Cython/Distutils/old_build_ext.py", line 186, in run
    _build_ext.build_ext.run(self)
  File "/home/nathaniel/anaconda3/lib/python3.8/distutils/command/build_ext.py", line 340, in run
    self.build_extensions()
  File "/home/nathaniel/.local/lib/python3.8/site-packages/torch/utils/cpp_extension.py", line 670, in build_extensions
    build_ext.build_extensions(self)
  File "/home/nathaniel/anaconda3/lib/python3.8/site-packages/Cython/Distutils/old_build_ext.py", line 195, in build_extensions
    _build_ext.build_ext.build_extensions(self)
  File "/home/nathaniel/anaconda3/lib/python3.8/distutils/command/build_ext.py", line 449, in build_extensions
    self._build_extensions_serial()
  File "/home/nathaniel/anaconda3/lib/python3.8/distutils/command/build_ext.py", line 474, in _build_extensions_serial
    self.build_extension(ext)
  File "/home/nathaniel/anaconda3/lib/python3.8/site-packages/setuptools/command/build_ext.py", line 196, in build_extension
    _build_ext.build_extension(self, ext)
  File "/home/nathaniel/anaconda3/lib/python3.8/distutils/command/build_ext.py", line 528, in build_extension
    objects = self.compiler.compile(sources,
  File "/home/nathaniel/.local/lib/python3.8/site-packages/torch/utils/cpp_extension.py", line 491, in unix_wrap_ninja_compile
    _write_ninja_file_and_compile_objects(
  File "/home/nathaniel/.local/lib/python3.8/site-packages/torch/utils/cpp_extension.py", line 1250, in _write_ninja_file_and_compile_objects
    _run_ninja_build(
  File "/home/nathaniel/.local/lib/python3.8/site-packages/torch/utils/cpp_extension.py", line 1555, in _run_ninja_build
    raise RuntimeError(message) from e
RuntimeError: Error compiling objects for extension


Create documentation in the readme for AutoRefresh

Some documentation how the AutoRefresh works and the different parameters would be useful.

Will do. Probably in a wiki page with a link in the readme.


0.5.1

I have some issues with the first step of 0.5.1. I can't seem to get the loop working, so that the function returns the dataframes from the different years.

The issue you're running into is twofold:

You define the function load_weather(), but never call it. When you then try to call df_last, which only exists within the function, you get a NameError, see scope.
You have a loop within your function, where each iteration returns df_last, whereas the assignment is to create a function which loads the dataframe for a given integer end year and processes as previously (1), and then call it multiple times, storing the dataframes in a list (2).

Hint: Removing the for loop in the function, adding preprocessing to the function and then adding the for loop afterwards where the function is called for each year and then appending to a list could be one way to attack the problem.


Fix typo.

Description

One character typo fix.
Checklist

[ ] I am familiar with the Contributing Guidelines.
[ ] New or existing tests cover these changes.
[ ] The documentation is up to date with these changes.
[ ] The cmake-format.json is up to date with these changes.
[ ] I have added new files under rapids-cmake/

[ ] I have added include guards (include_guard(GLOBAL))
[ ] I have added the associated docs/ rst file and update the api.rst

@gpucibot merge

@vyasr I merged and deleted the vyasr-patch-1 branch from this repo.

Thanks!


enable monitoring for CI jobs

Sometimes CI jobs fails continuously for real failures and we get to know about it may be after 2 days and more. To reduce such case we need to get notified if something is really fishy around CI jobs. Hence we need to monitor our jobs constantly so that we address such failure at earliest.
Acceptance Criteria

[ ] Research the process to monitor CI job constantly on may be IBM cloud or if there is some process on prow
[ ] If a particular CI fails more than 3 times in a row, notify QE  team

/area testing

[ ]  Research the process to monitor CI job constantly on may be IBM cloud or if there is some process on prow
[ ]  If a particular CI fails more than 3 times in a row, notify QE team

We use Jenkins to orchestrate every job, no? Could we use some Jenkins plugin to send notification when a job fails for 3 consecutive times? Also, isn't 3 too low a number considering how flaky/unreliable our tests and test infra has been so far?
Should it notify the dev team as well instead of just QE team? Or do you plan to automate relaying the information to devs as soon as this happens?

Could we use some Jenkins plugin to send notification when a job fails for 3 consecutive times?

AFAIK, yes we can do that. However I am not aware of the exact process atm. We do have post-build actions in jenkins for such scenarios but we don't want to notify for each and every failure. Considering failure count with notification is kind of tricky part for me.

Also, isn't 3 too low a number considering how flaky/unreliable our tests and test infra has been so far?

3 represents 3 consecutive job failure on the same pr. We can also consider looking into a job, failing for all the prs. Or we should try to cover both edge cases.

Should it notify the dev team as well instead of just QE team?

Yes, I think it should be notify either in #odo-notifications slack channel or via email to the whole odo Team. IMO we already have channel created for such things, I would prefer to use that. WDYT?

Sprint 206

[ ] Research the process to monitor CI job constantly on may be IBM cloud or if there is some process on prow

Not required now using  BM Cloud pipelines


Add DCO

Based on https://github.com/nodejs/node/blob/main/CONTRIBUTING.md
Related to https://github.com/openjs-foundation/project-status/issues/15

ping: @expressjs/express-tc

It could be added as a comment in the PR messages like pkgjs does.
ref: https://github.com/pkgjs/.github/blob/main/.github/PULL_REQUEST_TEMPLATE.md?plain=1

Great idea @bjohansebas. Would you mind to do a PR for that? :)


Save plot to image file

Is your feature request related to a problem? Please describe.
I am using the plot widget to visualize log data for failure analysis of hardware systems. I often need to save the plots to image files to include them in written reports. Often I need the info shown for the current mouse position as well, so I need to make a screenshot of the whole desktop, paste that into a separate program and then clip the image to the desired region.
Describe the solution you'd like
It would be great if there was builtin functionality to save a plot to an image file with user defined size. It would be even better, if there was a way generic way to save some part of the window to an image.
Describe alternatives you've considered
I've looked at the screenshot example, but it seems that I can only get a screenshot of the whole window, and that the quality of the image is limited.

I am having the same issue, in terms of figuring out a way to save the plot image only to an image.
Since I have the plot points available in a buffer in egui, one options is to simply make a button such as "save plot image" which would then use the current PlotPoints and write them to a png file.
Since matplotlib is kind of a standard, one consideration is to use one of the the Rust ports of matplotlib to create a PNG file from the data.

I would also really be interested in a egui built-in solution!

I would love this as well! Would be an amazing feature for those using egui to visualize data to be able to save those visualizations.


Digits swapped in German language

When testing the German voice capabilities, I noticed that when I say 28, it will understand 82. I think this is because in German, you don't say twenty-eight but eight-and-twenty (Achtundzwanzig in German). It's better explained here: https://langbox.co/german/german-numbers/

Thanks for reporting this! We are working on a fix


Integrate Torque2D

I can elaborate, if needed

This would be possible once T2D switches graphics operations to a GFX compatible subsystem and use the same audio and console subsystems. And of course platform code between both engines need to match too. Once that happens then you could literally copy all of T2D's 2D gamecore and components source files into say a T2D/ directory under T3D's engine/source/ directory and ta-da instant 2D support.
This would allow T3D to support everything T2D can do while at the same time keep T2D separate as a dedicated 2D game engine as T2D is extremely resource lite and very fast performance wise on mobile platforms. While T3D is currently considered a resource hog and performance monster even on medium end game machines which requires a pretty hefty graphics card.

like I said, I can elaborate if needed

As covered in the other issues, please be clear and elaborate on the issue when submitted to minimize confusion.


ADO agents fail to start when using vmscaleset image Ubuntu 24.04

Description
I have created a new vmscaleset using the latest Ubuntu 24.04 image.
when trying to point ADO pipeline to this new image (Ubuntu 24.04) ,i see the VM gets created but in ado agents won't show up even though everything has been permissioned.
we have same instance setup using Ubuntu 22.04 and everything works (Agents) no issues.
Platforms affected

[X] Azure DevOps
[ ] GitHub Actions - Standard Runners
[ ] GitHub Actions - Larger Runners

Runner images affected

[ ] Ubuntu 20.04
[ ] Ubuntu 22.04
[X] Ubuntu 24.04
[ ] macOS 12
[ ] macOS 13
[ ] macOS 13 Arm64
[ ] macOS 14
[ ] macOS 14 Arm64
[ ] macOS 15
[ ] macOS 15 Arm64
[ ] Windows Server 2019
[ ] Windows Server 2022

Image version and build link
Agent version <IP_ADDRESS>
OS version Ubuntu 24.04
Is it regression?
Yes, 22.04 is fine
Expected behavior
I expect the agents to scale up when using the image based on Ubuntu 24.04.
As it works for Ubuntu 22.04 image
Actual behavior
found similar github post https://github.com/microsoft/azure-pipelines-agent/issues/5012#issuecomment-2421014643
is there any issues with ado pipeline agent ?
Repro steps
1.Run GenerateResoureandImage
2.Run Packer
3.Update RG to the new image created
4. Create a new agent pool in ADO based on the subscription and VMSS pool
5. Run the pipeline to new pool

Hi @tumm0283,  Thank you for bringing this issue to our attention. We are looking into this issue and will update you on this issue after investigating.

HI @tumm0283 ,
it seems the issue with agent , i request you to kindly raise an issue with the below repo .

Hi @tumm0283 ,
we're closing this issue as it is not belongs to runner images , Thank you ! .


ABAPGit repo - all files constantly modified

Hi,
Not sure if that is the cause, but on a non-unicode system all the files keep the status 'modified' even after a pull. The difference highlighted is a hashtag (#) on the remote repo in the first line of the xml.

it is most likely a byte order mark, see https://github.com/larshp/abapGit/issues/799

I will take a look, thanks.
M.

I've found no solution to prevent BOM on a unicode system.
So I delete the BOM afterwards:

After the first small tests, this seems to work between unicode and non unicode systems.

I am using abapGit on a non-unicode system facing the same issue. alle files are constantly shown as modified. Is there a solution general for this problem? I would also be happy about a fix that I can implement in my fork.

"I think we should change the code so abapGit does not add byte order marks to any of the xml files"
however it will probably cause a lot of changed files in the ecosystem, so perhaps hide it behind a setting as a starting point

or perhaps its less invasive to always add it, hmm

I'll do the change to always add the byte order mark, this is the least invasive on the ecosystem

@BlackmanCC can you help testing https://github.com/larshp/abapGit/pull/2947 ?

Sure, I can test it. Today will be difficult, because I am on the way to TechEd, but I will have some time the next days.

The changes of #2947 adding the BOM seem to work. In the diff screen there are no changes shown anymore.  The problem is, that even after updating local checksums, all files are shown as modified.
Maybe it is the same problem as in #2124.
I suppose that it has to do with calculation of the checksums for local objects that could be different in non-unicode systems . What do you think?

seems like something is missing somewhere, the screenshots did not show the expected behavior

I would really like to solve the problem but do not know where to look at in debugging and where to start. I only see that the rsa1 checksums of local and remote are different even the coding seems to be the same.

btw: We encountered the same problems with our internal git system (Gitblit). The fixes of #2947 adding the bom solved the problems for us for the internal system.

@BlackmanCC thanks, but now we have unicode systems.

will close the issue, fix merged in https://github.com/larshp/abapGit/pull/3167


v0.3.1

Mostly bug fixes for things that weren't caught in v0.3.0
Do the following before requesting a review

[x] I have written tests covering functions I have added or changed.
[x] I have run tests and they all pass.
[x] I have ensured all new functions will show up in the _pkgdown.yml file.
[x] I have updated DESCRIPTION with any new package dependencies.
[x] I have updated NEWS.md with a brief description of my changes.
[x] I have updated the package documentation with devtools::document().
[x] I have updated the package website with pkgdown::build_site_github_pages().

Bump @elyse-22 @JackBuckley


"Only the best rank" in "Add columns from reconciled columns" should not output deprecated values

In "Add columns from reconciled columns", you can configure settings to get "Only the best rank". At least in some cases, though, this will also output deprecated values, if none other are available.
From Wikidata: https://www.wikidata.org/wiki/Help:Ranking: A statement with best rank is a statement with preferred rank, if there is none: a statement with normal rank.
To Reproduce
Steps to reproduce the behavior:

Add table with Q58633433 in the first column and reconcile it to Wikidata.
Add columns from reconciled columns with P691
OpenRefine will output a value for Q58633433 even though this value is deprecated.

Using OpenRefine 3.5.2.

Thanks for the report! Transferring it to https://github.com/wetneb/openrefine-wikibase/issues/133


Delete if (node.attr) in getDateAttr(node)

this.render = function(nodes, locale) {
  if (nodes.length === undefined) nodes = [nodes];
  for (var i = 0; i < nodes.length; i++) {
    doRender(nodes[i], getDateAttr(nodes[i]), locale, ++ cnt); // render item
  }
};

When you loop the jQuery objects in for..., the nodes[i] will be the DOM element to the jQuery object
so if (node.attr) return node.attr(ATTR_DATETIME); will never be executed even you pass jQuery objects.
Best wishes.

So I can not use JQ dom object ?

@hustcc I mean even you use JQ dom object, if (node.attr) will not be executed.
This if statement will never be executed.

I has done a testcase, you are right, thank you very much.


Warnings  C4715 and C4127 when building json-3.9.1 with Visual Studio 2019 16.7.7

I get the following warnings when building json-3.9.1 with Visual Studio 2019 16.7.7:
single_include\nlohmann\json.hpp(4697): warning C4715: 'nlohmann::detail::hash<nlohmann::basic_json<std::map,std::vector,std::basic_string<char,std::char_traits<char>,std::allocator<char> >,bool,__int64,unsigned __int64,double,std::al
locator,nlohmann::adl_serializer,std::vector<unsigned char,std::allocator<unsigned char> > > >': not all control paths return a value

test\src\unit-json_pointer.cpp(362,78): warning C4127: conditional expression is constant

Please describe the steps to reproduce the issue.

Download json-3.9.1.zip and unzip
Open a Developer command Prompt v16.7.7
cd json-3.9.1
Create directory build and cd build
cmake ..\ -D JSON_Install:BOOL=OFF -D JSON_ImplicitConversions:BOOL=OFF -D JSON_BuildTests:BOOL=ON
cmake --build .

What is the expected behavior?
No warnings
And what is the actual behavior instead?
Warnings
Which compiler and operating system are you using?

Compiler:  Visual Studio 2019 16.7.7 Professional
Operating system:  Windows 10 2004 Pro German

Which version of the library did you use?

[X] latest release version 3.9.1

Warning
single_include\nlohmann\json.hpp(4697): warning C4715: 'nlohmann::detail::hash<nlohmann::basic_json<std::map,std::vector,std::basic_string<char,std::char_traits<char>,std::allocator<char> >,bool,__int64,unsigned __int64,double,std::al
locator,nlohmann::adl_serializer,std::vector<unsigned char,std::allocator<unsigned char> > > >': not all control paths return a value

seems to be a false positive, because function hash(const BasicJsonType& j) uses a an exhaustive switch statement where all reachable branches return a value. The default branch consists of an assert(false) call which, if it would be reachable, does not leave the function, but abort.
Warning
test\src\unit-json_pointer.cpp(362,78): warning C4127: conditional expression is constant

seems to be a false positive. json::size_type is std::size_t whose size is implementation-defined, but at least 16 bit. unsigned long long is at least 64 bit. So
sizeof(typename json::size_type) < sizeof(unsigned long long)

is true very often, but not necessarily all the time.

Warning
single_include\nlohmann\json.hpp(4697): warning C4715: 'nlohmann::detail::hash<nlohmann::basic_json<std::map,std::vector,std::basic_string<char,std::char_traits<char>,std::allocator<char> >,bool,__int64,unsigned __int64,double,std::al
locator,nlohmann::adl_serializer,std::vector<unsigned char,std::allocator<unsigned char> > > >': not all control paths return a value

seems to be a false positive, because function hash(const BasicJsonType& j) uses a an exhaustive switch statement where all reachable branches return a value. The default branch consists of an assert(false) call which, if it would be reachable, does not leave the function, but abort.
Warning
test\src\unit-json_pointer.cpp(362,78): warning C4127: conditional expression is constant

seems to be a false positive. json::size_type is std::size_t whose size is implementation-defined, but at least 16 bit. unsigned long long is at least 64 bit. So
sizeof(typename json::size_type) < sizeof(unsigned long long)

is true very often, but not necessarily all the time.

I'm not sure how to fix any of the warnings.

I'm not sure how to fix any of the warnings.

sizeof(typename json::size_type) < sizeof(unsigned long long)

can be solved in c++17 with
if constexpr (sizeof(typename json::size_type) < sizeof(unsigned long long))

sizeof(typename json::size_type) < sizeof(unsigned long long)

can be solved in c++17 with
if constexpr (sizeof(typename json::size_type) < sizeof(unsigned long long))

The
default: // LCOV_EXCL_LINE

case does not return anything.

The
default: // LCOV_EXCL_LINE

case does not return anything.

json::size_type is std::size_t whose size is implementation-defined, but at least 16 bit. unsigned long long is at least > 64 bit. So

sizeof(typename json::size_type) < sizeof(unsigned long long)
is true very often, but not necessarily all the time.

MSVC does not warn about the general case but about the case for the architecture being compiled.

json::size_type is std::size_t whose size is implementation-defined, but at least 16 bit. unsigned long long is at least > 64 bit. So

sizeof(typename json::size_type) < sizeof(unsigned long long)
is true very often, but not necessarily all the time.

MSVC does not warn about the general case but about the case for the architecture being compiled.

can be solved in c++17 with
if constexpr (sizeof(typename json::size_type) < sizeof(unsigned long long))

The library targets C++11.

can be solved in c++17 with
if constexpr (sizeof(typename json::size_type) < sizeof(unsigned long long))

The library targets C++11.

The
default: // LCOV_EXCL_LINE

case does not return anything.

That's true, but it also does not leave the function due to the assertion.

The
default: // LCOV_EXCL_LINE

case does not return anything.

That's true, but it also does not leave the function due to the assertion.

If there were a return after the assert we'd probably get an unreachable code warning on it on other compilers.
This may help https://stackoverflow.com/questions/60802864/emulating-gccs-builtin-unreachable-in-visual-studio

If there were a return after the assert we'd probably get an unreachable code warning on it on other compilers.
This may help https://stackoverflow.com/questions/60802864/emulating-gccs-builtin-unreachable-in-visual-studio

This exact case is covered here: https://docs.microsoft.com/en-us/cpp/intrinsics/assume?view=msvc-160&viewFallbackFrom=vs-2019

This exact case is covered here: https://docs.microsoft.com/en-us/cpp/intrinsics/assume?view=msvc-160&viewFallbackFrom=vs-2019

@gregmarr Thanks for the reference! A NODEFAULT macro could be a good addition to the library. Interestingly, we have several other places where we did put a return after an assertion, like
        default:                   // LCOV_EXCL_LINE
            JSON_ASSERT(false);    // LCOV_EXCL_LINE
            return 0;              // LCOV_EXCL_LINE

@gregmarr Thanks for the reference! A NODEFAULT macro could be a good addition to the library. Interestingly, we have several other places where we did put a return after an assertion, like
        default:                   // LCOV_EXCL_LINE
            JSON_ASSERT(false);    // LCOV_EXCL_LINE
            return 0;              // LCOV_EXCL_LINE

If we already have places where we return after an assert and we're not getting errors there, then adding a return in this case seems like a reasonable fix.

If we already have places where we return after an assert and we're not getting errors there, then adding a return in this case seems like a reasonable fix.

The issue with the missing return value is fixed in the devlop branch: https://github.com/nlohmann/json/commit/dd8cb2acc1e38b3dc06fce36b6688c662e59afe2#diff-a9407ccd45e5c9f004f9d81a18c381d0e5ecd782d5a91ec8f64614d3da6a7eaeR8397
I went through the code and did not find a similar issue. I would close this issue unless anyone has an idea what to do with C4127.

The issue with the missing return value is fixed in the devlop branch: https://github.com/nlohmann/json/commit/dd8cb2acc1e38b3dc06fce36b6688c662e59afe2#diff-a9407ccd45e5c9f004f9d81a18c381d0e5ecd782d5a91ec8f64614d3da6a7eaeR8397
I went through the code and did not find a similar issue. I would close this issue unless anyone has an idea what to do with C4127.

I went through the code and did not find a similar issue. I would close this issue unless anyone has an idea what to do with C4127.

Globally disabling?

I went through the code and did not find a similar issue. I would close this issue unless anyone has an idea what to do with C4127.

Globally disabling?

I'm not a big fan of that - especially since it seems not to be enabled by default or is it?

I'm not a big fan of that - especially since it seems not to be enabled by default or is it?

Since the example shown is in a test file, I think it would be acceptable to have a pragma in that file to disable the warning.  If it were in the main source, that would be a different story.

Since the example shown is in a test file, I think it would be acceptable to have a pragma in that file to disable the warning.  If it were in the main source, that would be a different story.

diff --git a/test/src/unit-json_pointer.cpp b/test/src/unit-json_pointer.cpp
index 14d8cd183..fc10c6ff5 100644
--- a/test/src/unit-json_pointer.cpp
+++ b/test/src/unit-json_pointer.cpp
@@ -358,6 +358,10 @@ TEST_CASE("JSON pointers")
                 CHECK_THROWS_WITH(j_const[jp] == 1, throw_msg.c_str());
             }

+#if defined(_MSC_VER)
+#pragma warning (push)
+#pragma warning (disable : 4127) // on some machines, the check below is not constant
+#endif
             if (sizeof(typename json::size_type) < sizeof(unsigned long long))
             {
                 auto size_type_max_uul = static_cast<unsigned long long>((std::numeric_limits<json::size_type>::max)());
@@ -371,6 +375,10 @@ TEST_CASE("JSON pointers")
                 CHECK_THROWS_WITH(j_const[jp] == 1, throw_msg.c_str());
             }

+#if defined(_MSC_VER)
+#pragma warning (pop)
+#endif
+
             CHECK_THROWS_AS(j.at("/one"_json_pointer) = 1, json::parse_error&);
             CHECK_THROWS_WITH(j.at("/one"_json_pointer) = 1,
                               "[json.exception.parse_error.109] parse error: array index 'one' is not a number");

@gregmarr @t-b @Andreas-Schniertshauer Is this what you'd have in mind?

diff --git a/test/src/unit-json_pointer.cpp b/test/src/unit-json_pointer.cpp
index 14d8cd183..fc10c6ff5 100644
--- a/test/src/unit-json_pointer.cpp
+++ b/test/src/unit-json_pointer.cpp
@@ -358,6 +358,10 @@ TEST_CASE("JSON pointers")
                 CHECK_THROWS_WITH(j_const[jp] == 1, throw_msg.c_str());
             }

+#if defined(_MSC_VER)
+#pragma warning (push)
+#pragma warning (disable : 4127) // on some machines, the check below is not constant
+#endif
             if (sizeof(typename json::size_type) < sizeof(unsigned long long))
             {
                 auto size_type_max_uul = static_cast<unsigned long long>((std::numeric_limits<json::size_type>::max)());
@@ -371,6 +375,10 @@ TEST_CASE("JSON pointers")
                 CHECK_THROWS_WITH(j_const[jp] == 1, throw_msg.c_str());
             }

+#if defined(_MSC_VER)
+#pragma warning (pop)
+#endif
+
             CHECK_THROWS_AS(j.at("/one"_json_pointer) = 1, json::parse_error&);
             CHECK_THROWS_WITH(j.at("/one"_json_pointer) = 1,
                               "[json.exception.parse_error.109] parse error: array index 'one' is not a number");

@gregmarr @t-b @Andreas-Schniertshauer Is this what you'd have in mind?


Add test of original workflow with minimal changes

I think this is ready @tsalo

Merging this so we can make some progress.

@eurunuela Do you recall where the ground truth data came from? We might want to try re-running the original code if that isn't what was used. Also, after looking at the manual, I think we need to smooth the data as well.


[4.0.x] Fixed #28401 -- Allowed hashlib.md5() calls to work with FIPS…

… kernels.
md5 is not an approved algorithm in FIPS mode, and trying to instantiate
a hashlib.md5() will fail when the system is running in FIPS mode.
md5 is allowed when in a non-security context. There is a plan to add a
keyword parameter (usedforsecurity) to hashlib.md5() to annotate whether
or not the instance is being used in a security context.
In the case where it is not, the instantiation of md5 will be allowed.
See https://bugs.python.org/issue9216 for more details.
Some downstream python versions already support this parameter. To
support these versions, a new encapsulation of md5() has been added.
This encapsulation will pass through the usedforsecurity parameter in
the case where the parameter is supported, and strip it if it is not.
Co-authored-by: Mariusz Felisiak<EMAIL_ADDRESS>Backport of d10c7bfe56f025ccc690721c9f13e7029b777b9c from main

@vakwetu Thanks for this patch :+1: However this doesn't qualify for a backport based on our supported versions policy.


os/exec: No longer possible to pass all inheritable file handles to subprocess on Windows

What version of Go are you using (go version)? 1.17.10
Does this issue reproduce with the latest release? not tested, but there are no recent changes related to this
What operating system and processor architecture are you using (go env)? windows amd64
What did you do?
Spun off from #48393  @alexbrainman
This commit (@zx2c4 ) changed process creation on Windows so that only stdin/stdout/stderr, and the handles listed in AdditionalInheritedHandles, can be inherited by subprocesses.
Unfortunately, this interacts badly with a python wrapper tool we use. This wrapper sets up a virtual environment with all necessary packages, then simply shells out to the Python interpreter.
Some callers rely on being able to pass a file handle (i.e. a pipe) through to the Python script. This works fine if Python is invoked directly, but with this change to the golang implementation, our wrapper no longer passes these handles through to the python subprocess.
As the wrapper has no specific knowledge of the file handles that the caller wants to pass through, we can't just add them to AdditionalInheritedHandles.
What did you expect to see?
It would be nice if we could opt back into the old behavior in some way, using os/exec.
What did you see instead?
There doesn't seem to be a way to go back to the old behavior, other than by making all of the low-level Windows calls in our own code.
Thanks,

@brianryner8 thank you for creating the issue.
Can you please provide a small self runnable example that worked before go 1.17.10 but does not work now?
Thank you.
Alex

The sample in #48393 demonstrates the issue. The only difference for us is that rather than creating the pipe in our Go application, it is passed as an inheritable handle when our Go binary is executed.

The sample in #48393 demonstrates the issue.

I don't see a problem with that code. That code just need to use AdditionalInheritedHandles now. Go 1.17 added AdditionalInheritedHandles, and now everyone have to use it if you want to pass handles between processes.
Alex

Completely setting aside that this change breaks go1compat (which, imo, should be sufficient reason BY ITSELF to change the default behavior back to the previous behavior), the problem in this case is that the Go program here does not know which handles should be propagated and so has no easy way to set AdditionalInheritedHandles.
The flow goes:

parent process (which we don't control), marks some HANDLES as inheritable, and invokes "python" with some python script (which we also don't control).
our Go binary (which is in PATH as "python") does some setup (creation of a virtualenv) and then exec's (or as close ase we can get on Windows) into the real python interpreter.
the python interpreter runs, running the user-controlled python script, which expects the HANDLEs to be set the way the parent process set them.

In Go 1.16, this worked fine. In Go 1.17 we have to resort to duplicating a sizable chunk of exec_windows.go (https://chromium-review.googlesource.com/c/infra/luci/luci-go/+/3739699).
It may be a reasonable compromise to provide a function which the program can call that populates AdditionalInheritedHandles with any Handles that would have been present in the older version (though, again, this goes against go1compat... but at least it wouldn't leave users high and dry).

@riannucci thanks for your comments.

Completely setting aside that this change breaks go1compat

Your program assumed that syscall.StartProcess will pass all inheritable handles to the new process, but I consider that is a bug in Go 1.16. I will let Go team resolve our differences.

the problem in this case is that the Go program here does not know which handles should be propagated and so has no easy way to set AdditionalInheritedHandles.

I agree. Your program design assumes that inheritable handles will by passed to the child process.

In Go 1.16, this worked fine. In Go 1.17 we have to resort to duplicating a sizable chunk of exec_windows.go (https://chromium-review.googlesource.com/c/infra/luci/luci-go/+/3739699).

I am sorry you had to add extra code to your program. But perhaps it is a good enough solution here. You were the first to complain about this change. Perhaps Go need to provide some general solution for users like yourself. I don't know.

It may be a reasonable compromise to provide a function which the program can call that populates AdditionalInheritedHandles with any Handles that would have been present in the older version

I don't know of a way to enumerate all inheritable process handles. Perhaps others have some suggestions.
Alex

@riannucci

Completely setting aside that this change breaks go1compat

There are no guarantees on the syscall package:

It is impossible to guarantee long-term compatibility with operating system interfaces, which are changed by outside parties. The syscall package is therefore outside the purview of the guarantees made here.

It is impossible to guarantee long-term compatibility with operating system interfaces, which are changed by outside parties. The syscall package is therefore outside the purview of the guarantees made here.

While it's certainly true that OS interfaces are changed by outside parties,

it doesn't appear that this change to syscall behavior was prompted by a breaking change to the underlying Windows API
the change surfaces as a behavior change to the os/exec package (i.e. Cmd.Start/Cmd.Run), which would be part of the go1compat guarantee, no?

I'm not aware of any reasonable way to retrieve all the process inherited handles, therefore neither os/exec nor syscall currently provide a way to support the flow described by @riannucci in https://github.com/golang/go/issues/53652#issuecomment-1172988299. IMO this use case is very valid, we should provide a way to enable it.
My proposal is to opt-in to the old behavior, that is having a global lock that guards process creation and don't explicitly specify the list of handles to be inherited by the process. Users could opt-in to this behavior by setting a syscall.SysProcAttr property, named InheritAllInheritableHandles:
type SysProcAttr struct {
        // ...
	NoInheritHandles           bool                // if set, each inheritable handle in the calling process is not inherited by the new process
	AdditionalInheritedHandles []Handle            // a list of additional handles, already marked as inheritable, that will be inherited by the new process
	ParentProcess              Handle              // if non-zero, the new process regards the process given by this handle as its parent process, and AdditionalInheritedHandles, if set, should exist in this parent process
	// New!
	InheritAllInheritableHandles bool // if set and NoInheritHandles is unset, each inheritable handle in the calling process is inherited by the new process
}

I'll submit a new proposal issue as this is adding a new API.


[Doc] Basic documentation needed

Hi,
i recently stumbled upon this cool project and tinkered a little bit with it in order to get it running with docker-compose. I think i succeeded in that and wrote some basic docs here https://github.com/fleischsalatinspace/waitlist/tree/add-docker-compose, but it was a bit of a hit and miss without documentation, especially regarding the sse-server. Do you plan on writing some docs? i know this is some kind of "private" project. Do you accept PRs?
Also would be interesting to know how you run this in production? k8?
Anyway thank you for this cool project

Hey! I'm the current maintainer of this project and I run it on behalf of the TDF incursion community.
I have no plans to add some myself but would 100% welcome a PR contributing some and would be happy to provide timely reviews.
Can also sync on discord if you join the TDF discord and give "Lia Yahzri" a poke, PMs are enabled.

Ok. I'll work on my fork and when its in a working state, i'll create a pr


Applicant - "Choose one of the following..." or similar as default value for dropdowns

Description
Dropdown menus could easily be skipped for users with assistive technologies by having an accepted value as the default.
Suggest adding "Choose one of the following..." or similar as a default value for dropdown menus.
Required for Completion
Add/remove others as necessary for this specific task.

[ ] Run Lighthouse (Chrome Dev Tools)
[ ] Run WAVE Evaluation
[ ] Browser Compatibility Check
[ ] Update Translation Spreadsheet
[ ] Does this affect configuration? (If so discuss with team)
[ ] Create pull request to dev
[ ] Address issues found during peer review
[ ] Have someone else accept pull request into dev

Notes from Chris:
So our "quick fix" of adding required to the required select elements prevents the other forms on the page from submitting correctly because they're all technically the same form
Our "long fix" of adding appropriate form validation loses the user's input when validation fails
Our "extra long fix" of converting the whole thing to ajax submissions hasn't been done yet

Many <select> elements don't have validation, or adding front-end validation breaks back-end functionality. So this turned out to be a larger task than anticipated.
As far as I'm aware:

skills, references and work samples are good

first page of application has validation

degrees, courses, experience need work

probably some parts of the manager side as well

Fixed up issues with Composer packages, I believe this is good to go
https://github.com/GCTC-NTGC/TalentCloud/pull/658

Resolved by #804


Create topics/data/index.md

Please confirm this pull request meets the following requirements:

[x] I followed the contributing guidelines: https://github.com/github/explore/blob/main/CONTRIBUTING.md.
[x] I have no affiliation with the project I am suggesting (as a maintainer, creator, contractor, or employee).

Which change are you proposing?

[x] Curating a new topic or collection

Curating a new topic or collection

[x] I've formatted my changes as a new folder directory, named for the topic or collection as it appears in the URL on GitHub (e.g. https://github.com/topics/[NAME] or https://github.com/collections/[NAME])
[x] My folder contains a *.png image (if applicable) and index.md
[x] All required fields in my index.md conform to the Style Guide and API docs: https://github.com/github/explore/tree/main/docs

11,195 public repositories, no description, a popular topic.

Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.

Need some help...
  1) Failure:
collections::made-in-italy collection#test_0013_fails if a user, organization, or repository has been renamed or removed [/home/runner/work/explore/explore/test/collections_test.rb:197]:
Expected ["made-in-italy: federico-terzi/espanso has been renamed to espanso/espanso"] to be empty.
1050 runs, 2608 assertions, 1 failures, 0 errors, 0 skips
Error: made-in-italy: federico-terzi/espanso has been renamed to espanso/espanso

Thanks!


Fix/misc small fixes

Demo should pull in Roboto/Sanchez
Components should be able to resolve icons.svg using same global config prop

Note: Icons appear in production build, but not in local. Worth creating an issue to fix config.


Updated readme

It is required that all of the below requirements are met for this pull request to be merged.

[ ] I have starred the repository :star:
[ ] I have added my details to the contributor list.
[ ] I have followed the example while adding myself as contributor

Refers #1

@tharindubasnnayaka thanks for the PR, please make sure all the checkboxes are checked so that this PR could be merged.


integrate Jamie's percentogram and other visualization tools in Squigglepy or a different standalone plotting lib

https://statmodeling.stat.columbia.edu/2023/04/13/the-percentogram-a-histogram-binned-by-percentages-of-the-cumulative-distribution-rather-than-using-fixed-bin-widths/
Unfortunately these are in R so they'd have to be ported to Python
Context: Jamie works at Rethink Priorities

Code: https://github.com/Jimbilben/jimbilben/blob/master/R/make_percentogram_x.R


#219 set license expression

Set license expression on package
Closes #219

Thanks for this @thompson-tomo. Could you also bump the version and update the version as well? Unfortunately, the other change was already released at https://www.nuget.org/packages/Microsoft.Kiota.Abstractions/1.8.2


Window compile

Hello,
I just found your idea, it is interesting to Grbl .
I tested quickly on :

'Vista Pro',
'Code::Block svn1816',
and 'Qt5.6 Gnu Gcc 4.62 compiler',

I had to add the definition of ' M_PI ' in ' gsharp_program.h ' to compile the library.
'Example.cpp' generates correctly 'g#2g.exe'. I tested both file 'ngc ' delivery: that's okay.
I do not have time to do more.
Do you have a 'gtest.cbp' ?
Good job.
Cordially.

Thanks for testing it on Windows machine!  I really tried to address the shortage of standard Fanuc / LinuxCNC macro-programming capabilities in grbl controllers. Hopefully it can be useful.
M_PI should come from , but it may be different on Win version. I will add #ifndef.
Also good to know that it runs on lower than 4.8 GCC version. I will update the readme.
I will create "gtest.cbp", no worries, but compilation is very simple, doesn't even require Makefile. Readme file in "gtest" directory explains it well.
Thanks again,
NR

Thanks for testing it on Windows machine!
I really tried to address the shortage of standard Fanuc / LinuxCNC macro-programming capabilities in grbl controllers. Hopefully it can be useful.
M_PI should come from "cmath", but it may be different on Win version. I will add #ifndef.
Also good to know that it runs on lower than 4.8 GCC version. I will update the readme.
I will create "gtest.cbp", no worries, but compilation is very simple, doesn't even require Makefile. Readme file in "gtest" directory explains it well.
Thanks again,
NR

Hello,
For Gcc :  'Qt5.6 Gnu Gcc 4.92 compiler' !! Its'a typo.
Bye.


CUDA error: no kernel image is available for execution on the device

Hi,
I get the following error when using Cuda as device at
inference = SNPE(prior, density_estimator, device)

RuntimeError: CUDA error: no kernel image is available for execution on the device
CUDA kernel errors might be asynchronously reported at some other API call,so the stacktrace below might be incorrect.
For debugging consider passing CUDA_LAUNCH_BLOCKING=1.

nvidia-smi
Thu Dec  9 16:39:45 2021
+-----------------------------------------------------------------------------+
| NVIDIA-SMI 460.91.03    Driver Version: 460.91.03    CUDA Version: 11.2     |
|-------------------------------+----------------------+----------------------+

I am using Ubuntu 20.04,
torch : '1.10.0+cu102'
sbi: '0.17.2'
do I need to down version torch, Cuda version or something else?
>>> torch.cuda.is_available()
True

Also tried to install lower version:
pip3 install torch==1.9.1+cu102 torchvision==0.10.1+cu102 torchaudio==0.9.1 -f https://download.pytorch.org/whl/torch_stable.html

still have the same error.
trying cu111
pip3 install torch==1.9.1+cu111 torchvision==0.10.1+cu111 torchaudio==0.9.1 -f https://download.pytorch.org/whl/torch_stable.html

AssertionError: Prior (cpu) device must match training device (
            cuda:0). When training on GPU make sure to pass a prior
            initialized on the GPU as well, e.g., `prior = torch.distributions.Normal
            (torch.zeros(2, device='cuda'), scale=1.0)`.

I just load any tensors on cuda,  and there is no error anymore.

>>>theta.is_cuda
True
>>>x.is_cuda
True

inference = inference.append_simulations(theta, x)
density_estimator = inference.train()

raise RuntimeError(rte, message)
RuntimeError: (RuntimeError('Expected all tensors to be on the same device, but found at least two devices, cpu and cuda:0! (when checking arugment for argument mat1 in method wrapper_addmm)'), '')


Add 24 hour time formatting example

Added example for how to format 24 hour time without AM/PM

@pmacn : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@pmacn Thank you for this addition. We'll get this published. #sign-off


fix(ui): improve channel list search and filter

Description:
Refactor the channels reducer so that we reuse selectors as much as possible, and augment channels with additional metadata used for display purposes.
Motivation and Context:
Fix #1244
Fix #847
How Has This Been Tested?
Manually - give the network pane a good run for its money.
Types of changes:
Bug fixes.
Checklist:

[x] My code follows the code style of this project.
[x] I have reviewed and updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes where needed.
[x] All new and existing tests passed.
[x] My commits have been squashed into a concise set of changes.

I've updated some of these items @korhaliv and left some comments on others that I didn't feel right to address here.


Adopt and update to reqwest 0.9.x mainly to support latest OpenSSL versions

Hi, I just updated from reqwest 0.8.x to 0.9.x to be able compile sofa in my dev environment running on Ubuntu 18.04 LTS and Arch Linux without any issues regarding the version of the OpenSSL library. Please review my code changes. I'm not so familiar with Rust yet. Thank you. Kind regaards, Tobias

Dear OtaK, would you like to merge my pull request to sofa or are there any issues with it? Take care. Tobias

Hi @OtaK , I am hitting this issue and it is a bit of a blocker for us. Could we get it merged and 0.6.1 released if there is no problem with it?
It would be great!


drivers: ethernet: adin2111: fix generic spi frame reception

Fixes a bug introduced in https://github.com/zephyrproject-rtos/zephyr/commit/06df4b5ae956f38e0175da721e8fc8f9ceb70db9#diff-859cca15b29dc1d7847b3bc4f9c79ddf4e1c80c65606d866429e613ecb1017a3L500 that results in double RX buffer read from ADIN when generic SPI protocol is used.
For every correct ethernet frame the Pn_RX_RDY continues to be asserted one more time. However, the second read results in a bad frame that consists of first frame leftovers (that we fail to read fully) and garbage.
The bug is easy to check by enabling:
CONFIG_NET_LOG=y
CONFIG_ETHERNET_LOG_LEVEL_DBG=y
CONFIG_NET_L2_ETHERNET_LOG_LEVEL_DBG=y

and observing something like:
[00:00:03.543,000] <dbg> net_ethernet: ethernet_recv: (rx_q[0]): Unknown hdr type 0x3271 iface 1

To fix the issue, we must read the whole frame in one SPI transaction. The actual frame size is RX_FSIZE - FRAME_HEADER.
The fix for "Still some length to go 2" is preserved. (https://github.com/zephyrproject-rtos/zephyr/commit/06df4b5ae956f38e0175da721e8fc8f9ceb70db9#diff-859cca15b29dc1d7847b3bc4f9c79ddf4e1c80c65606d866429e613ecb1017a3). We drop the CRC32 bytes from the frame prior allocation and passing that pkt to the network stack.
@spectrum70

Unrelated tests fail (wifi).

Hi @GeorgeCGV ,
thanks for the fix, i couldn't catch it over testing, looks like it was not a functional issue for the whole transfer, but likely impacting on the performance, since the 2 bytes was read later on. Am i correct ?

@spectrum70 it worked fine but resulted in a reception of 2 frames. For some reason, the second read of FSIZE returned the same frame size as the first read... instead of returning "frame bytes left". However, reading the buffer with the previous FSIZE results in a corrupt frame with leftovers from the first frame + garbage that spans the entire frame size.
For example, if the ADIN receives a frame of size 64, read FSIZE would be 66 (64 + 2)  we read 58 (64-2-4). The ADIN keeps RX asserted as there are 4 FEC bytes we didn't read (due to - sizeof(uint32_t)). The next read of FSIZE still returns 66. That leads to an incorrect second frame.
From the user perspective that results in at least a performance hit. There is probably a door to craft a frame so that the net stack doesn't discard it on L2 due to an unknown header type; then the consequences might be bigger.

understood. Thanks for the fix.
Reviewed by: Angelo Dureghello<EMAIL_ADDRESS>


Am I configuring mail correctly?

Am I configuring mail correctly?

Your YAML seems not aligned correctly, refer to my comments at the end of #512 for an example of what helped me. Hope that helps.

Look at the log, copy other people's mail configuration


Str::kebab return wrong kebab-case if string has number

Laravel Version: 9.45.1
PHP Version: 8.1.0
Database Driver & Version:

Description:
See title
Steps To Reproduce:

Pass string with number to the Str::kebab

Workaround:
$str = 'string with 1 number';
echo(Str::kebab($str)); // string-with1-number

There must be a correct kebab-case "string-with-1-number"

It seems we have no intention of changing this behavior ourselves, sorry.


Generate checksums for kam binaries

What type of PR is this?
/kind enhancement
What does this PR do / why we need it:
Generate SHA 256 checksums for KAM binaries. Users could verify if the downloaded binary has the same SHA as the release artifact.
Have you updated the necessary documentation?

[ ] Documentation update is required by this PR.
[ ] Documentation has been updated.

Which issue(s) this PR fixes:
Fixes #307
How to test changes / Special notes to the reviewer:

Build and run the kam image and verify if the checksum is generated

docker build -f Dockerfile.serve -t quay.io/cbanavik/kam .
docker run -p 8080:8080 quay.io/cbanavik/kam

Download the kam binary and generate the checksum for the downloaded binary

sha256sum kam_linux_amd64

Verify if the downloaded binary has the same SHA

/lgtm
/approve


Fixed prev_index declaration in order to comply with JS strict mode.

Proposed changes
Fixes a violation of JS strict mode. Especially, fixes the following error that appears when the lib is bundled within an iife that contains 'use strict':
Uncaught ReferenceError: prev_index is not defined
    at HTMLUListElement.<anonymous> (bundle.js:13569)
    at Function.each (bundle.js:365)
    at jQuery.fn.init.each (bundle.js:160)
    at jQuery.fn.init.init (bundle.js:13552)
    at jQuery.fn.init.$.fn.tabs (bundle.js:13773)

Types of changes

[x] Bug fix (non-breaking change which fixes an issue).
[ ] New feature (non-breaking change which adds functionality).
[ ] Breaking change (fix or feature that would cause existing functionality to change).

Checklist:

[x] I have read the CONTRIBUTING document.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.

👍

nice


Decode unicode chars in pygments files iff necessary

Purpose
Closes https://github.com/CenterForOpenScience/osf.io/issues/2389
Changes

.is_printable() added to check if decoding is necessary
decodes iff necessary

Side Effects
None

MFR should not make any assumptions about the encoding of file content; that is the responsibility of the user of the MFR. Hence, https://github.com/CenterForOpenScience/osf.io/commit/8cd0b05f87c9ce32139196262a95ddae593f029a.


[ncp-buffer] initialize mReadDirection

Fixing Coverity identified issues...

GoogleBot CLA is having issue with my PR...  :)


Open up registration for Summer 2019

Overview
This PR, once merged, will open up applications for 2019.
TODO:

[x] Merge#63
[x] Create google hire opportunity, replace link

Google Hire link: https://hire.withgoogle.com/public/jobs/azaveacom/view/P_AAAAAADAABpEZO0RUIdn-D

@kjjustice that link does not work, can you post an  updated link?

@kjjustice once we publish job in google hire we should be good to go with merging this.


Inconsistent Result Types

After upgrade to latest terraform, some of my user pools are invalid.  I have errors like this:
│ Error: Inconsistent conditional result types
│
│   on .terraform/modules/acme_user_pool/main.tf line 214, in resource "aws_cognito_user_pool_client" "client":
│  214:   for_each = var.module_enabled ? local.clients : {}
│     ├────────────────
│     │ local.clients is object with 2 attributes
│
│ The true result value has the wrong type: attribute types must all match for conversion to map.

If I hotpatch the code to look like this, it fixes this for me.
for_each = var.module_enabled ? local.clients : map(object({}))

I am not sure if there is an error in my configuration or if this is a legitimate fix for this issue.  I can open a PR if needed

hey @wesnick, thank you for reporting this. What Terraform version are you using?

Terraform v1.1.3
on darwin_amd64


Add DOTNET Library Package and Release CI Jobs

Description
DOTNET is a famous libraries distribution ecosystem. Hence, let's add it in. Refer:

https://stackoverflow.com/questions/61662486/can-i-publish-a-nuget-package-without-using-nuget-exe
https://learn.microsoft.com/en-us/nuget/api/package-publish-resource
https://learn.microsoft.com/en-us/nuget/api/overview

Expected Behavior
nupkg can be uploaded easily to either GitHub package or nuget.org.
Current Behavior
nupkg upload is not automated.
Associated Data Files
No response

Still working on this?


WIP: include the Zookeeper source code

Description

The source code is included in the repo, instead of downloading during npm install.
Motivation and Context

When behind a company proxy, the download of the source code can be painfully slow. By including the source code, it will simplify and make the install process faster.

Fixes issue #204
How Has This Been Tested?

Manually running npm install
Travis CI Build Ok.

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

[x] I have read the code of conduct.
[x] I have read the contributing guide.
[x] I have updated the documentation accordingly (if applicable).

My only concern is about understanding the License for Apache ZooKeeper. As I interpret it, including the source code in this repo - and in the npm package - should be fine. I would very much appreciate help and feedback about this specific issue.


SyntaxError: ipython.set_next_input(..)

I have installed ipslides 0.8.7 and ipy 7.27.0.
When I run import ipyslides I get the following error:
File "/usr/local/lib/python3.7/dist-packages/ipyslides/__init__.py", line 36
  ipython.set_next_input(f'{code_after}\n{initial_code}', replace= True)

SyntaxError: invalid syntax

Which IDE you are using? Jupyterlab 3 is optimized at best. Some editors like Google colab do not support writing code by ipython. So you can write code yourself instead of using initialize()
You can do this too
import ipyslides as isd
from ipyslides.utils import write, plt2html, print_context, fmt2cols
from ipyslides.core import  LiveSlides
ls = LiveSlides() # This registers %%slide and %%title magics as bonus

# Note: For LiveSlides('A'), use %%slideA, %%titleA, LiveSlides('B'), use %%slideB, %%titleB
# so that they do not overwite each other's slides.

ls.convert2slides(True) #Set this to True for Slides output
ls.set_footer('Author: Abdul Saboor')
ls.align8center(True) # Set False to align top-left corner

with ls.title():
    write('# Title Page')
with ls.slide(1):
    write('## Bemo Slides')
    display(slides)

for i in range(2,5):
    with ls.slide(i):
        write(f'## Slide {i} Title')

ls.show()

See example slides at Kaggle

I have installed ipslides 0.8.7 and ipy 7.27.0.
When I run import ipyslides I get the following error:
File "/usr/local/lib/python3.7/dist-packages/ipyslides/__init__.py", line 36
  ipython.set_next_input(f'{code_after}\n{initial_code}', replace= True)

SyntaxError: invalid syntax

I did this with ipy 7 in colab and ipy 7.4 in my local machine. Is it some unstable version of ipython that throws error? Let me check with the version you are using

I just checked with versions you used. It's working even in ipython terminal
❯(test_ipy)  ipython
Python 3.7.6 (tags/v3.7.6:43364a7ae0, Dec 19 2019, 00:42:30) [MSC v.1916 64 bit (AMD64)]
Type 'copyright', 'credits' or 'license' for more information
IPython 7.27.0 -- An enhanced Interactive Python. Type '?' for help.

In [1]: import ipyslides as isd

In [2]: isd.__version__
Out[2]: '0.8.7'

In [3]: isd.initialize()
Copy lines below in a cell and execute
 import ipyslides as isd
from ipyslides.utils import write, plt2html, print_context, fmt2cols, details, file2img, file2code, set_dir

from ipyslides.core import  LiveSlides
ls = LiveSlides() # This registers %%slide and %%title magics as bonus

# Note: For LiveSlides('A'), use %%slideA, %%titleA, LiveSlides('B'), use %%slideB, %%titleB
# so that they do not overwite each other's slides.

ls.convert2slides(False) #Set this to True for Slides output
ls.set_footer('Author: Abdul Saboor')
ls.align8center(True) # Set False to align top-left corner

with ls.title():
    write('# Title Page')

for i in range(1,5):
    with ls.slide(i):
        write(f'## Slide {i} Title')

ls.show() #Use this only once in case you use Voila.
#Create slides with %%slide, insert_after now, will be updated on cell run.

In [4]:


[Feature] Use ping instead of a HTTP get request to check for internet connection

📃 Description
This PR uses ping to check for internet connections instead of HTTP get requests.
closes #1484
🪵 Changelog
✏ Changed

use ping instead of http get

@svenvg93 pinging you (pun intended) as this adds a new dependency to the dev image.


Not in npm registry?

npm install circonus-statsd-backend fails since it is not in npm registry

same experience here


Global Key option and TESSEL_AUTH_KEY

As mentioned by @johnnyman727 at https://github.com/tessel/t2-cli/pull/290/files#r39475328 and liked by @wprater at https://github.com/tessel/t2-cli/pull/328/files#r39893445 I am going to make a suggestion how to do by this pull request.
Notes
It was necessary to change a test about update command (assume @rwaldron wants to check this).
Usage
Each command what likes to have a default value for the option('key') would be able to use TESSEL_AUTH_KEY.

@Student007 why did you close this PR?

@johnnyman727  Tests didn't pass. Opened a new one.


Update rapids_version to 23.10

Just updates the rapids_version to 23.10 so we can build integration and docker downstream.

Thanks Ray! 🙏
LGTM. Do we want to indicate the 23.08 release somehow? Like tagging commit ( https://github.com/rapidsai/xgboost-feedstock/commit/7368a266406cd998d6d66bf26eaf6e66f5bbdcc4 )?


[google_maps_flutter] Add feature: onMapTapped callback.

fixed: https://github.com/flutter/flutter/issues/24919
https://github.com/flutter/flutter/issues/26761
https://github.com/flutter/flutter/issues/25439 half request

https://github.com/flutter/plugins/pull/985 has merged. Let me know if this PR still needs to land.


Port Redirect Fix - Only Redirect on Unspecified Port

This will only overwrite the port with the advertised port when otherwise unspecified, changing the default behavior a bit.

How about removing this mandated behavior in favor of a "followPort" option?

I opened https://github.com/stevarino/bedrock-protocol/pull/1 to add a followPort option. Please let me know if you think that sounds good. Thanks!

Merged via #282. Thanks !