Oso package corrupts terminal carriage returns in click prompts

Odd bug here, but I use Oso in my python click CLI app. When using prompts in click, pressing enter key prints a newline (and next prompt on new line), but when oso package is included this gets broken and no linefeed is printed.
`
import click
import oso   # Comment this out to see difference
one = click.prompt('Enter One', type=str, default="one")
two = click.prompt('Enter Two', type=str, default="two")`

Hi @radiantone! I wasn't able to reproduce this with the following environment:

zsh 5.8 (x86_64-apple-darwin17.7.0)
tmux 3.2
iTerm2 3.4.10
macOS 10.15.7
Python 3.9.7

Would you be able to provide similar specs about your environment? It would help us narrow down the issue. Thank you!

Sure. Let me see what my venv has. I'm on Ubuntu 21.04 btw

python 3.9.5
$ stty -a speed 38400 baud; rows 35; columns 205; line = 0; intr = ^C; quit = ^\; erase = ^?; kill = ^U; eof = ^D; eol = M-^?; eol2 = M-^?; swtch = <undef>; start = ^Q; stop = ^S; susp = ^Z; rprnt = ^R; werase = ^W; lnext = ^V; discard = ^O; min = 1; time = 0; -parenb -parodd -cmspar cs8 hupcl -cstopb cread -clocal -crtscts -ignbrk brkint -ignpar -parmrk -inpck -istrip -inlcr -igncr icrnl ixon -ixoff -iuclc ixany imaxbel iutf8 opost -olcuc -ocrnl onlcr -onocr -onlret -ofill -ofdel nl0 cr0 tab0 bs0 vt0 ff0 isig icanon iexten echo echoe echok -echonl -noflsh -xcase -tostop -echoprt echoctl echoke -flusho -extproc
$ echo $TERM
xterm-256color

Here is the console output
`(venv2) darren@phoenix:~/PycharmProjects/pyfi$ cat test.py
import click
import oso
one = click.prompt('Enter One', type=str, default="one")
two = click.prompt('Enter Two', type=str, default="two")
(venv2) darren@phoenix:~/PycharmProjects/pyfi$ vi test.py
(venv2) darren@phoenix:~/PycharmProjects/pyfi$ python test.py
Enter One [one]:
Enter Two [two]:
(venv2) darren@phoenix:~/PycharmProjects/pyfi$ cat test.py
import click
#import oso
one = click.prompt('Enter One', type=str, default="one")
two = click.prompt('Enter Two', type=str, default="two")
(venv2) darren@phoenix:~/PycharmProjects/pyfi$
`

My coworker tried reproducing this with Python 3.9 on Ubuntu and failed, so unfortunately this seems to be down to some finicky environment-specific issue. Our best guess at the moment is that this conditional import of readline is the source of the issue:
https://github.com/osohq/oso/blob/e7e3ba5a9a62805213364441c0202a5dfa14b2ab/languages/python/oso/polar/polar.py#L9-L14
I've created a follow-up task for us to move that conditional import into the repl() method in that same file to see if it fixes your issue (so you might still see the same issue if you tried running the REPL or otherwise called that function, but it wouldn't rear its head every time the polar.py file is loaded by Python).
At some point before our next release (October 20th), we'll make that change and create a wheel for you to try installing.
Alternatively, if you wanted to, you could test out that fix locally by editing your locally installed polar.py file (in the polar package; e.g., in my local venv the file path to the appropriate file is venv/lib/python3.9/site-packages/polar/polar.py).
If you're able to test it out and it fixes your issue, it'd be amazing if you would open a PR with the fix!

Cool. Thanks for looking into guys. Really appreciate that. Will study it more when i return from travel.

Gonna consider this closed until we hear otherwise 🙂


Bug: skill card component on hover flip

It flips and keeps showing the front for a few seconds before showing the back

This bugs shows up more frequently on phones

On an A71 it takes longer to flip if you tap once, it flips almost instantly (in the expected "correct" behavior) if you double tap.


100% Brightness - 39% Brightness?

Hi,
Thanks for the code, working well so far. One problem I’ve noticed, if I inject the following JSON via MQTT, my hue lights switch on, but don’t seem to set the brightness correctly to 100%, I’ve tried with  both 255 or “100%”, but either seems to set the brightness to 39% (in the Home app).
{
    "on": [
        true
    ],
    "transitiontime": [
        0
    ],
    "bri": [
        "100%"
    ]
}

Thanks for any help you can offer.

The problem most likely is because you pass the values in an array, and also the brightness is an number not an string
Try changing the JSON to something like this
{
  "on": true,
  "duration": 0,
  "bri": 100
}

Hi,
Thanks. No difference, I'm afraid. I'm guessing it's something to do with the "bri": 100, which is 39% more or less of 255.
Tried with 255 or 254, or "100%", or 50, but no change, the light/s just come on at 39%. Any other thoughts?

Figured it out, I had a function elsewhere that was setting the msg.payload to 100 not 254. I needed to pass the values as my post above to avoid a 'TypeError: CreateListFromArrayLike called on non-object
' error.
Thanks and apologies for the dumb error.


Understand effects of faulty bitstreams

It would be good to understand what the worst case effect of a faulty bitstream is on real hardware. For example, some of the pips are essentially one hot. What happens if you two hot them?
I think we also noted there might be two places to inject into global clock network? If this is the case, what happens if you drive both of them?
Propose something like measure power consumption, and see if there is an unusual increase. If there is, we should take extra precautions when publishing databases to make sure we don't cause this sort of hardware fault.

@azonenberg - This seems like the type of thing you are interested in.

I can confirm that (at least) with CoolRunner-II, the one-hot muxes are literally pass transistors on a shared wire. I have experimental data to show that yes, you can cause a significant (100x or more) increase in device power consumption if you create an internal bus fight.
In the case of the XC2C32A, shorting all internal routing muxes with a worst-case pattern (50% 0, 50% 1) resulted in power consumption climbing from <1 mA  to 100+ mA. This was fatal to the device (completely unresponsive including to JTAG) after about 20 minutes.
I strongly recommend creation of some kind of DRC pass that checks for these conditions in routing as a final step before bitstream generation.

The cool runner is a very old device. I would suggest we look actually look at new devices.


Update Build Variable Task fails for Primary Artifacts Only mode

VSTS Extension you are using
Update Build Variable Task
Where are you running it?
VSTS
Version of Extension/Task
currently public version
Expected behavior and actual behavior
Getting all kinds of errors which starts with a can't convert to Boolean "1" which continues to spiral into more errors and then finally just fails.  Of course I am expecting the variable to increment like it always has done in the past.  However I noticed a change that was implemented about 5 or 6 days ago and investigated the changes.
Steps to reproduce the problem
If you use the Primary Artifacts instead of All Artifacts you get it series of errors.  It turns out it does not if you go through the All Artifacts.  It turns out that in the PowerShell script where you are passing in a named variable you left the $ on the named variable which I noticed did not have this in the All Artifacts route.  This is near the end of the script where it calls the Update-Build function for the usedefaultcredentials parameter.

I am looking into it now, it appears that for people using the older version of the task the default value for a new parameter is set.

Firstly @SchulzDL thanks for the really good repo instructions. I have added extra tests to my release pipeline to make sure both the all artifacts and primary artifacts are properly tested.
The fix has now been released as 1.3.x


Delete an application in ldap doesn't delete the entry

all attribute and subentries are deleted but there is still the entry in the ldap

Seems to be fixed


Typo "@publication"→"@publication"

Bold with escape characters
https://docs.microsoft.com/sr-latn-RS/sql/relational-databases/replication/security/manage-logins-in-the-publication-access-list?view=sql-server-2014

@hyoshioka0128 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@hyoshioka0128 Thank you!


Proposal: Adding remote Hyper-V Server support

Currently Docker Machine assumes that Hyper-V is on the same host that runs the docker-machine command. In a large enterprise environment deploying docker-machine to every Hyper-V host becomes unsustainable. As docker-machine is using mainly PowerShell commands to create and configure the Boot2Docker Virtual Machine a potential solution can involve using PowerShell remoting command before any other invoke. Additionally, there might be room for invoking PowerShell DSC for Hyper-V?
Curious what others opinions are, might try some options in the following weeks.

I've just run into this problem. Connecting to a remote Hyper-V host would be very useful.

Duplicate https://github.com/docker/machine/issues/2985


[BUG] Not seeing the storybook interface

Description
I tried two approach:

auth0 branding templates show --debug: I see template code been displayed in the commandline, but no popup of a browser at all.
auth0 test login: I got a preview of the login template UI visually, but no storybook configurations.
auth0 branding templates: I got message seems somewhat related to open storybook, but did not tell me anything how to open it properly:

This command will open two windows:

* A browser window with a [Storybook](https://storybook.js.org/) that shows the login page with the page template applied:

![storybook](images/templates-storybook.png)

* The default terminal editor, with the page template code:

![storybook](images/templates-vs-code.png)

You now change the page template code, and the changes will be reflected in the browser window.

Once you close the window, you’ll be asked if you want to save the template. If you answer Yes, the template will be uploaded to your tenant.

Usage:
  auth0 branding templates <operation> [parameters...] [flags]

Available Operations:
  show        Display the custom template for Universal Login
  update      Update the custom template for Universal Login

Flags:
  -h, --help   help for templates

Global Flags:
      --debug           Enable debug mode.
      --force           Skip confirmation.
      --format string   Command output format. Options: json.
      --no-color        Disable colors.
      --no-input        Disable interactivity.
      --tenant string   Specific tenant to use. (default "chenmed-test.us.auth0.com")

Use "auth0 branding templates [command] --help" for more information about a command.

Environment

Please provide the following:

Version of this library used:
auth0 cli version 0.11.3 9daa0c20e749790319a2d2a9eb1f349844b51252
node v14.15.1

Hi @adamchenwei, thanks for raising this. The bug report is incomplete; the template includes a Reproduction section, but it is missing in this issue. Please complete it, and describe clearly the bug. It's not clear if there is a bug at all, as this seems more like a general usage question. For general usage questions, please refer to the Auth0 Community forums.

Closing due to inactivity.


Rich text editor

Something similar to the box I am typing in right now with support for github flavoured markdown

Just realized we already have github flavoured markdown theres just no buttons. closing.

I guess it would be nice to have buttons for that - if you want to reach less technical audiences (or just make it convenient for people who don't want to remember different markup defaults). I'd suggest to re-open unless there's another issue covering this ;)

Yeah, I think a toolbar or even an optional markdown-compatible RTE might be nice. Here are a few to consider:

https://simplemde.com/
https://github.com/fuksito/markdown-toolbar
https://stackedit.io/
https://github.com/OscarGodson/EpicEditor (demo:  https://epiceditor-demos.herokuapp.com/ )

I personally like EpicEditor, which gets out of the way if you're writing something quick/simple, but offers distraction-free full-screen editing with preview if/when you need it. Any thoughts on different options, especially based on prior experience writing lots of stuff in markdown?

Here's a more comprehensive evaluation of the "WYSIWYG" options:
https://docs.google.com/spreadsheets/d/1wrLiZQk3xokl02RjLWEIpTH6cBZYirEnj1yCgCV9SHA/edit#gid=0
I am leaning towards ProseMirror. This would allow us to have a WYSIWYM editor for people who don't like markdown, and a (possibly enhanced) markdown mode for everyone else. It's designed to be hackable and seems very active, though there may be a bit more leg work involved in getting it integrated than with some other options. On the flip side, it seems to be very future-proof.
I'm not fond of the options which combine markdown with formatting -- those seem to be "the worst of both worlds", no real preview and no real simplicity.

RTE branch will land soon, see https://github.com/eloquence/lib.reviews/commit/0de5dada8536f78c7b535dc5a4d7a58f78037545 for a summary of current state.

This is now live; blog post to follow shortly. Some known issues + more will come up, I'm sure -- bug reports welcome!
See rte-component label:
https://github.com/eloquence/lib.reviews/issues?q=is%3Aissue+is%3Aopen+label%3Acomponent-rte


[WIP] drivers: fpga: add support for the Lattice iCE40 series

Several commits

add DT bindings for lattice,ice40-fpga
add fpga_ice40 driver
add test for fpga_ice40 driver
declare ice40 in icev_wireless dts

Need to follow binary blob guidelines for bitstream.h (generated from bitstream.bin).
URL for binary blob docs:
https://docs.zephyrproject.org/latest/contribute/bin_blobs.html
The blob URL can likely be used with the http fetcher.
https://github.com/ICE-V-Wireless/ICE-V-Wireless/commit/b75230299fff12ceb1dfa19f38ca218b9bda8d7b
The binary blob itself is open-source Gateware with build instructions at the same GitHub project url.
https://github.com/ICE-V-Wireless/ICE-V-Wireless
At one point thinking it would be nice to work that into devicetree so that different instances could have different firmware, and then the driver instance could load its own firmware.


NO-TICKET: enable libp2p component by default

This PR reverses the behaviour of which networking component is chosen by default: now libp2p is the default, and users need to set the env var CASPER_ENABLE_LEGACY_NET to enable the old small_network component.

I assume you tested it +1 :)

Yes - I was doing that while CI ran.  Tested both with and without the env var set.

I assume you tested it +1 :)

Yes - I was doing that while CI ran.  Tested both with and without the env var set.

bors merge

bors merge

bors merge

bors merge


AttributeError: 'TaskSet' object has no attribute 'open_image'

I have tested your snippet (provided bellow) on two devices and I received this error:
from torch.utils.data import DataLoader

from continuum import ClassIncremental
from continuum.datasets import MNIST

clloader = ClassIncremental(
    MNIST("my/data/path", download=True),
    increment=1,
    initial_increment=5,
    train=True  # a different loader for test
)

print(f"Number of classes: {clloader.nb_classes}.")
print(f"Number of tasks: {clloader.nb_tasks}.")

for task_id, train_dataset in enumerate(clloader):
    train_dataset, val_dataset = split_train_val(train_dataset)
    train_loader = DataLoader(train_dataset)
    val_loader = DataLoader(val_dataset)

and the error is:
---------------------------------------------------------------------------
AttributeError                            Traceback (most recent call last)
<ipython-input-6-c5312f5c2b3b> in <module>()
      1 for task_id, train_dataset in enumerate(clloader):
----> 2     train_dataset, val_dataset = split_train_val(train_dataset)
      3     train_loader = DataLoader(train_dataset)
      4     val_loader = DataLoader(val_dataset)

/usr/local/lib/python3.6/dist-packages/continuum/task_set.py in split_train_val(dataset, val_split)
    118
    119     x, y = dataset.x, dataset.y
--> 120     train_dataset = TaskSet(x[train_indexes], y[train_indexes], dataset.trsf, dataset.open_image)
    121     val_dataset = TaskSet(x[val_indexes], y[val_indexes], dataset.trsf, dataset.open_image)
    122

AttributeError: 'TaskSet' object has no attribute 'open_image'

May I ask you what is the problem?

I forgot to update the function split_train_val after we did some modification to the TaskSet.
Sorry for the inconvenience, it has been fixed and tests have been created to avoid it to happen again.
You can pull master or update with pypi the library to enjoy the fix.

Worked! Thanks for your quick reply :)).


Do agentless jobs support AzureLoadTest@1 tasks?

I don't see azure load test tasks under the supported list of tasks for agentless. I thought it would be here as it's just an api call to kick off the job and potentially can be long running so it may tie up an agent? If you wish to go agentless do you have to manually call the api to start a load test?

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 95227592-b2a9-62be-59d1-fe8c7f4eae8e
Version Independent ID: abf0c659-ce8c-b187-2784-22ddc061d69f
Content: Jobs in Azure Pipelines and TFS - Azure Pipelines
Content Source: docs/pipelines/process/phases.md
Service: azure-devops-pipelines
Sub-service: azure-devops-pipelines-process
GitHub Login: @juliakm
Microsoft Alias: jukullam

@jdholbrook81 I've confirmed with the product team that agentless jobs don't support AzureLoadTest@1. They suggest that you try using the REST API or an Azure Function. If you'd like to propose that agentless jobs to include support for AzureLoadTest@1, you can create a feature request in our Developer Community.


Next notification push is blocked !

Description
Next notification push is blocked !
Audit Logs / Triggered Rule Numbers
[error] 1216269#1216269: *2294 [client xx.xx.xx.xx] ModSecurity: Access denied with code 403 (phase 1). Matched "Operator `Eq' with parameter `1' against variable `IP:xx.xx.xx.xx_64c0f0d116fb71284a0e1cd2960c6675c0ea9372::::DOS_BLOCK' (Value: `1' ) [file "/etc/nginx/modsec/rules/REQUEST-912-DOS-PROTECTION.conf"] [line "130"] [id "912130"] [rev ""] [msg ""] [data ""] [severity "0"] [ver "OWASP_CRS/3.4.0-dev"] [maturity "0"] [accuracy "0"] [tag "application-multi"] [tag "language-multi"] [tag "platform-multi"] [tag "paranoia-level/1"] [tag "attack-dos"] [tag "OWASP_CRS"] [tag "capec/1000/210/227/469"] [hostname "xx.xx.xx.xx"] [uri "/ocs/v2.php/apps/notifications/api/v2/push"] [unique_id "1638104847"] [ref ""], client: xx.xx.xx.xx , server: xx.xx.xx.org , request: "DELETE /ocs/v2.php/apps/notifications/api/v2/push HTTP/2.0", host: "xx.xx.xx.xx.org"
Your Environment
ubuntu 20.04

CRS version (e.g., v3.2.0):
Paranoia level setting:
ModSecurity version (e.g., 2.9.3):
Web Server and version (e.g., apache 2.4.41):
Operating System and version:

Confirmation
--- REQUEST-903.9003-NEXTCLOUD-EXCLUSION-RULES.conf.old
+++ REQUEST-903.9003-NEXTCLOUD-EXCLUSION-RULES.conf
@@ -495,7 +495,7 @@
Nextcloud uses notifictions to inform the user of important new details.
Allows notifications to be deleted
-SecRule REQUEST_FILENAME "@rx /ocs/v[0-9]+.php/apps/notifications/api/v2/notifications"
+SecRule REQUEST_FILENAME "@rx /ocs/v[0-9]+.php/apps/notifications/api/v2/(?:notifications|push)"
"id:9003701,
phase:1,
pass,\

Hi @kennethlau, thanks for the report.
[ver "OWASP_CRS/3.4.0-dev"]
As a note, it looks like you're using our latest development branch. Please be aware that this changes often and is not stable. If you're looking for our latest stable release, which is appropriate to use in production, for example, then check out our v3.3.2 release.
ModSecurity: Access denied with code 403... [file "/etc/nginx/modsec/rules/REQUEST-912-DOS-PROTECTION.conf"]... [id "912130"]
It looks like your transaction was caught by the CRS DoS rules. Do you have the DoS rule enabled intentionally? They are enabled under the "Anti-Automation / DoS Protection" section of crs-setup.conf.
If you're looking for DoS protection, I would not rely on the CRS to perform this aspect of your security. There are much better places and ways to defend against DoS attacks, e.g. at the firewall level, or using a dedicated appliance.
I hope this helps.

Thanks !

@kennethlau I'm going to close this issue now, but please feel free to reply here again if you need any further help with this.


Login now broken and I know why, but I have no idea how to fix it.

sxm-player version: latest
Python version: 3.9
Operating System: Moode Audio on Raspberry Pi 4

Description
sxm-player -U username -P password login fails.
At the Website, using a browser, Sirius is asking if you want to login by 3 different choices.

Text me a verification code
Email me a verification code
Sign in with my password

There doesn't seem to be a way to choose a default. You get a pop up asking which method every time.
What I Did
Paste the command(s) you ran and the output.
If there was a crash, please include the traceback here.

When I modify the code to print the response message, I get this:
{'messages': [{'message': 'Successful', 'code': 100}, {'message': 'GUP Id Unavailable - New User', 'code': 704}], 'status': 1, 'moduleList': {'modules': [{'moduleArea': 'UserFlow', 'moduleType': 'StandardAuth', 'updateFrequency': 0, 'wallClockRenderTime': '2024-01-19T14:08:47.232+0000', 'clientConfiguration': {'clientDeviceId': 'null'}, 'moduleResponse': {'authenticationData': {'sessionID': '', 'remainingLockoutMinutes': 0, 'remainingLockoutSeconds': 0, 'username': 'REDACTED'}}}]}}
Unfortunately I don't know what was being returned before, but I think the message "GUP ID Unavailable - New User code 704" is not right.
As a beginner, I'm not quite sure how they got the URL for the siriusxm player API but when investigating the siriusXM player's page, it doesn't appear to be the same anymore.

The cookies being returned are also not the same, I cannot see the expected cookies after login either, which are SXMAUTHNEW, AWSALB, and JSESSIONID.  I see an SXMDATA cookie and an SXM-DATA cookie.

I might add, I have a Grace Digital radio that is several years old, has not updated lately, still works using username and password.
Perhaps, modify the code to "identify" as a Grace Digital product? IDK, this is way over my head.

Hey I was going to post the same thing!  I'll close this.


A Facebook/Google/... login plugin

A plugin for authentication via Facebook/Google/...

@aviemzur to better understand your request, since Kong has no GUI interface, how would that work?

closing this due to lack of response

Could be something like using Social Account (Facebook/Google/Github/...) to authenticate the consumer
Then we can use ACL plugins to control access to service
This could be really nice to have this feature


Make testdata repo public

We'll be using it for perf testing, and there isn't anything sensitive in there.

Looks like this has been done?

Oh, I didn't realise.


WorkflowDefinition: Move common code to DTO instead of service

On my goal to move more things to entities or DTO(They are a bit anemic), to make the service it cleaner and easier to understand.

/approve


Update order of package dependencies

The previous order of the dependencies seemed to not get along with wiredep when using it to automatically inject dependencies in a project.
jquery-bridget was being loaded after masonry causing the following error:
TypeError: element.masonry is not a function

Objects in JavaScript are not guaranteed to be ordered. This only exploits an implementation specific detail and can break at any time and already breaks things like bower --save[-dev]. What's actually needed is proper dependency resolution.

Actually this fixes everything for every project i work on I have to rearrange the dependencies my self and I don't see any issues.
It fixes everything every time.


User Retention Feature for Security Release

Fixes #[issue_number]
Reminders

See the README for more details on how to work with the Rancher docs.

Verify if changes pertain to other versions of Rancher. If they do, finalize the edits on one version of the page, then apply the edits to the other versions.

If the pull request is dependent on an upcoming release, remember to add a "MERGE ON RELEASE" label and set the proper milestone.

Description

This ports changes for the current security release and describes the new user retention feature.
Comments

Is doing this through the UI an option or just kubectl?
There is no UI for updating user retention settings and setting user-specific overrides at the moment.

I started only adding feedback to the files under /docs since the same feedback is applicable to other versions.
Also, all versions are missing a sidebar entry.
Is doing this through the UI an option or just kubectl?

@btat There's no UI option for now

There is UI that shows when the user becomes subject to retention though in the user and detail views. We may want to include that. @martyav

@pmatseykanets that might have to be an additional PR if we want to get this one out as close to the actual release as possible. If you have instructions for how to view ready and a sentence or two I can edit, then we can include it in this one.

@martyav Using 2.8.5 or 2.7.14 or higher - "Users & Authentication" -> "Users". There are three new columns available now "Last Login", "Disable After", and "Delete After".

The same fields are also present in the user detail view

Added how to view user settings in the UI


Usage and Health Data Collection database work-around

The Usage and Health Data Collection database is not recommended to have in an Availability Group because you can't install updates. So what happens when you have an Availability Group for the other databases without this database? Can SharePoint run without this database? Will it be recreated on the secondairy replica?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 530a4fe6-b750-c975-8492-c574936b254f
Version Independent ID: 6fccbcbb-4499-51eb-9be4-9260b485add1
Content: Supported high availability and disaster recovery options for SharePoint databases
Content Source: SharePoint/SharePointServer/administration/supported-high-availability-and-disaster-recovery-options-for-sharepoint-databas.md
Service: unspecified
GitHub Login: @bentoncity
Microsoft Alias: stevhord

The Usage and Health Data Collection database can be potentially very large, but the data is transient so there isn't anything to preserve.

Additional info: While this database is transient, if it is removed, the Search Analytics will fail as it is dependent on the Usage database. We don't recommend putting this database in an availability group but instead do the following: Provision the Usage database by the service application deployment on one node. Then back up this database and restore it to all of the other nodes in the Always On clusters, but don't sync the databases.


有关于gpu的日程吗

English !!!!!!!

Please remove this thread, it can be consider as a SPAM.
@zhangxxyz are you suppose everyone can read your Chinese?
请删了这垃圾信息

Please remove this thread, it can be consider as a SPAM.
@zhangxxyz are you suppose everyone can read your Chinese?
请删了这垃圾信息

@justwjx Are u sure that you do not type Chinese?


ScrollController.position listeners aren't called when position.pixels i.e., offset is changed by item dismissed

If I register a listener for position, e.g.,
scrollController.position.addListener(listener_callback);
I expect that listener to be called whenever the position changes (including changes to position.pixels), including if changed by items being dismissed from a ListView that uses this ScrollController.
There's a note here:
https://api.flutter.dev/flutter/widgets/ScrollPosition/pixels.html
"This object notifies its listeners when this value changes (except when the value changes due to correctBy)."
IDK if this is what prevents getting the notification on change for item dismissed.  If so then working as designed but would make this a feature request.  Would like to know when the offset changes (offset = 0 implies we're at the top of a ListView, or all items are in view and the ListView is not scrollable) or some other means of determining if a ListView is scrollable (are all items in view?) and registering for changes to scrollable state.
Steps to reproduce:

Make a ListView with enough items that some are offscreen.
Scroll to the bottom of the ListView
Dismiss items from the bottom of the ListView until all items are visible in the ListView / not scrollable.
Logs on dismissing items show the offset value changing.  But the listener is never being called.

Minimal example:
import 'package:example/ScrollablePage.dart';
import 'package:flutter/material.dart';
import 'package:flutter/rendering.dart';

class ListWidget extends StatefulWidget {
  final List<String> data;

  ListWidget(this.data) : super();

  @override
  ListWidgetState createState() => ListWidgetState(data);
}

class ListWidgetState extends State<ListWidget> with ScrollablePage{
  List<String> _data;

  ListWidgetState(this._data) {
    WidgetsBinding.instance.addPostFrameCallback((timeStamp) {initScrollablePage();});
  }

  @override
  void rebuildOnScroll(){
    setState(() {});
  }

  @override
  Widget build(BuildContext context) {
    return Scaffold(
        body: Container(
          color: Colors.grey[900],
            child: ListView.builder(
              controller: scrollController,
              itemCount: _data.length,
              itemBuilder: (context, i) {
                return _buildRow(_data[i]);
              },
            ),
          ),
        );
  }

  Future<bool> _checkDismissDirection(DismissDirection direction) async{
    return direction == DismissDirection.endToStart;
  }

  Widget _buildRow(String s){
    return Dismissible(
      direction: DismissDirection.horizontal,
      key: Key(UniqueKey().toString()),
      confirmDismiss: (DismissDirection direction) => _checkDismissDirection(direction),
      onDismissed: (direction) {
        print("ListWidgetState::onDismissed() -- offset = ${scrollController.offset}");
        setState(() {
          _data.remove(s);
        });
      },
      child: Container(
        color: Colors.grey[800],
        padding: const EdgeInsets.all(8.0),
        child: ListTile(
          title: Text(s),
        ),
      ),
    );
  }

}

import 'package:flutter/material.dart';

mixin ScrollablePage {
  //
  // When using this mixin you need to:
  // > initially call initScrollablePage() to add the listener.
  // > provide an implementation for rebuildOnScroll()
  // > use this scrollController in widgets that take a ScrollController.
  //
  ScrollController scrollController = ScrollController();

  void initScrollablePage() {
    print("initScrollablePage() -- 1");
    if(scrollController.hasClients) {
      print("initScrollablePage() -- 2");
      scrollController.position.addListener(_onScrollControllerOffsetChange);
    }else{
      print("initScrollablePage() -- 3");
    }
  }

  void _onScrollControllerOffsetChange(){
    print("_onScrollControllerOffsetChange() -- offset = ${scrollController.offset}");
    if(scrollController.offset == 0){
        rebuildOnScroll();
    }
  }

  void rebuildOnScroll(); // provide an implementation that will call setState() to force a rebuild of the page.
}

Notice the offset value changing on latest Master.

log
I/flutter (26099): _onScrollControllerOffsetChange() -- offset = 0.0
I/flutter (26099): _onScrollControllerOffsetChange() -- offset = 8.0
I/flutter (26099): _onScrollControllerOffsetChange() -- offset = 0.0
I/flutter (26099): _onScrollControllerOffsetChange() -- offset = 8.0
I/flutter (26099): _onScrollControllerOffsetChange() -- offset = 4.658138304153274
I/flutter (26099): _onScrollControllerOffsetChange() -- offset = 1.9665350485466542
I/flutter (26099): _onScrollControllerOffsetChange() -- offset = 0.0
I/flutter (26099): _onScrollControllerOffsetChange() -- offset = 6.895460234777373
I/flutter (26099): _onScrollControllerOffsetChange() -- offset = 8.0
I/flutter (26099): _onScrollControllerOffsetChange() -- offset = 5.547378899165428
I/flutter (26099): _onScrollControllerOffsetChange() -- offset = 3.6819473513919174
I/flutter (26099): _onScrollControllerOffsetChange() -- offset = 2.3199223228026096
I/flutter (26099): _onScrollControllerOffsetChange() -- offset = 1.3777472222468194
I/flutter (26099): _onScrollControllerOffsetChange() -- offset = 0.7715836251485486
I/flutter (26099): _onScrollControllerOffsetChange() -- offset = 0.41778467746823544
I/flutter (26099): _onScrollControllerOffsetChange() -- offset = 0.2325822210839119
I/flutter (26099): _onScrollControllerOffsetChange() -- offset = 0.13227913193682728
I/flutter (26099): _onScrollControllerOffsetChange() -- offset = 0.05434227342720899
I/flutter (26099): _onScrollControllerOffsetChange() -- offset = 0.0

flutter doctor -v
[✓] Flutter (Channel master, 1.23.0-8.0.pre.221, on Mac OS X 10.15.4 19E2269
    x86_64, locale en-IN)
    • Flutter version 1.23.0-8.0.pre.221 at
      /Users/dhs/documents/Fluttersdk/flutter
    • Framework revision 0d8d4f77aa (23 hours ago), 2020-10-08 09:26:30 +0200
    • Engine revision 2eac514f26
    • Dart version 2.11.0 (build 2.11.0-186.0.dev)

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.0)
    • Android SDK at /Users/dhs/Library/Android/sdk
    • Platform android-30, build-tools 30.0.0
    • Java binary at: /Applications/Android
      Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build
      1.8.0_242-release-1644-b3-6222593)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 12.0.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 12.0.1, Build version 12A7300
    • CocoaPods version 1.9.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.0)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 46.0.2
    • Dart plugin version 193.7361
    • Java version OpenJDK Runtime Environment (build
      1.8.0_242-release-1644-b3-6222593)

[✓] VS Code (version 1.49.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.11.0

[✓] Connected device (4 available)
    • SM A260G (mobile) • 5200763ebcfa861f • android-arm    • Android 8.1.0 (API
      27)
    • macOS (desktop)   • macos            • darwin-x64     • Mac OS X 10.15.4
      19E2269 x86_64
    • Web Server (web)  • web-server       • web-javascript • Flutter Tools
    • Chrome (web)      • chrome           • web-javascript • Google Chrome
      86.0.4240.75

• No issues found!

I don't see the offset value changing but I'm on Stable, not Master.  Will test on master - based on your flutter doctor, looks fixed.
flutter doctor:
/home/vann/development/flutter/bin/flutter doctor --verbose
[✓] Flutter (Channel stable, 1.22.1, on Linux, locale en_US.UTF-8)
    • Flutter version 1.22.1 at /home/vann/development/flutter
    • Framework revision f30b7f4db9 (22 hours ago), 2020-10-08 10:06:30 -0700
    • Engine revision 75bef9f6c8
    • Dart version 2.10.1

[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.2)
    • Android SDK at /home/vann/Android/Sdk
    • Platform android-29, build-tools 29.0.2
    • Java binary at: /opt/android-studio/jre/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6222593)
    • All Android licenses accepted.

[✓] Android Studio (version 4.0)
    • Android Studio at /opt/android-studio
    • Flutter plugin version 50.0.1
    • Dart plugin version 193.7547
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6222593)

[✓] Connected device (1 available)
    • SM G930V (mobile) • dd6076f2 • android-arm64 • Android 8.0.0 (API 26)

• No issues found!
Process finished with exit code 0

Not seeing this fixed on master.
flutter doctor:
/home/vann/development/flutter/bin/flutter doctor --verbose
[✓] Flutter (Channel master, 1.23.0-8.0.pre.255, on Linux, locale en_US.UTF-8)
    • Flutter version 1.23.0-8.0.pre.255 at /home/vann/development/flutter
    • Framework revision ee08c2278a (3 hours ago), 2020-10-09 14:11:17 +0200
    • Engine revision 349889833c
    • Dart version 2.11.0 (build 2.11.0-203.0.dev)

[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.2)
    • Android SDK at /home/vann/Android/Sdk
    • Platform android-29, build-tools 29.0.2
    • Java binary at: /opt/android-studio/jre/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6222593)
    • All Android licenses accepted.

[✓] Android Studio (version 4.0)
    • Android Studio at /opt/android-studio
    • Flutter plugin version 50.0.1
    • Dart plugin version 193.7547
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6222593)

[✓] Connected device (1 available)
    • SM G930V (mobile) • dd6076f2 • android-arm64 • Android 8.0.0 (API 26)

• No issues found!
Process finished with exit code 0

log:
I/flutter (27395): ScrollablePage::_onScrollControllerOffsetChange() -- offset = 1642.907298997632
I/flutter (27395): ScrollablePage::_onScrollControllerOffsetChange() -- offset = 1678.1284698072702
I/flutter (27395): ScrollablePage::_onScrollControllerOffsetChange() -- offset = 1712.0685008005648
I/flutter (27395): ScrollablePage::_onScrollControllerOffsetChange() -- offset = 1744.7520885614633
I/flutter (27395): ScrollablePage::_onScrollControllerOffsetChange() -- offset = 1776.2076087179098
I/flutter (27395): ScrollablePage::_onScrollControllerOffsetChange() -- offset = 1806.4557671580271
I/flutter (27395): ScrollablePage::_onScrollControllerOffsetChange() -- offset = 1835.524648347189
I/flutter (27395): ScrollablePage::_onScrollControllerOffsetChange() -- offset = 1863.4385121124337
I/flutter (27395): ScrollablePage::_onScrollControllerOffsetChange() -- offset = 1890.218492318926
I/flutter (27395): ScrollablePage::_onScrollControllerOffsetChange() -- offset = 1896.0
I/flutter (27395): ListWidgetState::onDismissed() -- offset = 1774.5147573521363
I/flutter (27395): ListWidgetState::onDismissed() -- offset = 1657.4261515784078
I/flutter (27395): ListWidgetState::onDismissed() -- offset = 1540.4469108931721
I/flutter (27395): ListWidgetState::onDismissed() -- offset = 1423.4261515784078
I/flutter (27395): ListWidgetState::onDismissed() -- offset = 1306.4261515784078
I/flutter (27395): ListWidgetState::onDismissed() -- offset = 1189.4261515784078
I/flutter (27395): ListWidgetState::onDismissed() -- offset = 1072.4261515784078
I/flutter (27395): ListWidgetState::onDismissed() -- offset =<PHONE_NUMBER>784078
I/flutter (27395): ListWidgetState::onDismissed() -- offset =<PHONE_NUMBER>784078
I/flutter (27395): ListWidgetState::onDismissed() -- offset =<PHONE_NUMBER>784078
I/flutter (27395): ListWidgetState::onDismissed() -- offset =<PHONE_NUMBER>784078
I/flutter (27395): ListWidgetState::onDismissed() -- offset =<PHONE_NUMBER>784078
I/flutter (27395): ListWidgetState::onDismissed() -- offset =<PHONE_NUMBER>784077
I/flutter (27395): ListWidgetState::onDismissed() -- offset =<PHONE_NUMBER>784077
I/flutter (27395): ListWidgetState::onDismissed() -- offset =<PHONE_NUMBER>784077
I/flutter (27395): ListWidgetState::onDismissed() -- offset = 0.0
I/flutter (27395): ListWidgetState::onDismissed() -- offset = 0.0

The scrollController.position listener is called when the offset is changed from scrolling the ListView.  I don't see it called when the offset is changed from dismissing items from the ListView.  When you see the offset value change is it from scrolling or is it from dismissing items?

Likely this behavior is designed, and the pixel changes during the layout stage will not notify consumers
See also https://github.com/flutter/flutter/blob/f30b7f4db9/packages/flutter/lib/src/widgets/scroll_position.dart#L276
Probably we should update the document about ScrollPosition.pixels.

OK, can close as designed.  But then I would change this to a feature request, to have some way of determining if a ListView is scrollable and to be able to register for changes to the scrollable state (including if scrollable state changes due to items being added or dismissed).

Status update
This is the sample code I have been working with to reproduce this issue:
import 'package:flutter/material.dart';

void main() => runApp(MyApp());

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Flutter Demo',
      debugShowCheckedModeBanner: false,
      theme: ThemeData(
        primarySwatch: Colors.blue,
      ),
      home: MyHomePage(title: 'Flutter Demo Home Page'),
    );
  }
}

class MyHomePage extends StatefulWidget {
  final String title;
  MyHomePage({Key? key, required this.title}) : super(key: key);

  @override
  _MyHomePageState createState() => _MyHomePageState();
}

class _MyHomePageState extends State<MyHomePage> {
  var _counter = 0;
  final _counterList = <int>[];

  void _incrementCounter() {
    setState(() {
      _counterList.add(_counter++);
    });
  }

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        title: Text(widget.title),
      ),
      body: Scrollbar(
        child: ListView.builder(
          itemCount: _counterList.length,
          itemBuilder: (context, index) => Container(
            height: 50,
            child: Text('Count $index'),
          ),
        ),
      ),
      floatingActionButton: FloatingActionButton(
        onPressed: _incrementCounter,
        tooltip: 'Increment',
        child: Icon(Icons.add),
      ),
    );
  }
}

I've tried a couple of different ways to solve this, but I keep running into some of the intentional design aspects - like the lazy loading of list items that keeps scrolling efficient.
The closest I've come is by adding a listener to the maxExtent of the scroll position. This can work to inform the scrollbar to update - but only when the maxExtent has changed within the range of the built area. As I add items in this example code and it goes beyond the bounds of the cached extent, the maxExtent is not updated again until we scroll (the offset changes). I haven't tried it with shrink wrapping, it may work fine that way, but I want to be able to provide a solution that does not require choosing a less efficient scrollable.
That's best I've gotten so far, but I'll keep digging on it. If anyone has thoughts they are always welcome. 🙂

@Piinks Hi
Can we introduce a new event (names like ‘MetricsChangeEnent’) that notify the consumer whenever pixels change.

Linking: #82687 may resolve


partial_variables not working with ChatPromptTemplate (langchain v0.1.9)

Checked other resources

[X] I added a very descriptive title to this issue.
[X] I searched the LangChain documentation with the integrated search.
[X] I used the GitHub search to find a similar question and didn't find it.
[X] I am sure that this is a bug in LangChain rather than my code.

Example Code
   async def partial_test(self):
        prompt_template = "Tell me details about {name}. The output should be in {lang}"
        llm = LLMSelector(self.model).get_language_model()
        prompt = ChatPromptTemplate.from_messages([
            HumanMessagePromptTemplate.from_template(prompt_template, partial_variables={"lang": "Spanish"}),
        ])
        chain = prompt | llm | StrOutputParser()
        result = await chain.ainvoke({'name': 'Open AI'})
        print(result)

Error Message and Stack Trace (if applicable)
Errror: Input to ChatPromptTemplate is missing variables {'lang'}.  Expected: ['lang', 'name'] Received: ['name']\"
Description
But this works with PromptTemplate also work with ChatPromptTemplate in previous version
System Info
langchain v0.1.7

@hasansustcse13 Can you please tell what LLMSelector is, as in where are you importing it from?

This is an internal class. Just replace it with any chat model (ChatOpenAI)
llm  = ChatOpenAI(model="gpt-4", openai_api_key="key")

great catch, thank you for flagging @hasansustcse13! as a workaround while we fix, the following should still work (and is hopefully a bit simpler)
from langchain_core.prompts import ChatPromptTemplate

prompt_template = "Tell me details about {name}. The output should be in {lang}"
prompt = ChatPromptTemplate.from_messages([("human", prompt_template)])
prompt = prompt.partial(lang="Spanish")
prompt.invoke({"name": "foo"})

@baskaryan Thanks for the workaround. I know there are couple of workaround for the problem. The problem is that I have to change in lots of file which I don't want. And I have just demonstrated the bug using simple example. In my case it little bit more complex. Is there any plan to fix this bug in next release? If you share your planning (how to solve it) I can give it a try though I am new to open-source contribution.

Hey @baskaryan
Does this bug still need help? If yes, I would like to contribute (I am a first time contributor). Let me know if it is a good fit for first time contributor and how I can get started :). Thanks
Best,
Rahil

Same case with SystemMessagePromptTemplate.from_template
graph_creator_content = \
"""
Your instructions are:
{instructions}
History:
{history}
"""
graph_analyst_template = SystemMessagePromptTemplate.from_template(template=graph_creator_content,
                                                    input_variables=['history'],
                                                    partial_variables={'instructions': json_prompt_instructions})
graph_analyst_template.format(history='history')

KeyError: 'instructions'

Same case with SystemMessagePromptTemplate.from_template
graph_creator_content = \
"""
Your instructions are:
{instructions}
History:
{history}
"""
graph_analyst_template = SystemMessagePromptTemplate.from_template(template=graph_creator_content,
                                                    input_variables=['history'],
                                                    partial_variables={'instructions': json_prompt_instructions})
graph_analyst_template.format(history='history')

KeyError: 'instructions'

#20711 You can try this.

great catch, thank you for flagging @hasansustcse13! as a workaround while we fix, the following should still work (and is hopefully a bit simpler)
from langchain_core.prompts import ChatPromptTemplate

prompt_template = "Tell me details about {name}. The output should be in {lang}"
prompt = ChatPromptTemplate.from_messages([("human", prompt_template)])
prompt = prompt.partial(lang="Spanish")
prompt.invoke({"name": "foo"})

Where should be used chain object in there?


Composer runtime exception

Initial install composer error.

I just did a commit a minute ago. Do you like to try again. Sorry just type  mistake


UVI Request

--- UVI JSON ---
{
  "vendor_name": "Linux",
  "product_name": "Kernel",
  "product_version": "versions from  to before v5.13.3",
  "vulnerability_type": "unspecified",
  "affected_component": "unspecified",
  "attack_vector": "unspecified",
  "impact": "unspecified",
  "credit": "",
  "references": [
    "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=d1fb12412874c94ad037e11d0ecdd1140a439297"
  ],
  "extended_references": [
    {
      "type": "commit",
      "value": "d1fb12412874c94ad037e11d0ecdd1140a439297",
      "note": "fixed"
    }
  ],
  "reporter": "joshbressers",
  "reporter_id": 1692786,
  "notes": "",
  "description": "atm: iphase: fix possible use-after-free in ia_module_exit()\n\nThis is an automated ID intended to aid in discovery of potential security vulnerabilities. The actual impact and attack plausibility have not yet been proven.\nThis ID is fixed in Linux Kernel version v5.13.3 by commit d1fb12412874c94ad037e11d0ecdd1140a439297. For more details please see the references link."
}
--- UVI JSON ---

This issue has been assigned UVI-2021-1001235


Add embed support for command messages

Right now everything is in plain text, potentially making it into embeds could help with formatting and visual purposes.

Added embed support for getAnime and getCharacter.

Currently just need to polish embed for getAnime and getCharacter, and also implement into all the other commands.

Added.


Mourning's End Part II

In the section Puzzle 5 Part 2, the second instruction says "Have the mirror in the pillar northeast of the dispenser point up." Shouldn't it be the pillar northwest?

Resetting the maze again should probably be mentioned at the start of the Reach the Death Altar section.


SVG class styles are not rendered

Version: 1.0.0-alpha.9
Issue: It seems that classes applied to SVG elements (and their children) are not applied to exported images.
However, if those styles are applied in an inline "style" attribute, they are applied correctly.
I have noticed that font, color, and fill to be problematic.
fiddle: http://jsfiddle.net/patgoins/2d90yop3/
--Examples--
Exported Image:

HTML View:

I have a similar problem but the difference is that the svg content which is spilling out of the svg element is not visible, by default the "user agent stylesheet" says svg overflow hidden, but I have a class to the svg element where I have overwritten the overflow property to "overflow: visible !important;". but still ever though I have tried to apply the overflow property on runtime just before I call the html2canvas(...) function, this doesn't seem to work.

same problem here. firefox and chrome are OK. But safari have this issue.

Please re-open this ticket and implement this workaround into the core library.


feat: add support for .NET SDK V4

Issue #, if available:
DOTNET-7760
Description of changes:
This PR updates the AWS SDK for .NET dependencies to their v4 preview versions.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Could you please onboard this library to the testing infra as well as add the GitHub actions to use AutoVer?


Write integration test for Download Spreadsheet with metadata link info

This should test that linking columns are also in the spreadsheet.

@aaclan-ebi planning on working on this today

Assigning @ke4 @jacobwindsor  as primary code reviewers


Use fixed port in the logsever

https://github.com/newrelic/newrelic-lambda-extension/blob/fcdd844641bb4628154277198c3f12177404ad34/lambda/logserver/logserver.go#L156
If log server starts listening on random port, and Lambda sandbox (function and extensions) is restarted, it can lose logs from the previous invocation or the log server could receive duplicate logs. Using a stable port in the same sandbox will guarantee exactly-once delivery of the logs. It also will reduce the memory utilization in the sandbox.

@luben Thanks for the heads up. Is this behavior documented anywhere? Also, are there any guidelines for port numbers to avoid conflicts with other extensions?

Hi, sorry I missed the question.
You can use any port != 9001. It's documented in https://docs.aws.amazon.com/lambda/latest/dg/runtimes-logs-api.html#runtimes-logs-api-dest
Though this may cause conflict with other extensions. May be try some static port and if the bind fails fall-back to random.
Unfortunately this behaviour around guarantees is not documented.

Static port added in #77.


Ssrf fix

PR Checklist:

[DONE] I have run npm test locally and all tests are passing.
[DONE] I have added/updated tests for any new behavior.
[DONE] If this is a significant change, an issue has already been created where the problem / solution was discussed: [N/A, or add link to issue here]

PR Description
This pull request is a fix to CVE-2023-28155.
It introduces a new configuration option allowInsecureRedirects, turned off by default. The default configuration leaves library users protected from exploiting CVE-2023-28155. When the option gets turned on, the cross-protocol redirects will be allowed if library user decides it's safe and required in their case.

@mikeal @jabrena @mmalecki @eiriksm @reconbot any possibility one of you is available to review and merge this? Our build process is currently broken because of audit failures. Thanks.

Can we expect an updated request release with this fix soon?
If yes, how soon?
Sorry, just trying to figure out how fast we need to move out of request completely.
Thanks.

There were no non-doc/tools changes in the repo since 2018 and no commits at all for the last 3 years.
I wouldn't expect any fix coming from here.
Our own dependency on request came from jsforce (which is not gonna get fixed soon, as it looks like), so we migrated to the still-maintained fork from Cypress via Yarn forced resolutions mechanism, and it worked like a charm.

Yeah... It seems like it's not being maintained/updated anymore a long time.

Thanks.
Yes, I understand that request is not maintained any longer but since there was this PR created and it got reviewed and approved, I though that, may be, something was going to be released.

@khitrenovich CVE-2023-28155 was reported on Mar 16, 2023 and the last commit in fork from Cypress is from Jan 11, 2023. It doesn't look like this has been fixed in their fork :raised_eyebrow:

@khitrenovich CVE-2023-28155 was reported on Mar 16, 2023 and the last commit in fork from Cypress is from Jan 11, 2023. It doesn't look like this has been fixed in their fork 🤨

@suside You are right... Just opened an issue there, let's see how they respond.

@SzymonDrosdzol it might be worth you opening the same CVE against the cypress fork too

is there any alternate library of sforcejs where we do not have dependency on request library ?

Can we expect an updated request release with this fix soon?
If yes, how soon?
Sorry, just trying to figure out how fast we need to move out of request completely.
Thanks.

It would be great if a new version could be released including the fix. I see there was a new version a couple of days ago with the new version of xml2js so I have hope.


POC for uniform app for kustomize plugin and kpt function

Dup with https://github.com/GoogleContainerTools/kpt/issues/646. Close this one.


Incorrect Documentation

According to http://visionmedia.github.com/superagent/ and https://github.com/visionmedia/superagent/blob/master/Readme.md you can use the method data in conjunction with method post. According to the actual code and tests the method is send. The method send worked for me. Otherwise, much better than jQuery Ajax!

yeah i need to go through and redo the docs, lots of stuff missing, we have an issue for this already i think

Ooops, sorry, didn't see that.


sqrt(): return positive and negative values

According to Wikipedia:

In mathematics, a square root of a number a is a number y such that y^2 = a; in other words, a number y whose square (the result of multiplying the number by itself, or y ⋅ y) is a. For example, 4 and −4 are square roots of 16 because 42 = (−4)2 = 16.

To facilitate this, an Operation would be need to handle processing and returning two doubles. Each operation would have to decide if it will operate on the double and possibly filter out double.NaN.
I see this as a major overhaul and a major breaking change, and would require a bump in the major version if following semver.
Once that overhaul is complete, it would be trivial to return new Tuple<double, double>(Math.Sqrt(x), -Math.Sqrt(x)) for the Sqrt function operation. ~Alternatively, a new internal model could be passed around that includes the double result as well as a flag that indicates the next operation should be performed on both the result and the negation of the result.~ Edit: This would not work as the next operation may alter the negation result differently and that information would need to be communicated to further operations and eventually the caller.
Thoughts?

I am not really convinced of the added value of returning back a tuple. It will complixify the use of Jace without bringing sufficient added value.


Accessing prediction results by index whilst providing the model only one image for inference.

💡 My Question:
How do I access the prediction results when running model.predict() on only one image?
I'm trying to access bounding box coordinates of objects detected by YOLO-NAS.
I'm following this tutorial.
Trying to access the predictions using images_predictions[0]   gives me an error when I provide the model with only 1 image for inference.
from super_gradients.common.object_names import Models
from super_gradients.training import models
import torch

model = models.get(Models.YOLO_NAS_L, pretrained_weights="coco")
model = model.to("cuda" if torch.cuda.is_available() else "cpu")

IMAGES = [
    "/content/devices.jpg"
]

images_predictions = model.predict(IMAGES)

print(type(images_predictions[0]))

out: TypeError: 'generator' object is not subscriptable
It works well when I give the model 2 or more images for inference.
from super_gradients.common.object_names import Models
from super_gradients.training import models
import torch

model = models.get(Models.YOLO_NAS_L, pretrained_weights="coco")
model = model.to("cuda" if torch.cuda.is_available() else "cpu")

IMAGES = [
    "/content/devices.jpg",
    "/content/devices.jpg"
]

images_predictions = model.predict(IMAGES)

print(type(images_predictions[0]))

out:  <class 'super_gradients.training.models.prediction_results.ImageDetectionPrediction'>
for reference, this is how I'm trying to access and store the bbox coordinates
detected_objects = []
image_prediction = images_predictions[0]

labels = image_prediction.prediction.labels
confidence = image_prediction.prediction.confidence
bboxes = image_prediction.prediction.bboxes_xyxy

for i, (label, conf, bbox) in enumerate(zip(labels, confidence, bboxes)):
    detected_objects.append(bbox)

Versions
No response

Hi @sobek1886 , this is a known issue (https://github.com/Deci-AI/super-gradients/issues/956).
It was fixed in the master branch (pip install git+https://github.com/Deci-AI/super-gradients) and will be part of the next release :)


Update Readme according to Repo migration

Add instruction to contribute on https://repo.getmonero.org/monero-project/monero-site as the repository has been moved.
Please review @moneromooo-monero & @fluffypony

Corrections done @erciccione


Is this project dead? Please give us a proof of life scanny?

This is a phenomenal project, it would be good to know if it is dead or not, so we can make other arrangements if needed

This library is really nice. 🙏
@scanny I'm also intrigued in knowing if you plan to continue this project. Seems like a lot of people want to help this project continue to grow 🌱

@flubshi I am interested in the development of the project. I use a third of this project in my work. So, I created a fork of the project. Fixed bugs and added features. I still have one function local to change the visibility parameters of objects in the presentation. I will post it soon. https://github.com/sedrew/petpptx/releases/tag/v1.0.2b

@sedrew, in principle I could allow md2pptx to use your fork as the "pptx" engine. I would guess my users could specify whether to try importing your module before falling back on @scanny's. (The default would be not to try to.)
Of course I would have to ensure md2pptx only used additional features if it had successfully imported petpptx. But then there aren't any additional features yet, are there?

@MartinPacker There are not downgrade features in petpptx. Some open PR and Issue-resolve scanyI want to move my project. I have analyzed the forks of other contributions. Some fork provides a feature for adding and deleting columns. There are things related to optimization, but then me should abandon support for python 2.7
There is a small fix in petpptx

Fix module 'collections' has no attribute 'Container' for latest python 3.10
Add setter for font in Run

If there are suggestions for improving the pptx engine, I am glad to hear.

@sedrew this is why I said "additional features". I'm only interested in your (or any) fork if it either adds features or fixes bugs.

Hi @MartinPacker, I had used this package in many projects till 2019. Recently encountered some errors only to find this project is not as active as before. Want to fix some bugs but realizing PRs may not be merged, I made a fork and uploaded package in python-pptx-fix. I will try to fix bugs as when i find time and may be add some minor features. If any one is willing to contribute they are more welcome!

Hi all, what are your thoughts on creating a GitHub organization to manage the project?
Something similar was proposed in #870.
Creating an org would allow using a central fork to combine further development efforts, without risking blockers due to the owner not being responsive/focusing on the project. The only issue  would be in finding people interested in maintaining the project overall and reviewing issues/PRs.
We could possibly contact owners of existing PRs and people writing about the status of this project in the issues.

A good idea. I'm ready to join it. Let me know how you will create an organization

I am in too

I think a fork is the right approach. This limits risk for existing users and it minimizes the amount of "approval" you require to make changes. An organization seems like a good idea although I don't have a point of view on that.
A couple challenges you might want to be aware of.

"Good enough for my present purposes" is rarely good enough for shared software. Developing to solve the general case is (much) harder than adding some code that solves a particular problem or adds a single needed aspect of a general capability. In order to be "good" in the aspect of serving a general audience, the software needs to solve the general case.
An important class of bugs only appear at document open time and only in certain cases (repair-error bugs). These are difficult to debug and often occur long after the code is written. Prevention is the only remedy I've found effective for these.
The engineering rigor evident in this project is there for a reason. I (quickly) got tired of fixing bugs and unexpectedly breaking existing features when adding new ones. I concluded getting it right the first time was going to maximize the project velocity (even though each feature took longer) and minimize the time I spent in tasks I didn't care for. This rigor is essentially these three things:

Analysis and design (mostly) before implementation. Gathering the facts about the way PowerPoint works related to a particular feature and designing the API/interface elements to be added is more efficiently done up front. If you don't understand how it works, you'll end up discovering it the hard way during implementation and end up with rework or even a restart.
Acceptance tests are the primary regression indicator and drive test-driven development (outside in).
Unit tests exhaustively test all possible input/output cases and drive out low-level bugs.

While this rigor paid great dividends for me, it makes it much more work to add features, more than double I'd say. Also folks seem to struggle with analysis (describing the implementation in prose, technical writing essentially) and also struggle with testing. But without it I expect you'll find that you aren't able to get very far before the library becomes unreliable.
There is no shame in maintaining a private fork, that way you can pick and choose what features you add and when one of them breaks you have some familiarity with the implementation. Big plus is you don't have to worry about it breaking for anyone else.
In any case, I wish you good luck and am happy to consult on things as you go along. I won't be able to help you with things you can do for yourself, like researching the Microsoft API or the ISO spec, but if you want to understand how some aspect of the architecture works or why it was done that way I'll be happy to advise.

Hi @scanny, Thank you for your valuable inputs. I would also like to know if you were to write this library again what would be your approach. Would it be different or same. If it is different what could probably be it.
Regards,
@kascodeo

@kascodeo Turns out I have reason to use this library again in my current gig and will be adding some features and probably generally refreshing it as well, dropping Python 2.7 support, adding typing, that sort of thing.
This architecture is actually the third one I built. The first two were simpler to understand but turned out not to scale. So I don't think I'd make any fundamental changes there. I did have the idea to extract some of the common parts into separate libraries so they could be shared across python-docx and python-pptx, but never went very far with that. It would be challenging and also introducing cross-project coupling would be inconvenient when you wanted to make a breaking change.
A main common parts are the Open Packaging Convention (OPC) bits, so Package, Parts, Relationships, serializing and deserializing .pptx files (zip archives) etc. There's actually a python-opc project out there where I got part of the way.
The other part is DrawingML, so things like charts, text-boxes in docx, drawings somewhat like PowerPoint slides, some other things. That actually would be nice to have as a separate package if possible because charts are a lot of code and work and it would be nice to be able to add those to python-docx without rewriting all that code.


[question] How to pass options from podman to ocijail

Sorry for the stupid question, but I see that there is code in ocijail for enabling System-V IPC (this should be safe to enable unconditionally since FreeBSD 11?), but I can't figure out how to make podman pass these settings down to ocijail.  What should I be searching for in the docs?

I'm dealing with a similar situation with enable.mlock.
I was able to get my app to work by patching ocijail, but I feel like this is not the right approach.
diff --git a/ocijail/create.cpp b/ocijail/create.cpp
index 78f9355..27b6cae 100644
--- a/ocijail/create.cpp
+++ b/ocijail/create.cpp
@@ -244,6 +244,7 @@ void create::run() {
     jconf.set("persist");
     jconf.set("enforce_statfs", 1u);
     jconf.set("allow.raw_sockets");
+    jconf.set("allow.mlock");
     if (allow_chflags) {
         jconf.set("allow.chflags");
     }


revealed parameter in prover building proof

Signed-off-by: Pompeo Faruolo<EMAIL_ADDRESS>

Codecov Report

Merging #668 (3d14ca8) into main (aeee2bc) will decrease coverage by 15.97%.
The diff coverage is 50.00%.

@@             Coverage Diff             @@
##             main     #668       +/-   ##
===========================================
- Coverage   63.82%   47.85%   -15.98%
===========================================
  Files         213      212        -1
  Lines       20944    15455     -5489
  Branches     4688     3010     -1678
===========================================
- Hits        13368     7396     -5972
- Misses       3840     5771     +1931
+ Partials     3736     2288     -1448

Flag
Coverage Δ

unittests-aries-vcx
47.85% <50.00%> (-15.77%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

 Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

hi @pomfar can you please leave write up some description about these changes? Is this in order to be more explicit, or does this have any functional effect?
Thank you.

Hi
the change is a fix in the generating of the proof response, where the parameter unrevealed was ignored and set to true.
Then the proof response always revealed all attribute values, even when revealed parameter in input was false.

Hi @pomfar, this looks reasonable. 👍
I've never used revealed: false; if prover specifies this, what happens? I suppose this way the prover only proves ownership of the attribute, but the value?
Before we merge this, I would like to ask you for a favor - can you please rebase this on top of https://github.com/hyperledger/aries-vcx/pull/648 ? This is currently sort of top priority PR and @gmulhearn-anonyome has been already rebasing many times, I hope you understand. In that PR, the files you have modified has been shuffled a bit. Please reach out to @gmulhearn-anonyome on discord if it turns our tricky and a guidance is needed.
Thank you!

Hi
Yes, with revealed=false the values is not sent to the verifier.
This is a very powerful feature!
For the rebase, it's ok.
thanks


IRGen: Use clang::Sema::LookupName instead of TranslationUnit::lookup to find NSInteger.

Sema's lookup is much more efficient.

@swift-ci Please test and merge

@DougGregor Does this look better?

lldb-mi timeout failure on Linux looks unrelated.

Yes, much better. Thank you!

I'd recommend this for the Swift 3 branch.

Have never tried? What does this do to be exact?

What is up I'm lost?


v0.6.4

2. Description of changes:
v0.6.4 release.
3. How was this change tested?
Scaled up and scaled down and found no errors on a fresh cluster.
4. Does this change impact docs?

[x] Yes, PR includes docs updates
[ ] Yes, issue opened: link to issue
[ ] No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

LGTM


Change the UndoStack to something better

Because the UndoStack can only store 1MB of data, the potential for large Undooperations is pretty weak.
A custom Stack using an Array or a List is a should be a way better alternative here.

I tried the list but with pretty high ram usage, so no idea for that

Other idea is to use a string instead of a list


Add param for disabling pod cleanup

Introduces a flow parameter disable.pod.cleanup, if it's set
the flow-pod will not be auto-cleaned after flow execution ends.

Pull Request Test Coverage Report for Build 6308

13 of 24 (54.17%)  changed or added relevant lines in 3 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage increased (+5.0e**-05%**) to 44.894%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

azkaban-common/src/main/java/azkaban/executor/container/watch/FlowStatusManagerListener.java
1
4
25.0%

azkaban-common/src/main/java/azkaban/executor/container/KubernetesContainerizedImpl.java
2
6
33.33%

azkaban-common/src/main/java/azkaban/executor/container/watch/AzPodStatusMetadata.java
10
14
71.43%

Files with Coverage Reduction
New Missed Lines
%

azkaban-common/src/main/java/azkaban/executor/container/watch/AzPodStatusMetadata.java
1
75.51%

Totals

Change from base Build 6297:
5.0e-05%

Covered Lines:
17470

Relevant Lines:
38914

💛  - Coveralls


Output also original sentence

It is possible to output also the original sentence?
For example:
Sentence 1.
RE 1
RE2
Sentence 2.
RE1
RE2
Barack Obama was born in Hawaii.
Barack Obama | was | born
Barack Obama | was born in | Hawaii

@MichalGabonay can't you just keep the mapping yourself when you call the library?

I'll close this for now.


Enable dev mode instead of disable

We have a use case where we use Vercel for staging environment deployments. Here, the build is very much like a production build in that the NODE_ENV is production, but we would still like to see the variation switcher from dev mode.
https://github.com/growthbook/growthbook-react/blob/main/src/index.tsx#L60 hardcodes that disableDevMode can only be used when NODE_ENV is not production. Perhaps if we remove this rule and set disableDevMode = process.env.NODE_ENV === "production" as the default value, we will be able to overwrite disableDevMode.

We also would benefit from this exact same scenario. We have production builds on staging, which we would want to enable the devmode for, so we can test out the variations.

There is now a standalone dev mode npm package that can be used even when NODE_ENV is production.  https://www.npmjs.com/package/@growthbook/dev
It's only meant for dev/staging environments so make sure to conditionally render it so it doesn't show up in actual production.
Also, FYI this repo is being deprecated and the react code has moved to the main GrowthBook monorepo at https://github.com/growthbook/growthbook


In-browser version of Lean fails to show error on bad tactic proof

A minor bug that I came across while looking something up in the tutorial.
The following proof is clearly wrong:
import data.nat

constants a m n : nat
axiom a1 : n = a

theorem t1 : m = n :=
  by rewrite a1; apply rfl

In emacs, Lean identifies the error. The in-browser version just gives the following output without highlighting any errors:
-- Processing...
-- Saved at cookie.

The problem seems to be with the compound tactic.

It actually outputs the following error message to Javascript Console:
Uncaught abort() at Error
    at jsStackTrace (https://leanprover.github.io/lean.js/lean.js:1:4307289)
    at stackTrace (https://leanprover.github.io/lean.js/lean.js:1:4307472)
    at abort (https://leanprover.github.io/lean.js/lean.js:107:30300)
    at Array.aie (https://leanprover.github.io/lean.js/lean.js:97:67329)
    at gjb (https://leanprover.github.io/lean.js/lean.js:61:225396)
    at kXb (https://leanprover.github.io/lean.js/lean.js:93:133755)
    at Array.lXb (https://leanprover.github.io/lean.js/lean.js:93:134198)
    at Object.iNd [as dynCall_viii] (https://leanprover.github.io/lean.js/lean.js:97:3006)
    at invoke_viii (https://leanprover.github.io/lean.js/lean.js:1:5346348)
    at ZDc (https://leanprover.github.io/lean.js/lean.js:85:192395)
If this abort() is unexpected, build with -s ASSERTIONS=1 which can give more information.invoke_ii @ lean.js:1cf @ lean.js:9cNd @ lean.js:97lean_process_file @ VM257:6myModule.process_file @ main_live.js:1(anonymous function) @ main_live.js:1

The lean.js has not been updated in a while. I will update it asap.

I updated lean.js, and it is still failing.
I tried the native binary, and everything works with different settings.
I also compiled everything locally using --to_axiom, and did not find any problems.
I also tried to execute the native binary using valgrind, and got 0 errors.
I don't know what to do. This is a serious issue. It seems to affect many tactics.
Here is a smaller problematic example:
example (a n : nat) (H : n = a) : n = n :=
begin
  rewrite H
end

@soonhokong any ideas? I couldn't make sense of the trace you posted.

Dear Leo,
I will take a look at it after dinner.
Best,
Soonho
On Tuesday, June 16, 2015, Leonardo de Moura<EMAIL_ADDRESS>wrote:

I updated lean.js, and it is still failing.
I tried the native binary, and everything works with different settings.
I also compiled everything locally using --to_axiom, and did not find any
problems.
I also tried to execute the native binary using valgrind, and got 0 errors.
I don't know what to do. This is a serious issue. It seems to affect many
tactics.
Here is a smaller problematic example:
example (a n : nat) (H : n = a) : n = n :=begin
rewrite Hend
@soonhokong https://github.com/soonhokong any ideas? I couldn't make
sense of the trace you posted.
—
Reply to this email directly or view it on GitHub
https://github.com/leanprover/tutorial/issues/113#issuecomment-112593877
.

--
Best,
Soonho

Thanks!

@soonhokong Any news?
I'm worried about this issue because of the tutorial at CADE.

I was working on it last night. I had a problem compiling gmp with the latest version of emscripten SDK (known problem for 64-bit machines, but it worked before on a 32-bit machine). I think I figure out how to fix it. I'll keep you posted.

This is great news! What is the problem?

GMP checks whether a compiler supports long long or not by compiling a test code. I think there is a problem in the test code that they're using and it failed because of the code.

I see, you fixed the GMP problem...
I thought you had found the problem with the web version.

Anyway, I'll first compile Lean.js using a 32-bit VM machine (after fixing the above issue), then fix the original issue (which generated the JS stack trace that I mentioned above).

Sorry.. not yet :-(

@rlewis1988, I've made some updates. Could you check the two examples again on your machine?

This seems to have fixed it! Although, the error message is a little funky:

@rlewis1988, I see. I do have the same message.


modules/2.2-alpha1

This is a PR for tracking progress as we work on modules/2.2-alpha1.

Nothing too big in here; just adding some packages to trilinos and fixing the cudnn module. Also, the default Python has been set to 3.10.


fix: panic when config dir access denied

nali will panic when ConfigDir is not accessible
panic: runtime error: invalid memory address or nil pointer dereference
[signal 0xc0000005 code=0x0 addr=0x18 pc=0x4b8fa2]

goroutine 1 [running]:
github.com/zu1k/nali/internal/constant.prepareDir({0xc000022f40, 0x35})
        github.com/zu1k/nali/internal/constant/path.go:45 +0xe2
github.com/zu1k/nali/internal/constant.init.0()
        github.com/zu1k/nali/internal/constant/path.go:32 +0x1f8

L45 stat is possible nil, we need to check other errs to make sure stat is not nil.
In my case, the err is Access is denied.
https://github.com/zu1k/nali/blob/20a0de63f1eb447bf22fdbdd0609c3b2abc481f5/internal/constant/path.go#L38-L48

thanks


Added check for virtualenv's name

Added a bash condition which will check if virtualenv is installed by checking both virtualenv and virtualenv2 (for distros supporting Python 3 which had to rename Python 2 binaries), and stops the installation if not installed.
Fixes #252.

Found another (simpler?) way to check virtualenv's installation, thanks to @nicofrand.

Messed up with the branch's history. I'm going to redo everything in another PR, could you please close this one?


pool: add nicehash pool verificator support.

This adds a nicehash pool verificator client entry to supported mining clients.

dcrpool verificator results.
Pool host xxx.xxx.xx.xxx resolved to IP xxx.xxx.xx.xxx... OK
Connecting to Stratum proxy for region: EUROPE... OK
Selected mining algorithm: Decred... OK
Sending mining subscribe request... OK
Sending login information... OK
Mining subscribe request successfully completed... OK
Received mining set difficulty... OK
Pool difficulty is correct (provided=1303, minimum=128)... OK


Sync History

To track changes to the sync history feature #43. This is in progress still.
Apologies for the duplicate pull request, I accidentally messed the other one up. (I'm still fairly new to Github)

Thanks for the PR and no problem! Added a couple comments, will keep an eye out for updates :)

Thanks by the way!


Tracer detection failing for non default url

If the AEM server is not running on default url of http://localhost:4502 then plugin is not able connect to correct url. This happens because background.js tries to use chrome.tabs.query API in synchronous way which would not work as expected.
For this to work callback approach would have to be used

#24 Fix for the same. The fix might need tweaks as my js skills are well ... ;)


Update AI Software Template ref on README

What does this PR do / why we need it
The AI Templates repo has a release branch for more stable AI Software Templates.
Updates README for:

Adding in the new Software Templates that were not previously mentioned
Links to the release branch of the Software Templates instead of main

Which issue(s) does this PR fix
https://issues.redhat.com/browse/DEVAI-183
How to test changes / Special notes to the reviewer

Import the Software Templates to test out the changes as usual
Or, follow README for how to use RHDH installer to get an RHDH instance with the dependencies

I also have a PR for the 1.3.x branch https://github.com/redhat-developer/red-hat-developer-hub-software-templates/pull/25


chore: update dependencies

Types of changes

[x] Version bump

Checklist:

[x] All new and existing tests passed.

Codecov Report

Merging #3947 into dev will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev    #3947   +/-   ##
=======================================
  Coverage   97.48%   97.48%
=======================================
  Files          18       18
  Lines        1232     1232
  Branches      337      337
=======================================
  Hits         1201     1201
  Misses         30       30
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dabc60c...37973f6. Read the comment docs.

maybe for bumping versions use renovate bot  ?

@aldarund I'm up with your idea ;)

@Atinux cc


Make fluentd cloudwatch compatible

In some cases we need to send log to cloudwatch from fluentd.
This feature is missing in our images since quay.io/sighup/fluentd:v1.11.5-debian-1.0.
Do you think it will be possible to have it back for the latest modules of logging v1 and v2?

Hi Greg, Cloudwatch output is already available with the logging operator, on module versions v2 and v3
https://banzaicloud.com/docs/one-eye/logging-operator/configuration/plugins/outputs/cloudwatch/

thank you so much, so we only have to update to the V2 the cluster which are still on the v1 and can't send anymore the logs to clouwatch.
Thank you, will close the issue.


Enhance oss-find-source tool

Added logic for pypi, nuget and npm package managers to extract specific metadata to get the source code repository
Added general search of metadata to all package managers
Upgraded packages to latest
Added and updated tests

Merged into a new branch, PR #37 replaces this, let's sync up on that one.


Cherrypick as you wish!

Note: Calculator uses Darknight bg colours, all other apps should successfully pick with the old background without changes.

thx


[Unity] Add try-catch when tcp socket is processing data received

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 29.98%. Comparing base (fa75827) to head (ce414ae).
Report is 1 commits behind head on master.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #101   +/-   ##
=======================================
  Coverage   29.98%   29.98%
=======================================
  Files         102      102
  Lines        2898     2898
  Branches      389      389
=======================================
  Hits          869      869
  Misses       1974     1974
  Partials       55       55

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Polymorphable ignores damage groups of the polymorphed entity

Description

When a repairable component is repaired, it sets all damage values to 0, including ones that their damage container doesn't have. This includes giving genetic and rad damage values to drones, etc.
Reproduction

Health analyzer a drone
Observe their limited damage types
Punch drone
Weld drone to repair it
Now the drone can get radiation and genetic damage, etc...

Screenshots

Additional context

I cant seem to reproduce this using those steps. Did this happen in the downstream?

Yeah, this is a secondhand report by Ripmorld and all the involved components are the same as upstream.

I've isolated the actual issue to polymorph after a bit more debugging

It breaks after both of these occur:

Set all damage types from one entity on another (with polymorphing, for example)
Repair entity (or maybe other similar things, e.g. rejuvs)

Somewhere along here the damage container gets bypassed, for things that are possible during normal play

Recorded on upstream master
Uploading 2022-05-30 21-26-05.mp4…

Recorded on upstream master (make a Drone polymorph proto)
2022-05-30.21-26-05.mp4

Is it able to take damage from the newfound damage types or do they just appear on the health analyzer menu?

Recorded on upstream master (make a Drone polymorph proto)
2022-05-30.21-26-05.mp4

Is it able to take damage from the newfound damage types or do they just appear on the health analyzer menu?

It can take damage from them, yes

theres no need for roundstart polymorphs anymore and the system has been rewritten a bunch now, closing


Shortcut key to toggle between guided camera and gm follow camera

With the new shortcut key update, add a configurable shortcut to toggle between the two camera modes

Available in v1.2.0, along with various other binds.


Add contributors handles in contributors.md

I would like to work on it. Do I need to add the handles to contributors mentioned at the end of the repository?


Closed-form expressions for the Distance Gradients / Hessians

Hi,
I'm implementing IPC in my advisor's physics library. However, the paper does not appear to provide closed-form expressions for the {gradients, Hessians} of the {point-plane, point-line, line-line} distance functions WRT all inputs. Instead, the toolkit only has mangled, auto-generated functions. Since my advisor wants to make sure that I fully understand the math, I need to know the un-mangled expressions for these functions. So far, I've managed to reverse-engineer the following functions below. Could you please provide me the un-mangled forms for all the mangled functions? I'm relatively new to this math (e.g. I have never tried deriving something like the gradient of point-plane distance WRT the plane itself).
Thank you for your time.
VECTOR<T, 12>
Point_Plane_Distance_Gradient(const TV& p, const TV& a, const TV& b, const TV& c)
{
    TV pa = p - a;
    TV ba = b - a;
    TV ca = c - a;
    TV cb = c - b;
    TV normal = ba.Cross(ca);
    T one_over_normal_sq = 1 / normal.Magnitude_Squared();
    T one_over_normal_sq_sq = one_over_normal_sq * one_over_normal_sq;
    T p_distance = pa.Dot(normal);
    T p_distance_sq = p_distance * p_distance;

    return 2 * p_distance * one_over_normal_sq * VECTOR<T, 12>(
        normal,                                                                     //g_p
        VECTOR<T, 9>(
            p_distance * one_over_normal_sq * cb.Cross(normal) - (normal + pa.Cross(cb)), //g_a
            VECTOR<T, 6>(
                ca.Cross(normal) + pa.Cross(ca) * p_distance * one_over_normal_sq,  //g_b
                pa.Cross(ba) - ba.Cross(normal) * p_distance * one_over_normal_sq   //g_c
            )
        )
    );
}

VECTOR<T, 9>
Point_Line_Distance_Gradient(const TV& p, const TV& a, const TV& b) const
{
    TV pa = p - a;
    TV pb = p - b;
    TV ab = a - b;
    T over_ab_sq = 1.0 / ab.Magnitude_Squared();
    TV paXpb = (p - a).Cross(p - b);
    T over_ab_sq_sq = over_ab_sq * over_ab_sq;
    T paXpb_sq = paXpb.Magnitude_Squared();
    TV f = 2 * ab * paXpb_sq * over_ab_sq_sq;
    return 2 * over_ab_sq * VECTOR<T, 9>(
        ab.Cross(paXpb),
        VECTOR<T, 6>(
            f + pb.Cross(paXpb),
            f + pa.Cross(paXpb)
        )
    );

All of the distance derivatives in the toolkit (except for point-point) are derived using symbolic differentiation, so unfortunately, I do not have the matrix calculus versions of these expressions on hand. I can point you to Kim and Eberle's [2022] "Dynamic Deformables" course (see "Appendix I: Computing the Derivatives of a Triangle (and Edge) Normal"). Shi and Kim [2023] also have some useful derivations in their supplemental.
If your goal is to verify your derivation you can compare it with the existing implementation or use finite differences.
The derivatives were originally derived using the Symbolic Math Toolbox in MATLAB, but I prefer to use SymPy in Python. There is a utility file notebooks/generate_cpp_code.py which I use a lot to generate various gradients/Jacobian/Hessians. While I agree with your advisor that understanding matrix calculus is an important skill, I would also argue that learning how to use symbolic code generation is a good skill to have in your toolbox.


[core] Add CI check that the PR has label

This is probably too early to enforce at least one GitHub label on PRs but part of https://www.notion.so/mui-org/Retrospective-W32-33-cfd4332ad6a54f4593b453a8ec0bf91f#edf81bb00b504c8abd5b970aff98a77a. I believe that we eventually want to get there. Enforcing labels could solve:

Scaling reviews. It's what we use in https://www.notion.so/mui-org/0c8156b0b1634ea5bfd903dd005ec1cf?v=b9e94cc3ea554e668e7c54d585910569
Guiding high-level resource allocations. https://www.notion.so/mui-org/KPIs-1ce9658b85ce4628a2a2ed2ae74ff69c#06950ec6688840549cfc9429635f4298
Finding past work on the problems faster (in Material UI, it's often impossible without labels)

I have copied https://github.com/mui/material-ui/pull/32886

Are there any downsides if we try to enforce at least one label? Worse case scenario we can add just any label to make PR pass and document why we could use other meaningful labels, or if we need to create new ones 🤔

Are there any downsides if we try to enforce at least one label?

It's a bit more friction. I would personally be in favor of us feeling a pain around it before doing such.

It's a bit more friction, the GitHub Action takes ~20s to run, a time you have to wait before you can merge your PR if a label is missing.

Don't we need to wait for like 10-20 minutes before circle CI jobs complete? 🤔
I was also thinking if we could run GH action but make it optional in order to merge PR? That way it would introduce little bit of noise to nudge us to start using labels, but would not block merging of PRs?

I would personally be in favor of us feeling pain around the lack of labels before merging this.

I'm fine with merging, but this resonates with me. Without a clear purpose, I'm not sure we would be investing much time in the quality of our labeling.

I came back today to this PR after seeing some of the regressions, which made me think that having some metrics could help us identify if we write enough tests or not, identify if we focus enough/too much on bugs. Forcing at least one label could cover:

https://www.notion.so/mui-org/KPIs-1ce9658b85ce4628a2a2ed2ae74ff69c#5d672eaa191e41108d10ad84f3a3e6cf
https://www.notion.so/mui-org/KPIs-1ce9658b85ce4628a2a2ed2ae74ff69c#06950ec6688840549cfc9429635f4298

I think we should label in function of what we want to measure. We're currently labelling bugs and regressions.

some metrics could help us identify if we write enough tests or not, identify if we focus enough/too much on bugs.

If we want to effectively measure these two things, which extra labelling would be required?

in function of what we want to measure.

@Janpot At our scale, a few ideas of concrete problem that it could solve:

To find older work. We are getting close to #1000. We might want to find discussions on older work, without the labels to filter out issues/PRs, good luck.
To provide clarity on what the issue/PR is about. Sometimes simply choosing between, a bug, a new feature, support: question, and docs, can require a very deep understanding of the pain point.
To delegate the area of ownership, with broad product scope labels, we could start to prepare when we reach the point where the is too much activity on the repository for a single person to be able to see everything.
Maybe to track regressions, I'm not sure, maybe it's helpful as a broad feedback loop for us to: we are moving without testing enough.

To provide clarity on what the issue/PR is about. Sometimes simply choosing between, a bug, a new feature, support: question, and docs, can require a very deep understanding of the pain point.

Yes, those labels I agree with.

To delegate the area of ownership, with broad product scope labels, we could start to prepare when we reach the point where the is too much activity on the repository for a single person to be able to see everything.

I'm not sure I currently see clear lines where we can determine ownership. I was hoping for the future to do that more along the lines of CE, EE, cloud, docs. The current labels like "feature: queries" don't feel very useful to me. e.g. I change something that affects all queries, does it go in "core" or in "feature: queries"?

The current labels like "feature: queries" don't feel very useful to me.

We can remove these, until we see a clear pain point it solves. At this point, my main assumption is that the feature labels can help to find patterns of bugs, find duplicates, but if the volume is low enough to be able to see all the new issues, then yeah, agree, it's overkill at our size.

Ok, sounds good. So in terms of which labels have to be applied, how about

core
docs

to define area of ownership (We can add more labels when necessary), optionally accompanied by

bug
regression
feature
enhancement
...?

to define the nature of the PR?
Question: With this github action, can we define which labels to pick from? e.g. PR must have one blue label (core/docs) and one yellow label (bug/regression/..)

Question: With this github action, can we define which labels to pick from? e.g. PR must have one blue label (core/docs) and one yellow label (bug/regression/..)

This GitHub Actions doesn't support it. @mnajdova wrote it to help us find cases where we forgot about applying any labels. The problems we had was sometimes we forget about adding the labels altogether. We assumed that once we remember it, we then do it "correctly".

Does the labels option allow for specifying which labels are expected?

Based on https://github.com/mheap/github-action-required-labels#examples, yes, I think that it could be possible.


Travis build shows Flow errors but does not fail

The build should fail on Flow errors.
Ex: https://travis-ci.org/uber/jaeger-client-node/jobs/175170799
flow is still initializing; this can take some time. [processing] -# linter passed
./node_modules/.bin/mocha --compilers js:babel-core/register test
Launching Flow server for /home/travis/build/uber/jaeger-client-node
Spawned flow server (pid=4755)
Logs will go to /tmp/flow/zShomezStraviszSbuildzSuberzSjaeger-client-node.log
crossdock/src/helpers.js:37
 37:     _tracer: Tracer;
                  ^^^^^^ identifier `Tracer`. Could not resolve name
crossdock/src/helpers.js:39
 39:     _thriftChannel: Channel;
                         ^^^^^^^ identifier `Channel`. Could not resolve name
crossdock/src/helpers.js:46
 46:             peers: [Utils.myIp() + ':8082']
                         ^^^^^^^^^^^^ null. This type cannot be added to
 46:             peers: [Utils.myIp() + ':8082']
                         ^^^^^^^^^^^^^^^^^^^^^^ string

Fixed by some earlier commits


Submission for July 14th

I have done all the comments that Prof. Lukas mentioned. I don't understand What is the error right now?

Hello,
The grating coupler loopbacks on the right are missing the opt_in labels.
The grating couplers need to be perfectly aligned, where they have the same x coordinates.
Finally, you have Shapes outside component.  Shapes for device layers need to be inside a component. At minimum, they must be inside a cell and inside a DevRec shape. Read more about requirements for components: https://github.com/SiEPIC/SiEPIC-Tools/wiki/Component-and-PCell-Layout


Deploy tag

Q
A

Issue Type
Feature Request

Deployer Version
3.3.0 or above. Possible at v4?

Local Machine OS
Darwin luna.local 15.4.0 Darwin Kernel Version 15.4.0

Remote Machine OS
Linux apollo 4.4.0-24-generic 43-Ubuntu SMP

Description
When you are deploying you must have a option of generating a git tag in the repository with the current release name so you can easy track your latest deployment in your git environment.

@RicardoJ I think you should make a custom task for this feature.
Becasue, sometime, deployers want deploy a develop version for test of build CI. They will have many tag version is created by Deployer.
What are you thing if we will log deploy versions in to a file?

After reading your motivation, I agree to the situation other deployers may have with CI. Thank you for the information.
√

@RicardoJ
I see you implemented feature using deployer.lock file.
What are you thing if we will log deploy versions in to a file? Can you help us this feature?

Yes, I'll add it in a PR.


Minimal Code Changes to Support Latest PyTorch and Bug Fixed for Extremely Low Adaptation Accuracy

Thanks for contributing this repo, which is really nice to learn domain adaptation.

Just made some minimal code changes to support latest PyTorch (>= 1.0) and Python (>= 3.6) (https://github.com/corenel/pytorch-adda/pull/29/commits/0f98f5de673d0842f484a6460f2367131c243aad).

Fixed the low adaptation accuracy (10%-15%) mentioned in #27 #26 #22 #15 #10 #8 #7 #1. The bug is due to the different normalization applied to MNIST and USPS. The data loader normalizes all the MNIST images to 0-1, while normalizing all the USPS images to 0-255. Changing the latter to 0-1 leads to normal performance (https://github.com/corenel/pytorch-adda/pull/29/commits/13a295ab5c94a572854cdf0ffa5e63c65e209777):

=== Evaluating classifier for source domain === (100 epochs)
Avg Loss = 0.08870776686510162, Avg Accuracy = 99.250001%

=== Evaluating classifier for encoded target domain === (100 epochs)
>>> source only <<<
Avg Loss = 0.6725219937139436, Avg Accuracy = 87.956989%
>>> domain adaption <<<
Avg Loss = 0.49638841790887883, Avg Accuracy = 97.365594%

Fixed the outputs of the discriminator mentioned in #16 #11 #2. For nn.CrossEntropyLoss, the input is expected to contain raw, unnormalized scores for each class, rather than logprobs (https://github.com/corenel/pytorch-adda/pull/29/commits/6e59bbddfe1e254ab8eade18d6b5b489db099e52). However, the performance is not improved after correction.

=== Evaluating classifier for encoded target domain === (100 epochs)
>>> source only <<<
Avg Loss = 0.6533445982556594, Avg Accuracy = 87.956989%
>>> domain adaption <<<
Avg Loss = 0.46242921638726453, Avg Accuracy = 97.204304%

think you very much. this is  a big help.
I take a test. all is right in this version.
https://github.com/yuhui-zh15/pytorch-adda

I think what causes the low adaptation accuracy is that the class labels are swapped by the target encoder. This makes sense because it is an unsupervised task and the target encoder didn't see the class labels.
I've used this code on 2D data:
https://github.com/mashaan14/ADDA-toy
You can see in the attached image that the target encoder separates the classes well. But the class labels were swapped.


Remove curl usage from appveyor

Appveyor removed curl from PATH, which broke our CI

Issue: https://github.com/appveyor/ci/issues/1426

@bors r+

:pushpin: Commit 67a20ff has been approved by brson

:hourglass: Testing commit 67a20ff with merge d48074d...

:broken_heart: Test failed - status-appveyor

Just going to merge this, test failure is clearly spurious and the other PRs need to include this change before they can run on appveyor.


Add Map based update functions

Write two update functions that accept Maps, one with authentication, one without.

Done