skip_hooks context manager

Due to the current way skip_hooks works, you need to pass it into save(), you can not suppress hooks in the case of using model.objects.get_or_create. You can't just pass in skip_hooks to that method as it's used when initing the new model, and in inital get request.
For create() it would be possible to eaisly fix by popping out skip_hooks from init's kwags
    def create(self, **kwargs):
        """
        Create a new object with the given kwargs, saving it to the database
        and returning the created object.
        """
        obj = self.model(**kwargs)
        self._for_write = True
        obj.save(force_insert=True, using=self.db)
        return obj

class LifecycleModelMixin(object):
    def __init__(self, *args, **kwargs):
        self._skip_hooks = kwargs.pop("skip_hooks", None) #newline
        super().__init__(*args, **kwargs)
        self._initial_state = self._snapshot_state()

and then in save also check the non_null sate of self._get_hooks
    @transaction.atomic
    def save(self, *args, **kwargs):
        skip_hooks = kwargs.pop("skip_hooks", False) or self._skip_hooks

But that doesn't fix that skip_hooks=True will be passed to the queryset filter.
So in that case, the only solution would be some global var/instance which is set using enter and exit
class SkipHooks() :
    skip_hooks = False
    def __enter__(self):
         self.skip_hooks = True
    def __exit__(self):
         self.skip_hooks = False

skip_hooks = SkipHooks()

with skip_hooks:
    foo.save()

    @transaction.atomic
    def save(self, *args, **kwargs):
        skip_hooks = kwargs.pop("skip_hooks", False) or self._skip_hooks or skip_hooks.skip_hooks

Does anyone have any comments on this?
And if I were to make the proposed changes, would they PR be accepted?

I like the context manager approach, I've seen similar patterns in other projects like django-modeltranslation:
https://github.com/deschler/django-modeltranslation/blob/2061f6c264d7cb889ae14d2d52a7547df6d58663/modeltranslation/utils.py#L133C13-L155
https://github.com/deschler/django-modeltranslation/blob/master/modeltranslation/thread_context.py#L9-L21
If you want to provide an implementation for this let me know, if not when I have some spare time I could try to do it.


Puppeteer does not honor hyphens:auto

In Chromium 88, support for hyphens: auto was added.
https://www.chromestatus.com/feature/5672891947417600
However when using a puppeteer version that supports chromium 88 or above, hyphens:auto does not behave as expected.
I have downloaded the current version of chrome 88 locally, as well as the beta and canary versions. When viewing a test html file utilizing hyphens: auto in these chrome versions, the behavior works as expected and words are automatically hyphenated when the screen becomes too thin.
However if I boot these SAME executables up using puppeteer, and open the EXACT SAME test file, the hyphen behavior does NOT work as expected, and no hyphens appear.
My example hyphens test file is below.
<html lang="en">
    <div style="word-break: break-word; hyphens: auto;">
    reallylongwordwithnobreaksatall reallylongwordwithnobreaksatall reallylongwordwithnobreaksatall reallylongwordwithnobreaksatall reallylongwordwithnobreaksatall
    </div>
</html>

Steps to reproduce
Tell us about your environment:

Puppeteer version: Any, I have tried 5.5.0 - 7.0.1
Platform / OS version: Windows/Chrome
URLs (if applicable):
Node.js version:

What steps will reproduce the problem?
Please include code that reproduces the issue.

Boot up a non-headless version of puppeteer
View the above html file and notice that it does not match what the file looks like when using the corresponding chrome version.

What is the expected result?
Puppeteer should match chrome behavior for hyphens: auto
What happens instead?
Puppeteer does not match chrome behavior for hyphens: auto

Seems like a normal Chrome downloads dictionaries after startup and installs it (under Windows) within the AppData User directory in order to let the hyphenation work:

as also explained in Chrome's tracking bug entry on how it is implemented: https://bugs.chromium.org/p/chromium/issues/detail?id=652964#c70
I guess, this is what is not happening when a fresh chrome is started via puppeteer...

That's a good guess. However as noted as in the OP, when I have instructed puppeteer to use a chrome executable that I have verified honors hyphens: auto when booting it up normally, it still doesn't work.
What I'm saying is say I have chrome 88 downloaded. When I open chrome 88 normally, hyphens: auto works.
But when I have puppeteer open that SAME chrome 88 executable, hyphens: auto does not work.
This leads me to believe there's something else going on.

That's a good guess. However as noted as in the OP, when I have instructed puppeteer to use a chrome executable that I have verified honors hyphens: auto when booting it up normally, it still doesn't work.

@Friction-less-development This is not about the chrome executable, it's about the user profile dir. As @OmarHawk pointed out, chrome downloads the hyphenation data in the user profile dir after launching for the first time on that user profile dir. So the issue you are experiencing has to do with puppeteer using a new user profile dir every time it launches chrome. If you disable that behavior by passing a persistent value to the userDataDir option of puppeteer.launch then it should work, provided that you give it some time to download the the hyphenation data (you might also have to restart chrome after that). I have confirmed that under linux (and according to the relevant chrome bug, it should behave the same under windows).

BTW, there seems to be another issue: in my tests, hyphens: auto is not honored when running in headless mode, but I would guess this is a chromium bug not a puppeteer issue.

Does anyone know where Chromium pulls the hyphenation info from on Linux/Ubuntu? There is no hyphen-data directory and I cannot find any .hyb in the user data dir. If I knew were to put the files I'd just copy them in the right place before calling launch. I already do that with fonts (copy them into /tmp/.fonts in AWS lambda so they work for the PDF generation).

It seems like puppeteer does not render hyphens correctly yet. I tried rendering with hypens:auto with the new headless mode.
Starting chrome normally the hyphens are rendered, but using puppeteer the hyphens are not shown. Also with the executablePath pointing to chrome and the userDataDir pointing to the 'chrome user data dir'.

Does anyone know where Chromium pulls the hyphenation info from on Linux/Ubuntu? There is no hyphen-data directory and I cannot find any .hyb in the user data dir. If I knew where to put the files I'd just copy them in the right place before calling launch. I already do that with fonts (copy them into /tmp/.fonts in AWS lambda so they work for the PDF generation).

Did you ever get a solution to this problem?

It seems like puppeteer does not render hyphens correctly yet. I tried rendering with hypens:auto with the new headless mode. Starting chrome normally the hyphens are rendered, but using puppeteer the hyphens are not shown. Also with the executablePath pointing to chrome and the userDataDir pointing to the 'chrome user data dir'.

Did you find a solution to this?


Add better error handling

Is your feature request related to a problem? Please describe.
        // Find next project
        let next = match pick_next_project(db, &judge).await {
            Ok(p) => p,
            Err(_) => return (Status::InternalServerError, None),
        };

Errors messages are just... discarded :/
Describe the solution you'd like
We should have some way for the end user to see error messages. This should also be logged in the server logs fs
Additional context
No response

Update: Error messages are now better, but I do want some way of logging errors.


[BUG] - Listbox Type error when used with Typescript (works for Javascript) Type error: Type 'Dispatch<SetStateAction<Set<string>>>' is not assignable to type '(keys: Selection) => any'

NextUI Version
2.2.9
Describe the bug
Type error: Type 'Dispatch<SetStateAction<Set>>' is not assignable to type '(keys: Selection) => any'.
Types of parameters 'value' and 'keys' are incompatible.
Type 'Selection' is not assignable to type 'SetStateAction<Set>'.
Type 'string' is not assignable to type 'SetStateAction<Set>'.
394 |                 selectionMode="single"
395 |                 selectedKeys={selectedQuality}

396 |                 onSelectionChange={setSelectedQuality}
|                 ^
397 |               >
398 |
399 |                 <ListboxItem onClick={() => (setIsSettingsOpen(false), setSettingsItems(false))} key="Auto">Auto

Your Example Website or App
No response
Steps to Reproduce the Bug or Issue
While using the codes from official documentations in typescript.
While the code still works in development but when building the application it throws type error.
Expected behavior
The error doesnt cause any unexpected error it jst shows type error when building the application
Screenshots or Videos
No response
Operating System Version
Windows
Browser
Chrome

Hey, @kazuma-aniflex. Did you try to use onSelectionChange={(keys) => onSelectedCaption(keys as Set<string>)}?

@matheusboeira Thank you bro that solved the issue I was having.

As I see type Selection uses type Key that is defined in @react-types and can be string | number;
Even if I set type in useState like
import { useState, type Key } from 'react';
const [value, setValue] = useState<Set<Key> | 'all'>();

It will still cause an error, because in @types/react type Key = string | number | bigint.
So the possible solution can be setting type of the state like:
const [value, setValue] = useState<Set<string | number> | 'all'>();

@alehkonan Hi, may I ask if the value/setValue set to Set, how to assign the <Select value={value}? Cause I got the similar error: "Type Set<string | number> | "all" | undefined is not assignable to type string | number readonly string[] | undefined"


Linter Not Working Windows 7 Atom 0.165.0

I just installed Linter in Atom and installed a php linter and I cannot get it to work. I was using the main php linter.  Every time I see this error in the developer tools:
stderr 'php' is not recognized as an internal or external command,
operable program or batch file.
 utils.coffee:9
php returned LinterPhp Array[0] utils.coffee:5
command and arguments Array[8] utils.coffee:5
is node executable: false

I tried switching to the Linter Phpmd and it still doesn't work and I receive similar errors. What else can I try?

Make sure php is on your path. See #150.


withAuthUserTokenSSR does not have auth on Safari

Describe the bug
I apologize if this is a duplicate~
This issue only happens on Safari. Working as expected on Chrome and Firefox (did not test on Edge, though).
When I have a route that uses withAuthUserTokenSSR, it does not have the auth user, even after a successful login.
This does not change despite the configurations passed.
Versions
next-firebase-auth version: ^1.0.0-canary.5
Firebase JS SDK: ^9.6.
Next.js: latest
To Reproduce
I apologize for not having any live examples to share at the moment.

Export a getServerSideProps wrapped with withAuthUserTokenSSR.

export const getServerSideProps = withAuthUserTokenSSR({
      appPageURL: '/app_page',
      whenAuthed: AuthAction.RENDER,
      whenUnauthed: AuthAction.REDIRECT_TO_LOGIN,
      authPageURL: '/some_page',
      ...options,
    })(() => {
          // ...
    });

When landing on this page in Safari, I am always redirected to my login page.

Expected behavior
I expect the behaviors between Safari and Chrome to match, where I have the auth user available in getServerSideProps.
Additional context
I tested exporting getServerSideProps alone without withAuthUserTokenSSR.
When getServerSideProps is not wrapped, the page in Safari loads as expected.
It is only when I wrap it with withAuthUserTokenSSR do I run into this issue.
Thanks in advance~

It seems likely that the auth cookies are not being set, which can be due to browser settings or browser extensions.
Can you inspect the request that fires when you log in on Safari? Is the set-cookie response header set, and are the cookies set after that request completes?

I'm also experiencing this issue on safari. I have my app in production, and some of my users reported it. Here is a quick example.
export const getServerSideProps = withAuthUserTokenSSR({
  whenUnauthed: AuthAction.REDIRECT_TO_LOGIN,
  authPageURL: "/login",
})(async ({ AuthUser }) => {
  let isUserMentor = await confirmUserIsMentor();

  async function confirmUserIsMentor() {
    let isUserRole = getFirebaseAdmin()
      .auth()
      .getUser(AuthUser.id)
      .then((userRecord) => {
        let isUserRole =
          userRecord?.customClaims?.["mentor"] ||
          userRecord?.customClaims?.["admin"];
        return isUserRole;
      });

    return isUserRole;
  }

  // if (!isUserMentor) {
  //   // They aren't an admin
  //   return {
  //     redirect: {
  //       destination: `/app/dashboard`,
  //       permanent: false,
  //     },
  //   };
  // }

  return {
    props: {
      test: "test",
    },
  };
});

export default withAuthUser({
  whenUnauthedAfterInit: AuthAction.REDIRECT_TO_LOGIN,
  whenUnauthedBeforeInit: AuthAction.SHOW_LOADER,
})(MentorStudentApplications);

I'm also experiencing this issue. Have you found any solution for this?

Same issue

same issue

Can you try setting cookie's sameSite config to "Lax",?
This could be the issue: :

The problem emerge when ones set the signed parameter to true
cookies: {
    ...,
   signed: true,
 }

Closing this as related to cookie settings.
If you're running into this issue, verify that secure is only set to true in HTTPS environments, the browser and your app deployment support the SameSite setting, and that your cookie keys are set correctly when signed is true.
Please open a new issue with a live reproduction if you identify a problem with next-firebase-auth's behavior.


Address behavior of an open session when the endpoint becomes unresponsive

The issue
If I have an open session-manager-plugin session and the endpoint running amazon-ssm-agent stops responding, my session-manager-plugin shell will become unresponsive for an indeterminate amount of time.
Would it make sense and be feasible for the session-manager-plugin to detect an unresponsive endpoint and end the session-manager-plugin process itself, returning control to the parent process?
I recognize that there are many factors to consider; for example, how long to wait before considering the endpoint unresponsive, or whether to allow overriding that time to wait.
If it is decided that this behavior is not worth supporting, could documentation be added to state that session-manager-plugin will never terminate itself when the endpoint becomes unresponsive? At least that would provide some official documentation that I can point to in my projects.
I am unsure whether this issue should go here or in the Systems Manager forums, since it depends on what end you guys feel the issue should be handled.
This issue is independent of https://github.com/aws/session-manager-plugin/issues/6, but a solution to that issue would minimize the need for a solution to this issue.
My use case
I am connecting to ECS Fargate containers via session-manager-plugin. I have been using session-manager-plugin directly, but the issue is also reproducible with aws ecs execute-command.
If I have an open session with one of my containers and then the container dies, my shell session will freeze. I can go to the AWS Systems Manager Session Manager dashboard and manually terminate the session, which will return control of my shell to me.
It would be much more convenient in my eyes for the session-manager-plugin itself to detect an unresponsive endpoint and automatically end itself.
This behavior can be reproduced by starting up an ECS Fargate task with the execute agent enabled and with an entrypoint of sleep 180, then connecting with session-manager-plugin and waiting 3 minutes. At that point, the session-manager-plugin shell will become unresponsive.
My session-manager-plugin version is 1.2.339.0.
My containers are running on Fargate platform version 1.4.0.

Hi @stevenpitts,
Currently we had not support the request of #6 feature request. Not auto terminate sessions considering some single command session will keep no response for a while. But we have an idle time out feature, could you check will it help in your case, https://docs.aws.amazon.com/systems-manager/latest/userguide/session-preferences-timeout.html
In default it is 20mins, you can change it to a short value.
Thanks,
Yangtao

Hey @Yangtao-Hua ,
That makes sense. Using the idle timeout is a good idea for a workaround, but unfortunately it looks like it's an account-wide setting (rather than a setting that can be passed to a single session-manager-plugin session), which isn't ideal. It's too bad #6 isn't getting supported.
I do appreciate the suggestion, and hopefully it'll help someone else who comes across this issue!


remove unused imports from notebooks

This PR proposes removing unused imports in the example notebooks.
Unused imports make these notebooks worse in the following ways:

increase memory footprint
increase load time
distract and confuse users
introduce unnecessary risk of notebook breaking if an import fails (like if from thing import whatever fails because whatever is removed from thing)

I couldn't think of a good way to easily check for these in CI. We could do something gross where all the notebooks are converted to .py files and then checked with pylint or flake8 but I think that could take a lot of effort. So for now, this PR just cleans some things up and doesn't introduce tests to prevent them from creeping back in in the future.

We could do something gross where all the notebooks are converted to .py files and then checked with pylint or flake8 but I think that could take a lot of effort.

I imagine the work that @bhperry has done on integration tests is most of the way there. Maybe it'd make sense to add some linting over there.

We could do something gross where all the notebooks are converted to .py files and then checked with pylint or flake8 but I think that could take a lot of effort.

I imagine the work that @bhperry has done on integration tests is most of the way there. Maybe it'd make sense to add some linting over there.

Yeah just waiting on the new release builds to get into main before merging in the updates to integration-tests. They are already converting every example notebook to a python file, so we could definitely add linting there.

In my humble opinion, integration tests are way too late to find out about linting problems and it's preferable to do it in this project's on-every-commit CI to prevent problematic code from being merged in.
I think it would be annoying to be running those integration tests on the way to a release, and only then discover some linting issue that you have to come back and fix in the repo.

I think it would be annoying to be running those integration tests on the way to a release, and only then discover some linting issue that you have to come back and fix in the repo.

100% agree.
I was imagining the integration tests running on a cron job and warning about linting issues as they chug along. But you are right that doesn't sound very helpful. Probably was should just steal ideas from the integration test repo if/when we want to automate this.


why mxnet do not have split layer like caffe

Caffe use InsertSplits to add split layer implicit ， why mxnet do not have it for googlenet
I need to know to accelerate the split proedure

mxnet supports split a layer.

the question is mxnet hwo to support split a layer, I debug but not found ?

To be more specific, concat backward will call Split explicitly. But in googlenet, even pooling to inception module will require split implicitly because multiple top. Does Mxnet support the implicitly insert split layers? How?

mxnet doesn't split in forward as it's not needed. In backward gradient from multiple paths are aggregated automatically

Eric, where is the code to trigger what to be called for aggregation in backward? It should not be automatic. If I implemented a MKL elementwise-sum, it will be called. But I don't know how it is being called, actually I want to use another API to do that split bwd, but don't know where to put the code...

in executor it uses ElementWiseSum for this


Allow using database as postgresql for cloud8

Why would you want it?

e.g. because we want to allow SOC7 users to migrate to SOC8 and that can be very hard if they have to switch the DB for that.

@bmwiedemann AFAIK the plan is to only provide postgresql backend with Cloud8 together with some migration tool
But @sjamgade PR might make sense for comparing the performance

-ENODESCRIPTION
Please add a description next time.

This broke HA jobs: https://ci.suse.de/job/openstack-mkcloud/87206/console
https://github.com/SUSE-Cloud/automation/blob/43f01f870168bf28e5b0f5cdc53944a3f7904ffa/scripts/qa_crowbarsetup.sh#L2048-L2050


⚠ Samsung has degraded performance

In 925f6f8, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 2574 ms

Resolved: Samsung performance has improved in 211709e.


installation error

terrascan version:
latest (v1.15.2)

Operating System:
Ubuntu 22.04.1 LTS

Description
Terrascan installation unsuccessful
Describe what you were trying to get done.
I am trying to install terrascan on Ubuntu and getting this error with installation
What I Did
I followed Step1: install as native executable from this link https://github.com/tenable/terrascan#install-as-a-native-executable
Paste the command(s) you ran and the output.
anshul@aanandpc2:/mnt/c/dev/aws$  curl -L "$(curl -s https://api.github.com/repos/tenable/terrascan/releases/latest | grep -o -E "https://.+?_Darwin_x86_64.tar.gz")" > terrascan.tar.gz
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100 21.0M  100 21.0M    0     0  7327k      0  0:00:02  0:00:02 --:--:-- 9412k
anshul@aanandpc2:/mnt/c/dev/aws$ tar -xf terrascan.tar.gz terrascan && rm terrascan.tar.gz
anshul@aanandpc2:/mnt/c/dev/aws$ sudo install terrascan /usr/local/bin
[sudo] password for anshul:
anshul@aanandpc2:/mnt/c/dev/aws$ terrascan
-bash: /usr/local/bin/terrascan: cannot execute binary file: Exec format error
anshul@aanandpc2:/mnt/c/dev/aws$

my bad..I was using Darwin_x86_64 instead of Linux

same thing, thx for pointing out the installation method is for darwin :)


Exporting meshes with cloth physics breaks the physics

For example, when exporting grand cuirass (015) which is largely plate armor with a cloth skirt, the result is this:

Additionally, the skirt will be completely static. Doesn't seem to matter whether any changes have been made to the model before exporting; even when just importing -> exporting it seems to be problematic.
Also tried with a mage robe, eminent coat (008), which produces similar results for the bottom (i.e. waist down) part of the robe.

I confirm I can reproduce the issue with any armor with physics, I think I know what's missing in the exporter however I need to think about how to store that data when importing a mesh file in blender. It might take some time unfortunately.

The problem was twofold, mesh files have some secondary weight array that seems to be used for physics-related stuff: it's now added at import to the meshes in new weight groups with the "SHAPEKEY_" prefix, and used at export when present. If values are missing, those from the regular weight array are used.
That fixes the issue of parts of the armors flying away in the distance (presumably toward the origin of the map), however it seems meshes that use physics also use a secondary file (.gpuc.231011972) that seems to maps for each vertices of the meshes: so if any vertex is added or removed (removing LoD meshes counts too), subsequent vertices will be broken.
If that is truly what is causing the broken mesh issue, since handling this file format isn't supported for now, editing the concerned armor pieces that will require either to not add or remove geometry, or to disable the .gpuc file by modifying the .pfb associated to the armor.

Yep, it's exactly as you say; parts of the armor flying away is fixed, but adding or removing geometry breaks the mesh. However, a workaround to removing geometry for the time being is simply to set the scale for the part in question to 0, effectively making it invisible.


++ Syntax for adding vertex with sugar.

nice one, thank you!

I don't like this syntax because it took me 5-10 min to understand what's happening.
I think we should be careful about the understandability when introducing symbol based functions and not fall into a code that no one understand except yourself.
I take for example: List("1", "2", "3").foldLeft("")((a, b) => a + b)
can also be written (List("1", "2", "3") /: "")((a, b) => a + b)
But everyone agreed that this syntax is bullshit.
You should watch Martin Odersky speaking about that @ 1:02:30: https://www.parleys.com/tutorial/keynote-scala-style
In Scala ++ is usually a concatenation operator and here we are not concatenating at all.
I would maybe suggest to change for a simple + that usually means "add".

Would you be better with + ?  If we fall back to text then we should just remove it "add" it no better than "addVertex".
    val g = TinkerGraph.open.asScala
    g + (software, blueprints, _2010)
    g.V.has(blueprints).head <-- dependsOn --- (g + (software, gremlin, _2009))
    g.V.has(gremlin).head <-- dependsOn --- (g + (software, gremlinScala))
    g.V.has(gremlinScala).head <-- createdBy --- (g + (person, mpollmeier))
```
vs
```scala
    val g = TinkerGraph.open.asScala
    g + (software, blueprints, _2010)
    g.V.has(blueprints).head <-- dependsOn --- g.addVertex(software, Map(gremlin, _2009))
    g.V.has(gremlin).head <-- dependsOn --- g.addVertex(software, Map(gremlinScala))
    g.V.has(gremlinScala).head <-- createdBy --- g.addVertex(person, Map(mpollmeier))
```

Yes it would be better with a + although I don't really get what's the advantage over addVertex except less chars.
I'm not sure to understand this sentence:
"If we fall back to text then we should just remove it "add" it no better than "addVertex"."
Second thing is why did you put those functions in a implicit class? Why not directly in ScalaVertex?
Third thing the properties: (String, Any)*:
I don't know if it's good or not but we should agree on one notation and keep this notation across the all API. The user will be confused if he has to switch between the 2 notations.
I personally prefer the explicit Map because it's more clear when reading the code whereas when I read g + (software, gremlin, _2009) I have to guess that the first parameter is actually the label and the following is the properties.

Good points Joan. You're right, it's not always a good idea to have symbolic names and fold is a good example where it's not. In this case I'm with Daniel though, I think it's great to have a shorter alternative to add a vertex. You're right, ++ is probably not the best choice, but I don't have a problem with +.
Re properties: (String, Any)* I first had the same thought as you Joan, but when I saw the Spec it made sense, as "someKey" -> "someValue" is also a tuple. Your example g + (software, gremlin, _2009) wouldn't compile, right? It would have to be g + (software, (gremlin, _2009)) or better g + (software, gremlin -> _2009)
I agree that we should agree on one notation, either tuples or maps. Joan votes for Map. Any preference @dkrieg  @omidb?

Agreed on the + notation.
In he's case he did:
val gremlin = blabla -> blublu
val _2009 = whatever-> everwhat
g + (software, gremlin, _2009)

that's why it's working.
We can probably add both notation everywhere except in the implicit left and double arrow:
https://github.com/mpollmeier/gremlin-scala/blob/master/gremlin-scala/src/main/scala/gremlin/scala/package.scala#L104
And lastly can we move the introduced function:
https://github.com/mpollmeier/gremlin-scala/blob/master/gremlin-scala/src/main/scala/gremlin/scala/package.scala#L117
in ScalaVertex and remove the implicit class as it is useless here and cause implicit conflict with the StringLike.+ implicit.

Here are my thoughts:
First, the following API does not allow me to add T.label -> "something" and "label" -> "something" does not actually cause "something" to be set as the label
  def addVertex(properties: Map[String, Any]): ScalaVertex = {
    val v = addVertex()
    v.setProperties(properties)
    v
  }

The following + methods does allow me to add T.label -> "something"
  def +(properties: Map[Any, Any]): ScalaVertex =
    graph.addVertex(properties.flatMap(p => List(p._1, p._2)).asInstanceOf[Seq[Object]]: _*)

  def +(properties: (Any, Any)*): ScalaVertex =
    graph.addVertex(properties.flatMap(p => List(p._1, p._2)).asInstanceOf[Seq[Object]]: _*)

and for usage comparison:
  it("has - sugar 1") {
    def name(n: String) = "name" -> n
    def created(n: Int) = "created" -> n
    def label(n: String) = T.label -> n

    val g = TinkerGraph.open.asScala
    g + (label("software"), name("blueprints"), created(2010))
    g.V.has(name("blueprints")).head <-- "dependsOn" --- (g + (label("software"), name("gremlin"), created(2009)))
    g.V.has(name("gremlin")).head <-- "dependsOn" --- (g + (label("software"), name("gremlinScala")))
    g.V.has(name("gremlinScala")).head <-- "createdBy" --- (g + (label("person"), name("mpollmeier")))

    g.V.toList().size shouldBe 4
    g.V.hasLabel("software").toList().size shouldBe 3
    g.V.hasLabel("person").toList().size shouldBe 1

    g.E.toList().size shouldBe 3
    g.E.hasLabel("dependsOn").toList().size shouldBe 2
    g.E.hasLabel("createdBy").toList().size shouldBe 1
  }

  it("has - sugar 2") {
    def name(n: String) = "name" -> n
    def created(n: Int) = "created" -> n
    def label(n: String) = T.label -> n

    val g = TinkerGraph.open.asScala
    g + Map[Any, Any](label("software"), name("blueprints"), created(2010))
    g.V.has(name("blueprints")).head <-- "dependsOn" --- (g + Map[Any, Any](label("software"), name("gremlin"), created(2009)))
    g.V.has(name("gremlin")).head <-- "dependsOn" --- (g + Map[Any, Any](label("software"), name("gremlinScala")))
    g.V.has(name("gremlinScala")).head <-- "createdBy" --- (g + Map[Any, Any](label("person"), name("mpollmeier")))

    g.V.toList().size shouldBe 4
    g.V.hasLabel("software").toList().size shouldBe 3
    g.V.hasLabel("person").toList().size shouldBe 1

    g.E.toList().size shouldBe 3
    g.E.hasLabel("dependsOn").toList().size shouldBe 2
    g.E.hasLabel("createdBy").toList().size shouldBe 1
  }


player cannot choose a spot that is already taken

Added in method is_spot_taken to check whether player_one or player_two mark is already in the spot they chose.  If so, an error message will return to let them know to pick another spot.

Changed the code in a different branch instead.


Add new school

Add university of san buenaventura Bogotá https://www.usbbog.edu.co/

@jhoyberrocal I am sorry for a delay with processing your request.
Pull request merged. Thank you!


marked drawn shapes as active

marked drawn shapes as active, to be able to identify &
delete/manipulate them from outside the library.
Now I can do:
`$(document).on('keyup', function (evt) {
//might need to filter based on target
if (evt.keyCode == 46) { //delete
var removed = false;
_.each(['length', 'ellipticalRoi', 'rectangleRoi', 'angle', 'probe'],
function (shape) {
var data = (cornerstoneTools.getToolState(rawElement, shape) || {}).data
|| [];
for (var idx = data.length - 1; idx >= 0; idx--) {
if (data[idx].active) {
data.splice(idx, 1);
removed = true;
}
}
});
if(removed)
cornerstone.updateImage(rawElement);
}
});`

Hello!
I like the goal: Press delete to remove a tool, but there are some issues with the PR:
A few small things:

The spacing on all the data.active statements is not in-line with the rest of the code in the same block
You are using a copy/pasted version of pointNearTool for the probe tool. The one you pasted is used to calculate the distance between a point and a rectangle, so it is not appropriate for the probe tool. You should change it to something like cornerstoneMath.point.distance (https://github.com/chafey/cornerstoneMath/blob/master/src/point.js#L33) in order to calculate the distance between the cursor and the probe tool.

By the way, you can use github flavoured markdown to print code more nicely:
https://help.github.com/articles/github-flavored-markdown/#syntax-highlighting
$(document).on('keyup', function(evt) {
    //might need to filter based on target
    if (evt.keyCode == 46) { //delete
        var removed = false;
        _.each(['length', 'ellipticalRoi', 'rectangleRoi', 'angle', 'probe'],
            function(shape) {
                var data = (cornerstoneTools.getToolState(rawElement, shape) || {}).data || [];
                for (var idx = data.length - 1; idx >= 0; idx--) {
                    if (data[idx].active) {
                        data.splice(idx, 1);
                        removed = true;
                    }
                }
            });

        if (removed)
            cornerstone.updateImage(rawElement);
    }
});

@ra00l - Thanks for your contribution!

I've got some more goodies, like deleting the highlight shape. But need to make a bit of time for it, maybe tomorrow.
Thanks for accepting the contribution.
Sent from my Phone
-----Original Message-----
From: "Erik Ziegler"<EMAIL_ADDRESS>Sent: 21.05.2015 14:06
To: "chafey/cornerstoneTools"<EMAIL_ADDRESS>Cc: "ra00l"<EMAIL_ADDRESS>Subject: Re: [cornerstoneTools] marke highlighted shapes as active.Possibility to delete/manipulate selection (#41)
@ra00l - Thanks for your contribution!
—
Reply to this email directly or view it on GitHub.

There are some improvements coming for clearing specific / global tools. I'm actually in the process of merging it right now. See #40.


Integrate Create new snippet with backend

Create an api  - /api/snippets/createsnippet
on the save button click save details to the mongo db - snappit

Sure go ahead

I have finished the implementation and created pull request. Could you review it ?

Hi last week I updated the pull request, please check


Widget (still) shows tasks with future start date

I am sorry, but since you fixed #29 and I updated to the latest release all future events are shown in the widget again. Actually this bug was fixed for me months ago...
I am using CaldDAV-Sync 0.4.22 (AndroitPIT) and Tasks 1.1.5 with my personal OwnCloud.

I was able to solve the problem by choosing different start and end dates. If both are identical future tasks are shown in the widget. Is it a bug or a feature?

Ah yes, that's actually a feature. We implemented it that way to support tasks created on Apple clients. Apple clients always set the start date to the due date.


[SPARK-12656] [SQL] Implement Intersect with Left-semi Join

Our current Intersect physical operator simply delegates to RDD.intersect. We should remove the Intersect physical operator and simply transform a logical intersect into a semi-join. This way, we can take advantage of all the benefits of join implementations (e.g. managed memory, code generation, broadcast joins).
After a search, I found one of the mainstream RDBMS did the same. In their query explain, Intersect is replaced by Left-semi Join. Left-semi Join could help outer-join elimination in Optimizer, as shown in the PR: https://github.com/apache/spark/pull/10566

@rxin Please review the implementation. Thank you!

Which mainstream RDBMS is that?

MS SQL Server did that

LGTM.
cc @cloud-fan to take a look too.

Test build #48900 has started for PR 10630 at commit 0bd1771.

Test build #48900 has finished for PR 10630 at commit 0bd1771.

This patch fails Python style tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/48900/
Test FAILed.

Merged build finished. Test FAILed.

LGTM, pending tests.
It will be good to have some performance numbers for this change :)

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/48907/
Test FAILed.

retest this please.

LGTM.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/48909/
Test FAILed.

Merged build finished. Test FAILed.

Test build #2342 has started for PR 10630 at commit 6742984.

Test build #48912 has started for PR 10630 at commit 6742984.

@cloud-fan Sorry, I am still requesting a resource to do the performance testing. Unfortunately, I am unable to get it very recently. I am also highly interested in the performance number when running a large-scale workload in a distributed environment. Will keep you posted if it is done. Thanks!

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/48911/
Test FAILed.

Test build #48916 has started for PR 10630 at commit e4c34f0.

Test build #48916 has finished for PR 10630 at commit e4c34f0.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/48916/
Test PASSed.

Merged build finished. Test PASSed.

Test build #48912 has finished for PR 10630 at commit 6742984.

This patch fails from timeout after a configured wait of `250m`.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/48912/
Test FAILed.

retest this please

Test build #48947 has started for PR 10630 at commit e4c34f0.

How about we hold on it a little bit? I am not sure the plan is right.

Should we provide users one more Dataframe/SQL API INTERSECT ALL, which can be converted to Left-semi Join? Thank you! @yhuai @rxin @nongli @cloud-fan @marmbrus

Test build #48947 has finished for PR 10630 at commit e4c34f0.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Also did a research in the SQL standard. Below is the SQL2003 Syntax
<SELECT statement1>
INTERSECT [ALL | DISTINCT]
[CORRESPONDING [BY (column1, column2, ...)]] <SELECT statement2>
INTERSECT [ALL | DISTINCT]
[CORRESPONDING [BY (column1, column2, ...)]]
...

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/48947/
Test PASSed.

It's reasonable to support intersect all. We should do that as a separate ticket though.

After the merge, will submit another PR to support it. Thanks!

Test build #49007 has started for PR 10630 at commit 27192be.

In this update, the code changes include

Added DISTINCT on top of Semi Join for Intersect
Added a test case for detecting if the duplicate values are removed after Intersect
Threw an exception if the Intersect is not converted before conversion from logical plan to physical plan
Merge two rules ReplaceIntersectWithSemiJoin and ReplaceDistinctWithAggregate in the same batch "Replace Operators" for ensuring ReplaceIntersectWithSemiJoin should be called before ReplaceDistinctWithAggregate

Test build #49007 has finished for PR 10630 at commit 27192be.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/49007/
Test FAILed.

retest this please

Test build #49008 has started for PR 10630 at commit 27192be.

Test build #49008 has finished for PR 10630 at commit 27192be.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/49008/
Test FAILed.

Both failure are not related to this PR. They are caused by the test case randomSplit on reordered partitions in https://github.com/apache/spark/pull/10626. Thanks!

Test build #49012 has started for PR 10630 at commit a932cdb.

Test build #49012 has finished for PR 10630 at commit a932cdb.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
class JavaSampleActorReceiver<T> extends JavaActorReceiver
public class JavaActorWordCount
abstract class ActorReceiver extends Actor
abstract class JavaActorReceiver extends UntypedActor

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/49012/
Test FAILed.

Merged build finished. Test FAILed.

Found the root cause of this failure. We also need to change the analyzer to handle duplicate expression ids.

The latest update is for resolving the ambiguous attributes, which could trigger invalid predicate pushdown by the Optimizer rule PushPredicateThroughJoin. The solution is the same as what we are doing for self join in analyzer.
Thank you!

Test build #49020 has started for PR 10630 at commit 04a26bd.

Test build #49020 has finished for PR 10630 at commit 04a26bd.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class Intersect(left: LogicalPlan, right: LogicalPlan) extends SetOperation(left, right)

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/49020/
Test PASSed.

Test build #49038 has started for PR 10630 at commit f820c61.

In this update, the code changes include

Fixed a bug in Range by inheriting the trait MultiInstanceRelation.
Added a de-duplication resolution for all the binary nodes: Except, Union and Co-Group, besides Intersect and Join.
Added a new function duplicateResolved for all the binary nodes.
Improved the analysis exception message when failure to resolve conflicting references
Resolved all the other comments.

The analysis procedure is kind of tricky. I am unable to directly include duplicateResolved into childrenResolved. resolve is lazy evaluated. The resolution procedure need to follow the order: children at first, then itself, and then deduplicate the attributes' expression IDs in tis children.

Test build #49039 has started for PR 10630 at commit 4372170.

Test build #49039 has finished for PR 10630 at commit 4372170.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/49039/
Test PASSed.

Test build #49038 has finished for PR 10630 at commit f820c61.

This patch fails from timeout after a configured wait of `250m`.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class Intersect(left: LogicalPlan, right: LogicalPlan) extends SetOperation(left, right)

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/49038/
Test FAILed.

retest this please

Test build #49044 has started for PR 10630 at commit 4372170.

Test build #49044 has finished for PR 10630 at commit 4372170.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/49044/
Test PASSed.

@gatorsmile there is a conflict now - mind bringing it up to date?

sure, let me do it tonight.

When resolving the conflicts, I realized the multi-children Union might have duplicate exprId. So far, I did not add a function to de-duplicate them. This is not a trivial work, if needed. When the children has hundreds of nodes, it is infeasible to use the current per-pair de-duplication. That means, we need to rewrite the whole function dedup.
Let me know if we need to open a separate PR to do it now. So far, unlike Intersect, we did not hit any issue even if there exist duplicate exprId values. Thanks!

Test build #49936 has started for PR 10630 at commit 6a7979d.

Test build #49936 has finished for PR 10630 at commit 6a7979d.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/49936/
Test PASSed.

Merged build finished. Test PASSed.

I don't think its a problem for there to be conflicting attribute ids for set operations, this is because only on childs attribute references need to be propagated up (unlike with a join).

Yeah, agree! Thank you!

Test build #50176 has started for PR 10630 at commit e566d79.

Test build #50176 has finished for PR 10630 at commit e566d79.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/50176/
Test PASSed.

Test build #50257 has started for PR 10630 at commit 3be78c4.

Test build #50257 has finished for PR 10630 at commit 3be78c4.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/50257/
Test FAILed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/50298/
Test FAILed.

retest this please

Test build #50313 has started for PR 10630 at commit e51de8f.

Test build #50313 has finished for PR 10630 at commit e51de8f.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
abstract class SetOperation(left: LogicalPlan, right: LogicalPlan) extends BinaryNode

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/50313/
Test PASSed.

LGTM. we can merge it first and @gatorsmile can address remaining comments in a follow-up PR.

This is not that big. Let's just do it together here.

Thank you! Just cleaned the codes. : )

LGTM, pending test

Test build #50368 has started for PR 10630 at commit b600089.

Test build #50368 has finished for PR 10630 at commit b600089.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/50368/
Test PASSed.

Merged build finished. Test PASSed.

Thanks - I'm going to merge this.


Retry Auth

I've been getting these 403s a couple times a day for not constant enough to determine a pattern. Might be an edge case around auth an retying downloads?
2017/01/11 15:30:58 Downloading: 'PCF Metrics' to file: '/tmp/build/get/apm-1.2.4.pivotal'
 983.72 MB / 1.07 GB   90.00% 3m17ss
2017/01/11 15:34:16 Download failed: failed during retryable request: during GET unexpected status code was returned: 403
ERROR: failed during retryable request: during GET unexpected status code was returned: 403

@Osis - interesting, we should probably add more debug logging around the retryable request so we can see what is going on.

@Osis we've improved the retry logic a lot and seen improvements in various teams' pipelines, so I'm going to close this out, but please feel free to re-open if you continue to observe issues.


Added support for keyword-only arguments on Python 3+

Pull Request Check List

[x] Added tests for changed code.
[x] New features have been added to our Hypothesis testing strategy.
[x] Updated documentation for changed code.
[x] Documentation in .rst files is written using semantic newlines.
[x] Changed/added classes/methods/functions have appropriate versionadded, versionchanged, or deprecated directives.
[x] Changes (and possible deprecations) have news fragments in changelog.d.

Please, correct me if I checked something wrong.

@hynek I decided to go with a dedicated attr.ib() argument for the sake of simplicity: I don't like to overload init with more options than a simple on/off switch.
But if you think this is a bad API, let's discuss a better approach.

Wow, thanks for tackling this!
Before I dive deeper and start nitpicking:

please make it kw_only it’s more readable and I’d like to set the precedent of not smashing words together German-style. :)
There was an example of how to solve this problem for Python 2: https://github.com/python-attrs/attrs/issues/106#issuecomment-315690579 and I think it’s worth pursuing.  No need to make the feature Python 3-only and it should be rather easy to add?  If you run into any problems implementing it, we can always back out again.

please make it kw_only

Done.

There was an example of how to solve this problem for Python 2: https://github.com/python-attrs/attrs/issues/106#issuecomment-315690579  and I think it’s worth pursuing. No need to make the feature Python 3-only and it should be rather easy to add? If you run into any problems implementing it, we can always back out again.

Or we could make Python 3 transition slightly faster :) With no jokes, although I'm against of supporting such unique Python 3 features on Python 2 I'll try to implement this fallback anyway.

Ohhh…so you implemented it only on a per-attribute basis instead of per-class?

(JFTR I have zero qualms leaving Python 2 behind in 2017 if the cost exceeds a certain threshold)

Ohhh…so you implemented it only on a per-attribute basis instead of per-class?

Yes. In my opinion, if we have a per-attribute way of specifying keyword-only attributes making a whole class keyword-only is easy:
from functools import partial
kw_attrib = partial(attr.ib, kw_only=True)
@attr.s
class Foo:
    bar = kw_attrib()
    baz = kw_attrib()

But maybe an additional attr.s option (kw_only) is worth implementing. I don't know, I feel no evil with partial approach.

(BTW, I don't understand why codecov report says the coverage decreased. These lines do not seem to correlate with my changes.)

@hynek regarding Python 2 emulation of keyword-only arguments, I've found https://github.com/pasztorpisti/kwonly-args.
Although it works to some extent, it's still doesn't exactly match Python 3 behavior:
Python 2.7.14 (default, Oct  8 2017, 18:34:38)
[GCC 4.2.1 Compatible Apple LLVM 8.1.0 (clang-802.0.38)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> from kwonly_args import first_kwonly_arg, KWONLY_REQUIRED
>>> @first_kwonly_arg('b')
... def foo(a, b=KWONLY_REQUIRED, c=KWONLY_REQUIRED, d=4):
...   pass
...
>>> foo()
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/Users/malinoff/Projects/opensource/attrs/venv27/lib/python2.7/site-packages/kwonly_args/__init__.py", line 108, in wrapper
    ', '.join(sorted(missing_kwonly_args))))
TypeError: foo() missing 2 keyword-only argument(s): b, c
>>> foo(1, 2, 3)
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/Users/malinoff/Projects/opensource/attrs/venv27/lib/python2.7/site-packages/kwonly_args/__init__.py", line 108, in wrapper
    ', '.join(sorted(missing_kwonly_args))))
TypeError: foo() missing 2 keyword-only argument(s): b, c

vs
Python 3.6.1 (default, May 29 2017, 09:11:03)
[GCC 4.2.1 Compatible Apple LLVM 8.1.0 (clang-802.0.38)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> def foo(a, *, b, c, d=4):
...   pass
...
>>> foo()
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
TypeError: foo() missing 1 required positional argument: 'a'
>>> foo(1, 2, 3)
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
TypeError: foo() takes 1 positional argument but 3 were given

And the implementation is scary enough for me not wanting to translate it into the list of lines used to generate the __init__ body. Maybe somebody else has courage to do so.
What do you think about adding this as a Python 3 only feature for now?

Rebased onto master.

@Tinche since you've been pretty active in the referenced issues, I'd like to hear your opinion too.

As I’ve said, I don’t mind leaving Python 2 behind if it means too much work.  @Tinche is currently having a life-or-death battle with a manflu, but this won’t make 17.3 anyways, so no pressure. :)

@malinoff Implementing the additional @attr.s option would be make this work nicely with @attr.s(auto_attribs=True), or am I overlooking something? I.e. it would remove the need for attr.ib calls..
Quoting an usage example from the docs
>>> import typing
>>> @attr.s(auto_attribs=True)
... class AutoC:
...     cls_var: typing.ClassVar[int] = 5  # this one is ignored
...     l: typing.List[int] = attr.Factory(list)
...     x: int = 1
...     foo: str = attr.ib(
...          default="every attrib needs a type if auto_attribs=True"
...     )
...     bar: typing.Any = None

@leezu having only an attr.s option locks you between def foo(a, b, c=3): and def foo(*, a, b, c=3):.
Having an attr.ib option gives you enough flexibility: def foo(a, *b, c=3): and allows to implement the corresponding attr.s option for short-cut and convenience.
Also, I've opened this PR before 17.3 have been released, so I couldn't take auto_attribs into account at that time.
@hynek @Tinche, since 17.3 was cut off, could you please take a closer took at this PR?

would it be acceptable for python2 support to use a **kw_somewhat_unreadable_123 name combined with a funcsigs2 signature object that would return the complete signature for correctness ?
(given that popping from the dict + asserting can work, but the signature would suck

@malinoff essentially I would like to avoid writing out attr.ib for every attribute (based on auto_attribs=True), but still be able to use keyword-only arguments.

Having an attr.ib option gives you enough flexibility: def foo(a, *b, c=3): and allows to implement the corresponding attr.s option for short-cut and convenience.

Do you mean the kw_attrib partial? It doesn't allow avoiding attr.ib (or well, now kw_attrib).
You can argue that using keyword-only arguments is an advanced use-case, so it should require the "more complex" attr.ib syntax instead of the type hint based syntax with auto_attribs=True. I think otherwise, but please let me know if you disagree.

having only an attr.s option locks you between def foo(a, b, c=3): and def foo(*, a, b, c=3):

What about not "only an attr.s option" but an "shortcut attr.s option" which defaults to def foo(*, a, b, c=3) and more complex use-cases can be implemented via the corresponding attr.ib calls?

@leezu

What about not "only an attr.s option" but an "shortcut attr.s option" which defaults to def foo(*, a, b, c=3) and more complex use-cases can be implemented via the corresponding attr.ib calls?

That's what I mean in my previous reply.

Sorry for bursting into your conversation, but I hope it's related enough.
Will this PR (or combined with anything else already implemented) allow me to use attrs for something similar to this use case:
class A:
    def __init__(self, **kwargs):
        for key in kwargs:
            setattr(self, key, kwargs[key])

I guess it's more related to your plan to add an option to attr.s and not the attr.ib one.

I see this is not implemented in the code yet, will it be a part of version 17.4?

Unlikely, 17.4 is gonna be a mostly (overdue) bug fix release that should drop next week if nothing comes up.

@malinoff Is there anything else that needs to happen with this PR? I'm happy to take over the branch to try to get it in if you don't have the time).
(Although for my own use-case, I just need the class-level kw_only flag, but not the attr.ib level flag).

See also python/cpython#6238

I'm okay to finish the PR by myself, I just don't understand what else should be implemented/fixed.

@hynek Can you comment on what else needs to happen here (other than the merge conflicts obviously)? Is this blocked on the design issue of the whether this should also be an attr.s option?
(FWIW @malinoff I really would like the attr.s option so this works nicely with auto_attribs).

Sorry to be a bother, but bump @hynek

fixed by #411


[mobile] page cut off on certain claims

See https://odysee.com/@HighImpactFlix:ca/ObamaClintonBushBigPharma:c on mobile

Pushed up a fix for description issues, but still think they exist on other areas:

Hi, so in the description area of the page, I tried on my browser putting the CSS property 'overflow-wrap: anywhere;' on  the element with the class name of 'card__main-actions', which seems to fix the overflow issue, at least on the video page i tested it on.

issue is that in the comments, there is 1 comment '@celesteplantagenet-york 2 months ago' which is an inline element. These two elements are too long next to each other in mobile view and exceed the width of the parent container.

Also happens on: https://odysee.com/@timcast:c9/biden-admin-seeks-to-fire-fauci-amid:1 on iOS

I have this issue all the time. Makes the mobile experience pretty poor.
This worked in Chrome Dev Tools, but I've not tried it on a live site as rendered code.
@media only screen and (max-width: 375px) {
.file-page__secondary-content {
    transform: scale(0.8);
    transform-origin: top;
}}

Probably not the best approach, but if it works live, might be a good solution for now.
* That's just for the iPhone X size. Needs calibrating for all sizes that are affected.


fix: stabilize sporadically failing Control Tower setup

by retrying the setup of Control Tower in case of failure.
Definition of done (v0.0.2)

[x] Automated integration test

superseded by https://github.com/superwerker/superwerker/pull/259


Build error with build id #9274652

Details:

Project URL: https://readthedocs.org/projects/PyScada/
Build URL(if applicable): https://readthedocs.org/projects/pyscada/builds/9274652/
Read the Docs username(if applicable): trombastic

Expected Result
A description of what you wanted to happen
Actual Result
A description of what actually happened

Hi, this is because your project has some unused submodules in https://github.com/trombastic/PyScada/blob/master/.gitmodules, see #4371

Thank you very much!


react-native: node:http could not be found

Environment

react-native: 0.71.0
ofetch: 1.1.0

Reproduction

Start a react-native project
yarn add<EMAIL_ADDRESS>Add a request: ofetch('www.example.com')
Notice the bug

Describe the bug
I just tried this on react-native (after #206) and it looks like it does not work because of node:http:

node:http could not be found within the project or in these directories

Additional context
No response
Logs
error: Error: Unable to resolve module node:http from /homer/user/project/node_modules/ofetch/dist/node.cjs: node:http could not be found within the project or in these directories:
  node_modules
  ../../node_modules
  1 | 'use strict';
  2 |
> 3 | const http = require('node:http');
    |                       ^
  4 | const https = require('node:https');
  5 | const nodeFetch = require('node-fetch-native');
  6 | const fetch$1 = require('./shared/ofetch.0fda5c9e.cjs');
    at ModuleResolver.resolveDependency (/homer/user/project/node_modules/metro/src/node-haste/DependencyGraph/ModuleResolution.js:162:15)
    at DependencyGraph.resolveDependency (/homer/user/project/node_modules/metro/src/node-haste/DependencyGraph.js:260:43)
    at Object.resolve (/homer/user/project/node_modules/metro/src/lib/transformHelpers.js:177:21)
    at Graph._resolveDependencies (/homer/user/project/node_modules/metro/src/DeltaBundler/Graph.js:432:35)
    at Graph._processModule (/homer/user/project/node_modules/metro/src/DeltaBundler/Graph.js:218:38)
    at async Graph._addDependency (/homer/user/project/node_modules/metro/src/DeltaBundler/Graph.js:314:20)
    at async Promise.all (index 0)
    at async Graph._processModule (/homer/user/project/node_modules/metro/src/DeltaBundler/Graph.js:263:5)
    at async Graph._traverseDependenciesForSingleFile (/homer/user/project/node_modules/metro/src/DeltaBundler/Graph.js:207:5)
    at async Graph.traverseDependencies (/homer/user/project/node_modules/metro/src/DeltaBundler/Graph.js:147:9)

Try to upgrage your NodeJS version.

(reopening to try on react native. if they don't support this, we might use an export condition)


[OSD-2358] Removing allowFirst field

What type of PR is this?
(refactor)
What this PR does / why we need it?
Based on OSD-2358, this PR removes the allowFirst field from subjectPermission types and CRD because the AllowFirst field is no longer needed/being used
Which Jira/Github issue(s) this PR fixes?
Fixes # OSD-2358
Special notes for your reviewer:
Pre-checks (if applicable):

[ ] Tested latest changes against a cluster
[ ] Included documentation changes with PR

/hold

/unhold

Thank you @reedcort , we will review this.
Will there be a companion PR to managed-cluster-config to update all the SubjectPermissions that are currently specifying this field?

Do a text search within the repo, there are several places are still referring to the allowFirst, like:
pkg/utility/namespaces.go
pkg/utility/namespaces_test.go
pkg/dedicatedadmin/dedicatedadmin.go

Not sure if they should be cleaned up as well.
Out of the scope here, seems the dedicatedadmin package is not being anywhere. I think it should be cleaned as well.
But the real question for this PR is, do we really need to remove this? To me, this just added the ability to alter the default behaviour from the custom resource.
I cannot understand why we have to remove that.
cc @sam-nguyen7 I see you are the reporter for the OSD card. Could you help share some thoughts on this?

Do a text search within the repo, there are several places are still referring to the allowFirst, like:
pkg/utility/namespaces.go
pkg/utility/namespaces_test.go
pkg/dedicatedadmin/dedicatedadmin.go

Not sure if they should be cleaned up as well.
Out of the scope here, seems the dedicatedadmin package is not being anywhere. I think it should be cleaned as well.
But the real question for this PR is, do we really need to remove this? To me, this just added the ability to alter the default behaviour from the custom resource. I cannot understand why we have to remove that. cc @sam-nguyen7 I see you are the reporter for the OSD card. Could you help share some thoughts on this?

OSD-2358 is pretty old (2019/11/05) so trying to refresh my memory on this. Agreed that dedicatedadmin package is no longer in use by this operator and can be removed.
Specifically for this PR, allowFirst was created initially as we were not sure if the default behavior of the CR ever needed to change. The decision was made to always apply the "allow" regex first, allowFirst is no longer needed (eg. changing the allowFirst value to false will not actually apply the deny regex first). In pkg/utility/namespaces.go where allowFirst is being used, the function is also just part of the unused dedicatedadmin package so it can be removed.
We should also update the subjectpermission CRs in MCC as Matt mentioned above. Since this field is not optional, all subjectpermission CRs currently will need to specify it. While we don't have to remove this field for the operator to function properly, OSD-2358 was created as maintenance to remove a field that is no longer needed.

Thank you so much @sam-nguyen7 for the detail information.
So as the current status, I think we could still handle the removal of the allowFirst in the API in this PR, and we can create another JIRA card to track the unused packages clean up.
Also we need to make sure the resources deployed via MCC should be updated accordingly as what Matt pointed out.
@reedcort WDYT?

@bmeng The approach you mentioned works for me I'll create the necessary tickets and PRs for the unused packages and the resources deployed via MCC.
For this PR are there any changes I need to make?

@reedcort sounds good.
One small point, the custom resource example in README.md file is referring to the removed field allowFirst as well. It should be better clean it within the same PR.
Other than that, should be all good!

/lgtm


Backport to V1.x changes made to attachments size check on import.

Thanks, does it means that another V1.X will be released ?

I have to update my Geotrek-admin 0.35.
Not sure if I should use v1.0.0 or include these commits and use https://github.com/makinacorpus/Geotrek/tree/v1.x ZIP ?


[Bug] Doc github page isn't updated

The doc website isn't updated. Looks like it's the case since march 2022 the doc points to this commit https://github.com/casper-ecosystem/casper-js-sdk/commits/7da7c50

That's true, I'm currently working on fixing this and adding inline docs to the README :)

@hoffmannjan Will you do this as part of the current sprint?

It's not blocked, but will be N/A after https://app.zenhub.com/workspaces/engineering-l2-62618a6423afe100128e4656/issues/gh/casper-ecosystem/casper-js-sdk/165 is complete

close this issue in favor of https://github.com/casper-ecosystem/casper-js-sdk/issues/259


Video: Icons always using the only default poster image

Bug Description
Currently, the icons (such as in the Layer panel, in background media, in the Filter panel) are using the default poster image of a video.
If the user changes the poster image, the default poster is still used.

Expected Behaviour
Needs confirmation - is this expected or should we use the custom poster image then?

Steps to Reproduce

Add a video and set custom poster image
Add video as a background.
See the Filter, background media, and Layer panels -- still using the previous.

Screenshots

Additional Context

Plugin Version:
WordPress Version:
Operating System:
Browser:

Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance Criteria

Implementation Brief

Why would we not want to show the poster the user has chosen? Seems very confusing.

Why would we not want to show the poster the user has chosen? Seems very confusing.

IDK. Maybe since the default poster is part of the video and might more accurately display how the video would look like with a filter, for example, whereas the custom poster can be anything.
Assumed it was a bug but wasn't certain if it was purposefully left like this. Will move the issue forward since you also find it confusing.

Verified in QA


Question: How to compile C# WinUI 3 desktop app?

Hi,
I installed Visual Studio Enterprise 2019 Preview 4 few days ago and WinUI 3 Preview 4 extension. I've created brand new C# WinUI blank desktop packaged app, so far so good. The problems started when I tried to build/run the app (with no additional code or controls) - compiler returned WMC999 Cannot find type WinRT.IWinRTObject in module WinRT.Runtime.dll. Then I thought it'd be good try with CsWinRT v. 1.1.0. After adding Microsoft.Windows.CsWinRT package the WMC999 error disappeared but now there's another one: CS0012 The type 'SuspendingEventArgs' is defined in an assembly that is not referenced. You must add a reference to assembly 'Microsoft.Windows.SDK.NET, Version=10.0.18362.10, Culture=neutral, PublicKeyToken=31bf3856ad364e35'. This is what I ended up with. I've installed required Windows SDKs  (17134, 18362 and 19041).
Am I missing something?

@alwu-msft and @stevenbrix this sounds really similar to some issues we've had previously around the vsix not updating the project files with the sdk version, but we can't seem to find those issues.

@StephenLPeters No, I don't think is similar.
@jskop I don't think it should've been necessary to add an explicit reference to CsWinr 1.1.0 as we are already pulling it in for you.
@Scottj1s Any ideas what might be going wrong here?

Here are my VS installations:

Here are my .NET Core skds:

Error message without CsWinRT package:

Error message after adding package:

Hi
I've fixed the issue. I installed x86 .NET 6 alpha some time ago which messed with targeting packs. Project dependencies were pointing to Microsoft.Windows.SDK.NET.Ref 10.0.18362.4-preview which was the root cause of CS0012. Included WinRT.Runtime.dll was also missing WinRT.IWinRTObject.
Anyways thank you for your engagement.
Best Regards,
jskop


Migrate to Merovex.gem

Created Merovex.gem, but cannot use on Dausha.net because GitHub pages won't accept custom theme gems. Using Merovex.gem at Merovex.com


Question: minilm distillation code

Where can I read the Attention Transfer/Value-Relation transfer part of the distillation code?
Loved the paper!
Thanks.

Up!

Can we close this and put +1's and comments in #105 ?


CSS compress incorrect when both set background-color and background-image

Raising from: https://github.com/wilsonzlin/minify-html/issues/132
Optimization level >= 2
Raw css:
        body {
            background-color: #3cb03c;
            background-image: linear-gradient(45deg, limegreen 25%, transparent 25%, transparent 75%, limegreen 75%), linear-gradient(-45deg, limegreen 25%, transparent 25%, transparent 75%, limegreen 75%);
            background-size: 128px 128px;
            background-attachment: fixed;
        }

Output css: (has been reformated)
    body {
        background: #3cb03c;
        background-size: 128px 128px
    }

It seem that background-color replace background-image, but them can be set both.
https://css-tricks.com/css-basics-using-multiple-backgrounds

I have a potentially related issue:
my source file contains a background-image css rule, but the output changes the rule to just background, which changes the behaviour of my css.


[bug] failed to bundle project: error running light.exe

Describe the bug
windows11上打包msi报错

系统环境

tauri.config.json如下
{
  "build": {
    "beforeDevCommand": "pnpm dev",
    "beforeBuildCommand": "pnpm build",
    "devPath": "http://localhost:1420",
    "distDir": "../dist"
  },
  "package": {
    "productName": "xxxxxx",
    "version": "0.0.1"
  },
  "tauri": {
    "allowlist": {
      "all": false,
      "shell": {
        "all": false,
        "open": true
      }
    },
    "bundle": {
      "active": true,
      "targets": "all",
      "identifier": "com.xxx.xxx",
      "icon": [
        "icons/32x32.png",
        "icons/128x128.png",
<EMAIL_ADDRESS>        "icons/icon.icns",
        "icons/icon.ico"
      ]
    },
    "security": {
      "csp": null
    },
    "windows": [
      {
        "fullscreen": false,
        "resizable": false,
        "title": "XXX",
        "width": 800,
        "height": 400
      }
    ]
  }
}

Reproduction
No response
Expected behavior
No response
Platform and versions
[✔] Environment
    - OS: Windows 10.0.22631 X64
    ✔ WebView2: 120.0.2210.61
    ✔ MSVC: Visual Studio Community 2022
    ✔ rustc: 1.74.1 (a28077b28 2023-12-04)
    ✔ cargo: 1.74.1 (ecb9851af 2023-10-18)
    ✔ rustup: 1.26.0 (5af9b9484 2023-04-05)
    ✔ Rust toolchain: stable-x86_64-pc-windows-msvc (default)
    - node: 16.20.2
    - pnpm: 8.12.0
    - npm: 8.19.4

[-] Packages
    - tauri [RUST]: 1.5.3
    - tauri-build [RUST]: 1.5.0
    - wry [RUST]: 0.24.6
    - tao [RUST]: 0.16.5
    - tauri-cli [RUST]: 1.5.7
    - @tauri-apps/api [NPM]: 1.5.2
    - @tauri-apps/cli [NPM]: 1.5.7 (outdated, latest: 1.5.8)

[-] App
    - build-type: bundle
    - CSP: unset
    - distDir: ../dist
    - devPath: http://localhost:1420/
    - framework: React
    - bundler: Vite

Stack trace
No response
Additional context
No response

duplicate of https://github.com/tauri-apps/tauri/issues/8363


Program and Room Tables Spillover

Both the program and room table's selected item get out of visual sync with the model when the tables exceed the maximum number of items specified.


apt package should re-enable itself when a new version is installed if it was disabled by an OS upgrade

For example, upgrading Ubuntu 16.10 to 17.04 will result in the following in /etc/apt/sources.list.d/vscode.list:
# deb [arch=amd64] http://packages.microsoft.com/repos/vscode stable main # disabled on upgrade to zesty

We should check if # disabled on upgrade to ... exists and uncomment it if so.

Verification steps:

Create /etc/apt/sources.list.d/vscode.list with the following contents:
# deb [arch=amd64] http://packages.microsoft.com/repos/vscode stable main # disabled on upgrade to zesty

Install VS Code .deb

Verify /etc/apt/sources.list.d/vscode.list contents match:
deb [arch=amd64] http://packages.microsoft.com/repos/vscode stable main


Cannot resolve symbol 'SwitcherItemLink'

Hi there, think not important but i found this:
https://codesandbox.io/s/right-panel-with-switcher-ye8kg?file=/src/index.js:1547-1563
SwitcherItemLink component not found at 10.13v

😅

Changed
SwitcherItem now imports Link and handles everything SwitcherItemLink did, mimicking HeaderMenuItem
Changed a few propTypes to handle the refactor
See => https://github.com/carbon-design-system/carbon/pull/3209


[AIRFLOW-1229] UI improvement: Make column 'Run id' clickable and jump to DAG 'graph' with execution_date

Dear Airflow maintainers,
I wanted to be able to click trough from DAG-runs to the Dag instance (graph) corresponding to the execution_date of the run. Click on a DAG failed run jump directly to the Graph, its great.
When I finished my change I found a related/existing issue in JIRA from Erik Cederstrand.
https://issues.apache.org/jira/browse/AIRFLOW-1229
So in addition to the execution_date in the URL when clicking a DAG it also includes a new link for the Run-id's.
Description

[x] Here are some details about my PR, including screenshots of any UI changes:

Tests

[x] My PR does not need testing for this extremely good reason:
Simple UI addition, Flask url_for(...) filters empty parameters

Commits

[x] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":

Subject is separated from body by a blank line
Subject is limited to 50 characters
Subject does not end with a period
Subject uses the imperative mood ("add", not "adding")
Body wraps at 72 characters
Body explains "what" and "why", not "how"

Codecov Report

Merging #2801 into master will decrease coverage by <.01%.
The diff coverage is 25%.

@@            Coverage Diff             @@
##           master    #2801      +/-   ##
==========================================
- Coverage   73.42%   73.41%   -0.01%
==========================================
  Files         158      158
  Lines       11958    11962       +4
==========================================
+ Hits         8780     8782       +2
- Misses       3178     3180       +2

Impacted Files
Coverage Δ

airflow/www/views.py
70.89% <25%> (-0.13%)
:arrow_down:

airflow/models.py
87.3% <0%> (+0.04%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e4675ae...69d04bc. Read the comment docs.

Thanks @abij,
I've checked and the commit does not interfere with #2781, which is good.
Could you squash the two commits into a single one. And please refer to the commit guidelines:

Subject is separated from body by a blank line
Subject is limited to 50 characters
Subject does not end with a period
Subject uses the imperative mood ("add", not "adding")
Body wraps at 72 characters
Body explains "what" and "why", not "how"
And please add [AIRFLOW-1229] in front of the title. Thanks!

Looking forward to these additions


Error message points to a documentation page that does not exist

The message

'Invalid setup. See https://tina.io/docs/tina-cloud/connecting-site/ for more information.'

from the error thrown here
https://github.com/tinacms/tinacms/blob/d6af1fafadafec6c9dff0c6b481847c6fe333c5b/packages/tinacms/src/tina-cms.tsx#L165
and here
https://github.com/tinacms/tinacms/blob/d6af1fafadafec6c9dff0c6b481847c6fe333c5b/packages/%40tinacms/cli/src/next/codegen/index.ts#L221
points to page page from the documentation that does not exist anymore and thus results in a 404 error.

Thanks for reporting this, it looks like this was fixed in https://github.com/tinacms/tinacms/pull/4601
I've added a redirect on the docs site in case anyone has an old version that doesn't have the updated links - https://github.com/tinacms/tina.io/pull/1988


Add missing parenthesis in code

A tiny fix to the code in the tutorial I just came across.

Coverage remained the same at 78.215% when pulling 8149d5e1184284ddd8da55e957f2d922bd8b4577 on craiga:develop into eeb1e4712b3866e243daf800c142e2199e4be9df on divio:develop.

thank you @craiga !


M> Fix the English (Original) Transcript Mistakes of "Rchain Exclusive chat Lawrence Lerner & Nash Foster"

The original, English transcript has many mistakes that need fixing.
Completed: 100%

[x] Download the video
[x] Download the English (original) transcript.
[x] Fix the following issues:

[x] Grammar

[x] Spelling

[x] Syntax

[x] Remove redundant words

[x] Add specialized words

[x] Review each other's work
[x] View video with the English transcript and review
[x] Upload the English (original) transcript, here
[x] Have it reviewed by others with knowledge of English

Collaborators Work:

@ICA3DaR5: 40%
@zero-andreou: 30%
@thiefinshadows: 30%

Suggested Budget: $1000
File: https://drive.google.com/open?id=1cq8hWLLrdlT6W_t07sFqYanXEwwbjBSvcJv92aoKO5s

please post the the original link of the English version being worked on

I am almost done, I'll upload it as soon as I am done!

OK. @ICA3DaR5.

@ICA3DaR5 would love  collaborating with you guys on this

@BelovedAquila We are almost finished. Perhaps on another issue? :)

@BelovedAquila Here's the file
I'll finish some minor details tomorrow.

@ICA3DaR5 I see you have done a good work on it but I can still review it, I sited some few things needing corrections, if you don't mind?

@BelovedAquila Sure.

@Tonyprisca13 I see you self-assigned this. Why is that?

@ICA3DaR5 send me an access link friend.

@BelovedAquila I've put it on a GitHub Gist for the moment. https://gist.github.com/ICA3DaR5/857d0b884b857671c77603df809243e7
Me, @thiefinshadows and @zero-andreou are working on this. It's almost ready. Be a little patient. We are working on this all night and day.

can I collaborate with u

@Tonyprisca13 We're almost finished and we're doing this by watching the video and fixing the transcript at the same time.

@ICA3DaR5 alright friend.

I think this is finished.

@ICA3DaR5 I suppose you are done already? Can I have an access to the Doc so as to review it?

@BelovedAquila Sure I uploaded it. There is a link on the first post.
Here's the link again.

I'll watch the video with the English transcript, one more time, tomorrow, and I'll call it a day.

Can I get the completed .srt file to send to Brad when it’s done? Would prefer it in srt file as there are many google docs that I have to sort through for different languages

@Mervyn853 Sure, once I finish (in a few hours), I'll also upload the .srt file.

This is finished as far as me, @zero-andreou and @thiefinshadows are concerned!


The image have an unrelated text.

This issue was created by @blackfoxsar from https://github.com/MicrosoftDocs/feedback/issues/629
🛑 IMPORTANT: You can get your feedback addressed faster if you use the comment section for the article in which you encountered a problem.
Link to article:
https://docs.microsoft.com/en-us/windows-server/identity/ad-fs/overview/whats-new-active-directory-federation-services-windows-server
Problem:
The image have an unrelated text.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 7899bfcb-2e9c-2738-5e7f-468a6eb643ce
Version Independent ID: 482cc911-c7ef-c680-b6ff-f634530b1424
Content: What's new in Active Directory Federation Services for Windows Server 2016
Content Source: WindowsServerDocs/identity/ad-fs/overview/whats-new-active-directory-federation-services-windows-server.md
Product: windows-server-threshold
GitHub Login: @billmath
Microsoft Alias: billmath


json-cid API

OldCantus has a json-cid API: https://cantus.uwaterloo.ca/json-cid/006583a .
The format of the data it returns looks very similar to that of CantusIndex's json-con API. In OldCantus's source code, there are numerous calls to other databases' json-cid pages, so it's likely that CI uses these APIs for compiling the data in its json-con API. So, we'll probably have to implement it if we want CI to be able to display concordances from CD.

I think we should assume that this API is important, since OldCantus has it, and so we should be sure to implement it. Going to apply an "important" label, because we should really have this set up before NewCantus goes live.


Update ButtonGroup to use Beta::Button

Description

Removes deprecated Button component
Adds CSS for ButtonGroup class
Add preview for split button ActionMenu scenario (WIP)

Integration

Does this change require any updates to code in production?

Maybe, this might be kind of a breaking change? This is used 18 times in production and I'm happy to roll it out with any fixes.
Replace variant: :small with size: :small https://github.com/search?q=repo%3Agithub%2Fgithub+Primer%3A%3ABeta%3A%3AButtonGroup&type=code
Merge checklist

[x] Added/updated tests
[x] Added/updated documentation
[x] Added/updated previews

Maybe, this might be kind of a breaking change? This is used 18 times in production and I'm happy to roll it out with any fixes.

Taking a quick look the only thing it looks like we'll need to fix is variant:  is used but not in too many places, I think this could be doable https://github.com/search?q=repo%3Agithub%2Fgithub+Primer%3A%3ABeta%3A%3AButtonGroup&type=code

Taking a quick look the only thing it looks like we'll need to fix is variant:  is used but not in too many places, I think this could be doable https://github.com/search?q=repo%3Agithub%2Fgithub+Primer%3A%3ABeta%3A%3AButtonGroup&type=code

Yeah, and it was pointing to size for some reason? I guess I could just leave it in and let it be.

This is ready to merge, but I'd like to be available to help roll it out and make dotcom changes. I will be out May 22-26.


IGAPP-993: Renaming and ipad pro129 screenshots

This pull request belongs to an issue on our bugtracker.
You can find it there by looking for an issue with the key which is mentioned in the title of this pull request.
It starts with the keyword IGAPP.

@SteffiStuffel any reason why the german android screenshots were not in images/phoneScreenshots?


Compass heading angle is reversed

The compass app points correctly to North, but the number displayed is apparently reversed. I would expect the number to display the heading, i.e. the direction to which top edge of the Bangle watch points. When I point it westwards, so the North is to the button (right edge), it says "90", even though West should be 270 degrees instead. And vice versa for eastwards direction.

I also tripped over this. The value actually seems to show the direction the red arrow is pointing at. Maybe we should add a configuration option which value to show? Either angle or 360-angle.

This app? https://banglejs.com/apps/?q=compass
It'd be great to see this changed so it's right... However I distinctly remember this being complained about before. I'm actually really surprised this wasn't fixed at that time, but I don't see any changes that mention this...
Does Navigation Compass give the correct value?

Yes, Navigation Compass gives the right value (i.e. West at 270°).

Navigation Compass has this comment in code for B2: // Note actual mag is 360-m, error in firmware
Maybe this problem was only fixed in magnav and not in firmware?


Unhandled Domain Exception: Configuration system failed to initialize

I keep getting this message every time I tried to run the program.  I used the Control panel to reset to an earlier version of the software the first time, which corrected the issue for awhile.  Then when it started happening again, this option was no longer available.  I uninstalled the software and tried for a fresh install, but I am now getting the same error every time I try to install it and the program will not install.

There might be a corrupted configuration file. Check for a config file by opening explorer and entering %AppData% in the location bar. Then browse to find the PGM folder and delete it. Then reinstall it to start fresh.

Deleting and reinstalling the program does not seem to fix this.

The %AppData% search does not currently show any folder for PGM, and when I try to install it fresh, the Unhandled Domain Exception pops up.

Sorry try %localappdata%


config: mint/fetch with 'cool DOI' ids

I guess I'd forgotten the actual integration of the new cool doi like id in the API :sweat_smile:

Merged via #34


Multilabel case

Hey kevin,
I tried implementing this on JAX as a learning exercise (as you saw on twitter!) and thought it might be useful to have a multilabel case, so I'll leave this here if you want it.
For multilabel problems, I'm using sklearn input i.e. one-hot encoding of labels, so y_train is an NxM ndarray where N is the number of samples and M is the number of targets.
In this case, y_mask would be constructed something like the below:
if y_batch.ndim==1:
    y_mask = y_batch[:, None] == y_batch[None, :] #multiclass, single label
elif y_batch.ndim==2:
    y_mask = y_batch.dot(y_batch.T).astype(bool) #multilabel
else:
    Raise blah blah

i.e. a pairwise matrix indicating where pairs share one or more labels.
Again thanks for the library!

Neat, thank you @ljmartin , will add to repo when I get the chance!


Analyze Afloat Services

Here's a description on the activity, and I think it's good if we collaborate on it so we each have a solid understanding of the end-to-process.  The deliverables are:

step by step docs to install Postgres, Java, and compile run the web services.
script (bash or JS) that erase all data from the database, and then calls the web services to populate the database to add user(s) and complete an order end-to-end. This will generate a strong shared understanding that we can iterate on.

I believe that the general sequence of web services calls would comprise:

Create user named Alice, a tax credit owner interested in selling  (/create_user?username=Alice)
Alice creates a tax credit, Virginia Port Volume, $50k, expires in 2025
Alice lists the tax credit for sale for $0.87 per $1.00
Create user named Bob, a Virginia tax credit buyer
Bob deposits $48k
Bob submits a purchase order for the tax credit at the list price of $0.87 per $1.00
Order is matched and fulfilled and Bob becomes the owner, $45k is moved to Alice, x% commission moved to Afloat
(PDFs are generated)

(fractionalizable/spawnable)
At the end of the script, it would run a few queries and output to stdout the balances and tax credit owner
Task 1: Write repeatable steps to install Java, Postgres, build, and run services  (which OS do you use?  if it helps, I can create some temporary standard Ubuntu VMs to use to avoid local differences that may throw us off)
Task 2: Author steps to deploy empty DB schema to Postgres
Task 3: Analyze web services and start to map the services to each of the steps 1-7 above
Task 4: Start to build the specific curl commands or JS scripts that invoke these services

Steps for basic setup:

Deploy DB schema to a local Postgres instance
Attempt to build Java web services
Attempt to call web services using a tool like Postman (or CURL commands)

For Dwolla, it seems like a subscription to this webhook would be appropriate: customer_bank_transfer_completed
From this link: https://developers.dwolla.com/concepts/webhook-events#customers---transfers

https://gitlab.com/afloatowners/blockchaineventprocessing/-/issues/29


setup script

Test setup script from scratch.
Change permissions.

Obsolete with #15. Closing

Obsolete with #15. Closing


Oops Something went wrong.

I updated Ackee to 2.0.2 by git pull but only the following error is shown. I deleted my existing db and re-created a new one, but the same error remains.
Could anyone tell me how to fix this issue?
{"errors":[{"message":"Variable \"$interval\" got invalid value \"TOP\"; Value \"TOP\" does not exist in \"Interval\" enum.","locations":[{"line":2,"column":26}],"extensions":{"code":"INTERNAL_SERVER_ERROR"}},{"message":"Variable \"$sorting\" got invalid value \"LAST_24_HOURS\"; Value \"LAST_24_HOURS\" does not exist in \"Sorting\" enum.","locations":[{"line":2,"column":48}],"extensions":{"code":"INTERNAL_SERVER_ERROR"}},{"message":"Variable \"$range\" got invalid value \"DAILY\"; Value \"DAILY\" does not exist in \"Range\" enum.","locations":[{"line":2,"column":68}],"extensions":{"code":"INTERNAL_SERVER_ERROR"}}]}

Error: {"errors":[{"message":"Variable \"$interval\" got invalid value \"TOP\"; Value \"TOP\" does not exist in \"Interval\" enum.","locations":[{"line":2,"column":26}],"extensions":{"code":"INTERNAL_SERVER_ERROR"}},{"message":"Variable \"$sorting\" got invalid value \"LAST_24_HOURS\"; Value \"LAST_24_HOURS\" does not exist in \"Sorting\" enum.","locations":[{"line":2,"column":48}],"extensions":{"code":"INTERNAL_SERVER_ERROR"}},{"message":"Variable \"$range\" got invalid value \"DAILY\"; Value \"DAILY\" does not exist in \"Range\" enum.","locations":[{"line":2,"column":68}],"extensions":{"code":"INTERNAL_SERVER_ERROR"}}]}

    at n.default (https://saferepo.com/index.js:136:143740)
    at async https://saferepo.com/index.js:136:27316

Node.js : v14.11.0
yarn: 1.22.5

Thanks for letting me know. Working on a fix… 😰

I've published a new version. Should be available via Docker in 10 minutes. Let me know if that fixes the error :)

I confirmed 2.0.3 works well. Thanks!


Update NLog package to use 4.5.0

NLog is finally out of RC, update package to use this - https://github.com/NLog/NLog/releases/tag/v4.5

Any reason not to use Microsoft.Extensions.Logging.ILogger abstraction instead of NLog specifically?

At the time I lost some hair that day trying to figure out NLog's package that supported Microsoft.Extensions.Logging.ILogger abstraction properly with the versions the SDK supported.  It looks like they've pushed some updates to it so I'll take a look.

Using issue #47 to track using Microsoft.Extensions.Logging.Abstractions instead of NLog


Remaining wishlist

Summary
Catch-all for the remaining nice-to-haves, excluding any others already documented. Each section could probably be its own issue, so break out as needed.
Admin
Analytics
Google or Hotjar. Might need privacy stmt then.
GitHub

Fill out project info and org-level info in Settings.
Add some badges (Code of Conduct, Netlify build, coverage (errr not yet)

Community repo

Link to it from the main repo?
Run through community checklist

Backups
Ensure they exist for:

Tilesets
Source spreadsheet
WP content
Sheets config (e.g. for MB fonts)

Documentation

#8
Auto-generated React/TS docs
Mention Node version in README/Contributing doc

App-level
SEO/meta
Likely overkill:

robots.txt
sitemap.xml

Icons/logo

Favicon
iOS (+android?) home screen tile

UI wishlist
Graphs, charts, stats
Not much numeric data to work with and maybe not applicable to this project, just throwing it out there though.
Grid view
In addition to table, could have a grid with all unique endonyms/languages.
Light/dark switcher

UI: tried to implement this but not much luck
Basemap: doable but might need a second set of symbology and labels

Geocode/boundaries popover "X"
...and/or darker backdrop to indicate that it's technically a modal. Otherwise it's misleading that the next click only closes the popover and nothing else (e.g. map click).
Performance

Set benchmarks
Follow React profiling guide

Tests
Automated tests via Jest and react-testing-library are set up, just not very useful as they were written early-on before the UI was more complete, and now there is no time. So, Round 2: add something useful...

From my perspective... what's key here is everything under "Admin" except Backups, which I can handle, and Geolocation.
I'm not clear on App-Level, Performances, Tests.

Broke out geolocation into #105. Seems straightforward, maybe only 0.5 days or less for defaults, and a bit longer getting it into a logical place in our UI.


too many values to unpack when running fw_versions.py --scan

Describe the bug
The following error been reported to me by two different discord users: brad dongle ID a2b1d650214053d7 and kevie dongle ID 5d37fcbf464873fa when running fw_versions.py --scan
Traceback (most recent call last):
File "fw_versions.py", line 193, in
candidates, fw_vers = get_fw_versions(logcan, sendcan, 1, extra=extra, debug=args.debug, progress=True)
ValueError: not enough values to unpack (expected 2, got 0)
How to reproduce or log data
cd /data/openpilot/selfdrive/boardd
pkill ./manager.py
./boardd
Then in another session/window:
cd /data/openpilot/selfdrive/car/
Python fw_versions.py --scan
Start Car when message shows getting Vin
Expected behavior
ECU firmware versions should be queried and returned.
Device/Version information (please complete the following information):

Device: comma two
Version: 0.7.2 devel-staging 43c07122e24134c5db68c5a224948b034c5b64a0
Car make/model 2020 Toyota Prius Prime and 2020 Corolla LE

Fixed by https://github.com/commaai/openpilot/commit/719e0572e1a6b202a21c2ee6f644c111a2273b83


Add server echo example

This example just echos back an MO to the server with the same text as it receives in a MT. It helped me to test MO handling inside my client.
Adapted from:
http://stackoverflow.com/questions/25626983/cloudhopper-smpp-how-to-send-mo-sms-to-client
http://stackoverflow.com/questions/21906412/cloudhopper-smpp-how-to-get-messages-content-which-have-sent-from-other-client

Example is good -- although go ahead and change the author at the top to yourself.

I want to add some code to send out a DeliveryReceipt before sending the MO. I'll do this soon.

I think this is ready now...


FSGP Routemodel

Initial work on FSGP Routemodel:

Import track data
Construct a route by defining which segments to use and their order

Still need to work on seeding to the db and Cumulative Sum Distance