[BUG] DATETIME_FORMATTER_CACHING_SETTING experimental feature should not default to true

Describe the bug
This was first reported on the opensearch forum: https://forum.opensearch.org/t/opensearch-experimental-setting-true-by-default-datetime-formatter-caching/19067

Just wanted to bring up a change that was added into OpenSearch 2.12 which was enabled by default and broke some functionality in our applications.

The experimental feature flag opensearch.experimental.optimization.datetime_formatter_caching.enabled defaults to true, see:
https://github.com/opensearch-project/OpenSearch/blob/81707dcc74fd8a66349c80c0c47254de110b9f5d/server/src/main/java/org/opensearch/common/util/FeatureFlags.java#L82-L86
We clearly state in our release notes that experimental feature flags are disabled by default: https://github.com/opensearch-project/opensearch-build/blob/a7f6bb5901545875d7817f26016a1d6c99c4d8ad/release-notes/opensearch-release-notes-2.12.0.md?plain=1#L24
This was introduced in https://github.com/opensearch-project/OpenSearch/pull/9567
Related component
Indexing
To Reproduce
See code block linked in description.
Expected behavior
All experimental feature flags should be disabled by default. Ideally this should be enforced in the code as well.
Additional Details
Plugins
Please list all plugins currently enabled.
Screenshots
If applicable, add screenshots to help explain your problem.
Host/Environment (please complete the following information):

OS: [e.g. iOS]
Version [e.g. 22]

Additional context
Add any other context about the problem here.

Tagging folks who worked on original PR: @reta @CaptainDredge @ankitkala
It seems like this PR has been backported all the way to 2.11 which makes me think this isn't really an experimental feature flag anymore, which in that case we should move this to a dynamic setting.

It seems like this PR has been backported all the way to 2.11 which makes me think this isn't really an experimental feature flag anymore, which in that case we should move this to a dynamic setting.

Thanks a lot @jed326 for bringing this one up, I think yes, we messed it up  with default I believe, it indeed should be set as false as experimental setting. The true came out of the good intents, but it is not aligned with the semantic of the experimental setting, I agree.
AFAIK we cannot make it dynamic setting - the formatters are static instances that are created with the caching turned on/off, probably could look into it but it would need redesign, :100:

Thanks @reta -- do you think a static setting would make sense here then? I know we have a 2.14 release coming up soon but too, do you see this as a release blocker for that?

Thanks @reta -- do you think a static setting would make sense here then?

I mean there is no access to any kind of settings when the formatters are initialized. Reverting the default to false as it should have been done would probably makes sense.

[Triage - attendees 1 2 3 4 5 6 7 8]
@jed326 Thanks for creating this issue.

Reverting the default to false as it should have been done would probably makes sense.
@reta this would then result in a change of default format in the new version. How about we take the feature out of experimental setting? I feel like since this was enabled by default, sufficient bake time has been provided for any issue to bubble up. Wdyt?

@reta This does change the default format:
https://github.com/opensearch-project/OpenSearch/blob/0ddbd96291d4ff05499ec53c5a04a5dda32d36ad/server/src/main/java/org/opensearch/index/mapper/DateFieldMapper.java#L105-L109
I do think what @CaptainDredge suggested in moving this out of experimental is where we eventually want to end up. It seems like the main sentiment in the forum post that reported this is that there's uncertainty in what will be default going forward since this is currently under experimental.

@reta This does change the default format:

Ah yeah, thanks @jed326 , even the setting is somewhat confusing than, I think @CaptainDredge suggesting would make sense than

It seems like the main sentiment in the forum post...is that there's uncertainty

@jed326 @CaptainDredge The forum post says "...was enabled by default and broke some functionality in our applications". Have we dug into that? We should seriously consider reverting the default behavior back to the pre 2.11 format since we've got at least one data point that this is a breaking change.

@jed326 @CaptainDredge The forum post says "...was enabled by default and broke some functionality in our applications"

Thanks @andrross , I missed the "broke" part but it should be included into this issue in bold, I suspect the default format change could be the culprit here (caching is less likely but possible).

I've asked the original poster on the forum for some more details on what specifically broke for them

The takeaway from this issue is that it is turned off by some users, we cannot make it non-experimental without clearing the behaviour first

Definitely! Ideally the behaviour should've remained same since the new default format is just an extension of old default format. I'm highly curious to know what broke for the user in order to understand the functional difference between the old and new format

Hey all, yeah the error we were seeing after upgrading to OpenSearch 2.12 was:
[REQUEST_HANDLING_ERROR_CAUSED_BY] Caused by: exception: OpenSearchException message: OpenSearch returned an error: Code: 400. Error: illegal_argument_exception:Mapper for [created_at_dttm] conflicts with existing mapper: Cannot update parameter [format] from [strict_date_time_no_millis||strict_date_optional_time||epoch_millis] to [strict_date_optional_time||epoch_millis].
Guess this was because in several instances a type mismatch between how we were formatting our dates, and the default change in the new OpenSearch. Everything was working again as expected when we disabled the default format change with the experimental flag.
As @jed326  mentioned above, main motivation for forum post was to see whether this would be default in future, and to bring up the oddity that an 'experimental' feature was enabled by default.
Also, took a little bit of time to properly figure out this change too, as nothing to do with the default datetime format changing was mentioned in the release note that I could see.
Cheers for raising this issue and the discussion around it! :)

Thanks @StewartWBrown1 , @andrross @jed326 @CaptainDredge I strongly feel like we have to step back and follow the proper rollout process:

keep setting experimental
make false to be a default value (as it should have been, we sadly overlooked that)

I don't think this change would have any impact on existing apps (if the switch between default date formatters was not noticeable, it still won't be noticeable either). But it would address user's concern, the evidence we've been looking for to confirm that things do break.

I don't think this change would have any impact on existing apps (if the switch between default date formatters was not noticeable, it still won't be noticeable either)

@reta Agree, I think we should change the default back to the pre-2.11 behavior since we know this change was breaking for at least one user. I suspect more people (who have yet to upgrade to 2.11+) will be impacted if we don't fix this ASAP.

Thanks @andrross , I think we could make it to 2.14.0 once everyone is on board.

Reopening this since I've not seen any traction.
I'm still trying to understand what is the actual issue here with the new format.
@reta @StewartWBrown1 I'm still not sure of the actual issue here. Could you please help understand this?

@mgodwan please check https://github.com/opensearch-project/OpenSearch/issues/13411#issuecomment-2091509483

@reta I've gone through the issue and comments, but have not been able to figure out what exactly broke with the change. The new default format is compatible with the legacy one if I understand correctly

@mgodwan as user reported, this is not about functional format compatibility, but format of the datetime field:
[REQUEST_HANDLING_ERROR_CAUSED_BY] Caused by: exception: OpenSearchException message: OpenSearch returned an error: Code: 400. Error: illegal_argument_exception:Mapper for [created_at_dttm] conflicts with existing mapper: Cannot update parameter [format] from [strict_date_time_no_millis||strict_date_optional_time||epoch_millis] to [strict_date_optional_time||epoch_millis].

I don't know exact use case but I could imaging one, when the existing mappings for the index where created with the "old" default but than when the "new" default kicks in, with an attempt to update the existing mapping (please notice, no changes on user side).

when the existing mappings for the index were created with the "old" default but than when the "new" default kicks in

In case of default format, mapping format is not persisted ever.
Based on my dive deep into the mapping flow for datetime field, this can only happen when a user tries to explicitly applies the format which they expect to be the default.
e.g.
Create index with https://github.com/opensearch-project/opensearch-benchmark-workloads/blob/main/so/index.json

Try

curl --location --request PUT 'localhost:9200/so/_mappings' \
--header 'Content-Type: application/json' \
--data-raw '{
    "properties": {
      "creationDate": {
        "type": "date",
        "format": "strict_date_optional_time||epoch_millis"
      }
    }
}'
{"acknowledged":true}

Till 2.11, the above would've passed. Starting 2.12, user would've seen the error reported above. I don't think that this accounts for breaking change (as ideally, we should not even allow setting an explicit format when default is used but sadly opensearch had been allowing this).

Thanks, this is clear now.

I don't think that this accounts for breaking change (as ideally, we should not even allow setting an explicit format when default is used but sadly opensearch had been allowing this).

This is 100% breaking change for user: the feature that was worked before is not anymore (without any changes from user side).

we should not even allow setting an explicit format when default is used but sadly opensearch had been allowing this).

Since the default could change (which we sadly did), why  we should not even allow setting an explicit format?

Since the default could change (which we sadly did), why we should not even allow setting an explicit format?

@reta In general, we don't allow mappings for a field to be modified (e.g. doc_values cannot be enabled for a field for which it has been disabled). Similar to that, we don't allow date_time format to be changed once set (e.g. you cannot change from epoch_millis to strict_data_time_no_millis) . Only in case of default, users can set it explicitly equal to the backing default (and not to any other format) which is the payload which broke.

@reta In general, we don't allow mappings for a field to be modified (e.g. doc_values cannot be enabled for a field for which it has been disabled).

@mgodwan My understanding from your comment https://github.com/opensearch-project/OpenSearch/issues/13411#issuecomment-2108309595 the mapping was not modified but created the first time?

@reta No, you can successfully create the index. Its only when attempting to modifying the mappings that this error will come, which is the same behaviour as before based on how we look at it (i.e. changing from something other than default is not allowed)
Let me know your thoughts.
% curl -XPUT "http://localhost:9200/index-test" -H 'Content-Type: application/json' -d'
{
  "mappings": {
    "properties": {
      "datetime": {
        "type": "date"
      }
    }
  },
  "settings": {
    "number_of_replicas": 0,
    "number_of_shards": 1
  }
}'
{"acknowledged":true,"shards_acknowledged":true,"index":"index-test"}

% curl -XPUT "http://localhost:9200/index-test/_mappings" -H 'Content-Type: application/json' -d'
{
  "properties": {
    "datetime": {
        "type": "date",
        "format": "strict_date_optional_time||epoch_millis"
      }
  }
}'
{"error":{"root_cause":[{"type":"illegal_argument_exception","reason":"Mapper for [datetime] conflicts with existing mapper:\n\tCannot update parameter [format] from [strict_date_time_no_millis||strict_date_optional_time||epoch_millis] to [strict_date_optional_time||epoch_millis]"}],"type":"illegal_argument_exception","reason":"Mapper for [datetime] conflicts with existing mapper:\n\tCannot update parameter [format] from [strict_date_time_no_millis||strict_date_optional_time||epoch_millis] to [strict_date_optional_time||epoch_millis]"},"status":400}

---

% curl -XPUT "http://localhost:9200/index-test/_mappings" -H 'Content-Type: application/json' -d'
{
  "properties": {
    "datetime": {
        "type": "date",
        "format": "strict_date_time_no_millis||strict_date_optional_time||epoch_millis"
      }
  }
}'
{"acknowledged":true}

@reta No, you can successfully create the index. Its only when attempting to modifying the mappings that this error will come, which is the same behaviour as before based on how we look at it (i.e. changing from something other than default is not allowed)

Thanks @mgodwan , so it is exactly the flow I suspected (https://github.com/opensearch-project/OpenSearch/issues/13411#issuecomment-2107409315). In any case, I strongly lean towards classifying this change as a breaking: we do allow "noop" mapping updates but the change of the default date format broke that.

so it is exactly the flow I suspected (https://github.com/opensearch-project/OpenSearch/issues/13411#issuecomment-2107409315).

Just to clarify on the part it triggers an attempt to update the existing mapping (please notice, no changes on user side). from the linked comment, this does not happen within OpenSearch but only through a user action, and can be classified as breaking for users attempting to perform this.
(I honestly don't see a use case for performing this action but I agree that this may not be in line with semantic versioning guidelines and hence may justify the revert. I've asked the original reporter about the use case as well so that it gives us a path to solve for the issue and decide if we can disable no-op format modifications for the user as it is kind of leaking an implementation detail through the API)

I would like to brainstorm further on how to enable the new default format (given the performance gains highlighted in the original issue). Do you think this can be done for indices created on new versions at least (e.g. apply the defaults only for index.created.version >= 2.15.0) or would that be considered breaking as well?
Also, would like to hear community thoughts on if we should disable modifying from default to explicit format (i.e. no-op) from 3.0 through a validation check in DateFieldMapper?

I would like to brainstorm further on how to enable the new default format (given the performance gains highlighted in the original issue).

I think we have to fix this feature rollout by introducing 2 separate feature flags (I think @CaptainDredge mentioned that as well at some point):

the caching one DATETIME_FORMATTER_CACHING_SETTING (current, which you probably interested in since it is focused on performance gains)
the caching one DATETIME_FORMATTER_DEFAULT_SETTING (new, which does default format change)

@mgodwan I am closing this issue as per resolution, DATETIME_FORMATTER_CACHING_SETTING is now false and delivered in 2.14.0, please feel free to open follow up issues, we have quite a few options to proceed, thank you.


Monitor: Add URL links in notification email

Each alert should have an email link to a website with more details.

@mildebrandt please give me this task i would like to work on it. I am a beginner in open-source and would love to take on this challenge

Sure, thanks! Please let me know if you have questions about setting up the environment for development.


Task failure criteria

Currently a task is considered to have succeeded if the corresponding scheduler job runs to completion without timing or erroring out. This includes tasks which expect outputs but fail to produce them. This is misleading and confusing- if a job is expected to produce output files, we should mark it failed if it does not.
Are there any other similar cases to consider?

Updated in 4f7b502


Add Zach Van Uum to Contributors List.

@zvanuum, I'm quite elated about your PR. I wanna evolve this project to addresses various problems faced by first-time contributors. I'd love to learn about your journey in open source community, the problems, pain points you had etc.
Could you explain how you felt when you went through the tutorial, made a PR and learned that I merged it?

 I've been a software engineer professionally for two years now, and this whole time I've rarely touched personal projects or anything else outside of work. So by trying to get into open source, I'm trying to rectify that 😄


Notify senders of updates to 'direct' schema

We recently identified an issue where data from a sender is missing key fields required by the State of California DPH. Investigation revealed that key fields were missing from the sender's data feed.
Proposed solution:

We will update our direct schema and notify this specific sender to include these as optional fields going forward by updating the cardinality of these fields
Notify other senders as well of these changes so that they may update their schema as well

Need to notify the following senders:
Cue, SafeHealth, InBios and Anavasai - their schemas extend the direct.schema
A/C: Done when notification to all senders is complete. Follow ups from sender will be registered as unique issues.

SafeHealth is in a holding state until October, so we will communicate the change to them close to that time.
Still need to report to HHS Protect.


Add config version: 2 to dbt_project.yml

dbt-project.yml change

Adding config-version: 2 to the dbt_project.yml will allow the rudderlabs package to be implemented without error.

Type of change

[x] Bug fix (non-breaking change that fixes an issue)
[ ] New feature (non-breaking change that adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists
Development

[ ] Lint rules pass locally
[ ] The code changed/added as part of this pull request has been covered with tests
[ ] All tests related to the changed code pass in development

Code review

[ ]  This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
[ ] "Ready for review" label attached to the PR and reviewers mentioned in a comment
[ ] Changes have been reviewed by at least one other engineer
[ ] Issue from task tracker has a link to this pull request

@ameypv-rudder I saw you had made the last few commits. Are you who I should be tagging for review?

Hi, @lennypisano - thanks for your contribution. I've added @DipanjanAtRudderLabs to look into the PR. Also, could you please sign this contributor's agreement: https://rudderlabs.wufoo.com/forms/rudderlabs-contributor-license-agreement

@ameypv-rudder will there be a release for the new changes?

@ameypv-rudder will there be a release for the new changes?

@lennypisano there's no official release as such; the changes are reflected the dbt hub once their team pulls them.


number of action chart seems always show a drop because the moving average

see how can calculate the moving average to avoid the drop at the end.

@guo , how do you calculate the moving average field on the backend?

just assume the missing part as the avg.

What about hiding day1? (08-08)

At this moment, hide the day1.
Need to check later again.

close for now.


VSCode plugin show error when invoking twitter -> tweet

Description:
I'm following https://ballerina.io/learn/quick-tour and VSCode plugin show following error for twitter -> tweet. The program complies and run without any issues though.

Affected Versions:
VSCode - 1.22.2
VSCode Plugin - 0.970.0 release
OS, DB, other environment details and versions:
macOS 10.13.4

Has been fixed in latest Language Server plugin. Hence Closing the issue. Please reopen if the issue still can be observed


nginx reverse proxy strips response headers from backend

In a set up like this:
(client) <--> (nginx+modsec reverse proxy) <--> (backend web server)

If the backend server adds a new response header, modsec doesn't pass it to the client.
This happens even if all the rules are disabled and SecRuleEngine Off is set. It seems anything new that is added by the backend will get dropped.
We noticed this because we were trying to byte serve a PDF from the backend. Chrome uses range requests, but modsec drops the Content-Range header from the response, so it makes the client download the file forever.
I set up a super tiny test environment with nginx 1.6.0 and modsec 2.8.0 and could recreate the issue there. Here is a gist with some logs and the configs. We also saw this in another similar set up which was nginx 1.4.4 and modsec 2.7.7.
I hope I didn't miss anything, please let me know if any more info is needed.

Fixed by: #749.

Hi @zimmerle Has this been included in a release?
I've just compiled the latest version of Nginx (1.11.6) with Modsecurity (2.9.1). Nginx is acting as a reverse proxy for a Jetty server. I'm using the default OWASP rules (3.0.0).
The Java app is adding headers to the response which are being stripped out by Modsecurity. It was fine before Modsecurity was added.
Thanks in advance!

Hi @davidgenn,
Please use the `nginx_refactoring' branch. Or the ModSecurity-nginx connector:
https://github.com/SpiderLabs/ModSecurity-nginx


Add docs around WithAllowlistedMultiaddrs. Expose allowlist

Adds an example on how to use the with allowlisted multiaddr option.
Adds a function that lets you get the allowlist object from the resource manager. Maybe this should be part of the core api, or maybe NewResourceManager should return a concrete type. I think it'll be easier to change this in a monorepo, but this should be work for now. It should be a small number of users using this right now.

Will this be automatically rendered in the go doc for WithAllowlistedMultiaddrs?

Yup! And they get executed during tests: https://go.dev/blog/examples


add Testkube to landscape

Pre-submission checklist:
Please check each of these after submitting your pull request:

[X] Are you only including a repo_url if your project is 100% open source? If so, pick the single best GitHub repository for your project, not a GitHub organization.
[X] Does it follow the guidelines for new entries?
[X] Have you added an SVG to hosted_logos and referenced it there?
[X] Does your logo clearly state the name of the project/product and follow logo guidelines?
[X] Have you verified that the Crunchbase data for your organization is correct (including headquarters and LinkedIn)?
[x] ~5 minutes after opening the pull request, the CNCF-Bot will post a link for you to preview your changes. Have you confirmed that they are correct and then added a comment to the PR saying "LGTM"?

LGTM 🙃


java.lang.NullPointerException in JavaTimerManager$IdleFrameCallback.doFrame

Description
New Version
0.71.2
Old Version
0.69.7
Full Stacktrace
Fatal Exception: java.lang.NullPointerException: Attempt to invoke virtual method 'void com.facebook.react.modules.core.d$c.a()' on a null object reference
       at com.facebook.react.modules.core.JavaTimerManager$IdleFrameCallback.doFrame(JavaTimerManager.java:102)
       at com.facebook.react.modules.core.ReactChoreographer$ReactChoreographerDispatcher.doFrame(ReactChoreographer.java:175)
       at com.facebook.react.modules.core.ChoreographerCompat$FrameCallback$1.doFrame(ChoreographerCompat.java:85)
       at android.view.Choreographer$CallbackRecord.run(Choreographer.java:1299)
       at android.view.Choreographer$CallbackRecord.run(Choreographer.java:1309)
       at android.view.Choreographer.doCallbacks(Choreographer.java:923)
       at android.view.Choreographer.doFrame(Choreographer.java:847)
       at android.view.Choreographer$FrameDisplayEventReceiver.run(Choreographer.java:1283)
       at android.os.Handler.handleCallback(Handler.java:942)
       at android.os.Handler.dispatchMessage(Handler.java:99)
       at android.os.Looper.loopOnce(Looper.java:226)
       at android.os.Looper.loop(Looper.java:313)
       at android.app.ActivityThread.main(ActivityThread.java:8757)
       at java.lang.reflect.Method.invoke(Method.java)
       at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:571)
       at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1067)

https://github.com/facebook/react-native/blob/d9321c0866a9270f8aae0d37c11584f819bc11ce/ReactAndroid/src/main/java/com/facebook/react/modules/core/JavaTimerManager.java#L101-L103
The code seems to be causing problems, but I don't know why I get NullPointerException even though doing null check
React Native Version
0.71.2
Output of npx react-native info
System:
    OS: macOS 13.2.1
    CPU: (10) arm64 Apple M1 Pro
    Memory: 12.46 GB / 32.00 GB
    Shell: 5.8.1 - /bin/zsh
  Binaries:
    Node: 16.20.0 - /opt/homebrew/opt/node@16/bin/node
    Yarn: 3.5.0 - [hide]/node_modules/.bin/yarn
    npm: 8.19.4 - /opt/homebrew/opt/node@16/bin/npm
    Watchman: Not Found
  Managers:
    CocoaPods: 1.12.0 - /Users/[hide]/.rbenv/shims/pod
  SDKs:
    iOS SDK:
      Platforms: DriverKit 22.2, iOS 16.2, macOS 13.1, tvOS 16.1, watchOS 9.1
    Android SDK: Not Found
  IDEs:
    Android Studio: 2022.1 AI-221.6008.13.2211.9619390
    Xcode: 14.2/14C18 - /usr/bin/xcodebuild
  Languages:
    Java: 11.0.11 - /usr/bin/javac
  npmPackages:
    @react-native-community/cli: Not Found
    react: * => 18.2.0
    react-native: * => 0.71.2
    react-native-macos: Not Found
  npmGlobalPackages:
    *react-native*: Not Found
Android:
  hermesEnabled: true
  newArchEnabled: false

Additional Library Version
Versions of libraries that may be associated with this error
react-native-reanimated: 2.14.4
react-native-gesture-handler: 2.9.0
react-native-screens: 3.20.0
Steps to reproduce
After update react-native version from 0.69.7 to 0.71.2 in our project. The error occurs intermittently to the user.
Snack, screenshot, or link to a repository

Fatal Exception: java.lang.NullPointerException: Attempt to invoke virtual method 'void com.facebook.react.modules.core.d$c.a()' on a null object reference

Please provide:

Unsymbolicated stacktraces
A reproducer
Otherwise we'll have to close this issue


Add Liveinternet

Addition service Liveinternet. Several implementation options have been made as per the documentation:

in the form of a single image combining the counter and the LiveInternet logo
in the form of two images, one of which is a counter (transparent GIF size 1x1), and the other is the LiveInternet logo. This placement method will allow you to insert the code of the invisible counter at the beginning of the page, and the logo - where the design and content of the page allows.

Flake8 and isort found 3 minor issues, and some of your tests are failing. Can you fix that?

Flake8 и isort обнаружили 3 незначительные проблемы, и некоторые из ваших тестов не работают. Вы можете это исправить?

I don't have a lot of time right now, so I can't. As soon as I'm free, if I don't forget, I'll fix it.

I don't have a lot of time right now, so I can't. As soon as I'm free, if I don't forget, I'll fix it.

It's all good, take your time. Your contribution is good on track at the moment. Unfortunately, it's necessary to satisfy some basic code quality metrics. There's not much missing, though, really. Thank you for your understanding! Maybe set yourself a reminder. ⏱


ssl version error

i tryed installing latest openssl(kali) ,doesent seem to be solving the problem, any ideas? or is it still the proxy problem?

fml, im dumb, mobile proxies fixed the problem

Tryed good mobile proxies , kinda same error, even though now its now appearing instantly and feels like teally just times out

works with brightdata by me
i tryed making toks with no proxies - flawless, amazing stuff dude, waiting for that brightdata application to pass thru

Already did :)
make a donation wallet somewhere ;)


Koa example

This PR adds a Koa example app. In it's current state, it depends on https://github.com/jacobmarshall-etc/bugsnag-node/commit/6021c89fbb53eb26ad4d7f6d2557f0bb7e7822c8 (see #94) in order to have feature parity of the Express example app.

Awesome! Guessing this is pseudo code and doesn't actually work, just hit this exact issue.
I'd even gone to the trouble of implementing the middleware in the express style (as described in the docs) only to deploy it and find out it didn't work!

Guessing this is pseudo code and doesn't actually work

Well kinda. It does work if you manually apply this patch https://github.com/jacobmarshall-etc/bugsnag-node/commit/6021c89fbb53eb26ad4d7f6d2557f0bb7e7822c8. I know that we were looking into finding the best way to offer feature parity with other frameworks' middleware - and this way seemed the simplest (and also backwards compatible).
There's some awesome work being done by @kattrali to improve the test coverage (kattrali/improve-test-coverage), which I can see has the patched pulled in. So that may mean it's going to make it into a future release? But I couldn't say.


Link down in FAQ: "Is Cython faster than CPython?"

Trying to view https://sage.math.washington.edu:8091/hudson/view/bench/ gives: sage.math.washington.edu’s server IP address could not be found. When clicking on "See the latest results".

Thanks for reporting it. I couldn't find the pages. So I removed the links altogether.

Yes, the benchmark runner does not exist any more.


Modernize repository and CI

Hi there,
like already done on crate-dbal, this modernizes the repository and the CI configuration.

Bump to HTTP client "guzzle^7.2"
Replace Travis CI by GitHub Actions
Rename default branch to "main"
Update Scrutinizer configuration
Update documentation
Update development dependencies
Run code style checks

With kind regards,
Andreas.

Please note .github/workflows/tests.yml is a perfect blueprint how to run CrateDB on GitHub Actions with a custom configuration, specifically here it is about enabling SSL where some other files (keys and certificates) have to be provisioned to the container beforehand.
In order to accomplish this, we don't use GitHub Actions' native services configuration but leverage docker-compose instead. The accompanied docker-compose.yml makes use of health checks as well as a sidecar container to wait for the service to be available properly before handing over to the next job steps, even when starting Docker Compose in --detached mode.

Hi.
I wanted to share with you that, while revamping the crate-pdo driver and now running it against CrateDB Nightly on GitHub Actions, the process currently experiences a (hopefully) minor hiccup on PHP7.4 only (works on PHP7.2 and PHP7.3 though). I will discuss that with @seut, so JFYI and sorry for the noise.

Job failure: https://github.com/crate/crate-pdo/runs/1962329131?check_suite_focus=true
Code in question: https://github.com/crate/crate-pdo/blob/1.1.0/test/CrateIntegrationTest/PDO/PDOStatementTest.php#L335-L345
Thoughts: Trying to access array offset on value of type bool indicates $statement->fetchAll(PDO::FETCH_NAMED) returns false, probably from https://github.com/crate/crate-pdo/blob/1.1.0/src/Crate/PDO/PDOStatement.php#L235 or other places in that function.

With kind regards,
Andreas.

Running this on my workstation with -Cstats.enabled=true reveals from sys.jobs_log (even on PHP7.2) that the statement INSERT INTO test_table (name) VALUES (?) errors with
Column `id` is required but is missing from the insert statement.

So, the problem might not be related to the NULL parameter binding at all. However, this test case does not croak on PHP7.2.

Inspired by [1], I decided to ask PDO to throw exceptions like
PDO::ATTR_ERRMODE => PDO::ERRMODE_EXCEPTION

And indeed, the statement error revealed through sys.jobs_log is now a real error.
$ composer run -- test --filter "testNullParamBinding"

There was 1 error:

1) CrateIntegrationTest\PDO\PDOStatementTest::testNullParamBinding
Crate\PDO\Exception\PDOException: SQLParseException[Column `id` is required but is missing from the insert statement]

/Users/amo/dev/crate/sources/crate-pdo/src/Crate/PDO/PDO.php:129
/Users/amo/dev/crate/sources/crate-pdo/src/Crate/PDO/PDOStatement.php:211
/Users/amo/dev/crate/sources/crate-pdo/src/Crate/PDO/PDOStatement.php:211
/Users/amo/dev/crate/sources/crate-pdo/test/CrateIntegrationTest/PDO/PDOStatementTest.php:340

[1] https://bugs.php.net/bug.php?id=65825

It turns out the test was just plain wrong as it didn't issue a SELECT ... statement before comparing the outcome. The situation has been improved by adding appropriate tests like testInsertNull, testInvalidInsert, testNullParamBinding and testInvalidInsertWithNullParamBinding with 1af29dd.


Iterable via for...of

Currently it's impossible to iterate over collection via for...of from ES2015 (some sort of Symbol iterable bug). Workaround is to iterate over collection.models.

Duplicate of #35


When removing a file via dragging it out of the box, the file next to it also gets deleted

Let's say you have 5 files, and drag file number 3 out of the box to remove it, file number 4 will also get removed. This only happens when dragging the file out, clicking the remove element works just fine.

Fixed with 88efad08572f38e5f677e1767f1faf6ac3f71e09


gitprompt-rs: adopt orphan package

Description of changes
Orphaned in #307470.
While here, I also changed the hashes to sri format.

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

@isabelroses has taken your chance. Would you close it or still add your name after?

Closed by #307839


What is cssFactor for?

https://github.com/jeromeetienne/threex.htmlmixer/blob/43fdd5766133d321e86af1e9cd61144ff2182c03/threex.htmlmixer.js#L22-L24
Is this to prevent objects from disappearing when beyond camera's near/far?

Wait, nvm, I see this:
https://github.com/jeromeetienne/threex.htmlmixer/blob/master/threex.htmlmixer.js#L184-L186
Not sure what's that for yet.

I didn't understand what cssFactor was for, so I made my own "mixed mode": http://jsfiddle.net/trusktr/jc6j1wmf
Does mine have some bug that I might not be aware of?


Add flag to disable Modrinth restricted domains

This allows packwiz to produce .mrpack files with direct downloads, for packs that aren't distributed on modrinth.com.
See https://github.com/modrinth/docs/commit/e1ff209224d7af7cfb70925e83432b42fae48d65 :)

Thanks! This doesn't handle the case where mode is metadata:curseforge though, where there would be no URL that can be used to include it directly. Could you pass restrictDomains as a parameter to canBeIncludedDirectly?


Support user-defined functions as options to abort a simulation

For some codes there is a special way to cleanly stop a simulation, e.g. for FDS you create a <CHID>.stop file. I think JETTO has something similar. We should provide a way for users to define a function which does whatever is necessary which is executed when the run should be aborted.
This is something which a fire safety consultancy explicitly asked about.

https://cloudhpc.cloud/2023/08/29/fds-soft-vs-hard-stop/

Possibly solved by #500
Suggest trying the following with this branch:
def abort_callback() -> None:
    # Function to create soft abort file
    pass

with simvue.Run(abort_callback=abort_callback) as run:
    # Disable Simvue itself terminating the process
    run.config(abort_on_alert=False)
    # Add the FDS simulation process
    run.add_process(...)


yoga: Use Rocky Linux 9 as a base for kayobe-automation

The default CentOS Stream 8 base image is no longer available due to EOL.

RL9 change looks good, but CS8 jobs are broken by removal of upstream repos.


New ECCV paper(s) about DeepFake

Real Appearance Modeling for More General Deepfake Detection
https://www.ecva.net/papers/eccv_2024/papers_ECCV/html/6913_ECCV_2024_paper.php

Fake It till You Make It: Curricular Dynamic Forgery Augmentations towards General Deepfake Detection
https://arxiv.org/abs/2409.14444

Exploring Strengths and Weaknesses of Super-Resolution Attack in Deepfake Detection
https://arxiv.org/abs/2410.04205


Illegal string offset 'code' in securimage.php:1403

I'm getting the below error intermittently when users are using our forms. So far I have been unable to determine what causes this. When testing everything works as normal. Is anyone able to shed any light as to whether this is a bug or point me in the right direction on how to replicate it?
[2019-12-03 18:10:11] production.ERROR: Illegal string offset 'code' {"exception":"[object] (ErrorException(code: 0): Illegal string offset 'code' at /var/www/vendor/dapphp/securimage/securimage.php:1403)
[stacktrace]
#0 /var/www/vendor/dapphp/securimage/securimage.php(1403): Illuminate\Foundation\Bootstrap\HandleExceptions->handleError(2, 'Illegal string ...', '/var/www/vendor...', 1403, Array)
#1 /var/www/app/Http/Controllers/FormsController.php(94): Securimage->getCode()
#2 [internal function]: App\Http\Controllers\FormsController->remoteValidateCaptcha('1879157')
#3 /var/www/vendor/laravel/framework/src/Illuminate/Routing/Controller.php(54): call_user_func_array(Array, Array)
#4 /var/www/vendor/laravel/framework/src/Illuminate/Routing/ControllerDispatcher.php(45): Illuminate\Routing\Controller->callAction('remoteValidateC...', Array)
#5 /var/www/vendor/laravel/framework/src/Illuminate/Routing/Route.php(219): Illuminate\Routing\ControllerDispatcher->dispatch(Object(Illuminate\Routing\Route), Object(App\Http\Controllers\FormsController), 'remoteValidateC...')
#6 /var/www/vendor/laravel/framework/src/Illuminate/Routing/Route.php(176): Illuminate\Routing\Route->runController()
#7 /var/www/vendor/laravel/framework/src/Illuminate/Routing/Router.php(680): Illuminate\Routing\Route->run()
#8 /var/www/vendor/laravel/framework/src/Illuminate/Routing/Pipeline.php(30): Illuminate\Routing\Router->Illuminate\Routing\{closure}(Object(Illuminate\Http\Request))
#9 /var/www/vendor/laravel/framework/src/Illuminate/Routing/Middleware/SubstituteBindings.php(41): Illuminate\Routing\Pipeline->Illuminate\Routing\{closure}(Object(Illuminate\Http\Request))
#10 /var/www/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(163): Illuminate\Routing\Middleware\SubstituteBindings->handle(Object(Illuminate\Http\Request), Object(Closure))
#11 /var/www/vendor/laravel/framework/src/Illuminate/Routing/Pipeline.php(53): Illuminate\Pipeline\Pipeline->Illuminate\Pipeline\{closure}(Object(Illuminate\Http\Request))
#12 /var/www/vendor/laravel/framework/src/Illuminate/Foundation/Http/Middleware/VerifyCsrfToken.php(75): Illuminate\Routing\Pipeline->Illuminate\Routing\{closure}(Object(Illuminate\Http\Request))
#13 /var/www/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(163): Illuminate\Foundation\Http\Middleware\VerifyCsrfToken->handle(Object(Illuminate\Http\Request), Object(Closure))
#14 /var/www/vendor/laravel/framework/src/Illuminate/Routing/Pipeline.php(53): Illuminate\Pipeline\Pipeline->Illuminate\Pipeline\{closure}(Object(Illuminate\Http\Request))
#15 /var/www/vendor/laravel/framework/src/Illuminate/View/Middleware/ShareErrorsFromSession.php(49): Illuminate\Routing\Pipeline->Illuminate\Routing\{closure}(Object(Illuminate\Http\Request))
#16 /var/www/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(163): Illuminate\View\Middleware\ShareErrorsFromSession->handle(Object(Illuminate\Http\Request), Object(Closure))
#17 /var/www/vendor/laravel/framework/src/Illuminate/Routing/Pipeline.php(53): Illuminate\Pipeline\Pipeline->Illuminate\Pipeline\{closure}(Object(Illuminate\Http\Request))
#18 /var/www/vendor/laravel/framework/src/Illuminate/Session/Middleware/StartSession.php(56): Illuminate\Routing\Pipeline->Illuminate\Routing\{closure}(Object(Illuminate\Http\Request))
#19 /var/www/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(163): Illuminate\Session\Middleware\StartSession->handle(Object(Illuminate\Http\Request), Object(Closure))
#20 /var/www/vendor/laravel/framework/src/Illuminate/Routing/Pipeline.php(53): Illuminate\Pipeline\Pipeline->Illuminate\Pipeline\{closure}(Object(Illuminate\Http\Request))
#21 /var/www/vendor/laravel/framework/src/Illuminate/Cookie/Middleware/AddQueuedCookiesToResponse.php(37): Illuminate\Routing\Pipeline->Illuminate\Routing\{closure}(Object(Illuminate\Http\Request))
#22 /var/www/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(163): Illuminate\Cookie\Middleware\AddQueuedCookiesToResponse->handle(Object(Illuminate\Http\Request), Object(Closure))
#23 /var/www/vendor/laravel/framework/src/Illuminate/Routing/Pipeline.php(53): Illuminate\Pipeline\Pipeline->Illuminate\Pipeline\{closure}(Object(Illuminate\Http\Request))
#24 /var/www/vendor/laravel/framework/src/Illuminate/Cookie/Middleware/EncryptCookies.php(66): Illuminate\Routing\Pipeline->Illuminate\Routing\{closure}(Object(Illuminate\Http\Request))
#25 /var/www/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(163): Illuminate\Cookie\Middleware\EncryptCookies->handle(Object(Illuminate\Http\Request), Object(Closure))
#26 /var/www/vendor/laravel/framework/src/Illuminate/Routing/Pipeline.php(53): Illuminate\Pipeline\Pipeline->Illuminate\Pipeline\{closure}(Object(Illuminate\Http\Request))
#27 /var/www/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(104): Illuminate\Routing\Pipeline->Illuminate\Routing\{closure}(Object(Illuminate\Http\Request))
#28 /var/www/vendor/laravel/framework/src/Illuminate/Routing/Router.php(682): Illuminate\Pipeline\Pipeline->then(Object(Closure))
#29 /var/www/vendor/laravel/framework/src/Illuminate/Routing/Router.php(657): Illuminate\Routing\Router->runRouteWithinStack(Object(Illuminate\Routing\Route), Object(Illuminate\Http\Request))
#30 /var/www/vendor/laravel/framework/src/Illuminate/Routing/Router.php(623): Illuminate\Routing\Router->runRoute(Object(Illuminate\Http\Request), Object(Illuminate\Routing\Route))
#31 /var/www/vendor/laravel/framework/src/Illuminate/Routing/Router.php(612): Illuminate\Routing\Router->dispatchToRoute(Object(Illuminate\Http\Request))
#32 /var/www/vendor/laravel/framework/src/Illuminate/Foundation/Http/Kernel.php(176): Illuminate\Routing\Router->dispatch(Object(Illuminate\Http\Request))
#33 /var/www/vendor/laravel/framework/src/Illuminate/Routing/Pipeline.php(30): Illuminate\Foundation\Http\Kernel->Illuminate\Foundation\Http\{closure}(Object(Illuminate\Http\Request))
#34 /var/www/vendor/genealabs/laravel-caffeine/src/Http/Middleware/LaravelCaffeineDripMiddleware.php(11): Illuminate\Routing\Pipeline->Illuminate\Routing\{closure}(Object(Illuminate\Http\Request))
#35 /var/www/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(163): GeneaLabs\LaravelCaffeine\Http\Middleware\LaravelCaffeineDripMiddleware->handle(Object(Illuminate\Http\Request), Object(Closure))
#36 /var/www/vendor/laravel/framework/src/Illuminate/Routing/Pipeline.php(53): Illuminate\Pipeline\Pipeline->Illuminate\Pipeline\{closure}(Object(Illuminate\Http\Request))
#37 /var/www/vendor/fideloper/proxy/src/TrustProxies.php(57): Illuminate\Routing\Pipeline->Illuminate\Routing\{closure}(Object(Illuminate\Http\Request))
#38 /var/www/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(163): Fideloper\Proxy\TrustProxies->handle(Object(Illuminate\Http\Request), Object(Closure))
#39 /var/www/vendor/laravel/framework/src/Illuminate/Routing/Pipeline.php(53): Illuminate\Pipeline\Pipeline->Illuminate\Pipeline\{closure}(Object(Illuminate\Http\Request))
#40 /var/www/vendor/laravel/framework/src/Illuminate/Foundation/Http/Middleware/ValidatePostSize.php(27): Illuminate\Routing\Pipeline->Illuminate\Routing\{closure}(Object(Illuminate\Http\Request))
#41 /var/www/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(163): Illuminate\Foundation\Http\Middleware\ValidatePostSize->handle(Object(Illuminate\Http\Request), Object(Closure))
#42 /var/www/vendor/laravel/framework/src/Illuminate/Routing/Pipeline.php(53): Illuminate\Pipeline\Pipeline->Illuminate\Pipeline\{closure}(Object(Illuminate\Http\Request))
#43 /var/www/vendor/laravel/framework/src/Illuminate/Foundation/Http/Middleware/CheckForMaintenanceMode.php(62): Illuminate\Routing\Pipeline->Illuminate\Routing\{closure}(Object(Illuminate\Http\Request))
#44 /var/www/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(163): Illuminate\Foundation\Http\Middleware\CheckForMaintenanceMode->handle(Object(Illuminate\Http\Request), Object(Closure))
#45 /var/www/vendor/laravel/framework/src/Illuminate/Routing/Pipeline.php(53): Illuminate\Pipeline\Pipeline->Illuminate\Pipeline\{closure}(Object(Illuminate\Http\Request))
#46 /var/www/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(104): Illuminate\Routing\Pipeline->Illuminate\Routing\{closure}(Object(Illuminate\Http\Request))
#47 /var/www/vendor/laravel/framework/src/Illuminate/Foundation/Http/Kernel.php(151): Illuminate\Pipeline\Pipeline->then(Object(Closure))
#48 /var/www/vendor/laravel/framework/src/Illuminate/Foundation/Http/Kernel.php(116): Illuminate\Foundation\Http\Kernel->sendRequestThroughRouter(Object(Illuminate\Http\Request))
#49 /var/www/html/index.php(55): Illuminate\Foundation\Http\Kernel->handle(Object(Illuminate\Http\Request))
#50 {main}
"}

@Maescool We're on version 3.5.4, I think the newest "stable" version is 3.6.7 ... I suppose version 4 is a beta or a nightly stable version?
We're planning to add some log statements, to dump the contents of variables and to see which branches (if statements) are being executed, that should enable us to see what's going on.

It seems like this may be due to some custom usage as I haven't seen the error and getCode() generally isn't invoked if there is no code in the session/db. But just in case I have pushed the fix so it does return an empty string like the method signature says. Careful to check the return though!


Arduino Due Port Issue Revisited

I know this issue keeps cropping up. I used my Due's a couple years ago and initially had problems. For some reason it went away. I'm returning to them and the issue is back again. I have two boards both doing the same thing.
Running Ubunutn 16.04.

Yes, I'm accessing the correct port. They appear in /dev, lsusb, etc.
The Arduino 1.8.5 IDE seems to do the upload properly now but I don't know why. It didn't when I first tried it.
I'm using the Eclipse Sloeber plugin because my programs exceed the capacity of the IDE. It doesn't want to upload.

But I've found something interesting. If you omit the port (-p) it works every time from the command line. If you specify the port it fails.
Run this and it uploads:
stty -F /dev/ttyACM0 speed 1200
/home/rmerriam/.arduino15/packages/arduino/tools/bossac/1.6.1-arduino/bossac -d -U false -e -w -b /home/rmerriam/development/Arduino/StrandDev/Due/StrandDev.bin -R
Run this and it doesn't:
stty -F /dev/ttyACM0 speed 1200
/home/rmerriam/.arduino15/packages/arduino/tools/bossac/1.6.1-arduino/bossac -d -U false -e -w -b -p /dev/ttyACM0 /home/rmerriam/development/Arduino/StrandDev/Due/StrandDev.bin -R
No device found on /dev/ttyACM0`
It does the same with bossac installed using the package manager.

No device found on /dev/ttyACM0

I belive that the port changed after board reset from ACM0 to something else like ACM1.


Policy Webhooks - Additional Fields

Is your feature request related to a specific problem?
Pre/post execution webhooks could be made more usable by including additional fields, such as status (for post webhooks) and DSR type (e.g. access vs erasure)
Describe the solution you'd like
The following fields added:

Status (e.g. error, complete, etc)
Type (access or erasure)

Additional context
The use case here is to be able to use post-execution webhooks to send logs/events/metrics to a logging platform.

@RobertKeyser just to be clear, are we only thinking about in the YAML files or also the UI?

@RobertKeyser just to be clear, are we only thinking about in the YAML files or also the UI?

I was mostly thinking just the YAML, do we have a UI for the pre/post execution webhooks yet?

No but it's under consideration, possibly, as I think about how to incorporate more configuration options into the UI

I think we should just include it in the payload of a webhook request for all webhooks.


added df3dPostProcessing.utils as a package in the setup.py to fix an…

… issue with installation

I also addressed this in #13 . I will merge it there because it's trickier to resolve merge conflicts here.


Connecting memento to besu network with ibft2 seems to fail

Using the docker setup with :

alethio/memento:v1.1.4
redis:5.0.5-alpine
postgres:11.5-alpine
alethio/ethereum-lite-explorer:v1.0.0-beta.8
hyperledger/besu:1.4

Gives the following error message in memento :
time="2020-04-20T14:03:31Z" level=info msg="[eth] setting up best block polling"
time="2020-04-20T14:03:31Z" level=error msg="[eth] protocol not recognized, use http(s) or ws(s)"

Moreover, I don't think the problem comes with the RPC url (http://x.x.x.x:8545) because it worked with the alethio lite explorer, when used without memento.
I tried not to show the ws port with ws: "" and after ws: "ws://x.x.x.x:8546" as the webservices are not exposed on the server.
Do memento work with besu 1.4 for a ibft2 network? Or do you think it is due to misconfiguration?
If needed, I can share my config files in a gist

Hello!
From the logs you posted it looks like the  url for eth client connection is wrong.
If you could share the config you used, I might be able to help.

I am trying to debug it a little with a local besu node.
The real node I want to connect to is on a distant server with the websocket port closed. I think it lay be due to that.
I'll keep you in touch !

The gist is located at :
https://gist.github.com/ArvsIndrarys/d842bb92817d93c7488d9911c4a34d9a
Even locally, ( connexion to besu node as http://node:8545) I have the problem.

From the explorer :
/app # curl node0:8545 -v
*   Trying <IP_ADDRESS>:8545...
* TCP_NODELAY set
* Connected to node0 (<IP_ADDRESS>) port 8545 (#0)
> GET / HTTP/1.1
> Host: node0:8545
> User-Agent: curl/7.66.0
> Accept: */*
>
* Mark bundle as not supporting multiuse
< HTTP/1.1 201 Created
< content-length: 0
<
* Connection #0 to host node0 left intact

So the reference to node0 seems to work.

Could you try using the ip directly (<IP_ADDRESS>) instead of node0 and see if that works?

Could you try using the ip directly (<IP_ADDRESS>) instead of node0 and see if that works?

I still have the error

Just noticed you're not setting the correct volume for the memento container.
It should be
- .volumes/memento:/config

You're passing it the explorer config instead, which is a different thing.
- ./explorer/config.json:/config/config.json

That directory should contain the memento.yml file from your gist. Unless specified explicitly via the --config flag, Memento will search for a file named config.yml in that directory -- that means memento.yml will not work.

Okay it works, sorry for the inconvenience ^^'
Do I close the issue or let you close it?

Glad I could help! If you've got other problems, feel free to open another issue. I will close this one for now.
Thank you for using Memento! <3

I have the same freaking problem with ganache.


Add Insertion Sort in C++ , Java & Python

Description
Problem - Sort of Array using Insertion Sort in C++ , Java & Python
Examples -
Inout : 33, 27, 18, 66, 25
Output : 18, 25, 27, 33, 66
Inout : 47, 144, 62, 54, 24
Output : 24, 47, 54, 62, 144
Time Complexity  : O(N2)
Space Complexity : O(1)

Sorry this algorithm has been implemented already


OnchainAPI getgroupmembers issue

https://github.com/interep-project/interep.js/blob/5bc3350c1a05bf58bc25fcac5150ed887cf6c756/packages/api/src/onchainAPI.ts#L77
There seems to be a problem with creatproof. Perhaps there is a problem with merkleproof. This seems to be a problem caused by members not being sorted by index in the subgraph.
members(where: { group: "${groupId}" }, orderBy: index) {
If it is changed as follows, it will be good when using OnchainAPI's getGroupMembers. (Useful for leaveGroup, createProof)
Other features seem to be very useful. Thank you!

Thanks @jdhyun09, it should work now!


Rya 296 hasSelf

Description

What Changed?

Added rule for hasSelf to inferencing
Tests

Coverage?

tests for hasSelf from type, inferring property
tests for hasSelf from property with constant subject, inferring type
tests for hasSelf from property with constant object, inferring type
Links
Jira
Checklist

[ ] Code Review
[ ] Squash Commits

People To Reivew
@jessehatfield - give extra scrutiny towards the tests, I want to make sure it was all done correctly
@meiercaleb
@ejwhite922

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests/401/Build result: FAILURE[...truncated 4.24 MB...][INFO] Apache Rya Spark Support ........................... SKIPPED[INFO] Apache Rya Web Projects ............................ SKIPPED[INFO] Apache Rya Web Implementation ...................... SKIPPED[INFO] ------------------------------------------------------------------------[INFO] BUILD FAILURE[INFO] ------------------------------------------------------------------------[INFO] Total time: 04:22 min[INFO] Finished at: 2017-08-16T17:22:03+00:00[INFO] Final Memory: 291M/2925M[INFO] ------------------------------------------------------------------------[ERROR] Failed to execute goal org.apache.rat:apache-rat-plugin:0.11:check (check-licenses) on project rya.sail: Too many files with unapproved license: 1 See RAT report in: /home/jenkins/jenkins-slave/workspace/incubator-rya-master-with-optionals-pull-requests/sail/target/rat.txt -> [Help 1][ERROR] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.[ERROR] Re-run Maven using the -X switch to enable full debug logging.[ERROR] [ERROR] For more information about the errors and possible solutions, please read the following articles:[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException[ERROR] [ERROR] After correcting the problems, you can resume the build with the command[ERROR]   mvn  -rf :rya.sailchannel stoppedSetting status of f6faef8aae068a67e1104ffa58d8ae1354dd921c to FAILURE with url https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests/401/ and message: 'FAILURE 'Using context: Jenkins: clean package -Pgeoindexing

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests/416/Build result: FAILURE[...truncated 4.25 MB...][INFO] Apache Rya Web Projects ............................ SKIPPED[INFO] Apache Rya Web Implementation ...................... SKIPPED[INFO] ------------------------------------------------------------------------[INFO] BUILD FAILURE[INFO] ------------------------------------------------------------------------[INFO] Total time: 02:20 min[INFO] Finished at: 2017-08-21T15:44:50+00:00[INFO] Final Memory: 309M/2938M[INFO] ------------------------------------------------------------------------[ERROR] Failed to execute goal org.apache.rat:apache-rat-plugin:0.11:check (check-licenses) on project rya.sail: Too many files with unapproved license: 1 See RAT report in: /home/jenkins/jenkins-slave/workspace/incubator-rya-master-with-optionals-pull-requests/sail/target/rat.txt -> [Help 1][ERROR] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.[ERROR] Re-run Maven using the -X switch to enable full debug logging.[ERROR] [ERROR] For more information about the errors and possible solutions, please read the following articles:[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException[ERROR] [ERROR] After correcting the problems, you can resume the build with the command[ERROR]   mvn  -rf :rya.sailchannel stoppedSetting status of 11930ebb9c9308635ceb5e5db91c9afa85bf7f89 to FAILURE with url https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests/416/ and message: 'FAILURE 'Using context: Jenkins: clean package -Pgeoindexing

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests/417/Build result: FAILURE[...truncated 218.74 KB...][INFO] Apache Rya Web Projects ............................ SKIPPED[INFO] Apache Rya Web Implementation ...................... SKIPPED[INFO] ------------------------------------------------------------------------[INFO] BUILD FAILURE[INFO] ------------------------------------------------------------------------[INFO] Total time: 02:03 min[INFO] Finished at: 2017-08-21T16:15:17+00:00[INFO] Final Memory: 113M/3060M[INFO] ------------------------------------------------------------------------[ERROR] Failed to execute goal org.apache.rat:apache-rat-plugin:0.11:check (check-licenses) on project rya.sail: Too many files with unapproved license: 1 See RAT report in: /home/jenkins/jenkins-slave/workspace/incubator-rya-master-with-optionals-pull-requests/sail/target/rat.txt -> [Help 1][ERROR] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.[ERROR] Re-run Maven using the -X switch to enable full debug logging.[ERROR] [ERROR] For more information about the errors and possible solutions, please read the following articles:[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException[ERROR] [ERROR] After correcting the problems, you can resume the build with the command[ERROR]   mvn  -rf :rya.sailchannel stoppedSetting status of 24c7d7698b6fd0d843261350701c2228a4fc1cfc to FAILURE with url https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests/417/ and message: 'FAILURE 'Using context: Jenkins: clean package -Pgeoindexing

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests/421/Build result: FAILURE[...truncated 218.64 KB...][INFO] Apache Rya Web Projects ............................ SKIPPED[INFO] Apache Rya Web Implementation ...................... SKIPPED[INFO] ------------------------------------------------------------------------[INFO] BUILD FAILURE[INFO] ------------------------------------------------------------------------[INFO] Total time: 02:28 min[INFO] Finished at: 2017-08-22T17:14:02+00:00[INFO] Final Memory: 213M/3030M[INFO] ------------------------------------------------------------------------[ERROR] Failed to execute goal org.apache.rat:apache-rat-plugin:0.11:check (check-licenses) on project rya.sail: Too many files with unapproved license: 1 See RAT report in: /home/jenkins/jenkins-slave/workspace/incubator-rya-master-with-optionals-pull-requests/sail/target/rat.txt -> [Help 1][ERROR] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.[ERROR] Re-run Maven using the -X switch to enable full debug logging.[ERROR] [ERROR] For more information about the errors and possible solutions, please read the following articles:[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException[ERROR] [ERROR] After correcting the problems, you can resume the build with the command[ERROR]   mvn  -rf :rya.sailchannel stoppedSetting status of b127d10b90397cc707280f51100bf2dbfdd043cc to FAILURE with url https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests/421/ and message: 'FAILURE 'Using context: Jenkins: clean package -Pgeoindexing

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests/450/Build result: FAILURE[...truncated 218.55 KB...][INFO] Apache Rya Spark Support ........................... SKIPPED[INFO] Apache Rya Web Projects ............................ SKIPPED[INFO] Apache Rya Web Implementation ...................... SKIPPED[INFO] ------------------------------------------------------------------------[INFO] BUILD FAILURE[INFO] ------------------------------------------------------------------------[INFO] Total time: 04:18 min[INFO] Finished at: 2017-08-24T22:21:42+00:00[INFO] Final Memory: 128M/2974M[INFO] ------------------------------------------------------------------------[ERROR] Failed to execute goal org.apache.rat:apache-rat-plugin:0.11:check (check-licenses) on project rya.sail: Too many files with unapproved license: 1 See RAT report in: /home/jenkins/jenkins-slave/workspace/incubator-rya-master-with-optionals-pull-requests/sail/target/rat.txt -> [Help 1][ERROR] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.[ERROR] Re-run Maven using the -X switch to enable full debug logging.[ERROR] [ERROR] For more information about the errors and possible solutions, please read the following articles:[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException[ERROR] [ERROR] After correcting the problems, you can resume the build with the command[ERROR]   mvn  -rf :rya.sailchannel stoppedSetting status of b98a077182852ad648768867291e13a6d844ad05 to FAILURE with url https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests/450/ and message: 'FAILURE 'Using context: Jenkins: clean package -Pgeoindexing

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests/456/Build result: FAILURE[...truncated 218.75 KB...][INFO] Apache Rya Spark Support ........................... SKIPPED[INFO] Apache Rya Web Projects ............................ SKIPPED[INFO] Apache Rya Web Implementation ...................... SKIPPED[INFO] ------------------------------------------------------------------------[INFO] BUILD FAILURE[INFO] ------------------------------------------------------------------------[INFO] Total time: 05:02 min[INFO] Finished at: 2017-08-25T17:01:14+00:00[INFO] Final Memory: 301M/2986M[INFO] ------------------------------------------------------------------------[ERROR] Failed to execute goal org.apache.rat:apache-rat-plugin:0.11:check (check-licenses) on project rya.sail: Too many files with unapproved license: 1 See RAT report in: /home/jenkins/jenkins-slave/workspace/incubator-rya-master-with-optionals-pull-requests/sail/target/rat.txt -> [Help 1][ERROR] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.[ERROR] Re-run Maven using the -X switch to enable full debug logging.[ERROR] [ERROR] For more information about the errors and possible solutions, please read the following articles:[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException[ERROR] [ERROR] After correcting the problems, you can resume the build with the command[ERROR]   mvn  -rf :rya.sailchannel stoppedSetting status of 91093655eb0d2f0f489daf27e2349d2911103129 to FAILURE with url https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests/456/ and message: 'FAILURE 'Using context: Jenkins: clean package -Pgeoindexing

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests/458/


fix: Render single sheet without a title

Related Issues
fixes #500

:tada: This PR is included in version 6.29.1 :tada:
The release is available on:

GitHub release
v6.29.1

Your semantic-release bot :package::rocket:


Introduce devtools 3.1.3 bsdmake

Description of changes

Current source releases get this from version 3.2.6 of the Developer Tools. However, this seems arbitrary since they were available as recent as version 4.2 and as early as version 3.1.3.
My rationale for picking the oldest available source is if we introduced it as early as that version we wouldn't have needed to ever bump it. It's also a more honest representation of how old the sources we depend on are.
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[x] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

I think we can actually drop this. It's only used in adv_cmds/boot.nix, which isn't actually used anywhere AFAICT.


fix(.travis.yml): fix some elan

Let's try that again

"Surely he won't merge this one immediately too", I thought... :P
Well, I believe I fixed the issue in the elan repo, so mathlib should work from now on. You can also go into Travis and restart the job for the current head if you want.

Hm, I have no idea about Travis. So I completely rely on you :)

Build is green now :) . I found out that I can actually restart the build myself.


Disable client-side validation on Django 1.10 for multipart forms

Client-side validation fails on forms with prefilled file upload fields -
see https://code.djangoproject.com/ticket/27037. This is fixed in Django 1.10.1,
so as a workaround we disable client-side validation (using the 'novalidate'
attribute) for forms with enctype="multipart/form-data" on Django 1.10 only.
Fixes #2897

Looks good to me.
Do you think we need to mention this issue in the release notes or somewhere else?

Have added a short note under "Bug fixes" - I don't think we need to mention it in more detail, as there isn't really anything an end user needs to be aware of, or any action they can take (other than "upgrade to 1.10.1 when it's released", which is standard good advice anyhow :-) )
Merged in 197d85ce9f674e319cc7d7d0fa6e0a05dc6a46d7 (master) and f753a1c66ea9e25f1f2c96fbaa87b3419bb39a1c (1.6.x).


Upgrade Interfaces to be Compatible with Blockchain

This patch upgrades the interfaces of EVM to make sure that they are fully compatible with an implementation in the Blockchain app. The majority of the changes are minor changes to be compliant with this new version of the API interface. We also eradicate ContractInterface and store everything in AccountInterface.

See https://github.com/exthereum/blockchain/pull/12


Set proper ingress defaults for galley meshcfg

Fixes https://github.com/istio/istio/issues/17148
WIP because I am going to add some tests for this.

@howardjohn: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-galley-local-tests_istio
5dd31c716093efba4bc8c88e7b19cff23ee9b880
link
/test integ-galley-local-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-galley-local-tests_istio
5dd31c716093efba4bc8c88e7b19cff23ee9b880
link
/test integ-galley-local-tests

e2e-dashboard_istio
5dd31c716093efba4bc8c88e7b19cff23ee9b880
link
/test e2e-dashboard

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-galley-local-tests_istio
5dd31c716093efba4bc8c88e7b19cff23ee9b880
link
/test integ-galley-local-tests

e2e-dashboard_istio
5dd31c716093efba4bc8c88e7b19cff23ee9b880
link
/test e2e-dashboard

pilot-multicluster-e2e_istio
5dd31c716093efba4bc8c88e7b19cff23ee9b880
link
/test pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-galley-local-tests_istio
5dd31c716093efba4bc8c88e7b19cff23ee9b880
link
/test integ-galley-local-tests

e2e-dashboard_istio
5dd31c716093efba4bc8c88e7b19cff23ee9b880
link
/test e2e-dashboard

pilot-multicluster-e2e_istio
5dd31c716093efba4bc8c88e7b19cff23ee9b880
link
/test pilot-multicluster-e2e

codecov_istio
5dd31c716093efba4bc8c88e7b19cff23ee9b880
link
/test codecov

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-galley-local-tests_istio
5dd31c716093efba4bc8c88e7b19cff23ee9b880
link
/test integ-galley-local-tests

e2e-dashboard_istio
5dd31c716093efba4bc8c88e7b19cff23ee9b880
link
/test e2e-dashboard

pilot-multicluster-e2e_istio
5dd31c716093efba4bc8c88e7b19cff23ee9b880
link
/test pilot-multicluster-e2e

codecov_istio
5dd31c716093efba4bc8c88e7b19cff23ee9b880
link
/test codecov

integ-new-install-k8s-tests_istio
5dd31c716093efba4bc8c88e7b19cff23ee9b880
link
/test integ-new-install-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-galley-local-tests_istio
5dd31c716093efba4bc8c88e7b19cff23ee9b880
link
/test integ-galley-local-tests

e2e-dashboard_istio
5dd31c716093efba4bc8c88e7b19cff23ee9b880
link
/test e2e-dashboard

pilot-multicluster-e2e_istio
5dd31c716093efba4bc8c88e7b19cff23ee9b880
link
/test pilot-multicluster-e2e

codecov_istio
5dd31c716093efba4bc8c88e7b19cff23ee9b880
link
/test codecov

integ-new-install-k8s-tests_istio
5dd31c716093efba4bc8c88e7b19cff23ee9b880
link
/test integ-new-install-k8s-tests

integ-mixer-k8s-tests_istio
5dd31c716093efba4bc8c88e7b19cff23ee9b880
link
/test integ-mixer-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

pilot-multicluster-e2e_istio
5dd31c716093efba4bc8c88e7b19cff23ee9b880
link
/test pilot-multicluster-e2e

integ-mixer-k8s-tests_istio
5dd31c716093efba4bc8c88e7b19cff23ee9b880
link
/test integ-mixer-k8s-tests

integ-new-install-k8s-tests_istio
4bca3653547a22218df044b478f0ae8eb2bcafcb
link
/test integ-new-install-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

pilot-multicluster-e2e_istio
5dd31c716093efba4bc8c88e7b19cff23ee9b880
link
/test pilot-multicluster-e2e

integ-new-install-k8s-tests_istio
4bca3653547a22218df044b478f0ae8eb2bcafcb
link
/test integ-new-install-k8s-tests

integ-mixer-k8s-tests_istio
4bca3653547a22218df044b478f0ae8eb2bcafcb
link
/test integ-mixer-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-new-install-k8s-tests_istio
4bca3653547a22218df044b478f0ae8eb2bcafcb
link
/test integ-new-install-k8s-tests

integ-mixer-k8s-tests_istio
4bca3653547a22218df044b478f0ae8eb2bcafcb
link
/test integ-mixer-k8s-tests

racetest_istio
ab31410f400b5eb81a8d228220c7e11f07e967ea
link
/test racetest

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-new-install-k8s-tests_istio
4bca3653547a22218df044b478f0ae8eb2bcafcb
link
/test integ-new-install-k8s-tests

integ-mixer-k8s-tests_istio
4bca3653547a22218df044b478f0ae8eb2bcafcb
link
/test integ-mixer-k8s-tests

racetest_istio
ab31410f400b5eb81a8d228220c7e11f07e967ea
link
/test racetest

integ-pilot-local-tests_istio
ab31410f400b5eb81a8d228220c7e11f07e967ea
link
/test integ-pilot-local-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-new-install-k8s-tests_istio
4bca3653547a22218df044b478f0ae8eb2bcafcb
link
/test integ-new-install-k8s-tests

integ-mixer-k8s-tests_istio
4bca3653547a22218df044b478f0ae8eb2bcafcb
link
/test integ-mixer-k8s-tests

racetest_istio
ab31410f400b5eb81a8d228220c7e11f07e967ea
link
/test racetest

integ-pilot-local-tests_istio
ab31410f400b5eb81a8d228220c7e11f07e967ea
link
/test integ-pilot-local-tests

codecov_istio
ab31410f400b5eb81a8d228220c7e11f07e967ea
link
/test codecov

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-mixer-k8s-tests_istio
4bca3653547a22218df044b478f0ae8eb2bcafcb
link
/test integ-mixer-k8s-tests

racetest_istio
ab31410f400b5eb81a8d228220c7e11f07e967ea
link
/test racetest

integ-pilot-local-tests_istio
ab31410f400b5eb81a8d228220c7e11f07e967ea
link
/test integ-pilot-local-tests

codecov_istio
ab31410f400b5eb81a8d228220c7e11f07e967ea
link
/test codecov

integ-new-install-k8s-tests_istio
ab31410f400b5eb81a8d228220c7e11f07e967ea
link
/test integ-new-install-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

racetest_istio
ab31410f400b5eb81a8d228220c7e11f07e967ea
link
/test racetest

integ-pilot-local-tests_istio
ab31410f400b5eb81a8d228220c7e11f07e967ea
link
/test integ-pilot-local-tests

codecov_istio
ab31410f400b5eb81a8d228220c7e11f07e967ea
link
/test codecov

integ-new-install-k8s-tests_istio
ab31410f400b5eb81a8d228220c7e11f07e967ea
link
/test integ-new-install-k8s-tests

integ-mixer-k8s-tests_istio
ab31410f400b5eb81a8d228220c7e11f07e967ea
link
/test integ-mixer-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

codecov_istio
ab31410f400b5eb81a8d228220c7e11f07e967ea
link
/test codecov

integ-new-install-k8s-tests_istio
ab31410f400b5eb81a8d228220c7e11f07e967ea
link
/test integ-new-install-k8s-tests

integ-mixer-k8s-tests_istio
ab31410f400b5eb81a8d228220c7e11f07e967ea
link
/test integ-mixer-k8s-tests

integ-pilot-local-tests_istio
ab31410f400b5eb81a8d228220c7e11f07e967ea
link
/test integ-pilot-local-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

codecov_istio
ab31410f400b5eb81a8d228220c7e11f07e967ea
link
/test codecov

integ-new-install-k8s-tests_istio
ab31410f400b5eb81a8d228220c7e11f07e967ea
link
/test integ-new-install-k8s-tests

integ-mixer-k8s-tests_istio
ab31410f400b5eb81a8d228220c7e11f07e967ea
link
/test integ-mixer-k8s-tests

e2e-mixer-no_auth_istio
aa4c47e0f3dd198303bda647c22049d8f2432019
link
/test e2e-mixer-no_auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-mixer-k8s-tests_istio
ab31410f400b5eb81a8d228220c7e11f07e967ea
link
/test integ-mixer-k8s-tests

e2e-mixer-no_auth_istio
aa4c47e0f3dd198303bda647c22049d8f2432019
link
/test e2e-mixer-no_auth

integ-new-install-k8s-tests_istio
aa4c47e0f3dd198303bda647c22049d8f2432019
link
/test integ-new-install-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

BTW, is there a plan to deprecate ingress?

/retest

@howardjohn: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-new-install-k8s-tests_istio
aa4c47e0f3dd198303bda647c22049d8f2432019
link
/test integ-new-install-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

lintmodern_istio
b68a635eb695350fe0cf56573dbd8f2cb2550965
link
/test lintmodern

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

lintmodern_istio
b68a635eb695350fe0cf56573dbd8f2cb2550965
link
/test lintmodern

lint_istio
b68a635eb695350fe0cf56573dbd8f2cb2550965
link
/test lint

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

lintmodern_istio
b68a635eb695350fe0cf56573dbd8f2cb2550965
link
/test lintmodern

lint_istio
b68a635eb695350fe0cf56573dbd8f2cb2550965
link
/test lint

integ-mixer-k8s-tests_istio
b68a635eb695350fe0cf56573dbd8f2cb2550965
link
/test integ-mixer-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-mixer-k8s-tests_istio
b68a635eb695350fe0cf56573dbd8f2cb2550965
link
/test integ-mixer-k8s-tests

e2e-bookInfoTests-trustdomain_istio
0f726aa26c3106d64fbdcbd1f6a9d4b4b3953e1d
link
/test e2e-bookInfoTests-trustdomain

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

e2e-bookInfoTests-trustdomain_istio
0f726aa26c3106d64fbdcbd1f6a9d4b4b3953e1d
link
/test e2e-bookInfoTests-trustdomain

integ-mixer-k8s-tests_istio
0f726aa26c3106d64fbdcbd1f6a9d4b4b3953e1d
link
/test integ-mixer-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@rshriram mind taking a look?

/cherrypick release-1.3

@howardjohn: #17190 failed to apply on top of branch "release-1.3":
Applying: Fix tests
Applying: Add integration test
Applying: Fix test
Applying: fix new install
Applying: Update other default as well
error: Failed to merge in the changes.
Using index info to reconstruct a base tree...
M	galley/pkg/config/meshcfg/defaults.go
M	galley/pkg/config/meshcfg/defaults_test.go
Falling back to patching base and 3-way merge...
Auto-merging galley/pkg/config/meshcfg/defaults_test.go
CONFLICT (content): Merge conflict in galley/pkg/config/meshcfg/defaults_test.go
Patch failed at 0006 Update other default as well

In response to this:

/cherrypick release-1.3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.


Install error with utils.sh

I succeeded to install microk8s several months ago but now I can't.
OS: Ubuntu 18.04
$ sudo snap install microk8s --classic
2019-04-02T10:16:17+09:00 INFO Waiting for restart...
error: cannot perform the following tasks:
- Run install hook of "microk8s" snap if present (run hook "install":
-----
+ export LD_LIBRARY_PATH=/snap/microk8s/492/lib:/snap/microk8s/492/usr/lib:/snap/microk8s/492/lib/x86_64-linux-gnu:/snap/microk8s/492/usr/lib/x86_64-linux-gnu
+ LD_LIBRARY_PATH=/snap/microk8s/492/lib:/snap/microk8s/492/usr/lib:/snap/microk8s/492/lib/x86_64-linux-gnu:/snap/microk8s/492/usr/lib/x86_64-linux-gnu
+ export PATH=/snap/microk8s/492/usr/sbin:/snap/microk8s/492/usr/bin:/snap/microk8s/492/sbin:/snap/microk8s/492/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games:/usr/bin:/usr/local/bin
+ PATH=/snap/microk8s/492/usr/sbin:/snap/microk8s/492/usr/bin:/snap/microk8s/492/sbin:/snap/microk8s/492/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games:/usr/bin:/usr/local/bin
+ source /snap/microk8s/492/actions/common/utils.sh
+ cp -r /snap/microk8s/492/default-args /var/snap/microk8s/492/args
+ mkdir /var/snap/microk8s/492/certs
+ openssl genrsa -out /var/snap/microk8s/492/certs/serviceaccount.key 2048
Generating RSA private key, 2048 bit long modulus
................................+++
......................................................+++
unable to write 'random state'
e is 65537 (0x010001)
+ openssl genrsa -out /var/snap/microk8s/492/certs/ca.key 2048
Generating RSA private key, 2048 bit long modulus
...............................+++
....+++
unable to write 'random state'
e is 65537 (0x010001)
+ openssl req -x509 -new -nodes -key /var/snap/microk8s/492/certs/ca.key -subj /CN=<IP_ADDRESS> -days 10000 -out /var/snap/microk8s/492/certs/ca.crt
+ openssl genrsa -out /var/snap/microk8s/492/certs/server.key 2048
Generating RSA private key, 2048 bit long modulus
...................................................+++
..........................+++
unable to write 'random state'
e is 65537 (0x010001)
++ get_default_ip
+++ /snap/microk8s/492/bin/netstat -rn
+++ /snap/microk8s/492/bin/grep '^<IP_ADDRESS>'
+++ /snap/microk8s/492/usr/bin/gawk '{print $NF}'
+++ head -1
++ local DEFAULT_INTERFACE=ens33
+++ /snap/microk8s/492/sbin/ifconfig ens33
+++ /snap/microk8s/492/bin/grep 'inet '
+++ /snap/microk8s/492/bin/sed -e s/addr://
+++ /snap/microk8s/492/usr/bin/gawk '{print $2}'
++ local IP_ADDR=
++ echo
+ IP_ADDR=
+ produce_server_cert
/snap/microk8s/492/actions/common/utils.sh: 行 108: $1: 未割り当ての変数です
-----)

行: Row
未割り当ての変数です: Undefined variable

Also for me!

Same here
I just installed 18.04
I added the snap for minikube, then removed (not sure if it's relevant)
I installed net-toools (which wasn't)

FYI, I saw this error several weeks ago for the first time.

@marcoalbarelli @Bebbolus the fix just landed on edge. Would you please give it a try with:
sudo snap install microk8s --edge --classic

Please let me know if this works for you so we can release it to the rest of the channels. Thanks

Works for me
Thanks for the swift fix :)

fixed for me:
$ sudo snap install microk8s --edge --classic
microk8s (edge) v1.14.0 from Canonical✓ installed
$ microk8s.status
microk8s is not running. Use microk8s.inspect for a deeper inspection.
$ microk8s.status --wait-ready
microk8s is running
addons:
jaeger: disabled
fluentd: disabled
gpu: disabled
storage: disabled
registry: disabled
ingress: disabled
dns: disabled
metrics-server: disabled
prometheus: disabled
istio: disabled
dashboard: disabled
Thank you!


Add generic type for command name to Composer.command method

When you have a command list that you use both in code and, for example, to automatically set your commands with WebHook in a different place - this typing could be useful.

Out of curiosity—the screenshots you posted show Telegraf code. Are you planning on migrating a bot?

Out of curiosity—the screenshots you posted show Telegraf code. Are you planning on migrating a bot?

Ye, looking into it, I like typings here more, but I still on telegraf for the moment.


The babel config loading is taken to a separate file

Now everything regarding loading babel configuration is handled in a single file. So by requiring this file you can get the complete babel config. This should help supporting tools like storybook snapshot tests to get users babel config.

This looks great for me.
I'll get this.

Okay. This looks great.


[func-sig-opts][+0->+1] Rename OwnershipChecker.h => OwnershipUtils.h

I am going to be expanding this to contain more general utilities so naming the
file OwnershipChecker.h really doesn't make sense.
rdar://38196046

The linux failure isn't from this PR. It has something to do with misc/stats or something like that.

@swift-ci smoke test linux platform


visualize.py issue

Running the visualize.py script I got this error
Error message
gene1_start = min([x[0][1][0][0] for x in list(alignments.values()) if x[0][0] == breakpoints[0][0]])
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
ValueError: min() arg is an empty sequence
This is the code I run:
python3 visualize_fusion.py \
    -o fusion_browser_shot.png \
    -a gencode.v38.annotation.gtf \
    -f prefix.breakpoints.groups.bed \
    -b prefix.mapped.bam

I took as input the gtf file used for the pbfusion run, the prefix.breakpoints.groups.bed generated after the pbfusion run, and the aligned Iso-Seq HiFi data in a BAM file format (used also in the pbfusion). Maybe is this last BAM file that I used which is not the right one..

I think I know what the issue is and should have a fix soon. Would you be able to send me the breakpoint that you're trying to plot and the associated reads in a filtered bam please?

I think I know what the issue is and should have a fix soon. Would you be able to send me the breakpoint that you're trying to plot and the associated reads in a filtered bam please?

Thank you so much for your reply!
These are the 2 files you requested, let me know if there are some problems (these are txt files, I could not upload BED or BAM files apparently..). Also, I forgot to mention that I'm using the gencode.v38.chr_patch_hapl_scaff.annotation.gtf as GTF file
breakpoint.bed.txt
reads_filtered.bam.txt

We should have a release to fix this issue in the next few days, @meryyr

我想我知道问题是什么并且应该尽快解决。您能否尝试较差的断点以及过滤后的 bam 中的相关读数发送给我？

非常感谢你的回复！ 这是您请求的2个文件，如果有问题请告诉我（这些是txt文件，我显然无法上传BED或BAM文件..）。另外，我记得想起我正在使用gencode .v38.chr_patch_hapl_scaff.annotation.gtf 作为 GTF 文件
Breakpoint.bed.txtreads_filtered.bam.txt
Hello, I recently encountered the same problem as you, has your problem been solved?

We should have a release to fix this issue in the next few days, @meryyr

Perfect, thank you so much!

我想我知道问题是什么并且应该尽快解决。您能否尝试较差的断点以及过滤后的 bam 中的相关读数发送给我？

非常感谢你的回复！ 这是您请求的2个文件，如果有问题请告诉我（这些是txt文件，我显然无法上传BED或BAM文件..）。另外，我记得想起我正在使用gencode .v38.chr_patch_hapl_scaff.annotation.gtf 作为 GTF 文件
Breakpoint.bed.txtreads_filtered.bam.txt
Hello, I recently encountered the same problem as you, has your problem been solved?

Hello, the problem has not been solved yet, but should be in the days

@meryyr would you be able to send the header for your reads please? Just send the output of samtools view -H reads_filtered.bam. I'm having trouble reproducing your breakpoint + pysam won't take the file without a header

@tky199996 I've just released v0.4.1 and updated the visualization script, which should hopefully fix your error.
@meryyr Your fusion is a bit more complex (there's an N/A in the gene list), so it might take a bit of fiddling to get the visualization script working. Once you provide me with the header for your alignment file, I'll be able to test and see what modifications need to be made such that you can visualize your fusion. It should be noted that the visualization script doesn't support complex fusions (>2 genes).

@tky199996 I've just released v0.4.1 and updated the visualization script, which should hopefully fix your error.
@meryyr Your fusion is a bit more complex (there's an N/A in the gene list), so it might take a bit of fiddling to get the visualization script working. Once you provide me with the header for your alignment file, I'll be able to test and see what modifications need to be made such that you can visualize your fusion. It should be noted that the visualization script doesn't support complex fusions (>2 genes).
Hello, thank you for your help. Thank you very much. I wonder what time it is over there now? I tried a new script, but the problem still occurred. I will now upload my input file. Can you help me see if it is a file format problem? Thank you again.

I just found that my bam file cannot be transferred. I uploaded a screenshot of the title of my bam file. I hope this will work.

Then the two above are my gtf file and the bed file without title line obtained using pbfusion.
Thank you for your help and hope we can resolve this issue successfully

At the same time, I also noticed that there are N/A identifiers in some files. What does this mean? Is it an unknown gene?

@tky199996 I've just released v0.4.1 and updated the visualization script, which should hopefully fix your error.
@meryyr Your fusion is a bit more complex (there's an N/A in the gene list), so it might take a bit of fiddling to get the visualization script working. Once you provide me with the header for your alignment file, I'll be able to test and see what modifications need to be made such that you can visualize your fusion. It should be noted that the visualization script doesn't support complex fusions (>2 genes).

Sorry for the late reply, and thank you for the help! the zip file attached contains the header of the aligned reads (reads aligned with the pbmm2 tool), I hope this is the output you need! Please let me know if you need something else :)
header_aligned.zip

 At the same time, I also noticed that there are N/A identifiers in some files. What does this mean? Is it an unknown gene?

yes, I think that N/A means that is a segment not matching known genes

@tky199996 the visualization script update is meant to be used with pbfusion v0.4.1 (it contains a bugfix for getting genes and their IDs ordered 5->3 in the bed file). Did you rerun with the new binary?
@meryyr Thanks for the header - I'll see if I can get this working

@meryyr in looking at your fusion I discovered an edge case that I need to fix. I'll close this for now until I have a fix (maybe next week).

@meryyr in looking at your fusion I discovered an edge case that I need to fix. I'll close this for now until I have a fix (maybe next week).

Okay thank you so much! Let me know if you have some news :)

Hey! I faced the similar issue as well:
gene1_start = min([x[0][1][0][0] for x in list(alignments.values())]) ValueError: min() arg is an empty sequence
below is the screenshot of my BAM file without header (because the header is really long):

Wondering are there any solutions or fixes avaible for this issue?

Just wanted to let folks know that we've released a new version 0.5.1 which includes major updates to the visualization script.


[mgmt] storagemover release

https://github.com/Azure/sdk-release-request/issues/5264

/azp run js - storagemover - mgmt - ci

/check-enforcer override


[Feature] Filter operator "not-equals" for "status" and fast-filter button on ui

It will be useful to have possibility make filter status !== ok

Will be great if tag unresolved on testrun works as button for fast apply this filter

It will be useful to have possibility make filter status !== ok

could you elaborate what is the use case?
we could add some custom filters there https://material-ui.com/ru/components/data-grid/filtering/#custom-filter-operator

Will be great if tag unresolved on testrun works as button for fast apply this filter

not sure that this would be useful as build status is changing all the time
would default sorting by unresolved status solve the issue?