View exception handling fix (discussion)

I've started this PR as it needs to be fixed, but unsure as to how you would like it handled @taylorotwell . If you can provide some direction I'll resolve and then update this PR.

Can you describe the issue?

Also it seems sort of weird we would return exception results back out as the view result? Wouldn't taht potentially show an exception message to users of the application?

If I do an include in a view:
@include('partials.something')

And that partial generates an exception - you get a message something like this:
__toString should not generat an exception at....

And it doesn't give any real feedback information.
The code in the PR is just to demonstrate and get the discussion going - am happy to implement/change whatever you think would suit it best. I also don't like how it is written currently - it's ugly. But we need to do something :)

Yeah, the solution presented doesn't seem acceptable as it just returns an error message as if that is what the view rendered, which would be confusing. I wish PHP would let you throw exceptions from __toString but it doesn't. How did you cause this error. Are you echoing a view without calling render?

@taylorotwell na as I mentioned before, just doing an @include of a view from within a blade template that throws an exception.

@taylorotwell perhaps the language-friendly approach would not to use __toString for the render. Perhaps @include could instead call another method outputRender (or something) that immediately echoes the output from the method (which is effectively what __toString is doing. This way we can still have our nice exception handling?

Well @include does call ->render(), it doesn't use __toString. Was there
another view inside that view?
On Wed, Mar 11, 2015 at 9:03 PM, Kirk Bushell<EMAIL_ADDRESS>wrote:

@taylorotwell https://github.com/taylorotwell perhaps the
language-friendly approach would not to use __toString for the render.
Perhaps @include https://github.com/include could instead call another
method outputRender (or something) that immediately echoes the output from
the method (which is effectively what __toString is doing. This way we can
still have our nice exception handling?
—
Reply to this email directly or view it on GitHub
https://github.com/laravel/framework/pull/7965#issuecomment-78410996.

@taylorotwell hmmm, it could have been. It's a nested menu system, so it could have been several levels down. They all use @include, though.
It does this:
@include('partials.menu')
Then inside that, somewhere:
@include('partials.menu') or @include('partials/menuitem')
So it could be 3-4 levels deep.

If you look in BladeCompiler you can see that compileInclude calls
->render() so I'm not sure how __toString would ever be called.
On Wed, Mar 11, 2015 at 9:11 PM, Kirk Bushell<EMAIL_ADDRESS>wrote:

@taylorotwell https://github.com/taylorotwell hmmm, it could have been.
It's a nested menu system, so it could have been several levels down. They
all use @include https://github.com/include, though.
It does this:
@include https://github.com/include('partials.menu')
Then inside that, somewhere:
@include https://github.com/include('partials.menu') or @include
https://github.com/include('partials/menuitem')
So it could be 3-4 levels deep.
—
Reply to this email directly or view it on GitHub
https://github.com/laravel/framework/pull/7965#issuecomment-78411648.

Alright, this is the full menu.blade.php and item.blade.php:
menu

name }}" class="menu children">
    @foreach ($menu->children() as $child)
        @include('partials.menu.item', ['item' => $child])
    @endforeach

item
<?php
$classes = [];

if ($item->isParent()) {
    $classes[] = 'parent';
}
if ($item->isActive()) {
    $classes[] = 'active';
}
?>

    @if ($item->isRenderable())
        @if ($item->isParent())

                @if ($item->icon())
                    icon() }}">
                @endif
                {{ $item->text }}

            {!! HTML::menu($item->name) !!}
        @else
            link }}"@if ($item->isActive()) class="active"@endif>
                @if ($item->icon())
                    icon() }}">
                @endif
                {{ $item->text }}

        @endif
    @endif

I came across the same problem here, the only solution was to debug the __toString method. Yesterday, when not aware of this discussion, I even created a PR with the solution I found.
I think that debugging the __toString method is not the best solution, but was the only that I was able to find.
use Symfony\Component\Debug\ExceptionHandler as SymfonyDisplayer;
...
public function __toString()
{
	try
	{
		$contents = $this->render();
	}
	catch(\Exception $e) {
		$exceptionHandler = (new SymfonyDisplayer(config('app.debug')))->createResponse($e);
		die($exceptionHandler->getContent());
	}

	return $contents;
}

Yeah we definitely need @taylorotwell's input regarding how he wants to handle this. I've encountered it more than a handful of times and each time is a real pain to debug.

I think the first step is figuring out where in your application __toString is being called from, perhaps with a debug_backtrace.

@taylorotwell will that help, though? I think this is an unseen issue due to perhaps the way we use blade templates and includes (not sure). I wonder if resolving how __toString is handled on the view will at least alleviate that problem not just now, but in the future.

Once we know where it's called, we might be able to come up with a better solution where calling __toString is avoided.
For a readable stack, use:
echo (new \Exception)->getTraceAsString();

Yeah my point is same as @JoostK, the framework itself should never really be calling __toString so we need to figure out where that is happening so we can make it call ->render() instead. PHP (for now) is never going to let us give a clean exception out of __toString so best to just avoid it together.

Okay good point - will investigate further.
@JoostK thanks for the sample code, will use that to debug.

Right, here's the full stack:
#0 /home/vagrant/AwardForce/storage/framework/views/6faf30a2d9347875c5edecdce8fceeb6(29): Illuminate\View\View->__toString() #1 /home/vagrant/AwardForce/vendor/laravel/framework/src/Illuminate/View/Engines/PhpEngine.php(39): include('/home/vagrant/A...') #2 /home/vagrant/AwardForce/vendor/laravel/framework/src/Illuminate/View/Engines/CompilerEngine.php(57): Illuminate\View\Engines\PhpEngine->evaluatePath('/home/vagrant/A...', Array) #3 /home/vagrant/AwardForce/vendor/laravel/framework/src/Illuminate/View/View.php(136): Illuminate\View\Engines\CompilerEngine->get('/home/vagrant/A...', Array) #4 /home/vagrant/AwardForce/vendor/laravel/framework/src/Illuminate/View/View.php(104): Illuminate\View\View->getContents() #5 /home/vagrant/AwardForce/vendor/laravel/framework/src/Illuminate/View/View.php(78): Illuminate\View\View->renderContents() #6 /home/vagrant/AwardForce/vendor/laravel/framework/src/Illuminate/Http/Response.php(44): Illuminate\View\View->render() #7 /home/vagrant/AwardForce/vendor/symfony/http-foundation/Symfony/Component/HttpFoundation/Response.php(202): Illuminate\Http\Response->setContent(Object(Illuminate\View\View)) #8 /home/vagrant/AwardForce/vendor/laravel/framework/src/Illuminate/Routing/Router.php(1185): Symfony\Component\HttpFoundation\Response->__construct(Object(Illuminate\View\View)) #9 /home/vagrant/AwardForce/vendor/laravel/framework/src/Illuminate/Routing/Router.php(663): Illuminate\Routing\Router->prepareResponse(Object(Illuminate\Http\Request), Object(Illuminate\View\View)) #10 /home/vagrant/AwardForce/vendor/laravel/framework/src/Illuminate/Routing/Router.php(618): Illuminate\Routing\Router->dispatchToRoute(Object(Illuminate\Http\Request)) #11 /home/vagrant/AwardForce/vendor/laravel/framework/src/Illuminate/Foundation/Http/Kernel.php(157): Illuminate\Routing\Router->dispatch(Object(Illuminate\Http\Request)) #12 [internal function]: Illuminate\Foundation\Http\Kernel->Illuminate\Foundation\Http\{closure}

What is in that compiled view (6faf30a2d9347875c5edecdce8fceeb6) on that line 29?

Ahhh, okay now we're getting closer.
Line #29, is this:
<?php echo HTML::menu('main'); ?>

Which is this macro:
HTML::macro('menu', function ($menu) {
    // If a menu instance was not passed, let's instead try and fetch the menu by name
    if (!($menu instanceof \Tectonic\Shift\Library\Menu\Menu)) {
        $menu = Menufy::menu($menu)->first();
    }

    // Render the menu
    return view('partials.menu.menu', compact('menu'));
});

I think now I realise the issue - view should probably return render?

Yep. return view()->render();

Okay cool, soooo....
This is a slightly different behaviour from what is recommended when working with controllers (obviously). Is there anything you'd like to change or for me to work on @taylorotwell to try and avoid this in future?

I wonder if __toString is necessary in this case, as it seems to create problems if exceptions are thrown in views?

Aka, should __toString be removed?

What's interesting is that apparently we can use trigger_error from within the __toString method to perhaps raise an error message.
http://php.net/manual/en/function.trigger-error.php

For reference: http://stackoverflow.com/questions/2429642/why-its-impossible-to-throw-exception-from-tostring

Perhaps HTML macros should automatically call ->render() if the returned value is a RenderableInterface?

I'm curious if we can catch the exception in __toString and do this...
trigger_error((string) $exception, E_USER_ERROR);

That's not a bad idea either (as another solution) - but html/form is being managed by laravel-collective now and they've made it clear to me that no improvements/changes/extra features will be forthcoming.
@taylorotwell will test now :)

@taylorotwell unfortunately it results in the same error:
FatalErrorException in 6faf30a2d9347875c5edecdce8fceeb6 line 0:
Method Illuminate\View\View::__toString() must not throw an exception
This is when triggering an error manually if an exception has been caught:
public function __toString()
	{
        try {
            return $this->render();
        }
        catch (\Exception $e) {
            trigger_error((string) $e, E_USER_ERROR);
        }
}

it seems to me that the only way this is happening is if an echo is done directly on the view in these helpers.
@taylorotwell what's the need for __toString if it's never been called by Laravel itself?

The need is because some people still call it (as evidence by this PR) :) haha... but yeah ideally it would just be removed entirely

@taylorotwell yup, true - but it results in an issue that cannot be easily resolved.
It seems to me using __toString on a rather lengthy/complex set of logic which can result in exceptions being thrown, simply means annoyed developers as it's rather a pain to debug.
i double-checked by fixing up all my macros/helpers and then throw an exception in __toString - it never gets called by the framework itself.
This would be a breaking change - but I think a minor one.

We're only about 8 weeks away from 5.1. We can probably remove it there.

I may have another solution for now :)

See: https://github.com/laravel/framework/pull/7980

Another hack I just thought of is assigning the exception to a static property and at the end of the request throwing that exception if it's been set. This may however give an incorrect stacktrace, I'm not sure how generating an exception and throwing it somewhere different affects the trace.

Yeah that would be very hacky - the trace would start from where it's thrown.

Actually that's not what happens, it works pretty nicely. There is no sign of it being thrown somewhere completely different.

Hmmm, I've seen quite the opposite when dealing with caught exceptions that are re-thrown in Laravel. Perhaps something else was at play...

If an exception is caught and then a new exception was created, then yes. Quoting from a comment in the PHP documentation:
Note that an exception's properties are populated when the exception is *created*, not when it is thrown.  Throwing the exception does not seem to modify them.

Among other things, this means:

* The exception will blame the line that created it, not the line that threw it.

* Unlike in some other languages, rethrowing an exception doesn't muck up the trace.

* A thrown exception and an unthrown one look basically identical.  On my machine, the only visible difference is that a thrown exception has an `xdebug_message` property while an unthrown one doesn't.  Of course, if you don't have xdebug installed, you won't even get that.

yeah that's super cool - it must have been something else I was fighting against when I saw another case.


luci-app-firewall: cherry pick "Covered devices" in 19.07

This is the commit that contains this feature (among other things)
https://github.com/openwrt/luci/commit/df77b47badc5ea5aff5cbc341b44c64eeff2ba44#diff-cfa93b92d41c500ad02335dd08a0d799R175
Having it in Luci is important to allow VPN configuration from Luci as described in this wiki article.
https://openwrt.org/docs/guide-user/services/vpn/openvpn/client-luci
Note that only the "Covered devices" interface is needed for this, not the whole commit.
@jow- pretty please?

This could only be fixed (cherry-picked) if we move the master branch to 19.07 branch see RFC https://github.com/openwrt/luci/issues/3092

All master firewall support gas been merged to 19.07

thanks


alternate directory

WORKDIR /usr/src/app

RUN chmod 777 /usr/src/app

can I use this instead of the above ? In Dockerfile ?
WORKDIR /root/downloads

RUN chmod 777 /root/downloads

Yes you can modify it accordingly but also don't forget to change the original code directories aswell

For dockerfile
https://github.com/AmirulAndalib/MLTB-ALPINE-DOCKER/blob/master/Dockerfile Base/Dockerfile#L14-L17

For dockerfile
https://github.com/AmirulAndalib/MLTB-ALPINE-DOCKER/blob/master/Dockerfile Base/Dockerfile#L14-L17

Thanks


Create an intro

Add an intro about yourself: who are you, what is your strength, why are you here.

Wrote down the bio!


chore(store-ui): Slider atom - change input component

What's the purpose of this pull request?
Use store-ui Input component instead of HTML input tag to keep the design system pattern.
How it works?

Use <Input /> instead of HTML input tag in Slider atom.
Update 'CSS Selector' section Slider of the storybook page documentation.

How to test it?
The Slider behavior has to be the same as the last implementation.

Only check if it's possible to navigate to Input CSS selectors linked on Slider's storybook page.

References
_

[data-store-input] already had a style, just like [data-store-slider-thumb="left"]so the component now has 2 styles.

If we change the input to the Internal Input, we should've changed the Slider to be a molecule.

you have a point 🤔

If we change the input to the Internal Input, we should've changed the Slider to be a molecule.

That's not a problem for me. I think we should make this change indeed, it makes sense. The slider is complicated enough that we can call it a molecule.

I agree that the Slider component can be in the molecules' context... I even checked out some system design references and they follow this idea. But now, PriceRange, which is a Slider dependent, it's also in the molecules folder rs 😅

Oh my lord, 12k changes. Did you rebased your branch from 0.x with the new one 1.x?


The phone numbers are duplicate.

Case 1
When I have a single number associated with a contact.
For each contact it is showing two numbers like 74113 61788 and<PHONE_NUMBER>.
So basically it has a number with spaces and a number without spaces.
The same contact in my phone book app shows just a single number.
Case 2
When I have two numbers associated with a contact.
If I have a contact with two different numbers like 77777777 and 66666 6666, then it shows properly that is the two numbers with exact spacing.
I have an android 6.0 which is pure android. I making use of the default android contacts app.

You may have to consider that the contacts are linked in your previous phone and being shown as a single contact, but they're broken up when restored. This is an issue I'm having as well

Closing this issue as there's been a lack of interest in the community regarding this issue. If someone wants to contribute their solution, I will gladly re-open this issue for discussion. Thanks!


KEDA ScaledObject spec should be documented

Container Apps use KEDA ScaledObject internally. Specifications should be disclosed as much as possible so that scaling behavior can be assumed.
pollingInterval and cooldownPeriod are especially important because they are involved in billing.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 58fa8bbe-e0eb-4944-bc60-617aec0c0dde
Version Independent ID: eae53948-3193-a451-5963-3e6cd8ee2972
Content: Scaling in Azure Container Apps
Content Source: articles/container-apps/scale-app.md
Service: container-apps
GitHub Login: @craigshoemaker
Microsoft Alias: cshoe

Thanks for the feedback! We have assigned the issue to the content author to further review this and update the document as appropriate.

@ToruMakabe Thank you for your input.  I have added the cooldownPeriod and pollingInterval values to the article.  I hope that this helps.  You should see the changes soon.
#please-close


Date field placeholder format based on country code

What's this PR do?
We had moved translation of the placeholder text for the birthday field into POEditor, but the rules around that conflicted with the format being used for validation. So after much meeting...here comes the fix (i hope) in 3 lines of code.
POEditor will just be responsible for translating the string YYYY to AAAA when it needs to.
This code just updates the placeholder logic to ask for the correct date format based on the users country code which matches up with the validation logic.
How should this be manually tested?
The real sanity check for this will be to visit the site as a US user, but then hit a /mx/ url and then try to register a new account. The format the form asks for would be MM/DD/AAAA and it should pass validation.
What are the relevant tickets?
Fixes #5576
Waiting on #5636 for the translation of YYYY to AAAA to be added. But it is not a blocker.
/cc @DFurnes @angaither

:+1:


conn.close() not working

Hi,
For some reason it looks like the db connection is not closing properly.
Running this code (package version 1.16.8), on iojs:
r.connect(conf)
  .then(function (conn) {
    conn.close();
  })

The process doesn't exit.
Any thoughts? Thanks!

Did you import the driver with {pool : false}?
If not, you need to call r.getPool().drain().

Also, conn.close() return a promise, so you can see if the connection get closed by tackling another then.

I see, thanks, this fixes it!  :)


User Data Dispersion [Profile Cards]

Is your feature request related to a problem?
There is no way of viewing everything relevant to you under one command. This makes it difficult to find anything that is stored under your name. Also, it reduces the need for multiple commands being created. By setting it all under one view (a dropdown), if new data is being stored, simply create a new select option. This removes the need of creating yet another new command to view your stats.
Describe the solution you'd like
A system similar to one of Dank Memer. Everything related to you is displayed in a dropdown containing: your active cooldowns, stats, badges. All under one view and not dispersed in multiple different commands. This is often called a profile card
A profile card could have the following:

Your flex slot (something you have that you can flex on others)
Your level (which is integrated with tatsu)
Bank and inventory summary (already implemented)
Other features related to you would be in a dropdown in the associated selectable option.

Also with this change, it would be helpful if we could create a privacy toggle, which is already available to limit what other content users can see. This could range from your entire profile to just your profile card.
Describe alternatives you've considered
As of now, we have no alternative implementations. This seems to be the best option, and also the only option.
Additional context
Data related to you is usually located under one menu or heading. Without this kind of system, your data is hard to locate and ruins the UX.

After careful consideration, we've decided not to implement this.
The reason behind this is that unlike other large bots, we do not store data on everything you do. This includes details like how much money you've robbed or gained from working, storing numerous long term cooldowns. We do not store much data, and while that may change in the future, it's very unlikely to be substantial.
If we did make the go-ahead for this to happen, there would only be 3 select options. These include active cooldowns, gambling stats, and the main profile. This would only seem to be helpful if there were more than 5 selectable options to choose from. Using a dropdown also slows down the bot's response, and all these issues combined make the idea unsuitable for use.
This does not mean we are not resolving issue of user dispersion. Instead as a workaround, we will add a mode parameter to the profile command to choose what kind of stats you'd like to see on the user's profile. The options will include the same ones we've mentioned, and more if they arrive in the future.


Improve race condition handling in Ghost Table Manager

We regularly get race condition while running ghost table in users with lots of tables which run over 10 minutes long: https://github.com/CartoDB/cartodb/issues/12012
My proposed solution in order to avoid this is to add a new method to Carto::Bolt to indicate activity, that goes to redis and refreshed the TTL. This can be called after each table operation from ghost tables manager. We could also reduce the TTL a bit. This way:

We don't need to increase the TTL for bigger users (be it in a fixed amount, or heuristics based on number of tables).
We get a lower TTL, that will expire if the process is truly stuck, but will keep refreshing if it is doing something (even it it takes a while).

cc @juanignaciosl

Already fixed.


move agent install script in updater (setuid solution)

What does this PR do?
This PR adds a new go binary with cap setuid that can run a restricted set of priviledged commands:

add datadog* systemd units shipped by datadog-updater
remove datadog* systemd units
systemd start/stop/enable/disable/daemond-reload

The helper binary only imports the standard library and restricts its input. On the file system it's executable only by dd-agent and root.
Other changes added

updater when run by root will change to dd-agent user if it exists

Follow-up PRs

updater units are installed by the updater bootstrap
move every updater files to dd-updater unit, and chown installed agents to dd-agent

Motivation
Enable updating systemd
Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

/merge


Pyngrok Module ERROR

Hey, i came back after not using colab and automatic1111 for like 2-3 weeks. When i start the colab in the final step i get this error :

ModuleNotFoundError                       Traceback (most recent call last)
 in <cell line: 6>()
4 import sys
5 import fileinput
----> 6 from pyngrok import ngrok, conf
7 import re
8
ModuleNotFoundError: No module named 'pyngrok'
Any chance u guys can help me?, i tried to manually install pyngrok and every other thing that start appearing but no luck, please help!.

It was working fine until yesterday, but starting today I'm getting the same error.

maybe is Hugging Face issue again  :/

I'm relieved that I'm not the only one experiencing errors.
I hope it will be restored soon.

this is the problem?

went back
I just made it run
thanks


Fix broken terraform-docs install

🗣 Description
In this pull request we add the setup-go action to specify the version of go to use.  This is required to get around the fact that terraform-docs does not install with the version of go that is present by default.
💭 Motivation and Context
Without this change, all GitHub Actions that are triggered by this repository or any cloned from it fail.  Bad news.
🧪 Testing
I committed these changes and verified that the GitHub Actions that are triggered now pass.
🚥 Types of Changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (causes existing functionality to change)

✅ Checklist

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.

Two questions:

There is a v2 of this action in beta.  Do we want to use that instead?  The main difference seems to be that we can use semver annotations to denote "version x.y.z or any higher", etc.rgithub

Two questions:

There is a v2 of this action in beta.  Do we want to use that instead?  The main difference seems to be that we can use semver annotations to denote "version x.y.z or any higher", etc.
Do we want to specify the version of go as an environment variable in cisagov/setup-env-github-action instead?

I'm fine with us going ahead with v2.


[bug] <rh-tabs> don't display active border on initial load

Describe the bug
When using an <rh-tabs> component, the red border delineating the current tab does not appear on page load in all browsers except Safari.
Screenshots

Steps to reproduce

Visit the <rh-tabs> demo in any browser except Safari.
Observe that the first tab is showing ("Users").
Observe the missing red bottom border under the "Users" <rh-tab>.

Expected behavior
Upon loading the <rh-tabs> demo, users should see the red border under the currently active tab.
Operating System (OS)
macOS
Browser
Chrome, Microsoft Edge, Firefox
Additional browser or assistive technology info
Curiously, the red border is visible in Safari.

This no longer appears to be the case


help/search.en.html does not extend BASE_TEMPLATE (extends page.html instead)

Describe the bug
As in the title; not much to add.

closed by https://github.com/inveniosoftware/invenio-app-rdm/pull/1077


Unable to install Detox 8.2.3 using Xcode 10 beta 6

Description
Unable to install Detox 8.2.3 using Xcode 10 beta 6.
Steps to Reproduce
With Xcode 10 beta 6 installed, run yarn add detox.
Detox, Node, Device, Xcode and macOS Versions

Detox: 8.2.3
React Native: 0.55.2
Node: 9.8.0
Device: n/a
Xcode: Xcode 10 beta 6
macOS: 10.13.6

Device and verbose Detox logs
[1/1] ⡀ detox: Building Detox.framework from /Users/tom.aylesworth/repo/ae/appian-libraries/sail-client-native/Appian/node_modules/detox/ios_src...
[-/1] ⡀ waiting...
[-/1] ⡀ waiting...
[-/1] ⡀ waiting...
error /Users/tom.aylesworth/repo/ae/appian-libraries/sail-client-native/Appian/node_modules/detox: Command failed.
Exit code: 1
Command: node scripts/postinstall.js
Arguments:
Directory: /Users/tom.aylesworth/repo/ae/appian-libraries/sail-client-native/Appian/node_modules/detox
Output:
+ xcodebuild -version
+++ dirname /Users/tom.aylesworth/repo/ae/appian-libraries/sail-client-native/Appian/node_modules/detox/scripts/build_framework.ios.sh
++ dirname /Users/tom.aylesworth/repo/ae/appian-libraries/sail-client-native/Appian/node_modules/detox/scripts
+ detoxRootPath=/Users/tom.aylesworth/repo/ae/appian-libraries/sail-client-native/Appian/node_modules/detox
++ node -p 'require('\''/Users/tom.aylesworth/repo/ae/appian-libraries/sail-client-native/Appian/node_modules/detox/package.json'\'').version'
+ detoxVersion=8.2.3
++ echo 8.2.3
++ xcodebuild -version
++ shasum
++ awk '{print $1}'
+ sha1=ace2b19975268f18996ba8eabadf6e067c17c782
+ detoxFrameworkDirPath=/Users/tom.aylesworth/Library/Detox/ios/ace2b19975268f18996ba8eabadf6e067c17c782
+ detoxFrameworkPath=/Users/tom.aylesworth/Library/Detox/ios/ace2b19975268f18996ba8eabadf6e067c17c782/Detox.framework
+ main
+ '[' -d /Users/tom.aylesworth/Library/Detox/ios/ace2b19975268f18996ba8eabadf6e067c17c782 ']'
+ prepareAndBuildFramework
+ '[' -d /Users/tom.aylesworth/repo/ae/appian-libraries/sail-client-native/Appian/node_modules/detox/ios ']'
+ detoxSourcePath=/Users/tom.aylesworth/repo/ae/appian-libraries/sail-client-native/Appian/node_modules/detox/ios_src
+ extractSources /Users/tom.aylesworth/repo/ae/appian-libraries/sail-client-native/Appian/node_modules/detox/ios_src
+ detoxSourcePath=/Users/tom.aylesworth/repo/ae/appian-libraries/sail-client-native/Appian/node_modules/detox/ios_src
+ echo 'Extracting Detox sources...'
Extracting Detox sources...
+ mkdir -p /Users/tom.aylesworth/repo/ae/appian-libraries/sail-client-native/Appian/node_modules/detox/ios_src
+ tar -xjf /Users/tom.aylesworth/repo/ae/appian-libraries/sail-client-native/Appian/node_modules/detox/Detox-ios-src.tbz -C /Users/tom.aylesworth/repo/ae/appian-libraries/sail-client-native/Appian/node_modules/detox/ios_src
+ buildFramework /Users/tom.aylesworth/repo/ae/appian-libraries/sail-client-native/Appian/node_modules/detox/ios_src
+ detoxSourcePath=/Users/tom.aylesworth/repo/ae/appian-libraries/sail-client-native/Appian/node_modules/detox/ios_src
+ echo 'Building Detox.framework from /Users/tom.aylesworth/repo/ae/appian-libraries/sail-client-native/Appian/node_modules/detox/ios_src...'
+ mkdir -p /Users/tom.aylesworth/Library/Detox/ios/ace2b19975268f18996ba8eabadf6e067c17c782
Building Detox.framework from /Users/tom.aylesworth/repo/ae/appian-libraries/sail-client-native/Appian/node_modules/detox/ios_src...
+ /Users/tom.aylesworth/repo/ae/appian-libraries/sail-client-native/Appian/node_modules/detox/scripts/build_universal_framework.sh /Users/tom.aylesworth/repo/ae/appian-libraries/sail-client-native/Appian/node_modules/detox/ios_src/Detox.xcodeproj /Users/tom.aylesworth/Library/Detox/ios/ace2b19975268f18996ba8eabadf6e067c17c782
child_process.js:596
    throw err;
    ^

Error: Command failed: /Users/tom.aylesworth/repo/ae/appian-libraries/sail-client-native/Appian/node_modules/detox/scripts/build_framework.ios.sh
    at checkExecSyncError (child_process.js:575:11)
    at Object.execFileSync (child_process.js:593:13)
    at Object.<anonymous> (/Users/tom.aylesworth/repo/ae/appian-libraries/sail-client-native/Appian/node_modules/detox/scripts/postinstall.js:2:27)
    at Module._compile (module.js:649:30)
    at Object.Module._extensions..js (module.js:660:10)
    at Module.load (module.js:561:32)
    at tryModuleLoad (module.js:501:12)

Please describe your environment; is it just Xcode 10, or do you have Xcode 9 as well?
What does xcodeselect -p print?

Also, delete all folders inside ~/Library/Detox and retry the Detox install. There should now be one folder in there and inside should be a detox_ios.log file. Paste the contents of that file here. Thanks

I do have both Xcode 10 beta 6 and Xcode 9 installed.
xcode-select -p points to the Xcode 10 beta 6 directory as you can see in the terminal output below.
c02rq0q1g8wl:Appian tom.aylesworth$ xcode-select -p
/Applications/Xcode-beta6.app/Contents/Developer
c02rq0q1g8wl:Appian tom.aylesworth$ rm -rf ~/Library/Detox/*
c02rq0q1g8wl:Appian tom.aylesworth$ ls ~/Library/Detox/
c02rq0q1g8wl:Appian tom.aylesworth$ rm -rf node_modules/
c02rq0q1g8wl:Appian tom.aylesworth$ yarn install
yarn install v1.3.2
$ bash ./bin/preinstall.sh
Regenerating Registry.native.js
[1/4] 🔍  Resolving packages...
[2/4] 🚚  Fetching packages...
[3/4] 🔗  Linking dependencies...
warning "react-native > metro ><EMAIL_ADDRESS>has incorrect peer dependency "<EMAIL_ADDRESS>warning "react-native > metro ><EMAIL_ADDRESS>has incorrect peer dependency "<EMAIL_ADDRESS>warning " ><EMAIL_ADDRESS>has unmet peer dependency<EMAIL_ADDRESS>[4/4] 📃  Building fresh packages...
[1/2] ⢀ fsevents: [fsevents] Success: "/Users/tom.aylesworth/repo/ae/appian-libraries/sail-client-native/Appian/node_modules/fsevents/lib/binding/Release/node-v59-darwin-x64/fse.node" is installed via remote
[2/2] ⢀ detox: Building Detox.framework from ./ios_src...
[-/2] ⢀ waiting...
[-/2] ⢀ waiting...
error /Users/tom.aylesworth/repo/ae/appian-libraries/sail-client-native/Appian/node_modules/detox: Command failed.
Exit code: 65
Command: scripts/postinstall.sh
Arguments:
Directory: /Users/tom.aylesworth/repo/ae/appian-libraries/sail-client-native/Appian/node_modules/detox

detox_ios.log

Thanks
I’m currently on vacation. Will look at this when I’m back.

adding more information here,
trying to run demo-react-native-jest:
Detox: ^9.0.0
React Native: 0.51.1
Node: 8.11.4
Device: n/a
Xcode: Version 9.2 (9C40b)
macOS: Sierra 10.12.6
i'm receiving the same errors as @taylesworth
✔ ~/Desktop/demo-react-native-jest [master L|✔]
16:13 $ yr
yarn install v1.9.4
info No lockfile found.
[1/4] 🔍  Resolving packages...
warning react-native ><EMAIL_ADDRESS>connect 2.x series is deprecated
[2/4] 🚚  Fetching packages...
[3/4] 🔗  Linking dependencies...
warning " ><EMAIL_ADDRESS>has unmet peer dependency<EMAIL_ADDRESS>|| ^7.0.0-alpha || ^7.0.0-beta || ^7.0.0".
[4/4] 📃  Building fresh packages...
[-/3] ⠠ waiting...
[3/3] ⠠ detox
error /Users/eduardorabelo/Desktop/demo-react-native-jest/node_modules/detox: Command failed.
Exit code: 1
Command: node scripts/postinstall.js
Arguments:
Directory: /Users/eduardorabelo/Desktop/demo-react-native-jest/node_modules/detox
Output:
+ xcodebuild -version
+++ dirname /Users/eduardorabelo/Desktop/demo-react-native-jest/node_modules/detox/scripts/build_framework.ios.sh
++ dirname /Users/eduardorabelo/Desktop/demo-react-native-jest/node_modules/detox/scripts
+ detoxRootPath=/Users/eduardorabelo/Desktop/demo-react-native-jest/node_modules/detox
++ node -p 'require('\''/Users/eduardorabelo/Desktop/demo-react-native-jest/node_modules/detox/package.json'\'').version'
+ detoxVersion=9.0.1
++ echo 9.0.1
++ shasum
++ xcodebuild -version
++ awk '{print $1}'
+ sha1=4a0b5935f33eb33d6388b74fc11443701cf00f53
+ detoxFrameworkDirPath=/Users/eduardorabelo/Library/Detox/ios/4a0b5935f33eb33d6388b74fc11443701cf00f53
+ detoxFrameworkPath=/Users/eduardorabelo/Library/Detox/ios/4a0b5935f33eb33d6388b74fc11443701cf00f53/Detox.framework
+ main
+ '[' -d /Users/eduardorabelo/Library/Detox/ios/4a0b5935f33eb33d6388b74fc11443701cf00f53 ']'
+ '[' '!' -d /Users/eduardorabelo/Library/Detox/ios/4a0b5935f33eb33d6388b74fc11443701cf00f53/Detox.framework ']'
+ echo '/Users/eduardorabelo/Library/Detox/ios/4a0b5935f33eb33d6388b74fc11443701cf00f53 was found, but could not find Detox.framework inside it. This means that the Detox framework build process was interrupted.
         deleting /Users/eduardorabelo/Library/Detox/ios/4a0b5935f33eb33d6388b74fc11443701cf00f53 and trying to rebuild.'
+ rm -rf /Users/eduardorabelo/Library/Detox/ios/4a0b5935f33eb33d6388b74fc11443701cf00f53
/Users/eduardorabelo/Library/Detox/ios/4a0b5935f33eb33d6388b74fc11443701cf00f53 was found, but could not find Detox.framework inside it. This means that the Detox framework build process was interrupted.
         deleting /Users/eduardorabelo/Library/Detox/ios/4a0b5935f33eb33d6388b74fc11443701cf00f53 and trying to rebuild.
+ prepareAndBuildFramework
+ '[' -d /Users/eduardorabelo/Desktop/demo-react-native-jest/node_modules/detox/ios ']'
+ detoxSourcePath=/Users/eduardorabelo/Desktop/demo-react-native-jest/node_modules/detox/ios_src
+ extractSources /Users/eduardorabelo/Desktop/demo-react-native-jest/node_modules/detox/ios_src
+ detoxSourcePath=/Users/eduardorabelo/Desktop/demo-react-native-jest/node_modules/detox/ios_src
+ echo 'Extracting Detox sources...'
Extracting Detox sources...
+ mkdir -p /Users/eduardorabelo/Desktop/demo-react-native-jest/node_modules/detox/ios_src
+ tar -xjf /Users/eduardorabelo/Desktop/demo-react-native-jest/node_modules/detox/Detox-ios-src.tbz -C /Users/eduardorabelo/Desktop/demo-react-native-jest/node_modules/detox/ios_src
+ buildFramework /Users/eduardorabelo/Desktop/demo-react-native-jest/node_modules/detox/ios_src
+ detoxSourcePath=/Users/eduardorabelo/Desktop/demo-react-native-jest/node_modules/detox/ios_src
+ echo 'Building Detox.framework from /Users/eduardorabelo/Desktop/demo-react-native-jest/node_modules/detox/ios_src...'
+ mkdir -p /Users/eduardorabelo/Library/Detox/ios/4a0b5935f33eb33d6388b74fc11443701cf00f53
Building Detox.framework from /Users/eduardorabelo/Desktop/demo-react-native-jest/node_modules/detox/ios_src...
+ /Users/eduardorabelo/Desktop/demo-react-native-jest/node_modules/detox/scripts/build_universal_framework.sh /Users/eduardorabelo/Desktop/demo-react-native-jest/node_modules/detox/ios_src/Detox.xcodeproj /Users/eduardorabelo/Library/Detox/ios/4a0b5935f33eb33d6388b74fc11443701cf00f53
child_process.js:624
    throw err;
    ^

Error: Command failed: /Users/eduardorabelo/Desktop/demo-react-native-jest/node_modules/detox/scripts/build_framework.ios.sh
    at checkExecSyncError (child_process.js:601:13)
    at Object.execFileSync (child_process.js:621:13)
    at Object.<anonymous> (/Users/eduardorabelo/Desktop/demo-react-native-jest/node_modules/detox/scripts/postinstall.js:2:27)
    at Module._compile (module.js:652:30)
    at Object.Module._extensions..js (module.js:663:10)
    at Module.load (module.js:565:32)
    at tryModuleLoad (module.js:505:12)
    at Function.Module._load (module.js:497:3)
    at Function.Module.runMain (module.js:693:10)

I'm facing the same issue with 10.0 (10A254a). Can you pls let us know if we have fix anytime soon.

I’m back on 20th but there are holidays. I’ll look at it as soon as possible.

I don't see a problem in those logs. I will try to reproduce the issue on my computer when I get back.


Bugs in TimeStepperAdaptive

There appears to be one or more bugs in TimeStepperAdaptive.
If I set setCheckInterval to >0 the solution oscillates around the initial value. It is as if the RestoreInitialSolution function restores the unknown vector to the initial value every time and you just take the same time step over and over.
With CheckInteval=0 the solution evolves as it should, but there is still something iffy with the errors, because the steps it predicts can be orders of magnitude shorter than needed (even with a relative error of 10% it takes steps such that the solution (including the unknown that supposedly has the maximum error) barely evolves at all in hundreds of steps).

Example exhibiting this behavior added to development branch: compton_adaptive.py.

The current implementation of the adaptive time stepper checks the error in all quantities. It would be better if the user could specify which quantities should determine the time step, so that only the error in those quantities determines the next time step.


XMLHttpRequest error

Getting error with fetching-
https://api.time.com/wp-content/uploads/2023/04/florida-flooding-04.jpg

Same error as @anmol-me
When I replace Image.network by FastCachedImage, all my images didn't load on web and throws XMLHttpRequest errors.
@CHRISTOPANANJICKAL can you try your example but on a chrome device ?

You can fix the CORS issue in your server-side or you can use a proxy.


Tooltipster side not working well

Hi,
Thank you for this amazing plugin! Since jQuery clueTip Plugin is no longer being maintained by JQuery I changed my plugin to Tooltipser plugin. However I have some issues with the 'side' option, when I resize my navigator it doesnt work well.
My img is displayed when i click on the "magnifying glass" icon here is an example:
https://imgur.com/cCVcHXp
If i reduce my navigator size it will repositions my picture to bottom side :
https://imgur.com/qFE3i0i
But if i reduce 1px per px, this picture will jump between right side and bottom side:
https://imgur.com/UFHRMI4
here is my code :
`$(document).ready(function() {
var result;
$('div.content .spanloupe a.loupe').tooltipster({
	functionInit: function(instance, helper){
		var content = $(helper.origin).find('.tooltip_content').detach();
		instance.content(content);
	},
	trigger: 'click',
	theme: 'tooltipster-light',
	side: ['right','bottom']
});`

Hi, do you have a public page where I can see this happen? Thank you.


cargotest: purge deps

Blocking rust-lang/rust#42588.

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @matklad (or someone else) soon.
If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.
Please see the contribution instructions for more information.

Huh, it indeed seems useful to know about unused crates!
Thanks, @ishitatsuyuki !
@bors r+

:pushpin: Commit 72de74c has been approved by matklad

:hourglass: Testing commit 72de74c9eb38a2da5c5ccf1019a914b6e61f1efd with merge d516090d90d1251bc279637650db8556b8d5c13d...

:broken_heart: Test failed - status-travis

OSX livelock, please retry.

@bors r+

:bulb: This pull request was already approved, no need to approve it again.

This pull request previously failed. You should add more commits to fix the bug, or use retry to trigger a build again.

:pushpin: Commit 72de74c has been approved by matklad

:hourglass: Testing commit 72de74c9eb38a2da5c5ccf1019a914b6e61f1efd with merge 54501637c0acec442e4ffc1f4690489f845ba670...

:sunny: Test successful - status-appveyor, status-travis
Approved by: matklad
Pushing 54501637c0acec442e4ffc1f4690489f845ba670 to master...


Pattern 'netCatalogueInsertUnique' failed.

when i inject the dll it shows me this message:
Pattern 'netCatalogueInsertUnique' failed.

Yes, same for me

Same for me "Pattern 'netCatalogueInsertUnique' failed."

Because R* has fixed this bug, we no longer need to use this dll. Thank you for the author’s contribution.

This mod will no longer be needed for online speedup. It will soon be made to only speed up single player load times.


Fix some bugs introduced due to "default behavior" in pagerduty integration

to: @chunyong-lin @ryandeivert
cc: @airbnb/streamalert-maintainers
related to:
resolves:
Background
We received some requests regarding changes in default behavior of certain pages. This tweaks them back to normal.
Testing
CI?

Coverage decreased (-0.05%) to 96.699% when pulling 5a0c26abd303d21cfdf9beaaf4d082c3ce41561f on dw--fix-pd-defaults into 798493dcf862bf4c70aa431b1276617ad1d7b8ac on alert-publishers-final.


long term extensibility

Hey @MARDAScience — this dashboard that @ShahNafisRafique is building is mostly for Sallenger regime classification. But what other operations should a Coastal dashboard have? pixel annotation? segmentation? bounding boxes labeling for certain features? i think this would be a good place to have a list... and then also we can figure out what the next steps are... (and have a running list of other data we need to ingest (beyond the NOAA post-storm aerials from psi-collect

Great! I suppose that ideally it could include polygon labelling, bounding boxes, and pixel annotation would be amazing! I could implement my CRF code that works well for turning sparse into dense (i.e. every pixel) label images. What makes it 'coastal' is the just the data and classes, so you could leverage existing tools. What class labels would be provided? Or is the idea that users could upload their own imagery and classes? Happy to help in any way I can
Here's one idea to make it more 'coastal' - make trained coastal models available. My advice, if you don't already have a specific framework in mind: branch the maksense.ai code  because it has all the annotation tools, and is backended by tensorflow-js so can implement CNN models, etc. It would also be nice to implement the CRF model as an option. I could also contribute by training and testing models. Would require knowledge of at least tf-js and npm

these are all good ideas. Once we get v1 deployed, i'll try to parse these, get them rank ordered, and think of a way forward.

Pixel level annotation by leveraging an existing tool? — e.g.,
https://github.com/waoai/react-image-annotate. The key issue is making the manual pixel annotations very lightweight, so it can be stored easily on the mongodb w/o needing a huge db.

I'm closing this... Some of these are wrapped in to evolving long term plans..


Replace random2 with std::random implementation

Ping @JensWehner

Yeah last time I tried I got compilation problems with icc. So this is postponed.

The error I get ./votca_property: symbol lookup error: ./votca_property: undefined symbol: __libm_rcp_table_256

Hmm, this means icc links in the wrong libm, you might miss an LD_LIBRARY_PATH in your intel module.

but which one?

I am working on it.


Add Social Meta for previews

It would be nice to have images / displays for social sharing purposes.

Yes.  👍

You could use your avatar for the social share image.


TextField prevents default Button from working in some cases

This test shows that TextField is preventing ENTER from invoking Accept on the default button.
[Fact]
public void Enter_Prevents_Default_Button_Accept ()
{
    var superView = new Window ();
    var tf = new TextField ();
    var button = new Button ()
    {
        IsDefault = true,
    };

    superView.Add (tf, button);

    var buttonAccept = 0;
    button.Accept += ButtonAccept;

    var textFieldAccept = 0;
    tf.Accept += TextFieldAccept;

    tf.SetFocus ();
    Assert.True (tf.HasFocus);

    superView.NewKeyDownEvent (Key.Enter);
    Assert.Equal (1, textFieldAccept);
    Assert.Equal (0, buttonAccept);

    button.SetFocus();
    superView.NewKeyDownEvent (Key.Enter);
    Assert.Equal (1, textFieldAccept);
    Assert.Equal (1, buttonAccept);

    return;

    void TextFieldAccept (object sender, CancelEventArgs e) { textFieldAccept++; }
    void ButtonAccept (object sender, CancelEventArgs e) { buttonAccept++; }
}

We def want TextField to support firing Accept on Key.Enter. However, not in every case.
I use this in CharMap for example.
But in the video below, the default button should be invoked when one of the TF's has focus.
Background

Do you think that the hotkey PR, also broken the Accept event not being raising on a default button when the Enter key is pressed?

Seems fine to me?
Note that if the TextFields have focus, it doesn't work because TextField has registered ENTER.

Originally posted by @tig in https://github.com/gui-cs/Terminal.Gui/issues/3565#issuecomment-2192523217

This defines the correct behavior, I think...
    [Theory]
    [InlineData (false, 0)]
    [InlineData (true, 1)]
    public void Accept_Handler_Cancel_Prevents_Default_Button_Accept (bool cancelAccept, int expectedButtonAccepts)
    {
        var superView = new Window ();
        var tf = new TextField ();
        var button = new Button ()
        {
            IsDefault = true,
        };

        superView.Add (tf, button);

        var buttonAccept = 0;
        button.Accept += ButtonAccept;

        var textFieldAccept = 0;
        tf.Accept += TextFieldAccept;

        tf.SetFocus ();
        Assert.True (tf.HasFocus);

        superView.NewKeyDownEvent (Key.Enter);
        Assert.Equal (1, textFieldAccept);
        Assert.Equal (expectedButtonAccepts, buttonAccept);

        button.SetFocus ();
        superView.NewKeyDownEvent (Key.Enter);
        Assert.Equal (1, textFieldAccept);
        Assert.Equal (expectedButtonAccepts + 1, buttonAccept);

        return;

        void TextFieldAccept (object sender, CancelEventArgs e)
        {
            textFieldAccept++;
            e.Cancel = cancelAccept;
        }

        void ButtonAccept (object sender, CancelEventArgs e)
        {
            buttonAccept++;
        }
    }

    [Fact]
    public void Accept_No_Handler_Enables_Default_Button_Accept ()
    {
        var superView = new Window ();
        var tf = new TextField ();
        var button = new Button ()
        {
            IsDefault = true,
        };

        superView.Add (tf, button);

        var buttonAccept = 0;
        button.Accept += ButtonAccept;

        tf.SetFocus ();
        Assert.True (tf.HasFocus);

        superView.NewKeyDownEvent (Key.Enter);
        Assert.Equal (1, buttonAccept);

        button.SetFocus ();
        superView.NewKeyDownEvent (Key.Enter);
        Assert.Equal (2, buttonAccept);

        return;

        void ButtonAccept (object sender, CancelEventArgs e)
        {
            buttonAccept++;
        }
    }

The bug is View.OnAccept should return null if there's no event handler and TextField should do this:
        AddCommand (Command.Accept, () => OnAccept () == false);

@tig sorry for my confusion. TextView contains the Multiline property and not the TextField. If you use a TextView with Multiline as true and with focus, then the Enter key must be manipulated by the TextView and not by the button, right?

@tig sorry for my confusion. TextView contains the Multiline property and not the TextField. If you use a TextView with Multiline as true and with focus, then the Enter key must be manipulated by the TextView and not by the button, right?

I think so.
But if textView.MultiLine == false, shouldn't it behave just like a TextField in this regard?

Also, I goofed and misnamed the branch here. That just adds to the confusion.

If no Accept event hanlder is set, TextView works properly:

    [Theory]
    [InlineData (true, 0)]
    [InlineData (false, 1)]
    public void Accept_No_Handler_Enables_Default_Button_Accept (bool multiline, int expectedButtonAccept)
    {
        var superView = new Window ();
        var tv = new TextView ()
        {
            Multiline = multiline
        };
        var button = new Button ()
        {
            IsDefault = true,
        };

        superView.Add (tv, button);

        var buttonAccept = 0;
        button.Accept += ButtonAccept;

        tv.SetFocus ();
        Assert.True (tv.HasFocus);

        superView.NewKeyDownEvent (Key.Enter);
        Assert.Equal (expectedButtonAccept, buttonAccept);

        button.SetFocus ();
        superView.NewKeyDownEvent (Key.Enter);
        Assert.Equal (expectedButtonAccept + 1, buttonAccept);

        return;

        void ButtonAccept (object sender, CancelEventArgs e)
        {
            buttonAccept++;
        }
    }

This new test fails. I'll fix.

    [Theory]
    [InlineData (false, false, 0)]
    [InlineData (false, true, 1)]
    public void Accept_Handler_Cancel_Prevents_Default_Button_Accept (bool multiline, bool cancelAccept, int expectedButtonAccepts)
    {
        var superView = new Window ();
        var tv = new TextView ()
        {
            Multiline = multiline
        };
        var button = new Button ()
        {
            IsDefault = true,
        };

        superView.Add (tv, button);

        var buttonAccept = 0;
        button.Accept += ButtonAccept;

        var textViewAccept = 0;
        tv.Accept += TextViewAccept;

        tv.SetFocus ();
        Assert.True (tv.HasFocus);

        superView.NewKeyDownEvent (Key.Enter);
        Assert.Equal (1, textViewAccept);
        Assert.Equal (expectedButtonAccepts, buttonAccept);

        button.SetFocus ();
        superView.NewKeyDownEvent (Key.Enter);
        Assert.Equal (1, textViewAccept);
        Assert.Equal (expectedButtonAccepts + 1, buttonAccept);

        return;

        void TextViewAccept (object sender, CancelEventArgs e)
        {
            textViewAccept++;
            e.Cancel = cancelAccept;
        }

        void ButtonAccept (object sender, CancelEventArgs e)
        {
            buttonAccept++;
        }
    }

I think so.
But if textView.MultiLine == false, shouldn't it behave just like a TextField in this regard?

Yes, in this case return false for the default button to process it.

Also, I goofed and misnamed the branch here. That just adds to the confusion.

It was also my fault for confusing TextField with TextView, sorry. What matters is that it is corrected in the code and does not include the name of the branch or title. Furthermore, TextField was also improperly handling Accept.


Selection on the outline causes error

Description
Spyder shows error when a symbol is selected from the outline view. This happens only for some files in the editor. Also it does not happen always. For instance, as soon as I restarted Spyder, it worked on the same file without an error.
What steps will reproduce the problem?

Select a symbol in the outline view

What is the expected output? What do you see instead?
Expected: go to that symbol in the file
Actual: Error dialog is shown not going to that symbol
Please provide any additional information below
File "C:\WinPython-64bit-<IP_ADDRESS>Qt5b6\python-3.5.3.amd64\lib\site-packages\spyder\widgets\editortools.py", line 490, in clicked
self.activated(item)
File "C:\WinPython-64bit-<IP_ADDRESS>Qt5b6\python-3.5.3.amd64\lib\site-packages\spyder\widgets\editortools.py", line 481, in activated
if _id == editor_id and editor.parent() is parent:
RuntimeError: wrapped C/C++ object of type CodeEditor has been deleted
Version and main components

Spyder Version: 3.2.1
Python Version: 3.5.3
Qt Versions: 5.9.1, PyQt5 5.9 on Windows

Dependencies
pyflakes >=0.6.0 :  1.6.0 (OK)
pycodestyle >=2.3:  2.3.1 (OK)
pygments >=2.0   :  2.2.0 (OK)
pandas >=0.13.1  :  0.20.3 (OK)
numpy >=1.7      :  1.13.1 (OK)
sphinx >=0.6.6   :  1.6.3 (OK)
rope >=0.9.4     :  0.10.7 (OK)
jedi >=0.9.0     :  0.10.2 (OK)
nbconvert >=4.0  :  5.2.1 (OK)
sympy >=0.7.3    :  1.1.1 (OK)
cython >=0.21    :  0.26 (OK)
qtconsole >=4.2.0:  4.3.1 (OK)
IPython >=4.0    :  6.1.0 (OK)
pylint >=0.25    :  1.7.2 (OK)

Does this happen if you have splitted the Editor in some way?

It happened while I was working on splitted Editor. However, then I closed all the split panels but the error was popping up although there was no split anymore. After I restarted Spyder, it worked fine with and without the split panels. Maybe the error was initiated due to the split and then became persistent, but I am not sure. If I can observe some pattern regarding the cause of the error, I can report here.

Ok, thanks.

@ccordoba12 potentially a duplicate of https://github.com/spyder-ide/spyder/issues/3390

You're right.


Ysystem - Minor fixes

Changes / Comments

Fix range attack bug, added experience points tracker

Roll20 Requests
Comments are very helpful for reviewing the code changes. Please answer the relevant questions below in your comment.

[x] Does the pull request title have the sheet name(s)? Include each sheet name.
[x] Is this a bug fix?
[x] Does this add functional enhancements (new features or extending existing features) ?
[ ] Does this add or change functional aesthetics (such as layout or color scheme) ?
[ ] If changing or removing attributes, what steps have you taken, if any, to preserve player data ?
[ ] If this is a new sheet, did you follow Building Character Sheets standards ?

If you do not know English. Please leave a comment in your native language.

Character Sheet Info Roll20 Internal Use only.


Really use GdsApi.config.always_raise_for_not_found

The gds_api.rb initializer is overwritten on deploy by files from alphagov-deployment
These files in alphagov-deployment don't have the always_raise_for_not_found
configuration set.  This means that it's only used in dev.  I recently tried
to create a new Artefact in Panopticon in dev (which worked), but I was
subsequently unable to edit the created Edition in Publisher as Publishing-api
returned a 404 for Services.publishing_api.get_links on it.
Production environments are currently unaffected, but if we fix the
alphagov-deployment files to also have this configuration before this fix is
merged we'll be unable to edit Editions on newly created Artefacts.
The production initializers also try to use environment variables, but this is
not backed up by Puppet or the deployment repo, so this is something that we'll
fix in the near future.
Trello story

Thanks for the fix 👍 . Looks good, barring a comment about a comment.


Bug in einsum grad?

Hi,
First, thanks for the great software! I use it regularly.
I've run into a possible bug in the gradient function for numpy's einsum. Here's a reproducible example for my system (pip environment file is attached to this issue).
import autograd
import autograd.numpy as np

rng = np.random.RandomState(0)
x = rng.normal(size=(3, 2, 3, 2))

def f(x):
    y = np.einsum('abcd->bd', x)
    return np.sum(y**2)

print(autograd.grad(f)(x))

It appears that the indexing operation here triggers the exception. naked_summed_dims is a tuple, but I believe it should be a list.
Is this fix as easy as changing naked_summed_dims to list(naked_summed_dims) in the index? If so, I'm happy to submit a PR.
Thanks for your help!
env.txt

Thanks, @pschulam! Your diagnosis was right on the money, so I just went ahead and applied the fix you suggested.
PRs are welcome in the future! For future reference, the best protocol is to add a failing test as well as a fix, like I did in 51dff80. We try to keep to that, though we're not always perfect!

Oh, and thanks for the kind words about autograd!

Great, thanks for the quick fix!
In the future I'll go ahead and submit a PR directly.


multiple parallel environments

Hi,
thanks for this wonderful tool!! It's well crafted and extremely useful, but I feel that there is exactly one feature missing to make it just perfect for a workflow I frequently encounter while developing python packages:
One often needs to switch python versions in order to test behaviour on different python versions. Technically, pipenv --python=XXX can be used to switch between different python versions. However, this replaces the current environment and is therefore inconveniently slow in practice.
I would really like to be able to install multiple environments in parallel for the same project and select which one to use on the pipenv command line. This can speed up the time required to switch python versions for the same project significantly and therefore we would have a powerful (IMO alround better) replacement for virtualenvwrapper and the like.
This could work by e.g. providing an environment name on the command line:
# setup environments
pipenv --name 35 --python 3.5 install
pipenv --name 36 --python 3.6 install

# run commands
pipenv --name 35 run python

One issue could be that of different lockfiles in different python versions..
If you would be fine with such an option and think that it is possible to implement for s.o. unacquainted with the code, I'm of course willing to help on the implementation.
This issue is related to #368 and #137 who I think were trying to ask the same question, but I'm unsure whether you rejected the idea altogether or were happy with an intermediate solution at the time.
Best, Thomas

For automated testing many people use a pipeline similar to what you would find in our Travis config file. However you also have the option to use your own virtualenv when running pipenv. Most people don’t handle this by hand but if you do you probably want to make your own virtualenv for each or use pyenv

Thanks for the suggestion but deterministic virtualenv locations is an inherent part of what pipenv is, so I don't see us implementing this.  I'm gonna close this out for now!

Thanks for the answer.

For automated testing many people use a pipeline similar to what you would find in our Travis config file.

I was mainly thinking about interactive use, i.e. debugging, or stuff that's hard to test automatically (GUI, look&feel).

Thanks for the suggestion but deterministic virtualenv locations is an inherent part of what pipenv is, so I don't see us implementing this.

location can still be deterministic, based on path+name, so there is no real conflict here.

so I don't see us implementing this. I'm gonna close this out for now!

Fair enough, thanks anyway!

I also don't understand what conflict this would create with deterministic virtualenv locations.

To be super clear, you can still get your own custom environments set up just by sourcing virtualenvs.
virtualenv 35 --python=python3.5
virtualenv 36 --python=python3.6
source 35/bin/activate && pipenv install
source 36/bin/activate && pipenv install
source 35/bin/activate && pipenv run <whatever>

a tiny bit of additional visual clutter to the commands but is pretty straightforward

Interesting, so if you run pipenv while already in a virtualenv, it will just use that virtualenv, and ignore the one it would use otherwise?

Yup

The workaround kind of defeats the point of using pipenv...
The argument about deterministic virtualenv locations is bunk, the python version would just be another factor in automatically selecting the correct virtualenv.
I am not saying there isn't possibly some valid technical reason for rejecting this feature, but it would be nice to actually know what it is.

@moloney Honest question out of curiosity: How would you design an interface if we are to start from the ground up for this one? How would you associate virtual environments to a given project without cluttering the usual workflow with --name arguments?
I ask because I’ve been looking into building my own home-baked Pipfile + virtual environment tool, and collecting feedbacks for a while. Any feedback would help me greatly toward my goal.

@uranusjr I should have been more precise.  I agree that adding a --name option is probably too much. Instead of adding a --name option I would change the lookup behavior to use both the project and the python version to lookup the virtualenv to use.
I can understand not wanting to recreate the functionality of tox, but it is nice to be able to interactively switch between python versions and try things out without waiting for all the dependencies to reinstall.

That makes sense.

Another use case for this is when I want to work on the same project in a shared folder used by different virtual machines. Currently I'm using the approach suggested by @jtratner.

I have another use case: I'm working on a project with pytorch. The issue here is that the installation of pytorch is os specific, thus when I switch between linux and mac, the pytorch version is incompatible. So I was looking for a way to create an environment for each os.

Hello all,
Like @coldfix I am using pipenv for testing purposes. I tried @jtratner's solution, but then you use the same pipfile, while I had different requirements for my python 2.7 environment: an old wxPython version that is not pip installable.
I found a solution involving the PIPENV_PIPFILE environment variable. I am sharing it here in the hope it can be useful to others.
For the sake of this example let's say you are working under windows and your project folder is at: %USERPROFILE%\pythonprojects\project. Supposed that you need python 2.7 and 3.7 test environments, create subdirs 27 en 37 here. You need to put an initial Pipfile in these directories: they will not be created automatically.
For switching environment I wrote the batch file activate.cmd and put it somewhere in my windows path.
@if "%1"=="" (set PIPENV_PIPFILE=) else (set PIPENV_PIPFILE=%USERPROFILE%\pythonprojects\project\%1\Pipfile)

Now you can install your virtual environments and start using them:
activate 27 && pipenv --python C:\Python27\python.exe --site-packages install
activate 37 && pipenv --python 3.7 install
activate 27 && pipenv run pip list
activate 37 && python -m pipenv shell

If you are using activate in a batch file, use call activate
Cheers,
Henk

Hello all,
Like @coldfix I am using pipenv for testing purposes. I tried @jtratner's solution, but then you use the same pipfile, while I had different requirements for my python 2.7 environment: an old wxPython version that is not pip installable.
I found a solution involving the PIPENV_PIPFILE environment variable. I am sharing it here in the hope it can be useful to others.
For the sake of this example let's say you are working under windows and your project folder is at: %USERPROFILE%\pythonprojects\project. Supposed that you need python 2.7 and 3.7 test environments, create subdirs 27 en 37 here. You need to put an initial Pipfile in these directories: they will not be created automatically.
For switching environment I wrote the batch file activate.cmd and put it somewhere in my windows path.
@if "%1"=="" (set PIPENV_PIPFILE=) else (set PIPENV_PIPFILE=%USERPROFILE%\pythonprojects\project\%1\Pipfile)

Now you can install your virtual environments and start using them:
activate 27 && pipenv --python C:\Python27\python.exe --site-packages install
activate 37 && pipenv --python 3.7 install
activate 27 && pipenv run pip list
activate 37 && python -m pipenv shell

If you are using activate in a batch file, use call activate.
If you need to use a Pipfile in the root of your project for distribution purposes, you can switch to that Pipfile by activate without any argument.
Cheers,
Henk

But this will always recreate the virtualenvs from scratch.

But this will always recreate the virtualenvs from scratch.

Hi @amard33p,
That is not correct. The first two command lines create a virtualenv per PIPENV_PIPFILE environment variable. So no need to repeat those steps every time you want to switch virtualenv. Actually the example demonstrates it. On the third and fourth line you switch back to PIPENV_PIPFILE 27 abd 37 respectively. There is no recreation of the virtualenvs there.


Exception has occured.

MissingPluginException (MissingPluginException(No implementation found for method getResourceUsage on channel resource_monitor))

@AmeerSafdar Are you running it on Android ?

Android side is not implemented yet.
https://github.com/sikandernoori/resource_monitor/blob/0448224721b91cb7b18ce912f46ca72eb6ffb54a/android/src/main/kotlin/com/randomforest/resource_monitor/ResourceMonitorPlugin.kt#L20
Feel free to open PR.


Control visibility of Chart Part in Page Extensions

Problem description:  I created a Page Extension for the Purchase Order page (page 50) and set the visbility status on all Factbox Controls to false in an attempt to hide the Factbox area by default.
The issue I am faced with is the fact that there is an Inventory Forecast Chart displayed on the Purchase Order in the Chart Part factbox as a default and I am not able to remove/hide this, see below:

I would like to be able to set the default visibility of the Chart Part from a Page Extension.
Kind Regards,
Wiechardt

Hi @Wiechardt, are you are able to reproduce this issue on the latest developer preview (version 15.x)?

This issue has been closed because it needs more information and has not had recent activity. Please open a new issue if you believe this has not been resolved and reference the current issue.


Update sbt-scalajs, scalajs-compiler, ... to 1.8.0 in series/0.23

Updates

org.scala-js:sbt-scalajs
org.scala-js:scalajs-compiler
org.scala-js:scalajs-library
org.scala-js:scalajs-library_2.13
org.scala-js:scalajs-test-bridge
org.scala-js:scalajs-test-bridge_2.13

from 1.7.1 to 1.8.0.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Files still referring to the old version number
The following files still refer to the old version number (1.7.1).
You might want to review and update them manually.
website/src/hugo/content/changelog.md

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.scala-js" } ]

labels: library-update, early-semver-minor, semver-spec-minor, old-version-remains, commit-count:1

Scala.js 1.8.0 includes a bug fix relating to usage of scala-java-time which is a dependency of http4s.js. So this update is likely to do more good than harm.

https://github.com/scala-js/scala-js/issues/4601

And ... our fate has been decided :)

https://github.com/typelevel/fs2/pull/2753


Usability improvements

in Dockerfile, used alpine:latest instead of debian:testing image (lighter);
updated packages dependecies for alpine in Dockerfile;
Added empty folder for generated certificates and added to .gitignore the *.pem generated files;
docker-entrypoint.sh now uses sh instead of bash and prints the value of SPID_SECTOR if its not correct;
Added example files instead of the cat script in README.md file (easier to use);
Minor fix in gencert-private.sh (if the COMMON_NAME or ORGANIZATION_NAME have a space you get an error, but the script continues);
Added script to generate certs with docker named "gencert-with-docker.sh"
Updated README.md accordingly;

EntityID in uri format, not metadata URL. Yes It would be the same but EntityID Is the value


Implement event listeners

Implement EventListeners: Develop and integrate event listeners to handle application events efficiently.
The estimated time to resolve this issue is 1 hour

The time it took to solve this issue was 27 minutes.


When the entry in webpack`s config is multiple, the bundled results have empty chunk areas.

webpack.config.js
entry:{
"result1": ["index.js"],
"result2": ["index2.js"]
}

result1.js
/*!*************************!*\
  !*** external "jQuery" ***!
  \*************************/
/***/
function(module, exports) {
    module.exports = jQuery;
}, /* 1 */
/* unknown exports provided */
/* all exports used */
/*!*************************!*\
  !*** ./src/js/index.js ***!
  \*************************/
/***/
function(module, exports, __webpack_require__) {
    /* WEBPACK VAR INJECTION */
    (function($) {
        module.exports= {};
        });
    }).call(exports, __webpack_require__(/*! jQuery */ 0));
}, /* 2 */
, /* 3 */

result2.js
/*!*************************!*\
  !*** external "jQuery" ***!
  \*************************/
/***/
function(module, exports) {
    module.exports = jQuery;
}, /* 1 */
, /* 2 */
/* unknown exports provided */
/* all exports used */
/*!**************************!*\
  !*** ./src/js/index2.js ***!
  \**************************/
/***/
function(module, exports, __webpack_require__) {
    /* WEBPACK VAR INJECTION */
    (function($) {
        module.exports = {};
    }).call(exports, __webpack_require__(/*! jQuery */ 0));
}, /* 3 */
, /* 4 */

The bundled results have empty chunk areas that chunks in not now entry but other entry occupied.

The similar issue,
http://stackoverflow.com/questions/35920603/removing-empty-entries-with-webpack

Are you extracting them somehow? https://github.com/webpack/webpack/issues/1967 might be related then.

That's expected.
It looks like you just deleted our lovely crafted issue template. It was there for good reasons. Please help us solving your issue by answering the questions asked in this template. I'm closing this. Please open a new issue with filled issue template. Also make sure your issue is not a question. Questions should be posted on Stack Overflow.


AndHUD exception in Android 5.0.1 (API21) ?

Hi,
I've been using AndHud in my production application since yet with no problems and an amazing facility... thanks for your work first !
But I've made an update of my solution to target Android 5.0.1 (my test device GalasyS4 has been updated), and I got a problem...
It seems to happens at " AndroidHUD.AndHUD.ShowStatus" that was working until this update of target version.
Does anybody have this problem with Android API 21 ? is AndHUD compatible ?
EDIT : apparently this happens only in debug, not in release... maybe my configuration ?
This is my (very simple) call :
AndHUD.Shared.Show(_act, null, -1, MaskType.Clear, default(TimeSpan?), null, true, null);
And this is the stacktrace of the error :
System.Diagnostics.Debugger.Mono_UnhandledException_internal () in
System.Diagnostics.Debugger.Mono_UnhandledException (ex={Java.Lang.RuntimeException: Exception of type 'Java.Lang.RuntimeException' was thrown.
--- End of managed exception stack trace ---
java.lang.RuntimeException: java.lang.reflect.InvocationTargetException
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1183)
Caused by: java.lang.reflect.InvocationTargetException
at java.lang.reflect.Method.invoke(Native Method)
at java.lang.reflect.Method.invoke(Method.java:372)
at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:1388)
... 1 more
Caused by: md52ce486a14f4bcd95899665e9d932190b.JavaProxyThrowable: System.NullReferenceException: Object reference not set to an instance of an object
at Android.Runtime.JNIEnv.m__0 (intptr) <IL 0x0000b, 0x00080>
at Java.Lang.Object.GetObject (intptr,Android.Runtime.JniHandleOwnership,System.Type) <IL 0x0002d, 0x001c7>
at Java.Lang.Object._GetObject<Android.Views.Window> (intptr,Android.Runtime.JniHandleOwnership) <0x00107>
at Java.Lang.Object.GetObject<Android.Views.Window> (intptr,Android.Runtime.JniHandleOwnership) <0x0006f>
at Android.App.Dialog.get_Window () <IL 0x00054, 0x00203>
at AndroidHUD.AndHUD/c__AnonStorey3.<>m__0 (object) <IL 0x00040, 0x00177>
at Android.App.SyncContext.Send (System.Threading.SendOrPostCallback,object) <IL 0x00031, 0x0019b>
at AndroidHUD.AndHUD.SetupDialog (Android.Content.Context,AndroidHUD.MaskType,System.Action,System.Func4<Android.Content.Context, Android.App.Dialog, AndroidHUD.MaskType, Android.Views.View>) <IL 0x0003d, 0x00243> at AndroidHUD.AndHUD.showStatus (Android.Content.Context,bool,string,AndroidHUD.MaskType,System.Nullable1<System.TimeSpan>,System.Action,bool,System.Action) <IL 0x000cd, 0x0068b>
at AndroidHUD.AndHUD.Show (Android.Content.Context,string,int,AndroidHUD.MaskType,System.Nullable`1<System.TimeSpan>,System.Action,bool,System.Action) <IL 0x0002c, 0x0021b>
at Kiosk_Android.Activity_Web/HelloWebViewClient.OnPageStarted
Thanks for return.
Jérôme

Did you find a solution for this or an alternative?

Yes, as I supposed it was my configuration...
So I set-up a new environment with latest VS/Xamarin, I load my project and all was OK.
No bug / relation with AndHUD.


docs: add how to use the indexerClient to read from the indexer

Agree, this could be a very minimal example project in examples/indexer/

Can I move the examples outside the monorepo? Being in the monorepo affects their behavior.
When I run pnpm install on the indexer client, I get this output, and no node_modules gets created.
qbzzt1@penguin:~/indexer-mud/mud/examples/indexerClient$ pnpm install
Scope: all 28 workspace projects
../.. prepare$ husky install && (forge --version || pnpm foundryup)
│ husky - Git hooks installed
│ forge 0.2.0 (1044042 2023-08-10T13:04:25.942019017Z)
└─ Done in 291ms
Done in 2.9s
qbzzt1@penguin:~/indexer-mud/mud/examples/indexerClient$ ls node_modules
ls: cannot access 'node_modules': No such file or directory

But when I run it in a separate directory, which is what the readers will probably do in most cases, everything works:
qbzzt1@penguin:~/indexerClient$ pnpm install
Packages: +206
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Packages are cloned from the content-addressable store to the virtual store.
  Content-addressable store is at: /home/qbzzt1/.local/share/pnpm/store/v3
  Virtual store is at:             node_modules/.pnpm
Progress: resolved 227, reused 206, downloaded 0, added 206, done

dependencies:
+ @latticexyz/store-sync 2.0.0-main-9a7c9009
+ ts-node 10.9.1

Done in 5.5s
qbzzt1@penguin:~/indexerClient$ ls node_modules/
@latticexyz  prettier  prettier-plugin-solidity  ts-node
qbzzt1@penguin:~/indexerClient$ pnpm indexerClient

><EMAIL_ADDRESS>indexerClient /home/qbzzt1/indexerClient
> npx ts-node --esm index.ts

Block number: 4476
Tables: schema,Hooks,StoreMetadata,NamespaceOwner,InstalledModules,ResourceAccess,Systems,FunctionSelector,SystemHooks,SystemRegistry,ResourceType,Counter
Information about Counter
{
  id: '0x5FbDB2315678afecb367f032d93F642f64180aa3____Counter',
  address: '0x5FbDB2315678afecb367f032d93F642f64180aa3',
  tableId: '0x00000000000000000000000000000000436f756e746572000000000000000000',
  namespace: '',
  name: 'Counter',
  keySchema: {},
  valueSchema: { value: 'uint32' },
  lastUpdatedBlockNumber: 4476n,
  records: [ { key: {}, value: [Object] } ]
}
The actual value: 1
qbzzt1@penguin:~/indexerClient$

It seems like pnpm needs a pnpm-workspace.yaml file in the directory. Pushed a fix, @qbzzt lmk if installing works now. I would prefer to avoid a separate examples repo.

It seems like pnpm needs a pnpm-workspace.yaml file in the directory. Pushed a fix, @qbzzt lmk if installing works now. I would prefer to avoid a separate examples repo.

It works, :yay: . I think this is finally ready for publication.


vfu_destroy_ctx() doesn't delete the socket file that created via vfu_create_ctx()

As described in the title, the socket file is still there after calling vfu_destroy_ctx().

@changpe1 try https://github.com/nutanix/libvfio-user/pull/702

@changpe1 try #702

Works for me, thank you.


Removed autopublish and now transactions don't work

Once I do "meteor remove autopublish" on my app that includes "babrahams:transactions", the "undo..." and "redo..." buttons disappear. In fact, they do appear whenever I make a change but only for a split second and then disappear. I'm using this in conjunction with babrahams:editable-text-wysiwyg-bootstrap-3

Found the answer. You need to subscribe to transactions

That's strange.  The package should manage the subscription itself, independent of iron router.


Websocket: client onopen handshake timeout

There should be logic around websocket connection to timeout and error if unable to connect within a set amount of time

@elmutt can you look into this and see if this is an issue, if not close this ticket.


Caddy 2.7.2 frequently crashes

Hi,
just wanted to drop in and notify that 2.7.2 leads to frequent crashes for me and it seems others as well https://github.com/caddyserver/caddy/issues/5680. There are some proposed fixes in https://github.com/caddyserver/caddy/issues/5680#issuecomment-1665445217 and I have switched to a custom caddy binary for the moment to see if they fully resolve the issue.
Hopefully this will soon be merged and a new version released.

I was just about to open a pr, but I see you already beat me to it with https://github.com/einschmidt/addon-caddy-2/commit/cda82fe13d9370a8c6f50f68681f566e09e186ac


quitonerror option doesn't work for nmeamessage.py _do_attributes errors

I am using bluetooth with my GPS receiver, and I believe that is why I am getting some parsing errors.  I don't get any when hard wired. When nmeamessage.py _do_attributes raises an error, I can't figure out any way to continue operation and just ignoring the corrupt message without modifying the library. It seems like there should be a graceful way to just drop the bad data and continue.

Hi @dborden0
Could I please ask you to use the Issue template when raising issues, as advised in the README.
To help me diagnose your issue, I need to have:

Details of the specific GNSS device you're using and how you're connecting to it.
The specific version of pyubx2 you're using (if not the latest 1.2.17, advise upgrading and retrying)
The platform and operating system you're running on
A full copy of the Python script you're executing
A full copy of the error and traceback
What you were hoping to achieve?

Thanks in advance

Hi @dborden0,
In the absence of further information (Python script, full traceback) I can't really give you a definitive answer to your issue, but I would make the following general observations.

When using the ubxreader.py read method, the quitonerror flag will only capture unknown or unsupported protocols (i.e. something other than NMEA, UBX or RTCM3). It won't necessarily capture more general errors.
If you wish to capture parse, stream or message errors within an iterative read loop, ubxreader.py provides a dedicated iterate method which does allow you to use the quitonerror flag to specify whether such errors are ignored, logged or re-raised. See the /examples/ubxfile.py example by way of illustration.
Detection of individual corrupt NMEA, UBX or RTCM3 messages should be covered by the checksum validation flag, which is turned on by default. I recommend that checksum validation is always set to True.

You could of course simply add a suitable try...except construct around your own read loop to capture any specific exception types you wish to handle or ignore.
Hope this helps. I'm closing this issue for now.


Image gallery

Adding image gallery in the documentation.
Currently, only 1d_hist.rst has been implemented.
Waiting for feedback to continue.
See the gallery here: https://plothist.readthedocs.io/en/gallery-test/basic_examples_gallery/index.html

Adding image gallery in the documentation. Currently, only 1d_hist.rst has been implemented. Waiting for feedback to continue.
See the gallery here: https://plothist.readthedocs.io/en/gallery-test/basic_examples_gallery/index.html

Very nice! We should maybe have all the plots on a single page (sorted from less complex to more complex), I think it would generate the best user experience. Also, the gallery could replace most of the sections of the current documentation.
Shall we use the opportunity of this PR to add the dataset generated by generate_dummy_data() in the repository (estimated size=8.4 MB) and add a function to get it, so that we can drop the scikit-learn dependence. We could even drop the pandas dependence and load the data as numpy arrays, but this we can do later.

Before putting too much work on a doc that might change a lot with all current PR of v1.0, I will wait until they are merged to continue working on this.


Added ability to comment in PR with the link to the job

This will create a comment within your PR if it exists with a link to the failed unit tests and also automatically removes them when unit tests return successfully.
Sample Comment

what's the change to index.js I can't even see because it says "too large"

No need to worry about index.js, it is the package version of the changes.

@poldz123 should we push this upstream? Maybe with a boolean option to enable/disable it

@tahirmt This is only valid if your workflow is using pull_request not comment will be pushed when you are using push event

@tahirmt This is only valid if your workflow is using pull_request no comment will be pushed when you are using push event

I meant should we create a pull request on the original repo?

@tahirmt Ahh, I don't think we need to create a pull-request on the original repo, also that repo is already deprecated.

Oh yeah and the replacement already has the feature from #2


SLSH

Token Address
e.g: https://scan.tomochain.com/address/0xc809a65564d151606f2c6e10d523be9b3a108765
Token Symbol
e.g: SLSH
Token Name
e.g: Slash
Token Logo
https://github.com/tomochain/tokens/blob/f17fd5d9305bfd0e81a6b398174b8af5e505c818/tokens/0xc809a65564d151606f2c6e10d523be9b3a108765.png
Token Description
This Token is based on TomoChain and will use in the reward system for user-generated content.
Website
https://slash.financial
Social links
https://t.me/slashfinancial
https://www.reddit.com/user/slashfinancial
https://medium.com/@slashfinancial
https://www.youtube.com/channel/UCIr5ouTwXGwn2iQvE0t4oYQ
https://twitter.com/SlashFinancial
https://www.facebook.com/SlashFinancial/
https://github.com/slashfinancial

https://github.com/tomochain/tokens/pull/237


⚠ AGEG website (redirect) has degraded performance

In c4e6d3f, AGEG website (redirect) (https://ageg.ca/) experienced degraded performance:

HTTP code: 200
Response time: 2597 ms

Resolved: AGEG website (redirect) performance has improved in a1c91ba.


[FacebookBridge] Add group post timestamp

Add date information for post of Facebook group page

The timestamp value must be a unix timestamp. The grabbed value in your pr is e.g. July 18 at 3:38 PM. Try testing with
$d = new \DateTime($createdAt);
$d->getTimeStamp()

The timestamp value must be a unix timestamp. Maybe not fail with exception if the date can't be found. The grabbed value in your pr is e.g. July 18 at 3:38 PM. Try testing with
$d = new \DateTime($createdAt);
$d->getTimeStamp()

You right. With your example, I'm getting an error: "The timezone could not be found in the database". So, I tried in another way with date_parse. The error is found by this function but doesn't throw an exception (it is just stored in the array). I hope it's better like that.

Another experimental version to enforce use of English version of posts to be able to parse the date and try to parse relative minutes and hours date (but it will have flaws with timezone).

This pr works for me. But it does an additional http request. This will trigger the anti-bot response faster.

You right

I would argue that forcing English for all queries is not a bad thing. Otherwise how else would we parse such things as the dates, precisely? It doesn't change the language of the content (posts) itself, after all. Or am I missing something?


Add a MySQL 5.6 configuration to the tested databases

The goal is not to add first-class support for this database, but rather be proactive with partners that have initially installed RDP with it.

[ ] add ROW_FORMAT and ENGINE to the installation section to make it explicit for this database in addition to the 3 bytes UTF-8 charset
[x] add an entry in docker-compose.yml
[ ] setup a matrix build in GitHub Actions for covering different databases

Fixed in ca920ec50de8525253a2d675e27e05e6e055caa2

We'll do the matrix build at some other time.


DOC: optimize.root: fix docs for inner_* parameters

Reference issue
Closes gh-21296
What does this implement/fix?
This PR just pulls in @nickodell's suggestion from the linked issue - it looks good to me.
Additional information
A follow-up issue should be opened to warn when a user passes an option which is ignored.

thanks Nick!


Read article "The Ugly of Event Sourcing - Real-world Production Issues"

https://www.linkedin.com/pulse/ugly-event-sourcing-real-world-production-issues-dennis-doomen/
What?

concern and drawback

He separates issues into 2 groups

Issues that suddenly show up when deploying e.g. aggregate root structure changes, migrate event with legacy data or older event version, and some fields are missing
Issues that took a while to show up, mostly from code that doesn't handle the events the way they intended e.g. have dependency on projector

Lesson learn

Projection should never crash (always keep a warning log and analyze it)
Projector should be autonomous from other projectors


synchrosqueezing ITD and EMD

You may be aware that there has been recent research effort to combine synchrosqueezing with Empirical mode decomposition.
However, EMD has some shortcomings and it would seem there is a 21st century decomposition technique called intrinsic time-scale decomposition " Intrinsic time-scale decomposition: time−frequency−energy analysis and real-time filtering of non-stationary signals" Mark G Frei and Ivan Osorio,  doi: 10.1098/rspa.2006.1761
The original publication from 2007 is paywalled, but accessible via sci-hub. It features some insightful representation of the work that makes it evident that ITD is a fundamentally new and powerful weapon, as great as wavelets or FFT, which is missing from our arsenal. I don't know if it's a reversible decomposition method however it seems to be described as such.

I believe this screenshot sums it up pretty nicely.
From page four we have:
"4. The ITD method overcomes essentially all the limitations of EMD described earlier. In particular_, the ITD only involves O(n) computations, operates in realtime,_ and although it can be applied to windows of data, it naturally operates on inter-extrema segments of data, with a time-delay equal to the inter-extrema interval, which is determined by the frequency content of the signal being decomposed. When applied to a window of data, the unavoidable edge effects that stem from uncertainty regarding wave morphology in the intervals before the first and after the last signal extrema do not propagate inward as they can with the EMD, but rather are temporally constrained to margins defined by the first and last two extrema in the window. The ITD does not use splines and thus avoids the ‘difficulties’ they introduce. By construction, the ITD method guarantees proper rotation components2 and precisely preserves temporal information regarding TFE information and all the signal critical points. Finally, and perhaps most importantly, the sifting procedure introduced by Huang et al. (1998) in an attempt to produce proper rotation components with the EMD, but which also causes smearing and smoothing of TFE information, is not needed in the ITD. However, for heuristic purposes, we investigated its application within the ITD framework and determined that, as with the EMD, it has the general effect of smoothing variations in amplitude between adjacent extrema. Exhaustive sifting within a window of data results in a component that is purely frequency modulated with constant amplitude. Unlike the EMD, after each ITD sifting iteration, the extrema points remain identical to those of the input signal."
The best explanation of the core algorithm i could find, and i do not know if this is is correct, i only know that the algorithm isn't presented all at once elsewhere, is found on https://arxiv.org/pdf/1404.3827v1.pdf on page 26.
There is also a matlab implementation found at https://viewer.mathworks.com/?viewer=plain_code&url=https%3A%2F%2Fwww.mathworks.com%2Fmatlabcentral%2Fmlc-downloads%2Fdownloads%2Fbacae6a7-59d2-4ad9-89b8-f4d5dd60f422%2F3d85f570-571f-4e45-8049-b0e10d205469%2Ffiles%2Fitd.m&embed=web
From " The De-noising Algorithm Based on Intrinsic Time-scale Decomposition"   doi:10.4028/www.scientific.net/AMR.422.347 jinxia zeng, goufu wang, et al, in 2008, (also paywalled but available on scihub), we find they show evidence supporting that ITD offers similar computational complexity to wavelet transforms but improved noise reduction similar to EMD, while being orders of magnitude easier to compute, as claimed by frei and osorio. Unlike wavelets, the issue of a wavelet base is not encountered making this method superior to both.
I would genuinely like to see it accessible in python and feel this is the best place to announce discussion about it. I have sought help from some engineers from around the world to look into adapting it, perhaps for this repository and directly for inclusion in scipy and numpy libraries. I feel this method will really transform neural network inputs.  I have also heard about, but not seen research publications concerning, the application of synchrosqueezing to EMD, so it may even be possible to go further and apply it to ITD, resulting in a truly powerful and transcendent method.

https://github.com/falseywinchnet/demoframework/blob/main/ITD.ipynb @OverLordGoldDragon

Thanks for your submission.
I currently have no plans on improving upon SSQ. If implementation assistance is needed, I note that v0.6.0 has much simpler code while producing identical outputs. Few other points:

"the issue of a wavelet base is not encountered making this method superior to both" I don't understand. What's "wavelet base"? Note, there's nothing that really breaks Heisenberg's uncertainty in the worst case, without assumptions on input (which in literature SSQ is said to make, but actually doesn't). Such claims should be treated with skepticism. Wavelets are optimal in an important sense.
https://github.com/falseywinchnet/demoframework/ -- thanks. With some polishing, and visual demos in README, I recommend advertising at r/MachineLearning.

I was able to use SSQ on EFD to achieve a better result in individual EFD
decompositions.
I also moved my code and added a bunch of other algorithms since i
made this posting.
https://github.com/falseywinchnet/PyITD
Featured here are implementations for ITD, EFD, and some other stuff i have
been playing with.
sincerely
On Fri, Jun 17, 2022 at 3:55 PM John Muradeli @.***>
wrote:

Thanks for your submission.
I currently have no plans on improving upon SSQ. If implementation
assistance is needed, I note that v0.6.0 has much simpler code while
producing identical outputs. Few other points:

"the issue of a wavelet base is not encountered making this method
superior to both" I don't understand. What's "wavelet base"? Note,
there's nothing that really breaks Heisenberg's uncertainty in the worst
case, without assumptions on input (which in literature SSQ is said
to make, but actually doesn't). Such claims should be treated with
skepticism. Wavelets are optimal in an important sense.
https://github.com/falseywinchnet/demoframework/ -- thanks. With
some polishing, and visual demos in README, I recommend advertising at
r/MachineLearning https://www.reddit.com/r/MachineLearning/.

—
Reply to this email directly, view it on GitHub
https://github.com/OverLordGoldDragon/ssqueezepy/issues/65#issuecomment-1159220990,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AUYJQQ4C3IEHU6NOOPIRZELVPTQ47ANCNFSM5S2RFQWQ
.
You are receiving this because you authored the thread.Message ID:
@.***>


Take Interface, not the concrete class

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (5da288a) 100.00% compared to head (6c91dc8) 100.00%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff            @@
##            master       #92   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           25        25
  Lines          567       567
=========================================
  Hits           567       567

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


CSV importer - adding not nil to if statement so blank fields are skipped

@niedfelj Added a small change so we can have a messy spreadsheet with some fields blank uploaded all in one go. With this change, skips the blank cells. Ran this spreadsheet and it works :)
https://docs.google.com/a/theline.com/spreadsheets/d/11BV2EDkJDal9Y_evuF03QWnkFdst8p72uq6W1djPHA8/edit#gid=0

@niedfelj Thanks Joel - refactored as per your comments.


Base stepper PR

Alright, this is ready for review. I don't consider everything done but I want to move on to other things and allow the rest of the team to continue development with a working stepper.
It's a bit of a beast with some rough edges. I encourage asking for docstrings, comments, and clarification during review.
Things that still need doing:

Disabled mode for stepper items, with correct classes and no link
Error collection, which should be an easy addition as all stepper items that point to a ModelForm view have the instantiated form available
Stepper bubble colour depending on errors and completeness
Collecting all errors in the Stepper class for presentation in ProposalSubmit
The Documents page, which will come with the Attachments update
Collapsing of non-active stepper subfolders
Stepper flow for non-standard Proposal types.

Thankfully, these are all smaller issues that are very doable by others now that the framework is there.

Alright thanks for the valuable feedback!
I'm going to go through the smaller stuff first, then consider the Layout class and some of the other class hierarchies, and then document everything after.

Okay, I think I've addressed everything. Ready for another review!

Moved base classes into stepper_helpers.py with new docstrings and comments
Merged the Layout and Stepper classes. Layout came into existence when I didn't yet know what direction the classes would take, but in the end it is kind of superfluous
renderable Mixin now lives in main/utils.py
StepperItems are now also renderables
The Stepper has a more functional and less stateful build_stepper() method

I was a little hasty pushing the last fixes.

Imports were still in the wrong place
Incorrect references
Super weird stuff going on caused by #4b8b130

But I think everything is fixed now. Thanks for finding the above.

I am having a strange problem where clicking around in the stepper, in a new proposal or older proposal, keeps bringing me to an old proposal ... A few pk's back. Somewhere along the route, the stepper is receiving the wrong proposal object, and redirecting to it. I think this has something to do with ProposalMixin. When I get to the WMOForm and further in the form, the problem doesn´t occur anymore for me.

I think this was caused by #4b8b130, but please double check if it's still happening.

I am not a huge fan of proposal type hint and suggest we get rid of it. It seems like one more place to keep track of this. I would suggest the following:

During construction on major/4, the stepper would not appear until after you filled in the first form. I did not mind this design as it gives you kind off a zen start. Maybe we can bring this back? This would then, maybe also eliminate the need for the proposal_type_hint, as we could then just examine the proposal, and provide the correct layout based on that.

Although I posted a lengthy motivation above about why it currently is the way it is, I think removing the stepper from the createviews altogether is a totally cool idea that would save us some complexity. The reason I haven't done this is that it would be extra work and debugging right now (just before leaving for the UK), whereas the current implementation at least works.
And if it turns out there's something we hadn't thought about with the alternate proposal types that does require some kind of proposal type hint, well at least it's already there.
Feel free to not include the stepper in the createviews if that saves you some time, should you decide to work on the alternate proposal flows.


Initial Firebase Setup - Test Lab

Need to set up the Firebase Test Lab to test the app across devices:
https://console.firebase.google.com/u/1/project/budgy-a1a82/testlab/histories

Here are the instructions needed to run Firebase TestLab: https://support.google.com/firebase/answer/6386654?authuser=0
It appears that we don't need to make any configuration changes in the code for now.