Bug Report: Touble to download a complete series that have more than one season

Hi,
First of all, thank you for your hard work, the downloader is amazing.
But I found a strange bug, I noticed it now on several series.
For Example I tried to download The Fruit of Grisaia.
I entered fallowing command to download the series.
crunchy download -r best --output "{series_name} - S{season_number}E{episode_number} - {title}.mkv" --audio ja-JP --subtitle de-DE --no-hardsub https://www.crunchyroll.com/the-fruit-of-grisaia

But somehow it randomly takes some Episodes from Season 1 and then from Season 3:
=> ✔ Logged in
=> ✔ Parsed url 1 with 14 successes and 0 fails
=> 14 of 14 episodes could be parsed

=> Downloads:
=> 	1. Ordinary Academy Life » 1920x1080px, 23.97 FPS, Japanese audio (The Fruit of Grisaia S01E01)
=> 	2. School Killer Sakaki » 1920x1080px, 23.97 FPS, Japanese audio (The Fruit of Grisaia S01E02)
=> 	3. The Cocoon of Caprice III » 1920x1080px, 23.97 FPS, Japanese audio (The Fruit of Grisaia S03E03)
=> 	4. Where to Aim the Silver Bullet » 1920x1080px, 23.97 FPS, Japanese audio (The Fruit of Grisaia S01E04)
=> 	5. The Seed of Blanc Aile I » 1920x1080px, 23.97 FPS, Japanese audio (The Fruit of Grisaia S03E05)
=> 	6. The Seed of Blanc Aile II » 1920x1080px, 23.97 FPS, Japanese audio (The Fruit of Grisaia S03E06)
=> 	7. The Seed of Blanc Aile III » 1920x1080px, 23.97 FPS, Japanese audio (The Fruit of Grisaia S03E07)
=> 	8. Seed of the World Tree I » 1920x1080px, 23.97 FPS, Japanese audio (The Fruit of Grisaia S01E08)
=> 	9. Seed of the World Tree II » 1920x1080px, 23.97 FPS, Japanese audio (The Fruit of Grisaia S01E09)
=> 	10. Angelic Howl I » 1920x1080px, 23.97 FPS, Japanese audio (The Fruit of Grisaia S01E10)
=> 	11. Angelic Howl II » 1920x1080px, 23.97 FPS, Japanese audio (The Fruit of Grisaia S01E11)
=> 	12. Angelic Howl III » 1920x1080px, 23.97 FPS, Japanese audio (The Fruit of Grisaia S01E12)
=> 	13. 10 Centimeter Field of Fire » 1920x1080px, 23.97 FPS, Japanese audio (The Fruit of Grisaia S01E13)
=> 	14. The Cocoon of Caprice 0 » 1920x1080px, 23.97 FPS, Japanese audio (The Fruit of Grisaia S02E14)

As you saw, episode 1 - 2 are from season 1 and episode 3 is randomly from season 3
I noticed the bug also on

My Teen Romantic Comedy SNAFU
Is It Wrong to Try to Pick Up Girls in a Dungeon?
My Next Life as a Villainess

In my opinion this problem only occurs on shows that have more than one seasons.
I tried then to download them link by link using fallowing command
I used lynx -dump https://www.crunchyroll.com/the-fruit-of-grisaia | awk '/http/{print $2}' | grep -Ei episode to get a list of episodes
https://www.crunchyroll.com/the-fruit-of-grisaia/episode-10-the-seed-of-blanc-aile-vi-678079
https://www.crunchyroll.com/the-fruit-of-grisaia/episode-9-the-seed-of-blanc-aile-v-678077
https://www.crunchyroll.com/the-fruit-of-grisaia/episode-8-the-seed-of-blanc-aile-iv-678075
https://www.crunchyroll.com/the-fruit-of-grisaia/episode-7-the-seed-of-blanc-aile-iii-678073
https://www.crunchyroll.com/the-fruit-of-grisaia/episode-6-the-seed-of-blanc-aile-ii-678071
https://www.crunchyroll.com/the-fruit-of-grisaia/episode-5-the-seed-of-blanc-aile-i-678069
https://www.crunchyroll.com/the-fruit-of-grisaia/episode-4-the-cocoon-of-caprice-iv-678067
https://www.crunchyroll.com/the-fruit-of-grisaia/episode-3-the-cocoon-of-caprice-iii-678065
https://www.crunchyroll.com/the-fruit-of-grisaia/episode-2-the-cocoon-of-caprice-ii-678063
https://www.crunchyroll.com/the-fruit-of-grisaia/episode-1-the-cocoon-of-caprice-i-678061
https://www.crunchyroll.com/the-fruit-of-grisaia/episode-14-the-cocoon-of-caprice-0-678007
https://www.crunchyroll.com/the-fruit-of-grisaia/episode-13-10-centimeter-field-of-fire-661517
https://www.crunchyroll.com/the-fruit-of-grisaia/episode-12-angelic-howl-iii-661515
https://www.crunchyroll.com/the-fruit-of-grisaia/episode-11-angelic-howl-ii-661513
https://www.crunchyroll.com/the-fruit-of-grisaia/episode-10-angelic-howl-i-661511
https://www.crunchyroll.com/the-fruit-of-grisaia/episode-9-seed-of-the-world-tree-ii-661509
https://www.crunchyroll.com/the-fruit-of-grisaia/episode-8-seed-of-the-world-tree-i-661507
https://www.crunchyroll.com/the-fruit-of-grisaia/episode-7-letter-of-happiness-661505
https://www.crunchyroll.com/the-fruit-of-grisaia/episode-6-raison-dtre-661503
https://www.crunchyroll.com/the-fruit-of-grisaia/episode-5-vox-in-box-661501
https://www.crunchyroll.com/the-fruit-of-grisaia/episode-4-where-to-aim-the-silver-bullet-661499
https://www.crunchyroll.com/the-fruit-of-grisaia/episode-3-sweet-diet-661497
https://www.crunchyroll.com/the-fruit-of-grisaia/episode-2-school-killer-sakaki-661495
https://www.crunchyroll.com/the-fruit-of-grisaia/episode-1-ordinary-academy-life-661493

Then I run the command to download every episode link by link
lynx -dump https://www.crunchyroll.com/the-fruit-of-grisaia | awk '/http/{print $2}' | grep -Ei episode | parallel -j 1 '~/Tools/crunchyroll-go/crunchy download -r best --output "{series_name} - S{season_number}E{episode_number} - {title}.mkv" --audio ja-JP --subtitle de-DE --no-hardsub {}'

After the Download has finished, I noticed that some files had the same file name, for example S01E02 exists twice
./The Fruit of Grisaia - S01E02 - School Killer Sakaki (0).mkv
./The Fruit of Grisaia - S01E13 - 10 Centimeter Field of Fire.mkv
./The Fruit of Grisaia - S01E10 - Angelic Howl I.mkv
./The Fruit of Grisaia - S01E04 - Where to Aim the Silver Bullet.mkv
./The Fruit of Grisaia - S01E04 - Where to Aim the Silver Bullet (0).mkv
./The Fruit of Grisaia - S02E14 - The Cocoon of Caprice 0.mkv
./The Fruit of Grisaia - S01E08 - Seed of the World Tree I.mkv
./The Fruit of Grisaia - S01E07 - Letter of Happiness (0).mkv
./The Fruit of Grisaia - S01E07 - Letter of Happiness.mkv
./The Fruit of Grisaia - S03E01 - The Cocoon of Caprice I.mkv
./The Fruit of Grisaia - S01E02 - School Killer Sakaki.mkv
./The Fruit of Grisaia - S03E09 - The Seed of Blanc Aile V.mkv
./The Fruit of Grisaia - S03E03 - The Cocoon of Caprice III.mkv
./The Fruit of Grisaia - S01E11 - Angelic Howl II.mkv
./The Fruit of Grisaia - S03E06 - The Seed of Blanc Aile II.mkv
./The Fruit of Grisaia - S03E05 - The Seed of Blanc Aile I.mkv
./The Fruit of Grisaia - S01E10 - Angelic Howl I (0).mkv
./The Fruit of Grisaia - S03E01 - The Cocoon of Caprice I (0).mkv
./The Fruit of Grisaia - S03E05 - The Seed of Blanc Aile I (0).mkv
./The Fruit of Grisaia - S01E09 - Seed of the World Tree II.mkv
./The Fruit of Grisaia - S01E08 - Seed of the World Tree I (0).mkv
./The Fruit of Grisaia - S01E12 - Angelic Howl III.mkv
./The Fruit of Grisaia - S01E06 - Raison D'être.mkv
./The Fruit of Grisaia - S03E03 - The Cocoon of Caprice III (0).mkv

I checked the md5sum of these two, and both were different
948d23a154a245f33f1ef5123831a53a  The Fruit of Grisaia - S01E02 - School Killer Sakaki.mkv
b2a6bca9f9f8c09f2e7cdbd2acdb633a  The Fruit of Grisaia - S01E02 - School Killer Sakaki (0).mkv

But the video content is the same, so it downloaded the episode twice.
And that's strange, I cannot explain why this happens do you have an idea?
Thank you in advance
Mike

Yes I can confirm this error, very interesting xD
=> Downloads:
=>      1. Ordinary Academy Life » 1920x1080px, 23.97 FPS, Japanese audio (The Fruit of Grisaia S01E01)
=>      2. School Killer Sakaki » 1920x1080px, 23.97 FPS, Japanese audio (The Fruit of Grisaia S01E02)
=>      3. Sweet Diet » 1920x1080px, 23.97 FPS, Japanese audio (The Fruit of Grisaia S01E03)
=>      4. The Cocoon of Caprice IV » 1920x1080px, 23.97 FPS, Japanese audio (The Fruit of Grisaia S03E04)
=>      5. VOX IN BOX » 1920x1080px, 23.97 FPS, Japanese audio (The Fruit of Grisaia S01E05)
=>      6. The Seed of Blanc Aile II » 1920x1080px, 23.97 FPS, Japanese audio (The Fruit of Grisaia S03E06)
=>      7. The Seed of Blanc Aile III » 1920x1080px, 23.97 FPS, Japanese audio (The Fruit of Grisaia S03E07)
=>      8. Seed of the World Tree I » 1920x1080px, 23.97 FPS, Japanese audio (The Fruit of Grisaia S01E08)
=>      9. The Seed of Blanc Aile V » 1920x1080px, 23.97 FPS, Japanese audio (The Fruit of Grisaia S03E09)
=>      10. The Seed of Blanc Aile VI » 1920x1080px, 23.97 FPS, Japanese audio (The Fruit of Grisaia S03E10)
=>      11. Angelic Howl II » 1920x1080px, 23.97 FPS, Japanese audio (The Fruit of Grisaia S01E11)
=>      12. Angelic Howl III » 1920x1080px, 23.97 FPS, Japanese audio (The Fruit of Grisaia S01E12)
=>      13. 10 Centimeter Field of Fire » 1920x1080px, 23.97 FPS, Japanese audio (The Fruit of Grisaia S01E13)
=>      14. The Cocoon of Caprice 0 » 1920x1080px, 23.97 FPS, Japanese audio (The Fruit of Grisaia S02E14)

I think this is caused because the episodes are sorted after their episode number but not separate by seasons before (this also explains why my output differs from yours).
I'm currently working on the next version (v2) of this project, so no major changes will be made to the current version anymore and the solution of this problem would be such a major change.
But I'm looking forward to release the next version in the next few days, the error is also fixed there:
➞ The Fruit of Grisaia Season 1
➞       1. Leben als normaler Schüler » 1920x1080px, 23.97 FPS (S01E01)
➞       2. School Killer Yumiko » 1920x1080px, 23.97 FPS (S01E02)
➞       3. Süße Ernährung » 1920x1080px, 23.97 FPS (S01E03)
➞       4.  VOX IN BOX » 1920x1080px, 23.97 FPS (S01E05)
➞       6. Raison d’être » 1920x1080px, 23.97 FPS (S01E06)
➞       7. Brief der Glücklichkeit » 1920x1080px, 23.97 FPS (S01E07)
➞       8. Die Saat des Weltenbaums – Teil 1 » 1920x1080px, 23.97 FPS (S01E08)
➞       9. Die Saat des Weltenbaums – Teil 2 » 1920x1080px, 23.97 FPS (S01E09)
➞       10. Angelic Howl – Teil 1 » 1920x1080px, 23.97 FPS (S01E10)
➞       11. Angelic Howl – Teil 2 » 1920x1080px, 23.97 FPS (S01E11)
➞       12. Angelic Howl – Teil 3 » 1920x1080px, 23.97 FPS (S01E12)
➞       13. 10 Zentimeter Schussfeld » 1920x1080px, 23.97 FPS (S01E13)
➞ The Fruit of Grisaia Season 2
➞       1. Der Kokon der Caprice, Teil 0 » 1920x1080px, 23.97 FPS (S02E14)
➞ The Fruit of Grisaia Season 3
➞       1. Der Kokon der Caprice – Teil 1 » 1920x1080px, 23.97 FPS (S03E01)
➞       2. Der Kokon der Caprice – Teil 2 » 1920x1080px, 23.97 FPS (S03E02)
➞       3. Der Kokon der Caprice – Teil 3 » 1920x1080px, 23.97 FPS (S03E03)
➞       4. Der Kokon der Caprice – Teil 4 » 1920x1080px, 23.97 FPS (S03E04)
➞       5. Die Saat des Blanc Aile – Teil 1 » 1920x1080px, 23.97 FPS (S03E05)
➞       6. Die Saat des Blanc Aile – Teil 2 » 1920x1080px, 23.97 FPS (S03E06)
➞       7. Die Saat des Blanc Aile – Teil 3 » 1920x1080px, 23.97 FPS (S03E07)
➞       8. Die Saat des Blanc Aile – Teil 4 » 1920x1080px, 23.97 FPS (S03E08)
➞       9. Die Saat des Blanc Aile – Teil 5 » 1920x1080px, 23.97 FPS (S03E09)
➞       10. Die Saat des Blanc Aile – Teil 6 » 1920x1080px, 23.97 FPS (S03E10)

(The v2 branch cannot be compiled currently)

No problem, take your time xD
I'm looking forward to it.
Thanks

But I'm looking forward to release the next version in the next few days

Haha well, but now fixed in version v2.


Readme fix

@homu r+

:pushpin: Commit 23220d7 has been approved by smo-key

:hourglass: Testing commit 23220d7 with merge 12ef69d...

:sunny: Test successful - status


Keep LB policy alive during high freq of resolver updates

Trigger:
Resolvers providing very frequent updates, O(ms), recreate lb policies at that same rate.
Current state:
Older policies may have received requests for picks. With no time to make progress on those, the application-provided callback is put in the policy's "pending picks" list. When the new policy arrives shortly thereafter, the old policy's single reference count is unref'd, triggering a policy shutdown. The application callback is invoked with error as part of the policy's shutdown process for pending picks.
Solution:
Pending application picks should increase the reference count of the policy they are requesting the pick from. The corresponding unref should happen right before scheduling the application callback. In other words, an application's pending pick must keep its associated lb policy alive.

Performance differences noted:
Benchmark                                                                cpu_time    real_time
---------------------------------------------------------------------  ----------  -----------
BM_HpackEncoderEncodeHeader<SingleInternedBinaryElem<3, false>>/0/16k       +9.00        +9.00

Performance differences noted:
Benchmark                                                    cpu_time    real_time
---------------------------------------------------------  ----------  -----------
BM_HpackParserParseHeader<NonIndexedBinaryElem<10, true>>      -33.00       -33.00
BM_IsolatedFilter<DummyFilter, SendEmptyMetadata>               -6.50        -6.50

Issues: #10614 #9542


how to add new tool to aioli?

I had compile muscle v3 software to wasm by the guide at https://github.com/biowasm/biowasm/blob/main/CONTRIBUTING.md, but I do not know how to add this wasm to aioli? Could you give me some advice?
Thanks!
Si

Hi @orangeSi,
To use it a WebAssembly binary you compiled locally, you can use these files:

https://github.com/biowasm/aioli/blob/main/src/examples/test-biowasm.html
https://github.com/biowasm/aioli/blob/main/src/examples/test-biowasm.js

In the .js file, you can set urlPrefix to the folder on your localhost server that contains the muscle .wasm and .js files. This is the localhost server you would have launched based on the instructions in CONTRIBUTING.md
Then you can open localhost:PORT/test-biowasm.html in your browser and it should run there!

my test-biowasm.js is :
const CLI = await new Aioli([
	{
		tool: "muscle",
		version: "3.8.1551",
		// URL at which .js/.wasm assets are located
		urlPrefix: "http://localhost:8000/",
	},
], { debug: true });

const version = await CLI.exec("muscle -version");
document.getElementById("output-version").innerHTML = version;

and my test-biowasm.html is:

Code

muscle version=

and muscle.js + muscle.wasm + test-biowasm.js + test-biowasm.html  are  in same directory, then I open test-biowasm.html by Chrome and get those two errors in console:
[WebWorker] Setting up muscle (base = true)...
muscle.js:1 Uncaught (in promise) TypeError: Failed to execute 'fetch' on 'WorkerGlobalScope': Failed to parse URL from muscle.wasm
    at instantiateAsync (muscle.js:1:7194)
    at createWasm (muscle.js:1:8129)
    at muscle.js:1:68802
    at Object._setup (f29041e4-fc67-4ad6-b09d-bae2df23de1d:1:7513)
    at Object.init (f29041e4-fc67-4ad6-b09d-bae2df23de1d:1:4026)
    at i (f29041e4-fc67-4ad6-b09d-bae2df23de1d:1:1015)
instantiateAsync @ muscle.js:1
createWasm @ muscle.js:1
（匿名） @ muscle.js:1
_setup @ f29041e4-fc67-4ad6-b09d-bae2df23de1d:1
init @ f29041e4-fc67-4ad6-b09d-bae2df23de1d:1
i @ f29041e4-fc67-4ad6-b09d-bae2df23de1d:1
Promise.then（异步）
instantiateAsync @ muscle.js:1
createWasm @ muscle.js:1
（匿名） @ muscle.js:1
_setup @ f29041e4-fc67-4ad6-b09d-bae2df23de1d:1
init @ f29041e4-fc67-4ad6-b09d-bae2df23de1d:1
i @ f29041e4-fc67-4ad6-b09d-bae2df23de1d:1
aioli.js:2 Uncaught TypeError: Module is not a function
    at Object._setup (blob:http://localhost:8000/f29041e4-fc67-4ad6-b09d-bae2df23de1d:1:7576)
    at Object.init (blob:http://localhost:8000/f29041e4-fc67-4ad6-b09d-bae2df23de1d:1:4026)
    at i (blob:http://localhost:8000/f29041e4-fc67-4ad6-b09d-bae2df23de1d:1:1015)

What should I do for above error?
thanks~
Si

I  try fasttree by guide at https://github.com/biowasm/biowasm/blob/main/tools/fasttree/compile.sh and also got the same above error.

I had resolve it by the guide at https://github.com/biowasm/biowasm/blob/main/bin/compile.py, thanks~

I have one more question: urlPrefix  need a http server, so no http server is possiable for load *.js and *.wasm by some other workaround ?

That's right, you need a web server. If you just open the .html file in your browser (by going to file:///test-biowasm.html), I think it will give an error when trying to load the .wasm.

when I use the way to complie software t_coffee (https://tcoffee.org/Projects/tcoffee/index.html) to wasm and got t_coffee.wasm without error, but when run in Chrome get error:
[WebWorker] Executing t_coffee -seq=input.fa -reg    args=null
20b6be06-daba-47f1-bec0-8e1412abe74c:1 RuntimeError: unreachable
    at set_nproc(int) (t_coffee.wasm:0x1689fa)
    at t_coffee_dpa(int, char**) (t_coffee.wasm:0x4735be)
    at batch_main(int, char**) (t_coffee.wasm:0x4538ab)
    at main (t_coffee.wasm:0x44d553)
    at VM13 t_coffee.js:1581:22
    at Object.callMain (VM13 t_coffee.js:5618:15)
    at Object.exec (20b6be06-daba-47f1-bec0-8e1412abe74c:1:5793)
    at i (20b6be06-daba-47f1-bec0-8e1412abe74c:1:1015)

detail of  at set_nproc(int) (t_coffee.wasm:0x1689fa) is as below:
  (func $set_nproc(int) (;882;) (param $var0 i32) (result i32)
    (local $var1 i32)
    (local $var2 i32)
    (local $var3 i32)
    (local $var4 i32)
    (local $var5 i32)
    global.get $__stack_pointer
    local.set $var1
    i32.const 16
    local.set $var2
    local.get $var1
    local.get $var2
    i32.sub
    local.set $var3
    local.get $var3
    local.get $var0
    i32.store offset=12
    local.get $var3
    i32.load offset=12
    local.set $var4
    i32.const 0
    local.set $var5
    local.get $var5
    local.get $var4
    i32.store offset=696988
    unreachable
  )

Do you occur the silimar error as above?
Thanks~
Si

t_coffee.wasm and t_coffee.js is in t_coffee.wasm.js.zip

Since this is a separate issue, I moved it to https://github.com/biowasm/biowasm/issues/79 and I'll close this one, thanks


Svero is being deprecated.

It's been about a year since the first release of Svero.
Svelte 3 was a brand new technology back then. There were not much dedicated routers (if any). Svero came out of necessity at the time, and now this necessity is no more. Svelte grew in popularity (thanks to the awesome contributors and JavaScript jedi Rich Harris) and lots of router libraries came to life.
Meanwhile my free time got more and more scarce to the point I couldn't even work on Svero 2.0, which should have it's birth months ago.
Due do work schedule and prospects, I do not think there will be much time left in the near future to work on this lib, so I decided to deprecate Svero and officially stop with it's development.
It's a hard decision. I've never deprecated any OS project before, but as of today I see Svero doing more harm than good as newcomers keep coming, staring the project, trying to use it, and failing miserably because it's not being actively maintained.
I recommend those who use Svero to switch to other solutions as soon as possible. I will link alternatives in the bottom of this issue.
If you already use Svero and cannot migrate to other router at the moment, there is no need to worry. This repo will stay public, forks are encouraged, and current npm releases will always be available. Nothing will be deleted, it just won't be updated, fixed or have any more releases.
Here are some alternatives to Svero:

abstract-state-router
svelte-routing
yrv
svelte-spa-router

It's been a week from this issue and I'm now officially archiving this repo. All issues will be closed besides this one. Thanks for all the contributors who helped Svero in any way.


Need a 'Contributing.md' doc with instructions on how to build

I downloaded a copy of the project and opened the .sln in Visual Studio 2015 (with Update 3). I got a couple of errors that some project types are not supported. Once those were dismissed, it popped up a migration report with some details about the errors:
nerdbank-gitversioning.npm\nb-gv.njsproj: The application which this project type is based on was not found. Please try this link for further information: http://go.microsoft.com/fwlink/?LinkId=659044&projecttype=9092AA53-FB77-4645-B42D-1CCCA6BD08BD

Nerdbank.GitVersioning.NuGet\Nerdbank.GitVersioning.NuGet.nuproj: The application which this project type is based on was not found. Please try this link for further information: http://go.microsoft.com/fwlink/?LinkId=659044&projecttype=FF286327-C783-4F7A-AB73-9BCBAD0D4460

Clicking on those links resolved to URLs like: http://dotnetredir.azurewebsites.net/visualstudio?build=Dev14_VSU3_RTW&projecttype=FF286327-C783-4F7A-AB73-9BCBAD0D4460
The pages stuck for a long time on "waiting for response from server", then eventually displayed a simple page with the content "The specified CGI application encountered an error and the server terminated the process."
Does this project require VS2017? Or some special other something installed into VS? It would be great to have a simple "Contributing.md" doc that lists the requirements for building the source.
Thanks!

(forgot to add that after all that, I tried to build the solution, but it failed with a handful of errors, which I could try to figure out, but I imagine there are just some prereq's I'm missing which are throwing a wrench into the works)

Fixed by 310d235


fix(sls): remove unexpected assertion when http body is a json string…

remove unexpected assertion when http body is a json string of an array

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.shuizhao.gh seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Loop in stopped

HTLC Published but now it stopped.
d50369221b219da0c57e948df567e806bc1b2e291b937d51f14ba3ddaad40ea0,"Loop In","4000000","HTLC Published","Aug 18, 9:26 AM","Aug 18, 9:26 AM"

https://github.com/lightninglabs/lightning-terminal/issues/407#issue-1343240863

Hi @RichardPet.
While looking through the issues in this repo, I noticed you never got an answer to your issue... Were you able to resolve this over another communication channel perhaps? Or did the Loop complete normally after the HTLC was confirmed?
Sorry this fell off the radar on our end...

Thanks for the response, but it resolved itself :-)


APIError(code=-2010)

some transactions have more decimals than supported for some trades, a rounding function should fix this

I have no clue why this is happening, however placing a limit order with the market price seems to fix this issue and sell right after it's placed

This should have been addressed. Please clone main and try again. If it arises, please share stack traces, errors, and config. Cheers.


No module named 'pyozw_win'

Can't install Z-Wave in Windows :(
(.homeassistant) C:\Users\owner\.homeassistant>pip3 install homeassistant-pyozw
Collecting homeassistant-pyozw
  Using cached https://files.pythonhosted.org/packages/79/79/478710618faa11f4e78c38abd08f0b152938a8e27706798d5ba7b3ecdf59/homeassistant_pyozw-0.1.1.zip
    Complete output from command python setup.py egg_info:
    ImportError in : from wheel.bdist_wheel import bdist_wheel as _bdist_wheel
    NameError in : class bdist_wheel(_bdist_wheel) - Use bdist_egg instead
    sysargv ['-c', 'egg_info', '--egg-base', 'pip-egg-info']
    Found SETUP_DIR : C:\Users\owner\AppData\Local\Temp\pip-install-evwa1ayd\homeassistant-pyozw
    <pyozw_setup.EmbedTemplate object at 0x0000027651670128>
    Traceback (most recent call last):
      File "<string>", line 1, in <module>
      File "C:\Users\owner\AppData\Local\Temp\pip-install-evwa1ayd\homeassistant-pyozw\setup.py", line 42, in <module>
        print(current_template.ctx)
      File "C:\Users\owner\AppData\Local\Temp\pip-install-evwa1ayd\homeassistant-pyozw\pyozw_setup.py", line 224, in ctx
        self._ctx = self.get_context()
      File "C:\Users\owner\AppData\Local\Temp\pip-install-evwa1ayd\homeassistant-pyozw\pyozw_setup.py", line 803, in get_context
        ctx = self.system_context(ctx, static=True)
      File "C:\Users\owner\AppData\Local\Temp\pip-install-evwa1ayd\homeassistant-pyozw\pyozw_setup.py", line 143, in system_context
        from pyozw_win import get_system_context
    ModuleNotFoundError: No module named 'pyozw_win'

    ----------------------------------------
Command "python setup.py egg_info" failed with error code 1 in C:\Users\owner\AppData\Local\Temp\pip-install-evwa1ayd\homeassistant-pyozw\
You are using pip version 10.0.1, however version 18.1 is available.
You should consider upgrading via the 'python -m pip install --upgrade pip' command.

(.homeassistant) C:\Users\owner\.homeassistant>

I did a pip download homeassistant-pyozw --dest=./temp and extracted the .zip that was downloaded. The pyozw_win.py is indeed missing from the pip.
This looks to be the only commit in the new fork that touched anything with the pip creation. I don't see anything that would have excluded pyozw_win.py from being deployed. Was the package just created incorrectly? Is there a CI/CD with the fork? Or is this being done manually for the HA fork?
I'm new to Python but veteran Windows developer. I'd love to help investigating and fixing this, but I need a little push.

It looks like the same issue exists on Windows in the original repo. I guess we should try to fix it there first, and then sync up homeassistant_pyozw. I put an issue in there and will try to work with that team. But if anyone has any helpful tips or thoughts, please share them.

@balloobbot @balloob this is still an issue.  I can confirm it is still broken as of the latest release and I am still having to deploy a custom build of pyton-openzwave.
It would be resolved by merging the upstream changes in https://github.com/OpenZWave/python-openzwave into https://github.com/home-assistant/python-openzwave
https://github.com/home-assistant/home-assistant/issues/18552 also has similar issues that would be resolved in the same way.
I have pinged the developer channel on Discord a couple times but can't get a response as to when or if this is ever going to happen now that HA has forked python-openzwave.  I did log a work around in 18552 for Windows users to still be able to use zwave in Windows on current versions of HA until this issue is resolved.


stacking "futures"

Use case:

Assuming a staking pool of poxl-token-trait rewarding reward-token-trait is activated and running,
CONTRACT-OWNER can create a pool by calling create-pool with poxl-token-trait, reward-token-trait, a list of reward-cycles of size 32 (e.g. [1..32], implying reward-cycle 1 to 32) and a yield-token that represents ownership of the pool.
users can add liquidity to the pool by calling add-to-position with amount dx, provided the pool has not started staking. Adding a position mints yield-token to represent the proportional ownership of the pool.
users can remove liquidity from the pool by calling reduce-position with percent percent, provided the pool completed staking. Upon removing liquidity, users receive the staked poxl-token-trait and some reward-token-trait, and burn yield-token.


Add a way to customize the OpenOptions for a file

The use case I have in mind is being able to write a file out, then read
it to validate it. For that, the file needs to be opened in read-write
mode.

Thank you!


[Bug] Referrers 0 but Referring Sites is populated

Description
I have 2 referrers in my Referring Sites section but Referrers stat at the top of the TUI is 0.
Expected Result
Referrers would have a value of 2
Background
Hi! Maybe I'm not quite understanding the data that's trying to be presented. I'm using NGINX and have set the following parsing for my log lines:
goaccess --log-format='%h %^[%d:%t %^] "%r" %s %b "%R" "%u"' --date-format='%d/%b/%Y' --time-format='%H:%M:%S' /var/log/nginx/access.log

I'm running goaccess 1.9.3
goaccess --version
GoAccess - 1.9.3.
For more details visit: https://goaccess.io/
Copyright (C) 2009-2024 by Gerardo Orellana

Build configure arguments:
  --enable-utf8
  --enable-geoip=mmdb
  --with-openssl

I can see referrers in my logs ("https://forge.frodux.in/assets/js/eventsource.sharedworker.js?v=9.0.2" for example:
<IP_ADDRESS> - - [15/Dec/2024:00:46:55 -0500] "GET /user/events HTTP/2.0" 200 0 "https://forge.frodux.in/assets/js/eventsource.sharedworker.js?v=9.0.2" "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/<IP_ADDRESS> Safari/537.36 Edg/<IP_ADDRESS>"
<IP_ADDRESS> - - [15/Dec/2024:00:47:09 -0500] "GET /user/events HTTP/2.0" 200 417 "https://forge.frodux.in/assets/js/eventsource.sharedworker.js?v=9.0.2" "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/<IP_ADDRESS> Safari/537.36 Edg/<IP_ADDRESS>"
<IP_ADDRESS> - - [15/Dec/2024:01:03:52 -0500] "GET /user/events HTTP/2.0" 200 430 "https://forge.frodux.in/assets/js/eventsource.sharedworker.js?v=9.0.2" "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/<IP_ADDRESS> Safari/537.36 Edg/<IP_ADDRESS>"
<IP_ADDRESS> - - [15/Dec/2024:01:22:33 -0500] "GET /user/events HTTP/2.0" 200 0 "https://forge.frodux.in/assets/js/eventsource.sharedworker.js?v=9.0.2" "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/<IP_ADDRESS> Safari/537.36 Edg/<IP_ADDRESS>"

And I can see referrers in my output:

But the Top Level stats show Referrers 0

cc @shapr who has also experienced this with his logs (though the same log format so maybe we're both holding it wrong!)

Good question! I believe it's related to the referrers panel, which is disabled by default. You can enable it with the following option:  --enable-panel=REFERRERS. Let me know if that works for you!

@allinurl ok awesome thanks! What is that supposed to be hiding? Since I can see the referrers section and the heading?

One displays the full referrer (assuming --enable-panel=REFERRERS), while the other shows just the site. For example:

Are you seeing something else?

@allinurl oh that makes sense, I think I just wasn't fully grokking what I was seeing. Thanks so much for the fast and thorough support!


how to upload several files to my Documents? currently, I can only upload one by one, that's very inefficient.

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Describe the solution you'd like
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

duplicate #655

https://github.com/ollama-webui/ollama-webui/issues/651#issuecomment-1932186418


Geteduroam not working on Android 10

On an Android 10 device:

removing all eduroam networks and deinstalling Geteduroam and Eduroam Cat
Installing Geteduroam from Google Play
Searching Institution (DKFZ) and enter user information, push Install
Receiving silent message and push "yes"
Connect with WLAN eduroam => enter user and password, a certificate must be selected, we choose the one with EDUROAM in the name.

Now trying to connect to WLAN eduroam does not succeed without any information or error. It just doesn't connect successfully.
What can we try next? Are there any diagnostics possible to report?

Any news? Can we help somehow with some diagnostics?


[Bug] module 'asyncio' has no attribute 'coroutine'

This error originated from a custom integration.
Logger: homeassistant.loader
Source: custom_components/smart_irrigation/sensor.py:124
Integration: Smart Irrigation (documentation, issues)
First occurred: 4:26:05 PM (8 occurrences)
Last logged: 4:26:05 PM
Unexpected exception importing platform custom_components.smart_irrigation.sensor
Traceback (most recent call last):
File "/usr/src/homeassistant/homeassistant/loader.py", line 833, in get_platform
cache[full_name] = self._import_platform(platform_name)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/src/homeassistant/homeassistant/loader.py", line 850, in _import_platform
return importlib.import_module(f"{self.pkg_path}.{platform_name}")
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.11/importlib/init.py", line 126, in import_module
return _bootstrap._gcd_import(name[level:], package, level)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "", line 1206, in _gcd_import
File "", line 1178, in _find_and_load
File "", line 1149, in _find_and_load_unlocked
File "", line 690, in _load_unlocked
File "", line 940, in exec_module
File "", line 241, in _call_with_frames_removed
File "/config/custom_components/smart_irrigation/sensor.py", line 102, in
class SmartIrrigationSensor(SmartIrrigationEntity):
File "/config/custom_components/smart_irrigation/sensor.py", line 124, in SmartIrrigationSensor
@asyncio.coroutine
^^^^^^^^^^^^^^^^^
AttributeError: module 'asyncio' has no attribute 'coroutine'

Same here, this happens when upgrading to HA version 2023.06

The issues is understood but we are waiting for a merge of the fix. Please refer to #130 as you may edit the file yourself locally to fix it till the official update.

https://github.com/jeroenterheerdt/HAsmartirrigation/releases/tag/v.0.0.79


chore remove some useless code

remove vectorAnalyze and computeOutputColumn function on Expr
remove vectorOpcode and outputColumn attribute on Expr
remove useless static LOG object on some Expr class
Proposed changes
Issue Number: close #xxx

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

run buildall

run buildall


Android SDK can not be downloaded anymore

Hello,
I was starting to use briefcase following the tutorial but got stuck on the briefcase create android step.
Apparently the Android SDK is no longer supported and cannot be downloaded anymore. I get the following error message while I am in fact online.
Unable to download Android SDK; is your computer offline?
To recreate the issue you should start without the Android SDK and try briefcase create android.

Kind regards
Python 3.6
briefcase 0.3.3

Could this be because off a secured network?

It was because of a secured network.


 Bytes to String, I do not understand

Sorry but I can't understand what you're trying to tell. Compilation errors or something like that? If so, I'd recommend upgrading Unity to 2022.2 (as noted on README).

I close this issue as answered. Please reopen it for further problems.


examples/nested-components: use an apostrophe rather than a prime

This is just my OCD, but this file is much easier on the eyes when apostrophes are used rather than primes. It's also proper, as the prime is used in mathematics, not written English.

This is great. This level of attention to detail is what we aspire to. Thank you


Reset pagination on search

To accomplish this the search query was moved out of Search.JS and into QueryBox.JS.
useEffect is watching for changes to the searchQuery and resetting the pagination before sending the request to the API

Task linked: CU-1xr76wm Reset pagination on search

I think I understand this one. Fingers crossed.


Field for slowdown% (LLS/MS)

LLS and MS have slowdown percentages tracked but they don't support replays. There's however no way to manually enter the slowdown percentage when submitting a score.

Yeah, I guess this makes sense to add, since some people (and old replays) have machines that struggle to keep up with PC-98 emulators. I hate asking users for stuff like this, but I think this one is probably worth it, although I'm still inclined to make it optional.


Easy Clue: Search the bucket in the Port Sarim jail.

Bucket not highlighted w/ clue overlay, object listed in tooltip as null.

This should be fixed from this PR, if you wanna update your game and check? (if you still have the clue scroll)

I don't have the clue still, sorry. Not using the Snapshot, if it was fixed in there.

Fixed with #1383


Store Application missing generate token button

Description:
Add Generate Token button to APIM Store Application page
Affected Product Version:
APIM 3.0.0

Fixed with: https://github.com/wso2/carbon-apimgt/pull/4800 hence closing the issue


The Landing page for the plugin documentation is missing information about Grails 5 compatible version

Issue description
The Landing page for the plugin documentation is missing information about Grails 5 compatible version

Fixed by #965


Search icon color remains unchanged on hover

Screenshot for reference:

I'd like to work on this issue @max-programming.
Could you please assign it to me?

Alright go ahead


Reduce API list_volume when Attaching and Mounting Volumes

With this PR these IStateChanges are constructed with blockdevice_ids. This means that they do not have to do the dataset_id -> blockdevice_id mapping as part of their execution. This enables the removal of list_volumes() calls at the beginning of the execution of either of them.

Thanks!  Looks pretty good, just a few minor points.  One other thing that would be interesting is to see a count of the number of API calls made by a run of the acceptance test suite with and without this change.  I think our logs have this information so it's just a matter of a couple greps.  If you could do that and post the results somewhere, I think that'd be cool.  Then, please address the other review comments and merge.  Thanks!

Reviewed 2 of 2 files at r1.
Review status: all files reviewed at latest revision, 4 unresolved discussions, all commit checks successful.

flocker/node/agents/blockdevice.py, line 450 [r1] (raw file):
Pre-existing bad-naming here, sorry about that.  This is really the identifier of the IBlockDeviceAPI-managed volume.

flocker/node/agents/blockdevice.py, line 554 [r1] (raw file):
Likewise here.

flocker/node/agents/test/test_blockdevice.py, line 1203 [r1] (raw file):
It might be nice (ie, do this if you feel like it, not required) to put this logic into a helper function for use throughout this test module.

flocker/node/agents/test/test_blockdevice.py, line 3549 [r1] (raw file):
I wonder if it's worth replacing this with a test for the new failure behavior we'll get.  The failure from destroy_volume, UnknownVolume, will now be passed through.  An argument against doing this is that we probably don't much care exactly how this fails (demonstrated by the fact that I don't care that this PR changes the exception from DatasetWithoutVolume to UnknownVolume).
The value might be in proving that AttachVolume.run returns a Deferred that's connected to the underlying IBlockDeviceAPI call at all, though.  If the implementation returned None then the system wouldn't wait for the operation to complete, which is probably bad, and I don't think any other test would catch this.  Likewise, if it just returned succeed(None) then things wouldn't wait (and any test that just wanted a Deferred would still be satisfied).
So... yea... maybe there is value in having this negative-case test.

Comments from the review on Reviewable.io

Wrote a tiny python blob to count for me, ran on remote-logs from flocker/acceptance/aws/centos-7/aws:
process.py.txt
./both.txt 1661  - Includes This PR and #2057
./first.txt 1688    - only includes #2057
./before.txt 1780 - without # 2057 or this PR
So looks like the big wins are already in master (#2057), but this does drop order 1% of calls.
Now going to look through the review, address and merge.

Re-running buildbot runs and merging once I've convinced them to be green.

Review status: 0 of 2 files reviewed at latest revision, all discussions resolved, all commit checks successful.

flocker/node/agents/blockdevice.py, line 450 [r1] (raw file):
Done. Changed all docstrings in the file (Even some from my earlier PR).

flocker/node/agents/blockdevice.py, line 554 [r1] (raw file):
Done.

flocker/node/agents/test/test_blockdevice.py, line 1203 [r1] (raw file):
Done.

flocker/node/agents/test/test_blockdevice.py, line 3549 [r1] (raw file):
Added it back, made it work with UnknownVolume. hadn't thought about your second point.

Comments from the review on Reviewable.io


⚠ GitLab Server has degraded performance

In 8a981f2, GitLab Server (https://gitlab01.its-telekom.eu) experienced degraded performance:

HTTP code: 200
Response time: 10507 ms

Resolved: GitLab Server performance has improved in e982b29.


USB Host detection

Via:
http://developer.android.com/reference/android/content/pm/PackageManager.html#hasSystemFeature(java.lang.String)
we can detected whether an Android device supports USB Host mode:
http://developer.android.com/reference/android/content/pm/PackageManager.html#FEATURE_USB_HOST
We could extend the cordova-plugin-chrome-apps-usb Cordova plugin with an API for this. For example:
chrome.usb.cordova.hasUsbHostFeature(function (result) {
    console.log("USB Host supported: " + result);
});

sounds good to me!

@agrieve before or after a 1.1.1?

@agrieve I've tried to do a PR between my unregisterReceiverFix branch and my issue4 branch. But then the PR ends up at my repository instead of @ MobileChromeApps. See:
https://github.com/e-Contract/cordova-plugin-chrome-apps-usb/pull/1


[LinearProgress] color="action.disabled" is crashing

<LinearProgress color="primary" /> works.
<LinearProgress color="action.disabled" /> does not work (crash)
<LinearProgress color="inherit" sx={{ color: "action.disabled" }}  /> works as expected (workaround)
For example, These things work as expected:
<Typography color="action.disabled">qwe</Typography>
<Typography color="primary">qwe</Typography>
<Typography color="primary.dark">qwe</Typography>

Hi.
Thanks for opening the issue.
Typography API Docs says

As a CSS utility, the Typography component also supports all system properties. You can use them as props directly on the component.

However, for many other components including LinearProgress, you can't use system props directly on the component. Instead, you will need to use sx as you've already mentioned. e.g., https://mui.com/system/palette/#color

So, API is not consistent. It's not easy to understand where I can use what colors. Seems, property names are the same, but  allowed values are different.

The same about sx. It is separately documented. Why ? Are the other system props work ? Strange and wobbly API. Sometimes something works, and sometimes no, without any obvious reasons. I would advise renaming intersecting props. Because the set of allowed values is different (comparing same named system prop and non-system).

Yes, I agree with the confusion. What do you think about this Sam @samuelsycamore ?

It's to be notted that in these two examples:
<LinearProgress color="primary" />
<LinearProgress color="inherit" sx={{ color: "action.disabled" }} />

the color does not behave the same way. The color logic is vastly different, so I don't think that
<LinearProgress color="action.disabled" />

should ever be supported, it would be confusing. This being said, maybe the root problem is that we call the prop color. maybe if it was called differently, like:
<LinearProgress palette="primary" />

then it would be clear.


Select with custom value option

I would like a Select element that allows the user to input either custom value or a predefined value. Is there a way to implement this functionality with the current Select component? If not, can this functionality be added?

@RedHatter Maybe this documentation page will help: https://material-ui-next.com/demos/autocomplete/.


"Dynamic" softmax objective?

Currently, for multi-class classification, XGBoost supports a "fixed" label set, where separate trees are extracted per label. To handle "dynamic" label sets, one must do binary classification or a ranking classification. However it is often better to do softmax classification over a label set.
For example, consider a task where I give you a natural language text.
Passage: "Sally gave the ball to John. John threw the ball to Timmy. Timmy took the ball home."
Question: "Who has the ball?"
Candidates = [Sally, John, Timmy]
Label = Timmy
We would extract a feature vector for each candidate:
Sally = ['ball'-in-question-and-ball-after-name, is-first-name-mentioned, ...]
John = ['ball'-in-question-and-'ball'-after-name, is-second-name-mentioned, ...]
Timmy = ['ball'-in-question-and-'ball'-before-name, last-instance-with-'ball'...,]
Right now the best we could do is just do a logistic regression 3 different training samples and Timmy = 1, Sally = 0, John = 0 or we could do a ranking objective where Timmy = 0, Sally = 1, John = 1. But for cases like this it is often better to do a softmax over the candidates (especially when the number of candidates is large.), since we know there is exactly 1 correct answer and we want a probability distribution.
This should be fairly straightforward to do with the "group" mechanism by following the existing code for ranking objective + softmax, correct? I can add it myself in my fork if this is the case, but I want to make sure I'm not missing something.

Old proposition, no answer. Closing


Add LockFreeApiEventProducer

This is another piece of the new manual instrumentation change that uses the side-channel
to send event from the target process to OrbitService. In this PR, we define a simple ApiEvent
capture event that wraps raw orbit_api::ApiEvent's.
The LockFreeApiEventProducer and LockFreeApiEventBulkProducer are two variants of event
producers that will be used to compare the performance of different approaches for sending
events. They both push raw api events to a lockless queue from multiple threads and have a single
consumer thread that translates the raw events into capture events (protobufs). The difference is that
the "Bulk" version wraps multiple raw events into a single CaptureEvent to amortize the cost of
creating protobufs. The goal will be to iterate on the non-bulk implementation to see how close we
can get in terms of performance to the bulk approach.
This PR focuses on the production and sending of events from the target process to OrbitService.
The next PR will actually process those events.
Note that LockFreeBufferBulkCaptureEventProducer.h is basically a copy of the existing LockFreeBufferCaptureEventProducer.h with the minor modification of allowing to translate multiple
intermediate events at once. Maybe both classes could be merged as this could be an optimization
even for the normal use case (instead of calling translate function once per event, we could call it
once for all the dequeued events).

@dpallotti , thanks for the input, let's take it offline as you suggested!


Yarn 2 "portal:" local components import compilation failure because of ModuleScopePlugin

Describe the bug
Description here: https://stackoverflow.com/questions/61530712/module-not-found-error-using-yarn-2-to-link-react-components
TLDR:
When adding "MyExternalComponent": "portal:../MyExternalComponent" dependencies to package.json, and importing the component with import Mycomponent from MyExternalComponent, the build fails because of the ModuleScopePlugin restriction "You attempted to import components which falls outside of the project src/ directory"
Which terms did you search for in User Guide?

"yarn 2 ModuleScopePlugin"
"portal: ModuleScopePlugin"
Environment

yarn2
(paste the output of the command here.)
Steps to reproduce

(Write your steps here:)

create a package in folder Foo
yarn dlx create-react-app Bar
add "Foo": "portal:../Foo" to Bar's package.json
4 build Bar

Expected behavior
Should work
Actual behavior
compilation error: "You attempted to import components which falls outside of the project src/ directory"
Reproducible demo
https://bitbucket.org/cjmyles/yarn2-link/commits/e02b93771dfded0215bdba456d31aea011367807

Still unsolved

Same issue in workspaces with Yarn 2

Up
Le dim. 13 sept. 2020 à 20:29, stale[bot]<EMAIL_ADDRESS>a
écrit :

This issue has been automatically marked as stale because it has not had
any recent activity. It will be closed in 5 days if no further activity
occurs.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/facebook/create-react-app/issues/9226#issuecomment-691706825,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAVY6EDJPNDTYONF2TIJ3TSFUFO5ANCNFSM4OJGQVAQ
.

I had the same problem, ended up having to eject and remove ModuleScopePlugin
I understand that it CRA wants to prevent me from doing import foo from '../../../../bar' but the way ModuleScopePlugin is implemented means you can't use the linking features of yarn, lerna, etc.  My imports look like this import foo from 'bar'  and are linked using my package manager, which should be fine IMO.

For what it's worth, if you are using yarn v2, you can use their patch protocol to patch react-scripts to not include the ModuleScopePlugin (so you don't have to eject).


Repo sync for protected CLA branch

The pull request is created from main637898744477064019 to main to fix git push error for protected CLA branch

@v-alje : Thanks for your contribution! The author(s) have been notified to review your proposed change.


[AIRFLOW-2845] Remove asserts from the contrib package

Make sure you have checked all steps below.
Jira

[x] My PR addresses the following AIRFLOW-2845 issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"

https://issues.apache.org/jira/browse/AIRFLOW-XXX
In case you are fixing a typo in the documentation you can prepend your commit with [AIRFLOW-XXX], code changes always need a Jira issue.

Description

[x] Here are some details about my PR, including screenshots of any UI changes:
asserts is used in Airflow contrib package code .  And from point of view for which purposes asserts are really is, it's not correct.

If we look at documentation we could find information what asserts is debug tool: https://docs.python.org/3/reference/simple_stmts.html#the-assert-statement and also it is could be disabled globally by default.
So, I just want to change debug asserts to ValueError and TypeError.
Tests

[x] My PR adds the following unit tests OR does not need testing for this extremely good reason:
It's covered by existing tests. No new features or important changes.

Commits

[x] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":

Subject is separated from body by a blank line
Subject is limited to 50 characters (not including Jira issue reference)
Subject does not end with a period
Subject uses the imperative mood ("add", not "adding")
Body wraps at 72 characters
Body explains "what" and "why", not "how"

Documentation

[x] In case of new functionality, my PR adds documentation that describes how to use it.

When adding new operators/hooks/sensors, the autoclass documentation generation needs to be added.

Code Quality

[x] Passes git diff upstream/master -u -- "*.py" | flake8 --diff

it's little PR, just for clean code

Codecov Report

Merging #3690 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3690   +/-   ##
=======================================
  Coverage   77.57%   77.57%
=======================================
  Files         205      205
  Lines       15771    15771
=======================================
  Hits        12234    12234
  Misses       3537     3537

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da4f254...ba6f4b3. Read the comment docs.

@Fokko That looks fine. I wasn't entirely sure about assert just being a debug tool. But looks like it is from the link provided.

Most of the time assert is enabled in Python, but it can be disabled so shouldn't be relied on for critical checks.

thanks all for the review :)


text height is different on android devices with virtual navigation bars than on android devices without virtual navigation bars.

text height of Chinese characters is different on android devices with virtual navigation bars than on android devices without virtual navigation bars. iOS behaves like an android device with a virtual navigation bar.
this is on android devices with virtual navigation bars

this is on android devices without virtual navigation bars

this is on ios

Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel master, v0.5.8-pre.152, on Mac OS X 10.13.6 17G65, locale en-CN)
[✓] Android toolchain - develop for Android devices (Android SDK 27.0.3)
[✓] iOS toolchain - develop for iOS devices (Xcode 10.0)
[✓] Android Studio (version 3.1)
[✓] IntelliJ IDEA Ultimate Edition (version 2018.1.6)
[✓] VS Code (version 1.25.0)
[✓] Connected devices (3 available)

• No issues found!

I will look into this a bit and see what I can do.

So far, it seems that the problem is originating in Skia font metrics, which is providing drastically different metrics.fDescent for different devices. Will see if it is a problem with what we are passing to Skia or not.

@yohom Is your "device without virtual navigation bar" a Samsung device? Also, do you have a non-Samsung device that does not have a virtual navigation bar? I suspect the issue may be from Samsung default fonts rather than something flutter/skia is doing.


experimenting with formatting features

:warning: Validation status: warnings

File
Status
Preview URL
Details

docs/cloud-adoption/index.md
:warning:Warning
View
Details

docs/cloud-adoption/index.md

Line 24: [Warning] Invalid file link:(~/cloud-adoption/governance/overview.md).

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:warning: Validation status: warnings

File
Status
Preview URL
Details

docs/cloud-adoption/index.md
:warning:Warning
View
Details

docs/cloud-adoption/getting-started/overview.md
:white_check_mark:Succeeded
View

docs/cloud-adoption/index.md

Line 24: [Warning] Invalid file link:(~/cloud-adoption/governance/overview.md).

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:x: Validation status: errors

File
Status
Preview URL
Details

:x:Error

Details

[Error] Cannot sync git repo to specified state. Please make sure the pull request is mergeable. Details: Git merge results in conflict, repository remote url: https://github.com/mspnp/architecture-center, working directory: W:\smvq-s, target branch: eca/demo, target branch commit: 358869dcfd5f96fb2d86f5c48213e0a75adc89db, source branch: bennage/eca, source branch commit: .

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:x: Validation status: errors

File
Status
Preview URL
Details

:x:Error

Details

[Error] Cannot sync git repo to specified state. Please make sure the pull request is mergeable. Details: Git merge results in conflict, repository remote url: https://github.com/mspnp/architecture-center, working directory: W:\z1v5-s, target branch: eca/demo, target branch commit: a5c0dc319810da695768618fe2215085d5cfcca2, source branch: bennage/eca, source branch commit: .

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:x: Validation status: errors

File
Status
Preview URL
Details

:x:Error

Details

[Error] Cannot sync git repo to specified state. Please make sure the pull request is mergeable. Details: Git merge results in conflict, repository remote url: https://github.com/mspnp/architecture-center, working directory: W:\kkfb-s, target branch: eca/demo, target branch commit: f976d8fde29efaeb19e7d95d84379cdc3ca08f83, source branch: bennage/eca, source branch commit: .

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:x: Validation status: errors

File
Status
Preview URL
Details

:x:Error

Details

[Error] Cannot sync git repo to specified state. Please make sure the pull request is mergeable. Details: Git merge results in conflict, repository remote url: https://github.com/mspnp/architecture-center, working directory: W:\crqa-s, target branch: eca/demo, target branch commit: f976d8fde29efaeb19e7d95d84379cdc3ca08f83, source branch: bennage/eca, source branch commit: .

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:x: Validation status: errors

File
Status
Preview URL
Details

:x:Error

Details

[Error] Cannot sync git repo to specified state. Please make sure the pull request is mergeable. Details: Git merge results in conflict, repository remote url: https://github.com/mspnp/architecture-center, working directory: W:\yrqw-s, target branch: eca/demo, target branch commit: f976d8fde29efaeb19e7d95d84379cdc3ca08f83, source branch: bennage/eca, source branch commit: .

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:warning: Validation status: warnings

File
Status
Preview URL
Details

docs/cloud-adoption/governance/overview.md
:warning:Warning
View
Details

.openpublishing.redirection.json
:white_check_mark:Succeeded

docs/cloud-adoption/getting-started/azure-resource-access.md
:white_check_mark:Succeeded
View

docs/cloud-adoption/getting-started/overview.md
:white_check_mark:Succeeded
View

docs/cloud-adoption/getting-started/what-is-azure.md
:white_check_mark:Succeeded
View

docs/cloud-adoption/getting-started/what-is-governance.md
:white_check_mark:Succeeded
View

docs/cloud-adoption/governance/governance-multiple-teams.md
:white_check_mark:Succeeded
View

docs/cloud-adoption/governance/governance-single-team.md
:white_check_mark:Succeeded
View

docs/cloud-adoption/index.md
:white_check_mark:Succeeded
View

docs/cloud-adoption/infrastructure/basic-workload.md
:white_check_mark:Succeeded
View

docs/toc.yml
:white_check_mark:Succeeded
View

docs/cloud-adoption/governance/overview.md

Line 9: [Warning] Invalid file link:(~/cloud-adoption/getting-started/governance-explainer.md).
Line 11: [Warning] Invalid file link:(~/cloud-adoption/governance/governance-how-to.md).
Line 11: [Warning] Invalid file link:(~/cloud-adoption/governance/governance-design-guide.md).

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

.openpublishing.redirection.json
:white_check_mark:Succeeded

docs/cloud-adoption/getting-started/azure-resource-access.md
:white_check_mark:Succeeded
View

docs/cloud-adoption/getting-started/overview.md
:white_check_mark:Succeeded
View

docs/cloud-adoption/getting-started/what-is-azure.md
:white_check_mark:Succeeded
View

docs/cloud-adoption/getting-started/what-is-governance.md
:white_check_mark:Succeeded
View

docs/cloud-adoption/governance/governance-multiple-teams.md
:white_check_mark:Succeeded
View

docs/cloud-adoption/governance/governance-single-team.md
:white_check_mark:Succeeded
View

docs/cloud-adoption/governance/overview.md
:white_check_mark:Succeeded
View

docs/cloud-adoption/index.md
:white_check_mark:Succeeded
View

docs/cloud-adoption/infrastructure/basic-workload.md
:white_check_mark:Succeeded
View

docs/toc.yml
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

.openpublishing.redirection.json
:white_check_mark:Succeeded

docs/cloud-adoption/getting-started/azure-resource-access.md
:white_check_mark:Succeeded
View

docs/cloud-adoption/getting-started/overview.md
:white_check_mark:Succeeded
View

docs/cloud-adoption/getting-started/what-is-azure.md
:white_check_mark:Succeeded
View

docs/cloud-adoption/getting-started/what-is-governance.md
:white_check_mark:Succeeded
View

docs/cloud-adoption/governance/governance-multiple-teams.md
:white_check_mark:Succeeded
View

docs/cloud-adoption/governance/governance-single-team.md
:white_check_mark:Succeeded
View

docs/cloud-adoption/governance/overview.md
:white_check_mark:Succeeded
View

docs/cloud-adoption/index.md
:white_check_mark:Succeeded
View

docs/cloud-adoption/infrastructure/basic-workload.md
:white_check_mark:Succeeded
View

docs/toc.yml
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

.openpublishing.redirection.json
:white_check_mark:Succeeded

docs/cloud-adoption/_images/enterprise-cloud-adoption.png
:white_check_mark:Succeeded
View

docs/cloud-adoption/getting-started/azure-resource-access.md
:white_check_mark:Succeeded
View

docs/cloud-adoption/getting-started/overview.md
:white_check_mark:Succeeded
View

docs/cloud-adoption/getting-started/what-is-azure.md
:white_check_mark:Succeeded
View

docs/cloud-adoption/getting-started/what-is-governance.md
:white_check_mark:Succeeded
View

docs/cloud-adoption/governance/governance-multiple-teams.md
:white_check_mark:Succeeded
View

docs/cloud-adoption/governance/governance-single-team.md
:white_check_mark:Succeeded
View

docs/cloud-adoption/governance/overview.md
:white_check_mark:Succeeded
View

docs/cloud-adoption/index.md
:white_check_mark:Succeeded
View

docs/cloud-adoption/infrastructure/basic-workload.md
:white_check_mark:Succeeded
View

docs/toc.yml
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

.openpublishing.redirection.json
:white_check_mark:Succeeded

docs/cloud-adoption/_images/enterprise-cloud-adoption.png
:white_check_mark:Succeeded
View

docs/cloud-adoption/getting-started/azure-resource-access.md
:white_check_mark:Succeeded
View

docs/cloud-adoption/getting-started/overview.md
:white_check_mark:Succeeded
View

docs/cloud-adoption/getting-started/what-is-azure.md
:white_check_mark:Succeeded
View

docs/cloud-adoption/getting-started/what-is-governance.md
:white_check_mark:Succeeded
View

docs/cloud-adoption/governance/governance-multiple-teams.md
:white_check_mark:Succeeded
View

docs/cloud-adoption/governance/governance-single-team.md
:white_check_mark:Succeeded
View

docs/cloud-adoption/governance/overview.md
:white_check_mark:Succeeded
View

docs/cloud-adoption/includes/header.md
:white_check_mark:Succeeded
View

docs/cloud-adoption/index.md
:white_check_mark:Succeeded
View

docs/cloud-adoption/infrastructure/basic-workload.md
:white_check_mark:Succeeded
View

docs/toc.yml
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

.openpublishing.redirection.json
:white_check_mark:Succeeded

docs/_bread/toc.yml
:white_check_mark:Succeeded

docs/cloud-adoption/_images/enterprise-cloud-adoption.png
:white_check_mark:Succeeded
View

docs/cloud-adoption/getting-started/azure-resource-access.md
:white_check_mark:Succeeded
View

docs/cloud-adoption/getting-started/overview.md
:white_check_mark:Succeeded
View

docs/cloud-adoption/getting-started/what-is-azure.md
:white_check_mark:Succeeded
View

docs/cloud-adoption/getting-started/what-is-governance.md
:white_check_mark:Succeeded
View

docs/cloud-adoption/governance/governance-multiple-teams.md
:white_check_mark:Succeeded
View

docs/cloud-adoption/governance/governance-single-team.md
:white_check_mark:Succeeded
View

docs/cloud-adoption/governance/overview.md
:white_check_mark:Succeeded
View

docs/cloud-adoption/includes/header.md
:white_check_mark:Succeeded
View

docs/cloud-adoption/index.md
:white_check_mark:Succeeded
View

docs/cloud-adoption/infrastructure/basic-workload.md
:white_check_mark:Succeeded
View

docs/toc.yml
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

.openpublishing.redirection.json
:white_check_mark:Succeeded

docs/_bread/toc.yml
:white_check_mark:Succeeded

docs/cloud-adoption/_images/enterprise-cloud-adoption.png
:white_check_mark:Succeeded
View

docs/cloud-adoption/getting-started/azure-resource-access.md
:white_check_mark:Succeeded
View

docs/cloud-adoption/getting-started/overview.md
:white_check_mark:Succeeded
View

docs/cloud-adoption/getting-started/what-is-azure.md
:white_check_mark:Succeeded
View

docs/cloud-adoption/getting-started/what-is-governance.md
:white_check_mark:Succeeded
View

docs/cloud-adoption/governance/governance-multiple-teams.md
:white_check_mark:Succeeded
View

docs/cloud-adoption/governance/governance-single-team.md
:white_check_mark:Succeeded
View

docs/cloud-adoption/governance/overview.md
:white_check_mark:Succeeded
View

docs/cloud-adoption/index.md
:white_check_mark:Succeeded
View

docs/cloud-adoption/infrastructure/basic-workload.md
:white_check_mark:Succeeded
View

docs/toc.yml
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

.openpublishing.redirection.json
:white_check_mark:Succeeded

docs/_bread/toc.yml
:white_check_mark:Succeeded

docs/best-practices/naming-conventions.md
:white_check_mark:Succeeded
View

docs/cloud-adoption/_images/enterprise-cloud-adoption.png
:white_check_mark:Succeeded
View

docs/cloud-adoption/appendix/azure-scaffold-examples.md
:white_check_mark:Succeeded
View

docs/cloud-adoption/appendix/azure-scaffold.md
:white_check_mark:Succeeded
View

docs/cloud-adoption/appendix/index.md
:white_check_mark:Succeeded
View

docs/cloud-adoption/getting-started/azure-resource-access.md
:white_check_mark:Succeeded
View

docs/cloud-adoption/getting-started/index.md
:white_check_mark:Succeeded
View

docs/cloud-adoption/getting-started/overview.md
:white_check_mark:Succeeded
View

docs/cloud-adoption/getting-started/what-is-azure.md
:white_check_mark:Succeeded
View

docs/cloud-adoption/getting-started/what-is-governance.md
:white_check_mark:Succeeded
View

docs/cloud-adoption/governance/governance-multiple-teams.md
:white_check_mark:Succeeded
View

docs/cloud-adoption/governance/governance-single-team.md
:white_check_mark:Succeeded
View

docs/cloud-adoption/governance/index.md
:white_check_mark:Succeeded
View

docs/cloud-adoption/governance/overview.md
:white_check_mark:Succeeded
View

docs/cloud-adoption/index.md
:white_check_mark:Succeeded
View

docs/cloud-adoption/infrastructure/basic-workload.md
:white_check_mark:Succeeded
View

docs/cloud-adoption/infrastructure/index.md
:white_check_mark:Succeeded
View

docs/toc.yml
:white_check_mark:Succeeded
View

docs/vdc/networking-virtual-datacenter.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

.openpublishing.redirection.json
:white_check_mark:Succeeded

docs/_bread/toc.yml
:white_check_mark:Succeeded

docs/best-practices/naming-conventions.md
:white_check_mark:Succeeded
View

docs/cloud-adoption/appendix/azure-scaffold-examples.md
:white_check_mark:Succeeded
View

docs/cloud-adoption/appendix/azure-scaffold.md
:white_check_mark:Succeeded
View

docs/cloud-adoption/appendix/index.md
:white_check_mark:Succeeded
View

docs/cloud-adoption/getting-started/azure-resource-access.md
:white_check_mark:Succeeded
View

docs/cloud-adoption/getting-started/index.md
:white_check_mark:Succeeded
View

docs/cloud-adoption/getting-started/overview.md
:white_check_mark:Succeeded
View

docs/cloud-adoption/getting-started/what-is-azure.md
:white_check_mark:Succeeded
View

docs/cloud-adoption/getting-started/what-is-governance.md
:white_check_mark:Succeeded
View

docs/cloud-adoption/governance/governance-multiple-teams.md
:white_check_mark:Succeeded
View

docs/cloud-adoption/governance/governance-single-team.md
:white_check_mark:Succeeded
View

docs/cloud-adoption/governance/index.md
:white_check_mark:Succeeded
View

docs/cloud-adoption/governance/overview.md
:white_check_mark:Succeeded
View

docs/cloud-adoption/index.md
:white_check_mark:Succeeded
View

docs/cloud-adoption/infrastructure/basic-workload.md
:white_check_mark:Succeeded
View

docs/cloud-adoption/infrastructure/index.md
:white_check_mark:Succeeded
View

docs/cloud-adoption/overview.md
:white_check_mark:Succeeded
View

docs/toc.yml
:white_check_mark:Succeeded
View

docs/vdc/networking-virtual-datacenter.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

.openpublishing.redirection.json
:white_check_mark:Succeeded

docs/_bread/toc.yml
:white_check_mark:Succeeded

docs/best-practices/naming-conventions.md
:white_check_mark:Succeeded
View

docs/cloud-adoption/appendix/azure-scaffold-examples.md
:white_check_mark:Succeeded
View

docs/cloud-adoption/appendix/azure-scaffold.md
:white_check_mark:Succeeded
View

docs/cloud-adoption/appendix/index.md
:white_check_mark:Succeeded
View

docs/cloud-adoption/getting-started/azure-resource-access.md
:white_check_mark:Succeeded
View

docs/cloud-adoption/getting-started/index.md
:white_check_mark:Succeeded
View

docs/cloud-adoption/getting-started/overview.md
:white_check_mark:Succeeded
View

docs/cloud-adoption/getting-started/what-is-azure.md
:white_check_mark:Succeeded
View

docs/cloud-adoption/getting-started/what-is-governance.md
:white_check_mark:Succeeded
View

docs/cloud-adoption/governance/governance-multiple-teams.md
:white_check_mark:Succeeded
View

docs/cloud-adoption/governance/governance-single-team.md
:white_check_mark:Succeeded
View

docs/cloud-adoption/governance/index.md
:white_check_mark:Succeeded
View

docs/cloud-adoption/governance/overview.md
:white_check_mark:Succeeded
View

docs/cloud-adoption/index.md
:white_check_mark:Succeeded
View

docs/cloud-adoption/infrastructure/basic-workload.md
:white_check_mark:Succeeded
View

docs/cloud-adoption/infrastructure/index.md
:white_check_mark:Succeeded
View

docs/cloud-adoption/overview.md
:white_check_mark:Succeeded
View

docs/toc.yml
:white_check_mark:Succeeded
View

docs/vdc/networking-virtual-datacenter.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

.openpublishing.redirection.json
:white_check_mark:Succeeded

docs/_bread/toc.yml
:white_check_mark:Succeeded

docs/best-practices/naming-conventions.md
:white_check_mark:Succeeded
View

docs/cloud-adoption/appendix/azure-scaffold-examples.md
:white_check_mark:Succeeded
View

docs/cloud-adoption/appendix/azure-scaffold.md
:white_check_mark:Succeeded
View

docs/cloud-adoption/appendix/index.md
:white_check_mark:Succeeded
View

docs/cloud-adoption/getting-started/azure-resource-access.md
:white_check_mark:Succeeded
View

docs/cloud-adoption/getting-started/index.md
:white_check_mark:Succeeded
View

docs/cloud-adoption/getting-started/overview.md
:white_check_mark:Succeeded
View

docs/cloud-adoption/getting-started/what-is-azure.md
:white_check_mark:Succeeded
View

docs/cloud-adoption/getting-started/what-is-governance.md
:white_check_mark:Succeeded
View

docs/cloud-adoption/governance/governance-multiple-teams.md
:white_check_mark:Succeeded
View

docs/cloud-adoption/governance/governance-single-team.md
:white_check_mark:Succeeded
View

docs/cloud-adoption/governance/index.md
:white_check_mark:Succeeded
View

docs/cloud-adoption/governance/overview.md
:white_check_mark:Succeeded
View

docs/cloud-adoption/index.md
:white_check_mark:Succeeded
View

docs/cloud-adoption/infrastructure/basic-workload.md
:white_check_mark:Succeeded
View

docs/cloud-adoption/infrastructure/index.md
:white_check_mark:Succeeded
View

docs/cloud-adoption/overview.md
:white_check_mark:Succeeded
View

docs/toc.yml
:white_check_mark:Succeeded
View

docs/vdc/networking-virtual-datacenter.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


osbuilder fails randomly in the CI

Removing intermediate container 52e72aea5ba5
 ---> 09c8858e7d70
Successfully built 09c8858e7d70
Successfully tagged image-builder-osbuilder:latest
[OK] init is installed
[OK] init is systemd
[OK] Agent installed
INFO: Create root disk image. Attempt 1 out of 5.
INFO: Creating raw disk with size 126M
[OK] Image file created
INFO: Creating partitions
Model:  (file)
Disk /image/kata-containers.img: 132MB
Sector size (logical/physical): 512B/512B
Partition Table: gpt
Disk Flags:

Number  Start   End    Size   File system  Name     Flags
 1      1049kB  131MB  130MB  ext4         primary

[OK] Partitions created
/dev/loop0: gpt partitions 1
INFO: Formatting Image using ext4 filesystem
The file /dev/loop0p1 does not exist and no size was specified.
Failed at 121: sudo -E AGENT_INIT="${AGENT_INIT}" USE_DOCKER=true ./image-builder/image_builder.sh "$ROOTFS_DIR"
Build step 'Execute shell' marked build as failure
Performing Post build task...
Match found for :.* : True
Logical operation result is TRUE
Running script  : #!/bin/bash

export GOPATH=$WORKSPACE/go
export GOROOT="/usr/local/go"
export PATH=${GOPATH}/bin:/usr/local/go/bin:/usr/sbin:/usr/local/bin:${PATH}

cd $GOPATH/src/github.com/kata-containers/tests
.ci/teardown.sh "$WORKSPACE/artifacts"

fixed https://github.com/kata-containers/osbuilder/pull/264


datepicker does not work with model getter/setter

I try to use datepicker in that way:
<datepicker ng-model="model.fromDate" ng-model-options="{ getterSetter: true }" ></datepicker>
having $scope.model.fromDate = function(value) {};
I got error like this:
Datepicker directive: "ng-model" value must be a Date object, a number of milliseconds since 01.01.1970 or a string representing an RFC2822 or ISO 8601 date.
datepicker directive should allow model to be getter/setter function

Even if you use getter/setter you somehow need a date. So $scope.model.fromDate = function(value) {}; does not return a date. Have you tried e.g. $scope.model.fromDate = function(value) {return new Date()}; ?

But there is another problem which prevents gettersetter from working correctly:
If a user inputs a date, but the date is not valid (yet), then the date formatter will parse the value to undefined:
https://github.com/angular-ui/bootstrap/blob/82cb637dd12288d9fa0d42783f672fc71b94ffda/src/datepicker/datepicker.js#L562
https://github.com/angular-ui/bootstrap/blob/82cb637dd12288d9fa0d42783f672fc71b94ffda/src/datepicker/datepicker.js#L567
That is a problem, because the angular example on how to implement setter/getter:
https://docs.angularjs.org/api/ng/directive/ngModelOptions
forsees the usage of undefined to determine whether the value is being set or only get. Thus the example setter/getter looks like this:
function(newValue) {
  return angular.isDefined(newValue) ? (value = newValue) : value;
}

The problem now is that the datepicker tries to /set/ the value to undefined which does not work. Thus the date field retains it's original value and cannot assume (not even temporarily) an empty value.
I tried replacing undefined with null in the two locations linked above and then everything looks fine.

I have the same issue with typeahead.

Closing in favor of #4837.


Celo rosetta node issue

The celo rosetta node had stopped, when we tried starting it again  getting the below error. Could you please help resolve this
Executing: /usr/local/bin/geth --datadir /data/celo --nousb --http --http.addr localhost --http.port 8545 --http.vhosts localhost --syncmode full --gcmode archive --http.api eth,net,web3,debug,admin,personal --ipcpath /var/geth.ipc --light.serve 0 --light.maxpeers 0 --maxpeers 1100 --consoleformat term --txlookuplimit 0 --port 30303 --verbosity 3 --cache 1024 ERROR[01-19|13:24:35.751] Rosetta run failed                       err="Geth service did not create ipc file within deadline, check the log: /logs/celo.log"
@eelanagaraj : Could you please help us with the above issue

Looks like rosetta isn't able to start geth. Does the mentioned log file show why?

Did you encounter any issues with the node before?
This seems like an issue with the blockchain client, moving it over to the respective repo.


Added some additional info for the PoE devices

The GIF seems to have its aspect ratio changed (too slim)

the gif is ~17MiB, try reducing it a bit, to load faster

Agreed on the aspect ratio on the GIF.
Also to reduce the size of the GIF, I think we can trim off the front of the video and the end of the video, to only really show just initially holding it, going directly to plugging in, and then once it starts blinking cut there, or shortly after where it "feels right".
Not sure if there are other ways (other than temporal) to make the GIF smaller as well?  @VanDavv has a GIF tool he likes.

I use https://ezgif.com/ for all my gif works and it's great

Thanks Lukasz for the app, wasn't aware of it, it's great! Resized gif to 50%, it's less than 10MB now so it can be hosted on github as well

Thanks, @Erol444. I've linked this guide to hardware docs, too (OAK-1-POE and OAK-D-POE).


Fix material button for riot v3

Need some checks.
Working on this

@Joxit It seems that it is ok

@kysonic Ok, thank you :smile:


Don't crash on the cli

Fixes the graphene-cli so it doesn't crash when used. It currently doesn't seem to do anything other than loop forever.

The endless loop is intentional, when executed with a matching graaphite document, it should create a new window with the render result of the node graph


Allow setStory to take object as parameters(?)

This is spawned from my orginal idea over here, https://github.com/mgp25/Snap-API/issues/73
What I want to achieve is an automated bot that receives snaps and re-posts them on its story directly
My basic code wich I want to achieve this with is;
$snapchat = new Snapchat($username, $gEmail, $gPasswd, $debug);
$snapchat->login($password);

$snaps = $snapchat->getSnaps();

if (!is_null($snaps))
{
    foreach($snaps as $snap)
        //echo $snap->id;
        $snapchat->setStory($snapchat->getMedia($snap->id), $snap->time);
        $snapchat->markSnapViewed($snap->id);
}

$snapchat->closeAppEvent();

Now obviously this fails as setStory() only handles file objects. So with that in mind I'm requesting support for the above :-) (I hope you get what I mean)
PS: It fails with the following msg:
PHP Warning:  finfo_file(▒▒▒▒): failed to open stream: No such file or directory in /opt/Snap-API/src/snapchat.php on line 2179
PHP Warning:  file_get_contents() expects parameter 1 to be a valid path, string given in /opt/Snap-API/src/snapchat.php on line 2196
PHP Notice:  Undefined variable: type in /opt/Snap-API/src/snapchat.php on line 2226

Oh and btw, how does one mark a snap as "viewed" so that above wont post the snap to story again?

Ok so I solved this without doing it the way I intended to, perhaps people might be interested in the final piece
// Login

$tmpPath = '/tmp/';
$snapchat = new Snapchat($username, $gEmail, $gPasswd, $debug);
$snapchat->login($password);

$snaps = $snapchat->getSnaps();

if (!is_null($snaps))
{
    //print_r($snaps);
    foreach($snaps as $snap)
    {
        echo "Processing " . $snap->id . "\n";
        $tmpFilePath = $tmpPath . $snap->id;

        file_put_contents($tmpFilePath, $snapchat->getMedia($snap->id));
        $snapchat->setStory($tmpFilePath, $snap->time);
        $snapchat->markSnapViewed($snap->id);
        unlink($tmpFilePath);
    }
}

$snapchat->closeAppEvent();

@mgp25
I'd like to make use of

auth-.dat

Would you mind giving me an example on how I can do that? I understand that I need to make use of

$snapchat->openAppEvent();

The wiki nor examples gives much details into this

@jkaberg we have to fix that, because the lasts commits broke the reuse of the auth

@mgp25 yes, I see
But once your done fixing it, would you mind giving an example on how to use it?

http://www.github.com/sallaben/storybot PLEASE help me out with this.. I'm
willing to rewrite the entire thing with you but I already have a dedicated
community and several accounts with thousands of followers to test this on.
On Thu, May 7, 2015 at 9:16 AM, Joel Kåberg<EMAIL_ADDRESS>wrote:

This is spawned from my orginal idea over here, #73
https://github.com/mgp25/Snap-API/issues/73
What I want to achieve is an automated bot that receives snaps and
re-posts them on its story directly
My basic code wich I want to achieve this with is;
$snapchat = new Snapchat($username, $gEmail, $gPasswd, $debug);
$snapchat->login($password);
$snaps = $snapchat->getSnaps();
if (!is_null($snaps))
{
foreach($snaps as $snap)
//echo $snap->id;
$snapchat->setStory($snapchat->getMedia($snap->id), $snap->time);
}
$snapchat->closeAppEvent();
Now obviously this fails as setStory() only handles file objects. So with
that in mind I'm requesting support for the above :-) (I hope you get what
I mean)
—
Reply to this email directly or view it on GitHub
https://github.com/mgp25/Snap-API/issues/117.

Basically I've done what you're trying to do already, although pretty
sloppily. I would like you to help me make it better! Thanks :)
On Thu, May 7, 2015 at 7:58 PM, Steve Allaben<EMAIL_ADDRESS>wrote:

http://www.github.com/sallaben/storybot PLEASE help me out with this..
I'm willing to rewrite the entire thing with you but I already have a
dedicated community and several accounts with thousands of followers to
test this on.
On Thu, May 7, 2015 at 9:16 AM, Joel Kåberg<EMAIL_ADDRESS>wrote:

This is spawned from my orginal idea over here, #73
https://github.com/mgp25/Snap-API/issues/73
What I want to achieve is an automated bot that receives snaps and
re-posts them on its story directly
My basic code wich I want to achieve this with is;
$snapchat = new Snapchat($username, $gEmail, $gPasswd, $debug);
$snapchat->login($password);
$snaps = $snapchat->getSnaps();
if (!is_null($snaps))
{
foreach($snaps as $snap)
//echo $snap->id;
$snapchat->setStory($snapchat->getMedia($snap->id), $snap->time);
}
$snapchat->closeAppEvent();
Now obviously this fails as setStory() only handles file objects. So with
that in mind I'm requesting support for the above :-) (I hope you get what
I mean)
—
Reply to this email directly or view it on GitHub
https://github.com/mgp25/Snap-API/issues/117.

@sallaben This script does that,
https://github.com/mgp25/Snap-API/issues/117#issuecomment-99879561


Request for adding OCR to text extractor in PowerToys

Description of the new feature / enhancement
Can select handwritten text in images and text of other languages as well.
Scenario when this would be used?
Can be very useful for selecting handwritten text in images.
Supporting information
No response

The text extractor is already using OCR, currently the OCR is done by the Windows API.


Add favorite addresses feature

Closes #1006

note: I'm pretty sure this functionality would benefit from the labelling/tagging infrastructure we are doing, although it may not be saved in the same shareable place, so I would focus on doing that first, then we revisit/rebase this UI on top of that.


Can't start

I got a Problem with the MagicMirror...
Since this morning i cant start the MagicMirror (npm start). I was able to start it a few days ago.

for support, please check https://forum.magicmirror.builders
This topic might be of interest: https://forum.magicmirror.builders/topic/647/complete-setup-tutorial-npm-command-not-found-unable-to-install-dependencies


Help needed: "ReferenceError: sonar is not defined" error

I put exactly the same code for sonar task in my gulpfile.js file:
gulp.task('sonar', function () {
    var options = {
        sonar: {
            host: {
                url: 'http://localhost:9000'
            },
            projectKey: 'conn-ui',
            projectName: 'Conn App UI',
            //projectVersion: '1.0.0',
            // comma-delimited string of source directories
            sources: 'app/js,app/lib',
            language: 'js',
            sourceEncoding: 'UTF-8',
            javascript: {
                lcov: {
                    reportPath: 'test/sonar_report/lcov.info'
                }
            },
            exec: {
                // All these properties will be send to the child_process.exec method (see: https://nodejs.org/api/child_process.html#child_process_child_process_exec_command_options_callback )
                // Increase the amount of data allowed on stdout or stderr (if this value is exceeded then the child process is killed, and the gulp-sonar will fail).
                maxBuffer : 1024*1024
            }
        }
    };

    // gulp source doesn't matter, all files are referenced in options object above
    return gulp.src('thisFileDoesNotExist.js', { read: false })
        .pipe(sonar(options))
        .on('error', util.log);
});

However I always get the following error messages when I invoke gulp sonar command:
using args { _: [ 'sonar' ], env: 'local-java', e: 'local-java' }
[15:36:54] Using gulpfile ~/p/conn/ui/app/gulpfile.js
[15:36:54] Starting 'sonar'...
[15:36:54] 'sonar' errored after 7.8 ms
[15:36:54] ReferenceError: sonar is not defined
    at Gulp.<anonymous> (/home/luog/p/conn/ui/app/gulpfile.js:495:15)
    at module.exports (/home/luog/p/conn/ui/app/node_modules/orchestrator/lib/runTask.js:34:7)
    at Gulp.Orchestrator._runTask (/home/luog/p/conn/ui/app/node_modules/orchestrator/index.js:273:3)
    at Gulp.Orchestrator._runStep (/home/luog/p/conn/ui/app/node_modules/orchestrator/index.js:214:10)
    at Gulp.Orchestrator.start (/home/luog/p/conn/ui/app/node_modules/orchestrator/index.js:134:8)
    at /usr/lib/node_modules/gulp/bin/gulp.js:129:20
    at _combinedTickCallback (internal/process/next_tick.js:67:7)
    at process._tickCallback (internal/process/next_tick.js:98:9)
    at Function.Module.runMain (module.js:449:11)
    at startup (node.js:148:18)
    at node.js:405:3

Do you know where I am wrong?

Do you have var sonar = require('sonar'); at the top of your gulpfile.js?

yep I noticed that and problem resolved


Hover doesn't work on GUIs in XR mode

Bugs
Repro playground: https://playground.babylonjs.com/#AM07G2#49
In the playground, hover over the "Click me" button with a mouse. You'll see that on pointer enter, its colors change, and on pointer out, they change back.
Now do the same thing with a controller in XR mode. Pointer enter/out doesn't seem to register, but if you click the button (by pulling the trigger), it will change colors. This is unexpected.

Yeah, for some reason I decided that pointer move should only trigger between pointer down and up. I will add a constant pointer move event


Set offset in time graph unit controller

This allows it to create gridlines on rounded absolute times.
Signed-off-by: Patrick Tasse<EMAIL_ADDRESS>

Requires https://github.com/theia-ide/timeline-chart/pull/172
Fixes https://github.com/theia-ide/timeline-chart/issues/54

Before and after fix:


ok

OPS Build status updates of commit d3baa43:
:clock10: Preparing: average preparing time is 1 min(s) 12 sec(s)

OPS Build status updates of commit d3baa43:
:clock10: Incremental building: average incremental building time is 12 min(s) 23 sec(s)

OPS Build status updates of commit d3baa43:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

skype/skype-ps/skype/Grant-CsVoicePolicy.md
:white_check_mark:Succeeded
View (skype-ps)

skype/skype-ps/skype/Remove-CsVoicePolicy.md
:white_check_mark:Succeeded
View (skype-ps)

skype/skype-ps/skype/Set-CsUserServicesPolicy.md
:white_check_mark:Succeeded
View (skype-ps)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

OPS Build status updates of commit 72db997:
:clock10: Preparing: average preparing time is 1 min(s) 12 sec(s)

OPS Build status updates of commit 72db997:
:clock10: Incremental building: average incremental building time is 12 min(s) 23 sec(s)

OPS Build status updates of commit 72db997:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

skype/skype-ps/skype/Grant-CsVoicePolicy.md
:white_check_mark:Succeeded
View (skype-ps)

skype/skype-ps/skype/Remove-CsVoicePolicy.md
:white_check_mark:Succeeded
View (skype-ps)

skype/skype-ps/skype/Set-CsUserServicesPolicy.md
:white_check_mark:Succeeded
View (skype-ps)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Unable to delete commonservice CR due to the existence of finalizer

When I try to uninstall the Common Service, the CR commonservice in cs-operator cannot be deleted because there exists finalizer.
Need to use patching to remove finalizer
/cc @horis233

The finalizer is added for updating the size from the OperandConfig when the common service CR is deleted.
We can think of another way to avoid using the finalizer.
For example, if the instance from the request can't be found, the update the size from the OperandConfig by others OperandRequests.

The finalizer is added for updating the size from the OperandConfig when the common service CR is deleted.
We can think of another way to avoid using the finalizer.
For example, if the instance from the request can't be found, the update the size from the OperandConfig by others OperandRequests.


Extending mail capabilities

Pull Request (PR) description
Emails openvpn configuration to specified user(s).

HI @antgel, thanks for this PR. I'm not sure if this is a good approach. Do we really need a python script to send out emails? Mail handling is a very very complicated topic because almost each environment is different.  It's maybe the best idea to realize mail handling with a dedicated module. I'm open for opinions from our @voxpupuli/collaborators here.

I'd think this sort of code belongs in the manifests for a given infrastructure instead of the module here.  In my opinion, this makes too many assumptions to be useful generally, and strays away from the core of the module's primary purpose.  The exec here could still subscribe the resources in the module, but not need to be included with this project.

Agree with @bastelfreak and @xaque208 here

Hi all, thanks for the feedback. @shapi78 wrote this, because it fits an internal need. We wanted to send it upstream to give back - perhaps we should have consulted before hacking away. I can't see us having time to devote to a significant refactor, so should I close this?

With PR as this :

to install python on node becomes mandatory . Python is not installed on supported OSes by default.
to receive mail is mandatory. I expect a switch true/false to define behaviour.
to use localhost as smtp relay is mandatory. I expect a parameter.

In my point of view,  3 locking points that should be resolved.

@antgel I am not opposed to merging this functionality with the python script if it's documented in the README that python is required and that you make the other smaller changes I noted. It can be changed to be more portable later if that's required, most likely without affecting existing users.

I still think that this, in the current implementation, is way to site-specific and should be handled in a profile.


cluster: use latest staged images

ad991b7 disabled image pull because that pointed to release images and often times they had conflicts with local files in the repository.
As we now have staged images published on merge, we can try pulling images without forcing local builds (or local .yml editing).
Also, Compose warns about 'version' being obsolete so drop that too, while we're at it.

docker compose build remains the option for local builds still. With this, there's flexibility to choose how images are prepared without having to edit the compose file.


Fix alignment and opacity of "No Media Found" Message

Bug Description
“No media found” should be aligned to the centered and have opacity.
Figma
Acceptance Criteria

opacity: 0.54
Message is centred per Figma

See comments for conversation on: If there are no results, do not show the upload button or the media types
Steps to Reproduce

yield no results by using the search in the media library
note message for "no media found"

Screenshots

Do not alter or remove anything below. The following sections will be managed by moderators only.
QA Instructions

Is there a Figma link for this?

“No media found” should be aligned to the centered and have opacity.

How much opacity? Things like that need to be specified.

If there are no results, do not show the upload button or the media types

Not showing the media types is odd. What if I am currently filtering by videos and wanna search for videos only? Then when I don't find any videos I might wanna switch to "All".
Related: #1844
Second, not showing the upload button is odd too. Let's say I search for a specific media item, but I don't find it, so I wanna upload a new one. Why hide the button?

Agree that hiding the filters and upload option seems odd. Would prioritize styling the message appropriately, but let's reconsider hiding things.

Add some details and Figma link to ticket

@swissspidy

If your results yield a result, the media type is there (so not sure what you're looking at).
With the media integration work, we're redoing the entire media panel and moving upload to their section so don't worry about the upload button. Will take your point into consideration
The Figma file is in the bug description :) but #FFF at 54%

Appears to already be completed:


Activation steps link in the Github repo readme is broken

Describe the bug: (a clear and concise description of what the bug is)
The activation steps link in the Github repo readme is broken.
[activation steps](https://otomi.io/docs/installation/activation/).

Correct link should be https://otomi.io/docs/get-started/activation/

Thanks for pointing that out. We recently did some updates on the docs in otomi.io. You can find the activation steps here: https://otomi.io/docs/get-started/activation

fixed!