HBASE-25569 Adding region count and average region size in a table at…

… regionserver level

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
7m  0s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 2 new or modified test files.

_ branch-1 Compile Tests _

+0 :ok:
mvndep
2m 24s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
8m  0s
branch-1 passed

+1 :green_heart:
compile
1m 12s
branch-1 passed with JDK Azul Systems, Inc.-1.8.0_262-b19

+1 :green_heart:
compile
1m 22s
branch-1 passed with JDK Azul Systems, Inc.-1.7.0_272-b10

+1 :green_heart:
checkstyle
2m  7s
branch-1 passed

+1 :green_heart:
shadedjars
3m  1s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 10s
branch-1 passed with JDK Azul Systems, Inc.-1.8.0_262-b19

+1 :green_heart:
javadoc
1m 17s
branch-1 passed with JDK Azul Systems, Inc.-1.7.0_272-b10

+0 :ok:
spotbugs
2m 47s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
4m 11s
branch-1 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 17s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m 57s
the patch passed

+1 :green_heart:
compile
1m 12s
the patch passed with JDK Azul Systems, Inc.-1.8.0_262-b19

+1 :green_heart:
javac
1m 12s
the patch passed

+1 :green_heart:
compile
1m 21s
the patch passed with JDK Azul Systems, Inc.-1.7.0_272-b10

+1 :green_heart:
javac
1m 21s
the patch passed

+1 :green_heart:
checkstyle
0m 14s
The patch passed checkstyle in hbase-hadoop-compat

+1 :green_heart:
checkstyle
0m 15s
The patch passed checkstyle in hbase-hadoop2-compat

+1 :green_heart:
checkstyle
1m 33s
hbase-server: The patch generated 0 new + 4 unchanged - 16 fixed = 4 total (was 20)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedjars
2m 54s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
hadoopcheck
4m 41s
Patch does not cause any errors with Hadoop 2.8.5 2.9.2.

+1 :green_heart:
javadoc
1m  1s
the patch passed with JDK Azul Systems, Inc.-1.8.0_262-b19

+1 :green_heart:
javadoc
1m 15s
the patch passed with JDK Azul Systems, Inc.-1.7.0_272-b10

+1 :green_heart:
findbugs
4m 25s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
0m 28s
hbase-hadoop-compat in the patch passed.

+1 :green_heart:
unit
0m 39s
hbase-hadoop2-compat in the patch passed.

+1 :green_heart:
unit
107m  7s
hbase-server in the patch passed.

+1 :green_heart:
asflicense
1m 16s
The patch does not generate ASF License warnings.

166m 39s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2948/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2948

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux 44bf70831ff2 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-home/workspace/Base-PreCommit-GitHub-PR_PR-2948/out/precommit/personality/provided.sh

git revision
branch-1 / 7d80d99

Default Java
Azul Systems, Inc.-1.7.0_272-b10

Multi-JDK versions
/usr/lib/jvm/zulu-8-amd64:Azul Systems, Inc.-1.8.0_262-b19 /usr/lib/jvm/zulu-7-amd64:Azul Systems, Inc.-1.7.0_272-b10

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2948/1/testReport/

Max. process+thread count
3754 (vs. ulimit of 10000)

modules
C: hbase-hadoop-compat hbase-hadoop2-compat hbase-server U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2948/1/console

versions
git=1.9.1 maven=3.0.5 findbugs=3.0.1

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.


Upgrade to later rust min version, revert MaybeUninit workaround

This is a placeholder for future updates.
We introduced a workaround for MaybeUninit changes discussed in #101 . This currently only affects those using older versions of rust.
wiki reference, placeholder

the new version of pkg-config - v0.3.15 .. is triggering build errors on rust 1.24.1
additionally  pkg-config list v1.28+ as minimum supported version, might need to bump up minimum version  before releasing an updated crate
Build fails for version 1.24.1, works for nightly + stable

@erlepereira there is no need to bump the MSRV because of dependencies. All you need to do is pin the version in travis.yml. I've made a PR to do this here: #103
Also yes, eventually the maybe-uninit dependency should be removed as the MSRV is bumped but that shouldn't happen soon IMO but maybe in 6 months or so (ultimately it's your choice ofc).


Labels are not rounded

I'm submitting a ...
[x ] bug report
[ ] feature request
[ ] question about the decisions made in the repository

Do you want to request a feature or report a bug?
Bug

What is the current behavior?
class="label" => labels are not rounded

If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem via
https://plnkr.co or similar (you can use this template as a starting point: http://plnkr.co/edit/tpl:AvJOMERrnz94ekVua0u5).

http://plnkr.co/edit/InhM9Q47cFvgYYbb3C8O

What is the expected behavior?

Labels should be rounded

What is the motivation / use case for changing the behavior?

They are not rounded and the visual effect is quite ugly.

Please tell us about your environment:

Angular version: 4.1.3
Browser: [ Chrome 59 ]
Macbook Air 10.9.5

Other information (e.g. detailed explanation, stacktraces, related issues, suggestions how to fix, links for us to have context, eg. stackoverflow, gitter, etc)

Don't know how to fix it.

Please provide more details!

Standard bootstrap labels (e.g class="label label-default") should have rounded corners.
When I use them in akveo/ng2-admin corners appear sharp, a bit ugly.
Don't know how else to explain, sorry.

A screenshot of the expected state would help. Its probably just cause of a missing bootstrap theme css. From what I see they are rounded.

Hi,
Thanks for your reply.
I already did. The plnkr example I linked in my original comment is the expected result (boostrap standard).
I can give you a screenshot of what I see when using labels in ng2-admin:

html I'm using is:
<span *ngFor="let label of entry.labels" class="label {{label.className}}">
{{label.text}}

where label.className could be "label-success", "label-danger" or "label-warning".
Thanks.

Probably its an npm problem
Can you please follow these steps :

make sure your project is updated (Pull sources from ng2-admin git repository git, merge accordingly)
delete node_modules directory
rm -rf node_modules
clear npm cache
npm cache clean
set npm registry
npm config set registy "http://registry.npmjs.org/"
update npm
sudo npm install npm -g
install npm dependencies
npm install

I've gone through that procedure twice, still no joy.

@pulfabio If you have this problem just with the label elements don´t worry to much and add this piece as your custom css. If I see it on plunkr right it just adds:
border: 1px solid #fbeed5;
-webkit-border-radius: 4px;
-moz-border-radius: 4px;
border-radius: 4px;
so add a custom class e.g customLabel and define it in your css.
I´m pretty sure label gets somethere in ng overwritten or the bootstrap theme doesn´t even get loaded. I tried it by my own and had no style at all :)

@darklinki You got it! That css works, thanks. I just removed the border, which I don't like.


OS-35813 -

For better performance we need access to cache to avoide calling get function as intercepted for the playback

I don't understand what your change impact is, it looks equivalent to me to the code without the change

I don't understand what your change impact is, it looks equivalent to me to the code without the change

The purpose is exposing the cache without exposing the private member of the class


Hotfix/v1.0.2: Hotfix in Development

Title: Hotfix in Development
[P.S]
  - Updated the Readme File
  - Updated the init_delete.sh
  - Updated the init.sh file
  - Added the resources for KMS
  - Fixed the domain issue

:robot: OpenAI

Chat with 🤖 OpenAI Bot (@openai)

Reply on review comments left by this bot to ask follow-up questions. A review comment is a comment on a diff or a file.
Invite the bot into a review comment chain by tagging @openai in a reply.

Code suggestions

The bot may make code suggestions, but please review them carefully before committing since the line number ranges may be misaligned.
You can edit the comment made by the bot and manually tweak the suggestion if it is slightly off.

Ignoring further reviews

Type @openai: ignore anywhere in the PR description to ignore further reviews from the bot.

Files not summarized due to errors (15)
Failed to summarize

CHANGELOG.md (nothing obtained from openai)
ROADMAP.md (nothing obtained from openai)
infrastructure/init.sh (nothing obtained from openai)
README.md (nothing obtained from openai)
infrastructure/modules/serverless/cloudtrail.tf (nothing obtained from openai)
infrastructure/modules/serverless/data.tf (nothing obtained from openai)
infrastructure/init_delete.sh (nothing obtained from openai)
infrastructure/main.tf (nothing obtained from openai)
infrastructure/modules/serverless/variables.tf (nothing obtained from openai)
infrastructure/modules/xc3/data.tf (nothing obtained from openai)
infrastructure/modules/xc3/loadbalancer.tf (nothing obtained from openai)
infrastructure/modules/xc3/startup-script.sh.tpl (nothing obtained from openai)
infrastructure/terraform.auto.tfvars (nothing obtained from openai)
infrastructure/modules/xc3/variables.tf (nothing obtained from openai)
infrastructure/variables.tf (nothing obtained from openai)

In the recent run, only the files that changed from the base of the PR and between cfb275065175d9813291fb636c958118f7a80ed7 and 5de1973b62b3a9856257c8a50e10798777eae26f commits were reviewed.


add break-* properties

This feature is needed for https://github.com/jonathantneal/postcss-preset-env/issues/11
Please review it:

I'm not sure that I choose correct specificationId. Because it includes break-between and break-within and not includes widows-orphans
I'm not sure which caniuse feature chose. There are multicolumn and css-page-break and they both partially covers break-

Great work!
Your question about the specification id is perfectly timed. I just finished having a discussion with the CSSWG about these specification IDs, because I had my own concerns about their lack of consistency. https://github.com/w3c/csswg-drafts/issues/2255
Based on that conversation, in 2.0.0 I will switch to a new ID scheme that is based on the markup instead of the feature section. Features like the one you’ve PR’d are exactly why it’s better to not follow the section id pattern. So, for this feature, I will rename the id break-properties.
FWIW, in progress work of new IDs:
https://github.com/jonathantneal/css-db/blob/feature/2.0.0/cssdb.json


Build for Linux

Request for this to work in Linux on a Pi - I'm guessing build in this.. https://www.electronforge.io/config/makers/snapcraft

Nb. Now done ref https://github.com/AceCentre/EyeCommander/commit/d5f794e1947ecf62fc6396ad176aa2bb20d55513 just needs testing


solc: 0.8.13 -> 0.8.19

Description of changes
Latest upstream release, including many security fixes.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 219240 run on x86_64-linux 1

1 package built:

solc

Fixes #182498

Fixes #122568

Testing still fails with ModuleNotFoundError: No module named 'requests' on linux

Testing still fails with ModuleNotFoundError: No module named 'requests' on linux

Weird. It passed for me locally. I rebased to latest master in case it helps.

Aha, I need to tweak the python3 in nativeCheckInputs to add some python packages so solc.passthru.tests will work, when solc without tests does work already. Will run the tests...

How with nix-shell do I retry the tests with additional dependencies without rebuilding everything from scratch every time I change something?

Latest issue: some tests really want to execute in a tty. How do I run them in a pty?
OK
Testing LSP...(B
Traceback (most recent call last):
  File "/build/source/./scripts/../test/lsp.py", line 31, in <module>
    tty.setcbreak(sys.stdin.fileno())
  File "/nix/store/0n4y44dnaxafqs7cg625aldrb152x7bx-python3-3.10.10/lib/python3.10/tty.py", line 32, in setcbreak
    mode = tcgetattr(fd)
termios.error: (25, 'Inappropriate ioctl for device')
error: builder for '/nix/store/l74pnb5kla4ivqdarbwahp6q6r0fcacn-solc-0.8.19.drv' failed with exit code 1;
       last 10 log lines:
       > Ran 77 tests in 0.018s
       >
       > OK
       > Testing LSP...(B
       > Traceback (most recent call last):
       >   File "/build/source/./scripts/../test/lsp.py", line 31, in <module>
       >     tty.setcbreak(sys.stdin.fileno())
       >   File "/nix/store/0n4y44dnaxafqs7cg625aldrb152x7bx-python3-3.10.10/lib/python3.10/tty.py", line 32, in setcbreak
       >     mode = tcgetattr(fd)
       > termios.error: (25, 'Inappropriate ioctl for device')
       For full logs, run 'nix log /nix/store/l74pnb5kla4ivqdarbwahp6q6r0fcacn-solc-0.8.19.drv'.

I managed to patch the python script so it avoids requiring a tty, and added a few more check dependencies.
It's now at the point where it wants evmone to compile, and as I read the documentation I see it wants hera, too. Sigh. That's a much taller order than fixing the immediate build.

Trying to add an evmone package to nixpkgs, and it's another exercise in yak shaving.

OK, I give up for now. Too many other more important things to do in my life and for my job.
The patch offered is not a regression. Obviously these tests have never worked in Nix. Getting them to work would be a couple few days of work for an engineer.

I punted and made this patch pass the tests by commenting out the invocation of the script that depends on evmone and more, with a TODO comment. This way, solc can fix the known build issues, and still run a lot of tests. Further fixing the tests will require a lot of work.

To upstream my patch to a solidity test: https://github.com/ethereum/solidity/pull/14057

Can we get this merged? The commented out test is not a regression.

Result of nixpkgs-review pr 219240 run on x86_64-linux 1

1 package built:

solc


docs: router

Codecov Report

Merging #304 (3268ac9) into docs-rework (e0b38ee) will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           docs-rework     #304   +/-   ##
============================================
  Coverage        77.80%   77.80%
============================================
  Files               52       52
  Lines             4673     4673
  Branches           552      552
============================================
  Hits              3636     3636
  Misses            1032     1032
  Partials             5        5

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0b38ee...3268ac9. Read the comment docs.


Registry not showing New User link

Description
The Registry installed on vistaar (https://registry-sandbox-vistaar.da.gov.in) is not showing the "I am a new user" link. This was similar on BOC and Prasad fixed it.
Outcome

Fix it on the VISTAAR Sandbox registry
Document the process to enable it in the registry documentation.

This is the intended screen:

This is how it shows currently:

New user link is up but image also needs to be fixed. Checking that.

New user link is working now thanks But login Page image is still pending any solutions for that
..

Login page is also visible now. Please do a hard refresh and check @PrasadAthani
@faizmagic @vbabuEM please close this ticket once confirmed

Thanks alot


[BUG] Error when creating VM: volumeAnnotationClaimTemplates annotation is invalid: unable to parse quantity's suffix

Describe the bug
When creating a VM with 3 disks - 1 image, 2 existing volumes - the error shown in the attached screenshot occurs.

To Reproduce
Steps to reproduce the behavior:

Go to 'Volumes'
Create volumes, one being 1024 GB in size.

Support bundle
Will be attached after creating the issue.
Environment

Harvester ISO version: 1.3.0
Underlying Infrastructure (e.g. Baremetal with Dell PowerEdge R630): HPE DL380 Gen9

Additional context
None.

@dg1sbg as a workaround until we fix this, you can go through the VM creation form again, and instead of clicking "Create", click "Edit as YAML", then ctrl+f "TiGi" and fix those instances to just "Ti" and then click "Create".

@connorkuehl sure - I succeeded in creating the VM as intended.
Thanks for this very prompt reaction and help!


Expose extract method

Fix #15

Codecov Report

Merging #16 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #16   +/-   ##
=======================================
  Coverage   91.44%   91.44%
=======================================
  Files          13       13
  Lines         538      538
=======================================
  Hits          492      492
  Misses         46       46

Impacted Files
Coverage Δ

Sources/Rainbow.swift
92.85% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e618dc...8c48c23. Read the comment docs.


Find better way to export and assign GPIO's.

Currently we assign GPIO and PWM pins in the setup_all.py script.
Daniel gives a good explanation of how it works in issue #291.
This method works so far, but there's always been some confusion because of the fact that you have to assign it in two places: in the config file and in the setup file.
Ideally, for the sake of clarity it would be something that you change once so that no one double assigns a signal.
This is the first time this has become a problem, because we've never had so many inputs and outputs going on at once before.
This can wait until SEcon for now, so I'm closing and shelving it until then.

Another thing the library isn't doing at all right now is changing the device tree overlay.
We've gotten incredibly lucky up until now because we've never had to do that.
I've created and configured a device tree overlay file on @SimonSaysServo branch, in /bot/setup/fs-common/root/startup/device_tree_overlay.dts
and it will have to be compiled manually with dtc -O dtb -o pinctrl-test-0-00A0.dtbo -b 0 -@ device_tree_overlay.dts

Ansible is a good tool to look into for this.
On Fri, May 8, 2015, 6:10 PM Ahmed Samara<EMAIL_ADDRESS>wrote:

Reopened #332 https://github.com/IEEERobotics/bot2014/issues/332.
—
Reply to this email directly or view it on GitHub
https://github.com/IEEERobotics/bot2014/issues/332#event-300664074.

This is being moved over to a wiki.

Has this been resolved? Why is this closed?
On May 30, 2015 9:01 PM, "jasteve4"<EMAIL_ADDRESS>wrote:

Closed #332 https://github.com/IEEERobotics/bot2014/issues/332.
—
Reply to this email directly or view it on GitHub
https://github.com/IEEERobotics/bot2014/issues/332#event-318005538.


Updated sample data in readme to show snake segments

This is just a thought to remind me (I'm happy to PR it shortly when I'm not doing other work):
The readme shows a sample game request, but each segment of the snake has the same coordinates. For new folks who are exploring this for the first time, it would probably help to show that those coordinates are actually different (and make up the segments of the snake).
I'm sure it was all just placeholder initially so someone just needs to update...

This is a great suggestion and definitely a welcome change for a PR @jem-swu!


Fix context menu transparency on Linux

@matikorzenio
Menu on Linux has got white background, but it should be transparent. Transparency works well in Electron 1.4.14, but in higher versions it doesn't work.

Should be fixed now right? Let's close this


how do I convert Google Docs to PDFs

Let's say I have a folder called SAMPLES in my google cloud drive which has microsoft word DOCX files. Can I download them as PDF onto my local hard drive with this program? If so what commands might I use.
:)

Hello there @nassausky, thank you for the question and welcome to drive!
Yes, you can do that, please take a look at the README, section https://github.com/odeke-em/drive#exporting-docs, there are a couple of examples.

Also btw, please note that the converting only works for Google Docs, Sheets and Presentations, so basically if you can't open the file in Google Docs/Sheets and convert it from there, you can't do it with this tool.

Hi and Thanks!
I saw the drive pull examples. the built in help says the pull command if for pulling 'remote changes' which I didn't think it was the right command but it seems maybe it will work .
My first attempt was just grabbing a folder
drive pull -directories /Samples -exports-dir ~/Desktop/exports
but I got an error
no drive context found; run "drive init" or go into one of the directories (sub directories) that you performed "drive init"
I did
drive pull -exports-dir ~/Desktop/exports
and that did grab all the files but not just the Samples folder which gave me the error.

Could you please give some more context to
I did drive pull -exports-dir ~/Desktop/exports and that did grab all the files but not just the Samples folder which gave me the error.
What's the error? What's the output? What were you trying to do?

Oh I'm sorry maybe you're confused.
I performed 2 separate actions.  The first error was stated above with my first action which tried to only get the /Samples folder.
My first attempt was just grabbing a folder
drive pull -directories /Samples -exports-dir ~/Desktop/exports
but I got an error
no drive context found; run "drive init" or go into one of the directories (sub directories) that you performed "drive init"
My second command did grab everything from the cloud onto my PC but it didn't put it in a folder called desktop/exports

Alright, so in order to use anything with drive, you'll need to first run drive init which is what drive was telling you with that response. init authorizes and gives drive to your account.

You can't convert Microsoft Docx directly to PDFs if you haven't made Google Docs, Sheets and Presentations from them. You'll need to first convert it to a Google Doc by opening it with Google Docs, as I had mentioned before in https://github.com/odeke-em/drive/issues/975#issuecomment-346875504. Unfortunately Google Drive itself doesn't have a way to convert them directly.

Wow you're very fast in responding. Thanks but you didn't read what I wrote.

I said I got it to work. Drive init is fine. The problem was when I tried to grab only the  /Samples folder.

Thanks again for explaining the PDF tip. Now I understand about that

Oh I read what you were saying :) "error 1" seemed to suggest a relation with not being able to export, hence I was clearing up that that's a disjoint event unrelated to what we were trying to solve, hence the bullet point :)
Ahaha I respond fast when I am in front of my computer, of which I am right now, good morning!
Alright, sounds good, thanks for the questions, please feel free to ask more and make suggestions.

Good morning I'm tired and the day has just begun,
Can you maybe explain this
drive pull -directories Samples -exports-dir exports
gives this error:
'/exports' aka 'D:\Cool\GoogleTools\Client\Installs\bin\~\gdrive/exports' doesn't exist locally nor remotely
Any idea?

Hmm Ok i'm making progress.
I realized that

The parameter -directories is boolean and doesn't accept the name of the directory(ies) that I would like to pull.  If you type drive at the command line the usage help just shows:
**Usage: drive <command>**
That doesn't say I should put a directory as a parameter but just shows a list of commands.
The parameter -exports-dir doesn't seem to work for a Windows PC.  Not important
Most important is that it still is not converting Google DOC files to PDF. I have a single sample google doc file and when it gets brought to my pc it's still in the google doc format. This is the command I used:
**drive pull -export pdf Samples**

Sad news, it's still not converting Google DOC files to PDF


Update end-user-support.md

couple changes here to align more with O365 support

@jdeckerms @lizap @DaniHalfin - Can you please assist to check, approve and merge the content of this PR?

@jdeckerms @lizap @DaniHalfin - I would like to follow up on this.  Can you please assist to check, approve and merge the content of this PR?
Thank you.


fix context reporting for relative_files

fix reporting of contexts when relative_files = True
fixes #900

Codecov Report

Merging #902 into master will decrease coverage by 0.03%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #902      +/-   ##
==========================================
- Coverage   94.19%   94.16%   -0.04%
==========================================
  Files          86       86
  Lines       11870    11887      +17
  Branches     1185     1188       +3
==========================================
+ Hits        11181    11193      +12
- Misses        560      566       +6
+ Partials      129      128       -1

Impacted Files
Coverage Δ

coverage/jsonreport.py
100% <100%> (ø)
:arrow_up:

tests/test_html.py
99.62% <100%> (ø)
:arrow_up:

tests/test_json.py
100% <100%> (ø)
:arrow_up:

coverage/html.py
100% <100%> (ø)
:arrow_up:

tests/test_debug.py
90.38% <0%> (-7.7%)
:arrow_down:

tests/test_arcs.py
100% <0%> (+1.11%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c09c2c2...b980a0a. Read the comment docs.


Complex NSObject

Thanks for sharing this! I found this awesome! :D
Anyway, I think I need more complex data to be store e.g.
Defaults["bar"] = NSKeyedArchiver.archivedDataWithRootObject([100:"foo", 2:"b", 3:["foo":"bar"]])
var bar: AnyObject? = NSKeyedUnarchiver.unarchiveObjectWithData(Defaults["bar"].data!)
println(bar)

It success but like you see, it would be nice if we make it shorter.
Feel free to close this btw, I just think out loud tho :D
Thanks!

I'm not familiar with using NSKeyedArchiver with NSUserDefaults — I'm not sure if it's a common pattern or not.
If it is, I'd be definitely happy to add a pair of helpers for writing/accessing archived objects to the user defaults.
If anyone is interested in this feature, please give your feedback below ☺

I agree with @katopz, I'm also using NSKeyedArchiver with NSUserDefaults in some cases, so in order to have a cleaner syntax to handle these too :)
So +1 for this

+1 from me as well
but should admit my usecase was a bit awkward: storing a UILocalNotification in user defaults (long story http://stackoverflow.com/questions/25948037/ios-8-uiapplication-sharedapplication-scheduledlocalnotifications-empty)

Cool. @pellekrogholt @tbaranes @katopz any specific suggestions as for the API you'd like to see for (de)serializing NSObjects?

It should be simple like
Defaults.archive["foo"] = [bar:NSDate()]
println(Defaults.archive["foo"].bar)
// or maybe just
Archive["foo"] = [bar:NSDate()]
println(Archive["foo"].bar)

And let people do casting them self.
Cheers

@katopz @pellekrogholt @tbaranes Thanks for bringing this to my attention. I think I have a pretty great solution on the next branch. Check out http://radex.io/swift/nsuserdefaults/static/ for more background and explanation. Let me know what you think!


Custom Orchard Core analyzers (OSOE-346)

Let's develop custom analyzers. This is not that easy, and we'd need to publish them on NuGet since analyzers can't be used directly from the source.
Some ideas:

Check if controller actions have authorization either with attributes (e.g. [Admin]) or with an explicit IAuthorizationService call.
Check for any unfiltered ISession queries. While not always, usually there should be some kind of filtering instead of a full table retrieval.
Check for IContentManager.GetAsync(string id) calls in a loop and suggest IContentManager.GetAsync(IEnumerable<string> contentItemIds, bool latest = false) instead.
Check for OrchardCore.ResourceManagenet project/package reference if resource management tag helpers are used. Similarly, check for a missing OrchardCore.DisplayManagement reference and others. See https://github.com/OrchardCMS/OrchardCore/issues/6943.
Use IClock instead of DateTime.UtcNow.
Interesting not just for Orchard apps but any ASP.NET Core app, so should be under their own category:

Check for the injected localizer to have a proper type (not the field/property it's saved to): It must be IStringLocalizer<MyClass> or IHtmlLocalizer<MyClass>. The type parameter mustn't be omitted or have a different type than the current type.  This would actually be generally interesting for ASP.NET Core MVC apps. Came up here too: https://github.com/OrchardCMS/OrchardCore/pull/10987
Check for the Sdk attribute being Microsoft.NET.Sdk.Razor in the csproj's <Project> element if Razor templates are being used.
Private and protected fields should be named _prefixedWithUnderscoreCamelCased except for T and H. We can modify SX1309 for this. The alternative would be to put all localizers into properties instead and enable SX1309.

Jira issue

@Piedone is there any analyzers developed yet? If not is there a repo or project that I can start prototype the localizer analyzer

Not yet, we'd start in this project, so please fork it.

Sure

mark

Here's a proposition for a valuable analyzer:
Verify that an exception defined in a catch clause is used at the correct position in _logger.LogError():

_logger.LogError("message", ex) should trigger a violation
A fix should be provided to move ex to the beginning: _logger.LogError(ex, "message").

Tutorial on writing an analyzer: https://www.meziantou.net/roslyn-analyzers-how-to.htm.


Readme fix

Fixed some minor things in README.md.

Hi, @AndrewPoyntz
I've cloned master branch, changed only README.md, and my repo is not passing Travis CI build?

Hi @psanatov The PR didn't passed because there are conflicts, can you please resolve them. :+1:

@kartikjagdale Resolved conflicts :+1:


i have problem after building the grabber cmd will open and say error no model found as 'pyaes'

Can you try to disable your antivirus and delete the env folder near the Builder and then run it.

thanks it worked!

and can i test it myself?
i mean open the built file in pc that made that file.
does it work?

but it didn't sent it after 20 min

i think the file has problem

because my friend used the file and got the uploaded files in 10 sec
but not me

Did you set the Anti VM on or off?

Can you test the debug mode. Change it from Console:None to Console:Debug.


helm error

helm repo add akomljen-charts https://raw.githubusercontent.com/komljen/helm-charts/master/charts/
helm repo add es-operator https://raw.githubusercontent.com/upmc-enterprises/elasticsearch-operator/master/charts/
helm repo update
helm install --name es-operator es-operator/elasticsearch-operator --set rbac.enabled=false --namespace logging
helm install --name efk  --namespace logging  akomljen-charts/efk

Hey @bnnd what's the issue? Could you please explain the error / problem that you are running into?

This seems like it came from my blog post, as I used ES operator for EFK stack, but we need the issue first :)


Hub Refactor: Prop drilling and Hook for the fetch useEffect

mentioned here:
https://github.com/HausDAO/daohaus-monorepo/pull/401#pullrequestreview-1036156212
Keating started this for the profile view.

Honestly, a light rebuild of Hub is probably easier. It's one page. Most of the stuff here is not using our libs.

No hook yet. But prop drilling is fixed.


Integrate dotnet format check into GH pipeline

Motivation
Although we already require execution of dotnet format as one of the steps to successful contribution we do not verify that contributors have actually executed the formatting command before submitting to the repository. As a result, effective automation became impossible, as those using the dotnet format would see changes to files that were not touched by themselves during implementation.
Therefore, this PR adds dotnet format check directly to the pipeline.
Checklist

[x] Code follows coding conventions held in this repo
[x] Automated tests have been added
[x] Tests are passing
[x] Docs have been updated (if applicable)
[ ] Temporary settings (e.g. variables used during development and testing) have been reverted to defaults

How to test
If manual testing is required, what are the steps?

Can you also add the format call changes to the VS Code tasks and update the Contributing instructions like you did in Kentico.Xperience.Lucene?
The repo template does have an examples folder, even though it is empty

Can you also add the format call changes to the VS Code tasks and update the Contributing instructions like you did in Kentico.Xperience.Lucene?
The repo template does have an examples folder, even though it is empty

I originally considered Lucene a special exception because of the recent split into multiple projects, but now I see that the approach I had to apply to Lucene also applies to single project integrations and includes test files in formatting as well. So I ended up modifying the way we implement the dotnet format here, so that we check all files except those in the example folder.


Fix bug with size variable's value not being set when map is empty

In the type_convertion.m file the method to_c_items() does not set the c_dict.len variable if the size is equal to zero. This pull request changes things so that the variable is set earlier in the method so the size of the array does not stop the c_dict.len variable from being set.

See https://github.com/progrium/macdriver/pull/242 instead.


electrum: 4.4.6 -> 4.5.0

Description of changes

version update - https://github.com/spesmilo/electrum/blob/master/RELEASE-NOTES

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[x] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

@GrahamcOfBorg build electrum


Allow results to be opened from any directory

Allows backstop-results command to open the results page without having to be on the root directory.
The same change might/should work for macOS, but I don't have the means to test it. I do not know about Windows too, if anyone uses this in Windows can they please help?

Thanks. I think using the DDEV_APPROOT .env var also solves this, which i have just committed here: https://github.com/mmunz/ddev-backstopjs/commit/c011de281999256ec8065db8d8ad18a5fc827b57


Date Indexes

For 1.0.0 we need to settle on what exactly the story will be for DateTime and DateTimeOffset w/regard to indexes. Both are so common for querying against we'll probably need to ensure they are consistent if possible and where there are caveats we should make sure the documentation reflects them.

This is specific to DateTimeOffset. Indexes on DateTime do work today.


Track log missing

Ever since the log format was restructured (I suspect this commit was the culprit but I'm not certain), the trackLog is missing and the AccurateRip status always states "none of the tracks are present", even when this is patently not true.
Here's the same CD with the standard logger:
https://ptpb.pw/ud4r
And with the EAC logger:
https://ptpb.pw/glbJ
At least I hope I'm not the only one this happens to.

My hope is that EAC-style logging will help whipper be offically supported by the ripping community in private trackers and the like.

I think private trackers are going to rely on whipper's standard logger.


Fix il2cpp packaging in Unity 2022.2+

Fixes #227
See that issue for the details.

Tested this and it does work.

Great, thanks for the confirmation, @joseph-kaile. If you don't have any reservations, please merge it. I can't promise it will fix the problem forever, but it at least fixes it for now and it's a straightforward change that has no real chance of creating any new problems.


Move class artifacts out of katana-primitives

bcs the classes are used throughout other crates in /katana and not just in /primitives, so make sense to move it to the top dir

Merge activity

Apr 11, 1:56 AM EDT: @kariy started a stack merge that includes this pull request via Graphite.


LSP Inspector: In some cases hovering an item highlights more than expected

Refs #52866

Create a json log by modifying settings in vs code
Upload to LSP inspector and hover over items.

🐛 => Sometimes more than the request/response are highlighted

Tracking in https://github.com/Microsoft/language-server-protocol-inspector/issues/27


Querying Llama3 70b using BedrockChat returns empty response if prompt is long

Checked other resources

[X] I added a very descriptive title to this issue.
[X] I searched the LangChain documentation with the integrated search.
[X] I used the GitHub search to find a similar question and didn't find it.
[X] I am sure that this is a bug in LangChain rather than my code.
[X] The bug is not resolved by updating to the latest stable version of LangChain (or the specific integration package).

Example Code
from langchain.chains import LLMChain
from langchain.prompts import HumanMessagePromptTemplate
from langchain.prompts.chat import ChatPromptTemplate
from langchain_community.chat_models import BedrockChat
import langchain

langchain.debug = True

def get_llama3_bedrock(
    model_id="meta.llama3-70b-instruct-v1:0",
    max_gen_len=2048,
    top_p=0.0,
    temperature=0.0,
):
    model_kwargs = {
        "top_p": top_p,
        "max_gen_len": max_gen_len,
        "temperature": temperature,
    }
    return BedrockChat(model_id=model_id, model_kwargs=model_kwargs)

prompt_poem = """
This is a poem by William Blake

============
Never seek to tell thy love
Love that never told can be
For the gentle wind does move
Silently invisibly

I told my love I told my love
I told her all my heart
Trembling cold in ghastly fears
Ah she doth depart

Soon as she was gone from me
A traveller came by
Silently invisibly
O was no deny
============

What did the lady do?

"""
langchain_prompt = ChatPromptTemplate.from_messages([
        HumanMessagePromptTemplate.from_template(prompt_poem)
        ]
)
print("Response 1:", LLMChain(llm=get_llama3_bedrock(), prompt=langchain_prompt).run(dict()))
#Responds: ''

prompt_simple_question = """What is the capital of China?"""
langchain_prompt = ChatPromptTemplate.from_messages([
        HumanMessagePromptTemplate.from_template(prompt_simple_question)
        ]
)
print("Response 2:", LLMChain(llm=get_llama3_bedrock(), prompt=langchain_prompt).run(dict()))
#Responds: 'Beijing.'

Error Message and Stack Trace (if applicable)
No response
Description
I am trying to use BedrockChat to call Llama3 on our AWS account.
Here is the issue:

I try to pass a long-ish (multiline) prompt and it returns an empty string.
Passing the same long-ish prompt directly on the AWS Console generate the expected answer.

Passing a single line questions like What is the capital of China? return the expected answer Beijing.

System Info
platform: mac
python version: 3.11.7
langchain==0.1.16
langchain-community==0.0.34
langchain-core==0.1.46
langchain-text-splitters==0.0.1

Raise an issue and PR in langchain-aws repo: https://github.com/langchain-ai/langchain-aws/issues/31

Resolved here:
https://github.com/langchain-ai/langchain-aws/issues/31


Not adding conditionals inside nested model relations

Issue
Hello,
I have a query :
ProductType::where('id', $typeId)->with([
    'relation.subRelation.subSubRelation' => function ($query) {
        dd('test');
        $query->where('product_id', 10);
    }])->first()->toArray();

All of the models inside this query use Cachable trait.  But it doesn't enter inside callback. After code execution php doesn't die and doesn't dump 'test'. If I remove catchable trait from all models, it starts working as expected, and just pulls every record for subSubRelation of my query, without using $query->where()
Environment
Laravel Version: 5.6.15
Laravel Model Caching Package Version: 0.2.52
PHP Version: 7.2.1

@Tachii I was not able to reproduce the issue. Could you test again with the latest version? In my tests it does enter the closure and does trigger the dd():
        $author = (new Author)
            ->where("id", 1)
            ->with([
                'books' => function ($query) {
                    $query->where("id", "<", 100);
                    dd($query);
                }
            ])
            ->first();

@mikebronner you relation 'book' is single level, you'll a relation that has another relation in it. Also I'm initializing it with static call. My example still not working:
$productType = Type::find($typeId);
$productType = $productType->with([
    'attributeSet.attributes.values' => function ($query) {
        dd('test');
        $query->where('product_id', optional(\request()->product)->id);
        $query->where('webshop_id', \request()->webshop ?? Product::getDefaultWebshopId());
    }])->first()->toArray();

Thanks for the additional explanation. I'll add some tests for that and report back this weekend. Thanks!

I created another test specific for multiple levels of relationships, but still am not able to reproduce the problem. Please provide a complete stacktrace to troubleshoot this some more. You problem is likely elsewhere in your code. My guess is that your related models might not be cachable.

This issue is haunting me in 0.6.0 version as well. We get the cached values even though the query within the relation is changed.
For example:
    $author = (new Author)
            ->where("id", 1)
            ->with([
                'books.publisher' => function ($query) {
                    $query->where("id", "<", 100);
                }
            ])
            ->first();

and now change to
$author = (new Author)
            ->where("id", 1)
            ->with([
                'books.publisher' => function ($query) {
                    $query->where("id", "<", 50);
                }
            ])
            ->first();

this will return the previously cached values.


Just downloading without merging

Hi, first of all great tool - works like a charm ;-).
Is it possible to download all Segments of a DASH-Stream including manifest tranparently without merging them?

I'm glad it's useful!
This is not currently possible, but would be quite easy to implement. I'll keep this issue open and implement it one day. What's the intended purpose (I would think e.g. DRM decoding works on the merged audio and video streams)?

That sounds good :). I need the feature for development in the context of DASH Just-In-Time Packaging (JITP). I can then use it to control dynamically generated dash streams locally and do manifest manipulation for testing.

In fact, with the existing --keep-audio and --keep-video commandline options, you can access the audio and video files (assuming of course they are separate media streams). I could also add an option to disable muxing, which presumably would imply keep-audio and keep-video.

There is support for this in version 0.1.12. If the design of this interface can be improved, let me know.
--save-fragments <FRAGMENTS-DIR>

I think the --save-fragments argument is not useful to you.
In the next version, I will fix the warnings shown concerning the deletion of the temporary audio/video files when using --keep-video / --keep-audio. These shouldn't prevent the download from working correctly, though.
If you have specified --video-only you should not be seeing an attempt to mux. I don't on Linux.
To summarize, to keep only video:
dash-mpd-cli -v --video-only --keep-video keptvideo.mp4 mpd
To keep only audio:
dash-mpd-cli -v --audio-only --keep-audio keptaudio.mp4 mpd


Add initial test setup

As discussed in #3, this PR adds:

Orchestra Testbench
PHPUnit (+ configuration)
Model factory for OnlineMailable model
Basic TestCase.php
Composer script as a shortcut to run the tests

This looks really great, thank you @Jhnbrn90. I'll ask Ryan to review this too 👍🏼

@Sammyjo20 Approved both of these PRs, ready to merge. This one will need to be merged in first, then #7 can be merged. Nice work @Jhnbrn90 🔥

Great work thanks @Jhnbrn90 I'll use this code to learn testing in the future


createClient name colision

Description
I have a createClient operation in my openAPI schema, generating the createClient function. But at the same time createClient function is imported from the @hey-api/client-fetch package. It results in the name collision in the services.gen file.  It would be nice to have an option to avoid collision.
Reproducible example or configuration
No response
OpenAPI specification (optional)
No response
System information (optional)
No response

Hey @mkeyy0, yeah that's always a risk. How would you resolve this conflict?

@mrlubos I'm not sure, to be honest. It can be done in several ways:

For example, add the ability to override the createClient function name from the settings. But I'm not sure it's a good way to do this;
I guess that preferred way is:
Leave the public API of '@hey-api/client-fetch` the same, to not introduce any breaking changes to it.

import { createClient } from '@hey-api/client-fetch';

In the generated file use the following syntax
```ts
import { createClient as _createClient } from '@hey-api/client-fetch';

Anyway, createClient is not exported from the generated file, it's an internal implementation. So, to avoid name collisions, we add the _ internal property mark. It can be the same for the createConfig function.
What are your thoughts on this?

Yeah I think I'll need to move the client entirely out of the file since you'd be running into the same problem if your service was called "client", except I wouldn't be able to alias it then. Thanks for reporting, will improve this


Rollback

Add a new task docker_cloud:rollback which will :

scale up the previous version
switch the load balancer to the previous version
scale down the newer version
stop the newer version

For this issue, I will separate the different actions in different Capistrano tasks allowing then to reuse a lot of them to build the rollback recipe.


:bug: Fix kairosctl goreleaser build

drop rlcp: true -> https://goreleaser.com/deprecations#sourcerlcp
switch to --clean arg -> https://goreleaser.com/deprecations#-rm-dist
pin golang version -> https://github.com/kairos-io/provider-kairos/actions/runs/6123251646/job/16620757329#step:7:224

@kaiehrhardt this is very helpful, thanks!


Create 2022-08-10-The Console UI Will Use Material UI and Adopt Styli…

…ng from the VA Design System While Isolating Plugin Styling.md
Committing template for Design RFC
RFC Title
The Console UI Will Use Material UI and Adopt Styling from the VA Design System While Isolating Plugin Styling
RFC Preview Link
Comment Period End Date
August 31, 2022

Added Preview Link

The design system team is in the middle of an initiative to produce design tokens. I think this might address some of the issue cropping up here.

Thank you @timwright12, yes the Design System Team is working on that right now.
I also noticed a couple of the concerns about VADS listed in your (Draft) Explore replacing components in Console UI with Custom Components document. We can definitely work on getting better typescript support worked out with our web components, but I also want to note that our web components are used inside multiple React applications with no difficulty. I would love to know if there are any specific issues you found so that we can get them fixed.

Merged w/ comments added, was unable to close.


Terraform for route53 resolver rule. EKS API endpoint from peered VPC

Hi All, We are using AWS EKS. Since EKS endpoint will not get resolved from peered VPC, we always use route53 resovler by creating inbound and outbound endpoint and then create rule.
Here we haev created the inbound and outbound endpoint but while creating the rule, we need to pass the ip address created from the inbound connection, but its throwing an error when we try to use dynamic blocks.
variable "region" {
default = "ap-southeast-1"
}
provider "aws" {
region     = "${var.region}"
}
resource "aws_route53_resolver_endpoint" "eks-resolver" {
name      = "test-eks-dev_inboundendpoint"
direction = "INBOUND"
security_group_ids = [
"${var.inbound-sg}",
]
ip_address {
subnet_id = "${var.subnet-inbound}"
}
ip_address {
subnet_id = "${var.subnet-inbound-2}"
}
}
resource "aws_route53_resolver_endpoint" "eks-resolver-outbound" {
name      = "test-eks-dev_outboundendpoint"
direction = "OUTBOUND"
security_group_ids = [
"${var.outbound-sg}",
]
ip_address {
subnet_id = "${var.subnet-outbound}"
}
ip_address {
subnet_id = "${var.subnet-outbound-2}"
}
}
output "eks-resolver" {
value = "${aws_route53_resolver_endpoint.eks-resolver.ip_address}"
}
output "eks-resolver-outbound" {
value = "${aws_route53_resolver_endpoint.eks-resolver-outbound}"
}
resource "aws_route53_resolver_rule" "double" {
domain_name          = "EE3891EAE6181FEDECD789EF73FAD9C8.yl4.XX-XXXXXXX-1.eks.amazonaws.com"
name                 = "eks-resolver-rule"
rule_type            = "FORWARD"
resolver_endpoint_id = "${aws_route53_resolver_endpoint.eks-resolver-outbound.id}"
dynamic "target_ip" {
for_each = "${aws_route53_resolver_endpoint.eks-resolver.ip_address}"
content {
    ip = target_ip.ip
 }

}
}

I don't think this issue is related to this Terraform module?

Hi Max, Thanks for your response. I will close this and post the issue in terraform discussions.


Clicking on "Tag" in "Filter COs" does not add tag

Describe the bug
When I have a default tag set and COs selected in Filter COs, clicking on "Tag" does not add a Tag.
To Reproduce
Steps to reproduce the behavior:

When I have a default Tag set
Then I filter any COs in Filter COs
And I select all and click Tag.
No tag is added.

Expected behavior
Should add Tags
Environment (please identify where you experience this bug:
*** One of ***

Sandbox -
Production
Chrome

@jlpereira thanks much


Fix to avoid a bug when there are no changes in commit list

Also removed a duplicate import

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

Is this related to #30 ? When you encounter the bug?  Just looking where I can test it.

If you start a build manually and there has been no change since last build, it will complete (successfully or not doesn't matter anymore now that the commit list can be shown in all cases) and the commit list should be shown, but the null value returned was creating a null pointer exception. I patched it a few days after my pull request in november, but forgot to sync it.


SQLSTATE HV000 error when selecting kubernetes_cronjob

Describe the bug
I'm especially interested in the kubernetes_cronjob table. Unfortunately I've never managed to get a SELECT upon this table to work since I first tried, 3 or 4 months ago.
Steampipe version (steampipe -v)
Steampipe v0.20.0-alpha.4
Plugin version (steampipe plugin list)
Example: v0.18.1
To reproduce
steampipe query 'select * from kubernetes_cronjob;'

This produces
Error: the server could not find the requested resource (SQLSTATE HV000)

followed by an empty table.

Well thank you @bigdatasourav for involving yourself into such a great project !
I'm sorry I'm only partially answering your questions, I'll post the rest whenever I can.
Indeed, I just performed a plugin install instead of an update, I've now updated to v0.18.1 and the behavior is the same.
kubectl get cronjob xx returns
NAME                   SCHEDULE      SUSPEND   ACTIVE   LAST SCHEDULE   AGE
xxx   *[/5](https://file+.vscode-resource.vscode-cdn.net/5) * * * *   False     0        14d             14d

and kubectl version returns
WARNING: This version information is deprecated and will be replaced with the output from kubectl version --short.  Use --output=yaml|json to get the full version.
Client Version: version.Info{Major:"1", Minor:"26", GitVersion:"v1.26.0", GitCommit:"b46a3f887ca979b1a5d14fd39cb1af43e7e5d12d", GitTreeState:"clean", BuildDate:"2022-12-08T19:58:30Z", GoVersion:"go1.19.4", Compiler:"gc", Platform:"linux[/amd64](https://file+.vscode-resource.vscode-cdn.net/amd64)"}
Kustomize Version: v4.5.7
Server Version: version.Info{Major:"1", Minor:"11+", GitVersion:"v1.11.0+d4cacc0", GitCommit:"d4cacc0", GitTreeState:"clean", BuildDate:"2019-08-01T23:56:00Z", GoVersion:"go1.10.8", Compiler:"gc", Platform:"linux[/amd64](https://file+.vscode-resource.vscode-cdn.net/amd64)"}
WARNING: version difference between client (1.26) and server (1.11) exceeds the supported minor version skew of +[/-1](https://file+.vscode-resource.vscode-cdn.net/-1)

As for Kubernetes, it's hosted on a dedicated machine.
As for the kubernetes.spc file, I'm not sure I can get my hands on it.

I executed
echo "\
kubernetes_cluster_role
kubernetes_cluster_role_binding
kubernetes_config_map
kubernetes_cronjob
kubernetes_custom_resource_definition
kubernetes_daemonset
kubernetes_deployment
kubernetes_endpoint
kubernetes_endpoint_slice
kubernetes_event
kubernetes_horizontal_pod_autoscaler
kubernetes_ingress
kubernetes_job
kubernetes_limit_range
kubernetes_namespace
kubernetes_network_policy
kubernetes_node
kubernetes_persistent_volume
kubernetes_persistent_volume_claim
kubernetes_pod
kubernetes_pod_disruption_budget
kubernetes_pod_security_policy
kubernetes_replicaset
kubernetes_replication_controller
kubernetes_resource_quota
kubernetes_role
kubernetes_role_binding
kubernetes_secret
kubernetes_service
kubernetes_service_account
kubernetes_stateful_set
kubernetes_storage_class" | while read table; do echo -e "\n——— $table\n\n"; steampipe query "select * from ${table} limit 1;"; done

and here's the tables that wouldn't pass:

kubernetes_cronjob (1)
kubernetes_custom_resource_definition (1)
kubernetes_endpoint_slice (2)
kubernetes_ingress (3)
kubernetes_pod_disruption_budget (1)
kubernetes_secret (4)

and the associated error messages:

(1): Error: the server could not find the requested resource (SQLSTATE HV000)
(2): Error: endpointslices.discovery.k8s.io is forbidden: User "ngirard" cannot list endpointslices.discovery.k8s.io at the cluster scope: no RBAC policy matched (SQLSTATE HV000)
(3): Error: ingresses.networking.k8s.io is forbidden: User "ngirard" cannot list ingresses.networking.k8s.io at the cluster scope: no RBAC policy matched (SQLSTATE HV000)
(4): Error: secrets is forbidden: User "ngirard" cannot list secrets at the cluster scope: no RBAC policy matched (SQLSTATE HV000)

Thanks, @ngirard, for the quick response; I am still trying to reproduce the above error. Could you please share the Kubernetes version you are using?

Could you please share the Kubernetes version you are using?

Hey @bigdatasourav,
as far as I understand this can be found in the output from kubectl version:
Server Version: version.Info{Major:"1", Minor:"11+", GitVersion:"v1.11.0+d4cacc0", GitCommit:"d4cacc0", GitTreeState:"clean", BuildDate:"2019-08-01T23:56:00Z", GoVersion:"go1.10.8", Compiler:"gc", Platform:"linux[/amd64](https://file+.vscode-resource.vscode-cdn.net/amd64)"}

Please let me know if it suits you, otherwise I'll ask our SREs.

Thanks, @ngirard; as I can see, you are using an older version of Kubernetes v1.11.0+d4cacc0, which could be the reason for the error, with the latest stable versions, e.g. v1.24.10, I could not be able to reproduce that error.
CronJob API version of batch/v1 is fully supported since v1.21 only. However, batch/v1beta1 has backward compatibility.
I have raised a draft PR with a fix. Please try this and let us know your feedback.

@bigdatasourav , thanks you so much for your efforts !
I'm much more of a rustacean than a golanger, but I'll definitely take a stab at the PR since you provided clear instructions for me to compile it.
I'll keep you posted.

Unfortunately, CustomResourceDefination API version Apiextensions/V1beta1 does support older Kubernetes versions. Still, it does not support the latest versions like v1.24, so in our table, we have used the API version Apiextensions/V1 which is not compatible with older versions like v1.11.0+d4cacc0.
Same with CronJob and PodDisruptionBudget, they have also removed the API version v1beta1 support in the latest Kubernetes version v1.27.
I will dig it down further to check if we can provide support for both(old + latest).

Oh, perhaps I wasn't clear in my feedback: the patch does work for the kubernetes_cronjob table, which is the only one I'm interested in !

Hey @ngirard,  wanted to follow up on our previous communication regarding our plugin's compatibility with older Kubernetes API versions.
As I  mentioned earlier, our plugin currently supports the v1 API version, which does not support some of the older Kubernetes versions, and while we are constantly working on improving our product's capabilities, we regret to inform you that we do not have any plans to add support for the V1beta1 API version which works with older Kubernetes versions at this time.
I understand that this may be disappointing news, and I apologize for any inconvenience this may cause. However, I want to assure you that we are always open to feedback and suggestions from our users, and we will take your request into consideration as we continue to develop our plugin.
Also, you can continue to use this PR if it helps to resolve your problem.
If you have any further questions or concerns, please don't hesitate to reach out to us. We appreciate your support and look forward to continuing to work with you.

Hey @bigdatasourav, thanks for the heads up.
Sure, I understand. It won't be a problem at all for me: I'll keep using this PR until we have migrated to a newer version of Kubernetes, which should happen in the forthcoming months.
Thank you again for your efforts !

@ngirard Based on @bigdatasourav 's comment above, I'll be closing this issue as we're not currently planning on supporting older API versions, but if you have anymore questions, feel free to re-open this issue. Thanks!

Sure, @cbruno10 ! Cheers !


Support svelte 5

Describe the problem
Hi, is it possible to support svelte 5?
Describe the proposed solution
Svelte 5 is not supported it seems
Alternatives considered
uh, there exists no alternative
Importance
i cannot use svelte-retag without it

Right now: No, since it's still unstable and actively under development (at time of writing). However, we can at least anticipate what's coming up with some of the public API breaking changes here: https://svelte-5-preview.vercel.app/docs/breaking-changes
Summarizing what I found so far (for future reference):
It looks like a new major version of svelte-retag will also be required (setup v2 milestone) as some of the breaking changes would cascade down to anything depending on this package, too. That is: It'll likely only be compatible with either Svelte v3/v4 or Svelte v5, and that's mainly due to v5's use of mount() instead of new to instantiate components.  Also, I got a basic version of this working pretty quickly with v5 for the hello world demo, but after testing the vercel demo site it became clear that some other important features will need quite a bit more time to hash out (mainly issues with light DOM nesting, but there could be more). I put all this in experimental-svelte-v5 for now (see 1812b99); it's not ready for a PR yet though.
That's just what I could find after some initial testing. There might be more, especially once it's released. So, based on this, we'll definitely need to wait for the dust to settle with a stable<EMAIL_ADDRESS>before there can be a<EMAIL_ADDRESS>released to support it.

p.s. Forgot to mention that as part of my testing in experimental-svelte-v5 branch, I went ahead and rolled out #27 as a minor/patch fix, which was necessary to address some obvious bugs that came up when testing v5. It works with Svelte v3/v4, so it made sense to just roll that into main immediately (as svelte/internal isn't a public API anyway, as the name implies).

Hi, Thanks for the amazing work.

Forgot to mention that as part of my testing in experimental-svelte-v5 branch, I went ahead and rolled out https://github.com/patricknelson/svelte-retag/pull/27 as a minor/patch fix, which was necessary to address some obvious bugs that came up when testing v5. It works with Svelte v3/v4, so it made sense to just roll that into main immediately (as svelte/internal isn't a public API anyway, as the name implies).

Sounds awesome yep using private api will eventually lead to breakage.

That is: It'll likely only be compatible with either Svelte v3/v4 or Svelte v5, and that's mainly due to v5's use of mount() instead of new to instantiate components.

It can check for internal version and support both v3+v4 and v5. Here is the relevant file in svelte repository that exposes svelte version.
But it will inevitably increase the complexity of the entire package ( which might not what we want )...

it became clear that some other important features will need quite a bit more time to hash out (mainly issues with light DOM nesting, but there could be more). I put all this in experimental-svelte-v5 for now (see 1812b99); it's not ready for a PR yet though.

Thanks for taking a look into this on such a short notice :D

overall i am not sure svelte 5 is what i envisioned svelte to be. but it is what it is...

It can check for internal version and support both v3+v4 and v5. Here is the relevant file in svelte repository that exposes svelte version.

In this case, my key concern is just that I don’t think there’s any way to avoid it being a breaking change (regardless of the approach taken) making it necessary to go v2, that’s all. If we made it conditional and changed to an async import, that would affect builds/bundlers. For example, one key feature is support for IIFE for fast/early immediate execution of Svelte during initial render to eliminate CLS (cumulative layout shift). In other words, may as well just keep it simple and support one major API at a time (i.e. v3/v4 or v5) and then simply put a stake in the ground and call that v2 for now. 😊

Quick note: While this is currently assigned to v2 milestone (as a breaking change), it could be bumped to later version since I don't want it to block other changes slated for release with v2, largely because I will not be able to really work on this until after Svelte 5 is stable (as noted above).


[support]

vanilla glass and copper

Do i still need to install other mod to work like description's image

having the same issue

 vanilla glass and copper

having the same issue

check without other mods, maybe something changes the render

it is definitely other mods causing it but unsure which one

To find the problem you need a specific mod that breaks the render, if you manage to find it, open a new issue


Resolve Name Conflicts

Right now importing typings from, e.g., React will result in some strange things as in the React package we have something like
import * as PropTypes from 'prop-types';
export type Validator<T> = PropTypes.Validator<T>;

in dets this becomes
export type Validator<T> = Validator<T>;

where obviously the declaration of Validator is missing (otherwise we would have two with the same name).
Instead, we should choose a new name and come up with, e.g.,
export type Validator<T> = PropTypesValidator<T>;

where the latter would still be properly included / defined.

Available in latest version (0.5).


contact info for removal from mapathon support list

have a monitored email address people can reach out to about removing their info from the mapathon support map
also, it should be more explicit in the form about their info being publicly visible (so they should choose what contact info they want to post)

Hi Dan, how can we remove a person from the  google response form for mapathon support? Do you know who has access to edit it?
Thank you

Jana B, Rebecca F, and Jorieke V should all have access and ability to edit, as well as give additional people access.


fix: incompatible version changes for C4 W3 L4

Since the course was developed, some of the used packages had major version updates that made the code incompatible. Packages versions were not specified, so it made the pipeline fail unintentionally to the course program.
This PR fixes described issues and makes user experience a bit brighter.
Also fixed few empty line endings and a tpyo ;)

Hi Aleksandr! We're not yet accepting PRs but thank you for reporting this! The fix was ongoing based on previous reports but was put on hold because of a recent course launch. We just pushed the revisions so learners shouldn't run into the issues anymore. Thanks again!


Update information on master node size on GKE/AWS

Addresses issue #8640.

@zacharysarah Fixed

/lgtm
/approve


finished assessment, used class notes to reference

3.5 of 6 (-0.5 on Q2, Q3, Q5; -1 on Q4)
Not bad! You made a couple of small mistakes, but for the most part I think you've got this.

Thanks!
Sent from my iPhone, excuse any typos please
~ Laurisa

On Nov 2, 2015, at 9:19 PM, Matt Brendzel<EMAIL_ADDRESS>wrote:
3.5 of 6 (-0.5 on Q2, Q3, Q5; -1 on Q4)
Not bad! You made a couple of small mistakes, but for the most part I think you've got this.
—
Reply to this email directly or view it on GitHub.


Update test to reflect 2.2 and axe

Purple a11y leverages axe. Axe now has some elements of WCAG 2.2 in it.
So this text can change:

Only a subset of WCAG 2.1 (Conformance Level A & AA) Success Criteria can be automatically checked so manual testing is still required.

It is also worth adding what version of axe you are using on this page. It would fit nicely under "Purple A11y Version 0.9.41" in the left column.

This would also be a good place to feature an indicator of relative accessibility, such as I described in https://github.com/GovTechSG/purple-a11y/issues/240


Unable to Authorize Application

I'm trying to authorize application but get:

When I try another browser I can't even log in:

After a refresh I actually was logged in but authorization still fails:

Ah. There it is in the last screenshot in error console! A user error.
Can you convert this into a feature request:
"Tell user that that account is not verified if trying to authorize application with unverified account"

Thanks for reporting this. This is definitely bug and will be fixed.

@nevalla close if fixed?

Fixed


High CPU and hang for az acr build inside wsl2

Describe the bug
When calling az acr build from ubuntu/wsl2, it shows only a few log lines and hangs then. A python3 process tries consuming all CPU cycles. Nothing happens after minutes. On the same machine on windows there seems to be no problem.
az acr build --image {myimage} --registry {myregistry} --subscription {mysubscription} .
Packing source code into tar to upload...
Excluding '.gitignore' based on default ignore rules
Excluding '.git' based on default ignore rules

Command Name
az acr build
Errors:
none, it just hangs with a high cpu load

To Reproduce:
Steps to reproduce the behavior. Note that argument values have been redacted, as they may contain sensitive information.

Put any pre-requisite steps here...
az acr build --image {} --registry {} --subscription {} {}

Expected Behavior
az acr build completes its task
Environment Summary
Linux-<IP_ADDRESS>-microsoft-standard-WSL2+-x86_64-with-glibc2.29, Ubuntu 20.04.4 LTS
Python 3.8.12
Installer: DEB

azure-cli 2.34.1

Extensions:
azure-devops 0.22.0

Dependencies:
msal 1.16.0
azure-mgmt-resource 20.0.0

Additional Context

route to CXP team

Hello @hansmbakker Thanks for reporting this, we are routing this to service team's attention!


Issues by debugger

Problems with determining the term in the case of a syntax error. The error position row and column are not displayed. When developing using Firefox or analogs will display the location of the error, but on mobile devices it causes some difficulty.

These are now part of plugins , so report there.


[BUG] 1.16.5 and Curseforge have been made incompattible by specification. please remove this.

[Please fill out the form below and delete the sections in square brackets after reading them]
Version of Advanced Rocketry

N/A

Why is this important?
Knowing the version of Advanced Rocketry helps us narrow down an offending piece of code faster because we can easily determine what code is added and when.]

Have you verified this is an issue in the latest unstable build

[x] N/A

[Why is this important?
If you're not testing with the latest build, you may be encountering a bug that's already been fixed.
Reporting bugs that have already been fixed wastes everyone's time.  (please look in open issues too, somebody else could have already reported it!)]

Version of LibVulpes

N/A

Why is this important?
Advanced rocketry depends on a library mod (LibVulpes), some errors can really be in that mod.  So knowing the verison helps us not only start looking for fixes there without you needing to anwer more questions, it also helps us know if you have a version mismatch.]

Version of Minecraft

1.16.5

Why is this important?
Different versions of minecraft have different codebases for Advanced Rocketry.  Knowing the version of minecraft (and thus AR) helps us pinpoint issues quicker!]

Does this occur without other mods installed

[x] N

If Y, what is the MINIMUM set of mods required.

[Why is this important?
Sometimes interactions between mods cause issues.  While it can be a problem with Advanced Rocketry, sometimes it's not.  When there are a lot of mods, it can take bugtesters HOURS to go through the list to determine the root cause.  When there are a lot of bug reports, that can add DAYS to the time it takes to fix a large set of issues.]

Crash report or log or visualVM (if applicable)
http://pastebin.com is a good place to put them
crash reports that are put in the issue itself are
hard to read

[insert here

If it's an issue involving lag, please submit a visualVM sampler snapshot.  Mods like lag goggles often do not provide the kind of information needed to debug lag.
For more information on how to create a snapshot, please see "How to Run CPU Sampling" here.  Then export the snapshot as an .nps.  You may have to zip it since github is weird, then please upload it here.

Why is this important?
Full crashlogs contain valuable information like where exactly in the code the error occurred, what other mods may be running and what version of forge you have.  This helps us replicate and diagnose the issue FAR faster.]

Description of the problem

Open curseforge.com and open files and there are no 1.16.5 files there, despite there being a BETA VERSION OF 1.16.5 which WAS on curseforge.com but now isn't.

Why is this important?
If we cannot reproduce the problem, we probably cannot fix it at all.]

Completely intentional. The 1.16.5 version was buggy to the point of being entirely unusable.


[Task] Test AWS support

What needs doing
Similar to #72  we should test out our support for running on AWS, preferably on the new 'P4' instances that were recently announced.
We should compare using S3 vs local nvme for performance, and come up with documentation for running on AWS

need CLI access w/ access token


tooltip inside modal window, on hover of the element scroll bar goes to top - blocker

https://user-images.githubusercontent.com/82227069/138416042-b3ba4490-cb8d-4d52-8243-e7254207014d.mp4
We are using Tooltip.VERSION  = '3.3.4' & it's working fine earlier but currently it's failing.
RCA - In the library after this line this.options.container ? $tip.appendTo(this.options.container) : $tip.insertAfter(this.$element) execute scroll bar goes to up (top)
container is false

o


what happend to this repo?

Is this repo still alive?

it is.

its for celery next gen right? I was afraid that it became a stale repo....

Where i can see the progess since repo is not being updated since month back :)


HDDS-7275. Improve error logging when blocks cannot be allocated with RATIS THREE.

What changes were proposed in this pull request?
Current implementation returns a null and later on ScmBlockLocationProtocolServerSideTranslatorPB#allocateScmBlock() throws an exception with #blocks allocated and requested.
# hdfs dfs -put /etc/krb5.conf ofs://ozone1/vol1/bucket/3
put: Allocated 0 blocks. Requested 1 blocks

Proposed changed returns an exception when a block cannot be allocated after trying all possible strategies
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-7275
How was this patch tested?
Manual.
sh-4.2$ ozone sh key put /vol1/bucket1/key1 CONTRIBUTING.md
INTERNAL_ERROR Unable to allocate a container to the block of size: 1048576, replicationConfig: RATIS/THREE. Unable to find enough nodes that meet the space requirement of 10485760 bytes for metadata and<PHONE_NUMBER> bytes for data in healthy node set. Required 3. Found 2.
sh-4.2$

Thanks for improving this @SaketaChalamchala, this message has been confusing for users before. Could we also add a message summarizing why the allocation failed? For example, the log lines farther up in getContainer provide more information to the SCM log, but those messages could be returned to the client as well.

Thanks for improving this @SaketaChalamchala, this message has been confusing for users before. Could we also add a message summarizing why the allocation failed? For example, the log lines farther up in getContainer provide more information to the SCM log, but those messages could be returned to the client as well.

Done.

CI failures are fixed by #5217


[BUG] invokeai-web launcher is wrong

Environment
🪟 Windows
System
Windows
Describe the problem
The bat for invokeai-web needs to include the invokeai dir when run
Additional info
No response
Please tick the boxes

[X] I have explained the issue clearly, and I included all relevant info
[X] I have checked that this issue hasn't already been raised
[X] I have checked the docs

@AveryVeilfaire This is now fixed at https://github.com/SillyTavern/SillyTavern-Launcher/commit/3cee65e6bdd5e3e834a90e816d3e8cb1ab2d2892 Please update the launcher. The invokeai should now launch correctly


Create release of current version

Is there a date when the release of the current version will be made?

@kpalatzky Today.

@kpalatzky New version 0.4.47 is out.


Secure Connection Failed on documentaiton docs.laravelshopper.io

https://docs.laravelshopper.io/

The documentation is https://laravelshopper.dev


Getting warning 'video is being deferred until the player has loaded'

I'm getting this warning every time player is trying to load my video. It works fine when it loads the video for the first time, but after that for all other videos it shows a glimpse of previous video and then loads the actual one.
How can I wait for the player to fully load before sending in the url?
This is my what my code looks like:
<ReactPlayer
    playing={false}
    controls={true}
    url={this.props.movieVid}
/>

I'm probably doing something wrong here. It'd be great if you can help me out with this issue!
p.s. thanks for your amazing work!

The warning happens here when a new url is passed in before the onReady or onPlay event occurs. This behaviour was added to fix https://github.com/CookPete/react-player/issues/377.
Is this what is happening? What URLs are you trying to play?

I'm passing in youtube video that I'm getting from prop. How do I pass the url after onReady event?

How do I pass the url after onReady event?

You should be just passing the url in on first render, not trying to pass it in at a later time. onReady is just a callback for when the player deems itself "ready" to play something. If the url you are passing in changes between the first render of ReactPlayer and the onReady event, you will get this warning. ReactPlayer will then attempt to load the url you changed to once the player is ready, which may show a flick of a previous video.

@djohal How to pass the URLs on every render?  I also getting URLs from prop. THX

@djohal could you please describe, where did you add conditional statement to resolve the issue? Thanks in advance!

@cookpete can you please help me out with same issue 'warning - video is being deferred until the player has loaded', i didn't get the solution clearly.

The solution is to not change the url prop too quickly. This happens when a player tries to load but url changes before the player is ready, as described in my previous comment from nearly 3 years ago.

@cookpete what would be the preferred approach in case you do want to dynamically change the url on, for example, a click event elsewhere in the application?

what would be the preferred approach in case you do want to dynamically change the url on, for example, a click event elsewhere in the application?

There are many answers for this (and it's not really relevant to the issue) but the most basic way would be to have something like
const [url, setUrl] = useState(null)

in a top-level component somewhere. Then pass url down to your video player component that does
<ReactPlayer={url} ... />

and then pass setUrl down to the component you want to change the URL, then just do something like
<button onClick={() => setUrl('https://whatever')}>Click me!</button>

You could also use context, or redux, or any state management library.

You could also use context, or redux, or any state management library.

The reason I asked this question right here is because I, like you said, changed the url dynamically (in my case it's essentially a useState hook that drills down the url as a prop).
However, when I run tests (with the React Testing Library), I get this warning in the console.

Ah yeah, changing url rapidly (like in a test) is likely to trigger that warning. That’s annoying.
I'm considering getting rid of that guard altogether, or at least a prop that avoids it. It seems to cause more problems than it solves.

Also having the same problem as @MitchelSt


Color of Indicator

How can I change the indicator color?

thanks for asking this question, @italoevan. I added a section on this topic to the README.md. I hope this answers your question.


[Stability-embeddingapi] update stability tests.xml

-update stability tests.xml & suite.json

@jennycao please help to review it

LGTM


Issue/29 add base64deserializer

issue -> https://github.com/Laserfiche/lf-api-client-core-java/issues/29
https://v-dev-tfs/DefaultCollection/Server Tools/_workitems/edit/389207

We could move the initialization of Gson out of the method.

ok done and if there are not going to be any more changes, then i will publish preview version and update the other 2 java projects


Glitch with always 100 % Fuel

Could you please provide some more information? What did you do in order to get this "glitch"?
Maybe even the log file?

Oh, sorry that is my fault, didn't understand the meaning of "100 % Full" at first... LOL


Couldn't find a debug adapter descriptor for debug type 'msedge' (extension might have failed to activate)

When using the Remote Development feature of vscode
I get the following error message when trying to launch Edge (on my local system) via Run and debug.

Couldn't find a debug adapter descriptor for debug type 'msedge' (extension might have failed to activate)

Without using the remote Development feature it is working as intended.
In the past (do not remember which vscode version) this was working without any issues.
Does this issue occur when all extensions are disabled?: Yes/No
-> Not tested yet

VS Code Version:  1.61.2
OS Version: Linux x64 5.4.150-1-MANJARO

Version: 1.61.2
Commit: 6cba118ac49a1b88332f312a8f67186f7f3c1643
Date: 2021-10-19T14:58:13.605Z
Electron: 13.5.1
Chrome: 91.0.4472.164
Node.js: 14.16.0
V8: 9.1.269.39-electron.0
OS: Linux x64 5.4.150-1-MANJARO
Steps to Reproduce:
launch.json
{
           "type": "edge",
           "request": "launch",
           "name": "Launch Edge",
           "runtimeExecutable": "/usr/bin/microsoft-edge-beta",
           "urlFilter":"http://remote-ip:4000/",
           "port": 2015,
           "webRoot": "${workspaceFolder}/client",
           "trace": true,
           "sourceMaps": true,
           "userDataDir": "${workspaceFolder}/.vscode/edge",
           "sourceMapPathOverrides": {
                "webpack:///./src/*": "${workspaceFolder}/client/src/*"
     },
           "skipFiles": [
               "<node_internals>/",
               "${workspaceFolder}/client/node_modules//*.js",
           ],
}

Connect via vscode to remote PC
Run there via vscode the React client
Try to start the debugger (via Run and debug)

Please let me know if you need further information.

Do not want to reopen that issue, just for the ones stumbling about it.
If I understood it correctly it is a clash between JavaScript Debugger (https://github.com/microsoft/vscode-js-debug)
and debugger for Microsoft Edge (https://github.com/Microsoft/vscode-edge-debug2)
If I disable the JavaScript debugger globally and now try to start the debugger with the launch.json in the initial post
everything works as intended :)

@connor4312 are you aware of this clash?

Yea, we both register the msedge debug type. Vscode-edge-debug2 is deprecated and should generally no longer be used except if needed to debug IE or legacy Edge.

Interesting to know but why does then the launch.json below not work when using vscode remote?
{
      "name": "pwa-msedge",
      "request": "launch",
      "type": "pwa-msedge",
      "runtimeExecutable": "/usr/bin/microsoft-edge-beta",
      "url": "http://localhost:3000/*",
      "port": 9222,
      "trace": true,
      "webRoot": "${workspaceFolder}/client/src",
      "sourceMaps": true,
      "sourceMapPathOverrides": {
        "webpack:///./src/*": "${workspaceFolder}/client/src/*"
      },
      "skipFiles": [
        "<node_internals>/**",
        "${workspaceFolder}/client/node_modules/**/*.js"
      ]
    },

It runs remotely always into:

Could not connect to debug target at http://localhost:9222: Cancelled GET http://localhost:9222/json/version

Non-remote everything works as expected.
Therefore, my current workaround for that issue is to use vscode-edge-debug2


[Key Vault] resumeFrom overlap with required parameters may cause unintended behaviors

Many of Key Vault pollers accept resumeFrom serialized states that has copies of the main parameters of the methods that return those pollers. Although generally the resumeFrom properties that overlap are discarded in favor of the required function parameters, on multiple pollers, users may erroneously pass different values in both.
For example, beginDeleteKey requires a name parameter, and the resumeFrom from that poller also has a name parameter. Although only the required name parameter is finally taken, users may pass the wrong resumeFrom.
Proposed solution:
If the required parameters are different than the same properties in resumeFrom, we should throw an error.

@maorleger I moved this to July so that we can more easily remember to talk about it 🌞


Added starts of language detection.

I added some basic language detection.
It should also be noted that in order for the minified build to update, gulp build needs to be run twice otherwise changes won't persist. For that reason i have included the updated build files as well.

All the files should be updated now. Sorry about that. :-)

@AlexSwensen can you pull and run gulp build and again?
It would be even better if you would squash all the commits to 1 perfect commit.

git rebase -i HEAD~4
(4 is the number of commits you want to squash)

If you squashed all the commits you can force push it to your branch again

git push -f

Beautiful. Thankyou for this!

Created your function to make life easy.

Yes this could be a thing. I updated the switch with other language codes.
Also i build the minified code and altered the build a little.
A new release is coming today.

Awesome, good to hear!


Feat example classes and tests

Added some example classes to show inheritage mechanisms of typescript.
Added readme with full documentation on my DevOps Setup.

Thanks @tawfeeka, will merge now!


Add early / late notification

Someone got bitten by spam detection and didn't realise it, early/late notification could help with that.
https://itch.io/post/4992053


There appears to be no logging from your pod component that would shed light on this.
The pod container is publishing data very quickly on the TCP socket initiated by my local client.  I wonder if some buffer somewhere is getting overwhelmed?
Command was kubectl relay --kubeconfig=... --address <IP_ADDRESS> pod/$POD 23456:23456
For testing try sending multiple gigabytes as quickly as you can from pod back to client.
EDIT: and try sending a stop signal to the client (ctrl+z on max/linux) so that it isn't draining the socket... problem appears faster
I0810 18:07:48.590131   73054 tcp.go:22] "Handling tcp connection" reqID="70e80503-0e95-48e9-a466-2624ce13ddb8" dstAddr="<IP_ADDRESS>:23456" localAddr="<IP_ADDRESS>:23456" clientAddr="<IP_ADDRESS>:57880"
I0810 23:07:48.677016       1 main.go:59] "Start proxy tcp request" reqID="70e80503-0e95-48e9-a466-2624ce13ddb8" dstAddr="<IP_ADDRESS>:23456"
I0810 23:20:28.096485       1 tcp.go:48] "Client close connection" reqID="70e80503-0e95-48e9-a466-2624ce13ddb8"
I0810 23:20:28.096895       1 tcp.go:66] "ProxyTCP exit" reqID="70e80503-0e95-48e9-a466-2624ce13ddb8"
I0810 18:20:48.518316   73054 main.go:182] "Lost connection to krelay-server pod"
I0810 18:20:48.518368   73054 utils.go:96] "Removing krelay-server pod" pod="krelay-server-8h7mk"

Sorry for the late response, I guess this problem is caused by an underlying networking issue, and might be out of the scope of this kubectl plugin, https://github.com/kubernetes/kubernetes/issues might be a better place to post your problem there.

Close for now. Please feel free to reopen if you think this is still a krelay issue.


Generate project data (pull info from all MAINTAINERS files instead)

As discussed in the last Dev meeting, make the machinery pull-based instead (we just read MAINTAINERS file).
This is the first step, generate rolodex.
Signed-off-by: Daniel Holbach<EMAIL_ADDRESS>

#157 is follow-up. :grimacing:


chore: update versions.json to 1.5.2

Needs denoland/deno#8301

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


when do we need quantity_character?

I'm not sure I fully understand why we need quantity_character to support vector, tensor, and complex types. Why will it not work if the representation type is a vector, tensor, or complex value type? Is this because some quantities can only be vector types for example?

Makes sense, thanks.

Here is a bit outdated chapter about it in our docs: https://mpusz.github.io/mp-units/latest/users_guide/framework_basics/character_of_a_quantity.
When I finish my current work on it, I will definitely update this chapter.


There are components of slot and input. The update of the parent component will cause the input of the input to be reset.

Version
2.6.10
Reproduction link
https://jsfiddle.net/coinSnake/f03grbnh/22/
Steps to reproduce
Try changing the value of input
What is expected?
Normal input
What is actually happening?
Cannot be input normally, the current input will be covered by the old value

If you don't use slot, you won't find this problem.

This is expected because changing the slot rerenders the component containing the input and because of the lazy modifier, the old value is set again, overriding what was written by the user. You can get around this by using a regular v-model with copy of the text and listening to the change event to change the original value


Foundation version

I seem to have botched something since it thinks your commits are new. hmm...

Thanks Jon! Not sure how I missed the notification, but just merged your
Event search. Works great!
On Tue, Jul 21, 2015 at 2:31 PM, Jon McDuffie<EMAIL_ADDRESS>wrote:

I seem to have botched something since it thinks your commits are new.
hmm...
—
Reply to this email directly or view it on GitHub
https://github.com/LeahW/NewDevATL/pull/13#issuecomment-123429149.


Text drag and drop broken by unused variable in object destructuring

Issue Type: Bug
I noticed this issue after the recent update which introduced special rendering for unused variables. It seems that you can no longer drag and drop text onto lines with this special formatting.
Repro steps:

open a Typescript file
assign one or more variables via object destructuring
ensure a variable is unused, and is rendered in grey due to the recent update
select text elsewhere and try to drag it onto the line with that variable
drag and drop doesn't work anywhere in the line
dragging a selection from that line to elsewhere in the file does work

public myFunction() {
  const obj = {
    unusedVar: 50,
    usedVar: 100,
  };

  const {unusedVar} = obj;
  const {usedVar} = obj;

  const textIWantToDrag = "whatever";

  console.log(usedVar);
}

VS Code version: Code 1.24.0 (6a6e02cef0f2122ee1469765b704faf5d0e0d859, 2018-06-06T17:35:40.560Z)
OS version: Windows_NT x64 10.0.16299

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-4790 CPU @ 3.60GHz (8 x 3592)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onnative_gpu_memory_buffers: disabled_softwarerasterization: disabled_softwarevideo_decode: enabledvideo_encode: enabledvpx_decode: enabledwebgl: enabledwebgl2: enabled

Memory (System)
15.90GB (9.01GB free)

Process Argv
C:\Program Files\Microsoft VS Code\Code.exe

Screen Reader
no

VM
0%

Extensions (4)

Extension
Author (truncated)
Version

bracket-pair-colorizer
Coe
1.0.58

tslint
eg2
1.0.30

csharp
ms-
1.15.2

code-settings-sync
Sha
2.9.2

It seems the hit test is doing incorrectly in this case.

Tried to reproduce in latest version but failed, we no longer show the green squiggly line under unused variables, and that's probably why the issue no longer exists. Close it for now but if we have a good reproduce of this problem again, let's reopen it.


Unpaired ``` not gracefully handled

Original code; triple quote is unpaired accidentally
/**
 * ```kotlin
 * class foo {
 * }
 */

After formatting; an even # of triple quotes are added, which does nothing to solve the problem.  Every time formatter is run, more triple quotes are added.
/**
 * ```kotlin
 * ```
 * ```
 * class foo { }
 * ```
 * ```
 */

Here's a similar example, in which the triple quotes are not unpaired:
Before:
  /**
   * Title ```block```.
   * More text.
   */

After formatting once:
  /**
   * Title ```block```.
   * ```
   * ```
   * More text.
   * ```
   * ```
   */

Each time the file is formatted, 2 more lines of triple quotes are added before and after.

I started looking into this, and it looks like the problem stems from kdoc lexer tagging whatever token follows "block." as a CODE_BLOCK_TEXT token, which I would assume is a bug.
Not sure if we can fix kdoc lexer.  But also not sure what an appropriate workaround would be.

Update: the first issue is indeed fixed, but the second case is still not ideal.
Original:
/**
 * Title ```block```.
 * More text.
 */

Formatted:
/**
 * Title
 * ```block```.
 * More text.
 * ```
 */

Adding a new triple quote seems wrong in this case.


DayPlanner-Feature | add current date

WHEN I open the planner
THEN the current day is displayed at the top of the calendar

added dayjs.() for the current date


Bubble Sort/ Merge sort JS implementation

Files removed from self-study folder. Please check @sunnykgupta


WIP new primitive: createFileUploader

Thank you for an amazing repo!
It's my first ever open source PR, so any kind of feedback is highly appreciated.
Snippet:
// createFileUploader
<button onClick={() => {
    selectFiles(([{ source, name, size, file }]) => console.log({ source, name, size, file })});
}}>

// multiple files
const {files, selectFiles} = createFileUploader({ multiple: true, accept: "image/*" });
selectFiles(files => files.forEach(file => console.log(file)));

// single file
const {file, selectFile} = createFileUploader();
selectFiles(([{ source, name, size, file }]) => console.log({ source, name, size, file }));

// createDropzone

Dropzone

const { setRef: dropzoneRef1, files: droppedFiles1 } = createDropzone({
  onDrop: async files => {
    await doStuff(2);
    files.forEach(f => console.log(f));
  },
  onDragStart: files => console.log("drag start")
  onDragStart: files => files.forEach(f => console.log(f)),
  onDragOver: files => console.log("drag over")
});

// fileUploader directive
const [files, setFiles] = createSignal<UploadFile[]>([]);

<input type="file" multiple use:fileUploader={{
  userCallback: fs => fs.forEach(f => console.log(f)),
  setFiles
}} />

Demo: https://codesandbox.io/s/solid-primitives-upload-ry042x?file=/src/index.tsx
Reference: https://github.com/Marvinified/use-file-upload
TODO:

[x] Port the React hook
[x] Add/expose additional helpers
[x] Add async callback support
[x] Improve types
[x] Add createDropzone
[x] Add fileUploader directive

Awesome this was much needed. The next step is a createDropzone utility =)
Two quick comments, can you include a noop server entry? A lot of our primitive have that part of our standard pattern. It just mitigates the server doing anything it doesn't need to.
Also I'm not totally sold on the input being created from the component. I rather let the user create the component and use a directive to bind the uploader to it.

Welcome to the amazing world of open source, and thank you for bringing this here! :)
So far, you're nailing it for me, I don't have any suggestions for the work you've put in so far.
But I'm wondering a couple of things about the API: (I know they you're just poring the use-file-upload, but we can always improve if there is a reason to)

Wouldn't it be better to declare upload config on the createUpload primitive itself instead of on the selectFiles callback?
This would allow to narrow the types of the callback and files accessor. I can see a lot of type casting in your demo.
The type of file you want to accept and it's count is usually known up-front. If you have a pfp component you only accept a single image. If you have an attachments component in your email, it accepts any kind of files and any number.
This would even make the the api closer to the <input> component where you declare those sort of restrictions up front.

const [file, selectFile] = createUpload({ accept: "image/*" });
file() // T: UploadFile
selectFile({ source, name, size, file }) => {...});

const [files, selectFiles] = createUpload({ multiple: true });
files() // T: UploadFile[]
selectFiles(files) => files.forEach(file => {...}));

What about native <input type="file"> elements?
The createUpload is for triggering uploads by other elements (although the selectFiles could be used as a event handler of a input element, but it seams wasteful), but maybe some helpers could be exported separately so that using input elements could be done with similar api. This would make it easily swappable between these two when needed.
I imagine this could be done by providing a directive or an input event handler for input elements.

Shouldn't the primitive be called createUploader or createFileUploader? It just odd to have two verbs together.

@davedbase
Creating an input component is a necessary trick to be able to programatically trigger file uploads, for you would want to upload files by clicking on a normal button. I would say that this is a must have. The component isn't being connected to the dom anyway.

@thetarnav
Thank you very much for suggestions!
I'm trying to get away from the "porting" mindset now)

Ah, yes! Now I know why I was feeling uncomfortable with how I typed it :)
Additional helpers will definitely be useful I think. (maybe some from the snippet in my last comment?)
✓
✓
I think yes. I was also thinking about adding async user callback support. I was wondering whether it's a good idea/feasible  to make it possible to pass async user callback and depending whether it's a promise or not, handle it accordingly.

Published stage-0 at<EMAIL_ADDRESS>I think we may have been a little bit too quick with merging :P but I've cleared some of the missing peaces, just so we have a live package available for first usage.
 Thanks for handling it.

Thanks @thetarnav @davedbase! And sorry for taking so long:) Past two months have been quite busy.
Sure, I'll continue to improve the package and then probably start working on another primitive.