tensorflow.python.framework.errors_impl.InvalidArgumentError: Number of ways to split should evenly divide the split dimension, but got split_dim 1 (size = 1) and num_split 4

Hello,
I am able to run the pretrain code for rotation_3d and have its saved weights. In the config file for pretraining, I used  "top_architecture": "big_fully". Currently, I am trying to run the finetuning code for rotation_3d. I have a BRATS dataset which are all in numpy files. The BRATS images have dimensiom of (128,128,128,4) and they are already normalised, thus intensity of voxels range from 0 to 1. I am now trying to use BRATS labels of dimension (128,128,128) and they are not in one-hot encoding. Thus, the BRATS labels numpy array contain values of either 0,1,2 or 3. I also did the following changes.

In line 107 of this file https://github.com/HealthML/self-supervised-3d-tasks/blob/master/self_supervised_3d_tasks/data/segmentation_task_loader.py, I changed the patch size to (32,32,32) and patches_per_scan to be 64.
In line 181 of this file https://github.com/HealthML/self-supervised-3d-tasks/blob/master/self_supervised_3d_tasks/data/segmentation_task_loader.py, I changes n_classes to be 4 as initially I recieved a ValueError.

However, after attempting to run the finetune code, I recieved the following error.
Traceback (most recent call last):
File "finetune.py", line 4, in
main()
File "/home/svu/e0310071/self-supervised-3d-tasks/self_supervised_3d_tasks/finetune.py", line 418, in main
init(run_complex_test, "test")
File "/home/svu/e0310071/self-supervised-3d-tasks/self_supervised_3d_tasks/utils/model_utils.py", line 67, in init
f(**args)
File "/home/svu/e0310071/self-supervised-3d-tasks/self_supervised_3d_tasks/finetune.py", line 354, in run_complex_test
lambda: run_single_test(algorithm_def, gen_train, gen_val, True, False, x_test, y_test, lr,
File "/home/svu/e0310071/self-supervised-3d-tasks/self_supervised_3d_tasks/finetune.py", line 247, in try_until_no_nan
return func()
File "/home/svu/e0310071/self-supervised-3d-tasks/self_supervised_3d_tasks/finetune.py", line 357, in
logging_b_path, kwargs, clipnorm=clipnorm, clipvalue=clipvalue))
File "/home/svu/e0310071/self-supervised-3d-tasks/self_supervised_3d_tasks/finetune.py", line 174, in run_single_test
callbacks=w_callbacks,
File "/usr/local/lib/python3.6/dist-packages/tensorflow_core/python/keras/engine/training.py", line 819, in fit
use_multiprocessing=use_multiprocessing)
File "/usr/local/lib/python3.6/dist-packages/tensorflow_core/python/keras/engine/training_v2.py", line 342, in fit
total_epochs=epochs)
File "/usr/local/lib/python3.6/dist-packages/tensorflow_core/python/keras/engine/training_v2.py", line 128, in run_one_epoch
batch_outs = execution_function(iterator)
File "/usr/local/lib/python3.6/dist-packages/tensorflow_core/python/keras/engine/training_v2_utils.py", line 98, in execution_function
distributed_function(input_fn))
File "/usr/local/lib/python3.6/dist-packages/tensorflow_core/python/eager/def_function.py", line 568, in call
result = self._call(*args, **kwds)
File "/usr/local/lib/python3.6/dist-packages/tensorflow_core/python/eager/def_function.py", line 632, in _call
return self._stateless_fn(*args, **kwds)
File "/usr/local/lib/python3.6/dist-packages/tensorflow_core/python/eager/function.py", line 2363, in call
return graph_function._filtered_call(args, kwargs) # pylint: disable=protected-access
File "/usr/local/lib/python3.6/dist-packages/tensorflow_core/python/eager/function.py", line 1611, in _filtered_call
self.captured_inputs)
File "/usr/local/lib/python3.6/dist-packages/tensorflow_core/python/eager/function.py", line 1692, in _call_flat
ctx, args, cancellation_manager=cancellation_manager))
File "/usr/local/lib/python3.6/dist-packages/tensorflow_core/python/eager/function.py", line 545, in call
ctx=ctx)
File "/usr/local/lib/python3.6/dist-packages/tensorflow_core/python/eager/execute.py", line 67, in quick_execute
six.raise_from(core._status_to_exception(e.code, message), None)
File "", line 3, in raise_from
tensorflow.python.framework.errors_impl.InvalidArgumentError: Number of ways to split should evenly divide the split dimension, but got split_dim 1 (size = 1) and num_split 4
[[node model_5/model_4/up_sampling3d/split (defined at /home/svu/e0310071/self-supervised-3d-tasks/self_supervised_3d_tasks/finetune.py:174) ]] [Op:__inference_distributed_function_11489]
Function call stack:
distributed_function
Also, I am using TensorFlow version 2.1 and python version 3.6. Are these versions correct?
What does the error mean? Does anyone know how to solve this error?

Hello ,
So recently, I tried with the labels not in one-hot, meaning the labels dimension are (128,128,128).
Afterwards, I make the following changes.
In line 170 of https://github.com/HealthML/self-supervised-3d-tasks/blob/master/self_supervised_3d_tasks/data/segmentation_task_loader.py, I changed the line to this:
origin_row = np.random.randint(0, 1, self.patches_per_scan)
origin_col = np.random.randint(0, 1, self.patches_per_scan)
origin_dep = np.random.randint(0, 1, self.patches_per_scan)
The patch_size is still at (128,128,128) and patches_per_scan is 3.
In line 187 of https://github.com/HealthML/self-supervised-3d-tasks/blob/master/self_supervised_3d_tasks/data/segmentation_task_loader.py, I changed the line to this:
n_classes = 4
I hardcode the number of classes to be 4 since my BRATS dataset labels all have 4 classes.
After the following changes, I am able to run finish the finetuning code for all 5 self-supervised algorithms. I also did not have any errors while running the finetuning code and the model is able to train well. I am not exactly sure why the above following changes work for my case.
Nonetheless, thank you all for your help!

Hi @lokeycookie
Thanks for letting me know. I also can't tell why the changes you did work, without looking at the data.
Good luck! and don't forget to cite our work in your future projects :)


question-34-added

I have added question number 34 based on object literals and update the readme file as well

hi @kirandash I have created a pr , hope you merge it

Thanks, I will review it soon and merge

hi @kirandash made the changes as you suggested...

fixes #24


v3 - Events + some supporting files

With the events already present, is this PR still viable?

@Ulexus no

Okay, I'm going to close it, then. @SharonAllsup if we miss something from here, please feel free to open a new request for it.


Postal code validation does not work

Hi there.
General information

SDK version: 3.44.2
Environment: Sandbox
Browser and OS: Opera 49.0.2725.64 on Mac OS X 10.9.5 64-bit

Issue description
When using a wrong postal code with Hosted Fields, for example:
Card Number:<PHONE_NUMBER>111111
CVV: 000
Expiration Date: 12/20
Postal Code:<PHONE_NUMBER>

braintree-web does not find errors and returns nonce, but when using this nonce an error occurs on the server:
::Braintree::Customer.create(
  payment_method_nonce: nonce,
  credit_card: {
    options: {
      make_default: true,
      verification_merchant_account_id: merchant_account_id,
      verify_card: true
    }
  }
)

=> #<Braintree::ErrorResult params:{...} errors:<customer/credit_card/billing_address:[(81809) Postal code may contain no more than 9 letter or number characters.]>>

How can I validate the postal code on the client?

If you'd like to catch these errors on the client, you can vault on the client by generating a client token with a customer id (plus the other options you specified). https://developers.braintreepayments.com/reference/request/client-token/generate/ruby#customer_id
Then, when tokenizing with hosted fields, simply add vault: true as an option:
hostedFieldsInstance.tokenize({vault: true}, function (err, payload) {
  if (err) {
    // handle error
    return;
  }

  payload.nonce // token representing the vaulted card
});

Note: as reported in this issue, an unmatched postal code will pass back an error with the code HOSTED_FIELDS_TOKENIZATION_CVV_VERIFICATION_FAILED. We can't rename it to something like HOSTED_FIELDS_TOKENIZATION_FRAUD_TOOLS_VERIFICATION_FAILED until we publish a new major version, because it would break backwards compatibility. So just be aware if you're trying to catch specific error codes.


added back-to-top scroll up in readme

Issue No: #1222
I have added back-to-top scroll up in readme for easier navigation through lengthy readme files.
@sanjay-kv Please review and merge it with labels.
Thank you.

@sanjay-kv Sir, Could you please review and merge it with labels.
Thank you.

@sanjay-kv Sir, Could you please review and merge it with labels.
Thank you.


Implement message box

Implement a class uimsgbox derived from uiview to manage messageboxes.
Required features:

customizable window title
text message with word wrap
be able to specify standard buttons and buttons with customized text
automatic calculation of window size and position

Add accelerators support on buttons.


C:\Users\username.node-gyp\4.0.0\common.gypi not found

Similar to https://github.com/nodejs/node-gyp/issues/376
\4.0.0\include\node does have common.gypi, but not the 4.0.0 folder whereas all the other versions I have (back to 0.8.20) have them right in the root of the version folder.
Is this an issue with node-gyp or the script from heapdump?
myProject [feature/AddLabUnitTesting +2 ~2 -0 !]> npm install heapdump --save
\
><EMAIL_ADDRESS>install myProject\node_modules\heapdump
> node-gyp rebuild

myProject\node_modules\heapdump>if not defined npm_config_node_gyp (node "C:\Users\myUsername\AppData\Roaming\npm\node_modules\npm\bin\node-gyp-bin\\..\..\node_modules\node-gyp\bin\node-gyp.js" rebuild )  else (node  rebuild )
gyp: C:\Users\myUsername\.node-gyp\4.0.0\common.gypi not found (cwd: myProject\node_modules\heapdump) while reading includes of binding.gyp while trying to load binding.gyp
gyp ERR! configure error
gyp ERR! stack Error: `gyp` failed with exit code: 1
gyp ERR! stack     at ChildProcess.onCpExit (C:\Users\myUsername\AppData\Roaming\npm\node_modules\npm\node_modules\node-gyp\lib\configure.js:357:16)
gyp ERR! stack     at emitTwo (events.js:87:13)
gyp ERR! stack     at ChildProcess.emit (events.js:172:7)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:200:12)
gyp ERR! System Windows_NT 10.0.10240
gyp ERR! command "C:\\Program Files\\nodejs\\node.exe" "C:\\Users\\myUsername\\AppData\\Roaming\\npm\\node_modules\\npm\\node_modules\\node-gyp\\bin\\node-gyp.js" "rebuild"
gyp ERR! cwd myProject\node_modules\heapdump
gyp ERR! node -v v4.0.0
gyp ERR! node-gyp -v v2.0.2
gyp ERR! not ok
npm ERR! Windows_NT 10.0.10240
npm ERR! argv "C:\\Program Files\\nodejs\\node.exe" "C:\\Users\\myUsername\\AppData\\Roaming\\npm\\node_modules\\npm\\bin\\npm-cli.js" "install" "heapdump" "--save"
npm ERR! node v4.0.0
npm ERR! npm  v2.14.3
npm ERR! code ELIFECYCLE

npm ERR<EMAIL_ADDRESS>install: `node-gyp rebuild`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>install script 'node-gyp rebuild'.
npm ERR! This is most likely a problem with the heapdump package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     node-gyp rebuild
npm ERR! You can get their info via:
npm ERR!     npm owner ls heapdump
npm ERR! There is likely additional logging output above.

npm ERR! Please include the following file with any support request:
npm ERR!     myProject\npm-debug.log

Issues filed with heapdump: https://github.com/bnoordhuis/node-heapdump/issues/66#issuecomment-141113319

I also commented on the heapdump issue but make sure you use the npm and node-gyp that come with node v4.

After uninstalling/installing 4.1.0 and back to 4.0.0 and more reading, something was brought to my attention: gyp ERR! node-gyp -v v2.0.2 when I run node-gyp -v, I get 3.0.3 (and I'd previously confirmed that).  Thanks to https://github.com/nodejs/node-gyp/issues/724 I realized that my globally installed version was stale.
I've tried upgrading every way I know and at the CLI, -v reports 3.0.3, but npm installs keep failing and reporting 2.0.2 in the stack.
I'm on Windows if that wasn't clear. Do I have 2 versions installed and builds are using the wrong/older version?

While C:\Program Files\nodejs\node_modules\npm\node_modules\node-gyp had 3.0.3, C:\Users\myusername\AppData\Roaming\npm\node_modules\npm\node_modules\node-gyp had 2.0.2.
I emptied the older folder and copied over the contents of the newer. Seems that npm isn't dealing well with the fact that there's the system node_modules AND user account node_modules THEN the actual project.

my node is 4.0.0 is not install ! this i checkout to 0.12 can do it!..


May I ask, what is the MIOU of S3DIS dataset in  Area-5？

May I ask, what is the MIOU of S3DIS dataset in  Area-5？My own test was 49%, which feels a little low？

See https://github.com/AnTao97/dgcnn.pytorch/issues/20

Thanks.


CatalogException: damerau_levenshtein does not exist when using DuckDB

What happens?
I'm unable to run linker.estimate_u_using_random_sampling with a comparison ctl.name_comparison.
The error is"Scalar Function with name damerau_levenshtein does not exist! Did you mean "levenshtein"?"
To Reproduce
import pandas as pd
from splink.duckdb.linker import DuckDBLinker
import splink.duckdb.comparison_template_library as ctl
df_dupes = pd.DataFrame({
'unique_id': range(5),
'name': ['John', 'Johnny', 'Jack', 'James', 'Jimmy']
})
settings = {
'link_type': 'dedupe_only',
'comparisons': [ctl.name_comparison('name')],
'blocking_rules_to_generate_predictions': [
'substr(l.name, 1, 1) = substr(r.name, 1, 1)'
]
}
linker = DuckDBLinker(df_dupes, settings)
linker.estimate_u_using_random_sampling(max_pairs=5)
OS:
Google colab
Splink version:
3.9.1
Have you tried this on the latest master branch?

[X] I agree

Have you tried the steps to reproduce? Do they include all relevant data and configuration? Does the issue you report still appear there?

[X] I agree

You will need to upgrade your version of duckdb to 0.8.0 in order to use damerau_levenshtein - pip install duckdb==0.8.0.
Apologies, we should probably have some better messaging for this -  we don't insist on this version of duckdb as Damerau-Levenshtein is an optional feature, but we should probably make it clearer that this is only available on more recent DuckDB

Closing as this is now superseded by #1311


[troubleshooting] requesting reviews

I would like to request a review of this pull request, but documentation says "Pull request authors can't request reviews unless they are either a repository owner or collaborator with write access to the repository."
Did I create the pull request in the wrong place ?

Thanks @MayaAndersonGonzalez - this is not the wrong place at all. Apparently settings are more restrictive than I expected! I'll update this in the documentation.


Market Watcher: Strat Calculations queue when no trades available for processing

Note: this is the technical bug tracker, please use other platforms for getting support and starting a (non technical) discussion. See the getting help page for details.
I'm submitting a ...
[ x] bug report
[ ] question about the decisions made in the repository
Action taken (what you did)

"No new trades" are available from the exchange (binance in this case) and 2 or more candles of time elapse
A new trade is processed from the exchange at the next "request" interval

Expected result (what you hoped would happen)
1 candle of strategy calculation should be processed
Actual result (unexpected outcome)
All strategy calculations that should have run at the end of each candle, but no trades were available to process, ends up running at the same time as soon as a new trade is processed.
For instance:
Candle Size: 3 Minutes
Strat: CCI
On XLM/ETH - No trades occurred for about 8 minutes.
As soon as a new trade could be processed -  and was processed - 3 CCI calculations were processed, and resulted in a false indication of a trend for 2 candles.
Other information (e.g. detailed explanation, stacktraces, related issues, suggestions how to fix, links for us to have context, eg. stackoverflow, etc)
The scenario above should - in my opinion - result in a single calculation and not trigger subsequent trend indications off a single data-point. Ideally, any time no data is available for a candle, that candle should not contribute to the calculation of a trend.

This is a design decision! The hard thing comes from some exchanges (in some scenarios) not sending a trade that happened at 11:59 until something like 12:06 (7 minutes later). By waiting for the next trade Gekko is not making any assumptions about.
Note that is only a problem in very iliquid markets & on small candles. If you trade on 1 hour candles you'll hardly notice this when there are some trades.
There are a number of reasons why running Gekko with small candles on an illiquid market is a bad idea. For example see https://gekko.wizb.it/docs/features/backtesting.html#Simplified-simulation and https://github.com/askmike/gekko/issues/2380#issuecomment-408744682. I will try to explain this better in the docs.
Closing this but feel free to comment and let me know your thoughts.

How is this a design decision? What on earth were you thinking. This should not be the case for exchanges that offer candles!? We need to sync up with the exchange we are trading with as much as possible to minimize any error or.drift. I believe you decision was good at the time being (7 years ago) but now it's broken. If a exchange offers candles we should use them. Otherwise we should build

Also you keep saying illiquid markets. This is happening on pairs. BTCUSDT for one.

@thisisloze OP talks about XLM/ETH and minuts of no trades happening on this market. Please don't hijack other's people issues. I address you concerns here:https://github.com/askmike/gekko/issues/2524

I'm pretty sure this issue is related to candlebatcher. It's happening on
every pair Mike. Stop being like this lol!!
On Fri, Sep 14, 2018, 7:33 AM Mike van Rossum<EMAIL_ADDRESS>wrote:

@thisisloze https://github.com/thisisloze OP talks about XLM/ETH and
minuts of no trades happening on this market. Please don't hijack other's
people issues. I address you concerns here:#2524
https://github.com/askmike/gekko/issues/2524
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/askmike/gekko/issues/2461#issuecomment-421359651, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AVIk9q6ga6cxbc9ZhH_K_Z1TskJxfgDdks5ua7AqgaJpZM4WDV5O
.

Please read this issue again, and after that read my response in #2524.


Expose the list of the connected client IDs

It would be useful to have access to the list of connected clients of the broker. This would be very simple to implement: just create a function that returns the sessions.keys of the Broker class:
public fun getConnectedClients(): ListString = sessions.keys

Done here https://github.com/davidepianca98/KMQTT/commit/6dcc30c5f6fcda3ebacf462870acc95105cef777

Hey thanks that's awesome! This way I don't have to keep track manually but I can simply ask the broker for the connected devices!
Any ETA for the next release that will include this new feature?

I think during the next week it could be feasible

Awesome, thanks!


feature: refactor commlog

Is there an existing issue for this?

[X] I have searched the existing issues

Feature idea
make communication logger available through python logger
use the following logger names

sdc.com.multicast.out
sdc.com.discovery.in
sdc.com.discovery.out
sdc.com.soap.request.in
sdc.com.soap.request.out
sdc.com.soap.response.in
sdc.com.soap.response.out
sdc.com.soap.subscription.in

this enables the user to attach a logger of their choice to each communication channel. This also makes it very easy, if one e.g. is only interested in soap requests. Also, the user may decide how these logs are handled.
Alternatives
leave it as it is. However, this does not give very much flexibility and it is very difficult finding the correct log file because there is just the timestamp since when the application has been started
Implementation idea
using the logging.Logger class
Participation

[X] I am willing to submit a pull request to implement this feature.

Link to the idea discussion
No response

fixed in #253


Generator stryker-mutator with preset angular generates invalid configuration

Package: @diogovcs/stryker-mutator
Version: 0.2.5
Generator: stryker-mutator
Using the Generator "stryker-mutator" with preset "angular" generates a configuration file that contains the entry "tsConfig" in the section "jest" (without a training comma).
The missing comma raises an error when the newly generated code should be formatted:
nx generate @diogovcs/stryker-mutator:stryker-mutator xxx --preset angular
>  NX  Generating @diogovcs/stryker-mutator:stryker-mutator

Could not format libs/xxx/stryker.config.js. Error: "Unexpected token, expected "," (21:5)
  19 |     configFile: './libs/xxx/jest.config.js',
  20 |     tsConfig: './libs/xxx/tsconfig.spec.json'
> 21 |     config: {
     |     ^
  22 |       testEnvironment: 'jsdom'
  23 |     },
  24 |     enableFindRelatedTests: true,"

Furthermore, the configuration option is rejected by Stryker:
nx mutate xxx
> nx run xxx:mutate

11:59:59 (22664) ERROR OptionsValidator Config option "jest" must NOT have additional properties
11:59:59 (22664) ERROR Stryker Please correct this configuration error and try again.

Proposed solution: remove the line containing the entry "tsConfig" from the template.

This configuration is fixed in version 0.2.6.


memory leak when continuously writing?

SerialPort Version: 6.0.4 & 6.0.5 & 6.1.0

NodeJS Version: v8.9.0

Operating System and Hardware Platform: Windows 10 x64 [10.0.16299.248] & Arduino Due

Have you checked the right version of the api docs?:

Are you having trouble installing and you checked the Installation Special Cases docs?

Are you using Electron and have you checked the Electron Docs?:
First used in Electron, and then test in a pure node environment after encountering the problem.

Summary of Problem
I experienced that when continuously writing data to the serial port, large numbers of 'Buffer' objects were created, which can be observed in DevTools using 'Take snapshot'. If the transmit speed was accelerated, sometimes the programs will occupy hundreds of MBs of memory in a daytime. I have tried the versions of 6.0.4 & 6.0.5 & 6.1.0.
Steps and Code to Reproduce the Issue
I simply use the following test codes.
var port = new SerialPort("COM20", {
    baudRate: defaultBaudRate
});
setTimeout(()=>{
    setInterval(() => {
        port.write(Buffer.from('##0115aC8**', 'ascii'));
    }, 300);

    port.on('data', function(data){
        console.log(data.toString('ascii'));
    });
}, 400);

@reconbot There are enough time intervals between sending intructions. Actually, the response data is correct and in time. My arduino reply instructions every 50ms, so I think the time interval should be enough.

@reconbot Recently, I have tried the following code:
const promisify = require('util').promisify;
const SerialPort = require('serialport');

var port = new SerialPort("COM20", {
    baudRate: 115200
});

port.on('data', function(data){
    console.log(data.toString('ascii'));
});

(function test(){
    promisify(wAd)().then(()=>{
        test();
    });
})();

function wAd(callback){
    port.write(Buffer.from('##0115aC8**', 'ascii'));
    port.drain((err)=>{
        setTimeout(()=>{
            callback();
        }, 1000);
    });
}

However, the problem is still same as what I have previously said. The 'buffer' objects are accumulating after starting the program. But, I find it works well on Ubuntu 16.04 and the memory usage is stable.

I have seen this same problem, also using Windows. The "rss" memory reported from node will steadily climb as the serial port is used (I need to write to the port around 40 times per second the entire time the app is running, and the app needs to run for many days).
I have been able to fix the issue by adding a single line to serialport_win.cpp
Please note that I'm extremely unfamiliar with native code binding in node but from what I can understand in the documentation for nan::Persistent, it seems like V8 might be keeping the underlying memory around even though the baton has been deleted since baton->buffer.Reset(buffer) is called but baton->buffer.Empty() or baton->buffer.Reset() aren't called later.
Anyhow, adding baton.buffer.Reset() just before delete baton; on line #387 in serialport_win.cpp appears to resolve this problem on my machine.

Oh, I was just looking at the source again, would it be better to dispose of the buffer in the WriteIOCompletion  function?
I don't know if this is a problem or not but my previous solution will release the buffer as soon as the write is queued (via EIO_AfterWrite) rather than when the write operation is actually finished..


timeout in minutes right?

the page should probably specify that the function timeout duration is in minutes. IDK why but i assumed it was in seconds and i was trying to think about all kinds of workarounds to do my data analytics job in a bunch small runs.
TLDR: should probably specify that the timeout duration is in minutes

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 1df5e2bd-489d-19b2-87d3-d993ebb82021
Version Independent ID: 9e9d9ded-8f40-22be-4654-48c87f2c59e8
Content: Azure Functions runtime versions overview
Content Source: articles/azure-functions/functions-versions.md
Service: azure-functions
GitHub Login: @ggailey777
Microsoft Alias: glenga

Hi @Ballzer0 Thanks for your feedback. We will review and update as appropriate.

@Ballzer0 It is mentioned in the Function app timeout duration section.

So for now I will proceed with closure of this and If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion and we will reopen the issue.


Meta info in route ?

I was wondering if it could be useful to have meta attached to routes ?
Something like:
{
  route: "",
  get: function() {},
  meta: {
     foo: "bar"
  }
}

This could be pretty interesting to have a declarative approach to assist for example the authorize callback instead of inlining the information in the code.
What do you think ?

Could we just start simple by adding a getRoutes method to Router? From there we can at least play around with ideas for creating meta-documentation.
To answer some of the questions of @michaelbpaulson

What is this good for

It's good for creating self-generating documentation along the lines of Swagger or RAML for REST as opposed to trying (and failing) to keep README's and Wiki's up to date. So as a backend engineer I can load up my paths and my UI person can hit model.get('api-docs') and they get all of the paths available plus annotations.

How would someone access the meta information?

To start, you'd craft a "docs" path that splits out a JSON graph of the metadata structure. This does not have to be done in the falcor-router package but can be done as a 3rd-party addon. But to do this we need an interface to get the routes to analyse them.

would the meta info be available on this object in a route?

Probably not. It's usually used for passive documentation purposes.

@eddieajau as a stop-gap solution couldn't you define your array of routes separately and export them for consumption?
var routes = [ /* stuff */];

var router = new Router(routes);

module.exports = {
  routes: routes,
  router: router
};

Then whatever code you need to have access to those routes could simply just require the routes directly and analyze them.

@eddieajau have you seen https://github.com/greim/falcor-doc-router?

@blesh the would be a bandaid. However, I'd much prefer the router had an addRoute rather than messing around with concat-ing dozens of little arrays from various plugins. In that case, getRoutes would make sense. I modularise my different groups of routes and it would be so much cleanup just to call:
let router = createRouter();
registerRoutesForArticles(router);
registerRoutesForUsers(router);
registerRoutesForDocs(router);  // <-- this would call router.getRoutes() to build the JSON Graph

as opposed to
let routes = [].concat(
  makeRoutesForArticles(),
  makeRoutesForUsers()
);

makeRoutesForDocs(routes);

var router = createRouter(routes);

@trxcllnt no I haven't. That's an interesting start.


Unable to run Demo present in demo folder.

I am trying to run the demo bitext mining given in demo folder .
It is failing with following error :
2022-07-13 14:14 ERROR 1323129:submitit - Submitted job triggered an exception
Traceback (most recent call last):
File "/usr/lib/python3.8/runpy.py", line 194, in _run_module_as_main
return _run_code(code, main_globals, None,
File "/usr/lib/python3.8/runpy.py", line 87, in _run_code
exec(code, run_globals)
File "/nlsasfs/home/trial_home/trial_user/.local/lib/python3.8/site-packages/submitit/core/_submit.py", line 11, in
submitit_main()
File "/nlsasfs/home/trial_home/trial_user/.local/lib/python3.8/site-packages/submitit/core/submission.py", line 72, in submitit_main
process_job(args.folder)
File "/nlsasfs/home/trial_home/trial_user/.local/lib/python3.8/site-packages/submitit/core/submission.py", line 65, in process_job
raise error
File "/nlsasfs/home/trial_home/trial_user/.local/lib/python3.8/site-packages/submitit/core/submission.py", line 54, in process_job
result = delayed.result()
File "/nlsasfs/home/trial_home/trial_user/.local/lib/python3.8/site-packages/submitit/core/utils.py", line 133, in result
self._result = self.function(*self.args, **self.kwargs)
File "/nlsasfs/home/trial_home/trial_user/indicmining/repos/stopes/stopes/core/stopes_module.py", line 94, in call
res = self.run(iteration_value=iteration_value, iteration_index=iteration_index)
File "/nlsasfs/home/trial_home/trial_user/indicmining/repos/stopes/stopes/modules/preprocess/line_processor.py", line 138, in run
enc.process_lines(lines_with_numbers)
File "/nlsasfs/home/trial_home/trial_user/indicmining/repos/stopes/stopes/modules/preprocess/encode_to_npy.py", line 58, in process_lines
array = self.encode_to_np(lines_with_number)
File "/nlsasfs/home/trial_home/trial_user/indicmining/repos/stopes/stopes/modules/preprocess/laser_sentence_encoder.py", line 397, in encode_to_np
return self.encoder.encode_sentences(tokenized_sents)
File "/nlsasfs/home/trial_home/trial_user/indicmining/repos/stopes/stopes/modules/preprocess/laser_sentence_encoder.py", line 156, in encode_sentences
results.append(self._process_batch(batch))
File "/nlsasfs/home/trial_home/trial_user/indicmining/repos/stopes/stopes/modules/preprocess/laser_sentence_encoder.py", line 95, in _process_batch
sentemb = self.encoder(tokens, lengths)["sentemb"]
File "/nlsasfs/home/trial_home/trial_user/.local/lib/python3.8/site-packages/torch/nn/modules/module.py", line 1130, in _call_impl
return forward_call(*input, **kwargs)
File "/nlsasfs/home/trial_home/trial_user/indicmining/repos/stopes/stopes/modules/preprocess/laser_sentence_encoder.py", line 200, in forward
encoder_out = super().forward(src_tokens, src_lengths)
File "/nlsasfs/home/trial_home/trial_user/.local/lib/python3.8/site-packages/fairseq/models/transformer/transformer_encoder.py", line 165, in forward
return self.forward_scriptable(
File "/nlsasfs/home/trial_home/trial_user/.local/lib/python3.8/site-packages/fairseq/models/transformer/transformer_encoder.py", line 294, in forward_scriptable
lr = layer(x, encoder_padding_mask=encoder_padding_mask_out)
File "/nlsasfs/home/trial_home/trial_user/.local/lib/python3.8/site-packages/torch/nn/modules/module.py", line 1130, in _call_impl
return forward_call(*input, **kwargs)
File "/nlsasfs/home/trial_home/trial_user/.local/lib/python3.8/site-packages/fairseq/modules/transformer_layer.py", line 319, in forward
output = torch._transformer_encoder_layer_fwd(
RuntimeError: Mask shape should match input shape; transformer_mask is not supported in the fallback case.

Thanks for the report. Could you share the fairseq version you're using ? pip show fairseq and how you installed it ?

Version: 0.12.2

@gwenzek  Any further steps to fix this ?

@oneraghavan could you send the config that you used?
the run should have created a outputs folder and in there you will find (under the timestamp folder) a config dump folder with a bunch of yaml file. Would be good to have this + the cli you used.

@oneraghavan, I found an issue with the demo.yaml and nl file specs, I sent a fix for that, but if you got to the encoding step, then you must have fixed it on your side I guess.
I am running the encoders fine with fairseq==0.12.2 right now and that's working fine.
Can you maybe give us some details on your config/etc.

ok, bar that, I managed to get the same failure as you.

I'll update the readme to make sure that it's clear this should be the tag to use in fairseq repo.

fixed in 7e8518647e53c5a931c6e1229963e4e810b528cf


Update jest-leak-detector package to be compatible with the new Node version

At https://github.com/facebook/jest/issues/8397, we know weak package doesn't work in Node version 12 and we use weak-napi package instead of weak in new version. weak-napi  have interface like weak package but it still have some differences suck as:
GC callbacks are invoked at a suitable time (after the actual GC run has finished). This is nice because it means your process won’t potentially crash.

The consequence of this is that the isLeaking function in jest-leak-detector package return value must be converted into a promise to wait a bit time.

@SimenB  @jeysal  DT was released type for weak-napi package at @types/weak-napi and I added it. PR was updated.

Hmm, something seems to be off with CI - Circle runs on your account instead of Jest's. Not sure how that happened

how I fix it? :<

Noticed Circle doing the same for #8689, perhaps it only worked there because I have the necessary permissions. Maybe it works if you remove your fork from the list of projects that Circle builds.

@jeysal I have removed it from list in my CircleCI. Please trigger run build agian!

I don't know if we can rerun if there's no build for this PR in the history. Can you try to
git commit --amend --no-edit && git push -f

I did it and waiting to CircleCI re-run

That worked 👌

Either leak detection has improved or it's now wrong... See the node 10 failure (where we run --leak-detector on ourselves). I restarted it for now in case it's transient

node-10 is working well but I see an error in test-jest-circus and I don't know why CI throw this error!?

circus is unrelated, happens on master too

this PR will be waiting to test on node-12 before, right?

Yeah, we'll merge this when we start landing breaking changes.

many thanks for reviewed! ^^


Improve documentation of exceptional behavior of futurevalue

Current documentation is very misleading - multiple people are in an illusion, that using thrownBy with futures is allowed while at the same time, recoverToSucceededIf seems to be the correct approach.
This PR tries to fix the documentation to make this more obvious.
Fixes #1172

@cla-bot[bot] check


[BUG] The padlock icon on the address bar shows locked on insecure/HTTP websites

Describe the bug
The theme displays the padlock icon even when on an HTTP only page (proceeding to access the site after Firefox warns about it)
This gives the false impression that connection is secure, and could lead users to perform a transaction etc without thinking twice about it. Since the icon is what most people look at before sending / exchanging any sensitive data
To Reproduce
Steps to reproduce the behavior:

Go to any HTTP only website. Example: http://silent.org.pl/home/2022/06/13/the-floppotron-3-0/
Proceed to access despite the Firefox warning
The Padlock icon would be displayed as locked. Clicking on it reveals that the connection isn't secure

Expected behavior
The icon shows an a cross across the icon (or an exclamation point) to indicate the connection is not secure
Screenshots

Desktop (please complete the following information):

OS: MacOS 12.4
Firefox version 101.0.1
WhiteSur theme: commit 392cf013e5a752725e569308e3b9db4a3d29408d

Good pickup. I'll look into this ASAP

Added new icons for pages that are insecure as well as other warnings.

That was quick! Much appreciated


Corrected a couple of typos in readme.md

An incredibly useful little package, saved me loads of time! Thank you!

Thank you! I had completely missed this.


Fix sunpy 3.1 compatibiltiy

Fixes #38
This fixes a test incompatibility with sunpy>=3.1

Is there anything in sunpy or sunpy map that requires ndcube 2.0? I am getting some integer overflow errors when I try to use the .plot() method on a full, 3D cube of EIS data (both EISCubes and base NDCubes), so I am a bit wary of forcing users to upgrade immediately. Plotting 2D slices seems to work just fine though, which is what most users would be doing anyways, so perhaps it is a non-issue.

Is there anything in sunpy or sunpy map that requires ndcube 2.0?

No. sunpy does not depend on ndcube. Similarly, ndcube(>=2.0) does not depend on sunpy.

I am getting some integer overflow errors when I try to use the .plot() method on a full, 3D cube of EIS data (both EISCubes and base NDCubes), so I am a bit wary of forcing users to upgrade immediately. Plotting 2D slices seems to work just fine though, which is what most users would be doing anyways, so perhaps it is a non-issue.

Huh that is strange. If this is happening on bare ndcubes, maybe it should be reported upstream to the ndcube repo? Is this in animations in a notebook or in a normal matplotlib Qt interface?
My main reason for pinning to >=2.0 is that I'm not sure that maintaining compatibility between pre and post 2.0 is a good idea. It may be possible at the moment, but the burden of maintaining compatibility with both versions is only likely to increase. I think for a pre-1.0 package like eispac, it is perfectly reasonable to force users to update.

My main reason for pinning to >=2.0 is that I'm not sure that maintaining compatibility between pre and post 2.0 is a good idea.

I would agree with this, the ndcube 2.0 code base is very different from 1.0, even if your library code isn't using the API your users presumably will and will get very confused if you can swap between them with the same version of eispac.

I am getting some integer overflow errors when I try to use the .plot() method on a full, 3D cube of EIS data (both EISCubes and base NDCubes)

If you can reliably reproduce this please open an issue upstream so we can debug it!

Fair points. I will go ahead and merge this is and increase the required version numbers.
Finally getting back to testing the plotting of full cubes of EIS data and will open a report on the NDCube when I know more.


SS-28762: Create Infrastructure for supporting different toolbar type modes in Ketcher

This PR adds a new plug-n-play architecture for supporting multiple toolbar type modes in Ketcher, similar to what we currently have in Marvin. This enables us to show only the relevant tools for each user functionality.
As the list of toolbar enums (with the list of functionalities) has not been finalized by product yet, I have exposed dummy toolbar enums ('ABC' and 'DEF' for now)
This modification of toolbar mode can be done via the Ketcher JS API exposed in this PR - ketcher.setToolbarType
Tested it out by triggering this JS API call (through debugger tools) with 'ABC' and 'DEF'.
A follow-up ticket would address replacing the dummy toolbar type enums with actual names.
Primary - @mycrobe

Hi @mycrobe, did you get a chance to check this?


poetry run pytest /test throws ModuleNotFoundError no module named "example"

Following through from this example repository, and in other projects, I am seeing this error when running tests with poetry:
poetry run pytest test/

It gives this error:
ModuleNotFoundError: No module named 'example'

As far as I can see, there is nothing up here. However, any pro-tips as to where I have gone wrong would be amazing.
I have created my components with the poetry poly create command as documented ...

Could it be that you haven't set up the virtual environment?
Run poetry install to add all third-party dependencies (and to make Poetry recognize the folder structure of the repo).
Then you should be able to run poetry run pytest and the Polylith commands, such as poetry poly info.

@DavidVujic So I have run the usually poetry init, poetry shell and poetry install commands.
I have no issue running poetry run mypy . or poetry poly commands, this seems to be the only one that is failing ...

As an example:

My guess is that you have MyPy and pytest installed globally, otherwise the command would fail on "pytest". So, for pytest to be able to run code, that in turn might use third-party libraries, you need to have a virtual environment. That is created by using the poetry install command (only needed once). You will then have a .venv folder along the other folders at your repo root.
The reason that the poly commands work is that you have the Polylith plugin installed globally too - globally, as in where Poetry stores its own dependencies.

Hi @DavidVujic Unfortunately none of that accurately describes my environment, I do not have mypy or pytest installed globally. I develop inside the poetry environment, and have installed all dependencies.

I have also installed the two poetry plugins and developer dependencies inside the environment, and not globally. As I develop inside a containerised environment (for portability within our team).

Here is my repository structure with .venv visible:

Could the issue be in the installed versions of pytest? I see the repo example has version 7, and I have version 8.. ...? 🤔

Maybe we could jump on a call? 📞

Could you share the pyproject.toml file (the packages section in particular), and the workspace.toml file?

From looking at your screenshot from the poly info command, it looks like the components aren't added to the pyproject.toml at the root? That would explain why pytest cannot locate the namespace. The components and bases need to be added in the packages section, for Poetry to recognize them in the virtual environment.

Ok, I have had a little think and a review of everything we do ... I have tried both poetry from a .venv and globally installed inside the container, neither seem to work with this polylithic structure and pytest.
Everything else seems to work, mypy, ruff etc etc
I can see however, inside the test/ folder, the tests that I have aren't showing any types ...
I haven't even got to installing projects or bases yet, so at the moment I just have components as tester to see if this all works well.
RE: poly info command, the components are added to the root pyproject.toml file as follows:
[tool.poetry]
name = "observatory"
version = "0.1.0"
description = "Spaceflux's telescope control system monorepo for managing their global sensor network of astronomical observatories."
authors = ["Michael Roberts<EMAIL_ADDRESS>readme = "README.md"

packages = [
  { include = "observatory/astrometry", from = "components" },
  { include = "observatory/common", from = "components" },
  { include = "development" },
]

[tool.poetry.dependencies]
python = "^3.12"
poetry-multiproject-plugin = "^1.4.1"

[tool.poetry.group.dev.dependencies]
ruff = "^0.3.2"
pre-commit = "^3.6.2"
pytest = "^8.1.1"
poetry-multiproject-plugin = "^1.4.1"
poetry-polylith-plugin = "^1.17.2"
mypy = "^1.9.0"

[tool.pytest.ini_options]
addopts = "-vv"

[build-system]
requires = ["poetry-core"]
build-backend = "poetry.core.masonry.api"

I feel like I have absolutely followed everything by the letter, it's clearly to do with module discovery ...
We are using pytest version 8 and python 3.12 ...

Ok @DavidVujic I am a little further in understanding this, it looks to me that the pythonpath needs to be set for pytest to understand what and where to do ...
Using this:
pythonpath = "components"
Inside the pyproject.toml file gives better output, but how could this be extended to find all in components / bases / projects ...

This goes back to my original issue that I raised as a discussion I think - I fundamentally think the structure you ascribe to is not great. tests should be co-located as best as possible imho ...

This is the first time I have heard about problems with the Python path and the discovery of the components folder, and my guess is that is has to do something with how it is setup in your Docker container. Are you developing inside docker?
When creating a virtual environment, and when you have the package includes setup, poetry will create a ".pth" file to discover the source code. This is the same as with a single-project setup and when using a "src" or a folder with the same name as the project.
If you would try out the example repo as-is on your machine, would the path discovery and pytest work for you?

@michealroberts  Why are you using --no-root? I think that might be the cause actually.

The poetry install --no-root option will not add the paths to the virtual environment, and that explains why the folders aren't discovered. During development, you would want to have the paths added and just run poetry install.

This hasn't much to do with Polylith, but how Poetry resolves paths.
If you would have a single-project repo (i.e. no Polylith) and put code into a src folder, you would run into the same issues:
pyproject.toml
src/
   hello/
      world.py

the pyproject.toml would need to know the structure as described in their docs.
packages = [include = "hello", from = "src"} ]

when using the --no-root you will skip the part when Poetry adds the custom path(s) and probably not what you want to do when having the "src" structure or the Polylith structure.

@DavidVujic I do indeed stand corrected, I assumed that poly was overriding this default path somehow. I shouldn't assume.
You're right on the --no-root flag inside the container, although that is the prescribed way of installing poetry in Docker within their documentation, this does not work well with this structure.

When installing something into production, you are not doing the copy step as Poetry suggests in the docs about CI and Docker. Please have a look in the Polylith docs about how to package a service (using the build-project command).

The reason why we containerise development is to ensure consistency not only between python environments, but developer machines. What runs on one developer's machine might not run on another.

When packaging & deploying something into production, you are not doing the copy step as Poetry suggests in their docs about CI and Docker. Please have a look in the Polylith docs about how to package a service (using the build-project command).

I'll make a mental note of that and be sure to follow the documentation.
RE: poetry plugins, I'll be sure to also amend this. I assumed that as we are using it as a project tool, in development, it should be installed to development dependencies. Otherwise ... how is this portable?
Coming from other languages that have first class support for monorepos has been an eye opener on the conventions used by the python tooling ecosystem ... I wouldn't recommend doing what you're doing, but I would be happy to follow these "conventions". I would strongly argue that not installing tooling to dev dependencies could lead to a gap between team members.

The Poetry plugin feature is specifically for Poetry, and they recommend to install plugins using the poetry self add command. This, because Poetry has its own virtual environment with its own dependencies, separated from the environment the users have. This hasn't anything to do with monorepos, but how the Poetry plugin system is built.
If you develop in Docker, you still can have a project-specific virtual environment and a "global" environment. Global, within the container and a project-specific environment (usually a .venv folder). With this separation, you will have a dev-environment running in Docker in a similar way as having it on a local machine.
The plugins aren't something that is included in the production build of your service or app. Poetry isn't either included in your service or app, these are tools that are used during development and in a CI to test & package things.

Yes, so that's my point, why not install them to developer dependencies? They won't be included in the final built output, and this gives consistent tooling for the project.
My argument isn't the what or how, but the why. You need to deeply think about why you do something, and have it justified for what is best for both the software and the developers building it.
So far, the mental model and burden present just doesn't fit well imho.
If you have people asking what bases and components are, then you probably have your assumptions wrong on the what and the how.

There are alternatives to Poetry, such as Hatch and PDM. There's Polylith tooling for those ones too and they have a different take than Poetry on extending tooling (Hatch and PDM use build hooks instead of plugins).

Yes, so that's my point, why not install them to developer dependencies? They won't be included in the final built output, and this gives consistent tooling for the project.

As I have tried to explain before, this is how Poetry solves it, extending their tool with plugins and how to install them.

My argument isn't the what or how, but the why. You need to deeply think about why you do something, and have it justified for what is best for both the software and the developers building it.
So far, the mental model and burden present just doesn't fit well imho.
If you have people asking what bases and components are, then you probably have your assumptions wrong on the what and the how.

There are various ways to accomplish code sharing in a Monorepo, or using a several-different repos approach and share code via installable libraries. Polylith has a different take on this thing. It's not that complex, having code in two folders (bases and components) is it?

I'll close this issue. I think this is an interesting conversation, but also think the issue is solved (the --no-root option). There is the Discussions forum at the Polylith github, where we could continue talk about the parts that aren't the traditional issues (i.e. things broken needed to to fix or problems to solve).

Happy to resolve also, I think there's a lot of strengths of this project and clearly a lot of thought has gone into it. So happy to amend my mental models.
Will sync up in discussions if we need anything else.


can not access ngx.var.upstream_response_time

Can I access ngx.var.upstream_response_time with this module? just like lua-nginx-module https://github.com/openresty/lua-nginx-module#log_by_lua
now I get nil:
failed to run log_by_lua*: /usr/local/openresty/nginx/app/stats.lua:4: attempt to concatenate field 'upstream_response_time' (a nil value)

False question, just see that stream upstream module doesn't have this var http://nginx.org/en/docs/stream/ngx_stream_upstream_module.html


user.avatar returns nil

(lldb) p user.rawResponse.hdProfilePicVersions.array
([SwiftyInsta.DynamicResponse]?) $R8 = 2 values {
  [0] = dictionary {
    dictionary = 3 key/value pairs {
      [0] = {
        key = "height"
        value = number {
          number = 0xf0c1170ab455ee27 Int64(320)
        }
      }
      [1] = {
        key = "url"
        value = string (string = "https://scontent-lht6-1.cdninstagram.com/v/t51.2885-19/s320x320/46361553_356999201721545_4488569793045069824_n.jpg?_nc_ht=scontent-lht6-1.cdninstagram.com&_nc_ohc=OTtfnwxlEUYAX-TfSkQ&oh=4351f903d25a25311190e5775c485d34&oe=5ED948C2")
      }
      [2] = {
        key = "width"
        value = number {
          number = 0xf0c1170ab455ee27 Int64(320)
        }
      }
    }
  }
  [1] = dictionary {
    dictionary = 3 key/value pairs {
      [0] = {
        key = "height"
        value = number {
          number = 0xf0c1170ab455d227 Int64(640)
        }
      }
      [1] = {
        key = "width"
        value = number {
          number = 0xf0c1170ab455d227 Int64(640)
        }
      }
      [2] = {
        key = "url"
        value = string (string = "https://scontent-lht6-1.cdninstagram.com/v/t51.2885-19/s640x640/46361553_356999201721545_4488569793045069824_n.jpg?_nc_ht=scontent-lht6-1.cdninstagram.com&_nc_ohc=OTtfnwxlEUYAX-TfSkQ&oh=a816bd28e587758d0662aa6a7e7f180a&oe=5EDA4A2F")
      }
    }
  }
}

 p user.avatar
(URL?) $R6 = nil

this part does work:
(lldb) p user.rawResponse.hdProfilePicVersions.array?.max(by: { ($0.width.double ?? 0) < ($1.width.double ?? 0) && ($0.height.double ?? 0) < ($1.height.double ?? 0)})
(SwiftyInsta.DynamicResponse?) $R34 = dictionary {
  dictionary = 3 key/value pairs {
    [0] = {
      key = "height"
      value = number {
        number = 0xc6cbdcdcd2e82234 Int64(640)
      }
    }
    [1] = {
      key = "width"
      value = number {
        number = 0xc6cbdcdcd2e82234 Int64(640)
      }
    }
    [2] = {
      key = "url"
      value = string (string = "https://scontent-lht6-1.cdninstagram.com/v/t51.2885-19/s640x640/46361553_356999201721545_4488569793045069824_n.jpg?_nc_ht=scontent-lht6-1.cdninstagram.com&_nc_ohc=OTtfnwxlEUYAX-TfSkQ&oh=a816bd28e587758d0662aa6a7e7f180a&oe=5EDA4A2F")
    }
  }
}

Something is wrong with url

url find a dictionary and does :
p self["url"].url
(URL?) $R10 = nil

    /// `URL` if `.url` or `nil`.
    public var url: URL? {
        switch self {
        case .string(let string): return URL(string: string)
        case .dictionary(let dictionary): return dictionary["url"]?.url
        default: return nil
        }
    }

(lldb) p self["url"]
(SwiftyInsta.DynamicResponse) $R8 = string (string = "https://scontent-lht6-1.cdninstagram.com/v/t51.2885-19/s640x640/67066289_448226695780025_1481237115474804736_n.jpg?_nc_ht=scontent-lht6-1.cdninstagram.com&_nc_ohc=VIrJ2KYfswsAX_6C0Rj&oh=14e7c5412c1281383aa90e3a7432eb30&oe=5ED95B79")

It seems to be a bug in lldb

Does this happen on the last version? Cause I feel like it was something I had addressed exactly by doing:
    /// `URL` if `.url` or `nil`.
    public var url: URL? {
        switch self {
        case .string(let string): return URL(string: string)
        case .dictionary(let dictionary): return dictionary["url"]?.url
        default: return nil
        }
    }

Is there's something that needs fixing? Cause it's not really clear? 😅 @mycroftcanner

@sbertix there really is a problem with lldb showing the result of URL(string: x) as always nil.
The problem I noticed is that some old IG profiles do not have hdProfilePicVersions. They only have hdProfilePicUrlInfo or profilePicUrl.

Okay, so it's not in the "url" bypassing thing per se, at least.
I'm definitely gonna work on a PR adding the  fallback values for "non-hdProfilePicVersions" profiles.
Thanks for pointing this out man 💪

Here is a quick fix:
    public var avatar: URL? {
        guard rawResponse.hdProfilePicVersions != .none else {
            return rawResponse.hdProfilePicUrlInfo.url ?? rawResponse.profilePicUrl.url
        }
        return rawResponse.hdProfilePicVersions
            .array?
            .max(by: {
                ($0.width.double ?? 0) < ($1.width.double ?? 0)
                    && ($0.height.double ?? 0) < ($1.height.double ?? 0)
            })?
            .url
    }

#192 falls back to rawResponse.hdProfilePicUrlInfo.url for nil rawResponse.hdProfilePicVersions.
I didn't feel like adding rawResponse.profilePicUrl.url too, cause avatar is supposed to be high quality and when an improved version of thumbnail cannot be found, we should just be clear about it, and just fallback explicitly user.avatar ?? user.thumbnail.

rawResponse.hdProfilePicUrlInfo.url is still returning nil because the dynamic url getter is being prioritized over the dynamic member lookup for the key url. This fails because hdProfilePicUrlInfo is a dictionary and not a valid url type.
Easy fix: rawResponse.hdProfilePicUrlInfo["url"]
@sbertix

That should be taken care by the implementation of url in DynamicResponse… 🤔
Is it not? @leftyfl1p
    /// `URL` if `.url` or `nil`.
    public var url: URL? {
        switch self {
        case .string(let string): return URL(string: string)
        case .dictionary(let dictionary): return dictionary["url"]?.url
        default: return nil
        }
    }

Ok, I swear I'm not delusional and that this has failed during runtime, but now I can't reproduce it although lldb really does not like this
(lldb) e user.rawResponse.hdProfilePicUrlInfo["url"].url
(URL?) $R6 = nil
(lldb) e user.rawResponse.hdProfilePicUrlInfo.url
(URL?) $R8 = nil
(lldb) e user.rawResponse.hdProfilePicUrlInfo["url"]
(SwiftyInsta.DynamicResponse) $R10 = string (string = "https://scontent-lax3-1.cdninstagram.com/v/t51.2885-19/11849886_476740042494531_1297379791_a.jpg?_nc_ht=scontent-lax3-1.cdninstagram.com&_nc_ohc=MxYHw-ZdUtIAX8Id7Ho&oh=df86770845f84c88ed13551561cb9772&oe=5EFB2F98")
(lldb) e user.avatar
(URL?) $R12 = nil

Still scratching my head.


Kubernetes and Go blog post

It looks like Eric's suggested changes were reverted somehow in a later commit. Hold off on merging until we make sure all the suggested edits are present.


jQTouch Gallery issues

Hey guys, im getting some noob issues here. Im setting my gallery with the jqt.generategallery, but how can i activate it automatically without clicking on a link? I mean, activate it when the page loads?
Thanks!

Is this using a third party plugin? We don't officially offer support for them here :/


watcher is undefined in close()

What version are you using? (Don't say latest. Be specific.)
Latests 😄 0.6.2.
Expected result
Call close() before watch() without an error.
Actual result
TypeError: Cannot read property 'close' of undefined

Steps to reproduce issue
It looks like watcher is set when watch() is called. But I call refresh() manually and don't use watch(). However I'd like to close the server with close(). Currently this throws, because it expects watcher to be set.
Why is this important?
I use refresh() manually and inside a webpack build and don't use watch().

@donaldpipowitch thanks for reporting this. 0.6.3 was released to npm.

Thank you for the fix! ♥


CollectAs and CollectDistinctAs returns IEnumerable instead of IEnumerable<Node>

As commented on issue #17 these aggregates should return IEnumerable instead of the collection of node references.
However this pull request depends on the changes made by the transaction pull request. This commit should automatically refresh if that other pull request is accepted.
Pull request updates are going to be to include more unit tests.

Please see Transactions Pull request :)


Revert "feat(checkout): CHECKOUT-6655 Make screen reader say each shipping fo…"

Reverts bigcommerce/checkout-js#876

hey @huntario we had to revert this since it caused the functional test suite to fail.

Thanks for reverting, I'll take a look.


Fix panic in PFS cron commits

Wait so did this mean that any time you tried to restart a cron that had previously been running it would segfault? It seems a little hard to believe that was the case and we hadn't noticed... but that's what the code seems to suggest. Anyway, definitely LGTM.


Fix the Psoc64 MTB project BLE demo build failure.

Checklist:

[x] I have tested my changes. No regression in existing tests.
[ ] My code is Linted.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/bot run checks

/cbmc run checks

/cbmc run checks

/cbmc run checks

/cbmc run checks

/cbmc run checks

/cbmc run check

/cbmc run checks

Re-triggered the CBMC checks.


chore: generate a code coverage badge

With this PR a code coverage report is generated, and a beautiful badge is updated with the code coverage percentage.

No stale PRs 🏄


Armed M40 Grenades can be inserted into the U1 Grenade Launcher, functionally breaking the weapon

Description
You can load an M40 HEDP that has been armed into the breech of the U1 grenade launcher. If the grenade explodes while inside the breech, the ammo will not be subtracted, and that slot will never be refillable with a grenade ever again, effectively decreasing the amount of grenades it can carry. If the armed grenade that was loaded was the final one, the attachment will cease all function entirely.
Reproduction

Activate U1 grenade launcher attached to an M54C
Open the breech
Arm an M40 grenade
Insert the armed M40 grenade into the breech
Wait for the explosion
The bugged state is achieved

Screenshots
Reproduction video
https://github.com/user-attachments/assets/bedb782d-81c3-4b26-b86e-0d27f45001ba

this is for every grenade launcher


Pub2

👷 Deploy Preview for crpp-ai-oncology-zurich processing.

Name
Link

🔨 Latest commit
ec1296a91b062222c4b0f02756397f3886ea105c

🔍 Latest deploy log
https://app.netlify.com/sites/crpp-ai-oncology-zurich/deploys/656e1ef773d96f00088e3d39


Fix issue 14519:Parsing a GetResult returns NPE if found field is mis…

…sing. Signed-off-by: Vatsal<EMAIL_ADDRESS>
Description
GetResult.fromXContentEmbedded() throws NullPointerException when invoking GetResult constructor if the field "found" is null. Added a null check on this field before invoking the GetResult constructor. In case, it is null, it throws a Parsing Exception with message "Missing required field [found]".
Related Issues
Resolves #[14519]

Check List

[x] Functionality includes testing.
[ ] API changes companion pull request created, if applicable.
[ ] Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@dbwiddis
Please review.


belindas-closet-android_4_176_modify-product-update-page

Resolves #176
This PR modifies the product page so that pressing the edit button on the Product Details page redirects to the Update page where there is a delete button for each product in the category. The admin can then scroll and delete products one by one.

For manual testing purposes, update the handbag in the 'Accessories' category to be a 24-character hex string as the id in Datasource.kt because MongoDB generates the ObjectId in this format (will otherwise throw an invalid id error).
Related to User Story #183

This works well for me. It makes it easier to delete multiple products at the same time.


feat(fromDOM): add fromDOM source

Coverage decreased (-1.5%) to 77.688% when pulling 555165d961f1465426d12367fcc62b5574b24e7c on from-dom-event into 967e6a3abe7c1eb04469cec3eddb8c64bb154a7f on master.


Make an ingress optional when managing routes

We haven't set up GitHub => Tracker integration yet. I manually created #159885478.

@viovanov Thx for the PR!
We had the chance to review it finally. A few things changed in the meanwhile and it requires a rebase of develop. The key change we did that is affecting your PR is:

The route-emitter doesn't require the ingress anymore. So all changes to the route-emitter are actually not required anymore.

Generally, we couldn't find any unit-test. Could you please add them to your PR? We will add some contribution guidelines to our repo too.

@gdankov updated the PR based on your comments
cheers!


fix schema GetIdentityFieldValuesMap interface or ptr

[ x ] Do only one thing
[ x ] Non breaking API changes
[ x ] Tested

What did this pull request do?
我的使用场景遇到了 类型为 interface 的问题
User Case Description
使用 reflect 构建的 model 对象在 Find 中 Preload 失效
https://github.com/go-gorm/gorm/issues/6416

I had the same problem, just tested the patch, it works well !
Do you think you can merge the PR soon ?
Thanks in advance !


Deprecation warning in Angular 12

Bug Report
When building my library application i'm getting a new deprecation warning after updating to Angular 12.
*My warning message (local folders):
(node:9872) [DEP0148] DeprecationWarning: Use of deprecated folder mapping "./" in the "exports" field module resolution of the package at C:\g\LogicmediaAngularNpm\logicmedia-angular\library-container-project\projects\logicmedia-angular\node_modules\tslib\package.json.
Update this package.json to use a subpath pattern like "./*".
I'm using<EMAIL_ADDRESS>and Angular 12.1.1
I'm compiling my Angular library application using Ivy partial compilation mode.
🙁 Actual behavior
The application builds and my npm package can be published.
🙂 Expected behavior
Angular not showing these red lines when building.

Added in the wrong repo


multiple threads for mapping multiple species

Hello,
I'd like to use multiple threads for mapping multiple species on clusters using the option --single_mapping
but I don't understand what should be in the "Singe species file allowing to map in a job array" means.
Could you please give an example with the command line?
Thank you very much in advance!

Dear @Yuqia
Thanks for contacting us.
For running read2tree on cluster with multi-threads and multi-species, you can consider each following line as a job:
read2tree --standalone_path marker_genes --output_path output --reference --dna_reference  dna_ref.fa
read2tree --standalone_path marker_genes --output_path output --reads species1_R1.fastq species2_R2.fastq  --threads  30
read2tree --standalone_path marker_genes --output_path output --reads species2_R1.fastq species2_R2.fastq  --threads  30
read2tree --standalone_path marker_genes --output_path output --reads species3_R1.fastq species3_R2.fastq  --threads  30
read2tree --standalone_path marker_genes --output_path output --merge_all_mappings --tree

Once the first one is finished, the line for each species can be submitted as a separate job.
After finishing  all species, you can run the last line to infer the tree including all species.
We'll improve the documentation for that option.  Please let us know whether this answers the question.
Best regards,
Sina

Dear Sina,
Many thanks for your reply. Does this mean that each species is mapped sequentially using multiple threads instead of multiple species are mapped simultaneously using 1 thread per species?
Best,
Yuqia

You're welcome. Each species is mapped separately using multiple threads.

Thanks a lot Sania! All is clear.


Rename ring-sgx's links value

Proposal: rename the links value in ring-sgx's Cargo manifest (https://github.com/mesalock-linux/ring-sgx/blob/master/Cargo.toml#L16) from "ring-asm" to "ring-sgx-asm".
According to Cargo book:

Cargo requires that there is at most one package per links value. In other words, it’s forbidden to have two packages link to the same native library.

I believe it's a common use-case to compile the same Rust code for sgx and non-sgx environments based on a feature flag. This means having ring and ring-sgx as dependencies in the same Cargo workspace. Currently, that's not allowed since Cargo thinks both of these crates are attempting to link to the same native library.

Hey, I totally understand your concern, and I think it really makes sense. But the "same linking name" failure can help with finding the collisions. For example, if an enclave brings in the regular upstream "ring" with no_std enabled, as well as ring-sgx at the same time, the collision failure would find this. So I think this may help with finding all such collisions. What do you think?

For the scenario you mentioned, Cargo wouldn’t allow it anyways unless either upstream ring or ring-sgx was explicitly renamed using the package key.
Also, if I have 2 separate libraries in the same Cargo workspace, I should be able to use ring in one and ring-sgx in the other.

got it. let me fix it now.

fixed in https://github.com/mesalock-linux/ring-sgx/commit/a871a4ef683480750dce65d7c893c2911629bbdd

thanks!


rework integration tests to be driven by tinygo test

Integration tests were previously driven by a Javascript-based GitHub
Action.  These ended up being pretty flaky and were not easy to run
locally.  As a result, they were difficult to write and folks waited
until CI to see if they passed.
Viceroy (as of 0.4.0 or so) can act as a test runner by passing in a
.wasm file in a special run-once mode.  Combined with a special TinyGo
target config (compute-at-edge.json) that uses this Viceroy mode as the
"emulator", we can run the integration tests with tinygo test like so:
tinygo test -target=compute-at-edge.json ./integration_tests/...

The tests are build flagged so that they aren't run outside of a WASI
environment, so doing things like go test ./... won't attempt to run
them.
The integration tests themselves have been changed so that they contain
not only the handlers but also calling the handlers and checking the
results.  The expected results were previously defined in a JSON file
and checked by the JS runner.
A lot of the churn here is removing the old github action, and moving
the integration tests from _integration_tests to integration_tests
so that they are picked up by tinygo test.
The rtlog integration test was the only one that was dropped.  Because
the tests don't have visibility into the Viceroy runtime, it's not
possible to capture the logs.

New backend integration test is failing because Viceroy is erroneously returning Inval when it should return None for its internal ValueAbsent error.  https://github.com/fastly/Viceroy/pull/291


video_player plugin needs to more explicitly state it supports Web in the README.

Steps to Reproduce
The first sentence of the README of the video_player plugin seems to suggest that the plugin only supports iOS and Android.
It should be updated to reflect that the plugin also supports the web platform.
Reported by: @mariamhas

The fix for this issue has been published.


Reviving Add BuildProgressPlugin

Is this a bug report?
No
I was just wondering if there was any interest in reviving the Add BuildProgressPlugin PR that got closed back in January, 2019
I believe @Timer had it working but wasn't happy with the progress accuracy -> is this still true? not sure if anything has changed but to me it seems like something would be better than nothing
anyone else interested in this? I could try and revive the PR again at some point in the next few weeks

I'll let @Timer chime in on this one, as I wasn't across it in detail. If there's a newer, more accurate version, that could also be good to discuss.
By the way, "back in January, 2019" is scary to say so soon ;)

You caught me :-) January 2018

@Timer what do you think? Do you want @maniax89 or me(I hope its ok Andrew) to start working on it?

I'm fine with you working on it @eladmotola

I never got a chance to work on it but would like this to stay open

I'm going to label this as "Up for grabs" unless you think you'll have time to work on it in the near future.

I'd like to dig into this if possible. Would acceptance criteria for this look like getting the webpack ProgressPlugin to work?

I just learned that enabling any of these progress plugins introduces a significant performance penalty in webpack. They all require webpack to emit progress information during the build and that slows things down quite a bit. I don't think it's worth it just to display a progress bar so I'm going to close this issue.


Adding Example of modules with deploying web application with log analytics

Broke down existing web-app-loganalytics example to use modules.

Codecov Report

Merging #1200 (ecd58d8) into main (a514ee9) will increase coverage by 0.46%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1200      +/-   ##
==========================================
+ Coverage   94.49%   94.95%   +0.46%
==========================================
  Files         336      332       -4
  Lines       16825    16666     -159
  Branches       14        0      -14
==========================================
- Hits        15898    15826      -72
+ Misses        927      840      -87

Flag
Coverage Δ

dotnet
94.95% <ø> (-0.08%)
:arrow_down:

typescript
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...cep.Core.UnitTests/FileSystem/FileResolverTests.cs
79.31% <0.00%> (-20.69%)
:arrow_down:

.../Bicep.Core.UnitTests/Assertions/BaselineHelper.cs
63.63% <0.00%> (-15.91%)
:arrow_down:

src/Bicep.Core/FileSystem/PathHelper.cs
96.15% <0.00%> (-3.85%)
:arrow_down:

src/Bicep.Core.UnitTests/Utils/CompilerFlags.cs
33.33% <0.00%> (ø)

...Bicep.Core.UnitTests/FileSystem/PathHelperTests.cs
100.00% <0.00%> (ø)

src/vscode-bicep/src/utils/logger.ts

src/vscode-bicep/src/language/client.ts

src/vscode-bicep/src/utils/telemetry.ts

src/vscode-bicep/src/extension.ts


[question] My switch does not work in v7.0.0 and later versions.

Hello.
First of all, I apologize for my poor English.
SWITCH : Dawon DNS Zwave Switch
I am inquiring because the switch that worked well before zwavejs2mqtt v6.14.1 has not been working since the update.
v6.14.1 and earlier debug log (work good)
2022-09-29 08:40:50.575 INFO ZWAVE: Node 39: value updated: 37-1-currentValue false => true
2022-09-29 08:40:50.581 INFO ZWAVE: Node 39: value updated: 37-1-targetValue false => true
2022-09-29 08:40:50.615 INFO ZWAVE: Node 39: value updated: 113-1-alarmType 0 => 0
2022-09-29 08:40:50.619 INFO ZWAVE: Node 39: value updated: 113-1-alarmLevel 0 => 0
2022-09-29 08:40:50.639 INFO ZWAVE: Node 39: value updated: 113-1-Power Management-Mains status 2 => 3
2022-09-29 08:40:52.986 INFO ZWAVE: Node 39: value updated: 37-1-currentValue true => true
v.7.0.0 and later versions debug log (not work)
2022-09-28 16:54:41.269 INFO Z-WAVE: Calling api writeValue with args: [
{
nodeId: 39,
commandClass: 37,
endpoint: 1,
property: 'targetValue'
},
true,
{},
[length]: 3
]
The sensor values for that switch are displayed well.
Is there anything I need to check? Is there any more information I need to tell you?
Thank you.

Please try to re-interview your device

Please try to re-interview your device

I tried it several times, but it didn't work.
exclusion and Inclusion same.

@jsj0318 Try uploading driver logs so please


DEPS.xwalk: Roll blink-crosswalk (59d6385 -> b699def).

b699def Merge pull request #70 from rakuco/webcl-move-webclexception-to-core
e6ccb69 WebCL: Move WebCLException to core/webcl.

lgtm


Problem Running Notebook

from SimPEG.EM.Static import SP appears not available
And couldn't find it on SIMPEG documentation either. Please provide a work around

Try running on the SP-spherical branch. @sgkang

Thank you Craig for your reply.
Please where do I find Spherical Branch you referred to. Could you share a link to it? Do I need to make additional installation on my SIMPEG? Please provide detail


Always take first item in Sparkle strategy.

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same change?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests for your changes? Here's an example.
[ ] Have you successfully run brew style with your changes locally?
[ ] Have you successfully run brew typecheck with your changes locally?
[ ] Have you successfully run brew tests with your changes locally?

Always take the first (i.e. latest) item. From what I've seen it is more likely that the BundleVersion#version (most often build number) of an older item is higher rather than a newer item being for a legitimate older version (i.e. a patch update for a previous major version).

Review period will end on 2021-04-15 at 23:20:46 UTC.

Review period ended.

@reitermarkus this may have caused some unforeseen issues; for example:
|-> brew livecheck iina mathpix-snipping-tool rectangle vlc
iina : 1.1.2,128 ==> <IP_ADDRESS>,55
mathpix-snipping-tool : 3.1,202 ==> 2.0,94
rectangle : 0.45,50 ==> 0.27,32
vlc : 3.0.12 ==> 1.1.3

@miccal, that's why I marked it “do not merge”.

@miccal, that's why I marked it “do not merge”.

Apologies @reitermarkus, I am not sure how I missed the do not merge label.


[Question] register and login via passport

Hi Guys,
Loving this module, great work.  Super excited to be building with it.
Have seen a few people asking about using passport and have checked the demo app, but you've left user creation and login to the default laravel frontend.
I initially started this project without your module and have created separate API controllers to create and and login users with passport tokens but would be nice to incorporate these controllers into the JSON-API routes.    Do i just create a custom Auth controller and adapter? And what would go in the config.resources array as Auth does't have a model to reference.
any tips gratefully received.

You can write custom adapter for tokens resource and implement create method with authentication service call.

You can write custom adapter for tokens resource and implement create method with authentication service call.

So would I need to create a Tokens Model? or can that just be ignored in the config file?

So would I need to create a Tokens Model?

You may use Laravel\Passport\Token model.

Closing this issue for the mo, as I think the question has been answered.


Enable KMS and SQS managed server side encryption for SQS queues

Open state for enabling server side encryption of SQS queues using either KMS or an SQS managed key.
Related documentation:
https://docs.aws.amazon.com/AWSSimpleQueueService/latest/SQSDeveloperGuide/sqs-server-side-encryption.html
https://docs.aws.amazon.com/sdkfornet/v3/apidocs/items/SQS/TQueueAttributeName.html
https://docs.aws.amazon.com/AWSSimpleQueueService/latest/APIReference/API_CreateQueue.html
Unit tests currently aren't possible because localstack doesn't support setting these specific queue attributes

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

This looks good to me. Thanks!!


pkg/netutil: add linux netem functions

This is useful for simulating bad networks by introducing
latencies to wide area networks.
Reference:
http://www.linuxfoundation.org/collaborate/workgroups/networking/netem
For https://github.com/coreos/etcd/issues/4666.

Quick demo:
ping google.com

# add rules
sudo tc qdisc add dev eth0 root netem delay 100ms

# describe rules
tc -s qdisc

ping google.com

# delete rules
sudo tc qdisc del dev eth0 root netem

@xiang90 All addressed. PTAL. Thanks!

lgtm

Thanks. Merging in greens.


Adding conditional steps to release tag and master branch & adding a …

…secret config to openshift applier if pushing to quay

Ready to review. I added two conditional steps:
release tag
master branch
In order to push it to quay I added a secret entry in the openshift applier.
*The secret was created manually on S11
Quay repo is just a "fake". Once that we have it the correct Quay repo, we can change it.


cannot use "as" in

Vue version
3.2.37
Link to minimal reproduction
https://stackblitz.com/edit/vitejs-vite-jjfqgw?file=vite.config.js,src%2FApp.vue&terminal=dev
Steps to reproduce
<script lang="tsx" setup>
编译出错 (Compile error)
<script lang="ts" setup>
编译正常 (Compile successfully)
What is expected?
jsx 可以正常编译 (Compile successfully with jsx)
What is actually happening?
在本地报错 (in local)

在 StackBlitz 报错 (in StackBlitz)

System Info
No response
Any additional comments?
No response

duplicate of #5764

This is a bug. It was raised three months ago, and there is no intention to solve it until now.


More flexible cluster configuration

resolves #444

Description

When using notebook submission, if job_cluster_config is specified, we will run that model with a job_cluster.
This PR also makes user being able to specify a separate cluster_id or job_cluster_config for each individual model through config.
job_cluster_config will overwrite cluster_id in current situation.(if job_cluster_config is set for a model, we will always use it).
This PR also removes the need for user and put dbt model files under /dbt_python_mode/{$SCHEMA} in Databricks workspace

Checklist

[ ] I have read the contributing guide and understand what's expected of me
[ ] I have signed the CLA
[ ] I have run this code in development and it appears to resolve the stated issue
[ ] This PR includes tests, or tests are not required/relevant for this PR
[ ] I have opened an issue to add/update docs, or docs changes are not required/relevant for this PR
[ ] I have run changie new to create a changelog entry

`job_cluster_config` will overwrite cluster_id in current situation.(if job_cluster_config is set for a model, we will always create a job cluster for that model, regardless of cluster_id).

@jtcohen6 @lostmygithubaccount is the current overwriting logic odd?


add log collection

Implements a log collection system based on async task name.

Codecov Report
Attention: Patch coverage is 87.50000% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 73.51%. Comparing base (ed37be4) to head (11eb7c5).

Files
Patch %
Lines

taskiq/cli/worker/log_collector.py
86.04%
6 Missing :warning:

taskiq/result/v1.py
0.00%
3 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #306      +/-   ##
===========================================
- Coverage    78.00%   73.51%   -4.49%
===========================================
  Files           61       61
  Lines         1791     1824      +33
===========================================
- Hits          1397     1341      -56
- Misses         394      483      +89

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

I have realized that this is not useful. It will only collect logs from the taskiq.tasklogger logger, not any modules that it calls. Celery essentially does the same thing with its get_task_logger function. However, Celery also implements something you can use to set up loggers to get imported modules to log with a Celery task ID: after_setup_logger.connect in conjunction with get_current_task. Maybe we should look into implementing something like this for Taskiq. I have no clue how that would be possible in an async environment, but it would unlock some good potential.


TypeScript support. Doc comment.

Don't scare ... just consider to define types. There are multiple ways.
Doc comments are useful with or without TypeScript. Definition files (*.d.ts) can be generated from this comments and the current source code. Or we could move to TypeScript. Ideas are welcome.
Current Alternative
DefinitelyTyped
Types from @types are mostly a gambling game. Because in most cases they are not synchronized and hand crafted. And you have one more dependency. I would prefer a build-in solution. Many libraries already have this. It's optional and separated. It will not blow up the build size.

It was inevitable this was going to come up. I do support our TypeScript overlords, however due to the current engine architecture, it would need a complete re-write to get it working properly. I'll tag it for now for consideration when the next major release is in the works.

It was inevitable this was going to come up. I do support our TypeScript overlords, however due to the current engine architecture, it would need a complete re-write to get it working properly. I'll tag it for now for consideration when the next major release is in the works.

Is it possible to participate in this?


Fix updateChecksum logic to use installed_rank as well as version. Fixes, #1262.

Modified the update checksum logic to now use version and installed_rank when updating checksum as part of DB repair.
For ALL of the DBs that flyway supports installed_rank is a PRIMARY KEY and cannot be NULL so this should be acceptable (unless I've missed a scenario). This should work for Repeatable migrations as well.
Alternative solution to #1263.
Fixes, #1262
@axelfontaine & @jmahonin please review.

Changes look good on the Phoenix side. I'll defer to @axelfontaine for comment on the Flway changes.
Thanks @anirudha13

@axelfontaine please review when you have a chance.

@axelfontaine any update on this?

Sorry about the delay in reviewing this. I just had a look at it and I don't believe this is the desired behavior. By definition the checksum of repeatable migrations can change over time (the checksum change is the trigger that indicates they need to be rerun). Therefore I don't feel it makes sense to update the existing checksums for repeatable migrations as part of a repair operation.

That's a good point, @axelfontaine. It was my understanding that the version of the repeatable resolved migration would be null. Let me check this once again.

@anirudha13 Any updates on this? Let me know if I can do anything here.

@jmahonin sorry was caught up with a couple of things, I need to recreate my dev environment. Target getting to this, sometime this week or early next week.

@axelfontaine , @jmahonin please re-review the changes. Have added a unit test that ensures that repeatable migrations are not affected.

LGTM, nice work

@axelfontaine any chance you could take a look at this next week?

bump, @axelfontaine

Sorry about the delay. Could you update it to make it mergeable again?

@anirudha13  Could you update this PR to make it mergeable again?

Closing due to lack of response.


Instrumented Netty

We'd like to use Netty in our Apache Camel app, but we're using Jetty for now as it has a Codahale-Metrics-instrumented version..
I'm happy to contribute this code to the project, but wanted (before embarking on the task) to check there was an appetite for this, and to see if anyone could provide a list of the classes, and instrumentation in the Netty codebase which I should look at.
I'm assuming following the instrumented-Jetty method of providing alternative jar(s) named metrics-* would be attractive.
Kind regards, Andrew

Apologies, I just saw this: https://github.com/netty/netty/issues/922  Does that mean this has been resolved and we're just missing the documentation?

@andrewharmellaw no it was not resolved... We did not really come to an "agreement" on how and what to instrument.

Thanks for your reply @normanmaurer . Is this something there is an appetite to pick up again?  As I said, I'd be willing to contribute this (though I'm not au-fait with the Netty architecture so would need a few pointers as to what to instrument and in what way.)

@andrewharmellaw sorry for the late response but we would love to add some thing like instrumentation. @Scottmitch @nmittler @trustin agree ?

@andrewharmellaw @normanmaurer - Yes sounds good to me ... I this it would be good to discuss overall approach / API before digging into the implementation for this one.

Sounds great guys. I've not put a great deal of thought into this, but the idea was to echo what you get with the metrics-intstrumented netty.  Thats from a consumer perspective however - the internals will likely be wildly different.  Please let me know how I can help / contribute in this discussion.

And https://github.com/netty/netty/issues/6523 from Mar 2017, not JMX support yet?


Auto Incrementing Number Provider or Range of Numbers?

Is there an Auto Incrementing Number Provider or even better would be auto increment but allow a start number to start from instead of always 0?

No. The implementation is left as an exercise for the reader.


Rebuilt into separate C and Python packages

This recipe now provides the following

lalmetaio: just the C package including headers and SO libraries
python-lalmetaio: just the python bindings and extras for the given python version

Checklist

[x] Used a fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[x] Re-rendered with the latest conda-smithy
[x] Ensured the license file is being packaged.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@skymoo, any thoughts?

Looks good to me.


Bugfix: socket is leak on IPv6 testbed

Agent sends IPv6 Gratuitous NDP packet on each Pod to broadcast its
address. The socket is not closed after sending packet, which introduces
socket leak.
To resolve the issue, adding a defer function to close the socket after
writing the packet into the connection.
Fixes #4086
Signed-off-by: wenyingd<EMAIL_ADDRESS>

/test-all
/test-ipv6-all
/test-ipv6-only-all

/test-ipv6-networkpolicy
/test-ipv6-only-networkpolicy

/test-flexible-ipam-e2e


Test refactoring

TestCase method not used properly
for example:
[self assert: (self endPoint ping)] 		on: Exception  		do: [ ^ self ]. 	self fail
self should: (self endPoint ping) raise: Exception
self assert: (self endPoint logout) = true.
self assert: (self endPoint logout) equals: true
or even better: self assert: (self endPoint logout).

refactored all tests.


ThresholdSignatureCircuitImplZendoo.signaturePlaceHolder multiply free supporting

From comment to https://github.com/ZencashOfficial/Sidechains-SDK/pull/117/files/eb49acc0e6ca39b71020212f77b224186de8422d#diff-16ea5a9eedc16ff422536088f76491e3 :
albertog78
this is quite tricky solution because you rely on the fact that signaturePlaceHolder will support multiple "free" invokes. It would be safer to instantiate in any case a new placeholder in case of no signature

@albertog78 There is no problem in case if zendoo_sc_cryptolib directly support multiply free for empty schnorr signature new SchnorrSignature(). For example, if the class description directly describes the possibility of multiply free, thus only appropriate description could be added, to avoid unnecessary objects creation.


build flag new and cross build status

 update the build docs and shell / scripts for the current software
this are the items

git clone ...microsoft/vscode
cd vscode
yarn
yarn watch
the command need to be updated
yarn does not take vscode (arg) via cli
the ./script/npm.sh does take (arg) -flag
yarn -arm64 fails
./script/npm.sh -arm64 works it is now building
this flag -arm64 is critical for the build CPU and OS
ARM 64 is now building
the yarn gulp task are ;
Gulp tasks
vscode-reh-linux-armhf-ci, vscode-reh-linux-armhf-min, vscode-reh-linux-arm64-ci, vscode-reh-linux-arm64, vscode-reh-linux-arm64-min-ci, vscode-reh-linux-arm64-min, vscode-reh-web-linux-arm64-min, vscode-win32-arm64-ci, vscode-win32-arm64, vscode-win32-arm64-min-ci, vscode-win32-arm64-min, vscode-linux-x64-ci, vscode-linux-x64-min, vscode-linux-armhf-ci, vscode-linux-armhf, vscode-linux-armhf-min-ci, vscode-linux-armhf-min, vscode-linux-arm64-ci, vscode-linux-arm64, vscode-linux-arm64-min-ci, vscode-linux-arm64-min, vscode-linux-x64-build-deb, vscode-linux-armhf-build-deb, vscode-linux-armhf-build-rpm, vscode-linux-arm64-build-deb, vscode-linux-arm64-build-rpm, vscode-linux-arm64-prepare-snap, vscode-linux-arm64-build-snap
attached is my writeup

vscode.txt
so finding 2
The x64 build  cross build yarn gulp vscode-linux-arm64 builds the package , when the command code-oss is entered, reset the machine take place. chroot and chrome book, the same as the binaries from vscode market
the x64 build on x64 machine  yarn gulp vscode-linux-x64 work on the command code-oss functions the app works fine
the arm64 build via ./scripts/npm.sh -arm64 is now building so i report back

Update
the code-oss built with ARM however no change the machine resets, I have complied new nodejs v16.15.0 code and will try this same the x64 machine, Arm64 compiles now with no errors what the flag -arm64 on .script/npm.sh -arm64
also code-oss --debug to see what happens
i will also try a x64 build on the arm64 the cross complier is installed
I have no idea what the gulp tasks are maybe the readme will be updated
The x64 code runs great web extension are working now with a new product.json file the whole resources app folder is new

Here are the cross compile instructions which I don't think you're following based on what you're running: https://github.com/microsoft/vscode/wiki/Cross-Compiling-for-Debian-Based-Linux
This is how we do macOS cross compiling: https://github.com/microsoft/vscode/blob/98d9782b8bc77891135a5b295c9489e7ddf0d2a4/build/azure-pipelines/product-build.yml#L328-L398, we do not provide support or instructions for how to do this but how we do it is there.

I have no idea what the gulp tasks are maybe the readme will be updated

This is intentional and we don't plan on providing further documentation, you should look at our CI/CD scripts to understand how to do things.

This is intentional and we don't plan on providing further documentation, you should look at our CI/CD scripts to understand how to do things. it useless for cli. I'll post a issue about is OK ?

yes i have an I'm running them, on git hub.  this is in scope now
update you readme to match the CI/CD scripts
I did the cross compile it fails. you support many processors and os but provide no reference, just to write my env is wrong
2m 1s
Run yarn --frozen-lockfile --network-timeout 180000
➤ YN0050: The --frozen-lockfile option is deprecated; use --immutable and/or --immutable-cache instead
➤ YN0000: ┌ Resolution step
Resolution step
➤ YN0000: └ Completed in 0s 289ms
➤ YN0000: ┌ Fetch step
Fetch step
➤ YN0000: └ Completed in 38s 471ms
➤ YN0000: ┌ Link step
Link step
➤ YN0000: └ Completed in 1m 22s
➤ YN0000: Failed with errors in 2m 1s
Error: Process completed with exit code 1.

chroots and building The cross compile activity is happen now on x86_x64 machine the gitbuild is also being tried.
Arm linux does not work with android studio, chromium and vscode. so the issue is not with vscode. src need to be built on ARCH chroots via x64 this seem to be the work around by the normal
I finally got link error message the nodejs need rebuild electron is also being rebuilt, python build failed do to linking
The yarn gulp compiles and link with no errors arm64 the debug has provided some assistance.
vscode tries to run, the support code fails nodejs python java
i have input for the wiki when progress happens


fix: dragging feature integrated

@devzkhalil hi,
I made a help to your PR, I have fix some bugs that I found
Just merge it, your PR will be updated

Also, on chrome i getting
[Violation]
  Added non-passive event listener to a scroll-blocking 'touchstart' event.
  Consider marking event handler as 'passive' to make the page more responsive.
  See https://www.chromestatus.com/feature/5745543795965952

is there another way for touchstart?


added a gui (EXPEREMETAL)

added a gui based on pyqt5 lib

closing this pull req due to @just-mn complete and improve it in private beta repo


[5.7] Fix source range computation of regex literals for diagnostics

5.7 cherry-pick of https://github.com/apple/swift/pull/58823
Start recording the locations of regex literals on the SourceManager, and using this information to re-lex them as regex literals. This is unfortunately needed to ensure we correctly compute source ranges for diagnostic logic.
rdar://92469692

@swift-ci please test

@swift-ci please test


Emoji Reaction Picker: Frozen state / Can't delete reaction

This happened to me once so I'm assuming its possible it could happen to other users too and is indeed a bug that needs to be squashed. While scrolling through reactions the lag ( issue #2925 ) caused me to accidentally select an emoji. After this point I tried clicking the emoji in the message but it would not let me remove the emoji for some reason. I tried clicking the emoji icon several times but it wouldn't go away.
On 16.2.96 for iOS.

Issue already reported in #2784

Got the reproduction, submitting PR soon 👍
Thanks @armaanahluwalia for the report.
@zulipbot claim