sync values for telemetry v2 update

@richardwxn: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

mandiff_operator
aa6a2ac48155ccc77d34f17927ef5d16a9313818
link
/test mandiff_operator

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@richardwxn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

mandiff_operator
aa6a2ac48155ccc77d34f17927ef5d16a9313818
link
/test mandiff_operator

gencheck_operator
aa6a2ac48155ccc77d34f17927ef5d16a9313818
link
/test gencheck_operator

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@richardwxn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

gencheck_operator
aa6a2ac48155ccc77d34f17927ef5d16a9313818
link
/test gencheck_operator

mandiff_operator
b606b2f9268a56fb7392697f03ea7883fd0e639f
link
/test mandiff_operator

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@richardwxn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

mandiff_operator
b606b2f9268a56fb7392697f03ea7883fd0e639f
link
/test mandiff_operator

gencheck_operator
b606b2f9268a56fb7392697f03ea7883fd0e639f
link
/test gencheck_operator

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@richardwxn: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

test_operator
c8510fe02d3294a08ec150a02254ffc9e29c7bdf
link
/test test_operator

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@richardwxn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

test_operator
c8510fe02d3294a08ec150a02254ffc9e29c7bdf
link
/test test_operator

e2e_operator
c8510fe02d3294a08ec150a02254ffc9e29c7bdf
link
/test e2e_operator

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

close as another PR to update the sha is merged


[PLC] [Costing] Improved budgeting modes

Don't look here yet.

I need to fix conflicts, but the PR should be ready for review.

@kwxm

That's a definite improvement. I can now run things without incurring the tallying cost, and the times are as you'd expect: no budgeting < counting < restricting << tallying, which is reassuring. There's no sign of any memory misbehaviour either.

Thanks for checking! I was going to check myself, but then I stupidly forgot.


Add topic option in api call

Adds topic model initialization when router starts
Adds matching methods and Config for init/get in ModelLoader
download_dependencies.sh - put model and data paths into a variable (the topics path was wrong and it wasnt being unzipped with the other models)
search.py - changed the first arg in each route to be "body" for clarity

tested on postman with url: localhost:5000/textExtractions?extractType=topics
text from wiki page about topic extraction body = {"text": "In machine learning and natural language processing..."}
Results
{
"extractType": "topics",
"extracted": [
[
0.6635282413471477,
"topic"
],
[
0.29509904818906196,
"topics"
],
[
0.25357750095344334,
"models"
],
[
0.23613126535592635,
"latent"
],
[
0.17210545109086287,
"algorithms"
]
]
}


CIV-6003 CCJ guard

JIRA link
https://tools.hmcts.net/jira/browse/CIV-6003
Change description
CCJ guard
Does this PR introduce a breaking change? (check one with "x")
[ ] Yes
[x] No

Unblocked


Code block styling: small size

https://rfc.stitcher.io/rfc/the-pipe-operator

Someone needs to remove max-width: 200px; from the code HTML element. Will you do it @MohammadAlhallaq? If you don't have time, I'll do it

@SerhiiCho Please do it because I still can't produce code highlighting locally for some reason 😅


jsoup cpu is high

Cpu is very high when parsing large amounts of html using jsoup

Yes, it is. But you can't do much with it. I tried to do some optimizations but was only able to improve a little bit. JSoup is quite well optimized out of the box.

I don't have anything else to add... If you have a specific HTML chunk that could do with more optimizing, please add and re-open.


R.is(Number, NaN) === true

Welcome to Javascript!
In my opinion R.is(Number, NaN) should return false....obviously.

Well, the NaN is still a number type. It may look weird, but it's actually quite reasonable; read answers at http://stackoverflow.com/questions/2801601/why-does-typeof-nan-return-number

But if you read it out loud... it makes zero sense. I think ramda should take care of this, as it should fix javascript quirks like that.

Yeah, if you read it "Not a Number is a Number", then it's an oxymoron. However, it may be just a problem of our interpretation.

Documentation is very clear about it:

See if an object is an instance of the supplied constructor.

NaN is an instance of Number in JS (and I guess that not just here). It's a special instance that indicates that the result of numeric calculation actually isn't a valid number. If R.is worked as you suggests, than it'd lie.
I understand your point of view, but I'm afraid that it may cause even more confusion.

I don't think it's reasonable to expect code to always make sense when interpreted literally. If we really wanted that we'd be renaming this function to R.isInstanceOf. To keep function names sane it's probably not feasible endeavor to convey function semantics in this way.

to make function names sane this is what bugs me here. R.is doesn't make up for it's name then. R.isType could also be a name for this and then I could agree on typeof NaN === 'number' but R.is sounds a lot more stricter about the type/instance checks it does imo.

Me as a human I tend to think more literally of course and I think a library like ramda should take this in mind. I mean this lib is for us humans, not the computer :)

I think the problem is that NaN is spelled wrong.  It is a number according to the IEEE 754 specification, which is what Javascript supports.  If it were called InvalidNumber rather than Not a Number, things would be much more clear.
This is for humans, and we want the proper ergonomic fit where we can.  is(Rectangle) reads better and is altogether clearer than isType(Rectangle).  This is true across the board.  Because of the weird naming of NaN, though, in that one case, the read-aloud is correct, but sounds very strange.

NaN is a member of Number (though not of ValidNumber).
One can always define one's own function:
//    isValidNumber :: Any -> Boolean
const isValidNumber = R.both(R.is(Number), R.complement(R.equals(NaN)));


CalledProcessError: Failed building editable for infinigen (WSL2)

Describe the bug
Hey all, I followed the instructions in Installation.md for installing Infinigen as a Blender Python script, but when running bash scripts/install/interactive_blender.sh I receive a CalledProcessError. I am running this via Windows WSL2 x86_64 and am using Ubuntu 20.04.3.
Steps to Reproduce
What version of the code were you using?
Tell us the commit & commit hash from git log
infinigen-1.3.4
What command did you run?
bash scripts/install/interactive_blender.sh
Error section from output logs
infinigen/assets/creatures/util/geometry/cpp_utils/bnurbs.c:38:10: fatal error: Python.h: No such file or directory
38 | #include "Python.h"
|          ^~~~~~~~~~
compilation terminated.
Traceback (most recent call last):
File "/tmp/pip-build-env-34l_7ee9/overlay/lib/python3.10/site-packages/setuptools/_distutils/unixccompiler.py", line 188, in _compile
self.spawn(compiler_so + cc_args + [src, '-o', obj] + extra_postargs)
File "/tmp/pip-build-env-34l_7ee9/overlay/lib/python3.10/site-packages/setuptools/_distutils/ccompiler.py", line 1041, in spawn
spawn(cmd, dry_run=self.dry_run, **kwargs)
File "/tmp/pip-build-env-34l_7ee9/overlay/lib/python3.10/site-packages/setuptools/_distutils/spawn.py", line 68, in spawn
raise DistutilsExecError(f"command {cmd!r} failed with exit code {exitcode}")
distutils.errors.DistutilsExecError: command '/usr/bin/gcc' failed with exit code 1
  During handling of the above exception, another exception occurred:

  Traceback (most recent call last):
    File "/tmp/pip-build-env-34l_7ee9/overlay/lib/python3.10/site-packages/setuptools/command/editable_wheel.py", line 155, in run
      self._create_wheel_file(bdist_wheel)
    File "/tmp/pip-build-env-34l_7ee9/overlay/lib/python3.10/site-packages/setuptools/command/editable_wheel.py", line 357, in _create_wheel_file
      files, mapping = self._run_build_commands(dist_name, unpacked, lib, tmp)
    File "/tmp/pip-build-env-34l_7ee9/overlay/lib/python3.10/site-packages/setuptools/command/editable_wheel.py", line 280, in _run_build_commands
      self._run_build_subcommands()
    File "/tmp/pip-build-env-34l_7ee9/overlay/lib/python3.10/site-packages/setuptools/command/editable_wheel.py", line 307, in _run_build_subcommands
      self.run_command(name)
    File "/tmp/pip-build-env-34l_7ee9/overlay/lib/python3.10/site-packages/setuptools/_distutils/cmd.py", line 316, in run_command
      self.distribution.run_command(command)
    File "/tmp/pip-build-env-34l_7ee9/overlay/lib/python3.10/site-packages/setuptools/dist.py", line 968, in run_command
      super().run_command(command)
    File "/tmp/pip-build-env-34l_7ee9/overlay/lib/python3.10/site-packages/setuptools/_distutils/dist.py", line 988, in run_command
      cmd_obj.run()
    File "/tmp/pip-build-env-34l_7ee9/overlay/lib/python3.10/site-packages/setuptools/command/build_ext.py", line 91, in run
      _build_ext.run(self)
    File "/tmp/pip-build-env-34l_7ee9/overlay/lib/python3.10/site-packages/setuptools/_distutils/command/build_ext.py", line 359, in run
      self.build_extensions()
    File "/tmp/pip-build-env-34l_7ee9/overlay/lib/python3.10/site-packages/setuptools/_distutils/command/build_ext.py", line 479, in build_extensions
      self._build_extensions_serial()
    File "/tmp/pip-build-env-34l_7ee9/overlay/lib/python3.10/site-packages/setuptools/_distutils/command/build_ext.py", line 505, in _build_extensions_serial
      self.build_extension(ext)
    File "/tmp/pip-build-env-34l_7ee9/overlay/lib/python3.10/site-packages/setuptools/command/build_ext.py", line 252, in build_extension
      _build_ext.build_extension(self, ext)
    File "/tmp/pip-build-env-34l_7ee9/overlay/lib/python3.10/site-packages/Cython/Distutils/build_ext.py", line 135, in build_extension
      super(build_ext, self).build_extension(ext)
    File "/tmp/pip-build-env-34l_7ee9/overlay/lib/python3.10/site-packages/setuptools/_distutils/command/build_ext.py", line 560, in build_extension
      objects = self.compiler.compile(
    File "/tmp/pip-build-env-34l_7ee9/overlay/lib/python3.10/site-packages/setuptools/_distutils/ccompiler.py", line 600, in compile
      self._compile(obj, src, ext, cc_args, extra_postargs, pp_opts)
    File "/tmp/pip-build-env-34l_7ee9/overlay/lib/python3.10/site-packages/setuptools/_distutils/unixccompiler.py", line 190, in _compile
      raise CompileError(msg)
  distutils.errors.CompileError: command '/usr/bin/gcc' failed with exit code 1
  /tmp/pip-build-env-34l_7ee9/overlay/lib/python3.10/site-packages/setuptools/_distutils/dist.py:988: _DebuggingTips: Problem in editable installation.
  !!

          ********************************************************************************
          An error happened while installing `infinigen` in editable mode.

          The following steps are recommended to help debug this problem:

          - Try to install the project normally, without using the editable mode.
            Does the error still persist?
            (If it does, try fixing the problem before attempting the editable mode).
          - If you are using binary extensions, make sure you have all OS-level
            dependencies installed (e.g. compilers, toolchains, binary libraries, ...).
          - Try the latest version of setuptools (maybe the error was already fixed).
          - If you (or your project dependencies) are using any setuptools extension
            or customization, make sure they support the editable mode.

          After following the steps above, if the problem still persists and
          you think this is related to how setuptools handles editable installations,
          please submit a reproducible example
          (see https://stackoverflow.com/help/minimal-reproducible-example) to:

              https://github.com/pypa/setuptools/issues

          See https://setuptools.pypa.io/en/latest/userguide/development_mode.html for details.
          ********************************************************************************

  !!
    cmd_obj.run()
  error: command '/usr/bin/gcc' failed with exit code 1
  [end of output]

note: This error originates from a subprocess, and is likely not a problem with pip.
ERROR: Failed building editable for infinigen
Failed to build infinigen
ERROR: Could not build wheels for infinigen, which is required to install pyproject.toml-based projects
What are your FULL output logs?
logs.txt
If this is your first time running Infinigen, what are the full install logs?**
logs2.txt
Platform

OS & OS Version: Windows 11
GPU (?) : NVIDIA GeForce RTX 3080
GPU Driver Version (?) :Driver Version: Version 551.23
RAM (GB):32

Additional context
Add any other context about the problem here.
The same problem is on the Ubuntu 24.04.

Hi @SearAbbas Can I ask how you resolve this problem?

Just leaving a comment for future reference;
In my case, Python.h was under a different directory ($CONDA_PREFIX/include/python3.10), so had to include it manually.
export C_INCLUDE_PATH=$CONDA_PREFIX/include:$CONDA_PREFIX/include/python3.10:$C_INCLUDE_PATH
export CPLUS_INCLUDE_PATH=$CONDA_PREFIX/include:$CONDA_PREFIX/include/python3.10:$CPLUS_INCLUDE_PATH
I am using anaconda installed python on Linux. The correct directory may differ from OS to Os. You can manually search it and add the paths to the C_INCLUDE_PATH and CPLUS_INCLUDE_PATH paths.
Related post


make more complex and prettier examples

Hi,
how can i use tabController to create more than 2 tabs?
All the example are only for 2 tabs.
thanks

Hey @EgomL
There currently seems to be no support for providing a TabController to the ContainedTabBarView, but you can have as many tabs and views as you like by just specifying them in tabs and views lists.
What benefits are you looking to get by providing your TabController? If you have an idea for improvement, I'd be happy to accept your PR.


Add a LICENSE file

If assigned I will add a LICENSE file to the report which you would prefer.

LICENSE file added.


fix: client page for client creds

:x: Build TheIdServer 4.5.4-feat-open-telemetry1-0019 failed (commit https://github.com/Aguafrommars/TheIdServer/commit/225ff3cd4a by @aguacongas)


cli-ext: payload builder constraints

Description
With the recent changes in the abstractions of the payload builder, it has become more difficult to override default builder behavior. It requires either using the provided payload_builder or implement a builder that's generic over payload arguments and what kind of payload it produces. It doesn't always make sense if you are implementing a payload builder only for ethereum or only for optimism.
https://github.com/paradigmxyz/reth/blob/ce010264b9210bb23d046e1e5f5954096c2887b3/bin/reth/src/cli/ext.rs#L131-L136
Example Request
Create an example in examples/ directory that implements an empty payload builder and spawns it instead in CLI extension RethNodeCommandConfig::spawn_payload_builder_service.
Some existing doc code can be reused:
https://github.com/paradigmxyz/reth/blob/ce010264b9210bb23d046e1e5f5954096c2887b3/crates/payload/builder/src/lib.rs#L27-L89

Hi @Rjected if you don't have bandwidth I am happy to take it. Thanks!


Make the code readable at any size + dom size optimization

I noticed that unless you set the size to an exact multiple of the number of cells; so for a relatively small qr code with 33x33 cells you need to set the size as 33 or 66 or 330 etc. otherwise a handful of the cells will be rounded up or down creating non-square pixels.

Notice the non-square pixels:

Not only does it look slightly awkward with those rounding errors and reduce readability somewhat; but if you set the size anywhere close to (but not exactly) the number of cells the code will have, the qr-code will be completely broken:

I realised I could fix the rounding by changing from viewBox being one of the optional parameters to be be set to the size of the qr-code in cells.
Then I could also simplify the paths a lot by using unit sized cells and let the viewbox take care of the final scaling.
This way the maximum rounding error is one native pixel rather than a rather large fraction of the cell, which should be much better for readability.
Once all the cell-size calculations were simplified to using 1 I realised the paths outputted was pretty repetetive and could be written more compactly. Also by using a single <rect /> for the background I could practically halve the number of path elements by outputting only the foreground pixels. Just to further reduce the DOM size I changed from using transforms to using absolute positioned move and relative lines in the d property of the path.
After these changes:

This is readable at any size as long as theres sufficient quietzone around it and it's physically large enough for the camera to focus on it.

In our local copy I've now also added a prop for quiet zone so that the required minimum of 4 modules quiet zone is baked into the SVG itself; should I bother to add these changes to this PR or are you not interested?

Any update on this? I've had this issue related to rounding

@strindhaug thank you for the PR, I will try to look at this on a weekend. Sorry, too busy these days 😢


className props was removed

I saw in the last update that 'className' was removed from the props in the typescript types. That property was very important since it allows to access and manipulate the style of the ReactPlayer component. Is there a preferred way to deal with this ? i would rather not create another div (since the component already creates 2 of those) around it just to style it.

As of, d8df671478105165ca396716a4c8328bc78a70c1, any props not specified in props.js get applied to the ReactPlayer wrapper div. So className still works as before, but just isn't specified as it just gets passed through with any other extra props.
I guess I need to update the typings file to include an indexer, to allow for any other props? Correct me if I'm wrong – I am not too clued up on TypeScript typings:
export interface ReactPlayerProps {
  url?: string | string[] | SourceProps[];
  playing?: boolean;
  loop?: boolean;
  // ...
  [otherProps: string]: any;
}

I tried adding the actual attributes types from the react types package, but a few properties of the ReactPlayer props (onProgress, onError, ...) conflicts with the DOMAttributes interface which has different definitions for those. So I guess you general indexer is our only solution for now :/


Need to clarify the correct auth endpoints when using azureActiveDirectory

The endpoints for Login, Purge user details, and Authentication callbacks need to be clarified in the case where the user is using azureActiveDirectory as the provider. The doc lists the endpoints as the following, which is correct for all providers except azureActiveDirectory.
/.auth/login/<PROVIDER_NAME_IN_CONFIG>
/.auth/purge/<PROVIDER_NAME_IN_CONFIG>
https://<YOUR_SITE>/.auth/login/<PROVIDER_NAME_IN_CONFIG>/callback
https://<YOUR_SITE>/.auth/logout/<PROVIDER_NAME_IN_CONFIG>/callback
In the case where the user is using azureActiveDirectory as the provider, the endpoints would be /.auth/login/aad , etc. But if following the doc, users are prone try to use /.auth/login/azureActiveDirectory , etc, which would be the incorrect endpoints. Am proposing adding a note to the following sections to clarify that aad should be used instead of <PROVIDER_NAME_IN_CONFIG> if using azureActiveDirectory as the provider.
https://docs.microsoft.com/azure/static-web-apps/authentication-custom?tabs=aad#login-logout-and-purging-user-details
https://docs.microsoft.com/azure/static-web-apps/authentication-custom?tabs=aad#authentication-callbacks

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 623901d6-2ff5-930f-a597-50aadc08b00b
Version Independent ID: 22464fe8-5e55-0d8d-0894-ee58e7310f55
Content: Custom authentication in Azure Static Web Apps
Content Source: articles/static-web-apps/authentication-custom.md
Service: static-web-apps
GitHub Login: @aaronpowell
Microsoft Alias: aapowell

@gabesmsft  - Thanks for bringing this to our attention.
I'm going to assign this to the document author so they can update the document accordingly.

The section you're referring to is related to custom OIDC providers, not the pre-configured providers (such as AAD). AAD is covered more in https://docs.microsoft.com/azure/static-web-apps/authentication-custom?tabs=aad&WT.mc_id=javascript-0000-aapowell#login-logout-and-purging-user-details and I'm proposed some tweaks to make it clearer.

Tweaks to make the AAD part clearer will be great. Even though the mentioned section is about custom OIDC providers, it is still causing confusion for users because those .auth endpoints are applicable to other preconfigured providers (Google, Facebook, etc) and although users could extrapolate the correct endpoints for AAD from the linked AAD EasyAuth doc, the endpoints aren't called out explicitly.

I updated the main auth article with this information as well.

Moving to #please-close this issue as the article is updated with clearer guidance on the AAD-specific values. Will follow up directly with @gabesmsft regarding further required enhancements needed to the doc.


Documentation out of date

There is a general issue of documentation being out of date (e.g., README has not been updated in nearly 30 months). Some is easy -- add missing items to README. One question I have is about generation of files. The top of mpif.h says:
!!!
!!!   NOTE: The files mpif.realXdoubleY.h are generated from
!!!   mpif.master.h using make-mpif and later copied to mpif.h
!!!   during the library make.  All modifications should be
!!!   made to mpif.master.h
!!!

I cannot find any sign of this infrastructure. Is there any sort of code generation going on in mpi-serial? Any objections to getting rid of the comment?
Any objections to getting rid of NOTES? It seems ignored and out of date.

Yes you can remove NOTES.   Yes you can get rid of that comment.  The code generation went away with the conversion to autotools.


Github repository website shows wrong "latest" release

Problem
When navigating to https://github.com/dagger/dagger, there is a "releases" widget that shows the latest release. That widget currently indicates that v0.2.36 is the latest release, which is incorrect (the latest dagger engine release is in fact 0.3.5).
The reason for this is that github defines "release" narrowly as "the act of using the Github release feature". However the Dagger Engine since 0.3.0 has been released by setting a git tag. Per Github's narrow proprietary definition, nothing is wrong. However, something clearly is wrong: people visiting our github repository page are misled into thinking 0.2.36 is our latest available version of the software, which it is not.
Solution
Unclear.
Perhaps the imminent CLI 0.3.x release will coincide with an engine release, and use the proprietary github release feature? If so, perhaps the problem will resolve itself shortly?

No longer an issue, works as expected:


add: Breadth-First Search (BFS)

Describe the algorithm/code
Issue Description : Breadth-First Search (BFS) is a graph traversal algorithm that systematically explores all neighbors of a node before moving on to their neighbors. It starts at the root node and progresses level by level, making it useful for tasks like finding the shortest path in unweighted graphs, exploring the connectivity of a graph, and web crawling. BFS is typically implemented using a queue data structure.
Hi there 👋
I'm excited to contribute to Hacktoberfest 2023, and I'd like to work on this issue. It looks like a great opportunity to learn and contribute to the project.
Please assign this issue to me, and I'll start working on it right away. If you have any specific instructions or guidelines, please let me know, and I'll make sure to follow them.
Thanks a lot for considering my request!
Best regards,
Prateek Sethi
Do you want to work on this feature?

[X] I am willing to implement this feature.

I guess we already have this implemented.
Check here:  https://github.com/himanshu-03/Python-Data-Structures/tree/main/Graphs


zimg is error

zimg  every time is build error

Please elaborate.

error

That looks like some kind of internet issue on your end, or an intermittent hickup on Github.
The commit exists on the googletest repo, and it fetches just fine for me.
Have you tried just trying it again?

ok


Update caption to 1.3.0

After making all changes to the cask:

[x] brew cask audit --download {{cask_file}} is error-free.
[x] brew cask style --fix {{cask_file}} left no offenses.
[x] The commit message includes the cask’s name and version.

Additionally, if updating a cask:

[ ] If the sha256 changed but the version didn’t,
provide public confirmation by the developer: {{link}}

Thank you for the contribution. It was merged directly as 452514f2b06921b5e392eddac7070bbc1b3305f4. Your contribution is still credited to you.


CMake Error on MacOS

When following installation instructions:
brew install curl cmake libressl c-ares doxygen graphviz
git submodule update --init
export OPENSSL_ROOT_DIR=/usr/local/opt/libressl
cmake -H. -Bbuild-output

I get:
CMake Error at build-output/CMakeDoxygenDefaults.cmake:471 (set):
  Syntax error in cmake code at

    /Users/XXX/Code/google-cloud-cpp/build-output/CMakeDoxygenDefaults.cmake:471

  when parsing string

    \makeindex

  Invalid character escape '\m'.
Call Stack (most recent call first):
  /usr/local/Cellar/cmake/3.13.2/share/cmake/Modules/FindDoxygen.cmake:958 (include)
  cmake/GoogleCloudCppCommon.cmake:94 (doxygen_add_docs)
  google/cloud/CMakeLists.txt:53 (include)

I was able to reproduce this locally. Something is not right with the configuration file generated by FindDoxygen.
As a workaround, consider using:
cmake -H. -Bbuild-output -DCMAKE_DISABLE_FIND_PACKAGE_Doxygen=TRUE

This looks like an issue with FindDoxygen in CMake:
https://gitlab.kitware.com/cmake/cmake/issues/18738

FWIW, Doxygen has fixed the bug referenced above, but it will take a while for a new release to make it into homebrew.  I am going to close this bug because there is no action for us to take, an automatic workaround would be super hacky (something like if CMake <= blah version AND Doxygen >= foo version then disable doxygen anyway).
Feel free to reopen if the workaround is not working for you.


Send a JSON response for authentication failures

Motivation:
Central Dogma server sends a response without content when authorization
fails. We could respond with JSON so that the clients knows the exact
cause of the failure.
Modifications:

Use HttpApiUtil to build an authentication failure response.
Do not use HttpStatus.reasonPhrase() when exception message is
missing, because it often mismatches with the actual exception type,
e.g. ShuttingDownException having Internal Server Error message.

Result:

Proper response even on authentication failure
message field in an error response is empty if an exception does not
have a message.

Thanks for reviewing.


Add support for using TransformerEngine

Use TransformerEngine for either 1) linear layers only 2) Whole te.TransformerLayer to replace GPTBlock.

Hi @dskhudia, can you comment on how necessary it is to use the TransformerLayer for performance / convergence?
For context, we have been making many changes to GPTBlock (and expect to make more variations), supporting different attention / arch / normalization strategies, and I'm not sure if we would end up using TransformerLayer much. The te.Linear approach feels more modular and we could use it with all the variations we end up building.
If it's still useful for testing purposes to have TransformerLayer, then I can think about a way to make the model construction more modular like cfg.block_type=...

Hello!
How does one use this with inference of the model? We have a great interest in that.
Best Regards

Closing, because llm has moved to llm-foundry.


User directory "Add to address book" button not present on MacOS

When navigating to the User Directory in the macOS beta version of Beaker, users are listed but without the a "add to address book" button (which is mentioned in the User Guide).

Ah thanks for the issue, that's a bug in the docs. We'll update.

By the way, you can do this manually by going to the site and clicking the gray "site info" button on the left of the URL bar. There's an "add to address book" button there.

Fixed! Thanks again for reporting


🐞 - Mobile Calendar opens on year 1900

Which @taiga-ui/* package(s) are the source of the bug?
addon-mobile
Please provide a link to a minimal reproduction of the bug
https://taiga-ui.dev/stackblitz
Is this issue blocking you?
Blocking
Description
From few days ago (date triggered, not by taiga update) we have a problem with mobile calendar that it opens up on year 1900. Any ideas?
I am trying to debug this but as its urgent problem for us any hing would be useful.....
thanks.

Angular version
14
Taiga UI version
3.9, 3.15 tested
Which browsers have you used?

[X] Chrome
[X] Firefox
[ ] Safari
[ ] Edge

Which operating systems have you used?

[ ] macOS
[X] Windows
[X] Linux
[ ] iOS
[ ] Android

Part of code that I believe to be relevant. It sets activeYear to 1900.

@hheexx create a PR please for fix

I don't have fix yet.
I still don't understand why.

I fixed problem by changing STARTING_YEAR to 2023.
I believe problem may be actually in cdk-virtual-scroll-viewport as it fires event scrolledIndexChange with parameter 2 when it should not.

Thank you for investigating it. If you want, you can continue looking into it and fix is very welcome, because I'm not sure when we will be able to get to this task as we currently have a lot on out plate we must prioritize over this.


Correction for raw affiliation INRA, UMR1083 SPO, Halle de Biotechnologie, 34060 Montpellier, France

Correction needed for raw affiliation INRA, UMR1083 SPO, Halle de Biotechnologie, 34060 Montpellier, France
raw_affiliation_name: INRA, UMR1083 SPO, Halle de Biotechnologie, 34060 Montpellier, France
new_rors: 022m8c549;04w07sc25
previous_rors: 022m8c549
works_examples: W2171328081
contact: c7dbfcf4a9d2f8b9d450c3d8c6a3903c:2ca078a093f1418bc0f3c2cc54bdea646c95 @ inrae.fr

This issue was accepted and ingested by the OpenAlex team on 2024-10-09. The new affiliations should be visible within the next 7 days.


Azure Functions in class library triggers error: MSB4113: Specified condition "$(SelfContained)" evaluates to "" instead of a boolean.

I'm running into an issue where the Microsoft.Azure.Functions.Worker.Sdk (Microsoft.Azure.Functions.Worker.Sdk.targets) throws an error when building an Azure Functions class library. I've found a work around which is to make the class library also a console application, but that will be confusing.
To reproduce:
Create a class library that has the following references:
    <PackageReference Include="Microsoft.Azure.Functions.Worker" Version="1.3.0" />
    <PackageReference Include="Microsoft.Azure.Functions.Worker.Extensions.Http" Version="3.0.12" />
    <PackageReference Include="Microsoft.Azure.Functions.Worker.Sdk" Version="1.0.3" OutputItemType="Analyzer" />

Also create an Azure Function application that references that class library next to the references stated above.
If the class library is setup with <OutputType>Library</OutputType> the error "MSB4113: Specified condition "$(SelfContained)" evaluates to "" instead of a boolean." is thrown during build. If the package Microsoft.Azure.Functions.Worker.Sdk is removed, the error is not thrown anymore, but the functions in the class library are not recognized anymore by the Azure Functions application.
If the output type of the class library is set to <OutputType>Exe</OutputType> and still used as a class library, the projects build and the Azure Function application recognizes the class library functions and everything works.

Do you still have the same issue if you don't reference the SDK package? That shouldn't be needed for a class library (you only need that for the application that references the library, i.e. the worker)

When I tried that the first time the function worker stated that no functions were found. I've tried it again and it has no problem recognizing the functions in the class library. So that's good.
I was updating my setup from a preview version to the 1.3.0 release, so I think I still had some other issues that I fixed along the way. Thanks for the reply and I'll be closing this issue.


PeekPokeTester

Type of issue: bug report
The Chisel 2 tester allowed to peek (and poke?) into the hierarchy of the modules, which was very convenient. Looks like this is gone with the Chisel 3 PeekPokeTester. We need again sire interesting signal up to the top level, which is painful.

Impact: issue on porting from Chisel 2 to 3

This is now a chiseltest issue although perhaps a "wont fix".


[snabbnfv traffic] Fix issue #481: Check PCI device on startup

This fixes issue #481 (snabbnfv traffic:Check PCI device on startup) .

Hah! I also addressed this in #481.
Looks like I did two things wrong to obscure that change:

Failed to reference the bug Issue in the Pull Request, so that Github would cross reference.
Closed the PR after having merged it onto the nfv branch (but not yet onto master).

Is there one that we should keep or should we merge them together?

Whoops I did see that PR at some point, well there goes short term memory. Your PR (#489) solves this in a generally neater way (no useless loop) but it doesn't check for is_usable. I am not sure if it should since the driver(s) unbind(?) the device anyways?

Good point.
In a perfect world it could be nice to refuse to operate on ports that the kernel is currently using and insist that the user do ifconfig ethxx down. That would avoid really annoying problems like wiping out networking on the machine by accidentally using the wrong PCI address.
However, this would not be backwards compatible behavior for snabbnfv traffic and so I suspect we would do more harm than good by introducing this now. I close this PR for now.


edits made to FG mcom 221

@catheryn-zuo & @emmanuelD-AFK  updated numbering in Course learning outcomes, the weightage of score for assignments and hid the lesson notes and activities for U10. Please have a look and let me know if you have any questions.


redis.exceptions.ResponseError: unknown command 'FT.CREATE'

redis.exceptions.ResponseError: unknown command 'FT.CREATE'?

me too

https://github.com/openai/chatgpt-retrieval-plugin#redis

docker run -p 6379:6379 redislabs/redisearch:latest

helps

cannot salve my problem

You need to install RediSearch. Using docker you can run the following
docker run -it --rm --name redis-search-2 \
   -p 6379:6379 \
   redislabs/redisearch:2.2.5

Use Docker or install Redis with Redisearch - FT.Create (https://redis.io/commands/ft.create/)

Hi just to clarify from the Redis side, you need to make sure both RediSearch and RedisJSON are installed. They come by default with the Redis Stack docker container we reference under: https://github.com/openai/chatgpt-retrieval-plugin/tree/main/examples/docker/redis
This should fix your issues.

We'll open a PR with a module check to return a clearer error. Stay tuned.

Updating Docker fixed my issue

addressed with:
https://github.com/openai/chatgpt-retrieval-plugin/pull/38


Ground truth with the anotation tag

Actions before raising this issue

[X] I searched the existing issues and did not find anything similar.
[X] I read/searched the docs

Is your feature request related to a problem? Please describe.
Hi, I have the impression that Ground truth doesn't work with the anotation tag. I don't have any results, could you confirm that this isn't supported, unless I've forgotten something? Thank you very much!
Describe the solution you'd like
I would like to use the Ground truth mode with the anotation tag, following my labelisation I create a model and during the test I see classes rated differently to what the human has done. So I'd like to use Ground truth in an automated way to get this information back and then be able to do an issue review. But already manually, I have the impression that it doesn't work for the tags... I don't get any values displayed:

Describe alternatives you've considered
No response
Additional context
No response

I've automatically added the issue and the how, it's better ^^

issue = models.Issue.objects.create(
          job=initial_job,
          frame=frame_number,
          position=[0, 0],
          owner=visionia_user,
      )

      comment_message = (
          f"Predicted: {predicted_label}\n"
          f"Confidence: {confidence}"
      )

      models.Comment.objects.create(
          issue=issue,
          owner=visionia_user,
          message=comment_message
      )


https?

the web site / API does not support https. It should.

Especially that you can get free ssl certs from letsencrypt

@openstreetview Any news?

I just had the same thought. HTTPS seems to now be available but it uses a self-signed certificate so browsers don't trust it.

Well, the website supports https now. The images are being loaded over http, though, so it's only a partial victory.


[4397] Update course years form

Context
Trello: https://trello.com/c/0uO9YRcl/4397-get-rid-of-current-year-and-2023-to-2024-on-course-years-page
It was reported that users were accidentally registering their trainees too early, in a future year. We don't have the publish courses yet for 2023 - 2024 so we decided to remove this year option.
We've also removed 'current year' as this was potentially confusing users.

Changes proposed in this pull request

Update /app/forms/course_years_form.rb to only include this year and last year as options
Remove 'current year' text

Guidance to review

Navigate to the course year page by creating a new trainee record, clicking on course details and clicking on the year change link
Check the course year picker page looks and works as expected

Important business

[ ] Does this PR introduce any PII fields that need to be overwritten or deleted in db/scripts/sanitise.sql?
[ ] Does this PR change the database schema? If so, have you updated the config/analytics.yml file and considered whether you need to send 'import_entity' events?

NB: Please notify the #twd_data_insights team and ask for a review if new fields are being added to analytics.yml

 Get rid of '(current year)' and '2023 to 2024' on course years page

Looks good to me, thanks Hettie!


Lynda Exercise Files?

Please follow the guide below

You will be asked some questions and requested to provide some information, please read them carefully and answer honestly
Put an x into all the boxes [ ] relevant to your issue (like that [x])
Use Preview tab to see how your issue will actually look like

Make sure you are using the latest version: run youtube-dl --version and ensure your version is 2<IP_ADDRESS>. If it's not read this FAQ entry and update. Issues with outdated version will be rejected.

[x ] I've verified and I assure that I'm running youtube-dl 2<IP_ADDRESS>

Before submitting an issue make sure you have:

[ x] At least skimmed through README and most notably FAQ and BUGS sections
x[ ] Searched the bugtracker for similar issues including closed ones

What is the purpose of your issue?

[ ] Bug report (encountered problems with youtube-dl)
[ ] Site support request (request for adding support for a new site)
[ ] Feature request (request for a new functionality)
[ x] Question
[ ] Other

I'm able to download Lynda videos no problem. I would like to learn how to download the exercise files along with the videos and put them into the same folder. Is this possible? Do you have some example scripts to try out?
Thanks

Currently downloading non-media content is out of scope of youtube-dl.


packer: add fedora 36

F35 is going EOL soon, so let's update. I want to ditch F35 as soon as possible after this is merged, but I want to have some overlap just to be sure.
Signed-off-by: Ondřej Budai<EMAIL_ADDRESS>This pull request includes:

[ ] adequate testing for the new functionality or fixed issue
[ ] adequate documentation informing people about the change such as

[ ] submit a PR for the guides repository if this PR changed any behavior described there: https://www.osbuild.org/guides/

Forgot the inventories. :facepalm:


chore: delete .github folder

After move github files to global .github repository, this folder is unnecessary.

Sorry, what's the global .github repository stand for, please?

global .github repository will take effect for each repository that does not have the .github folder.


Build Error: 'GADBannerViewDelegate.h" not found

I found the file in GoogleMobileAds.framework/Headers in CocoaPods. It looks like Google changed the way it's doing things. Will this affect the library in other ways? Thank you Lars
Xcode 7.0.1 - iOS 9.0

I fixed it by editing TOLAdapterAdMobAds.h
#import <GoogleMobileAds/GADBannerViewDelegate.h>
#import <GoogleMobileAds/GADBannerView.h>
//#import "GADBannerViewDelegate.h"
//#import "GADBannerView.h"

I've actually been looking at this. I started earlier this week in commit 987064e, but ran into a couple other things that I hope to get to this weekend. Google doesn't make these things very easy to future-proof...

@larsacus you're absolutely right about that. In just in case you didn't know, you are the quickest responder that I have seen on GitHub. Salud!

It's probably because I'm always online :smile:

Hello, I've just encountered something strange with that. I followed the instructions above (I modified TOLAdAdapterGoogleAds.h and not TOLAdapterAdMobAds.h - is that correct?) but now I get "Declaration of 'GADBannerViewDelegate' must be imported from module 'GoogleMobileAds' before it is required. Do you have any idea how to deal with it?

@dafdafydd No, that's not correct. Those are two completely different files meant for different ad systems -- one is for Google Ads and the other is for  iAds.

But I mean *AdMobAds.h and not *iAds.h.

I'm not sure I follow. There has never been a file named TOLAdAdapterAdMobAds.h.

I thinks so too but this is the name @robmontesinos used:) I just wanted to make sure that I am not missing some files or something.
Do you have an idea why the error might appear? Your example code compiles without problems while my does not.

There's currently an issue when using this library with CocoaPods. Google in all their infinite wisdom has changed the deployment method of their application without revving the major version, which has made supporting this change extremely difficult. I still haven't found a workaround for it except for to 1. Remove support for CocoaPods or 2. Remove support for GoogleAds when using CocoaPods and just use something like Carthage to bring in the frameworks.

I see. I will stick to 3.0 and AdMob 6.0 for now then. Thank you for your response and your hard work. I hope you are finally going to find a solution as your library is so convenient and elegant that it would be great loss to remove support for CocoaPods.


Remove encoderEnforceMaxConcurrentStreams(...) as it ignored argument…

… and is redundant.
Motivation:
Remove encoderEnforceMaxConcurrentStreams(...) as it ignored the argument and always disabled the enforcing. Beside this it is redundant with encoderMaxConcurrentStreams(...) which we can just adjust to let the user specifiy -1 to disable the enforcement.
Modifications:

Remove encoderEnforceMaxConcurrentStreams(...) method
Change encoderMaxConcurrentStreams(...) so the user can use -1 to disable it.

Result:
Correctly behaving builder and less confusing.

@nmittler @Scottmitch PTAL

@Scottmitch ping

@nmittler @Scottmitch please check again

@normanmaurer - 1 Comment then LGTM.

@Scottmitch addressed... @nmittler ?

Cherry-picked into 4.1 (077af8c019921e2b5a66fd72e7105a680b7f9327) and master (4fa6a645627c004e360659d622fcd08c4fb1e3ab)

@normanmaurer sorry ... LGTM


User Notification will not run page, by action

Describe the bug
A notification with an action to run a page, does not do anything when clicked.
This is broken in "Insider build"
Version: 14.0.29346.0-W1 Platform: 14.0.29248.0
Pre 14.0 works fine!
To Reproduce
Steps and/or AL code to reproduce the behavior:
1 : Subscribe to Rolecenter open
[EventSubscriber(ObjectType::Codeunit, codeunit::"Conf./Personalization Mgt.", 'OnRoleCenterOpen', '', false, false)]
2: Call a function to issue the notification
var
WizardNotification: Notification;
begin
WizardNotification.Id('12900211-6c58-4cf4-93fa-35d0ffad2d24');
WizardNotification.MESSAGE := 'You have succesfully installed something.';
WizardNotification.AddAction('Let''s continue!', Codeunit::"My GUI Helper", 'RunSetupWizard');
WizardNotification.SEND();
end;
3: Define the function called by the notification action in the Codeunit above
procedure RunSetupWizard(_Notification: Notification)
var
begin
page.RunModal(page::"Some Wizard page");
end;
Expected behavior
The action should run.
Screenshots
Versions:

AL Langauge:
3.0.107312
Business Central:
Version: 14.0.29346.0-W1 Platform: 14.0.29248.0

This seems to have been fixed by using the nightly insider build from today bcinsider.azurecr.io/bcsandbox:base


minor bug fixes and added benchmarks

I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.

Thank @li0nr.
Can you please provide an explanation of the bugs that are solved by this PR?

Sure,
line 96 is have more precise allocated value, since when reallocating from the free list the original code with missing adding the newly allocated bytes to the variable allocated , while it was decreased in the free function.
line 217, is to tackle a highly concurrent allocation consider this scenario a lot of threads want to allocate
and we are forced to allocate new block since the getAndIncrement line 216 was before the assignment to the blockArray
other threads may allocate from this block but form their perspective the blockArray still at null, so when those threads
try to call readMemoryAddress they will get null.


[Beta4] More substitutions

This change addresses items #292, partly #286, #272  (and maybe some more)
Changes
This PR makes variant settings available for substitution and also enables substitution for the configuration settings.
I also added support for the ${env.VARNAME} syntax, since that one is used in VS2017.
I added a special case for the buildType variant setting, whose value will be placed in a variable named buildLabel to avoid overriding the default one.
I also pushed a commit which fixes the cmake.installPrefix config, since that one was ignored in the current beta. While at it,  I also enabled substitution support for it.
At the moment, the extension gives priority to the CMAKE_INSTALL_PREFIX setting, if the user provided one in cmake.configureSettings. Else it takes the value from cmake.installPrefix.
Implementation Details
I added a replacements variable to the StateManager, which makes it accessible to other classes/extensions.
This way, any class/extension can add their own replacements (e.g. currentKitName).
The CMakeDriver has it's own getter for the replacements named _replacements.
The getter updates the "default" variables before returning it to the callee.
Other Notes/Information
This is a rather rushed implementation, so any feedback and/or PRs are welcome.
I made the changes atop the refactor branch for the 1.0 release, since I didn't want to look through both versions.

I recently merged some changes for automated testing and CI. Would you mind adding some automated tests that check the variable expansion?

I will add some tests in the next commit.

None of the tests currently do any mocking. Maybe someday, but for now the tests just run against the "real thing," which is sufficient and effective for now. All the tests are contained in a single file in the tests directory, and just copying from another one should be sufficient. Don't sweat the details.
Also, ignore the AppVeyor failure. Somethings awry with the VS 2017 Preview test.

So, I have taken a closer look at the already existing tests, but I honestly don't know how I am supposed to test the variable expansion, since it all happens within the CMakeDriver.
I would have to create a new instance of the driver and then let it do the configure stuff, after which I can read the CMakeCache.txt file to check to results.
Am I missing something here ❓

Hm, I somehow can't install this (PR) version via .vsix.
I packaged it with vsce package and used the same installation command as for your Beta4 release.
Anyway, how about we just merge this PR and add the unit test later, since I don't know how I can test the variable expansion.

You are right. It is hard to write a unit test for the complete modification, but for some sub parts it is possible, like environment replacement or the expandString function.
The test for this feature on extension test level is really complex.
I work at the moment on unit test for the cmakeserverclient. I hop this allows us to fake the client later and make it easier to write tests for the cmakedriver.

I have rebased this PR onto the latest changes.

@vector-of-bool @KoeMai
I have started writing tests for variable substitution behavior.
Since there will be many tests, I have decided to move them into a separate file (variable-substitution.test.ts).
I have pushed my changes so far, maybe you could take a look at it, so that I don't work in a wrong direction.
At the moment, I check each substitution in an own test case, which has the side effect, that a configure is run for each case. It would be way more efficient to only configure it one time and then read out the CMake cache in the test cases without re-configuring it each time. I don't know how to do a one time setup step though, so if you know how to, please say so.
I also plan on merging all my other PRs into this branch/PR, so that I can write tests for them.
I think that will be better because my PRs mostly rely on this PR to really work well.

Ah, it's so nice when all tests pass ;)
Anyway, @KoeMai I have added some documentation for various configure options and also about the variant identifier substitution.

I recommend: https://github.com/SethMichaelLarson/trytravis

Certainly looks interesting :D

@vector-of-bool Is there a reason why 'squash and merge' is not enabled for this repo?
I think that in some cases, it is quite sensible to do it.

I've disabled squash and merge as well as FF merging because I strongly prefer to keep all of Git history (at least for PRs, feel free to rebase/squash on your local copy). Even if there are silly "typo" commits, I prefer to see them in the history.
Give trytravis a go. It works beautifully.

@vector-of-bool
About that trytravis thing, I don't see a use for me at the moment, since all the configure/build tests are skipped if process.env.HasVs is not true, which means that they are also skipped on travis.
It looks useful though, so I will give it a try later.


ggpicrust Install Issues

Hello! I really like the idea of ggpicrust. It looks like an efficient means of quickly analyzing picrust. Are there any plans to dockerize the package? I'm having an extremely hard time installing this package with endless dependency problems. I've tried just in R - just in Conda - in R and Conda and from renv::restore (renv.lock) all to no avail. For each dependency problem I install that package and try again and every time there is a different dependency problem.  I'm at the point of giving up and writing something myself to analyze picrust data. I've read the other two issue post on dependency problems none of which have been able to solve my problem. If this package was dockerized I think it would help not only me but future people looking to use this package.

Hello @ZellaD,
Thank you for reaching out and for your kind words about ggpicrust2. I truly appreciate your feedback and understand the challenges you're facing with package dependencies.
I'm sorry for the inconvenience you've experienced. To address these issues, I've recently updated the renv files. I hope that the new renv.lock will make the installation process smoother and help resolve the dependency problems you've been encountering.
Moreover, I've noticed the redundancy in ggpicrust2's dependencies and recognize the need to streamline them. Rest assured, I'm working on refining this, and my goal for the next version is to reduce such redundancies to enhance the package's accessibility for our users.
Regarding dockerizing the package, it's a great suggestion. Docker containers can indeed simplify deployment by handling package dependencies, and it's something I will seriously consider for future updates to ensure easier accessibility for users like you.
In the meantime, please try installing with the updated renv files and let me know if you face any more issues. I'm here to help, and I'm dedicated to improving the usability of ggpicrust2 for everyone.
Best regards,
Chen YANG

Hi Chen YANG thank you for the updates. I was able to install the packages locally using a mix of conda and the the renv.lock file. For my pipeline development, I will try to dockerize the package.
Cheers!
ZellaD


[BEAM-4290] proto changes to support artifact_staging_id

[PR IS NOT READY TO BE MERGED AND IS INTENDED TO VALIDATE THE CHANGE.
THESE PROTO CHANGES ARE NON BACKWARD COMPATIBLE SO WE WILL HAVE TO UPDATE ANY IMPLEMENTATION OF JOB SERVICE AND ARTIFACT STAGING SERVICE.]
Updating the proto to pass an artifact_staging_id to artifact staging service.
Reference document: https://docs.google.com/document/d/12zNk3O2nhTB8Zmxw5U78qXrvlk5r42X8tqF248IDlpI/edit

Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

It will help us expedite review of your Pull Request if you tag someone (e.g. @username) to look at it.

CC: @jkff @herohde @lukecwik @robertwb @bsidhom @axelmagn @tweise @tgroh

Yes, The missing "token" will be filled in subsequent PR where applicable.


HIVE-25738: NullIf doesn't support complex types

What changes were proposed in this pull request?

Why are the changes needed?

Does this PR introduce any user-facing change?

How was this patch tested?

+1，looks good to me!


Make 2-datacenter up to date, 2. refactor site.yml and inventory f…

Make 2-datacenter up to date, 2. refactor site.yml and inventory files, 3. create inventory role for Spark

Proceed with testing.


[GUI] Edit template: attribute name validation is different in addition and edition

In the addition of the attribute, the validation is done.

Steps:

View the details of a template
Click "EDIT"
Click "Add New Attribute"
Select type String
Fill in the name field with "@ #"
Click "ADD"

But in editing an attribute, the same validation is not done.

Steps to reproduce the problem:

View the details of a template
Click "EDIT"
Select an attribute
Change the Name field to the value "@ #"
Click "SAVE"

Expected behavior: Validation must be the same.
Affected Version: 0.3.0-nightly_20180912

The same validation is done, adding or changing the attribute.

In the addition of the attribute:

In editing an attribute:


Move code generation into an integration test

Instead of using a build script, use an integration test to generate code from the input files. This makes it so that downstream users don't have to compile and run the build script, and allows the crate to work more easily with non-Cargo build systems (like Buck2) that require deterministic input. The integration test will fail CI if the generated code falls out of sync with the input.

I don't think generating code in the integration test is a good idea.
Could you just add the code generator as a binary target?

Why don't you think it is a good idea? Participants of the performance working group have repeatedly said that build scripts are problematic for performance since they introduce an extra step in the compilation pipeline. It's just a waste of time and resources to have all downstream consumers redo the work that you could be doing at development time.
Several other crates have adopted similar solutions:

https://github.com/async-graphql/async-graphql/pull/901
https://github.com/steveklabnik/semver-parser/pull/50
https://github.com/mattsse/chromiumoxide/pull/80
https://github.com/humenda/isolang-rs/pull/30

I'm not against removing the build script, but I am skeptical about the use of the test script hack for code generation. However, it is also true that your solution does not seem to have obvious drawbacks.

Because it's not what the test script is intended for. For instance, when another program depends on this repo as a path dependency, the code generation isn't triggered by updating names.txt, unlike when using build.rs. Although this might not be a major issue, it can still cause confusion.

That's a fair point, thanks for explaining!


Ignoring the notification and navigating to some warning URL doesn't show up the notification

OS : Windows 8
Steps to reproduce

Install the extension https://chrome.google.com/webstore/a/google.com/detail/chrome-user-experience-su/hgimloonaobbeeagepickockgdcghfnn
Navigate to https://test.hstsfail.appspot.com and observe that the CUES notification displayed at the bottom of the screen.
Ignore the notification and again reload the page - observe

Expected Output:
The  notification should display as the survey is not taken up before
Actual Output:
The notification displays after some time(5 mins) as if the survey was finished before.

Tested on Chrome version 44.0.2363.0

Issue is observed on Mac 10.9.5 using M 44.0.2363.0 as well.

I believe this is WAI, we don't survey people again if they've recently been surveyed.


Tracing: open span for monitoring gateway callbacks

Pull Request type
Please check the type of change your PR introduces:

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build-related changes
[ ] Documentation content changes
[ ] Other (please describe):

What is the current behavior?

Issue Number: N/A
What is the new behavior?

Does this introduce a breaking change?

[ ] Yes
[ ] No

Other information

This change is

crates/papyrus_monitoring_gateway/src/lib.rs line 56 at r1 (raw file):
Previously, dan-starkware wrote…
Also not related, can you fix this to something like:
Monitoring gateway is running, listening on - {}.

Note that I instrumented the run_server function, and now the config is a field in the span.
Not sure if the local_addr function might return a different value, but if not I can just remove the addr from the event (otherwise just add it as a field).
wdyt?


The first line is a Redundant Blank line

When click the copy button, I get the content of the code, but, The first line is always a Redundant Blank line
highlightjs: v11.5.1
highlightjs-copy: 1.03

an example of the copied content like this

I figure out this has nothing to do with  highlightjs-copy.js, this issue will be close

em......I use a linenumber plugin:https://github.com/wcoder/highlightjs-line-numbers.js
I'm not sure I'm not sure that has anything to do with it.
but, why I use another copy plugin, there is no blank first line?

when i manul trim then content text like this: navigator.clipboard.writeText(newText.trim()), it works. no blank first line anymore.


libroach: enable rocksdb logging to a separate file

PR: https://github.com/cockroachdb/cockroach/pull/40681
From release notes:

RocksDB INFO logs are now stored with CockroahDB debug logs. [#40681][#40681] {% comment %}doc{% endcomment %}

This version is no longer supported. Closing.


Problem With Access Token

Hello Team,
I am facing  very weird error, I have initially able to access token on development server, but when I moved that code on production server it automatically stop working. I have added production URL in my project console. Interesting part is that code is exact same. I can't see any error to fix this. Also When I am using 'offline access token' as type it still expire in 1 hour. Please help me with this. Here is my code
         //////////// Index.php

          $google_redirect_url = base_url('index2.php');
	$client = new Google_Client();
	$client->setAuthConfig($this->google_credentials);
	$client->setAccessType("offline");        // offline access
	$client->setIncludeGrantedScopes(true);   // incremental auth
	$client->addScope('https://www.googleapis.com/auth/plus.business.manage');
	$client->setRedirectUri($google_redirect_url);
	$google_auth_url = $client->createAuthUrl();

Here is my code handler.
        //////////// Index2.php
                          $client = new Google_Client();
			$client->setAuthConfig($this->google_credentials);
			$client->setAccessType("offline");
			$client->authenticate($_GET['code']);
			$access_token = $client->getAccessToken();

Hi @ashujangra. Are you having issues with this still?

yes ..

Standard cause for invalid_grant error

Your server’s clock is not in sync with NTP. (Solution: check the server time if its incorrect fix it. )
The refresh token limit has been exceeded.       (Solution: Nothing you can do they cant have more refresh tokens in use)
Applications can request multiple refresh tokens. For example, this is useful in situations where a user wants to install an application on multiple machines.  In this case, two refresh tokens are required, one for each installation. When the number of refresh tokens exceeds the limit, older tokens become invalid. If the application attempts to use an invalidated refresh token, an invalid_grant error response is returned. The limit for each unique pair of OAuth 2.0 client and is 25 refresh tokens (note that this limit is subject to change). If the application continues to request refresh tokens for the same Client/Account pair, once the 26th token is issued, the 1st refresh token that was previously issued will become invalid. The 27th requested refresh token would invalidate the 2nd previously issued token and so on.

Hi @ashujangra,
Did @LindaLawton's information help solve your problem?

Let's close this. However, feel free to reopen @ashujangra


Cannot compile BCBluetooth.m

After a fresh install of the plugin with cordova plugin add https://github.com/bcsphere/bluetooth.git my Xcode project fails to build.
Cordova: 5.3.3
Xcode: 7.0.1
OSX: 10.11.1 Beta (15B38b)

+1

Just updated to adapt to ios 9.1 change. Those API are deprecated. Please check.

The compilation error is fixed for xcode 7.0.1.

Thank you!


search input does not trigger clear event when input is empty

Falsey nature of empty string causes clear to not be called
https://github.com/ExactTarget/fuelux/blob/master/js/search.js#L89

nvm


Add init reference count

This PR fixes the problem of multiple calls to BD init/deinit APIs, by simply adding an init ref count. This is required due to the fact that the mbed-os utility block devices, which may use SD block device as the backing block device, call the underlying init/deinit APIs automatically.
This PR resolves #7455 for the SD block device.

Changes pushed, conforming with @deepikabhavnani's comments.
Note that atomic increment/decrement also isn't used any more, as the class has a built in lock.

@davidsaada - Code changes looks good, before merging the code would like to make sure that the testing is done.

Code changes looks good, before merging the code would like to make sure that the testing is done.

Sure. Tested with all available SD tests (on the K64F board).

Sure. Tested with all available SD tests (on the K64F board).

Thanks for confirming. Will merge


Microsoft 365 Defender REST API Internal Server Error and OData Protocol $filter System Query Option

When interacting with the Microsoft 365 Defender API, an internal server error occurs if the OData Service Model is requested in the JSON format, as specified in the OData v4.01 URL Conventions section 4.1.
The documentation states that in the absence of an error code, Microsoft should be contacted without specifying where/how this should occur.

InternalServerError
Internal Server Error (500)
Note: No error message,  retry the operation or contact Microsoft if it does not get resolved

Could the documentation be completed to indicate how these kinds of errors could be reported? The documentation does further not specify whether the $format system query option is globally supported (as would be required by the OData protocol) or not. This is quite important given model endpoints (e.g.: /incidents) return JSON by default whereas the model endpoint (i.e. /$metadata) returns XML by default.
Compliance with the OData protocol is initially mentioned at Supported Microsoft 365 Defender APIs:

All APIs along the /api path use the OData Protocol; for example, https://api.security.microsoft.com/api/incidents.

=== RUN   TestApi_MetadataJSON
==== Querying	https://api.security.microsoft.com/api/$metadata?%24format=json
==== Response	Code 500
{
  "error": {
    "code": "",
    "message": "An error has occurred."
  }
}
    incident_test.go:31: 500 Internal Server Error
--- FAIL: TestApi_MetadataJSON (2.47s)

=== RUN   TestApi_MetadataXML
==== Querying	https://api.security.microsoft.com/api/$metadata?%24format=xml
==== Response	Code 200
<?xml version="1.0" encoding="utf-8"?><edmx:Edmx Version="4.0" xmlns:edmx="http://docs.oasis-open.org/odata/ns/edmx"><edmx:DataServices><Schema Namespace="microsoft.windowsDefenderATP.api" xmlns="http://docs.oasis-open.org/odata/ns/edm"><EntityType Name="AdvancedHunting"><Key><PropertyRef Name="query" /></Key>...
--- PASS: TestApi_MetadataXML (0.12s)

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 2334c49d-0ba7-e015-b987-ff5aa46fede2
Version Independent ID: b3a79951-1800-3f8d-eb46-a494e9f58e7f
Content: Common Microsoft 365 Defender REST API error codes
Content Source: microsoft-365/security/defender/api-error-codes.md
Product: m365-security
Technology: m365d
GitHub Login: @mjcaparas
Microsoft Alias: macapara

@0xThiebaut Thank you for your feedback. We have made changes to the document via PR#https://github.com/MicrosoftDocs/microsoft-365-docs/pull/5318
Thanks
Sri

@msbemba Thank you very much for the contribution and updating the documentation with PR. @0xThiebaut Hope this update is helpful for you. Thanks for taking out some time to open the issue. Appreciate and encourage you to do the same in future also.


Support in operators with python_version marker

E.g., python_version in "2.6 2.7 3.2 3.3" should be evaluate as python_version == "2.6" or ....
See: https://github.com/astral-sh/uv/issues/3675.

Right now, these are evaluate as Arbitrary.

Working on this...


Confirmation for reset

Could there be a confirmation dialog for the reset button?
Especially since 'reset' and 'restore' are the same size, it's easy to click another out of habit.

Can you share a screenshot? I'm not sure which buttons you mean..

Maybe the buttons could also be redisigned or renamed, because the left symbol is also a common symbol to mean 'reset', and right one could seem like a 'cancel', as in 'do nothing and keep previous'.

I think changing the icons would probably confuse people who are already very familiar with this dialog.
But I think the text labels could be improved.  What if they said "Restore my changes" / "Discard my changes" ?

Yes, that would be an improvement.


Fix TPM12 attestation flow

Do not calc hash for MeasurementIDACMDateInPlace
Correct usage of predefined TPM in attestation flow detection
Tested internally on TPM1.2 hosts

@rihter007 : I suggest you also approve this to get the second approval.

You can't approve your own PR


Remove duplicated lines

You dropped the right lines :) . We actually want to compute the time as soon as possible to minimise the chance of interferenced...


Save dialogs' file name does not start selected anymore

Godot version
4.0 28174d531b7128f0281fc2b88da2f4962fd3513e
System information
Windows 10 64 bits GLES3 GeForce GTX 1060 6GB/PCIe/SSE2
Issue description
In Godot 3, opening a save dialog to save anything (a scene, resource, script...) starts with the file name selected:

In Godot 4, this is no longer the case. So everytime, the user has to manually select to rewrite the intented file name, it is a usability regression:

Steps to reproduce
"Save As" anything: current scene, inspector resource, script
Minimal reproduction project
No response

I this a bug or future request?

May I take this issue?

May I take this issue?


seaweedfs 2.84 - volume.fsck -reallyDeleteFromVolume errors rather than warns on all readonly volumes

If you have a few hundred or a few thousand volumes and try to use "volume.fsck -reallyDeleteFromVolume", you'll get a whole lot of errors due to the readonly volumes, each of them interrupting the process.
I believe this command should only warn about the readonly volumes and continue, not error and abort. It even seems like the command does nothing if it errors. so deleting data not referenced by the filer is maybe currently not possible unless absolutely all volumes are read/write.
Additionally I thought it'd maybe be nice to have a parameter to allow temporarily marking volumes as read/write for the purpose of running this command, so that it runs smoothly and the volumes automatically can return to being readonly in setups where this is desired.

Added a fix to skip read only volumes.

Added a fix to skip read only volumes.

Thank your fixing it this way even if out of expediency.
I actually appreciate the allowance of reads to take a front seat to writes any time... by default at least. I see it as a feature and not a bug. If the maintainer knows I error in this as a fact, please chime in.
If anything is to ever be blocking in today's workflows... let the writes stand to the side while the client gets what already exists in the lake. This allows for async/sync decoupling, as in reality there is no simply choosing one over the other.
As long as you have reads and writes holding different latencies for the same workload you have sync context to deal with in some way. Projects like this one allow for use case cures for these issues instead of another symptomatic medicinal coverup (insert framework here) on the front...
Thank you Chris.
BTW, anyone spitting seeds into beds of SeaweedFS with RedPanda?


lib.systems.extensions.sharedLibrary: do not throw

Description of changes
Because downstream code expects to use == on platform attrsets, we are unfortunately not able to throw a useful error message when the sharedLibrary attribute is accessed.
When users do a comparison like:
stdenv.hostPlatform == pkgsStatic.stdenv.hostPlatform

... in a situation where stdenv.hostPlatform.hasSharedLibraries, they expect this to return false.  Unfortunately Nix does a deep equality comparison here, and ends up forcing the pkgsStatic.stdenv.hostPlatform.extensions.sharedLibrary attribute, which throws the error.
Rather than returning null, this commit instead simply omits the extensions.sharedLibrary attribute.  This provides the user with a more-useful error message: instead of waiting until the null is     used (and hoping that produces an error), the user will get an error    about the extensions.sharedLibrary attribute being missing, at the    position where it was referenced.
Big thanks to @trofi for his PR to add NIX_VALIDATE_EVAL_NONDETERMINISM to Nix, which I am now using.  It made tracking this down really easy!
Fixes #244045

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Another option is not to provide the attribute at all with a fancy computed assignment:
nix-repl> { ${if false then "attr" else null} = 42; }
{ }

nix-repl> { ${if true then "attr" else null} = 42; }
{ attr = 42; }

That way error messages attempting to use irrelevant attribute might be slightly clearer. But I did not test it. Might break more than it fixes.

Updated to implement @trofi's suggestion, but using lib.optionalAttrs instead of dynamic attributes.
No drv-hash change (or eval failure) with NIX_VALIDATE_EVAL_NONDETERMINISM=1 for all my usual builds (mips, powerpc, aarch64, x86_64) as well as tests.cross.sanity.


Search cluster AB test

This adds a (disabled) AB test for search clusters. 95% will go to the A/Default cluster. 5% will go to the new elasticsearch 6 cluster. The expiry for the AB test will be 1 day.
A subsequent PR will activate this test by changing SearchClusterABTest to true in configs/dictionaries/active_ab_tests.yaml.
Follows https://docs.publishing.service.gov.uk/manual/run-ab-test.html#2-how-to-set-up-an-ab-test
Trello: https://trello.com/c/OLcUGWeo/858

Unless something has changed recently, I'm not sure why the VCL for the mirrors has also been updated? In previous A/B tests only for the VCL affecting www-ENV needed to be updated.
Also, I'd suggest enabling this test with initial percentages for traffic to variants as
A: 100%
B: 0%

and a short cookie expiry (though 24 hours as you have it is probably fine).
When this PR is merged we'll invalidate the cache, so if we switch it on with A: 100% to begin with, we'll reduce load on origin at the point when you send traffic to the B variant.

@karlbaker02
Thanks, I changed the percentages to 100 and 0. Am I correct in thinking that the AB test wont be active until this is merged? https://github.com/alphagov/govuk-cdn-config/pull/171/files#diff-40b85c5bdce3d06be10655c29f214e18R9
The code impacting the mirror VCL was autogenerated. It looks like the AB tests are already present there https://github.com/alphagov/govuk-cdn-config/commit/b2443db2450bfe021f195849034f8416ee92f1ea

Yep, that's right Bill. Suggest you probably make it active as part of this PR, then do another PR when you actually want to turn on the A/B test to update the variants.

Thanks, I've changed the test to be active.


fix: set index and value to 0 for array_get with predicate

Description
Problem*
Resolves issue on noir-protocol-circuit and should also resolve issues described in https://github.com/noir-lang/noir/pull/4716.
The issue it resolves is that array_get under a predicate are done at index 0 if the predicate is false, but since arrays are not homogenous, it may contain some value that overflow the type of the array_get.
Summary*
When getting value from an array_get, I multiply it with the predicate to avoid any possible overflow if element at index 0 has not the same type as the expected one.
Additional Context
Documentation*
Check one:

[X] No documentation needed.
[ ] Documentation included in this PR.
[ ] [For Experimental Features] Documentation to be submitted in a separate PR.

PR Checklist*

[X] I have tested the changes locally.
[X] I have formatted the changes with Prettier and/or cargo fmt on default settings.

It would be interesting to compare this against the solution of adding an index offset instead of reading 0 to ensure that we read the correct typed value from the array. This keeps the final value a single witness rather than a quadratic expression so should result in better codegen in later opcodes.

Edit: the above comment isn't a blocker for this PR and I've opened #4972 to follow up on this.

It also seems like we can be smarter about when to multiply in the predicate/add an offset to the index. We only need to do this when the type which we would read is larger than the type we want to read. We can then avoid this in two cases.

The array is homogeneous (I think this would cut out 99% of the circuit size increase we see)
The array is heterogeneous but the type of the first field of the element type is smaller than the type we want to read. i.e. [Struct {foo: bool, bar: Field}; 3] can always read the first field in the flattened array safely and use its value for all other indices.

It also seems like we can be smarter about when to multiply in the predicate/add an offset to the index. We only need to do this when the type which we would read is larger than the type we want to read.

Good point, I have also added the use of the offset when the array is not a nested array. So the rule now is:

if array is not nested, find the offset and use it for the predicate_index, else
if the first element of the array has compatible bit_size, we can use directly the predicate_index, else
fallback to the multiply the value with the predicate.

I have updated the PR description.
I could not get the offset to work with nested arrays but it is definitively do-able. However, almost all cases are now properly optimised.


Can't navigate to dynamic page

So I have a number of pages on my site that 100% of the same, except for data passed from CMS (entry identified by the ID that is passed in).
I decided to remove the /about, /faq, /terms, /privacy pages and replace them with a single /dynamicContent;
Using the express code below, renderer represent that page on the file system that I am using to present the content. The ID is what actually makes the pages different.
  // All Routes we Support from Contentful
  for (const { route, locale, renderer, additions, referrer, id } of routes) {
    server.get(route, (req, res) => {
      if (config.APP_ENV !== 'localhost') {
        renderAndCache(req, res, renderer, { id, locale, referrer, additions });
      } else {
        app.render(req, res, renderer, { id, locale, referrer, additions });
      }
    });
  }

This is what I am using the for the actual pages content.
import { Component } from 'react';
import Connector from '../libs/cms/Connector';
import Layout from '../layouts/Default';
import PageContent from '../components/PageContent';

export default class DynamicContentPage extends Component {
  static async getInitialProps({ query: { id, locale, additions } }) {
    const initProps = await new Promise((resolve) => {
      const cms = new Connector();
      const cmsRet = cms.retrieve(id, locale, additions);
      resolve(cmsRet);
    });
    return initProps || {};
  }

  render() {
    const { site, header, content, footer } = this.props;
    const layout = { site, header, footer };

    return (
      <Layout {...layout} >
        <PageContent {...content} />
      </Layout>
    );
  }
}

Problem - When I enter into a URL domaion.com/about it works, but when I navigate to /about I get a error page, and the following in console.

How do I instruct a link to use a specific renderer from the client side?

Looks like in my route map, I have to store the render and pass that to the client.
Then instead of a link going to /about i send it to /dynamicContent and set as="/about".
Does not look like the url is separated from the file path name of the renderer in the Router.

You probably encounter more problems, I've been in a similar situation, what I recommend is that you have each route within pages and do something like this in each route:
import Home from '../components/home'

export default Home

one of the main problemas that I have was that you can't browse back when you navigate to the same page using a different as prop.

@Goluis - not following what the issue is, can you walk me through that again?

Then instead of a link going to /about i send it to /dynamicContent and set as="/about".

Actually this is our routing system works.
Please read: https://learnnextjs.com/basics/clean-urls-with-route-masking

Makes sense. The issue for me is a little strange.
The content authors in the CMS do not know what actually does the rendering under the hood, they just want the user to navigate to /about.
What I did was create a custom  component and generates the correct params and uses the imperative router solution. Works great. Not sure what @Goluis is suggesting above...


[!] Could not find a default VPC

So we don't have a "default" VPC.  (deleted it)
Need the ability to input the "awsvpc networking" as a command line option.

One design choice I made here in the spirit of "reasonable defaults" was to use the default VPC rather than spinning up an entirely separate VPC or asking the user to select one to not litter a user's account and to prevent option sprawl respectively. My thought was that a user encountering this error could just re-create their default VPC (via http://docs.aws.amazon.com/AmazonVPC/latest/UserGuide/default-vpc.html#create-default-vpc).
It'd be nice to help the user out here though. It seems like this could be tackled a number of different ways. If the default VPC isn't available, we could do one or more of the following options:

return an error and ask the user to provide a VPC ID when creating new services and load balancers and running new tasks
create a new VPC and n subnets (where n = the number of availability zones the account can access)
create a new default VPC (which is a single API call)
continue to blow up, but return a more useful error message explaining how to create a default VPC

I'm learning toward returning a more useful error message as a user might have had good reason not to want a default VPC.
Any thoughts/opinions? Thanks so much for opening this.

I would thing it would be best to provide a VPC ID and Cluster Name on the command line. As we have several Clusters and VPCs that we use to separate out services.

@lecole Thanks. I think I'm sold on adding cluster as a command line option for task and service commands.
I'm still not sure on the above VPC question though. Asking the user to provide a VPC ID seems to introduce mental overhead and could potentially create issues. i.e., I create a load balancer in one VPC, and try to use it in another. Now there's another new magic string I need to correlate. I suppose we could default to the default VPC, and just allow it to be overridden (a la option 1 above).

@jpignata Sounds like a good plan. But what if you also added the VPC as an option and then also implemented option 1. This would give some control over which VPC you want it to go into (without the error), and also as a default have the "default VPC" as the target deployment location.

@lecole Thanks for the input! I'll tinker with this over the next day or two and try to get a 0.2.0 release together with something to address these two pain points.

Sounds good. Great work so far.

Released v0.2.0 to address the above.


Overwrite existing does not work for Targz (or any other Tar implementation of unarchiver)

The cast found at the identified line only works for "Tar" files and not .targz, etc...
https://github.com/anchore/syft/blob/91d7a8a9923a64292f2ab634672951ab4983179b/syft/source/file_source.go#L243
I have a .targz file that has two files named the same thing in different "case" (outside of my control) that I cannot syft on Mac OS because an error is thrown by archiver during unzip/untar process.  This is the result of APFS (encrypted) format of drive being case insensitive by default (really a bogus decision by Apple btw).
While I can syft this file fine on a case sensitive file system it points out the issue with the identified line of code. It will only work for tar files.
I can generate a pull request to fix this but wanted to have a high level discussion on implementation first.
So, step 1. Is there agreement that this is an issue.
Step 2. Let's talk about a solution.
Step 3. I can generate a pull request or the primary contributors can run with the ball.
Cheers,
Jon

👋 hey @jonathannewell I think I'm a little lost on trying to reproduce the issue you're facing can you help before we shake hands and say "Yes! This is a bug"
I created foo.tar.gz and foo.targz on my local.
Are you seeing syft error when it scans either of these archives?
I cannot get syft to error on my local for either
Apple Silicon
Sonoma 14.5

Which case sensitive file system are you using to show the happy path?

Looking at this implementation path, there are some changes we should be making to https://github.com/anchore/syft/blob/91d7a8a9923a64292f2ab634672951ab4983179b/syft/source/file_source.go#L232-L288
Specifically: if the user passes a .tar. or similar, we should no unarchive the contents, we should be getting to a .tar file and using what we have in stereoscope to analyze the archive. If we don't need to extract all files then we shouldn't.


Lua error when running :Octo actions with fzf-lua

Issue Description
Type: bug report
Describe what happened (or what feature you want)
When using fzf-lua as a picker and running :Octo actions, I get this error:
Error executing Lua callback: ...y/octo.nvim/lua/octo/pickers/fzf-lua/pickers/actions.lua:20: attempt to index global 'opts' (a nil value)
stack traceback:
        ...y/octo.nvim/lua/octo/pickers/fzf-lua/pickers/actions.lua:20: in function 'actions'
        ...e/.local/share/nvim/lazy/octo.nvim/lua/octo/commands.lua:1494: in function 'actions'
        ...e/.local/share/nvim/lazy/octo.nvim/lua/octo/commands.lua:22: in function 'o'
        ...e/.local/share/nvim/lazy/octo.nvim/lua/octo/commands.lua:350: in function 'octo'
        ...e/.local/share/nvim/lazy/octo.nvim/lua/octo/commands.lua:16: in function <...e/.local/share/nvim/lazy/octo.nvim/lua/octo/commands.lua:15>

Describe what you expected to happen
How to reproduce it (as minimally and precisely as possible)

Configure:require'octo'.setup {
    picker = 'fzf-lua',
}

Run the :Octo action command

The error comes from this line:
https://github.com/pwntester/octo.nvim/blob/22328c578bc013fa4b0cef3d00af35efe0c0f256/lua/octo/pickers/fzf-lua/pickers/actions.lua#L20C1-L20C57
There is no opts. It is a leftover from somewhere? Does it even need a prompt? It does not look like the Telescope version has one.
If removing the prompt is acceptable, I can make a PR myself (otherwise - I'm not sure where to take the prompt from). I think there are other similar places in the fzf-lua integration, and I can hunt them down as well in the same PR.


Bindings and Life cycle hooks do not work on dynamic component

I'm submitting a ...  (check one with "x")
[x] bug report => search github for a similar issue or PR before submitting
[ ] feature request
[ ] support request => Please do not submit support request here, post on Stackoverflow or Gitter

Current behavior

From my app.component I am creating a new modal instance with a component ModalViewComponent. (The component has been added to the entryComponents.)
this.ngxSmartModalService.create('testModal', ModalViewComponent).open();

The modal opens correctly but the lifecycle hooks (ngOnInit, ngAfterViewInit) of the dynamically loaded component are not called. I have also observed that the template bindings are not working. In the dynamically loaded component there is binding for title that does not render.
Expected behavior

Lifecycle hooks are called and template bindings work.
Reproduction of the problem
I have created a stackblitz that shows the issue. Clicking the Open Modal button displays the modal but none of the lifecycle hooks are called and the template bindings do not render.
https://stackblitz.com/edit/ngx-smart-modal-lifecycle
What is the motivation / use case for changing the behavior?

Please tell us about your environment:

Smart Modal version: 7.3.0

Angular version: 8.2.9

Browser: Chrome 78.0.3904.97

Language: all

Hi @barryajones ,
thanks to reporting this issue (with a stackblitz :metal:) ! I'll check this asap.

Hi @barryajones!
I think this issue is complementary with this one #235. It seems this is common for a lot of projects that would like to handle content projection with dynamic content. 🤔


⚠ Bofrost.fr has degraded performance

In 5bf8eef, Bofrost.fr (https://www.bofrost.fr) experienced degraded performance:

HTTP code: 200
Response time: 1486 ms

Resolved: Bofrost.fr performance has improved in b15cc8e after 6 minutes.


Kotlin 1.0.2

Unfortunately the test still doesn't work when using the GradleRunner. Works fine if you build it locally (and add sqldelight:gradle-plugin:0.3.1 to the classpath) and looks like some weird bug between GradleRunner, Android and Kotlin.

Lgtm. I'll look at the failure in a bit.

the specific error I was seeing is java.lang.ClassCastException: com.android.build.gradle.AppExtension_Decorated cannot be cast to com.android.build.gradle.BaseExtension
but its weird that it worked fine if i built local to that folder. android plugin might be doing something different because its in a test environment?

Looks like the double class path problem. The Android plugin gets added by
us with the class path crap and then by the Kotlin plugin as a transitive
dep
On Fri, May 13, 2016, 12:34 PM Alec Strong<EMAIL_ADDRESS>wrote:

the specific error I was seeing is java.lang.ClassCastException:
com.android.build.gradle.AppExtension_Decorated cannot be cast to
com.android.build.gradle.BaseExtension
but its weird that it worked fine if i built local to that folder. android
plugin might be doing something different because its in a test environment?
—
You are receiving this because you commented.
Reply to this email directly or view it on GitHub
https://github.com/square/sqldelight/pull/279#issuecomment-219139179


fixed problem with shader transparency

This fixes a regression introduced by the transparency fix. The multilight and eyepicking samples should be fixed by this.

Please if possible remove the unnecessary commits. The history is difficult enough to deal with as is.

I reverted one commit from another branch that didn't belong. The rest is from rebasing. I only changed three files.

If you were rebasing there would not be merge commits.

I am using GitHub desktop and doing “Sync”. I thought that did a rebase but I am not really sure.
From: Mihail<EMAIL_ADDRESS>Sent: Friday, June 24, 2016 8:15 AM
To: Samsung/GearVRf<EMAIL_ADDRESS>Cc: Nola Donato<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [Samsung/GearVRf] fixed problem with shader transparency (#634)
If you were rebasing there would not be merge commits.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/Samsung/GearVRf/pull/634#issuecomment-228373608, or mute the threadhttps://github.com/notifications/unsubscribe/AQw1S-jtYaCvRm_uElluAiaFFXflW5kdks5qO_SNgaJpZM4I8bHe.


Use declarative config for setup.py and enable coverage testing

Major changes:

use setuptools and add a declarative config for setup.py
turn on coverage testing (see #323).  You can enable mpmath repo on codecov.io to see coverage statistics (I think, it will be available only after PR merge).
use setuptools_scm to track versions (as you can see, release procedure could be reduced just to commit tagging).  Unfortunately, this require dropping py3.3 support.

Minor stuff:

use xenial dist on Travis
pep8 -> pycodestyle renaming
adapt LICENSE, so github will recognize it
add more classifiers for pypi.org
unbundled the six library

I can split this PR if you prefer.

Thanks, and apologies for the long delay!

use setuptools and add a declarative config for setup.py

Could you explain the advantages (and possible disadvantages) of this?
Could you roll back the unbundling of six.py? I prefer to avoid the external dependency.

Could you explain the advantages (and possible disadvantages) of this?

More declarative config, no code at all. And all projects settings are in one place.
Not sure about disadvantages, maybe version requirements for the setuptools, that disallow ancient stuff.  I can lower this down to 30.3.0.  The price is some repetition for *requires options: we can't reference extras requirements like
tests_require = mpmath[tests]

Could you roll back the unbundling of six.py? I prefer to avoid the external dependency.

Can you explain some technical reasons behind of this?  pip can handle external dependencies well, by design.  In turn, you already have very outdated six.py file, almost uncovered by tests.  An option may be copy&paste only very tiny part of the six, which is actually used and will be well maintained.

It looks like we only depend on exec_ and print_ from six.py. I suppose we could just move those to backend.py? We don't even need the full print_, really; it's just used in a handful of places for concatenating strings.
No dependency = one less thing that can go wrong.

That must be because PY2 isn't covered at all.

Of course.  The question was: should we enable coverage testing on PY2 just for that single function.

I don't understand the problem.

Good! And now the fun game of raising the coverage% begins :)

Does coverage testing ignore doctests?

No.  pytest is collecting doctests per default (i.e. we run it with --doctest-modules):
$ py.test mpmath/calculus/optimization.py
============================= test session starts ==============================
platform linux -- Python 3.7.1, pytest-4.2.0, py-1.7.0, pluggy-0.8.1
hypothesis profile 'default' -> database=DirectoryBasedExampleDatabase('/home/sk/src/mpmath/.hypothesis/examples')
rootdir: /home/sk/src/mpmath, inifile: setup.cfg
plugins: xdist-1.26.1, timeout-1.3.3, forked-1.0.1, cov-2.6.1, hypothesis-4.4.3
collected 3 items

mpmath/calculus/optimization.py ...                                      [100%]

=========================== 3 passed in 0.37 seconds ===========================

But there may be problems, which I miss, may be with dynamic docstrings or something.

Example: libmp.libintmath.stirling1 is reported as not covered, but should be covered via the doctest for mpmath.stirling1.
Another example: functions.qfunctions.qhyper is reported as not covered, but has its own doctests.

libmp.libintmath.stirling1 is reported as not covered, but should be covered via the doctest for mpmath.stirling1.
Another..

I see.  These seems to be the mentioned above cases with dynamic __doc__.

That's bizarre -- the docstrings in functions/qfunctions.py are not dynamic.
In either case, if the test runner doesn't run all doctests, that's not good.

the docstrings in functions/qfunctions.py are not dynamic

Hmm, indeed.  This case seems to be related with broken defun* decorators, see #432.


Add native target: iOS

Should be as easy as adding the common target ios(), unless you don't have HMPP enabled, in which case the more specific targets:
iosArm32
iosArm64
iosX64
iosSimulatorArm64

Should be solved by #148