"access violation" problem

Reporting a bug

[x] I am using the latest released version of Numba
[x] I have included below a minimal working reproducer

Thank you all for developing numba! I'm now using numba 0.49.1 with cuda 10.2.89 on python 3.7.5, windows 10. I have a problem in my code that it... sometimes fail to execute due to OSError: exception: access violation reading 0x<non-zero-non-0xFF...address>.
cuda-memcheck.exe shows nothing.
The memory access violation occurs every time in the numba\cuda\cudadrv\nvvm.py in compile(self, **options), line 232, err = self.driver.nvvmCompileProgram(self._handle, len(opts), c_opts)
---------------------------------------------------------------------------
OSError                                   Traceback (most recent call last)
 in
     39 arr2 = np.arange(16,dtype=np.int8)
     40 arr5 = np.zeros(16*16,dtype=np.int8)
---> 41 foo[2, 16](arr1,arr2,arr5)   # more threads than array elements

V:\Program Files\Python\lib\site-packages\numba\cuda\compiler.py in __call__(self, *args)
    756         Specialize and invoke this kernel with *args*.
    757         '''
--> 758         kernel = self.specialize(*args)
    759         cfg = kernel[self.griddim, self.blockdim, self.stream, self.sharedmem]
    760         cfg(*args)

V:\Program Files\Python\lib\site-packages\numba\cuda\compiler.py in specialize(self, *args)
    767         argtypes = tuple(
    768             [self.typingctx.resolve_argument_type(a) for a in args])
--> 769         kernel = self.compile(argtypes)
    770         return kernel
    771

V:\Program Files\Python\lib\site-packages\numba\cuda\compiler.py in compile(self, sig)
    786             self.definitions[(cc, argtypes)] = kernel
    787             if self.bind:
--> 788                 kernel.bind()
    789         return kernel
    790

V:\Program Files\Python\lib\site-packages\numba\cuda\compiler.py in bind(self)
    528         Force binding to current CUDA context
    529         """
--> 530         self._func.get()
    531
    532     @property

V:\Program Files\Python\lib\site-packages\numba\cuda\compiler.py in get(self)
    405         cufunc = self.cache.get(device.id)
    406         if cufunc is None:
--> 407             ptx = self.ptx.get()
    408
    409             # Link

V:\Program Files\Python\lib\site-packages\numba\cuda\compiler.py in get(self)
    376             arch = nvvm.get_arch_option(*cc)
    377             ptx = nvvm.llvm_to_ptx(self.llvmir, opt=3, arch=arch,
--> 378                                    **self._extra_options)
    379             self.cache[cc] = ptx
    380             if config.DUMP_ASSEMBLY:

V:\Program Files\Python\lib\site-packages\numba\cuda\cudadrv\nvvm.py in llvm_to_ptx(llvmir, **opts)
    493     cu.add_module(libdevice.get())
    494
--> 495     ptx = cu.compile(**opts)
    496     # XXX remove debug_pubnames seems to be necessary sometimes
    497     return patch_ptx_debug_pubnames(ptx)

V:\Program Files\Python\lib\site-packages\numba\cuda\cudadrv\nvvm.py in compile(self, **options)
    229         c_opts = (c_char_p * len(opts))(*[c_char_p(x.encode('utf8'))
    230                                           for x in opts])
--> 231         err = self.driver.nvvmCompileProgram(self._handle, len(opts), c_opts)
    232         self._try_error(err, 'Failed to compile\n')
    233

OSError: exception: access violation reading 0x000002087936AB58

If run the program again, it shows CudaAPIError: [500] Call to cuModuleGetFunction results in CUDA_ERROR_NOT_FOUND.
Here's a reproducer works on my machine:
import numpy as np
import numba
from numba import cuda

sbox = np.array([0,1,2,3,4,5,6,7,8,9,10,11,12,13,14,15],dtype=np.int8)
pbox = np.array([15,14,13,12,11,10,9,8,7,6,5,4,3,2,1,0],dtype=np.int8)

@cuda.jit(device=True)
def bar(txt,el,r):
  cudas_box=cuda.const.array_like(sbox)
  cudap_box=cuda.const.array_like(pbox)
  if r!=0:
    temp=cuda.local.array(16,numba.int8)

    #error do not occur if either for loop is removed
    for i in range(16):
      temp[i]=cudas_box[txt[cudap_box[i]]]
    for i in range(16):
      txt[i]=temp[i]

  return txt[10]+el

@cuda.jit(debug=True)
def foo(arr1,arr2,arr5):
  tx = cuda.threadIdx.x
  ty = cuda.blockIdx.x
  bw = cuda.blockDim.x
  pos = tx + ty * bw

  pos1=pos%16
  pos2=(pos//16)%16
  if pos<len(arr5):
    roundtext=cuda.local.array(16,numba.int8)
    for i in range(16):
      roundtext[i]=arr1[pos1][i]
    arr5[pos] = bar(roundtext,arr2[pos2],pos%2)

arr1 = np.arange(16,dtype=np.int8).repeat(16).reshape(16,16)
arr2 = np.arange(16,dtype=np.int8)
arr5 = np.zeros(16*16,dtype=np.int8)
foo[2, 16](arr1,arr2,arr5)

Thanks for the report and nice reproducer! I can reproduce this.

Hi, I have a similar problem and it is very annoying (OSError: exception: access violation reading ... in nvvm.py) see https://github.com/numba/numba/issues/4783 . I managed to upload a minimal reproducer (see https://gitlab.com/pittnerf1/test-project-for-numba-and-cuda-functions/-/tree/master ) which crashes on both Windows 10 and Google Colab, too.

For me, the reproducer is intermittently segfaulting, and repeated runs reduce the likelihood of segfault.

I believe #6030 will fix this.

Closing now that #6030 is merged.

Since these errors still pop up on occasion (as it did for me), debugging with Cuda Simulator seems to help pinpoint the source of the error in the code. See my answer for Numba code compilation for CUDA GPU fails with OSError: exception: access violation reading

Thanks for linking to the answer. This issue was caused by some transformations that were done to the IR that made it invalid when passing it to NVVM. However, for errors in user code using the simulator can also be a good option. If the simulator is too slow, then one can also add debug=True,opt=False kwargs to the @cuda.jit decorator and run under compute-sanitizer (e.g. compute-sanitizer python bug.py - if there are any source lines with invalid accesses these will be reported. It's not as interactive / deep a tool for CUDA Python code as the CUDA simulator, but it is a lot faster.

@gmarkall good distinction. Thank you!


Connection pool support

Instead of a new connection for each flipper instance, it would be nice to use connection pooling.
In config/initializers/redis.rb we have:
$redis = ConnectionPool.new(size: [ENV['REDIS_POOL'].to_i, 1].max) { Redis.new(url: ENV['REDIS_URL'])  }

in config/initializers/flipper.rb we want to do the following:
require 'flipper'
require 'flipper/adapters/redis'
require 'flipper/adapters/active_support_cache_store'

Flipper.configure do |config|
  config.adapter do
    Flipper::Adapters::ActiveSupportCacheStore.new(
      Flipper::Adapters::Redis.new($redis),
      ActiveSupport::Cache::MemoryStore.new,
      expires_in: 10.seconds
    )
  end
end

However this fails when using flipper since the methods required for redis are not defined on the connection pool. To access the redis methods you have to do:
$redis.with do |redis|
  # do operations on redis
end

Do you think we can add support? I'm happy to work on it

I have this to proxy methods through a connection pool but it is not as optimal as native support:
class ConnectionPoolProxy
  def initialize(pool)
    @pool = pool
    @instance_class = pool.with(&:class)
  end

  def method_missing(method_name, *args, &block)
    @pool.with { |instance| instance.public_send(method_name, *args, &block) }
  end

  def respond_to_missing?(method_name, _ = false)
    @instance_class.public_instance_methods.include?(method_name.to_sym)
  end
end

You can also just make a new flipper adapter. That said, I'm cool with a RedisConnectionPool adapter in flipper. Seems good to me.

I'm going to close this issue to keep things tidy but if you have any more questions let me know. Happy to merge a PR for a connection pool adapter.

Also if I wasn't clear before, which re-reading I'm wondering if I was, what I meant is we could add RedisConnectionPool adapter in flipper. I'd start by copying the redis one and then adding the necessary pool.with blocks around accessing redis.

@jnunemaker Did anything ever come of this? It would be really great to have an adapter that use the Redis connection pool.

It would also be great to have connection pool support for Redis in the RedisCache adapter.

@cymen no, but we'd gladly accept a pull request that adds a Redis connection pool adapter.

@bkeepers sounds good -- I wrote one and opened a PR here https://github.com/flippercloud/flipper/pull/826

@bkeepers I came up with a solution as well https://github.com/flippercloud/flipper/pull/839

Just wanted to say that I would love to see one of these solutions make it in :)


valgrind diagnosed errors

==642== Invalid read of size 8
==642==    at 0x38C45F: CubbyFlow::MatrixCSR<double> CubbyFlow::MatrixCSR<double>::BinaryOp<std::plus<double> >(CubbyFlow::MatrixCSR<double> const&, std::plus<double>) const (in /home/msca8h/projects/CubbyFlow/bin/UnitTests)
==642==    by 0x375A64: MatrixCSR_BinaryOperatorMethods_Test::TestBody() (in /home/msca8h/projects/CubbyFlow/bin/UnitTests)
==642==    by 0x71EDB9: void testing::internal::HandleExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) (in /home/msca8h/projects/CubbyFlow/bin/UnitTests)
==642==    by 0x714B9C: testing::Test::Run() [clone .part.534] (in /home/msca8h/projects/CubbyFlow/bin/UnitTests)
==642==    by 0x7151AC: testing::TestInfo::Run() [clone .part.535] (in /home/msca8h/projects/CubbyFlow/bin/UnitTests)
==642==    by 0x715404: testing::TestCase::Run() [clone .part.536] (in /home/msca8h/projects/CubbyFlow/bin/UnitTests)
==642==    by 0x71668E: testing::internal::UnitTestImpl::RunAllTests() [clone .part.550] (in /home/msca8h/projects/CubbyFlow/bin/UnitTests)
==642==    by 0x7169D1: testing::UnitTest::Run() (in /home/msca8h/projects/CubbyFlow/bin/UnitTests)
==642==    by 0x1B2F31: main (in /home/msca8h/projects/CubbyFlow/bin/UnitTests)
==642==  Address 0x5df3cb0 is 0 bytes after a block of size 16 alloc'd
==642==    at 0x4C2D52F: operator new(unsigned long) (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==642==    by 0x381573: void std::vector<unsigned long, std::allocator<unsigned long> >::_M_realloc_insert<unsigned long const&>(__gnu_cxx::__normal_iterator<unsigned long*, std::vector<unsigned long, std::allocator<unsigned long> > >, unsigned long const&) (in /home/msca8h/projects/CubbyFlow/bin/UnitTests)
==642==    by 0x382279: CubbyFlow::MatrixCSR<double>::Compress(std::initializer_list<std::initializer_list<double> > const&, double) (in /home/msca8h/projects/CubbyFlow/bin/UnitTests)
==642==    by 0x36CF2C: CubbyFlow::MatrixCSR<double>::MatrixCSR(std::initializer_list<std::initializer_list<double> > const&, double) [clone .constprop.439] (in /home/msca8h/projects/CubbyFlow/bin/UnitTests)
==642==    by 0x375A3B: MatrixCSR_BinaryOperatorMethods_Test::TestBody() (in /home/msca8h/projects/CubbyFlow/bin/UnitTests)
==642==    by 0x71EDB9: void testing::internal::HandleExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) (in /home/msca8h/projects/CubbyFlow/bin/UnitTests)
==642==    by 0x714B9C: testing::Test::Run() [clone .part.534] (in /home/msca8h/projects/CubbyFlow/bin/UnitTests)
==642==    by 0x7151AC: testing::TestInfo::Run() [clone .part.535] (in /home/msca8h/projects/CubbyFlow/bin/UnitTests)
==642==    by 0x715404: testing::TestCase::Run() [clone .part.536] (in /home/msca8h/projects/CubbyFlow/bin/UnitTests)
==642==    by 0x71668E: testing::internal::UnitTestImpl::RunAllTests() [clone .part.550] (in /home/msca8h/projects/CubbyFlow/bin/UnitTests)
==642==    by 0x7169D1: testing::UnitTest::Run() (in /home/msca8h/projects/CubbyFlow/bin/UnitTests)
==642==    by 0x1B2F31: main (in /home/msca8h/projects/CubbyFlow/bin/UnitTests)

==642== Conditional jump or move depends on uninitialised value(s)
==642==    at 0x3B3F46: CubbyFlow::Matrix<double, 5ul, 5ul>::Invert() (in /home/msca8h/projects/CubbyFlow/bin/UnitTests)
==642==    by 0x3B1141: Matrix_ComplexGetters_Test::TestBody() (in /home/msca8h/projects/CubbyFlow/bin/UnitTests)
==642==    by 0x71EDB9: void testing::internal::HandleExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) (in /home/msca8h/projects/CubbyFlow/bin/UnitTests)
==642==    by 0x714B9C: testing::Test::Run() [clone .part.534] (in /home/msca8h/projects/CubbyFlow/bin/UnitTests)
==642==    by 0x7151AC: testing::TestInfo::Run() [clone .part.535] (in /home/msca8h/projects/CubbyFlow/bin/UnitTests)
==642==    by 0x715404: testing::TestCase::Run() [clone .part.536] (in /home/msca8h/projects/CubbyFlow/bin/UnitTests)
==642==    by 0x71668E: testing::internal::UnitTestImpl::RunAllTests() [clone .part.550] (in /home/msca8h/projects/CubbyFlow/bin/UnitTests)
==642==    by 0x7169D1: testing::UnitTest::Run() (in /home/msca8h/projects/CubbyFlow/bin/UnitTests)
==642==    by 0x1B2F31: main (in /home/msca8h/projects/CubbyFlow/bin/UnitTests)

==642== Conditional jump or move depends on uninitialised value(s)
==642==    at 0x3B131B: Matrix_ComplexGetters_Test::TestBody() (in /home/msca8h/projects/CubbyFlow/bin/UnitTests)
==642==    by 0x71EDB9: void testing::internal::HandleExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) (in /home/msca8h/projects/CubbyFlow/bin/UnitTests)
==642==    by 0x714B9C: testing::Test::Run() [clone .part.534] (in /home/msca8h/projects/CubbyFlow/bin/UnitTests)
==642==    by 0x7151AC: testing::TestInfo::Run() [clone .part.535] (in /home/msca8h/projects/CubbyFlow/bin/UnitTests)
==642==    by 0x715404: testing::TestCase::Run() [clone .part.536] (in /home/msca8h/projects/CubbyFlow/bin/UnitTests)
==642==    by 0x71668E: testing::internal::UnitTestImpl::RunAllTests() [clone .part.550] (in /home/msca8h/projects/CubbyFlow/bin/UnitTests)
==642==    by 0x7169D1: testing::UnitTest::Run() (in /home/msca8h/projects/CubbyFlow/bin/UnitTests)
==642==    by 0x1B2F31: main (in /home/msca8h/projects/CubbyFlow/bin/UnitTests)

Mostly related to

Matrix_ComplexGetters_Test::TestBody()
CubbyFlow::Matrix<double, 5ul, 5ul>::Invert()
CubbyFlow::MatrixCSR CubbyFlow::MatrixCSR::BinaryOp<std::plus >(CubbyFlow::MatrixCSR const&, std::plus)

Thanks to analyze it.
Fixed matrix logic error in 083a1a.


Update arkworks to allow commitment generation without private key

Codecov Report
Base: 66.76% // Head: 66.60% // Decreases project coverage by -0.16% :warning:

Coverage data is based on head (9c9ea0c) compared to base (b2cd5cb).
Patch coverage: 34.33% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #221      +/-   ##
==========================================
- Coverage   66.76%   66.60%   -0.15%
==========================================
  Files          30       30
  Lines        2337     2425      +88
==========================================
+ Hits         1560     1615      +55
- Misses        777      810      +33

Impacted Files
Coverage Δ

arkworks-setups/src/aead.rs
0.00% <0.00%> (ø)

arkworks-setups/src/lib.rs
0.00% <ø> (ø)

arkworks-setups/src/r1cs/vanchor/tests.rs
99.67% <ø> (-0.33%)
:arrow_down:

arkworks-setups/src/utxo.rs
42.86% <16.67%> (-13.28%)
:arrow_down:

arkworks-setups/src/r1cs/vanchor/mod.rs
54.40% <37.04%> (-1.90%)
:arrow_down:

arkworks-setups/src/keypair.rs
64.00% <60.00%> (-1.00%)
:arrow_down:

arkworks-r1cs-circuits/src/vanchor.rs
81.40% <0.00%> (-3.48%)
:arrow_down:

arkworks-setups/src/r1cs/anchor/mod.rs
30.73% <0.00%> (-2.08%)
:arrow_down:

arkworks-native-gadgets/src/poseidon/mod.rs
54.49% <0.00%> (-1.37%)
:arrow_down:

arkworks-native-gadgets/src/merkle_tree.rs
61.97% <0.00%> (-0.61%)
:arrow_down:

... and 7 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


TypeError: Cannot set property $ref of # which has only a getter

When using the mock server with the attached openapi definition that validates just fine at https://validator.swagger.io/ I consistently get the following error when using prism mock ./openapi.yml instead of starting the mock server:
TypeError: Cannot set property $ref of #<Object> which has only a getter
    at Object.onProperty (/Users/user/.nvm/versions/node/v18.6.0/lib/node_modules/@stoplight/prism-cli/node_modules/@stoplight/json/index.cjs.js:1:4846)
    at _traverse (/Users/user/.nvm/versions/node/v18.6.0/lib/node_modules/@stoplight/prism-cli/node_modules/@stoplight/json/index.cjs.js:1:3579)
    at _traverse (/Users/user/.nvm/versions/node/v18.6.0/lib/node_modules/@stoplight/prism-cli/node_modules/@stoplight/json/index.cjs.js:1:3672)
    at _traverse (/Users/user/.nvm/versions/node/v18.6.0/lib/node_modules/@stoplight/prism-cli/node_modules/@stoplight/json/index.cjs.js:1:3672)
    at _traverse (/Users/user/.nvm/versions/node/v18.6.0/lib/node_modules/@stoplight/prism-cli/node_modules/@stoplight/json/index.cjs.js:1:3672)
    at _traverse (/Users/user/.nvm/versions/node/v18.6.0/lib/node_modules/@stoplight/prism-cli/node_modules/@stoplight/json/index.cjs.js:1:3672)
    at _traverse (/Users/user/.nvm/versions/node/v18.6.0/lib/node_modules/@stoplight/prism-cli/node_modules/@stoplight/json/index.cjs.js:1:3672)
    at _traverse (/Users/user/.nvm/versions/node/v18.6.0/lib/node_modules/@stoplight/prism-cli/node_modules/@stoplight/json/index.cjs.js:1:3672)
    at _traverse (/Users/user/.nvm/versions/node/v18.6.0/lib/node_modules/@stoplight/prism-cli/node_modules/@stoplight/json/index.cjs.js:1:3672)
    at _traverse (/Users/user/.nvm/versions/node/v18.6.0/lib/node_modules/@stoplight/prism-cli/node_modules/@stoplight/json/index.cjs.js:1:3672)

Environment: MacOS 12.4, NodeJS 18.6.0 and 16.15.0 (tried both)

Hi @keyboardsamurai, thank you for reporting this! Could you provide a minimum reproducible example that illustrates this issue? That will help us pinpoint exactly what about a ref could cause this.

Hi @chohmann, thank you for taking the time to look into this issue. I'd be happy to provide a working setup but I'm not sure what I should gather besides the attached spec. Do you have something specific in mind, like a dockerized demo of the issue?

Hi @keyboardsamurai! I was thinking just a smaller spec with one ref that illustrates the issue. It's hard to tell from the spec you provided exactly which ref is causing the issue. So a very simple spec would be greatly appreciated!

@chohmann I was able to narrow this particular issue down to the cyclic dependency for PydanticDocument described in this minimal openapi spec below. Hope this helps
openapi: 3.0.2
info:
  title: My Jina Service
  description: Desc
  version: 3.6.13
paths:
  "/update":
    put:
      summary: "/Update"
      description: Post data requests to the Flow. Executors with `@requests(on="/update")`
        will respond.
      operationId: _update_update_put
      requestBody:
        content:
          application/json:
            schema:
              "$ref": "#/components/schemas/JinaRequestModel"
        required: true
components:
  schemas:
    JinaRequestModel:
      title: JinaRequestModel
      type: object
      properties:
        data:
          anyOf:
            - type: array
              items:
                "$ref": "#/components/schemas/PydanticDocument"
    PydanticDocument:
      title: PydanticDocument
      type: object
      properties:
        chunks:
          title: Chunks
          type: array
          items:
            "$ref": "#/components/schemas/PydanticDocument"

A previous ticket regarding circular references: https://github.com/stoplightio/prism/issues/1456

I see same error when testing with docker image v4.10.1. It fails to start the mock:
 [11:35:16 AM] › [CLI] …  awaiting  Starting Prism…
 [11:35:18 AM] › [CLI] ✖  fatal     Cannot set property $ref of #<Object> which has only a getter

But I am able to start Prism mock when using docker image v4.10.0.
So maybe there was a regression in v4.10.1?

I am able to start Prism mock when using v4.2.5.
I install prism by yarn add<EMAIL_ADDRESS>I see same error when using v4.10.0 and v4.10.1.

I downloaded Stoplight Studio here: https://github.com/stoplightio/studio/releases
And with the assumption that Stoplight Studio "Mocks" feature is powered by Prism:

Version "v2.8.1" also has this issue (toggle Dev Tools to see it)
Whereas, version "2.8.1" doesn't
(the difference is the letter "v" at the beginning)

I'm encountering the same issue on my end. After trying it out, it appears that my spec stopped successfully compiling on
v4.9.x and  above.

Hey team! Please add your planning poker estimate with ZenHub @brendarearden @daniel-white @EdVinyard @fcasad

thanks all. i'm starting to take a look to see what is going on

i'm not able to directly reproduce in my dev environment but running this spec under docker does cause problems (both node16 and node18)

hey @keyboardsamurai  @steffidg @hieucd04 @theold190 - i just cut 4.10.3. i'm hoping this solves your use cases. if not please come back and open new issues with new examples. thanks!


optimize: optimize release savepoint when use oracle

Signed-off-by: slievrly<EMAIL_ADDRESS>
Ⅰ. Describe what this PR did
optimize: optimize release savepoint when use oracle
Ⅱ. Does this pull request fix one issue?
fix  #2794
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews

Codecov Report

Merging #3523 (1deb585) into develop (fa3791e) will decrease coverage by 0.12%.
The diff coverage is 25.00%.

@@              Coverage Diff              @@
##             develop    #3523      +/-   ##
=============================================
- Coverage      51.58%   51.46%   -0.13%
+ Complexity      3401     3398       -3
=============================================
  Files            621      621
  Lines          20655    20629      -26
  Branches        2579     2533      -46
=============================================
- Hits           10655    10616      -39
+ Misses          8933     8923      -10
- Partials        1067     1090      +23

Impacted Files
Coverage Δ
Complexity Δ

...ta/rm/datasource/exec/SelectForUpdateExecutor.java
81.25% <25.00%> (ø)
10.00 <0.00> (ø)

...obuf/convertor/BranchRegisterRequestConvertor.java
90.47% <0.00%> (-9.53%)
3.00% <0.00%> (ø%)

...otobuf/convertor/BranchReportRequestConvertor.java
90.90% <0.00%> (-9.10%)
3.00% <0.00%> (ø%)

...obuf/convertor/BranchRollbackRequestConvertor.java
92.00% <0.00%> (-8.00%)
3.00% <0.00%> (ø%)

...otobuf/convertor/GlobalBeginResponseConvertor.java
92.59% <0.00%> (-7.41%)
3.00% <0.00%> (ø%)

...n/src/main/java/io/seata/common/util/IdWorker.java
77.08% <0.00%> (-6.25%)
11.00% <0.00%> (-1.00%)

...otobuf/convertor/GlobalCommitRequestConvertor.java
93.75% <0.00%> (-6.25%)
3.00% <0.00%> (ø%)

...otobuf/convertor/GlobalStatusRequestConvertor.java
93.75% <0.00%> (-6.25%)
3.00% <0.00%> (ø%)

...obuf/convertor/GlobalRollbackRequestConvertor.java
93.75% <0.00%> (-6.25%)
3.00% <0.00%> (ø%)

...protobuf/convertor/RegisterTMRequestConvertor.java
94.73% <0.00%> (-5.27%)
3.00% <0.00%> (ø%)

... and 28 more

changes 1.5.0.md


Compatibility with koa-logger

koa-logger is a Koa middleware that calls a user supplied callback at the start and end of requests, so as to print information such as latency, status code, etc.
When the callback is called at the beginning of the request we have access to the cls context. However, when we are called at the end this context is not there. This is because the callback is called in the context of a "finished" or "close" event on  ctx.res.  Relevant code.
I've made it work by altering the module code:
const namespace = cls.createNamespace();
res.once('finish', namespace.bind(onfinish));

Is there any way to do just from my app side?

Merged the pull request, now it is released with version 1.2.0


README

README
User Story
As a boot camp student,
I want the prework notes to be structured on a webpage,
So that I can easily find and read the information.
Acceptance Criteria
GIVEN the prework project repository,
WHEN I view the README for the repository,
THEN I can see a professional README that provides information on the project and how to use it

Who doesn't like documenting their code??


[WIP] Offline upgrade

Initial pass at implementing offline upgrades. The upgrade follows the process outlined in #255. That is, the upgrade proceeds, one node at a time. Once the nodes are upgraded, the private registry and cluster services are upgraded next.
This PR also attempts to DRY up the execute.go file. I think it's a first step towards a refactor of this code.
The following is the output for a 3 node cluster on AWS:
> ./kismatic upgrade offline

Computing upgrade plan==============================================================
Reading plan file                                                               [OK]
Validate SSH connectivity to nodes                                              [OK]

Validating nodes====================================================================
1/1....  Run Upgrade Pre-Flight Checks                                          [OK]

Upgrade Node "ip-10-0-3-105"========================================================
1/11...  Install Kismatic packages                                              [OK]
2/11...  Upgrade Kubernetes Etcd Cluster                                        [OK]
3/11...  Upgrade Networking Etcd Cluster                                        [OK]
4/11...  Upgrade Docker                                                         [OK]
5/11...  Upgrade Cluster Network                                                [OK]
6/11...  Update Kismatic version file                                           [OK]

Upgrade Node "ip-10-0-3-69"=========================================================
1/11...  Install Kismatic packages                                              [OK]
2/11...  Upgrade Kubernetes API Server                                          [OK]
3/11...  Upgrade Kubernetes Scheduler                                           [OK]
4/11...  Upgrade Kubernetes Controller Manager                                  [OK]
5/11...  Upgrade Docker                                                         [OK]
6/11...  Upgrade Cluster Network                                                [OK]
7/11...  Upgrade Kubelet                                                        [OK]
8/11...  Upgrade Kubernetes Proxy                                               [OK]
9/11...  Update Kismatic version file                                           [OK]

Upgrade Node "ip-10-0-3-200"========================================================
1/11...  Install Kismatic packages                                              [OK]
2/11...  Upgrade Docker                                                         [OK]
3/11...  Upgrade Cluster Network                                                [OK]
4/11...  Upgrade Kubelet                                                        [OK]
5/11...  Upgrade Kubernetes Proxy                                               [OK]
6/11...  Update Kismatic version file                                           [OK]

Upgrade Cluster Services============================================================
1/3....  Upgrade Kubernetes DNS                                                 [OK]
2/3....  Upgrade Kubernetes Ingress                                             [OK]
3/3....  Upgrade Kubernetes Dashboard                                           [OK]

Upgrade complete

Outstanding questions / challenges:

[ ] Play reuse? I don't know if we can reuse the play files, given that during the upgrade, the plays should have different names.
[ ] Upgrade with internal docker registry - Since we introduced the disconnected installation flag with default = false, upgrading from a previous version that used an internal docker registry fails because disconnected_installation: false and the images are not available to be pushed into the registry.
[ ] Integration with changes to deployment approach (using pod specs)
[ ] Figure out play numbering in output
[ ] Figure out why the docker and cluster network plays are running for etcd nodes
[ ] Run smoke test after upgrade?

@dkoshkin Thanks for the review. I addressed your comments, minus the DNS which is outstanding. PTAL

We have decided to merge this branch and perform follow up work in subsequent PRs.


Differences about the result after improvement of performance

Hi,
I've trained your network on my own dataset. Everything is going well before generating new performance caffemodel of deploy version.
However, there are too many false positive bounding boxes with the deploy model.
You can see the differences as followed:
MobileNetSSD_deploy_bn.prototxt

MobileNetSSD_deploy.prototxt

I'd like to know how to fix this problem.
And how much performance improvement with the merge_bn version?
Thanks

It adds batchnorm layer.

@haopo2005, have you found the solution? i met the same problem

@ujsyehao did you find the root cause of this issue? can you share?


Hotfix/fix fs event overload

@bryphe @CrossR important bugfix here, noted since I merged in the FileWatcher that if you switch project roots the filesystem watcher would send an event for all the subdirectories and files of the newly watched directory resulting in 100s of events which bombard oni.
I've added a throttle off 300ms to the events being fired to stop the bombardment
Discussion Points: Wasn't sure if it would be preferable to throttle the refresh dispatch, and have the watcher respond with all the events it receives?

@bryphe @CrossR important bugfix here, noted since I merged in the FileWatcher that if you switch project roots the filesystem watcher would send an event for all the subdirectories and files of the newly watched directory resulting in 100s of events which bombard oni.

Ah good catch... that would be brutal!

Discussion Points: Wasn't sure if it would be preferable to throttle the refresh dispatch, and have the watcher respond with all the events it receives?

Yes, perhaps it makes sense actually to move this logic to our refreshEpic in ExplorerStore - I can't think of a scenario where we'd want to refresh that aggressively.
We could use auditTime  on our epic there, like:
    action$.ofType("REFRESH")
   .auditTime(300)
   .mergeMap(() => {
        const state = store.getState()

        return Object.keys(state.expandedFolders).map(p => {
            return Actions.expandDirectory(p)
        })
    })

I think this approach may actually be preferable, because based on the interface of the FileSystemWatcher - if we had several 'add' or 'move' events happen in succession, I believe we'd actually drop some of those with the throttle (we'd only get the first/last depending on what the leading/trailing defaults are). So if something else depending on the FileSystemWatcher, it might lead to confusing or unintuitive behavior - it wouldn't be clear why sometimes in high-frequency changes we'd drop events.

@bryphe changed this PR to use auditTime as you suggested and this seems to work quite well

@bryphe just wanted to mention somewhere since I know you plan on releasing soon that I think this PR might be required before release or alternatively reverting the FSWatcher as the bombardment really negatively impacts user experience when loading a project folder (btw I've been running this PR locally and it resolves the issue v. well).

Awesome, thanks @Akin909 ! Change looks great.  Appreciate you calling out that we should include, I'll make sure it's included in 0.3.3 👍


Move PackageStatistics out of the main NuGetGallery database

Moving issue NuGet/Home#860 here.

Will be fixed with CDN-based statistics - https://github.com/NuGet/NuGetGallery/issues/2503


Improve developer experience with finishIfInvalidAuth()

Some users are forgetting to call finishIfInvalidAuth() in their onAttach method in their fragments.
Since the users call it in their Activity, this usually works in development.  But when the Activity is destroyed, the Fragment can be recreated during the super.onCreate() call in the Activity.  This causes a crash when the Fragment tries to call inject().
It would be good to either add a lint rule to check for this, see if there is a way to remove the need to call finishIfInvalidAuth() in the Fragment, or be more explicit when this is missed.

Yes. I think we could a lint rule that checks that all fragments that implement AuthRequiredFragment or AuthOptionalFragment should always call finishIfInvalidAuth() on their onAttach() method. AuthAwareFragment should be safe, because they always rely on their parent Fragment / Activity.
We might also want to add concrete class versions of all of the base interfaces. However, this would violate one of our Guiding Principles: composition over inheritance. But I can see how there's people that actually want to make it as part of their fragment / activities tree to avoid having to call finishIfInvalidAuth() all the time.

Yes. I think we could a lint rule that checks that all fragments that implement AuthRequiredFragment or AuthOptionalFragment should always call finishIfInvalidAuth() on their onAttach() method. AuthAwareFragment should be safe, because they always rely on their parent Fragment / Activity.
We might also want to add concrete class versions of all of the base interfaces. However, this would violate one of our Guiding Principles: composition over inheritance. But I can see how there's people that actually want to make it as part of their fragment / activities tree to avoid having to call finishIfInvalidAuth() all the time.

Since already a processor might as well fail during compilation than lint

Since already a processor might as well fail during compilation than lint


ZlibDecoder does not support preset dictionary

Attempting to create a ZlibDecoder using the preset dictionary constructor throws a compression exception:
org.jboss.netty.handler.codec.compression.CompressionException: failed to set the dictionary (-2)
z.inflateSetDictionary should not be called until the inflate returns JZlib.Z_NEED_DICT

Both pull requests merged.. Thanks!


Remove azure pipeline check on pull request

this is only for the deployment of the library which is manually triggered

done


[FEATURE] Multi tenant emulator

Issue To Be Solved
In some cases, multi-tenant support can be valuable to emulator. One emulator instance, running multiple blockchains.
I opened this issue for to start a discussion, if it is needed like I suspect, I can do the implementation.

Should we close or leave as an idea if it gets traction?

@sideninja
I think we can close, I think solution outside emulator makes sense


Fix some sporadic test failures

Reverting #349 in this PR and trying a different approach because still seeing sporadic errors, e.g. now
Cannot resolve bounds of unresolved type variable V by class
org.springframework.cglib.core.internal.LoadingCache$2

Setting net.bytebuddy.raw=true solves the Cannot resolve bounds of unresolved type variable. We set this in AgentInstaller, but because the tests load bytebuddy early, it's too late during tests to set it in AgentInstaller, so setting it now at the beginning of the tests.
After setting net.bytebuddy.raw=true, still getting some of the issues that #349 addressed. In general these failures look like they happen during redefinition of classes that were loaded by prior tests, so isolating each test class in it's own JVM seems to be helping.
The instrumentation tests are already so expensive that I'm too concerned about the extra overhead of forkEvery = 1.
Lastly in this PR, there is a fix for tests sporadically failing because TEST_SPAN was not applied due to existing span (probably left over from propagation to the thread when it was started). Now TEST_SPAN is always applied, regardless of existing span, which required some changes to the JettyTestInstrumentation to prevent multiple TEST_SPANs from being applied.

Closing, I don't understand (I'm sure user error somehow), but github is showing incorrect commit list. Will open fresh PR.


wip - fix up run script to match quickrun better

Input submission checklist

[ ] created a directory for each system based on the template directory
[ ] named and placed the directory with the following pattern: input_structures/prepared_structures/<set_name>/<system_name>

For each submitted directory:

[ ] filled in system preparation details in the PREPARATION_DETAILS.md file
[ ] added a PDB file with the protein named protein.pdb
[ ] removed any cofactors from the PDB file and placed them in cofactors.sdf
[ ] kept cystallographic waters and metals in the PDB file
[ ] tested the PDB and, if available, cofactors.sdf file using the input validation script
[ ] copied over the ligands SDF file to a file named ligands.sdf and removed any duplicate binding modes or protonation states, keeping the more favorable state

Summary of changes

Licensing agreement

[ ] I agree to release these inputs under the combined MIT and CCBY SA 4.0 licenses of this repository

Hello @IAlibay! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file industry_benchmarks/utils/plan_rbfe_network.py:

Line 189:1: W293 blank line contains whitespace
Line 213:80: E501 line too long (84 > 79 characters)

Oh and one more thing, we need to have some " around a few of those variables if there is a chance that spaces could end up in the file names, but if that can't happen we should be good!


1- Create Color Input component

[x] it should have 3 different inputs Hex, RGB, HSL

resolved

Resolved


refacotoring of the makefile to make it easyer to use locally

with this change I can use a custom AUTH_FILE location and use the
makefile locally.
When AUTH_FILE is not set it will use the default value.
Also broken the targets a bit to be able to remove/create nodes and
deployemts separately.
all changes are to make it easyer to use locally
Signed-off-by: Krasi Georgiev<EMAIL_ADDRESS>

Lgtm


#335 upgraded jsdom to version 11.11.0

related refactoring to fix breaking changes due to new jsdom API

Warning! I wasn't able to test the changes in functionalTest/html/crawler.js (its test file is excluded from airplane mode).

@mario-git Thanks for the update. Why did you close it? Did it not work?

Yes, there were a few dead bodies. A slightly better version is coming soon.

Got it, thanks
On Mon, Jun 4, 2018 at 3:40 PM, Mario Giampietri<EMAIL_ADDRESS>wrote:

Yes, there were a few dead bodies. A slightly better version is coming
soon.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/bbyars/mountebank/pull/350#issuecomment-394491640,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAESv5A9eycvYWBgIvaDUrwLm8NMJmqoks5t5ZshgaJpZM4UYQsr
.


Adding Ken Lu's CC-API update slides for 2024/05/07

Add files via upload
Update README.md

hi @kenplusplus, quick question: is this slide deck intended to supersede the previous one?

It is OK to replace the previous one. @thomas-fossati  do you want keep the new record for 2024/05/07? or just replace the previous one?

hi @kenplusplus, quick question: is this slide deck intended to supersede the previous one?

It is OK to replace the previous one.

cool

@thomas-fossati do you want keep the new record for 2024/05/07? or just replace the previous one?

I would coalesce the two, with "2024-04-23, 2024-05-07" in the date column.

hi @kenplusplus, quick question: is this slide deck intended to supersede the previous one?

It is OK to replace the previous one.

cool

@thomas-fossati do you want keep the new record for 2024/05/07? or just replace the previous one?

I would coalesce the two, with "2024-04-23, 2024-05-07" in the date column.

Update at https://github.com/CCC-Attestation/meetings/pull/36/commits/3ebad170271fd489dad49b1454e17505348ab458 could you please review again?

Thanks @kenplusplus !  Question: is slide 4 superfluous now?  Or you want to keep it?

Thanks @kenplusplus ! Question: is slide 4 superfluous now? Or do you want to keep it?

Good reminder, in latest update at https://github.com/CCC-Attestation/meetings/pull/36/commits/4f01cf90c300a42b91b6e1673951c19645aca93e, I have removed slide 4, and move the page 1,2 to the end. Could you please help to review again? Thanks for your time.

@KeithMoyer Do you have additional guides and comments? Could you please help to merge?

@gkostal Could you please help to merge? Thanks!


Inconsistent qualitative results

Hello,
I ran the script to get the 3D proposals from the 2D masks on the sample provided here, but I couldn't get the same qualitative results as in the paper (details on the results I got are bellow). What post-processing did you use to get the proposals shared in the paper, and what mask scores did you use to perform the post-processing?
Also, you mentioned here that NMS was applied after combining both 3D and 2D-3D proposals

However, it seems that the NMS section here is commented out in the code.
The results I got (from 2D only):

Results reported in the paper:

Thanks in advance for your assistance,

Hi @aminebdj,

Initially, we employed NMS (Non-Maximum Suppression) to eliminate redundant masks. However, we observed that this step did not significantly impact performance. Consequently, we opted to forgo any post-processing steps to retain as many masks as possible (not leveraging post-processing steps to achieve well-looking masks). The results you showed appear to be somewhat similar to ours. To validate the processed masks, you can run class-agnostic mask validation script and check on project page .
For the visualization issue, on the first and second levels, we use the visualizations generated from the source code. However, for the last two levels, we discovered that our visualizations could overwhelm readers due to the abundance of lifted 2D masks. Therefore, we opted to utilize ground truth annotations for these final two levels to enhance visualization clarity. We apologize for any confusion this may have caused to you.
Best.

Hey @PhucNDA,
Thanks a lot for the explanation.


Do not read useless nodes

This increases a bit the run time (+20%) but dramatically reduces memory
consumption (divided by 5)

@antoine-de please review :)

seems ok for me :+1:
What are the impacts on memory usage (and on execution time) ?

This increases a bit the run time (+20%) but dramatically reduces memory
consumption (divided by 5)

plop plop plop, I need to wake up.
nice!


verify that icon is properly included in the program

When installed on a Windows VM on a mac, the icon (top bar) failed to load. Is this because it's set to an absolute path (i.e. C:/Users/Remi-Work/....) or is this a Windows VM compatibility issue?

the icon loads on Windows in general, so this must be a Windows VM/Mac issue


Correction needed for Open Graph Tags Lecture question

For the Open Graph Tags Lecture in the HTML fundamentals module the last question here needs to be updated.
What does the `name="og:title"` do in the `meta` element?

It should be this instead
What does the `property="og:title"` do in the `meta` element?

Here is the file you need to update
https://github.com/freeCodeCamp/freeCodeCamp/blob/main/curriculum/challenges/english/25-front-end-development/lecture-html-fundamentals/6708396caa00e11b597b3365.md

This has been opened for contribution. The first comprehensive PR created will be reviewed and merged. We typically do not assign issues to anyone other than long-time contributors.
If you would like to contribute and have not read the contributors docs, please do so here: https://contribute.freecodecamp.org/#/
If you have any issues with contributing, be sure to join us on the contributors channel, or on the contributors sub-forum
Happy coding


Building pegasus with gcc on ubuntu2004 always failed due to undefined reference

Recently "Build Cpp (ubuntu2004, gcc)" for Lint and build regularly always failed with the following error:
/usr/bin/ld: ../../base/libpegasus_base.a(rrdb_types.cpp.o): in function `dsn::apps::duplicate_entry::write(apache::thrift::protocol::TProtocol*) const':
/root/incubator-pegasus/src/base/rrdb_types.cpp:5225: undefined reference to `dsn::task_code::write(apache::thrift::protocol::TProtocol*) const'
collect2: error: ld returned 1 exit status
make[2]: *** [src/geo/bench/CMakeFiles/pegasus_geo_bench.dir/build.make:119: src/geo/bench/pegasus_geo_bench] Error 1
make[1]: *** [CMakeFiles/Makefile2:1673: src/geo/bench/CMakeFiles/pegasus_geo_bench.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....

This problem has been resolved by https://github.com/apache/incubator-pegasus/pull/1284.


Upgrade core and modules [2h]

To Do

Upgrade Drupal core

Upgrade modules (where applicable)

//cc @adamhstewart

Duplicate to #1274.


More details on Jupyter configs?

Hello,
Because users can execute arbitrary code in Jupyter Notebooks, its critical to understand how users are handled in the Ubuntu (and Windows) DSVM.
My org requires more details on:

Jupyter Hub/Lab server configs
Jupyter Hub/Lab user configs, authentication mechanisms, etc.
Will you provide these additional elements?
Thank you!

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: b82eed62-460a-ab0b-bc5b-ad5fa69a4d84
Version Independent ID: 294790f4-7323-3b1f-5859-3bf0fb5757f6
Content: Introduction to Azure Data Science Virtual Machine for Linux and Windows
Content Source: articles/machine-learning/data-science-virtual-machine/overview.md
Service: machine-learning
GitHub Login: @gopitk
Microsoft Alias: gokuma

Specifically, the Jupyter Security docs state: "...If you enable a password for your notebook server, token authentication is not enabled by default..."
How does the vm handle these things?

@SeaDude Thanks for the feedback! We are currently investigating and will update you shortly.

@alexsuttonms Hi Alex, can you please check the issue to see if we can add more details about Jupyter? Thank you.

@YutongTie-MSFT - please assign to new PM, @vijetajo

@Alberto-Vega-MSFT please reassign to me

@vijetajo Done, thank you.

As this (https://docs.microsoft.com/en-us/azure/machine-learning/data-science-virtual-machine/dsvm-ubuntu-intro#jupyter-notebook) documentation states by default on DSVM The Jupyter notebook is accessed through JupyterHub. You sign in using your local Linux user name and password.  All configuration files for JupyterHub are found in directory /etc/jupyterhub the default_jupyter_config.py file and jupyterhub_config.py file.
#please-close


feat: retry with exponential backoff

As a best practice, we should do exponential backoff https://docs.aws.amazon.com/prescriptive-guidance/latest/cloud-design-patterns/retry-backoff.html

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Currently, PutRumEvents requests (i.e., those that are sent via fetch, and not sendBeacon) retry every two seconds. The maximum number of re-tries is currently 2. Once both re-tries fail, the data is dropped.
With this change, PutRumEvents requests retry with exponential backoff, starting with two seconds and doubling every re-try thereafter. This means that the second re-try will happen after 4 seconds instead of after 2 seconds.


[Auto-generated] Update dependencies

Update dependencies
Automatically created PR from ci/dependency-updates.
The PR is based on the 'CI - Update dependencies PR' workflow in SINTEF/ci-cd.
To do

[ ] Check that the diff is sensible, and that tests and builds pass with the new dependency versions.
[ ] Make sure that the PR is squash merged, with a sensible commit message.

Codecov Report
Patch and project coverage have no change.

Comparison is base (8b1acbe) 72.74% compared to head (6e250d4) 72.74%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@           Coverage Diff           @@
##             main      #96   +/-   ##
=======================================
  Coverage   72.74%   72.74%
=======================================
  Files          14       14
  Lines        1255     1255
=======================================
  Hits          913      913
  Misses        342      342

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Design and Implement a Fully Responsive 'About Us' Page

I would like to contribute by designing and implementing a modern, visually appealing, and fully responsive 'About Us' page for the website. This page will enhance the user experience by providing an elegant layout that showcases the website's mission, vision, and team, while maintaining responsiveness across all devices.
Please assign this issue to me as I would like to work on fixing it. also add the label GSSoC 2024 Extd relaevant and lvl.

@sahhoArjun097  Approved! You have been assigned the task. Feel free to start working on it, and reach out if you have any questions.

hello i need help related to about page

Hi, I am interested in working on this project, please assign me, and I'll share my solution as soon as you ping me !!

@skmirajulislam  please reply me soon

@sahhoArjun097 yes how can assist you!

@sahhoArjun097 resolved this issue!

which issue

#98 PR assigned issue, means this one im talking about GitHub issue number not in code issue😂, dont worry.

okay


Adding vttablet background binlog monitor.

It is enabled with the -monitor_replication_stream command line
argument. It does two things:

remember the last applied Event Token (and exposes it in vars)
if the event is a DDL, it forces a schema reload.

ReplicationStreamMonitor got me confused. I thought it was a monitoring service. Maybe ReplicationStreamer?

@sougou can you please approve with your regular account, not bot please? :)

LGTM


Setup proxy contract for agent consensus

Rationale
Why should this feature exist?
What are the use-cases?
Implementation
Do you have ideas regarding the implementation of this feature?
Are you willing to implement this feature?
https://app.fireflies.ai/view/Think-tank::7pfYgjxUl4

see #1501 , you can copy the link there and close this issue


pdctl: add label command

close https://github.com/pingcap/pd/issues/505 https://github.com/pingcap/pd/issues/507
PTAL @siddontang @huachaohuang @overvenus

You should split into two PR, one for refactor, another for the label command.

Any update @nolouch ?

i will split it


ct-point first & last

Hi Gion
I have idea for small enhancement:
Would be nice if first and last ct-point from serie contains some marker "first" or "last".
I implemented Bootstrap tooltips (http://goo.gl/ss1tG2) for Chartist diagrams (later I can share) and for first ct-point is good to use "right" tooltip and for last one "left".
Currently I have to add some marker (class) manualy:
chart.on('created', function() {
    chartElement.find('.ct-point:first').get(0).classList.add('first');
    chartElement.find('.ct-point:last').get(0).classList.add('last');
});

I agree this could be useful. Do you only use this for behaviour and not for styling right? For styling you could also use -of-type like here: http://jsbin.com/fopefo/1/edit?css,output

Yes, for behaviour. Something like this:
var direction, left, top;
if(pointClassList.contains('first')) {
    direction = 'right';
    left = pointPosition.left + 10;
    top = pointPosition.top - toolTip.height() / 2;
}
else if(pointClassList.contains('last')) {
    direction = 'left';
    left = pointPosition.left - toolTip.width() - 20;
    top = pointPosition.top - toolTip.height() / 2;
}
else {
    direction = 'top';
    left = pointPosition.left - toolTip.width() / 2;
    top = pointPosition.top - toolTip.height() - 20;
}

In case of big points density the 2nd and 3rd point also have to have tooltip direction right.
So this enhancement is useless, I solve it differently.

Maybe you should determine the tooltip direction with a mouse position detection altogether?


Code indentation is mixed

Hi,
I've noticed that mostly you use spaces for indentation, but sometimes there are tabs, too.
For example here:

If you don't have time to fix this, I'd make a PR which fixes this problem if you accept it. It would contain only whitespace changes, but in a lot of files.
Thanks,
Gábor

Hello @zgabi ,
Thank you for reporting.
We will for sure look at it and try to fix it everywhere.
Best Regards,
Jonathan

Help us to support this library: Donate

Hello @zgabi ,
All the files have been cleaned with Resharper,
The mixed space/tab should no longer be here.
Best Regards,
Jonathan

Help us to keep this library free: Donate

Thank you, it seems to be much better now.
The samples and tests and the non-shared HtmlAgilityPack projects are not maintained anymore?
The following files still have tabs:
src\HAPPhoneTest.7.1\App.xaml.cs
src\HAPPhoneTest.7.1\MainPage.xaml.cs
src\HAPPhoneTest\App.xaml.cs
src\HAPPhoneTest\MainPage.xaml.cs
src\HtmlAgilityPack.Tests\HtmlDocumentTests.cs: This is ok, because the tab is inside a string literal
src\HtmlAgilityPack.Tests\HtmlNode.Tests.cs
src\HtmlAgilityPack\HtmlDocument.cs
src\HtmlAgilityPack\HtmlEntity.cs
src\HtmlAgilityPack\HtmlNode.cs
src\HtmlAgilityPack\HtmlNode.Xpath.cs
src\HtmlAgilityPack\HtmlWeb.cs
src\HtmlAgilityPack\IOLibrary.cs
src\Samples\GetDocLinks\GetDocLinks.cs
src\Samples\Html2Rss\Html2Rss.cs
src\Samples\Html2Txt\Html2Txt.cs
src\Samples\Html2Xml\Html2Xml.cs
src\Tests\NugetReferenceTests\Silverlight.4.0\App.xaml.cs
src\Tests\NugetReferenceTests\Silverlight.4.0\MainPage.xaml.cs
src\Tests\NugetReferenceTests\Silverlight.5.0\App.xaml.cs
src\Tests\NugetReferenceTests\Silverlight.5.0\MainPage.xaml.cs
src\Tests\NugetReferenceTests\WindowsPhone.7.0\App.xaml.cs
src\Tests\NugetReferenceTests\WindowsPhone.7.0\MainPage.xaml.cs
src\Tests\NugetReferenceTests\WindowsPhone.7.1\App.xaml.cs
src\Tests\NugetReferenceTests\WindowsPhone.7.1\MainPage.xaml.cs
src\Tests\NugetReferenceTests\Winforms.2.0.Full\Form1.cs
src\Tests\NugetReferenceTests\Winforms.2.0.Full\Form1.Designer.cs
src\Tests\NugetReferenceTests\Winforms.2.0.Full\Program.cs
src\Tests\NugetReferenceTests\Winforms.2.0.Full\Properties\Resources.Designer.cs
src\Tests\NugetReferenceTests\Winforms.2.0.Full\Properties\Settings.Designer.cs
src\Tests\NugetReferenceTests\Winforms.4.0.ClientProfile\Form1.cs
src\Tests\NugetReferenceTests\Winforms.4.0.ClientProfile\Form1.Designer.cs
src\Tests\NugetReferenceTests\Winforms.4.0.ClientProfile\Program.cs
src\Tests\NugetReferenceTests\Winforms.4.0.ClientProfile\Properties\Resources.Designer.cs
src\Tests\NugetReferenceTests\Winforms.4.0.ClientProfile\Properties\Settings.Designer.cs
src\Tests\NugetReferenceTests\Winforms.4.0.Full\Form1.cs
src\Tests\NugetReferenceTests\Winforms.4.0.Full\Form1.Designer.cs
src\Tests\NugetReferenceTests\Winforms.4.0.Full\Program.cs

And it also seems that Resharper did not fix the lines where it is in a non active #if #else #endif block, the "main" project still have some wrong lines (current line numbers after the file name):
src\HtmlAgilityPack.Shared\HtmlDocument.cs:319, 1992
In a comment and inside an #if

src\HtmlAgilityPack.Shared\HtmlEntity.cs:60, 769-776
In comment and commented out code

src\HtmlAgilityPack.Shared\HtmlNode.cs:1620, 1771-1772
In an #if

src\HtmlAgilityPack.Shared\HtmlWeb.cs:1625-1631, 1865-1871
In commented out code

src\HtmlAgilityPack.Shared\IOLibrary.cs:33
One line in #else

Thank you, it seems to be much better now.
The samples and tests and the non-shared HtmlAgilityPack projects are not maintained anymore?
The following files still have tabs:
src\HAPPhoneTest.7.1\App.xaml.cs
src\HAPPhoneTest.7.1\MainPage.xaml.cs
src\HAPPhoneTest\App.xaml.cs
src\HAPPhoneTest\MainPage.xaml.cs
src\HtmlAgilityPack.Tests\HtmlDocumentTests.cs: This is ok, because the tab is inside a string literal
src\HtmlAgilityPack.Tests\HtmlNode.Tests.cs
src\HtmlAgilityPack\HtmlDocument.cs
src\HtmlAgilityPack\HtmlEntity.cs
src\HtmlAgilityPack\HtmlNode.cs
src\HtmlAgilityPack\HtmlNode.Xpath.cs
src\HtmlAgilityPack\HtmlWeb.cs
src\HtmlAgilityPack\IOLibrary.cs
src\Samples\GetDocLinks\GetDocLinks.cs
src\Samples\Html2Rss\Html2Rss.cs
src\Samples\Html2Txt\Html2Txt.cs
src\Samples\Html2Xml\Html2Xml.cs
src\Tests\NugetReferenceTests\Silverlight.4.0\App.xaml.cs
src\Tests\NugetReferenceTests\Silverlight.4.0\MainPage.xaml.cs
src\Tests\NugetReferenceTests\Silverlight.5.0\App.xaml.cs
src\Tests\NugetReferenceTests\Silverlight.5.0\MainPage.xaml.cs
src\Tests\NugetReferenceTests\WindowsPhone.7.0\App.xaml.cs
src\Tests\NugetReferenceTests\WindowsPhone.7.0\MainPage.xaml.cs
src\Tests\NugetReferenceTests\WindowsPhone.7.1\App.xaml.cs
src\Tests\NugetReferenceTests\WindowsPhone.7.1\MainPage.xaml.cs
src\Tests\NugetReferenceTests\Winforms.2.0.Full\Form1.cs
src\Tests\NugetReferenceTests\Winforms.2.0.Full\Form1.Designer.cs
src\Tests\NugetReferenceTests\Winforms.2.0.Full\Program.cs
src\Tests\NugetReferenceTests\Winforms.2.0.Full\Properties\Resources.Designer.cs
src\Tests\NugetReferenceTests\Winforms.2.0.Full\Properties\Settings.Designer.cs
src\Tests\NugetReferenceTests\Winforms.4.0.ClientProfile\Form1.cs
src\Tests\NugetReferenceTests\Winforms.4.0.ClientProfile\Form1.Designer.cs
src\Tests\NugetReferenceTests\Winforms.4.0.ClientProfile\Program.cs
src\Tests\NugetReferenceTests\Winforms.4.0.ClientProfile\Properties\Resources.Designer.cs
src\Tests\NugetReferenceTests\Winforms.4.0.ClientProfile\Properties\Settings.Designer.cs
src\Tests\NugetReferenceTests\Winforms.4.0.Full\Form1.cs
src\Tests\NugetReferenceTests\Winforms.4.0.Full\Form1.Designer.cs
src\Tests\NugetReferenceTests\Winforms.4.0.Full\Program.cs

And it also seems that Resharper did not fix the lines where it is in a non active #if #else #endif block, the "main" project still have some wrong lines (current line numbers after the file name):
src\HtmlAgilityPack.Shared\HtmlDocument.cs:319, 1992
In a comment and inside an #if

src\HtmlAgilityPack.Shared\HtmlEntity.cs:60, 769-776
In comment and commented out code

src\HtmlAgilityPack.Shared\HtmlNode.cs:1620, 1771-1772
In an #if

src\HtmlAgilityPack.Shared\HtmlWeb.cs:1625-1631, 1865-1871
In commented out code

src\HtmlAgilityPack.Shared\IOLibrary.cs:33
One line in #else

Hello @zgabi ,
Only the shared and test library is currently maintained. We will probably make a cleanup soon since some file should no longer exist.
Do you think you could make a pull with remaining change? Otherwise, we can check it again and do it on our side.
Best Regards,
Jonathan

I've cre3ated the pull request. I changed the files which are in the HtmlAgilityPack.sln solution or in a test project.
So the following files are not changed (they seems to be some old and duplicate files):
src\HtmlAgilityPack\HtmlDocument.cs
src\HtmlAgilityPack\HtmlEntity.cs
src\HtmlAgilityPack\HtmlNode.cs
src\HtmlAgilityPack\HtmlNode.Xpath.cs
src\HtmlAgilityPack\HtmlWeb.cs
src\HtmlAgilityPack\IOLibrary.cs


Feature Request: Preserve scroll position while not "at bottom"

Description of the new feature/enhancement
I tried searching for this but couldn't find any dupes, but please let me know if this is already possible!
It'd be great to (at least have an option to) preserve the terminal scroll position while you aren't scrolled to the bottom.
Eg. If I'm doing a build or something, which is logging out info every second, but then want to scroll up and take a look at an error message I noticed higher up, my view shouldn't be affected by new lines being printed to the terminal. Whereas currently the view jerks around as new stuff is appended to it, making it impossible to actually read any history.
If I then scroll back down "as far as you can go", that should then be a signal to "stick" the scroll with the latest output again.
Could also be nice to have a small button appear somewhere if new lines have been printed while you were scrolled up, which you could click to jump back to the "stuck to the bottom" mode.
Thanks!

We don't have a duplicate bug for this, but it'd definitely on our radar. :)
I'll be sure to add it to #2529, since there was a similar request in that PR.

This seems like something that would finally put the Scroll Lock key to good use, it should be a toggle available through a tab right-click menu, as well as the Scroll Lock key for faster keyboard use.
Related: Tabs could show some icon when new content has been added to their buffer while they were not visible, like the audio notification icon in Edge. This would make it easy to see some update happened while working in another tab.


textwrangler: fix version for mountain lion

because v5.5.2 requires Mavericks or later

There was a pull request template when you submitted. It must be filled.
If you were not presented a template, you may have submitted via a CLI tool (likely hub). It that was the case, you may wish to see if the tool has a way to let you use the template (hub is working on it).
Next time, please make sure to fill it.

@vitorgalvao

There was a pull request template when you submitted. It must be filled.

There was indeed, and I followed its instructions.

Next time, please make sure to fill it.

Sorry, I hadn't realized it needed to to be retained. Next time I'll be sure to fill it out and leave it in.


How to visualize the results

whne I run
torchpack dist-run -np 1 python tools/visualize.py configs/nuscenes/det/transfusion/secfpn/camera+lidar/swint_v0p075/convfuser.yaml

it's output is below
Traceback (most recent call last):
  File "tools/visualize.py", line 167, in <module>
    main()
  File "tools/visualize.py", line 83, in main
    for data in tqdm(dataflow):
TypeError: 'module' object is not callable
--------------------------------------------------------------------------
Primary job  terminated normally, but 1 process returned
a non-zero exit code. Per user-direction, the job has been aborted.
--------------------------------------------------------------------------
--------------------------------------------------------------------------
mpirun detected that one or more processes exited with non-zero status, thus causing
the job to be terminated. The first process to do so was:

  Process name: [[37400,1],0]
  Exit code:    1

how to fix it

I just meet the same problem, I modified the tools/visualize.py file like below:
 #from torchpack.utils.tqdm import tqdm
 from tqdm import tqdm

and then the problem solved.

I just meet the same problem, I modified the tools/visualize.py file like below:
 #from torchpack.utils.tqdm import tqdm
 from tqdm import tqdm

and then the problem solved.

I have solved it,too. I download tqdm from here.
And put it into anaconda3/envs/bevfusion/lib/python3.8/site-packages/torchpack/utils.Then the problem solved.

Hello, the official address for downloading the pre-training model of the project is invalid. If you have swint-nuimages-pretrained.pth, could you share it with my email address<EMAIL_ADDRESS>I wish you all the best in scientific research.


chore: cleanup junk, create .env on composer install/update

Welcome to Codecov :tada:
Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment.
Thanks for integrating Codecov - We've got you covered :open_umbrella:


Stop reachability test after using fetch

How can I stop the reachability test after using fetch?
I thought listening event is pretty annoying so I used NetInfo.fetch instead.
but after using NetInfo.fetch once, it continuously fetching [HEAD] /generate_204 like I using eventListener. Is this the intended behavior?

Related to #178.


libc++abi.dylib: terminating with uncaught exception of type tihmstar::exception: assure failed

Brother, what's wrong with this report? Ibss ibec cannot be created


[Prover] Not yet supported constant vector type: Vector(Primitive(Bool))

🐛 Bug
The Move Prover not yet supports constant bool vectors.
Happy to dig into it myself but tagging @rahxephon89 as he expressed interest in providing feedback.
To reproduce
Run prover on the following module:
module bool_vec::bool_vec {
    fun foo(): vector<bool> {
        let v = vector[];
        v
    }
}

Stack trace/error message
thread 'main' panicked at 'not implemented: Not yet supported constant vector type: Vector(Primitive(Bool))', language/move-prover/bytecode/src/stackless_bytecode_generator.rs:1348:22

Expected Behavior
This piece of code should verify correctly.
System information
Main branch of the Move repo (sha: 3ac0cd7b78cc2a6d470b7fefbfd82b0c044ef576) built on a Mac.

According to here, we may want a general method instead of adding a special case for bool. @meng-xu-cs @wrwg @junkil-park

Yes, Prover needs to support vector constants for all types. I added the special support of address arrays in order to unblock our specification ASAP a few month ago. I will include this work item in our task list.

@junkil-park - may I ask what the timeline for this would be? It's one of the blockers for us at this point... Again, I am happy to give it a try myself, particularly if the timeline is long-ish. It would help if someone could provide some (high-level?) suggestions for this beyond using  Vector(Vec<Value>) to generalize support for vectors.

I am working on it. I hope I can get something done this week


Doesn't really work

I have generated about 6000 codes but none of them came valid

Bro 6000 are not at all enough, they generate random digits and check them so it needs to check many codes. 6000 is a small amount to check.

Bro 6000 are not at all enough, they generate random digits and check them so it needs to check many codes. 6000 is a small amount to check.

How much should I generate, what do you think?

Of course 6,000 isn't enough, you have a higher chance of winning the lottery (probably). I am current running 5 files with 1.2mil codes each, coming into around 6mil codes by noon tomorrow, so I'll check up on it and update you if I get even a single hit (which I doubt). I plan on adding another 6mil codes right now, so 12mil total. I'll come back!

Of course 6,000 isn't enough, you have a higher chance of winning the lottery (probably). I am current running 5 files with 1.2mil codes each, coming into around 6mil codes by noon tomorrow, so I'll check up on it and update you if I get even a single hit (which I doubt). I plan on adding another 6mil codes right now, so 12mil total. I'll come back!

Have you had any success? I'll do it too only if I know it would work because my pc isn't fast enough and it takes an enormous amount of time to even check 50,000 codes

Of course 6,000 isn't enough, you have a higher chance of winning the lottery (probably). I am current running 5 files with 1.2mil codes each, coming into around 6mil codes by noon tomorrow, so I'll check up on it and update you if I get even a single hit (which I doubt). I plan on adding another 6mil codes right now, so 12mil total. I'll come back!

yea have you had any sucess or any of the code worked even a single on

Nope I stopped trying

Of course 6,000 isn't enough, you have a higher chance of winning the lottery (probably). I am current running 5 files with 1.2mil codes each, coming into around 6mil codes by noon tomorrow, so I'll check up on it and update you if I get even a single hit (which I doubt). I plan on adding another 6mil codes right now, so 12mil total. I'll come back!

yea have you had any sucess or any of the code worked even a single on

hi i've just tried about 24million codes and none work :/

I have another website link like this and people in GitHub are saying it works and i don't have a pc to install dncc made by the creator of the website so if any of y'all have a pc then y'all can check it out: https://scorpionv125.github.io/gen_coruscant/

I have another website link like this and people in GitHub are saying it works and i don't have a pc to install dncc made by the creator of the website so if any of y'all have a pc then y'all can check it out: https://scorpionv125.github.io/gen_coruscant/

This will only generate the links not check them, basically as useless at typing them yourself

I have another website link like this and people in GitHub are saying it works and i don't have a pc to install dncc made by the creator of the website so if any of y'all have a pc then y'all can check it out: https://scorpionv125.github.io/gen_coruscant/

This will only generate the links not check them, basically as useless at typing them yourself

This website has a GitHub page if u go and check in the issues then u can find a dncc(discord Nitro code checker) there made by the owner of that website

They are technically same, it doesn't matter what program you're going to use for Nitro codes, to get those codes, need a luck, it can be done in first execution or after 12 million codes or even no result. Literally waste of time.

Imma close, seems the issue has been resolved


Make Placeholder sharing consistent with other tensor sharing

Related to #499 -- see note in PondPrivatePlaceholder.feed here

Could you provide a few more details @jvmancuso?

In TFE based on TF2, this is no placeholder, we will close this issue.


img allowedTags throwing an error in Nuxt.js

To Reproduce
Not too sure how to reproduce, Using this in a Nuxt.js application, with the issue occurring during SSR on the latest version of sanitize-html.
Following the docs, I added { allowedTags: sanitizeHtml.defaults.allowedTags.concat(['img']) } to allow img tags, this worked fine in version 2.1.0.
Updating to 2.4.0, nuxt starts throwing a very non-descript error "TypeError: isPlainObject is not a function", with no other stack traces.
Assuming this is some typescript querk, I changed the configuration to: { allowedTags: [...sanitizeHtml.defaults.allowedTags, 'img'] } and it now works like before. :man_shrugging:
Expected behavior
The sanitizeHtml.defaults.allowedTags.concat method described in the readme to work, without throwing errors.
Describe the bug
Looks like allowedTags isn't a "plain" array, so it's causing issues when passed as an option.
Details
Version of Node.js:
Observed on both 12.16.1 and 14.16.1
Server Operating System:
Observed on Linux and MacOS X
Additional context:
Nuxt version 2.14.6
Maybe the fix is just to update the readme to not use concat?

Looks like I was too eager to make this issue, using a spread operator does not work.
This is definitely only happening during SSR on nuxt, doing the following actually worked, but it just disables the img tags when sanitizing on the server-side.
process.client ? { allowedTags: [...sanitizeHtml.defaults.allowedTags, 'img'] } : undefined

So the issue seems to be with allowing image tags whilst doing server-side rendering in nuxt...

Hi, thanks for the report.
This sounds like an issue external to sanitize-html. The system you
describe has a lot of parts that are not sanitize-html.
However if you can reproduce it in a unit test in sanitize-html we'll be
glad to take a look.
I would also suggest running nuxt in whatever its development build mode
is, so that you can see a better stack trace, but I don't have any further
expertise with nuxt to offer.
Closing for now for housekeeping, but feel free to reopen if you find a way
to reproduce this with just sanitize-html and a known set of inputs and
expected outputs.
On Wed, Jun 16, 2021, 12:45 AM Fraser @.***> wrote:

Looks like I was too eager to make this issue, using a spread operator
does not work.
This is definitely only happening during SSR on nuxt, doing the following
actually worked, but it just disables the img tags when sanitizing on the
server-side.
process.client ? { allowedTags: [...sanitizeHtml.defaults.allowedTags, 'img'] } : undefined
So the issue seems to be with allowing image tags whilst doing server-side
rendering in nuxt...
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/apostrophecms/sanitize-html/issues/483#issuecomment-862034763,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAH27P6HFWUU42NZFPBQDLTTAT6TANCNFSM46YSFNNQ
.

I'm hitting exactly the same problem.  I think the last version of the is-plain-object module was changed in a way that is inconsistent with their docs and with how it is used in sanitize-html.  The file node_modules/is-plain-object/index.cjs.js has the line module.exports = isPlainObject; and the file node_modules/is-plain-object/index.es.js has the line export default isPlainObject;.    The docs say to use isPlainObject like this const { isPlainObject } = require('is-plain-object');, which is just wrong.
I'm puzzled because is-plain-object seems to be downloaded  25 million times a week, so how can it be broken?
It doesn't work for me in any situation: not with node on the command line and not with next.js using webpack 5.
Here's with node on the command line:
~/cocalc/src/packages/frontend$ node --version
v14.17.4
~/cocalc/src/packages/frontend$ node
Welcome to Node.js v14.17.4.
Type ".help" for more information.
> require('./node_modules/is-plain-object')     # this is NOT a map with isPlainObject as key.
[Function: isPlainObject]
>
~/cocalc/src/packages/frontend$ grep exports node_modules/is-plain-object/index.cjs.js
module.exports = isPlainObject;

You should probably re-open this issue.   One fix might be to switch to this module:
https://www.npmjs.com/package/is-plain-obj
It seems nearly as popular as is-plain-object, and it's documentation seems correct instead of wrong.  Also, it's 6 lines of code total, written 3 years ago instead of 6 years ago.
In the meantime, I'm going to try to hack around this problem using resolve.alias in webpack...

sanitize-html depends on version 5.0.0 of is-plain-object, according to package.json.
The package.json of that version of is-plain-object points to dist/is-plain-object.js as main, so that is what gets required.
And that file ends with:
exports.isPlainObject = isPlainObject;

Which shows isPlainObject is indeed a subproperty as expected.
The newer exports section of package.json also points to this file for "require", as well as an equivalent one for "import." No sign of a function as default export in either.
So there appears to be no problem. Possibly you are forcing the use of a different major version of is-plain-object somehow.
There is just one 5.x version, 5.0.0, so no chance of a bc break within that series, but I removed package-lock and reinstalled just to make sure.

@boutell you're exactly right.  Both version 5.0.0 and version 3.x of is-plain-object are installed, and my webpack config (which is nontrivial for some other complicated reasons) is evidently messing up the module resolution.   This is definitely not at all something that is wrong with sanitize-html, and I was wrong.

No worries. I've been in similar messes.


Reframing CI/CD test to avoid running unrelated tests for each PR

/kind feature
Describe the solution you'd like
For now, each PR will trigger long time CI/CD testing, in fact some of them are not related with the PR, for example if we changed files under pkg/api, that's not related the build images Stepes, those images sometime running timeout and failed, that waste time. Suggest to create a separated workflow for those testing by define reasonable prow file.
Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]

We need to take high priority to handle this, the CI/CD tests always failed for timeout or some other strange reasons.

Need to enhance build steps to save CI test time.

Hello,
Maybe this tool can help you ? https://github.com/KnpLabs/should-skip-ci

@nm2107 Thanks sharing, we need to inestigate how to integrate with current CI famerwork, and I think we need to consider when to skip or not, such as some dir is not changed etc...

closing as the issue is staled and we have done so much improvements for the e2e infra


more spec updates

NB: I still have to merge in #492.
This is probably easiest to review via https://github.com/nutanix/libvfio-user/blob/more-spec-updates/docs/vfio-user.rst

Fixes #486

Fixes #487

github gone wrong


web/api: add targets endpoint

To be able to implement automated tests to see whether a discovery mechanism is working and has been configured correctly, an API to retrieve targets is necessary. For example: it could be used for integration tests of existing service discovery mechanisms built into Prometheus as well as to test whether for example the prometheus-operator has setup the kubernetes sd configuration correctly.
Before I invest some time into tests I would like to have a discussion and a general consensus on the resulting representation.
Currently the data part of the object consists of an array of target pools, where a target pool is an array of targets of the same job. For example:
{
   "status":"success",
   "data":[
      [
         {
            "metaLabels":{
               "__address__":"<IP_ADDRESS>:8081",
               "__metrics_path__":"/metrics",
               "__scheme__":"http",
               "job":"example-app"
            },
            "labels":{
               "instance":"<IP_ADDRESS>:8081",
               "job":"example-app"
            },
            "lastError":"Get http://<IP_ADDRESS>:8081/metrics: dial tcp <IP_ADDRESS>:8081: getsockopt: connection refused",
            "lastScrape":"2016-11-29T17:34:53.904539388+01:00",
            "health":"down"
         }
      ]
   ]
}

This slightly differs from the internal representation, but as far as I can tell (from comments in code) the internal representation this representation is created from is only kept for backward compatibility at this point.
@fabxc @brian-brazil @juliusv

That generally looks like what we want. The full URL used for scraping should be in there as well though as we can currently only infer it from the meta labels and other configurations specific to the scrape config will be missing entirely.
However, basic auth should probably be stripped or at least masked.

Travelling right now so can't give in depth review, but we should include a
way to get all dropped targets too.
On 29 Nov 2016 16:51, "Frederic Branczyk"<EMAIL_ADDRESS>wrote:

To be able to implement automated tests to see whether a discovery
mechanism is working and has been configured correctly, an API to retrieve
targets is necessary. For example: it could be used for integration tests
of existing service discovery mechanisms built into Prometheus as well as
to test whether for example the prometheus-operator
https://github.com/coreos/prometheus-operator has setup the kubernetes
sd configuration correctly.
Before I invest some time into tests I would like to have a discussion and
a general consensus on the resulting representation.
Currently the data part of the object consists of an array of target
pools, where a target pool is an array of targets of the same job:
{
"status":"success",
"data":[
[
{
"metaLabels":{
"address":"<IP_ADDRESS>:8081",
"metrics_path":"/metrics",
"scheme":"http",
"job":"example-app"
},
"labels":{
"instance":"<IP_ADDRESS>:8081",
"job":"example-app"
},
"lastError":"Get http://<IP_ADDRESS>:8081/metrics: dial tcp <IP_ADDRESS>:8081: getsockopt: connection refused",
"lastScrape":"2016-11-29T17:34:53.904539388+01:00",
"health":"down"
}
]
]
}
This slightly differs from the internal representation, but as far as I
can tell (from comments in code) the internal representation this
representation is created from is only kept for backward compatibility at
this point.
@fabxc https://github.com/fabxc @brian-brazil
https://github.com/brian-brazil @juliusv https://github.com/juliusv
You can view, comment on, or merge this pull request online at:
https://github.com/prometheus/prometheus/pull/2234
Commit Summary

web/api: add targets endpoint

File Changes

M web/api/v1/api.go
https://github.com/prometheus/prometheus/pull/2234/files#diff-0 (61)
M web/web.go
https://github.com/prometheus/prometheus/pull/2234/files#diff-1 (2)

Patch Links:

https://github.com/prometheus/prometheus/pull/2234.patch
https://github.com/prometheus/prometheus/pull/2234.diff

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/prometheus/prometheus/pull/2234, or mute the thread
https://github.com/notifications/unsubscribe-auth/AGyTdvuqWUmZhPNhg2WULQhA7inBXi1uks5rDFgSgaJpZM4K_NXW
.

I think we can add that later once there's demand. It would be off by default anyway and would require a bunch of nasty changes in the actual discovery code.

@fabxc added the full scrapeUrl. As far as I can tell from the code, basic auth is not included in the URL returned by the Target.

@fabxc @brian-brazil I added a simple test. As we are not testing the Target here I think this simple test should be enough. Let me know what you think.

Looks good in general. Just wondering whether we should rename metaLabels to discoveredLabels. Seems more understandable.

Agreed, as meta labels are in the docs usually referred to as labels that start and end with 2x _ and would seem inconsistent here.

@fabxc do you prefer discoveredLabels or origLabels as seen here?

Discovered labels is more likely to be understood by the user I expect.

Sounds good to me. As I was already at it, I also changed the naming used internally there by the Target to make it consistent across the code base. Re-review @fabxc @brian-brazil ?

Cool, LGTM 👍
This needs to be added to our HTTP API docs then as well.

Alright will get started on that PR as wel then


Alert dialog should say Success! on registration.

Context
On a successful registration, the alert should say "Success!" rather than "Register" to be consistent.

Receiving HTML script as my response for coinstash. I received another error for GPIB however I was unable to load the screenshot for GPIB.

the whole response
https://gist.github.com/pondpiu/5ffbadecab1fc70f09797efd23fe3fd9

They might have put in some DDoS protection?

Blocked until this gets fixed so we can test with GPIB


Modifier -> SwiftUI -> Technology-specific views: photosPicker(isPresented:selection:matching:preferredItemEncoding:)

Doc: https://developer.apple.com/documentation/swiftui/view/photospicker(ispresented:selection:matching:preferreditemencoding:)

[ ] Swift implementation
[ ] Elixir implementation

Blocked by file uploading

Blocked by https://github.com/liveview-native/liveview-native-core/issues/15

This is part of PhotoKit https://developer.apple.com/documentation/photokit


Homebridge hangs after update to 0.11.5

Hi Erik,
I just made the update from<EMAIL_ADDRESS>to 0.11.5. The result is the error below preventing the homebridge to start completely. The start process continues normally after the error, at last I can see in the log that homebridge-zp is initialized. Everything seems to be normal but homebridge does not show up with the message Homebridge is running on port 51826.
Port 51826 cannot be accessed. Homebridge does not run or hangs somehow. After downgrading the Plugin everything is running smoothly again. Am I missing something?
I am an experienced Linux user and my system is reasonably well maintained.
homebridge-0.4.45
node-10.15.0
Thanks,
Stefan
Dec 28 18:08:10 raspberrypi homebridge[1405]: [12/28/2018, 6:08:10 PM] [Hue] TypeError: homebridgeLib.UpnpMonitor is not a constructor
Dec 28 18:08:10 raspberrypi homebridge[1405]:     at Promise (/usr/local/lib/node_modules/homebridge-hue/node_modules/homebridge-hue-utils/lib/HueDiscovery.js:66:27)
Dec 28 18:08:10 raspberrypi homebridge[1405]:     at new Promise ()
Dec 28 18:08:10 raspberrypi homebridge[1405]:     at HueDiscovery._upnp (/usr/local/lib/node_modules/homebridge-hue/node_modules/homebridge-hue-utils/lib/HueDiscovery.js:65:12)
Dec 28 18:08:10 raspberrypi homebridge[1405]:     at HueDiscovery.discover (/usr/local/lib/node_modules/homebridge-hue/node_modules/homebridge-hue-utils/lib/HueDiscovery.js:42:12)
Dec 28 18:08:10 raspberrypi homebridge[1405]:     at HuePlatform.findBridges (/usr/local/lib/node_modules/homebridge-hue/lib/HuePlatform.js:424:21)
Dec 28 18:08:10 raspberrypi homebridge[1405]:     at request.then.catch.then (/usr/local/lib/node_modules/homebridge-hue/lib/HuePlatform.js:265:17)
Dec 28 18:08:10 raspberrypi homebridge[1405]:     at Function.then (/usr/local/lib/node_modules/homebridge-hue/node_modules/deferred/_ext.js:67:13)
Dec 28 18:08:10 raspberrypi homebridge[1405]:     at Deferred._settle (/usr/local/lib/node_modules/homebridge-hue/node_modules/deferred/deferred.js:97:26)
Dec 28 18:08:10 raspberrypi homebridge[1405]:     at Deferred.resolve (/usr/local/lib/node_modules/homebridge-hue/node_modules/deferred/deferred.js:142:15)
Dec 28 18:08:10 raspberrypi homebridge[1405]:     at Function. (/usr/local/lib/node_modules/homebridge-hue/node_modules/deferred/ext/promise/catch.js:29:4)
Dec 28 18:08:10 raspberrypi homebridge[1405]:     at Deferred._settle (/usr/local/lib/node_modules/homebridge-hue/node_modules/deferred/deferred.js:97:26)
Dec 28 18:08:10 raspberrypi homebridge[1405]:     at Deferred.resolve (/usr/local/lib/node_modules/homebridge-hue/node_modules/deferred/deferred.js:142:15)
Dec 28 18:08:10 raspberrypi homebridge[1405]:     at Function.then (/usr/local/lib/node_modules/homebridge-hue/node_modules/deferred/_ext.js:72:4)
Dec 28 18:08:10 raspberrypi homebridge[1405]:     at Deferred._settle (/usr/local/lib/node_modules/homebridge-hue/node_modules/deferred/deferred.js:97:26)
Dec 28 18:08:10 raspberrypi homebridge[1405]:     at Deferred.resolve (/usr/local/lib/node_modules/homebridge-hue/node_modules/deferred/deferred.js:142:15)
Dec 28 18:08:10 raspberrypi homebridge[1405]:     at Request.request [as _callback] (/usr/local/lib/node_modules/homebridge-hue/lib/HuePlatform.js:469:14)
Dec 28 18:08:10 raspberrypi homebridge[1405]:     at Request.self.callback (/usr/local/lib/node_modules/homebridge-hue/node_modules/request/request.js:185:22)
Dec 28 18:08:10 raspberrypi homebridge[1405]:     at Request.emit (events.js:182:13)
Dec 28 18:08:10 raspberrypi homebridge[1405]:     at Request. (/usr/local/lib/node_modules/homebridge-hue/node_modules/request/request.js:1161:10)
Dec 28 18:08:10 raspberrypi homebridge[1405]:     at Request.emit (events.js:182:13)
Dec 28 18:08:10 raspberrypi homebridge[1405]:     at IncomingMessage. (/usr/local/lib/node_modules/homebridge-hue/node_modules/request/request.js:1083:12)
Dec 28 18:08:10 raspberrypi homebridge[1405]:     at Object.onceWrapper (events.js:273:13)
Dec 28 18:08:10 raspberrypi homebridge[1405]:     at IncomingMessage.emit (events.js:187:15)
Dec 28 18:08:10 raspberrypi homebridge[1405]:     at endReadableNT (_stream_readable.js:1094:12)
Dec 28 18:08:10 raspberrypi homebridge[1405]:     at process._tickCallback (internal/process/next_tick.js:63:19)

Same error here.

See also #419.  I ran into an argument with npm.  Can you please check what versions of the dependencies were installed (sudo npm -g list --depth=1).

Danm, it's an error with the discovery of bridges.  Didn't test that.  Will publish fix shortly.

And it does! Dank u wel. I'm sorry I ruined your evening, but thank you so much for your nice software.


[Feature Request] manpage

ly has some great potential, but RTFM and starting up ly is probably not the best way to respond to ly --help.
Considering how popular this project is getting, it might be time to write up a manpage for ly so that man ly can offer us some man-ly advice on how to use it. :grin:

The RTFM is already replaced with something more useful in the last git
A manpage I agree it could be kinda useful

At very least, add a URL next to "RTFM" so we can at least have a quick reference to where it is.

Personally, I don't think a manpage is really that useful. The config file is well documented enough that any person could figure out what setting does what, and doing ly --help redirects you to the config file.

Well, I do think it would be important for ly not to launch if my curiosity to try -h or --help to see if there's any information about how I should use it (without coming to Github).  Fortunately, a CTRL+C in the shell I was using let me exit out. Imagine it I couldn't do that or didn't know that was possible.
All I'm saying is to probably make a couple of simple modifications to avoid making mistakes of launching ly without getting it properly set up first.

Wait, do you mean doing ly --help launches a login prompt for you? If yes, this should not happen at all.

I can confirm ly --help launches ly normally for me as well (except that the help message is printed), I have to Ctrl-c to exit ly and view the printed message. Thought this was intended behavior lol

I personally thik the configuration file is already well documented. The aforementionned bug is also fixed, so I'm closing this issue as solved.


Remove threesdk and related commands (usershell)

As we already have other methods for installation and we don't maintain it anymore.

@m-motawea has removed threesdk already

@m-motawea has removed threesdk already

successfully removed on development reduce


kernel: Modify the signature of k_mem_slab_free via deprecation

Deprecate the current k_mem_slab_free() function to be able to introduce
a new k_mem_slab_free2() version with the correct signature, replacing
the old void **mem with void *mem as a parameter.
Fixes #61888.

Sad to see this “new” API. Stability cult has gone too far, sorry but can’t approve this one.

This looks fine to me, but I will say I prefer the other two options you mentioned.

So do I, and others. This PR is here to open the discussion, great to have your feedback @andyross!

Superseeded by https://github.com/zephyrproject-rtos/zephyr/pull/61901


v3.0.0dev0 blobs failing when different shapes

General information:

emcee version: v3.0.0dev0
platform: any
installation method (pip/conda/source/other?): any

Problem description:
Expected behavior:
I expect that returning blobs of various shapes should work.
Actual behavior:
An error is raised: ValueError: setting an array element with a sequence.
What have you tried so far?:
When passing blobs_dtype with shapes for each returned blob, it works fine.
Minimal example:

import emcee

import numpy as np
def lnl(p):
    return p[0], 1.0, np.array([1,2,3])
sampler = emcee.EnsembleSampler(
    nwalkers = 10,
    ndim = 2,
    log_prob_fn = lnl
)

p0 = np.random.normal(size=(10,2))
for sample in sampler.sample(p0, iterations=10):
    continue

The offending line is L394 of ensemble.py: dt = np.atleast_1d(blob[0]).dtype. This will work as intended (I think), if it is instead: dt = [(np.atleast_1d(b).dtype, np.atleast_1d(b).shape) for b in blob[0]], though there might need to be a check for 1-dimensional arrays.

I've "fixed" this in the sense that it doesn't fail anymore (instead it infers the dtype as object), but I'd definitely recommend using blobs_dtype for the best results because it's too complicated to come up with a general dtype inference mechanism that will do what you want.

I think this will work for the default backend, but not the HDF backend, as it does not understand the "object" dtype. I agree that there's no obvious way to do it that will work in all use cases. At this point, I am changing my likelihood function to present the blobs correctly.

Yeah - this definitely won't work for the HDF backend but I don't see a way to fix that.
I'll close this for now, but feel free to re-open if you think that there's more to do.

as v3.0.0 is now the default pip version, this can cause transition issues for people previously (knowingly or unknowingly) worked with e.g. v2.2.1.
The default blobs input leads to a raise statement.
My travis report can be found here:
https://travis-ci.org/sibirrer/lenstronomy/jobs/591749997
Below the relevant lines that crashed
../../../virtualenv/python3.6.7/lib/python3.6/site-packages/emcee/ensemble.py:324: in sample
514    self.backend.grow(iterations, state.blobs)
self = <emcee.backends.backend.Backend object at 0x7f773bd07cd0>, ngrow = 1
1202blobs = array([None, None, None, None, None, None, None, None, None, None, None,
1203     ...ne, None, None, None, None,
1204       None, None, None, None, None], dtype=object)
1205
1206    def grow(self, ngrow, blobs):
1207        """Expand the storage space by some number of samples
1208
1209            Args:
1210                ngrow (int): The number of steps to grow the chain.
1211                blobs: The current list of blobs. This is used to compute the
1212                    dtype for the blobs array.
1213
1214            """
1215        self._check_blobs(blobs)
1216        i = ngrow - (len(self.chain) - self.iteration)
1217        a = np.empty((i, self.nwalkers, self.ndim))
1218        self.chain = np.concatenate((self.chain, a), axis=0)
1219        a = np.empty((i, self.nwalkers))
1220        self.log_prob = np.concatenate((self.log_prob, a), axis=0)
1221        if blobs is not None:
1222>           dt = np.dtype((blobs[0].dtype, blobs[0].shape))
1223E           AttributeError: 'NoneType' object has no attribute 'dtype'

Can you please provide a code snippet that reproduces this error? I'm not sure what you mean by "default" blobs.

I mean the
blobs=array([None, None, None, None, None, None, None, None, None, None, None ... None], dtype=object)
statement in the input of
ensemble.py:324
I never defined the blobs myself in v2.2.1. I see that you have a nice transition page and I will first to follow all those steps before coming back to you. It just became urgent to transition to v3.0.0 as the default pip version has changed (today?) and v2.2.1 is not supported anymore on python3 (at least not on travisCI environment)

I don't see anything wrong with that line there and there are plenty of tests where the blobs are not definined and they work just fine. So, can you please share a small piece of code that reproduces your issue.

The issue was in an incompatible wrapper that used two arguments in the likelihood function output and the way this functions were called to effectively overwrite the blobs statement. Problem fixed on my side. Sorry for bothering you and thanks for the quick replies.

No worries. Glad you got it sorted!

I keep having this issue when using CosmoHammer within MontePython, see issue mentioned above. I believe @sibirrer was experiencing the same issue. How exactly did you manage to fix it?

@alessiospuriomancini:  by now I am not using CosmoHammer anymore (as it might not be as well supported) and directly use the MPI support in emcee. The following way I initialize the MPI pool to work with emcee (slightly modified fro schwimmbad): https://github.com/sibirrer/lenstronomy/blob/master/lenstronomy/Sampling/Pool/multiprocessing.py
This fixed an other issue between pickle and dill in storing the different instances of the MPI process.

Thanks so much @sibirrer. Just to clarify: you use the script multiprocessing.py within some script for emcee, to directly run using emcee without going through CosmoHammer?

yes @alessiospuriomancini, for example here: https://github.com/sibirrer/lenstronomy/blob/master/lenstronomy/Sampling/sampler.py in definition mcmc_emcee()


Consider adding ambiguity check for regexes

Hi! LALRPOP’s lexer has a very cool feature: if two tokens have regexes with non-empty intersection language, then an error is reported, unless there’s an explicit precedence annotation as well. This helps a lot with producing correct lexers: after implementing a TOML lexer with LALRPOP, I’ve found an ambiguity in the lexer I’ve implemented for IntelliJ Rust:
https://github.com/intellij-rust/intellij-rust/pull/2426/files
It would be cool if logos had this feature as well!

For the reference, here’s the relevant bit from LALRPOP:
https://github.com/lalrpop/lalrpop/blob/28533afc7fe0ba653d015ba587e0cda52b0840c8/lalrpop/src/lexer/dfa/mod.rs#L39
The precedence thing is what determines if ambiguity is an errror or not.

Logos currently errors if two patterns can resolve to the same token. Adding precedence markers to make it resolve those situations should be possible, will need to think about how to reflect it on the API surface without adding too much bloat to the attributes.

Now that token disambiguation is well defined and document, I think we can do this. I reckon the default disambiguation strategy is good for most use cases, but we could add a flag like #[regex("...", strict)] or some such to have logos produce an error in case two regexes collide.


SUBMARINE-669. Notebook name contain only lowercase alphanumeric characters or '-'

What is this PR for?
Fix the rule of "Notebook Name" while creating new notebook and add description in userdocs.
Now notebook name should follow the DNS label standard as defined in RFC 1123.

Contain at most 63 characters.
Contain only lowercase alphanumeric characters or '-'.
Start with an alphanumeric character.
End with an alphanumeric character.

What type of PR is it?
[Bug Fix]
Todos

[ ] - Task

What is the Jira issue?
SUBMARINE-669
How should this be tested?
Travis CI
Screenshots (if appropriate)

Questions:

Does the licenses files need update? No
Is there breaking changes for older versions? No
Does this needs documentation? No

@charlie0220 Thanks for your contribution!
@kobe860219 Could you please help me review this PR ?

@charlie0220 @kobe860219
Would it be better if we display validation message under the input field?

@lowc1012 @charlie0220  I will embed ng-zorro to notebook page soon!

I found out a problem. Please do not merge this PR.


Port lru_cache from @davidfischer-ch changes. Closes #430

Current coverage is 96.34%

Merging #495 into dev will decrease coverage by -0.03% as of 7c6a33a

@@              dev    #495   diff @@
=====================================
  Files          25      25
  Stmts        2289    2293     +4
  Branches      205     206     +1
  Methods         0       0
=====================================
+ Hit          2206    2209     +3
- Partial        34      35     +1
  Missed         49      49

Review entire Coverage Diff as of 7c6a33a

Uncovered Suggestions

+0.30% via ...y_forms/bootstrap.py#76...82
+0.17% via ...spy_forms_filters.py#103...106
+0.13% via ...crispy_forms_tags.py#66...68
See 7 more...

Powered by Codecov. Updated on successful CI builds.

Any chance we can do these kind of fixes by cherry picking the original change? (That way the history stays with the original author)

Ok, I'll try to do that.