Generalize the working directory configuration

One can launch the application from the .build or other folders even from the command-line, not necessarily from the Xcode
#if Xcode requires each IDE to use the same preprocessor definition as Xcode does and that's not good since we need to introduce another entity for the particular run configuration in the particular IDE.

Initially created here

This PR is missing an important point in the original function – in particular, the reason of the #if Xcode check – and will break existing workflows in the de facto most important IDE: Xcode.
In a freshly generated Xcode project, the Run scheme uses a temporary folder in DerivedData as the current working directory by default. getcwd will return this folder as well, and from it, there is no way do find the project directory again – which is pretty important for file serving, template rendering, etc.
While the developer can manually set the project folder as a custom working directory, there is no way to override this when running tests in Xcode.
Other IDEs don't have to define the Xcode flag, they just have to use the project folder as the working directory.

If the project is not run in Xcode, getcwd will have absolute precedence (as the other code path is not even compiled in), and the app just works.

Adding extra logic for .build and Packages in the current path seem pretty arbitrary and not realistic – normally you would not touch these folders manually in a develop-run-repeat cycle.

You can run the app from the proper working directory even if it is in the .build folder. Just do:
.build/debug/App

If you are using something like Supervisor, there are options to set the working directory.
In Vapor 2 there was a flag you could pass to set the working directory used. We could consider porting this to 3, but unless there's a reason why the previous two solutions wouldn't work it's probably not worth the effort.

I got the logic and even though just removing the #if Xcode problem solves the problem when developing the application, it's incorrect when we run the app on the server. Closing this pull request and hoping that some solution like used in Kitura (that does not rely on the IDE) will be implemented.

Closing this pull request and hoping that some solution like used in Kitura (that does not rely on the IDE) will be implemented.

@yeswolf do you have a link to the implementation you are referencing? I'd be interested to look at it.

Fun fact about Kitura's FileKit module: you can inude it in your Vapor project and use it instead of DirectoryConfig if it suits your needs better. You could even wrap it in a custom DirectoryConfig.
Without actually knowing what the problem is (you haven't shared anything about your magical IDE or how you deploy to your server, just that something doesn't work), it's pretty hard to come up with a solution that works for all of us.


Toggling Solo occasionally leaves another channel un-soloed

I have a drum kit of 9 samples being setup as shown below.  This has been working well throughout my React app. (for context: kitRef.current is an array of objects with properties for each sample. Each sample property is a url)
for (let i = 0; i < 9; i++) {
      kitRef.current[i].sampler = new Tone.Sampler({
        C2: kitRef.current[i].sample,
      });
      kitRef.current[i].channel = new Tone.Channel({
        volume: 0,
        pan: 0,
        channelCount: 2,
      }).toDestination();
      kitRef.current[i].sampler.connect(kitRef.current[i].channel);

Elsewhere, I implemented 'Solo' and 'Mute' toggles by setting kitRef.current[i].channel.solo = !prev .  It works ok but at random .solo = true leaves one other sampler playing.  It's not always the same channel that is left open.
I tried getting rid of Tone.Channel and using Tone.Solo instead to see if that would help, but in that case my toggle doesn't work at all.  Sorry if I'm misunderstanding how this is supposed to work.

Could you provide an example which demonstrates the issue? i'm unable to recreate the issue from the code that you included.

Thx pls give me a few days.

sure thing, thanks!

Problem has disappeared with some refactoring.  Was likely my own error.  Will open new issue if it happens again.


Add per-platform ANSI art to HelloWorld

Just by looking at the code you can likely guess what gets drawn for Linux ;)
I've left Mac as a todo for someone else who'd like to contribute something beautiful.
Right now, the console app just takes the target platform as a command-line argument.  We can update it later to fall back to a default based on Environment.

looks good


Could istio-proxy send traces directly to jaeger-agent?

Describe the feature request
I'd like to configure istio-proxy to export tracing data to a colocated jaeger-agent, as opposed to via a jaeger-collector.
Based on the docs I've read for Jaeger and Istio, I think istio-proxy can emit zipkin format traces over HTTP/TCP, but jaeger-agent only accepts a few UDP-transport formats https://www.jaegertracing.io/docs/1.15/deployment/#agent so there is no overlap in supported formats. This means for the moment, sending traces to the jaeger-collector is the only option.
Describe alternatives you've considered

Asking Jaeger project whether jaeger-agent can be enhanced to accept zipkin traces on HTTP port 9411 or another port in a similar manner to how jaeger-collector does
Writing a bespoke service that accepts zipkin traces on HTTP port 9411, proxying and adapting them to one of the UDP-transported formats jaeger-agent can accept
Sending traces to jaeger-collector instead of jaeger-agent https://www.jaegertracing.io/docs/1.15/deployment/#collectors

Additional context

Another option would be to use the Opencensus tracer within envoy, with ocagent exporter, to report to an OpenTelemetry collector (running as a sidecar agent) configured with jaeger exporter - which then reports the traces to the Jaeger collector.

Hmm.. looks like this work got dropped. Could this be re-visited?

Hmm.. looks like this work got dropped. Could this be re-visited?


Prevent processing unenlarged file without an error?

Hi there! Love this plugin.
I want to use gulp-responsive to batch-resize all images within a given directory to be resized down to several different sizes, for use with picturefill/srcset. I've noticed, however, that gulp-responsive will create new copies of a file with the same pixel dimensions if an option block defines a width target higher than the original source file.
How do I configure gulp-responsive to simply skip a config block if the original image is smaller than the destination output width of that config block?
I've set withoutEnlargement to true to at least prevent gulp-responsive from enlarging the images, but I hoped it would also cause the plugin to skip any images bigger than the config block.

Hi @timrourke
Sorry for the delay.
skipOnEnlargement option will be implemented in near future.

Landed in 1.2.1

Hi @timrourke
Does skipOnEnlargement option solves your task?

Hi @timrourke is issue resolved for you?

I tried the skipOnEnlargement option, but it did not work as expected.
I'm using gulp-responsive v2.2.0
Instead of the image being skipped, an error is thrown.
I'm using this configuration.
{                 //<EMAIL_ADDRESS>is 2560 pixels wide                 width: 1280 * 2,                 skipOnEnlargement: true,                 rename: {                     suffix: '-extralarge@2x',                     extname: '.jpg',                 }
The error I get is:

events.js:154
throw er; // Unhandled 'error' event
^
cted
real width: 1000px, required width: 1280px


Create fpcsrc.rb

https://github.com/caskroom/homebrew-cask/pull/13636 plus corrections.
@Gutem decided to close that one, for some reason.

Merged as 0968bf87e4d1ab41331465078eebe871e65478e1.


Writing and validating v0.11 upgrade guide

We have a basic upgrade guide in place already, creating this issue to track what's required for upgrading from v0.10 to v0.11, and to ensure we properly document it.
/milestone v0.10
/priority important-soon
/area deploy
/kind documentation

/milestone v0.11

Things to do, and who's doing them:

[ ] Adding list of old vs new annotations to upgrade guide & release notes
[ ] Add action required section to release notes
[ ] Linking to uninstall doc from upgrade guide

Notable items:

[ ] Renamed API group (@munnerz)

[ ] Bumping API version (@munnerz)

[ ] Removing deprecated config fields (@munnerz)

[ ] Improving ACME Order design (@munnerz)

[ ] New CertificateRequest resource type (@JoshVanL)

[ ] Support for out-of-tree issuer types (@JoshVanL)

[ ] New fields on Certificate resources (@JoshVanL)

[ ] No longer generating 'temporary certificates' by default (@JoshVanL)

[ ] Generating full changelog


OpenVPN Admin Utility

Can somebody please explain to me how to install Admin utility?  I do not have a /opnevpn_as folder as I believe I should?

+1

I really don't think openvpn as is present on the pi, in fact i believe there is a build for it.

What do you need the Admin utility for? There already is a pivpn command that allows you to create, list and revoke .ovpn files.

Now that I have figured out static IP, nothing. :)
Sent from my iPhone

On May 24, 2017, at 08:11, redfast00<EMAIL_ADDRESS>wrote:
What do you need the Admin utility for? There already is a pivpn command that allows you to create, list and revoke .ovpn files.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

For advanced configurations like restrict access only to specific hosts inside the LAN?


WIP: OpenTracing integration

OpenTracing integration.
Tracing ClientExecChain has to be registered as the last one. It should wrap all the client invocation.
There will be probably one more class - SpanDecorator to add tags to span (onRequest, onResponse, onError).
cc @ok2c
(mvn clean install -Dcheckstyle.skip=true -Dmaven.javadoc.skip=true -Drat.skip=true  -DskipTests)

This integration can live in a separate repo, if there will be a way how to add TracingExec as the last one in the chain.
Question about async client. Requests probably happen in a different thread. Is there a way how to access code creating those callables/runnables? I will have to do something like this? https://github.com/OpenFeign/feign-opentracing/blob/master/feign-hystrix-opentracing/src/main/java/feign/opentracing/hystrix/TracingConcurrencyStrategy.java#L75

@pavolloffay I am still working on a redesign of request execution pipeline in my private branch (both classic and async). It will likely take me another week or two to complete. Please just bear with me.
I am not sure I am in favor of adding OpenTracing as a hard dependency to HttpClient. I personally would rather prefer it to be a separate module like HTTP cache, Windows integration and OSGi.

Agree OT integration should optional. I'm just trying to make sure that integration is possible for both clients.
Take your time. Ping me please when it is ready.

as much as I like tracing, I also think it would be extremely unwise to add more deps to the bottom of the stack (which is often where httpclient is), particularly in v0 apis that have few java developers reviewing them

hey, oleg. different project but same problem.
Here's an example of instrumenting the async client w/ v4.3
(apologies I made no useful code comments explaining..)
https://github.com/openzipkin/brave/blob/master/instrumentation/httpasyncclient/src/main/java/brave/httpasyncclient/TracingHttpAsyncClientBuilder.java
The main concerns are split into a several areas:

how to propagate state internally throughout the request (ex stuffing
things in attributes)
how to make state visible to user interceptors (ex thread scoping)
how to ensure span lifecycle happens (callbacks)
what to add to the span (parsing)

You can do everything except the "user interceptors" part and tracing will
work fine. It is just that some users want to do things like add to a trace
manually. That's what's lost when you don't have clean hooks into executors
or other means to start work.

@adriancole Adrain, feel to propose or, better, to contribute "clean hooks into executors or other means to start work" to HttpClient 5.0. There we can still shape APIs as we deem fit.

@adriancole https://github.com/adriancole Adrain, feel to propose or,
better, to contribute "clean hooks into executors or other means to start
work" to HttpClient 5.0. There we can still shape APIs as we deem fit.

I'll try to instrument what's already in 5 and then see how it goes (I
won't be using code in this PR). I'll run through brave's test suites and
see how it goes and let you know!

Oleg, thinking in general here.. I think one hook approach that would
be nice to see in any instrumentation library is an interface like
this..
Scope newScope(Attributes attributes);
which is used in try-finally form whenever user interceptors are invoked.
try (Scope wa = newScope(attributes) {
userInterceptorChain.invoke();
}
this approach was discussed here:
https://github.com/openzipkin/brave/issues/166#issuecomment-277634798
An implementation of this scope could be picking trace context out of
the attributes and setting it in a thread local. closing the scope
removes it. This is cheaper than trying to do the same with lambdas,
and also keeps the call stack less complex
As different users may pick different things, a composition of scopes
would be inside the "newScope" method above. It might have to act like
guava's Closer such that all scopes are closed even if one causes a
problem.


2024.4.1b0 - Component fails to setup

System Health details
System Information

version
core-2024.4.3

installation_type
Home Assistant OS

dev
false

hassio
true

docker
true

user
root

virtualenv
false

python_version
3.12.2

os_name
Linux

os_version
6.6.25-haos

arch
x86_64

timezone
Europe/London

config_dir
/config

Home Assistant Community Store

GitHub API
ok

GitHub Content
ok

GitHub Web
ok

GitHub API Calls Remaining
4649

Installed Version
1.34.0

Stage
running

Available Repositories
1403

Downloaded Repositories
61

Home Assistant Cloud

logged_in
false

can_reach_cert_server
ok

can_reach_cloud_auth
ok

can_reach_cloud
ok

Home Assistant Supervisor

host_os
Home Assistant OS 12.2

update_channel
stable

supervisor_version
supervisor-2024.04.0

agent_version
1.6.0

docker_version
25.0.5

disk_total
109.3 GB

disk_used
43.6 GB

healthy
true

supported
true

board
generic-x86-64

supervisor_api
ok

version_api
ok

installed_addons
Samba share (12.3.1), Duck DNS (1.16.0), File editor (5.8.0), Glances (0.21.1), Log Viewer (0.17.0), Advanced SSH & Web Terminal (17.2.0), MariaDB (2.7.1), Vaultwarden (Bitwarden) (0.21.2), chrony (3.0.1), Samba Backup (5.2.0), Z-Wave JS UI (3.5.0), Zigbee2MQTT (1.36.1-1), Mosquitto broker (6.4.0), Nginx Proxy Manager (1.0.1), Studio Code Server (5.15.0), ESPHome (2024.4.0), Govee to MQTT Bridge (2024.01.24-ea3cd430)

Dashboards

dashboards
4

resources
53

views
12

mode
storage

Recorder

oldest_recorder_run
19 April 2024 at 14:57

current_recorder_run
22 April 2024 at 13:48

estimated_db_size
831.50 MiB

database_engine
mysql

database_version
10.11.6

Checklist

[X] I have enabled debug logging for my installation.
[X] I have filled out the issue template to the best of my ability.
[X] This issue only contains 1 issue (if you have multiple issues, open one issue for each issue).
[X] This issue is not a duplicate issue of any previous issues..

Describe the issue
The component now fails to setup 2024.4.1b0.

2024-04-22 13:48:57.336 INFO (SyncWorker_2) [homeassistant.util.package] Attempting install of pyanglianwater==0.2.1
2024-04-22 13:49:05.014 INFO (MainThread) [homeassistant.setup] Setting up anglian_water
2024-04-22 13:49:06.005 DEBUG (MainThread) [pyanglianwater.api] >> Request to login successful.
2024-04-22 13:49:08.613 DEBUG (MainThread) [pyanglianwater.api] >> Request to get_bills_payments successful.
2024-04-22 13:49:10.225 DEBUG (MainThread) [pyanglianwater.api] >> Request to get_usage_details successful.
2024-04-22 13:49:12.321 DEBUG (MainThread) [pyanglianwater.api] >> Request to get_usage_details successful.
2024-04-22 13:49:12.323 ERROR (MainThread) [custom_components.anglian_water] Unexpected error fetching anglian_water data: 0
Traceback (most recent call last):
File "/usr/src/homeassistant/homeassistant/helpers/update_coordinator.py", line 315, in _async_refresh
self.data = await self._async_update_data()
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/config/custom_components/anglian_water/coordinator.py", line 63, in _async_update_data
await self._insert_statistics()
File "/config/custom_components/anglian_water/coordinator.py", line 100, in _insert_statistics
hourly_consumption_data[0]["meterReadTimestamp"]
~~~~~~~~~~~~~~~~~~~~~~~^^^
KeyError: 0
2024-04-22 13:49:12.337 DEBUG (MainThread) [custom_components.anglian_water] Finished fetching anglian_water data in 6.330 seconds (success: False)
2024-04-22 13:49:18.693 DEBUG (MainThread) [pyanglianwater.api] >> Request to login successful.
2024-04-22 13:49:21.412 DEBUG (MainThread) [pyanglianwater.api] >> Request to get_bills_payments successful.
2024-04-22 13:49:23.065 DEBUG (MainThread) [pyanglianwater.api] >> Request to get_usage_details successful.
2024-04-22 13:49:24.862 DEBUG (MainThread) [pyanglianwater.api] >> Request to get_usage_details successful.
2024-04-22 13:49:24.866 ERROR (MainThread) [custom_components.anglian_water] Unexpected error fetching anglian_water data: 0
Traceback (most recent call last):
File "/usr/src/homeassistant/homeassistant/helpers/update_coordinator.py", line 315, in _async_refresh
self.data = await self._async_update_data()
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/config/custom_components/anglian_water/coordinator.py", line 63, in _async_update_data
await self._insert_statistics()
File "/config/custom_components/anglian_water/coordinator.py", line 100, in _insert_statistics
hourly_consumption_data[0]["meterReadTimestamp"]
~~~~~~~~~~~~~~~~~~~~~~~^^^
KeyError: 0
2024-04-22 13:49:24.868 DEBUG (MainThread) [custom_components.anglian_water] Finished fetching anglian_water data in 6.172 seconds (success: False)

Reproduction steps

install 2024.4.1b0
enable debugging
recreate the integration
select water tariff "standard'
add custom water rate float - eg 194
component confirms "Success" but the integration reports: failed setup, will retry
...

Debug logs
2024-04-22 13:49:05.014 INFO (MainThread) [homeassistant.setup] Setting up anglian_water
2024-04-22 13:49:06.005 DEBUG (MainThread) [pyanglianwater.api] >> Request to login successful.
2024-04-22 13:49:08.613 DEBUG (MainThread) [pyanglianwater.api] >> Request to get_bills_payments successful.
2024-04-22 13:49:10.225 DEBUG (MainThread) [pyanglianwater.api] >> Request to get_usage_details successful.
2024-04-22 13:49:12.321 DEBUG (MainThread) [pyanglianwater.api] >> Request to get_usage_details successful.
2024-04-22 13:49:12.323 ERROR (MainThread) [custom_components.anglian_water] Unexpected error fetching anglian_water data: 0
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/helpers/update_coordinator.py", line 315, in _async_refresh
    self.data = await self._async_update_data()
                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/config/custom_components/anglian_water/coordinator.py", line 63, in _async_update_data
    await self._insert_statistics()
  File "/config/custom_components/anglian_water/coordinator.py", line 100, in _insert_statistics
    hourly_consumption_data[0]["meterReadTimestamp"]
    ~~~~~~~~~~~~~~~~~~~~~~~^^^
KeyError: 0
2024-04-22 13:49:12.337 DEBUG (MainThread) [custom_components.anglian_water] Finished fetching anglian_water data in 6.330 seconds (success: False)
2024-04-22 13:49:18.693 DEBUG (MainThread) [pyanglianwater.api] >> Request to login successful.
2024-04-22 13:49:21.412 DEBUG (MainThread) [pyanglianwater.api] >> Request to get_bills_payments successful.
2024-04-22 13:49:23.065 DEBUG (MainThread) [pyanglianwater.api] >> Request to get_usage_details successful.
2024-04-22 13:49:24.862 DEBUG (MainThread) [pyanglianwater.api] >> Request to get_usage_details successful.
2024-04-22 13:49:24.866 ERROR (MainThread) [custom_components.anglian_water] Unexpected error fetching anglian_water data: 0
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/helpers/update_coordinator.py", line 315, in _async_refresh
    self.data = await self._async_update_data()
                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/config/custom_components/anglian_water/coordinator.py", line 63, in _async_update_data
    await self._insert_statistics()
  File "/config/custom_components/anglian_water/coordinator.py", line 100, in _insert_statistics
    hourly_consumption_data[0]["meterReadTimestamp"]
    ~~~~~~~~~~~~~~~~~~~~~~~^^^
KeyError: 0
2024-04-22 13:49:24.868 DEBUG (MainThread) [custom_components.anglian_water] Finished fetching anglian_water data in 6.172 seconds (success: False)

Diagnostics dump
No response

Thanks.
Note the custom water rate will only be used if you select the "LITE" tariff, otherwise it will always use the tariff information published on the website (https://www.anglianwater.co.uk/services/extra-support/tariff-options/standard-rates/) - also, rates should be specified in £ (eg 2.0954 rather than 20954)

thanks @pantherale0 this makes sense now - I only added 194 as it seemed the input marks 1.94 in red, if I recall correctly but subsequent tests showed it still accept it

Same for me, expected float when selecting standard rate.

Same for me, expected float when selecting standard rate.

just add anything it wont take the custom water rate anyway when selecting standard


Suggestion: Move config to a TDATA folder

A big problem that we've seen in the Xbox community is dashboard is in weird places - there's no standardised place to put dashboard (other than C:/xboxdash.xbe for MS dash that some people overwrite with their custom dash), and therefore the config is up for the ride. To fix this, it may be a good idea to place config inside a TDATA folder.
The main issue here is it requires we decide on a standard code for the dashboard now, like MS' codes (IG-036 for Unreal Championship, etc) - Looking through DBox's publisher list, NX is not in use so we could use that as an NXDK application but that's really your call to make and we still would have to reserve title numbers
Please let me know what you think :)

I thought I had a reason to put it next to the xbe but I cant remember now, it may have been for testing and I forgot to change it :) so I can keen to change that.
I currently use UDATA to store a list of recently played titles, but not sure if TDATA or UDATA is better?
In UDATA I create "UDATA/LithiumX/TitleMeta.xbx" so it appears in the dash save files so can be deleted if needed.

UDATA I believe shows up in the dash save files, I feel that TDATA might be more suited for info like a config (versus recently played titles?) but I could be wrong, and I think DLC shows up anyway in TDATA so it's a weird one on which to pick
Didn't realise you could use full names in the UDATA(/TDATA) folders, in which case my second point is completely moot 😅

I am going to keep in UDATA, I assume this stands for (User)DATA? as opposed to (Title?)DATA plus we can delete in MSDash memory manager which is what I want.
Thanks for the info though


Some fixes in fr/locale.cfg

Fixed locale/fr/locale.cfg by removing a string that shouldn't be here,
Removed a duplicate key in fr/locale.cfg

Thanks for the PR. But it seems to be a duplicate.

Hello, thanks your for your contribution,
before open issue or make a PR? make sure it's not already existed.
=)

https://github.com/notnotmelon/maraxsis/pull/78

? ?
#78 was posted after mine !


Explicit unambigous type for all function arguments and class fields

Following the closure of #18786 I thought maybe a discussion before opening the PR was what was missing.
My project cdd-python can take whole modules as input, and apply type hints, convert between docstring formats, or emit SQLalchemy, argparse, classes, or functions; e.g.,

see this example that takes keras.optimizers as input and produces classes as output:

python -m cdd exmod -m keras.optimizers --emit class -o generated\optimizers

Here is the output from the https://github.com/keras-team/keras/blob/1c1c1d0/keras/optimizers/adam.py (+interpolated) input:
"""
Generated from keras.src.optimizers.adam.
"""
from typing import Optional, Any

class Adam(object):
    """
    Optimizer that implements the Adam algorithm.

        Adam optimization is a stochastic gradient descent method that is based on
        adaptive estimation of first-order and second-order moments.

        According to
        [Kingma et al., 2014](http://arxiv.org/abs/1412.6980),
        the method is "*computationally
        efficient, has little memory requirement, invariant to diagonal rescaling of
        gradients, and is well suited for problems that are large in terms of
        data/parameters*".

    :cvar learning_rate: A float, a `keras.optimizers.schedules.LearningRateSchedule` instance, or a callable that takes no arguments and returns the actual value to use. The learning rate.
    :cvar beta_1: A float value or a constant float tensor, or a callable that takes no arguments and returns the actual value to use. The exponential decay rate for the 1st moment estimates.
    :cvar beta_2: A float value or a constant float tensor, or a callable that takes no arguments and returns the actual value to use. The exponential decay rate for the 2nd moment estimates.
    :cvar epsilon: A small constant for numerical stability. This epsilon is "epsilon hat" in the Kingma and Ba paper (in the formula just before Section 2.1), not the epsilon in Algorithm 1 of the paper.
    :cvar amsgrad: Boolean. Whether to apply AMSGrad variant of this algorithm from the paper "On the Convergence of Adam and beyond".
    """

    learning_rate: float = 0.001
    beta_1: float = 0.9
    beta_2: float = 0.999
    epsilon: float = 1e-07
    amsgrad: bool = False
    global_clipnorm: Optional[Any] = None
    use_ema: bool = False
    name: str = "adam"
    ema_overwrite_frequency: Optional[Any] = None
    clipnorm: Optional[Any] = None
    ema_momentum: float = 0.99
    clipvalue: Optional[Any] = None
    weight_decay: Optional[Any] = None

__all__ = ["Adam"]

Or another example; this time with your https://github.com/keras-team/keras/blob/b9be76a/keras/callbacks/reduce_lr_on_plateau.py †:
class ReduceLROnPlateau(object):
    monitor: str = "val_loss"
    factor: float = 0.1
    patience: int = 10
    verbose: int = 0
    mode: Literal["auto", "max", "min"] = "auto"
    min_delta: float = 0.0001
    cooldown: int = 0
    min_lr: int = 0

For https://github.com/keras-team/keras/blob/b9be76a/keras/callbacks/backup_and_restore_callback.py †:
class BackupAndRestore(object):
    backup_dir: Optional[Any]
    save_freq: Union[Literal["epoch"], bool, int] = "epoch"
    delete_checkpoint: bool = True

†to be succinct on this GitHub issue; just showing the class keyword, name, and fields.

As you can see, though docstring parsing (+ your adhoc type syntax parsing), and inferring from the default value type can give some reasonable resultant types; it is imperfect.
For example, lines like:
A float value or a constant float tensor, or a callable that takes no arguments and returns the actual value to use.

Needs to become:
Union[float, keras.types.FloatTensorType, Callable[[],Union[float, keras.types.FloatTensorType]]

(or with (PEP604)[https://peps.python.org/pep-0604/] | can be used instead of Union and [I think] Literals)

@fchollet can you reconsider using an unambiguous parameter type specification language, like Python's official PEP484 and its derivatives as per the PR you rejected in #18786 ?
Thank you

@SamuelMarks, my apologies for being blunt, but I fail to see how using an unambiguous parameter type specification language helps our case here. The docstrings are primarily (and quite obviously) meant to be human-readable in order to assist users, potential contributors, as well as maintainers. Someone without intricate knowledge of Python's official PEP484 would find it hard to decode what a statement such as Union[float, keras.types.FloatTensorType, Callable[[],Union[float, keras.types.FloatTensorType]] implies.

Thanks for the suggestion. Overall, we aren't interested in adding this feature.

The docstrings are primarily (and quite obviously) meant to be human-readable

This is True. Docstrings are for humans. More generally we've stayed away form type annotations because historically they've caused more issues for us than they've solved problems.

The main advantage, relevant to Keras, is for Google Vizier (also Ray Tune; and others): know what the search space is, so these can be plugged into the search-space and optimised accordingly.

Automatically generating a hparam search space from model code is an impasse (unless you are leveraging ML to do it in a smart way informed by a strong prior based on past data). There is often no distinction between discrete values and continuous values in the API (e.g. the optimizer LR can be a float or a function; the actual range here is the space of all possible scalar functions). And there's an enormous number of possible argument to tune, the range of possible values for almost any argument is infinite, the search space grows combinatorially with number of argument being tuned, and evaluating any single combination is expensive. (For instance, it would be incredibly wasteful to evaluate all possible optimizers when the thing you should focus on is purely the LR schedule for your AdamW optimizer).
This is why hparam optimization relies solely on handcrafted search spaces; you need a human (or a very smart algorithm) to tell you which specific arguments to pay attention to and which narrow value range to look at. You're going to want to explore only the most import 0.01% of possible combinations.

Automatically generating a hparam search space from model code is an impasse (unless you are leveraging ML to do it in a smart way informed by a strong prior based on past data).

I'm doing this partially as a chapter (or two) for my second PhD; partially for some potentially commercial (but open-source) work; and partially for my self-funded charitable medical diagnostic work (at Harvard Medical School / Mass Eye and Ear).
Yes, the idea is most certainly to do this intelligently rather than to greedily search the entire space.

As for future work, very interested in limiting number ranges:

https://github.com/python/mypy/issues/16117
https://github.com/python/typing/issues/1304#issuecomment-1722091885

Often in ML codebases [incl. Keras, JAX, TensorFlow, PyTorch, scikit-learn] there are integers that need to be nonnegative, and floating point numbers that are required to be, for example, inbetwixt 0.0 and 1.0.
What I am trying to do to Keras—and then to those other frameworks/libraries—is to expose what categorical and continuous variables are available (incl. their ranges); and then use this to benchmark, and also to expose interfaces for interaction in:

Databases (ORM, so multi-database)
GUI (cross-platform)
REST API
CLI (cross-platform)
Frontends (web, iOS, Android)
Python SDKs
Other language SDKs

writing cdd-c—like my Python compiler but written in C for C; so C would be the base and every other language can access—think libtensorflow but wrapped in dozens of programming languages

PS: Some test-cases that I got working based on your adhoc syntax - https://github.com/offscale/cdd-python/blob/3f4f84d/cdd/tests/test_docstring/test_parse_docstring_utils.py

@fchollet Can I send smaller PRs your way? - Maybe that just fix ambiguities and inconsistencies without introducing the PEP484 [and derived] syntax throughout your codebase?


Analyzing stakeholder research findings

When [Situation]?
We've met with key stakeholders about content, data and interactivity feasibility
I want to [Motivation]
understand how our findings will impact our prototypes & plans
So I can [Expected Outcome]

Document the touchpoints with the key stakeholders
Make necessary updates

Mtg booked for July 12 at 3p


Complex html structures not rendering properly

Complex html structures not rendering properly when increasing font size in reflowable epubs
This issue is a Bug
Expected Behaviour
Rendering should match iBooks - code line 10 in image below

Observed behaviour
Instead Readium breaks layout slightly 10 is truncated on left

Steps to reproduce

open attached epub with readium
browse to item_GuidedTour
change font size to 190%
go to page 4

Test file(s)
https://drive.google.com/open?id=1HI8ZstBLja7YjD7wOpQ5Rjx_-YtOW9xw
Product

Native application (Readium SDK C++)

official "launcher"
iOS 11.2

I just tried with https://readium.firebaseapp.com (which is readium-js-viewer, which itself is based on the same readium-shared-js code as native iOS / Android reader apps). Everything looks okay in both paginated and scroll view modes:

Yes, it works fine at 100% font size, but if you increase the font size it goes wonky

I suspect this problem occurs because of how Readium applies the font-size change to DOM fragments:
https://github.com/readium/readium-shared-js/blob/develop/js/helpers.js#L256
Applying a percentage value at the top-level does not work in many cases (because of CSS cascade overrides), so the current method is to walk the DOM tree, record the original computed size, then apply the desired "scale" factor as a calculated, not relative value.
Although the line height is proportionally adjusted, I think that your example reveals a similar / related issue with content "gutters". I'm not sure how to address this though...

We've built our own epub reader and managed to get around this by applying webkit-text-size-adjust to the html tag - it seems to work on the entire document

Thanks for the tip! https://developer.mozilla.org/en-US/docs/Web/CSS/text-size-adjust


loadfromJSON is maybe asynchronous?

The script give me some problem that I solve by put false historyProcessing assignment in the callback of loadfromJSON.
I hope this help.

Something like that work better for me:
var self = this;
this.loadFromJSON(history,function(){
self.renderAll.bind(canvas);
self.fire('history:undo');
self.historyNextState = self._historyNext();
self.historyProcessing = false;
});

I didn't quite understand the problem. Could you explain the problem ?

fabric.Canvas.prototype._historySaveAction = function () { ... console.log('_historySaveAction'); } ... fabric.Canvas.prototype.undo = function () {   this.historyProcessing = true;   console.log('historyProcessing true');   const history = this.historyUndo.pop();   if (history) {     this.historyRedo.push(this._historyNext());     this.loadFromJSON(history).renderAll();     this.fire('history:undo');   }   this.historyProcessing = false;   console.log('historyProcessing false'); }
The debug sometimes output>
historyProcessing true
historyProcessing false
_historySaveAction
_historySaveAction

Hello, I think this is a nice point. I will implement it as soon as possible.

Hello,
Thanks for your feedback, I have fixed it. You can install 1.4.0 version.


options object template override seems not to be working

First, thanks for your work, it works well with quasar and ssr.
I'm looking to override the default template (https://github.com/Scrum/vue-2-breadcrumbs#options) to use the breadcrumb quasar component but it does not affect the default one

@heyimmowee Hi, I'm glad to know that someone needs this package.
Yes, thanks for your comment, you really need to determine what is included in the options and prioritize and choose one thing


radix64, fiestel round, small domain

Added radix 64 feature, allowed small domain and user defined number of Fiestel rounds.

Hi @PuspenduBanerjee, I'm not a maintainer, but I wanted to point out that you committed your .idea/ directory. You'll probably want to add it to .gitignore, clean up the extraneous files, and squash your commits so that those files are no longer in the git history.
The CI seems to be failing due to the path to the test file in .travis.yml being pyfpe_ff3/pyfp3_ff3_test.py while that in the repo is tests/pyfpe_ff3_test.py.
I see you created a setup.py which is great. But then I noticed that it seems to conflict with the one from @bschoening on PyPI.
Out of curiosity, what's your motivation for modifying the licenses?

Yes @maresb , you are absolutely right, I shall raise another pull from the fixed head.
Regarding license modification, working on some other product which requires choice of licensing for:

Patent exclusion/inclusion.
Suability for closed source product.


Fix nuget gen on multi-core machines, fix build issue when not building for coreclr

Continuing on from this line comment discussion
@KevinRansom  Yes, I had the size wrong, sorry.  As mentioned on the other thread using the CoreCLR proto added about 8 minutes of download for me before getting to the first stage of compilation (my wifi may be crappy though). Everything proceeded smoothly after that without any noticeable difference.
We probably need to let it ride for a while and then ask contributors how they feel.  There's a question of what we allow (e.g. options to only use CoreCLR, or only use DesktopCLR), and what the defaults are.

My guess is that a large number of potential contributors will want to use one or the other, but not both.

Obviously we will want all Linux and Mac developers to be in "CoreCLR-only" mode.  Since that's the clearest of all things, then perhaps that's something we can focus on.  We definitely need a CoreCLR-only mode of use.

For Windows Developers, it does feel reasonable to have a DesktopCLR-only mode of use.  It is clear that large numbers of Windows developers are not going to move to CoreCLR for a long time.

This is of course the whole drama of CoreCLR - every .NET repo in the world is going to be faced with choices like this.
Re 3 compiler compilations: so far we've always adopted the "clean bootstrap" principle that the final version(s) of the compiler be compiled by Proto, rather than by LKG. This properly handles compiler fixes that affect code generation of the compiler itself, and detects bugs that hork the compiler.
If we stick to that principle, then 3 compilations are required:

LKG --> Proto
Proto --> CoreCLR
Proto or CoreCLR --> DesktopCLR

Note that CoreCLR is produced by a Proto, following the "clean bootstrap" principle.
If we drop the "clean bootstrap" principle, then you can do it with 2.

LKG --> CoreCLR
LKG --> DesktopCLR

For example, that approach is used in the production of FSharp.Compiler.Service which doesn't bootstrap.
So I think the real question is whether we stick to the "clean bootstrap" principle or not.
Cheers!
Don

I think we should merge this? AppVeyor is passing
BTW I notice that tests are no longer being run on a vanilla build.cmd.  I'll add some witches to turn on testing selectively

This is the Jenkins error:
error MSB6004: The specified task executable location "..\..\..\lkg\bin\Debug\dnxcore50\win7-x64\publish\fsc.exe" is invalid. [d:\j\workspace\debug_windows---2f360ea4\src\fsharp\FSharp.Build-proto\FSharp.Build-proto.fsproj]
Indication 1

I quite like build only for build unqualified.
From: Don Syme<EMAIL_ADDRESS>Sent: Saturday, April 9, 2016 5:22 PM
To: Microsoft/visualfsharp<EMAIL_ADDRESS>Cc: Kevin Ransom<EMAIL_ADDRESS>Subject: Re: [Microsoft/visualfsharp] Fix nuget gen on multi-core machines, fix build issue when not building for coreclr (#1053)
I think we should merge this? AppVeyor is passing
BTW I notice that tests are no longer being run on a vanilla build.cmd. I'll add some witches to turn on testing selectively
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHubhttps://github.com/Microsoft/visualfsharp/pull/1053#issuecomment-207890337

I quite like build only for build unqualified.

Yes, agreed.  Do you like build.cmd runtests to turn on all testing?

Build all is what I would use
From: Don Syme<EMAIL_ADDRESS>Sent: Saturday, April 9, 2016 5:50 PM
To: Microsoft/visualfsharp<EMAIL_ADDRESS>Cc: Kevin Ransom<EMAIL_ADDRESS>Subject: Re: [Microsoft/visualfsharp] Fix nuget gen on multi-core machines, fix build issue when not building for coreclr (#1053)
I quite like build only for build unqualified.
Yes, agreed. Do you like build.cmd runtests to turn on all testing?
—
You are receiving this because you modified the open/close state.
Reply to this email directly or view it on GitHubhttps://github.com/Microsoft/visualfsharp/pull/1053#issuecomment-207892302


Find() currently returns a slice of pointers. Could it be tweaked to return a slice of plain model values instead?

I noticed that after generation, the Find method returns a pair of the following sort:
[]*model.User, error

I understand why this could possibly make sense for First() (returning a pointer), but the slice itself being a kind of implicit pointer reference, it can be a simple slice of values instead:
[]model.User, error

Actually, why do you go returning pointers in the first place, as the user still needs to manually check for ErrNotFound. In other words, the nil-ability of the end result does not bring much. Or am I missing something?
In short, is there a single option that would tweak methods to return non-pointer values instead?

Sorry for reply late reply.
In GO, parameters are passed between functions using pass-by-value, which means each time you access the value in model array(for range or sth else), the struct will be copied. When the struct array is long, the copy operation can be time-consuming.

@riverchu That's true, but I hope you are aware of the fact that a large percentage of Go developers prefer copying of struct values, even when those are part of a slice. You can see this everywhere - even the original GORM documentation encourages this approach everywhere (I have rarely seen a model referred to, or returned as a pointer). In addition, if you look at how people use GORM, nowadays, you will find hundreds, if not thousands of projects wrapping GORM calls in functions like these:
func (r *UserRepository) FindUsers(ids []string) ([]User, error) {
    // GORM call here
}

Anyway, I am not trying to discourage your approach, but just give some light on commonly accepted practices among GORM  (and Go) users out there.


ValueError: not enough values to unpack (expected 2, got 1)

python train.py
加载自定义词典成功
加载自定义词典成功
WARNING: Logging before InitGoogleLogging() is written to STDERR
I0425 17:05:53.758841  4566 ProcessGroupNCCL.cpp:686] [Rank 0] ProcessGroupNCCL initialization options:NCCL_ASYNC_ERROR_HANDLING: 1, NCCL_DESYNC_DEBUG: 0, NCCL_ENABLE_TIMING: 0, NCCL_BLOCKING_WAIT: 0, TIMEOUT(ms): 1800000, USE_HIGH_PRIORITY_STREAM: 0, TORCH_DISTRIBUTED_DEBUG: OFF, NCCL_DEBUG: OFF, ID=187465152
Traceback (most recent call last):
File "train.py", line 106, in
torch.multiprocessing.spawn(train, args=(world_size,), nprocs=world_size, join=True)
File "/usr/local/lib/python3.8/site-packages/torch/multiprocessing/spawn.py", line 246, in spawn
return start_processes(fn, args, nprocs, join, daemon, start_method="spawn")
File "/usr/local/lib/python3.8/site-packages/torch/multiprocessing/spawn.py", line 202, in start_processes
while not context.join():
File "/usr/local/lib/python3.8/site-packages/torch/multiprocessing/spawn.py", line 145, in join
raise ProcessExitedException(
torch.multiprocessing.spawn.ProcessExitedException: process 0 terminated with signal SIGBUS
env
pip list | grep torch
apex                      0.1+2a4864d.abi0.dtk2310.torch2.1
torch                     2.1.0a0+git793d2b5.abi0.dtk2310
torchaudio                2.1.2+4b32183.abi0.dtk2310.torch2.1.0a0
torchvision               0.16.0+git267eff6.abi0.dtk2310.torch2.1.0

mv checkpoints/vocoder.pt ./

Thank you for your issue report!
The problem comes from the file load.py. This has been fixed in the latest version. In the new version, you no longer need to delete checkpoints/vocoder.pt.
Let me know if you encounter any other issues!


GBIF data import

Import occurrence data for a species from GBIF, limiting them to:

points with coordinates
points with no geospatial issue

Things to think about in the future could be:

highlighting points by their basis of record
highlighting points in the same cluster (possible duplicates)
only getting points by their basis of record

Partially resolved with commits 45af2a85cdb25abbb82609f7dbdea26edb7d4c5a and 19d50e39003ccb401452649ea9ec9a45ca112300
Can you please check @barnabywalker

closed a couple of times, latest with #42


Including doc comments from protocol being mocked?

Not sure if this is supported by swift macros today, but if it was, it could be a nice enhancement for people (like me) who use Xcode's alt+click quick help feature while writing their unit tests to jog their memory. 🧠
Thoughts?

Opened a PR to address this: https://github.com/Kolos65/Mockable/pull/97


cant edit the settings

out of the box installation in a windows 10 with vs2017 and the settings menu is trying to open a file i guess with my vs to edit, and i jsut get vs17 opening in a blank enviroment. what is the file and where is located and why do you allow it to open with the default editor when clearly is not?

Have you tried opening the file using another editor other than Visual Studio?
How to change your default editor

Try using something like Visual Studio Code (the JSON schema will give you IntelliSense on possible parameters in Terminal Settings). If you don't want to install VS Code, use another text editor of choice

There currently isn't a settings UI - opening the settings file will open in whatever your default editor for .json files is.
/dup #1586
/dup #1460


Should PQCP implementations ship randombytes()

During the 2024-07-18 TSC meeting, we were discussing https://github.com/pq-code-package/tsc/issues/4.
Let me try to summarize (please correct me if I got something wrong):
There appears to be consensus that the derandomized APIs should be supported by all implementations in the PQ Code Package.
The discussion then drifted towards if the randomized APIs should also be required or not. Some opinions were raised that the derandomized versions are much easier to integrate into other libraries/software as secure randomness can be provided from the outside. This lead to discussions whether or not we should take on the responsibility of providing a good source of randomness at all or if this should be expected to be provided by the user.
While these discussions were mostly about APIs, I think it makes sense to discuss this separately: Do we want to include a decent default randombytes implementation or not?
If we don't, then not supporting the randomized APIs sounds like a reasonable choice as it will ease the integration.
If we do, then the randomized APIs are easier to use and harder to misuse.
Some strong opinions on this have been voiced, and the conclusion was that we need to discuss this in a broader group. We may want a TSC vote on this in case we want this to be consistent across projects.

My view is that the developers and maintainers of pqcp are (hopefully) more qualified to pick a randombytes implementation that is less likely going to result in disasters. This at least applies to common platforms and operating systems.
This may not matter for integrations into other big crypto libraries like liboqs or mbedtls, but it does matter for smaller projects developed by people with less cryptography experience.
I'd very much prefer to provide a good default choice even if we want to document that user should replace the randomness generation with their own suitably secure randomness generator. I think we should make it easy to replace it, but very hard to misuse.
I'm worried that we will see pqcp code being used in the wild with hard-coded randomness - because who really knows what coins is supposed to be? I am not sure how we can avoid this if we really decide to only support the derandomized APIs.
To confirm my point, I asked ChatGPT to use the API we proposed in #4 (mostly for fun - I don't think this is what we should worry about most). It produced the following code:
...
uint8_t coins[32];     // Random coins

// In a real-world scenario, you would obtain these from a proper source
for (int i = 0; i < 32; i++) {
    coins[i] = (uint8_t)(255 - i);
}

// Call the pqcp_mlkem512_ref_enc_derand function
int result = pqcp_mlkem512_ref_enc_derand(ct, ss, pk, coins);

This results in convieniently useless crypto. At least ChatGPT seems to know that you should not do it like this, but who will really read that comment here?
I am also curious where it learned that this is a good example of initializing randomness.

I lean towards thinking that providing a good source of randomness is a difficult problem on its own that is outside of the scope of PQCP and should be handled by whatever higher-level stack PQCP will be used with.
Some thoughts on the risk @mkannwischer flags regarding people directly using the PQCP API and doing it badly by providing poor random coins:

As @mkannwischer says, we should distinguish the question of scope from the question of API. The issue of a coins parameter that's tempting to use with 0's first and then forget about it, is one of API, not one of scope. If we decide randomness is out of scope, one could instead consider an API with an unimplemented randombytes hook that users need to link against, and instead of a coins parameter the user has to pass a randomness context. Something like int mlkem512_ref_enc_derand(uint8_t *ct, uint8_t *ss, const uint8_t *pk, void *rnd_ctxt); where rnd_ctxt is an opaque pointer passed to a user-provided stateful randombytes. I'm not saying that this is necessarily the best API, but it would be easier to flag in the documentation of randombytes() that this MUST be a proper source of randomness, and it takes more effort for a user to ignore -- so certainly there's options to consider other than necessarily having a plain coins parameter.
How likely are customers of PQCP that do just use PQCP and not also another cryptographic stack? Using just PQCP would already be a bad idea because you should be using some hybrid PK scheme, not solely rely on PQCP. So I'm not sure if we even serve the customer well by making it easy to use PQCP standalone.

I lean towards providing randombytes() in PQCP code.
I like the idea of "it works." When "it doesn't work", the as-is PQCP randombytes() "shouldn't compile", then the developer must sit down and read the manual.

PQCP should ship the randombytes() function for the "it works!" idea. This will make the majority happy.
When it doesn't work, any potential error should appear at compile time, IMO. In that case, I'm sure the developers know what they are dealing with on their platforms/OS, perhaps they already have a solution somewhere in their stack.

I'm concerned that if randombytes() isn't included in PQCP or if it complicates the API, things can easily go wrong.

If there's a randomized version in the API, then PQCP is going to need an implementation of randombytes at least for testing. So then the question becomes whether you make that testing implementation a serious implementation or not. If the testing implementation isn't done properly, there's a risk that someone will copy that code, thinking it's okay, even though it's not.

A question we need to answer here is how we expect folks to use the code here.

Integration into an existing crypto library will most likely NOT require a randombytes function. No serious crypto library can do without a proper rng.
Integration into other (potentially, not crypto) code. This would be the "it works" case as @cothan called it, and would require a randombytes function.

If we actually expect usage outside of crypto library, we have to provide randomness.
I personally think people really shouldn't use it in this way. But at the same time do I expect people to actually use it that way 😔.  Which implies that we should provide something.

One of the consumers of the implementations here in general would be something like liboqs - effectively a cryptolibrary. That would likely take the responsibility to provide a rng. Or either via liboqs or directly into say OpenSSL - again with rng. All examples of 1. above.
This seems most likely, but I still agree with @franziskuskiefer 's last point that we do include a rng (with clear documented caveats etc) since some I think will use directly

I think the barrier created by not providing an RNG is a more effective way of conveying that there's non-trivial work to be done here, than providing an insecure default and trying to grab people's attention through documentation and warning messages.
I remain opposed to shipping randombytes() -- it's out of scope IMO.

My impression was that in the TSC meetings the consensus was that we do not ship a randombytes(). Can we close this issue then?

I think that's the consensus too, I think the group were keen to get your final input. Let's confirm on call today?

This was discussed during the 11/21 TSC meeting again and there are no objections. We can close this issue.


feat(metrics): support reference counting in metrics label

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Related to https://github.com/risingwavelabs/risingwave/issues/12805
Resolve https://github.com/risingwavelabs/risingwave/issues/12848.
Improve the guarded label metrics to support label level reference counting so that multiple call on a same list label values is allowed, and only the last dropped one will remove the labels from the metrics vec.
Metrics greater than 100 in the following prod cluster metrics list are ported to the new label guarded metrics.
578 connection_writer_count
 578 connection_write_rate
 578 connection_reader_count
 578 connection_read_rate
 578 connection_create_rate
 578 connection_count
 576 state_store_iter_scan_duration_bucket
 576 state_store_iter_init_duration_bucket
 440 stream_join_barrier_align_duration_bucket
 424 stream_actor_input_buffer_blocking_duration_ns
 410 stream_actor_output_buffer_blocking_duration_ns
 360 state_store_get_duration_bucket
 290 stream_join_matched_join_keys_bucket
 264 stream_memory_usage
 264 lru_evicted_watermark_time_ms
 258 actor_sampled_serialize_duration_ns
 217 stream_actor_in_record_cnt
 192 state_store_iter_fetch_meta_duration_bucket
 178 stream_actor_out_record_cnt
 168 actor_sampled_deserialize_duration_ns
 156 state_store_sst_store_block_request_counts
 156 state_store_iter_scan_key_counts
 128 stream_join_lookup_total_count
 128 stream_join_lookup_miss_count
 128 stream_join_insert_cache_miss_count
 128 stream_join_cached_entries
 117 stream_join_match_duration_ns
 117 state_store_read_req_positive_but_non_exist_counts
 117 state_store_read_req_check_bloom_filter_counts
 117 state_store_read_req_bloom_filter_positive_counts

Checklist

[ ] I have written necessary rustdoc comments
[x] I have added necessary unit tests and integration tests
[ ] I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features #7934).
[ ] My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
[x] All checks passed in ./risedev check (or alias, ./risedev c)
[ ] My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)

[ ] My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

[ ] My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

Is this method applicable for https://github.com/risingwavelabs/risingwave/issues/9492?


Fix PNG CRC errors

There are PNG CRC errors which probably come from the overlay rendering:
libpng error: IDAT: CRC error

It seems that the PNG data is read and written in parallel which causes the PNG data to be partly destroyed when being drawn. Besides overlay_ready there should be an indicator whether it currently is being drawn and then should not be written again.


Macro Miss-behaving.

So I use this G-Code in a macro.
G90
G21
$H
M00
G92 Z0
G01 Z-20 F1000
F500
G38.2 Z-60
G92 Z0
G01 Z5
F50
G38.2 Z-7
G92 Z6.6
G01 Z30 F1500
G53 X-708 Y-1463.7 F4000
G92 X0 Y0
On the last line, the G92 dont set my X0 Y0.
On my very next move I receive a error Invalid gcode ID:24
If I load the G-Code as a file, it works great.
What do you think that could be.

Mnn, I know that I still need to implement some kind of 'wait for ok' on the macro stream, it presently uses the MDI mechanism which just hoses the commands to Grbl. Wonder if G53 access EEPROM (not mentioned in the list on the Grbl wiki).
Can you try adding an M0 after the G53? You will have to Start to continue.

I shortened the code and it seems fine. Instead of changing speeds so many
times. I use F2500 for both F1500 and F4000 mm per min.
Is it possible there is a limit to the length of the macro?
Thanks
Bill
On Mar 20, 2016 4:34 PM, "Gerrit Visser"<EMAIL_ADDRESS>wrote:

Mnn, I know that I still need to implement some kind of 'wait for ok' on
the macro stream, it presently uses the MDI mechanism which just hoses the
commands to Grbl. Wonder if G53 access EEPROM (not mentioned in the list on
the Grbl wiki).
Can you try adding an M0 after the G53? You will have to Start to continue.
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/gerritv/Grbl-Panel/issues/55#issuecomment-199015263

Yes, that is a definite possibility and related to my not waiting for on Ok before sending out the next line. I will start looking at a solution now that the issue has really popped up.


Support new text-embedding-ada-002 model in text2vec-openai module

What's being changed:

add new config field "version" which accepts either "001" or "002"
if no config is provided the default is model=ada, modelVersion=002, type=text
there is new validation that makes sure that invalid combinations such as model=ada, modelVersion=002, type=code or model=curie, modelVersion=002, type=text are not allowed
there is new logic that builds the right model script based on the version number. This was required because 002 no longer uses separate models for query and document, but just a single model

Review checklist

[x] Documentation has been updated, if necessary. Link to changed documentation: @bobvanluijt is in the process of doing that and releasing it when ready
[ ] Chaos pipeline run or not necessary. Link to pipeline:
[x] All new code is covered by tests where it is reasonable.
[ ] Performance tests have been run or not necessary.

https://openai.com/blog/new-and-improved-embedding-model/
The older embeddings were built specifically for code, search, etc. The new ada-002 embeddings do not have this level of granularity:
Unification of capabilities. We have significantly simplified the interface of the [/embeddings](https://beta.openai.com/docs/api-reference/embeddings) endpoint by merging the five separate models shown above (text-similarity, text-search-query, text-search-doc, code-search-text and code-search-code) into a single new model. This single representation performs better than our previous embedding models across a diverse set of text search, sentence similarity, and code search benchmarks.

Also, the new embeddings are universally recommended due to performance and price advantages:
https://beta.openai.com/docs/guides/embeddings/embedding-models
We recommend using text-embedding-ada-002 for nearly all use cases. It’s better, cheaper, and simpler to use. Read the [blog post announcement](https://openai.com/blog/new-and-improved-embedding-model).

Thank you so much, @kcm! I've taken the liberty to rebase this onto stable/v1.16 (and change the base branch of the PR accordingly), so we can release it as a v1.16.8 patch. Next up, I will also look into making the new module the default and do an e2e check. If all is fine, we can release it later today.

I've added a few more changes. Instead of naming the model ada2 which isn't consistent with OpenAI's naming, I've added an explicit modelVersion field that can take either "001" or "002".
If the user selects ada and does not select code, we now default to 002, but default to 001 in all other cases.
I can't test the change at the moment because I'm getting these errors:
failed with status: 500 error: The server had an error while processing your request. Sorry about that! You can retry your request, or contact us through our help center at help.openai.com if the error persists. (Please include the request ID 1f387e978127c408ea5c45f9d4a53310 in your message.)

Naming should also support fine-tuned model names, no?

Naming should also support fine-tuned model names, no?

That's a good point, what could we do UX-wise @etiennedi?

The OpenAI QnA module does it already, allowing a model's full name:

Let's tackle arbitrary names in a different PR. I agree that we should support it, but we need to answer a few questions around backward compatibility query/doc model split, etc. I'll create a separate issue for this.

Here's the issue for arbitrary model names.


Reorganize task label colors

Reorganizes task label colors such that:

Task States that don't require action, but aren't serving requests are info or primary (different shades of blue that distinguish similar but different states)
Task States that are currently serving requests are success (green)
Task States that indicate a failure and may require attention are danger (red)
Task States that indicate either a small problem or no problem, but aren't a task-initiated completion, are warning (orange)
Task States that are unknown to the UI are default (black)

cc @ssalinas @tpetr @markhazlewood @wolfd @kwm4385
This PR should not be merged until all of those people have a chance to look at it and share their opinions because it is a fairly large change in the look of tasks (even if the code is small).
The original motivation was to distinguish tasks that are currently serving requests from ones that aren't, but then grew to group similar states as a whole.
Screenshots:

A few things:

TASK_KILLED should not be an orange. Tasks will end up in this state if they are asked to shut down and do so gracefully. The orange signifies to me that something is still wrong/might be wrong. I'd argue for keeping the current grey for killed
I'm unsure about TASK_CLEANING, it'd make more sense to keep it green if we had another state to transition to when a task was in the process of being killed, and no longer serving requests (i.e. making better use of TASK_KILLING, but currently a cleaning task (for however short a time) may not always be serving requests (in the case of a web service). Could be convinced otherwise on this, but wanted to state the concern

This might be easier to reason about if we make a tree of the task lifecycle chronologically and see if it makes sense to assign colors by region.

Approve of these changes and agree w/ @ssalinas and @kwm4385 on all counts.

Here's the tree as best I understand it. Sorry it's not pretty, I'm not Mark :p There are probably a bunch more arrows going to Lost, Failed, and Lost While Down, but this should be the general idea.

The reason TASK_CLEANING was green is because I thought it was always serving requests. Remember the original problem was that TASK_CLEANING being orange was worrying developers, who thought there was nothing serving their requests for a short period. What color would you suggest?
Another possibility would be to redesign the request detail page entirely to show tasks that are serving requests in their own table. Then there could be at most one state of each color in each table (except the completed tasks table, since there are a bunch of bad states).

My reasoning:
Green: Task is running and guaranteed to be serving requests at this time
Light/dark blue: Task may not be serving requests, but the state that it's in is expected and no action is needed
Red: Something went wrong and you may want to investigate
Orange: Something is wrong but action might not be required on your part
Grey: Task is waiting/not relevent now

While I agree with most of that chart, it still doesn't solve the anxiety that occurs when all tasks are in cleaning or starting during certain kinds of bounce.

I suppose the only answer to that would be to make cleaning and running the same color.

Then we're back to the problem that @ssalinas had which is that cleaning isn't guaranteed to be serving requests...
We're kind of stuck between a rock and a hard place here.

Yeah I think its either we solve that anxiety by telling people something that isn't quite true, or be absolutely accurate in our labeling.

Maybe we could use dark blue for cleaning and light blue for finished. Then add a note of some sort (maybe an alert) that cleaning tasks may still be accepting requests.

Closing this to avoid making huge UX changes in the decaf branch.
Once deacf is merged we will circle back to this.


After training testing code gives error like "r2n/Reshape_9:0 is missing

Hi, I have tried retraining of pre-trained network and training from scratch using the training code that you have given. After 400 epoches i have  saved the model of both. But i got same error in both model while testing.  error was in below line
Y_pred = tf.get_default_graph().get_tensor_by_name("r2n/Reshape_9:0")
r2n/Reshape_9 tensor was not there. I have confirmed it by TensorBoard. But while checking the graph generated by pre-trained network which is downloaded shows the same tensor.  How it is possible??
One interesting thing is that , I changed the code line as below
Y_pred = tf.get_default_graph().get_tensor_by_name("r2n/Reshape_7:0")
And then tested with my trained network. It give output. Because after training myself r2n block takes 323232 sized voxels from r2n/Reshape_7:0.
Can you explain why it is so???

@Ajithbalakrishnan sorry for the delay. Have you solved it?  Which version tf do u use? seems the default name for the tensor is changed.

Thanks for the reply sir. yes i solved it. After training from scratch i took voxel output ( Y_pred ) from "r2n/Reshape_7:0" tensor.
One more doubt is that in this paper you said the loss function is IOU. But in the implementation code it seems like you have used cross entropy loss which is described in the base paper 3D-R2N2.  why it is so?
I got similar loss functions listed below
1.IOU
2.Chamfer distance
3.Cross entropy
4. Earth movers distance ( https://arxiv.org/abs/1612.00603 )
how can i select a good loss function from this?

@Ajithbalakrishnan As to voxel prediction, the cross-entropy loss is usually used for this binary classification problem.

Thanks , I got it.
Can you please share the code for finding the IOU ?
I have tried with the below code for IOU . But it got an error
InvalidArgumentError (see above for traceback): assertion failed: [labels out of bound] [Condition x < y did not hold element-wise:] [x (mean_iou/confusion_matrix/control_dependency:0) = ] [0 0 0...] [y (mean_iou/ToInt64_2:0) = ] [1]
Code -
import tensorflow as tf
import os
import sys
sys.path.append('..')
import tools as tools
import numpy as np
import matplotlib.pyplot as plt
import pandas as pd
GPU='0'
vox_res = 32
def load_real_rgbs(test_mv=3):
obj_rgbs_folder ='./Data_sample/amazon_real_rgbs/lamp/'
rgbs = []
rgbs_views = sorted(os.listdir(obj_rgbs_folder))
for v in rgbs_views:
if not v.endswith('png'): continue
rgbs.append(tools.Data.load_single_X_rgb_r2n2(obj_rgbs_folder + v, train=False))
rgbs = np.asarray(rgbs)
x_sample = rgbs[0:test_mv, :, :, :].reshape(1, test_mv, 127, 127, 3)
return x_sample, None
def load_shapenet_rgbs(test_mv=3):
obj_rgbs_folder = './Data_sample/ShapeNetRendering/03001627/1a6f615e8b1b5ae4dbbc9440457e303e/rendering/'
obj_gt_vox_path ='./Data_sample/ShapeNetVox32/03001627/1a6f615e8b1b5ae4dbbc9440457e303e/model.binvox'
rgbs=[]
rgbs_views = sorted(os.listdir(obj_rgbs_folder))
for v in rgbs_views:
if not v.endswith('png'): continue
rgbs.append(tools.Data.load_single_X_rgb_r2n2(obj_rgbs_folder + v, train=False))
rgbs = np.asarray(rgbs)
x_sample = rgbs[0:test_mv, :, :, :].reshape(1, test_mv, 127, 127, 3)
y_true = tools.Data.load_single_Y_vox(obj_gt_vox_path)
#########################################
Y_true_vox = []
Y_true_vox.append(y_true)
Y_true_vox = np.asarray(Y_true_vox)
return x_sample, Y_true_vox
#########################################
def ttest_demo():
model_path = './Model_released/'
if not os.path.isfile(model_path + 'model.cptk.data-00000-of-00001'):
print ('please download our released model first!')
return
config = tf.ConfigProto(allow_soft_placement=True)
config.gpu_options.visible_device_list = GPU
with tf.Session(config=config) as sess:
    saver = tf.train.import_meta_graph(model_path + 'model.cptk.meta', clear_devices=True)
    saver.restore(sess, model_path + 'model.cptk')
    print ('model restored!')

    X = tf.get_default_graph().get_tensor_by_name("Placeholder:0")
    Y_pred = tf.get_default_graph().get_tensor_by_name("r2n/Reshape_9:0")

x_sample, gt_vox = load_real_rgbs()
    x_sample, gt_vox = load_shapenet_rgbs()

### IOU #########################################################
    gt_vox=gt_vox.astype(np.float64)

    Y_vox_ = tf.reshape(gt_vox, shape=[-1, vox_res ** 3,1])
    Y_pred_ = tf.reshape(Y_pred, shape=[-1, vox_res ** 3,1])
    iou = tf.metrics.mean_iou(labels=Y_vox_,predictions=Y_pred_,num_classes=1)
    sess.run(tf.local_variables_initializer())

#########################################################
## session run
y_pred,recon_loss,iou_value = sess.run([Y_pred, rec_loss,iou], feed_dict={X: x_sample})
print("IOU :",iou_value)
###### to visualize
th = 0.25
y_pred[y_pred>=th]=1
y_pred[y_pred<th]=0
tools.Data.plotFromVoxels(np.reshape(y_pred,[32,32,32]), title='y_pred')
if gt_vox is not None:
tools.Data.plotFromVoxels(np.reshape(gt_vox,[32,32,32]), title='y_true')
from matplotlib.pyplot import show
show()
#########################
if name == 'main':
ttest_demo()

@Ajithbalakrishnan  Here's the script for IoU calculation.
def metric_IoU(batch_voxel_occup_pred, batch_voxel_occup_true):
    batch_voxel_occup_pred_ = copy.deepcopy(batch_voxel_occup_pred)
    batch_voxel_occup_pred_[batch_voxel_occup_pred_ >= 0.5] = 1
    batch_voxel_occup_pred_[batch_voxel_occup_pred_ < 0.5] = 0
    I = batch_voxel_occup_pred_ * batch_voxel_occup_true
    U = batch_voxel_occup_pred_ + batch_voxel_occup_true
    U[U < 1] = 0
    U[U >= 1] = 1
    iou = np.sum(I) * 1.0 / np.sum(U) * 1.0
    return iou

Thank you . It Works.
Instead of cross-entropy have you ever tried with any other loss functions like,
1.Earth movers distance ( https://arxiv.org/abs/1612.00603)
2.Mean squared false cross entropy loss ( MSFCEL) (https://arxiv.org/abs/1804.06375)
or any other......
Can you please share your opinion?

@Ajithbalakrishnan  sorry, I didn't try it.

Ok Thanks.
Till now i only tried to train from scratch. But,
While retrain the released model (uncommented the line in main_attsets.py)
i got an error... Its given below.
total weights: 52590114
2019-06-12 04:38:53.597409: I tensorflow/core/platform/cpu_feature_guard.cc:141] Your CPU supports instructions that this TensorFlow binary was not compiled to use: SSE4.1 SSE4.2 AVX FMA
2019-06-12 04:38:53.597951: I tensorflow/core/common_runtime/process_util.cc:69] Creating new thread pool with default inter op setting: 2. Tune using inter_op_parallelism_threads for best performance.
restoring saved model!
2019-06-12 04:38:57.550933: W tensorflow/core/framework/op_kernel.cc:1273] OP_REQUIRES failed at save_restore_v2_ops.cc:184 : Not found: Key beta1_power_2 not found in checkpoint
Traceback (most recent call last):
File "/home/wiproec4/anaconda3/envs/attsets/lib/python3.6/site-packages/tensorflow/python/client/session.py", line 1292, in _do_call
return fn(*args)
File "/home/wiproec4/anaconda3/envs/attsets/lib/python3.6/site-packages/tensorflow/python/client/session.py", line 1277, in _run_fn
options, feed_dict, fetch_list, target_list, run_metadata)
File "/home/wiproec4/anaconda3/envs/attsets/lib/python3.6/site-packages/tensorflow/python/client/session.py", line 1367, in _call_tf_sessionrun
run_metadata)
tensorflow.python.framework.errors_impl.NotFoundError: Key beta1_power_2 not found in checkpoint
[[{{node save/RestoreV2}} = RestoreV2[dtypes=[DT_FLOAT, DT_FLOAT, DT_FLOAT, DT_FLOAT, DT_FLOAT, ..., DT_FLOAT, DT_FLOAT, DT_FLOAT, DT_FLOAT, DT_FLOAT], _device="/job:localhost/replica:0/task:0/device:CPU:0"](_arg_save/Const_0_0, save/RestoreV2/tensor_names, save/RestoreV2/shape_and_slices)]]
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/home/wiproec4/anaconda3/envs/attsets/lib/python3.6/site-packages/tensorflow/python/training/saver.py", line 1538, in restore
{self.saver_def.filename_tensor_name: save_path})
File "/home/wiproec4/anaconda3/envs/attsets/lib/python3.6/site-packages/tensorflow/python/client/session.py", line 887, in run
run_metadata_ptr)
File "/home/wiproec4/anaconda3/envs/attsets/lib/python3.6/site-packages/tensorflow/python/client/session.py", line 1110, in _run
feed_dict_tensor, options, run_metadata)
File "/home/wiproec4/anaconda3/envs/attsets/lib/python3.6/site-packages/tensorflow/python/client/session.py", line 1286, in _do_run
run_metadata)
File "/home/wiproec4/anaconda3/envs/attsets/lib/python3.6/site-packages/tensorflow/python/client/session.py", line 1308, in _do_call
raise type(e)(node_def, op, message)
tensorflow.python.framework.errors_impl.NotFoundError: Key beta1_power_2 not found in checkpoint
[[{{node save/RestoreV2}} = RestoreV2[dtypes=[DT_FLOAT, DT_FLOAT, DT_FLOAT, DT_FLOAT, DT_FLOAT, ..., DT_FLOAT, DT_FLOAT, DT_FLOAT, DT_FLOAT, DT_FLOAT], _device="/job:localhost/replica:0/task:0/device:CPU:0"](_arg_save/Const_0_0, save/RestoreV2/tensor_names, save/RestoreV2/shape_and_slices)]]
Caused by op 'save/RestoreV2', defined at:
File "main_AttSets.py", line 475, in
net.build_graph()
File "main_AttSets.py", line 378, in build_graph
self.saver = tf.train.Saver(max_to_keep=1)
File "/home/wiproec4/anaconda3/envs/attsets/lib/python3.6/site-packages/tensorflow/python/training/saver.py", line 1094, in init
self.build()
File "/home/wiproec4/anaconda3/envs/attsets/lib/python3.6/site-packages/tensorflow/python/training/saver.py", line 1106, in build
self._build(self._filename, build_save=True, build_restore=True)
File "/home/wiproec4/anaconda3/envs/attsets/lib/python3.6/site-packages/tensorflow/python/training/saver.py", line 1143, in _build
build_save=build_save, build_restore=build_restore)
File "/home/wiproec4/anaconda3/envs/attsets/lib/python3.6/site-packages/tensorflow/python/training/saver.py", line 787, in _build_internal
restore_sequentially, reshape)
File "/home/wiproec4/anaconda3/envs/attsets/lib/python3.6/site-packages/tensorflow/python/training/saver.py", line 406, in _AddRestoreOps
restore_sequentially)
File "/home/wiproec4/anaconda3/envs/attsets/lib/python3.6/site-packages/tensorflow/python/training/saver.py", line 854, in bulk_restore
return io_ops.restore_v2(filename_tensor, names, slices, dtypes)
File "/home/wiproec4/anaconda3/envs/attsets/lib/python3.6/site-packages/tensorflow/python/ops/gen_io_ops.py", line 1466, in restore_v2
shape_and_slices=shape_and_slices, dtypes=dtypes, name=name)
File "/home/wiproec4/anaconda3/envs/attsets/lib/python3.6/site-packages/tensorflow/python/framework/op_def_library.py", line 787, in _apply_op_helper
op_def=op_def)
File "/home/wiproec4/anaconda3/envs/attsets/lib/python3.6/site-packages/tensorflow/python/util/deprecation.py", line 488, in new_func
return func(*args, **kwargs)
File "/home/wiproec4/anaconda3/envs/attsets/lib/python3.6/site-packages/tensorflow/python/framework/ops.py", line 3272, in create_op
op_def=op_def)
File "/home/wiproec4/anaconda3/envs/attsets/lib/python3.6/site-packages/tensorflow/python/framework/ops.py", line 1768, in init
self._traceback = tf_stack.extract_stack()
NotFoundError (see above for traceback): Key beta1_power_2 not found in checkpoint
[[{{node save/RestoreV2}} = RestoreV2[dtypes=[DT_FLOAT, DT_FLOAT, DT_FLOAT, DT_FLOAT, DT_FLOAT, ..., DT_FLOAT, DT_FLOAT, DT_FLOAT, DT_FLOAT, DT_FLOAT], _device="/job:localhost/replica:0/task:0/device:CPU:0"](_arg_save/Const_0_0, save/RestoreV2/tensor_names, save/RestoreV2/shape_and_slices)]]
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/home/wiproec4/anaconda3/envs/attsets/lib/python3.6/site-packages/tensorflow/python/training/saver.py", line 1548, in restore
names_to_keys = object_graph_key_mapping(save_path)
File "/home/wiproec4/anaconda3/envs/attsets/lib/python3.6/site-packages/tensorflow/python/training/saver.py", line 1822, in object_graph_key_mapping
checkpointable.OBJECT_GRAPH_PROTO_KEY)
File "/home/wiproec4/anaconda3/envs/attsets/lib/python3.6/site-packages/tensorflow/python/pywrap_tensorflow_internal.py", line 359, in get_tensor
status)
File "/home/wiproec4/anaconda3/envs/attsets/lib/python3.6/site-packages/tensorflow/python/framework/errors_impl.py", line 526, in exit
c_api.TF_GetCode(self.status.status))
tensorflow.python.framework.errors_impl.NotFoundError: Key _CHECKPOINTABLE_OBJECT_GRAPH not found in checkpoint
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "main_AttSets.py", line 475, in
net.build_graph()
File "main_AttSets.py", line 392, in build_graph
self.saver.restore(self.sess, path + 'model.cptk')
File "/home/wiproec4/anaconda3/envs/attsets/lib/python3.6/site-packages/tensorflow/python/training/saver.py", line 1554, in restore
err, "a Variable name or other graph key that is missing")
tensorflow.python.framework.errors_impl.NotFoundError: Restoring from checkpoint failed. This is most likely due to a Variable name or other graph key that is missing from the checkpoint. Please ensure that you have not altered the graph expected based on the checkpoint. Original error:
Key beta1_power_2 not found in checkpoint
[[{{node save/RestoreV2}} = RestoreV2[dtypes=[DT_FLOAT, DT_FLOAT, DT_FLOAT, DT_FLOAT, DT_FLOAT, ..., DT_FLOAT, DT_FLOAT, DT_FLOAT, DT_FLOAT, DT_FLOAT], _device="/job:localhost/replica:0/task:0/device:CPU:0"](_arg_save/Const_0_0, save/RestoreV2/tensor_names, save/RestoreV2/shape_and_slices)]]
Caused by op 'save/RestoreV2', defined at:
File "main_AttSets.py", line 475, in
net.build_graph()
File "main_AttSets.py", line 378, in build_graph
self.saver = tf.train.Saver(max_to_keep=1)
File "/home/wiproec4/anaconda3/envs/attsets/lib/python3.6/site-packages/tensorflow/python/training/saver.py", line 1094, in init
self.build()
File "/home/wiproec4/anaconda3/envs/attsets/lib/python3.6/site-packages/tensorflow/python/training/saver.py", line 1106, in build
self._build(self._filename, build_save=True, build_restore=True)
File "/home/wiproec4/anaconda3/envs/attsets/lib/python3.6/site-packages/tensorflow/python/training/saver.py", line 1143, in _build
build_save=build_save, build_restore=build_restore)
File "/home/wiproec4/anaconda3/envs/attsets/lib/python3.6/site-packages/tensorflow/python/training/saver.py", line 787, in _build_internal
restore_sequentially, reshape)
File "/home/wiproec4/anaconda3/envs/attsets/lib/python3.6/site-packages/tensorflow/python/training/saver.py", line 406, in _AddRestoreOps
restore_sequentially)
File "/home/wiproec4/anaconda3/envs/attsets/lib/python3.6/site-packages/tensorflow/python/training/saver.py", line 854, in bulk_restore
return io_ops.restore_v2(filename_tensor, names, slices, dtypes)
File "/home/wiproec4/anaconda3/envs/attsets/lib/python3.6/site-packages/tensorflow/python/ops/gen_io_ops.py", line 1466, in restore_v2
shape_and_slices=shape_and_slices, dtypes=dtypes, name=name)
File "/home/wiproec4/anaconda3/envs/attsets/lib/python3.6/site-packages/tensorflow/python/framework/op_def_library.py", line 787, in _apply_op_helper
op_def=op_def)
File "/home/wiproec4/anaconda3/envs/attsets/lib/python3.6/site-packages/tensorflow/python/util/deprecation.py", line 488, in new_func
return func(*args, **kwargs)
File "/home/wiproec4/anaconda3/envs/attsets/lib/python3.6/site-packages/tensorflow/python/framework/ops.py", line 3272, in create_op
op_def=op_def)
File "/home/wiproec4/anaconda3/envs/attsets/lib/python3.6/site-packages/tensorflow/python/framework/ops.py", line 1768, in init
self._traceback = tf_stack.extract_stack()
NotFoundError (see above for traceback): Restoring from checkpoint failed. This is most likely due to a Variable name or other graph key that is missing from the checkpoint. Please ensure that you have not altered the graph expected based on the checkpoint. Original error:
Key beta1_power_2 not found in checkpoint
[[{{node save/RestoreV2}} = RestoreV2[dtypes=[DT_FLOAT, DT_FLOAT, DT_FLOAT, DT_FLOAT, DT_FLOAT, ..., DT_FLOAT, DT_FLOAT, DT_FLOAT, DT_FLOAT, DT_FLOAT], _device="/job:localhost/replica:0/task:0/device:CPU:0"](_arg_save/Const_0_0, save/RestoreV2/tensor_names, save/RestoreV2/shape_and_slices)]]


Update jsonpath-to-dot version - for array index fix

Also updated readme with travis-ci build target and homepage url in package.json.

This change is

Reviewed 2 of 2 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

Previously, mention-bot wrote…
> By analyzing the blame information on this pull request, we identified @imlucas and @thedug to be potential reviewers

Review status: :shipit: all files reviewed at latest revision, all discussions resolved, all commit checks successful.

Comments from Reviewable

beaut!  published in<EMAIL_ADDRESS>


vmss stop --instance-ids has trouble with multiple-digit IDs

I'm currently running az off pypi(azure-cli==0.1.0b7), and when I do:
az vmss stop --instance-ids "10 14" --resource-group test --name agents

I get:
The provided instanceId 1 is not an active Virtual Machine Scale Set VM instanceId.

Trying to stop instances 3 and 4 works, so I think there's something wrong with argument parsing here.

I haven't debugged (from the description, there is clearly an issue here), but my expectation for invoking the command would be that you do not put quotes around the list of instance ids.

@rcarmo : Did removing quotes work for you?

No. If it had, I wouldn’t have opened the issue in the first place...

I just attempted to reproduce this issue and I believe that this is related to using quotes around the instance ids, because the help text would lead one to believe you should. The following works fine:
az vmss stop --instance-ids 10 11 12 -g {rg} -n {name}
I will issue a PR to update the help text.


Record SCNView?

In the documentation you mention the ability to record a SCNView. How do I implement that?
The examples don't mention it and when I try using a SCNView instead of an ARSCNView or ARSKView I get errors all around.
recorder = RecordAR(ARSceneKit: sceneView)
Does not seem to take SCNView as expected.

Hi,
Please use this initializer instead:
RecordAR(SceneKit: 'insert SCNView here')
Note that if you installed ARVideoKit using the .framework file you won't be able to use the scene kit initializer because the binary file is not longer supported.
Regards,
Ahmed Bekhit

thanks!


Cloud Native Java/Graalvm

Try to build into the standard Docker pattern.  If not, look into adapter the builder so a different tool isn't required.
Example from https://github.com/bcgov/nr-forest-client/pull/396/files
  build-backend:
    name: Backend Image Build
    env:
      COMPONENT: backend
      ZONE: ${{ github.event.number }}
      NAME: ghcr.io/${{ github.repository }}/backend:${{ github.event.number }}
    runs-on: ubuntu-latest
    permissions:
      contents: read
      packages: write
    steps:
      - name: Checkout repository
        uses: actions/checkout@v3

      - uses: graalvm/setup-graalvm@v1
        with:
          version: '22.3.0'
          java-version: '17'
          components: 'native-image'
          github-token: ${{ secrets.GITHUB_TOKEN }}

      - name: Build App
        run: |
          cd backend
          chmod +x ./mvnw
          ./mvnw -Pnative clean spring-boot:build-image \
          -Dspring-boot.build-image.imageName="${{ env.NAME }}" \
          -Doci.revision=${{ github.event.number }} \
          -DskipTests \
          -Dtests.skip=true \
          -Dskip.unit.tests=true \
          -q
      - name: Log in to the Container registry
        uses: docker/login-action@f054a8b539a109f9f41c372932f1ae047eff08c9
        with:
          registry: ghcr.io
          username: ${{ github.actor }}
          password: ${{ secrets.GITHUB_TOKEN }}

      - name: Pushing
        run: docker push ${{ env.NAME }}

Handled in https://github.com/bcgov/quickstart-openshift-backends.


🐛 No horizontal scrollbars for listviews

Describe the bug
There is no scrollbar for horizontal aligned listviews. Therefore views like grids, cannot scroll to horizontally if there is content either left or right.
Ideally there will be a scrollbar on the right and on the bottom attached to the window.
To Reproduce
    return ListView(
      scrollDirection: Axis.vertical,
      children: [
        SizedBox(
          height: 250,
          child: SingleChildScrollView(
            controller: ScrollController(),
            scrollDirection: Axis.horizontal,
            child: Row(
              children: [
                for (var i = 0; i < 20; i++) ...[
                  const Padding(
                    padding: EdgeInsets.all(20.0),
                    child: Text('data'),
                  ),
                ],
              ],
            ),
          ),
        )
      ],
    );
  }

Expected behavior
[X] Right scrollbar
[ ] Scrollbar on bottom
Screenshots

You can add a scrollbar manually by wrapping your ListView into a Scrollbar, and using the same ScrollController for both:
final controller = ScrollController();

Scrollbar(
  controller: controller,
  child: ListView(
    controller: controller,
    ...,
  ),
),

Can this be closed?

Yes :)


Taskbar Hover Actions Gone & Icon Pixelated

OS:
Windows 10 Pro Version 1803 OS build 17134.137
GPMDP Version:
4.6.0
Issue Descriptions:

Taskbar hover actions are no longer available - in the latest release, the hover window no longer contains action buttons allowing the user to quickly pause, go back, or skip.

Icon is pixelated - in the latest release, the icon went from being crisp and clear to pixelated.

Steps to Reproduce:
Install GPMDP version 4.6.0 on OS listed above

Fixed in master, should be released shortly.


subclass: Hook up instance_init()

Add a new wrapper type, InitializingObject, to store the object pointer during instance_init(). Binding crates are expected to define traits and implement them for InitializingObject to expose safe methods. Notably, this is required for gtk_widget_init_template().

Updated.


2.5 Discussion

I haven't had time the last week, so I can't comb through the issues right now. What did 2.5 change? What has been improved? What has been regressed?
I saw that you put in a PR, do you suspect it will land for 2.5 final (since it's a regression)?

What did 2.5 change?

https://github.com/Microsoft/TypeScript/wiki/Roadmap#25-august-2017
https://blogs.msdn.microsoft.com/typescript/2017/08/17/announcing-typescript-2-5-rc/
https://github.com/Microsoft/TypeScript/wiki/What's-new-in-TypeScript#typescript-25

😃

What has been improved? What has been regressed?

I'm gonna be doing a bunch more testing over different versions now that we have a shiny new testing framework courtesy of @TheOtherSamP. So I'll get back on this.

I saw that you put in a PR, do you suspect it will land for 2.5 final (since it's a regression)?

I think my PR for the numerical index issue should be in based on the timing of this RC release -- and I guess further 2.5 releases may add more still. Fingers crossed, got a few more PRs open atm.

Closing, but TS versions are definitely a thing that'll need branches sooner or later, though so far focus has been on getting things to work well on the newest TS. That said, 2.8 is looking good too (conditional types, some new built-in utility types).


Added Light Mode

Resolves #93

Changes:

Added button to change between light/dark mode
Changed the colors of download animation
Changed background colors
Changed box-shadow
Changed Upload/Draw button colors and added Function to switch between them in lightmode

Thank you for the review :)


fix: updated the capx version used

What problem does this PR solve?:
updated the capx version used from sha to released tag of v1.4.0-alpha.2
Which issue(s) this PR fixes:
Fixes # https://d2iq.atlassian.net/browse/D2IQ-100463
How Has This Been Tested?:

make examples.sync

Special notes for your reviewer:

@deepakm-ntnx I've rebased to sign the commit as all commits are required to be signed to merge the PR.


Update README.md

Codecov Report

Merging #62 (36e4027) into master (e99b140) will not change coverage.
The diff coverage is n/a.

:exclamation: Current head 36e4027 differs from pull request most recent head a5cb5b3. Consider uploading reports for the commit a5cb5b3 to get more accurate results

@@            Coverage Diff             @@
##            master       #62    +/-   ##
==========================================
  Coverage   100.00%   100.00%
==========================================
  Files           12        20     +8
  Lines          187       287   +100
==========================================
+ Hits           187       287   +100

Impacted Files
Coverage Δ

...src/utils/formatter/extended_logger_formatter.dart
100.00% <0.00%> (ø)

.../src/utils/formatter/colored_logger_formatter.dart
100.00% <0.00%> (ø)

...logger/lib/src/models/log_details/log_details.dart
100.00% <0.00%> (ø)

...r/lib/src/utils/filter/loglevel_logger_filter.dart
100.00% <0.00%> (ø)

...ker_logger/lib/src/models/log_level/log_level.dart
100.00% <0.00%> (ø)

...ogger/lib/src/settings/talker_logger_settings.dart
100.00% <0.00%> (ø)

...ges/talker_logger/lib/src/utils/console_utils.dart
100.00% <0.00%> (ø)

packages/talker_logger/lib/src/talker_logger.dart
100.00% <0.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Fix all Sphinx doc generation warnings

This fixes all docs Sphinx warnings and turns on the -W flag to sphinx so that the build will fail if any warnings get introduced in the future.
Many of these changes involve transitioning many of the domains from :c: to :cpp:. Note there are still uses for the :c: domain since some directives we use are only supported there, such as our macros. But many functions and enumerations that used to be c are now cpp.

[approve ci autest ubuntu]

[approve ci autest ubuntu]


allow disableRipple on mat-menu-item buttons

Bug, feature request, or proposal:
bug/feature
What is the expected behavior?
ability to disableRipple on mat-menu-item
What is the current behavior?
Ripples no matter what
What are the steps to reproduce?
Is it just me or are all the plunker's for material broken atm?
What is the use-case or motivation for changing an existing behavior?
Slowly migrating existing UI styling to Material styling, or maybe i just don't like the ripple?
Which versions of Angular, Material, OS, TypeScript, browsers are affected?
angular 4.4.6
material 2.0.0-beta12
Is there anything else we should know?

Try stackblitz.com: https://stackblitz.com/edit/dialog-issue


[Question] Shouldn't this work in 4.26?

So this works in 4.24 as described in the project file here:
https://github.com/rfsheffer/QuestHands/blob/01e40ef99072e95a99889879b3c919e4f29a101d/QuestHandsExample.uproject#L3
But it doesn't appear to work in 4.26?
According to semversion shouldn't 4.26 be backwards compatible with 4.24? What's happening here?

It should work but maybe shouldn't be used because 4.26 has the official hand tracking plugin from oculus included. Is there a reason this plugin would be better to use over the official plugin?


[MINOR] Only rename SparkR tar.gz if names mismatch

What changes were proposed in this pull request?
For release builds the R_PACKAGE_VERSION and VERSION are the same (e.g., 2.1.0). Thus cp throws an error which causes the build to fail.
How was this patch tested?
Manually by executing the following script
set -o pipefail
set -e
set -x

touch a

R_PACKAGE_VERSION=2.1.0
VERSION=2.1.0

if [ "$R_PACKAGE_VERSION" != "$VERSION" ]; then
  cp a a
fi

cc @rxin

Test build #70220 has started for PR 16299 at commit fcc8265.

can we mv instead?
https://github.com/apache/spark/pull/16249/files#diff-ba2c046d92a1d2b5b417788bfb5cb5f8R232

I found an issue with snapshot build just now - R CMD check doesn't handle the -SNAPSHOT part of the file name in SparkR_*tar.gz. Since it's only an issue with SNAPSHOT build I'll open a PR separately.

Ah I see - yes - using mv is a simpler option - BTW when do we run R CMD check ? Is this for say when users download the tar.gz and run it ? (We can move this discussion to the JIRA)

Test build #70222 has started for PR 16299 at commit 95ac227.

Merging in master/branch-2.1.

Test build #70220 has finished for PR 16299 at commit fcc8265.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/70220/
Test PASSed.

Test build #70222 has finished for PR 16299 at commit 95ac227.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/70222/
Test PASSed.


Punycode Deprecated Error, a Future Major Version of Node.js the Module Will Be Removed

Expected Behavior
Should not receive a punycode deprecation warning for running clasp push or other clasp commands that rely on punycode.
Actual Behavior
When running clasp push or other clasp commands that rely on punycode, the following deprecation error occurs:
(node:79914) [DEP0040] DeprecationWarning: The `punycode` module is deprecated. Please use a userland alternative instead.
(Use `node --trace-deprecation ...` to show where the warning was created)

This issue can be resolved by using the userland-provided Punycode.js instead,  per the Node.js v22.9.0 documentation. Steps to resolve the issue are detailed in the provided documentation.
Steps to Reproduce the Problem

Run clasp push or other clasp commands that rely on punycode
Results in the following error:

(node:79914) [DEP0040] DeprecationWarning: The `punycode` module is deprecated. Please use a userland alternative instead.
(Use `node --trace-deprecation ...` to show where the warning was created)

Specifications

Node version (node -v): 22.9.0
Version (clasp -v): 2.4.2
OS (Mac/Linux/Windows): Mac

As far as I can tell, this is due to gaxios, one of clasp's dependencies. Luckily, there's a pull request in the works and it looks like it could be merging soon! 🎉
https://github.com/googleapis/gaxios/pull/617

The pull request have been merged, but the deprecation error still persists. Am I missing something?

@m3n94 I'm not positive what all needs to happen, but afaik we have to wait for that version of gaxios to get released (it's currently v6.7.1, and this change is going to be included in the upcoming v7.0.0). Then that change has to trickle through the various packages that clasp is dependent on (directly or indirectly).
For those that understand npm and versioning better, please jump in and clarify where I may be off.

@andyconlin I believe you are correct, PR #657 of gaxios does show that we are waiting for the v7.0.0 to release. I am not entirely aware of what is using gaxios in clasp. It could either be a clasp dependency or a nested dependency for something else in clasp's other dependencies. We would need those to also use v7.0.0 as well if it does include a fix for punycode's deprecation.
However, are we confident v7.0.0 includes the punycode fix as issue #640 says it is closed as a not planned issue. I did a quick scan of the v7.0.0 release notes and saw no relevant references to it. The package.json also has no inclusion of the punycode package that is required to resolve this issue. Am I missing something?

@mattjmoran It looks like clasp v2.4.2 doesn't have a direct dependency on gaxios, but the dependency is there via google-auth-library (possibly others). However, the current (unreleased/unversioned?) package.json for clasp does list gaxios as a dependency. Like you said, we might be waiting for gaxios v7.0.0 to trickle through updates on several other packages.
Iirc, gaxios v7.0.0 fixes the punycode error because of something to do with dropping support for older versions of node where punycode was. It doesn't directly address punycode, but the fix is a side effect of other changes they made.  ...I think
This is all coming from my attempts to understand these systems, so I could be totally off 😆


Route helper generate url with domain instead of APP_URL

Laravel Version: 6.6
PHP Version:7.3
Database Driver & Version: mysql 7.26

Description:
I wrote the issue here https://github.com/laravel/nova-issues/issues/2194
They said it is more a Laravel issue than a nova issue.
Any solution to that ?
Cordially

We've done some investigation into this. Please check https://github.com/laravel/nova-issues/issues/2194#issuecomment-561209398