nixos/nomad: enforce specific data_dir semantics

Motivation for this change
This PR enforces the semantics discussed here: https://github.com/NixOS/nixpkgs/pull/105739#discussion_r557689413
In summary, the data_dir value of the nomad service must be set to
a specific value if dropPrivileges is set to true.
The updated unit also includes additional documentation describing
the responsibilities of the nomad cluster manager given these
constraints as well as a suggestion for how to go about satisfying them.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

@aanderse Is this okay to merge?

@aanderse Is this okay to merge?

Roger that! Thanks.

Roger that! Thanks.


UI for managing DAO token features (transferable, stakeable, burnable, etc)

Overview
Currently the only meaning that DAOs have is the possibility of voting in a ballot created specifically for that community. However, in order to vote it is necessary to have a positive balance of its token, but by default, they are not transferable. This prohibits the users to be able to vote and that renders the entire DAO system useless.
We need to provide a solution to the DAO manager to change the whole token configuration.
Acceptance criteria
The token creator must be able to access the list of available features for a DAO token and change them. That list includes the following features: transferable, burnable, reclaimable, stakeable, unstakeable, maxmutable
Tasks

[ ] create a component for encapsulating the checkbox list to enable/disable token features
[ ] adapt the current Create-DAO dialog to include the new component and include the token feature settings in the DAO creation process.
[ ] once created the DAO, it should show a button to popup a dialog with a form containing the new component to change token features.

Fixed and merged, so I close this issue


Implement clear appointment command and fix a bug in parsing command

Previously list -aaaaa behaved in the same way as list -a, which was not intended
Now list -aaaaa will be treated as an invalid command, this also applies to commands related to other components

Codecov Report

Merging #84 (6f631e6) into master (f6e2dde) will decrease coverage by 0.08%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##             master      #84      +/-   ##
============================================
- Coverage     37.55%   37.46%   -0.09%
  Complexity      479      479
============================================
  Files           161      162       +1
  Lines          3049     3056       +7
  Branches        354      355       +1
============================================
  Hits           1145     1145
- Misses         1853     1859       +6
- Partials         51       52       +1

Impacted Files
Coverage Δ

...ddress/logic/commands/ClearAppointmentCommand.java
0.00% <0.00%> (ø)

.../seedu/address/logic/parser/AddressBookParser.java
39.39% <0.00%> (-1.88%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6e2dde...6f631e6. Read the comment docs.


[FEATURE REQ] Configration consistency with spring cloud stream

[We use spring cloud stream abstraction in our codebase and the relevant binders gets decided based on build/deployment. Binders we use - activemq, kafka, rabbit and recently started using azure-service-bus binders.
We noticed some differences wrt properties key (some missing) that been used. For example

Max concurrent messages client should process (introduced new servicebus layer and changed the name for concurrency and prefetch)
ActiveMQ binder:

spring:
  cloud:
    stream:
      bindings:
        renderChannelMessage:
          consumer:
            concurrency: 10
            prefetch: 1000

ASB binder:
spring:
  cloud:
    stream:
      servicebus:
        bindings:
      	  renderChannelMessage:
      	    consumer:
      		  max-concurrent-calls: 10
      		  prefetch-count: 1000

Retry mechanism configuration is completely different and there are 2 types- Exponential, Fixed
ActiveMQ binder:

spring:
  cloud:
    stream:
      default:
        consumer:
          backOffInitialInterval: 10000
          backOffMaxInterval: 40000
          backOffMultiplier: 2.0

ASB binder:
spring:
  cloud:
    azure:
      retry:
        mode: exponential
        exponential:
          max-retries: 5
          base-delay: PT2S
          max-delay: PT60S

Global configuration for consumer is not found for ASB (needs more investigation) which includes concurrency and prefetch
ActiveMQ binder:

spring:
  cloud:
    stream:
      default:
        consumer:
          concurrency: 10
          prefetch: 1000

ASB binder:
N/A

Group configuration is still under investigation in how to make it work because not clear how this work for ASB
ActiveMQ binder:

spring:
  cloud:
    stream:
      bindings:
        renderChannelMessage:
          group: ceo-group

ASB binder:
spring:
  cloud:
    stream:
      bindings:
        renderChannelMessage:
          group: <uuid-id-generated-dynamically-for-each-env>

NOTE: the 4th issue is really a struggle as we have to get the ID and then update the relevant services with it. Redo the same if its incase of re-creation of topics.
Describe the solution you'd like
I would like a consistent naming convention with Spring. Dealing with properties while using azure-binders can be a bit of a struggle due to the differences in property names. Switching among other binders is easy since the same property keys work for all, but if the deployment uses azure-service-binders, one has to find the equivalent properties.
Additional context
We understand that there are two similar services like eventhubs and servicebus that require different keys. However, the last part of the key, such as concurrency vs max-concurrent-calls or prefetch vs prefetch-count, could be made similar. Spring allows two properties to be mapped to the same key without the need to change the existing key.
Also, for values like in spring.cloud.stream.bindings.renderChannelMessage.group, friendly names should be allowed, which get automatically mapped.
Information Checklist
Kindly make sure that you have added all the following information above and checkoff the required fields otherwise we will treat the issuer as an incomplete report

[x] Description Added
[x] Expected solution specified

Hi @dhananjay12
Thank you for reporting this issue. We have received your submission and will take it into consideration. We appreciate your input and will review this matter as soon as possible.
Please feel free to provide any additional information or context that you think may be helpful. We'll keep you updated on the progress of our review.
Thank you for your contribution to improving our project.

I think this should be treated as a bug in the Spring Cloud Azure Stream Binder to fix, @dhananjay12 could you elaborate more on the 4th? How does this group act in your application?

Hi @saragluna
For the 4th item , we are not facing this with the latest version of the binder, so it can be marked as resolved.
For rest of them which involves consistancy with the spring cloud stream names, its docs can be reffered from here - https://docs.spring.io/spring-cloud-stream/docs/current/reference/html/spring-cloud-stream.html#spring-cloud-stream-reference
May be map 2 configuration to the same class variable to maintain backwar compatibility?


mpirun training can't return

Hi, @yjxiong
When I use mpirun -np 2 to run the training with 2 GPUs, the program can't return. It stopped at Optimization Done like this ( I set the number of iteration to 20 for convenience ),

I1221 22:17:14.922746 24063 solver.cpp:631] Iteration 0, lr = 0.001
I1221 22:17:56.933382 24063 solver.cpp:502] Snapshotting to models/hmdb51_split_1_tsn_rgb_bn_inception_iter_20.caffemodel
I1221 22:17:57.243152 24063 solver.cpp:510] Snapshotting solver state to models/hmdb51_split_1_tsn_rgb_bn_inception_iter_20.solverstate
I1221 22:17:57.486786 24063 solver.cpp:406] Iteration 20, loss = 3.53084
I1221 22:17:57.486837 24063 solver.cpp:411] Optimization Done.
I1221 22:17:57.486843 24063 caffe.cpp:187] Optimization Done.

and never return to system. The training had been done, so i suspect it is the mpirun couldn't return. Then i run with --mca mpi_common_cuda_verbose 100  for additional information, and i get this at the end,

I1221 22:47:31.502188 27430 solver.cpp:406] Iteration 20, loss = 3.50854
I1221 22:47:31.502244 27430 solver.cpp:411] Optimization Done.
I1221 22:47:31.502249 27430 caffe.cpp:187] Optimization Done.
[UBUNTUB:27430] CUDA: mca_common_cuda_fini, never completed initialization so skipping fini, ref_count is now 2
[UBUNTUB:27431] CUDA: mca_common_cuda_fini, never completed initialization so skipping fini, ref_count is now 2
[UBUNTUB:27430] CUDA: mca_common_cuda_fini, never completed initialization so skipping fini, ref_count is now 1
[UBUNTUB:27431] CUDA: mca_common_cuda_fini, never completed initialization so skipping fini, ref_count is now 1
[UBUNTUB:27430] CUDA: mca_common_cuda_fini, never completed initialization so skipping fini, ref_count is now 0
[UBUNTUB:27431] CUDA: mca_common_cuda_fini, never completed initialization so skipping fini, ref_count is now 0

which i don't understand. And I have tried launching the training without mpirun ( i.e run caffe train --slover=... directly with one GPU ), the program returns normally,

I1221 22:55:10.266736 28827 solver.cpp:510] Snapshotting solver state to models/hmdb51_split_1_tsn_rgb_bn_inception_iter_20.solverstate
I1221 22:55:10.510454 28827 solver.cpp:406] Iteration 20, loss = 3.61723
I1221 22:55:10.510510 28827 solver.cpp:411] Optimization Done.
I1221 22:55:10.510516 28827 caffe.cpp:187] Optimization Done.
Setting device 0
cenjiepeng@UBUNTUB:~/temporal-segment-networks$

I run it on Ubuntu 16.04 + CUDA 8.0 + OpenMPI 1.8.8 and I have tried OpenMPI 1.8.7 and 1.10.2, but it didn't work. Have you ever encouter this problem?

On some machine, it is possible to observe this. However, once you see  Optimization Done, it is fine to use CTRL+C to close the program.

Thank you, @yjxiong.
Could you tell me the reason causing it?  And does it any way to fix this? As it brings some bother if the program couldn't be closed automatically.

We currently don't have a fix because this rarely happens on our machines. You are welcome to contribute a fix to this issue.

Thanks for your help. I will have a try.

You can just kill the process. Find all the process ids and then kill them.


1820 can map interrupt

can.Map.interrupt plugin. Provides the ability to interrupt setting or removing the properties of a can.Map by wrapping them in a can.transaction. Will also supplant the batch functionality in setState for can.route to allow a route to be interrupted on set or remove.

I'm closing this PR since we will extract it into a separate plugin as discussed.


Merit data export is imbalanced when the load of a power plant reaches its maximum

One of our clients pointed out that the merit data export is imbalanced when the load of a power plant (energy_power_combined_cycle_hydrogen in this case) reaches its maximum. I tried to reproduce it in this scenario and indeed ran into the same bug:

Here's the underlying analysis:
merit_order.753299.xlsx
@antw, would you have any idea what's going on here?
Notifying @ChaelKruip

I don't have a copy of Excel available, and while the spreadsheet seems to load in Numbers it replaces some formulas with their previously-calculated value. I can see what the formulas should be, but my Excel-fu isn't good enough to decipher them. :wink:
=SUMIF($E$1:$EP$1,_xlfn.CONCAT("*",A$1),$E442:$EP442)

I'm guessing .input is the sum of all inputs, and .output is the sum of all outputs?

when the load of a power plant (energy_power_combined_cycle_hydrogen in this case) reaches its maximum.

By this, do you mean the bug is triggered when load of a dispatchable plant equals its capacity? The bug isn't there so long as the load remains lower than the capacity?

I'm guessing .input is the sum of all inputs, and .output is the sum of all outputs?

Indeed!

By this, do you mean the bug is triggered when load of a dispatchable plant equals its capacity?

Yes!

The bug isn't there so long as the load remains lower than the capacity?

That's what I'm guessing. When I touch some sliders to make sure there's less demand -- for instance, by increasing the insulation slider values -- and the loads of the dispatchable plant remain below its max capacity, the merit data export seems to balance just fine.
I'm guessing the

Good news: this isn't a bug! 😅
There are two hours where input and output are mismatched:

Time
Demand
Production
Deficit

2050-01-19 18:00 (450)
37289.7550
36835.6551
454.0999

2050-01-19 19:00 (451)
37271.7460
36835.6551
436.0909

2 mismatches
This exactly matches the dashboard_blackout_hours query: the mismatches are due to insufficient production capacity in the scenario. We don't represent deficits in the merit order, and so they also don't appear in the merit order CSV.

We don't represent deficits in the merit order, and so they also don't appear in the merit order CSV

This might be confusing for some users (as we have seen). Is there an elegant way to include deficits as a participant and have them show up in the data-dumps?

Is there an elegant way to include deficits as a participant

It can surely be done, but I think not elegantly.

Mismatched supply and demand are used to calculate blackout hours and loss of load. A "deficit producer" would mean supply always meets demand.
Merit relies on not having a producer-of-last-resort when setting the electricity price for those hours where there are deficits.

Solving these would mean having to special-case the deficit producer, and requires that we always remember that the producer must be treated differently when writing merit order related code in the future.
We could add a hard-coded column to the merit CSVs (electricity and heat network) which has the different between all inputs and outputs.

Thanks for your clarification @antw. That explains!

Solving these would mean having to special-case the deficit producer, and requires that we always remember that the producer must be treated differently when writing merit order related code in the future.

That sounds like a suboptimal solution of which I wouldn't be in favour.

We could instead add a hard-coded column to the merit CSVs (electricity and heat network), which has the different between all inputs and outputs.

I guess that could be a solution? In addition, we could also add an extra line of explanation on this in the paragraphs on the heat and electricity curves in the front-end?

I guess that could be a solution? In addition, we could also add an extra line of explanation on this in the paragraphs on the heat and electricity curves in the front-end?

I'm in favour of those two things :)

I've renamed and reopened this issue again. I can add an extra line to the front-end. @antw, would be nice if you could add the extra hard-coded column to the data exports.


Update waf-sentinel.md

changed microsoft web application to Azure web application (service is called Azure and you won't find it by Microsoft *)

Note that publishing in this repository is suspended until Tuesday, November 2. Merging will resume Tuesday morning. Authors can still review and sign off on PRs in the interim. Thanks.

Change connector name to "Azure Web Application Firewall" accurately reflects what Sentinel shows. #sign-off


Create pull request template

Guidelines

[X] I agree to follow this project's Contributing Guidelines.

Is there an existing issue for this?

[X] I have searched the existing issues

Dependencies
No response
Overview
We need a pull request template that can be filled out with useful information so that when PRs are submitted, reviewers can know what is being added.
Action Items

[ ] Determine what information needs to go in the template
[ ] Find other templates and figure out how to implement them in our project
[ ] Create template

[ ] Within template, include examples so that people can see what a good PR looks like

Anything else?
No response

@SyntheticNerd has a PR template they've used in the past so we are going to give this a try!


Lighting feature not working (F7 key)

I see a lot of others are having issues with the lighting overlay enabled by the F7 key, I'm having that issue as well. I'm using Forge for Minecraft 1.16.3 version 34.0.9 and using More Overlays Updated version 1.18.8 (the Alpha version for Minecraft 1.16.3). The only other mods I am currently using are AppleSkin (shows hunger saturation and what saturation food gives you), VoxelMap, OptiFine, and OptiForge. The F9 function to see chunk borders still works fine though. I even tried rebinding the key from F7 to a key that was unused, no luck. I know Alpha means that it is still in early testing phases, so I understand. Please let me know if there is anything I can do to help (though I have no knowledge of coding).

Can confirm, not working on 1.16.3 Forge version 34.1.14

I'm not able to replicate this issue. There was another person who had problems with the mod for 1.16.3 and I tried using the exact same mods, same mod versions, same forge version, same Minecraft version and even the same java version as him, but I was not able te replicate the problem.
I also tried it on 2 different PC's with a clean Minecraft and Forge installation but still no success. Are you also having the same problem on 1.16.2? Because the only things that's different between the mc1.16.2 version of the mod and the mc1.16.3 version are the dependencies.
Here are also 2 test versions that may fix the problem so please try them:
moreoverlays-1.18.9 Test Versions-mc1.16.3.zip
If I can't replicate the problem, it's almost impossible for me to fix it.

Problem went away when using the modfile moreoverlays-1.18.9_PREVIEW_1-mc1.16.3.jar
It now shows the lightlevel overlay again.

That's great! Fixed an issue without even being able to replicate the issue, that doesn't happen everyday. I've uploaded the file to CurseForge: https://www.curseforge.com/minecraft/mc-mods/more-overlays-updated/files/3079188. @Subratrix Please reopen this issue if you're still having this problem.

I'm having the same issue. I'm using 1.18.9 (the version that supposedly fixed it) and Forge 34.1.35, and the light level overlay doesn't work while connected to a server, but chunk borders work just fine. The behaviour is the same whether or not I'm using any other mods
It also doesn't seem matter whether it's a vanilla server or not. If it's a server, it doesn't work. If it's single-player, it works fine

It also doesn't seem matter whether it's a vanilla server or not. If it's a server, it doesn't work. If it's single-player, it works fine

For me, the light level overlay doesn't work in singleplayer either.

It also doesn't seem matter whether it's a vanilla server or not. If it's a server, it doesn't work. If it's single-player, it works fine

For me, the light level overlay doesn't work in singleplayer either :/

I'm able to replicate the problem and trying to fix it. It's a really strange issue. I'll keep you guys notified about the progress.

Just released a new version with bugfixes: https://www.curseforge.com/minecraft/mc-mods/more-overlays-updated/files/3099374 It should work again on servers.

1.18.10 works perfectly for me

1.18.10 works great for me as well! Thank you so much!


Maps without names aren't unloaded from the form into a proto

If an input has no name, or if an automation code or analysis has no name, then they will be silently excluded from the message. We should have a way of checking this. When a new map field is created, should we automatically populate the name field like we do with the sidebar?

I can't reproduce this on my branch; the input/analysis shows up in the proto without a "key" field and seems to reload just fine.

I can't figure out what example led me to observe this either anymore. Will reopen if I find one, but the code looks right


Adds support for namespaced events and endingElement to event object

This allows the user to use the tocca config to namespace events to avoid collisions with future native DOM implementations of swipe, etc.
Additionally, this includes event info regarding the endingElement of the touch event

thank you for PR but I have decided to not merge the features provided by your patch. Feel free to fork the project if you need and if my suggestions above do not work in your case. 🙏

thank you for PR but I have decided to not merge the features provided by your patch. Feel free to fork the project if you need and if my suggestions above do not work in your case. 🙏

Sure thing.  I'll probably create a fork and add some stuff to it.  Obviously I will keep your copyright notice in the source.  Thank you for making this boss library!

Hey Dude.  So I made a CustomEvent version of your library.  I have some added info in the touch events.  Would love to know what you think.
https://www.npmjs.com/package/tocada


Privileges spelled wrong

When you click on a driver from the home page, the table that lists it's use cases spells the word privileges incorrectly

super embarrassed, thank you sharing! Just pushed a change to main: https://github.com/magicsword-io/LOLDrivers/commit/9e885057c4f8a2b938b7415d1c8a3b748ba46f39


HAWKULAR-194 - Added support for consuming Keycloak events

Please, do not merge this. As reviewed by @jmazzitelli  on IRC, the modules should be pulled as ZIP from accounts, so, this module shouldn't worry about building the modules itself.

@jmazzitelli , could you please review it again?


Bash

Typically not the right tool for the job.

Nearly two years later…
Thank you for this amazing implementation :) I think it’s the shortest one!

Better late than never :)
Thank you for taking the time to review it!


Docs: workflow working mechanism

Signed-off-by: Yin Da<EMAIL_ADDRESS>Add docs for introducing workflow working mechanism, including

Mode
Backoff
State Keep

/cc @FogDong @wonderflow

@wonderflow @FogDong BTW, I add the workflow related time configurations in the bootstrap parameter document now.


Switched spatial viewer cadastre to use LGATE-001.

Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from the review on Reviewable.io


0-Row Sprites

I was using DXY0 as a simple method to create a single frame of delay, but Octo assumes this is the Super Chip instruction, which draws a 16 pixel sprite instead.

After extensive consideration, I've decided to avoid creating a new feature flag for this. Drawing a 1-pixel tall blank sprite with the vblank flag enabled will achieve your desired effect provided you can find a zero byte anywhere in your program, which should be trivial to arrange.

@JohnEarnest Note that this behavior is (as far as I can gather) unique to Octo, which means that games written with Octo as a target platform that use DXY0 to draw a 16x16 sprite in low-resolution mode will not work in anything but Octo. (Your own "Eaty the Alien" comes to mind.)
Considering the number of games out there that use DXY0 as a delay routine is probably zero (at least now that 12Me21 has been dissuaded from doing it), that in itself might not be a reason to add a feature/quirks flag to Octo, but in fact the CHIP-8 interpreter for the DREAM 6800 computer used DXY0 to draw an 8x16 sprite.
So there are three different low-resolution behaviors of DXY0 that I know of: 8x16 sprite drawing (DREAM 6800), 16x16 sprite drawing (Octo) and no-op with a "vblank delay" (most/all other implementations),

@tobiasvl the compromise I came up with was to make it so that the linter warns of using 16x16 sprites in low-res mode:
https://github.com/JohnEarnest/Octo/blob/gh-pages/js/debugger.js#L210-L212
Thus, authors are assisted in writing portable programs if they wish to do so.


Server

So, there is a security problem - storing passwords in file in plain text. But ignoring it for now


Optimizing the README.md readability

Hi @therealdhruv ,
The current Readme seems fine as it is. If you have specific suggestions or concerns, please let me know, and we can discuss further. Thanks!


protobufVersions: init, add protobuf_22

Description of changes
Replace our existing callPackage + continuation logic to a formal package set for protobuf versions.
Main benefit is remove of the two callPackage calls.
noticed protobuf_22 was missing, so I decided to add it.
closes: #272151
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[x] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

This shouldn't change the build for any of the existing packages.

We don't want to collect all possible protobuf versions.

@SuperSandro2000 This PR fixes a bug (linked from the PR description). The fact that it adds a missing protobuf version is not the main point of the PR and it should not be closed simply because you disagree on the value of that one addition.


NSISOLatin1StringEncoding in AFURLResponseSerialization

What did you do?
I've upgraded the AFNetworking version in my app from 2.7.0 version to 4.0.1. Everything works fine, but I'm having some issues with the serialize process of some JSON responses.
I've been doing some tests and this is what I have seen:

All my WS JSON responses has the ISO-8859-1 encoding.
The ones with special characters in some JSON fields are giving me the following error:

Error Domain=NSCocoaErrorDomain Code=3840 "Unable to convert data to string around character 1483." UserInfo={NSDebugDescription=Unable to convert data to string around character 1483.}

This same URLs were just working fine with the 2.7.0 version of the library.

I know this is a serialization problem and that the NSJSONSerialization class doesn't support the ISO-8859-1 encoding, but I have added the following two lines to the AFJSONResponseSerializer class and it has worked:
NSString *iso = [[NSString alloc] initWithData:data encoding:NSISOLatin1StringEncoding];
NSData *dutf8 = [iso dataUsingEncoding:NSUTF8StringEncoding];

Is there any chance to add this two lines to the AFJSONResponseSerializer class (I know there are several methods to do the serialization process) so the URLs with special characters in the JSON response won't fail?
Thanks in advance.
AFNetworking Environment
AFNetworking version: 4.0.1
Xcode version: 11.5
Platform(s) running AFNetworking: iOS
macOS version running Xcode: Catalina 10.15.5

No, we will not be reencoding all of the data that flows through AFNetworking. Creating a custom serializer to do the transcoding for you is the appropriate solution, especially since anything but UTF-8 is against the JSON standard.


SNOW-1432694 Add documentation pages for Index object

Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

Fixes SNOW-1432694

Fill out the following pre-review checklist:

[ ] I am adding a new automated test(s) to verify correctness of my new code

[ ] If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing

[ ] I am adding new logging messages
[ ] I am adding a new telemetry message
[ ] I am adding new credentials
[ ] I am adding a new dependency
[ ] If this is a new feature/behavior, I'm adding the Local Testing parity changes.

Please describe how your code solves the related issue.
Adding one page with a list of the Index APIs (indexing.rst) and one page with a table of the APIs supported/not supported. (index_supported.rst)
This should be merged after the NotImplementedError PR for Index since all Index APIs are listed here.

Are you able to build without warnings? After deleting pandas_api and running make clean + make html, I get these warnings:
WARNING: [autosummary] failed to import snowflake.snowpark.modin.pandas.Index.T.
Possible hints:
* ImportError:
* ModuleNotFoundError: No module named 'snowflake.snowpark.modin.pandas.Index'
* AttributeError: type object 'Index' has no attribute 'T'
WARNING: [autosummary] failed to import snowflake.snowpark.modin.pandas.Index.all.
Possible hints:
* ImportError:
* AttributeError: type object 'Index' has no attribute 'all'
* ModuleNotFoundError: No module named 'snowflake.snowpark.modin.pandas.Index'

(repeated many times for other methods)
checking consistency... /Users/joshi/code/snowpandas/docs/source/modin/supported/index_supported.rst: WARNING: document isn't included in any toctree

/Users/joshi/code/snowpandas/src/snowflake/snowpark/modin/plugin/_internal/index.py:docstring of snowflake.snowpark.modin.plugin._internal.index.Index:7: WARNING: undefined label: basics.dtypes

@sfc-gh-joshi It will keep on raising the build errors until my other PR is in (raising NotImplementedError for all APIs not present). It's raising the errors because these APIs don't exist in the code.


Virus alert while installing

I'm sure Microsoft antivirus alert is a false positive, but I though it was anyway important to report this. While installing, Microsoft AV flagged as sever threat both
.\CentOS7\rootfs\usr\bin\dbus-daemon

and
.\CentOS7\rootfs\usr\bin\systemctl

as affected by Trojan:Win64/Longage.
Thanks

Did it resolve?
I use Windows Defender, but I haven't found any false positives.

See also the CentOS forum although a different rpm, mostly a false positive ('coz it's the dbus-demon and systemctl, eh!?) and should've been removed by Microsoft during definition update.
.
いつもお世話いただいて、感謝の気持ちでいっぱいです。 <(_ _)>

Same here, CentOS7.exe blocked and labeled 'Insight Network Threat' by Norton

Same here, blocked and labeled 'Network Threat' by Norton

exe?

Yep

I tested with VirusTotal, I found that some engines detected it as malware.
Executable files with icon resources were found to be easily detected as malware.

I don't have Norton.
I would be grateful if you could help report a false positive.
https://support.norton.com/sp/en/us/home/current/solutions/kb20100222230832EN
I`ll report false positives of some AV vendors whenever possible.

I don't have Norton.
I would be grateful if you could help report a false positive.
https://support.norton.com/sp/en/us/home/current/solutions/kb20100222230832EN
I'll report false positives of some AV vendors whenever possible.

Done that


fix-45503: update trial copy issues

Details

This PR updates the logic that shows the subscription ended text if there is a card already added.
Fixed Issues

$ https://github.com/Expensify/App/issues/45503
PROPOSAL: https://github.com/Expensify/App/issues/45503#issuecomment-2231555576
Tests

Create a new account and a new workspace.
Open the subscription settings and execute the following in console.

Onyx.merge('fundList', {
    'fundA': {
        methodID: 1,
        key: 'fundA',
        accountData: {
            cardMonth: 11,

            cardNumber: '1234',

            cardYear: 2026,

            currency: 'USD',

            addressName: 'John Doe',

            additionalData: {
                isBillingCard: true,
            }
        },
        isDefault: true,
    },
});

Onyx.merge('nvp_expensify_billingFundID', 1);

Refresh the page and verify that add a payment card copy does not appear as a subtitle in the subscription settings.
Execute the following code in the console, replacing the day with the current day.

        Onyx.merge('nvp_private_lastDayFreeTrial', '2024-07-17 01:06:39');

Refresh the page, and verify that the x days remaining in the banner do not show up. Instead, it should show the next payment date.

[x] Verify that no errors appear in the JS console

Offline tests

Same as above.
QA Steps

Same as above.

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

https://github.com/user-attachments/assets/78be69bd-ac67-4200-a9ef-e4c59721a9cf
https://github.com/user-attachments/assets/2b2b147a-f390-4199-befb-78c513ed2e8b

iOS: Native

iOS: mWeb Safari

https://github.com/user-attachments/assets/7f557c1b-2b9d-4cd6-914f-9c1d17c37093
https://github.com/user-attachments/assets/347a79c4-70fe-48a1-a06a-9f43751496ae

MacOS: Chrome / Safari

https://github.com/user-attachments/assets/b808badd-099a-423f-9ee6-30c186112038
https://github.com/user-attachments/assets/dc2bc3af-2381-4225-84a7-5155e0277f40

MacOS: Desktop

https://github.com/user-attachments/assets/cbbc4d97-75ca-4860-b6ce-7a48a5838974

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/chiragsalian in version: 9.0.9-1 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.0.9-2 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

🚀 Deployed to production by https://github.com/mountiny in version: 9.0.10-7 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅


Clay v1 Pipeline Spec

This is a proposal for a streaming approach that relies on static STAC Indexes and dynamic tiling.
tl;dr

List imagery "scenes" using STAC items
Compute how many chips are in each scene
Download batches of "scenes" to a fast temporary storage
Do dynamic tiling for feeding to the model

Tracking scenes
The first step is creating a list of scenes from multiple sources, like Modis, Landsat, Sentinel-2, Naip, Drones. Separately, one by one.

For each scene create a static STAC item with asset links to scalable storage (S3), ideally in same region
Each STAC item metadata should contain the following information

Reference date
Central wavelength of each band
Bandwidth of each band
Resolution in meters of each band
lat/lon bounding box
Data normalization average
Data normalization mean

Track chips in each scene
Track how many chips are in each scene

For each STAC item, we precompute how many “chips” can be created using simple window reads. That means no reprojection or spatial lookup, simply cutting the pixels into chips of 256x256 pixels
With this count we can index all the chips and their “parent” STAC items

The index table
We would then store all the static STAC item as json in files in a central location and index all the chips into a single table.

Stac Item

Chip ID

sentinel-2-2023-01-23-FQ23.json

1

sentinel-2-2023-01-23-FQ23.json

2

sentinel-2-2023-01-23-FQ23.json

3

…

…

naip-ma-2020-m-41071327.json

1301

naip-ma-2020-m-4107132.json

1302

naip-ma-2020-m-4107132.json

1303

…

openaerialmap-65ec6c0deda0.json

2521

openaerialmap-65ec6c0deda0.json

2522

…

…

The pipeline would then do random sampling into batches in two steps:

Creating a Mega Batch by random sampling at the STAC item level

This needs to be a big number, so that the random sample at the STAC item level would be representative of the whole globe as much as possible.
Each STAC item is like a single scene ,and we know what “chips” we can make from them from the index
We would expect a few thousand STAC items to be a good number.

Create a Mini Batch to pass to the model using a full random shuffle of all the “chips” in the index from all the sampled STAC items.

The Mini Batch would be sampled from the items in the Mega Batch
Each Mini Batch will be a few hundred chips, depending on the GPU memory we have available

Considerations:

The Mega Batch needs to be big enough to have a diverse sample because we would run through each chip in the Mega Batch before moving on to the next one
The number of STAC Items in each Mega Batch is a function of the size of the Mini Batch.

In each Mini Batch we don’t want to repeat the “parent” STAC Item of the chips
We also don’t want each Mini Batch within a Mega Batch to be from the very same STAC Items. So the Mega Batch size should be at least 5 to 10 times as many items as the number of chips of the MiniBatch.

Data Flow

Our pipeline would then take all the static STAC items, and the index file with all the chips as input.
It would then populate a temporary storage with the first Mega Batch. That means downloading all the assets for all the items in the Mega Batch.
It would then dynamically create Mini Batches from all the chips in the Mega Batch and feed these to the model from the fast temporary storage
Meanwhile, the next Mega Batch would be prepared.
When the first Mega Batch has been passed to the model, the next will be used and the first will be removed from the temporary storage

Considerations

We would expect the temporary storage to be in the range of 1TB to 3 TB in size. It would get all the assets for all the items in each Mega Batch, a few thousand “scenes”
With this approach, we would re-download all the source data in each Epoch.

Love this idea. I believe this also restricts us to use COG data on S3 (for speed and window reads) but that's an ok cost to bear imo. We should just make sure we can fall back always to static pre-made batches (important to keep that functionality for finetunning and users who want to continue training potentially offline).

For 1.i I see the need to not bias a batch, but I don't think it's too concerning, specially when we do batch accumulation, right? We can document that to ensure we accumulate batches.
Do we actually need a megabatch? Why not just weight random call STAC items and from them random chips? (we random weight by the number of chips on the STAC item, and we keep track of the ones we used, to not repeat them.)
Why not streaming the creation of the batches with a queue? If we use several workers on an scalable queue, we can keep pumping batches as they are needed without having to pre-process.
Totally fine to re-download on each epoch, our training data becomes ephemeral. We just need to create logs, maybe even dump the MD5 hashes alongside the STAC source, to ensure complete provenance.

Thanks for the feecback @brunosan
The fallback would be to run this pipeline but store all tiles permanently. That should be fine for smaller datasets, but then maybe this mechanism is overkill and the user is better off to simply create chips on their own scripts. But in any case, the proposed mechanism could be used to permanently store chips as well.

We will be doing training aross instances so not sure how much batch accumulation will solve for bias
Yes because of the speed we consume the data. The network overhead of chipping directly from S3 is huge (99% of time). So preloading the scenes into a fast storage is probably crucial)
Most definitively we will need many workers to create chips and queuing would happen through the Mega Batch level, and implicicilty by the data loader.
Yes exactly, chips become ephmeral, they would become defined through the STAC catalogs and the pipeline spec. That makes this very scalable in terms of total data, but has a cost on network and processing time.

@yellowcap Thanks for doing this write up 🚀 , I think it is a good summary of some of the discussions we had.  I'll try to carve out some time this week to add tickets for

Options to support automated transfer of data for a batch to fast, temporary storage.
Testing and benchmarking a tiffile based Dataloder that might be more efficient in these cases where no spatial reference information or transforms are needed.

A few questions/comments about the approach you've described.  On the STAC side

For the required STAC metadata I'd suggest including the projection extension.  Many published items already support this and the proj:shape field would provide an easy mechanism to calculate chipping without accessing the COG's header directly.

Generally, most assets/bands in a STAC Item have the same shape, but this is not a requirement.  You'll likely want to handle this case in your chip generation.

Would a batch consist of Item's only from a single sensor or a mix of sensors?  If the batch is composed of multiple sensors, how will the Dataloder handle mixed asset/band options?  Will it need sensor specific information to determine which assets to combine into a chip?

On the index table side, for optimized performance, we may wish to consider in-lining all of the relevant STAC Item information into columns in a Parquet dataset/files (with the assets dictionary stored in a serialized column) to avoid having to load and parse a very large JSON index file.  This may only be valuable when our index size grows to > 1M rows.
On the temporary data loading side, the depth of my Pytorch knowledge is fairly limited, but we will also need to include hooks within the training loop to publish an external notification when a batch is completed so that our infrastructure can remove the assets associated with that batch from fast temporary storage.
We will likely also need some mechanism to "peek" at the next batch for the Dataloader's iterator so that it can be preloaded to disk.  (This would achieve our temporary storage "streaming" goals and allow us to use our fast disk capacity efficiently).
Hopefully once I get a bit more understanding on the Pytorch side I can provide some more concrete ideas on this 😄

In a very timely post, @jhamman. et al at Earthmover seem to have managed to stream Zarr data directly to the GPU. https://earthmover.io/blog/cloud-native-dataloader/
GH code https://github.com/earth-mover/dataloader-demo

Here is a proposal for where to get / store the metadata fields from v1 in STAC. Everything except the normalization parameters is either native STAC or from the eo and raster extensions.

Property
STAC Item Reference
Extension

Bounding box
box
-

Date
properties:datetime
-

Ground Sampling Distance
raster:bands:spatial_resolution
raster

Wavelength
eo:bands:center_wavelength
eo

Bandwidth
eo:bands:full_width_half_max
eo

Normalization Average
properties:normalization_average
custom

Normalization Standard Deviation
properties:normalization_standard_deviation
custom

@yellowcap I'm writing up a slightly modified version of this approach based on the recent demonstration from the EarthMover team https://github.com/earth-mover/dataloader-demo.  I hadn't even considered Dask's in-memory opportunistic caching as a fast intermediate store for pre-fetched chips to maintain high GPU saturation but this is actually very well aligned with our requirements.
One question which will drive the partitioning/row group structure of our chip index parquet file and how we perform sampling for shuffling is what level of reproducibility we need for batches?
With the approach we'll use Dask Dataframe's sample. We have some options for ensuring that our batch partitioning and shuffling is fully reproducible but I'll need to consider this in our pipeline architecture.  Do we need fully reproducible batch generation in this case?

Hmm not 100% sure here. I it depends on how we distribute batches across GPU nodes. Maybe we need to reproduce the sample in each node and then select from that, or the sample is created centrally and then pushed to the nodes. In this case reproducibility is less important. But not sure about this, maybe @srmsoumya knows more...

Another issue that I remembered now for the optical spaceborn sensors are clouds ☁ . When indexing, we should ideally limit cloud cover at the chip level. For v0.1 and v0.2 we are limiting chip level cloud cover to 30%, and we pre-select mostly cloud free scenes already.
This makes the indexing more complicated, as we have to actually inspect the data at indexing time.

I have been working more on the v1 pipeline, realizing that we will need cloud and nodata tracking at the chip level. I played around with creating classes where the platform specific cloud and nodata filters can be added through class method overrides.
the current code is in the PR linked above. But here are the the specific pointers
https://github.com/Clay-foundation/model/blob/clay-v1-pipeline/scripts/pipeline_v1/chip_indexer.py
script to try them out with the data attached below is
https://github.com/Clay-foundation/model/blob/clay-v1-pipeline/scripts/pipeline_v1/run_chip_indexer.py
test_stac_items.zip
The latests idea is to make copies of scenes that we want to use in a single bucket that can be hooked directly into FSx. Storing 100TB permanently would cost about 14k per month, which is still acceptable given the credits we have.
If we put the scene files, the STAC items, and a central index in a bucket, then FSx can sync that stuff and we can expose it to our training nodes.
The data loader could then do dynamic chipping from the scenes based on the index. This should be quite fast.
If we move with this approach now we gain time to do the "megabatch" part where we handle batches of scenes.  I feel like if we do dynamic chipping and indexing on of the chips, that should integrate well with a more batched streaming approach. What do you think @sharkinsspatial

Splitting the indexing and chipping functionality into a separate repo, as this can be done quite univerally I think.
https://github.com/Clay-foundation/stacchip

Got a first full version for the new v1 pipeline for Sentinel-2. This will

Download items from the earth-search api (least cloudy per quarter for 3 years)
Copy all assets from a whitelist to our own S3 bucket
Update the stac item with the new hrefs
Upload the edited stac item
Create a chip index (using stacchip )
Upload index to S3

If we let this run through all 2500 MGRS tiles we have previously sampled we should have all the S2 data we want for v1. We can test this at scale this week and then replicated for other sources!
Results from the a single MGRS tile and one date are here
https://github.com/Clay-foundation/stacchip/blob/main/scripts/sentinel-2-processor.py

Ok this is ready for a first serious test drive tomorrow. The index file is written properly to geoparquet and both the STAC item and the assets are created as desired. I'll push this to Batch tomorrow, if things go smoothly we will produce
2500 MGRS tiles for 3 years with 4 seasons each. I.e. 30'000 Sentinel-2 scenes. That should be a good start!
Screenshot from visualization of the geoparquet index using lonboard

Closing this as we have moved forward as documented in https://clay-foundation.github.io/model/data_sampling.html


🔎 Search bar yay! 🔎

This code is bugged - if you hover datalist inside the sidebar it closes the sidebar. Im pretty sure this is the issue of ActiveZone as the datalist is portalled somewhere else in the dom.
After like an hour of trying I concede defeat as the syntax of the activezone stuff is so cryptic that I simply cannot figure this out XD

Ofc we'll have to change this once the algolia like search is in place


LaTeX formatting

Hi, I'm newbie in emacs and struggling with using AucTeX LaTeX-fill-buffer formatter instead of latexindent. Do you have any idea to use it? Thanks in advance!

Done. You can now select an auctex formatter in latex-mode buffers.

Perfect! Would you mind correcting me to change default LaTeX formatter?
(setq format-all-default-formatters '(("LaTeX" auctex)))

It's probably easiest to change it from M-x customize-group format-all.


Animation instance doesn't have the right subset name when created with Template Builder

In GitLab by @support-bot on Mar 9, 2023, 16:07

the subset is call feadingPump_rigMain_01_

and should be call feadingPump_animationMain_01

Softwares concerned
Maya, Fix

Merge request
https://github.com/ynput/OpenPype/pull/4877

@mre7a

Merge request ynput#4877

I thought bigroy solved this in another PR?

I don't think so, do you have the link of the PR ?
His suggestion in the comments is useful, but does not solve our problem.
I have just asked him why there are no answers.

If you want to test it, I added some documentation here:
https://openpype.io/docs/admin_hosts_maya#templated-build-workfile


add rows limit to query settings

with default 10000 and allowed range 1..100000
parameter name is "limit_rows"

range is not quite supported from-the-box by our components
not sure if it will be good idea to spend much time to implement it for now


[Question] Why does MixinExtras 0.2.0 for fabric platform requires fabric loader >=0.14.11

MixinExtras declares dependency on fabric loader >=0.14.11, but I don't see any actual code dependency on fabric loader >=0.14.11
https://github.com/LlamaLad7/MixinExtras/blob/b26d42127aee5eca65204238a0a729b0f022cd65/platform/fabric/src/main/resources/fabric.mod.json#L19-L21
The reason why I can't just update my fabric loader is, I have some fabric client setups in mc1.15 and below, that cannot work with fabric loader >=0.12.0. I'm also maintaining some mods for those mc versions. If MixinExtras requires fabric loader >=0.14.11, then I cannot use MixinExtras 0.2.0 for my mods while still support those client setups
If it's not necessary, I'll suggest to remove this dependency, just like the MixinExtras 0.1.1 that depends on nothing

It requires this fix. The latest version of fabric loader should work on every mc version, what specific issues are you encountering?

Also you don't have to use the fabric specific artifact, you can still shade and relocate it as explained in the "other platforms" section.

The latest version of fabric loader should work on every mc version

the fabric loader itself works, but some mods don't

Also you don't have to use the fabric specific artifact, you can still shade and relocate it as explained in the "other platforms" section.

I thought I have to follow the fabric guide in the readme xd
Can I simply apply loom's include on mixinextras-common and invoke MixinExtrasBootstrap.init() in my onw, just like what we do for MixinExtras 0.1.1? cuz using include much easier than using shadow

No, you cannot. The generated modid will be wrong.

Using mixinextras on <0.14.11 without shading it is kind of not a supported use case at all since you can't initialize it from a mixin plugin without triggering the crash, and if you do it from preLaunch then mixin inheritance won't work properly with its injectors. I sort of assumed everyone would be off those versions by now.

Yes.


feat(euler-problem): Add tests and solution for Problem 4: Largest palindrome product

Add tests and solution for Problem 4: Largest palindrome product

Pre-Submission Checklist

[x] Your pull request targets the staging branch of freeCodeCamp.
[x] Branch starts with either fix/, feature/, or translate/ (e.g. fix/signin-issue)
[x] You have only one commit (if not, squash them into one commit).
[ ] All new and existing tests pass the command npm test. Use git commit --amend to amend any fixes.

Type of Change

[ ] Small bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds new functionality)
[ ] Breaking change (fix or feature that would change existing functionality)
[ ] Add new translation (feature adding new translations)

Checklist:

[x] Tested changes locally.
[ ] Closes currently open issue (replace XXXX with an issue no): Closes #XXXX

Description

@AungMyoKyaw This is a nice start. It looks like you got a build error.
Also, could you share a working solution here to make this easier to QA?

@AungMyoKyaw Any luck getting this to pass locally?

Hi @QuincyLarson
When i run test locally,I got the following error message.
Create a Circular Queue

✖ SyntaxError: Octal literals are not allowed in strict mode.
✖ SyntaxError: Octal literals are not allowed in strict mode.

@AungMyoKyaw It looks like Node may be interpreting some of your code as octals. This Stack Overflow answer may be relevant: https://stackoverflow.com/questions/23609042/how-to-avoid-octal-literals-are-not-allowed-in-strict-mode-with-createwritestr
@texas2010 Do you know what might be causing this?

Hi @QuincyLarson ,
All test can pass, if no solution is provided.
Here is my solution.
 "const largestPalindromeProduct = (digit)=>{\n  let start = 1;\n  let end = Number(`1e${digit}`) - 1;\n let palindrome = [];\n  for(let i=start;i<=end;i++){\n    for(let j=start;j<=end;j++){\n      let product = i*j;\n      let palindromeRegex = new RegExp('\\b(\\d)(\\d?)(\\d?).?\\3\\2\\1\\b','gi');\n      palindromeRegex.test(product) && palindrome.push(product);\n    }\n }\n return Math.max(...palindrome);\n}"

Here is more readable version
const largestPalindromeProduct = (digit)=>{
  let start = 1;
  let end = Number(`1e${digit}`) - 1;
  let palindrome = [];
  for(let i=start;i<=end;i++){
    for(let j=start;j<=end;j++){
    	let product = i*j;
    	let palindromeRegex = new RegExp('\\b(\\d)(\\d?)(\\d?).?\\3\\2\\1\\b','gi');
    	palindromeRegex.test(product) && palindrome.push(product);
     }
  }
  return Math.max(...palindrome);
}

I've granted @alvinkl write access to this repo. He has agreed to help QA your pull requests since he knows more about the process of importing and improving these Project Euler challenges than anyone.

@QuincyLarson I am not sure (for my lack of expertise on the topic) what this needs for a QA? Are we able to either merge or close this?

Hi there @AungMyoKyaw. I was asked to take a look at your pull request. I have it running fine here on my local machine, and npm test no longer throws any errors. Seems like the build errors you were getting before were from another problem altogether. Everything with your submission looks good here!
@QuincyLarson, is there a way to trigger another Travis-CI build on your end? Or would it be best for @AungMyoKyaw to close and reopen this pull request? Maybe squash and push an empty commit? I'm not sure what would be best in this case.

@scissorsneedfoodtoo this pull request simply needs a re-base against the current staging.
@AungMyoKyaw you need to
git checkout feat/eluer-prob-4
git pull --rebase upstream staging
git push origin feat/eluer-prob-4

That will re-base the code and trigger the build again.

@raisedadead Thank you! I'll definitely keep that in mind.
@AungMyoKyaw, good luck with the new build.

Hi @QuincyLarson , @raisedadead , @scissorsneedfoodtoo
Sorry for my late reply
I am updating my pull request.

@AungMyoKyaw, no worries! Thank you for updating your pull request.
Sorry the build is still failing. It seems to be a problem with another challenge, possibly Create a Priority Queue Class. I'm looking into it now. Hope we can get this sorted out and merge your pull request soon!


Showing image while offline?

Hi,
I'm having trouble showing the image while offline - seeing blank like the normal  component. Thanks for your work!

I don't think fast-image provide offline caches right ?
Images are not saved to app's document directory, or are they ?

I believe this might already work. I'll confirm though.


🐛Bug: ts-plugin does not resolve exports for remapped imports installed with forge

Relative filepaths work; remapped paths do not
Example repo: https://github.com/emo-eth/minrepro

So is the issue here this?

LSP works
Next.js build does not

If so this is expected and something I should do a better job documenting. I just looked in docs and any documentation on this is very buried and impossible to discover.
TLDR
There are 2 fixes

You can code-gen the typescript before running webpack production build npx tevm-gen . src/Counter.sol
You can turn off typechecking in the next.js config like here

Context
LSP plugins by default only run in your editor and not when command line typescript is running. We have an unreleased way of getitng the command line ts to work (it copies how vue.js works) but this is unreleased at this time.
The first solution of code genning fixes it by adding the ts file for your bundler to resolve which ts will properly see.
The second solution works via turning off typechecking when next.js runs
A better solution will come in future. Will keep issue open until I make a new issue for this

TODO also add a NEXT.js specific guide as it's the only build that typechecks that I'm aware of

Sorry, wrote it quickly (& writing this on my phone), the issue is that the LSP doesn't recognize the contract if it imports from a remapped file, eg:
Module '"../../src/Counter.sol"' has no exported member 'Counter'.ts(2305)
if it imports from "forge-std/console2.log", so red underline and "any" type.
Compilation and bundling etc works fine, just typescript lsp within vscode complains

@emo-eth wasn't able to repro that one both worked fine for me. What editor are you using

Reproduced bug. The tevm cache MUST not exist when the editor is opened to reproduce

Error happening
Info 103  [20:56:38.603] [tevm-ts-plugin] error: @tevm/ts-plugin: getScriptSnapshotDecorator was unable to resolve dts for /Users/williamcory/minrepro/src/Counter.sol

Error happening
Info 101  [20:56:38.603] [tevm-ts-plugin] error: there was an error in tevm plugin resolving .dts
Info 102  [20:56:38.603] [tevm-ts-plugin] error: {
  "_id": "FiberFailure",
  "cause": {
    "_id": "Cause",
    "_tag": "Fail",
    "failure": {
      "_tag": "ReadFileError",
      "name": "ReadFileError"
    }
  }
}
Info 103  [20:56:38.603] [tevm-ts-plugin] error: @tevm/ts-plugin: getScriptSnapshotDecorator was unable to resolve dts for /Users/williamcory/minrepro/src/Counter.sol
Info 104  [20:56:38.603] [tevm-ts-plugin] error: {
  "_id": "FiberFailure",
  "cause": {
    "_id": "Cause",
    "_tag": "Fail",
    "failure": {
      "_tag": "ReadFileError",
      "name": "ReadFileError"
    }
  }
}

Fixed in release 102


Add TRACE to OpenAPI allowed methods during import

Description
In #2117 it was discovered by @nicolasne that the TRACE method caused an issue on import, this is an attempt at adding it to the list of allowed methods.
TRACE is already supported in other OpenAPI Collection locations such as
https://github.com/usebruno/bruno/blob/1e0c88a2916236b73017c2df01a6a85c414d7edf/packages/bruno-app/src/utils/importers/openapi-collection.js#L342-L347
Contribution Checklist:

[x] The pull request only addresses one issue or adds one feature.
[x] The pull request does not introduce any breaking changes
[ ] I have added screenshots or gifs to help explain the change if applicable.
[x] I have read the contribution guidelines. (but unfortunately I had created the branch name before I read the guidelines, hope that is okay)
[x] Create an issue and link to the pull request.

Note: Keeping the PR small and focused helps make it easier to review and merge. If you have multiple changes you want to make, please consider submitting them as separate pull requests.
Publishing to New Package Managers
Please see here for more information.

Merged! Thanks @NiklasBr !


Constrain variable names

Update validation to constrain variable names in schema version 4.

Variable names are constrained by the nmtoken rules
Option values are constrained by the nmtoken rules
Entity names are constrained by the nmtoken rules
Migration for v4 of the schema has been added
Helper function for getting the migration notes (which are a new feature)

Resolves https://github.com/codaco/protocol-validation/issues/38

Once the above is resolved, feel free to merge the protocol validation branch and update the ref here.
We then need a corresponding PR in NC, which will need to mark protocol versions prior to 4 as obsolete rather than outdated.

It occurred to me that external data already loaded won't be updated or invalidated by the migration. I don't think there is much of anything we can do it about, but I wanted to note it here in case you can think of anything.

On this, if there are no better ideas, can we add an additional bullet point to the migration notes:

NOTE: If you are using external network data, you must ensure that you update your column headings manually to ensure that they meet the same requirements regarding variable names outlined above. See our documentation on variable naming.

The link in the note above is just going to a blank page for now.

We discussed linking to the documentation in the migration dialog, but I didn't see this implemented. I added a link to the dialog, but it doesn't work. I suspect it needs some electron special sauce, but I didn't want to make that change myself. Can you look at it?

I had thought this would go in the notes, since it's markdown?

I'm not sure about this, I'd intentionally left out commas since I was concerned it might be confusing (is comma one of the characters?) - I know that it's obvious to us.

It occurred to me that external data already loaded won't be updated or invalidated by the migration. I don't think there is much of anything we can do it about, but I wanted to note it here in case you can think of anything.

We could check that within NC, it isn't something that's handled by this submodule at the moment - but could potentially port some of the code from Architect.

We could check that within NC, it isn't something that's handled by this submodule at the moment - but could potentially port some of the code from Architect.

I've extracted the relevant code here so that it can be referenced in NC


Cannot fetch LUIS apps

Version
4.3.0
Describe the bug
When trying to add a LUIS app to a bot file in Bot Emulator it cannot find
To Reproduce
Steps to reproduce the behavior:
0. Set up some LUIS apps in West Europe (https://eu.luis.ai)

Click '+' next to 'Services'
Select LUIS
Log in to Azure if asked
Emulator tries to fetch LUIS apps
Emulator shows partially filled dialog saying it could not find anything

Expected behavior
LUIS apps linked to my account are found
Screenshots

[bug]

I am able to repro this. The root cause is that the luis authoring keys are not shared across regions. The Emulator will have to match the region with the authoring key for that region in order to pull data.

Great :+1:

Thank you for the quiclass resolution

Is this available in a prerelease?


Add client support for SSL certificates

Purpose
This PR adds support for specifying client certificates, private keys, and CA certificates to each check and metric script.
Known Compatablity Issues
None that I know of.

Hi,
Is there any chance someone could build a new release of the code so we can use 'sensu-install' to get all the latest changes please?

Yes, will cut a new release soon.

1.1.0 is live on rubygems.


Animation for avaritia singularities don't work

Everything is in title.

See also #40

Oh sorry I hadn't seen it since it was closed. I suppose it has been fixed and I should close this issue.

I'm not quite certain that this issue was fixed, though.

It isn't fixed

I have explained this particular issue to @Runemoro adding that animation of the white noise in the background of the Pile of Neutrons item etc. is broken by VanillaFix as well.
I wonder what animation shenanigans Morpheus might be doing that clash so badly with VF. :smile:

Fixed


New public ( No auth ) partner, organization api to fetch very basic infrormation

Briefly describe the feature

Add new organization and partner basic information api which will be non-restricted and public
Only organization, partner id and name information will be fetched
Will be used in dashboard to load before user login
Impact to CLI to be checked
Remove the existing mandatory permissions validation for organization / partner
Skip only kubectl related permissions from authz.

What problem does this feature solve? Please link any relevant documentation or Issues

It removes the dependency for all custom roles to have organization, partner read only permissions. Thus enabling creating custom roles with just hand-picked api permissions depending on the use case.

(optional) What is your current workaround?

Currently, while creating custom roles organization, partner read permissions are made mandatory so that users / systems can use those custom roles

@niravparikh05 Exposing an API publicly without authentication will raise security concerns. Let's reassess this ticket since it is been a while you created it.

Deprioritizing and closing this.


Bug- Code Folding

When I try to use the #region keyword and the #endregion the code folds properly, when building it won't build producing an invalid character build-fail error at the line of #region.
Note:
_It was working fine but suddenly it stopped, I tried enabling and disabling the code folding but it didn't solve the issue_
Thank You

Hi Ahmed,
In Masm i use the folding keywords in a remark, for example ";#region". Not sure why it used to work but stopped working, maybe the code has redefined the remark character.
Let me know if this helps.

Hello H,
Yes it's working fine now, thanks.
I maybe have missed the remark.
Is it possible to completely uninstall and reinstall the tool again, I'm experiencing an error on startup here is  a part of the activity log:

System.InvalidOperationException: The calling thread must be STA, because many UI components require this.
   at System.Windows.Input.InputManager..ctor()
   at System.Windows.Input.InputManager.GetCurrentInputManagerImpl()
   at ....

I'm currently experiencing connection problems so I'm unable to attach the activity log right now but the main problems are linked with the CodeFoldingTagger.cs at line 148 and CodeFoldingTagger.cs line 144
I guess this error produced when I tried changing the folding settings, is it possible to reset them?
Thank You.

@Ahmed-YehiaGPEL, I've tried to solve the threading issue you mentioned above, but I can't reproduce it. Were there any specific circumstances, such as, 100k lines in the folding region, 10 levels deep folding regions, a system under very heavy load, less than 4k of free memory, etc. Have you experienced this more than once?
Regards HJ!

@HJLebbink, No there weren't any special circumstances that would produce the bug, I've just turned of and on the folding ability and changed some settings in the ASM Dude configuration that has no relation to the code folding.
But the file contained lots of code folding, it was about 800 Lines of code, but the folding didn't exceed 100 lines.
Thank you,
A.Y


Login to quay.io before push

@jacobweinstock I'm hacking the CI, but can't merge without approval :(


BUG: Wrong swap qoutes on MAYA

Maya qoutes are mispriced by a decimal. please verify and fix.

additionally when switching to other routes afterwards, the quotes do not update.


read_hdf opens the store in rw mode by default.

Currently the HDFStore in read_hdf is opened in rw mode by default, leading to permission
errors when reading a non-writeable file.
This patch changes the default mode to r.

This seems like a big change since any code like
store = pd.HDFStore('my_store.h5')
store.put(df,'key')
store.close()

will now not work.  The default is a I believe (append).

I updated the description, this doesn't actually change the behaviour on HDFStore but just on read_hdf.

I see - seems reasonable to read in 'r'.

Is it possible to test this change?
Either way, this needs a release note for "what's new".

Create a hdf file and change it to read only using os.chmod.  The use read_hdf...it should pass now and would have failed before.
On Feb 25, 2015 3:06 PM, Stephan Hoyer<EMAIL_ADDRESS>wrote:
Is it possible to test this change?
Either way, this needs a release note for "what's new".
—
Reply to this email directly or view it on GitHubhttps://github.com/pydata/pandas/pull/9551#issuecomment-76044621.

the default mode is 'a', which is the PyTables default, and IMHO the most correct thing to do. It doesn't actually write the file if you don't do any write operations so its safe for read-only systems as well.
You can write a test to validate, but since the mode is determined by .open() I believe it is already correct.
this was a bug, but fixed in 0.13: https://github.com/pydata/pandas/pull/4513

Hmm, indeed it works locally, but if the h5 file to be opened is on a network share it fails with a permission error (that's where this appeared). I'll try to verify it, but it's going to be difficult to test this ...

Indeed, when I deny the Write permission in Windows' security settings I can not read anymore with mode="a" but it works with mode="r".

It sounds like it is a platform-specific bug, but it also looks innocuous to open 'r' in read_hdf since the store is immediately closed.

@filmor I don't think this is going to be possible as the default is append (and makes more sense)

What? For *read*_hdf append is more sensible than read? I disagree.
Just to make this clear, this PR does not change the default on HDFStore, nor does it change how read_hdf works if you pass in a store directly.

Please reconsider, the patch is trivial, doesn't break anything because behaviour doesn't change and this issue is causing real problems in our systems, as people are not regularly allowed to change the shared HDF5 files. I hate to sprinkle mode='r' all over the place, in particular as read_hdf(f, mode='r') just sounds broken ...

you can simply use a function internal to what you do. Even if I agreed that this should be changed, this would take a month or more to make it to the next release, then you would have to update, etc.
def read_hdf(fname, key, mode=None, **kwargs):
    if mode is None:
         mode = 'r'
    return pd.read_read(fname, key, mode=mode, **kwargs)


Kairos release v1.1.6

🗺 What's left for release

[x] #320
[x] #333
[x]  #334
[x] #337
[x] #348
[x] #354
[x] #266  (x86_64)
[x] #358
[x] https://github.com/kairos-io/kairos/pull/381
[x] https://github.com/kairos-io/kairos/issues/306

🔦 Highlights
Minor release (fixup)
✅ Release Checklist

[x] Stage 0 - Finishing Touches

[x] Check kairos/packages, and for any needed update
[x] Make sure CI tests are passing.

[x] Stage 1 - Infrastructure Testing

How: Using the testing version, make sure that manual and k8s upgrades are working from the latest release, and that docs are still aligned
Where:

[x] Two kairos nodes

[x] Deploy latest release with automatic node setup
[x] Upgrade to testing release
[x] Analyze

[x] Create deployments
[x] Keep cluster running overnight
[x] Run upgrades and verify workload is still running
[x] Keep cluster running overnight

[x] Stage 3 - Release

[x] Tag the release on master.

[x] Stage 4 - Update kairos-provider
[x] Make required changes to the release process.

We have a high-prio follow up: #383 as currently images aren't released cause of it. We might have to revisit how we release bigger assets


Surface the underlying Azure StorageException errors due to concurrency

We created a new BotStorageException class meant to surface the underlying Azure StorageException errors due to concurrency while writing large objects. This is an edge case scenario which we won't address in the Bot Builder but we want to guide the devs into the root cause of the problem.
Error message in this scenario is: "An error ocurred while trying to write an object. The underlying 'InvalidBlockList' error is commonly caused due to concurrently uploading an object larger than 128MB in size."

@JuanAr I see some build errors, likley due to this:
Error 1:
2018-05-14T20:32:05.2133989Z Failed   BlobStorage_BatchCreateObjectsTest
2018-05-14T20:32:05.2134202Z Error Message:
2018-05-14T20:32:05.2134528Z  Assert.IsInstanceOfType failed.  Expected type:<Microsoft.Bot.Builder.Core.Extensions.BotStorageException>. Actual type:<Microsoft.WindowsAzure.Storage.StorageException>.
2018-05-14T20:32:05.2134829Z Stack Trace:
2018-05-14T20:32:05.2135153Z    at Microsoft.Bot.Builder.Core.Extensions.Tests.StorageBaseTests.<_batchCreateObjectTest>d__7.MoveNext() in D:\a\1\s\tests\Microsoft.Bot.Builder.Core.Extensions.Tests\StorageBaseTests.cs:line 233
2018-05-14T20:32:05.2135586Z --- End of stack trace from previous location where exception was thrown ---
2018-05-14T20:32:05.2135880Z    at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
2018-05-14T20:32:05.2212330Z    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
2018-05-14T20:32:05.2213181Z    at Microsoft.Bot.Builder.Azure.Tests.BlobStorageTests.<BlobStorage_BatchCreateObjectsTest>d__22.MoveNext() in D:\a\1\s\tests\Microsoft.Bot.Builder.Azure.Tests\BlobStorageTests.cs:line 138
2018-05-14T20:32:05.2238669Z --- End of stack trace from previous location where exception was thrown ---
2018-05-14T20:32:05.2239213Z    at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
2018-05-14T20:32:05.2239576Z    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
2018-05-14T20:32:05.2239852Z


Source maps in different location when compiling

This issue was originally filed by<EMAIL_ADDRESS>
What steps will clearly show the issue / need for enhancement?

When using a script/library that dynamically generates unique file names there's no option to have the source map be put in another location.

What is the current output?
Source map appears in the same location.
What would you like to see instead?
A flag to be able to change the file name and location of the source map file.
What version of the product are you using? On what operating system?
Ubuntu 14.10. Dart 1.8.3
Please provide any additional information below.
I'm using a third party library that compiles dynamically generated files. These files aren't accessible to the web directly, so I'd like extend the library to leave the source map elsewhere. However, I can't do that as easily as if there was a way I could change the file name and path to the source map when compiling with dart2js. Then developers would be able to debug with ease according to their own web configuration.

I'm just cleaning up some old source-map related bugs and run across this one. Today the name of the sourcemap file is derived from the output file name you specify in the command line. I'm guessing that should address your needs? If not, feel free to reopen/clarify.


finch compose stumbles on restart: on-failure instruction in docker-compose.yml.

Describe the bug
When restart: on-failure instruction is present docket-compose.yml file finch compose up command throws an error.
Use docker-compose.yml file from https://github.com/madduci/docker-compiler-explorer.
Steps to reproduce
A clear, step-by-step set of instructions to reproduce the bug.
finch version: 0.0.2
% cat docker-compose.yml
version: "3"

services:
  compiler-explorer:
    build:
      context: ./
      dockerfile: Dockerfile
    image: madduci/docker-compiler-explorer:latest
    restart: on-failure
    container_name: compiler-explorer
    ports:
      - 10240:10240
    networks:
      - ce_network
    stop_grace_period: 1m30s

networks:
  ce_network:

Debug log
% finch compose up --file docker-compose.yml
INFO[0000] Creating network compose_ce_network
INFO[0000] Creating network compose_default
WARN[0000] build.config should be relative path, got "/Users/siravara/vishwas-tests/compose"
INFO[0000] Ensuring image madduci/docker-compiler-explorer:latest
INFO[0000] Creating container compiler-explorer
FATA[0000] error while creating container compiler-explorer: exit status 1
FATA[0000] exit status 1
siravara@bcd074105a94 compose % finch compose up --debug  --file docker-compose.yml
DEBU[0000] Creating limactl command: ARGUMENTS: [shell finch nerdctl compose up --file docker-compose.yml], LIMA_HOME: /Applications/Finch/lima/data
WARN[0000] build.config should be relative path, got "/Users/siravara/vishwas-tests/compose"
INFO[0000] Ensuring image madduci/docker-compiler-explorer:latest
INFO[0000] Creating container compiler-explorer
FATA[0000] error while creating container compiler-explorer: exit status 1
FATA[0000] exit status 1

Expected behavior
Description of what you expected to happen.
compose up should not throw any error.
Screenshots or logs
If applicable, add screenshots or logs to help explain your problem.
Additional context
Add any other context about the problem here.
Get the same error while running nerdctl compose up .

restart: on-failure is supported in containerd v1.7.0. Prior to v0.6.0, Finch was using containerd 1.6.9 which did not support restart: on-failure. Finch v0.6.0 uses containerd v1.7.0. It should work now. I have verified in my local machine with same yml file you provided and it works fine with Finch v0.6.0.


Update wildfly-discovery to 1.0.0.Beta7

Seems included in https://github.com/wildfly/wildfly-core/pull/2159


Tcsh support

Cecile H reported problems running jupyter forward, and @andersy005 tracked it down to a few bash commands that we were executing on the remote machine (she uses tcsh by default). We were able to get her running with some kludgy updates, but this PR cleans everything up.
Testing: I created a VM where my default shell was tcsh, and verified that I could not use jupyter-forward out of the box. After the following commits I was able to use jupyter-forward to get to my virtual machine, and could still use it to connect to machines where my default shell is bash.
Fixes #66

Note that I left the --shell command line argument because it is used with --launch-command but it is no longer part of self.run_kwargs


ignore .swiftpm/ folder

When opening the FloatingPanel package, this folder is created.
This folder contains what can be considered the SwiftPM version of "Xcode derived data" folder, therefore I suggest it to be ignored.

Thanks!


Add: tapenade package

I was pleasantly surprised to see this previously closed-source commercially-licensed tool is now open source under MIT!
IMO, this tool is the state of the art in automatic differentiation for Fortran. It has a long history and is hence quite robust.
See also the discussion on discourse.
(It doesn't have gitlab stars because it's a self-hosted instance of gitlab I think.)

Great, I have been attending a series of workshops on the topic recently, It has great potential.

Great, I have been attending a series of workshops on the topic recently, It has great potential.

Were those the NAG workshops? Are there any publicly available materials also for non-participants?

Yes, the NAG workshops - I think the material is for participants only. but
the workshops themselves were free. You could contact them about it.
Regards,
Arjen
Op ma 26 okt. 2020 om 22:15 schreef Ivan<EMAIL_ADDRESS>
Great, I have been attending a series of workshops on the topic recently,
It has great potential.
Were those the NAG workshops? Are there any publicly available materials
also for non-participants?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/fortran-lang/fortran-lang.org/pull/159#issuecomment-716827775,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAN6YR245DJZJLYFYKUHAE3SMXRGFANCNFSM4S7DARMQ
.

This looks good, I will go ahead and merge. Thanks @LKedward!


Implement codeql

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 38.027%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
424

Relevant Lines:
1115

💛  - Coveralls

@emmakenny can you please copy the same we have in https://github.com/k8snetworkplumbingwg/sriov-network-device-plugin/blob/master/.github/workflows/codeql.yml
so we are consistent in all the sriov projects?

PR #254 addresses same topic, closing this one

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 38.027%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
424

Relevant Lines:
1115

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 38.027%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
424

Relevant Lines:
1115

💛  - Coveralls


Allow kwargs in dask predict

Codecov Report

Merging #6117 into master will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #6117   +/-   ##
=======================================
  Coverage   78.52%   78.52%
=======================================
  Files          12       12
  Lines        3069     3069
=======================================
  Hits         2410     2410
  Misses        659      659

Impacted Files
Coverage Δ

python-package/xgboost/dask.py
78.95% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08bdb2e...a12cef1. Read the comment docs.

I think requiring explicit kwargs is safer as inputs can't be unintentionally used for the wrong argument.


feat(nfs): test connection

If we lose NFS connection after setting up backup-target and then we try to initialize NFS BackupStoreDriver again in another program, the program may be stuck in MkdirAll or List. So I use util.Execute to avoid being stuck in mkdir command.
Issue: https://github.com/harvester/harvester/issues/2631

@shuo-wu The PR tries to let the call fail fast if NFS server is offline. If NFS server is off, The first os.MkdirAll call could stuck because it stats mount point first.

For the port checking, maybe we could try to use rpcinfo command?
Another question is that even if the listening ports are what we want, we may still hang on the MkdirAll or List.
Should we need to another checking for target mountpoint? (Like check export by showmount or do some operations like stat on target mountpoint with timeout)

Hi @Vicente-Cheng and @derekbit, thanks for your reviews and suggestions. I am thinking how about using util.Execute, so we don't need to check connection and we can avoid hanging on the MkdirAll. WDYT? Thank you.

Hi @Vicente-Cheng and @derekbit, thanks for your reviews and suggestions. I am thinking about using util.Execute for Mkdirall, so we don't need to check connection and we can avoid hanging on the MkdirAll. WDYT? Thank you.

Sounds good. :)

Hi @Vicente-Cheng and @derekbit, thanks for your reviews and suggestions. I am thinking about using util.Execute for Mkdirall, so we don't need to check connection and we can avoid hanging on the MkdirAll. WDYT? Thank you.

Sure, sounds good with a timeout!

@derekbit Could you help update the dependency of manager, instance manager, and engine? Thanks.

Sure thing!