HUGE FPS SPIKES increasing exponentially after playing for 20 mins or so

Mod Version:
<IP_ADDRESS>
The version that is installed in your pack.
Forge Version:
35.1.28
The actual Forge version - "latest" does not count.
Link to client log:
https://pastebin.com/fYdPNhg1
My fps starts to freeze after about 20 mins of playing, at it increases from there the lag spikes until it becomes unplayable with spike occuring every 0,5 seconds.

Don't think this is DS.  I play Direwolf20 and things are fine.  What is your memory looking like?  F3 in the top right corner.  Usually if there are lag spikes its because of Java garbage collection, and you can see when they occur if the amount of used memory gets near the max threshold.

Don't think this is DS.  I play Direwolf20 and things are fine.  What is your memory looking like?  F3 in the top right corner.  Usually if there are lag spikes its because of Java garbage collection, and you can see when they occur if the amount of used memory gets near the max threshold.

Have the same problem with Forge 35.1.36 on ATM6 modpack.
FPS freeze when all allocated memories ends.
Memory consumes increase with any movement when DynSur is active.
I just open F3 screen and walk\jump - every sound from this movements increase memory consumption by 1%
So after 1-2 minutes of play - it consumes 100% allocated memories and game freeze to 0-1 fps,
I try to allocate up to 25 gb, it doesn't matter - every step increase consumption dramatically
Without DynSur - all works fine

Have the same problem with Forge 35.1.36 on ATM6 modpack.
FPS freeze when all allocated memories ends.
Memory consumes increase with any movement when DynSur is active.
I just open F3 screen and walk\jump - every sound from this movements increase memory consumption by 1%
So after 1-2 minutes of play - it consumes 100% allocated memories and game freeze to 0-1 fps,
I try to allocate up to 25 gb, it doesn't matter - every step increase consumption dramatically
Without DynSur - all works fine

What other mods have you added to the pack besides DS?  Also, what are your java startup parameters?

What other mods have you added to the pack besides DS?  Also, what are your java startup parameters?

What other mods have you added to the pack besides DS? Also, what are your java startup parameters?
https://github.com/AllTheMods/ATM-6/issues/871

Seems like after deactivate DS issue still here, also sound of jumping totally disappear without DS. Here is the issue on ATM6 github with full logs include list of mods

What other mods have you added to the pack besides DS? Also, what are your java startup parameters?
https://github.com/AllTheMods/ATM-6/issues/871

Seems like after deactivate DS issue still here, also sound of jumping totally disappear without DS. Here is the issue on ATM6 github with full logs include list of mods

Which version of OptiFine?  It is having teething issues with 1.16.4 and you should be on the most current (which I believe is G6).

Which version of OptiFine?  It is having teething issues with 1.16.4 and you should be on the most current (which I believe is G6).

Last version of Optifine, G6

Last version of Optifine, G6

pre12 before release version G6 is released - has same issue

pre12 before release version G6 is released - has same issue

Can you try with out OptiFine?

Can you try with out OptiFine?

I loaded up ATM 6, dropped my mod in, and started a new world.  Standing in a village wandering around - no lag spikes.  I have 8GB allocated to the instance.  I do not have any special Java parameters defined.  I am using OpenJDK <IP_ADDRESS> hotspot.

I loaded up ATM 6, dropped my mod in, and started a new world.  Standing in a village wandering around - no lag spikes.  I have 8GB allocated to the instance.  I do not have any special Java parameters defined.  I am using OpenJDK <IP_ADDRESS> hotspot.

Have you had a chance to try without OptiFine?

Have you had a chance to try without OptiFine?

Well I try without optifine too - nothing changes.
But now, after al I tried I think it's not DynSur fault. Mostly this happens in my base of previous world, so probably it's some blocks that interact with sounds. And I don't know what this block are...
Probably mekanism, that have many problem with sound in previous version of Minecraft (a round 1.12.2 have similar issue with dynsur and mekanism). But after all this time they change code and look like it fixed.
Any sound-muffing block I placed I try to delete, try to delete all another mods that do something with sound - nothing changes.
Now I just start new world, and don't have much more now. If problem happens again when I start creating machine-ore processing - I tell about it and try to figure out what machine/block do this

Well I try without optifine too - nothing changes.
But now, after al I tried I think it's not DynSur fault. Mostly this happens in my base of previous world, so probably it's some blocks that interact with sounds. And I don't know what this block are...
Probably mekanism, that have many problem with sound in previous version of Minecraft (a round 1.12.2 have similar issue with dynsur and mekanism). But after all this time they change code and look like it fixed.
Any sound-muffing block I placed I try to delete, try to delete all another mods that do something with sound - nothing changes.
Now I just start new world, and don't have much more now. If problem happens again when I start creating machine-ore processing - I tell about it and try to figure out what machine/block do this

That would be great if you can.  If you find a block that does that let me know and I can load up and see if I can isolate the interaction that is causing an issue.  I am currently playing the Direwolf20 1.16.4 pack and using Mekanism machines and I have not encountered any issues.  I am going to leave this issue open.  It's obvious something is going on.  The hard part is figuring it out.

That would be great if you can.  If you find a block that does that let me know and I can load up and see if I can isolate the interaction that is causing an issue.  I am currently playing the Direwolf20 1.16.4 pack and using Mekanism machines and I have not encountered any issues.  I am going to leave this issue open.  It's obvious something is going on.  The hard part is figuring it out.


Bug: Fix objects must not be overlapped in a report.

Describe the bug
When running this command
eslint . --ext .js,.jsx,.ts,.tsx --fix --cache

I get this error

Oops! Something went wrong! :(

ESLint: 8.41.0

AssertionError [ERR_ASSERTION]: Fix objects must not be overlapped in a report.
    at mergeFixes (PROJECT_PATH/node_modules/eslint/lib/linter/report-translator.js:152:9)
    at normalizeFixes (PROJECT_PATH/node_modules/eslint/lib/linter/report-translator.js:182:16)
    at PROJECT_PATH/node_modules/eslint/lib/linter/report-translator.js:349:49
    at Object.report (PROJECT_PATH/node_modules/eslint/lib/linter/linter.js:1021:41)
    at PROJECT_PATH/node_modules/eslint-plugin-perfectionist/dist/index.js:3:217
    at I (PROJECT_PATH/node_modules/eslint-plugin-perfectionist/dist/index.js:1:2481)
    at PROJECT_PATH/node_modules/eslint-plugin-perfectionist/dist/index.js:3:143
    at Array.forEach (<anonymous>)
    at Program:exit (PROJECT_PATH/node_modules/eslint-plugin-perfectionist/dist/index.js:3:131)
    at ruleErrorHandler (PROJECT_PATH/node_modules/eslint/lib/linter/linter.js:1050:28)
    at PROJECT_PATH/node_modules/eslint/lib/linter/safe-emitter.js:45:58
    at Array.forEach (<anonymous>)
    at Object.emit (PROJECT_PATH/node_modules/eslint/lib/linter/safe-emitter.js:45:38)
    at NodeEventGenerator.applySelector (PROJECT_PATH/node_modules/eslint/lib/linter/node-event-generator.js:297:26)
    at NodeEventGenerator.applySelectors (PROJECT_PATH/node_modules/eslint/lib/linter/node-event-generator.js:326:22)
    at NodeEventGenerator.leaveNode (PROJECT_PATH/node_modules/eslint/lib/linter/node-event-generator.js:349:14)
    at CodePathAnalyzer.leaveNode (PROJECT_PATH/node_modules/eslint/lib/linter/code-path-analysis/code-path-analyzer.js:816:23)
    at PROJECT_PATH/node_modules/eslint/lib/linter/linter.js:1087:32
    at Array.forEach (<anonymous>)
    at runRules (PROJECT_PATH/node_modules/eslint/lib/linter/linter.js:1080:15)
    at Linter._verifyWithoutProcessors (PROJECT_PATH/node_modules/eslint/lib/linter/linter.js:1330:31)
    at Linter._verifyWithConfigArray (PROJECT_PATH/node_modules/eslint/lib/linter/linter.js:1706:21)
    at Linter.verify (PROJECT_PATH/node_modules/eslint/lib/linter/linter.js:1412:65)
    at Linter.verifyAndFix (PROJECT_PATH/node_modules/eslint/lib/linter/linter.js:1967:29)
    at verifyText (PROJECT_PATH/node_modules/eslint/lib/cli-engine/cli-engine.js:245:48)
    at CLIEngine.executeOnFiles (PROJECT_PATH/node_modules/eslint/lib/cli-engine/cli-engine.js:825:28)
    at ESLint.lintFiles (PROJECT_PATH/node_modules/eslint/lib/eslint/eslint.js:551:23)
    at Object.execute (PROJECT_PATH/node_modules/eslint/lib/cli.js:391:36)
    at async main (PROJECT_PATH/node_modules/eslint/bin/eslint.js:135:24)

Code example
{
  "extends": ["@callstack", "plugin:perfectionist/recommended-line-length"],
  "plugins": ["perfectionist"],

  "settings": {
    "import/parsers": {
      "@typescript-eslint/parser": [".ts", ".tsx"]
    },
    "import/resolver": {
      "typescript": {},
      "babel-module": {}
    }
  },
  "rules": {
    "perfectionist/sort-objects": [
      "error",
      {
        "type": "line-length",
        "order": "desc"
      }
    ],
    "import/newline-after-import": ["error", { "count": 1 }],
    "react-native/no-raw-text": [
      "off",
      {
        "skip": ["Heading", "Body", "Title", "Button"]
      }
    ],
    "react-native/no-color-literals": "off"
  },
  "overrides": [
    {
      "files": ["*.stories.tsx", "test/**", "*.config.js", "*.config.ts"],
      "rules": {
        "import/no-default-export": "off",
        "import/no-extraneous-dependencies": "off"
      }
    },
    {
      "files": ["test/**"],
      "env": {
        "jest": true,
        "jest/globals": true
      }
    }
  ]
}

ESLint version
v8.41.0
ESLint Plugin Perfectionist version
v1.1.0
Additional comments
{
  "devDependencies": {
    "@babel/core": "^7.20.0",
    "@callstack/eslint-config": "^13.0.2",
    "@testing-library/jest-native": "^5.4.2",
    "@testing-library/react-native": "^12.1.2",
    "@types/jest": "^29.2.1",
<EMAIL_ADDRESS>"^4.0.7",
    "@types/react": "~18.0.14",
    "babel-plugin-module-resolver": "^5.0.0",
    "eslint": "^8.41.0",
    "eslint-import-resolver-babel-module": "^5.3.2",
    "eslint-import-resolver-typescript": "^3.5.5",
    "eslint-plugin-import": "^2.27.5",
    "eslint-plugin-jest": "^27.2.1",
    "eslint-plugin-perfectionist": "^1.1.0",
    "eslint-plugin-prettier": "^4.2.1",
    "eslint_d": "^12.2.1",
    "jest": "^29.2.1",
    "jest-expo": "^48.0.2",
    "prettier": "^2.8.8",
    "typescript": "^4.9.4"
  }
}

Validations

[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.

We need to understand which object is the problem.
Can you run ESLint with the --debug flag? Then around the end of the output you will see the file after which ESLint ended with an error.
We need to examine this file and see how this object is different from the others.

I managed to solve this by removing a comment block we had in our interface:
e.g
interface ActionParams extends UTMSearchParams {
  term: number;
  amount: string;
  channel: string;
  clickId?: string;
  origination_journey: string; // Needs to be snake case
}

@moshie Nice catch. I will fix this problem soon.

Fixed in 03e550820172c6cee52e686c5e694341cdbea327
Released in v1.1.2


TypeScript type definitions - corrections

@blakeembrey , could you please review these changes?
There are a couple of things I don't understand.

Why return values of the methods are sometimes separated with ":" (e.g. this line and many other places) and sometimes with "=>" (e.g. this line)?
ErrorParameters interface looks as if it is an object with many optional properties. In reality it is one of the definitions below (MinMaxParam | AdditionalPropertyParam | ...) depending on the keyword property in ErrorObject. Is it possible to express it or should alteration be used in this case?
Why Dependency and PatternGroup have "[]" after them (also in ErrorParameters)? Probably I should read the manual more attentively...

Coverage remained the same at 99.732% when pulling 76bdf0796e19ffa6d3af7aaa5bbadd2fc368231d on typescript into de23630ea1300a4f9eaef5bc513e63a8663d823f on master.

Also, would that be a correct syntax?
interface FormatValidator {
  string | RegExp | (data: string) => boolean
}

Coverage remained the same at 99.732% when pulling 76bdf0796e19ffa6d3af7aaa5bbadd2fc368231d on typescript into de23630ea1300a4f9eaef5bc513e63a8663d823f on master.

@epoberezkin Quick TypeScript primer. You have primitive types: number, string, void, any, boolean. Includes any[] (array syntax) and () => any (function syntax). On top of that, you can write interfaces:
interface Foo {
  (): any // `Foo` is a function.
  method (): any // Has a `method` method.
  prop: () => any // Equivalent to `method` method, but using our primitives.
  x: string // Another prop.
  [key: string]: string // Dictionary.
}

So, interfaces can kind of describe anything. On top of that, you have type expression (E.g. unions and intersections, etc.) which can be used in any type position or with the type keyword.
type Bar = () => any

Now let's use an expression to demonstrate where expressions can be valid.
function foobar (x: string, y: { [key: string]: Foo }): Bar

Also, would that be a correct syntax?

No, you want:
type FormatValidator = string | RegExp | (data: string) => boolean;

Why return values of the methods are sometimes separated with ":"

Either works, as described above.

Is it possible to express it or should alteration ("|") be used in this case?

Yes, it's possible to express. TypeScript has string literal types that could be used here, but it'll probably get verbose.
interface ErrorObject1 {
  keyword: 'foo'
  params: {
    x: number
    y: number
  }
}

type ErrorObject = ErrorObject1 | ...

Why Dependency and PatternGroup in ErrorParameters have "[]" after them?

Array syntax.

I think everything in this PR looked valid (we could hook up a test using tsc on the .d.ts file), but you may want to replace some of those Object usages with index signatures ({ [key: string]: Foo }).

@blakeembrey thank you very much!
When I run ./node_modules/.bin/tsc lib/ajv.d.ts on this file I get these errors:
lib/ajv.d.ts(44,31): error TS1005: ')' expected.
lib/ajv.d.ts(44,33): error TS1131: Property or signature expected.
lib/ajv.d.ts(44,39): error TS1005: ';' expected.
lib/ajv.d.ts(44,41): error TS1128: Declaration or statement expected.
lib/ajv.d.ts(45,10): error TS1109: Expression expected.
lib/ajv.d.ts(46,20): error TS1109: Expression expected.
lib/ajv.d.ts(47,19): error TS1109: Expression expected.
lib/ajv.d.ts(48,16): error TS1109: Expression expected.
lib/ajv.d.ts(49,17): error TS1109: Expression expected.
lib/ajv.d.ts(50,18): error TS1109: Expression expected.
lib/ajv.d.ts(51,25): error TS1109: Expression expected.
lib/ajv.d.ts(52,19): error TS1109: Expression expected.
lib/ajv.d.ts(53,14): error TS1109: Expression expected.
lib/ajv.d.ts(54,14): error TS1109: Expression expected.
lib/ajv.d.ts(55,11): error TS1109: Expression expected.
lib/ajv.d.ts(58,49): error TS1005: ')' expected.
lib/ajv.d.ts(58,57): error TS1005: ';' expected.
lib/ajv.d.ts(58,59): error TS1128: Declaration or statement expected.
lib/ajv.d.ts(185,1): error TS1128: Declaration or statement expected.

I installed with npm install typescrpt
It seems like it doesn't like anonymous functions in parameters...
What am I missing?
Thank you again :)

Coverage remained the same at 99.732% when pulling 18ca34253f2d3dd490502b3079e474ceda342d19 on typescript into de23630ea1300a4f9eaef5bc513e63a8663d823f on master.

Odd, worked for me from master. Can you make sure it wasn't your PR you tested?

@epoberezkin I forgot to mention, for Promise support, you'll want to add some promise typings locally for it to work properly. TypeScript < ES6 does not have a promise type, and the promise type also requires a generic parameter.

^ As does Array. It's a generic, should be Array<any>, for example.

Finally, for the union with an anonymous function use-case, wrap it in some extra parens for parsing:
transpile?: string | ((code: string) => string);

@blakeembrey thanks a lot, all works now! I just added type Promise = Object; and I was wondering whether it should import this instead: https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/es6-promise/es6-promise.d.ts ?
Thank you again :)

@blakeembrey Ok, I've figured re Promise. Should've read your comments more attentively :)

Coverage remained the same at 99.732% when pulling a954845be254c3436deff1a3893997e6e7156f2c on typescript into de23630ea1300a4f9eaef5bc513e63a8663d823f on master.

Coverage remained the same at 99.732% when pulling a954845be254c3436deff1a3893997e6e7156f2c on typescript into de23630ea1300a4f9eaef5bc513e63a8663d823f on master.

@epoberezkin Where are you using promises, I want to check if we can improve this. Otherwise, non-ES6 TypeScript clients will get confused because Promise<> does not exist for them. Is it just you accept something that returns promises or do you actually return promises yourself? If it's the former, we can fix this and inline a type definition that's compatible for you (TypeScript is structural, it'll be clearer that way).

@blakeembrey Promises are used for asynchronous validation. Ajv supports both custom keywords and formats that return promises and in this case the schema itself becomes asynchronous. Promise-compatible inline definition is absolutely fine, I actually started with it: type Promise = Object;. Or should it be something more elaborate than that?

Should be more elaborate, unless you accept pretty much anything? In TypeScript, Object is pretty equivalent to any. E.g. http://www.typescriptlang.org/play/#src=const test%3A Object %3D 10


Bump dependencies to latest current version

Thank you for your kind contribution. However, I have a concern about changing the version of packages, especially for lightning. I found it is more stable under the version of 1.9.4 or 1.9.5. Did you have tried to run some experiments? If possible, could you provide me with your current lightning versions and some log files?

Thanks for checking. I have successfully ran the notebook examples/tutorial.ipynb in a venv that I setup with the following commands:
python -m venv venv
source venv/bin/activate
pip install -r requirements.txt
jupyter notebook

On stability of pytorch2, I can attest that it has worked without issues in the past 5 months within our company. Happy to run any other tests that you would like us to run.
If it is a too disruptive change, we will continue to work on our forked repo, so we're not blocked by this.

Thank you for your contribution. I have reviewed the code again and solved the conflicts.


Special Character "&" not displaying correctly in Bulletin RSS feed

Related to #119 -
Thanks for fixing the RSS feed for the Bulletin! It looks like the feed does not display the "&" character correctly. In the following link, (http://aashe-hub-dev.herokuapp.com/browse/topics/research/), one of the stories is listed as "U Virginia Completes Nitrogen &Amp; Carbon Footprint Food Study" - the "&Amp;" should simply be "&".
I didn't see other special characters that are displaying incorrectly.

Fixed in https://github.com/AASHE/hub/commit/684ff35f3696a5de746b4aff67acc27fe0deee6a.


istioctl: move workload command from proxy-config to ztunnel-config

Please provide a description of this PR:
We need to discuss whether we should expose this command in the proxy-config list once L4 reaches beta, or at least in a non-verbose mode (excluding details like network and waypoint). This command, which retrieves workload information sent to ztunnel, was previously hidden due to its unstable status. Now, as we reach to the L4 beta, I think the APIs have become relatively stable. Therefore, it may be time to make this useful command available to users in the proxy-config list, which seems to be the most appropriate place to me.
Note: Currently, using istioctl pc all <ztunnel> displays the ztunnel workload information. However, there is no specific configuration command for the workload, which is inconsistent with other commands like cluster, listener, etc.

@hanxiaop: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
722d33aaba997ea19dba7212702238727cf683d2
link
true
/test release-notes

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Related: https://github.com/istio/istio/issues/49841

@hanxiaop: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
722d33aaba997ea19dba7212702238727cf683d2
link
true
/test release-notes

lint_istio
0aed997ce158632598956e96b330cf0f06dee6ce
link
true
/test lint

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hanxiaop: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio
0aed997ce158632598956e96b330cf0f06dee6ce
link
true
/test lint

release-notes_istio
0aed997ce158632598956e96b330cf0f06dee6ce
link
true
/test release-notes

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hanxiaop: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio
0aed997ce158632598956e96b330cf0f06dee6ce
link
true
/test lint

release-notes_istio
a4b386176348c4602b218299a8a38f990474225f
link
true
/test release-notes

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hanxiaop: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
a4b386176348c4602b218299a8a38f990474225f
link
true
/test release-notes

lint_istio
a4b386176348c4602b218299a8a38f990474225f
link
true
/test lint

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hanxiaop: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio
a4b386176348c4602b218299a8a38f990474225f
link
true
/test lint

gencheck_istio
135111deb0d69a468e93efa4bd560d34b2c27e4c
link
true
/test gencheck

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hanxiaop: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

gencheck_istio
135111deb0d69a468e93efa4bd560d34b2c27e4c
link
true
/test gencheck

lint_istio
135111deb0d69a468e93efa4bd560d34b2c27e4c
link
true
/test lint

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hanxiaop: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

gencheck_istio
135111deb0d69a468e93efa4bd560d34b2c27e4c
link
true
/test gencheck

lint_istio
135111deb0d69a468e93efa4bd560d34b2c27e4c
link
true
/test lint

integ-pilot-multicluster_istio
135111deb0d69a468e93efa4bd560d34b2c27e4c
link
true
/test integ-pilot-multicluster

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


[plot] Add select-draw interaction mode to PlotWidget

This PR adds a select-draw interactive mode which provides items (e.g., markers) selection and dragging and shape drawing interaction at the same time.
This would be useful for PR #1758.

I don't really understand, but it looks fine.


all Python cells throw AttributError:  'list' object has no attribute 'isspace'

OSX 10.11.3
Atom 1.5.3
Python 3.5.1
apm: jupyter-notebook: 0.0.9
pip: notebook: 4.1.0
Every time I try to execute a cell, this is the result:
Traceback (most recent call last):

  File "/usr/local/lib/python3.5/site-packages/ipykernel/ipkernel.py", line 175, in do_execute
    shell.run_cell(code, store_history=store_history, silent=silent)

  File "/usr/local/lib/python3.5/site-packages/IPython/core/interactiveshell.py", line 2629, in run_cell
    if (not raw_cell) or raw_cell.isspace():

AttributeError: 'list' object has no attribute 'isspace'

@rgbkrk Any ideas?

No clue there. Version drift between the kernel gateway and the ipython kernel?
Have you tried out any of the JS packages we've been making @gnestor?

@rgbkrk Not yet but I think it's time to start!

Upgraded jupyter_kernel_gateway from 0.3.1 to 0.4.0. No change.

Same here. Anybody has a resolution?

Same here

here too

Same here. @gnestor @rgbkrk

The same here. @gnestor @rgbkrk

Once we have the prebuilt zmq story better underway, I'll be happy to come back to this repo to make it a fully standalone (no need for kernel gateway) Atom package, like Hydrogen. Right now I don't have time to assist with this package, though I'll happily merge PRs that help push us towards the right efforts. Most of my open source node+jupyter time is in the nteract org.

Any solutions?

Another one here.
Ubuntu: 16.04
Atom: 1.7.2
Python: 3.5.1
jupyter-notebook: 0.0.9

Installed latest Atom version (1.10.2), now I have problems opening jypyter server: https://github.com/jupyter/atom-notebook/issues/55

This happens on line 2190 of interactive_shell.py for me
/usr/local/lib/python3.6/dist-packages/IPython/core/interactiveshell.py in run_cell_async(self, raw_cell, store_history, silent, shell_futures)
   2908         result = ExecutionResult(info)
   2909
-> 2910         if (not raw_cell) or raw_cell.isspace():
   2911             self.last_execution_succeeded = True
   2912             self.last_execution_result = result

AttributeError: 'builtin_function_or_method' object has no attribute 'isspace'
Out[5]: 'None'

In [6]: str(interactive_variables['interactive_console'].run_cell(print, True).result)

Seems like it could be solved with a simple try/except


Users can apply script hosted on HTTP server using query parameters

Some HTTP server depends on the query parameter values to serve the right file.
Expected Behavior
apply from: 'http://localhost/some/path/file.gradle?h=some;query=value' call to the localhost server with the path some/path/file.gradle as well as with the query parameters h=some;query=value.
Current Behavior
The applying URI is model inside ExternalResourceName which drop the query parameters. When reconstructing the URI the query parameters aren't part of the requesting URI anymore.
Steps to Reproduce (for bugs)
An integration test will follow soon.

Branch dl/apply-from-with-query-string contains an integration test exposing the issue.

The integration test is now in master: https://github.com/gradle/gradle/commit/9bc33a9fd10a2d1aae16ac7b13b0b62370d51da2

I discussed this with @big-guy. He will identify whether it is a blocker for 4.2 and a implement a potential fix if it is cheap to do.

Fixed by fa5740022c9c2e5c4f67fbc193ad8f8c60e9c5c2

This has been merged


ApolloTestingController flushes .watchQuery synchronously but .query and .mutate asynchronously

Intended outcome:
Using ApolloTestingController should work the same for .watchQuery, .query, and .mutate in terms of async vs sync flush expectations. Tests should fail synchronously if an expectation fails in the subscription callback.
The documentation here should work for all three: https://www.apollographql.com/docs/angular/guides/testing/
Actual outcome:

The documentation for testing Apollo states that ApolloTestingController works like HttpTestingController to test network responses by flushing fake data. This is true, http.get and apollo.watchQuery work exactly the same. You can test whether the responses are the expected responses without worrying about asynchronous factors, like using async or fakeAsync or done.
When using apollo.query or apollo.mutate it does not seem to work the same way and results in strange behavior when expectations do fail. Tests actually pass when they shouldn't, instead errors are thrown later after all tests are run without signaling what test caused a failure ("An error was thrown in afterAll").
Result in example:
"Chrome 79.0.3945 (Mac OS X 10.15.2): Executed 3 of 3 (2 FAILED) ERROR (0.071 secs / 0.057 secs)"

How to reproduce the issue:

Repository: https://github.com/alchemy-way/angular-apollo-testing-example
Stackblitz: can't run unit tests
Run ng test (or npm test) to execute the unit tests via Karma and notice how the query does not fail synchronously like the others.
Versions

"apollo-angular": "1.8.0"
"apollo-angular-link-http": "1.9.0"
"apollo-link": "1.2.11"
"apollo-client": "2.6.0"
"apollo-cache-inmemory": "1.6.0"

"@angular/core": "8.2.14"
"graphql-tag": "2.10.0"
"graphql": "14.5.0"
"typescript": "3.5.3"
"ts-node": "7.0.0"

"karma": "4.1.0",
"karma-jasmine": "2.0.1"

See package.json: https://github.com/alchemy-way/angular-apollo-testing-example/blob/master/package.json

That's because @apollo/client/core uses Promises for query and mutate methods

This seems to have changed with Angular 9. Our unit tests now fail quite a bit.

I'm having the same problem, except for me watchQuery also does not seem to fail (intentionally). It seems the observable never emits, so the code in the subscribe block never runs (therefore, those expects don't affect the outcome of the test).
When using the done() technique, it throws a timeout error (Async function did not complete within 5000ms) which also confirms that the observable is not emitting.
Versions:
"apollo-angular": "1.6.0",
"apollo-angular-link-http": "1.8.0",
"apollo-cache-inmemory": "1.6.2",
"apollo-client": "2.6.3",
"apollo-link": "1.2.12",
"apollo-link-error": "1.1.11"

"@angular/core": "8.2.14",
"graphql": "14.4.1",
"graphql-tag": "2.10.1",
"ts-node": "7.0.0",
"typescript": "3.4.5"

"karma": "4.2.0",
"karma-jasmine": "2.0.1",

This one has just become a problem for us after updating to<EMAIL_ADDRESS>let user: User | null | undefined;
userService.user$.pipe(tap(console.log)).subscribe(u => (user = u));

const op = apolloController.expectOne(userQuery);
expect(op.operation.variables).toEqual({ userId: EXPECTED_USER.userId });

op.flush({
  data: {
    user: {
      ...EXPECTED_USER,
      __typename: 'User',
    },
  } as UserResponse,
});

console.log('assert');
expect(user).toEqual(EXPECTED_USER);

In the example above, the 'assert' gets logged before the tap(console.log).
The query we're testing is:
this.queryRef = apollo.watchQuery<UserResponse, UserVariables>({
  query: userQuery,
  variables: { userId },
  fetchPolicy: 'network-only',
});

So now I'm guessing everything is async


Fix README example

Fix the function declaration.

Thanks, we've only just open-sourced this repo so I'm sure there will be plenty of issues like this. We have a number of things to add to the README and would also like to add an examples directory.
How did you come across f1?
Also, I think the build is failing because the encrypted files can only be decrypted by Travis in this repo. I might try creating a target branch for this PR within this repo and see if we can merge into that first.

Yep that worked, will merge to master in https://github.com/form3tech-oss/f1/pull/13

How did you come across f1?

I was contacted by one of your tech talent recruiter. So I decided to look at some of your open source projects 🙂


Highlight optional/required fields

When creating a new task, method or result/metric, as a user it would be nice to know what fields are mandatory and what not. For example, there are tasks without a "Description" but if one submits a method without the "Description" field, an error arises.
I suggest using either the "(optional)" next to optional fields or an asterisk * next to required ones.

@vprusso Note that we have FormFieldValidators here already, but they should just trigger on pressing "Submit." I'm going to set defaults for method entry, as well, since I'm editing that UI for method hierarchy.

This happens to be addressed in PR #480, in the process of addressing issue #438.


pod pkg: WithReadinessProbe method added to the container config

pod pkg: WithReadinessProbe method added to the container config

@klaskosk @trewest @cdvultur PTAL


Contributors

@all-contributors
please add @jungheejung for infra, test, code, design, research.
please add @psadil for infra, test, code.

https://github.com/all-contributors
please add @jungheejung for infra, test, code, design, research.
please add @psadil for infra, test, code.


Added Xcode 6.4 & 7 beta 3 UDIDs

Thanks! For Xcode 7 the plugin isn't needed anymore, I'll remove the UUID in another commit.


Link to Babeljs.io repl incorrect.

The "See full expanded version" link to babeljs.io in content/tutorial/tutorial.md is not interpreting the html character codes for non-alphanumeric characters correctly in production. The link is working correctly when selected from within the markdown file in the repo.
This is what is loaded into babel in production:

Shopping List for {props.name}<%2Fh1>

Instagram<%2Fli>

WhatsApp<%2Fli>

Oculus<%2Fli>
  <%2Ful>
<%2Fdiv>

Product URL snippet: className%253D%22shopping-list
Markdown URL snippet: className%3D%22shopping-list
Reproduced in:
Google Chrome Version 61.0.3163.100
Google Chrome Version 62.0.3202.75
Firefox 56.0.2
Work around:
Update the code in babel after following the link.
I can probably take a look at this later unless someone else wants to grab this.

Wanna send a fix?

Sure, I'll take a look over the weekend. Do the markdown files go through some sort of build process  before it hits production?

Thanks for catching this!

Do the markdown files go through some sort of build process before it hits production?

I had an idea (mentioned here) of auto-generating the links during build, but currently they are hard-coded.

This issue is all yours, @ptrmelko10! 😄
I've added an "in-progress" label so that others will know not to start work on the issue. If you change your mind about the issue, no worries! Just let me know so that I can remove the label and free it up for someone else to claim.
Cheers!

@ptrmelko10 Have you started on this, by chance? If not I'd like to pick it up. After working on #251 I have a pretty good idea of how we could auto-generate links during build in the way I mentioned.

I'm going to toss up a PR that's related to this, but a bit broader, just because I'm thinking about it at the moment. I'll CC you on it for discussion! 😄

Since my PR fixed a couple of additional issues (not just the one mentioned in this issue) I went ahead and merged it. I hope this is okay and I didn't step on your toes, @ptrmelko10. 🙏 Many apologies if I did.
Let's chat more if you have any concerns or follow-up suggestions to the approach I took in #255!

@bvaughn it's all good. I didn't get much time to look this over. I'll review #255 since I figured the problem had something to do with gatsby.


Langchain BGE implementation

Hello, do you think this code is still needed in langchain?

Hi, thanks very much for your work! BGE is different from the Instructor model (we only add instruction for query) and sentence-transformers. Therefore, I think it's needed.
Here are some suggestions for this code:

DEFAULT_QUERY_BGE_INSTRUCTION should be "Represent this sentence for searching relevant passages: " ,  DEFAULT_EMBED_BGE_INSTRUCTION should be "" or delete it, which is not needed in BGE model.
It's better to set both DEFAULT_QUERY_BGE_INSTRUCTION_EN  and DEFAULT_QUERY_BGE_INSTRUCTION_ZH.
And using DEFAULT_QUERY_BGE_INSTRUCTION_ZH when '-zh' exists in model_name
Use the same encode function with sentence transformers. The instruction pair is not supported in sentence transformers.
Overall, maybe a class like this is better:

DEFAULT_QUERY_BGE_INSTRUCTION_EN = (
    "Represent this question for searching relevant passages: "
)
DEFAULT_QUERY_BGE_INSTRUCTION_ZH = (
    "为这个句子生成表示以用于检索相关文章："
)

class HuggingFaceBgeEmbeddings(BaseModel, Embeddings):
    """HuggingFace BGE sentence_transformers embedding models.

    To use, you should have the ``sentence_transformers`` python package installed.

    Example:
        .. code-block:: python

            from langchain.embeddings import HuggingFaceBgeEmbeddings

            model_name = "BAAI/bge-large-en"
            model_kwargs = {'device': 'cpu'}
            encode_kwargs = {'normalize_embeddings': False}
            hf = HuggingFaceBgeEmbeddings(
                model_name=model_name,
                model_kwargs=model_kwargs,
                encode_kwargs=encode_kwargs
            )
    """

    client: Any  #: :meta private:
    model_name: str = DEFAULT_BGE_MODEL
    """Model name to use."""
    cache_folder: Optional[str] = None
    """Path to store models.
    Can be also set by SENTENCE_TRANSFORMERS_HOME environment variable."""
    model_kwargs: Dict[str, Any] = Field(default_factory=dict)
    """Key word arguments to pass to the model."""
    encode_kwargs: Dict[str, Any] = Field(default_factory=dict)
    """Key word arguments to pass when calling the `encode` method of the model."""
    query_instruction: str = DEFAULT_QUERY_BGE_INSTRUCTION_EN
    """Instruction to use for embedding query."""

    def __init__(self, **kwargs: Any):
        """Initialize the sentence_transformer."""
        super().__init__(**kwargs)
        try:
            import sentence_transformers

        except ImportError as exc:
            raise ImportError(
                "Could not import sentence_transformers python package. "
                "Please install it with `pip install sentence_transformers`."
            ) from exc

        self.client = sentence_transformers.SentenceTransformer(
            self.model_name, cache_folder=self.cache_folder, **self.model_kwargs
        )
        if '-zh' in self.model_name:
            self.query_instruction = DEFAULT_QUERY_BGE_INSTRUCTION_ZH

    class Config:
        """Configuration for this pydantic object."""

        extra = Extra.forbid

    def embed_documents(self, texts: List[str]) -> List[List[float]]:
        """Compute doc embeddings using a HuggingFace transformer model.

        Args:
            texts: The list of texts to embed.

        Returns:
            List of embeddings, one for each text.
        """
        texts = list(map(lambda x: x.replace("\n", " "), texts))
        embeddings = self.client.encode(texts, **self.encode_kwargs)
        return embeddings.tolist()

    def embed_query(self, text: str) -> List[float]:
        """Compute query embeddings using a HuggingFace transformer model.

        Args:
            text: The text to embed.

        Returns:
            Embeddings for the text.
        """
        text = text.replace("\n", " ")
        embedding = self.client.encode(self.query_instruction+text, **self.encode_kwargs)
        return embedding.tolist()

I'm not sure whether to set normalize_embeddings to True. The similarity method of BGE is cosine similarity. If the default similarity mode in Langchain is 'inner product' or 'L2', there will be some difference if not normalize the embedding.

Thank you.  I will propose the new changes.
Instruction is only required for retrieval, right?
Do we need instructions for clustering?

From: staoxiao @.>
Sent: Tuesday, August 8, 2023 6:15:45 PM
To: FlagOpen/FlagEmbedding @.>
Cc: manmax31 @.>; Author @.>
Subject: Re: [FlagOpen/FlagEmbedding] Langchain BGE implementation (Issue #9)
Hi, thanks very much for your work! BGE is different from the Instructor model (we only add instruction for query) and sentence-transformers. Therefore, I think it's needed.
Here are some suggestions for this code:

DEFAULT_QUERY_BGE_INSTRUCTION should be "Represent this sentence for searching relevant passages: " , DEFAULT_EMBED_BGE_INSTRUCTION should be "" or delete it, which is not needed in BGE model.
It's better to set both DEFAULT_QUERY_BGE_INSTRUCTION_EN and DEFAULT_QUERY_BGE_INSTRUCTION_ZH.
And using DEFAULT_QUERY_BGE_INSTRUCTION_ZH when '-zh' exists in model_name
Use the same encode function with sentence transformers. The instruction pair is not supported in sentence transformers.
Overall, maybe a class like this is better:

DEFAULT_QUERY_BGE_INSTRUCTION_EN = (
"Represent this question for searching relevant passages: "
)
DEFAULT_QUERY_BGE_INSTRUCTION_ZH = (
"为这个句子生成表示以用于检索相关文章："
)
class HuggingFaceBgeEmbeddings(BaseModel, Embeddings):
"""HuggingFace BGE sentence_transformers embedding models.
To use, you should have the ``sentence_transformers`` python package installed.

Example:
    .. code-block:: python

        from langchain.embeddings import HuggingFaceBgeEmbeddings

        model_name = "BAAI/bge-large-en"
        model_kwargs = {'device': 'cpu'}
        encode_kwargs = {'normalize_embeddings': False}
        hf = HuggingFaceBgeEmbeddings(
            model_name=model_name,
            model_kwargs=model_kwargs,
            encode_kwargs=encode_kwargs
        )
"""

client: Any  #: :meta private:
model_name: str = DEFAULT_BGE_MODEL
"""Model name to use."""
cache_folder: Optional[str] = None
"""Path to store models.
Can be also set by SENTENCE_TRANSFORMERS_HOME environment variable."""
model_kwargs: Dict[str, Any] = Field(default_factory=dict)
"""Key word arguments to pass to the model."""
encode_kwargs: Dict[str, Any] = Field(default_factory=dict)
"""Key word arguments to pass when calling the `encode` method of the model."""
query_instruction: str = DEFAULT_QUERY_BGE_INSTRUCTION_EN
"""Instruction to use for embedding query."""

def __init__(self, **kwargs: Any):
    """Initialize the sentence_transformer."""
    super().__init__(**kwargs)
    try:
        import sentence_transformers

    except ImportError as exc:
        raise ImportError(
            "Could not import sentence_transformers python package. "
            "Please install it with `pip install sentence_transformers`."
        ) from exc

    self.client = sentence_transformers.SentenceTransformer(
        self.model_name, cache_folder=self.cache_folder, **self.model_kwargs
    )
    if '-zh' in self.model_name:
        self.query_instruction = DEFAULT_QUERY_BGE_INSTRUCTION_ZH

class Config:
    """Configuration for this pydantic object."""

    extra = Extra.forbid

def embed_documents(self, texts: List[str]) -> List[List[float]]:
    """Compute doc embeddings using a HuggingFace transformer model.

    Args:
        texts: The list of texts to embed.

    Returns:
        List of embeddings, one for each text.
    """
    texts = list(map(lambda x: x.replace("\n", " "), texts))
    embeddings = self.client.encode(texts, **self.encode_kwargs)
    return embeddings.tolist()

def embed_query(self, text: str) -> List[float]:
    """Compute query embeddings using a HuggingFace transformer model.

    Args:
        text: The text to embed.

    Returns:
        Embeddings for the text.
    """
    text = text.replace("\n", " ")
    embedding = self.client.encode(self.query_instruction+text, **self.encode_kwargs)
    return embedding.tolist()

I'm not sure whether to set normalize_embeddings to True. The similarity method of BGE is cosine similarity. If the default similarity mode in Langchain is 'inner product' or 'L2', there will be some difference if not normalize the embedding.
―
Reply to this email directly, view it on GitHubhttps://github.com/FlagOpen/FlagEmbedding/issues/9#issuecomment-1669134771, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAU7ATZUYX2VFT2TATH5O6LXUHYTDANCNFSM6AAAAAA3IAKYGA.
You are receiving this because you authored the thread.Message ID: @.***>

Yes, only for retrieval. It's not needed for clustering.

https://github.com/langchain-ai/langchain/blob/e3056340da262788f7c284d0f1f158073c3152b1/libs/langchain/langchain/embeddings/huggingface.py#L179
It's there now :)


fix(settings): missing timestamps in api conversion

created_at was returning 0, only if the value was updated via API.
also, noticed a variable type newSettingps so i made it the ol' shadow variable with an underscore

added a settings.FromCLIContext that fixes missing fields in Restore


x/tools/gopls: add codelens to show number of references to each symbol

Issue Type: Feature Request
it would be nice to see if a function is referenced in the code or not.
click on the codelens and see all the places the variable, function being referenced.
variable:

functions:

Extension version: 2020.8.1301
VS Code version: Code - Insiders 1.49.0-insider (bd08768fd310d34cdd4423a53e5f3ca77340fea5, 2020-08-14T05:56:40.601Z)
OS version: Windows_NT x64 10.0.18363

Thanks for the feature request, @sanket-bhalerao. I'd like to hear from others about the benefits of this feature. Currently, my preference would be to add the 'unused' checks from staticcheck (https://github.com/golang/go/issues/36602), which might make this feature a little redundant.

references is a quick insight into how many times a function is being called an generally would allow the end click to create a view into where the functions / etc are being used for quick looks. I think this is much more valuable than what is being shown here. And completely different from staticcheck. Just look at elm language server for instance

references is a quick insight into how many times a function is being called an generally would allow the end click to create a view into where the functions / etc are being used for quick looks. I think this is much more valuable than what is being shown here. And completely different from staticcheck. Just look at elm language server for instance

This feature is already available by right-clicking an identifier and selecting "Find all references". The code lens is would make it easy to tell if a symbol is referenced, which is typically used to see if it is used anywhere in the workspace.

I guess a workaround to get this feature would just have the client implementation make the request automatically rather than having to click and request them. 🤷♂ Seems like it may be more of a personal preference thing at that point ?

I think we would be open to this feature being added in gopls, but it would have to be off by default, because it would be expensive to constantly called "find references" on every symbol in a given file. Still, we will not prioritize work on this, so if a community member would like to pick this up and send a CL, please follow up here.

We implemented this feature in our extension, tooltitude. We focus on augmenting gopls with convenience and productivity features. For example on screenshot you could see the usages of Join in the "stirngs" on kubernetes repo. It computed all reference counts in around 300ms on my M1 Max Macbook pro. On smaller files, and projects it's much faster. On machines with more cores the perf is even better.

P.S. You could read more about it here: https://www.tooltitude.com/ You could install from here: https://marketplace.visualstudio.com/items?itemName=tooltitudeteam.tooltitude
cc @TerminalFi @stamblerre  @hyangah @sanket-bhalerao

Looks cool! I am a ST User, and maintain LSP-gopls. I see this is closed source. That is too bad

@TerminalFi In theory nothing prevents it working from within ST. It's mostly LSP, with some additional requests and notifications to improve integration with VSCode.  At some point we will consider it, taking into account that sublime is closed source too and people happily pay for performance (i.e. they are more likely than vscode users interested in commercial extension).

@TerminalFi I have a VS Code extension that is open-source here: https://github.com/tkg-codes/go-interface-annotations. I have also mentioned this in https://github.com/golang/go/issues/56695 unfortunately there doesn't seem to be any movement on this one. :(
I moved to neovim since making that extension for VSCode and it seems I can't get the same thing working on nvim, which is really, really sad.

@TerminalFi I have a VS Code extension that is open-source here: https://github.com/tkg-codes/go-interface-annotations. I have also mentioned this in https://github.com/golang/go/issues/56695 unfortunately there doesn't seem to be any movement on this one. :(
I moved to neovim since making that extension for VSCode and it seems I can't get the same thing working on nvim, which is really, really sad.

Time to move to Sublime ;)

Does it work there? Goddamit. Do you know if gopls even supports this? I can make the neovim extension, but I need to know whether gopls can even return textdocument/references or textdocument/implementations correctly...

I am working on an update to LSP-gopls

Hm, are you getting this data from gopls? 🤔 If so then it should be possible for me to code it for neovim too.

Hm, are you getting this data from gopls? 🤔 If so then it should be possible for me to code it for neovim too.

Yes. Essentially this is the logic I am using.

File is activitated (Opened or Focused)
Send LSP Request textDocument/documentSymbol
For each Symbol returned

for symbol in symbols:
        params = {
            'textDocument': {'uri': view_to_uri(self.view)},
            'position': symbol['selectionRange']['start']
        }
        request = Request("textDocument/references", params)

Hm, this is what I tried. Hm. Maybe I just messed something up the last time, oh well, got a new weekend project, I guess. Cheers!

@tkgalk I actually have a working implementation in a branch of gopls. I need to figure out the proper way to open an MR for it though.
Seems to be relatively fast

@stamblerre I might need a little direction on handling sending the response back to the client. Looks like i need to do something in tsclient.go

Yeah, I coded it in myself now. I'll be publishing it on GitHub soon. I also found https://github.com/VidocqH/lsp-lens.nvim which works.

Yeah, I manage to code something for neovim, I'll release it later on GitHub for anyone wanting to use it but I need to finish some stuff first.

While making it, I also found that someone had already done something similar, though: https://github.com/VidocqH/lsp-lens.nvim.

Yeah, just meant that this should be in core once I finish this. So it won't need to be handled by the client.

We implemented this feature in our extension, tooltitude. We focus on augmenting gopls with convenience and productivity features. For example on screenshot you could see the usages of Join in the "stirngs" on kubernetes repo. It computed all reference counts in around 500ms on my M1 Max Macbook pro. On smaller files, and projects it's much faster. On machines with more cores the perf is even better.

P.S. You could read more about it here: https://www.tooltitude.com/ You could install from here: https://marketplace.visualstudio.com/items?itemName=tooltitudeteam.tooltitude
cc @TerminalFi @stamblerre @hyangah @sanket-bhalerao
P.S. Updated check time value to reflect a fix of a bug.

Nice extensions !!!

any updates on this?

We implemented this feature in our extension, tooltitude. We focus on augmenting gopls with convenience and productivity features. For example on screenshot you could see the usages of Join in the "stirngs" on kubernetes repo. It computed all reference counts in around 500ms on my M1 Max Macbook pro. On smaller files, and projects it's much faster. On machines with more cores the perf is even better.

P.S. You could read more about it here: https://www.tooltitude.com/ You could install from here: https://marketplace.visualstudio.com/items?itemName=tooltitudeteam.tooltitude
cc @TerminalFi @stamblerre @hyangah @sanket-bhalerao
P.S. Updated check time value to reflect a fix of a bug.

Nice extensions !!!

No, this is a paid extension with pretty mature price ( I think getting JB Goland will be a cheaper option lol), afwul that we does not have such a basic functionality with default vscode extension

No, this is a paid extension with pretty mature price ( I think getting JB Goland will be a cheaper option lol), afwul that we does not have such a basic functionality with default vscode extension

https://github.com/tkgalk/go-interface-annotations you can take a look at my extension that does this. It is implemented in a fairly naive way, though, so in big codebases or large files it might be slow, but I haven't tested it thoroughly as I don't use VS Code anymore. But yes, it is a shame, that this isn't part of the gopls itself.

No, this is a paid extension with pretty mature price ( I think getting JB Goland will be a cheaper option lol), afwul that we does not have such a basic functionality with default vscode extension

To be fair to Tooltitude, I think that specific part of the reference count is free.
https://github.com/tkgalk/go-interface-annotations you can take a look at my extension that does this. It is implemented in a fairly naive way, though, so in big codebases or large files it might be slow, but I haven't tested it thoroughly as I don't use VS Code anymore. But yes, it is a shame, that this isn't part of the gopls itself.

looks awesome! thank you, definitely will try it


Creating an override method renames reference out

The reference out terminal gets renamed to "reference in" when creating an override method

Fixed in the next version, it was just the template files for 4 and 5 CP sized of Sub classes that had the wrong name

v1.3.6 is ready for testing


feat(Dockerfile): Add Dockerfile - #18

Added the Dockerfile and the the .dockerignore file to dockerize the application

LGTM


Bootstrap tools broken on macOS 10.14 Mojave - fork() issue

Issue description
building '/nix/store/qbr6qqs9gi96r5dpamalb76725zyyvj3-bootstrap-tools.cpio.bz2.drv'...
building '/nix/store/mswwp45p6pzbb3zv604h3li6lsm43l6s-bzip2.drv'...
building '/nix/store/fn6dmhxmki9ppkfgibr054z65sqxnw34-cpio.drv'...
building '/nix/store/5pgkcx95qbbjsdk04hxngqc1fnaxgjgf-mkdir.drv'...
building '/nix/store/ycjc52zyp25h42br5ikz0sip84vfynh8-sh.drv'...
objc[36265]: +[__NSPlaceholderArray initialize] may have been in progress in another thread when fork() was called.
objc[36265]: +[__NSPlaceholderArray initialize] may have been in progress in another thread when fork() was called. We cannot safely call it or ignore it in the fork() child process. Crashing instead. Set a breakpoint on objc_initializeAfterForkError to debug.
objc[36267]: +[__NSPlaceholderArray initialize] may have been in progress in another thread when fork() was called.
objc[36267]: +[__NSPlaceholderArray initialize] may have been in progress in another thread when fork() was called. We cannot safely call it or ignore it in the fork() child process. Crashing instead. Set a breakpoint on objc_initializeAfterForkError to debug.
objc[36269]: +[__NSPlaceholderArray initialize] may have been in progress in another thread when fork() was called.
objc[36269]: +[__NSPlaceholderArray initialize] may have been in progress in another thread when fork() was called. We cannot safely call it or ignore it in the fork() child process. Crashing instead. Set a breakpoint on objc_initializeAfterForkError to debug.
objc[36285]: +[__NSPlaceholderArray initialize] may have been in progress in another thread when fork() was called.
objc[36285]: +[__NSPlaceholderArray initialize] may have been in progress in another thread when fork() was called. We cannot safely call it or ignore it in the fork() child process. Crashing instead. Set a breakpoint on objc_initializeAfterForkError to debug.
objc[36317]: +[__NSPlaceholderArray initialize] may have been in progress in another thread when fork() was called.
objc[36317]: +[__NSPlaceholderArray initialize] may have been in progress in another thread when fork() was called. We cannot safely call it or ignore it in the fork() child process. Crashing instead. Set a breakpoint on objc_initializeAfterForkError to debug.
builder for '/nix/store/qbr6qqs9gi96r5dpamalb76725zyyvj3-bootstrap-tools.cpio.bz2.drv' failed due to signal 6 (Abort trap: 6)
builder for '/nix/store/mswwp45p6pzbb3zv604h3li6lsm43l6s-bzip2.drv' failed due to signal 6 (Abort trap: 6)
builder for '/nix/store/fn6dmhxmki9ppkfgibr054z65sqxnw34-cpio.drv' failed due to signal 6 (Abort trap: 6)
builder for '/nix/store/5pgkcx95qbbjsdk04hxngqc1fnaxgjgf-mkdir.drv' failed due to signal 6 (Abort trap: 6)
builder for '/nix/store/ycjc52zyp25h42br5ikz0sip84vfynh8-sh.drv' failed due to signal 6 (Abort trap: 6)

Steps to reproduce
Try to build the Darwin stdenv on 10.14.
Technical details
I was going to be clever here and post the issue description again, but luckily I have a nix-info still surviving.

 - system: `"x86_64-darwin"`
 - host os: `Darwin 18.0.0, macOS 10.14`
 - multi-user?: `no`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.1pre6148_a4aac7f`
 - channels(root): `"nixpkgs-18.09pre144939.14a9ca27e69"`
 - nixpkgs: `/Users/jackhenahan/.nix-defexpr/nixpkgs`

It claims that I don't have a multi-user install and that sanboxing is on, but neither of those is true. :shrug:

Apparently this can be worked around by setting
export OBJC_DISABLE_INITIALIZE_FORK_SAFETY=YES

but I have no idea where to actually put this to make Nix see that variable.

Do you know if this just bootstrapTools or also parts of the stdenv?

Adding more verbosity hasn't given me much more info, but I can gist a full log if it'll help. I assume it's in bootstrapTools because that's the first drv failing. nix-env -i hello -vvv gets me
<snip>
building of '/nix/store/jgmzc9lnxxhzncvrwfmg6gn445skfn90-help2man-1.47.6.drv': have derivation
acquiring write lock on '/nix/var/nix/temproots/42839'
downgrading to read lock on '/nix/var/nix/temproots/42839'
building of '/nix/store/jgmzc9lnxxhzncvrwfmg6gn445skfn90-help2man-1.47.6.drv': all outputs substituted (maybe)
downloading 'http://tarballs.nixos.org/sha256/4e321a7bf05f382437dee9f10d727affe25244466690ab0e180f653a0d2f17a2'...
starting download of http://tarballs.nixos.org/sha256/4e321a7bf05f382437dee9f10d727affe25244466690ab0e180f653a0d2f17a2
objc[43692]: +[__NSPlaceholderArray initialize] may have been in progress in another thread when fork() was called.
objc[43692]: +[__NSPlaceholderArray initialize] may have been in progress in another thread when fork() was called. We cannot safely call it or ignore it in the fork() child process. Crashing instead. Set a breakpoint on objc_initializeAfterForkError to debug.
downloading 'http://tarballs.nixos.org/stdenv-darwin/x86_64/d5bdfcbfe6346761a332918a267e82799ec954d2/bzip2'...
starting download of http://tarballs.nixos.org/stdenv-darwin/x86_64/d5bdfcbfe6346761a332918a267e82799ec954d2/bzip2
objc[43694]: +[__NSPlaceholderArray initialize] may have been in progress in another thread when fork() was called.
objc[43694]: +[__NSPlaceholderArray initialize] may have been in progress in another thread when fork() was called. We cannot safely call it or ignore it in the fork() child process. Crashing instead. Set a breakpoint on objc_initializeAfterForkError to debug.
downloading 'http://tarballs.nixos.org/stdenv-darwin/x86_64/d5bdfcbfe6346761a332918a267e82799ec954d2/cpio'...
starting download of http://tarballs.nixos.org/stdenv-darwin/x86_64/d5bdfcbfe6346761a332918a267e82799ec954d2/cpio
objc[43696]: +[__NSPlaceholderArray initialize] may have been in progress in another thread when fork() was called.
objc[43696]: +[__NSPlaceholderArray initialize] may have been in progress in another thread when fork() was called. We cannot safely call it or ignore it in the fork() child process. Crashing instead. Set a breakpoint on objc_initializeAfterForkError to debug.
downloading 'http://tarballs.nixos.org/stdenv-darwin/x86_64/d5bdfcbfe6346761a332918a267e82799ec954d2/mkdir'...
starting download of http://tarballs.nixos.org/stdenv-darwin/x86_64/d5bdfcbfe6346761a332918a267e82799ec954d2/mkdir
objc[43698]: +[__NSPlaceholderArray initialize] may have been in progress in another thread when fork() was called.
objc[43698]: +[__NSPlaceholderArray initialize] may have been in progress in another thread when fork() was called. We cannot safely call it or ignore it in the fork() child process. Crashing instead. Set a breakpoint on objc_initializeAfterForkError to debug.
downloading 'http://tarballs.nixos.org/stdenv-darwin/x86_64/d5bdfcbfe6346761a332918a267e82799ec954d2/sh'...
starting download of http://tarballs.nixos.org/stdenv-darwin/x86_64/d5bdfcbfe6346761a332918a267e82799ec954d2/sh
objc[43700]: +[__NSPlaceholderArray initialize] may have been in progress in another thread when fork() was called.
objc[43700]: +[__NSPlaceholderArray initialize] may have been in progress in another thread when fork() was called. We cannot safely call it or ignore it in the fork() child process. Crashing instead. Set a breakpoint on objc_initializeAfterForkError to debug.
building of '/nix/store/qbr6qqs9gi96r5dpamalb76725zyyvj3-bootstrap-tools.cpio.bz2.drv': got EOF
building of '/nix/store/qbr6qqs9gi96r5dpamalb76725zyyvj3-bootstrap-tools.cpio.bz2.drv': woken up
building of '/nix/store/mswwp45p6pzbb3zv604h3li6lsm43l6s-bzip2.drv': got EOF
building of '/nix/store/mswwp45p6pzbb3zv604h3li6lsm43l6s-bzip2.drv': woken up
building of '/nix/store/fn6dmhxmki9ppkfgibr054z65sqxnw34-cpio.drv': got EOF
building of '/nix/store/fn6dmhxmki9ppkfgibr054z65sqxnw34-cpio.drv': woken up
building of '/nix/store/5pgkcx95qbbjsdk04hxngqc1fnaxgjgf-mkdir.drv': got EOF
building of '/nix/store/5pgkcx95qbbjsdk04hxngqc1fnaxgjgf-mkdir.drv': woken up
building of '/nix/store/ycjc52zyp25h42br5ikz0sip84vfynh8-sh.drv': got EOF
building of '/nix/store/ycjc52zyp25h42br5ikz0sip84vfynh8-sh.drv': woken up
building of '/nix/store/qbr6qqs9gi96r5dpamalb76725zyyvj3-bootstrap-tools.cpio.bz2.drv': build done
killing process 43692
builder process for '/nix/store/qbr6qqs9gi96r5dpamalb76725zyyvj3-bootstrap-tools.cpio.bz2.drv' finished
killing all processes running under uid '30001'
builder for '/nix/store/qbr6qqs9gi96r5dpamalb76725zyyvj3-bootstrap-tools.cpio.bz2.drv' failed due to signal 6 (Abort trap: 6)
<snip>

I suspect this is Cocoa churn, as usual, but I don't have many good ideas about where to look.
I've also been using --option substitute false because I keep getting unexpected end-of-file like so:
checking substituter 'https://cache.nixos.org' for path '/nix/store/fyq4whg2lzgx2qw43ip6zni7g1lvfrv6-hello-2.10'
querying info about '/nix/store/fyq4whg2lzgx2qw43ip6zni7g1lvfrv6-hello-2.10' on 'https://cache.nixos.org'...
downloading 'https://cache.nixos.org/fyq4whg2lzgx2qw43ip6zni7g1lvfrv6.narinfo'...
starting download of https://cache.nixos.org/fyq4whg2lzgx2qw43ip6zni7g1lvfrv6.narinfo
error: unexpected end-of-file

I don't know if that indicates that something else may be broken or if it's an entirely separate thing.

You probably want to put OBJC_DISABLE_INITIALIZE_FORK_SAFETY=YES here:
https://github.com/NixOS/nixpkgs/blob/master/pkgs/stdenv/darwin/default.nix#L30
I haven't tried to reproduce this, but it will definitely be bad once Hydra machines are updated. I'm not sure what version they are on now so we may have a while before it becomes a problem.
I wonder why this safety check is getting hit? It could be just because are stuff was built with old SDKs?

This doesn’t actually happen for me on recent nixos-unstable checkouts on the latest Mojave, so this may have been fixed by the new CF work.

@matthewbauer  & @LnL7 I still observe this issue on master for the last 3-5 days. This time on nix-daemon side on a darwin multi-user installation:

Have a look here: http://sealiesoftware.com/blog/archive/2017/6/5/Objective-C_and_fork_in_macOS_1013.html


Added Strategr - no-fuss time management app

Project URL
https://github.com/khrykin/StrategrDesktop
https://khrykin.github.io/strategr
Category
Productivity
Description
Stategr helps you maximize your productivity, giving you the quickest and most effective way to time-box your day with strategies. More info on the website.
Why it should be included to Awesome macOS open source applications  (optional)
Well, cause... it's awesome!
Checklist

[x] Edit applications.json instead of README.md.
[x] Only one project/change is in this pull request
[x] Screenshots(s) added if any
[x] Has a commit from less than 2 years ago
[x] Has a clear README in English

          1 Warning

:warning:
Found 1 link issue, a project collaborator will take care of these, thanks :)

Link issue by awesome_bot

Line
Status
Link

7477
301
https://khrykin.github.io/strategr redirects tohttps://khrykin.github.io/strategr/

  Generated by :no_entry_sign: Danger

@khrykin Thank you! 👍

@serhii-londar 🤟


Fix RuntimeError: can't add a new key into hash during iteration issu…

AR-JDBC's version used:
52.1
version of Rails / ActiveRecord you're running with:
5.2.1
JRuby version (you might include your Java version as well) - jruby -v
jruby-<IP_ADDRESS>
A way to reproduce :)
Start a console with rails c and run this line within the console
100.times { Thread.new { ActiveRecord::Base.connection.execute "SELECT SLEEP(1)" } }
Solution:
Implemented the fix based on this link:
https://stackoverflow.com/a/27643890
include any (related) back-traces (or Java stack-traces) you've seen in the logs
                             []= at org/jruby/RubyHash.java:1033
                mysql_connection at /Users/ptong/.rvm/gems/jruby-<IP_ADDRESS>/gems/activerecord-jdbc-adapter-52.1-java/lib/arjdbc/mysql/connection_methods.rb:8
                  new_connection at /Users/ptong/.rvm/gems/jruby-<IP_ADDRESS>/gems/activerecord-5.2.1/lib/active_record/connection_adapters/abstract/connection_pool.rb:809
         checkout_new_connection at /Users/ptong/.rvm/gems/jruby-<IP_ADDRESS>/gems/activerecord-5.2.1/lib/active_record/connection_adapters/abstract/connection_pool.rb:853
  try_to_checkout_new_connection at /Users/ptong/.rvm/gems/jruby-<IP_ADDRESS>/gems/activerecord-5.2.1/lib/active_record/connection_adapters/abstract/connection_pool.rb:832
              acquire_connection at /Users/ptong/.rvm/gems/jruby-<IP_ADDRESS>/gems/activerecord-5.2.1/lib/active_record/connection_adapters/abstract/connection_pool.rb:793
                        checkout at /Users/ptong/.rvm/gems/jruby-<IP_ADDRESS>/gems/activerecord-5.2.1/lib/active_record/connection_adapters/abstract/connection_pool.rb:521
                      connection at /Users/ptong/.rvm/gems/jruby-<IP_ADDRESS>/gems/activerecord-5.2.1/lib/active_record/connection_adapters/abstract/connection_pool.rb:380
             retrieve_connection at /Users/ptong/.rvm/gems/jruby-<IP_ADDRESS>/gems/activerecord-5.2.1/lib/active_record/connection_adapters/abstract/connection_pool.rb:1008
             retrieve_connection at /Users/ptong/.rvm/gems/jruby-<IP_ADDRESS>/gems/activerecord-5.2.1/lib/active_record/connection_handling.rb:118
                      connection at /Users/ptong/.rvm/gems/jruby-<IP_ADDRESS>/gems/activerecord-5.2.1/lib/active_record/connection_handling.rb:90
               block in evaluate at (irb):1```

we didn't look into support for running AR-JDBC with DB2 systems, however we welcome the effort.
... you should change the branch from master to target 50-stable so it gets fixed for all 5x releases

The stack trace says the issue is in mysql, but the change is to the db2 file. Which system are you using?


Restore sponsors and works with logos on logged-in homepage

Feature Request
Desired behaviour
Need these even though it is redundant
┆Issue is synchronized with this Jira Story
┆Issue Type: Story
┆Fix Versions: Dockstore 1.8
┆Sprint: Seabright Sprint 26 Abalone
┆Issue Number: DOCK-1117

See them on the homepage
API - 1.8.0-beta.6 dockstore status indicator
UI - 2.5.0-beta.1


Ruleset::getIgnorePatterns(): add tests

Suggested changelog entry
N/A
Related issues/external references
This PR is part of a series of PRs expanding the tests for the Ruleset class.

The only comment I have is whether you considered adding exclude patterns with the type attribute? Both with absolute (the default value) and relative.

This tests specifically targets the Ruleset::getIgnorePatterns() method and that method does not make a difference between absolute or relative patterns, so for testing this particular method, it's irrelevant, which is why I didn't include it.
The handling of absolute vs relative patterns should be tested in other tests (which cover methods which do have specific logic to handle this).
Still, I agree it's not a bad idea to have at least one explicit absolute and one explicit relative pattern in these tests. I'll update the PR.

As a sidenote not directly related to this PR, it seems PHPCS doesn't validate the value of the type attribute, and users can pass any value. Maybe there should be some validation? Happy to create a separate issue for this if you agree.

Yes, please open an issue about about that.
This PR series is purely about adding tests for the Ruleset class to unblock #689. In particular, it is about unblocking the change in the error handling of the Ruleset class which is discussed in https://github.com/PHPCSStandards/PHP_CodeSniffer/issues/689#issuecomment-2482992507
This PR series is not a review of the functionality of the Ruleset class, but should allow for more improvements in the future as, once these tests are in, at least we can be relatively sure that existing functionality won't break with future changes.
The error handling change for #689, will also help for adding validation for the type attributes as that shouldn't need to be a blocking error, while, as things are now, it would have to be.
And yes, there are more places in the Ruleset class where invalid things in an XML ruleset are currently silently being ignored, while they would probably benefit from a notice to the end-user. The work for https://github.com/PHPCSStandards/PHP_CodeSniffer/issues/689#issuecomment-2482992507 should unblock all of that.

The handling of absolute vs relative patterns should be tested in other tests (which cover methods which do have specific logic to handle this).
Still, I agree it's not a bad idea to have at least one explicit absolute and one explicit relative pattern in these tests. I'll update the PR.

Yeah, I agree. Thanks for including one explicit absolute and one explicit relative pattern in the tests.

Yes, please open an issue about that.

Here is the issue: https://github.com/PHPCSStandards/PHP_CodeSniffer/issues/727


Is this project dead?

Hi, is this project still maintained? I see no updates for Laravel 5.5, no code changes since months, last twitter updates over a year ago, lots of open issues without any ongoing work.
If this project is dead it would be nice to add a deprecation message to the Readme.md, maybe with a recommendation for an alternative.
Thanks!

I tried to make it keep alive by helping other users. So we are.
Because i'm using laraadmin for my project.

I'm so sorry because laraadmin has enormous potential but it is not possible to consider it if you do not know how much it will be supported, leading developers are alive every month for two or three days then disappear without giving valid information. It's not quite possible to use laraadmin for your business.


Add sendgrid

Adds sendgrid support. The Postmark heroku add-on is no longer available.

Closing for inactivity


Fix Chrome touch & preventDefault

fix double events pointer/touch on Chrome >=55 #303
Unable to preventDefault inside passive event listener due to target being treated as passive. #328
PR Checklist
Please review the guidelines for contributing to this repository.

[ ] I am requesting to pull a topic/feature/bugfix branch (right side). In other words, not master.
[ ] I have run grunt against my changes and both linting and tests pass.
[ ] I have added tests to prove my fix is affective or my feature works. This can be done in the form of unit tests in test/bdd/test.js or a new demo on demo/index.html.
[ ] I have added or edited necessary documentation in the README.md (if appropriate).

Description

Fixes: #

Hi @inuyaksa
Thanks for submitting a pull request.. Note that this broke a lot of tests, and I'm not sure which of the changes is the one responsible.
Can I ask you two things:

Create two pull requests. Each one should handle either #303 or #328.
Make sure that the tests pass, or fix the tests, justifying why the current tests are wrong.

Thanks!


Reduce chance of ICMP packet ID collisions

As reported by @ssoroka in #130: the Pinger.id field is set to a randomly generated number but only in the range 0 to 32767 rather than 0 to<PHONE_NUMBER> (15 bits rather than 31 bits, accounting for sign). Someone running a large number of pings in parallel has a not-insignificant chance of packet ID collision.
https://github.com/go-ping/ping/blob/3300c582a663c5bce1d0ecf1868107da0ae38829/ping.go#L98
The ID field of the Echo struct in golang.org/x/net/icmp [ref] is an int type so we should try and use the full bit space of that.

I'm wondering if it would also be useful to have an optional extra ID in the ICMP message body. You could stuff a UUID into the message body and include that as part of the "is this the right Pinger" logic.

I'm wondering if it would also be useful to have an optional extra ID in the ICMP message body. You could stuff a UUID into the message body and include that as part of the "is this the right Pinger" logic.

@SuperQ is this the purpose of the Tracker field, or do we essentially use it as that anyway?

@SuperQ is this the purpose of the Tracker field, or do we essentially use it as that anyway?

@ssoroka That's a per-packet tracking.

@ssoroka That's a per-packet tracking.

Anyone have any idea why switching to MaxInt32 doesn't work? the spec seems to say this is an int32 field

Anyone have any idea why switching to MaxInt32 doesn't work? the spec seems to say this is an int32 field

Yeah I'm not sure why it's not working... 🤔  Wireshark clearly shows that the echo request packets are leaving and that replies are being received by the OS so it's reasonable to assume that the issue is somewhere in the deserialisation chain.
This is what I observe when pinging Cloudflare:

Yeah I'm not sure why it's not working... 🤔  Wireshark clearly shows that the echo request packets are leaving and that replies are being received by the OS so it's reasonable to assume that the issue is somewhere in the deserialisation chain.
This is what I observe when pinging Cloudflare:

Looks like the problem might be coming from golang.org/x/net/icmp/echo.go:31
// Marshal implements the Marshal method of MessageBody interface.
func (p *Echo) Marshal(proto int) ([]byte, error) {
	b := make([]byte, 4+len(p.Data))
	binary.BigEndian.PutUint16(b[:2], uint16(p.ID))
	binary.BigEndian.PutUint16(b[2:4], uint16(p.Seq))
	copy(b[4:], p.Data)
	return b, nil
}

Looks like the problem might be coming from golang.org/x/net/icmp/echo.go:31
// Marshal implements the Marshal method of MessageBody interface.
func (p *Echo) Marshal(proto int) ([]byte, error) {
	b := make([]byte, 4+len(p.Data))
	binary.BigEndian.PutUint16(b[:2], uint16(p.ID))
	binary.BigEndian.PutUint16(b[2:4], uint16(p.Seq))
	copy(b[4:], p.Data)
	return b, nil
}

It looks like this matches the ICMP spec . https://en.wikipedia.org/wiki/Internet_Control_Message_Protocol#Timestamp
If in fact it's only 16 bits, which it appears to be, then it explains why we're having issues. If that's all there is to play with the only other thing I can think of is starting the sequence numbers at random places in the 2^16 space, rather than always at 0, and making sure they roll over to 0 properly.
we can also use MaxUint16 to double the addresses we get, rather than MaxInt16

It looks like this matches the ICMP spec . https://en.wikipedia.org/wiki/Internet_Control_Message_Protocol#Timestamp
If in fact it's only 16 bits, which it appears to be, then it explains why we're having issues. If that's all there is to play with the only other thing I can think of is starting the sequence numbers at random places in the 2^16 space, rather than always at 0, and making sure they roll over to 0 properly.
we can also use MaxUint16 to double the addresses we get, rather than MaxInt16

confirmed this works, Only downside is the sequence number is visible to the user
> go run .\cmd\ping\ping.go --privileged google.ca
PING google.ca (<IP_ADDRESS>):
24 bytes from <IP_ADDRESS>: icmp_seq=5518 time=28.7935ms ttl=0
24 bytes from <IP_ADDRESS>: icmp_seq=5521 time=28.2054ms ttl=0
24 bytes from <IP_ADDRESS>: icmp_seq=5522 time=43.8518ms ttl=0
24 bytes from <IP_ADDRESS>: icmp_seq=5523 time=37.1334ms ttl=0
24 bytes from <IP_ADDRESS>: icmp_seq=5524 time=38.5358ms ttl=0
24 bytes from <IP_ADDRESS>: icmp_seq=5525 time=28.1251ms ttl=0
24 bytes from <IP_ADDRESS>: icmp_seq=5526 time=28.9425ms ttl=0

--- google.ca ping statistics ---
9 packets transmitted, 7 packets received, 22.22222222222222% packet loss
round-trip min/avg/max/stddev = 28.1251ms/33.369642ms/43.8518ms/5.921461ms
> go run .\cmd\ping\ping.go --privileged google.ca
PING google.ca (<IP_ADDRESS>):
24 bytes from <IP_ADDRESS>: icmp_seq=12030 time=30.4058ms ttl=0
24 bytes from <IP_ADDRESS>: icmp_seq=12031 time=32.5532ms ttl=0
24 bytes from <IP_ADDRESS>: icmp_seq=12032 time=37.57ms ttl=0
24 bytes from <IP_ADDRESS>: icmp_seq=12033 time=36.7702ms ttl=0

--- google.ca ping statistics ---
4 packets transmitted, 4 packets received, 0% packet loss
round-trip min/avg/max/stddev = 30.4058ms/34.3248ms/37.57ms/2.958396ms

confirmed this works, Only downside is the sequence number is visible to the user
> go run .\cmd\ping\ping.go --privileged google.ca
PING google.ca (<IP_ADDRESS>):
24 bytes from <IP_ADDRESS>: icmp_seq=5518 time=28.7935ms ttl=0
24 bytes from <IP_ADDRESS>: icmp_seq=5521 time=28.2054ms ttl=0
24 bytes from <IP_ADDRESS>: icmp_seq=5522 time=43.8518ms ttl=0
24 bytes from <IP_ADDRESS>: icmp_seq=5523 time=37.1334ms ttl=0
24 bytes from <IP_ADDRESS>: icmp_seq=5524 time=38.5358ms ttl=0
24 bytes from <IP_ADDRESS>: icmp_seq=5525 time=28.1251ms ttl=0
24 bytes from <IP_ADDRESS>: icmp_seq=5526 time=28.9425ms ttl=0

--- google.ca ping statistics ---
9 packets transmitted, 7 packets received, 22.22222222222222% packet loss
round-trip min/avg/max/stddev = 28.1251ms/33.369642ms/43.8518ms/5.921461ms
> go run .\cmd\ping\ping.go --privileged google.ca
PING google.ca (<IP_ADDRESS>):
24 bytes from <IP_ADDRESS>: icmp_seq=12030 time=30.4058ms ttl=0
24 bytes from <IP_ADDRESS>: icmp_seq=12031 time=32.5532ms ttl=0
24 bytes from <IP_ADDRESS>: icmp_seq=12032 time=37.57ms ttl=0
24 bytes from <IP_ADDRESS>: icmp_seq=12033 time=36.7702ms ttl=0

--- google.ca ping statistics ---
4 packets transmitted, 4 packets received, 0% packet loss
round-trip min/avg/max/stddev = 30.4058ms/34.3248ms/37.57ms/2.958396ms

Thanks for digging through the Golang sodlib and spec. By playing around and hardcoding values for Pinger.id I've worked out that the largest value it can take is math.MaxUint16 which concurs with that. Also the fact that Wireshark displays the id as 0xFFFF.

Thanks for digging through the Golang sodlib and spec. By playing around and hardcoding values for Pinger.id I've worked out that the largest value it can take is math.MaxUint16 which concurs with that. Also the fact that Wireshark displays the id as 0xFFFF.

... could make random initial sequences a function you could call to enable this if always running it is undesirable.

... could make random initial sequences a function you could call to enable this if always running it is undesirable.

Regarding adding some more entropy to the sequence number, I wonder if by default we should stick to starting from 0 but maybe have e.g. a pinger.UseRandomFirstSeq(true) method, similar to how we have pinger.SetPrivileged(true), for anyone who does want do to that.

Regarding adding some more entropy to the sequence number, I wonder if by default we should stick to starting from 0 but maybe have e.g. a pinger.UseRandomFirstSeq(true) method, similar to how we have pinger.SetPrivileged(true), for anyone who does want do to that.

I think we're on the same page. :D

I think we're on the same page. :D

That said, I'm not sure randomising seq numbers gets us much. If a larger number of pingers are created in a very concurrent environment and two happen to have the same randomly-generated ID then any echo replies will filter through to one of them which will either count it as a genuine reply, or (pending the merge of #130) see it as a duplicate rather than a packet meant for the other pinger.

That said, I'm not sure randomising seq numbers gets us much. If a larger number of pingers are created in a very concurrent environment and two happen to have the same randomly-generated ID then any echo replies will filter through to one of them which will either count it as a genuine reply, or (pending the merge of #130) see it as a duplicate rather than a packet meant for the other pinger.

ah. I think you're right. I think we need to also use the tracker to confirm uniqueness... if we do that maybe it's not necessary to do the rest.

ah. I think you're right. I think we need to also use the tracker to confirm uniqueness... if we do that maybe it's not necessary to do the rest.

which it looks like it already does.

which it looks like it already does.

Cool. Do you want to open the world's shortest PR to change it to math.MaxUint16? (it actually has to be a PR even if one of us opens it since we can't push directly to master 😉)

Cool. Do you want to open the world's shortest PR to change it to math.MaxUint16? (it actually has to be a PR even if one of us opens it since we can't push directly to master 😉)

will do.

will do.


New Standard SQL Data Types Not Supported in gcloud._helpers._rows_from_json() / _CELLDATA_FROM_JSON()

Standard SQL dialect support was added in 0.18.0, but current release does not support queries that return results that include data types that are not supported by Legacy SQL.
E.g. executing the following query using Standard SQL:
SELECT PARSE_DATE('%Y%m%d', '20160810') AS table_date;

results in
rows = query.rows
  File "/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages/gcloud/bigquery/query.py", line 204, in rows
    return _rows_from_json(self._properties.get('rows', ()), self.schema)
  File "/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages/gcloud/bigquery/_helpers.py", line 85, in _rows_
from_json
    converter = _CELLDATA_FROM_JSON[field.field_type]
KeyError: u'DATE'

Not a significant issue since the Legacy SQL Data types will work for my needs, but wanted to report it all the same.

@ToomToom Thanks for the report!  For future reference, here are the docs for the column types returned when querying with the standard SQL dialect.

@tseaver isn't 'DATE' a valid type?
https://cloud.google.com/bigquery/sql-reference/data-types#date-type
It's listed here https://github.com/GoogleCloudPlatform/google-cloud-python/blob/master/google/cloud/bigquery/_helpers.py#L81.

@abovethewater, @ToomToom, @daspecster

PR #2265 added support for the DATE type.
We should be able to add the INT64 and FLOAT64 standard types as trivial aliases for the legacy INT and FLOAT.
The standard BYTES type should be straightforward, if we can figure out how the back-end is expecting the values to be tunneled via JSON (I expect base64, but can't find it in the docs).
Support for both ARRAY and STRUCT are going to require reworking the current implementation, as the field types are no longer constant strings.

#2787 fixed the marshalling of ARRAY and STRUCT types, as well as adding the BOOL alias.
#2803 fixed handling of DATE, DATETIME, TIMESTAMP fields.

AFAICT, the remaining standard SQL types which need support are BYTES (I just verified that the back-end marshals them as base64) and TIME.


Capitalization on MacOS

I'm finding a LOT of odd behavior on my Mac when I uppercase files. I know in part that MacOS is a bit half-hearted in it's distinction of capitalization which leads to a lot of confusion in the first place but vs-code's ability to deal with this seems particular problematic.
In the screenshot above you see me on the latest version of vs-code (see below) trying to bring up the Record.ts file which was previous named record.ts. In the finder it's showing Uppercase version twice and the lowercase version once.

With another file, List.ts -- which has had the same renaming done -- it's a bit different/better:

I could sort of understand that maybe the List.ts situation could come about if you were just caching recent requests and assuming that on the native OS List and list point to different files (they wouldn't in MacOS). But the Record example strikes me as downright odd.

BTW, I wish I could just get MacOS to be truly cap-sensitive but I doubt that will ever happen.

@ksnyde Thanks for the clear write up, this is a duplicate of https://github.com/Microsoft/vscode/issues/12448


Option to validate against private registries

Is there any option to validate images that are coming from private registries?

@adamancini Because outdated runs as a kubectl plugin, it uses your local registry credentials. Private images will be scanned, if you are also logged in to the same registries from your workstation.
We could pull image pull secrets from the podSpec when we scan and use those credentials also/instead. I haven't thought through the feasibility or security implications of this, except to know that we need to think through the security implications before doing it.
Does docker login work for private images now? Or are you looking for a more automated solution that uses the cluster credentials?

I'm able to successfully login to the private registry using docker login locally, but still no luck with validating images. I'm still getting Unable to get image data

Validate local docker login

❯ docker login anecik8sinfrastructure.azurecr.io
Authenticating with existing credentials...

On the other hand, I think it would be a more elegant way to get imagePullSecrets from the podSpec than running docker login. What security implications do you think can block such a feature?


cdc: Carry a request id in events to distinguish events of different requests

What problem does this PR solve?
Problem Summary: Provides a better way for CDC to distinguish Events of different requests in the same stream.
What is changed and how it works?
What's Changed: Adds request_id to CDC ChangeDataRequest and Event, so CDC can use this to distinguish events corresponding different requests.
TiKV doesn't ensure the request_id is unique, just send exactly the value received from the request.
How it Works: Save the ID in the Downstream object when receives request, and set it to the Event's request_id field when sending Event to CDC.
Related changes

[ ] kvproto https://github.com/pingcap/kvproto/pull/582
Need to cherry-pick to the release branch

4.0

Check List
Tests

Unit test (TODO)
Integration test

Release note
(No need)

/release

/release


Documentation suggests column name will be set to data attribute but it is not

Summary of problem or feature request
In the documentation it is written that the column name attribute will be set to the same value as the data attribute if being omitted. This does not seem to be the case though, as can be seen here. The name attribute is only set (to a correct value) if an array index is given. For snippets as given below, it is not set and therefore search and other functions don't work.
Code snippet of problem
No name field:
protected function getColumns()
{
    return [
        ['data' => 'id', 'title' => trans('my.model.id')],
        ['data' => 'name', 'title' => trans('my.model.name')],
        ['data' => 'url', 'title' => trans('my.model.url')],
    ];
}

With name field (untested but from the code it should have one):
protected function getColumns()
{
    return [
        'id'    => ['title' => trans('my.model.id')],
        'name'  => ['title' => trans('my.model.name')],
        'title' => ['title' => trans('my.model.url')],
    ];
}

System details

Laravel Version: 5.6
Laravel-DataTables Version: latest

@Namoshek good catch. Will try to patch this as soon as I can. If you can, please do not hesitate to submit a PR. Thanks!

I already thought about how it could be solved but I couldn't find a nice one-liner, so I gave up. 😞
But I'll have another look in the evening then. 👍


Add startsWith() endsWith() JavaScript Examples to String() methods

Add startsWith() and endsWith() JavaScript examples to the startsWith() and endsWith() String method pages

@irenesmith, @estelle, @chrisdavidmills I see that there are examples in the repo, but not on the corresponding wiki pages. Can this issue be closed?

Oops, they are in the wiki pages. Closing.


"Edit comment" button is only injected for a first post

After recent changes (https://github.com/sindresorhus/refined-github/pull/3407 ?) the "Edit" button is only visible for initial post. This is like that after initial page loading (no interaction with it):
First post

Second and other posts

I've tried to reload the page a couple of times with "Disable cache" checkbox enabled in devtools.

Duplicate of https://github.com/sindresorhus/refined-github/issues/3279

Sorry if I created an extra report 😳
I confirm that everything is OK now. Thank you for your work!


Improve consistency of UG

Ensure command examples are consistent and added updated screenshots of app.

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
see 8 files with indirect coverage changes


Update EventEmitter import for es module compatibility

What's Changing and Why
Changed the packages/core/src/index.js import of the EventEmitter class.
Was: import EventEmitter from "events"
Now: import * as EventEmitter from "events"
This change was required for building a project utilizing Jimp custom to build a slimmer version of the library. The project is built as a module with target esnext on Node20 and Typescript using Vite.
Without this fix, vite build will produce the following error:
error during build:
RollupError<EMAIL_ADDRESS>(29:7): "default" is not exported by "node_modules/events/events.js", imported by<EMAIL_ADDRESS>file: [...]/node_modules/@jimp/core/es/index.js:29:7

The events package is not an es module yet, see Issue 86 and converting it to one is not on the roadmap as far as I can tell. Therefore, this fix should be applied to Jimp directly.
What else might be affected
Compatibility may be affected when building Jimp not as an es module.
Tasks

[ ] Add SemVer Label

event emitter usage has been removed, it never really made sense for this library (unless someone convinces me)


pools of size 0 should return transient connections/sessions

In case a pool does not contain any cached connections or sessions, it might make sense to establish transient connections and sessions when a caller tries to get a connection or a session from the pool.

Hey @jxsl13 ,
I want to pick this up.
Is it okay to pick this up as a good first time issue?

Sure, but I will give lots of feedback, as I have already an idea how this should be handled.

Sure.
I am really looking forward to learn from your feedbacks.
I'll have a detailed look at the codebase.
I am still unsure of the exact problem statement, but in simple words I believe that in case the connection pool has no connections left i.e pool size of 0 , then if callers tries to connect, we will return some temporary connection to the caller.
That connection will not be stored in the pool connections.
I'll look at the codebase once.
But do let me know in case I'm missing anything.

the problem is slightly different.
You define a connection pool of size x. In case that size is 0, all connections of this pool should be temporary (transient) connections.
Currently if the connection pool has like 10 connections and all of those connections are in use, then the next GetConnection() will block until someone else put a connection back into the pool. This behavior should stay the same.

When closing the pool, I would like to scale the pool down to 0 and still allow callers to fetch temporaty connections.
This might allow for the pools to either ack or nack messages before they are shut down.
Maybe the whole idea is not how that should work, I dunno, gotta play around a little bit with the code.
The more I think about this problem the less this scaling down to 0 makes sense...
Maybe not a good first issue.


[DC-2272] ethnicity_source_concept_id and ethnicity_source_value are not broken down in registered tier

Hi @lrwb-aou, they're failing locally for me as well. Looked at it earlier today, but haven't figured it out yet. Will try again tomorrow.

No problem.  Just didn't want you to be waiting on my review.

@lrwb-aou Thanks for taking a look. Looks like I was missing a concept insert in the integration test. Hopefully it passes now.

@lrwb-aou Thanks for taking a look. Looks like I was missing a concept insert in the integration test. Hopefully it passes now.

Just noticed the copy_vocab_tables method that you recently created. Very convenient, could have maybe avoided this issue.

I wanted to make sure it could handle someone selecting a race and an ethnicity concept, so I experimented with adding a test case. Look at the patch and let me know what you think repopulate_person_post_deid_test_patch.txt .

I think it looks great, much cleaner. You can commit your patch or I can if your prefer.

I wanted to make sure it could handle someone selecting a race and an ethnicity concept, so I experimented with adding a test case. Look at the patch and let me know what you think repopulate_person_post_deid_test_patch.txt .

I think it looks great, much cleaner. You can commit your patch or I can if your prefer.

Your PR. If you would like to commit it, you should.

Sounds good, just added it


I can't see light sources

Goodnight. I have a problem regarding light sources. When I place a light source in an elevated area, the light does not appear. It's as if the light is restricted by a wall. In my case, this is only happening with light source - if a token is emanating light, the light will spread across the area normally.

Try going into the light configuration and setting the elevation to some value above the terrain. You might have to move the light around after saving it to force it to refresh, but for me, that makes the light appear.
The light should refresh when you change elevation—I will look into that bug.
It is difficult to know if a default light is supposed to be at elevation 0 or at elevation infinity. I will look into forcing it to be considered infinitely high, which would help this situation but may cause certain other issues. For example, an infinitely high light does not cause much shadows (depending on if it is exactly overhead, of course) while a light at elevation 0 would cause infinite shadows for most default wall setups.

In v0.5.10, I forced infinite lights to use a really large integer for elevation. Conceptually, I think it is more intuitive that lights with infinite elevation are treated as such. We will see if it causes too much confusion, given that Foundry really treats lights as if they are just slightly above the canvas .

I'm still having this issue.  Fully updated on Foundry and the module.  I tried increasing the height of the light manually but it did not work.  Any idea?


Open... and Open Workspace pops up a menu, which is dismissed immediately

code-server version:
server/development linux-x64 node-v8.15.0

OS Version:
Ubuntu 18.10, running on docker for mac, container image is
codercom/code-server:latest

Description

Steps to Reproduce
Here is the video, it should really help you how to reproduce the problem:
https://github.com/KeyboardNerd/keyboardnerd.github.io/blob/master/Screen Recording 2019-03-22 at 6.12.37 PM.mov

@KeyboardNerd can you try running docker pull codercom/code-server:latest?

and then run the docker command again?


Longest Common Subsequence implementation in JAVA | Dynamic Programming | Strings

Hi @TechVine , can you please assign this issue to me and add Hacktoberfest labels !!

@TechVine can you please assign this issue to me Pls bhaiya want to contribute

Sir can you assign this issue to me?

Sir please assign this issue to me I have an optimised solution.

can you assign this task to me?

Hello @TechVine  sir please assign this issue to me so that i will be able to solve this issue.

Hello @TechVine sir can you assign this task to me and I will solve it.

Can you assign this issue to me?


Add Default UI-Schema Generator

Please review and merge.

I've added some notes which you might wanna have a look at. Otherwise this looks good. I will merge this as soon as you have looked at the comments.

Thanks for your comments ;)