fix: add user/pwd when cloning private env repos

Submitter checklist

[ ] Change is code complete and matches issue description.
[ ] Change is covered by existing or new tests.

Description
Special notes for the reviewer(s)
Which issue this PR fixes
fixes #

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign jstrachan
You can assign the PR to them by writing /assign @jstrachan in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/approve

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: jstrachan
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [jstrachan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Update composer.json

Please support php >=5.6

See this instead. It's a fork of this repo that supports php >= 5.6


support bool and assign

Codecov Report

Merging #75 (bdddab9) into main (5f4f3ee) will increase coverage by 0.04%.
The diff coverage is 95.45%.

@@            Coverage Diff             @@
##             main      #75      +/-   ##
==========================================
+ Coverage   88.91%   88.96%   +0.04%
==========================================
  Files          28       28
  Lines        2960     2982      +22
==========================================
+ Hits         2632     2653      +21
- Misses        328      329       +1

Impacted Files
Coverage Δ

optpy-std/src/object.rs
78.94% <ø> (ø)

optpy-std/src/value.rs
82.79% <80.00%> (-0.07%)
:arrow_down:

optpy-generator/src/lib.rs
87.14% <100.00%> (+0.05%)
:arrow_up:

optpy-parser/src/expression/types.rs
82.00% <100.00%> (+0.36%)
:arrow_up:

tests/test-std.rs
98.67% <100.00%> (+0.06%)
:arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


reset admission check after deactivation

What type of PR is this?
/kind bug

What this PR does / why we need it:
Which issue(s) this PR fixes:

Fixes #3346
Special notes for your reviewer:
Does this PR introduce a user-facing change?
NONE

/ok-to-test

@KPostOffice PTAL at the failures, maybe we could include as bugfix in 0.9.

cc @PBundyra for a review pass. It seems the failing integration tests are for BookingExpired. PTAL.

cool to see all integration and e2e tests passing already 👍

LGTM, but let me check with @PBundyra if there are more comments

LGTM
Thank you @KPostOffice
/hold cancel

/lgtm

/release-note-edit
Fix the flow of deactivation for workloads due to rejected AdmissionChecks.
Now, all AdmissionChecks are reset back to the Pending state on eviction (and deactivation in particular),
and so an admin can easily re-activate such a workload manually without tweaking the checks.

/approve
/cherry-pick release 0.9

@KPostOffice can you work on preparing the cherry-pick?
You can use the hack/cherry_pick_pull.sh script.


Emphasis in titles trips up double→single quotation marks conversion if using JSON db

Emphasized/italicized strings in titles trip up the conversion from (curly) double to (curly) single quotation marks carried out when the whole title is wrapped in an outer set of quotation marks – but only when using a JSON bib db. (No such problem with, at least, YAML and biblatex bib dbs.)
pandoc and pandoc-citeproc: latest dev
First example, using a yaml bib db:
cat > test.yaml << EOT
references:
- id: item1
  type: article-journal
  author:
  - family: Doe
    given: Jane
  issued:
    - year: 2018
  title: '“Some *important* quote” in a title'
EOT

pandoc -s -F pandoc-citeproc -t plain << EOT

Foo [@item1].

# References {-}

---
bibliography: test.yaml
...
EOT

Expected = actual output:
Foo (Doe 2018).

REFERENCES

Doe, Jane. 2018. “‘Some _Important_ Quote’ in a Title.”

Second, the same with a (content-wise identical) JSON db.
cat > test.json << EOT
[
  {
    "author": [
      {
        "family": "Doe",
        "given": "Jane"
      }
    ],
    "id": "item1",
    "issued": {
      "date-parts": [
        [
          2018
        ]
      ]
    },
    "title": "“Some <i>important</i> quote” in a title",
    "type": "article-journal"
  }
]
EOT

pandoc -s -F pandoc-citeproc -t plain << EOT

Foo [@item1].

# References {-}

---
bibliography: test.json
...
EOT

Expected output: as above
Actual output:
Foo (Doe 2018).

REFERENCES

Doe, Jane. 2018. ““Some _Important_ Quote” in a Title.”

FWIW, with a biblatex db (below), output is as expected, i.e., contains single quotes, too.
@article{item1,
  author = {Doe, Jane},
  date = {2018},
  title ={“Some \textit{important} quote” in a title}
}

Output from pandoc 2.11 is as expected now. Closing.


-----END CERTIFICATE-----
certificate_fingerprint: 9d18413dff45805dee690940482b0b...
driver: lxc
driver_version: 3.0.3
kernel: Linux
kernel_architecture: x86_64
kernel_version: 4.15.0-45-generic
server: lxd
server_pid: 5224
server_version: 3.0.0
storage: ""
storage_version: ""
server_clustered: true
server_name: lxd11vgtult`

We have 11 lxd servers and we are facing one huge problem. From lxc servers we push our old containers to our array storage and then we put them in lxd. (we create container with same lsb-release in lxd, stop it, delete rootfs, paste old containers rootfs in that one) and after these steps we always run command lxc publish to rewrite permissions, because lxd uses 100000, with 9 lxd servers out of 11 it works fine, but last two servers doesn't rewrite permissions and owner like it should do. Can you suggest something, because i can't find anything wrong in server.
thank you in advance.
I'm new here so sorry if somethings wrong let me know how to correctly write.

You should make sure all your servers are up to date, 3.0.0 is out of date, assuming you're running Ubuntu (looks like it based on kernel), you should get 3.0.3.
I'm also not sure what you're doing with lxc publish here. All that this command does is turn a container into an image, the image itself should be unshifted, but the container will normally not be altered as part of that. So maybe you're somehow relying on a bug from an older LXD or something?
Assuming that what you're trying to do is import unshifted containers into LXD, the way you'd normally do that is:

lxc init some-name --empty -c security.privileged=true
Make sure that /var/lib/lxd/containers/some-name is mounted
Copy the content into /var/lib/lxd/containers/some-name/rootfs/
lxc config unset some-name security.privileged
lxc start some-name

Or you could use the lxd-p2c tool which lets you remotely import a container into LXD by passing the URL of the target server, the name you want for the container and the path to the current unshifted rootfs. It will then use the migration API to transfer the content.

(Closing as report is on out of date LXD and seems to be relying on undefined internal behaviors)

Yes, we're runing 3.0.0, but we don't have problems with other 9 lxd nodes in cluster. And we always did (with about 30 containers from LXC) to rewrite permisions.
To tell you step by step, it should go like this.
copy whole container from LXC to array storage.
Create container in LXD. Stop it. Delete whole "rootfs". Paste LXC containers rootfs in there and after that just run command lxc publish containers-name.
And after it completes it makes an image of that container and also rewrites all permissions and oweners from root's - 1000 (if i'm correct), to lxd root's - 100000. And it works with other 9 nodes perfectly in 3.0.0 but does not on the new ones. And i'm asking this, because we can't add new nodes to cluster with newer version of 3.0.3 because we get error like this: "Error: Failed to configure cluster: failed to request to add node: API version mismatch: cluster has 81" even thou i understand it like update for cluster not like newer version of it, but we get error.

I'm sorry but we can't support what you're currently doing.
You are almost certainly relying on a shifting bug to get your current behavior, lxc publish isn't the way to get the container to shift/unshift, what you're describing sounds like a bug.
I told you about the proper way to do what you're doing above, if you still hit the same issue when using lxd-p2c or the lxc init --empty approach I described, then we can investigate it further (though would insist on this being reproduced on 3.0.3 first).


build error

@timmolter looks like the JVM died on the latest build, something to do with "Error while generating Javadoc".  Can you kick it off again?

done


Linting

@jhamman I think there's a small problem with the pre-commit tools interacting with one another - my cmd line output is given below but no files are changed for me to commit. I've already run pre-commit run --all-files a few times to get to this point (those changes are what is committed in this PR), but now this happens every time. I think this means that black and isort are undoing each others changes to datatree/datatree.py? If I delete isort from the pre-commit-config.yaml then black passes.
(py38-mamba) tom@pop-os:~/Documents/Work/Code/datatree$ pre-commit run --all-files
Trim Trailing Whitespace.................................................Passed
Fix End of Files.........................................................Passed
Check Yaml...............................................................Passed
isort....................................................................Failed
- hook id: isort
- files were modified by this hook

Fixing /home/tom/Documents/Work/Code/datatree/datatree/datatree.py

black....................................................................Failed
- hook id: black
- files were modified by this hook

reformatted datatree/datatree.py
All done! ✨ 🍰 ✨
1 file reformatted, 8 files left unchanged.

blackdoc.................................................................Passed
flake8...................................................................Failed
- hook id: flake8
- exit code: 1

datatree/tests/test_dataset_api.py:166:80: E501 line too long (87 > 79 characters)
...

(py38-mamba) tom@pop-os:~/Documents/Work/Code/datatree$ git status
On branch linting
Your branch is up to date with 'origin/linting'.

Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git restore <file>..." to discard changes in working directory)
	modified:   .pre-commit-config.yaml

Untracked files:
  (use "git add <file>..." to include in what will be committed)
	.idea/
	datafiles/
	datatree/accessors.py
	design_notes.md
	setup.cfg

no changes added to commit (use "git add" and/or "git commit -a")

(there are more flake8 and mypy suggestions/warnings later but I'll try and deal with them afterwards)

Nice! The remaining failure seems to be related to mypy. We could turn that off for now, or you can make those fixes here.

The remaining failure seems to be related to mypy. We could turn that off for now, or you can make those fixes here.

Yes - I'm currently trying to fix the mypy failures, but I don't understand a lot of them. What I think I will do is turn off mypy for now and open a separate PR to discuss changes needed to make it pass locally.


[Improvement] test more Iceberg versions in spark connector

What would you like to be improved?
For now, Iceberg versions are compiled and test in 1.4.3, we'd better test 1.3, and 1.5 versions.
How should we improve?
It's expensive to add another -PicebergVersion to run test, I suggest to test Iceberg 1.3 in Spark3.3,  1.4 in Spark3.4, 1.5 in spark3.5

@jerryshao @caican00 WDYT?

@jerryshao @caican00 WDYT?

@jerryshao @caican00 WDYT?

test Iceberg 1.3 in Spark3.3, 1.4 in Spark3.4, 1.5 in spark3.5

FYI:
The spark connector does not contain the iceberg runtime jar.  Users generally use the iceberg runtime jar maintained by themselves.
It  seems unnecessary, and since iceberg1.4 and 1.5 both support spark3.3, spark3.4, and spark3.5, just testing Iceberg 1.3 in Spark3.3, 1.4 in Spark3.4, 1.5 in spark3.5  seems not comprehensive enough.


Getting an error: can't resolve '@angular/cdk' in ...

In step 6, running "ng build" fails with the above mentioned error.
Managed to resolve this by running:
npm install --save @angular/cdk
(or alternatively, update package.json)

This is a breaking change in @angular/material 2.0.0 beta 8 (code last updated to 2.0.0 beta 2)

#249  fix this issue


Showing modal after clicking a bubble

Modal shows intent name, intent frequency, and intent associates.
Model has buttons to close itself and direct to Voiceflow to add the intent.
Model appears on the bottom left, which is not ideal. Will improve that later.

Handled the merge conflict, so someone can review the PR when available.


Change owner error

node:events:497
throw er; // Unhandled 'error' event
^
ReferenceError: MessageSelectMenu is not defined
at Client. (D:\Discord-TempVoice-Bot-master\tempVCs.js:743:25)
at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
Emitted 'error' event on Client instance at:
at emitUnhandledRejectionOrErr (node:events:402:10)
at process.processTicksAndRejections (node:internal/process/task_queues:84:21)
Node.js v20.16.0

Hi! Thanks for letting me know about this problem.
I missed updating two functions when I upgraded to Discord.js v14 in the previous version.
This has now been fixed!


Error in GCP Composer

When I run in the composer it returns that.
[2020-04-16 21:27:07,642] {taskinstance.py:862} INFO - Executing <Task(DbtRunOperator): dbt_run> on 2020-04-16T21:26:19.688956+00:00
[2020-04-16 21:27:07,643] {base_task_runner.py:133} INFO - Running: ['airflow', 'run', 'dw_dbt', 'dbt_run', '2020-04-16T21:26:19.688956+00:00', '--job_id', '1004', '--pool', 'default_pool', '--raw', '-sd', 'DAGS_FOLDER/dw_dbt/dw_dbt_airflow.py', '--cfg_path', '/tmp/tmph61y8y0e']
[2020-04-16 21:27:09,486] {base_task_runner.py:115} INFO - Job 1004: Subtask dbt_run [2020-04-16 21:27:09,486] {settings.py:254} INFO - settings.configure_orm(): Using pool settings. pool_size=5, max_overflow=10, pool_recycle=1800, pid=1044
[2020-04-16 21:27:09,800] {base_task_runner.py:115} INFO - Job 1004: Subtask dbt_run [2020-04-16 21:27:09,800] {app.py:53} WARNING - Using default Composer Environment Variables. Overrides have not been applied.
[2020-04-16 21:27:09,803] {base_task_runner.py:115} INFO - Job 1004: Subtask dbt_run [2020-04-16 21:27:09,802] {configuration.py:593} INFO - Reading the config from /etc/airflow/airflow.cfg
[2020-04-16 21:27:09,818] {base_task_runner.py:115} INFO - Job 1004: Subtask dbt_run [2020-04-16 21:27:09,818] {settings.py:254} INFO - settings.configure_orm(): Using pool settings. pool_size=5, max_overflow=10, pool_recycle=1800, pid=1044
[2020-04-16 21:27:10,185] {base_task_runner.py:115} INFO - Job 1004: Subtask dbt_run [2020-04-16 21:27:10,184] {default_celery.py:90} WARNING - You have configured a result_backend of redis://airflow-redis-service.default.svc.cluster.local:6379/0, it is highly recommended to use an alternative result_backend (i.e. a database).
[2020-04-16 21:27:10,187] {base_task_runner.py:115} INFO - Job 1004: Subtask dbt_run [2020-04-16 21:27:10,187] {__init__.py:51} INFO - Using executor CeleryExecutor
[2020-04-16 21:27:10,188] {base_task_runner.py:115} INFO - Job 1004: Subtask dbt_run [2020-04-16 21:27:10,188] {dagbag.py:407} INFO - Filling up the DagBag from /home/airflow/gcs/dags/dw_dbt/dw_dbt_airflow.py
[2020-04-16 21:27:10,194] {base_task_runner.py:115} INFO - Job 1004: Subtask dbt_run /opt/python3.6/lib/python3.6/site-packages/airflow_dbt/operators/dbt_operator.py:43: PendingDeprecationWarning: Invalid arguments were passed to DbtRunOperator (task_id: dbt_run). Support for passing such arguments will be dropped in Airflow 2.0. Invalid arguments were:
[2020-04-16 21:27:10,194] {base_task_runner.py:115} INFO - Job 1004: Subtask dbt_run *args: ()
[2020-04-16 21:27:10,194] {base_task_runner.py:115} INFO - Job 1004: Subtask dbt_run **kwargs: {'profile_dir': './dw-dbt/profiles'}
[2020-04-16 21:27:10,195] {base_task_runner.py:115} INFO - Job 1004: Subtask dbt_run   super(DbtBaseOperator, self).__init__(*args, **kwargs)
[2020-04-16 21:27:10,619] {base_task_runner.py:115} INFO - Job 1004: Subtask dbt_run [2020-04-16 21:27:10,619] {cli.py:545} INFO - Running <TaskInstance: dw_dbt.dbt_run 2020-04-16T21:26:19.688956+00:00 [running]> on host airflow-worker-67465d97c9-v7q2l
[2020-04-16 21:27:10,685] {base_task_runner.py:115} INFO - Job 1004: Subtask dbt_run [2020-04-16 21:27:10,684] {dbt_hook.py:86} INFO - dbt run --models l1_autorizacoes
[2020-04-16 21:27:10,835] {taskinstance.py:1059} ERROR - [Errno 2] No such file or directory: 'dbt': 'dbt'
Traceback (most recent call last)
  File "/usr/local/lib/airflow/airflow/models/taskinstance.py", line 930, in _run_raw_tas
    result = task_copy.execute(context=context
  File "/opt/python3.6/lib/python3.6/site-packages/airflow_dbt/operators/dbt_operator.py", line 61, in execut
    self.hook.run_cli('run'
  File "/opt/python3.6/lib/python3.6/site-packages/airflow_dbt/hooks/dbt_hook.py", line 93, in run_cl
    close_fds=True
  File "/opt/python3.6/lib/python3.6/subprocess.py", line 729, in __init_
    restore_signals, start_new_session
  File "/opt/python3.6/lib/python3.6/subprocess.py", line 1364, in _execute_chil
    raise child_exception_type(errno_num, err_msg, err_filename
FileNotFoundError: [Errno 2] No such file or directory: 'dbt': 'dbt

Hey @pedrofelipest,
Noticed you've closed this so you've probably already worked it out, but just for prosperity, this is the error you get when dbt isn't on your PATH. The operator just calls the dbt CLI (there's no other way to invoke it).
If it's not on your PATH you can set dbt_bin to the absolute path of the dbt CLI.
Hope you find this operator useful, and let us know if you have any feedback!
Regards,
Andrew


R# 2022.3 Support Please :D

Thank you and Happy Holidays 🎄⛄🎅

Enjoy! Have just published it. Got a delay as I was working on adding Rider support as well, so broke things right before the release 🤣 But will add Rider version a bit later after all.
Have great holidays as well 😊

@zvirja The artifact of 7.3 does not have the libgit2 native libraries included. I get a DLL not found exception when trying to perform the git modified cleanup process.
Performing a manual pack on the project creates a nupkg with the libraries.

Wow, let me please investigate that!

@theit8514 I've just pushed updated version of plugin. Thank you for pointing to the issue, it was quite tricky actually 😉
The version 7.3.1 should appear soon after the plugin verification.


Created funtion definition for EDA of numeric columns

I have added function documentation for the explore_numeric_columns() function. @lephanthuymai  please review and merge the code if it looks fine.

Hi Rahul,
The change looks good. I talked to Tiff the other day and she said we should always return some values, so we can't return None. Probably just return a list of plots?
Thanks.

Hi Rahul,
The change looks good. I talked to Tiff the other day and she said we should always return some values, so we can't return None. Probably just return a list of plots?
Thanks.

I have made the change. Could you have a look and approve if it looks good?


Items value not Displaying properly

Hi. I've been looking for something like this and right now I'm facing this problem.
I have this as a code:
<paper-dropdown-input label="Members" items='[[members]]' filter-property="name"> 			<dom-repeat items="{{members}}" as="member"> 		        <paper-item>{{member.name}}</paper-item>	 		    </dom-repeat> 		</paper-dropdown-input>
And when I click the dropdown it immediately shows 'No Results Found' and no items are shown. Only when I type something on the input do the items appear. But even then the items are shown as
[object Object]. How do I fix this?

I think you got very close, and it seems your use case closely resembles the custom template demo, so you could look there for answers:
3 things to consider:

the <dom-repeat> needs to be wrapped into a <template>.
The element needs a template if you want to use a custom dropdown
Inside that template, the data you passed to items is filtered and exposed as items, not members.
the <dom-repeat>'s content itself also needs to be wrapped in a <template>.
This is an API change since Polymer 2.x.

With these 3 changes, and provided members resembles something like [{name: "something"}, {name: "something else"}], you should be good to go with this code:
<paper-dropdown-input label="Members" items="[[members]]" filter-property="name">
  <template>
    <dom-repeat items="[[items]]" as="member">
      <template>
        <paper-item>{{member.name}}</paper-item>
      </template>
    </dom-repeat>
  </template>
</paper-dropdown-input>

Please let me know if you have any luck with this.

@Juravenator Yes! That works perfectly. Btw, is there anyway I can get the selected value and pass it to a function when I on-tap a button?


Cleaner: ELF files are executable on Linux

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same change?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests for your changes? Here's an example.
[x] Have you successfully run brew tests with your changes locally?

Breaking some Linux tests: https://travis-ci.org/Homebrew/brew/jobs/305958848

The binary files in test/support/fixtures/tarballs/testball-0.1.tbz are Mach-O executables.
We can add testball-0.1-linux.tbz with ELF executables.
Should I rename testball-0.1.tbz to testball-0.1-mac.tbz?

brew tests still failing here but the approach in general looks sound.

Fixed the test failures.

Thanks again @sjackman!

Thanks again for merging, Mike!


Mb 11451 dp3 rds

MB-11451 Update loadtest RDS certs
Summary
This adds a new variable to the env files for the RDS certificate (DB_SSL_ROOT_CERT). Currently only adding to loadtest.
This is updating how the dp3 sites are deployed by cleaning up the million steps and parameterizing things where possible. Currently, only loadtest is updated.
Demo and Exp will have these updates done shortly as well.

Warnings

:warning:
Please add the JIRA issue key to the PR title (e.g. MB-123)

  Generated by :no_entry_sign: dangerJS against dfb4c2ab14f0955ec582867fc8dd885d05db4fec


androidenv: android licenses

Motivation for this change
Android SDK requires accepted licenses, those are save in specific location and looks like android tools construct paths based on their location, rather than env variables (which means they are looking in nix store and user is not able to add them setting environment variable [at least I didn't find how to do it]).
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Notify maintainers
cc @svanderburg

who would be right person to check here?

cc @svanderburg

@spinus @svanderburg Is this PR still applicable - or does the user approval via config.android_sdk.accept_license = true; make this not needed?
@spinus Your insight may help in PR #82118 - where I update the package-related generated expressions. Would you please consider having a look at that PR, and prepare a branch for any changes you may envisage. Thanks!

@lucafavatella sorry for delay. I've seen your PR but I was not skilled yet with it to provide constructive feedback. Thank for pushing this. Looks like good chunk of work, I guess I'm closing this one in that case. Cheers.


Added scrollbars to text windows

Modified css to display overflown text using scrollbars instead of just cutting the text.

Thanks @kaniblu !


fix error emails that are not being sent

Coverage increased (+0.2%) to 89.016% when pulling 24b74d01ce43a7ab8aa7f5d1883db26ff913aae1 on bugfix/error-mails into 2d6b10941ddda3b12edba3bbd07a69e78048e973 on main.


PowerShell on FreeBSD

Is there interest in PowerShell on FreeBSD?
I have been following dotnet/runtime for a while and building the preview releases on FreeBSD.
I was curious to see if PowerShell would build and did a little hacking to get things to compile.
There weren't many changes needed, but of course that's no guarantee that everything is
working correctly. Certainly enough to get going though.
[jason@freebsd11 ~/src/PowerShell/src/powershell-unix]$ ../../.dotnet/dotnet --info
.NET Core SDK (reflecting any global.json):
 Version:   5.0.100-preview.3.20216.6
 Commit:    9f62a32109

Runtime Environment:
 OS Name:     FreeBSD
 OS Version:  11
 OS Platform: FreeBSD
 RID:         freebsd.11-x64
 Base Path:   /usr/home/jason/src/PowerShell/.dotnet/sdk/5.0.100-preview.3.20216.6/

Host (useful for support):
  Version: 5.0.0-preview.3.20214.6
  Commit:  b037784658

.NET SDKs installed:
  5.0.100-preview.3.20216.6 [/usr/home/jason/src/PowerShell/.dotnet/sdk]

.NET runtimes installed:
  Microsoft.AspNetCore.App 5.0.0-preview.3.20215.14 [/usr/home/jason/src/PowerShell/.dotnet/shared/Microsoft.AspNetCore.App]
  Microsoft.NETCore.App 5.0.0-preview.3.20214.6 [/usr/home/jason/src/PowerShell/.dotnet/shared/Microsoft.NETCore.App]

To install additional .NET runtimes or SDKs:
  https://aka.ms/dotnet-download
[jason@freebsd11 ~/src/PowerShell/src/powershell-unix]$ bin/Release/netcoreapp5.0/freebsd-x64/pwsh
PowerShell 7.1.0-preview.1-45-gba53621894a030c2f5dfce0db81fa1e09408fd2f
Copyright (c) Microsoft Corporation.

https://aka.ms/powershell
Type 'help' to get help.

PS /usr/home/jason/src/PowerShell/src/powershell-unix> Get-Host

Name             : ConsoleHost
Version          : 7.1.0-preview.1
InstanceId       : 18a64041-fd7b-49ab-bd93-76d3e9a915e0
UI               : System.Management.Automation.Internal.Host.InternalHostUserInterface
CurrentCulture   :
CurrentUICulture :
PrivateData      : Microsoft.PowerShell.ConsoleHost+ConsoleColorProxy
DebuggerEnabled  : True
IsRunspacePushed : False
Runspace         : System.Management.Automation.Runspaces.LocalRunspace

PS /usr/home/jason/src/PowerShell/src/powershell-unix> $PSVersionTable

Name                           Value
----                           -----
PSVersion                      7.1.0-preview.1
PSEdition                      Core
GitCommitId                    7.1.0-preview.1-45-gba53621894a030c2f5dfce0db81fa1e09408fd2f
OS                             FreeBSD 11.3-RELEASE FreeBSD 11.3-RELEASE #0 r349754: Fri Jul  5 04:45:24 UTC 2019     root@releng2.nyi.freebsd.org:/usr/obj/usr/src/sys/GENERIC
Platform                       Unix
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0…}
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>
WSManStackVersion              3.0

PS /usr/home/jason/src/PowerShell/src/powershell-unix>

Work previously done by @mateusrodrigues helped, thanks.

We need to get .Net support before do anything here.
Current status https://github.com/dotnet/runtime/issues/14537

https://github.com/dotnet/runtime/blob/master/docs/workflow/README.md shows FreeBSD
and https://github.com/dotnet/runtime/blob/master/docs/workflow/requirements/freebsd-requirements.md shows instructions for cross-build via Linux.

After .Net team announce FreeBSD support you can open an issue in PowerShell repo using Disribution support template.

After .Net team announce FreeBSD support you can open an issue in PowerShell repo using Disribution support template.

So this announcement is going to happen soon? Or rather "if"?

Current supported OSes https://github.com/dotnet/core/blob/master/release-notes/5.0/5.0-supported-os.md
you should ask .Net team about supporting new OSes.


fix: add try catch

rt

Codecov Report

Merging #147 (4f518ec) into master (52c3516) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #147   +/-   ##
=======================================
  Coverage   81.56%   81.56%
=======================================
  Files          34       34
  Lines        2755     2755
  Branches      782      782
=======================================
  Hits         2247     2247
  Misses        457      457
  Partials       51       51

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52c3516...4f518ec. Read the comment docs.


New version: Tencent.QiDian version <IP_ADDRESS>51

Created by 🥟 Dumplings in Run #3438.
Microsoft Reviewers: Open in CodeFlow

Automatic Validation ended with:

Installer Verification Analysis Context Information:
Installer https://dldir1v6.qq.com/qqfile/crm/qidian/QiDian<IP_ADDRESS>51.exe
Scan request id: '768f2b8b-a018-46d1-97ca-078af1b32944'
Error information: BlockingDetectionFound

2/21/2024 10:35:11 AM

Installer Validation

(Automated response - build 776.)

This might be due to a network block of data centers, to prevent automated downloads.
(Automated response - build 776.)


The trailing comments sometimes get lost.

The ddoc page here  http://dlang.org/spec/ddoc.html says "Multiple documentation comments applying to the same declaration are concatenated" and this example demos it with block and trailing:
/** documentation for g */
int g; /// more documentation for g

libdparse does not seem to recognize this:
        node.comment = start.comment;
        if (node.comment is null)
            node.comment = start.trailingComment;

That's from https://github.com/Hackerpilot/libdparse/blob/master/src/dparse/parser.d#L3911 but the same pattern appears throughout the parser.
There also seem to be a few cases where the trailing comment just gets lost too, like in parsing an AliasDeclaration: https://github.com/Hackerpilot/libdparse/blob/master/src/dparse/parser.d#L84
And I don't see it attached on the initializer list either, though I might be missing something there, I don't know your code very well yet.
With this test case:
/// test
alias cool = string; /// which comment is there?

I ran it through the visitor and checked AliasDeclaration.comment and it only gave me "/// test". If I take the top comment off, the comment is null.
My guess is what you'll want to do is remove those if(null) conditions and use ~= instead, but the whole allocation business probably makes that a bit more than it seems...

I have a fix coded up for your alias example.
The docs for your variable declaration example are not lost, but they're not where you expect them either. dscanner --ast test.d | xmllint --format gives output like this:
<?xml version="1.0"?>
<module>
  <declaration>
    <variableDeclaration>
      <ddoc>/** documentation for g */</ddoc>
      <type pretty="int">
        <type2>int</type2>
      </type>
      <declarator line="2">
        <name>g</name>
        <ddoc>/// more documentation for g</ddoc>
      </declarator>
    </variableDeclaration>
  </declaration>
</module>

The first comment is attached to the variable declaration, but the second is attached to the declarator. I think that I wrote it this way so that you can have different trailing doc comments for each declarator, though I can tell that I didn't test this well enough.
Check this out:
/// doc1
int a, /// doc2
	b, /// doc3
	c; /// doc4

Build with dmd -c -D test.d and look at the html file. You'll get something like this:
int a;
    doc1
    doc2

int b;
    doc1
    doc3

int c;
    doc1
    doc4

The ddoc spec doesn't really say that this should happen, but it doesn't say that it shouldn't either.

I started a thread to get some input on this<EMAIL_ADDRESS>

On Wed, Jan 06, 2016 at 06:11:10PM -0800, Brian Schott wrote:

The docs for your variable declaration example are not lost, but they're not where you expect them either. dscanner --ast test.d | xmllint --format gives output like this:

Aye, I realized this earlier today too, it makes sense when I think about it.

With my most recent change the AST will look like this:
<?xml version="1.0"?>
<module>
  <declaration>
    <variableDeclaration>
      <ddoc>/// doc1</ddoc>
      <type pretty="int">
        <type2>int</type2>
      </type>
      <declarator line="9">
        <name>a</name>
        <ddoc>/// doc1
/// doc2</ddoc>
      </declarator>
      <declarator line="10">
        <name>b</name>
        <ddoc>/// doc1
/// doc3</ddoc>
      </declarator>
      <declarator line="11">
        <name>c</name>
        <ddoc>/// doc1
/// doc4</ddoc>
      </declarator>
    </variableDeclaration>
  </declaration>
</module>


Cleaning up unused code from gdf trial

Representing minimal build components as they mature

Rejection - vote from me. This pull request is removing some code that I believe is still in use in the Analytics and Execution engine development. I suggest consulting with them in preparation of a revised pull request to prevent down stream development issues.

This can't be accepted.
The Analytics Engine, Execution Engine and ND Expression Language is part of the minimum build.
This was presented yesterday at the minimum build presentation & review, and is still under ongoing development.
I also suggest the GDF remain until the new Data Access API reaches the functionality of the GDF.
I vote -1.

When I offered to port Analytics Engine and Execution Engine from GDF to minimal build branch Peter said he wasn't going to use that code

@petewa in datacube/gdf.py there are get_descriptor and get_data functions, so I believe Data Access API has reached the functionality of GDF (given the absence of the specification of said functionality).

When AE and EE are ready to be integrated the code can be added to the current release at that time. We're use revision control, so it's not like the GDF trial code is gone forever

Sounds reasonable to me. Minimal build releases could be staged over the coming weeks (prior to wrapup of minmimal build by xmas) and include AE/EE/QL components as they become functional against the storage access. For GDF trial components that have been superseded it seems to make sense to remove these from the minimal build branch.

There's not much reason to keep it around in this branch. My understanding is that by the end of milestone 1 everything will be under the datacube package instead of gdf.
Any code that uses the gdf packages wont work in this branch already, as those packages depend on the old schema and NetCDF structures.
The code in the datacube package may be insufficient at the moment for AE funcionality, but that's a separate issue to this one. We'll add the functionality, and merge the AE code into this branch (and the datacube package) by the end of the milestone.
+1 from me.

Removal of in progress code will mean references made to this branch and this code in yesterday's review will no longer be valid. It also disregards the committed development effort that is underway and a suggests no progress is being made on the other components.
Since the two modules under development for the minimal build are in two different branches (from what I can tell) I suggest the creation of a combined branch containing all of the minimal build components in progress and then the removal of truly deprecated code. This would then have the two development teams involved working off the same code base rather than this rather awkward independent branch which is not the full minimal build as its name seems to indicate and only contains one set of activities.
How does that sound?

Good points Rob.
Since develop is not being used otherwise, could we merge ga/milestone1 into develop and make it the primary point of milestone1 development instead? We can leave ga/milestone1 as-is to stay relevant to the status as-of the presentation if needed.
Having separate feature branches is not itself unusual in this milestone though. A few weeks ago there were four separate, fully independent and incompatible branches for my, Greg, Damien and Peter's modules, and we're gradually merging them one-by-one into here, fixing the incompatible interfaces as we go. We're still creating separate branches for larger and in-progress features as needed (my new query code was separate earlier this week, and Damien now has a new one).

@v0lat1le the original AE/EE from the GDF trial and Expression Language was presented at the minimum build presentation & review and is part of the minimum build.
I am not sure which code you are referring to but in this pull request, the AA/EE and EL have been removed.
@v0lat1le the spec for the the get_descriptor and get_data functions for EDA are here: http://www.datacube.org.au/wiki/Data_Access_Interface
This is a subset of the get_descriptor and get_data functionality from the GDF trial that is required for the EDA use case.
For the full functionality of the get_descriptor and get_data as per the GDF trial please see:
https://github.com/data-cube/agdc-v2/blob/master/gdf/__init__.py.
It has examples of the inputs and outputs of each function.
As we discussed, the returned ndarrays need to be an Xray DataArray.
You can also reverse engineer the code if it will help you.
I still need the GDF code for testing until the Data Access API supports the functionality of the GDF. Once I can confirm this and am happy with the Data Access API, then the GDF can go.
@v0lat1le I have been invited to the meeting that you are having with the author of the GDF to understand the functionality of get_descriptor and get_data later this week.
I suggest we take this offline and discuss it as a coherent development team and follow up on @woodcockr 's suggestions on bringing these branches together.

@petewa you have commit access to the repository. Please collaborate with us and move the code that you require into the datacube package

@jeremyh your suggested use of develop would be consistent with common practices and would make it simple to move these branches together given the dev branches both come from there. I'd be keen to see that happen. The point your raise about the use of feature branches is important. It seems to me at least that this particular branch has strayed beyond its intended scope to include changes in AE which are impacting other development teams. Best to work with in the scope, and push to develop than have AE bring its piece in once the Storage Access API is resolved. We could also replace the additional analytics done without the AE module with an AE enabled one in the process and bring all the dev back into unification as discussed when working on the review presentation content.


Cannot re-sync sectors in cancelled state

@mdoering, when you cancelled the sector syncs over the [sic] bug, it seems to have broken the sync queue. It's not possible to re-sync these four datasets with sectors in cancelled state:
MilliBase, Mollusca, Isopoda, Bryozoa
I get a 201 on the sync POST, but it doesn't seem to sync. The other WoRMS sectors with syncs that weren't in cancelled state seemed to have worked.
Logs
java.lang.InterruptedException: java.lang.NullPointerException
	at life.catalogue.common.lang.InterruptedRuntimeException.asChecked(InterruptedRuntimeException.java:24)
	at life.catalogue.assembly.SectorSync.processTree(SectorSync.java:320)
	at life.catalogue.assembly.SectorSync.doWork(SectorSync.java:95)
	at life.catalogue.assembly.SectorRunnable.run(SectorRunnable.java:136)
	at life.catalogue.assembly.SectorSync.run(SectorSync.java:44)
	at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515)
	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
	at java.base/java.lang.Thread.run(Thread.java:834)

This is very weird. Im investigating...

btw, the logs also say this:

Rematched 60 SpeciesEstimates from project 3. updated: 1, broken: 59

There was a bug in the code that swallowed some exceptions and converted them into interrupted exceptions, used to cancel operations. So there is some other, real exception underneath this problem that we cannot see so far. I will deploy the fix in an hour and try to sync millibase again, so we can hopefully see and ultimately fix the real problem

deployed. Finally we can ee a NullPointerException

Caused by: java.lang.NullPointerException: null
at life.catalogue.assembly.TreeBaseHandler.processEnd(TreeBaseHandler.java:169)
at life.catalogue.assembly.TreeCopyHandler.process(TreeCopyHandler.java:164)
at life.catalogue.assembly.TreeCopyHandler.processLast(TreeCopyHandler.java:125)
at life.catalogue.assembly.TreeCopyHandler.acceptThrows(TreeCopyHandler.java:115)

It was introduced by the sic parsing in authorships. Datasets with sic synonyms currently fail. I might need a day to fix this, its a bit more complex I am afraid.

deployed to prod just now


[BUG] Export-AzPolicyAssignmentRuleData unable to export Azure policy as PSRule (The function "field" was not found) [Custom policy: Prevent cross tenant Private Link for key vault]

Existing rule
No response
Description of the issue
Unable to export policy assignment data to PSRule.
{
    "Name": "00000000-0000-0000-0000-000000000000",
    "ResourceId": "/providers/Microsoft.Management/managementGroups/MyManagementGroup/providers/Microsoft.Authorization/policyDefinitions/00000000-0000-0000-0000-000000000000",
    "ResourceName": "00000000-0000-0000-0000-000000000000",
    "ResourceType": "Microsoft.Authorization/policyDefinitions",
    "SubscriptionId": null,
    "Properties": {
        "Description": "This policy prevents private link between tenants for key vault.",
        "DisplayName": "Prevent cross tenant Private Link for key vault",
        "Metadata": {
            "version": "0.0.2",
            "category": "Network",
            "status": "Active",
            "Control": "ABC1, ABC2, ABC3, ABC4, ABC5",
            "purpose": "This policy prevents private link between tenants for key vault.",
            "tags": [
                {
                    "managedpolicy": "true"
                }
            ],
            "createdBy": "00000000-0000-0000-0000-000000000000",
            "createdOn": "2023-06-14T14:18:44.6748556Z",
            "updatedBy": null,
            "updatedOn": null
        },
        "Mode": "All",
        "Parameters": {
            "effect": {
                "type": "String",
                "metadata": {
                    "description": "The effect of the policy",
                    "displayName": "Effect"
                },
                "allowedValues": [
                    "Audit",
                    "Deny",
                    "Disabled"
                ],
                "defaultValue": "Deny"
            }
        },
        "PolicyRule": {
            "if": {
                "allOf": [
                    {
                        "equals": "Microsoft.KeyVault/vaults/privateEndpointConnections",
                        "field": "type"
                    },
                    {
                        "anyOf": [
                            {
                                "exists": false,
                                "field": "Microsoft.KeyVault/vaults/privateEndpointConnections/privateEndpoint.id"
                            },
                            {
                                "notEquals": "[subscription().subscriptionId]",
                                "value": "[split(concat(field('Microsoft.KeyVault/vaults/privateEndpointConnections/privateEndpoint.id'), '//'), '/')[2]]"
                            }
                        ]
                    }
                ]
            },
            "then": {
                "effect": "[parameters('effect')]"
            }
        },
        "PolicyType": 1
    },
    "PolicyDefinitionId": "/providers/Microsoft.Management/managementGroups/MyManagementGroup/providers/Microsoft.Authorization/policyDefinitions/00000000-0000-0000-0000-000000000000"
}

Error messages
An error occurred evaluating expression '[split(concat(field('Microsoft.KeyVault/vaults/privateEndpointConnections/privateEndpoint.id'), '//'), '/')[2]]' line 57. The function "field" was not found.
Reproduction
Exporting policy assignment data
Version of PSRule
2.9.0
Version of PSRule for Azure
1.33.2
Additional context
This bug is related to #1323

Currently we need to support indexing into an array of string with a runtime token to fully complete this implementation which requires support to be added to PSRule.


Typescript route

Typescript.
I want to add custom parameter in route like "name"
<Route name="News" path="news" component={News} />
I try extend IRouteProps:
declare module 'react-router' {
  namespace ReactRouter {
    export interface IRouteProps {
      name?: string;
    }
  }
}

But it don't work.

This isn't really a React Router issue. I would ask in the appropriate support channels for Typescript.


Update Paypal Implementation

It would be easier to work on this if you could provide some description!

I'm claiming this issue,Could you assign the issue to me?

@mariobehling can you pls elaborate more on this issue, as I would like to work on it, pls explain it
It would be a great help for all of us to contribute!!

@mariobehling can you plz tell tell what all things we have to implement? I would like to work on this issue

is the issue still open?


Manage newsletter subscription in a modern ajax way

This is more elegant and avoid full page reload, see https://github.com/PrestaShop/PrestaShop/issues/17054
Newsletter subscription uses an old fashion "post to home page" form with several issues :

After subscribing, the user is redirected to the home page.
If the module is hooked several time, a buggy message tel the user that his email has already been used (see https://github.com/PrestaShop/PrestaShop/issues/15629)

Notice : I've changed the version number to 2.5.2 to launch upgrade : I must register a new hook actionFrontControllerSetMedia to load my new js file.

I've made a new commit to replace ajaxRender by ajaxDie for Prestashop < 1.7.5 support

Any news from QA ?

Hey @jf-viguier
Please configure your IDE so it auto-add new line at the end of the file :)

Hello @jf-viguier The success message when subscribing is not displayed, only the green rectangle appears .

Can you check this please ? Other than that everything is OK

@SD1982 Maybe a lang issue, what language do you use in front ? I didn't add any new message.
Do you have messages when javascript is turned off ?

Hello @jf-viguier  I tried with the FO in English and in French same result. But by trying as you suggested by disabling javascript the success or failure messages are correctly displayed but this time they are below :
English with javascript disabled

French  with javascript disabled

Hello @SD1982, I don't have this behavior. I'm in <IP_ADDRESS> and you ?
I've changed message position to match other ps behaviors like in account creation page.

@jf-viguier I tested your PR also (on 1.7.7.x). I have the same issue:

I checked the AJAX query, the data.msg data returned by backend is empty

{"value":"mathieu.fermentb@prestashop.comsss","msg":"","conditions":"Vous pouvez vous d\u00e9sinscrire \u00e0 tout moment. Vous trouverez pour cela nos informations de contact dans les conditions d'utilisation du site."}

Hello @jf-viguier  This behavior appears when i test on version 1.7.7 but I just tested on version 1.7.6 like you and indeed it works correctly and as you can see the message is diplayed on top this time  :
Version 1.7.6.x

so it probably does not come from your PR what do you think of that @matks , @NeOMakinG

@SD1982 please use a stable version ;-) You've certainly found a bug for 1.7.7 but I've no time to check this for now.
Certainly a bug in ajax request that doesn't have correct context of global vars stuff. @matks ? Other ajax messages works on 1.7.7 ?

I think we need @PrestaShop/prestashop-core-developers opinion on this ! If this PR works in 176 but not in 177, is this link to the PR or to the 177 version ?
Thanks

@Robin-Fischer-PS I've already answered this : it's linked to 177 version.
I just use old messages in ajax return array.
Tt's certainly a bug in ajax request that doesn't have correct context of global vars stuff.

@Robin-Fischer-PS I've already answered this : it's linked to 177 version.
I just use old messages in ajax return array.
Tt's certainly a bug in ajax request that doesn't have correct context of global vars stuff.

It does not matter. We are not going to accept a Pull Request that we know it will fail with 177 😉. What kind of professionnals would we be if we accept something that we know will fail with next release when it's scheduled for 1 or 2 months in the future ?
Until we know why it fails with 177 we cannot merge this PR.
It does not mean we will not merge this PR. It means we need more exploration.

Thanks @matks  I understand. I just means that my pr is not the source of the bug. I guess that other ajax requests have this bug in 177 ?

Found the culprit
https://github.com/PrestaShop/ps_emailsubscription/pull/37/files#diff-cfb1aa2304713070e111aaa57e5c8ef5R350

@jf-viguier Fixed with commit https://github.com/PrestaShop/ps_emailsubscription/pull/48/commits/da17e14412f365758d7b63b6629595a42151330c
This PR can now go through QA again, for both 176 and 177 checks 💪

Thanks @matks for the fix, you rocks

LGTM in 1.7.6.x and 1.7.7.x Thanks @jf-viguier

Thanks @jf-viguier

@Progi1984 when this will pr be released ?

Newsletter subscription seems no more in ajax in hummingbird theme. Can someone confirm ?


Use babel to inline code for properties

This inlines the code for css properties, renaming variables as necessary to avoid conflicts.
This reduces the time taken to require('CSSStyleDeclaration') between 80ms and 150ms in my tests.  I attribute most of this speedup to the fact that it no longer needs to run the expensive module resolution algorithm for each of the properties.

This is awesome. To give some context – we use this through jsdom inside of Jest and the require time of this module alone is about 100ms which is about 20 % of jsdom's overall require time. We'd like to speed up Jest's startup time because it is imperative for a unit test framework to run quickly. Please consider merging this :)

so, that looks great, I'm just concerned that if something goes wrong with it later, I am not smart enough to fix it

Don't worry, we are always here to help you :)

published version 0.2.37 with the change. if either of you want to take it over, let me ;)


adsec-1714 fix for missing ACI codes

As discussed with Dominica, I'm waiting for tests to be added

ready to review


[Dialog] Remove disableEscapeKeyDown prop, in favor of using the onClose callback

Is there any particular reason that the disableBackdropClick prop is deprecated on the Dialog component but the disableEscapeKeyDown prop is not?
I feel like they should either both be deprecated and handled the same way via the handleClose function, or neither should be deprecated.
Docs (v4.12.1) are currently showing:

From the pull request that removed disableBackdropClick:

disableEscapeKeyDown is on the chopping block as well but will be handed separately.

Ok sounds good, just wanted to make sure things were remaining consistent

We will probably need to move this to v6. The reason is that the property still exists in v5, and we wouldn't like to introduce more braking changes now that we are in beta. Thanks for the report @nzayatz14

This is fine for v5. Otherwise the API just looks weird as mentioned in the issue description. I just forgot to do it.

On the other hand, Modal also does stop event propagation which is a bit scary to change. Let's do this in v6.

Is there any particular reason that the disableBackdropClick prop is deprecated on the Dialog component but the disableEscapeKeyDown prop is not?

@nzayatz14 It's similar to the other events but not identical. The motivation to keep it was to kill two birds (not call on click + call event.stopPropagation()) in one stone (disableBackdropClick). It's meant as a helper to save time. If we remove it, developers would have to not forget to call event.stopPropagation(), they will get surprises otherwise.

If we remove it, developers would have to not forget to call event.stopPropagation(), they will get bad surprises otherwise.

This is misleading.

This is misleading.

@eps1lon Happy to have a longer conversation about it. I guess there are multiple different ways to see this problem.

stopPropagation vs. preventDefault. react-modal uses stopPropagation while bootstrap uses preventDefault. Who is right? In #14991, we use the feedback in https://github.com/mui-org/material-ui/issues/13470#issuecomment-435029581 that makes the case for only using preventDefault for preventing default user-agent behaviors.
This article https://css-tricks.com/dangers-stopping-event-propagation/  makes the case for avoiding stopPropagation unless we absolutely want no other parent event handlers to know about the events. It's why we call stopPropagation in the Autocomplete because we pretty much know that nobody should handle the event.
https://github.com/mui-org/material-ui/blob/913461139a7a275230bf4e960064646bb90ccc54/packages/material-ui/src/useAutocomplete/useAutocomplete.js#L778-L785

should the modal manipulate the event with its default props? It currently does, hence why we need disableEscapeKeyDown to disable the built-in behavior.

Regarding how we manage the product. Up until now, as the owner of it, I have used the milestones to include problems to fix in order to reach a specific larger goal. So I have removed the v6 milestone from this issue because we haven't yet a clear consensus on the direction the product should take on this one.
Now, we could act on a different way to manage milestones, by including issues that have been less processed. Meaning we would including potential opportunities, even if half never get into the final shipped outcome. It would be a different tradeoffs. The advantage is that it avoid us to forgot about something, and allows for more exploration, the disadvantage is that we might end up with never ending milestones. With the latter tradeoff, we can use the "discussion" label to signal that we haven't yet dive enough into the problem, and the product owner would have to be conscious about not making the scope of the milestones grow forever, removing issues when needed.

Hey guys, just wanted to bring up that deprecating those fields makes it kindof impossible out of the box to disableBackdropClick or disableEscapeKeyDown at large in createTheme.
Since it is not an actual event received in onClose you cannot event overload it generally and stopPropagation or preventDefault or whatever.
I would love to bring a solution to the problem, but this is over my head 😅

I document how I  migrated here: https://dev.to/teaganga/handle-dialogdisablebackdropclick-descoped-property-warning-in-mui-v5-2i35


mFaker Star Wars

Why

Some people like to test with Star Wars data.

This change addresses the need by

Create Faker module for random Star Wars data.

I've added:

[x] USAGE.md docs if applicable
[x] CHANGELOG.md

LGTM

Your changes in USAGE.md are based on the older USAGE.md. Would you be so kind to check the new structure of USAGE.md in master and update your PR?


Added metadata pagination proposal

Related issue: #94
This proposal merges all the current metadata endpoints into one, while keeping the same functionality. It also adds the possibility to do some advanced queries, like filtering just by senderPublicKey without setting a target asset.
I'm assuming that all the metadata entries are stored in the same MongoDB collection.

Fixed merge and applied changes to use addresses instead of private keys.

@fboucquez @rg911 Could you please review the PR? Thanks!


->defaultLocales applied only in posts

Hi,
If i set plugin in this way:
FilamentCMSPlugin::make()                     ->useCategory()                     ->usePost()                     ->allowExport()                     ->allowImport()                     ->defaultLocales(['it', 'en'])
and i go to categories, the selection remains in english and arabic. Posts are fine.

fixed on the last version.


Add Library API

Hello, I'm working on EmbarkStudios/rust-gpu and we're currently looking at how we can build our own sysroot as part of our build process (https://github.com/EmbarkStudios/rust-gpu/issues/48). Cargo's -Zbuild-std is currently not sufficient for us, as we want to be able to re-use the sysroot both for development and across multiple tests. Using cargo's -Zbuild-std either requires locking dependencies, redundantly compiling sysroot multiple times, or generate a complicated setup for tests so that they can re-use libcore. Ideally we'd like to just compile it once and re-use it throughout the build.
While investigating what was already available in this space I came across your crate, and found that it mostly does what we need for the project except for generating a .cargo/config.toml and being only available as a binary tool.  Would you be interested in adding a lib.rs that allows a user to just build the sysroot? I would be willing to contribute the work for the change.

Yeah thats fine

Do these changes work?

I'm going to try to build a proof of concept with it over the next couple of days, but it looks good to me just reviewing the code.

So one thing I don't understand in the current API, is why does generate_alloc_cargo_toml take in a pre-existing manifest file and inherit its profile settings? Could this be optional so that it uses the default if you don't provide a manifest file?
https://github.com/DianaNites/cargo-sysroot/blob/4a0c48b1fd1b9db8324aca3a3e203fab4752abe8/src/lib.rs#L62-L66

Another thing is that this currently builds every sysroot crate, but right now rust-gpu can really only compile some of core. Having an option to be able to compile alloc, core, and compiler_builtins separately would be immensely helpful.

generate_alloc_cargo_toml inherits profiles because it seemed to match carbo-xbuild behavior, and a project that worked with xbuild failed with mine until I added it, but I can make it optional.

Okay, hows it look now?
The mem feature of compiler_builtins is no longer on by default, and you can choose which sysroot crate to compile, core, alloc, or std.
Theres no option for compiler_builtins itself because, besides core, everything else depends on it. For core it simply isn't included at all, but I can change that if need be.

Thank you so much for working on this! The API is much improved.

Theres no option for compiler_builtins itself because, besides core, everything else depends on it. For core it simply isn't included at all, but I can change that if need be.

That would be great, as it seems that those compiler_builtins are required for core, even if they aren't built. At least trying to build a module with just core available int the sysroot provides a error[E0463]: can't find crate for `compiler_builtins`.. When running the following command.
Build
env::set_var("RUSTFLAGS", format!("-Zcodegen-backend={}", path_to_backend.display()));
let sysroot = cargo_sysroot::build_sysroot_with(
        None,
        &target_dir,
        "spirv-unknown-unknown".as_ref(),
        &src,
        cargo_sysroot::Sysroot::Core,
        false,
).map_err(|e| eyre!("Error building sysroot: {}", e))?;
env::remove_var("RUSTFLAGS");

Command
rustc lib.rs --target spirv-unknown-unknown --sysroot=<path_to_sysroot> -Zcodegen-backend=<path_to_rustc_codegen_spirv.dylib> -C target-feature=+spirv1.0

lib.rs
#![feature(lang_items)]
#![no_std]
#![feature(register_attr)]
#![register_attr(spirv)]

#[panic_handler]
fn panic(_: &core::panic::PanicInfo) -> ! {
    loop {}
}

#[lang = "eh_personality"]
extern "C" fn rust_eh_personality() {}

#[spirv(vertex)]
pub fn main() {
}

error[E0463]: can't find crate for compiler_builtins.

Thats odd, I wonder whats requiring it, I thought missing compiler_builtins usually caused linker errors. I tried to reproduce it and couldn't, though using a different target. May be specific to your target?
In light of that, instead of making Core bring in compiler_builtins, I've added Sysroot::CompilerBuiltins, which brings in both core and compiler_builtins. Does this work for you?

Thank you so much again for working on this! I've now managed to create a working prototype that builds the spirv-unknown-unknown sysroot. I'm still working on the PR that uses it, but as some final feedback it would be nice if you could pass rustc flags as right now I need to build in two steps. First building the core sysroot, and then building the compiler builtins sysroot with the core sysroot available through --sysroot, and I'm manually setting a RUSTFLAGS environment variable before each invocation to do that. And related to that it would be nice if this function accepted a builder for all the options that you have graciously added. 😄

Can you elaborate on setting rustc flags? Why do you need to build in two steps right now?

Sure, here's the relevant code. compiler_builtins is built using core, but the new sysroot isn't visible to rustc.  So I need to pass the --sysroot flag to the second build with the location of the first.
fn rust_flags(backend: &Path, sysroot: Option<&Path>) -> String {
    use std::fmt::Write;
    let mut buf = String::new();
    let _ = write!(&mut buf, "-Zcodegen-backend={}", backend.display());
    if let Some(sysroot) = sysroot {
        let _ = write!(&mut buf, " --sysroot={}", sysroot.display());
    }

    buf
}

// Build core without `--sysroot`
env::set_var("RUSTFLAGS", rust_flags(&backend, None));
let sysroot = cargo_sysroot::build_sysroot_with(
    None,
    &target_dir,
    TARGET_NAME.as_ref(),
    &src,
    cargo_sysroot::Sysroot::Core,
    false,
).map_err(|e| eyre!("{}", e))?;

// Build compiler_builtins with `spirv_unknown_unknown` sysroot
env::set_var("RUSTFLAGS", rust_flags(&backend, Some(&sysroot)));
let sysroot = cargo_sysroot::build_sysroot_with(
    None,
    &target_dir,
    TARGET_NAME.as_ref(),
    &src,
    cargo_sysroot::Sysroot::CompilerBuiltins,
    false,
).map_err(|e| eyre!("{}", e))?;
env::remove_var("RUSTFLAGS");

I'm more confused. Why are you building core explicitly? CompilerBuiltins implies Core. It builds core itself, because it depends on core? It can't be built separately?

Apparently, because if I comment out the second one and change Core to CompilerBuiltins I get the following error. I should have a PR that you can try out by Friday.
    Updating crates.io index
   Compiling compiler_builtins v0.1.36
   Compiling core v0.0.0 (/Users/.rustup/toolchains/nightly-x86_64-apple-darwin/lib/rustlib/src/rust/library/core)
error[E0463]: can't find crate for `core`
  |
  = note: the `spirv-unknown-unknown` target may not be installed

error: aborting due to previous error

For more information about this error, try `rustc --explain E0463`.
error: could not compile `compiler_builtins`

To learn more, run the command again with --verbose.

Well, that shouldn't happen.. I'll see whats causing that

Okay, that should fix it. Thats embarrassing. A simple mixed conditional.

I'm now getting a Couldn't copy host tools to sysroot error when building any Sysroot using the same code as above.

Thats.. never happened before. No idea how to reproduce that.
Is that the entire error message? It's not supposed to be..

Don't think I can do anything about this without more details on the error, above should help with that. Maybe it's something apple specific? But I have no way to test.
Maybe Rust changed some layouts? What nightly are you on? I'm on rustc 1.49.0-nightly (1773f60ea 2020-11-08), and the latest seems to be 1.49.0-nightly (5404efc28 2020-11-11), but I can't update since it, and last two versions, are missing the miri component.

Hmm but wait, it worked for you before didnt it? But I shouldn't have changed anything that could break it..

Not seeing anything that could've affected it between https://github.com/DianaNites/cargo-sysroot/commit/2adf1bde2dbe9275f524be48f652933edfea3872 and now..

It is the full error, I'll try some different nightlies on my end and get back to you.
Compiling core v0.0.0 (/Users/.rustup/toolchains/nightly-2020-11-09-x86_64-apple-darwin/lib/rustlib/src/rust/library/core)
Compiling Sysroot v0.0.0 (/Users/src/rust-gpu2/examples/runners/wgpu/target/debug/build/example-runner-wgpu-fa478400e7da9d34/out/spirv/sysroot)
    Finished release [optimized] target(s) in 15.81s
Error: Couldn't copy host tools to sysroot

Thats.. extremely odd. Are you using the latest master, https://github.com/DianaNites/cargo-sysroot/commit/b8b0c4db2d570618fc2350e01c6abceb5aacd4c1 added some more context hopefully to improve it

Okay it seems cargo update fixed it. Thank you again so much for your help with this! 😄

Actually I found the issue. If I have a rust-toolchain with a specific nightly (e.g. nightly-2020-11-09) it fails to copy the tools.

Oh great! With that I should be able to reproduce and fix it to.. not fail.

And with the above commit, it should be fixed.

Added a builder API in https://github.com/DianaNites/cargo-sysroot/commit/9d61d0bd418b3fd64cf38ca3b7f6c7464447f069, including the ability to set rustc flags.

@DianaNites Thank you again for all this work! It's very stable now, would you be up for releasing this version on crates.io?

I can do a crates.io release, yeah! But what about #6?

Published as v0.8.0

I can do a crates.io release, yeah! But what about #6?

Great, the library API itself is still good, and for now we can just not run clippy on those examples in my PR. We can track progress in more specific issues.


vscode-extensions.gruntfuggly.todo-tree: 0.0.205 -> 0.0.206

Motivation for this change
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[X] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[X] Fits CONTRIBUTING.md.

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 116943 run on x86_64-linux 1

1 package built:

vscode-extensions.gruntfuggly.todo-tree

The following issues got detected with the above build packages.
Please fix at least the ones listed with your changed packages:

vscode-extensions.gruntfuggly.todo-tree:

warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?
Near pkgs/misc/vscode-extensions/default.nix:383:9:
    |
383 |         meta = with lib; {
    |         ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md
warning: build-tools-in-build-inputs
unzip is a build tool so it likely goes to nativeBuildInputs, not buildInputs.
Near pkgs/misc/vscode-extensions/vscode-utils.nix:25:5:
   |
25 |     buildInputs = [ unzip ] ++ buildInputs;
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/build-tools-in-build-inputs.md
warning: unused-argument
Unused argument: src.
Near pkgs/misc/vscode-extensions/vscode-utils.nix:5:5:
  |
5 |     src,
  |     ^


Demo Link Doesn't Worked

Before this, your GitHub username was tovic but it seems you've changed it to taufik-nurrohman. But anyway, how's life?

Fixed now.

But anyway, how’s life?

Still the same person but with more confidence. As you can see how I had decided to change the user name to my real name.


Undefined symbols for architecture x86_64 and ld: symbol(s) not found for architecture x86_64 clang: error: linker command failed with exit code 1

Hello I am very new to flutter and app development in general. When I was cleaning out my computer I think I may have accidentally deleted something important? I have tried deleting my podfile podfile.lock and runner.xcworkspace and letting it recreate itself, but that doesn't seem to work.
Steps to Reproduce

Run flutter run.

Actual results:

Logs

Launching lib/main.dart on iPhone 11 Pro Max in debug mode...
Running Xcode build...
Xcode build done.                                            8.3s
Failed to build iOS app
Error output from Xcode build:
↳
    ** BUILD FAILED **

Xcode's output:
↳
    Undefined symbols for architecture x86_64:
      "_OBJC_CLASS_$_FlutterMethodChannel", referenced from:
          objc-class-ref in GoogleApiAvailabilityPlugin.o
      "_FlutterMethodNotImplemented", referenced from:
          -[GoogleApiAvailabilityPlugin handleMethodCall:result:] in GoogleApiAvailabilityPlugin.o
    ld: symbol(s) not found for architecture x86_64
    clang: error: linker command failed with exit code 1 (use -v to see invocation)
    note: Using new build system
    note: Planning build
    note: Constructing build description
    warning: Mapping architecture armv7 to i386. Ensure that this target's Architectures and Valid Architectures build settings are configured correctly for the iOS Simulator platform. (in target 'image_picker' from project 'Pods')
    warning: Mapping architecture arm64 to x86_64. Ensure that this target's Architectures and Valid Architectures build settings are configured correctly for the iOS Simulator platform. (in target 'image_picker' from project 'Pods')

Could not build the application for the simulator.
Error launching application on iPhone 11 Pro Max.

Analyzing christin...

   info • Unused import: 'dart:async' • lib/Home.dart:1:8 • unused_import
   info • 'await' applied to 'void', which is not a 'Future' • lib/Home.dart:52:5 •
          await_only_futures
   info • Unused import: 'package:christin/globals.dart' • lib/Welcome.dart:1:8 •
          unused_import
   info • Name types using UpperCamelCase • lib/editPhotos.dart:8:7 •
          camel_case_types
   info • Name types using UpperCamelCase • lib/editPhotos.dart:18:7 •
          camel_case_types
   info • Don't explicitly initialize variables to null • lib/globals.dart:6:21 •
          avoid_init_to_null
   info • Unused import: 'package:firebase_auth/firebase_auth.dart' •
          lib/login_signup_page.dart:3:8 • unused_import
   info • Unused import: 'login_signup_page.dart' • lib/main.dart:4:8 • unused_import
   info • Name types using UpperCamelCase • lib/map.dart:5:7 • camel_case_types
   info • This class (or a class which this class inherits from) is marked as
          '@immutable', but one or more of its instance fields are not final:
          map.currentLocation • lib/map.dart:5:7 • must_be_immutable
   info • Name types using UpperCamelCase • lib/map.dart:13:7 • camel_case_types
   info • Name types using UpperCamelCase • lib/photoSelect.dart:11:7 •
          camel_case_types
   info • Name types using UpperCamelCase • lib/photoSelect.dart:21:7 •
          camel_case_types
   info • The declaration '_clear' isn't referenced • lib/photoSelect.dart:54:8 •
          unused_element

14 issues found. (ran in 12.3s)

[✓] Flutter (Channel stable, v1.12.13+hotfix.9, on Mac OS X 10.15.3 19D76, locale
    en-US)
    • Flutter version 1.12.13+hotfix.9 at /Users/ardelalegre/flutter
    • Framework revision f139b11009 (3 weeks ago), 2020-03-30 13:57:30 -0700
    • Engine revision af51afceb8
    • Dart version 2.7.2

[✓] Android toolchain - develop for Android devices (Android SDK version 28.0.3)
    • Android SDK at /Users/ardelalegre/Library/Android/sdk
    • Android NDK location not configured (optional; useful for native profiling
      support)
    • Platform android-28, build-tools 28.0.3
    • Java binary at: /Applications/Android
      Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1343-b01)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 11.3.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 11.3.1, Build version 11C504
    • CocoaPods version 1.9.1

[✓] Android Studio (version 3.4)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 36.1.1
    • Dart plugin version 183.6270
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1343-b01)

[✓] IntelliJ IDEA Ultimate Edition (version 2019.2.3)
    • IntelliJ at /Applications/IntelliJ IDEA.app
    • Flutter plugin version 43.0.2
    • Dart plugin version 192.7761

[✓] Connected device (1 available)
    • iPhone 11 Pro Max • 446850C7-C775-4440-B89D-2C47A6D8CA1B • ios •
      com.apple.CoreSimulator.SimRuntime.iOS-13-3 (simulator)

• No issues found!

Same issue.

Duplicate of #51395


Revert "ci: add chromatic support (#1951)"

Revert of chromatic.

What's the story with this? Should we dump any visual testing then?

I will close this PR, we can come back here if one day we need to enable visual testing again.


element

Heya,
Nice work! :+1:  I wrote something similar back in 2011 - http://algytaylor.blogspot.co.uk/2011/11/tgvjs-javascript-to-reduce-page-loading.html
One of the good suggestions I'd had from that was that you should add a noscript tag with the actual image, so that it works for people with JavaScript disabled (or otherwise non-working), ie:

Cheers,
Algy

Great. Would you like to update the readme file with a pull request?

Done :)


chore(main): release 8.4.2

:robot: I have created a release beep boop
8.4.2 (2024-10-17)
Bug Fixes

always use the default diff in commit prompt (e8ba37a)

This PR was generated with Release Please. See documentation.

:robot: Created releases:

v8.4.2
:sunflower:


Allow specifying package versions

Adds a new zulu switch command which can be used to checkout a specific branch or tag (using --branch and --tag options).
Also allows specifying version when installing packages by passing --branch or --tag to zulu install

Fix #72

This is pretty much ready to merge. Just need to write a few tests.


Add docs site to main repo

Co-host website docs in main repo.
https://horreum.hyperfoil.io is now built and deployed using a github action: https://github.com/Hyperfoil/horreum.hyperfoil.github.io/blob/master/.github/workflows/gh-pages.yml

The test failures are not related to anything in this PR


feat(core): parse scripts from addresses on generating transactions

This commit enables parsing scripts from addresses on generating a transaction, instead of using the
default secp256k1/blake160 script.
But the lock script in change output is fixed to the default secp256k1/blake160 script.
FWIW, the internal interface generateRawTransaction in core/generateRawTransaction is changed to accept scripts instead of public key hash.

Codecov Report

Merging #488 into develop will increase coverage by 0.44%.
The diff coverage is 95.65%.

@@             Coverage Diff             @@
##           develop     #488      +/-   ##
===========================================
+ Coverage    95.40%   95.84%   +0.44%
===========================================
  Files           48       48
  Lines         1522     1516       -6
  Branches       292      292
===========================================
+ Hits          1452     1453       +1
+ Misses          70       63       -7

Impacted Files
Coverage Δ

packages/ckb-sdk-core/src/index.ts
71.25% <80.00%> (+3.37%)
:arrow_up:

...ackages/ckb-sdk-core/src/generateRawTransaction.ts
98.63% <100.00%> (-0.02%)
:arrow_down:


Add GoldenDict <IP_ADDRESS>

part of #897
Microsoft Reviewers: Open in CodeFlow

Dupe of https://github.com/microsoft/winget-pkgs/pull/1335


android 10 min api deadline question

Hello,
I was wondering, will nixos/nix-on-droid be effected by the minimum sdk / android 10 issue (as termux will be) in a few months from now?
I am looking for a backup to termux, that won't end up broken when this api cutoff deadline occurs (in November 2020 I think). I am rooted and on a custom rom, if that makes any difference.
Really hope this will possibly be a good alternative, and if it's uneffected I wonder if the creator of this could figure out with the termux dev how to fix the issue (there gonna use apks instead of packages or something, sounds a bit messy). I know they were taking about using proot and other things like that, so maybe that could end up being a potential collaboration.. who knows :-)
Thanks!

will nixos/nix-on-droid be effected by the minimum sdk / android 10 issue (as termux will be) in a few months from now?

If that's the Google Play policy cutoff, then, well, it's never been on Google Play. But then again, more roadblocks will probably follow, right?

I am looking for a backup to termux, that won't end up broken when this api cutoff deadline occurs

Sorry to disappoint you, but (at least my) stance is "this is a tiny project, it doesn't have to be the one to figure it out first". Granted, it might be easier for Nix-on-Droid than for the rest if proot bundling will be enough to solve it, but that's speculation. I totally planned to ape it from someone else who solves that earlier.

If the creator of this could figure out with the termux dev how to fix the issue (there gonna use apks instead of packages or something, sounds a bit messy).

Oh Lord =)
If only I knew something about Android development.


SAML Error - Nested Groups

Attempted Debugging

[X] I have read the debugging page

Searched GitHub Issues

[X] I have searched GitHub for the issue.

Describe the Scenario
We have setup Azure SAML login with bookstack and mapped the group IDs to Role IDsaccordingly with bookstack configuration.
Everything works and we needed to add another group in to our existing group so that the new group has same privilages as the existing one...
we are getting the following error.
Request Id: xxxxxxx-1234-1234-1234-e8d44da12900
Correlation Id: xxxxxxx-1234-47bf-1234-7ef734399133
Timestamp: 2023-02-23T06:24:32Z

Message: AADSTS50105: Your administrator has configured the application BookStack_SAML ('GROUP_ID') to block users unless they are specifically granted ('assigned') access to the application. The signed in user ['myemail](mailto:'myemail)' is blocked because they are not a direct member of a group with access, nor had access directly assigned by an administrator. Please contact your administrator to assign access to this application.

Is there any configuration on bookstack to allow nested groups to login ?
Thanks.
Exact BookStack Version
v23.01
Log Content
No response
PHP Version
PHP 7.4.30
Hosting Environment
Apache/2.4.29 (Ubuntu)
PHP 7.4.30

Hi @Sx3,
To be honest, based upon that error message, this looks to be purely an AzureAD issue/limitation or something that's dependent to your Azure user group management. I'm don't think I can help you out with this from a BookStack perspective.

Since there's been no further conversation here I'll close this off.


Capturing why a panic happened

When you have thousands, or more, of instances of your code running and having one crash occasionally with no information as to why is not the situation you want to be in.

LGTM


Why is 1.11.2 EnderIO is taking so long?

Why it's taking so long?
It's because you don't want to do?
Or just making new things to the mod?

Creator of EnderIO you need to awnser this questions

"Status for the update to 1.11.2: Time spent: ~180 hours. Updated: ~30%. Stop nagging us, or we might notice we know ways to spend our time doing things that are more enjoyable."  Surprised they havent deleted your post yet


Automated cherry pick of #6500: 修复当prestate=alerting，newstate=alerting的情况无法触发notify的问题

Cherry pick of #6500 on release/3.2.
#6500: 修复当prestate=alerting，newstate=alerting的情况无法触发notify的问题

Codecov Report

Merging #6502 into release/3.2 will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@               Coverage Diff               @@
##           release/3.2    #6502      +/-   ##
===============================================
- Coverage         7.04%    7.04%   -0.01%
===============================================
  Files              649      649
  Lines           111531   111548      +17
===============================================
- Hits              7858     7856       -2
- Misses          103065   103083      +18
- Partials           608      609       +1

Flag
Coverage Δ

#aFlag
7.04% <0.00%> (-0.01%)
:arrow_down:

Impacted Files
Coverage Δ

pkg/compute/models/guest_queries.go
0.00% <0.00%> (ø)

pkg/compute/models/guests.go
0.56% <ø> (ø)

pkg/cloudcommon/db/lockman/fifo.go
80.00% <0.00%> (-10.00%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a3c4826...0fb24d9. Read the comment docs.


Feature request: copy filters in filterd

Proposed feature
Add a new step in the playbook to copy filters in filterd folder.
Rationale
For the moment, if you specify a filter in your jail local conf, it will fail as the filters do not exist.
I will propose a PR for that.

Thanks! I'll release a new version with your PR in a bit.


Nick: Watch cialisphm.net

Nick requests the watch of the watch_keyword cialisphm\.net. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

cialisphm\.net has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by cocomac in Charcoal HQ


Decompress gzip files

Update request lib.
This fixes #2090 and #1004, but I'm not sure how to unit test it.
I tried it with the example given in #1004
bower install --save-dev hellosign=http://s3.amazonaws.com/cdn.hellofax.com/js/embedded.js
and it works.
In short, if request notices a gzipped file, it decompresses it. We need to add the option there because request doesn't do it automatically (for backward compatibility reasons).

:+1: Nice work!

Nice job!
Some testing thoughts: Reply headers can be specified with nock. Try adding a test to test/util/download.js that mocks the downloading of a text file with a 'Content-Encoding': 'gzip' header. After it's downloaded, if you can successfully read its contents with fs.readFileSync, the test passes and satisfies #1004.
For #2090, use the same test as above but add .gz to the end of the text file.
If you need any help, find us on chat.

@contolini Thanks for the tips. Just to clarify, I should add a gzipped file to tests/assets and test against that, right?

@Utsav2 Yes, you can use nock's "replyWithFile" helper and .txt file encoded with gzip you put in test/assets.

@sheerun How does it look now?

LGTM :)


Announcement: Renaming "master" to "main" in this repository

On the 18th of June, 2021 (PST) (updated)) we will be renaming the master branch in this repository to main. When this occurs there will be some disruption to the engineering system as we address any issues that earlier preparations did not address. Please read the following centralized issue for more background on what to expect:

https://github.com/Azure/azure-sdk/issues/2745

Localized issues in this repository can be discussed here.
Engineering System Checklist
The following checklist will be executed by a member of the Azure SDK Engineering System team when the branch rename occurs. If errors occur they'll need to be addressed:

[ ] Ensure repo mirroring is stopped (coordination across repos required).
[ ] Rename the master branch to main on this repository.
[ ] Rename the master branch on the -pr repository.
[ ] Rename the master branch on the azure-sdk user's clone of this repository.
[ ] Rename the master branch on the azure-sdk user's clone of the -pr repository.
[ ] Ensure repo mirroring is started (coordination across repos required).
[ ] Ensure pipeline generation has been run and pipelines have been updated to correct branch.
[ ] Submit a PR to ensure that PR validation is executing correctly.
[ ] Merge PR to ensure that CI triggers are executing correctly.
[ ] Trigger template release pipeline to ensure end-to-end release process is working correctly.

@danieljurek Is there anything left todo on this issue?  Can this be closed?

I'll be making the updates to docs to change links from .../master/... to .../main/... today.

This was done yesterday. https://github.com/Azure/azure-sdk-for-cpp/commit/015c34a0295594dbe6d82bcaffcc6cb70ff5f57f Closing the issue.


Wiring up form state and value conversion on submission

Reorganized all the form components into a subfolder.
Created ApiContext to do dependency injection of api functions. This lets us mock API calls cleanly in stories/tests without having to hook into Axios and do ugly protobuf encoding of mock responses.

Note: I have only switched the hooks in use by this form and its stories to using the api context. Others will be migrated later.

Implemented all the logic for selecting the workflow, fetching the launch plans, and using the default launch plan.

Note: I will add a launch plan selector in the next PR. For now, it's just using the default launch plan.

Form now uses WaitForData where appropriate:

The initial form state must wait on fetching our 10 default workflow versions
The input rendering must wait on fetching of both workflows and launch plans. Otherwise it's going to render whatever input array we have set (which defaults to empty if no launch plan is selected)

Added logic for converting the supported input values to their Literal versions for submission to the backend.
Fixed z-index issue with workflow selector when other components are in the form with it
Wired WorkflowSelector up to the form
Fixed some behavior issues with datetime selector.

Thanks @mrmcduff ! Since this is a feature branch, I'm going to merge and implement feedback in the next PR.


Remove doubling of connection setup in SDP creation

Description
I noticed a:setup=actpass showing up twice in each media description in an SDP. It is already being added in the addTransceiverSDP and addDataMediaSection methods.
Reference issue

@suhasgaddam great work!

Can you update your commit message so it is subject/body

You could do something like
Remove doubling of setup attribute in SDP creation

Before a:setup=actpass was showing up twice in each media description. It is already being added in the addTransceiverSDP and addDataMediaSection methods. This commit removes
the extra call.

Add yourself to the README

Add your test to peerconnection_go_test.go instead. Our media APIs diverge from the browser, so we can't compile them to WASM.

After that it should be good to merge! Really excited to see you involved :)

Codecov Report

Merging #787 into master will increase coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #787      +/-   ##
==========================================
+ Coverage    75.8%   75.84%   +0.03%
==========================================
  Files          59       59
  Lines        4200     4198       -2
==========================================
  Hits         3184     3184
+ Misses        744      743       -1
+ Partials      272      271       -1

Impacted Files
Coverage Δ

peerconnection.go
72.66% <ø> (-0.05%)
:arrow_down:

sctptransport.go
75.33% <0%> (+1.33%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62e4d17...4757f84. Read the comment docs.


32 byte align for BGQ

Original author: Ehsan Totoni
Original date: 2014-04-22 22:04:16
Original PR: https://charm.cs.illinois.edu/gerrit/194

Change-Id: I2c9f1ab5ef417f460bd618e4d7ea76d9890a05c6

BG/Q support is deprecated now (we don't know if any extant systems now), so closing this.


AttributeError: module 'audioowl' has no attribute 'analyze_file'

Hi, I'm trying to test out a simple file and am getting the error:
AttributeError: module 'audioowl' has no attribute 'analyze_file'

I'm running Python 3.66
import audioowl
data = audioowl.analyze_file(path='squishy.wav', sr=22050)
print (data)

Any idea what could be going on?

Hi,
I'm running the same operation with Python 3.6.5 (should be no different) and I can't reproduce the issue. Everything is working fine :)
Can you please recheck your environment?
Please feel free to reopen if you still face this problem.


Refactor memory allocation PInvokes

Changed RCWWalker back to use non-throwing version. It was a bug introduced earlier - it is not ok to use throwing version in RCWWalker because of the code is executing during GC.
Made Windows-specific HEAP_ZERO_MEMORY flag to be used in Windows-specific implementation only
Split the regular ones from the very special flavor used by RCWWalker that does not throw exceptions and zero initializes memory
Removed some unnecessary null checks for out of memory

@tarekgh @tijoytom PTLA

LGTM. thanks Jan for the cleaning up.


Update fetching-bulk-analytics.md

Since you have to use API Keys, not API Token, you have to use the correct headers: X-Auth-Email and X-Auth-Key instead of Authorization.

I think there is a misunderstanding. GraphQL API supports both ways to authenticate the request:

providing a single header with API Token
providing a pair of email / key headers

API Tokens allow you to configure access as needed: limit it to a specific set of resources (like analytics for a given zone, but not for the entire account), or set a particular range of IP addresses it can be used from. In contrast, a pair of email/key headers provide a global level of access to the account resources (zone/account analytics, etc).
In my mind, we have this PR because you might have been using the wrong API Token or one that wasn't configured to allow you access to the account-level analytics.


bugfix:  sudo 场景下 nohup 重定向报错 /tmp/nm.nohup.out: Permission denied (c…

…losed #1633)

Codecov Report

Merging #1635 (85152a9) into v2.3.2-dev (644f6da) will not change coverage.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           v2.3.2-dev    #1635   +/-   ##
===========================================
  Coverage       73.39%   73.39%
===========================================
  Files             389      389
  Lines           26274    26274
===========================================
  Hits            19283    19283
  Misses           6991     6991

Impacted Files
Coverage Δ

apps/backend/agent/solution_maker.py
90.00% <100.00%> (ø)


ConnectionResetError: [WinError 10054] connection fail

I want to get google calendar's information that is a project of used by python.
I prepared something that from google calendar API 's guide.
when executive then project , I got a error:
ConnectionResetError: [WinError 10054] 既存の接続はリモート ホストに強制的に切断されました。
The environment:
python version 3.6.1
windows 10
google chrome  68.0.3440.106（Official Build） （64bit）
※ I'm using a  proxy to access google
The error detail information
_>python quickstart.py
E:\Users\123456789\AppData\Local\Programs\Python\Python36\lib\site-packages\oauth2client\_helpers.py:255: UserWarning: Cannot access token.json: No such file or directory
  warnings.warn(_MISSING_FILE_MESSAGE.format(filename))

Your browser has been opened to visit:

    https://accounts.google.com/o/oauth2/auth?client_id=135970666564-rvv4lt7i90p10tcnhe8p7igmgrfkpkb0.apps.googleusercontent.com&redirect_uri=http%3A%2F%2Flocalhost%3A8080%2F&scope=https%3A%2F%2Fwww.googleapis.com%2Fauth%2Fcalendar.readonly&access_type=offline&response_type=code

If your browser is on a different machine then exit and re-run this
application with the command-line parameter

  --noauth_local_webserver

Traceback (most recent call last):
  File "quickstart.py", line 36, in <module>
    main()
  File "quickstart.py", line 18, in main
    creds = tools.run_flow(flow, store)
  File "E:\Users\123456789\AppData\Local\Programs\Python\Python36\lib\site-packages\oauth2client\_helpers.py", line 133, in positional_wrapper
    return wrapped(*args, **kwargs)
  File "E:\Users\123456789\AppData\Local\Programs\Python\Python36\lib\site-packages\oauth2client\tools.py", line 243, in run_flow
    credential = flow.step2_exchange(code, http=http)
  File "E:\Users\123456789\AppData\Local\Programs\Python\Python36\lib\site-packages\oauth2client\_helpers.py", line 133, in positional_wrapper
    return wrapped(*args, **kwargs)
  File "E:\Users\123456789\AppData\Local\Programs\Python\Python36\lib\site-packages\oauth2client\client.py", line 2054, in step2_exchange
    http, self.token_uri, method='POST', body=body, headers=headers)
  File "E:\Users\123456789\AppData\Local\Programs\Python\Python36\lib\site-packages\oauth2client\transport.py", line 282, in request
    connection_type=connection_type)
  File "E:\Users\123456789\AppData\Local\Programs\Python\Python36\lib\site-packages\httplib2\__init__.py", line 1514, in request
    (response, content) = self._request(conn, authority, uri, request_uri, method, body, headers, redirections, cachekey)
  File "E:\Users\123456789\AppData\Local\Programs\Python\Python36\lib\site-packages\httplib2\__init__.py", line 1264, in _request
    (response, content) = self._conn_request(conn, request_uri, method, body, headers)
  File "E:\Users\123456789\AppData\Local\Programs\Python\Python36\lib\site-packages\httplib2\__init__.py", line 1187, in _conn_request
    conn.connect()
  File "E:\Users\123456789\AppData\Local\Programs\Python\Python36\lib\site-packages\httplib2\__init__.py", line 1050, in connect
    raise socket_err
  File "E:\Users\123456789\AppData\Local\Programs\Python\Python36\lib\site-packages\httplib2\__init__.py", line 1013, in connect
    self.sock = self._context.wrap_socket(sock, server_hostname=self.host)
  File "E:\Users\123456789\AppData\Local\Programs\Python\Python36\lib\ssl.py", line 401, in wrap_socket
    _context=self, _session=session)
  File "E:\Users\123456789\AppData\Local\Programs\Python\Python36\lib\ssl.py", line 808, in __init__
    self.do_handshake()
  File "E:\Users\123456789\AppData\Local\Programs\Python\Python36\lib\ssl.py", line 1061, in do_handshake
    self._sslobj.do_handshake()
  File "E:\Users\123456789\AppData\Local\Programs\Python\Python36\lib\ssl.py", line 683, in do_handshake
    self._sslobj.do_handshake()
ConnectionResetError: [WinError 10054] 既存の接続はリモート ホストに強制的に切断されました。_

It looks like there is a ConnectionResetError that may be from an issue with the proxy.
Can you try without using a proxy?
Or perhaps retry the request multiple times like in this example?
@asrivas Can you follow-up on this issue?

I can't connect google's service without using a proxy, because I'm in China, and the proxy server is in Japan. that is normally, explore internet(google's calendar too) with use the proxy  except this issue.

OK. I don't think we support proxies in our samples currently.
@asrivas Can you follow-up or unassign yourself from this issue?

Under your guidance, I rewrote the following code and solved the issue, although it's not fundamentally resolved。
File  "E:\Users\123456789\AppData\Local\Programs\Python\Python36\lib\site-packages\httplib2\__init__.py"

Thank you very much！！

Glad it worked out!


License Issues

The README mentions that ANT is licensed under Apache 2.0. Are there any restrictions or special considerations for using ANT in commercial projects?

Apache License 2.0 does not place restrictions on commercial use.


Add Pinterest's Gestalt

Looks pretty neat 👍  https://pinterest.github.io/gestalt

Added in https://github.com/alexpate/awesome-design-systems/pull/101


Support for a Windows Server AWS EC2 instance deployment using Terraform

Description
Support for a lightweight Windows Server AWS EC2 instance deployment with Arc connectivity using Terraform
Implementation Requirments

Lightweight VM for fast provisioning
Parameterize deployment using Terraform
Azure Arc connectivity instructions
Detailed README
Reference in the main README

Supporting Docs
Please refer to the supported Azure Arc supported OS

There is a blocking issue with Terraform AWS provider - https://github.com/hashicorp/terraform/issues/24970
This will make it clunky for users to create Windows instances because they will need to create keys using a different method compared to the other quickstart guides which use ssh-keygen. Parking this enhancement for now.


Remember old comps

It might be nice to store the name and url of older comps in the local storage to find it back easily. You can force an update once the upload is finished, and this way users can easily find them back. Especially useful if you're unfortunate like me and the previewer often crashes directly after it's done. :(
I'd set a limit to it, though. Probably 5 comps saved by default until it starts overwriting them to avoid it from getting too busy (with a setting allowing that to be changed?)

Additional nicety would be to also print the progress of comps being made to stdout, including the final url. Useful in case you close vspreview but forgot to copy the link, or if it crashes straight after uploading (as has happened to me before).

Additional nicety would be to also print the progress of comps being made to stdout, including the final url. Useful in case you close vspreview but forgot to copy the link, or if it crashes straight after uploading (as has happened to me before).

Please open another issue for this

Fixed in https://github.com/Irrational-Encoding-Wizardry/vs-preview/commit/8c06a9b53c57b128909dca3ae6d64c2455d0217b