update with release notes for 1.4.0 release

Description
update with release notes for 1.4.0 release
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.

[ ] The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
[ ] Changes are complete (i.e. I finished coding on this PR)
[ ] All changes have test coverage:
Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
[ ] Code is well-documented:
For user-facing API changes, API doc string has been updated.
For new C++ functions in header files, their functionalities and arguments are documented.
For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
[ ] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

[ ] Feature1, tests, (and when applicable, API doc)
[ ] Feature2, tests, (and when applicable, API doc)

Comments

If this change is a backward incompatible change, why must this change be made.
Interesting edge cases to note here

Please wait a moment to merge the PR.
I will add the description of MKL-DNN parts tomorrow.

@srochel  could you help add the below description into the new feature parts of r1.4?
@larroy @aaronmarkham could you help take a reveiw for the contents?
Thanks in advance.

MKDNN backend: Graph optimization and Quantization (experimental)
Two advanced features, graph optimization (operator fusion) and reduced-precision (INT8) computation, are introduced to MKL-DNN backend in this release (#12530, #13297, #13260).
These features significantly boost the inference performance on CPU (up to 4X) for a broad range of deep learning topologies.

Graph Optimization

MKL-DNN backend takes advantage of MXNet subgraph to implement the most of possible operator fusions for inference, such as Convolution + ReLU, Batch Normalization folding, etc. When using mxnet-mkl package, users can easily enable this feature by setting export MXNET_SUBGRAPH_BACKEND=MKLDNN.

Quantization

Performance of reduced-precision (INT8) computation is also dramatically improved after the graph optimization feature is applied on CPU Platforms. Various models are supported and can benefit from reduced-precision computation, including symbolic models, Gluon models and even custom models. Users can run most of pre-trained models with only few lines of command and a new quantization script imagenet_gen_qsym_mkldnn.py. The observed accuracy loss is less than 0.5% for popular CNN networks, like ResNet-50, Inception-BN, MobileNet, etc.
Please find detailed information and performance/accuracy numbers here: MKLDNN README, quantization README and design proposal

@pengzhao-intel added your change request.

I kept getting nginx 405 errors from github when trying to submit this review (it was a lot of change requests >100) - it went through on the third try, so hopefully the review is all there.

Thanks for the corrections @srochel

@srochel Please let me know when I should merge this PR

12/18 4pm - I addressed most of Aaron feedback. I will work with him tomorrow to resolve the remaining feedback from him. Issues from all other code reviewers are addressed.

addressed all feedback as of 12/19 11.30am.

@srochel after I get this merged into the 1.4.x branch, what's procedure to get it added to the master branch ?

Ah I didn't see Aston's comment. I can add that myself.

Don't worry, it has already been added:
https://github.com/apache/incubator-mxnet/pull/13691


Adds postgresql support to travis.

Yaay, Travis is back!

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@4b728d5). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #211   +/-   ##
=========================================
  Coverage          ?   27.27%
=========================================
  Files             ?       18
  Lines             ?      572
  Branches          ?        0
=========================================
  Hits              ?      156
  Misses            ?      416
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b728d5...685fc47. Read the comment docs.


Document how to set defaultNullBehavior for scalar function

The isDefaultNullBehavior method is removed in #9209.
This PR just updated a document to align with the latest code.

@mbasmanova, this is simply a fix for a document. Could you review it? Thanks!

@PHILO-HE Thank you for updating the docs. Should we also document 'deterministic' flag?

Hi @mbasmanova, I just updated deterministic part. Please review again.

@mbasmanova, could you please help check again? Thanks!

@PHILO-HE Thank you for updating the doc. Please, generate the docs locally and double check they look nice.

@mbasmanova, just confirmed. It looks good and the added href also works.


Conda environment

Could someone help me to build a conda environment setup file to run OpenSfM?
Thanks.

I have just had a couple of days of pain trying to get through this, I think the biggest problem with using Conda is that the version of Python that ships with it by default.
The best approach would be to create a Conda environment that matches Ubuntu 20.04 (Python 3.8.3 rather than Conda's 3.9.12) that way when pip pulls modules down it should be getting them in context with the version of python it's using. The Dockerfile lists various ubuntu python3- packages that are installed, these packages are compatible with the default version version of Python in the system. Providing that the python version in your Conda environment matches the system's, pip will then install the requirements.txt modules in a way that compliments the packages installed via apt.
Hope this helps.


Added Native Http Requests

This fixes the issue where iOS WKWebView blocks cors requests so the image loader plugin does not work on iOS. This uses the Native HTTP plugin to handle the requests in the native thread. I have not been able to test this on iOS or Android. So I was wondering if someone else could test it.

I don't recommend to add this workaround by default but I would prefer to add some notes about this problem.
You can fix it by following this guide: https://github.com/sneas/ionic-native-http-connection-backend

When will this PR get merged ?

Waiting on this PR merge too.

@ihadeed Could you please merge this PR?

I've made pull request #160 which still uses HttpClient and works with iOS (tested in simulator and device).

@ihadeed Made pull request #161 so images will load even with --livereload flag.


Got an Issue

Converted HTML to PDf
how will you implement this pdf functionality
http://mpdf1.com/manual/index.php?tid=152
it seems it has no documentation

Two ways:

Using beforeRender() event (line 93 of PdfResponseFormatter class)
Using mpdf HTML tag for that purpose: http://mpdf1.com/manual/index.php?tid=176

Feel free to ask if you need more details or have more questions.

thanks rob! I am satisfied of your answer. You can definitely close this question. Thanks again! great job!


Write initial documentation

We should describe how clappr is structured and how plugins works - showing the differences between container plugins, playback plugins and "global" ones.  Would be quite interesting to have at last one tutorial describing step-to-step how to write a mp3 player or a slideshow player.
We should also create a session like nginx's 3rd party modules to store external modules like bemtv p2phls plugin.

What about something like an API.md document? To list all the javascript methods that can be called?

This would be a great start @chriswiggins

Hey there, I’d really like to use clappr and maybe contribute to development. Unfortunately, the lack of documentation makes everything beyond instantiating a player really hard and a guessing game.
Please invest some time to provide great documentation, that could really provide a kickstart for the project.

@davidaurelio You're definitely right about this. I'll start to focus on this in the next days.

+1

+1

+1

+1

+1

Following @chriswiggins idea, I started to draft an API.md file. Feedbacks are welcome.

We may use something similar to this http://leandromoreira.github.io/clappr-docs/classes/Player.html#method_constructor

At Aug 9, 2014 @thiagopnts suggested yuidoc and we did it :facepunch:
You already can check the initial documentation, mostly covering the github's home page and thiago's API documentation.
We still need to better integrate this to our build but I think the first step was done. can we close this @flavioribeiro @thiagopnts @towerz @bernardocamilo @barbosa ?

Great job, @leandromoreira! :beers:
I'm ok with closing this one, now we can start moving towards tutorials and other kinds of documentation, as well as improving our test coverage.

@chriswiggins @davidaurelio @bryfry @tarkanlar @snsxn @deedos @irongomme you can check the initial documentation at http://clappr.github.io/


Unable to restore the wallet.

Unable to restore the wallet.It is happening on android device only.
My level 1 was complete still I was unable to recover the wallet.It was stuck on loader messages.I was not able able to jump in the wallet.
Tested on staging app v2.0.5(377)and 2.0.5(378)
-This is also happening on Android live app 2.0.5(379). live app was completed even at level 2 still unable to recover wallet and when i went to background and came to this restore screen it asked me security question answer and when i answered it showed me some error and After that start loading loader message but I was unable to land on home page.

Verified this issue on staging app v2.0.5(381)


pip install gsconfig

Error when running "pip install gsconfig."
Here's the error I receive...
Collecting gsconfig
Using cached https://files.pythonhosted.org/packages/a1/f2/2bde043ed1238643e6459674ac75534defecde2ff13b1532eccb732c0bd8/gsconfig-1.0.10.tar.gz
Complete output from command python setup.py egg_info:
Traceback (most recent call last):
File "", line 1, in
File "/private/var/folders/md/16zrp6t13r9g0y_0c2vl4q740000gn/T/pip-install-626nj8ti/gsconfig/setup.py", line 8
except IOError,e:
^
SyntaxError: invalid syntax
----------------------------------------

Command "python setup.py egg_info" failed with error code 1 in /private/var/folders/md/16zrp6t13r9g0y_0c2vl4q740000gn/T/pip-install-626nj8ti/gsconfig/

Try this command  'pip install gsconfig-py3'

Seems to me like it isn't Python 3 compatible.

has there been a solution found for this?

Not that I'm aware of - unless someone has forked the repo and fixed it.

just found a solution its related to python 3 compaitiblity use the gsconfig-py3 lib instead

The code is already python3-compatible on master, it is just the fact that no new realase is available
on PyPI.  It seems that gsconfig-py3 is not always up2date as it states.
Here is the alternative. You can always install the master branch if this happens.
If you use pip
pip install git+https://github.com/boundlessgeo/gsconfig.git#master

if you use pipenv
pipenv install -e git+https://github.com/boundlessgeo/gsconfig.git@master#egg=gsconfig

PS:

if you use pipenv, and writing private repo on top of gsconfig, use pip instead. It will be a headache when it comes to packaging your private repo.
If your stuff eventually goes to server, and the server blocks git, use gsconfig-py3

Just curiours, why isn't there any new release on PyPI?  Is there any decision being made that I miss from this repo?

@adclose using gsconfig-py3 worked. Thank you very much. I apologize for the late response.

You can try this command for python 3
pip install gsconfig-py3


[BUG] HTTPSconnection error when accessing /v2/logs

Brief description:
There is a general problem when doing POST requests:

How to achieve it:
Fix it

This might be unrelated but it seems that the analytics request for fetching a user's location by their IP is failing as well:
  File "/root/.cache/pypoetry/virtualenvs/py-api-9TtSrW0h-py3.11/lib/python3.11/site-packages/requests/adapters.py", line 486, in send
    resp = conn.urlopen(
           ^^^^^^^^^^^^^
  File "/root/.cache/pypoetry/virtualenvs/py-api-9TtSrW0h-py3.11/lib/python3.11/site-packages/urllib3/connectionpool.py", line 798, in urlopen
    retries = retries.increment(
              ^^^^^^^^^^^^^^^^^^
  File "/root/.cache/pypoetry/virtualenvs/py-api-9TtSrW0h-py3.11/lib/python3.11/site-packages/urllib3/util/retry.py", line 592, in increment
    raise MaxRetryError(_pool, url, error or ResponseError(cause))
urllib3.exceptions.MaxRetryError: HTTPSConnectionPool(host='geolocation-db.com', port=443): Max retries exceeded with url: /json/Address(host='<IP_ADDRESS>',%20port=60462) (Caused by SSLError(SSLEOFError(8, '[SSL: UNEXPECTED_EOF_WHILE_READING] EOF occurred in violation of protocol (_ssl.c:1006)')))

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/root/.cache/pypoetry/virtualenvs/py-api-9TtSrW0h-py3.11/lib/python3.11/site-packages/uvicorn/protocols/http/httptools_impl.py", line 426, in run_asgi
    result = await app(  # type: ignore[func-returns-value]
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/root/.cache/pypoetry/virtualenvs/py-api-9TtSrW0h-py3.11/lib/python3.11/site-packages/uvicorn/middleware/proxy_headers.py", line 84, in __call__
    return await self.app(scope, receive, send)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/root/.cache/pypoetry/virtualenvs/py-api-9TtSrW0h-py3.11/lib/python3.11/site-packages/fastapi/applications.py", line 289, in __call__
    await super().__call__(scope, receive, send)
  File "/root/.cache/pypoetry/virtualenvs/py-api-9TtSrW0h-py3.11/lib/python3.11/site-packages/starlette/applications.py", line 122, in __call__
    await self.middleware_stack(scope, receive, send)
  File "/root/.cache/pypoetry/virtualenvs/py-api-9TtSrW0h-py3.11/lib/python3.11/site-packages/starlette/middleware/errors.py", line 184, in __call__
    raise exc
  File "/root/.cache/pypoetry/virtualenvs/py-api-9TtSrW0h-py3.11/lib/python3.11/site-packages/starlette/middleware/errors.py", line 162, in __call__
    await self.app(scope, receive, _send)
  File "/root/.cache/pypoetry/virtualenvs/py-api-9TtSrW0h-py3.11/lib/python3.11/site-packages/starlette/middleware/exceptions.py", line 79, in __call__
    raise exc
  File "/root/.cache/pypoetry/virtualenvs/py-api-9TtSrW0h-py3.11/lib/python3.11/site-packages/starlette/middleware/exceptions.py", line 68, in __call__
    await self.app(scope, receive, sender)
  File "/root/.cache/pypoetry/virtualenvs/py-api-9TtSrW0h-py3.11/lib/python3.11/site-packages/fastapi/middleware/asyncexitstack.py", line 20, in __call__
    raise e
  File "/root/.cache/pypoetry/virtualenvs/py-api-9TtSrW0h-py3.11/lib/python3.11/site-packages/fastapi/middleware/asyncexitstack.py", line 17, in __call__
    await self.app(scope, receive, send)
  File "/root/.cache/pypoetry/virtualenvs/py-api-9TtSrW0h-py3.11/lib/python3.11/site-packages/starlette/routing.py", line 718, in __call__
    await route.handle(scope, receive, send)
  File "/root/.cache/pypoetry/virtualenvs/py-api-9TtSrW0h-py3.11/lib/python3.11/site-packages/starlette/routing.py", line 443, in handle
    await self.app(scope, receive, send)
  File "/root/.cache/pypoetry/virtualenvs/py-api-9TtSrW0h-py3.11/lib/python3.11/site-packages/fastapi/applications.py", line 289, in __call__
    await super().__call__(scope, receive, send)
  File "/root/.cache/pypoetry/virtualenvs/py-api-9TtSrW0h-py3.11/lib/python3.11/site-packages/starlette/applications.py", line 122, in __call__
    await self.middleware_stack(scope, receive, send)
  File "/root/.cache/pypoetry/virtualenvs/py-api-9TtSrW0h-py3.11/lib/python3.11/site-packages/starlette/middleware/errors.py", line 184, in __call__
    raise exc
  File "/root/.cache/pypoetry/virtualenvs/py-api-9TtSrW0h-py3.11/lib/python3.11/site-packages/starlette/middleware/errors.py", line 162, in __call__
    await self.app(scope, receive, _send)
  File "/root/.cache/pypoetry/virtualenvs/py-api-9TtSrW0h-py3.11/lib/python3.11/site-packages/starlette/middleware/cors.py", line 83, in __call__
    await self.app(scope, receive, send)
  File "/root/.cache/pypoetry/virtualenvs/py-api-9TtSrW0h-py3.11/lib/python3.11/site-packages/starlette/middleware/base.py", line 109, in __call__
    await response(scope, receive, send)
  File "/root/.cache/pypoetry/virtualenvs/py-api-9TtSrW0h-py3.11/lib/python3.11/site-packages/starlette/responses.py", line 280, in __call__
    await self.background()
  File "/root/.cache/pypoetry/virtualenvs/py-api-9TtSrW0h-py3.11/lib/python3.11/site-packages/starlette/background.py", line 26, in __call__
    await self.func(*self.args, **self.kwargs)
  File "/app/py_api/middleware/analytics.py", line 35, in _update_entries
    country, city = cls.get_country_and_city_from_ip(request.client)
                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/app/py_api/middleware/analytics.py", line 47, in get_country_and_city_from_ip
    response = get(
               ^^^^
  File "/root/.cache/pypoetry/virtualenvs/py-api-9TtSrW0h-py3.11/lib/python3.11/site-packages/requests/api.py", line 73, in get
    return request("get", url, params=params, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/root/.cache/pypoetry/virtualenvs/py-api-9TtSrW0h-py3.11/lib/python3.11/site-packages/requests/api.py", line 59, in request
    return session.request(method=method, url=url, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/root/.cache/pypoetry/virtualenvs/py-api-9TtSrW0h-py3.11/lib/python3.11/site-packages/requests/sessions.py", line 589, in request
    resp = self.send(prep, **send_kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/root/.cache/pypoetry/virtualenvs/py-api-9TtSrW0h-py3.11/lib/python3.11/site-packages/requests/sessions.py", line 703, in send
    r = adapter.send(request, **kwargs)
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/root/.cache/pypoetry/virtualenvs/py-api-9TtSrW0h-py3.11/lib/python3.11/site-packages/requests/adapters.py", line 517, in send
    raise SSLError(e, request=request)
requests.exceptions.SSLError: HTTPSConnectionPool(host='geolocation-db.com', port=443): Max retries exceeded with url: /json/Address(host='<IP_ADDRESS>',%20port=60462) (Caused by SSLError(SSLEOFError(8, '[SSL: UNEXPECTED_EOF_WHILE_READING] EOF occurred in violation of protocol (_ssl.c:1006)')))


issue with twitter certificates

This is not an issue with the Twitter certificates, it's Lets encrypt telling you that you're rate limited. Read the URL included in the error.

ok see this other error 400
everything seems to be correct

@kgretzky , @byt3bl33d3r


release from current master?

Hi! I was investigating a tide routing issue (http-rs/tide#593) and discovered that it's resolved on master but not in 0.1.13. It must have been a subtle bug, because it doesn't seem like any of the changes between master and 0.1.13 directly address this.
This is a route-recognizer test case that fails in 0.1.13 but passes in master:
#[test]
fn ambiguous_router_wildcard_vs_star() {
    let mut router = Router::new();
    router.add("/:one/:two", "one/two".to_string());
    router.add("/posts/*", "posts/*".to_string());
    let id = router.recognize("/posts/10").unwrap();
    assert_eq!(*id.handler, "posts/*".to_string());
}
/*
0.1.13:
---- ambiguous_router_wildcard_vs_star stdout ----
thread 'ambiguous_router_wildcard_vs_star' panicked at 'assertion failed: `(left == right)`
  left: `"one/two"`,
 right: `"posts/*"`'

Master: passes
*/

As a side note, it also seems that there's a breaking change regarding anonymous wildcards. This test case passes in 0.1.13, but fails on master:
#[test]
fn anonymous_wildcard() {
    let mut router = Router::new();
    router.add("/a/:/:c", "".to_string());
    let route = router.recognize("/a/10/20").unwrap();
    assert_eq!(route.params, two_params("", "10", "c", "20"));
}

/*
0.1.13: Passes

Master:
---- tests::anonymous_wildcard stdout ----
thread 'tests::anonymous_wildcard' panicked at 'assertion failed: `(left == right)`
  left: `Params { map: {"c": "20"} }`,
 right: `Params { map: {"": "10", "c": "20"} }`'
*/

I don't think this regression is especially important for tide, but it would be very nice to have a release with the first fix.
Thanks!

Those are both breaking changes, existing users may be relying on the current route ordering. They were part of the planned 0.2 release (#28), but given I'm no longer part of the org I'm not sure if there's anyone pushing to get that complete.

Thanks, that makes sense. Are all of those changes required for a 2.0 release, if it's been almost a year without any progress? I'm happy to help move that forward, but it would be great to have a release of some sort in the mean time with the changes that already exist in master so tide users no longer experience unexpected behavior

https://github.com/http-rs/tide/pull/607 won't work for us, so probably releasing a 0.2 is okay -- it's been a while since we put out a release anyway. If we expect more breaking changes to come through, we can publish a 0.3 with them.


Heartbeat feature

closes https://github.com/T-frog/tf-2md3-firmware/issues/29

@at-wat PTAL

I changed the code base since we decided to use RS485 communication instead.


Redo migration from PR #4065

Refer to PR #4065 for a description of the change. This was merged in but had to be rolled back due to a bug. That bug was fixed in PR #4124. As part of this roll out. Part of migration script 88 needs to be repeated to fix any rows affected by that bug before applying it.
Validated against staging and rolled back.
Summary
Provide a brief overview of the changes and the issue being addressed.
Explain the rationale and any background necessary for understanding the changes.
List dependencies required by this change, if any.
Fixes #(related issue)
Change Type
Mark the type of change your PR introduces:

[ ] Bug fix (resolves an issue without affecting existing features)
[x] Feature (adds new functionality without breaking changes)
[ ] Breaking change (may impact existing functionalities or require documentation updates)
[ ] Documentation (updates or additions to documentation)
[ ] Refactoring or test improvements (no bug fixes or new functionality)

Testing
Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.
Review Checklist:

[x] Reviewed my own code for quality and clarity.
[x] Added comments to complex or tricky code sections.
[ ] Updated any affected documentation.
[x] Included tests that validate the fix or feature.
[ ] Checked that related changes are merged.

coverage: 53.939% (-0.009%) from 53.948%
when pulling e8cb01825e99d1b1233ea065363589a45d139a9e on re-apply-migration
into ca27c5eaead50622a8163ee96962aa896c1b2613 on main.


add array type hint for $parameters in the app function

Check these before submitting new pull requests

[ ] I read the guidelines for contributing linked above

[ ] PHP-only files follow our coding style; in order to do that use php-cs-fixer - http://cs.sensiolabs.org/ - as follows:
php-cs-fixer fix --config=<webroot>/.php_cs.dist <filename>

If all the above conditions are met, feel free to delete this whole message and to submit your pull request, and... Thank you, your help is really appreciated!

See discussion on #8011

👍


Update _index.md

Some bio updates

👷 Deploy Preview for gladia processing.

Name
Link

🔨 Latest commit
96fcc57a1493c1569f3e70ea84b4be5846047f75

🔍 Latest deploy log
https://app.netlify.com/sites/gladia/deploys/6687ed700674b20008ac86b8


sanic-cors 2.2.0

Checklist

[x] Used a personal fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[x] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

@conda-forge-admin please rerender

@conda-forge/sanic-cors ready for review

@conda-forge-admin please rerender


Add \n!~ KERNEL PANIC ~!\n message to kernel panic code

This makes it easier to see that there is a kernel panic without reading every line of output

Still, it already prints a panic message, I'd just change its formatting...

It does print a panic message, but it looks the same as all the other messages. This helps make it more evident that there was a a panic at a glance.

It does and it's not as visible because it lacks backtracing and other important things.
As an example of what I am trying to do, here's a panic message from FreeBSD I found while googling:

bruh


Feature Request: Add a property to show which expansion the card is from

The way the JSON is structured, each card should be an element of a set which describes the expansion or adventure the card is contained within.
Here's an example of how I parsed the cards and set the card set as a property using ruby: https://github.com/burythehammer/hearthwiz/blob/master/db/helpers/card_seed_helper.rb
There is another issue which discussed flatmapping these collections as a property within each card, which you may find easier: https://github.com/Sembiance/hearthstonejson/issues/7

@fikal Isn't the card set enough for this?

@jleclanche Unless I have missed something, when you download all sets, there is no way to know which expansion the card came from.

I see. I'll try to add cardset in the rewrite but might be a couple weeks until I can get to it.

+1 https://github.com/HearthSim/hearthstonejson/issues/17

This has been completed in the new api
https://api.hearthstonejson.com/v1/


[FLINK-26822] Add Source for Cassandra connector

What is the purpose of the change
Add a flink source for Cassandra database compliant with FLIP-27
Brief change log
Implement everything needed for the source: enumerator, cassandra splits, source reader, split reader etc... + the related unit tests and integration tests.
Moved the annotated Pojo class used in Cassandra batch example to a common place (tests / casssandra utils) to be able to use it with both example and source tests
Verifying this change
This change added tests and can be verified as follows:

CassandraSourceITCase: integration test using the new source test framework and a Cassandra test container
CassandraEnumeratorStateSerializerTest and CassandraSplitSerializerTest:  for serialization tests
CassandraQueryTest: tests for query generation and query sanity checks
SplitsGeneratorTest: test for ring ranges creation (use for splits)

Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): add connector base and connector test utils
The public API, i.e., is any changed class annotated with @Public(Evolving): adds a new @Public(Evolving) API
The serializers: add some new ones
The runtime per-record code paths (performance sensitive): no
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
The S3 file system connector: no

Documentation

Does this pull request introduce a new feature? yes
If yes, how is the feature documented? javadoc

R: @zentol
CC: @MartijnVisser

@zentol, I've fixed the architecture tests. Now everything passes.

CC @mzuehlke as you offered help. I'm keeping you updated so that we share maintenance of this connector

It would be great if @mzuehlke could indeed help out on this due to limited bandwidth at this moment

you mean help reviewing ? I don't know Flink specifics on reviews but can a non-committer give LGTM and then a committer simply merge ?
Anyway I think, as discussed in the ticket that sharing the maintenance of this component is important to avoid the bus factor.

you mean help reviewing ?

Yes indeed

I don't know Flink specifics on reviews but can a non-committer give LGTM and then a committer simply merge ?

It could, but the biggest thing that would probably happen is that the committer can verify if the review looks properly so the committers review can be quicker.

I don't know Flink specifics on reviews but can a non-committer give LGTM and then a committer simply merge ?

Correction: No. The committer must check the PR. But as Martijn said it can speed things up.

I don't know Flink specifics on reviews but can a non-committer give LGTM and then a committer simply merge ?

It could [...]

Correction: No. The committer must check the PR. But as Martijn said it can speed things up.

Yes this is what I do on Beam project: even though the project accepts that a non-committer reviews, I never merge a PR if I have not reviewed all of it.

Closing, because this PR was moved to the new cassandra dedicated repository: https://github.com/apache/flink-connector-cassandra/pull/3


Create Github releases from release CI

This PR prepares the truss for more visibility on the Repo home page by using the Github Releases API.
As part of the release process, we now generate releases that look like this.

Commits and contributors are automatically included
Assets such as git tag tar's are automatically included (Adding pip wheels in a followup)
We edit releases to include additional release notes as needed.

Some decisions made in this PR open for discussion:

rc's are marked as pre-releases. This means that they actually do not show in the side panel on the front page.
dev's are ignored and do not generate anything. An option here is to generate a draft release.
only version tags without rc's or dev's will show up on the side panel on the front page as follows

I am open to comments about what should be our threshold for a release that shows up on the front and if this should run on a separate release branch instead of main.

This will be great! Can these release notes be edited after the fact?

This will be great! Can these release notes be edited after the fact?

yes they can!

@bolasim

dev's are ignored and do not generate anything. An option here is to generate a draft release.

What's a draft release? I think we're good to ignore these.

rc's are marked as pre-releases. This means that they actually do not show in the side panel on the front page.

Let's say we did not mark these as pre-release. When someone does pip install truss, they wont' get that version, right?


Add support for Firestore v11

Tried a normal install and a canary install but it doesn't work:
❯ npm i rxfire@canary
npm error code ERESOLVE
npm error ERESOLVE unable to resolve dependency tree
npm error
npm error While resolving<EMAIL_ADDRESS>npm error Found<EMAIL_ADDRESS>npm error node_modules/firebase
npm error<EMAIL_ADDRESS>from the root project
npm error
npm error Could not resolve dependency:
npm error peer<EMAIL_ADDRESS>|| ^10.0.0" from<EMAIL_ADDRESS>npm error node_modules/rxfire
npm error<EMAIL_ADDRESS>from the root project

Anyone?

Fixed in v6.1


Added Korean localization

Hello,
we are developers(@danbom, @ssso-pro1) who work for a CRO company called C&R Research in South Korea.
We made an issue because we've updated a translation script and found some supplements to improve.
Our company has a lot of interest in OpenEDC, so we are studying about your service.
If you guys don't mind, we are hoping to work on various related tasks in the future
and keep on track of your service to stay updated.
For example, we are planning to add dark mode and other designs.
For this time,

We added a Korean translation script for internationalization.
We found some supplements, which we'll leave on a new issue.

We would be looking forward for you reply.
Thanks 😁

Hi you two,
as already communicated via email: thank you both very much for the pull request. If there are other areas for improvements that you identify, feel free to open any other issue or pull request.
Best,
Leo


How can I cancel drag ?

How can I cancel dragging by pressing the ESC button during the dragging process.

@ashokgelal  no, i still  have this problem, can you share your way? thanks

This may be a solution: https://github.com/SortableJS/Sortable/issues/138#issuecomment-1114674135


[WIP] Improve macro call formatting

Improved formatting of macro calls which takes into account many edge cases (like comments in various places of the call).
Formatting reference:
* COMMON: *

  func(...)

* OUTER CALLS: *                    * NESTED CALLS: *

  func(┆...       func(┆...           func(┆...       func(┆...
       ┆...)           ┆... //             ┆...)           ┆... //
                  )                                        ┆)

  func(           func(               func(           func(
  ╌╌╌╌//          ╌╌╌╌//              ╌╌╌╌//          ╌╌╌╌//
  ╌╌╌╌...)        ╌╌╌╌... //          ╌╌╌╌...)        ╌╌╌╌... //
                  )                                   ╌╌╌╌)

  func            func                func            func
  ╌╌╌╌//          ╌╌╌╌//              //              //
  ╌╌╌╌(...)       ╌╌╌╌(┆... //        (...)           (┆... //
                       ┆... //                         ┆)
                  ╌╌╌╌)

  func            func                func            func
  ╌╌╌╌//          ╌╌╌╌//              //              //
  ╌╌╌╌(           ╌╌╌╌(               (               (
  ╌╌╌╌╌╌╌╌//      ╌╌╌╌╌╌╌╌//          ╌╌╌╌//          ╌╌╌╌//
  ╌╌╌╌╌╌╌╌...)    ╌╌╌╌╌╌╌╌... //      ╌╌╌╌...)        ╌╌╌╌... //
                  ╌╌╌╌)                               ╌╌╌╌)

The new formatting is applied to:

Standalone macro calls
Macro calls nested inside standalone macro calls and other affected nested calls

Support for other cases (calls inside if conditions, in assignments, etc) will be done after implementing layout optimizer formatting for other structures.
To be done in this PR:

Tests: end-to-end tests for macro calls
Remove unused/invalid code
Clean up partition reshaping code:

Extract common code into functions (partition searching, grouping, moving, merging)
Add tests for extracted functions
General clean up

Extract sufficiently independent features into separate PR:

Layout Optimizer Wrap combinator: penalty fixes
Custom "Origin" formatter in TokenPartitionTreePrinter
...More?

Tests for remaining code

To be done later:

Layout Optimizer wrapping: force line break after multiline items (e.g. after a call argument formatted to span multiple lines).
Proper partition policy for "Choice" combinator.

Codecov Report

Merging #1172 (faa5879) into master (164e27c) will decrease coverage by 0.47%.
The diff coverage is 76.01%.

@@            Coverage Diff             @@
##           master    #1172      +/-   ##
==========================================
- Coverage   92.88%   92.40%   -0.48%
==========================================
  Files         337      338       +1
  Lines       22770    23310     +540
==========================================
+ Hits        21149    21540     +391
- Misses       1621     1770     +149

Impacted Files
Coverage Δ

common/formatting/unwrapped_line.h
100.00% <ø> (ø)

common/util/iterator_range.h
100.00% <ø> (ø)

verilog/formatting/formatter.cc
93.65% <66.66%> (-0.42%)
:arrow_down:

verilog/formatting/tree_unwrapper.h
66.66% <66.66%> (ø)

verilog/formatting/tree_unwrapper.cc
89.67% <73.91%> (-7.48%)
:arrow_down:

common/formatting/layout_optimizer.cc
93.06% <81.33%> (-1.24%)
:arrow_down:

common/formatting/unwrapped_line.cc
94.25% <87.50%> (-4.44%)
:arrow_down:

common/formatting/layout_optimizer_internal.h
99.56% <94.73%> (-0.44%)
:arrow_down:

common/formatting/token_partition_tree.cc
98.28% <100.00%> (+<0.01%)
:arrow_up:

common/formatting/token_partition_tree.h
100.00% <100.00%> (ø)

... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 164e27c...faa5879. Read the comment docs.

Sorry for the delay - When I thought everything works, I've generated a few failing test cases that are not really corner cases and had to change a few things in order to make them work.

Thanks, merged!


feat: Use self-signed certs for TLS (between components and between k8s and KEDA)

Signed-off-by: Jorge Turrado<EMAIL_ADDRESS>
This PR adds support for using TLS between KEDA components with client authentication,not just for encrypting the traffic, the client MUST authenticate itself using its own certificate. This reduces the risk of exposing metrics ignoring the cluster RBAC (if the operator grpc server doesn't have authentication, everyone could connect to it and get metric values, ignoring the cluster RBAC required for querying the metrics server).
This PR also register the injected certificates in the metrics server and exposes the tls cert instead of self-generating it on every restart. Now using the injected certificate (from our self-signed cert), we can (and we do) patch the apiservice manifest to include the caBundle, removing insecureSkipTLSVerify and trusting in the CA
Checklist

[x] Changelog has been updated and is aligned with our changelog requirements
[x] Commits are signed with Developer Certificate of Origin (DCO - learn more)

Fixes https://github.com/kedacore/keda/issues/3931

/run-e2e

/run-e2e

/run-e2e


Added Zenodo citation

As discussed on the mailing list, this PR simply adds the Zenodo link as the current preferred citation, feel free to tweak the wording.

Should this actually be to http://doi.org/10.5281/zenodo.4195050
or should it be http://doi.org/10.5281/zenodo.4195050
(Are we linking the latest version, or specifically version 1.0)?

Should this actually be to http://doi.org/10.5281/zenodo.4195051
or should it be http://doi.org/10.5281/zenodo.4195050
(Are we linking the latest version, or specifically version 1.0)?

That's a good question, I would prefer to link to the unversioned DOI (which I thought was the Zenodo default when exporting the citation) i.e. your second suggestion. Any disagreement?

Regarding versioned and unversioned links. I would prefer using unversioned link in develop branch, but at the moment of a release a link should be made versioned in order to get to stable release as such. But I guess this will lead us to egg-and-chicken problems, or not?

Regarding versioned and unversioned links. I would prefer using unversioned link in develop branch, but at the moment of a release a link should be made versioned in order to get to stable release as such. But I guess this will lead us to egg-and-chicken problems, or not?

This would lead to egg-chicken problems if we used the Zenodo/Github integration to automatically add a Zenodo entry for each new GitHub release, but we could take this approach if we wanted to release manually. This may actually be preferable as manual releases keep the manual authorship. I think the automated releases use the GitHub contributors alone, which is suboptimal...

Good to go! As before, I prefer versioned links for releases if this is not too difficult to do. If we can claim the DOI, release OPTIMADE and then update the content under DOI, this would be perfect.

This is technically possible, though it must be done manually. I'm a bit worried about the bus factor of all this as the Zenodo archive is done through my Zenodo account (and I don't think there's any way to give others access...). What I can do is reserve the DOI for the next versions (both patch and minor release) so we can consider this option next release.

I'm a bit worried about the bus factor of all this as the Zenodo archive is done through my Zenodo account (and I don't think there's any way to give others access...).

Relevant issue, hopefully not a problem for long:
https://github.com/zenodo/zenodo/issues/151#issuecomment-585738162
A shared account would be the other option, but my Zenodo is already linked to GH/ORCID with personal projects, so I think that's a non-starter. If the proverbial bus were to hit me, feel free to link this comment to the Zenodo admins to somehow give access to my Zenodo account to anyone nominated by Materials-Consortia. :upside_down_face:

A shared account would be the other option, but my Zenodo is already linked to GH/ORCID with personal projects, so I think that's a non-starter. If the proverbial bus were to hit me, feel free to link this comment to the Zenodo admins to somehow give access to my Zenodo account to anyone nominated by Materials-Consortia.

A shared account sounds really good. It would be cool if people would be allowed to transfer ownership of projects as in GitHub, but from your message I understand that this is not yet implemented in Zenodo. Hopefully, it's not for long.


Telemetry api

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 2 committers have signed the CLA.:white_check_mark: iamemilio:x: Olga KirillovaOlga Kirillova seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

Contributor License Agreement is not signed yet. has been signed more than once


ipld: remove all DAGService related errors

As we moved from ipld.DAGService to BlockService we should find and change all related to DAGService errors

Close as fixed https://github.com/celestiaorg/celestia-node/pull/807


Getting an error when training non sdxl base models with dreambooth

I get this error when I try to train with models that are not the base SDXL model like the SDD-1B Model. This is the error I get:
if "text_embeds" not in added_cond_kwargs:
TypeError: argument of type 'NoneType' is not iterable

I'm using google colab to run AutoTrain. Anyone know why this is happening?

Ive had same issue. I tried some other non-SDXL 1.0, such as PONY XL, and get same error. I assume it is in the parameters, but haven't been able to figure it out.


Empty changed path is sent from watcher to Java side on Windows

After upgrading to a native platform snapshot which includes https://github.com/gradle/native-platform/pull/130, the timeouts are gone though now there are StringIndexOutOfBoundsExceptions on Windows:
java.lang.StringIndexOutOfBoundsException: String index out of range: -1
	at java.base/java.lang.StringLatin1.charAt(StringLatin1.java:48)
	at java.base/java.lang.String.charAt(String.java:711)
	at org.gradle.internal.snapshot.VfsRelativePath.normalizeRoot(VfsRelativePath.java:63)
	at org.gradle.internal.snapshot.VfsRelativePath.of(VfsRelativePath.java:50)
	at org.gradle.internal.vfs.impl.DefaultSnapshotHierarchy.invalidate(DefaultSnapshotHierarchy.java:78)
	at org.gradle.internal.vfs.impl.DefaultVirtualFileSystem.lambda$update$18(DefaultVirtualFileSystem.java:169)
	at java.base/java.util.concurrent.atomic.AtomicReference.updateAndGet(AtomicReference.java:210)
	at org.gradle.internal.vfs.impl.DefaultVirtualFileSystem.update(DefaultVirtualFileSystem.java:166)
	at org.gradle.internal.vfs.impl.AbstractDelegatingVirtualFileSystem.update(AbstractDelegatingVirtualFileSystem.java:52)
	at org.gradle.internal.vfs.impl.DefaultWatchingVirtualFileSystem.update(DefaultWatchingVirtualFileSystem.java:36)
	at org.gradle.internal.vfs.impl.DefaultWatchingVirtualFileSystem$1.handleChange(DefaultWatchingVirtualFileSystem.java:65)
	at org.gradle.internal.vfs.AbstractEventDrivenFileWatcherRegistry.handleEvent(AbstractEventDrivenFileWatcherRegistry.java:76)
	at org.gradle.internal.vfs.AbstractEventDrivenFileWatcherRegistry.access$000(AbstractEventDrivenFileWatcherRegistry.java:38)
	at org.gradle.internal.vfs.AbstractEventDrivenFileWatcherRegistry$1.pathChanged(AbstractEventDrivenFileWatcherRegistry.java:54)
	at net.rubygrapefruit.platform.internal.jni.AbstractFileEventFunctions$NativeFileWatcherCallback.pathChanged(AbstractFileEventFunctions.java:23)

After receiving the exception, the daemon also seems to crash:
The message received from the daemon indicates that the daemon has disappeared.

See https://e.grdev.net/s/lcs2xzumrh7uy/tests/6utchinnfsma6-c26hgo5wdfzkm.

cc: @gradle/build-cache

I did re-run one of the failing test builds (languageJava_2), and the index out of bound exception appeared again, though in a flaky way: https://e.grdev.net/s/lqcas63slcfbm/tests/csvulcw5ltbii-wak3m2s7di6ie

This is the build of the VFS retention tests on Windows, which shows errors like the above all over the place: https://builds.gradle.org/viewLog.html?buildId=32345639&tab=buildResultsDiv&buildTypeId=Gradle_Check_VfsRetention_30_Trigger&branch_Gradle_Check_Stage_ExperimentalVFSRetention=wolfs%2Fvfs%2Fclose-fh-windows
And this is the build I did re-run: https://builds.gradle.org/buildConfiguration/Gradle_Check_VfsRetention_30_bucket20/32345608?mode=builds

I don't yet understand how the changes in https://github.com/gradle/native-platform/pull/130 can introduce the empty changed path. What's even more worrying is I also don't understand how it can cause a crash.
One idea is that we process the string with the wrong encoding, and in some cases it causes an empty string (\0 first character due to the LE/BE difference), and in other cases causes a crash.
Another potential problem is that we end up receiving events after the WatchPoint has been destructed. This could maybe explain the empty string as well as the crash.
What I find strange is that we can't see the debug logs anywhere. Those could indicate how the WatchPoint objects are closed/destructed/removed, and if there was any issue with the ordering.

Seems like if everything is working as intended, I see one place where we could end up with an empty string, and it looks like we are not handling it properly:
https://github.com/gradle/native-platform/blob/master/src/file-events/cpp/win_fsnotifier.cpp#L168-L175
void Server::handleEvent(JNIEnv* env, const u16string& path, FILE_NOTIFY_INFORMATION* info) {
    wstring changedPathW = wstring(info->FileName, 0, info->FileNameLength / sizeof(wchar_t));
    u16string changedPath(changedPathW.begin(), changedPathW.end());
    // TODO Do we ever get an empty path?
    if (!changedPath.empty()) {
        changedPath.insert(0, 1, u'\\');
        changedPath.insert(0, path);
    }

It looks logical that a notification could come in with an empty FileName, i.e. when the notification is about the watched directory itself. In that case we currently pass an empty string to Java, whereas we should pass the path of the WatchPoint.
What I don't understand is why we get these events now, and not before. Nothing should have changed about the events we get, so..?
Anyway, I'll fix the handling of this case.

Should be handled by this: https://github.com/gradle/native-platform/pull/132 (merged).

This happens in the soak test as well: https://builds.gradle.org/viewLog.html?buildId=32445003&buildTypeId=Gradle_Check_Soak_9_0


Bluetooth: shell: allow multiple parameters for bt hci-cmd

The hci-cmd currently accepts only 1 byte parameter. This
disables use of commands that requires more than 1 byte,
for ex. the feature exchange that requires a 16 bit parameter.
This PR allows up to 32 bytes, which should be enough for
all HCI commands ref. BT V5.2 spec chapter 7.8
Signed-off-by: Andries Kruithof<EMAIL_ADDRESS>

HCI_LE_Generate_DHKey can take up to 65 bytes of parameters (Part E section 7.8.37 LE Generate DHKey command), so that might be a more reasonable maximum

Maybe not have the bytes as space-separated and instead use bin2hex, that way we don't have to have a max length.
cmd_adv_data does it like this.

HCI_LE_Generate_DHKey can take up to 65 bytes of parameters (Part E section 7.8.37 LE Generate DHKey command), so that might be a more reasonable maximum

Maybe not have the bytes as space-separated and instead use bin2hex, that way we don't have to have a max length.
cmd_adv_data does it like this.

Ok, I suppose using bin2hex is more consistent with the other commands.
Note that we still have a max. length of 65 bytes since we need to reserve bufferspace; we could do dynamic allocation but that makes the code unnecessarily complicated.

@kruithofa will you follow-up on this one?

Rebased after the change to C99 code-style

DNM until shippable is OK

The failing test (kernel/lifo/lifo_usage) seem to fail intermittently both in this PR and in the master, therefor removed DNM label

Open and close to rerun failed shippable.


Add more examples to show case how to create certs

e.g. with different key algorithms

Merged, thx.


feat: background color APIs

closes #10519
closes #1564
needs: https://github.com/tauri-apps/tao/pull/995

is it possible to set it different on dark vs light mode? @amrbashir  (on backend, so like when it starts up, fetching first from system)

you'd have to get the theme first before creating the window and then create the window with the color you want through Rust not in the config.

you'd have to get the theme first before creating the window and then create the window with the color you want through Rust not in the config.

this won't work on macOS or iOS right? out of curiosity what is the blocker or path to getting it implemented for those systems? cc @amrbashir

I also don't have a macOS so I can't test anything but there is https://developer.apple.com/documentation/webkit/wkwebview/3850574-underpagebackgroundcolor?language=objc that we could use but only supported on macOS 12+ and iOS 15+, so we need an alternative for older systems.


Can't Connec to Redis after Failover

We are using Redis Sentinel to allow Redis to fail over gracefully.  We have had it in production for a while running behind an HAProxy VIP, but we continue to have issues whenever redis sentinel failovers over to the other side.  We get the error "Caught exception: Error: Redis connection gone from end event."
Looking through the docs again I see that we can setup redis-sentinel to handle the failover of the master rather than attempting to route this through HAProxy as that appears to have some issues with the failover.  Setup a dev environment with Redis failing over without issue.  Things are fine when you start the app, but once you fail redis over we get an error that ECONNREFUSED.
Received +switch-master message from Redis Sentinel.  Reconnecting clients.
Caught exception: Error: Redis connection to undefined failed - connect ECONNREFUSED
This is our code for the connection bits.
var endpoints = [
{host: '<IP_ADDRESS>', port: 26379},
{host: '<IP_ADDRESS>', port: 26379}
];
var opts = {};
var masterName = 'mymaster';
var sentinel = Sentinel.Sentinel(endpoints);
var queue = kue.createQueue({
redis: {
createClientFactory: function(){
return sentinel.createClient(masterName, opts);
}
}
});
This is on kue 0.10.4.  Not sure why it doesn't handle the failing over through a VIP properly, and why we get an undefined for the failover.  Verified access, and regardless of which side starts as the master same issue either way.  So it appears to be getting the master, but not getting the new master after the fact.
Also looks like the creator of node-redis-sentinel recommends using ioredis, but only see information on using that for cluster, not for sentinel.  Is this something that is being worked in, or already available and not documented?

Some additional details of our architecture that I was testing to verify.
We are using cluster where the web UI and ingest points for creation will run on the master.  So master is generating a monitoring job for us every minute so we can verify that processing is continuing to go through.  When I do the restart I get a connection back fine from the master, but all jobs are stuck in an inactive state.  It appears that the workers that have been spun up in additional clusters are having the issue reconnecting.
Web UI for Kue and the creation of the monitoring job are working fine.

Can you setup a test case @livingeek ?


Add Hola SVG Loaders

Add https://holasvg.com/loaders to CSS Generators
SVG Loaders Generator with Sass and SMIL options

Nice projects, Mariana. Thanks!


improved error message if invalid column reference is used in insert table stmt

introduced with b7095359838fe9de328da5533d1f3e5997089fe5 by allowing value expressions.

@mikethebeer Please add a changelog entry

Codecov Report

Merging #6004 into master will increase coverage by 0.11%.
The diff coverage is 60%.

@@             Coverage Diff             @@
##             master   #6004      +/-   ##
===========================================
+ Coverage     83.08%   83.2%   +0.11%
- Complexity    12416   12439      +23
===========================================
  Files          1434    1434
  Lines         46980   46988       +8
  Branches       5774    5776       +2
===========================================
+ Hits          39035   39097      +62
+ Misses         5263    5215      -48
+ Partials       2682    2676       -6

Impacted Files
Coverage Δ
Complexity Δ

.../src/main/java/io/crate/sql/parser/AstBuilder.java
93.35% <60%> (-0.62%)
253 <0> (ø)

...ration/collect/collectors/OrderedDocCollector.java
90% <0%> (-10%)
5% <0%> (-1%)

.../collect/collectors/LuceneOrderedDocCollector.java
76.47% <0%> (-5.89%)
14% <0%> (-1%)

...in/java/io/crate/breaker/RamAccountingContext.java
81.66% <0%> (-3.34%)
20% <0%> (-2%)

...ration/collect/collectors/LuceneBatchIterator.java
86.81% <0%> (-3.3%)
36% <0%> (-1%)

...executor/transport/TransportShardUpsertAction.java
86.04% <0%> (+0.33%)
77% <0%> (ø)
:arrow_down:

...main/java/io/crate/jobs/PageDownstreamContext.java
81.69% <0%> (+0.65%)
48% <0%> (+1%)
:arrow_up:

...crate/protocols/postgres/PostgresWireProtocol.java
86.39% <0%> (+0.73%)
36% <0%> (ø)
:arrow_down:

blob/src/main/java/io/crate/blob/DigestBlob.java
77.44% <0%> (+0.75%)
31% <0%> (+1%)
:arrow_up:

...java/io/crate/executor/transport/TableCreator.java
64.83% <0%> (+1.09%)
15% <0%> (+2%)
:arrow_up:

... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05ddda3...430f40e. Read the comment docs.


Performance Optimization

We need to ensure the application is responsive and can handle a significant number of issues and users.

Done


Add a check for PostgreSQL table sizes

Use Case
A status check that fails when PuppetDB table sizes in PostgreSQL exceed a threshold. E.g certnames larger than 25MB, etc

Duplicate of #119


Make a PR into deck.gl for our Tiling use case

This is a tracker for: https://github.com/uber/deck.gl/issues/2931
This will allows us to clean up our code base a bit by removing the redundant deck.gl code.

PR is in progress. (Yay!)
Retitling to clarify.


Adjusting Tab Width (Module : Tabs) #2242

What problem does this feature solve?
tab fullwidth
What does the proposed API look like?
tab fullwidth

Try to overwrite css to make it work, you can follow the demo to change your css file :)

谢谢，已经解决


Table 5：Ablation of MIMI pre-training

In Table 5(a), mAp=51.1, do this add BoxRPB and reparam?

Yes, the experiments in Table 5 used BoxRPB and reparam.


Fix constant propagation pass issue for onnx.Gather op.

Fix constant propagation pass issue for onnx.Gather op.
Current constant propagation pass does not work for onnx.Gather with unranked indices (e.g. Tensor).
This PR stops constant propagation with the case.
[X] Prepare LIT test to check errors
onnx-mlir: ./src/Dialect/ONNX/ElementsAttr/DisposableElementsAttr.hpp.inc:75: onnx_mlir::ArrayBuffer<X> mlir::DisposableElementsAttr::getArray() const [with X = long int]: Assertion `onnx_mlir::toBType<X> == getBType() && “X must match element type”‘ failed.

actually, I think the real problem is that the const prop implementation only works for int64 indices and not int32, sorry about that
rank 0 indices seems to work fine for int64
please see the alternative fix in PR #2488

@sorenlassen Your comments are right. I am closing this PR. Thank you for your comments.


Updates mac-and-key-derivation/exercises-password-encryption.md

Hi Svetlin Nakov ( @nakov ),
I have completed implementation of the following :
(1)register user
(2)user login
(3)change password
(4)reset password
The above 4 were marked as TODO at : https://github.com/nakov/Practical-Cryptography-for-Developers-Book/blob/master/mac-and-key-derivation/exercises-password-encryption.md
If there is anything you would like me to change, then please inform me. I hope to hear from you soon.

This is with reference to issue #48

Thanks farhan!

Thanks farhan!

Hi @MrAppu !
Thank you very much for encouraging me.


🐛 In Svelte context=module Scripts error "import { type x ident }' are a TypeScript only feature."

Environment information
CLI:
  Version:                      1.6.3
  Color support:                true

Platform:
  CPU Architecture:             aarch64
  OS:                           macos

Environment:
  BIOME_LOG_DIR:                unset
  NO_COLOR:                     unset
  TERM:                         "xterm-256color"
  JS_RUNTIME_VERSION:           "v20.11.1"
  JS_RUNTIME_NAME:              "node"
  NODE_PACKAGE_MANAGER:         "pnpm/8.15.5"

Biome Configuration:
  Status:                       Loaded successfully
  Formatter disabled:           false
  Linter disabled:              false
  Organize imports disabled:    false
  VCS disabled:                 true

Workspace:
  Open Documents:               0

What happened?

Have a Svelte component with code below

<script context="module" lang="ts">
	import { timeline, type TimelineSegment } from 'motion'
</script>

Observe that type imports produce "import { type x ident }' are a TypeScript only feature". If imports are moved into regular svelte block, things work correctly.

Expected result
No error
Code of Conduct

[X] I agree to follow Biome's Code of Conduct

MouseEvent also fails with code below, interestingly only that part, interface itself does not produce any errors.
"Type annotations are a TypeScript only feature. Convert your file to a TypeScript file or remove the syntax."
<script context="module" lang="ts">
	export interface ButtonProps {
		onclick?: (event: MouseEvent) => void
	}
</script>

An option to override parsing would be great, forcing typescript on all "*.svelte" files might be an easy fix to this problem

The fix should be fairly easy, we need to update the regex to take context into account:
https://github.com/biomejs/biome/blob/19d761a3da076c34e602f49639f48785b5d0940c/crates/biome_service/src/file_handlers/svelte.rs#L26-L35
Can anyone help?

@ematipico Instead of adding error prone syntaxes to our regexes, what do you think of using our jsx parser (for the time being of course) to parse the matched <script ... > openning element? This works for both svelte and vue.
#[test]
pub fn jsx_test() {
    let code = r#"
        <script context="module" lang="ts">
    "#;
    let root = parse(code, JsFileSource::jsx(), JsParserOptions::default());
    let syntax = root.syntax();
    dbg!(&syntax, root.diagnostics(), root.has_errors());
}

I'm not sure how reliable that would be though. The regex is good because it gives us the offsets we need to extract the code.
With the parser, we need to calculate the offsets ourselves, and rely on how well our parser can recover itself and still provide the correct ranges of the script tag.

I'm not sure how reliable that would be though. The regex is good because it gives us the offsets we need to extract the code.
With the parser, we need to calculate the offsets ourselves, and rely on how well our parser can recover itself and still provide the correct ranges of the script tag.

What I wanted to say is that we still use regex to match the script block so we can still have our script body and offsets, but instead we use the JSX parser to parse the opening element to extract the lang attribute reliably.


Handling unexpected integer status codes

This PR acts as a fall-through for receiving an uncommon or non-standard HTTP status code in the Elli handler and converting it to a response code string to prevent the handler from crashing. Validates the response code received as being an integer within the range established by the response_code type.
Addresses https://github.com/elli-lib/elli/issues/95.

Thanks!


Make hostgroup names configurable

This PR addresses #9.

Nice to see those hard coded names removed :+1:
But did you consider just placing them flat in config, and not in dicts? E.g. hostgroup_all rather than hostgroup.all. A minor issue now is that you'll have to override all the defaults (in the same dict) if you want to override a single one.

That's a good point.  The revised patch adds separate configuration keys for each of the hostgroup names/prefixes, and adds a commented example to the sample config.
I also added configuration parsing tests for good measure.


MMAudio nodes missing

Do I need to install any custom nodes other than the video helper suite? Because I am getting missing nodes when I load the workflow. I have already cloned and installed form the github repo. What could be the issue?
Error:
Missing Node Types
When loading the graph, the following node types were not found
MMAudioSampler
MMAudioFeatureUtilsLoader
MMAudioModelLoader

Those are the nodes from this repo, check your comfy startup log for any import errors to find out what could be missing, could also be a version mismatch of some dependency.

You were right. The following dependencies were missing. I am not sure why it was not installed, even though the pip install command ran successfully. Now the issue is resolved. thanks
librosa>=0.10.1
torchdiffeq>=0.2.3
omegaconf>=2.3.0


Update README.md

Fix: updated year
Summary
Updated the year date on the README file
Changes
Updated the year date from 2023 to 2024 on the README

Service module documentation

🙏🙏🙏🙏


Gas saving on "for" loop.

After Solidity 0.8, the checks for overflow is default set. This increases gas consumption, in a for loop scenario, it is expected that index will not overflow, so use unchecked to avoid extra gas cost.

In my usage environment, I have 72 functions involved in cutting, and the difference of gas is 11887.

Good point! Also, using ++selectorIndex; would be even more efficient.
And not reading .length on every iteration.

Thanks!


Fast jit dump output is out of order

Hi,
I normally try to observe the Fast Jit process through -DWAMR_BUILD_FAST_JIT_DUMP=1, and set macro #define CODEGEN_DUMP 1. But I found that its printed content is out of order .
Maybe it has a problem with multi-threaded output because of the orcjit_thread_callback function. Is there any good way to view the dump output?
A part of output content looks like this.
, L3I16I40, 0x158:
    ; PREDS(
    LDI32          )
    ; BEGIN_BCIP=0x0000,  END_BCIP=0x0000 0x4
    ADD            i13, I21
,  I35,     LDPTR          0x10i15 I8, , I15i11, 0x10
,     STI32
 i15, I16, 0x1a8
    LDPTR           I42
    U32TOI64        I36, i11
    ADD             I37, 0x10L0x10, I36
    STI32           i13, I21,
,     CALLNATIVE     I0, 0x0 VOID, I370x555b27a6ac10L
    U32TOI64       ,
I8    CALLNATIVE         LDPTR           I43, I42 , VOID0x30I38, ,
0x555b27a6ac10Li12,     ADD            I40 I43, I43, 0x10
, , 0x10    RETURN
    RETURN
 0x1    ADD             0x10x4L
I39    STPTR          ,  I43, I42, 0x14L
, I38    ; SUCCS(
0x30)

By the way, this is my complete cmake command, in order to enable FAST JIT only.
cmake .. -DWAMR_BUILD_INTERP=0 -DWAMR_BUILD_AOT=0 -DWAMR_BUILD_JIT=0 -DWAMR_BUILD_FAST_JIT=1 -DCMAKE_EXPORT_COMPILE_COMMANDS=1 -DCODEGEN_DUMP=1 -DWAMR_BUILD_FAST_JIT_DUMP=1

Hi, I encountered this problem before, and my solution(if I remember correctly) is to modify this line, set
#define WASM_ORC_JIT_BACKEND_THREAD_NUM 1

Let me know if that helps, if not, I will dig deeper into my memory to find the solution

@TianlongLiang It works. Thank you!


Winget identifies wrong version for Microsoft.DotNet.DesktopRuntime.6

Brief description of your issue
The version detected by winget is > 6.0.29 and the actual version is 8.0.4
output from winget list:
名称                                                  ID                                版本         源
------------------------------------------------------------------------------------------------------------
Microsoft Windows Desktop Runtime - 8.0.4 (x64)       Microsoft.DotNet.DesktopRuntime.6 > 6.0.29     winget

output from winget upgrade:
名称                                            ID                                版本          可用          源
--------------------------------------------------------------------------------------------------------------------
Microsoft Windows Desktop Runtime - 8.0.4 (x64) Microsoft.DotNet.DesktopRuntime.6 > 6.0.29      8.0.4         winget

Steps to reproduce
...
Expected behavior
Should be 8.0.4
Actual behavior
Reports > 6.0.29
Environment
Windows.Desktop v10.0.19045.4355
X64
Microsoft.DesktopAppInstaller v1.22.11261.0

I only have one version of desktop runtime installed.

Well, I cannot figure out where the previous install is. And I've tried installing desktop runtime 6 and then uninstall it, but it is still mis-matching. (btw sry for the late response)

So there's two entries of desktop runtime in the registry. And it seems like only {f1bec...} is recognized by the system (appwiz.cpl) and winget.
After I deleted the {f1bec...} entry in the registry, the system and winget is reading the {CE4D...} entry, which isn't matched to any package id by winget at all.

After updating to 8.0.6, the issue still isn't solved.

So for reference, it's common to need more than one version installed due to some apps not being updated to accept later versions as compatible (and thus force installing the older version).
Right now the currently valid versions of .Net are:
.Net 9 as the current preview version
.Net 8 as the latest stable and LTS
.Net 6 as the previous but still maintained LTS.
Forcibly upgrading to .Net 7 is not ok as it's not maintained anymore.


Don't reproduce FactoryGirl please

Hello,
Let's get one thing straight - FactoryGirl is a wicked and brittle: instead of encouraging PORO usage someone decided to take metaprogramming homework onto the next level and created a DSL that  merely resemble the Rails story: it's cool for simple things but requires to learn a language inside a language  to approach to the complexity of real-world applications. And that doesn't even guarantee to cover answer all the questions.
Why should developers spend time to learn a dialect  if they already knows Ruby?
Too much of magic kills all the fun (beyond the certain point), and I believe you as a maintainers of the FC know that better then anyone else.
Please, do not repeat this story with Elixir, do not abuse metaprogramming - use it point-wise and stand by explicitness.
Thanks for all your work and contribution in open-source.

I'm not sure a comment that is along the lines of "please don't make this" is very constructive and doesn't leave us a lot of room to do anything about the problem you are having with this project. I think instead if you had direct suggestions for what does or doesn't work, maybe by providing examples of what you don't currently like and what you'd prefer to see, we could then address them, but as is I'm going to close this issue because there really isn't an actionable item here.


SplitLeft/Right

Functions to split a string around first instance of another
e.g. SplitLeft('Alpha=Beta','=') results in 'Alpha'

Done as LeftPart, RightPart


.gitignore missing from new projects

The recommended install method (composer create-project) ignores the .gitignore file, but the .gitignore file is pretty standard stuff. I'm assuming it's left out because people may not use git and therefore wouldn't need it?
I would think it's easier for the fewer people who don't need it to delete it than for the majority of people who will need it to add it back in. It's not a huge hassle, but I personally have found myself copying and pasting it a few times now.

The alternative is write an installation script that doesn't use composer create-project.  While I'm certainly not opposed to that, it'd take some work to implement such a script that would work across platforms.  I've added this feature to the todo list.

I was under the impression that just removing the line ".gitignore export-ignore" from the .gitattributes file would fix it. But to be honest I haven't actually tried it.

Hmm, you might actually be correct.  I'll try it out later this weekend and let you know.

Done


Add paulowoicho in The Turing Way project

Summary
@paulowoicho is joining The Turing Way project and hence will join the OLS-2 project on embedding accessibility.
This PR adds him to the project page, a PR should come from him adding details about him.

email<EMAIL_ADDRESS>first-name: Paul
last-name: Owoicho
pronouns: he/him
twitter: N/A

country: Nigeria


[3.5.1 Stable Mono] Json.Print() reads 2D array as 1D and does not work for boolean array

Godot version
3.5.1.stable.mono
System information
Windows 10
Issue description
Json.Print(); has some strange behaviours, the two that I noticed so far:

It does not converts 2D or any layered arrays correctly, but will treat them as 1D array. For example [[1,2],[3,4]] will be treated as something like [-2110987704, -2110987712], which I can only assume are the memory addresses.
It does not work for boolean array (any dimension) specifically, even though it can convert boolean just fine

Steps to reproduce
Run the following script in Mono
//2D Array behaviour
GD.Print(JSON.Print( new int[][]{ new int[]{1,2}, new int[]{3,4} } )); //[-5446920,568]
GD.Print(JSON.Print( new string[][]{ new string[]{"ab","cd"}, new string[]{"ef"} } )); //["",""]

//Boolean Array beahviour
GD.Print(JSON.Print(true)); //true
GD.Print(JSON.Print(new bool[]{true, false})); //Errors with the following stacktrace
//E 0:00:00.862   mono_object_to_variant_impl: Attempted to convert a managed array of unmarshallable element type to Variant.
//   <C++ Error>   Method failed. Returning: Variant()
//   <C++ Source>  modules/mono/mono_gd/gd_mono_marshal.cpp:1032 @ mono_object_to_variant_impl()
//   <Stack Trace> :0 @ System.String Godot.NativeCalls.godot_icall_3_1207(IntPtr , IntPtr , System.Object , System.String , Boolean )()
//                 JSON.cs:77 @ System.String Godot.JSON.Print(System.Object , System.String , Boolean )()
//                 TestScene.cs:19 @ void TestScene._Ready()()

Minimal reproduction project
N/A

Is this c# specific? I'm not familiar with c# or the Json functionality but we normally ask for MRP in gdscript, unless c# specific.

I don't know Mono but some casual looking makes me think it could be that it incorrectly treats nested arrays as plain arrays and therefore tries to convert them, it doesn't look like it supports nested arrays like this though even without that
I suspect though that you need to use Array instead of native array types, does that help?

So while it looks like there can be some bugs in the marshalling code, incorrectly treating multi-level arrays as single-level ones, multi-level arrays aren't supported by Variant like this, you can't get a multi-level typed array, so even if this is a bug it can't be represented in a way that translates cleanly to C#
To marshal it correctly it would be turned into arrays of all levels except the last one where you'd have an optional typed array, it does however seem that when using the type x[] syntax the arrays must be convertible to some static typed array if it is a simple type, like bool, again this might be a shortcoming of the implementation and a bug


[SPARK-39327][K8S] ExecutorRollPolicy.ID should consider ID as a numerical value

What changes were proposed in this pull request?
This PR aims to make ExecutorRollPolicy.ID should consider ID as a numerical value.
Why are the changes needed?
Currently, the ExecutorRollPolicy chooses the smallest ID from string sorting.
Does this PR introduce any user-facing change?
No, 3.3.0 is not released yet.
How was this patch tested?
Pass the CIs.

cc: @dongjoon-hyun


AttributeError: module 'http.client' has no attribute 'get'

Exception happened during processing of request from ('<IP_ADDRESS>', 52838)
Traceback (most recent call last):
  File "/usr/local/Cellar/python3/3.5.1/Frameworks/Python.framework/Versions/3.5/lib/python3.5/socketserver.py", line 318, in _handle_request_noblock
    self.process_request(request, client_address)
  File "/usr/local/Cellar/python3/3.5.1/Frameworks/Python.framework/Versions/3.5/lib/python3.5/socketserver.py", line 344, in process_request
    self.finish_request(request, client_address)
  File "/usr/local/Cellar/python3/3.5.1/Frameworks/Python.framework/Versions/3.5/lib/python3.5/socketserver.py", line 357, in finish_request
    self.RequestHandlerClass(request, client_address, self)
  File "/usr/local/Cellar/python3/3.5.1/Frameworks/Python.framework/Versions/3.5/lib/python3.5/socketserver.py", line 684, in __init__
    self.handle()
  File "/Users/lxh/IdeaProjects/services/lib/python3.5/site-packages/werkzeug/serving.py", line 217, in handle
    rv = BaseHTTPRequestHandler.handle(self)
  File "/usr/local/Cellar/python3/3.5.1/Frameworks/Python.framework/Versions/3.5/lib/python3.5/http/server.py", line 414, in handle
    self.handle_one_request()
  File "/Users/lxh/IdeaProjects/services/lib/python3.5/site-packages/werkzeug/serving.py", line 251, in handle_one_request
    elif self.parse_request():
  File "/usr/local/Cellar/python3/3.5.1/Frameworks/Python.framework/Versions/3.5/lib/python3.5/http/server.py", line 340, in parse_request
    conntype = self.headers.get('Connection', "")

Please include some code that reproduces this error.  See mcve.

Hey @leaxoy , did you find a fix for this?


A few minor fixes

LGTM
But jenkins is not working :)

Looks like you need to gofmt some files

@crosbymichael @LK4D4  thanks. I have uploaded a fixed version.

@mrunalp Done. Thanks.

The kernel seems to have a max limit of 2^22 - 1 = 4194303 for pid_max. There couldn't be more process groups than that so this should actually be safe as math.MinInt32 is -2147483648

The kernel seems to have a max limit of 2^22 - 1 = 4194303 for pid_max. There couldn't be more process groups than that so this should actually be safe as math.MinInt32 is -2147483648

Yes i think you are correct. TIL that :heart:
(https://github.com/torvalds/linux/blob/master/include/linux/threads.h#L33 )
LGTM

LGTM


⚠ Thumbnails API Endpoint has degraded performance

In aecc5c9, Thumbnails API Endpoint (https://thumbnails.roblox.com/v1/assets?assetIds=82738847&format=Png&isCircular=false&size=30x30) experienced degraded performance:

HTTP code: 200
Response time: 2148 ms

Resolved: Thumbnails API Endpoint performance has improved in 8797329.


Request documentation on best practises when debugging kedro cli commands in a pycharm environment

Introduction
I am trying to generate a project using kedro new --starter and see a cookiecutter error that I would like to investigate in more detail by stepping through the code line by line
Background
Being able to step inside the code is invaluable for better understand the error.
Problem
There's a lot of code to work through to get to the core functionality that actually creates the new project repo using the commands we pass on the cli. I'm unable to access those functions directly because then a number of initialization steps are not present. For example, context is missing, so on.

Hi @roumail do you want to join us on Discord and it will be easier to debug?
https://discord.gg/akJDeVaxnB

Hi Joel! Thanks for the quick turn around - i'm just about to enter a call so I won't be able to join right away.
The work around I use for moment is to A) use either post mortem debugging by executing the cli commands on the command line or B) set pdb.set_trace() inside the kedro codebase right before the line where I have the error. These solutions work, but then you're losing the power of pycharm debugging

Hi @roumail, I've reworked the implementation of kedro new --starter quite a bit recently so would be curious to hear what the problem is here. To debug it while developing, my approach is to set up a run configuration as per this guide. You can put PyCharm breakpoints in the source code of kedro in site-packages and it should still work. Alternatively, if you want to have it more easily accessible you can pip install kedro --target=. --no-deps to install it into your current working directory rather than site-packages.

Agree with everything @AntonyMilneQB says - the other hacky solution is to follow this sort of guide from the Jetbrains side that could allow you to invoke the PyCharm debugger from python code
https://www.jetbrains.com/help/pycharm/remote-debugging-with-product.html#remote-debug-config

This is great - exactly what I was looking for. I'm going to try these solutions out!


Updated README with an Approach to build GraphNet.

First of all this is really cool project . As  I take help by  google and understand the project , I get to know that how the library will work , what the flow should be to design the whole develop the library .  I am really excited to work with this project.

@charithccmc  and @kasundezoysa  Kindly have a look on it so that we can move further.


feat: use vite instead of plain esbuild

Hello @derhuerst 👋
total noob in the GTFS world I saw this, and it let me quickly see my rt gtfs ... yay :)
To better understand how all this work i start fiddling with this, but the build watch phase is kinda anoying
and it took me a couple of minute to figure out there was meaningful files in the dist folder...
Here is a proposition to use vite,
there is no attempt to push "the tool I use, just because", but i feel it's easier to grasp and to maintain
for example:

management of env files (migrated the TOKEN to use the env)
asset management
dev preview
etc....

oupsi , mybad, fixed

Thanks!

@eMerzh Do you happen to know why the GitHub Pages deployment is broken? index.html seems to be missing.

aarg ... sorry, looking 👀

there's something strange with the actions... maybe in combination with the gitignore or something 🤔
i wonder if we shouldn't use the standard actions for that instead 🤔 (https://github.com/actions/deploy-pages)
but trying to figure out what's going on


Validate system configuration

Building on #554.  Write a test case that takes as input the configuration generated by #554, retrieves the current config of the system, and verifies they are the same.
If they do not match up then this test case should clearly tell the user what has changed.

I will be happy to work on this.

https://gerrit.openbmc-project.xyz/5005

Code merged. Closing


[BUG] cannot return INTEGER from within an if branch in a subroutine

Please fill all required sections
Kind of proposals

[]Parser
[]Linter
[x]Simulator
[]Testing

Describe the problem
It seems to be kind of a specific bug, but I cannot have a "return" statement within an "if" branch of a subroutine that returns an INTEGER. This is hard to understand with words, so please have a look at the following simple code that better illustrates what I mean.
VCL code that cause the problem / reproduceable
$ cat main.vcl

sub compute INTEGER {
  // pb seems to be around here
  if (true) {
    return 2;
  }
  return 3;
}

sub vcl_recv {
  declare local var.myint INTEGER;
  set var.myint = compute();
}

And when I launch the simulator and refresh my browser at http://localhost:3124, I have this error:
$ falco simulate main.recv
...
Failed to assign value to var.myint, Invalid assignment for INTEGER type, got NULL

Here is a version working in Fastly Fiddle.
https://fiddle.fastly.dev/fiddle/d4bd0467
Also, if I remove the if in compute, it works:
sub compute INTEGER {
  return 2;
}

sub vcl_recv {
  declare local var.myint INTEGER;
  set var.myint = compute();
}

Expected behavior
The above should not raise an error.
Desktop (please complete the following information)

OS: ubuntu 22
Shell: bash

Hi @lobre , this issue could be reproduced and will be fixed in #242 .


keepassxc: 2.3.4 -> 2.4.0

Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[ ] NixOS
[x] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Assured whether relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

wait with merge - this build can't open my database

official 2.4.0 download from keepassxc website also cannot open my database
a new database (created with 2.3.4 without keyfile) can be opened in this build
so apparently not a packaging bug

@pSub Why did you merge even though @Quiark has reported problems with the new version?


Reporting scammers:app.ston.fi

mistakenly connect my tonkeeper wallet to app.ston.fi: through this wallet account:  EQBhy3ZUzX47_mUklrng3SKzs8g0OppaN2gjB2j2c3yjxlK6 they take all my Ton(about 6.77 ton),they indicate that they will only withdrawn 0.13ton no the day 31 Aug. 2024 , 10:29 Nigerian time. Below is my address please to refund me through
UQBMSzgLZZIibD8sU9MSfeKBR_PzLXr2FKnkKB7JQ8KzTgst.
Thank you

mistakenly connect my tonkeeper wallet to app.ston.fi: through this wallet account: EQBhy3ZUzX47_mUklrng3SKzs8g0OppaN2gjB2j2c3yjxlK6 they take all my Ton(about 6.77 ton),they indicate that they will only withdrawn 0.13ton no the day 31 Aug. 2024 , 10:29 Nigerian time. Below is my address please to refund me through UQBMSzgLZZIibD8sU9MSfeKBR_PzLXr2FKnkKB7JQ8KzTgst. Thank you

@Habibut7  It sounds like your query would be best dealt with by the support team.
I'll have to refer you to the official support live chat with the ticket ID TON07638
Please see the link below to our dedicated support line:
Tonkeeper live support Click on the live chat icon at the bottom corner of the page to initiate chat with a live support agent

Contact the Support page to resolve your request.
Note: You can also initiate a chat with the live agent on the chat button to get more information about your request via Live Chat
@Habibut7
Support.
{c}2024


Messages from Discord to Slack duplicated on Discord side

Describe the bug
Message is duplicated in Discord because of bot message in Slack
To Reproduce

Set up simple test discord <-> slack bridge
Send message in Discord
Message is bridged to Slack, which is bridged back to Discord
The message you sent in Discord is duplicated in Discord

Expected behavior
Message should not be duplicated.
Screenshots/debug logs
If applicable, add screenshots to help explain your problem.
Use logs from running matterbridge -debug if possible.
Discord

Slack
Appears as expected on Slack (with my photo and name).
Logs
click here
➜ ./matterbridge -debug
[0000]  INFO main:         Enabling debug logging.
[0000]  INFO main:         Running version 1.16.6-dev
[0000]  INFO main:         WARNING: THIS IS A DEVELOPMENT VERSION. Things may break.
[0000] DEBUG discord:      Configuring Discord Incoming Webhook
[0000]  INFO router:       Parsing gateway mta.test
[0000]  INFO router:       Starting bridge: slack.mta
[0000]  INFO slack:        Connecting using token
[0000]  INFO slack:        slack.mta: joining test (ID: testslack.mta)
[0000] DEBUG slack:        Choosing token based receiving
[0000] DEBUG slack:        == Receiving event &slack.ConnectingEvent{Attempt:1, ConnectionCount:0}
[0000] DEBUG slack:        Unhandled incoming event: *slack.ConnectingEvent
[0000]  INFO router:       Starting bridge: discord.mta
[0000]  INFO discord:      Connecting
[0000]  INFO discord:      Connecting using webhookurl (for posting) and token
[0000]  INFO discord:      Connection succeeded
[0000] DEBUG slack:        == Receiving event &slack.ConnectedEvent{ConnectionCount:0, Info:(*slack.Info)(0xc00040a000)}
[0001] DEBUG slack:        Start listening for Slack messages
[0001] DEBUG discord:      Verifying PermissionManageWebhooks for testdiscord.mta with ID<PHONE_NUMBER>40469505
[0001]  INFO discord:      Can manage webhooks; will edit channel for global webhook on send
[0001] DEBUG slack:        getting 33 users
[0002]  INFO discord:      discord.mta: joining test (ID: testdiscord.mta)
[0002]  INFO main:         Gateway(s) started succesfully. Now relaying messages
[0002] DEBUG discord:      == Receiving event &discordgo.Message{ID:"689415941343150083", ChannelID:"590172620440469505", GuildID:"278474088903606273", Content:"PLEASE FVV", Timestamp:"2020-03-17T10:12:49.145000+00:00", EditedTimestamp:"", MentionRoles:[]string{}, Tts:false, MentionEveryone:false, Author:(*discordgo.User)(0xc000574a80), Attachments:[]*discordgo.MessageAttachment{}, Embeds:[]*discordgo.MessageEmbed{}, Mentions:[]*discordgo.User{}, Reactions:[]*discordgo.MessageReactions(nil), Pinned:false, Type:0, WebhookID:"", Member:(*discordgo.Member)(0xc000576460), MentionChannels:[]*discordgo.Channel(nil), Activity:(*discordgo.MessageActivity)(nil), Application:(*discordgo.MessageApplication)(nil), MessageReference:(*discordgo.MessageReference)(nil), Flags:0}
[0002] DEBUG discord:      <= Sending message from qaisjp on discord.mta to gateway
[0002] DEBUG discord:      <= Message is config.Message{Text:"PLEASE FVV", Channel:"test", Username:"qaisjp", UserID:"83386293446246400", Avatar:"https://cdn.discordapp.com/avatars/83386293446246400/a525dac41568459ca38bafd903af8548.jpg", Account:"discord.mta", Event:"", Protocol:"", Gateway:"", ParentID:"", Timestamp:time.Time{wall:0x0, ext:0, loc:(*time.Location)(nil)}, ID:"689415941343150083", Extra:map[string][]interface {}(nil)}
[0002] DEBUG gateway:      => Sending config.Message{Text:"PLEASE FVV", Channel:"test", Username:"qaisjp", UserID:"83386293446246400", Avatar:"https://cdn.discordapp.com/avatars/83386293446246400/a525dac41568459ca38bafd903af8548.jpg", Account:"discord.mta", Event:"", Protocol:"discord", Gateway:"mta.test", ParentID:"", Timestamp:time.Time{wall:0xbf9446885119f1e8, ext:2615190372, loc:(*time.Location)(0x3c76020)}, ID:"689415941343150083", Extra:map[string][]interface {}(nil)} from discord.mta (test) to slack.mta (test)
[0002] DEBUG slack:        => Receiving config.Message{Text:"PLEASE FVV", Channel:"test", Username:"qaisjp", UserID:"83386293446246400", Avatar:"https://cdn.discordapp.com/avatars/83386293446246400/a525dac41568459ca38bafd903af8548.jpg", Account:"discord.mta", Event:"", Protocol:"discord", Gateway:"mta.test", ParentID:"", Timestamp:time.Time{wall:0xbf9446885119f1e8, ext:2615190372, loc:(*time.Location)(0x3c76020)}, ID:"", Extra:map[string][]interface {}(nil)}
[0002] DEBUG slack:        == Receiving event &slack.MessageEvent{Msg:slack.Msg{ClientMsgID:"", Type:"message", Channel:"C4Z7JEUC8", User:"", Text:"PLEASE FVV", Timestamp:"1584439969.005400", ThreadTimestamp:"", IsStarred:false, PinnedTo:[]string(nil), Attachments:[]slack.Attachment(nil), Edited:(*slack.Edited)(nil), LastRead:"", Subscribed:false, UnreadCount:0, SubType:"bot_message", Hidden:false, DeletedTimestamp:"", EventTimestamp:"1584439969.005400", BotID:"BF5S2HSTG", Username:"qaisjp", Icons:(*slack.Icon)(0xc0003e7880), Inviter:"", Topic:"", Purpose:"", Name:"", OldName:"", Members:[]string(nil), ReplyCount:0, Replies:[]slack.Reply(nil), ParentUserId:"", Files:[]slack.File(nil), Upload:false, Comment:(*slack.Comment)(nil), ItemType:"", ReplyTo:0, Team:"T216B1U03", Reactions:[]slack.ItemReaction(nil), ResponseType:"", ReplaceOriginal:false, DeleteOriginal:false, Blocks:slack.Blocks{BlockSet:[]slack.Block(nil)}}, SubMessage:(*slack.Msg)(nil), PreviousMessage:(*slack.Msg)(nil)}
[0002] DEBUG gateway:      mID slack.mta:<PHONE_NUMBER>.005400
[0002] DEBUG slack:        Found bot &slack.Bot{ID:"BF5S2HSTG", Name:"Chat Bridge", Deleted:false, UserID:"UF3N0SGJU", AppID:"AF3RWLXBK", Updated:1546356234, Icons:slack.Icons{Image36:"https://a.slack-edge.com/80588/img/plugins/app/bot_36.png", Image48:"https://a.slack-edge.com/80588/img/plugins/app/bot_48.png", Image72:"https://a.slack-edge.com/80588/img/plugins/app/service_72.png"}}
[0002] DEBUG slack:        <= Sending message from qaisjp on slack.mta to gateway
[0002] DEBUG slack:        GetUserInfo failed for BF5S2HSTG: user_not_found
[0002] DEBUG slack:        <= Message is &config.Message{Text:"PLEASE FVV", Channel:"test", Username:"qaisjp", UserID:"BF5S2HSTG", Avatar:"", Account:"slack.mta", Event:"", Protocol:"slack", Gateway:"", ParentID:"", Timestamp:time.Time{wall:0x0, ext:0, loc:(*time.Location)(nil)}, ID:"1584439969.005400", Extra:map[string][]interface {}{}}
[0002] DEBUG gateway:      => Sending config.Message{Text:"PLEASE FVV", Channel:"test", Username:"qaisjp", UserID:"BF5S2HSTG", Avatar:"", Account:"slack.mta", Event:"", Protocol:"slack", Gateway:"mta.test", ParentID:"", Timestamp:time.Time{wall:0xbf94468866708f98, ext:2973192208, loc:(*time.Location)(0x3c76020)}, ID:"1584439969.005400", Extra:map[string][]interface {}{}} from slack.mta (test) to discord.mta (test)
[0002] DEBUG discord:      => Receiving config.Message{Text:"PLEASE FVV", Channel:"test", Username:"qaisjp", UserID:"BF5S2HSTG", Avatar:"", Account:"slack.mta", Event:"", Protocol:"slack", Gateway:"mta.test", ParentID:"", Timestamp:time.Time{wall:0xbf94468866708f98, ext:2973192208, loc:(*time.Location)(0x3c76020)}, ID:"", Extra:map[string][]interface {}{}}
[0002] DEBUG discord:      Broadcasting using Webhook
[0002] DEBUG discord:      Setting webhook channel to "test"
[0003] DEBUG discord:      Processing webhook sending for message config.Message{Text:"PLEASE FVV", Channel:"test", Username:"qaisjp", UserID:"BF5S2HSTG", Avatar:"", Account:"slack.mta", Event:"", Protocol:"slack", Gateway:"mta.test", ParentID:"", Timestamp:time.Time{wall:0xbf94468866708f98, ext:2973192208, loc:(*time.Location)(0x3c76020)}, ID:"", Extra:map[string][]interface {}{}}
[0003] DEBUG gateway:      mID discord.mta:<PHONE_NUMBER>01461043

Environment (please complete the following information):

OS: [e.g. linux]
Matterbridge version: output of  matterbridge -version
If self compiled: output of git rev-parse HEAD

Problem happens on my test instance
6b4b19194ec40c79569bc692a6557e78f338ded9 + #1036 (needed to make it compile), macOS
Does not happen on my production instance
c0be3e585a5ef6c6dc4d517e891fd10bc053c195 + few tiny patches, Linux
Additional context
Please add your configuration file  (be sure to exclude or anonymize private data (tokens/passwords))
Related to #219
[discord]

[discord.mta]
Token="bot-token"
Server="278474088903606273"
RemoteNickFormat="{NICK}"
WebhookURL="https://discordapp.com/api/webhooks/684875846770753568/token"

[slack]
[slack.mta]
Token="xoxb-xxxxx-yyyy-zzzz"
RemoteNickFormat="{NICK}"

[[gateway]]
name="mta.test"
enable=true

[[gateway.inout]]
account="slack.mta"
channel="test"

[[gateway.inout]]
account="discord.mta"
channel="test"

Could be related to #1018. Doing some debugging...
With this patch on this file
diff --git a/bridge/slack/handlers.go b/bridge/slack/handlers.go
index 10ed0ae5..04d30fed 100644
--- a/bridge/slack/handlers.go
+++ b/bridge/slack/handlers.go
@@ -125,6 +125,10 @@ func (b *Bslack) skipMessageEvent(ev *slack.MessageEvent) bool {
        }

        // Skip any messages that we made ourselves or from 'slackbot' (see #527).
+       fmt.Printf("Comparing ev.Username[%#v] == sSlackBotUser[%#v]\n", ev.Username, sSlackBotUser)
+       fmt.Printf("Comparing (b.rtm!=nil)[%#v] && ev.Username[%#v] == b.si.User.Name[%#v]\n", b.rtm != nil, ev.Username, b.si.User.Name)
+       fmt.Printf("Comparing attachment stuff. Result %#v\n", (len(ev.Attachments) > 0 && ev.Attachments[0].CallbackID == "matterbridge_"+b.uuid))
+       fmt.Printf("Slack event: %#v\n", ev)
        if ev.Username == sSlackBotUser ||
                (b.rtm != nil && ev.Username == b.si.User.Name) ||
                (len(ev.Attachments) > 0 && ev.Attachments[0].CallbackID == "matterbridge_"+b.uuid) {

This output is given:
➜ ./matterbridge
[2020-03-17T10:52:27Z]  INFO main:         Running version 1.16.6-dev
[2020-03-17T10:52:27Z]  INFO main:         WARNING: THIS IS A DEVELOPMENT VERSION. Things may break.
[2020-03-17T10:52:27Z]  INFO router:       Parsing gateway mta.test
[2020-03-17T10:52:27Z]  INFO router:       Starting bridge: discord.mta
[2020-03-17T10:52:27Z]  INFO discord:      Connecting
[2020-03-17T10:52:27Z]  INFO discord:      Connecting using webhookurl (for posting) and token
[2020-03-17T10:52:27Z]  INFO discord:      Connection succeeded
[2020-03-17T10:52:28Z]  INFO discord:      Can manage webhooks; will edit channel for global webhook on send
[2020-03-17T10:52:29Z]  INFO discord:      discord.mta: joining test (ID: testdiscord.mta)
[2020-03-17T10:52:29Z]  INFO router:       Starting bridge: slack.mta
[2020-03-17T10:52:29Z]  INFO slack:        Connecting using token
[2020-03-17T10:52:29Z]  INFO slack:        slack.mta: joining test (ID: testslack.mta)
[2020-03-17T10:52:29Z]  INFO main:         Gateway(s) started succesfully. Now relaying messages
Comparing ev.Username["qaisjp"] == sSlackBotUser["slackbot"]
Comparing (b.rtm!=nil)[true] && ev.Username["qaisjp"] == b.si.User.Name["chat-bridge"]
Comparing attachment stuff. Result false
Slack event: &slack.MessageEvent{Msg:slack.Msg{ClientMsgID:"", Type:"message", Channel:"C4Z7JEUC8", User:"", Text:"yes", Timestamp:"1584442356.006000", ThreadTimestamp:"", IsStarred:false, PinnedTo:[]string(nil), Attachments:[]slack.Attachment(nil), Edited:(*slack.Edited)(nil), LastRead:"", Subscribed:false, UnreadCount:0, SubType:"bot_message", Hidden:false, DeletedTimestamp:"", EventTimestamp:"1584442356.006000", BotID:"BF5S2HSTG", Username:"qaisjp", Icons:(*slack.Icon)(0xc000475420), Inviter:"", Topic:"", Purpose:"", Name:"", OldName:"", Members:[]string(nil), ReplyCount:0, Replies:[]slack.Reply(nil), ParentUserId:"", Files:[]slack.File(nil), Upload:false, Comment:(*slack.Comment)(nil), ItemType:"", ReplyTo:0, Team:"T216B1U03", Reactions:[]slack.ItemReaction(nil), ResponseType:"", ReplaceOriginal:false, DeleteOriginal:false, Blocks:slack.Blocks{BlockSet:[]slack.Block(nil)}}, SubMessage:(*slack.Msg)(nil), PreviousMessage:(*slack.Msg)(nil)}

More context.
Running the following code (using the bot token)
func main() {
	api := slack.New("xoxb-xxxx-yyyy-zzzz")
	api.SendMessage("C4Z7JEUC8", slack.MsgOptionText("kek", true))
}

Sends this message:

Logs this:
Comparing (b.rtm!=nil)[true] && ev.Username["Chat Bridge"] == b.si.User.Name["chat-bridge"]

slack b.si.User.ID "UF3N0SGJU" and ev.BotID "BF5S2HSTG" and ev.User ""

Slack event: &slack.MessageEvent{Msg:slack.Msg{ClientMsgID:"", Type:"message", Channel:"C4Z7JEUC8", User:"", Text:"kek", Timestamp:"1584446901.006900", ThreadTimestamp:"", IsStarred:false, PinnedTo:[]string(nil), Attachments:[]slack.Attachment(nil), Edited:(*slack.Edited)(nil), LastRead:"", Subscribed:false, UnreadCount:0, SubType:"bot_message", Hidden:false, DeletedTimestamp:"", EventTimestamp:"1584446901.006900", BotID:"BF5S2HSTG", Username:"Chat Bridge", Icons:(*slack.Icon)(nil), Inviter:"", Topic:"", Purpose:"", Name:"", OldName:"", Members:[]string(nil), ReplyCount:0, Replies:[]slack.Reply(nil), ParentUserId:"", Files:[]slack.File(nil), Upload:false, Comment:(*slack.Comment)(nil), ItemType:"", ReplyTo:0, Team:"T216B1U03", Reactions:[]slack.ItemReaction(nil), ResponseType:"", ReplaceOriginal:false, DeleteOriginal:false, Blocks:slack.Blocks{BlockSet:[]slack.Block(nil)}}, SubMessage:(*slack.Msg)(nil), PreviousMessage:(*slack.Msg)(nil)}

More interestingly, my app appears in the apps list, which I can PM:

The old version of the same app, also appears in the contact list:

Which is apparently a deactivated account:

And the app is apparently disabled:

Clicking "How does chat-bridge work?" shows this

Clicking "Settings" or "View in App Directory" will both link to https://multitheftauto.slack.com/apps/AF4ACB3V2-chat-bridge, which says "There's been a glitch":

On Slack, "Your Apps", my Chat Bridge app (at https://api.slack.com/apps/AF3RWLXBK/app-home) shows this:

Observe "legacy Bot User", which is possibly why I am running into issues.
Note that inviting the bridge shows "Bridge" and not "chat-bridge". Originally (when I first set the bridge up) it would say @chat-bridge:

On another Slack workspace (with a different app so a different token, but the same configuration), @chat-bridge works fine - https://api.slack.com/apps/A9C11GZ7H/app-home?:

On the OAuth & Permissions tab, both of them say this:

Do you think I should just delete the app and start over? Or should I keep this around so that we can be legacy bots work with matterbridge? Should we support legacy bots?

Aha! Above, in the "installed bots" (not the developer interface) screen, under the "Bot User" heading, the usernames are different.

I'll try and see if we can make this use the ID only, and not compare usernames.
It still won't explain why it works fine on Linux (with an older version of matterbridge, which has a different copy of the library). But /shrug, it should solve the issue.

I can confirm this happens on 6b4b19194ec40c79569bc692a6557e78f338ded9 on my production instance (just upgraded).
After cherry-picking #1042 the messages are no longer duplicated.

I also experienced the same issue with a simple Slack<->Discord bridge setup.
Can confirm the issue but I have not tested the fix.

the core issue ALL ALONG is that something is wrong with attachments, lol

The fix in #1042 went in a completely incorrect direction.
#1046 does it properly.


Android - rotateWhenOrientationChanged Not working

Android does not take the picture in the right position.
It's upside down and none of the options are making the returned base64 picture in the right position.
To test this:

use an android devise
take a capture.
If the picture is the right position, return your device and take another picture
One of the 2 base64 images are not in the right position.
Repeat with any option.

Please resolve that issue. It's been like this for months now.

Hello @hommalex
Have you found any workaround for this please?