grouping/aggregation filter applying to entire aggregation string

This issue seen in the latest unstable build.
The aggregated values in a grouping header row have any cell filters applied after the aggregation string is built (e.g. filter runs against "avg: data" instead of against data), which causes many filters to fail.
See this issue in http://plnkr.co/edit/VBIbnVYcY4ra825647Vy

That's what the option groupingSuppressAggregationText is for, it's documented on http://ui-grid.info/docs/#/tutorial/209_grouping

So it is... I scanned right over that part of the documentation.
I looked to see if it was an enhancement/fix I could contribute without much risk to the rest of ui-grid, but looking through the code it looks like it would require a number of changes all over in core pieces since grouping rows use the same row and cell templates as data rows.
As a temporary workaround for my own purposes I added the following to my cell template:
{{row.groupHeader && col.grouping.aggregation ? (col.grouping.aggregation + ': ') : ''}}
Not ideal, from a performance perspective, since the same cell template is used for every data row. But it's functional to get the aggregation text + filtered data.

Based on your addition to the Future milestone, I guess you're in favor of leaving this open as a possible future enhancement/bugfix? Since it's documented that seems very reasonable. Thanks for the quick response.

Yeah, although I have no idea how to actually change it, since the filters get applied via an angular binding.  I could maybe write a filter that applies the totals/aggregations, and add that filter to the end of the filters, but it's getting a little too tricky I think.
In my code, I just unstring it in the filter.  Most commonly I'm doing this on a reference data lookup (changing 1 => active, 2=> inactive or similar).  I have a generic routine that makes filters for my ref data:
.factory('SystemRefDataService', function( ){
  var systemRefDataService = {
    genericMap: function( constant, constantName ) {
      return function (input) {
        var result;
        var match;

        if(!input) {
          return '';
        } else if (result = constant[input]) {
          return result;
        } else if ( ( match = input.match(/(\d+)( \(\d+\))/) ) && ( result = constant[match[1]] ) ) {
          return result + match[2];
        } else {
          if(!$rootScope[constantName + 'Error']) {
            LoggingService.logError('42001: ' + constantName + ' not recognised', 'SYSTEM_REF_DATA', {input: input});
            $rootScope[constantName + 'Error'] = true;
          }
          return 'MSG_base_42001_system_ref_data_not_recognised';
        }
      };
    }
  };

  return systemRefDataService;
})

I hold most of my refData in constants in the format:
.factory( 'ProjectStatusesConstant', function() {
  return {
      1: 'VALUE_project_project_status_active',
      2: 'VALUE_project_project_status_inactive'
  };
})

So I can define a filter by:
.filter('mapProjectStatus', function( ProjectStatusesConstant, SystemRefDataService ) {
  return SystemRefDataService.genericMap( ProjectStatusesConstant, 'project_statuses');
})

I think this may be addressed in the newest version of grouping (which has significant breaking changes).
You can now define a customTreeAggregationFinalizerFn that doesn't concatenate the data, and then concatenate the data in a cellTemplate instead (the label and the value are both now separately available for you to do things with if you wish).


[runtime] Add Skia support for web

Why
On Android and iOS, Skia seems to work nicely already. But for web, we need to initialize canvaskit-wasm. This adds that support.
How

Added Snack-specific initialization in the Runtime, based on the original web init

Test Plan
Will share a snack for staging.

cc @wcandillon

is this ready to move to ready for review?

@brentvatne It's reviewable, but I'd need to update the other SDK 46 beta upgrade to non-beta when it's out 😄 So I'd prefer to keep this separate until the SDK 46 upgrade is complete.


NaN handling

We should decide how to handle NaNs in submission (or how many to allow) and implement it

The current implementation now removes any rows that have a nan in either the measured or predicted rates prior to downsampling. In addition, when running the command line tool to score an entire dataset, we take the nanmedian of scores across neurons. In my testing I occasionally found NaNs in the output of the optimization function for the loglik computation for just one neuron, though I wasn't entirely sure why, probably worth tracking down.


accessor allows this parameter but is not checked or enforced.

TypeScript Version:  3.7.5 and 3.8 (91ffa1c752ac26882b1426fb4c9012701c1d908e)

Search Terms:
getter, get, set, setter,  accessor property, this parameter
Code
In the following, x.a and x.b() are invalid for the same reason but x.a doesn't give a type error.
interface Unimplemented {
    calculate(): number;
}

class Demo {
   get a(this: Unimplemented) {
        return this.calculate();
    }
    b(this: Unimplemented) {
        return this.calculate();
    }
}
const x = new Demo();
console.log(x.a); // no type error, fails at runtime

console.log(x.b()) // correctly gives following error:
/* The 'this' context of type 'Demo' is not assignable to method's 'this' of type 'Unimplemented'.
     Property 'calculate' is missing in type 'Demo' but required in type 'Unimplemented'.ts(2684) */

Expected behavior is one of:

error to declare a this parameter on an accessor field (get or set)
OR accessing x.a gives same type error as calling x.b()

Actual behavior:
this parameter is syntactically allowed on accessor but has no impact outside the function so it is never checked.  Accessing x.a throws an error at runtime.
Playground Link:
Playground Link
Related Issues:
none found, It's quite possible I'm the first one to actually try something like this.

For reference, what I was doing when I ran into this is that I wanted to write an abstract class with a static method that would work as a valid react component, something like this:
abstract class HookCls<P>{
    abstract useRender(props: P): React.ReactElement | null;
    public static JSX<P>(this: new()=>HookCls<P>, props: P){
        const instRef = React.useRef<HookCls<P>>();
        const inst = instRef.current ?? (instRef.current = new this());
        return inst.useRender(props);
    }
}

The constraint means that HookCls.JSX({}) is invalid because HookCls doesn't extend the concrete constructor, but a subclass like Example.JSX({}) would work, however when it's used in JSX like <Example.JSX a="test"/> means it doesn't keep the this value because it passes an unbound method to react, so I needed to replace it with a getter:
abstract class HookCls<P> {
    abstract useRender(props: P): React.ReactElement | null;
    public static get JSX<P>(this: new () => HookCls<P>) {
        return (props: P) => {
            const instRef = React.useRef<HookCls<P>>();
            const inst = instRef.current ?? (instRef.current = new this());
            return inst.useRender(props);
        };
    }
}

Right away typescript told me that generics on a getter is not valid, but it took me a while to find that it also doesn't support a this parameter correctly.
It would be amazing if typescript was capable of representing that HookCls.JSX has a different type on subclasses, (and it can be transformed based on a generic on the getter) but I recognize how much changes it would take to get something like this to be supported for such a very niche use case.  So I expect typescript should just not allow declaring a this on accessors just like generics because it has no way to enforce it.

We should give an error on the this parameter like
'get' and 'set' accessors cannot declare 'this' parameters.

or
Accessors cannot declare 'this' parameters.

I prefer the first one.

I'm considering this as a first issue, do I need to know anything that's not already said?

Thanks @a-tarasyuk!


The Eco-Score is not clickable

The Eco-Score is not clickable like NOVA or Nutri-Score. We should link to the methodology like we usually do.
https://world.openfoodfacts.org/eco-score-the-environmental-impact-of-food-products
https://fr.openfoodfacts.org/eco-score-l-impact-environnemental-des-produits-alimentaires

Done. Will add a PR soon.

Done. Will add a PR soon.


Create a Web_Optimization.MD at the root level of the repo

Only take this issue once you have an understanding of how were optimizing SEO, overall speed, etc

Give the heading
Add an illustration/image(preferably from Unsplash but do give a CC)/giphy. Make sure it is suitable
In bullet points, describe the optimizations performed. Add Code blocks wherever required
Emaphasis on file image size and formats is also appreciated
Cite your reference for each point if possible. Use [1], [2], [3] in the bullet points and at the bottom list out the references under a heading references

SAMPLE
# How did we optimize our project so far?

![Some Appropriate Image/Illustration/GIF](https://link-to-a-media-item)

- Suggestion 1
- Suggestion 2
- Suggestion 3 [1] . Suggestion 3 continued [2]
``
Some code to corroborate or illustrate the point
``
- Suggestion 4
- Suggestion 5[3].
.
.
.
- Suggestion n

## References:

[1] [The name of the article/blog/report/video](https://link-to-the-reference)
[2] [The name of the article/blog/report/video](https://link-to-the-reference)
.
.
.
[3] [The name of the article/blog/report/video](https://link-to-the-reference)

i want to work on this


ERR_SSL_VERSION_INTERFERENCE with Chrome on android

On Chrome Android, some requests will fail randomly. I could detect, it's the "ERR_SSL_VERSION_INTERFERENCE" error. When disable tls1.3 support in chrome://flags, all works fine.
Any idea what i can do?

As i see, the flag Tls11 and Tls12 is "unsupported" in Mono:
https://github.com/mono/mono/blob/master/mcs/class/System/System.Security.Authentication/SslProtocols.cs
so, i'm wondering what chrome is using than. Maybe only the flag is unsupported, but it's still using >tls1.0 (1.0 is obselete).

Nowin does not have any own TLS implementation it just uses SSLStream from underlying framework. You could probably has better chance to report it to Mono/NetCore, because I don't really know TLS protocol in needed detail to help fix Mono or reimplement it myself.
I still using Nowin in personal projects (old ones), but on Windows and with Caddy Server doing TLS termination and ACME cert updates, especially because I don't have capacity to solve security problems or evolution of such code.

It seems, Mono uses a external unmanaged library for SSL: http://www.mono-project.com/docs/about-mono/releases/4.8.0/
The flag MONO_TLS_PROVIDER=legacy didn't helped. Because planned to use a load balancer ( https://cloud.google.com/compute/docs/load-balancing/http/ ) i added it now and the proxy simply redirect https to http. Works perfectly.


Pydantic model compatibility

[All tests and lint checks are passing.]
What this PR does / why we need it:
This PR introduces Pydantic model conversions for Entity, DataSource, and FeatureView, so that they may be transmitted over the wire using FastAPI. This allows a Feast project to be broken up into a local SDK and a remote registry service.
Only RequestSource and SparkSource are supported for now. We plan to add support for FeatureService models in the near future.

Moving pydantic models to expediagroup.models package
conversion from pydantic model to feast and vice versa can be moved to pydantic models class so we will not be touching feast code.

Fixed!

Please use Squash and Merge


Add other method for removing outliers.

refs https://en.wikipedia.org/wiki/Outlier

But there's so many T-T

pandas may be going to implement the function for dropping outliers.
But pandas has no dependency on scipy . So it's a little difficult to implement the method required t-value(scipy.stats.t) like Smirnov grubbs tests or Thompsonぴ Tau test.
So I think this library should implements these methods.
refs: https://github.com/pandas-dev/pandas/issues/15111


the error of the keypoints from traker is  large

This error depends on the parameter that we set for the Lucas-Kanade algorithm and also on the external lightning conditions. Kindly suggest so I can improve the result.


Allow configuring any supported Omnisharp log level

Fixes #993
This PR allows the user to set any log level that Omnisharp supports in the user settings.
The default is information.
Note 1: that this is technically a breaking change, since I removed the old verbose log level as it doesn't exist in Omnisharp and replaced the allowed values with the ones Omnisharp can understand (if it's critical, we can bring back that verbose level and map to debug but I think this is a fringe feature and there is no need for such "phase out").
Note 2: this only works with latest Omnisharp builds, but that has already been included into the latest C# extension.

OK, https://github.com/OmniSharp/omnisharp-roslyn/pull/743 is merged, correcting '-loglevel' to '--loglevel'. I'll merge this once I take a new omnisharp-roslyn.

thank you!

OK. I'm going to update to the latest omnisharp-roslyn release this morning and will merge this then.


Make Git Module Show Pulls Quantity

As git module already shows the quantity of pushes need to diff the upstream branch, it would be great if it show the quantity of pulls also if branch is behind it. I think it can be an idea to parse git status instead of just using git cherry, something like what pure does.
As this is not necessary right now, this can be something to be worked on when this module has become async.

Implemented in commit 4efc5081f4f4b48b5681902b986f65e93f4c8c14.


Decoding with limited image dimensions as output

Is your feature request related to a problem? Please describe.
For responsive websites it may be necessary to decode a JXL to a different image format for older clients, with a certain maximum bit depth and an upper boundary on the image resolution.
Describe the solution you'd like
It would be nice if there's not only a downsampling factor but a target image size for decoding, to allow the file to be only fetched so far as necessary from the storage, to output the image with the required bit depth and resolution requested.
Something like
djxl --downsamping_width=240 --downsampling_height=240 --color_space=RGB_D65_SRG_Rel_Lin --jpeg_quality=65 --bits_per_sample=8 INPUT.jxl OUTPUT.jpg

would decode a maximum width of 1920 px and a maximum height of 1080 px with the selected color space and a maximum bit depth of 8 bit/channel.
Additionally, an optional flag would be nice to reduce the quality a bit by selecting one quality lower, as the command above would round the downsampling step to one above, this flag would round down:
djxl --downsamping_lq --downsamping_width=1920 --downsampling_height=1080 --color_space=RGB_D65_SRG_Rel_Lin --jpeg_quality=90 --bits_per_sample=8 INPUT.jxl OUTPUT.jpg

Describe alternatives you've considered
Only possible with a lot of boiler plating, reading image sizes and figure out the nearest downsamping factor and then do the pixel conversion afterwards.

As JXL is being considered as a successor to PNG for in the freedesktop.org thumbnail specification (through which most Linux file managers handle their thumbnails), this would be essential to realizing the benefits discussed in https://gitlab.freedesktop.org/xdg/xdg-specs/-/issues/79.


Can we match different cloak_patterns to different types of files?

Basically title... It'd be awesome to match different patterns in different files.
I have 2 main types of secret files. 1 is yaml that has things like con: my-secret-connection-info and the other is like your example, .env files with MYSECRET=.... I'd like to match both but am struggling to get it right - can you toss an example in the README or is this not possible at the moment?
PS - already love the plugin.. dox'd myself so many times on Teams calls...

Hey, this should be possible already.
Something like the following config should work for what you describe:
require('cloak').setup({
  patterns = {
    {
      -- Match any file ending in '.yml'. you can make this more specific, like 'secrets.yml', or even pass a list.
      file_pattern = '*.yml',
      -- Match a ':' and any character after it will be cloaked.
      cloak_pattern = ':.+'
    },
  },
})

If you also want to cloak lists in yml, you can do something like this:
require('cloak').setup({
  patterns = {
    {
      -- Match any file ending in '.yml'. you can make this more specific, like 'secrets.yml', or even pass a list.
      file_pattern = '*.yml',
      -- Match a ':' and any character after it will be cloaked.
      cloak_pattern = ':.+'
    },
    {
      -- Match any file ending in '.yml'. you can make this more specific, like 'secrets.yml', or even pass a list.
      file_pattern = '*.yml',
      -- Match a '-' and any character after it will be cloaked.
      cloak_pattern = '-.+'
    },
  },
})

Does this help?

I have added support for multiple cloaks per pattern, so the 2nd snippet can now be simplified using:
require('cloak').setup({
  patterns = {
    {
      file_pattern = '*.yml',
      cloak_pattern = {  ':.+', '-.+' },
    },
  },
})

I am also closing this because I assume everything is resolved.

Thanks! Sorry for the delay, lost this notification in my email. I will play around and come back if I have questions! Great plugin!


Add GitHub Actions pipeline that triggers a nightly feedstock build

This pipeline runs nightly. It updates the recipe to build the latest commit from "main" in the TileDB-SOMA repo, and force pushes to the branch "nightly-build", which triggers the feedstock builds on Azure. Because upload_on_branch: main is set in conda-forge.yml, any binaries produced by this nightly test build are never uploaded to anaconda.org
Other details:

"-nightly" is appended to the version string. This makes it easier to read the logs, and also ensures that the Python client always builds against the locally built libtiledbsoma
The pipeline runs every night, but can also be manually triggered in the Actions UI or by editing the workflow file

You can see how this works on my fork:

nightly-build branch
nightly actions
example commit - this gets overwritten each run of the pipeline
example Azure build logs

Note that the builds are currently failing because the conda recipe uses the flag --libtiledbsoma to build the Python client, and that flag was removed from "main" in PR https://github.com/single-cell-data/TileDB-SOMA/pull/1189
Potential improvements if requested:

Move the code in the pipeline steps to standalone scripts for easier local troubleshooting
Automatically open an Issue if the nightly build fails. This is tricky since it requires cross-communication between the Azure builds and a GitHub pipeline (I don't want to directly edit the conda-forge generated Azure files since these will be overwritten by future conda smithy rerenderings). Also this is bound to be noisy since any breaking change will fail until a new release is made
Fancier version string, eg append the current date

@jdblischak this is baller!! :)
Re your "Potential improvements if requested" my personal $0.02 is we're OK without all three of these:

This might be nice ... but as long as we can run-on-demand in GHA, I think that's enough
A release is a manual, human-decision process with a workflow/checklist & one of those checklist items will be checking this new CI signal. So this is fine. If we ever wanted to move to automated releases (once a month, say) then we should revisit. But I don't see that anywhere on the horizon.
Nice :)

@jdblischak requesting merge-by-requestor rather than merge-by-author; merging


Properly format (are ...) functions  (from mynomoto in Clojureverse)

About clojure.test/are formatting, it should ideally depend on the first argument. That’s a template for the rest of the form. A couple of examples:
(are [x y] (= x y)
  2 (+ 1 1)
  4 (* 2 2))

(are [x y z] (= x y z)
  2 (+ 1 1) (- 4 2)
  4 (* 2 2) (/ 8 2))

Notice how in the second example there should be 3 forms on each line if possible because the first argument of are is a vector with 3 elements.

I haven't figured out a way to make this automatic, but at least if you define are in this way, it will let you format those lines "by hand":

> are1
"(defn myare\n[]\n(are [x y] (= x y)  \n  2 (+ 1 1)\n  4 (* 2 2))\n\n(are [x y z] (= x y z)  \n  2 (+ 1 1) (- 4 2)\n  4 (* 2 2) (/ 8 2)))"
> (print are1)
(defn myare
[]
(are [x y] (= x y)
  2 (+ 1 1)
  4 (* 2 2))

(are [x y z] (= x y z)
  2 (+ 1 1) (- 4 2)
  4 (* 2 2) (/ 8 2)))

>(czprint are1 {:parse-string? true :fn-map {"are" [:none {:list {:indent-only? true} :next-inner {:list {:indent-only? false}}}]}})
(defn myare
  []
  (are [x y] (= x y)
    2 (+ 1 1)
    4 (* 2 2))
  (are [x y z] (= x y z)
    2 (+ 1 1) (- 4 2)
    4 (* 2 2) (/ 8 2)))

Hopefully this will help.

The are function is now formatted specially (as of version 1.2.0), and correctly, for at least the examples I've been able to find here and there.


Adding initial files to the repo.

These files are necessary for the project.

I know these files are problematic, however they compile!
Issues have been created to track.


Remote File

I am interested in the question, does the tdlib api have the ability to upload a file to my storage? In general, I need to save images of chats in my storage. If I use the DownloadFile function, then in the UpdateFile handler I actually get the path to the file downloaded to a specific folder (parameters.databaseDirectory/profile_photos/). I could take this file and place it remotely on the storage. But I would like to know if it is possible to save a file remotely immediately, without downloading it locally?

Do I understand correctly that the stdlib api does not allow you to get the path as a url to a photo stored on the telegram side?

TDLib can download files only locally.
Sent in Telegram files aren't available through HTTP.


No information about skiped task

Deployer version: 7.3.1

I have a task:
task('yii2:db:create', function () {
    // something here
})
    ->select('foo')
;

when I run dep deploy on selector that not match the ->selector('foo') my task is skipped, but deploy logs not show that.
Instead it show something like:
task yii2:db:create
done yii2:db:create 0ms

which is confusing :-|
I believe it should be something like:
task yii2:db:create
skipped yii2:db:create 0ms

if your select() is false, then nothing happens, this looks exactly like this :-)
And that you don't have an equal sign in your call looks broken ;-)
https://deployer.org/docs/7.x/api#select

More info:
dep deploy {selector}
task foo
task boo

dep deploy {selector} -v
task foo
[tag] something here
task boo

When running deploy without any verbose task 'foo' (executed) and 'boo' (skipped) is indistinguishable.
With verbose we have some info but it's still confusing.

We should use skip so it is in line with the 4 letter task and done. But I like the idea very much


Instances for QueryParam codec

This adds instances for QueryParamEncoder and QueryParamDecoder. Instances are constructed lazily to avoid initialization issues.

Apparently widen isn't part of scalaz.Functor in scalaz 7.1

Hell.


Feature Request: Different Colours Per Cluster

Feature Request: Different Colour UI Per Cluster
I often flip between clusters without realizing which one I'm in, and then can edit the wrong one.  It'd be nice if I could set different colour backgrounds per cluster so I can tell what context I'm in.

Duplicate of https://github.com/rancher/rancher/issues/15838

Pardon my ignorance, but all the referenced duplicates are closed but I'm unclear what the resolution is.  Does this feature exist already?  Is it on a roadmap?  Is it not going to be implemented?

It's not on the roadmap, the referenced issue was opened a while ago and there has been no response or request for it so it is closed to try to keep the backlog as clean as possible for features that will be implemented.


Don't show onboarding pager to user if they have seen it in the past

PR is created for the issue. If they have already scrolled through the pager, we should not make them scroll again, instead take them to permissions fragment directly.

The onboarding page is only shown once. I think you may have cloned a version of the code where a configuration was set to force the onboarding page to be shown all the time for debugging purposes.
Look at OnboardingActivity.java
We store a boolean state indicating whether the user has gone through the onboarding steps:
boolean b = prefs.getBoolean(getString(R.string.onboard_enabled_pkey),true);
If the user has done this, then it won't be shown.
In MainActivity.java this is set to false:
editor.putBoolean(getString(R.string.onboard_enabled_pkey), false);
Most likely in the version you cloned the "forceOnboard" variable in OnboardingActivity.java was enabled.

I saw that part in the code, what i am referring to not showing the pager
again if they have seen it in the past. We can discuss tomorrow. Opening
the issues. You will get to know from the changes i made. :)
Thanks and Regards,
Akashdeep Singh
On Sat, Apr 18, 2020 at 1:29 AM Justin Chan<EMAIL_ADDRESS>wrote:

The onboarding page is only shown once. I think you may have cloned a
version of the code where a configuration was set to force the onboarding
page to be shown all the time for debugging purposes.
Look at OnboardingActivity.java
We store a boolean state indicating whether the user has gone through the
onboarding steps:
boolean b =
prefs.getBoolean(getString(R.string.onboard_enabled_pkey),true);
If the user has done this, then it won't be shown.
In MainActivity.java this is set to false:
editor.putBoolean(getString(R.string.onboard_enabled_pkey), false);
Most likely in the version you cloned the "forceOnboard" variable in
OnboardingActivity.java was enabled.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/covidsafe/App-Android/issues/19#issuecomment-615755515,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAYL6FXJFXACANLYZZIAVP3RNFQGVANCNFSM4MLIJ33Q
.

I am working on the latest code 👍


WRN-11824:

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.5 out of 13 committers have signed the CLA.:white_check_mark: juwonjeong:white_check_mark: alexandrumorariu:white_check_mark: sjro:white_check_mark: jeonghee27:white_check_mark: adrian-cocoara-lgp:x: Teck:x: RenukaAtale:x: JayCanuck:x: sugardave:x: 0x64:x: YunhoLee0:x: daniel-stoian-lgp:x: stanca-pop-lgpTeck seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Cannot remove down tikv node

Question

one of my tikv node down because of data corruption，i need remove it， i had execute store delete comand two days ago
，but its region count almost keep the same ，i cannot remove the abnormal node，how can i do it

@yester354  This is most likely due to an unhealthy store state, such as has a lot of regions that are not elected leader.

This is caused by no leader region, see #5852

After using tikv-ctl tombstone to remove the stale peer, the no leader region can do election normally.


Theming issues in output

theming issues when rendering this:

asyncapi: 2.0.0
info:
  title: TEST
  version: 1.0.0

servers:
  local:
    url: <IP_ADDRESS>
    protocol: mqtt
    variables:
      port:
        enum:
          - '8883'
          - '9001'
        default: '8883'

components:
  schemas:
    languageInfoObject:
      title: Language info object
      type: object
      properties:
        languageCode:
          type: string
      examples:
        - languageCode: ja-JP
        - languageCode: zh-CN
        - languageCode: fr-FR

  parameters:
    randomKey:
      description: A random ID to identify the request.
      schema:
        type: string

  securitySchemes:
    user-password:
      type: userPassword

channels:
  'zbos/dialog/tts/languages/response/{key}':
    parameters:
      key:
        $ref: '#/components/parameters/randomKey'
    subscribe:
      tags:
        - name: speech
      summary: 'response: TTS languages list'
      message:
        payload:
          type: array
          items:
            $ref: '#/components/schemas/languageInfoObject'
          examples:
            - - age: ADULT
                languageCode: JPJ
                getDialogConfig: MALE
                language: Japanese
                languageVersion: 1.1.0
                name: Daisuke
                frequency: 22050

The examples overlap and page becomes very wide.

Thanks for reporting, @rv0! Will have a look at it as soon as I have time.

Gonna take a quack at it, however I am not a big fan of tailwind, so lets see what happens.

There is also a problem with defining publish and subscribe for the same channel. I know this is not normally done, but I had a use case where I included multiple clients in one and seperated the channels by a security extension.

Thanks for the great work!


[FEATURE] Docker image for each release

Describe the feature you'd like
For now only "latest" tag is available on Docker Hub, it will be great to also build an image each time a new release tag  is created on the repository.
Additional context
Add any other context or screenshots about the feature request here.

this is good suggestion will do!

Done :-)


Display correct runtime-spec version

Instead of using a constant as the runtime-spec
version, user Version in the package.
Signed-off-by: Lei Jitang<EMAIL_ADDRESS>

lgtm (ianam)

Dup of #9 (which I think is doing a more thorough job)?

On Thu, Sep 22, 2016 at 09:43:18AM -0700, Antonio Murdaca wrote:

@@ -70,7 +70,7 @@ func (c *config) runtimeSpec(rootfs string) (*specs.Spec, error) {
}

var s specs.Spec

s.Version = "0.5.0"

s.Version = specs.Version

this was the runtime version not the image one right? if so this is
wrong (do image and runtime follow same release? if so this is still
wrong to me, but righter...)

I think this change is right.  It's using the runtime version
(specs.Version) to fill in a field on the generated runtime config.
With this PR, there's one less place to bump when image-tools moves to
new runtime-spec versions.  Although with the approach made possible
by opencontainers/runtime-tools#219, we will be able to drop the
runtime-spec dependency completely.

LGTM


controller: Increment log

What does this implement/fix? Explain your changes.
This pull request implements unit tests for all interactor features.

Adds new logs in controller

Does this close any currently open issues?
Any relevant logs, error output, etc?
Any other comments?
Where has this been tested?
 The error logs looks awesome to me. However, I'm not sure about the use of debug and info logs, and the difference between them both
Wait to see what @netoax and @lcbm comment about! 😄

@esdrasjnr We usually use debug for more detailed contextual information about the operations is being executed. Besides, info just shows that operations were received and executed or not.


Unknown at rule: @rn-hoist - V4

When the node_modules/.cache/nativewind/global.css.native.css file includes a @rn-hoist  and the application is booted on web with the Metro web bundler the following error occurs: error: SyntaxError in node_modules/.cache/nativewind/global.css.native.css: Unknown at rule: @rn-hoist
Example of the CSS in the global.css.native.css file:
.placeholder\:text-neutral-faded {
  color: var(--text-neutral-faded);
  @rn-hoist color placeholderTextColor
}

.fill-icon-neutral {
  @rn-hoist fill;
  fill: rgb(0, 0, 0)
}

As expected removed the @rn-hoist items manually from this file then result in the web application working again.
To Reproduce
Steps to reproduce the behaviour:

Set up NativeWind V4 with Metro web bundler.
Ensure your cached global.css.native.css files includes a @rn-hoist.
Try and boot the web app and you should get the same error as above.

Expected behavior
The web bundler should not be picking up the global.css.native.css file or it should support the @rn-hoist.

Running expo with a clean cache resolved this: npx expo start --clear


Explosions Outside of Protected Zones can Explode Inside Protected Zones.

Pretty simple. Drag a creeper to a land claim border and boom, right outside of the protection and spills into the claimed land.
https://i.imgur.com/Z4KVYPc.png
I would just disable them in the wild, but when I do this they stop doing all damage to the player as well they just pretty much puff out of existence and that is no fun.
Versions:
forge-1.10.2-<IP_ADDRESS>7-universal.jar
spongeforge-1.10.2-2477-5.2.0-BETA-2731.jar
griefprevention-1.10.2-<IP_ADDRESS>2.jar
LuckPerms-Sponge-4.0.16.jar
https://i.imgur.com/Z4KVYPc.png

Not sure what happen but I seem to have fixed the issue. Maybe the other pack had something screwing it up so to save someone the headache I will go ahead and close it.


Leading comma in the 1st line

Describe the bug
The CSV-export shows aleading comma in the headline
To Reproduce
Steps to reproduce the behavior:

export statistic
open CSV-file
find the leading comma in the first line

Expected behavior
There is no leading comma
Screenshots

The comma is fine but there should be a name for the column like "Stadt" or so in front of it :D


Remove debt for one server

Maybe not a overhaul all at once, but as you see it, while working, try to help it

This is kinda deeply imbedded in this current bot.
Maybe if we get around to doing #383 we can make that the goal from the beginning.

no plan to do this anytime soon, if at all lol


Custom nodes added to node-red can cause the editor to no longer load

If a node installed using the node-red palette editor has a syntax error in the frontend code, it causes the frontend to crash out, which makes node-red unusable.
Just as an example, installing https://flows.nodered.org/node/node-red-ca_enginenode causes this issue.
Node-red version 15.2

There isn't a quick fix to this. The editor loads all node html content in a single request; the runtime serves them all concatenated together. That does mean we cannot isolate individual nodes that have errors.
One approach would be to load each node individually. That would allow errors to be isolated, but would slow down loading the palette as a single http request is now replaced by many.
Some more thought needed - taking off the 0.16 list.


Fix some issues flagged by pyright; add a pyright config

This PR fixes a few issues flagged by pyright, and adds a tool.pyright section to pyproject.toml to improve the experience of working on the plugin inside VSCode.
(I don't personally feel the need to run pyright in CI, since none of the issues uncovered here are particularly dire.)

If we don't run it in CI we shouldn't add the pyright config, since we'll inevitably introduce new pyright errors and the config will give the false impression that we're supposed to be checked with pyright.

I don't feel strongly about adding the config, I'll remove it 👍


Show info on Service Card

Description
So coming form Heimdall, one of the best features was the ability to check things at a glance, such as current leeching (per qbit instances), current things in queue or missing for the ARRs, warnings and errors for apps like Netdata, and stream count on Tautulli (just to name a few.
From the image below you can see my recent setup for Heimdall and what I'm referring to.

Priority
Low (Nice-to-have)
Please tick the boxes

[X] You've read the docs
[X] You've checked for duplicate issues

+1 for this, would be nice to have more info from integrations like radarr etc. ability to specify what it shows would be a bonus.

This is kind of hard to do but I might consider it. Showing how many medias Radarr or Sonarr have found or the current DL speed of a certain service.

Please continue this discussion on https://github.com/ajnart/homarr/issues/469


MRG: Make test more lenient

Closes #2834.

Ok, will wait until this is merged and run the csp test with mkl and various sklearn version

Owesome! Thanks @Eric89GXL

No problem, I'll go ahead and merge since we converged on this in the other thread(s).

Thanks @Eric89GXL !


Fix Sass deprecation warning re: reverse-gradient function.

Since Sass 3.4.10 (January), passing anything other than a non-string value to the unquote function is deprecated. This affects the reverse-gradient function, which tries to pass a list through unquote. This PR removes this usage of unquote.
Status: Ready to merge
Reviewers: @jeffkamo @avelinet @cole-sanderson @mlworks @yourpalsonja @nastiatikk
Ticket: N/A
Linked PRs: N/A
Changes

No longer attempt to unquote the final list returned from reverse-gradient.

How to test-drive this PR

Clone this repo and run npm install && bower install to ensure dependencies are installed
Run grunt to compile Sass
Ensure all the DEBUG statements in output pass
Open the test/index.html file and verify that the reverse-gradient function still works.

Research resources

Sass commit adding unquote deprecation warning

I didn't know about `uni

So to clarify since Sass 3.4.10 you can pass non-string value only?

@nastiatikk Yes, in 3.4.10+ you can’t pass a list to unquote, which we are accidentally doing in the reverse-gradient function. Attempting to unquote a list never did anything, so we can safely remove the call in this case. I’m actually not sure when unquoting is strictly necessary, if ever.

Maybe @jeffkamo could give some ideas? Seems like it was his tweak https://github.com/mobify/spline/commit/70d0b7b05d6fda9bf39d2e23c48f669a3528ff21

I'm fine with this change. If the usecase is no longer supported (via deprecation) it's probably a good idea that we fix our code to reflect that.

I just haven't tested the change yet.

@jeffkamo Just to be clear, there was never a “use case” for passing a Sass list to unquote – it just allowed you to do that and passed the list through unchanged. Now, this is deprecated (and will be an error in future versions).

Yup, that's basically what I meant. I suppose I should've said "non-use case" instead.

:bow:

This change sounds reasonable
+1

I'm sure I must have done that for a reason though... :octopus:

@kpeatt Hi there 😄. I can see it being done as insurance, in case the list itself could be a string. Re-reading the code again, it seems like for some code paths that could be the case. We do need to change something here, but probably need to be more careful about it, and have a test for it. Let me look at this again and make sure.

Opened #47 until I can write a more careful PR.


Icon component is not part of components package

I'm submitting a bug report

Library Version:
0.6.0

Please tell us about your environment:

Operating System:
Windows 10

Node Version:
6.2.0

NPM Version:
3.10.3

JSPM OR Webpack AND Version
webpack-3.8.1

Browser:
all

Language:
all

Current behavior:
The ux-icon component is not part of @aurelia-ux/components package
Expected/desired behavior:

What is the expected behavior?
The ux-icon component is a part of @aurelia-ux/components package

What is the motivation / use case for changing the behavior?
All other components are part of that package

For now this is intentional. The reason behind this is the UX Icon component is very large and does not benefit from tree shaking due to the way the Icons are currently included. The Icon map is the source of the bloat at over 300kb which is larger than the rest of the library.

.
Core + Components
Core + Components (Minified)
Core + Components + Icons
Core + Components + Icons  (Minified)

Parsed
219.62 kb
103.17 kb
571.13 kb
376.6 kb

GZipped
27.33 kb
17.19 kb
99.84 kb
88.4 kb

Visual of a production build with tree shaking and minification

It makes sense, I think we can close this issue then :)


Proposed feature: Actual size dimensions (after highres fix) / Highres fix check

Stumbled upon this application today, works wonders. Thank you.
I'm sorting through my larger sized images, including those made with the highres fix. This means that while the actual height (for instance) is 1024px, but the metadata says 512px. Is there a way for this to be implemented (or is there one already?)
Alternatively, a check to see if the highres fix has been applied?

I pull the dimensions from the Stable DIffusion metadata, but I should probably try to pull it first from the regular metadata.

I second a filter for upscaling, or sorting by size, or usage of greater than / less than when filtering for size..

Plus one to this, it would be lovely :)


remove op history stuff ?

test how big this is for big patches

20% faster on db write. lets try less indexing ?

only save when not working in patch alone

useless and full of bugs, remove


fix: missing const before declarations

The grammar will fail to evaluate if JS is run in 'strict mode', since the variable assignments are assigning them as globals, which is disallowed in strict mode.

Thank you!


json_report lacks the skip_empty argument

xml_report and html_report both has the skip_empty argument, but json_report doesn't have this argument.

My theory about the JSON report is that it is not meant for human eyes, it is meant to be parsed by a program.  That program can choose to skip empty files if it chooses.
How are you using the JSON report?

My theory about the JSON report is that it is not meant for human eyes, it is meant to be parsed by a program.  That program can choose to skip empty files if it chooses.
How are you using the JSON report?

My theory about the JSON report is that it is not meant for human eyes, it is meant to be parsed by a program. That program can choose to skip empty files if it chooses.
How are you using the JSON report?

My JSON report will be parsed by my program and users can not see it.
I am just confused that why json_report doesn't have the skip_empty argument when I reading the code.
Your answer resolves my confusion. Thank you

My theory about the JSON report is that it is not meant for human eyes, it is meant to be parsed by a program. That program can choose to skip empty files if it chooses.
How are you using the JSON report?

My JSON report will be parsed by my program and users can not see it.
I am just confused that why json_report doesn't have the skip_empty argument when I reading the code.
Your answer resolves my confusion. Thank you


Update contributing guide with new template format

Link to the HowTo guide on the website https://github.com/cncf/tag-contributor-strategy/pull/164
Remove html comments, which are now in the HowTo
Add prompts to fill out sections that follow our format of ⚠  Instructions

/approve


Add support for building for Linux

This PR adds support for building an AppImage executable for Linux systems. I can confirm that the executable can be built and run on Ubuntu 23.04.

Side note: I'm a frosh at MIT working on Illuminations and its documentation as a project of the Admissions Office.


Test the performance of MCTS and TF neural networks

AS A machine learning engineer or a project manager
I WANT TO understand the performance of our MCTS and TF NN evaluations
SO THAT I CAN estimate the time and computation resource for a network to mature to the performance of a grandmaster
Acceptance Criteria:

[ ] I understand the resources (time and computation power) required to achieve grandmaster level performance
[ ] If ant additional resource is required, I have a plan to acquired those. (e.g. performance improvement, AWS etc)

9bcebee3a44a8820c5a828270018c194fe342fb3
A single decision with 800 MCTS simulation takes 16~19 seconds.

Over the course of training, 4.9 million games of self-play were generated, using 1,600 simu-
lations for each MCTS, which corresponds to approximately 0.4s thinking time per move. Param-
eters were updated from 700,000 mini-batches of 2,048 positions. The neural network contained
20 residual blocks (see Methods for further details).

We should aim for at least 1 second MCTS thinking time to even be remotely effective.

bfaa4bc
With 800 MCTS simulations, on average there are:
4000 select operations
20000 nodes creations
At this moment, each node preserves a full copy of the environment with a board.copy() operation. This is very expensive.
I suspect this is a major contributor to the runtime.


feat: Expose streaming as public API wrap

Close https://github.com/seanmonstar/reqwest/issues/2243

Hi, @seanmonstar, do you think it's a good time for us to expose this API?

Thanks!


Remove version: OpenJS.NodeJS.LTS version 14.16.0

Replaced by another Pull Request
Microsoft Reviewers: Open in CodeFlow

https://www.github.com/microsoft/winget-pkgs/pull/143386#issuecomment-1986949152 [Policy] Needs-Author-Feedback

Close with reason: See discussion in above linked issue;


FlashAttention works with single GPU, but crash with accelerate DP on multiple GPU (FlashAttention only support fp16 and bf16 data type)

System Info
`Accelerate` version: 0.22.0
Platform: Linux-5.10.192-183.736.amzn2.x86_64-x86_64-with-glibc2.29
Python version: 3.8.10
Numpy version: 1.23.1
PyTorch version (GPU?): 2.0.1+cu117 (True)
PyTorch XPU available: False
PyTorch NPU available: False
System RAM: 1121.81 GB
GPU type: NVIDIA A100-SXM4-80GB

transformers              4.37.2
trl                       0.7.11.dev0
flash-attn                2.5.2

out, q, k, v, out_padded, softmax_lse, S_dmask, rng_state = flash_attn_cuda.varlen_fwd(
RuntimeError: FlashAttention only support fp16 and bf16 data type

Reproduction
The following script works as expected on 1 GPU, but if running on multiple GPU with DP, it will give error:
out, q, k, v, out_padded, softmax_lse, S_dmask, rng_state = flash_attn_cuda.varlen_fwd(
RuntimeError: FlashAttention only support fp16 and bf16 data type
import os
import wandb

import torch
from accelerate import Accelerator
from datasets import load_from_disk
from peft import LoraConfig, get_peft_model, prepare_model_for_kbit_training
from transformers import (
    AutoModelForCausalLM,
    AutoTokenizer,
    BitsAndBytesConfig,
    AutoTokenizer,
    TrainingArguments
)

from trl import DataCollatorForCompletionOnlyLM

from PIL import Image
from transformers import AutoProcessor, LlavaForConditionalGeneration, AutoTokenizer

import sys
project_root = '/'.join(os.path.dirname(__file__).split('/')[:-1])
print(project_root)
sys.path.append(project_root)
from utils.meta_loader import write_meta, read_meta

import transformers

# bench
alpha = 16
rank = 64
batch_size = 2
length = 4096
accumlate_steps = 1
lr = 5e-5

train_dataset = load_from_disk("/mnt/localssd/dataset/llava_processed_dataset/train")
eval_dataset = load_from_disk("/mnt/localssd/dataset/llava_processed_dataset/test")

run_name = "llava_debug"
save_dir = "/mnt/localssd/llava_debug"

compute_dtype = getattr(torch, "float16")

bnb_config = BitsAndBytesConfig(
    load_in_4bit=True,
    # load_in_8bit=True,
    bnb_4bit_quant_type="nf4",
    bnb_4bit_compute_dtype=compute_dtype,
    bnb_4bit_use_double_quant=True,
    # llm_int8_skip_modules=["multi_modal_projector"]
)

model = LlavaForConditionalGeneration.from_pretrained(
    "llava-hf/llava-1.5-7b-hf",
    # "llava-hf/bakLlava-v1-hf",
    quantization_config=bnb_config,
    trust_remote_code=True,
    device_map={'':torch.cuda.current_device()},
    torch_dtype=torch.float16,
    use_flash_attention_2=True
    )

target_modules = [
    "*language_model.*q_proj",
    "*language_model.*k_proj",
    "*language_model.*v_proj",
    "*language_model.*o_proj",
    "*language_model.*gate_proj",
    "*language_model.*up_proj",
    "*language_model.*down_proj",
    "*language_model.*lm_head"]

modules_to_save = ["linear_1", "linear_2"]

peft_config = LoraConfig(
    lora_alpha=alpha,
    lora_dropout=0.1,
    r=rank,
    bias="none",
    task_type="CAUSAL_LM",
    target_modules=target_modules,
    modules_to_save=modules_to_save
)

tokenizer = AutoTokenizer.from_pretrained("llava-hf/llava-1.5-7b-hf", trust_remote_code=True)
tokenizer.pad_token = tokenizer.eos_token

processor = AutoProcessor.from_pretrained("llava-hf/llava-1.5-7b-hf")

model = prepare_model_for_kbit_training(model, use_gradient_checkpointing=True)
model = get_peft_model(model, peft_config)

training_arguments = TrainingArguments(
    output_dir=save_dir,
    per_device_train_batch_size=batch_size,
    gradient_accumulation_steps=accumlate_steps,
    optim="paged_adamw_32bit",
    save_steps=500,
    logging_steps=10,
    learning_rate=lr,
    fp16=True,
    max_grad_norm=0.3,
    num_train_epochs=100,
    warmup_ratio=0.03,
    # group_by_length=True,
    lr_scheduler_type="constant",
    run_name=run_name,
    evaluation_strategy="steps",
    eval_steps=200,
    ddp_find_unused_parameters=False,
    gradient_checkpointing=True,
    # weight_decay=0.01,
    # dataloader_num_workers=NUM_PROC//2
)

model.config.use_cache = False # not use for fine tuning

def test_data_collator(datas):
    result = {}
    input_ids = [torch.Tensor(d['input_ids']) for d in datas]
    attention_mask = [torch.Tensor(d['attention_mask']) for d in datas]
    pixel_values = [torch.Tensor(d['pixel_values']) for d in datas]
    labels = [torch.Tensor(d['labels']) for d in datas]

    result['input_ids'] = torch.concat(input_ids).type(torch.int64)
    result['attention_mask'] = torch.concat(attention_mask).type(torch.int64)
    result['pixel_values'] = torch.concat(pixel_values)
    result['labels'] = torch.concat(labels).type(torch.int64)
    return result

trainer = transformers.Trainer(
    model=model,
    train_dataset=train_dataset,
    eval_dataset=eval_dataset,
    args=training_arguments,
    data_collator=test_data_collator
)

trainer.train()```

### Expected behavior

Expect the behavior should be the same for both single GPU and Multi GPU

I'm not familiar with accelerate or how transformers uses FlashAttention, you'd probably get better help asking on those repos.

I am getting a similar issue without training with torch nightly on Llama so can confirm something's wrong! Might be on our side, but as far as I tested all the inputs's dtypes were bfloat16, still got the issue.
Reproducer is here with attn_implementation="flash_attention_2" and the corresponding PR on transformers.
- `transformers` version: 4.38.0.dev0
- Platform: Linux-5.4.0-166-generic-x86_64-with-glibc2.31
- Python version: 3.10.0
- Huggingface_hub version: 0.20.3
- Safetensors version: 0.4.2
- Accelerate version: 0.27.0
- Accelerate config:    not found
- PyTorch version (GPU?): 2.3.0.dev20240208+cu121 (True)
- Tensorflow version (GPU?): not installed (NA)
- Flax version (CPU?/GPU?/TPU?): not installed (NA)
- Jax version: not installed
- JaxLib version: not installed
- Using GPU in script?: <fill in>
- Using distributed or parallel set-up in script?: <fill in>

flash_attn=2.5.3 + torch nightly so (2.3 ish)

from flash_attn import flash_attn_func
import torch
flash_attn_func(torch.ones((2,3), dtype=torch.bfloat16), torch.ones((2,3), dtype=torch.bfloat16), torch.ones((2,3), dtype=torch.bfloat16), 1, softmax_scale=1, causal=True)

this doesn't work for me

this doesn't work for me again, might be because I have. cc @tridao not sure how relevant this is

The q, k, v need to be on 'cuda' and have shape (batch, seqlen, nheads, headdim).

The error is before that, but it seems it's torch nightly, the transformers snippet works with torch2.2 !
So more reliable.
(I am getting RuntimeError: q must be on CUDA with my snippet on torch2.2 so different error
)

I am getting a similar issue without training with torch nightly on Llama so can confirm something's wrong! Might be on our side, but as far as I tested all the inputs's dtypes were bfloat16, still got the issue. Reproducer is here with attn_implementation="flash_attention_2" and the corresponding PR on transformers.
- `transformers` version: 4.38.0.dev0
- Platform: Linux-5.4.0-166-generic-x86_64-with-glibc2.31
- Python version: 3.10.0
- Huggingface_hub version: 0.20.3
- Safetensors version: 0.4.2
- Accelerate version: 0.27.0
- Accelerate config:    not found
- PyTorch version (GPU?): 2.3.0.dev20240208+cu121 (True)
- Tensorflow version (GPU?): not installed (NA)
- Flax version (CPU?/GPU?/TPU?): not installed (NA)
- Jax version: not installed
- JaxLib version: not installed
- Using GPU in script?: <fill in>
- Using distributed or parallel set-up in script?: <fill in>

flash_attn=2.5.3 + torch nightly so (2.3 ish)

I can't run the reproducer right now bc StaticCache is not in transformers 4.37.2 (latest stable version).

this doesn't work for me again, might be because I have. cc @tridao not sure how relevant this is

The q, k, v need to be on 'cuda' and have shape (batch, seqlen, nheads, headdim).

Yeah flash attention uses (batch , seqlen, nheads, headdim ) to represent inputs, however in many software (triton, for example) we have reasons to use (batch, nheads, seqlen, headim) for easy arrangement of layout. Actually they are equivalent with this mapping:
    def permute(self, x: torch.Tensor) -> torch.Tensor:
        new_x_shape = x.size()[:-1] + (self.nheads, self.headim)
        x = x.view(new_x_shape)
        return x.permute(0, 2, 1, 3)

But it is weird that the error (I have tested in the lastest version) says "FlashAttention only support fp16 and bf16 data type".
So we need to update the error information, right ?

I confirm that flash-attn==2.5.6 doesn't work with torch==2.3.0a0+40ec155e58.nv24.3 nightly even though inputs are indeed in torch.bfloat16 format!
I rolled back to torch2.2 stable and reinstalled flash-attn and now it works.


Rclone Update for Rclone Bug

Rclone had a bug with uploading OneDrive files. It was fixed in v1.66, see here: https://github.com/rclone/rclone/issues/7405
Can you update the dockerfile to use rclone v 1.67.0? This will fix the onedrive unauthenticated upload issue.

closed by #197


Does not increase right stick deadzone in RL

XBOX One S controller

Goal: 0.11 deadzone on left stick and 0.18 or higher on right stick
I am on Epic and have restarted the game after applying both 32 bit and 64 bit, as well as applied while the game was closed

Wrong issue tracker I'm afraid. This appears to be a quite modified version of Durazno, check on the upper right as it seems to have a link for "Help and updates" which might be worth checking out.


feat(asCol): add asCol HOC

:tada: This PR is included in version 16.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


[BUG] page.pdf generating blank pdf for domain www.adobe.com

Context:

Playwright Version: 1.12.1
Operating System: Windows
Browser: Chromium

Describe the bug
I am converting adobe.com html to pdf using playwright. In headless mode, empty blank pdf is getting generated while in headed mode / chrome browser the contents are visible.
Code is simply to navigate and print -
page.navigate("https://www.adobe.com");
page.pdf();
Can you help identify why behaviour is different for www.adobe.com URL for headless mode?

I am converting adobe.com html to pdf using playwright. In headless mode, empty blank pdf is getting generated while in headed mode / chrome browser the contents are visible.
...
Can you help identify why behaviour is different for www.adobe.com URL for headless mode?

Looks like some bot protection kicks in on the adobe.com site and it serves different page when you access it from a headless browser (or more generically browser controlled by automation I believe). I get this page in headless:

@yury-s is there any special difference in a browser controlled by automation, that a site can identify and block?
Any special properties that are added to browser?

Yes, there are many subtle differences, to start with user-agent header is different, 'navigator.webdriver' property may be true etc. Support for a 'stealth' mode where the server cannot tell if the browser is controlled by automation is not a goal for Playwright at the moment as we assume that in the test environment you can always tweak the server to serve right content.


Don't run rpmqa plugin if koji configured

No need to run rpmqa if koji_promote will be fetching that data anyway and koji-containerbuild won't need its output.

CC @maxamillion

Actually this is wrong. We need the rpmqa plugin to run as that provides information to the koji_promote plugin.
What we don't need, when koji is configured, is to store that rpmqa output as an annotation. I even think we should only run rpmqa if koji_promote is configured, and never store the rpmqa output as an annotation.

Fixed via https://github.com/projectatomic/atomic-reactor/pull/451.


Serial number check failed error message is not correct

check comments

The error is not self explanatory
Need to review error messages.

Please change it to "Failed to validate serial Number"


Included FFmpeg for MacOS doesn't work on new Macs

What version are you running?
pip-21.3.1
What went wrong
Paste the command you've tried.
auto-editor /Users/IMAC/Movies/ScreenFlow2.mov

**Describe what went wrong**
The file Movies/ScreenFlow2_ALTERED.mov was not created```

Paste the terminal output here.
iMac-de-Gamal:~ IMAC$ auto-editor /Users/IMAC/Movies/ScreenFlow2.mov
dyld[9389]: Library not loaded: /usr/local/opt/libxcb/lib/libxcb.1.dylib
  Referenced from: /Library/Frameworks/Python.framework/Versions/3.10/lib/python3.10/site-packages/auto_editor/ffmpeg/Darwin/ffmpeg
  Reason: tried: '/usr/local/opt/libxcb/lib/libxcb.1.dylib' (no such file), '/usr/local/lib/libxcb.1.dylib' (no such file), '/usr/lib/libxcb.1.dylib' (no such file)
Error! The file /Users/IMAC/Movies/ScreenFlow2_ALTERED.mov was not created.

Something went wrong!
Create a bug report at:
  https://github.com/WyattBlue/auto-editor/issues/
**What conditions must be met for it to be wrong**

**Does the example video work? (if applicable)**

**What's your platform? (if applicable)**
Run: `auto-editor --debug`

MAC

Paste output here.
Python Version: 3.10.1 64-bit
Platform: Darwin 21.2.0 x86_64
FFmpeg path: /Library/Frameworks/Python.framework/Versions/3.10/lib/python3.10/site-packages/auto_editor/ffmpeg/Darwin/ffmpeg
FFmpeg version: dyld[9604]:
Auto-Editor version 21w51a
**What properties your input file(s)? (if applicable)**
You can use  `aeinfo ./path/to/video.mp4` or `ffmpeg -hide_banner -i ./path/to/video.mp4` to get standard info.

Paste output here.

Run
./Library/Frameworks/Python.framework/Versions/3.10/lib/python3.10/site-packages/auto_editor/ffmpeg/Darwin/ffmpeg

and show the output

iMac-de-Gamal:~ IMAC$ ./Library/Frameworks/Python.framework/Versions/3.10/lib/python3.10/site-packages/auto_editor/ffmpeg/Darwin/ffmpeg
-bash: ./Library/Frameworks/Python.framework/Versions/3.10/lib/python3.10/site-packages/auto_editor/ffmpeg/Darwin/ffmpeg: No such file or directory

ugh, run
/Library/Frameworks/Python.framework/Versions/3.10/lib/python3.10/site-packages/auto_editor/ffmpeg/Darwin/ffmpeg

and show the output

iMac-de-Gamal:~ IMAC$ /Library/Frameworks/Python.framework/Versions/3.10/lib/python3.10/site-packages/auto_editor/ffmpeg/Darwin/ffmpeg
dyld[10356]: Library not loaded: /usr/local/opt/libxcb/lib/libxcb.1.dylib
Referenced from: /Library/Frameworks/Python.framework/Versions/3.10/lib/python3.10/site-packages/auto_editor/ffmpeg/Darwin/ffmpeg
Reason: tried: '/usr/local/opt/libxcb/lib/libxcb.1.dylib' (no such file), '/usr/local/lib/libxcb.1.dylib' (no such file), '/usr/lib/libxcb.1.dylib' (no such file)
Abort trap: 6

Hmm, it appears that the precompiled FFmpeg doesn't work on the new MacBooks.
Remove the binary and install ffmpeg if you haven't already
rm /Library/Frameworks/Python.framework/Versions/3.10/lib/python3.10/site-packages/auto_editor/ffmpeg/Darwin/ffmpeg

brew install ffmpeg

iMac-de-Gamal:~ IMAC$ brew install ffmpeg
-bash: brew: command not found

Go install homebrew here: https://brew.sh/

installing homebrew

installing homebrew done

installing ffmpeg

ffmpeg installed but ñook at this
auto-editor /Users/IMAC/Movies/ScreenFlow2.mov
Error! No ffmpeg found, download via homebrew or restore the included binary.

brew reinstall ffmpeg done but
iMac-de-Gamal:~ IMAC$ auto-editor /Users/IMAC/Movies/ScreenFlow2.mov
Error! No ffmpeg found, download via homebrew or restore the included binary.

I have macos monterey

finally auto-editor running.
final solution:
As of March 25th, 2020, MacOS + homebrew install has disabled native dependencies support. If additional libraries are required for an FFMPEG build, installing all the extra configurations can be accomplished with this script:
brew uninstall --force --ignore-dependencies ffmpeg
brew install chromaprint amiaopensource/amiaos/decklinksdk
brew tap homebrew-ffmpeg/ffmpeg
brew install ffmpeg
brew upgrade homebrew-ffmpeg/ffmpeg/ffmpeg $(brew options homebrew-ffmpeg/ffmpeg/ffmpeg | grep -vE '\s' | grep -- '--with-' | grep -vi chromaprint | tr '\n' ' ')
then uninstall and reinstall auto-editor
pip3 uninstall auto-editor
pip3 install auto-editor
That's all
credits to JOHN RISELVATO. http://johnriselvato.com/how-to-install-ffmpeg-on-macos/

brew upgrade homebrew-ffmpeg/ffmpeg/ffmpeg $(brew options homebrew-ffmpeg/ffmpeg/ffmpeg | grep -vE '\s' | grep -- '--with-' | grep -vi chromaprint | tr '\n' ' ')

This is where it fails for me:
 % brew upgrade homebrew-ffmpeg/ffmpeg/ffmpeg $(brew options homebrew-ffmpeg/ffmpeg/ffmpeg | grep -vE '\s' | grep -- '--with-' | grep -vi chromaprint | tr '\n' ' ')
==> Upgrading 1 outdated package:
homebrew-ffmpeg/ffmpeg/ffmpeg 4.4.1_5 -> 5.0-with-options
==> Downloading https://ffmpeg.org/releases/ffmpeg-5.0.tar.xz
Already downloaded: /Users/christoph/Library/Caches/Homebrew/downloads/ca7feb8ffc2f64941a9c9099ede3d74293119b7d8eed5772e7024fc1cebc250e--ffmpeg-5.0.tar.xz
==> Upgrading homebrew-ffmpeg/ffmpeg/ffmpeg
  4.4.1_5 -> 5.0-with-opti
==> ./configure --prefix=/opt/homebrew/Cellar/ffmpeg/5.0-with-options --enable-s
==> make install
Last 15 lines from /Users/christoph/Library/Logs/Homebrew/ffmpeg/02.make:
                    ^
/Library/Developer/CommandLineTools/SDKs/MacOSX12.sdk/usr/include/c++/v1/atomic:1860:21: error: unknown type name 'ptrdiff_t'
    _Tp* operator+=(ptrdiff_t __op) _NOEXCEPT          {return fetch_add(__op) + __op;}
                    ^
/Library/Developer/CommandLineTools/SDKs/MacOSX12.sdk/usr/include/c++/v1/atomic:1862:21: error: unknown type name 'ptrdiff_t'
    _Tp* operator-=(ptrdiff_t __op) volatile _NOEXCEPT {return fetch_sub(__op) - __op;}
                    ^
/Library/Developer/CommandLineTools/SDKs/MacOSX12.sdk/usr/include/c++/v1/atomic:1864:21: error: unknown type name 'ptrdiff_t'
    _Tp* operator-=(ptrdiff_t __op) _NOEXCEPT          {return fetch_sub(__op) - __op;}
                    ^
fatal error: too many errors emitted, stopping now [-ferror-limit=]
20 errors generated.
make: *** [libavdevice/decklink_enc.o] Error 1
20 errors generated.
make: *** [libavdevice/decklink_dec.o] Error 1

If reporting this issue please do so at (not Homebrew/brew or Homebrew/core):
  https://github.com/homebrew-ffmpeg/homebrew-ffmpeg/issues

These open issues may also help:
FFmpeg with decklink support installation failure https://github.com/homebrew-ffmpeg/homebrew-ffmpeg/issues/92
Brewing custom ffmpeg but failure at metal execution https://github.com/homebrew-ffmpeg/homebrew-ffmpeg/issues/96
opencv not working after homebrew-ffmpeg installation https://github.com/homebrew-ffmpeg/homebrew-ffmpeg/issues/93

 ~ %

I have looked at the other github issues that are mentioned but none of them helped me fix this. Is this just me being stupid or does this solution no longer work?

brew upgrade homebrew-ffmpeg/ffmpeg/ffmpeg $(brew options homebrew-ffmpeg/ffmpeg/ffmpeg | grep -vE '\s' | grep -- '--with-' | grep -vi chromaprint | tr '\n' ' ')

This is where it fails for me:
 % brew upgrade homebrew-ffmpeg/ffmpeg/ffmpeg $(brew options homebrew-ffmpeg/ffmpeg/ffmpeg | grep -vE '\s' | grep -- '--with-' | grep -vi chromaprint | tr '\n' ' ')
==> Upgrading 1 outdated package:
homebrew-ffmpeg/ffmpeg/ffmpeg 4.4.1_5 -> 5.0-with-options
==> Downloading https://ffmpeg.org/releases/ffmpeg-5.0.tar.xz
Already downloaded: /Users/christoph/Library/Caches/Homebrew/downloads/ca7feb8ffc2f64941a9c9099ede3d74293119b7d8eed5772e7024fc1cebc250e--ffmpeg-5.0.tar.xz
==> Upgrading homebrew-ffmpeg/ffmpeg/ffmpeg
  4.4.1_5 -> 5.0-with-opti
==> ./configure --prefix=/opt/homebrew/Cellar/ffmpeg/5.0-with-options --enable-s
==> make install
Last 15 lines from /Users/christoph/Library/Logs/Homebrew/ffmpeg/02.make:
                    ^
/Library/Developer/CommandLineTools/SDKs/MacOSX12.sdk/usr/include/c++/v1/atomic:1860:21: error: unknown type name 'ptrdiff_t'
    _Tp* operator+=(ptrdiff_t __op) _NOEXCEPT          {return fetch_add(__op) + __op;}
                    ^
/Library/Developer/CommandLineTools/SDKs/MacOSX12.sdk/usr/include/c++/v1/atomic:1862:21: error: unknown type name 'ptrdiff_t'
    _Tp* operator-=(ptrdiff_t __op) volatile _NOEXCEPT {return fetch_sub(__op) - __op;}
                    ^
/Library/Developer/CommandLineTools/SDKs/MacOSX12.sdk/usr/include/c++/v1/atomic:1864:21: error: unknown type name 'ptrdiff_t'
    _Tp* operator-=(ptrdiff_t __op) _NOEXCEPT          {return fetch_sub(__op) - __op;}
                    ^
fatal error: too many errors emitted, stopping now [-ferror-limit=]
20 errors generated.
make: *** [libavdevice/decklink_enc.o] Error 1
20 errors generated.
make: *** [libavdevice/decklink_dec.o] Error 1

If reporting this issue please do so at (not Homebrew/brew or Homebrew/core):
  https://github.com/homebrew-ffmpeg/homebrew-ffmpeg/issues

These open issues may also help:
FFmpeg with decklink support installation failure https://github.com/homebrew-ffmpeg/homebrew-ffmpeg/issues/92
Brewing custom ffmpeg but failure at metal execution https://github.com/homebrew-ffmpeg/homebrew-ffmpeg/issues/96
opencv not working after homebrew-ffmpeg installation https://github.com/homebrew-ffmpeg/homebrew-ffmpeg/issues/93

 ~ %

I have looked at the other github issues that are mentioned but none of them helped me fix this.

This hack is unnecessary since auto-editor now ships with the proper FFmpeg.

OK, good to know. The reason  I thought this is still relevant is that when I try to run auto-editor /some/mp4/file --export_to_final_cut_pro it complains that ffmpeg could not be found (even though it is installed). I can run it from the same command prompt without problems. What's going wrong?


use El in yesvelte.com/docs page

these dots should not be visible

@pournasserian this problem is created because of using tabler.min.css instead of tabler.css for docs site


Update readme.mb, add SSM and Custom domain to s3 and cloudtrail.

Added an option to use SSM in s3 and cloudtrail integration
Added an option to use custom domain for coralogix.
Update the readme.md so that it will be adjusted to the changes.

@guyrenny
Per Terraform Publishing guidelines, we should leave the README.md file populated with the input values example, you can revert the readme.md update and it make sure to update it with your SSM related changes.


Facebook Sharing Preview

Hello,
When I try to share a blog entry on Facebook, instead of a preview of the blog entry, this is what I got it.

Any help ?

Thanks for the reporting this issue @Mobiller!
This is strange! This shouldn't happen! Are you sure FB is getting the right page. It looks like you blocked the United States with the "Country Blocker" tool, so FB see the banned message page https://github.com/pH7Software/pH7-Social-Dating-CMS/blob/master/_protected/app/system/global/views/base/tpl/other/msg.html.php#L19-L20
https://unfurls.co/

You blocked the "United States", right? The Facebook server that fetches the websites has probably a US IP address. That's why when it was fetching your website, FB wasn't able to access to your website, because it was blocked.


How to use it with BG Renderer Max which is an AE plugin?

About BG Render Max more details: Click here
I recognized that nexrender is based on 'aerender' tool from AE, I'm not sure whether nexrender works well with BG Render Max? Please give me some advice, thanks!

Not sure, haven't seen BG Render Max before. Do you know backend does it rely on?


stacking-rules-demo

Codecov Report

Merging #1 (08a9c80) into stacking-rules (cec9a1e) will not change coverage.
The diff coverage is n/a.

@@               Coverage Diff               @@
##           stacking-rules       #1   +/-   ##
===============================================
  Coverage           65.89%   65.89%
===============================================
  Files                  24       24
  Lines                2551     2551
===============================================
  Hits                 1681     1681
  Misses                870      870

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Settings GUI should not modify setting when selecting same option

VSCode Version: 1.24
OS Version: Windows 10

Steps to Reproduce:

modify a number or dropdown option
if number (let's say 300): erase the last 0 and put the last 0 back in, so it is 300 again
if dropdown: click on the dropdown and then click out without selecting anything
Setting shows as modified despite not being changed

Does this issue occur when all extensions are disabled?: N/A - not related to any extension

The interesting thing is, changing a setting to its default value could actually have a side effect. If you are changing a setting in the workspace or folder scope, it could override the setting in the user scope, if it's modified in the user scope.
I think this is an important concept but is confusing. We could simplify it by saying that when a setting is set to the default value, it becomes not-modified (AKA, is removed from the settings.json). Overriding settings in other scopes can be considered an "advanced" scenarios, and power users can use the old editor for that.
We could also extend this to check whether a setting is configured differently in another scope, and if so, in that case we keep the current behavior.


nothing happens after login

I'm using the capacitor adapter. I initialize the Keycloak instance the same way as the example. When I hit the login button, the in-app browser opens and I login, however the onAuthSuccess method does not do anything . Also, when I try to get the userInfo and the sessionId I get undefined values. Why is this happening?

I've created an example Angular project: https://github.com/JohannesBauer97/keycloak-ionic/tree/main/examples
This one works, probably you're missing sth in your implementation. I would need code from your implementation to help.


Minor retargeting changes

This makes some straightforward changes to help MIDebugEngine and MICore run on Core without affecting compatibility with 4.5.

Hi @chlowell, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

It looks like you're a Microsoft contributor (Charles Lowell). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;

:+1:

Hey guys this PR build didn't pass.


julius: 1.5.1 -> 1.6.0

Motivation for this change
Version update
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 109548 run on x86_64-darwin 1

1 package marked as broken and skipped:

julius

Result of nixpkgs-review pr 109548 run on x86_64-darwin 1

1 package marked as broken and skipped:

julius

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 109548 run on x86_64-linux 1

1 package built:

julius

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 109548 run on x86_64-linux 1

1 package built:

julius


TODO - replace with a variable

Installed product versions

Visual Studio: [example 2015 Professional]
This extension: [example 1.8.0]

Description
COnstructor - parameter "TODO" instead of integer
Steps to recreate
Class with constructor with integer
Ctor(Interface service, int ala)
Current behavior
putting "TODO" instead of a typed variable, like integer
Expected behavior
variable of correct type

That's by design. I wanted to make sure that it forced you to put something sensical in there, rather than throw in a default value that might be wrong.


Handling email links across the site

mailto<EMAIL_ADDRESS>link
mailto<EMAIL_ADDRESS>link

@emanelfy do we mean in addition? (I like that! 😃) so long as we're not obscuring the destination. I think Hillary had shared something similar from Adam Silver's blog: The trouble with mailto email links and what to do instead. Eventually, building out a structured contact form might be a solution we explore in the upcoming phase of work?

One thing to consider is that with two email addresses it could get confusing..

.

About page
EN: You can reach out to us by<EMAIL_ADDRESS>at<EMAIL_ADDRESS>FR: Vous pouvez contacter notre équipe par<EMAIL_ADDRESS>à l'adresse suivante<EMAIL_ADDRESS>Contact us page
EN: To inquire about partnering with us and get coaching and advice, you can [email<EMAIL_ADDRESS>at<EMAIL_ADDRESS>FR: Pour en savoir plus sur les possibilités de partenariat et pour obtenir de l’encadrement et des conseils, veuillez communiquer avec nous par<EMAIL_ADDRESS>à l'adresse suivante<EMAIL_ADDRESS>

Similarly, we may want to consider how the underline styling works in tandem with another nearby link. It might be perceived as a broken link by the user here on the About page? Perhaps bolding would be a more effective tactic?

We may want to adjust our approach to email links across the site.
We are also still using mailto links on the privacy page/terms and conditions for ATIP and the Privacy Commissioner etc.

*This scales across the product

@emanelfy @dylanzheng94 tried to make the change above in Contentful and put a mailto link for email and bold the email address itself, but it just links back to the homepage... Do mail-to links require other coding interventions outside the CMS?

Decision in interim: remove hyperlink for now, bold email address.
Change applied to following pages:

Contact
About
Privacy
Terms

Still need to check: Homepage

Blocked by #195

Blocking issue #195 was never prioritized, therefore this issue can not have resolution. Today service is winding down. As a consequence, closing this issue without resolution .


Use C++ range iterators for Lists in many situations

With #50284, we now have range iterators. This PR uses them throughout the codebase for List. This PR doesn't replace every single usage of List<>::Element, but it does replace many of them.
It's likely that I made some mistakes, but it would be like finding a needle in a haystack simply because this PR is so big. 99% of this should be good. This took a lot longer than I expected.

I think part of this refactor should be removing the temporary lists.  Yes it's nice to move the actual iterator to a range, but we should remove these temporary lists too.  .get_key_list(&keys) is an easy target. The internals of get_key_list(&List) requires a round trip to malloc/free and back for every key.    If we can iterate dictionaries with KeyPair references, we should be able to eliminate all of these.

TBH, the API (c++ side) for getting a collection of keys from a map shouldn't even be exposed IMO.  Iterators should be enough, and if you really need a copy of the keys, it's easy to construct from iterator.  If it really must be exposed it should maybe be Vector<String> get_keys() const;.  The compiler will move or (copy elicit) the Vector.  There's not much reason to pass a reference argument for output in modern c++ these days.
But I honestly wouldn't even include it because it'll encourage it's use over the cost-free iterator.  This will bring the codebase inline with other template collections like stdlib stl.
Thoughts @reduz ?   Also MUCH appreciation for implementing range iterators.  I have huge respect for anyone who takes criticism well.  Sometimes I think OSS maintainers have the thickest skin

@jordo The idea is there, but the plan is to do one thing at a time. The first step is to remove all usages of the Element syntax across the codebase. Once that has been accomplished, the next step is to migrate the codebase to more efficient data types depending on usage.

Haven't done a thorough review but at a glance it looks good, and seems to compile.
There's still all this now badly names E and F local variables that will need to be renamed to more sensible names at some point... and that's going to be super tedious as it's not something that can be easily automated... But that's for another PR.
From a quick local compile test, I seem to run into an issue where I can't run projects:
Running: /home/akien/Projects/godot/godot.git/bin/godot.linuxbsd.tools.64 --path /home/akien/Test4.0 --remote-debug tcp://<IP_ADDRESS>:6007 --allow_focus_steal_pid 247548 --position 448,240
Error: Can't run project: no main scene defined.
ERROR: Condition "int32_t(p_level) != level" is true.
   at: deinitialize_extensions (core/extension/native_extension_manager.cpp:101)

Project settings seem to be bogus:

Thanks!


Decimal literal magnitude and precision not constrained to CQL spec limits

Currently one can select Decimal values via Decimal literals with any precision, despite the CQL section 3.4.1 System-Defined Types saying the type's step size is 10^-8.
Run the following:
define DecimalTenStep:   0.0000001
define DecimalOneStep:   0.00000001
define DecimalTenthStep: 0.000000001

Its actual result:
>> DecimalTenStep [1:1] 1E-7
>> DecimalOneStep [2:1] 1E-8
>> DecimalTenthStep [3:1] 1E-9

What we expect is that DecimalTenthStep would either produce an error citing a literal using more precision than the step size, or else DecimalTenthStep would evaluate to the nearest value by rounding that is an even multiple of the step size.

Similarly, one can currently select Decimal values via Decimal literals with any magnitude, despite the same section of the CQL spec saying the type's range is -10^28 – 10^-8..10^28 – 10^-8.
All 4 of the following CQL statements will evaluate and produce results, but we expect only the first two would succeed and the second two would raise an error of having too great a magnitude.
define x1:<PHONE_NUMBER>999999999999999999.99999999
define x2: -9999999999999999999999999999.99999999
define y1:<PHONE_NUMBER>0000000000000000000.00000000
define y2:-10000000000000000000000000000.00000000

These constraint and/or rounding errors raised in this comment plus the initial issue are reflected in these failing test suite tests:

ValueLiteralsAndSelectors.xml -> Decimal -> DecimalTenthStep
ValueLiteralsAndSelectors.xml -> Decimal -> DecimalPosTenthStep
ValueLiteralsAndSelectors.xml -> Decimal -> DecimalNegTenthStep
ValueLiteralsAndSelectors.xml -> Decimal -> Decimal10Pow28
ValueLiteralsAndSelectors.xml -> Decimal -> DecimalPos10Pow28
ValueLiteralsAndSelectors.xml -> Decimal -> DecimalNeg10Pow28

For precision-based values, the sizes specified in the CQL specification are floors, not ceilings. So long as they behave consistently and correctly according to the operation semantics when dealing with precision, implementations are free to use greater precision than required by the specification.


[New port] Added Sciter.JS port (version <IP_ADDRESS>)

Describe the pull request

What does your PR fix?
Add new Sciter.JS port (https://github.com/c-smile/sciter-js-sdk)

Which triplets are supported/not supported?

Yes

If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/

I'm sorry about the lengthy osx rebuild, I messed that up in our builds :(

/azp run

Finally OSX build ended 😅

Finally OSX build ended 😅

Yeah I accidentally deleted the Azure Storage account where all the caches were stored for the osx fleet 😳

@BillyONeal ,Could you please help review this pr?

@VuYeK ，Could you please clarify the review comments above

@VuYeK ，Could you please clarify the review comments above

Done.

@BillyONeal ,Could you please help review this pr?

Because this conflicts with an existing sciter port, I don't think we can list it in the vcpkg catalog. Consider creating a community registry to contain the port at which you can point your customers.
See #17161 for other community registries.
(Sorry for not noticing this conflict before I was just about to push the approve button :( )

I don't understand why, subdirectory completely solves this problem and allows to have both version installed together. It'll be very disappointing if "older" version will block possibility to use new one. I could "update" the 'sciter' port to 'sciter-js' but it isn't good idea because if someone has 'sciter' as dependency then his app will stop working after this update.
Following your way will cause that vcpkg won't ever have newer version of sciter and will stuck on old non-js version when support will end. Subdirectory allows existing both together.

The problem is that it breaks the contract vcpkg provides to its users -- the way vcpkg avoids needing to have the cross product of build system integrations between ports and users is this "virtual system root" installed tree approach. Binaries must be in bin or integrations downstream won't work. For example, if someone had both ports installed, it is likely they would get the sciter DLL even though they intended to use sciter-js (which would probably explode at runtime).

Following your way will cause that vcpkg won't ever have newer version of sciter and will stuck on old non-js version when support will end. Subdirectory allows existing both together.

That seems unlikely; the same DLL name means that they cannot be deployed together. We can add a new port and skip the old one in CI, but would only want to do that if this is a complete replacement for the old one and not a fork or something like that.
I think the options are one of the following:

If this is a new / complete replacement for the older port, the older port should be updated to point to this. Users who want the previous thing can pin to it with versioning. Alternatively, we could make the old port print warning messages that it is deprecated in favor of this one, and stop testing that one in CI to resolve the conflict.
If this is a fork / intended to compete with the other port, then the right behavior is to put it into a community registry as described earlier, and for users to access it with overlays.

@VuYeK, have you considered BillyONEal’s comments

@JonLiu1993 I followed with first @BillyONeal option with deprecating sciter and using sciter-js as replacement. I have removed binary subdirectory and everything is building and working properly.
I don't understand what is wrong in this "PR Suggestions / build (pull_request)" check - details don't tell me what is a problem. In my opinion now it's correct.

I don't understand what is wrong in this "PR Suggestions / build (pull_request)" check - details don't tell me what is a problem.

Yeah, sorry about that. That was fixed in https://github.com/microsoft/vcpkg/pull/20236

I followed with first @BillyONeal option with deprecating sciter and using sciter-js as replacement.

Is it truly a complete replacement for the other project? Looking at the upstream libraries it doesn't seem so, they are both edited very recently.
@pravic it looks like you added the sciter port, do you have comments?

They are different libraries (they use different scripting languages), both are supported. So yeah, makes sense to have two ports.

They are different libraries (they use different scripting languages), both are supported. So yeah, makes sense to have two ports.
But makes no sense to replace the original library with this one. Either have two ports, or two features (which would choose which library to install), or the old library can be renamed to something like sciter-tis.
Well, there's a potential conflict in dll names and in include folders (though they can be patched to use different folder names).

@pravic that was my first version of this PR with sciter-js dll in subdirectory to avoid dll name conflict but @BillyONeal wrote that bin directory cannot have subdirectories... So I followed with his suggestion to deprecate sciter and use this as replacement - people who want to use sciter port can just use previous version.
Look here: https://sciter.com/sciter-js-is-the-mainstream-primary-version-of-sciter/ there won't be new features for old sciter port, probably only some patches/bug fixes.

@BillyONeal wrote that bin directory cannot have subdirectories..

Yes, that's true.

So I followed with his suggestion to deprecate sciter and use this as replacement

My suggestion had this caveat though:

If this is a new / complete replacement for the older port

as in, if Sciter is no longer maintained and the new Sciter is Sciter-JS. (There are often cases where a fork of a project takes over and becomes the new defacto standard for providing a service, for example what happened with OpenOffice -> LibreOffice)

... So I followed with his suggestion to deprecate sciter and use this as replacement - people who want to use sciter port can just use previous version.

Yes but a previous port can't be updated to the latest sciter version.

Look here: https://sciter.com/sciter-js-is-the-mainstream-primary-version-of-sciter/ there won't be new features for old sciter port, probably only some patches/bug fixes.
But there will be new versions - and there are, if we look at the repository.

Well, it's controversial now. How about a single port with mutually exclusive features to select which build to install?
For a single user, most likely he won't need two libraries simultaneously - while been a drop in replacement (headers and dll names are the same) the scripting languages are different and not compatible.

@BillyONeal I generally agree with you but in my opinion much better option is to have newer version of library (sciter-js) which is in active developemnt (not only fixes/security - https://sciter.com/sciter-js-is-the-mainstream-primary-version-of-sciter/) in main repository and use separate registry to update old (sciter) version if somebody will want to do that. Users can still use all versions which already was added to vcpkg so noone will be affected.
In other way (sciter-js in separate registry) developers cannot start new project with newest version of library without complications which for me doesn't make a sense. Especially when it is described in provided link - "Please consider Sciter.JS if you are starting new project."

Can we ask upstream to consider naming the relevant bits sciter-js instead of stomping on the same names?

What relevant bits?

Well, API and ABI of the dll are exactly the same. Only scripts are different. But I agree though.

There are no functions in the DLL that look at those scripts? I'm not sure I understand.

Exactly. There's, say, "call_function(name, args)" - it doesn't matter in which script language that function is written. Sciter loads an html file and renders it.
Like, InternetExplorer used to support multiple scripting languages as well (for example, https://perlhelp.web.cern.ch/Components/Windows/PerlScript.html)

@BillyONeal so what is your conclusion?

I still don't understand. If it is literally the same library then what is the actual change between the versions? Presumably in Sciter there's a TIS interpreter in the DLL but in Sciter.JS there's a JS interpreter in the DLL?
If you want the JS one to take over as a "replacement" then I think someone needs to sign up to run the registry where the TIS one lives, otherwise our response has to be "sorry, that name is already taken".

@VuYeK ,Could you please clarify the question?
https://github.com/microsoft/vcpkg/pull/18951#issuecomment-943724778

@VuYeK ,Could you please clarify the question? #18951 (comment)

Ok, I have created registry with old TIS version like @BillyONeal wanted to: https://github.com/VuYeK/vcpkg-registry. Additionally I've updated sciter-js version in PR to <IP_ADDRESS>. Can we finally merge and close this request?

Thanks @VuYeK for your continued work here and sorry for the difficult situation that upstream has put us all in.
I have two changes that are needed before this is mergeable: first, sciter-js is not a replacement for sciter and thus we should not implicitly install it. Second, we need to explain to users what the situation is and make them aware of their options.
sciter will also need to be added to ci.baseline.txt as failing on all platforms.
Once these changes have been made, this PR will be ready to merge.

Ok, all changes has been applied :D

Thanks everyone!

Is there an example on how to use this package from a CMakeLists.txt POV? I was expecting to find a FindSciterJS.cmake file somewhere but there's none. Is it possible to find SciterJS dependencies through find_package?


Reverts ACME issuer from forming a chain bundle and populating the ca.crt

This PR reverts the ACME CR controller changes in https://github.com/jetstack/cert-manager/pull/3984/files
Though I have tested that with the changes made above, ingress controllers like NGINX still work correctly, I'm not confident that we are breaking someone somewhere silently.
REVERTS: The ACME issuer now constructs a certificate chain after signing, and populates the CertificateRequest.Status.CA with the root most certificate if available.

/assign @jakexks

/approve
/lgtm

/kind bug


[BUG] race condition on uninstall

Describe the bug
Uninstall fails to remove the var directory because the state file may be updated asynchronously by a background task during uninstall. Leaving behind a .lock file, which prevents the var directory from being removed.
To Reproduce
~/Projects/deref/exo (main) $ exo uninstall
destroying workspace: k6z3kyjcg1e885z1xzefhpzkk0
destroying workspace: 93d77y9771tzfw8bt8gfs05xjm
destroying workspace: 9vhb0tfazdfmcfw6eb67d3esr8
removing home directory: /Users/brandonbloom/.exo
Error: removing exo directory: unlinkat /Users/brandonbloom/.exo/var: directory not empty
removing exo directory: unlinkat /Users/brandonbloom/.exo/var: directory not empty

~/Projects/deref/exo (main) $ ls /Users/brandonbloom/.exo/var
state.json.lock

Expected behavior
All async tasks should be stopped before uninstall proceeds, so this should be impossible.

More generally, there are some issues with shutdown paths. exo exit shuts down the daemon, but doesn't stop supervised processes. Is that OK? Meanwhile, exo workspace destroy does stop processes, but potentially fails & then there is no obvious way to cleanup. More thought & various improvements are needed.


CFG modification limit reached. attached the file. bug Core #2300

Describe your idea
???

#2300 fixed


HttpClient instances that include access tokens

In the Visual Studio Blazor WebAssembly App the template includes the following code in the Program.cs file.
// Supply HttpClient instances that include access tokens when making requests to the server project
builder.Services.AddTransient(sp => sp.GetRequiredService<IHttpClientFactory>().CreateClient("BlazorApp3.ServerAPI"));

Is it your intention to do the same thing in the tutorial?

Hi @ToiWright. I was planning to update the workshop this weekend to use strongly typed clients with an HttpClient that has been preconfigued with the new BaseAddressAuthorizationgMessageHandler.


ionList does not have rubber band scrolling

I am using the ionList as shown in the example
{{#ionView}}
    {{#ionContent}}
      {{#ionList}}
        {{#each contacts}}
          {{#ionItem path="contacts.show" buttonRight=true avatar=true class="item-icon-right"}}
            <img src="{{avatarUrl}}">
            {{name.first}} {{name.last}}
            {{> ionIcon icon="ios-arrow-forward" class="positive"}}
          {{/ionItem}}
        {{/each}}
      {{/ionList}}
    {{/ionContent}}
  {{/ionView}}

Compare
http://meteoric-contacts.meteor.com/
with the list on the ionic site:
http://ionicframework.com/docs/api/directive/ionList/
The list bounces back when you scroll to the top
Can we get rubber band scrolling with ionList?

It has rubber band scrolling when running on the device, it's not needed or desirable on the desktop.

Ah this is true, rubber band scrolling works on the device. thank you.


fix: hack for Gradle 5 + signed artifacts + gradle-bintray-plugin 1.8.4

WARNING: since the Groovy Gradle API is modified, this breaks build
isolation when sharing a common Gradle daemon instance.
This hack works because gradle-bintray-plugin is using Groovy dynamic
compilation (i.e. compiled in Groovy without @CompileStatic) hence it is
affected by Groovy runtime meta-programming.
Tested with: Gradle 5.6.3 / gradle-bintray-plugin 1.8.4
asciidoctor/asciidoctorj#861
bintray/gradle-bintray-plugin#300

Thanks a log! 🎉


fix two bugs for mips64le

Signed-off-by: wanghuaiqing<EMAIL_ADDRESS>

@tonistiigi PTAL

@tonistiigi could we merge this commit to master branch?


No visualisation with Denoise

Hi.
No progress visualisation in 'it' when Denoise is switched on.
But if i switch Denoise off - i can see rendering progress in 'it'.

Yes this is a limitation. The issue is that the Denise data has to be written to a separate file which kills interactivity to it. It's really meant to be used for final renders

Ok. Close it.


[bug] Server fails violently if config not present

If the file config.properties does not exist as expected (e.g., different name), you can still start the application. However, when trying to register, you get the message that the e-mail is already taken (even if it's not - in my case, the cs_select database wasn't even created) and tomcat crashes completely (closes it's window, so you need to be fast to even copy the error messages). An understandable error message in the browser (and no tomcat crash) would be nice.

Changed the configuration so it throws an exception when an error occurs while reading the config file. Can now be caught and send an error message to the user on the frontend @bendixsonnenberg.
Referring to branch configurationException

Fixed with #130


No script named 'tensorboard'

after collecting logs, run command tensorboard --logdir=logs/, get error below:
Traceback (most recent call last):
  File "/bin/tensorboard", line 4, in <module>
    __import__('pkg_resources').run_script('tensorboard', 'tensorboard')
  File "../lib/python2.7/site-packages/pkg_resources/__init__.py", line 739, in run_script
    self.require(requires)[0].run_script(script_name, ns)
  File "../lib/python2.7/site-packages/pkg_resources/__init__.py", line 1486, in run_script
    raise ResolutionError("No script named %r" % script_name)
pkg_resources.ResolutionError: No script named 'tensorboard'

directly run command lib/python2.7/site-packages/tensorboard/tensorboard, it works.

What's the output of which tensorboard, seems I've met this before, if the tensorboard binary exists, then the problem is the corresponding file path.
Could you help enhancing the script by create a PR after we solve these issues? Thank you!

Open the tensorboard binary using vim or PyCharm, you might find:
PYTHON_BINARY = '/Users/zihao.zzh/anaconda2/envs/tensorboard/bin/python'

The path should be same as the one in tensorflow/tools/python_bin_path.sh, and your default Python path.