Need to support real template usage

Let me give you an example:

    {% if "name" === "blahblah" %}

      <input type="text" name="name" value={{name}}>

    {% end %}

if init[name] == "blahblah"should render to

    {% if "name" === "blahblah" %}

      <input type="text" name="name" value="blahblah">

    {% end %}

and if not then it should render to

if you can make ``` ``` to work instead of {% %} that's fine but whatever works it needs to support this.

I made this package for my small project, so I didn’t mean to make a compelete template engine.
But, I’ll try to make this package more useful because there is other people who use it.
I think it’ll take at least one day, please wait.

I understand. 👍 You don't have to support {% %} or {{ }} but to make a template you do need some way to allowing {% if xxx=xxx %} something using {{ xxx }}  {% end %}. Otherwise, the use case of template language is very limited.

I finish implementing basic template usage(like {%%}). documentation hasn't been updated, but the syntax is simple.
When the template is
#HTML Template File

    <title>MyPage</title>

        {% if name=="julia" %}
        The current time is
        ```
        using Dates
        now()
        ```

        {% end %}
        {% for i in 1 : 10 %}
        Hello Julia
        {% end %}

the output will be(init=Dict("name"=>"julia"))
#HTML Template File

    <title>MyPage</title>

        The current time is
        2023-05-03T23:02:59.753

        Hello Julia

        Hello Julia

        Hello Julia

        Hello Julia

        Hello Julia

        Hello Julia

        Hello Julia

        Hello Julia

        Hello Julia

        Hello Julia

As you can see, I can't do things like removing extra spaces yet. Moreover, I've already found the fatal bug that variables don't work properly in for statement.
But, don't worry, solution for these problems has already been found and I'll fix when I have a enough time.
I'll temporarily release if the PR in General repository is merged.

I fixed bugs and made docs. please check the docs.

Are you going to release the new version? The current released version in the registry is still v0.1.3.

It looks like your new username is merged. Please release this.

Don't forget to update your new version to v0.1.4 or v.0.2.0 or whatever.

I think support for real template usage has done. If you have more idea to improve this package, please open a new issue.


Mini Player keeps zooming in and resizing to view bounds

Checklist:

[x] I have checked that there are no issues with similar or the same content
YOU SHOULD CHECK CLOSED ISSUES ASWELL

[x] I have checked the FAQ (https://github.com/MarshallOfSound/Google-Play-Music-Desktop-Player-UNOFFICIAL-/wiki/FAQ) and the answer I am looking for is not there

[x] I have double checked and can reproduce the issue

OS:
Win 10 Version 2004
GPMDP Version:
4.7.1
Issue Descriptions:
The mini player window keeps growing and zooming in continuously till it fills the screen and no button to go back to full UI. Have to exit and restart the app.
Screenshot:
[https://i.imgur.com/vbi4sJB.png](took while the window is growing)
Steps to Reproduce:
Click the small (gray) mini-player button in full ui

I have same/similar issue where the window keeps growing and, within the window, the UI elements keep getting bigger
My main monitor (A) is 3440x1440 and laptop (B) is 1920x1080p.
If I move the app from A->B when in small player mode I get this 'growing window' behavior every time.
This is actually seems like a re-emerging bug as I remember a couple years ago gpdmdp had the same issue.

I'm also facing this exact issue when my second monitor. Primary monitor, no issues. But when moved to second monitor, expands even whilst dragging the mini player.

I get this with just the mini player, but not the main player. I only have one screen.
It also walks "down" the screen until it hits the bottom, at which point it sits there and "wobbles" (shrinking & growing by one or two pixels in each dimension) and keeps growing for a bit, until it hits some magic size at which point it keeps wobbling most of the time, but stops getting persistently bigger. Sometimes it will also stop wobbling. If I move it off the bottom edge of the screen, the walking & wobbling resume.
Linux GNOME on X11 with font scaling set to 125%.


test: add module function call test

Co-authored-by: warren2k<EMAIL_ADDRESS>

Closing due to failed checks and noticed problem when only running nix flake check not cargo test


⚠ Beamable Beamo (Basic) has degraded performance

In c60cb51, Beamable Beamo (Basic) (https://api.beamable.com/basic/beamo/platform/docs) experienced degraded performance:

HTTP code: 504
Response time: 10022 ms

Resolved: Beamable Beamo (Basic) performance has improved in 8980858 after 18 minutes.


Add \f examples printf in devices controllers

This PR adds examples of using printf("\f"); to clear the console and have a better, more readable output in the Webots console.

test me

Build Passed :ok_hand:
You can safely merge 'fix-add-antislash-f-example-printf-in-devices-controllers' into 'revision'.

👍

:eyes:


Add reader for PostgreSQL Databases

Hey all,
I have:

Added a reader to connect and query PostgreSQL Databases.
Included an example (.py file) of how to connect and query a database correctly.
Updated the docs with the additional PostgreSQL option.

Best,
Kevin Saltarelli

thanks for doing this @kevinqz! any chance you could take a look at using the SQLDatabase class instead? https://gpt-index.readthedocs.io/en/latest/reference/struct_store.html - this is already used for our SQL index, and we could use it as a reader too (SQLAlchemy should allow for connecting to most structured databases including postgres)

Hi, @jerryjliu! Just added another commit in which I've:

Added a DatabaseReader to connect to and query SQL Databases by using SQLAlchemy and the SQLDatabase class.
Included an example (now with a Jupyter Notebook .ipynb file).
Updated the docs with the additional DatabaseReader option.

Tried a few tests here and everything should be fine to go. Feel free to let me know if anything.

I see your point, @jerryjliu! I've made some changes:

Made changes in the way to instantiate the DatabaseReader class. Inherited it as a BaseReader and added an instance variable called sql_database of the SQLDatabase class. Please let me know if I understood and implemented your points correctly.
Also added the ability to start from an existing (SQLAlchemy) Engine - not sure if this is something excessive or necessary, please let me know your opinion.
Removed 2 old files (related to PostgreSQL only).
Added examples of how to instantiate the DatabaseReader class from sql_database (SQLDatabase), an engine (Engine), and an uri (string) in the DatabaseReaderDemo.ipynb file.

Feel free to let me know if I correctly addressed your points, ok? Still new to this whole area. :)

I see your point, @jerryjliu! I've made some changes:

Made changes in the way to instantiate the DatabaseReader class. Inherited it as a BaseReader and added an instance variable called sql_database of the SQLDatabase class. Please let me know if I understood and implemented your points correctly.
Also added the ability to start from an existing (SQLAlchemy) Engine - not sure if this is something excessive or necessary, please let me know your opinion.
Removed 2 old files (related to PostgreSQL only).
Added examples of how to instantiate the DatabaseReader class from sql_database (SQLDatabase), an engine (Engine), and an uri (string) in the DatabaseReaderDemo.ipynb file.

Feel free to let me know if I correctly addressed your points, ok? Still new to this whole area. :)

nice, this is a lot better! could you remove the old files? there's TestDatabaseReader.ipynb, TestPostgresReader, and postgresql.py which can be removed

@jerryjliu, done! Let me know if I did it correctly this time. 😅


Safely passing a mutable reference to Python?

I have a feeling I'm not alone in wanting to pass a mutable Rust reference to Python code. In my case, I want Python code to draw into a Piet RenderContext. There is basically no reasonable way to do this without a mutable reference, for example by copying data.
Having read through the code and some blogs on the issue, I believe I may have a workable answer. Probably easiest to post my code:
https://gist.github.com/raphlinus/479df97a7ba715b494b87af9071e9b87
The short explanation is that the PyCell holds a RefCell to an optional mutable reference. There's also a guard object which clears that reference when the guard is dropped. There is a small amount of unsafe, but it's only to adjust lifetimes; I'm not mucking with raw pointers at all (as I had done in a previous iteration). In particular, I'm relying on RefCell for mutability guarantees, so I'm not particularly worried about that.
I post this issue mostly to ask for review that the approach is sound. It's also possible there's some easier way to do this I'm missing. If it is a good approach, likely it should be documented, as it seems like something a lot of people want to do.
Many thanks for your consideration!

Any time your depending on Drop being run on some guard for safety, it's trivial to show that your API design is not safe: just mem::forget the guard, which is a safe operation.

Right, I should have figured that out, thanks for the reminder. What about a scoped API, where I pass the &PyCell to a closure? I'll explore it in any case.

that could work, see rayon::scope for a similar scoped API.

The gist has been updated, the second file is my attempt at a scoped version. It feels like it might be possible to refine further, but I'm very interested in feedback on whether it's on the right track.

Thank you!
After looking over the gist for some minutes, I think now I understand your idea.
Python and Rust have very different lifetime strategies: one is by reference count, one is by static lifetime analysis...
But we can enforce Rust's lifetime to Python objects, by doing obj = None when dropping.
This is a cool idea, but I'm still struggling to understand the context where this technique is usable.
To make this work, we need a scope StringRef::scoped or RAII guard.
So it is limited to 'Python in Rust code' usage, and then I think even Option can be unnecessary due to Python's single-threaded nature.
Do you intend only this usage?
Or do you plan to extend this to 'Rust object in Python code' situation?

Sure, I'm happy to explain the motivation behind it. We want to have a GUI app (our main use case right now is a font editor) where we also have plugins written in Python, and we want those plugins to draw onto a canvas.
That canvas is represented by a [`&mut RenderTarget](https://docs.rs/piet/0.1.0/piet/trait.RenderContext.html) object. In particular, the runloop of the GUI app generates a render target, then passes it into the `paint` method of various widgets. We want to be able to pass that into Python code. If the Python code were to retain the reference, for example stashing it into global state, then return, it would be a dangling reference that could exploit UB, most likely a crash. We want to prevent that. To be clear, we're willing to tolerate some unsafe patterns on the Rust side, though would want to keep that to a minimum. But we definitely want to make it difficult or impossible for people to crash the program on the Python side by such common errors as use-after-free, type errors such as passing an image where a gradient was expected, etc.
The type that I wrote is clunky for sure, with lots of options and two different flavors of refcell; I think it's likely it could be streamlined, but didn't clearly see how to do that.

Interesting application, thank you for the detailed explanation!
I'll do my best to give helpful reviews, but I'm sorry if I have some misunderstanding :)

Your Option approach looks good especially when you run the extension with some context, like:let extension_context = PyDict::new();
py.run(code, None, Some(extension_context)).unwrap(); // Run extension code with some context

In such cases, extension programs can set &mut RenderTarget anywhere by setting it to the globals, and thus restricting the period when it is really usable is necessary.
I'm kind of doubtful about the use of RefCell. Though you may already know, PyCell behaves like RefCell when it exposed to Python (see https://docs.rs/pyo3/0.12.0/pyo3/pycell/struct.PyCell.html). So just PyCell<Option<...>> could work, unless it is already managed as Rc<RefCell<...>> or so.
'static can be irritating but now I have no better way to deal with this.

Ah ok, I think I understand this better now. I agree that the RefCell can be removed, it doesn't add any additional safety.
It seems to me difficult to write a fully safe Rust wrapper for this pattern. The risk is that the &'static mut String reference (or any wrapper that holds this reference) may be moved out of the PyCell that contains it, as all types in Rust can be moved. (I found it helpful to review the documentation for the rental crate and the relatively new Pin api)
But I think we may have a situation that is good enough for our needs. We can have a relatively small amount of unsafe in our code, and then as we only use the reference in a way that respects the scope pattern, it should be safe from the Python side.
It seems maybe possible to express this pattern in a macro, so that all unsafe uses are hidden, but this is beyond my current scope.
I think there may be documentation value in writing about this pattern, what level of safety is possible, where unsafe is necessary, and what conditions must be maintained to ensure the soundness of the resulting system.

I've made another attempt at the problem, this time using pointers rather than trying to transmute the lifetimes of references. I believe it may address the safety issues of my previous version. Of course, as with all unsafe code, there's a very good chance I've missed something and there is a soundness hole.
Even so, I've tried to be reasonably careful. I did some sanity-checking with miri to establish that the basic pattern of "tunneling" the mutable reference through turning it into a pointer and then re-creating it later is valid. I've also added a py: Python<'p> guard to the borrow method to ensure that the GIL is held, as it would clearly be unsafe to call this method otherwise.
I've also this time improved the signature, so that it takes any T and not just String, and separated the creation of the Rust wrapper object from the Python class creation. Thus, the unsafe should be confined entirely to the safe wrapper itself (which I've put into a separate module to emphasize), and it should be possible to use this with essentially any inner type.

👍 I've been busy the past few days but lurking on this conversation; I was going to say that pointers are probably better than transmuting lifetimes. I'm keen to take a read of your most recent solution when I have a chance. Thanks for looking into this!

I withdraw that particular gist, there's an issue with a dangling pointer to the stack. I think it can be fixed with a bit of boxing.

Ok, fourth try. This one is based on Rc, and is considerably simpler; I realized the scope function doesn't really need access to the PyCell, so the somewhat terrifying signature is now much less so.
The allocation of the Rc is in service of making the wrapper movable. I can see how to eliminate it if there is an unsafe burden on the client of the API, but otherwise I'm not sure it's possible. The code generated for try_get_mut is well within reason, though one or two branches could be eliminated if the code were specialized: the weak count and strong count are both {0,1}.
I believe this version is worthy of review, but am not yet making the claim it's actually sound. Apologies for the previous false starts; unsafe code is hard.

The Weak pattern looks cool, especially when the internal mutable object is managed by Rc.
But somehow I feel it hard to understand why it is necessary even with scoped objects.
Or,

I withdraw that particular gist, there's an issue with a dangling pointer to the stack.

could you please explain this more?

Why is the Rc necessary? It's because I want to encapsulate just the concept of the safe wrapper of to the reference, and especially make it movable from the safe wrapper into completely arbitrary user code, most likely a constructor for a PyClass object that will embed the wrapped reference as a field.
If I were to tolerate an unsafe burden on the user of the wrapper, and wanted to avoid the Rc, then I would have some mechanism to zero out the wrapper at the end of the scope. But I don't see a clean way to enforce that: the callback of the scope function can take that wrapper and move it out of the scope.
The dangling pointer is a fairly straightforward issue. The obj_ptr_ptr value is a pointer to the obj_ptr variable on the stack frame of scope. That pointer is placed into the SafeWrapper function, whose lifetime can extend past scope itself (although it won't in normal usage). I did test it locally, and it seemed to work, but only because of the coincidence that the location was still zero.
The Rc solves these problems: the Weak container can be moved around freely, and if there is an attempt to access the inner pointer after the scope function has completed, then the attempt to downgrade will fail. The only downside is the extra allocation. For my particular application, I find this a completely acceptable tradeoff. We're not going to call scope very often, even though we might do many (hundreds or thousands) of drawing calls on the context object within that scope.
We don't need the full generality of Rc here, because we never actually clone the Rc. If we were going to make a custom implementation, it could be a Box of the pointer and a bool, all in an unsafe cell. The try_get_mut function would just check whether the pointer is null, and provide Some mutable reference if not; I believe this would compile down to no code, but haven't checked that in Godbolt yet. The beginning of scope would set the bool to false. The end of scope would zero the pointer in any case, and check the bool. If it's true, it would deallocate the box. The drop function on the wrapper would check whether the pointer was null. If so, it would deallocate the box. If not, it would set the bool to true (note that this is the normal case). This behavior is the same as Rc, just with less extra steps. I wouldn't expect a huge improvement in performance though, as the number of allocations is the same.
I hope this explanation is useful. Feel free to ask if there are more questions. Having slept on it, I am more confident that the approach is viable, but obviously would welcome careful review before expecting such a wrapper would be adopted, in case there's still a safety problem I've overlooked, or an opportunity to make it more efficient.

I don't think you even need Rc or Weak. Assuming I didn't mess up somewhere, the following should work:
#[pyclass]
pub struct MyMutRef {
    v: Option<NonNull<MyValue>>,
}

impl MyMutRef {
    pub fn get(&mut self) -> Option<&mut MyValue> {
        unsafe { self.v.as_mut().map(|v| v.as_mut()) }
    }
    pub fn scope<R>(py: Python<'_>, v: &mut MyValue, f: impl FnOnce(Python<'_>, &Py<MyMutRef>) -> PyResult<R>) -> PyResult<R> {
        struct PanicOnDrop(bool);
        impl Drop for PanicOnDrop {
            fn drop(&mut self) {
                if self.0 {
                    panic!("failed to clear correct MyMutRef instance"); // abort via double-panic
                }
            }
        }
        struct Guard<'py>(Python<'py>, Py<MyMutRef>, NonNull<MyValue>);
        impl Drop for Guard<'_> {
            fn drop(&mut self) {
                let panic_on_drop = PanicOnDrop(true);
                let guard = self.1.borrow_mut(self.0);
                assert_eq!(guard.v.take(), Some(self.2), "MyMutRef instance was moved somewhere else");
                panic_on_drop.0 = false;
            }
        }
        let guard = Guard(py, Py::new(py, MyMutRef { v: Some(v.into()) })?, v.into());
        f(py, &guard.1)
    }
}

I'll let others critique the above, but I should clearly state another goal: ideally I'd like a safety boundary so that I can add whatever methods I like to the #[pyclass] object, and those methods can't cause unsafety from safe code. If methods are added and the v field remains basically a raw pointer, I can see lots of things that can go wrong.

The use of Rc has a very subtle soundness hole: it can be moved into a context where Drop is not protected by a 'p lifetime ensuring the drop happens while the GIL is held.
Fortunately, this can be fixed with atomics. I've looked at the generated code in Godbolt and it's very nice, at least on x64. That said, this code feels like it's skating pretty close to the edge wrt soundness. I've written it so that if there is a race (which I believe will only happen when there's an intentional effort), then the box can leak. This is not a soundness issue and I consider it an acceptable consequence. If that were not desired, at the expense of slightly slower code, the atomic operation in the drop function could be replaced with a swap with Ordering::Release, which would compile to an xchg instruction.


Transition to find-bugs:sweep

Codecov Report

Merging #304 (b959934) into master (7c70d79) will increase coverage by 1.73%.
The diff coverage is 36.30%.

@@            Coverage Diff             @@
##           master     #304      +/-   ##
==========================================
+ Coverage   30.65%   32.39%   +1.73%
==========================================
  Files          55       58       +3
  Lines        5349     5476     +127
  Branches     1179     1183       +4
==========================================
+ Hits         1640     1774     +134
+ Misses       3608     3588      -20
- Partials      101      114      +13

Impacted Files
Coverage Δ

elliottlib/cli/__main__.py
0.00% <0.00%> (ø)

elliottlib/cli/attach_bugs_cli.py
0.00% <0.00%> (ø)

elliottlib/cli/create_placeholder_cli.py
0.00% <0.00%> (ø)

elliottlib/cli/create_textonly_cli.py
0.00% <0.00%> (ø)

elliottlib/cli/verify_attached_bugs_cli.py
0.00% <0.00%> (ø)

elliottlib/openshiftclient.py
0.00% <ø> (-14.64%)
:arrow_down:

elliottlib/tarball_sources.py
32.22% <ø> (ø)

elliottlib/util.py
39.13% <ø> (-1.70%)
:arrow_down:

elliottlib/errata.py
37.45% <16.66%> (+0.38%)
:arrow_up:

elliottlib/cli/attach_cve_flaws_cli.py
42.15% <28.57%> (+0.25%)
:arrow_up:

... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3917984...b959934. Read the comment docs.


Replace Ubuntu 18.04 with 20.04 in CI

Fix for #114

Pull Request Test Coverage Report for Build 0e46dac9bc9f709c009394495ab269f6e91cf6a8-PR-115

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 9daec85b08701ef27de8e6ef919bbca149fa6077:
0.0%

Covered Lines:
374

Relevant Lines:
374

💛  - Coveralls


Test select option on Categories page

Add tests for select option on Categories page

Codecov Report

Merging #64 (2d946e7) into master (25f3f69) will increase coverage by 3.55%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #64      +/-   ##
==========================================
+ Coverage   28.96%   32.51%   +3.55%
==========================================
  Files          36       36
  Lines         366      366
  Branches       73       73
==========================================
+ Hits          106      119      +13
+ Misses        239      227      -12
+ Partials       21       20       -1

Impacted Files
Coverage Δ

src/components/main/categories/DropDownOptions.js
100.00% <ø> (ø)

src/utils/generic-utils.js
35.61% <0.00%> (+5.47%)
:arrow_up:

src/components/main/categories/Categories.js
85.71% <0.00%> (+14.28%)
:arrow_up:

src/reducer/categoriesReducer.js
81.81% <0.00%> (+22.72%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25f3f69...2d946e7. Read the comment docs.


Add support for Azure Stack

Please add vFXT to the Azure Stack Marketplace as this would remove the need for separate hardware for existing Avere clusters in an on-premise environment. Both BYOL and on-demand pricing options should be made available.

@anhowe Does this mean Azure Stack is now officially supported as a backend for Azure FXT?


Making snappygrav work with data manager plugin with admin

I've got snappygrav working for user-facing pages just fine. I'm experiencing a few issues getting it to work for submitted data through the data manager plugin.
I've hacked and tried a few options and still have a few more options to explore, but I thought I'd see if you can suggest a simple/elegant solution. Seems it should be simple. Trying each option takes some time, especially since I am preferring to make changes to plugins that can be shared or integrated into plugin repos so that I don't make upgrading difficult for myself.
Ideally I'd like a "PDF download" link/button on the items listing page for each data "type". For now, I would settle for an "Export" button on the full data item page. I've tried simply adding {{snappgrav(page.route)}} into the item.html.twig template from the plugin, but I discovered that in the data manager plugin (perhaps all of admin), page.route is null. So this can't work unless I find another way to get the page's route.
For the link side, I added a method into the plugin class to simply give me a URL and serve it through snappy-manager. This worked but isn't the URL I wanted, and I get authentication and nonce errors when trying routes within the admin path. I don't quite understand how this plugin routes. Ideally I want the URL to be the same as the data item in data manager but with a .pdf extension.
I can see the data manager plugin code has something similar for CSV downloads (no docs or anything though) and I should be able to add PDF in the same way. That means hacking two plugins plus creating dependencies and I'm just not sure I (or repo owners) want to go into all that.
Be keen to hear your thoughts on achieving this. This capability would make snappygrav pretty powerful.

I have developed the plugin for users of a site, in fact, even if a few days, snappygrav is earlier.
At this moment I'm more interested in replacing the wkhtmltopdf library that creates too many problems regarding its update and its different versions related to different operating systems.
Actually I think to add two other libraries like tcpdf and mpdf: I do not want to disturb those who are comfortable with wkhtmltopdf.
Until today I had never thought about it, but never ever.

OK thanks, I mostly understand. I don't understand the following, it's just your English phrasing :)

in fact, even if a few days, snappygrav is earlier.

.. I had never thought about it, but never ever.

I have managed to achieve what I wanted by only modifying/hacking one plugin, Data Manager. I don't know how to make that into a patch that's useful for everybody though. For now, I will probably maintain a fork and rebase it regularly.
BTW when I figured out how to get the route for an Admin page (current_route), I put {{snappygrav(current_route)|raw}} in my data item template just to see what happens. I get "Invalid Security Token" when trying to create the PDF, so I think some conflict is happening within the Admin area with tokens and nonces. Possibly because snappy-manager is outside the Admin path. It's OK because I don't need this right now.
If you don't mind me providing some general feedback on your plugin .. it might be more generally useful and extendable if you create smaller methods that do less. For example, SnappyManager::runWk could be broken up into methods to:

determine the PDF creator executable path
get and set options
create and return an unencoded PDF, which is more flexible (or implement a method parameter to toggle whether the output is encoded).

And some of the methods, like this one, seem like they should be public, not protected. I just think if you provide more public methods doing smaller jobs, that the plugin will be more flexible and useful to others and perhaps hook in better with other plugins.
Hope that's helpful feedback. It's a great plugin. I would not have known where to start attempting to generate PDFs from form data if it didn't exist. Thanks for your work :)

Thanks for the great advice.
I explain the dark sentences: :-)

in fact, even if a few days, snappygrav is earlier.

When I wrote this plugin, there was not a data management plugin, so I was not thinking about this possibility.
Even when the data manager was published, I did not think about this, because some libraries already available also provide the output in pdf as dhtmlx.
I'm not saying that a data manager is useless: I do not need it.
Snappygrav was born as a personal need. I did it because it was not expected to be among the priorities of rhuk.

I had never thought about it, but never ever.

As a result, yesterday I did not know if and when I would do it.
However, today adopting your advice to create public monofunctional modules I will take into consideration the possibility of doing so.
You wrote:

Possibly because snappy-manager is outside the Admin path.

Exactly, it works outside the admin environment.
Certainly not enough to include the admin environment to make it work. The changes you suggest will be needed.
Thanks again for your useful feedback.

I have just published a new version that uses the replacement libraries of wkhtmltopdf: mPDF and TCPDF.
I also believe I have achieved what you have suggested.
For now it's a beta version.
Thanks again


[DEFECT] Input variables in Opt must always be present in SolutionExport

Thank you for the defect report

[X] I am using the latest version of RAVEN.
[X] I have read the Wiki.
[ ] I have created a minimum, reproducible example
that demonstrates the defect.

Defect Description
The optimization variables should always be present among the variables of the SolutionExport.
If this is not the case, the Optimizer crashes because the useRealization method tries to find a match of variables that do not exist in the list of variables belonging to the Dataobject.
Steps to Reproduce

Creation of a input case that uses GradientDescent, has a SolutionExport
From the  section of the SolutionExport remove input variables
Run

Expected Behavior
Better error handling informing me that a certain variable is not present in the list of variables of the SOlutionExport data object
Screenshots and Input Files

OS
MacOS
OS Version
No response
Dependency Manager
CONDA
For Change Control Board: Issue Review

[X] Is it tagged with a type: defect or task?
[X] Is it tagged with a priority: critical, normal or minor?
[X] If it will impact requirements or requirements tests, is it tagged with requirements?
[X] If it is a defect, can it cause wrong results for users? If so an email needs to be sent to the users.
[X] Is a rationale provided? (Such as explaining why the improvement is needed or why current code is wrong.)

For Change Control Board: Issue Closure

[x] If the issue is a defect, is the defect fixed?
[x] If the issue is a defect, is the defect tested for in the regression test system?  (If not explain why not.)
[x] If the issue can impact users, has an email to the users group been written (the email should specify if the defect impacts stable or master)?
[x] If the issue is a defect, does it impact the latest release branch? If yes, is there any issue tagged with release (create if needed)?
[x] If the issue is being closed without a pull request, has an explanation of why it is being closed been provided?

issue closure checklist is satisfied. Issue can be closed with PR #2040


⚠ AGEG website (prod) has degraded performance

In bb22ffd, AGEG website (prod) (https://www.ageg.ca/) experienced degraded performance:

HTTP code: 200
Response time: 1280 ms

Resolved: AGEG website (prod) performance has improved in b9a356e.


[RESOLVED] Interface eth0(): High error rate (>2 for 5m)

Problem started at 08:27:29 on 2023.05.26
Problem name: Interface eth0(): High error rate (>2 for 5m)
Host: S100-Primario
Severity: Warning
Operational data: errors in: 1, errors out: 0
Original problem ID: 22551
Event details in Zabbix: http://<IP_ADDRESS>/tr_events.php?triggerid=23483&eventid=22551

Problem has been resolved in 3m 0s at 08:30:29 on 2023.05.26
Problem name: Interface eth0(): High error rate (>2 for 5m)
Host: S100-Primario
Severity: Warning
Original problem ID: 22551


Docs: Add additional notes/warnings about using ZC on code playgrounds

Docs: Add additional notes/warnings about using ZeroClipboard on code playground sites.
Closes #586.
Does this satisfy your needs from #586, @dandv?  If you would prefer something slightly different, please let me know.

Looks great. Thanks!

@dandv: By the way, if you hadn't seen this section in the docs, this is the deeper explanation of what's going on with those playground sites:  docs/instructions.md#sandboxed-iframe-limitations


fix: Deletion of comments

Comments which deleted are not going to be appeared after showing the popover again and again

Fixes #212


Apollo with native macOS support

I would like Apollo with native macOS support.  Thanks!

I would like Apollo with native macOS support. Thanks!

You mean running Apollo directly on macOS, or just running Apollo Docker container on top of macOS?

I would like Apollo with native macOS support. Thanks!

You mean running Apollo directly on macOS, or just running Apollo Docker container on top of macOS?

For the latter, running Apollo Docker on macOS hosts was once provided in previous Apollo releases, although with some restrictions and limitations. Hope that we can bring it back.
Please stay tuned. Once we are ready, we should let everyone noticed.


Added ditaa example.

Could you add this example to booksample and cheatsheet documents in conf folder ?

@rahmanusta Done. Added ditaa and graphviz dot examples to both booksample and cheatsheet.

Thank you @wfouche !


can't find RRDBNet weight

Hi,sorry to bother you, but I find the RRDBNet weight is not in the weight set

RRDBNet？ ESRGAN？？？

Found it, thank you!


Feature: download and install plugins

Codecov Report

Merging #168 (859f7bc) into main (f1a18c9) will decrease coverage by 4.46%.
The diff coverage is 51.48%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #168      +/-   ##
==========================================
- Coverage   66.49%   62.03%   -4.47%
==========================================
  Files          31       34       +3
  Lines        1382     1483     +101
  Branches      304      325      +21
==========================================
+ Hits          919      920       +1
- Misses        392      494     +102
+ Partials       71       69       -2

Impacted Files
Coverage Δ

qgis_deployment_toolbelt/plugins/downloader.py
0.00% <0.00%> (ø)

...ployment_toolbelt/jobs/job_plugins_synchronizer.py
31.81% <31.81%> (ø)

qgis_deployment_toolbelt/profiles/qdt_profile.py
85.43% <75.00%> (-0.43%)
:arrow_down:

qgis_deployment_toolbelt/plugins/plugin.py
91.89% <91.89%> (ø)

qgis_deployment_toolbelt/jobs/orchestrator.py
84.84% <100.00%> (+0.47%)
:arrow_up:

qgis_deployment_toolbelt/utils/win32utils.py
44.00% <0.00%> (-36.00%)
:arrow_down:

qgis_deployment_toolbelt/profiles/shortcuts.py
44.92% <0.00%> (-23.92%)
:arrow_down:

qgis_deployment_toolbelt/commands/cli_upgrade.py
54.68% <0.00%> (-7.82%)
:arrow_down:

...loyment_toolbelt/jobs/job_environment_variables.py
93.10% <0.00%> (-6.90%)
:arrow_down:


WIP exclude browserSync and connect-history-api-fallback

I what to separate browser-sync and have problems running gulp build --exclude-source --prod.
This is work in progress. Hope together we will succeed.

Edit by antonybudianto:
TODOS

[x] rebase latest master #96

Closes #94

Please store mode 'dev' as constant, so it's not hardcoded and expose it to config var
I need predefined hard coded environment.

please update travis build script to
gulp build --exclude-source --env=prod

@darxx , can you edit karma.conf.js and go to excludedDependencies part,
var excludedDependencies = [
    'systemjs', 'zone.js', 'font-awesome'
  ];

and add karma-ie-launcher, karma-phantomjs-launcher...

Hope changes will be useful to everyone. Ok I will wait. After I will fork this project again.  Im not  spending much time on github. Dont know how to make rebase on forked project.

you can also pull latest master and merge it to your branch

Changes Unknown when pulling 466d412e88d436d141a7d2d0a3750130b38bf2b0 on darxx:master into ** on antonybudianto:master**.

Coverage remained the same at 100.0% when pulling 0e2c5fefb336d8920c1afe47fe4843f6c932f76a on darxx:master into ef02ab4faacfb3cf5e4fba8fe88eb2e1cc28ced3 on antonybudianto:master.

Coverage remained the same at 100.0% when pulling 0e2c5fefb336d8920c1afe47fe4843f6c932f76a on darxx:master into ef02ab4faacfb3cf5e4fba8fe88eb2e1cc28ced3 on antonybudianto:master.

Coverage remained the same at 100.0% when pulling d16583dbc9d8b75063dc08e17ce965ec0c17580c on darxx:master into ef02ab4faacfb3cf5e4fba8fe88eb2e1cc28ced3 on antonybudianto:master.

Coverage remained the same at 100.0% when pulling 6746eb92e54ebb19c871aad0bff03348424c69de on darxx:master into ef02ab4faacfb3cf5e4fba8fe88eb2e1cc28ced3 on antonybudianto:master.

Coverage remained the same at 100.0% when pulling 08cdf171c1dc9d0596fa32280de5bba6f931b21b on darxx:master into ef02ab4faacfb3cf5e4fba8fe88eb2e1cc28ced3 on antonybudianto:master.

Coverage remained the same at 100.0% when pulling 08cdf171c1dc9d0596fa32280de5bba6f931b21b on darxx:master into ef02ab4faacfb3cf5e4fba8fe88eb2e1cc28ced3 on antonybudianto:master.

the rest LGTM, will check it out tonight

Coverage remained the same at 100.0% when pulling 1757ab537777503fb5297a04c28067bf89df850a on darxx:master into ef02ab4faacfb3cf5e4fba8fe88eb2e1cc28ced3 on antonybudianto:master.

Thanks for the PR! @darxx


Sonarr API doesn't seem to work, logs show 404 on startup.

I've set up Unpackerr for Sonarr and Radarr, not sure if it matters but I'm running Fedora 31 currently. Radarr works fine but when reviewing the Unpackerr logs I'm seeing 404 errors coming from Sonarr.
Unpackerr Config:
`################'
'### Episodes ###'
'################'
'[[sonarr]]'
url = "http://<IP_ADDRESS>:8989"
api_key = "****************"
File system path where downloaded Sonarr items are located.
paths = ["/mnt/nfs/Downloads/Incomplete/"]
Default protocols is torrent. Alternative: "torrent,usenet"
protocols = "torrent"
How long to wait for a reply from the backend.
timeout = "10s"
How long ago a file must have been imported before deletion. The file must
also not be part of an active queue item. Set this to "1m" to make sure files
are deleted quickly after being imported. Recommend "5m". Uses Go Duration.
Setting this to any negative number -1 disables deleting extracted files.
delete_delay = "5m"
If you use this app with NZB you may wish to delete archives after extraction.
General recommendation is: do not enable this for torrent use.
Setting this to true deletes the entire original download folder after import.
delete_orig = false
`
Unpackerr Log:
2021/07/08 10:57:12.441429 sonarr.go:102: [ERROR] Sonarr (http://<IP_ADDRESS>:8989): api.Get(queue): failed:  (status: 404 Not Found): invalid status code, <200||>299: { "message": "NotFound"}
Am I missing something? I can query the API from a browser without issue.

I've set up Unpackerr for Sonarr and Radarr, not sure if it matters but I'm running Fedora 31 currently. Radarr works fine but when reviewing the Unpackerr logs I'm seeing 404 errors coming from Sonarr.
Unpackerr Config:
`################'
'### Episodes ###'
'################'
'[[sonarr]]'
url = "http://<IP_ADDRESS>:8989"
api_key = "****************"
File system path where downloaded Sonarr items are located.
paths = ["/mnt/nfs/Downloads/Incomplete/"]
Default protocols is torrent. Alternative: "torrent,usenet"
protocols = "torrent"
How long to wait for a reply from the backend.
timeout = "10s"
How long ago a file must have been imported before deletion. The file must
also not be part of an active queue item. Set this to "1m" to make sure files
are deleted quickly after being imported. Recommend "5m". Uses Go Duration.
Setting this to any negative number -1 disables deleting extracted files.
delete_delay = "5m"
If you use this app with NZB you may wish to delete archives after extraction.
General recommendation is: do not enable this for torrent use.
Setting this to true deletes the entire original download folder after import.
delete_orig = false
`
Unpackerr Log:
2021/07/08 10:57:12.441429 sonarr.go:102: [ERROR] Sonarr (http://<IP_ADDRESS>:8989): api.Get(queue): failed:  (status: 404 Not Found): invalid status code, <200||>299: { "message": "NotFound"}
Am I missing something? I can query the API from a browser without issue.

Are you using v2 of sonarr?

Yes I am, and sorry about the formatting I was trying to fix it up and get distracted with work.

Sonarr v2 is EOL and depreciated.

Oh wow, I had no idea v3 was even out! Apologies, and thank you!


zlib: 1.3 -> 1.3.1

Description of changes

Changes in 1.3.1 (22 Jan 2024)

Reject overflows of zip header fields in minizip
Fix bug in inflateSync() for data held in bit buffer
Add LIT_MEM define to use more memory for a small deflate speedup
Fix decision on the emission of Zip64 end records in minizip
Add bounds checking to ERR_MSG() macro, used by zError()
Neutralize zip file traversal attacks in miniunz
Fix a bug in ZLIB_DEBUG compiles in check_match()
Various portability and appearance improvements

http://www.zlib.net/ChangeLog.txt
Also migrate to by-name.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

58581 packages updated
this should target staging

Didn't see that there was already 1.3.1 in staging.


Live changing theme

Is there a way to change the color of the theme dynamically and live ? Use case could be: User can change his theme...
$mat-background-color: #fafafa; // #fafafa for a light and #303030 for a dark theme

Create two custom themes with different names (by default there is always a theme folder called "mytheme", simply duplicate it with the name f.e. "mytheme2") and change the variable values.
You should then be able to change the theme via UI::setTheme("mytheme2") in runtime.
(You can find a working example in the Valo Theme Test)[https://github.com/vaadin/framework/tree/master/uitest/src/main/java/com/vaadin/tests/themes/valo]
I actually never tried to do this myself. If there any problems with the theme itself let ne know.

Great idea, thanks.
I'll let you know if it worked

Works like a charm. Thanks!
Maybe you want to add this to your wiki, if anyone else has this question, the answer could be found there.


Requests to management API fail without Authorization header

All of the management API functions need to sent an API token through the Authorization header, which currently isn't possible, and causes requests to fail with 401 "Missing Authentication". Should be as simple as adding an additional parameter of type AccessToken that gets used to build the header.

@JBetz Unfortunately we never ended up using this library (yet?), so aren't actively working on it at the moment. If you send in a PR with a working fix I'd be happy to merge it in.

@boj Ah, too bad. Do you have any sort of notes on what's left to implement? I'm building a Haskell backend that needs to talk to Auth0, so I'll likely need at least a subset of this library to work. As it is, I can't even get an access token. But yeah, I definitely want to help move it forward.
Out of curiosity, why'd you decide not to use this library?

As far as I know I implemented all of the Auth0 interfaces, but only tested the few I cared about.
Why we are not using this kind of convoluted. We took over a project that was being written in C# and was using Auth0, so I implemented this library thinking that functionality was necessary. Turns out it was overkill for the project, and using something like Azure's various integrated AD solutions made more sense for us (we handle a lot of onsite customer networks and services, not internet facing apps).

Yeah, it looks you got a good start. I don't think it will take much to make it useful for my needs.
My (professional) use case is fairly narrow, but it is for an internet facing app, so makes sense for our purposes. The one disappointing thing so far is that the admin dashboard isn't really something we're going to want to make our clients use (since each will be a separate tenant), so the plan there is to create our own that focuses on what we actually want along and also on what we need beyond Auth0. So yeah, that will be the primary use case for this library, as a backend for that admin panel.
Work on it has been delayed the past couple weeks, but I'm planning to get back into it soon and we'll see how it goes. :)

Got a PR coming to fix this. Will open it once #5 is resolved.

Great, thanks for the PR!

Resolved by #6.


C++ Bitset Functions [Documentation]

Description
I will explain various bitset functions with examples in documentation form.
Domain
C/CPP
Type of Contribution
Documentation
Code of Conduct

[X] I follow Contributing Guidelines & Code of conduct of this project.

/assign


Keep copy of tags in documents

We'll likely want to display associated tags when viewing a document. Trying to fetch these dynamically will get slower and slower as document repos grow, so we should manage a copy of the tags on the document metadata. This should be as simple as adding updates to the documents whenever we call TagDoc or UntagDoc for both dynamo and bolt backends.

Need to omit special tags as they're added. Pinning tags like user/{userID} shouldn't be included in the listing kept with the document.


[SPARK-3074] [PySpark] support groupByKey() with single huge key

This patch change groupByKey() to use external sort based approach, so it can support single huge key.
For example, it can group by a dataset including one hot key with 40 millions values (strings), using 500M memory for Python worker, finished in about 2 minutes. (it will need 6G memory in hash based approach).
During groupByKey(), it will do in-memory groupBy first. If the dataset can not fit in memory, then data will be partitioned by hash. If one partition still can not fit in memory, it will switch to sort based groupBy().

Hey @davies this would be freakin' fantastic to get merged... any chance that might happen soon? We hit many issues with skewed group sizes causing a whole job to fail and in my brief experimentation I think this would make things far more stable for us.

Ping @JoshRosen

This PR looks amazing! I'm going to test this out tomorrow with 1.3-rc3 and report back with some findings. I started taking a stab initially at trying to improve the shuffle memory handling a bit but it looks like I don't have to now!

Tried this out with 1.3-rc3 and was getting FetchFailedExceptions while performing a join between two RDDs:
org.apache.spark.shuffle.FetchFailedException: Error in opening FileSegmentManagedBuffer{file=/tmp/spark-6b363150-d169-4f3e-b703-98048b3dca7f/spark-edaee223-72e4-47f5-a984-64d25bdc34bd/spark-97f52fa9-3fc6-49f4-b1da-660c08e6d826/blockmgr-18bb9336-ca07-43db-ae49-c4be84846eb3/2c/shuffle_2_11_0.data, offset=1193, length=230}

Do you hit this error without the patch? I have no idea on why they are related.
On Thursday, March 26, 2015 at 10:43 AM, mkhaitman wrote:

Tried this out with 1.3-rc3 and was getting FetchFailedExceptions while performing a join between two RDDs:
org.apache.spark.shuffle.FetchFailedException: Error in opening FileSegmentManagedBuffer{file=/tmp/spark-6b363150-d169-4f3e-b703-98048b3dca7f/spark-edaee223-72e4-47f5-a984-64d25bdc34bd/spark-97f52fa9-3fc6-49f4-b1da-660c08e6d826/blockmgr-18bb9336-ca07-43db-ae49-c4be84846eb3/2c/shuffle_2_11_0.data, offset=1193, length=230}
—
Reply to this email directly or view it on GitHub (https://github.com/apache/spark/pull/1977#issuecomment-86640421).

@davies Sorry, I deleted the comment though you still received the notification. Think it was just a fluke since it didn't happen the second time. Sorry about that! So far looking good on joins.

Test build #29756 has started for   PR 1977 at commit c6a2f8d.

Test build #29757 has started for   PR 1977 at commit d9589ab.

Test build #29756 timed out     for PR 1977 at commit c6a2f8d     after a configured wait of 120m.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/29756/
Test FAILed.

Test build #29757 timed out     for PR 1977 at commit d9589ab     after a configured wait of 120m.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/29757/
Test FAILed.

Test build #29779 has started for   PR 1977 at commit d2f053b.

Test build #29779 has finished for   PR 1977 at commit d2f053b.

This patch fails PySpark unit tests.

This patch merges cleanly.

This patch adds the following public classes (experimental):

class ResultIterable(object):

class FlattedValuesSerializer(BatchedSerializer):

class ExternalList(object):

class GroupByKey(object):

class ChainedIterable(object):

class ExternalGroupBy(ExternalMerger):

This patch does not change any dependencies.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/29779/
Test FAILed.

Test build #29802 has started for   PR 1977 at commit 2a1857a.

Test build #29802 has finished for   PR 1977 at commit 2a1857a.

This patch fails PySpark unit tests.

This patch merges cleanly.

This patch adds the following public classes (experimental):

class ResultIterable(object):

class FlattedValuesSerializer(BatchedSerializer):

class ExternalList(object):

class GroupByKey(object):

class ChainedIterable(object):

class ExternalGroupBy(ExternalMerger):

This patch does not change any dependencies.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/29802/
Test FAILed.

Test build #637 has started for   PR 1977 at commit 2a1857a.

Test build #638 has started for   PR 1977 at commit 2a1857a.

Test build #638 has finished for   PR 1977 at commit 2a1857a.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.
This patch does not change any dependencies.

Test build #637 has finished for   PR 1977 at commit 2a1857a.

This patch fails PySpark unit tests.

This patch merges cleanly.

This patch adds no public classes.

This patch adds the following new dependencies:

activation-1.1.jar
aopalliance-1.0.jar
avro-1.7.7.jar
breeze-macros_2.10-0.11.2.jar
breeze_2.10-0.11.2.jar
commons-cli-1.2.jar
commons-compress-1.4.1.jar
commons-io-2.1.jar
commons-lang-2.5.jar
gmbal-api-only-3.0.0-b023.jar
grizzly-framework-2.1.2.jar
grizzly-http-2.1.2.jar
grizzly-http-server-2.1.2.jar
grizzly-http-servlet-2.1.2.jar
grizzly-rcm-2.1.2.jar
guice-3.0.jar
hadoop-annotations-2.2.0.jar
hadoop-auth-2.2.0.jar
hadoop-client-2.2.0.jar
hadoop-common-2.2.0.jar
hadoop-hdfs-2.2.0.jar
hadoop-mapreduce-client-app-2.2.0.jar
hadoop-mapreduce-client-common-2.2.0.jar
hadoop-mapreduce-client-core-2.2.0.jar
hadoop-mapreduce-client-jobclient-2.2.0.jar
hadoop-mapreduce-client-shuffle-2.2.0.jar
hadoop-yarn-api-2.2.0.jar
hadoop-yarn-client-2.2.0.jar
hadoop-yarn-common-2.2.0.jar
hadoop-yarn-server-common-2.2.0.jar
jackson-jaxrs-1.8.8.jar
jackson-xc-1.8.8.jar
javax.inject-1.jar
javax.servlet-3.1.jar
javax.servlet-api-3.0.1.jar
jaxb-api-2.2.2.jar
jaxb-impl-2.2.3-1.jar
jersey-client-1.9.jar
jersey-core-1.9.jar
jersey-grizzly2-1.9.jar
jersey-guice-1.9.jar
jersey-json-1.9.jar
jersey-server-1.9.jar
jersey-test-framework-core-1.9.jar
jersey-test-framework-grizzly2-1.9.jar
jettison-1.1.jar
jetty-util-6.1.26.jar
management-api-3.0.0-b012.jar
protobuf-java-2.4.1.jar
spark-bagel_2.10-1.4.0-SNAPSHOT.jar
spark-catalyst_2.10-1.4.0-SNAPSHOT.jar
spark-core_2.10-1.4.0-SNAPSHOT.jar
spark-graphx_2.10-1.4.0-SNAPSHOT.jar
spark-launcher_2.10-1.4.0-SNAPSHOT.jar
spark-mllib_2.10-1.4.0-SNAPSHOT.jar
spark-network-common_2.10-1.4.0-SNAPSHOT.jar
spark-network-shuffle_2.10-1.4.0-SNAPSHOT.jar
spark-repl_2.10-1.4.0-SNAPSHOT.jar
spark-sql_2.10-1.4.0-SNAPSHOT.jar
spark-streaming_2.10-1.4.0-SNAPSHOT.jar
stax-api-1.0.1.jar
xz-1.0.jar

This patch removes the following dependencies:

breeze-macros_2.10-0.11.1.jar
breeze_2.10-0.11.1.jar
commons-el-1.0.jar
commons-io-2.4.jar
commons-lang-2.4.jar
hadoop-client-1.0.4.jar
hadoop-core-1.0.4.jar
hsqldb-<IP_ADDRESS>.jar
jblas-1.2.3.jar
spark-bagel_2.10-1.3.0-SNAPSHOT.jar
spark-catalyst_2.10-1.3.0-SNAPSHOT.jar
spark-core_2.10-1.3.0-SNAPSHOT.jar
spark-graphx_2.10-1.3.0-SNAPSHOT.jar
spark-launcher_2.10-1.3.0-SNAPSHOT.jar
spark-mllib_2.10-1.3.0-SNAPSHOT.jar
spark-network-common_2.10-1.3.0-SNAPSHOT.jar
spark-network-shuffle_2.10-1.3.0-SNAPSHOT.jar
spark-repl_2.10-1.3.0-SNAPSHOT.jar
spark-sql_2.10-1.3.0-SNAPSHOT.jar
spark-streaming_2.10-1.3.0-SNAPSHOT.jar

Test build #29816 has started for   PR 1977 at commit e3b8eab.

Test build #29816 has finished for   PR 1977 at commit e3b8eab.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.
This patch does not change any dependencies.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/29816/
Test PASSed.

I spent most of the morning looking this over again and the patch looks pretty good to me.  I think I understand the lifecycle of values pretty well.  I left a couple of questions / comments upthread, but overall I think this is pretty close to being ready to merge.
One quick question: when do groupBy's spill files get cleaned up?  It seems like we want them to be cleaned at the end of the task, since at that point we know for sure that they won't be re-used.  To handle this case, what do you think about adding a cleanup hook mechanism that allows us to register cleanup code to run at the end of a task?  In the past, we could have relied on shutdown hooks for this, but that's no longer possible due to worker re-use.

Test build #29891 has started for   PR 1977 at commit 0dcf320.

@JoshRosen Thanks for review this, this may be the most complicated part in PySpark. :(
For partitioned file, they will be cleaned up after merging, partition by partition. The sorted file and file for large list (ExternalList) will be cleaned up once it's closed by GC (os.unlink() after open it).

@JoshRosen Also, I had rollback the changes in ResultIterable (because some one is using ResultIterable.maxindex), and improve the performance of len(ResultIterable) for ExternalList, please take another look.

Test build #29891 has finished for   PR 1977 at commit 0dcf320.

This patch fails Spark unit tests.

This patch merges cleanly.

This patch adds the following public classes (experimental):

class FlattenedValuesSerializer(BatchedSerializer):

class ExternalList(object):

class GroupByKey(object):

class ChainedIterable(object):

class ExternalGroupBy(ExternalMerger):

This patch does not change any dependencies.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/29891/
Test FAILed.

Jenkins, retest this please.

Test build #29895 has started for   PR 1977 at commit 0dcf320.

@JoshRosen the last comments had been addressed.

Test build #29900 has started for   PR 1977 at commit 0b0fde8.

Test build #29895 has finished for   PR 1977 at commit 0dcf320.

This patch passes all tests.

This patch merges cleanly.

This patch adds the following public classes (experimental):

class FlattenedValuesSerializer(BatchedSerializer):

class ExternalList(object):

class GroupByKey(object):

class ChainedIterable(object):

class ExternalGroupBy(ExternalMerger):

This patch does not change any dependencies.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/29895/
Test PASSed.

Test build #29900 has finished for   PR 1977 at commit 0b0fde8.

This patch passes all tests.

This patch merges cleanly.

This patch adds the following public classes (experimental):

class FlattenedValuesSerializer(BatchedSerializer):

class ExternalList(object):

class ExternalListOfList(ExternalList):

class GroupByKey(object):

class GroupListsByKey(GroupByKey):

class ChainedIterable(object):

class ExternalGroupBy(ExternalMerger):

This patch does not change any dependencies.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/29900/
Test PASSed.

Sorry for my initial confusion regarding the external lists of lists.  I think that the __len__ thing might be an issue if we ever directly expose ExternalListOfList to users, but it looks like we currently only expose it through a ChainedIterable in this code, so it doesn't appear to be a problem yet.  This still might be worth addressing if you agree that it could help prevent future bugs if we start using this in more places.

@JoshRosen Thanks for the comments, it looks better now.

Test build #29921 has started for   PR 1977 at commit e78c15c.

Test build #29921 has finished for   PR 1977 at commit e78c15c.

This patch fails PySpark unit tests.

This patch merges cleanly.

This patch adds the following public classes (experimental):

class FlattenedValuesSerializer(BatchedSerializer):

class ExternalList(object):

class ExternalListOfList(ExternalList):

class GroupByKey(object):

class ExternalGroupBy(ExternalMerger):

This patch does not change any dependencies.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/29921/
Test FAILed.

Test build #29925 has started for   PR 1977 at commit 67772dd.

Test build #29925 has finished for   PR 1977 at commit 67772dd.

This patch passes all tests.

This patch merges cleanly.

This patch adds the following public classes (experimental):

class FlattenedValuesSerializer(BatchedSerializer):

class ExternalList(object):

class ExternalListOfList(ExternalList):

class GroupByKey(object):

class ExternalGroupBy(ExternalMerger):

This patch does not change any dependencies.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/29925/
Test PASSed.

I spent a bit of time fuzz-testing this code to try to reach 100% coverage of the changes in this patch.    It looks like there's a branch in ExternalSorter.sorted where we can end up returning a list instead of an iterator (line 517), where we return current_chunk.

@JoshRosen Good catch! fixed it.

Test build #29967 has started for   PR 1977 at commit af3713a.

Test build #29967 has finished for   PR 1977 at commit af3713a.

This patch passes all tests.

This patch merges cleanly.

This patch adds the following public classes (experimental):

class FlattenedValuesSerializer(BatchedSerializer):

class ExternalList(object):

class ExternalListOfList(ExternalList):

class GroupByKey(object):

class ExternalGroupBy(ExternalMerger):

This patch does not change any dependencies.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/29967/
Test PASSed.

LGTM.  I spent more time testing this locally, commenting out various memory threshold flags as necessary in order to get good branch coverage, and didn't find any new problems.  We should definitely do performance benchmarking of this feature during the 1.4 QA period in order to quantify its impact, but that isn't a blocker to merging this now.  If this does turn out to have any performance issues for certain workloads, users should be able to feature-flag it by configuring Spark with a higher spilling threshold (or we could introduce a new flag specifically to bypass this).
I'm going to merge this into master (1.4.0).   Thanks!

Great thanks to test it, it did help us to find a bug!


undefined reference to `FlutterPlatformMessageCreateResponseHandle'

Flutter version
Flutter 1.6.3 • channel beta • https://github.com/flutter/flutter.git
Framework • revision bc7bc94083 (4 months ago) • 2019-05-23 10:29:07 -0700
Engine • revision 8dc3a4cde2
Tools • Dart 2.3.2 (build 2.3.2-dev.0.0 e3edfd36b2)

Golang errors (Optional)

hover: Using engine from cache
hover: Cleaning the build directory
hover: Bundling flutter app
Running "flutter pub get" in app...                                 3.2s
hover: Checking available release on Github
hover: The core library 'go-flutter' has an update available. (v0.29.0 -> 0.29.2)
              To update 'go-flutter' in this project run: $ hover upgrade
hover: Compiling 'go-flutter' and plugins
# github.com/go-flutter-desktop/go-flutter/embedder
C:\Users\(user)\AppData\Local\Temp\go-build735935182\b040\_x003.o: In function `_cgo_84ad20d147fe_Cfunc_FlutterPlatformMessageReleaseResponseHandle':
/tmp/go-build/cgo-gcc-prolog:252: undefined reference to `FlutterPlatformMessageReleaseResponseHandle'
C:\Users\(user)\AppData\Local\Temp\go-build735935182\b040\_x005.o: In function `createMessageResponseHandle':
..\..\..\..\go\pkg\mod\github.com\go-flutter-desktop\go-flutter@v0.29.0\embedder/embedder_helper.c:72: undefined reference to `FlutterPlatformMessageCreateResponseHandle'
collect2.exe: error: ld returned 1 exit status
hover: Go build failed: exit status 2

Steps to Reproduce

Install MinGW
Install go
Install hover
Run hover init github.com/...
Run hover run

Update to the latest version of the flutter beta channel.

duplicate of  #247


Increase wait for generation features in DevTests

configIncludesChangeTest() intermittently fails through GitHub Actions because generateFeatures is not given enough time to run. Fix increases the time waiting to see generate features message in dev mode output.
Signed-off-by: Kathryn Kodama<EMAIL_ADDRESS>

See GitHub actions run from commit here: https://github.com/kathrynkodama/ci.gradle/runs/6161509712?check_suite_focus=true


search query in gallery

suggestions and their routing should be fixed once we have merged

https://github.com/kodadot/nft-gallery/pull/3491

last thing (afaik) is to fix the actual search query for words in Gallery
{
   "errors":[
      {
         "message":"Variable \"$search\" got invalid value { name: { likeInsensitive: \"%test%\" } } at \"search[0]\"; Field \"name\" is not defined by type \"NFTEntityWhereInput\".",
         "extensions":{
            "code":"BAD_USER_INPUT",
            "exception":{
               "stacktrace":[
                  "GraphQLError: Variable \"$search\" got invalid value { name: { likeInsensitive: \"%test%\" } } at \"search[0]\"; Field \"name\" is not defined by type \"NFTEntityWhereInput\".",
                  "    at /squid/node_modules/graphql/execution/values.js:116:15",
                  "    at coerceInputValueImpl (/squid/node_modules/graphql/utilities/coerceInputValue.js:114:9)",
                  "    at coerceInputValueImpl (/squid/node_modules/graphql/utilities/coerceInputValue.js:54:14)",
                  "    at /squid/node_modules/graphql/utilities/coerceInputValue.js:70:14",
                  "    at Array.map (<anonymous>)",
                  "    at safeArrayFrom (/squid/node_modules/graphql/jsutils/safeArrayFrom.js:36:23)",
                  "    at coerceInputValueImpl (/squid/node_modules/graphql/utilities/coerceInputValue.js:68:50)",
                  "    at coerceInputValue (/squid/node_modules/graphql/utilities/coerceInputValue.js:37:10)",
                  "    at _loop (/squid/node_modules/graphql/execution/values.js:109:69)",
                  "    at coerceVariableValues (/squid/node_modules/graphql/execution/values.js:121:16)"
               ]
            }
         }
      }
   ]
}

👋

Shouldn't this be fixed by #3433?

Shouldn't this be fixed by #3433?

Feel free to fix this bug in your PR if you want.

Shouldn't this be fixed by #3433?

Feel free to fix this bug in your PR if you want.

no its fine, if it isnt fixed there, I guess we can fix it in a different issue to keep track so go ahead


[BUG] Automatic version tagging for containerized environments doesn't work

Agent Environment
Agent version: 7.55.2
Describe what happened:
The docs in https://docs.datadoghq.com/getting_started/tagging/unified_service_tagging/?tab=kubernetes
state that the version tag should be taken from the image_tag. Therefore, for the following pod:
apiVersion: v1
kind: Pod
metadata:
  name: test
  labels:
    app: my-app
    tags.datadoghq.com/env: "staging"
    tags.datadoghq.com/service: "mysvc"
spec:
  containers:
  - name: nginx
    image: yoavklein3/nginx:0.1
    ports:
    - containerPort: 80

the version tag should be 0.1.  But I don't see any version tag on the logs generated by this container.
Describe what you expected:
the version tag should be 0.1.  But I don't see any version tag on the logs generated by this container.
Steps to reproduce the issue:

Install the Datadog Agent using the Datadog Operator on a Kubernetes cluster.
Deploy the following pod:

apiVersion: v1
kind: Pod
metadata:
  name: test
  labels:
    app: my-app
    tags.datadoghq.com/env: "staging"
    tags.datadoghq.com/service: "mysvc"
spec:
  containers:
  - name: nginx
    image: yoavklein3/nginx:0.1
    ports:
    - containerPort: 80

Additional environment details (Operating System, Cloud provider, etc):

Thank you for reporting this issue, and we apologize for the inconvenience. While the documentation was recently updated (https://github.com/DataDog/documentation/pull/23262), it is not yet fully accurate in describing how "Unified Service Tagging" works across all Datadog products.
Currently, only the APM product supports automatic "version" tagging from image_tag. As such, it is expected that this functionality isn't yet available for logs and metrics emitted by your application.
We are planning to update the documentation soon to provide a more accurate description of the current Unified Service Tagging capabilities. In parallel, we're starting an internal discussion about extending this behavior to other products. In the meantime, I recommend reapplying the tags.datadoghq.com/version label to retrieve the version tags.
Thanks again for your understanding, and we'll keep you posted on any updates.


Fix visual overflow for SliverMainAxisGroup

Fixes https://github.com/flutter/flutter/issues/132788
The SliverGeometry was not set properly for SliverMainAxisGroup. Omitting hasVisualOverflow affected the Viewport's choice to apply a clip, leading to the sliver being rendered outside of the bounds of the viewport.
Pre-launch Checklist

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[x] I signed the CLA.
[x] I listed at least one issue that this PR fixes in the description above.
[ ] I updated/added relevant documentation (doc comments with ///).
[x] I added new tests to check the change I am making, or this PR is test-exempt.
[x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

hope this change merge to stable as soon as possible


5454082B - Red Dead Redemption GOTY Edition

Validation

[X] I've read the FAQ.
[X] The Xenia build used is from a canary branch. (not MLBS/AlexVS/master/pull requests, etc)
[X] This issue isn't for help (tech support) with Xenia, or a game.
[X] I've checked if this game doesn't already have a compatibility report.

Xbox 360 Marketplace link
https://marketplace.xbox.com/en-US/product/Red-Dead-Redemption/66acd000-77fe-1000-9115-d8025454082b
Xenia version
https://github.com/xenia-canary/xenia-canary/commit/3d3810fa9829704fdfb6c4ec6a2c43e0cd8eece2
Issues
With the current Xenia Canary, ragdoll animations are not executed properly. In comparison with the current Xenia master, the game on XBox One/360 and Xenia Canary, it seems like the ragdoll sequences are shorter, less stable and less responsive on the current Xenia Canary. Xenia Master is identical to the Xbox One/360 (where the ragdoll animation sequences are executed properly).
It is very likely that this is related to the used middleware (tech-middleware-euphoria) in combination with the better performance of xenia canary. One explanation could be, that the game is using a kind of fps counter to calculate the ragdoll sequence lenght. At least the parameters of the engine gives you the option to consider fps counting to calculate the ragdoll. (the real engine configuration of RDR GOTY is unknown to me). It seems like the way how the performance boost on xenia canary works is affecting this (it dont matter if you have vsync true or false or vsync_interval = 16 [= 30 fps ingame]).
Previously, this issue only occurred if you disabled Vsync on Xenia master to disable the 30fps lock.
The euphoria driven ragdoll mechanic of Red Dead Redemption are a main feature of the game which is highly inspired by the prequel called "Red Dead Revolver".
If you need more information you can also contact me on discord "leckeres_bratgut#8804"
Log
xenia.log
Screenshots

Labels
state-gameplay, tech-engine-rage, tech-middleware-euphoria

playable from start to finish with these settings:
framerate_limit = 120 (caps the FPS to 60)
query_occlusion_fake_sample_count = -1 (Stops the lights shining through the walls)
also used the disable sun flare patch.

Label
state-playable


⚠ Bofrost.de has degraded performance

In 20598a1, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1522 ms

Resolved: Bofrost.de performance has improved in d793830 after 19 minutes.


FlutterFragment overlapping Android native DrawerLayout

Steps to Reproduce

Create layout with DrawerLayot
Put FlutterFragment inside DrawerLayout
Try to open Drawer

Expected results:  Drawer will be shown over FlutterFragment
Actual results:  FlutterFragment is overlapping Drawer, but Drawer handles all taps
Repository with test app Link

Logs

flutter analyze
Analyzing drawer_overlap_bug...
No issues found! (ran in 2.0s)

flutter doctor -v
[✓] Flutter (Channel stable, 2.0.5, on Mac OS X 10.15.7 19H524 darwin-x64,
    locale ru-RU)
    • Flutter version 2.0.5 at /Users/sergeyanisov/development/flutter
    • Framework revision adc687823a (10 days ago), 2021-04-16 09:40:20 -0700
    • Engine revision b09f014e96
    • Dart version 2.12.3

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.2)
    • Android SDK at /Users/sergeyanisov/Library/Android/sdk
    • Platform android-30, build-tools 30.0.2
    • Java binary at: /Applications/Android
      Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build
      1.8.0_242-release-1644-b3-6915495)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 12.4, Build version 12D4e
    • CocoaPods version 1.10.0

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build
      1.8.0_242-release-1644-b3-6915495)

[✓] IntelliJ IDEA Community Edition (version 2020.2.3)
    • IntelliJ at /Applications/IntelliJ IDEA CE.app
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart

[✓] VS Code (version 1.54.3)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension can be installed from:
      🔨 https://marketplace.visualstudio.com/items?itemName=Dart-Code.flutter

[✓] Connected device (2 available)
    • SM G920T (mobile) • 0715f7a0a9d31734 • android-arm64  • Android 7.0 (API
      24)
    • Chrome (web)      • chrome           • web-javascript • Google Chrome
      90.0.4430.85

• No issues found!

Verified this on S10 device and noticed the same behavior, ie, the FlutterFragment is overlapping native drawerLayout.

flutter doctor -v
[✓] Flutter (Channel stable, 2.0.5, on Mac OS X 10.15.4 19E2269 darwin-x64,
    locale en-GB)
    • Flutter version 2.0.5 at /Users/dhs/documents/fluttersdk/flutter
    • Framework revision adc687823a (3 days ago), 2021-04-16 09:40:20 -0700
    • Engine revision b09f014e96
    • Dart version 2.12.3

[!] Xcode - develop for iOS and macOS
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 12.3, Build version 12C33
    ! CocoaPods 1.9.3 out of date (1.10.0 is recommended).
        CocoaPods is used to retrieve the iOS and macOS platform side's plugin
        code that responds to your plugin usage on the Dart side.
        Without CocoaPods, plugins will not work on iOS or macOS.
        For more info, see https://flutter.dev/platform-plugins
      To upgrade see
      https://guides.cocoapods.org/using/getting-started.html#installation for
      instructions.

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build
      1.8.0_242-release-1644-b3-6915495)

[✓] VS Code (version 1.55.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.20.0

[✓] Connected device (3 available)
	  • SM G975F (mobile) • RZ8M802WY0X • android-arm64 • Android 10 (API 29)
    • Darshan's iphone (mobile) • 21150b119064aecc249dfcfe05e259197461ce23 • ios
      • iOS 14.4.1
    • macOS (desktop)           • macos                                    •
      darwin-x64     • Mac OS X 10.15.4 19E2269 darwin-x64
    • Chrome (web)              • chrome                                   •
      web-javascript • Google Chrome 89.0.4389.114

! Doctor found issues in 1 category.

I found a way, to fix it by changing a mode of rendering.
Create fragment with texture or image RenderMode:
FlutterFragment.withNewEngine()
			.renderMode(RenderMode.texture)
			.build<FlutterFragment>()


$cordovaOauth additions and bug fixes

This merge may seem large, but it isn't.  I ended up copying all my code over because it was easier.  Git picked up differences in spacing.
This request contains the following additions:

Add Magento support
Add ADFS support
Add vkontakte support

For bug fixes there were two types made that spanned across all providers:

Close browser only after promise was made to prevent inaccurate cancel login flow messages
Add a timeout to the browser close.  If a close attempt is made while the open transition is happening, it wont close.  Adding a timeout is a workaround

Lastly, the createSignature method has been updated to account for token secrets.

Looks good to me! thanks @nraboy

No problem man.  Ping me if someone ever has trouble with the Oauth stuff since I don't frequently visit the issue tracker.


chore(master): release 1.17.5

:robot: I have created a release beep boop
1.17.5 (2024-10-30)
Bug Fixes

fix coercion of env values (686ec29)

This PR was generated with Release Please. See documentation.

:robot: Created releases:

v1.17.5
:sunflower:


worker keep logging of "waiting for db"

Description
I ran the app in kubernetes but worker pod  kept logging "waiting for db"
Steps to reproduce the issue, if relevant:
just follow the steps
kubectl create namespace vote
then
kubectl create -f k8s-specifications/
then kubectl logs worker...
you will meet the error of waiting for db

Same for me.

We have to pass the environment variables while running the db container -
POSTGRES_USER: "postgres"
POSTGRES_PASSWORD: "postgres"
This solved the issue for me.

@jithinktom PR #159 added these variables to the postgres invocation, but the error persists

Same for me, even including the Postgres user and pass on db container.

As I commented in another post, I just notice that Swarm and Kubernetes deployments are not going to work because images from docker hub are not updated as predicted on this  pull request. In this case, you have to build the images by yourself and change the stacks and k8s-specifications to use your own images.

To me, first I start with
docker-compose up
then break, and add to docker-compose.yml:
environment:       POSTGRES_USER: "postgres"       POSTGRES_PASSWORD: "postgres"
Next,
docker-compose down -v
And again
docker-compose -up -d
It worked to me.

Hi,
Using docker-compose the image is built when running the command as others have mentioned. However, using swarm or Kubernetes, as she is trying to do, the image is pulled from the docker hub, which is outdated.
spec:
      containers:
      - image: dockersamples/examplevotingapp_worker
        name: worker

Using Kubernetes or swarm you have to build the image locally and change the image path accordingly until they fix it.
Best regards,

@eliezerreis thank you!
I lost a few hours on this one.

Hi @hedeesa,
Eu encontrei uma maneira de fazer funcionar, porém, precisei de algumas interações manuais.
O erro parece estar no método de autenticação que por algum motivo não retorna o hash md5 adequadamente. Estou investigando ainda.
Error:
FATAL:  password authentication failed for user "postgres"
DETAIL:  Connection matched pg_hba.conf line 95: "host all all all md5"
Workaround:
Verify your db instance in Kubernetes:
kubectl get pods -n vote | grep db db-68c5b55955-ns5w4       1/1     Running   0          123m
Inside your pod execute those commands:
apt update && apt install vim vim /var/lib/postgresql/data/pg_hba.conf
Change line 95 to  'host all all all trust'
Ref: https://www.postgresql.org/docs/9.1/auth-methods.html
Now we need to reload postgres configurations.
Change to postgres user:
su - postgres
Execute psql:
psql
Execute this command to reload configuration:
SELECT pg_reload_conf();
If you need to close connection to psql execute:
\q[ENTER]
Now i believe your Example-Voting-App works in Kubernetes.

I found another way to do this configs.
Include this environment variable inside your k8s-specifictions/db-deployment.yaml:
   ` - name: POSTGRES_HOST_AUTH_METHOD `
    `  value: trust`

After changing this configuration above, postgres displays this message:

WARNING: POSTGRES_HOST_AUTH_METHOD has been set to "trust". This will allow
anyone with access to the Postgres port to access your database without
a password, even if POSTGRES_PASSWORD is set. See PostgreSQL
documentation about "trust":
https://www.postgresql.org/docs/current/auth-trust.html
In Docker's default configuration, this is effectively any other
container on the same system.
     It is not recommended to use POSTGRES_HOST_AUTH_METHOD=trust. Replace
     it with "-e POSTGRES_PASSWORD=password" instead to set a password in
     "docker run".

Important: Use this configuration only in TEST environments and following documentation recommendations

Found the Problem !
In the Worker app the Postgresql connexion string is wrong :
replace
var pgsql = OpenDbConnection("Server=db;Username=postgres;Password=postgres;");

with
var pgsql = OpenDbConnection("Host=db;Username=postgres;Password=postgres;");

Can someone please refresh the images in dockersamples/ Docker Hub repository?
It should be pretty easy.

This is still an issue so 'Step 4: Orchestration: Swarm' of https://www.docker.com/docker-desktop/getting-started-for-windows doesn't work - the votes are not registered.
As per the title of this ticket vote_worker is constantly logging: Waiting for db
Also vote_db is constantly logging: FATAL:  password authentication failed for user "postgres"

Try this for env for postgres db hope this voting docker stack will work.
db:
image: postgres:9.4
environment:
POSTGRES_USER: "postgres"
POSTGRES_PASSWORD: "postgres"
volumes:
- db-data:/var/lib/postgresql/data
networks:
- backend

Try this for env for postgres db hope this voting docker stack will work.
db:
image: postgres:9.4
environment:
POSTGRES_USER: "postgres"
POSTGRES_PASSWORD: "postgres"
volumes:
- db-data:/var/lib/postgresql/data
networks:
- backend

Hi @hedeesa,
I found a way to make it work, however, I needed some manual interactions.
The error appears to be in the authentication method which for some reason does not return the md5 hash properly. I'm still investigating.
Error:
FATAL: password authentication failed for user "postgres" DETAIL: Connection matched pg_hba.conf line 95: "host all all all md5"
Workaround:
Verify your db instance in Kubernetes:
kubectl get pods -n vote | grep db db-68c5b55955-ns5w4 1/1 Running 0 123m
Inside your pod execute those commands:
apt update && apt install vim vim /var/lib/postgresql/data/pg_hba.conf
Change line 95 to 'host all all all trust'
Ref: https://www.postgresql.org/docs/9.1/auth-methods.html
Now we need to reload postgres configurations.
Change to postgres user: su - postgres
Execute psql: psql
Execute this command to reload configuration: SELECT pg_reload_conf();
If you need to close connection to psql execute: \q[ENTER]
Now we can see in worker pod this message:
Waiting for db Waiting for db Waiting for db Connected to db Found redis at <IP_ADDRESS> Connecting to redis
Now I believe your Example-Voting-App works in Kubernetes.
Hope I help you. See ya

apt update && apt install vim vim /var/lib/postgresql/data/pg_hba.conf
just needs to be
apt update && apt install vim && vim /var/lib/postgresql/data/pg_hba.conf
missing the && between installing VIM and running it

We're sorry for the late response. Linux images have been refreshed, cleaned up, and are now multi-platform. If you're still having issues with the latest images, feel free to reopen this ticket.


Fix bootstrap fluid containers wording issue

Closes #2467.

@formap, merged, thanks for your contribution!


chore: use client.IgnoreNotFound

Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 8 (0.0%)  changed or added relevant lines in 6 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.2%) to 74.056%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

pkg/controllers/metrics/pod/controller.go
0
1
0.0%

pkg/controllers/metrics/provisioner/controller.go
0
1
0.0%

pkg/controllers/provisioning/controller.go
0
1
0.0%

pkg/controllers/termination/terminate.go
0
1
0.0%

pkg/controllers/counter/controller.go
0
2
0.0%

pkg/controllers/node/controller.go
0
2
0.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.2%

Covered Lines:
4787

Relevant Lines:
6464

💛  - Coveralls


feedback

Hey I wrote a provider for the CCP CREST API (https://github.com/alcohol/oauth2-eveonline).
After submitting it for review/feedback on r/evetech, a user left the following comment: https://www.reddit.com/r/evetech/comments/5r7gt1/php_70_oauth2_client/dd512op/
Wonder if you have any opinion/feedback to this?

I don't see a security risk here, we're just generating 2x the amount of random bytes and then truncating it. That said, I think the correct thing to do would be to reduce the amount of bytes generated to match the expected length of output.
Any thoughts @ramsey ?


Setup issue

Discord SiriusXM Bot version: latest
Python version: 3.5.3
Operating System: Windows server 2016 || debian linux 9.8

Description
When trying to setup the project following the provided instructions and simply running the --help command produces an error.
What I Did
mortis-music --help
Traceback (most recent call last):
File "/home/user/mortis-music/venv/bin/mortis-music", line 11, in
load_entry_point('mortis-music==0.1.0', 'console_scripts', 'mortis-music')()
File "/home/user/mortis-music/venv/lib/python3.5/site-packages/pkg_resources/init.py", line 489, in
load_entry_point
return get_distribution(dist).load_entry_point(group, name)
File "/home/user/mortis-music/venv/lib/python3.5/site-packages/pkg_resources/init.py", line 2843, in
load_entry_point
return ep.load()
File "/home/user/mortis-music/venv/lib/python3.5/site-packages/pkg_resources/init.py", line 2434, in
load
return self.resolve()
File "/home/user/mortis-music/venv/lib/python3.5/site-packages/pkg_resources/init.py", line 2440, in
resolve
module = import(self.module_name, fromlist=['name'], level=0)
File "/home/user/mortis-music/venv/lib/python3.5/site-packages/mortis_music-0.1.0-py3.5.egg/mortis_music
/cli.py", line 197
base_url = f"http://{host}:{port}"
^
SyntaxError: invalid syntax

Sorry I never saw this.
Only Python 3.6+. This project is still in development. I am not really set on the name or APIs or anything. It should be considered very unstable at the moment.

@songoku119 You should be able to check out https://github.com/AngellusMortis/sxm-discord now. I split this project into two projects. This one is just now the core SXM playback functionality. If you were looking for the bot functionality, check out that one.
As a reminder, it is Python 3.6+ only.


Image api improvements

While working with the img API I was frustrated to find that I had to create a vector of u8's even though I already had either a DynamicImage instance or PathBuf instance.  e.g. when creating a new file (DynamicImage) or opening a file (PathBuf).
I also noted that img_dynamic visibility is pub(crate) which meant I could not use that either.
This PR adds three well-named methods (commit 1) and deprecates the old one (commit 2).
See commits/changes.

Hello, any particular reason this PR cannot be merged?

@charlescgs

Hello, any particular reason this PR cannot be merged?

It hasn't passed CI and typically won't be reviewed until it does.
I do think though that we don't want to deprecate the img function. I think we can leave it as it is and just add the two new functions. Final approval is from dzhou121 though.

I do think though that we don't want to deprecate the img function

I agree, img is nice and convenient shorthand

@panekj then how about this:
pub fn img(image: impl Fn() -> Vec<u8> + 'static) -> Img {
    let image = image::load_from_memory(&image()).ok();
    let width = image.as_ref().map_or(0, |img| img.width());
    let height = image.as_ref().map_or(0, |img| img.height());
    let data = Arc::new(image.map_or(Default::default(), |img| img.into_rgba8().into_vec()));
    let blob = Blob::new(data);
    let image = peniko::Image::new(blob, peniko::Format::Rgba8, width, height);
    img_dynamic(move || image.clone())
}

pub fn img_from_path(image: impl Fn() -> PathBuf + 'static) -> Img {
    let image = image::open(&image()).ok();
    let width = image.as_ref().map_or(0, |img| img.width());
    let height = image.as_ref().map_or(0, |img| img.height());
    let data = Arc::new(image.map_or(Default::default(), |img| img.into_rgba8().into_vec()));
    let blob = Blob::new(data);
    let image = peniko::Image::new(blob, peniko::Format::Rgba8, width, height);
    img_dynamic(move || image.clone())
}

pub fn img_from_image(image: impl Fn() -> peniko::Image + 'static) -> Img {
    img_dynamic(move || image())
}


Controller for URP forms

Implement the necessary function that each API route uses in a controller file for the URP form API.

Resolved


Explicity load linux shared libraries with dlopen

NativeLibraryManager was able to load all of my windows shared libraries, but I was not able to load dependency trees of linux shared libraries.  This patch makes the linux library loading more robust using dlopen.
Suppose you have a package A -- libA.so depends on libB.so and libC.so, and B depends on libD.so.  This modification allows that shared library dependency tree to load under linux.  There is a caveat that should be mentioned on the tutorial pages though.  The libraries with dependencies must occur last in the libManager file list -- order is important.  Use ldd to see the dependencies so they can be put in the right order.
Example.
var accessor = new ResourceAccessor(Assembly.GetExecutingAssembly());
var libManager = new LibraryManager(
Assembly.GetExecutingAssembly(),
new LibraryItem(Platform.Windows, Bitness.x64,
new LibraryFile("A.dll", accessor.Binary("A.dll")),
new LibraryFile("AMath.dll", accessor.Binary("AMath.dll")),
new LibraryFile("B.dll", accessor.Binary("B.dll"))),
new LibraryItem(Platform.Linux, Bitness.x64,
new LibraryFile("libD.so", accessor.Binary("libD.so")),
new LibraryFile("libC.so", accessor.Binary("libC.so")),
new LibraryFile("libB.so", accessor.Binary("libB.so")),
new LibraryFile("libAMath.so", accessor.Binary("libAMath.so")),
new LibraryFile("libA.so", accessor.Binary("libA.so"))));
libManager.LoadNativeLibrary();
The Embedded resource tags in the csproj needs to have all those libraries.

Thank you for your pull request! Sorry it took some time to get around to it :)


Support compressed (deflate) payload

See: RFC 7516 4.1.3
I am working with:

Smart Health Cards - Overview
Smart Health Cards - Specification

in Ruby.
I'm working in a constrained Ruby environment (Rhomobile platform) and ruby-jwt is well-suited for the environment since it has few dependencies. (I've used ruby-jwt before to implement openid-connect in that environment.)
Smart Health Cards are jws with I think only a small twist: the payload is compressed with DEFLATE. The signature is over the Base64 header and payload. But the payload is opaque to ruby-jwt, and it will fail trying verify claims because the payload is unintelligible to ruby-jwt.
FWIW, headers look something like:
{"zip":"DEF","alg":"ES256","kid":"7JvktUpf1_9NPwdM-70FJT3YdyTiSe2IvmVxxgDSRb0"}

Above is as implemented by California Department of Public Health for their digital Covid immunization records. (Yes the kid is real, it's no secret it's the kid of the current/only public key.)
May not take a lot to support. To read/verify, for example, would require inflating the payload after decoding the Base64, but before parsing the JSON, while still using the raw Base64 header and payload for computing the signature for signature verification. Have not examined creation/signing, as it's not something I need to do.
I've worked around for now by just using ad-hoc code and OpenSSL without ruby-jwt objects, though I do use JWT::SecurityUtils lightly. But I would love to use ruby-jwt.
Since I didn't get far with ruby-jwt I'm unclear how well supported EC is. There could be variations in the format, including possibly certificate chain.
I don't know if there are other use cases where payloads are compressed like this?
Is there an interest in supporting compressed payloads?
Willing to implement and/or help. I'd rather see this incorporated into ruby-jwt rather than making my own variant, and would be good to discuss.
Edit: I updated with RFC7516 4.1.3 reference. I left my original commentary, because Smart Health Cards are now emerging the real world, and I think may become one of the first popular use cases for compressed payload? The compression is done because these are encoded into QR Code images as one embodiment, and it makes quite a dense QR even with the compression.

I notice that RFC7515 - the JWS spec - does not provide for compression. 7516 is JWE. Not sure how the standards mesh.
Smart Health Cards use a compressed payload but they are not JWE, they are JWS.

Im wondering if the jwt gem is the correct place to implement the actual deflating. Maybe this gem could have a way to inject behaviour into the decoding pipeline would make sense that then could be handled in a separate JWE gem?
Would also like to move the JWK handling out of this gem into something that can be plugged into this gem.
I think the EC support is on a semi-good level when not counting some unresolved incompatibilities with some other JWT components (#412).

I've done a bit more research, and zip:deflate is not a standardized public header for JWS. (But it is for JWE).
In the context of Smart Health Cards, it is used as a private header, which is permitted.
This discussion is helpful and relevant: smart-on-fhir/health-cards Issue 128

Like the idea of making a context specific gem extending the behaviour of ruby-jwt
I could help with playing around with ideas on how to get the decode process extended. The current API is already pretty bloated so i guess that even yet another option will not make it worse, but let's see. Would you be interested in helping out with this one @jtara, it's always easier to get stuff done if there is someone giving feedback and contributing?

Left something in that #434. Not even close to production ready, but maybe a path that could be taken?

@jtara I've played around with the idea a little more. Would appreciate some input on #460. Got a simple Smart Health Card use case working with the capabilities implemented: https://github.com/jwt/ruby-jwt/pull/460/files#diff-d8d789567978973190503f1f875cbc6a0b6e53a3dc37946ea992bba213282761

Would appreciate some input on #460. Got a simple Smart Health Card use case working

Cool!  Thanks for doing this, @anakinj!  I have a similar use case to @jtara, and will try to take a look at this, and let you know how it goes.


[loc][Query][vscode-cmake-tools] Localizability of 0; "./src/kit.successfully.loaded.kits"

Hello developers,
please help localization team to answer question from translator.
In case translator is not sure about context/meaning/localizability of string we raise a question.
Source:
Successfully loaded {0} kits from {1}
File Name:
Src\vscode-extensions\vscode-cmake-tools.xlf
Query:
Please, define placeholders in order to help with translation.

{0} is a number
{1} is a file path


sub-site assets

assets are included through relative URLs ... which can break for project sites. Same issue dealt with in PR #4.
I'll PR a fix for this eventually.

Let's go ahead and add these into the new cdn.llnl.gov that I've been building up. I can point you to that repo (it is internal).

Is cdn.llnl.gov behind the firewall? I can't get to it right now from home.

No, I was just able to get to it on my phone... maybe a minor glitch?


Add test for add variant to cart

adding a test of adding a variant to the cart
adding data-testid to elements
standardization of the names of exports
adding waitForSearchedProducts to the search test

Task linked: SALEOR-7521 Add test for SRS_0202 should select a variant and add a product to the chart

Sorry, this PR was closed automatically due to us reorganising the repo. Would you mind reapplying your changes? Thanks for the contribution!