Properly handle dict loading with error handling, etc. - ROUND 2

Round 2 for this.
Basically, we have the advanced load_pickle, and it works if there's pickles existing.  If there's no pickle files existing, it seems to properly handle "empty" or "invalid" pickles and returns the proper empty list or dict objects.  This seems to work fine, and TCoM was running and restarted a handful of times without a repeat of the issues saw yesterday by the same approaches.

Codecov Report

Merging #963 into master will increase coverage by 0.59%.
The diff coverage is 3.22%.

@@            Coverage Diff             @@
##           master     #963      +/-   ##
==========================================
+ Coverage   63.48%   64.07%   +0.59%
==========================================
  Files           6        6
  Lines        1780     1765      -15
==========================================
+ Hits         1130     1131       +1
+ Misses        650      634      -16

Impacted Files
Coverage Δ

datahandling.py
54.63% <3.22%> (+2.8%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b8cca8...6628070. Read the comment docs.

@tripleee Can you review again and adjust your review status please?  I made additional changes.

!!/approve


fix(makemarkdown.table): col text align right

fix for html columns align right. currently hmtl cols
with align right get converted to md with align center
e.g. html
head
get converted to
:---: (suddenly center)
this pull request fixes that bug
Closes #689

@loveTheSource Thank you for the PR! Can you add a test case to this file as well?


Scipy Dependency

Discussion
Now I'm trying to introduce CMA-ES with Margin, and I'm thinking of putting scipy dependency into this repository.
Specifically, I'd like to use chi2.ppf in the following.
https://github.com/scipy/scipy/blob/v1.9.1/scipy/stats/_continuous_distns.py#L1343-L1407
It might be possible to implement chi2.ppf without scipy, it seems to be a bit difficult (at least for me).
Optuna, which employs this repository for using CMA-ES, already requires scipy, so I think this doesn't a problem.
https://github.com/optuna/optuna/blob/master/setup.py#L39

What do you think? @c-bata

As for Optuna, we are currently considering removing scipy from the dependencies. However, I agree with the use of scipy in cmaes library :+1:
Implementing CMA-ES in Margin is much more important than removing the scipy dependency.

Ok, thanks! Btw, I can work for removing scipy in the next month (if you hope so).
When we're implementing it from scratch, I think it is better to compare the accuracy and computational time with scipy.

I can work for removing scipy in the next month (if you hope so). When we're implementing it from scratch, I think it is better to compare the accuracy and computational time with scipy.

Sounds great 👍 Yes, we should compare the accuracy though.

@amylase is working on this issue on https://github.com/CyberAgentAILab/cmaes/pull/126


"Cocu" is listed in the drop-down menu

Description:
"Cocu" is listed in the drop-down menu alongside its corresponding county and commune, according to the law
Precondition:
The website is up an running.

Step 1
Type "Cocu" in the search bar.

Expected results
The location is listed in the drop-down menu as "Cocu, Argeș".


[IMPROVEMENT] Provide more information for volume scheduling failure

Is your improvement request related to a feature? Please describe (👍 if you like this request)
When a user encounters a volume scheduling failure, it can be challenging to pinpoint the specific cause of the issue from the UI message. We've already added the cause in the PV annotation longhorn.io/volume-scheduling-error. This can make the user experience better by showing the error along with the Replica Scheduling Failure message.

Describe the solution you'd like

Describe alternatives you've considered

Additional context

cc @smallteeths

Verified pass on longhorn-master(longhorn-ui 1b2b2d)
When a volume scheduling failure, UI will show more information about the failure reason


Test instructions in README are stale

I'm not sure how to run the tests any longer, and the directions in the README are no longer correct.
This is what I tried to do, without success:
jackjennings:fontParts ▹ pip install -e .
Obtaining file:///Users/jackjennings/src/fontParts
Installing collected packages: fontParts
  Running setup.py develop for fontParts
Successfully installed fontParts
You are using pip version 8.1.1, however version 8.1.2 is available.
You should consider upgrading via the 'pip install --upgrade pip' command.
jackjennings:fontParts ▹ python Lib/fontParts/nonelab/test.py
Traceback (most recent call last):
  File "Lib/fontParts/nonelab/test.py", line 1, in <module>
    from fontParts.test import testEnvironment
ImportError: No module named fontParts.test

Yeah, the whole readme is out of date. (That's a weird traceback as that module does exist.)

Updated with d96940c3c7251bf14404a7281eacfcad58d1a99e - a1f56c1496633ef2b3990e1bcad8b7fbbdb2b049. I'm going to leave this issue open as a reminder tgo document how to run the test suite.

@jackjennings the Test module wasn't part of the setup script until four days ago (https://github.com/robofab-developers/fontParts/commit/a20b7b5ea630578628d9cb1b12dbe322a4e64f3e) so that may be the issue there.

This got more clear with https://github.com/robofab-developers/fontParts/commit/ddf9344bf6e9fef752104d7306351ad338c184fc. Closing.


get_elements_or_none_by_xpath bug - uses CSS_SELECTOR instead of XPATH

I believe there was an oversight issue of using the wrong By. ENUM parameter for this function.
file: anti_detect_driver.py
def get_elements_or_none_by_xpath(self: WebDriver, xpath, wait=Wait.SHORT):
        try:
            if wait is None:
                return self.find_elements(By.XPATH, xpath)
            else:
                WebDriverWait(self, wait).until(
                    EC.presence_of_element_located((By.CSS_SELECTOR, xpath))
                )

                return self.find_elements(By.XPATH, xpath)
        except:
            return None

the line
EC.presence_of_element_located((By.CSS_SELECTOR, xpath))
should be changed to:
EC.presence_of_element_located((By.XPATH, xpath))

Thanks, will fix in upcoming release

fixes


Created Python Programming Language Cheatsheet

I have created a file in which I have mentioned some quick methods and features that are available in Python programming language

This is so very incomplete.

@thewolfcommander put some more effort in it ✌ check what others have done and covered in their sheets and I am sure yours will be a worthy python sheet to have.

@thewolfcommander put some more effort in it  check what others have done and covered in their sheets and I am sure yours will be a worthy python sheet to have.

Sure will improve the sheet to meet the needs. Thanks for the review btw.

@thewolfcommander When it will be more complete, I will be happy to merge this. 👍


[Feature] support instance_aware_colorization inference

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
Support instance_aware_colorization inference mentioned in https://github.com/open-mmlab/mmediting/issues/1247
Modification

[x]  built upon  https://github.com/open-mmlab/mmediting/pull/1173
[x] use mmdet instead of detectron
[x] add docstring
[x] add uni tests

Who can help? @ them here!
BC-breaking (Optional)
Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.
Checklist
Before PR:

[x] I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
[x] Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
[ ] Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
[ ] New functionalities are covered by complete unit tests. If not, please add more unit test to ensure the correctness.
[ ] The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

[x] If the modification has potential influence on downstream or other related projects, this PR should be tested with some of those projects.
[x] CLA has been signed and all committers have signed the CLA in this PR.


Drop browsersync completely in production build

Why in npm run build we still use browsersync? browsersync make sense for development. I deployed my app by running npm run build, expect everything to worked, but I saw movement on my app without me clicking anything, then I realised it was caused by browsersync.
What's the purpose of browsersync in production and how to turn it off? just comment the config in tools/disServer.js ?

Slingshot generates static files to the dist folder. Browsersync is just set up so that you can run the production build on your local machine for review. For production, you should use a traditional web server to serve the static files written to /dist. So your deployment process really just needs to copy the files in /dist to your prod webserver.

traditional server means? I usually use ubuntu and nginx for SAP with node.

Tried to get ampp for a quick test, I place files in dist folder and run index.html, I got this error
https://i.imgur.com/iqZ6T7e.png
any clue?

Serve the app from web root instead of a subfolder and it'll work

localhost/react is the web root, I create a react folder to hold those files.

oh ya placing it in a folder won't work, have to put those file in the root. Got it, thanks for the help Cory!

But I still curios, is there anyway I can turn off browsersync?

Here are some recommendations on how to remove browsersync  - https://github.com/coryhouse/react-slingshot/issues/477

@kwelch Couldn't click the link, typo?

Not sure it works on my end. You can also look up react-slingshot issue #477

Works on my end too.

@kwelch @nickytonline the link redirect me to the same page, https://drive.google.com/file/d/0B89f1Cq6M9EQcnNkc1ZGclVManc/view

The link is for #477, which is https://github.com/coryhouse/react-slingshot/issues/477

@nickytonline I'm seeing my own issue https://i.imgur.com/YHbsVFP.png

@kwelch, we are silly. I think you meant to say issue https://github.com/coryhouse/react-slingshot/issues/474 ?

@mikedevita Thanks for sharing, do you do any automation in step 4? It's tedious to copy manually to server.

unfortunately no I don't. not even aware if there is an automated process for that part. typically we use http-proxy-middleware and reverse proxy to the sap back end during development. that way we only push to sap when were ready for a release and we know the UI is good to go.
I'm at SAP TechEd right now but shoot me an email Mike.devita<EMAIL_ADDRESS>if you need further help since this is out of this kits scope and I'd hate to clutter the issue up with SAP stuff 😜.


Add support for automated handling of Android 6+ security alerts

Android Marshmallow and higher has introduced a new feature - per-application permission settings. In UI these are visible as standard alerts with DENY/ALLOW buttons upon the AUT triggers any action, that requires the appropriate permission. It would be very convenient to have an option in Selendroid to automatically detect and allow/deny such alerts implicitly, so we can keep our existing tests for older platforms unchanged.

has anyone worked this out ?


[ISSUE #2969] Add a skip accumulation message command in mqadmin.

Make sure set the target branch to develop
What is the purpose of the change
#2969
Brief changelog
XX
Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

[x] Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[x] Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
[x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
[x] Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test  to make sure integration-test pass.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

Coverage increased (+0.2%) to 53.967% when pulling 13f561ba87ecfe062613ac63e23249627d2cf40e on zhangjidi2016:add_skipAccumulatedMessage_command into 5e99cdbeb7d56a46059ca83923a12b9a0d80cece on apache:develop.

Codecov Report

Merging #2970 (13f561b) into develop (5e99cdb) will decrease coverage by 0.17%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             develop    #2970      +/-   ##
=============================================
- Coverage      47.98%   47.81%   -0.18%
+ Complexity      4567     4551      -16
=============================================
  Files            552      552
  Lines          36628    36628
  Branches        4844     4844
=============================================
- Hits           17577    17514      -63
- Misses         16831    16883      +52
- Partials        2220     2231      +11

Impacted Files
Coverage Δ

...apache/rocketmq/client/trace/TraceDataEncoder.java
54.30% <0.00%> (-15.24%)
:arrow_down:

...org/apache/rocketmq/common/stats/StatsItemSet.java
43.28% <0.00%> (-8.96%)
:arrow_down:

...a/org/apache/rocketmq/logging/inner/SysLogger.java
28.57% <0.00%> (-5.72%)
:arrow_down:

...in/java/org/apache/rocketmq/test/util/MQAdmin.java
38.88% <0.00%> (-5.56%)
:arrow_down:

...ketmq/client/impl/consumer/PullMessageService.java
75.55% <0.00%> (-4.45%)
:arrow_down:

...java/org/apache/rocketmq/logging/inner/Logger.java
51.67% <0.00%> (-4.31%)
:arrow_down:

...ava/org/apache/rocketmq/test/util/VerifyUtils.java
46.26% <0.00%> (-2.99%)
:arrow_down:

...ava/org/apache/rocketmq/filter/util/BitsArray.java
59.82% <0.00%> (-2.57%)
:arrow_down:

...ache/rocketmq/store/AllocateMappedFileService.java
39.02% <0.00%> (-2.44%)
:arrow_down:

...org/apache/rocketmq/client/trace/TraceContext.java
72.91% <0.00%> (-2.09%)
:arrow_down:

... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e99cdb...13f561b. Read the comment docs.

LGTM

can we close the issue #2969 ?


Naming convention for paper related repos

Suggestions of naming conventions:

author1_author2_author3_date
title_of_the_paper
free for all

@jcohenadad

i've often seen paper repos written with "paper_XX", XX being an obvious identifier for the paper. Eg in your case, something like: paper_softseg

article_softseg looks good to me @charleygros  what do you think?

Oh Yeahh! paper_softseg sounds great


support comments

lines starting with / should be ignored

https://github.com/opensourceame/skimpy/blob/d5e8829c5d40369fb674930fb9e8dc0622a319cb/skimpy/skimpy.py#L47-L48


notification.Push() doesn't appear to work on Windows 11

There are no errors or crashes but the notification does not get pushed.

I wasn't running my code as Administrator


New Deployment Center

Deployment Centers has replaced the steps here for setting up CD in the Portal ...

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 5a34424e-6a23-5517-5755-c9282643876f
Version Independent ID: 1c375649-94d6-863a-203b-cb5ed5e4044e
Content: Continuous deployment for Azure Functions
Content Source: articles/azure-functions/functions-continuous-deployment.md
Service: azure-functions
GitHub Login: @ggailey777
Microsoft Alias: glenga

@KetanChawda-MSFT Can you please assign to @ColbyTresness who is working on updates to this article.

hi, after deployment from github , the azure did not build it? After I change the code, the output still keep same. How I build code from Azure?

how can i manually trigger a build/deployment from azure console?  i have a similar problem to above, commits are not triggering builds.

I believe this issue should be closed, since I updated the article with the newer deployment center UX.
I believe the two followup questions should be tracked elsewhere, not this docs issue, since they're product questions. Please reopen any questions in https://github.com/Azure/Azure-Functions

#please-close


Specify dtypes for auxiliary fields

Introduces a dictionary in dicts.py for specifying the dtype of aux fields. The default is now float32 for a space savings.
@Grimler91 it would be great to get your help with testing.

I am on vacation at the moment, will be around two weeks until I have access to data to test with (sorry for the inconvenience)

No worries, enjoy your vacation!


No header files installed on make install

Calling make install in RHash-1.3.9 installs librhash.so.0 but no rhash.h. So cmake cannot find the systems’s librhash, see https://gitlab.kitware.com/cmake/cmake/-/issues/20728#note_762319 .

There is no bug in RHash here.  Header files are installed together with static archives via install-lib-static target.  If you want it to be invoked automatically, run the configure script with the --enable-lib-static switch.  Notice that it is passed in the provided rhash.spec.in file.  If your OS/distribution does not do that, you might want to report a bug against them instead.

There is no point to install header files only with static build, as the header files are equally.needed with dynamic libraries.
I use Linux From Scratch and rhash.spec.in virtually does not exist there.

There is no point to install header files only with static build, as the header files are equally needed with dynamic libraries.

No.  Header files are needed for building consumers of a library (that's why they go with what some distributions call -dev or -devel packages).  During run-time linking, only shared libraries are needed, not headers.

I use Linux From Scratch and rhash.spec.in virtually does not exist there.

It's part of the RHash source code, the template for RPM .spec file.  I don't know how packages are managed in LFS, I've only suggested it as a reference.

In LFS there are no packages.  Only .tar.gz.

There is no differences between linking for consumers of the library and run-time linking.  When compiling software depending on librhash, one has to decide whether librhash will be linked statically or dynamically.  In both cases the header files are needed.  This is how all software distributed in source form (and especially libraries) work.
Can you provide an example of another library distributed in source code, that on make install does not install the headers ? (except nss, nspr, and llhttp)

There is no differences between linking for consumers of the library and run-time linking.

Of course there is (you've missed the building part).

This is how all software distributed in source form (and especially libraries) work.

Thank you for educating us on that. :-)  Now, if you want static libraries (object archives) and header files to be installed automatically, simply ./configure RHash with --enable-lib-static switch as suggested earlier.

omg just wow, I'd like to give it a thumbs down.
If I develop software in something else than a dumb editor and documentation alone there is a need for simple h files in every IDE. At the same time I do not want to have static libs.
Or do I miss something here? Would young pups be hurt to install the headers along the shared lib aswell?

RHash project itself is not a library project, so make install installs by default only rhash binary with its dependencies, but without (unnecessary for running) development headers, static library or the librhash.so symlink.


Decoder::skip_duration consumes the object (self, not &self)

Good evening, this function consumes the Decoder object, making it unusable to append to.

It consumes the Decoder and produce something that implements Source, specifically a SkipDuration. You can do the same with a source as you can with a decoder.
Its similarly to how iterators work (see take).

Hey @DoormatIka are you still stuck? If not could you close this Issue?

I'll close it. My apologies for not responding 😅


fix don't abort in replica write layer unless all replica fails

Proposed changes
Currently, if any replica fails in rpc layer, the load will be aborted.
This is bad when there are multiple replicas and only need quorum to success.
This PR makes the replica write layer to keep writing unless all replica fails.
The quorum logic will be handled in upper layer.
Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

run buildall


got error when I want to train with celeba dataset (AttributeError: 'NoneType' object has no attribute 'tb_lasti')

Hi, I used this command after prepared dataset python bin/train.py -cn lama-fourier-celeba data.batch_size=10 but I got this below error. Why it's happen? How I can fix it? I'm using windows os.
@windj007
### Error:
C:\ProgramData\Anaconda3\envs\pytorch171\lib\site-packages\hydra\core\default_element.py:127: UserWarning: In 'hydra/overrides': Usage of deprecated keyword in package header '# @package group'.
See https://hydra.cc/docs/next/upgrades/1.0_to_1.1/changes_to_package_header for more information
See {url} for more information"""
C:\ProgramData\Anaconda3\envs\pytorch171\lib\site-packages\hydra\core\default_element.py:127: UserWarning: In 'trainer/any_gpu_large_ssim_ddp_final_celeba': Usage of deprecated keyword in package header '# @package group'.
See https://hydra.cc/docs/next/upgrades/1.0_to_1.1/changes_to_package_header for more information
See {url} for more information"""
C:\ProgramData\Anaconda3\envs\pytorch171\lib\site-packages\hydra\core\default_element.py:127: UserWarning: In 'evaluator/default_inpainted': Usage of deprecated keyword in package header '# @package group'.
See https://hydra.cc/docs/next/upgrades/1.0_to_1.1/changes_to_package_header for more information
See {url} for more information"""
C:\ProgramData\Anaconda3\envs\pytorch171\lib\site-packages\hydra\core\default_element.py:127: UserWarning: In 'visualizer/directory': Usage of deprecated keyword in package header '# @package group'.
See https://hydra.cc/docs/next/upgrades/1.0_to_1.1/changes_to_package_header for more information
See {url} for more information"""
C:\ProgramData\Anaconda3\envs\pytorch171\lib\site-packages\hydra\core\default_element.py:127: UserWarning: In 'optimizers/default_optimizers': Usage of deprecated keyword in package header '# @package group'.
See https://hydra.cc/docs/next/upgrades/1.0_to_1.1/changes_to_package_header for more information
See {url} for more information"""
C:\ProgramData\Anaconda3\envs\pytorch171\lib\site-packages\hydra\core\default_element.py:127: UserWarning: In 'discriminator/pix2pixhd_nlayer': Usage of deprecated keyword in package header '# @package group'.
See https://hydra.cc/docs/next/upgrades/1.0_to_1.1/changes_to_package_header for more information
See {url} for more information"""
C:\ProgramData\Anaconda3\envs\pytorch171\lib\site-packages\hydra\core\default_element.py:127: UserWarning: In 'generator/ffc_resnet_075': Usage of deprecated keyword in package header '# @package group'.
See https://hydra.cc/docs/next/upgrades/1.0_to_1.1/changes_to_package_header for more information
See {url} for more information"""
C:\ProgramData\Anaconda3\envs\pytorch171\lib\site-packages\hydra\core\default_element.py:127: UserWarning: In 'data/abl-04-256-mh-dist-celeba': Usage of deprecated keyword in package header '# @package group'.
See https://hydra.cc/docs/next/upgrades/1.0_to_1.1/changes_to_package_header for more information
See {url} for more information"""
C:\ProgramData\Anaconda3\envs\pytorch171\lib\site-packages\hydra\core\default_element.py:127: UserWarning: In 'location/docker': Usage of deprecated keyword in package header '# @package group'.
See https://hydra.cc/docs/next/upgrades/1.0_to_1.1/changes_to_package_header for more information
See {url} for more information"""
C:\ProgramData\Anaconda3\envs\pytorch171\lib\site-packages\omegaconf\resolvers_init_.py:13: UserWarning: The env resolver is deprecated, see https://github.com/omry/omegaconf/issues/573
"The env resolver is deprecated, see https://github.com/omry/omegaconf/issues/573"
Traceback (most recent call last):
File "C:\ProgramData\Anaconda3\envs\pytorch171\lib\site-packages\hydra_internal\utils.py", line 211, in run_and_report
return func()
File "C:\ProgramData\Anaconda3\envs\pytorch171\lib\site-packages\hydra_internal\utils.py", line 371, in
overrides=args.overrides,
File "C:\ProgramData\Anaconda3\envs\pytorch171\lib\site-packages\hydra_internal\hydra.py", line 105, in run
configure_logging=with_log_configuration,
File "C:\ProgramData\Anaconda3\envs\pytorch171\lib\site-packages\hydra\core\utils.py", line 122, in run_job
working_dir = str(OmegaConf.select(config, job_dir_key))
File "C:\ProgramData\Anaconda3\envs\pytorch171\lib\site-packages\omegaconf\omegaconf.py", line 691, in select
format_and_raise(node=cfg, key=key, value=None, cause=e, msg=str(e))
File "C:\ProgramData\Anaconda3\envs\pytorch171\lib\site-packages\omegaconf_utils.py", line 821, in format_and_raise
_raise(ex, cause)
File "C:\ProgramData\Anaconda3\envs\pytorch171\lib\site-packages\omegaconf_utils.py", line 719, in _raise
raise ex.with_traceback(sys.exc_info()[2])  # set end OC_CAUSE=1 for full backtrace
File "C:\ProgramData\Anaconda3\envs\pytorch171\lib\site-packages\omegaconf\omegaconf.py", line 688, in select
throw_on_missing=throw_on_missing,
File "C:\ProgramData\Anaconda3\envs\pytorch171\lib\site-packages\omegaconf_impl.py", line 63, in select_value
absolute_key=absolute_key,
File "C:\ProgramData\Anaconda3\envs\pytorch171\lib\site-packages\omegaconf_impl.py", line 96, in select_node
throw_on_resolution_failure=throw_on_resolution_failure,
File "C:\ProgramData\Anaconda3\envs\pytorch171\lib\site-packages\omegaconf\base.py", line 434, in _select_impl
memo=memo,
File "C:\ProgramData\Anaconda3\envs\pytorch171\lib\site-packages\omegaconf\base.py", line 622, in _maybe_resolve_interpolation
memo=memo if memo is not None else set(),
File "C:\ProgramData\Anaconda3\envs\pytorch171\lib\site-packages\omegaconf\base.py", line 483, in _resolve_interpolation_from_parse_tree
parse_tree=parse_tree, node=value, key=key, parent=parent, memo=memo
File "C:\ProgramData\Anaconda3\envs\pytorch171\lib\site-packages\omegaconf\base.py", line 669, in resolve_parse_tree
).with_traceback(sys.exc_info()[2])
File "C:\ProgramData\Anaconda3\envs\pytorch171\lib\site-packages\omegaconf\base.py", line 662, in resolve_parse_tree
return visitor.visit(parse_tree)
File "C:\ProgramData\Anaconda3\envs\pytorch171\lib\site-packages\antlr4\tree\Tree.py", line 34, in visit
return tree.accept(self)
File "C:\ProgramData\Anaconda3\envs\pytorch171\lib\site-packages\omegaconf\grammar\gen\OmegaConfGrammarParser.py", line 205, in accept
return visitor.visitConfigValue(self)
File "C:\ProgramData\Anaconda3\envs\pytorch171\lib\site-packages\omegaconf\grammar_visitor.py", line 101, in visitConfigValue
return self.visit(ctx.getChild(0))
File "C:\ProgramData\Anaconda3\envs\pytorch171\lib\site-packages\antlr4\tree\Tree.py", line 34, in visit
return tree.accept(self)
File "C:\ProgramData\Anaconda3\envs\pytorch171\lib\site-packages\omegaconf\grammar\gen\OmegaConfGrammarParser.py", line 339, in accept
return visitor.visitText(self)
File "C:\ProgramData\Anaconda3\envs\pytorch171\lib\site-packages\omegaconf\grammar_visitor.py", line 301, in visitText
return self._unescape(list(ctx.getChildren()))
File "C:\ProgramData\Anaconda3\envs\pytorch171\lib\site-packages\omegaconf\grammar_visitor.py", line 389, in _unescape
text = str(self.visitInterpolation(node))
File "C:\ProgramData\Anaconda3\envs\pytorch171\lib\site-packages\omegaconf\grammar_visitor.py", line 125, in visitInterpolation
return self.visit(ctx.getChild(0))
File "C:\ProgramData\Anaconda3\envs\pytorch171\lib\site-packages\antlr4\tree\Tree.py", line 34, in visit
return tree.accept(self)
File "C:\ProgramData\Anaconda3\envs\pytorch171\lib\site-packages\omegaconf\grammar\gen\OmegaConfGrammarParser.py", line 1030, in accept
return visitor.visitInterpolationResolver(self)
File "C:\ProgramData\Anaconda3\envs\pytorch171\lib\site-packages\omegaconf\grammar_visitor.py", line 182, in visitInterpolationResolver
args_str=tuple(args_str),
File "C:\ProgramData\Anaconda3\envs\pytorch171\lib\site-packages\omegaconf\base.py", line 653, in resolver_interpolation_callback
inter_args_str=args_str,
File "C:\ProgramData\Anaconda3\envs\pytorch171\lib\site-packages\omegaconf\base.py", line 596, in evaluate_custom_resolver
inter_args_str,
File "C:\ProgramData\Anaconda3\envs\pytorch171\lib\site-packages\omegaconf\omegaconf.py", line 355, in resolver_wrapper
val = cache[key] if key in cache else resolver(*args_unesc)
File "C:\ProgramData\Anaconda3\envs\pytorch171\lib\site-packages\omegaconf\resolvers_init.py", line 22, in env
raise ValidationError(f"Environment variable '{key}' not found")
omegaconf.errors.InterpolationResolutionError: ValidationError raised while resolving interpolation: Environment variable 'USER' not found
full_key: hydra.run.dir
object_type=dict
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "bin/train.py", line 72, in
main()
File "G:\codes\lama-main\saicinpainting\utils.py", line 163, in new_main
main_func(*args, **kwargs)
File "C:\ProgramData\Anaconda3\envs\pytorch171\lib\site-packages\hydra\main.py", line 53, in decorated_main
config_name=config_name,
File "C:\ProgramData\Anaconda3\envs\pytorch171\lib\site-packages\hydra_internal\utils.py", line 368, in _run_hydra
lambda: hydra.run(
File "C:\ProgramData\Anaconda3\envs\pytorch171\lib\site-packages\hydra_internal\utils.py", line 270, in run_and_report
cur.tb_lasti = iter_tb.tb_lasti
AttributeError: 'NoneType' object has no attribute 'tb_lasti'

I also have the same error when I'm trying to run train.py. I appreciate any help to solve this error.

Hi! Set USER environment variable to any value, see this issue. You're trying to train, so you might also need TORCH_HOME environment (this issue).
I do not have a Windows machine, so I cannot test the code under Windows. It might worth trying Windows Linux Subsystem - the easiest way to use Linux from a Windows machine - many open source machine learning tools work better under Linux.

I've tested the code on windows. It works perfectly.

I've tested the code on windows. It works perfectly.

Hi，How do you solve this problem on Windows?

I got a problom like this. Did you solve this problem?
Training failed due to "'Box' object has no attribute 'visualizer'":
Traceback (most recent call last):
File "box\box.py", line 504, in box.box.Box.getitem
KeyError: 'visualizer'
The above exception was the direct cause of the following exception:
Traceback (most recent call last):
File "box\box.py", line 537, in box.box.Box.getattr
File "box\box.py", line 525, in box.box.Box.getitem
box.exceptions.BoxKeyError: "'visualizer'"
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "box\box.py", line 539, in box.box.Box.getattr
AttributeError: 'Box' object has no attribute 'visualizer'
The above exception was the direct cause of the following exception:
Traceback (most recent call last):
File "D:\jsc\LAMA\lama-main\bin\train.py", line 44, in main
config.visualizer.outdir = os.path.join(os.getcwd(), config.visualizer.outdir)
File "box\box.py", line 553, in box.box.Box.getattr
box.exceptions.BoxKeyError: "'Box' object has no attribute 'visualizer'"

I got a problom like this. Did you solve this problem? Training failed due to "'Box' object has no attribute 'visualizer'": Traceback (most recent call last): File "box\box.py", line 504, in box.box.Box.getitem KeyError: 'visualizer'
The above exception was the direct cause of the following exception:
Traceback (most recent call last): File "box\box.py", line 537, in box.box.Box.getattr File "box\box.py", line 525, in box.box.Box.getitem box.exceptions.BoxKeyError: "'visualizer'"
During handling of the above exception, another exception occurred:
Traceback (most recent call last): File "box\box.py", line 539, in box.box.Box.getattr AttributeError: 'Box' object has no attribute 'visualizer'
The above exception was the direct cause of the following exception:
Traceback (most recent call last): File "D:\jsc\LAMA\lama-main\bin\train.py", line 44, in main config.visualizer.outdir = os.path.join(os.getcwd(), config.visualizer.outdir) File "box\box.py", line 553, in box.box.Box.getattr box.exceptions.BoxKeyError: "'Box' object has no attribute 'visualizer'"

Hello, Did you solve this problem? I met the same problem.


gpt 4o pricing incorrect

Issue you'd like to raise.
Openai recently halved their gpt 4o pricing, and the new pricing is updated in langsmith yet.
Suggestion:
No response

Thank you for flagging!


Include an absolute path file.

I've been checking the code and it doesn't seem possible to include a file with absolute path. Is there any alternative in this regard ?
The code always gathers the file paths relative to the settings it calls include.
pattern = os.path.join(conf_path, conf_file)

Thanks for raising this question!
I would love to know more about your use-case. Why do you need the absolute path?

In my case it would be for plugins to be able to add configuration files without being in the main package.

Do you mean something like https://docs.djangoproject.com/en/3.0/ref/applications/#configuring-applications ?

Is not it. Plugins settings is loaded and added to the main project settings at startup.

Django boot
Load settings
---- Load plugins
---- Loaf plugins settings (add abs path)

A simple os.path.isabs(conf_file) check already solves this issue.
    for conf_file, __name in args:
        saved_included_file = scope.get('__included_file__')
        if not os.path.isabs(conf_file):
            pattern = os.path.join(conf_path, conf_file)
        else:
            pattern = conf_file
        # find files per pattern, raise an error if not found (unless file is
        # optional)
        files_to_include = glob.glob(pattern)
        if not files_to_include and not isinstance(conf_file, _Optional):
            raise IOError('No such file: {}'.format(pattern))

The thing is that I don't want to add a core support for this case. Why?
 It is guaranteed not to work as someone expects.
So, I would like to find any other ways to help you in your extraordinary use-case.

ok


Integrate the plugin into another plugin

Hello
I want to develop a plugin that gets grades, except that I do not see how to recover those ... How to do?

Use the API, documentation for it is here: https://github.com/lucko/LuckPerms/wiki/Developer-API


asynchronous file io and terminal logic

This PR wants to move the terminal logic and the file I/O with the pty into a separate Isolate.
The reason for this is that this way we can better scale to have multiple terminal instances that might get slower in processing data when the machine gets near its limit but doesn't slow down the UI Isolate.
There are a couple of decisions to make, big and small. This PR already did some of them but I as this is WIP currently everything can (and should) be discussed.
1. Pty connection
The challenge here was to have the backend of the terminal configurable and also have it being executed in the terminal Isolate.
The approach I have chosen is to introduce a TerminalBackend interface. The instance of this interface given to the TerminalIsolate is passed into the Terminal Isolate.
This only works when there are no closures in the backend instance at the time of passing. I achieved this by doing a late initialization when the backend has been passed already.
The problem here is that this introduces a complexity to the user (as this is the place where currently the backend has to be implemented. There pty and xterm come together) that we might not want to have there. It leaks the Isolate complexity to the user.
I sadly don't have a better idea than this or making the concrete possible backends known in the xterm project (much less flexibility)
2. Terminal isolate data exchange
I have a branch that does the fyi-heap trick but my tests have shown that this doesn't really improve the performance much so that I decided that the PR uses the "plain" Dart approach.
As we already have a ByteData per line that contains all the data as state that has to be copied the only advantage the manual ffi-heap approach would bring that we can control exactly the number of bytes copied (use trimmed length as an indicator)
I think this is something that should be discussed. The branch that contains the ffi approach can be found here:
https://github.com/devmil/xterm.dart/tree/async-io-and-terminal-logic-ffi-data
3. Pty kind
We have currently two kinds of pty: blocking and polling. Both don't really fit this use case:
Blocking creates its own isolate and doesn't lead to throttling down when the machine comes to its limit as the isolate is fetching new data regardless if the data transfer events towards the terminal isolate pile up => no throttling
The polling ffi is currently using a timer to trigger the polling. This timer has been set to 15ms which can be quite long (e.g. for cmatrix -r). I reduced it to 1ms to improve the experience. This approach leads to throttling as the data fetching happens in the same Isolate as the file reading.
Doesn't yet feel like we already have the best overall solution here.
4. Pty communication
I decided to route any pty communication via the terminal. There was no real other option as we don't have access to the pty when it runs in a separate isolate.
So given the TerminalBackend interface the Terminal does route data writes and resize events to the backend and it is also responsible for watching the exitCode Future.
The Terminal registers itself with the out stream of the backend.
The only thing the user has to do is to pass the backend to the Terminal. There rest happens automatically.
5. Choice
I think we should export the Terminal and the TerminalIsolate even if it makes the API more complex.
There will be use cases that need the Terminal directly because they might want to more deeply interact with the backend (like the SSH example) whereas the direct pty connection should be capable of processing data as much as possible without making the UI sluggish.
Matching pty PR: https://github.com/TerminalStudio/pty/pull/6
Matching studio PR: https://github.com/TerminalStudio/studio/pull/1

Would there be more possibilities if we have something like mutex? It seems not too hard to implement mutex with dart:ffi.

Would there be more possibilities if we have something like mutex? It seems not too hard to implement mutex with dart:ffi.

Possibilities in terms of what exactly?
Mutex might help to avoid the data copy step but I think in our case that would not help as we would have to sync on a valid buffer state.

I tried this version. It works fine when running find /, but when running cmatrix or cmatrix -r, cpu usage of studio doubled. I tried to use Dart Observatory to figure out what happened.

It looks like the overhead come from isolate communication.

With mutex, we can create a TerminalState every time paint() is called rather than every time the terminal changes(which is more frequent).
My imagination(not complete, just to show the skeleton):
/// Minimum information that TerminalView needs to render a frame.
abstract class TerminalFrame {
  int get cursorX;
  int get cursorY;
  int get height;
  int get width;
  List<BufferLine> get lines;
}

/// Contains the state of a terminal.
class TerminalState implements TerminalFrame {
  late int cursorX;
  late int cursorY;
  late int height;
  late int width;
  late Buffer buffer;
  // and more ...

  List<BufferLine> get lines {
    return buffer.getVisibleLines;
  }

  void toFrame() {
    return this;
  }
}

/// A native version of [TerminalStateNative] that can be accessed by both the UI thread and the isolate
class TerminalStateNative extends ffi.Struct implements TerminalState {
  @ffi.Int32()
  late int cursorX;

  @ffi.Int32()
  late int cursorY;

  @ffi.Int32()
  late int height;

  @ffi.Int32()
  late int width;

  late BufferNative buffer;
  // and more ...

  void toFrame() {
    mutex.lock();

    final result = TerminalFrameNative(
      cursorX: cursorX,
      cursorY: cursorY,
      // ...
    );

    mutex.unlock();

    return result;
  }
}

mixin TerminalInteractions on TerminalState {
  void write(String data) {
    // ...
  }

  void resize(int height, int width) {
    // ...
  }

  // ...
}

class Terminal = TerminalState with TerminalInteractions;

class TerminalNative = TerminalStateNative with TerminalInteractions;

and when painting a frame:
class TerminalPainter extends CustomPainter {
  void paint(...) {
    final frame = terminalState.toFrame();
    for (var line in frame.lines) {
      // ...
    }
  }
}

Wouldn't that be basically the ffi variant that I linked with the difference that the copy operation is happening on demand?

Another idea would be to change the way the terminal state is requested.
Currently the isolate requests a new state each time it gets a changed event.
We could change that so that we requested a new state whenever the zu is finished with its frame. As the request already checks if there are any changes and omits the request when there are none this might be the better solution to sync the state copy frequency with the zu update frequency.

To avoid that we would have to wait for the buffer manipulation being ready which might slow down the ui thread (and link it to the terminal logic).

Yes, I've also considered this problem. Currently most operating systems has pty buffer smaller than 20kb, which could be processed by the Terminal in less than 1ms. So I think the ui thread won't be slowed down so much.

May I ask what 'zu' refers to?

May I ask what 'zu' refers to? @devmil

Ui. Was typing on my phone and the autocorrection tries to make German words out of my text 😀

We could change that so that we requested a new state whenever the ui is finished with its frame. As the request already checks if there are any changes and omits the request when there are none this might be the better solution to sync the state copy frequency with the zu update frequency.

You mean requesting a new state after a frame is painted?

We could change that so that we requested a new state whenever the ui is finished with its frame. As the request already checks if there are any changes and omits the request when there are none this might be the better solution to sync the state copy frequency with the zu update frequency.

You mean requesting a new state after a frame is painted?

More a schedule of the request to happen when a frame is finished. Not sure yet what the best API for this would be in Flutter.
I could imagine that the TerminalIsolate can get a Function(Function() request) that in the default case directly executes the request and in our case would post executing request to the Flutter system to be executed after the current frame.

Maybe SchedulerBinding.instance!.addPostFrameCallback is what you are looking for?

More a schedule of the request to happen when a frame is finished. Not sure yet what the best API for this would be in Flutter.

Did you mean once a request is sent, never send another request until a frame is painted?

It seems to me that this is feasible. And perhaps we can further modify terminalMain so that it doesn't send 'notify' again until a state is sent.

As to pty kind, the polling one uses ~10% of a cpu core on my machine even it's idle. When we have 5 terminal windows, it will use half of a cpu core while doing nothing, so I think it's not the choice. Perhaps we can use this package I just created and a counter variable to throttle the blocking pty. When we have too many data chunks piled up, we can lock the pty isolate until they are consumed.

Maybe SchedulerBinding.instance!.addPostFrameCallback is what you are looking for?

This seems only to work when a frame is currently built.
I pushed a change that uses a Ticker to handle that. Have to test if this works as intended

Maybe SchedulerBinding.instance!.addPostFrameCallback is what you are looking for?

This seems to only work when a frame is currently built.
I pushed a change that uses a Ticker to handle that. Have to test if this works as intended

I replaced the Ticker approach with a much more simple direct throttling in the TerminalIsolate (achieved via EventDebouncer). This approach makes the API for the user much easier (no need to do the frame sync on user side) and allows to throttle the Terminal more than to once per frame.

I tried studio with last commits and the performance is much better than before!

In this commit I made terminalIsolate send NotifyChange only once until a NewState is send.
Messages sent by terminalIsolate(before)
NotifyChange, NotifyChange, NotifyChange, ..., NotifyChange, NewState, NotifyChange, NotifyChange, ...

Messages sent by terminalIsolate(after)
NotifyChange, NewState, NotifyChange, NewState, NotifyChange, NewState

This reduces CPU usage of cmatrix -r from ~43% to ~37% on my machine.

I think this PR (and the linked ones) are now ready for review


Mpi/crocoddyl topic/test pinocchio state - [merged]

In GitLab by @MaximilienNaveau on Sep 24, 2019, 12:40
Merges mpi/crocoddyl-topic/test_pinocchio_state -> devel
Implement the unit-tests for the StateMultibody (pinocchio).
Added the test for a couple of models:

example-robot-data/talos_data/urdf/talos_reduced.urdf
example-robot-data/hyq_description/robots/hyq_no_sensors.urdf
example-robot-data/talos_data/robots/talos_left_arm.urdf
Random humanoid

In GitLab by @cmastalli on Sep 24, 2019, 12:45
Please format c++ code by:

go to the root folder of crocoddyl
run the following command:

clang-format-6.0 -i $(find . -path ./cmake -prune -o -iregex '.*\.\(h\|c\|hh\|cc\|hpp\|cpp\|hxx\|cxx\)$' -print)

for more information see: https://gepgitlab.laas.fr/loco-3d/crocoddyl/wikis/Developer-Guide

In GitLab by @MaximilienNaveau on Sep 24, 2019, 13:14
added 1 commit
09149d2b - use clang for the formatting
Compare with previous version

In GitLab by @MaximilienNaveau on Sep 24, 2019, 13:15
Done

In GitLab by @cmastalli on Sep 24, 2019, 13:18
There are some issues with the CI job (see here https://gepgitlab.laas.fr/mnaveau/crocoddyl/-/jobs/33103).
Could you rebase the branch? And also, could you give me rights to push to this branch? (there is a bug that I fixed, however, I didn't propagate yet)

In GitLab by @cmastalli on Sep 24, 2019, 13:19
You also need to change the target branch. Please always use devel branch.

In GitLab by @MaximilienNaveau on Sep 24, 2019, 13:32
changed the description

In GitLab by @MaximilienNaveau on Sep 24, 2019, 13:32
changed target branch from master to devel

In GitLab by @cmastalli on Sep 24, 2019, 13:33
Ok, let me know when you've rebase the branch. I could put my hands after that

In GitLab by @MaximilienNaveau on Sep 24, 2019, 13:43
added 98 commits
09149d2b...4814cb7a - 95 commits from branch loco-3d:devel9b58f754 - add the unittests on the hyq and thalos model for the states. Problem with pinocchio yete71bbd94 - update the test_state to handle different state types3d71c766 - use clang for the formatting
Compare with previous version

In GitLab by @MaximilienNaveau on Sep 24, 2019, 13:58
added 1 commit
8805b1bc - fix the rebase
Compare with previous version

In GitLab by @MaximilienNaveau on Sep 24, 2019, 13:59
I rebased the branch and gave you access to it

In GitLab by @MaximilienNaveau on Sep 24, 2019, 14:17
I fixed a small bug during the rebase (forgot a pinocchio include)

In GitLab by @cmastalli on Sep 24, 2019, 15:02
added 1 commit
9f9f70ba - [bugfix] Error in the dimension of q in legacy unittest + use StdVec_Force
Compare with previous version

In GitLab by @cmastalli on Sep 24, 2019, 15:03
I pushed the a commit that fixed a bug in the legacy code. Now the CI see it since we used Debug mode from Pinocchio.
Let's see if we need to solve something else

In GitLab by @cmastalli on Sep 24, 2019, 15:53
It fails test_state.cpp in the Debian jobs. Could you figure out and fix them? (https://gepgitlab.laas.fr/mnaveau/crocoddyl/-/jobs/33386)

In GitLab by @MaximilienNaveau on Sep 24, 2019, 16:08
Being a segfault with nothing more it is difficult to say what is wrong.
Any suggestion in the way to go with the CI?
Can I start it with a debugger?

In GitLab by @cmastalli on Sep 24, 2019, 16:17
@nim65s do you have any advice? Docker? @MaximilienNaveau's PR fails in the Debian job.

In GitLab by @nim65s on Sep 24, 2019, 16:45
@MaximilienNaveau :
docker run --rm -it gepetto/buildfarm:py-crocoddyl-py3-stretch

Then, once inside the container:
cd wip/py-crocoddyl
make checkout MASTER_REPOSITORY="git https://gepgitlab.laas.fr/mnaveau/crocoddyl.git"
build=$(make show-var VARNAME=CONFIGURE_DIRS); cd $(make show-var VARNAME=WRKSRC); cd $build
git checkout mpi/crocoddyl-topic/test_pinocchio_state
cd ../..
make
build=$(make show-var VARNAME=CONFIGURE_DIRS); cd $(make show-var VARNAME=WRKSRC); cd $build
make test

This might not be the fastest way, but it might be the easiest :)

In GitLab by @nim65s on Sep 24, 2019, 16:49
If you are really in a hurry, we could also temporarily allow failures for debian… But this looks like a real bug, even if ubuntu fails to catch it for now.

In GitLab by @MaximilienNaveau on Sep 24, 2019, 16:52
If I have a good way of trying things out then its perfect!
Thank Guilhem!

In GitLab by @MaximilienNaveau on Sep 24, 2019, 17:43
added 1 commit
d8d7de5c - [CI][test state] remove the shared pointer on the abstract Factory
Compare with previous version

In GitLab by @MaximilienNaveau on Sep 24, 2019, 17:47
added 1 commit
84efd6cc - [CI][test_state] fix previous commit
Compare with previous version

In GitLab by @MaximilienNaveau on Sep 25, 2019, 10:39
[small update] I could pin down the problem to the use of a freeflyer during the model loading.

In GitLab by @cmastalli on Sep 25, 2019, 10:50
The name of the robot is TALOS, not THALOS

In GitLab by @MaximilienNaveau on Sep 25, 2019, 10:52
Ok so explain me this assert:
https://gepgitlab.laas.fr/loco-3d/crocoddyl/blob/master/src/multibody/states/multibody.cpp#L38

In GitLab by @cmastalli on Sep 25, 2019, 10:53
Why is this needed?

In GitLab by @cmastalli on Sep 25, 2019, 10:53
The robot name is Talos, please modify all the corresponding cases

In GitLab by @MaximilienNaveau on Sep 25, 2019, 10:54
Because otherwise the Numpy include are not found

In GitLab by @cmastalli on Sep 25, 2019, 10:56
I don't understand how EXAMPLE_ROBOT_DATA_PKGDATAROOTDIR is retrieved. Is this works for general cases? I mean let's imagine that you install example-robot-data in another directory and you properly setup your bashrc

In GitLab by @cmastalli on Sep 25, 2019, 10:58
It checks that you pass a vector with the right dimension, is this answer your question?

In GitLab by @cmastalli on Sep 25, 2019, 10:59
But why do we need to include then? We don't depend on NumPy, EigenPy does

In GitLab by @nim65s on Sep 25, 2019, 11:39
In that case, why the FIND_NUMPY on the line before ?

In GitLab by @nim65s on Sep 25, 2019, 11:41
that's available in example-robot-data.pc

In GitLab by @cmastalli on Sep 25, 2019, 13:14
thanks for the clarification

In GitLab by @cmastalli on Sep 25, 2019, 13:15
Indeed, could @MaximilienNaveau try to remove both and double check that they're not needed?

In GitLab by @MaximilienNaveau on Sep 25, 2019, 14:32
It was a comment that I saw on an email about the size of "x2_eps"
Eigen::VectorXd x2_eps(state.get_ndx());
This needs to be of size ndx and not nx because it is the output of a state::diff method which is of size ndx.

In GitLab by @MaximilienNaveau on Sep 25, 2019, 14:42
I added them because:

upon compilation of the python bindings we include EigenPy which in turn include Numpy.
the find_numpy does not do the INCLUDE_DIRECTORIES.
And for the PKG_CONFIG_USE_DEPENDENCY(${PROJECT_NAME}_pywrap eigenpy) does give us the path to numpy either.

This is the only way I could make the build working.

In GitLab by @MaximilienNaveau on Sep 25, 2019, 14:45
I did it, it's gonna be in the push.

In GitLab by @MaximilienNaveau on Sep 25, 2019, 14:47
It is actually during the cleaning of the memory because all unit-tests pass.

In GitLab by @cmastalli on Sep 25, 2019, 15:18
I see. I think eigenpy needs to add this path, do you agree @nim65s?
Let's keep this as it is. @MaximilienNaveau thank you for taking care of it

In GitLab by @cmastalli on Sep 25, 2019, 15:20
Sorry, I was my mistake. I removed the comments after realizing it. Variables names are very similar

In GitLab by @MaximilienNaveau on Sep 25, 2019, 15:23
So I have no problem with the TALOS_ARM_URDF and the RandomHumanoid. So it is definitely during a memory clean up of the freeFlyer object in pinocchio or in the multibody class...

In GitLab by @nim65s on Sep 25, 2019, 15:49
Ideally, including eigenpy headers should not force us to have numpy headers… But this require some work to clean that.
This error is extremely common in all Gepetto projects, and it forces us to always look for all dependencies of all our dependencies.

In GitLab by @MaximilienNaveau on Sep 25, 2019, 17:11
I printed a message in the destructor to see if there was a problem but the destructors are all called fine. It is when the unittests memory is freed that a problem arise.
I have no clue what is going on.
May I plublish the unittest with the TALOS_ARM_URDF (no freeflyer) and the RandomHumanoid (with free flyer)?
We can keep this issue activated with a bug flag for the time being until the bug is fixed. But I would move on to the rest of the unit-tests

In GitLab by @MaximilienNaveau on Sep 25, 2019, 17:14
changed this line in version 9 of the diff

In GitLab by @MaximilienNaveau on Sep 25, 2019, 17:14
changed this line in version 9 of the diff

In GitLab by @MaximilienNaveau on Sep 25, 2019, 17:14
changed this line in version 9 of the diff

In GitLab by @MaximilienNaveau on Sep 25, 2019, 17:14
added 1 commit
fcac5067 - [CI][test state] deactivated the HYQ_URDF and the TALOS_URDF tests. Still have...
Compare with previous version

In GitLab by @cmastalli on Sep 25, 2019, 17:36
Why do you need to use shared pointers? It would be great if we don't use them

In GitLab by @cmastalli on Sep 25, 2019, 17:38
You should first access the raw pointer (e.g. *pinocchio_model->get()). However, as I mentioned about, it would be great to do not use share pointers

In GitLab by @cmastalli on Sep 25, 2019, 17:39
remove all printing lines such as this one

In GitLab by @cmastalli on Sep 25, 2019, 17:40
same here, you need to access the raw pointer

In GitLab by @cmastalli on Sep 25, 2019, 17:42
better returning the share pointer in get_state, i.e.:
boost::shared_ptr<StateAbstract>& state = factory.get_state();

In GitLab by @cmastalli on Sep 25, 2019, 17:50
@MaximilienNaveau the problem is there. Are you running your code in Debian?

In GitLab by @MaximilienNaveau on Sep 25, 2019, 17:51
I am supposed to, I guess I am not using docker in the proper way...

In GitLab by @MaximilienNaveau on Sep 25, 2019, 17:58
Strange: from this job (https://gepgitlab.laas.fr/mnaveau/crocoddyl/-/jobs/33639)
I see that I delete my object more time than I create it...

In GitLab by @MaximilienNaveau on Sep 25, 2019, 18:34
changed this line in version 10 of the diff

In GitLab by @MaximilienNaveau on Sep 25, 2019, 18:34
changed this line in version 10 of the diff

In GitLab by @MaximilienNaveau on Sep 25, 2019, 18:34
changed this line in version 10 of the diff

In GitLab by @MaximilienNaveau on Sep 25, 2019, 18:34
changed this line in version 10 of the diff

In GitLab by @MaximilienNaveau on Sep 25, 2019, 18:34
added 1 commit
33e12229 - [CI][test state] use only normal pointer and do not manage the deletion of the memory
Compare with previous version

In GitLab by @MaximilienNaveau on Sep 25, 2019, 18:58
added 1 commit
3c2a2215 - [CI][test_state] de-activated all tests but the StateVector
Compare with previous version

In GitLab by @MaximilienNaveau on Sep 25, 2019, 19:33
added 1 commit
96016aeb - [CI][test state] Re-activate unit-test as they pass on the docker...
Compare with previous version

In GitLab by @MaximilienNaveau on Sep 26, 2019, 09:02
added 1 commit
e67fedd6 - [CI][unit-test] reactivate (python bindings and python) unit-tests
Compare with previous version

In GitLab by @MaximilienNaveau on Sep 26, 2019, 09:27
changed this line in version 14 of the diff

In GitLab by @MaximilienNaveau on Sep 26, 2019, 09:27
added 1 commit
3666ef5c - [CI][test state] format the file
Compare with previous version

In GitLab by @MaximilienNaveau on Sep 26, 2019, 10:16
Ok, all tests pass: https://gepgitlab.laas.fr/mnaveau/crocoddyl/pipelines/5865.
I am not 100% happy with the memory management of this unit-tests but I suggest I come back to this later. Do you have any additional comments on this PR? (I think I cleaned the code but I might have missed something)

In GitLab by @cmastalli on Sep 26, 2019, 10:25
resolved all threads

In GitLab by @cmastalli on Sep 26, 2019, 10:28
added 62 commits
3666ef5c...47f7b7cf - 61 commits from branch loco-3d:devel31a5d8b9 - Merge branch 'devel' into 'mpi/crocoddyl-topic/test_pinocchio_state'
Compare with previous version

In GitLab by @cmastalli on Sep 26, 2019, 10:29
enabled an automatic merge when the pipeline for 31a5d8b90db8b1d2049b13e44f01f44ed7362f32 succeeds

In GitLab by @MaximilienNaveau on Sep 26, 2019, 10:35
Thanks for dealing with the rebasing. Just to confirm that what I am understanding it correctly:
In this case I can either merge devel in mpi/crocoddyl-topic/test_pinocchio_state by
git checkout mpi/crocoddyl-topic/test_pinocchio_state
git merge devel

or rebase the devel by
git rebase origin/devel mpi/crocoddyl-topic/test_pinocchio_state

Is this correct ?

In GitLab by @cmastalli on Sep 26, 2019, 10:39
Yes, you can either merge the devel to your branch (first option) or rebase your branch with respect to the devel, i.e.
git checkcout $mybranch
git rebase origin devel

Generally speaking I prefer to rebase the branch because it's supposed that you didn't do too many modifications on your branch. However in some weird cases, it's better the other (e.g. formatting the entire code).

In GitLab by @cmastalli on Sep 26, 2019, 10:55
merged

In GitLab by @cmastalli on Sep 26, 2019, 10:55
mentioned in commit 9541dfa8fcf12e7c73aa83ebb93e6120b40800ae


Try me... search button on homepage not working

Sorry if this is the wrong repository to post this in, I couldn't find a repository called meilisearch.com or anything like that in this organization.
Describe the bug
The search bar on the Meilisearch homepage isn't working.
To Reproduce
Steps to reproduce the behavior:

Go to the search bar in the screenshot below.
Type in any text.
See no responses.

Expected behavior
Some kind of response given.
Screenshots
The search bar:

Browser logs are also showing a bunch of failed requests:

Meilisearch version: N/A
Additional context
Browser: Firefox 105.0.1
OS: Kubuntu 22.04

Hello here!
Thanks for the report @hwittenborn!
I moved the issue to the right repo!
We will do our best to fix this asap

Looks like the search functionality is back @curquiza, don't know if you want to keep it open until it's fixed on the meilisearch side, feel free to do what you want though

Yes, thank you, I close this!
The core team is investigating to avoid this issue to be present again


Update README.md

Typos, grammar and double Muffin

Thanks. You can tell that english is not my best language...


Creating a selector for the element

Added an extension method for the elements that creates a unique selector path used to locate the element in the DOM.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 2 committers have signed the CLA.:white_check_mark: FlorianRappl:x: lvkinsYou have signed the CLA already but the status is still pending? Let us recheck it.

Looks great - thanks for your contribution :beers:!


fix the npm audit vulns

The @waves npm packages have many npm audit vulnerabilities and it's blocking my CI. Other packages that still need fixing are @waves/signature-adapter and @waves-transactions, but I figured I would start here since it's the deepest level package and probably needs the most attention.


Update 105-update-root-area-and-iteration-path-field.sql

Based on this discussion we first remove the unique name index on the iterations and areas table before we modify the data.
In a previous attempt (https://github.com/fabric8-services/fabric8-wit/pull/2312) I haven't moved the removal of the index enough up.
This should fix the migration issue that was visible here: https://github.com/openshiftio/saas-openshiftio/pull/1082

Ike Plugins (test-keeper)
Thank you @kwk for this contribution!

It appears that no tests have been added or updated in this PR.
Automated tests give us confidence in shipping reliable software. Please add some as part of this change.
If you are an admin or the reviewer of this PR and you are sure that no test is needed then you can use the command /ok-without-tests as a comment to make the status green.
For more information please head over to official documentation. You can find there how to configure the plugin.

/ok-without-tests


Windows container DNS resolution failure

Description
Observed Behavior:
I'm trialling the new Windows node / container support for use in CI build systems and am currently blocked on a DNS resolution issue.
Gitlab runner output:
Using Kubernetes namespace: default
Using Kubernetes executor with image mcr.microsoft.com/windows/servercore:ltsc2022 ...
Using attach strategy to execute scripts...
Preparing environment
Waiting for pod default/runner-tughempr-project-2452-concurrent-0r8xkj to be running, status is Pending
	Unschedulable: "0/4 nodes are available: 4 node(s) had untolerated taint {eks.amazonaws.com/compute-type: fargate}. preemption: 0/4 nodes are available: 4 Preemption is not helpful for scheduling."
<snip>
Waiting for pod default/runner-tughempr-project-2452-concurrent-0r8xkj to be running, status is Pending
	Unschedulable: "0/4 nodes are available: 4 node(s) had untolerated taint {eks.amazonaws.com/compute-type: fargate}. preemption: 0/4 nodes are available: 4 Preemption is not helpful for scheduling."
Waiting for pod default/runner-tughempr-project-2452-concurrent-0r8xkj to be running, status is Pending
	ContainersNotInitialized: "containers with incomplete status: [init-permissions]"
	ContainersNotReady: "containers with unready status: [build helper]"
	ContainersNotReady: "containers with unready status: [build helper]"
<snip>
Waiting for pod default/runner-tughempr-project-2452-concurrent-0r8xkj to be running, status is Pending
	ContainersNotReady: "containers with unready status: [build helper]"
	ContainersNotReady: "containers with unready status: [build helper]"
Running on RUNNER-TUGHEMPR via
project-spring...
Getting source from Git repository
Fetching changes with git depth set to 20...
Initialized empty Git repository in C:/builds/myproject/.git/
Created fresh repository.
powershell : fatal: unable to access 'https://gitlab.######.com/myproject.git/': Could not resolve host:
gitlab.######.com
At C:\scripts-2452-550553\terminate_with_json_script.ps1:7 char:1
+ powershell -File $Path
+ ~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : NotSpecified: (fatal: unable t...novation.com.au
   :String) [], RemoteException
    + FullyQualifiedErrorId : NativeCommandError

Where gitlab.######.com is a real hostname that's publicly resolvable and works fine on linux nodes.
Note: this git pull is performed within a container / pod running on the node.
There appear to be a couple of open issues like this with windows docker:

https://github.com/microsoft/Windows-Containers/issues/216
https://forums.docker.com/t/dns-broken-on-docker-desktop-for-windows/130121

Does the Karpenter test suite happen to test anything like this; running application / test code inside a container / pod that would be using public dns resolution?
Expected Behavior:
On linux machines running with the same cluster configuration the git pull runs without issue.
Reproduction Steps (Please include YAML):
I'll grab a copy of this when I'm next on the work network (don't have access at home) however it's pretty basic defaults other that specifying the windows os and our company security groups / zones.
Versions:

Chart Version: TBA
Kubernetes Version (kubectl version): TBA

Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
If you are interested in working on this issue or have submitted a pull request, please leave a comment

Solved, not a Karpenter issue
In my gitlab runner configuration I had the Kubernetes pod DNS Policy set to "cluster-first" (not entirely sure where I copied that from now).
Changing it to:
  [runners.kubernetes]
    dns_policy = "default"

Got my windows node and ci job working.

In my gitlab runner configuration I had the Kubernetes pod DNS Policy set to "cluster-first" (not entirely sure where I copied that from now).
Changing it to:

  [runners.kubernetes]
    dns_policy = "default"

Got my windows node and ci job working.

I thought I had it fixed with gitlab-runner config change, but no that didn't work.
It looks like pod dnsPolicy and dnsConfig aren't really working properly on windows... well google gets me a couple of specific things that aren't supported and my tests of using dns_policy = "none" and dns_config / nameservers = ["known working dns ip address"] as set with gitlab-runner didn't work at all. ipconfig /all in the pod still showed the kubernetes dns server in use.
What did work for me is changing the provisioner:
spec:
  kubeletConfiguration:
    clusterDNS: ["known working dns ip address"]

Been struggling with myself in a similar scenario (also for CI) - GitHub ARC to be exact..  the pods on nodes brought up by eksctl when I provisioned the windows nodegroup can resolve dns fine, but pods on karpenter provisioned nodes can’t resolve DNS.  Will try this tomorrow!


Create a New Page called MediaManip #676

Issue #676

New Page Called "Media Manip" is Created
Routing added
Navbar updated
Drag & Drop feature implemented.
Preview of uploaded/dropped images.
Input/Output Format selecting Dropdown added
2 Buttons added for convert & download (currently no functionality as you have mentioned)
Responsive

Overall Page UI:

Dropdown selected:

While Dropping an Image/ Multiple Image
(Cursor not visible in the Scrnshot)

Added an Image:

Added Multiple Images:

Also, reduce the shadow on the image once uploaded so that it looks good. currently, the shadow's are too much.

Image Shadow Reduced & Merge Conflict Fixed

@iamdarshshah hello sir,
the recent commit I have made is for a new PR but it got into it. How to revert and make a new PR for this commit. Please Help.

Everything is fixed as per suggestion.
@smaranjitghose , Can you please review it?

A small logical issue.
I have selected my input as PNG yet I am able to upload a JPG image.
Just put a conditional to implement either of these situation(s):

The easy way: First the user has to choose an option from input else the file upload will not work, once the option is selected, only files with that extension are allowed to be uploaded

The cool way(not recommended at this stage but you can take this as a challenge): we don't need to give the option for the user to choose the input type, we will have options to upload certain types of images, check their individual extensions, read the output choice and accordingly call the functions for necessary conversion

UI/UX Simplication

Once the user uploads a single image (or an array/list of images) we remove the option of uploading more images!
Rather we would have the size of the dropbox/carousel or whatever we call it🤣 unchanged and options to scroll right and left
Remove the progress bar and put it like a speedometer in between the input and output options (similar to what we see when we check internet speed)

Either way, the progress bar should work
The download button should have different color, once the conversion is complete(the color changes indicating we have data in our cloud server ready for download). Whenver the user presses the download button, without having converted any image, it should raise an alert "Images not uploaded/converted"

@smaranjitghose For being real, it wasn't a Progress Bar. 😬😅
It a horizontal scroll bar and now it got the style of the vertical scroll bar of the page.
Anyway thanks for your suggestions. Let me implement a progress bar.

Initial Page Without Images:

When an Image is Added , Convert Button gets enabled and shows Download button is disabled mode

If output is not selected

On Click of Convert Button

During Conversion

When Conversation is Complete, Download Button Gets Enabled

When download button is clicked

LGTM🙌🙌. Great work


Listen to an event that fires before the AJAX call is made

Is there currently a way to listen to an event that fires before any AJAX call is made? Something like:
Barba.Dispatcher.on('beforeLoad', function() {
  //your listener
});

If this doesn't exist, would it be possible to add it to this really useful library?
Many thanks!

Hello @bravokiloecho ,
what would be the usage of such event?

Ok, i see @bravokiloecho .
I'll check if add such event in a new version.

Brilliant, thanks @luruke!
I'm excited to hear there might be a new version. I use Barba.js a lot and find it really helpful. So many thanks for all your work on it!


A multiline TextBox does not move up the header

Current behavior
Using a multiline TextBox with a header when you write some lines the header does not move up to the top of the field.
Expected behavior
The Header is moved up when write in the field.
How to reproduce it (as minimally and precisely as possible)

Open the attached solution and compile it.
Execute it in any platform.
Write in the TextBox.

Workaround:
There is a TestTextBox style in the attached solution with VerticalAlignment of the HeaderElement changed to Top, you can use it.
Environment
Visual Studio 2022 17.11.4
Nuget Package:
Package Version(s):
Uno.WinUI 5.4.27
Affected platform(s):

[ ] iOS
[ ] Android
[X] WebAssembly
[X] Skia (WPF)
[X] WinAppSDK
[ ] MacOS

Anything else we need to know?
TestBoxMultilineHeader.zip

fyi @eriklimakc

@Suriman same comment as https://github.com/unoplatform/Uno.Themes/issues/1469#issuecomment-2465263566 to be able to have the fixes with the latest Uno Themes dev version.

The fix didn't make it into<EMAIL_ADDRESS>-><EMAIL_ADDRESS>It is only available from<EMAIL_ADDRESS>and onward.

@agneszitte @kazo0 any plan to backport this, or when this will make it to the vNext?


Handle out of sync extension activations for encryption keys updated event

Noticed an issue with firing of event from SqlToolsServer - in case where azurecore cache gets activated first, event if fired only once. And if event listener is not registered, we end up losing emitted event.
Since we absolutely need to read encryption keys to work, I'm introducing a direct access API to be able to read Encryption keys right after STS activation and send notification to backend service. Not considering emitting event multiple times to avoid unnecessary events being fired that would impact performance.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 12 (0.0%)  changed or added relevant lines in 4 files are covered.
35 unchanged lines in 3 files lost coverage.
Overall coverage decreased (-0.007%) to 42.32%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

extensions/azurecore/src/extension.ts
0
1
0.0%

extensions/azurecore/src/account-provider/utils/fileEncryptionHelper.ts
0
3
0.0%

extensions/azurecore/src/account-provider/azureAccountProviderService.ts
0
4
0.0%

extensions/azurecore/src/account-provider/utils/msalCachePlugin.ts
0
4
0.0%

Files with Coverage Reduction
New Missed Lines
%

extensions/notebook/src/jupyter/serverInstance.ts
4
75.5%

extensions/azurecore/src/account-provider/utils/msalCachePlugin.ts
15
0%

extensions/azurecore/src/account-provider/azureAccountProviderService.ts
16
0%

Totals

Change from base Build<PHONE_NUMBER>:
-0.007%

Covered Lines:
30805

Relevant Lines:
67608

💛  - Coveralls


need help whit packaging for linux?

i see that you dont have support for linux so need help whit packaging for linux?

Yeah would be epic!

Sorry for replying late :(

you got discord?

if you have just add me its "josakko"

nah man you got zoom or smth? zoom works by sending invites (for chats) by emails (mines<EMAIL_ADDRESS>

maybe telegram, signal, anything?

if you dont just send me zoom invite on<EMAIL_ADDRESS>

sent bro


Add language prefix to Jaeger client version tag

Fixes #34.

The coverage seems to have a mistake. IDK why it thinks the coverage went down on BaggageSetter.


Update navbar

Can you make a small adjustments:

Match style of dropdown items with designs (so we don't have this blue vertical bar next to active item).

Fix behavior of accordion, so it doesn't push logo up when it's opened.

https://github.com/user-attachments/assets/fb04ea2d-62bf-44b7-b01c-a4e6535826b3

Optional: Maybe we could align 'x' with chevron. It looks a bit weird, that they are not aligned

this vertical bar is included on designs https://www.figma.com/design/mJ0IlSLdrYzDnmUAMWls5A/Spark-App?node-id=5774-2466&t=IoY84INtO1E77E3S-4
but good catch with the mobile view


Show more information while recognizing

Currently, the Willow only shows "say command" until the response is back. It would be better to show something like "processing...", as my setup might take a few seconds to respond, and showing "say command" during a time when the device isn't listening is confusing UX.

How do you feel about displaying "Processing..." on the same line as "Say command..." after speech ends and when the command is sent to the command endpoint?

You mean instead of "say command..."? Yes, that was what I meant, though on second thought "processing" might be a bit too jargony. Depending on your intended audience, maybe "thinking" is more understandable?

Thanks for understanding, glad to hear you won't be asking for your money back ;).
I'm actually embarrassed we didn't think of this before - you're absolutely correct in that it's good to get some definitive feedback on when voice has ended, something is happening, and the user just needs to wait. Of course in my testing with Home Assistant and a local RTX 3090 "Thinking..." basically flashes on the display for a couple hundred ms but it's still good to know.
Your ChatGPT + Willow Twitter video is really cool but sitting there at "Say command..." is pretty cringe to me and this is an easy change that makes a huge difference in user experience.
If I push this change to a branch do you have a build/dev environment setup to test? I've already put it through our automated testing for 2,000 successive runs but it would be good to test with your configuration as well.

I can test it, yep! I'll need to make some changes to the code to make the Box speak the result, and flashing my changes has been a bit finicky, but I should be able to test, yes.

@kristiankielhofner do you have a branch for this, perhaps?

I'll try this, thanks!

Oof, amazing :kissing: :ok_hand:.


Formatting system: format large numbers with thousands separators (digit grouping) by default

Summary of the new feature/enhancement
The output formatting system's purpose is to present data to the human reader.
(As such - because the formatted output isn't meant for programmatic processing - it isn't part of PowerShell's breaking-changes contract.)
Currently, large numbers are output without thousands separators, i.e. without grouping the digits for easier comprehension.
I suggest applying this grouping to all numbers (that aren't explicitly formatted via formatting data):
# WISHFUL THINKING - but you can get a preview with the prototype below.

# Number by itself (out-of-band formatting)
PS> 1000
1,000

# Implicit in-band formatting (table or list)
PS> @{ num = 1000 }

Name                           Value
----                           -----
num                            1,000

# Should also automatically apply to types with explicit formatting data
# (unless number formatting is part of a given list item / table column).
# Note the "Size" column.
PS> Get-Item $PROFILE

    Directory: /Users/jdoe/.config/powershell

UnixMode   User             Group                 LastWriteTime           Size  Name
--------   ----             -----                 -------------           ----  ----
-rw-r--r-- jdoe             staff              10/23/2019 22:31           1,934  Microsoft.PowerShell_profile.ps1

Proposed technical implementation details (optional)
Here's a quick prototype that uses the ETS. It is not the suggested implementation, for reasons of both performance and also changing the behavior of explicit .ToString() calls.
A proper implementation would require modifying the formatting system itself.
# Prototype:
[int16], [int], [long], [double], [decimal], [bigint], [uint16], [uint], [uint64] | % {

  Update-TypeData -TypeName $_.FullName  -MemberType ScriptMethod -MemberName ToString -Value {
    # Determine how many decimal places there are in the original representation.
    # Note: PowerShell's string interpolation uses the *invariant* culture, so '.'
    #       can reliably be assumed to be the decimal mark.
    $numDecimalPlaces = ("$this" -replace '^[^.]+(?:.(.+))?', '$1').Length

    # Format with thousands grouping and the same number of decimal places.
    # Note: This will create a culture-sensitive representation
    #       just like with the default output formatting.
     # CAVEAT:
     #  To avoid a crash (from infinite recursion?), both .psobject.BaseObject
     #  and the -f operator must be used.
     #  ($this.psobject.BaseObject.ToString("...") also crashes).
    "{0:N$numDecimalPlaces}" -f $this.psobject.BaseObject
  } -Force

}

(As such - because the formatted output isn't meant for programmatic processing - it isn't part of PowerShell's breaking-changes contract.)

Although this might be true, I am afraid that the purpose will be more confusing than an advantage in human readability especially for a novice programmer.
If I do this: @{ num = 1000 } | Out-File .\Output.txt
Will it have thousands separators in the output file or not?
I presume they shouldn't show up in the output, as I am not doing e.g. @{ num = 1000 } | Format-Table | Out-File .\Output.txt
which is wrong although a lot a lot of PowerShell users do this or have already don't this. For this group, their process (relying on a 'Format-Table' output) might break. ... Sorry, you should have read the small print in the contact 😒
So, if this assumption is correct, a novice programmer will likely get confused by the difference outputted on the screen and what is actually in the file.

There is a UX problem - if copy-paste from console it is very annoying because it is culture sensitive.

You might also consider to do this on a specific type...
The type that usually holds a lot of digits and can hold all the other types (and is actually not prototype list): [BigInt].
If you just do this for [BigInt], you would be able to quiet easily format a large number with thousands separators, like:
PS C:\> [BigInt]1000
1,000
PS C:\> @{ num = [BigInt]1000 }

Name                           Value
----                           -----
num                            1,000

I think that's more likely to just be needlessly confusing, having one numeric type that behaves differently to the rest.
If this is going to change, all number types should behave similarly.

To get the current behavior there should be a switch parameter on the format commands and a preference variable to enable/disable globally.

@iSazonov, the culture-specific output not being reusable in source code already applies to numbers with decimal places (and also to dates, for instance):
PS> $o = [cultureinfo]::CurrentCulture; [cultureinfo]::CurrentCulture = 'fr-FR'; 1.23; [cultureinfo]::CurrentCulture = $o
1,23  # Decimal mark is ","

True, with the grouping it would occur more often, which is why @ThomasNieto's  suggestion (preference variable and switch) is a good one.
@iRon7, nothing would change for Out-File / >: you'll get the same representation in the file as you would get on the screen; because Out-File also uses the formatting system, files created this way shouldn't be relied on for further programmatic processing. Also, something like @{ num = 1000 } | Format-Table | Out-File out.txt is legitimate, because it allows you to pick the "shape" of the output explicitly instead of relying on the default.

I'd definitely like to see an option for this.  I think making this default would lead to a lot of confusion on both ends of the experience spectrum though.

Veteran users have already been trained that if they see digit separators then they're dealing with a string.  If they want to treat it like a number, they need to prep the string for parsing
Newer users will have difficulty troubleshooting why their number only has digit separators sometimes. (e.g. Write-Host 1000 would output 1000 but 1000 would output 1,000)

It needed to sinking in a little, but I guess I actually like the basic idea.
Provided there is an option to disable it because (if I understand it right) here lays in essence the pitfall:
(1000 | Out-String) -eq ('1000' | Out-String)

This is $True in CMO and will be $False in FMO.
The same discrepancy happens when I do this:
1000 | Out-File .\Thousand.txt
$Thousand = Get-Content .\Thousand.txt
$Thousand -eq 1000

Or is this due to the fact that is concerns a prototype?

@SeeminglyScience:
At the end of the day I'd personally be happy with either solution (grouping by default ON vs. OFF), though I think that in the long run having it on by default is more beneficial:

Readability is then enhanced by default. While that comes at the expense of copying and pasting output as number literals usable in source code, I think the readability aspect trumps that, given that presenting output readably to the human observer is the very purpose of the formatting system.

Conversely, if OFF were the default, it wouldn't be easy for beginners to discover how to opt in.

I don't think we need to worry about Write-Host, which already presents enough puzzles to the uninitiated - e.g.,
Write-Host @{ a =1; b = 2} printing System.Collections.DictionaryEntry System.Collections.DictionaryEntry. However, unlike with the preference variable / new switch we're discussing here, information about  Write-Host is easy to discover and conceptualize - even though the help topic is currently lacking: see https://github.com/MicrosoftDocs/PowerShell-Docs/issues/6599.
The short of it: Write-Host uses .NET  .ToString() stringification on its arguments, which is unrelated to PowerShell's formatting system.

@iRon7:
Yes, these behaviors would change, but I do not consider that problematic:

(1000 | Out-String) -eq ('1000' | Out-String)

1000 is unequivocally a number literal, '1000' is unequivocally a string.
You need to know that Out-String applies default formatting to its inputs, and that the results will only be the same if the input is a strings (leaving aside that Out-String currently appends an extra newline).

The same applies to Out-File; if you do want .ToString() stringification, use Set-Content instead.

Readability is then enhanced by default. While that comes at the expense of copying and pasting output as number literals usable in source code, I think the readability aspect trumps that, given that presenting output readably to the human observer is the very purpose of the formatting system.
Conversely, if OFF were the default, it wouldn't be easy for beginners to discover how to opt in.

Yeah I agree for sure.  I just expect a lot of confusion around it if it gets implemented.  Similar to how some format definitions include columns that aren't real properties, I see folks having issues with that at least once a week.  Also when you get an object that returns an actual formatted string that's going to be hard to pin down the difference.

I don't think we need to worry about Write-Host, which already presents enough puzzles to the uninitiated - e.g., (...)

True, but I think it's much harder to reason about with a primitive.  A complex object is expected to be formatted differently, where a primitive you usually expect the stringification of it.

much harder to reason about with a primitive

I think that all users need to know is: (a) Write-Host works differently, and (b) given that it uses .ToString() on its input objects - whether primitive or not - you can easily test the behavior with, say, $var = 1.23;  $var.ToString() - although there is indeed an existing pitfall there: Write-Host 1.23 is not culture-sensitive, because a literal argument is used; by contrast, $num = 1.23; Write-Host $num is culture-sensitive; I've updated the docs issue with details.
Generally, I think users from cultures that use , as the decimal mark are already ware that neither Write-Host nor Out-* cmdlets / implicit formatting necessarily preserve the original representation of a number.

I hear you on the potential for confusion, but I think this confusion will go away over time, and won't apply to new users.
Not being able to readily distinguish between the output from 1000 and '1,000' is somewhat inconvenient, but I think the  inconvenience of having to call .GetType() to disambiguate is outweighed by the benefits of readability.
I think we now understand the issues involved and just happen to disagree on what the default should be.
Let's see what others have to say.

much harder to reason about with a primitive

I think that all users need to know is: (a) Write-Host works differently, and (b) given that it uses .ToString() on its input objects

Write-Host was an example, the ToString difference is what I'm talking about.  And yes, once they understand what it happening they will understand what it is happening, but it's still introducing a new newbie pitfall.

(...) and won't apply to new users.

I disagree, I think it's most likely to confuse new or very casual users who are more likely to try to fit the stringification of a primitive into a report or something.

I think we now understand the issues involved and just happen to disagree on what the default should be.
Let's see what others have to say.

👍


"Use previews of the .NET Core SDK" does not exist in VS 2019 16.7 Preview 2

The documentation is incorrect for the latest version of visual studio preview VS 2019 16.7 Preview 2
If you are in Visual Studio, it uses the prerelease status requested. That is, if you're using a Preview version of Visual Studio or you set the Use previews of the .NET Core SDK option (under Tools > Options > Environment > Preview Features), prerelease versions are considered; otherwise, only release versions are considered.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a94c335b-0b65-96cc-1c25-65777fbe4bb5
Version Independent ID: 6d80613f-42dc-35d7-aeff-3187a36dbbca
Content: global.json overview - .NET Core CLI
Content Source: docs/core/tools/global-json.md
Product: dotnet-core
Technology: dotnet-cli
GitHub Login: @tdykstra
Microsoft Alias: tdykstra

The use of the option is relevant only if you're not using a preview version of VS:

if you're using a Preview version of Visual Studio ... prerelease versions are considered [that is, no option setting is necessary]

or [that is, if you're not using a Preview version] you set the Use previews of the .NET Core SDK option ..., prerelease versions are considered


ImmediateGeometry Node does not color the points

Godot version:
3.1 master from the last few days
OS/device including version:
Intel HD 5000 (macbook air)
Issue description:
I'm using ImmediateGeometry to draw a list of points. I believe I can set the colour of the point similar to an opengl call by using IM.set_color inside the IM.begin call.
However, the points render black in the game. I think it could be one of several problems:

my misunderstanding the use of set_color
I'm using gles2 as it's an older laptop and perhaps it's not supported
There's a bug where ambient light does not affect the points
There's a bug where no lights affect the points (I added an omnilight to no effect)

I think this is related to #10024 which describes a similar problem on godot 2.
Steps to reproduce:
var point_size = 5
var im = ImmediateGeometry.new()
add_child(im)
var m = SpatialMaterial.new()
m.flags_use_point_size = true
m.params_point_size = point_size
im.set_material_override(m)
im.clear()
im.begin(Mesh.PRIMITIVE_POINTS, null)
im.set_color(Color(0,1,1))
for p in pts: #list of Vector3s
    im.add_vertex(p)
im.end()

I think you forgot to use vertex color as albedo, this works for me in 3.1 alpha1:
	var point_size = 5
	var im = ImmediateGeometry.new()
	add_child(im)
	var m = SpatialMaterial.new()
	m.flags_use_point_size = true
	m.params_point_size = point_size
	m.vertex_color_use_as_albedo = true # <-- THIS
	im.set_material_override(m)
	im.clear()
	im.begin(Mesh.PRIMITIVE_POINTS, null)
	im.set_color(Color(0,1,1))
	for i in 100:
	    im.add_vertex(Vector3(rand_range(-1, 1), rand_range(-1, 1), rand_range(-1, 1)))
	im.end()

Thanks, it works on linux but not my old mac laptop using gles2 but I can live with that!

same here for macOS, but the color is not black, always gray and light green-ish.

Just to note it worked fine on Windows.

In the material, I need flags_unshaded = true in order to see Albedo otherwise get black.

Can anyone still reproduce this bug in Godot 3.2.3 or any later release?

@KoBeWi  yes I can repro with 3.2.3 under Linux: set_color() does nt seem to do anything, points are just always black.

@WilliamTambellini Did you enable "unshaded" on the SpatialMaterial used for the ImmediateGeometry node?

Don't forget vertex_color_use_as_albedo otherwise it will not have any effect

@dodgyville Can you (or anyone else) still reproduce this bug in Godot 3.4.2 or any later release?
If yes, please ensure that an up-to-date Minimal Reproduction Project (MRP) is included in this report (a MRP is a zipped Godot project with the minimal elements necessary to reliably trigger the bug). You can upload ZIP files in an issue comment with a drag and drop.


Invoice number description and billing/shipping emails not being sent to AIMrequest

I can not set the following fields using the library in current state:
Billing/Shipping e-mails
invoice number
description.
phone number.

@mariuskubilius Would you be able to give dev-master a try? That should support:

setInvoiceNumber()
setDescription()
$card->setBillingPhone()

There are quite a few changes that I would like to put in a release soon. Nothing should be a BC break, but it needs to be tested in an environment other than mine (it works for me, but that's not enough, because I don't use many of the features).

Thanks will definitelly try 👍

Try release 2.5.0 That should fix all of the above. Let us know how it goes.

Closing this as fixed.


🚸 Make MessageContext.ack() flag argument optional

Basically what the title says. I think the method would be a bit more readable if you didn't need an argument for interactions without flags.

Yeah, this was a small mistake.
The only thing that has to change is the params and default to None since the Interaction.ack implements this too as optional.
(https://github.com/Pincer-org/Pincer/blob/main/pincer/objects/app/interactions.py#L259)
This should be an easy fix.

Please assign this to me


Install in a TV without a USB port

Hi, I have a smart TV with Android TV 11, Model MA4100 Hailstorm Version 4.0.1, Android TV OS build RTT5.230106.001.230428.107. It is a set top box that connects to the internet and cable, but comes without an USB port.
I installed Kodi from Google Play and elementum from an online repository, but I am getting the unfamous error daemon 13... I heard that if I install the ElementumService it will go away, but I don't have a way to install it from a USB.
Is there any repository online where I could download it like I downloaded Elementum from the "install from zip" section?
Thank you.

@jordillonchesteve you can install the app without a USB by doing the following:

Add source https://StefanIlchev.github.io/ElementumService to Kodi;
Copy service APK from source to device's storage and install it;
Install Elementum addon from source;
(Optional) Reinstall the addon from the added Elementum Service Repository and Kodi will keep it up to date. The APK once installed will update itself to match the addon's version.

Thank you!
I managed to add your address as a source and install the zip file, but don't know how to copy the service apk to the device's storage. Is there some manual I could follow?
Thanks again.

@jordillonchesteve you can use Kodi's File manager to copy the service apk to the device's storage. If you don't have the device's storage as a source, you can try adding it by adding /sdcard.


Add CODE_OF_CONDUCT.md

This adds a code-of-conduct document taken from http://contributor-covenant.org
Please take a look at the website as it explains the reasoning behind having a CoC in an OSS project. In case of any suggestions or concerns please let me know in this PR.

:+1: :+1: Thank you!

:+1:

thank you Piotr! :100:


belt bug that copies items

Describe the Bug
When I drop two or more items onto the belt, the items remains there meanwhile they are transported, so actually the items are copied.(forgive my poor English)
Reproduction Steps
1.a driving belt
2.just throw items on it
Expected Result
the items should be transported
Screenshots and Videos
https://user-images.githubusercontent.com/106714014/174073454-b2801dfb-ce74-412c-8b43-a70fe44a9530.mp4
Crash Report or Log
No response
Operating System
Windows 10
Mod Version
0.4.1
Minecraft Version
1.18.2
Other Mods
No response
Additional Context
No response

fixed


XIVY-15332 Only enable apiDoc-Meta for Pro Designer

The JdtApiDocService does not work on neo (ivy.log gets flooded with warnings). I disabled the useQuery for the apiDoc if the app is not "designer".

I think I could do it that way. I took inspiration from the dataclass editor, where we also disable metas on the frontend using 'enable.' However, I think this isn't quite the same scenario. So should I instead fix this on the backend?

I think disable a button should be done in the frontend. but this is show info for a selection. this should be handled by the backend...


add required rpms-signature-scan task

Enterprise checks are failing with
✕ [Violation] tasks.required_tasks_found
  ImageRef: quay.io/redhat-user-workloads/app-sre-tenant/shared-pipelines-main/shared-pipelines-main@sha256:1f1c81526ffed8d5057efb4720fb832813b0439f76f1c6f79d98becc0ea818ff
  Reason: Required task "rpms-signature-scan" is missing
  Title: All required tasks were included in the pipeline
  Description: Ensure that the set of required tasks are included in the PipelineRun attestation. To exclude this rule add
  "tasks.required_tasks_found:rpms-signature-scan" to the `exclude` section of the policy configuration.
  Solution: Make sure all required tasks are in the build pipeline. The required task list is contained as
  xref:ec-cli:ROOT:configuration.adoc#_data_sources[data] under the key 'required-tasks'.

/retest


[Bugfix] Activate Unused Colour (#3)

This Pull Request will activate the currently unused colour base07 from the coulour scheme definition.  But it will also require further maintenance of the existing colour schemes.
At the moment, many colour schemes define an arbitrary colour for base07 which was not assumed to be applied.  The resulting appearance due to the activation is not always what users might expect.  Hence, the fields base04 and base07 of many themes need to be adjusted.
Since this Pull Request is not done, yet, but merely for discussion, I am looking forward for constructive feedback and ideas.

If activating the colour at all, what should be coloured with?  I would like to suggest to apply the colour onto the status bar.

The colour is unused because of the almost similar names for base01 and base07 in the conversion function:  lighter_background versus light_background.  Zee's default theme uses indeed base07 for is_not_modified such that activating this would be intended behaviour.

I just counter-checked all colour schemes.  This Pull Request will be an enhancement for all of them since it highlights the very important change status and position (line / column number) fields.

I am going to squash the submitted commits and to re-submit them in a fresh Pull Request.