Added Inbound networkfilter idletimeout

Please provide a description of this PR:
To help us figure out who should review this PR, please put an X in all the areas that this PR affects.

[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[x] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure

Please check any characteristics that apply to this pull request.

[ ] Does not have any user-facing changes. This may include CLI changes, API changes, behavior changes, performance improvements, etc.

@hzxuzhonghu: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
a1696d6444cdc9d5a8e2fc5a4055619b41171210
link
true
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
a1696d6444cdc9d5a8e2fc5a4055619b41171210
link
true
/test release-notes_istio

integ-pilot-multicluster-tests_istio
a1696d6444cdc9d5a8e2fc5a4055619b41171210
link
true
/test integ-pilot-multicluster-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest


Remove FIX_TO_WORK_ON_JAVA9 constraints from tests that pass with Java9+

@Requires(TestPrecondition.FIX_TO_WORK_ON_JAVA9) ignores the test if it is run on JDK9 or newer.
This change removes this restriction from tests that actually work with JDK9+ now.

Thanks for doing this cleanup @rieske. Did you look at all the tests with that annotation? Can you maybe update this issue with what you have learned: https://github.com/gradle/gradle-private/issues/2955?


chore: contributors

@all-contributors please add @kaname-png for bug, code, doc, ideas, maintenance, projectManagement, review,

@all-contributors please add @kaname-png for bug, code, doc, ideas, maintenance, projectManagement, review,


Cache number of violations per build

We display the number of violations per repo on the account page (for
paid repos). That was causing timeouts, since repos can have many builds
and sql IN uses a loop for large arrays.
To speed things up, we can cache the number of violations (messages) per
build.

:+1:


Fix small typo in numpy notebook

Hope I haven't misunderstood anything :)

Great catch! Merged, thanks a lot for your contribution @vladimir-tikhonov !


Edge TPU slower than CPU running inference

Hi,
First off I do not know if this is the correct place to ask/report since I do not know if it's a bug or expected behavior. Please don't hesitate to close the issue if so.
I am using the Coral Dev Board and trying to run an extremely simple NN for the MNIST sample dataset on it. It's basically this:
def create_model():
  model = tf.keras.models.Sequential([ # Sequential model, easy mindmap
      tf.keras.layers.Flatten(input_shape=(28, 28)), # we need to flatten the matrix into a vector
      tf.keras.layers.Dense(128, activation='relu'), # Rectified linear activator
      tf.keras.layers.Dense(10), # 10 digits, so one_hot output
      tf.keras.layers.Softmax() # Softmax the previous output scores for the loss function
  ])
  model.compile(
    optimizer='adam',
    loss='sparse_categorical_crossentropy',
    metrics=['accuracy'] # Log accuracy
  )
  return model

The problem is that when benchmarking this model with 50k images the Edge TPU is taking 1876 ms and the onboard CPU 700 ms. Is this a bug or does the allocating of Edge TPU just take a set amount of time? It is also very plausible I coded it wrong, please let me know.
I trained the model for 5 epochs on my laptop CPU and compiled it for the Edge TPU, this produces this log:
Edge TPU Compiler version 2.1.302470888
Input: converted_model_from_keras_8bit_all.tflite
Output: converted_model_from_keras_8bit_all_edgetpu.tflite

Operator                       Count      Status

SOFTMAX                        1          Mapped to Edge TPU
FULLY_CONNECTED                2          Mapped to Edge TPU
QUANTIZE                       2          Mapped to Edge TPU

Please see https://github.com/Bartvelp/edge_tpu_MNIST for the full code and steps to reproduce

@Bartvelp Humnn, this doesn't sounds right at all o_0
Allocating tpu should only take a long time the first time you load the model and then faster after that. I was able to replicate your issue exactly on my dev board and it's quite puzzling.
 Considering that I have a 12 cores processor @3.2Ghz I'm also iffy that it performs slower than the dev board's quadcore arm cortex. I wonder if this is either due to python caching is doing something behind the scene + the fact the tflite cpu model was optimized for arm processor?

So I did some investigating and got the following results on the dev board.
Speed stats compared to amount of parameters

Parameters
On-chip memory
off-chip memory
TPU (ms/500 img)
CPU (ms/500 img)

20,587,010
7.82MiB
12.24MiB
16548
12751

12,585,010
7.83MiB
4.54MiB
6611
7837

7,999,550
7.84MiB
0
279
5494

1,176,450
1.33MiB
0
198
695

318,010
370KiB
0
156
154

15,910
51KiB
0
154
15

If the TPU needs to stream to much parameters from off-chip memory it becomes slower than the onboard CPU
Then there is a sweet spot where the TPU can use only on-chip memory and hugely outperforms the CPU.
But with less parameters than ~318k the CPU performance keeps getting better, but the TPU is hitting a plateau of 155 ms / 500 images.
According to google the mobilenet v2 NN has 3.4 Million parameters, which puts it in the sweet spot of the TPU. The Mobilenet NN is the model used in the example by Coral of python classification here.
Method
Tested using the following format of a model, by varing the size of all the dense layers, and sometimes removing or adding some to get the wanted amount of params.
def create_model():
	startingLayerSize = 784
	sizeDenseLayers = 200
	model = tf.keras.models.Sequential([ # Sequential model, easy mindmap
			tf.keras.layers.Dense(startingLayerSize, activation='relu', input_shape=(784,)), # Rectified linear activator
			tf.keras.layers.Dense(sizeDenseLayers, activation='relu'),
			tf.keras.layers.Dense(sizeDenseLayers, activation='relu'),
			tf.keras.layers.Dense(sizeDenseLayers, activation='relu'),
			tf.keras.layers.Dense(10, activation='relu'),
			tf.keras.layers.Softmax()	# Softmax the previous output scores for the loss function
	])
	model.compile(
		optimizer='sgd', # stochastic gradient descent method that just works well
		# easiest to use loss function sparse_categorical_crossentropy, easiest to understand mean_squared_error
		loss='mean_squared_error',
		metrics=['accuracy'] # Log accuracy
	)
	return model

In this model the images are flattened before the benchmark, but I think it doesn't really matter anyways.
Can somebody reproduce these results?

I did a similar experiment before. In my case, I use changed the number of Dense layers.
I got the same result as you. Model with dense layers is slower on Edge TPU.
I think it's because Edge TPU is specialized in convolution operation. (and I think it right strategy because Conv occupies a majority of inference time in most models.
The above is my result. model is generated this code ()

@Bartvelp
I did a similar experiment before. In my case, I changed the number of Dense layers.
I got the same result as you. Model with dense layers is slower on Edge TPU.
I think it's because Edge TPU is specialized in convolution operation. and I think it's right strategy because Conv occupies a majority of inference time in most models.
The below is my result. model is generated this code (https://github.com/iwatake2222/EdgeTPU_Analysis/blob/master/Ops/)
Model with convolution ops is super fast, while model with dense ops is slow on Edge TPU

Dense only model

Layer Num
Model Size [MiB]

Time [msec]

filesize
On-chip memory used
Off-chip memory used
CPU
EdgeTPU

100
1.458
0.993
0.268
0.8
1.4

200
2.911
0.993
1.540
1.8
5.8

300
4.368
0.993
2.810
2.4
9.4

400
5.825
0.993
4.080
2.9
13.1

Conv only model

Layer Num
Model Size [MiB]

Time [msec]

filesize
On-chip memory used
Off-chip memory used
CPU
EdgeTPU

10
0.493
0.876
0.000
1200.5
7.8

25
1.240
2.320
0.000
3165.0
20.1

50
2.481
4.710
0.000
6448.1
40.7

75
3.730
5.000
1.060
9688.7
61.6

100
4.981
5.000
2.250
12991.6
82.7

Thanks for your results, I guess that makes sense with the design of the Edge TPU. I can confirm that I'm seeing similar results.
I am also seeing results like @Namburger, where the dev board CPU is way faster than my quadcore i7, weird.

This is just my guess but I think TensorFlow has lots of optimization for ARM CPU.

I also observe the similar result with @iwatake2222's report. However, it's not intuitive for me that why edgetpu is only optimized for convolution operation and not for dense operation.  I assume that conv. is fundamentally transformed into matrix multiplication as well.


can't build

elrut@linuzzzz:~/thdwb$ make
assets/icons.go:3:8: package embed is not in GOROOT (/usr/lib/go-1.15/src/embed) make: *** [Makefile:11: run] Error 1

how should i fix it

Please report your local go version. i.e. go --version


no pairing or logs. what do i wrong?

I bought a esp32 and the receiver.
I want to pair my telis remote but doens't received something.
Updated to 1.7.0
my layout is:

I enless checked but can't see what I do wrong.

Did the Radio Not Initialized message go away?  Check the carrier board to ensure TX and RX map to GPIO12 and 13 respectively.  Typically these are mapped to 1 and 3.  Make sure GDO0 is connected to the pin you identify as TX in the setup and GDO2 is connected to the pin you identify as RX in the setup.  Alternatively, you can use only the GDO0 pin but assign both RX and TX to this pin.

I am not familiar with that carrier board but almost always GPIO 12 and 13 are on the other side of the board.

thank you for your quick response!
I bought this board: https://nl.aliexpress.com/item/1005004268911484.html?spm=a2g0o.cart.0.0.477461d7xFTlgm&mp=1&gatewayAdapt=glo2nld
the pin layout is:

12 and 13 are indeed on other side. but it has also separated rx tx pins. (gpio 1 and 3)
I have changed that in your interface and I got an rssi and see logs :)
I don see a not initialized message before although the wires were not correct.
I can continue!  thank you very very much.  hope this message can help others as well

Keep in mind gpio 1 and 3 are attached to the UART on the chip.  The TX pin will attempt to send output on boot through a debugger and pin 3 must remain high at boot or it will go into debug mode.  It should be fine unless you notice weird happenings when the board is booting.  I try to shy away from any pin that has special purpose during boot.

Hi, I have a similar issue. I cannot pair. Nothing happens on both my blinds and awning. At first I thought the memory of the blinds was full so i did a factory reset. To no avail.
I have also the ESP32-Wroom32 bought from azdelivery (https://www.azdelivery.de/nl/products/esp32-developmentboard).
I have used the default, suggested wiring from you and I have the radio working. I am getting nice reception, I see it in the logs and everything seems to work until I try to pair. I get the blinds in pairing mode (push prog on remote, wait for jog, then push on prog on the espsomfy page) but nothing happens. Neither on the blinds or on the awning. The esp is within 2.5 meters from the blind and 2 meters from the remote. Whenever I try to pair (i suppose transmit) a red light flickers on the esp.
see screenshots

Which transceiver do you have is it an E07-M1101D-SMA?  If it is trace pin 3 (GDO0) on the transceiver and given your setup above it should connect up to D12 or GPIO12.  If if connects to D13 or GPIO13 then swap the RX and TX settings.

Also if it is an E07-M1101D-SMA your max TX power is 10dbm.

Not weird at all that you could receive but not transmit.  That is because the TI chip can receive on either GDO0 or GDO2 but only transmit on GDO0.  You are not the first to confuse this with serial comms though where, it is actually TXD and RXD which in many instances the D is silent and how the pins are actually read is determined by the protocol.
I am trying to formulate the magic text that will allow folks to understand these differences.  It is funny that it seems folks with a greater exposure to these type of electronics are more likely to think of it as a serial transmission whereas the peeps with little exposure just match the pin numbers and set the configuration.   What makes this more confusing is that you can even use a single pin for both TX and RX so long as it is connected to GDO0.
I could use GDO0/2 but that is even more confusing when you read the transceiver docs.

Glad you got it working.  I am going to close this for now.


Typo

LastProccesedTimeUtc should read LastProcessedTimeUtc.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: b835bf35-1614-2d8d-13ab-176c6d839047
Version Independent ID: ed4653f3-e393-dd42-5960-87888c08ba40
Content: Pull Windows Defender ATP alerts using REST API
Content Source: windows/security/threat-protection/windows-defender-atp/pull-alerts-using-rest-api-windows-defender-advanced-threat-protection.md
Product: w10
GitHub Login: @mjcaparas
Microsoft Alias: macapara

Fixed--thank you!


Allow choosing which C++ standard library to use

Closes #39.
This implements my proposed solution to issue #39 (with some slight changes). If you prefer a different solution, feel free to close this PR.

Awesome, thanks! I think perhaps though just a plain string may be best suited here? Unfortunately new variants of Stdlib can't be added backwards-compatibly, so it'd have to be frozen today (which I'm not super sure about). I also feel like the extra value of having an enum doesn't necessarily pay off in this case.
Perhaps something like:
pub fn cpp_stdlib(&mut self, stdlib: &str) -> &mut Self;
pub fn link_cpp_stdlib(&mut self, link: bool) -> &mut Self;

Sure that sounds good, although I don't think we really have to worry about adding new variants to StdLib because the creation of a new C++ standard library is probably a pretty rare occasion.
Anyway, instead of using two separate functions, I would use just one that takes an option. We can also define known std libs as constants and provide a function to retrieve the default stdlib for the current target. Something like:
const LibStdCpp: Option<&'static str> = Some("stdc++");
const LibCpp: Option<&'static str> = Some("c++");

pub fn target_default_libstd() -> Option<&'static str> { ... }

pub fn set_cpp_stdlib(&mut self, stdlib: Option<&str>) -> &mut Self {}

Alright, I implemented the new design and have to agree that it looks much cleaner & flexible than using the enum.

Perhaps this could avoid the target_default_libstd and public constants for now? I can see where there might be a use for them, but I would prefer to start out conservative and just add the ability to customize the C++ standard library in use.

Sure. Then we just default to libstdc++, no matter the target? And from an api design standpoint, should Config::cpp_std_lib take a String or a &str and clone it internally?

Oh I think it's fine to use libc++ on OSX by default (as it's probably what you want anyway), and I'd take Option<&str> and clone internally (this API has basically no performance impact at all).
Perhaps also cpp_stdlib as the method name? (e.g. it's rarely broken up into "std lib")

I think it's either stdlib or lib_std (which I'm currently using). But either is fine with me.

Sure!

Alright, I removed the public constants / function and used stdlib everywhere.

Thanks!


Can I print the theme colors?

I would like to print the theme colors and formatting, is this possible?

Current specifications can not answer your expectations.
In the case of a darkly colored theme, is the background color of printed matter black good?  If you forcibly change to white, there is a problem that the code color after printing is too thin this time.
So, there are no plans to support at the moment.

is the background color of printed matter black good?

That's exactly what I need, is this possible?


tag and push latest image.

tag and push latest image for each commit on master branch.
/cc @kuanf

/lgtm


icons not found when using in addon (v1.2.2)

I have to add
  svgJar: {
    sourceDirs: ['tests/dummy/public']
  }

in order to see icons in the viewer when serving the dummy app. Haven't tried yet in an app that uses this addon.
According to #52 this shouldn't be necessary. What gives?
My addon is namespaced in case that is important.

How would one change configuration options (e.g. adding sourceDirs) in an addon?

I'm too banging my head with this issue. Can we pass config from one addon to another???

I had to figure out this problem too. The index.js file of your ember addon should look like:
/* eslint-env node */
'use strict';
module.exports = {
  name: 'your-ember-addon',
  options: {
    svgJar: {
      sourceDirs: [
        // In my case I wanted to load the files in a folder inside of the addon folder:
        'node_modules/your-ember-addon/mysvgfolder',
      ]
    },
  },

};


Move DataGrid to uberfire-widgets-table (the only place directly usin…

…g it).
This refactoring lets us remove the dependency on uberfire-workbench-client-views-patternfly
in uberfire-widgets-table.

Can one of the admins verify this PR? Comment with 'ok to test' to start the build.

ok to test

@mbarkley added you as a team member so your PRs don't have to be verified in the future.

@csadilek Thanks!
@ederign Please see my comment in this PR, explaining these changes.

@mbarkley thanks!


Segfault when serializing svg with xlink:title attribute

First of all, thank you for this amazing library!
When parsing + serializing the following html using lxb_html_serialize_tree_str(), a segfault occurs:
<!DOCTYPE html>

  <svg xlink:title="arrow">
  </svg>

This issue happens only when it's a <svg> element that contains a xlink:title attribute. As far as I can tell, no other xlink namespaced attribute has this problem.
Thank you for your time.

Hi @noam3127
What version of the library are you using? I tried it on the current code and everything works fine.
    lxb_status_t status;
    lexbor_str_t str;
    lxb_html_document_t *document;

    static const lxb_char_t html[] =
	"<!DOCTYPE html><svg xlink:title=\"arrow\"></svg>";

    document = lxb_html_document_create();
    status = lxb_html_document_parse(document, html, sizeof(html) - 1);
    if (status != LXB_STATUS_OK) {
        return EXIT_FAILURE;
    }

    str.data = NULL;

    lxb_html_serialize_tree_str(lxb_dom_interface_node(document), &str);

Result:
<!DOCTYPE html><svg xlink:title="arrow"></svg>

We're using v2.1.0. Is this something that might have gotten fixed in recent versions?

@noam3127
Try using a newer version, such as v2.3.0, or the latest one from the repository.
Please let me know if the problem has gone away.

Ok, after building from the latest source and testing locally, the problem is gone (as you predicted).
FWIW, this commit - https://github.com/lexbor/lexbor/commit/7ecf3661e000e504d6b7406a430a7b965a83fbc2 is the code that apparently fixed this bug, as testing any build from before then leads to that segfault.
Thanks again for your help.

@noam3127
That's an interesting side effect.  I'm thinking of parsing what exactly was there and why this patch with the addition of cloning fixed the problem.
At the very least to make sure there's nothing wrong there.
Thank you for your active participation!

I also performed a bisect and found a different commit that fixed the issue: 842754c0863c0d8d03a6ab8bb449f631139d99d5
This makes more sense. Prior to this commit the following happened:
The segfault happens because the address 0xba is dereferenced in lxb_html_serialize_attribute_cb when accessing lexbor_hash_entry_str(&data->entry). This is because data is equal to 0xba. Notice that LXB_TAG_TITLE is equal to 0xba and we're dealing with a (xlink:)title tag. Given the fix commit this indeed makes sense.

@noam3127  @nielsdos
thank you for all your hard work! I think I'll watch it tomorrow as well. Unfortunately, due to busyness I forgot about it.

I looked into this issue and yes the problem was fixed by patch 842754c. Tests for this are present in the patch.


Common aliases fsh-file

Create a common set of aliases to be used across IG-s (and then use it across IGs).
This is helpful for:

finding urls for relevant code systems and value sets
copypasting parts of fsh code from one IG to another

This is not a strong governance issue. Just had that idea while replacing sct and snomed, and atc and who-atc, for the 100th time while copying bits of examples from one IG to another.

I started doing this for the HL7 EU related IGS extracting system aliases

the question is where to maintain the source of truth


fix: node mudules not found

Connects to #137

Coverage remained the same at 93.939% when pulling 8376519fb90487cae72fe43b7d54cd8cc52b8ca8 on helio-frota:lr-137 into dd56e7d60e333dc67ee4f419aa9d8e818d33d298 on bucharest-gold:master.


Table without a Thead

I'd like to be able to create a Table that doesn't have a heading and I haven't been able to figure out a way to do it in version 0.13.2. Does this feature exist somehow and I've missed it?
If this feature is within scope and does not exist, I'd like to make a pull request with the following change:

add prop hideTableHeader to Table, similar to hideFilterInput.

Thoughts?

yeah, that'd be fine for me, though I'm curious about your specific use case

In my case, it's mainly to format a name/value pair with table-like behavior; like a transposed table where the rows serve as the labels and the columns have the potential to grow.
Besides that, the HTML standard says a thead is optional so, I figure, why the hell not :)


Update machine type for GPU node pools

This PR changes the machine type for the GPU node pools to a family we have quota for, according to https://github.com/2i2c-org/infrastructure/issues/930#issuecomment-1028205052
It also removes the node taint and uses a label to identify gpu nodes instead

This has already been deployed successfully


Difference between shared/node and server

Is there a difference between the src/server and src/shared/node folders as to how Webpack handles it?  I am placing my API code in server folder. Not totally clear on what the node folder is for either. All I can think of is potential code for SSR that is server only. Is this correct?  Thanks for clarifying.

Hi @cyberwombat
Yeah, you are completely right to put your API code in your server folder.  The node folder exists in the case that there is some code that is shared between the server and the universalMiddlware bundles.  Both of which are node target bundles.
I hope that makes sense. :)


[Backport to v0.7] Upgrade Grafana to v7.3.5

Backport #1860 to v0.7 branch.

✔ epicli apply: AWS/Azure x Ubuntu/RHEL with monitoring component enabled.
All tests passed. I was able to login to Grafana and import dashboards.


MSID: 100885 Version: 1 DOI: 10.1101/2<IP_ADDRESS>2030

MSID: 100885
Version: 1
Preprint DOI: https://doi.org/10.1101/2<IP_ADDRESS>2030
Step 1. Awaiting reviews
Editorial to post reviews via hypothesis
Useful links:

DocMap: https://data-hub-api.elifesciences.org/enhanced-preprints/docmaps/v2/by-publisher/elife/get-by-manuscript-id?manuscript_id=100885
New model tracking: https://docs.google.com/spreadsheets/d/1_fHaoOy7hjyocptKtVJRijeNpUY4hBS7Ck_aVmx6ZJk/
Reviews on sciety: https://sciety.org/articles/activity/10.1101/2<IP_ADDRESS>2030

For trouble shooting (e.g. no Docmaps available):

DocMap issue addressing: https://miro.com/app/board/uXjVNCwK6EI=/
Explore DataHub DocMaps API: https://lookerstudio.google.com/reporting/4c2f0368-babb-4beb-b5b3-497e7e7b0f08/page/ejphD
Unmatched submissions and preprints: https://lookerstudio.google.com/u/0/reporting/9f86204f-3bf7-477c-9b18-5c5ef141bf69/page/p_gxi57ha93c
Unmatched manuscripts spreadsheet: https://docs.google.com/spreadsheets/d/15QcK8w-ssB7109RQEDtFpJPZ0J5HTGxoHa_2TtpMBbg/edit#gid=1336081641

Step 2. Preview reviewed preprint
Production QC content ahead of publication
Instructions:

QC preview: https://prod--epp.elifesciences.org/previews/100885v1
Update ticket with any problems (add blocked label)
When QC OK, add QC OK label to ticket and add publication date and time to https://docs.google.com/spreadsheets/d/1amAlKvdLcaDp5W8Z8g77NmkwbMF5n_u89ArSqPMO8jg
Move card to next column
(At end of the day post link in #enhanced-preprint and ask for PDF to be generated)

Useful links:

Preprint DOI :  https://doi.org/10.1101/2<IP_ADDRESS>2030
Confirm reviews returned by EPP: https://prod--epp.elifesciences.org/api/reviewed-preprints/100885/v1/reviews
To update the MECA path in the docmap: https://docs.google.com/spreadsheets/d/1mctCQuNFBjSn97Lihy7_vBO6z7-N-oqyLv4clyi6zHg

Step 3: Awaiting search reindex
This step adds the reviewed preprint to the homepage: https://elifesciences.org
The search reindex is triggered once an hour. We need the reviewed preprint to be indexed as the search application serves the journal homepage.
Useful links:

Jenkins pipeline to reindex search can be triggered sooner or monitored here: https://alfred.elifesciences.org/job/process/job/process-reindex-reviewed-preprints/

Step 4: Published! PDF requested
Waiting for PDF to be generated
Useful links:

PDF tracking: https://docs.google.com/spreadsheets/d/106_XeDjmuBae7gexOTNzg60lapeqjl2aRn9DzupGyS8/

Step 5: Introduce PDF to data folder and git repo
Upload PDF to relevent folder in git repo https://github.com/elifesciences/enhanced-preprints-data/
Step 6: Done!

[ ] Kettle is on!

Hi @acollings, just checking is the RE affiliation missing the usual details i.e. city and country?

Hi @rkcook312 fixed!

sent author WOS update

chased


Resizable Window Dialog with set Rect.MinSize moves when hitting minsize

Godot Version: 3.1.beta1
Used on: Windows10

When using a Window Dialog Node, and setting this to be 'resizable', while also having set a minimum X or Y size for the Window Dialog, the behaviour of the window seems inconsistent. When resizing the window from the right or bottom, it will stop when it reaches the minimum size, and not allow the user to size the window to be any smaller. When resizing the window from the left or top, it will start moving in the direction you are resizing in, when it reaches the minimum size.
I expect it should not move at all, and stay in place when being resized while already at it's minimum size.
REPRODUCTION STEPS
1. Create an empty project.
2. Add a 'Window Dialog' node to a 2D scene, and make it visible.
3. Make the Window Dialog 'resizable' in the inspector.
4. Give the Window Dialog a Min(imum) Size in the Rect tab of the inspector.
5. Play the project.
6. Resize the Window Dialog from the left side, towards the minimum size, and compare this with resizing the window from the right side.
7. Resizing from the left side of the window will cause the window to move across the screen when it hits it's given minimum size, while resizing from the right will not.

Duplicate of https://github.com/godotengine/godot/issues/23831 ?

Ah, you're right. I looked around for earlier reports already, but I must have missed yours.
Good to see the bug is already known about!


tunnel serivice fails after several hours with  Error getting authorization:

Does this issue occur when all extensions are disabled?: Yes/No

VS Code Version: ./code -V
code 1.82.2 (commit abd2f3db4bdb28f9e95536dfa84d8479f1eb312d)
Laest as client
OS Version:  ubuntu 2022 on server side windows 11 on client side

Steps to Reproduce:

Take a vanilla ubuntu 2022 vm adn run ./code tunnel service install (also do sudo loginctl enable-linger $USER)
USe for a couple of days. Vs code will get disconnected and not reconnect
./code tunnel service log will get

-> % ./code tunnel service log
● code-tunnel.service - Visual Studio Code Tunnel
     Loaded: loaded (/home/pmiller/.config/systemd/user/code-tunnel.service; enabled; vendor preset: enabled)
     Active: active (running) since Mon 2023-10-02 04:19:00 UTC; 16h ago
   Main PID: 1287297 (code)
      Tasks: 10 (limit: 38516)
     Memory: 3.0G
        CPU: 3h 14min 1.737s
     CGroup<EMAIL_ADDRESS>             └─1287297 /home/pmiller/code --verbose --cli-data-dir /home/pmiller/.vscode/cli tunnel service internal-run
Oct 02 20:40:20 millercloud2 code[1287297]: [2023-10-02 20:40:20] trace refresh poll failed, retrying: Error getting authorization: authorization_pending The authorization request is still pending.
Oct 02 20:40:25 millercloud2 code[1287297]: [2023-10-02 20:40:25] trace refresh poll failed, retrying: Error getting authorization: authorization_pending The authorization request is still pending.

Where the last two lines repeat. uninstallign and installign again will fix the problem

This is likely a result of the GH access token expiring. In theory device code access tokens never expire, but in practice this doesn't seem to be the case; I think there's some limit to the number of tokens you can have for an account, as I notice if I'm developing something that is logging in a lot my older tokens can go bad.
I'm not sure this is something we can solve in the CLI. Interactive grant flows aren't really an option since many users set up the tunnel headless over SSH.

Headless ssh is definitely my setup. I am inside microsoft github org and would not be suprised if we had a policy that expired tokens faster than normal but there was no reloging when I unisntalled/installed.
Happy to dogfood anything since my vpn options are also either bad or forbidden.

Here's the doc that talks about the 10 tokens:
https://docs.github.com/en/apps/oauth-apps/building-oauth-apps/authorizing-oauth-apps#creating-multiple-tokens-for-oauth-apps
GitHub OAuth Apps don't issue refresh tokens, period. Only GitHub Apps do. Historically we've talked about moving to a GH App but it doesn't fit our scenarios. GitHub folks agreed.
There's an API for resetting a token:
https://docs.github.com/en/rest/apps/oauth-applications?apiVersion=2022-11-28#reset-a-token
which can be done without user interaction... I wonder if that's the best way to mark a token as "newest" and thus it won't be deleted by GitHub cleanup. We could do this in CLI & in the VS Code GH Auth extension so that the last thing you touched is always the newest token.
There's also an API for delete a token:
https://docs.github.com/en/rest/apps/oauth-applications?apiVersion=2022-11-28#delete-an-app-token
which we do in VS Code itself when the user logs out of their GitHub account.
A kinda clever approach could be to have the CLI ask for some random additional scope like... gists. Based on the 10 tokens doc above its 10 tokens per app id per set of scopes... so having the CLI ask for a somewhat unique set of scopes that wouldn't otherwise be used would limit the number of conflicts.

Yea, their docs are sparse but it sounds like the "token reset" is what we'd be looking for here. The scope idea is clever but I think that's more clever than I want to be! I'll introduce a refresh loop to reset the token every hour or so. That should be sufficient for most cases.

Update: looks like that endpoint only works for clients with a client secret, which we don't have 😢

From discussion and with Github, it seems like using the token should be enough to keep it alive. I'll need the refresh loop for AAD auth later this month, but for Github I'll just have it pull the current /user every hour while the tunnel's alive to keep the token at the top of the LRU list.

This bug has been fixed in the latest release of VS Code Insiders!
@paulgmiller, you can help us out by commenting /verified if things are now working as expected.
If things still don't seem right, please ensure you're on version 7d4027b62bb1e620e5454580450fa646682bc102 of Insiders (today's or later - you can use Help: About in the command palette to check), and leave a comment letting us know what isn't working as expected.
Happy Coding!

Grabbed 874831ebcf088f59735879156f62308ce48f17d1 and tunnel service installed Checking on if its still usable in 2 days.

This solved one issue but just left me with anotehr for a long lived tunnel. After a couple of days I get Last EH closed. Not sure what that is?  The next time you connect to that machine, a new VS Code server and extension host will get started up

Wasn't and am still not able to connect after that log message.  Service log still shows active and running but remotes->tunnels shows offline and tyring to connect fails.

Was there anything before those extension host logs you saw? Seems like the service lost track of the connected host relay (or it failed in a permanent way)

marking as verified since it sounds like the original issue was fixed. @connor4312 can decide to re-open or create a new issue for the remaining piece.

I'll open a new issue.


New version: yt-dlp.yt-dlp version 2024.07.02

Checklist for Pull Requests

[X] Have you signed the Contributor License Agreement?
[ ] Is there a linked Issue?

Manifests

[X] Have you checked that there aren't other open pull requests for the same manifest update/change?

[X] Does your manifest conform to the 1.6 schema?

Note: <path> is the directory's name containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

/azp run

@stephengillie, not sure why this didn't auto merge?

not sure why this didn't auto merge?
Because this? (my PR has same issue, but my PR was no this event)

not sure why this didn't auto merge?

Because of this? (my PR has same issue, but my PR not have this event)
These pull request(s) don't seem to have been automatically merged too: #161100

Yeah, I think, because the policy bot also approves the PR, the auto merge sometimes disables when lots of PRs are being approved at once. Like a race condition.

https://github.com/microsoft/winget-pkgs/issues/142854


Argument version: Regex Bug

I'm not a RegEx expert but it seems that not all version returned by
Get-NodeVersions -Remote
are supported by the RegEx validator for Argument -Version
v0.1.14 => Works
v0.1.100 => does not works => RegEx bug for the 3°number !?
my suggestion:
regEx is nice but always a high risk in errors/maintainance
remove the regex validator (use only NotNullOrEmpty and argumenttype string)
use System.Version.(try)Parse to convert the value => throw meaningfull exception in case of fail....

Do you have a scenario where a particular version of Node can't be installed or is this just a hypothetical?

i have used
Get-NodeVersion -Remote
to get a list of versions...the last one in the (unsorted) list was
v0.1.100
=> try to install with your PS-Function => Version-Argument fail
so please try/test with v0.1.100 to reproduce the issue
my second try: v0.1.14 => works immediately

huh, v0.1 went to over 100 builds, what do you know.
Is this something that you're trying to install or just an observation? Wondering how pressing it is to implement a fix

NO pressure to implement a fix!!
But i'm new here and this are the problems where i run into => ideas for usability improvements specially helpful for beginners!
Another usability problem that i see with old versions/builds:
That there are NO MSI files on Nodejs.org and you get a exception message that is not helpful
idea: find out the minimum version where msi files are available and use this to create a meaningful exceptionmessage...

Closing as there's been no activity on this for over 6 months.


Azure media player timecode and html id fixes

What's updated:

handling custom id of Azure Media Player container
integration with `media-services-javascript-azure-media-player-framerate-timecode-calculator-plugin  - real framerate is provided to timeline  https://github.com/mconverti/media-services-javascript-azure-media-player-framerate-timecode-calculator-plugin

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: ojczeo sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


Small toolbar buttons

Is there a way to set the toolbar button as small using the Material UI size attribute?

@DesignyourCode Currently there is no property to set the size of the IconButton. I will add it on a next release.

Brilliant, thank you

This is added on version 1.11.0

Amazing, thank you

Sorry yes I am setting it, but it's not shrinking the icons at all.

The default component for a ToolbarButton is an IconButton, so the small size is the one provided by material-ui which basically just removes the padding from the IconButton. You can still use custom toolbar button components if you require a smaller size.


strip copyright and trademark symbols from menu

#42

@cb-ndow This looks good - thanks for tackling this! I'll get this deployed once we have some CI set up.


OAuth Allowed Response and Grant Type checks

At least through CAS Management the allowed Response and Grant Types are added to the service as their corresponding enum values for marshaling/unmarshaling through Jackson.  This PR addresses an issue where validating an OAuth request fails because the enum name does not match specifically the response or grant type id for the protocol.  Specifically "id_token token" is affected.
This change first uses the enums valueOf() method to get the enum instance and then uses it's "type" field to compare the code that was received in the request.
It also adds ID_TOKEN("id_token") as a valid response type.

What do you think makes more sense here:
Change the expectation that Response and Grant types will use enum names in the service entries instead of type values? (i.e IDTOKEN_TOKEN instead of 'id_token token')
Change CAS Management to write the enum type values into the registered service?
To use the type() values we would probably need to add a valueByType() method to the enums.  The documentation doesn't set an expectation either way at the moment, but to change to enum names would be a breaking change to anyone who has set this by hand using the values.  Vice versa these won't appear correctly in CAS Managment at the moment if the values are set instead of enum names.

Change the expectation that Response and Grant types will use enum names in the service entries instead of type values? (i.e IDTOKEN_TOKEN instead of 'id_token token')

Not a good idea. The domain language must remain consistent with its configuration as much as and whenever possible. There is no such thing called IDTOKEN_TOKEN; that's an internal thing. The official value that every user should instantly recognize is id_token token. Our choice of enum use as an internal implementation detail should not have to dictate how one may configure something. (Java-wise, it's also considered bad practice more or less to rely on enum names; the error-prone-plugin will likely start issuing warnings for that sort of thing).

Change CAS Management to write the enum type values into the registered service?

This.

To use the type() values we would probably need to add a valueByType() method to the enums.

Sounds good to me.

Cool, I think it will be easier if I close this PR and submit a new one coordinated with CAS Management changes.


Other mouse clicks

Not sure if I haven't read the instructions properly yet but I couldn't see how to initiate a right click.
I guess it would be a little tricky as it would quite often bring up a context menu that may be hard to target.
Anyhow thanks for Scoot great idea!

You're not doing anything wrong -- support for right (and middle) clicking aren't actually implemented.
I quickly hacked together right click support last night, but (as you predicted) Scoot isn't able to interact with the context menu. (There are still other system shortcuts for selecting items in the menu, so that's good at least.) I want to try a few other things out before giving up, but I will add shortcuts for right and middle clicking regardless.

Check out #20, which dramatically improves clicking support.
(Unfortunately, I couldn't find a way for Scoot to take control of the mouse cursor when a context menu is active.)

Legend!
I'll take a look thanks!

Now available in v0.9: https://github.com/mjrusso/scoot/releases/tag/v0.9

This is awesome! thanks works well.
The context menu is very easy to use using existing OSX keyboard nav 👍


Add:

Channel Name
CHIVACOATV INTERNACIONAL
Alternative Names (optional)
Impulsando lo Nuestro
Network (optional)
Redes rikvik
Owners (optional)
No response
Country
VE
Subdivision (optional)
No response
City (optional)
Chivacoa
Broadcast Area
Venezuela
Languages
Es
Categories (optional)
No response
NSFW
FALSE
Launched (optional)
No response
Closed (optional)
No response
Replaced By (optional)
No response
Website (optional)
www.chivacoatv.com
Logo
https://www.chivacoatv.com/sitepad-data/uploads/2023/06/LOGO-CANAL-CHIVACOA-TV.png
Notes
https://vdo1.panelstreaming.live:3875/live/guarotvlive.m3u8

Duplicate of #4794


Index signatures in type definitions: now we have noUncheckedIndexedAccess, include or omit undefined?

lib Update Request

Before we had noUncheckedIndexedAccess, it was common practice to add undefined to an index signature as a workaround. For example:

https://github.com/microsoft/TypeScript/issues/13792 in which the index signature inside DOMStringMap (lib.dom.d.ts) was modified to include undefined.
https://github.com/DefinitelyTyped/DefinitelyTyped/pull/43931 in which all index signatures in @types/node were modified to include undefined (e.g. ProcessEnv and ParsedUrlQuery).

However, it seems this workaround wasn't extended to all index signatures, e.g.
RegExpMatchArray['groups'] in lib.es2018.regexp.d.ts and PropertyDescriptorMap in lib.es5.d.ts.
Now we have noUncheckedIndexedAccess I would like to ask what the best way forward is regarding these workarounds? For people who enable noUncheckedIndexedAccess, these workarounds are redundant. For people who don't enable noUncheckedIndexedAccess, these workarounds are still necessary—but potentially not always desirable since it forces a higher level of strictness.
It seems inconsistent that some index signatures use this workaround and others do not, so I think we should decide either to use this workaround in all index signatures or remove it from all index signatures and suggest people use noUncheckedIndexedAccess.
Including undefined creates a few problems, for example:
declare const v: DOMStringMap;

Object.values(v).map((value) => {
    // Expected: string;
    // Actual: string | undefined; ❌
    value;
});

for (const value of Object.values(v)) {
    // Expected: string;
    // Actual: string | undefined; ❌
    value;
}

const test: DOMStringMap = {
    // This should error
    foo: undefined
}

If the TypeScript team can decide the best way forward then this will also provide some guidance to the community—for example we're trying to decide what the best option is for @types/node: https://github.com/DefinitelyTyped/DefinitelyTyped/pull/51177.

Arguably, it should be possible to use the ? optional suffix on an index signature to force noUncheckedIndexedAccess for that index signature, e.g.:
interface Dict<T> {
	[key: string]: T;
}

declare const foo: Dict<number>;

// $ExpectType number | undefined
foo.prop;
//    ^?

if (foo.prop != null) {
	// $ExpectType number
	foo.prop;
	//    ^?
}

Workbench Repro

I think what's needed is a way to represent a Dict<V> (or Record<string, V>) type that is partial over string keys, rather than complete. Adding the ? optional suffix to the indexer type currently causes typescript to infer that the dictionary may contain undefined values, not just that some keys may be absent.
Lots of libraries / APIs in javascript use an Object with string keys that are not statically known, and values of a fixed non-null type. Some examples:

process.env, defined as Dict<string> in process.d.ts
APIGatewayProxyEventBase.queryStringParameters in aws-lambda, defined as Record<string, string|undefined> in api-gateway-proxy.d.ts in @types/aws-lambda

These cannot be satisfactorily represented in Typescript at present, because there is no way to have both of the following desirable properties at the same time:

map lookups are correctly nullable, i.e. r[k] is of type V | undefined
map iterations are correctly not-null, i.e. Object.values(r) is of type V[]

There are currently two choices that library authors can take to represent this:
A:  Dict<V> or Record<string, V> or interface Dict<V> { [key: string]: V; } -- this satisfies (2) but not (1).
This approach incorrectly assumes that all string lookups in process.env will return a string, but most will return undefined at runtime.
B: Dict<V | undefined> or Record<string, V | undefined> or interface Dict2<V> { [key: string]?: V; } -- this satisfies (1) but not (2).
This approach incorrectly assumes that iterating over the object may return undefined entries, i.e. Object.keys(event.queryStringParameters) is of type (string | undefined)[] rather than string[] because the library authors have chosen approach B to avoid the drawbacks of A.
Unless I'm missing something, there is no way to declare a type in Typescript that represents a js object with both properties (1) and (2).
I think this is needed in addition to the noUncheckedIndexedAccess flag, because library authors (like @types/aws-lambda) want to be able to avoid the pitfalls of A but can't do so without adding the drawbacks of B.

To clarify my above comment, which is perhaps over-long, sorry:
I think Typescript needs to add a new built in type that allows library authors to fully represent js objects used as dictionaries, because the current language support falls short (can't have both "1" and "2" as described above).
The recent changes to add noUncheckedIndexedAccess were a step in the right direction towards fixing this issue (which has been known about for a long time) but they are insufficient for library authors in the Typescript ecosystem, since it requires user opt-in. In the absence of a full fix for this issue, some library authors have been adding "| undefined" to their declarations, which fixes use-case (1) above but breaks use-case (2).

I've found that noUncheckedIndexedAccess really goes too far with the addition of undefined.
Code that checks for property array index should not have to deal with undefined but does and encounters errors. For example:
interface Rec { [prop: string]: string };
function foo(rec: Rec, key: keyof Rec): string {
	if (key in rec) return rec[key]; // error: TS(2322) Type 'string | undefined' is not assignable to type 'string'
	rec[key] = 'placeholder'; // ${key} now exists in rec
	return rec[key]; // error: TS(2322) Type 'string | undefined' is not assignable to type 'string'
}
function bar(): string {
	const strings = ["bar"];
	if (strings.length > 0) return strings[0]; // error: TS(2322) Type 'string | undefined' is not assignable to type 'string'
	return 'huh';
}

playground
So instead of enabling in it we've added notes of caution in code that we must remember to check that properties exist.

I've found that noUncheckedIndexedAccess really goes too far with the addition of undefined. Code that checks for property array index should not have to deal with undefined but does and encounters errors. For example:
interface Rec { [prop: string]: string };
function foo(rec: Rec, key: keyof Rec): string {
	if (key in rec) return rec[key]; // error: TS(2322) Type 'string | undefined' is not assignable to type 'string'
	rec[key] = 'placeholder'; // ${key} now exists in rec
	return rec[key]; // error: TS(2322) Type 'string | undefined' is not assignable to type 'string'
}
function bar(): string {
	const strings = ["bar"];
	if (strings.length > 0) return strings[0]; // error: TS(2322) Type 'string | undefined' is not assignable to type 'string'
	return 'huh';
}

playground So instead of enabling in it we've added notes of caution in code that we must remember to check that properties exist.

i also can't stop wondering how stupid TypeScript is still

@jason-ha I think this is my big issue with noUncheckedIndexedAccess. I would love to enable it, but it forces undefined on both Array and Record accesses alike. Quite a number of closed issues discuss this problem, and the concensus is that TypeScript simply can't know if an Array access is undefined or not and so it treats any indexed access as possibly undefined.
But this creates so many false positives for the programmer, as simply going through a for(let i = 0; i < foo.length; i++) loop causes false positives for any foo[i] access.
I would propose that noUncheckedIndexedAccess be the default for TypeScript, but only for Records, and not Arrays. Then we could have another option, maybe noUncheckedArrayAccess that also makes Array access possibly undefined for those that want that feature.
That change would solve this issue, whereby existing type definitions don't need to go adding undefined to all of their Record types, since it would be added by default to their indexed access in TypeScript. And additionally we wouldn't get all of the array access headaches associated with enabling noUncheckedIndexedAccess.


maximumLineLength allExcept functionSignatures - broken in IIFE

With jscs-2.7.0, maximumLineLenght.allExcept = ['functionSignatures'] does not work if such a function is wrapped in an IIFE block.
I assume that's a bug, right?
Simple case:
.jscsrc
{
  "maximumLineLength": {
    "value": 64,
    "allExcept": [
      "functionSignature"
    ]
  }
}

bug.js
function tooLongButOK_spam_spam_spam_spam_spam_spam_spam_spam_spam() {
}

(function() {
  function tooLongAndNotOK_spam_spam_spam_spam_spam_spam_spam_spam() {
  }
})();

(function() {
  "use strict";
  function tooLongAndStillNotOK_spam_spam_spam_spam_spam_spam_spam() {
  }
})();

I'd expect jscs to run on this without errors, but I get 2 errors.

It totally is! By looking at the code, it is not ideally implemented, one might say - badly implemented.
Do you wanna try to fix it

Sure, looks like a fun xmas project :) though after a (really) quick look the day before I couldn't really make heads or tails of it..
But if I'm fixing it, do we still really want this to not apply to var foo = function(...) {?

Judging by name of the option, i'd say it would be okay to make that changes.
Happy Christmas btw!

@markelog Thanks!, Merry Christmas to you as well :)
And what do you think of #2040?, should hopefully be a bit cleaner than the current approach..


Implemented a sound recognition system

Fixes #431

Added this feature that allows the user to input the sounds that they want to be heard by the system and give them a prompt that allows them to not miss it.

Why this feature?

For people with hearing issues or aides, this kind of features let them know if there is any emergency or harm to themselves or people around them.

@suryanshsk Could you please confirm this was a level2 when assigned.

We can't give this issues as level 2


Implement organization-level Load Balancer pool/monitor API calls

There is currently no way to access access organization level load balancer pool/monitor settings.
The API calls in question is:
Monitors:

https://api.cloudflare.com/#organization-load-balancer-monitors-list-monitors
https://api.cloudflare.com/#organization-load-balancer-monitors-create-a-monitor
https://api.cloudflare.com/#organization-load-balancer-monitors-monitor-details
https://api.cloudflare.com/#organization-load-balancer-monitors-delete-a-monitor
https://api.cloudflare.com/#organization-load-balancer-monitors-modify-a-monitor

Pools:

https://api.cloudflare.com/#organization-load-balancer-pools-properties
https://api.cloudflare.com/#organization-load-balancer-pools-create-a-pool
https://api.cloudflare.com/#organization-load-balancer-pools-pool-details
https://api.cloudflare.com/#organization-load-balancer-pools-delete-a-pool
https://api.cloudflare.com/#organization-load-balancer-pools-modify-a-pool

Pass UseOrganization
https://godoc.org/github.com/cloudflare/cloudflare-go#UsingOrganization -
the LB methods will then use the /organizations endpoints automatically.
On Wed, Apr 18, 2018 at 6:58 AM Jesper<EMAIL_ADDRESS>wrote:

There is currently no way to access access organization level load
balancer pool/monitor settings.
The API calls in question is:
Monitors:

https://api.cloudflare.com/#organization-load-balancer-monitors-list-monitors
https://api.cloudflare.com/#organization-load-balancer-monitors-create-a-monitor
https://api.cloudflare.com/#organization-load-balancer-monitors-monitor-details
https://api.cloudflare.com/#organization-load-balancer-monitors-delete-a-monitor
https://api.cloudflare.com/#organization-load-balancer-monitors-modify-a-monitor
Pools:

https://api.cloudflare.com/#organization-load-balancer-pools-properties
https://api.cloudflare.com/#organization-load-balancer-pools-create-a-pool
https://api.cloudflare.com/#organization-load-balancer-pools-pool-details
https://api.cloudflare.com/#organization-load-balancer-pools-delete-a-pool
https://api.cloudflare.com/#organization-load-balancer-pools-modify-a-pool
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/cloudflare/cloudflare-go/issues/178, or mute the
thread
https://github.com/notifications/unsubscribe-auth/AABIcBvsSOo9VrXQhOvXC7LeDdTBf_Tnks5tp0aFgaJpZM4TaHiM
.

Ahh so i needed to just RTFM.
Will close the issue then


Demos don't work on Android

Three-mesh-bvh simple demo no longer works, either. Should create a chrome android bug.

https://bugs.chromium.org/p/chromium/issues/detail?id=1392944


Use Docker multistage builds for reduced imagesize

This drastically reduces the size of the resulting docker image.
The image with the multi-stage-build tag is the new one (73MB uncompressed) whereas the other ones are downloaded from DockerHub (573MB).

Is there a way how I can run tests against the new image to see if it still works correctly?
I did a manual smoke test and it seems to be working fine!

Thanks @thomaseizinger! This looks very promising! I'm not a docker guru myself, so I'll tag in @benjamincburns or @seesemichaelj to get their feedback on this.
@seesemichaelj or @benjamincburns We should probably run our tests within the docker build, which looks like it'd be simple to configure with a multi-stage build, per: https://codefresh.io/docker-tutorial/node_docker_multistage/#creatingamulti-stagedockerfilefornode.jsapplication

Running them within the Docker is not as useful IMO because there are no
source code changes compared to outside of Docker. Integration-tests
against the HTTP API from the outside would shed light onto whether the
system behaves correctly.
On Thu, 16 Aug 2018, 07:37 David Murdoch<EMAIL_ADDRESS>wrote:

Thanks @thomaseizinger https://github.com/thomaseizinger! This looks
very promising! I'm not a docker guru myself, so I'll tag in
@benjamincburns https://github.com/benjamincburns or @seesemichaelj
https://github.com/seesemichaelj to get their feedback on this.
@seesemichaelj https://github.com/seesemichaelj or @benjamincburns
https://github.com/benjamincburns We should probably run our tests
within the docker build, which looks like it'd be simple to configure with
a multi-stage build, per:
https://codefresh.io/docker-tutorial/node_docker_multistage/#creatingamulti-stagedockerfilefornode.jsapplication
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/trufflesuite/ganache-cli/pull/563#issuecomment-413345840,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFO3Nbzi9Jz_-bfBi4KzAi78zkMrqc-wks5uRJSBgaJpZM4V9ye4
.

I like this idea, haven't reviewed implementation, however -- I'll leave that to you @davidmurdoch!

I actually already reviewed the implementation; this looks great! I was in the middle of testing when I discovered an issue with our latest release that I had to handle :sweat_smile:
Looking at this now

@seesemichaelj Just incorporated the request changes!

Thanks for merging this so quickly!
Any chance that this is backported to the v6.1.x release?

The 7.x series was not continued past v7.0.0-beta.0. I'm guessing @benjamincburns changed his mind and went to 6.1.0 instead.
The current series is the 6.1.x series. This PR will go into effect in 6.1.9, 6.2.0, or 7.0.0 (whatever is the next release, more than likely 6.1.9).
Perhaps we should look into removing the v7.0.0-beta.0 image from docker hub.

Oh. good to know!
Are there already plans for the next release?
On Thu, 16 Aug 2018, 15:52 Mike Seese<EMAIL_ADDRESS>wrote:

The 7.x series was not continued past v7.0.0-beta.0. I'm guessing
@benjamincburns https://github.com/benjamincburns changed his mind and
went to 6.1.0 instead.
The current series is the 6.1.x series. This PR will go into effect in
6.1.9, 6.2.0, or 7.0.0 (whatever is the next release, more than likely
6.1.9).
Perhaps we should look into removing the v7.0.0-beta.0 image from docker
hub.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/trufflesuite/ganache-cli/pull/563#issuecomment-413433760,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFO3NSSDHH8WEw8bHarowAL0-YVWKDNpks5uRQiNgaJpZM4V9ye4
.

Unfortunately no, as it's needed. We've been trying to do it regularly (seems ~2 weeks). Sorry I don't have more details!


Rotate image

It would be practical if an image could be roated by +-90 deg / 180 deg. A detection of portrait/landscape capture mode (e.g. on a smartphone) and according rotation would also be very helpful.

This library automatically reads image exif data and rotates image automatically. Are you facing any issues? If you install the exif extension, this functionality will automatically work.


Fix unsafe.Slice error with mllama

Fix the error and also improve error handling for the llama.cpp CGo layer.

s/Id/ID/g where this PR touches, would be nice.

Tests?

We already separately added a test that will trigger this on appropriately resource-constrained systems. I think it's hard to simulate that type of environment on other systems in a way that is broad enough to be worthwhile.


Adds Recording::find & moves Track::search into Recording::search

This is a rebase of PR: https://github.com/localhots/musicbrainz/pull/25
Breaking change: Track::search does not exist anymore and has been moved into Recording::search.
$ rspec spec/
............................................

Finished in 0.15818 seconds (files took 0.96443 seconds to load)
44 examples, 0 failures

Randomized with seed 25558

Thanks!


Fill main Dashboard

This PR present data recieved from backend on the overview page of the app, utils and overview page could use a little clean up but for now i will unblock the developemnt by pushing this one
Sample screenshot:

I have mixed feeling about this panel. It doesn't say which kind of actions were applied (created/moved/commented/etc.,) and some rows are duplicated. If it's not relatively easy I would just put sth like "recently commented task" with who commented. What do u think?
Also should label state "other"?


ResizeObserver

https://twitter.com/umaar/status/914960745338634240

ResizeObserver has landed in Chrome Canary! Get notified in JavaScript when an element resizes.

(There's a page for that feature
http://caniuse.com/#search=ResizeObserver
but perhaps the info from the tweet is of use.)

related: https://twitter.com/sl007/status/915201248957222912

Hm, just updated my Canary to 63.0.3235.0 and still not enabled by default.

Yeah, perhaps it still is behind a flag ...
https://www.chromestatus.com/feature/5705346022637568
https://bugs.chromium.org/p/chromium/issues/detail?id=612962

Still not enabled in Canary 64, so gonna go ahead and close this.


Regional masks based on EEZ shapefiles

Code to apply shapefiles to GCM (xarray) data and to obtain climate variable mean values etc for the actual EEZ area, rather than the closest fitting lat/lon box incorporating the EEZ region

Hi @Thomas-Moore-Creative, just wondering if you've had a chance to look at this one yet? No urgency.

Hiya, I'm back from leave.  I'll need to build some similar tools for a primary project and will share that on here so it's hopefully useful.  I don't have a timeline yet.  It will almost certainly use regionmask


provide better snippet for secret token generation

What does this pull request do?
While the previous snippet wasn't necessarily bad, it used
uuid4 for something it isn't intended to. Python 3 provides
a cryptographically secure token generator, so let's tell
our users to use that instead.

:green_heart: Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

Start Time: 2022-06-21T07:07:43.340+0000

Duration: 3 min 8 sec

:grey_exclamation: Flaky test report
No test was executed to be analysed.
:robot: GitHub comments
To re-run your PR in the CI, just comment with:

/test : Re-trigger the build.

/test linters : Run the Python linters only.

/test full : Run the full matrix of tests.

/test benchmark : Run the APM Agent Python benchmarks tests.

run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)


Use psql db in unit tests

/retest

/retest

/retest

/retest

going to force merge, dependencies on eph are broken :(


Add agent.Registrar and a register command

This adds a hidden register command that will be used with a forthcoming connect command for an advanced agent flow where you want to split the register from the agent execution, for instance when using a K8S or ECS scheduler.
This involves a pretty heavy refactor of the AgentPool. I split out the registration related parts into a Registrator which let me take a lot of complexity out of AgentPool. I'm pleased with the result and think it will make future custom agents much easier to assemble out of components.
This PR is 98% about the refactor and 2% about the register command, but interested in feels on both.

I could potentially split this into a few PR's if it's difficult to review.

Going to split this out.

This looks rad, I’m keen to see the split PRs! <3

The basic refactor that is needed to support this is in https://github.com/buildkite/agent/pull/956. Would love your feels on it @plasticine!


Armada-458 Improve logging in Jobbergate API

What
Improve logging in Jobbergate-API.
Why
We are not logging much in the Jobbergate-API. This makes it very difficult to triage problems that arise. We should add more debug logging to the API so that we can better tell where issues are happening.
Task: https://app.clickup.com/t/18022949/ARMADA-458

Peer Review
Please follow the upstream omnivector documentation concerning
peer-review guidelines.

Task linked: ARMADA-458 Improve logging in jobbergate-api


add test cases for fast_math.ispc

They should be optional because they require the ispc compiler to be present but it might be worth doing this.

Will have a look at this

ISPC backend have been removed in #963


why v1.1.7 is well, but v1.1.8 error status 1 or status 5

when Installed nvm v1.1.8, run nvm use xxx, error status1 or status 5.
v1.1.7 all is well.

This isn't enough information to actually diagnose a problem. My best guess is v1.1.7 was installed with admin permissions while 1.1.8 was not. Exit status 5 is an "Access Denied" from Windows itself.
Closing as a duplicate of #665 and #665.

I have the same issue, I double click nvm-setup.exe to install nvm, however it seemed not popped up an admin permissions request dialog.

Same to me by using Git-Bash.I tried everything but got exit staus 1: You do not have sufficient privilege to perform this operation.

me too


Pretrained models

Hi! Do we have pretrained models for this work? It would be nice to run inference on a couple of images to see what would we obtain, plus, a good starting point for training. Thanks!

Hi! Do we have pretrained models for this work? It would be nice to run inference on a couple of images to see what would we obtain, plus, a good starting point for training. Thanks!

Hello, I am also interested. Thanks.

I would also be interested in some pretrained weights of the model. Many thanks in advance! :)

I would also be interested in some pretrained weights of the model. Many thanks in advance! :)

can u offer a weights？ thanks！

It's so strange that the author didn't apply any pretrained model for reproduce the results. Is there anyone who can support me the pretrained model?


[FN] Set the Block.BlockSize property only on first serialization

This supersedes
https://github.com/stratisproject/StratisBitcoinFullNode/pull/3942
To ensure the BlockSize is set only once with the correct deserialization parameters.

Yeah I will fix the tests now.
What we need is first consistency and second to have the true value of the block size.
It's possible to calculate the block size without relaying on the BlockSize property (for other cases like the block size rule)
My change introduces consistency however it may in some cases not capture the real block size (in case serialization is done first with different Options param
I'd say this is the best e can achieve without too much refactoring.

@zeptin this seems fine now

@dangershony pardon my ignorance but I'm still a bit unsure as to why this change is needed? What is the issue with setting the block size again after serializarion?

What is the issue with setting the block size again after serializarion?
When you serialize with segwit options and without segwit options you get different results of the block size (segwit is an exmapl we may have other things that determine serialization)

So this PR will capture the first size which should be the correct one as it gets des from the network.


warning and error on save

warning and error on save
[LSP] Format request failed, no matching language servers.
vim.lsp.buf.formatting_sync is deprecated. Use vim.lsp.buf.format instead
"/d/xxxxx/main.go" [noeol] 40L, 1072B written

What is your neovim version?


Add is about relation to quantity values

Description of the issue
From PR  #697
We almost never use the axiom something quantity value is about something. Nevertheless, this relation would make the quantity value subclasses more transparent.
Ideas of solution
Add the is about relation to all quantity values to relate them to the respective concepts they are about.
Maybe it would be possible to add is about as non-reflexive inverse of has quantity value.
Workflow checklist

[ ] I discussed the issue with someone else than me before working on a solution
[ ] I already read the latest version of the workflow for this repository
[ ] The goal of this ontology is clear to me

I am aware that

[ ] every entry in the ontology should have a definition
[ ] classes should arise from concepts rather than from words

I don't understand what you mean with non-reflexive inverse. Can't we define a simple inverse quantity value of like we have has input and input of?

If I understood @jannahastings right, the relation that is usually used for quantity values is is about. Anyway, is about is quite a broad relation and we use it for other concepts, too.

Yes, is about is usually used for quantity values. But we could define a sub-property of is about just for quantity values and call it quantity value of if we prefer?

Sounds like a practical solution.

https://github.com/OpenEnergyPlatform/ontology/pull/710#issuecomment-822437565:

It's just that the relations between the quantity values and the "entities in reality" are not yet added. I was wondering, if this sould be done automatically or manually.

I don't think there is much here that can be done automatically, because 'hub height' SubClassOf 'has quantity value' some 'length value' doesn't entail 'length value' SubClassOf 'quantity value of' some 'hub height'. Or in other words: even if we know that an entity in reality is connected to a specific quantity value we still have to define to which entities in reality the quantity value can be connected.
I also don't think that we need to connect every quantity value to a certain set of entities in reality, but here are some axioms I found based on the existing textual definitions / other axioms:

coefficient of performance value SubClassOf quantity value of some energy conversion performance
declared net capacity SubClassOf quantity value of some power generating unit or power plant
duration SubClassOf quantity value of some one-dimensional temporal region (instead of is about some one-dimensional temporal region)
emission quantity value SubClassOf quantity value of some emission value
nameplate capacity SubClassOf quantity value of some power generating unit or power plant
power rating SubClassOf quantity value of some energy converting device
storage capacity SubClassOf quantity value of some energy storage object

This issue has been solved in PR #710, so I will close it.


Client side SSL configuration

I'm getting "Authentication error, check host, port, and login information" in the client when trying to authenticate to a server that requires SSL to connect.  I've imported the server's  intermediate certificates into the java keystore but it doesn't seem to have changed the error that I receive.  On the irods server I see
Mar 31 13:40:04 pid:107553 ERROR: [-]   iRODS/server/core/src/rodsAgent.cpp:222:main :  status [SYS_INVALID_INPUT_PARAM]  errno [] -- message []
[-]     iRODS/server/core/src/irods_server_negotiation.cpp:152:client_server_negotiation_for_server :  status [SYS_INVALID_INPUT_PARAM]  errno [] -- message [SSL is required by the server but not requested by the client]
How can I configure irods-cloud-browser to require ssl?

will merge in with install notes issue, this is a config issue.


Need to create automated tests

Use pytest to write some tests for all primitive property types, structs, and File reader/writers.

Write and Reread tests are completed for the most part. Still need to write more tests for other components though.


PR Summary

PR Summary
Files OK, 8Files in PR:  8
Tokens in PR (4):

BEP2 TUSDB-888
ERC20 0x0000000000085d4780B73119b644AE5ecd22b376
BEP20 0x14016e85a25aeb13065688cafb43044c2ef86784
TRC20 TUpMhErZL2fhh4sVNULAbNKLokS4GjC1F4

Token BEP2 - TUSDB-888:
Symbol: TUSDB decimals: 8
Links: Logo Info Website Explorer
Token check error:
!  No. of holders not checked, external info not available; null
✓  Token type OK (BEP2); Contract/ID is OK; Type field OK; Symbol field OK; Decimals field OK; Description field OK; Website field OK; Explorer field OK; Status field OK; Id field OK; Logo image type is OK (image/png); Logo image size is OK (15.64 kB); Logo dimensions OK (256x256);

Token ERC20 - 0x0000000000085d4780B73119b644AE5ecd22b376:
Symbol: TUSD decimals: 18
Links: Logo Info Website Explorer (check OK 🙂)

Token BEP20 - 0x14016e85a25aeb13065688cafb43044c2ef86784:
Symbol: TRUEUSD decimals: 18
Links: Logo Info Website Explorer
Token check error:
❌  Contract is not in checksum format, should be 0x14016E85a25aeb13065688cAFB43044C2ef86784 (not 0x14016e85a25aeb13065688cafb43044c2ef86784). Please rename it. You may need to rename to a temp name first, then to the checksum format, because lowercase-uppercase-only renames are often ignored by the Git client or the filesystem.
❌  Symbol does not match token info, expected 'TUSD' instead of 'TRUEUSD', please change.
✓  Token type OK (BEP20); Type field OK; Decimals field OK; Description field OK; Website field OK; Explorer field OK; Status field OK; Id field OK; Logo image type is OK (image/png); Logo image size is OK (15.64 kB); Logo dimensions OK (256x256); Token circulation OK (no. of holders: 8738);

Token TRC20 - TUpMhErZL2fhh4sVNULAbNKLokS4GjC1F4:
Symbol: TrueUSD decimals: 18
Links: Logo Info Website Explorer
Token check error:
!  No. of holders not checked, external info not available; null
✓  Token type OK (TRC20); Contract/ID is OK; Type field OK; Symbol field OK; Decimals field OK; Description field OK; Website field OK; Explorer field OK; Status field OK; Id field OK; Logo image type is OK (image/png); Logo image size is OK (15.64 kB); Logo dimensions OK (256x256);

Originally posted by @ghost in https://github.com/trustwallet/assets/pull/12649#issuecomment-895776087

Please submit the correct information, invalid information will cause the issue to close


How can i mock or create a stub TableResult for unit test?

I am trying to create an TableResult object for unit test but I couldn't do it. Do you have any example that I can refer to ?

Hi @erdemontas, apologies for the delayed response. We were not actively monitoring this repo's issues.
Can you share some error messages or code snippets that show TableResult not being created/ instantiated/ used properly in your unit tests?
We do have docs on our GCP reference website (i.e. https://cloud.google.com/bigquery/docs/writing-results#writing_large_results_using_legacy_sql)


JSON-LD: Use UltraJSON if available

Motivation: https://github.com/scrapinghub/extruct/issues/37#issuecomment-284255022

#69

If you were to use something else than the built-in json for parsing, you'd probably want to also change https://github.com/scrapinghub/extruct/blob/master/extruct/jsonld.py#L38 that uses built-in json  behind the scenes.
You could use the comment-removal function from jstyleson directly.
Or, use https://pypi.org/project/nojsoncomments/ that uses the exact same logic for comment removal but is over twice as fast. The use case if somewhat marginal of course, and it's a Cython extension so someone would have to provide Windows & Linux wheels (I'm on a Mac).


chore: bdd-nh-1591264668 to 0.0.1

chore: Promote bdd-nh-1591264668 to version 0.0.1

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


homeassistant: Integrate with systemd notify

The aim of this change is to switch the systemd service from simple to
notify. For this to work, the systemd notify integration in
HomeAssistant was done as a custom component that notifies systemd when
HomeAssistant is started. This enables robust systemd service
dependencies for other OS components.
Signed-off-by: Andrei Gherzan<EMAIL_ADDRESS>

Works for me, I can make it start a web browser as soon as HA is up.


Make sure we read all the data on an Ultra 2 meter

See attached Trello card for details.

 Ultra 2 not uploading all available data on meter


Exception when searching using aggregation

First of all, thank you for creating an maintaining the project!
I started using flutter with elastic search yesterday and started using this package.
But when searching with an aggregation I unfortunately got an error in https://github.com/isoos/elastic_client/blob/master/lib/src/elastic_client_impl.dart in lines 130-134.
name = name;
value = m['value'];
values = m['values'] as Map;
docCountErrorUpperBound = m['doc_count_error_upper_bound'] as int;
sumOtherDocCount = m['sum_other_doc_count'] as int;

My search query:
client.search(index: 'sensordata', type: '', aggregations: {
      'values': {
        'composite': {
          'sources': [
            {
              'value': {
                'terms': {'field': 'sensorname'}
              }
            }
          ]
        }
      }
    });

I looked up in the documentation https://pub.flutter-io.cn/documentation/elastic_client/latest/elastic_client/Aggregation-class.html and found that values for example should be of type Map? but is, as seen in the code block above of type Map.
After making the fields values, docCountErrorUpperBound and sumOtherDocCount nullable everything worked fine.
Can anybody confirm that problem?

Yeah, that may be of a problem. Would you be able to create a PR with the fix? I'd be happy to review and merge it...

Yeah, that may be of a problem. Would you be able to create a PR with the fix? I'd be happy to review and merge it...

Yeah sure.


Initial support for Slave Request Handler

Not all slave requests are implemented at the moment, only the small subset required by virtio-fs. That said, it should be fairly straightforward to add the rest though.
The SlaveReqHandler struct creates the slave-master socketpair, handles all incoming / outgoing message validation, and routes messages to the appropriate handlers. SlaveReqHandler::new accepts a struct that implements VhostUserSlaveReqHandler, with users overriding the default handlers. SlaveReqHandler::new also returns a UnixStream that must be sent to the slave via Master::set_slave_request_fd.
As both master and slave requests share the same wire-format, it can be easy to mix up the two when handling requests. To mitigate these issues, PhantomData markers are added to Endpoint and VhostUserMsgHeader specifying if they operate on MasterReq messages or SlaveReq messages.
Lastly, some library internals, notably the Listener and Endpoint structs, have been marked as pub(crate). This necessitated a small refactor of how Slaves are constructed, introducing a SlaveListener struct which returns a valid Slave when the socket accepts a connection.
cargo tests are passing, and handlers are being tested in crosvm (see this CL). Expect tweaks as behavior is tested, and inevitable bugs are discovered.
Further considerations:
Since VhostUserSlave is implemented by users, it's methods should return user errors, not vhostuser_rs errors. VhostUserSlaveReqHandler methods return Boxed errors, and it might make sense to update VhostUserSlave to do the same.

I'm a bit confused about how Listener's are supposed to work now - I've got the start of a vhost-user client program, and I was using Listener::new(),  accept  and then passing it to Slave::new() with a type of VirtiOFSSlave which impl'd VhostUserSlave.   But this was for the master connection on my client.  Hmm.
So do we have types that correspond to the master/slave endpoints on the client side?

Check out the create_slave method in lib.rs's tests.
The gist is that SlaveListener acts as a builder for Slave, returning a valid Slave from accept() upon receiving a Master connection.
This change was made to avoid leaking the Endpoint/Listener structures into client code, since all socket setup and communications should be handled transparently by the vhostuser_rs library itself.

On a unrelated note, there is a small bug in this PR that I stumbled upon recently and haven't had a chance to fix upstream yet. virtio-fs slave requests expect a acknowledgement message, which this PR doesn't implement. It's fixed in my local dev branch of crosvm, and when I get the chance, I'll try to put up a bugfix PR.

Yep, the ack is necessary to make sure you know the mmap is complete before you try and access it.
(Note that slave protocol is still a bit touchy - there's a deadlock I'm trying to fix in the C world where if qemu crashes and shuts down the queues it can be blocked because the slave is sending qemu a command).
OK, so I've now got the apparently working:
    let mut listener = SlaveListener::new(&env::args().nth(1).unwrap(),
                                          Arc::new(Mutex::new(VirtioFSSlave::new()))).
                                          expect("Listening on UNIX socket");
    // We want to wait for the connection
    listener.set_nonblocking(false)?;
    let mut slave = listener.accept().expect("Accepting socket connection").expect("endpoint");
    dbg!("We have an endpoint");

    loop {
        slave.handle_request()?
    }

however, I'm still a bit confused - are we using 'Slave' here to mean two different things - the 'slave' reverse connection back to qemu and also using it to mean the client itself? 'create_dummy_slave' is really creating a client?

Haha yes, the terminology does get confusing fast, doesn't it! I've been going off the terminology established here, which defined the Server/Slave as the vhost-user userland application, and the Client/Master as the VMM.
I'll be honest, I'm not entirely sure what create_dummy_slave is doing (I think it's for testing?). Most of my work has been on the Master-side of the library, so I can't comment too much about what it's like writing Slaves with it.

Yeh, that seems to reflect the unfortunate naming in qemu's docs/interop/vhost-user.txt.
Hmm.
It feels like since you've created a 'SlaveReqHandler' - i.e. something that reads requests on the VMM send received from the vhost-user application,
that we should also have a 'MasterReqHandler' - i.e. something that reads requests from the VMM in the vhost-user application.
I think what I call there 'MasterReqHandler' is currently VhostUserSlave??

Yep, that sounds about right.
I'd +1 renaming VhostUserSlave to MasterReqHandler, since it does make the trait's purpose a bit clearer.

OK, I've posted that as https://github.com/jiangliu/vhostuser_rs/pull/5    see what you think.
Thinking about it a bit more life may get more complex - in the sense that the slave program is an implementer of MasterReqhandler but also does other things; we'll see.


Follow-up with Microsoft for Azure tenancy special subscription deletions

Describe the issue
There are two legacy subscriptions in the BCgov tenancy that cannot be deleted and we will have to address this with Microsoft and coordinate with the ADMS group
Additional context
Subscriptions were produced by Microsoft automation around the time that Office 365 enterprise capabilities were being implemented and are no longer needed
Definition of done

Coordinate with the ADMS group
Troubleshoot Azure ticket submission issues
Submit support tickets to Microsoft when submission issue resolved
Follow-up with ADMS

Issues getting to the bottom of how this could be dealt with and involving support took longer than expected as the problem did not seem to be well understood by the people discussed with, nor by MS Support at first.  Eventually a resolution was found and we confirmed with one of the original owners of the legacy\undeletable subscriptions that there was no longer any need for the two in question.  Support then confirmed their lack of use and empty of resources now so they were removed by Microsoft.  Closing ticket


The decription of Deformable DETR is wrong

Deformable DETR doesn't formulate the queries as anchor points.
Actually, the query formulation of Deformable DETR is the same as the original DETR, i.e. a set of learned embeddings.
Instead, Deformable DETR predicts the reference points/anchor point by the queries.

Thanks for pointing out the issue. We will fix it in the next version.


Null Check operator used on a null value Error

Describe the bug
Null check operator used on a null value error is thrown while onboarding
To Reproduce
Steps to reproduce the behavior:

Install the wavi app
Click on the generate free atsigns
Enter the email and OTP

Expected behavior
The error message should not be displayed in the logs
Screenshots
INFO|2021-09-02 13:00:33.619859|KeyChainUtil|atsignMap: {}
E/flutter (24013): [ERROR:flutter/lib/ui/ui_dart_state.cc(199)] Unhandled Exception: Null check operator used on a null value
E/flutter (24013): #0 _AtsignListScreenState.initState.
package:at_onboarding_flutter/screens/atsign_list_screen.dart:29
E/flutter (24013): #1 _rootRunUnary (dart:async/zone.dart:1362:47)
E/flutter (24013): #2 _CustomZone.runUnary (dart:async/zone.dart:1265:19)
E/flutter (24013):
Smartphone (please complete the following information):

Device: Samsung Galaxy A50
OS:  Android
Browser [e.g. stock browser, safari]
Version [e.g. 59]

Were you using an @application when the bug was found?

@ wavi

Additional context
Add any other context about the problem here.

Tested as part of this PR.
https://github.com/atsign-foundation/at_widgets/pull/182
I don't see the exception in the logs
I/flutter ( 2815): {atsigns: [Caps, comfortabletabletennis, violetred7ready, emotionalbluebell, vicariouspuzzles, airsoftinvolved], newAtsign: 7anteaterugly3}
I/flutter ( 2815): INFO|2021-09-03 11:15:07.489508|KeyChainUtil|atsignMap: {}
I/ViewRootImpl@f982dd4MainActivity: ViewPostIme pointer 0
I/ViewRootImpl@f982dd4MainActivity: ViewPostIme pointer 1
I/ViewRootImpl@f982dd4MainActivity: ViewPostIme pointer 0
I/ViewRootImpl@f982dd4MainActivity: ViewPostIme pointer 1
I/flutter ( 2815): null
I/flutter ( 2815): INFO|2021-09-03 11:15:16.384670|KeyChainUtil|atsignMap: {}
I/flutter ( 2815): outbound finish handler called
I/flutter ( 2815): outbound finish handler called
I/flutter ( 2815): INFO|2021-09-03 11:15:30.892949|AtLookup|from result:data:_f9084139-f12d-43ed-a290-77e3077bbfd2@7anteaterugly3:0a031c30-2496-45c8-97df-3b133d7f7398
I/flutter ( 2815): INFO|2021-09-03 11:15:31.421307|AtLookup|auth success
I/flutter ( 2815): INFO|2021-09-03 11:15:34.059053|AtLookup|auth success
I/flutter ( 2815): INFO|2021-09-03 11:15:34.110060|KeyChainUtil|atsignMap: {}
I/flutter ( 2815): initializing storage
I/flutter ( 2815): INFO|2021-09-03 11:15:35.279109|CommitLogKeyStore|Keystore initialized successfully
I/flutter ( 2815): Hive instance has already been initialized. Please call Hive.init only once if possible.
I/flutter ( 2815): getHiveSecretFromFile no file found
I/flutter ( 2815): outbound finish handler called
I/flutter ( 2815): INFO|2021-09-03 11:15:35.551956|HivePersistenceManager|KeyStore initialized successfully


Upgrade org.sonarsource.scanner.maven:sonar-maven-plugin <IP_ADDRESS>6 -> <IP_ADDRESS>1

This PR contains the following updates:

Package
Update
Change

org.sonarsource.scanner.maven:sonar-maven-plugin (source)
minor
<IP_ADDRESS>6 -> <IP_ADDRESS>1

Release Notes

SonarSource/sonar-scanner-maven
v<IP_ADDRESS>1
Compare Source

[ ] If you want to rebase/retry this PR, check this box

Suggested commit message:
Upgrade sonar-maven-plugin <IP_ADDRESS>6 -> <IP_ADDRESS>1

See https://github.com/SonarSource/sonar-scanner-maven/compare/<IP_ADDRESS>6...<IP_ADDRESS>1

Suggested commit message:
Upgrade sonar-maven-plugin <IP_ADDRESS>6 -> <IP_ADDRESS>1

See https://github.com/SonarSource/sonar-scanner-maven/compare/<IP_ADDRESS>6...<IP_ADDRESS>1


Universal K8S feature reduction and customization mechanism

Will K3S's patch to K8S become a burden for long-term follow-up of the community's mainline version?
Will the patch modified by K3S for K8S be pushed into the K8S main line?
Is there a plan to promote the source-level reduction customization capability of the Linux-like kernel on the K8S mainline?

All great questions.  If k3s becomes sufficiently popular will we start an effort to push the changes upstream.  In theory what we are doing here can be accomplished with golang build tags.  And then k3s will just become a specific set of build tags.
The burden of maintaining K3s patch is not huge. It's a fairly straight forward set of changes and in general at Rancher Labs we maintain lots of versions of k8s.  But ideally we would want this all to go upstream.  Right now I'd rather not bother with a SIG until we have more market validation that this is a good approach.  (So far the feedback has been extremely positive).


Do not add proxy into prometheus pod during install

This issue is related to #478 and #485. As of 0.3.0, the conduit pods with a proxy sidecar undergoes restarts because containers in controller, prometheus and web pods are unable establish connections between each other during proxy startup. The best course of action to handle this failure is for apps within containers to retry on network failure. Retries can be easily implemented in the tap, destination and telemetry services since we have access to the code. However, We can't add retry logic to the kubectl proxy since we can't modify the source code for that application.
One solution is to stop injecting the proxy into the prometheus pod. This may require a change in the InjectYAML in inject.go. We would have to establish that a specific deployment, replicaset, etc has some criteria that notifies the install script that it should not inject the proxy into a deployment resource.

As of 0.3.0, the conduit pods with a proxy sidecar undergoes restarts because containers in controller

Note: 0.3.1, not 0.3.0. 0.3.0 is fine in this respect.
I think it is fine to stop injecting the proxy into the prometheus pod for 0.3.1.
In the future (0.4.0; maybe later is OK) we need to find a solution that lets us inject the proxy into Prometheus.  We should probably contribute such a fix upstream to whoever maintains the Prometheus docker image, so that when somebody tries to inject conduit into their own instances of Prometheus, it works. I guess that should be a separate follow-up issue.

We should probably contribute such a fix upstream to whoever maintains the Prometheus docker image

I agree. We could try to shoot for 0.4.0 but my guess is that it might be later.
As a possible solution, we could use a label in a the install YAML file that indicates whether a PodSpec should contain a proxy sidecar. We could this label to the prometheus section in our install template and have the inject code read the label and ignore injecting the sidecar into prometheus.

We could this label to the prometheus section in our install template and have the inject code read the label and ignore injecting the sidecar into prometheus.

I think that something like that would be a great feature to add to conduit inject but it probably requires design work that will require more than 1 day to sort out. I think we should just make a minimal change to the inject.go code to skip the pod "prometheus" in the conduit-namespace, siimlar to how to change the controller URL when the pod is "controller" in the conduit-namespace.

I don't think it's problematic to continue to inject the prometheus pod. The restart that happens in that pod is from the kubectcl container, not the prometheus container. We're running a kubectl proxy alongside prometheus so that prometheus can securely scrape the kubernetes api. The kubectl proxy process makes a network call on startup, which fails if the conduit proxy process has not yet started, causing the kubectl container to exit. Here's a description from the kubectl describe command of one of these restarts:
  kubectl:
    ...
    State:          Running
      Started:      Tue, 27 Feb 2018 17:12:33 -0800
    Last State:     Terminated
      Reason:       Error
      Exit Code:    1
      Started:      Tue, 27 Feb 2018 17:12:31 -0800
      Finished:     Tue, 27 Feb 2018 17:12:32 -0800
    Ready:          True
    Restart Count:  1

You can see that it happens almost immediately, and as far as I can tell the restart has no bearing the ability of prometheus to successfully collect metrics. Prometheus does the right thing and retries if the scrape target is unavailable. So aside from the unsightly "1 restart" in the output of the kubectl command, I don't think conduit functionality is affected. Maybe the outcome of #485 could help improve this further, but I think it's ok for now.

If I understand correctly, #509 will resolve this! 🎉

Awesome! once the PR get merge I can test on GKE

@klingerf

I don't think it's problematic to continue to inject the prometheus pod. The restart that happens in that pod is from the kubectcl container, not the prometheus container. We're running a kubectl proxy alongside prometheus so that prometheus can securely scrape the kubernetes api. [...] Prometheus does the right thing and retries if the scrape target is unavailable. So aside from the unsightly "1 restart" in the output of the kubectl command, I don't think conduit functionality is affected. Maybe the outcome of #485 could help improve this further, but I think it's ok for now.

i'm closing this based on @klingerf's analysis above.
Also, PR #509 removes the kubectl container completely. it turns out it wasn't even being used anyway! So even the aesthetic problem with the logs should be fixed.


TorusBorder class

Implement class TorusBorder(Border), for wrapping board edges in torus topology.

N-dimensional torus wrapping is implemented.


Finish Trident issues

https://github.com/jacobobryant/trident/issues/8
https://github.com/jacobobryant/trident/issues/7

7 is done but not 8... good enough for now.


Passing variables to the layout

Hi man!
First of all nice work on this framework I love it's simplicity and small footprint.
Right now I'm working on an small utility and I'm using layouts, I notice that there is not an easy way to pass data to that layout (for example the title of the page) cause when your are fetching the layout on the _render method of the Flight class the data is hardcoded using array($key => $content) as data parameter.
By the way I found that at the end the View class does a merge when rendering with the data you have passed and the data assigned directly to the view using Flight::view()->set('var', $value);.
If this is the expected way to pass data to the layout I think will be great to add a small paragraph on the view section of the webpage (on the learn section) just to let the users know how to do it and avoid them spending time searching how to deal with that.
If this is not the expected behavior I think the patch is really easy (added below just in case).
On line 538 of Flight.php replace:
self::view()->render($layout, array($key => $content));
with:
self::view()->render($layout, array_merge((array)$data, array($key => $content)));
Thank you!

I think I'm going to revert back to the old render method, which was to save the content into a template variable, then render the layout later instead of having it mashed up into one method. So you would do this instead.
Flight::render('header', array('message' => 'hello'), 'header_content');
Flight::render('body', array('text' => 'world'), 'body_content');
Flight::render('layout', array('title' => 'My Page'));

Then your layout template would simply be

<?php echo $title; ?>

<?php echo $header_content; ?>

<?php echo $body_content; ?>

And yes I do need to provide better examples in the documentation. Thanks for your comments.

Fixed in commit 8af17f2215


Fix Domain Screen Minor Issues

What does this PR do?
(Provide a description of what this PR does.)
Test Plan
(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work.)
Related PRs and Issues
(If this PR is related to any other PR or resolves any issue or related to any issue link all related PR and issues here.)
Have you read the Contributing Guidelines on issues?
(Write your answer here.)

@TorstenDittmann should we also move to using https protocol for the domains? Currently its http.

@TorstenDittmann should we also move to using https protocol for the domains? Currently its http.

yes, lets do that 👍🏻

@TorstenDittmann should we also move to using https protocol for the domains? Currently its http.

yes, lets do that 👍🏻

Done ✅


⚠ Jenkins Plugins Artifactory has degraded performance

In f3b8f14, Jenkins Plugins Artifactory (https://get.jenkins.io/plugins/artifactory/) experienced degraded performance:

HTTP code: 200
Response time: 1148 ms

Resolved: Jenkins Plugins Artifactory performance has improved in 8d80bb6 after 12 minutes.


[Scheduled] flutter pub upgrade --null-safety

Auto-generated by create-pull-request
See: https://github.com/peter-evans/create-pull-request/blob/master/docs/concepts-guidelines.md#triggering-further-workflow-runs

Codecov Report

Merging #58 (4833401) into main (07b58ed) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##            main     #58   +/-   ##
=====================================
  Coverage   0.00%   0.00%
=====================================
  Files          1       1
  Lines          4       4
=====================================
  Misses         4       4

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

bors merge


Doc generation?

With some changes to checkhelper, we can now generate documentation at a profile level like this:


[Mention The Feature]: to add dark and light toggle

Is your feature request related to a problem? Please describe.
i just want to enhance the code and the website's dark and light toggle mode
Describe the solution you'd like.
No response
Describe alternatives you've considered.
No response
Additional context.
No response
Show us the magic with screenshots

Checklist

[X] I have checked the Existing Issues
[X] I have read the Contributing Guidelines
[X] I want to work on this issue. (optional)

@sv410 sure go ahead, do make sure the toggle be available on all pages of website

Make sure to join the discord server for further communication
Don't forget to star the repository
Complete the task in next 2 days and kindly mention your issue # in your pr like:
Closes #IssueNumber

Note: the level of the issue may change based on the quality of the PR code

@sv410 you have made the pull request in your own repository