[WIP][SPARK-35055][SQL] Fix the requirement in BitSet.union

What changes were proposed in this pull request?
Reversed the requirement in BitSet.union:
require(this.numWords <= other.numWords)
=>
require(this.numWords >= other.numWords)
Why are the changes needed?
Ensure that we don't go out-of-bound in a BitSet's Long array.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Existing tests.

Test build #137326 has started for PR 32159 at commit f4a8266.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41906/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41906/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41906/

Test build #137326 has finished for PR 32159 at commit f4a8266.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137326/

Test build #137360 has started for PR 32159 at commit 88fc731.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41939/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41939/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41939/

Test build #137360 has finished for PR 32159 at commit 88fc731.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137360/

Test build #137369 has started for PR 32159 at commit 2c0e862.

Are we sure this is the right fix? It seems that we loop over this.numWords, so this.numWords <= other.numWords seems right?

Yeah, you're right.
FYI: @cloud-fan

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41947/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41947/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41947/

Test build #137369 has finished for PR 32159 at commit 2c0e862.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
public class VectorizedBLAS extends F2jBLAS
trait AnalysisOnlyCommand extends Command
 implicit class MetadataColumnHelper(attr: Attribute)

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137369/


SPI Mode wrong?

File mcp41010.c
In the SPI initialization, you use
''    devcfg.mode = 2;''
But according to the datasheet of the potentiometer this should be mode
''    devcfg.mode = 0; ''
or
''    devcfg.mode = 3; ''
Any other value might work but is working on the edge.

Thanks for the report.
I checked the datasheet.
datasheet say:
It is possible to operate the devices in SPI modes 0,0 and 1,1.

We will fix it in the near future.

Thank you.
Maybe for your reference.
I used your original code with 5 modules in parallel, and 2 of the 3 were working.
After changing the SPI mode to 0, all modules are working fine.
So it might work with the current code but may not be stable over temperature and design changes.
Thank you for posting this lib!

Changed SPI mode from 2 to 0 and changed to component


2.0.3 Removes Highlighting in Vue SFCs

Problem
After package control upgraded this package, my Vue single file components no longer have syntax highlighting:

Expected Results
Sass syntax highlighting in Vue SFCs where the following is defined:
<style lang="scss">
</style>

Prior to this release, things were working as expected.
Environment

Sublime 3.1.1, Build 3176
SublimeSass v2.0.3
Vue Syntax Highlight v3.3.1

This line needs to match the scope of the SCSS package you use. Braver's is set to source.css.scss.

@braver I was reading https://github.com/wbond/package_control_channel/pull/7220 and if I interpreted it correctly, it seems that your version of this package only recently got pushed to package control as of a few hours ago?
If true, I take it that prior commits to this repository were not rolling out to those who installed via package control.
8fbbb95b63e3932c8c51fd09017cd36d41ec2cb8 introduced the change mentioned by @michaelblyons
Would it make sense to change the scope back to source.scss ? I'm not sure what implications that would have, but I don't see how I can integrate with vue-syntax-highlight otherwise, unless I'm missing something. It doesn't seem possible for me to configure these scopes once the packages are downloaded/installed from package control.
File:
https://github.com/braver/SublimeSass/blob/2d12d9e9aab91f542394c7dfe5ec4959d81e2f0b/Syntaxes/SCSS.sublime-syntax#L7

Okay. So basically this is the new Sass package from the package control.
For Vue.js forks

Temporary workaround: Remove Sass package and install Syntax Highlighting for Sass
Wait for vuejs/vue-syntax-highlight to fix this

@vapurrmaid yes, after some back and forth we decided to replace the old Syntax Highlighting for Sass repository with mine as the source for the Sass package. Before that change some people were already using the new package via manual installation, but it hasn't been rolled out via package control yet. As you saw in the commit you linked, it's now built on the same principles as the LESS package that's already available via package control.

Would it make sense to change the scope back to source.scss

Well yes and no. The same change has been made to the vue syntax to support LESS, so that's the proper way to solve this.
Right now both LESS and SCSS are scoped to present themselves as an extension of the CSS syntax. This way they get to inherit things like keybindings and completions.
That said, at some point I probably want to extend the CSS completions in a smarter way. The fact that normal CSS of course isn't nested, sometimes makes it a bit tricky to not trigger keybindings and completions at the incorrect time. So, it might change back at some point. Who knows. :)

It doesn't seem possible for me to configure these scopes once the packages are downloaded/installed from package control.

Scopes aren't configurable, but packages can be hacked.

Wait for vuejs/vue-syntax-highlight to fix this

Sublime needs a better syntax for Vue, and it needs one that is maintained more actively. But they do tend to respond to PR's, so that might help push this forward. I'll have to see how my priorities lie the coming weeks.

Hey folks!
Maintainer of Vue.js sublime syntax here. Pushed out a new release including @louim's fix, can you check it out (v3.3.2) and let me know if it's fixed now?
Thank you!

 Thanks freaks!

This isn't working for me. I've uninstalled and reinstalled both plugins.

Let me know if there is any more information I can provide to help.


We see production ads in Android emulator instead of test ads

We see production ads in Android emulator instead of test ads
Environment
Plugin Version
Version ^3.0.0 (currently using the actual 3.0.0 version)
OS

Verified on macOS

Platform

This bug occurs only when the Flutter app is running on Android.

Description of the problem
Production ads are shown when using an Android emulator.
Steps to Reproduce

Implement ads
Set up your production ad ids
Run your app in an Android emulator

Expected results: We should see the test ads, since we are running in an emulator.
Actual results: We see our production ads.

Hi @aalex
Are you seeing this issue only on emulator API 33? I see there is a similar issue filed in Developer Forum: https://groups.google.com/g/google-admob-ads-sdk/c/Kk0kDDYVbX0 (the team is still investigating the issue). If so, it could be a general issue so I would suggest you follow it for further updates. It's worth checking this on Android native example as well.


Search bar in the documentation website does not work

If you try to search for content in the search bar of the riverpod documentation, it just does not work like in the pictures below.
Used chrome and safari to test.
Both on https://riverpod.dev and https://docs-v2.riverpod.dev
Also, I kindly ask for a link that describes the refresh and invalidate methods if there is one.
Search bar:

The algolia backends responds with a 403: Invalid Application-ID or API key.

Thanks for the report. Fixed :)


The Node.js OIDC sample app could use a SameSite update

Hi,
This document has examples for ASP.NET, Java, and Python, but not Node.js; the official OIDC sign-in documentation provides examples, however, for Node as well, at https://docs.microsoft.com/en-us/azure/active-directory/develop/quickstart-v2-nodejs-webapp.
That references the sample repo https://github.com/azureadquickstarts/AppModelv2-WebApp-OpenIDConnect-nodejs, which does not yet have any updates to SameSite. I opened an issue https://github.com/AzureADQuickStarts/AppModelv2-WebApp-OpenIDConnect-nodejs/issues/37 to track that.
I'm interested in learning how to update a similar app to the sample to comply with SameSite=None etc., and browser sniffing, so would love to collaborate and learn from others who may have tackled this.
Thanks.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: f1c4f43c-843e-c1da-9e7e-af1eeccb9abd
Version Independent ID: fed9d3c7-d831-2a38-149e-a9b5c69ec62f
Content: How to handle SameSite cookie changes in Chrome browser - Microsoft identity platform
Content Source: articles/active-directory/develop/howto-handle-samesite-cookie-changes-chrome-browser.md
Service: active-directory
Sub-service: develop
GitHub Login: @jmprieur
Microsoft Alias: jmprieur

@jeffwilcox
Thanks for your feedback! We will investigate and update as appropriate.

#assign @hamiltonha @DarylThayil

@DarylThayil : Microsoft.Identity.Web does process samesite.
See https://github.com/AzureAD/microsoft-identity-web/blob/master/src/Microsoft.Identity.Web/CookiePolicyOptionsExtensions.cs#L77

#unassign @hamiltonha

Updating issue assignment to @DarylThayil  per @jmprieur so it's not double-assigned: #reassign:DarylThayil

@sameerag is there Node sample handling SameSite that we can point Jeff to?

@mvrak Reassigning to you, Amit, per @DarylThayil. #reassign:mvrak

We don't have any plans to update this OIDC sample app and will be archiving it.  The sample uses an implicit flow strategy that has issues with Samesite.
For an alternative, we recently published samples for MSAL Node, which covers this scenario and does not rely on the implicit flow.  It should have no issue with Samesite.  https://docs.microsoft.com/en-us/azure/active-directory/develop/quickstart-v2-nodejs-webapp-msal

@jeffwilcox Hi Jeff, apologies for the delay in response here. As @mvrak mentions in https://github.com/MicrosoftDocs/azure-docs/issues/59014#issuecomment-721323963, the new MSAL Node should cover you. I'll close this issue out as there are no updates require for this article, but let us know with an @-mention if you have additional comments on the issue. #please-close


Enable manual trigger of workflow

After specifying an empty inputs: element, I finally see the button for triggering the workflow in the UI. This fixes the remaining problem from #104.

To prevent Travis builds, I should have named the branch prose-action-manual rather than action-manual-prose. Duh.


[example] Add thread and wifi mgn switch to linux app

Problem
WiFi provisioning is missing due to wpa_supplicant dbus is not initialized on linux example apps

Summary of Changes
Add command line argument for linux app to enable host wifi managemtn & thread management.

Fixes #4343

This breaks mac builds.  See https://github.com/project-chip/connectedhomeip/issues/4505

This breaks mac builds.  See https://github.com/project-chip/connectedhomeip/issues/4505


x/build/env/linux-arm64/packet: 8 Packet linux/arm64 machines missing (mid-March 2020)

From https://farmer.golang.org/:

Previously:

#37371 (last occurrence, 25 days ago)
#35708
#35524
#32543
#31112
etc.

Restarted the server via Packet UI to fix it.


Revert "Do not run kube-proxy/cleanup in privileged mode"

How to categorize this PR?

/area networking
/kind bug
What this PR does / why we need it:
This reverts commit fc9de555d6bce14b1d3fdcf3b5a8d6ce0388117a.
After https://github.com/gardener/gardener/pull/6476 I noticed the following error when switching the kube-proxy mode (while testing some other changes):
$ k -n kube-system logs kube-proxy-cpu-worker-v1.20.15-5prt7 cleanup
...
I0822 13:41:05.358412      26 iptables.go:351] running ip6tables-save [-t nat]
E0822 13:41:05.361246      26 proxier.go:439] Failed to execute iptables-save for nat: exit status 1
I0822 13:41:05.361270      26 iptables.go:351] running ip6tables-save [-t filter]
E0822 13:41:05.364014      26 proxier.go:476] Failed to execute iptables-save for filter: exit status 1
...
F0822 13:41:05.722184      26 server.go:495] encountered an error while tearing down rules

I see that in a non-privileged container ip6tables-save -t nat
# ip6tables-save -t nat
ip6tables-save v1.8.5 (legacy): Cannot initialize: Permission denied (you must be root)

while it succeeds in privileged one.
Maybe while testing #6476 I didn't notice the above error because there was nothing to cleanup or the error happens with particular kube-proxy versions or with particular CRI (docker/containerd). Anyways, as currently there are no plans to run kube-proxy in non-provileged mode (due to the many sysctls it does internally), we can leave the cleanup init container in privileged mode.
Release note:

NONE

/test pull-gardener-integration

/approve


Adopt Snippet support in completion items in LSP

VSCode Version: 1.8.x

See https://github.com/Microsoft/vscode/issues/3210#issuecomment-260959818

Added in master https://github.com/Microsoft/vscode-languageserver-node/commit/08d578b42916a368c1d4a7321a384a569bbd560f as well as for 2.6
(https://github.com/Microsoft/vscode-languageserver-node/tree/2.6-next)
Published to npm as 2.6.4-next.1 (client), 2.6.2-next.1 (server), 1.0.5-next.1 (types)

Thanks Martin !

I don't get why the protocol needs the SnippetString which just wraps a single string?
Also leveraging union types in the protocol is problematic for languages that don't support them (like Java).


Some vector tiles are missing data

Bug description
What is happening?
Some vector tiles appear to be missing data. This is not a case of missing tiles, because they contain some elements, but we can see tile edges, as shown in screenshots and links below. Where we have completely blank tiles, I would expect those are tiles not in the cache that the system needs to generate (so would eventually catch up) but where we have some but not all data, with hard edges at tile boundary, I assume something is wrong with tile generation.
What should be happening?
All the data in a tile should either show up because tile exists, or not, because tile is being generated. Tile boundaries should not be showing up.
It is a bit hard to know exactly what should be happening, since we also exclude some data types from zoomed-out views, so we expect zooming in to reveal more data, but not to "complete" partially rendered elements missing in tile-size chunks from previous zoom levels.
Repro Steps
Steps to reproduce the behavior:

Go to https://vtiles.openhistoricalmap.org/#13/51.5352/-0.1649
Progressively zoom in and watch the tiles populate with completed shapes from previous levels.

Screenshots & URL
https://www.openhistoricalmap.org/#map=16/51.5308/-0.1573&layers=OD

https://vtiles.openhistoricalmap.org/#13/51.5352/-0.1649
Animation showing progressive filling in of data as we zoom in: https://recordit.co/IhsKsH4bWB
I suspect we are hitting max tile size limits?

Here's another possible example: https://www.openhistoricalmap.org/#map=16/47.6069/-122.3255&layers=O

Here's another possible example: https://www.openhistoricalmap.org/#map=16/47.6069/-122.3255&layers=O

And here's an example off different degrees of the problem, also from Regents Park in London:
https://vtiles.openhistoricalmap.org/#15.4/51.5283/-0.1547

And here's an example off different degrees of the problem, also from Regents Park in London:
https://vtiles.openhistoricalmap.org/#15.4/51.5283/-0.1547

Good example. Thanks for that! So maybe this is not about tile size, but something about the geometry in some of these tiles that is causing them to lose data. I do not think is is about filters pulling data into the tiles, since a single element appears in some tiles but not other at the same zoom level.
Here's an example:
https://openhistoricalmap.org/way/198180153#map=16/51.5292/-0.1576&layers=OD
If the vector tile filters were excluding data on import, then I would expect that feature t be missing on all tiles.
Same set of tiles as in Jeff's example combined with the overlay of what is actually inside OHM data:

The bottom left and right are the examples that suggest pure tile size is not the problem here, since lower left tile doesn't appear any more complex than lower right

Good example. Thanks for that! So maybe this is not about tile size, but something about the geometry in some of these tiles that is causing them to lose data. I do not think is is about filters pulling data into the tiles, since a single element appears in some tiles but not other at the same zoom level.
Here's an example:
https://openhistoricalmap.org/way/198180153#map=16/51.5292/-0.1576&layers=OD
If the vector tile filters were excluding data on import, then I would expect that feature t be missing on all tiles.
Same set of tiles as in Jeff's example combined with the overlay of what is actually inside OHM data:

The bottom left and right are the examples that suggest pure tile size is not the problem here, since lower left tile doesn't appear any more complex than lower right

Another example I found interesting... pretty much nothing other than natural data afaict...
https://www.openhistoricalmap.org/changeset/13549#map=9/13.2345/109.1588&layers=O
[btw, this changeset is from Minh Nguyễn, an OSM-US board member and power linked data / wikidata user... great to have him involved, but I hate having him see this! ;) ]

Another example I found interesting... pretty much nothing other than natural data afaict...
https://www.openhistoricalmap.org/changeset/13549#map=9/13.2345/109.1588&layers=O
[btw, this changeset is from Minh Nguyễn, an OSM-US board member and power linked data / wikidata user... great to have him involved, but I hate having him see this! ;) ]

Ok... last one, but now I'm seeing this lots of places...
https://www.openhistoricalmap.org/#map=7/38.756/37.855&layers=O

Ok... last one, but now I'm seeing this lots of places...
https://www.openhistoricalmap.org/#map=7/38.756/37.855&layers=O

Thank you for this detailed ticket @danrademacher @jeffreyameyer. There are two major issues that I discovered while debugging this.
1. More date parsing errors
For example, these tiles https://vtiles.openhistoricalmap.org/#13/51.5352/-0.1649 aren't rendering properly because of invalid dates. I can see them in the logs:
2021/01/26 13:06:30 map.go:196: err fetching tile (z: 15, x: 16369, y: 10892) features: ERROR: Not a valid date 1900, 2, 29 (SQLSTATE P0001)
2021/01/26 13:06:30 map.go:196: err fetching tile (z: 15, x: 16370, y: 10892) features: ERROR: Not a valid date 1900, 2, 29 (SQLSTATE P0001)
2021/01/26 13:06:30 map.go:196: err fetching tile (z: 15, x: 16370, y: 10892) features: ERROR: Not a valid date 1900, 2, 29 (SQLSTATE P0001)
2021/01/26 13:06:30 map.go:196: err fetching tile (z: 15, x: 16370, y: 10892) features: ERROR: Not a valid date 1900, 2, 29 (SQLSTATE P0001)
2021/01/26 13:06:30 map.go:196: err fetching tile (z: 15, x: 16370, y: 10891) features: ERROR: Not a valid date 1900, 2, 29 (SQLSTATE P0001)
2021/01/26 13:06:30 map.go:196: err fetching tile (z: 15, x: 16370, y: 10891) features: ERROR: Not a valid date 1900, 2, 29 (SQLSTATE P0001)
2021/01/26 13:06:30 map.go:196: err fetching tile (z: 15, x: 16370, y: 10891) features: ERROR: Not a valid date 1900, 2, 29 (SQLSTATE P0001)
....

To fix this, we need to deploy the date fix @danrademacher and @gregallensworth made based on https://github.com/OpenHistoricalMap/issues/issues/146
2. A geometry rendering regression in the Tegola version we are using
The example here https://www.openhistoricalmap.org/changeset/13549#map=9/13.2345/109.1588&layers=O around Vietnam is because of a Tegola regression. Note that this also exists on staging https://vtiles-staging.openhistoricalmap.org/#8.06/13.2699/108.8681 and also note that this is only on z8. z8 works fine.
This is still a bit experimental but I'm going to upgrade Tegola version on staging and see if that helps.

Thank you for this detailed ticket @danrademacher @jeffreyameyer. There are two major issues that I discovered while debugging this.
1. More date parsing errors
For example, these tiles https://vtiles.openhistoricalmap.org/#13/51.5352/-0.1649 aren't rendering properly because of invalid dates. I can see them in the logs:
2021/01/26 13:06:30 map.go:196: err fetching tile (z: 15, x: 16369, y: 10892) features: ERROR: Not a valid date 1900, 2, 29 (SQLSTATE P0001)
2021/01/26 13:06:30 map.go:196: err fetching tile (z: 15, x: 16370, y: 10892) features: ERROR: Not a valid date 1900, 2, 29 (SQLSTATE P0001)
2021/01/26 13:06:30 map.go:196: err fetching tile (z: 15, x: 16370, y: 10892) features: ERROR: Not a valid date 1900, 2, 29 (SQLSTATE P0001)
2021/01/26 13:06:30 map.go:196: err fetching tile (z: 15, x: 16370, y: 10892) features: ERROR: Not a valid date 1900, 2, 29 (SQLSTATE P0001)
2021/01/26 13:06:30 map.go:196: err fetching tile (z: 15, x: 16370, y: 10891) features: ERROR: Not a valid date 1900, 2, 29 (SQLSTATE P0001)
2021/01/26 13:06:30 map.go:196: err fetching tile (z: 15, x: 16370, y: 10891) features: ERROR: Not a valid date 1900, 2, 29 (SQLSTATE P0001)
2021/01/26 13:06:30 map.go:196: err fetching tile (z: 15, x: 16370, y: 10891) features: ERROR: Not a valid date 1900, 2, 29 (SQLSTATE P0001)
....

To fix this, we need to deploy the date fix @danrademacher and @gregallensworth made based on https://github.com/OpenHistoricalMap/issues/issues/146
2. A geometry rendering regression in the Tegola version we are using
The example here https://www.openhistoricalmap.org/changeset/13549#map=9/13.2345/109.1588&layers=O around Vietnam is because of a Tegola regression. Note that this also exists on staging https://vtiles-staging.openhistoricalmap.org/#8.06/13.2699/108.8681 and also note that this is only on z8. z8 works fine.
This is still a bit experimental but I'm going to upgrade Tegola version on staging and see if that helps.

Quick update here! Part 1 is now in production. Still needs to clear caches and I'll do this by regions. Starting in the US and then going East.
Part 2 has fixed some geometries but the mysterious one is still Vietnam https://www.openhistoricalmap.org/changeset/13549#map=9/13.2345/109.1588&layers=O. I will now enable Tegola query debugging on staging and see what the SQL looks like and inspect the geometry.

woo-hoo!! Double-checking problem areas now!

how long should the cache clearing take?

any update on this? all my demo sites are still having problems...
https://www.openhistoricalmap.org/#map=13/43.9376/12.4675&layers=O&date=1850&daterange=300,2021

and Regent's Park, from above...
https://www.openhistoricalmap.org/#map=16/51.5301/-0.1554&layers=O&date=1850&daterange=1800,2021

Caches have been cleared in the US, EU and some parts of Africa. I'll be moving to Asia next.
@jeffreyameyer Regent's Part looks good to me, but let me know if it's still not right to you? Perhaps your browser cache?

City of San Marino should also look good now.
All issues reported on this ticket except for the Vietnam one are resolved. But I'm going to clear caches everywhere anyway so that we don't have any dud tiles.

W00t!!! This is awesome. Very much loving this. Nice work!!

Still some weirdness at zoom >=18... is that just a delay in finishing the cache stomping? (repro'd on multiple browsers)
https://www.openhistoricalmap.org/#map=18/51.53553/-0.15505&layers=O&date=1850&daterange=1800,2021

That's right. It's a lot of tiles 😄

This is now more or less resolved I think. I've made some adjustments how admin layers are cut into tiles which reduces the overall tile size. The 6/34/21 tile is now loading and things should be back to being ok.
Next: I'll spend some more time digging into the tile 8/205/118 tile in Vietnam.

@geohacker   any news about the Vietnam? , anyway, this  issue should be gone once we deploy the admin changes, https://github.com/OpenHistoricalMap/issues/issues/212 in production.

This looks good now

closing this ticket!

This is SOOO GOOD!!!
On Fri, May 21, 2021 at 12:06 PM Ruben Lopez M. @.***>
wrote:

This looks good now
[image: image]
https://user-images.githubusercontent.com/1152236/119186440-bbb67380-ba3d-11eb-9c58-fcbd421f8e4f.png
closing this ticket!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/OpenHistoricalMap/issues/issues/186#issuecomment-846184987,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AALM4EWMHR53VOGQQC4QOZLTO2VM5ANCNFSM4WSELMRA
.

--
Jeff Meyer
206-676-2347
osm: Open Historical Map (OHM)
http://wiki.openstreetmap.org/wiki/Open_Historical_Map / my OSM user page
http://www.openstreetmap.org/user/jeffmeyer
t: @OpenHistMap


aggregate-prometheus-0 is OOMKilled on almost all Seeds after<EMAIL_ADDRESS>rollout

How to categorize this issue?
/area auto-scaling
/kind bug
/priority 3
What happened:
We observe aggregate-prometheus-0 that is OOMKilled on multiple Seed after<EMAIL_ADDRESS>rollout
$ k -n garden get po aggregate-prometheus-0
NAME                     READY   STATUS             RESTARTS   AGE
aggregate-prometheus-0   1/2     CrashLoopBackOff   30         151m

$ k -n garden describe po aggregate-prometheus-0

    Args:
      --config.file=/etc/prometheus/config/prometheus.yaml
      --storage.tsdb.path=/var/prometheus/data
      --storage.tsdb.no-lockfile
      --storage.tsdb.retention.time=2w
      --web.enable-admin-api
      --web.listen-address=<IP_ADDRESS>:9090
      --web.enable-lifecycle
    State:          Waiting
      Reason:       CrashLoopBackOff
    Last State:     Terminated
      Reason:       OOMKilled
      Exit Code:    137
      Started:      Wed, 12 May 2021 14:40:00 +0300
      Finished:     Wed, 12 May 2021 14:40:31 +0300
    Ready:          False
    Restart Count:  30
    Limits:
      cpu:     500m
      memory:  2000Mi
    Requests:
      cpu:      30m
      memory:   500Mi

What you expected to happen:
No OOMKilled events.
How to reproduce it (as minimally and precisely as possible):
Anything else we need to know?:
Environment:

Gardener version<EMAIL_ADDRESS>Kubernetes version (use kubectl version):
Cloud provider or hardware configuration:
Others:

/assign @amshuman-kr @wyb1

Even though HVPA is applying the VPA recommendations to the aggregate-prometheus StatefulSet, the long-standing issue of StatefulSet controller not doing the rolling updates if pods are unhealth/crashing is preventing the pods to get the recommendation.
In one seed at least, I can see that the memory usage jumped from ~1Gi to ~3.2Gi. I suspect the same to be true in the other seeds too.

The current configuration of limitsRequestsGapScaleParams is not sufficient to handle such spikes in usage. I suggest to modify these values to something like below at least.
    limitsRequestsGapScaleParams:
      cpu:
        percentage: 60
        value: 400m
      memory:
        percentage: 80
        value: 2Gi

Even though HVPA is applying the VPA recommendations to the aggregate-prometheus StatefulSet, the long-standing issue of StatefulSet controller not doing the rolling updates if pods are unhealth/crashing is preventing the pods to get the recommendation.

Side note: If there will ever be a v2 of HVPA, I really recommend to not touch the higher-level resources but only the Pods directly (like VPA). Apart from this concrete issue (StatefulSet not updating crash-looping pods), we have a lot of avoidable code complexities in g/g that would not be necessary. cc @timebertt

Side note: If there will ever be a v2 of HVPA, I really recommend to not touch the higher-level resources but only the Pods directly (like VPA)

FWIW, I disagree. This would be a a work-around on top of a work-around. Besides, HVPA is not the only component that has this problem. Anyone deploying/managing statefulsets via controllers technically has this problem which potentially requires a manual intervention to recover.
May I suggest a controller that watches statefulsets (suitably annotated) and their pods. If it sees the pods crashing (or crashlooping to be sure) and the podspec different from the pod template, then shoots the pod.
The reluctance in upstream Kubernetes to do this automatically is assuming the work case where stateful workload always requires manual intervention on crashing. But all of the statefulsets that we use in gardener can and do handle restarts gracefully (and we can mark this fact in an annotation on the statefulset).
This would solve not just this issue here but also other cases it might manifest generally.

we have a lot of avoidable code complexities in g/g that would not be necessary.

The fact that VPA enables to avoid the complexity in gardener does not mean it should ideally be avoided. In principle, who ever deploys a resource should ideally be responsible for it mutating between reconciliation, especially if another component is also deployed which is expected to mutate it.
AFAIK, even with HPA, the replicas will get overwritten if the reconciler is not careful.

VPA using webhook to mutate pods is really just a work around and messes with rolling update strategy among other things. It breaks layers.
What is really required is a Scale subresource equivalent to scale resources. A Resources subresource, if you will. But even that won't eliminate the need for g/g to be careful not to overwrite. Which is as it should be, IMHO.

To complete my thoughts on the topic of mutating resources (at the risk of dragging the discussion on a side-note), a more viable way to dynamically mutate resources while also reducing the complexity in gardener of having to take care not to overwrite would be to use a separate CRD (for resources) coupled with a mutating webhook to mutate higher order resources instead of mutating the pods underneath. Something like what is done by PodPreset and kupid.
This would let gardener not worry about overwriting anything while also not breaking layers and the problems thereof.
Nothing like this exists yet, of course.


fix: update SCC profile_id to fe96bd4d-9b37-40f2-b39f-a62760e326a3

/run pipeline

:tada: This PR is included in version 2.1.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Hyperapp 0.16.0 API Changes

Immutable state
No more requestAnimationFrame
Curried data argument to actions
No more init property

Closing in favor of #3.


[important] Edit PANDA tag

I agree to not ping anybody on Discord/Twitter/email about this pull request. Instead I will inquire by posting a new comment in the pull request if needed.

PRs are reviewed in bulk and and can take up to two weeks to be merged.
This repository is managed using an auto merge action. Please ensure your PR has no deleted lines, and it will be merged.
Please provide the following information for your token.
Please include change to the src/tokens/solana.tokenlist.json file in the PR.
DON'T modify any other token on the list.
At minimum each entry should have

Token Address:
Token Name:
Token Symbol:
Logo: (logo should be uploaded under assets/mainnet//*.<png/svg>)
Link to the official homepage of token:
Coingecko ID if available (https://www.coingecko.com/api/documentations/v3#/coins/get_coins__id_):

I am the owner of PANDA coin, I added PANDA to token-list repo (#3114). I added NFT tag accidentally so PANDA token is only shown in Collectibles section while PANDA is not a Collectible. It has 10,000,000,000 token in total (https://explorer.solana.com/address/Aw8qLRHGhMcKq7rxs5XBNCd9oe3BvoAhpNMVz7AdGmty)
Please help me to merge this PR. Many thanks

can confirm decimals=9 and author was original committer in https://github.com/solana-labs/token-list/commit/c4bbbec68b05b06d6892bf8a561ce3046b024a02


Use a randomly generated hash/string for id's

We are using an integer which increments after each paste as the id for the paste. This is not the right way to generate the id.
We need it to be a randomly generated id, something like b7ckgse8c which is entirely composed a-z,A-Z and 0-9. We can further discuss the specifics of the random id if you are interested.

Hello, i would like to work on this.


do not perform formatting if the previous node ends after the current node

Do not perform formatting if the previous node ends after the current node starts

This PR  fix issue  #1571


QWen's generator con't stop if I use a eos_token_id != default id (151643)

I add a eos_token to the tokenizer's config files, it wokered

which id you use?  151645?


Can't build project

coremlc: Error: unable to read document: /Users/alex/Downloads/CarPoseDemo-master/CarPoseDemo/CarPoseModel.mlmodel
detail: validator error: unable to deserialize object
Command CoreMLModelCodegen failed with a nonzero exit code

Xcode 10.2.1, iOS 12.2

same.

The reason is because github screwed up the asset, you can see this when you try to open the ml file in notepad. To fix this you have to download the raw ml file from it's location in the repo and I'm not sure if it also ruined the opencv framework but you can download that too here: https://opencv.org/releases/
There was one issue with this line:
p1 = (p1 / outputSize) * ((double)imageWidth);
so I just replaced it with:
p1 = Point3d(p1.x / outputSize * (double)imageWidth, p1.y / outputSize * (double)imageWidth, p1.z / outputSize * (double)imageWidth);


Will rtree recognize coordinate/dimension changes of inserted rects?

If I have a rtree where I insert 50 rectangles and change the coordinates/dimensions of some rectangles afterwards, will rtree recognize this and adapt the internal data structure to work correctly? Or do I have to somehow let the tree know, that some rectangles changed?

I think the safest way is to remove and re-insert nodes even the code looks like it does a "check and run" before every search, which I understand as bringing the tree into a consistent state.

I think the safest way is to remove and re-insert nodes even the code looks like it does a "check and run" before every search, which I understand as bringing the tree into a consistent state.


adding the old categories for parameters

This PR restores the old categories and adds a script that is used for some overview plots.
@MuffinLinwist Could you double-check whether the new categories are correct?
@LinguList Is there a better place for the plots than /raw/scripts? We could create a new folder in the main directory instead.

@Tarotis already checked. Everything is in order.

@tarotis, it seems like using cldfviz would also be useful for this map. I do not know which parameters you want to plot there, but cldfviz may be useful to learn for you guys anyway. Check here: https://github.com/cldf/cldfviz
Examples are also in https://github.com/lexibank/lexibank-analysed/
There, check for the folder "plots".

I did use a fresh venv, but I made another mistake: I follwed an old workflow that installed packages using pip install -e ./. However, since the requirements have been moved to the cldf-directory, pyglottolog etc did not get installed. Then, I followed the prompt that I had to install pyglottolog/concepticon/clts and did so manually, resulting in the mismatches in the package versions. Now I used pip install -r cldf/requirements.txt in order to not change the requirements. The file still appears as if it were changed though, and I am not sure why.

If all works on your side, this is fine. Just wanted to check, as these
cases jumped into my eye.

@MuffinLinwist Could you double-check if my changes are ok, so we can merge this PR?

@Tarotis, it seems that everything is perfect so I'm merging this PR.


Suggestions for Make a Person Bonfire

Make tests more friendly. Until you write the six functions you don't even get to see any tests. All you see is something like:
bob.setFullName is not a function. Program Execution Failure. No user tests were run.
Rewrite the spec to be more exact. For example, you don't know the arity of setFullName. Is it one parameter or two? Turns out it's one. I think little things like that will just slow people down.

I'm not against specifying the arity of the functions but the tests shouldn't change. The error enforces the instructions by stating which function a user forgot to implement.


Bug: Logging in after logging breaks program

Steps to recreate:

Log into OstrichDB
Sign out of OstrichDB (Without exiting the program completely)
Log in again

At this point even after successfully entering their username and password AND being told via the program "User has been signed in". the user is unable to preform any OstrichDB actions as they are continuously prompted to enter their password again and again.
See screenshots below
This shows my successful initial log in

At this point I have logged out and am logging back in but cannot do anything beside renter password

For some odd reason when trying to recreate the bug nothing seems to be wrong now. I was able to recreate several times earlier proven by the above screenshot but now without changing its working as intended....

Would be an easy fix if Odin didnt care so much about cyclical importation. Might need to rebuild engine.odin and security/auth.odin

Had to completely rework project structure to fix this............


Configure and build as pip-installable package

Done, and released to PyPI.
Check it out: https://pypi.org/project/django-wikiwikiweb/


New mutator: Error mutator

We could add error mutator, so each Error / TypeError etc will be changed to return or empty Error

Empty error is already tested with the StringLiteral mutator. Do we really need an additional return there?
I would feel more for a "throw statement mutator". So throw is removed from code. @stryker-mutator/contributors do you agree?

I think this is fine as it is right now.


External wifi antenna?

The ESP32 freezes up after about 7 hours (or so...) I'm thinking it is because the wifi connection is not strong enough.  Has anyone put an external antenna on their ESP32?  If so, any recommendations, gotchas?
Thank you.

What specific software are you running?  Also what is the rssi value?
There is an esp32 dev module with an external antenna connection.

Speaking of RSSI, it would be awesome to add that as one of the values available via MQTT, so it can be graphed/monitored over time.

@BitKnitting I meant to post this version of the DevKitC- https://www.mouser.com/ProductDetail/Espressif-Systems/ESP32-DevKitC-32U?qs=sGAEpiMZZMuJ3l9lTgMBp1ZUJQFPkBG2sDWyUw9oyIyrWi1BCP7QAQ%3D%3D


Validation: fix multiple errors

VALIDATION
Category

[x] Content fix
[ ] New article

Related issues

no issue number - part of the Validation cleanup efforts.

What's in this Pull Request?
This PR fixes 29 issues in 12 files.

Docs Build status updates of commit 04b685f:
:warning: Validation status: warnings

File
Status
Preview URL
Details

docs/community/social-media.md
:warning:Warning
View
Details

docs/apis/migrate-webparts-with-migrationapi.md
:white_check_mark:Succeeded
View

docs/business-apps/power-automate/guidance/manage-list-item-file-permissions.md
:white_check_mark:Succeeded
View

docs/business-apps/power-automate/guidance/working-with-send-sp-http-request.md
:white_check_mark:Succeeded
View

docs/declarative-customization/site-design-pnp-provisioning.md
:white_check_mark:Succeeded
View

docs/declarative-customization/site-theming/sharepoint-site-theming-csom.md
:white_check_mark:Succeeded
View

docs/community/social-media.md

Line 2, Column 1: [Warning: ms-prod-and-service - See documentation] Only one of the following attributes can exist: 'ms.prod', 'ms.service'. Use ms.prod for on-premise products, or ms.service for cloud services.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 6377f3e:
:warning: Validation status: warnings

File
Status
Preview URL
Details

docs/community/social-media.md
:warning:Warning
View
Details

docs/general-development/accessing-a-schema.md
:warning:Warning
View
Details

docs/general-development/accessing-the-soap-api.md
:warning:Warning
View
Details

docs/apis/migrate-webparts-with-migrationapi.md
:white_check_mark:Succeeded
View

docs/business-apps/power-automate/guidance/manage-list-item-file-permissions.md
:white_check_mark:Succeeded
View

docs/business-apps/power-automate/guidance/working-with-send-sp-http-request.md
:white_check_mark:Succeeded
View

docs/declarative-customization/site-design-pnp-provisioning.md
:white_check_mark:Succeeded
View

docs/declarative-customization/site-theming/sharepoint-site-theming-csom.md
:white_check_mark:Succeeded
View

docs/design/ui-text-for-web-parts.md
:white_check_mark:Succeeded
View

docs/design/web-part-commanding.md
:white_check_mark:Succeeded
View

docs/features/hub-site/REST-sphubsite-type.md
:white_check_mark:Succeeded
View

docs/features/hub-site/REST-sphubsitedata-type.md
:white_check_mark:Succeeded
View

docs/community/social-media.md

Line 2, Column 1: [Warning: ms-prod-and-service - See documentation] Only one of the following attributes can exist: 'ms.prod', 'ms.service'. Use ms.prod for on-premise products, or ms.service for cloud services.

docs/general-development/accessing-a-schema.md

Line 2, Column 1: [Warning: ms-prod-and-service - See documentation] Only one of the following attributes can exist: 'ms.prod', 'ms.service'. Use ms.prod for on-premise products, or ms.service for cloud services.

docs/general-development/accessing-the-soap-api.md

Line 2, Column 1: [Warning: ms-prod-and-service - See documentation] Only one of the following attributes can exist: 'ms.prod', 'ms.service'. Use ms.prod for on-premise products, or ms.service for cloud services.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Global effort to fix build validation errors
@VesaJuvonen
The Content & Learning team is fixing build validation errors on docs.microsoft.com for the rest of H2. This will eliminate potential accessibility, security, and usability issues. This PR includes only build validation fixes and does not change other content. Please review within five business days and merge or comment in the PR with any changes you’d like to see. Thank you!

When updating docs, please update the ms.date with the current date of the change to correctly reflect the last time this doc was updated.

@andrewconnell ms.date attributes updated.


upgrade to spring-data-redis 1.5.0

and clean up the RedisCache class in Sagan, since this class is now public in spring-data-redis

Also this: https://jira.spring.io/browse/DATAREDIS-369

Fixed by #487


ops: Set up archive Cobalt node for consensus and Emerald

This is part of https://github.com/oasisprotocol/oasis-indexer/issues/186
A public grpc endpoint was added to existing archive nodes at grpc.cobalt.archive.emerald.oasiscloud.io:443 . This is probably sufficient (and the quickest solution, since all the code already existed for grpc.oasiscloud.io). If you need one of the restricted methods, add a comment and I'll remove the method whitelist and add an IP whitelist.
As the same nodes also serve web3.cobalt.archive.emerald.oasiscloud.io excessive load can kill both. If this becomes a problem, we can split them.
See also https://github.com/oasislabs/private-ops/pull/2633
Old discussion:
@mitjat wrote:

In case it helps, here's what happens when I query the two grpc nodes with
./go/oasis-node/oasis-node control status -a $HOSTNAME

oasis-core version | grpc.oasis.dev:443 | grpc.cobalt.archive.emerald.oasiscloud.io:443
v21.1.x  |  conn closed  |  conn closed
v21.2.x  |  conn closed  |  conn closed
v21.3.x  |  connection closed before server preface received  |  connection closed before server preface received
v22.0.x  |  build failed            |  build failed
v22.1.x  |  build failed            |  build failed
v22.2.x  |  OK                      |  OK (but cbor mismatch)
(I built oasis-node at every version)
I guess it's not very informative because Matt found meanwhile that 21.1x has no chance of talking to a TLS endpoint anyway.
I'll stop making noise for now, I'm off for today. Thank you for digging!

Gregor:

@mitjat  If you are still having issues, try the various TLS options supported by https://github.com/oasisprotocol/tools/pull/21. Your error reminds me of TLS errors encountered during deployment of operators-health.

@mitjat:

Resolved! Matt shared his sample client code with me, and that helped me isolate my problem. It was trivial -- I was hardcoding an incorrect name of the grpc method.
Ironically, I did think all along that there was a possibility that I'm making a mistake there, so I cross-checked with the oasis-node cli ... but that errored out too, so I incorrectly started suspecting the server/connection more. As Matt found out, that error was for a different reason: The old oasis-node hardcodes non-TLS connections.
With both TLS and the correct grpc method name (or using the right convenience wrappers, as Matt's sample code did, but I couldn't use in oasis-indexer for versioning reasons), the connection works now.
Thank you all for the help!

@tjanez:

Matthew Geskey, we updated the scope (see title). Is this one done?

Reuven:

[@Mitja Trampus](javascript: void;) just triple checking. As far as you're concerned the archive for cobalt is working just fine?

@mitjat:

Thank you, it was working fine.
Unfortunately I only now got to a point where I tried using a method that is not supported:
"err":"rpc error: code = Unimplemented desc = Only some methods are allowed on this proxy.","level":"error","method":"/oasis-core.Registry/GetEvents"

From my preliminary experiments (I disabled this method and tried using others that I know I'll need), this is the only "problematic" method. Is it feasible to whitelist it in the config? Being an archive node, I imagine there's not a lot of load on it, and even if it were to go under because of unexpected traffic, production systems likely wouldn't be affected?

Reuven wrote:

Matthew Geskey can you take a look at this one?

Copied to https://github.com/oasisprotocol/internal-ops/issues/508, where it belongs


Githubdam h65 updates test iOS VoiceOver

Hi Marc, Please review the branch if you find any incorrect please advise.

Merged - OK to delete this branch.


Added project Compound Interest Calculator

Related Issue

I've added the Compound Interest Calculator project.

Closes: #1670
Describe the changes you've made
I've added the HTML, CSS, and javascript for the Compound Interest Calculator project.
Describe if there is any unusual behaviour of your code(Write NA if there isn't)
NA
Checklist:

[x] My code follows the style guidelines of this project.
[x] I have performed a self-review of my own code.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] I have made corresponding changes to the documentation.
[x] New and existing unit tests pass locally with my changes.

Screenshots
Put any screenshot(s) of the project here.

@Vishal-raj-1 please add the gssoc21 label to it. I did not get the score for this pr.


Fix runtime error due to missing file.

I believe this fixes a runtime error from npm start for latest master.

Peter and I have been working on this with a DevApp.js file which is a copy of App.js as we write the challenges locally but I git ignored this file so we can avoid have merge conflicts.


Wireframe UI

We need to wireframe our UI. Not entirely sure what this thing is supposed to look like.
Maybe look at using Material Design specs? Maybe see this

I've wireframed the results view for desktop. More to follow as needed, should be viable to move on for now. Closed


OZ sandboxed applications fail if /media/user doesn't exist

I'm not sure OZ should start messing with random system directories on the host. I wouldn't expect OZ to create a $HOME if it were missing. I can make it not fail, but that sandbox will be unable to mount files from external mounts which, while maybe less annoying, is a failure in itself.

This has been fixed in the installer itself, closing.


Missing files in 1.0.0

Looks like the *.js-files aren't included in the npm package. I guess adding lib to files in package.json should be enough.
Sorry for not catching it when reviewing!

v1.0.1 is up


Fix cluster.yaml due to providerConfig type change

What this PR does / why we need it: After providerConfig was changed from string to RawExtension, machines.yaml was updated but not the cluster.yaml. As a result, gcp-deployer is broken currently.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
Release note:

@kubernetes/kube-deploy-reviewers

/assign @jessicaochen


implement Pipe

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 92 (0.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-15.5%) to 62.039%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

pipe.go
0
92
0.0%

Totals

Change from base Build<PHONE_NUMBER>:
-15.5%

Covered Lines:
286

Relevant Lines:
461

💛  - Coveralls


[ml] Bugfix: Fix misconfigured timeout parameter for job.stream

Description
This PR fixes an issue where download_text_from_url, called as part of ml_client.jobs.stream, used the wrong keyword parameter to specify the read timeout for the GET request
Further details:
When sending http requests with azure.core, there are several timeout related parameters:

timeout is handled by RetryPolicy and is a time limit for all retry attempts
read_timeout and connection_timeout apply to the http transport, and control the read and connection timeouts for the http requests

download_text_from_url erroneously used timeout instead of read_timeout to specify the read timeout
All SDK Contribution checklist:

[x] The pull request does not introduce [breaking changes]
[ ] CHANGELOG is updated for new features, bug fixes or other significant changes.
[x] I have read the contribution guidelines.

General Guidelines and Best Practices

[x] Title of the pull request is clear and informative.
[x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[ ] Pull request includes test coverage for the included changes.

API change check
API changes are not detected in this pull request.


[Snyk] Upgrade @opentelemetry/sdk-metrics from 1.23.0 to 1.25.1

Snyk has created this PR to upgrade @opentelemetry/sdk-metrics from 1.23.0 to 1.25.1.
:information_source: Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.

The recommended version is 4 versions ahead of your current version.

The recommended version was released on a month ago.

Release notes

Package name: @opentelemetry/sdk-metrics

1.25.1 - 2024-06-201.25.1
📚 (Refine Doc)

refactor(examples): added usage of @ opentelemetry/semantic-conventions and @ opentelemetry/resources to the examples in examples/opentelemetry-web for maintaining consistency across all examples. #4764 @ Zen-cronic

🏠 (Internal)

refactor(context-zone-peer-dep): use explicit exports #4785 @ pichlermarc
refactor(context-async-hooks): use explicit exports #4785 @ pichlermarc

1.25.0 - 2024-06-051.25.0
🚀 (Enhancement)

feat: support node 22 #4666 @ dyladan
feat(context-zone*): support zone.js 0.12.x #4376 @ maldago
refactor(core): Use tree-shakeable string constants for semconv #4739 @ JohannesHuster
refactor(shim-opentracing): Use tree-shakeable string constants for semconv #4746 @ JohannesHuster
refactor(sdk-trace-web): Use tree-shakeable string constants for semconv #4747 @ JohannesHuster
refactor(sdk-trace-node): Use tree-shakeable string constants for semconv #4748 @ JohannesHuster
refactor(sdk-trace-base): Use tree-shakeable string constants for semconv #4749 @ JohannesHuster
refactor(resources): update deprecated semconv to use exported strings #4755 @ JamieDanielson
refactor(exporters): update deprecated semconv to use exported strings #4756 @ JamieDanielson

📚 (Refine Doc)

refactor(examples): use new exported string constants for semconv in examples/esm-http-ts #4758 @ Zen-cronic
refactor(examples): use new exported string constants for semconv in examples/basic-tracer-node #4759 @ Zen-cronic
refactor(examples): use new exported string constants for semconv in examples/http #4750 @ Zen-cronic
refactor(examples): use new exported string constants for semconv in examples/grpc-js #4760 @ Zen-cronic
refactor(examples): use new exported string constants for semconv in examples/otlp-exporter-node #4762 @ Zen-cronic
refactor(examples): use new exported string constants for semconv in examples/opentracing-shim #4761 @ Zen-cronic

1.24.1 - 2024-05-071.24.1
🐛 (Bug Fix)

fix(core): align inconsistent behavior of getEnv() and getEnvWithoutDefaults() when a process polyfill is used #4648 @ pichlermarc

getEnvWithoutDefaults() would use process.env if it was defined when running in a browser, while getEnv() would always use _globalThis. Now both use _globalThis when running in a browser.

fix(resources): prevent circular import (resource -> detector -> resource -> ...) #4653 @ pichlermarc

fixes a circular import warning which would appear in rollup when bundling @ opentelemetry/resources

fix(exporter-metrics-otlp-grpc): add explicit otlp-exporter-base dependency to exporter-metrics-otlp-grpc #4678 @ AkselAllas

1.24.0 - 2024-04-241.24.0
🚀 (Enhancement)

feat(sdk-trace-base): log resource attributes in ConsoleSpanExporter #4605 @ pichlermarc
feat(propagator-aws-xray): moved AWS Xray propagator from contrib 4603 @ martinkuba
feat(resources): new experimental detector ServiceInstanceIdDetectorSync that sets the value for service.instance.id as random UUID. #4608 @ maryliag

🐛 (Bug Fix)

fix(sdk-trace-web): fix invalid timings in span events #4486 @ Abinet18
fix(resources): ensure BrowserDetector does not think Node.js v21 is a browser #4561 @ trentm

1.23.0 - 2024-04-031.23.0
🚀 (Enhancement)

perf(sdk-trace-base): do not allocate arrays if resource has no pending async attributes #4576 @ Samuron
feat(sdk-metrics): added experimental synchronous gauge to SDK #4565 @ clintonb

this change will become user-facing in an upcoming release

🐛 (Bug Fix)

fix(sdk-metrics): increase the depth of the output to the console such that objects in the metric are printed fully to the console #4522 @ JacksonWeber

    from @opentelemetry/sdk-metrics GitHub release notes

[!IMPORTANT]

Check the changes in this PR to ensure they won't cause issues with your project.
This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.
For more information:

🧐 View latest project report
📜 Customise PR templates
🛠 Adjust upgrade PR settings
🔕 Ignore this dependency or unsubscribe from future upgrade PRs

Closing. This update was rolled into #676.


Repeated connection causes the program to crash

It looks like this.

onDisconnected()
onConnected()
onConnected()
onDisconnected()
E/AndroidRuntime: FATAL EXCEPTION: hawtdispatch-DEFAULT-2
Process: com.xxx.xxx, PID: 22875
java.lang.NullPointerException: Attempt to invoke interface method 'boolean org.fusesource.hawtdispatch.transport.Transport.offer(java.lang.Object)' on a null object reference
at org.fusesource.mqtt.client.CallbackConnection$7.run(CallbackConnection.java:449)
at org.fusesource.hawtdispatch.transport.HeartBeatMonitor$3.run(HeartBeatMonitor.java:83)
at org.fusesource.hawtdispatch.transport.HeartBeatMonitor$1.run(HeartBeatMonitor.java:62)
at org.fusesource.hawtdispatch.internal.SerialDispatchQueue.run(SerialDispatchQueue.java:100)
at org.fusesource.hawtdispatch.internal.pool.SimpleThread.run(SimpleThread.java:77)

这个bug你解决了吗

how do you deal with it

I don't know.
I don't do it now.


Logan Branch

Logan Branch first pull request

@luh429 Uh oh! I am not accepting this pull request because it was done backwards: That is, you want to merge commits from the main branch into your loganBranch. What you want to be doing is the other way around: When you do the pull request, you want to set main as your base branch and you compare your loganBranch with it.  That way you're requesting that the commits from loganBranch be merged into the main branch (with main as the base).  Can you do this again? I'm going to close this PR without merging it.


CIT Issue

whenever I put a CIT(custom item texture) pack in, the game says 'Failed to load texture" Can someone help?

You'll need to provide logs when requesting assistance with a crash or an error.
> Windows
> MacOS
Please get the latest log. (or a crash report if relevant)

latest.log

Says
[14:48:52] [Worker-Main-5/INFO]: [citresewn] No cit packs found.

Doesn't show you trying to use any CIT packs packs anywhere else.
Can you launch the game, try to add the pack and close it without going in a world or doing anything else?

No, because as I mentioned when I put in the pack it immediately takes out all the resource packs.

latest.log
I sent the logs again, I hope it works but I doubt it

Thanks, I got a fix for it :)


Internal routing bug: doesn't work with middleware

Any internal request in conjunction with a route that contains middleware, like this:
$api->version('v1', ['middleware' => 'test'], function ($api) {

});

Results in a:
[ReflectionException]
  Class test does not exist

Despite it being define properly inside Kernel.php:
 protected $routeMiddleware = [
        'test' => \App\Http\Middleware\Test::class,
        'auth' => \App\Http\Middleware\Authenticate::class,
        'auth.basic' => \Illuminate\Auth\Middleware\AuthenticateWithBasicAuth::class,
        'guest' => \App\Http\Middleware\RedirectIfAuthenticated::class,
        'throttle' => \Illuminate\Routing\Middleware\ThrottleRequests::class,
    ];

I've created a test case to illustrate the bug here https://github.com/assembledadam/laravel
Just run php artisan testcase in the root folder, and to view the middleware working visit localhost/index.php/test/blahblah
Stack trace (from my application, not the test case!):
n Error Occured:
Class oauth does not exist
File: /usr/www/app/vendor/laravel/framework/src/Illuminate/Container/Container.php
Line: 738
#0 /usr/www/app/vendor/laravel/framework/src/Illuminate/Container/Container.php(738): ReflectionClass->__construct('oauth')
#1 /usr/www/app/vendor/laravel/framework/src/Illuminate/Container/Container.php(633): Illuminate\Container\Container->build('oauth', Array)
#2 /usr/www/app/vendor/laravel/framework/src/Illuminate/Foundation/Application.php(697): Illuminate\Container\Container->make('oauth', Array)
#3 /usr/www/app/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(123): Illuminate\Foundation\Application->make('oauth')
#4 [internal function]: Illuminate\Pipeline\Pipeline->Illuminate\Pipeline\{closure}(Object(Dingo\Api\Http\InternalRequest))
#5 /usr/www/app/vendor/laravel/framework/src/Illuminate/Routing/Pipeline.php(32): call_user_func(Object(Closure), Object(Dingo\Api\Http\InternalRequest))
#6 /usr/www/app/vendor/dingo/api/src/Http/Middleware/PrepareController.php(45): Illuminate\Routing\Pipeline->Illuminate\Routing\{closure}(Object(Dingo\Api\Http\InternalRequest))
#7 [internal function]: Dingo\Api\Http\Middleware\PrepareController->handle(Object(Dingo\Api\Http\InternalRequest), Object(Closure))
#8 /usr/www/app/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(124): call_user_func_array(Array, Array)
#9 [internal function]: Illuminate\Pipeline\Pipeline->Illuminate\Pipeline\{closure}(Object(Dingo\Api\Http\InternalRequest))
#10 /usr/www/app/vendor/laravel/framework/src/Illuminate/Routing/Pipeline.php(32): call_user_func(Object(Closure), Object(Dingo\Api\Http\InternalRequest))
#11 [internal function]: Illuminate\Routing\Pipeline->Illuminate\Routing\{closure}(Object(Dingo\Api\Http\InternalRequest))
#12 /usr/www/app/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(103): call_user_func(Object(Closure), Object(Dingo\Api\Http\InternalRequest))
#13 /usr/www/app/vendor/laravel/framework/src/Illuminate/Routing/Router.php(726): Illuminate\Pipeline\Pipeline->then(Object(Closure))
#14 /usr/www/app/vendor/laravel/framework/src/Illuminate/Routing/Router.php(699): Illuminate\Routing\Router->runRouteWithinStack(Object(Illuminate\Routing\Route), Object(Dingo\Api\Http\InternalRequest))
#15 /usr/www/app/vendor/laravel/framework/src/Illuminate/Routing/Router.php(675): Illuminate\Routing\Router->dispatchToRoute(Object(Dingo\Api\Http\InternalRequest))
#16 /usr/www/app/vendor/dingo/api/src/Routing/Adapter/Laravel.php(80): Illuminate\Routing\Router->dispatch(Object(Dingo\Api\Http\InternalRequest))
#17 /usr/www/app/vendor/dingo/api/src/Routing/Router.php(574): Dingo\Api\Routing\Adapter\Laravel->dispatch(Object(Dingo\Api\Http\InternalRequest), 'v1')
#18 /usr/www/app/vendor/dingo/api/src/Dispatcher.php(540): Dingo\Api\Routing\Router->dispatch(Object(Dingo\Api\Http\InternalRequest))
#19 /usr/www/app/vendor/dingo/api/src/Dispatcher.php(445): Dingo\Api\Dispatcher->dispatch(Object(Dingo\Api\Http\InternalRequest))
#20 /usr/www/app/vendor/dingo/api/src/Dispatcher.php(372): Dingo\Api\Dispatcher->queueRequest('post', 'users', Array, '{"old_id":"301"...')
#21 /usr/www/app/vendor/candybanana/creo-migration/src/ETL/Scripts/User.php(240): Dingo\Api\Dispatcher->post('users', Array, '{"old_id":"301"...')
#22 /usr/www/app/vendor/candybanana/creo-migration/src/ETL/Scripts/AbstractMigration.php(178): Candybanana\CreoMigration\ETL\Scripts\User->insert(Array)
#23 /usr/www/app/vendor/candybanana/creo-migration/src/ETL/Scripts/User.php(68): Candybanana\CreoMigration\ETL\Scripts\AbstractMigration->run(NULL, '114947')
#24 /usr/www/app/vendor/candybanana/creo-migration/src/ETL/ETL.php(348): Candybanana\CreoMigration\ETL\Scripts\User->__construct(Object(Candybanana\CreoMigration\ETL\ETL), '0adf04fce0090b6...')
#25 /usr/www/app/vendor/candybanana/creo-migration/src/ETL/ETL.php(262): Candybanana\CreoMigration\ETL\ETL->runEntityScripts(Array)
#26 /usr/www/app/vendor/candybanana/creo-migration/src/ETL/ETL.php(91): Candybanana\CreoMigration\ETL\ETL->run()
#27 /usr/www/app/vendor/candybanana/creo-migration/src/Console/Command/Migrate.php(87): Candybanana\CreoMigration\ETL\ETL->__construct(Array, Object(Candybanana\CreoMigration\Console\Command\Migrate), Object(PDO))
#28 [internal function]: Candybanana\CreoMigration\Console\Command\Migrate->fire()
#29 /usr/www/app/vendor/laravel/framework/src/Illuminate/Container/Container.php(507): call_user_func_array(Array, Array)
#30 /usr/www/app/vendor/laravel/framework/src/Illuminate/Console/Command.php(169): Illuminate\Container\Container->call(Array)
#31 /usr/www/app/vendor/symfony/console/Command/Command.php(259): Illuminate\Console\Command->execute(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
#32 /usr/www/app/vendor/laravel/framework/src/Illuminate/Console/Command.php(155): Symfony\Component\Console\Command\Command->run(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
#33 /usr/www/app/vendor/symfony/console/Application.php(844): Illuminate\Console\Command->run(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
#34 /usr/www/app/vendor/symfony/console/Application.php(192): Symfony\Component\Console\Application->doRunCommand(Object(Candybanana\CreoMigration\Console\Command\Migrate), Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
#35 /usr/www/app/vendor/symfony/console/Application.php(123): Symfony\Component\Console\Application->doRun(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
#36 /usr/www/app/vendor/laravel/framework/src/Illuminate/Foundation/Console/Kernel.php(107): Symfony\Component\Console\Application->run(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
#37 /usr/www/app/artisan(36): Illuminate\Foundation\Console\Kernel->handle(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
#38 {main}

I confirm this. I have the same problem when I run functional tests while calling routes with middleware 'api', which is a middleware from the Laravel framework. It was working before the update.
Here is the error log.
1) Tests\Functional\Http\Controllers\Api\AuthenticateControllerTest::testAuthenticate
ReflectionException: Class api does not exist

/home/vagrant/Code/rms-php-api/vendor/laravel/framework/src/Illuminate/Container/Container.php:738
/home/vagrant/Code/rms-php-api/vendor/laravel/framework/src/Illuminate/Container/Container.php:633
/home/vagrant/Code/rms-php-api/vendor/laravel/framework/src/Illuminate/Foundation/Application.php:697
/home/vagrant/Code/rms-php-api/vendor/dingo/api/src/Http/Middleware/Request.php:155
/home/vagrant/Code/rms-php-api/vendor/laravel/framework/src/Illuminate/Foundation/Http/Kernel.php:155
/home/vagrant/Code/rms-php-api/vendor/laravel/framework/src/Illuminate/Foundation/Testing/Concerns/MakesHttpRequests.php:508
/home/vagrant/Code/rms-php-api/tests/Functional/Http/Controllers/Api/AuthenticateControllerTest.php:27

The AuthenticateControllerTest raising the error
class AuthenticateControllerTest extends TestCase
{
    public function setUp()
    {
        parent::setUp();
        Artisan::call('migrate:refresh');
        $this->seed();
    }

    public function testAuthenticate()
    {
        $user = User::first();
        $credentials = ['email' => $user->email, 'password' => $user->email];
        $response = $this->call('POST', 'api/auth', $credentials);
        $content = json_decode($response->content());

        $this->assertSame(200, $response->getStatusCode());
        $this->assertNotNull($content->token);
    }
}

P.S.: Using the dev-master#3062aac74327d589e0fed92d276225ee7aaab377 commit for dingo/api in composer.json removes the bug.

Seems to have been an ordering of providers issue.
I've pushed a fix which should eliminate this so you can add the provider wherever you want in the app.php config file.
Please update and let me know.

Hi Jason - using 9c28813049bbc8bb3a62f60e9199f398e0845264 and still getting the problem on both my app and the testcase.

Agreed with @assembledadam the latest build didn't fix it. The quick fix is to move it above RouteServiceProvider in app.php:
        Dingo\Api\Provider\LaravelServiceProvider::class,
        App\Providers\RouteServiceProvider::class,

Aye, register Dingo first. I'll take another look at this tomorrow.

I confirm the quick fix that @stueynet gave. All my tests pass with his fix but I have the same reported error when I keep the former order of providers.

Yep, definitely the ordering of providers that's the problem. Reordering seems to have no adverse effects so far.

Alright so my plan is to re-work the "cloning" of the Laravel router, which is the root cause of all these other issues.
The idea behind the clone was to fix an issue with the internal dispatcher screwing up the current route on the router instance.
But I can possibly work around that. So, for now, stick with placing the provider first (which is usually how I do it, but order shouldn't matter), and I'll get back to you all with what I can come up with.

I'm adding middlewares dynamically and I get the error, even I have DIngoProvider first...

How do you add these middlewares dinamically? In the last version there is a config in dingo for global middlewares

@catalinux
In a service provider I "inject" the illuminateRouter and:
$router->middleware($middlewareKey, $middlewareRouter);

Anyway, I fix in my case downgrading to b36db17 commit (dec 2015)

Yeah hopefully resolve those issues as well with upcoming changes. Stay tuned, I'll update here when I've got something.

Okay folks can someone try upgrading to latest dev-master changes and letting me know if this is resolved?
I've reverted (what I believe to be) the root cause of the issue which was cloning of the Laravel router which prevented middlewares and bindings to be registered on the router when dispatching routes.
At the moment cloning is now done prior to dispatching the request and then the cloned instance is unset. This is temporary. I'm hoping I can re-work the internal dispatcher itself so that the router does not need to be cloned at all.

Well, in my case I don't get the error of "Class 'middleware-class' doesn't exists'.
But I do get sometimes "Maximum function nesting level of '200' reached".

It's working with that fix, although the cloning seems pretty nasty.  As you say hopefully it can be re-worked to not be necessary.
But I think i've discovered another bug (seems to be a habit of mine!) which i'm trying to get to the bottom of. Basically I'm making a request the the same endpoint with different input vars (which completely changes the output).
Problem is, the second request to the same endpoint isn't even reaching my API controller. It just spits back out the same response as the prior request, almost like it's cached.  I've checked that it 100% isn't any kind of cache I've implemented...

Where does Laravel do that? And you mean for subsequent requests during the same initial request, right?

I mean subsequent requests indeed. I believe I tracked it down to Illuminate\Routing\ControllerDispatcher::makeController() and within there you've got $this->container->make($controller);
Just means anything you set in the constructor of your controllers is obviously only called upon on the first initialisation/call - but with Dingo's internal requests, you may well make more than that.
In my case this came to light as I was processing some request inputs in the constructor, and the second request inputs were different to the first, and without a call to 'refresh' the state of those inputs in my app it meant the inputs were stale.  Fix/workaround was simply to move out of the constructor, but it certainly isn't as clean with the constructor being the only real 'boot' method of a controller.
It's a bit of a gotcha, but I don't know if I'd call this a bug (and nothing to do with this issue, sorry!).  I imagine users may expect that their controllers are initialised for each internal request, but if I'm the first person to moan, perhaps not!

I actually think this is more because Dingo is storing the controller instance to prevent it from being instantiated multiple times. In fact it was you that brought this to my attention: #922

That would be amazing and a little schizophrenic on my part! But that was actually different - that was a single request hitting the controller twice.  This is two completely separate requests hitting the controller only once.

Hm, two completely separate requests shouldn't know anything about the other request, meaning the controller should be instantiated again as nothing is "stored" between requests.
You did mention internal requests though, which, if that's the case then yes it will only be instantiated once.
If you need to you could force the instance to be forgotten by the container.
app()->forgetInstance('Your\Controller\Here');

This is an interesting point though and might be worth baking in...

I absolutely think it would be worth baking it in - I don't think it's intuitive for a user to have to manually clear out the IOC for internal requests.
As an example, in my case this was being used for a long-running ETL command line script, and I was hitting the same endpoint with different input vars like this:
$categories = \API::header('Content-Type', 'application/json')
                        ->get('media/categories', ['site_id' => 1, 'type' => 'download']);

And then in a later script (same process)
$categories = \API::header('Content-Type', 'application/json')
                        ->get('media/categories', ['site_id' => 1, 'type' => 'video']);

(Using Dingo's API facade of course)
With the 'type' input being processed in the controller constructor. Was a bit of a head-scratcher for me when I was getting 'download' categories in my second request!

This is causing me pain again, now I'm certain that this is something that the lib would benefit from being baked in :)

This was causing me massive grief - this seems to do the trick (would be nice to have a better reference to the container though, but it's 1.38am right now :)

The middleware bug should be fixed yes - the controllers being reinitialised between requests is still not merged I believe, check the PR related to this issue.

Sorry, been a while I am not working on the project using Dingo, so can't help here.

I will close due to lack of response then, if anyone still has this issue - please make a new issue using the new template.


Can't use date_hierarchy for admin of model that uses InheritanceManager

Problem
If a model uses InheritanceManager and the model's admin has date_hierarchy, the following error appears when you navigate to the model's admin page:

TypeError at /admin/MyProject/mymodel/
_clone() got an unexpected keyword argument '_annotated'

This bug only appeared after upgrading to Django 2.0.
Environment

Django Model Utils version: 3.0.0
Django version: 2.0
Python version: 3.5.2

Code examples
models.py:
from django.db import models
from model_utils.managers import InheritanceManager

class MyModel(models.Model):
    objects = InheritanceManager()
    date_time_field = models.DateTimeField()

admin.py:
from django.contrib import admin
from .models import MyModel

@admin.register(MyModel):
class MyModelAdmin(admin.ModelAdmin):
    date_hierarchy = 'date_time_field'

Pretty sure this doesn't have anything to do with the ModelAdmin portion of the examples above. I'm experiencing the same TypeError on a model that uses InheritanceManager, but without any ModelAdmin specified.
Traceback (most recent call last):
  File "/usr/local/lib/python3.5/dist-packages/django/core/handlers/exception.py", line 35, in inner
    response = get_response(request)
  File "/usr/local/lib/python3.5/dist-packages/django/core/handlers/base.py", line 128, in _get_response
    response = self.process_exception_by_middleware(e, request)
  File "/usr/local/lib/python3.5/dist-packages/django/core/handlers/base.py", line 126, in _get_response
    response = wrapped_callback(request, *callback_args, **callback_kwargs)
  File "/usr/local/lib/python3.5/dist-packages/django/views/decorators/http.py", line 40, in inner
    return func(request, *args, **kwargs)
  File "/usr/local/lib/python3.5/dist-packages/django/utils/decorators.py", line 142, in _wrapped_view
    response = view_func(request, *args, **kwargs)
  File "/var/www/t4b-server/trivie/authentication.py", line 205, in do_authentication
    return f(*args, **kwargs)
  File "/var/www/t4b-server/management/views/dashboard.py", line 124, in difficult_questions
    .exclude(answered_count_calc__lte=3) \
  File "/usr/local/lib/python3.5/dist-packages/django/db/models/query.py", line 843, in exclude
    return self._filter_or_exclude(True, *args, **kwargs)
  File "/usr/local/lib/python3.5/dist-packages/django/db/models/query.py", line 850, in _filter_or_exclude
    clone = self._chain()
  File "/usr/local/lib/python3.5/dist-packages/django/db/models/query.py", line 1156, in _chain
    obj = self._clone()
  File "/usr/local/lib/python3.5/dist-packages/model_utils/managers.py", line 100, in _clone
    return super(InheritanceQuerySetMixin, self)._clone(**kwargs)
TypeError: _clone() got an unexpected keyword argument '_annotated'

I plan on looking at this in more depth tomorrow. I'll report back with what I find.


[VL] Add MergeTwoPhasesHashBaseAggregate to injectRas list

Description
Add MergeTwoPhasesHashBaseAggregate to injectRas list to make RAS support merge aggregate

@zhztheplayer @jackylee-ch Could you please take a look, thanks


Improve summarise API

I'm not a fan of the agg approach a la pandas and much prefer dplyr's summarise. Lazy polars can get us there, such that the summarise API and mutate API can be almost identical.
Also probably need to add aliases for -ise to -ize for American spelling.

Closing this in favor of #223. :)


get masks

Hello everyone,
How can I get the mask of output images, please? thank you

Yes you can get mask by changing model path in eval config file to your save checkpoint file and then run python eval_segmentation.py file.

Error executing job with overrides: []
Traceback (most recent call last):
File "G:\STEGO\src\eval_segmentation.py", line 187, in my_app
plot_img = (prep_for_plot(saved_data["img"][img_num]) * 255).numpy().astype(np.uint8)
IndexError: index 260 is out of bounds for dimension 0 with size 260
how to get all the mask of output images ?


ISO code for Telangana (IN)

The Telangana state in India and the Sejong province in Korea are new and up until recently didn't have any official ISO codes, but I see that codes are now listed on the ISO site:
https://www.iso.org/obp/ui/#iso:code:3166:KR
https://www.iso.org/obp/ui/#iso:code:3166:IN
That probably means they're safe to include in the dataset?

Sejong has been fixed.

Telangana has been fixed as well.


Make host status less aggressive when failing

We should slow down the retry for the host status to help reduce the number of errors we hit while the host is coming back up again.

Related to https://github.com/projectkudu/AzureFunctionsPortal/issues/612

retry 12 times with 5 seconds delay. This would retry for 1 minute before throwing.
This used to be 5 times over 300 msec. which is 1.5 seconds.
I also increased the general retry logic to be 5 times with 1 second delay, so it's 5 seconds now rather than 1.5.


Throttle policies cannot be removed from different tenant

Description:
If two tenants have the same throttling tier and if tenant1 is using that tier tenant2 cannot delete the tier from the environment.

@kavishkafernando Let's refer the git issue from the fixing PRs.
And please add the Affected/[version] label.


HTTP: Merging HTTP header maps should ignore case

HTTP headers defined in protocol and request are not detected as having the same name when they have different cases.

Duplicate #4106 ?

@Isammoc No. #4106 actually reports 2 different issues: one with Gatling and one with the recorder.

I don't see the bug in the recorder.
The recorder records headers from the browser which are not same case as netty's headers.
Now you fix the insensitive case headers merging, the recorder won't be a problem anymore, will it?

That was more of a possible improvement to enforce standard HTTP/2 case, but I gave up on that.

Close as of #4106


Add Leptos-Use to the template

Full disclosure: I'm the author of Leptos-Use but I sincerely think that it would be useful as a default dependency.

@maccesch, Thank you for the leptos-use! And thank you for the attention here :)
Yeah, i'm definitely up to add leptos-use. Lots of useful utils.
Soon I will spend more time with this project.
Thinking about use_sorted, is_*** utils, and debounces. And any other suggestion is also welcome :)


Using http-request plugin in integration tests fails due to wrong Guava version

Jenkins core still uses Guava 11:
https://github.com/jenkinsci/jenkins/blob/d4690b20f9dc170f7657c6b36df2c0d48a217ebe/bom/pom.xml#L42
My integration test uses http-request-plugin 1.8.26. Looking at the dependencies of the Gradle plugin, Guava 18 is used:
$ gradle dependencies | grep guava
|    |    |    |    +--- com.google.guava:guava:11.0.1 -> 18.0
|    +--- com.google.guava:guava:11.0.1 -> 18.0
+--- com.google.guava:guava:18.0
|    |    |    |    +--- com.google.guava:guava:11.0.1 -> 18.0
|    +--- com.google.guava:guava:11.0.1 -> 18.0
+--- com.google.guava:guava:18.0
|    |    |    |    +--- com.google.guava:guava:11.0.1 -> 18.0
|    +--- com.google.guava:guava:11.0.1 -> 18.0
+--- com.google.guava:guava:18.0
|    |    |    |    +--- com.google.guava:guava:11.0.1 -> 18.0
|    +--- com.google.guava:guava:11.0.1 -> 18.0
+--- com.google.guava:guava:18.0
     |    |    |    +--- com.google.guava:guava:11.0.1
     +--- com.google.guava:guava:11.0.1 (*)
+--- com.google.guava:guava:18.0 (n)
|    |    |    |    +--- com.google.guava:guava:13.0.1 -> 18.0
|    |         |    +--- com.google.guava:guava:11.0.1 -> 18.0
|    |         |    |    |    +--- com.google.guava:guava:14.0 -> 18.0
|    |         +--- com.google.guava:guava:11.0.1 -> 18.0
|    +--- com.google.guava:guava:18.0
     |    |    |    |    +--- com.google.guava:guava:11.0.1
     |    +--- com.google.guava:guava:11.0.1
|    |    |    |    +--- com.google.guava:guava:11.0.1 -> 18.0
|    +--- com.google.guava:guava:11.0.1 -> 18.0
+--- com.google.guava:guava:18.0
|    |    |    |    +--- com.google.guava:guava:11.0.1 -> 18.0
|    +--- com.google.guava:guava:11.0.1 -> 18.0
|    |    \--- com.google.guava:guava:11.0.1 -> 18.0
+--- com.google.guava:guava:18.0
|    |    |    |    +--- com.google.guava:guava:11.0.1 -> 18.0
|    +--- com.google.guava:guava:11.0.1 -> 18.0
|    |    \--- com.google.guava:guava:11.0.1 -> 18.0
+--- com.google.guava:guava:18.0

Guava 18 does not contain com.google.common.collect.Ranges any more and my integration test using http-request-plugin fails to import that class. See https://github.com/jenkinsci/http-request-plugin/blob/eb45bd7e963903f355c22377266fe907c9ea45f7/src/main/java/jenkins/plugins/http_request/HttpRequest.java#L27

Found the cause of my problem
pluginDependencies {
dependency("org.jenkins-ci.plugins", "jira", "3.1.1") // has dependency to guava 18.0
}
downgrading that plugin to 3.0.9 solves my dependency problem.

https://github.com/jenkinsci/jira-plugin/blob/master/pom.xml#L142

I was able to work around this issue without downgrading any plugins by adding the following to build.gradle:
dependencies {
  integrationTestImplementation enforcedPlatform("org.jenkins-ci.main:jenkins-bom:${jenkinsVersion}")
}

(Here, jenkinsVersion is the version of Jenkins core I am using.)
The Jenkins core BOM defines the old versions of Groovy and Guice used by Jenkins core. By importing this BOM using enforcedPlatform, the versions defined in the BOM override the newer versions found in the dependency graph. Note that you must be using Gradle 5.0 or later to be able to import Maven BOMs.

https://github.com/mkobit/jenkins-pipeline-shared-libraries-gradle-plugin/issues/65#issuecomment-730512926 solved my issues with latest plugins and Jenkins pipeline tests.

I'll look to make use of enforcedPlatform for the Jenkins BOM or some other dependency maneuvering to ensure runtime compatibility in the next release.


instagrapi.exceptions.ClientUnauthorizedError: 401 Client Error: Unauthorized for url: [BUG]

To Reproduce
from instagrapi import Client
import os

def login(username, password):
    cl = Client()
    cl.delay_range = [60, 70]
    if os.path.exists(f"settings({username}).json"):
        cl.load_settings(f"settings({username}).json")
    if cl.login(username=username, password=password):
        cl.dump_settings(f"settings({username}).json")
        print("Login successful")

        # Add your code here to run after successful login
        yo = cl.user_followers_gql_chunk("xxx", 0, "None")
        print(yo)

        return cl
    else:
        print("Login failed")

cl = login('xxxx', 'xxxx')

Traceback
Traceback (most recent call last):
  File "/home/user/.local/lib/python3.11/site-packages/instagrapi/mixins/public.py", line 168, in _send_public_request
    response.raise_for_status()
  File "/usr/lib/python3.11/site-packages/requests/models.py", line 1021, in raise_for_status
    raise HTTPError(http_error_msg, response=self)
requests.exceptions.HTTPError: 401 Client Error: Unauthorized for url: https://www.instagram.com/graphql/query/?variables=%7B%22id%22%3A%2252218558877%22%2C%22include_reel%22%3Atrue%2C%22fetch_mutual%22%3Afalse%2C%22first%22%3A12%2C%22after%22%3A%22None%22%7D&query_hash=5aefa9893005572d237da5068082d8d5

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/home/shjee/Desktop/insta/main.py", line 22, in <module>
    cl = login('xxxx', 'xxxx')
         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/user/Desktop/insta/main.py", line 14, in login
    yo = cl.user_followers_gql_chunk("xxxx", 0, "None")
         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/user/.local/lib/python3.11/site-packages/instagrapi/mixins/user.py", line 664, in user_followers_gql_chunk
    data = self.public_graphql_request(
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/user/.local/lib/python3.11/site-packages/instagrapi/mixins/public.py", line 240, in public_graphql_request
    body_json = self.public_request(
                ^^^^^^^^^^^^^^^^^^^^
  File "/home/user/.local/lib/python3.11/site-packages/instagrapi/mixins/public.py", line 123, in public_request
    raise e
  File "/home/user/.local/lib/python3.11/site-packages/instagrapi/mixins/public.py", line 100, in public_request
    return self._send_public_request(url, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/shjee/.local/lib/python3.11/site-packages/instagrapi/mixins/public.py", line 191, in _send_public_request
    raise ClientUnauthorizedError(e, response=e.response)
instagrapi.exceptions.ClientUnauthorizedError: 401 Client Error: Unauthorized for url: https://www.instagram.com/graphql/query/?variables=%7B%22id%22%3A%2252218558877%22%2C%22include_reel%22%3Atrue%2C%22fetch_mutual%22%3Afalse%2C%22first%22%3A12%2C%22after%22%3A%22None%22%7D&query_hash=5aefa9893005572d237da5068082d8d5

Expected behavior
to get all the users followers
Desktop (please complete the following information):

OS: Alpine Linux
Python version 3.11
instagrapi version latest

Same problem here.

use session, do not login every run with your code
and use high quality proxy, account

Same problem using client.user_followers_gql_chunk(user_id, max_amount=200, end_cursor=current_cursor) in a for loop with sleep. In second iteration I get the error


MGDCTRS-945: Validate generated Json Schema in catalog

@rinaldodev @valdar this is a POC for validation, at this stage it is not set to fail but it emits warnings like:
[WARNING] Failure processing connector: google-storage-source-0.1, reason:
[ {
  "type" : "enum",
  "code" : "1008",
  "path" : "$.properties.gcp_service_account_key.type",
  "schemaPath" : "#/$defs/simpleTypes/enum",
  "arguments" : [ "[array, boolean, integer, null, number, object, string]" ],
  "details" : null,
  "message" : "$.properties.gcp_service_account_key.type: does not have a value in the enumeration [array, boolean, integer, null, number, object, string]"
}, {
  "type" : "anyOf",
  "code" : "1003",
  "path" : "$.properties.gcp_service_account_key.type",
  "schemaPath" : "#/properties/type/anyOf",
  "arguments" : [ "array" ],
  "details" : null,
  "message" : "$.properties.gcp_service_account_key.type: should be valid to any of the schemas array"
} ]

Added options to configure the behavior:

-Dcos.catalog.validation.mode=WARN -> would report a warning
-Dcos.catalog.validation.mode=FAIL -> would fail the build

The report would looks like:
{
  "connector" : {
    "id" : "google-storage-source-0.1"
  },
  "messages" : [ {
    "type" : "enum",
    "code" : "1008",
    "path" : "$.properties.gcp_service_account_key.type",
    "schemaPath" : "#/$defs/simpleTypes/enum",
    "arguments" : [ "[array, boolean, integer, null, number, object, string]" ],
    "message" : "$.properties.gcp_service_account_key.type: does not have a value in the enumeration [array, boolean, integer, null, number, object, string]"
  }, {
    "type" : "anyOf",
    "code" : "1003",
    "path" : "$.properties.gcp_service_account_key.type",
    "schemaPath" : "#/properties/type/anyOf",
    "arguments" : [ "array" ],
    "message" : "$.properties.gcp_service_account_key.type: should be valid to any of the schemas array"
  } ]
}

Added an option provide a patch to the definition before it is written to a file, as example:
def props = schema.requiredAt('/properties')

props.fieldNames().each {
    def f = props.get(it)
    def t = f.get('type')

    if (t != null && t.asText() == 'binary') {
        log.info("Patch binary property ${it}")

        props.with(it).put('type', 'string')
        props.with(it).put('format', 'base64')
    }
}


[WIP] Global fzf header

fzf 0.35 introduced border/preview labels. Global (e.g. top row) text can now be set for any invocation of fzf. This means that we can now have a header that displays which screen you're on when in the main zfsbootmenu interface. The recovery shell and zdebug/trace screen, and any screens requiring custom input (cloning a snapshot, pool rollback, etc) do not have a header.

Included in this WIP are the following changes:

Test if the border label option exists, gate it behind HAS_BORDER_LABEL
Add a draw_page  (would global_header make more sense?) function that determines which page to highlight based on the name of the caller. Easy to extend / keep all of the logic central to one place.
Changes the preview border from rounded to sharp, and then sets it to white. This now makes the preview border visible on the Linux console, instead of being invisible / lost space.

I believe I've accounted for every usage of fzf and preview windows. The colors used for the page text could possibly be tweaked - both the selected page and the unselected page colors. The start/end of the page string could maybe use some gussying up.

Updated to use preview window labels on the snapshot screen.


Add optional time parameters to touch function

PHP's built-in touch function has 2 optional parameter:

time
The touch time. If time is not supplied, the current system time is used.
atime
If present, the access time of the given filename is set to the value of atime. Otherwise, it is set to the value passed to the time parameter. If neither are present, the current system time is used.

These parameters are useful for some common use cases and worth to be added to the lib

Merged in b67c83752cf986ddee338d1caebfaf993040442c. Thanks!


Cannot find media files on directory

What is the path structure required to find media files on disk? I keep getting message "Retrying setup: Setup failed of provider filesystem: Music Directory  does not exist.
Do the files have to be located in the HA instance or can I play from Network?

At this time only local files are possible. I'll do my best to add network support later.
So for example on HA OS, the path could be /media/musicdir

ok, thanks for the quick response - I had hoped I'd be able to play from a folder I have mounted locally to HA - even got exicited as your intergration took some time to "sync" - think it would work, but unfortunately it was empty!
Congratulations on the launch of your integration - 3 years - a lot of effort in this!


Calculate age

Problem Statement
asks the user to enter their name and their age.
And return age in year month and days

Can I work on this issue?


working example

Here is my work

Here is my working example, it uses my own brand assets

Good work. Will be closing this request and we can target this at another branch.

:+1:


Highlighting fails after underscore in link url

Could be related to #39
[![PayPayl donate button](http://img.shields.io/paypal/donate.png?color=yellow)](https://www.paypal.com/cgi-bin/webscr?cmd=_s-xclick&hosted_button_id=QB8GQPZAH84N6 "Donate once-off to this project using Paypal")

Will break highlighting for everything after it:
https://www.dropbox.com/s/zozxl6cqixtdtsg/Screenshot 2014-08-14 16.54.27.png
Environment:

Language Gfm 0.46.0
Atom v0.121.0
React editor enabled
OS: OSX 10.9.4

I'm having an issue that's somewhat similar. When adding an url as text containing an underscore everything after it is interpreted as italic:

On GitHub the underscore within an url isn't interpreted as italic (see here).
When changing the code to an link it does work correct: [https://github.com/jerone/UserScripts/wiki/_new](https://github.com/jerone/UserScripts/wiki/_new).
Is this an intended difference between GitHub and this package?


Unpublished Gradle metadata is breaking builds

Hi,
our builds don't really work at the moment because the Gradle metadata file is not published, although the pom.xml marker suggests it.
https://repo1.maven.org/maven2/io/springfox/springfox-swagger2/3.0.0/springfox-swagger2-3.0.0.pom
<!--  This module was also published with a richer model, Gradle metadata,   -->
<!--  which should be used instead. Do not delete the following line which   -->
<!--  is to indicate to Gradle or any Gradle module metadata file consumer   -->
<!--  that they should prefer consuming it instead.  -->
<!--  do_not_remove: published-with-gradle-metadata  -->

This currently breaks when doing ./gradlew build --refresh-dependencies and is a show-stopper for us at the moment because Artifactory is returning 403 on virtual repos when it doesn't find artifacts (https://www.jfrog.com/jira/browse/RTFACT-8765)
A quick fix would be to disable metadata generation
    tasks.withType(GenerateModuleMetadata) {
        enabled = false
    }

Or by including the respective .module file in the publication step.
Cheers,
Christoph

Still relevant

Still valid

Still valid

Still valid

Still valid

This issue is breaking builds in my organization as well. Is this project still active???


docs: fix broken links part 5

This continues on fixing broken links, hopefully this is the last batch 🎉
Full list: https://docs.google.com/spreadsheets/d/1Fvob__PD6KSwvrISxpAoLdHf-d7P_youQUDhdrnTw10/edit#gid=1111993929

Merging this one @berkeli 👍 Thanks for fixing the broken links!!


history: share dialog should include live and versioned link

@jrchudy commented on Tue Feb 05 2019
When the user is looking at a versioned record page, the share dialog should include a share link for the current versioned catalog and one for the live catalog.

@carlkesselman @robes @karlcz @ljpearlman Please review and close the issue if it is good.

Its okay with me.


[bug] windows rewite and match error

When using this pattern to match and modify on Windows, without interactive mode, the modification will be displayed but the source file won't change. If using interactive mode, only a part will be modified. Using interactive mode again will directly exit.
⏯ Playground Link

Playground link with relevant code
Note: This error cannot be reproduced in the playground, but it can be replicated when executed on local Windows 10 and WSL Ubuntu-22.04 environments.
💻 Code

Code:
class AnnotationEditorLayerBuilder {
  constructor(options) {
    let div = null;
  }

  async temp(option){
    let div = null;
  }
}

export { AnnotationEditorLayerBuilder };

Pattern:
language: js
id: temp
rule:
  pattern: div

fix:
  dav

🙁 Actual behavior
https://github.com/ast-grep/ast-grep/assets/74853597/afaf852b-cd07-4527-99c5-9d906c956538
🙂 Expected behavior
The modification is completed normally.

the modification will be displayed but the source file won't change

This is the intended behavior, use the -U option to update all without confirmation. https://ast-grep.github.io/reference/cli/scan.html#u-update-all
the -i option is still under investigation


Fixed import of ReactNativePropRegistry to be not path specific.

This addresses issue #18 by fixing how ReactNativePropRegistry is imported/required.

No, this doesn't quite work. Path is still required to find the exported class