Change max-height of ModalContainer

The previously hardcoded max-height of 700px was causing issues on mobile but changing it to 100% fixes it right up 🎉
Before

After

I think you need 2 things from each type of modal:

display scrolling content (Immersive)
Force user to make an action (Dialog)

Immersive Modals always have a close a button and you can close clicking outside of it. So probably that was not intended for your UrgentTriageModal
I can think of 2 things to suggest:

Test with immersiveModal and get an approval to go with it
Since this is an edge case: test passing custom styles: These modals support the {...rest} props if you check the code it is passed to the Overlay component so you could pass a css prop with your own styles in your consumer app, you need to get to the ModalContainer via a css selector and add the mediaquery there (in your consumer app that is)

Thank you for this input Diego! On mobile, the ImmersiveModal takes up the full height of the viewport (-32px) and with some tweaking in the dev tools I wasn't able to get the desired changes needed so that it took up a similar height to that of the DialogModal. This tells me that a more substantial change may be needed to the ImmersiveModal which I don't think is worth the trouble for this bug. What I'm going to try next is writing a media query like Michael mentioned and/or passing custom styles like you mentioned so that I can try and override the max-height: 700px on the DialogModal.
This is what I got with the ImmersiveModal out of the box:

@daigof and @michaeljaltamirano I didn't have any luck accessing the ModalContainer that lives within within the ImmersiveContainer from the consumer app so I added a media query here. Adding styling with a css prop (or even within the styled component) was only applied to the initial "How can we help?" modal but not the "Report an Emergency" modal and I noticed clicking the "Report an Emergency" button didn't trigger a re-render of the component although it's hooked into a store/mobx context (mobx magic? - still learning about this library). The media query here should just work but any feedback on a different approach would be much appreciated!

@daigof and @michaeljaltamirano I didn't have any luck accessing the ModalContainer that lives within within the ImmersiveContainer from the consumer app so I added a media query here. Adding styling with a css prop (or even within the styled component) was only applied to the initial "How can we help?" modal but not the "Report an Emergency" modal and I noticed clicking the "Report an Emergency" button didn't trigger a re-render of the component although it's hooked into a store/mobx context (mobx magic? - still learning about this library). The media query here should just work but any feedback on a different approach would be much appreciated!

I've opened a PR that (I think) shows how to switch the UrgentTriageModal functionality to using an ImmersiveModal. There is indeed some mobx magic so even if you decide to go the radiance-ui-only route I hope it is instructive 🙂  https://github.com/curology/PocketDerm/pull/12143

sorry I haven't have a chance to test this thoroughly, please implement Michael change but please try with with
 ${MEDIA_QUERIES.xsUp}

Check iphones dimensions reference:

iPhone 5: 320px
iPhone X: 375px
xs breakpoint: 330px

This way you will be targeting/fixing iPhone5 issue without modifying the iPhone X experience which is the device most of our users use (in terms of width dimensions). Test and let me know if that solves your bug Ill test once this is ready. Using MEDIA_QUERIES.xsUp is the most harmless approach, I hope it fixes your issue

I don’t think this is correct. Here is a screenshot from my iPhone 12 Pro:

The real issue is that this content shouldn’t be in a dialog modal, it is too much content. Nevertheless, smUp should be used instead of xsUp. Changing max-height from 700px to 100% will not change the experience for even higher end mobile devices beyond making the close icon actually accessible without needing to scroll it into view.

I forgot we can add videos directly now and that I can take a screen recording of my phone 😅
https://user-images.githubusercontent.com/13544620/108371386-509d9c80-71c3-11eb-8e5a-294a16ab3d23.MP4


Is luajit-2.1.0-rc2 supported?

Hi,
Sorry for asking the quesiton here. Is luajit-2.1.0-beta2 supported (it's built on macos 10.11 with system-lua and luajit flags)?
I'm getting segmentation fault just to call newstate.
import qualified Scripting.Lua as Lua

main :: IO ()
main = do
  lua <- Lua.newstate
  Lua.close lua

(lldb) run
Process 689 launched: 'script/luafun' (x86_64)
Process 689 stopped
* thread #1: tid = 0x3216bf, 0x00007fff04c5f530 libluajit-5.1.2.dylib`lua_createtable +16, queue = 'com.apple.main-thread', stop reason = EXC_BAD_ACCESS (code=1, address=0x8)
    frame #0: 0x00007fff04c5f530 libluajit-5.1.2.dylib`lua_createtable + 16
libluajit-5.1.2.dylib`lua_createtable:
->  0x7fff04c5f530 <+16>: movl   0x8(%rbx), %eax
    0x7fff04c5f533 <+19>: movq   0x20(%rax), %rax
    0x7fff04c5f537 <+23>: movq   %rax, %rcx
    0x7fff04c5f53a <+26>: shrq   $0x20, %rcx

Thanks for the neat lib!
Feng

may be related to http://luajit.org/install.html

If you're building a 64 bit application on OSX which links directly or indirectly against LuaJIT, you need to link your main executable with these flags:
-pagezero_size 10000 -image_base 100000000

Anybody know how to pass them through stack build?
Thanks!

Found my answer!
stack exec -- ghc -optl'-pagezero_size 10000,-image_base 100000000' script/luafun.hs


Available events documentation

It would be great to document the available events that can be bind

@Maxwell2022 Maybe we can complete the events by ourselves since the author said not enough time to maintain.

@Maxwell2022 Please just use my node-webcrawler instead, because the current author won't maintain crawler any more and didn't transfer the repo to any others, I have fixed several critical bugs and will continue to maintain it.

event name has been documented in latest version.


Attach Lambda function to VPC

It doesn't look like the above can be done with this module, according to main.tf#55-75. Is it actually the case or am I just looking at the wrong code?
Also, if it is actually not possible, was there an explicit decision to not allow the option?

Hi, thanks for raising the question.
VPC support is on my radar, but didn't have enough time for exploring that feature so far.
It's one of the goals of this project to leverage the full potential of the regional Lambdas, since most projects in this area use Lambda@Edge which is limited in those capabilities.
But since we aim for an enterprise use of Next.js here VPC would be a great addition IMO 👍

Awesome! I have this WIP PR that I'm testing on a project at the moment. I'll move it to be reviewable if all the scenarios I have in mind pass (as in functions get attached, correct routing, correct permissions).
https://github.com/dealmore/terraform-aws-next-js/pull/111


Exception-based context

Re: #479

Gonna add docs, fix the build, then I think this is good to go.

We want to use annotate_exception and it seems this patch fixes a bug we've found (the need for the DeepMerge there). Without the deep merge, extra data we pass to annotate exception will be overwritten by the options passed to Event.from_exception.
Any plans on getting this merged?

Yes - it'll be in this week, I promise!

@nateberkopec hey, sorry to push you, but I took liberty to look at the tests and it seems the needed changes are merely style. Would it be possible to release it any time soon?

@juanibiapina yup, doing more work today and then its probably new version time

@nateberkopec Would you release a version with these changes if your current work is not yet finished?


Prototype Logstash T-Splitting Locally

Depends on task: https://github.com/opensearch-project/opensearch-migrations/issues/88
Task
Using the tooling created in the preceding task (https://github.com/opensearch-project/opensearch-migrations/issues/88), develop a bare-bones prototype to analyze the performance of Logstash as a T-Splitter.
Acceptance Criteria

Code to automate creation of two Elasticsearch or OpenSearch Clusters, a Logstash instance, and the configuration to pipe requests sent to the Logstash instance to both Clusters
Demo automated setup, T-Splitting, and automated teardown to the team

High level estimate -- may need to revisit: 13

As discussed in https://github.com/opensearch-project/opensearch-migrations/issues/76, investigation indicates that Logstash/data prepper are not well suited to provide synchronous proxy and recording of the traffic stream to the primary cluster.  Closing task.


Raiding Issues/Suggestions

[ ] Would it be possible to setup pings for raiding report to verified wallet owner?

[x] Add a click on that to bring up modal of defending army composition (I dont think theres a way to see in frontend currently unless you have an army there)

[x] I have an army at realm 29. The Atlas says there is no defending army but when I click to raid a defending army is there

[x] Battle Report - At first I wasn't sure if I won. Suggest changing the battle report title to- Battle Report: Victory! -or- Battle Report: Defeat!

[ ]

closing and moving final issue into other issue


test: migrate binary_name to snapbox

What does this PR try to resolve?
Part of https://github.com/rust-lang/cargo/issues/14039.
Migrate tests/testsuite/binary_name.rs to snapbox.
How should we test and review this PR?
Two things need to beware of

A new redaction is added: [ELAPSED] for libtest output.
Snapbox's JsonLines doesn't seems to support pretty printed JSON.

Additional information

@bors r+
Checked in with @weihanglo  on jsonlines

It's a regression when reviewing those outputs. We can track it in the issue and revisit then

:pushpin: Commit a4384575f1904bb22764967351a8b99478ea45da has been approved by epage
It is now in the queue for this repository.

:hourglass: Testing commit a4384575f1904bb22764967351a8b99478ea45da with merge 33512c5a6a71360d03b084c31b41f16be288bad8...

:sunny: Test successful - checks-actions
Approved by: epage
Pushing 33512c5a6a71360d03b084c31b41f16be288bad8 to master...


Add possibility to consistently get object property name

We need to get object property name in cases like Angular 2 ngOnChanges (when you need to compare key from changes map with object property name):
ngOnChanges(Map<String, SimpleChange> changes);
It would be great to have something like nameof in C#, so that we could get property name and don't be afraid that someone will rename property.
nameof(obj.propertyName); // 'propertyName'

Considering that you can't use this information (i.e. there is no reflective support), what would this accomplish?

You can use it in noSuchMethod.
It might even help you with the named arguments of Function.apply, but only if you are somehow allowed to denote a named parameter of a function signature.
It's a good idea. I wouldn't use a macro like nameof (Dart doesn't have precompiler macros otherwise), but I would definitely like something that takes qualified name in scope and provides the symbol for that name. It should be recognizable in renaming and other refactorings.
We can't use #foo since that already works for things that are not in scope.
So, for the giggles, let's try ##foo. It would have a grammar like a symbol, but be interpreted differently:
import "self.dart" as self;
abstract class C {
  static foo({bar});
  baz({qux});
  get toto;
}
main() {
  var c = ##C;
  var cFoo = ##C.foo;
  var cFooBar = ##C.foo.bar;
  var cFooBar2 = ##self.C.foo.bar;
  print(identical(cFooBar, cFooBar2));  // true, yey!
  // var wrong = ##C.biff;  // Invalid, no biff declared in C.
}

Other possible, but probably too odd, syntaxes: #foo.bar#, #:foo.bar, ...
No great syntax so far :(
See also #30518,

@matanlurey if (changes.containsKey(nameof(field)) ....

At least for that particular API, we decided it was probably wrong.
I don't know if I'd push for a language feature to fix the API we created (personally).

In our big project. Main priority is code support. We have 'toName', 'toSymbol' an analog of nameof. It is made using a transformer and the special code for run vm test.
We very often use this for:
Deserialization/Serialization, Angular.Dart, noSuchMethod
// Deserialization
class AccountDeserializer extends EntityDeserializer {
  static final _rightsSymbol = toSymbol((Account o) => o.rights);
  static final List<DeserializeField> _fields = [
    new DeserializeSingleField("isOwner", toSymbol((Account o) => o.isOwner)),
    new DeserializeSingleField("isAdmin", toSymbol((Account o) => o.isAdmin)),
....

// Angular
ngOnChanges(Map<String, SimpleChange> changes){
   if (changes.containsKey(nameof(field)) ....
}

Interface
toSymbols([o.field1, o.field2]);// => [#field1,#field2]
toSymbol(o.field1);// => #field1
toSymbols((Task o)=>[o.field1, o.field2]);// => [#field1,#field2]
toSymbol((Task o)=>o.field1);// => #field1

toNames([o.field1, o.field2]);// => ['field1','field2']
toName(o.field1);// => 'field1'
toNames((Task o)=>[o.field1, o.field2]);// => ['field1','field2']
toName((Task o)=>o.field1);// => 'field1'

All this is directed to ensure that the code is connected at all parts. Developers should receive a real "Find usages". Developers should safely refactor the code. Also in our company, literals are forbidden. Since literals are potential errors.
Now the transformer has become a problem, as we move to build. 'nameof' solves the problems at the language level.
@matanlurey @lrhn

this would help me so much.
All my models are like:
class SomeClass extends Model {
  int _myProp;

  int get myProp => _myProp;
  set myProp(int x) {
    this.modified('myProp', _myProp, _myProp = x);
  }
}

would be amazing to do something like:
class SomeClass extends Model {
  int _myProp;

  set myProp(int x) {
    this.modified(##SomeClass.myProp, _myProp, _myProp = x);
    // becomes
    this.modified('myProp', _myProp, _myProp = x);
  }
}

@lrhn @munificent @leafpetersen – is this more of a language request?
I've been hitting this a lot in the last few days – would make a lot of folks very happy!

Yes, this sounds like a language request to me. Want to move it over to the language repo?

Yes, this sounds like a language request to me. Want to move it over to the language repo?

Sure!


JQuery - Slick Slider - Only shows the first image

I have created a slick slider on a site. I can see it goes into 'slick mode', but doesnt show the number of slides I have told it too. They are all there and I can make them show by changing their 'left' and 'opacity' css values.
I won't be able to replicate this as I have used slick reliably forever and will work if I dumb it down.
The slider is within the blue section under the main image. There should be 4 slicked slides. However it only shows one.
If anyone thinks they can crack it pop over here: https://development.materialshub.com/2018/11/13/altered-visions/
====================================================================
Steps to reproduce the problem...
I have never had trouble with this slider before - its amazing...
====================================================================
What is the expected behaviour?
To show all four slides
====================================================================
What is observed behaviour?
1 slide shows at the correct width to show all four but the other slides are given opacity 0 and a left value that places them on top of each other.
====================================================================
More Details

Which browsers/versions does it happen on? Chrome, Firefox, Safari
Which jQuery/Slick version are you using? 1.8.1
Did this work before? it is a new build

:S - Nobody with any ideas?

Please! My brain hurts!

Your development site is just a static image.


[Bug] Clicking outside of  elements doesn't close popup

For example I highlight a text in elements I've chosen, popup shows and if I click outside (for example on background), text gets de-selected but popup remains.

yup noticed that too, needs a more general close event.

Screencast

Fixed in my fork of SelectionMenu that addresses a few other issues from selection-sharer and makes it general-purpose (i.e you can put anything you want in the menu).


Newsletter Content Request for Ideas: 9/1/16 - 9/7/16

Request for Newsletter content:
Open a new issue and label it as a "topic suggestion" in order to submit ideas for the next newsletter. Submissions for the 9/28 drop date will be taken from 9/1 to 9/7.

Submission period is closed.


Erlang Support

Check for existing issues

[X] Completed

Describe the feature
It would be nice if Erlang is supported out of the box. It has an LSP implementation at https://github.com/erlang-ls/erlang_ls and a tree-sitter implementation at https://github.com/WhatsApp/tree-sitter-erlang
If applicable, add mockups / screenshots to help present your vision of the feature
No response

Used wrong template.


'security' block is not loaded

Sphinx documentation generated from OpenAPI 3.0 doesn't contain information from security block. For example about required bearer token

Reference to standard: https://github.com/OAI/OpenAPI-Specification/blob/master/versions/3.0.2.md#securitySchemeObject

Related to https://github.com/sphinx-contrib/openapi/pull/61


allow setting column to false to ignore it in addTimestamps

Closes #1985
This allows using the boolean false for the first two arguments to addTimestamps and addTimestampsWithTimezone to have it skip adding that column to the table.

Damn, I don't remember the last time I created an issue in an OS repo and the idea got accepted AND done in less than a few months. I didn't even have time to get psychologically prepared to make my "first" PR into the project :(((
Congratz you all! hahaha


push the next words onto the result array

Hello! Thank you for all the modules :surfer:
I noticed that fill was returning stuff that seemed slightly out of order, by doing a push on the next words the results end up looking like [..., previousWords, currentWord, nextWords, ...], rather than [lastWord, firstWord, ...,  currentWord].

:+1: I agree it should do push rather than unshift.
Thanks for all your modules, Substack! /beep boop


Option to do near fully configurable UFW rules based on Ansible UFW Module for ALB hosts

With #1 already working, this issue is about create one way to create some way to just mimic same variables used on https://docs.ansible.com/ansible/latest/modules/ufw_module.html.

The folder https://github.com/fititnt/ap-application-load-balancer/tree/master/tasks/ap-firewall could be removed. The new tasks/ufw already can be used even without other features of ALB.
The file firewall-internals.md and nlb-internals.md could also be merged on the alb-internals.md. We will have other components, so this could start get very big soon.


Example how to use

It would be great if you can supply a working example.

Hi @rogierlommers I have included a basic example in the README. Is that what you were looking for? If there is something more you need, let me know.

Sorry, didn't saw the rest of the readme (I looking on mobile). Will check it out. Basically what I was looking for was a piece of code to run on two nodes which illustrates what Huton does.

Hi, @rogierlommers I have expanded the usage example in the README. Is this explanation sufficient or is there something else you'd like to see expanded on?

Thanks; I'm able to setup a cluster of three now. Now the next step is to put some data in, I tried this: curl -v -X POST http://<IP_ADDRESS>:8200/ -d {"key":"value"}. Now I receive this: memberlist: Received invalid msgType (80). So for some reason I cannot put some data in.

@rogierlommers sorry for being so late getting back to you on this. I became super busy with my day job. Anyway, are you per chance running this in Windows 10 via the bash shell?


First image of a slider is not shown completely.

If a 'slicked' slider is replaced with jquery.replaceWith and another instance of Slick is created the first photo is not shown completely

http://jsfiddle.net/0u2en6tq/1/

Steps to reproduce the problem

Create slick slider with the given config
make replaceWith with the 'before slick' html
Create slick slider again with the same config
See the first image is absent or shown half of its normal size

What is the expected behaviour?
Normal first image

What is observed behaviour?
Empty field or a part of image. Images appears after switching slides.

More Details
'Hack' to fix:
$('.slider-for div.slick-list').css({height: ''});
u see after Slick initialisation .slick-list height is not of the normal size. That's why image is not shown completely.
The fiddle example is a bit not good looking but rather functional.

I think that'll be because slick can't calc dimensions when its display none. You might be able to use slick set position of visibility hidden. Good luck!
Closing: support request


Add wayfinding at root of docs.wildfly-swarm.io.

[ ] Have you followed the guidelines in our Contributing document?
[ ] Have you created a JIRA and used it in the commit message?
[ ] Have you checked to ensure there aren't other open Pull Requests for the same issue?
[ ] Have you built the project locally prior to submission with mvn clean install?

retest this please

Will fix for Windows, probably replacing bash with jruby.


Fix broken website search

Summary
Search is currently broken. Couldn't test it before due to hidden API key. I think it's okay to expose the API key because it's easier to test for contributors.
Look at how Docusaurus do it https://github.com/facebook/Docusaurus/blob/e9f290f7887aaeb7a899ffdce7f8ea3d398758ba/website/siteConfig.js#L37
Test plan
jestjs.io (before)

after

Closed. Fix in algolia itself https://github.com/algolia/docsearch-configs/commit/acd518393f60b6e369f7995d318c34ae43b4cc03#commitcomment-29529347


Add weight to a query clause

Is your feature request related to a problem? Please describe.
We want to assign weights to certain parts of the query.
Describe the solution you'd like
(( docId contains "testDoc" AND docId_attr matches "^test\\-ranking.")) OR (( docId contains "new-doc-testl" AND docId_attr matches "^test\\-ranking."))
We would like at assign more weightage to the 1st OR query clause instead of the 2nd one.
Describe alternatives you've considered
We are currently using the weight provided by vespa for assigning weights to terms if needed but we would also like to add weights to certain parts of the query

duplicate / related #14171


GH-339 Added artifactory_remote_generic_repository and other missing …

…remote repos in non-messy setup
Fixes: #339

BTW, can we hope to see the virtuals and federated ones all implemented?


Clarify how commit characters from capabilities and completion items combine

I learned from speaking with team members that commit characters on completion items add to, rather than replace, commit characters from the capabilities. This was a surprise to me and, looking at the spec, I cannot find the information.
export interface TextDocumentClientCapabilities {
			/**
			 * The client supports commit characters on a completion item.
			 */
			commitCharactersSupport?: boolean

interface CompletionItem {
	/**
	 * An optional set of characters that when pressed while this completion is active will accept it first and
	 * then type that character. *Note* that all commit characters should have `length=1` and that superfluous
	 * characters will be ignored.
	 */
	commitCharacters?: string[];

export interface CompletionRegistrationOptions extends TextDocumentRegistrationOptions {
	/**
	 * The list of all possible characters that commit a completion. This field can be used
	 * if clients don't support individual commmit characters per completion item. See
	 * `ClientCapabilities.textDocument.completion.completionItem.commitCharactersSupport`
	 *
   * Since 3.2.0
	 */
	allCommitCharacters?: string[];

If it's not too late, having the CompletionItem.commitCharacters override CompletionRegistrationOptions.allCommitCharacters would be more powerful than them being additive. C++ has a scenario for this: . is normally a commit character, except in #include completion (same goes for -, +, ,, and any other character that can be part of a filename).

The team member (which was me :-)) was not correct. The allCommitCharacters on the registration capability should only be used if clients don't support individual commit characters. So from a spec point of view they are currently exclusive.
Give this I have no problem clarifying the spec and saying if both are provided the once on the completion item wins.
Sorry for the confusion around this.


Remove inputs which are not files from CsWinRTGenerateProjection target.

The msbuild documentation  states that the Inputs property of a target must be a list of files. However,  $(CsWinRTExcludes);$(CsWinRTIncludes);$(CsWinRTExcludesPrivate);$(CsWinRTIncludesPrivate);$(CsWinRTFilters);$(CsWinRTWindowsMetadata) are not files, so the target does not run incrementally as the non-files are always absent.
I think it's just safe to just remove these, if they are changed then a project file or targets file will have changed, which should trigger the correct incremental build behavior.

I don't think we should remove the inputs, but probably need to specify differently how the are consumed as inputs, for example by hashing them and writing to a file and then use the file as input. This is how CoreGenerateAssemblyInfo in the .NET SDK does this.

@jlaanstra is it not sufficient that the inputs ultimately came from a csproj/props/targets? Or can they flow in from computed results too?

If you change those properties, you must have changed your vcxproj and those will cause a rebuild of your project... right?

If you change those properties, you must have changed your csproj and those will cause a rebuild of your project... right?

Nothing prevents these properties to be defined dynamically without requiring changes to csproj/props/targets.

Sure, I'll take a look at it. I am not an msbuild expert though so I may need some help if I get lost.

One other thought I had that is similar to the hashing approach is, we instead generate the cswinrt.rsp in a separate target from where we call cswinrt.exe.  And the target which calls cswinrt.exe has the rsp file as an input so it only runs if that changes.  Not sure if the hashing approach is better than this or is equivalent.

This approach is pretty uncommon. Most targets don't do this. Who is dynamically changing these inputs that the ROI of doing this work is worth it?

Is it possible for us to just document (or enforce?) that these properties must only be provided in csproj/props/targets files?
Would changing these dynamically even work with all the other parts of the build process?

One other thought I had that is similar to the hashing approach is, we instead generate the cswinrt.rsp in a separate target from where we call cswinrt.exe. And the target which calls cswinrt.exe has the rsp file as an input so it only runs if that changes. Not sure if the hashing approach is better than this or is equivalent.

We currently use cswinrt.rsp as the output marker so we'd need to find a different output marker.

I can see why someone might include "dynamic" stuff in the generated AssemblyInfo.cs (time of build, git commit hash, etc), making "perfect dependency tracking" a necessity in CoreGenerateAssemblyInfo. However, going for perfect dependency tracking is the exception, not the norm in MSBuild targets. For example, if I define CheckForOverflowUnderflow based on the time of day, that'll break my incremental builds.
A good parallel for the dependency of CsWinRTGenerateProjection on the value of CsWinRTExcludes, would be the dependency of CoreCompile on the value of CheckForOverflowUnderflow. It's also an imperfect dependency (it doesn't work if I define CheckForOverflowUnderflow based on the time of day, or override it on the command line), but it's considered good enough, that's ensured by mainly two things:

CoreCompile depends on MSBuildAllProjects
the output of CoreCompile goes to a directory that includes Configuration, just in case  CheckForOverflowUnderflow depends on that (i.e. varies in Debug/Release)

So I think as long as CsWinRTGeneratedFilesDir includes Configuration, dependency tracking here is as good as in CoreCompile.


Update CI

Makes a few improvements to CI (details included in log)

Hey, sorry I did not react to this, it got buried under my notifications and I've only noticed it now. If you still feel like applying these improvements, would you be willing to update with the latest master? (you can use a merge-commit to update if you want, we'll probably squash-merge the PR)


Added action tweet when tweet label applied

Used the tspascoal/get-user-teams-membership@v2 action to check if the user is the member of the service-mesh-performance organization.
Used the ethomson/send-tweet-action@v1 action to send the when the "issue/tweet" label is applied.
Fixes: https://github.com/service-mesh-performance/service-mesh-performance/issues/359
Notes for Reviewers
Signed commits

[X] Yes, I signed my commits.

@leecalcote can you please review this PR?

Let's see if this works... our challenge was the secrets last time...

@leecalcote I have the Twitter developer credentials required to use this action but can not think of a way that'll allow me to test those without leaking them. I'm ready to share the credentials with you on Slack if you can add those to the GitHub secrets of this repo for testing.


Switch over to application log detectors

Apparently, this detector will be almost instant as it is getting the application log rather than kusto which results in much better performance.  It still provides insights as to why the deployment has failed, so it might serve our purposes much better than Linux Web App Down Detector.

Fixed with #1444


method getStructField(xmlSchema: XmlSchema, schemaType: XmlSchemaType) in XSDToSchema.scala isn't handling a particular case in its switch statements

I am trying to convert an xsd to schema where it calls the method getStructField(xmlSchema: XmlSchema, schemaType: XmlSchemaType) - here in my case schemaType is XmlSchemaComplexType hence it gets to line no. 119 to get a match for ContentModel. Now in my case ContentModel is of type XmlSchemaComplexContent which is not handled. Hence, it throws error
`scala.MatchError: org.apache.ws.commons.schema.XmlSchemaComplexContent@5dc769f9 (of class org.apache.ws.commons.schema.XmlSchemaComplexContent)
at com.databricks.spark.xml.util.XSDToSchema$.com$databricks$spark$xml$util$XSDToSchema$$getStructField(XSDToSchema.scala:118)
at com.databricks.spark.xml.util.XSDToSchema$.getStructType(XSDToSchema.scala:200)
at com.databricks.spark.xml.util.XSDToSchema$.read(XSDToSchema.scala:47)
at com.databricks.spark.xml.util.XSDToSchema$.read(XSDToSchema.scala:57)
at com.databricks.spark.xml.util.XSDToSchema.read(XSDToSchema.scala)`

Yeah, support for XSDs is definitely not complete. Can you share an example of the XSD? not sure how hard it is to add support for this.


[2943] Update trainee TRN's

Context
https://trello.com/c/571WVMDX/2943-duplicate-trainees
Still waiting on one more trainee. They currently have 2 TRNs in DQT; waiting to find out which one is correct.
Changes proposed in this pull request

Data migration to make the TRN changes for a group of trainees

 Duplicate trainees


Improve performance when handling settings in analyzers

I profiled using StyleCopTester and noticed that a lot of time was spent reading the settings file. Previously, a SourceTextValueProvider was used to cache the parsed json data, but that is no longer used.
The following optimizations looks reasonable:

Cache the parsed json representation of settings files.
Cache complete StyleCopSettings objects, with data from the settings json file and .editorconfig.

Closing since the remaining last part was handled in #3885


Failing Tests

Some of the test cases do not work when REDCap Authentication is enabled.

RequestHandler tests break with new versions of guzzle.
Remove tests via httpclient. Replace by unit tests.

This seems fixed.


make torch melspectrogram same as the tensorflow one

Added pad_end and safe_log, and set center=False to replicate the tensorflow implementation.

Full eval done by @KinWaiCheuk using pretrained MT3 on Slakh test set, results are the same with using TF melspectrogram:


Replace Bagdes by Tags in Card props

In the documentation of dsfr (https://www.systeme-de-design.gouv.fr/elements-d-interface/composants/carte) it's already tags instead of badges.
So we should apply changes to Card component
I can work on a PR

Sorry we read a little too fast. So it seems that both tags and badges are possible but not at the same time. We would like to have the possibility to choose from tags or badges.
We thought of something like this: changing the following prop badges: BadgeProps[] | TagProps[]
Maybe reuse the  and  components?

@ocruze Seems fine

Hi @slafayIGN, thank you for bringing those rules to my attention.
If I understand correctly, you're saying that the current Card component allows usages that don't adhere to the official DSFR guidelines. Is that correct?
Are you suggesting that we should strengthen the Props type definition so that TypeScript will throw an error if all the rules aren't followed?
Should the component be completely overhauled?
Would anyone be willing to take this on? It seems straightforward, as there's no logic involved.

@ihiverlet, that's correct!
Thank you for bringing this to my attention.
I'm currently in the midst of a complete overhaul of our release pipeline, so I can't easily make a release at the moment. However, I'll address this issue as soon as I've finished with the ops work!


Various CLI fixes to run all commands, git ignore files to keep direc…

…tories, and upgrading typer version.

closing because the codebase has significantly changed


Add AIM synth

I would like to commit to creating a wrapper for AIM synthesizer from private-pgm repo

Thanks for this contribution!  It will be great to have a good workload-aware synthesizer available.
One question: where is the import for HDMM (from hdmm.matrix import Identity in aim.py) coming from?  I assume it's from ektolo, but can't find a reference in either of Ryan's repos, and it doesn't install with pip install git+https://github.com/ryan112358/private-pgm.git.

Note: we only need one version of cdp2adp - will remove the extra file in a follow up mini-PR


Support hokusai

Hokusai depends on image tags to reflect its dev->staging->production pipeline. Releasecop could add support for that.

Closed by#5.


Android mult-thread pthread_exit crash

I am debugging the casehello_world.wasm.zip on Android.
I instantiated the wasm module. I called the function _start. It will create 10 threads.
After wasm_func_call executed successfully,pthread_exit crashed.

what is the value of maximum number of threads?

12

I run it ok on MacOS and iOS.

In that case, I would suggest setting max_thread_num of RuntimeInitArgs to a larger number, like 12 or 15, then using wasm_runtime_full_init() to start everything.

In that case, I would suggest setting max_thread_num of RuntimeInitArgs to a larger number, like 12 or 15, then using wasm_runtime_full_init() to start everything.

I had set CLUSTER_MAX_THREAD_NUM to 12. And MacOS and iOS is rightly. Are there other points?

iwasm works well with the hello_world.wasm on my local environment. Could u try it, with iwasm, on MacOS?
$ ./iwasm --max-threads=20 ./hello_world.wasm
 in thread 4
 in thread 7
 in thread 6
 in thread 2
 in thread 3
 in thread 9
 in thread 5
 in thread 0
 in thread 8
 in thread 1

iwasm works well with the hello_world.wasm on my local environment. Could u try it, with iwasm, on MacOS?
$ ./iwasm --max-threads=20 ./hello_world.wasm
 in thread 4
 in thread 7
 in thread 6
 in thread 2
 in thread 3
 in thread 9
 in thread 5
 in thread 0
 in thread 8
 in thread 1

I had set CLUSTER_MAX_THREAD_NUM to 12. And MacOS and iOS is rightly. Are there other points?

I had try it on MacOS, it is OK. It only happen on Android. And it must happen.

I had try it on MacOS, it is OK. It only happen on Android. And it must happen.

When reproduce it on Android, using iwasm or your local, self compiled, wamr library?

I had try it on MacOS, it is OK. It only happen on Android. And it must happen.

When reproduce it on Android, using iwasm or your local, self compiled, wamr library?

Compile locally to .so with cmake

Since I can't reproduce it locally, here are some BKMs of the team, hope useful:

Don't mix using WAMR_BUILD_LIB_PTHREAD and WAMR_BUILD_LIB_PTHREAD together
With the help of valgrind and sanitizers(WAMR_BUILD_SANITIZER)
Shrink the problem by break something. For example:

try variant thread numbers
try variant compilation options, like BOUND_CHECK
comment wasm_deinstantiate()
comment wasm_unload()
...

Since I can't reproduce it locally, here are some BKMs of the team, hope useful:

Get it. Thanks!


How can I pass json datas to my main file ?

Hello,
I have to compile a unique main.js file to a "./build/raw/" folder. The output is going to be a file name [account_id].js (And I have to generate multiple files with multiples ids).
Before launching Browserify with gulp, I get a json from my server, which is stored in a global variable in my gulpfile.js.
Is there a way for me to provide this json/variable to the javascript ? The issue is that the code in the main.js targetted by browserify NEED this json to be able to work :)
Thanks for helping, I searched for a loooong time before asking.

Have you taken a look at b.require. It allows you to pass in a stream as a file (and you can provide a name), and then main.js can require the file you pass in for the account-specific information.

Hi,
Thanks, I found a solution by using concat with browserify to prefix my file with a global var declaration containing my json :)
I'll try to switch to your solution now. Thanks again.


[LAUNCHER]: Added first iteration of indexer, pivot, and added skeleton for shooter.

[x] Fix CI issue (should do this in a separate branch next time but I'll let myself slide on this one)
[x] Add first iteration of Indexer subsystem along with IndexNote command
[x] Add first iteration of Pivot subsystem
[x] Add skeleton for shooter
[ ] Finish first iteration for shooter

In YeetSpeaker, find a way to pass in setpoint to pivot and shooter commands instead of calculating with the interpolation table twice


Friend presence support?

available as of the open beta

This is definitely something i'll look into if I look into while fixing some other bugs it currently has.


content_blobs_storage_used_mb seems to include "pending" + "finished" blobs. (Making it not to match the actual disk-usage)

To repro:

Have save_file disabled
Check "content_blobs_storage_used_mb": in status, and the real disk-usage of blobs
Run lbrynet get 'lbry://@a#f1/ubuntu-test#e'
Run lbrynet blob clean to update the blob storage usage numbers in lbrynet status
Check "content_blobs_storage_used_mb": again, and the real disk-usage of blobs
The "content_blobs_storage_used_mb": instantly increased by ~2,8GB, but real disk_usage only increased the size of the sd_blob

Thank you very much for this clear reproduction! I was able to reproduce the issue. Opening a PR


"Table 'p.PasteFile' doesn't exist"

need initiate database and table if not exsit ?
ProgrammingError: (_mysql_exceptions.ProgrammingError) (1146, "Table 'p.PasteFile' doesn't exist") [SQL: u'INSERT INTO PasteFile (filename, filehash, uploadTime, mimetype, symlink, size) VALUES (%s, %s, %s, %s, %s, %s)'] [parameters: ('Screen Shot 2015-10-29 at 10.58.57 AM.png', '7d9fbd827db8476498238c62e0931ef6.png', datetime.datetime(2015, 11, 1, 12, 49, 16, 668605), 'application/octet-stream', 'kaiQcU', 14736)]

@qiaoyan i fixed it. you can pull the newest code. and try again. thanks!


Resources are now added by the user, and the user is saved as a field…

… on resource.
The name of whoever checked in a resource is shown on the resource check in list next to the organisation.
New resource types added.

This is for issue #490, and addresses the second and third task.


Enhancement: Skin Editor

I think it cold be cool if you guys added a skin editor for BF and GF if the character does not have the default offsets it would be hard to find a offset for them, my way to add offset is by getting any mod that i made and creating a character

Great Idea!


Discord community created

Hi all,
We have created a Discord community for Single shot face swapping like SberSwap and SimSwap. We are working on code optimizatiobs, new models, etc. Please join us at:
https://discord.gg/rVDXtH2K

Hi all,
We have created a Discord community for Single shot face swapping like SberSwap and SimSwap. We are working on code optimizatiobs, new models, etc. Please join us at:
https://discord.gg/rVDXtH2K

"The invite is invalid"

"The invite is invalid"


Wire up client action plugins

so they can be used.
Signed-off-by: Joe Grund<EMAIL_ADDRESS>

Codecov Report

Merging #994 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #994   +/-   ##
=======================================
  Coverage   95.42%   95.42%
=======================================
  Files           2        2
  Lines         153      153
=======================================
  Hits          146      146
  Misses          7        7

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07ef44f...7dea9b5. Read the comment docs.


Add commit support to docker driver

If commit is present, after the normal execution of docker target, the container can be committed back to an image. This gives people more flexibility (docker run plus docker commit) to build images, instead of using docker build only.
Both docker build and docker commit should support extra tags instead of one, and supporting labels too.
E.g. for docker build, property image can be used as the primary tag, while additional tags property can specify more tags.
For docker commit, the value of commit specifies the primary tag, and when tags is present, additional docker tag command should be used.

tags/labels are supported, as well as other command line options.

The schema is:
targets:
  task-with-commit:
    image: alpine:latest
    cmds:
        - run something modify the file system
    commit:
        - myimage:latest
        - myimage:1.0.0
        - host:5000/myrepo/myimage:latest
        - host:5000/myrepo/myimage:1.0.0

The actual work done is:

docker run ... with cmds from alpine:latest
docker commit CONTAINER-ID myimage:latest
docker tag myimage:latest myimage:1.0.0
docker tag myimage:latest host:5000/myimage:latest
docker tag myimage:latest host:5000/myimage:1.0.0

Thanks @chempher!


base seq annotation

#1556

the resolution is kind of low, and I think the main drawing area is getting a little crowded. I think it would be better if we could 1) use some kind of vector format for drawing this rather than exporting as an image and 2) putting the base sequence annotation underneath the spectrum annotation. This seems like it may not be possible, though - does the current pdf exporter allow this?


Migrate API and generated API code into separate repo

/sig multicluster
Thinking about #173 some more, I think the best way to solve this problem is to split the cluster registry repository into two "separate units" (likely repos):

crinit, clusterregistry API server and examples
clusterregistry API

The API itself does not have that many dependencies, and should be easy for other integrators to vendor in; the clusterregistry API server and crinit have dependencies on specific versions of the API machinery and other components which should not be imposed on dependents. Or, in other words, the cluster registry binaries are "end products" that should be able to make tight decisions about their dependency versions, while the API does not have these requirements.
That said, I think this decision requires some consideration about the downsides of having to maintain two separate repos and keep them in sync within the cluster registry project. For example, generating the swagger.json file currently requires running a clusterregistry API server, which in this new model would live in a separate repository.
\cc @pmorie @madhusudancs @font

https://docs.google.com/document/d/1bqwjR5zR7TNZF3dFYIDAd_0ddDSon-RuqNq2HUKr640/edit?usp=sharing


Encrypt saved user credentials

Hawk looks like an attractive option for this. ("Secure simple key-value storage")

Closing this issue. From Using Cryptography to Store Credentials Safely:

Android's existing security model already provides plenty of protection for this kind of data. User credentials should be stored with the MODE_PRIVATE flag set and stored in internal storage, rather than on an SD card, since permissions aren't enforced on external storage. Combined with device encryption, this provides protection from most types of attacks targeting credentials.

We're already using MODE_PRIVATE on SharedPreferences and storing it in internal app data, so we should be good. In any case, using AES will not be effective since the passphrase will ultimately have to be stored unencrypted in SharedPreferences or elsewhere.


sha3/blake mismatch in deposit merkle tree

Issue
We are building the receipt_tree in the pow deposit contract with sha3, but then are attempting to verify the merkle branch in the beacon chain with hash which is defined as blake2b. This won't work! :)
Proposed Solution
Either:

require sha3 (actually keccak256) in beacon chain implementations
deploy blake2b as a precompile on existing pow chain

The latter would make Zooko very happy!
Actual question though: are we sure we are using blake2b as the phase 0 hash function? Or could we end up switching to something stark friendly?

Do we need to go through this process of explicitly and manually including Ethereum 1.0 logs on the beacon chain? Can't this happen implicitly and automatically when the POW_RECEIPT_ROOT_VOTING_PERIOD boundary is hit on the beacon chain?

hmmm I prefer explicit over implicit in general. I want a  node that is not syncing eth1.0 to be able to process and validate the deposit records.
As for the implicit vs explicit, it still doesnt resolve this mismatched hash issue.

Could keccak256 be used as a proof-of-posession hash function? If yes then it makes it more reasonable to add keccak256 to the beacon chain.

this is resolved via #227
The beacon chain is to use keccak256 for now


Webclient Interaction.

Added inputChannel with mouse interactions.
Updated UI with css and added elements to list available pears to join.

@claurendine @tylergibson I've reviewed the code and tested it and it looks great to me.

cool, will merge this after the build succeeds (there's really no reason it would not since this stuff isn't even included in it, but waiting a bit won't impact us much).


Some Extensions are missing unexpectedly.

Issue Type
Bug
Description
Sometimes when I launch the app or just after I click the Reload to update, some of the extensions would be missing.
For the first time, I lost my theme extension Dracula Official 2.9.0. I have nothing to do but try to search for it and reinstall it manually. And now I lost extensions Code Runner 0.9.0 and Language Support for Java(TM) by Red Hat 0.20.0. Nothing works and I had to reinstall it manually again!
I don't know when it comes to me for the third time that I have to reinstall some of my extensions. Maybe I have to reinstall all my extensions some day, who knows?
VS Code Info
VS Code version: Code 1.20.1 (f88bbf9137d24d36d968ea6b2911786bfe103002, 2018-02-13T15:23:28.607Z)
OS version: Darwin x64 17.4.0

System Info

Item
Value

CPUs
Intel(R) Core(TM) i5-5257U CPU @ 2.70GHz (4 x 2700)

Load (avg)
2, 2, 2

Memory (System)
8.00GB (0.54GB free)

Process Argv
/Applications/Visual Studio Code.app/Contents/MacOS/Electron

Screen Reader
no

VM
0%

Extensions (6)

Extension
Author (truncated)
Version

vscode-dash
dee
1.8.0

code-runner
for
0.9.0

python
ms-
2018.1.0

vscode-java-debug
vsc
0.6.0

vscode-java-pack
vsc
0.3.0

vscode-java-test
vsc
0.3.0

(1 theme extensions excluded)

Reproduces without extensions

Sorry about the troubles. We had a bug that the restart for updating VS Code did not consider if extensions where in the process of being updated. This is fixed in the latest insider and will be fixed in 1.21 that we'll release in the next couple of days.
//duplicate of #41894

/duplicate of #41894


Unformat data in the content loader

This moves the unformat_section_data function from the supplier frontend
into the ContentSection class.
See:
https://github.com/alphagov/digitalmarketplace-supplier-frontend/blob/d7e89ddc0abdc0d8e0e9d72035c1311ef948ad37/app/main/helpers/services.py#L83

:+1:


(build.index.prod) Fixed broken injection under windows

Problem:
When running 'run build.prod' under windows, the injected URL's have backslashes instead of slashes.
The dev build is not effected.
Before fix:
 <!-- inject:css -->
 <link rel="stylesheet" href="css\all.css?1457433908204">
 <!-- endinject -->

After fix:
 <!-- inject:css -->
 <link rel="stylesheet" href="css/all.css?1457433908204">
 <!-- endinject -->

I added 'slash' to the build.index.prod.ts and also re-factored it to be similar to build.index.dev.ts

Thanks for the catch!


Fix bug in streaming decoding

Follow-up of #233.

Codecov Report

Merging #235 (950f526) into master (8af9bc0) will decrease coverage by 0.00%.
The diff coverage is 22.72%.

@@            Coverage Diff             @@
##           master     #235      +/-   ##
==========================================
- Coverage   64.72%   64.71%   -0.01%
==========================================
  Files          82       82
  Lines       10044    10047       +3
==========================================
+ Hits         6501     6502       +1
- Misses       3543     3545       +2

Impacted Files
Coverage Δ

neural_sp/models/seq2seq/speech2text.py
58.00% <0.00%> (-0.15%)
:arrow_down:

neural_sp/models/seq2seq/frontends/streaming.py
14.78% <27.77%> (+0.62%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8af9bc0...950f526. Read the comment docs.


Automatically Create Rotation File

The plugin should automatically create/update the rotation.txt file every time the server starts, manually doing it can become a hassle for some users. I am using the latest version of CardinalPGM.

It does automatically create?

I find no rotation.txt file in my server directory. It might be an issue with updating from a previous version of Cardinal.

Could you try deleting all files and restarting the server, one should be created

Same results occur after completely deleting the server directory and restarting it.


XML parsing error with GOG sync

Setup the GOG sync and while refreshing the list of games I was getting the following:
20:20:16 | ( 2 / 14) fetching game details for blake_stone_aliens_of_gold...
20:20:22 | xml parsing error occurred trying to get md5 data for setup_blake_stone_-_aliens_of_gold_1.0_(28043).exe
20:20:26 | xml parsing error occurred trying to get md5 data for blake_stone_aliens_of_gold_<IP_ADDRESS>.dmg
20:20:29 | xml parsing error occurred trying to get md5 data for gog_blake_stone_aliens_of_gold_<IP_ADDRESS>.sh

Could be the XML schema changed? Or maybe they switched from md5 to another hashing scheme? Tough to say, not quite sure what the URLs are for those XML documents so I can't check their contents.

Just to clarify it's with all the games in my list, not just this one.

OK this looks like an upstream project problem or perhaps an access/session issue, we will have to check it out there, or perhaps GOG made some changes on their end that are unhandled in the tool. This project also hasn't been updated in their repo since 2019 so if GOG did make a change we may have to request an update.
RetroNAS does not do anything in this space apart from provide access to the software. I've looked at the playbook and we may well be able to approach updates of the local install of the software better, needs some more thought
Please ensure your login details are correct and up to date and try logging in again and re-running.

@minorOffense have you had a chance to revisit this?

I logged in again and it did it again. I was going to follow up with the
original tool author instead of bothering you with it again.
On Thu, Feb 24, 2022 at 1:21 PM sairuk @.***> wrote:

@minorOffense https://github.com/minorOffense have you had a chance to
revisit this?
—
Reply to this email directly, view it on GitHub
https://github.com/danmons/retronas/issues/117#issuecomment-1050133461,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAGU2MF2BNBVCMCC54REWQTU4ZZLDANCNFSM5PC7VU5Q
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you were mentioned.Message ID:
@.***>

--
Mathew Winstone
CEO/Co-Founder
Coldfront Labs Inc.
@.***
(866) 507-8332 x101
Coldfrontlabs.ca
twitter: @mathewwinstone
d.o: minorOffense
Dropfort - Fortified Drupal https://dropfort.com
DrupalCamp Ottawa 2019 Platinum Sponsor https://drupalcampottawa.com/

From our side i've added a warning to the screen for now with a link to the gogrepo issue while we review our options

Just to update this problem seems to have resolved itself for me without the need for any intervention, I am waiting for confirmation from others on my gogrepo ticket before I close it off. In the meantime I will leave the warning in place on our UI.


Feat: Add new design for search results page(no results found)

Fixes Issue
This PR closes #2175
Changes proposed

added the new design for the search results page(no results found)

Screenshots

Note to reviewers

made an update to the tailwind.config.js file by adding new colors that were used for building the Search page

hey @heysolomon, please make the following changes

Remove extra space in sidebar,
Shift the heading to left
Reduce vertical adding in join discord button
Increase side of the arrow in join discord button

Thanks for contributing :)

Okay, making the fixes

hey @heysolomon, please make the following changes

Remove extra space in sidebar,
Shift the heading to left
Reduce vertical adding in join discord button
Increase side of the arrow in join discord button

Thanks for contributing :)

@rupali-codes I have made the changes

[x] Remove extra space in sidebar,
[x] Shift the heading to left
[x] Reduce vertical adding in join discord button
[x] Increase size of the arrow in join discord button

Note to reviewers

I noticed the styles weren't taking effect when I tried reducing the vertical padding of the Button component in the className. I didn't want to change the padding in the component because I didn't know if the Button component was used elsewhere in the code. Ideally, my new styles are supposed to override the old ones. So, I added a tailwind package, tailwind-merge a utility function to merge Tailwind CSS classes efficiently  in JS without style conflicts.

hey @heysolomon, please make the following changes

Remove extra space in sidebar,
Shift the heading to left
Reduce vertical adding in join discord button
Increase side of the arrow in join discord button

Thanks for contributing :)

@rupali-codes I have made the changes

[x]  Remove extra space in sidebar,
[x]  Shift the heading to left
[x]  Reduce vertical adding in join discord button
[x]  Increase size of the arrow in join discord button

Note to reviewers

I noticed the styles weren't taking effect when I tried reducing the vertical padding of the Button component in the className. I didn't want to change the padding in the component because I didn't know if the Button component was used elsewhere in the code. Ideally, my new styles are supposed to override the old ones. So, I added a tailwind package, tailwind-merge a utility function to merge Tailwind CSS classes efficiently  in JS without style conflicts.

Yeah, tailwind merge is very useful and addition will just benefit in the longer run.

hey @heysolomon, please make the following changes

Remove extra space in sidebar,
Shift the heading to left
Reduce vertical adding in join discord button
Increase side of the arrow in join discord button

Thanks for contributing :)

@rupali-codes I have made the changes

[x]   Remove extra space in sidebar,
[x]   Shift the heading to left
[x]   Reduce vertical adding in join discord button
[x]   Increase size of the arrow in join discord button

Note to reviewers

I noticed the styles weren't taking effect when I tried reducing the vertical padding of the Button component in the className. I didn't want to change the padding in the component because I didn't know if the Button component was used elsewhere in the code. Ideally, my new styles are supposed to override the old ones. So, I added a tailwind package, tailwind-merge a utility function to merge Tailwind CSS classes efficiently  in JS without style conflicts.

Yeah, tailwind merge is very useful and addition will just benefit in the longer run.

Yeah

@heysolomon can you reduce the space between the search icon the top-heading

Sorry I don't clearly understand.

@heysolomon i'm talking about this

reduce size of the icon
put some space around the icon
make the button like earlier (voilet)

Oh! okay. Working on it

@rupali-codes and @Anmol-Baranwal, I fixed the icon size and spacing.
Here are screenshots of different views

Please let me know if there's any other thing I need to fix

@rupali-codes
Please check.

@Anmol-Baranwal and @CBID2 please help review and merge this PR. Thank you!


Window Reloading on every click

Godot version
3.5,4.0,4.1
System information
Windows 11, Ryzen 7 5000Series, Amd HD Graphics, GTX 1650, Laptop Asus Rog Flow x13
Issue description
Since a few days, everywhere I click in Godot, doesn't matter what project, in the editor and project screen, it seems like godot is reloading (flashing white) for a second. Even the Logo in the Taskbar is Reloading (like Godot is reopened). (Example in the Video)
What I tried:

trying other Godot versions: Steam version, standalone 3.5/4.0/4.1
reinstalling windows,
geting newest driver and windows updates
changing from forward+ to mobile and compatible

The weird thing, this only happend with my laptop and Godot. I tried it on a second device (ROG ALLY), but everything works fine on it.
https://github.com/godotengine/godot/assets/141322052/e51d62ff-00fa-427e-bd00-8c9475e38958
Steps to reproduce
not reproducable
Minimal reproduction project
not reproducable out of the box

I tested a bit. A redditor told me to use the startoption "--rendering-driver opengl3". This does not work. Then I activated "compatability mode: Windows 8" and it works, no more flickering but super worse performance :(

Can you reproduce this after enabling Single Window Mode in the Editor Settings then restarting the editor?
Do you have any third-party applications that may interfere with window managemnt or tooltips, such as shell extensions?

Hey Calinou, I couldn't wait any longer and completly reinstall windows with a full wipe of data. Now it works without problems.
I know it would have been nice to know what was causing this. But iw was a bit annoying that I couldn't work on my game.
Can we close this issue?
and no, I didn't install extra shell extensions. The only thing running in the background was "lightshot", "steam" and "amoury crate"

I just encountered the exact same problem but I really don't want to reinstall windows and wiping my data. I enabled Single Window Mode in the Editor Settings and it still persist.
https://github.com/user-attachments/assets/a0ed6620-4363-4a89-aa29-07e6bcf7454e


[TW#28495] issue about select uart

Hi,
I have tested the uart with open file way like linux. But I can't find how to config Termios. I am care about the INLCR\IGNCR\ICRNL and so on. Can you add this feature?
Best regards,
jade

Hi dobairoland,
How about it?
Best regards,

Hi @jade111. Can you please provide more information as it is suggested by the issue template (https://github.com/espressif/esp-idf/blob/master/docs/issue_template.md)? What IDF version are you using? Can you share a piece of code explaining what is wrong with the current behavior and what behavior do you expect?
The flags you are mentioning are already implemented (see https://github.com/espressif/esp-idf/blob/master/components/vfs/vfs_uart.c#L481).

I'm closing this for lack of activity. Please feel free to reopen it if this is still an issue.


PLT-6325 Prepare release.

Pre-submit checklist:

Branch

[ ] Tests are provided (if possible)
[ ] Commit sequence broadly makes sense
[ ] Key commits have useful messages
[ ] Changelog fragments have been written (if appropriate)
[ ] Relevant tickets are mentioned in commit messages
[ ] Formatting, PNG optimization, etc. are updated

PR

[ ] (For external contributions) Corresponding issue exists and is linked in the description
[ ] Targeting master unless this is a cherry-pick backport
[ ] Self-reviewed the diff
[ ] Useful pull request description
[ ] Reviewer requested

Y, it looks good, I am merging it.
Next steps are:

tag the merged commit (check git tag -a or git tag -s)
open a PR in ChAP, similar to https://github.com/input-output-hk/cardano-haskell-packages/pull/249 . Read first the README in that repo, specifically: https://github.com/input-output-hk/cardano-haskell-packages#-from-github


More cert error handling for deploy command

Handles possible cert errors when fetching deployment by url in deploy command

Codecov Report

Merging #2475 into canary will decrease coverage by 0.01%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           canary    #2475      +/-   ##
==========================================
- Coverage   10.78%   10.77%   -0.02%
==========================================
  Files         256      257       +1
  Lines        9195     9209      +14
  Branches     1020     1022       +2
==========================================
  Hits          992      992
- Misses       8100     8114      +14
  Partials      103      103

Impacted Files
Coverage Δ

src/commands/deploy/latest.js
0% <0%> (ø)
:arrow_up:

src/util/deploy/get-deployment-by-url.ts
0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a23b7dd...15fd088. Read the comment docs.


#![feature] may not be used on the stable release channel

compiling the library gives this error
error[E0554]: `#![feature]` may not be used on the stable release channel
 --> /home/moth/.cargo/registry/src/github.com-1ecc6299db9ec823/gun-0.1.2/src/gun.rs:3:1
  |
3 | #![feature(non_ascii_idents)]
  | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove the attribute
  |
  = help: the feature `non_ascii_idents` has been stable since 1.53.0 and no longer requires an attribute to enable

For more information about this error, try `rustc --explain E0554`.
error: could not compile `gun` due to previous error

I can fix this myself, just I would like confirmation from you so we could initiate a pull request once it is fixed.

Sure, go ahead!

huh, seems like it's been fixed.

seems like it's been fixed


Basic EECS 280 Materials

I'm not sure how basic we want to go with this, but would it be helpful to add a few of the Quick References from EECS 280?  Specifically I was thinking the CAEN_Linux and Compiling references.

I know we already have a page for a CAEN quickstart, the caen_linux resource may go well there?  (I don't quite know the document as I took 280 many years ago).
Right now, we have a lot of stuff on Makefiles, but not so much on compiling in general, so if you want to start a page for that, I'd say go ahead!


No manual scroll available while the script running.

The user can not use the browser internal scroll function while the script running in chrome 50.0.2661.102 m.

Script running I mean while the script scroll the page.

The user can not use the browser internal scroll function

Just to clarify, what do you mean by "can not"? Is there an error you see? And what is the expected behavior? Thanks for reporting 👍

Closing due to no response. @oneakroller, feel free to comment here again with details if you're still having problems.


Add NRPTI

Insert URLs to the project here: https://github.com/bcgov/NRPTI

[x] The projects is active, documented, open source licensed, shows usage from external parties and is directly targeting environmental sustainability. Find more details in the Contribution Guide.

All issues labeled as Good First Issue of the project listed on OpenSustain.tech will be visible on ClimateTriage.com. This is a great way to welcome new community members to your project.
All projects listed will be posted on our Mastodon channel

@marklise @NickPhura @BcGovNeal @KitArmstrong


fix up build scripts to deal with deleted go.mod

After removing the top-level go.mod/sum files, the
scripts/build-controller-image.sh and
scripts/build-controller-release.sh scripts were broken.
In the case of build-controller-image.sh, we needed to always set the
Docker build context to the top-level
$GOPATH/src/github.com/aws-controllers-k8s directory and update the
Dockerfile to always copy the go.mod and go.sum files from the service
controller's repository instead of the old go.mod/sum files from the
original monorepo.
In the case of build-controller-release.sh, we needed to pass a
--aws-sdk-go-version CLI argument to the ack-generate release
command line call to force ack-generate to not look for a go.mod file
in order to determine the aws-sdk-go version to use in constructing the
SDK helper for the code generator. In the case of the ack-generate release command, we don't actually use the aws-sdk-go contents like we
do for ack-generate apis and ack-generate controller.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jaypipes i'm curious what errors did you get after using build-controller-image.sh ? it's work fine for me with both  Dockerfile and Dockerfile.local

@jaypipes i'm curious what errors did you get after using build-controller-image.sh ? it's working fine for me with both Dockerfile and Dockerfile.local

@A-Hilaly the script broke when I merged the PR this morning that removed go.mod and go.sum from the main community repo.


⚠ Bofrost.lu has degraded performance

In 9c79f1c, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1448 ms

Resolved: Bofrost.lu performance has improved in c48e72d after 19 minutes.


Add readme file for odfe-cli

Updated ReadMe to include installation from source and usage
instructions for profile.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@aetter Thanks
@jmazanec15 Can you review one last time?


Notebooks - Diff view has different indicators based on mimetype selected

VS Code Version: 1.61.0-insider
OS Version: Windows

Steps to Reproduce:

Open diff view
Find table output - no diff indicated
Change left side mimetype to text - diff indicated
Change right side mimetype to text - diff indicated

I was not expecting changing the mimetype in step 3 would have changed the visual indicators...after some thought I could maybe understand it? However after both mimetypes are changed (step 4), I thought the visual indicators would go away and match the original but they remained.

@claudiaregio can you please share the modified document which you always reproduce the bug?

Fixed via 6f9e39711d663877986bd8050500333b00a82f20


RuntimeError when create Form

If I coding this:
from muxi.form import Form
from muxi.form.fields import StringField, SubmitField
from muxi.form.validators import Required

class MuxiForm(Form):
    name = StringField(validators=[Required()])
    submit = SubmitField("submit")

And when I create form in view function:
It called RuntimeError!!!!
now, I just use form ... import * to import flask-wtf API....(may be tooo simple...)

now I will test if I just use flask-wtf !

well, not work !!!!!!!!

now I will move MuxiForm class in views..

still RuntimeError!!!!!

Now, I just can not create Form:form = MuxiForm() , just like a 💣!!!!


CF-229 on Bosh-Lite: UAA and Routing API

I've deployed the cloudfoundry 229 release locally on bosh-lite, and the api job is "failing". I checked its processes, and only the routing_api process is not monitored.
In its log, I get the following error over and over again in /var/vcap/sys/log/routing-api/routing-api.log:
{"timestamp":"1455090652.275856018","source":"routing-api","message":"routing-api.database","log_level":1,"data":{"etcd-addresses":["http://<IP_ADDRESS>:4001"]}} {"timestamp":"1455090652.277089596","source":"routing-api","message":"routing-api.uaa-key-fetcher.fetch-key-started","log_level":1,"data":{"session":"1"}} {"timestamp":"1455090652.288404942","source":"routing-api","message":"routing-api.uaa-key-fetcher.http-error-fetching-key","log_level":2,"data":{"error":"http-error-fetching-key","session":"1"}}
This is a brand new deployment, from scratch, not a delta deployment, so I'm not sure what is causing it to fail.

Sorry, problem has been resolved using the bin/provision_cf script.


prevent race condition for status cache

https://github.com/omgnetwork/elixir-omg/issues/1557
Overview
Fixing the order of booted dependencies and made some bootup synchronus instead of async.
Changes

status.get endpoint has dependencies to underlying services like OMG.Watcher.BlockGetter, OMG.Watcher.ExitProcessor, OMG.State. These dependencies need to be available with the first status.get call (even if it's cache!).

Testing
mix test

from this article: http://davidsulc.com/blog/2018/09/08/otp-21-introduces-handle_continue-callback-to-genserver/
It seems like the call from mailbox would be handled only after handle_continue finished. And it sort of states that that is why handle_continue is invented for (to avoid race condition before really booting up the process).
Given this, I am not sure if this approach is correct on solving this?

So there are two things going on:

handle_continue
init

and their relationship to the supervisor is different. How?
While youre executing init/1, the supervisor is waiting for the process to return {:ok, pid}. If you use handle_continue (with empty init/1), the supervisor immediately gets the pid of the process ({:ok, pid}`) and continues to start other processes defined as children.
The order of children defined in the supervisor is sometimes important because of the relationships between them.
The specific problem here was that blockgetter used handle_continue and in there it's booting children:
{:ok, _} = __MODULE__.Status.start_link()
:ok = update_status(state)

which are exposed via his API:
  @doc """
  Retrieves the freshest information about `OMG.Watcher.BlockGetter`'s status, as stored by the slave process `Status`.
  """
  @spec get_events() :: {:ok, Core.chain_ok_response_t()}
  def get_events(), do: __MODULE__.Status.get_events()

So you could have a race condition where someone was requesting data from the blockgetter api, but the blockgetter wasn't fully booted because it was still processing his handle_continue. That's why we're making this a blocking operation.
cc @boolafish @unnawut

(thinking out loud)
The other scenario I'm thinking is how /status.get behaved in this case before the status cache. I think the endpoint would crash anyway so this is also not introducing a new failure mode

(thinking out loud)
The other scenario I'm thinking is how /status.get behaved in this case before the status cache. I think the endpoint would crash anyway so this is also not introducing a new failure mode

Yeah, if you called it too early, it would have crashed on you.

I think a TLDR for me would be, this makes the about-to-crash crashes earlier, and so we don't have to worry about all the possible crashing states from the async and parallel crashes later on.


shell open vscode

VSCode Version:
OS Version:

Steps to Reproduce:
让vscode可以从shell启动，例如atom的  atom . 代开当前目录代码

This is the translation I got from your text:

Let vscode start from the shell, such as the atom of the atom. Instead, open the current directory code

When you open from vscode from shell, it opens the current directory. That is by design.
What is your expectation?

It should open empty window with no folder? You can do this by code -n
It should open a particular file? You can do this by code -g file path
It should open a particular folder? You can do this by code folderpath

Does this help?


How to deploy?

I've been following this repository for a while.
As I understand, the application involves three programs: catalog, repo, client.
Instructions are given for how to install and start each program.
However, some critical information is missing:

Which programs should be installed on the file server, and which programs should be install on the client that wants to download the files?
What routing entries, if any, are needed in the forwarders?

You are correct.
The application revolves around those three programs: catalog, repo, client. There is also a hidden player within the ecosystem which is our currently-existing file server repositories.
I am going to update the instructions soon as the design is finalized; but for your own experiments and curiosity, here is the answers to your questions.

In a real-world scernio, everything would be ran on different nodes within a network. A scientific community would ideally have one catalog, many NDN repos for clients to pull from, and also keep the currently-existing file server repositories. A client that wants the file would use the repo's client program (right now its attached to the code of the repo so they would just download this entire github project). Once downloaded, they would express an interest which would contact the nearest scientific community's NDN repo. If it needs the data, the NDN repo would contact the NDN catalog to get a mapping in order to then retrieve the data from the file server repositories.

You might ask why not just contact the file servers themselves rather than going through all these different nodes to get the data? This application is designed to remove as much of the client responsibility as possible. Currently in scientific communities it is very difficult to fetch data in general. Too much responsibility for clients to sort out interface problems / knowledge AND location dependent data being hard to fetch are just some of the reasons.

The repo may need to fetch mappings from the catalog therefore a route needs to be established. Also, clients need to express their interest to the repo.

REPO routes /catalog to CATALOG
CLIENT routes / to REPO

I will keep this issue open for a reminder to include this information.


Twins program from code forces

Description
I have added the twins program from code forces in c++ language.
Fixes #747
Replace issue_no with the issue number which is fixed in this PR
Type of change
Please delete options that are not relevant.

[x] New feature (non-breaking change which adds functionality)

Checklist:

[x] My code follows the style guidelines(Clean Code) of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have created a helpful and easy to understand README.md
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests/screenshots(if any) that prove my fix is effective or that my feature works

@Amit366 kindly review my pr


New feature coming - requires UI update

In the future users will be allowed to re-stake principle and interest without performing the round trip to and from wallet software. This is a new Solidity function which has been implemented at a new branch of the interest earner smart contract
https://github.com/second-state/interest-earner-smart-contract/blob/with_re_stake_capability/InterestEarner.sol
This UI needs to have a new page/button which can call this function.

This is implemented quickly as a draft an the branch with_re_stake_capability; it requires testing
https://github.com/second-state/interest-earner-user-interface/commit/1e3281cd4f3f43ae7c3c20997f206a8074192546


New version: Google.Chrome.Canary version 128.0.6576.0

Created by 🥟 Dumplings in workflow run #6352.

Log
Updated: 128.0.6575.0 → 128.0.6576.0
Submitting WinGet manifests
Creating manifests
Uploading manifests and making commits
Creating a pull request

Microsoft Reviewers: Open in CodeFlow

/azp run

/azp run

https://github.com/microsoft/winget-pkgs/issues/142854


[ComedyCentral] Unable to extract mgid

[x] I've verified and I assure that I'm running youtube-dl 2016.09.27
[x] At least skimmed through README and most notably FAQ and BUGS sections
[x] Searched the bugtracker for similar issues including closed ones
[x] Bug report (encountered problems with youtube-dl)

matej@mitmanek: ~$ youtube-dl --verbose 'http://www.cc.com/episodes/18dju4/the-colbert-report-june-30--2011---timothy-garton-ash-season-7-ep-07086'[debug] System config: [u'--prefer-free-formats']
[debug] User config: []
[debug] Command-line args: [u'--verbose', u'http://www.cc.com/episodes/18dju4/the-colbert-report-june-30--2011---timothy-garton-ash-season-7-ep-07086']
[debug] Encodings: locale UTF-8, fs UTF-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2016.09.27
[debug] Python version 2.7.5 - Linux-3.10.0-509.el7.x86_64-x86_64-with-redhat-7.3-Maipo
[debug] exe versions: ffmpeg 3.1.3-static, ffprobe 2.6.8, rtmpdump 2.4
[debug] Proxy map: {}
[ComedyCentral] the-colbert-report-june-30--2011---timothy-garton-ash-season-7-ep-07086: Downloading webpage
ERROR: Unable to extract mgid; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see  https://yt-dl.org/update  on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
Traceback (most recent call last):
  File "/usr/lib/python2.7/site-packages/youtube_dl/extractor/mtv.py", line 208, in _extract_mgid
    og_url = self._og_search_video_url(webpage)
  File "/usr/lib/python2.7/site-packages/youtube_dl/extractor/common.py", line 776, in _og_search_video_url
    return self._html_search_regex(regexes, html, name, **kargs)
  File "/usr/lib/python2.7/site-packages/youtube_dl/extractor/common.py", line 667, in _html_search_regex
    res = self._search_regex(pattern, string, name, default, fatal, flags, group)
  File "/usr/lib/python2.7/site-packages/youtube_dl/extractor/common.py", line 658, in _search_regex
    raise RegexNotFoundError('Unable to extract %s' % _name)
RegexNotFoundError: Unable to extract video url; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see  https://yt-dl.org/update  on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
Traceback (most recent call last):
  File "/usr/lib/python2.7/site-packages/youtube_dl/YoutubeDL.py", line 694, in extract_info
    ie_result = ie.extract(url)
  File "/usr/lib/python2.7/site-packages/youtube_dl/extractor/common.py", line 355, in extract
    return self._real_extract(url)
  File "/usr/lib/python2.7/site-packages/youtube_dl/extractor/mtv.py", line 230, in _real_extract
    mgid = self._extract_mgid(webpage)
  File "/usr/lib/python2.7/site-packages/youtube_dl/extractor/mtv.py", line 224, in _extract_mgid
    r'embed/(mgid:.+?)["\'&?/]', sm4_embed, 'mgid')
  File "/usr/lib/python2.7/site-packages/youtube_dl/extractor/common.py", line 658, in _search_regex
    raise RegexNotFoundError('Unable to extract %s' % _name)
RegexNotFoundError: Unable to extract mgid; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see  https://yt-dl.org/update  on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.

matej@mitmanek: ~$

There is no video on this page.


[#22] - add query parameter for repository deletion

Looking through the code and I realized we already have an endpoint for deleting the submission only.
DELETE - /submit/{repository}/{identifier}


Extension deletes files irrecoverably

A student reported to me about a week ago that he had created a file of class notes and that it simply disappeared on him. I did't disbelieve him, but I also couldn't confirm that it was due to a fault in the plug-in. Now I can.
I just saw it myself. After working for several hours in the IDE (unfortunately without a commit), I got a "server failed 5 times and won't restart" error, which I've seen many times, but then immediately after that I got a "file not found, do you want to create it?" error. The file had been opened in a tab in the IDE. Now it was gone.
There's no question but that the IDE deleted the file, and it seems unrecoverable, as the file is not in my trashcan (on OSX). The file that was deleted was not the file I was working on at the moment the errors occurred.
This just cost me several hours of work.  Clearly a bug like this is a "must fix" before this plug-in can be considered viable for broader use.

As I really do not see any way in which the extension could delete a file,
and there was no feedback since January, I am closing this issue for now.
Feel free to reopen if you have more details or see it happening again!


Specification Chapter/Topics

[ ] Front Matter

[ ] Introduction
[ ] Specification Scope
[ ] Terms and Definitions

[ ] Source code and Rust syntax tree (graph?) - T-lang

[ ] Lexing/tokenization (@m-ou-se)
[ ] Grammar, AST
[ ] Crates, modules, source files
[ ] Macro invocations
[ ] Macro expansion and conditional compilation
[ ] Name/Path resolution of (mod-level) items

[ ] Static semantics - mixed T-lang/T-types

[ ] type checking
[ ] associated item resolution
[ ] existential (impl Trait) resolution
[ ] borrow checking
[ ] unsafe checking
[ ] const eval - T-opsem?
[ ] type inference

[ ] Dynamic Semantics - T-opsem

[ ] high level expression form
[ ] pattern matching and binding
[ ] dyn traits and dynamic method dispatch
[ ] memory layout and value representation (@chorman0773)
[ ] low level (MIR-like) statement form
[ ] memory model (borrowing; atomics)
[ ] ABIs and FFI linkage

[ ] The Core library crate - T-libs-api (@pietroalbini ??)

[ ] builtin types' traits and methods
[ ] core::* items
[ ] alloc

I'll claim ABI and FFI linkage next.


fixing issues and add test

Closes #85 and #84
There is no proper way to fix #84, but returning an empty interval makes more sense than returning (nan, nan).

@dsaxton wrote:

I think raising a helpful warning explaining why a meaningful result wasn't computed makes sense, whatever we decide the return value should be

I am not sure whether we should raise a warning or not.
Case against:
With my patch, the "bca" method now gives the same result as the "percentile" method in the pathological case, which is good. If all the replicas end up being the same value x, then the correct confidence interval according to the bootstrap algorithm is [x, x]. So it is not really an error, it is just a natural limitation of the bootstrap. We also don't raise a warning when the data sample is small, e.g. 1 element, which also makes the bootstrap meaningless.
Case in favor:
When bias and acceleration cannot be computed, the bca method becomes first-order accurate instead of second-order accurate. So issuing a warning about that makes sense.

Thanks @HDembinski


Upgrade to Symfony 4.4

This issue is imported from pivotal - Originaly created at Sep 18, 2019 by Michiel Kodde
The upcoming SF 4.4 release is a LTS release (3 years of support). Upgrading to this version seems a good starting point.

3.4 or 4.4 (subject vs body)? (Thijs Kinkhorst - Oct 11, 2019)


Chromium coredump on wayland screenshare

Describe the bug
Chromium coredumps on wayland/sway when trying to share a screen.
Steps To Reproduce
Steps to reproduce the behavior:

Use sway/wayland
start chromium --enable-features=UseOzonePlatform --ozone-platform=wayland
visit "https://www.webrtc-experiment.com/Pluginfree-Screen-Sharing/"
Click on "share screen"
Click anywhere
Core-Dump

Expected behavior
A selector for the screen to share should appear
Additional context
According chromium setting:
chrome://flags/#enable-webrtc-pipewire-capturer = enabled

According nixos configuration:
  xdg.portal = {
    enable = true;
    wlr = {
      enable = true;
      settings = {
        screencast = {
          max_fps = 30;
          chooser_type = "simple";
          chooser_cmd = "${pkgs.slurp}/bin/slurp -f %o -or";
        };
      };
    };
    gtkUsePortal = true; # does not seem to affect the issue. Same with this setting disabled.
  };

Console output when the error occurs:
[191680:191711:0406/150359.461672:ERROR:object_proxy.cc(623)] Failed to call method: org.freedesktop.DBus.Properties.Get: object_path= /org/freedesktop/portal/desktop: org.freedesktop.DBus.Error.InvalidArgs: No such interface “org.freedesktop.portal.FileChooser”
[191680:191711:0406/150359.461712:ERROR:select_file_dialog_linux_portal.cc(242)] Failed to read portal version property
[191720:191720:0406/150359.472635:ERROR:gl_surface_egl.cc(1405)] EGL display query failed with error EGL_BAD_PARAMETER
[191720:191720:0406/150359.472775:ERROR:gl_surface_egl.cc(1430)] eglInitialize Default failed with error EGL_BAD_DISPLAY
[191720:191720:0406/150359.472840:ERROR:gl_ozone_egl.cc(20)] GLSurfaceEGL::InitializeOneOff failed.
[191720:191720:0406/150359.474047:ERROR:viz_main_impl.cc(188)] Exiting GPU process due to errors during initialization
[191680:191680:0406/150359.496758:ERROR:cursor_loader.cc(116)] Failed to load a platform cursor of type kNull
[191776:191776:0406/150359.543208:ERROR:gl_surface_egl.cc(1405)] EGL display query failed with error EGL_BAD_PARAMETER
[191776:191776:0406/150359.543331:ERROR:gl_surface_egl.cc(1430)] eglInitialize Default failed with error EGL_BAD_DISPLAY
[191776:191776:0406/150359.543393:ERROR:gl_ozone_egl.cc(20)] GLSurfaceEGL::InitializeOneOff failed.
[191776:191776:0406/150359.546580:ERROR:viz_main_impl.cc(188)] Exiting GPU process due to errors during initialization
[191680:191796:0406/150359.554448:ERROR:object_proxy.cc(623)] Failed to call method: org.freedesktop.DBus.Properties.Get: object_path= /org/freedesktop/UPower: org.freedesktop.DBus.Error.ServiceUnknown: The name org.freedesktop.UPower was not provided by any .service files
[191680:191796:0406/150359.555528:ERROR:object_proxy.cc(623)] Failed to call method: org.freedesktop.UPower.GetDisplayDevice: object_path= /org/freedesktop/UPower: org.freedesktop.DBus.Error.ServiceUnknown: The name org.freedesktop.UPower was not provided by any .service files
[191680:191796:0406/150359.556719:ERROR:object_proxy.cc(623)] Failed to call method: org.freedesktop.UPower.EnumerateDevices: object_path= /org/freedesktop/UPower: org.freedesktop.DBus.Error.ServiceUnknown: The name org.freedesktop.UPower was not provided by any .service files
[191680:191680:0406/150359.560628:ERROR:system_web_app_manager.cc(320)] Exceeded SWA install retry attempts.  Skipping installation, will retry on next OS update or when locale changes.
[191816:191816:0406/150359.571755:ERROR:gl_surface_egl.cc(1405)] EGL display query failed with error EGL_BAD_PARAMETER
[191816:191816:0406/150359.571857:ERROR:gl_surface_egl.cc(1430)] eglInitialize Default failed with error EGL_BAD_DISPLAY
[191816:191816:0406/150359.571934:ERROR:gl_ozone_egl.cc(20)] GLSurfaceEGL::InitializeOneOff failed.
[191816:191816:0406/150359.573569:ERROR:viz_main_impl.cc(188)] Exiting GPU process due to errors during initialization
[191828:191828:0406/150359.601234:ERROR:sandbox_linux.cc(377)] InitializeSandbox() called with multiple threads in process gpu-process.
[191680:191680:0406/150405.624912:ERROR:cursor_loader.cc(116)] Failed to load a platform cursor of type kHand
[191680:191680:0406/150409.571176:ERROR:egl_dmabuf.cc(296)] Unable to load EGL entry functions.
[0406/150409.602465:ERROR:elf_dynamic_array_reader.h(64)] tag not found
[0406/150409.607672:ERROR:process_memory_range.cc(75)] read out of range
/home/dse/bin/chromium-wayland: line 6: 191680 Segmentation fault      (core dumped) chromium --enable-features=UseOzonePlatform --ozone-platform=wayland

Also this works fine with firefox-wayland and used to work with chromium.
Notify maintainers

@primeos
@danielfullmer
@Frostman
Metadata
Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.
[user@system:~]$ nix-shell -p nix-info --run "nix-info -m"
 - system: `"x86_64-linux"`
 - host os: `Linux 5.17.0-zen1, NixOS, 22.05 (Quokka), 22.05pre366144.bc4b9eef3ce`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.7.0`
 - channels(dse): `""`
 - channels(root): `"nixos, nixos-stable-21.11"`
 - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`

Could be related to https://github.com/NixOS/nixpkgs/issues/156950

Did screen sharing work before / is that crash (segmentation fault) new? And do you know since which version it stopped working?
So far screen sharing did never work reliably and there have been frequent regressions: https://github.com/NixOS/nixpkgs/issues/91218 (I've fixed it twice on my test setup but I've given up since then).
We might want to close this issue in favor of https://github.com/NixOS/nixpkgs/issues/91218 to keep the discussion in one place.

For me, screenshare works on Chromium v99, and stopped working after uodate to v100

For me it also worked in the past without issues.
This is new and this is chrome core-dumping. This is a different issue. If screen sharing did not work in the past, it just did not work. It did not cause an out of bounds read or crash of the browser.
Please don't close this issue.

Please don't close this issue.

Sure, we can leave it open. We should mention it in the other issue though (I just did that) for better visibility.
Now we need someone with time and motivation to handle this issue (analyzing the issue, searching for upstream issues, etc. and eventually someone needs to submit a fix).

@d4g Since this is NixOS and we have the boon of input-reproducibility and a binary cache, could you post:

the nixpkgs commit you are on
the nix store path of your chromium binary

This will make it even easier for others to reproduce.
You may also be able to get the stack trace with GDB using gdb --args chromium, use run, make the segfault happen, and use backtrace in GDB.

nixpkgs: ccb90fb9e11459aeaf83cc28d5f8910816d90dd0
/nix/store/07346c7jv5wnwg30r5dvmlgqbk52hinz-chromium-100.0.4896.60/bin/chromium

Regarding gdb: "/run/current-system/sw/bin/chromium": not in executable format: file format not recognized
How do I get gdb on the actual executable but keep the env vars of the shell script wrapper?

@chaoflow

How do I get gdb on the actual executable but keep the env vars of the shell script wrapper?

cp $(which chromium) ~/chromium-gdb
chmod u+w ~/chromium-gdb

Now edit ~/chromium-gdb, replacing like this:
-exec "/nix/store...
+gdb --args "/nix/store...

Then terminate all chromium instances (to avoid joining existing instances), and run ~/chromium-gdb.

https://bugs.chromium.org/p/chromium/issues/detail?id=1311437&q=webrtc%3A%3ASharedScreenCastStreamPrivate%3A%3AProcessBuffer&can=1
Looks like it should be fixed in m101

I tried to build chromiumDev(102) or chrimiumBeta (101) - but both failed with errors related to:
 unsupported instrumentation profile format version

This patch may be useful:
https://webrtc-review.googlesource.com/c/src/+/255601

@d4g @anthr76 building chrome s you can install the chrome dev or beta channel package. On my up-to-date, flakes-enabled nixos-unstable:
$ NIXPKGS_ALLOW_UNFREE=1 nix run --impure nixpkgs#google-chrome-dev
(fetches google-chrome-unstable_102.0.4997.0-1_amd64.deb)

The issue seems fixed there. I guess there are no dev builds of chromium upstream, that's a shame.

I've opened https://github.com/NixOS/nixpkgs/pull/169365 for a quick and dirty fix - the code isn't pretty but should do the job (I wish fetchpatch would support Base64 patches or even better: Gerrit and gitiles would support fetching patches using a sane format like basically any other web VCS frontend does...). Anyway, I'll check if the VM test passes (although that patch is so trivial that it should be unnecessary) and can merge the fix tomorrow.

I love the name webrtc-wayland-screenshare-coredump-fix.patch


Add username for unlinking

What
Add a username to user and use for unlinking requests
Ticket
CBO-1312
Why
Unlinking requests require a username to be provided
for the purposes of auditing within MLRA/MAATDB.
In addition this attribute can provide consistencty
of experience between VCD and MAAT for the purposes
of login by allowing users to login using their
username or email address.
How
Add username to user and amend authentication mechanism
(devise) to allow use of email address or username as
the login name.

TODO (wip)

[X] add field/migration
[X] enable login using email or username
[X] validate username (presence, prevent email, limit to 10 chars)
[X] send username as part of unlink request
[ ] list username in user list
[ ] rewrite feature test for unlinking and move parts to request spec
[ ] auto-generate a suggested username on new account creation *based on MLRA username
[ ] investigate whether linking needs/should have username too
[ ] constrain null values at DB level

lgtm 👍


Wrong error message for mismatched Cicero versions

The error message is wrong when trying to execute a template with the wrong Cicero version. The corresponding error is raised here:
https://github.com/accordproject/cicero/blob/52e3f515ef81e18e83315b3a796e9de7217a55fe/packages/cicero-core/lib/metadata.js#L126
where ciceroVersion is actually defined as const ciceroVersion = require('../package.json').version;
https://github.com/accordproject/cicero/blob/52e3f515ef81e18e83315b3a796e9de7217a55fe/packages/cicero-core/lib/metadata.js#L18
Which his the template version rather than the Cicero version

I looked at this too quickly. This seems to be the correct logic...


Add the possibility to give as input non-diagonal stiffness matrix and "critical" damping

https://citeseerx.ist.psu.edu/viewdoc/download?doi=<IP_ADDRESS>.5033&rep=rep1&type=pdf
Equation 23. It is an eigen value decomposition, super simple to do


Outgoing webhook app no longer available within Teams

The document states:
"Select the appropriate team and select Manage team from the (•••) drop-down menu.
Choose the Apps tab from the navigation bar.
From the window's lower right corner select Create an outgoing webhook"
Although this option for an App is longer present in Teams.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: bb9c5bd5-1ac6-dcc8-4ed6-d6aad2432776
Version Independent ID: 43e90995-bba4-86b6-1f1c-ab749e546a4b
Content: Add custom bots to Microsoft Teams with outgoing webhooks - Teams
Content Source: msteams-platform/webhooks-and-connectors/how-to/add-outgoing-webhook.md
Product: msteams
GitHub Login: @laujan
Microsoft Alias: laujan

I found it!
Could I suggest making it more visible and appear like the other apps, rather than hide down there. Also, you cannot search for this in the "More Apps" section either, making it even more difficult to find.

@DaveVoyles Thanks for sharing your suggestion. We will consider this. You can also go ahead and raise a uservoice for Microsoft Teams.


43-update-error-head-style

What type of PR is this? (check all applicable)

[ ] Feature
[x] Refactor
[ ] Bug Fix
[ ] Optimization
[ ] Documentation Update
[ ] Other (please specify here: )

Description of what this Pull Request does
Updated "Error 404" text to use established class "mainH2" to match other pages, plush a marginTop of 30px.
Related Tickets & Documents

Closes #46

Ok, this looks even better with the style add!


Add CSRF token to default component partials

HI . Thanks for this nice plugin . but i dont see any csrf token in login and register form . where is it ? and how can i add and use csrf token in this plugin for login and register form ?
thanks

@ajmanco you can do one of two things, either override the component partials (https://octobercms.com/docs/cms/components#overriding-partials) or you can create a PR to change all the partials to use the form_ajax() Twig helper instead of using hardcoded <form data-request="onRequestName"> elements. See form_ajax() on https://octobercms.com/docs/markup/function-form

@luketowers  Thanks for you reply . But i have 2 question now .
1: why this plugin dont use this laravel default features ?! And is it enaugh secure ?
2 :  if i override the component partials or create forms with ajax and custom form , will it secure enaugh ?

Fixed as of https://github.com/rainlab/user-plugin/commit/c1679ba4c4745cb216ec44b5b4cc28cc98c850aa.
@ajmanco, in response to your questions to @LukeTowers:

Whilst we use Laravel as a base framework, our scope of features is different to Laravel, so we've had to do things differently in some aspects. Rest assured that we take security very seriously.
If you override the partials and components with your own, you're effectively making yourself responsible for the security of that functionality. So it's as secure as you make it ;)