VersionControlSystem: Invert the priority of revision candidates

Previously, the last successful candidate was choosen from the list of
revision candidates and it seems that this was by accident. If a package
specifies a fixed revision in its meta-data, that revision should take
precendence over any revision guessed from the package version or Git
tags respectively. So, invert the priorities to achieve exactly that.
Note that ORT's downloader in fact preferred the guessed revisions over
the provided fixed revision for projects (ORT speak), which always have
a correct fixed revision in their meta-data (disregarding the case of a
history re-write happening after the analysis but before the downloader
or scanner run repsectively). That issue is now fixed.

Why "don't you think that's correct"?

Like I wrote, because "the last successful candidate was choosen from the list" is something different than "the last element in the list is checked whether it was successful (in each iteration)".

The last statement in the original loop is if (results.last().isSuccess) return@forEachIndexed, which erroneously works like a continue (whereas it should have been a break). As a last statement in a loop a continue is a no-op. So the loop is always over all revision candidates, whether they were successful or not. So if the last element in the list of candidates was not successful, it would still be chosen. That's why I believe saying " the last successful candidate is returned" is incorrect.

Ok, now I got it. Thanks.

Thank you for finding and fixing it! Quite an embarrassing mistake on my side (I believe it was me who introduced this code). And also a bit disgraceful that we seem to have no test coverage for this case...

Haven't done the Git blame. I'm surprised that this bug hasn't been discovered earlier. I wouldn't expect it to affect packages but for project it can mean that it's scanning an outdated commit instead of a recent one. So teams making changes to ort.yml should not that their changes do not take any effect. So, maybe the use case happens more rarely than my gut feeling suggests.


Add placeholder update handler for CDI

Issue #, if available:
Description of changes:
Add placeholder update handler on Custom Data Identifier resource
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Looks good to me! We maybe should do a quick check about whether we can/should include the word "dummy" in the commit message. I'll get back to you on that, but otherwise 👍

Updated the commit message


add selectrum module

Been meaning to try selectrum, decided to package it as a doom module. Still WIP.

consult now has consult-ripgrep and consult-find which bring us much closer to parity with the ivy module. There's just a few missing I think, like jumping to symbol in the project. I was actually planning on making a PR this weekend but here's my code so far. I've bound more consult commands and got embark working with which-key more effectively.

consult now has consult-ripgrep and consult-find which bring us much closer to parity with the ivy module. There's just a few missing I think, like jumping to symbol in the project. I was actually planning on making a PR this weekend but here's my code so far. I've bound more consult commands and got embark working with which-key more effectively.

I've added a function for selectrum project search in this PR.

I've added a function for selectrum project search in this PR.

What does your custom function for project search do that consult-ripgrep doesn't? I think we should focus on making that function great, if they're missing something not doom specific to make a PR to consult.

What does your custom function for project search do that consult-ripgrep doesn't? I think we should focus on making that function great, if they're missing something not doom specific to make a PR to consult.

What does your custom function for project search do that consult-ripgrep doesn't?

It's doom-specific stuff:

whether to search in hidden files
which directory to search in
Making the prompt more meaningful

These are mainly so that the signature of the functions align with that of ivy and helm, I suppose.

What does your custom function for project search do that consult-ripgrep doesn't?

It's doom-specific stuff:

whether to search in hidden files
which directory to search in
Making the prompt more meaningful

These are mainly so that the signature of the functions align with that of ivy and helm, I suppose.

You can change consult-ripgrep-command to set whether to search hidden files.
you can pass the directory as first argument into consult-ripgrep or consult-find
I agree that "Ripgrep in project X" could maybe use improvement, but that doesn't feel worth a redefinition here.

It seems like (consult--grep "Search" '("rg" "--whatever") custom-directory nil) gives you most of this, no?

You can change consult-ripgrep-command to set whether to search hidden files.
you can pass the directory as first argument into consult-ripgrep or consult-find
I agree that "Ripgrep in project X" could maybe use improvement, but that doesn't feel worth a redefinition here.

It seems like (consult--grep "Search" '("rg" "--whatever") custom-directory nil) gives you most of this, no?

It seems like (consult--grep "Search" '("rg" "--whatever") custom-directory nil) gives you most of this, no?

That's exactly how it's implemented now.

It seems like (consult--grep "Search" '("rg" "--whatever") custom-directory nil) gives you most of this, no?

That's exactly how it's implemented now.

Totally my bad, I looked first on my phone and clearly didn't read the code closely enough.

Totally my bad, I looked first on my phone and clearly didn't read the code closely enough.

@loafofpiecrust @jethrokuan I am looking forward to seeing the Selectrum/Consult/Embark suite of packages in Doom. Please let me know if you need anything on the side of Consult. I saw that you are offering a modified project search command here. Maybe some things should be exposed better on the Consult side to reduce the amount of code needed here? You are setting the consult-project-root-function; you should already get a project search which works out of the box. But maybe not as full featured as what you are implementing here?

@loafofpiecrust @jethrokuan I am looking forward to seeing the Selectrum/Consult/Embark suite of packages in Doom. Please let me know if you need anything on the side of Consult. I saw that you are offering a modified project search command here. Maybe some things should be exposed better on the Consult side to reduce the amount of code needed here? You are setting the consult-project-root-function; you should already get a project search which works out of the box. But maybe not as full featured as what you are implementing here?

fwiw my usage of the selectrum/consult/embark suite has been very minimal, and I'm likely to have gotten many things wrong here. Perhaps someone with more experience can provide a better PR.

fwiw my usage of the selectrum/consult/embark suite has been very minimal, and I'm likely to have gotten many things wrong here. Perhaps someone with more experience can provide a better PR.

I've been using Selectrum, Orderless, Consult, and Embark for the last couple of weeks, and I'm loving it. I've found a few useful snippets in this pull request and in various repos that I thought I'd share: https://gist.github.com/jcf/ac6f57a5b0c49263619e4d2ee4a0c00a
I see Jethro mentioned someone with more experience might want to take the reigns on this pull request. While I'm not sure that's me I'd be happy to help test out any changes, and will keep sharing any useful code I add to my own configuration.

I've been using Selectrum, Orderless, Consult, and Embark for the last couple of weeks, and I'm loving it. I've found a few useful snippets in this pull request and in various repos that I thought I'd share: https://gist.github.com/jcf/ac6f57a5b0c49263619e4d2ee4a0c00a
I see Jethro mentioned someone with more experience might want to take the reigns on this pull request. While I'm not sure that's me I'd be happy to help test out any changes, and will keep sharing any useful code I add to my own configuration.

Do make another pull request, I started this because I was surprised to see that none has been made yet. My time is tied working on org-roam.

Do make another pull request, I started this because I was surprised to see that none has been made yet. My time is tied working on org-roam.

@Townk I think it sounds like you might be the best to take over, and then people and PR to your branch. Do you have a link to your personal config btw?

@Townk I think it sounds like you might be the best to take over, and then people and PR to your branch. Do you have a link to your personal config btw?

@Townk I think it sounds like you might be the best to take over, and then people and PR to your branch. Do you have a link to your personal config btw?

I'm working on a refactor for my config after my 1000th bankruptcy :P, but you can follow along here: https://github.com/Townk/doom-emacs-private
I'm trying a literate config this time. Let's see if I can finish.
Regarding the PR, let me work a bit on it today and see where I can get with it. Most likely I will need two PRs in order to get Selectrum fully working, and I won't push anything until later tonight or tomorrow morning (my 2 and 4 yo kids usually get in the way of such things).

@Townk I think it sounds like you might be the best to take over, and then people and PR to your branch. Do you have a link to your personal config btw?

I'm working on a refactor for my config after my 1000th bankruptcy :P, but you can follow along here: https://github.com/Townk/doom-emacs-private
I'm trying a literate config this time. Let's see if I can finish.
Regarding the PR, let me work a bit on it today and see where I can get with it. Most likely I will need two PRs in order to get Selectrum fully working, and I won't push anything until later tonight or tomorrow morning (my 2 and 4 yo kids usually get in the way of such things).

Most likely I will need two PRs in order to get Selectrum fully working ...

So @Emiller88 opened up a new PR for selectrum in #4664.
But we need another for the workspace module, to replace persp-mode with perspective?

@bdarcus Regarding Selectrum and Persp-Mode, I wonder why there is a problem. Selectrum is not doing anything out of the ordinary, relying on nothing else than the minibuffer. Did you open an issue on the perp-mode repository or the Selectrum repository?

@bdarcus Regarding Selectrum and Persp-Mode, I wonder why there is a problem. Selectrum is not doing anything out of the ordinary, relying on nothing else but the minibuffer. Did you open an issue on the perp-mode repository or the Selectrum repository?

No; I'm not familiar with the details. Was just summarizing the status, based on what @townk concluded. Perhaps he could submit a bug report?
I did find that the current code project search functionality doesn't work correctly though. Maybe that has something to do with it?

Closing in favour of #4664


Add feature to import/export keys as raw byte array

Excellent, thank you! 😄

Now available in v1.1.1!


Support Modules

Modules allow you to better structure code.
You could include a weather module in your graphcool.yaml file like this:
modules:
  weatherModule: "modules/weather/weather.yaml"

Modules have the same features as normal Graphcool projects with the one limitation that they can not reference other modules. Functions, permissions, rootTokens and types in a module are merged into your project and are not name-spaced. If there are conflicts you won't be able to deploy your project.

We'll collect example modules here: https://github.com/graphcool/modules. Modules shall increase reusability and structure in your code base.


777 fix missing headers

See https://github.com/awspring/spring-cloud-aws/pull/778

@maciejwalkowiak feel free to review and merge when you have the time. Thanks!


Auto build Windows binaries

The wallet builds succesfully on Windows, but Travis isn't set up to build them. We should switch to Azure like the grin projects and add auto building of Windows binaries

Latest beta release for v2.0.0 now includes binaries for windows


Possible to remotely jit a method?

I'm currently using this library to lookup a memory address of a method in a running program. I've noticed that if the method has not been jitted yet the memory address returned will be 0xFFFFFFFFFFFFFFFF and the ILOffsetMap is empty. In this case I would like to remotely jit the method and get the new/correct memory address. How can I do this? Is there way or do I have to re-run the address lookup all the time until the method is jitted?

Sorry for the delay in responding.
ClrMD cannot do this itself.  ClrMD is meant to be a passive "inspection" API and will not modify memory in the target process, which would be required to JIT a method.
I believe the CLR profiling API and ICorDebug have ways to force a method to be JIT'ed but this isn't something I know how to do off the top of my head, but you might be able to ask the folks in the CLR diagnostics repo, but it will be invasive.

As far as the profiler API is concerned there's also https://github.com/microsoft/CLRInstrumentationEngine


Video tutorials for Add  in local.properties

Where to find local.properties, to change client id and secret.
If possible put video tutorials or instruction to find local properties.
Also if #73 is implemented, it is more easy as we don't need build apk, as myself also not familiar with apk build from given source code.

Video tutorial won't be possible, please refer to this answer on StackOverflow


Differentiate between statements and expressions

We now make a distinction between statements and expression.
We apply the following conventions:

Statements are assumed to have no return value. This means that the "return" channel is always "ignored".
Expressions have a default of "None". We do some stuff to ensure this also works in languages with "void" returns, such as Java, C# and C.

Fixes #372 and #400. Previous attempt at #374.
Most existing usages should be caught by the backwards compatibility (if you have an expected return value with a statement, the statement is treated as an expression instead). However, some uses might now change, but we'll fix those test suites as they occur.

FYI: Concerning the use case where return values from expressions without a return attribute were previously "ignored" that would now fail if something other than "nothing" is returned. I consider this a good thing, as I think this was unwanted behavior in TESTed.


Contrast between copy and bg is low for danger Alert variant.

For consideration:

And from Material.

Re-opening this. I honestly feel that the alert message should be stronger than its background. In the event that the app suffered a session-ending failure, I feel that the message should be bold, not subdued.
Going forward, it might also be beneficial to issue a formal response when an issue is closed, to indicate that it was acknowledged, and also provide a justification for why it was disregarded.

@JCarmine why reopened?

@JCarmine weird, i just saw your explanation of why you reopened in my email, but wonder why it wasn't posted here. Going to blockquote it here:

Re-opening this. I honestly feel that the alert message should be stronger than its background. In the event that the app suffered a session-ending failure, I feel that the message should be bold, not subdued.
Going forward, it might also be beneficial to issue a formal response when an issue is closed, to indicate that it was acknowledged, and also provide a justification for why it was disregarded.

Anyways, the referenced PR #266 actually updated the tokens for the Alert to lighten the background, thus increasing the contrast up to WCAG AAA spec. Sorry, I didn't communicate that when closing. You can see that the danger Alert in the screenshot below is now more readable than what's in the original issue post.
If something needs to bold, like a failure, then use the title prop.
https://ux.palmetto.com/?path=/story/components-alert--with-icon

I'm going to close this again because I believe your concerns have been addressed.


ansible_mitogen: Support templated become_user

refs #1083

This is my work in progress for handling become plugin options
    # Better to use ActionBase.get_become_option? Probably not, as long as
    # ansible_mitogen.connection.Connection.reset() assigns a half lobotomised
    # self._action
    def _become_option(self, name):
        plugin = self._connection.become
        if plugin is not None:
            return plugin.get_option(
                name, hostvars=self._task_vars, playcontext=self._play_context,
            )
        else:
            # FIXME BecomeBase.get_option() only does this for become_user,
            #       become_pass, become_flags, & become_exe.
            LOG.warning(
                '%r: Used play_context fallback for option %r', self, name,
            )
            return getattr(self._play_context, name)

The FIXME is part of why it's still WIP, the other is that I haven't worked out how to test it yet.

This is my work in progress for handling become plugin options
[...]
The FIXME is part of why it's still WIP, the other is that I haven't worked out how to test it yet.

Should I close this PR? I feel like it`s not the best idea to leave this PR if you are already working on that topic.
Maybe it would be better to help you with testing?

Lets leave it open, in draft. It's as agood a place as any to collect notes, intermiediate test results and generally collaborate.
Have you manually tested your code change? Is it working for your playbook(s)?

Notes:

Ansible PR https://github.com/ansible/ansible/pull/62373

moved common become* parameters to become options
created ansible.plugins.become.BecomeBase.get_option() containing a limited getattr(play_context, ...) fallback
is present in all ansible-core >= 2.10

ansible-core become plugins subclass BecomeBase. This may be a requirement of all Ansible become plugins.
ansible_mitogen.plugins.connection.mitogen_sudo subclasses ConnectionBase, not BecomeBase.
ansible_mitogen is entirely unaware of become plugins. Existing become support relies on legacy Ansible < 2.10 fallbacks.
ansible_mitogen.transport_config.PlayContextSpec._connect_option() will silently return non-connection options such as become_user, due to the unrestricted getattr(play_context, ...) fallback.

Noticed several commented out tests related to become_user and become_pasword while looking at this. Probably not critical path for this feature, but I want to take a look soon. Refs #658, #692
$ ag https://github.com/dw/mitogen/issues/692 -A1
ag https://github.com/dw/mitogen/issues/692 -A1
tests/ansible/integration/playbook_semantics/with_items.yml
8:    # TODO: https://github.com/dw/mitogen/issues/692
9-    # - name: Spin up a few interpreters

tests/ansible/integration/action/make_tmp_path.yml
145:    # TODO: https://github.com/dw/mitogen/issues/692
146-    # - name: "Try writing to temp directory for the readonly_homedir user"

tests/ansible/integration/action/synchronize.yml
43:    # TODO: https://github.com/dw/mitogen/issues/692
44-    # - file:
--
73:    # TODO: https://github.com/dw/mitogen/issues/692
74-    # - file:

tests/ansible/integration/become/sudo_password.yml
62:    # TODO: https://github.com/dw/mitogen/issues/692
63-    # - name: Ensure password sudo succeeds.

tests/ansible/integration/become/sudo_requiretty.yml
8:    # TODO: https://github.com/dw/mitogen/issues/692
9-    # - name: Verify we can login to a non-passworded requiretty account
--
22:    # TODO: https://github.com/dw/mitogen/issues/692
23-    # - name: Verify we can login to a passworded requiretty account

@mordekasg I've updated the branch with what I think is the correct combination to get templated become_user working, plus tests to cover it. Could you try it and let me know if it works for you?. Comments, questions and code reviews welcomed.
I also added you to the list of contributers. If you'd prefer not to be listed or to change the entry, then please let me know.

Lets leave it open, in draft. It's as agood a place as any to collect notes, intermiediate test results and generally collaborate.
Have you manually tested your code change? Is it working for your playbook(s)?

I tested my change then and now - you were right, it`s not working or working randomly.

@mordekasg I've updated the branch with what I think is the correct combination to get templated become_user working, plus tests to cover it. Could you try it and let me know if it works for you?. Comments, questions and code reviews welcomed.

Thank you! Will try to do it today.

Tested - everything is working flawlessly.
I have also done some runs on my infrastructure and nothing crashed.

Tested - everything is working flawlessly.
I have also done some runs on my infrastructure and nothing crashed - LGTM.

thank you, great news.


Getting "Exception in plugin DDEV Integration"

Is there an existing issue for this?

[X] I have searched the existing issues

Are you sure that this bug is related to this DDEV Integration Plugin?

[X] I am sure

Enter your error report ID (If available)
ff1e6a9a6030468795068270ce2a80c8
Describe the bug
de.php_perfect.intellij.ddev.cmd.CommandFailedException: Failed to execute /usr/local/bin/ddev version --json-output
	at de.php_perfect.intellij.ddev.cmd.DdevImpl.execute(DdevImpl.java:42)
	at de.php_perfect.intellij.ddev.cmd.DdevImpl.version(DdevImpl.java:18)
	at de.php_perfect.intellij.ddev.state.DdevStateManagerImpl.checkVersion(DdevStateManagerImpl.java:137)
	at de.php_perfect.intellij.ddev.state.DdevStateManagerImpl.lambda$initialize$0(DdevStateManagerImpl.java:52)
	at de.php_perfect.intellij.ddev.state.DdevStateManagerImpl.checkChanged(DdevStateManagerImpl.java:90)
	at de.php_perfect.intellij.ddev.state.DdevStateManagerImpl.initialize(DdevStateManagerImpl.java:49)
	at de.php_perfect.intellij.ddev.state.DdevStateManagerImpl.initialize(DdevStateManagerImpl.java:33)
	at de.php_perfect.intellij.ddev.InitPluginActivity.lambda$runActivity$0(InitPluginActivity.java:14)
	at com.intellij.openapi.application.impl.ApplicationImpl$1.run(ApplicationImpl.java:246)
	at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:539)
	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
	at java.base/java.util.concurrent.Executors$PrivilegedThreadFactory$1$1.run(Executors.java:702)
	at java.base/java.util.concurrent.Executors$PrivilegedThreadFactory$1$1.run(Executors.java:699)
	at java.base/java.security.AccessController.doPrivileged(AccessController.java:399)
	at java.base/java.util.concurrent.Executors$PrivilegedThreadFactory$1.run(Executors.java:699)
	at java.base/java.lang.Thread.run(Thread.java:833)
Caused by: com.intellij.execution.process.ProcessNotCreatedException: Cannot run program "/usr/local/bin/ddev" (in directory "/home/rishi/Sites/RFS/jpal"): error=2, No such file or directory
	at com.intellij.execution.configurations.GeneralCommandLine.createProcess(GeneralCommandLine.java:359)
	at com.intellij.execution.process.OSProcessHandler.startProcess(OSProcessHandler.java:84)
	at com.intellij.execution.process.OSProcessHandler.<init>(OSProcessHandler.java:44)
	at com.intellij.execution.process.CapturingProcessHandler.<init>(CapturingProcessHandler.java:20)
	at de.php_perfect.intellij.ddev.cmd.ProcessExecutorImpl.executeCommandLine(ProcessExecutorImpl.java:16)
	at de.php_perfect.intellij.ddev.cmd.DdevImpl.execute(DdevImpl.java:30)
	... 17 more
Caused by: java.io.IOException: Cannot run program "/usr/local/bin/ddev" (in directory "/home/rishi/Sites/RFS/jpal"): error=2, No such file or directory
	at java.base/java.lang.ProcessBuilder.start(ProcessBuilder.java:1143)
	at java.base/java.lang.ProcessBuilder.start(ProcessBuilder.java:1073)
	at com.intellij.execution.configurations.GeneralCommandLine.startProcess(GeneralCommandLine.java:435)
	at com.intellij.execution.configurations.GeneralCommandLine.createProcess(GeneralCommandLine.java:349)
	... 22 more
Caused by: java.io.IOException: error=2, No such file or directory
	at java.base/java.lang.ProcessImpl.forkAndExec(Native Method)
	at java.base/java.lang.ProcessImpl.<init>(ProcessImpl.java:314)
	at java.base/java.lang.ProcessImpl.start(ProcessImpl.java:244)
	at java.base/java.lang.ProcessBuilder.start(ProcessBuilder.java:1110)
	... 25 more

Steps to reproduce

Open PHPStorm as usual
DDEV 1.0.4 is installed
ddev version provides the following info:

 ITEM             VALUE
 DDEV version     v1.21.5-alpha1
 architecture     amd64
 db               drud/ddev-dbserver-mariadb-10.4:v1.21.4
 dba              phpmyadmin:5
 ddev-ssh-agent   drud/ddev-ssh-agent:v1.21.4
 docker           23.0.1
 docker-compose   v2.15.1
 docker-platform  ThinkPad-E14-Gen-2
 mutagen          0.16.0
 os               linux
 router           drud/ddev-router:v1.21.4
 web              drud/ddev-webserver:20230207_fix_nvm

Additional context
No response

Thank you for reporting this with all the details @RishiKulshreshtha!
The error basically says there is no ddev binary installed. But this should already be checked before the ddev version command is run (No Exception should happen):
Caused by: com.intellij.execution.process.ProcessNotCreatedException: Cannot run program "/usr/local/bin/ddev" (in directory "/home/rishi/Sites/RFS/jpal"): error=2, No such file or directory

Could you please confirm this is the place where ddev is installed and tell if this error consists or if it occurs from time to time?

@nico-loeber, it appears that ddev is installed in the /usr/bin/ddev directory.

@nico-loeber, it appears that ddev is installed in the /usr/bin/ddev directory.

Thank you for asking me that question, as that made me realize that this is not a ddev-intellij-plugin issue, but rather a config change that I should have done here.

@RishiKulshreshtha the plugin automatically finds DDEV if you don't override its behavior by configuring that. I'm pretty sure you just wanted it empty.

@rfay, you are correct. The plugin was able to detect ddev in my $PATH automatically.

I believe the confusion arose due to a recent upgrade that I performed on ddev. Previously, it was installed using the installation script, but I later switched to the recommended method outlined in the documentation (https://ddev.readthedocs.io/en/latest/users/install/ddev-installation/#debianubuntu).
I don't recall configuring the "DDEV Integration" path in PHPStorm. It's possible that /usr/local/bin/ddev was saved earlier, but after the upgrade, the "DDEV Integration" path in PHPStorm remained set to /usr/local/bin/ddev instead of the new and correct path /usr/bin/ddev. Please let me know if my understanding is correct.


Removing saturating_add_assign and replacing with Saturating struct

Problem
Cleaning up all usages of saturating add assign and replacing with Saturating
https://github.com/anza-xyz/agave/issues/502
Summary of Changes
Fixes #

The CI has been failing in a check: https://buildkite.com/anza/agave/builds/15596#0193af2b-68f5-4b10-84d9-f316e42f9886
Would you mind fixing that?

Clippy failure as well. Will grab that, and run locally from now on.

In the future, the following are good command to run from the base of the repo:
$ ./cargo nightly fmt
$ ./cargo nightly clippy
$ cargo test --no-run

The first two will keep the linters happy, the last one will ensure all test code can be compiled oto

Clippy nightly has a bunch of errors right now that seem unrelated. Is there a set of rules that should be ignored?
For example:
warning: the following explicit lifetimes could be elided: 'a
--> core/src/repair/repair_generic_traversal.rs:25:6
|
25 | impl<'a> Iterator for GenericTraversal<'a> {
|      ^^                                ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
|
25 - impl<'a> Iterator for GenericTraversal<'a> {
25 + impl Iterator for GenericTraversal<'_> {

Clippy nightly has a bunch of errors right now that seem unrelated. Is there a set of rules that should be ignored? For example: warning: the following explicit lifetimes could be elided: 'a --> core/src/repair/repair_generic_traversal.rs:25:6 | 25 | impl<'a> Iterator for GenericTraversal<'a> { | ^^ ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 25 - impl<'a> Iterator for GenericTraversal<'a> { 25 + impl Iterator for GenericTraversal<'_> {

Are you sure you're using the correct nightly version ? If you use the one specified by ./cargo nightly, then that should build with what we build with. For the specific failure you hit this time, you need to rebase to tip of master to pick up https://github.com/anza-xyz/agave/pull/4023:
error: this function has too many arguments (10/9)
--
  | --> accounts-cluster-bench/src/main.rs:749:1
  | \|
  | 749 \| / fn make_rpc_bench_threads(
  | 750 \| \|     rpc_benches: Vec<RpcBench>,
  | 751 \| \|     mint: &Option<Pubkey>,
  | 752 \| \|     start_bench_barrier: &Arc<Barrier>,
  | ...   \|
  | 759 \| \|     transaction_signature_tracker: &TransactionSignatureTracker,
  | 760 \| \| ) -> Vec<JoinHandle<()>> {

Thanks, I see the issue. I was using cargo +nightly, rather than ./cargo nightly

Thanks, sorry about that. It was a requirement where I previously worked.
Will take a look at the coverage build failures.


DRep directory - Drep list - Load more button not shown after 10 items

Issue in feature https://github.com/IntersectMBO/govtool/issues/220
NOT OK Show more - NOT SHOWN AFTER TEN ITEMS

Design:

blocked by issue 756

OK NOW

@l-br1 Are you assigning this for me to test? This should be assigned to a tester, as they should do regression testing on all fixed bugs. @MSzalowski can you please verify the workflow for fixed bugs?

"Show more" button works 17 May

@MSzalowski can you please verify the workflow for fixed bugs?

Yes, you should verify only what is delivered on staging which at this stage should be tested by QA

Adding this to list of automated tests. Assigned to @NabinKawan

This is covered as
2O. Should load more DReps on show more


Automatic reload / clone of imported repos on the content change

Hey, does the plugin detect changes in imported repos?
Can we force it to clone the specific branch of the specific repo every fixed time or do we have to reload it manually?
If done manually, what is the proposed way of doing that?

Currently, every time you call mkdocs serve or mkdocs build the plugin clones the files from the remote. Are you asking about doing like a periodic check to every to see if pages have changed over the course of running mkdocs serve locally?
In production you could setup a CI workflow that triggers the importers workflow. The imported repo's workflow can run anytime a documentation file changes.
Are you wanting something like livereload?

Currently, I have a container starting with mkdocs serve, and see no option to re-serve it again, and mkdocs build executes in another process if I try it, so there are no changes in the temp_dir inside.
The only thing I can think of is restarting the container from within the CI every time one of the sub-repos is being updated, but I don't want to redeploy the whole main documentation.
I already start the container with --livereload. The thing that I miss is an option to detect changes on the branch and re-clone the repo after merging a PR.

Oh, actually it imports the repos whenever I execute mkdocs serve and build. But it changes only .md files, not .html ones. So that's why I always see the old version 🤔

The --dirtyreload flag helped with rebuilding the .html files to the latest version, but mkdocs still hasn't detected these changes and shows me the old version.
Can it be connected with the plugin's parameters? I have:
  - multirepo:
      cleanup: false
      keep_docs_dir: false

The container is based on squidfunk/mkdocs-material image.

As I didn't find any way to dynamically re-import subrepos, I simply redeploy the container whenever one of my subrepos' main branch is changed.


Finish live recording

DO NOT REMOVE OR SKIP THE ISSUE TEMPLATE

[X] I understand that I will be blocked if I intentionally remove or skip any mandatory* field

Checklist

[X] I'm asking a question and not reporting a bug or requesting a feature
[X] I've looked through the README
[X] I've verified that I'm running yt-dlp version 2023.07.06 (update instructions) or later (specify commit)
[X] I've searched known issues and the bugtracker for similar questions including closed ones. DO NOT post duplicates
[X] I've read the guidelines for opening an issue

Please make sure the question is worded well enough to be understood
How can I create a video file from currently running stream temp file?
Sometimes I want to get a video from currently running stream asap, but I am unable and need to wait until it ends? Or there is a way?
Provide verbose output that clearly demonstrates the problem

[ ] Run your yt-dlp command with -vU flag added (yt-dlp -vU <your command line>)
[ ] If using API, add 'verbose': True to YoutubeDL params instead
[ ] Copy the WHOLE output (starting with [debug] Command-line config) and insert it below

Complete Verbose Output
No response

I don't really understand your question. If you close yt-dlp during a download it will leave behind a temp file. Re-running the yt-dlp command will finish the download

I don't really understand your question. If you close yt-dlp during a download it will leave behind a temp file. Re-running the yt-dlp command will finish the download

I mean if I decide that I need video footage asap, while stream still running, can I force yt-dlp to finalize recording with existing footage and provide me a video without me waiting until the stream ends? There is very long 6-12 hour streams out there and I  have this need pretty often.

pressing ctrl+c once should do it (do not press ctrl+c twice, even if it looks like nothing is happening)

Can I somehow do this and also continue recording so it uncut in the end?

O  non-WIN32 environment, you can play or copy any temp file.

@LivreAcessoPro Under some situations, the partial file may not be valid video, hence my use of "most of the time"


Annoying debug messages: upgrading piaf and dependencies

This PR is a draft because I need feedback regarding Nix.
Problem
In his logging PR, @anchpop had to remove annoying debug messages from Piaf, and pin a specific commit of Piaf. His PR got accepted into Piaf so he removed the pin, but we didn't change the version we're using, and the debug messages are back.
Unfortunately, latest versions of Piaf use several dependencies that are not published, so the resulting esy file is a bit of a mess. Also I'm not sure about the state of affairs for Nix, can someone please take a look?
In the long run we should probably stop using Piaf.
(Sidenote: I should have tested logging one last time before merging and I'm sorry I didn't.)
Solution

Update Piaf
Pin specific versions of ocaml-sendfile and gluten that are all required by Piaf

You can just do nix flake update and you should get the correct version

@ulrikstrid after doing nix flake update, running nix develop gives me this:
error: 'init' at /nix/store/2s98acvj4g2ijm8wy6dq8la8cwh08nyi-source/src/lib.nix:63:10 called with unexpected argument 'systems'

       at /nix/store/yhmw3h3ha9syzax3q9nnf2v8177ky150-source/flake.nix:51:23:

           50|
           51|       dream2nix-lib = dream2nix.lib2.init {
             |                       ^
           52|         systems = supportedSystems;
(use '--show-trace' to show detailed location information)

🤷

diff --git a/flake.nix b/flake.nix
index 67eb6d69..51df8d00 100644
--- a/flake.nix
+++ b/flake.nix
@@ -47,19 +47,9 @@
     , prometheus-web, tezos, json-logs-reporter }:
     let
       supportedSystems = [ "x86_64-linux" "aarch64-linux" "aarch64-darwin" ];
-
-      dream2nix-lib = dream2nix.lib2.init {
-        systems = supportedSystems;
-        config.projectRoot = ./.;
-      };
     in with flake-utils.lib;
     eachSystem supportedSystems (system:
       let
-        nodejs = pkgs.nodejs-16_x;
-
-        ligo = (import nixpkgs { inherit system; }).ligo.overrideAttrs
-          (_: { meta = { platforms = pkgs.ocaml.meta.platforms; }; });
-
         pkgs = (ocaml-overlays.makePkgs { inherit system; }).appendOverlays [
           (import ./nix/overlay.nix)
           prometheus-web.overlays.default
@@ -69,6 +59,15 @@

         pkgs_static = pkgs.pkgsCross.musl64;

+        dream2nix-lib = dream2nix.lib.init {
+          inherit pkgs;
+          config.projectRoot = ./.;
+        };
+        nodejs = pkgs.nodejs-16_x;
+
+        ligo = (import nixpkgs { inherit system; }).ligo.overrideAttrs
+          (_: { meta = { platforms = pkgs.ocaml.meta.platforms; }; });
+
         npmPackages = import ./nix/npm.nix {
           inherit system dream2nix-lib nix-filter nodejs;
         };
diff --git a/nix/npm.nix b/nix/npm.nix
index 2d9e89d0..2a430720 100644
--- a/nix/npm.nix
+++ b/nix/npm.nix
@@ -1,7 +1,7 @@
 { system, dream2nix-lib, nix-filter, nodejs }:

 let
-  outputs = (dream2nix-lib.makeFlakeOutputs {
+  outputs = (dream2nix-lib.makeOutputs {
     source = nix-filter.lib.filter {
       root = ../.;
       include = [ ../package-lock.json ../package.json ];
@@ -18,7 +18,7 @@ let
     settings =
       [{ subsystemInfo.nodejs = (builtins.substring 0 2 nodejs.version); }];
   });
-  npmPackages = outputs.packages."${system}".sidechain;
+  npmPackages = outputs.packages.sidechain;

   node_modules' = builtins.attrValues
     (builtins.removeAttrs npmPackages.dependencies [ "webpack" ]);


Exception while invoking method 'increasePostViews' Error: Match error: Expected string, got object

After upgrade to 0.22.2, it appears that I am getting this error in the logs.

Should be fixed, hopefully.

Is this fix going to master branch?

This didn't fix it for me. On the site I see:

@cloudunicorn I am not sure your issue is related to mine. You are seeing an iron router error, my error was from a DDP call failing behind the scenes.

hm, my logs say: Exception while invoking method 'increasePostViews' Error: Match error: Expected string, got object

My app works fine on local, but shows that error live on the site / digital ocean.

hm, new error now, i'll stop hijacking this.
Error: Meteor code must always run within a Fiber. Try wrapping callbacks that you pass to non-Meteor libraries with Meteor.bindEnvironment.

I don't think the fix worked as I am also getting this error with the latest Telescope Devel and latest Zeiss.  Full error code:
I20150813-07:32:09.226(-6)? Exception while invoking method 'increasePostViews' Error: Match error: Expected string, got object I20150813-07:32:09.226(-6)?     at checkSubtree (packages/check/match.js:159:1) I20150813-07:32:09.227(-6)?     at check (packages/check/match.js:32:1) I20150813-07:32:09.227(-6)?     at [object Object].Meteor.methods.increasePostViews (packages/telescope:posts/lib/methods.js:283:1) I20150813-07:32:09.227(-6)?     at [object Object].methodMap.(anonymous function) (packages/meteorhacks:kadira/lib/hijack/wrap_session.js:161:1) I20150813-07:32:09.227(-6)?     at maybeAuditArgumentChecks (packages/ddp/livedata_server.js:1617:1) I20150813-07:32:09.227(-6)?     at packages/ddp/livedata_server.js:648:1 I20150813-07:32:09.227(-6)?     at [object Object]._.extend.withValue (packages/meteor/dynamics_nodejs.js:56:1) I20150813-07:32:09.227(-6)?     at packages/ddp/livedata_server.js:647:1 I20150813-07:32:09.227(-6)?     at [object Object]._.extend.withValue (packages/meteor/dynamics_nodejs.js:56:1) I20150813-07:32:09.227(-6)?     at [object Object]._.extend.protocol_handlers.method (packages/ddp/livedata_server.js:646:1) I20150813-07:32:09.227(-6)? Sanitized and reported to the client as: Match failed [400] I20150813-07:32:09.227(-6)?

@cloudunicorn yeah the error discussed here and the Fiber thing don't actually crash your app or have any effect on the site, so your issue must be different.
@milezteg the code should now match anything, so it's weird that you're still getting an error. Are you 100% sure you're running the latest devel?
https://github.com/TelescopeJS/Telescope/commit/65efb6180cac6688f66278a976e4852ab47acf1f

Are you 100% sure you're running the latest devel?

Doh!  Missed that last commit.  Error is gone and increasePostViews working as expected.
Thanks Sacha =)


Pod install doesn't work

dyld: lazy symbol binding failed: Symbol not found: _rb_str_new_static
  Referenced from: /Users/andreasheiberg/.rvm/gems/ruby-2.2.1/gems/json-1.8.3/lib/json/ext/parser.bundle
  Expected in: flat namespace

dyld: Symbol not found: _rb_str_new_static
  Referenced from: /Users/andreasheiberg/.rvm/gems/ruby-2.2.1/gems/json-1.8.3/lib/json/ext/parser.bundle
  Expected in: flat namespace

I have exactly the same issue, anyone now how to fix it ?

Doing rvm reload. Then gem uninstall sqlite3 and gem install sqlite3 worked for me ...
(see http://stackoverflow.com/questions/16400588/rails-s-dyld-lazy-symbol-binding-failed-symbol-not-found-rb-intern2)


Switch from jest to vitest

Even if we are not bundling with vite yet, we can use vitest in place of Jest which brings a few benefits like not requiring to use NODE_OPTIONS to run and having sane module resolution.
It's possible to also use jest-extended with vitest, but I opted to not do so for now because it brings heavyweight dependencies and it was trivial to just rewrite the affected matchers to be compatible.
This PR also removes 153 JS dependencies, which is certainly nice.

This PR also removes 153 JS dependencies, which is certainly nice.

npm install:
https://img-9gag-fun.9cache.com/photo/aQEpZB7_460svvp9.webm

This PR also removes 153 JS dependencies, which is certainly nice.

npm install: https://img-9gag-fun.9cache.com/photo/aQEpZB7_460svvp9.webm

threads option is enabled again. It makes local tests a second slower but provides isolation between tests and it should overall become faster with increased number of tests.


Backport: "common: serialise host restart #995"

backport of #995

I must have messed up the merge conflicts in<PHONE_NUMBER>b8b8b1ae08e04973213328771a6494
Let me try it again.

It seems like this might need https://github.com/ceph/ceph-ansible/pull/1243 to be backported first

jenkins test ansible2.2-purge_cluster

jenkins test ansible2.2-xenial_cluster


Include query in fetchData

Coverage remained the same at 97.5% when pulling db671bdd0aeedaafbaa1ce766353c1aa5222fd27 on tupy:patch-1 into 584e52b72ac1b490c2ffff7220563e4838c1a417 on pheuter:master.

Hm, what would be an example of when one would use state.query to fetch data over state.params?

For instance, a feed of documents that it's possible to filter/sort using a query param:
/feed/new-feed-1?filter=tag1&sort=date
The react-router receive these params and fetchData() should send them to load the correct data.


Add support for client command

Adding support for the client command so that any clients which set their client name will not fail with an unsupported operation exception.
After creating this PR I noticed #75 addresses this same issue. However, it seems in that PR the client name is sent back in the response, this is not the expected behaviour according to what I saw while debugging a session with a real Redis instance, Redis simply replied OK.

Hi, thanks for your contribution and sorry for the long wait!
I was not able to push changes to your branch, so I commited your changes in a separate PR. Your commits are in the main branch now, I'm closing this PR


Filter entities when searching to update links

Steps to replicate:

Create a submission with the ff metadata :

donor
process 1 linked to donor and specimen
collection protocol linked to process 1
specimen
process 2 linked to specimen and cell suspension
dissociation protocol linked to process 2
cell suspension
lib prep protocol linked to process 3
seq protocol linked to process 3
process 3   linking cell suspension and sequencing files
2 sequencing files

In the UI, go to the submission page, go to Processes tab and expand the row for a process.

Search protocols/files/biomaterials

Actual Behavior:
The dropdown displays all protocols/biomaterials/files in Ingest and not just the entities in the current project/submission
Expected Behavior:
The search result is used to be filtered to only display entities from the same submission.
Notes:
Look into filtering the entities to only display those entities from the same project

This is a bug to User story: Update links prior to hitting submit
Test plan: https://docs.google.com/spreadsheets/d/1sf_PnPRufEPUeqkADhewJGJsYsb00CBwymKKPFB_VHI/edit#gid=0

This was fixed as part of the work on ebi-ait/dcp-ingest-central#673


Prevent loading views if view class not in container

If views are disabled in application an error is encountered:
In Container.php line 767:

  Class view does not exist

This pull requires will prevent loading views in IdeHelperServiceProvider if there is no view binding in application container.

I think the view is required, what is your use-case to have it not enabled?

I disable ViewServiceProvider in some of my projects. For example, in my bot application it is disabled (as it is not needed): https://github.com/fondbot/fondbot/blob/master/config/app.php#L154

Yeah but this package actually needs it. So perhaps it should register/boot it instead then.

@barryvdh If the application only api then this change is necessary


Improve Collision Detection with spatial partitioning

World Collision is already utilizing spatial hash maps but body/body collisions check against every other body which scales extremely badly. Implement some form of spatial partitioning (grid, octree eg)

improved terrain collision by using octree queries for potential colliding triangles, octree is generated during level export from blender.
Still missing: dynamic spatial acceleration structure for object-object collisions


Using packages from cilium-cli as a vendored lib to install cilium programmatically inside an environment

Proposal / RFE
Recently I was experimenting with kind inside a golang project to programmatically spin up a k8s cluster. The support for kind via go is pretty good but taking it to the next was to install cilium in the env for which I found that I have 2 options:

run helm and deploy the cilium chart
run cilium-cli and have this install + configure cilium inside my kind cluster

Both of the options work well but you need to have the helm binary, helm chart locally or the cilium-cli binary. Did you folks consider exposing the internals of the cilium-cli for other consumers to vendor in their code and use? I was chatting with @michi-covalent  about this and would be pretty nifty to have access to https://github.com/cilium/cilium-cli/blob/0af00d450144f2c656394f5d6391657050937825/install/install.go#L293-L305. Right now I cannot vendor this because it's included in the internal package which golang forbids:
could not import github.com/cilium/cilium-cli/internal/k8s (invalid use of internal package github.com/cilium/cilium-cli/internal/k8s)

@tklauser mentioned there is also https://github.com/cilium/cilium-cli/issues/618 which seems related.

Yep -- that is exactly what I'm looking for. @michi-covalent feel free to close this and consolidate in the other one if you think that is right.

i'll take a stab at this


Add GNUInstallDirs + fixes for the pkg-config file

This PR has two semi-related commits.
The first one implements GNUInstallDirs like other projects in the KhronosGroup (i.e. Vulkan-ValidationLayers).
Reference: https://cmake.org/cmake/help/latest/module/GNUInstallDirs.html
The second commit removes the hardcoded variables in the pkg-config file and installs it the correct directory. Since it is not an architecture independent pkg-config file it does not belong in /usr/share/, but rather the appropriate CMAKE_INSTALL_LIBDIR which is added in the previous commit. On Slackware this is /usr/lib64/ and /usr/lib/ on 64-bit and 32-bit installs respectively.
I took the liberty of removing SPIRV_CROSS_INSTALL_LIB_DIR and SPIRV_CROSS_INSTALL_INC_DIR since they are not used or needed after this PR.
Example pkg-config.in file: https://github.com/pkgconf/pkgconf/blob/c862e030cf83447f679e4f49876f5298f0fc9691/libpkgconf.pc.in

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Adding -m option to useradd

#323 #390
See also https://linux.die.net/man/8/useradd

Sorry for the noise, it's duplicate of https://github.com/docker-library/mongo/pull/463.


Fix K.rnn documentation on unroll parameter

Edit
Docs state the below, but unroll is a parameter used by both backends.

unroll: with TensorFlow the RNN is always unrolled, but with Theano you can use this boolean flag to unroll the RNN.

For theano backend we use scan but for tf we use while_loop, even through tf also supports scan. Also, does anyone know if using scan instead of while_loop has any performance or other benefits?
Cheers,
Ben
Please make sure that the boxes below are checked before you submit your issue. If your issue is an implementation question, please ask your question on StackOverflow or join the Keras Slack channel and ask there instead of filing a GitHub issue.
Thank you!

[x ] Check that you are up-to-date with the master branch of Keras. You can update with:
pip install git+git://github.com/fchollet/keras.git --upgrade --no-deps

[x ] If running on TensorFlow, check that you are up-to-date with the latest version. The installation instructions can be found here.

[x ] If running on Theano, check that you are up-to-date with the master branch of Theano. You can update with:
pip install git+git://github.com/Theano/Theano.git --upgrade --no-deps

[ x] Provide a link to a GitHub Gist of a Python script that can reproduce your issue (or just copy the script here if it is short).

I'm pretty sure theano can optimize a scan better than an unrolled RNN. What I don't know is if TF will have different performance between unrolled and scan.

That's, like, not true. Keras has supported dynamic TF RNNs for as long as
they have been available in TF.
On Jan 26, 2017 10:00, "Ben"<EMAIL_ADDRESS>wrote:

I'm pretty sure theano can optimize a scan better than an unrolled RNN.
What I don't know is if TF will have different performance between unrolled
and scan.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/fchollet/keras/issues/5191#issuecomment-275461815,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AArWb4mOF7GQRtaAIR2Wf9qmhkPDersyks5rWN8kgaJpZM4Lu8X8
.

@fchollet Then are the docs out of date or am I just misreading them?

unroll: with TensorFlow the RNN is always unrolled, but with Theano you can use this boolean flag to unroll the RNN.

@fchollet Thanks! I missed it because TF uses while_loop instead of a scan.
The docs make it sound like tensorflow K.rnn ignores unroll, which it doesn't.
Is there any advantage to control_flow_ops.while_loop over tf.scan?
So my two comments are:

Should update docs because unrolling is supported in both backends.
Determine if there is any performance difference with using scan over while_loop. No idea what works best.

Updated documentation in this PR:
https://github.com/fchollet/keras/pull/5192
As to the difference between while_loop and scan in tensorflow, anyone know if there is a performance difference or should I just try it and see?

@fchollet serves me right for reading the doc instead of just reading the code ;)

Another weird inconsistency:
Docs:

input_length: not relevant in the TensorFlow implementation. Must be specified if using unrolling with Theano.

Tensorflow implementation gets timesteps from the input shape and ignores the input_length parameter
time_steps = tf.shape(inputs)[0]

Theano implementation requires the input_length parameter.
    if unroll:
        if input_length is None:
            raise ValueError('When specifying `unroll=True`, '
                             'an `input_length` '
                             'must be provided to `rnn`.')

Would it be more consistent if both got the input shape the same way? The time_steps parameter could be used by both backends, or could be removed and both could get the shape from the input.

Closing the issue. Just a small PR for the documentation.https://github.com/fchollet/keras/pull/5192


Improves messages and removes unnecessary dependency of Laravel Installer

Improves messages and removes unnecessary dependency of Laravel Installer.
laravel new appname requires Laravel's installer and you can achieve the same result using composer create-project laravel/laravel appname --prefer-dist

Also I would recommend that you delete the sublime-workspace since it contains some personal info (see ```"file_history"````). Or atleast remove the parts that are not essential for this repo.

@jhuliano  Ok thanks about the sublime


Added Django 2 compatibility (without dropping < 1.11)

Replaces: #267 and #266

Thanks for doing this!

@jsocol you're welcome :) Happy New Year!


Output to file instead of folder

Since the output is a single CEF file, it would be better to just write that file directly (and not put it inside a run folder).

Ok so we provide just this output for now?

What else did you have in mind?

plots, correlation matrix, other formats? ...maybe is unnecessary though.
Ok I will make the change. How do I update it on github?

You need git. See http://rogerdudler.github.io/git-guide/
Then:
git clone https://github.com/linnarsson-lab/BackSPIN
Make changes locally on your laptop
git add
git commit -m "Made some changes"
git push

Might be a good idea to make a separate tool for visualizing a CEF file. Correlation matrix, barplots, histograms - then it could be used on any CEF i.e. one clustered by other methods.

Sure, with matplotlib is quite straightforward. Even interactive heat map like the one I am used to work with could be useful.


(j9.0.42) Exclude FollowReferences/VThreadStackRefTest

Related: https://github.com/eclipse-openj9/openj9/issues/18426
Port of https://github.com/adoptium/aqa-tests/pull/4937.

fyi @pshipton @llxia


Documentation issues certificates

Link to https://kubernetes.io/en-us/docs/tasks/administer-cluster/certificates/
The secondary list elements in the page are all "1." , they are not in order, it looks weird

/sig docs

/lgtm

Hi @sanqiuli, can you please elaborate which page are you talking about?

Hi @sanqiuli, can you please elaborate which page are you talking about?

Sorry, I forgot to check the link in my issue, the correct link is https://kubernetes.io/zh-cn/docs/tasks/administer-cluster/certificates/

/language zh
/triage accepted
/retitle [zh] Wrong list numbering in tasks/administer-cluster/certificates page
FYI:

en page: https://kubernetes.io/docs/tasks/administer-cluster/certificates/
en file: https://github.com/kubernetes/website/blob/main/content/en/docs/tasks/administer-cluster/certificates.md?plain=1

/assign

/assign

This PR:https://github.com/kubernetes/website/pull/34724 fixes this issue.


Playlists at Dashboard

Proposal:
Proposal written by Nickkel
What is the title of your proposal?: Playlists at Dashboard
Is it a suggestion for the website or for the bot?: Website
Explain your proposal more accurately (It's best to give as much information as possible, so that we can implement the proposal better): You should see all playlists on your server dashboard. Then you see all titles and if you click on them the bot plays it.
Why should we add this feature?: Nice
ReportID: 147

➤ LenoxBot commented:
Approve:
I think the bot can't start playing some songs when you click on it via dashboard. But perhaps you will be directed to the youtubevideo (if it exists)
Dadi#7808

➤ LenoxBot commented:
Approve:
agree with denario
Profxy#5396

➤ LenoxBot commented:
Approve:
good idea - I will add that you can add/remove songs on the dashboard
Denarioyt#3352

@Monkeyyy11 What exactly vars I receive and what content has?


Support Windows (desktop) ?

Support Windows (desktop) ?

same here waiting for macOs and windows Support

Hey,
I'd also like to see this plugin supporting desktops.
Maybe you can just state if you are going to do so or not?

Desktop support?

I really like the library, but I am also wondering if there will be support for desktop (windows + macOs). There is similar library for react native that has similar functionality and support for both windows and macOS, so it seems that it is somehow doable. I understand that it is not possible for web as iframe has a lot of limitations and strong isolation level.

same here waiting for macOs and windows Support

Me, too. :)

I also need the support of windows;

Windows support released @zhujintao ,You can close this

cool，
how can it be implement as platform view is not ready for windows;


Remove jenkins, admin-console and perf operator logic

Jenkins, admin-console, and perf operator are deprecated.
We need to remove all dependencies and related logic from the codebase operator.

Dependency removed.


[9.x] Allow chunkById on Arrays, as well as Models

This PR allows chunkById with PDO_ASSOC results from the Builder.
I believe this is a very niche scenario, and understand a rejection on this PR. On projects I've previously (and currently) worked on, I've had scenarios where we're using PDO_ASSOC as the fetch mode.
This change would allow others to chunkById in either scenario, handling Models/objects or associative arrays.

+1


Fix find-in-files and go-to-line dialog (partially)

Fixes #21975

Change find-in-files dialog to be AcceptDialog instead of WindowDialog because the latter can be resized to be smaller than minimum size. Also use built in AcceptDialog buttons.
Use VBoxContainer to position UI in go-to-line dialog.

@groud I'm not sure if it'd totally fixes 21975 because I didn't touch find function dialog in the original issue. I probably might have fixed a fraction of the real issue.

That being said the regression causing #21933 seems to be quite old (currently looking for a bisect "good" commit, still not found while mid-July), and the EDSCALE-related parts of #21975 definitely need a fix as proposed here. Haven't assessed the rest yet, I'll try to finish my bisecting of #21933 to have a better overview and know if it relates or not with #21975.

Another update, #21933 is fixed and was caused by a bug in Label exposed by an optimisation (b2e78e11), so not a duplicate of #21975 (but if the latter appears to be a regression too, that optimisation might be worth checking).

Thanks!


What is the keepalive_timeout attribute for?

What is the keepalive_timeout attribute for?
I can not find keepalived package and configuration file.
Do you have plan to develop keepalived feature?.

It's used in https://github.com/cloudfoundry-community/haproxy-boshrelease/blob/master/jobs/haproxy/templates/haproxy.config.erb#L23
HAProxy documentation: https://cbonte.github.io/haproxy-dconv/configuration-1.6.html#4-timeout http-keep-alive

I was confused with keepalivedc.
Actually, i am using haproxy-boshrelease with keepalivedc to achieve high availability.
To automate this feature, need to add some settings to haproxy-boshrelease.
Do you have plan to develop this feature like keepalivedc?.
http://www.keepalived.org/
http://www.stratoscale.com/wp-content/uploads/HAproxy-architecture.png

Orange is preparing a PR for keep-alived support in haproxy-boshrelease. We're polishing the documentation and should submit the PR soon. Some more details at https://github.com/orange-cloudfoundry/cf-haproxy-boshrelease/pull/1
/CC @axelfauvel @poblin-orange


[Android] Invariant Violation: requireNativeComponent: "RCTFBLoginButton" was not found in the UIManager.

🐛 Bug Report
When I try to show a LoginButton, it appears the following error: Invariant Violation: requireNativeComponent: "RCTFBLoginButton" was not found in the UIManager.
To Reproduce
I have a simple html button inside a WebView (react-native-webview package), on click I would like to show another view with the Facebook login button. (Note: navigations between views are handled with react-navigation/native package)
Expected Behavior
On button click I expected a new view with the Facebook login button
Code Example
import React from "react";
import {
  Text,
  View,
} from "react-native";
import { AccessToken, LoginButton } from "react-native-fbsdk-next";

const FacebookSdkLogin = () => {
  var token = null;
  return (
    <View>
      <LoginButton
        onLoginFinished={(error, result) => {
          if (error) {
            console.log("login has error: " + result.error);
          } else if (result.isCancelled) {
            console.log("login is cancelled.");
          } else {
            AccessToken.getCurrentAccessToken().then((data) => {
              console.log(data.accessToken.toString());
            });
          }
        }}
        onLogoutFinished={() => {
          console.log("logout.");
        }}
      />
      {token ? (
        <Text style={{ textAlign: "center" }}>{`Token: ${token}`}</Text>
      ) : null}
    </View>
  );
};

export default FacebookSdkLogin;

Environment
![IMG_20210726_182122](https://user-images.githubusercontent.com/69848167/127024106-722d120f-fb01-4532-b5d8-2cb6cbe55aeb.jpg)

I think it's related to Expo tool because in a React-Native "pure app" this error doesn't appear.

I am also having this same issue, please help.

I am also having this same issue, please help.

Are you using Expo?

I am facing the same issue. I am using expo

Anyone have the resolution for this ?
@mikehardy  @cage81 @ShajiaAnnoor

I saw something similar in device info just now, it appears something expo has done has broken things. Not sure what, I do not use Expo.
https://github.com/react-native-device-info/react-native-device-info/issues/1381
No idea what would cause this. If you can reproduce it from a clean app (npx react-native init ....) then we have a bug, if it's just something Expo-specific, pursue on expo support site I think

Thank you for your time @mikehardy. Really appreciated.
It is happening only when I use the  tag.
I started by installing "react-native-fbsdk-next" .
and then followed along this documentation.
https://www.npmjs.com/package/react-native-fbsdk-next
after adding the below code as follows:
<LoginButton
onLoginFinished={
(error, result) => {
if (error) {
console.log("login has error: " + result.error);
} else if (result.isCancelled) {
console.log("login is cancelled.");
} else {
AccessToken.getCurrentAccessToken().then(
(data) => {
console.log(data.accessToken.toString())
}
)
}
}
}
onLogoutFinished={() => console.log("logout.")}/>
      and after running the code I receive the error "Render Error: requireNativeComponent: "RCTFBLoginButton" was not found in the UIManager"

and the error is occurring for only  tag not for any others tags.

This was the most important part of my comment, it still stands:

No idea what would cause this. If you can reproduce it from a clean app (npx react-native init ....) then we have a bug, if it's just something Expo-specific, pursue on expo support site I think

Hi guys, this error was happening to me with a barebone expo app (expo app after expo prebuild). The problem was using expo start instead of expo run. When you execute expo run the app builds natively using the android dir and the lib is loaded properly. Hope it helps!


matplotlib: Fix TkAgg

Motivation for this change
Matplotlib with TkAgg was broken in 16.09 due to separate outputs in tk.
The matplotlib packages in master and release-16.09 are so different that the changes in this PR and in #20774 are incompatible.
Things done

[x] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[x] Linux

[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

CC: @FRidh @lovek323
Support for TkAgg was broken due to the package tk being split into
multiple outputs: The setup script was unable to locate the tk headers.
This patch fixes that by passing the include path from tk.dev
explicitly

Is it working on master as expected?

Note that I just pushed https://github.com/NixOS/nixpkgs/commit/4626857229f241b06742d3707c913c321a60973d (to fix evaluation when enabling TK backend with Python 3) so you will need to rebase.

@FRidh Yes, it's working on master as expected. I just checked it with python 2.7 and 3.5. Thanks!
And thanks for the heads-up. I've rebased the PR and tested it with python 2.7 and 3.5.

@FRidh Thanks, it's working as expected.


StatefulSet deployed via a Flux HelmRelease are not displayed in the UI.

Hi,
We use flux 2.2.3 and Flamingo v2.10.2+81e8dc2.dirty
We use flamingo generate-app to create the argo app. It work perfectly well for HelmRelease containing a Deployment but for HelmRelease containing StatefulSet everything is displayed in the Flamingo UI except the StatefulSet.
Regards,

I am also having resources not showing when using flamingo generate-app from a helm-release. I am using the ingress-nginx chart. The resources used to show when creating the app (this stopped showing yesterday, and I have tried redeploying it all). All that is shown in the UI is the helmReop and helmRelease objects, but nothing else (the resources are created in Kubernetes)

Same Problem here. Tried a lot of HelmCharts with different kind of resources but they won't be shown. We are using flux 2.3.0 and Flamingo v2.10.5-fl.23-main-5958964b

Same here, we use flamingo  v2.10.2-fl.23-main-d2c9a8cb and flux 2.3.0. Is there any way to deploy pods/deployments and other resources deployed by helm releases?

Also having the same problem of only the HelmRelease object being shown in the UI but not the objects that are managed by said HelmRelease.
Interestingly enough, if you turn on orphaned resources detection in the associated Argo project it shows that the application contains a bunch of orphaned resources, presumably the ones that are not shown in the UI.

I scaled down all pods (except redis) in argocd namespace, then scaled them up, now I am able to see the pods created by helmreleases and kustomizations. I am using 2.10.5 release of flamingo.

If you downgrade flux to version 2.2.2 the resources will be shown in Flamingo (v2.10.5-fl.23-main-5958964b).


Fibonacci Series in python

There should be a Fibonacci series in every data structure algorithm repository.

Kindly assign this issue to me .I am a gssoc'21 participant

Hey there, I think I can solve this issue, I will write this code in python and I will complete this code in max one hour after it is assigned to me. So please assign this issue to me.

please assign this issue tome in java under GSSOC'21

present at #635


python312Packages.pygccxml: 2.5.0 -> 2.6.0

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python312Packages.pygccxml is: Python package for easy C++ declarations navigation
meta.homepage for python312Packages.pygccxml is: https://github.com/gccxml/pygccxml
meta.changelog for python312Packages.pygccxml is: https://github.com/CastXML/pygccxml/blob/v2.6.0/CHANGELOG.md
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 2.6.0 with grep in /nix/store/3ik2kjxyyyz9qa19wzsxsa4wardx2s48-python3.12-pygccxml-2.6.0
found 2.6.0 in filename of file in /nix/store/3ik2kjxyyyz9qa19wzsxsa4wardx2s48-python3.12-pygccxml-2.6.0

Rebuild report (if merged into master) (click to expand)

8 total rebuild path(s)

8 package rebuild(s)

First fifty rebuilds by attrpath

gnss-sdr
gnuradio
gnuradioPackages.osmosdr
ns-3
python311Packages.pygccxml
python312Packages.pygccxml
trunk-recorder

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/3ik2kjxyyyz9qa19wzsxsa4wardx2s48-python3.12-pygccxml-2.6.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A python312Packages.pygccxml https://github.com/r-ryantm/nixpkgs/archive/1c34da7d34fbeb0652df6eecbdd7d387167d61b1.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/1c34da7d34fbeb0652df6eecbdd7d387167d61b1#python312Packages.pygccxml

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/3ik2kjxyyyz9qa19wzsxsa4wardx2s48-python3.12-pygccxml-2.6.0
ls -la /nix/store/3ik2kjxyyyz9qa19wzsxsa4wardx2s48-python3.12-pygccxml-2.6.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review

x86_64-linux

:white_check_mark: 10 packages built:

gnss-sdr
gnuradio
gnuradioPackages.osmosdr
gnuradioPackages.osmosdr.dev
ns-3
python311Packages.pygccxml
python311Packages.pygccxml.dist
python312Packages.pygccxml
python312Packages.pygccxml.dist
trunk-recorder

Maintainer pings
cc @teto for testing.

[!TIP]
As a maintainer, if your package is located under pkgs/by-name/*, you can comment @NixOS/nixpkgs-merge-bot merge to automatically merge this update using the nixpkgs-merge-bot.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 356872 run on x86_64-linux 1

10 packages built:

gnss-sdr
gnuradio
gnuradioPackages.osmosdr
gnuradioPackages.osmosdr.dev
ns-3
python311Packages.pygccxml
python311Packages.pygccxml.dist
python312Packages.pygccxml
python312Packages.pygccxml.dist
trunk-recorder


Does UnmountVolumeAfterTimeMachine work on Sonoma?

Hey,
I've found this tool and while it seems to exactly do what I want, it does not seem to work on my MacBook Air running Sonoma.  I've installed it using mint, and when I start it I see this:
mecipt-1 1088_% ~/.mint/bin/UnmountVolumeAfterTimeMachine
No launchd agent set
launchd agent written
launchd agent startOnMount set
status: unloaded

When I manually start a Time Machine backup, it finishes, but the backup volume stays mounted.  Nothing is printed by UnmountVolumeAfterTimeMachine after the initial messages.  Am I missing something?
Thank you!
Hans

Sorry for the slow reply: it works for me!
I hadn't actually backed up since upgrading so I did just now and it behaved as expected.
My first guess is you had the drive open in Finder, or a file open that's on that's on the drive, so it wasn't able to be ejected.
Please try it again. I presume since you installed it via Mint, it's still installed. Please:

open Activity Monitor
plug your drive in
notice the drive show in Finder
notice UnmountVolumeAfterTimeMachine in Activity Monitor
notice Time Machine start (or start it)
notice Time Machine complete (including cleanup)
UnmountVolumeAfterTimeMachine should be absent from Activity Monitor
your drive should be absent in Finder

Let me know how what happens for you.

Hi,
thank you for getting back and confirming that the tool works on Sonoma.  I believe that my system is somehow behaving incorrectly in that the external hard drive does not show up in Finder, even though it is mounted and visible in the /Volumes directory.  My guess is that this misbehavior is also what causes UnmountVolumeAfterTimeMachine to not work.  I will try to figure out what's going on, resorting to recreating my user account from scratch if necessary (although that'd be a bit of a pain).
Kind regards,
Hans


Execution failed for task ':react-native-google-analytics-bridge:processReleaseResources'.

I have problem running app.

I have Android sdk tools 23~25.
How should I fix it?

@edoko
I ran into same issue, solution is to change your project folder name to minimal characters.
refer this thread https://github.com/mcnamee/react-native-starter-app/issues/64#issuecomment-289224815

@edoko Make sure you have exactly build tools 25.0.2 (from Android Studio > Tools > Android > SDK Manager > SDK Tools > Click show package details > then install the missing version/s)


[Text] Highlight Text on Press

I'm working on a chat application. The messages can have links, and I need to parse the text to identify the links.
By nesting Text components, I'm able to give the links a blue color, and handle press on the link to open it in the browser. But it's missing one important element, it doesn't give any feedback when the link is pressed (I'm on Android).
The TouchableHighlight component seem to be only working for views and not for text. So I cannot use it, as the links need to be inline with the rest of the text.
Are there any plans for providing a TouchableTextHighlight or something like that? Or maybe even support Text components with TouchableHighlight?
Maybe my approach is all wrong. If so, is there another preferred method of handling such scenario? Maybe I could use setNativeProps somehow?

On iOS this is supported - nested Text with an onPress is highlighted with a grey background (as per default iOS behaviour when you touch a link within Safari) when it is touched. We should have parity for this feature on Android. What is the default behaviour on Android?

@brentvatne On android nothing happens. No feedback :(

@satya164 - within React Native yeah, what about within Chrome when you press on a link, what is the default behaviour? Does this seem like a reasonable effect to use?

@brentvatne I don't think there is any background color change unless you do it with CSS. I've never tried a web page without CSS though, but I think it's just darkening of the link.
I'll try a plain web page and reply back.

This is in the latest Chrome for Android:
Unstyled link:

Link OnPress:

Visited Link (RN wouldn't implement this, just included for completeness):

I'm happy to take a look at getting this implemented if that would be helpful.

@corbt Would very much like to see this implemented on Android as any serious reading application in RN would require textural interactions.

@ssomnoremac unfortunately at the moment I'm busy with other stuff, but I do hope someone takes this on.

maybe also related to this issue - on android it is much "harder" to trigger onPress than on iOS.
on iOS I can see highlight area around text itself and whole this area seems to respond to press event.
on android I can quite easily touch touchablehighlight with text - but it is quite hard when I have just "inline" text with onPress.
is it possible or is it just my "wrong impression"?

on Android inline text onPress event often doesn't work
@sodik82 did you have a chance to find a solution/workaround?

unfortunately not yet. as kind of workaround I have additional touchablehighlight under the text itself (in my case "tag list") - but it is not real solution to that problem.

Hi there! This issue is being closed because it has been inactive for a while.
But don't worry, it will live on with ProductPains! Check out its new home: https://productpains.com/post/react-native/text-highlight-text-on-press
ProductPains helps the community prioritize the most important issues thanks to its voting feature.
It is easy to use - just login with GitHub. GitHub issues have voting too, nevertheless
Product Pains has been very useful in highlighting the top bugs and feature requests:
https://productpains.com/product/react-native?tab=top
Also, if this issue is a bug, please consider sending a pull request with a fix.
We're a small team and rely on the community for bug fixes of issues that don't affect fb apps.


One Dark syntax theme colors all Java code yellow

Here's a screenshot of the issue:

I've seen the same issue in Sublime themes as well but I never quite figured out the problem.

I'm not sure it's a bug. Just a bad design choice.
I noticed that as well with Java files and the theme just doesn't work very well with those files.
If you wish to change this, open an issue on the theme's repository, or create a PR with something more pleasing, maybe?

I'll move this over to the One dark syntax theme: https://github.com/atom/one-dark-syntax/issues/21


Can't import an user

Laravel Version: 5.4
Adldap2-Laravel Version: #.#
PHP Version: 7.1.10
LDAP Type: Active Directory

Description: I use the command  php artisan adldap:import someemail, everything goes well, it found the user, then I put yes, yes.  Then the last message is Successfully imported / synchronized 0 user(s).
Why is not importing the user? My provider is:
'provider' => Adldap\Laravel\Auth\DatabaseUserProvider::class,

To anyone looking back on this, you could technically just change name key in sync_attributes array to first_name which is what I've done. It's not ideal, but I'm about to dig deep to see if I could somehow split based on space and then insert into both first_name and last_name.


Update ScalaCheck to 1.14.1

Codecov Report

Merging #1274 into master will decrease coverage by 0.31%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1274      +/-   ##
==========================================
- Coverage   85.97%   85.66%   -0.32%
==========================================
  Files          74       74
  Lines        2532     2532
  Branches      110      110
==========================================
- Hits         2177     2169       -8
- Misses        355      363       +8

Impacted Files
Coverage Δ

.../core/shared/src/main/scala/io/circe/Decoder.scala
83.1% <0%> (-2.15%)
:arrow_down:

...rc/main/scala/io/circe/numbers/BiggerDecimal.scala
84.79% <0%> (-0.59%)
:arrow_down:

...les/core/shared/src/main/scala/io/circe/Json.scala
78.78% <0%> (+0.6%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe817bd...8bc8bc9. Read the comment docs.


[Dialog] Add 'lg' support to maxWidth

Added 'lg' as an option for maxWidth on Dialogs.
This is my first code PR, so please let me know if I missed anything!

This is my first code PR, so please let me know if I missed anything!

Is it #10742? Thanks!


Install issues

Whay i have problem the install the package of playsound 1.3.0

https://github.com/TaylorSMarks/playsound/issues/150
There are a few suggestion in that issue. pip install wheel worked for me.


AppDynamics cluster agent auto-instrumentation breaks other deployed Helm releases

The AppDynamics cluster agent appears to work by running an init container that copies the AppDynamics language-specific agent and instrumentation shim into the application container.  It does so by creating an emptyDir volume named "appd-agent-repo-nodejs" (in our case, anyways) that is mounted by the init container, and the application container.  This appears to be accomplished by modifying the deployment spec to define the volume and have the application container mount the volume.
A problem arises when attempting to deploy the service again, as it will generate the following error --
Error: UPGRADE FAILED: an error occurred while rolling back the release. original upgrade error: cannot patch "foo" with kind Deployment: Deployment.apps "foo" is invalid: spec.template.spec.initContainers[0].volumeMounts[0].name: Not found: "appd-agent-repo-nodejs": release foo failed: timed out waiting for the condition

This is because the deployment spec has been updated and the application Helm chart does not match anymore.  One workaround was to try adding the "appd-agent-repo-nodejs" emptyDir volume manually to each service Helm chart, which seemed to work, at least for deploying the chart.  However, when the containers would actually try to start the AppDynamics cluster agent seemed to skip actually performing the instrumentation, and the services would fail to start with this error --
internal/modules/cjs/loader.js:796
    throw err;
    ^

Error: Cannot find module '/opt/appdynamics-nodejs/shim.js'
Require stack:
- internal/preload
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:793:17)
    at Function.Module._load (internal/modules/cjs/loader.js:686:27)
    at Module.require (internal/modules/cjs/loader.js:848:19)
    at Module._preloadModules (internal/modules/cjs/loader.js:1133:12)
    at loadPreloadModules (internal/bootstrap/pre_execution.js:443:5)
    at prepareMainThreadExecution (internal/bootstrap/pre_execution.js:62:3)
    at internal/main/run_main_module.js:7:1 {
  code: 'MODULE_NOT_FOUND',
  requireStack: [ 'internal/preload' ]

I was 90% through writing this issue when I decided to ensure that our Helm versions were fully up to date.  After upgrading to Helm 3.4.2, this doesn't appear to be a problem anymore.  The issue was likely something Helm-specific, and this kind of init container rewriting of the deployment spec appears to be supported now.
I decided to finish filing the issue in case someone else out there hits this.  When looking for a solution I wasn't able to find anything to steer me in the right direction, so hopefully this might help someone out in the future.


Implement annotation based registration

Overview
This implements annotation based Registration of Classes, Functions, Properties and Signals.
Information on how to use the annotations are provided in the Registration readme.
Technical background:
The annotation processing is done using a KotlinCompiler plugin I implemented in the old repo (kotlin-compiler-plugin and kotlin-compiler-native-plugin modules). To read the annotations on native targets we use the MpApt project. The annotations are received in a AnnotationProcessor (the godot-annotation-processor module).
The Entry file is then generated using the EntryGenerator (inside the entry-generator module).
The problem we had is that the compiler plugins are called too late in the compilation process for the compiler to pick up the newly generated Entry.kt file.
Jetbrains goes around this problem by directly generating JVM Bytecode / IR (for native) and feeding that into the compiler (see the Serializable compiler plugin).
As I don't have the required know how to directly generate IR (nor do i find it useful as we cannot debug it conventionally) I opted to overcome this problem by adding a dummy target during build. As the actual compilation task is the shortest one the time overhead is negligible IMHO. During the compilation for this dummy target, the Entry.kt file is generated. So it's already present when we compile the real target. This dummy target logic is located in the KotlinTargetPreset (in the godot-gradle-plugin module). It ensures also only one dummy target is added even when building for multiple targets.
Summary of the steps:

During build a dummy target is added
The dummy trarget get's compiled
The kotlin compiler plugin calls the annotation processor with all required annotations
The annotation processor gathers all information required for the entry generator
The annotation processor calls the entry generator with all required informations
The entry generator generates the entry file
The actual target is compiled including the now present entry file
rest of the normal build pipeline follows...

Alternatives that i tried:

Normal annotation processing using kapt:
The problem here is, that kapt only works for JVM targets. There is no kapt for native targets. Once #10 is implemented. My goal is to switch to normal kapt annotation processing as it's much faster. The migration should be almost seamless as i already use a annotation processor and we just need to remove the compiler plugin part and the dummy target.
But for now this is sadly not possible.

Extracting the kotlin compiler frontend into a script and call it directly:
This worked for the most part. The problem was that we needed to add all required sources of all dependencies to be parsed as well. Which is no problem for our own code but is a problem for dependencies the user might add. Furthermore the parsing took a long time (around 45-60s on a Dell XPS 15  with an i7-8750H). It also takes this long for the godot-library so it was not a problem with the script, more of the sheer amount of code that needed to be parsed.
This and the fact that we cannot gather all the required source code for all the dependencies a user might add, lead me to the conclusion that i don't want to use this approach.

The next steps:
There are many things we can optimize regarding annotation processing. But I didn't implement it yet as this is the basics on which we can build on.
Some improvements i want to make:

Implementing some extension functions to make the life easier when working with signals
So a user could call connect(::methodInThisClass) and this would automatically connect the signal he has overriden
Use code generation to provide the possibility to export NodePath from annotating a property of a type which derives from Node.
Like this a user could write this code:

@Export
lateinit var body: KinematicBody

instead of:
@RegisterProperty(true, null)
lateinit var body: KinematicBody

@RegisterFunction
override fun _ready() {
    body = KinematicBody2D from getNode(NodePath("Path/To/Node"))
}

and then could wire up the node path in the editor, like when writing
export var pathToBody : NodePath
onready var body: KinematicBody = get_node(pathToBody)

in GDScript.
Notes
Note: I did not bother migrating the coroutines sample as it does not work at the moment anyways and we can do the migration together with the fix of it in #36.
@piiertho please check the bintray configuration with care as I'm not sure whether they are correct.
@CedNaru Please check the registration readme with care to be sure everything is clear (I'm sadly not that good at writing documentation in an understandable manner)
I tested this on linux and android. Please also test on MacOS and Windows.
This resolves #2 .

I've got fairly poor service here and can't seem to comment on the exact line in the change, but the new config section in the build.gradle.kts scripts needs to take the buildType project var into account. Currently it just hard codes to debug.

buildType

True i forgot that. It's added now. Thanks :-)

Hi ! Really great job !
There is some mission documentation in COMPILING_FROM_SOURCES.md, to compile annotations-internal only.
Everything working on MacOS.

Whops. Sorry about that. Added it now.

I rebase this PR to include the changes made in #41

Thanks a lot for this awesome work !
It's working well on MacOS and Windows on my side :)

Good to hear! Thanks for your review.


Nesting a code block with table elements inside of a table cell results in incorrect rendering

Consider the following markdown:
|PowerShell command|Example|
|--|--|
|Get-Service|`Get-Service | Stop-Service -WhatIf`|

This renders incorrectly, with the second column in the first data row truncating after the pipe that is inside of the code block.
Please consider fixing this such that showdownjs ignores table pipe symbols inside of inline code blocks that are included in the markdown table.
Thank you.

This is indeed a bug.
As a workaround, for now, you can escape the pipe char, like this:
|PowerShell command|Example|
|--|--|
|Get-Service| `Get-Service \| Stop-Service -WhatIf` |

Keep in mind though that github also fails in the same regard:

PowerShell command
Example

Get-Service
`Get-Service

Should be fixed now in latest develop. Please give it a try and let me know.

Donate
As you know, ShowdownJS is a free library and it will remain free forever. However, maintaining and improving the library costs time and money.
If you like our work and find our library useful, please donate through Pledgie or directly through paypal!! Your contribution will be greatly appreciated and help us continue to develop this awesome library.

Thank you. I'll give it a try next week (it's Thanksgiving/long weekend in the US, so I can't get the upgrade to the latest done until next week).


ShadowDOM and chromedp.ByJSPath

Hi,
I have been trying to access elements within a ShadowDOM. Puppeteer has solved this problem via JS Path evaluation: https://github.com/GoogleChrome/puppeteer/issues/858#issuecomment-438540596
I have coded up a sample to add chromedp.ByJSPath with this api:
chromedp.Click(`document.querySelector('#container').shadowRoot.querySelector('#foo')`, chromedp.ByJSPath),

Here is my quick implementation:
// ByJSPath is a query option to select elements by JS Path
// this allows selection of nodes within ShadowDOM nodes
func ByJSPath(s *Selector) {
	ByFunc(func(ctx context.Context, n *cdp.Node) ([]cdp.NodeID, error) {
		// set awaitPromise
		p := runtime.Evaluate(s.selAsString()).WithAwaitPromise(true)

		// evaluate
		v, exp, err := p.Do(ctx)
		if err != nil {
			return nil, err
		}
		if exp != nil {
			return nil, exp
		}

		// use the ObjectID from the evaluation to get the nodeID
		nodeID, err := dom.RequestNode(v.ObjectID).Do(ctx)
		if err != nil {
			return nil, err
		}

		if nodeID == cdp.EmptyNodeID {
			return []cdp.NodeID{}, nil
		}

		return []cdp.NodeID{nodeID}, nil
	})(s)
}

This works and appears to be quick. Maybe you have a better solution? Or happy to do a PR.

Hi,
If anyone is interested I have created proof-of-concept for using JSPath instead of XPath to allow ByJSPath (above) to behave like any other selector. JSPath allows full traversal of the DOM including any ShadowDOM.
So adding ByJSPath and refactoring the included Javascript functions in:
https://github.com/seddonm1/chromedp
And adding jspath vs xpath in:
https://github.com/seddonm1/cdproto
You can do track changes to see diffs.

@seddonm1 please submit a PR for this.

@kenshaw I can but this is a relatively large change given the reliance on XPATH (which does not support ShadowDOM)  for a lot of the Selector functions. This would need agreement from @mvdan and others to switch to JSPATH.

This would not become the default option -- adding an additional selector type is more than fine. Dan can of course weigh in, but I don't see any reason to not add this. The only thing missing from the above is a unit test covering the selector.

Hi, happy to submit the PR but it will not achieve much given that most chromedp Actions assume they will be given an XPATH: https://github.com/chromedp/chromedp/blob/master/js.go#L70 (which does not work through shadowDom boundaries.
I had to change the cdproto to add a JSPath javascript command generator: https://github.com/seddonm1/cdproto/blob/master/cdp/types.go#L393
and modify the JS to accept either the XPATH or JSPath command:
https://github.com/seddonm1/chromedp/blob/master/js.go#L70
I guess the big question is if chromedp wants to support JSPath. If so then it needs to be applied everywhere (instead of XPath by default)

@seddonm1 apologies, I did not realize you weren't the original issue author. I did not mean to cause confusion. Also, note that the default By func is BySearch, which takes either a XPath or a CSS query. The underlying call is Chrome's DOM.performSearch.
@A139834 I'd be more than happy to put in this By* func. To simplify things, I'll just add this and a unit test for it. Feel free to submit a PR with this, if you'd like your name/email in the commit history.

I have a working implementation here: https://github.com/chromedp/chromedp/pull/387
Please note that I'm still polishing that up, but it should work. Expect it to be merged to master in the next couple days.

@kenshaw thanks. Actually i am @A139834  as well as I forgot to log out of my work github.
I will give this a try probably tomorrow and see if it is working with my tests.


Fix the issue of visiting SMI firmware update service

Background
smi-service API could be invoked through each individual smi-service or smi-service-gateway which could be controlled by config file. During development of previous stories, we found it was failed to invoke API through gateway but successful through individual smi-services. We need to resolve this problem.
https://rackhd.atlassian.net/browse/RAC-6424
Done
Add extra_hosts: service-registry for consul.
Reviewers
@rahmanmuhamad  @RackHD/corecommitters @nortonluo

The Copyright Check has failed!
The files listed below do not have a valid copyright statement:

docker/dell/docker-compose.yml


First methods

Added the *First methods to the docs, renamed some deprecated methods to their non-deprecated names

Updated with PR fixes. @emosbaugh


Check for existence of fields before setting in profile

To make consistent with the other oAuth passport libs

Not too keen on this one, this can break existing code.
If someone pulls a profile which has no name fields then profile.name won't exist so if someone is checking for profile.name.givenName they will get TypeError: Cannot read property 'givenName' of undefined instead of simply a value of undefined.

In that case, we should probably update the other strategies to match, because the google oauth 2 strategy does the same thing.
If the goal is for these strategies to return semi-consistent profiles, them we should probably strive to make them behave consistently.

Ugh you're right about the google oauth 2. I'll raise an issue in the main passport repo for this and have a think.

https://github.com/passport-next/passport/issues/16 made the issue for discussion.


Bare Bones example project

Hi all,
I was playing round with discovery and one thing that would be awesome is an example project with all the modules defined but stubbed out (kind of like how the cowboy team setup their examples https://github.com/ninenines/cowboy/tree/master/examples).
Thanks!

@cjimison this is a good idea, I'll see what I can do unless somebody issues a PR and beats me to it


Bot skipping private accounts involuntarily

What happened:
Bot skips private accounts, even if there is no variable set to skip them at all
What you expected to happen:
For bot to send a follow request to private accounts
Environment:

GramAddict version: v3.1.5
Device Model/Emulator Type: SM-T860
Android Version: 11
Instagram Version: <IP_ADDRESS>.117.

Anything else we need to know?:
Everything is being performed without an issue. Users are being followed, interacted with and photos are being liked. But as soon as the bot reaches a private account it skips it, and I don't know why.
Relevant Logs:
CMD log.txt
config.txt
filters.txt
All private and nonrelevant data has been redacted from all three files.

Nope.
This is what a skip for private looks like: USERNAME has a private account and you want to interact only public, skip.
you probably have "interact-percentage" less than 100%.

Thank you for the explanation. Because the command line didn't output that private accounts were being followed I just pressumed it skipped them all-round.

Let me be more clear about that because I got asked a few times. :D
When it opens an account it takes some useful information.
If the profile is private, the bot says that it's private in the log.
At this point we can: send a PM, FOLLOW, SKIP.
To follow a private (or empty) profile you must have it enabled in your filters follow_private_or_empty: true and be lucky with the flip coming out from "follow-percentage" (for example 50%, you have a 50% of chance to follow him).
I'll change the bare SKIP with something more explicative.
thanks


DocsArchive-<IP_ADDRESS>Auto archive content

Please don't merge this PR until target archive repo PR https://github.com/OPS-E2E-PPE/docs-archive-test-target_75afa2b6-df6a-498e-b582-66971556b65b/pull/1 is merged into live branch.
Auto archive content to https://github.com/VSC-Service-Account/docs-archive-test-target_75afa2b6-df6a-498e-b582-66971556b65b.git

Docs Build status updates of commit c80f74b:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error-BackendEngineExceptionError] An exception occurred during the build process. Please check the raw log and retry building your content again. If the issue persists, please open a ticket in https://SiteHelp and include the URL of publishing report as well as below information: One or more errors occurred..

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


Fcc pipeline2

PR #4 contains the commits for the first bullet point below. All commits after that are for the second bullet point below.

Copied code from United States of Broadband and organized into separate files for the HTML, CSS, and JavaScript
Developed working bash scripts to generate maptiles, which are currently stored in a private (Google internal) GCS bucket

This change is

We've decided to push this work to a different repo, using a fork of the original. Closing.