refactor: rename ibcDenom to denom

ibcDenom is not semantically correct since possible values can include for example:

native denom: rowan
peggy denom: cusdc, sifBridge00010x0000000000000000000000000000000000000000
ibc denom: ibc/330D65554F859FB20E13413C88951CFE774DD2D83F593417A0552C0607C92225

Does that mean the new denom is stable and returns a predictable value?
What was the conclusion in the comparison in your investigation for performing this refactor?

Does that mean the new denom is stable and returns a predictable value?
What was the conclusion in the comparison in your investigation for performing this refactor?

Yes denom is stable n should always return the correct value. This is simply a rename, since "denom" is a much better description of the possible values returned


Refrain from writing deprecated legacy options to invokeai.yaml

What type of PR is this? (check all applicable)

[ ] Refactor
[ ] Feature
[X] Bug Fix
[ ] Optimization
[ ] Documentation Update
[ ] Community Node Submission

Have you discussed this change with the InvokeAI team?

[X] Yes
[ ] No, because:

Have you updated all relevant documentation?

[X] Yes
[ ] No

Description
When migrating the invokeai.init legacy configuration file to the new .yaml format, do not copy any deprecated fields. This PR also activates the Pydantic validate_assignment behavior which raises an exception when an instantiated config object is updated with invalid values.
Related Tickets & Documents

Related Issue #
Closes #

QA Instructions, Screenshots, Recordings

Added/updated tests?

[ ] Yes
[ ] No : please replace this line with details on why tests
have not been included

[optional] Are there any post deployment tasks we need to perform?

Ah, I missed your comments in the PR itself about validate_assignment, cool.
I'd still like to understand why this PR couldn't just add that as a safeguard, and then remove the restore field from the config model. If we aren't going to reference it, why do we need to maintain that value?

Ah, I missed your comments in the PR itself about validate_assignment, cool.
I'd still like to understand why this PR couldn't just add that as a safeguard, and then remove the restore field from the config model. If we aren't going to reference it, why do we need to maintain that value?

I will remove the deprecated fields and see if it causes any issues. As I recall, the presence of additional fields in invokeai.yaml were causing exceptions, and this was without setting Extra.ignore. But the code has changed a lot since then.

I've marked the conversations resolved so we can get this important fix in, but I think there's some room to improve how we handle InvokeAIAppConfig to better leverage the data integrity confidence afforded by Pydantic.


Conflict between SRP and OCP

Prerequisite Checklist

[X] I searched for existing issues to prevent duplicates
[X] I searched for existing discussions on the forum to prevent duplicates
[X] I understand SFML's scope and believe the feature fits it

Describe your feature request here
sf::Sprite, sf::Text, sf::VertexArray ...: break SRP rules, for follow OCP
Have two reason for change.
draw() - for follow OCP
other
Use Cases
make friends SRP with OCP
API Example
//-----------------------------------------------------------------------------
//
// Source code for MIPT ILab
// Slides: https://sourceforge.net/projects/cpp-lects-rus/files/cpp-graduate/
// Licensed after GNU GPL v3
//
//-----------------------------------------------------------------------------
//
//  Demonstration of parent inversion: complete SRP and OCP satisfied
//
//-----------------------------------------------------------------------------

#include <algorithm>
#include <iostream>
#include <memory>
#include <string>
#include <utility>
#include <vector>

using Screen = std::ostream;

struct Vector3D {
  int x, y, z;
};

struct Polygon3D {
  std::vector<Vector3D> vs;
  Polygon3D(std::initializer_list<Vector3D> il) : vs(il) {}
};

void draw(int x, Screen &out, size_t position) {
  out << std::string(position, ' ') << x << "\n";
}

void draw(Vector3D v, Screen &out, size_t position) {
  out << std::string(position, ' ') << "(" << v.x << ", " << v.y << ", " << v.z
      << ")\n";
}

void draw(const Polygon3D &p, Screen &out, size_t position) {
  out << std::string(position, ' ') << "<polygon>" << std::endl;
  for (auto v : p.vs)
    ::draw(v, out, position + 2);
  out << std::string(position, ' ') << "</polygon>" << std::endl;
}

class Drawable {
  struct IDrawable {
    virtual ~IDrawable() = default;
    virtual std::unique_ptr<IDrawable> copy_() const = 0;
    virtual void draw_(Screen &, size_t) const = 0;
  };

  template <typename T> struct DrawableObject final : IDrawable {
    T data_;
    DrawableObject(T x) : data_(std::move(x)) {}
    std::unique_ptr<IDrawable> copy_() const override {
      return std::make_unique<DrawableObject>(*this);
    }
    void draw_(Screen &out, size_t position) const override;
  };

  std::unique_ptr<IDrawable> self_;

public:
  template <typename T>
  Drawable(T x) : self_(std::make_unique<DrawableObject<T>>(std::move(x))) {}

  // copy ctor, move ctor and assignment
public:
  Drawable(const Drawable &x) : self_(x.self_->copy_()) {}
  Drawable(Drawable &&x) noexcept = default;
  Drawable &operator=(Drawable x) noexcept {
    self_ = std::move(x.self_);
    return *this;
  }

public:
  friend void draw(const Drawable &x, Screen &out, size_t position) {
    x.self_->draw_(out, position);
  }
};

using Model = std::vector<Drawable>;

void draw(const Model &x, Screen &out, size_t position) {
  out << std::string(position, ' ') << "<world>" << std::endl;
  for (const auto &e : x)
    draw(e, out, position + 2);
  out << std::string(position, ' ') << "</world>" << std::endl;
}

template <typename T>
void Drawable::DrawableObject<T>::draw_(Screen &out, size_t position) const {
  ::draw(data_, out, position);
}

int main() {
  Model document;
  document.push_back(0);
  document.push_back(Polygon3D{{2, 1, 6}, {-3, 7, 4}});
  document.push_back(document);
  document.push_back(Vector3D{-3, 7, 4});
  draw(document, std::cout, 0);
}

You appear to be referring to SOLID principles. We don't oppose those rules but we also don't dogmatically follow them. This doesn't look like something we're interested in doing.

I don't particularly see a open-closed principle violation for draw() as it's extendible via sf::Drawable and inheritance if necessary. You should really be more specific, i.e. spend more than 5min writing down your thought process and reasoning (DeepL, ChatGPT and Google Translate all understand Russian as well).
One of SFML's "core goal" is to provide a simple API. This means we're not in this to practice perfect SOLID principles, but we're gladly trading something like single responsibility principle for a simpler API. Yes, we could extract some "SpriteDrawer" class or what else, to move the responsibility out of the sprite class, but that would make the API a lot more complicated, for no added benefit at this point. We might end up having to change the API for something like batch drawing, but this will bring its own challenges disconnected from SOLID principles.
The code you showed is nice a theoretical example, where you don't have to care about states and references, but it already shows an API that's a lot harder to understand and even breaks encapsulation, as implementation details such as draw_() and copy_() are exposed on a public API/interface.


Scope of Simple Edge Discovery for Fall24 CAMARA release

This issue shall define which issues are within scope of  the API of the Simple Edge Discovery Sub Project for the Fall24 release, and will be regularly updated based on the decision within the EdgeCloud meetings.
Alignment with Commonalities 0.4 and ICM

camaraproject/SimpleEdgeDiscovery#33
camaraproject/SimpleEdgeDiscovery#34
camaraproject/SimpleEdgeDiscovery#35
camaraproject/SimpleEdgeDiscovery#36
camaraproject/Commonalities/issues/233
camaraproject/Commonalities/issues/214
camaraproject/Commonalities/issues/213
camaraproject/Commonalities/issues/203
camaraproject/Commonalities/issues/177
camaraproject/Commonalities/issues/170
camaraproject/Commonalities/issues/152
camaraproject/SimpleEdgeDiscovery#22
camaraproject/SimpleEdgeDiscovery#21
camaraproject/SimpleEdgeDiscovery#20
camaraproject/SimpleEdgeDiscovery#15
camaraproject/EdgeCloud/pull/119

Resource model name/structure changes aligned with EdgeCloud

camaraproject/SimpleEdgeDiscovery#14
camaraproject/SimpleEdgeDiscovery#17
camaraproject/SimpleEdgeDiscovery#18
camaraproject/EdgeCloud/issues/163

Documentation

camaraproject/EdgeCloud/issues/207

API Release Criteria

camaraproject/SimpleEdgeDiscovery#16
camaraproject/SimpleEdgeDiscovery#19

@Kevsy would you like to transfer the issues from EdgeCloud into the SimpleEdgeDiscovery repository?
As you have write access to both repositories you can do it yourself, using the "Transfer issue" on the right column. Links to the previous location will be automatically redirected to the new location, so no problems with broken links in minutes etc.

@Kevsy x-correlator is still defined with format: uuid in v0.11.0-rc.1, but Commonalities removed this restriction in v0.4.0. So x-correlator can now be any string.

Thanks @eric-murray - raised in #33 for M4

@Kevsy don't forget the fix for #33

@Kevsy don't forget the fix for #33

Thanks - added to the scope above

Added the following issues to the scope.

camaraproject/SimpleEdgeDiscovery#34
camaraproject/SimpleEdgeDiscovery#35
camaraproject/SimpleEdgeDiscovery#36

@Kevsy When creating the release PR for M4, please set the version therein to 1.0.0, not 0.11.0 -- assuming that you still consider to release a stable version. It would be great if you would also update the title and target version field on https://wiki.camaraproject.org/display/CAM/simple-edge-discovery+v0.11.0 already now to have a clear status here.

HI Herbert -

When creating the release PR for M4, please set the version therein to 1.0.0, not 0.11.
Sure - just to clarify, you are not asking me to change the current PR for v0.11.0-rc.2https://github.com/camaraproject/SimpleEdgeDiscovery/pull/37 - but rather to make sure the eventual release PR for M4 has v1.0.0 , correct?

It would be great if you would also update the title and target version field on https://wiki.camaraproject.org/display/CAM/simple-edge-discovery+v0.11.0 already now to have a clear status here.

Yes, I can change that now
All best,
Kevin
C2 General
From: Herbert Damker @.>
Sent: Tuesday, August 20, 2024 8:20 PM
To: camaraproject/SimpleEdgeDiscovery @.>
Cc: Kevin Smith, Vodafone @.>; Mention @.>
Subject: Re: [camaraproject/SimpleEdgeDiscovery] Scope of Simple Edge Discovery for Fall24 CAMARA release (Issue #3)
External Email: Do you know the sender? Is the request to open attachments and click links legitimate? If in doubt, use the Report Message button.
@Kevsyhttps://github.com/Kevsy When creating the release PR for M4, please set the version therein to 1.0.0, not 0.11.0 -- assuming that you still consider to release a stable version. It would be great if you would also update the title and target version field on https://wiki.camaraproject.org/display/CAM/simple-edge-discovery+v0.11.0 already now to have a clear status here.

Reply to this email directly, view it on GitHubhttps://github.com/camaraproject/SimpleEdgeDiscovery/issues/3#issuecomment-2299592308, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AB4JV2SNMXLM4T6S57IVWLTZSOJHDAVCNFSM6AAAAABH7SB2NGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOJZGU4TEMZQHA.
You are receiving this because you were mentioned.Message ID<EMAIL_ADDRESS>

@Kevsy When creating the release PR for M4, please set the version therein to 1.0.0, not 0.11.0 -- assuming that you still consider to release a stable version.

Sure - just to clarify, you are not asking me to change the current PR #37 for v0.11.0-rc.2 - but rather to make sure the eventual release PR for M4 states  uses v1.0.0 , correct?

It would be great if you would also update the title and target version field on https://wiki.camaraproject.org/display/CAM/simple-edge-discovery+v0.11.0 already now to have a clear status there.

Yes, I can change that now

Sure @hdamker - just to clarify, you are not asking me to change the current PR #37 for v0.11.0-rc.2 - but rather to make sure the eventual release PR for M4 states uses v1.0.0 , correct?

Yes, correct. We should just get #37 merged soon, as the "eventual release PR for M4" is already due on Monday :-)

Thanks @hdamker - so I can merge #37 now, release with tag r1.2, and then prepare the release PR for M4 by the Monday deadline :)

@Kevsy thanks for https://github.com/camaraproject/SimpleEdgeDiscovery/pull/38 ... so you are now ready to create the release with the r1.2 tag 👍

@hdamker  Thanks, my mistake 🤦♂ - also thanks to @javierlozallu for the fast approval.
I will make the release and then prepare the PR for M4 per the instructions - Monday is a UK bank holiday so will get it done today...

@Kevsy I suppose that this issue is done and can be closed. Consider to start planning for Spring25 😄

Thanks Herbert and all the contributors for getting this issue closed :)


EnhancedTextarea doesn't listen for window resize events.

EnhancedTextarea and by extension, TextField in multi-line mode displays incorrectly when the window has been resized and the text wraps to more lines.  This is specifically when the component holding the TextFields is using the addon PureRenderMixin.  I haven't yet tested without the mixin.
When using PureRenderMixin, React will not call render() on a component if the state or props have not changed.
I think this could be solved by having EnhancedTextarea listen for a window resize event and call setState() as appropriate.  See React documentation on this.  This should cause the component to be re-rendered and display correctly on screen size changes.

Is it resolved for you now? This is specific to your use-case so I don't know how to recreate this.
I am closing this for now. Do let me know if this is still a problem for you by leaving a comment below and I will reopen the issue.


Request to add a function to copy a project from the projects title screen

Tested versions

System information

Issue description
If possible, add a button in the control column that will copy the project and give the option to immediately rename it (and only then, after confirmation, Godot will make a copy of the project folder)
The button can be placed at the very top or after “run”
(sorry if I'm writing in the wrong place)
Steps to reproduce

Minimal reproduction project (MRP)
N/A

Feature proposals are tracked here, this is for bugs. Please open a proposal instead. Please make sure to fill in everything on the form there, or if you are unable please open a discussion instead.
Closing as this is not the right place for feature proposals, thank you nonetheless.


I have completed the user creation, authentication, updating and dele…

I have completed the user creation, authentication, updating, and deleting user API.
After deleting crypto, I also Installed a package for hashing passwords better (bcryptjs). Furthermore, I left a detailed note on the user model. After signing in, I sent the user not just the token but the user details. I replaced the database URL with mine since Ayo's doesn't work for me.
I tested the app thoroughly using Postman and ensured everything was functioning properly.
Attention should now be drawn to Ads model API and Favorite API.
regards,
Yusuf O. Adeleke

Neatly done! Good job.


Remove erase_all function

Remove unimplemented erase_all function.
erase_all is a default features of flash-algorithm so we need to add default-features = false in order to skip defining it.
Also renamed the rust-toolchain file to rust-toolchain.toml, since the version without file extension is the old style: "If both files are present in a directory, the latter is used for backwards compatibility"
Resolves #15

Has this been tested with probe-rs? Can you paste a screenshot?

Algo was copy-pasted from build.sh into RP2040.yaml, can't use target-gen yet.

target-gen not working might be due to https://github.com/rp-rs/flash-algo/pull/14#issuecomment-1848689660

It definitely is. I've tested it with the extra linker keep directives and it works.
The firmware size does grow substantially though, so we should keep it optional like in that PR.
I'm thinking of trying to fix that issue on the target-gen side as well (you don't need that info if updating an existing algo yaml, because it's already in the yaml)


caffemodel converted to iOS CoreML(.mlmodel) Model it's returning result in Multiarray

Recently I converted your caffemodel to CoreMode(.mlmodel) but whenever I put in Xcode it's automatically detect mlmodel file and it's giving me Multiarray result.

Same problem here - can someone please advise how to get the model working in Core ML?

@jay-mahadeokar

This works fine with CoreML:
Use: prediction.prob[1].doubleValue

@ravi-kotadiya @ycchen1 I think you can access the first element from that array and that is the result (double value).
Example:
let prediction = ...  // your model prediction
let prob = prediction.prob  // the MLMultiArray result, in your case may be other name
let precision = prob![0].doubleValue  // the result like 0.7512


Neural Coder enable backend support for intel_extension_for_transformers

Signed-off-by: Yao, Kai<EMAIL_ADDRESS>Type of Change
Neural Coder enable backend support for intel_extension_for_transformers
Description
Neural Coder enable backend support for intel_extension_for_transformers. Intel Extension for Transformers: https://github.com/intel/intel-extension-for-transformers
The enabling pattern is as follows:
from intel_extension_for_transformers import metric, objectives, QuantizationConfig
from intel_extension_for_transformers.optimization.trainer import NLPTrainer
# Replace transformers.Trainer with NLPTrainer
# trainer = transformers.Trainer(......)
trainer = NLPTrainer(......)
metric = metrics.Metric(name="eval_f1", is_relative=True, criterion=0.01)
objective = objectives.performance
q_config = QuantizationConfig(approach="PostTrainingStatic", metrics=[metric], objectives=[objective])
MODEL_NAME = trainer.quantize(quant_config=q_config)

We enable the backend support in two parts:

Change Trainer to NLPTrainer while defining the trainer, according to intel_extension_for_transformers document
Add API code lines, according to intel_extension_for_transformers document

Note that since Neural Coder is a one-click no-code solution, we default apply Post-Training Dynamic and eval_f1 in this case to avoid confusion, and we do not provide user-specific argument for this feature as of now.
Expected Behavior & Potential Risk
enable backend support for intel_extension_for_transformers , no risk
How has this PR been tested?
locally
Dependency Change?
no

@WenjiaoYue could you help add PythonLauncher for spelling? Thanks


[wip] Make go a conda compiler

Goals:

To cross compile go code by using the compiler and target_platform tags.
Update recipe to  use conda-build's 3.x capabilities

Todo:

[x] Find sufficient conditions for recipe to work.
[ ] Find necessary conditions for recipe to work.
[x] Rebase/Squash before asking for review
[ ] Check @isuruf's fixes to conda-smithy
[ ] Request change to conda smithy linter so that multiple source files do not show up as an error

Hi! This is the friendly automated conda-forge-linting service.
I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.
Here's what I've got...
For recipe:

The "source" section was expected to be a dictionary, but got a CommentedSeq.
The recipe must have some tests.
The "source" section was expected to be a dictionary, but got a CommentedSeq.

@conda-forge-admin, please rerender

@isuruf,
there is a bug on the code that merges the conda_build_config.yaml files. I have an entry called go arch where the value amd64 is repeated 3 times but when conda-smithy  rendered the value amd64 only shows up once.

@conda-forge-admin, please rerender

Rerendering with https://github.com/conda-forge/conda-smithy/pull/786 works for me

It doesn't work for me now. Weird

I'm temporarily hard-coding it to amd-64 and removing the variant until that issue is fixed.

You can remove the variants using jinja for loops, so this issue won't be there.

It looks like it also alphabetized the entries, which does not play well with zip_keys.

Updated the conda-smithy PR. Can you check now?

Hi! This is the friendly automated conda-forge-linting service.
I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.
Here's what I've got...
For recipe:

The "source" section was expected to be a dictionary, but got a CommentedSeq.
The recipe must have some tests.
Selectors are suggested to take a <two spaces>#<one space>[<expression>] form. See lines [29]
The "source" section was expected to be a dictionary, but got a CommentedSeq.

Hi! This is the friendly automated conda-forge-linting service.
I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.
Here's what I've got...
For recipe:

The "source" section was expected to be a dictionary, but got a CommentedSeq.
The recipe must have some tests.
The "source" section was expected to be a dictionary, but got a CommentedSeq.

I don't understand what the problem was that necessitated @isuruf PR.  What were the loop variables, and what was zip_keys set to?  How did you want it to behave, and how was it actually behaving?
I think @isuruf has fixed it, but I'd like to understand how it went wrong.

What I am trying to build is

go-core with build and host platform equal. This is essentially the same as the previous go library except for go stdlib.
Three cross compilers with precompiled go stdlib

go_linux-64
go_osx-64
go_windows-64

My first attempt to do that with a conda_build_config.yaml file looked like this:
goplatform:
- linux-64
- osx-64
- windows-64
goos:
- linux
- darwin  # this is not a typo
- windows
go arch:
- amd64
- amd64
- amd64
zip_keys:
- - goplatform
  - goos
  - goarch

After some issues started coming up, I realized that for this case I could just set go_arch: amd64 and that would be sufficient.

Hi! This is the friendly automated conda-forge-linting service.
I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.
Here's what I've got...
For recipe:

The "source" section was expected to be a dictionary, but got a CommentedSeq.
The "source" section was expected to be a dictionary, but got a CommentedSeq.

@isuruf, when you get a chance can you check why conda smithy rerender is still not correctly merging with my recipe's conda_build_config.yaml file?
Please look at 3d1d1e920dcc615879618c2eb9f7b7a95255825e for what I needed to change by hand.

@sodre, can you try https://github.com/isuruf/conda-smithy/commit/630463d262023c4f814d314f1555a47e1b615442 ?

@isuruf, conda-smithy was a little flaky...

The version I committed worked. It reordered the zip_keys, which I don't think is an issue.
It generated a version where the values were repeated multiple times.
It generated a version of win_.yaml without any zip_keys, i.e. including compiler_{c,cxx}.
It generated a version of win_yaml without my zip_keys in which case the conda_goos section was sorted.

@isuruf , I take that the version that I committed works back. The files look fine visually, but the generated zip_keys are not being accepted by conda-build 3.

@nehaljwani, it looks like most build time issues have been fixed. Would you mind reviewing the PR to see if everything is okay with you?

ping @nehaljwani, can you take a quick look at this recipe to see if it is still okay with you?

@sodre Could you please rebase this and also add yourself and @scopatz as maintainers?

@nehaljwani no problem, and sorry for so many updates. Getting everything ready for the compiler took a lot of trials.

@conda-forge-admin Please re-render

Hi! This is the friendly automated conda-forge-linting service.
I was trying to look for recipes to lint for you, but it appears we have a merge conflict.
Please try to merge or rebase with the base branch to resolve this conflict.
Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug.

I have rebased this PR over master (1.10.3).

Friendly nudge @sodre  :sweat_smile:
Please don't back out after such wonderful work!

@conda-forge-admin, please rerender

Hi! This is the friendly automated conda-forge-webservice.
I rerendered the feedstock and it seems to be already up-to-date.

The TravisCI system is busted at the moment because of some bad Image config.
See: https://www.traviscistatus.com/incidents/r4y5703yt80x

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@nehaljwani, this should be ready for final review and merge when the Travis issue is fixed.

Thank you very much @sodre !
I'll try to merge this as soon as I know that the travis issue has been fixed.

Personally have had issues with binary prefix replacement in go in the past (e.g. crashes and other strange errors). Would lean towards using the activation scripts instead.

The linux and macOS CI runs went fine, but the windows CI run broke. Even on re-triggering it twice, it didn't succeed. I'll need your help here, @jakirkham . Builds go fine, but the upload cries.
The two weird errors I have seen so far are:
[ERROR] File "C:\bld\win-64\go-core-1.10.3-h7ee7fc2_1.tar.bz2" does not exist

But it actually builds:
C:\bld\win-64\go-core-1.10.3-h22be3a3_1.tar.bz2

I wonder why the upload program is trying to use the wrong filename?
Another error was (which I believe is supposed to be intermittent):
PermissionError: [WinError 5] Access is denied: 'C:\\Users\\appveyor\\AppData\\Local\\Temp\\1\\tmpr2qe5wez\\binstar.token'

Documented the problem in an issue https://github.com/conda/conda-build/issues/3017


Improve types of declarative testing api, so that rename refactoring will automatically update tests as well

Description
Currently, when using for example the hasState declarative function:
When(host).hasState({ someProp: 42 })....

Renaming the property someProp in the host component will not update the test case but only mark it as error, which is unfortunate as it requires additional manual work.
Proposed solution
Update typings in a way that the rename refactoring will automatically update test cases as well.

e.g. Instead of Record<keyof T, any> the type T only would enable the refactoring to update also the tests.

Alternatives considered
No response

Part of version 2.1.4-alpha.25


Release 1.1.1, see CHANGELOG..md for details

My last PR (1.1.0) didn't go through all the testing, and of course the testing revealed the faults in handling cookies. 1.1.0 wasn't breaking, but not providing the intended benefits.
This PR corrected the issue. I also added the documentation of how to test in a load-balanced environment, so it can be repeated easily.

I also have a few questions.

I noticed some naming inconsistency, such as "get_target_platform_details", vs "get_account". Is there a specific reason? I followed the first convention with "get_safe_details" since I saw another example "get_logged_on_user_details", and felt the name is more explicit. It would be good in the long term to standardize on one convention.
Another is the documentation. "accounts.rst" uses "autofunction", but "accountgroup.rst" does not. Did I read it correctly or misunderstood it?

Thanks

I was also able to test the "keep_cookies" features with an F5 load balancer.

@gleveille-lbp  - Can you take a look at the PR and provide feedback? Thanks.

I also have a few questions.

I noticed some naming inconsistency, such as "get_target_platform_details", vs "get_account". Is there a specific reason? I followed the first convention with "get_safe_details" since I saw another example "get_logged_on_user_details", and felt the name is more explicit. It would be good in the long term to standardize on one convention.
Another is the documentation. "accounts.rst" uses "autofunction", but "accountgroup.rst" does not. Did I read it correctly or misunderstood it?

Thanks

Hi @ywei2017 , if you think it's confusing perhaps we could rename get_account to get_account_details and keep an alias for get_account. It would better follow the Cyberark's name
For the second point it's just a matter of time, i rewrited all the docstrings of accounts.py to be usable with autofunction, i will do the same for others file as soon as possible !

@ywei2017 Sorry for that, I will look your PR soon, i was struggling with some tests but now we should be fine.


async functions to not blindly await via isPromise

This is for performance. awaiting is more expensive than a Promise check

this is happening now


unsigned int unpacking

Resolves #993
TODO:

[x] remove signed_int references from core because it's broken
[ ] bump fc after merging https://github.com/bitshares/bitshares-fc/pull/64

Wrong destination.


Generic unions

Since base now uses Foldable basically everywhere would it not be a good idea to change unions for both HashMaps and HashSets to Foldable f rather than []?
Since the implementation is foldl' anyways there should be no performance difference.

Yes. I'd really rather get rid of unions and unionsWith, but a recent discussion on the libraries list shows that a number of people are quite attached to them.

Well, it turns out to be a rather common use case. I personally use it a lot in tree traversals for aggregating information from subtrees. However my trees are all Foldable or Traversable, as such it would be nice to have a Foldable constrained unions so I could call them directly on the tree rather than having to do unions . toList. Its just a little nicer

unions in containers takes Foldable, so we should probably do the same.

Sure... Should both use foldMap'?
On Sat, May 29, 2021, 11:41 AM Simon Jakobi @.***>
wrote:

unions in containers takes Foldable, so we should probably do the same.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/haskell-unordered-containers/unordered-containers/issues/185#issuecomment-850853281,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAOOF7MXEIHPQMAMYN3GAULTQEDI7ANCNFSM4EPUGBBQ
.

Sure... Should both use foldMap'?

If that would preserve the current semantics, yes.

We'd have to be careful to use the right order, but it should be fine.
Something like this, I think:
newtype Onion k v = Onion { scrunion :: HashMap k v }
instance (Eq k, Hashable k) => Semigroup (Onion k v) where
-- this is the spot we have to check for ordering
Onion t <> Onion u = Onion (union u t)
instance (Eq k, Hashable k) => Monoid (Onion k v) where
mempty = Onion empty
unions = scrunion . foldMap' Onion
We'll have to check that performance is ever better than just using foldl'.
On Sat, May 29, 2021, 11:49 AM Simon Jakobi @.***>
wrote:

Sure... Should both use foldMap'?
If that would preserve the current semantics, yes.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/haskell-unordered-containers/unordered-containers/issues/185#issuecomment-850854556,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAOOF7II7T5MJJNOLL7E7YLTQEEJ7ANCNFSM4EPUGBBQ
.


8x8 font is drawn as 9x8

I noticed pixfont.DrawString() draws the 8x8 font in 9x8 cells.
Is there an option to render the 8x8 font with 8-pixel width instead of 9-pixel width?
I am using the 8x8 font to create an atlas for opengl text rendering in an experimental Android game: https://github.com/udhos/fugo/blob/master/demo/invader/font.go
I think 8x8 cells would deliver a more realistic look for such a classic font. :)

I added a package-level var so you can do this using pixfont.Spacing=0 somewhere in your setup code. For simple stuff like this feel free to submit a PR in the future. Cheers!

It worked! Thanks!!


refactor: TypeScript rewrite

The greater version of https://github.com/guidojw/arora-api/pull/263

[x] migration
[x] services
[x] util
[x] entities
[x] structures
[x] jobs
[x] managers
[x] client
[x] better way of doing cron
[ ] commands

The fields of type Emoji in the TicketType and RoleMessage entities are commented due to the same named field containing the emoji name. This will be fixed in a later PR when those entities move to using the new Discord buttons.

Removed the boilerplate code for custom repositories + class-transformer because scopes are not needed in this project. Can just use relations: string[] here to include relations on querying data from the database.

Jobs are still scheduled on a per guild basis, might revisit later.

Switched ChannelEntity.toLinks and .fromLinks so probably have to remove them using the commands before merging this.


Hosting your dataset on the Hugging Face Hub

Hi @sahil280114, this is a really cool project and great job augmenting the Alpaca dataset with code instructions!
Would you be interested in hosting this on the Hugging Face Hub (https://huggingface.co/datasets)? The Alpaca dataset is also hosted there (link) and your version would be of wide interest to the community, especially since many people have noted the Alpaca models can't code very well :)
If that sounds interesting, you just need to create a new dataset repo and upload your code_alpaca_20k.json file through the UI. For more details, you can check out our docs here
PS LLaMa is now included in the main branch of transformers, so you may also want to update your training instructions :)

Hey! Love using HF datasets so makes sense to upload this, I've setup the repo and uploaded here . Will update readme with instructions on how to use it soon.

This looks awesome! Thanks for sharing it with the community 🤗


The code block obscures the previous line of text

I like this theme very much. Thank you very much.
Currently learning the JavaScript and while taking notes I found that：
The code block obscures the previous line of text.

Thanks, I have some time in about 1-2 Weeks to go through all reports and try to fix them.

Fixed in 0.3

Thank you very much.


On iPad when closing a tab with address bar input in focus, the input gets carried over to previous tab's address bar

App version: 7.64.2
Device model: 2020 iPad Pro 11"
iOS version: iOS 15b4
Steps to reproduce the bug:

Open tab 1, load a website
Tap the "+", open tab 2
Load a website in tab 2
Tap the address bar of tab 2
Close tab 2

Expected behavior:  I get tab 1, address bar loses focus and has tab 1 url, keyboard is dismissed
Actual behavior:  I get tab 2, address bar retains focus, has tab 2 url, keyboard is present.

Please see the video demo:
https://user-images.githubusercontent.com/68649232/127742277-acb94ae4-935b-4ed4-8f49-056416d284e7.MP4
This behavior is also incorrect if tab 2 is a blank tab, but since it's blank it carries over the empty string to previous tab's address bar:
https://user-images.githubusercontent.com/68649232/127742300-c8076b64-dded-446a-a489-2cdf3c3514f2.MP4
Please let me know if you'd like me to do a PR and fix this.

@romanrudyy Great spotting, we'd very much welcome a PR for this if you're up for it! If not, I have capacity for fix this bug on Friday this week. 🙂

hey @samsymons, I won't be able make it for Friday as I'm stacked on work, but I could give it a go on Sunday, if that sounds good 🙂


Bump snow version to v0.1.6

Issue #, if available:
Description of changes:
Testing (if applicable):
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/lgtm
/approve


add TileDB-VCF

added TileDB-VCF to summary of alternatives

@dpark01 can I get a merge thx

Right sorry this dropped in while I was out!


Update single node setup.

Use the vagrant generated public key when connecting to the VM with
ansible.

Update hosts file to use ip addresses instead of names. This obviates
the need to use the hostupdater plugin which requires root permissions
to update /etc/hosts

Use an ansible.cfg file to make the ssh connection for ansible
disable host key checking and to not write the VM's host key to
known_hosts file.

Remove the destroy trigger in the Vagrantfile used to purge the
known_hosts file as this is no longer needed.

Signed-off-by: Arunabha Ghosh<EMAIL_ADDRESS>

Why not make the same updates on multi-host too?

That's hard to replicate completely for multi machine. The private key location will change depending on the machine in use. Made the other changes though.

Ok. LGTM.


606 - Get AP Capacity endpoint

Add endpoint to get AP capacity per day, from today until the furthest-in-the-future Booking or Lost Beds

 Write API endpoint to get the capacity of an AP


Add ability to diff masters and cross products

Currently, we can only compare fvar instances. This PR allows users to diff the masters in a vf and also designspace cross products. Still need to update the readme.
@simoncozens do you mind checking this?

Thanks Simon. Once we're back from AtypI, I/we should work on making the reports smaller and more elegant. I'm thinking of only showing the TTJ stuff for the default master. The deltas will just have the word diffs. Also, more testing and refinement on the diff stuff.


[Enhancement] Tag ASEA deployed config rules

ASEA tags most deployed resources with Accelerator and AcceleratorName containing {AcceleratorPrefix}
it does not currently tag config rules
means config rule SCPs need to protect all config rules and not just ASEA managed config rules

ASEA not working on new features see README.


Add namespace create delete,persistentvolumeclaim create delete

Volume create stub
Add implementation for namespace creation deletion
make it build
namespace tests pass
Fix creation of PVC
fix bulid
Update job test volume
Typos

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 69 (0.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-5.5%) to 50.144%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

pkg/kubelayer/kubelayer.go
0
69
0.0%

Totals

Change from base Build<PHONE_NUMBER>:
-5.5%

Covered Lines:
348

Relevant Lines:
694

💛  - Coveralls


Add an option to pass a word for highlight

hi there,
Can you please add an option to pass a word/regex to highlight instead of the exact word under the cursor?
TIA.

@justrajdeep this is a really good idea, I've done this with a quick update. You and update and use the following key mapping
map <silent> <leader>r :lua require'mywords'.hl_toggle_regex()<CR>

Thanks @dwrdx  for this fix. Really appreciate it.


[Algo] Quick Sort [Elixir]

Hello @paawan01 !
What do you think about adding algorithms written in Elixir ( https://elixir-lang.org/ )

GitMate.io thinks possibly related issues are https://github.com/NITSkmOS/Algorithms/issues/146 ([Algo] Quick Sort [C]), https://github.com/NITSkmOS/Algorithms/issues/147 ([Algo] Merge Sort [C]), https://github.com/NITSkmOS/Algorithms/issues/145 ([Algo] Selection Sort [C]), https://github.com/NITSkmOS/Algorithms/issues/149 ([Algo] Merge Sort [Java]), and https://github.com/NITSkmOS/Algorithms/issues/281 ([Algo] Merge Sort (Java Implementation)).

Hi @denysmedynskyi !
I haven't used Elixir any time so I'm not too sure about that.
Besides @sangamcse would be the better person to ask whether to include in this repo or not.

Hey @denysmedynskyi assigns this task to me.


Support localstack connectivity by providing an endpointUrl parameter to the clients

Thanks for providing this SDK.
I would like to perform local development using the localstack docker image.
The AWS CLI provides an option to provide an -endpoint-url.  This is extremely useful for running things locally and in a CI environments for integration tests.
I have attempted to create an EndpointResolver and overwrite the URL as follows:
class MyResolver : EndpointResolver {
    func resolve(serviceId: String, region: String) throws -> AWSEndpoint {
        return AWSEndpoint(endpoint: Endpoint(host: "localhost",
                                              port: 4566,
                                              protocolType: .http))
    }
}

Then pass this into the DynamoDbClient as follows:
let dynamoDbClient = DynamoDbClient(config: try DynamoDbClient.DynamoDbClientConfiguration(
            endpointResolver: MyResolver(),
            region: "us-west-1"))

However, it looks like TLS is required even though I set the protocol to .http.  Let me know if there is a way to get around this.
[ INFO ] Connection was acquired to: Optional("http://localhost:4566/?")
client(ClientRuntime.ClientError.deserializationFailed(ClientRuntime.SdkError<AWSDynamoDB.PutItemOutputError>.client(ClientRuntime.ClientError.networkError(AwsCommonRuntimeKit.CRTError.crtError(AwsCommonRuntimeKit.AWSError(errorCode: 1029, errorMessage: Optional("TLS (SSL) negotiation failed")))), nil)), nil)

Community Note

Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
If you are interested in working on this issue, please leave a comment

Describe the Feature
The ability to set an endpointUrl directly in the clients:
let DynamoDbClient(endpointUrl: "http://localhost:4566", region: "us-west-1")

Is your Feature Request related to a problem?
There is no way to perform local development or run integration tests without connecting to AWS.  The creates brittle development and test environments.
Proposed Solution
N/A
Describe alternatives you've considered
Provide the endpointUrl in the Config instead.
Additional Context
Without this feature, it requires every developer to have an instance of the AWS service for their own development and testing purposes.  LocalStack gives the developer the ability to run locally without network connectivity.

[ ] I may be able to implement this feature request

Hello @ganeshnj ,
Thank you very much for your submission. We really appreciate your collaboration and feedback. This bug has been added to our current team backlog. I will post an update here as soon as we solve this issue.
Thank you very much for your time and contribution.
Sincerely,
Yasmine


Removal of AWS Credential check

It's causing a conflict with pre-commit checks. Seems like it's searching for/requiring AWS credentials instead of alerting when they're found.

No needed with --allow-missing-credential added


How to get VuMark id

Hi, I am struggling to find the solution to this, I am not very familiar with objective-C++.
This library supports the generation of the id by the VuMark like the iOS Vuforia Samples does?
I can load successfully the VuMark dataset and display a scene kit scene, but I need to get that ID. How can I obtain it?
Thank you for advance.
Regards!

I was able to obtain de instanceId by adding some files of the VuMark and convert the VuforiaTrackableResult to VuMarkTargetResult and some other methods, was a little hard to me, but i finally achieve it. I am closing this issue.


Downgrade libraries to prevent clash.

This PR is not necessarily for merging. But this changes were required to make the RTE working on Superlist.
As the stream_chat library can not work with uuid right now, we need to lower down the versions of the libraries.
After all the necessary downgrades, I was able to run the tests by running the following command:
flutter test --no-sound-null-safety

All 55 tests passed with this approach.

@salihgueler this is good to know for future tests. Based on our conversation it looks like we can move forward with this package being null-safe and Superlist using a slightly modified branch to downgrade dependencies. If that works for you, let's go ahead and close this PR and we can keep in mind the test command if we ever need it.

Of course, but let's keep the branch for the reference :)


Expand "Compiler Args" to "Compiler Arguments"

One of the Dafny settings in the IDE is called "Compiler Args". I think the "Args" is an unnecessary abbreviation that is better spelled out as "Arguments".
Also, it says compiler arguments. The explanatory text also mentions the compiler, but it could be nice if the message would say something along the lines of "These arguments are used when you ask to compile your code. These settings are not used by the background verifier."  For example, I wasn't sure if perhaps "compiler" referred to the entire tool, so I had tried to use /functionSyntax:4. I then discovered this does not work. But then it would be nice to know if or how I could add options to the verifier. Even saying "(Sorry, there's no way to give arbitrary options to the verifier.)" would be nice, I think.

For the second part, we split the arguments into two, one for running and one for the background verifier. That means you can have --function-syntax:4 for both now !
For the first part, although I agree it would be an improvement, renaming the option would be disrupting for users who were already relying on it. But perhaps it's fine. If @keyboardDrummer  agrees with the renaming, then I can perform it.

I'm wholly convinced by the presented Arguments.

I just looked at this again. I no longer see the "Compiler Args", but I see

Dafny: Language Server Launch Args
Dafny: Run Args

It would be nice to expand "Args" in both of these cases. In fact, more text would be help, along the lines of "Arguments pass to Dafny when running the program".


deprecated warnings in php8

I just upgraded to php8.1 and I am getting deprecated warnings in the source code:
PHP Deprecated:  Return type of SignRequest\Model\SignRequestQuickCreate::offsetExists($offset) should either be compatible with ArrayAccess::offsetExists(mixed $offset): bool, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /var/www/xxx.com/vendor/signrequest/signrequest-client/src/Model/SignRequestQuickCreate.php on line 1585
Deprecated: Return type of SignRequest\Model\SignRequestQuickCreate::offsetExists($offset) should either be compatible with ArrayAccess::offsetExists(mixed $offset): bool, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /var/www/xxx.com/vendor/signrequest/signrequest-client/src/Model/SignRequestQuickCreate.php on line 1585
PHP Deprecated:  Return type of SignRequest\Model\SignRequestQuickCreate::offsetGet($offset) should either be compatible with ArrayAccess::offsetGet(mixed $offset): mixed, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /var/www/xx.com/vendor/signrequest/signrequest-client/src/Model/SignRequestQuickCreate.php on line 1597
Deprecated: Return type of SignRequest\Model\SignRequestQuickCreate::offsetGet($offset) should either be compatible with ArrayAccess::offsetGet(mixed $offset): mixed, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /var/www/xxx.com/vendor/signrequest/signrequest-client/src/Model/SignRequestQuickCreate.php on line 1597
PHP Deprecated:  Return type of SignRequest\Model\SignRequestQuickCreate::offsetSet($offset, $value) should either be compatible with ArrayAccess::offsetSet(mixed $offset, mixed $value): void, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /var/www/xxx.com/vendor/signrequest/signrequest-client/src/Model/SignRequestQuickCreate.php on line 1610
Deprecated: Return type of SignRequest\Model\SignRequestQuickCreate::offsetSet($offset, $value) should either be compatible with ArrayAccess::offsetSet(mixed $offset, mixed $value): void, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /var/www/xxx.com/vendor/signrequest/signrequest-client/src/Model/SignRequestQuickCreate.php on line 1610
PHP Deprecated:  Return type of SignRequest\Model\SignRequestQuickCreate::offsetUnset($offset) should either be compatible with ArrayAccess::offsetUnset(mixed $offset): void, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /var/www/xxx.com/vendor/signrequest/signrequest-client/src/Model/SignRequestQuickCreate.php on line 1626
Deprecated: Return type of SignRequest\Model\SignRequestQuickCreate::offsetUnset($offset) should either be compatible with ArrayAccess::offsetUnset(mixed $offset): void, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /var/www/xxx.com/vendor/signrequest/signrequest-client/src/Model/SignRequestQuickCreate.php on line 1626
PHP Deprecated:  Return type of SignRequest\Model\Signer::offsetExists($offset) should either be compatible with ArrayAccess::offsetExists(mixed $offset): bool, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /var/www/xxx.com/vendor/signrequest/signrequest-client/src/Model/Signer.php on line 1489
Deprecated: Return type of SignRequest\Model\Signer::offsetExists($offset) should either be compatible with ArrayAccess::offsetExists(mixed $offset): bool, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /var/www/xxx.com/vendor/signrequest/signrequest-client/src/Model/Signer.php on line 1489
PHP Deprecated:  Return type of SignRequest\Model\Signer::offsetGet($offset) should either be compatible with ArrayAccess::offsetGet(mixed $offset): mixed, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /var/www/xxx.com/vendor/signrequest/signrequest-client/src/Model/Signer.php on line 1501
Deprecated: Return type of SignRequest\Model\Signer::offsetGet($offset) should either be compatible with ArrayAccess::offsetGet(mixed $offset): mixed, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /var/www/xxx.com/vendor/signrequest/signrequest-client/src/Model/Signer.php on line 1501
PHP Deprecated:  Return type of SignRequest\Model\Signer::offsetSet($offset, $value) should either be compatible with ArrayAccess::offsetSet(mixed $offset, mixed $value): void, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /var/www/xxx.com/vendor/signrequest/signrequest-client/src/Model/Signer.php on line 1514
Deprecated: Return type of SignRequest\Model\Signer::offsetSet($offset, $value) should either be compatible with ArrayAccess::offsetSet(mixed $offset, mixed $value): void, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /var/www/xxx.com/vendor/signrequest/signrequest-client/src/Model/Signer.php on line 1514
PHP Deprecated:  Return type of SignRequest\Model\Signer::offsetUnset($offset) should either be compatible with ArrayAccess::offsetUnset(mixed $offset): void, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /var/www/xxx.com/vendor/signrequest/signrequest-client/src/Model/Signer.php on line 1530
Deprecated: Return type of SignRequest\Model\Signer::offsetUnset($offset) should either be compatible with ArrayAccess::offsetUnset(mixed $offset): void, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /var/www/xxx.com/vendor/signrequest/signrequest-client/src/Model/Signer.php on line 1530

I am having the same problem.


🎉 release: v9.3.0

:tada: This PR is included in version 9.3.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


[FLINK-12249][table] Fix type equivalence check problems for Window Aggregates

What is the purpose of the change
This pull request fixes type equivalence check problems for Window Aggregates
background
Creating Aggregate node fails in rules: LogicalWindowAggregateRule and ExtendedAggregateExtractProjectRule if the only grouping expression is a window and
we compute aggregation on NON NULLABLE field.
The root cause for that, is how return type inference strategies in calcite work and how we handle window aggregates. Take org.apache.calcite.sql.type.ReturnTypes#AGG_SUM as an example, based on groupCount it adjusts type nullability based on groupCount.
analysis
There is no problem for non-window aggregate that return type turn to nullable if the call occurs within a "GROUP BY ()" query, e.g. in "select sum(x) as s from empty", s may be null.
This is also the behavior of common databases, such as mysql. The result of query "select sum(x) as s from empty" is a null output.
However, for window aggregate, there is no way to output null, as we don't know which window the null belongs to, so the result should be an empty result which means the result type is also not null.
solution
To fix this problem we can replace the current sum/avg SqlAggFunction to a self-defined one which avoids turning the "not null" to "nullable" for window aggregate. We can simply use a Rule to archive this.
Brief change log

Add a self-defined sum and avg SqlAggFunction which will not change return type to nullable even if the call occurs within a "GROUP BY ()" for window aggregates.
Add a Rule(ReplaceWindowAggregateFunctionRule) to change the sum/avg to the self-defined sum/avg(SqlWindowAvgAggFunction and SqlWindowSumAggFunction).
Add getSqlAggFunctionString in CommonAggregate. This method makes sure that the new self-defined sum/avg returns same string with sum/agg.
Add tests.

Verifying this change
This change added tests and can be verified as follows:

Added plan tests for flink, blink.
Added plan tests for batch, streaming.

Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
The serializers: (no)
The runtime per-record code paths (performance sensitive): (no)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
The S3 file system connector: (no)

Documentation

Does this pull request introduce a new feature? (no)

Hi @twalthr @dawidwys , would be great if you can take a look at the fix. Thank you.

Thanks for the PR @hequn8128
Please rebase the PR, let the CI passed.
@flinkbot attention @dawidwys @twalthr :)
Best, Jincheng

@sunjincheng121 Have rebased to the latest master. Thanks a lot for the advice.

Thank you for your work @hequn8128. Unfortunately I don't think this is a valid solution. It does not fix the root cause of the problem (that we deceive the logic of Aggregate with a false information about number of grouping fields. In case of Window aggregates it is always >= 1, because we group at least by window).
This just workarounds the problem for subset of aggregates. It does not fix it for:

SqlAnyValueAggFunction
SqlBitOpAggFunction
SqlFirstLastValueAggFunction
SqlMinMaxAggFunction
SqlNthValueAggFunction
and any other function that uses the information of org.apache.calcite.rel.core.Aggregate.AggCallBinding#getGroupCount for type inference.

@dawidwys Thanks for your comments. I think you are right.
We had a discussion just now. (with @godfreyhe @wuchong @sunjincheng121 ) We think that, to solve the problem fundamentally, the current window aggregate should not extend from org.apache.calcite.rel.core.Aggregate, instead it should extend from SingleRel. This makes sure the right semantics of window aggregate.
To correct this, the changes may be somehow very large as there are many existing window related rules. Also, this is a problem a long time ago and the probability of occurrence is relatively small.
Considering the reasons above, I think it would be good if we can fix this issue later after release-1.9?
What do you think? @dawidwys
Best, Hequn

I agree we should not treat this issue as a blocker for 1.9. It's rather uncommon as there are a few prerequisites for it to occur (only group by window, not null field for aggregate). I have one idea how could it be fixed I want to check, but overall we could change the priority to minor.

@dawidwys Thanks for your comments. I think you are right.
We had a discussion just now. (with @godfreyhe @wuchong @sunjincheng121 ) We think that, to solve the problem fundamentally, the current window aggregate should not extend from org.apache.calcite.rel.core.Aggregate, instead it should extend from SingleRel. This makes sure the right semantics of window aggregate.
To correct this, the changes may be somehow very large as there are many existing window related rules. Also, this is a problem a long time ago and the probability of occurrence is relatively small.
Considering the reasons above, I think it would be good if we can fix this issue later after release-1.9?
What do you think? @dawidwys @godfreyhe @wuchong @sunjincheng121
Best, Hequn

yes, it's a big issue to refactor WindowAggregate completely using solution3 mentioned in FLINK-12249. "Creating special window aggregate call function" is not a proper approach, how about users defined aggregate function? currently, i think we should make WindowAggregate does not extend from Aggregate in this pr, which had been validated in  a blink minor branch. and do the clean refactor after 1.9 ?

@dawidwys @godfreyhe @wuchong @sunjincheng121 Hi, I have updated the PR with the latest solution: Change the types to the inferred types in the Aggregate and then cast back in the Project after Aggregate.
I think this makes sure the right semantics and also brings minor changes to the under-released Flink.  The long term solution as we discussed in the jira ticket should be considered later after 1.9.
Would be great if you can take a look.
Best, Hequn

Thanks for the update @hequn8128!
I agree with @dawidwys @hequn8128  that this issue is not the blocker of 1.9 release.
And I like this workaround patch, in this way we can solve this issue for user in 1.9, and create a new JIRA for  the follow-up discussion.
What do you think?
Best, Jincheng

@sunjincheng121 Hi, thanks a lot for your suggestion. I have created a new jira(FLINK-13392) to further improve the WindowAggregate.
Best, Hequn

@godfreyhe Hi, thanks a lot for your review and suggestions. I have updated the PR according to your comments.
Best, Hequn


pagination change page not refreshing, please set to 25 or so by default

maybe we dont need pagination at all? a good filter and newest first or so like in organisations might be nicer? just a thought


Feat/afit migration

Soooo I was simply trying to make so that only the actor is Send and not the whole OnMountFuture since it was super annoying (the whole future needed to be send).
One thing led to another and ended up migrating to AFIT and use the embassy::task macro directly using your prior work.
Migrated all the tests  and examples to AFIT and removed the embedded-hal deps since they weren't used.
Also, this fixes the lifetime issue mentioned in this pr.
Finally, I updated embassy-sync to 0.2
As always, comments are welcomed!

Great amount of work, thanks! This will remove some functionality in ector though, with the removal of the associated lifetime for the Message type. This means that you can only pass owned/static items as messages.
Having gone back and forth through several designs, I think removing that is probably for the best. In the end, there are better options if you want to reference buffers.


Using hie-bios with an local dependency?

I am trying to edit the pandoc source code including a local copy of the source code of the pandoc-types repo which is a dependency of the pandoc repo. So I have the following directory:
pandoc/
- src/
- pandoc-types/
-- src/
...

I have adjusted the pandoc.cabal file and the stack.yaml accordingly and I am able to bild the project with either cabal build or stack build. But I cannot get the hover function to work for the local dependency of pandoc-types. Does the passage about internal libraries refer to local dependencies? Are these generally not supported or are they only not supported when using stack?
How would I have to configure my hie.yaml file in order for the language server to resolve my local dependencies correctly?

Hi!
Usually that should work, and if hover does not work, I think that is rather an issue of hls. Did you open a file from the pandoc-types dependency and checked if it works within the dependency?


Fix/projects

So when pulling projects from GitHub, the site syncs a project's homepage and repository fields to project.repo.url (this applies to the former if project.repo.homepage doesn't exist). Project.repo.url on a GitHub API call returns a link to the project's GitHub JSON data (ie https://api.github.com/repos/codeforexample/Test-Empty-Project). I changed the fields in the pull project function so that a project's homepage/repo fields link to the GitHub repo page (ie https://github.com/codeforexample/Test-Empty-Project) by calling project.repo.html_url.


Sync missing-doc-variants branch to master

I'd like to merge atsamd-hal #677, so I figured I'd help by bringing this branch up to speed withh the latest master.

Wow. looks like I made a merge instead of a rebase pull. This brought in way too many changes, sorry about that.


Typo in preprocessing.check_data_Quality

https://github.com/google/lightweight_mmm/blob/7aafa2917976891ab7b8cb200c85eacee1afd128/lightweight_mmm/preprocessing.py#L430
extra_feature_names need to be changed to extra_features_names to align with arguments

thanks for flagging this! We just pushed a new commit which should hopefully fix it.


Implement execution options for processor and prover

Pervious preparatory PR: #991
This PR makes use of the ExecutionOptions struct created in the previous PR, implementing cycle limit for the process and ability to initialize structs based on the expected cycles data.

One other comments: let's make sure we can compile with Rust 1.67 and later (e.g., using is_some_and() doesn't work for 1.67 as it was stabilized after).

I tested it with Rust 1.67, it worked well (we don't use is_some_and() anymore)
I tested VM on Fibonacci program with 2^20 cycles with 64 and 2^20 expected cycles. Results are 2236 ms with 64 expected cycles and 2057 ms with 2^20 expected cycles. These are the average values obtained for 10 runs on M2 MacBook Pro

I tested VM on Fibonacci program with 2^20 cycles with 64 and 2^20 expected cycles. Results are 2236 ms with 64 expected cycles and 2057 ms with 2^20 expected cycles. These are the average values obtained for 10 runs on M2 MacBook Pro

Is this for the whole proof, or just for trace generation? (I would expect only trace generation to be affected by this change).
Also, could you paste printouts of two representative runs of before and after?

One other thing: let's add the ability to specify execution options for example command in the CLI.

Is this for the whole proof, or just for trace generation? (I would expect only trace generation to be affected by this change).

It turned out that I tested it wrongly by using cli_test and not the binary file. It was time of the program execution. Do we have some tools to get only the trace generation time?

It turned out that I tested it wrongly by using cli_test and not the binary file. It was time of the program execution. Do we have some tools to get only the trace generation time?

Yes, once you build a binary using make exec, you can execute it via:
./target/optimized/miden example fib -n 200000

And one of the things it'll print out is trace generation time.


First version? 🤔

Any chance to make first release? 🤔

Hey @kloczek this is part of a GSoC project 2024. Therefore work will seriously begin end of this month. But I don't expect the first pre release to be available before end of June. And the final release will probably land end of the summer.

Do we have a plan for release and integration going forward?


Upgrade, improve security move to main catalog

Upgrade to latest release
Improve security by executing as user with privileges and not root
Switch to main catalog

If we own it, we should add the team annotation like this https://github.com/giantswarm/aws-operator/blob/master/helm/aws-operator/Chart.yaml#L8

Also please ensure we are following the advice here https://github.com/giantswarm/roadmap/issues/1436

We have the new labels in place too

PR in https://github.com/giantswarm/k8s-dns-node-cache-app/pull/15


For timestamp, command_zsh in parse_history(input_file):

I know you have put a lot of love into this @rsalmei . So I gave this tool a shot and got this error:
Traceback (most recent call last):
  File "/usr/local/bin/zsh-history-to-fish", line 8, in <module>
    sys.exit(exporter())
  File "/usr/local/lib/python3.9/site-packages/click/core.py", line 829, in __call__
    return self.main(*args, **kwargs)
  File "/usr/local/lib/python3.9/site-packages/click/core.py", line 782, in main
    rv = self.invoke(ctx)
  File "/usr/local/lib/python3.9/site-packages/click/core.py", line 1066, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/usr/local/lib/python3.9/site-packages/click/core.py", line 610, in invoke
    return callback(*args, **kwargs)
  File "/usr/local/lib/python3.9/site-packages/zsh_history_to_fish/command.py", line 72, in exporter
    for timestamp, command_zsh in parse_history(input_file):
ValueError: not enough values to unpack (expected 2, got 1)

Any ideas?

Hey @martisjm, yes I really have!
That's curious, it did work last time I checked, but now I've got the same error.
This tells me ZSH has probably changed something in a new version, and now sometimes includes empty lines in its history.
Well, I just fixed it! It is in https://github.com/rsalmei/zsh-history-to-fish/pull/5
And I even made some general command output improvements, and included official support for Python 3.9 and 3.10.
It's already released, just pip install -U zsh-history-to-fish and you're good to go!

Hey @martisjm, yes I really have!
That's curious, it did work last time I checked, but now I've got the same error.
This tells me ZSH has probably changed something in a new version, and now sometimes includes empty lines in its history.
Well, I just fixed it! It is in https://github.com/rsalmei/zsh-history-to-fish/pull/5
And I even made some general command output improvements, and included official support for Python 3.9 and 3.10.
It's already released, just pip install -U zsh-history-to-fish and you're good to go!

Well, still waiting for your answer, but I'm going to close this one.

Well, still waiting for your answer, but I'm going to close this one.


[inferno-router] Query string params support

Current router does not support querystring params.
I'm going to add it.

I need a redeem code to get stuff off google play


fix fix regression case

Proposed changes
Issue Number: close #xxx
Problem summary
Fix typo of test case.
Checklist(Required)

[ ] Does it affect the original behavior
[ ] Has unit tests been added
[ ] Has document been added or modified
[ ] Does it need to update dependencies
[ ] Is this PR support rollback (If NO, please explain WHY)

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall


DocsArchive-<IP_ADDRESS>Auto archive content

Please don't merge this PR until target archive repo PR https://github.com/OPS-E2E-PPE/docs-archive-test-target_9c09014d-74eb-4a27-9136-3d454a4426ba/pull/1 is merged into live branch.
Auto archive content to https://github.com/VSC-Service-Account/docs-archive-test-target_9c09014d-74eb-4a27-9136-3d454a4426ba.git

Docs Build status updates of commit c458a11:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error-GitBranchDeletedOrForcePushed]

Cannot sync git repo to specified commit because branch Release_Archive_master_2020-05-29-03-12-33 has been deleted or has been force pushed: fatal: couldn't find remote ref refs/heads/Release_Archive_master_2020-05-29-03-12-33

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


stage layer

Question 1: In which layer type conversion should be done? staging models or source models? Say contract A has 100 call/event models. If type conversion is done in staging models, we will have another 100 models (views likely).
Question 2: Is wyvern_data.sql a staging model (which should reside in dbt_ethereum_source) or a business model?
Question 3: If we need to create a staging table for each event/call table (e.g. punk_transfer / wyvern_data), which path should we put it in? If it resides in the same schema of source models, how can we deal with naming conflicts?
For Question 3, I have figured out a pattern for how we organize those models. It will make the naming of our tables shorter.
First stage: ethereum-etl
node API --[ethereum-etl]->  ethereum.traces
Second stage: dbt-ethereum-source
ethereum.traces   --[dbt enrich]->  ethereum_stg.traces --[dbt decode]-> ethereum_opensea.wvyern_call_atomicmatch --[dbt enrich]-> ethereum_opensea_stg.atomic_match
Third stage: dbt-datawaves
ethereum_opensea_stg.atomic_match --[dbt business]-> opensea.trades --[dbt business]-> nft.trades
In the business dbt repo, we don't add a chain name as a prefix or use it as a database name, and the project should be renamed into dbt_datawaves or something because the modeled data are chain free. (Considering that, we can further rename dbt-ethereum-source to dbt-ethereum.)
I notice dune v2 also takes this approach. They use column blockchain to differentiate chains. All chain records combine into one table.

If opensea.trades view is general, we may open-source another project dbt-opensea for ease of maintenance.
Since dbt requires models to have unique names. opensea.trades and nft.trades must be achieved using alias and overwriting custom_schema. But this will make test hard. Since we don't utilize target_schema field.
Another pattern I suggest is to use some alias like core or event:
ethereum_opensea_stg.atomic_match --[dbt business]-> event.opensea_trades --[dbt business]-> event.nft_trades

Modified some contents. I have moved ethereum_stg.traces to the first stage since it is more source-centric and closer to the existing pipeline.
First stage: ethereum-etl
node API --[ethereum-etl]-> ethereum.traces --[dbt enrich]-> ethereum_stg.traces
dbt-ethereum-source
ethereum_stg.traces --[dbt decode]-> ethereum_opensea.wvyern_call_atomicmatch --[dbt enrich]-> ethereum_opensea_stg.atomic_match
Third stage: dbt-datawaves
ethereum_opensea_stg.atomic_match --[dbt business]-> opensea.trades --[dbt business]-> nft.tradesa


Emojione: ASCII smilleys surrounded by newline characters fail

ASCII smileys (i.e. :D :) :( ;) ) will fail if they are not perfectly within whitespace. It should be Whitespace and Newlines.

Fixed by changing the ASCII Regex to:
(()("+ns.asciiRegexp+")())

Before it was:
((\\s|^)("+ns.asciiRegexp+")(?=\\s|$|[!,\.]))

i.e. match whitespace+start (?), match one of our ASCII smiley patterns, match whitespace+end+!+.

Meaning it must begin with whitespace, and end with whitespace or an ! or a dot. I briefly added a few more characters, like ?, since the list should be a list of common characters that follow. Alas, I wasn't able to make it correctly understand newlines, so I just axed it.

Create new bug reports for any common grammars that this breaks.


App crashes if there is no default 'Site'

There was an incident where a live site went down because GlobalDataMiddleware was unable to retrieve a Site object from the database, which then causes a cascade of further failures during request processing. See log attached.
The problem was resolved by ensuring that a default Site is configured i.e. at least one Site exists with the is_default_site field set to 'true'. It is unclear how there came to be no default Site in the database, but any Wagtail admin with the required permissions could create the conditions for this failure.
What can we do to try to avoid this in future?
default-site-bug.log.txt

Access (add/edit/delete) to “Site” in the wagtail admin panel is controlled via permissions in groups. For example a user with no delete permission for the site.

Wagtail itself works alright if no site is available and if something relies on the site wagtail gives a descriptive message that no site is configured. For example, all sites are removed and access to “Site Settings” in the admin panel gives an error.

Just like wagtail’s “Site Settings” IoGT relies on the existence of a default site (if no default site then use the first site—not implemented right now but can be which wagtail itself uses in some places) in multiple cases, for example, registration survey, global theme, etc.
The following are possible options

Don’t give access to anyone for “Site”. Only superusers will have access to it. This would be difficult to manage I imagine.
Add help text in the "Site" admin panel that explains the repercussion of deleting a site.
Don’t let anyone delete the site if only one is remaining.
Rethink and refactor the IoGT code to handle no-site scenarios.

I think we should be following Wagtail's lead i.e. assume that there may be no site at all and defend against that situation. Focusing first on the specific problem with GlobalDataMiddleware will fix the bug described by this issue. If there are other similar scenarios where a default site is assumed to always exist, then those should be addressed too, but maybe as a separate issue(s).
With the introduction of Wagtail Cache, it is also worth considering whether GlobalDataMiddleware is still required, and if not, then the fix might be to remove it.


bottom part of the fragment in the viewpager is clipped or cut of how to fix this

hello
i have a view pager with fragment in the scrollable , when i scroll down you can notics that the bottom part of the fragment in the viewpager is clipped or cut of how to fix this

Hello @xbahaa !
Well, let's see it. Can you please attach your layout xml and a screenshot of this behaviour?

https://youtu.be/tgz2fMPRBcc
in the bottom of the view some part of the item is cut of this a tabs and view pager in the viewpager
there fragment contains a recycle view how to fix this

Hey @xbahaa !
I didn't notice any cutout on the video... can you share the XML that is used to build the layout?

@xbahaa try changing the ViewPager like this:
<android.support.v4.view.ViewPager
    android:id="@+id/productDetailsViewPager"
    android:layout_width="match_parent"
    android:layout_height="match_parent"
    android:layout_marginTop="48dp"/>

It changes the layout_marginTop attribute to match the height of the AppBarLayout

thanks for you it;s work's like a charm, but way it's works that's the question?

@xbahaa it works because:

ScrollableLayout positions its children like vertical LinearLayout, but measures them like a FrameLayout

This is very important part to know when creating layouts with ScrollableLayout. So, if you put 2 views inside a ScrollableLayout with layout_height="match_parent" they both will have the same height (equal to the height of ScrollableLayout) but one will be placed under another.


Allow field layout to be determined for more types

Use the FormatterServices.GetUninitializedObject() method to get an instance of a specified type without having to invoke one of the ctors for the type; this allows the field layout to be determined for a wider set of types, e.g., types whose ctors check-then-throw for null arguments. An additional benefit of this change is that because the ctors for those types are no longer run, they no longer raise exceptions which cause the VS debugger to break (pause execution).
I built/ran the full test suite after making the change, and all of the tests passed except for one (an ISO8601-related test for TimeSpan) which doesn't seem related.

If this pull request is approved, it will fix issue #207 . The failing unit test is no issue, I've found that some of the tests fail randomly because of a precision error.

As explained in the issue, GetUnitializedObject has a performance penalty of around 11%. I see you're always using it when it's available. It might benefit performance to only call GetUnitializedObject when no parameterless constructor is available.

I strongly urge against this. In the spirit of correctness over performance, I suggest sticking to GetUninitializedObject(). Calling the constructor sometimes is more obscure, and could surprise the developer. More importantly, the behavior in question seems to be used even when serializing for the first time, if I remember correctly. When breakpoints are active, or there are other expectations on code [not] being hit, it is very disconcerting if a constructor is unexpectedly hit when serializing. When you serialize to string, you don't expect new instances of the classes in question to be constructed. And who knows - good practice or not, some constructors have side-effects.


CSS - newsletter button and course title hovers

Hello! I did the following changes:

[x] Fixed the newsletter button that was way off (Desktop)
[x] Added a soft hover animation to the course titles

--
I tried fixing the button on mobile but ran into a bunch of issues, so I could not fix that. If this project is going forward, I would love to give it a more detailed review at the CSS and its responsiveness in the future outside Hacktoberfest.
Have a great day 👍

(only on hover)

@all-contributors please add @maenad  for css

@maenad try fixing the mobile layout as well or you can come you with some new footer style too.

@all-contributors please add @maenad  for code


Throw if SSLParameters contains settings that are not supported by Re…

…ferenceCountedOpenSslEngine
Motivation:
We not support all SSLParameters settings so we should better throw if a user try to use them.
Modifications:

Check for unsupported parameters
Add unit test

Result:
Less surprising behavior.

@nmittler you may want to do the same in conscrypt

Cherry-picked into 4.1 (325cc84) and 4.0 (127f6e9)

@normanmaurer added it to the list in https://github.com/google/conscrypt/issues/31.  Thanks!


build: small cares fixes

Needed to get Lyft internal build working.

@lyft/network-team @htuch

LGTM.

@htuch if possible can you merge these 2 changes into your DNS PR when you reopen it. Then I can just close this one.

Will do.


Out of memory attempting to serialize data for transmission

Good evening,
During running 'run_ucm.m' with a dataset of 1,485 images (totalling 1.5 GB), an error occurred '' Out of memory attempting to serialize data for transmission ''
I have 8 GB RAM, 2 GB gpu and an i7.
Any solution please ? Thank you.
This is the code :
`% path to the directory containing images, which need to be segmented
img_dir = '/home/mansour/hala/SynthText-master/images/train';
% path to the mcg/pre-trained directory.
mcg_dir = '/home/mansour/hala/mcg-master/pre-trained';
imsize = [240,NaN];
% "install" the MCG toolbox:
run(fullfile(mcg_dir,'install.m'));
% get the image names:
imname = dir(fullfile(img_dir,'*'));
imname = {imname.name};
% process:
names = cell(numel(imname),1);
ucms = cell(numel(imname),1);
%parpool('AGLocal',4);
N = numel(imname);                                                                                parfor i = 3:N
fprintf('%d of %d\n',i,numel(imname));
try
im_name = fullfile(img_dir,imname{i});
im = imread(im_name);
catch
fprintf('err\n');
continue;
end
im = uint8(imresize(im,imsize));
names{i} = imname{i};
ucms{i} = im2ucm(im,'fast');
end
save('ucm.mat','ucms','names','-v7.3');`

this is the code :
`% path to the directory containing images, which need to be segmented
img_dir = '/home/mansour/hala/SynthText-master/images/train';
% path to the mcg/pre-trained directory.
mcg_dir = '/home/mansour/hala/mcg-master/pre-trained';
imsize = [240,NaN];
% "install" the MCG toolbox:
run(fullfile(mcg_dir,'install.m'));
% get the image names:
imname = dir(fullfile(img_dir,'*'));
imname = {imname.name};
% process:
names = cell(numel(imname),1);
ucms = cell(numel(imname),1);
%parpool('AGLocal',4);
N = numel(imname);                                                                                parfor i = 3:N
fprintf('%d of %d\n',i,numel(imname));
try
im_name = fullfile(img_dir,imname{i});
im = imread(im_name);
catch
fprintf('err\n');
continue;
end
im = uint8(imresize(im,imsize));
names{i} = imname{i};
ucms{i} = im2ucm(im,'fast');
end
save('ucm.mat','ucms','names','-v7.3');`

The GPU memory seems to be insufficient.
Either use just the CPU, which will make it slower, or work on a GPU card with more memory.

Good morning,
I really appreciate your help.
Am trying to reduce my data set size to avoid the huge size of the output
matrix.
Thank you.
On Wed, Jul 19, 2017 at 9:18 AM, Ankush Gupta<EMAIL_ADDRESS>wrote:

The GPU memory seems to be insufficient.
Either use just the CPU, which will make it slower, or work on a GPU card
with more memory.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/ankush-me/SynthText/issues/62#issuecomment-316308861,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AacoyRx4qEyL4PQGYZkX0VF4PcCAWzvmks5sPbvZgaJpZM4ObiKi
.

Hello Ankush,
Can you take a look at this this
https://github.com/ankush-me/SynthText/issues/63.I really appreciate your
help.
Thank you a lot.
On Thu, Jul 20, 2017 at 6:21 PM, Ankush Gupta<EMAIL_ADDRESS>wrote:

Closed #62 https://github.com/ankush-me/SynthText/issues/62.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/ankush-me/SynthText/issues/62#event-1172542473, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AacoyYaR48a0gIwfuf3c4WUE4xD9L7sdks5sP4yYgaJpZM4ObiKi
.


Add code linter

As the code base grows large, a code linter like rubocop - https://github.com/rubocop-hq/rubocop will make it very easy to keep a hold of overall code quality by imposing strict checks.
Once added, the entire code-base will have to linted. Most of errors will get fixed by rubocop -a

I would like to self assign the issue! :smile:

Also eslint or prettier  for js code

Also, a .editorconfig can have to be added for uniform formatting.

I am not fan of linting whole code together as it will change git history without any functional change. But since this project is in early stage, it may be fine. @satu0king your thoughts please

If we don't want to lint the whole code-base at once, we can look into running rubocop only on those files that are being changed before every commit -
git ls-files -m | xargs ls -1 2>/dev/null | grep '\.rb$' | xargs rubocop
We can add this as a pre-commit hook.

@Ankitanvesh https://github.com/brigade/overcommit does this

Thanks :+1: , I'll look into them once.

@tachyons looks like you tagged the wrong Ankit :D

Oops, sorry

I am not fan of linting whole code together as it will change git history without any functional change. But since this project is in early stage, it may be fine. @satu0king your thoughts please

True, it will change git history without any functional change but it has to happen sometime! We can do it along with the refactor of #199. I would not want to do it now as it will raise unnecessary conflicts with everyone's PRs.

True, it will change git history without any functional change but it has to happen sometime! We can do it along with the refactor of #199. I would not want to do it now as it will raise unnecessary conflicts with everyone's PRs

Maybe we can explore of the option of still setting up codeclimate where we can view all the new offences and try fix most of them in each pr. This way add the new additions will be free of lint errors.


Database Connection to external database

Hello,
I just wanted to know whether it is possible to use this Trac plugin to connect to other databases than the project database. In the current version I understand that this feature is not supported. We are running some kind of tutorial in our Trac system and it would be awesome to use the plugin to allow the students to perform queries on an example database. For this I would need to specifiy a connection string and add an additional driver I guess...

This should work with standard sqlite, postgres, and mysql connection strings (as long as your local Trac instance has the requirements for the relevant database backend).  I updated the README to show how to configure it.

By the way, I do "pretty linking" of certain well-known columns within the project database (like revisions, tickets, wiki, etc.).  If you use an external database and that gets in the way, just select the "raw output" option and it will just render text.


Parent component not accessable

I'am trying to access methods defined on the main component, is it missing or it just the documentation is not completed !!
this should help with global methods for all items.

Try this way
<RecyclerView
      :options="options"
    ></RecyclerView>

data () {
return {
  options: {
        props: {
          $parent: this
        }
      }
  }
}

i think its not working, i couldn't find any related data inside item object, can you plz describe how to access $parent from (Item) scope.


Mutable function arguments when using the 'strategy' attribute.

Hi,
This code doesn't work because #[strategy(..)] apparently strips the mut keyword.
#[proptest]
fn test(#[strategy(1..2)] mut x: i32) {
  x = 0;
}

It would be nice to keep the mut keyword. My usecase is for generating a Vec and then removing duplicates.

Thanks for posting the issue.
I have fixed this issue in 55646548e7ca5557db54b0aa24913044682eeb82.

Awesome!

@frozenlib anything missing before a new version that includes this fix can be released? Anything you need help with?

There didn't seem to be any problems, so I have just released a new version.


[react-komposer-1.4.0 / meteor-1.3-beta.12] _reactKomposer.composeWithTracker is not a function

I get the following browser console error after upgrading react-komposer from 1.3.3 to 1.4.0:
Uncaught TypeError: (0 , _reactKomposer.composeWithTracker) is not a function
Downgrading react-komposer to 1.3.3 resolves the issue.
Meteor version: 1.3-beta.12.
OS: Windows 7 SP1 64bit
Browsers: Chrome 49, Firefox 45 and IE9

Updated a new version. Try it now.

Now I get another error:

This works for me. Try installing npm modules from the beginning.

Works for me too after
# rm /rf ./node_modules
# npm install

Many many thanks!
Wow, the power of opensource! - I've reported an issue and you've published a working release in just 7 minutes! Awesome!! And thanks again!

@staskorz ya, @arunoda  work so hard, good to follow him with meteor :+1:

Oka guys. Hope we can close this issue.


Created SVG version of YOURLS logo

Old raster logo painstakingly recreated as a vector graphic.

Man, that's truly awesome. I guess SVG graphics are totally cross browser compatible these days? Should we keep the .png as is (instead of replacing it as your commit does) and use the .svg instead in files, eg .HTML, .MD and such?

Yeah an svg will work in a regular img tag these days in nearly every
browser.
In retrospect... if some file somewhere is linking to the .png then it
would 404 rather than using the .svg so maybe total replacement of the png
isn't safe without checking other files first.
On Mon, Sep 2, 2019 at 3:58 PM ྅༻ Ǭɀħ ༄༆ཉ<EMAIL_ADDRESS>wrote:

Man, that's truly awesome. I guess SVG graphics are totally cross browser
compatible these days? Should we keep the .png as is (instead of replacing
it as your commit does) and use the .svg instead in files, eg .HTML, .MD
and such?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/YOURLS/YOURLS/pull/2548?email_source=notifications&email_token=AAPZLSFZFPTL2GLAAPZBGWLQHWLCRA5CNFSM4ITAL2FKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5WUIQY#issuecomment-527254595,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAPZLSEJGW3WVUHYUYGP5CTQHWLCRANCNFSM4ITAL2FA
.

--
Jay Holtslander
https://jay.holtslander.ca

maybe total replacement of the png isn't safe without checking other files first.

Indeed! That should be easy, though.

@JayHoltslander could you remove the first commit so we keep the .png along with the new .svg? This way we'll just use the newer file but won't break anything using the png one

Sorry about the slow reply. Will try to do this evening.

@ozh Rebased myself, since we've been waiting several weeks now. Ready to merge if you like, unless it bugs you to have the author & committer be different.


[Catalyst] Big Sur App Receipt not found

This issue is thrown in Big Sur beta 8 and validation fails
Error validating receipt: initializationFailed(reason: TPInAppReceipt.IARError.ReceiptInitializationFailureReason.appStoreReceiptNotFound)

Hello Chris,
Unfortunately, I won't be able to fix the issue until Big Sur is released.
Best,
P

@tikhop Understood Pavel.  It might now be the api but bugs in Big Sur.  The thing is really buggy still.   It doesn't see the receipt file thus the exception.
po FileManager.default.fileExists(atPath: appStoreReceiptURL!.path)
false

HI @chrisvanbuskirk,
I haven't updated to Big Sur yet, just curious whether you still have the problem.
Thanks,
P

Hi @aalenliang, based on your reply on developers forum it seems that you have the same issue here.
Am I right that Bundle.main.appStoreReceiptURL returns an invalid path and instead of ./../../sandboxReceipt you get ./../../receipt?

@tikhop Pavel.  Sorry for the late response.  I verified everything worked in the release version.  Thanks again for your hard work.

@tikhop, Yes, but I am running an iOS app on ARM, so it is not the same case.

I'm closing this.

@chrisvanbuskirk thank you — glad it works.