ODSP driver: blob read API returns cachable result only if epoch is in query params

If epoch is in headers, then not only this cases OPTIONS call, but SPO will not mark response as cachable, and we will pay the cost of fetching same immutable blob over and over.
As result we should generate an error telemetry event when that happens.

We need to confirm that with Marcelo (i.e. that description is actually accurate)

The options call will be removed when we will move to POST calls for these apis. Related to this issue:
https://github.com/microsoft/FluidFramework/issues/4811
For this we just want to log the telemetry error event.

Note - we should double check the claim I put here with Marcelo. He mentioned somewhere that "external" blobs might get unique IDs, and if so - epoch becomes irrelevant (as IDs can't be reused, even if file is restored - they are unique).
Not true for summary blobs though.

Yes, I talked to him. Attachment blobs are always cacheable as their id is function of their content. For summary blobs, the id is unique per document and per epoch. So In case we provide the epoch as query param, the result will be marked as cachable. For headers it will be not.

Does it mean that SPO will mark ALL request (including ones with headers/OPTIONS) for external blobs as cachable, but will mark request for summary blobs as cachable if headers/OPTIONS is not used?
I believe POST calls are not cachable, i.e. they always hit network, right?
So we have to have both GET and POST. Former - for cases that are cachable, like blob read with epoch on query param.
GET + options call is likely preferred over POST if the request is catchable for sure, as options and/or get can be cached.
Note - we do not know if ID is for summary blob or external blob in driver, so we have to error on safety. At the same time we know that most blobs (today - 100%, but that will change) will be external blobs, so if we know that all such request are cachable, then we would rather stick with GET.

"Does it mean that SPO will mark ALL request (including ones with headers/OPTIONS) for external blobs as cachable, but will mark request for summary blobs as cachable if headers/OPTIONS is not used?" - Yes


UVVM tag v2_v2024.03.08 breaks old tests

Hello,
I have tried to upgrade my tests to v2_v2024.03.08 however my tests weirdly crash without any info.
Tests worked fine with v2023.09.16.
I use VVCs for AvalonST and AXI stream in the tb, tests are run using vunit.
This is the verbose output:
Starting tb_lib.avst_to_axis_tb.avst_to_axis
Output file: /wrk/vunit_out/test_output/tb_lib.avst_to_axis_tb.avst_to_axis_686df3585fa779b4c96d68d9faffc1a12fc8d74e/output.txt
/wrk/UVVM/uvvm_util/src/rand_pkg.vhd:5507:24:warning: NUMERIC_STD.TO_SIGNED: vector truncated
        v_max_range := to_signed(C_MIN_RANGE, 33);
                       ^
/wrk/UVVM/uvvm_util/src/rand_pkg.vhd:5524:53:warning: NUMERIC_STD.TO_SIGNED: vector truncated
          v_ret_long      := to_signed(v_ret, 33) - to_signed(C_MIN_RANGE, 33); -- Remove offset
                                                    ^
/wrk/UVVM/uvvm_util/src/license_pkg.vhd:52:5:@0ms:(report note):

*****************************************************************************************************
 This is a *** LICENSED PRODUCT *** as given in the LICENSE.TXT in the root directory.
*****************************************************************************************************

/wrk/UVVM/uvvm_util/src/license_pkg.vhd:65:7:@0ms:(report note):

=====================================================================================================
=====================================================================================================
This info section may be turned off via C_SHOW_UVVM_UTILITY_LIBRARY_INFO in adaptations_pkg.vhd

Important Simulator setup:
- Set simulator to break on severity 'FAILURE'
- Set simulator transcript to a monospace font (e.g. Courier new)

UVVM Utility Library setup:
- It is recommended to go through the two powerpoint presentations provided with the download
- There is a Quick-Reference in the doc-directory
- In order to change layout or behaviour - please check the src*/adaptations_pkg.vhd
  This is intended for personal or company customization

License conditions are given in LICENSE.TXT
=====================================================================================================
=====================================================================================================

UVVM: ID_CONSTRUCTOR                     0.0 ns  CLOCK_GENERATOR_VVC,0          VVC instantiated.
UVVM: ID_CONSTRUCTOR_SUB                 0.0 ns  CLOCK_GENERATOR_VVC,0          Command queue instantiated and will give a warning when reaching 1000 elements in queue.
UVVM: ID_CONSTRUCTOR_SUB                 0.0 ns  CLOCK_GENERATOR_VVC,0          Result queue instantiated and will give a warning when reaching 1000 elements in queue.
UVVM: ID_CONSTRUCTOR                     0.0 ns  AVALON_ST_VVC,0                VVC instantiated.
UVVM: ID_CONSTRUCTOR_SUB                 0.0 ns  AVALON_ST_VVC,0                Command queue instantiated and will give a warning when reaching 1000 elements in queue.
UVVM: ID_CONSTRUCTOR_SUB                 0.0 ns  AVALON_ST_VVC,0                Result queue instantiated and will give a warning when reaching 1000 elements in queue.
UVVM: ID_CONSTRUCTOR                     0.0 ns  AXISTREAM_VVC,3                VVC instantiated.
UVVM: ID_CONSTRUCTOR_SUB                 0.0 ns  AXISTREAM_VVC,3                Command queue instantiated and will give a warning when reaching 1000 elements in queue.
UVVM: ID_CONSTRUCTOR_SUB                 0.0 ns  AXISTREAM_VVC,3                Result queue instantiated and will give a warning when reaching 1000 elements in queue.

I tried with a different simulator (NVC) and first it gave me a more
detailed error, stating there was not enough heap space. Enlarging the heap
solved the issue and the test ran fine.
However, I still can't get it to work in ghdl.
Il mar 7 mag 2024, 15:50 UVVM @.***> ha scritto:

Hi,
This seems a bit strange. Your test is failing even before any activity
has even started.
Which simulator are you using? And would it be possible for you to test
without using VUnit to check if the test case will finish? An alternative
you can use is HDLRegression
https://github.com/HDLUtils/hdlregression/tree/main if you want to
automate the test run.
Br,
UVVM
—
Reply to this email directly, view it on GitHub
https://github.com/UVVM/UVVM/issues/237#issuecomment-2098458296, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ACOSI7RTEC73FGB3XBD6R53ZBDL2LAVCNFSM6AAAAABHLA6LQ2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOJYGQ2TQMRZGY
.
You are receiving this because you authored the thread.Message ID:
@.***>

I think this is related to the Axistream VVC, but is a GHDL issue with the memory allocation, see https://github.com/ghdl/ghdl/issues/2644
You can try reducing C_MAX_TUSER_BITS from 64 to 32 in axistream_bfm_pkg as a temporary fix.

The constant C_MAX_TUSER_BITS in axistream_bfm_pkg has been reduced from 64 to 32, and moved to adaptations_pkg to be configurable by the user. This should solve the GHDL memory issue.


[WIP]Meter Analysis Language

These changes intend to intoduce a new language to analyze meter metrics. It's inspired from agent analyzer meter DSL, and add more features to support OC/Prometheus user cases.
The details can be found at mal.md.
The plan and status of this work is:

Document draft✅
Tag filter ✅
Binary operator ✅
Aggregation operation ✅
Function ✅
Downsampling ✅
Tweaking prometheus fetcher  ✅
OC fetcher  ✅
Self-observability ✅
Final document (WIP)

Self-observability is updated with the MAL based implementation. The below image shows the metrics are analyzed and stored as before.


Ability to connect Azure Analysis Services and Analysis Services as well

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Describe the solution or feature you'd like
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

Closing as duplicate of #1026


deinit doesn't remove the kvo observers

I ended monkey patching the deinit() function with this
    deinit {
        self.desub()

        reachability.stopNotifier()
        unobserve(ReachabilityChangedNotification, object: reachability)

        qualityAdjustmentTimer?.invalidate()
        qualityAdjustmentTimer = nil

        retryTimer?.invalidate()
        retryTimer = nil

        currentItem = nil
        enqueuedItems = nil
        player = nil

        endBackgroundTask()
    }

    private func desub() {
        for keyPath in AVPlayer.ap_KVOItems {
            player?.removeObserver(self, forKeyPath: keyPath)
        }
    }

You're right! Working on a fix right now.

@arun057
Setting these to nil in deinit:
currentItem = nil
enqueuedItems = nil
player = nil

didn't call their didSet while doing it in stop() works like a charm.
Fixed in 0.2.6 dd58037d7a7e922a3d79f439ed1bbdb0cd762023

Will test and report back

I was calling stop and changing mp3s when this happened, so not sure if this is the definite fix ( either way will test and report back )

Hi!
Based on my tests it worked pretty well like this. Please let me know if you face any issues, I'd be glad to help. In the meantime, I'll keep this issues closed and reopen if that doesn't fix your problem.

tested, looks good :) thank you very much

:+1:


[ServiceBus] prepare for June 2022 release

update CHANGELOG

API change check
API changes are not detected in this pull request.


tests: Bluetooth: llcp: migrate CTE request control procedure unit tests to new ZTEST API

Migrate LLCP unit tests in ctrl_cte_req to new ZTEST API.
Part of: #47002
Signed-off-by: Piotr Pryga<EMAIL_ADDRESS>

@cvinayak @kruithofa could you take a look?


docs(router): Minor content update for Heroes tutorial

Delete routerLinkActive from one of the earlier code examples as it is not relevant to what the user is trying to achieve at that point in the tutorial
When I was running through the tutorial, it said "Finally, add a dashboard navigation link to the template, just above the Heroes link.", but the code sample showed the routerLinkActive attribute added as well to the code. I was wondering "what's that for? why are both links being set as active?". I only realised what it was for later on in the tutorial in the section that describes the directive. It's not relevant to adding a new navigation link and can detract from the flow of the tutorial so it's better it only gets added in the bit that actually discusses it.

Not sure if this is valid right now. We changed the guide a bit and I think that this PR is not valid anymore.
/cc @brandonroberts

I have seen the recent PR (https://github.com/angular/angular.io/pull/1905) merged by @brandonroberts and feel that routerLinkActive was prematurely added to this first example in that PR. This PR is simply removing it from the first example, but leaving it intact on the later examples where it is more relevant.
Unless there has been a major refactoring which has not yet been committed to master, I would say this PR is relevant.

Before that snippet there is an explanation of what routerLinkActive is.

@Foxandxss You're quite right, I had updated the wrong ts file!
I still haven't managed to get the docs to run up locally due to npm install issues (node-sass on windows!! still trying to solve...), however I've updated the PR to apply the change to the correct ts file.

I see. You are right on this one, but the solution is not the appropriate one. If you modify that file, the routerLinkActive will disappear altogether.

I can't run it up locally yet but I just want to say there is a separate example file showing them added immediately after routerLinkActive is discussed. The path to the example file is toh-5/ts/app/app.component.3.ts. If you diff the 2 example files, the only difference is adding the routerLinkActive directive.

When we create a guide, we have two things:

The complete example, that can be run from the terminal or via plunker.
Extra files to show previous or alternative steps  (those .1., .2., etc)

That means, that the app.component.ts is the one that ends in the final example, so we can't use it to show a previous step.

Ok that makes sense. Thanks for explaining. I think I know what I need to do now. I will do my best to update the PR and run it all locally to ensure it works. Will let you know when it's done.

@massimocode I think its fine to be removed from there, but as @Foxandxss stated there needs to be a separate file provided for that example and the app.component.ts remain unchanged.

@brandonroberts @Foxandxss This has been updated now as per the feedback. Let me know if there's anything else to consider. I have managed to get everything running locally and it all looks good! Also fixed 2 x small spelling mistake in the logging of one of the build tools.

I am sorry sir, we changed that chapter quite a bit and apart from the typos, I am not sure if the other part is relevant. Could you please rebase this PR or open a new one? Thank you sir.


Scoverage integration

Code coverage report with scoverage and codecov integration with badge included. But it's needed to got to codecov and activate integration. Only repo admins can do it.

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@4fb65e2). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #18   +/-   ##
=========================================
  Coverage          ?   80.75%
=========================================
  Files             ?       17
  Lines             ?      665
  Branches          ?       33
=========================================
  Hits              ?      537
  Misses            ?      128
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4fb65e2...d4ff8b1. Read the comment docs.

Thanks, although I'm not 100% sold on the usefulness of code coverage plugins. But maybe others could chime in and say if they'd like to see this in the build?

The plugin provides nice 'colourful' feedback, but be warned - I am using it in one of my projects and some commits show as failed if it decreases the code coverage %.
Check here: https://github.com/atais/Fixed-Length/commits/master
Maybe it is configurable; I did not spend much time on it.


Does is support placement at the top of the screen?

If not, please consider adding, should not be hard.
If if does, please consider adding this information to the read me file.

it doesn't support yet. I can look into adding it if there is a special need to it.

I have added support for placing the menu at the top of the screen but it doesn't support the CoordinatorLayout Behaviour


Adding support for Microsoft Edge browser released with Windows 10

See next article: http://blogs.windows.com/msedgedev/2015/05/13/announcing-media-capture-functionality-in-microsoft-edge/

Edge just implements getUserMedia, so not stuff enough for rtcninja, which is supposed to be a complete wrapper/shim for getUserMedia and RTCPeerConnection.
Once Edge is here and adds RTCPeerConnection or ORTC we'll start working to support it. For now there is nothing to do.

Hi Iñaki,
ORTC is now available in Edge: https://blogs.windows.com/msedgedev/2015/09/18/ortc-api-is-now-available-in-microsoft-edge/
Have you already planned to integrate Edge into rtcninja?
There are not yet compatible video codecs between Edge and Firefox/Chrome (are there?). But audio only should work (?). It would also be nice to make audio calls between all browsers.
Tilman

There are not yet compatible video codecs between Edge and Firefox/Chrome (are there?). But audio only should work (?). It would also be nice to make audio calls between all browsers.

Right now audio calls are only supported because Edge implements H264.UC, which is not compatible with vanilla H.264, AFAIK.

Edge does not implemente WebRTC 1.0 but ORTC. Currently rtcninja is not supposed to support ORTC.
This will be studied in the future when things become more clear and stable.


repost TSC meeting minutes and recording post

Moved

Note sure about the validation failure, looks more like a missing environment config unless there is a typo that I don't see?

That's likely because it's run from a fork which has no access to the secrets, see https://github.com/nodejs/bluesky/issues/10

Looks like the fork repo has branch deletion settings, which is pending to resolve in https://github.com/nodejs/bluesky/pull/16 - in the mean time, I reopened https://github.com/nodejs/bluesky/pull/24 using a branch from this repo to get it done.


Imputed wang data errors when selecting gene

@thomaslchan : I think I had checked out the branch locally, and it worked well, so this is the result of some interaction with other PRs? Sorry to have merged it prematurely.
Describe the bug

Visit the demo site
Click on a gene in the sidebar
Screen goes blank with error in the log.

Environment:

Release or git hash: branch=master | hash=1869451 | date=2019-07-22
Browser: FF

Started this branch for work.
Some genes cause the problem... others do not: All the Blanks seem bad, and AKAP11 and CDC45 ...

Some cells are missing color assignments. When it works: Object.keys(cellColors).length === 192 ... on Blank-01: Object.keys(cellColors).length === 189

This code should be more robust...
but root problem may be vitessce-data.


(?) Get rid of the scss-bundle

Overview
The lib is quite old and I haven't found what for we are using it. Mb we can remove it?
Acceptance criteria

[ ] Check app
[ ] Remove npm package and scss-bundle.config.json
[ ] Test

You would need to check in what commit it has been added to understand why it is there.


Cast command does not allow hiding of particle effects

If a target is invisible, the particle effects from the "- cast" command call will still leave the mob (or player target) discernable via the particle effects.  When using the vanilla "/effect" command you can specify the same parameters exposed in the denizen one, but also the HideParticles parameter (see http://minecraft.gamepedia.com/Command#effect)
This functionality would be very nice to have - otherwise, "execute as_server "effect %player% minecraft:night_vision %time% 0 true"" becomes the call we have to use for invisible targets to actually remain truly invisible.

Works!! Thank you!


⚠ Bofrost.at has degraded performance

In 1c8a0a2, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 2374 ms

Resolved: Bofrost.at performance has improved in 57f35dd after 13 minutes.


google/flan-t5-xl - A100 80GB out of memory - LoRA

Hi
I have a model based on T5 but wrapped in another class as there are many customizations done at the header level for text classification use case. All in all, within a Model class I call
self.t5 = T5Model.from_pretrained(                 'google/flan-t5-xl',                 from_tf=False,                 config=self.config,                 cache_dir=self.cache_dir,         )
another object within the main model class is
self.header = MyCustomClass()
As it is a custom model I looked in the following places

https://github.com/huggingface/peft/blob/main/examples/sequence_classification/LoRA.ipynb
https://www.philschmid.de/fine-tune-flan-t5-peft
https://github.com/huggingface/peft/blob/main/examples/multilayer_perceptron/multilayer_perceptron_lora.ipynb

when I call the following
lora_config = LoraConfig(
        r=16,
        lora_alpha=32,
        target_modules=["q", "v"],
        lora_dropout=0.05,
        modules_to_save=["model.header.____", "model.header.____", ''....],
        bias="none",
        )
The point is I get the training parameters reduction from 2,7B to 17M. All is great but in terms of GPU memory consumption after initial 20GB of memory usage after the model is loaded when the model starts training it goes OOM. I would imagine that if the weights take around 20GB and an individual (any) 20M parameter model utilizes usually around 2GB of GPU memory. In total, the model training should stay way below 30GB.
Here are the key lines of what happens to the model.
model = MyModel() # inside there is self.t5 object
model = get_peft_model(model, lora_config)
optimizer = torch.optim.AdamW(model.parameters(), lr=LEARNING_RATE)
for i, batch in enumerate(train_dataloader):
        outputs = model(batch)
        loss = outputs[0]
        loss.backward()
        optimizer.step()
        optimizer.zero_grad()
What am I doing wrong? I don't even mention the XXL model that should fit in the A100 based on tutorial 2
BTW - in the third tutorial above I see that the count of trainable parameters does not match the expected number
trainable params: 56,164 || all params: 4,100,164 || trainable%: 1.369798866581922
but the number of updated ones in cell 16 and 17 is = 16000 x 3 + 160 + 4000 + 2 = 52,162 instead 56,164. Does any one know why?
The attached LoRA.py can easily run on a single A100 GPU though. Any thoughts?
lora.txt

All is great but in terms of GPU memory consumption after initial 20GB of memory usage after the model is loaded when the model starts training it goes OOM. I would imagine that if the weights take around 20GB and an individual (any) 20M parameter model utilizes usually around 2GB of GPU memory. In total, the model training should stay way below 30GB.

I'm not sure if your assumption holds. According to this estimator, I get 10 GB for loading google/flan-t5-xl and 41 GB for training it with float32 and Adam. This does not take batch size or LoRA into consideration, so the real value could be lower, but not necessarily below 30 GB. Even with most of the model parameters frozen, they'll still require memory for calculating the activations (though not the gradients).

in the third tutorial above I see that the count of trainable parameters does not match the expected number

Yes, there is a bug that for modules_to_save, we don't set requires_grad=False on the original weights, which means they are counted towards the number of trainable parameters even though they're not trained. This doesn't really matter in this case, and it's being addressed in #905.

@BenjaminBossan Thank you for keeping this conversation going. I really appreciate you further comments (help). Here are more details:

great tool (estimator). Bear in mind that in my case T5Model.from_pretrained(...) is a sub class of the bigger model. But let's agree we are more less on the same page on this one - my GPU has 80GB. I don't care whether it is 10GB or 20GB.
for the argument sake let's stick to your numbers - normal training e.g. BATCH_SIZE = 2 should be around 41GB (definitely 80GB is enough to train 2,7B model)
when I call LoRA I get like wrote before "The point is I get the training parameters reduction from 2,7B to 17M". So if the binary model based on your numbers is 10GB and on top of it LoRA is going to train a sub-model of 17M size I should still be able to train the model with BATCH_SIZE=2, float32 and Adam very easily.
Training 17M any model is for me around 2GB of GPU memory.
10GB of flan-xl (binary size) + 2BG of the 17M model but I go OOM on 80GB GPU.
Either I do something terribly wrong or there is a bug. That's my point.

Yes, I totally agree that a model of this size should be trainable on 80 GB. You mentioned that you made some custom changes. Although it is quite unlikely that they're the reason, it could still be insightful to compare those vs a "vanilla" flan-t5 on a similar task.

BTW - when I trained "google/flan-t5-large"
without LoRA - 74GB of GPU Memory, Trainable parameters around 800M

This feels really excessive, is this vanilla flan-t5 or also including your changes? Do you do anything else that might somehow influence memory usage, like using accelerate, mixed precision, quantization, etc.?

with LoRA - (everything else the same, configuration of LoRA as in the first post). The memory consumption is still pretty high 67GB. Trainable parameters less than 20M

Yes, it seems pretty high. Do you train a single LoRA adapter or are there multiple? Could you try a test with a non-adaptive optimizer like SGD?

Thank you @BenjaminBossan  for all the info. In simple terms, I found the problem, it is the size of the input window that through T5 implementation changes. Most of the demo use cases you guys do are based on 128 or 256 window size. When increased e.g. to 2000 it pretty much explodes. Thanks for all your help.


chore: deduplicate subDomainName generation logic in tests

What this PR does / why we need it:
There were a lot of subdomain generation implementations in the tests, now it is centralized. (part of #4128)
Release note:

/release-note-none

/kind chore

/kind cleanup

/approve
/ok-to-test


Refine exception handling about StreamClosedError

Resolved  #157

Coverage decreased (-0.07%) to 71.629% when pulling 94150fa6cc90e7f8886794438d7c03818d417389 on refine-stream-closed-exec-#157 into 467955e13d500b1f43cee75f388813d8025af74d on master.

Coverage remained the same at 71.629% when pulling 675f245a5795002e0c22743599546356c8efa511 on refine-stream-closed-exec-#157 into 9be0af1063d15eda2867e96e3caa17ccc938985f on master.

Coverage decreased (-0.07%) to 71.597% when pulling 675f245a5795002e0c22743599546356c8efa511 on refine-stream-closed-exec-#157 into 9be0af1063d15eda2867e96e3caa17ccc938985f on master.

Merged, thanks.


Help infinity Listening for game integration calls...

I decided to run a test program, and there was such an endless loading, what should I do?

yes, I restarted Dota and the computer and the program, still an error, can we go to discord or another social network where they could help me please?

https://youtu.be/k5LvveWqV44 - in this video I showed the code, launch and availability of cfg

In your cfg file your specified port is 3000, but in your example program the specified port is 4000. Change the port in your cfg file to 4000 and everything should work.

If you use the latest release, it adds automatic GSI config file generation. That should resolve your issue as well.


Moving file in src mangles React (and other packages) import

Issue Type: Bug
I moved some of my files, and got React, jQuery, etc. in all files affected by path change mangled, like below:
import React from '../../../../Users/asokalov/AppData/Local/Microsoft/TypeScript/2.9/node_modules/@types/react/../../Users/asokalov/AppData/Local/Microsoft/TypeScript/2.9/node_modules/@types/react/../../Users/asokalov/AppData/Local/Microsoft/TypeScript/2.9/node_modules/@types/react';
VS Code version: Code 1.25.1 (1dfc5e557209371715f655691b1235b6b26a06be, 2018-07-11T15:43:53.668Z)
OS version: Windows_NT x64 6.1.7601

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-6820HQ CPU @ 2.70GHz (8 x 2712)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onnative_gpu_memory_buffers: disabled_softwarerasterization: disabled_softwarevideo_decode: enabledvideo_encode: enabledvpx_decode: unavailable_softwarewebgl: enabledwebgl2: enabled

Memory (System)
15.88GB (3.94GB free)

Process Argv
C:\Program Files\Microsoft VS Code\Code.exe

Screen Reader
no

VM
0%

Extensions (3)

Extension
Author (truncated)
Version

vscode-eslint
dba
1.4.12

tslint
eg2
1.0.33

debugger-for-chrome
msj
4.8.0

I had an extension for automatic import, and I was sure it was causing this behavior. After I switched it off, the problem is still there.


Retraining model costs too much time!

It is said in your paper that

We train our network using Adam optimizer with learning rate 2e-4 and batch size 20. The model converges in
approximately 2 days using 2 TitanX gpus for Tai-Chi-HD and VoxCeleb.

Actually in my experiment of VoxCeleb, I found it cost much longer. I can only run 10 epoch per day. So retraining with both of "vox-256.yaml" and "vox-adv-256.yaml" will cost almost one month! Is there something goes wrong with my settings?
I trained with your code and your configuration without any modification, except batch_size is set to 16 ，for larger batchsize will cause out-of-memory.
My Environment lists as below.
GPU:Tesla V100 * 2 ,each with 32GB memory
Pytorch 1.0

Are you using png data format?

Are you using png data format?

Are you using png data format?

yes！

Are you using png data format?

yes！

What is the naming of the files send an example and gpu utilisation?

What is the naming of the files send an example and gpu utilisation?

What is the naming of the files send an example and gpu utilisation?

file names:
id10001#7w0IBEWc9Qw#000993#001143
id10001#7w0IBEWc9Qw#001298#001705
id10001#7w0IBEWc9Qw#001709#001897
id10001#7w0IBEWc9Qw#002052#002158
gpu utilisation ranges from 5% to 100%

What is the naming of the files send an example and gpu utilisation?

file names:
id10001#7w0IBEWc9Qw#000993#001143
id10001#7w0IBEWc9Qw#001298#001705
id10001#7w0IBEWc9Qw#001709#001897
id10001#7w0IBEWc9Qw#002052#002158
gpu utilisation ranges from 5% to 100%

What is the naming of the files send an example and gpu utilisation?

file names:
|--train
|--id10001#7w0IBEWc9Qw#000993#001143
|--0.png
|--1.png
|--id10001#7w0IBEWc9Qw#001298#001705
|--0.png
|--1.png
|--id10001#7w0IBEWc9Qw#001709#001897
|--id10001#7w0IBEWc9Qw#002052#002158
gpu utilisation ranges from 5% to 100%

What is the naming of the files send an example and gpu utilisation?

file names:
|--train
|--id10001#7w0IBEWc9Qw#000993#001143
|--0.png
|--1.png
|--id10001#7w0IBEWc9Qw#001298#001705
|--0.png
|--1.png
|--id10001#7w0IBEWc9Qw#001709#001897
|--id10001#7w0IBEWc9Qw#002052#002158
gpu utilisation ranges from 5% to 100%

What is the naming of the files send an example and gpu utilisation?

file names:
|--train
|----id10001#7w0IBEWc9Qw#000993#001143
|--------0.png
|--------1.png
|----id10001#7w0IBEWc9Qw#001298#001705
|--------0.png
|--------1.png
|----id10001#7w0IBEWc9Qw#001709#001897
|----id10001#7w0IBEWc9Qw#002052#002158
gpu utilisation ranges from 5% to 100%

What is the naming of the files send an example and gpu utilisation?

file names:
|--train
|----id10001#7w0IBEWc9Qw#000993#001143
|--------0.png
|--------1.png
|----id10001#7w0IBEWc9Qw#001298#001705
|--------0.png
|--------1.png
|----id10001#7w0IBEWc9Qw#001709#001897
|----id10001#7w0IBEWc9Qw#002052#002158
gpu utilisation ranges from 5% to 100%

OK, naming seems correct. Did you change anything in configs, your images is 256x256?

OK, naming seems correct. Did you change anything in configs, your images is 256x256?

OK, naming seems correct. Did you change anything in configs, your images is 256x256?

All I changed lists as below:
frame_shape: [256, 256, 3]
id_sampling: True
pairs_list: data/vox256.csv    # I comment this
num_epochs: 1000
num_repeats: 7
epoch_milestones: [600, 900]   # set num_repeats to 7 and train 10X epoch， then I can make checkpoint more frequently.
batch_size: 16

OK, naming seems correct. Did you change anything in configs, your images is 256x256?

All I changed lists as below:
frame_shape: [256, 256, 3]
id_sampling: True
pairs_list: data/vox256.csv    # I comment this
num_epochs: 1000
num_repeats: 7
epoch_milestones: [600, 900]   # set num_repeats to 7 and train 10X epoch， then I can make checkpoint more frequently.
batch_size: 16

This is not a good idea to increase number of epochs, it did heavy saving after which reduce the training speed. Also did you specify --device_ids 0,1?

This is not a good idea to increase number of epochs, it did heavy saving after which reduce the training speed. Also did you specify --device_ids 0,1?

This is not a good idea to increase number of epochs, it did heavy saving after each epoch which reduce the training speed. Also did you specify --device_ids 0,1?

yes!
CUDA_VISIBLE_DEVICES=4,5 python -W ignore run.py --device_ids 0,1 --config config/retrain.yaml

This is not a good idea to increase number of epochs, it did heavy saving after each epoch which reduce the training speed. Also did you specify --device_ids 0,1?

yes!
CUDA_VISIBLE_DEVICES=4,5 python -W ignore run.py --device_ids 0,1 --config config/retrain.yaml

@AlanLu0808 I would check a couple of things:

Is GPU fully utilised? If not, find the bottleneck. It could be IO speed, slow CPU-GPU transfer etc.
Double check the dataset size. Just print(len(dataset)) and multiply by num_repeat. You should get an adequate number here.
Try increase batch size. For 32Gb of memory you should get something like 30 samples in batch.

@AlanLu0808 I would check a couple of things:

Is GPU fully utilised? If not, find the bottleneck. It could be IO speed, slow CPU-GPU transfer etc.
Double check the dataset size. Just print(len(dataset)) and multiply by num_repeat. You should get an adequate number here.
Try increase batch size. For 32Gb of memory you should get something like 30 samples in batch.


Cannot get data using javascript tooltips in deck.gl screen grid

A clear and concise description of what the bug is.
How to reproduce the bug

Go to maps deck.gl screen grid
Write code javascript in javacript tooltips generator
Example :
Function getData(d) {
d.object.extraProps[0].data.map(i, x => console.log(x)) }
Run code
See errror : data.map is not a function.
When log data d in function, i cannot see the data object

How to use javascript tooltips generator for get data from my field ?
Environment
Superset version 1.5.0

I think most users have the JS Tooltips feature turned off because of the security risks (perhaps not too scary of a risk, but a risk nonetheless). It might be worth digging back into a (very) old Superset SHA and seeing if you can find a working state for this feature. If you can, it's just a matter of git bisect to figure out where things might have gone sideways.

If you are able to find an older version/SHA where this worked, I might be able to help you with the diagnostic part.

Closing this as stale since it's been silent for so long, and we're trying to steer toward a more actionable Issues backlog. If people are still encountering this in current versions (currently 3.x) please open a new Issue or a PR to address the problem.


Bug: runSeeders throws with: The "path" argument is undefined

Versions

Node: Node 18
OS: AWS lambda

Reproduction
When executing runSeeders inside an AWS lambda function the following error is thrown:
{
  "errorType": "TypeError",
  "errorMessage": "The \"path\" argument must be of type string or an instance of URL. Received undefined",
  "trace": [
    "TypeError [ERR_INVALID_ARG_TYPE]: The \"path\" argument must be of type string or an instance of URL. Received undefined",
    "    at __node_internal_captureLargerStackTrace (node:internal/errors:496:5)",
    "    at new NodeError (node:internal/errors:405:5)",
    "    at Object.fileURLToPath (node:internal/url:1401:11)",
    "    at Object.<anonymous> (/node_modules/locter/node_modules/glob/src/index.ts:218:13)",
    "    at Module._compile (node:internal/modules/cjs/loader:1256:14)",
    "    at Module._extensions..js (node:internal/modules/cjs/loader:1310:10)",
    "    at Module.load (node:internal/modules/cjs/loader:1119:32)",
    "    at Module._load (node:internal/modules/cjs/loader:960:12)",
    "    at Module.require (node:internal/modules/cjs/loader:1143:19)",
    "    at require (node:internal/modules/cjs/helpers:121:18)",
    "    at _tryRequire (file:///var/runtime/index.mjs:1039:14)",
    "    at async _loadUserApp (file:///var/runtime/index.mjs:1055:16)",
    "    at async UserFunction.js.module.exports.load (file:///var/runtime/index.mjs:1093:21)",
    "    at async start (file:///var/runtime/index.mjs:1256:23)",
    "    at async file:///var/runtime/index.mjs:1262:1"
  ]
}

I must admit I'm at a loss here. I have no idea why this is failing in an AWS lambda context.
I can run the seed just fine via typeorm-extension/bin/cli.cjs (not using the lambdaHandler)

Additional Details
Lambda function:
import { runSeeders } from 'typeorm-extension';
import { AppDataSource } from './myDataSource';

export const lambdaHandler = async () => {
    if (!AppDataSource.isInitialized) {
        await AppDataSource.initialize();
    }

    await runSeeders(AppDataSource);

    return { statusCode: 200, body: 'Seeding completed successfully.' };
};

// myDataSource
export const AppDataSourceOptions: DataSourceOptions & SeederOptions = {
    type: 'postgres',
    ...
    // the error persists with or without seeds and factories props, so I'm thinking it's unrelated
}

export const AppDataSource = new DataSource(AppDataSourceOptions);

Steps to reproduce

Clone https://github.com/snebjorn/typeorm-ext-seed
Install Node, SAM CLI and Docker as described in the README
in the root of the repo run:

sam build
docker compose up
sam local invoke HelloWorldFunction

Observe the "path argument" error

What is Expected?
runSeeders should work.
What is actually happening?
$ sam local invoke HelloWorldFunction

Invoking app.lambdaHandler (nodejs18.x)
Local image is up-to-date
Using local image: public.ecr.aws/lambda/nodejs:18-rapid-x86_64.

Mounting ~\sam-app\.aws-sam\build\HelloWorldFunction as /var/task:ro,delegated, inside runtime container
START RequestId: d36f07db-c785-4381-af32-f6bb168c4730 Version: $LATEST
2023-08-24T08:26:25.873Z        undefined       ERROR   Uncaught Exception      {"errorType":"TypeError","errorMessage":"The \"path\" argument must be of type string or an instance of URL. Received undefined","code":"ERR_INVALID_ARG_TYPE","stack":["TypeError [ERR_INVALID_ARG_TYPE]: The \"path\" argument must be of type string or an instance of URL. Received undefined","    at __node_internal_captureLargerStackTrace (node:internal/errors:496:5)","    at new NodeError (node:internal/errors:405:5)","    at Object.fileURLToPath (node:internal/url:1401:11)","    at Object.<anonymous> (/Temp/tmpw3ob8r4s/node_modules/locter/node_modules/glob/src/index.ts:218:13)","    at Module._compile (node:internal/modules/cjs/loader:1256:14)","    at Module._extensions..js (node:internal/modules/cjs/loader:1310:10)","    at Module.load (node:internal/modules/cjs/loader:1119:32)","    at Module._load (node:internal/modules/cjs/loader:960:12)","    at Module.require (node:internal/modules/cjs/loader:1143:19)","    at require (node:internal/modules/cjs/helpers:121:18)","    at _tryRequireFile (file:///var/runtime/index.mjs:976:37)","    at _tryRequire (file:///var/runtime/index.mjs:1026:25)","    at _loadUserApp (file:///var/runtime/index.mjs:1055:22)","    at UserFunction.js.module.exports.load (file:///var/runtime/index.mjs:1093:27)","    at start (file:///var/runtime/index.mjs:1256:42)","    at file:///var/runtime/index.mjs:1262:7","    at ModuleJob.run (node:internal/modules/esm/module_job:194:25)"]}
24 Aug 2023 08:26:25,891 [ERROR] (rapid) Init failed error=Runtime exited with error: exit status 129 InvokeID=
2023-08-24T08:26:26.666Z        undefined       ERROR   Uncaught Exception      {"errorType":"TypeError","errorMessage":"The \"path\" argument must be of type string or an instance of URL. Received undefined","code":"ERR_INVALID_ARG_TYPE","stack":["TypeError [ERR_INVALID_ARG_TYPE]: The \"path\" argument must be of type string or an instance of URL. Received undefined","    at __node_internal_captureLargerStackTrace (node:internal/errors:496:5)","    at new NodeError (node:internal/errors:405:5)","    at Object.fileURLToPath (node:internal/url:1401:11)","    at Object.<anonymous> (/Temp/tmpw3ob8r4s/node_modules/locter/node_modules/glob/src/index.ts:218:13)","    at Module._compile (node:internal/modules/cjs/loader:1256:14)","    at Module._extensions..js (node:internal/modules/cjs/loader:1310:10)","    at Module.load (node:internal/modules/cjs/loader:1119:32)","    at Module._load (node:internal/modules/cjs/loader:960:12)","    at Module.require (node:internal/modules/cjs/loader:1143:19)","    at require (node:internal/modules/cjs/helpers:121:18)","    at _tryRequireFile (file:///var/runtime/index.mjs:976:37)","    at _tryRequire (file:///var/runtime/index.mjs:1026:25)","    at _loadUserApp (file:///var/runtime/index.mjs:1055:22)","    at UserFunction.js.module.exports.load (file:///var/runtime/index.mjs:1093:27)","    at start (file:///var/runtime/index.mjs:1256:42)","    at file:///var/runtime/index.mjs:1262:7","    at ModuleJob.run (node:internal/modules/esm/module_job:194:25)"]}
END RequestId: 3f1cbd2e-9f2e-4dbc-85e2-ce908b03c63e
REPORT RequestId: 3f1cbd2e-9f2e-4dbc-85e2-ce908b03c63e  Init Duration: 0.12 ms  Duration: 1606.12 ms    Billed Duration: 1607 ms        Memory Size: 512 MB     Max Memory Used: 512 MB
{"errorType": "TypeError", "errorMessage": "The \"path\" argument must be of type string or an instance of URL. Received undefined", "trace": ["TypeError [ERR_INVALID_ARG_TYPE]: The \"path\" argument must be of type string or an instance of URL. Received undefined", "    at __node_internal_captureLargerStackTrace (node:internal/errors:496:5)", "    at new NodeError (node:internal/errors:405:5)", "    at Object.fileURLToPath (node:internal/url:1401:11)", "    at Object.<anonymous> (/Temp/tmpw3ob8r4s/node_modules/locter/node_modules/glob/src/index.ts:218:13)", "    at Module._compile (node:internal/modules/cjs/loader:1256:14)", "    at Module._extensions..js (node:internal/modules/cjs/loader:1310:10)", "    at Module.load (node:internal/modules/cjs/loader:1119:32)", "    at Module._load (node:internal/modules/cjs/loader:960:12)", "    at Module.require (node:internal/modules/cjs/loader:1143:19)", "    at require (node:internal/modules/cjs/helpers:121:18)", "    at _tryRequireFile (file:///var/runtime/index.mjs:976:37)", "    at _tryRequire (file:///var/runtime/index.mjs:1026:25)", "    at _loadUserApp (file:///var/runtime/index.mjs:1055:22)", "    at UserFunction.js.module.exports.load (file:///var/runtime/index.mjs:1093:27)", "    at start (file:///var/runtime/index.mjs:1256:42)", "    at file:///var/runtime/index.mjs:1262:7", "    at ModuleJob.run (node:internal/modules/esm/module_job:194:25)"]}

I managed to isolate the issue in a repo. Updated issue with details.

I thin the problem is that, the import.meta.url property is not supported in AWS Lambda functions running in a Node.js environment.
It also looks like the output conforms to esm syntax and not cjs syntax. Could you set module to CommonJS in your tsconfig and try again?

I set all the commonjs flags I could find and now I'm getting this
{
  "errorType": "TypeError",
  "errorMessage": "The \"path\" argument must be of type string or an instance of URL. Received undefined",
  "trace": [
    "TypeError [ERR_INVALID_ARG_TYPE]: The \"path\" argument must be of type string or an instance of URL. Received undefined",
    "    at new NodeError (node:internal/errors:405:5)",
    "    at Object.fileURLToPath (node:internal/url:1401:11)",
    "    at Object.<anonymous> (/var/task/app.js:164771:38)",
    "    at Module._compile (node:internal/modules/cjs/loader:1256:14)",
    "    at Module._extensions..js (node:internal/modules/cjs/loader:1310:10)",
    "    at Module.load (node:internal/modules/cjs/loader:1119:32)",
    "    at Module._load (node:internal/modules/cjs/loader:960:12)",
    "    at Module.require (node:internal/modules/cjs/loader:1143:19)",
    "    at require (node:internal/modules/cjs/helpers:121:18)",
    "    at _tryRequireFile (file:///var/runtime/index.mjs:976:37)"
  ]
}

looks the same expect for the last async lines.
I unminified the compiled code and looked at app.js:164771. Which is this line of code:
var import_url3 = __toESM(require("url"), 1);
// ...
var __filename = import_url3.default.fileURLToPath(import_meta.url);
// ----------------------------------^

Turns out that the package locter (used by typeorm-extension) doesn't work when built using esbuild.
locter uses import.meta.url which esbuild doesn't support.

There are many node-specific features that esbuild doesn't support while bundling such as __dirname, import.meta.url, fs.readFileSync, and *.node native binary modules.
https://esbuild.github.io/getting-started/#bundling-for-node

There are many ways to "fix" this. Like use another package then locter . Not sure what is easiest.

The problem is that even if we map the functionality in this library, import.meta.url is still used because we provide a bundle for cjs and esm. Esbuild should eig. be able to access the cjs file. But it kind of looks like based on your configuration an esm bundle is generated anyway and cjs imports are wrapped with toEsm.

@snebjorn do you have found any solution in the meantime?

I'm still waiting for an explanation from esbuild or a discussion about this behavior.
I didn't test this. But I think a workaround would be to use require instead of import in the .ts files to get esbuild to import the commonjs code.


text-size-adjust

text-size-adjust

This issue was imported from Google Moderator
Moderator votes: +11
Issue added by shannonmoeller on 2011-08-24
To vote this issue up or down, simply include +1 or -1 in your comment.

http://caniuse.com/#feat=text-size-adjust


Try to get a faster re-run for libvirt_manager

By registering overlay state, we should be able to avoid a long list
of tasks that are useless against an already created VM.
We also slightly amend the way we generated the SSH configuration for
the ProxyJump in order to allow running multiple "labs" on multiple
hypervisor, while avoiding overriding the whole ssh configuration and
losing access to the VMs.
With this patch, in case you're deploying two labs on two distinct
machines, you'll be able to reach either of them by using, for instance,
ssh controller-0.hypervisor-1 or ssh compute-0.hypervisor-2.
As a pull request owner and reviewers, I checked that:

[X] Appropriate testing is done and actually running

recheck

/test all

/approve


support abort signal for direct fetch util

Describe the feature
See: https://github.com/nuxt/nuxt/issues/22684
We don't yet support AbortController meaning that the fetch created with createFetch does not have a way to cancel requests. This may be desirable, depending on the difficulty of implementing a signal, but I thought it would be worth tracking it all the same.
Additional information

[X] Would you be willing to help implement this feature?

Seems a good idea to have if possible. How do you imagine canceling a direct fetch (which is an async function call) though?


disable sending unhealthy endpoints by default

Fixes https://github.com/istio/istio/issues/39825

[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ X] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure

@ramaraochavali: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio
5ed1e381c15286e6efff7f5fad680fba5b1225a2
link
true
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ramaraochavali: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio
1eed553d23813626fbfb0ffff404b9e046045e64
link
true
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ramaraochavali: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio
1eed553d23813626fbfb0ffff404b9e046045e64
link
true
/test unit-tests_istio

lint_istio
1eed553d23813626fbfb0ffff404b9e046045e64
link
true
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ramaraochavali: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio
dc5e775071f4a4ba10ee71befa5e43ed0d552a3d
link
true
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ramaraochavali: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-security-multicluster_istio
87a84acf51501b96b21a4bb8e3ff17f43141cb39
link
true
/test integ-security-multicluster_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test integ-security-multicluster_istio

@ramaraochavali: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-security-multicluster_istio
87a84acf51501b96b21a4bb8e3ff17f43141cb39
link
true
/test integ-security-multicluster_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ramaraochavali: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-security-multicluster_istio
87a84acf51501b96b21a4bb8e3ff17f43141cb39
link
true
/test integ-security-multicluster_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test integ-security-multicluster_istio

@ramaraochavali: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-pilot-multicluster_istio
87a84acf51501b96b21a4bb8e3ff17f43141cb39
link
unknown
/test integ-pilot-multicluster_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test integ-pilot-multicluster_istio

@ramaraochavali: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-security-multicluster_istio
87a84acf51501b96b21a4bb8e3ff17f43141cb39
link
unknown
/test integ-security-multicluster_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test integ-security-multicluster_istio

https://github.com/envoyproxy/envoy/issues/22120 Envoy issue for tracking

@ramaraochavali: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-security-multicluster_istio
87a84acf51501b96b21a4bb8e3ff17f43141cb39
link
unknown
/test integ-security-multicluster_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test integ-security-multicluster_istio

@ramaraochavali: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-security-multicluster_istio
87a84acf51501b96b21a4bb8e3ff17f43141cb39
link
true
/test integ-security-multicluster_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test integ-security-multicluster_istio

In response to a cherrypick label: #39834 failed to apply on top of branch "release-1.14":
Applying: disable panic threshold by default
Using index info to reconstruct a base tree...
M	pilot/pkg/networking/core/v1alpha3/cluster.go
M	pilot/pkg/networking/core/v1alpha3/cluster_test.go
Falling back to patching base and 3-way merge...
Auto-merging pilot/pkg/networking/core/v1alpha3/cluster_test.go
Auto-merging pilot/pkg/networking/core/v1alpha3/cluster.go
CONFLICT (content): Merge conflict in pilot/pkg/networking/core/v1alpha3/cluster.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 disable panic threshold by default
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to a cherrypick label: new issue created for failed cherrypick: #39871


add layer caching

enable docker layer caching for codeship cc @dincho

Could you please provide link to working build that also shows timing ?

without cache https://circleci.com/gh/aeternity/epoch/1663?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link
with cache https://circleci.com/gh/aeternity/epoch/1714?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link

Note the "spin up environment"


make get_X_y private, param test, rename file

@agramfort thanks for the pass, testing downloads for all datasets is a challenge at the moment given their sizes.
I would merge the other changes right now and delay the extensive testing to later.
Ok for me to push to your branch?

sure go ahead

Thanks Alexandre!


Sensor are not working at Home Assistant start?

Hello!
I am using this code in my ui-lovelace.yaml to show the Samba Backup sensors:
      - type: entities
        title: Samba Backup
        entities:
          - entity: sensor.samba_backup
            icon: mdi:file-replace-outline
            name: Backup Status
          - attribute: backups_local
            entity: sensor.samba_backup
            icon: mdi:file-outline
            name: Lokale Backups
            type: attribute
          - attribute: backups_remote
            entity: sensor.samba_backup
            icon: mdi:file-move-outline
            name: Remote Backups
            type: attribute
          - attribute: total_backups_succeeded
            entity: sensor.samba_backup
            icon: mdi:file-check-outline
            name: Erfolgreiche Backups
            type: attribute
          - attribute: total_backups_failed
            entity: sensor.samba_backup
            icon: mdi:file-cancel-outline
            name: Fehlgeschlagene Backups
            type: attribute
          - attribute: last_backup
            entity: sensor.samba_backup
            icon: mdi:file-clock-outline
            name: Letztes Backup
            type: attribute
        show_header_toggle: false

But after starting Home Assistant or starting Home Assistant Operating System these sensore are not available which is shown on my lovelace page.
When I restart Samba Backup they are available immediate.
What can be the problem here?

Please take a look at this issue: https://github.com/thomasmauerer/hassio-addons/issues/55

Oh, I see.
Sorry to open this issue!


Change Poll Time

Any chance you can allow the user to determine the poll time (either from a set list or by entering time)? Currently I get a new joke every minute. No big deal, but when I want to show someone, sometimes by the time I get to them it's already changed to a new one.

I second this.  I would like hourly or even daily jokes.  My use case is two-fold:  First, I keep checking Home Assistant just to see what the joke is and it gets distracting.  Secondly, When the joke is funny, I read it to my wife and she gets annoyed because she hates dumb jokes (I love them, of course).  Having fewer jokes would distract me less and annoy my wife less.
I was thinking of using a text helper and just copying the joke to it hourly or daily as a workaround, but having a user-selectable interval would be ideal.

agree: set refresh time variable

agree: set refresh time variable

I think adding a configuration option would be a great idea. Let the user determine when the jokes get refreshed. Unfortunately, I have no idea how to do that. I did submit a PR to update it from 60 seconds to 15 minutes though. But I like your idea of a user-set update time.

Yer configurable time would be awesome.
Plan is to use this once a day in the morning to wake up to :)

The official way to change update intervals in Home Assistant nowadays is to disable the automatic updates and create an automation to trigger when you want updates.
First disable automatic polling. For this go to the integration and open the system settings for the integration (it is in the vertical 3-dot menu). There is a switch to enable polling for automatic updates. Turn off that switch.
Next create an automation that calls the homeassitant.update_entity service.
This is my automation. It updates every 15 minutes, but only between 8:00 and 23:00. Change it to your liking.
alias: Update joke
description: ""
trigger:
  - platform: time_pattern
    minutes: /15
condition:
  - condition: time
    after: "08:00:00"
    before: "23:00:00"
    weekday:
      - sun
      - sat
      - fri
      - thu
      - wed
      - tue
      - mon
action:
  - service: homeassistant.update_entity
    data: {}
    target:
      entity_id: sensor.random_joke
mode: single


Correct set_index(Stabilizer_Tableau, rows, cols)

Suppose
julia> H
+ X_X_ZYZY
+ X_YZX_YZ
+ XZ_Y_YXZ

I want to apply Hadamard Rotation operaton to each element in each row, H*X
julia> for rows in 1:3
                 for cols in 1:2^3
                       setindex!(H, rows, cols) = sHadamard(1)*H[[rows], [cols]]
                  end
          end

I get wrong output, no change!
julia> H
+ X_X_ZYZY
+ X_YZX_YZ
+ XZ_Y_YXZ

Expected Output
 Z_Z_XYXY
Z_YXZ_YX
ZX_Y_YZX

There seems to be a problem with setindex! Because H operation is applied correctly as shown in the output
julia> for rows in 1:3
              for cols in 1:2^3
                    println(sHadamard(1)*Hⱼ[[rows], [cols]] )
              end
           end
+ Z
+ _
+ Z
+ _
+ X
- Y
+ X
- Y
+ Z
+ _
- Y
+ X
+ Z
+ _
- Y
+ X
+ Z
+ X
+ _
- Y
+ _
- Y
+ Z
+ X

The problem either lies in the assignment ( setindex!(H, rows, cols)) or in setindex! Please feel free to assign an better name to the issue.

I think there is some conceptual confusion here. A gate is supposed to be applied to the tableau (state) as a whole, not row-by-row. Thus I am not sure what setindex!(H, rows, cols) = sHadamard(1)*H[[rows], [cols]] is supposed to do.
If one wants to apply a gate, they should just do apply!(state, sHadamard(qubit_index)) (which is also non-allocating, unlike this loop).
If the Hadamard needs to be applied to all qubits, it would looks something like:
for q_i in 1:nqubits(state)
    apply!(state, sHadamard(q_i))
end

There is a bit of a misuse of julia syntax here, which is a separate problem. If you want to set an index, you should write:
H[rows, cols] = sHadamard(1)*H[[rows], [cols]]
Instead, you are writing
setindex!(H, rows, cols) = sHadamard(1)*H[[rows], [cols]]

which simply redefines the setindex! function. You are defining new methods, not calling a function with this syntax.
For the moment I will close this issue, but feel free to reopen it if something was unclear.

Thanks a lot!


Can I do it with just offsets?

I have the included offsets that come with Chrono compressor is that enough to decompile? I know this isn't an issue with the program, but there's no contact information for help.
Get in touch with me at this discord
https://discord.gg/RxT7Tvy

I don't understand what you're asking, sorry.
This project lives in GitHub, I'm not going to use Discord to deal with issues.


Option to not shorten the feed articles

I would appreciate if there is an option, e.g. set in osmosfeed.yaml to display unmodified content:encoded if available (from the RSS feed itself). I am not sure if it's related but I will also appreciate showing the images, e.g. XKCD strips from https://xkcd.com/rss.xml, inline.

Thanks for the feedback @luben. I've been considering extracting a "cover image" from the article content. Would that address your core issue? Or there is something else in the unmodified encoded content you'd need?

Yes, that's one option. Also I noticed my first request didn't make a lot of sense (opposite of the title), so I edited it.

I would also love such feature. Browsing through my oldest RSS feeds, I see that some of the articles are no longer accessible. Having osmofeed store the content of the article would be perfect for archiving purposes.

@2m , thank you for providing the motivation. I have converted your ask to #14.


Added WAC volume creation instructions and updated FAQ

Updated volume creation instructions and added a screenshot
Updated FAQ section

Microsoft authors of articles need to make updates through the private repository so the updates can be staged and validated by the current validation rules. After you review staging and fix all validation issues, you can add the sign-off comment to let the PR reviewers know the updates are ready to be merged.It's easy to access the private repo version of your articles in GitHub. Just add -pr to the URL, as follows:
Public repo URL: https://github.com/MicrosoftDocs/{docs-repo}
Private repo URL: https://github.com/MicrosoftDocs/{docs-repo-pr}
We have closed this pull request. Please resubmit the updates through the private repo. For more information, [see the contributor guide].(https://docs.microsoft.com/en-us/contribute/)


Add branding options

Summary | Résumé
Adds branding options for The National Battlefields Commission and the Immigration and Refugee Board of Canada.

Before
After

Insert Image showing before the change was made
Insert Image showing after a change was made

Test instructions | Instructions pour tester la modification
Sequential steps (1., 2., 3., ...) that describe how to test this change. You should include
anything outside the README that will help the developer access your changes and be able to test
them such as any environmental setup steps and/or any time-based elements that this requires.
This will help a developer test things out without too much detective work.
Unresolved questions / Out of scope | Questions non résolues ou hors sujet
Are there any related issues or tangent features you consider out of scope for
this issue that could be addressed in the future? If so please create issues and provide
links in this section
Pull Request Checklist
Please complete the following items in the checklist before you request a review:

[ ] Have you completely tested the functionality of change introduced in this PR? Is the PR solving the problem it's meant to solve within the scope of the related issue?
[ ] The PR does not introduce any new issues such as failed tests, console warnings or new bugs.
[ ] If this PR adds a package have you ensured its licensed correctly and does not add additional security issues?
[ ] Is the code clean, readable and maintainable? Is it easy to understand and comprehend.
[ ] Does your code have adequate comprehensible comments? Do new functions have docstrings?
[ ] Have you modified the change log and updated any relevant documentation?
[ ] Is there adequate test coverage? Both unit tests and end-to-end tests where applicable?
[ ] If your PR is touching any UI is it accessible? Have you tested it with a screen reader? Have you tested it with automated testing tools such as axe?

Approving that said:
@samsadasivan @connorscarolyns
As is these new logos look small - we'll need to figure out the best way to intake + get some consistency going for sizing the svgs.


Don't let the app crash on 404s

This PR adds checks and adds error handling on every parametric route (e.g./hosts/:host)
It also adds tests for every handler.
WIP:
I am not sure on how the NewLandscapeHandler should behave, since it just tries to pull all the environments and then passes them to the view context, which does some filtering if the envName query param is passed or it just shows all the environments otherwise.
See: https://github.com/trento-project/trento/blob/2c9832ffc6fe0b500b200b0e604184f6fb81927e/web/environments.go#L62
I could cycle to check if the landscape exists, but I think I am missing some context here.
Thoughts?

@fabriziosestito great work again!
@lee-martin This probably belongs to a different discussion but as they are mentioned here: are we keeping the environments? it might make little sense making changes on them if they are going to go anyway.

This PR adds checks and adds error handling on every parametric route (e.g./hosts/:host)
It also adds tests for every handler.
WIP:
I am not sure on how the NewLandscapeHandler should behave, since it just tries to pull all the environments and then passes them to the view context, which does some filtering if the envName query param is passed or it just shows all the environments otherwise.
See:
https://github.com/trento-project/trento/blob/2c9832ffc6fe0b500b200b0e604184f6fb81927e/web/environments.go#L62
I could cycle to check if the landscape exists, but I think I am missing some context here.
Thoughts?

Hi @fabriziosestito ,
The why about the sending the environment in the NewLandscapeHandler is that we show the environment which this particular landscape belongs to in the view.
As the environment -> landscape -> system is a hierarchical thing, the landscape itself doesn't store which is its environment. That's why we pass it.
About the filtering, I think this is some leftover, as initially the landscape didn't have to belong to any environment by force. I think we could remove the statement where it checks if the environment is empty.
This way, we need to guarantee that the environment is passed in the query, and the provided c.Param("land") exists in the loaded environments

About the filtering, I think this is some leftover, as initially the landscape didn't have to belong to any environment by force. I think we could remove the statement where it checks if the environment is empty.
I think that the filtering is still needed, because we are using the sapystems_table partial also in the sapsystems list view, and it expects many or one environment (by filtering).

If I can assume that the envName has to be an existing environment in the NewLandscapeHandler I can just 404 if I find this is not true and keep the template as it is in this PR and we can think maybe to restructure it later.

gj 🏖


Amazing New Partnership for Our Future

This has been by far the very best news I've heard so far and it will be much better for all of us, as we will all benifit greatly in softwear design, compatability issues, and we can all contribute in it to end up with super products we all dreamt about having it with Microsoft,... Thank you Mr. Gates

Document details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 0193ed76-3eec-18ac-512f-45f8118dde34
Version Independent ID: 8e693833-3e45-2bb8-ddc2-d0c54936c3c1
Content: A New Feedback System Is Coming to docs.microsoft.com
Content Source: teamblog/a-new-feedback-system-is-coming-to-docs.md
Service: unspecified
Product: team-blog
GitHub Login: @EisenbergEffect
Microsoft Alias: EisenbergEffect

Thanks for the feedback!


fix: log the cumulative resource request that failed

Fixes #
Description
Its not as helpful to know just the pod resource
request when you're trying to diagnose why a node
won't launch. You need to know the daemonset + pod resource requests that Karpenter is using in its
calculation.
How was this change tested?
Deploying on an EKS cluster with a pod that had a large request size.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

4 of 4 (100.0%)  changed or added relevant lines in 1 file are covered.
7 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.05%) to 81.239%

Files with Coverage Reduction
New Missed Lines
%

pkg/controllers/node/controller.go
7
70.59%

Totals

Change from base Build<PHONE_NUMBER>:
-0.05%

Covered Lines:
6898

Relevant Lines:
8491

💛  - Coveralls


update readme

the statement about pip install is not quite right. it would also probably be helpful to point to texlive.

did it


feat: dark mode

What did you implement
Editor's support for dark mode

How it can be tested

start Strapi
go to profile settings
select dark mode
go to content manager
add/edit item with rich text editor
input should be readable in new theme

Would love to see this merged in and officially supported.
@melishev


Add a selected global python interpreter  on to PATH

Environment data

VS Code version: 1.47.3
Extension version (available under the Extensions sidebar): XXX
OS and version: Windows Server 2019
Python version (& distribution if applicable, e.g. Anaconda): Python 3.7.8 and Python 3.8.4 (downloaded from Python.org)
Type of virtual environment used (N/A | venv | virtualenv | conda | ...): NA
Relevant/affected Python packages and their versions:
Relevant/affected Python-related VS Code extensions and their versions: Python 2020.7.96456  and Shell launcher 0.4.1
Value of the python.languageServer setting: None

Expected behaviour
When I select the Python Interpreter version, I expect to get the selected version in the VSC integrated terminal.
Actual behaviour
When I type Python in the integrated terminal, the command is not recognized.
In my user settings, I'm setting the PATH environment variable (I removed the path for the python directory here). Also I'm excluding myself from the A/B pythonPath testing.
Steps to reproduce:

Logs

Output from Python output channel

> conda --version
> pyenv root
> python3.7 c:\Users\el.mehdi.el.aouni\.vscode\extensions\ms-python.python-2020.7.96456\pythonFiles\pyvsc-run-isolated.py -c "import sys;print(sys.executable)"
> python3.6 c:\Users\el.mehdi.el.aouni\.vscode\extensions\ms-python.python-2020.7.96456\pythonFiles\pyvsc-run-isolated.py -c "import sys;print(sys.executable)"
> python3 c:\Users\el.mehdi.el.aouni\.vscode\extensions\ms-python.python-2020.7.96456\pythonFiles\pyvsc-run-isolated.py -c "import sys;print(sys.executable)"
> python2 c:\Users\el.mehdi.el.aouni\.vscode\extensions\ms-python.python-2020.7.96456\pythonFiles\pyvsc-run-isolated.py -c "import sys;print(sys.executable)"
> python c:\Users\el.mehdi.el.aouni\.vscode\extensions\ms-python.python-2020.7.96456\pythonFiles\pyvsc-run-isolated.py -c "import sys;print(sys.executable)"
> py -3.7 c:\Users\el.mehdi.el.aouni\.vscode\extensions\ms-python.python-2020.7.96456\pythonFiles\pyvsc-run-isolated.py -c "import sys;print(sys.executable)"
> py -3.6 c:\Users\el.mehdi.el.aouni\.vscode\extensions\ms-python.python-2020.7.96456\pythonFiles\pyvsc-run-isolated.py -c "import sys;print(sys.executable)"
> py -3 c:\Users\el.mehdi.el.aouni\.vscode\extensions\ms-python.python-2020.7.96456\pythonFiles\pyvsc-run-isolated.py -c "import sys;print(sys.executable)"
> py -2 c:\Users\el.mehdi.el.aouni\.vscode\extensions\ms-python.python-2020.7.96456\pythonFiles\pyvsc-run-isolated.py -c "import sys;print(sys.executable)"
> ~\AppData\Local\Programs\Python\Python38\python.exe c:\Users\el.mehdi.el.aouni\.vscode\extensions\ms-python.python-2020.7.96456\pythonFiles\pyvsc-run-isolated.py -c "import sys;print(sys.executable)"
> ~\anaconda3\Scripts\conda.exe info --json
Starting Pylance language server.
Python interpreter path: ~\AppData\Local\Programs\Python\Python38\python.exe
Error 2020-08-06 14:59:13: Attempted to download with skipDownload true.
> ~\AppData\Local\Programs\Python\Python38\python.exe c:\Users\el.mehdi.el.aouni\.vscode\extensions\ms-python.python-2020.7.96456\pythonFiles\pyvsc-run-isolated.py -c "import jupyter"
> ~\AppData\Local\Programs\Python\Python38\python.exe c:\Users\el.mehdi.el.aouni\.vscode\extensions\ms-python.python-2020.7.96456\pythonFiles\pyvsc-run-isolated.py -c "import jupyter"
> ~\AppData\Local\Programs\Python\Python38\python.exe c:\Users\el.mehdi.el.aouni\.vscode\extensions\ms-python.python-2020.7.96456\pythonFiles\pyvsc-run-isolated.py -c "import notebook"
> ~\AppData\Local\Programs\Python\Python38\python.exe c:\Users\el.mehdi.el.aouni\.vscode\extensions\ms-python.python-2020.7.96456\pythonFiles\pyvsc-run-isolated.py -c "import notebook"
Error 2020-08-06 14:59:16: Detection of Python Interpreter for Command py and args -2 failed as file Python 2 not found!

 -3.8-64
 -3.7-64 does not exist
Error 2020-08-06 14:59:16: Detection of Python Interpreter for Command py and args -3.6 failed as file Python 3.6 not found!

 -3.8-64
 -3.7-64 does not exist
> ~\anaconda3\Scripts\conda.exe info --json
> ~\anaconda3\Scripts\conda.exe env list
> ~\AppData\Local\Programs\Python\Python37\python.exe c:\Users\el.mehdi.el.aouni\.vscode\extensions\ms-python.python-2020.7.96456\pythonFiles\pyvsc-run-isolated.py pip --version
Python interpreter path: ~\AppData\Local\Programs\Python\Python37\python.exe
> ~\AppData\Local\Programs\Python\Python38\python.exe c:\Users\el.mehdi.el.aouni\.vscode\extensions\ms-python.python-2020.7.96456\pythonFiles\pyvsc-run-isolated.py pip --version
Editor support is inactive since language server is set to None.
Python interpreter path: ~\AppData\Local\Programs\Python\Python38\python.exe

We do not participate in the terminal creation in terms of PATH. I also don't see any entry in your custom PATH setting that would place a python binary on your PATH. If you used the Python installer from python.org then you need to explicitly opt into putting Python on to the PATH to begin with.
What I will do, though, is turn this into a feature request to try to come up with a way to include a global Python interpreter into the terminal when one is manually specified.

Perfect. Makes sense. Thank you @brettcannon

@ditordccaa I'm reopening this to leave it as a feature request. If you aren't interested in it you can unsubscribe from the issue if you prefer.

We will want to address after https://github.com/microsoft/vscode-python/issues/11039.

@luabud Should we close this as we're deciding to not do it right now?
cc/ @brettcannon

We are afraid of breaking users if we were to implement this. Plus, we would rather encourage people to use environments which do have shell activation support.


Fix compatibility with php 7.4

The static value as a return type isn't supported until php 8.0

@emiliopedrollo thank you for this.


Bugfix: Conversion between Label and Image with original scaling

Description
Adding a change to fix https://github.com/napari/napari/issues/3389
Type of change

[x] Bug-fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

References

How has this been tested?

[ ] loading image with napari.view_image(skimage.data.moon(), scale=[2, 1]) and convert it to Label and back to Image.

Could anyone tell me what test is required and how to run tests?
Final checklist:

[ ] My PR is the minimum possible work for the desired functionality
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] If I included new strings, I have used trans. to make them localizable.
For more information see our translations guide.

Could anyone tell me what test is required and how to run tests?

You could update this test here to change some attribute about the input layer and make sure it carries over to the new layer.
Tests will run here on CI, but to test it locally you can run pytest.  That will take a long time though, so to direct it only to the relevant test, run:
pytest napari/layers/_tests/test_layer_actions.py

(this assumes you've installed the testing dependencies with pip install -e .[testing]

Thank you @tlambert03
It is not related to this PR but I got error when running the test: pytest napari/layers/_tests/test_layer_actions.py
log.txt

huh, haven't seen that error before.  Not quite sure what to tell you.  would be curious to know if you still got it in a fresh environment.  Was this a relatively new environment?

I tried with absolutely fresh environment. Also I tried in anaconda environment and system python. If there is docker image that can run test I can use it.

Finally I can run and add test with new WSL2 environment. I don't know what was wrong but thank you anyway.

The error:
..\..\..\anaconda3\envs\naparidev\lib\site-packages\pluggy\_manager.py:91: in register
    raise ValueError(
E   ValueError: Plugin already registered: c:\users\yukim\documents\napari-dev2\napari\napari\conftest.py=<module 'napari.conftest' from 'c:\\users\\yukim\\documents\\napari-dev2\\napari\\napari\\conftest.py'>

to me looks like an issue with pytest Python paths. Sometimes I have to do PYTHONPATH=. pytest path/to/test.py, never really understood why, but give it a go? How did you install napari for development? pip install -e .[all,dev]?


JSON Request option?

It would be nice for Inertia to understand JSON requests. I'm using this to help make modal windows work in a cleaner way (by not mixing concerns in unrelated controllers). I've got code similar to below in a helper function, it'd be cool if the framework did this out of the box!
Apologies if I've missed a way in which this can already be done.
function renderJsonOrInertia($component, $data) {
        if (Request::hasHeader('X-Inertia') == false && Request::expectsJson()) {
            return response()->json($data);
        }

        return Inertia::render($component, $data);
}

Hello @dangerdan, thanks for your interest in Inertia.js.
Because of how the Inertia client-side routing works, it's not possible to support both Inertia responses and plain JSON responses.
If you'd like to make a standard XHR requests, simply use XHR directly, or via a library like axios, or even fetch.
The docs have a note about this: https://inertiajs.com/forms#classic-xhr-submits

Thanks for the reply @reinink. I am actually using the method outline above so make XHR requests to Inertia routes that then provide plain json via "response()->json", this saves me duplicating controller calls to return the same data when I need to manipulate it for models etc outside of the client-side Inertia JS. Just thought this would be a useful approach to share to reduce code duplication for those that need raw access to the same data Inertia controller methods provide.

I have the exact same problem and no one found a solution on this:
Versions:
"inertiajs/inertia-laravel": "^0.3.5",
"@inertiajs/inertia": "^0.8.4",
"@inertiajs/inertia-vue3": "^0.3.5",
"@inertiajs/progress": "^0.2.4",
Steps to reproduce:
    axios.get('/test-connection')
                .then(response => {
                    this.TestConnection = response.data;
                })

Response is a json object from Laravel:
return response()->json($data);
The response is always returning { "cookies": {}, "transferStats": {} }, I am not the only people with this issue, others on Laracast experience this too.
Tried everything I could, I cannot get a normal response in Json with Axios when Intertia is installed. Any hints please?


Would it be possible to add outlined variant for the datepicker?

I've tried so many things to try and make it work but I haven't been successful. Would it be possible to add it in as a feature?

you can use the inputVariant prop
<FastField
    name={"date_completed"}
    label="Date Completed"
    component={KeyboardDatePicker}
    inputVariant="outlined"
    format="MM/dd/yyyy"

    autoOk
    showTodayButton

    onChange={(value: string) => {
      setFieldValue(`date_completed`, value);
    }}
    value={values.date_completed || ""}
 />

Thanks @KerstingJ but how would I do it on here?
import { Field } from "formik";
import { DatePicker } from "formik-material-ui-pickers";

<Field
	component={DatePicker}
	disabled={editPatientDisabled}
	label="Date Added"
	variant="outlined"
	name="dateAdded"
/>


Add missing brew dependency

The dependency libyaml is missing in the README, resulting in such errors:
dyld[79096]: Library not loaded: /opt/homebrew/opt/libyaml/lib/libyaml-0.2.dylib
  Referenced from: <182D868F-ABE0-349D-A614-C31E254B37EC> /opt/homebrew/Cellar/hetzner_k3s/0.6.9/bin/hetzner-k3s
  Reason: tried: '/opt/homebrew/opt/libyaml/lib/libyaml-0.2.dylib' (no such file), '/System/Volumes/Preboot/Cryptexes/OS/opt/homebrew/opt/libyaml/lib/libyaml-0.2.dylib' (no such file), '/opt/homebrew/opt/libyaml/lib/libyaml-0.2.dylib' (no such file), '/usr/local/lib/libyaml-0.2.dylib' (no such file), '/usr/lib/libyaml-0.2.dylib' (no such file, not in dyld cache)
[1]    79096 abort      hetzner-k3s releases

This PR fixes the docs.
Probably an even better approach would be to add the dependencies to the brew formula (using depends_on).

Hi @Niek ! Thanks for reporting this. I followed your suggestion and updated the brew formula, which seems like a better solution. Do you mind double checking on your mac? Thanks!

Much better! I can confirm it works great now (I removed libyaml and hetzner-k3s, then reinstalled hetzner-k3s and it installed the dependency).
BTW I couldn't find the brew formula source, else I wouldn't made a PR for that.

Thanks for confirming! I think that the convention is to name the repo as homebrew-tap. Mine is at https://github.com/vitobotta/homebrew-tap


Add 'save as' topology template feature

Fixes: #1499

Weirdly both translations can be found in the locale files, and I18n seems to have been configured to include them in the JS. Can you reproduce this or is it just me?
The validation of the name seems to have been lost (but this is also true on beta). A 422 Unprocessable Entity request comes back to the browser, but no message is displayed. Since this is also true on beta – and therefore not related to this PR – we can merge this provided the translations work for you, and fix the validation separately.

Weirdly both translations can be found in the locale files, and I18n seems to have been configured to include them in the JS. Can you reproduce this or is it just me?

You need to, stop the server, do rake tmp:clear, start the server (this took me some time to figure out once)

You need to [...] rake tmp:clear

TY! Works perfectly. :+1:


lang="" on a html tag produces "VueCompilerError: Invalid end tag."

Version
16.0.0-rc.0
Reproduction link
https://github.com/xPaw/vue-loader-lang-bug
Steps to reproduce
Clone my repro project, yarn and yarn webpack.
Template:
<template>

</template>

What is expected?
Compilation succeeds
What is actually happening?
ERROR in ./src/test.vue
Module Error (from ./node_modules/vue-loader/dist/index.js):

VueCompilerError: Invalid end tag.
at src\test.vue:4:2
2  |

3  |

4  |

   |      ^
5  |  </template>

 @ ./src/index.js 1:0-21

Removing lang="" attribute fixes this.

vuejs/vue-loader#1726 was closed as not being able to repro, but it still won't compile.

Right, makes sense that is in the compiler, I didn't know where exactly the bug was, because the vue ast thing worked fine.

A temporary workaround: use :lang="''", because the SFC parser only checks for static lang attributes.

For a case like this where you add attributes to native elements, wouldn't the data-* html attributes be a better fit?

lang is a HTML attribute. https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/lang

Oh, didn't know that :) Thanks for the clarification


test(operator): Assert that ConfigAuditReports are created when Conftest is used as a scanner

There are two plugins to audit config of K8s workloads, Polaris and Conftest. We have some integration tests for Polaris, but we'd like to add similar scenarios for Conftest.

Please assign me


CodeGen: ensure 8-byte aligned String Swift CF ABI

CFStrings should be 8-byte aligned when built for the Swift CF runtime
ABI as the atomic CF info field must be properly aligned.  This is a
problem on 32-bit platforms which would give the structure 4-byte
alignment rather than 8-byte alignment.
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@368471 91177308-0d34-0410-b5e6-96231b3b80d8
(cherry picked from commit ee5531b2162e8d696928cbd48f58d92740c1015e)

CC: @dexonsmith @millenomi
This is needed to repair Foundation on non-Darwin 32-bit targets.  Since this is controlled by the -fcf-runtime-abi= flag, with the default being ObjC, this has no impact on the Darwin path as Darwin targets do not currently use the Swift runtime ABI (due to historical accidents).  Additionally, this patch only changes things on 32-bit targets (watchOS is excluded as it is a Darwin target), as 64-bit targets would use sizeof(void *) as the alignment (which would be 8-bytes).  Even there, it is increasing the alignment (4 -> 8) and should be safe for interoperability (even though there is not ABI guarantees yet on non-Darwin targets).


Execution bundle causes depth bug

When you replaced the arguments with a bundle, you caused an interesting regression.
Previously, depth was pass-by-value. So if you have a tree of a (calling b calling c and d) (calling e calling f and g), depth at a would be 500, depth at b would be 499, depth at c and d would be 498, depth at e would be 499, depth at f and g would be 498. Essentially, only recursive calls decrease the depth limit.
But not depth is pass-by-reference. Which means that it goes depth at a is 500, depth at b is 499, depth at c is 498, depth at d is 497, depth at e is 496, depth at f is 495, depth at g is 494.
In other words, "depth" is currently acting as a straight counter.
This is why strings isn't working properly. Currently, "depth" effectively imposes a limit on the length of the program.

Didn't realize you had already fixed this.


try google cloud storage instead of minio

need cloud storage abstraction, consider using https://github.com/lytics/cloudstorage

use https://github.com/graymeta/stow instead


Wallet recovery

I need to recover my copay wallet. My phone reset itself and I do not remember the recovery words. The password I thought I used is not working either. What can I do?


fix docs: typo and word choice

cc @davidism on this small change w/e you have time. 🙏

Hey @davidxia , thanks for yor contribution.
These fixes are quite straight-forward. After chaning the target branch, happily merging this PR.


Support for CMYK color spaces

As explained in https://github.com/color-js/color.js/pull/386#issuecomment-1902237776 this depends on #45 .
Once ICC profiles are supported, we could then add some common CMYK spaces (e.g. US Coated SWOP, FOGRA, etc.) to be available as predefined spaces and decide which one "cmyk" should resolve to (if any), though I'm not sure about their licensing requirements. @svgeesus, I’m sure you'd have many thoughts here!

This is a dup of #45 because there is no single "CMYK color space"


Kuberenetes pod metrics not available to HPA

Rancher versions:
rancher/server: 1.6.7
rancher/agent:
Infrastructure Stack versions:

Docker version: (docker version,docker info preferred)
1.12.6
Operating system and kernel: (cat /etc/os-release, uname -r preferred)
Ubuntu 16.04.2 LTS (4.10.0)
Type/provider of hosts: (VirtualBox/Bare-metal/AWS/GCE/DO)
Setup details: (single node rancher vs. HA rancher, internal DB vs. external DB)
Environment Template: (Cattle/Kubernetes/Swarm/Mesos)
K8
Steps to Reproduce:
Follow the steps in this guide to create a Horizontal Pod Autoscaling Policy: https://kubernetes.io/docs/tasks/run-application/horizontal-pod-autoscale-walkthrough/
Results:
HPA doesn't see CPU metric from Pod (says <unknown>):
>>> get hpa
NAME         REFERENCE               TARGETS           MINPODS   MAXPODS   REPLICAS   AGE
php-apache   Deployment/php-apache   <unknown> / 50%   1         10        0          2s

Heapster logs show several of these errors:
W0901 17:00:16.423547       1 listers.go:68] can not retrieve list of objects using index : object has no meta: object does not implement the Object interfaces

as well as
E0901 00:04:27.563257       1 reflector.go:203] k8s.io/heapster/metrics/sources/kubelet/kubelet.go:342: Failed to list *api.Node: Get https://<IP_ADDRESS>:443/api/v1/nodes?resourceVersion=0: dial tcp <IP_ADDRESS>:443: getsockopt: no route to host

perhaps related? https://github.com/kubernetes/heapster/issues/1470

@wjimenez5271 Tested with Rancher v1.6.9-rc3 and kubernetes 1.7.4, and i can see the HPA working normally:
kubectl run php-apache --image=gcr.io/google_containers/hpa-example --requests=cpu=200m --expose --port=80
service "php-apache" created
deployment "php-apache" create

kubectl run -i --tty load-generator --image=busybox /bin/sh

Waiting for pod default/load-generator-3044827360-pvc33 to be running, status is Pending, pod ready: false
If you don't see a command prompt, try pressing enter.
/ # while true; do wget -q -O- http://php-apache.default.svc.cluster.local; done
OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!OK!

kubectl get hpa
NAME         REFERENCE               TARGET    CURRENT   MINPODS   MAXPODS   AGE
php-apache   Deployment/php-apache   50%       412%      1         10        6m

kubectl get deployments
NAME             DESIRED   CURRENT   UP-TO-DATE   AVAILABLE   AGE
load-generator   1         1         1            1           5m
php-apache       4         4         4            4           8m

kubectl get hpa
NAME         REFERENCE               TARGET    CURRENT   MINPODS   MAXPODS   AGE
php-apache   Deployment/php-apache   50%       136%      1         10        9m

And after stopping the load i can see scaling down is working as well
kubectl get hpa
NAME         REFERENCE               TARGET    CURRENT   MINPODS   MAXPODS   AGE
php-apache   Deployment/php-apache   50%       0%        1         10        8m

kubectl get deployments
NAME             DESIRED   CURRENT   UP-TO-DATE   AVAILABLE   AGE
load-generator   1         1         1            1           8m
php-apache       1         1         1            1           12m

However i am still seeing two kinds of messages in heapster logs:
9/7/2017 3:07:39 AMI0907 00:07:39.969279       1 handlers.go:216] No metrics for pod default/php-apache-593471247-vx4jn
9/7/2017 3:08:09 AMW0907 00:08:09.976442       1 listers.go:68] can not retrieve list of objects using index : object has no meta: object does not implement the Object interfaces

and
9/7/2017 3:07:09 AMI0907 00:07:09.970993       1 handlers.go:216] No metrics for pod default/php-apache-593471247-7ksbd
9/7/2017 3:07:09 AMI0907 00:07:09.971002       1 handlers.go:216] No metrics for pod default/php-apache-593471247-dx2gw
9/7/2017 3:07:09 AMI0907 00:07:09.971009       1 handlers.go:216] No metrics for pod default/php-apache-593471247-vx4jn

which i am still looking into, and also i can see metrics for the remaining pod:

Tested HPA on 1.6.7 and 1.6.8 as well, autoscaling is working perfectly on all of them, after checking @wjimenez5271 setup it turned out that the problem is not related to Heapster however its related to kubelet can collect metrics, kubelet logs:
9/7/2017 12:57:27 PME0907 19:57:27.279470    4991 container_manager_linux.go:543] [ContainerManager]: Fail to get rootfs information error trying to get filesystem Device for dir /var/lib/kubelet: err: could not find device with major: 0, minor: 67 in cached partitions map

Another issue will be opened for this problem.

Kubelet is having problems on RancherOS 1.0.3 and 1.0.4, following up on the root cause in this issue #9848


Parse Object

sorry for very simple question but I need to ask
The analyzer or lemmatizer functions return lists with keys lemma,pos, morphemes etc...
After I get the analyzer, how can I access lemma property?
Right now  those functions return list of lists.
I am not very proficient at Python, apologise for bothering you.
thank you for help

I guess I found the answer. I am writing here so that it will be helpful for someone else
created=analyzer.analyze(line) # this returns a list of of Parse Objects (Parse object is some kind of list/dictionary)
for el in created:
for bel in el:
print(bel.lemma) #this will return the lemmatized result


Config option to control crosshair/gun sway

PR adds a CrosshairSway option to control crosshair/gun sway (100% by default). A bit of a cheat, but makes mouse aim feel better on PC for those that want it

Isn't this the point of the Head Roll control option...?

This isn't really related to Head Roll AFAIK, this is more like a control for the way the crosshair lags behind your mouse/controller movements which isn't normally controllable.


Document that .carousel-inner is required

It turns out that you need carousel-inner element and that one item needs to be active. The old docs forgot to mention that.

The active requirement is already covered by the "Initial active element required" callout in the docs.

Isn't the example markup enough here? If it's in the code for the component in the docs, I'd say that's enough to denote it being required.

Agreed. None of the examples omit it and we don't state that it's optional anywhere.

I always assumed they were required for the reasons @mdo mentioned.

Yup, punting on this. Thanks though!

The examples are full of lots of optional stuff (like indicators and controls and role attributes). My pair and I were confused that in addition to items being required, the carousel-inner was also required -- this doc would have saved us some debugging time.

FWIW, we've added a check for this to the linter: https://github.com/twbs/bootlint/pull/235


Float entries. Dissociate id source

Float entries detected as update even if there is no change.
Dissociate id source was wrong.
AuditSubscriber.zip

@tleurida2, thanks for your feedback and sorry for my late reply.
You're right about updates detected by error regarding float/int but your solution likely won't work with boolean/null values (null == false). Maybe you could provide a PR?
For the other part (dissociate id source was wrong), could you provide an example?

I pushed some changes that should fix the issue. Could you please test against master branch?

For us, the issue is that Doctrine returns the values of decimals as string, understandably, since you can set a specific precision which would be lost as float type. When editing a decimal field in the Form component, it does return a float. So when comparing old and new, Doctrine sees a change in the typing, not in contents.
We're choosing to conform to Doctrine in this case by changing our fields to a string before setting them on the entity.

Our problem was that Symfony's FormBuilder built-in MoneyType transforms values to the float type. While our entity's corresponding decimal field setters and getters did not enforce the string type it should have (decimals should not be represented by floats). By typehinting these getters and setters with the string type you can enforce the decimal field to be represented as a string, even if a float value is used to set the field. Then when the audit bundle does the difference comparison it won't try to compare the float as it was set to the entity with the string decimal that came from the database.

Decimals are now casted as string before comparison. Can you please test against dev-master?

Closing the issue for now. Feel free to re-open if needed.


Replace C-style array declaring with Java-style array declaring

There are many of those. A quick search shows around 400 occurrences of the C-style.
I am not sure this is worth it. It will make backporting very hard.

There are many of those. A quick search shows around 400 occurrences of the C-style.
I am not sure this is worth it. It will make backporting very hard.

What if we write new code? Should we write the Java-style array?

Yes, please use Java-style array declaration syntax in new code.

I think code style should be unified,especially obvious ones like this

@lanicc We agree that the code style should be consistent and that it should follow Java conventions. But we will do it only when editing such code for other functional changes.