HDDS-8475. Unexpected IOException should be returned as INTERNAL_ERROR.

What changes were proposed in this pull request?
In OM GetKeyInfo API, unexpected IOExceptions are returned as KEY_NOT_FOUND and the original error is swallowed.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-8475
How was this patch tested?
Standard CI.

Thanks @duongkame for the fix.


add required required response types to provider config

 Issue by sym3tri
Thursday Dec 04, 2014 at 23:25 GMT
Originally opened as https://github.com/coreos-inc/auth/issues/127

Spec says:
response_types_supported
REQUIRED. JSON array containing a list of the OAuth 2.0 response_type values that this OP supports. Dynamic OpenID Providers MUST support the code, id_token, and the token id_token Response Type values.
http://openid.net/specs/openid-connect-discovery-1_0.html#ProviderMetadata

dex correctly provides this field during discovery


UNABLE TO CHECK STATUS

UNABLE TO CHECK STATUS
Health check failed: CloudBridgeBaseException: Unable to locate credentials from exception type: <class 'botocore.exceptions.NoCredentialsError'

I'm guessing you are using temporary credentials? Please refer here: https://github.com/galaxyproject/cloudlaunch/issues/212


2 packages - one with IServerTiming , one with asp.net core middleware

I want to add timings toan assembly. But I do not want to add the whole middleware to the project ( the middleware should be just into the ASP.NET Core  )  -  I want just to have reference to IServerTiming .
Could you separate into 2 nuget packages ?

Hi @ignatandrei,
Yes, this makes sense. The trick is that this will be a breaking change. So before I do this, I'll wrap up and release #16. Than I can do this and #10.

Ok. Let me know. And thanks

Lib.AspNetCore.ServerTiming.Abstractions package is now available.

Thanks

Ok, something messed up during CI/CD (#22), it will be another day or two.

Should be ok now.

TimeAction and TimeTask -could be on the same dll ?

Hmm, I'll need to think if/how they fit.


use NavLink for SidebarItem

This website is a Single Page React Application with precompiled HTML, but links in sidebar are rendered as <a> elements, which would cause browser to load a whole new html page. When we render them as NavLink, it would dynamic load the needed part instead of loading a new html page which could load the page faster.

We're having a problem here https://github.com/ReactTraining/react-router/issues/394.


TS-4513: Error when building with gcc 6.1.1 with luajit

(cherry picked from commit 5f91438df0b89865386374ec1363ad8edb2b11cb)

Back port of #894

Linux build successful! See https://ci.trafficserver.apache.org/job/Github-Linux/1041/ for details.

FreeBSD build successful! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/1148/ for details.


fix #1887 resolve memory leak for parsing result cache.

Pull Request Test Coverage Report for Build 6803

21 of 21 (100.0%)  changed or added relevant lines in 5 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.02%) to 74.298%

Totals

Change from base Build 6801:
0.02%

Covered Lines:
10664

Relevant Lines:
14353

💛  - Coveralls


Apply verusfmt to vstd for the first time

Thank you and @jaybosamiya for working on this!
We may want to separately review if there are style changes that we'd want to tweak, but I'd have three procedural requests before we go ahead and merge this:

[ ] if we're using verusfmt on the standard library, we're now taking a dependency on it from verus; shall we move it into the verus-lang org so contributors who make verus changes have access to make verusfmt fixes if necessary?
[ ] can we set up a CI check and the related machinery to let users check verusfmt on the standard library, so that it remains formatted?
[ ] (minor) I generally use an empty author for commits that make broad changes applied with a tool, or by importing external code (with `--author "Nobody "), so that we maintain (indirectly) the original author of a line of code.

I'd in particular like to see CI, so that we make sure committed code remains in-line with verusfmt, which also preserves the git blame, which turns out often useful to determine when/how a change was made. (If there's no CI, then the code tends to drift, and then gets reformatted occasionally, which uninformative attributions in git blame again.)

shall we move it into the verus-lang org so contributors who make verus changes have access to make verusfmt fixes if necessary?

Yes, if you're comfortable with that, we're happy to make the move.

can we set up a CI check and the related machinery to let users check verusfmt on the standard library, so that it remains formatted?

Yes, definitely, this should be part of CI.  Would it be reasonable to set that up as a separate PR, so the changes are distinct from the massive but mechanical changes in this PR?

I generally use an empty author for commits that make broad changes applied with a tool, or by importing external code (with --author "Nobody "),

Is that something we can do to a commit retroactively, or do we need to restart this PR?

Will coordinate with you @utaal-b on Slack to make the move (since stuff might need updates due to permissions and such).
As for the CI PR, I recommend we use the (automatically) prebuilt binaries that I've set up for verusfmt.  However, I don't know how GitHub will handle things upon the move of verusfmt to the verus-lang org (I assume they'll URL-rewrite, but I haven't tested that with release artifacts in particular), so to keep things simple, it might be best for us to finish migrating it to the verus-lang and then setup the CI PR.
Regarding author-nobody: agreed on rewritten history if it seems ok to @parno; I'm bringing this up mostly to also point out that we should also additionally add the commit to the .git-blame-ignore-revs file, so that GitHub will automatically ignore such commits in its blame view; the addition to the .git-blame-ignore-revs prob is best added as part of this PR itself.

If you're able to remove the author for 69f9fee and add it to a .git-blame-ignore-revs file, that sounds fine to me.   I'm glad we can do it retroactively.
I can work with Jay to get verusfmt added to the CI once we migrate the verusfmt repo to verus-lang

Done. We must not squash or rebase this branch when marging through GitHub's UI as that would invalidate the git hash we added to .git-blame-ignore-revs. This will have to be a merge commit.

We're now in sync with main.  Can we merge this in at this point?  It seems simpler than rebasing, since I don't know if the custom edits in 4072213 will replay cleanly when doing the rebase, and they were tedious to do by hand.

since I don't know if the custom edits in 4072213 will replay cleanly when doing the rebase, and they were tedious to do by hand.

From my offline chat with @jaybosamiya I got the impression that there were no custom edits in that commit, which is why I suggested the rebase. Now knowing that's not the case, I absolutely agree with merging instead of rebasing.
I don't know if you're just planning ahead, but I'd very much prefer if we only merged this once the CI check is ready to be merged as well, as I'd rather not have vstd re-diverge from "approved" verusfmt.

I'd very much prefer if we only merged this once the CI check is ready to be merged as well, as I'd rather not have vstd re-diverge from "approved" verusfmt.

I think the CI changes should be ready this week, but if we hold off merging, every edit to vstd will cause a conflict with this PR and require manual intervention.  If we merge now, those edits might cause a small drift, but that seems easy to fix mechanically by simply running verusfmt.  Are there additional costs associated with temporary divergence?

Since verusfmt is frequently updated, is it going to cause problems? Like a CI that succeeds one day and then fails because verusfmt is updated? Is there a plan to avoid this kind of annoyance?

That's a fair point. As long as you're confident we will have CI support sometime this week, I personally think you can go ahead and merge.
However, I would also like to hear from @tjhance and @Chris-Hawblitzel that they don't have any other concerns/questions first.

I'm fine with merging and waiting on CI.  To address @tjhance 's point about verusfmt itself being updated, we might need the CI to point to a particular version of verusfmt at any given time.

I'm fine with merging and waiting on CI. To address @tjhance 's point about verusfmt itself being updated, we might need the CI to point to a particular version of verusfmt at any given time.

We will also need to make sure that the verus dev has the correct version installed at the time, otherwise their local check won't match with what CI expects. Perhaps a task for vargo?
/cc @jaybosamiya

Since verusfmt is frequently updated, is it going to cause problems? Like a CI that succeeds one day and then fails because verusfmt is updated? Is there a plan to avoid this kind of annoyance?

I don't believe that "CI succeeds one day, fails the next" is something to be particularly worried about due to a collection of factors:

We expect and strive to have very few changes to its output on things that is already supported. Basically, verusfmt is regularly updated, but almost all of its updates are to improve support for things (new Verus syntax features, etc.), rather than change style on existing features.
Verusfmt itself runs a CI job which performs snapshot checks to prevent divergence (for example, see the Verus syntax.rs unchanged test, or any of our consistency tests), thereby preventing unintentional divergence. We can additionally add more tests to the snapshot if there are particular files that folks want extra assurance on. We already have some files planned to be added there (soon) for extra assurance.
In the rare case of intentional changes to output, that would be a situation that requires some coordination, but I think we can handle this on a case-by-case basis, since we expect such changes are to be primarily hyper-localized.

To address @tjhance 's point about verusfmt itself being updated, we might need the CI to point to a particular version of verusfmt at any given time.
One approach to this is to have two separate jobs in the CI, one pinned (this is the primary formatting check, and thus PRs must satisfy this) and one floating at latest verusfmt release (this is a secondary check, and thus won't fail or block merging or anything; will only act as warning upon divergence).

Given the intended stability goals for verusfmt, I suspect that we don't need to be particularly paranoid about this: I think we should perform pinning only if we see serious breakages being an actual issue. For now, I think it is reasonable for us to just use the latest verusfmt release (which again is intended to be stable).

We will also need to make sure that the verus dev has the correct version installed at the time, otherwise their local check won't match with what CI expects. Perhaps a task for vargo?

I understand this could be a possible longer-term concern, but for now, I don't think we should block on this. Adding it as part of vargo fmt might be good as a separate PR though to improve convenience for verus devs.

In light of the discussion above, I'm going to go ahead and merge this.  We'll update the CI soon thereafter.


--standalone .exe not doing anything. works fine if not run as --standalone

Nuitka = 0.612.2
OS = Win 10 64 bit
Python = 3.7
installed in venv with PyCharm
python -m nuitka --windows-disable-console --plugin-enable=multiprocessing --mingw64 SPSS_Data_Editor_v1.0.py
creates .exe which works perfectly.
python -m nuitka --windows-disable-console --plugin-enable=multiprocessing --mingw64 --standalone --plugin-enable=numpy --plugin-enable=qt-plugins SPSS_Data_Editor_v1.0.py
creates .exe in dist folder will dlls, etc. does not do anything when run. no error messages or other output.
what is very strange is when I copied dist folder to another location on my machine and replaced .exe with one generated without --standalone it worked. neither of these attempts worked when I copied to another machine.

Do not disable the console, then you probably get an error, that would be helpful, without console no error can be output.

Got the following:
(DataEditor) C:\Users\johntaggart\Documents\PycharmProjects\DataEditor\SPSS_Data_Editor_v1.0.dist>SPSS_Data_Editor_v1.0.exe
Traceback (most recent call last):
File "C:\Users\JOHNTA~1\DOCUME~1\PYCHAR~1\DATAED~1\SPSS_D~1.DIS\SPSS_Data_Editor_v1.0.py", line 29, in
File "C:\Users\JOHNTA~1\DOCUME~1\PYCHAR~1\DATAED~1\SPSS_D~1.DIS\pyreadstat_init_.py", line 17, in
File "pyreadstat\pyreadstat.pyx", line 1, in init pyreadstat.pyreadstat
ModuleNotFoundError: No module named 'pyreadstat._readstat_writer'

And now guess what I need next? Hint, it's something you deleted from the issue template. I might be line 29 of your program, which is likely an import, and I need you to confirm it has the same issue. :)

import pyreadstat
No surprise there. As I mentioned, it's all good when not run as --standalone.

It's not about the surprive level, it's about me not having to guess, i.e. knowledge level. When trying this, I got another error, where it wants to import pandas.

I'm using pandas 1.2.2

seems to be a duplicate of #980

@kayhayen and there is a minimal reproducer there

Yes, this is a duplicate indeed, please follow that issue @jttaggart

Also new option of 0.6.13 or higher allows you to force outputs into files, even when not using console, that is also very helpful for debugging. Look for --windows-force-stdout-spec and for tracebacks of course esp. --windows-force-stderr-spec


GPUParticles3D billboarding is affected by particle's global rotation when precision=double

Godot version
v4.0.2.stable.custom_build [285ca4637]
System information
Windows 10, Forward+
Issue description
With #76003 and #75462 I thought my particle issues were solved, but in testing I've noticed more billboard strangeness. Finally debugged it to the global rotation of the particles node.

This issue is not present in non-double precision builds.
Steps to reproduce

Create a GPUParticles3D in a double precision build
Set billboarding in the material
Rotate the particles node or its parent

Minimal reproduction project
double-particles-2.zip

Wondering / hoping if #72638 will improve this situation. Will take a closer look this weekend if I get a chance.

As noted in #89020 - can be worked around by enabled Rotate Y in the process material.

This issue is cause by the following block in the shader code scene_forward_clustered.glsl after the #CODE : VERTEX:
https://github.com/godotengine/godot/blob/f2045ba822bff7d34964901393581a3117c394a9/servers/rendering/renderer_rd/shaders/forward_clustered/scene_forward_clustered.glsl#L400-L415
If you remove the USE_DOUBLE_PRECISION branch, then this issue goes away.


Randomize Pepe

Pick a random Pepe for every greater rarity!
Minor readme fixes and frenship

@cryptobiff I am a Python newbie, so I hope my commit makes sense. Thanks, fren! Catch me on Discord under erik


[DO NOT MERGE] Add 'kind' column to generated report

Trello card
Titled as 'format' because that's what's shown in panopticon. We want to make this information available in the publisher reports so that it's still available when panopticon is retired.
TODO:

[ ] Deploy this branch to integration and run the rake task to generate these reports. I haven't been able to do this locally due to the hilarious number of app dependencies involved.

Looks good 👍


Wifi event details

Exposes some more details. In my use case, I want to use the event stream to display the currently associated BSSID to the user.

@jothan Aside from the 'a lifetime nit (see above) I think the rest looks quite nice!
So if you can justify the 'a lifetime introduction - or - if not needed after all - roll it back - I think this is ready for merging.
Let me know about that and thanks for the great work - and being able to navigate this undocumented code, and the *Ref tricks I introduced recently so as to avoid heap allocs and/or stack blowups.


update to latest gradle version and add gradle wrapper

Hello,
While we tried  to use the allure-server tool, we discovered that it is build with rather old version of gradle.
This PR updates the gradle version to 8.7. With that, the gradle docker image in the Dockerfile is updated as well as the github actions used to build the project.
For some specific reason, this repo excluded the gradle wrapper from the VCS. While updating the gradle github action, I found out that the wrapper is now the preferred way how to work with it. For this reason, I removed required wrapper files from gitignore. Even the gradle team itself recommends that the wrapper files are so small so they should be committed into the repo - https://docs.gradle.org/current/userguide/gradle_wrapper.html#sec:adding_wrapper so I don´t expect it will cause any problems, on the contrary, the presence of gradle wrapper files in the VCS can simplify the first load of the project.

https://github.com/kochetkov-ma/allure-server/releases/tag/v2.13.4


Relation problem during compilation

/usr/bin/ld: hwloc-prefix/src/hwloc-build/hwloc/topology-linux.o: relocation R_AARCH64_ADR_PREL_PG_HI21 against symbol `cmi_hwloc_alloc_mmap' which may bind externally can not be used when making a sha
red object; recompile with -fPIC

I'm configuring with
cmake -D CMAKE_INSTALL_PREFIX=/work/00434/eijkhout/charmpp/installation-charmpp-8.0.0-vista-nvidia24.9-openmpi5.0.5_nvc249                     -D CMAKE_COLOR_DIAGNOSTICS=OFF                     -D CMAKE_VERBOSE_MAKEFILE=ON                     -D BUILD_SHARED_LIBS=ON                     -D NETWORK=mpi -D CMAKE_POSITION_INDEPENDENT_CODE=ON                       /work/00434/eijkhout/charmpp/charmpp-8.0.0/

so the fPIC flag should be covered. Maybe you're not propagating it?
I get the same problem with gcc14

I would suggest you try using the build script to install charm++, as opposed to directly using cmake, and see if that resolves your issue.

Starting from version 7.0, Charm++ uses the CMake-based build system when building with the ./build command. To use the old configure-based build system, you can build with the ./buildold command with the same options. We intend to remove the old build system in Charm++ 7.1.

?

But sure, the build script works. However, it only creates static libraries. How do I tell it to make shared?

--build-shared

Ok, that builds the shared & static in two separate directories. (Not great, usually that's combined in one directory.)

How do I pass that option to the cmake install?
I can't get a prefix dir set: I build

./build charm++ ucx-linux-arm8 --build-shared --basedir=$(pwd)/../installation-old --force

but the basedir seems to be ignored.

Let me ask that last one separately.


Animation bug on Firefox

Due to unrendered javascript present in firefox, this bug is faced feel free to resolve this issue

hey @anushbhatia i have solved this issue i found the bug.

hey @anushbhatia i have solved this issue i found the bug.

Please give a PR within a couple of days

@anushbhatia  @smaranjitghose i need some guidance related to the code please can u tell why are we using svg of moving bicycle in nav bar . ASAP

@anushbhatia @smaranjitghose i need some guidance related to the code please can u tell why are we using svg of moving bicycle in nav bar . ASAP

You can build a css animation too if you wish

I came across this aswell. Awesome site though !!!


Port Range for v4tov4 is not working

[Enter feedback here]
Port Range for v4tov4 is not working

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 3b3b40a3-1d83-9dab-d06b-784944580ddb
Version Independent ID: 0be7bac0-6fc9-ce45-92dc-81d612ae8204
Content: Netsh commands for interface portproxy
Content Source: WindowsServerDocs/networking/technologies/netsh/netsh-interface-portproxy.md
Product: windows-server
Technology: networking
GitHub Login: @JasonGerend
Microsoft Alias: jgerend

Hello @dkalog,
Thanks for contacting Microsoft. We value your feedback.
As we understand it, you've described an issue with the Window Server product or service, rather than the documentation itself.
As you're probably aware, we offer many channels for engaging with us, whether you have a support question, product feedback, or other feedback.  GitHub Issues in the Windows Server repo are monitored for content issues we can address, such as broken links, grammar or wording, typos, updates, or incorrect code examples.
Don’t use GitHub Issues if you’re searching for:

Support cases or support tickets
Bug submittal or feature requests
Extended troubleshooting, technical support, or product support

Instead, use one or more of the following methods:

From Windows, use Windows Feedback Hub or press Windows + F. You can also provide feedback with Feedback.
Open a ticket with Microsoft Support.
Search or engage with Microsoft TechNet.
Search or engage with the Microsoft Developer Network.
Search or engage with the Microsoft Support Community.

Because this issue is a non-documentation issue, we’re closing this thread.
Thank you.
#please-close


Hex strings in database should be stored as BLOBs

sqlite3_analyzer reports that the tx table is ~59% of the database right now, and the hex column in that table is the bulk of it. We should convert that to the BLOB data type. The HEX() function of sqlite can be used to convert back to hex quickly in queries so changing this table should require minimal run-db changes. I'd also like to version the database so that existing DBs can be upgraded upon restart. After hex, other savings could be the txid, deps, spends, and location columns, but changing these will custom queries more difficult. Converting just the hex column will shrink the database by ~30% if using the default trustlist.

Fixed in https://github.com/runonbitcoin/run-db/commit/5bad5d3067f3b02d111c979ab5db2437807f772c
Result: Size reduction from 2.8G to 1.9G, ~33%.
Note that the VACUUM command during the upgrade takes ~5 minutes to complete for the size above on a regular laptop.

If you are querying hex strings from the tx table, you just need to change:
SELECT hex FROM tx WHERE ...
to
SELECT HEX(bytes) AS hex FROM tx WHERE ...


Endianness is unspecified

I could not find any mentions of "endian" or "byte order" in the spec. Without looking into the source code, I have no way to tell which to use.
That is a rather important oversight :)

Hi @matejcik,
I agree! While there is an example in the Class B encoding, it certainly could be made clearer:
https://github.com/OmniLayer/spec#class-b-transactions-also-known-as-the-multisig-method


Failed to sync network policy chains: failed to perform ipset restore

Environmental Info:
K3s Version:
k3s -v
k3s version v1.24.6+k3s1 (a8e0c66d)
go version go1.18.6

Node(s) CPU architecture, OS, and Version:
Linux dev-k8s-infra-01 5.15.0-52-generic https://github.com/k3s-io/k3s/pull/51-Ubuntu SMP Thu Aug 11 07:51:15 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Cluster Configuration:
24 worker nodes (8vCPU, 32gb ram)
2 master (4vCPU 8gb ram)
1 MariaDB database (8vCPU, 32gb ram)
1 nginx load balancer (4vCPU 8gb ram)
Describe the bug:
Getting error "Failed to sync network policy chains: failed to perform ipset restore"
Expected behavior:
No error
Actual behavior:
Oct 24 15:24:53 dev-k8s-infra-01 k3s[8913]: E1024 15:24:53.814397    8913 network_policy_controller.go:264] Aborting sync. Failed to sync network policy chains: failed to perform ipset restore: ipset v7.6: Error in line 1663: Kernel error received: Resource busy

This appears to be reported upstream:

https://github.com/cloudnativelabs/kube-router/issues/674

Can you provide more information about the issue? How often does it occur, and on how many nodes? How many network policies do you have in your cluster? Do you see a lot of pod churn in your cluster, or are things generally pretty stable and long-running? Do you have anything else on your nodes that manages iptables rules or ipset groups?

cc @manuelbuil

@brandond
It appears every few minutes in the logs on server (master) nodes. We have two of them. We don't have any network policies in the cluster. We do have activity of pod creation and removal from time to time, but I won't say it is a lot. Probably 100 pods were deleted and created per day out of 1500 pods total. Most of the pods are long-running. We don't have anything else that manages the nodes iptables or ipset groups.

The error is being bubbled up from the ipset tool. I don't think there's anything to be done on our side; for some reason when flannel is running the ipset binary, it's returning an error indicating that the resource is busy (possibly because another ipset run is still in process).

Out of curiosity, what happens if you do ipset list, do you get any output?

Hi @manuelbuil,
Yes, I get tons of output. Seems like every ServiceIP is listed with timeout 0, ServiceIP listed with specific ports open, and all nodes ports

@manuelbuil I will also note that I frequently get the following error in the k3s logs when I delete NetworkPolicies from the cluster:
E1026 20:53:00.574409      27 network_policy_controller.go:291] Failed to cleanup stale ipsets: failed to delete ipset KUBE-DST-434S4LQLXAPAJ2FZ due to ipset v7.6: Set cannot be destroyed: it is in use by a kernel component

@manuelbuil I know you were out for a long while. Do you have any new thoughts about updating the version of ipset utility in k3s-root?

FWIW the ipset version did get bumped when k3s-root was upgraded a couple releases back. We now bundle:
systemd-node-1:/ # /var/lib/rancher/k3s/data/current/bin/ipset --version
ipset v7.15, protocol version: 7


Funtionality stops working in Production

Please complete the following fields as applicable:
What version of the DMPRoadmap code are you running? (e.g. v2.2.0)
V3.0.4
We have upgraded to v3.0.4 on our TST server. In the development instance, all functionality works but when moving to the production instance some things stop working such as the edit profile section and action/dropdowns.
On the "edit profile" section, only the Personal Details tab is accessible.
On my dashboard section under "my plans", the action dropdown does not work. see image for reference:

Hi @Ebrahim1010 do you have any customized copies of those pages in the app/views/branded/ directory? If so, make sure that they are up to date with the current default pages in the roadmap code. For example if you have a file called app/views/branded/layouts/_signin_signout.html.erb then it overrides the default one in app/views/layouts/_signin_signout.html.erb. If the default version changes (e.g. it has a new class name or the structure of the html changed) and you have not carried those changes over to your customized copy, it can cause errors in javascript that is trying to interact with the html content.
If you have not customized those pages, then you may be having an issue with some of the client side javascript that runs in the browser. If you use your preferred browser's developer tools, you should be able to check the console output to see if there are any javascript errors. Here are instructions for how to do that in Firefox: https://developer.mozilla.org/en-US/docs/Tools/Web_Console. You can do the same in Safari and Chrome as well and the approach is similar.
Once you have the developer tools open and are on the Console tab, you can refresh your page. Any JS errors will appear in the console window. If you don't see any, try clicking on the 'Actions' menu on your Dashboard to see if any messages appear.

Is this still an issue @Ebrahim1010? Can this be closed?


Fix hudo anchor in readme (id)

More fixes)

/language id

/assign @girikuncoro

thanks a lot @Arhell for fixing this! 🎉
/lgtm
/approve

@Arhell is there a script or tooling you used for detecting this broken hugo anchor? if you don't mind can you share? so we can put it our CI for detecting this kind of error

/assign @xiangpengzhao

@girikuncoro
Hi, unfortunately not, manually

/assign @sftim

@kubernetes/sig-docs-id-reviews

issue

/approve


Hello, what should I do if I want to get an error message in Chinese?

Hello, for other natural language users, how do you solve

Oh, I'm sorry, I just read the document and found the way to localize it. Your document is very friendly. Thank you


[EG] add databox and apimanagement

API change check
APIView has identified API level changes in this PR and created following API reviews.
azure-eventgrid


play speed

is there a way to increase the video speed to 1.2x or 1.5x?

video speed? you are probably in the wrong place 😒

Oh man, apologies. I was using the WWDC videos app, and this was in my history, so assumed it was the WWDC videos app, and not the parties app.
Sorry again!


QuantumCircuit.qasm cannot handle nested gates with different parameters

Environment

Qiskit Terra version:  0.24.0.dev0+3005806
Python version: 3.9.13
Operating system: MacOS Ventura 13.2.1

What is happening?
Having a QuantumCircuit containing nested gates, such as PauliEvolutionGate, with different parameters leads to issues when translating these circuits to qasm strings. Qasm defines a new gate for these nested gates with parameters but discards gates that contain the same nested gates with different parameters.
The resulting qasm string looks like this, containing a duplicate definition of the gates exp_it_ZZ_ and exp_it_XI_:
OPENQASM 2.0;
include "qelib1.inc";
gate exp_it_ZZ_ q0,q1 { rzz(20.0) q0,q1; }
gate exp_it_XI_ q0,q1 { rx(20.0) q1; }
gate exp_it_ZZ_ q0,q1 { rzz(2.0) q0,q1; }
gate exp_it_XI_ q0,q1 { rx(2.0) q1; }
gate gate_PauliEvolution(param0) q0,q1 { exp_it_XI_ q0,q1; exp_it_ZZ_ q0,q1; }
gate gate_PauliEvolution_140709141623472(param0) q0,q1 { exp_it_XI_ q0,q1; exp_it_ZZ_ q0,q1; }
qreg q[2];
h q[0];
h q[1];
gate_PauliEvolution(1.0) q[0],q[1];
gate_PauliEvolution_140709141623472(1.0) q[0],q[1];

The result is that only one definition of these gates is used, ignoring the fact that they are used multiple times with different parameterizations.
This is a problem when sending such circuits to the cloud and results in the wrong circuits bein evaluated.
How can we reproduce the issue?
from qiskit.quantum_info import SparsePauliOp
from qiskit import QuantumCircuit
from qiskit.circuit.library import PauliEvolutionGate

circ = QuantumCircuit(1)
evo_gate1 = PauliEvolutionGate(
    SparsePauliOp(["X", "Z"], [1, 1]),
    1
)

evo_gate2 = PauliEvolutionGate(
    SparsePauliOp(["X", "Z"], [10, 10]),
    1
)

circ.append(evo_gate1, circ.qubits)
circ.append(evo_gate2, circ.qubits)

qasm_str = circ.qasm()
rebuilt = QuantumCircuit.from_qasm_str(qasm_str)

Output:
qiskit.qasm.exceptions.QasmError: "Duplicate declaration for gate 'exp_it_Z_' at line 5, file .\nPrevious occurrence at line 3, file "
What should happen?
Qasm should define distinct gates for each nested gate with a distinct parameterization.
Any suggestions?
No response

It seems like the exporter does not check the namespace of declared gates.


Added Dictionary App

Title: The Dictionary App
Description:
This app can search word meanings, synonyms, example etc. Only English language is supported.
Issue No:
#292
Tech stack: Html,css, javascript.
Screenshot:

Update the project number to 78

Sir, please check I added One new PR. With the changes and this PR is closed. New PR #349


XCode 7

I made the mistake of going to XCode 7 yesterday. Now ofxAudioUnit won't compile. I made a blank project with of_v20150909_osx_release and it compiled and ran fine. I then added ofxAudioUnit to the AddOn folder, and it failed to compile with the errors "gltypes.h included before glew.h" and "error: typedef redefinition with differen ttypes...".
Wondering if anyone has similar problems.
Thanks.
Sam

Sounds more like an openframeworks 0.9 + Xcode 7 problem than a
ofxAudioUnit problem.  Have you tried OF0.8.4 + Xcode 7 with ofAudioUnit?
On Thu, Sep 17, 2015 at 3:59 PM, stswong<EMAIL_ADDRESS>wrote:

I made the mistake of going to XCode 7 yesterday. Now ofxAudioUnit won't
compile. I made a blank project with of_v20150909_osx_release and it
compiled and ran fine. I then added ofxAudioUnit to the AddOn folder, and
it failed to compile with the errors "gltypes.h included before glew.h" and
"error: typedef redefinition with differen ttypes...".
Wondering if anyone has similar problems.
Thanks.
Sam
—
Reply to this email directly or view it on GitHub
https://github.com/admsyn/ofxAudioUnit/issues/25.

--
Jason Levine
new media performer + creative coder
https://www.behance.net/jasonlevine https://www.behance.net/jasonlevine

I was on OF0.8.4 + XCode 6 to begin with. When I updated to XCode 7, it complained about openssl problem. Web searching pointed me to OF0.9 to fix this issue, but then the gltypes.h/glew.h problem appeared.
Any help on the openssl issue?
Thanks.

But it worked with OF0.8.4 + XCode 6, correct?  Xcode 7 is probably
assuming you are running osx10.11.  Find any incidences of 10.11 in you
build settings an change them to 10.10 or whatever system you are running.
The  gltypes.h/glew.h problem sounds like a change in the OF core
which ofxAudioUnit
is probably not caught up to.
@admsym can you comment on ofxAudioUnit OF0.9.0 compatibility?
On Thu, Sep 17, 2015 at 4:40 PM, stswong<EMAIL_ADDRESS>wrote:

I was on OF0.8.4 + XCode 6 to begin with. When I updated to XCode 7, it
complained about openssl problem. Web searching pointed me to OF0.9 to fix
this issue, but then the gltypes.h/glew.h problem appeared.
Any help on the openssl issue?
Thanks.
—
Reply to this email directly or view it on GitHub
https://github.com/admsyn/ofxAudioUnit/issues/25#issuecomment-141221987.

--
Jason Levine
new media performer + creative coder
https://www.behance.net/jasonlevine https://www.behance.net/jasonlevine

Yup, it has been working great with OF0.8.4 + XCode 6. I have been targeting for 10.6 and now 10.7. I am currently downloading XCode 6.4...

I'm back to OF0.8.4 + XCode 6 and everything works again! I copied my code to OF0.9.0 and with the latest ofxAudioUnit and it works too. So going to XCode 7 caused two problems:
openssl.h problem in OF0.9.0 itself
glew.h problem in ofxAudioUnit
Thanks.

I was just dealing with that today, upgrading OFXcodeMenu! I'll look into it, but it's really weird :)

Alright, looks like there was some new weird behaviour happening with the Objective-C++ compilation necessary for the ofxAudioUnit::showUI(...) function. Reworked the inclusion hierarchy to be a little bit cleaner, so gltypes.h / glew.h never enter the picture.
Let me know if you still see the issue, but it looks fixed to me!

It all compiles and works now, OF0.9 and Xcode 7.
Thanks.
Sam.
From: Adam Carlucci <notifications<EMAIL_ADDRESS>Reply-To: admsyn/ofxAudioUnit <reply<EMAIL_ADDRESS>Date: Thursday, September 24, 2015 at 8:56 PM
To: admsyn/ofxAudioUnit <ofxAudioUnit<EMAIL_ADDRESS>Cc: Sam Wong <sam<EMAIL_ADDRESS>Subject: Re: [ofxAudioUnit] XCode 7 (#25)
Alright, looks like there was some new weird behaviour happening with the Objective-C++ compilation necessary for the ofxAudioUnit::showUI(...) function. Reworked the inclusion hierarchy to be a little bit cleaner, so gltypes.h / glew.h never enter the picture.
Let me know if you still see the issue, but it looks fixed to me!
—
Reply to this email directly or view it on GitHubhttps://github.com/admsyn/ofxAudioUnit/issues/25#issuecomment-143117738.


How do i pass Parameter

How do i pass parameter into where clause?because i need to do some filtering before showing the data table like date between from and to

Nevermind...you can do it as usual,you can use either using $_GET or $_POST


[Request] Awesome Flutter Project Test

Please provide links and information in the following format
github:  https://github.com/karx/homepage
tag: none
excerpt:   wow

        #### Thank you karx for submitting a new weapon for the __FlutterArsenal__.

        The github repository: _karx/homepage_ is now awaiting approval from __admins__.
        Kudos to you for contributing!

        #### Thank you karx for submitting a new weapon for the __FlutterArsenal__.

        The github repository: _karx/homepage_ is now awaiting approval from __admins__.
        Kudos to you for contributing!

test

Thank you karx for submitting a new weapon for the FlutterArsenal.
        The github repository: _karx/homepage_ is now awaiting approval from __admins__.
        Kudos to you for contributing!

Thank you karx for submitting a new weapon for the FlutterArsenal.
The github repository: karx/homepage is now awaiting approval from admins.
Kudos to you for contributing!

Thank you karx for submitting a new weapon for the FlutterArsenal.
The github repository: karx/homepage is now awaiting approval from admins.
Kudos to you for contributing!

Thank you @karx for submitting a new weapon for the FlutterArsenal.
The github repository: karx/homepage is now awaiting approval from admins.
Kudos to you for contributing!


Missing Fields in DCR Rest API

Describe the issue:
Some fields are missing in the response body of DCR Rest API [1] GET https://localhost:9443/api/identity/oauth2/dcr/v1.1/register/:client_id.
For example,
The following fields (requested in https://github.com/wso2/product-is/issues/14959) are not present.
application_type
ext_display_name
ext_application_token_lifetime
ext_user_token_lifetime
ext_refresh_token_lifetime
ext_id_token_lifetime
ext_public_client

Also observed that PKCE related info are not available as well. Eg:
pkce_mandatory
pkce_support_plain

The response body that is shown now is as follows:
{
    "client_id": "xTyk2usLKfGDSG4J2n9J0apHafYa",
    "client_secret": "LNbnnfl_qo04zQDvGxU97wcY3UQhhY4LpWFtHIcFyX4a",
    "client_secret_expires_at": 0,
    "redirect_uris": [
        "http://localhost:5678"
    ],
    "grant_types": [
        "urn:ietf:params:oauth:grant-type:saml2-bearer",
        "client_credentials",
        "iwa:ntlm",
        "urn:ietf:params:oauth:grant-type:device_code",
        "refresh_token",
        "password",
        "authorization_code",
        "urn:ietf:params:oauth:grant-type:token-exchange",
        "urn:ietf:params:oauth:grant-type:jwt-bearer"
    ],
    "client_name": "ApplicationCreatedFromDCRCall_Mod",
    "jwks_uri": null,
    "token_endpoint_auth_method": null,
    "token_endpoint_auth_signing_alg": null,
    "sector_identifier_uri": null,
    "id_token_signed_response_alg": null,
    "id_token_encrypted_response_alg": "null",
    "id_token_encrypted_response_enc": "null",
    "request_object_signing_alg": null,
    "tls_client_auth_subject_dn": null,
    "require_pushed_authorization_requests": false,
    "require_signed_request_object": false,
    "tls_client_certificate_bound_access_tokens": false,
    "subject_type": "public",
    "request_object_encryption_alg": null,
    "request_object_encryption_enc": null,
    "software_statement": null
}

How to reproduce:
Below are the steps I have gone through

Created an application via POST https://localhost:9443/api/identity/oauth2/dcr/v1.1/register, with the following payload:

{
  "client_name": "ApplicationCreatedFromDCRCall",
  "redirect_uris": [
    "http://localhost:1234"
  ]
}

Edited the above application via PUT https://localhost:9443/api/identity/oauth2/dcr/v1.1/register/:client_id, with the following payload:

{
  "redirect_uris": [
    "http://localhost:5678"
  ],
  "client_name": "ApplicationCreatedFromDCRCall_Mod",
  "client_id": "xTyk2usLKfGDSG4J2n9J0apHafYa",
  "client_secret": "LNbnnfl_qo04zQDvGxU97wcY3UQhhY4LpWFtHIcFyX4a",
  "grant_types": [
    "password",
    "client_credentials",
    "refresh_token",
    "urn:ietf:params:oauth:grant-type:saml2-bearer",
    "iwa:ntlm",
    "urn:ietf:params:oauth:grant-type:device_code",
    "authorization_code",
    "urn:ietf:params:oauth:grant-type:jwt-bearer",
    "urn:ietf:params:oauth:grant-type:token-exchange"
  ],
  "ext_application_token_lifetime": "3600",
  "ext_user_token_lifetime": "3600",
  "ext_refresh_token_lifetime": "3600",
  "ext_id_token_lifetime": "3600",
  "ext_pkce_mandatory": "true",
  "ext_pkce_support_plain": "true",
  "ext_public_client": "true"
}

Performed GET https://localhost:9443/api/identity/oauth2/dcr/v1.1/register/:client_id

Expected behavior:

Environment information (Please complete the following information; remove  any unnecessary fields) :

Product Version: IS 7.0.0-beta4
OS: Mac

Optional Fields
Related issues:

Suggested labels:

[1] https://is.docs.wso2.com/en/next/apis/use-the-openid-connect-dynamic-client-registration-rest-apis/

Hi Team,
I checked the same with the RC1 pack, and still noticed that some of the fields are not present. For example:
The following from my original request at this issue's description:
application_type
ext_display_name

Some fields like token_type_extension.
Ideally, all the fields we can send in the payload of the POST /register, should be present in the response payload of the GET as well.
Can we get this fixed pleae?

As agreed in the following comment [1],  the parameter token_type_extension is not added to both 'POST' or 'GET'. The yaml file contains few stale data and we will add a task to improve the yaml file. If you have a requirement to add those parameters to the IS core (Both POST and GET) please initiate a request for it, so we can evaluate.
[1] https://github.com/wso2/product-is/issues/14959#issuecomment-1554456852

@DMHP I could use token_type_extension in POST.
I sent the following body payload to POST https://{{serverUrl}}/api/identity/oauth2/dcr/v1.1/register:
{
  "client_name": "ApplicationCreatedFromDCRCall2",
  "redirect_uris": [
    "http://localhost:1234"
  ],
  "token_type_extension": "JWT"
}

This creates an application, and when I view that application in the console, I can see that JWT has been selected under Access Token -> Token Type.

But when I execute GET https://{{serverUrl}}/api/identity/oauth2/dcr/v1.1/register/:client_id, I get the following payload, in which, no information about this token_type_extension is present (although it's available in the UI):
{
    "client_id": "uq_zXhSOHfwdNWrSfb44so0KRTga",
    "client_secret": "e4SF53S6pFSdSoPr8I9b6AZjTWrrO6CI91bDrMRHiUMa",
    "client_secret_expires_at": 0,
    "redirect_uris": [
        "http://localhost:5678"
    ],
    "grant_types": [
        "password",
        "client_credentials",
        "refresh_token",
        "urn:ietf:params:oauth:grant-type:saml2-bearer",
        "iwa:ntlm",
        "urn:ietf:params:oauth:grant-type:device_code",
        "authorization_code",
        "urn:ietf:params:oauth:grant-type:jwt-bearer",
        "urn:ietf:params:oauth:grant-type:token-exchange"
    ],
    "client_name": "ApplicationCreatedFromDCRCall_Mod",
    "ext_application_display_name": null,
    "ext_application_owner"<EMAIL_ADDRESS>    "ext_application_token_lifetime": 3600,
    "ext_user_token_lifetime": 3600,
    "ext_refresh_token_lifetime": 3600,
    "ext_id_token_lifetime": 3600,
    "ext_pkce_mandatory": true,
    "ext_pkce_support_plain": true,
    "ext_public_client": true,
    "jwks_uri": null,
    "token_endpoint_auth_method": null,
    "token_endpoint_auth_signing_alg": null,
    "sector_identifier_uri": null,
    "id_token_signed_response_alg": null,
    "id_token_encrypted_response_alg": "null",
    "id_token_encrypted_response_enc": "null",
    "request_object_signing_alg": null,
    "tls_client_auth_subject_dn": null,
    "require_pushed_authorization_requests": false,
    "require_signed_request_object": false,
    "tls_client_certificate_bound_access_tokens": false,
    "subject_type": "public",
    "request_object_encryption_alg": null,
    "request_object_encryption_enc": null,
    "software_statement": null
}

Basically, all the attributes we already support sending in the POST request payload, should be returned in the GET response payload as well. Is it possible to add the exhaustive list of attributes in the GET response payload?


Need an 'x' button.

Type: Feature Request
Why is there no x button on the copilot terminal prompt? It is taking up too much screen space to use the terminal comfortably!
Extension version: 0.23.2
VS Code version: Code 1.96.2 (fabdb6a30b49f79a7aba0f2ad9df9b399473380f, 2024-12-19T10:22:47.216Z)
OS version: Windows_NT x64 10.0.19045
Modes:
Remote OS version: Linux x64 <IP_ADDRESS>-microsoft-standard-WSL2

Pressing ESC closes the inline chat widget in the terminal.


add check for null measurement

Fix #1556

Browse[1]> gaussian_mechanism(arg=123.0)
Error in measurement_invoke(ptr, arg) :
  Measurement is a null pointer. Reusing measurements from previous sessions is unsupported.

... but maybe this should be at a higher level? I'm also not sure about the best way of testing this: just calling measurement_invoke with a null pointer is contrived, and if the implementation changed, the test wouldn't necessarily keep up.
This approach to testing for null pointer is from https://stackoverflow.com/a/27350487/10727889

@Shoeboxam -- This would be a change to the generated code, and would be applied to all the functions. Before I invest time in code generation, can you give your thoughts on this much?

Do you think you could avoid the need for codegen changes but get the same errors by adjusting a lower-level helper function?
I would think the code paths would all pass through the sexp_to_* functions here:
https://github.com/opendp/opendp/blob/main/R/opendp/src/convert_elements.c

I myself feel less confident in the C code than in the R, but that doesn't mean the R is the best place. We can figure out the best direction when you're back.

But if this could be addressed at a lower level, maybe that also means there's a way for this problem in Python? That would actually be a good thing, because I'm more confident about testing and debugging the Python API.

Since the time this was originally filed, we've git ignored the generated files, so I'm much less concerned about keeping everything in sync. If I follow the steps in the original reproducer, I now see:
> gaussian_mechanism(arg=123.0)
Error in measurement_invoke(ptr, arg) :
  Got null pointer. Reusing objects from previous sessions is unsupported.

#1563  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @mccalluc and the rest of your teammates on  Graphite

Updated code now fails with the following message:
> meas("input_domain")
Error in measurement_input_domain(ptr) :
  Got null pointer. Reusing a measurement from a previous session is not supported.


Feature Request: Monte Carlo UI

Per user request in GEOPHIRES workshop

Now available at https://gtp.scientificwebservices.com/monte-carlo/

Now available at https://gtp.scientificwebservices.com/monte-carlo/


ResolveUrl Analytics always returning null

Hey there im trying to resolve shortened google urls and getting data but response.analytics is always returning null do i need to add an api or set another service key?

when you create the urls and request them back you need to be authenticated with the same user using oauth2.


Hashes in the path are not allowed

I'm able to do the following in webpack:
module.exports = {
    ...
    output: {
        path: path.resolve('../webpack_bundles/[hash]'),
        filename: '[name].js',
    },
    ...
};

But django-webpack-loader doesn't allow that. Here you expect to have a path to the chunk. But if the hash is in the path, it's not known in advance.
Can't we add, say, BUNDLE_DIR_PATH and do something along these lines?
import os.path
if 'BUNDLE_DIR_PATH' in self.config:
    relpath = os.path.relpath(chunk['path'], self.config['BUNDLE_DIR_PATH'])

Related https://github.com/django-webpack/django-webpack-loader/issues/178


Stopping condition. Won't be executed

		        // Stopping condition. When the event is from a new participant, we
			// don't want to go all the way down to the bottom of the hashgraph.
			// So we stop at the ancestors that are witnesses.
			if w, err := h.witness(ah); err != nil && w {
				break
			}

h.witness()  will not return err and true  at the same time。
func (h *Hashgraph) witness(x string) (bool, error) {
	if c, ok := h.witnessCache.Get(x); ok {
		return c.(bool), nil
	}
	r, err := h._witness(x)
	if err != nil {
		return false, err
	}
	h.witnessCache.Add(x, r)
	return r, nil
}

Good catch, thanks!

Fixed here: https://github.com/mosaicnetworks/babble/commit/f0d6549bf30f8cbe557090126cbf3d9ec9f89ba7


EF Core 1.1 support

Good day.
Could you tell me, whether there were plans develop and support EF-Core-Security in future?
I tried to use the SecurityDbContext and EF Core 1.1 but I failed.
I can use context.Add()/SaveChanges() methods, but any selection queries (context.Find() or db set using) cause following exception :
" System.MissingMethodException . Void Microsoft.EntityFrameworkCore.Query.QueryContextFactory..ctor(Microsoft.EntityFrameworkCore.ChangeTracking.Internal.IStateManager, Microsoft.EntityFrameworkCore.Internal.IConcurrencyDetector, Microsoft.EntityFrameworkCore.ChangeTracking.Internal.IChangeDetector)".
in line
public override IQueryContextFactory QueryContextFactory => GetService<SecurityQueryContextFactory>() ;
SecurityDatabaseProviderServices.cs file.
At the same time if I use default EF DbContext then all is well.
Is there any way to solve this problem?
Thansk in advance.

Hello,
I've updated the project so that it supports the EF Core 1.1.0.
Even though this project is experimental (mainly for EF Core research purposes) and there is no active development to it, we are always happy to hear your feedback and suggestions or make corrections, if necessary. In particular, our team will be very interested to learn about your real world use-case scenarios and how our project helps you handle them. In addition, it would be great to hear of other options (e.g., ASP.NET Core Identity) you considered prior to visiting our GitHub page and their benefits/weaknesses for your tasks.


SyntaxError: unqualified exec is not allowed in function 'recordtype' it contains a nested function with free variables

Error in running or importing smop with python 2.7.5
$ smop test.m
Traceback (most recent call last):
  File "/home/scott/.local/bin/smop", line 11, in <module>
    load_entry_point('smop==0.41', 'console_scripts', 'smop')()
  File "/home/scott/.local/lib/python2.7/site-packages/pkg_resources/__init__.py", line 476, in load_entry_point
    return get_distribution(dist).load_entry_point(group, name)
  File "/home/scott/.local/lib/python2.7/site-packages/pkg_resources/__init__.py", line 2700, in load_entry_point
    return ep.load()
  File "/home/scott/.local/lib/python2.7/site-packages/pkg_resources/__init__.py", line 2318, in load
    return self.resolve()
  File "/home/scott/.local/lib/python2.7/site-packages/pkg_resources/__init__.py", line 2324, in resolve
    module = __import__(self.module_name, fromlist=['__name__'], level=0)
  File "/home/scott/.local/lib/python2.7/site-packages/smop/main.py", line 16, in <module>
    from . import parse
  File "/home/scott/.local/lib/python2.7/site-packages/smop/parse.py", line 7, in <module>
    from . import node
  File "/home/scott/.local/lib/python2.7/site-packages/smop/node.py", line 8, in <module>
    from . recipes import recordtype
  File "/home/scott/.local/lib/python2.7/site-packages/smop/recipes.py", line 128
    exec(template, namespace)
SyntaxError: unqualified exec is not allowed in function 'recordtype' it contains a nested function with free variables

$ smop --version
0.41

Anything weird about my setup? Or has this happened before?

hmm I actually can't get it to reproduce this bug now.. The "test.m" was actually a few different files that I swapped out, it seemed to be throwing this error for anything I tried.
I can close this if you'd like since I can't give you better directions right now.

I got it to work by reverting to the old exec syntax at https://github.com/victorlei/smop/blob/master/smop/recipes.py#L128
exec(template, namespace) -> exec template in namespace

@Victordmdb Thanks I was facing the same problem and making the change recommended by you fixed it.
@victorlei can you reopen this ticket and see of the fix by @Victordmdb is good to go in the production code.

Just got this exact issue.
Freshly installed SMOP on CentOS7 through pip, tried to translate https://github.com/MrRedstoner/rp2019/blob/master/matlab/Cvicenie2/bisekcia.m and got the error repeatedly. Manually modifying /usr/lib/python2.7/site-packages/smop/recipes.py to perform the change mentioned by @Victordmdb  did stop this error, instead I got 2 token unused warnings, a lot of str in the console, and no new file has appeared in the directory


readability changes to description fields

Details
I spotted a couple of descriptions for the response status codes did not match so changed those.
Then i spotted that Source was always referenced with initial caps but Flow, Segment and Tag was not so decided to change those.
Finally my OCD kicked in with a couple more changes.
I have ONLY changed content of description fields so nothing functionally changes with this PR.
Pivotal Story (if relevant)
Story URL: n/a
Related PRs
n/a
Submitter PR Checks

[ ] PR completes task/fixes bug
[ ] API version has been incremented if necessary
[ ] ADR status has been updated, and ADR implementation has been recorded
[ ] Documentation updated (README, etc.)
[ ] PR added to Pivotal story (if relevant)
[ ] Follow-up stories added to Pivotal

Reviewer PR Checks
(tick as appropriate)

[ ] PR completes task/fixes bug
[ ] Design makes sense, and fits with our current code base
[ ] Code is easy to follow
[ ] PR size is sensible
[ ] Commit history is sensible and tidy

Info on PRs
The checks above are guidelines. They don't all have to be ticked, but they should all have been considered.

Closing this PR as almost all changes are very minor. I have supplied the actual mistakes via Slack to make it easier.


count_lang_repos is the same as parse_lines

count_lang_repos should call parse_lines as they are the same function just run on all repos vs individually.
we can sum count_lang_repos to get what parse_lines is used for in main

removed the duplicated logic by using a default empty string repo parameter


add code climate configuration

Coverage remained the same at 30.647% when pulling f62848a31fcba4ad37f8ad569fb6b97bf4e04b7f on feature-code-climate into d56ca9c1b05b234d5787718dd482e710cc66e45f on master.

Coverage remained the same at 30.647% when pulling f6806ac3ec700c770f0632778469366cf0831720 on feature-code-climate into d56ca9c1b05b234d5787718dd482e710cc66e45f on master.

Coverage remained the same at 30.647% when pulling b35ee6987a9fd3b846ad4ab93e566232b45c287a on feature-code-climate into d56ca9c1b05b234d5787718dd482e710cc66e45f on master.

Approved

Approved

Coverage remained the same at 91.791% when pulling 3bc069572432365402304972790a8cbe46bc332e on feature-code-climate into 8cb2f55ff02129f195220a8ec169ac1c1e376511 on master.


Order of hyena operation

The order of operation described in the hyena paper was conv in time domain first then frequency domain.
But the implementation in this repo does conv in frequency domain first then time domain.
Am I missing something?
https://github.com/HazyResearch/safari/blob/main/src/models/sequence/hyena.py#L339

This small change was to accommodate checkpoints of models trained on a different codebase, the order of these two ops does not make a huge difference as long as you perform both (see how there is an additional gating at the output, so you can view the sequence of ops as pre-gate followed by the regular conv-gate order described in the paper).

Thanks for the clarification!

Sorry but I have one more question. Doesn't current implementation reduces the number of time domain conv?
For example, in the paper order-2 hyena (which is corresponds to H3) has two frequency domain conv and two time domain conv. But for current implementation, the order-2 hyena has two frequency domain conv and a single conv time domain conv. Should I just think that order-2 hyena in current code is equivalent to order-1 hyena in the paper?

that's correct there is one less long convolution in the current implementation. The number of total time-domain convolutions is still 2 if you count the short input convolution (which replaces the shift SSM in H3). The changes were made to carry out fair ablations (in terms of total FLOPs and model depth) between H3 and order-2 Hyenas.

The number of total time-domain convolutions is still 2 if you count the short input convolution (which replaces the shift SSM in H3).

Which means that order-2 hyena with short conv + long conv is used for all evaluations in the paper?

The changes were made to carry out fair ablations (in terms of total FLOPs and model depth) between H3 and order-2 Hyenas.

When just comparing model quality without consideration of FLOPs, is order-2 hyena with two long conv better than a short-conv and a long-conv? or is this short-conv essential for model quality?

Which means that order-2 hyena with short conv + long conv is used for all evaluations in the paper?

Yes, anywhere we state Hyena-2 in the manuscript. There are some experiments with other orders (e.g. wikitext).

When just comparing model quality without consideration of FLOPs, is order-2 hyena with two long conv better than a short-conv and a long-conv? or is this short-conv essential for model quality?

Higher orders can be more performant depending on the task.


Adds configuration options for context-specific arity uniqueness rules

Problem
We needed the ability to set arity uniqueness rules based on the type of uniqueness desired (unique_at_runtime, unique_in_queue, unique_across_queues). Some of our jobs need to be unique at runtime for the first parameter, but re-queable with different second and third parameters.
Solution
This PR adds 3 new configuration options (arity_for_uniqueness_at_runtime, arity_for_uniqueness_in_queue, arity_for_uniqueness_across_queues) which allow us to handle the complex uniqueness rules of our application.

@pboling

This is so cool.  Thank you. 💯 Glad to know people have found this project and are using it!


Create @types for log-driver

We're currently using the log-driver npm module:
https://github.com/cainus/logdriver
There are currently no @types available for it.  We should submit a PR to add them to DefinitelyTyped.

Not a problem since we got rid of log-driver all together 😄 Resolved by #97


Add autoselection behaviour for select

Coverage decreased (-1.4%) to 93.391% when pulling 05de19f1018d3b64655a06730f73f87587d00a41 on kononenko-a-m:master into e36a88eff2f6ee99a513fe03b9f12472dce1be4d on mseemann:master.

thx! will have a look - but I'm afraid I need some time for this :(

can you check my comments? also: if there is not enough space under the select component the options will open above the component. But this will hide the select input control I think we have to make sure that the options list is always under the select component if the autoselect feature is used.

about space above select component - we might optionally show it exactly above input so it wouldn't cover input

need to see how this looks if the popup opens above the input control...

@mseemann I've renamed feature, so now it's can be enabled, and disabled by default. fixed on mobile, right now it would be shown above input, but it works in such way only for new feature

@kononenko-a-m sorry for the delay:( thx for your work!


Substitute links to improved docs.

Replace links to API docs with links to resource docs.  Initially this pull request includes blog posts and guides, I will continue to update other content in a new PR.
Issue #2887

In addition, for the relref's I think should also end with a trailing /, IFF there isn't an anchor link.

This is not required actually.


Provide easy way to init store

It looks to me that if using getInitialStateRender in the renderer process, than we have explicitly to set the initial state at the main process as global variable reduxState, however I couldnt find this documented anywhere, except in the source code itself

Hey @rsaccon . That's already happening in https://github.com/hardchor/electron-redux/blob/master/src/helpers/replayActionMain.js#L5-L8, so a manual step shouldn't be necessary? Are you having trouble getting the renderer store initialised?

Ok, thanks, I guess now all is clear, I just set optionally the initialState at main to some value and use getInitialStateRenderer  at renderer. Thanks again.

No worries, please let me know if the docs need to be a bit clearer in that respect.

No worries, please let me know if the docs need to be a bit more clear in
that respect
On Sun, 23 Oct 2016, 10:45 Roberto Saccon<EMAIL_ADDRESS>wrote:

Ok, thanks, I guess now all is clear, I just set optionally the
initialState at main to some value and use getInitialStateRenderer at
renderer. Thanks again.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/hardchor/electron-redux/issues/4#issuecomment-255578829,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AASv2u9NDFMey-_tz-CLFTTGNK7tyKShks5q2yzPgaJpZM4KVoXK
.


New package: chaiNNer-org.chaiNNer version 0.19.2

[x] Have you signed the Contributor License Agreement?
[x] Have you checked that there aren't other open pull requests for the same manifest update/change?
[x] This PR only modifies one (1) manifest
[x] Have you validated your manifest locally with winget validate --manifest <path>?

[x] Does your manifest conform to the 1.5 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: codeflow:open?pullrequest=https://github.com/microsoft/winget-pkgs/pull/116831&drop=dogfoodAlpha

Manifest Error: Field usage requires verified publishers. [Icons]

Hi @KK-Designs,
I'm not sure if we're accepting icons quite yet.

@KK-Designs,
Your manifest appears to contain one or more issues with the content. Please ensure it meets the contribution guidelines.
* Manifests should be tested to ensure applications can install unattended

* Manifests should be tested to ensure application version matches the Package Version, or that AppsAndFeaturesEntries are included if necessary

* Manifests should be tested to ensure application publisher matches the defaultLocale Publisher, or that AppsAndFeaturesEntries are included if necessary

* Manifests should be tested to ensure application name matches the defaultLocale PackageName, or that AppsAndFeaturesEntries are included if necessary

Please review your manifest and make the appropriate changes. This PR will be automatically closed if no changes are made.
Template: msftbot/validationError/manifest/contentIncomplete

Whats this? I created this using the wingetcreate.exe

/AzurePipelines run

Hi @KK-Designs,
I'm sorry for applying that label and causing you some concern. It was in error and I meant to retry the PR instead.

Is the PR ok and valid?

Fixed the invalid icons


feat: Added metadata saving in PPSimulation_2DContinuous

Fixes #81

I thank you pointing it out, @OskarElek. I will address the adjustments in the upcoming PR.


Create a Front Page/Landing Page

Create a landing page that explains a little about dAcademy before going directly into playbooks.

Make this a page also above organization bookshelf cards.
Include logos for

Optimism
The Graph
IPFS
Envio
Quest Chains
?


cannot find a .min.js in the distribution folder

Hi
I cannot find a .min.js  or a umd.min.js file for ng2-validation please help or email it
laz

I'm sorry. You have to use npm to install this validation.

please use the latest version, you can see the bundles/ng2-validation.umd.js


Include pkg/steep_icecavity by leveraging pkg/shelfice files

What changes does this PR introduce?
This PR is based on Martin's PR #772, which offers an alternative method for including pkg/steep_icecavity as initially implemented in PR #368. This alternative method leverages existing files in pkg/shelfice, ensuring that pkg/steep_icecavity contains only the minimal necessary files. As a result, many files present in PR #368's version of pkg/steep_icecavity are eliminated.
What is the current behaviour?
(You can also link to an open issue here)
What is the new behaviour
(if this is a feature change)?
Does this PR introduce a breaking change?
(What changes might users need to make in their application due to this PR?)
Other information:
Suggested addition to tag-index
(To avoid unnecessary merge conflicts, please don't update tag-index. One of the admins will do that when merging your pull request.)

@owang01, changes look good, except that a new directory pkg/stepice appeared in the last commit. Probably not on purpose ...

As discussed today, we will explore how to avoid setting temp_addMass and specially salt_addMass to `UNSET_RL.

@mjlosch Thank you for fixing these variable storage issues!

I did not check pieces of code inside pkg/steep_icecavity but have few comments regarding interfaces:

ctrl_map_ini_genarr.F does not look right to me: e.g., in isomip/input_ad/data.ctrl,  'xx_shicoefft' was (and is still) set in genarr2d, but is now ignored since ALLOW_SHITRANSCOEFF_3D is defined.
in shelfice_forcing.F, I understand that SHELFICEboundaryLayer cannot be used with useSTIC=T (stic_check.F), but it seems that the units of shelficeForcingT are different when useSTIC=T and useSTIC=F. This is (very) confusing. If they have to be different (with different units) then we should use a different array.
since the only thing shelfice_thermodynamics.F does when useSTIC=T is to call STIC_THERMODYNAMICS, suggest to move this call directly to do_oceanic_phys.F.
there is no reason to update anything in external_forcing.F (the purpose to keep this file is precisely to keep it unchanged, just for USE_OLD_EXTERNAL_FORCING).
could we rename "icfForcingT/S" to something else ?  e.g., stic_ForcingT or  stic_steep_gT or stic_side_gT or stic_front_gT ?
curious that we need to store shiTransCoeffS in shelfice_ad_check_lev{2,3,4}_dir.h but
a) not shiTransCoeffT   -- and -- b) only when ALLOW_STEEP_ICECAVITY ?

Also, in general, would prefer to avoid using "ICE FRONT" (like in shelfice_forcing.F), specially if it's outside pkg/steep_icecavity, unless it relates to pkg/icefront.
I did not check (yet) what the

@jm-c Thank you for your comments. I will have a closer look in a few days.

Regarding temp_addMass & salt_addMass:
Replacing the resetting of these 2 to UNSET_RL (January and earlier version) by adding ".AND. .NOT.useSTIC" in apply_forcing.F does not go in the right direction (it's even less transparent with a miss-leading report in config_summary
and a hack in apply_forcing.F).
So here are the 2 options:

we keep this implementation of pkg/steep_icecavity 3-D fresh-water input which only works with temp_addMass = salt_addMass = UNSET_RL
we change the implementation of pkg/steep_icecavity 3-D fresh-water input to be consistent with temp_addMass = salt_addMass = 0.

There are advantages with going with (2) as I mentioned in my comments to PR #682 (on Mar 25, 2023) and can repeat these here if needed.
Now if we go with (1), I would recommend to remove the changes to "apply_forcing.F" and to add a stop in stic_check.F if either temp_addMass or salt_addMass are not equal to UNSET_RL.

@jm-c I have addressed some of your comments in the new commits. More updates to follow.

I also noticed that I can fix many hidden recomputations of density in do_oceanic_phys.F but changing two store directives.

@jm-c I have updated stic_thermodynamics.F to handle the case of non-UNSET_RL temp_addMass and salt_addMass, as suggested in your second option.

I've just checked the changes/addition to isomip experiment and it's good. I updated the 2 new reference output since the previous ones were not that recent (with many more lines in the old output_adm.stic.txt).

@jm-c Thank you for your review and approval. Regarding your two comments, I keep the CPP option ALLOW_SHITRANSCOEFF_3D, since one could turn it off to not declare some 3d arrays and also make the model run a bit faster. I have removed some unnecessary header files in stic_solve4fluxes.F.

@owang01 So everything is good and I think this PR is ready to be merged. Do you agree ?
If yes then will merge it soon (like later today), unless someone wants to add something (@mjlosch are you OK with this ?).

Thanks @jm-c. LGTM. Also, a big thank-you to @mjlosch for all the contributions to this PR.


Webhook/endpoint to create "incidents" in the system on-demand

Why do we need this ?
Currently the system relies on reverted PRs for CFR/MTTR data, only.
With support for webhooks, we might be able to link a variety of third party incident management solutions to Middleware for better Dora metrics reporting.
Should be straight-forward enough.

@jayantbh could please assign this issue to me, i would like to build this feature.

@jayantbh I was researching the webhook implementation and just need a quick clarification: what specific fields/parameters should we expect from third-party systems for each incident? (I'm thinking incident ID, severity, description, detected timestamp).

https://github.com/middlewarehq/middleware/issues/562#issuecomment-2397665815
Please check out the guidelines in this issue. These two issues are very similar in implementation and would largely use the similar services and APIs that one of these issue end up implementing. So before we begin the implementation it is better to have the approach well discussed and documented here. This is a rather challenging and time taking task.
As for the what request body we want from the user, you can read through the incident service to get a better understanding of our system.

@xyfer17 @divyanshu-dj ^ the linked comment will offer much needed context.


Yaml perturbators

@brianhhu
I guess now we need someone to write the yaml to describe the parameters for any given perturber that we want to ingest inside NRTK explorer.
That file can be loaded at runtime via an environment variable NRTK_TRANSFORM_DEFINITION=/path/to/a/file.yaml


Return long form of a queue for lease task REST calls

https://ocd.appscale.com:8080/job/Daily Build/1937/

:+1:


workers are not terminated

Even official demo page 'https://jnordberg.github.io/gif.js/'
Workers are not terminated after generate GIF.

How can I terminate Workers?

Also running into this, workers are piling up. .abort() only works for active workers, and reusing the gif instance causes an error when .render() gets called again.

Workaround: The workers can be accessed through GIF.freeWorkers. To clean up, call:
gif.freeWorkers.forEach(w => w.terminate());

You actually have to call
gif.abort();
at it clears a status variable too.


pkgsMerge: automatic buildEnv's with chained packages

Motivation for this change
nix shell nixpkgs#hello nixpkgs#cowsay nixpkgs#dash -c dash -c 'hello|cowsay'

is awkward and repetitive. Especially if trying to use a flake not in the registry (eg: a github flake URI). This also doesn't look very nice in a shebang (https://github.com/NixOS/nix/pull/5189). The idea is to utilize syntax similar to https://github.com/DavHau/mach-nix and https://nixery.dev/. This change makes it easy to make a buildEnv by chaining together packages.
nix shell nixpkgs#pkgsMerge.hello.cowsay.dash -c dash -c 'hello|cowsay'

Things done
Added an adapter alongside other pkgs* which recursively places all of top-level packages into the passthru of a buildEnv derivation. As one traverses through the passthru's, the paths are collected and incorporated into a buildEnv.
design decisions to think about:

Name? pkgsMerge, pkgsEnv?
Should order matter? When used with nix run we must pick either first or last item.
Use first or last item's mainProgram value? Currently this uses the last item in the list.
Alias? "+" is convenient, but probably a bit too much overloading?
nix run nixpkgs#pkgsMerge.hello.cowsay.bash doesn't work as expected due to PATH not being set for the program. This could be fixed in Nix pretty easily by setting the PATH to the merged-environment/bin itself around here
does not work with non-top level derivations (eg: python, but we have mach-nix for that!)

This also works as an independent flake!
nix shell github:tomberek/-#pkgsMerge.hello.cowsay.dash -c dash -c 'hello|cowsay'

TODO

[ ] get feedback
[ ] finalize design
[ ] docs
[ ] nix run fixes

Please don't do this. It creates problems rather than solve any.
I condemn "fluent apis" because

they create wrong expectations
they abuse syntax, inhibiting learning. . is generally supposed to access a "part" or "method", not to combine arbitrary stuff
they inevitably have limitations that cause a casual contributor to some project to get stuck

does not work with non-top level derivations

they don't follow the rules for proper composition

An alternative solution: use bash syntax: nixpkgs#{hello,figlet,cowsay}
This could be added to the shebang parser as well.

I appreciate the out-of-the-box thinking though :)


Vireio Perception 3.0 compatibility

Hi,
I was thinking of using Vireio + OGO + ALVR for playing older dx9 games (e.g. Fallout New Vegas) in 3D with SBS.
For the first without any special controller besides keyboard and mouse.
There are videos and instructions on youtube doing it with vorpx and "real" oculus rift/htc vive.
Is it possible to use such a virtual stereo injector like Vireio with ALVR?
I only get steam to run the game in cinema mode displaying the SBS picture there on "big screen".
BTW: I had partially success with using moonlight only, but it not only is unstable (with an old apk which still supports SBS) but also as there then is no headtracking you get sick quite fast.
For reference, I am speaking about version 3 (https://www.mtbs3d.com/downloads-section/viewdownload/21-vireio-perception-3-0/72-vireio-perception-3-0-1-vr-boost) as version 4 seem to only be working for dx11 games.
Best Regards, Greenfrog

vorpx can work with ALVR. https://github.com/polygraphene/ALVR/issues/51
ALVR is a driver of SteamVR. You may get it to work in a similar way for Vive.

I am aware that vorpx is working with ALVR. I have no Vive, otherwise I would not need ALVR. But there are Videos, that you can play with a Oculus Rift over S
My question is, if there is a way to get Vireio to work with ALVR, so for example if there is a missing link where ALVR could tell steam that the video shall be streamed directly like it is rendered to the oculus go or so without using cinema mode; picture is already SBS.
I guess, it is vireio which is not working together with SteamVR (as it is quite old) but using some other older way to use Oculus Rift directly.

Vireio is driver for run game in SBS 3D mode, then you can stream game to OgO with Moonlight for Go and watch on "big screen" like in big 3D Tv.
If you want play game in full 3D environment, then you must buy VorpX and you can use ALVR to streram game to OgO.

That's a difficult issue.
We need one of the following solutions:

Create driver which bridges between SteamVR and old Rift driver.
Add features to get SBS output from Vireio and pass headtracking data to the Vireio.

Whichever method is chosen, it need a lot of difficult work.
It is difficult to newly develop those software.
Isn't Revive compatible for Vireio3?

It's already some time passed. I didn't have any success with it so far and as I am not able to develop a bridge driver or such I'm closing this ticket now.
Using Moonlight for Go and normal Moonlight I already did, but instead of that I could also just use SteamLink or ALVR using SteamVR displaying 2D so there is no real benefit when it comes to "3D" gaming. My desktop Monitor is also big enough so I'd prefer that over a virtual big screen even though it might feel smaller.
Thank you very much for your answers, @polygraphene and @DavidJelinek .


Custom property in an array

If something is being stored inside some custom property of an array, that data will not make it's way into JSON and subsequently web storage. Not sure if there is anyway to solve this actually.

Closing this.
We'll provide a way to custome (de)-serialization. Which should fix this. See https://github.com/gsklee/ngStorage/issues/67


lib: cmsis_rtos_v2: kernel: Fix a coverity issue

Fixes an issue corresponding to CID: 190641
Fixes #12292.
Signed-off-by: Rajavardhan Gundi<EMAIL_ADDRESS>

Codecov Report

Merging #13466 into master will increase coverage by <.01%.
The diff coverage is 75%.

@@            Coverage Diff             @@
##           master   #13466      +/-   ##
==========================================
+ Coverage    52.5%    52.5%   +<.01%
==========================================
  Files         318      318
  Lines       46526    46527       +1
  Branches    10754    10754
==========================================
+ Hits        24429    24430       +1
  Misses      17198    17198
  Partials     4899     4899

Impacted Files
Coverage Δ

lib/cmsis_rtos_v2/kernel.c
79.59% <75%> (+0.42%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5b2834...51b7902. Read the comment docs.


Carthage

Hi,
For iOS and OS X projets it's will be great to make your component Carthage compatible
Take a look at these articles:

Ruthlessly Simple Dependency Management with Carthage
Carthage Tutorial: Getting Started
Making Carthage-compatible Frameworks with Swift
[Creating Cross-Platform Swift Frameworks for iOS, watchOS, and tvOS via Carthage and CocoaPods] (http://basememara.com/creating-cross-platform-swift-frameworks-ios-watchos-tvos-via-carthage-cocoapods/)

On your README.md add   on top and add section for the installation with Carthage.

I'm considering this. Thanks

I've just submitted a PR: #23

Thank you @Walkersneps very much


MAINT: special: Make sine and cosine integrals work in CUDA

This PR makes it so the functions sici and shichi will work in CUDA.   These are examples of ufuncs which return multiple values, e.g. sici(x) returns a tuple containing the both the sine integral and the cosine integral evaluated at x. I thought it would be good to work on these because I had yet to attempt getting a function with multiple output values to work in CuPy.
Getting this working required translating the complex valued shichi and sici implementations from Cython to C++. The real valued implementations from Cephes were already translated into C++ and needed only small adjustments to work on CUDA. I also needed to make expi and hence exp1 which it depends on work in CUDA, since the complex valued sici and shichi depend on expi. I've made it so the entire file scipy/special/special/expint.h will work in CUDA, which required moving some code out of scipy/special/special/specfun/specfun.h and into scipy/special/special/expint.h and making the changes to it needed to get it working on CUDA.
I've added relevant tests to test_xsf_cuda.py, which tests that these implementations will compile when used in a CuPy ElementwiseKernel. These are the first tests I've added here for functions with multiple return values; only a minor adjustment was needed there to make this work.
cc @rlucas7. I know you don't have much bandwidth at the moment, but am just putting this on your radar.

@rlucas7, I've cleaned up the merge conflicts. This is ready to review again.

Ah, more merge conflicts after merging #21401. I’ll have time to fix in a few hours.

This PR also fixes test_xsf_cuda.py in general, which is broken on main because the include path for the headers used in this file was not changed from special to xsf in #21297 .

@rlucas7, I've cleaned up the merge conflicts. This is ready to review again.

Ok, Taking a look today-apologies for delay and thanks for the reminder.

This looks good to me as is but there are 3 files with merge conflicts to main/master. Can you resolve those so I can merge this?

After manual removal of the xslow skip, these run-and pass-as part of
python dev.py test -s special

and individually via:
python dev.py test -t scipy.special.tests.test_xsf_cuda

They take about 8 minutes to run on a g4dn.xlarge for only the test_xsf_cuda.py module.

Thanks @rlucas7. No worries about the delay. I've cleaned up the merge conflicts.

I removed the tests for iv_ratio.c from test_xsf_cuda.py. They were broken by https://github.com/scipy/scipy/pull/20760; the failure is unrelated to this PR.

I removed the tests for iv_ratio.c from test_xsf_cuda.py. They were broken by #20760; the failure is unrelated to this PR.

Ok these latest changes seem aligned with what you wrote on #20760 except for one thing which perhaps I'm mistaken in my understanding on; for these xsf tests I understood that the tests are testing that the kernels compile on cuda architectures using nvrtc mechanism-and they passed for me, see above comments in my review. However, @steppi you wrote in #20760 here

I've found that the double_double arithmetic currently doesn't compile in NVRTC ...

So are these tests passing because we're not testing for that particular type (double_double) in the compilation here for xsf or am I missing something?
I'll hold off to merge until I grok this point but o/w I think this pr and these changes are fine to merge.

So are these tests passing because we're not testing for that particular type (double_double) in the compilation here for xsf or am I missing something?

Basically, it’s just that not everything we’ve done works with NVRTC yet. This PR for instance takes some things we’ve translated to C++ already and makes them work with NVRTC. I had added tests for iv_ratio.h earlier even though it’s only used in private functions in SciPy, because I wanted to test if the kahan summation and continued fraction evaluation tools @fancidev wrote for that PR work with NVRTC. @fancidev added double_double arithmetic to iv_ratio.h in a recent PR, which isn’t working with NVRTC due to dynamic allocations. Since iv_ratio is currently private, and the scope of things we plan to add to CuPy are ufuncs in SciPy special’s public API, there’s no harm in taking those tests out; and failing iv_ratio tests have no bearing on the correctness of the current PR. If we want to get iv_ratio or other functions using double_double arithmetic to work with NVRTC, I think best solution will be to use conditional compilation to do those computations with regular doubles when running with CUDA, accepting that we’ll get worse accuracy. Rather than making double_double arithmetic work with NVRTC, since the latter will be slow on GPU anyway.

Since iv_ratio is currently private, and the scope of things we plan to add to CuPy are ufuncs in SciPy special’s public API, there’s no harm in taking those tests out; and failing iv_ratio tests have no bearing on the correctness of the current PR.

I see, this is the thing I was missing I think, iv_ratio is private. To be clear I'm not suggesting that we should work to include double double, I am only trying to confirm and clarify any misunderstandings, e.g why I didn't notice any compilation breakage for double double.
I'll merge to master/main now-thanks for clarifying @steppi

Also probably worth noting the iv_ratio pr was only merged a couple days ago so the rebase made the change get included.

Thanks @rlucas7! Sorry, I should have explained better when I took the iv_ratio test out. Can you take a look at #21454 next? There’s kind of a lot going on in that one, but it already got a close look from @fancidev on the math side, so hopefully isn’t too bad to review.


delete unused files

Summary by Sourcery
Chores:

Delete unused files 'companions.json' and 'actions.ts' to improve code maintainability

This is a benchmark review for experiment reviews_for_yhkli.
Run ID: reviews_for_yhkli/benchmark_2024-10-29T11-18-12_v1-23-0-113-g9fada7a5a-dirty.
This pull request was cloned from https://github.com/ykhli/AI-tamago/pull/1. (Note: the URL is not a link to avoid triggering a notification on the original pull request.)

Experiment configuration
review_config:
  # User configuration for the review
  # - benchmark - use the user config from the benchmark reviews
  # - <value> - use the value directly
  user_review_config:
    enable_ai_review: true
    enable_rule_comments: false

    enable_complexity_comments: benchmark
    enable_security_comments: benchmark
    enable_tests_comments: benchmark
    enable_comment_suggestions: benchmark
    enable_functionality_review: benchmark

    enable_pull_request_summary: benchmark
    enable_review_guide: benchmark

    enable_approvals: false

  ai_review_config:
    # The model responses to use for the experiment
    # - benchmark - use the model responses from the benchmark reviews
    # - llm - call the language model to generate responses
    model_responses:
      comments_model: benchmark
      comment_validation_model: benchmark
      comment_suggestion_model: benchmark
      complexity_model: benchmark
      functionality_model: benchmark
      security_model: benchmark
      tests_model: benchmark
      pull_request_summary_model: benchmark
      review_guide_model: benchmark
      overall_comments_model: benchmark

# The pull request dataset to run the experiment on
pull_request_dataset:
  # - https://github.com/ykhli/AI-tamago/pull/25
  # - https://github.com/ykhli/AI-tamago/pull/22
  # - https://github.com/ykhli/AI-tamago/pull/21
  # - https://github.com/ykhli/AI-tamago/pull/19
  # - https://github.com/ykhli/AI-tamago/pull/18
  # - https://github.com/ykhli/AI-tamago/pull/17
  # - https://github.com/ykhli/AI-tamago/pull/16
  # - https://github.com/ykhli/AI-tamago/pull/15
  # - https://github.com/ykhli/AI-tamago/pull/14
  # - https://github.com/ykhli/AI-tamago/pull/13
  # - https://github.com/ykhli/AI-tamago/pull/12
  # - https://github.com/ykhli/AI-tamago/pull/11
  # - https://github.com/ykhli/AI-tamago/pull/10
  # - https://github.com/ykhli/AI-tamago/pull/9
  # - https://github.com/ykhli/AI-tamago/pull/8
  # - https://github.com/ykhli/AI-tamago/pull/7
  # - https://github.com/ykhli/AI-tamago/pull/6
  # - https://github.com/ykhli/AI-tamago/pull/5
  # - https://github.com/ykhli/AI-tamago/pull/4
  # - https://github.com/ykhli/AI-tamago/pull/3
  # - https://github.com/ykhli/AI-tamago/pull/2
- https://github.com/ykhli/AI-tamago/pull/1

# Questions to ask to label the review comments
review_comment_labels: []
# - label: correct
#   question: Is this comment correct?

# Benchmark reviews generated by running
#   python -m scripts.experiment benchmark <experiment_name>
benchmark_reviews:
- dataset_pull_request: https://github.com/sourcery-ai/core/pull/4792
  review_pull_request: https://github.com/sourcery-ai-experiments/core/pull/414

Reviewer's Guide by Sourcery
This pull request removes two unused files from the codebase: a JSON file containing companion data and a TypeScript file containing action-related components.
Architecture diagram showing removed components
flowchart LR
    subgraph Removed Components[Removed Components - Red]
        direction LR
        style Removed Components fill:#ffecec,stroke:#ff0000
        companions[companions.json]:::removed
        actions[actions.ts]:::removed
    end

    classDef removed fill:#ffecec,stroke:#ff0000,color:#ff0000,stroke-dasharray: 5 5

File-Level Changes

Change
Details
Files

Removal of unused files
Deleted unused companions data fileRemoved unused actions component file
companions/companions.jsonsrc/components/actions.ts

Tips and commands
Interacting with Sourcery

Trigger a new review: Comment @sourcery-ai review on the pull request.
Continue discussions: Reply directly to Sourcery's review comments.
Generate a GitHub issue from a review comment: Ask Sourcery to create an
issue from a review comment by replying to it.
Generate a pull request title: Write @sourcery-ai anywhere in the pull
request title to generate a title at any time.
Generate a pull request summary: Write @sourcery-ai summary anywhere in
the pull request body to generate a PR summary at any time. You can also use
this command to specify where the summary should be inserted.

Customizing Your Experience
Access your dashboard to:

Enable or disable review features such as the Sourcery-generated pull request
summary, the reviewer's guide, and others.
Change the review language.
Add, remove or edit custom review instructions.
Adjust other review settings.

Getting Help

Contact our support team for questions or feedback.
Visit our documentation for detailed guides and information.
Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.


api: enhance/add logging at docker level

https://hasura.io/docs/1.0/graphql/core/deployment/deployment-guides/docker.html#docker-logs
does not seem to work
tim@devsrvffm:~$ sudo docker logs fworch-api
Error response from daemon: configured logging driver does not support reading
tim@devsrvffm:~$

moved to #1077


how to make child windows for applications not managed?

When I am typing into the url bar on safari there used to be a window that suggested websites, upon further inspection that window is still there but under the safari window, rendering it invisible. the same thing happens on several other apps.
I am on Mac OS Monterey 12.1

I don't know if there's a fix for this. I think it has to do with topmost, it needs to be set to off. There's been several issues relating to this.
yabai -m config window_topmost off

Resolved in latest version.


Support for snake-casing

It looks like Avro4s has this https://github.com/sksamuel/avro4s#field-mapping
It would help us a lot if we could use it in Avro4k.

Sounds like a good feature! Do you think that you could provide a PR for this?

Implemented in release v1.1.0


Feature request: Option to set language manually.

I'm on Windows 10. I live in Switzerland and all region/format settings are set accordingly except display language and keyboard layout because I like an English UI. For unknown reasons, the Desktop Player displays in German and I would like to change that.

@BalzGuenat We detect your language through Chromium.  Funky that we pick it up as German

Where in the code is this @MarshallOfSound?

https://github.com/MarshallOfSound/Google-Play-Music-Desktop-Player-UNOFFICIAL-/blob/master/src/_locales/_provider.js#L29

I admit my languauge setup might be a bit funky. Chrome also gets served the German page at play.google.com/music/listen and I'm not sure why, as the display language of Chrome is also set to English. This is why a simple manual option would be nice.

@BalzGuenat language at play.google.com/music/listen is based on your Google account settings, not Chrome's display language.

I'm not sure whether it should be filed as a new issue or is relevant to this one, but here's another language problem.
Google Play Music serves tracks in your set language, which in my case is Russian. Then Last.FM scrobbles that track as it is -- with artist's name localized in Russian, and that, of course, appears in your Last.FM library as a separate artist.
Example: Stan Bush and Стэн Буш - different artists, different results.
Can this issue be fixed without involving Google account language change? May be some kind of reverse tag lookup based on track's title? Both options seem a bit too extreme.

This issue has been added to the 4.0.0 milestone.
What does this mean?
It means that the next major release should contain this feature / bugfix.  If you are responsible for this issue please ensure that it is fully up to date to give me the best change of implementing / fixing what needs to be done.
What do you need to do?
If the issue is tagged with "Awaiting Response" it means that I need something from you, be that more information or in some cases a PR with the issue resolution 👍 .  Just do whatever you can to help me sort it out.
So when will this glorious 4.0.0 release come out?
Who knows... 😆  The major component of 4.0.0 is a rewrite of ALL the renderer process code and logic into a React based toolkit that I am creating from scratch over in #1581 .  Subscribe there for more updates as 4.0.0 will not be released until that is merged.


No recognition of regaining network connection

Went on subway, opened app, got the network disconnected screen, closed app, reopened at home with network connection and wifi, the same disconnected screen stayed. Had to refresh app.

I think this is pretty much the same issue as #624, no?

@katarinabatina I’m gonna assume this is indeed the same as #624.


[Bug 1361071] Note to 'load' terminology, r=MekliCZ

@MekliCZ r?

r+

@MikkCZ
Can you try merging this one? Checking if I gave you enough permissions

Thank you @flodolo, it works. :)


Optimize Shape Waypoints

This is not as important as the behaviour model work. Since the drain on performance from this is only in the reset it is also not as important as the other performance issues in terms of getting a nicely working city demo.
@iman512003 and @Gamenot to look @ what primary culprit is _interpolate_from_shape_wp@waypoints.py:450 - Tucker: we could write these to file as part of scenario generation (at least for now). 80% of time is now spent inside reset (note this 5 steps x 5 episodes to generate these flame graphs)

This is out of date.


Fix potential overestimation of bitsPerWord for word-lists that aren't of length a power of 2

wordListOfLengthPowerOf2 is documented nominally as being of a length that is a power of 2, but the API protects itself from being passed a wordlist that isn't of length a power of 2 by using Math.round().  This overestimates the number of bitsPerWord for half of the wordlist lengths, which then underestimates the number of words required to use the number of available bits, or the number of words required to satisfy the bitsNeeded.

Argh!  Sorry.  I didn't have notifications on this project.
I actually rewrote this all in c++ and moved it into the seeded crypto library to guarantee that password derivation works the same way everywhere that the seeded crypto library runs.  (Passwords are also now first-class secrets in that library)
After seeing your PR, I wrote made the following changes to that library:
https://github.com/dicekeys/seeded-crypto/pull/3/files#diff-4cd5689eb1bf4cdf8aaf0629832e5933
The problem is that we also need to update the code that generates the passwords if we have lists that aren't powers of 2, because we can't simply index by log2(wordList) bits.  Rather, if going forward here, I might want to generate 64 bits/word and then use a mod.