Late initialization error for Analytics.userProperty

Recently, when we added the error handling class to log errors we encounter within the package, we failed to consider the case when an error occurs on start up. Specifically, if the ~/.dart-tool/dart-flutter-telemetry-session.json was malformed and was not valid json, we would encounter an error on start up.
And once we encounter this json parsing error, we properly handle it with our try/catch blocks in lib/src/session.dart file. While handling this error, we attempt to send an event that indicates what happened during this error. This error occurs because we have logic that has been placed in the Session class's constructor body.
We should instead move the logic that exists within the Session class's constructor body into a separate method called Session.initialize and only call that once we have ensured that all the necessary fields for Analytics have been initialized already

Invocation: 'dart tooling-daemon --machine'
Exception: 'LateInitializationError: Field 'userProperty' has not been initialized.'
Stack Trace:
#0      AnalyticsImpl.userProperty (package:unified_analytics/src/analytics.dart)
#1      AnalyticsImpl.send (package:unified_analytics/src/analytics.dart:613:21)
#2      ErrorHandler.log (package:unified_analytics/src/error_handler.dart:29:18)
#3      Session._refreshSessionData (package:unified_analytics/src/session.dart:102:21)
#4      new Session (package:unified_analytics/src/session.dart:37:27)
#5      new AnalyticsImpl (package:unified_analytics/src/analytics.dart:429:23)
#6      new Analytics (package:unified_analytics/src/analytics.dart:87:12)
#7      createUnifiedAnalytics (package:dartdev/src/unified_analytics.dart:23:10)
#8      DartdevRunner.runCommand (package:dartdev/dartdev.dart:165:27)
#9      CommandRunner.run.<anonymous closure> (package:args/command_runner.dart:122:25)
#10     new Future.sync (dart:async/future.dart:306:31)
#11     CommandRunner.run (package:args/command_runner.dart:122:14)
#12     runDartdev (package:dartdev/dartdev.dart:46:29)
#13     main (file:///Volumes/Work/s/w/ir/x/w/sdk/pkg/dartdev/bin/dartdev.dart:11:9)
#14     _delayEntrypointInvocation.<anonymous closure> (dart:isolate-patch/isolate_patch.dart:293:33)
#15     _RawReceivePort._handleMessage (dart:isolate-patch/isolate_patch.dart:184:12)
[12:28:59 PM] [DartToolingDaemon] [Info] Process /Users/ldap/Library/flutter/bin/cache/dart-sdk/bin/dart terminated! 255, null
[12:28:59 PM] [DartToolingDaemon] [Info] DTD connection closed

Fixed in

#239


Output Report Info to File

Currently
Important Analysis Results are only printed in the console
Desired
Make an output report for the beam.

Ideas:

.csv file with results and config info
quick and dirty .txt file
fancy shmancy .pdf using a save image from the 2d-3d plots

For the .docx / .pdf - type options

docx
pdfs

closed by #18


[Bug]: rspack sass-loader preload error

Version
System:
    OS: Linux 6.1 Ubuntu 20.04.6 LTS (Focal Fossa)
    CPU: (2) x64 AMD EPYC
    Memory: 2.82 GB / 4.01 GB
    Container: Yes
    Shell: 5.0.17 - /bin/bash
  npmPackages:
    @rsbuild/core: ^0.7.5 => 0.7.6
    @rsbuild/plugin-sass: ^0.7.6 => 0.7.6
    @rsbuild/plugin-vue2: ^0.7.5 => 0.7.6

Details
The pre -load of the sassfile has been loaded, but I have not introduced the sass file in other files, If I commemorate the comments introduced by the SCSS file introduced in the js file, it can run ...
error

no error

Reproduce link
https://codesandbox.io/p/github/djkloop/rs-issue-vue2-demo/main
Reproduce Steps

pnpm i  -f
pnpm dev
error

感觉像是scss文件在.js文件导入有问题。

I found that the modern Sass API no longer support this, but you can switch to the legacy Sass API to make it work:
pluginSass({
  sassLoaderOptions: {
    api: "legacy",
    additionalData: `@import '~@/style/preload.scss';`,
  },
})

Reference: https://github.com/webpack-contrib/sass-loader?tab=readme-ov-file#api


Xamarin Live Reload Support

For the "half elmish" approach of having static XAML files, but still using an elmish model, it would be very compelling to have Xamarin Live Reload support.
At the moment if I add the live reload package to this project, the ResolveAssembly task in Xamarin.Android.Common.targets fails with:
C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\MSBuild\Xamarin\Android\Xamarin.Android.Common.targets(1590,2): error : Exception while loading assemblies: System.IO.FileNotFoundException: Could not load assembly 'Xamarin.Live.Reload, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken='. Perhaps it doesn't exist in the Mono for Android profile?
File name: 'Xamarin.Live.Reload.dll'

I think I can work around this, but then I spotted some targets in the live reload package that looks like it will only work in C# & VB projects, it tries to inject some attributes into the assembly, however I don't think F# uses the same targets (yet? see here: https://github.com/Microsoft/visualfsharp/issues/3113).
I might have a dabble with this later this week to see what I can get working.

@slang25 If you can add docs for getting half-elmish to work with Live Reload that would be great
In the meantime we've added a preliminary LiveUpdate experience for Full Elmish, see https://fsprojects.github.io/Elmish.XamarinForms/tools.html

Note that Live Reload has been deprecated: https://github.com/xamarin/Xamarin.Forms/issues/4155#issuecomment-431596130

I never got around to looking at this 😞 Given it's dead, I'm closing

Note that the "Live Update" support in this repo is unrelated to "Live Reload" mentioned above :)

Yes :) now I dislike XAML even more!


combine-repos too large to "compare" on PR

@stephpenn1 OK this seems normal—GitHub has limits on the diff sizes it'll show, and those json files are larger than that.


Add aiimagegenerator.org to Stable Diffusion Deployed Web Tools category

Thanks for the awesome list! We are the makers of https://www.aiimagegenerator.org and we would love to add it to your list, under Stable Diffusion Deployed Web Tools 🙂

@sonoroboto Excellent! Thanks for the contribution!


Change protobuf readers to a single generic(-ish) reader

All graveler readers are the same, they only take a different protobuf message type.  So
create a single generic parser and reader.
Use the standard technique: pass an empty "prototype" message.  Protobufs allow for creating
sort-of message clones, bypassing the need for understanding much of how to use generics.

@johnnyaug please have a look.  I think this technique for generic protobufs allows us roughly to halve the amount of plumbing code required to support 2 message types.  (It also makes it easier to support future method types, and maybe even make some testing happier.)

Codecov Report

:exclamation: No coverage uploaded for pull request base (wip/scala_client@8cbf048). Click here to learn what that means.
The diff coverage is n/a.

@@                 Coverage Diff                 @@
##             wip/scala_client    #1449   +/-   ##
===================================================
  Coverage                    ?   40.48%
===================================================
  Files                       ?      152
  Lines                       ?    12018
  Branches                    ?        0
===================================================
  Hits                        ?     4866
  Misses                      ?     6463
  Partials                    ?      689

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8cbf048...2723d1c. Read the comment docs.

Thanks!
Protobuf lint failure is unrelated. Pulling...


Operations page responsive

Changes in this Pull Request:

New responsive operations page

Mandatory checks:

[x] Branch is up to date (latest changes were fetched from the upstream branch before creating this PR)
[x] Changes were tested manually
[ ] Java code changes are unit tested
[ ] Webtests are successful

To be checked by the reviewer:

[ ] Clean Java code and unit tested changes
[ ] UI customizablity is preserved: No hard-coded styling and URL references in JSF views

To be checked by the pull request owner:

[ ] .MASTER/job/BES_MASTER_IT/
[ ] .MASTER/job/OSCM_WS_Tests_INTERNAL/
[ ] .MASTER/job/OSCM_WS_Tests_OIDC/
[ ] .MASTER/job/OSCM_Integration_Tests_INTERNAL/
[ ] .MASTER/job/OSCM_Integration_Tests_OIDC/

Cross repository and core changes:

[ ] Interdependent changes have been communicated to the team (if applicable)
[ ] This pull request includes high risk modifications or core changes (e.g API, datamodel, authentication...). Mandatory reviewers: @goebell or @kowalczyka.

OSCM Build References:

c11

Screenshot (if applicable):

This change is

oscm-portal/WebContent/marketplace/css/mp.css, line 1707 at r1 (raw file):

  margin-top: 10px;
  min-height: 500px;
}

Please correct this.

oscm-portal/WebContent/marketplace/playground/subscriptions/subscriptionUsagePanel.xhtml, line 140 at r1 (raw file):

         var f = document.getElementById('subscriptionForm');
         f.target = subscriptionKey;
         f.action = accessUrl;

why did you change this id?

oscm-portal/WebContent/marketplace/playground/subscriptions/subscriptionUsagePanel.xhtml, line 140 at r1 (raw file):

         var f = document.getElementById('subscriptionForm');
         f.target = subscriptionKey;
         f.action = accessUrl;

why did you change this id?

Because this caused problems when creating more operations


Adding watch endpoint to the fake REST client

This PR adds a watch endpoint to the fake REST client. This sets us up to add integration tests for watching resources, to be done in a follow-up

Moving to 0.0.3 because this is still in-progress

I am moving this out of all milestones, since #693 is being worked on, and will make this obsolete

This will be closed when #782 is merged


Update wheels.yml to prevent release if failed builds.

Add check for all wheels building successfully before uploading to PyPI. Not sure if this step should happen immediately after wheel building step or where I have put it?

Linked to https://github.com/zeromq/pyzmq/issues/1978

Thanks for the PR! This is already accomplished by the needs field, I believe (the affected step didn't run until just now when all the jobs finished). The problem is linux ARM wheels are published from CircleCI.
If we added a step that pulled the wheels in from Circle so that they all uploaded at once, it would fix this.

#1982 causes all wheels to be uploaded together


lassoConfig always undefined

Cannot understand how to set a custom Lasso config.
I tried to create a ~/index.js looking like
module.exports = {
  'lassoConfig': ... // my lasso config here
}

but it doesn't get read from marko-starter.
I've also tried to set lassoConfig as key of my package.json but still the same issue.

We will be improving the documentation for this project soon, but you should just need to create a project.js in the root of your project with a structure similar to the following: https://github.com/marko-js/markojs-website/blob/master/project.js
@austinkelleher When you get a chance, do you mind adding some docs for this project? I'm not sure why the docs did not get moved over from the original repo: https://github.com/mlrawlings/marko-starter/blob/master/README.md

@patrick-steele-idem Thanks, I was about to write that I found a solution which is exactly the one you suggested.
By reading the code in marko-starter I noticed that there's a way to override the project.js.
Mine turned out to be pretty simple:
const projectDir = require('app-root-dir').get();

const project = require('marko-starter').projectConfig({
  'dir': projectDir,
  'lassoConfig': require('./config').lasso
})

module.exports = project

I'll read the marko-js/markojs-website tomorrow over the day and see how I can improve my project.js 👍

@matteozambon89 I've added a README with some documentation to this project. Hope this helps. Glad you figured out your issue.


Allow for more VPS options without diluting simplicity

This might be a good sample project to work from: https://github.com/nusenu/ansible-relayor
SIMPLICITY IS PARAMOUNT. THIS ISN'T A PROJECT INTENDED FOR THE END USER TO BE REQUIRED TO MAKE ANY CHOICES DURING SETUP.

@robbintt cool project.  regarding "more vps options", might want to consider using hashicorp's packer, an easy way to facilitate creation with various cloud apis (aws/gcp/azure), on top of digitalocean.


Fix Documentation Typos

Here's a non-exhaustive list of changes I want to make to the docs. May update later.

This section has an incorrect command. pip install hubploy doesn't work I think. It's just pip install -e ~/<absolute-path-to>/hubploy.
The Prerequisites section has some confusion wording.
The Hubploy workflow section has a typo.
The docs don't link back to the GitHub repo. They probably should.

Feel free to add suggestions below.

From https://github.com/yuvipanda/hubploy/pull/75#discussion_r462503196 , add note in docs about images: being optional.

In Hub Customizations, I should replace the pound signs with numbers / letters and remove the bold, fully-capitalized sentence at the end, since the docs are not a repo.


Ignore local imports during dependency scanning

Intent
This PR omits local module/package import from being listed as package dependencies from the scanning process.
Fixes #2096
Type of Change

[x] Bug Fix

[ ] New Feature

[ ] Breaking Change

[ ] Documentation

[ ] Refactor

[ ] Tooling

Approach
Check for the existence of a module or local directory matching the top-level import name.
Automated Tests
Updated an existing test to check for these cases.
Directions for Reviewers
Scan for Python dependencies in the posit-conf-survey project. The local imports (data, location, etc) should be excluded from the generated requirements.txt file.
Checklist

[ ] I have updated CHANGELOG.md to cover notable changes.

This would be a much bigger change, so not needed in this PR, but do you want me to make an issue for the thought of extending this slightly to add the excluded file(s) to the file includes? Some of that depends on the outcome of questions about what minimal files to send are (e.g. if we include all *.py for apps, this is less useful)


Consolidate PR workflows

To remove some duplication in GHA, we can move PR deploys (staging env) into the main workflow files.
In order to build the apps in an environment-agnostic fashion, we set app settings at deploy time via Bicep Infra as Code. This is done by using the Bicep existing keyword to pull in properties such as storage keys, creds, and fqdn's of container apps.
Conditions are used on jobs as follows:

Always build the app
If source branch is NOT main, deploy to staging
If source branch is main, deploy to prod

Coming soon: reusable workflows to remove step duplication

@bradygaster - would you be able to lend a hand in getting Blazor to load appsettings.json from the web app service? Looks like this is the issue? https://github.com/dotnet/aspnetcore/issues/25152


Display the last modified time in the output of the show data command

Add a column in the output of show data to display the last modified time of the data. The results of show data are collected asynchronously in the background. This asynchronous collection may lead to some discrepancy between the data size in show data and the actual size. Displaying the last modified time in show data can help better understand how old the statistics are.

Colud you let me try this ?

Hi @lingtaolf, I wanted to check in and see how the work is going on this issue. Don't hesitate to reach out if you need any assistance or have any questions. But no pressure - please take your time. Just keep us posted so we can support you.

@lingtaolf Are you still willing to change this issue? If you don't plan to modify it in the near future, I would like to give it a try

@lingtaolf Are you still willing to change this issue? If you don't plan to modify it in the near future, I would like to give it a try

@lingtaolf Are you still willing to change this issue? If you don't plan to modify it in the near future, I would like to give it a try

No pressure, please take your time

future

@Jin-H I'm a little busy recently, and I still work on this.  I will finish it in next week.


mp3 file loading hang on macOS and Windows

Hi,
i've found an issue related with dr_mp3 lib, right now you have in your repo the v0.4.2, mp3 file loading is working perfectly on linux but it hangs on OSX and windows.
I've solved it updating dr_mp3 to the last one, v0.4.4 - 2019-05-06
easy fix!

oook, i will update the libs and commit to fix this

closing!


Swik 958 screen only css

Brings functionality for screen reader descriptions CSS class that is only visible by the screen reader

@schatzopoulos this look fine but I can't test is properly until it is merged.
@ali1k are you ok for this to be merged?

@abijames I think you can test it by going to slidewiki-platform/custom_modules/custom-semantic-ui and then git pull and git checkout SWIK-958_ScreenOnlyCSS. This will change to the specific branch of the custom-semantic-ui repo, if I am not mistaken.

I tried that but the branch didn't show up in custom-semantic-ui submodule in my git client. will try again after the call

@schatzopoulos got this working and it working correctly so I am merging!


Feature Request: SecurityRequestError Structure Standardization

Is your feature request related to a problem? Please describe.
When you run into "error" xml returned from IRRSMO00, there are effectively two kinds of structures:
Structure 1 is the case we based SecurityResultError on, RACF returns with a non-zero RC and the following XML:
<?xml version="1.0" encoding="IBM-1047"?>
<securityresult xmlns="http://www.ibm.com/systems/zos/saf/IRRSMO00Result1">
  <user name="TESTBOY" operation="set" requestid="UserRequest">
    <info>Definition exists. Add command skipped due  to precheck option</info>
    <command>
      <safreturncode>8</safreturncode>
      <returncode>16</returncode>
      <reasoncode>8</reasoncode>
      <image>ALTUSER TESTBOY  OMVS     (UID         (STRING))</image>
      <message>IKJ56701I MISSING OMVS UID+</message>
      <message>IKJ56701I MISSING OMVS USER ID (UID), 1-10 NUMERIC DIGITS</message>
      <message>IKJ56716I EXTRANEOUS INFORMATION WAS IGNORED: STRING</message>
    </command>
  </user>
  <returncode>4</returncode>
  <reasoncode>0</reasoncode>
</securityresult>

Structure 2 is the case where IRRSMO00 itself is returning an error to the user as XML:
<?xml version="1.0" encoding="IBM-1047"?>
<securityresult xmlns="http://www.ibm.com/systems/zos/saf/IRRSMO00Result1">
  <user name="TESTBOY" operation="set" requestid="UserRequest">
    <error>
      <errorfunction>10</errorfunction>
      <errorcode>2000</errorcode>
      <errorreason>76</errorreason>
      <errormessage>Data may not be specified for a boolean field.</errormessage>
      <erroroffset>216</erroroffset>
      <textinerror>STRING</textinerror>
    </error>
  </user>
  <returncode>2000</returncode>
  <reasoncode>76</reasoncode>
</securityresult>

Because the internal XML structure is so different, the SecurityRequestError is very different. Our documented sample of:
from pyracf import UserAdmin
from pyracf import SecurityRequestError

user_admin = UserAdmin()

try:
    user_admin.alter("squidwrd", traits={"base:password": "passwordtoolong"})
except SecurityRequestError as e:
    return_code = e.result["securityResult"]["user"]["returnCode"]
    reason_code = e.result["securityResult"]["user"]["reasonCode"]
    messages = "\n".join(e.result["securityResult"]["user"]["commands"][0]["messages"])
    print(f"Return Code: {return_code}")
    print(f"Reason Code: {reason_code}")
    print(f"Messages:\n\n{messages}")

would not work because there is no commands dictionary and no 'messages', just all sorts of error tags.
Describe the solution you'd like
We should make one structure conform to the other at least when added under the SecurityRequestError object so that errors thrown either by SMO or RACF can be handled by users without having to change their exception handling logic.
Describe alternatives you've considered
We could also split these into two entirely separate error objects to be handled differently, but that could still leave users with complications.
Additional context
The SMO errors also have some nice fields like erroroffset and textinerror. It would be nice to incorporate these into the SecurityRequestError in some way so that end users could quickly access that information to correct user error.

Resolved in #57


Custom rules

Is there an way of making custom rules?

It's all in the Wiki documentation... Wiki - Regular Expression Pattern

yeah, I saw it, but regex is now enought for me, is'nt there a way to really create new ones?

Custom Regex is the only I have in place, it usually fit almost all situations. What are you trying to accomplish that you can't do with custom Regex?

Well things like check the value agaist others fields

match and different are made for that, in_list might also interest you. You can also use interpolation to dynamically build a validation. Until you provide a better example, I still don't see what's missing...

Just saw the remote rule, I think that and interpolation will cover my needs for now, but still, there could be a way to create custom rules for better code reuse and organization

I still can't picture your need, without a clear example, I just don't understand what you want... Giving code examples would help a lot.
Also remember one thing, this is community sharing. If you think you can help with better features and code then go ahead, I accept new commit. This is all done in my free time and I'm not getting paid for it either, though sometime I wish it would, since I spent a whole lot of time on this library.

@ghiscoding is it possible to use a function instead of a regex to create custom rules?
It would be very useful to validate the CPF (the brazilian social security) which is not possible to validate only with regex since it includes math operations.
Thanks!

Here's an example of a function that validates a CPF:
jQuery.validator.addMethod("cpf", function(value, element) {
   value = jQuery.trim(value);

    value = value.replace('.','');
    value = value.replace('.','');
    cpf = value.replace('-','');
    while(cpf.length < 11) cpf = "0"+ cpf;
    var expReg = /^0+$|^1+$|^2+$|^3+$|^4+$|^5+$|^6+$|^7+$|^8+$|^9+$/;
    var a = [];
    var b = new Number;
    var c = 11;
    for (i=0; i<11; i++){
        a[i] = cpf.charAt(i);
        if (i < 9) b += (a[i] * --c);
    }
    if ((x = b % 11) < 2) { a[9] = 0 } else { a[9] = 11-x }
    b = 0;
    c = 11;
    for (y=0; y<10; y++) b += (a[y] * c--);
    if ((x = b % 11) < 2) { a[10] = 0; } else { a[10] = 11-x; }

    var retorno = true;
    if ((cpf.charAt(9) != a[9]) || (cpf.charAt(10) != a[10]) || cpf.match(expReg)) retorno = false;

    return this.optional(element) || retorno;

}, "Informe um CPF válido");

@gsantiago , is your question related to the original question? I actually didn't understand the original question, but yeah it might be related. If it is then I'll reopen the ticket, if not please open another issue number and let's discuss later.
@williamoliveira, you're welcome to answer as well if you see that it does fit your original question...
Thanks

Yes, it does fit my question, the api do add new rules could be something like this:
validationService.registerRule({
      name: 'my_custom_rule',
      expression: function(scope, element){

      // do the logic and return boolean
})

But I dont know if it can be done in the architeture as it is right now

Ok I now understand that the custom rules that you wanted are actually calling a remote javascript function, that was the part that I was missing.
So I am reopening the issue, but I can't promise you that it will be done, neither when it could be done, but I will definitely look at it. Also to be clear, I am not accepting every feature request, this is still developed in my personal time, but if I do see a benefit, then yes I don't mind looking at it. Thanks for the feedback :)

@ghiscoding are you open for pull requests? Maybe I can work on that

Yes I'm open to pull request, this custom function would probably be similar to the remote implementation and for that you can look at the validation-common.js file starting at line 603. Thanks

I'm almost done with the implementation, I did some refactoring of my code prior to implement it and so it took me a bit more time than I expected. It looks like it's working as I wanted on the Directive, I also have to look at the Service and see if it works. And finally, I need to make a few Protractor tests to cover them and I should be fine. So by the end of the week, I should have it done.
The syntax will be very similar to the remote Validator (so is the implementation), so no major difference. I'm not fully decided on the Validator name yet, I was thinking to accept both of these names custom or javascript, so for example on the Directive, it would look like this:
<input type="text" class="form-control"
            name="input1"
            ng-model="vm.model.input1"
            validation="custom:vm.myCustomValidation:alt=Alternate error message|required" />

Similar to the remote as well, the custom error message can be declared with the alt: (directly in the html validation attribute) or inside the custom function. If it's declared in the custom function, then instead of returning a boolean, it would return an object as for example
return { isValid: false, message: 'custom error' };
The custom javascript function could look like this
vm.myCustomValidation1 = function() {
    var isValid = false;

    if(vm.model.input1 === "abc") {
      isValid = true;
    }

    // you can return a boolean for isValid or an objec (see the next function)
    return isValid;

    // or returned as an object if we want to include the custom error message
    // return { isValid: false, message: 'custom error' };
  }

If you have any feedback or suggestions, now is the time...

The feature was pushed in latest release v1.4.11
You can also look at Wiki - Custom Validation function, it's implemented exactly like I said in my previous comment.


Thanks for this plugin !

Thanks Volkov Team for this plugin , helped solve a Transformation issue as mentioned here
https://community.grafana.com/t/transformation-does-not-calculate-total-mean-correctly/90589/4

@samant-rags Glad it worked out!
Let us know if there is anything else.


On docker hub, we do not have any tag for specific versions

Can someone build on dockerhub based on the tags? Or are we waiting for v1?

done

Awesome! Waiting for a new tag!


Update ansible roles to improve reliability.

Includes a default profile in the Janus controller.

@disprosium8
Please merge.


Remove new/changed in 1.1 callouts from prominent places

Fixes #2735
@bdarnell, please let me know if you disagree with any of the removals. There might be more that I left that you might've removed, too...

This change is

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/dd894e641c807abbb0e8a23f54c9d6d0913b4a6d/

Review status: 0 of 16 files reviewed at latest revision, all discussions resolved, all commit checks successful.

Comments from Reviewable


package.json missing "engine" property

Could you please specify a engine constraint in your package.json

http://blog.nodejitsu.com/package-dependencies-done-right/

Example:
   "engine": "node >= 0.4.1"

OK I will definitely do that for the next release, which I hope to get working on in the next few days. I will go over all the pending pull requests and issues.
I'm relatively new to Javascript and this is my first major open source project, so thanks for all your help!

Thanks Colin ... This will really help me to know what node engines to do testing with and for new projects based on this lib .. What engine should select for my projects.

Oh yeah ... If possible (and your dependencies support it!) would be great to use the Node 4.2.x or 4.3.x as they are LTS (long term support).
https://nodejs.org/en/blog/release/v4.3.0/

Yes, I do my personal testing on 4.x. I believe it will also run on 5.x
without a problem. I will add 4.x to package.json next release.
On Mar 14, 2016 7:30 AM, "Tony OHagan"<EMAIL_ADDRESS>wrote:

Oh yeah ... If possible (and your dependencies support it!) would be great
to use the Node 4.2.x or 4.3.x as they are LTS (long term support).
https://nodejs.org/en/blog/release/v4.3.0/
—
Reply to this email directly or view it on GitHub
https://github.com/colinskow/superlogin/issues/39#issuecomment-196334364
.

Official NPM documentation specifies "engines" as the correct field.
I am going to add this:
"engines" : {
    "node" : ">=4.0.0"
  }

It should work on both LTS and latest version, and be tested against both.


fix: allow users with profile to access profile creation

:tada: This PR is included in version 1.17.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


[BUG] Do not terminate nfs-ganesha in share-manager pod after failing to access recovery backend

Is your improvement request related to a feature? Please describe (👍 if you like this request)

Avoid terminating the nfs-ganesha when it fails to access the recovery backend.
Terminating nfs-ganesha can result in NFS clients becoming stuck.
Steps to reproduce

Create a 3-node Longhorn v1.5.3 cluster

Create a deployment with a RWX volume
apiVersion: v1
kind: PersistentVolumeClaim
metadata:
  name: rwx-vol-pvc
spec:
  accessModes:
    - ReadWriteMany
  storageClassName: "longhorn"
  resources:
    requests:
      storage: 10Gi
---
apiVersion: apps/v1
kind: Deployment
metadata:
  name: test-workload
spec:
  replicas: 2
  selector:
    matchLabels:
      app: test-workload
  template:
    metadata:
      labels:
        app: test-workload
    spec:
      containers:
      - name: test-workload
        image: ubuntu:20.04
        command: ["/bin/sh", "-c"]
        args:
          - |
            while true; do
              dd if=/dev/urandom of=/data/file bs=4K count=400000
              rm -f /data/file
            done
        imagePullPolicy: IfNotPresent
        volumeMounts:
        - name: rwx-vol
          mountPath: /data
      volumes:
      - name: rwx-vol
        persistentVolumeClaim:
          claimName: rwx-vol-pvc

Upgrade Longhorn by the customized longhorn-manager image derekbit/longhorn-manager:v1.5.3-no-rb. The recovery backend service is removed, so the existing and running share-manager cannot talk to the recovery backend in the new longhorn-manager pod.

Update the replicas of the deployment test-workload to 3 by  kubectl edit deployment test-workload

Because the share-manager pod cannot talk to the recovery backend, the share-manager pod will error out. The NFS clients become frozen.

Describe the solution you'd like

Describe alternatives you've considered

Additional context

Verified pass on longhorn master (longhorn-share-manager ad7420) with test steps
Test with custom image chanow/longhorn-manager:no-rb, the share-manager pod did not terminated.
> k -n longhorn-system logs share-manager-pvc-ebb7bb4a-90e4-4b4b-834a-9016a580d97b | grep recovery
29/05/2024 03:12:26 : epoch 66569d1a : share-manager-pvc-ebb7bb4a-90e4-4b4b-834a-9016a580d97b : nfs-ganesha-29[main] nfs4_recovery_init :CLIENT ID :INFO :Recovery Backend Init for longhorn
29/05/2024 03:12:26 : epoch 66569d1a : share-manager-pvc-ebb7bb4a-90e4-4b4b-834a-9016a580d97b : nfs-ganesha-29[main] longhorn_recov_init :CLIENT ID :EVENT :Initialize recovery backend 'share-manager-pvc-ebb7bb4a-90e4-4b4b-834a-9016a580d97b'
29/05/2024 03:12:26 : epoch 66569d1a : share-manager-pvc-ebb7bb4a-90e4-4b4b-834a-9016a580d97b : nfs-ganesha-29[main] longhorn_read_recov_clids :CLIENT ID :EVENT :Read clients from recovery backend share-manager-pvc-ebb7bb4a-90e4-4b4b-834a-9016a580d97b
29/05/2024 03:12:26 : epoch 66569d1a : share-manager-pvc-ebb7bb4a-90e4-4b4b-834a-9016a580d97b : nfs-ganesha-29[main] read_clids :CLIENT ID :EVENT :response={"actions":{},"clients":[],"hostname":"share-manager-pvc-ebb7bb4a-90e4-4b4b-834a-9016a580d97b","id":"share-manager-pvc-ebb7bb4a-90e4-4b4b-834a-9016a580d97b","links":{"self":"http://longhorn-recovery-backend:9503/v1/recoverybackendstatuses/share-manager-pvc-ebb7bb4a-90e4-4b4b-834a-9016a580d97b"},"type":"recoveryBackendStatus"}
29/05/2024 03:12:26 : epoch 66569d1a : share-manager-pvc-ebb7bb4a-90e4-4b4b-834a-9016a580d97b : nfs-ganesha-29[main] longhorn_recov_end_grace :CLIENT ID :EVENT :End grace for recovery backend 'share-manager-pvc-ebb7bb4a-90e4-4b4b-834a-9016a580d97b' version 5MIJQQKC
29/05/2024 03:12:31 : epoch 66569d1a : share-manager-pvc-ebb7bb4a-90e4-4b4b-834a-9016a580d97b : nfs-ganesha-29[svc_5] longhorn_add_clid :CLIENT ID :EVENT :Add client '30:Linux NFSv4.1 ip-172-31-32-234' to recovery backend share-manager-pvc-ebb7bb4a-90e4-4b4b-834a-9016a580d97b
29/05/2024 03:12:31 : epoch 66569d1a : share-manager-pvc-ebb7bb4a-90e4-4b4b-834a-9016a580d97b : nfs-ganesha-29[svc_8] longhorn_add_clid :CLIENT ID :EVENT :Add client '30:Linux NFSv4.1 ip-172-31-46-109' to recovery backend share-manager-pvc-ebb7bb4a-90e4-4b4b-834a-9016a580d97b
29/05/2024 03:37:39 : epoch 66569d1a : share-manager-pvc-ebb7bb4a-90e4-4b4b-834a-9016a580d97b : nfs-ganesha-29[svc_1012] longhorn_add_clid :CLIENT ID :EVENT :Add client '30:Linux NFSv4.1 ip-172-31-32-236' to recovery backend share-manager-pvc-ebb7bb4a-90e4-4b4b-834a-9016a580d97b
29/05/2024 03:37:39 : epoch 66569d1a : share-manager-pvc-ebb7bb4a-90e4-4b4b-834a-9016a580d97b : nfs-ganesha-29[svc_1012] longhorn_add_clid :CLIENT ID :EVENT :Failed to create client in recovery backend. HTTP call error: res=-1 ((null))


Fixed address encoding bug

Fixed issue where address bit 0x4 was ignored.

Is there a POCSAG implementation that uses a 4-bit time-division of the pager population?
Per section 1.2 of https://www.itu.int/dms_pubrec/itu-r/rec/m/R-REC-M.584-2-199711-I!!PDF-E.pdf which I followed while writing this:

The frames are numbered 0 to 7 and the pager population is divided into 8 groups. Thus each pager is allocated to one of the 8 frames according to the 3 least significant bits (LSB) of its 21 bit identity (see § 1.3.2), i.e. 000 = frame 0, 111 = frame 7, and only examines address codewords in that frame.

This is where the & 0x3 comes from here, the upper 3 bits of the address indicate which timeslot the message will be transmitted in.
This document is from 1997, so I could conceive that this was extended to 4 bits later. But if possible, I'd like a source I can cite in the comments if that's the case.

oh wait im so bad at hex

sorry i got confused by address bit 0x4 because i read it as "the 4th address bit" instead of "3rd address bit, value 0x4". yeah. hahahahaha


Documentation Typo

At the Isaac ROS Documentation the input_width is used twice.

ROS Parameter
Type
Default
Description

input_image_width
uint16_t
0
The input image width.

input_image_width
uint16_t
0
The input image height.

I assume this is meant to be input_image_width and input_image_height

Thanks for bringing it up. Yes, it is supposed to be input_width and input_height.


[v2] line comments are incorrectly handled

Version
2.0.1
Steps to reproduce
styled.div`
   background-color: blue;
   // this comment will kill the next rule
   .foo { color: red; }
`

Expected Behavior
Only the comment is removed
Actual Behavior
The resulting CSS given to stylis is everything on one line, which breaks the CSS obviously.
Furthermore, in generateAndInjectStyles, there is a comment removal step, but it doesn't work because the rules were already de-newlined before that, and besides stylis already does it.

Upon closer inspection, the babel plugin could be the reason the css has newlines removed.

the babel plugin could be the reason the css has newlines removed.

That is the case! /cc @vdanchenkov can we do something about this?

Issue is at https://github.com/styled-components/babel-plugin-styled-components/issues/29


Fix BC break introduced in BAP-18638

Due to default true e.g. image filters don´t work anymore until migration to add this option is run, which represents a BC break. Even Orocommerce core had to implement such migration, which is not acceptable for PATCH release under Sematic versioning scheme https://github.com/oroinc/orocommerce/commit/4c98d4e78d33413db4e5c9e432223a9134353549#diff-d2c55e6814f8d028e983c63285cc62a7
Attachments without option acl_protected set should default to the same value as previously - to not protected (false).

Closed, because BC break was added intentionally as a part of the security fix.


[Snyk] Upgrade: @fortawesome/fontawesome-svg-core, @fortawesome/free-regular-svg-icons, @fortawesome/free-solid-svg-icons

This PR was automatically created by Snyk using the credentials of a real user.Snyk has created this PR to upgrade multiple dependencies.
👯♂ The following dependencies are linked and will therefore be updated together.

:information_source: Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.

Name
Versions
Released on

@fortawesome/fontawesome-svg-corefrom 6.4.2 to 6.5.1
2 versions ahead of your current version
a month agoon 2023-11-30

@fortawesome/free-regular-svg-iconsfrom 6.4.2 to 6.5.1
2 versions ahead of your current version
a month agoon 2023-11-30

@fortawesome/free-solid-svg-iconsfrom 6.4.2 to 6.5.1
2 versions ahead of your current version
a month agoon 2023-11-30

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.
For more information:
🧐 View latest project report
🛠 Adjust upgrade PR settings
🔕 Ignore this dependency or unsubscribe from future upgrade PRs

Upgraded in previous PR


Remove duplicate tags if sent by the client

[x] read the CONTRIBUTING guidelines
[ ] raised a GitHub issue or discussed it on the projects chat beforehand
[x] added unit tests
[ ] added integration tests
[ ] updated documentation if needed
[ ] updated CHANGELOG.md

As mentionned on discord by @linksysrouter, there was a possibility to add multiple times the same tags. This PR should remove this.

Strange error with the proto, since I did not change anything related to this.


limactl start  can not work when reboot system

I  create a instance named default via limactl start default, and  I reboot my computer ,  at this time I try to run this instance by limactl start, at the end of the command execution, I find that the status of  instance  that is named default   is stopped

Is the qemu process actually running?
Is there some interesting output in the logs?
https://github.com/lima-vm/lima/tree/v0.6.3#hints-for-debugging-other-problems

stdout.log

I got this message 「Please use server=on instead」in stderr.log

I got this message 「Please use server=on instead」in stderr.log

That is just a warning; it is benign and can be ignored.
Please attach ha.stderr.log; the stdout log has nothing of interest.

Please attach ha.stderr.log; the stdout log has nothing of interest.

Oops, I see the screenshot is the ha.stderr.log. Please attach as text file instead in the future.
Unfortunately there is nothing helpful in that screenshot either. Can we get a copy of serial.log?

Please attach ha.stderr.log; the stdout log has nothing of interest.

Oops, I see the screenshot is the ha.stderr.log. Please attach as text file instead in the future.
Unfortunately there is nothing helpful in that screenshot either. Can we get a copy of serial.log?

this is ha.stderr.log ha.stderr.log, I found that the serial.log is empty

Hmm, I'm at a bit of a loss what could be causing this; it sounds like qemu is not starting up at all.
Can you run the qemu command from your logfile manually in a shell and see if it produces further output:
/usr/local/bin/qemu-system-x86_64 -cpu Haswell-v4 -machine q35,accel=hvf -smp 4,sockets=1,cores=4,threads=1 -m 4096 -drive if=pflash,format=raw,readonly,file=/usr/local/share/qemu/edk2-x86_64-code.fd -boot order=c,splash-time=0,menu=on -drive file=/Users/xslin/.lima/default/diffdisk,if=virtio -cdrom /Users/xslin/.lima/default/cidata.iso -netdev user,id=net0,net=<IP_ADDRESS>/24,dhcpstart=<IP_ADDRESS>,hostfwd=tcp:<IP_ADDRESS>:60022-:22 -device virtio-net-pci,netdev=net0,mac=52:55:55:5b:3e:e6 -device virtio-rng-pci -display none -device virtio-vga -device virtio-keyboard-pci -device virtio-mouse-pci -parallel none -chardev socket,id=char-serial,path=/Users/xslin/.lima/default/serial.sock,server,nowait,logfile=/Users/xslin/.lima/default/serial.log -serial chardev:char-serial -chardev socket,id=char-qmp,path=/Users/xslin/.lima/default/qmp.sock,server,nowait -qmp chardev:char-qmp -name lima-default -pidfile /Users/xslin/.lima/default/qemu.pid

/usr/local/bin/qemu-system-x86_64 -cpu Haswell-v4 -machine q35,accel=hvf -smp 4,sockets=1,cores=4,threads=1 -m 4096 -drive if=pflash,format=raw,readonly,file=/usr/local/share/qemu/edk2-x86_64-code.fd -boot order=c,splash-time=0,menu=on -drive file=/Users/xslin/.lima/default/diffdisk,if=virtio -cdrom /Users/xslin/.lima/default/cidata.iso -netdev user,id=net0,net=<IP_ADDRESS>/24,dhcpstart=<IP_ADDRESS>,hostfwd=tcp:<IP_ADDRESS>:60022-:22 -device virtio-net-pci,netdev=net0,mac=52:55:55:5b:3e:e6 -device virtio-rng-pci -display none -device virtio-vga -device virtio-keyboard-pci -device virtio-mouse-pci -parallel none -chardev socket,id=char-serial,path=/Users/xslin/.lima/default/serial.sock,server,nowait,logfile=/Users/xslin/.lima/default/serial.log -serial chardev:char-serial -chardev socket,id=char-qmp,path=/Users/xslin/.lima/default/qmp.sock,server,nowait -qmp chardev:char-qmp -name lima-default -pidfile /Users/xslin/.lima/default/qemu.pid

I run command in shell and  get the output as follows

Please cut&past text instead of using screenshots; they make it impossible to quote specific parts of it!
The issue seems to be that qemu cannot assign the SSH port 60022. Maybe you still have a previous instance running on it? Please check ps -ef | grep qemu and kill any still running processes (that are related to lima).
If this port is used by a different application, please edit the lima.yaml file before you start the instance, to use a different port.

Please cut&paste text instead of using screenshots; they make it impossible to quote specific parts of it!
The issue seems to be that qemu cannot assign the SSH port 60022. Maybe you still have a previous instance running on it? Please check ps -ef | grep qemu and kill any still running processes (that are related to lima).
If this port is used by a different application, please edit the lima.yaml file before you start the instance, to use a different port.

I kill process and run it again
qemu-system-x86_64: -drive if=pflash,format=raw,readonly,file=/usr/local/share/qemu/edk2-x86_64-code.fd: warning: short-form boolean option 'readonly' deprecated
Please use readonly=on instead
qemu-system-x86_64: -chardev socket,id=char-serial,path=/Users/xslin/.lima/default/serial.sock,server,nowait,logfile=/Users/xslin/.lima/default/serial.log: warning: short-form boolean option 'server' deprecated
Please use server=on instead
qemu-system-x86_64: -chardev socket,id=char-serial,path=/Users/xslin/.lima/default/serial.sock,server,nowait,logfile=/Users/xslin/.lima/default/serial.log: warning: short-form boolean option 'nowait' deprecated
Please use wait=off instead
qemu-system-x86_64: -chardev socket,id=char-qmp,path=/Users/xslin/.lima/default/qmp.sock,server,nowait: warning: short-form boolean option 'server' deprecated
Please use server=on instead
qemu-system-x86_64: -chardev socket,id=char-qmp,path=/Users/xslin/.lima/default/qmp.sock,server,nowait: warning: short-form boolean option 'nowait' deprecated
Please use wait=off instead
qemu-system-x86_64: warning: host doesn't support requested feature: CPUID.01H:ECX.x2apic [bit 21]
qemu-system-x86_64: warning: host doesn't support requested feature: CPUID.01H:ECX.tsc-deadline [bit 24]
qemu-system-x86_64: warning: host doesn't support requested feature: CPUID.07H:EBX.invpcid [bit 10]
qemu-system-x86_64: warning: host doesn't support requested feature: CPUID.07H:EDX.spec-ctrl [bit 26]
qemu-system-x86_64: warning: host doesn't support requested feature: CPUID.80000001H:EDX.rdtscp [bit 27]
qemu-system-x86_64: warning: host doesn't support requested feature: CPUID.01H:ECX.x2apic [bit 21]
qemu-system-x86_64: warning: host doesn't support requested feature: CPUID.01H:ECX.tsc-deadline [bit 24]
qemu-system-x86_64: warning: host doesn't support requested feature: CPUID.07H:EBX.invpcid [bit 10]
qemu-system-x86_64: warning: host doesn't support requested feature: CPUID.07H:EDX.spec-ctrl [bit 26]
qemu-system-x86_64: warning: host doesn't support requested feature: CPUID.80000001H:EDX.rdtscp [bit 27]
qemu-system-x86_64: warning: host doesn't support requested feature: CPUID.01H:ECX.x2apic [bit 21]
qemu-system-x86_64: warning: host doesn't support requested feature: CPUID.01H:ECX.tsc-deadline [bit 24]
qemu-system-x86_64: warning: host doesn't support requested feature: CPUID.07H:EBX.invpcid [bit 10]
qemu-system-x86_64: warning: host doesn't support requested feature: CPUID.07H:EDX.spec-ctrl [bit 26]
qemu-system-x86_64: warning: host doesn't support requested feature: CPUID.80000001H:EDX.rdtscp [bit 27]
qemu-system-x86_64: warning: host doesn't support requested feature: CPUID.01H:ECX.x2apic [bit 21]
qemu-system-x86_64: warning: host doesn't support requested feature: CPUID.01H:ECX.tsc-deadline [bit 24]
qemu-system-x86_64: warning: host doesn't support requested feature: CPUID.07H:EBX.invpcid [bit 10]
qemu-system-x86_64: warning: host doesn't support requested feature: CPUID.07H:EDX.spec-ctrl [bit 26]
qemu-system-x86_64: warning: host doesn't support requested feature: CPUID.80000001H:EDX.rdtscp [bit 27]

So after you kill the process again (I think you can just ⌃C the process in the shell), try running limactl start ... again and see if it now works. If it still doesn't work, please attach the log files again.

So after you kill the process again (I think you can just ⌃C the process in the shell), try running limactl start ... again and see if it now works. If it still doesn't work, please attach the log files again.

I kill the process and run limactl start again , It looks ok, then I run limactl ls, the status of instance is stopeed, at the same time, I run ps -ef | grep qemu and find that qemu is not running.  ha.stderr.log
limactl start log
INFO[0000] Using the existing instance "default"
INFO[0000] Downloading "https://github.com/containerd/nerdctl/releases/download/v0.11.1/nerdctl-full-0.11.1-linux-amd64.tar.gz" (sha256:ce7a6e119b03c3fb8ded3d46d929962fd17417bea1d5bbc07e0fce49494d8a09)
INFO[0000] Using cache "/Users/xslin/Library/Caches/lima/download/by-url-sha256/3304d173f1e1824e5be6cf84bf2f78825cf0db416c4c975dbb2458776942629e/data"
INFO[0001] [hostagent] Starting QEMU (hint: to watch the boot progress, see "/Users/xslin/.lima/default/serial.log")
INFO[0001] SSH Local Port: 60022
INFO[0001] [hostagent] Waiting for the essential requirement 1 of 4: "ssh"
INFO[0072] [hostagent] Waiting for the essential requirement 1 of 4: "ssh"
INFO[0085] [hostagent] The essential requirement 1 of 4 is satisfied
INFO[0085] [hostagent] Waiting for the essential requirement 2 of 4: "sshfs binary to be installed"
INFO[0085] [hostagent] The essential requirement 2 of 4 is satisfied
INFO[0085] [hostagent] Waiting for the essential requirement 3 of 4: "/etc/fuse.conf to contain \"user_allow_other\""
INFO[0086] [hostagent] The essential requirement 3 of 4 is satisfied
INFO[0086] [hostagent] Waiting for the essential requirement 4 of 4: "the guest agent to be running"
INFO[0086] [hostagent] The essential requirement 4 of 4 is satisfied
INFO[0086] [hostagent] Mounting "/Users/xslin"
INFO[0088] [hostagent] Mounting "/tmp/lima"
INFO[0089] [hostagent] Waiting for the optional requirement 1 of 2: "systemd must be available"
INFO[0089] [hostagent] Forwarding "/run/user/501/lima-guestagent.sock" (guest) to "/Users/xslin/.lima/default/ga.sock" (host)
INFO[0089] [hostagent] The optional requirement 1 of 2 is satisfied
INFO[0089] [hostagent] Not forwarding TCP <IP_ADDRESS>:53
INFO[0089] [hostagent] Waiting for the optional requirement 2 of 2: "containerd binaries to be installed"
INFO[0089] [hostagent] Not forwarding TCP <IP_ADDRESS>:22
INFO[0089] [hostagent] Not forwarding TCP [::]:22
INFO[0089] [hostagent] The optional requirement 2 of 2 is satisfied
INFO[0089] READY. Run `lima` to open the shell.

This is really confusing. Did you try lima to see if you can connect now.
I don't understand how limactl ls says "Stopped" when the qemu process is still running; it should only set that status when both qemu and the hostagent are stopped.
Can you run these 2 commands please:
$ pgrep -l -F ~/.lima/default/ha.pid
44722 limactl
$ pgrep -l -F ~/.lima/default/qemu.pid
44727 qemu-system-x86

after I run limactl start, I can not find ha.pid and qemu.pid in ~/.lima/default,  but when I run limactl start(command not done yet), I get message as follows
$ pgrep -l -F ~/.lima/default/ha.pid
25074 limactl
$ pgrep -l -F ~/.lima/default/qemu.pid
25078 qemu-system-x86

This is really confusing. Did you try lima to see if you can connect now.
I don't understand how limactl ls says "Stopped" when the qemu process is still running; it should only set that status when both qemu and the hostagent are stopped.
Can you run these 2 commands please:
$ pgrep -l -F ~/.lima/default/ha.pid
44722 limactl
$ pgrep -l -F ~/.lima/default/qemu.pid
44727 qemu-system-x86

after I run limactl start, I can not find ha.pid and qemu.pid in ~/.lima/default,  but when I run limactl start(command not done yet), I get message as follows
$ pgrep -l -F ~/.lima/default/ha.pid
25074 limactl
$ pgrep -l -F ~/.lima/default/qemu.pid
25078 qemu-system-x86

I'm out of ideas right now; let's see if anybody else can help!

I'm out of ideas right now; let's see if anybody else can help!

Thank you for answering my question. @jandubois


Thread Level Usage Accounting and Query Killing on Server

Design reviewed previously with OSS in issue -- https://github.com/apache/pinot/issues/9055
https://docs.google.com/document/d/1Z9DYAfKznHQI9Wn8BjTWZYTcNRVGiPP0B8aEP3w_1jQ/edit?usp=sharing
Working on adding more integration test

Codecov Report

Merging #9727 (8d62d53) into master (229c55e) will decrease coverage by 37.73%.
The diff coverage is 5.69%.

@@              Coverage Diff              @@
##             master    #9727       +/-   ##
=============================================
- Coverage     63.02%   25.28%   -37.74%
+ Complexity     5229       44     -5185
=============================================
  Files          1938     1942        +4
  Lines        104130   104606      +476
  Branches      15780    15854       +74
=============================================
- Hits          65625    26452    -39173
- Misses        33640    75451    +41811
+ Partials       4865     2703     -2162

Flag
Coverage Δ

integration1
25.28% <5.69%> (-0.10%)
:arrow_down:

integration2
?

unittests1
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...accounting/CPUMemThreadLevelAccountingObjects.java
0.00% <0.00%> (ø)

...counting/HeapUsagePublishingAccountantFactory.java
0.00% <0.00%> (ø)

...re/accounting/PerQueryCPUMemAccountantFactory.java
0.00% <0.00%> (ø)

...unting/utils/RunnerWorkerThreadOffsetProvider.java
0.00% <0.00%> (ø)

...a/org/apache/pinot/core/operator/BaseOperator.java
80.00% <0.00%> (-20.00%)
:arrow_down:

...a/org/apache/pinot/core/plan/DocIdSetPlanNode.java
80.00% <ø> (ø)

...core/query/executor/ServerQueryExecutorV1Impl.java
76.02% <0.00%> (-6.95%)
:arrow_down:

...e/pinot/core/transport/InstanceRequestHandler.java
39.84% <ø> (-24.22%)
:arrow_down:

...ot/query/runtime/executor/WorkerQueryExecutor.java
0.00% <0.00%> (-100.00%)
:arrow_down:

.../java/org/apache/pinot/server/conf/ServerConf.java
79.31% <ø> (-3.45%)
:arrow_down:

... and 1223 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Adjust wording to reflect current state of AWS IAM web GUI

The Permissions policy section has a button called Add permissions which then displays the option to Attach policies in the associated drop-down menu.

Ready to merge. Thanks, @qasimwarraich!


Add a Summary at the Top of Every Value Message

Description
Add a summary at the top of every value message, to make the explorer more accessible for the average user.
Motivation
The explorer is not very user-friendly, especially for simple value transfers. The average user is confronted with many technical terms and information, that they might not understand.
Requirements
At the very top of the message page, add a distinct box with a short summary of the most important information about the message, such as:

Sent from (address) (possibly colored red)
Sent to (address) (possibly colored green)
Amount transferred
Status (colored appropriately)

Are you planning to do it yourself in a pull request?
No.

Simplified view is now implemented by default.


[UI][Connection Wizard] Adapter card coincides with wrong adapter chip

Current Behavior
In the meshery adapters menu, the adapter on the cards coincide with wrong adapter chips.
Desired Behavior
The scroll should be set in such a way that the adapter on the card and chip are the same.
Screenshots/Logs
https://user-images.githubusercontent.com/53532328/129942798-4612954d-842a-49f1-b48e-10034ff0821c.mov
Environment

Browser: Chrome, Safari
Host OS: Mac
Meshery Server Version: stable
Meshery Client Version: stable
Platform: Docker desktop

Contributor Guides and Resources

🎨 Wireframes and designs for Meshery UI in Figma
🖥 Contributing to Meshery UI
🙋🏾🙋🏼 Questions: Layer5 Discussion Forum and Layer5 Community Slack

@sayantan1413 , any updates ?

This issue has been fixed.


Add pre-commit utilities

This PR adds pre-commit utilities such as auto-formatting, spelling check.
Try running poetry run pre-commit run  --all-files

Merging now.


Encrypt vector embeddings

In my reading of the source code, it looks like vector embeddings are not currently encrypted. This is potentially problematic, since they are (somewhat) reversible.
Would you be open to a pull request to encrypt content using the input, so it's only retrievable when you have access to the original source text?

Hi @morgante! Thanks for the report. Yes, definitely open to a PR. I'm not totally clear on where you'd want them to be encrypted that they are not (e.g. the results cache should cache the ouput), but a PR would help clarify!

Great. Specifically, I don't want the embedding to be retrievable unless you have the original input chunk. I'll put together a PR.

Ok got it! I believe that to currently be the case, but I am likely missing something you're observing. Looking forward to the PR.


No documentation for any plugin

Bro I'm trying use your lighting plugin but I don't know how to do it, I look at your post on Forum, your website and this repo and I can't find nothing to explain how to use it.

On the EventLight addon, I put all the script calls and notetags you can use and what they do. All other plugins of the lighting system are plug and play: You don't need to do anything other than activate the plugins.

I just added the orangeLighting and set lightMask to 1 and opacityVariable to 20.
What I'm trying is, turn on the light system with lightMask param to 1 and set the dark layer opacity to 20 in the scale 0~255 since 0 is the full dark and 255 no dark, so the 20 will be a gentle dark.
The result that I had is nothing, I'm sure I'm not undertanding the logic of the plugin so if you can explain me better I will apreciate.

If you leave the lightMaskSwitch param as 0, it will always be active. When you set it to 1, it will be active when switch 1 is turned on.
Setting opacityVariable to 20 will make the plugin use the value of variable 20 instead of the fixed value 20.

Got it... bro your plugin is awesome

by the way... flickle did you mean fickle?


Support tile definition by service tag

Inventory elements with the tag "MSAM-Tile=" will be used to define that tile's inventory. That tag can occur multiple time per element so the element will appear on multiple tiles.

Add a tag called "MSAM-Tile: " to any cloud item to create a tile (if needed) and add that item to the tile. Removing the tag will not remove the item from the tile. This operation is additive only. Cached inventory is scanned every 5 minutes for these tags.


Disable cortex m4 core force-boot on STM32H7

As described in this issue Zephyr currently does not respect the BCM4 option byte on STM32H7 microcontrollers.
This option byte should disable the boot of the m4 core but the Zephyr kernel on the m7 core force-boots the m4 core. The changes of this merge request disable this force-boot.

grep -R stm32h7_m4_wakeup ~/zephyrproject/zephyr proved that the removed function is not needed by other parts of the code.
It was in addition tested with basic blinky aswell as a proprietary firmware which needs the BCM4 option byte. Both times it was tested successfully with BCM4=0 and BCM4=1.

Thank you for the quick reply.
About the use case: We need to make sure that the m4 is not booting a firmware image which is partially swapped by the MCUboot instance on the m7. Our solution was to simply disable the m4 boot and later start it from the m7 application with LL_RCC_ForceCM4Boot();.
About the changes: My first idea was to remove just the else clause with LL_RCC_ForceCM4Boot(); which works too. But since the name stm32h7_m4_wakeup implies that it is just needed for waking up the m4 from this m7 init code and it proofed to work I thought it would be cleaner to remove it completely.
The general idea of this merge request is that there is no (to me) known use case where the m4 is unintentionally not started by system reset. Thus a start by the m7 kernel code should not be necessary.

Thanks for these details. I better get your needs.
No that has to be done is to find a middle ground between your needs and existing code (which is working well so far for other use cases).
I suggest trying to add it as a new Kconfig option.

Of course, I can create and force-push a draft for it.
So the idea is to replace CONFIG_STM32H7_DUAL_CORE by that new Kconfig option at the parts of the code i changed already?
Would you be ok with the name CONFIG_STM32H7_WAKE_M4 and a default to no?

So the idea is to replace CONFIG_STM32H7_DUAL_CORE

Whatever change you propose, please take into account that your need is a new feature and should be backward compatible for others that don't face the same need and should not have impact on their side.
So typically I rather think of a new option that would change behavior only if enabled and have no impact otherwise.

I rewrote the commit history of this merge request. The new single commit adds the CONFIG_STM32H7_WAKE_M4 Kconfig option which will override BCM4 and is enabled by default for backwards compatibility.
The commit was tested on stm32h747i_disco with the sample/basic/blinky software and works as expected:

BCM4
CONFIG_STM32H7_WAKE_M4
does M4 blink?

0
n
no

0
y
yes

1
n
yes

1
y
yes

I had to change the commit a bit due to CI errors (another board failed). Now the changes are as minimal as possible and I repeated the testing as described in the table above successfully.


[build-script] Avoid stripping clang builtin .a libraries when extracting dSYMs on Darwin

Clang builtins (.a libraries inside lib/swift/clang/lib/darwin) are sometimes problematic to strip (because stripping .a/.o files involves calling the linker) and it's somewhat wrong to strip them in the first place (because they get consumed into linked products which might want to still extract dSYMs but if the .a is already stripped, then debug info for the .a content is already lost). Let's avoid stripping Clang builtins.
rdar://123844745

@swift-ci please test

@swift-ci please test


[WIP] PR: Variable explorer issues

Description of Changes
Fixes variable explorer issues

Issue(s) Resolved

Fixes https://github.com/spyder-ide/ux-improvements/issues/17
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct:
@jsbautista

Preview:

Preview:


Feat/crypts

Minimum Playable Adventurer game using Loot Items and Nile CLI

Looks good. First PR with further code done in feat/crypts-metadata, will provide more details on CLI functions and status.


672 && 1895

-- https://github.com/qaprosoft/zafira/issues/1895
// these widgets have been changed :

TESTS EXECUTION ROI (MAN-HOURS)
TEST CASE STABILITY TREND
PASS RATE (%)
PASS RATE
TEST CASE DURATION TREND
TEST CASE STABILITY
MILESTONE DETAILS
the other 2 already had a fix in their config

-- https://solvd.atlassian.net/projects/ZEB/issues/ZEB-672?filter=myopenissues&orderby=priority DESC

task should be reorganized using another approach. closing this PR


GetNumCores not working at Win32

https://github.com/GetAywa/AywaCore/blob/f5bf12fdf51e456d96db72c23100662b85fc54a9/src/util.cpp#L981-L988
Propose to use this algo:
https://stackoverflow.com/questions/150355/programmatically-find-the-number-of-cores-on-a-machine

fixed


This is amazing

Thank you very much. Can we expect an update in August again?

@thereaderfortyfive Yes! I will push the preview branch soon! Thank you for checking in.

Curious if it was written manually or generated somehow?

@thereaderfortyfive Updated so for now I am going to close this issue! Thanks for the support!

@tahirmt Yes it is! I wrote a little script that parsed a list of SFSymbols and then a super tiny generator that creates these enums.
Recently I moved to the nested enum style so I had to write another code generator.


Alert Popup Box feature in contact form upon submission

🚀 Feature
As when user fills the contact form and click on Submit button then there is no respond means neither the page reloads nor a successful message is delivered.
Pitch
I want to add an alert which will pops up and will tell the user that message was delivered successfully, thanks for their submission.
Add relevant screenshot or video (if any)

/assign


Anyway to get venv-selector to look for local python venv

If I have a different python venv in the same directory as the python project how can I show that on venv selector. This is my current config for the plugin:
require("venv-selector").setup({
    name = { "env", "venv", ".venv" },
})

But it doesn't recognize any local python venvs. For clarification I am using the builitin python command to create a python venv by:
python -m venv env

Hi!
I cant seem to reproduce the issue here. I created a python virtual environment called env, like you posted, in the same directory as my python files (i created a new dir called test_venvsel.
python -m venv env

And I see it fine, its the last one in the list in the screenshot.
Lets try to add debug output and see what you get. Change your code to:
 require("venv-selector").setup({
    name = { "env", "venv", ".venv" },
    enable_debug_output = true
})

Now when you restart neovim, you will start to get messages from VenvSelect. Go to your python project and try to find virtual environments. Then you can type :messages in neovim to see all the messages. Copy all the output that is prefixed with VenvSelect: and post it here. :)

Thanks for the reply, here are the debug messages:
VenvSelect: Setting fd binary to 'fd' since it was found on system and requested by user instead of fd.
VenvSelect: Telescope path: /home/pydev19/Documents/Projects/Python/PyTorch_Learning
VenvSelect: Refresh telescope since there are no previous results.
VenvSelect: Removed telescope results.
VenvSelect: Finding parent venvs in: /home/pydev19/Documents/Projects
VenvSelect: Found venv in parent search: /home/pydev19/Documents/Projects/Python/TubeFetchr-CLI/env/
VenvSelect: Found venv in parent search: /home/pydev19/Documents/Projects/Python/PyTorch_Learning/env/
VenvSelect: Found venv in parent search: /home/pydev19/Documents/Projects/Python/PyClickerX/env/
VenvSelect: Found venv in parent search: /home/pydev19/Documents/Projects/Python/PyTorch_Learning/env/lib/python3.11/site-packages/jedi/third_party/typeshed/stdlib/3/venv/
VenvSelect: Found venv in parent search: /home/pydev19/Documents/Projects/Python/ModDownloaderX/env/
VenvSelect: Found workspace folder: /home/pydev19/Documents/Projects/Python/PyTorch_Learning
VenvSelect: Running search for workspace venvs with: fd -HItd --absolute-path --color never '(^env$|^venv$|^.venv$)' --search-path /home/pydev19/Documents/Projects/Python/PyTorch_Learning
VenvSelect: Found venv in Workspace search: /home/pydev19/Documents/Projects/Python/PyTorch_Learning/env/
VenvSelect: Found venv in Workspace search: /home/pydev19/Documents/Projects/Python/PyTorch_Learning/env/lib/python3.11/site-packages/jedi/third_party/typeshed/stdlib/3/venv/
VenvSelect: Found no venv manager directories to search for venvs.
VenvSelect: Telescope path: /home/pydev19/Documents/Projects/Python/PyTorch_Learning
VenvSelect: Removed telescope results.
VenvSelect: User refreshed results - buffer_dir is: /home/pydev19/Documents/Projects/Python/PyTorch_Learning
VenvSelect: Finding parent venvs in: /home/pydev19/Documents/Projects
VenvSelect: Found venv in parent search: /home/pydev19/Documents/Projects/Python/ModDownloaderX/env/
VenvSelect: Found venv in parent search: /home/pydev19/Documents/Projects/Python/PyClickerX/env/
VenvSelect: Found venv in parent search: /home/pydev19/Documents/Projects/Python/PyTorch_Learning/env/
VenvSelect: Found venv in parent search: /home/pydev19/Documents/Projects/Python/PyTorch_Learning/env/lib/python3.11/site-packages/jedi/third_party/typeshed/stdlib/3/venv/
VenvSelect: Found venv in parent search: /home/pydev19/Documents/Projects/Python/TubeFetchr-CLI/env/
VenvSelect: Found no workspaces to search for venvs.
VenvSelect: Found no venv manager directories to search for venvs.
VenvSelect: Removed telescope results.
VenvSelect: User refreshed results - buffer_dir is: /home/pydev19/Documents/Projects/Python/PyTorch_Learning
VenvSelect: Finding parent venvs in: /home/pydev19/Documents/Projects
VenvSelect: Found venv in parent search: /home/pydev19/Documents/Projects/Python/ModDownloaderX/env/
VenvSelect: Found venv in parent search: /home/pydev19/Documents/Projects/Python/PyClickerX/env/
VenvSelect: Found venv in parent search: /home/pydev19/Documents/Projects/Python/PyTorch_Learning/env/
VenvSelect: Found venv in parent search: /home/pydev19/Documents/Projects/Python/PyTorch_Learning/env/lib/python3.11/site-packages/jedi/third_party/typeshed/stdlib/3/venv/
VenvSelect: Found venv in parent search: /home/pydev19/Documents/Projects/Python/TubeFetchr-CLI/env/
VenvSelect: Found no workspaces to search for venvs.
VenvSelect: Found no venv manager directories to search for venvs.
VenvSelect: Removed telescope results.
VenvSelect: User refreshed results - buffer_dir is: /home/pydev19/Documents/Projects/Python/PyTorch_Learning
VenvSelect: Finding parent venvs in: /home/pydev19/Documents/Projects
E5108: Error executing lua .../nvim/lazy/venv-selector.nvim/lua/venv-selector/venv.lua:84: attempt to index local 'venv_row' (a nil value)
stack traceback:
	.../nvim/lazy/venv-selector.nvim/lua/venv-selector/venv.lua:84: in function 'set_venv_and_system_paths'
	.../nvim/lazy/venv-selector.nvim/lua/venv-selector/venv.lua:206: in function 'activate_venv'
	.../lazy/venv-selector.nvim/lua/venv-selector/telescope.lua:76: in function 'key_func'
	...hare/nvim/lazy/telescope.nvim/lua/telescope/mappings.lua:352: in function 'execute_keymap'
	[string ":lua"]:1: in main chunk
VenvSelect: Cannot start a new search while old one is running.
VenvSelect: Cannot start a new search while old one is running.
VenvSelect: Cannot start a new search while old one is running.
VenvSelect: Found venv in parent search: /home/pydev19/Documents/Projects/Python/ModDownloaderX/env/
VenvSelect: Found venv in parent search: /home/pydev19/Documents/Projects/Python/PyClickerX/env/
VenvSelect: Found venv in parent search: /home/pydev19/Documents/Projects/Python/PyTorch_Learning/env/
VenvSelect: Found venv in parent search: /home/pydev19/Documents/Projects/Python/PyTorch_Learning/env/lib/python3.11/site-packages/jedi/third_party/typeshed/stdlib/3/venv/
VenvSelect: Found venv in parent search: /home/pydev19/Documents/Projects/Python/TubeFetchr-CLI/env/
VenvSelect: Found no workspaces to search for venvs.
VenvSelect: Found no venv manager directories to search for venvs.

While reading this I found that is does find the venv but doesn't add it to the list when I run VenvSelect it shows nothing. Further more if I run :lua print(require("venv-selector").get_active_venv()) I just get nil

Yeah this is strange. I wonder what happens here... like you say, the venvs are found but there is an error when they are supposed to be added to the telescope picker.
And you have nvim-telescope/telescope.nvim installed as a requirement also, and its loaded?
I can try to look in the code and see what could go wrong, but its difficult when its working on my own system. I could add some more debug printouts to maybe understand more whats going on for you.

I added some more debug output in a version i just pushed. Try again to run it and see if debug output shows some more info. Just trying to understand where it goes wrong. :)

I tried it with the new push with new debug options but the output it still the same I think it has something to do with this message:
VenvSelect: Found no workspaces to search for venvs.
VenvSelect: Found no venv manager directories to search for venvs.

But if you need the full messages then this is it:
VenvSelect:
{
  anaconda_path = "$CONDA_PREFIX/envs",
  auto_refresh = false,
  cache_dir = "/home/pydev19/.cache/venv-selector/",
  cache_file = "/home/pydev19/.cache/venv-selector/venvs.json",
  changed_venv_hooks = { <function 1>, <function 2> },
  dap_enabled = false,
  enable_debug_output = true,
  fd_binary_name = "fd",
  name = { "env" },
  notify_user_on_activate = true,
  parents = 2,
  pipenv_path = "~/.local/share/virtualenvs",
  poetry_path = "~/.cache/pypoetry/virtualenvs",
  pyenv_path = "~/.pyenv/versions",
  search = true,
  search_venv_managers = true,
  search_workspace = true
}
VenvSelect: Setting fd binary to 'fd' since it was found on system and requested by user instead of fd.
"~/Documents/Projects/Python/YTDownloader/src/main.py" 19L, 435B written
VenvSelect: Telescope path: /home/pydev19/Documents/Projects/Python/YTDownloader/src
VenvSelect: Refresh telescope since there are no previous results.
VenvSelect: Removed telescope results.
VenvSelect: Finding parent venvs in: /home/pydev19/Documents/Projects/Python
VenvSelect: Found venv in parent search: /home/pydev19/Documents/Projects/Python/TubeFetchr-CLI/env/
VenvSelect: Found venv in parent search: /home/pydev19/Documents/Projects/Python/PyTorch_Learning/env/
VenvSelect: Found venv in parent search: /home/pydev19/Documents/Projects/Python/PyClickerX/env/
VenvSelect: Found venv in parent search: /home/pydev19/Documents/Projects/Python/YTDownloader/env/
VenvSelect: Found venv in parent search: /home/pydev19/Documents/Projects/Python/ModDownloaderX/env/
VenvSelect: Found workspace folder: /home/pydev19/Documents/Projects/Python/YTDownloader
VenvSelect: Running search for workspace venvs with: fd -HItd --absolute-path --color never '(^env$)' --search-path /home/pydev19/Documents/Projects/Python/YTDownloader
VenvSelect: Found venv in Workspace search: /home/pydev19/Documents/Projects/Python/YTDownloader/env/
VenvSelect: Found no venv manager directories to search for venvs.
VenvSelect: Removed telescope results.
VenvSelect: User refreshed results - buffer_dir is: /home/pydev19/Documents/Projects/Python/YTDownloader/src
VenvSelect: Finding parent venvs in: /home/pydev19/Documents/Projects/Python
VenvSelect: Found venv in parent search: /home/pydev19/Documents/Projects/Python/ModDownloaderX/env/
VenvSelect: Found venv in parent search: /home/pydev19/Documents/Projects/Python/PyClickerX/env/
VenvSelect: Found venv in parent search: /home/pydev19/Documents/Projects/Python/PyTorch_Learning/env/
VenvSelect: Found venv in parent search: /home/pydev19/Documents/Projects/Python/TubeFetchr-CLI/env/
VenvSelect: Found venv in parent search: /home/pydev19/Documents/Projects/Python/YTDownloader/env/
VenvSelect: Found no workspaces to search for venvs.
VenvSelect: Found no venv manager directories to search for venvs.
VenvSelect: Removed telescope results.
VenvSelect: User refreshed results - buffer_dir is: /home/pydev19/Documents/Projects/Python/YTDownloader/src
VenvSelect: Finding parent venvs in: /home/pydev19/Documents/Projects/Python
VenvSelect: Found venv in parent search: /home/pydev19/Documents/Projects/Python/ModDownloaderX/env/
VenvSelect: Found venv in parent search: /home/pydev19/Documents/Projects/Python/PyClickerX/env/
VenvSelect: Found venv in parent search: /home/pydev19/Documents/Projects/Python/PyTorch_Learning/env/
VenvSelect: Found venv in parent search: /home/pydev19/Documents/Projects/Python/TubeFetchr-CLI/env/
VenvSelect: Found venv in parent search: /home/pydev19/Documents/Projects/Python/YTDownloader/env/
VenvSelect: Found no workspaces to search for venvs.
VenvSelect: Found no venv manager directories to search for venvs.
VenvSelect: Removed telescope results.
VenvSelect: User refreshed results - buffer_dir is: /home/pydev19/Documents/Projects/Python/YTDownloader/src
VenvSelect: Finding parent venvs in: /home/pydev19/Documents/Projects/Python
VenvSelect: Found venv in parent search: /home/pydev19/Documents/Projects/Python/ModDownloaderX/env/
VenvSelect: Found venv in parent search: /home/pydev19/Documents/Projects/Python/PyClickerX/env/
VenvSelect: Found venv in parent search: /home/pydev19/Documents/Projects/Python/PyTorch_Learning/env/
VenvSelect: Found venv in parent search: /home/pydev19/Documents/Projects/Python/TubeFetchr-CLI/env/
VenvSelect: Found venv in parent search: /home/pydev19/Documents/Projects/Python/YTDownloader/env/
VenvSelect: Found no workspaces to search for venvs.
VenvSelect: Found no venv manager directories to search for venvs.
VenvSelect: Removed telescope results.
VenvSelect: User refreshed results - buffer_dir is: /home/pydev19/Documents/Projects/Python/YTDownloader/src
VenvSelect: Finding parent venvs in: /home/pydev19/Documents/Projects/Python
VenvSelect: Found venv in parent search: /home/pydev19/Documents/Projects/Python/ModDownloaderX/env/
VenvSelect: Found venv in parent search: /home/pydev19/Documents/Projects/Python/PyClickerX/env/
VenvSelect: Found venv in parent search: /home/pydev19/Documents/Projects/Python/PyTorch_Learning/env/
VenvSelect: Found venv in parent search: /home/pydev19/Documents/Projects/Python/TubeFetchr-CLI/env/
VenvSelect: Found venv in parent search: /home/pydev19/Documents/Projects/Python/YTDownloader/env/
VenvSelect: Found no workspaces to search for venvs.
VenvSelect: Found no venv manager directories to search for venvs.
VenvSelect: Removed telescope results.
VenvSelect: User refreshed results - buffer_dir is: /home/pydev19/Documents/Projects/Python/YTDownloader/src
VenvSelect: Finding parent venvs in: /home/pydev19/Documents/Projects/Python
VenvSelect: Found venv in parent search: /home/pydev19/Documents/Projects/Python/ModDownloaderX/env/
VenvSelect: Found venv in parent search: /home/pydev19/Documents/Projects/Python/PyClickerX/env/
VenvSelect: Found venv in parent search: /home/pydev19/Documents/Projects/Python/PyTorch_Learning/env/
VenvSelect: Found venv in parent search: /home/pydev19/Documents/Projects/Python/TubeFetchr-CLI/env/
VenvSelect: Found venv in parent search: /home/pydev19/Documents/Projects/Python/YTDownloader/env/
VenvSelect: Found no workspaces to search for venvs.
VenvSelect: Found no venv manager directories to search for venvs.

No those messages saying it doesn't find venv manager directories are Pipenv, Pyenv, Condas and so on. It's normal for those to not be found if you don't use those.
Workspaces may or may not exist also. You should have a workspace if you use pyright but even if you don't, it should pick up venv directories located in your project.
So right now I don't know what's going on here....

I tried also to remove my venv manager directories so they dont show, but still cant trigger the bug you have.
Here is a sample from my debug output, and it has the same messages as yours but still displays the results, and this is intended behavior.
VenvSelect: Found venv in parent search: /home/cado/Code/upsales/venv/
VenvSelect: Found venv in parent search: /home/cado/Code/zendesk/venv/
VenvSelect: Found no workspaces to search for venvs.
VenvSelect: Found no venv manager directories to search for venvs.
VenvSelect: There is 10 results to show.

Ok, so now I am getting a new message:
VenvSelect: There is 5 results to show.

But when I run :VenvSelect it shows nothing

This means everything is working fine right until the very last bit where the results are supposed to be shown by telescope.
Are you sure telescope is correctly installed? If you run Telescope old_files for example, it all works?
I added a printout of the results also, just to make sure there is not something weird about yours. Update the plugin and try to use it one last time, and show how the last part looks where it prints the actual results.
Otherwise im not sure what to do actually... its difficult to troubleshoot more than this since its literally just the telescope display part left now, and that should work if its installed correctly...

I tried also to remove my venv manager directories so they dont show, but still cant trigger the bug you have.
Here is a truncated sample from my debug output, and it has the same messages as yours but still displays the results, and this is intended behavior.
VenvSelect: Found venv in parent search: /home/cado/Code/upsales/venv/
VenvSelect: Found venv in parent search: /home/cado/Code/zendesk/venv/
VenvSelect: Found no workspaces to search for venvs.
VenvSelect: Found no venv manager directories to search for venvs.
VenvSelect: There is 10 results to show.

I also pushed another change so there is no error when you select an empty row in telescope (when there are no results).

I still get this error even when I select an empty row, it is telling me that there are 5 results to show but doesn't actually show them

Those are not errors, just information. Its fine to not have a workspace or to not use a venv manager. The plugin will work anyway.
If you update VenvSelector to the latest version, it should also log the actual content of the rows its trying to show in telescope. Would be interesting to see them.

This means everything is working fine right until the very last bit where the results are supposed to be shown by telescope.
Are you sure telescope is correctly installed? If you run Telescope old_files for example, it all works?
I added a printout of the results also, just to make sure there is not something weird about yours. Update the plugin and try to use it one last time, and show how the last part looks where it prints the actual results.
Otherwise im not sure what to do actually... its difficult to troubleshoot more than this since its literally just the telescope display part left now, and that should work if its installed correctly...
Whats your operating system and vim version?

My system is fedora 38, neovim version 0.9.1.
When I run Telescope old_files it shows everything perfectly fine

Those are not errors, just information. Its fine to not have a workspace or to not use a venv manager. The plugin will work anyway.
If you update VenvSelector to the latest version, it should also log the actual content of the rows its trying to show in telescope. Would be interesting to see them.

I did update it and yes it does show the content of the rows it is trying to display like this:
VenvSelect: Telescope path: /home/pydev19/Documents/Projects/C++/TubeFetchr/src
VenvSelect: There are 1 results to show:
VenvSelect:
{ {
    display = <function 1>,
    icon = "󰅬",
    index = 1,
    ordinal = "/home/pydev19/Documents/Projects/C++/TubeFetchr/env",
    path = "/home/pydev19/Documents/Projects/C++/TubeFetchr/env",
    source = "Search",
    value = "/home/pydev19/Documents/Projects/C++/TubeFetchr/env"
  } }

But still nothing shows in the VenvSelect command.
A new thing did happen, when I don't run neovim inside python venv and I run VenvSelect it sets the neovim venv to {current_file_name}/bin, which is not a directory. (current_file_name is the first file I open in neovim once I run it)

Its quite strange. I tried moving some of my own telescope code around and renaming some things to make sure there are no conflicts with the telescope plugin, but its a shot in the dark.
I really dont understand why its not showing for you, but you can try the latest commit, maybe it helps somehow.

I figured out the problem and it was all my fault. I looked into it being a telescope problem so I check my config. Then I realized that I told telescope to ignore anything including 'env' here:
defaults = {
    file_ignore_patterns = {
		"node_modules",
                "env/*"
	},
}

After removing the env/* it works now.
Sorry for all the trouble I caused.


Use Markdown Extra instead of Markdown

By using MarkdownExtra, significant extra functionality is made available to users.  For example, it is now possible to format tables within docblocks.
This update does not alter any existing behaviour of sami.
For a full explanation of the extra features available in Markdown Extra, see https://michelf.ca/projects/php-markdown/extra/

Thank you @mattgorle.


The translation of some of the Surah names are off

Seems that Pickthall's translation of the names are used, and they have a few issues. Most prominently:

At-Taghabun — THE MUTUAL DISILLUSION
At-Takwir — THE OVERTHROWING

Likewise, the following translations are somewhat questionable:

As-Saffat — THOSE WHO SET THE RANKS
Fussilat — EXPLAINED IN DETAIL
Al-Jathiyah — THE CROUCHING
Al-Mutaffifin — THE DEFRAUDING
Ash-Sharh — THE RELIEF
Al-Mujadila — THE PLEADING WOMAN
Al-Mumtahanah — SHE THAT IS TO BE EXAMINED
As-Saf — THE RANKS
Al-Humazah — THE TRADUCER (very archaic)

I assume that Sahih Intl's translations are better, but that has to be looked into.
On a somewhat related note, "Al-Anbya" should be spelled "Al-Anbiya'".

@mustafa0x what about Clear Quran? Got this data few months ago but somehow forget to update the translations.
please ignore the unrelated stuff
۩ ◙ ☼ 1. The Opening  (Al-Fâtiḥah)	23
۩ ◙ ☼ 2. The Cow  (Al-Baqarah)	24
۩ ◙ ☼ 3. The Family of ’Imrân  (Âli-’Imrân)	47
۩ ◙ ☼ 4. Women  (An-Nisâ')	61
۩ ◙ ☼ 5. The Spread Table  (Al-Mâ'idah)	75
۩ ◙ ☼ 6. Cattle  (Al-An’âm)	86
۩ ◙ ☼ 7. The Heights  (Al-A’râf)	98
۩ ◙ ☼ 8. Spoils of War  (Al-Anfâl)	111
۩ ◙ ☼ 9. Repentance  (At-Tawbah)	117
۩ ◙ ☼ 10. Jonah  (Yûnus)	127
۩ ◙ ☼ 11. Hûd  (Hûd)	134
۩ ◙ ☼ 12. Joseph  (Yûsuf)	142
۩ ◙ ☼ 13. Thunder  (Ar-Ra’d)	149
۩ ◙ ☼ 14. Abraham  (Ibrâhîm)	153
۩ ◙ ☼ 15. The Stone Valley  (Al-Ḥijr)	157
۩ ◙ ☼ 16. Bees  (An-Naḥl)	160
۩ ◙ ☼ 17. The Night Journey (Al-Isrâ')	168
۩ ◙ ☼ 18. The Cave  (Al-Kahf)	175
۩ ◙ ☼ 19. Mary  (Mariam)	182
۩ ◙ ☼ 20. Ṭâ-Hâ  (Ṭâ-Hâ)	187
۩ ◙ ☼ 21. The Prophets  (Al-Anbiyâ')	193
۩ ◙ ☼ 22. The Pilgrimage  (Al-Ḥajj)	198
۩ ◙ ☼ 23. The Believers  (Al-Mu'minûn)	203
۩ ◙ ☼ 24. The Light  (An-Nûr)	208
۩ ◙ ☼ 25. The Standard  (Al-Furqân)	214
۩ ◙ ☼ 26. The Poets  (Ash-Shu’arâ')	219
۩ ◙ ☼ 27. The Ants  (An-Naml)	225
۩ ◙ ☼ 28. The Whole Story  (Al-Qaṣaṣ)	230
۩ ◙ ☼ 29. The Spider  (Al-’Ankabût)	236
۩ ◙ ☼ 30. The Romans  (Ar-Rûm)	240
۩ ◙ ☼ 31. Luqmân  (Luqmân)	244
۩ ◙ ☼ 32. The Prostration  (As-Sajdah)	247
۩ ◙ ☼ 33. The Enemy Alliance  (Al-Aḥzâb)	249
۩ ◙ ☼ 34. Sheba  (Saba')	255
۩ ◙ ☼ 35. The Originator  (Fâṭir)	259
۩ ◙ ☼ 36. Yâ-Sĩn  (Yâ-Sĩn)	263
۩ ◙ ☼ 37. Those ˹Angels˺  Lined up in Ranks  (Aṣ-Ṣâffât)	267
۩ ◙ ☼ 38. Ṣãd  (Ṣãd)	271
۩ ◙ ☼ 39. The ˹Successive˺ Groups  (Az-Zumar)	275
۩ ◙ ☼ 40. The Forgiver  (Ghâfir)	280
۩ ◙ ☼ 41. ˹Verses˺  Perfectly Explained  (Fuṣṣilat)	285
۩ ◙ ☼ 42. Consultation  (Ash-Shûra)	289
۩ ◙ ☼ 43. Ornaments  (Az-Zukhruf)	293
۩ ◙ ☼ 44. The Haze  (Ad-Dukhân)	297
۩ ◙ ☼ 45. The Kneeling  (Al-Jâthiyah)	299
۩ ◙ ☼ 46. The Sand-Hills  (Al-Aḥqâf)	302
۩ ◙ ☼ 47. Muḥammad (Muḥammad)	305
۩ ◙ ☼ 48. The Triumph  (Al-Fatḥ)	308
۩ ◙ ☼ 49. The Private Quarters  (Al-Ḥujurât)	311
۩ ◙ ☼ 50. Qãf  (Qãf)	313
۩ ◙ ☼ 51. Scattering Winds  (Aⱬ-Ⱬâriyât)	315
۩ ◙ ☼ 52. Mount Ṭûr  (Aṭ-Ṭûr)	318
۩ ◙ ☼ 53. The Stars  (An-Najm)	320
۩ ◙ ☼ 54. The Moon  (Al-Qamar)	322
۩ ◙ ☼ 55. The Most Compassionate  (Ar-Raḥmân)	324
۩ ◙ ☼ 56. The Inevitable Event  (Al-Wâqi’ah)	326
۩ ◙ ☼ 57. Iron  (Al-Ḥadîd)	328
۩ ◙ ☼ 58. The Pleading Woman  (Al-Mujâdilah)	331
۩ ◙ ☼ 59. The Banishment  (Al-Ḥashr)	334
۩ ◙ ☼ 60. The Test of Faith  (Al-Mumtaḥanah)	336
۩ ◙ ☼ 61. The ˹Solid˺ Ranks  (Aṣ-Ṣaff)	338
۩ ◙ ☼ 62. Friday Congregation (Al-Jumu’ah)	340
۩ ◙ ☼ 63. The Hypocrites  (Al-Munâfiqûn)	341
۩ ◙ ☼ 64. Mutual Loss and Gain  (At-Taghâbun)	342
۩ ◙ ☼ 65. Divorce  (Aṭ-Ṭalâq)	344
۩ ◙ ☼ 66. The Prohibition  (At-Taḥrîm)	346
۩ ◙ ☼ 67. All Authority  (Al-Mulk)	348
۩ ◙ ☼ 68. The Pen  (Al-Qalam)	350
۩ ◙ ☼ 69. The Inevitable Hour  (Al-Ḥâqqah)	352
۩ ◙ ☼ 70. Pathways of  ˹Heavenly˺ Ascent  (Al-Ma’ârij)	354
۩ ◙ ☼ 71. Noah  (Nûḥ)	356
۩ ◙ ☼ 72. The Jinn  (Al-Jinn)	358
۩ ◙ ☼ 73. The Wrapped One  (Al-Muzzammil)	360
۩ ◙ ☼ 74. The One Covered up  (Al-Muddaththir)	361
۩ ◙ ☼ 75. The ˹Rising for˺ Judgment  (Al-Qiyamah)	363
۩ ◙ ☼ 76. Humans  (Al-Insân)	364
۩ ◙ ☼ 77. Those ˹Winds˺  Sent Forth  (Al-Mursalât)	366
۩ ◙ ☼ 78. The Momentous News  (An-Naba')	368
۩ ◙ ☼ 79. Those ˹Angels˺  Stripping out ˹Souls˺  (An-Nâzi’ât)	370
۩ ◙ ☼ 80. He Frowned  (’Abasa)	372
۩ ◙ ☼ 81. Putting out ˹the Sun˺  (At-Takwîr)	373
۩ ◙ ☼ 82. The ˹Sky˺ Splitting Open  (Al-Infiṭâr)	374
۩ ◙ ☼ 83. Defrauders  (Al-Muṭaffifîn)	375
۩ ◙ ☼ 84. The ˹Sky˺ Bursting Open  (Al-Inshiqâq)	376
۩ ◙ ☼ 85. Constellations (Al-Burûj)	377
۩ ◙ ☼ 86. The Nightly Star  (Aṭ-Ṭâriq)	378
۩ ◙ ☼ 87. The Most High  (Al-A’la)	379
۩ ◙ ☼ 88. The Overwhelming Event  (Al-Ghâshiyah)	380
۩ ◙ ☼ 89. Dawn  (Al-Fajr)	381
۩ ◙ ☼ 90. The City  (Al-Balad)	382
۩ ◙ ☼ 91. The Sun  (Ash-Shams)	383
۩ ◙ ☼ 92. The Night  (Al-Layl)	384
۩ ◙ ☼ 93. The Morning Sunlight  (Aḍ-Ḍuḥa)	385
۩ ◙ ☼ 94. Uplifting the Heart  (Ash-Sharḥ)	386
۩ ◙ ☼ 95. The Fig  (At-Tîn)	387
۩ ◙ ☼ 96. The Clinging Clot ˹of Blood˺ (Al-’Alaq)	388
۩ ◙ ☼ 97. The Night of Glory  (Al-Qadr)	389
۩ ◙ ☼ 98. The Clear Proof  (Al-Bayyinah)	390
۩ ◙ ☼ 99. The ˹Ultimate˺ Quake  (Az-Zalzalah)	391
۩ ◙ ☼ 100. The Galloping ˹Horses˺  (Al-’Ȃdiyât)	392
۩ ◙ ☼ 101. The Striking Disaster  (Al-Qâri’ah)	393
۩ ◙ ☼ 102. Competition  for More ˹Gains˺  (At-Takâthur)	394
۩ ◙ ☼ 103. The ˹Passage of˺ Time  (Al-’Aṣr)	395
۩ ◙ ☼ 104. The Backbiters  (Al-Humazah)	396
۩ ◙ ☼ 105. The Elephant  (Al-Fîl)	397
۩ ◙ ☼ 106. ˹The People of˺ Quraysh  (Quraysh)	398
۩ ◙ ☼ 107. ˹Simplest˺ Aid  (Al-Mâ’ûn)	399
۩ ◙ ☼ 108. Abundant Goodness  (Al-Kawthar)	400
۩ ◙ ☼ 109. The Disbelievers  (Al-Kâfirûn)	401
۩ ◙ ☼ 110. The ˹Ultimate˺ Help  (An-Naṣr)	402
۩ ◙ ☼ 111. The Palm-Fibre Rope  (Al-Masad)	403
۩ ◙ ☼ 112. Purity of Faith  (Al-Ikhlâṣ)	404
۩ ◙ ☼ 113. The Daybreak   (Al-Falaq)	405
۩ ◙ ☼ 114. Humankind  (An-Nâs)	406

Mostly better, but hopefully something even more clear and concise can be found. A lot of the context added to the translation is unneeded and even questionable. E.g. The ˹Ultimate˺ Help, The Night of Glory, and Friday Congregation.

What about these from Abd Al-Haleem's translation?

The Opening (Al-Fatiha) 3
The Cow (Al-Baqara) 4
The Family of Tmran (Al-'Imran) 34
Women (Al-Nisa') 50
The Feast (Al-Ma'ida) 67
Livestock (Al-An'am) 80
The Heights (Al-A'raf) 94
Battle Gains (Al-Anfal) no
Repentance (Al-Tawba) 116
Jonah (Yunus) 128
Hud (Hud) 136
Joseph ( Yusuf) 145
Thunder (Al-Ra'd) 153
Abraham (Ibrahim) 158
Al-Hijr (Al-Hijr) 162
The Bee (Al-Nahl) 166
The Night Journey (Al-Isra') 175
The Cave (Al-Kahf) 183
Mary (Mary am) 191
Ta Ha (Ta Ha) 196
The Prophets (Al-Anbiya') 203
The Pilgrimage (Al-Hajj) 209
The Believers (Al-Muminun) 215
Light (Al-Nur) 220
The Differentiator {Al-Furqan) 227
The Poets (Al-Shu ara) 232
The Ants (Al-Naml) 239
The Story (Al-Qasas) 245
The Spider {Al-'Ankabut) 252
The Byzantines (Al-Rum) 257
Luqman (Luqman) 261
Bowing down in Worship (Al-Sajda) 264
The Joint Forces (Al-Ahzab) 266
Sheba {Saba") 172
The Creator (Fatir) 277
Ya Sin (Ya Sin) 281
Ranged in Rows (Al-Saffat) 285
5W (>SW) 290
The Throngs (Al-Zumar) 295
The Forgiver (Ghafir) 301
[Verses] Made Distinct (Fussilat) 307
Consultation (Al-Shura) 311
Ornaments of Gold (Al-Zukhruf) 316
Smoke (Al-Dukhan) 321
Kneeling (Al-Jathiya) 324
The Sand Dunes (Al-Ahqaf) 327
Muhammad (Muhammad) 331
Triumph (Al-Fath) 334
The Private Rooms (Al-Hujurat) 338
Â£Â«/ (Â£Â«/) 340
Scattering [Winds] (Al-Dhariyat) 343
The Mountain (Al-Tur) 345
The Star (Al-Najm) 347
The Moon (Al-Qamar) 350
The Lord of Mercy (Al-Rahman) 353
That which is Coming (Al-Waqi'a) 356
Iron (Al-Hadid) 359
The Dispute (Al-Mujadala) 362
Contents vii
The Gathering [of Forces] (Al-Hashr) 365
Women Tested (Al-Mumtahana) 368
Solid Lines (Al-Sajf) 370
The Day of Congregation (Al-Jumu'a) 372
The Hypocrites (Al-Munafiqun) 374
Mutual Neglect (Al-Taghabun) 376
Divorce (Al-Talaq) 378
Prohibition (Al-Tahrim) 380
Control (Al-Mulk) 382
The Pen (Al-Qalam) 384
The Inevitable Hour (Al-Haqqa) 387
The Ways of Ascent {Al-Ma'arij) 389
Noah (Null) 391
The Jinn (Al-jfinn) 393
Enfolded (Al-Muzzammil) 395
Wrapped in his Cloak (Al-Muddaththir) 397
The Resurrection (Al-Qiyamd) 399
Man (Al-Insan) 401
[Winds] Sent Forth (Al-Mursalat) 403
The Announcement (Al-Naba') 405
The Forceful Chargers (Al-Nazi'at) 407
He Frowned ('Abasa) 409
Shrouded in Darkness (Al-Takwir) 411
Torn Apart (Al-Infitar) 412
Those who Give Short Measure (Al-Mutaffifin) 413
Ripped Apart (Al-Inshiqaq) 415
The Towering Constellations (Al-Buruj) \b
The Night-Comer (Al-Tariq) 417
The Most High (Al-A'la) 418
The Overwhelming Event (Al-Ghashiya) 419
Daybreak (Al-Fajr) 420
The City (Al-Balad) 422
The Sun (Al-Shams) 423
The Night (Al-Layl) 424
The Morning Brightness (Al-Duha) 425
Relief {Al-Sharh) 426
The Fig (Al-Tin) 427
The Clinging Form (Al-'Alaq) 428
The Night of Glory (Al-Qadr) 429
Clear Evidence (Al-Bayyina) 430
The Earthquake {Al-Zalzala) 431
The Charging Steeds {Al-'Adiyat) 432
The Crashing Blow (Al-Qari'a) 433
Striving for More (Al-Takathur) 434
The Declining Day (Al-'Asr) 435
The Backbiter (Al-Humaza) 436
The Elephant (Al-Fil) 437
Quraysh (Quraysh) 438
Common Kindnesses (Al-Maun) 439
Abundance (Al-Kawthar) 440
The Disbelievers (Al-Kafirun) 441
Help (Al-Nasr) 442
Palm Fibre (Al-Masad) 443
Purity [of Faith] (Al-Ikhlas) 444
Daybreak (Al-Falaq) 445
People (Al-Nas) 446

Muslimin names the surah differently, but often they keep deep and related meaning of the content in the name they choose.
So I suggest we provide them all the names, even better with available explaination.
And we the majority as default name. Even better if the app could adapt to user region to pick the default name.


test: fix server hmr port conflict

Description
Similar to #7523 but for hmr port.
Ideally, it should use the next unused port instead but it will require more work so I didn't do it in this PR.
Also I feel it curious to silent EADDRINUSE for ws server. 🤔
https://github.com/vitejs/vite/blob/0858450b2a258b216ae9aa797cc02e9a0d4eb0af/packages/vite/src/node/server/ws.ts#L162-L169
Steps to reproduce

Edit playground/ssr-react/server.js line 90 app.listen(5173, () => { to app.listen(5174, () => {.
Run pnpm dev in playground/ssr-vue
Run pnpm dev in playground/ssr-react
Edit playground/ssr-react/src/pages/Home.jsx
HMR does not happen

Additional context
It does not affect CI because only one thread is used with CI.

What is the purpose of this pull request?

[ ] Bug fix
[ ] New Feature
[ ] Documentation update
[x] Other

Before submitting the PR, please make sure you do the following

[x] Read the Contributing Guidelines.
[x] Read the Pull Request Guidelines and follow the Commit Convention.
[x] Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
[x] Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
[ ] Ideally, include relevant tests that fail without this PR but pass with it.

Nicee it's working for me too. Maybe it's still worth looking into auto-increment the the hmr port, but I think this is fine for now to get local tests running properly. And also, maybe this is the reason we can't run multiple threads on CI? So we can tune it up now 🤔


powerline-symbols: init at 2.8.1

Motivation for this change
Add the powerline-symbols font. This is different from powerline-fonts, which is a collection of various patched fonts with powerline additions. This only includes the powerline symbols, and no patched fonts.
Result of nixpkgs-review
❯ nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
$ git -c fetch.prune=false fetch --force https://github.com/NixOS/nixpkgs master:refs/nixpkgs-review/0
$ git worktree add /home/midchildan/.cache/nixpkgs-review/rev-e27f7903a1e43154dee15bd99016af633a017227/nixpkgs 2032339e5bbce8a57655b8742190ecb32b7af863
Preparing worktree (detached HEAD 2032339e5bb)
Updating files: 100% (23852/23852), done.
HEAD is now at 2032339e5bb mmv-go: 0.1.2 -> 0.1.3
$ nix-env -f /home/midchildan/.cache/nixpkgs-review/rev-e27f7903a1e43154dee15bd99016af633a017227/nixpkgs -qaP --xml --out-path --show-trace
$ git merge --no-commit e27f7903a1e43154dee15bd99016af633a017227
Updating 2032339e5bb..e27f7903a1e
Fast-forward
 pkgs/data/fonts/powerline-symbols/default.nix | 19 +++++++++++++++++++
 pkgs/top-level/all-packages.nix               |  2 ++
 2 files changed, 21 insertions(+)
 create mode 100644 pkgs/data/fonts/powerline-symbols/default.nix
$ nix-env -f /home/midchildan/.cache/nixpkgs-review/rev-e27f7903a1e43154dee15bd99016af633a017227/nixpkgs -qaP --xml --out-path --show-trace --meta
1 package added:
powerline-symbols (init at 2.8.1)

warning: ignoring the user-specified setting 'experimental-features', because it is a restricted setting and you are not a trusted user
$ nix --experimental-features nix-command build --no-link --keep-going --option build-use-sandbox relaxed -f /home/midchildan/.cache/nixpkgs-review/rev-e27f7903a1e43154dee15bd99016af633a017227/build.nix
warning: ignoring the user-specified setting 'experimental-features', because it is a restricted setting and you are not a trusted user
warning: ignoring the user-specified setting 'sandbox', because it is a restricted setting and you are not a trusted user
1 package built:
powerline-symbols

warning: ignoring the user-specified setting 'experimental-features', because it is a restricted setting and you are not a trusted user
$ nix-shell /home/midchildan/.cache/nixpkgs-review/rev-e27f7903a1e43154dee15bd99016af633a017227/shell.nix

Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

/marvin opt-in
/status needs_reviewer

/marvin opt-in
/status needs_reviewer

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 108916 run on x86_64-linux 1

1 package built:

powerline-symbols

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 108916 run on x86_64-linux 1

1 package built:

powerline-symbols


How do you suppress the WebViewKit pane on the right?

I would like to suppress the empty WebViewKit pane on the right side.
Please consider adding how to do this to the documentation.

Hi @curtcox
I'm not sure which pane you mean? Can you provide an example?

I'm talking about the right half of the image above.
When I launch on MacOS the pane is empty. It can be resized so that it is almost entirely, but not quite, invisible.
In the example above I have done the following to get content in the pane.

File >> New Window
Window >> Merge All Windows

Oh, I had accidentally used a NavigationView in the macOS demo, which placed the browser in the leading panel. I have pushed a fix for it now.


Bot help message

Output help message, see https://github.com/hunter-packages/hunter-bot/issues/4

Hedwig Console - press Ctrl+C to exit.

The console adapter is useful for quickly verifying how your
bot will respond based on the current installed responders

fire-win\fire> hunter, help
hunter> hunter help - Displays all of the help commands that hunter knows about.
hunter help <query> - Displays all help commands that match <query>.

Initial work in a debug console.

Install elixir from chocolatey

I hope it works fine on Linux?

For the reference: http://elixir-lang.org/

http://elixir-lang.org/install.html
Ubuntu 12.04 and 14.04 / Debian 7
Add Erlang Solutions repo: wget https://packages.erlang-solutions.com/erlang-solutions_1.0_all.deb && sudo dpkg -i erlang-solutions_1.0_all.deb
Run: sudo apt-get update
Install the Erlang/OTP platform and all of its applications: sudo apt-get install esl-erlang
Install Elixir: sudo apt-get install elixir

http://elixir-lang.org/install.html

Yep, reading it now


Cancel incomplete lunaria preview builds on new commits

Description
Lunaria continues to run after new commits, which wastes a bit of time but, more importantly, may cause a race in the Lunaria preview.
Concurrency options are the same as the CI file:
https://github.com/withastro/docs/blob/b5dbd5323918b4d45b96d73ccc2b49e6276862fc/.github/workflows/ci.yml#L10-L13

pull_request_target triggers workflows based on the latest commit of the pull request's base branch. So it won't use the fix until it is merged 🙃