Swapping in clocks calibrated off thread

hey,
I spent a couple hours tonight trying to work up a struct interface to a thread that periodically calibrates a Clocksource and sends clones around to any subscribing threads. However, I was surprised to find that neither of two approaches I tried ended up being faster than calling std::time::SystemTime::now(). It seems that the overhead of concurrency is more costly than the marginal speedup of rdtsc.
This branch has the code. Would be interested in any thoughts you have. Happy to eventually submit as a pull request if you'd like but figured I would check in first since 1) it didn't work quite as expected, 2) no idea if you want something like this in the library.
Here are some bench results:
i7 laptop:
$ RUSTFLAGS="-C target-cpu=native" cargo bench
# ...
running 11 tests
test tests::test_raw ... ignored
test tests::test_reference ... ignored
test tests::test_source ... ignored
test calibrator::tests::calibrates_a_realtime_counter_clocksource       ... ignored
test calibrator::tests::cloning_a_clocksource                           ... bench:           1 ns/iter (+/- 0)
test calibrator::tests::mpsc_calibrator_hot_path_loop_overhead          ... bench:          28 ns/iter (+/- 1)
test calibrator::tests::triple_buffer_calibrator_hot_path_loop_overhead ... bench:          28 ns/iter (+/- 3)
test tests::calls_rdtsc_directly                                        ... bench:          11 ns/iter (+/- 0)
test tests::calls_std_instant_now                                       ... bench:          20 ns/iter (+/- 1)
test tests::calls_std_system_time_now                                   ... bench:          20 ns/iter (+/- 0)
test tests::it_creates_a_duration                                       ... bench:           1 ns/iter (+/- 0)

xeon server:
$ RUSTFLAGS="-C target-cpu=native" cargo bench
# ...
running 11 tests
test tests::test_raw ... ignored
test tests::test_reference ... ignored
test tests::test_source ... ignored
test calibrator::tests::calibrates_a_realtime_counter_clocksource       ... ignored
test calibrator::tests::cloning_a_clocksource                           ... bench:           1 ns/iter (+/- 0)
test calibrator::tests::mpsc_calibrator_hot_path_loop_overhead          ... bench:          35 ns/iter (+/- 0)
test calibrator::tests::triple_buffer_calibrator_hot_path_loop_overhead ... bench:          28 ns/iter (+/- 0)
test tests::calls_rdtsc_directly                                        ... bench:          14 ns/iter (+/- 0)
test tests::calls_std_instant_now                                       ... bench:          25 ns/iter (+/- 0)
test tests::calls_std_system_time_now                                   ... bench:          25 ns/iter (+/- 3)
test tests::it_creates_a_duration                                       ... bench:           1 ns/iter (+/- 0)

@jonathanstrong - apologies for not having a chance to respond sooner. Travel and moving have prevented me from having time to really sit and address this. Thanks for opening this issue and providing the data around the approach you've taken.
I would be curious to see if there is any substantial gain to be found on virtualized environments like AWS where the clock_gettime() calls tend to be particularly expensive. On baremetal, I would expect clocksource w/ rdtsc to be of less benefit overall.
I still feel that having the ability to re-calibrate in a non-blocking way would be of value - but I do have to wonder if there's any other approach we could take for this. Perhaps we could periodically make a call to both the reference and local clocks and use those to determine the new constants for conversion to reference timescale. This may require some revision to the current strategy of cloning the clocksource around in multi-threaded applications. We still wouldn't want different instances of clocksource within the app to provide differing results.
I feel this is going to require some more thought and experimentation. But do want to let you know that I appreciate what you've done in this experiment. If we find that your approach does have some strong benefit in the virtualized use-case it would be worth considering adding to the library. I think we can do better than what the library currently provides, but it may also be worth further consideration of different approaches to this. I'll try to carve some time to implement another approach to this and update with further thoughts when I have them.
Again, apologies for my slow response and thanks for raising this.

No worries about the delay! Totally understand. Thanks for your detailed thoughts on it - looking forward to your conclusions. Good call on virtualized environments, I'll try to test it out on some cloud servers I'm running in the next few days.
A couple additional thoughts:

Any event loop like this is going to be waiting on a channel or queue of some kind for new data. If the calibrated clock came over that main channel, like as part of an enum of possible messages, the marginal cost might be reduced because it's one less check on a concurrent queue. Possibly this could slow down the main channel though, for instance by requiring it to be a larger sized object. I'm not sure that approach would allow an ergonomic handle like the one I prototyped, either.

I realized that the structs holding the calibration thread need to store it as an Option<Arc<JoinHandle<()>>> rather than an Option<JoinHandle<()>>. The current design relies on the initial object lasting longer than any of its clones without any compile-time check this is the case. An example of the improved pattern would be (some pseudocode included):

struct A<T> {
    tx: Sender<Option<T>>,
    thread: Option<Arc<JoinHandle<()>>>
}

impl<T> A<T> {
    pub fn send(&self, t: T) -> Result<_, _> {
        self.tx.send(Some(t))
    }
}

impl<T> Drop for A<T> {
    fn drop(&mut self) {
        if let Some(arc) = self.thread.take() {
            if let Ok(thread) = Arc::try_unwrap(arc) {
                let _ = self.tx.send(None);
                let _ = thread.join();
            }
        }
    }
}


Wait time for creating moderately large TagSets is horrendous

see tags/parser.py
The problem is in tags.parser.save, as tags.parser.parse has trivial execution time thus far. i.e. for a large TagSet:
[PARSE] --- 0.0003917217254638672 seconds ---
[SAVE] --- 3.6412529945373535 seconds ---

If saving is nearly 4 orders of magnitude slower than parsing, then why not just save tags as plain text?

Because that would tank query performance.

NOT IF I DO SOMETHING CRAZY

Fixed in simplified-tags branch.


Doc enhancements

Working with @tbarnes-us to update and improve WKO docs. First pass at Home page, add contributing info to the Developer Guide, and added FAQ from the wiki to the doc FAQ (Answers to commonly asked newcomer questions).

Absolutely incorporated your comment/improvement. I think everything looks good, but we cannot merge this PR until after https://github.com/oracle/weblogic-kubernetes-operator/pull/2328 due to a link in here to the patching doc there. @rjeberhard


libvirt plugin

Native support for libvirt was initially requested by @gabrielecerami and the main reason behind it that the workaround of using vagrant uses by default virtualbox which is in conflict with libvirt. If the user happens to already use libvirt for something, they are likely to have problems.
While vagrant has a libvirt backend plugin, that one is experimental, not easy to install and without support for all platforms.
As libvirt has remoting support, we should be able to use libvirt directly.
Please note that that if someone wants to write this driver, it will have to be implemented as a plugin as we are currently transitioning all drivers to external plugins.

Please visit https://github.com/ansible-community/molecule-libvirt/issues for anything related to libvirt support.


[runserver_plus] autoreload django

Hello,
after updating Django to version 4.1.1 I noticed that using runserver_plus on the modification of python files, the autoreload works correctly but on the modification of html files if I do not restart the server,  by reloading the web page the changes are not displayed. If I use the Django runserver command everything works fine.
I think this all depended on this: https://docs.djangoproject.com/en/4.1/releases/4.1/#templates
I wait your feedback.
Thanks!

I'll second that.
TEMPLATES = [
    {
        'BACKEND': 'django.template.backends.django.DjangoTemplates',
        'OPTIONS': {
            'loaders': [(
                'django.template.loaders.app_directories.Loader',
                'django.template.loaders.filesystem.Loader',
            )],
           # etc...
    }
]

Copying a comment from a conversation on Twitter

You’re doing reloads somehow though I guess? If you can have your watcher trigger django.templates.autoreload.reset_loaders you’ll be good.

https://twitter.com/carltongibson/status/1588534399561510914?s=20&t=J-EAyK34GY0uHLP67Nqnxg

There is a pull request #1775 solving this issue. Can someone test it by installing the repo through git: git+https://github.com/foarsitter/django-extensions.git?
I tested it only with the stat reloader and works nicely inside a docker container.


Add hist_outliers to outliers notebook

🚀 Feature Request
Add examples of hist outliers to outliers notebook
Motivation
Guide for user on the use of all methods of searching for anomalies
Proposal
Add examples of hist outliers to outliers notebook
Test cases
No response
Alternatives
No response
Additional context
No response
Checklist

[X] Added feature request
[X] Added motivation
[X] Added proposal

Make notebook runs AFTER merge to master


fix for DeserializeList

Happens when Enumerable was provided as an Object property during serialization. On DeserializeList it cannot find any Generic types or Interfaces as type is System.Object. Also, type.IsArray of Object is false even if underlying type is actually an array, which leads to a different can of warms. See the tests and comments.
I updated tests as well, but because it is not possible to detect what was the original underlying type it is hard to Assert expected and actual types. Therefore, (ICollection) cast.
Could be a wrong using of the LiteDB altogether. Stumbled upon this one when tried to serialize-deserialize Dictionary<string,object> where one of objects was string[].

It is no more relevant to me as I found another way how to achieve what I need. Feel free to close it if you think it is just wrong.


Meaning of the acceleration detected by sensor/framelinacc

Hi!
When I learned how to add force-related sensors and collect data, I was confused about the meaning of the acceleration measured by sensor/framelinacc. According to the document,

This element creates a sensor that returns the 3D linear acceleration of the spatial frame of the object, in global coordinates.

I tried to add this sensor to the box object and check the exact value. Here is the whole manipulation process:
https://github.com/google-deepmind/mujoco/assets/72594017/e6b450d0-410a-4073-932d-9490126368ae
Then, I collect the acceleration data in the z-direction where the horizontal axis represents the timestep.

Before the object was grasped, the measured acceleration was approximately 9.8 and vertically upward. After the object was grabbed, the direction of the acceleration did not change but the value became smaller.
So, my confusions are

what does this acceleration (which can also be seen as a kind of force) represent?

If this sensor measures the acceleration acting on the frame of the object, why is the acceleration not equal to zero (considering gravity) before grasp?

Why does the acceleration become smaller after the grasp?

Thanks in advance!

Hello, I can try to give a preliminary answer for the first 2 questions
1: Have a look at the way the sensor calls mj_objectAcceleration to populate its values, which in turn processes values from data->cacc, which were calculated recursively from it's parent's cacc
2: Because the cacc calculation recurses back to the worldbody frame, and the worldbody frame is modelled as accelerating upwards to represent gravity. Yuval explained it in more detail here.
3: I'm not entirely sure. When the data was recorded, was the arm fully settled at the end?


Add headless HTML mode

Add option for HTML output that does not create <head> or <body>, and is wrapped in a <div>, so it can be embedded in another HTML page.

Implemented in isodoc. Will need to inherit it into specific standards as needed.


Bug in Note G solution

All odd-numbered Bernoulli numbers should be zero but:
>>> bernoulli(55)
(0, 1)
>>> bernoulli(57)
(7709321041217, 13260)

Also an issue with the even-numbered Bernoulli numbers past n=56.
>>> bernoulli(56)  # Agrees with Mathematica
(-2479392929313226753685415739663229, 870)
>>> bernoulli(58)  # Wrong. Should be:<PHONE_NUMBER>8880041862046775994036021/354
(13585864776982076303861046163101181164343439,<PHONE_NUMBER>0)

All is good. I was dividing two ints by mistake to get a regular float...
Switched to using scipy.special.comb to calculate binomial coefficients.


How to set a REPL for a filetype?

It seems like iron.nvim automatically sets up the REPL type or prompts for one. Is there a way to set your own default REPL for a filetype?

There is still no persistent way to do that.
Once you run IronPromptRepl, iron will make use of that even after the one you were prompted for is closed.
If that doesn't suffice, I'm planning to add more customization options on the future, but there are more urgent structurings that need to be made first.
Cheers

Hi,
This is now solved on the new Lua infrastructure.


Add package.json, use new numbered class names

Thanks for sharing your changes @wconnorwalsh! I just merged them in here and released v2.0.0.


.NET DI differentiation using Keyed Services

As of .NET 8 you can now register services using keys.
services.AddKeyedSingleton<IMessageWriter, MemoryMessageWriter>("memory");
services.AddKeyedSingleton<IMessageWriter, QueueMessageWriter>("queue");

public class ExampleService
{
    public ExampleService(
        [FromKeyedServices("queue")] IMessageWriter writer)
    {
        // Omitted for brevity...
    }
}

Please consider allowing .NET DI to have the same function as autofac

Thank you for your suggestion. I tried this feature when .net 8 first supported it. Because .NET DI cannot pass constant parameters to the constructor, such as whether to enable read-write separation, I finally decided to continue using autofac.


Feature 590

Added Email confirmation before login

HI @devarshad - thanks for this PR, I will check it - but can you check failed tests?

Thanks for your PR, I will solve this suggestion in PR #631 👍


How to add additional scrape config in GCP Managed Prometheus?

Hi folks, congratulation on this awesome project.
I'm working on GKE with Managed Prometheus. I was able to deploy the k8spacket with helm and apparently, it's working properly.
2023/01/03 10:39:32 [nodegraph plugin] Connection: src=<IP_ADDRESS> srcName=N/A srcPort=38732 srcNS= dst=<IP_ADDRESS> dstName=pod.prometheus-6d4bdcb6f7-bdbgn dstPort=9090 dstNS=gmp-system closed=true bytesSent=111 bytesReceived=168 duration=1.9404e-05
2023/01/03 10:39:32 [nodegraph plugin] Connection: src=<IP_ADDRESS> srcName=N/A srcPort=38730 srcNS= dst=<IP_ADDRESS> dstName=pod.prometheus-6d4bdcb6f7-bdbgn dstPort=9090 dstNS=gmp-system closed=true bytesSent=109 bytesReceived=166 duration=0.000105884
2023/01/03 10:39:35 [nodegraph plugin] Connection: src=<IP_ADDRESS> srcName=N/A srcPort=45910 srcNS= dst=<IP_ADDRESS> dstName=pod.grafana-deployment-846c46f9f6-6p7hw dstPort=3000 dstNS=gmp-system closed=true bytesSent=113 bytesReceived=357 duration=1.5131e-05
2023/01/03 10:39:35 [nodegraph plugin] Connection: src=<IP_ADDRESS> srcName=N/A srcPort=45908 srcNS= dst=<IP_ADDRESS> dstName=pod.grafana-deployment-846c46f9f6-6p7hw dstPort=3000 dstNS=gmp-system closed=true bytesSent=113 bytesReceived=357 duration=0.000101168

Unfortunately, after the data sources have been configured properly, then the Dashboards don't show anything.
I think I have to configure the additional scrape config in Managed Prometheus, but I am not able to do it.
Do you know how I can do it? Thanks in advance

DASHBOARD

@marandalucas
I assume the problem is connected to the wrong data source selected inside the Panel. Go to the Edit page:

and check the selected Data source:

Should be selected node-graph-plugin in your case (as it is in the explore screenshot)
The Query string should be filled by the value namespace=$namespace&include=$include&exclude=$exclude&stats-type=$statstype

Hi @k8spacket
You are right! Now it's working. The panel was using Prometheus Data Source (Default).
This is my configuration. Apparently, the data sources should be configured automatically based on the JSON below:
"type": "hamedkarbasi93-nodegraphapi-datasource"
Is there something I missed? Thanks!
---
apiVersion: integreatly.org/v1alpha1
kind: GrafanaDashboard
metadata:
  name: k8spacket-node-graph-dashboard
  namespace: gmp-system
  labels:
    app: grafana
spec:
  json:
    ""
  configMapRef:
    name: k8spacket-node-graph-dashboard
    key: k8spacket-node-graph-dashboard
---
apiVersion: v1
kind: ConfigMap
metadata:
  name: k8spacket-node-graph-dashboard
  namespace: gmp-system
  labels:
    grafana_dashboard: "1"
    app.kubernetes.io/name: grafana
    dashboard-provider: default
data:
  k8spacket-node-graph-dashboard: |-
    {
      "annotations": {
        "list": [
          {
            "builtIn": 1,
            "datasource": "-- Grafana --",
            "enable": true,
            "hide": true,
            "iconColor": "rgba(0, 211, 255, 1)",
            "name": "Annotations & Alerts",
            "target": {
              "limit": 100,
              "matchAny": false,
              "tags": [],
              "type": "dashboard"
            },
            "type": "dashboard"
          }
        ]
      },
      "editable": true,
      "fiscalYearStartMonth": 0,
      "graphTooltip": 0,
      "id": 3,
      "iteration":<PHONE_NUMBER>825,
      "links": [],
      "liveNow": false,
      "panels": [
        {
          "datasource": {
            "type": "hamedkarbasi93-nodegraphapi-datasource",
            "uid": "PC93AC6A0E760905D"
          },
          "gridPos": {
            "h": 31,
            "w": 24,
            "x": 0,
            "y": 0
          },
          "id": 2,
          "targets": [
            {
              "datasource": {
                "type": "hamedkarbasi93-nodegraphapi-datasource",
                "uid": "PC93AC6A0E760905D"
              },
              "queryText": "namespace=$namespace&include=$include&exclude=$exclude&stats-type=$statstype",
              "refId": "A"
            }
          ],
          "title": "Panel Title",
          "type": "nodeGraph"
        }
      ],
      "refresh": "",
      "schemaVersion": 35,
      "style": "dark",
      "tags": [],
      "templating": {
        "list": [
          {
            "current": {
              "selected": true,
              "text": "connection",
              "value": "connection"
            },
            "hide": 0,
            "includeAll": false,
            "label": "graph mode",
            "multi": false,
            "name": "statstype",
            "options": [
              {
                "selected": true,
                "text": "connection",
                "value": "connection"
              },
              {
                "selected": false,
                "text": "bytes",
                "value": "bytes"
              },
              {
                "selected": false,
                "text": "duration",
                "value": "duration"
              }
            ],
            "query": "connection,bytes,duration",
            "queryValue": "",
            "skipUrlSync": false,
            "type": "custom"
          },
          {
            "current": {
              "selected": false,
              "text": "",
              "value": ""
            },
            "description": "",
            "hide": 0,
            "label": "namespace (regexp)",
            "name": "namespace",
            "options": [
              {
                "selected": true,
                "text": "",
                "value": ""
              }
            ],
            "query": "",
            "skipUrlSync": false,
            "type": "textbox"
          },
          {
            "current": {
              "selected": false,
              "text": "",
              "value": ""
            },
            "hide": 0,
            "label": "include name (regexp)",
            "name": "include",
            "options": [
              {
                "selected": true,
                "text": "",
                "value": ""
              }
            ],
            "query": "",
            "skipUrlSync": false,
            "type": "textbox"
          },
          {
            "current": {
              "selected": false,
              "text": "",
              "value": ""
            },
            "hide": 0,
            "label": "exclude name (regexp)",
            "name": "exclude",
            "options": [
              {
                "selected": true,
                "text": "",
                "value": ""
              }
            ],
            "query": "",
            "skipUrlSync": false,
            "type": "textbox"
          }
        ]
      },
      "time": {
        "from": "now-6h",
        "to": "now"
      },
      "timepicker": {},
      "timezone": "",
      "title": "k8spacket - node graph",
      "weekStart": ""
    }

I had to update the json the following values

Hi @marandalucas
Thanks for the information. I'll check if this uid is even necessary for dashboard definition files. Information about the type may be good enough.

Hi @marandalucas
Fixed in PR #21
Thanks.


Searching for Sciety.org in Google gives 'no information available' message

Update robots.txt

[ ] open up for all
[ ] stop search being indexed
[ ] site-verification
[ ] page-title ('titleofpage | Sciety' except for homepage)

[ ] articles ('the-whole-title | Sciety')(go with consistency, see what it looks like, maybe experiments later)
[ ] ECs ('name-of-community | Sciety')
[ ] homepage ('Sciety: where research is evaluated and curated by the communities you trust. ')
[ ] users ('twitter-display-name | Sciety')
[ ] search('Search | Sciety')
[ ] about('About | Sciety')
[ ] terms and privacy ('the-h1-content | Sciety')

~metadata~
[ ] retrigger google spider
~build sitemap~

https://www.google.com/webmasters/tools/robots-testing-tool may help (requires a verified property)

We already have a TXT google-site-verification entry, may have been setup for GMail. Think users will need to be granted access /cc @BlueReZZ

We already have a TXT google-site-verification entry, may have been setup for GMail. Think users will need to be granted access (we can overwrite it, but unsure if that'll have side effects) /cc @BlueReZZ

It looks like the verification code is related to me and the domain, as the same one worked for verifying the domain in the "webmaster central" and G Suite verification paths.
Therefore I have legitimate access to it in the search console. I also found a way to add users so added @thewilkybarkid and we can see what happens tomorrow.

Tried a live check using the google bot on the homepage but it's not seeing the updated robots.txt There is an issue with the requesting of reindexing currently so maybe the page isn't working as expected. I learned more here: https://support.google.com/webmasters/answer/9012289#live_indexable


To Reproduce
I get this when running the code from https://novel.sh/docs/introduction in an Electron app.
Expected behavior
I would expect there to not be an exception.
Screenshots
See above.
Desktop (please complete the following information):

OS: MacOS
Browser: Electron

Additional context
Thank you!

I had the exact same issue.


Derive the JSON omitempty annotation directly from the property type

It'd be good to have the rationale on the PR so we can see it easily later.

Due to ARM requirements, we actually need the omitempty annotation to be derived from the optional/mandatory nature of the property, it can't be decoupled. Abandoning this PR.


Updated workflows

#1047  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @CatChen and the rest of your teammates on  Graphite


Using stable/redis as LRU cache

How can I edit the .conf in the docker image in order to set the eviction policy for redis so that it is only used as an LRU cache?

Hi @34code, thanks for opening an issue, though we're able to provide support for problems with charts in the general sense (failing to install, Helm issues, etc.).


Error certificate Letsencrypt

Environment Information

Device Name: Samsung Galaxy S8+
OS Version: Android 8
Mattermost App Version: 1.22.1
Mattermost Server Version: 5.14.1

Expected behavior
We are testing Mattermost in a server where we installed another letsencrypt ceritficate and exist an apache running in 443 port.
The Mattermost is running on port 8065 and we set the .key file and .crt file from webgui, the option "Use Let's Encrypt" is disabled because is not running on port 80/443.
The web access with TLS working fine, desktop application for Windows working fine too and iOS application, but for Android we have a problem with certificate:
{"level":"error","ts":1567177896.6155794,"caller":"http/server.go:1794","msg":"http: TLS handshake error from X.X.X.X:49000: remote error: tls: unknown certificate","source":"httpserver"}
But the strange thing is that if I follow the next steps, I bypass the error and I can login into Mattermost but when I change the network we are out again:

Trying with https://myserver.com:8065 -> Error
Trying with https://mattermost.com -> Error
Trying with https://myserver.com:8065 -> Success

We tested with two android mobile.

Hi @miguellara999, this doc might help: https://docs.mattermost.com/mobile/mobile-troubleshoot.html#i-keep-getting-a-message-cannot-connect-to-the-server-please-check-your-server-url-and-internet-connection.

Android apps are still unavailable. Why not cure SSL failures?

Going to close this issue as it hasn’t had any recent activity


On zabbix 6.2 I'm seeing a lot of Zfs dataset $1 $2 with values but with the name $1 $2

I think that the idea is to name it after the real name of the dataset but instead it does it with "Zfs dataset $1 $2"

I see the same the $1 and $2 are not substitued.

I have resolved this issue and also added Zpool fragmentation monitoring. I am not a developer (never done a PR) but happy to share my changes if on interest.

Yes, your code changes would be very welcome.

I created a PR. Never done this before so hope it is correct.

This might be related to this change.

Don't mind me asking but why hasn't that fix been merged and the issue closed?
I am running 6.4 in containers with 2 hosts running zfs and I am running into the same issue.
I think I manually applied the fix to those hosts but the graphs are slow and not loading at the moment (not sure if its related to this).

I have also noticed that this ZFS template doesn't seem to work under Zabbix 6.0.
I am going to try applying https://github.com/Cosium/zabbix_zfs-on-linux/pull/41 to see if that brings it back to life.

The above PR was no help for me so I've opened this ticket.
https://github.com/Cosium/zabbix_zfs-on-linux/issues/47
If anyone knows how I fix the pool health monitoring under Zabbix 6.0 please let me know, thanks!

these were deprecated after version 6. I've just renamed them to corresponding values and it works.
The template needs some maintenance care.


cannot find arrayFrom()

i am sorry it was my mistake @signaflo

No problem @MuhYusuf93 , and sorry it took me so long to get back. I've been insanely busy in other areas of life. Is everything working out fine for you now?

i have bad english, i hope you will be fine with that

i think you are missing getter n setter for ArimaParameters.java, for example setMean and getDriftParScale() need it.
where is constructor in ArimaParameters.java ? i delete all slash from here to get constructor but parameters object in fromCoefficients method need double
i think you have little strange code in RandomWalk.java in here why do you create forecast object but return function doesn't need it?

best regards -

i'm studying about Arima to get a bachelor's degree and your git is most clear and readable ARIMA code in github. thanks for your code that makes me understand about ARIMA. you're genius. i love you


transfer-encoding: chunked vs content-length

https://github.com/mozilla/pdf.js/pull/2719 implemented chunk loading, it requests the server to return response with content-length. while for tomcat apache server, which uses the http 1.1 and use transfrer-encoding in place of content-length.
Is there a special setting to support transfer-encoding "chunked"? or is there a other way to implement partial content loading for large pdf document?

PDF.js uses HTTP range requests to "ask" server for data need to display particular page. And it does not matter if transfer-encoding is used -- the received data is handled by browser's XHR so it shall not be an issue. However it is PDF.js must know the total length if the file to accurately estimate size of the document. If server does not support range requests. PDF.js will try to load data progressively, but that's currently supported by Firefox's XHR only (moz-chunked-arraybuffer responseType). See #5319 for details.
There are not many PDFs that are linearized (web optimized) -- non-linerized PDFs contain important data at the end of the file, so just using streaming/loading progressively will not help. Closing as answered.


no work in 1.0.1 version

Thank you for providing this cool stuff to help replace string easily.
I found it worked when I first install on version 1.0.0, the version now is 1.0.1 but I found it doesn't work like before. I saw the change log for 1.0.1 "Now it doesn't changing anything, if case was equal in the first place - prevents some annoying false positives.", however, I am not clear what it changes about.
How do I make it work?

Damn, that was embarassing :). Please install 1.0.2, it should be fixed

Many thanks :)
It rocks again!!! Cool~


Setup fails

Hi,
Thank you for your great effort to create this repository.
I cannot setup cortex. I will encounter the following error:
ERROR: Command errored out with exit status 1:
command: /home/sina/.conda/envs/pytorch/bin/python -c 'import sys, setuptools, tokenize; sys.argv[0] = '"'"'/tmp/pip-req-build-0y42isk4/setup.py'"'"'; file='"'"'/tmp/pip-req-build-0y42isk4/setup.py'"'"';f=getattr(tokenize, '"'"'open'"'"', open)(file);code=f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, file, '"'"'exec'"'"'))' egg_info --egg-base pip-egg-info
cwd: /tmp/pip-req-build-0y42isk4/
Complete output (24 lines):
Traceback (most recent call last):
File "/home/sina/.conda/envs/pytorch/lib/python3.6/site-packages/setuptools/dist.py", line 220, in assert_string_list
assert isinstance(value, (list, tuple))
AssertionError
During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/tmp/pip-req-build-0y42isk4/setup.py", line 28, in <module>
    zip_safe=False)
  File "/home/sina/.conda/envs/pytorch/lib/python3.6/site-packages/setuptools/__init__.py", line 144, in setup
    _install_setup_requires(attrs)
  File "/home/sina/.conda/envs/pytorch/lib/python3.6/site-packages/setuptools/__init__.py", line 133, in _install_setup_requires
    (k, v) for k, v in attrs.items()
  File "/home/sina/.conda/envs/pytorch/lib/python3.6/site-packages/setuptools/dist.py", line 446, in __init__
    k: v for k, v in attrs.items()
  File "/home/sina/.conda/envs/pytorch/lib/python3.6/distutils/dist.py", line 281, in __init__
    self.finalize_options()
  File "/home/sina/.conda/envs/pytorch/lib/python3.6/site-packages/setuptools/dist.py", line 734, in finalize_options
    ep.load()(self, ep.name, value)
  File "/home/sina/.conda/envs/pytorch/lib/python3.6/site-packages/setuptools/dist.py", line 225, in assert_string_list
    "%r must be a list of strings (got %r)" % (attr, value)
distutils.errors.DistutilsSetupError: 'dependency_links' must be a list of strings (got {'git+https://github.com/facebookresearch/visdom.git'})
----------------------------------------

ERROR: Command errored out with exit status 1: python setup.py egg_info Check the logs for full command output.
Any hint?
Thank you

From looking at the Python Package documentation, there appears to be a small error in the setup.py file for Cortex where they use a dictionary {} instead of a list [].
To fix it I simply went into the setup.py file and changed:
dependency_links={'git+https://github.com/facebookresearch/visdom.git'},
To (the 'git+' is unnecessary so I dropped it):
dependency_links=['https://github.com/facebookresearch/visdom.git'],

wow, I have met that problem. Your answer is very very useful.Thank you very much

From looking at the Python Package documentation, there appears to be a small error in the setup.py file for Cortex where they use a dictionary {} instead of a list [].
To fix it I simply went into the setup.py file and changed:
dependency_links={'git+https://github.com/facebookresearch/visdom.git'},
To (the 'git+' is unnecessary so I dropped it):
dependency_links=['https://github.com/facebookresearch/visdom.git'],

wow, I have met that problem. Your answer is very very useful.Thank you very much

wow, I have met that problem. Your answer is very very useful.Thank you very much

From looking at the Python Package documentation, there appears to be a small error in the setup.py file for Cortex where they use a dictionary {} instead of a list [].
To fix it I simply went into the setup.py file and changed:
dependency_links={'git+https://github.com/facebookresearch/visdom.git'},
To (the 'git+' is unnecessary so I dropped it):
dependency_links=['https://github.com/facebookresearch/visdom.git'],

wow, I have met that problem. Your answer is very very useful.Thank you very much

Thank you, @DEUCE1957.
Can you create a pull request? I think it may help many folks if the owner agrees with it and approves it.

i agree

Thank you, @DEUCE1957.
Can you create a pull request? I think it may help many folks if the owner agrees with it and approves it.

i agree

From looking at the Python Package documentation, there appears to be a small error in the setup.py file for Cortex where they use a dictionary {} instead of a list [].
To fix it I simply went into the setup.py file and changed:
dependency_links={'git+https://github.com/facebookresearch/visdom.git'},
To (the 'git+' is unnecessary so I dropped it):
dependency_links=['https://github.com/facebookresearch/visdom.git'],

I wonder if a pull request has been created for this one. I recently faced this exact same issue and the suggested change worked.

There is indeed a pull request: https://github.com/rdevon/cortex/pull/210

From looking at the Python Package documentation, there appears to be a small error in the setup.py file for Cortex where they use a dictionary {} instead of a list [].
To fix it I simply went into the setup.py file and changed: dependency_links={'git+https://github.com/facebookresearch/visdom.git'}, To (the 'git+' is unnecessary so I dropped it): dependency_links=['https://github.com/facebookresearch/visdom.git'],

hello，i have a promblem about DIM....how can i solve?
Traceback (most recent call last):
File "scripts/main.py", line 71, in
run(controller)
File "/root/anaconda3/envs/pytorch_2.2.1/lib/python3.8/site-packages/cortex/main.py", line 39, in run
model.build()
File "/root/anaconda3/envs/pytorch_2.2.1/lib/python3.8/site-packages/cortex/_lib/models.py", line 417, in wrapped
return fn(*args, **kwargs)
File "/root/anaconda3/envs/pytorch_2.2.1/lib/python3.8/site-packages/cortex_DIM/models/controller.py", line 216, in build
model.build(self.encoder, copy.deepcopy(config))
File "/root/anaconda3/envs/pytorch_2.2.1/lib/python3.8/site-packages/cortex/_lib/models.py", line 417, in wrapped
return fn(*args, **kwargs)
File "/root/anaconda3/envs/pytorch_2.2.1/lib/python3.8/site-packages/cortex_DIM/evaluation_models/classification_eval.py", line 49, in build
X = self.inputs('data.images')
File "/root/anaconda3/envs/pytorch_2.2.1/lib/python3.8/site-packages/cortex_DIM/models/controller.py", line 140, in get_inputs
raise KeyError(f"Input key '{key}' not found in inputs dictionary.")
KeyError: "Input key 'data.images' not found in inputs dictionary."
thanks!!


Paginator can't select page

Hello,
im using Cycle ORM natively. And I have 2 problems with paginator.
I described problem at comments.
    $select = $r->select()->where('status',1)->orderBy('id', 'DESC');;
    echo $select->count(); //8 records
    $paginator = new \Spiral\Pagination\Paginator(3);//set 3 records per page
    $paginator->paginate($select);
    $paginator->withPage(2); //select 2 page

    $jobList = $select->fetchAll(); // First problem, selecting first page instead of second
    echo $paginator->countPages(); // Second problem, countPages() = 1, should be 3

Packages version:
cycle/annotated               v2.0.4
cycle/orm                     v1.2.4
cycle/schema-builder          v1.1.2
spiral/pagination             v2.2.2
spiral/core                   v1.4.4
spiral/database               v2.7.11
spiral/logger                 v1.2.1
spiral/pagination             v2.2.2
spiral/tokenizer   v2.1.8

Installed by:
    "cycle/orm": "^1.2",
    "cycle/annotated": "^2.0",

PHP 7.4.3
Is that code is correct? Or its a bug?
Regards

Hi, paginator is immutable object:
$p->withPage(2)->paginate($select);

There should be a little better documentation for pagination so far.
https://cycle-orm.dev/docs/advanced-pagination

Shame on us. I would also recommend use data grids from spiral, much more powerful instrument.

updated


Revert "xvm: add  llvm backend support (#326)"

This reverts commit 5439bf8c4bf524098d7dc64b4f55b88daaf202c7.
Description
revert llvm backend support of xvm
Fixes # (issue)
Type of change
Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)

Codecov Report

Merging #328 (04e1ff6) into master (5439bf8) will decrease coverage by 0.08%.
The diff coverage is 20.00%.

@@            Coverage Diff             @@
##           master     #328      +/-   ##
==========================================
- Coverage   45.81%   45.73%   -0.09%
==========================================
  Files         140      138       -2
  Lines       12361    12291      -70
==========================================
- Hits         5663     5621      -42
+ Misses       5539     5517      -22
+ Partials     1159     1153       -6

Impacted Files
Coverage Δ

bcs/contract/xvm/aot_creator.go
5.35% <0.00%> (-1.89%)
:arrow_down:

bcs/contract/xvm/builtin_resolver.go
0.00% <ø> (ø)

bcs/contract/xvm/instance.go
0.00% <0.00%> (ø)

bcs/contract/xvm/interp_creator.go
4.16% <0.00%> (-12.50%)
:arrow_down:

bcs/contract/xvm/resolver.go
0.00% <ø> (ø)

bcs/contract/xvm/code_manager.go
66.36% <100.00%> (-5.71%)
:arrow_down:

bcs/consensus/tdpos/common.go
52.17% <0.00%> (-2.90%)
:arrow_down:

bcs/consensus/tdpos/tdpos.go
46.94% <0.00%> (-2.35%)
:arrow_down:

bcs/consensus/pow/pow.go
41.82% <0.00%> (-1.15%)
:arrow_down:

... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5439bf8...04e1ff6. Read the comment docs.

Codecov Report

Merging #328 (04e1ff6) into master (5439bf8) will increase coverage by 0.04%.
The diff coverage is 20.00%.

@@            Coverage Diff             @@
##           master     #328      +/-   ##
==========================================
+ Coverage   45.81%   45.86%   +0.04%
==========================================
  Files         140      138       -2
  Lines       12361    12291      -70
==========================================
- Hits         5663     5637      -26
+ Misses       5539     5504      -35
+ Partials     1159     1150       -9

Impacted Files
Coverage Δ

bcs/contract/xvm/aot_creator.go
5.35% <0.00%> (-1.89%)
:arrow_down:

bcs/contract/xvm/builtin_resolver.go
0.00% <ø> (ø)

bcs/contract/xvm/instance.go
0.00% <0.00%> (ø)

bcs/contract/xvm/interp_creator.go
4.16% <0.00%> (-12.50%)
:arrow_down:

bcs/contract/xvm/resolver.go
0.00% <ø> (ø)

bcs/contract/xvm/code_manager.go
66.36% <100.00%> (-5.71%)
:arrow_down:

bcs/consensus/tdpos/common.go
52.17% <0.00%> (-2.90%)
:arrow_down:

bcs/consensus/tdpos/tdpos.go
46.94% <0.00%> (-2.35%)
:arrow_down:

kernel/consensus/base/driver/chained-bft/smr.go
41.33% <0.00%> (+0.74%)
:arrow_up:

... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5439bf8...04e1ff6. Read the comment docs.


Remove xml report consolidation.

I realize this is going to be a bit controversial but I wanted to get the discussion started anyway.
IMHO the report consolidation as it currently stands should be removed. Reasons for that being:

It does not work if the root project does not have any sources (#1768).
It does not work with source set tasks such as detektMain
It makes the code inside the Detekt tasks somewhat clunky and harder to maintain.
I believe there is a workaround by running detekt in the root project only with the root folder as the input.

I realize that this was heavily requested feature, but the way it is implemented simply introduces more problems than benefits.
Reverts #1329

Thank you for making me take another look. While most of the unreverted changes were refactorings in test code and formatting there was one more thing that could be removed. With this the detekt task does not have to depend on the detekt task of its child projects.

Codecov Report

Merging #1774 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #1774   +/-   ##
=========================================
  Coverage     79.82%   79.82%
  Complexity     1937     1937
=========================================
  Files           324      324
  Lines          5472     5472
  Branches       1009     1009
=========================================
  Hits           4368     4368
  Misses          581      581
  Partials        523      523

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f98ccac...0e87e5f. Read the comment docs.

I also appreciate your work and investigations on this one!
With this blocker out, the way is open for 1.0 and starting 'normal' versioning.
We can deliver this feature better in a minor 1.X update later :)


support this UA ?

Aweme 8.2.0 rv:82017 (iPhone6,2; iOS 12.4; zh_CN) Cronet

It looks like it doesn't parse it right. What is it?


Run licensify data sync daily instead of weekly.

We're doing some work to improve these apps and
having more up to date data will help that process.

Looks correct to me :+1:


unique_identifier: 1.0.6-1 in 'noetic/distribution.yaml' [bloom]

Increasing version of package(s) in repository unique_identifier to 1.0.6-1:

upstream repository: https://github.com/ros-geographic-info/unique_identifier.git
release repository: https://github.com/ros-geographic-info/unique_identifier-release.git
distro file: noetic/distribution.yaml
bloom version: 0.9.0
previous version for package: null

unique_id

No changes

unique_identifier

No changes

uuid_msgs

No changes

Once this is in - I can release geographic_info as well.


Check test suite for any gaps - Target Version 0.2.0b2

We have 100% coverage with duplicated tests to make sure that all the paths from the deprecated functionality is run as well.
However, I'm not completely certain we're fully testing the environment variable grabbing, so we need to write tests for ALL of that as well.

[x] Check if the environment variable grabbers are actually fully tested
[x] If not, write more unit tests - make sure every single one is checked

There was a gap but that's now been resolved - this issue can be closed with the 0.2.0b2 update.


Program crashing because of server module (through multicastdns) throwing EADDRNOTAVAIL

Hello,
Multicastdns from Server module (mdns-server.js) is throwing an error (EADDRNOTAVAIL ) coming from inner function setMulticastInterface as specified in dgram's documentation
https://nodejs.org/api/dgram.html#dgram_call_results
I can't find a way to catch it from my own code except with process.on('uncaughtExcetion') which i find pretty ugly
Is there a way to catch this exception properly ? Am i missing something here or is there no better way ?

Is this a duplicate of #18?

Is this a duplicate of #18?

Hello Thom-nic ! Ty for your time
The scenario described in #18 is not the same as the one i encountered
I met the issue of handling this exception while trying to publish twice the same service name on the same network from the same computer (it happens when starting 2 instances of our program)
I have solutions to address my particular scenario, but the issue I wanted to point out was that the exception thrown does not seem to be catchable (unless I am missing something)

Either way, I'm going to suggest for anyone using this library in a production environment either migrate to bonjour-service or @homebridge/ciao.  This project is unmaintained, it has not seen a single commit in 6 years (!)


Update tip using F5 to use Ctrl-F5

Pressing F5 with add-in in focus will not reload from source, only from cache.
Pressing Ctrl-F5 will reload from source disregarding cache.
I assume hard reload is the most likely needed scenario, as such I propose replacing F5 with Ctrl-F5.
If this assumption is incorrect or not warranted, adding a sentence describing Ctrl-F5 might be a better solution.

Docs Build status updates of commit 3737e02:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/testing/clear-cache.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Hi @larsts,
Thanks for submitting this PR. This is a good tip. We are validating that the information is consistent across all the supported Webviews and will respond again soon.

Docs Build status updates of commit 0c4031d:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/testing/clear-cache.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Allocation show schemes in measurable-ratings-panel

#4007

This pull request introduces 1 alert when merging edb46bdc7aae5e2113ce322c1f6c54b7117faebb into 4acec124bf7a01492a12c5894695bbf5c21adfc3 - view on LGTM.com
new alerts:

1 for Unused variable, import, function or class

Comment posted by LGTM.com


Update the PeerDependency to Angular 4

As another issue (https://github.com/ngrx/effects/issues/120) stated, this lib works with Angular 4. Would you please update the PeerDependency accordingly? Thank you.

Fixed via https://github.com/ngrx/effects/pull/142


wrong behavior detected by @diandr6 94% brightness

In #22 the user @diandr6 detected wrong behavior, she explain it :

The lamp works and connects, but the white color does not behave as usual. For the interface, the lamp is always at 94% brightness (even if the HA interface is set to 1%) and the selected color mode. Warm white and cool white modes do not work correctly. Warm white = 10,000K and cool white = 1,000,000K when the actual range is 3000K to 6500K. When the lamp is turned on in white mode, the interface is displayed as in color mode (blue or light yellow) and turning off / on the lamp switches it to color mode.

And with video

I think the video will make it clearer what's going on.
https://youtu.be/AtCGdVATMDE

You can actually set the color temp range in kelvins using the light class and configure a range for each light, it will display the correct range in HA and limit you to those, have done something similar in https://github.com/raulgbcr/lednetwf_ble/blob/main/light.py which is heavily based on your integration code!

Thnks @raulgbcr i implement it when have time.
I redirect my support features to your repo when the strip is supported for your code.

This should fix it: https://github.com/dave-code-ruiz/elkbledom/pull/41


Split Roboto font definitions to multiple scripts

This patch adds back all the different Roboto variations and splits the font definitions into multiple files to avoid issues with Roblox's replication breaking.
I was also working on adding Latin accents to the font set. I got all the atlases uploaded already, but there is a bug in Roblox which is preventing me from working on it further (Anaminus/roblox-bug-tracker#794)

Also, Roboto.part.*.lua are all ModuleScripts inside the main Roboto ModuleScript.


feat(devcontainer): Adding default configuration + Fix Make install

Could you please add some documentation on how to use this for any new comer (even just some links) please?


Update .editorconfig

Space is already the default indent style.

Builds seem unrelated. What's up?


Navigation Agent 3D "Target Desired Distance" Ignored using _integrate_forces() function

Godot version
3.5
System information
Windows 10 GLES3 AMD Radeon HD 8730M
Issue description
When using the Navigation Agent, target desired distance property is being ignored when using the _integrate_forces function
Steps to reproduce

Create a RigidBody node
Add a Collision Shape node as children
Add Navigation Agent as children of the rigidbody
Add a Script to the RigidBody node
Paste this into the script

func _ready() -> void:
	_get_follow_target_position()

func _get_follow_target_position():
	$NavigationAgent.set_target_location([SOMENODE].global_transform.origin)

func _integrate_forces(state: PhysicsDirectBodyState) -> void:
	_get_follow_target_position()
	if $NavigationAgent.is_target_reached():
		print("forces reached")

func _physics_process(delta: float) -> void:
	if $NavigationAgent.is_target_reached():
		print("process reached")

Play
It should only print "process reached"

Minimal reproduction project
No response

@KC098 Please upload a minimal reproduction project to make this easier to troubleshoot.
Related to https://github.com/godotengine/godot/issues/62532. Have you tried adjusting Target Desired Distance in various ways?

No it is not ignored.
If you use NavigationAgent.set_target_location() you are requesting a path update which resets the internal state e.g. sets target_reached = false which makes NavigationAgent.is_target_reached() return false.

Oh I see, thanks for clarifying. Also, I don't think the documentation states that. Something along the lines of "Note: when calling '_set_target_location()' inside a '_integrate_forces()' will cause the path to reset wich makes the 'is_target_reach()' always return false. Instead, call it using '_physics_process()'."

Reopening, as this still needs to be documented.

@Calinou  What do you want to document? The documentation has it as a stick note.

Note: After set_target_location() is used it is required to use the get_next_location() function once every physics frame to update the internal path logic of the NavigationAgent.

and the function set_target_location() states:

This will clear the current navigation path.

I don't think we need to state every single interal value that gets reset on a navigation path clear.


Improve custom routes docs

It is possible to add custom routes in multiple ways with Nuxt 3 but docs could be improved. (Routing or pages directory)
Ref: https://github.com/nuxt/framework/discussions/7211?converting=1#discussioncomment-3545577

@danielroe I think I could do this :)

Amazing! ❤

@SuleymanQ you should be able to do that by passing a RouterConfig in your nuxt config (routes method):  https://nuxt.com/docs/guide/directory-structure/pages#custom-routes


trying to get the BLOB_READ_WRITE_TOKEN but inn vercel its not showing option for connect with blob

Vercel Blob is still in beta – feel free to DM me on Twitter for access!


Bug in the member's filter

After collapsing the filter and reopening it. If the page is showing non-member contributors, the checkbox will appear unchecked, which will cause confusion to users as the page is still showing contributors who are not members with their box being unchecked at the same time (see attached screenshot).
Once checked, the checkbox should stay so unless the user unchecks it.

@itsmohmans please follow up on this task


starting up a PR so luke can see my content ;)

Using this to get the first draft of the page content added.

:cool:


Set up a github action using hatch to release to PyPI

Automate the release to PyPI using hatch.
To approach this issue, consult the hatch documentation and recommended GitHub action.
This task will finish and close #82.

yay thanks @willingc i have this workflow that publishes using setuptools_Scm (which hatch is using under the hood).
So i think the big changes for this are

[x] setup a trusted workflow in pypi (this is just easier to maintain than worrying about tokens and such) and preferred.
[ ] switch the build step to hatch build rather than using pypa build (pr opening in just a few)


Module Incompatibilities

[x] Forien's Quest Log
[x] Dungeondraft Import
[x] Onejournal
[ ] Custom Journal
[ ] Tidy UI
[x] Calendar

I'm having a few issues with GM Notes, where the notes visualization doesn't have a proper background for readability. Would it be possible to add support to it to have the same styling as regular journal pages?

Appears to have similar behaviour on OneJournal, oddly...

i ahve the same problem in a whisper module

On version 3.0, the 'show text', 'show image', and 'close' buttons for journal entries occlude the MINDMAP button from Moerill's Mindmap, making it impossible to open.

If an existing entry is a mindmap, it is impossible to close as the 'close' button does not exist


update the README file

As a developer
I need a clear description of a micro-service  we are developing
So that coming back to work on this micro-service I will be up to date with what is happening
Details and Assumptions

list the high level overview of what we are working on

Acceptance Criteria
Given the valid repo
When I want to be up to date with the repo's current state
Then README file would be a great way of documenting the progress and global vision of our micro-service

From the homework assignment: Update the README.md file and make sure that you give instructions on what calls are available and what inputs they expect and how to run and test your code so that users will know how it works.


eureka REST endpoint is not generally correct

return 'http://' + this.config.eureka.host + ':' + this.config.eureka.port + '/eureka/v2/apps/';
in suffix: '/eureka/v2/apps/', this is not generally how that done, prefix 'eureka' for the path, depends on deployment or might be missing at all, so this has to be configured.

@maksimlikharev This should now be available in version 1.6.0 of this module. Just upgrade your dependency version and you should be good to go. Just set eureka.servicePath in your configuration.


Improve Send & Receive Payments tutorial

What problem does your feature solve?
Add more explicit guidance to the Send and Receive Payments tutorial (https://developers.stellar.org/docs/tutorials/send-and-receive-payments) that helps users understand how to list Stellar assets on exchanges
@JakeUrban feel free to add more information

@JakeUrban could you add more context please

We are frequently asked to provide all the information required for an exchange to list a Stellar asset like USDC.
The tutorial as it exists today provides simplistic code samples to submit and receive payments of XLM.
I would love a page (doesn't have to be the same page as a simple payments tutorial) that summarizes the requirements for supporting assets on Stellar.

Run Horizon (in the future, this would be "run the payments indexer & RPC")

configure it to only index data related to the assets you intend to list

Support deposits of the asset

provide code samples for streaming payments of Stellar assets (i.e. not just XLM) via Horizon
provide information about memos and muxed accounts (most exchanges uses memos, we'd like them to use muxed accounts)

Support withdraws of the asset

provide code samples for submitting payment transactions of Stellar assets via Horizon
provide information about retry logic, common status codes, etc.


getLocale() broken with strategy: "prefix"

The getLocale() is broken on the index.astro when using strategy: "prefix",
Astro config:
import { defineConfig } from "astro/config";

import liciousI18n from "@astrolicious/i18n";

// https://astro.build/config
export default defineConfig({
  integrations: [
    liciousI18n({
      defaultLocale: "en",
      strategy: "prefix",
      locales: ["en", "nl", "fr"], // must include the default locale
    }),
  ],
});

routes/index.astro :
---
import { getLocale } from "i18n:astro";

const locale = getLocale()
---

{locale}

result when navigation to /nl :

as you can see it's showing the locale as 'en' in the frontend, but it should be 'nl'.
when using strategy: "prefixExceptDefault" it does work as intended.

Is it broken in 0.5.0? I wonder if the latest patch broke it

It's broken in 0.5.0 and also 0.5.1

Furthermore, it will build the files in the right directory ex dist/nl/index.html and dist/fr/index.html but it will still build with getLocale() set to English. Making the pages all in English.


[WIP] #55 - removeStreamView can trigger an app crash because of async

Solves #55

Changed code in such a way that only the real view things happen on the runOnUiThread and made sure that all the view removing happens on main thread. It allows for blocking of the JavaScript callback. Will only trigger after it really has been removed.
Note: Adding and updating of View Hierarchy has to happen on the same thread(we do it on UiThread), removing of the View does not.


HADOOP-17893.Improve PrometheusSink for Namenode TopMetrics

Description of PR
https://issues.apache.org/jira/browse/HADOOP-17893
How was this patch tested?
add test testTopMetricsPublish
For code changes:
Parse TopMetrics in PrometheusMetricsSink

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 58s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
34m 11s

trunk passed

+1 :green_heart:
compile
23m 45s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
compile
20m 13s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
checkstyle
1m  2s

trunk passed

+1 :green_heart:
mvnsite
2m  6s

trunk passed

+1 :green_heart:
javadoc
1m  2s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
1m 37s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
2m 25s

trunk passed

+1 :green_heart:
shadedclient
18m 21s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 55s

the patch passed

+1 :green_heart:
compile
22m 31s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javac
22m 31s

the patch passed

+1 :green_heart:
compile
19m 56s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
javac
19m 56s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 58s

the patch passed

+1 :green_heart:
mvnsite
1m 31s

the patch passed

+1 :green_heart:
javadoc
1m  1s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
1m 35s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
2m 49s

the patch passed

+1 :green_heart:
shadedclient
18m 29s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
17m 28s

hadoop-common in the patch passed.

+1 :green_heart:
asflicense
1m  7s

The patch does not generate ASF License warnings.

193m 29s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3426/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3426

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux ae97b0fc21af 4.15.0-153-generic #160-Ubuntu SMP Thu Jul 29 06:54:29 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 3c964fa89b9f0c21ef019d227eefc8c2d23554f7

Default Java
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3426/1/testReport/

Max. process+thread count
1610 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3426/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
17m 51s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
33m 58s

trunk passed

+1 :green_heart:
compile
22m 44s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
compile
19m 22s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
checkstyle
1m  0s

trunk passed

+1 :green_heart:
mvnsite
1m 31s

trunk passed

+1 :green_heart:
javadoc
1m  3s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
1m 36s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
2m 25s

trunk passed

+1 :green_heart:
shadedclient
23m 33s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 55s

the patch passed

+1 :green_heart:
compile
22m 13s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javac
22m 13s

the patch passed

+1 :green_heart:
compile
19m 35s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
javac
19m 35s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 59s

the patch passed

+1 :green_heart:
mvnsite
1m 29s

the patch passed

+1 :green_heart:
javadoc
0m 59s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
1m 34s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
2m 33s

the patch passed

+1 :green_heart:
shadedclient
23m 44s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
17m 20s

hadoop-common in the patch passed.

+1 :green_heart:
asflicense
0m 47s

The patch does not generate ASF License warnings.

217m  6s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3426/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3426

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux 78abfb6d5933 4.15.0-143-generic #147-Ubuntu SMP Wed Apr 14 16:10:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / dfc535e426cf05342d371905709205ab08ea9ade

Default Java
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3426/3/testReport/

Max. process+thread count
1871 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3426/3/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
26m 15s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
35m  7s

trunk passed

+1 :green_heart:
compile
25m 27s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
compile
19m 57s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
checkstyle
0m 58s

trunk passed

+1 :green_heart:
mvnsite
1m 31s

trunk passed

+1 :green_heart:
javadoc
1m  2s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
1m 30s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
2m 28s

trunk passed

+1 :green_heart:
shadedclient
24m  8s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m  1s

the patch passed

+1 :green_heart:
compile
26m 27s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javac
26m 27s

the patch passed

+1 :green_heart:
compile
32m 28s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
javac
32m 28s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
1m 48s

the patch passed

+1 :green_heart:
mvnsite
2m 39s

the patch passed

+1 :green_heart:
javadoc
1m 43s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
2m 42s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
3m 16s

the patch passed

-1 :x:
shadedclient
30m 38s

patch has errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
1m 43s
/patch-unit-hadoop-common-project_hadoop-common.txt
hadoop-common in the patch failed.

+0 :ok:
asflicense
0m 42s

ASF License check generated no output?

245m  7s

Reason
Tests

Failed junit tests
hadoop.io.TestBloomMapFile

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3426/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3426

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux 91a9b65ce965 4.15.0-153-generic #160-Ubuntu SMP Thu Jul 29 06:54:29 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / dfc535e426cf05342d371905709205ab08ea9ade

Default Java
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3426/2/testReport/

Max. process+thread count
520 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3426/2/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

The fail tests seem unrelated.  Plz trigger test in jenkins again. Thank you.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 59s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
34m  7s

trunk passed

+1 :green_heart:
compile
22m 51s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
compile
19m 17s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
checkstyle
1m  2s

trunk passed

+1 :green_heart:
mvnsite
1m 31s

trunk passed

+1 :green_heart:
javadoc
1m  1s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
1m 38s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
2m 26s

trunk passed

+1 :green_heart:
shadedclient
23m 47s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 56s

the patch passed

+1 :green_heart:
compile
22m 11s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javac
22m 11s

the patch passed

+1 :green_heart:
compile
19m 17s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
javac
19m 17s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 58s

the patch passed

+1 :green_heart:
mvnsite
1m 30s

the patch passed

+1 :green_heart:
javadoc
1m  0s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
1m 34s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
2m 34s

the patch passed

+1 :green_heart:
shadedclient
24m  8s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
17m  6s

hadoop-common in the patch passed.

+1 :green_heart:
asflicense
0m 48s

The patch does not generate ASF License warnings.

200m 33s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3426/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3426

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux 16cecbeecd77 4.15.0-153-generic #160-Ubuntu SMP Thu Jul 29 06:54:29 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / e382775bab2f74f3fec73d127212bc7e5961dc6b

Default Java
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3426/4/testReport/

Max. process+thread count
3059 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3426/4/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

+1, Merged. Thank you @Neilxzn


Error in Draw Shapes example for Shape type: "Star"

To reproduce:

go to: http://openlayers.org/en/latest/examples/draw-shapes.html
select Shape type: Star
click on the map

Error message:
SimpleGeometry.js:177 Uncaught TypeError: Cannot read property 'length' of null
at e.setLayout (SimpleGeometry.js:177)
at e.setCoordinates (Polygon.js:321)
at new e (Polygon.js:92)
at e [as geometryFunction_] (draw-shapes.js:44)
at e.startDrawing_ (Draw.js:549)
at e.A [as handleUpEvent_] (Draw.js:913)
at e.f (Pointer.js:220)
at e.P [as handleEvent] (Draw.js:862)
at e.handleMapBrowserEvent (PluggableMap.js:920)
at e (events.js:41)
Problem line:
if (!geometry) {
geometry = new Polygon(null);
}

Maybe fixed by #8483?

yes, this issue is fixed with #8483


move logic to action file

work : before run the assign function, we just check the comment body and behalf of this, run the assign function , so it's fixed issue #10 and #11
Note: To apply these changes in BLT, we have to update the workflow file in BLT, and for this, please approve PR: https://github.com/OWASP/BLT/pull/1753

I would like to see some kind of automated tests

@fredfalcon  sir , then we have to use the workflow in a dummy project. I will create one and give you the link for test

@JisanAR03 can you use this project as the test project? So it is self contained?

@JisanAR03 can you use this project as the test project? So it is self contained?
@DonnieBLT sir, sorry for asking again. Can you explain a little bit more detailly?

@JisanAR03 you mentioned having a test project so can you use this repository to have the test project?  Ideally we can have a github action in this repository that can test creating an issue adding "/ assign" to it and see if it gets assigned to the user?  or if there was a way to make the code more modular and test individual functions that might work too.  My main concern is that we have some automated test to make sure it always works.

@JisanAR03 you mentioned having a test project so can you use this repository to have the test project? Ideally we can have a github action in this repository that can test creating an issue adding "/ assign" to it and see if it gets assigned to the user? or if there was a way to make the code more modular and test individual functions that might work too. My main concern is that we have some automated test to make sure it always works.

@DonnieBLT sir, then I think I should update this PR with the workflow file. and then you can check here. Is it ok, sir?

@DonnieBLT  , actually, sir I only added few lines of code but for the "if (issue && proceedWithIssueProcessing) {" line, github shows I edited all of the code 🙂
`if (eventName === 'issue_comment' && issue && comment) {
console.log('processing issue comment');
const commentBody = comment.body.toLowerCase(); // Convert to lower case for case-insensitive comparison
const assignKeywords = ['/assign', 'assign to me', 'assign this to me', 'please assign me this', 'i can try fixing this', 'i am interested in doing this', 'i am interested in contributing'];
const unassignKeywords = ['/unassign'];
    const shouldAssign = assignKeywords.some(keyword => commentBody.includes(keyword));
    const shouldUnassign = unassignKeywords.some(keyword => commentBody.startsWith(keyword));

    if (shouldAssign) {
        proceedWithIssueProcessing = true; // Set flag to true
    } else if (shouldUnassign) {
        console.log(`Unassigning issue #${issue.number} from ${comment.user.login}`);
        await octokit.issues.removeAssignees({
            owner,
            repo,
            issue_number: issue.number,
            assignees: [comment.user.login]
        });
    }
}`

ok let's go with it, thanks.  hopefully everything continues to work.  Can you please test after it's merged?

@DonnieBLT  , thank you so much sir ☺

ok let's go with it, thanks. hopefully everything continues to work. Can you please test after it's merged?

yeah sir sure .. I will test this after merge the "BLT" pr

screenshot after test:

looks fine sir ☺

awesome, nice work, thanks!

Can you please also update the readme

Can you please also update the readme

yeah sir sure , I will make one more PR after update the Readme


remove compress from all problem and streaming problem methods

@sanjgupt , I'm not seeing a recording for Toshiba.
Could you enable Toshiba testing, delete the Toshiba recordings and re-record them?


we need a way to run all of our tests, not just CI

Currently, we only run Describe blocks tagged with CI and are not running tests tagged Feature, Scenario, or Slow. We really should have a way to regularly run all of our tests.

Design Proposal:

[ ] 1.  Refactor the AppVeyor.yml PowerShell code into a module
[ ] 2. Refactor code which should be in build.psm1 into appVeyor.yml and the other way around
[ ] 3. Add the code to AppVeyor.yml to allow for a scheduled build
[ ] 4. Create a new AppVeyor Project and set it up to only run on a schedule
[ ] 5. Add a badge for the daily build to the readme.

Done


Support PM2.5 for AC

Closes #40

The difference is the command type only, so I created an abstract PM2.5 class and implemented each entity class.


Add frozen_row config

Checks

[X] I have checked that this enhancement has not already been requested

How would you categorize this request.  You can select multiple if not sure
Display (is this related to visual display of a value), Summary stats, Developer ergonomics (defaults, error messages)
Enhancement Description
Allow buckaroo to be configured to display a row at the top of the table view that is pulled from summary stats.  Also allow a row formatter to be specified.  Histograms currently do this, but are hardcoded into the app.  Instead the current histogram display should be configured as
BuckarooWidget(df, frozen_row=['histogram', 'HistogramRowFormatter'])
Polars users expect to see the dtype for every column in their table view.  This feature makes that trivial to support with
BuckarooWidget(df, frozen_row=['dtype', 'StringRowFormatter'])
Pseudo Code Implementation
No response
Prior Art

Fixed by #201 for release 0.6.1


CronJobs and Jobs support

It would be great to add support for CronJobs

List and view CronJobs
Being able to manually trigger a run of a CronJobs

Thanks !

Thanks for calling it out. We believe that we've already covered CronJobs in our code. But it's a good idea to trigger a run of a CronJobs

Hey @tianni4104! I would like to contribute. Could you tell me what exactly I need to do as I haven't contributed before.

Hi. Since kubernetes v1.25 batch/v1beta1 is not supported (https://kubernetes.io/docs/reference/using-api/deprecation-guide/). So, cronjobs does not available anymore.


Removed reference to terhix.com

Changed document link from terhix.com (which is reported to be compromised, does not show any documentation) to docs.rs.

Thanks!


Remove Text Search Limit

we still need to respect the configured limit. CQ is another path to search indexes but it should honor the same configuration parameters. See https://github.com/cloudant/dreyfus/blob/master/src/dreyfus_httpd.erl#L68-69 for how dreyfus does it.

not sure why get_limit insists on lower limit of 25, so why isn't that function simply erlang:min(get_dreyfus_limit(), CAcc#cacc.limit + CAcc#cacc.skip). ? (cc @davisp)

Probably just didn't realize there was a standard config parameter for it. I'm fine with this change.
+1

I'm ok removing the 25 lower limit as well. Not sure what my reasoning was for that.
Also "We may want to revisit this." means I was probably aware that it was silly but didn't want to think that hard while working through the other bits.

+1 after that last change and squash.


Crafting not properly converting container items (Unending bowl recipe not returning empty bucket etc)

This applies to all crafting processes:
Mortars should return empty containers
Pyre should return empty containers
Fey Crafter should return empty containers


Title Bar links

I talked to you on Twitter about this. You told me to create a request for an easier way to add "Settings | About" etc next to the WindowControls.

What sort of customisation would you like? It won't be possible to customise those buttons for the MetroWindow, but if you're using WindowCommands by itself, we could do something like:
<WindowCommands> <Button Content="Settings"> <Button Content="About"> </WindowCommands>
Should the separator be 'forced' or require you to put that in as well?

I think it should be forced as that is how it's done in Zune, but then again there aren't no guidelines for the Zune theme.

I support this feature. I'd like  to display an image button with a cog for settings.
Do you have an ETA for this?

There is no ETA for this because its a non-trivial thing to restyle/turn into a control.

Some progress has been made towards this.

Separators, it turns out, are a heck of a lot more work than one would think. The xaml to generate this from the "consumption" side (ie, what you stick in the client), current looks like this:
                <Controls:WindowCommand>
                    <Button Content="1" />
                    <Button Content="settings" />
                    <Button>
                        <StackPanel Orientation="Horizontal">
                        <Rectangle Width="20"
                        			Height="20">
                            <Rectangle.Fill>
                                <VisualBrush Stretch="Fill"
                        					Visual="{StaticResource appbar_cupcake}" />
                            </Rectangle.Fill>
                        </Rectangle>
                            <TextBlock Text="  deploy cupcake" />
                        </StackPanel>
                    </Button>
                </Controls:WindowCommand>

I've checked the progress in for this https://github.com/MahApps/MahApps.Metro/blob/master/MetroDemo/MainWindow.xaml On a MetroWindow, you can access WindowCommands now, by doing this:
  <Controls:MetroWindow.WindowCommands>
      <Controls:WindowCommands>
          <Button Content="wat" />
      </Controls:WindowCommands>
  </Controls:MetroWindow.WindowCommands>

Which will produce this:

Notice that while MetroWindow.ShowTitleBar="True", the colour of these is white. Once ShowTitleBar is disabled, it adapts based on the light or dark theme.
If somebody else could check this out and confirm its the behaviour you're seeking, that'd be a great help/step towards 0.7 being released.


'Move' action not possible in Chrome

Affected Scenario(s): [e.g. 6, 10 and 33]
4, 16 and 18 are the only three I tried but my hunch is that all of them might be affected
Describe the bug
Moving monsters or players does not work.
To Reproduce
Steps to reproduce the behavior:

Go to one of the scenarios listed above
Click on any monster or starting character
Try to perform the 'move' action
You will see that it does not work

Browser :
It doesn't work in Chrome.
Firefox seems to work fine.

Thanks for raising this @radekwyrwas ! Unfortunately a release late last night broke the move functionality in Chrome.. I should have a fix for this rolled out soon though.
Really sorry about the inconvenience this has caused

I've managed to roll out a fix for this now (1.6.2) - You will be able to tell if you're running the current version by looking in the bottom right of the screen, where it should say 'Version 1.6.2'. You may need to do a hard refresh or clear your cache in order for it to work properly.
Sorry again for the trouble caused

Thank you so much!


Note that desktop notification duration is a max of 5 seconds for desktop apps

Note that desktop notification duration is a max of 5 seconds for desktop apps.
To fix it requires upstream changes in Electron. The required level of effort doesn't exceed the benefit: https://github.com/mattermost/desktop/issues/304#issuecomment-346902736
cc: @yuya-oc @esethna

PM approved: https://pre-release.mattermost.com/core/pl/s1hpaib3i7nyfmd7853rixk8sc


Terraform is not found in ubutnu@latest

Description
Terraform scripts do not work when 'runs-on' still references ubuntu@latest in github actions, but in fact uses 24.04.1 version instead 22.04.5.
I get terraform: command not found Error: Process completed with exit code 127 error when try to run terraform init.
Platforms affected

[ ] Azure DevOps
[X] GitHub Actions - Standard Runners
[ ] GitHub Actions - Larger Runners

Runner images affected

[ ] Ubuntu 20.04
[ ] Ubuntu 22.04
[X] Ubuntu 24.04
[ ] macOS 12
[ ] macOS 13
[ ] macOS 13 Arm64
[ ] macOS 14
[ ] macOS 14 Arm64
[ ] macOS 15
[ ] macOS 15 Arm64
[ ] Windows Server 2019
[ ] Windows Server 2022

Image version and build link
Operating System: Ubuntu 24.04.1 LTS
Runner Image: ubuntu-24.04 (20241006.1.0)
Is it regression?
Yes. Ubuntu 22.04.5 LTS, Runner Image ubuntu-22.04 (20241006.1.0)
Expected behavior
Terraform is installed and is a part of an Ubuntu 24.04 image.
Actual behavior
Terraform not fount in Ubuntu 24.04 runner image.
Repro steps
Try run 'terraform init' within ubuntu@latest github action.

runs-on: ubuntu-22.04 fixes this issue, but does not seem to be aligned with recommended strategy to use ubuntu@latest.

Hi @ANavakahtsky Thank you for bringing this issue to our attention. We are looking into this issue and will update you on this issue after investigating.

Terraform is not included in the list of installed softwares here: https://github.com/actions/runner-images/blob/main/images/ubuntu/Ubuntu2404-Readme.md
But it's available here: https://github.com/actions/runner-images/blob/main/images/ubuntu/Ubuntu2204-Readme.md
Looks like for some reasons they decided to exclude it.


Fixed npm package installation command syntax

Fixes #1247

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

npm install is an alias to npm add. I missed that at first. This makes this PR irrelevant.
I am going to close this now but thanks for your contribution.

This is actually not irrelevant, as the common and known command to users indeed is called npm install. As the command indeed seems to confuse users, this is a valuable change that will help avoid such confusion in the future.

Thanks for the PR!

K


Can not build project including nativescript-dev-sass plugin with --path option

Steps to reproduce:
tns create TestAppNG --template https://github.com/NativeScript/template-drawer-navigation-ng
tns prepare android --path TestAppNG

Logs:
Executing before-prepare hook from c:\Git\nativescript-cli-tests\TestAppNG\hooks\before-prepare\nativescript-dev-sass.js
Found peer node-sass
Error: File to import not found or unreadable: c:\Git\nativescript-cli-tests\node_modules\nativescript-theme-core\scss\light.
       Parent style sheet: c:/Git/nativescript-cli-tests/TestAppNG/app/app.scss
        on line 4 of TestAppNG/app/app.scss
>> @import '~nativescript-theme-core/scss/light';
   ^

SASS compiler failed with exit code 1

Merged the solution from @radeva. Please let me know if that fixes your error.
Should be available on npm as version 1.2.0 shortly.


[KYUUBI #3602] Bump log4j from 2.18.0 to 2.19.0

Why are the changes needed?

to close #3602 .
Bump log4j from 2.18.0 to 2.19.0.
How was this patch tested?

[ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

[ ] Add screenshots for manual tests if appropriate

[x] Run test locally before make a pull request

Codecov Report

Merging #3603 (fef6865) into master (2cb34c4) will increase coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #3603   +/-   ##
=========================================
  Coverage     51.75%   51.75%
  Complexity       13       13
=========================================
  Files           483      483
  Lines         27023    27023
  Branches       3777     3777
=========================================
+ Hits          13985    13986    +1
+ Misses        11672    11670    -2
- Partials       1366     1367    +1

Impacted Files
Coverage Δ

...he/kyuubi/ha/client/etcd/EtcdDiscoveryClient.scala
66.25% <0.00%> (-0.63%)
:arrow_down:

...ain/scala/org/apache/kyuubi/engine/EngineRef.scala
73.10% <0.00%> (+0.84%)
:arrow_up:

...apache/kyuubi/engine/JpsApplicationOperation.scala
80.64% <0.00%> (+3.22%)
:arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Thanks, merging to master


Cleanup nuget feeds

CC @aspnet/build
Don't merge until we open for 3.0.2

#18976, are we open for 3.0.2 changes? Can this be merged?

are we open for 3.0.2 changes?

We are open for GitHub updates for 3.0.2. Hold off on anything in AzDO.