clarification on semantic versioning

This project clearly looks to be tagging using semantic versioning.
Doesn't this line from the project README.md break any notion of semantic versioning?

that means that most code under pkg/ is subject to change in a breaking way, even between minor or patch releases and even if the code is currently publicly exported.

It would be much more clear to simply state that this project does not follow semantic versioning.
One easy solution would be:

Every time any public  func,type,interface etc. changes in pkg/... , just bump the major semantic version.

Issue 3868 does mention the use of go convention enforced by go mod of using internal to isolate what would otherwise be breaking changes.
For reference, go version numbers
Thanks

Hi, appreciate your input!
We avoid making breaking changes to our Go public interface if we can, but our primary concern is that cert-manager as a tool is stable and unbreaking - we're not in the business of building a Golang library for people to import outside of a few very specific cases described on the website.
Longer term we'd definitely prefer to have everything that might want to be imported by third parties in a separate repo with strict semantic versioning, and to have this repo use "internal" for everything. But that's a lot of busywork and not a huge gain.

This project clearly looks to be tagging using semantic versioning.

I'm not actually aware of us ever saying directly that we use semantic versioning. I certainly would agree that we don't strictly follow semantic versioning and if we claimed that we did somewhere I'd probably advocate to change that.

I think this is probably safe to close!


Fix typo

Description:
Missing space in the error message lead to a typo in the output.
Related issue (if applicable): fixes #
Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#
Example entry for configuration.yaml (if applicable):
http:
  api_password: YOUR_PASSWORD

Checklist:
If user exposed functionality or configuration variables are added/changed:

[ ] Documentation added/updated in home-assistant.io

If code communicates with devices, web services, or a:

[ ] Local tests with tox run successfully. Your PR cannot be merged unless tests pass
[ ] New dependencies have been added to the REQUIREMENTS variable (example).
[ ] New dependencies are only imported inside functions that use them (example).
[ ] New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
[ ] New files were added to .coveragerc.

If the code does not interact with devices:

[ ] Local tests with tox run successfully. Your PR cannot be merged unless tests pass
[ ] Tests have been added to verify that the new code works.

@fabaff Think we should put this into 0.27.2?

Doesn't really matter if it goes into 0.28 or 0.27.2 as this is already around for quite some time.

🐬


[RESOLVED] Interface eth0(): High error rate (>2 for 5m)

Problem started at 09:18:29 on 2023.04.25
Problem name: Interface eth0(): High error rate (>2 for 5m)
Host: S100-Primario
Severity: Warning
Operational data: errors in: 9, errors out: 0
Original problem ID: 19945
Event details in Zabbix: http://<IP_ADDRESS>/tr_events.php?triggerid=23483&eventid=19945

Problem has been resolved in 6m 0s at 09:24:29 on 2023.04.25
Problem name: Interface eth0(): High error rate (>2 for 5m)
Host: S100-Primario
Severity: Warning
Original problem ID: 19945


net: FileListener doesn't work on Plan 9

See https://storage.googleapis.com/go-build-log/a29b1dce/plan9-386-gcepartial_808d3016.log.
ok      mime/quotedprintable    0.164s
--- FAIL: TestFileListener (0.00s)
    file_test.go:168: file file+net /net/tcp/22/ctl: file does not represent a listener
FAIL

Duplicate of #29801


Is there any fundamental reason why select_related is not supported

Is it because it is too hard to do with django-multitenant or is it because it is not possible at all? Without select_related how would one optimise the queries?

Hey @divick select_related works in the latest version with the introduction of TenantForeignKey. Just updated the README.


I would like to create new quantity inputs

https://www.hyperui.dev/components/ecommerce/quantity-inputs
The 4 components are looking same.
I would like to create something new

Good idea! The first 3 are variations of each other, be nice to add some diversity.

Can i start working on this


question: io_uring_enter EAGAIN return

hi, I have a question about io_uring_enter and EAGAIN.
When to_submit is zero, can io_uring_enter return EAGAIN?
When to_submit is not zero, can io_uring_enter return 0? And if so, when does it return 0, and when EAGAIN?

I wouldn't assume it won't in the future, but from what I see in the code (5.7), it can't.
Maybe except polling case, where a driver may decide to return that on ->poll() call.


Remove version: Tencent.COSBrowser version 2.10.0

[Automated] It returns code over 400 in all urls
Microsoft Reviewers: Open in CodeFlow

URL: https://cos5.cloud.tencent.com/cosbrowser/cosbrowser-setup-2.10.0.exe
Response status code does not indicate success: 404 (Not Found).
(Automated message - build 896)

URL: https://cos5.cloud.tencent.com/cosbrowser/cosbrowser-setup-2.10.0.exe
Response status code does not indicate success: 404 (Not Found).
(Automated message - build 896)


just-curry-it is not a declared dependency of @hyperjump/json-schema in latest version

https://github.com/hyperjump-io/json-schema/blob/0cef4969ef475ce6877eb6da4052e480fa144f2f/lib/schema.js#LL1C35-L1C35
While transpiling with Parcel, I found that while Pact declares the dependnecy on just-curry-it, this downstream package does not.
🚨 Build failed.

@parcel/core: Failed to resolve 'just-curry-it' from
<EMAIL_ADDRESS>
  /home/vovgiobt/nodevenv/public_html/blog-backend.cyberscientist.ca/14/lib/node_modules/@hyperjump/json-schema/lib/schema.js:1:19
  > 1 | import curry from "just-curry-it";
  >   |                   ^^^^^^^^^^^^^^^
    2 | import * as Pact from "@hyperjump/pact";
    3 | import { nil as nilPointer, append as pointerAppend, get as pointerGet } from "@hyperjump/json-pointer";

@parcel/resolver-default: External dependency "just-curry-it" is not declared in package.json.

  /home/vovgiobt/nodevenv/public_html/blog-backend.cyberscientist.ca/14/lib/node_modules/@hyperjump/json-schema/package.json:37:3
    36 |   "bundleDependencies": false,
  > 37 |   "dependencies": {
  >    |   ^^^^^^^^^^^^^^
    38 |     "@hyperjump/json-pointer": "^1.0.0",
    39 |     "@hyperjump/pact": "^0.2.4",

  💡 Add "just-curry-it" as a dependency.

Thanks for pointing this out. I've released v1.4.1 with the fix.


skylark: byte code compiler and interpreter

A byte code is a more efficient representation of the program for execution, as it is more compact than an AST, and it is readily serializable, permitting the work of parsing, resolving, and compilation to be amortized across runs when the byte code is cached in the file system.
This change defines a simple byte code, compiler, and interpreter for Skylark, using ideas from Python and Emacs Lisp.
It also deletes the tree-based evaluator. I evaluated (ha!) keeping both and switching between them dynamically, compiling the program just before the 2nd or nth invocation of a function. (In a build system, a great many "functions" are executed exactly once, such as the toplevel of a BUILD file.) However, the performance gain over always compiling was barely measurable and did not justify the cost of maintaining two different interpreters. Also, just-in-time compilation makes program dynamics very complex.
Details:

the toplevel code of a module is now represented as a function   of no parameters, enabling various simplifications.
Every Frame now has a Function.  Backtracing is simpler. Only the leaf frame (the error) has a position; all the parent frames record only the program counter of the call instruction, and compute the position from this as needed.
To keep the line number table encoding simple and compact, EvalError no longer reports column information. It would be nice to add it back with a carefully tuned encoding.

Breaking API changes:

Thread.{Push,Pop} are gone. The reason they were initially exposed is exemplified by the TestRepeatedExec test case, which is better served by the new API:

      var predeclared skylark.StringDict

      // parse and compile
      _, prog, err = SourceProgram("foo.sky", src, predeclared.Has)

      // "in between" stuff goes here

      // execute toplevel
      globals, err = prog.Init(thread, predeclared)

ExecOptions.BeforeExec is gone, and thus so is ExecOptions.
This function existed so that clients could "get in between" producing a program and executing it, but the new low-level API (see above) above separates these operations explicitly. Now that Exec and ExecOptions are no more expressive than ExecFile, they have been deleted.

Thanks to Jay Conrod for earlier rounds of review, including substantial simplifications.

cc: @laurentlb

[For the record: prior Google-internal review recorded at cr/150369732.]

Interesting!
Do you have any performance data?

Nothing rigorous. My primary motivation was to reduce the amount of time spent parsing BUILD/.bzl files that we've already seen before: the cost of parse+eval versus parse+compile+interpret is about the same for most BUILD files, but the cost of load+interpret is much less. For example query deps(//gws) takes 6.6s with an empty compile cache, versus only 5.1s with a full cache.


Unexpecte behavior on cancelled request

Expected Behavior
On a cancelled request I would expect to find a single logged item and have RequestCanceled as error code. Also I would expect to have no stack trace information given the context, just the error code and the request path.
Actual Behavior
I have 2 identical log items and the error code is UnableToCompleteRequestError. Below is how a log item looks.
requestId: "0HLQT4TOSU6LR:00000001", previousRequestId: "no previous request id", message: "Error Code: UnableToCompleteRequestError Message: Error making http request, exception: System.Threading.Tasks.TaskCanceledException: The operation was canceled. ---> System.IO.IOException: Unable to read data from the transport connection: The I/O operation has been aborted because of either a thread exit or an application request. ---> System.Net.Sockets.SocketException: The I/O operation has been aborted because of either a thread exit or an application request
   --- End of inner exception stack trace ---
   at System.Net.Sockets.Socket.AwaitableSocketAsyncEventArgs.ThrowException(SocketError error)
   at System.Net.Sockets.Socket.AwaitableSocketAsyncEventArgs.GetResult(Int16 token)
   at System.Net.Http.HttpConnection.FillAsync()
   at System.Net.Http.HttpConnection.ReadNextResponseHeaderLineAsync(Boolean foldedHeadersAllowed)
   at System.Net.Http.HttpConnection.SendAsyncCore(HttpRequestMessage request, CancellationToken cancellationToken)
   --- End of inner exception stack trace ---
   at System.Net.Http.HttpConnection.SendAsyncCore(HttpRequestMessage request, CancellationToken cancellationToken)
   at System.Net.Http.HttpConnectionPool.SendWithNtConnectionAuthAsync(HttpConnection connection, HttpRequestMessage request, Boolean doRequestAuth, CancellationToken cancellationToken)
   at System.Net.Http.HttpConnectionPool.SendWithRetryAsync(HttpRequestMessage request, Boolean doRequestAuth, CancellationToken cancellationToken)
   at System.Net.Http.HttpClient.FinishSendAsyncBuffered(Task`1 sendTask, HttpRequestMessage request, CancellationTokenSource cts, Boolean disposeCts)
   at Ocelot.Requester.HttpClientHttpRequester.GetResponse(DownstreamContext context) errors found in ResponderMiddleware. Setting error response for request path:/shipmentsapi/data/configurationtree, request method: GET"

Steps to Reproduce the Problem

Configure a route to a long running uri.
Start a request (via web browser or a tool like soapui).
Cancel the request before it completes.

Specifications

Version: 13.5.2
Platform: Windows

When the exception is OperationCanceledException the error code will be RequestCanceled.
https://github.com/ThreeMammals/Ocelot/blob/fbd9c01a425a0a3bda46717efda423883543fb76/src/Ocelot/Requester/HttpExeptionToErrorMapper.cs#L17-L32
System.Threading.Tasks.TaskCanceledException is a subclass of OperationCanceledException and it can not trigger the RequestCanceledError.
But I think it should get the RequestCanceled error code as well.

I send a PR to fix this problem.
Here is the new log information.
warn: Ocelot.Responder.Middleware.ResponderMiddleware[0]
      requestId: 0HLR1IQO6KT5M:00000001, previousRequestId: no previous request id, message: Error Code: RequestCanceled Message: The operation was canceled. errors found in ResponderMiddleware. Setting error response for request path:/aa, request method: GET

@catcherwong
:ok: Your fix is here
https://github.com/ThreeMammals/Ocelot/blob/d6eefc899f9b2d37814335c7d0bccd5f7a830bd0/src/Ocelot/Requester/HttpExceptionToErrorMapper.cs#L40-L43
Develop branch: Line 40
Commit: https://github.com/ThreeMammals/Ocelot/commit/2c97c5859d260847d2220657e8946484784e5ea7
Good!

Implemented by #1051


[Feature][Connector-V2] oracle connector

Purpose of this pull request

new v2 connector for oracle
Check list

[ ] Code changed are covered with tests, or it does not need tests for reason:
[ ] If any new Jar binary package adding in your PR, please add License Notice according
New License Guide
[ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs

#2550

Can you give a quick review of #2250 review? Some places have not been modified

@CalvinKirs flink e2e fake2oracle is ok

CI is error. how do i fix it?

CI is error. how do i fix it?

maven network connection error, I rerun again.

CI is error ,and the error is JdbcPhoenixIT .@CalvinKirs

Hi, rerun, due to its large size
On 08/31/2022 @.***> wrote：
CI is error ,and the error is JdbcPhoenixIT .@CalvinKirs
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: @.***>

CI is not  stable. @CalvinKirs

LGTM @CalvinKirs

@CalvinKirs pls review.

Need to merge #2648

Please add connector doc

@ic4y @EricJoy2048 @Hisoka-X @hailin0 please help to review ,and rerun CI.Thanks

Already add oracle doc. @EricJoy2048

Please merge the dev branch to your branch and push again because https://github.com/apache/incubator-seatunnel/pull/3022

Please merge the dev branch to your branch and push again because #3022

Done.

merge #3031. fix the e2e error. @EricJoy2048 help to rerun CI,and i need the common part of the jdbc e2e for gbase 8a,thanks


[SPARK-21977][HOTFIX] Adjust EnsureStatefulOpPartitioningSuite to use scalatest lifecycle normally instead of constructor

What changes were proposed in this pull request?
Adjust EnsureStatefulOpPartitioningSuite to use scalatest lifecycle normally instead of constructor; fixes:
*** RUN ABORTED ***
  org.apache.spark.SparkException: Only one SparkContext may be running in this JVM (see SPARK-2243). To ignore this error, set spark.driver.allowMultipleContexts = true. The currently running SparkContext was created at:
org.apache.spark.sql.streaming.EnsureStatefulOpPartitioningSuite.<init>(EnsureStatefulOpPartitioningSuite.scala:35)

How was this patch tested?
Existing tests

CC @brkyvz

Test build #82032 has started for PR 19306 at commit af017f0.

Test build #3928 has started for PR 19306 at commit af017f0.

Thanks @srowen . LGTM!

Test build #3928 has finished for PR 19306 at commit af017f0.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged to master


Add new workflow that updates go.sum files

Summary
When dependabot updates a new dependency it does not modify the go.sum files under actions/get-upstream-dependency/entrypoint and actions/list-new-upstream-dependency-versions/entrypoint that reference the go.mod in the root of the project so a problem is generated when one of these actions is used.
I create a new Workflow that updates these files when there is a change in the main go.mod file.
Checklist

[x] I have viewed, signed, and submitted the Contributor License Agreement.
[ ] I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
[ ] I have added an integration test, if necessary.
[x] I have reviewed the styleguide for guidance on my code quality.
[x] I'm happy with the commit history on this PR (I have rebased/squashed as needed).

Just wondering why https://github.com/paketo-buildpacks/dep-server/blob/a270512d02e9ba61668c321444d88b4f10bedc31/actions/list-new-upstream-dependency-versions/entrypoint/go.mod#L5-L7 is done instead of require github.com/paketo-buildpacks/dep-server main?
Also, wouldn't it fix the go.sum issue if go mod tidy is added here instead of a workflow that opens PRs?

@arjun024 I was wondering the same thing. It looks like this go.mod file has been like that since it's inception. I believe the version has to be of the form vx.x.x and can't be main. If you run a go get github.com/paketo-buildpacks/dep-server@main, the go.mod gets v0.0.0-20210716200630-a270512d02e9 added to it instead of v0.0.0-00010101000000-000000000000 . I am assuming this is because this repo isn't versioned in any way.

@arjun024 I hadn't thought about that! I'd love to see a PR for that for this action and get-upstream-dependency if you have a chance. That'd definitely work.


Build error for Versions >= 4.1.0 on jitpack.io

We want to use the new pending pacts feature in our project but we can't get the dependency (v4.1.x) in the project because the builds on jitpack.io are all broken (See e.g. https://jitpack.io/com/github/DiUS/pact-jvm/4_1_6/build.log)
Can you please have a look?
Thanks

I had a look, and the reason it is failing is there is no signing key, so the JAR files can not be signed.
Is there a reason you are not able to use the official versions published to Maven Central?
You can fix the build here by either disabling signing of the JAR files (which I don't think is a good idea), or provide a GPG key to be used.


Implement ability to debug through statements which ask for User Input

Implement ability to debug through statements which ask for user Input

This is something that now works in latest builds :)


[Feature Request] Simple UI searching topic by topic name

Is your proposal related to a problem?
One broker may have thousands of topic, I suggest we add a simple searching of topic by name on the UI

Hi @ducminhnguyen, thanks for the request! Currently, the interface allows you to search topics by name in the Topics tab. Is it not what you are looking for?


Linux Stable Unittests on GHA

Moving Linux Stable GPU Unittests to GHA.

@vmoens  Seeing the following errors when using mostly the same scripts/env vars as the previous CCI job:
=========================== short test summary info ============================
SKIPPED [1] test/smoke_test_deps.py:25: Not implemented yet
FAILED test/smoke_test_deps.py::test_dm_control - ImportError: Cannot initialize a headless EGL display.
FAILED test/smoke_test_deps.py::test_gym - gymnasium.error.NamespaceNotFound: Namespace ALE not found. Have you installed the proper package for ALE?

Did some research but don't want to touch anything that would change the test functionality. It seems like gymnasium is correctly installed though. Any ideas on resolving these errors?

Cannot initialize a headless EGL display

I usually rely on the "nvidia/cudagl:11.4.0-base" docker image which comes with all the EGL tooling I need. The pytorch docker images we usually use are hard to make work.

gymnasium.error.NamespaceNotFound: Namespace ALE not found. Have you installed the proper package for ALE?

This should work. Here I read that it has all been installed.
Now it does say just after

WARNING: Running pip as the 'root' user can result in broken permissions and conflicting behaviour with the system package manager. It is recommended to use a virtual environment instead: https://pip.pypa.io/warnings/venv

which might mean that the libs have been put somewhere else but then gym should not be accessible either...

Looks like the original Linux Unittests (stable) workflow also used the PyTorch manylinux image, not the cudaGL image. The pip error doesn't seem to be related in this case since other dependencies are found within the conda environment.

If you look at this
https://github.com/pytorch/rl/blob/1e17304cb0732d2f30bef2c15e0e6a0172d9feb8/.circleci/config.yml#L928
we're actually not using the docker to run the tests which makes the GPU apparent (I think)

I made the generic script run outside of the container. Then we specifically run all the scripts except for run_tests.sh inside of the container. Looks like this basically mimics the existing behavior at this point. We're down to just 1 test failing now - looks like gym test is still failing:
FAILED test/smoke_test_deps.py::test_gym - gymnasium.error.NamespaceNotFound: Namespace ALE not found. Have you installed the proper package for ALE?

cc @vmoens Got this job to work on GHA - would love your review

Have we tried to just copy paste the version that uses the nightlies and install the regular PyTorch instead?

This is still using the old install.sh script, I just consolidated everything into a single run_all.sh script. They both use the stable PyTorch version as opposed to nightlies.


Make Event_STOP|PROPAGATE slightely better

it would be nice to have something similar to glib::Continue. See gtk-rs/gdk#354 for details

Is this still needed? We have signal::Inhibit

Inhibit is used for something different I assume ?

My gtk is a bit rusty (pun intended), but you would use GDK_EVENT_STOP in the callback of a signal handlers for signals like button-press-event and in gtk-rs that callback returns Inhibit


Fix mixin init order. Close #329.

Shave off presets (mixin mixins) in the process.
Update tests & docs.

This will change the way events are reduced by mixin too ?
In the case I am using a mixin PromiseResolve to resolve each action using a promise to a thunk call.
App:actions:fetch -> PromiseResolve:events:resolve -> App:events:resolve

@Swizz This will change the way events are reduced by mixin too ?

Before the order started with app, now app is last.
With this PR.
const A = () => ({
  events: {
    anyEvent(state, actions, data) {
      console.log(data) //=> Data:
      return data + "A"
    }
  }
})

const B = () => ({
  events: {
    anyEvent(state, actions, data) {
      console.log(data) //=> Data:A
      return data + "B"
    }
  }
})

const C = () => ({
  events: {
    anyEvent(state, actions, data) {
      console.log(data) //=> Data:AB
      return data + "C"
    }
  }
})

const emit = app({
  events: {
    anyEvent(state, actions, data) {
      console.log(data) //=> Data: ABC
    }
  },
  mixins: [A, B, C]
})

emit("anyEvent", "Data: ")

LGTM :shipit:


Fix Ordinal add operand mutation

This commit fixes the following issue:

from transfinite import w
x = w+1
x
\omega + 1
x+1
\omega + 2
x
\omega + 2

by avoiding to mutate the addition operand:

from transfinite import w
x = w+1
x
\omega + 1
x+1
\omega + 2
x
\omega + 1

Thank you very much! And thanks for going through the code - I'm looking at it for the first time in a long while, and I see it's not easy to follow the logic at all.
I'll make an effort to try and refactor and improve the code here :-)
Thanks again!

Thanks to you for the library! ;-)


[misc] Switch to eslint + prettier

OK, this is a redo of #4546
I wanted to play with the options a bit, also this separates the eslint and prettier fixes.

Coverage decreased (-0.2%) to 88.204% when pulling 2d103d4f66e044dc1d9ac2421e1bf19793cc401c on eslint-prettier into 94edb2e8089ae73b68b266b8a2ac0c63f54fe799 on develop.

Coverage decreased (-0.2%) to 88.204% when pulling 2d103d4f66e044dc1d9ac2421e1bf19793cc401c on eslint-prettier into 94edb2e8089ae73b68b266b8a2ac0c63f54fe799 on develop.

@ichernev Personally, we should also add husky and lint-staged. See PR #5463 .


Update pokemon_v2/README.md

@SerenadeX thanks for finding this. Could you also update the link? (ContestEffect) should also point to Super Contest Types
I would take the Contest Spectacular discussion over to https://github.com/veekun/pokedex
I believe they're still updating their data to completely incorporate ORAS. Seems to get more time consuming every time a new game comes out because things just get more complex. Sun and Moon is going to kill us :)

YEY I can't wait for Sun and Moon haha.

@sh0hei please rebase against master :)

@phalt done :)

Thanks :)


Tanim play video issue for wait

Video is generated successfully but may encounter error when playing the video right after finish generating the video.
This is caused by playing video before it is fully written.

Fixed in commit cb28369


Frontend throws unknown error for Analytics tab if it is disabled

Describe the bug
If Datahub analytics is disabled by deployment config:
global:
  graph_service_impl: elasticsearch
  datahub_analytics_enabled: false

and Elasticsearch is used as graph service the corresponding Elasticsearch index (datahub_usage_event) is not created.
Therefore the frontend throws an unknown error when users click on the analytics button.
ERROR c.l.d.g.a.service.AnalyticsService - Search query failed: Elasticsearch exception [type=index_not_found_exception, reason=no such index [datahub_usage_event]]
To Reproduce
Steps to reproduce the behavior:

Deploy Datahub with config above
login to the frontend
Click on Analytics in the above right corner
See error

Expected behavior
I would expect to disable/hide the button in the frontend so users cannot click on it or alternatively show a message and explain that this feature is not enabled.
Screenshots

Desktop (please complete the following information):

OS: Mac OS
Browser: Brave
Version 0.8.13

@gabe-lyons : you might want to take a look at this one

The button should indeed be disabled when you disable analytics. Will take a look!

Is this still an issue? If not, will close it in a few days due to inactivity.


[SSH] Remove setup.py from connectedmachine SDK folder

This checklist is used to make sure that common guidelines for a pull request are followed.

For new extensions:

[ ] My extension description/summary conforms to the Extension Summary Guidelines.

About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
The precondition is to put your code inside this repository and upgrade the version in the pull request but do not modify src/index.json.

SSH


Fuse.Scripting: give error on unconsumed args

In the argument-less case, we can make a generic error if arguments
were passed to a method that doesn't care about arguments.
This ensures calling code is forward-compatible in the case where we
want to add arguments to existing methods.

Wait, I think this needs a CHANGELOG entry. If somebody happened to pass an argument to one of those functions before, it will now produce an error and do nothing instead of being ignored.

Good point, I'll add this!


sqlx problem with passwords containing special chars and % encoding

Bug Description
It looks like Postgres support has issues with special character passwords even when using %encoding.
Minimal Reproduction
Try to connect to PSQL with following URI ( no special chars escaping)
DB URL<EMAIL_ADDRESS>Result:
WARN sqlx_postgres::options::parse: ignoring unrecognized connect parameter<EMAIL_ADDRESS>value=
Error: error communicating with database: failed to lookup address information: Name or service not known

So "?" is a problem. Escaping with %3F doesn't help:
DB URL<EMAIL_ADDRESS>Result:
Error: error communicating with database: failed to lookup address information: Name or service not known
Info

SQLx version: 0.7.4
SQLx features enabled: ["sqlx-postgres", "runtime-tokio", "tls-rustls", "postgres"]
Database server and version:/ Postgres
Operating system: Linux
rustc --version: rustc 1.78.0 (9b00956e5 2024-04-29)

Try doing a full escape of that password, it should be %2F7M%2Br%3FE%27%3AdHz
It uses regular url encoding with you can find online converts for it

Closing as user error.


ios

does not work on ios, please help, support it, android works fine

Can you share your project with me perhaps?


General check up for no segfault policy

move the binary where it can't load his assets
limit the memory
limit cpu

only remove some assets


Possible race condition in add_alarm_in_us/sleep_us, incorrect alarm period

Below is a simple program that uses a recurring timer interrupt using add_alarm_in_us to blink an LED as a liveness check.
In the main loop, it simply reads characters from stdin (USB CDC), uses sleep_us, and echos them to stdout.
When sending enough data to the Pico, it eventually stops blinking, which should never happen.
The Pico is still alive, but the blink timer interrupt somehow stopped firing. After some time (minutes to hours), it suddenly starts blinking again, so it seems like it's just the alarm period that somehow gets corrupted.
The reason that I wrote this small program is that in a much larger program, I sometimes encountered sleep_us hanging in a similar way when the USB traffic was high. I would have a sleep_us(100) somewhere, for example, and I would notice that the Pico would hang on that call for minutes. When attaching a debugger, it turned out that it was indeed waiting inside of sleep_us (all relevant variables were optimized out, so I didn't investigate further, this only happens in release mode).
main.cpp
#include <pico/stdio.h>
#include <pico/stdlib.h>
#include <cstdio>
#include <initializer_list>

// #define SLEEP_US(x) busy_wait_us(x)
#define SLEEP_US(x) sleep_us(x)

static constexpr uint wait_led_pin = 19;
static constexpr uint blink_led_pin = PICO_DEFAULT_LED_PIN;
static constexpr uint test_pin = 2;

int64_t blink(alarm_id_t, void *) {
    static bool led_state = false;
    gpio_put(blink_led_pin, led_state ^= 1);
    return -80'000;
}

void loop() {
    static bool led_state = false;
    gpio_put(wait_led_pin, led_state ^= 1);
    int ch = getchar_timeout_us(100'000);
    if (ch >= 0) {
        gpio_put(test_pin, 1);
        SLEEP_US(static_cast<uint8_t>(ch));
        gpio_put(test_pin, 0);
        putchar_raw(ch);
    }
}

int main() {
    for (uint pin : {wait_led_pin, test_pin, blink_led_pin}) {
        gpio_init(pin);
        gpio_set_dir(pin, GPIO_OUT);
    }

    stdio_init_all();

    auto timer_id = add_alarm_in_us(80'000, blink, nullptr, false);
    if (timer_id < 0)
        panic("No alarm slots available");
    if (timer_id == 0)
        panic("Alarm already passed");

    while (1)
        loop();
}

CMakeLists.txt
cmake_minimum_required(VERSION 3.18)
include(cmake/pico_sdk_import.cmake) # Pull in SDK (must be before project)
project(pico-sleep-test C CXX ASM)
pico_sdk_init() # Initialize the SDK

add_executable(main main.cpp)
target_link_libraries(main PRIVATE pico_stdlib)
pico_enable_stdio_usb(main 1)
pico_enable_stdio_uart(main 0)
pico_add_extra_outputs(main)

Build
export PICO_SDK_PATH="${HOME}/pico/pico-sdk"
cmake -S. -Bbuild \
    -DCMAKE_BUILD_TYPE=RelWithDebInfo \
    -DPICO_CXX_ENABLE_EXCEPTIONS=Off \
    -DCMAKE_INTERPROCEDURAL_OPTIMIZATION=On
cmake --build build -j -t main

Test
port="ttyACM1"

# Upload the firmware and reset the Pico
~/opt/raspberrypi-openocd/bin/openocd -f interface/cmsis-dap.cfg -c "adapter speed 5000" -f target/rp2040.cfg -c "program build/main.elf verify reset exit"
sleep 3
# Generate some random data to send
[ -e challenge.bin ] || head /dev/urandom -c 1M > challenge.bin
# Configure the serial port
stty -F /dev/$port 115200 raw crtscts -echo
# Discard any old data already in the buffer
timeout 1 cat /dev/$port > /dev/null ||:
# Read the response and write it to a file
cat /dev/$port > response.bin &
# Send the data to the Pico
cat challenge.bin > /dev/$port
# Wait for all data to be received and stop reading
sleep 10
kill -INT %1
# Make sure the response matches the challenge
cmp {challenge,response}.bin

Tools
Ubuntu 22.04.3
pico-sdk 1.5.1
arm-none-eabi-gcc (15:10.3-2021.07-4) 10.3.1 20210621 (release)
libnewlib-arm-none-eabi 3.3.0-1.3

Pico SDK patch
Required to support LTO (otherwise, the linker can't find the __wrap_ functions).
diff --git a/src/rp2_common/pico_platform/include/pico/platform.h b/src/rp2_common/pico_platform/include/pico/platform.h
index 64b5e96..5f905ac 100644
--- a/src/rp2_common/pico_platform/include/pico/platform.h
+++ b/src/rp2_common/pico_platform/include/pico/platform.h
@@ -484,7 +484,7 @@ static __force_inline uint __get_current_exception(void) {
     return exception;
 }

-#define WRAPPER_FUNC(x) __wrap_ ## x
+#define WRAPPER_FUNC(x) __attribute__((used)) __wrap_ ## x
 #define REAL_FUNC(x) __real_ ## x

 /*! \brief Helper method to busy-wait for at least the given number of cycles

I understand that LTO/CMAKE_INTERPROCEDURAL_OPTIMIZATION is not officially supported, however, the fact that it fails with LTO enabled may point to an underlying problem such as a data race or another source of undefined behavior.

I'm really happy to see this issue here because I had the same problem 20 minutes ago concerning LTO (wrapper functions not found). So yeah, maybe it could be cool to add an option to the pico sdk to support LTO (something like PICO_SDK_LTO which would add -DPICO_SDK_LTO to the compilation command-line to conditionally define WRAPPER_FUNC to __attribute__((used)) __wrap_ ## x). However, I guess inconsistent behavior when enabling LTO may rather be caused by unwanted optimizations (I don't know exactly how nor why) or wrong code (but I think pico-sdk's code has been sufficiently tested to verify such things) rather than data races (at least in this case, since there's apparently no multicore code nor multithreading possibilities)

Note #97 for LTO

I understand that LTO/CMAKE_INTERPROCEDURAL_OPTIMIZATION is not officially supported, however, the fact that it fails with LTO enabled may point to an underlying problem such as a data race or another source of undefined behavior.

are you saying it doesn't fail without LTO

However, I guess inconsistent behavior when enabling LTO may rather be caused by unwanted optimizations (I don't know exactly how nor why) or wrong code (but I think pico-sdk's code has been sufficiently tested to verify such things)

In my experience, what you refer to as "unwanted" optimizations have almost exclusively been caused by invalid code invoking Undefined Behavior.
For correct code without UB, the compiler and the optimizer should not alter the observable behavior of the code (for the standard's definition of observable). As such, "unwanted" optimizations are not really a thing, it's just that if you write code that violates the preconditions of the optimizer, the result won't satisfy its postconditions either. This is of course ignoring the real possibility of compiler bugs, but those are relatively rare, and shouldn't usually be the first hypothesis.
UB is unfortunately not something you can really test for: because of its very nature, problems may only come up in certain scenarios or at sufficiently high optimization levels.

rather than data races (at least in this case, since there's apparently no multicore code nor multithreading possibilities)

True, but in the cases where I encountered the bug, there have always been timer interrupts involved. In the example code I posted, the state of the timer/alarm pool has to be updated both from the main thread and in the interrupt handlers. Combined with the nondeterministic behavior, a data race doesn't seem unlikely, but there could of course be other causes.

are you saying it doesn't fail without LTO

Indeed. Or at least, I haven't observed the same glitch (yet?) without LTO enabled. Given the sporadic nature of the bug, it may just be more likely with LTO enabled, but not impossible without.
Even with LTO enabled, it occasionally takes two or three tries to reproduce the issue.

@tttapa yeah indeed, maybe you're right, especially if it hasn't been tested with LTO enabled before

It could be that enabling/disabling LTO is simply changing the timing and ordering of events, which makes the bug apparent (or not).
We are also seeing a very similar issue in MicroPython and I think we have tracked down the bug to the way the hardware timer target is being configured, sometimes an interrupt is missed and that puts things into an inconsistent state.  See #1552.

are you saying it doesn't fail without LTO

I just tried this and it seemed that the issue was ONLY reproducible with LTO

The alarm code was rewritten for the last SDK, please check on that


Documentation

Is there a full documentation anywhere?

Best thing I've found are the demos. The simple one is easy to get.
https://github.com/xbsoftware/enjoyhint#demo

Hi @iggirubio ,
We'll add it soon


Don't do dispose animation on undo

The block should disappear immediately, not animate out as if we dropped it into the trash/toolbox

Changed in Blockly's develop branch.

sounds good - thanks, Neil!


Build error on ubuntu: no such include directory: 'PhysX/physx/source/Common/src/linux'

Try to build in ubuntu 24.04.1 fllowing README.md but get this error.

It's may related to the includes_CXX.rsp that generated by cmake and reference by emscripten-release/sdk_source_bin/CMakeFiles/xxxx/build.make, while compiling orinal phsyx sdk in linux does't generate .rsp and works well.
So I set CMAKE_CXX_USE_RESPONSE_FILE_FOR_XXXXS OFF in physx/source/compiler/cmake/CMakeLists.txt but it doesn't avoid the generation of .rsp file.
Has anyone encountered the same situation?

Force cmake to generate .rsp for linux and get no compile error as well in original physx

Hmm first thing: the common dir in the path exists but is spelled with a lower case c and on Linux paths are of course case-sensitive, which is why you get the no such file or directory error.
However, I'm using Linux as well to build the lib and don't get that errors, so it might be something in your configuration?

In PhysXCommon.cmake is common/src/linux with lower case c.
But when it's been included in LowLevel.cmake and PhysxExtensions.cmake, it is  Common/src/linux with upper case c.
I guess that's where the Common/src/linux comes from, but i see the cmake file is almost the copy of source/compiler/cmake/linux. That's wierd.


SIGTERM and SIGINT handling

I am trying to get advantage of onShutdown handler:
$processManager = new Ko\ProcessManager()
$processManager->fork(function(Process $process) {
});

$processManager->fork(function(Process $process) {
});

$processManager->onShutdown(function () {
    echo 'Shutting down';
});

$processManager->wait();

But it is never called.
When I interrupt my script with Ctrl + C SIGINT signal is sent.
SIGTERM is expected in:
protected function setupSignalHandlers()
{
    $this->signalHandler = new SignalHandler();
    $this->signalHandler->registerHandler(SIGCHLD, function() {
        $this->handleSigChild();
    });

    $this->signalHandler->registerHandler(SIGTERM, function() {
        $this->handleSigTerm();
    });
}

I have tried adding:
$this->signalHandler->registerHandler(SIGINT, function() {
    $this->handleSigTerm();
});

But then the script is never interrupted.

Look's like joke but this is normail is php application then tru to catch SIGTERM  from console. Here is good explanation why this so http://www.hackingwithphp.com/16/1/1/taking-control-of-php. You can catch SIGTERM request with kill <pid> for your master/slave php process.

@misterion Thanks.
But, shouldn't we trigger onShutdown on SIGINT?

Only if send it with kill

OK, maybe it wold be useful to have something for SIGINT, maybe new method like:
$processManager->onInterrupt(function () {
    //
});

But php actually can not hande SIGINT/SIGTERM sended from console.


Could you please tell me how to decompress the RYDL.hdf5 file to get the picture and put it into the model for prediction?

Hi @DBIGSHUAI,
you could access hdf5 data as follows:
import h5py
data = h5py.File("RYDL.hdf5", mode="r")

After that, you could use the verification example provided in the rainymotion library as a reference: https://rainymotion.readthedocs.io/en/latest/notebooks/nowcasting.html.


bug: Splash Screen on iPad with orientation locked

Type: bug
Platform: ios 7 webview
When the Orientation preference config is set to "portrait", Ionic does not create landscape splash screens (as mentioned here: http://ionicframework.com/docs/cli/icon-splashscreen.html). However, an iPad locked to landscape mode will display the landscape splash screen of an app on launch - even if that app is locked to portrait. This causes the default Cordova splash screen to appear on launch.

Hmm, just tested this out with a fresh project, set the project to portrait, then created the splash screens. Locked my iPads orientation to landscape, but when I launched the app, it launch with the portrait splash screen.
Not sure there's too much we could do about this though, it's more of a cordova specific issue.
You might want to post and issue on their issue tracker.
http://cordova.apache.org/
Closing this.


Create Sapphire Implementation of the MemberLeave Event

Event
Bot leaves a guild
Steps

Set guild to disabled
Set birthdays with guild_id to disabled

Implemented in cda10d4750dc16763fe3904349e2c092dbff71d4


Reports break when installed

Reports UI breaks when the module is installed.

Looks like the recent permissions expansion has broken something.  Digging further.

The ScheduledReport entity was missing the getEntityType() function, which was causing an endless recursion on the underlying __call method from the EntityModel.  Adding the function allows things to progress but need to determine if there are any other side effects to it.

This issue is related to PR invoiceninja/invoiceninja#2283

PR invoiceninja/invoiceninja#2282  has been merged.


Fix git url for git clone in documentation

The git url for git clone in documentation is not working, it's not the Salesforce repository.

CLA is signed.

Thanks @gschurck for the contribution. Regards.

You're welcome


Not all address fields included in the form

In the form to update the meeting, not all of the available address fields are available.
i.e. County/Sub-Province and Nation
In my region, we cover 2 separate Countries (Ireland and Northern Ireland) so we do use the Nation field.
And the country is divided up into Counties, so we use the County field as well.

Support for these specific fields have been added in 0.3-beta. Will look at adding a more generic method for handling these shortly, as these aren't the only fields I've missed.


AlternateCssUrl File is downloaded but  file entries is not created

In ObjectComposedLook SiteLogoUrl, BackgroundFile, ColorFile, and FontFile are all downloaded then have File entities created and added to the template.  AlternateCssUrl does not.  Is there a reason for this?

this may only be an insure in the current release.  I was reviewing the code in the dev branch and object handlers have change significantly.  I'm going to try the dev branch and see if this is solved, report back soon.

Using the dev or master branch with the Debug15 profile the AlternateCssUrl is set but the file it references is not downloaded and is not referenced in the Files section.  I propose that this be changed so regardless of 15/16 code base if the AlternateCssUrl  references a file in the current site it be downloaded and included as a file in the template.
I would make the change and submit it myself but I'm working though some IP issues with my work.  So for now this is the best I can do.

Hi Bestadd,
Thanks for your contribution. We will make it possible to download the CSS file, if the PersistBrandingFiles flag is set to true, and if the CSS is within the same site that you are exporting the template from. I will let you know when it is done. Thanks.

Hi Bestadd,
I just realized that it is already implemented, since Jan 2016. I will close this Issue, but feel free to let us know in case of any further need. Thanks.


Create how-to-update page

Do we need to mention Cron at all? Not sure if the setup script properly overwrites old configs. I've always just hashed out the old stuff before I ran it.


[Feature request] Add more calendar events

I can't find a way to edit calendar event topics. I think I need at least "other", "harvest" and "replace" events. It would be great if these can be added. There might be other events but these came to my mind.

Thanks for the hint, we can add these, too!
What do you mean with "replace"? Maybe we can choose a better wording.

Certainly, there will be a better word for it. I mean with "replace" to replace filter medium or similar consumable item. Or use it with plants to replace them with new ones after harvest. For salads/microgreen etc there is no need to add them as a "plant" since their lifespan is limited.

I am tempted to use the term "respawn" for that. :D I am not a native english speaker, but in german it does not only translate to "resurrect" but also "restart" which would essentially describe the process.

You can now manage custom calendar classes. I consider this specific topic resolved.


Make custos part of att.visualOffset.ho

Follow-up PR to #951. Makes it possible to apply a horizontal offset to custos as suggested by @pe-ro.

Looks like a good solution. 👍

Thanks everyone!


PDF doesn't show images

hi,
I'm using phpwkhtmltopdf since 3 years. It works fine. but since a few days, it doesn't put images (charts generated from Highcharts) in my PDF. I didm't change anythings in my code. Have you an idea ?

This is a question for wkhtmltopdf itself, not our library. We provide only a thin wrapper around it for PHP.


Deal with the SIGALRM problem

This also probably conflicts with time.sleep().
Probably need to adapt https://gist.github.com/dcoles/2132527

Can Cython code be a thing? How bad is that?


Notes on if statements

The "Shorter if syntax" section does not mention that there are actually some differences :
# foo && bar is different from foo; then bar; fi
$ false && true
$ echo $?
1

$ if false; then true; fi
$ echo $?
0

You may want to be able to use your shell script as a command line utility.
Using foo && bar may return a non 0 exit status even if the script succeeds.
# foo && bar || foobar is different from if foo; then bar; else foobar; fi
$ if true; then false; else foo=bar; fi
$ echo $foo

$ true && false || foo=bar
$ echo $foo
bar

May cause unwanted behaviors.

Cheers :+1:


[BUG] Swate Installation and Tutorial links missing

Received via help desk mail on 24.03.2023
Dear DataPlant team,
I am writing you regarding some problems that occured to me while setting up data entries for my research project through the ARC structures.
While trying to install Swate, i encountered the following issues:

the link "Swate in your browser", found here (https://nfdi4plants.github.io/Swate-docs/docs/UserDocs/Docs01-Installing-Swate.html) yields a 404 error site not found (https://nfdi4plants.github.io/Swate-docs/docs/UserDocs/docs/UserDocs/swate_installation_browser.html).
in ARC Commander mini (installer versions 0.3.4 and 0.4.0), the "tutorials" link displayed after generating an ARC regarding the Swate tool displays a 404 at its end location (https://nfdi4plants.org/nfdi4plants.knowledgebase/docs/tutorials/QuickStart_swate.html).

Kind regards,
The user requested feedback to<EMAIL_ADDRESS>

in ARC Commander mini (installer versions 0.3.4 and 0.4.0), the "tutorials" link displayed after generating an ARC regarding the Swate tool displays a 404 at its end location (https://nfdi4plants.org/nfdi4plants.knowledgebase/docs/tutorials/QuickStart_swate.html).

@JonasLukasczyk This is the new link: https://nfdi4plants.org/nfdi4plants.knowledgebase/docs/implementation/QuickStart_swate.html


How to use with mst ?

Hello,
Is it possible to use mobx-persist with mobx-state-tree ?
If so, can you give an example ?
Thanks you

Hi, mobx-state-tree can easily persist store to local storage without any lib. https://github.com/mobxjs/mobx-state-tree/blob/master/packages/mst-example-bookshop/src/stores/CartStore.js#L89-L90

@pinqy520 hey mate I commented on #37

Since it might not be clear to check #37 from this issue, just wanted to note here that per https://github.com/pinqy520/mobx-persist/issues/37#issuecomment-493830440 I've created a separate library for to handle MST called mst-persist :)


Use react-native-fs for all your mobile file fiddling needs

:eye_speech_bubble: @keybase/react-hackers

approved, one other option we could do is just implement this in go and not use this 3rd party


Changing order in example of Functions should only be one level …

Like said in https://github.com/ryanmcdermott/clean-code-javascript#function-callers-and-callees-should-be-close, the code is read from top to bottom, so I'd prefer the definition of the function parseBetterJSAlternative above the functions called within.

Thank you I greatly appreciate your contribution!


lammps installation (intel error)

I am trying to install lammps to use a trained network.
I follow the same process described in READ.md and the lammps configuration goes without any errors.
But when I am building, I am getting this error:
"# error "This Intel  is for use only with the Intel C++ compilers!""
I am loading intel compilers (intel, intel-mpi, intel-mkl)

ok, I think, was able to fix that issue by manually adding "-DCMAKE_CXX_COMPILER=icpc" while configuring lammps. But then, ended up getting the following error during build:
[ 97%] Building CXX object CMakeFiles/lammps.dir/home/vsumaria/software/lammps/src/write_coeff.cpp.o
[ 97%] Building CXX object CMakeFiles/lammps.dir/home/vsumaria/software/lammps/src/write_restart.cpp.o
/home/vsumaria/software/lammps/src/pair_nequip.cpp(97): error #308: member "LAMMPS_NS::NeighRequest::half" (declared at line 55 of "/home/vsumaria/software/lammps/src/neigh_request.h") is inaccessible
neighbor->requests[irequest]->half = 0;
^
/home/vsumaria/software/lammps/src/pair_nequip.cpp(98): error #308: member "LAMMPS_NS::NeighRequest::full" (declared at line 56 of "/home/vsumaria/software/lammps/src/neigh_request.h") is inaccessible
neighbor->requests[irequest]->full = 1;
^
/home/vsumaria/software/lammps/src/pair_nequip.cpp(101): error #308: member "LAMMPS_NS::NeighRequest::ghost" (declared at line 69 of "/home/vsumaria/software/lammps/src/neigh_request.h") is inaccessible
neighbor->requests[irequest]->ghost = 0;
^
compilation aborted for /home/vsumaria/software/lammps/src/pair_nequip.cpp (code 2)
make[2]: *** [CMakeFiles/lammps.dir/build.make:4476: CMakeFiles/lammps.dir/home/vsumaria/software/lammps/src/pair_nequip.cpp.o] Error 2
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [CMakeFiles/Makefile2:713: CMakeFiles/lammps.dir/all] Error 2
make: *** [Makefile:149: all] Error 2

I think was something to do with the version of lammps, I downloaded the 29Sep2021 version, and things are working fine now.


Can't fetch JWT token

Can't get it to work, it can't fetch the token.
% ./beeper-password-reset.ts login-email --email $MY_EMAIL
✔ Enter the challenge code sent to your email: … $EMAIL_CODE_I_GOT

Your JWT Token:  undefined

I don't really know what I'm doing but I skimmed at your code, and tried issuing each reqest with cli curl. It got me the email with one time code just fine but then after
% curl -X POST https://api.beeper.com/user/login/response -H "Authorization: Bearer BEEPER-PRIVATE-API-PLEASE-DONT-USE" -H "Content-Type: application/json" -d '{"request":"REDACTED_REQUEST","response":"EMAIL_CODE_I_GOT"}'

I get {"waitlist":REDACTED_NUMBER} as a response, the number is random with 5 digits and I feel like this is unexpected flow

Do you have a current/active beeper account, or are you on the wait list still? The response makes me think the latter.
I haven't personally tried the flow in a while, so it's possible something changed since I implemented it; but that's definitely not a response I ever experienced at the time.

I have a working account, I've been actively using it for 3 months

Ok, it magically started working now with the same commands it failed 10 minutes ago, probably a server side bug.

True true. Glad it's working for you now!
I'll close this for now, but if it breaks again and you're able to reproduce it, feel free to open this thread again.


Hf models add

Add ability to load HF models via API_TOKEN and MODEL_ID

It is worth drop some prints and correct some minor issues


feat: Prepopulate tstorage for the new version of EvmGasManager

What ❔
Required for https://github.com/matter-labs/era-contracts/pull/738
The logic of prepopulating storage is left for compatibility with the previous version of the contract
Why ❔

Checklist

[ ] PR title corresponds to the body of PR.
[ ] Tests for the changes have been added / updated.
[ ] Documentation comments have been added / updated.
[ ] Code has been formatted via cargo fmt and checked with cargo clippy.

@0xVolosnikov please don't update this branch!
There is a potential bug in CI revealed here. Let us check it first.

@0xVolosnikov , @hedgar2017 , CI is updated, all looks good to me now.


refactor(react/form-elements): universal APIs

Affected components: input, textarea, radio, checkbox, select and switch.
Most native input props are passing via inputProps except value and onChange.
Having this change has below concerns:

id, className and style will be bound to the host element by intuition
following 1., if the component props directly extend input props, the separation of id will be confusing
Considering complicated form elements like Date-picker and Select, it is necessary for them to have inputProps rather than extending it since the behaviours are different. An inputProps prop seems more universal.

issue ref #55


CreateRoute to NetworkInterfaceId has not been implemented in Moto yet

I am getting CreateRoute to NetworkInterfaceId has not been implemented in Moto yet error when trying to create a route:
route = ec2_client.create_route(
            DestinationCidrBlock=pub_subnet.cidr_block,
            NetworkInterfaceId=eniA["NetworkInterface"]["NetworkInterfaceId"],
            RouteTableId=route_table["RouteTable"]["RouteTableId"],
        )

Please add support for NetworkInterfaceId as next hop in routes.
Thank you,

This was implemented in #3063, so I'll close this. Let us know if there's still anything missing.


Add Box::from_corners method

Objective
This add a ctor to Box to aid the creation of non-centred boxes. The PR adopts @rezural's work on PR #3322, taking into account the feedback on that PR from @james7132.
Solution
Box::from_corners() creates a Box from two opposing corners and automatically determines the min and max extents to ensure that the Box is well-formed.

moving to 0.10 as 0.9.1 as this is a new feature


[GHSA-r58r-74gx-6wx3] Nokogiri gem, via libxml, is affected by DoS vulnerabilities

Updates

Affected products

Comments
Per https://github.com/sparklemotion/nokogiri/issues/1714, this should have been addressed in nokogiri v 1.8.2.

#2660 has been merged so hopefully this is fixed soon


PGAudit is missing shared preload library in the default configuration

Describe the bug
The missing configuration must be added to defaults. Otherwise pgaudit will not work.
  extensions:
    pgaudit:
      enabled: yes
      shared_preload_libraries:
        - pgaudit

How to reproduce
Execute epicli apply ... without configuration mentioned above.
Expected behavior
Shared preload libraries should be added by default when pgaudit is installed.
Config files
As above.
Environment

Cloud provider: [All]
OS: [All]

epicli version: [epicli --version]
Additional context
None

DoD checklist

[ ] Changelog updated (if affected version was released)
[ ] COMPONENTS.md updated / doesn't need to be updated
[ ] Automated tests passed (QA pipelines)

[ ] apply
[ ] upgrade

[ ] Case covered by automated test (if possible)
[ ] Idempotency tested
[ ] Documentation updated / doesn't need to be updated
[ ] All conversations in PR resolved
[ ] Backport tasks created / doesn't need to be backported

This task is already done in PR 1383.


Build error

[ 28%] Built target thrift_static
[ 28%] Built target chainbase
[ 28%] Built target eosio_prods_static
Scanning dependencies of target chainbase_test
fatal: No names found, cannot describe anything.
CMake Error at version.cmake:11 (message):
git describe failed
libraries/appbase/CMakeFiles/appbase_version.dir/build.make:57: recipe for target 'libraries/appbase/CMakeFiles/appbase_version' failed
make[2]: *** [libraries/appbase/CMakeFiles/appbase_version] Error 1
CMakeFiles/Makefile2:5525: recipe for target 'libraries/appbase/CMakeFiles/appbase_version.dir/all' failed
make[1]: *** [libraries/appbase/CMakeFiles/appbase_version.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....
warning: [options] source value 6 is obsolete and will be removed in a future release
warning: [options] target value 1.6 is obsolete and will be removed in a future release
warning: [options] To suppress warnings about obsolete options, use -Xlint:-options.
3 warnings
Fatal Error: Unable to find package java.lang in classpath or bootclasspath
[ 29%] Linking CXX shared library libfc.so
libraries/vm/vm_java/CMakeFiles/vm_java.dir/build.make:70: recipe for target 'libraries/vm/vm_java/VMMain.class' failed
make[2]: *** [libraries/vm/vm_java/VMMain.class] Error 3
CMakeFiles/Makefile2:4200: recipe for target 'libraries/vm/vm_java/CMakeFiles/vm_java.dir/all' failed
make[1]: *** [libraries/vm/vm_java/CMakeFiles/vm_java.dir/all] Error 2
/usr/bin/ld: /usr/local/lib/libsecp256k1.a(libsecp256k1_la-secp256k1.o): relocation R_X86_64_PC32 against symbol `stderr@@GLIBC_2.2.5' can not be used when making a shared object; recompile with -fPIC
/usr/bin/ld: final link failed: Bad value
clang: error: linker command failed with exit code 1 (use -v to see invocation)
libraries/fc/CMakeFiles/fc.dir/build.make:1544: recipe for target 'libraries/fc/libfc.so' failed
make[2]: *** [libraries/fc/libfc.so] Error 1
CMakeFiles/Makefile2:5883: recipe for target 'libraries/fc/CMakeFiles/fc.dir/all' failed
make[1]: *** [libraries/fc/CMakeFiles/fc.dir/all] Error 2
[ 29%] Building CXX object libraries/chainbase/test/CMakeFiles/chainbase_test.dir/test.cpp.o
[ 29%] Linking CXX executable chainbase_test
[ 29%] Built target chainbase_test
Makefile:162: recipe for target 'all' failed
make: *** [all] Error 2
>>>>>>>>>>>>>>>>>>>> MAKE building EOSIO has exited with the above error.

update cmake to 3.10.20171129 or above
git submodule update --init --recursive
export JAVA_HOME=
4.rename /usr/local/lib/libsecp256k1.a to other name
Sorry for the inconvenience, I'm developing on mac os x, so don't hesitate to report to me if you have encountered more build problems.

I'm using cmake 3.10.2

After "java --version", it return "openjdk 10.0.2 2018-07-17". Should i set 'JAVA_HOME'??

Before "git submodule update --init --recursive", should i delete 'externals' folder??

I still have these error...
[ 28%] Built target hera-buildinfo-git
[ 28%] Generating VMMain.class
[ 28%] Built target chainbase
[ 28%] Built target eosio_prods_static
Scanning dependencies of target fc
fatal: No names found, cannot describe anything.
CMake Error at version.cmake:11 (message):
git describe failed
libraries/appbase/CMakeFiles/appbase_version.dir/build.make:57: recipe for target 'libraries/appbase/CMakeFiles/appbase_version' failed
make[2]: *** [libraries/appbase/CMakeFiles/appbase_version] Error 1
CMakeFiles/Makefile2:5525: recipe for target 'libraries/appbase/CMakeFiles/appbase_version.dir/all' failed
make[1]: *** [libraries/appbase/CMakeFiles/appbase_version.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....
warning: [options] source value 6 is obsolete and will be removed in a future release
warning: [options] target value 1.6 is obsolete and will be removed in a future release
warning: [options] To suppress warnings about obsolete options, use -Xlint:-options.
[ 28%] Built target aleth-buildinfo-git
[ 28%] Building CXX object libraries/fc/CMakeFiles/fc.dir/src/crypto/elliptic_impl_priv.cpp.o
[ 28%] Building CXX object libraries/fc/CMakeFiles/fc.dir/src/crypto/elliptic_secp256k1.cpp.o
3 warnings
Fatal Error: Unable to find package java.lang in classpath or bootclasspath
libraries/vm/vm_java/CMakeFiles/vm_java.dir/build.make:70: recipe for target 'libraries/vm/vm_java/VMMain.class' failed
make[2]: *** [libraries/vm/vm_java/VMMain.class] Error 3
CMakeFiles/Makefile2:4200: recipe for target 'libraries/vm/vm_java/CMakeFiles/vm_java.dir/all' failed
make[1]: *** [libraries/vm/vm_java/CMakeFiles/vm_java.dir/all] Error 2
[ 29%] Linking CXX shared library libfc.so
[ 31%] Built target fc
Makefile:162: recipe for target 'all' failed
make: *** [all] Error 2
>>>>>>>>>>>>>>>>>>>> MAKE building EOSIO has exited with the above error.

[ 28%] Generating VMMain.class
[ 28%] Built target eosio_prods_static
fatal: No names found, cannot describe anything.
CMake Error at version.cmake:11 (message):
git describe failed
libraries/appbase/CMakeFiles/appbase_version.dir/build.make:57: recipe for target 'libraries/appbase/CMakeFiles/appbase_version' failed
make[2]: *** [libraries/appbase/CMakeFiles/appbase_version] Error 1
CMakeFiles/Makefile2:5525: recipe for target 'libraries/appbase/CMakeFiles/appbase_version.dir/all' failed
make[1]: *** [libraries/appbase/CMakeFiles/appbase_version.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....
Scanning dependencies of target fc
[ 28%] Built target aleth-buildinfo-git
warning: [options] source value 6 is obsolete and will be removed in a future release
warning: [options] target value 1.6 is obsolete and will be removed in a future release
warning: [options] To suppress warnings about obsolete options, use -Xlint:-options.
3 warnings
Fatal Error: Unable to find package java.lang in classpath or bootclasspath
[ 28%] Building CXX object libraries/fc/CMakeFiles/fc.dir/src/crypto/elliptic_impl_priv.cpp.o
[ 28%] Building CXX object libraries/fc/CMakeFiles/fc.dir/src/crypto/elliptic_secp256k1.cpp.o
libraries/vm/vm_java/CMakeFiles/vm_java.dir/build.make:70: recipe for target 'libraries/vm/vm_java/VMMain.class' failed
make[2]: *** [libraries/vm/vm_java/VMMain.class] Error 3
CMakeFiles/Makefile2:4200: recipe for target 'libraries/vm/vm_java/CMakeFiles/vm_java.dir/all' failed
make[1]: *** [libraries/vm/vm_java/CMakeFiles/vm_java.dir/all] Error 2
[ 29%] Linking CXX shared library libfc.so
[ 31%] Built target fc
Makefile:162: recipe for target 'all' failed
make: *** [all] Error 2
>>>>>>>>>>>>>>>>>>>> MAKE building EOSIO has exited with the above error.

Something went wrong in getting version info in appbase CMakeLists.txt
Since I can't replicate these error on my laptop, you can try the following steps:
1. export JAVA_HOME= or upgrade jdk to at least version 10 and point JAVA_HOME to jdk 10, I suggest you just use "export JAVA_HOME="
2. update git to version 2.15.2 or above, as this is the git version I'm using.
3. rm -rf build;./eosio_build.sh to rebuild pyeos
4. clone pyeos to a new directory and rebuild

Thanks for the report and good luck.


iOS: stream of stories

In the web app, the rightmost pane shows a continuous stream of stories, instead of just one at a time.  This could be done in the iOS app as an optional alternative to the paged stories.
For performance, it'd make sense to work similar to the feed detail list: load a few stories, and dynamically load more as the user scrolls.

This is basically the same as vertical scrolling between stories in #1100, so I'll close it.


C++ integration of models built with Fold

I have seen that Fold is partially implemented in C++, but I'm not sure exactly what parts are. I am using TensorFlow to build and train models, "freeze" them into a self-contained GraphDef and export them to run in a C++ application. Currently I only need the C++ side of TensorFlow to run it. If I build a model with Fold, would I be able to export it in the same way and run it in C++? Or would I also need to include the C++ part of Flow into my application? Or maybe the best route would be to take the trained weights and put them into a simple TensorFlow model for exporting?

Currently you cannot run Fold models in C++.  The loom library will build a
TensorFlow graph that you could potentially export to a GraphDef.  However,
the inputs to the TensorFlow graph are tables of indices that encode the
structure of the trees (e.g. parse trees) that you are feeding as inputs to
the model.  The code which traverses those trees, and builds the indices,
is currently written in python: the blocks library.
On Mon, Feb 27, 2017 at 2:27 AM, Javier Dehesa<EMAIL_ADDRESS>wrote:

I have seen that Fold is partially implemented in C++, but I'm not sure
exactly what parts are. I am using TensorFlow to build and train models,
"freeze" them into a self-contained GraphDef and export them to run in a
C++ application. Currently I only need the C++ side of TensorFlow to run
it. If I build a model with Fold, would I be able to export it in the same
way and run it in C++? Or would I also need to include the C++ part of Flow
into my application? Or maybe the best route would be to take the trained
weights and put them into a simple TensorFlow model for exporting?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/tensorflow/fold/issues/24, or mute the thread
https://github.com/notifications/unsubscribe-auth/AGGbTdT97OkXi-6PPfJlkzsv5aXFssnmks5rgqUlgaJpZM4MM7ss
.

--
DeLesley Hutchins | Software Engineer |<EMAIL_ADDRESS>|<PHONE_NUMBER>

To expand on delesley's answer, if you want to run in pure C++ you need to build your graphs using only the low-level API for fold, Loom API. In this approach you will need to write the code that traverses your inputs (e.g. trees) and builds the indices yourself, as a custom op; the recommended way to do this is by subclassing WeaverOpBase.
This is a bit more work that the blocks API and considerably more error prone due to the weaker type checking, but of course offers benefits in terms of performance and flexibility. One approach you could take would be to use the blocks API as a prototyping tool, then reimplement with loom once you have settled on a good architecture.


Websocket support

After startup, open a websocket with URL /pushlistener?clientId=
If server sends updates, you'll receive a message like api/changes
The message is a command.
Simply support the api/changes command and send the api/changes request to get all changes from the server.
A specific PushWorkScreen is available for test purposes.

Example is available: http://localhost/JVx.mobile/websocket.html


Share on linked in doesn't work

Thanks for this package,
It's working properly except for the LinkedIn. When I click on LinkedIn share button The URL generated is  something like this:
https://www.linkedin.com/sharing/share-offsite/?mini=true&url=https://staging.medeventus.com/events/66/Medeventus First Event
and LinkedIn page says: Something went wrong
Would  you please help me to solve this issue?

I have got the same issue. Kindly fix it.
Also Facebook, Twitter and LinkedIn share is not opening on new tab like whatsapp and telegram

I don't have the time for it, but feel free to open a PR to fix this problem and a working test suite

@TasneemWahdan i am also facing same issue, have you fixed it ??

@Hashir12 I used addThis for sharing

The same problem

I am using the package and LinkedIn share is working now!
make sure to include these into website's head section:
    <meta property='og:title' content='Title of the article'/>
    <meta property='og:image' content='//media.example.com/ 1234567.jpg'/>
    <meta property='og:description' content='Description that will show in the preview'/>
    <meta property='og:url' content='//www.example.com/URL of the article'/>

and clear the browser's cache  since  the error may appear there, or use another device to check


Fix login to do without GALX

Google is no longer serving GALX on the login page.  The fix is simple: just
remove GALX.

Good find.  GALX should also be removed from lines 84, 85, and 89.

Thanks, working !

Thanks, chris001.  I fixed 84, 85, and 89 as well.


Final review modal is showing @expensify.sms for Users with Phone Numbers as their login

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Login to newDot
Request money from an account who has phone number as their login
Enter amount and Continue
You will see @expensify.sms after the phone number

Expected Result:
Should show only the phone number

Actual Result:

Workaround:
Visual Issue.
Platform:

Where is this issue occurring?

Web
iOS
Android
Desktop App
Mobile Web

Version Number:
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
View all open jobs on Upwork

Triggered auto assignment to @sakluger (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

Proposal

To remove the smsDomain we need to pass alternateText: Str.removeSMSDomain(participant.login) here
https://github.com/Expensify/App/blob/ec38ff9574ff9f1ac997b29b871aaf13afc5d57e/src/libs/OptionsListUtils.js#L580

@sakluger Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

Thanks for creating this issue @aman-atg! I'm reviewing the issue now.

Triggered auto assignment to @roryabraham (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

This issue is unique and the suggested behavior is in line with what we did in this related issue.
This should be able to be handled by an external contributor.
The su

Triggered auto assignment to @arielgreen (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

Putting on hold for a week-ish

Triggered auto assignment to @chiragsalian (Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

Job posted https://www.upwork.com/jobs/~01b9648852c0022ec5
@chiragsalian will you review @aman-atg 's proposal above? Thx

I just tried this on dev and i don't see @expensify.sms next to the phone number

Also tried it on production and i don't see the issue,

Might be some old issue. @aman-atg can you confirm, if the issue does not exist let's close this GH issue.

@chiragsalian It's still happening.
I think you should try with a real number that has an account.

Weird, i don't see it for the same number you provided.

Maybe its because you have first and last name loaded. Trying that next,
I created a phone account with test aug17th as the name but i don't see expensify.sms domain.

Trying your account, i also don't see expensify.sms. lol, weird.

I just cleared my cache and retested,

So i'm a little unsure how you are getting the issue. Did you also try on google chrome and did you clear your cache?

@mallenexpensify are you also able to reproduce the issue?

No, unable to reproduce

Did you also try on google chrome and did you clear your cache?

Well, this is a bizarre situation.. I tried with chrome as well and cleared my cache.
Even tried on a different machine.

I think it's only occurring when we request money directly from the chat.
Video for reference.
https://user-images.githubusercontent.com/28243942/129894295-b378d8da-ab50-419c-be81-f2f137c675a2.mp4
If it's still not reproducible then we can maybe close this for now.

I was able to reproduce! Just took a handful of tries.

open staging.new.expensify.com in chrome.
go to chat with a user where their account login is a phone number
click the plus icon next to the compose box (not the big green one)
enter amount
observe expensify.sms at end of username.

I cleared my local storage and signed out/back in and the issue persists.
@chiragsalian can you test the above steps, try to reproduce, and if so... review @aman-atg 's proposal to fix?

Proposal
I propose that we fix the original change that caused this. In newDot we trim the SMS domain from phone numbers while preparing data options for the viewing purpose. Every component follows that. But I see that this https://github.com/Expensify/App/pull/3651 PR added this to fix the issue with IOU Creation but at that time we didn't think of this regression.

To Keep the app consistent, we remove the logic to add the SMS domain to options from here https://github.com/Expensify/App/blob/ec38ff9574ff9f1ac997b29b871aaf13afc5d57e/src/libs/OptionsListUtils.js#L109.
Then we fix the https://github.com/Expensify/App/issues/3614 we add the SMS domain while passing the logins to createIOUTransaction. This is the same pattern we are following in WorkspaceInvitePage.js https://github.com/Expensify/App/blob/2b57f0fac59d007441fb170fd05445d83392ed86/src/libs/actions/Policy.js#L152

Why do this?
As we create the first drop SMS domain while creating options for the listing and then we are re-adding the SMS domain here and again if remove the SMS Domain from here https://github.com/Expensify/App/blob/ec38ff9574ff9f1ac997b29b871aaf13afc5d57e/src/libs/OptionsListUtils.js#L580. It is so confusing to manage. The main source of the data should only be one location OptionsListUtils file. This is the reason we create options for each component from this module only.
https://github.com/Expensify/App/blob/ec38ff9574ff9f1ac997b29b871aaf13afc5d57e/src/libs/OptionsListUtils.js#L191

@chiragsalian, @mallenexpensify it looks like no one is assigned to work on this job.
Please double the price or add a comment stating why the job isn't being doubled.

Yup, i can reproduce the issue when i request for money within the chat. Previously i had only tried it via the big green one. Cool, looks like a real issue.
I like @parasharrajat, @mallenexpensify can you hire him on upwork.
@parasharrajat, feel free to create the PR.

@chiragsalian , since @aman-atg created the issue, we often them allow them "first dibs" to have their proposal reviewed.  Can you confirm that you've reviewed @aman-atg proposal above and, if you choose to not go with it, provide a synopsis of why not?  Thx

Oh hahaha, I just realized I didn't complete my thought earlier and just wrote,

I like @parasharrajat
😂  😂

Lol, i meant to say,

I like @parasharrajat solution because I'd like the data to exist cleanly in login without sms domain, than pass an additional correct value to alternate text.

@parasharrajat , can you submit a proposal in Upwork and I'll hire? https://www.upwork.com/jobs/~01b9648852c0022ec5. Please confirm in a message here once you have

@mallenexpensify Done.

Hired in Upwork, assigned to @parasharrajat , removed Help Wanted label...

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by @Julesssss in version: 1.0.90-3 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

Paid @parasharrajat in Upwork


Ephemeral/generic

Added ephemeral volume provisiong

Let's consider next steps...
We need to make changes for 1.16 (https://github.com/kubernetes-csi/docs/pull/209/files):

extend driver info to include volumeLifecycleModes: persistent, ephemeral in a new deployment for 1.16
enable pod info
in the code which decides between "ephemeral" and "persistent" check podinfo for csi.storage.k8s.io/ephemeral and if set, use that (and only that); if not set, use the heuristic

We need automated testing on 1.16. @okartau, you were working on an extension of our test cluster setup for Cent OS + Kubernetes 1.16, right? Is that ready for merging?

extend driver info to include volumeLifecycleModes: persistent, ephemeral in a new deployment for 1.16

We can deal this volumeLifecycleModes change as part of Kubernetes 1.16 deployment change. This shouldn't effect v1.15.

enable pod info

our deployment already  using podInfoOnMount: true,

in the code which decides between "ephemeral" and "persistent" check podinfo for csi.storage.k8s.io/ephemeral and if set, use that (and only that); if not set, use the heuristic

This check is already part of this change. In addition to make it work for v1.15, we provision ephemeral only volume if all below conditions are met:

Volume with given volume-id is not found
Missing StagingTargetPath in the NodePublishRequest
No provisioner information in NodePlubishRequest.VolumeContext

Amarnath Valluri<EMAIL_ADDRESS>writes:

extend driver info to include volumeLifecycleModes: persistent, ephemeral in a new deployment for 1.16

We can deal this volumeLifecycleModes change as part of Kubernetes
1.16 deployment change. This shouldn't effect v1.15.

Instead of merging a feature where we know that additional changes will
be needed soon, I prefer to do it all at once. Then we only need to go
through the code once and know that the current code really works in all
cases instead of assuming that it does.

All PRs are now getting tested against 1.16 (on Fedora) and against 1.15 (on Clear). Can you update the PR such that it works with both?
To start a cluster with 1.16 locally, use TEST_DISTRO=fedora TEST_KUBERNETES_VERSION=1.16 make start.

Let's support 1.16 from the start, i.e. avoid accumulating technical debt.

I have pushed the 1.16 deployment changes.

Do we have tests? Probably we need to vendor Kubernetes 1.16.0 first, then we can enable these tests: https://github.com/kubernetes/kubernetes/blob/master/test/e2e/storage/testsuites/ephemeral.go

Instead of copying quite a few files into deploy/kustomize/kubernetes-1.16-* dirs, would it be possible to take the existing Kubernetes 1.15 deployment and just patch the volumeLifecycleField in?

Do you mean something this:
avalluri@099d91d

Yes, exactly what I had in mind - thanks for turning it into code :-)
But comments are currently inconsistent, some of them look like copy-and-paste leftovers. I think it is enough to have one README.md in the deploy/kubernetes-1.16 directory that explains the difference and then drop all other comments from the directories and kustomization.yaml files underneath it.
Another nit: also check the file endings in those file - sometimes you have two line breaks, sometimes one, sometimes none.
Ending a file with a line break looks best IMHO.

I just pushed a new revision, that covers all these review comments.

devicemanager: Make GetDevice() return pointer

Why?

Enabled ephemeral testsuite and made changes to ListVolumes() implementation so that it does not return ephemeral volumes.

The question around checking for os.ErrNotExit is also still open.

Now the code uses os.IsErrorNotExist() call, which does the digging and checks for real error. This should address the unwrapping issue you pointed.

The question around checking for os.ErrNotExit is also still open.
Now the code uses os.IsErrorNotExist() call, which does the digging and checks for real error. This should address the unwrapping issue you pointed.

Hmm, where do you see that os.IsErrorNotExist unwraps errors? The API only says "It is satisfied by ErrNotExist as well as some syscall errors" and the source code confirms that (https://golang.org/src/os/error.go#L92). Errors that wrap ErrNotExist are opaque to it, as the following test program confirms:
package main

import (
	"fmt"
	"github.com/pkg/errors"
	"os"
)

func main() {
	err := errors.Wrap(os.ErrNotExist, "wrapping")
	fmt.Printf("%q: os.IsNotExists %v, os.IsNotExists(errors.Cause) %v\n",
		err,
		os.IsNotExist(err),
		os.IsNotExist(errors.Cause(err)))
}

$ go run ./error.go
"wrapping: file does not exist": os.IsNotExists false, os.IsNotExists(errors.Cause) true

Hmm, where do you see that os.IsErrorNotExist unwraps errors?

Sorry, I did not update the comment. I later figured out that it does not unwrap, but I already updated the code to use errors.Cause().


✨ try improving join performance

# cython: language_level=3
import cython
import numpy as np
from cython import Py_ssize_t

cimport numpy as cnp
from numpy cimport int64_t, ndarray

cnp.import_array()

@cython.boundscheck(False)
def cython_inner_join(
        const int64_t[:] left_idxs, const int64_t[:] right_idxs,
        const int64_t[:] left_counts, const int64_t[:] right_counts,
        const int64_t[:] left_bidxs, const int64_t[:] right_bidxs):

    """ this is referred to as the HASH join in Opteryx """

    cdef:
        Py_ssize_t i, li, ri, rows = 0, p = 0
        int64_t cats, lbi, rbi, lc, rc, lp, rp
        ndarray[int64_t, ndim=1] left_align, right_align

    cats = left_counts.shape[0]
    for i in range(cats):
        lc = left_counts[i]
        rc = right_counts[i]
        rows += lc * rc

    left_align = np.empty(rows, dtype=np.int64)
    right_align = np.empty(rows, dtype=np.int64)

    with nogil:
        for i in range(cats):
            lc = left_counts[i]
            rc = right_counts[i]
            if lc > 0 and rc > 0:
                lbi = left_bidxs[i]
                for li in range(lc):
                    rbi = right_bidxs[i]
                    for ri in range(rc):
                        lp = left_idxs[lbi]
                        rp = right_idxs[rbi]
                        left_align[p] = lp
                        right_align[p] = rp
                        rbi += 1
                        p += 1
                    lbi += 1
    return left_align, right_align

@cython.boundscheck(False)
def cython_left_join(
        const int64_t[:] left_idxs, const int64_t[:] right_idxs,
        const int64_t[:] left_counts, const int64_t[:] right_counts,
        const int64_

Improvements can be made to the hash code that creates the hashes that go into the join.
The below code is roughly 2x faster than the existing implementation.
def hasher(vals):
    if numpy.issubdtype(vals.dtype, numpy.character):
        return numpy.array([CityHash64(s.encode()) for s in vals], numpy.uint64)
    return vals


Localization

It'd be nice if there was a way to specify the strings used for the hours/dates/minutes/etc. so that other languages could work with this module.

Mostly, it'd be nice if we configure things in a similar way to human-interval

Would a PR be welcome?

No thanks. I would prefer to keep this module simple.

Hey @RangerMauve,
I made a gist for custom time units :
https://gist.github.com/vaidd4/0d83ddba3fb218bb2a7949a4b93ee686
It just adds an optional parameter units. it's not the best implementation but will surely satisfy basic needs for other languages.

@vaidd4 Could you publish it as a module which depends on pretty-ms so that it'd be easier for people to use? Maybe call it something like localized-pretty-ms?

@RangerMauve thanks for the interest, I may try to do so this week-end.
But this gist is far from an ideal alternative for this module to get localized units.
Hi @sindresorhus , would you consider adding personalized units (instead of complete localization) ? (you can look at my gist for some inspiration)

@vaidd4 Sorry no, I don't want to complicate it. Localization also doesn't always work directly 1:1. So in some cultures, there would be a need for something more advanced. I just don't want to deal with this.


Improve pseudo-transaction handling (RIPD-1454, RIPD-1455)

Adds additional checks and improves error messages related to pseudo-transactions.

Codecov Report

Merging #2104 into develop will increase coverage by <.01%.
The diff coverage is 77.77%.

@@             Coverage Diff             @@
##           develop    #2104      +/-   ##
===========================================
+ Coverage    68.84%   68.85%   +<.01%
===========================================
  Files          684      684
  Lines        50367    50370       +3
===========================================
+ Hits         34674    34681       +7
+ Misses       15693    15689       -4

Impacted Files
Coverage Δ

src/ripple/app/consensus/RCLConsensus.cpp
63.09% <0%> (-0.32%)
:arrow_down:

src/ripple/protocol/impl/STTx.cpp
81.41% <100%> (+0.25%)
:arrow_up:

src/ripple/protocol/TxFormats.h
100% <100%> (ø)
:arrow_up:

src/ripple/app/tx/impl/applySteps.cpp
77.01% <100%> (-0.56%)
:arrow_down:

src/ripple/beast/asio/io_latency_probe.h
97.01% <0%> (-1.5%)
:arrow_down:

src/ripple/server/impl/BaseWSPeer.h
67.5% <0%> (-0.63%)
:arrow_down:

src/ripple/core/impl/JobQueue.cpp
85.71% <0%> (-0.47%)
:arrow_down:

src/ripple/ledger/impl/ReadView.cpp
83.33% <0%> (+2.77%)
:arrow_up:

src/ripple/app/tx/impl/Change.cpp
80.37% <0%> (+6.54%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1dbc5a5...821b495. Read the comment docs.

Thanks @ximinez, I like the changes you suggested!  One question above before I fold in your changeset.

Merged as f2787dc35c8669baee29a443b2d4ea533621c891


Crash on opening or closing a project

Lapce Version
Lapce 0.2.6, macOS dmg downloaded from GitHub releases
System information
macOS Monterey, MBA with M2 CPU
Describe the bug
Crash on closing, opeining, or changing a folder with a basic Python project.
Additional information
Other information that can be used to further reproduce or isolate the problem.
This commonly includes:

screenshots
logs
theories about what might be going wrong
workarounds that you used
plugins installed

Plugins installed:

Ayu
Aleph
Aura Theme
Catppuccin
Alabaster
Material Icon theme
Visual Studio Code Themes
Tokio Night
Rust
Python (python-lsp-server)

Apple crash log
https://gist.github.com/eirnym/6403efd2e35b62679ef7ae6a04f9b0ed

Duplicate of #2200


j.l.Class.isInstance does not work for raw JS classes

The following does not work as expected:
val cls = classOf[dom.HTMLElement]
println(cls.isInstance(dom.document.getElementById("foo")))

It always displays false because it tries to perform the type test as if HTMLElement were a Scala.js class.
We could fix this by providing a custom isInstance function to the type data of raw JS classes.
For raw JS traits, there's nothing we can do, since isInstanceOf itself is not supported.
Fixing this is a prerequisite for #1430.

The IR does not contain the information necessary to implement this feature. We would need the ClassDef of a raw JS class to retain the FQN of the JavaScript constructor behind it, which, due to @JSName, cannot be inferred from the class' encodedName. We don't even have a proper place in the ClassDef to store this information ...
I'm not sure yet what I want to do with this.


[Feature request] Make input textarea more bigger

This app is amazing, but it have small UI issues, font preview textarea is too small, with bigger font size, and I can't understand how font looks for specific text (if text is longer, some phrase or slogan)
So, just add possibility to:

Change textarea font size;
Change textarea size, or maybe instead letter preview put textarea view, and let user choose what he need, I think for more people to preview text is more important than just a some letter.

Thank you.

Thanks for the feedback! There are a few options here that might suit your case:

1 - You can hide the letter preview area entirely by clicking this button in the "..." menu
2 - You can resize the the area using the column dragger
3 - You can switch to the type ramp view using this button, which might be more appropriate for you
Type Ramp View:

If none of these work for you I can consider adding something else, let me know what you think.


Step over and Step in are quite slow

Testing https://github.com/microsoft/vscode/issues/127362

Start debugging jupyter notebook
Step over a variable definition
🐛 The entire watch variables flashes and it takes a solid second before the next line is hit

I can confirm that step over is much slower than it was earlier

I see it too, maybe its related to the timer and spinner fix?


Adjust num_classes to custom dataset

I am training your model for instance segmentation on my own dataset and saw that there are 3 mentions of num_classes in the config:
MODEL:
  DDETRS:
    NUM_CLASSES: null
  RETINANET:
    NUM_CLASSES: 80
  ROI_HEADS:
    NUM_CLASSES: 80
  SEM_SEG_HEAD:
    NUM_CLASSES: 54

Which have to be adjusted for the instance segmentation task?
Anything else has to be adjusted?
Thank you very much for this fascinating project.

@cristof-r Hi, for UNINEXT, we only use MODEL.DDETRS, so NUM_CLASSES is always null. You can refer to objects365_v2.py to custom your own datasets.

Thank you very much for the fast reply. I will look into that.

@cristof-r can you tell steps to train with your own data?


Sonoff zb bridge and zb sensors

Hello!
I have noticed that all my sonoff devices work in local and cloud mode except the zigbee bridge (sonoff too) and the temperature sensors it manages (sonoff too). This sensor only work on cloud mode
Do you have to do any extra config for these devices? I see the configs documentation for RF bridge (but this is not my model)
Thanks

+1 same problem. Stopped working since latest HA version.  All the wifi devices are online and work as before, only zigbee looks affected.
Logs showing:
Logger: custom_components.sonoff.sonoff_cloud
Source: custom_components/sonoff/sonoff_cloud.py:256
Integration: Sonoff (documentation, issues)
First occurred: January 13, 2022, 23:31:12 (1 occurrences)
Last logged: January 13, 2022, 23:31:12
Cloud WS Connection error: Cannot connect to host <IP_ADDRESS>:8080 ssl:False [Connect call failed ('<IP_ADDRESS>', 8080)
Kind regards
Y

Sorry, yvesdemoerloos I did not express myself correctly, English is not my language. My zb sensors work perfectly in HA in cloud mode but not in local mode. I realized this last night (around the same time as your error) because the sonoff server in my area was out and my lights and switches were working with HA but the zigbee devices were not. Looking at the attributes I saw that it only put "cloud mode"

@jbega Sonoff zigbee devices only work via the cloud. This is written in the documentation

Yeah, my bad, apologies. Zigbee hub was on a smartplug which must have
given up around the moment of the upgrade. Murphy does exist! 😊
On Fri, Jan 14, 2022, 22:10 jbega @.***> wrote:

Sorry, yvesdemoerloos I did not express myself correctly, English is not
my language. My zb sensors work perfectly in HA in cloud mode but not in
local mode. I realized this last night (around the same time as your error)
because the sonoff server in my area was out and my lights and switches
were working with HA but the zigbee devices were not. Looking at the
attributes I saw that it only put "cloud mode"
—
Reply to this email directly, view it on GitHub
https://github.com/AlexxIT/SonoffLAN/issues/676#issuecomment-1013475757,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ASQLJUBZQNOH5YV2OVTVOF3UWCGOBANCNFSM5L7JP2EQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you commented.Message ID:
@.***>


Making Dropdown Menu and Associated Dialogs Have the Dark Backdrop

This should be more consistent with other dialogs within the app. These still are not 'modals' in the pure sense where clicking outside of them would do nothing (clicking outside of these will actually close them), which is more consistent with the typical dropdown behavior as the mock originally intended.

This change is

Awesome!  :+1:


Maze Generator Issue with UE5.1, perhaps user error. but

Perhaps I am doing this wrong,   I drop the BP onto UE5.1 and set the size.  When in the editor it looks right except part of the walls are not drawing correctly.
When I run the level, the maze continuously  redraws the maze, instead of the maze that I dropped on the setup.
HELP, probably me doing something wrong.

Hi!
In the BP_Maze there is some loop logic that being executed (for example
sake).
Hope this helps!
On Mon, 5 Dec 2022, 05:33 EdwardWelborn, @.***> wrote:

Perhaps I am doing this wrong, I drop the BP onto UE5.1 and set the size.
When in the editor it looks right except part of the walls are not drawing
correctly.
When I run the level, the maze continuously redraws the maze, instead of
the maze that I dropped on the setup.
HELP, probably me doing something wrong.
[image: mazegeneratorissue]
https://user-images.githubusercontent.com/45338915/205536656-e404a022-0bb5-4183-9663-0164c8177e64.jpg
—
Reply to this email directly, view it on GitHub
https://github.com/1owkeyme/UE5-MazeGeneratorPlugin/issues/13, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/A2RHPV5VKYBWJUIISYYQSTDWLVH73ANCNFSM6AAAAAASTXSKZA
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

And by the way. Your wall mesh should be "square", i.e. the same on all sides!


should we allow prereleases when resolving packages

Downstream certain prebuilt wheels have prerelease versions and by default the resolver does not consider prerelease candidates: https://packaging.pypa.io/en/stable/specifiers.html#packaging.specifiers.Specifier.contains
Should we allow prerelease candidates by default? Or should we only allow it for prebuilt wheels?

We will follow the default pip behavior and use constraints to allow for prereleases. So fromager must allow prereleases while checking for constraints


The new types definitions of takeLatest and takeEvery display errors when used as parameter in fork

Hi,
I’m using redux-saga with react 16.0 and typescript 2.6.1. I just updated redux saga from 0.14.8 to 0.16.0 and I have got issues to use this instruction : fork(takeLatest, <Name of the action>, <function generator>)
Here is a sample of the code :
function* deletePermissionStarted(action: { payload: { id: string; accessToken: string } }) {
  const inputParams = action.payload;
  try {
    const f = yield call(permissionApi.DeleteAsync, action.payload.id, action.payload.accessToken);

    yield put(
      permissionActions.deletePermission.done({
        params: inputParams,
        result: f,
      }),
    );
  } catch (e) {
    swal(
      'Erreur',
      "Une erreur s'est produite lors de la suppresion." +
        "Si le problème persiste, veuillez contactez l'administrasteur !",
      'error',
    );
    yield put(
      permissionActions.loadPermissions.failed({
        params: { accessToken: action.payload.accessToken },
        error: e.message,
      }),
    );
  }
}

export function* permissionSaga() {
  yield [
    fork(takeLatest, permissionActions.deletePermission.started.type, deletePermissionStarted)
  ];
}

This code works without issues in the version 0.14.8 and the version 0.16.0 but in the version 0.16.0 I’ve got this message in the terminal and in VS Code.
[at-loader] ./src/permissions/permissionSagas.ts:167:10
    TS2345: Argument of type '{ <A extends Action>(pattern: Pattern, worker: HelperFunc0<A>): ForkEffect; <A, T1>(pattern: Patt...' is not assignable to parameter of
type 'CallEffectNamedFn<{ [x: string]: Func2<string, (action: { payload: { id: string; accessToken: str...'.
  Type '{ <A extends Action>(pattern: Pattern, worker: HelperFunc0<A>): ForkEffect; <A, T1>(pattern: Patt...' is not assignable to type '{ context: { [x: string]: Func2<string, (action: { payload: { id: string; accessToken: string; };...'.
    Property 'context' is missing in type '{ <A extends Action>(pattern: Pattern, worker: HelperFunc0<A>): ForkEffect; <A, T1>(pattern: Patt...'.

How can I fix it?

@aikoven any idea what has changed?

What you have encountered is a weak point of TS compiler error reporting. In a case when TS fails to match against a union of types, it shows an error regarding the last type of the union. The same goes with overloaded signatures.
In your particular case the problem type is this:
// redux-saga/effects.d.ts#152
export type CallEffectFn<F extends Function> =
  F | [any, F] | {context: any, fn: F};

Try to comment out all union members except for F and see what error you get.

@aikoven if I comment all union members in line 152 except F  of effect.d.ts ; I've got this error message :
TS2345: Argument of type '{ <A extends Action>(pattern: Pattern, worker: HelperFunc0<A>): ForkEffect; <A, T1>(pattern: Patt...' is not assignable to parameter of type 'CallEffectNamedFn<{ [x: string]: Func0; }, string>'.
  Type '{ <A extends Action>(pattern: Pattern, worker: HelperFunc0<A>): ForkEffect; <A, T1>(pattern: Patt...' is not assignable to type '[{ [x: string]: Func0; }, string]'.
    Property '0' is missing in type '{ <A extends Action>(pattern: Pattern, worker: HelperFunc0<A>): ForkEffect; <A, T1>(pattern: Patt...'.

I also try to comment union members in line 157 like this,
export type CallEffectNamedFn<C extends {[P in Name]: Function},
                              Name extends string> =
  [C, Name] // | {context: C, fn: Name};

I've got this error message:
 TS2345: Argument of type '{ <A extends Action>(pattern: Pattern, worker: HelperFunc0<A>): ForkEffect; <A, T1>(pattern: Patt...' is not assignable to parameter of type '[{ [x: string]: Func0; }, string]'.
  Property '0' is missing in type '{ <A extends Action>(pattern: Pattern, worker: HelperFunc0<A>): ForkEffect; <A, T1>(pattern: Patt...'.

Then I also tried to comment the lines from 176 to 200 in the same file like this
/* <C extends {[P in N]: Func0}, N extends string>( ... ...rest: any[]): R; */

I've got this error
TS2345: Argument of type '{ <A extends Action>(pattern: Pattern, worker: HelperFunc0<A>): ForkEffect; <A, T1>(pattern: Patt...' is not assignable to parameter of type 'Func0'.

Then I tried to change the line of the same file from
(fn: CallEffectFn<Func0>): R;

to
(fn: CallEffectFn<any>): R;

and all error message disappeared.
I hope it'll help.

@dyesseyumba Ok, so now it resolves to a wrong signature. Please find interface CallEffectFactory (line 160), and comment out all signatures that mention CallEffectNamedFn. These are the ones that handle this form:
yield fork([obj, 'method'], ...args);

Then try to compile once again.
I'm sorry about this being so frustrating. Hopefully, it will get at least a little better with the new typings for redux-saga 1.0.

Ah, sorry, I can see that you've already tried that.
By the way, why do you need to fork takeLatest? It's already non-blocking, see https://github.com/redux-saga/redux-saga/blob/v0.16.0/src/internal/io.js#L188

Yes, you right. I used takeLatest directly and it works well. thank you.

@aikoven Thanks for the help!