Hide console window ?

Is there a way to hide console window and just show main UI?
I see two window when starting my aplication, first Console and next Desktop UI

You can try using this: https://www.nuget.org/packages/NSubsys.

Thank you for replay, how to use? no documents

You need to specify the runtime identifier so that it deploys the dotnet host.

i installed package in my dekstop  AvaloniaUI not happening, not work, cannot see NSubsys dll in build folder and nothing, can you show me a sample or what i can do?

ping @jmacato

https://github.com/AvaloniaUI/Avalonia/wiki/Platform-support

https://github.com/AvaloniaUI/Avalonia/wiki/Hide-console-window-for-self-contained-.NET-Core-application

@Ali-YousefiTelori You need publish your app with dotnet publish

Thank you @wieslawsoltes your way works fine.

@grokys @wieslawsoltes perhaps we can update this wiki page ?

@Ali-YousefiTelori can i close this issue now? :)

@jmacato yes

I understand this is closed issue, but does NSubSys work on macOS/Linux also, or is this just a Windows solution?

@tom-corwin only for windows

If we talk about development for Windows, and using Visual Studio probably, what I did is opened the properties of my application (project) and in the Application section I changed the Output type from Console Application to Windows Application. Now the debug build still opens the console, release build doesn't.
No need for Nsubsys or editbin.

I've bumped into the same problem when I was configuring CI build of win-x64 target in Docker linux container. OutputType was WinExe, but I still got console window when running built application. I tried to use NSubsys, but it also didn't work. The reason was that I was building for net5.0, and NSubsys was tuned to use some variables from MsBuild process specific for NetCore build.
So, the solution: use NSubsys.Tasks.dll to run an additional post-build event which patches the built application (add to .csproj file):
<PropertyGroup>
    <NSubsysTasksPath Condition="'$(NSubsysTasksPath)' == ''">$(MSBuildThisFileDirectory)\NSubsys.Tasks.dll</NSubsysTasksPath>
</PropertyGroup>

<UsingTask TaskName="NSubsys.Tasks.NSubsys" AssemblyFile="$(NSubsysTasksPath)" />

<Target Name="CustomAfterBuild" AfterTargets="Build" Condition="$(RuntimeIdentifier.StartsWith('win'))">
    <NSubsys TargetFile="$(OutputPath)$(AssemblyName)$(_NativeExecutableExtension)" />
</Target>

<Target Name="CustomAfterPublish" AfterTargets="Publish" Condition="$(RuntimeIdentifier.StartsWith('win'))">
    <NSubsys TargetFile="$(PublishDir)$(AssemblyName)$(_NativeExecutableExtension)" />
</Target>

@ChernyshevDS
You, Sir deserve a cookie! Still works for Avalonia 11 preview 5 and net7.0:

First install nuget NSubsys 1.0
Replace path NSubsys.Tasks.dll with the nuget one (see below)
Run the build

<Project Sdk="Microsoft.NET.Sdk">
<!-- ... -->
  <PropertyGroup>
    <NSubsysTasksPath Condition="'$(NSubsysTasksPath)' == ''">$(HOME)/.nuget/packages/nsubsys/1.0.0/tool/NSubsys.Tasks.dll</NSubsysTasksPath>
  </PropertyGroup>

  <UsingTask TaskName="NSubsys.Tasks.NSubsys" AssemblyFile="$(NSubsysTasksPath)" />

  <Target Name="CustomAfterBuild" AfterTargets="Build" Condition="$(RuntimeIdentifier.StartsWith('win'))">
    <NSubsys TargetFile="$(OutputPath)$(AssemblyName)$(_NativeExecutableExtension)" />
  </Target>

  <Target Name="CustomAfterPublish" AfterTargets="Publish" Condition="$(RuntimeIdentifier.StartsWith('win'))">
    <NSubsys TargetFile="$(PublishDir)$(AssemblyName)$(_NativeExecutableExtension)" />
  </Target>
</Project>

@sandreas You can use PackageDownload msbuild item to make the package to be auto-downloaded and $(NugetPackageRoot) instead of $(HOME)/.nuget/packages

@kekekeks Thanks, I'll try that out. Is it planned, that somehow this will be integrated into AvaloniaUI? The second window is really annoying in windows?!

Since it's definitely is an SDK bug, I'm not quite sure that we should be adding hacks on our side.

You can achieve the same thing by changing the OutputType from Exe to WinExe.
This should work on all platforms, but I can confirm this is the case on Windows.


v0.4.7

Fix issue with redirects on login.
Updated CSS for new player cards.

Coverage remained the same at 92.715% when pulling 4cf013ec50b7a4e5bcdfb42b4d6467b417d2b7c2 on develop into e9bf85d0b46f359e28bd6543406d8bd16fddc7c3 on master.


Fix async unit tests

Existing async unit tests weren't running due to old pytest and a missing pytest-asyncio dependency.

Codecov Report
Base: 71.55% // Head: 79.97% // Increases project coverage by +8.42% :tada:

Coverage data is based on head (1eeca78) compared to base (d40f0d3).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1802      +/-   ##
==========================================
+ Coverage   71.55%   79.97%   +8.42%
==========================================
  Files         239      239
  Lines        7421     7421
==========================================
+ Hits         5310     5935     +625
+ Misses       2111     1486     -625

Impacted Files
Coverage Δ

zhaquirks/xiaomi/__init__.py
80.40% <0.00%> (+3.74%)
:arrow_up:

zhaquirks/xiaomi/aqara/vibration_aq1.py
64.28% <0.00%> (+5.71%)
:arrow_up:

zhaquirks/tuya/ts0601_motion.py
100.00% <0.00%> (+10.16%)
:arrow_up:

zhaquirks/xiaomi/mija/sensor_switch.py
58.69% <0.00%> (+13.04%)
:arrow_up:

zhaquirks/orvibo/motion.py
100.00% <0.00%> (+14.28%)
:arrow_up:

zhaquirks/xiaomi/mija/sensor_magnet.py
100.00% <0.00%> (+14.28%)
:arrow_up:

zhaquirks/tuya/ts0601_electric_heating.py
57.57% <0.00%> (+18.18%)
:arrow_up:

zhaquirks/tuya/__init__.py
72.50% <0.00%> (+18.92%)
:arrow_up:

zhaquirks/konke/motion.py
100.00% <0.00%> (+20.00%)
:arrow_up:

zhaquirks/xiaomi/mija/motion.py
100.00% <0.00%> (+20.00%)
:arrow_up:

... and 8 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


revert: "chore(ci): split upload action into it's own so it can find docker"

Reverts ublue-os/bluefin#109

The missing error is from a missing file, not from docker being missing.


best way to remove mis-configured cluster

Due to what appears to be a DNS issue,  discovery has found 2 instances of an intermediate master when setting up Orchestrator to look after our production DB instances (after testing with a similar setup in AWS)
Will issuing a "forget" on the master instance remove the whole cluster, or just force a promotion of the real intermediate master ? I can't seem to find a clear way to just remove a complete cluster config, as opposed to an individual instance, which works fine.
I'd just like to clear things up, adjust DNS, and then attempt a clean re-discovery.
Master is running 5.6, other nodes are running 5.7, final stage of a 5.7 upgrade. Orchestrator is from latest version of PMM, appears to be percona-orchestrator-3.0.6-1.gita77ee00.el7.x86_64
Thanks,
Mike

Just to confirm what I sort of expected.
Almost instant total recovery, when attempting to "forget" a cluster by choosing the instance which is identifying the cluster. (quick test in AWS)
I've included a view of the issue below, where the lower intermediate with no replicas has picked up the hosting providers hostname, rather than the ip addresses the others are using. I suspect, even though this has 3 connections of its own on the monitoring DB, attempting to clean it up will take the one above with it, and mess things up a little.

Any suggestions gratefully accepted.

To forget a cluster, please use orchestrator-client -c forget-cluster -alias ..., or call /api/forget-cluster/<thecluster>.
I'm not sure what "instant total recovery" means?
If you forget an instance, and it's connected to the graph (ie it's a running master or a running replica), it will be re-discovered by probing its own master or replicas.

I suspect, even though this has 3 connections of its own on the monitoring DB, attempting to clean it up will take the one above with it, and mess things up a little.

I'm sorry, I'm not sure I understand what "will take the one above with it" means?


Prompt validation of confirm prompt in chatbot is not working for newly added language

I have a question
I am working on a chat bot project and we support English and Dutch languages.
Now we need to add German support also
But the prompt validation for confirm prompt is not working. Translation to English working correctly but while validating the data from prompt context , its showing PromptRecognizerResult  as False

Hi everyone, we reviewed this issue and added it to our backlog. We'll be tackling it next week.


Maximum Number of Achievable Transfer Requests-Leetcode Solved #210

Related Issue
Solved issue number: #210
Describe the changes you've made
Added solution of the leetcode problem Maximum Number of Achievable Transfer Requests
Describe if there is any unusual behaviour of your code(Write NA if there isn't)
NA
Language used for coding
Python
Checklist:

[ ] My code follows the style guidelines of this project.
[ ] I have performed a self-review of my own code.
[ ] I have commented my code, particularly in hard-to-understand areas.
[ ] I have made corresponding changes to the documentation.
[ ] New and existing unit tests pass locally with my changes.

check all the checkboxes.

Done

Nice work :)


Disable ShimmerView animation if OS has "reduce motion" accessibility…

… setting turned ON.
Platforms Impacted

[x] iOS
[ ] macOS

Description of changes
The design team requested that for usability reasons, the ShimmerView should not animate when the OS "reduce motion" accessibility setting is turned on.
Verification
Validated the animation is being executed when the setting is disabled and the shimmer is static when it's turned on:

Pull request checklist
This PR has considered:

[x] Light and Dark appearances
[x] VoiceOver and Keyboard Accessibility
[ ] Internationalization and Right to Left layouts
[ ] Different resolutions (1x, 2x, 3x)
[ ] Size classes and window sizes (iPhone vs iPad, notched devices, multitasking, different window sizes, etc)

Microsoft Reviewers: Open in CodeFlow

So it freezes with the shimmer in the middle of the control? Not just a uniform grey all around?

So it freezes with the shimmer in the middle of the control? Not just a uniform grey all around?

Yes. The design team liked the static gradient.
On a real use case scenario, the user would just top seeing the animation if the setting change is made while the shimmer is animating.


'xhr' type of request cannot be captured with this plugin

In generated har file, couldn't see the request/data between a web browser and a web server (XHR) (access token endpoint request, scim endpoint and etc). Is this the limitation of this plugin?
Appreciate any input/workaround to capture the details of the xhr type of request in the har file.

Any update on this question?
Is there any way to capture the xhr type of request in the .har file with this plugin?

@Kanapriya the plugin must capture all requests inside your browser session including those which have been sent by cy.request (see examples). Please provide a reproducible sample repo.

Hey @derevnjuk, I've created a sample repo for your reference.
With the spec, you can see that I've made multiple cy.request requests but none of them were caught by the cypress-har-generator. I believe the reason behind this is that cypress doesn't make cy.request requests from the browser as mentioned here. Also, such requests are not available in the har file that was exported from the chrome browser.
My only question is, the har file generated by the chrome browser shows all the requests that were made during the session whereas the har file generated by cypress-har-generator shows the requests that were made during the last test of the spec. Why is this so?

@pranavj1001  I am not a developer in this project but have written similar tools for other languages so have experience with the concepts. Hopefully the owners of this project won't mind me answering this question.
This plugin uses the Chrome DevTools Protocol (https://chromedevtools.github.io/devtools-protocol/) to subscribe to events triggered by chrome when HTTP requests are made and received.  By keeping track of these events (there are multiple events associated to one request/response), a HAR file can be generated from the available data.
As a result, only requests made by the browser generate these events, hence requests made by the node process such as cy.request are not captured.
I guess that in theory as the process that is subscribing to the CDP events is the same process that makes the cy.request, a HAR file could be created that includes these also but they would have to be added to the HAR explicitly.
Whether it is possible for HAR generation code to access a log of cy.request, I don't know but would definitely be an enhancement request to this  plug in

xhr type request are available in the json file though it not display by importing any of the har file viewer. tried with chrome dev tools, and etc..


update event docs

in a chain with #1028
not currently published on my github pages due to hosting another doc changes.

Codecov Report

Merging #1031 (bd06d69) into main (e281a17) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1031   +/-   ##
=======================================
  Coverage   99.98%   99.98%
=======================================
  Files         302      302
  Lines       19919    19956   +37
=======================================
+ Hits        19917    19954   +37
  Misses          2        2

Impacted Files
Coverage Δ

internal/orchestrator/orchestrator.go
100.00% <ø> (ø)

pkg/core/contract_listener.go
100.00% <ø> (ø)

pkg/core/subscription.go
100.00% <ø> (ø)

...erver/route_get_contract_listener_by_name_or_id.go
100.00% <100.00%> (ø)

internal/apiserver/route_get_subscription_by_id.go
100.00% <100.00%> (ø)

internal/blockchain/ethereum/ethereum.go
100.00% <100.00%> (ø)

internal/blockchain/ethereum/eventstream.go
100.00% <100.00%> (ø)

internal/blockchain/fabric/fabric.go
100.00% <100.00%> (ø)

internal/contracts/manager.go
100.00% <100.00%> (ø)

internal/orchestrator/subscriptions.go
100.00% <100.00%> (ø)

... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


[KK/KKS][PE] Swap pose results in twisted finger joints

To reproduce, enable FK for hands, click the swap pose button in KKPE main window
Code from this commit can be used to fix it
https://github.com/IllusionMods/HSPlugins/commit/47862206182fa32276739b0f28a3135c120dbe19

Fixed by #46


Error using Fast Serve 1.20.0/1.20.1 on new SPFx 1.20.0 project

I'm encountering an issue when trying to run spfx-fast-serve with the following setup:

spfx-fast-serve version: 1.20.1
SPFx version: 1.20.0
Node version: 16.20.2

When I run the npm run serve command, the build starts but fails with the error:
[fast-serve] Cannot read properties of null (reading 'plugins') TypeError: Cannot read properties of null (reading 'plugins') at getExternalComponents (C:...\spfx-fast-serve-helpers\lib\common\helpers.js:256:31) at createBaseConfig (C:...\webpack\baseConfig.js:67:68) ...

It seems to be failing during the webpack configuration step. I'm not sure what might be causing the plugins property to be null.
Steps to Reproduce:

Clone a project using SPFx 1.20.0.
Install spfx-fast-serve version 1.20.1.
Run npm run serve.

Expected behavior:
The project should build and serve as expected.
Actual behavior:
The process terminates unexpectedly with a "Cannot read properties of null (reading 'plugins')" error.

According to the compatibility table, statging from SPFx 1.19 you should use NodeJS 18. Please update NodeJS version, npm version, delete node_modules, delete package-lock.json, reinstall dependencies and try serve again.

According to the compatibility table, statging from SPFx 1.19 you should use NodeJS 18. Please update NodeJS version, npm version, delete node_modules, delete package-lock.json, reinstall dependencies and try serve again.

Still the same issue with node v18.18.0, so I don't think that's the issue.

Could you create a sample repository and attach it to the issue? Or a link to the github repo.

I'll stick to slow serve for now, and try this again later. Thanks!


Spare change is displayed in header when there are no selected rows.

Defective ToolKit Feature Name: Spare Change
Expected Behavior
If there are no selected rows there should be no spare change shown in the header.
Actual Behavior
After un-selecting all rows, the spare change is still displayed in the header.
Steps to Reproduce the Behavior

Select one or more rows
Un-select the rows using the Edit menu, clicking the checkbox, or using the right-click popup menu to "Clear Selection"
Spare change amount remains in the header

Export of Toolkit Settings (Bottom Left of Settings Page)
[paste settings here]

System Settings
ToolKit Version: 0.7.12
Operating System (Mac/Windows/Etc): Windows 19
Browser (Chrome/Firefox/Safari): Chrome
Browser Version: 56.0.2924.87 (64-bit)
Other Extensions:

Strange. This seems to no longer be "broken". Wonder why it was acting that way yesterday.
From what I observed yesterday in an initial look was that changedNodes did not contain ynab-grid-body and the areChecked observer was not firing on an un-check.

I'm going to close this issue out due to its age, but if you can reproduce this feel free to add a new bug report. Thanks!


Parameters

What would an example of using parameters look like? I'm just not really understanding the syntax (for example, the teams method has the parameter year)
Thanks!

Hey @jordzhu, thanks for the issue!
So I've briefly described how each method works here. It might be kind of confusing though, so I'll try to re-explain.
Each method takes 2 optional arguments – query and cb. The first argument is the one that should contain the URL/request parameters (i.e. year for this method).
nba.data.team({  year: '2016' }, function(err, res) {
  if (err) {
    console.error(err);
    return;
  }
  console.log(res);
});

The documentation for data endpoint parameters is incomplete right now, so if you're looking for some sort of specification as to how parameters should look, feel free to ask away (most should be intuitive). It'll be updated very soon.

There are a few examples here, but it isn't as comprehensive as it should/can be 😅. That'll be updated very soon as well.

The example you gave definitely helped. Looking forward to future updates, I think some more documentation will be very helpful. Either way great job man!

Thanks dude! This helped a lot, I agree with sharpar :)

I'm not sure if I'm doing something wrong or not, but when I call currentScoreboard, it doesn't show the current scores.
nba.data.currentScoreboard(function(err, res) {
    if (err) {
        console.error(err);
        return;
    }
    console.log(res);
});

Output:
{ games: [], numGames: 0 }
Also for scoreboard, what format is the date parameter supposed to be in?

For scoreboard the date format is 'yyyy-mm-dd' so something like 20161027.
As for the currentScoreboard endpoint it doesn't seem to be working.

@sharpar Yeah, looks like the currentScoreboard endpoint is returning nothing right now. I'm not entirely sure that this ever worked (might've just assumed it does, since it doesn't error out), going to keep it around for the time being.
@WataruKay is right about the date format, should be of the form "yyyymmdd".

Got a PR in the works (https://github.com/kshvmdn/nba.js/pull/11) for the data parameter references.
Should be merged soon (missing some information for teamUrlCode / seasonScheduleYear right now, would love some help 😄).

I just got all the teamurls valid for endpoints that use teamUrlCode
'hawks',   'fcbarcelona',   'celtics',   'nets',   'san_lorenzo',   'hornets',   'bulls',   'cavaliers',   'mavericks',   'nuggets',   'pistons',   'warriors',   'maccabi_haifa',   'rockets',   'pacers',   'clippers',   'lakers',   'grizzlies',   'heat',   'bucks',   'timberwolves',   'pelicans',   'knicks',   'thunder',   'magic',   'sixers',   'suns',   'blazers',   'real_madrid',   'kings',   'spurs',   'shanghai_sharks',   'raptors',   'jazz',   'wizards'
Should I wait for #11 to be merged then make a new pull request?

@WataruKay Awesome!
And sure! Let me merge that right now. Also note that I've changed a few of the parameter names (including teamUrlCode), refer to https://github.com/kshvmdn/nba.js/commit/88c7d76e2b3958a49511cb02ea5358eafe29003a for more info.

I've submitted #12 with the 'teamName' values.


Improve docker installation steps for inexperienced docker and ssh users

1. Why is this change necessary?
Inexperienced docker and/or ssh users might get stuck after starting the docker container not knowing how to terminate it.
2. What does this change do, exactly?
It adds the necessary commands to end the ssh session and stop the docker container to the docs
3. Describe each step to reproduce the issue or behaviour.

Somebody who has never used ssh before follows the installation docs
Now he wants to end Shopware and does not now how, he will probably just close the terminal after accepting a warning

4. Please link to the relevant issues (if any).
/
5. Checklist

[ ] I have written tests and verified that they fail without my change
[ x] I have squashed any insignificant commits
[ x] I have written or adjusted the documentation according to my changes
[ ] This change has comments for package types, values, functions, and non-obvious lines of code
[ x] I have read the contribution requirements and fulfil them.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Hello,
thank you for creating this pull request.
I have opened an issue on our Issue Tracker for you. See the issue link: https://issues.shopware.com/issues/NEXT-12316
Please use this issue to track the state of your pull request.

Thank you for contributing @gcascio ! :tada:


[BUG]

Describe the bug
A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
Add any other context about the problem here.

@parthvash1 Hello buddy..
Thanks for reporting a bug, but can you please tell me what and where is the bug exactly so I can fix it..
Best regards..

@parthvash1 Hey buddy. I'm still waiting for your reply..
I don't want you to be disappointed with this plugin 😁
Best regards..

@parthvash1 Hey buddy..
Since this issue has been open for a long time and you haven't clarified the bug you reported, the issue will be closed..
Best regards..


Guest user cart

Assignee Tasks

[ ] added unit tests (or none needed)
[ ] written relevant docs (or none needed)
[ ] referenced any relevant issues (or none exist)

Guidelines
Please add a description of this Pull Request's motivation, scope, outstanding issues or potential alternatives, reasoning behind the current solution, and any other relevant information for posterity.

This update focused on adding the Guest User cart and adding the ability to add products to cart. Changes include:

Adding a fully functional guest user cart -- guest users can add/remove items from their cart as well as change item quantity

Adding an order summary to the guest user cart

Adding and "Add to Cart" button for both guest users and logged in user

Resolving a bug that caused a loading error for newly created users when they navigated to their cart for the first time

close #36, close #29, close #34

WOOOOP


refactor: switch to gov account

Moves CI to use resources from the gov AWS account.

@stevenj @const-iohk Can you have a look, please?

The last merge broke a ton of the Nix builds.

@jmgilman I'm sorry. I have no idea why 🤨

And many Nix things are broken in the main too.

@minikin #212 needs to be reverted. I had @cameron1024 restore the branch, and I'll try and see why it broke things a bit later.


App file structure

@brianmuks change the logo then you can merge

For logo, better to use this https://avatars.githubusercontent.com/u/32548381?s=200&v=4

Done!

@brianmuks can you why the deployed version doesn't look okay ? The preview is here https://vercel.live/open-feedback/sparked-next-git-fork-brianmuks-app-file-struture-olivierjm.vercel.app

igger that. If that cam

This is vercel deploying changesm I set it up but it looks like the changes don't look good you can compare the changes for this PR https://sparked-next-nlazy9npg-olivierjm.vercel.app and the main branch here https://sparked-next.vercel.app/


jreleaser-cli: 1.14.0 -> 1.15.0

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/jreleaser/jreleaser/releases.
meta.description for jreleaser-cli is: Release projects quickly and easily
meta.homepage for jreleaser-cli is: https://jreleaser.org/
Updates performed

Version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 1.15.0 in filename of file in /nix/store/vripghkv2qsw9sdj1rigmf0d1hkgx0vh-jreleaser-cli-1.15.0

Rebuild report (if merged into master) (click to expand)

2 total rebuild path(s)

2 package rebuild(s)

First fifty rebuilds by attrpath

jreleaser-cli

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/vripghkv2qsw9sdj1rigmf0d1hkgx0vh-jreleaser-cli-1.15.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A jreleaser-cli https://github.com/r-ryantm/nixpkgs/archive/4f161ca5d5c3ffdc85a322c42950e0bc20727c8a.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/4f161ca5d5c3ffdc85a322c42950e0bc20727c8a#jreleaser-cli

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/vripghkv2qsw9sdj1rigmf0d1hkgx0vh-jreleaser-cli-1.15.0
ls -la /nix/store/vripghkv2qsw9sdj1rigmf0d1hkgx0vh-jreleaser-cli-1.15.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review

x86_64-linux

:white_check_mark: 1 package built:

jreleaser-cli

Maintainer pings
cc @I-Al-Istannen for testing.

[!TIP]
As a maintainer, if your package is located under pkgs/by-name/*, you can comment @NixOS/nixpkgs-merge-bot merge to automatically merge this update using the nixpkgs-merge-bot.

Add a :+1: reaction to pull requests you find important.

@NixOS/nixpkgs-merge-bot merge


Store: ExpandPostings returning postings for time series not matched by matchers

Thanos, Prometheus and Golang version used:
main 0651f334324572266844f73882e61d746ec7e91b

Object Storage Provider: N/A
What happened:
When using Thanos from main (version stated above) with the Thanos Prometheus engine, we sporadically see vector cannot contain metrics with the same labelset error for specific queries. Running sum by (__name__) (some_metric{some="label"}) for the metrics that triggered the error, we sometimes got additional time series for metrics different from some_metric.
Further investigating we noticed that the bucket's Series call returns some thousand series, instead of two series we would expected according the the matchers in the request. Debugging lead us to ExpandPostings of the blockSeriesClient, which sometimes seems to return postings for times series that are not matched by the provided matchers. We were able to narrow it down to https://github.com/thanos-io/thanos/pull/6420 and removing this PR resolved the issue. We didn't investigate further yet and don't know which part of the PR is causing the issue, but we assume it might be a race condition, since it only happens sporadically.
What you expected to happen:
Don't see vector cannot contain metrics with the same labelset error or metrics for different time series being returned.
How to reproduce it (as minimally and precisely as possible):
We were able to reproduce it by running a store against our production GCP bucket for specific tenants with index cache enabled, but weren't able to reproduce it with a bucket test yet.
Full logs to relevant components: N/A
Anything else we need to know: N/A
Environment:
It happens for both the production deployment and locally when pointing stores at our production buckets.

@yeya24 I wonder if you are seeing this in Cortex as well.

Thanks for the report. I was not aware of this issue and I haven't found anything weird so far. I will take a closer look today.

I also run with that change and haven't seen anything like this.

Hum...
Maybe I'm missing something but shouldn't  we have the "matcher type" on the cache key?
https://github.com/thanos-io/thanos/blob/e2123a9d217013e75eac732d3bfb3fa10911d909/pkg/store/cache/memcached.go#L136-L137
https://github.com/thanos-io/thanos/blob/e2123a9d217013e75eac732d3bfb3fa10911d909/pkg/store/cache/cache.go#L118-L127

@rabenhorst Regarding the problematic query sum by (__name__) (some_metric{some="label"}), does it have issue for all metrics or only specificf metrics/series?
If you remove the sum by and run some_metric{some="label"}, can you share what series will be included in the response? For the additional time series added, do they have anything in common or there is nothing in common.
If you are able to connect your local Thanos to the bucket, then it would be really appreciated to run store gateway in debug mode and reproduce this issue.

It would be better to provide a unit test to reproduce this.

We spent quiet some time on debugging this already and didn't succeed yet in creating a test to replicate it. If we succeed implement test I will update this issue.

@rabenhorst Regarding the problematic query sum by (__name__) (some_metric{some="label"}), does it have issue for all metrics or only specificf metrics/series?

It only happens for specific metrics and sporadically. It was hard to reproduce and narrow down to specific stores.

If you are able to connect your local Thanos to the bucket, then it would be really appreciated to run store gateway in debug mode and reproduce this issue.

We managed to do that, but couldn't find out why it is happening yet and will try to debug further. I will post updates here, if we find something.

@rabenhorst It would be great to hear if we have any other updates on this issue.

@rabenhorst It would be great to hear if we have any other updates on this issue.

As @fpetkovski and you just pointed out this might be fixed by #6575. While we were never able to reproduce the issue with a test, we can see if the issue is still reproducible with the setup where we saw the issue before.

I saw a bunch of races in Thanos Store prod so either one of them might be causing this: https://github.com/thanos-io/thanos/issues/6583
https://github.com/thanos-io/thanos/issues/6584
https://github.com/thanos-io/thanos/issues/6585

Do you have a way to consistently reproduce this?

I don't think. My ruler is running into these issues multiple every minute. I see in trace that the query frontend is the main first component that shows any issue.

We did run on 0.31.0 before.

Can you try again with latest main? Ruler was missing the deduplication fix from 0.32.0 but @saswatamcode added it recently.

Hello. I tested with the new 0.32.2 and it did not fix my issue. In my case, it also happens while querying the sidecars.
I'm trying to simulate this in a more controlled environment but it seems to happen randomly.
In my case I'm running a query like max_over_time(pipelinerun:deploy_step:duration_seconds[2h]). The query uses a recording rule but when using the expanded expression everything works.

Are you able to test with a nightly? We merged a fix for deduplication recently that was not yet released

Hey @MichaHoffmann 👋 it indeed seems to have fixed my problem. Thank you for the fast response!

awesome :tada:

Please try out v0.32.3 as well! Thanks!

Tested and it works 😄 thanks!

I will close this issue and we can reopen it if necessary.


How to correctly pass docker environment variables

Hi,
how do I correctly pass environment variables for e.g. the default language in a docker compose file?
Here is my docker compose, but the language is still English and not German. What is wrong here?
version: '3.3'
services:
    s-pdf:
      restart: always
      container_name: pdftools
      labels:
        - "com.centurylinklabs.watchtower.enable=true"
      image: frooodle/s-pdf
      volumes:
        - /opt/docker/pdftools/tessdata:/usr/share/tesseract-ocr/4.00/tessdata
      networks:
        - default
      environment:
        - defaultLocale="de-DE"
        - googlevisibility="false"

networks:
  default:
    name: www
    external: true

Thank you for any help in advance
Danny

It doesn't seem to work for SYSTEM_ROOTPATH... I have tried "pdf", "/pdf" "/pdf/" and "https://fulldomain/pdf"

Can you try SYSTEM_ROOTURIPATH ?

Also having issues.  I can't seem to get the right settings with the newest version.  Lost the ability to custom brand etc.  Tried a variety of things, will wait till updates to the documentation etc.

Can you try SYSTEM_ROOTURIPATH ?

Was able to get that to work with "/pdf"

I've just done a new install and even the config file seems to be ignored at the moment. Neither my docker environment or the settings file options are being used. This is on the latest docker image.

Also having issues. I can't seem to get the right settings with the newest version. Lost the ability to custom brand etc. Tried a variety of things, will wait till updates to the documentation etc.

I have already updated documentation on this

If you want to change the app name etc via env variables then you can use
UI_APPNAME
UI_HOMEDESCRIPTION
etc

I've just done a new install and even the config file seems to be ignored at the moment. Neither my docker environment or the settings file options are being used. This is on the latest docker image.

Cant reproduce this, case you raise as a new issue and ill see if i can reproduce, are you using security mode?

Got it.  All set, I misinterpreted the new instructions. thanks!

Any way i could word it better?

Maybe have a docker-compose example file with all the environment variable options spelled out with # and users can just remove the comment and use the ones they need?

I've just done a new install and even the config file seems to be ignored at the moment. Neither my docker environment or the settings file options are being used. This is on the latest docker image.

Cant reproduce this, case you raise as a new issue and ill see if i can reproduce, are you using security mode?

I've rebuilt it today and removed the env variables from the docker compose. It's now picking up the settings from the config file. Thanks.

Maybe have a docker-compose example file with all the environment variable options spelled out with # and users can just remove the comment and use the ones they need?

 environment:
      - DOCKER_ENABLE_SECURITY=true
      - SECURITY_ENABLELOGIN=true     #Default username: admin and password: stirling
      - SYSTEM_DEFAULTLOCALE=de-DE
      - SYSTEM_GOOGLEVISIBILITY=false
      - UI_APPNAMENAVBAR=appnamenavbar-test
      - UI_APPNAME=DOCKER PDF
      - UI_HOMEDESCRIPTION=------> AWESOME PDF TOOL IN DOCKER <------
      - METRICS_ENABLED=false # API CAllS are not allowed e.g. http://<IP>:<PORT>/api/v1/uptime
      #- ENDPOINTS_TOREMOVE=img-to-pdf, remove-pages


Robotron link not valid

Hello !
First thanks for the roadmap, this is very cool ;-)
It looks like the link https://shorturl.at/hjvT1 written in the "Source of Truth/Inventory/Modeling" module is not valid anymore.
I guess it is meant to point to https://research.fb.com/wp-content/uploads/2016/11/robotron_top-down_network_management_at_facebook_scale.pdf ?
Thanks again !

@jpmondet Hi! Thanks for the feedback and for pointing out the broken links, they have been fixed now.
And yes, you have the correct link to FB Robotron


Add sort capability

Enable sorting for the hash data structure, for number, string and boolean field types.
Syntax:
const sorted = await repository.search().sortBy('field').returnAll();

Also added min and max functions mentioned in #10
const biggest = await search.min('numberField');    // or await search.returnMin('numberField');
const smallest = await search.max('numberField');  // or await search.returnMax('numberField');

A quick glance and this looks pretty solid. Thanks for an awesome contribution! I'll go over it more thoroughly this week, we can go through the review cycle, and we'll hopefully get it merged. Thanks!

Want to let you know that I haven't forgotten about this. Just competing priorities on my time. It shall be merged at some point!

Merged this to a branch and will do the work to integrate it with the changes that I have wrought since you create this request. Thanks so much for your contribution!

Hey @danipatko, are you cool with me giving you a shout out in the Redis Blog to thank you for contributing this to Redis OM?

Yeah, I would gladly accept that, thank you.


Update for TravelMidwest site change

The TravelMidwest site was recently updated which seems to have broken expresschi.com. However, the good news is that they've fixed the direction indication. There is also now a JSON-based API, so no HTML parsing needed!
I updated the code to use this new API, along with some other various refactoring. Since there was no formatting config for this repo, my local Prettier config was used to format it. You might want to run it through whatever formatter you used previously to keep it consistent, but if not I'd recommend reviewing the code with whitespace disabled.

@ajmhyd all done, ready to merge!


Add percent (%) as a recognized pint unit.

@noahl PTAL

LGTM. This looks great. One question - can I define a units flag with convertible_to=units.percent? That would be very useful.

Good question. The answer is yes, and I've added a test case for it.

LGTM


timeout too short on some build

Hello !
I needed to change the timeout settings in line 35 by
  await self.page.goto('file://' + temp.name, timeout=0)
because i had a constant issue with timeout being too short for some PDF buildings.
Is it possible to add an option to set proper timeout ?
Thanks for your work

Default timeout is set to 30s. If your page isn't loading in that time you probably have an issue with some script/styles/images/fonts not loading properly.
But you are right, I'm adding config parameters to set the timeout and waitUntil options in the next release.


Can't start node with forever

I am not sure it's problem of forever, but it happened and don't know how to fix it;
When I start server with command:
forever start -l forever.log -o out.log -e err.log server.js
it says:
info:   Running action: start
info:   Forever processing file: start
error:  Cannot start forever
error:  script /var/app/winkr/start does not exist.
environment:

forever version :0.7.3

node version: v0.4.10

npm version: 1.0.106

python version: 2.6.5

I am having the same error with node v0.6.2

same error with node version v0.4.12 !

Same issue here with Node 0.6.0 and forever 0.7.3. I've discovered that you can start something when you don't pass the start action, like so: forever app.js, but it doesn't start it as a daemon, so forever stops when you close the terminal. At first I thought there was an API change, but now I think it's a bug.

This is a duplicate of the already-solved issue #165
This issue may be closed.

Fixed.
closing.

note: they haven't published the 0.4.6 release of nconf to npm yet, so you'll have to update it manually if you don't want to wait.

yeah, yeah, yeah,
update the system.js file in the forever/node_modules/nconf/lib/nconf/stores folder with latest.


Include the word "Archives" as a tag line or in the SS description

For accessibility reasons, we need to indicate that SS is an archive of PSU research. @bdezray - do you have suggested wording? Thanks!

Add the following tagline language to the Blue Bar that says Welcome to ScholarSphere as a subtitle as well as replace the "A service of the University Libraries" in the bottom left with this language.
An institutional repository and archive dedicated to sharing and preserving Penn State’s scholarly and research outputs


Issue in reloading CollectionViewCell

when we reload  collection view using "collectionView.reloadData()", the cells disappears. After moving in the blank space the cell appears back

if you can share a piece of code that reproduces the issue I can help better.
Try this after reloadData,
(self.collectionView.collectionViewLayout as? CollectionViewPagingLayout)?.invalidateLayoutInBatchUpdate()

if you can share a piece of code that reproduces the issue I can help better.
Try this after reloadData,
(self.collectionView.collectionViewLayout as? CollectionViewPagingLayout)?.invalidateLayoutInBatchUpdate()

Thank you so much for the fast replay "collectionView.reloadData()" worked now. There was one more issue that I faced. When we reload a single cell of the collection view using "collectionView.reloadItems(at: [IndexPath])" the cell reloads but after reloading user click/tap is not affected on the cell, After we move to other cell and come back the cell comes back to normal and responds to the click / tap

Probably the same trick (invalidateLayoutInBatchUpdate) should work for that too, if it doesn't I'd need a sample code to investigate more

Just want to let every one know. when I disappearing cell after reload (self.collectionView.collectionViewLayout as? CollectionViewPagingLayout)?.invalidateLayoutInBatchUpdate() did the trick for me, but their was still some glitchy cell movement. Changed the above code to  collectionView?.performBatchUpdates({ [weak self] in
self?.collectionView?.collectionViewLayout.invalidateLayout()
}) , and then all the reload issues were long gone.


fix/dropping-sender-to-end-stream

Depends on https://github.com/jabber-tools/google-cognitive-apis/pull/3
With the combination of this and the merging of https://github.com/jabber-tools/google-cognitive-apis/pull/3, dropping a sender should send an END_STREAM signal.
In Speech-to-text streaming this is essential as it allows you to signal the end of an audio stream and receive a response without waiting for a timeout (paying for extra billable time, and leading to latency for users).

I have implemented additional methods as discussed + done some minor changes to get rid of warnings. see here https://github.com/jabber-tools/google-cognitive-apis/commit/cfe0317d47514e7b2c52b94b7324ab586cb4792b. This basically addresses stuff implemented in this PR so I am closing it without merging. I am planning to release these changes as patch version 0.1.5. PR#4 will be then released as 0.2.0 mostly because of need to manually setup protoc. Let me know if this is OK with you, any further suggestions are welcome. Thanks for your contributions so far!

Thank you!
I'll give the final 0.2 a test with our cast just to see the stream lifecycles behave correctly but thanks for looking at these changes and taking the time.


Remove defer from proc.(*Sort).Pull loop

Each loop iteration in proc.(*Sort).Pull defers a call to batch.Unref.
The accumulated runtime.newdefer allocations consume memory proportional
to the number of batches produced by the parent proc.  Remove the defer
to eliminate those allocations.

Good catch.


files missed

whe I run preprocess data file, I found there are missed data files
datas = []
# older Amazon
data_flie = '/path/reviews_' + dataset_name + '.json.gz'
# latest Amazon
# data_flie = '/home/hui_wang/data/new_Amazon/' + dataset_name + '.json.gz'
could you provide it?

here， I find this，share with u。
https://github.com/lianyixin/Amazon-Product-Classifier-and-Recommendation-UCSD-Dataset/blob/master/reviews_Beauty_5.json.gz


Improve UI/UX for anchors

Key highlights:

anchors are smaller and less noisy
anchors are hidden unless one of these conditions is met:

an element that depends on the anchor is hovered/selected
the cursor is close to the anchor
the anchor does not have any elements that depend on it
the editor is in a select-anchor mode

when visible, anchors are rendered on top of everything
anchors have an outline (white if hovered, black if not hovered)

they were definitely not well thought-out

I couldn't think of any better way to do it until I recently learned about RenderLayers. We got some excellent mileage out of those medicine balls!


Add support for ingesting non-JSON messages

Non-JSON messages in CloudWatch caused the plugin to crash and burn. This PR adds a begin/rescue block to properly deal with them by wrapping non-JSON events into a hash as per the Fluentd event spec.
Fixes #156

Tagging @ryotarai for a review.

Tagging @cosmo0920 instead for a review.

@cosmo0920 one thing that sprints to mind is that this change might generate a lot of error messages in Fluentd's logs if CloudWatch logs are not JSON. Thought I confess I haven't yet understood why events are NOT in JSON format from the CloudWatch API for my use case.


Is it possible to have both non-outline part and outline in a single tiddler?

In Notion, we can have an outline and a normal note inside the same page. Can we do this in tiddlywiki with streams?

@linonetwo I have no familiarity with Notion, so please explain in more general terms what your question is.

Like this, mixed normal wikitext and list

@linonetwo thank you for the example. Currently this is not supported. The plan for 2.0 is to support different types of node types. So a node could be formatted as a list item or something else. But that's still a fair way down the road as I'm being kept rather busy with other commitments.
Do note however that each node in Streams can contain any content, even multiline. So while it might not look visually the same as your example you might be able to achieve the same goals.

Also note that a tiddler can have it's own content in its text field, which is displayed before any nodes that it might have.

I think before install streams, tiddler is the first class note type, but after install streams, the first class note type is the streams outline note.
Maybe what I want is actually

when type - , automatically insert a {{transclusion to a new tiddler}}
can directly edit that tiddler

But that will be far complicated.
Thanks for your explanation.

@linonetwo note that you can still open the individual stream nodes directly for editing, by clicking the bullet symbol.


Add hyperlinks

Codecov Report

Merging #346 (f42bebe) into master (5cd4aa6) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #346   +/-   ##
=========================================
  Coverage     64.60%   64.60%
  Complexity      701      701
=========================================
  Files           112      112
  Lines          2557     2557
  Branches        332      332
=========================================
  Hits           1652     1652
  Misses          775      775
  Partials        130      130

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5cd4aa6...f42bebe. Read the comment docs.


992 post type labels

Ticket: #992
Reviewer: @connorjburton
Issue
Need an API to access post type information that matches other methods on Post
Solution
{{ post.type }} can store and return this data
Impact
If a user has a custom field named "type" they're gonna have a bad time
Usage
{{ post.type }} and the old method {{ post.get_post_type }} still work
Considerations
Should {{ post.post_type }} return this data too? At first I thought so, but then I changed my mind. Thoughts?
Testing
Tests included!

I just caught a failing test, please hold on reviewing for now...

Coverage decreased (-0.05%) to 87.932% when pulling e85abf4e627ff4e1b117d8d64992c71616416639 on 992_post_type_labels into 7ae6337f1811b2a274dc43c6434e48b464ec7746 on master.

Coverage increased (+0.005%) to 87.982% when pulling e85abf4e627ff4e1b117d8d64992c71616416639 on 992_post_type_labels into 7ae6337f1811b2a274dc43c6434e48b464ec7746 on master.

Coverage increased (+0.005%) to 87.982% when pulling<PHONE_NUMBER>281c97959bc3022978eb6399e9ff10 on 992_post_type_labels into 05973f2367e6652398d852c2a6f12c32ea30c862 on master.

Coverage increased (+0.005%) to 87.982% when pulling 84f7323098345399234bc71ef6e47b09f56af457 on 992_post_type_labels into ee10478bf4168ec4f1918dbf3c8dea094b14552b on master.

as you say, If a user has a custom field named "type" they're gonna have a bad time - in fact this appears to be a breaking change in 1.04... I've just had to downgrade to 1.03 as a result. any suggestions for a workaround?

We should probably change this to post.post_type @jarednova ?

Related #1057

We could also make this pluggable, so only add the type property if it doesn't already exist.

either of those (post_type rather than type or the conditional add) seem better than bulldozing any custom field called type... it's got to be a pretty common/likely field name, no?

@connorjburton @fewerflatlands thanks for the heads-up on that. I agree and will work on a patch now


Answer Hack doesnt work anymore

Describe the bug
When putting into console the error "uncaught" shows up
To Reproduce
Steps to reproduce the behavior:

Go to 'the console'
Click on 'the paste button'
Scroll down to 'All the errors'
See error

Expected behavior
Expected to show me answers
Screenshots
No screenshots
Desktop (please complete the following information):

OS: [e.g. iOS] Windows
Browser [e.g. chrome, safari] Chrome
Version [e.g. 22] idk

Smartphone (please complete the following information):

Device: [e.g. iPhone6]
OS: [e.g. iOS8.1]
Browser [e.g. stock browser, safari]
Version [e.g. 22]

Additional context
I could just typed it out but github gave me this super usefull template anyways doesnt work u can test urself lol

False issue. Some features are not supported.


made curl ssl_verification configurable

Hi
Thanks for your pull request. I believe that keeping it as true will increase the security. with that in mind I will have to respectfully decline your pull request

Hi,
Our dev environment does not have a valid https certificate, so in order for us to use this client we need this configuration. I suggest we could use
$ssl_conf = ($config['ssl'] && $config['is_sanbox'])
This being more or less pseudocode but i think you know what i mean.
If you agree i will make another pull request
Regards
Fitzel

Hi fitzel,
the change you suggested is not realted to you acting as the server (https) but as a client in the handshake. Our endpoints are secured via https and you need a vaild ca-bundle to be able to acknowledge our certificates and act as a clinet in the handshake.
This something the SDK supports. Yuu can download an ca-bundle, e.g.: https://raw.githubusercontent.com/bagder/ca-bundle/master/ca-bundle.crt
Save it wherever you like and specify the location in the config via the variable: cabundle_file
hope this helps.
By the way, if you want to address the frontend as well (buttons, widgets), SSL / HTTPS is a must.
Best wishes
Daniel


[stdlib]Properly promote stack buffer to heap buffer when necessary (5.0 cherry pick)

rdar://problem/45216800
https://bugs.swift.org/browse/SR-8939

@swift-ci please test

@airspeedswift Don't let this interrupt your weekend/holiday plans too much. It would just be nice to get this in sooner rather than later.

Build comment file:
Performance: -O

TEST
OLD
NEW
DELTA
RATIO

Regression

InsertCharacterEndIndex
145
160
+10.3%
0.91x

StringEqualPointerComparison
600
657
+9.5%
0.91x

Improvement

Hanoi
3779
3487
-7.7%
1.08x

Performance: -Osize

TEST
OLD
NEW
DELTA
RATIO

Regression

StringEqualPointerComparison
571
628
+10.0%
0.91x

InsertCharacterEndIndex
145
159
+9.7%
0.91x

Improvement

DictionaryKeysContainsNative
30
27
-10.0%
1.11x (?)

Performance: -Onone

TEST
OLD
NEW
DELTA
RATIO

Improvement

ArrayOfGenericPOD2
1179
1067
-9.5%
1.10x (?)

ArrayOfPOD
858
780
-9.1%
1.10x

How to read the data
The tables contain differences in performance which are larger than 8% and
differences in code size which are larger than 1%.
If you see any unexpected regressions, you should consider fixing the
regressions before you merge the PR.
Noise: Sometimes the performance results (not code size!) contain false
alarms. Unexpected regressions which are marked with '(?)' are probably noise.
If you see regressions which you cannot explain you can try to run the
benchmarks again. If regressions still show up, please consult with the
performance team (@eeckstein).

Hardware Overview
  Model Name: Mac Pro
  Model Identifier: MacPro6,1
  Processor Name: 12-Core Intel Xeon E5
  Processor Speed: 2.7 GHz
  Number of Processors: 1
  Total Number of Cores: 12
  L2 Cache (per Core): 256 KB
  L3 Cache: 30 MB
  Memory: 64 GB

--------------


Fix babel-register code example

Spent half an hour trying to workout why my setup wasn’t working before I realised this invocation isn’t right 😅

👍


Wisdom from the old

Add utils to convert old cabs to new cab. This is to make it easier to make stimela 2.0 cabs, but cabs converted this way should be manually checked and tested before being added to cult-cargo

@SpheMakh, since there's a change to the casa6 image, did you run build-cargo casa6 to build and push the update?


VIRTUALENVWRAPPER_PYTHON in .zshenv is being overridden

I just updated prezto from last week.
Now I suddenly find that VIRTUALENVWRAPPER_PYTHON in .zshenv is being overridden by prezto due to @belak 's changes in https://github.com/sorin-ionescu/prezto/commit/e021adeb4a628387e853004427e3ea373207ee5a and https://github.com/sorin-ionescu/prezto/commit/d8d6b4d70a09cb78eab6f524e1e448a2a84cc155.
I set the value for VIRTUALENVWRAPPER_PYTHON here: https://github.com/jeffwidman/dotfiles/blob/00a93ab62c1642eafddc81784bcb5d11fdd57c78/zsh/.zshenv#L34
On my work laptop, I set this as /usr/local/bin/python2 so that any new virtualenv's default to python2 without my needing to specify it every time.  However, when I check the value, it's reported as /usr/local/bin/python3:
~ ❯❯❯ echo $VIRTUALENVWRAPPER_PYTHON
/usr/local/bin/python3

I don't know whether to classify this as a bug (in which case prezto should check .zshenv) or user error (I should somehow specify the value in .zpreztorc rather than .zshenv).
Related: #1519

I suppose I could accomplish this by installing virtualenv/virtualenvwrapper into python3, but then specify
VIRTUALENVWRAPPER_VIRTUALENV_ARGS = --python=python2. It's slightly problematic because then it hardcodes the python, and occasionally I want to create venv's that have a python3 interpreter.
http://virtualenvwrapper.readthedocs.io/en/latest/install.html#default-arguments-for-virtualenv

This can be overridden with :prezto:module:python:virtualenvwrapper:python-path but I'll push a fix which will only override this envar if it isn't already set.

Thanks for reporting! This should be fixed now. Edge cases are the bane of my existence.

I'm not sure if it would be better to remove the zstyle option and have people set that environment variable manually, or just leave it in at this point... >_<

Personally, I would remove the zstyle override option. Makes great sense to have a sensible default and I appreciate you adding it. But I do think it's confusing to have an override for a third-party tool that already has a documented override available. This zstyle option for prezto hasn't been out more than a few days, so should be safe to remove it if we do it quickly.


Include diff.blog in Compter Science News section.

https://diff.blog is an aggregator of computer science engineering and developer blogs. I built it around 1.5 years back and I plan to keep it running as much as I can.
Links to a recent HN discussion, Product Hunt launch and an article mentioning diff.blog in Towards Data Science to make it easier for you to review this :)

CLosin

邮件已收到，我会尽快回复。

来信收到，谢谢，祝您一切顺利！

您好，您的邮件我已收到！祝工作顺利，天天开心。。。

这是来自QQ邮箱的假期自动回复邮件。你好，我最近正在休假中，无法亲自回复你的邮件。我将在假期结束后，尽快给你回复。


4-byte UTF8 code point reported as 2 chars in textDocument/didChange

VSCode Version: 1.9
OS Version: All.

Steps to Reproduce:

Add a 4-byte UTF8 code point (e.g. 𐍈 or 𠜎 ) to a new file (e.g. C++).
Delete it and put a breakpoint in an extension that handles the textDocument/didChange protocol (e.g. the C++ extension).

Bug: The result from VS Code is that TextDocumentContentChangeEvent rangeLength is 2, so our extension sees that the 1st character is correctly 4 bytes, but then it tries to process a non-existent 2nd character (crashing the process or corrupting data).
It seems like VS Code should make available the real character length of an edit so extensions can behavior correctly. VS Code reports the 4-byte code point as taking up 2 columns, which is consistent with the rangeLength of 2.
As a workaround, we will assume that all 4-byte code points take up 2 characters and all other code points take up 1 character. Does that seem like a good workaround? I don't know for sure which UTF8 code points count as 2 or more characters.

Codepoints encoded in UTF-8 will be:

1 byte if they are between U+0000 and U+007F
2 bytes if they are between U+0080 and U+07FF (most major European and Middle Eastern languages)
3 bytes if they are between U+0800 and U+FFFF (the rest of the Basic Multilingual Plane)
4 bytes if they are between U+10000 and U+10FFFF (all the supplemental planes)

Note that the characters that take 4 bytes in UTF-8 tend to be problematic in UTF-16 too, because they take two characters (a surrogate pair) to represent, and are a common source of problems for programmers who didn't sufficiently test their code. There are plenty of characters from the supplemental plane in common use (for example, here are 62 Chinese ideograms from the supplemental plane that are considered to be among the "core" ideograms in modern Chinese, and most emojis are in the supplemental plane as well).
Since Javascript uses UTF-16 internally, you have to be prepared to encounter various Unicode problems when dealing with the supplemental plane. It sounds like the TextDocumentContentChangeEvent is passing a UTF-16 string, and the C++ extension is simply assuming, incorrectly, that the surrogate pairs are two separate characters.

Thanks @rmunn for those great details. I agree that this is how JS works, esp. this hurts:

JavaScript treats code units as individual characters, while humans generally think in terms of Unicode characters. This has some unfortunate consequences for Unicode characters outside the BMP. Since surrogate pairs consist of two code units, '𝌆'.length == 2, even though there’s only one Unicode character there. The individual surrogate halves are being exposed as if they were characters: '𝌆' == '\uD834\uDF06'.

Okay, we have a function to get the UTF16 character length of a UTF8 code point, so using that has fixed the issue for us. So we don't really need a fix from you guys, but if you do decide to change the character/column/ranges values from being UTF16 counts to Unicode character counts then we'd need change our code back to the way it was before.

Ok. We will not change/break the current implementation, but there is a request to 'expose the bytes'. That might be useful for you once it happens: https://github.com/Microsoft/vscode/issues/5735


New docs on expressions and constants

Fixes #992.

This change is

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/27b6ad364233809f60cd5f3bc3e162364a0ee0f2/

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/4f060001b68c5ad94d00f3eaeadefec633d2ccab/

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/ba268000887648f2ce7f5d2cfdee1aefcdf23063/

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/fe1b2e99645d1324ce682d04ae816f4a6cc62f4e/

Review status: 0 of 14 files reviewed at latest revision, 17 unresolved discussions, some commit checks failed.

bytes.md, line 20 at r1 (raw file):

## Formats

To express a byte array constant, see the section on

Quick note before I do a more thorough review: for this and all other data types, I would like to see at least one example of formatting left on the page. The idea being that I can jump to the page and get the information I'm most likely to need, and then find a link to deeper reference material only if I need it.

Comments from Reviewable

bytes.md, line 20 at r1 (raw file):
Previously, sploiselle (Sean Loiselle) wrote…
Quick note before I do a more thorough review: for this and all other data types, I would like to see at least one example of formatting left on the page. The idea being that I can jump to the page and get the information I'm most likely to need, and then find a link to deeper reference material only if I need it.

@knz, although I didn't say as much in my review, I agree with Sean that simple examples on page are a huge plus for getting users quick answers. I'd say a simple example per expression type mentioned, here and other data type pages.

Comments from Reviewable

Quick note before I do a more thorough review: for this and all
other data types, I would like to see at least one example of
formatting left on the page. The idea being that I can jump to the
page and get the information I'm most likely to need, and then find
a link to deeper reference material only if I need it.

@knz https://github.com/knz, although I didn't say as much in my
review, I agree with Sean that simple examples on page are a huge plus
for getting users quick answers. I'd say a simple example per expression
type mentioned, here and other data type pages.

I agree with both of you on this. I'll have a look before Monday.
Cheers

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/43efba793828ada65cdeb5e49ac8be24c7be3af7/

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/8e57b91fa43f99401722a50b1d39d05aefd33fc6/

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/a6276885a813e628e8931abcccacb517f12f91e4/

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/6640c43f9571bcb43fd8c6dcfa785f2e5ec780d6/

I have reworked the sidebar significantly. PTAL

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/4a5a77415472fad5e61ffba435c0b4fb74fac9e9/

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/b8b97d1dd02fbcefdc52dc54626348eac116d4d7/

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/e5e040d55c94e333bd4d21866a4b4a6241f2cae5/

Review status: 0 of 22 files reviewed at latest revision, 68 unresolved discussions.

bytes.md, line 20 at r1 (raw file):
Previously, jseldess wrote…
@knz, although I didn't say as much in my review, I agree with Sean that simple examples on page are a huge plus for getting users quick answers. I'd say a simple example per expression type mentioned, here and other data type pages.

Done.

sql-constants.md, line 85 at r1 (raw file):
Previously, jseldess wrote…
I'd take this out of parentheses.

Done.

sql-expressions.md, line 49 at r1 (raw file):
Previously, jseldess wrote…
For this and all other section headings, let's use title case, i.e., Column References instead of Column references.

Done.

sql-expressions.md, line 51 at r1 (raw file):
Previously, jseldess wrote…
Would be clearer as: An expression in a query can refer to columns in two ways:

Done.

sql-expressions.md, line 53 at r1 (raw file):
Previously, jseldess wrote…

Capitalize Using.
Don't think we need quotes around price.
Let's make [SQL keyword](keywords-and-identifiers.html#keywords) a link.

Done.

sql-expressions.md, line 69 at r1 (raw file):
Previously, jseldess wrote…
I think we may eventually want to move/combine this with the auto-generated operator docs, but some of the operators here (NOT and probably others) aren't caught by our doc generator because they are only in our grammar. Spoke to @dt about this and will open an issue to get them added to the lists that the generator depends on, though there's then a danger of drift between the docs and the actual implementation in these cases.

I do not like the idea of combining these things anytime soon. There is much more information to share in docs about operators than what fits in our auto-generator, and extending the auto-generator so that it produces output nearly as useful as a simple hand-written chapter on the topic is a non-trivial task.

sql-expressions.md, line 104 at r1 (raw file):
Previously, jseldess wrote…
nit: We use the oxford comma in the docs, so please add a comma before "and IS NOT".

Done.

sql-expressions.md, line 123 at r1 (raw file):
Previously, jseldess wrote…
The indentation works for code blocks, but for the sake of consistency, can you please change all code blocks to look like this?
~~~
<expr> IN <expr>
<expr> IN ( ... subquery ... )

<expr> NOT IN <expr>
<expr> NOT IN ( ... subquery ... )
~~~

Done.

sql-expressions.md, line 157 at r1 (raw file):
Previously, jseldess wrote…
We use ~~~ around code blocks. I'm actually surprised the back ticks work, as they have not in the past.
Also, throughout the docs:

We separate the the response. So two code blocks, the first with sql syntax highlighting, the second without.
Whenever we have a sql query, we preface it with a shell prompt $ and end it with a semicolon ;.

Done.

sql-expressions.md, line 166 at r1 (raw file):
Previously, jseldess wrote…
Want to add an example, as you have for other sections, or is that overkill?

Done.

sql-expressions.md, line 184 at r1 (raw file):
Previously, jseldess wrote…
Want to add an example?

Done.

sql-expressions.md, line 264 at r1 (raw file):
Previously, jseldess wrote…
Can a column actually contain such an array? I haven't heard about his and can't get it to work myself, though I probably just have the wrong syntax.

No, and that's another example of why #1009 matters.

sql-expressions.md, line 273 at r1 (raw file):
Previously, jseldess wrote…
conditional expression

Done.

sql-expressions.md, line 365 at r1 (raw file):
Previously, jseldess wrote…
Would you mind adding an example or two for window function calls? We still need to get window functions added to the auto-generate functions doc (https://github.com/cockroachdb/docs/issues/852), but if we add examples, I wonder whether that's sufficient to close https://github.com/cockroachdb/docs/issues/710?

I don't know how to construe meaningful examples (and I still personally think that window functions are a poor feature that ought not to exist).

window functions and processing deserve as separate page anyway. Let's address #710 separately.

sql-expressions.md, line 424 at r1 (raw file):
Previously, jseldess wrote…
As mentioned above:

Need to use ~~~ for code blocks.
Let's preface sql statements with $ and end with ;.

Done.

sql-expressions.md, line 440 at r1 (raw file):
Previously, jseldess wrote…
Same feedback as above.

Done.

sql-expressions.md, line 469 at r1 (raw file):
Previously, jseldess wrote…
Same feedback as above.

Done.

Comments from Reviewable

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/a7c35c558302182eefcb428eebc0634e44dd8575/

data-types.md, line 31 at r1 (raw file):
Previously, knz (kena) wrote…
I have added the callout thing and a more clearly worded recommendation.

Thanks, @knz. One more change: I lead you to use markdown formatting for the link inside. Turns out that causes rendering issues. So please format the link as html instead, here an in any other callouts you added:
type annotation

Comments from Reviewable

date.md, line 47 at r2 (raw file):

~~~
~~~ sql
> -- explicitely typed DATE literal

spelling: explicitly

Comments from Reviewable

manual-deployment.md, line 12 at r2 (raw file):

{{site.data.alerts.callout_info}}
For testing and development, you can
[Start a Local Cluster](start-a-local-cluster.html) or

As mentioned above, I've had to revert the ability to use markdown inside callouts, so we need to revert this to html as well.

Comments from Reviewable

sql-constants.md, line 2 at r1 (raw file):
Previously, knz (kena) wrote…
Done.

Title case, please: Constant Values

Comments from Reviewable

sql-constants.md, line 30 at r1 (raw file):
Previously, knz (kena) wrote…
Done.

Let's change ; to . at the end of each bullet, please. And remove and from the end of the last bullet.

Comments from Reviewable

sql-constants.md, line 85 at r1 (raw file):
Previously, knz (kena) wrote…
Done.

Parentheses are still there ...?

Comments from Reviewable

sql-constants.md, line 174 at r1 (raw file):
Previously, knz (kena) wrote…
wait what? The paragraph starts with "The two differences ..." above and ends with the last bullet point.

Yes, you're right. I should have also asked you to rework the intro to the list to be a complete sentence, something like:
The two differences between byte array literals and string literals with character escapes are as follows:

Comments from Reviewable

sql-expressions.md, line 60 at r1 (raw file):
Previously, knz (kena) wrote…
done

Whoa! Thank you.

Comments from Reviewable

sql-expressions.md, line 69 at r1 (raw file):
Previously, knz (kena) wrote…
I do not like the idea of combining these things anytime soon. There is much more information to share in docs about operators than what fits in our auto-generator, and extending the auto-generator so that it produces output nearly as useful as a simple hand-written chapter on the topic is a non-trivial task.

You're misunderstanding what I meant. I envision adding manually created content to the page with auto-generated content, not getting the auto-generator to produce this type of content. In any case, we can revisit later. This content is great here as well.

Comments from Reviewable

sql-expressions.md, line 198 at r1 (raw file):
Previously, knz (kena) wrote…
The whole makes a single paragraph. I do not understand why the need to split it; the semicolons are breaking the reading already as appropriate.

Instead of using a list to form a complete sentence, we introduce a list with a complete sentence and then treat each bullet as an independent item.
Can each of these bullets stand on its own, or are they dependent on each other? If the former, please don't use semicolons.

Comments from Reviewable

sql-expressions.md, line 264 at r1 (raw file):
Previously, knz (kena) wrote…
No, and that's another example of why #1009 matters.

OK, point take, and we'll revisit that. But if a column can't contain an array, then we should say "For example, if column a of the current row contains an array...", right?

Comments from Reviewable

sql-expressions.md, line 365 at r1 (raw file):
Previously, knz (kena) wrote…

I don't know how to construe meaningful examples (and I still personally think that window functions are a poor feature that ought not to exist).

window functions and processing deserve as separate page anyway. Let's address #710 separately.

OK, thanks.

Comments from Reviewable

sql-expressions.md, line 419 at r1 (raw file):
Previously, knz (kena) wrote…
done

Looks like this didn't actually get done?

Comments from Reviewable

sql-statements.md, line 2 at r2 (raw file):

---
title: SQL Statements

This is a huge improvement. Thank you, @knz!

Comments from Reviewable

table-expressions.md, line 7 at r1 (raw file):
Previously, knz (kena) wrote…
I disagree that the intro is unnecessary. The mention that multiple table names after FROM is a cross join is not mentioned elsewhere (for now).

OK.

Comments from Reviewable

table-expressions.md, line 156 at r1 (raw file):
Previously, knz (kena) wrote…
done

Sorry to have misdirected you here. Can you reformat the the callout to include only html formatting, not markdown?
{{site.data.alerts.callout_info}}
WITH ORDINALITY necessarily prevents some optimizations of the surrounding query. Use it sparingly if performance is a concern, and always check the output of EXPLAIN in case of doubt.
{{site.data.alerts.end}}

Comments from Reviewable

Thanks for making so many tweaks, @knz. I've included/repeated a few more, but it's look very close now.
I would like to decouple this work from an overahaul of the sidenav, however. There are some strange user experience issues that need to be factored in when designing the sidenav (page url needs to match link url in sidenav in order for the correct section to expand and the sidnav item to get highlighted, for example). And we're already intending to rethink the docs architecture (mostly this section) next quarter, as well as move to another tool that will let us restructure our site hierarchy.
So for now, I'd suggest we go back to the old sidenav with the three new pages simply added to the Develop section.

Comments from Reviewable

Reviewed 22 of 22 files at r2.
Review status: all files reviewed at latest revision, 17 unresolved discussions, some commit checks failed.

Comments from Reviewable

I'm very confused by the sidenav syntax and I can't seem to get it to work now (although it worked yesterday!). Are you ok with adding this fix after merging this PR?

Review status: 1 of 16 files reviewed at latest revision, 18 unresolved discussions, some commit checks pending.

data-types.md, line 31 at r1 (raw file):
Previously, jseldess wrote…
Thanks, @knz. One more change: I lead you to use markdown formatting for the link inside. Turns out that causes rendering issues. So please format the link as html instead, here an in any other callouts you added:
type annotation

Done.

date.md, line 47 at r2 (raw file):
Previously, jseldess wrote…
spelling: explicitly

Done.

manual-deployment.md, line 12 at r2 (raw file):
Previously, jseldess wrote…
As mentioned above, I've had to revert the ability to use markdown inside callouts, so we need to revert this to html as well.

Done.

sql-constants.md, line 2 at r1 (raw file):
Previously, jseldess wrote…
Title case, please: Constant Values

Done.

sql-constants.md, line 30 at r1 (raw file):
Previously, jseldess wrote…
Let's change ; to . at the end of each bullet, please. And remove and from the end of the last bullet.

Done.

sql-constants.md, line 85 at r1 (raw file):
Previously, jseldess wrote…
Parentheses are still there ...?

I had forgotten to commit the change. Apologies.

sql-constants.md, line 174 at r1 (raw file):
Previously, jseldess wrote…
Yes, you're right. I should have also asked you to rework the intro to the list to be a complete sentence, something like:
The two differences between byte array literals and string literals with character escapes are as follows:

Done.

sql-expressions.md, line 69 at r1 (raw file):
Previously, jseldess wrote…
You're misunderstanding what I meant. I envision adding manually created content to the page with auto-generated content, not getting the auto-generator to produce this type of content. In any case, we can revisit later. This content is great here as well.

Ok I agree!

sql-expressions.md, line 198 at r1 (raw file):
Previously, jseldess wrote…
Instead of using a list to form a complete sentence, we introduce a list with a complete sentence and then treat each bullet as an independent item.
Can each of these bullets stand on its own, or are they dependent on each other? If the former, please don't use semicolons.

Done.

sql-expressions.md, line 264 at r1 (raw file):
Previously, jseldess wrote…
OK, point take, and we'll revisit that. But if a column can't contain an array, then we should say "For example, if column a of the current row contains an array...", right?

Ok now I see where you're coming from.
The fun thing is that a query can produce arrays in columns by means of SQL expression computations, and these arrays can be used further in the query; however the array values cannot be stored in the database.
We were writing past each other by overlapping the notion of "physical column in storage" and "virtual column of an intermediate result table in a query".
I reworked the explanation accordingly.

sql-expressions.md, line 419 at r1 (raw file):
Previously, jseldess wrote…
Looks like this didn't actually get done?

Again forgot to commit.

sql-statements.md, line 2 at r2 (raw file):
Previously, jseldess wrote…
This is a huge improvement. Thank you, @knz!

:smile_cat:

table-expressions.md, line 156 at r1 (raw file):
Previously, jseldess wrote…
Sorry to have misdirected you here. Can you reformat the the callout to include only html formatting, not markdown?
{{site.data.alerts.callout_info}}
WITH ORDINALITY necessarily prevents some optimizations of the surrounding query. Use it sparingly if performance is a concern, and always check the output of EXPLAIN in case of doubt.
{{site.data.alerts.end}}

Done.

Comments from Reviewable

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/3c6f92a0b73cf95df653eab200bb04fc4f4a6ea0/

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/eeaddbc57a64f8cd050ef07f5f68219e93f084b2/

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/3e989bf31aa085ad013b476de92a0827a7c718b9/

Just extended this PR to integrate the changes from https://github.com/cockroachdb/cockroach/pull/13094

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/22b5eeeb3b8f4c9784487ce2960c4f95ea4bf106/

 Thanks again, @knz! I'll deal with the sidenav in a follow-up pr. Excited to get this content to users.

Reviewed 16 of 21 files at r3.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

Comments from Reviewable


install error with CMakeLists.txt

Hello!  Very excited to be diving into your code!  I've gone through the installation setup twice on Ubuntu to make sure I didn't miss a step.  All goes well until the very end.  When I try to run this:
cmake -DCMAKE_PREFIX_PATH="${CONDA}/lib/python3.9/site-packages/torch/;${CONDA}" ..
I get this error:
The source directory "/mnt/c/Users/user/Documents/github/vet/External" does not appear to contain CMakeLists.txt.
Sure enough, that file doesn't exist for me.
Thoughts?
Thanks!

Also after installing pytorch, the "Compile VET" block needs to be executed in the main folder. I have added a "cd .." to the README. That also might have caused the problem

Ok great!  Doing both of those things resolved the issue.  To get through the rest I also had to install:
libxi-dev
libxcursor-dev
libxinerama-dev
libxrandr-dev
But then when I get to:
make -j10
I get an error if I run it from within build/  (The build dir is empty even though I ran cmake from inside this dir.)
make: *** No targets specified and no makefile found.  Stop.
However, if I run make -j10 from the External dir (where I found Makefile,) it runs, but then errors out:
CMake Error at /home/user/miniconda3/envs/vet/share/cmake-3.26/Modules/FetchContent.cmake:1622 (message):
Build step for absl failed: 2
Call Stack (most recent call first):
/home/user/miniconda3/envs/vet/share/cmake-3.26/Modules/FetchContent.cmake:1762:EVAL:2 (__FetchContent_directPopulate)
/home/user/miniconda3/envs/vet/share/cmake-3.26/Modules/FetchContent.cmake:1762 (cmake_language)
/home/user/miniconda3/envs/vet/share/cmake-3.26/Modules/FetchContent.cmake:1976 (FetchContent_Populate)
External/or-tools/cmake/dependencies/CMakeLists.txt:71 (FetchContent_MakeAvailable)
So close!  I'm retracing my steps again as well.  Thanks for the help!

Ok, cool, retraced my steps and got past the the initial  make -j10 error. But now I get this one.  Any ideas?  Thanks for taking a look!
(vet) user@DESKTOP-39PR928:/mnt/c/Users/brian/documents/github/vet/build$ make -j10
make[1]: Warning: File 'CMakeFiles/Makefile2' has modification time 9.1 s in the future
make[2]: Warning: File 'CMakeFiles/NeAT.dir/progress.make' has modification time 6.6 s in the future
make[2]: Warning: File 'External/saiga/submodules/libpng/CMakeFiles/genfiles.dir/progress.make' has modification time 6.9 s in the future
make[2]: Warning: File 'External/saiga/submodules/googletest/googletest/CMakeFiles/gtest.dir/progress.make' has modification time 7.1 s in the future
make[2]: Warning: File 'External/saiga/submodules/zlib/CMakeFiles/zlibstatic.dir/progress.make' has modification time 7.6 s in the future
make[2]: Warning: File 'External/saiga/submodules/glog/CMakeFiles/glog.dir/progress.make' has modification time 7 s in the future
make[2]: Warning: File 'External/tensorboard_logger/CMakeFiles/tensorboard_logger.dir/progress.make' has modification time 7.5 s in the future
make[2]: Warning: File 'External/saiga/submodules/glfw/src/CMakeFiles/glfw.dir/progress.make' has modification time 7 s in the future
make[2]: warning:  Clock skew detected.  Your build may be incomplete.
make[2]: warning:  Clock skew detected.  Your build may be incomplete.
make[2]: Warning: File 'CMakeFiles/NeAT.dir/progress.make' has modification time 6.5 s in the future
make[2]: Warning: File 'External/saiga/submodules/libpng/CMakeFiles/genfiles.dir/progress.make' has modification time 6.8 s in the future
make[2]: warning:  Clock skew detected.  Your build may be incomplete.
[  0%] Performing configure step for 'NeAT'
[  0%] Generating pnglibconf.c
make[2]: Warning: File 'External/saiga/submodules/googletest/googletest/CMakeFiles/gtest.dir/progress.make' has modification time 7 s in the future
make[2]: warning:  Clock skew detected.  Your build may be incomplete.
[  1%] Generating scripts/pnglibconf.c
make[2]: warning:  Clock skew detected.  Your build may be incomplete.
make[2]: Warning: File 'External/saiga/submodules/glog/CMakeFiles/glog.dir/progress.make' has modification time 6.8 s in the future
[  1%] Generating scripts/symbols.chk
make[2]: Warning: File 'External/saiga/submodules/zlib/CMakeFiles/zlibstatic.dir/progress.make' has modification time 7.3 s in the future
make[2]: warning:  Clock skew detected.  Your build may be incomplete.
make[2]: warning:  Clock skew detected.  Your build may be incomplete.
options.awk: bad line (10): com
CMake Error at scripts/gensrc.cmake:68 (message):
Failed to generate pnglibconf.tf5
make[2]: *** [External/saiga/submodules/libpng/CMakeFiles/genfiles.dir/build.make:97: External/saiga/submodules/libpng/pnglibconf.c] Error 1
make[2]: *** Waiting for unfinished jobs....
make[2]: Warning: File 'External/tensorboard_logger/CMakeFiles/tensorboard_logger.dir/progress.make' has modification time 7.1 s in the future
make[2]: Warning: File 'External/saiga/submodules/glfw/src/CMakeFiles/glfw.dir/progress.make' has modification time 6.6 s in the future
Build Type: RelWithDebInfo
Build Options
options.awk: bad line (11): com
-- Option HEADLESS              ON
CMake Error at scripts/gensrc.cmake:41 (message):
Failed to generate pnglibconf.tf7
make[2]: *** [External/saiga/submodules/libpng/CMakeFiles/genfiles.dir/build.make:120: External/saiga/submodules/libpng/scripts/pnglibconf.c] Error 1
make[1]: *** [CMakeFiles/Makefile2:2245: External/saiga/submodules/libpng/CMakeFiles/genfiles.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....
make[2]: warning:  Clock skew detected.  Your build may be incomplete.
make[2]: warning:  Clock skew detected.  Your build may be incomplete.
[  2%] Built target gtest
[  3%] Built target glog
make[2]: warning:  Clock skew detected.  Your build may be incomplete.
make[2]: warning:  Clock skew detected.  Your build may be incomplete.
[  6%] Built target zlibstatic
[  8%] Built target tensorboard_logger
make[2]: warning:  Clock skew detected.    Your build may be incomplete.
gmake[5]: Entering directory '/mnt/c/Users/brian/documents/github/vet/build/NeAT/src/NeAT-build/_deps/absl-subbuild'
gmake[5]: Warning: File 'CMakeFiles/absl-populate.dir/progress.make' has modification time 497 s in the future
[ 12%] Performing patch step for 'absl-populate'
error: patch failed: CMakeLists.txt:41
error: CMakeLists.txt: patch does not apply
gmake[5]: *** [CMakeFiles/absl-populate.dir/build.make:113: absl-populate-prefix/src/absl-populate-stamp/absl-populate-patch] Error 1
gmake[5]: Leaving directory '/mnt/c/Users/brian/documents/github/vet/build/NeAT/src/NeAT-build/_deps/absl-subbuild'
gmake[4]: *** [CMakeFiles/Makefile2:83: CMakeFiles/absl-populate.dir/all] Error 2
gmake[4]: Leaving directory '/mnt/c/Users/brian/documents/github/vet/build/NeAT/src/NeAT-build/_deps/absl-subbuild'
gmake[3]: *** [Makefile:91: all] Error 2
gmake[3]: Leaving directory '/mnt/c/Users/brian/documents/github/vet/build/NeAT/src/NeAT-build/_deps/absl-subbuild'
CMake Error at /home/user/miniconda3/envs/vet/share/cmake-3.26/Modules/FetchContent.cmake:1622 (message):
Build step for absl failed: 2
Call Stack (most recent call first):
/home/user/miniconda3/envs/vet/share/cmake-3.26/Modules/FetchContent.cmake:1762:EVAL:2 (__FetchContent_directPopulate)
/home/user/miniconda3/envs/vet/share/cmake-3.26/Modules/FetchContent.cmake:1762 (cmake_language)
/home/user/miniconda3/envs/vet/share/cmake-3.26/Modules/FetchContent.cmake:1976 (FetchContent_Populate)
External/or-tools/cmake/dependencies/CMakeLists.txt:71 (FetchContent_MakeAvailable)
-- Configuring incomplete, errors occurred!
make[2]: *** [CMakeFiles/NeAT.dir/build.make:92: NeAT/src/NeAT-stamp/NeAT-configure] Error 1
make[1]: *** [CMakeFiles/Makefile2:1049: CMakeFiles/NeAT.dir/all] Error 2
make: *** [Makefile:156: all] Error 2

Hello, just following up.  Any insights?

Sorry for the delayed response! It seems that cmake doesn't like some differing date stamps in your files? Unsure why exactly.
It looks to me that you are using WSL? Maybe there are some issues with code pulled via windows and then compiled in Linux? Just guessing as I am not very familiar with WSL.
Please also note that the viewer may not work in WSL as we use a CUDA-to-OpenGL interop, which was not supported at least a while back

Unfortunately, we don't support Windows at the moment :(


Tabs are still filtered by window when changing to the new mode

The tab manager only shows the last window (1st when I tried) no matter which one you select.
This is a bug when changing between the classic mode and the new mode. While being in the classic mode with a window selected and then changing to the new mode, the tabs are still filtered by the window. Then, when you try to go to another window, there will be an error with the jQuery selector because the window doesn't exist (there is only one window when all of them should be there in the new mode)

#107 resolves this issue.


How to append an HTML element to an input's wrapper ?

Apologies if I'm missing something obvious, but is there a way to append an HTML element to the
 wrapper generated by an input helper?
For example, the first form example in the Bootstrap 4 docs includes a  element after the label and input elements for providing additional help text:

  Email address
  <input type="email" class="form-control" id="exampleInputEmail1" aria-describedby="emailHelp" placeholder="Enter email">
  We'll never share your email with anyone else.

Is there a way to do this with the current form helpers? I saw some other answers that used the :append option with html_safe, so I tried that but didn't get the output I was looking for:
<%= f.email_field :email, autofocus: true, append: 'We\'ll never share your email with anyone else.'.html_safe %>

  Email

    <input autofocus="autofocus" class="form-control" type="email" value="" name="user[email]" id="user_email">
    We'll never share your email with anyone else.

I also tried wrapping it in a f.form_group block, thinking that maybe this let me define the form-group block more explicitly, but as you probably already know that just adds an extra form-group div wrapper, which makes the spacing wrong:
<%= f.form_group do %>
  <%= f.email_field :email, autofocus: true %>
  We'll never share your email with anyone else.
<% end %>

    Email
    <input autofocus="autofocus" class="form-control" type="email" value="" name="user[email]" id="user_email">

  We'll never share your email with anyone else.

I ended up using text_field_without_bootstrap, which works totally fine of course:

  <%= f.label :email %>
  <%= f.text_field_without_bootstrap :email, class: "form-control", type: "email", autofocus: true %>
  We'll never share your email with anyone else.

Just wondering if I'm missing anything! Also thanks a lot for this gem.

Okay I see now that the :help option is for this specific example use case (although generates a ). Which is good because I realized what I was doing wasn't handling error messages :smile:.
However, it seems that form errors replace the help text message, which is something I don't want (see the bootstrap example of help text not erasing).
So am still somewhat curious if there's a more general solution for adding arbitrary elements or not.
I also tested #259's PR, but wrapper: false seems to not generate the corresponding  for the <input> so wasn't quite what I was looking for.

To my knowledge, :help is the "official" way to accomplish what you are looking for. In the more general case, I don't think there is a way to append arbitrary markup within the wrapper
.
Regarding the error overriding the :help, there is a separate issue for discussing that if you want to add your 2¢. Thanks!
https://github.com/bootstrap-ruby/rails-bootstrap-forms/issues/284

Sounds good, thanks!