Added "NAT" to the article

Added the term "Network Address Translation" and its definition to the article

[X] I have read freeCodeCamp's contribution guidelines.
[X] My pull request has a descriptive title (not a vague title like Update index.md)
[X] My pull request targets the master branch of freeCodeCamp.
[X] None of my changes are plagiarized from another source without proper attribution.
[X] My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.
Closes #XXXXX

Looks good. Congrats on your first contribution @sjoh29 👍


read-gcsobject error message ambiguous

Can we make "Read-GcsObject : Not Found" to "Object Not Found" instead? Otherwise I was confused as to whether the Read-GcsObject command itself wasn't found or something else. In general, the error messages should mention what wasn't found, e.g. "Bucket Not Found", "Object Not Found", etc.

This is fixed with https://github.com/GoogleCloudPlatform/google-cloud-powershell/pull/376. The error message will now be "Storage object 'blah' does not exist."


Implement FLORIS v3.4 scattered grid visualisation

The release of FLORIS v3.4 added support for probing velocities at arbitrary flow field points. This could greatly increase the speed at which flow field plots are being generated.
A first idea is to create a grid in OFF, distribute the grid points in a Voronoi matter to the closest turbine and then evaluate the grid points in the wake model of said turbine. The result should be a tiled view of all steady state simulations going on with all turbines. Might be a good idea to add lines to visualise which grid part belongs to which turbine.
An extension would be to add a weighted manner mix the TWFs instead of drawing hard lines between them.

Currently being worked on, alongside the FLORIS v4 adaptations.
For more details view linked branch.


NativeScript -NFC

Hi,
I downloaded the sample code provided. I run into following when I run the preview on Andriod.
ERROR in ./app.ts
Module not found: Error: Can't resolve 'C:/workspace2/NativeApp-NFC/OnlineProj/nativescript-nfc-master/demo/node_modules/nativescript-nfc/nfc-activity.js' in 'C:\workspace2\NativeApp-NFC\OnlineProj\nativescript-nfc-master\demo\app'
@ ./app.ts 6:0-124
I have android 11 and NFC is turned on.
I would appreciate your help.


merge: dev to master

:tada: This PR is included in version 0.107.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Update README.

Fix formatting mistake and spelling error.

Can one of the admins verify this patch?


Set CI to run on default branch: main

The default branch of this repo is set to main so this reflects that.

bors try


fix: Clipboard button icon color in the demo website.

🙋 Feature Request
The clipboard icon appears black in dark mode, and when switching the website mode to light, the color state remains unchanged unless the cache is cleared.
🤔 Expected Behavior
The website should use accent variant or white color in dark mode and when it switched to light mode the color state should also change to without clearing the cache.
😯 Current Behavior
The website use dark icon clipboard color in dark mode and won't change when the website mode changed to white.
💁 Possible Solution
N/A
🔦 Context
I want to the clipboard icon has a different color in the existing theme mode color in the website.
💻 Examples

Replacing the icon with a 'Copy' text. The highlightjs pluging used for this functionality can not respond well to theme changes so I replacedit with our own copy function. It can be seen already at https://preview.fluentui-blazor.net/. Will be rolled out to www site with next release


Remove Serial Number from Drop Down Labels for MobiFlight Modules and Joysticks

Is your feature request related to a problem? Please describe.
Remove Serial Number from Drop Down Labels for MobiFlight Modules and Joysticks
Describe the solution you'd like
The labels should simply show the name, because it doesn't help much anyways to show the cryptic serial to the user.
Describe alternatives you've considered
Still show it.
Show the COM Port for default Names, so that MobiFlight Boards can be told apart from each other.

I can knock this one out

Uuuuugh. This is not a straightforward thing @MobiFlight-Admin. Just removing the text from the dropdown label causes all sorts of problems:

Saved config files no longer properly populate the dialogs when you open them, since the identifier in the .mcc file is the name + serial number.
After selecting one of the entries in the device dropdown the modules dropdown doesn't populate.

Turns out there's quite a bit of logic that depends on the serial number being present in that dropdown label :(
Unassigning and kicking this back into the pool for people to consider. Not sure it's worth the effort to change anymore.

Haha, ok - there is a difference between value and label... if we use proper ListItems it should be doable pretty easily. but it is quire repetitive


Use single macro to control each feature

Describe your changes
Adjust macro usage to ensure that a single macro is used to enable/disable each feature.
AX_USE_PHYSICS renamed to AX_ENABLE_PHYSICS
AX_USE_3D_PHYSICS renamed to AX_ENABLE_3D_PHYSICS
AX_USE_NAVMESH renamed to AX_ENABLE_NAVMESH
AX_ENABLE_PHYSICS3D renamed to AX_ENABLE_3D_PHYSICS to make it easier to distinguish from AX_USE_PHYSICS.
AX_USE_3D_PHYSICS and AX_USE_NAVMESH are only defined if the respective module is enabled via cmake options, so they need to be checked by #if defined(AX_USE_3D_PHYSICS) etc.
Issue ticket number and link
Related PR #1769
Checklist before requesting a review
For each PR

[x] Add Copyright if it missed:
- "Copyright (c) 2019-present Axmol Engine contributors (see AUTHORS.md)."

[x] I have performed a self-review of my code.
Optional:

[ ] I have checked readme and add important infos to this PR.
[ ] I have added/adapted some tests too.

For core/new feature PR

[ ] I have checked readme and add important infos to this PR.
[ ] I have added thorough tests.

@halx99 Attempting to run tools/tolua/genbindings.py doesn't generate the cpp files, and adds a lot of blank lines in the header files that are generated.  Is there something I need to set up to get the generator working on my system?

@halx99 The android checks are failing with "ld: error: unable to find library -lpthread", but I'm not sure if it's related to this PR.


[DO NOT MERGE] indexer: introduce an object balance processor

running now, no issues so far and the objects_history table is being populated


Update string-width to fix vulnerable ansi-regex

Upgrade the string-width package to ^4.2.3, as it contains the transitive ansi-regex package in which the vulnerability was found.
Dependency tree:
<EMAIL_ADDRESS>  ><EMAIL_ADDRESS>|| 2"
    ><EMAIL_ADDRESS>      ><EMAIL_ADDRESS>
Snyk report: https://app.snyk.io/vuln/SNYK-JS-ANSIREGEX-1583908
GitHub Advisory Database: https://github.com/advisories/GHSA-93q8-gq69-wqmw

This makes multiple changes and I'd prefer things to be more targeted. I've added my own commits to produce functionally the same result and published a new version.


cannot push to localhost

Pushing to a registry on localhost
docker push localhost:5000/mongodb
FATA[0000] Error: v1 ping attempt failed with error: Get http://localhost:5000/v1/_ping: dial tcp <IP_ADDRESS>:5000: connection refused

fails although this looks OK
$ curl http://localhost:5000
"\"docker-registry server\""

as on OSX we are essentially talking to a VM running docker this is not that much of a surprise.
Of course on that VM localhost is -well- that VM and not the OSX host.
But shouldn't this "just work"? Is there at least any easy workaround to make this work?
The only one I see at the moment is to not use localhost but a name, lot's of /etc/hosts messing and it would involve quite a lot of swearing.

I'm not sure what you have set up - are you running the registry on the OSX box, in the boot2docker vm, or in a container on the boot2docker vm? (I'd do the last..)
and yes, you're talking about nteworking, so localhost is not going to be the same thing everywhere.
but ... docker pull and docker push run on in the docker daemon, so if your registry was running on the vm, it would have worked out :)

I had the registry running in a separate vagrant vm with the port mapped to the host.
So the "why" is pretty clear now. It still sucks though :)

maybe your registry server and docker engine are not running at same vm, it dose make sense.
localhost:5000 for OSX was forwarding to registry server, but for docker engine daemon, it's another machine.


wiki page title that contains no escape #

gogs <IP_ADDRESS>9
Gogs version (or commit ref):
Git version: git version 2.7.2.windows.1
Operating system:windows 2008 r2
Database:
[ √] MySQL
Description
wiki page title that contains no escape #
http://<IP_ADDRESS>:3000/root/test/wiki/_pages##-1-业务部分/_edit

Gogs version: <IP_ADDRESS>3
Git version: 2.1.4
Operating system: Debian Jessie
Database: MySQL

--
I have the same problem with ? in file names in a "normal" repository.
Currently: https://gogs.tld/user/repository/src/master/abc?def
Should be: https://gogs.tld/user/repository/src/master/abc%3Fdef
(Replaced all ? with %3F)

https://github.com/gogits/gogs/pull/3287 has some related changes, back on this until that PR has been merged.

This is fixed in master.


Safer (unicode-safe) flaky test report

Verified that @potrebic has signed the CLA. Thanks for the pull request!


Update bitwarden image

The bitwarden image referenced is a fork of the original and not maintained as much as the original...

Looking good, thanks @psarossy !


Update conda_and_docs_build.yml

Describe your changes
Use newest https://github.com/TomographicImaging/conda-package-publish-action v2
Describe any testing you have performed
Please add any demo scripts to CIL-Demos/misc/
Link relevant issues
Checklist when you are ready to request a review

[x] I have performed a self-review of my code
[x] I have added docstrings in line with the guidance in the developer guide
[x] I have implemented unit tests that cover any new or modified functionality
[x] CHANGELOG.md has been updated with any functionality change
[x] Request review from all relevant developers
[x] Change pull request label to 'Waiting for review'

Contribution Notes
Please read and adhere to the developer guide and local patterns and conventions.

[x] The content of this Pull Request (the Contribution) is intentionally submitted for inclusion in CIL (the Work) under the terms and conditions of the Apache-2.0 License.
[x] I confirm that the contribution does not violate any intellectual property rights of third parties

should merge this soon as it's more than 2x quicker build times :)


update chinese docs

Synchronize the ReadMe
translate  migration guides
translate  some files in docs_CN

Codecov Report

Merging #1360 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1360   +/-   ##
=======================================
  Coverage   81.81%   81.81%
=======================================
  Files           7        7
  Lines         187      187
=======================================
  Hits          153      153
  Misses         34       34

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e10aac0...7db9241. Read the comment docs.

@BasThomas @stephencelis @steam @shanev  hi    Do I need to  click on "merge pull request" button（show below）
or wait for someone else to check the branch then make merge ?

Hey @lovesomeone, great question 😃
I usually wait for a couple Moya Core Team members to approve my pull requests before merging. Personally, I never merge my own PRs 😅
It's good to get a few pairs of eyes on everything if possible. I know this is related to Chinese so reviewers are sparse, but @BasThomas was still able to give some feedback.

This is awesome :)
Can you delete c9981ee and rebase instead? I think it's ready to merge after that

Hey  @AndrewSB  .   Because I  never used rebase on github，can you tell me how to do it.  Or can someone help to delete c9981ee and rebase. Thank you!

@lovesomeone for sure!!
So you're going to do two things.

delete that commit
rebase your branch onto the latest Moya:master.

git rebase is a really interesting and often hard to understand tool, https://git-scm.com/book/en/v2/Git-Branching-Rebasing is a great resource if you're interested.
To delete the commit, you're going to do an interactive rebase (see https://stackoverflow.com/a/1338756)
so I think the command will be
git rebase -i c9981ee~1

which will bring up your $EDITOR, where you should drop c9981ee and save. That should delete the commit
To rebase your changes onto Moya:master, first you'll need to have Moya/Moya as a git remote (you can see all your remotes with git remote -v), assuming you have it as a remote named origin that points to Moya/Moya, you can
git fetch origin
git rebase origin/master

and if that worked without error, you can force push to your fork (assuming the remote is named lovesomeone)
git push lovesomeone -f

let me know if I can clear anything up or if I was confusing anywhere!

I assume this one can be closed now as #1365 went on.


Create-react-app issue

I saw there was a fix for this that was already merged in, but I'm still running into the same issue;
I can render the GraphiQL UI, but it only renders half of it!
I'm on a Windows environment, using FF, Chrome, and IE

@Magneticmagnum could you give some more information about your issue and how to repro it?

Hey @asiandrummer ,
I have an example here: https://github.com/Magneticmagnum/graphiqlTest
It is a barebones create-react-app that tries to render GraphiQL in App.js
The CSS is imported into the project in import 'graphiql/graphiql.css';

@Magneticmagnum the parent element of GraphiQL needs to have an explicit height for the component to render properly. You can set the height to be the full height of the viewport like this:
.App {
  height: 100vh;
}

(You should also remove the text-align: center style from .App to fix the text alignment.)

@Magneticmagnum I'm closing due to an inactivity - let us know && reopen this issue if @fson's suggestion doesnt resolve your issue!


"EntityFramework.SQLite": "7.0.0-rc1-final" get Internal compiler error when used with Microsoft.OData.Client

Hello guys,
The issue is similar to this one https://github.com/aspnet/EntityFramework/issues/4511 .
EntityFramework.SQLite (7.0.0-rc1-final) cause several compiler errors when used with Microsoft.OData.Client (v 6.15.0) in one project when build in Release mode of Universal Windows application:
The type name 'RCWAdapterClass' does not exist in the type 'System.Collections.Generic.IEnumerable_A_System_Collections_Generic_IEnumerable_A_System_Collections_Generic_IEnumerable_A_System_Collections_Generic_IEnumerable_A_System_Collections_Generic_IEnumerable_A_System_Collections_Generic_IEnumerable_A_System_Collections_Generic_IEnumerable_A_System_Collections_Generic_IEnumerable_A_System_Collections_Generic_IEnumerable_A_System_Collections_IEnumerable_V__V__V__V__V__V__V__V__V___Impl'	in ImplTypes.g.cs
We should release our application at the end of the spring.
So is there any workaround or some hotfix for this issue? Or any chance that rc2 will be released before summer?

This should all be fixed in RC2. In RC1 we had a whole bunch of custom stuff around reflection info to support .NET Native. In RC2 this all goes away thanks to some improvements from the .NET Native team. Unfortunately you can't try it out just yet, as you'll need a UWP tooling update to support RC2.


net/net_pkt: Fix is_ppp dependency issue

The functions net_pkt_is_ppp() and net_pkt_set_ppp() are used by both the l2 ppp subsystem (NET_L2_PPP) and the ppp uart based driver (NET_PPP), but the function is only included when NET_PPP is enabled.
the l2 ppp subsystem does not depend on the uart based PPP driver, the ppp uart driver does however depend on the l2 ppp subsystem. Including the two functions should therefore be dependent on if the l2 ppp subsystem is enabled using the symbol CONFIG_NET_L2_PPP instead of the symbol CONFIG_NET_PPP
The dependency issue was detected while creating a PPP interface which depends on the L2 PPP subsystem, which does not require the UART based PPP driver.
Signed-off-by: Bjarki Arge Andreasen<EMAIL_ADDRESS>Fixes https://github.com/zephyrproject-rtos/zephyr/issues/54378

@bjarki-trackunit A bug report is required in order for this PR to be merged during the feature freeze. Please file a bug report issue for the problem that this PR is trying to fix and link the issue to this PR.

@stephanosio Buf report has been filed :)

@stephanosio Bug report has been filed :)

Thanks!


Add apache2 LICENSE

Copied from https://github.com/ManageIQ/ui-components, https://github.com/ManageIQ/ui-components is also on Apache 2.
Previously the file was empty here.

:tada: This PR is included in version 0.11.42 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Standardize revert exceptions between calls and transactions

What I did
Ensure revert messages are consistent between reverting calls and transactions.
How I did it

Move the majority of the message formatting logic to TransactionReceipt.__init__.
Ensure dev revert comments are included on failed calls.

Some of this code feels hacky, but I didn't want to make any changes that could be considered breaking to the API.  In the v2.0.0 refactor, all of this code will have to be revisited.
How to verify it
Run tests.

Related - #330


Can Sheared-LLaMA beat OpenLLaMA v2 significantly with the same amount of compute ?

We can see from the picture that  Sheared-LLaMA is on par with OpenLLaMA v2 with 1/32 compute, which is quite impressive. But from my experience, knowledge distillation and pruning is very data efficient indeed, but can not surpass pre-training from scatch significantly due to the size limit of the target model. I wonder if you train Sheared-LLaMA-2.7B longer, is it possible to surpass Open-LLaMA-3B-v2 by 4~5% on average downstream performance ?

Hello! We believe that Sheared-LLaMA has the potential to significantly improve its performance as the number of training tokens increases, as indicated by the observed trend. We weren't able to put in more compute because of computational constraints on our end.

Try mistral7b to see when we can have a 3d compareable with 7b model


HttpOpener  shall be able to handle GZIP encoding

HttpOpener , aka decode-html when speaking flux, is not able to decode gziped data atm.

Working on it I noticed in https://github.com/metafacture/metafacture-core/blob/52e41414fff130c183151dbb64810f259548ddf8/metafacture-io/src/test/java/org/metafacture/io/HttpOpenerTest.java#L259 the setting of content-encoding header to UTF-8. This seems invalid:

The content-encoding specifies the data transfer encoding used by the issuer of the content. UTF-8 is not a content encoding, it is a character set. Specifying the character set is done in the content-type header

(https://stackoverflow.com/questions/17154967/is-content-encoding-being-set-to-utf-8-invalid)


Rewrite docker-compose and config script

As with newest Drone CI, it's time to fully migrate this to comply with their recommendations.

[ ] Switch from MariaDB to PostgreSQL
[ ] Enable SSL support with Lets Encrypt
[ ] Set DRONE_COOKIE_SECRET to avoid losing login sessions
[ ] Use drone/drone-runner-docker instead of the deprecated agent image
[ ] Add their official GitHub Teams extension

https://github.com/orgs/LawnchairLauncher/teams/drone-ci


Problem with background-parsing (i.e. compute function) example in docs

When running this example:
https://flutter.io/cookbook/networking/background-parsing/
I get a runtime error:
List' is not a subtype of type 'List
I think the problem has nothing to do with the compute function. The issue is this part:
List<Photo> parsePhotos(String responseBody) {
    final parsed = json.decode(responseBody);
    return parsed.map((json) => new Photo.fromJson(json)).toList();
  }

What ever toList() is returning is not the correct type.
This code works:
List<Photo> parsePhotos(String responseBody) {
    final parsed = json.decode(responseBody);
    List<Photo> photos = [];
    for (var jsonObject in parsed) {
      Photo photo = Photo.fromJson(jsonObject);
      photos.add(photo);
    }
    return photos;

It looks the inference for map is failing, and parsed becomes List<dynamic>.  If you replace parsePhotos with the following do you still get a type error?
List<Photo> parsePhotos(String responseBody) {
    final parsed = json.decode(responseBody);
    return parsed.map<Photo>((json) => new Photo.fromJson(json)).toList();
  }

@StokeMasterJack

Hey all, sorry about this one! I've got a PR with a fix up for this on the Website repo, but it hasn't been reviewed quite yet. I've pinged a few folks to see if they can help out!

I am getting "object is a closure - Function 'parsePhotos'" this error:
[ERROR:topaz/lib/tonic/logging/dart_error.cc(16)] Unhandled exception:
Invalid argument(s): Illegal argument in isolate message : (object is a closure - Function 'parsePhotos':.)
#0      Isolate._spawnFunction (dart:isolate/runtime/libisolate_patch.dart:510:59)
#1      Isolate.spawn (dart:isolate/runtime/libisolate_patch.dart:361:7)
<asynchronous suspension>

I am getting the same "Illegal argument in isolate message " error.

@brianegan Please look at this.

Thanks all -- just back from vacation. I'll take a look tomorrow.

@brianegan welcome back, did you get the time to look at this?

Sorry @vipulasri, arrived home from travel to some family health problems and didn't get a chance yet. I'll update soon!

Heya @vipulasri -- just ran the recipe from the Cookbook, and it seems to be running for me. Does the example in the Flutter cookbook work, or is that failing?
If the example is failing, could you please copy and paste the results of flutter doctor -v? If you're trying this out with your own classes, please note the restrictions on passing objects between isolates: https://flutter.io/cookbook/networking/background-parsing/#notes-on-working-with-isolates
It sounds like you might have a class that contains closures (Functions) as data, and that will throw an error.

@brianegan Yeah, I am trying put with my own class. I am unable to figure out to make it work. Thanks for looking into it.

@vipulasri Gotcha! Yep, the objects you can pass back and forth between Isolates generally need to be  "primitive types" such as Strings, ints, etc.
If you have a class that contains a closure (such as final Function() myFunc;, you'll see Dart throw errors. In these cases, you might need to rework the classes you're passing back and forth a bit to contain only simple data.

@brianegan Thanks for this detailed explanation. Earlier, I wasn't able to quite properly understand it.

Good feedback, I'll update the recipe to add a bit more detail.

@brianegan btw I followed the same way that is depicted in sample: https://flutter.io/cookbook/networking/background-parsing/ but for my code, still facing the issue.
My Code:
class Api {

Future <List<Painting>> getFeaturedArts(int page) async {
	final url = "https://www.wikiart.org/?json=2&layout=new&param=featured&layout=new&page=$page";
	final response = await http.get(url);
	return compute(parseFeaturedArts, response.body);
}

List<Painting> parseFeaturedArts(String response) {
	final responseJson = json.decode(response);
	final paintingResponse = new PaintingResponse.fromJson(responseJson);
	return paintingResponse.paintings;
}

}

Though, I am not using FutureBuilder.

Heya @vipulasri -- I don't think FutureBuilder would make the difference. The above code generally looks fine to me. Could you please show me the code for your Painting class?

@brianegan Here it is: https://gist.github.com/vipulasri/669e76299f1784d13ad3aa311ccf1e9d

Ah wait, sorry -- I'd missed something in the first piece of code you pasted. This is another odd restriction in Dart -- you can't pass a method of a class across isolates. You must extract the parseFeaturedArts function out as a top-level function.
If you arrange your code like so, it should work:
class Api {
  Future<List<Painting>> getFeaturedArts(int page) async {
    final url =
        "https://www.wikiart.org/?json=2&layout=new&param=featured&layout=new&page=$page";
    final response = await http.get(url);
    return compute(parseFeaturedArts, response.body);
  }
}

List<Painting> parseFeaturedArts(String response) {
  final responseJson = json.decode(response);
  final paintingResponse = new PaintingResponse.fromJson(responseJson);
  return paintingResponse.paintings;
}

@brianegan Awesome 👍 It worked! All these things should be mentioned in the documentation :(

Fair point, I'll add that info!

@brianegan Also seems the callback function (parseFeaturedArts) cannot return results of asynchronous functions (basically can't do await on other functions)? Because then it would have to return a Future, but it must return a value?

@brianegan I get this error from the updated code on the cookbook link https://flutter.io/cookbook/networking/background-parsing/
E/flutter (31340): NoSuchMethodError: Class '_InternalLinkedHashMap<String, dynamic>' has no instance method 'map' with matching arguments.
E/flutter (31340): Receiver: _LinkedHashMap len:2
E/flutter (31340): Tried calling: map<Yaip>(Closure: (dynamic) => Yaip)
E/flutter (31340): Found: map<K2, V2>((K, V) => MapEntry<K2, V2>) => Map<K2, V2>

same, i gave up with the example as it was outdated or something as it always broke down

Heya @johnny-stevie -- could you describe the problem you're seeing? I've just run the sample code against Flutter Stable, Beta, and Master channels and I didn't encounter any issues.

Hello, in my project I'm facing this problem:

Invalid argument(s): Illegal argument in isolate

Then I replaced my with the original example:
` Future<List> fetchPhotos(http.Client client) async {
final response =
await client.get('https://jsonplaceholder.typicode.com/photos');
return compute(parsePhotos, response.body);
}
List parsePhotos(String responseBody) {
final parsed = jsonDecode(responseBody).cast<Map<String, dynamic>>();
return parsed.map((json) => Photo.fromJson(json)).toList();
}
`
but unfortunatelly I'm facing the same problem:
[VERBOSE-2:ui_dart_state.cc(157)] Unhandled Exception: Invalid argument(s): Illegal argument in isolate message : (object is a closure - Function 'parsePhotos':.)
#0      Isolate._spawnFunction (dart:isolate-patch/isolate_patch.dart:541:55)
#1      Isolate.spawn (dart:isolate-patch/isolate_patch.dart:381:7)
Here is my Flutter configuration:
`[✓] Flutter (Channel master, v1.16.4-pre.73, on Mac OS X 10.15.2 19C57, locale it-IT)
• Flutter version 1.16.4-pre.73 at /Users/antoninobajeli/Documents/FlutterSDK/flutter
• Framework revision 6fddb7ee8c (5 hours ago), 2020-04-02 10:31:03 -0700
• Engine revision c9506cb8e9
• Dart version 2.8.0 (build 2.8.0-dev.18.0 eea9717938)
[✓] Android toolchain - develop for Android devices (Android SDK version 28.0.3)
• Android SDK at /Users/antoninobajeli/Library/Android/sdk
• Platform android-29, build-tools 28.0.3
• ANDROID_HOME = /Users/antoninobajeli/Library/Android/sdk
• Java binary at: /Applications/Android Studio 3.5.app/Contents/jre/jdk/Contents/Home/bin/java
• Java version OpenJDK Runtime Environment (build 1.8.0_212-release-1586-b4-5784211)
• All Android licenses accepted.
[✓] Xcode - develop for iOS and macOS (Xcode 11.3.1)
• Xcode at /Applications/Xcode.app/Contents/Developer
• Xcode 11.3.1, Build version 11C504
• CocoaPods version 1.8.3
[✓] Chrome - develop for the web
• Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome
[✓] Android Studio (version 3.6)
• Android Studio at /Applications/Android Studio 3.5.app/Contents
• Flutter plugin version 44.0.2
• Dart plugin version 192.7761
• Java version OpenJDK Runtime Environment (build 1.8.0_212-release-1586-b4-5784211)
[✓] VS Code (version 1.43.2)
• VS Code at /Applications/Visual Studio Code.app/Contents
• Flutter extension version 3.8.1
[✓] Connected device (3 available)
• iPhone di Antonino Bajeli • 1dc32573e1ee148d13ae7c8cee583152725b9185 • ios            • iOS 12.4.5
• Chrome                    • chrome                                   • web-javascript • Google Chrome 80.0.3987.149
• Web Server                • web-server                               • web-javascript • Flutter Tools
`

@brianegan I've given up on that already and moved on to another part of my project. Thanks for offering to help anyway!

I solved by myself.
My mistake has been to put both metohss inside the same class.
The solution has bee to put the method calling 'compute' in a class "MyClass" and the method called by the 'compute' outside "MyClass" class.
May be this can be an help for other facing the same problem.
Tony


Data Science with Python : Automated Essay Grading

Description
Welcome to the 'DSWP' Team, good to see you here.
With this issue, it will help us in grading the essay automatically using machine learning
Dataset : https://www.kaggle.com/c/asap-aes/data
To get assigned to this issue, add your serial numbers mentioned in the spreadsheet of "Data Science with Python", the approach one would follow and the choice you prefer (Documentation, Audio, Video). You can go with all three or any number of options you're interested to work on.
If you had referred any resources, add them up in "DS Resources". Similarly, if you had used datasets, include them in "DS Datasets".
Domain: Kaggle Competitions
Mentors Assigned : Nithin | Aarya Patel
Points to Note :
The issues will be assigned on a first come first serve basis, 1 Issue == 1 PR.
"Issue Title" and "PR Title" should be the same. Include issue number along with it.
Changes should be made inside the Datascience_With_Python/ directory & Datascience_With_Python branch.
Follow Contributing Guidelines & Code of Conduct before start Contributing.
This issue is only for 'GWOC' contributors of 'DSWP' domain.
All the best. Enjoy your journey ahead. 😎
Domain
Data Science with Python
Type of Contribution
Audio, Video, Documentation
Code of Conduct

[X] I follow Contributing Guidelines & Code of conduct of this project.

./assign Documentation

/assign Documentation, I would write up a step by step process of making this model.

Don't self assign yourself. Instead add details before doing so and ask for confirmation so that i can assign it. @eliziaeve7

@prathimacode-hub  Mam please assign this issue to me I have 4 merged PR's. I want to work on one more PR.
serial number : 295
approach : Implementing automatic essay grading system using machine learning
Choice : documentation

Issue assigned to @vishnupriya129 for documentation


Didx 272 merge workflows into upstream

Implements #304
continuous build pipeline:

Build, deploy and test against private EKS cluster
Self-hosted runner
Clean startup

docker-compose enhancements and improvements:

ability to reference pre-built images by passing --no-build set REGISTRY and IMAGE_TAG
handling inter-service startup dependencies
removed sleep hacks

dockerfile enhancements:

Dockerfile ENTRY_POINT instead of CMD to allow overriding args with k8s see: https://jamesdefabia.github.io/docs/user-guide/containers/

test improvements/workaround:

./app/facades/acapy_ledger.py: accept_taa_response hack
source ./app/tests/util/constants.py as env vars allowing override
./app/generic/definitions.py fix to check for 405 response code
./app/tests/e2e/test_connections.py improvement to assert both http/https

Maximum access for pull requests from public forked repositories for scope id_token is read. Pipeline can't authenticate.


Adjusted jenkins-agent script for direct connection

Remoting#3.34 introduced direct inbound TCP agent connections (to masters without Web UI/HTTP port). The feature is documented here.
This Pull Request adds the required parameters to the jenkins-agent script. In particular this change is needed to enable the Kubernetes plugin to make use of this feature, e.g. in combination with Jenkinsfile Runner on Kubernetes (without HTTP port).

Created https://github.com/jenkinsci/docker-slave/releases/tag/3.35-3 to unblock it

Created https://github.com/jenkinsci/docker-slave/releases/tag/3.35-3 to unblock it

Thanks @oleg-nenashev. I updated the Dockerfiles. The Pull Request is ready for review and merge now, from my perspective.


Fixes nest making under windows.

Hotfix - changes makefile to fix problem with making Nests on Windows. Tested on Windows and Mac.


screen reader accessibility of www.caniuse.com

it'd be great if www.caniuse.com was accessible for screen reader users because knowing what is supported by browsers is an important part of providing solution recommendations for accessibility issues. Some suggestions include marking up the support tables using HTML table mark-up or suitable ARIA roles so that these can be navigated and understood effectively; providing accessible names for all interactive elements including text inputs, hyperlinks, and buttons; using HTML sectioning elements/ARIA landmark regions correctly and providing them with an accessible name.

I'd be happy to do what I can to improve screen reader accessibility, thanks for pointing this out. Previously I'd made changes and additions to this end, including making each support "cell" focusable with a aria-describedby attribute that in theory should make the tooltip info be read which provides more information on a browser version's support level. Admittedly I don't know how well that works in practice and I'm sure other parts of the site could use improvements. Definitely something I'd like to improve, if there's any more specifics you can suggest I'd be happy to hear them.

yeah, sure. it'd need pretty major surgery to be WCAG conforming, but there's a bunch of things that can make it more accessible for a screen reader user .... I hadn't actually realised that each 'table cell' has an aria-describedby using a screen reader primarily because - contrary to common misconceptions - using the TAB key to navigate content is incredibly inefficient .. it would have taken me half the day to get to these items, and, without being focused using tab, the content of the aria-describedby isn't announced ... so what's the best way to provide specifics?


Make it work for OS X

OS X has deprecated ucontext after 10.6.

thanks for telling that truth, weird OSX. I'll merge it sometime.


feature request: estimating size of backup

It's strange to fail in backup chroot due to insufficient space with 32GB USB thumb drive. Even if the backup packs up Download folder (other than this, I cannot think of any other possibility) it cannot be such amount of size as I don't keep any large files in there. Eventually failing after waiting backup procedure to take almost two hours with filling up 32GB, would make anyone feel futility.
Anyway, Is there specific way to estimate the size of backup? Would be better to have such feature in order to prepare sufficient storage beforehand.

@midnightradio -
Try: du -sh /usr/local/chroots/[CHROOTNAME] to get the total size of your chroot.
I just did a backup of my wheezy chroot and this is what I got:

4.5G    /var/crouton/chroots/wheezy/
1.9G    ~/downloads/wheezy.tar.gz

That compressed size looks to be about 42% when using tar and gunzip
The backup time and rate were:

81MiB [2.81MiB/s] [>                                         ]  0% ETA 0:25:18

The crouton author is looking at providing more feedback when doing backups, restorals, and encryption using a program called pv for 'pipeview', this will display the info. similar to what I got above.
It will provide realtime estimates of rate and completion time - very helpful for most of us I think.

I'm not recommending this right now but, if you're sure your chroot is unmounted and not in use, you can try the following to do a backup with estimated rate and completion times:
NOTE: substitue [CHROOTNAME] with your actual chroot name in the 3 locations below!
tar cf - /usr/local/chroots/[CHROOTNAME] -P |\
    pv -i 5 -w 80 -berps $(du -sb /usr/local/chroots/[CHROOTNAME] |\
    awk '{print $1}') | gzip > [CHROOTNAME]-`date '+%Y%m%d-%H%M'`.tar.gz

@DennisLfromGA Thank you very much for your answer in detail. I thought it supposed be more complicated than just checking disk usage (du) somehow...


Problem with the Simulator when changing the Max topology number and the max bandwidth

Hello,
I'm a PHD student and i'm trying to use your model.
I want also to create a custom dataset for the validation and prediction purpose but when the (network_size >10 or bandwidth >100000)
the simulator does not work properly and returns an exception related to the existence of the folder /data.{ctr} (not created) even i changed the parameters max topology size and max bandwidth in the Simulate.py file.
So my questions are:
-- there are other parameters that i should  change in the simulator?
-- how did you create your validation dataset (50, 100, 150...nodes)?
thanks in advance for helping.
regards,
Sofiane MESSAOUDI

Hey, I also had the same problem, would love if you could help us,
thanks

Hello,
There is a docker version of the simulator without the limitations imposed by the challenge. You can find instructions to use it in this repository:https://github.com/BNN-UPC/BNNetSimulator
Regards
Albert


clj-kondo: 2021.12.19 -> 2022.01.15

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/clj-kondo/clj-kondo/releases.
meta.description for clj-kondo is: "A linter for Clojure code that sparks joy"
meta.homepage for clj-kondo is: "https://github.com/clj-kondo/clj-kondo"
meta.changelog for clj-kondo is: "https://github.com/clj-kondo/clj-kondo/blob/v2022.01.15/CHANGELOG.md"
Updates performed

Version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
Warning: no invocation of /nix/store/y0jdbc4dc2c0fzrbzvhhncg9jd0bhbzf-clj-kondo-2022.01.15/bin/clj-kondo had a zero exit code or showed the expected version
0 of 1 passed binary check by having a zero exit code.
0 of 1 passed binary check by having the new version present in output.
found 2022.01.15 with grep in /nix/store/y0jdbc4dc2c0fzrbzvhhncg9jd0bhbzf-clj-kondo-2022.01.15
found 2022.01.15 in filename of file in /nix/store/y0jdbc4dc2c0fzrbzvhhncg9jd0bhbzf-clj-kondo-2022.01.15

Rebuild report (if merged into master) (click to expand)

2 total rebuild path(s)

1 package rebuild(s)

1 x86_64-linux rebuild(s)
1 x86_64-darwin rebuild(s)

First fifty rebuilds by attrpath
clj-kondo

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/y0jdbc4dc2c0fzrbzvhhncg9jd0bhbzf-clj-kondo-2022.01.15 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A clj-kondo https://github.com/r-ryantm/nixpkgs/archive/978211bedf2cd1f502cb174e1489fd3a62719039.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/y0jdbc4dc2c0fzrbzvhhncg9jd0bhbzf-clj-kondo-2022.01.15
ls -la /nix/store/y0jdbc4dc2c0fzrbzvhhncg9jd0bhbzf-clj-kondo-2022.01.15/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

clj-kondo

Maintainer pings
cc @jlesquembre @bandresen @thiagokokada for testing.

@ofborg eval


added run in postman

postman now has a "run in postman" feature. This adds a button to our website through which you can add a postman collection to your postman app and start making requests to our api right away.

:confetti_ball: :tada:  Awesome! :+1:


Adds pagination to extension request list

Issue: https://github.com/Real-Dev-Squad/website-dashboard/issues/430
What is the change?

Currently we are able to filter api data based on only one value for a query param eg:  ?status=APPROVED. This PR allows us to filter the data based on multiple values eg: ?status=APPROVED&status=PENDING
This PR also adds pagination support for the api. To get paginated result we would have to pass the required page size ?size=10.
-This PR also adds a functionality to sort the data based on created time.eg: ?order=asc

Note to Reviewers:

The feature is under a feature flag. To access, please use ?dev=true query param.

Test stats
Before :

After:

*Dev Tested?

[x] Yes
[ ] No

Screenshot:

Indexes :
The following indexes needs to be created with these change:

hey Ajeyakrishna, In case we want to use multiple params we must use query params like
q=status:assigned+available we wont be using & (Moving to RDS's own query language)

I took inspiration for this design from an API that's currently being used in RDS:

I don't mind making your requested changes for this PR.
But I also think we should create a separate issue to identify and migrate the other API which are not using the format that you've mentioned.
Let me know your thoughts on the same.

hey Ajeyakrishna, In case we want to use multiple params we must use query params like
q=status:assigned+available we wont be using & (Moving to RDS's own query language)

@RitikJaiswal75 I need a more clarity on this.
What if we have two keys with multiple values eg: ?status=APPROVED&status=PENDING&assignee=user1&assignee=user2.
How will we handle this in the format that you have mentioned

Please update the API contracts for it

Please update the API contracts for it

Ive raised a PR for the same: https://github.com/Real-Dev-Squad/website-api-contracts/pull/154


Improper rendering of unicode surrogate pairs in terminal

VSCode Version: Code 1.7.1 (02611b40b24c9df2726ad8b33f5ef5f67ac30b44, 2016-11-03T13:46:00.226Z)
OS Version: Darwin x64 15.6.0
Extensions:

Extension
Author
Version

html-snippets
abusaidm
0.0.18

python
donjayamanne
0.5.2

ocaml
hackwaly
0.6.9

haskell-linter
hoovercj
0.0.6

vscode-ghc-mod
hoovercj
1.0.1

language-haskell
justusadam
1.2.2

vscode-clang
mitaki28
0.2.1

The terminal seems to render both characters of a surrogate pair instead of rendering it as a single glyph. This causes alignment issues in my ncurses-based project (not a blocker, just something odd I noticed).
See screenshot

@agentultra do you have some minimal repro steps? I have a feeling it's related to the width of the character being wrong.

Upstream issue https://github.com/sourcelair/xterm.js/issues/467

I think this is fixed now in stable


Make future releases to be just the addon

I'll try this plugin, seems cool, but in the meanwhile, i want to suggest to make future releases to be just the addon folder or the anima plugin folder, not the entire repository source code.
This way, everyone can download only the plugin and also keep it updated via git.

just moved the demos in a different repo.


Add starring feature

All this permission is required? 😕

cc @samuelli :)

@abdonrd: Yeah, it's super unfortunate :(
https://developer.github.com/v3/oauth/#scopes
"Also required for starring public repositories."
I've already filed multiple feature requests for alternative workarounds like starring as a separate scope

@samuelli thanks for the explication! :(


feat: added company who uses Apache APISIX logo

Fixes: #[Add issue number here]
Changes:

added company who uses Apache APISIX logo
Screenshots of the change:

Nice

思必驰信息科技股份有限公司
浙江大东鞋业有限公司
上海合合信息科技股份有限公司

The above logo is white and needs to be replaced
The logo that can be added has been added, the rest of the CC @iamayushdas

思必驰信息科技股份有限公司

浙江大东鞋业有限公司

上海合合信息科技股份有限公司

The above logo is white and needs to be replaced
The logo that can be added has been added, the rest of the CC @iamayushdas

Okay

will also update apisix's readme?

will also update apisix's readme?

I will be adding to readme company wall after putting the missing icons.

@guoqqqi suggest to remove zihao and zhi20 due to https://github.com/apache/apisix-website/pull/376#issuecomment-866279217

Remove zhi20 due to suspected pyramid scheme
Remove zihaowangluo since it's an outsourcing company

Also we need to turn the white background to transparency (add alpha channel) to make it compatible with night mode

cc @guoqqqi do you have some progress on this

suggest to remove zihao and zhi20 due to #376 (comment)

Remove zhi20 due to suspected pyramid scheme
Remove zihaowangluo since it's an outsourcing company

Hi @guoqqqi do you mind fix this problem

Hi @guoqqqi do you mind fix this problem

@Yiyiyimu Hi, I have removed them in this PR

@guoqqqi it seems icon of zhi20 haven't been removed yet

@Yiyiyimu It has been removed


GEODE-2272: Fix Pulse data browser export

Pulse no longer loads all results into the browser before generating a results file for download.

Precheckin started


chore: ts project references and working typescript on all projects

add typescript package references to support a single watch/build of the package.
website types compile now
other clean up

Looks like this is breaking the website build. Not sure why just yet.

Looks like this is breaking the website build. Not sure why just yet.

Me neither, it was working before my second commit

Is this ready to merge?


Respect the EXIF auto orientation tag.

When uploading an image from a mobile device, the generated thumbnails are not rotated according to the EXIF tag. This results in thumbnails being potentially generated in the wrong orientation.
The imaging package supports reading the EXIF tag, so adding support for it is a simple fix.

Thanks! It will be included in the next bugfix release sometime later this week.


Move spotdb into own project?

The "spotdb" (which is actually a caliper database) could be useful for other projects - could we move it into it's own module proper, and perhaps branded with caliper so it's clear that's what it's serving? Let me know what you think!

If this idea is amenable to you, I'd be happy to make a new repository and the wiring to release to pypi, etc. I'm guessing there is some software release for caliper we could use?


Non escaped special characters in file path causes sync to fail

Sync doesn't appear to work if there is a space in the filepath (directory names).
Possible fix: If filepath strings are backslash escaped.
From error modal:
Cannot find /Users/xxxxxx/Music/Library/Mobile Documents/com~apple~CloudDocs/Music/1970s/10cc - Dreadlock Holiday (Extended Tech Edit) (Clean).mp3
This is a correct response as far as the terminal is concerned.
e.g. /Users/k-sym/Music/Library/Mobile Documents/com~apple~CloudDocs/Music/1970s/10cc - Dreadlock Holiday (Extended Tech Edit) (Clean).mp3 : No such file or directory (os error 2)
However, file is found one spaces are escaped:
e.g. /Users/xxxxxx/Library/Mobile\ Documents/com\~apple\~CloudDocs/Music/1970s/10cc\ -\ Dreadlock\ Holiday\ \(Extended\ Tech\ Edit\)\ \(Clean\).mp3 - file found

Hi,
unfortunately I am unable to reproduce this.
My database file (m.db in the Engine Library can be opened with any SQLite client) also contains paths pointing to iCloud (usually ~/Library/Mobile Documents/com~apple~CloudDocs/) and those sync just fine.
Could it be that you moved the Engine Library Backup folder after creating it?
Since EngineDJ saves the paths as relative to the library folder in the database file, moving the folder could cause this weird behavior (It's pointing to ~/Music/Library/[...] in your case)


Fixes excessive ShuffleBlockId object creation due to missing map index bounds

Signed-off-by: Alessandro Bellina<EMAIL_ADDRESS>This fixes a bug that was found with larger NDS data scales (10TB) where GC limits would be exceeded. I tracked this down to excessive creation of ShuffleBlockIds just to get the "partition size" metric in ShuffledBatchRDDUtil.
The GC starts to become a problem when we create hundreds of millions of these, which adds up to single-digit GBs of jvm memory. With this fix, the most I saw created was ~3M and the amount of JVM usage was ~100MB, which allowed the query to succeed.
Note I left some filtering that happened after we got the ShuffleBlockIds in place, and it should be a noop. I believe that can be removed.
Adding this as draft as I haven't run through all the tests yet.

build

Tested with this PR and it resolves the GC issue.

I have gone ahead and removed the extra filtering we were doing, after reviewing spark code, which already slices given the correct map indices are passed.

build

Failing with: test_explain_bucket_disabled_by_query_planner. The main error I can parse out of it is (from databricks):
E               pyspark.sql.utils.AnalysisException: java.lang.RuntimeException: The root scratch dir: /tmp/hive on HDFS should be writable. Current permissions are: rwxr-xr-x

There are potentially other errors, I don't think they are related to the change.

build


Update armeria to 1.9.0

Updates com.linecorp.armeria:armeria from 1.8.0 to 1.9.0.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.linecorp.armeria", artifactId = "armeria" } ]

labels: library-update, semver-minor

Superseded by #1021.


adding archive repo

adding ability to enable the archive repo so we can install old versions.

ugh just noticed archive isnt a valid yum repo, no repodata :cry:


[WIP ]Update st-ug-deploy.md

close #2324

no need to fix cn version, cuz the en version is wrong. will fix the en version.


Search finds string in translation file, but not in php file

Issue Type: Bug
When i searched for a string in the source files, the result was empty. I then included the all folders, but it only found the translation (.po) file. I then used grep to find the file and opened that file (.php) in VSCode and after that the search successfully found the string inside that file.
If I close the file and search again, the result disappears again...
Does this issue occur when all extensions are disabled?:  I have no memory of clicking it, but maybe I hit it by accident? Wasn't even really aware of this option.

This is a very hidden button with huge impact on the results
It does not even say anything in the results about it, only "x results in y files" - Could at least mention "x results in y files - only searching open editors"
The link for search issues https://github.com/microsoft/vscode/wiki/Search-Issues does not mention this option at all - in fact it is missing even in the screenshot. Is this a newer feature? Hope it's not active by default...

Duplicate of #130412


[Cadl APIView] Move aliases to their own section

Currently aliases are mixed in with models, but you can also alias operations and template specializations, so it would be more appropriate for these to appear in their own section of the APIView document.

This is misleading to look at the APIView and have aliases under models, as those are not and will never end up as actual classes or construct (an alias is an anonymous construct, that happened to have a name for reference, but disapear at compile time).


Avoid running on_training_end after Keyboard Interrupt

🚀 Feature
Right now, due to #795 , on_training_end runs after a KeyboardInterrupt. This ends up running code that's meant to be run only after successful training completion. This feature should either be reverted, or an alternative should be provided, so as to run some code only after successful training.
Motivation
I am training a model on Sagemaker and have added a notebook shutdown code within the on_training_end method. There were times where I had to manually cancel my model training because some parameters were incorrect. However, If I do that, the notebook shuts down immediately. This is because the on_training_end method runs even after a KeyboardInterrupt.  I don't want my notebook shutting down after a keyboard interrupt, only after successful training completion.
Pitch
Maybe add an on_training_completed method for code that's meant to be run after successful training.

Good point, it makes sense to skip eval of the unfinished train also when a user is it he doesn't want to wait for another hour lol Mind send a PR? :robot:

Thanks for bringing this use-case to our attention @lezwon , definitely something we'd want to consider.
What if the Trainer object had a status property? Similar to how compute jobs will have a status {PENDING, RUNNING, COMPLETE, FAILED} we could apply something similar here for the training job. In this case we could differentiate the two cases with a status of INTERRUPTED vs COMPLETED and your callback logic can check for the proper status before closing (eg. shutdown notebook on FAILED/COMPLETED but don't shutdown for INTERRUPTED).
What do you think?

@jeremyjordan that sounds great. We could definitely do that.

Not sure if we really need to add complexity to the existing callbacks...
Also on_training_completed is standard behavior so rather some cleanup for interrupted?
@jeremyjordan status sounds cool, by my opinion it is much better signal the returned 0/1 from e.g. .fit =)

@Borda are you suggesting that we add a new callback (on_training_completed that @lezwon mentioned) which runs conditionally according to the value returned from fit()? My only worry is that it might be confusing to know the difference between on_training_end (existing) and on_training_complete (proposed).

in this moment I was just thinking about adding Trainer status...
not sure if we want to add complexity with new callback...

Ok yes I agree, I think the Trainer status would be a simple solution that may also be useful in other situations as well :)

Cool, does anyone send a PR with Trainer status? I may suggest to implement it as enum/numbering similar like logging.INFO/DEBUG/...

Will this status also account for validation/test completed/interrupted?

yes we could do something like:
>>> from enum import Enum
>>> class TrainerStatus(Enum):
...     PENDING = "Initializing Trainer object"
...     TRAINING = "Optimizing model via train loop"
...     VALIDATING = "Running model on validation set"
...     TESTING = "Running model on test set"
...     FAILED = "Trainer failed to complete a successful run"
...     INTERRUPTED = "Training was interrupted by the user"
...     COMPLETED = "Training completed successfully"

I can work on getting this into a PR

Hey @jeremyjordan, what if we would like to execute different actions if the trainer failed during a validation task? Can we find out which task it failed at from the status? Just wondering if this would be flexible in such a scenario.

@lezwon do you have an example in mind of where you'd need that?
i'd prefer to keep the implementation simple and generic enough such that we don't keep adding new status types.

Don't really have an example yet. Was just considering a scenario like that though.
I guess we could go ahead with the current proposal you mentioned. That should solve my issue for sure 😊

probably want to consider building upon the Trainer state defined in #770
fyi @xingzhaolee - what do you think? (we don't need to include it in #770 just thinking about building off of that)

@jeremyjordan sounds like a good idea! also I was thinking that since we have TrainerStatus, can it be the main class while TrainerMode servers as a nested enum instead of putting them all under a single enum? something like:
class TrainerMode(enum.Enum):
    TRAINING = enum.auto()
    VALIDATING = enum.auto()
    TESTING = enum.auto()

class TrainerStatus(enum.Enum):
    PENDING = enum.auto()
    FAILED = enum.auto()
    INTERRUPTED = enum.auto()
    ...
    MODE = TrainerMode

then user can access the current status and mode through:
# Interrupted when validation is running
if ... is TrainerStatus.INTERRUPTED and ... is TrainerStatus.MODE.VALIDATING:

sure! that would be flexible enough to address @lezwon 's earlier comment. i had started a branch to work on TrainerStatus, once #770 is merged i can pick up that work with your new suggestion here :)

if I understand it correctly the .auto means that it can be every run different enum value, right? Even it seems to be starting from 1 and incrementally increase...
if so I would recommend using some exact numbers in case of exporting/importing :]

not too sure about that, but probably the order matters too when new status or mode is added. so I guess we should use exact numbers like you suggested in case any import or export is involved! 🙂

i went back and forth on whether the trainer status would be a valuable addition. ultimately, i decided to opt for a simple attribute denoted when a KeyboardInterrupt has been caught.


Gate::after(): returning a not null value do not alter the result of the authorization

Laravel Version: 7.20.0
PHP Version: 7.4.8
Database Driver & Version: mysql 8.0.21

Description:
According to the documentation about the after method:
https://laravel.com/docs/7.x/authorization#intercepting-gate-checks
"Similar to the before check, if the after callback returns a non-null result that result will be considered the result of the check."
But has no effect, like in older version of the framework.
Steps To Reproduce:
Gate::define('edit-settings', function ($user = null) {
    return true;
});
Gate::after(function ($user = null, $ability = null, $result = null, $arguments = null) {
    return false; //this have no effect
});

// ------------

Gate::allows('edit-settings'); // return true!

The behavior is OR, not AND. If any of the above returns true, the permission passes.

The behavior is OR, not AND. If any of the above returns true, the permission passes.

The actual behavior seems different:
Gate::define('edit-settings', function ($user = null) {
    // no return
});
Gate::after(function ($user = null, $ability = null, $result = null, $arguments = null) {
    return false;  // the result is determined only by Gate::after() function
});

Gate::define('edit-settings', function ($user = null) {
    return false;
});
Gate::after(function ($user = null, $ability = null, $result = null, $arguments = null) {
    return true;  // if  Gate::define() return not null value, so Gate::after() return value is ignored
});

Maybe the documentation have to be updated?

The behavior is OR, not AND. If any of the above returns true, the permission passes.

Is there a way in an Gate::after() hook to return the definitive result? This explanation makes the following snippet, as highlighted in the OP, completely inaccurate:

"Similar to the before check, if the after callback returns a non-null result that result will be considered the result of the check."

Context: using laravel/bouncer for DB permissions, configured so that it runs Laravel policies before DB permission checks but then I also want an additional global rule to run after everything else where it denies based on X condition unless a policy returns true (hence why I can't use Gate::before)


Supply collection process presumes normal quality construction robots are available

I'm using the mod via Maraxsis.  The process of collecting supplies to build ghosts assumes that normal quality bots are available on the logistic network.  The workflow seems to request normal quality construction robots even if the entity (spidertron/submarine) has higher quality construction robots pre-installed.
It doesn't seem like a Maraxsis-specific scenario that there are only higher quality construction robots available on the network, since this is a mid/late game mod, so posting the issue here.

I think this should be reported at https://mods.factorio.com/mod/Constructron-Continued rather than here? This mod only does the schedules and docks, not auto-requesting or auto-building.

Hi @hikeonpast
I am the coder of Constructrons.
The quality of the robot can be changed int eh settings UI via the mod button or SHIFT +C +C.


Image disagrees with text in /DevOps/2_ContinuousDeliveryPipeline/README.md

The image /DevOps/2_ContinuousDeliveryPipeline/images/codepipeline-add-2.png should be corrected to have its Template input value changed from:
MyAppBuild::output.yaml to: MyAppBuild::app-sam-output.yaml to agree with the text that says:
"Enter MyAppBuild::app-sam-output.yaml for Template".
I missed that step.

@pc-mreeves - apologies for the delay.  The workshop has been updated today to use CodeStar, which has replaced this screenshot in Module 2.  I'll close for now.  Please check out the updates, and let me know if you have any feedback on the new format.  Thanks!


GPU multi instance doc update

Removed reference to ND96asr_v4 being the only SKU supporting A100 GPU. NC_A100_v4/NDm_A100_v4 series are also eligible.

Fixed typo under Confirm multi-instance GPU capability referencing "Allocable" (should be "Allocatable")

Reworked the schedule work section

3.1 kubectl --limits flag has been deprecated and no longer works. --override flags can be used as an alternative, but results were inconsistent with kubectl run.
3.1.2 Changed the scheduling work strategy to deployment manifests w/ execution command + output for a consistent experience.
3.2 Added a reference to nvidia's deprecating the latest tag on their docker repo - pulling a base image of nvidia/cuda will not work. The full tag needs to be used

#sign-off


Fix broken Chinese IME when deleting composition

Summary of the Pull Request
This PR fixes an out of bounds access when deleting composition during Chinese IME. What's happening is that we're receiving a CompositionCompleted before receiving the TextUpdate to tell us to delete the last character in the composition. This creates two problems for us:

The final character gets sent to the Terminal when it should have been deleted.
_activeTextStart gets set to _inputBuffer.length() when sending the character to the terminal, so when the TextUpdate comes right after the CompositionCompleted event, _activeTextStart is out of sync.

This PR fixes the second issue, by updating _activeTextStart during a TextUpdate in case we run into this issue.
The first issue is trickier to resolve since we assume that if the text server api tells us a composition is completed, we should send what we have. It'll be tracked here: #5110.
At the very least, this PR will let users continue to type in Chinese IME without it breaking, but it will still be annoying to see the first letter of your composition reappear after deleting it.
PR Checklist

[x] Closes #5054
[x] CLA signed. If not, go over here and sign the CLA
[x] Tests added/passed

Validation Steps Performed
Play around with Chinese IME deleting and composing, and play around with Korean and Japanese IME to see that it still works as expected.

@msftbot merge this in 8 minutes


MAINT: Update link

The best I could do to fix our linkcheck failure:
https://app.circleci.com/pipelines/github/mne-tools/mne-python/16194/workflows/d606325b-39eb-4712-b060-dea32139cdb4/jobs/48753

Failure is a spurious dask.org outage, in it goes


Dependency update required (deprecated graceful-fs required by fstream 0.1)

Hello Richard,
After installing materialize-css, I noticed a warning regarding graceful-fs:
npm WARN deprecated<EMAIL_ADDRESS>graceful-fs v3.0.0 and before will fail on node releases >= v7.0. Please update to<EMAIL_ADDRESS>as soon as possible.
This is caused by node-archiver requiring an old version of fstream requiring in turn the deprecated graceful-fs version:
┬<EMAIL_ADDRESS>
└┬<EMAIL_ADDRESS>
 └┬<EMAIL_ADDRESS>
  └<EMAIL_ADDRESS>
fstream  updated its graceful-fs dependency above 4.0.0 in release 1.0.9.
Would it be possible to update the dependency in node-archiver to ensure it will stay compatible with future versions of Node.js?
Thank you - and please don't hesitate to get in touch if you need help for testing!
Yoann

Yes, that's does need to be upgraded. I'll be able to do that shortly after the middle of this month.
Thanks for the heads up,
Richard

Dependencies for fstream and tar updated to latest and npw published as 0.3.0 since no functionality changes were required to update these dependencies - https://www.npmjs.com/package/node-archiver
Thanks for the report!


To create a DLL project in Visual Studio 2019 fails after first create DLL with compile error

1>C:\Program Files (x86)\Windows Kits\10\Include\10.0.19041.0\shared\sdkddkver.h(276,1): fatal error C1189: #error:  WINVER setting conflicts with _WIN32_WINNT setting
I started to create the DLL in VS2019 (16.10.3) as described with prerequisites "Desktop development with C++",   created header and cpp copied respective code hit compile and get above error. This page need updating.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 08c574a2-cef0-ab13-7375-55851f966ef6
Version Independent ID: fe3421c7-e9f4-4986-589f-fadaedce583e
Content: Walkthrough: Create and use your own Dynamic Link Library (C++)
Content Source: docs/build/walkthrough-creating-and-using-a-dynamic-link-library-cpp.md
Product: visual-cpp
Technology: cpp-tools
GitHub Login: @corob-msft
Microsoft Alias: corob

@GuidoSE
I'm sorry you're having trouble. The error you describe is unexpected, and I can't reproduce it with VS2019. You shouldn't need to set WINVER or _WIN32_WINNT at all. Things to try: Verify that you're using the correct template, and try to build the DLL created by the template before you make any changes to it. It should build successfully. If it doesn't, there may be a problem with your Visual Studio installation. Once it builds successfully, then try the remaining steps in the walkthrough to create the DLL. If you continue to have trouble, then I recommend getting help from Microsoft Learn Q&A. Since this appears to be a support issue rather than a problem with the documentation, I'm closing it. Best of luck with your code.

Hi Colin,
Thank you for your reply. I think a re-install of VS2019 Pro is my next option.
I tried the same example on VS2019 Community edition, home pc, the example worked however I did need to correct the name of the PREPROSSOR value MATHLIBRARY as it was miss-spelt in this version of VS2019 when first compiling the project. After correcting the value it work. So agree, probably code related bugs/installation issue,
Kind regards
Guido
Internal
From: Colin Robertson @.>
Sent: 08 November 2022 22:47
To: MicrosoftDocs/cpp-docs @.>
Cc: Guido Le Lorrain @.>; Mention @.>
Subject: Re: [MicrosoftDocs/cpp-docs] To create a DLL project in Visual Studio 2019 fails after first create DLL with compile error (Issue #4272)
[External email: Use caution with links and attachments]

@GuidoSEhttps://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FGuidoSE&data=05|01|guido.lelorrain%40se.com|5a69426505e84629ed8708dac1db22ea|6e51e1adc54b4b39b5980ffe9ae68fef|0|0|638035444169107369|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=UMAqXGb8LzWgDqnhwh5qaTPGu8FE2QvQ8B7YV0kJBl0%3D&reserved=0
I'm sorry you're having trouble. The error you describe is unexpected, and I can't reproduce it with VS2019. You shouldn't need to set WINVER or _WIN32_WINNT at all. Things to try: Verify that you're using the correct template, and try to build the DLL created by the template before you make any changes to it. It should build successfully. If it doesn't, there may be a problem with your Visual Studio installation. Once it builds successfully, then try the remaining steps in the walkthrough to create the DLL. If you continue to have trouble, then I recommend getting help from Microsoft Learn Q&Ahttps://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Flearn.microsoft.com%2Fen-us%2Fanswers%2Ftopics%2Fc%252B%252B.html&data=05|01|guido.lelorrain%40se.com|5a69426505e84629ed8708dac1db22ea|6e51e1adc54b4b39b5980ffe9ae68fef|0|0|638035444169107369|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=WF0nLr9UPt%2FlZtPSTIgvSwlPa2vbp55%2FdeBrAeoa2sw%3D&reserved=0. Since this appears to be a support issue rather than a problem with the documentation, I'm closing it. Best of luck with your code.

Reply to this email directly, view it on GitHubhttps://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2Fcpp-docs%2Fissues%2F4272%23issuecomment-1307940366&data=05|01|guido.lelorrain%40se.com|5a69426505e84629ed8708dac1db22ea|6e51e1adc54b4b39b5980ffe9ae68fef|0|0|638035444169107369|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=AupaUCFRzM6Pbfcguvstiz%2F63jaXr1MqYv0raLdIj7g%3D&reserved=0, or unsubscribehttps://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FARD6MTTMGW4TM4F3SPMFHWDWHLJ53ANCNFSM6AAAAAAR2PRR5U&data=05|01|guido.lelorrain%40se.com|5a69426505e84629ed8708dac1db22ea|6e51e1adc54b4b39b5980ffe9ae68fef|0|0|638035444169107369|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=pP%2BeDlPhbzfcdsJt%2FIr5FkpO%2FROm0n%2By3H4icnWiGxY%3D&reserved=0.
You are receiving this because you were mentioned.Message ID<EMAIL_ADDRESS>

Hi,
Investigation found the following:

VS2019 and Windows 10 SDK 10.0.19041.0 are not incompatible, you get the following compilation error with this project (any project):

1>C:\Program Files (x86)\Windows Kits\10\Include\10.0.19041.0\shared\sdkddkver.h(276,1): fatal error C1189: #error:  WINVER setting conflicts with _WIN32_WINNT setting

However VS2019 does work with Windows 10 SDK 10.0.18362.0, no problem compiling projects.
VS2022 and Windows 10 SDK 10.0.19041.0 do work together and  this project will compile. Finding this out shouts poor testing of releases, either the SDK or VS or both! Surely Microsoft could simply automate a smoke test with this project to evaluate a successful compile?

Kind regards
Guido Le Lorrain
Internal
From: Guido Le Lorrain
Sent: 09 November 2022 09:39
To: MicrosoftDocs/cpp-docs @.***>
Subject: RE: [MicrosoftDocs/cpp-docs] To create a DLL project in Visual Studio 2019 fails after first create DLL with compile error (Issue #4272)
Hi Colin,
Thank you for your reply. I think a re-install of VS2019 Pro is my next option.
I tried the same example on VS2019 Community edition, home pc, the example worked however I did need to correct the name of the PREPROSSOR value MATHLIBRARY as it was miss-spelt in this version of VS2019 when first compiling the project. After correcting the value it work. So agree, probably code related bugs/installation issue,
Kind regards
Guido
Internal
From: Colin Robertson<EMAIL_ADDRESS>Sent: 08 November 2022 22:47
To: MicrosoftDocs/cpp-docs<EMAIL_ADDRESS>Cc: Guido Le Lorrain<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [MicrosoftDocs/cpp-docs] To create a DLL project in Visual Studio 2019 fails after first create DLL with compile error (Issue #4272)
[External email: Use caution with links and attachments]

@GuidoSEhttps://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FGuidoSE&data=05|01|guido.lelorrain%40se.com|5a69426505e84629ed8708dac1db22ea|6e51e1adc54b4b39b5980ffe9ae68fef|0|0|638035444169107369|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=UMAqXGb8LzWgDqnhwh5qaTPGu8FE2QvQ8B7YV0kJBl0%3D&reserved=0
I'm sorry you're having trouble. The error you describe is unexpected, and I can't reproduce it with VS2019. You shouldn't need to set WINVER or _WIN32_WINNT at all. Things to try: Verify that you're using the correct template, and try to build the DLL created by the template before you make any changes to it. It should build successfully. If it doesn't, there may be a problem with your Visual Studio installation. Once it builds successfully, then try the remaining steps in the walkthrough to create the DLL. If you continue to have trouble, then I recommend getting help from Microsoft Learn Q&Ahttps://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Flearn.microsoft.com%2Fen-us%2Fanswers%2Ftopics%2Fc%252B%252B.html&data=05|01|guido.lelorrain%40se.com|5a69426505e84629ed8708dac1db22ea|6e51e1adc54b4b39b5980ffe9ae68fef|0|0|638035444169107369|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=WF0nLr9UPt%2FlZtPSTIgvSwlPa2vbp55%2FdeBrAeoa2sw%3D&reserved=0. Since this appears to be a support issue rather than a problem with the documentation, I'm closing it. Best of luck with your code.

Reply to this email directly, view it on GitHubhttps://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2Fcpp-docs%2Fissues%2F4272%23issuecomment-1307940366&data=05|01|guido.lelorrain%40se.com|5a69426505e84629ed8708dac1db22ea|6e51e1adc54b4b39b5980ffe9ae68fef|0|0|638035444169107369|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=AupaUCFRzM6Pbfcguvstiz%2F63jaXr1MqYv0raLdIj7g%3D&reserved=0, or unsubscribehttps://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FARD6MTTMGW4TM4F3SPMFHWDWHLJ53ANCNFSM6AAAAAAR2PRR5U&data=05|01|guido.lelorrain%40se.com|5a69426505e84629ed8708dac1db22ea|6e51e1adc54b4b39b5980ffe9ae68fef|0|0|638035444169107369|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=pP%2BeDlPhbzfcdsJt%2FIr5FkpO%2FROm0n%2By3H4icnWiGxY%3D&reserved=0.
You are receiving this because you were mentioned.Message ID<EMAIL_ADDRESS>

@GuidoSE
Good work finding a repro case on your system. The various combinations of VS and Windows SDK are in fact tested continuously with each other, and we'd fix issues if we found any. I'm inclined to think the problem is local to your machine, since I have no trouble building the default DLL project in Visual Studio 2019 version 16.11.21 (the latest) with Windows SDK 10.0.19041.0 (set in the Project Properties dialog under Configuration Properties > General > Windows SDK Version).
An earlier version of Visual Studio had a typo in the DLL template that would create the project-specific preprocessor macro in mixed case, rather than all upper case. However, it's fixed in the current version of Visual Studio 2019. I'd recommend using the latest 2019 version with all its bug and security fixes, even if you don't want to move to Visual Studio 2022. You're probably prompted to update it every time you launch Visual Studio.


Preparation for playground snapshots and testing

This PG does the following:

restructure the playwright configuration and test detection. From now on any test file throughout the repository matched by the specific playwright project matcher will be included in the tests of this specific project.
Added playground test project as a preparation for playground user interaction testing
Prepare the playground to a full snapshot deployment and testing.

The next steps (after this is merged) are:

Build the playground as part of the standard CI
Deploy this to a snapshot directory so we can test the actual playground (and not only the default playground with CDN snapshots)
Run the playground tests as part of this CI step. Fail if the playground doesn't work correctly.

Note that I opted-out of snapshot testing for the actual website. Mainly because of different rendering cross OSes AND the fact that we have a constant version changing, which will require either not rendering this part or ignoring a lot of pixel changes, which will render snapshot testing useless.

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

Snapshot stored with reference name:
refs/pull/15889/merge
Test environment:
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/15889/merge/index.html
To test a playground add it to the URL, for example:
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/15889/merge/index.html#WGZLGJ#4600
Links to test babylon tools with this snapshot:
https://playground.babylonjs.com/?snapshot=refs/pull/15889/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/15889/merge
https://gui.babylonjs.com/?snapshot=refs/pull/15889/merge
https://nme.babylonjs.com/?snapshot=refs/pull/15889/merge
To test the snapshot in the playground with a playground ID add it after the snapshot query string:
https://playground.babylonjs.com/?snapshot=refs/pull/15889/merge#BCU1XR#0

Reviewer - this PR has made changes to one or more package.json files.

Visualization tests for WebGPU (Experimental)
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/15889/merge/testResults/webgpuplaywright/index.html

WebGL2 visualization test reporter:
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/15889/merge/testResults/webgl2playwright/index.html

not sure the webgpu.json file should be removed

AFAIK this file has been merged with config.json and has not been used in a long time, at least not in the CI. I can of course revert it, if it is still being used.

Visualization tests for WebGPU (Experimental)
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/15889/merge/testResults/webgpuplaywright/index.html

Reviewer - this PR has made changes to one or more package.json files.

not sure the webgpu.json file should be removed

AFAIK this file has been merged with config.json and has not been used in a long time, at least not in the CI. I can of course revert it, if it is still being used.

Also I am not sure to understand how the webgl2 and webgpu tests are now able to run (it is clearly Monday :-) ) ?

WebGL2 visualization test reporter:
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/15889/merge/testResults/webgl2playwright/index.html

Visualization tests for WebGPU (Experimental)
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/15889/merge/testResults/webgpuplaywright/index.html

Reviewer - this PR has made changes to one or more package.json files.

Also I am not sure to understand how the webgl2 and webgpu tests are now able to run (it is clearly Monday :-) ) ?

Just as they were running until now! Playwright only. We don't use jest anymore. there are many different ways starting them. The issue with the CI was actually browserstack (which is only enabled on the CI).
To start the tests you can:

use the vscode extension
Use npm run test:visualization
Open the UI using npm run test:visualization:ui
run the tests directly using playwright npx playwright test --project-webgl2

Jest and puppeteer as visualization testing was deprecated a long time ago. we don't use on the CI (except fro webgl1) and i don't recommend using it locally as well. Playwright is better.

Visualization tests for WebGPU (Experimental)
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/15889/merge/testResults/webgpuplaywright/index.html

I'll fix the build. This is a permission issue.

Reviewer - this PR has made changes to one or more package.json files.

WebGL2 visualization test reporter:
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/15889/merge/testResults/webgl2playwright/index.html

Reviewer - this PR has made changes to one or more package.json files.

Visualization tests for WebGPU (Experimental)
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/15889/merge/testResults/webgpuplaywright/index.html

WebGL2 visualization test reporter:
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/15889/merge/testResults/webgl2playwright/index.html

Reviewer - this PR has made changes to one or more package.json files.

Visualization tests for WebGPU (Experimental)
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/15889/merge/testResults/webgpuplaywright/index.html

WebGL2 visualization test reporter:
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/15889/merge/testResults/webgl2playwright/index.html


toEqualValue does not retry, fails instantly

Hi there,
I am trying to use toEqualValue, and noticed that it does not wait for the condition to be true as I would have expected.
Below is an example where it checks the value of an input. Since the value is not Playwright, the test fails instantly. I would have expected it to keep checking the input value before timing out, as sometimes inputs can be filled in with a delay. The error message is 'Playwright' does not equal ''.
const qawolf = require("qawolf");
const selectors = require("./selectors/myTest.json");

let browser;
let page;

beforeAll(async () => {
  browser = await qawolf.launch();
  const context = await browser.newContext();
  await qawolf.register(context);
  page = await context.newPage();
});

afterAll(async () => {
  await qawolf.stopVideos();
  await browser.close();
});

test("myTest", async () => {
  await page.goto("http://todomvc.com/examples/react");
  await page.click(selectors["0_what_needs_to_b_input"]);
  await page.type(selectors["1_what_needs_to_b_input"], "enter todo");
  await page.press(selectors["2_what_needs_to_b_input"], "Enter");

  const element = await page.$(selectors["2_what_needs_to_b_input"]);
  await expect(element).toEqualValue("Playwright");
});

Another note - the README still says 1 second. Just wanted to see if that was still the actual timeout, or if it is just out of date.
Thanks in advance :)

Hey @flaurida,
currently I'm just getting the value of the element via $eval and then I'm making there a .textContent to get the actual text inside of the element.
This unfortunately until now, does not work, if the value of the element changes to the expected one after a few seconds e.g.
Not sure how we should proceed there, definitely a case which we should handle somehow. Playwright internally with the text selector engine is doing a pretty similar thing.

Hi @mxschmitt 😊 thanks for getting back to me! I understand the issue now.
For what it's worth, the API I would advocate for would look something like this, consistent with the toHaveText API:
await expect(page).toEqualValue("#my-selector", "Playwright")

or
await expect("#my-selector").toEqualValue("Playwright")

I would then expect it to keep retrying the assertion until timeout.
Let me know your thoughts, happy to collaborate here!

Hey,
probably the first case, because the selector has to have access to the page object.
Would be awesome if you want to implement that. Looking forward to it!

Closed since it was stale, please reopen if its still an issue.

Closed since it was stale, please reopen if its still an issue.


typo: Double word "in"

@nschonni : Thanks for your contribution! The author, @stevestein, has been notified to review your proposed change.


The default value for aspectRatio of the document seems to be wrong

Documentation Is:

[ ] Missing or needed?
[X] Confusing
[ ] Not sure?

Please Explain in Detail...
The document says the default value of aspectRatio is 2, but it is actually operating at 1
Chart.js/src/docs/configuration/responsive.md
(In version 2, the default value seems to be 2)
Your Proposal for Changes
I think the document is wrong, but I want to change the default value to 1
Example
No response

Looks like its only mentioned in migration guide:

aspectRatio defaults to 1 for doughnut, pie, polarArea, and radar charts


More Bots and Organization of Bot List

Alphabetized bot list to make merging multiple pull-requests easier in the future (and improves lookup of supported values)
added a lot of missing bots

Note: make build is broken: https://github.com/biggora/express-useragent/issues/70

Note: would be even better to abandon maintaining another bot list and use the isbot npm package.


Update travis configuration to run sonarcloud

Check List:

Fixes: sonarcloud configuration
Unit tests : NA
Javadoc with a code example (API only) : Not needed

I am opening this PR to try to integrate sonarcloud scan with travis.
I've updated configuration following this guide https://docs.travis-ci.com/user/sonarcloud/#SonarQube-Scanner-for-Maven and the example that was linked.

@btrajkovski can you investigate why the build fails ? Here's the extract from travis logs:
[INFO]
[INFO] --- sonar-maven-plugin:<IP_ADDRESS>3:sonar (default-cli) @ assertj-core ---
Downloading: https://repo.maven.apache.org/maven2/org/sonarsource/scanner/api/sonar-scanner-api/<IP_ADDRESS>7/sonar-scanner-api-<IP_ADDRESS>7.pom
Downloaded: https://repo.maven.apache.org/maven2/org/sonarsource/scanner/api/sonar-scanner-api/<IP_ADDRESS>7/sonar-scanner-api-<IP_ADDRESS>7.pom (5.1 kB at 506 kB/s)
Downloading: https://repo.maven.apache.org/maven2/org/sonarsource/scanner/api/sonar-scanner-api-parent/<IP_ADDRESS>7/sonar-scanner-api-parent-<IP_ADDRESS>7.pom
Downloaded: https://repo.maven.apache.org/maven2/org/sonarsource/scanner/api/sonar-scanner-api-parent/<IP_ADDRESS>7/sonar-scanner-api-parent-<IP_ADDRESS>7.pom (4.7 kB at 932 kB/s)
Downloading: https://repo.maven.apache.org/maven2/com/google/code/findbugs/jsr305/2.0.3/jsr305-2.0.3.pom
Downloaded: https://repo.maven.apache.org/maven2/com/google/code/findbugs/jsr305/2.0.3/jsr305-2.0.3.pom (1.4 kB at 154 kB/s)
Downloading: https://repo.maven.apache.org/maven2/org/sonarsource/scanner/api/sonar-scanner-api/<IP_ADDRESS>7/sonar-scanner-api-<IP_ADDRESS>7.jar
Downloading: https://repo.maven.apache.org/maven2/com/google/code/findbugs/jsr305/2.0.3/jsr305-2.0.3.jar
Downloaded: https://repo.maven.apache.org/maven2/com/google/code/findbugs/jsr305/2.0.3/jsr305-2.0.3.jar (33 kB at 944 kB/s)
Downloaded: https://repo.maven.apache.org/maven2/org/sonarsource/scanner/api/sonar-scanner-api/<IP_ADDRESS>7/sonar-scanner-api-<IP_ADDRESS>7.jar (532 kB at 9.2 MB/s)
[INFO] User cache: /home/travis/.sonar/cache
[ERROR] SonarQube server [http://localhost:9000] can not be reached
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 01:04 min
[INFO] Finished at: 2017-10-04T20:55:20Z
[INFO] Final Memory: 59M/995M
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.sonarsource.scanner.maven:sonar-maven-plugin:<IP_ADDRESS>3:sonar (default-cli) on project assertj-core: Unable to execute SonarQube: Fail to get bootstrap index from server: Failed to connect to localhost/0:0:0:0:0:0:0:1:9000: Connection refused (Connection refused) -> [Help 1]

It seems we need to configure the SonarQube server location.

I am still investigation this, looks like the issue is that travis is not exposing environment variables on pull requests (which does make sense) and that is why this fails.
So the only time when we should active sonarcloud scan is on commits in master branch and PR to master should be excluded from starting the scan. I will open another PR to trigger travis build :)


mobile: Fix Envoy initialization bug

Prior to this PR, the code did not check for the EnvoyStatus when starting Envoy, which means if there was a failure when running Envoy, the users would not know causing a bug that could be difficult to debug. This PR fixes the issue by throwing an exception when envoy status is EnvoyStatus.ENVOY_FAILURE.
Risk Level: low
Testing: unit test
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: mobile

/retest

/retest

/retest

/retest

/retest

/retest


Missing documentation for N::n

There is no documentation available in the generated n function.
Coupled with the default pub visibility of the function, my #!warn(missing_docs)] lint is going crazy!

Looking at the expanded macro, it looks like it's not passing through the #[allow(missing_docs)] that's on the actual type to the generated impl block, even though other derive std macros are doing so.

I'm running into the same issue, is there any work to fix it?


Subsequent downloads of CloudBlockBlob fail due to expectedContentLenght=0

When I download CloudBlockBlob object from my store for the first time everything is fine.
On 2nd download it reads all the bytes properly but then it throws exception in the NetworkInputStream class
if (this.bytesRead != this.expectedLength) {
    throw new IOException(SR.CONTENT_LENGTH_MISMATCH);
}

expectedLength is '0' at this point, so I assume it's because it's using cached response on the subsequent calls, but I'm not sure how to disable that (or ignore).
For now I just changed the above line and added this.expectedLength != 0

Hi @armadilov , what version of Android are you using? Did this just start occurring with the latest release? Does it fail consistently and can you provide repro code?


README: update make command to build full release

make generate all => TAGS=bindata make generate all

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@2e2eacf). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #5004   +/-   ##
=========================================
  Coverage          ?   37.41%
=========================================
  Files             ?      306
  Lines             ?    45374
  Branches          ?        0
=========================================
  Hits              ?    16975
  Misses            ?    25946
  Partials          ?     2453

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e2eacf...f10b567. Read the comment docs.

It's not that I would mind much that this was merged but please wait till all change requests are approved before merging :)


Fix computation of pattern stop projection onto shape

Checklist

[x] Appropriate branch selected (all PRs must first be merged to dev before they can be merged to master)
[x] Any modified or new methods or classes have helpful JSDoc and code is thoroughly commented
[x] The description lists all applicable issues this PR seeks to resolve
[x] The description lists any configuration setting(s) that differ from the default settings
[x] All tests and CI builds passing

Description
Fix #581. This PR essentially swaps out the return value for addPatternStopsToShapePoints from using shapePointsCopy to computedShapePoints. This was a tricky one to debug and I can't say 100% why we were ever returning shapePointsCopy (or if it ever worked), but yea, this PR fixes things.

Codecov Report

Merging #582 into dev will decrease coverage by 22.60%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##              dev     #582       +/-   ##
===========================================
- Coverage   38.42%   15.82%   -22.61%
===========================================
  Files         315      315
  Lines       17255    16085     -1170
  Branches     5268     4894      -374
===========================================
- Hits         6631     2545     -4086
- Misses       9245    11556     +2311
- Partials     1379     1984      +605

Flag
Coverage Δ

#end_to_end_tests
?

#unit_tests
15.82% <0.00%> (ø)

Impacted Files
Coverage Δ

lib/editor/components/map/PatternStopsLayer.js
0.00% <0.00%> (-63.83%)
:arrow_down:

lib/editor/selectors/index.js
0.00% <0.00%> (-24.23%)
:arrow_down:

lib/manager/components/validation/TripsChart.js
0.00% <0.00%> (-80.40%)
:arrow_down:

...nager/components/validation/ServicePerModeChart.js
0.00% <0.00%> (-78.27%)
:arrow_down:

lib/common/util/map-keys.js
25.00% <0.00%> (-75.00%)
:arrow_down:

lib/editor/components/EditorInput.js
0.00% <0.00%> (-72.79%)
:arrow_down:

lib/manager/components/HomeProjectDropdown.js
0.00% <0.00%> (-72.73%)
:arrow_down:

...b/manager/containers/ActiveFeedVersionNavigator.js
0.00% <0.00%> (-70.00%)
:arrow_down:

lib/editor/components/EditorSidebar.js
0.00% <0.00%> (-66.67%)
:arrow_down:

lib/editor/containers/ActiveGtfsEditor.js
0.00% <0.00%> (-66.67%)
:arrow_down:

... and 253 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b640af...dbbc274. Read the comment docs.

:tada: This PR is included in version 4.1.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


@azure/openai - Additional OPTIONS request made before POST request for getChatCompletions call

Package Name: @azure/openai
Package Version: 1.0.0-beta.12
Operating system: Windows 11
[x] nodejs

version: 20.12.1

[ ] browser

name/version:

[x] typescript

version: 5.4.2

Is the bug related to documentation in

[ ] README.md
[ ] source code documentation
[ ] SDK API docs on https://docs.microsoft.com

Describe the bug
A clear and concise description of what the bug is.
When calling the getChatCompletions function of an OpenAIClient, an OPTIONS call to the API is made before the POST call is successfully processed.
For most scenarios calling Azure OpenAI directly, this works fine. However, scenarios that implement proxies to multiple Azure OpenAI backend instances do not. This is because the OPTIONS request is not defined in the OpenAPI specification for the Azure OpenAI APIs. Those implementing the spec will not handle OPTIONS requests as is not expected.
Exploring the JS SDK, I cannot find where this request is being made as it is not clear in the OpenAI specific source that this is the case.
To confirm functionality across Azure OpenAI SDKs, the .NET SDK will only perform the POST request resulting in a successful response via a proxy.
To Reproduce
Steps to reproduce the behavior:

Create a new OpenAIClient with default Azure OpenAI configuration
Using a traffic monitoring tool (such as Fiddler), make a request using the OpenAIClient using the getChatCompletions function.

Notice that there are two requests made. The initial OPTIONS request, and the subsequent POST request.
Expected behavior
A clear and concise description of what you expected to happen.
Only the POST request should be made.
Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
Add any other context about the problem here.

Attempting to hijack the requests with a custom HttpClient implementation from the @azure/core-rest-pipeline library also does not work as expected.
I can assume that the OPTIONS request is part of a downstream function called by the default HTTP client provided by the core-rest-pipeline SDK.

@jamesmcroft this is odd, I don't think we should be making OPTIONS requests in Node. I'd expect this to only happen in a browser due to CORS. Can you confirm the environment you're executing your code in is Node 20?

We strongly recommend that you migrate to using the AzureOpenAI client exported by the official OpenAI client library for JavaScript. Please checkout the migration guide for information on how to do so.


Add THIRD-PARTY-LICENSES.txt

Issue #, if available:
Description of changes:
Add THIRD-PARTY-LICENSES.txt with licenses of all 3rd party dependencies.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (5f513f8) 43.53% compared to head (96d9d3c) 43.53%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop      #81   +/-   ##
========================================
  Coverage    43.53%   43.53%
========================================
  Files          247      247
  Lines         8492     8492
  Branches       871      871
========================================
  Hits          3697     3697
  Misses        4521     4521
  Partials       274      274

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


add builder specific information

It adds some extra information to api's response from the builder. Moreover, it also imports BuilderCommitment from Hotshot.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Merged!


[refactor] Fix import cycle caused by importing the pkg/crc/network package

For making any http network calls from CRC we use the transport from  network.HTTPTransport(), but this causes import cycles, most recently seen in #3693 and https://github.com/crc-org/crc/pull/3693#issuecomment-1573317258 mentions other instances we have seen this before.
It'd be good to fix the import cycles once and for all by doing some refactor

https://github.com/cfergeau/crc/tree/refactor this could look like this

I rebased my PR #3693 on top of https://github.com/cfergeau/crc/tree/refactor here: https://github.com/anjannath/crc/tree/bundle-hash-refactored


Try retrying client connection errors on drop_db

Hopefully fixes #6411.
Our bindings won't retry DROP DATABASE automatically.

Running https://github.com/edgedb/edgedb/actions/runs/6727297102/job/18286276579 to gauge whether it worked.