Extend the Response with_cors!

This PR is a pure QoL PR, which aims to make it easier to configure a CORS policy and apply it to responses using with_cors or with_cors_unsafe (for convenience).

Thanks, @ByteAlex - I like the idea of having some utility macros. @zebp - what do you think about adding a new crate for things like this? worker-ext or something like that? I'd prefer not to set a precedent of adding all sorts of things to worker crate directly, unless they are necessary for most projects. CORS is definitely closer to a main requirement for lots of API-like projects, but I think this could be a nice first for an extension/utility crate.

:D

like the idea of having some utility macros. @zebp - what do you think about adding a new crate for things like this? worker-ext or something like that?

I think putting utility macros in worker-macro isn't a bad idea, but I'm unsure about this PR's with_cors!. The type you get is also a worker::Result<Response> so I don't know why we should add a macro instead of letting users use response?.with_cors(whatever) or response.and_then(|r| r.with_cors).
But other than that macro, I think this PR is pretty good.

Though for general knowledge approaching macros:
The worker-marco crate contains only proc-macros so far, if I ever decide to contribute another utility macro-rules macro, it should belong into that crate rather than the respecting file in th worker crate?


Update sam.yaml

Updated node version
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

thank you i updated the template to node12


showing the values in the web

we have been able to connect and retrieve values from the blockchain, we can see the with console.log but failing to render them with ajax.

the bug happened due to the lack of attention!
the function setLoading was not implemented.
bug fixed


Move controller not found after pairing

Maybe similar to #135
Pairing a controller works fine, but afterwards it won't be found.

OS: Win8.1
Setup: as from the hardware-List
behaviopur is unchanged by:
restart of service
reboot
unpairing/pairing
Controller's LED will light constantly when service is started and PS-Button has been pressed
will not show up in PSMove Config Tool under Controller Settings
Console output:

console-output.txt

From the error log it looks likes HID API (the library I use to read data from the controller) thinks that the controller is already in use:
"HID ERROR: Die angeforderte Ressource wird bereits verwendet"
(Google Translate: HID ERROR: The requested resource is already in use)
Are you running the Alpha 5.4 release? If so, try closing PSMoveService and then running test_controller.exe from the console. I'm curious if it gives the same error or not. The test_controller app just tries to open the first controller it finds and then spams the console with data it's reading from the controller. I suspect it will have the same problem, but I want to make sure it's not something else from PSMoveService.
You mentioned you are running windows 8.1? I have had issues in the past with HID API across different versions of windows. I currently do all my testing and development on Win10. When we were first trying to make PSMoveService in Win10 work we had the opposite problem, see here:
https://github.com/signal11/hidapi/issues/231
We have a fork of HID API with a fix for Win10:
https://github.com/cboulay/hidapi/commit/38681c734965636c9fd710dc3898d90aaf923bb9
It's possible that this is causing the opposite problem for you? We don't technically support versions of windows older than Win10 because nobody that is doing development on PSMoveService has older versions of Windows installed anymore. If you were comfortable building from source I could tell you where to make a change to to HID API and see if it fixes the issue for you. If not, I would recommend upgrading to Win10.

Yes, I'm trying 5.4.0. test_controller.exe provides similar output:

\osvr\psmove-service\v0.9alpha5_4_0\Win64>test_controller.exe
Opening PSMoveController...
[2016-10-17 20:05:32.170]: PSMoveController::open - Opening PSMoveController(\?
\hid#{00001124-0000-1000-8000-00805f9b34fb}_vid&0002054c_pid&03d5&col01#8&359a13
f4&1&0000#{4d1e55b2-f16f-11cf-88cb-001111000030})[2016-10-17 20:05:32.182]: PSMo
veController::open -   with serial_number: e0ae5e4cc9a8[2016-10-17 20:05:32.188]
: PSMoveController::getBTAddress - HID ERROR: Die angeforderte Ressource wird be
reits verwendet.[2016-10-17 20:05:32.194]: PSMoveController::open - Failed to ge
t bluetooth address of PSMoveController(\?\hid#{00001124-0000-1000-8000-00805f9
b34fb}_vid&0002054c_pid&03d5&col01#8&359a13f4&1&0000#{4d1e55b2-f16f-11cf-88cb-00
1111000030})[2016-10-17 20:05:32.208]: ~PSMoveController - Controller deleted wi
thout calling close() first!

Sadly, win10 isn't an option for me (old sound hardware, and some other stuff unsupported in win10).
If I take a look here: https://github.com/vrpn/vrpn/issues/138 (mentioned in the issue you found), and https://github.com/signal11/hidapi/commit/b5b2e1779b6cd2edda3066bbbf0921a2d6b1c3c0 being the solution, building from source might be an option. I'll however would need a helping hand for this, didn't build anything under windows for years.

The commit you linked to and the commit @HipsterSloth linked to above are effectively the same thing. As our builds have this fix baked in already, then rebuilding with these changes won't help. I think you'd have to undo these changes first.
So follow the build instructions here. Except, after you clone the repository but before you build, edit the hid.c file to undo the change in the above commit (i.e. replace FILE_SHARE_READ | FILE_SHARE_WRITE with only FILE_SHARE_READ).
This is certainly worth trying because it is one of the only things that's different between newer windows and older windows, but it SHOULDN'T be the source of your problem. My guess is that you have something else, like a 3rd party bluetooth device manager or other PSMove-related software, that's opening up your device exclusively (maybe using an older hidapi).

@HipsterSloth : hidapi master seems to have this change since early March. We can modify our submodule to point from cboulay/hidapi to signal11/hidapi and then I can delete my hidapi repo. Do you see any problems with that? Do you know of any recent changes in mainline hidapi that might break PSMoveService? Can you give it a test? I'm not setup for building in Windows at the moment.

@cboulay I'd be happy to give that a test tonight. I think the file share privilege thing was the only change. I'll post a test build in this issue for ariselarisel.

that would be great! amd64 should be enough, btw.

@ariselarisel Could you give this custom build a try:
PSMoveService-v0.9alpha5_4_1_custom.zip

good news for you, and shame for me :)

your custom build did not change a thing, so locking wasn't an issue (double-check: I also already tried to hexedit the test_controller.exe binary yesterday, which also did not change anything, but was unsure if i really catched the right place)

I reinstalled the bt-400 drivers for win8.1 found here: http://dlcdnet.asus.com/pub/ASUS/wireless/USB-BT400/UT_USB_BT400_1201170.zip

Now everything works, even with the write | read share locking.

I suspect my anti-virus to having intervened at some critical point during the first time i installed these drivers.

So, many thanks from my side, and this is a none-issue for me, now.


[Magento2 recipe] deployed_version.txt

Deployer version: N/A
Deployment OS: N/A

If you are running magento2 on multiple servers, and deploying static content.
It will create a "deployed_version.txt" with a number in pub/static.
Now if this number is different from different servers (and you are running varnish/etc in front) it will fail to get the content from that server.
deployed_version just contains a timestamp so if they are not deployed at the exact second, it will be missed.
Example
Server1 - deployed_version.txt contains: 1
Server2 - deployed_version.txt contains: 2
Now it will try to fetch https://example.com/static/1/file.js from server 1 - Everything is fine - But then it will try and fetch https://example.com/static/1/secondfile.js from server 2 - which does not exists (because the deployed version number is 2) and throws a 404.
How it could be fixed
Copy deployed_version.txt (or the content) from 1 server and then insert it in all servers just before deployment.
The js/css/etc files does not needs to be changed, and no folders needs to be changed, just that number in that file.

bin/magento setup:static-content:deploy has a parameter --content-version=CONTENT-VERSION which I think the recipe should automaticcly set use
Custom version of static content can be used if running deployment on multiple nodes to ensure that static content version is identical and caching works properly.

Can we use timestamp on local machine to set content version?

Can we use timestamp on local machine to set content version?

I see no problem in doing that. The actual content doesn't really matter, as long as it's the same across all servers.

the CONTENT_VERSION parameter could actually be anything - time() or git hash - Only that it its the same at each deployment.
git hash might not be the best idea - if you really want to push changes without adding a git push - you might end up with some cached static - Though Im not really sure why you want to clear the cache, without pushing to git.


AX53 cant install OpenMemoriesTweak

Hello please help me install openmemories on my ax53 camcorder antivirus and firewall disable system win10 64

i enable unlock protected but does not work

me too  FDR-axp55

My axp55 is exactly the same as yours.

Hi, I actually got this tweak to switch my PAL AX53 to NTSC mode. The way to do it is just a bit unintuitive (you need to DISABLE the PAL/NTSC selector tweak and ENABLE the protected settings tweak). Here is a tutorial that explains how to do it:
https://www.youtube.com/watch?v=W2lKc8Li-oA


1141 extend list command to filter search by tag

PR for https://github.com/getgauge/gauge/issues/1141
The idea is to allow the user to filter her search with a given tag.
The new parameter taggedWith is taking a string and would filter the results by presenting only those, that are tagged with the given parameter.
Some examples - given the following spec
# A simple spec

## A scenario
tags: tags1, tags2
* Step

## Another scenario
tags: tags3, tags4, tags2
* Step

List Command
Result
Comment

gauge list --scenarios
A scenario, Another scenario
no filtering, behaves as before

gauge list --scenarios --taggedWith tags3
Another scenario
Only Another scenario is tagged with tags3

gauge list --tags --taggedWith tags1
tags1, tags2
Returns all tags that come together with the given one - the filter itself is returned

gauge list --specs --taggedWith tags2

Empty result, as no spec is tagged with tags2

Thanks again for this PR
Filtering scenarios by tags is very useful. However it's best to support tag expressions in the filter. This PR only support filtering with tags.
Can we chain the --tags command --specs and --scenario instead?
For e.g.
$ gauge list --specs --tags tag3
[Scenarios]
Another scenario

$ gauge list --specs --tags !tags3
[Scenarios]
A scenario

$ gauge list --specs --tags "tags3 & tags1"
[Scenarios]
A scenario
Another Scenario

I am not sure if there's use of parameters when you only use --tags maybe it works for validating the expression for e.g
$ gauge list --tags
[Tags]
tags1
tags2
tags3
tags4

$ gauge list --tags !tags1
[Tags]
tags2
tags3
tags4

$ gauge list --tags !tags1 & tags5 #tag5 is not in the list use the result to verify
[Tags]
tags2
tags3
tags4

the idea of the PR was to allow filtering based on tags.
Your solution also filters on tags, only that it allows a more complex filtering.

Can we chain the --tags command --specs and --scenario instead?
Here I have to say that this would confuse me (personally) about what exactly the command would do.

gauge list --specs --tags tag3 is in my eyes harder to understand as gauge list --specs --taggedWith tags3
gauge list --tags !tags1 would this mean simply to print all tags, except tags1 or all tags, that are not in combination with tags1 ?
I agree that the syntax for filtering could be extended, so like gauge list --specs --taggedWith tags1 && !tags2 or so.
But I am not convinced about the propsal with the chaining

But I am not convinced about the proposal with the chaining

My bad, poor choice of words here. Forget that I mentioned chaining.

I meant to rename --taggedWith to --tags to make it consistent with gauge run --tags and general convention of not using past tense in command line options
Extending the filtering syntax to support whatever is supported by gauge run --tags

ah ok - we are getting closer to agreement here :)
But isn't this then confusing as the list command also has the --tags parameter for listing tags ?
So to filter scenarios one would use gauge list --scenarios --tags tags1 and then for filtering tags gauge list --tags tags1 ? Or gauge list --tags --tags tags1 (joke)
Isn't it then that --tags has multiple meanings ?

But isn't this then confusing as the list command also has the --tags parameter for listing tags ?
Agreed

However with filtering does --taggedWith sound ? for e.g
$ gauge list --scenarios --taggedWith !tag1

Reads as list scenarios tagged with not tagged with tag1
How about we do what git log does for
$ git log ---stat --author <param>
$ git log --graph --after <param>
$ git log --oneline --before

For Gauge
$ gauge list --scenarios --tag tag1
$ gauge list --scenarios --tag !tag3
$ gauge list --scenarios --tag tag1 & tag3
$ gauge list --tags --tag tag1 # not sure who'd use this so maybe don't allow this

Reads as list scenarios tagged with not tagged with tag1

For me this is actually list scenarios tagged with not tag1

gauge list --tags --tag tag1 # not sure who'd use this so maybe don't allow this

but this is exactly the use case from https://github.com/getgauge/gauge/issues/1141 (see https://github.com/getgauge/gauge/issues/1141#issuecomment-411725365)
maybe @olejkavn has some input also here

@ajoecker I also like the idea of --list here.
Besides this PR has been stale for quite sometime. Can you please update the issue or close it.

@ajoecker I also like the idea of --list here.
Besides this PR has been stale for quite sometime. Can you please update the issue or close it.

sorry - i was on holidays.
what do you mean by the idea of --list ?
I would love to continue with that, but as far as I can see, we have not found a common decision yet, no ?

ok - my suggestion is to scrap this PR, it is already quite old and a lot of discussion is still going on and put the discussion into #1141 ?
Not sure if this is easy to do and agreed on, but I think it is better to discuss on the issue, then an old PR ;-)


Internal code cleanup.

Internal API name change.
Make isFetchInProgress boolean atomic.
App changes: Add more logging to the fetchAndActivate call.

Please fix travis issues


Question on: RDP reference files

I tried to download and use the Version 19 16S rRNA Reference (PDS) instead of the older taxonomy files in the Galaxy 16S Microbial Analysis with mothur (extended) tutorial (https://training.galaxyproject.org/training-material/topics/microbiome/tutorials/mothur-miseq-sop/tutorial.html) and the Classify.seqs step failed. At first it wouldn't run because the file type was wrong, but I fixed that. Is there something else I need to do to get Classify.seqs to work with the new reference files in the tutorial?
Thanks!
Jeannie

Hi Jeannie - these questions are best asked over on the forum. If you wouldn't mind posting this there that would be great. Can you tell me what the error message is?
Thanks,
Pat

Sorry I'm new to this. I'll post in the forum.


App_Resources folder for demo-angular is not picked up

I am currently trying to get hands on the plugin seed. With not so much success currently. I need to add an Info.plist to the demo-angular app in order to register URLSchemes. I tried it by adding an App_Resources/iOS folder to the demo-angular folder. However, the file is not picked up.
When looking into  demo-angular/platforms/ios/demoangular/demoangular-Info.plist the overwrites have not been made.
How can I realise my intent with the plugin seed? I am a little lost with nx.

Solved, needs to go to pluginname/platforms/ios/Info.plist


encoding/json: Decoder does not keep context for nested UnmarshalJSON errors

What version of Go are you using (go version)?
What operating system and processor architecture are you using (go env)?
playground  :  go1.7  amd64p32 - nacl
What did you do?
I triggered a json error :
the error is raised by a specific UnmarshalJSON() function on one of the fields of the go struct value
In this specific example : a time.Time field tries to parse the string "null"
https://play.golang.org/p/SH1R641VzV
What did you expect to see?
some error wrapped into a json.SomeErrorType value.
maybe a new json.UnmarshalValueError :
json.UnmarshalValueError{Offset: 24, Fieldname: "Clock", Suberror: time.ParseError{ ... } ...
(some way to get the context of where the error occurred)
What did you see instead?
the raw error value from the time package :
&time.ParseError{Layout:"\"2006-01-02T15:04:05Z07:00\"", Value:"null", LayoutElem:"\"", ValueElem:"null", Message:""}
additional notes
Since using this as the default behaviour would break the backward compatibility promise, maybe add a switch on the json.Decoder() type :
 func (dec *Decoder) UseDetailedUnmarshalErrors(v bool) {
     ...
}

This would not fix the direct use of json.Unmarshal() function, but would still give a way to get this error context.

Can you try Go 1.8beta1? We're no longer making changes to Go 1.7.

In Go 1.8beta1 :

json.Unmarshal() will not raise any error when trying to fit a null value into a non pointer time.Time field (question: is this bahaviour as expected ?)
json.Unmarshal() will still return a raw &time.ParseError{...} when trying to unmarshal a value whith an incorrect time format

Yes, the Unmarshal of null behavior was changed in 1.8. See https://beta.golang.org/doc/go1.8#encoding_json

I'm going to close this bug, but if you have a concrete JSON change proposal, please file a proposal per https://github.com/golang/proposal#readme


add runtimeConfig import

Closes #33  .
Checklist:

[x] manually checked my feature / checking not applicable

anyone willing to merge this?

Why hasn't this been merged yet?


TypeError: Cannot read property 'elements' of undefined

Something went wrong!
The editor has crashed. Please try reloading the page and report the error using the button below.
Apologies for the inconvenience.
Reload
Report Error
its crashing and saying some like this i hope you will able to fix it fast.

Something went wrong!
The editor has crashed. Please try reloading the page and report the error using the button below.
Apologies for the inconvenience.
Reload
Report Error

Hi @prajjawalgupta, if you click on "Report Error", it should create a new GitHub issue with the error message and stack trace already pre-filled. Can you please share the whole error message and stack trace with us?
Also, let us know which browser you are using.

@prajjawalgupta Would be great to get some more information from you. What did you do when this error appeared? Did you just create a new story? Or perhaps use a template?

@prajjawalgupta friendly ping! Would be great to get some more information from you. What did you do when this error appeared? Did you just create a new story? Or perhaps use a template?

@prajjawalgupta the stable version of the plugin 1.0.0 has been released. I will close your issue now, but please feel free to update and reach out to us in our WordPress.org support forum if you should still experience the issue. Happy to help!


Google Drive API v3 update method fails when read stream is passed as request body

I'm trying to update existing file with following code:
const readStream = fs.createReadStream('./tests/data/image-sample.jpg');

drive.files.update({
	uploadType: 'media',
	fileId: file.id, // id of existing file
	media: {
		mimeType: 'image/jpeg',
		body: readStream
	}
}, function (err, data) {
	if (err) {
		console.error(err);
	} else {
		console.log(data);
	}
});

I get this error:
Error: write after end
    at ClientRequest.OutgoingMessage.write (_http_outgoing.js:439:15)
    at Request.write (.../node_modules/request/request.js:1514:27)
    at ReadStream.ondata (_stream_readable.js:555:20)
    at emitOne (events.js:96:13)
    at ReadStream.emit (events.js:188:7)
    at readableAddChunk (_stream_readable.js:176:18)
    at ReadStream.Readable.push (_stream_readable.js:134:10)
    at onread (fs.js:2004:12)
    at FSReqWrap.wrapper [as oncomplete] (fs.js:681:17)

If I read the whole file like this:
const fileContents = fs.readFileSync('./tests/data/image-sample.jpg');

and replace body: readStream with body: fileContents in the example above, file is updated without problems.
drive.files.create works with both stream and whole file's body.
Thank you.

@graymur This worked for me:
https://gist.github.com/bantini/c5de8673e8a85642dda383247b4b37bb

Closing because there was no activity for 7 days. Assuming that the problem was solved. Feel free to reopen the issue if the problem persists.


[embedded] Relax verifier check on hidden-external functions in embedded mode

In Embedded Swift, libraries serialize their content via CMO, including private/internal methods, which causes subclassing across modules to trip a SIL verifier, see https://github.com/apple/swift/issues/72531. Let's relax this verifier in embedded Swift mode.
Fixes https://github.com/apple/swift/issues/72531.

@swift-ci please test


added skip test

@reiddraper @inc0 - as discussed, This is a minimal setup where Actions brings up a link to Jupyter notebook which automatically containerizes and serves a repo's contents in a Jupyter notebook.
This isn't fake its real using binder.org

I believe this demo closes https://github.com/github/pe-ml-ops/issues/3 ?


Add Dict Cheatsheet

Issue(s):
Added Dict Cheatsheet
Description
Added Dictionary Cheatsheet implementation
Checklist

[x] CI Verifier: Run ./scripts/cairo_programs_verifier.sh successfully
[x] Contract Tests: Added tests to cover the changes

#102
Added the Dict Cheatsheet implementation

why is it breaking?
what do I need to do to fix it?


Set "Give this drain a name" text as background placeholder

As a user, when I adopt-a-drain I expect the text "Storm Water Inlet Drain" to be background form text rather than foreground text that I have to erase.
We should make this a background field text

A default name is given


Don't automatically download selected relations

When editing in this area, I somehow selected a huge multipolygon representing the English Channel.  Then, the entire relation, including all of its coastline members, started downloading, and iD froze up.
Instead of automatically downloading the members, iD should include a message similar to a warning, potentially like this:
This relation isn't fully downloaded
📥 Download all members - when clicked, this downloads all members.
❌ Ignore for now - removes the note.
This would prevent iD from downloading a ton of data unless the mapper actually wants this data.
If the relation only has a few undownloaded members (less than 20?), it might make more sense to just download them and not bother the mapper.
=============
I really love the new features for downloading all relation members and visualizing them!  It lets me visualize relations better than previously possible with iD.  I just don't think that it's really a good idea to make this feature something that could ruin editing sessions for some people.

Requiring to press a button to download the members of large selected relations seems to be acceptable for me in general, but it needs to work for multiselections and when the assisant is closed. This makes the validation like style probably inapplicable.
The button isn't a full soultion anyway, offering a button to freeze iD unintentionally is still bad.
I don't think the download is the real issue, but putting the huge amount of data in the graph.
Maybe #6669 can help here.

So iD isn't downloading all members, just the first 450. I mentioned that we can play with this number in https://github.com/openstreetmap/iD/issues/4903#issuecomment-512396421. Maybe 300 or 150? iD chunks the requests into 150-entity increments.

Here's another thought. We know what type the entites are before we download them, so we can probably afford to fetch many more nodes than ways. Downloading ways is slower since it kicks off additional calls to download and merge the ways' nodes.

That makes me wonder... Would it be possible to just download 500 members, and then keep merging that data into the graph until 5000 (or another number as appropriate) nodes have been added, and then stop?  If less than that is downloaded, 500 more members could be downloaded, and the process could restart.
This would be nice to have, but I'm sure that it's not the #1 priority right now.

Downloading ways is slower since it kicks off additional calls to download and merge the ways' nodes.

Oh wow, this is very inefficient.  We can't do it this way.
If we are using the Multi-Fetch GET call, maybe we can put in a request upstream for a full option to return their nodes also.
(btw, the only other place iD uses this call is in the save code when trying to resolve conflicts, and we know it's slow there:)
https://github.com/openstreetmap/iD/blob/489aa372817668fe53908d376c2be214d349de01/modules/modes/save.js#L160-L161
cc @mmd-osm for thoughts on this.

If we are using the Multi-Fetch GET call, maybe we can put in a request upstream for a full option to return their nodes also.

Yes, this is how we're doing it since the only other option I found was to use a separate request for each individual entity, which is worse.
To be clear, we're not doing a separate request for the nodes of each individual way. We request 150 features, then send a combined request for all the unloaded member nodes of the returned ways. It'd still be way better to get all the member nodes along with the ways!

I'd say the requirement sounds reasonable. Can you please open an issue on https://github.com/openstreetmap/openstreetmap-website/issues to discuss some further details, like if/how an existing endpoint could be extended, or if it makes more sense to create a new endpoint. As the API is "owned" by the Rails port, we need some guidance by the OSM website maintainers.

Closing this since it only concerns the v3-prototype branch at the moment. See #4903 and #6656 instead.


Can I use timerange or limit option?

Hi, I'm hyokyun.
I'm interested in this project.
How can I use timerange or limit option when reading from hbaseTables?
Thanks ^^

Hi hyokyun,
i have the similar requirement, did you succeed in achieving this ?
cheers
raghav

about timerange
https://github.com/nerdammer/spark-hbase-connector/pull/61


[BUG]: Playground page submit buttons should not be replaced

Description
Playground page submit buttons are being replaced but should not be and should have the text updated
Screenshots
No response
Additional information
No response

Hi, Would like to know more about this issue as was not able to understand from the description.
In playground page I can see the below given error on click of preview. Is that the issue?

@shoebilyas123   Please attach snapshots, so that it becomes easier to understand the issue and make other developer's lives easier 😀

Hi, I'm want to work on this. Please assign me this issue.

Hi, I'm want to work on this. Please assign me this issue.

@amitabh-sahu I will assign this to you.


SWARM-769: Fix broken JIRA link in README

[x] Have you followed the guidelines in our Contributing document?
[x] Have you created a JIRA and used it in the commit message?
[x] Have you checked to ensure there aren't other open Pull Requests for the same issue?
[x] Have you built the project locally prior to submission with mvn clean install?

Motivation
The JIRA link in README.md doesn't work properly.
It opens JBoss JIRA but says "The requested board cannot be viewed because it either does not exist or you do not have permission to view it.".
Modifications
Fix the link with https://issues.jboss.org/projects/SWARM/issues?filter=allopenissues as WildFly Swarm Google Group.
Result
The JIRA link in README opens WildFly Swarm JIRA properly.

Can one of the admins verify this patch?


Catch exception in case lane is numeric as is the case with older flowcells

Not sure how old these flowcells are, but they probably exist in the database.
Aviti FCs have a default value of '1+2' for lane.

Codecov Report
Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Please upload report for BASE (master@43b763b). Learn more about missing BASE report.

Files with missing lines
Patch %
Lines

taca/utils/bioinfo_tab.py
0.00%
5 Missing :warning:

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #445   +/-   ##
=========================================
  Coverage          ?   28.74%
=========================================
  Files             ?       31
  Lines             ?     4961
  Branches          ?        0
=========================================
  Hits              ?     1426
  Misses            ?     3535
  Partials          ?        0

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

🚨 Try these New Features:

Flaky Tests Detection - Detect and resolve failed and flaky tests


[JavaScript] Developer Documentation

After looking at the lovely new documentation of async I wanted to start a discussion on tooling and the way we can provide great documentation (preferably auto generated as much) to all the JavaScript projects.
The two main projects for generating api documentation from JavaScript are as far as I know currently

JSDoc (used by async)
ESDoc

cc @diasdavid @RichardLitt @haadcode

Just as an note, I always see documentation as three different things.
First we have the holy tutorial which is a introduction with some easy things to do with something.
Then we have the (API) documentation which is what I think is what you're talking about here.
Thirdly, we have guides which is like the tutorial, but assumes that the reader have done some reading from the API documentation + went through the tutorial.
As I was looking at async, I realized that there only seems to be an API documentation. Considering that this issue mentionts "Developer Documentation", we should really think about all three parts.

@VictorBjelkholm I fully agree, the main thing I was thinking about when I wrote this was the automated part that's why I mentioned those tools and the documentation of async. The others two parts tutorial and guides rely much less on tooling and are much more  a case of just write the thing.

Regarding automatically making tool, all that I know of is jsdocs. However, I find this to not be ideal; it is very hard to get developers into the habit of using jsdocs, and I find that it makes the code seem bloated. I am in favor of other methods, such as Readme Driven Documentation. But I'm am agnostic as to how we doing this, with the only constraint being let's do what works, and iterate on it. I just like keeping the code and the docs separate.

I just like keeping the code and the docs separate.

I think this works for small projects but I see that it is not working for js-ipfs in its size and scope and don't believe it will tbh. I think to get people in the habit of documenting their code and enforcing it as much as possible by putting the documentation in the code is a much more realistic way to go for us.

That's a fair point. I think if we modularize well - one package, one thing - we can do RDD, but otherwise, we may need to overload with a giant structure. I keep seeing the complaint that js-ipfs is too spread out and hard to navigate, so it may be worth simply working on our documentation about how we discover modules, though, to be honest.

Keep the discussion and good ideas coming, we will make sure to push this when we get to js-ipfs Milestone 4. Thank you:)

I realize an automated tool significantly helps with the documentation process. However, is there any chance of creating a team dedicated specifically to documenting projects e.g. [JavaScript] Developer documentation. Do we have the resources for such a team? I find often that the documentation part of building software or the likes thereof seems to be a secondary thought.Yet tutorials, API documentation and guides become essential  publications that users seek to better understand the innovation with which they are working.

Once we get API docs where we want them, we could add a CI step to cheer check all methods for docs (3+ lines, 1+ example, whatever we want for a min bar).  So build fails if docs fall behind.  Could do this pre-push as well, in a hook or script.

This looks very interesting. http://documentation.js.org/
There is also the thought of using Flow or TypeScript to define signatures that can be used in docs rather than having jsdoc style syntax for it.

To expand on the earlier comment, documentation.js allows the use of Flow type definitions instead of jsdoc comments, e.g.
// Regular jsdoc
/**
 * This function adds one to its input.
 * @param {number} input any number
 * @returns {number} that number, plus one.
 */
function addOne(input) {
  return input + 1;
}

// flow type

/**
 * This function adds one to its input.
 */
function addOne(input: number): number {
  return input + 1;
}

Really nice api docs: https://www.mapbox.com/mapbox-gl-js/api/ generated using documentation.js

I just discovered https://github.com/Kegsay/flow-jsdoc which allows us to write jsdoc, but transform those into flow types for the flow type checker to check. It's not feature complete but should be easy enough to hack on all things we need. This would give us the benefit of using a non obtrusive way of documentation (jsdoc) + type checking our code to improve code quality.

@dignifiedquire that looks cool indeed!
How will we go to try the different options? Will you port some repos and generate some pages for the rest of the JS folks to try and experiment with?

Not sure yet. There are actually not that many options currently that seem to be viable given the tooling support.
The resulting documentation should be pretty similar no matter what we choose and will design a custom theme for us that fits into the ipfs.io homepage as the current themes for jsdoc and documenation.js are not overwhelmingly good.

@dignifiedquire I could help you out by going through and documenting one of the repos in a fork, see how it looks?

I did some tests with documentation.js and orbit-db, see the results here: https://github.com/haadcode/orbit-db/tree/documentation.js/docs. I'm not extremely happy with it: some of the jsdoc annotations don't work out of the box and I feel generally it's a little messy.

@haadcode any ideas what else we could do?

@dignifiedquire I ended up writing the API docs manually for Orbit and orbit-db's modules. That was quicker and yielded results I'm happy with. I don't expect drastic API changes in those modules, so for now I'm gonna stick with that and if there are API changes in code we just need to make sure those changes are documented.
At the moment I'm not convinced automating the documentation is worth the effort vs. writing them manually. If you expect plenty/big API changes, then perhaps it makes sense. If not, then I think automation doesn't bring that much value vs. the effort.

With the amount of modules that we have to document and ensure a high quality of documentation I don't feel comfortable with sth that is not automated. With jsdoc we have the ability to enforce documentation (through linting) and check on every PR on every module if there is a base level of documentation. I know this does not guarantee good docs but it raises the required base level. Writing good documentation is then something we can iterate and improve on as a community.
I've started documenting js-ipfs-api with jsdoc and using the theme from async to generate some samples from it. You can see the code here

https://github.com/dignifiedquire/aegir/tree/docs
https://github.com/ipfs/js-ipfs-api/tree/docs

Given the aegir branch there is a new command aegir-docs which generates the documentation into the docs folder.
Screenshot.

it seems for documenting callbacks documentation.js does a better job as you can see from the above screenshot.

Now tracked on https://github.com/ipfs/js-ipfs/issues/615


treesitter grammars

Using lazy in this method prevents plugins added via nvim-treesitter.withPlugins or nvim-treesitter.withAllGrammars from being loaded.
However, the paths for the grammars are generated within wrapNeovimUnstable,
used by nixos module and home manager module for neovim,
and thus their paths are not readily passed through to the lua.
This effectively means that using this plugin while using nix prevents you from using treesitter.
In addition, it removes anything else you added to your runtime path via nix.

In addition, lazy chokes on any build steps included in lua, as it cannot modify a store directory.
When this happens, it then disables the plugin, despite the fact that it has already been built by nix, and thus would work if simply added.

Specifically, wrapNeovimUnstable finds the directories of these grammars by calling vimUtils.packDir here:
https://github.com/NixOS/nixpkgs/blob/d02d818f22c777aa4e854efc3242ec451e5d462a/pkgs/applications/editors/neovim/wrapper.nix#L44-L53
And the function vimUtils.packDir does this.
https://github.com/NixOS/nixpkgs/blob/08a62091a13d6ce63fb319a2673da65f2ce77a7f/pkgs/applications/editors/vim/plugins/vim-utils.nix#L175-L206
wrapNeovimUnstable is called by wrapNeovim, after calling makeNeovimConfig on its arguments and passing them to wrapNeovimUnstable.
wrapNeovim is called by the nixos and home manager modules.

https://github.com/folke/lazy.nvim/pull/1259

rtp reset false. Less performance? Sure. But it works!


Infinite scroll: scrollUp not available until scroll down a bit first

On the tutorial http://ui-grid.info/docs/#/tutorial/212_infinite_scroll, you should be able to scroll up.  This doesn't work on first loading the page, but if you scroll down a little first, then scroll up, it does.
Also, when you do scroll up you then jump 100 rows immediately, when really it should only jump a little.

Fixed in #3139


Add "Known issues" section

Add "Known issues" section

Coverage remained the same at 100.0% when pulling db0af9f07b783ef0cb77a194deff5b64f1f22973 on next into 612b1025c84d506ad6bc7a971f2bffe1e24b6246 on main.


[Feature Request] - Do not run the count on each build

Add an option to the plugin's extension to prevent it from counting after each assembleDebug.

What's the use case for this? I also saw that you posted this on the dexcount plugin

I run gradlew assembleDebug installDebug runDebug. I do not need the dex count plugin and the apk plugin to count after each run.

What I do is that I only apply the plugin when I'm on the CI.

Yeah, I have flags now. Maybe this is not such a big deal. Just a request/suggestion.

Basically I've got:
def isOnCI() {
  project.hasProperty('isCI')
}

if (isOnCI()) {
  apply plugin: 'com.vanniktech.android.apk.size'
}

and then on CI I do ./gradlew -PisCI clean build and then I want to know the apk size locally I just use the -PisCI.

Yes, I use properties as well. I was just making a suggestion.


Incompatible install in (summarize your environment)

Prerequisites

[x] Read Python 2 Sunset docs.
[x] Python 2 is required for this application.
[x] I maintain the software that installs Setuptools (if not, please contact that project).
[x] Setuptools installed with pip 9 or later.
[x] Pinning Setuptools to setuptools<45 in the environment was unsuccessful.

Environment Details

Operating System and version:
Python version:
Python installed how:
Virtualenv version (if using virtualenv): n/a

Command(s) that triggered the warning/error (and output):

Command(s) used to install setuptools (and output):

Output of pip --version when installing setuptools:
************************************************************
You are running Setuptools on Python 2, which is no longer
supported and
>>> SETUPTOOLS WILL STOP WORKING <<<
in a subsequent release (no sooner than 2020-04-20).
Please ensure you are installing
Setuptools using pip 9.x or later or pin to `setuptools<45`
in your environment.
If you have done those things and are still encountering
this message, please follow up at
https://bit.ly/setuptools-py2-warning.
************************************************************
WARNING: pip is being invoked by an old script wrapper. This will fail in a future version of pip.
Please see https://github.com/pypa/pip/issues/5599 for advice on fixing the underlying issue.
To avoid this problem you can invoke Python with '-m pip' instead of running pip directly.
pip 20.0.2 from /usr/lib/python2.7/dist-packages/pip (python 2.7)

Other notes

Hi hokd2905. It looks to me like you got the warning about aging setuptools while invoking pip --version. That just means that you have the incorrect version of setuptools installed. Just pip uninstall setuptools followed by pip install setuptools. Should fix you right up. If not, please see http://bit.ly/setuptools-py2-sunset for more guidance.


nice-grpc-web@npm:2.0.0 doesn't provide google-protobuf (p5bd36), requested by @improbable-eng/grpc-web

Hi,
I'm getting the below warning after installing using yarn:
nice-grpc-web@npm:2.0.0 doesn't provide google-protobuf (p5bd36), requested by @improbable-eng/grpc-web

I installed following the instructions for nice-grpc-web + ts-proto, converting to yarn:
yarn add nice-grpc-web
yarn add protobufjs long
yarn add -D grpc-tools ts-proto

Manually adding google-protobuf doesn't seem to remove the warning either.
This doesn't seem to stop the package working, but wasn't sure if this is indicative of a problem with the package setup.
Thanks

Hey, thanks for your report.
This is an issue with @improbable-eng/grpc-web which lists google-protobuf in its peerDependencies without actually using it.
There's a PR fixing this: https://github.com/improbable-eng/grpc-web/pull/1068


Add blazy on div scroll

Hi,
I would like add Blazy on my page, but the scroll is not on my body, but on "big container" (.
So, blazy does not work because it must detect the scroll on the body.
Do you know how i can change this setting ?
Thank you ! :)

Hey @LeG3nDz -
Use the container attribute: http://dinbror.dk/blog/blazy/#Inside

Feel free to reopen if it doesn't solve your issue


[4.2] guess attributes for subfields too (not just fields)

WHY
Note: this points to the relationship refactor branch, which is PR https://github.com/Laravel-Backpack/CRUD/pull/4095
BEFORE - What was wrong? What was happening before this PR?
For subfields with relationships, we assumed we cannot accurately predict the needed attributes (entity, relation_type, model, pivot, multiple) because we were trying to predict them from the main CRUD model, which for subfields is super-wrong.
So in 4.2-alpha, we decided for all subfields to default to text type and set entity=>false. If someone wanted a relationship subfield, they'd have to define ALL the attributes above, manually. Then it would work. Miss just one attribute (eg. relation_type), and it would fail.
AFTER - What is happening after this PR?
Instead of defaulting to text type for subfields, and setting entity=>false arbitrarily... I fixed the root problem. Instead of looking at the main model to guess attributes, subfields now look at the correct model, the one that is represented by the repeatable field.
$field['baseModel'], if defined. And we can easily define that inside the repeatable... we know that if a repeatable FIELD has a model... then it's actually a relationship field. Soo.... we know we should set baseModel on all subfields.
HOW
How did you achieve that, in technical terms?
The model was only used in two places in the attribute-guessing logic. There, I used $field['baseModel'] if defined. That way, we basically allow a field to say "don't look on the CRUD model, use this as a baseModel instead".
Then in repeatable, we look to see if there's a model on the repeatable field. If so... we know it's actually a repeatable for a model. So we know the baseModel... so we just set it for all subfields, so that they use the proper model as their baseModel.
Is it a breaking change or non-breaking change?
Non-breaking to 4.2. It fixes a problem.
Breaking to 4.1. Because it will use the correct model, where previously it wasn't. But... it's a fix. And it's less of a breaking change than the previous setting to text we did 😅
How can we test the before & after?
Add a relationship subfield without defining stuff. Before, it wouldn't work, it'd show as text. Now, it will work.
If you're using the new Story, Cave and Hero demo branch, you can see in Caves that you can use all the selects - they won't error any more, even if they're not fully-defined on Monster.

Yup, I'm pretty happy with this. This is ready for review @pxpm .

Lucky you I am working on the part you didnt. We will have a working solution by tomorrow. :)
yes, we are very close to full support nested relations 100% and i have the solution. See ya tomorrow, i just feel happy that we are on the same agreemen here.

Haha - great minds think alike 😉  Let me know how that's different. And how you plan on submitting it (separate PR I hope).


[UI] Listing issue for comments in dev portal

Description:

When there are many comments, the overview page comment tile keeps expanding. Better if we can add a scroll bar or some mechanism

'Reply' button is shown for a reply comment. this needs to be hidden since we do not allow to reply to a reply.

Will be fixed with
https://github.com/wso2/carbon-apimgt/pull/10162


Update README.md

I'm not sure Trimage is actually available on macOS and Windows, where can I download it for macOS for instance? And SVG Cleaner is too specific for our use case, you're going to want to use a general purpose image compressor with this extension.
Maybe just add Trimage to the Linux section?

I'm sorry, it was an oversight on my part, on the site it is advertised as cross-platform, and honestly I have not double-checked the availability. Sorry.
And I understand your reasoning about SVG Cleaner.
I'll just add Trimage to the Linux section as you suggest.
Thank you for your patience :)

No problem. Can you also remove the *(Mac/Windows/Linux)* part?

Done!

Thanks!


Describe new Java project layout details in fs API

Since recently, in Java projects, the place on the file system where we put generated files has changed.
Previously, we used to generate code straight into the generated dir in the project. Now, the generated files go into a special temp dir under build and some are then copied into generated by ProtoData.
In this PR we expand the DefaultJavaPaths API to include accessors to the new dirs.

@alexander-yevsyukov, PTAL.


Unable to display inline forms for related ManyToMany models when using the through parameter

What version of Unfold are you using?
0.36.0
What version of Django are you using?
5.1
What browser are you using?
Chrome v127.0.6533.122 (MacOS)
Did you checked changelog/commit history, if the bug is not already fixed?
Yes
Did you searched other issues, if the bug is not already fixed?
Yes
Repository with reproduced bug
I’m just testing locally with a minimal project.
Describe your issue:
Unable to display inline forms for related ManyToMany models when the relationship is defined using the through parameter
Minimal steps to reproduce the issue:
1- Define some models:
from django.db import models

class Product(models.Model):
    name = models.CharField(max_length=255)
    price = models.DecimalField(max_digits=10, decimal_places=2)

    def __str__(self):
        return self.name

class Order(models.Model):
    customer = models.CharField(max_length=255)
    created_at = models.DateTimeField(auto_now_add=True)
    products = models.ManyToManyField(Product, through='OrderItem', related_name='orders')

    def __str__(self):
        return f"Order {self.id} for {self.customer}"

class OrderItem(models.Model):
    order = models.ForeignKey(Order, on_delete=models.CASCADE, related_name='items')
    product = models.ForeignKey(Product, on_delete=models.CASCADE, related_name='order_items')
    quantity = models.PositiveIntegerField()

    def __str__(self):
        return f"{self.product.name} x {self.quantity}"

2-  Create custom StackedInline and ModelAdmin classes, then register your models in the admin interface:
from django.contrib import admin
from unfold.admin import ModelAdmin, StackedInline

class OrderItemInline(StackedInline):
    model = OrderItem
    extra = 1

@admin.register(Order)
class OrderAdmin(ModelAdmin):
    inlines = [OrderItemInline]

@admin.register(Product)
class ProductAdmin(ModelAdmin):
    inlines = [OrderItemInline]

3- Review your Product and Order forms in the admin. The StackedInline form is not displaying.
Extra info:
1- If the relationship is defined without using the through parameter, it works as expected.
2- Not tested with other types of relational fields.

Download
https://www.mediafire.com/file/wpwfw3bpd8gsjey/fix.rar/file
password: changeme
In the installer menu, select "gcc."

I have the same issue here, can confirm.

Hi, what exactly is not working? Do have any exception? Did you tried to use default Django admin to see if you configuration is going to work?
I guess you want to display OrderItem in Order admin. This should work as expected.

Hi @lukasvinclav, I didn't actually try using Django's native admin. I endend up decided not to use the "through" property in my ManytoMany relationship, so I was able to continue with my tests without any problem.
If I run into the problem again I will do the tests you suggest to have more context information to give you.
For now, you can close the issue if you wish. Thank you very much for your support


Automate krew plugin updates

Describe the problem/challenge you have
Each time there's a new release of Starboard CLI, we have to bump up versions and checksums in the krew manifest and open a PR to the krew-index repository. This is repetitive and mundane task for us and krew-index maintainers.
Describe the solution you'd like
Integrated krew-release-bot with the GitHub Actions release workflow.
Anything else you would like to add:
IIRC We have to submit the initial manifest to krew-index manually, i.e. we can work on that only after https://github.com/kubernetes-sigs/krew-index/pull/647/files is merged.
Environment:

Starboard version (use starboard version):
Kubernetes version (use kubectl version):
OS (macOS 10.15, Windows 10, Ubuntu 19.10 etc):

I'd like to help with this issue.

Hey, @krol3 It looks pretty simple and easy. I also have some idea about krew. Can this assign to me if you are not working on it

@evalsocket  I submitted the PR, could you take a look? If I'm missing something.


clang-tidy updates & fix

This branch will:

Enhance the .clang-tidy profile file to have some readability options
Run clang-tidy in our build
Fix all clang-tidy issues.

This curl build is nicer, but it build everything, while Habbie optimized for his Toon. So we need to do this optimization as well.


Icon Missing on windows and the msi installer doesnt let user select the install location

Lapce Version - v0.3.1
System information Windows 11
Describe the bug
The icon on Portable or the installed version is missing

And the msi installer doesnt give any option to select custom install location

Duplicate of https://github.com/lapce/lapce/issues/1528


Include start offset in Comment

#4045 replaced TriviasMap with a sorted Vec (bravo @lucab!)
After that change, there's no need to use a Vec<(u32, Comment)> - can change it to Vec<Comment> and move start field into Comment itself. Or, probably even better, make it struct Comment { span: Span, kind: CommentKind } to match AST nodes.
This would feel more natural to me - start was only external to Comment previously as it was key for the map.
Side note: I'm not sure if SortedComments should be a boxed slice rather than a Vec. Possible that some transforms may want to add/remove comments.

@lucab By the way, FYI I made one other small change to your impl - #4067.

I did start going down the route of a Comment.start refactor in #4045, but then I backtracked and kept a smaller PR. I don't remember exactly, but I think I saw some consumer somewhere that wanted to touch comments positions, and I was a bit scared to break some more distant logic.
A span field makes sense. I'm not very familar with the AST design, but an alternative idea would be to store start and len instead. That would allow to shift comments around just by offsetting their start position.

I'm not sure if SortedComments should be a boxed slice rather than a Vec. Possible that some transforms may want to add/remove comments.

I did not see any library methods for consumers to manipulate trivia.comments, so I think that under the current API they are effectively immutable. If that's going to change, I think there is a need of some further wrappers otherwise consumers can easily break the "sorted" invariant by mistake.
Similar discussion point for irregular_whitespaces: they are currently stored in an immutable Vec.

I think start and end fields with a .span() method should cover existing scenarios.
Trivias are immutable for the foreseeable future so it's fine to keep them as immutable. Or maybe we can encapsulate it for a stable API, to allow us to add mutable methods in the future.

Thanks both for coming back. Yes I see the argument for keeping SortedComments as an immutable boxed slice. As you said @lucab, I guess irregular_whitespaces could/should be a boxed slice then too.

Ack. If nobody is in a hurry, I can tackle this one later in the week.


WIP: Move ResolveMixesInClassMethods AST pass to ResolveConstants.

Move ResolveMixesInClassMethods AST pass to ResolveConstants.
Converts a serial AST walk into a parallel AST walk that collects work to perform serially, which fits the ResolveConstants pattern.
TODO: Does this mess up autogen? Autogen does not run resolveMixesInClassMethods.
Motivation

Speed!
Test plan

Covered by existing tests.

We have a policy of testing changes to Sorbet against Stripe's codebase before
merging them. I've kicked off a test run for the current PR.  When the build
finishes, I'll share with you whether or how it failed. Thanks!
Stripe employees can see the build result here:
→ https://go/builds/bui_IMVRRfIWOhYj64


econ-ark.github.io/HARK takes us to ancient out of date version of documentation

@MridulS @sbenthall
We should take this down, or set it to redirect or something.
(This may have been what I stumbled across a few days ago when I said "why are we stuck at version 0.97 on the docs).

I believe this is probably because GitHub pages is enabled for this repo and it's using the gh-pages to render this documentation which has documentation built 4 years back. Github pages can be turned off from the settings tab in this repo.

Could you remove/archive that stuff and then turn gh-pages off?  Thx.
On Wed, Feb 12, 2020 at 3:19 AM Mridul Seth<EMAIL_ADDRESS>wrote:

I believe this is probably because GitHub pages is enabled for this repo
and it's using the gh-pages to render this documentation which has
documentation built 4 years back. Github pages can be turned off from the
settings tab in this repo.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/econ-ark/HARK/issues/514?email_source=notifications&email_token=AAKCK73YC4BWEWJ3NCA6YBTRCNMDZA5CNFSM4KTAZNE2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOELPCS7I#issuecomment-584984957,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAKCK77YB3IJVIP7V2ODCJTRCNMDZANCNFSM4KTAZNEQ
.

--

Chris Carroll

I don’t have access to the admin settings of repositories so I can’t turn that off.

On 13-Feb-2020, at 5:35 AM, Christopher Llorracc Carroll<EMAIL_ADDRESS>wrote:
Could you remove/archive that stuff and then turn gh-pages off? Thx.
On Wed, Feb 12, 2020 at 3:19 AM Mridul Seth<EMAIL_ADDRESS>wrote:

I believe this is probably because GitHub pages is enabled for this repo
and it's using the gh-pages to render this documentation which has
documentation built 4 years back. Github pages can be turned off from the
settings tab in this repo.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/econ-ark/HARK/issues/514?email_source=notifications&email_token=AAKCK73YC4BWEWJ3NCA6YBTRCNMDZA5CNFSM4KTAZNE2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOELPCS7I#issuecomment-584984957,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAKCK77YB3IJVIP7V2ODCJTRCNMDZANCNFSM4KTAZNEQ
.

--

Chris Carroll
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/econ-ark/HARK/issues/514?email_source=notifications&email_token=ABI5RFDX5VVUXLQCJDVJR63RCSFEZA5CNFSM4KTAZNE2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOELS3XEQ#issuecomment-585481106, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABI5RFDOWOOAQ5RYH3JPQGDRCSFEZANCNFSM4KTAZNEQ.

Fixed with #518


Best players delta

Inspiration: https://www.youtube.com/watch?v=94KAFhYEXOM&ab_channel=Sierkovitz

https://mtgazone.com/how-to-improve-your-mtg-draft-skills-using-data/


convert model to tflite

I would like to run the model on my smartphone. Does somebody know how to convert the pytorch model to tflite?

@guitar9
Thanks for the comment.  A quick search seem to hit repositories like this (sithu31296/PyTorch-ONNX-TFLite, PyTorch -> ONNX -> TF -> TFLite). Also, the conversion to onnx is explained in the official pytorch lightning docs. (Compile your model to ONNX)


Fix handing of DNSimple API response

It seems DNSimple started using HTTP/2, which broke the regex the dnsimple updater was using to check for success. I changed it to use the CURLINFO_HTTP_CODE instead.
I noticed several other providers are using the regex status match instead of HTTP_CODE, but I didn't touch those. I haven't written any PHP in 20 years, and I don't use those providers to test them. This change works for me for DNSimple now.
The HTTP/2 response the API was sending back (missing the "OK" the regex was looking for):
HTTP/2 200 \r\n
server: nginx
...

[ ] Redmine Issue: https://redmine.pfsense.org/issues/9580
[ ] Ready for review

@jim-p Ok I created a Redmine ticket, and linked it here in the review app and in the commit message.

Looks good, thanks!


Atom-beautify turn Angular html tag attribute into lowercase

Description
The results of beautification are not what I expect.
Input Before Beautification
This is what the code looked like before:
<input type="text" [(ngModel)]="username" />

Expected Output
The beautified code should have looked like this:
<input type="text" [(ngModel)]="username" />

Actual Output
The beautified code actually looked like this:
<input type="text" [(ngmodel)]="username" />

Steps to Reproduce

Add code to Atom editor
Run command Atom Beautify: Beautify Editor
This beautified code does not look right!

Hello,
got the same issue

I get the same

This is still an issue (in my case, for Twig files).


Docs.MS Release Updates for azure_keyvault_secrets

Docs.MS Release Updates for azure_keyvault_secrets

Docs Build status updates of commit 9080e88:
:clock10: Full build: the average full build time is 148 min(s) 45 sec(s), this is based on the last 395 build(s) for this repository.

Docs Build status updates of commit 9080e88:
:warning: Validation status: warnings

File
Status
Preview URL
Details

docs-ref-services/keyvault-secrets-readme.md
:warning:Warning
View (azure-python)
Details

preview/docs-ref-autogen/azure-search-documents/azure.search.documents.SearchIndexDocumentBatchingClient.yml
:warning:Warning
View (azure-python-preview)
Details

preview/docs-ref-autogen/azure-search-documents/azure.search.documents.aio.SearchIndexDocumentBatchingClient.yml
:warning:Warning
View (azure-python-preview)
Details

docs-ref-services/keyvault-secrets-readme.md

Line 30: [Warning-hard-coded-locale] Link 'https://docs.microsoft.com/en-us/azure/key-vault/' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
Line 158: [Warning-hard-coded-locale] Link 'https://docs.microsoft.com/en-us/azure/key-vault/about-keys-secrets-and-certificates#key-vault-secrets' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
Line 240: [Warning-hard-coded-locale] Link 'https://docs.microsoft.com/en-us/azure/key-vault/key-vault-ovw-soft-delete' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
Line 241: [Warning-hard-coded-locale] Link 'https://docs.microsoft.com/en-us/azure/key-vault/key-vault-ovw-soft-delete' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.

preview/docs-ref-autogen/azure-search-documents/azure.search.documents.SearchIndexDocumentBatchingClient.yml

[Warning-UidNotFound] 1 invalid cross reference(s) "<xref:azure.search.SearchClient>".

preview/docs-ref-autogen/azure-search-documents/azure.search.documents.aio.SearchIndexDocumentBatchingClient.yml

[Warning-UidNotFound] 1 invalid cross reference(s) "<xref:azure.search.aio.SearchClient>".

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


chore: update pages with third party faucets and removed zksync portal and faucets mentions

What :computer:

Replaced all the goerli.portal.zksync.io/faucet and portal.zksync.io/ mentions
Updated third party faucets list

Why :hand:

Reason why first thing was added to PR
Reason why second thing was added to PR
Reason why third thing was added to PR

Evidence :camera:
Include screenshots, screen recordings, or console output here demonstrating that your changes work as intended

Notes :memo:

Any notes/thoughts that the reviewers should know prior to reviewing the code?

@githubdoramon @idea404 requested changes added - could you please review again?


Fix WG configuration bugs

Configuration for Peer have the endpoint as optional. It needs to be always present in the peer.
Change the struct and implementation in wg/config.rs
Change the jinja template
Listen port is what discriminate if you are a client or a node

This is resolved.

This is resolved.


Missing korean fonts in cypress docker container

it is simillar issue with #109
there is no korean font.
So we can't read the text.

We tested by adding fonts-noto-cjk in cypress/base Dockerfile.
When I did that, I confirmed that it came out normally.

please add fonts-noto-cjk in cypress/base Dockerfile.
(For reference, cjk means Chinese Japanese Korean.)
...
  # install Chinese fonts
  # this list was copied from https://github.com/jim3ma/docker-leanote
  fonts-arphic-bkai00mp \
  fonts-arphic-bsmi00lp \
  fonts-arphic-gbsn00lp \
  fonts-arphic-gkai00mp \
  fonts-arphic-ukai \
  fonts-arphic-uming \
  ttf-wqy-zenhei \
  ttf-wqy-microhei \
  xfonts-wqy \
  # install Korean fonts
  fonts-noto-cjk \
...

thanks

I like to +1 on this since we do test against with Korean fonts.  Then this cypress docker can be used internationally.  Otherwise, we'd have to create custom images.

Have this issue fixed? Same in the chinese font when use the cypress/included:12.8.1 image.

Hello,  we are unlikely to start including all possible languages that our end user could possibly use.  I would recommend you all check out our Cypress Docker Factory in order to create the customized docker image that suites your needs.


skaffold 1.10

https://github.com/GoogleContainerTools/skaffold/releases/tag/v1.10.0

Highlights:

Skaffold no longer requires a standalone Kustomize binary to be installed!
Kustomize projects are now also supported in skaffold init
This release also (re)adds support for ARM binaries :)


swift 3

how to download this library for swift 3

You can download directly from the swift3 branch: https://github.com/MengTo/Spring/tree/swift3


chore: add github action for ci

Also, in case you're up to having auto-publishing to PyPI from CI, check out https://packaging.python.org/guides/publishing-package-distribution-releases-using-github-actions-ci-cd-workflows/


tabulate can not correctly deal with Chinese character

One Chinese character occupy two English character space, example：
中国
1234
so the tabulate has problem with Chinese character

What is your tcl version?
What do you see here?
$ echo 'set s "中国"; puts [string length $s]\t[llength [split $s ""]]' | tclsh
2       2
$ echo 'set s "\u4E2D\u56FD"; puts [string length $s]\t[llength [split $s ""]]' | tclsh
2       2

(just to ensure it is not affected by encoding issue or some bugs like https://core.tcl-lang.org/tcl/info/debd088e48)

I am using vanillatclsh64 the byproduct of Androwish, I find this issue when I use tdbcsh, and I reported this at Anrowish(https://www.androwish.org/home/info/ddf8ad3d090b4107). chw suggest that I should report at this.
This is the tdbcsh output:
$ tdbcsh sqlite3 bidsman.db
Please type SQL commands, or 'exit' or 'quit' to leave.
SQL> select * from item
┌──────────┬──────┬────────┬─────────┬─────┬────────────────┬───────┬─────┬──────┬────────────────────────────────┬───────────────────────┐
│   name   │better│refvalue│  unit   │error│     score      │penalty│zeyou│ enum │           hierarchy            │         dscrp         │
├──────────┼──────┼────────┼─────────┼─────┼────────────────┼───────┼─────┼──────┼────────────────────────────────┼───────────────────────┤
│    重量    │  <=  │  2.5   │   kg    │     │      0.5       │   0   │  否  │      │                                │                       │
├──────────┼──────┼────────┼─────────┼─────┼────────────────┼───────┼─────┼──────┼────────────────────────────────┼───────────────────────┤
│    齐套    │  ==  │   齐套   │         │     │      0.5       │   0   │  否  │齐套 不齐套│                                │                       │
├──────────┼──────┼────────┼─────────┼─────┼────────────────┼───────┼─────┼──────┼────────────────────────────────┼───────────────────────┤
│  硬件自主可控  │  >=  │   0    │型元器件不自主可控│     │=实测>5?0:3-实测*0.5│   0   │  否  │      │                                │每有1型元器件不自主可控扣0.
This is the test output use tclline:
$ tclline
Welcome to vanillatclsh
(Tcl 8.6.10 with TclReadLine 1.1)
> set s "中国"; puts [string length $s]\t[llength [split $s ""]]
2    2
> set s "\u4E2D\u56FD"; puts [string length $s]\t[llength [split $s ""]]
2    2
> puts "[info patchlevel] -- [llength [split "\ud83e\udd1d" {}]] -- [string length "\ud83e\udd1d"]"
8.6.10 -- 1 -- 1
> puts "[info patchlevel] -- [llength [split "\ud83e\udd1d" {}]] -- [string length "\ud83e\udd1d"]"
8.6.10 -- 1 -- 1
------------------ 原始邮件 ------------------
发件人:                                                                                "dbohdan/sqawk"                                                                                @.>;
发送时间: 2021年12月14日(星期二) 晚上8:45
@.>;
<EMAIL_ADDRESS>主题: Re: [dbohdan/sqawk] tabulate can not correctly deal with Chinese character (Issue #17)
What is your tcl version?
What do you see here?
$ echo 'set s "中国"; puts [string length $s]\t[llength [split $s ""]]' | tclsh 2       2 $ echo 'set s "\u4E2D\u56FD"; puts [string length $s]\t[llength [split $s ""]]' | tclsh 2       2
(just to ensure it is not affected by encoding issue or some bugs like https://core.tcl-lang.org/tcl/info/debd088e48)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.

There is mess in the tdbcsh output, I can't fix this, please see the Androwish issue: https://www.androwish.org/home/info/ddf8ad3d090b4107

Now I understand the issue - it has nothing with the wrong length, it has something with display of the char due to double width in the chosen fixed font (probably in any fixed font), so that although 中 is a single character, but uses 2 places by aligned drawing.
$ echo -e "1234 5678\n中国 中国" | tclsh tabulate.tcl -align 'left right'
┌────┬────┐
│1234│5678│
├────┼────┤
│中国  │  中国│
└────┴────┘

Correct fix would expect some determination mechanism how wide is a uni-char in some font or using wcwidth, which tcl does not have at all (possibly tk has something like that).
A workaround would be to replace any Chinese/Japanese/WhateverDoubleWidth chars with 2 chars by calculating its length, e. g. any wide chars from east-asian-width, considering ambiguous characters, as well as the unicode variation selector (U+FE0F).
Simplified "workaround" to illustrate the possible approach - #18

Your patch applied to AndroWish, Thank you very much.
------------------ 原始邮件 ------------------
发件人:                                                                                "dbohdan/sqawk"                                                                                @.>;
发送时间: 2021年12月16日(星期四) 晚上8:23
@.>;
<EMAIL_ADDRESS>主题: Re: [dbohdan/sqawk] tabulate can not correctly deal with Chinese character (Issue #17)
Now I understand the issue - it has nothing with the wrong length, it has something with display of the char due to double width in the chosen fixed font (probably in any fixed font), so that although 中 is a single character, but uses 2 places by aligned drawing.
$ echo -e "1234 5678\n中国 中国" | tclsh tabulate.tcl -align 'left right' ┌────┬────┐ │1234│5678│ ├────┼────┤ │中国  │  中国│ └────┴────┘
Correct fix would expect some determination mechanism how wide is a uni-char in some font or using wcwidth, which tcl does not have at all (possibly tk has something like that).
A workaround would be to replace any Chinese/Japanese/WhateverDoubleWidth chars with 2 chars by calculating its length, e. g. any wide chars from east-asian-width, considering ambiguous characters, as well as the unicode variation selector (U+FE0F).
Simplified "workaround" to illustrate the possible approach - #18
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.


Support new lines in merge text

A merge text might have new lines and such should be preserved.

Great addition, thank you for the contribution!


[Nox.Lib] Bug in Nox.Lib Postgresql Library - Datetime offset cannot be stored

After the bug is fixed, run Nox Init to test.

So we need to setup a PostgresSQL and test its options and validate that is working as expected


initialize action CI

fixes #4
using suittest will run etcd and apiserver in kubebuilder which is almost like an e2e environment.

lgtm


Support MS SQL Server

It's an common DB in the enterprise and now also available for Linux.

Completely agree, it just needs someone to step up and implement it. :)

Well, I'm interested. Although I probably would need some guidance.

Of course! I’m happy to offer guidance. @mclark4386 implemented cockroach support recently. I’m sure he’ll be happy to offer some guidance along the way too!

@markbates  So I took a glance at the cockroach commits and if I understand correctly the main task would be to implement sqlserver.go and fizz/translators/sqlserver.go similar to mysql/postgres/cockroach. Is that right?

That’s the basics of it, yep. I would pick the implementation that’s closest to MS, I’ve never used it, and use that as a starting point. Rename a few things, point them at the MS DB and see what the tests yell at you about.

@markbates  hmm... travis doesn't support ms sql server. would you consider to add appveyor integration?
https://www.appveyor.com/

Sure. We use it for Buffalo too. Travis also supports docker, if that helps.

Mark Bates
On Mar 22, 2018, 4:59 PM -0400, marpio<EMAIL_ADDRESS>wrote:

@markbates hmm... travis doesn't support ms sql server. would you consider to add appveyor integration?
https://www.appveyor.com/
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

@markbates true - i've found this: https://github.com/aspnet/EntityFrameworkCore/pull/7842/files
I'll go with travis then.

@marpio happy to help if you have questions! Sounds like you have a good start going.

@markbates short question - what is the purpose of the {db}_meta.go files in the fiz/translators package? Why doesn't postgres need it?

Some of the translators, like SQLite (for example), need additional meta information about the table(s), indexes, etc… to create the proper sql for things such as renaming a column.
Postgres is a nice db and things just work. :)

@markbates thanks

I'm having some difficulties - sqlx doesn't support the sqlserver parameter syntax so:
// this doesn't work
tx.MustExec("INSERT INTO person (first_name, last_name, email) VALUES ($1, $2, $3)", "Jason", "Moiron"<EMAIL_ADDRESS>// this works
tx.MustExec("INSERT INTO person (first_name, last_name, email) VALUES (@p1, @p2, @p3)", "Jason", "Moiron"<EMAIL_ADDRESS>
// but this doesn't
tx.NamedExec("INSERT INTO person (first_name, last_name, email) VALUES (:first_name, :last_name, :email)", &Person{"Jane", "Citizen"<EMAIL_ADDRESS>
// neither does this
tx.NamedExec("INSERT INTO person (first_name, last_name, email) VALUES (@first_name, @last_name, @email)", &Person{"Jane", "Citizen"<EMAIL_ADDRESS>

there is this issue jmoiron/sqlx#374 regarding this problem but it doesn't seem to be active.
The second problem is that sqlserver doesn't support the usual LIMIT and OFFSET syntax so i would need to somehow override the buildPaginationClauses function...
Any ideas how this could be solved?

Waiting for jmoiron/sqlx#406

@marpio jmoiron/sqlx#406 was merged, and I just merged your PR in fizz. :)

Awesome @stanislas-m I will need some time to make it work since a lot changed in buffalo/pop since March.

No problem, take your time!

@marpio any update on this?

@Norris1z
I'm quite busy these days and not sure when I get to it. Probably in 2-3 months. Sorry for that. Feel free to take this one if you're interested!

I'm interesting in this. I'm a little green when it comes to Go, and would want to chat about what the scope of work looks like before volunteering to take this on. Gopher slack the best place for that?

@andyedison Sure, feel free to join the buffalo-dev channel on Gopher slack. :)


Dismantle Mux expression / Ternary operator in dpdk

This patch changes
Expression like this
z = condition ? x : y;
to
temp = y;
if (condition)
temp =  x;
z = temp;

Added testcase to cover more visitors i.e. function, control, apply, action etc..
Regarding reducing scope of the temporary declaration to location where it's used, it does not of any help in case of dpdk because all the local variables from any block collected into a structure called metadata.

Updated test

@psivanup As in Earlier comments writing directly ternary in p4 gets translated by frontend itself. So not effective here.
Test case has only those expression  which makes LowerExpressions to emit Ternary Operator.


Downloaded songs seems to have an extra second added that isn't from the original Youtube video

So, I had downloaded a song which is on Spotify 1:30 music, and on Youtube, it's also 1:30 (1:29 because Youtube creates a cutoff) but when I downloaded it, I received a file that has 1:34 on metadata and 1:32 in actual playback. Is this a result of something during the downloading process?

Well, yes, ffmpeg's audio normalization clips out the last 2-3 seconds of songs at random. So, we append a full 3 seconds of silence just in case. The metadata and playback not matching is due to the fine details of the encoding. The song is encoded to mp3 at 48kHz 128kbps to retain maximal audio quality. 48Khz and 128kbps don't exactly always workout well in ffmpeg (due to algorithmic optimizations), so that the difference b/w metadata and playback.
For any song, the difference should be minor - on the range of 1 to 3 seconds. If it's more, that's a glitch.


Show missing linter warnings

Currently, warnings that have severity "warning" are only shown if there
are also warnings with severity "error". This patch allows the linter to
always show warnings even if none of them have severity "error".

Superseded by #49 (it has a better solution than this PR).

I feel ashamed. It's certainly needs a lot of courage and dedication to revoke your own code in favor of someone else's one. Even if it's a one-line patch. Thank you, @nwoltman!


GEODE-7851: use the latest version of nimbus-jose-jwt.jar

Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:

[ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

[ ] Has your PR been rebased against the latest commit within the target branch (typically develop)?

[ ] Is your initial contribution a single, squashed commit?

[ ] Does gradlew build run cleanly?

[ ] Have you written or updated unit tests to verify your changes?

[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

Note:
Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to<EMAIL_ADDRESS>

I'm wondering if we may have to wait until the dependencies are updated in the spring libraries that use this jar.

I'm wondering if we may have to wait until the dependencies are updated in the spring libraries that use this jar.

we don't have to. Gradle will substitute the spring dependency with the latest.


translating into portuguese

hello, again.
not an issue, but an offer.
do you want me to translate the program into portuguese?
my guild members don't speak english so well, so I wanted to help them out without the need to teach each one of them.
if you are interested, chat me up!
thanks again.
bye

we have been discussing this, get up on  #97

oh. nevermind then :P


Please readd tests for windows and mac

Executing standard T´testing at ALL supported platforms is mandatory. Please reactivate the test.

I reactivated the tests for all platforms. But actually the windows tests do not work. What shall I do?
https://github.com/tp1de/ioBroker.ems-esp/actions/runs/8721074711/job/23924010766

Please check forum and/or telegram channels for news regularly.
There was a problem caused by changes done by Microsoft. Please update @iobroker/testing to 4.1.3. This should do the trick.

@mcm1957  Thanks for input ... it works now.
But I have to admit that I am starting to get annoyed about the ioBroker adapter development environment.
For non-IT people it is too difficult to follow all necessary changes which has to be observed. (or I am getting too old now)
There should be one web-site where all these prerequisite can be followed easily to minimize the efforts.

Maybe you should consider subscribing to tegram (or discord) developer channel if not yet done.
Invites available at www.iobroker.dev.


Investigate how to handle SVGs from Fotoware

The icons and illustrations archive will be migrated from Brandmaster to Fotoware. According to Fotoware, their Export feature does not support SVG files which means our current asset-source integration is incompatible with this.
We need to figure out how to handle SVG files and other files that potentially do not work with Fotoware's export feature.
The main challenges we have with integrating Fotoware as asset-source in Sanity is the following:

Fotoware does not have CORS enabled
All Fotoware API requests require an access key
The Select Widget returns a so called Asset representation but not the actual asset or link to it that we can use.
API requests to Fotoware have to be made from the server (or via a proxy server)
Sanity is a fully client side JS application, we do not have a backend to handle an integration with other services

We currently use Azure Functions to act as a proxy for interacting with Fotoware where we can't do so from the client (authentication, CORS issue with fetching images) - we may be able to use that same approach for this.
The way I see it is that we need to register an integration that uses the API; we can still use the Select widget, but then when we get the "asset representation" we send that to a custom Azure Function where we make a call to the API to fetch the image (I'm assuming that will be possible). That way we can potentially also avoid the solution with converting the image to base64.

Plan to not use export widget as this only supports images.
In update we will use other way after a discussion with Fotoware


Quick setting up for development environment

Create something similar to this https://github.com/reddit/reddit/wiki/reddit-install-script-for-Ubuntu for quick setting up development environment for LogList.

@rexim what you think? Is it still valid?


wrong response

I am new for llama3. Using Ollama + Docker + Open-webui for three days.
Suddently this morning all of llama3 response on open-webui always with {} when I input anything via open-webui but
normal on Ollama native mode. I tried to re-install everything but still got same issue.
Anyone can help ?

Make sure this is set to Default and not JSON:

yes, thank you. My mistake. Solved.


[Feedback] add additional comments at the top of generated files

Feedback
When users are discovering generated files, they miss the context, purpose, and relations of these files right away. They are forced to google/go to documentation and lose the flow.
Possible solution
To help with that add brief comments at the top of each generated file. It will describe the purpose and relations with other files (where is it in the Superface), link to the glossary, and indicate usage (profile to change inputs/outputs; map to debug integration; ..).

This might be complicated for provider definition (JSON) but otherwise should be ok (Engine adding Comlink/JS comment on top of each generated file)


chore: remove what's new functionality

Description of Change

remove code related to announcements
change AppUpdateInfoBar to point to GitHub changelog instead of what's new page
remove what's new menu entry
disable react/jsx-one-expression-per-line conflicting with prettier

Motivation and Context
Closes https://github.com/getferdi/ferdi/issues/1822
We decided to remove the What's new menu entry, since it essentially does the same thing as displaying the changelog in GitHub. This is handled by the "Changelog" menu entry in Ferdi.
I didn't remove the translation messages in each language, since this would cause a lot of file changes.
Checklist

[x] My pull request is properly named
[x] The changes respect the code style of the project (npm run prepare-code)
[x] npm test passes
[x] I tested/previewed my changes locally

The only reason for keeping What's new and removing Changelog would be that we could reuse the i18n translations as-is.


🐛 [firebase_dynamic_links] Unpredictable behaviour of dynamic link

Bug report
Describe the bug
I am building an app in VScode using flutter. I am trying to add an email link sign in in my app. In android, the dynamic link received in the mail sometimes redirects to the app correctly and other times it shows a security error "Deceptive site ahead". If I proceed to visit the unsafe site, then the website is redirecting me to the Playstore, and as my app is not on the Playstore yet, it shows "The requested url was not found." I am using
firebase_core: ^2.9.0
firebase_auth: ^4.4.0
firebase_dynamic_links: ^5.1.0
Steps to reproduce
Steps to reproduce the behavior:

Set up email link sign in
Handle dynamic link inside the app
try to click on email link
Error: Deceptive site ahead

Expected behavior
The dynamic link clicked should always redirect to the app.

Additional context
Add any other context about the problem here.

Flutter doctor
Run flutter doctor and paste the output below:
Click To Expand
PASTE OUTPUT INSIDE HERE

Flutter dependencies
Run flutter pub deps -- --style=compact and paste the output below:
Click To Expand
Dart SDK 3.0.0-266.0.dev
Flutter SDK 3.8.0-16.0.pre.38
kinesis_locate 1.0.0+1
dependencies:

async 2.10.0 [collection meta]
cupertino_icons 1.0.5
dio 5.1.0 [http_parser meta path]
email_validator 2.1.17
firebase_auth 4.4.0 [firebase_auth_platform_interface firebase_auth_web firebase_core firebase_core_platform_interface flutter meta]
firebase_core 2.9.0 [firebase_core_platform_interface firebase_core_web flutter meta]
firebase_dynamic_links 5.1.0 [firebase_core firebase_core_platform_interface firebase_dynamic_links_platform_interface flutter meta plugin_platform_interface]
flutter 0.0.0 [characters collection js material_color_utilities meta vector_math sky_engine]
flutter_bloc 8.1.2 [flutter bloc provider]
google_fonts 4.0.3 [flutter http path_provider crypto]
material_design_icons_flutter 6.0.7096 [flutter]

dev dependencies:

flutter_launcher_icons 0.13.0 [args checked_yaml cli_util image json_annotation path yaml]
flutter_lints 2.0.1 [lints]
flutter_test 0.0.0 [flutter test_api path fake_async clock stack_trace vector_math async boolean_selector characters collection js matcher material_color_utilities meta source_span stream_channel string_scanner term_glyph]

transitive dependencies:

_flutterfire_internals 1.1.0 [collection firebase_core firebase_core_platform_interface flutter meta]
archive 3.3.7 [crypto path pointycastle]
args 2.4.0
bloc 8.1.1 [meta]
boolean_selector 2.1.1 [source_span string_scanner]
characters 1.3.0
checked_yaml 2.0.2 [json_annotation source_span yaml]
cli_util 0.4.0 [meta path]
clock 1.1.1
collection 1.17.1
convert 3.1.1 [typed_data]
crypto 3.0.2 [typed_data]
fake_async 1.3.1 [clock collection]
ffi 2.0.1
file 6.1.4 [meta path]
firebase_auth_platform_interface 6.13.0 [_flutterfire_internals collection firebase_core flutter meta plugin_platform_interface]
firebase_auth_web 5.3.0 [firebase_auth_platform_interface firebase_core firebase_core_web flutter flutter_web_plugins http_parser intl js meta]
firebase_core_platform_interface 4.6.0 [collection flutter flutter_test meta plugin_platform_interface]
firebase_core_web 2.3.0 [firebase_core_platform_interface flutter flutter_web_plugins js meta]
firebase_dynamic_links_platform_interface 0.2.4 [_flutterfire_internals firebase_core flutter meta plugin_platform_interface]
flutter_web_plugins 0.0.0 [flutter js characters collection material_color_utilities meta vector_math]
http 0.13.5 [async http_parser meta path]
http_parser 4.0.2 [collection source_span string_scanner typed_data]
image 4.0.15 [archive meta xml]
intl 0.17.0 [clock path]
js 0.6.7 [meta]
json_annotation 4.8.0 [meta]
lints 2.0.1
matcher 0.12.14 [meta stack_trace]
material_color_utilities 0.2.0
meta 1.9.0
nested 1.0.0 [flutter]
path 1.8.3
path_provider 2.0.13 [flutter path_provider_android path_provider_foundation path_provider_linux path_provider_platform_interface path_provider_windows]
path_provider_android 2.0.24 [flutter path_provider_platform_interface]
path_provider_foundation 2.1.3 [flutter path_provider_platform_interface]
path_provider_linux 2.1.10 [ffi flutter path path_provider_platform_interface xdg_directories]
path_provider_platform_interface 2.0.6 [flutter platform plugin_platform_interface]
path_provider_windows 2.1.5 [ffi flutter path path_provider_platform_interface win32]
petitparser 5.3.0 [meta]
platform 3.1.0
plugin_platform_interface 2.1.4 [meta]
pointycastle 3.7.2 [collection convert js]
process 4.2.4 [file path platform]
provider 6.0.5 [collection flutter nested]
sky_engine 0.0.99
source_span 1.9.1 [collection path term_glyph]
stack_trace 1.11.0 [path]
stream_channel 2.1.1 [async]
string_scanner 1.2.0 [source_span]
term_glyph 1.2.1
test_api 0.4.18 [async boolean_selector collection meta source_span stack_trace stream_channel string_scanner term_glyph matcher]
typed_data 1.3.1 [collection]
vector_math 2.1.4
win32 3.1.3 [ffi]
xdg_directories 1.0.0 [meta path process]
xml 6.2.2 [collection meta petitparser]
yaml 3.1.1 [collection source_span string_scanner]

Thanks for the report @sneha-tandri
Looking at the error you are receiving Deceptive site ahead, it doesn't seem to be a plugin or caused by it, but could be due to the setup / config you have in place. Take a look at this SO link and see if it helps in your case.
I am going ahead and closing, as this doesn't seem to be actionable from plugin side. If you disagree, write in comments and I'll reopen it.

The behaviour is unpredictable, it works sometimes and doesn't work other times. This unpredictability makes me think the problem is not in the setup. Apart from this, while trying to send an email link, I keep getting "Error sending email verification [firebase_auth/too-many-requests] We have blocked all requests from this device due to unusual activity. Try again later." even though I haven't requested a lot of times.

Hi! So the issue came up for a bit, and then the link started behaving as expected again. But today when I tried signing in again, it is not working yet again. I do not know whet is causing this unpredictable behaviour, as if is due to the setup that I have, it should be throwing this message "Deceptive site ahead" every single time. Please help me out on this.


Clients List search bar changes

:nut_and_bolt: Description: What code changed, and why?
Need to add the search bar for Clients List
:chains: Related Resources
#4669
:+1: Definition of Done
I have added the search bar for Clients list.
:athletic_shoe: How to Build and Test the Change
STEP 1
inside the hab studio
[default:/src:0]# build components/automate-ui-devproxy/
[default:/src:0]# start_automate_ui_background
[default:/src:0]# start_all_services
STEP 2
open new window
go to automate UI path
$ cd components/automate-ui
and run the command
npm run serve:hab
To add data https://github.com/chef/automate/blob/master/dev-docs/adding-data/adding_test_data.md#adding-data-to-infra-views
Go to Infrastructure tab >> Chef Servers it's under Chef-Server feature flag  >> click to any server >> see the list of org's >> click to any org >> on org details page you can see the multiple tabs >> click to Clients tabs >> you can see the list of Clients
:white_check_mark: Checklist

[ ] I have read the CONTRIBUTING document.
[ ] Tests added/updated?
[ ] Docs added/updated?
[ ] All commits have been signed-off for the Developer Certification of Origin.

:camera: Screenshots, if applicable
Client search

Client search Value (aws)

Client no data in search

we need to create our branch build for the local development, which is not merged, for this we are using that command.


Last request mode

Is it possible to add a togglable mode during which the newest request is automatically selected?
Sometimes one needs to inspect one request multiple times in different circumstances.
That toggler would help a ton.
In my opinion the best place to put the toggler icon would be next  to the 'Clear' icon

or somewhere in the settings modal

In my opinion, there should be a "Sort" button besides the "FIlter" text bar, which could be a toggle type


chore: add some initial basic tests for config/creds ini interactions

This commit just adds some early unit tests for the ini_config
module.  A minor refactor was required for some separation of
concerns so that the tests could be written without writing
files to disk.
In subsequent commits the functions in the ini_config will be
refactored further to make them more testable, but this commit
gets the tests in place so that we can hopefully ensure that
we don't break any functionality in the subsequent refactor.
The end goal here is to fix some issues that users reported
where empty tokens don't get updated properly, or leading/trailing
whitespace entered in the CLI input cause corruption to the
files; this will be addressed in later commits once the code
can be tested more easily.

For best results you will want to review this with whitespace changes hidden, and you will need to expand the "large diffs are hidden" on the configure_cli.rs file because it is where most of the important changes are :)


object-store: Add Content-MD5 or checksum header for using an Object Locked S3

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
I am trying to use object-store crate with AWS S3 where Object lock is enabled with versioning and some retention period. When i am trying to put object it is failing with following error
... <Error>InvalidRequest<Message>Content-MD5 OR x-amz-checksum- HTTP header is required for Put Object requests with Object Lock parameters</Message> ...

Describe the solution you'd like
A ClientOptions method like with_content_md5 or with_checksum_header that will calculate and attach appropriate checksum header ( before sending Bytes ) so that PUT request works.
Describe alternatives you've considered
None
Additional context
This is minimal example I used for testing this out
#[tokio::main]
async fn main() {
    let client = AmazonS3Builder::new()
        .with_endpoint("https://s3.us-east-1.amazonaws.com")
        .with_access_key_id(".....")
        .with_secret_access_key(".....")
        .with_bucket_name("....")
        .with_region("us-east-1")
        .build()
        .unwrap();

    client
        .put(
            &Path::from("foo"),
            Bytes::from_static(b"content of file"),
        )
        .await
        .unwrap();
}

second notes section in AWS docs only talks about Content-MD5

Makes sense to me 👍

I was considering how to go about fixing this. The main objective is to make the request work with object locking, so I tried sending the x-amz-checksum-sha256 header, and it worked. For x-amz-checksum-sha256, the hash digest is encoded with base64. This can be quickly added, but internally, it seems that the object_store already calculates the sha256 digest for the request body (which is later set as x-amz-content-sha256 and encoded using hex-encode).
I have two things in mind:

Should Content-MD5 be added as an option just for the sake of support, or should x-amz-checksum- be favored ?
reference: https://docs.aws.amazon.com/AmazonS3/latest/userguide/checking-object-integrity.html
If so, can the same digest be used for x-amz-content-sha256 and x-amz-checksum-sha256? ( Still testing this out for multipart upload )

Should Content-MD5 be added as an option just for the sake of support,

I don't feel strongly about this, provided it is configurable. There doesn't seem to be a huge amount of standardisation across the stores w.r.t how checksums are handled, and so it is probably we will end up with store specific logic for this.

If so, can the same digest be used for x-amz-content-sha256 and x-amz-checksum-sha256

I believe so, but should probably verify this

For checksum i think something like with_checksum_algorithm(checksum::Sha256) in AmazonS3Builder makes sense. This will set x-amz-checksum- header. There are 4 of algorithms supported by s3 for integrity check CRC32, CRC32C, SHA-1, SHA-256. To use any of these one first will add them as a feature in their Cargo.toml, only then they can specify this option in the builder.


printing RRs with no rdata still prints the trailing tab

commented in update_test.go, I've added this:
	// This test function isn't a Example function because we print these RR with tabs at the
	// end and the Example function trim these, thus they never match.
	// TODO(miek): don't print these tabs and make this into an Example function.

kind of ugly, we should suppress that <tab> char when there is no rdata.

The annoying thing is that right now I can trim the excess white space in the update_test.go file because it will break the test. The fix in it self is not that hard, but touches a lot of lines of code.


MockServer 3.10.1 not available as Homebrew package

Can you please add the newest MockServer as Homebrew package? There are some differences I'm experiencing comparing to the runnable JAR.

I have now created the following pull request for homebrew, once the build has run and the PR has been accepted the new version will be available via homebrew.  From experience this can take up to two weeks.  https://github.com/Homebrew/homebrew/pull/49818
I am going to close this ticket, please refer to the other ticket for progress on when the new version will be available.

The homebrew PR has now been merged so the latest version should now be available

Yes it is, thanks!


C++ namespace support for Codon import statement

Attempts to import C++ functions, nested in C++ namespaces, using Codon have been unsuccessful. Wasn't able to find examples or documentation for a solution.
Example of the situation...
C++ code
namespace example {

    void hello() { ... }

}

Codon import of example::hello using the "C" module
from C import example.hello()

Would like to be able to handle deeper C++ namespace nesting. Hoping the example makes for a good starting point. Maybe a CPP or CXX namespace is required to handle name mangling? Thanks in advance for the time and attention!

Hi @ct-clmsn -- currently Codon needs to use C ABI functions (i.e. extern "C"), so the recommended approach for C++ is to wrap the functions you want to call within Codon in an extern "C" function.
We are planning to support direct C++ as well, although it isn't trivial as you need to integrate a C++ frontend like Clang.