Swift 5 update

i have a branch working here named swift5: https://github.com/prolificinteractive/Marker/tree/swift5


Over-eager inference with ThisType & homomorphic mapped types

@ahejlsberg and I have spoken about this a few times offline, but @bterlson was asking if we had an issue tracking this problem.
We've been working with Vue's API to try to give users a better experience. Unfortunately, this is still a very easy gotcha to fall into.
As a boiled down case, try running the following example with noImplicitAny and noImplicitThis:
type ComputedOf<T> = {
    [K in keyof T]: () => T[K]
}

declare function foo<P, C>(options: {
    props: P,
    computed: ComputedOf<C>
} & ThisType<P & C>): void;

foo({
    props: { x: 10, y: 20 },
    computed: {
        bar() {
            return this.x;
        }
    }
});

Here, you'll get a problem on bar and on the x in this.x, you'll get:

'bar' implicitly has return type 'any' because it does not have a return type annotation and is referenced directly or indirectly in one of its return expressions.

Property 'x' does not exist on type '{ bar(): any; }'.

The problem surfaces as soon as any value on this is used in producing the return value of a computed method.
I forget exactly why this occurs, but it has to do with circularities in trying to draw inferences to C which is wrapped in a homomorphic mapped type. @ahejlsberg can fill me in here.
The solution for users is to add a return type annotation to bar which is not obvious, but it prevents type argument inference from type-checking the internals of the method, and avoids the circularity problem. Ideally, users should not have to think about this.

I just spent a few hours figuring out why inference was failing sometimes for one of my generic functions, finally narrowing it down to whether or not this.someProp was referenced in a return expression of a method inside an object. I suspected something strange going on with ThisType and that lead me to this issue. Thanks @DanielRosenwasser for the workaround (adding a return annotation to the method).
I agree that it is not at all obvious. It's very surprising to see infered types totally change depending what a method returns, with no obvious causal link for the changed inference.

This works now


Using a MemCard Pro as an SD card adapter

Is this possible? I realize this might be more expensive overall, but if there is a possibility of only needing the Pico and a means of reading the card (MemCard Pro), and maybe leaving the optical drive functional, that would be awesome.
I love the nature of the PicoBoot mod for the GameCube, which leaves the optical drive functional if needed but also gives the option to boot games out of an SD card.
Amazing work so far, by the way. I'm very excited about the future of this project!

From what I understand, it shouldn't be possible in the current state of things.
The picostation intercepts CD related commands and replies to it, but it doesn't see anything else

From what I understand, it shouldn't be possible in the current state of things.
The picostation intercepts CD related commands and replies to it, but it doesn't see anything else


Rethink the Restore button on the Unlock screen

User feedback from @crwatkins has indicated that the Restore button on the Unlock screen is confusing. Perhaps a better approach would be to have two buttons: "Create..." and "Restore..." which both target the welcome wizard but use a different starting panel view.
This would remove any confusion in the mind of the user about creating a new wallet.

In discussions we agreed that better text than what we have at the moment is:

I have forgotten my password
I want to restore a wallet
I want to use an existing wallet

Updated in line with this post.
There is now a Create button on the Credentials 'Enter password' screen that takes the user to the 'Create wallet preparation' screen. I have adjusted the 'Select option' lists to remove the previous create option.
Tried it out with various configurations, cold start, warm start, restore, use existing wallet etc and the screen flow what what you'd expect. Probably worth playing with it for a bit to see if I have missed anything though.
I've pushed all the changes so you can review the functionality but still have the FEST tests to do yet.
Will also post some screenshots later

The handover between the credentials wizard and the welcome wizard isn't quite working correctly leading to problems with events getting sent to two wizards and causing strange state changes as a result (see #534).
I'll incorporate your updates as I progress with that issue.

I've got the FEST tests running cleanly now.
Also added a 'Create wallet' to the Select wallet option screen only on a cold start (where the user won't have a wallet and most likely will want to create one).
Awaiting review and closing.

Screenshots:

Updated the text on the 'Enter password' screen to reflect that there are now two buttons:

Works fine.
One nit: there is no way back to the Unlock screen after starting the Create process without an Exit. It remains possible through the Restore button. Perhaps the Previous button on the wallet preparation screen should be re-instated with a return to the display of the options containing "use existing wallet" presented. It's a bit incongruous, but it gives an escape from accidentally clicking Create.

Added Previous button that navigates to the 'Select option' screen.
Also checked the Trezor create wallet preparation screen has a Previous button.
Awaiting review and closing

Verified working (soft and hard wallet)
Closing.


python312Packages.linknlink: 0.2.1 -> 0.2.2

Diff: https://github.com/xuanxuan000/python-linknlink/compare/refs/tags/0.2.1...0.2.2
Changelog: https://github.com/xuanxuan000/python-linknlink/releases/tag/0.2.2
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 308463 run on x86_64-linux 1

4 packages built:

python311Packages.linknlink
python311Packages.linknlink.dist
python312Packages.linknlink
python312Packages.linknlink.dist


🪲[Bug]: Become volunteer needs to be more visible

Describe the bug
Volunteer button not visible properly
To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots

Desktop (please complete the following information):

OS: [e.g. iOS]
Browser [e.g. chrome, safari]
Version [e.g. 22]

Smartphone (please complete the following information):

Device: [e.g. iPhone6]
OS: [e.g. iOS8.1]
Browser [e.g. stock browser, safari]
Version [e.g. 22]

Additional context
Add any other context about the problem here.

Hello @akshitagupta15june please assign this issue to me under gssoc 24


"Recent activity" on dashboard and project overview say they are in UTC time when they are not

Steps:

Do some action on the OSF (i.e. create a project)
Go to the dashboard page's watchlist
Check the timestamp on the log

Expected:
Since there's a sentence at the top saying all times are displayed in UTC offset, I expected the timestamps to be UTC time.
Actual:
The timestamps are localized!

And the tooltips are UTC:

The sentence "All times displayed at -0400 UTC offset" should be taken out since it's no longer true!

From what I am understanding, UTC offset doesn't mean UTC time. It means the difference between your local time zone and the UTC time. I think the current behavior is correct. Close for now.


Display nodes with multiple self-linking links properly

Don't let the self-linking links stack directly on top of one another.

They also need to be drawn above the node layer.


Deleting topics with items logs exception in browser console

If a topic with x info items and y action items will be deleted then there will be (x+2y) exceptions displayed in the browsers console.

Cannot reproduce this bug anymore. So I will close this issue.


Test and Document Atomic Swap with UTXO Support

done here https://github.com/CounterpartyXCP/counterparty-core/pull/2203


Deb packaging

We should get on with Raspbian packaging fairly quickly. I want this on the image for the next Birmingham picademy, and I'd like to include instructions on the worksheet for teachers to install this on any other Pi's they have with minimal hassle. I can handle this if you wish.

Yes please - go ahead

Argh ... spidev and w1thermsensor aren't packaged for Raspbian. I'll have to make those local imports and come up with some "friendly" error telling the user how to install them in the event they're not present

(or package them myself, but I really don't have the time to devote to that)

Hmm. Maybe we should look at packaging them. I'll ask when I'm back in the office.

@bennuttall Is this the issue why you need the w1thermsensor module as package in the repos?
I'll definitely gonna work on it ...

Yes - thanks!

Quick question before I redo the PR for deb packaging - I'm assuming the w1thermsensor package is going to be packaged as python-w1thermsensor and python3-w1thermsensor, and that spidev will be packaged as python-spidev and python3-spidev in accordance with the usual Debian convention? Just need to check for the deps in the control file

I would think so. @XECDesign?

Yeah, that's right.

Yes - for w1thermsensor the same ..

Good stuff - I'll bung in the PR in a bit

Reopening until the package is released!

Heh - good point :)

Use the following commands to create the python 2 and python 3 packages:
For python 2:
python setup.py --command-packages=stdeb.command bdist_deb

For python 3:
python3 setup.py --command-packages=stdeb.command bdist_deb

Do you need something else in order to include it to the repositories?

The machinery for making the deb package should all be in there after PR #54, we're just fixing a few other things before the next release at the moment. The machinery is based on stdeb's output but with a few tweaks that I've built up over the years to make certain things easier (most of it's in the Makefile and handles things like launching dch to update the changelog properly and in the fuller versions that I use on picamera and picraft, building the separate docs package automatically, integrating it with docs-base, and auto-uploading everything to PyPI and the Raspbian maintainer via dput)

I didn't use this for the 0.9 release as I needed to get it out - but will try by the next release.

No prob - let me know if you have any issues. I can always run it if you like as I'm set up for signing packages and Serge's got my public keys on the Raspbian dput servers (which is why I can automate the whole thing from package building to uploading to PyPI and Raspbian)

Will the python-w1thermsensor, python3-w1thermsensor, python-spidev and python3-spidev packages also be added to the Wheezy repositories? Or will they remain Jessie-only?

That would be the "proper" solution here (and I suspect the easiest though
I'm not au fait with the particulars); I haven't heard the verdict on that
yet though.
On 4 Nov 2015 12:53 a.m., "Andrew Scheller"<EMAIL_ADDRESS>wrote:

Will the python-w1thermsensor, python3-w1thermsensor, python-spidev and
python3-spidev packages also be added to the Wheezy repositories? Or will
they remain Jessie-only?
—
Reply to this email directly or view it on GitHub
https://github.com/RPi-Distro/python-gpiozero/issues/44#issuecomment-153536582
.

That would make things a lot easier. We do want people to upgrade to Jessie, but I don't like the idea of this just not working in Wheezy. It's possible to supply separate instructions for Wheezy but that gets complicated.
@XECDesign do you think we could make Wheezy packages for this and its dependencies?

If someone can confirm that they 'just work' as they are, I don't see why not.

They should! Send me some debs and I'll test them. Thanks

http://archive.raspberrypi.org/debian/pool/main/w/w1thermsensor/python-w1thermsensor_0.2.2-1_all.deb
http://archive.raspberrypi.org/debian/pool/main/w/w1thermsensor/python3-w1thermsensor_0.2.2-1_all.deb
http://archive.raspberrypi.org/debian/pool/main/s/spidev/python-spidev_2.0~git20150907_armhf.deb
http://archive.raspberrypi.org/debian/pool/main/s/spidev/python3-spidev_2.0~git20150907_armhf.deb

Right, packaging is tested and works nicely (on jessie - it'll work on wheezy as well when/if the spidev packages are back-ported there) so I'll close this for release


Memory leaks and slow content rendering in Android

We are dealing with a very heavy reflowable EPUB 3 file that features long chapter and high amount of images for each chapter. Some chapters account more than 300 images. When rendering the file in our Reader (Android Readium SDK), the content is hanging and sometime it's not even possible to open the chapter. We suspect the amount of images more than the length of the chapter to be causing this issue.
An extract of the file has been shared with Ric.

Not much we can do here in the short term, but keeping it alive as a test case.


DotNetCoreCLI publish timeout

I'm trying to publish a Blazor project with AOT [On] and I'm getting a timeout error. Below are the snapshots of task and result.

I just increased the timeout threshold to 90 min. However, this takes to long to publish though.

Now it's not timing out but rather going out of memory
(_WasmBuildNative target) ->
EXEC : LLVM error : out of memory [my project's path]
emcc : error : 'C:\hostedtoolcache\windows\dotnet\packs\Microsoft.NET.Runtime.Emscripten.2.0.12.Sdk.win-x64\6.0.0-preview.4.21220.1\tools\bin\wasm-ld.exe @C:\Users\VSSADM~1\AppData\Local\Temp\emscripten_c2hlbfgo.rsp' failed<PHONE_NUMBER>) [my project's path]
C:\hostedtoolcache\windows\dotnet\packs\Microsoft.NET.Runtime.WebAssembly.Sdk\6.0.0-preview.4.21253.7\Sdk\WasmApp.targets(504,5): error MSB3073: The command "emcc "@D:\a\1\s[my project's name]\Client\obj\Release\net6.0\wasm\emcc-link.rsp"" exited with code 1. [my project's path]

@chshrikh does the Release label means is to be fixed by Release?

Is there any update on this?

Is there any update?

@ashwinsangem

@ylr-research, can you pass the complete logs with the system.debug flag on.


chore: Review TODO notes

Describe the bug
See what the TODO notes are about, update their status or document as an issue if needed

[ ] agent/src/index.ts
[ ] packages/core/src/models.ts
[ ] packages/core/src/runtime.ts
[ ] packages/core/src/environment.ts
[ ] packages/core/src/memory.ts
[ ] packages/plugin-starknet/src/providers/trustScoreProvider.ts
[ ] packages/plugin-starknet/src/providers/token.ts
[ ] packages/plugin-starknet/src/actions/takeOrder.ts
[ ] packages/plugin-starknet/src/actions/transfer.ts
[ ] packages/plugin-starknet/readme.md
[ ] packages/adapter-sqlite/src/sqliteTables.ts
[ ] packages/adapter-sqljs/src/index.ts
[ ] packages/adapter-sqljs/src/sqliteTables.ts
[ ] packages/plugin-node/src/services/transcription.ts
[ ] packages/plugin-node/src/services/browser.ts
[ ] packages/client-twitter/src/search.ts
[ ] packages/client-twitter/src/base.ts
[ ] packages/plugin-solana/src/evaluators/trust.ts
[ ] packages/plugin-solana/src/providers/trustScoreProvider.ts
[ ] packages/plugin-solana/src/actions/swap.ts
[ ] packages/plugin-solana/src/actions/takeOrder.ts
[ ] packages/plugin-evm/src/actions/bridge.ts
[ ] packages/plugin-evm/src/actions/swap.ts
[ ] packages/plugin-flow/src/types/fcl.d.ts
[ ] packages/plugin-flow/src/actions/transfer.ts
[ ] packages/plugin-nft-generation/src/index.ts
[ ] packages/plugin-image-generation/src/index.ts
[ ] packages/client-farcaster/src/client.ts
[ ] packages/adapter-supabase/src/index.ts
[ ] packages/client-lens/src/actions.ts
[ ] packages/client-lens/src/client.ts
[ ] packages/client-lens/src/interactions.ts
[ ] packages/client-discord/src/utils.ts
[ ] packages/client-discord/src/attachments.ts
[ ] packages/client-discord/src/messages.ts
[ ] packages/client-discord/src/actions/chat_with_attachments.ts
[ ] packages/client-discord/src/actions/summarize_conversation.ts
[ ] packages/client-slack/src/events.ts

To Reproduce
To find the files to fix:
grep -ro "TODO" --exclude-dir=node_modules --exclude-dir=dist | uniq
Some examples grep -roP "TODO\s*.*" --exclude-dir=node_modules
agent/src/index.ts:TODO: Add Slack client to the list
packages/core/dist/index.js:TODO: check
packages/core/dist/index.js:TODO: ?download=true
packages/client-discord/src/utils.ts:TODO: clean this up
packages/client-discord/src/attachments.ts:TODO: clean this up
packages/client-discord/src/messages.ts:TODO: This is throwing an error but seems to work?
packages/client-discord/src/messages.ts:TODO: Move to attachments manager
packages/client-discord/src/actions/chat_with_attachments.ts:TODO: make this dynamic and generic
packages/client-discord/src/actions/summarize_conversation.ts:TODO: parse start and end into timestamps
packages/client-slack/src/events.ts:TODO: Implement reaction handling

Expected behavior
github issue or cleaning up the code
Screenshots

Additional context

Shall I work on this issue?


CFFL

CFFL

Linter check found the following problems:
The following problems have been found:
ERROR: /tmp/abs_596jhbkl5p/clone/recipe/meta.yaml:16: pip_install_args: pip install should be run with --no-deps.
ERROR: /tmp/abs_596jhbkl5p/clone/recipe/meta.yaml:23: host_section_needs_exact_pinnings: Packages in host must have exact version pinnings, except python build tools.
ERROR: /tmp/abs_596jhbkl5p/clone/recipe/meta.yaml:23: missing_wheel: For pypi packages, wheel should be present in the host section
ERROR: /tmp/abs_596jhbkl5p/clone/recipe/meta.yaml:48: http_url: http://multiset.readthedocs.io is not https
Errors were found


Fix the n-queens benchmark

Will segmentation fault on line 19. The r variable has somehow been freed

Fixed


Removed kOutput variable which was not used

tensorflow/lite/kernels/expand_dims.cc:30:15: warning: unused variable 'kOutput' [-Wunused-const-variable]
constexpr int kOutput = 0;

Nagging Reviewer @aselle: You have been added as a reviewer to this pull request. Please add your review or reassign. It has been 14 days with no activity and the awaiting review label has been applied.

Nagging Reviewer @aselle: You have been added as a reviewer to this pull request. Please add your review or reassign. It has been 30 days with no activity and the awaiting review label has been applied.

Nagging Reviewer @aselle: You have been added as a reviewer to this pull request. Please add your review or reassign. It has been 44 days with no activity and the awaiting review label has been applied.

Nagging Reviewer @aselle: You have been added as a reviewer to this pull request. Please add your review or reassign. It has been 62 days with no activity and the awaiting review label has been applied.

Nagging Reviewer @aselle: You have been added as a reviewer to this pull request. Please add your review or reassign. It has been 77 days with no activity and the awaiting review label has been applied.

@aselle Could you PTAL and approve

@gbaned I'm not an owner of this code -- I'm just in the history because I moved it. Can you find a more fitting reviewer for TF lite, please?


Add native platform

Hi there, as discussed with @BennyHill I would like to have a look at this over the coming weekend.

:+1:


Probleme to deploy my project and get the code files

Describe the bug
I can not export or deploy my project anywhere, even to share to my dev
Link to the Bolt URL that caused the error
https://bolt.new/~/sb1-x3iazw
Steps to reproduce
I click on deploy only, thne it showing the error message.
Expected behavior
I would like to get the files or find a way to share the acces to the code that bolt developp concerning my project to my dev to link the app with my actual dashboard.
Screen Recording / Screenshot
No response
Platform
Browser name = Chrome
Full version = <IP_ADDRESS>
Major version = 130
navigator.appName = Netscape
navigator.userAgent = Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/<IP_ADDRESS> Safari/537.36
performance.memory = {
  "totalJSHeapSize": 242137810,
  "usedJSHeapSize": 225188690,
  "jsHeapSizeLimit":<PHONE_NUMBER>
}
Username = Quentup
Chat ID = 63f6c432c0d1

Additional context
Error:
We ran into a Netlify rate limit error, please try again in a bit.

@Quentinup this issue is being tracked in #1037


Nuxt DevTools integration

Integrate DevTools to incorporate incoming and outgoing data and requests, ability to send custom queries; also potentially embedding Surrealist or atleast a fraction of Surrealists features i.e. view tables, data etc.

Hi @itsezc
Ideally I would have liked to add Surrealist itself into the devtools, but unfortunately it is not possible to load it within an iframe.
I did already mention this in their open issue about official dockerfile support. Once they do add it I do plan to host a Surrealist instance just for this module.
Ideally yes, creating a custom devtools integration would be the better route, allowing me to further integrate it with the module itself. But it is something that I cannot currently do because of lack of time and lack of experience with devtools (although I don't imagine being that much of a deal).


Improvements to worker regions

Contributions: We are not currently taking public contributions - see our contributions policy. However, we are accepting issues and we do want your feedback.

Description
Convert worker regions from planes to cuboids.  Also make them togglable in the settings.
Release note
Will add...
Tests
We have been using these changes on NWX with different vertical scales to visualize the worker boundaries (100 may be a good starting point for levels with varied terrain, but i've left the default at 1 here so there is a smaller visual delta in the test levels) in multiworker deployments.
STRONGLY SUGGESTED: How can this be verified by QA?
Documentation
Will add release note
Primary reviewers
@alastairdglennie

Longer term would be nicer to keep them around if the debugger is enabled, and just hide/show them as necessary, but this will do for a start.

needs changelog conflict resolution


Failed to load the JS script of the agent

Hello. We're constantly getting this error in Android Build
Error: Failed to load the JS script of the agent
We're on versions "@fingerprintjs/fingerprintjs-pro-spa": "^1.0.2"
Note* No VPN no Ad Block.

This error occurs when I call it's Init Function
import { FpjsClient } from '@fingerprintjs/fingerprintjs-pro-spa';
const fpjsClient = new FpjsClient({
loadOptions: {
apiKey: "your_Api_key" // insert your public api key from the dashboard here
}
});
const visitorData = fpjsClient.init().then(() => {
console.log("Ok ");
}).catch((error)=>{
console.log("Error :: "+ error);
});

Can you provide info about your browser? Version, operation system?
Also, is this link available from your network? https://fpnpmcdn.net/v3/<your_Api_key>/loader_v3.8.2.js

@ilfa No this Link is not available it say "path does not exist".
I'm using Android Mobile version 7.0.
and I'm not testing it on chrome or any browser. I created apk from cocosCreator

@RizwanAliGujjar have you inserted your public API key to the URL instead <your_Api_key> before testing?
Do you use cocosCreator because you are writing app with javascript? Because we have an Android agent that is more effective for Android apps.
Does cocosCreator allow to run code like document.createElement('script') and document.appendChild to manipulate the DOM and load additional scripts? If not, it is not compatible with using our JavaScript Agent

So problem is not on the network side.
I checked cocosCreator documentation and it said: "Plugins that rely on the DOM API will not be able to publish to the native platform"
Our JS Agent needs a browser DOM API for work.
I recommend you to use native agents for Android and for iOS
I found this example that says that it is possible.
We use the native agent approach in our Flutter and React Native SDKs.


add option to include all services in name table

Please provide a description of this PR:

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

/test all

@ramaraochavali: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
fae4ef3f60ca84fe5f46c0b4c75551bb9566d5b3
link
true
/test release-notes

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ramaraochavali: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
fae4ef3f60ca84fe5f46c0b4c75551bb9566d5b3
link
true
/test release-notes

unit-tests-arm64_istio
fae4ef3f60ca84fe5f46c0b4c75551bb9566d5b3
link
true
/test unit-tests-arm64

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ramaraochavali: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
fae4ef3f60ca84fe5f46c0b4c75551bb9566d5b3
link
true
/test release-notes

unit-tests-arm64_istio
fae4ef3f60ca84fe5f46c0b4c75551bb9566d5b3
link
true
/test unit-tests-arm64

unit-tests_istio
fae4ef3f60ca84fe5f46c0b4c75551bb9566d5b3
link
true
/test unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ramaraochavali: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
fae4ef3f60ca84fe5f46c0b4c75551bb9566d5b3
link
true
/test release-notes

unit-tests-arm64_istio
fae4ef3f60ca84fe5f46c0b4c75551bb9566d5b3
link
true
/test unit-tests-arm64

unit-tests_istio
fae4ef3f60ca84fe5f46c0b4c75551bb9566d5b3
link
true
/test unit-tests

gencheck_istio
cf7f5b6d0befba75027a272b49cb2bc08672a29f
link
true
/test gencheck

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ramaraochavali: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
fae4ef3f60ca84fe5f46c0b4c75551bb9566d5b3
link
true
/test unit-tests-arm64

unit-tests_istio
fae4ef3f60ca84fe5f46c0b4c75551bb9566d5b3
link
true
/test unit-tests

gencheck_istio
cf7f5b6d0befba75027a272b49cb2bc08672a29f
link
true
/test gencheck

release-notes_istio
cf7f5b6d0befba75027a272b49cb2bc08672a29f
link
true
/test release-notes

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ramaraochavali: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

gencheck_istio
cf7f5b6d0befba75027a272b49cb2bc08672a29f
link
true
/test gencheck

lint_istio
cf7f5b6d0befba75027a272b49cb2bc08672a29f
link
true
/test lint

release-notes_istio
b67edd3a41a0afd85a9ad168d732c92cdd8084fd
link
true
/test release-notes

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Its not unfortunately - depends on two things

Pilot_gateway_cluster_config
ExportTo annotation
Thinking about this more, this is needed for sidecar with multi cluster
headless as well. With exportTo we don't return the address from our dns
proxy but kubedns returns if it is in same cluster.  For multi cluster it
would fail. Infact it is one of the motivations for this. Thanks for asking.

On Sun, 20 Oct 2024, 06:48 John Howard, @.***> wrote:

@.**** commented on this pull request.
if this is for a gateway isn't everything in scope already?
—
Reply to this email directly, view it on GitHub
https://github.com/istio/istio/pull/53538#pullrequestreview-2379884066,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AEDINKCBBXCBPCJA6MAR4Y3Z4MAH5AVCNFSM6AAAAABP63CO2CVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDGNZZHA4DIMBWGY
.
You are receiving this because you were mentioned.Message ID:
@.***>

/test release-notes


Current version differs from Server, server reporting 404 page not found

wizarr    | WARNING:root:Current version differs from Server, server reporting 404 page not found
wizarr    |  but we have 0.11.0

# cat docker-compose.yaml
version: "3.3"
services:
  wizarr:
    container_name: wizarr
    image: ghcr.io/wizarrrr/wizarr
    ports:
    - 5690:5690
    volumes:
      - /opt/wizarr/:/data/database
    environment:
      - APP_URL=https://wizarr.domain.local
      - DISABLE_BUILTIN_AUTH=false #Set to true ONLY if you are using another auth provider (Authelia, Authentik, etc)
      - ALLOW_BUG_REPORTING=true #Helps me fix bugs, but you can disable it if you want! I use Sentry.io for this.

I can confirm that I'm experiencing the same thing. Log is identical and settings similar (Unraid).

Ah! The website I made that is checked for the versions seems to have been down. Sorry for the inconvenience


Implement WorkerProcess

Closes: #8

@pipermerriam I think this is ready for a first pass

@pipermerriam should be good for a proper review now!


MVC Test controller docs

PR accepted. You need to contribute a bit more to get a full :gift:.  Your contributions are remarkable but I expect a bit of code. For example, you can create a controller with an endpoint that always throws an Exception and test that calling him returns the contents of error.html with an appropriate status code.


Allow user to configure/remap key bindings?

This way, I could configure things to behave more like other CLI tools I tend to use most often, e.g.:
/     find  (if added)
q    quit
e    edit (if added)
:     command mode

External configuration of key bindings is something that is on the Textual roadmap, so I think it'll be likely that this will be left until that is a Textual feature.
I'll keep this open though as I see the value.

+1 for this as cntrl q quits my terminal :)

If it helps, right now Ctrl+C will also safely exit, and Escape in an empty input will too (hitting escape repeatedly should always result in an exit).

Makes sense.
I suspect this is already a consideration, but if there are going to be some common default keybindings used across Textual, it could be useful to see what other popular TUI tools use and adopt similar norms, when possible.. This way it's easy to jump between tools with minimal friction.


double tap and long press

Good day,
with the code below,
the doubleTap fires correctly using the mouse, but using the finger on the screen of my HP Spectre 13 laptop, the doubleTap fires on a single tap, instead of on a double tap.
And the superpress event doesnt fire at all neither with mouse or touch, any tips?
    var el = document.querySelector("#outermain");
var mc = new Hammer.Manager(el);
mc.add(new Hammer.Tap({ event: 'doubletap', taps: 2 }));
mc.add(new Hammer.Press({ event: 'superpress', time:500 }));

mc.on("doubletap", onDoubleTap);
mc.on("superpress", onPress);

function onDoubleTap(ev) {console.log("double tap");}
function onPress(ev) {console.log("press");}

even on this page
http://codepen.io/jtangelder/pen/pBuIw
clicking once on the screen of my HP touch enabled spectre 13 laptop fires the double tap instead of the single tap

so double tap may be broken on touch-enabled laptop screens (at least in mine), and also the press event just doesn't fire at all for me

This is taken from your own examples (i just added the press event lines),
and again, one single tap on my screen fires the Doubletap event. And also the Press handle is never ever fired.
var el, hammer;
var tripleTapCount = 0,
doubleTapCount = 0,
tapCount = 0;
	var el = document.querySelector("#outermain");
    hammer = new Hammer(el, {recognizers: []});

    var tap = new Hammer.Tap();
    var doubleTap = new Hammer.Tap({event: 'doubleTap', taps: 2 });
    var tripleTap = new Hammer.Tap({event: 'tripleTap', taps: 3 });
    var press = new Hammer.Press({event: 'press'});

    hammer.add([tripleTap, doubleTap, tap]);
	hammer.add([press]);

    tripleTap.recognizeWith([doubleTap, tap]);
    doubleTap.recognizeWith(tap);

    doubleTap.requireFailure(tripleTap);
    tap.requireFailure([tripleTap, doubleTap]);

    tripleTapCount = 0;
    doubleTapCount = 0;
    tapCount = 0;

	hammer.on('press', function() {
		console.log("PRESSS DOWN");
	});

    hammer.on('tap', function() {
        tapCount++;
		console.log("tapcount:"+tapCount);
    });
    hammer.on('doubleTap', function() {
        doubleTapCount++;
		console.log("doubleTapCount:"+doubleTapCount);
    });
    hammer.on('tripleTap', function() {
        tripleTapCount++;
		console.log("tripleTapCount:"+tripleTapCount);
    });

@runspired This is not a device specific bug. You can easily reproduce in Dev Tools mobile mode with preset "Laptop with touch". Basically you would have this bug on any laptop with touch screen and they are not rare things nowadays.

@PixelsCommander that's the definition of device specific. It appears that both the mouse input and the touch input are utilized.  It also depends on whether such a device fire both mouse and touch events when the screen is touched or just touch events.  This bug is very likely due to some of those platforms incorrectly firing both.
@arschmitz thoughts on restricting input recognizers by input type? e.g. if you start with a recognizer session with mouse input, touch input will be ignored?

Related Issues:

better mouse vs. touch detection #812

Yes recognizers should only use a single input type within the same gesture.

Theoretically this is already the case
https://github.com/hammerjs/hammer.js/blob/master/src/input/touchmouse.js#L25-L35

@arschmitz the issue actually isn't "within the same gesture", each "tap" is it's own gesture, I suspect we're going through a complete recognizer lifecycle for both the mouse and the touch version of the events.  We need to have the manager stop recognizing either touch or mouse entirely depending on which is received first until the end of that gesture's life cycle.

@runspired thats what i meant sorry iv debated this same issue on other projects. and have always maintained they trying to support simultaneous inputs of different types is to much of an edge case and too crazy to support.
I dont think iv ever seen someone try to use the touch screen with one hand and mouse with the other at the same time. And even if they do we should just not support this too many bugs and edge cases like this one to even think about it in my oppinion

@arschmitz Our users already found that and we are still in closed beta.

@PixelsCommander you found your users using the touch screen and the mouse at the same time? my understanding here is this is the mouse event which is generated by the touch event not independant events?

They just have laptops with touch and mouse. I know very little on how things a built under the hood but having touch and mouse events in browser brakes double tap which seems to be reflected in this issue.

@PixelsCommander yes no one is saying there is not an issue currently we are simply talking about how to fix it

@arschmitz Sorry Alexander, misunderstood.

The double tap problem is that on a touch enabled device, Chrome delivers these events (plus a few others) for a touch tap: touchstart touchend mousedown mouseend, click In that order   The code in TouchMouseInput to set allow to false during the touch assumes that it's sufficient for allow to be false while the  touch is active, but this sequence breaks that.   As far as I have been able to determine, the only way to stop Chrome from delivering the mouse events is to call preventDefault for one of the touch events, but that also suppresses the click event.
Calling preventDefault in your tap handler won't work because by the time it fires, the real mouseUp event handler is off the stack because of the requireFailure.
Some experimenting with https://jsfiddle.net/BillAtYuzu/xoznn4yp/3/ suggests that Chrome will send the mouse start event eventually if you press and hold, and that it doesn't send the mouse events at all on drags.


foreach and other advanced tempting features

Is it possible to use statements (foreach, if, etc.) in templates?
If not:

is it planned for future releases?
any workaround?

yes! plop uses the handlebars template engine and has all of these features, plus the ability to add custom features if you so desire. You can learn more on their website.


Issues with okhttp < 2.2

We are facing this issue: https://github.com/square/okhttp/issues/1460
Would it be possible to update the bindings to okhttp 2.2 ?

I'll take care of it this weekend

Fixed in a61c8d98b


[CSFix] Handle some cases where the same fix appears in multiple solutions

Same missing conformance in multiple different solutions;
Same invalid reference in a key path;
Same out-of-order argument;

Same in this context means located in the same position and having exactly the same information e.g. same requirement/non-conforming type, same argument positions, same member declaration etc.
Resolves: SR-14093
Resolves: rdar://73600328
Resolves: rdar://74447308

@swift-ci please smoke test


Fix client-go dependency issue

Background / Context
LCA depends on client-go, config-policy-controller and local-storage-operator
Issue / Requirement / Reason for change
See #269
There's an old pinning of client.go in open-cluster-management.io/config-policy-controller that pinned the version of client-go to v12.0.0+incompatible which means we had to pin our client-go on that version as well.
This makes importing LCA as a library (e.g. in image-based-install-operator) annoying as they have to copy our replace directives
config-policy-controller fixed that a while ago on their main branch but never released a version tag.
Solution / Feature Overview
Now that they released a tag, we can move to depend on their latest v0.14.0 instead, which doesn't depend on the weird v12 client-go version.
Another issue
Simply trying to move to the latest version of config-policy-controller doesn't work, because our recently added local-storage-operator dependency depends on a weird version of client-go called v1.5.2.
Solution for the other issue
This means we have to move our local-storage-operator dependency to the last version that didn't depend on this weird version (go get github.com/openshift/local-storage-operator@569393ff42e1b632254b05d1d89f0f1431246cb5)

/lgtm

/approve


add deprecation message into the confluent cloud package card

overview
we'd like to add a message into the new package page card for the confluent cloud provider to better communicate that the package has been deprecated.
designs

instead of the info icon, uses a warning icon in our warning color #BD4C85
warning icon also appears on the collapsed card to the left of the publication date, size 14x14
fontawesome equivalent of the warning icon, triangle-exclamation

@susanev let me know if this is the right direction for the text, we can adjust this in whatever way you think best

whoa that was fast, and i love this!
is that white accessible on the orange?

i can double check, but i think jonelle ran this thru a contrast checker before she updated the design system

it passes for graphical components but not text. if we're wanting it to pass for text, we would have to bump the base color up from this one (orange600) to orange800 #B35F16.

@anita-trimbur yah you can go with the pink if you'd like, you can also use dark text instead of white and keep the orange you have. whatever you think is b est.

this is mostly done, just needs the warning icon instead of the info icon


ios bug

I'm using admob ver. 1.4.0
xcode 15.0.1
I install the plugin like in this youtube https://www.youtube.com/watch?v=vfKGsWZdhSE (from here https://github.com/EMI-INDO/emi-indo-cordova-plugin-admob/discussions/3)
the build was successful but when I fire this JS I get an error

cordova.plugins.emiAdmobPlugin.initialize(	);
cordova.plugins.emiAdmobPlugin.loadBannerAd(
				    bannerAdUnitId = "ca-app-pub-3940256099942544/2934735716",
				npa = "1", // String | 0 | 1
				position = "bottom-center",
				size = "default",
			);
cordova.plugins.emiAdmobPlugin.showBannerAd();

this what the xcode refer to
Thread 1: Swift runtime failure: Index out of range
let bannerAdUnitId = command.arguments[0] as? String ?? ""
emiAdmobPlugin.swift:36

@boazn0
plugin upgrade new API

ios swift migration to objective c.
works just like an android.
actions, events just like android.
New documentation,
New README.md,
New basic index.html example.

https://github.com/EMI-INDO/emi-indo-cordova-plugin-admob/blob/main/README.md
https://github.com/EMI-INDO/emi-indo-cordova-plugin-admob/tree/main/example


[WIP] Expose notification creation

Also add support for websocket connections in the test context.
We need these features in a wrapper of SM.

Coverage increased (+0.004%) to 88.78% when pulling 44a5fba30cee0bf1e00ee4bde6c04f745922b8cf on expose-create-notification into 8001819b022eb2879b1865c58435828951ba0b5c on master.


Add Host Configuration Option for Enhanced Security with Nginx Reverse Proxy

I am currently using Casdoor and noticed that it only allows configuration of the listening port, defaulting to listen on <IP_ADDRESS>. This setup makes it challenging to securely configure Casdoor behind an Nginx reverse proxy without exposing additional ports to the outside network.

Issue Description:

The application lacks an option to configure the listening host address. It is always set to listen on all interfaces (<IP_ADDRESS>).
This behavior poses a security risk as it potentially exposes the application to unwanted external access.

Proposed Solution:
I propose adding a configuration option that allows users to specify the listening host address. For instance, being able to set the host to <IP_ADDRESS> would enable the application to only listen on the local machine, thus enhancing security when using reverse proxies like Nginx.
Benefits:

Increased security by restricting access to the application via network configuration.
Flexibility for users who need to deploy behind reverse proxies without exposing the app on public networks.

I believe this feature would be beneficial for many users who are looking to secure their Casdoor deployments more effectively. Looking forward to your thoughts on this.
Thank you for considering this enhancement.

@moemoequte modify this line:
https://github.com/casdoor/casdoor/blob/bfcfb56336799ff24068f06e7d1aaa214d75d4ff/main.go#L88
to: beego.Run(fmt.Sprintf("<IP_ADDRESS>:%v", port))
No need to add config, there are already too many configs.

I have to disagree. Security is layered. Unless someone explicitly installs a firewall, casdoor will happily listen on http-alt and respond there. It should be safe by default, not requiring additional steps for hardening. Take a look e.g. at Debian's packaging of Mysql/MariaDB: it only listens on localhost by default.


Bugfix: the id property of spo tenant applicationcustomizer get should be the list item id

In https://github.com/pnp/cli-microsoft365/issues/4243 we implemented retrieving an application customizer that is installed tenant wide by its id, title or clientSideComponentId.
The only problem is we've implemented the wrong id. In the documentation it says its the product id, and in the code it gets the list item by its GUID property.
The GUID property is unique, but as it's not much used by developers (AFAIK) its better to use the UniqueId or the List Item Id. In this case the list item id is fine. It's shorter, easier to use and remember when you copy it from somewhere.
It's a slight breaking change though. Opinions @pnp/cli-for-microsoft-365-maintainers?
Should we wait with this or just treat is as a bug. My opinion is to get it out of the way as a bug..

Why should we consider it as a bug? We chose a specific implementation and in hindsight it doesn't seem the right choice. I suggest we consider it a breaking change for v7, rather than a bug.

Thought you'd say that 😂

Opening this up as we are releasing v7 after the summer holidays. Warmly recommended for your contribution. 🎉
Target the v7 branch when raising a PR.

Can I work on this?

Sure, all yours


Assigning and returning arrays results in stack corruption

This code segfaults:
bar([1, 2, 3] |> $[0] + $[1]);

This doesn't:
foo();
bar([1, 2, 3] |> $[0] + $[1]);

Array literals now return the pointer to their first index, resolving this bug.

Fixed, issue was in validator.c where local variables would not be assigned the correct array sizes

Issue still occurring when doing this with arrays bigger than 128 bytes

Fixed with the new array implementation


Laravel 5.2

I'm submitting a ...

[ ] bug report
[ ] feature request
[ ] support request
[ v] other (Please specify)

Provide information & explanation

Hi developers, does v3.4 also support Laravel 5.2?

Version 3.4 is based on Laravel 5.3
Version 3.2 is based on Laravel 5.2


FlatList refreshing animation not displaying on initial load when using SafeAreaView

Description
When fetching data on initial mount of the component, the FlatList refreshing animation is not displaying when there is a header that is using SafeAreaView. If I add a setTimeout to the fetchData in componentDidMount then the animation shows up but that feels a bit hacky and shouldn't be necessary. I'm using iPhone X simulator. Sidenote: This also appears to be happening with the SectionList refreshing animation as well.
Environment
React Native version: 0.60.5
System:
    OS: macOS 10.14.6
    CPU: (8) x64 Intel(R) Core(TM) i7-7700HQ CPU @ 2.80GHz
    Memory: 423.18 MB / 16.00 GB
    Shell: 3.2.57 - /bin/bash
  Binaries:
    Node: 12.8.0 - /usr/local/bin/node
    Yarn: 1.17.3 - /usr/local/bin/yarn
    npm: 6.10.3 - /usr/local/bin/npm
    Watchman: 4.9.0 - /usr/local/bin/watchman
  SDKs:
    iOS SDK:
      Platforms: iOS 12.4, macOS 10.14, tvOS 12.4, watchOS 5.3
  IDEs:
    Android Studio: 3.4 AI-183.54<IP_ADDRESS>52501
    Xcode: 10.3/10G8 - /usr/bin/xcodebuild
  npmPackages:
    react: 16.8.6 => 16.8.6
    react-native: 0.60.5 => 0.60.5
  npmGlobalPackages:
    create-react-native-app: 2.0.2
    react-native-cli: 2.0.1
    react-native-git-upgrade: 0.2.7

Steps To Reproduce

https://snack.expo.io/B17r3SdES
Using iOS, changing the SafeAreaView to a View shows that the FlatList's refreshing animation will display on initial load.
Changing the header back to a SafeAreaView shows that the refreshing animation is absent on initial load (unless using the setTimeout( this.fetchData, 250 ) hack in componentDidMount that I mentioned in the description).

Describe what you expected to happen:
I expected the SafeAreaView to have the same behavior as the View component in the way it interacts with other components on initial render.
Snack, code example, screenshot, or link to a repository:
https://snack.expo.io/B17r3SdES

It also happens with react-native 0.60.4

0.60.5 same bug here


Support Bedrock tags

Hey,
I would be nice to support Bedrock tags from action inputs
Something like
bedrock_tags:
  required: false
  default: ''

And if user provide them as list
input.bedrock_tags: department=foo,team=bar

Ref: https://docs.aws.amazon.com/bedrock/latest/userguide/tagging.html

@matanbaruch Hi, sorry for the late reply.
This tool just calls specified models with invokeModel API, so as far as I read the doc, we cannot set the tag from our side.
I think you can set bedrock_heavy_model or bedrock_light_model to your models with tags configured, and then you can track model usage using tags.


fix: displayed toolbar for map icon click

Fixes #1531
Changes:
Toolbar displayed on map icon click in SessionDetailActivity.
Screenshots for the change:

@the-dagger
please review!

LGTM @arp95 just rebase your branch on development

Yes, map icon is also disappearing after back button is pressed on MapFragment.
Fix it along with it

@Shailesh351 I don't think we need that map icon here as we are already on the map screen.

@heysadboy I am saying that once back button pressed on map fragment  when user return on session detail activity map icon is disappered

@Shailesh351
rebasing it.
actually i tried to ensure the map icon doesnt disappear for a day but found no solutions to it.
any ideas?

@arp95 Are you adding the map icon programmatically?

@iamareebjamal
have done changes.

@arp95 Is the menu icon still disappearing?

@iamareebjamal
thats a separate issue because if you see in SessionActivity even there on clicking, the maps icon disappears. As its not realted realtedd over here will have a lookm at both map icon at a single pr instead of here.
is it fine then?


Fix apply edit when codeAction is selected.

Hi, gbrlsnchs.
Thank you this plugin.
This PR fix apply_edit when textDocument/codeAction.
textDocument/codeAction can return either Command[] or CodeAction[].
If it is a CodeAction, it can have either an edit, a command or both.
Edits should be executed first.
See also:
https://github.com/golang/tools/blob/master/gopls/doc/vim.md#neovim-imports
https://microsoft.github.io/language-server-protocol/specifications/specification-current/#textDocument_codeAction

Thank you very much for fixing this! :smiley:


(PUP-6631) ensure packages are not autoremoved

Someone with more Debian chops than me should review this heavily. I
don't know whether apt-mark is even installed by default on all Debian
flavors, or whether there will be unwanted side effects.

(and for the record, I don't see why it doesn't get marked as manual by default, since we're just calling apt-get install)

On debian 8:
root@c09f6df09c30:/# dpkg -S /usr/bin/apt-mark
apt: /usr/bin/apt-mark

CLA signed by all contributors.

I don't think this will actually fix the issue on the ticket. My understanding is that the issue is as follows:

Install package foo, which depends on bar
Apply a puppet manifest that wants bar installed. This is a no-op
Uninstall foo. bar will be uninstalled.

The change that's needed, then, is that when Puppet has a package resource on debian it should consider it out-of-sync if that package isn't marked as manual, so that the marking can happen. Adding marking to all operations won't fix that, and shouldn't be necessary - any explicit call to install a package with apt-get will have already marked that package as manual

It is possible to make package marking work as desired, though it'll require more work. In order for a package to be marked that's not installed it needs to be treated as out of sync, which requires a new mark property. Let me know if you want to explore this implementation and I can give more details, but as it stands this pull request can't be merged since it doesn't address the root issue.

@binford2k if you're interested in proceeding further with this PR, please ping @adrienthebo to continue with the needed changes. In the interim I'm going to go ahead and close this as it's not merge-able as is and its been a couple months, and we can reopen once changes are complete.


Tabloid/Landscape Page Type Prints as Letter/Portrait

With the page type set to 11x17 (tabloid) and landscape, it prints as 8.5x11 (letter) and portrait.  I've reproduced this Firefox and the Windows desktop app.  I've also reproduced it with both a physical printer and a PDF printer.

Hi,
you mentioned you tried both a physical printer and a PDF printer. What exact steps you performed (where did you click), please?
Was it File > Print and Save as PDF/Print to PDF
or File > Export as PDF > ... (add your steps please)
Thanks,

It was File > Print.  I've tried sending to a printer (Konica Minota Biz C754) and the Microsoft Print to PDF driver.
I just tried it in Chrome also and get the same result.  Chrome actually shows a preview in the print dialog and you can see it with the wrong paper type there.
File > Export > PDF seems to work!  The resulting file has the paper type and orientation set correctly.  Thank you for pointing that out, that's a workaround.
Thanks

Did you try changing the paper size in the system print dialog?

Did you try changing the paper size in the system print dialog?

I did and it came out with the correct paper and orientation, but I seem to remember that it didn't render correctly.  It bled off the page and spilled onto a second page.

Can you please provide us with a sample file and steps to reproduce the rendering issue when the system print dialog page size matches the page size in draw.io print dialog?

I'm lost where you are going with this, because overriding the paper orientation and size through the printer driver doesn't address the bug.  :)  Rotating and stretching with the printer driver has mixed results.
Regardless, I've attached the source file and the sample PDF if I print to the Microsoft Print to PDF driver.  In this case, I used Firefox, but the problem seems cross platform.
To reproduce, File -> Print... (which this dialog correctly shows 11x17), Print.  In the system printer dialog, change to Microsoft Print to PDF, Preferences..., Orientation: Landscape, Advanced..., Paper size: tabloid.  With this print driver, it doesn't bleed over to a second page, but it doesn't scale up to fit the full page, either (sample output file attached).
11x17 test.zip

The reason I asked for changing the page size in the system print dialog is we don't have control on that dialog. We prepare the page size based on the information give in our print dialog, then the user should match those setting in the system dialog.
As in this screen shot (where I followed your steps but with clicking preview), you see the page size and orientation is correct

And this is how it prints when I matched the page size and orientation in the system dialog
Accountability Chart no names 2020-07-20.pdf

Yes, it does look correct in the preview screen.  It's just not making it to the printer with correct paper settings.  You're saying that this is a shortcoming of the development platform?  If so, I'll just continue using the PDF export functionality as a workaround.
Thanks

You can also try our desktop app which has more control over the printer settings and should produce correct results.


type_graph: add CycleFinder pass

Summary
Typed Data Segment can't currently handle cycles, because it's impossible to define the cyclic type in unmodified template parameters. This change solves that by pulling out the graph edges which would be problematic first, creating a fake type which can be used in place of the cyclic type.
This implementation corrects cycles in a subset of cases, but should expose all cycles. This allows it to give a descriptive error to continue debugging.
Test plan

OID_TEST_ARGS='-ftyped-data-segment' make test - all cycle failures are gone.

Codecov Report

Merging #231 (29dec0b) into main (28b813c) will decrease coverage by 18.74%.
The diff coverage is 98.70%.

@@             Coverage Diff             @@
##             main     #231       +/-   ##
===========================================
- Coverage   66.30%   47.56%   -18.74%
===========================================
  Files          90       86        -4
  Lines        9940     9855       -85
  Branches     1621     1602       -19
===========================================
- Hits         6591     4688     -1903
- Misses       2498     4365     +1867
+ Partials      851      802       -49

Impacted Files
Coverage Δ

oi/CodeGen.h
100.00% <ø> (ø)

oi/type_graph/TypeGraph.h
100.00% <ø> (ø)

oi/type_graph/Types.h
90.66% <91.66%> (-9.34%)
:arrow_down:

oi/CodeGen.cpp
62.44% <100.00%> (+2.17%)
:arrow_up:

oi/type_graph/CycleFinder.cpp
100.00% <100.00%> (ø)

oi/type_graph/Types.cpp
71.08% <100.00%> (-3.21%)
:arrow_down:

... and 48 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Changing to draft as I'm having a bit of a rethink of this. It might end up not changing but draft for now.

Waiting for a rebase then I'll clean this up.

Partially addresses #293

Closing this PR as it's extremely outdated and a mess. Some of the approach is still okay.


Please add locale-specific toUpper/LowerCase

Currently in our project we need to have separate Intl.messages for messages such as 'Paused' and 'PAUSED' because calling Intl.message('Paused').toUpperCase() might be wrong in some languages, namely Turkish, Azeri and Lithuanian.
This introduces the risk that the two messages might be translated differently, introducing confusion for the user.
Note that Intl has toBeginningOfSentenceCase that handles Turkish and Azeri (but not Lithuanian) so this doesn't seem like such a leap.
See http://hg.openjdk.java.net/jdk9/jdk9/jdk/file/65464a307408/src/java.base/share/classes/java/lang/ConditionalSpecialCasing.java
for the OpenJDK implementation (or don't look at it if there are intellectual property issues).

What are you asking for this to do? Is it just roughly the equivalent of
aString.split("").map((x) => toBeginningOfSentenceCase(x).join("");
perhaps with the addition of Lithuanian? I've been reluctant to do anything that would add a large amount of character data, and the urgent issue seemed to be around these couple of special cases. And you made me worried so I haven't looked at the OpenJDK version.

Yes, that's what we would need, but likely with some Unicode subtleties
that I don't understand.
On Mon, Feb 5, 2018 at 10:40 AM, Alan Knight<EMAIL_ADDRESS>wrote:

What are you asking for this to do? Is it just roughly the equivalent of
aString.split("").map((x) => toBeginningOfSentenceCase(x).join("");
perhaps with the addition of Lithuanian? I've been reluctant to do
anything that would add a large amount of character data, and the urgent
issue seemed to be around these couple of special cases. And you made me
worried so I haven't looked at the OpenJDK version.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/dart-lang/intl/issues/157#issuecomment-363179482, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AZC77f8x7SiWlOzOJhKuyA8A6CZreKxdks5tR0sogaJpZM4R5r-v
.

--
Roberto Scaramuzzi
https://www.google.com/+RobertoScaramuzzi

print(DateFormat('MMMM', 'tr')
        .format(DateTime(2020, 4, 1))
        .split("")
        .map((x) => toBeginningOfSentenceCase(x))
        .join(""));

The code above still prints NISAN instead of NİSAN.
Am I missing something?

toBeginningOfSentenceCase has an optional locale parameter. If you have not set the default locale to 'tr', then you need to pass that parameter. Also, you don't need to do it for each character, you can just do it for the whole string, skipping the split/join.

If I skip split/join, it does not work since i is the second letter.

It is working fine after setting locale. Thank you.


No WAS Suite menu found, where can I see it please?

No WAS Suite menu found, where can I see this menu
I have extracted the file to /ComfyUI/custom_nodes/ folder

You should be able to just extract to /ComfyUI/custom_nodes/WAS_Node_Suite.py
If you extracting to custom_nodes with __init__.py and not inside was-node-suite-comfyui folder, it probably won't work.
What does your console say?

if  extracted to /ComfyUI/custom_nodes/WAS_Node_Suite.py I can confirm that No WAS Suite menu is found.
However, if you extract into  '/ComfyUI/custom_nodes/was-node-suite-comfyui' and rename WAS_Node_Suite.py to init.py the menu appears and works.

Strange. It works fine for me. I don't use any init nonsense or folders.

I think I have uncovered the mystery , if you use the downloadable portable version it works as you say, if you use a version that uses the automatic1111 core for dependencies then you have to do as I wrote before : https://github.com/comfyanonymous/ComfyUI#i-already-have-another-ui-for-stable-diffusion-installed-do-i-really-have-to-install-all-of-these-dependencies

I think I have uncovered the mystery , if you use the downloadable portable version it works as you say, if you use a version that uses the automatic1111 core for dependencies then you have to do as I wrote before (but there's not a preexisting __init__.py it's just your .py renamed) : https://github.com/comfyanonymous/ComfyUI#i-already-have-another-ui-for-stable-diffusion-installed-do-i-really-have-to-install-all-of-these-dependencies

That is strange. I wonder why it can't load them normally. It doesn't sound like a dependency issue since it checks its own dependencies and installs if needed, which though would install to whatever venv is running it. But they are not forcing reinstalls or anything and should just skip.

yes I think you are right : a dependency issue, auto1111 is a code that is always being modified and it is normal to have these problems...  for this reason I think I will switch to using ComfyUI in portable mode not in auto1111 mode, however renaming the -py is no big deal if one wanted to use the version that uses auto1111.

yes I think you are right : a dependency issue, auto1111 is a code that is always being modified and it is normal to have these problems... for this reason I think I will switch to using ComfyUI in portable mode not in auto1111 mode, however renaming the -py is no big deal if one wanted to use the version that uses auto1111.

Yeah. I haven't actually used WebUI in a couple weeks now. Been using ComfyUI.

personally, i use the regular comfy version (not the portable one) using the same venv as automatic1111 and it works without problems.
i installed it by cloning the entire folder into custom_nodes.
automatic1111 had a big update recently which i haven't pulled yet, so maybe that broke something?

personally, i use the regular comfy version (not the portable one) using the same venv as automatic1111 and just works™. i installed it by cloning the entire folder into custom_nodes. (so my file structure is \custom_nodes\was-node-suite-comfyui<files>)
automatic1111 had a big update recently which i haven't pulled yet, so maybe that broke something?

That could be. I updated a couple weeks ago, so may have missed it. I always have issues with the updates. Especially reordering whole main menu all the time for seemingly no reason.
Hopefully it's a minor thing, though luckily there are multiple install methods.

Yes I saw, you did well.


java 6 support

a lot of projects (including ensime-serever) use java 6 because its the lowest common denominator and still the official JDK for stable releases of scala.
But using your sbt plugin on a java 6 project gives
[error] java.lang.UnsupportedClassVersionError: coursier/CoursierPlugin$ : Unsupported major.minor version 51.0

Should be fixed on the topic/java-6 branch.

Use the Java 6 specific SBT plugin with
addSbtPlugin("com.github.alexarchambault" % "coursier-sbt-plugin-java-6" % "1.0.0-M8")

You're the best :smile:

Considering this fixed by the topic/java-6 branch. I'm intending to regularly merge it with master until 1.0 final.


Tar MemoryStream only works with no compression

Example Test (similar to existing), only none passes
[Theory]
        [InlineData(CompressionType.None)]
        [InlineData(CompressionType.GZip)]
        [InlineData(CompressionType.LZip)]
        [InlineData(CompressionType.BZip2)]
        public void TestCompressions(CompressionType compressionType)
        {
            const string filename = "file.txt";
            const string input = "dummy filecontent";

            // Step 1: create a tar in memory
            using var stream = new MemoryStream();
            using var writer = WriterFactory.Open(stream, ArchiveType.Tar, compressionType);
            using var inputStream = new MemoryStream();
            inputStream.Write(Encoding.UTF8.GetBytes(input));
            inputStream.Position = 0;
            writer.Write(filename, inputStream, null);
            stream.Position = 0;

            // Step 2: check if the written tar file can be read correctly
            using var archive2 = TarArchive.Open(stream);
            Assert.Equal(1, archive2.Entries.Count);
            Assert.Contains(filename, archive2.Entries.Select(entry => entry.Key));

            foreach (var entry in archive2.Entries)
                Assert.Equal("dummy filecontent", new StreamReader(entry.OpenEntryStream()).ReadLine());
        }

stream doesn't get closed correctly.  You need to explicitly dispose it in the scope to finish off compression/trailers for any archive.

wont the "using" statement properly dispose the object?

wont the "using" statement properly dispose the object?

you have two scopes writing then reading....nothing gets disposed until the end of the function which is the problem.


Corrects update instructions

This repo is now public and no longer requires a  #"login" to the technekes
organization for pulling the image.

Good catch @blankenshipz!


define and align on a trust decision model/function

I could easily see this as a critical joint item between the ToIP and DIF, but the idea here is that we need a complete and standard model to think about trust decisions. We should then align them with the specifications and make sure it's appropriately able to work with the model.
These may seem like vacuous and theoretical questions, but I think they have some real ramifications around how an actual implementation would look, and how technology can support these efforts, so I'm bringing it up here.

I'm working on something related to this. But it will take time for me to prepare.

I like the idea! I can see this being a new spec or an interop item with another group

@decentralgabe I have meaningful ideas around how, to do this, but I actually kicked them out b/c I want to make sure we clear out any IP related stuff first. I can bring it up over the next TE call.

Another article came through. noting: https://www.fer.unizg.hr/download/repository/Master_Thesis-_Mirjam_Situm.pdf

Another article: https://fdocuments.net/document/the-study-of-trust-vector-based-trust-rating-aggregation-.html?page=4


Implement extended Delete command

Implements an extended version of the Delete command. Closes #2.
As the base AB3 already contains a delete command that deletes the specified index, I've extended the command to also be able to take in a student's matriculation number as a possible input parameter.
Example usage of extended command: delete i/A0123456Z
Testcases to be implemented.

Just some extra comments from me (that does not really affect the correctness of the command)

Thanks for the suggestions, will clean up my code👍


Helm value to prevent namespace creation

I want to create the namespace separately so that I have full control over it's labels and annotations. However the Helm chart seems to force namespace creation.
Can an option be added to disable default NS creation and let me create it instead?

Have you tried installing by telling Helm to use a different namespace? Basically, add the parameters --namespace <my-ns> --create-namespace to your installation command. Does this work?

Closing due to inactivity.


A way to nicely recreate usb device

Basically i have usbd-serial device in the main loop, and i want to use serial device to log errors in the panic handler.
There are two solutions for this:

Make a global serial singleton.
Reset the device somehow.

First one should just work, but i want to implement second one, and have encountered problems with this.
I have tried setting a static mut var in the .noinit section, similar to how lufa jumps to bootloader, to keep that variable between reboots, then have used watchdog to reset the program, and then on the start of the program checked if that variable is set do the actual panic handling, but even that doesn't work, for some unknown reason, i have to wait until PC powercycles the devices itself.
I have tried .reset() method on the bus, but that doesn't work.
I have found .force_reset() method that is currently unimplemented and i think that is what i need probably, so what i ask is for its implementation.

Sorry I haven't responded to this, I have a bit of trouble understanding what you're asking.
However, force_reset has now been implemented and merged (#13), if you want to try that.


Game Pass International Support

Much of this content comes from aqw/xbmc-gamepass#313

A quick background for the uninitiated:
In 2017, the Game Pass Service was split between two streaming providers:
Game Pass Europe (WPP/Bruin)
Game Pass International (NeuLion)

Currently all developers of this library are in Europe, so only Game Pass Europe is supported. We are very interested in developers from Game Pass International regions getting involved in development and maintenance.
In theory, it should not be too difficult to get decent support for Game Pass International. Prior to 2017, NeuLion was the only streaming provider. Version 0.10.2 of aqw/xbmc-gamepass used that service. As a result, many of the devs have experience with the NeuLion service, and we can help provide some pointers.
However, not all is easy. Predictably, NeuLion has changed its APIs quite a bit since the split (likely concern over the competition), so it's not as easy as a quick code-resuscitation. There will likely be some new paths to blaze.
It is important that consumers of pigskin.py should be able to use the same API regardless of which service (Europe vs International) they are connecting to. This will be problematic at times, but looks to be doable.
Two places where you can borrow code from

pigskin.py from xbmc-gamepass 0.10.2
dav-sap did some work in the international-support-2017 branch of dav-sap/xbmc-gamepass

I am willing to share a login for game pass international

@r3dlobst3r Thanks for the offer. When it comes time to start integrating dev-sap's work into this library, I may ask for you to do some testing. :-)

I have tried @dav-sap 's fork.. NFL network works but has issues (every 15secs or so it pauses and resumes after 2sec or so... ) However I am unable to get games to reply in any format... Looking in debug log its giving me a 403 error. Next live game I will check those... I have a full Gamepass account and currently in New Zealand, I am happy to help with testing, etc... I do know a bit of python however I am far from an expert, but I have no experience with writing addons for kodi.

I will take a look. I remember it worked last season. The lagging doesn't
sound like some i experienced. Did u ise adaptive inputstream? enabled it
in the setting
On Wed, Aug 29, 2018, 06:36 michlinux<EMAIL_ADDRESS>wrote:

I have tried @dav-sap https://github.com/dav-sap 's fork.. NFL network
works but has issues (every 15secs or so it pauses and resumes after 2sec
or so... ) However I am unable to get games to reply in any format...
Looking in debug log its giving me a 403 error. Next live game I will check
those... I have a full Gamepass account and currently in New Zealand, I am
happy to help with testing, etc... I do know a bit of python however I am
far from an expert, but I have no experience with writing addons for kodi.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/aqw/pigskin/issues/1#issuecomment-416813198, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AQCk2RT2BYbPV2FuDwPrBPV4XQ2kbFzgks5uVgxCgaJpZM4V-E3y
.

Yes I am using adaptive, as you stated before it does not work without it. so my memory must have been bad, as I timed between the "pauses" and it looks like its exactly 1min, might be 61secs....  I timed it for 5 times always the same. I grabbed part  of debug log from when it does a pause.. I should clarify; the player doesn't pause, the screen goes black and I see a file flash like its starting a new file in the upper left, but its really fast. 1 second maybe, 2 max... most of that the screen is just black.
gamepass.log

Tested on live games both with and without adaptive and neither work.

Yep this is live game from today...
Logging starts from app launch to attempted live game play. Adaptive is on.
kodi.log

Once #15 is done, then we can actively start working on this.

For now, everything seems to be broken again. Except for nfl network. I
don't know what changed, the log doesn't say much. If anybody can help me
with this let me know.
On Tue, Sep 11, 2018, 23:10 Alex Waite<EMAIL_ADDRESS>wrote:

Once #15 https://github.com/aqw/pigskin/issues/15 is done, then we can
actively start working on this.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/aqw/pigskin/issues/1#issuecomment-420408634, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AQCk2aSZiKXZGjnqL0Lf1fuQ5Nwq9Bcqks5uaBjAgaJpZM4V-E3y
.

i got replays to work. without using inputstream adaptive, which seems to be broken now. inputstream adaptive seems to forget the cookies and it get 403 back. I will to work it with them ( i remember doing the same thing last year)
I believe the live will work tomorrow now that i understood the problem. but can't promise anything. I committed the changes to my fork

Yes, they are working here as well, nicely done! Cheers m8, is adaptive bug the reason NFL network was doing the small freezes? - on a side note I have more free time now, so I can help with this project now.

So it looks like Live is going to work... Monday Night game is getting ready to start, and its showing "The Game will start soon" screen.

now we need to clean everything up and fit to the new  API @aqw is writing.
at the time i also changed the default.py file which should stay the same
On Sep 18, 2018 03:09, "michlinux"<EMAIL_ADDRESS>wrote:
So it looks like Live is going to work... Monday Night game is getting
ready to start, and its showing "The Game will start soon" screen.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/aqw/pigskin/issues/1#issuecomment-422210787, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AQCk2exwm2l2HPMJsDzGOu6JYhltoopqks5ucDm_gaJpZM4V-E3y
.

@dav-sap Thanks for continuing to keep the International support alive. :-)
@michlinux You say you have time, eh? :-D Help's always appreciated. If your focus is international support, then @dav-sap is right that it's best to wait until I have the new API figured out (which hopefully won't be too much longer). If your interest is broader and feel comfortable working in Python, then find something you're interested in the issues and I can provide some direction. :-)

@dav-sap @michlinux How were you able to get the addon to work in the new version of Kodi, with the updated version of input? Kodi will not allow me to enable it. Thanks!

not sure i did anything special, but i handled this almost a yr ago, maybe
i don't remember.  what logs do you get?
On Tue, Sep 18, 2018, 18:02 r3dlobst3r<EMAIL_ADDRESS>wrote:

@dav-sap https://github.com/dav-sap @michlinux
https://github.com/michlinux How were you able to get the addon to work
in the new version of Kodi, with the updated version of input? Kodi will
not allow me to enable it. Thanks!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/aqw/pigskin/issues/1#issuecomment-422429401, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AQCk2cQKo4-IfEjUrp9-Zgapv7TXyke_ks5ucQsagaJpZM4V-E3y
.

@dav-sap sorry i was referring to this part:
note: default inputstream adaptive for kodi17 is version 2.0.19, this issue (cookies not being sent in all requests) has been fixed in later versions. in kodi18 they use the latest version. need to manually update version so inputstream adaptive works

Yeah, sorry for being too vague.

kodi18 has the latest. To put the latest on kodi17 you need to build it on
your own. but from some version it's not compatible at all with 17. you
should check their github and issues.
On Tue, Sep 18, 2018, 18:42 r3dlobst3r<EMAIL_ADDRESS>wrote:

Yeah, sorry for being too vague.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/aqw/pigskin/issues/1#issuecomment-422443977, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AQCk2Y2-zPGI5yh3bB0nMWVr72odparEks5ucRROgaJpZM4V-E3y
.

Okay, thanks @dav-sap .

@aqw You bet! I have "some" free time now starting this coming weekend. Im happy to help and my python skills are improving, so will see what I can do. cheers.

@michlinux Great to hear. I'm actually leaving for a week-long vacation tomorrow, so I'll be taking a break during that period. But I'll be happy to answer any questions when I come back. :-)

Hey all,
I can confirm international game pass works with https://github.com/aqw/xbmc-gamepass master code.
I used kodi 18 with inputstream adaptive. From what i read i think europe also has the problem they must use inputstream adaptive.
I checked: shows, nfl network live, live game, replays.

@dav-sap Any way you could share how you installed the NFL Gamepass add-on into Kodi 18? Based on the discussion in this thread, I just tried updating to Kodi 18 but the NFL Gamepass add-on was reported as incompatible. Does it need to be installed manually somehow, rather than through the Kodi add-ons interface?

If needed I can provide international gp account for a dev.

Is game pass international support working for this or https://github.com/pigskin/kodi-gamepass?

I don't know, if this still is an issue. Please see my comments in https://github.com/pigskin/kodi-gamepass/issues/444

Closing this issue, as NFL has canceled the Gamepass service


Master branch missing from checkout UI

VSCode Version: 1.52.1
OS Version: Windows 10 Pro, build 19042.746

Steps to Reproduce:

Initialize repository
Create new branch
Checkout the new branch
Click on the new branch name on the status bar
The master branch is missing from the checkout selection UI

Does this issue occur when all extensions are disabled?: Yes

Reading through the above mentioned links I seem to have experienced the same bug as https://github.com/microsoft/vscode/issues/112838
The only thing to clarify is that this happens on ALL new repos created with this version of VSCode (1.52.1)

Reading through the above mentioned links I seem to have experienced the same bug as https://github.com/microsoft/vscode/issues/112838
The only thing to clarify is that this happens on ALL new repos created with this version of VSCode (1.52.1)

It's a duplicate and is fixed in the current insiders build.

It's a duplicate and is fixed in the current insiders build.


add env variable to retrieve workspace root path

Closes https://github.com/rust-lang/cargo/issues/7036
r? @matklad @alexcrichton

The current work-around for this is to launch cargo metadata, which is not to pretty: https://github.com/mitsuhiko/insta/commit/943e7bca885140d6253a0ee97127e0f963403eac
The potential gotcha here is that workspace situation is different between locally developed crate, and crate as it exists on crates.io: in the latter case, we remove all workspace structure and just store a flat list of crates.

@matklad
tried to build a crate with this patch, output this snippet:
CARGO_MANIFEST_DIR=/Users/pengtangjin/.cargo/registry/src/github.com-1ecc6299db9ec823/lazy_static-1.3.0
CARGO_WORKSPACE_MANIFEST_DIR=/Users/pengtangjin/.cargo/registry/src/github.com-1ecc6299db9ec823/lazy_static-1.3.0

I thought it was ok, any case dangerous cases I missed?

@matklad
tried to build a crate with this patch, output this snippet:
CARGO_MANIFEST_DIR=xxx/.cargo/registry/src/github.com-1ecc6299db9ec823/lazy_static-1.3.0
CARGO_WORKSPACE_MANIFEST_DIR=xxx/.cargo/registry/src/github.com-1ecc6299db9ec823/lazy_static-1.3.0

I thought it was ok, any case dangerous cases I missed?

Thanks for the PR @csmoe and sorry for the delay in review!
This sort of feature has a bit of history at this point, so I think it's worth paging that in as well. In addition to https://github.com/rust-lang/cargo/issues/7036 there's a lot more discussion on https://github.com/rust-lang/cargo/issues/3946 along with a closed PR and rationale for why the PR was closed.
Could this perhaps address some of the feedback in those threads to indicate why we would merge this instead?

Thanks for reviewing :), the problems wasn't addressed.
So, closed.


User can send fee as an input to the payment transaction

As an end-user wallet,
I want to be able to make an end-to-end transaction with a particular fee token and amount,
So that my transaction will get accepted by the operator.
This story includes a user making transaction from /transaction.create endpoint to a successful /transaction.submit_typed end to end.

Still learning walllet, are these requests made via omg-js or direct to watcher.

This story includes a user making transaction from /transaction.create endpoint to a successful /transaction.submit end to end.

@Pongch Did you mean: /transaction.submit_typed :question:

no fee, no transfer now yo


Safari can't handle identical keys across collections

Reported here: http://www.raymondcamden.com/2014/09/25/IndexedDB-on-iOS-8-Broken-Bad
What to do? The proposed solution is to use namespaced keys. Should Dexie.js provide a way to namespace the keys? It's only an issue on Safari, but that means any hybrid application that runs on iPhone has to deal with it.
Live Example (source) Notice how adding the thing, the widget disappears.

Thanks for sharing, that's serious stuff :)  I tried your sample on chrome but had to change the script include to https://rawgit.com/dfahlander/Dexie.js/master/dist/latest/Dexie.js to make it work (will serve it will correct content type).
I would not like to include a fix directly in Dexie but it would be great if it could be fixed by creating a polyfill that fixes the issue by rewriting IDBObjectStore.prototype methods to prefix and unprefix keys. But that is not a simple task because one would need to intercept get() and onsuccess callbacks from openCursor() etc. But it's doable.
Another solution for Safari may be to use the [indexedDBShim] instead if it works better than the native (http://nparashuram.com/IndexedDBShim/) but to make it work on the newest Safari browser you would have to change the __useShim() method in the source of the shim. See Issue #63.

Ah. Right. Forgot about that cross-browser MIME issue. I fixed the codepen. Thanks!
So, I don't exactly expect Dexie to have this as a normal feature. But perhaps we could have an addon and also make some architecture choices to make such an addon easier to write?
Perhaps instead there could be an easy way to use a uid generator, whether that's a guid generator or an autoincrementing id-number vending table.

Good thought. There's a guid generator included in Dexie.Observable.js that would help working around the issue. The code could be pulled out as its own plugin.
If we go the path by prefixing all keys generically, and hiding that for the API user, it would be almost easier to override the default behaviour of IDBObjectStore.prototype etc I think. Unless as you suggested, to remake the architecture to simplify writing such a plugin, which would be a good thing, but (for me at least) not possible to do in the nearest future.
Crud hooks could not solve the issue as they work today. An addon would need to override dexie methods such as db.WriteableTable.prototype.put(), db.WriteableTable.prototype.add(),db.WriteableTable.prototype.get(), db.WriteableTable.prototype.delete(), db.WriteableCollection.prototype.modify() and db.Collection.each().

As of current status of the native indexedDB support, it is better to use the WebSQL shim (IndexedDBShim) than the native. However, that shim is not 100% standard compatible so there might still be some minor issues but not as severe as Apple's own bugs in its implementation of indexedDB.
From now on, to use the shim instead of the native IDB support, just include the indexedDBShim before including Dexie. See #77 .


Memory usage by daskframe

I need to open several TTree from different files and to merge them. They are quite big and so I am using daskframe, something like this:
for info, fn in catalogue.items():
    df = uproot.daskframe(fni, "CollectionTree", branches)
    df = df.rename(columns = lambda x: x.replace('HGamEventInfoAuxDyn.', '').replace('HGamTruthEventInfoAuxDyn.', 'truth_'))     df['isPassed'] = df['isPassed'].astype(bool)
    df['mc'] = info[0]
    df['prod'] = info[1]
    all_df.append(df)

I was convinced that this was very fast, I guess you just need to known how many events you have in each TTree and the type of each branches.
On the contrary this is very slow and uses a lot of memory. See plot.
uproot: 3.10.12

I don't know what dask.frame does when it merges DataFrames, but it looks like it's evaluating them. It depends on whether they wanted "merge" to be a lazy operation (pushing the work of actually merging down to the next operation, which can multiply the number of times that it happens) or they wanted "merge" to be eager (which means that columns are loaded that might not be used later). They both have advantages and disadvantages.
As we've accumulated experience with lazy data types, I'm becoming less enamored with them. It often trades having to think up-front about what's in memory when with having to think about it later, after disaster strikes. If the delayed read and caching algorithms are perfect for a given workflow, the performance cost is still not any better than a carefully designed eager workflow, so all it buys is not having to worry about the details in cases when it works.
The laziness algorithm (when to load what, given that you want to compute a particular thing) is in the computation framework—in this case Dask. (I've had to think about it in the context of PartitionedArrays and VirtualArrays in Awkward Array, another computation framework, and there are some hard problems there.) Uproot just initiates a read when Dask asks for one.

@jpivarski: forget the merging. The plot is during the loop I have posted.

Well, any sane implementation of rename would remain lazy, but
df['isPassed'] = df['isPassed'].astype(bool)

forces an eager read. I wonder if the memory is all due to that column.
If it's the case that any other columns are being read, then that's an Uproot error.
I suppose it's also possible that the time and memory usage is due to reading the TFile and TTree metadata, which includes all the TStreamerInfo and generating Python classes for each type, for each TFile. I've been fixing exactly that in Uproot4 (since it requires deep modifications).

I tried to remove everything except for
for info, fn in catalogue.items():
    df = uproot.daskframe(fni, "CollectionTree", branches)
    all_dfs.append(df)

still I see an increase of memory (actually jupyter was killed)

How many files is it, how many branches, and how many classes? These things would add up because we need to open each file to get the metadata to Dask (the number of events and columns).

~20 files (actually the plot show only ~3 files), eight branches, these are ATLAS mxAOD so I am not sure how to reply "how many classes": they can be read by plain root and you see just a set of branches.

I meant the classes defined in the TStreamerInfo, which aren't lazily read in Uproot3. The other parameters do sound small, though.

I also see very high memory usage of daskframe. If I read a file with on disk size 2.7G, htop tells me I'm using 14.1G (RES), more than I expect considering compression (factor ~2 I would assume). Usually with dask I get minimal memory usage until I call "compute" on my dataframe.


Optimize repeat

Instead of O(n) appends, using doubling copies.

I'll re-do the benchmark changes in a separate PR. This PR is now just the optimization of repeat. And I agree, we shouldn't check in the repeat benchmarks, since we don't want to encourage micro-optimizing them.

Thanks!


Faas env

Issue to resolve:
https://adobe-mwp.slack.com/archives/C02A3PQSD51/p1682104409585409?thread_ts=1682101521.751589&cid=C02A3PQSD51

@meganthecoder  Good catch.


Refills Flashes

I’m seeing some inconsistencies with the Refills Flashes in a new Suspenders project:

application.css.scss has @import "refills/flashes";, but there isn’t actually a _flashes.scss Sass partial that exists in the stylesheets directory (nor is there a refills directory in stylesheets).
If we do have a _flashes.scss partial, it should go in a components directory, not refills. A refills directory inside stylesheets is not clear.

Related with PR: https://github.com/thoughtbot/suspenders/pull/552

Thanks Tyson! Closing in favor of PRs.


[rename] (coprocessor, leaf) -> (component, shard)

Renaming to avoid later confusion.

FYI @nyunyunyunyu


Clarification on US #427 Acceptance criteria #8

Dear Mr. Oleh
In User Story#427
In the acceptance criteria 8 it says that "After successfully creating a category, the admin user should receive a confirmation message or notification indicating that the category has been added.". Should we choose only one option either confirmation message or notification? User can get a notification on the web page that the category is successfully created, for example.
Looking forward for you reply.
Kateryna

I think everything works properly:
Запис екрану від 11.11.23 14:52:47.webm


fix(updateProperties): getFieldMask ignore gridProperties

good catch! and THANK YOU for adding a test as well 🔥
I'll try to get this merged asap

you welcome, do you mind if i do multiple dev in same PRs ? with distinct commit, i still have the problem with duplicate headers and I have a very simple solution to manage it

probably better to split - because the duplicate header stuff isn't quite as clear whereas this is a bugfix

Hi, when you will be able to merge it please ?


travis-ci and coveralls

Would you consider adding these to the main readme and to the repo?
I did a quick test and added them on a fork: https://github.com/magikstm/flight
Tested PHP:

5.5
5.6
7.0
7.1
7.2
7.3

I think they would give useful info on tests and PHP versions.
There's a related PR here: https://github.com/mikecao/flight/pull/212

I tried playing around with travis-ci and my build kept failing. Not sure what I'm doing wrong. Here is what I would see:

I submitted #393 for it.
You would need to adjust settings inside coveralls and travis-ci:
https://coveralls.io/sign-in
https://travis-ci.org/
By:

Logging-in with your github account
Linking your account inside both
Adding the repository inside both (your repositories will be listed in the first page after you log in)
Toggling the repository as active
Committing PR #393

There are more options you could adjust, but default ones would be good at first.
Let me know if you need help setupping either.

I believe the issue you are having is because of a missing or incorrect .travis.yml under the main folder of the repository. This issue should be corrected af you pull the PR above.
Travis-CI docs:
https://docs.travis-ci.com/user/languages/php/
Coveralls docs:
https://docs.coveralls.io/php
https://github.com/php-coveralls/php-coveralls

Because this has aged a bit, lemme know if you still want/need this. We're slowly making our way to do it on our own.


[main] Upgrade to latest dependencies

Cron -knative-prow-robot
/cc knative-sandbox/networking-wg-leads
/assign knative-sandbox/networking-wg-leads
Produced by: knative-sandbox/knobots/actions/update-deps
Details:
bumping knative.dev/hack 8d1e4cc...f9dc722:
  > f9dc722 Format go code (# 218)
  > 664eac5 Fixing go.mod foreach (# 217)
  > 97fd663 :gift: Support multiple Golang modules in a single project (# 205)
  > f472a96 fix go run invocation of github hub cli (# 212)
  > 7d3bed1 go run... (# 210)
  > e81d63a Update community files (# 209)
bumping knative.dev/networking e51df7c...215bac9:
  > 215bac9 httpproxy test image can setup TLS client with CA certs (# 708)
  > 7c9b49e upgrade to latest dependencies (# 707)
  > dba99c4 upgrade to latest dependencies (# 706)
  > 9d28d41 Update community files (# 705)
  > 99830de upgrade to latest dependencies (# 704)
bumping knative.dev/pkg 4a03844...93b66e6:
  > 93b66e6 Update: report stats for request (# 2584)
  > a650186 Make request body available in admission context (# 2583)
  > a6afcab Fix # 2115, allow selective verbs / subresources for webhooks. (# 2547)
  > da71919 split warnings. Fix issue: 2581 (# 2582)
  > 0a3c1d6 upgrade to latest dependencies (# 2580)
  > 5fbe0c3 upgrade to latest dependencies (# 2579)
  > 2f06d64 Update community files (# 2578)
  > 2e08ca6 WaitForServiceEndpoints doesn't take into account not found endpoint (# 2576)
  > 766f70d fix double close of channel (# 2574)

/retest
/lgtm
/approve


More django/wagtail upgrades

Codecov Report

Merging #759 (68ea7f5) into develop (2180232) will decrease coverage by 10.91%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           develop     #759       +/-   ##
============================================
- Coverage    97.46%   86.54%   -10.92%
============================================
  Files          232       12      -220
  Lines        12515      446    -12069
  Branches        66       66
============================================
- Hits         12198      386    -11812
+ Misses         317       60      -257


How can I set modal dropdown container width ?

You can see modal dropdown (Blue line) always has larger width than Dropdown item (red line). I wanna set equal width

Did you solved this? I am facing same issue

@vandiepbui I have edited by using pickerStyle={{ borderBottomColor: 'transparent',width:'90%',marginLeft:5}} as my desired.


Fix agent cache

Problem

The agent cache is now version based, this is complicated for end-users and becomes difficult in the new agent design
Time based expiry is broken: https://github.com/inmanta/inmanta-core/issues/833

Proposed solution

we keep version open for a fixed time X (e.g. 1 minute after last use ended)
we generate a 'tick' to the cache regularly (e.g. 1s) to make it run finalizes), on a threadpool  (taking care not to race actual usage.

Discussed in planning meeting. Main difficulty that needs to be addressed: discarding an entry from the cache means calling a custom finalizer, which is not async, therefore has to be run on a thread. It must only be called when the agent is not actively using the thing cached.

See status on Slack