[proposal] Fix utf8

Hi @aryeguy @dmand @undera
Currently when the labels that handle apiritif are unicode values, it does not allow its storage in csv and the generation of the same in the logs files of logging (failure apiritif making the whole test fail unexpectedly).
I enclose a proposal, unfortunately csv in python 2.x does not support utf-8 in its generation.
The people behind unicodecsv solved the problem of having a single method to generate csv by being compatible with python 2 and 3 through its library, which simply impersonates the name of csv that comes with python and it is not necessary to modify the logic, except to define the encoding of engraving.
I leave it as a proposal, the idea of this PR is not to be accepted (unless you want to finish it), since I'm not in time to invest a lot in it, but if I found the source and could prove its solution for the cases that I found.
If I can tell you that it was tested in python 2.7 and 3.5 and from this fix it is possible that apiritif correctly generate the csv and the texts in the log files (my focus is "Nose Requests" using Taurus, I did not do an extensive analysis of the support of utf8 in the project).

This is a very good find. Thank you, @3dgiordano
I've researched a similar problem with writing unicode CSV in Python 2 before, but that time i settled with manually encoding every string to bytes before dumping CSV. unicodecsv looks like a really good find.

I think i'm going to merge your PR into a separate branch and work on it a bit more.


HTTP Testing of Plugin not possible

Winter CMS Build
dev-develop
PHP Version
8.1
Database engine
SQLite
Plugins installed
No response
Issue description
I have a custom plugin with a routes.php file.
I've written a test that uses laravels HTTP Testing to test an endpoint from the routes.php file.
I use php artisan winter:test --plugin=My.Plugin to run it's tests.
The test request to any valid endpoint in that routes.php file returns the 404 page of the active theme.
The cause is that the plugin will not get registered under a PluginTestCase unless it is elevated: https://github.com/wintercms/winter/blob/develop/modules/system/classes/PluginManager.php#L338
The plugin and it's routes must get registered at this stage, to prevent the CMS routes beeing registered before the plugins routes.
So including the plugins routes manually in the test case wont work as it is too late in the process.
Steps to replicate
Create a plugin with routes.php
Create a plugin test case and use HTTP testing from Laravel (https://laravel.com/docs/9.x/http-tests#introduction) to run a test request against a route from routes.php of the plugin.
Use php artisan winter:test --plugin=Your.Plugin to run the test.
Workaround
Make the Plugin elevated: https://wintercms.com/docs/v1.2/docs/plugin/registration#elevated-permissions

@der-On this would be related to https://github.com/wintercms/winter/commit/71fcf8eef9584ddcc428809f867429118aa74129, which itself is related to an issue reporting in October years ago.
Essentially, we had to disable the plugin register() method and routes.php and init.php files within plugins when running CLI commands (such as winter:test) if the database is either unavailable or hasn't yet been configured/migrated, as multiple people would run commands for environments such as Vapor without the database being made available yet and would encounter exceptions if a plugin used a database during registration.
Personally, I'm not a fan of the fix - I think plugin developers should be more responsible and not be calling the database during registration, but I digress, since it was reported commonly enough, we had to err on the side of caution.
One thing you could do - I don't know how difficult it would be with your setup - but you could run the migrations before the tests run. If the database is available and migrated before the tests are run, you would side-step this fix.
Alternatively, we could make it so that this fix is applied conditionally (enabled by default) and could be disabled by an option to the winter:test command, but I'm not a massive fan of that either.

@bennothommo I'm already running the tests after the database is migrated. This is actually part of the PluginTestCase setUp method by default.

@der-On have the migrations been run on the test database before you run the tests?
The reason I ask is because the function that disables plugin initialization (here in the code) specifically looks for whether the migration table is set up, as winter:test itself is not a privileged CLI command. In your unit tests, you would likely be using a different database connection.

@bennothommo As far as I can tell, It uses the test database. I however did create a config/testing/database.php.

Closing this for now as there's been no follow up. If the issue persists, please let us know and we'll re-investigate.


Get App Service Plan 404 does not return an error

Bug Report

import path of package in question github.com/Azure/azure-sdk-for-go/services/web/mgmt/2018-02-01/web
SDK version e.g. 31.0.0
go version go1.12.5 darwin/amd64

Issue
I ran into an issue where I used the Get method for an app service plan and received a nil object with a 404 response but no error. I expected an error to occur because that is how the majority of this provider handles 404 errors and it's causing issues in the Terraform Azure Provider . We're implementing a workaround for now but it'd be great to get this addressed!
Reproduce
You should be able to reproduce this by doing a Get call on an app service plan that was deleted or doesn't exist

Hi @mbfrahry  It looks like the team will merge the pull request you wrote up to help you work around this temporarily. I'm leaving this to track the real fix.


What is "authcode"?

I have input the username and password of steam in example.php file.
When i hit the url if shows error
Please enter AUTHCODE available in your e-mail inbox (domain: aohholdings.se).
What is this??
How to get AUTHCODE?????????

https://support.steampowered.com/kb_article.php?ref=4020-ALZM-5519

okay! thanks for your reply,
What if i got the auth code?
Where to put it?
how to use it??

Run script
You get authcode in your e-mail inbox.
Rerun script with $SteamLogin->login('authcode here')

Okay Thanks for your reply :-)
umm one more thing to ask, you have also passed the "$twofactorcode='' is this also mandatory ?????

$twofactorcode is required, if you have active twofactor authentication on your account (code from mobile app).

Yeah thank you :-)
I used the authcode in login function and rerun my script , but it is not returning anything, the page is blank and also the json file generated consist only steamid, no sessionid and cookies were there.

Show me your script.

`<?php
define('php-steamlogin', true);
require('main.php');
$SteamLogin = new SteamLogin(array(
'username' =><EMAIL_ADDRESS>'password' => 'bambi321',
'datapath' => dirname(FILE) //path to saving cache files
));
if($SteamLogin->success){
$logindata = $SteamLogin->login('HVNVT');
/*
$logindata = array(
'steamid' => 'xxx', //64-bit
'sessionId' => 'xxx',
'cookies' => 'xxx=xxx; yyy=yyy; '
);
*/
//You can view steamcommunity.com from created session
//$SteamLogin->view('http://steamcommunity.com/id/kysune');

//Sending tradeoffers: https://github.com/halipso/php-steam-tradeoffers

if($SteamLogin->error != '') echo $SteamLogin->error;

}else{
echo $SteamLogin->error;
}
?>`
I am using the example.php file provided in the package.
thanks in advance!!!

<?php
define('php-steamlogin', true);
require('main.php');

$SteamLogin = new SteamLogin(array(
	'username' => '********',
	'password' => '********'
	'datapath' => dirname(__FILE__) //path to saving cache files
));

if($SteamLogin->success){

	$logindata = $SteamLogin->login('HVNVT');

	if($SteamLogin->error != ''){
		echo $SteamLogin->error;
	}else{
		echo 'Logged successfully!
';
		echo 'Your steamid: '.$logindata['steamid'].'
';
		echo 'Your sessionId: '.$logindata['sessionId'].'
';
		echo 'Your cookies: '.$logindata['cookies'];
	}

}else{
	echo $SteamLogin->error;
}
?>

Do you need it?

Yup got all three values. :-)
Thanks for helping :-) :-) :-)


Shortcut "Ctrl + D" of Multi-select in new document can't work normally

VSCode Version: 1.6.0 - insider
OS Version: Windows 7

Steps to Reproduce:

create a new Document: A.example(Not saved locally)
Type "Hello World"
Select first "l" (3rd letter)
Use shortcut "Ctrl + D" to select second "l" (4th letter)
Use shortcut "Ctrl + D" to select third "l" (10th letter).
But doesn't work, This make select target "ll"(Double l) but not "l"

Currently, we collapsed multiple cursors that are touching each other. To revisit if this is still really needed.

Duplicate of #6661


⚠ Bofrost.fr has degraded performance

In 2437b95, Bofrost.fr (https://www.bofrost.fr) experienced degraded performance:

HTTP code: 200
Response time: 1590 ms

Resolved: Bofrost.fr performance has improved in 2d1da09.


fun fact

"Grafika" is the word for "Graphics" in Hungarian

Also in Polish (where some of my ancestors are from).


[$1000] Web - Edit and delete button are not available for normal message in mac after changing default contact

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:
Precondition: user should have more then 1 contact method verified

Open the app
Open any report
Send few messages
Change default contact method
Revisit report opened in step 2 and hover on latest sent messages (sent in step 3)

Expected Result:
App should display edit and delete for normal messages
Actual Result:
pp does not display edit and delete for normal messages after changing default contact method
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[x] MacOS / Chrome / Safari ONLY
[ ] MacOS / Desktop

Version Number: 1.3.34-1
Reproducible in staging?: n/a
Reproducible in production?: n/a
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/93399543/c6a6a77d-3bb7-4cb8-bdab-70441e1bae98
Expensify/Expensify Issue URL:
Issue reported by:  @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1688029345913139
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~016e71cf3db941fc35
Upwork Job ID:<PHONE_NUMBER>989825536
Last Price Increase: 2023-07-01

Proposal
Please re-state the problem that we are trying to solve in this issue.
Web - Edit and delete button are not available for normal message in mac after changing default contact
What is the root cause of that problem?
After changing contact method, the reportAction is not updated with latest contact method email, so the condition inside canDeleteReportAction will be false:
if (reportAction.actorEmail === sessionEmail) {
return true;
}
What changes do you think we should make in order to solve the problem?
canDeleteReportAction function has to compare account id instead of email checking current user's message.

What alternative solutions did you explore? (Optional)
N/A

While changing to accountID is simpler, bug reporters' offline shenanigans after logging in like, login, disable network and change default contact and then try to edit kinda actions might be better addressed with Onyx loginlist.

Comparing account IDs holds significance as they serve the purpose of identifying users and acting as primary keys.
It's good to avoid adding specific code blocks solely to address edge cases.
Ideally, it is preferable to handle edge cases within the main logic of the codebase, if feasible.

@mollfpr, @MitchExpensify please take a look my proposal.
https://github.com/Expensify/App/issues/21948#issuecomment-1616776147

Not overdue, Melvin

Reviewing proposal!

This issue is not reproducible. Is fixed in the accountID migration PR https://github.com/Expensify/App/pull/22327

@mollfpr thanks, sounds like reporting payment is all thats due here - agreed?

@MitchExpensify Agree!

Awesome, invite sent here for reporting payment @dhanashree-sawant 👍  https://www.upwork.com/jobs/~016e71cf3db941fc35

@MitchExpensify, Thanks!
Offer accepted.

Awesome, paid!


Export the hadoop heapsize,

…otherwise it will use the default 256mb which is not enough for production workloads
Signed-off-by: Patrick Van Brussel<EMAIL_ADDRESS>

This repository is a read-only mirror from code in Wikimedia Gerrit.
See also https://www.mediawiki.org/wiki/Developer_account and https://gerrit.wikimedia.org/g/operations/puppet.


Highlight focused series in axis tooltip

What problem does this feature solve?
When someone hovers over a specific series, and the tooltip is shown, we need to highlight the specific series in the tooltip.
This happens when the tooltip trigger is axis.
Please see the screenshot provided for an example.

What does the proposed API look like?
When the
tooltip.formatter string, Function
is a callback function in the params Object|Array
have an property called
focused of type boolean
for each item which is true when the mouse is hovering over the item's specific series.

Hello @yufeng04 ,
I just read my description and the proposed API doesn't make any sense. I'll try to rewrite it here.
What does the proposed API look like?
Basically when we have tooltip.trigger Axis and the tooltip.formatter Callback function is called can you add a Boolean property to the params. That parameter will be called focused that will be True when the mouse is hovering over the specific series at that moment when the tooltip was triggered.
Thank you for you time and effort.
Best regards,
Sergios.

Any update here? I would love this functionality as well.


I2C: Receiving weight information from the Arduino Uno

Definition of done:

Able to receive variables via I2C from the Arduino
Able to transmit Weight information via I2C to the Pi

Reopened this issue, added more to definition of done: swapped this issue with I2C issue instead.


[RESOLVED] Interface eth0(): High error rate (>2 for 5m)

Problem started at 17:12:29 on 2023.08.01
Problem name: Interface eth0(): High error rate (>2 for 5m)
Host: S100-Primario
Severity: Warning
Operational data: errors in: 0, errors out: 0
Original problem ID: 34528
Event details in Zabbix: http://<IP_ADDRESS>/tr_events.php?triggerid=23483&eventid=34528

Problem has been resolved in 3m 0s at 17:15:29 on 2023.08.01
Problem name: Interface eth0(): High error rate (>2 for 5m)
Host: S100-Primario
Severity: Warning
Original problem ID: 34528


return UID if no pwd entry for UID

Issue
If using this library in a container that has a user UID that does not have an entry in the passwd database this will throw a KeyError during getting user login information.
KeyError: 'getpwuid(): uid not found: XXXXX'

Potential Fix
Let's handle this KeyError and just return the UID running the process instead.

any chance of getting this added?


Fix scrolling issue in InformationFragment (EXPOSUREAPP-4939)

How to test:
Can be tested on smaller devices or the font size can be increased

Link back to #2302.


External devportal url correction

Reference of external devportal  url port number is misleading.
Purpose

Describe the problems, issues, or needs driving this feature/fix and include links to related issues in the following format: Resolves issue1, issue2, etc.

Goals

Describe the solutions that this feature/fix will introduce to resolve the problems described above

Approach

Describe how you are implementing the solutions. Include an animated GIF or screenshot if the change affects the UI (email<EMAIL_ADDRESS>to review all UI text). Include a link to a Markdown file or Google doc if the feature write-up is too long to paste here.

User stories

Summary of user stories addressed by this change>

Release note

Brief description of the new feature or bug fix as it will appear in the release notes

Documentation

Link(s) to product documentation that addresses the changes of this PR. If no doc impact, enter “N/A” plus brief explanation of why there’s no doc impact

Training

Link to the PR for changes to the training content in https://github.com/wso2/WSO2-Training, if applicable

Certification

Type “Sent” when you have provided new/updated certification questions, plus four answers for each question (correct answer highlighted in bold), based on this change. Certification questions/answers should be sent to<EMAIL_ADDRESS>and NOT pasted in this PR. If there is no impact on certification exams, type “N/A” and explain why.

Marketing

Link to drafts of marketing content that will describe and promote this feature, including product page changes, technical articles, blog posts, videos, etc., if applicable

Automation tests

Unit tests

Code coverage information

Integration tests

Details about the test cases and coverage

Security checks

Followed secure coding standards in http://wso2.com/technical-reports/wso2-secure-engineering-guidelines? yes/no
Ran FindSecurityBugs plugin and verified report? yes/no
Confirmed that this PR doesn't commit any keys, passwords, tokens, usernames, or other secrets? yes/no

Samples

Provide high-level details about the samples related to this feature

Related PRs

List any other related PRs

Migrations (if applicable)

Describe migration steps and platforms on which migration has been tested

Test environment

List all JDK versions, operating systems, databases, and browser/versions on which this feature/fix was tested

Learning

Describe the research phase and any blog posts, patterns, libraries, or add-ons you used to solve the problem.

@uvindra , can you please review this PR from a technical aspect.

Corrected at line no 94 ,please review.

@arunpatil1983, as you have currently sent this fix to the 3.1.0 branch, the fix will show only in the 3.1.0 docs. Can you please send this same fix to the master branch as well so that this fix will show in future API-M docs as well.


Feature Request: Custom spirit names

Is your feature request related to a problem? Please describe.
It's not related to an issue/problem at all, just flavor.
Describe the solution you'd like
I would like the ability to give the mod a list of custom names to pull from rather than what's hardcoded.  I'm working on a modded server for a friend's twitch community and would like to have spirits/etc named after mods/vips in that community, but as I understand it all the current names are hardcoded.
Additional context
N/A :)

Configurable in /saves/<world>/serverconfig/occultism-server.toml
#Ritual Settings
[rituals]
	#By default spirit names are generated at random from lists of possible syllables.
	#If you instead want to specify the possible spirit names directly, configure a list of values here.
	possibleSpiritNames = ["atlgeek007", "VIP-2", "..."]

Will be available in https://github.com/klikli-dev/occultism/releases/tag/release%2Fv1.18.2-1.32.1

Hi @klikli-dev !
I installed a bare 1.18.2 instance with Forge 40.1.0, along with Occultism (and dependencies), JEI, and The One Probe -  my logs are spammed with
[26/04/2022 10:53:13 AM] [Thread-0/WARN] Configuration file **USERSDIR**/instances/testbed/saves/New World/serverconfig/occultism-server.toml is not correct. Correcting
Any changes I make to the file are clobbered and the possible spirit names list is empty again.


Unexpected token error with dynamic import()

I'm unable to get eslint to parse ES2015 dynamic import()s. I've searched for solutions, and everyone points to this library as a solution, but it doesn't work for me.
I created a minimal example at https://github.com/thallada/babel-eslint-dynamic-import which has more details.

Are you on the latest version? 7.2.3 is the current latest

Ah, that was the problem. The latest version works.
I followed the README which told me to run:
npm install<EMAIL_ADDRESS>babel-eslint@6 --save-dev

Shouldn't that be this now?
npm install<EMAIL_ADDRESS>babel-eslint@7 --save-dev

yeah I guess it's not updated - can you make a PR?


Adding RADOSGW Usage exporter

As this exporter now supports Luminous (current LTS release) I wanted to add it to the exporters page.

We try to avoid duplication in this list, so I'd suggest trying to work with the existing listed ceph exporter rather than creating a new one.

@brian-brazil I can certainly get in touch with the digital ocean folks who maintain the existing exporter. However my reasoning for creating a separate exporter is that these talk to different components of the cluster.
While their exporter talks directly to the cluster monitors (a component that every Ceph cluster has) this exporter is pulling data from RADOSGW nodes. The RADOSGW component is not something that every ceph cluster operator uses and may not even be installed/running.
My feeling was as RGW was a separate optional component a separate exporter made sense.
Duplication goes the separate ceph exporter may be already be supplanted by upstream ceph adding Prometheus instrumentation directly into the base ceph-manager daemon. I have not yet had a chance to deploy that however.
Thanks,
Berant

The RADOSGW component is not something that every ceph cluster operator uses and may not even be installed/running.

From the research I've done, RADOS is a core component in every cluster. The GW is just one API to access it.

You are correct that RADOS is the core of Ceph however that is not what this exporter is reporting on. This architecture page as a diagram at the top that helps show how the different components interact.
A cluster that is just doing block (RBD) say for an openstack cluster would not need any RADOSGW nodes at all, same would go for just a cluster that is providing cephfs access. A single cluster could also be providing all three.
This exporter is just for the radosgw portion (s3/swift compatable), and reports on usage stats (bytes/ops IN/OUT) for operations by bucket (GET/PUT/DEL/LIST), which allows for an operator to track and potentially bill by operation count as well as bytes IN/OUT (like AWS S3 does).
It also exports total data on disk by bucket/user for an operator that is just billing based on bytes stored
Any transactions done either directly via LIBRADOS, RBD, or cephfs would not show up in RADOSGW usage data as those interactions don't go through the RADOSGW API.
Thanks,
Berant

Thanks for the explanation.
The way you are exposing the category label doesn't follow the rules for labels, as it's not a partition across the space. I'd suggest info metrics with this information rather than double counting in the main metrics.
Taking secrets via command line is unwise, as they'll be exposed to everyone on the machine.
radosgw_usage_bucket_total is a Gauge so shouldn't end in _total, and should also have a unit.

Brian,
Thanks for the feedback, I'll work to address those and let you know when it is pushed.

@brian-brazil I've corrected the gauge (removed _total and added base unit).
For the credentials, while it does accept the access/secret keys via command line it also does via environment variable. Would you prefer eliminating the option for passing it via argument or is calling out the security ramifications in the docs and recommending using an env variable sufficient? There seems to be a smattering of both among the exporters.
Regarding the category label, forgive my misunderstanding, however I'm not grasping how what I'm doing isn't a partition across the space. To me these seem the same:
radosgw_usage_ops_total{bucket="test",category="list_bucket",owner="nano"} 2.0
radosgw_usage_ops_total{bucket="test",category="put_obj",owner="nano"} 1.0
Where "category" is somewhat analogous to HTTP method.
And this from the haproxy exporter:
http_requests_total{code="200",handler="prometheus",method="get"} 2.287328e+06
haproxy_server_http_responses_total{backend="radosgws",code="2xx",server="radosgw02"} 7.2825603e+07
An info metric (as used to specify a software version) wouldn't be able to capture the timeseries for the number of operations of a given category.
Thanks again for the feedback, I appreciate it.

I can't merge this until you add the DCO.

Where "category" is somewhat analogous to HTTP method.

My interpretation from the code is that a bucket can be in multiple categories, which is not the same as http method.

For the credentials, while it does accept the access/secret keys via command line it also does via environment variable. Would you prefer eliminating the option for passing it via argument or is calling out the security ramifications in the docs and recommending using an env variable sufficient? There seems to be a smattering of both among the exporters.

I personally would go for a file as env vars are not designed for secrets, but getting it off the command line is the important thing.

If that's the name in the docs, then that's best.
I'd do a git rebase -i master, squash down to one commit, and then amend that commit.

gah, now I borked it even more. yay.

Yeah, I'll close this PR and resubmit.


Deploy environment

This issue serves to track efforts to bootstrap the following processes:

Train state storage (aka collection)
User-accessible frontend

Current plan:

Ubuntu with two containers: one for pull and one for display
Docker + docker-compose
Job scheduler to pull every minute

The docker-compose environment now mostly works in deploy-env branch—having an issue where the cgi container needs to be restarted once before it will populate with mysql info. Investigating...

In pull request #28


Resolve spellcheck NodeJS alerts

Resolve spellcheck node alerts
spellcheck
Node.js 12 actions are deprecated. Please update the following actions to use Node.js 16: actions/checkout@v2. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/.
build-and-deploy
Node.js 12 actions are deprecated. Please update the following actions to use Node.js 16<EMAIL_ADDRESS>actions/setup-node@v2. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/.
build-and-deploy
The save-state command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

Fixed -- warnings are no longer showing up in PRs


Plugin's filtered by 'enabled' in OpenAPI config

Closes #3153

Closing this PR as the root issue has already been resolved but wasn't closed. I really appreciate your efforts, though - please see https://github.com/Kong/insomnia/issues/3153#issuecomment-984164092! 🙌🏽


fix: extra quotation marks will be added when execute edit-save action repeatly

Reproduce

Input a char ", and save;
Click the tick icon to save, the tree node value will be ";
Edit and save again, the  tree node value will be  """;
repeat again.... quotation marks grows... :)

Fixes
By trimming the extra quotes when eval(newValue) throws an error to prevent the extra quotes.

Thanks for the PR👍, and putting the pure function resolveEvalFailedNewValue into the utils.ts file may be better.

Thanks for the PR👍, and putting the pure function resolveEvalFailedNewValue into the utils.ts file may be better.

Good idea. resolveEvalFailedNewValue now moved to utils.ts.


How will LFO/facility admin data flow in our system between Reg. & Rep.?

LFO's need to submit facility-level data for Reporting, but what information will be required for Registration at the facility level?
What specific administrative data from facilities is required (if at all?) for registration? How does this flow into reporting?
Acceptance Criteria:

[x] Sync up with Hanna on work to date from Registration
[x] Pull in registration fields marked priority 2 & 3 (can be found in SME channel reg. fields spreadsheet)
[ ] Create a list of unknowns, framed as clear questions for the business area (and who should answer each one)
[ ] Map out + add to our blueprint where in our system LFO/IF admin data should live; what does this process look like for the users?

Goal of this ticket:
Confirm high-level process for how facility-level admin data is entered into our system

@hannavovk tagging you so you're aware of this ticket. As of oct 18th the understanding is that LFO facility data will NOT be part of the Registration MVP. The business area is still figuring out whether this data will end up in registration or reporting, so still to be confirmed.

Some outcomes from the wireframe party session on Tuesday, 12th December:

To decide: We talked about how to position Registration + Reporting in the app. Will it be separate apps for each (separate domain links?) Will it look appear as one app or separate to the external user?

To decide: How will we add Tier 2 & 3 fields in Registration for post-MVP? From a technical perspective, what would make more sense: adding those additional fields to our forms when the user needs to complete them for their remaining OBPS registration? When do we add those, right before reporting requirements start so they can submit both together or much in advance? This requires some regulation info from business area for weighing in too. We also want to know if the business area wants to validate the Tier 2 & 3 fields as well, so that would mean validating twice in the app.

To design: I'd be happy to take a stab at some really lo-fi mockups for the above and present them as options to the business area once we have some internal understanding as to how we want to proceed.

Work done:

Held 2 wireframe parties
Made a rough map of how this data will be handled
Made some rough wireframes


force:source:retrieve cannot retrieve a package version

Is your feature request related to a problem? Please describe.
I have a managed package which was created sometime ago. Since then numerous developers have made changes in the dev org. I would like to retrieve the unedited code from a specific package version. The package version is still available to install but I cannot retrieve the code base of that version.
Describe the solution you'd like
I would like the force:source:retrieve command to have an extra flag when using the [-n PACKAGENAMES] flag so I can specify exactly which version is it that I want to retrieve, defaulting to the most recent.
Describe alternatives you've considered
There are no real alternatives that I have found. I'm not sure it's possible to do this without enhancement of the SFDX CLI

@CiaranShocks I think you can go to your git repository and then releases and find the package version you are looking for.  Then you do a checkout on that hash to get the sources for that particular version.

@AllanOricil I probably should have been more specific and mentioned that this use case is for pulling a specific package version from a 1GP managed package in a dev org. There is no git repo or project associated with it.

@CiaranShocks Thank you for the feature request!
Unfortunately, retrieving a specific package version is not supported by the Metadata API.
I'm going to close this issue for now, please feel free to comment if we have missed something.


fix: export TableFooter from ui/table components

❓ Type of change

[ ] 📖 Documentation (updates to the documentation, readme or JSdoc annotations)
[x] 🐞 Bug fix (a non-breaking change that fixes an issue)
[ ] 👌 Enhancement (improving an existing functionality like performance)
[ ] ✨ New feature (a non-breaking change that adds functionality)
[ ] 🧹 Chore (updates to the build process or auxiliary tools and libraries)
[ ] ⚠ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description
The TableFooter was removed from the ui/table export. Can't see a reason for it in the history so adding it back as an exported item.
I haven't opened an issue or discussion because this is such a minor issue that I didn't feel going through a repro step was necessary.

Please run
pnpm build:registry

in apps/www, Thanks

Done.


[Backport] [1.3] Routine dependency updates: Netty 4.1.91.Final, ASM 9.5, ByteBuddy 1.14.3 (#6981) (#6986) (#7005)

Backport of https://github.com/opensearch-project/OpenSearch/pull/6981 to 1.3

Codecov Report

Merging #7021 (8dc830e) into 1.3 (4b0acb3) will decrease coverage by 0.08%.
The diff coverage is n/a.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@             Coverage Diff              @@
##                1.3    #7021      +/-   ##
============================================
- Coverage     77.90%   77.83%   -0.08%
+ Complexity    63460    63433      -27
============================================
  Files          4454     4454
  Lines        274964   274964
  Branches      41167    41167
============================================
- Hits         214209   214005     -204
- Misses        43855    44049     +194
- Partials      16900    16910      +10

see 454 files with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Cannot type symbols using option + key

Describe the bug
Whenever I try to type any symbol using option + key it doesn't work and I get an invalid key sound.
To Reproduce
Steps to reproduce the behavior:

Go to any dialog
type option + any key

Expected behavior
The symbol I want to type appears.
Screenshots
None.
Desktop (please complete the following information):

MacOS Version: Monterey 12.6
Device Macbook Pro
Year 2022

Additional context
I'm using the Italian keyboard layout.
If I type the symbols on another program then copy and paste them everything works.
Thanks for this amazing program! I've been using it for a while and this is the only issue I've had since then.

Hello!
So as for symbols, Ive actually only ever needed to use !@#$%^&()*, from using the Shift+Any Key combination.
And until now, I didn't even know that pressing the Option+Any Key combination was used to make any extra symbols!
Those symbols aren't labeled on the American keyboard, but I just Googled the Italian keyboard and I see exactly what you're talking about.
I will definitely look into this later today and let you know when I fix it!
And thank you very much for the kind words, I appreciate it! 😀

Hello again @rhxto ! It should be all fixed now.
Here's the update: https://github.com/jostasik/Flowgorithm-macOS/releases/download/testing-v<IP_ADDRESS>/Flowgorithm-macOS-v<IP_ADDRESS>.zip
Please let me know if this fixes the issue for you as well!
I'll then publish this as an official update 😊

Everything works now!
Thank you for all the support.


Multiline values formatting

This (it comes from sample nginx magento snippet)
gzip_types
    text/plain
    text/css
    text/js
    text/xml
    text/javascript
    application/javascript
    application/x-javascript
    application/json
    application/xml
    application/xml+rss
    image/svg+xml;

is converted to
gzip_types
text/plain
text/css
text/js
text/xml
text/javascript
application/javascript
application/x-javascript
application/json
application/xml
application/xml+rss
image/svg+xml;

Could it format such multiline values the padded way?

In fact, this is a matter of style. Perhaps, current formatting is preferred for some, as shown in #9. I'll probably make an option in FormatterOptions for it. Leaving it open for now.


Network permission removal in seperate release?

Hello,
so far yetCalc seems to be more stable and feature packed than other calculators i've seen.
My only concern is the network permission, if its not too much of an extra maintenance burden, could you create a 2nd release apk that has network permission removed and just have the features that require it disabled or removed?

Couldn't you just disable the app from using the network in Settings?

@ExperiencersInternational My phone (Pixel 6) runs stock AOSP, no it doesn't have such an option. I could use a firewall, like netguard, but there are times where during restart it takes time for the firewall to startup. Though if app doesn't need network, it shouldn't have such a permission.
Since app is open-source I suppose I could do it myself, its just something that I would have to do each time an update is released.

@dhammel tbh I just don't see why as a developer you would go out just to remove the internet components
I haven't used stock AOSP since around 2017, so I really can't say much.

@ExperiencersInternational Apps that don't need internet for its functionality shouldn't have them, for privacy reasons. As far as I see, currency conversion is the only feature needing internet but i have no need for currency conversion. Some may, which is why I suggested a seperate apk, rather than removing it outright.

@dhammel I understand your concern. However, the currency conversion tab only sends an API request to exchangeratehost if the field values are not empty. Also, before doing that it checks if you have a stable internet connection. This way it never sends any data outside without your actions.
If that is not satisfiable, then you can select any other tab for example 'Length'. Since 'Use Recent Tab' setting is enabled by default, it will never load the currency tab. Note that the currency tab would still get added to the tabs tho.
Removing the internet permission entirely would be to remove the currency tab itself, that would not be hard but maintaining every release might. Do you still want a separate release?

@Yet-Zio The main reason for removing a network permission is that when people would see that a calculator app has one, it would  be a concern, unless the user reads over the source code himself it would come down to trust.
As I said though, if its too much work to maintain every releaee then i wouldn't bother.

@dhammel that is true, but if I did remove network permission and currency conversion, then I would need to make sure everything works when I make changes to Unit Conversion Activity and related settings and confirm that there are no issues on both sides, this would be tiresome as I already don't get time nowadays due to college and other things.
Maybe I should instead add an intro tour later with doubts on faq.


Add optimizations to primitives

After some performance testing using V8, I found some minor tweaks I could make to Haystack Core that will make a difference to its performance. I'm sure there are more. However these changes are based on real tests and seem to have an impact in my tests...

Stop using Object.freeze for primitive values that are not interned.
Prefer typeof over valueIsKind where possible.
Stop using interning for HSymbol using memoize. It adds an necessary overhead.

Interesting changes! For my education, what was the reason for transitioning away from Object.freeze? And what does it mean for an object to be interned?

I found that freezing an object had a performance penalty. Therefore I'm removing it.
It's a shame since freezing an object meant that it could never been changed. Hence keeping it purely immutable.

I found that freezing an object had a performance penalty. Therefore I'm removing it.
It's a shame since freezing an object meant that it could never been changed. Hence keeping it purely immutable.

A shame indeed! But understandable tradeoff as well.


all: rename module name to github.com/opentofu/registry and sort imports

OpenTofu organization has been renamed from opentffoundation, but there is still use of the previous name in the Go module.
Rename it and sort the import section via goimports.

/cc @RLRabinowitz

Hi! Right now the registry repo is not accepting contributions, but this issue is very correct.
I will make sure the module name gets changed tomorrow morning.
As for the import ordering, we have an issue to introduce golangcilint properly in this repo with issue #19, Once that is bought in we will sort the imports there too.

The imports are now solved by #19

Rename was resolved in #88 , closing this now.
Thank you anyway for your contribution.

@Yantrio 🙏


LinearSelector end_points property

I have no idea why we have size as a kwarg, end_points makes much more sense...

nevermind, let's just do mean([min, max])

Thinking about it again, end_points actually makes more sense as a property than size. We should change it in the constructor too.


Add GitFlow support

I would like to suggest you to provide a GitFlow implementation in your plugin, following this article.
Reference implementation (GitFlow CLI): https://github.com/nvie/gitflow
Just for comparison: Atom's plugin git-control provides a frontend for GitFlow CLI, while Visual Studio Code's plugin vscode-gitflow has its own implementation.

Thanks @lbssousa , great suggestion. Though it make take some time until I'll be able to implement this.


Save a group as a PNG

how to save a group as a PNG?

You will need to recursively go over the layers of the top node of the group you want to save and save each one of them over the parent node's image

You will need to recursively go over the layers of the top node of the group you want to save and save each one of them over the parent node's image

I try all the way to achieve the function but fail.some like this:
`      complieGroup(group,ctx){
let lays=group.children().reverse();
if(!ctx){
ctx=document.createElement('canvas').getContext('2d');
ctx.canvas.width=group.width;
ctx.canvas.height=group.height;
}
lays.forEach((la)=>{
if(la.export().type==='group'){
this.complieGroup(lays,ctx);
}else {
let layerImage = new Image();
ctx.globalAlpha= la.layer.image.opacity;
layerImage.src = la.layer.image.toBase64();
ctx.translate(la.left-group.left,la.top-group.top);
ctx.drawImage(layerImage,0,0)
}
    });

    return ctx.canvas;
  },`

is there any example?

`const compositeGroupOrLayer = async group => {
let info = group.export();
let children = group.children().reverse();
let img = sharp({
create: {
width: info.width,
height: info.height,
channels: 4,
background: { r: 0, g: 0, b: 0, alpha: 0 }
}
});
let childPngs = [];
for (let i = 0, len = children.length; i < len; i++) {
let buf;
let childInfo = children[i].export();
if (children[i].isGroup()) {
buf = await compositeGroupOrLayer(children[i]);
} else {
buf = await toBuf(children[i].toPng().pack());
}
let image = {
  input: buf,
  top: childInfo.top - info.top,
  left: childInfo.left - info.left
};

childPngs.push(image);

}
let buf = await toBuf(img.png().composite(childPngs));
return buf;
};`

Your idea is almost the same as mine. And I succeeded with nodejs;
But, I cannot resolve mask and layer style.￣へ￣.
  let info = group.export();

  let children = group.children().reverse();

  let img = sharp({
    create: {
      width: info.width,
      height: info.height,
      channels: 4,
      background: { r: 0, g: 0, b: 0, alpha: 0 }
    }
  });
  let childPngs = [];

  for (let i = 0, len = children.length; i < len; i++) {
    let buf;
    let childInfo = children[i].export();
    if (children[i].isGroup()) {
      buf = await compositeGroupOrLayer(children[i]);
    } else {
      buf = await toBuf(children[i].toPng().pack());
    }

    let image = {
      input: buf,
      top: childInfo.top - info.top,
      left: childInfo.left - info.left
    };

    childPngs.push(image);
  }

  let buf = await toBuf(img.png().composite(childPngs));

  return buf;
};```

Hi @tinypoint ,
I'm interested in your solution. Can you please share your toBuf()function as well?
I tried to transform the input stream to a buffer, but it doesn't work.


[Feature Request] Update naming for OpenAIFunction

Required prerequisites

[X] I have searched the Issue Tracker and Discussions that this hasn't already been reported. (+1 or comment there if it has.)
[ ] Consider asking first in a Discussion.

Motivation
The class "OpenAIFunction" doesn't actually require OpenAI, it's a legacy name from earlier development.we can renaming it to something more fitting, like "CamelTool."
Solution
No response
Alternatives
No response
Additional context
No response

I would like to give this a try, could you assign it to me?

Hey @tom-doerr , thank you for your willingness to contribute! We're planning to rename OpenAIFunction to FunctionTool. However, if you have any alternative name suggestions, we’re open to discussing them. I've assigned this issue to you.

I renamed OpenAIFunction to FunctionTool.
However not all tests pass for me, even before I renamed it, see discussion: https://github.com/orgs/camel-ai/discussions/910

I renamed OpenAIFunction to FunctionTool. However not all tests pass for me, even before I renamed it, see discussion: https://github.com/orgs/camel-ai/discussions/910

Thanks @tom-doerr! You can create the PR directly, if the failed test is not related to your change but just due to lack for API Keys then we can ignore those failed test

Just added a PR that is almost just renaming OpenAIFunction.
There are however still functions that include openai, e.g.
    def validate_openai_tool_schema(

I also worked on renaming those and renaming the files that are referencing OpenAI functions, however that breaks backwards compatibility.
Should I rename them and add the old function/filenames that throw a deprecation warning when used?

thanks @tom-doerr ! For this method it's indeed related to OpenAI since it's validating whether the schema follow's OpenAI's required format, so I'd suggest don't rename this method


Fixed a typo in second task name in Suse.yml

Hey @fishtenors, thank you for the typo fix.
Sometimes, these things just pass through...


Offline message not showing in Country and State selection screen

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Go offline -> Go to settings
Click profile -> Click personal details
Click home address-> Click State/Country

Expected Result:
It should show offline message like other screens
Actual Result:
Country/State picker not showing offline message
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[ ] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: 1.3.49-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/43996225/08f87975-9356-43d7-96c7-ddead6724d23
https://github.com/Expensify/App/assets/43996225/69859d3d-966b-4796-b7bb-ed21ca50be72
Expensify/Expensify Issue URL:
Issue reported by: @DinalJivani
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1690741191378189
View all open jobs on GitHub

It seems like there's more to this issue than just the offline indicator not showing up on those pages when you switch to airplane mode. In the second video, you can't even load the personal details screen while offline, which I think you should be able to do.
@jasperhuangg do you think there's a chance this is also related to the recent changes around personal details?

Asked Jasper in the original Slack thread.

This issue is covered in this PR https://github.com/Expensify/App/pull/24164

The other PR fixed this issue as well, closing 👍


[Bug]: save_best_only=True breaks WandbModelCheckpoint

Describe the bug

Description
In the _check_filepath it states that when using save_best_only = True, I must ensure that the filepath argument contains formatting placeholders like {epoch:02d} or {batch:02d} to ensure correct interpretation of the logged artifacts.
However, when doing this, the WandbModelCheckpoint callback fails if the model does not improve on the given metric. When the model does not improve, it is not saved locally, and therefore, it also fails to upload to W&B. WandbModelCheckpoint does not check if the file exists before trying to upload it.
To demonstrate this issue, I have generated a minimal working example:
import wandb
from wandb.integration.keras import WandbModelCheckpoint
import os
import numpy as np

import tensorflow as tf

wandb.init(project="wandb_keras_callback_bug")

# Create a simple model
model = tf.keras.Sequential([
    tf.keras.layers.Dense(10, input_dim=10, activation='relu'),
    tf.keras.layers.Dense(1, activation='linear')
])

# Compile the model with a very high learning rate, makes sure model does not improve every epoch
model.compile(optimizer=tf.keras.optimizers.SGD(learning_rate=10),
              loss='mean_squared_error')

callback = WandbModelCheckpoint(
    os.path.join("/playground/models/", wandb.run.name,"_epoch_{epoch:02d}" + "_min_val_loss.h5"),
    monitor="loss",
    verbose=1,
    mode="min",
    save_best_only=True,
    save_weights_only=False,
    )

model.fit(
    x=np.random.rand(100, 10),
    y=np.random.rand(100, 1),
    epochs=5,
    callbacks=[callback]
)

This code fails with the following error:
Epoch 1/5
1/4 [======>.......................] - ETA: 1s - loss: 2.4207
Epoch 1: loss improved from inf to 144019552.00000, saving model to /playground/models/volcanic-blaze-14/_epoch_01_min_val_loss.h5
4/4 [==============================] - 1s 95ms/step - loss: 144019552.0000
Epoch 2/5
1/4 [======>.......................] - ETA: 0s - loss:<PHONE_NUMBER>168.0000
Epoch 2: loss did not improve from 144019552.00000
Traceback (most recent call last):
  File "mre_test.py", line 32, in <module>
    model.fit(
  File "/usr/local/lib/python3.8/dist-packages/wandb/integration/keras/keras.py", line 176, in new_v2
    return old_v2(*args, **kwargs)
  File "/usr/local/lib/python3.8/dist-packages/wandb/integration/keras/keras.py", line 176, in new_v2
    return old_v2(*args, **kwargs)
  File "/usr/local/lib/python3.8/dist-packages/wandb/integration/keras/keras.py", line 176, in new_v2
    return old_v2(*args, **kwargs)
  File "/usr/local/lib/python3.8/dist-packages/keras/utils/traceback_utils.py", line 67, in error_handler
    raise e.with_traceback(filtered_tb) from None
  File "/usr/local/lib/python3.8/dist-packages/wandb/integration/keras/callbacks/model_checkpoint.py", line 145, in on_epoch_end
    self._log_ckpt_as_artifact(filepath, aliases=aliases)
  File "/usr/local/lib/python3.8/dist-packages/wandb/integration/keras/callbacks/model_checkpoint.py", line 161, in _log_ckpt_as_artifact
    raise FileNotFoundError(f"No such file or directory {filepath}")
FileNotFoundError: No such file or directory /playground/models/volcanic-blaze-14/_epoch_02_min_val_loss.h5

Possible duplicates issues
#6423 This feature request seems to have gone stale last year. Has this been abandoned?
#6169 Not directly related.

Hey @GabrielGosden Good day and thank you for reporting this issue to us! I tried to run the script you shared and I received:
The filepath provided must end in `.keras` (Keras model format). Received: filepath=/playground/models/sandy-deluge-2/_epoch_{epoch:02d}_min_val_loss.h5

I assume this is because I am using a different environment but do you know if you have seen this similar error when you are trying it from your end?
Additionally, may I know your current SDK version when you were building your experiment? You can get this by running wandb --version.

Hi @paulosabile-wb,
Thanks for your reply.

The filepath provided must end in `.keras` (Keras model format). Received: filepath=/playground/models/sandy-deluge-2/_epoch_{epoch:02d}_min_val_loss.h5

I assume this is because I am using a different environment but do you know if you have seen this similar error when you are trying it from your end?

I have not seen this error before. If i remove the {epoch:02d}" placeholder i can use WandbModelCheckpoint to upload .h5 files without issues.

Additionally, may I know your current SDK version when you were building your experiment? You can get this by running wandb --version.

My error for not specifying the SDK version. We are using wandb==0.18.5

I have the same issue. My wandb version is 19.0, and I use python 3.12.7. For me, the problem occurs for weights.h5 and .keras paths.


Plain text password encryption

In the password writeback TLS section it says the plain text password is encrypted with a public key but it should be a symmetric key based on the sections above.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: ebc51bb0-dd9d-cb3f-3e3f-b9765b48f21d
Version Independent ID: d597a70e-8fb1-0e4e-8ae0-e3cd87de1118
Content: On-premises password writeback with self-service password reset - Azure Active Directory
Content Source: articles/active-directory/authentication/concept-sspr-writeback.md
Service: active-directory
Sub-service: authentication
GitHub Login: @Justinha
Microsoft Alias: justinha

@AlexFilipin Thank you for your feedback . We will investigate and update the thread.

@AlexFilipin Thanks for your comment! It actually is encrypted by both. Specifically, the passwords themselves are encrypted with the Public key, then the entire request + metadata is encrypted with the symmetric key.

#please-close

There is one sentence that says

When the user selects Submit, the plaintext password is encrypted with a symmetric key created during the writeback setup process.

And one that says

When a password reset or change operation occurs in the cloud, the plaintext password is encrypted with your public key.

I understand that the password is encrypted and then the entire request BUT the two sentences above both refer to the plain text password and are contradictory.


Updating README.md

Updating README.md to improve readability and add context.
Updating buildspec.yml to enable ecs staging deploy.

Looks like this won't be published. Someone still needs to redo the readme.


Add Nexmo Gateway

I'd like to add a gateway for the Nexmo Verify service. I work for Nexmo, and I'm happy to implement the gateway and maintain it. I've opened this ticket for discussion, because I didn't want to supply an unwanted PR.
Is this proposed gateway something you'd be prepared to merge?

@judy2k I'd read @Bouke 's comments on https://github.com/Bouke/django-two-factor-auth/pull/215
There's also the option to make the Nexmo gateway a separate package, so I'd keep that mind if you do go ahead and make a PR.


Add support for stateful functions using the bookie as state storage

Motivation
Enables support for using the Pulsar bookies as persistent state storage for functions.
Modifications

Added an option to enable/disable using bookies as state storage
Adds extra server components options to the bookkeeper to enable necessary features for bookies to be used as state storage
Adds stateStorageServiceUrl to the broker configmap

Verifying this change

[ ] Make sure that the change passes the CI checks.

is this change abandoned? state storage is currently not working on k8s deployments

Thanks for your contribution @Ethan-Merrill!


Fix 'Allow select actions' wording and description

Replaces PR: https://github.com/github/docs/pull/941, and done in collaboration with @Simran-B
Why:

The description for Allow select actions does not mention that local actions are also allowed when using that setting.
The docs incorrectly name the setting Allow specific actions, when the label in the UI is Allow select actions.

What's being changed:
Adds some wording to the description stating that local actions are also allowed, and fixes the label text.
Stage previews:

https://docs-1112--lucascostiallow-spe.herokuapp.com/en/free-pro-team@latest/github/administering-a-repository/disabling-or-limiting-github-actions-for-a-repository
https://docs-1112--lucascostiallow-spe.herokuapp.com/en/free-pro-team@latest/github/setting-up-and-managing-organizations-and-teams/disabling-or-limiting-github-actions-for-your-organization
https://docs-1112--lucascostiallow-spe.herokuapp.com/en/free-pro-team@latest/github/setting-up-and-managing-your-enterprise/enforcing-github-actions-policies-in-your-enterprise-account

Check off the following:

[x] All of the tests are passing.
[x] I have reviewed my changes in staging.
[x] For content changes, I have reviewed the localization checklist
[x] For content changes, I have reviewed the Content style guide for GitHub Docs.

Thanks for the original content for this, @Simran-B! Because I'm the creator of this PR, we have to wait until someone else on the docs team reviews and approves it 🙂

joshmgross said that

Local actions also includes any within an enterprise account.

It still doesn't say so here:

When you enable local actions only, workflows can only run actions located in your repository or organization.

<EMAIL_ADDRESS>

It still doesn't say so here:

Should we improve the description of "local actions" in this PR too?

Ah, yes! Thanks for calling that out. Done in https://github.com/github/docs/pull/1112/commits/271c99ac4d430815d7a76a7a0924ba4aa0376525 🚀
I'll get this merged 🚢

Send perfactmon money-05001eced277062d2577f1c7ae43e96e85b76916


📦 switch to pnpm

Use pnpm rather than yarn. Possible with --no-package option for vsce

Why go back to npm after this?


SetNetworkBootstrapKeys: panic: runtime error: index out of range

Output of docker version:
Client:
 Version:      1.12.0-dev
 API version:  1.25
 Go version:   go1.6.2
 Git commit:   8b72f10-unsupported
 Built:        Wed Jun 29 06:15:22 2016
 OS/Arch:      linux/amd64
 Experimental: true

Server:
 Version:      1.12.0-dev
 API version:  1.25
 Go version:   go1.6.2
 Git commit:   ad44f49-unsupported
 Built:        Wed Jul  6 02:40:54 2016
 OS/Arch:      linux/amd64

Server: https://github.com/docker/docker/commit/ad44f49470bec84143ce73f51698bc9bbb501425
The client version should be unrelated to the issue
Output of docker info:
Containers: 6
 Running: 0
 Paused: 0
 Stopped: 6
Images: 137
Server Version: 1.12.0-dev
Storage Driver: aufs
 Root Dir: /var/lib/docker/aufs
 Backing Filesystem: extfs
 Dirs: 163
 Dirperm1 Supported: true
Logging Driver: json-file
Cgroup Driver: cgroupfs
Plugins:
 Volume: local
 Network: host null overlay bridge
Swarm: active
 NodeID: b5icgbjvy2bimk78g0wu65qwo
 IsManager: Yes
 Managers: 1
 Nodes: 1
 CACertHash: sha256:0654f9b254b966315063adc91d6ad298b8147c12a6184dfe5ad878a068241941
Runtimes: runc
Default Runtime: runc
Security Options: apparmor seccomp
Kernel Version: 4.4.0-28-generic
Operating System: Ubuntu 16.04 LTS
OSType: linux
Architecture: x86_64
CPUs: 4
Total Memory: 14.69 GiB
Name: ws01
ID: SN3T:CNK6:JKQD:54CY:XKF2:BRX3:CIRU:DQBT:6DVZ:VWQ2:Q5ET:F23L
Docker Root Dir: /var/lib/docker
Debug Mode (client): false
Debug Mode (server): true
 File Descriptors: 32
 Goroutines: 119
 System Time: 2016-07-07T01:31:16.207468965Z
 EventsListeners: 0
Registry: https://index.docker.io/v1/
WARNING: No swap limit support
Insecure Registries:
 <IP_ADDRESS>/8

Steps to reproduce the issue:

Create a swarm cluster (just single node is enough)
Wait for hours.

When I hit the issue, I was not running any service, although perhaps running some non-service containers.
Describe the results you received:
DEBU[43206] Adding key 45455
DEBU[43206] Primary Key 9c664
DEBU[43206] (*Agent).run exited                           module=agent
panic: runtime error: index out of range

goroutine 77 [running]:
panic(0x1ae9c40, 0xc82000e0b0)
        /usr/local/go/src/runtime/panic.go:481 +0x3e6
github.com/docker/libnetwork.(*controller).getPrimaryKeyTag(0xc82029a690, 0x1f3a4e0, 0x10, 0x0, 0x0, 0x0, 0x3)
        /go/src/github.com/docker/docker/vendor/src/github.com/docker/libnetwork/agent.go:312 +0x2ab
github.com/docker/libnetwork.(*controller).handleKeyChange(0xc82029a690, 0xc82208a2a0, 0x3, 0x4, 0x0, 0x0)
        /go/src/github.com/docker/docker/vendor/src/github.com/docker/libnetwork/agent.go:141 +0x766
github.com/docker/libnetwork.(*controller).SetKeys(0xc82029a690, 0xc82208a2a0, 0x3, 0x4, 0x0, 0x0)
        /go/src/github.com/docker/docker/vendor/src/github.com/docker/libnetwork/controller.go:270 +0x35f
github.com/docker/docker/daemon.(*Daemon).SetNetworkBootstrapKeys(0xc82036da00, 0xc82208a2a0, 0x3, 0x4, 0x0, 0x0)
        /go/src/github.com/docker/docker/daemon/network.go:175 +0x6d
github.com/docker/docker/daemon/cluster/executor/container.(*executor).SetNetworkBootstrapKeys(0xc8208dd980, 0xc822153ee0, 0x3, 0x4, 0x0, 0x0)
        /go/src/github.com/docker/docker/daemon/cluster/executor/container/executor.go:136 +0x2e1
github.com/docker/swarmkit/agent.(*Agent).handleSessionMessage(0xc820430070, 0x7f428e563d98, 0xc820b695c0, 0xc820f0a280, 0x0, 0x0)
        /go/src/github.com/docker/docker/vendor/src/github.com/docker/swarmkit/agent/agent.go:265 +0x5ca
github.com/docker/swarmkit/agent.(*Agent).run(0xc820430070, 0x7f428e563d98, 0xc820b695c0)
        /go/src/github.com/docker/docker/vendor/src/github.com/docker/swarmkit/agent/agent.go:170 +0xbe6
created by github.com/docker/swarmkit/agent.(*Agent).Start
        /go/src/github.com/docker/docker/vendor/src/github.com/docker/swarmkit/agent/agent.go:81 +0x37d

Describe the results you expected:
It should not panic.
Additional information you deem important (e.g. issue happens only occasionally):

I could not reproduce the issue.
Maybe the discussion should be moved to docker/libnetwork or docker/swarmkit, but I am not sure yet.

ping @mavenugo PTAL

@sanimej It seems the issue is seen during key rotation. Can you PTAL ?

@AkihiroSuda Did you initialize the cluster with a rc2 or older binary and then upgraded to the current version ? After RC2 one of the change was to generate separate keys for overlay data encryption. If the cluster was initialized with an earlier binary it won't have those keys and could cause this panic during key rotation.
Please create a new cluster with RC3 or the latest master docker and confirm this crash is not seen ?

@sanimej: We should update the code to check for for this condition instead of panicing. Even though the keys should be created by default, I think robustness when dealing with objects created by a previous version is important.

@sanimej perhaps so, and I'm not seeing the issue after re-init.

Merged a change in libnetwork that makes this code more defensive: docker/libnetwork#1371.
It shouldn't be possible to trigger the panic anyway with a cluster bootstrapped in Docker 1.12.0.


A setting for whether the video stream and displayed snapshots are mirrored

Our use case of this package is that we are taking pictures of product labels. Obviously, to make it easier to read the text, it would be better for us if the video stream and displayed snapshots were not mirrored.
Currently, there is no way to configure this as it seems to be hardcoded into the package. To me, it would make sense if the existing "mirror" setting was able to control this. According to the documentation, this setting only currently affects whether the uploaded snapshots are mirrored or not.

Interesting. So who is supposed to read the text? If it's your reviewing staff on the server side then the existing mirror option that controls upload should be enough. Is it the user while they review the image before upload? User can probably read the text better off the product they hold in their hand anyway...
If you don't like the default behavior consider setting this CSS style on the camera's parent element:
https://stackoverflow.com/questions/5406368/can-you-use-css-to-mirror-flip-text#5409373

@amw The user who takes the picture of the product needs to ensure that the image is clear, and that the text is readable. Of course, it's much easier to do this if the text isn't mirrored.
Thanks for the work-around, we will consider using this for now. Would be nice to have this feature built in to the package however.

I did a quick modification in my fork that respects the mirror option in the UI.
https://github.com/JustinStolle/jpeg_camera


[Eloquent backport]: Allow the MapDisplay "Update Topic" to be changed. (#517)

The major reason for this is so that the "Update Topic"
(and more importantly the QoS profile) is saved when clicking
"Save Config" in RViz2.  The more minor reason is that a user
might want to use a different topic for this.  We still
auto-populate this field with <topic_name>_updates by default,
but the user can now override it.
Signed-off-by: Chris Lalancette<EMAIL_ADDRESS>

One thing I was concerned with is if this change will cause any problems with existing .rviz files, since I think this change will affect the stored config structure. I didn't test for this case though.

I don't believe it will.
In the existing Eloquent RViz, because this is marked as read-only, clicking "Save" in RViz won't actually save it.  So for most "normal" uses of RViz, this is a straightforward addition.
If someone went ahead and and hand-typed the data into a saved RViz file, then in current Eloquent RViz it will be properly loaded in (I have a customer using that workaround right now).  By changing this to not be read-only, that behavior is preserved, but it additionally allows us to save by clicking "Save" (and has the side-effect of allowing the user to set the "Update Topic" to an arbitrary value).

@mjcarroll if you want me to do a release into Eloquent let me know.


Use key name in Datastore snippet.

Writers are using this snippet in a slightly different way, so it needs to include the key name instead of using the auto ID.

@halgrimur This is for the "Creating Entities" page.

LGTM


perf: lazy initialization of the gzip stream

Which problem is this PR solving?
A gzip stream is created by opentelemetry-exporter-otlp-http even when it's never used. Moreover, it's also never ended. It's particularly visible when using the testing framework Jest, that will complain about it with the following message : Jest has detected the following 1 open handle potentially keeping Jest from exiting: ZLIB.
Short description of the changes
Having a way to call gzip.end() would fix the issue, but I think it's first preferable to avoid creating the gzip stream in the first place.
Type of change
Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?
I ran npm test in the root folder and experimental folder.
Checklist:

[x] Followed the style guidelines of this project
- [ ] Unit tests have been added (not required IMHO)
- [ ] Documentation has been updated (not required)

Please fix the conflicts

Conflicts are fixed and I added the comment. I'm not sure how you do about the merge commit because I can't see any in the git log of the main branch, but perhaps you rebase everytime.

All PRs are squashed when we merge. That's why they have to be up to date. Speaking of which, this PR is out of date so it needs to be updated in order to be mergeable.

Re-running tests to see if failure is persistent.

Looks like the error wasn't caused by this PR. Please update the branch so it can be merged.

Please update the branch so this can be merged. I want to cut a release and I'd like this to be in it.

I'm working on it now.

Is the merge enough or should I do something else ?

No thats fine as long as the tests pass


Make sure App, Package and ImplementationDirectory implementations can be deployed as upgradeable instances

This issue depends on https://github.com/zeppelinos/zos/issues/88
The idea here is make sure that the initialization logic needed for each contract can be used with the upgradeability flow we are supporting currently

Closing in favour of #1325


Hover menu no longer seems to work in 4.0

Checklist:

[x ] I updated to the latest version available Yes, built V4.0 on 5/31
[x ] I cleared the cache of my browser

**Release with the issue: 4.0
**Last working release (if known): 3.0
**Browser and Operating System: Chrome Browser on Windows 11

Description of problem:
First of all, thanks Dermot for your help the other day - I was able to build V4.0 after your comments.  The release looks fantastic, but I have a couple minor issues having to do with the menu display.  First of all, I typically use hover mode for menus so the card does not look too cluttered.  I saw in your code that hover should now only work when the cursor is over the menu itself rather than the card (great idea!).  However, when I select hover mode the menu is "always" displayed - identical to if I had selected overlay mode.
The second issue is minor - my cards always have rounded corners based on my theme, but when the menu is displayed it causes the top left corner of the card to be square.  The other three corners are OK.  With no menu displayed it displays OK.
I should probably note that if I set hidden mode, the Frigate button does not cause this issue.  But clicking the Frigate button (and displaying the rest of the menus) causes the top left corner to be squared off.

Thanks for the feedback to help make v4 a quality release! Do you have a screenshot you could provide for the rounded corners thing?

This is a screenshot when the menu mode is set to hidden.  Notice the corner is rounded:

Still set to hidden, but the menu is expanded by clicking on the Frigate button - corner is not rounded.

And this is when the menu stye is set to hover:

The second issue is minor - my cards always have rounded corners based on my theme, but when the menu is displayed it causes the top left corner of the card to be square.

I think it's actually the menu background (a linear gradient darker on the right side than the left) that is causing it to look like the corner is not rounded. Let me see if I can fix ...

Thanks @tbrausch ! I believe both are now fixed. Really appreciate the early beta testing, please keep the issue reports coming.


Gitlab support in pipeline

Related issue: https://github.com/rancher/rancher/issues/12608

cool

cool

LGTM

Closing as the changes will come as a part of https://github.com/rancher/rancher/pull/14283

In Rancher v2.0.8 still no changes on .../pipeline page


Update page weights in tutorial/security section

This PR updates the page weights for the tutorial/security section, https://kubernetes.io/docs/tutorials/security/. It is part of our larger effort to update the page weights in the english docs, as described in https://github.com/kubernetes/website/issues/35093. To summarize, when page weights are missing or duplicated the site will default sort the page in alphabetical order based on page title. This causes problems in localized content because the page titles are different, making the page order different between the english and localized content.
https://github.com/kubernetes/website/issues/38850 was filed recently calling out a problem with the page weights in the tutorial/security section.

@sftim i've update the pr description to include more info about the page weights issue

/approve


returned Datetime type for proton datetime and datetime64

similar to https://github.com/timeplus-io/proton-go-driver/pull/38

returned Datetime type for proton datetime and datetime64
implement json.Marshaler, json.Unmarshaler, yaml.Marshaler, yaml.Unmarshaler interface for types.Date and types.Datetime

I think it's a breaking change. Why do we do this?
Is there a issue about this PR? What's the context of it?

If we have to make this change, @ye11ow could you please help to estimate the influence to neutron?

This pr can make it easier for user to read data from proton, then marshal data they read to json in the same format as proton do.
Run select * from example format JSONEachRow with proton client, the col whose type is datetime is in format of 1970-01-01 00:00:00. However, if user read the col via proton go driver, they will get a value whose type is time.Time. Using encoding/json  to marshal time.Time and the format will be like 2006-01-02T15:04:05Z07:00.
Type datetime and time.Time can easily be solved, but if user want complex type for example map(string,array(array(map(string,datetime)))), to marshal all time.Time with format 1970-01-01 00:00:00 will not be easy.

This pr is of low priority


PhysicalFileProvider.GetFileInfo(".") returns NotFoundFileInfo

From @moozzyk on Monday, July 20, 2015 6:05:07 PM
This is because Path.GetFullPath(".") returns the path without the trailing slash and we check if the path is under the root using .StartsWith() again the Root which does contain trailing slash.
Copied from original issue: aspnet/FileSystem#116

Thanks for your feedback. We appreciate your letting us know about the problem you've encountered or suggestion but we are not planning to take further action on this issue because our focus has been on issues with significantly higher customer interest and issues impacting a broad number of customers.


Twitter counter missing

I don't know at what point exactly, but twitter counter has disappeared.

https://github.com/sapegin/social-likes/releases/tag/3.0.15


add customizable clock colors

Adds the ability to assign custom filled and empty colors to a clock. Existing clocks will default to white and red as before.

I wanted to also add the ability to configure the default colors, but that was a bit beyond my knowledge of how to create config menus.

Is there a reason to have the clock colors be per clock instead of per world?

Yes I was thinking it would be nice to be able to represent clocks that have different meanings with different colors. For example if you have a clock that represents the strength of some enemy you might want it to look different than the clock that represents the strength of your allies.

Hmm, If its for that purpose the ideal way to handle it might be to have a way to add alternate colors to the world settings. Rather than each clock having a specific color value, it could have a dropdown selecting from all available configured color options.
That would allow gms to have a consistent look and feel, rather than dealing with a color picker everytime they make a new clock.
I thought the purpose was for theming, that's why I asked if per world wouldn't suffice :^)

That makes sense, I'm not very familiar with how to add new world settings options and interact with them in Foundry. Can you provide any guidance?

I think I also saw somewhere that the world settings don't support a color-picker input type natively, so that could be a bit of an annoyance for setting these up through world settings.

Caught me on vacation. I'll have to try to remember later, but that's unfortunately that there is native color picker available there. I'll dig though.


Docs: Add Blockbridge volume plugin

Thank you for all your hard work on the volume plugins, and the volume plugins API!
We have just made available our volume plugin for Docker. This PR is to list the plugin alongside the other existing volume plugins in the plugins documentation.
Please consider this docs change for 1.8.
Thank you!

Thanks! LGTM. I'll add it to the milestone, but @calavera has the final word in this :-)
/cc @moxiegirl @calavera (for review and cherry-pick)

@moxiegirl thank you for the review! You've got it. Two sentences, pushed a new commit.

Thanks @srust LGTM! To @calavera for the final review and merge.

LGTM. Thank you!

@calavera Cherry pick too?


speedup Inoreader mark_article_read using thread, borrowed from ttrssapi.cpp

trying to address #710

Coverage decreased (-0.04%) to 56.227% when pulling 972c26ee44f4ac2346d24cd337e958396f4facf7 on scateu:master into 09cbfa67c11a7da2ff97a3532de13637e2440e36 on newsboat:master.


Change "Physiography" to ???

The scope of the term "physiography" (physical geography) is very broad and encompasses many of the other existing data API service categories (hydrology, permafrost/soils, climate, geology...).
Since this data category currently only contains the EPA Ecoregions data, consider changing the service category name to "Ecology", "Biogeography", or something similar.

Suggest "Ecoregion"


CHEBI:78364 wrong stereochemistry

The InChi key points to https://pubchem.ncbi.nlm.nih.gov/compound/86289556 which, in the biologic description, shows a D-arginine. This is not plausible in a mammalian hormone. Please fix.

Now fixed. Thanks


Improve JSDocs to be more descriptive and better overall

I've improved all relevant JSDocs across files Player.ts, Poru.ts, Queue.ts, and Response.ts so they have a more descriptive JSDoc comment. I also fixed some spelling issues/sentences that made no sense.
Breaking changes:

I've changed the player.stop method to player.skip instead as stop implies a complete stop of the player's playback where skip implies skipping the currently playing song
I've removed the unnecessary parameter from poru.init (that being the client parameter) as it's already provided in poru's constructor

I've improved all relevant JSDocs across files Player.ts, Poru.ts, Queue.ts, and Response.ts so they have a more descriptive JSDoc comment. I also fixed some spelling issues/sentences that made no sense.
Breaking changes:

I've changed the player.stop method to player.skip instead as stop implies a complete stop of the player's playback where skip implies skipping the currently playing song
I've removed the unnecessary parameter from poru.init (that being the client parameter) as it's already provided in poru's constructor

Overall looks Good, Discussing about the breaking changes firstly the player.stop

"implies a complete stop of the player's playback"

true, that's actually what it does completely stops the current playing track.
secondly client parameter is present probably to provide the updated client data as <Poru>.init would be run once the discord client is ready(fully connected to discord) and before that client won't have access to it's user id.
I might be wrong don't mind it and correct me.
Apart from this I'll wait 24h for @parasop to review if he doesn't in 24h I'll merge this. (If I don't or forgot to do so Kindly Reminder me 😅)
-- Thanks UnschooledGamer

secondly client parameter is present probably to provide the updated client data as .init would be run once the discord client is ready(fully connected to discord) and before that client won't have access to it's user id
The thing about the client (at least for discord.js, not sure about other libraries) is that you can't access the user property if it's not initialized. I didn't see any other references to the client parameter inside of the init method which made me think it's superfluous.

true, that's actually what it does completely stops the current playing track.

As a user of the library I avoided the stop method as I figured it would completely stop the player and disconnect it from the voice channel similar to what destroy does hence why I renamed it to a more straight-forward skip instead. It may just be me but I feel like skip would work better here.

secondly client parameter is present probably to provide the updated client data as .init would be run once the discord client is ready(fully connected to discord) and before that client won't have access to it's user id

The thing about the client (at least for discord.js, not sure about other libraries) is that you can't access the user property if it's not initialized. I didn't see any other references to the client parameter inside of the init method which made me think it's superfluous.

It's most likely the same as after the bot successfully connects discord Gateway it returns the information about the user id etc.

true, that's actually what it does completely stops the current playing track.

As a user of the library I avoided the stop method as I figured it would completely stop the player and disconnect it from the voice channel similar to what destroy does hence why I renamed it to a more straight-forward skip instead. It may just be me but I feel like skip would work better here.

stop just tells Lavalink to stop the current playing song that's all. The disconnection afterwards is probably by code written somewhere.


Hardcoded Secrets in .tf Files

Inside the main.tf _https://docs.microsoft.com/en-us/azure/terraform/terraform-create-vm-cluster-module#create-the-template_ there is a hardcoded admin_password. The admin_password should be moved to a variable. How it exists today, if the terraform code were to be stored in source control, you would now have your admin credentials open to the public.
The same can be said about azureProviderAndCreds.tf _https://docs.microsoft.com/en-us/azure/terraform/terraform-create-vm-cluster-module#set-up-authentication-with-azure_ where you are hardcoding your client_secret in plaintext. If you view the official HashiCorp documentation here, _https://www.terraform.io/docs/providers/azurerm/auth/service_principal_client_secret.html_ they do not recommend defining the variables in-line. Instead, environment variables are recommended if you are going to use a Service Principal with Client Secret.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 1d39bd2e-380b-7e21-4e69-662edad08242
Version Independent ID: 3b44e702-b937-1f19-da25-e0bc4c232337
Content: Use Terraform modules to create a VM cluster on Azure
Content Source: articles/terraform/terraform-create-vm-cluster-module.md
Service: azure
GitHub Login: @TomArcherMsft
Microsoft Alias: tarcher

I am available to discuss the updates before creating a PR to adjust the documentation.

Thanks for the feedback! I have assigned the issue to the content author to investigate further and update the document as appropriate.

The admin password was hardcoded to simplify the tutorial. It's definitely not a best practice, and neither is hardcoding the client secret in the provider block. We're currently working on an article about managing secrets in Terraform that will provide more detailed guidance about this topic.
We recommend using a managed identity for Terraform whenever possible, and ssh keys or certificates to access VMs.  Just-in-time access (https://docs.microsoft.com/en-us/azure/security-center/security-center-just-in-time) to the VM will further improve security. Managed identities remove the need to expose Azure authentication credentials anywhere in the Terraform configuration.  For more information, see Authenticating using managed identities for Azure resources (https://www.terraform.io/docs/providers/azurerm/auth/managed_service_identity.html).  Keys, certificates, and other secrets are stored in Azure Key Vault and retrieved by Terraform when the configuration is run, instead of putting them into a variables file.

Whatever is decided as far as the documentation goes, a lot of individuals follow the tutorials literally so hardcoding passwords should be avoided. Moving to a variable isnt the most secure / best option sure but its the simplest to display with minimal changes required which is why I recommended that. This PR was basically my way of asking for the hardcoding to be removed from the documentation. I'll leave that decision up to you all though :)

Also, thanks for the feedback.

This article has been updated. #please-close


Remove deprecated label key in num_word

This should remove the following warning during the "West Build" stage when building new firmware:

'label' is marked as deprecated in 'properties:' in /__w/zmk-config/zmk-config/zmk/app/dts/bindings/behaviors/zmk,behavior-caps-word.yaml for node /behaviors/behavior_num_word.

Thanks for providing well-maintained and usable resources! I use smart-num and caps-word almost every day :)

Normally, I'd say let's fix it in the PR branch instead. But in this case, doing it just for this branch makes sense as I was planning some deeper refactors for then PR anyhow (https://github.com/zmkfirmware/zmk/pull/1451#issuecomment-2099085425).


show terminal on run/debug

When we start debugging or run the program we should show the terminal window - it has nice colored output. I don't think showing the "output" is very useful (too much stuff in there)

fixed


Reduce memory pressure from TraceGarbageCollector in real-time streaming scenarios

Opening this after having a conversation with @Maoni0
The TraceEventSession class supports a way to easily hook into parsed GC event data via the TraceLoadedDotNetRuntime.GCEnd event. This what tools like RealMon  use for live streaming of GC events.
One issue I noticed when trying to build my own real-time GC event streaming tool is that the internal TraceGarbageCollector class keeps an ever-growing list of all TraceGCs that have happened so far. For a long-lived process that wants to monitor GC events, this creates significant memory pressure as it grows without bound.
One idea for solving this would be to add a way to configure TraceGarbageCollector such that it doesn't keep a list of TraceGCs - this is useful for the real-time scenario where a subscriber wants to know about a GC event once and not again after that.
In the meantime, one workaround for others hitting this would be to periodically restart the TraceEventSession. The downside to this (besides being a general extra thing to maintain) is that you may miss events unless you carefully manage the restart.

You should be able to do this via the Lifetime tracking built into the GC collector: https://github.com/microsoft/perfview/blob/a79143be3467ae0dd221c481ba65d24917b48455/src/TraceEvent/TraceEvent.cs#L310

@jeffschwMSFT thanks! That looks viable. Will give it a try.

For realtime streaming, another great tool is the dispatchhook.  You can use this to pre-filter what events are allowed for processing or discarded.
https://github.com/microsoft/perfview/blob/a79143be3467ae0dd221c481ba65d24917b48455/src/TraceEvent/TraceEvent.cs#L3313
This filter may only allow events from a given process, etc.  The dispatch hook can help reduce volume.

Setting TraceEventSource.DataLifetimeMsec addresses my issues - memory use stays relatively constant now and is no longer expanding without bound. Thanks a lot @jeffschwMSFT for the suggestion!
I marking this item as closed.


Ability to configure a different ConsistencyLevel than QUORUM

In a development/test context, having a cluster with more than one node is not necessarily possible.
Would it be possible to add a config entry to set the consistency to ONE in order to avoid having the error bellow?
Not enough replicas available for query at consistency QUORUM (2 required but only 1 alive)))

Thanks it worked!


Add AMP quote element

And also add make the Heading and List element to inherit from the HTML implementation.

the spec for amp-paragraph still says descibre ..HTML..Paragraph :see_no_evil:

Due to problems with the namespace evaluation in sub-classes, we decided to keep the code duplicated. One benefit is that it will make sub-gems easier to pull of down the road. For now it will reduce our code-climate score :(


Usertype::implement not respecting module argument

This is not a high priority for me at all, but dropping an issue here since I noticed it the other day.
Usertypes seem to always be implemented in Main module scope, rather than the module specified in Usertype<T>::implement(unsafe::Module* module).
The module argument doesn't seem to be used at all:
https://github.com/Clemapfel/jluna/blob/05a827c3eda6f4fa7891f238ed7550f3105ece72/.src/usertype.inl#L61-L81

fixed by #37 once it's merged, the functionality was already implemented I just forgot to call it without the default argument.


Second Contribution by Rashid Leonard

My name is Rashid Leonard
I analyzed CVXPY | OpenJS projects.
Introduction
The governance model of CVXPY is structured around a community-driven approach with an emphasis on transparency and inclusivity. The key governance bodies include maintainers, the Steering committee, and the community and are designed to foster collaboration and ensure that the project's development remains focused on its core values.
The OpenJS Foundation is a nonprofit organization dedicated to supporting and fostering the growth of the JavaScript ecosystem. The governance model is designed to provide a transparent and collaborative decision-making process that involves multiple stakeholders. Key governance bodies include the Board of Directors, the Technical Steering Committee (TSC), the Cross-Project Council (CPC), and the community.
The governance model is designed to ensure that the foundation's decisions are made in a transparent and collaborative manner, with input from multiple stakeholders.
Similarities
The governance models of CVXPY and OpenJS Foundation share similarities, such as a Community-driven approach-emphasizing the importance of the community in shaping the direction of the project, a transparent decision-making process- by providing open channels for discussion and feedback, Multiple governing bodies-responsible for different aspects of the project's development and oversight and Inclusivity- with opportunities for community members to participate and contribute.
Differences
There are also differences between the two models such as;
Decision-Making Power - OpenJS Foundation's process involves more stakeholders and governing bodies, while CVXPY's gives more
power to the Maintainers and Steering Committee.
Technical Oversight - OpenJS Foundation has a Technical Steering Committee responsible for overseeing the technical direction of
projects, while CVXPY's is primarily focused on maintaining technical quality.
Scale and Scope - OpenJS Foundation oversees a larger and more diverse set of projects than CVXPY.
Legal structure - OpenJS Foundation is a nonprofit organization with a formal legal structure, while CVXPY is an open-source project
without a formal legal entity.
Conclusion
A better model depends on the specific needs and context of the project or organization. Both governance models are effective in their respective contexts, and each model has its strengths and weaknesses.
The governance model of CVXPY is more streamlined and focused on technical development, which may be more suitable for smaller projects with a narrower scope. On the other hand, OpenJS Foundation is more complex and involves more stakeholders, making it better suited for larger-scale and diverse projects.
Ultimately, the effectiveness of a governance model depends on how well it aligns with the goals and values of the project or organization, as well as the needs and preferences of the community.

Hi @arliss-NF, here is my second contribution. Thank you.

@rashidleonard - great analysis.  The points you make in your conclusion are right on!  Governance model recommendations are based on the project & community size and it's great you noted that.


A few small UI tweaks

Use same font weight for time in full and lite schedule
Draw 1 px gray border around avatars
Fix typo in error message

LGTM.


fix: post lifecycle was not executed on error

:tada: This PR is included in version 4.5.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


[stable/prometheus-operator] Add prometheus-operator ServiceAccount annotations

Signed-off-by: Max Roycroft Jr<EMAIL_ADDRESS>
Is this a new chart
No, this enhances the stable/prometheus-operator.
What this PR does / why we need it:
Add missing support for prometheus-operator ServiceAccount annotations.
Which issue this PR fixes
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

fixes #

Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] DCO signed
[x] Chart Version bumped
[x] Variables are documented in the README.md
[x] Title of the PR starts with chart name (e.g. [stable/mychartname])

/ok-to-test
Looks like you need to add sign-off to your commits

/retest

/cc

/cc @bismarck
/cc @mrueg
/cc @vsliouniaev

/test pull-charts-e2e

/hold
Let’s hold PRs to stable/prometheus-operator chart for a short time until https://github.com/prometheus-community/community/issues/28#issuecomment-672933972 is resolved. If you want to help with that effort, to test etc, that would be great!

🚧 This chart is now deprecated.
Further development has moved to prometheus-community/helm-charts. The chart has been renamed kube-prometheus-stack to more clearly reflect that it installs the kube-prometheus project stack, within which Prometheus Operator is only one component.
If applicable, please re-open this PR there. Thanks!


Error loading keys page after enabling the application registration workflow

Description
After enabling the application registration workflow [1], when users create an application through the developer portal and click on "Generate Keys" for OAuth Tokens, then proceed to click on "Production Keys" before appre from the admin, the entire page turns white.
Steps to Reproduce
Please follow the steps below to reproduce the behavior:
1.) Enable the application registration workflow by following the documentation provided in [1].
2.) Proceed to the development portal and create a new application.
3.) Navigate to the "Production Keys" section and select the "OAuth2 Tokens" tab. Click on the "Generate Keys" . This action will lead you to the following page ( Screenshot from 2023-08-17 19-21-21.png) :

4.) Now, Click on "Production Keys" tab or go back and then click on "Production Keys" tab ( Before approve from admin portal). You will notice that the screen becomes a completely blank white page, as depicted below (Screenshot from 2023-08-17 19-23-07.png):

Please also note that we did  not observe any error logs or any kind of logs during this behavior.
Affected Component
APIM
Version
wso2am-4.1.0
Environment Details (with versions)
No response
Relevant Log Output
No response
Related Issues
No response
Suggested Labels
No response

To add on this error , even when you reject the request it also breaks and return the blank page instead of atleast a massage that says your request was rejected

Fixed available in main branch https://github.com/wso2/api-manager/issues/1129


Raw snackbar strange behaviour

In raw snackbar messageText is of type Widget and message is of type Text. Is this intended? And text defined inside messageText i.e., Widget like Column(children:[Text ()]) isn't changing wrt to snackbar color instead it's changing according to the primary text color as opposed to Original snackbar.!

Hi, Yes, that is intended.
"message" is String, and messageText is a Widget. You can customize the color as you like using the style property of Text().
As this is not a bug description, but a question that has been answered, I am closing this.


StopIteration error in from_masked_images method

I am reaching out to you because I cannot figure by myself a solution for this error.
My code looks like this :
 for task in glob.glob(f"{postproc_path}/*/"):
        task = task[-12:]
        logger.info(f'Importing data')
        files = sorted(glob.glob(f'{postproc_path}/{task}/*.nii.gz*'))

        images = load_img(files)
        logger.info("Loaded files")
        masked_imgs = image.mask_images(images, brain_mask)
        logger.info("Masked images")

        # compute ISC
        bold_imgs = image.MaskedMultiSubjectData.from_masked_images(
                masked_imgs, len(files))

Where : images are loaded nii post processed files using nilearn.images  (tried it with brainiak.io module as well)
Seems to me that a generator object is passed to the method and turned into an iterator. The code breaks here.
Yet, I'm applying cell 5 from your tutorial. I wonder why it's not working with my data.
It may be my postprocessed files that are corrupted, but less probable than anything else as they are correctly loaded. I may be mistaken.
Being from a psychology background, there's a limit to my pythonic fluency and I would appreciate some help from the community.
Any troubleshooting insights for me ?
Thank you very much

Hello, @sangfrois. I am sorry to hear about your issue.
Could you add print(len(images)) before calling from_masked_images and share the output?
Did you run the ISC tutorial successfully?

Hello @mihaic !
Thank you so much for your fast response. I did run it successfully!
i get :
TypeError: object of type 'generator' has no len()
Does that mean I plainly did not correctly postprocess my EPI files ?

Not necessarily. How about len(files)? What is load_img? Are you executing exactly the code in the issues or are there maybe other lines you skipped?

as I said in the description : load_img is a utility to load .nii.gz files from the nilearn.image module.
files is a list returned by glob.glob(path/to/files.nii.gz so len(files) is 6. I load data from 6 subjects.

Try images = list(load_img(files)). If that doesn't work, please paste load_img here.

OH WOW! @mihaic
I'm sorry, I went ahead of myself, being sure i was listing files correctly, but I think it's the source of my error. I tried it in a interactive shell, and it spitted out empty lists.
brain_mask = load_mni152_template()
coords = np.where(brain_mask)
brain_nii = load_img(brain_mask)
print("Loaded mask")

@click.command()
@click.argument('postproc_path', type=click.Path(exists=True))
@click.argument('isc_map_path', type=click.Path(exists=True))
def map_isc(postproc_path, isc_map_path, pairwise=False):
    """
    Compute ISC for brain data.

    note
    """
    # specify data path (leads to subdi
    logger = logging.getLogger(__name__)
    logger.info('Starting Temporal ISC workflow')
    tasks = glob.glob(f"{postproc_path}/*/")
    # walks subdirs with taks name (task-s01e01a)
    for task in sorted(tasks):
        # HERE : the string returned is incorrect so it's looking for unexisting paths
        task = task[-12:]
        logger.info(f'Importing data')
        files = sorted(glob.glob(f'{postproc_path}/{task}/*.nii.gz*'))

        images = io.load_images(files)
        logger.info("Loaded files")
        masked_imgs = image.mask_images(images, brain_mask)
        logger.info("Masked images")

        # compute ISC
        bold_imgs = image.MaskedMultiSubjectData.from_masked_images(
                masked_imgs, len(files))

It seems to load files correctly and I don't get the StopIteration again.
Now, i get an ValueError because the mask I import does not have the same shape.
I feel so stupid! Sorry for mobilizing your energy for such an error on my part.
Thank you so much. I think we can close this now.

You're welcome. :)