The JavaScript examples on this page call the class MainDailog instead of MainDialog

Seems like a typo in the word Dialog

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 039ff5cc-7243-ce4b-527e-c152755eeb72
Version Independent ID: 039ff5cc-7243-ce4b-527e-c152755eeb72
Content: Code configuration for enabling SSO for bots - Teams
Content Source: msteams-platform/bots/how-to/authentication/bot-sso-code.md
Service: msteams
GitHub Login: @surbhigupta
Microsoft Alias: surbhigupta

Hello @surbhigupta12 - Please help us to update the documentation.


Converting cell_metadata from integer to string for latest MERFISH public data

IMPORTANT: Please search among the Pull requests before creating one.
Description
A previous pull request #679 by @djlee1 addressed this issue but implemented the code in the read_visium() function rather than in read_vizgen().
Here I made the changes to read_vizgen(). Looking through current issues on squidpy I didn't see any with the read_visium() function that would be addressed by the change, so I reverted to the previous version of the read_visium() code.
How has this been tested?
I've tested this locally on the public MERSCOPE data mentioned in #686, and the AnnData observations data frame was correctly populated with values rather than NaNs.
I also confirmed that the changes didn't effect previous squidpy tutorials using Vizgen data (mouse brain, mouse liver).

Codecov Report

Merging #692 (a4f1d38) into main (3684f11) will decrease coverage by 0.03%.
The diff coverage is 50.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #692      +/-   ##
==========================================
- Coverage   78.51%   78.49%   -0.03%
==========================================
  Files          33       33
  Lines        4706     4706
  Branches      922      916       -6
==========================================
- Hits         3695     3694       -1
  Misses        735      735
- Partials      276      277       +1

Impacted Files
Coverage Δ

squidpy/read/_read.py
38.37% <50.00%> (ø)

... and 1 file with indirect coverage changes

Oh, I accidentally edited another part and request it. Appreciate for fixing it :)

thank you @dfhannum , this was bad overlook from our side, I'll go on and merge it!


Moving bitvis_vip_wishbone to the UVVM repository.

Let's face the truth. The idea of UVVM_Community_VIPs has not catch on.
The fact, that bitvis_vip_wishbone is put there only generates the mess and increases the cognitive complexity.
The bitvis_vip_wishbone is in separate repository, however it needs to be copied to the UVVM repository to be compiled.
Because it is not in the UVVM repository by default GHDL compile-uvvm.sh script does not support it, so it needs manual modifications. All this is pure waste of time, putting bitvis_vip_wishbone into separate repository solves 0 problems, and creates at least 2.
Can bitvis_vip_wishbone be moved into the UVVM repository?
One more question.
What is the point of UVVM_SUPPLEMENTARY repository?

UVVM changed the license (hopefully with a license clearance) to Apache License 2.0 so it can be published under the umbrella of IEEE.
As now UVVM is Apache licensed: Why are user contributions are split apart, while the license itself plus the contribution agreements handle how to integrated more code from users into UVVM?

UVVM changed the license (hopefully with a license clearance) to Apache License 2.0 so it can be published under the umbrella of IEEE.
As now UVVM is Apache licensed: Why are user contributions are split apart, while the license itself plus the contribution agreements handle how to integrated more code from users into UVVM?

The Wishbone is in beta and require additional work from our side before it can be added to the UVVM repository.
User contributions are kept aside from UVVM in a separate repository as including them in UVVM would require that we review and make tests to verify them, and that the contributors will have to make documentation similar to those shipped with UVVM. We belive this could make contributors not willing to do the additional work and not share their work.

The Wishbone is in beta and require additional work from our side before it can be added to the UVVM repository.
User contributions are kept aside from UVVM in a separate repository as including them in UVVM would require that we review and make tests to verify them, and that the contributors will have to make documentation similar to those shipped with UVVM. We belive this could make contributors not willing to do the additional work and not share their work.

@mariuselv
commit 6eb24b30b65f1dc8dd6f0a08c955612e923644e8
Author: UVVM<EMAIL_ADDRESS>Date:   Tue Aug 6 13:01:35 2019 +0200

    added Bitvis VIP Wishbone BETA

Beta since 6th August 2019?

User contributions are kept aside from UVVM in a separate repository.

Author: UVVM<EMAIL_ADDRESS>

@mariuselv
commit 6eb24b30b65f1dc8dd6f0a08c955612e923644e8
Author: UVVM<EMAIL_ADDRESS>Date:   Tue Aug 6 13:01:35 2019 +0200

    added Bitvis VIP Wishbone BETA

Beta since 6th August 2019?

User contributions are kept aside from UVVM in a separate repository.

Author: UVVM<EMAIL_ADDRESS>

I will up the priority in the jira ticket so that someone hopefully can start the work sometime soon.

I will up the priority in the jira ticket so that someone hopefully can start the work sometime soon.

@mariuselv any status update?

Hi,
unfortunately we have not had the time to start on this task yet - our team is small and also working on other UVVM tasks and other projects. Unfortunately, I do not know when we will get started with this task.
Br,
Marius

@mariuselv moving it to the UVVM is probably not a lot of work. I can do it, if you will merge my PR.

https://github.com/UVVM/UVVM/pull/140

Hi @m-kru,
I think we can have the Wishbone VIP in the UVVM repository, but users have to be notified that it is beta, i.e. it is not fully tested and with missing documentation. This can be done by giving the folder name a "_beta" suffix - bitvis_vip_wishbone_beta and removing all files in the /doc folder.
Any thoughts?

Hi @mariuselv
I was thinking the same, but it is already mentioned in a few places that this is beta. In the versions.txt one can see:
  bitvis_vip_wishbone, version v.0.1.0 BETA

There is the BETA suffix. The first number in the version is 0. In semantic versioning it means that this is BETA and potentially everything is unstable and can change.
In the bitvis_vip_wishbone/VERSION.TXT one can also see:
0.1.0 BETA

Having BETA in the directory name may imply some adjustment in other projects utilizing UVVM when Wishbone will no longer be BETA. I do not think this BETA suffix is needed.
There is not doc/ directory in the bitvis_vip_wishbone.

Moved to UVVM.


Does this support backing up passkeys?

I'm using your solution to back up my vaultwarden.
I'm not sure If we are supporting backing up the passkeys. I did not find any information in the repository, so I place a question here.
Thanks.

What is a passkey? Perhaps it is not part of the service data. You can check here to understand the official recommendations on what needs to be backed up.


Plugin request for Buf Schema Registry - danielgtaylor-betterproto v.2.0.0b6

Mandatory
Where is the source code for the plugin?
https://github.com/danielgtaylor/python-betterproto/tree/v.2.0.0b6
(we already have latest stable release v1.2.5 https://github.com/bufbuild/plugins/tree/main/plugins/community/danielgtaylor-betterproto/v1.2.5 in community plugins, but it is released 3 years before and many new changes is in 2.0.0+(even in beta)
Optional
Does the plugin have a valid semver version?
https://github.com/danielgtaylor/python-betterproto/tree/v.2.0.0b6
Does the plugin have a dependency on another plugin?
No
Does the output of this plugin depend on any other external libraries?
No

Thanks for filing an issue. Unfortunately, we only package and publish stable versions. However, let's keep this issue open to track these requests.
There's a discussion on the original issue https://github.com/bufbuild/plugins/issues/95#issuecomment-1602976667
But to summarize:
At this time, we only support stable semver versions for BSR plugins. Once that repository publishes a v2.0.0 tag, we will pick it up automatically and release it to the BSR.

Thanks for filing an issue. Unfortunately, we only package and publish stable versions. However, let's keep this issue open to track these requests.
There's a discussion on the original issue #95 (comment)
But to summarize:
At this time, we only support stable semver versions for BSR plugins. Once that repository publishes a v2.0.0 tag, we will pick it up automatically and release it to the BSR.

I see @mfridman thanks for the information. Then probably I need find some work-around at the moment

As much as we'd like to add all plugins, we have to be a bit careful because for each plugin (and version) we add there's a maintenance cost.
The cost goes up for unstable/unmaintained plugins. Our goal is to provide a platform to host Protobuf plugins, but we don't have the bandwidth to maintain all these plugins.
Paying customers have the option to upload custom plugins to their organization.
Having said all that, our hope is the community can push progress forward in the upstream https://github.com/danielgtaylor/python-betterproto project.

@soisyourface I'm afraid not, the BSR UI linked to is referring to a v2 version of the buf.gen.yaml file, and not an updated version of the upstream plugin.


spawn myfile ENOENT

Hello there,
I'm trying to use atom with latex, so I wanted to try the atom-latex package. But an error message keeps popping :
Failed Building LaTeX (code ENOENT).
spawn empty ENOENT
Where empty.tex is my file containing :
\documentclass[11pt]{article}
\begin{document}
coucou
\end{document}
of course I've checked on TeXmaker and it's compiled fine...
Detail:
I am running on Windows 10.
Thanks in advance.

How did you install Atom? I had this issue as well because i had installed it as flatpak that causes issues with file access. Since I installed the system wide .deb everything works fine.
PS: this is a duplicate https://github.com/James-Yu/Atom-LaTeX/issues/178

@Fredastair For some reason it's not finding your root file. Try setting it explicitly and it should find it fine then.
let me know,

Closing this due to lack of response, feel free to post if you run into it again.


WIP: Add test github action

Changes:

Change pipeline from travis to github actions

Close in favor of #779


Slider not set correctly when updating value.

Based on Slider with dates example in the docs, if I try to move from date range index manually, even though index and value match to one of the values in the date range it doesn't update correctly.
I've already tried to use setTimeout approach and manualRefresh.emit() one too. The only way I've seen it actually update the value correctly is by toggling it with an *ngIf, which causes the illusion of blinking and it's not desirable.
Here's my code:
setUpDates() {
    this.dateRange = this.createRange();
    this.minValue = this.dateRange[15].getTime();
    this.currentTickIndex = 15;
    // this.maxValue = this.dateRange[29].getTime();
    this.options = {
      stepsArray: this.dateRange.map((date: any) => {
        return { value: new Date(date).getTime() };
      }),
      translate: (value: number): string => new Date(value)
        .toLocaleTimeString('en-GB', { hour12: true, hour: '2-digit', minute: '2-digit' })
    };
  }

createRange(): Date[] {
    const dates: Date[] = [];
    const start = moment(this.date).add(-15, 'minutes');
    for (let i = 0; i <= 30; i++) {
      dates.push(new Date(start.year(), start.month(), start.day(), start.hours(), start.minutes() + i));
    }
    return dates;
  }

onChange(e: any) {
    this.currentTickIndex = this.options.stepsArray.findIndex(item => item.value === e.value);
  }

moveTick(index) {
    this.currentTickIndex += index;
    if (this.currentTickIndex < 0) {
      this.currentTickIndex = 0;
    } else if (this.currentTickIndex > 30) {
      this.currentTickIndex = 30;
    }
    // this.minValue = this.dateRange[this.currentTickIndex].getTime();
    this.minValue = this.options.stepsArray[this.currentTickIndex].value;
    // this.hideSlider = true;
    setTimeout( () => {
      this.options = Object.assign({}, this.options);
      this.manualRefresh.emit();
    });
    // this.hideSlider = false;
  }

Any hint would be very appreciated.
Thanks in advance.

"ng5-slider": "^1.1.10",
Thanks for quick reply.

Can you upgrade to 1.1.11 and re-test please?
On Fri, 21 Dec 2018, 12:55 David Aguiñaga<EMAIL_ADDRESS>wrote:

"ng5-slider": "^1.1.10",
Thanks for quick reply.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/angular-slider/ng5-slider/issues/53#issuecomment-449181135,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABGS3GtldBl9n4oMuTPbaqW_JhqxVfRwks5u7CNTgaJpZM4Zc6tX
.

It worked! Thanks a lot!

Closing as dupe of #52


Add more job than threads

if much job are added into queue, and now the threads are busy , no thread is waiting the mutex, so if the threads finish the work, it will not be notified again.

@Jamesluo1
If there are more jobs waiting in the queue, the semaphore value should be always 1.
static void jobqueue_push(jobqueue *jobqueue_p, struct job *newjob)
{
    // ...
    bsem_post(jobqueue_p->has_jobs); // set 1 to semaphore value and signal
    // ...
}

When one of the threads finish the work, it won't wait for a condition variable but continues to pull a job from the queue and execute it. In the meantime, the semaphore value will be set to 1 again.
static void bsem_wait(bsem *bsem_p)
{
    pthread_mutex_lock(&bsem_p->mutex);
    while (bsem_p->v != 1) // 1. skip
    {
        pthread_cond_wait(&bsem_p->cond, &bsem_p->mutex);
    }
    bsem_p->v = 0; // 2. reset 0 to semaphore value
    pthread_mutex_unlock(&bsem_p->mutex);
}

static struct job * jobqueue_pull(jobqueue *jobqueue_p)
{
    // ...
    /* more than one job in queue -> post it */
    bsem_post(jobqueue_p->has_jobs); // 3. set 1 again
    // ...
}


WIP: Buttons for simple feedback on specific page

https://csc-guide-preview.rahtiapp.fi/origin/feedback-buttons/

After clicking on "Yes":

After clicking on "No":

Prefilled title and label in new issue:

Text suggestions:

Yes:
Thank you for you feedback!
No:
Thank you for your feedback! Please let us know how we could improve this page by contacting us or by creating an issue in GitHub. You can also edit this page yourself and contribute your improvements through a pull request.

The link to editing would of course be different for each page (same as when clicking the pen icon at the top of a page).

Maybe also the 'Do you find this page useful?' could be written in past tense 'Did you find this page useful?' I guess you need to first read the page in order to then decide whether it was useful or not?

Maybe also the 'Do you find this page useful?' could be written in past tense 'Did you find this page useful?' I guess you need to first read the page in order to then decide whether it was useful or not?

I'm viewing the site as a handbook where pages are constantly revisited, so the idea here is that the page presently exists and is either useful or not.

Maybe also the 'Do you find this page useful?' could be written in past tense 'Did you find this page useful?' I guess you need to first read the page in order to then decide whether it was useful or not?

I'm viewing the site as a handbook where pages are constantly revisited, so the idea here is that the page presently exists and is either useful or not.

Fair enough, that makes also sense!

Maybe also the 'Do you find this page useful?' could be written in past tense 'Did you find this page useful?' I guess you need to first read the page in order to then decide whether it was useful or not?

I'm viewing the site as a handbook where pages are constantly revisited, so the idea here is that the page presently exists and is either useful or not.

Fair enough, that makes also sense!

Oh, and when the page source file changes, the previous selection is removed and the buttons shown again. That makes it an on-going dialog, rather than a one time "yes" or "no".

Preview of this branch seems to not be building correctly. Other branches are fine, so I wonder if this is an issue with the changes made here and whether those could also be carried over to production?

Preview of this branch seems to not be building correctly. Other branches are fine, so I wonder if this is an issue with the changes made here and whether those could also be carried over to production?

Looks fine now. :man_shrugging: Perhaps preview fixed itself over the weekend.


[20.03] alacritty: backport 0.4.2

Motivation for this change
This change was initially motivated by unexpected behavior of alacritty after updating from 19.09 to 20.03.
The application seemed to randomly close, upon further investigation it turns out that this was probably related to Alacritty not ignoring keyboard events for changing WM focus on X11.
0.4.2 also includes other X11 related bugfixes ( https://github.com/alacritty/alacritty/releases/tag/v0.4.2 )
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

@paumr You'll need to backport the commit that adds cole-h as a maintainer.
That would be in maintainers-list.nix.

@paumr You'll need to backport the commit that adds cole-h as a maintainer.
That would be in maintainers-list.nix.

Fixed, thanks


FileIndex availability

Hi,
I don't seem to find tkrzw's FileIndex in the Go API. Is this intentional? Is there any plan to include it?
Thanks!

Hi,
The Go interface is a wrapper of the C interface.  And, the C interface doesn't support FileIndex yet.
Now, I'm writing a class PolyDBM which wraps both FileIndex and MemIndex.
I'm going to write its C and Go interafaces soon.

Exciting! Thank you so much!

I released Tkrzw 1.0.28, which supports PolyIndex to wrap FileIndex and MemIndex.
The Go interface on Github supports Index class to access PolyIndex.

That was fast! I'll check it out. Thank you so much!


Add utility support wrapping CrateDB's special table options

About

@wierdvanderhaar suggested to improve the ctk load table interface such that the target table can be created with CrateDB-specific features like partitioned table, and friends. Thanks.

This patch adds relevant support code, mostly for providing it to downstream libraries and applications. The first candidate is CrateDB Toolkit's I/O subsystem.
References

https://github.com/crate-workbench/cratedb-toolkit/issues/149
https://github.com/crate/sqlalchemy-cratedb/pull/139

See also

https://github.com/crate/sqlalchemy-cratedb/issues/142

@amotl
Honestly, I do not like this approach as it would force use to maintain table options not only at CrateDB but also at this dialect. I'd really prefer to not add concrete options here. Why not just double quote CrateDB specific (all settings prefixed with crate_ when they get converted into the create table stmt?

Why not just double quote CrateDB specific (all settings prefixed with crate_ when they get converted into the create table stmt?

This is probably about that issue?

GH-142

This patch's aim is different, and independent of the UX improvements outlined there. It is to have a map for shorthand versions of special table options to be conveyed via URL query parameters. It is exploring this area to have a proper metadata knowledge data structure in Python, to be used for different purposes. Currently, it is targeted for the ctk load table interface of CrateDB Toolkit.

It would force use to maintain table options not only at CrateDB but also at this dialect.

I hear you. About the maintenance details, it does not necessarily have to be the source of truth here. In a future iteration, both the documentation and API wrappers would be able to derive the information from CrateDB itself, either its sources, or by inquiring at runtime?


Installation instructions need update

Following instructions from http://mxnet.io/get_started/ubuntu_setup.html
MXNet can't be built on Ubuntu 16.04 with the default OpenCV (version 2.4.9) because MXNet 0.9.5 requires at least OpenCV 3.x due to the reference to -lopencv_imgcodecs.
In addition, OpenCV3.1 is not compatible with CUDA8 so OpenCV3.2 is required.
Installing OpenCV3.2-dev following instructions from
https://github.com/BVLC/caffe/wiki/OpenCV-3.1-Installation-Guide-on-Ubuntu-16.04
resolves the issue.
For bugs or installation issues, please provide the following information.
The more information you provide, the more likely people will be able to help you.
Environment info
Operating System: Ubuntu 16.04
Compiler: gcc 5.4.0
MXNet version: 0.9.5

@szha @mli  I thought the test server was running opencv 2.4?

The image codecs functions were in highgui module in OpenCV2.4 and were moved to imgcodecs in 3.0. It should be compatible as long as you change the -lopencv_imgcodecs to -lopencv_highgui, and it should work with opencv2.
What do you mean by "OpenCV3.1 is not compatible with CUDA8"? Are you using OpenCV for something else? MXNet does not require having a CUDA enabled version of OpenCV.

can we detect opencv version and link against the correct lib?

"OpenCV3.1 is not compatible with CUDA8": I take this from here: https://github.com/opencv/opencv/issues/6632

That issue is on opencv_cudaimgproc, which is not a dependency for mxnet

@sandeep-krishnamurthy turns out the installation instructions have a couple of issues.

-lopencv_imgcodecs in the instruction should not be necessary because of pkg-config invocation in Makefile.
These references to openblas are totally wrong because the installation guide said to install atlas.

@sandeep-krishnamurthy please fix both cases and send pr. Also please work with @lxn2 to make sure that in the CI the tests would actually capture this type of problems. If these don't capture problems, it means we don't need them.

This page is obsolete - http://mxnet.io/get_started/ubuntu_setup.html and CI tests are not running on this page. We need to remove this page and add a redirection (so search engine links are not broken). I will do that.

Here is the page we recently worked and improved the installation guide with installation instructions that is being tested on CI - http://mxnet.io/get_started/install.html.

@sandeep-krishnamurthy how's the progress.

PR - https://github.com/dmlc/mxnet/pull/6585

Seems that this issue has been fixed.


Add null guards for DelegatingDatabaseMetaData

The class DelegatingDatabaseMetaData has two private final properties, databaseMetaData and connection. Their values are provided as arguments to the constructor, but are not guarded against null which could propagate and cause NPEs at a later arbitrary time.
This commit implements a fail-fast guard against null values.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (ab6207f) 59.81% compared to head (99450c2) 59.86%.
Report is 14 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #352      +/-   ##
============================================
+ Coverage     59.81%   59.86%   +0.05%
- Complexity     1787     1794       +7
============================================
  Files            57       57
  Lines          7418     7430      +12
  Branches        419      423       +4
============================================
+ Hits           4437     4448      +11
  Misses         2766     2766
- Partials        215      216       +1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


CyLeaflet: Allow access to updated lat/lon of Cytoscape elements when modified by user

Description
When the dashboard user repositions nodes in the CyLeaflet UI, the elements property of the underlying Dash Cytoscape component is updated to reflect the new node positions.
However, only the x and y coordinates are updated; the lat and lon values passed inside the node data retain their original values.
CyLeaflet should provide a way for the developer to access the elements with updated lat/lon values.
Steps/Code to Reproduce

Expected Results

Actual Results

Versions
dash_cytoscape==1.0.0

IMO the most straightforward solution would be to add a callback which updates the elements store which is part of CyLeaflet every time the Cytoscape elements change. This does mean the API for accessing elements in CyLeaflet would be different than the API for accessing elements in Cytoscape, but it would provide access to the updated lat/lon without too many code changes.
Alternatively, maybe we could use Cytoscape event handlers to add a JS hook which updates the node data each time the nodes change?


Add in support for FIXED_LEN_BYTE_ARRAY as binary

This depends on https://github.com/rapidsai/cudf/pull/13437
This fixes https://github.com/NVIDIA/spark-rapids/issues/7449
The is to support https://issues.apache.org/jira/browse/SPARK-41096 in the plugin. It went into 3.4.0 so these changes and tests are specific to 3.4.0, although some of the back end support in this patch goes into a 3.3.0+ shim, but Spark itself tends to prevent this from happening in anything beyond 3.4.0. I did not thoroughly test this though and if we want more tests/verification that this is going to work I am happy to do that.
I wrote this because the author of https://github.com/rapidsai/cudf/pull/13437 asked me to test it, and this was the simplest way to test it.

The dependent PR is still in draft. I will move this to 23.10 when the dependent PR is also updated to 23.10

The dependency was merged into CUDF last night, but the CI failed so we might need to wait a little longer before this is ready to test.

build

@jlowe could you take another look?


Add "Choose all the locations..." para

Reason: Edits for clarifications questions and answers themes

Closing this PR as I have added the commit here to https://github.com/alphagov/digitalmarketplace-frameworks/pull/318


Add in initial files.

Initial solution with two run modes supported: Docker compose (multiple containers), Run multiple projects (no containers - local debugging). No manage.sh, or S2I support yet.

This work stream will be integrated with the work stream in https://github.com/bcgov/supreme-court-viewer/pull/3

Visual Studio project and API implementation
Plus the more integrated BC Gov theme portions of the UI.


Update excel-performance-and-limit-improvements.md

@lindalu-MSFT

Docs Build status updates of commit 2a4fb11:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

excel/Concepts/Excel-Performance/excel-performance-and-limit-improvements.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


List of changes deployed to production through Helm

Hi,
One of the auditors asked to extract the list of changes deployed to production through Helm. Could you please inform how I can extract this list of changes from Helm?
Thank you  in advance.

@macielro  I think  you need this: https://github.com/databus23/helm-diff

@macielro I think you need this: https://github.com/databus23/helm-diff

Hi yxxhero, thank you very much.

@macielro you can close this issue? please. thanks very much.

Closing this issue as answered. Please feel free to comment here and let us know if you have further questions. Thanks!


CPU training is not allowed

Hello when trying to run the train.py file I keep getting assertion error: CPU training is not allowed
Platform Win10 64
CUDA 12.1 installed
VSCode latest, all dependencies installed, ipynb jupyter notebook being used, inference notebook works fine in generating but as soon as I try to train this happens

Have you installed the correct version of pytorch for your CUDA?

Have you installed the correct version of pytorch for your CUDA?

Yes, I fixed it but now it's saying I don't have enough VRAm I need to run it on CPU instead

See https://github.com/effusiveperiscope/so-vits-svc/issues/23#issuecomment-1500764594 and remove the assert; frankly I'm not sure if training is possible on CPU or how fast it will be.


Feature/fix tests

As the integration tests didn't work I worked to fix them. Please review so the local tests will work in the future with elasticsearch's latest versions.

Thanks :)


Force install of progressbar2>=3.9.3

With earlier versions we would get the following error:
File "/home/travis/build/criteo/biggraphite/.tox/pypy-coverage/site-packages/progressbar/bar.py", line 108, in update
      if self.redirect_stderr and sys.stderr.tell():
IOError: [Errno 29] Illegal seek: '<stderr>'

This change is

Coverage decreased (-0.2%) to 94.005% when pulling 72bd8bd4aa3d2ff5c21d4054c1e37f460961c62f on iksaif:master into 04624d2ce0f5314114d87cd3eede3d918ff4d591 on criteo:master.

Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable


Refactor file_manager, stream_info_manager

a)
The file objects managed by file_manager ( EncryptedFileManager ) is hard to understand because it has some layers of unnecessary inheritance
( ManagedEncryptedFileDownloader -> EncryptedFileSaver -> EncryptedFiledDownloader -> CryptStreamDownloader )
b)
Currently, the tasks that stream_info_manager (DBEncryptedFileMetadataManager) and file_manager (EncryptedFileManager) is supposed to perform is poorly organized.  stream_info_manager should be responsible for downloading streams. file_manager should be responsible for constructing files out of these streams. Currently file_manager both manages streams and the construction of files. stream_info_manager merely acts as a database to store stream information.
The primary goal should be to have e a clear distinction between streams and files. As you can have streams without files.

The primary goal should be to have a clear distinction between streams and files. As you can have streams without files.

https://github.com/lbryio/lbry/pull/1025 refactors the stream and file creation process and storage in the database to do this. It does not significantly change the confusing inheritance of the lbry file classes, however it does remove redundancy of many associated functions (which are now in lbrynet.core.StreamDescriptor). The lbry file classes should be further refactored later and shouldn't require more database changes, this pr is big enough already.


Disqus enhancement

@baimingze the discus for each dataset comment has always the title "OmicsDI Dataset" this is really to generic. Probably would be good to have more customization like the title of the dataset or the combination of Repository - RepositoryID. See the image:

done

The code is ready, bu I guess we need to delete the whole site to change the titles. https://omicsdi.disqus.com/admin/settings/advanced/

what means the whole site ?

Done


“hugo --minify” strips spaces and preserve some new lines

v0.64.1/extended windows/amd64

When I use hugo --minify in my branch/repo:

some new lines are not minified,
some spaces inside tags (that need to be preserved) are striped.

New lines not minified:

Space inside tag striped:

yes me too, but this just happen on  tag only.

I want to clarify that "newlines are not minified" is incorrect. The minifier removes superfluous whitespace, but sometimes whitespace in HTML has meaning and cannot be removed. In that case either a space or a newline are required, and both have the same effect. The minifier will let the remaining significant whitespace be a newline when any of the original whitespace characters contained a newline. This newline cannot be removed without changing the display of HTML.
You second issue that whitespaces get remove in tags, this is because you use the CSS white-space property or you change display to inline. This changes the semantical meaning of HTML and may influence layouts that depend on whitespace for formatting. It is not recommended to let your HTML layout depend on whitespace!

@tdewolff thanks for the input and your work on the magnifiers, much appreciated. I have not looked into this particular issue, but we just merged way to configure and turn off a given minified, so that should solve most of these issues.

@tdewolff  Just a minify note. It appears that the first nested <source> block inside a <picture> preserve newlines between the parent picture and first source element. I don't see why they should be preserved.

Thanks for that! I've fixed it in https://github.com/tdewolff/minify/commit/8a5c9ca87945e475609daffac2634532fe4518cb. Seems that both audio and picture could remove their initial space. Make sure you have KeepWhitespace = false!

Thanks @tdewolff . Will wait for @bep to let us know what version this is updated in.

@bep any chance we can get an updated build with latest tdewolff/minify version?

Will push one out soon, I'm very busy with work these weeks unfortunately :-( sorry about that

@virgofx I had to revert to an older version of that library some time ago as it broke many sites in the wild. So we're currently a little behind.

I've pushed out 2.7.4

I too have had issues with spaces being remove, and the other thing I noticed with hugo --minify is that these select list options are not minified which I found interesting.

Thanks @bugsysailor, fixed your issue in https://github.com/tdewolff/minify/commit/7d9c4604da3a2c21bc3b21efa553ba1b19f5254e
Please remember that Hugo prevents removal of end tags. The default settings of the minifier will remove all superfluous </option> end tags. Let me know if you hit any other tips!

Is there any way to get rid of the new lines with the current config settings? I've set all the "Keep…" options to false, although I still get new lines. My HTML/CSS is set up in such a way where it doesn't rely on whitespace so they aren't needed

Some whitespace is significant in HTML, that whitespace character may be a space or a newline (both are 1 byte long). Eventhough your file contains newlines it may not be possible to further minify its contents.

This issue has been marked as stale, but I am still experiencing this behavior with hugo 0.80.

This issue has been marked as stale, but I am still experiencing this behavior with hugo 0.80.

I still experience this as well, although I understand why it works like it does. I think what's needed is an option to disable the "significant" whitespace. If I have:
Link 1
Link 2
Link 3

in my HTML, I'm not saying I want a space between each HTML tag even if it appears that way on the page when there's no stylesheet, the newline generates whitespace that I don't want and I visually remove it with CSS. I would like an option for these tags to be on one line when minified with no whitespace between them.

I still experience this as well, although I understand why it works like it does. I think what's needed is an option to disable the "significant" whitespace. If I have:
Link 1
Link 2
Link 3

in my HTML, I'm not saying I want a space between each HTML tag even if it appears that way on the page when there's no stylesheet, the newline generates whitespace that I don't want and I visually remove it with CSS. I would like an option for these tags to be on one line when minified with no whitespace between them.

With the various comments since this issue was originally created, the scope and detail are no longer clear. It contains unrelated reports of problems and suggested changes.
We bumped tdewolff/minify to the most current version (v2.9.15) with Hugo v0.82. Please test to see if your problem or enhancement has been addressed, and create new specific issues as needed.
Please remember that minification has a number of configuration options:
https://gohugo.io/getting-started/configuration/#configure-minify


Creating a custom widget

Question received by email:

I have a question regarding the angular2-schema-form repo. You say that it is possible to generate your own widget, sadly I don’t understand how and where I should begin.
Could you give me some information or documentation regarding creating your own widget?

You need to derivate the widget you want to customize:
@Component({
  selector: 'mdl-sf-string-widget',
  templateUrl: './string.widget.html'
})
export class MyStringWidget extends StringWidget {}

You need to provide its html template (let's imagine we want to use the Material Design text field):
<mdl-textfield [label]="schema.description" type="string" floating-label
    [name]="name" [attr.readonly]="schema.readOnly?true:null"
    [attr.id]="id"
    [attr.disabled]="schema.readOnly?true:null"
    [formControl]="control"></mdl-textfield>

And you need to declare it in a custom registry:
import { MyStringWidget } from './mystring';

export class MyWidgetRegistry extends DefaultWidgetRegistry {
  constructor() {
    super();

    this.register('string',  MyStringWidget);
  }
}

And then you need to provide your registry in your module:
providers: [{provide: WidgetRegistry, useClass: MyWidgetRegistry}],

Note: I will add this to the doc

first: thanks for the answer.
second: what is StringWidget?

Sorry, StringWidget can be imported from the angular2-schema-form package
(the code is here: https://github.com/makinacorpus/angular2-schema-form/blob/master/src/defaultwidgets/string/string.widget.ts )

Hi, I created my own Widget:
<md-input-container>
    <input type="number" mdInput [name]="name" [formControl]="control" [placeholder]="schema.title"
               [attr.id]="id" [readonly]="schema.readOnly?true:null" [min]="0" [max]="90" [value]="value">
    <md-error>This time is not valid!</md-error>
</md-input-container>

Using material2, but when I get the json of the form and I can see that the properties that used that custom widget are not set.

is your widget used? Do you see any changes in the ui? If not I assume your widget registry does not work correctly

Hi @marc101101 , I can see changes in the ui. The widget registration is working perfectly.


Option to invert the brightness changes

Would it be possible to include a switch maybe to invert how the brightness changes in the evening?
At the moment our lights get dimmer when it gets later. But I'd like this behavior reversed so that AL makes our lights go brighter as later (and therefore darker!) it gets outside.
Would make much more sense to me personally

Do you wake up in the evening?

Hey @LooneyN,
can you describe your use case in a bit more detail?
As far as I understand it correctly you like to be awake longer and move the sunset to a later point in time (for one day?). Additionally, you like to have Adaptive Lighting react to a brightness sensor, instead of following a predetermined brightness setting, to have a consistent brightness in the room in the evening when the window isn't letting light in anymore - right?
The second thing would be https://github.com/basnijholt/adaptive-lighting/issues/122 - the first thing would need a new ticket that describes this functionality.
Thanks!

@RubenKelevra The use case I have for this feature is related to my garden patio lights. I would like them to get brighter as it gets darker when I am sitting out in the garden.
I currently have an automation that increases the brightness by 10% every 20 mins after sunset, but I recently started using your integration (I love it BTW) and thought it would be great to have this increase the brightness of the patio lights as it gets later in the evening.

@WizBangCrash wrote:

@RubenKelevra The use case I have for this feature is related to my garden patio lights. I would like them to get brighter as it gets darker when I am sitting out in the garden.
I currently have an automation that increases the brightness by 10% every 20 mins after sunset, but I recently started using your integration (I love it BTW) and thought it would be great to have this increase the brightness of the patio lights as it gets later in the evening.

I think we have something on the roadmap already to get a matching functionality from your user story:

Incorporate ambient brightness sensors per room as feedback method to adjust for uncontrolled light sources and natural light
Switch from a brightness-percentage-goal to a target-brightness-in-lux-goal

Should make it possible to connect the lights on the porch and an ambient light sensor and set just goal in lux for the porch.
If the lights are "on" they would turn on and dim as necessary to get the requested apparent brightness on your porch.
Have a look on the roadmap in the discussions tab and vote on the functionalities you like to see, thanks!

@WizBangCrash wrote:

@RubenKelevra The use case I have for this feature is related to my garden patio lights. I would like them to get brighter as it gets darker when I am sitting out in the garden.
I currently have an automation that increases the brightness by 10% every 20 mins after sunset, but I recently started using your integration (I love it BTW) and thought it would be great to have this increase the brightness of the patio lights as it gets later in the evening.

I think we have something on the roadmap already to get a matching functionality from your user story:

Incorporate ambient brightness sensors per room as feedback method to adjust for uncontrolled light sources and natural light
Switch from a brightness-percentage-goal to a target-brightness-in-lux-goal

Should make it possible to connect the lights on the porch and an ambient light sensor and set just goal in lux for the porch.
If the lights are "on" they would turn on and dim as necessary to get the requested apparent brightness on your porch.
Have a look on the roadmap in the discussions tab and vote on the functionalities you like to see, thanks!

@RubenKelevra I like what I see in the roadmap, but I think both those features are overkill for my garden use case. The reason being that even if I put an illuminance sensor in the garden I would never be able to meet a fixed light level once it started getting too dark with my patio lights. The patio is too big and the light strips are more for ambience than to illuminate anything (they just run around the edge of the patio).
I was hoping to replace my simple automation with your cool integration and keep everything in one place :-)
I can see where I can use those features inside the house though, so will definitely try them out when you have added them.

@WizBangCrash Well having a "fixed target" for lux can obviously be bigger than what you can achieve with "just" artificial light.
The light would just turn on as soon as the sun starts beeing too dim and add a bit of light until its the only light source.
There's also a point on the roadmap which limits the maximum change rate, so you can set it something like 10%/minute to give you a slow dimming even if the sun sets fast :)

I'm already using this, crudely created in automations to test it out. I've set the maximum Lux to 80 while the artificial lighting can only achieve 38 lux on maximum brightness.
So as soon as the room gets down to 79 the light turns on and adds a bit of light to keep it at 80.
So the room will only dip down below 80 if the light can't supply more artificial lighting.

@RubenKelevra Okay. You've convinced me to try it once it becomes available :-)
I will order a Zigbee illuminance sensor for the garden and get it installed and create a similar automation while I wait for the next version of AL 👍

@RubenKelevra Okay. You've convinced me to try it once it becomes available :-)

Now you have to convince me to write it :P

I will order a Zigbee illuminance sensor for the garden and get it installed and create a similar automation while I wait for the next version of AL 👍

Actually getting a non-zigbee sensor would probably be better. There's also a feature on the roadmap to get real time color / color temperature information into the integration with a sensor which support this.
Price is about the same as the zigbee ones.

The settings I use for ESPHome is shared in the Roadmap.

I would like to second to having just a inverted switch as I do work nights sometimes and on my days off I don't switch my schedule just to say consistent, so it is mostly just either dark or extremely bright in my place overnight.
I think it would be cool to have my lights sync to what the sun would normally do but overnight with my light getting brighter after sunset and dimming during sunrise. A light sensor won't help in this case as I have my windows blocked off to sleep during the day.

I just ran into this use case (make ambient lighting brighter as it gets darker) and I simply inverted the min/max brightness values (eg min 100 and max 1) and it just works.
I understand it might not be intentional, and probably does not work with the non default brightness modes, but have you guys tried that?

I just ran into this use case (make ambient lighting brighter as it gets darker) and I simply inverted the min/max brightness values (eg min 100 and max 1) and it just works.
I understand it might not be intentional, and probably does not work with the non default brightness modes, but have you guys tried that?

I do the same, only strange thing i sleep brightness keeps transitioning (maybe not related)

It probably isn't intentional, but I can at least anecdotally confirm that using "tanh" or "linear" brightness modes, inverting max/min brightness settings simply leaves the lights at "minimum" brightness all day and all night. Unfortunately, it doesn't quite work the way I want it to in "default", since I'd like to make use of the brightness_mode_time_dark and light settings.
The use case I'm trying to use Adaptive Lighting for is to have the lights at a dimmer setting when turned on during the day and have them get gradually brighter as the sun sets. (I have a separate automation that activates AL's sleep mode for when I want some darker lights late in the night before I'm going to bed.) Maybe this isn't an intended use case, and if there's another integration out there that can handle this sort of thing better, I'd love to hear about it. My place gets plenty of natural light during the day, but (especially in the winter, where sunset is around 16:30) it drops off pretty dramatically once the sun starts setting and I need more artificial light to compensate.

I would like to expand on this request to invert the brightness curve in the middle of the day to let the sun take over. The current brightness curve is perfect for a room without much natural light.
I'd like to ramp up the brightness fairly quickly (after my alarm) and ramp down after sunrise.  In the evening the brightness would ramp up again as the sun sets and remain high until some offset from bedtime.
This is likely able to be accomplished with separate AM and PM profiles. I'll give it a show when the simulator is back up. I'd imagine this feature is "baked in" with #122  but I don't have any lux sensors.

Hey @OBoudreaux, you don't need a Lux sensor for automatic adjustments. Some weather plug-ins offer values of solar radiation which can be used to adjust the maximum brightness as necessary.
Inverting the curve however doesn't work, as most people like to also use adaptive lighting to extend the daytime and dim down to improve sleepyness in the evening.
Adapting to the brightness offered by the sun however is meeting your requirements without blocking the common use cases of other people, leading to weird behavior in some scenarios.
Lmk if you need any further help :)

Inverting the curve however doesn't work, as most people like to also use adaptive lighting to extend the daytime and dim down to improve sleepyness in the evening.

I believe "Inverting the curve" was the wrong way to say it. Having two peaks would be more accurate.

@OBoudreaux ah I see what you mean.
But I think you're underestimating the problem. If there's a thunderstorm or an overcast sky the illumination of the sun is much less than if the sky is bright and this is not even taking obstructions of the sun in winter into account.
I'm running a brightness sensor for around have a year now and the difference is tenfold in terms of brightness.
I think it would make more sense to get a 10 dollar sensor and put it on a window to measure the actual illumination by the sun and do some rough estimation based on that for each room.
If you doesn't want to add a sensor for each room, which I agree can be quite expensive.

[Copy pasting this message in a few recent open issues]
I just wanted to take a moment to express my heartfelt thanks to everyone that is active in this repo. Your contributions, from answering questions to addressing issues, have been invaluable. It's amazing to see how supportive and helpful our community is!
Adaptive Lighting is all about enhancing your living spaces with smart, sunlight-responsive lighting. We've had quite a few discussions and open issues recently, and I see this as a positive sign of our community's engagement and growth. If you come across anything in the documentation that's unclear or if you have suggestions for improvement, please don't hesitate to share!. Your feedback is crucial for making Adaptive Lighting better for everyone.
On a personal note, I've recently welcomed twin boys into my family, which has been an incredible and life-changing experience. As you can imagine, my time is now more limited, and while I'm doing my best to keep up with the project, there may be delays in my responses. I appreciate your understanding and patience during this time.
Rest assured, I'm fully committed to addressing any bugs, especially those related to new Home Assistant updates, as swiftly as possible. I understand that many issues may stem from hardware limitations or misunderstandings about things like Zigbee groups. Your continued support and collaboration in helping each other out not only strengthen our community but also enhance the Adaptive Lighting experience for all.
Thank you once again for your understanding, patience, and support. Let's keep our houses well lit and adaptive for maximal enjoyment of life! 🌞🏠🌙


autocad cant read library dwg/dxf writing output

Autocad cant read library dwg/dxf writing output.
To reproduce:

download Drawing.zip and extract it
run the following code loading the Drawing.dwg that was inside the zip

`using ACadSharp;
using ACadSharp.Entities;
using ACadSharp.IO;
using CSMath;
CadDocument doc = DwgReader.Read(@"Drawing.dwg");
using (DxfWriter writer = new<EMAIL_ADDRESS>doc, false))
{
writer.Write();
}
using (DwgWriter writer = new<EMAIL_ADDRESS>doc, false))
{
writer.Write();
}`
expected a readable file in autocad but the output is much smaller then original dwg and fail in autocad.

Hi @mamaorha,
I've test your file, here are the results, DXF:

DWG:

With the DWG I needed to recover the file but it seems that it could be opened by Autocad.
I've noticed that your file has a dynamic block, this are not fully supported by ACadSharp, which may be the cause for the loss of information in the file. I'll use your file to try to fix the issue and improve the reader/writer.

Thank you for addressing it so quickly, i truely appreciate the work you have done here.
im guessing that with time the missing read/write parsers will preserve more data.
indeed autocad offers to recover but still a lot of the data is lost in that transition (you can see the file shrinked from 144kb to 36kb).

Same issue here. Wandering has this bug been fixed?

Hi @Nico3201975
This particular issue was resolved, the file could be opened in Autocad with no major issue, if you are referring to the size, this is a work in progress to be solved.
In any other case, if you have a particular issue with a file, it would be good if you could provide an example of what are you trying to achieve or the file that is not working.

Hi @DomCR
Thanks for the quick reply.
I just updated to the newest release version.
Now I am on the stage of inserting a summary info into a file created by autocad.
Ingoring the size of the file part, a recovery prompt shows up each time when openning it.
Is there a way to removing this notification by any chance?

That notification usually appears for a badly written entity or object, after pressing recover Autocad usually prompts a log with what has been fixed and which entities or objects have been affected, if you can provide the logs I can take a look of what is the cause of it.
Also if you could provide an example of the output file it will really help with the problem because I could take a more detailed look at the issue.

Hi DomCR,
So basically, I followed the example to call DwgReader to retrieve a dwg file attr, then set comment section, then output to a new dwg file by calling DwgWriter.
Here is added comment dwg file:
log&file.zip

I've tested your file, this is the code that I'm using:
	CadDocument doc = DwgReader.Read(test, this._dwgConfiguration, this.onNotification);

	doc.SummaryInfo.Comments = "HELLO THIS IS MY COMMENT";

	DwgWriter.Write(path, doc, this.onNotification);

I'm guessing that this is what you want to achieve, if your case is more complex or you are changing some other structure, please let me know to make sure that I can properly create a test case.
The resulting file seems healthy, this is the only popup that I get form Autocad:

Which is completely normal and it doesn't recover any errors.
Checking the changes:

Are you using the Nuget package or the repository?

another test with more data, the Hyperlink hasn't been saved though.

Hi DomCR,
Appreciate for the testing.
what I wrote is pretty much same as what you provided above.
DwgReaderConfiguration _dwgConfiguration = new DwgReaderConfiguration
{
KeepUnknownEntities = true,
Failsafe = false
};
CadDocument doc = DwgReader.Read(strDwgFilePath, _dwgConfiguration);
doc.SummaryInfo.Comments = strDwfFileComment;
using (DwgWriter writer = new DwgWriter(strNewDwgFinal, doc))
{
//writer.OnNotification += NotificationHelper.LogConsoleNotification;
writer.Write();
}
DwgReader.Read() actually reads a file originally created by Autocad2022, then adds a comment, then after that creating as a new dwg file.
Somehow, my autocad2022 shows the prompt below:

And here is the prompt file:
123dwg.zip
If nothing looks suspected about above snippet, I might look over, and debug myself one more time carefully.
Thanks for the response.


[needs new maintainer] python3Packages.google_api_python_client: 1.12.8 -> 2.0.2

Motivation for this change
Status: I'm currently running nixpkgs-review.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 115194 at cc4be816 run on x86_64-linux 1

30 packages built:

beancount (python38Packages.beancount)
deja-dup
duplicity
duply
fava
gcalcli
kmymoney
ledger2beancount
lieer
python37Packages.beancount
python37Packages.beancount_docverif
python37Packages.goobook
python37Packages.google_api_python_client
python37Packages.oauthenticator
python37Packages.pydrive
python37Packages.weboob
python38Packages.beancount_docverif
python38Packages.goobook
python38Packages.google_api_python_client
python38Packages.oauthenticator
python38Packages.pydrive
python38Packages.weboob
python39Packages.beancount
python39Packages.beancount_docverif
python39Packages.goobook
python39Packages.google_api_python_client
python39Packages.oauthenticator
python39Packages.pydrive
python39Packages.weboob
tuijam

1 suggestion:

warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?
Near pkgs/development/python-modules/google-api-python-client/default.nix:37:5:
   |
37 |     maintainers = with maintainers; [ ];
   |     ^


minute: Add right network id as 1minutetip uses.

After @FrNecas fixed the IPv4 parsing in #543 the minute provision works just fine for me. @RHEmployee, why do you propose this change? I'm not sure hard-coding a specific value is a better approach.

After @FrNecas fixed the IPv4 parsing in #543 the minute provision works just fine for me. @RHEmployee, why do you propose this change? I'm not sure hard-coding a specific value is a better approach.
Hi. Because it's how 1minutetip and 1minutetip instances works. We have specified network with some minor configuration changes and we just forcing instances to use it.

Feel free to close this but I really don't understand what this module should do... mimic 1minutetip?

I'm not sure hard-coding a specific value is a better approach.
also "parsing" 1minutetip bash script doesn't seem to be good approach ;-P. But who Am I to judge? :)

self.debug(f"Get the API URL from '{SCRIPT_PATH}'.")
script_content = self.read(SCRIPT_PATH)
match = re.search(API_URL_RE, script_content)

Feel free to close this but...

@FrNecas, what do you think?

I really don't understand what this module should do... mimic 1minutetip?

Implement one of the provision methods so that you can choose if you want to run tests on your localhost, in a container, vm, openstack...

also "parsing" 1minutetip bash script doesn't seem to be good approach ;-P

Do you have a better proposal how to prevent disclosing the internal url?

Is there a reason why the specific network is used in 1minutetip? Does it work differenly from the others? The solution currently used was proposed by @thrix and I think it makes sense to use the network that is used the least to avoid potential problem with overloading a network but I am definitely not an expert on such things, let alone on openstack :) I've tested several networks and they seem to work just fine after fixing the regex.
Parsing the URL from 1minutetip script is a temporary workaround we made when implementing the plugin. Ideally, we would later create a config and we could distribute the config with the correct internal URL inside Red Hat so that tmt run provision -h minute would work out of the box without any additional setup. This solution seemed like the best at the time as potential users of this plugin already use 1minutetip so parsing it from the script covers most use-cases for now but it is far from ideal.

Do you have a better proposal how to prevent disclosing the internal url?

Yeah.. everything is better than "parsing" internal bash script.
For example 2 level configuration would be nice.
One can be distributed with internal tools and have know place. We can call it presets.
Then there will be second config file in user directory, which is able to overload presets.
If nothing provided, you can fallback to heuristic based on magic.

Is there a reason why the specific network is used in 1minutetip? Does it work differently from the others?
No. It doesn't matter. It's just random string which I liked... magic numbers....

And Now for Something Completely Different
I don't know how others networks behave. But I know how this specific network behaves and it's enough for me.
It matters in case if you want to guarantee at least something to users.
Provide working ipv6 for example. Or I remember how specially configured this network to allow ingress and egress. IPv4 ranges are also with sync with documentation for user's ssh configuration.
provider_net_cci_2 have ipv6 configured (there is ticket for covering even dns names...) etc...
If you call it minute then should it behave like 1minutetip?

There are multiple networks in PSI Openstack which provide also IPv6. If we want to choose networks with IPv6, we should still guess them :) We do not want to hardcode anything.  We have been there. It would be wise from 1minutetip to guess the network, or it might just randomly break once the network is full :) And no, we do not want to be really 100% compatible with whatever 1minutetip does, we just use it to easily provision machines on internal Openstack.

Ok. How I wrote in previous comment, I need to guarantee at least something for more or less stable and predictable testing environment. If this is not in aim of tmt/minute then ok. Closing.
Minute name is totally confusing. In case of onboarding 1minutetip users, it would just create chaos.

Additional notes:

We have been there. It would be wise from 1minutetip to guess the network, or it might just randomly break once the network is full :)
Huh?
Instances and free address space is something 1 to 1. So if you are out of ip address space then you don't have enough instances. I need to guarantee for example ipv6 address space so guessing random networks without ingress/engress set as I expect is nonsense.

About hardcoding: I proposed different solution with using 2 level configuration but without notice nor any response.

About hardcoding: I proposed different solution with using 2 level configuration but without notice nor any response.

I think the first step here could be to create an internal package with the plugin, as suggested by @FrNecas. That could contain the default config. @RHEmployee, are you possibly interested in working on this?

Additional notes:

We have been there. It would be wise from 1minutetip to guess the network, or it might just randomly break once the network is full :)

Huh?
Instances and free address space is something 1 to 1. So if you are out of ip address space then you don't have enough instances.

Instances in Openstack? That is not true, those resources are orthogonal. We hit no IP address on a network and had plenty of openstack instances available ...

I need to guarantee for example ipv6 address space so guessing random networks without ingress/engress set as I expect is nonsense.

Not sure I follow, you can find the most suitable (with most free IPv4 addresses) network with support for both IPv4 and IPv6.

About hardcoding: I proposed different solution with using 2 level configuration but without notice nor any response.

We have a solution to choose the correct network, there is no need for any other solution.

About hardcoding: I proposed different solution with using 2 level configuration but without notice nor any response.

I think the first step here could be to create an internal package with the plugin, as suggested by @FrNecas. That could contain the default config. @RHEmployee, are you possibly interested in working on this?

I believe the current way of things is correct, we can just make sure we choose a network with also IPv6 enabled?

I think we could add an option to the plugin that would force IPv6-enabled network, how about that? Or perhaps it could be the default and then add option to allow networks without IPv6? Although I am not sure how to check if the network is IPv6-enabled, will have to find out how to do that :)


Docker compose scripts to help with new deployments.

Docker tools for development
Added docker-compose scripts to build initial databases and to run the application mounting the code, so it is not necessary to rebuild the images:
Changes

Pass DB_SALT value to app-backoffice container in orginal docker-compose files
Added docker-compose-init-db.ymland build_fake_db.sh to build the databases with docker
Added docker-compose-dev.ymlthat mounts scripts and icubam folders on top of the fodlers that are copied in the Dockerfile
Edited docs/docker.md accordingly

How to init databases
docker-compose docker/docker-compose-init-db.yml build
docker-compose docker/docker-compose-init-db.yml up
docker-compose docker/docker-compose-init-db.yml down

Develop with docker-compose
docker-compose docker/docker-compose-dev.yml build
docker-compose docker/docker-compose-dev.yml up -d

For example, if we make a change in the source code of the server (e.g. a template), we can see it simply restarting app-server:
docker-compose docker/docker-compose-dev.yml restart app-server

@sfehlandt
Hi,
Something wrt build path for docker and docker-compose that I think should be clearly explained in the doc.
I tried to run the command
docker-compose -f docker/docker-compose-init-db.yml build

and it worked, but it was a side-effect of having setup in my environment ICUBAM_COMPOSE_CONTEXT to the project's root folder locally.  If setting this variable to empty, thus using the default value in the compose file, then I have the following result.
docker-compose -f docker/docker-compose-init-db.yml build
Building db-builder
ERROR: Cannot locate specified Dockerfile: ./docker/Dockerfile

If the context value is set to "." in the compose yml file, then docker-compose executes in the directory where the yml file is located (hence, "./docker/Dockerfile" is not available while "./Dockerfile" is).  I'm always launching docker-compose like
docker-compose -f docker/docker-compose-core.yml --project-directory . up

If we want to run the command without this --project-directory flag, then the default value in the compose file should be "..". However, this has an effect in production where we want the mounts' sources to be outside of the project's folder. This was the reason for using both project-directory and context (and keeping the same yml file).
Does it make sense ? Do you have another solution ?

@sfehlandt
Another discusion relating to dev vs. prod.
Currently the Dockerfile on master uses Ubuntu:18.04 and Conda. However to reduce the size of the image and spped up build/testing, we are moving to the Python's buster-slim base image and will do away with Conda.
Do you think the Docker image for development should extend the trimmed image and add by default a set of tools to properly dev/debug, or should it use another Dockerfile altogether ?

Hi @pgraverdy,
Yes, you are right. My compose assumes we have the ICUBAM_COMPOSE_CONTEXT variable set to ... I forgot to mention that. I added a suggested .env that works with all docker-compose scripts in the docker.md, and in that example I use ICUBAM_COMPOSE_CONTEXT=..
I tried to keep it versatile, maintaining your decision of keeping the ICUBAM_COMPOSE_CONTEXT configurable. If I understood correctly, the issue you mention with production could be solved keeping the ICUBAM_COMPOSE_CONTEXT as .. but going up another level in mount points for the other resources.
About the docker.md, maybe I can add the --project-directory . to my commands in the instructions, with a note saying that you may omit that if you set ICUBAM_COMPOSE_CONTEXT=..

I think it is a good idea to split them. Maybe you can even use the alpine images for ultra lightweight production images and the buster-slim with other dev and debug tools (in the requirements-dev.txt right?).
What I have done in other projects is to have a Dockerfile optimized for production (as light as I can). And a Dockerfile-dev for development. I usually do not copy the whole code in that, as it is intended for development.
Basically I copy the requirements files and then run 'pip install -r requirements.txt'. Then in a docker-compose specific for development, I mount the whole source codo in the container. This way I can see changes with no need to rebuild the images. I also usually use Django or other frameworks that support "live changes refresh" when you run them in development mode. So I can see them as soon as I save the file...

Maybe regarding the build path, we can

put the ICUBAM_COMPOSE_CONTEXT .env default values to ..
put in the docker.md the  --project-directory .
and put at the bottom the error case I described so that people that forget about the first two points may find the source of the error

Regarding the Dockerfile indeed better to have a dedicated Dockerfile as you propose (I'm from the node/angular world and indeed "live changes refresh" is quite convenient. BTW, you'll notice that the Dockerfile has changed (o more conda) due to the merge of the PR.

Great, I did as you said. About the first point I wasn't sure if you were talking about changing the default value in all docker-compose files. I did that (changed all the docker-compose files). But if you meant only the ones I added let me know and I can fix that.


Push service problem on Chinese Android Phone

Summary
I am using Android Phone which does not contain Google Service.
I love Mattermost, and our company build Mattermost server.
I want to use Mattermost on my Android Phone. Also want to receive push.
Please teach me the way to build Mattermost mobile apk for Chinese push service.
I did check with "Send Test Notification" at notification setting, but not received test notification.
Environment Information

Device Name: Nubia v815
OS Version: Android 7.0
Mattermost App Version: 1.50.1
Mattermost Server Version: 6.5.1

Steps to reproduce
Install Mattermost apk at Chinese Android Phone which does not contain Google Service.
And test with "Send Test notification" at setting.
Possible fixes
I think, I can use Chinese push server for receive push notification.
But how can I change notification server?
Please tell me.
Thank you.

Hi @JinZhuXing What you'd need to do is:

Modify the app code base to add support for another way/service to receive push notifications (then build the app yourself and publish).
Modify the push proxy to use something other than Firebase Cloud Messaging with another service and make it compatible with the server.
Configure your Mattermost server to use the custom push proxy.


C++ Hello World

What does the program do ?
Says Hello World
In what programming language it is written?
C++

This pull request do not contains files in specific folders. Please fix it and reopen for help see https://help.github.com/articles/moving-a-file-to-a-new-location/


Repository it not synchronized with https://gitlab.linphone.org/BC/public/external/vo-amrwbenc

The status of github repository is not the same as the couterpart in https://gitlab.linphone.org/BC/public/external/vo-amrwbenc
Currently the commit is 60b925e6

Closing this as no response for maintainers and I'm not using this app anymore.


Otimize NPK usage

There's just one NPK instanced needed during mount.

I'm not sure if passing a fd opened non block to losetup is fine.

I'm not sure if passing a fd opened non block to losetup is fine.

I didn't test that either, but I'd hope the kernel just cares about the fd, no matter which mode...


Allow specifying sdkRoot for ManifestLoader

We can avoid shelling out to xcrun in case the client already knows the right path.
rdar://problem/46417631

@swift-ci please smoke test


[DOCS] Add LICENSE section to README

Description
The README.md file does not have a LICENSE section to showcase LICENSE Biodrop is under.
Screenshots
No response
Do you want to work on this issue?
None
Additional information
No response

Thank you for your contribution but given that the License is shown on the Repo page I cannot see this would be necessary and will close this issue.


Brian/Electron

Fixed sizing across the homepage & dashboard page
Polished the error page displayed on incorrect URL as well as on KubeView
Fixed the error message for signing up with credentials already present in the database
Added an alert requesting the user to sign-in upon successfully signing up.

Looks great!


} expected, at-rule or selector expected on valid styled component

I'm getting errors on a styled component that seems valid to me:
const sizeProp = ({ align }) => (align ? "width" : "height");
const sizeValue = ({ size }) => (size === "sm" ? "16px" : "20px");

export const Icon = styled.img`
  height: ${sizeValue};
  ${sizeProp}: 16px;
  ${sizeProp}: ${sizeValue};
`;

I see ts-styled-plugin(9999) errors on the last two lines:

} expected on the first $ in the second-last line
at-rule or selector expected on the ; in the last line

The previous two lines are fine. They're just there to illustrate that it's okay when I have a computed property or value, but the combination of both seem to confuse the plugin.

I can corroborate this:
The same issue occurs for me when using a variable as an attribute name and a property value. In my situation the variable is actually const-string-typed, and both of the potential values are valid attribute names.

Closing as this package has been deprecated in favor of the official styled-components/typescript-styled-plugin fork
After updating to that fork, follow up in the styled-components repo if this is still an issue


Call build on mailable when mocking and default to when sending emails

Laravel Version: 5.6.24
PHP Version: 7.2

Description:
When I am testing mailables with Mail::fake() and Mail::assertSent(), and I use the second parameter for Mail::assertSent, the argument passed to the closure is missing the attributes, I would have to build it ($mail->build()). And if no recipient for the mail is not declared and would fallback to the default mail.to config, it's not on the returned object.
Steps To Reproduce:
Mail::fake();

Mail::assertSent(ContactForm::class, function ($mail) {
            return $mail->hasTo('example@example.com'); // this email is used from mail.to config.
});

I tried to add this custom config for email on laravel/laravel, but it was rejected:
https://github.com/laravel/laravel/pull/4672

I don't seem to understand your issue, please share more details.

Sorry If I was not clear.
In order for the test below to work, I have to build the mailable first.
// does not work
Mail::assertSent(ContactForm::class, function ($mail) {
    return $mail->hasTo('example@example.com');
});

// it works
Mail::assertSent(ContactForm::class, function ($mail) {
    $builtMail = $mail->build();
    return $builtMail->hasTo('example@example.com');
});

If this approach is OK, I think it's worthy to add a note on docs. What do you think?

I think somebody already tried a PR on this and was rejected because it's fair to just call the build method on the mailable.

I think it's ok to call build, but I think it would be nice to have it documented. I want to know if it's the best practice.

Please feel free to send a PR To the Laravel/Docs with the documentation idea :)


[Unity]  Support cumsum with pure int32

This PR fixes a bug on attr handling in data type rewriter and enforces i32 buffer in cumsum function definition, which ensures that cumsum can be run on a machine with int32 but not int64.

cc: @MasterJH5574


0.6.x releases in tandem with 0.7.x work

Before we get too far ahead, there will be fixes and improvements that can be released as part of the 0.6.x series whilst 0.7.x breaking changes happen in parallel. To this end, should we create a 0.7 feature branch to merge breaking PRs into? There are already breaking changes in master, so I'd have to branch off an earlier commit and force push master. Is there a better/preferred way?

Force pushing master seems like a bad idea IMO. For now I would suggest to keep doing 0.7 development in master and create an 0.6 branch for 0.6 patch releases. We can reconsider changing the way we use branches after 0.7 is released.

Sure, that makes sense. Cherry picking stuff from master into 0.6 should work ok.

On second thoughts, I would prefer to keep releasing from master, and work in a 0.7 feature branch. I think we'll run into problems with git tags and cargo-release and probably other stuff later if we don't.
Splitting off 0.7.0 into a feature branch would require one force push to move the Circle changes in master, which I think is acceptable. Force pushing isn't great, but the benefits outweigh the drawbacks this time I think?

I haven't used cargo-release before, so you can better judge if this will cause any problems.
We could use git revert to add a new commit that removes the circle changes instead of force pushing. IMO that would be a cleaner solution.

Ah, yeah a revert would work. Let me rustle a PR up.

Can you also create the development branch and push the circle changes to that branch? This would allow me to finish the rectangle PR.

Yep, I just pushed the v0.7.0 branch. I reverted the revert for the circle PR on it which is messy but should get us back to the correct state and (hopefully) make it easy to rebase master onto v0.7.0 to keep everything in sync.

Do we want to create a long lived PR for that branch or just leave it in git for now? Might useful for us and other watchers to see what's going to be in 0.7.0 if we do create it.

The 0.7 branch is behind master and it's easy to forget to merge changes in master to the development branch. IMO committing all changes to a development branch and cherry picking relevant changes to 0.6 would work better. By doing all the work in master and using one branch per release, it would also be possible to maintain more than one previous version, because every major release would have a separate branch.
But I'm not very experienced with the different git workflows and maybe there are better methods. I just think that the current one isn't working great.

I meant:

Delete the 0.7.0 branch.
All PRs and changes are merged into master.
When a new stable version is released a permanent branch is created (e.g. 0.6)
Master is always one version ahead of the last stable branch (at the moment 0.7)
All non breaking changes in master can be cherry picked into the stable branch

I'd like to be able to clean up these branches but keep the tag but I don't think that's possible, right? They'd have to live forever once created if we don't want to break links.

If the stable version branches are permanent they could be used for tags.

Ok great, I think we're aligned :). Next steps:

I'll create a PR to un-revert the circle changes in #274  back into master (this is the only change not in master currently)
Once that's merged, I'll then delete the v0.7.0 branch and we can continue on master as usual

Anything I've missed here?

If we want to release more 0.6.x releases it might be a good idea to create the 0.6 branch before we merge the circle changes into master.

That's true. Just for completeness' sake:

I'll create the v0.6 branch
I'll create a PR to un-revert the circle changes in #274  back into master (this is the only change not in master currently)
Once that's merged, I'll then delete the v0.7.0 branch and we can continue on master as usual
Any non-breaking changes for 0.6 can be cherry picked from master into v0.6.

SGTM :+1:

How should we handle changelogs in the future? If some changes are cherry picked into a stable branch, they will be added to the changelog for that version. Should we manually merge these additions to the changelog back to master after each minor release or handle this once before a new stable version is released. Or maybe something else?

Yeah, I think a merge from the release branch into master would have to be it. I can't think of a better way, so let's see how it works when a 0.6 release happens? We can tune the process from anything learned then.

v0.7.0 is now deleted. We should be good going forward. I think this now unblocks #286?

Also, please close this issue if you think it should be.

Yes, once the naming issues are resolved #286 can be merged.


Fix tls ports for FunctionWorkers and Zookeeper

Haxx tests discovered issues running function workers with the kaap operator and also some issues have started to appear with running pulsar 3.0 and master tests using the kaap operator and tls.
See:

https://datastax.jira.com/browse/LS-1192
https://datastax.jira.com/browse/LS-1149

This is a naive attempt to fix the issue, but it is not tested.

Some tests are broken.


Fixed issue with untranslated text

Contains
Closes #2698 with a very simple one line fix 🙂
Just an issue with the text being untranslated. It does seem a bit unintuitive that the translation is done in JoinGameScreen.java instead of ServerListDownloader.java but I went with this since the TranslationSystem object cannot be instantiated in ServerListDownloader.
How to test
Open the Join Game screen. Verify that the translated text is shown.

Hooray Jenkins reported success with all tests good!

@iojw Please add Javadoc to the ServerListDownloader stating that the status String/getStatus() method return a i18n key. This is not very intuitive and should be noted somewhere to prevent this bug in the future.

@skaldarnar I've added the  javadoc to ServerListDownloader. Let me know if there's anything you would like me to change.

Hooray Jenkins reported success with all tests good!

Thanks, looks all good now 😄


Torch module no longer supported

When running the ESMFold Structure Prediction test script from the site, after a clean install, get the following error.
ModuleNotFoundError: No module named 'torch._six'
The module was deprecated and removed from torch.

getting the same error

getting the same error

I have the same issue. It comes from deepspeed, who patched this in March, but ESM requires deepspeed==0.5.9. Would be nice if ESM worked with new torch versions but oh well.
https://github.com/microsoft/DeepSpeed/issues/2845

On DeepSpeed compatibility: this is actually an issue with OpenFold - see here https://github.com/aqlaboratory/openfold/issues/276.
Replacing all occurrences of deepspeed.utils.is_initialized() with deepspeed.comm.comm.is_initialized() in openfold/model/primitives.py fixes the issue and allows you to use the latest DeepSpeed, so you could make those changes yourself. I've done this locally and I can use ESMFold with the PyTorch 2.0 and the latest DeepSpeed too.


Add support for new media queries features

This PR adds support for new media queries features:

prefers-color-scheme
prefers-reduced-motion
any-pointer and pointer
any-hover and hover

Hi, thanks for your contribution.
My usual answer for this would be the same as always:

The way I usually approach this is is to wait for a feature to land in the Sublime Text default CSS package (or open a PR there to get things moving). The Sass/SCSS and LESS syntaxes are based off that default syntax, and it makes it easier to sync them all up if a new CSS feature is implemented "upstream" first.

Now, we are currently slightly deviated from the default CSS package because I need to port a pretty massive rewrite. So maybe it wouldn't be so bad to walk out ahead a little bit. But like most Sass users I write some plain vanilla CSS as well from time to time, and I would definitely like to have these media features in that syntax as well. So, even then it makes sense to start with a PR there. If that takes too long I might still be interested in this PR, but I would like a test to go along with the changes.

I think this is already covered in CSS package, but as you said this package already deviated a little bit so it needs special treatment. I can’t check right now since I’m on vacation.

I checked “prefers-color-scheme” in css and it isn’t recognized at all.

Ah, you’re right, I guess I’ve seen something different. I will start with PR on CSS syntax and see the response.

Thanks! I’ll keep an eye on it. I’m in the process of syncing back up with the CSS syntax, but it’s a bit of a project… when that’s done though, I should be able to integrate the new media queries with ease.

Here it is: https://github.com/sublimehq/Packages/pull/2891

@braver it’s merged!

Cool! Thanks!
So, I’m currently rebuilding the Sass syntax based on the current version of the CSS syntax (and improving it along the way, making it more maintainable). It’s quite a bit of a project but it will get done and that will bring all the new CSS features along with it. So, some patience still 😉

A 3.0 beta release is out now, check the readme on how to get the early builds to take advantage of the improvements and help out improving the package before we ship it to the world. In 3.0 we should also be able support your requested features if we don't do so already. Please have a look!

confirmed these are supported in #96


consider merging with staticsitegenerators.net

https://staticsitegenerators.net/ seems to have been there for a while and serves a similar purpose. why not merge the two?
the issue on the other side has already been opened, see https://github.com/bevry/staticsitegenerators/issues/22

Hi there.
Staticgen has actually been around for quite a bit longer than staticsitegenerators.net, though the current version is more recent.
There are some really big differences between the two lists, mostly related to the rules specified here:
http://www.staticgen.com/rules
If you go through the list of staticsitegenerators.net you'll see things like BitBalloon (our drag'n drop hosting platform), Kirby (A flat file CMS), Statamatic (Proprietary flat file CMS) that are actually not static site generators and not open-source.
We prefer to keep a smaller list with strict requirements and a more details on the individual static site generator, whereas staticsitegenerators.net is more of a long list of everything static related.

awesome, thanks for the clarification!


Use RequestBody with HttpGet

How to send RequestBody with HTTPGet.

This is a better question for stack overflow. This tracker is for bug reports with test cases and feature requests only.


chore: run typescript build as part of typecheck, not normal build

Summary
That way type errors will not block unit tests from running

Test plan
Green CI

Ok, ended up adding build:ts which builds type definitions. Also added prebuild: build:ts, so it triggers automatically before build. Also added watch:ts which runs tsc in watch mode


Streams Control Panel

It will be great to have a Steams control panel when buffering is enable
This way we can see the streams use currently by the xteve with the steam#:M3UName: Channel # and name.
Also have a way to force close a specific stream.

Maybe sometime in the future.

Nice idea!

good one


Move release notes into its own chapter

Describe the Task
Move the METviewer Release Notes section out of the Overview chapter and into it's own chapter (under Overview - the Release Notes will become chapter 2). Rename in the following way:
1.10 METviewer Release Notes -> 2 METviewer Release Information
Modify the index.rst file to add the new chapter "release-notes" after "overview"
Create a new 2.1 section called METviewer Release Notes
Create a new 2.2 section called METviewer Upgrade Instructions (with paragraph text "Upgrade instructions will be listed here if they are applicable for this release.")
This work will require changing the types of headers to follow the standard guidelines:
https://www.sphinx-doc.org/en/master/usage/restructuredtext/basics.html
with overline, for parts
with overline, for chapters
=, for sections
-, for subsections
^, for subsubsections
“, for paragraphs
Time Estimate
Estimate the amount of work required here.
1 day of work or less.*
Sub-Issues
Consider breaking the task down into sub-issues.

[ ] Add a checkbox for each sub-issue here.

Relevant Deadlines

MET-11.0.0-beta4 release*

Funding Source

2792541*

Define the Metadata
Assignee

[x] Select engineer(s) or no engineer required
[ ] Select scientist(s) or no scientist required

Labels

[x] Select component(s)
[x] Select priority
[x] Select requestor(s)

Projects and Milestone

[x] Select Repository and/or Organization level Project(s) or add alert: NEED PROJECT ASSIGNMENT label
[x] Select Milestone as the next official version or Future Versions

Define Related Issue(s)
Consider the impact to the other METplus components.

[x] METplus, MET, METdataio, METviewer, METexpress, METcalcpy, METplotpy

Task Checklist
See the METplus Workflow for details.

[x] Complete the issue definition above, including the Time Estimate and Funding Source.
[x] Fork this repository or create a branch of develop.
Branch name: feature_<Issue Number>_<Description>
[x] Complete the development and test your changes.
[ ] Add/update log messages for easier debugging.
[ ] Add/update unit tests.
[x] Add/update documentation.
[x] Push local changes to GitHub.
[x] Submit a pull request to merge into develop.
Pull request: feature <Issue Number> <Description>
[x] Define the pull request metadata, as permissions allow.
Select: Reviewer(s) and Linked issues
Select: Repository level development cycle Project for the next official release
Select: Milestone as the next official version
[x] Iterate until the reviewer(s) accept and merge your changes.
[ ] Delete your fork or branch.
[x] Close this issue.

Changes have been made


Travis py35

Please do not review or merge yet.

I also messed a bit this branch ;)

This configuration should run 2 jobs - and for each job flake8 and the python tests for the appropriate version. I could not find a decent way to run 3 jobs: flake8, python2.7 and python 3.5
Obviously we can easily avoid running twice flake8
What bothers me is that from the tests I've been doing it appears that travisCI ignores env markers and ends up installing ovs 2.5 for the python 3.5 job.
If that's confirmed we either force ovs to 2.6.0-dev3 or wait for ovs 2.6 to be published to pypi (I think that will happen by the end of the week)

@salv-orlando I think the env marker support is a relatively new feature of pip.  travis-ci probably just doesn't have it.  :(
I'm responsible for getting ovs on pypi.  I'll get it done this week for sure.

..... annnnnd ovs 2.6.0 was just uploaded to pypi.
https://pypi.python.org/pypi/ovs/2.6.0

thanks russellb!
Well maybe travisci supports env markers after all... I forgot to patch requirements.txt from the branch where I was doing unit tests.


fix: server action cases

Fix some RSC case, will fix https://github.com/dai-shi/waku/pull/745. In the future, I will migrate the logic to https://github.com/himself65/react-server and keep same output
Some issues still happening:

export default async function () {"use server"} cannot be RSCA
export function a() { "use server" } should throw error, because it's not async

export default async function () {"use server"} cannot be RSCA

Yeah, I notice that too. Even with top-level "use server", it fails. Gotta fix it, but maybe later.

export function a() { "use server" } should throw error, because it's not async

Originally, I thought sync functions are supported, and I have such an example in 23_actions.
Does nextjs throw an error? I'll leave it to your react-server.

Originally, I thought sync functions are supported, and I have such an example in 23_actions.
Does nextjs throw an error? I'll leave it to your react-server.

It must be an async (and next.js forces this) because the server action is function between the client and server, the is no way to be sync

Originally, I thought sync functions are supported, and I have such an example in 23_actions.
Does nextjs throw an error? I'll leave it to your react-server.

It must be an async (and next.js forces this) because the server action is function between the client and server, the is no way to be sync

#778


⚠ ClamAV has degraded performance

In 443134f, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 73 ms

Resolved: ClamAV performance has improved in 0b4942f.


Remove version: Datto.Workplace version <IP_ADDRESS>

[Automated] It returns code over 400 in all urls
Microsoft Reviewers: Open in CodeFlow

For moderators or/and anyone else

[!Caution]
As a result of several personal problems I've had over the last few months + my final exams coming up very soon, I'm currently unable to look at my GitHub notifications every day and maintain my executions correctly.
If you detect a certain problem on a certain pul request:

Either you can close the pull request directly without mentioning me.
Or you can send me a message on X (Twitter): @Exorcism0666

Thank you for your understanding, and I'm sorry if some pull requests can't be approved due to the situation I'm in.

This account is automated by Github Actions and the source code was created by CoolPlayLin. If you have any questions about any pull request, don't hesitate to ping Exorcism0666.

[!warning]
With the new version of Komac, numerous Pull Requests may contain bugs or unwanted elements. If such issues arise, please tag russellbanks so that these bugs can be addressed in future updates.

[!important]
Please carefully review these Pull Request before merging. If it is a Pull Request for removing incorrect content and the URLs are issue, free upon manual checking, please close this Pull Request directly. (It is best to inform Exorcism0666 of the closure.)

良い一日をお過ごしください！

/azp run

URL: https://us.workplace.datto.com/update/DattoWorkplaceSetup_v<IP_ADDRESS>.exe
Response Error: The remote server returned an error: (404) Not Found.
(Automated message - build 912)


Sync with community and update to 2.2.0.ER5

@Ladicek pushed changes to artifact version

OK, great. FYI, I will keep these PRs open until we know the final version.thorntail.


AWS VPC networking scheduler

link https://github.com/rancher/rancher/issues/9153

Not clean and very complicated
This is not a good way. Close it.