v-model will force cast  to number

Vue version
3.3.4
Link to minimal reproduction
https://play.vuejs.org/#eNp9kc1OwzAQhF/F8iUgQSvU/yqtBKgHOAACjr6UdJOm+E/2uhRFeXfWrho4oN68M5/XM3LDb63t7QPwOc994WqLzAMGuxS6VtY4ZA1zULKWlc4olhGaCS10YbRHpnzFFtG/yGaz2XQ6nUwm4/F4NBoNh8PsUui8f1xK62hAUFauEWhiLN/eLJsmrWjbvE9TUq2DKOO3BVN2blSTXWsbkO2vldmAXAhOgOCJpkEH9QFOcELzfvcYv+LoKW9ZV72dN5qqNnGX4IVRtpbgni3W1EfwOUtO9NZSmq/HpKELcHXSiy0Un//oO3+ImuAvDjy4PQjeebh2FeDRXr09wYHOnUlNgiT6jPkK3sgQMx6xu6A3FPsPl9I+pA+rdfXuVwcE7U+lYtBItokXnD7x/kz137iD3iDdE7rl7Q+FaLZA
Steps to reproduce

Make a <input v-model="msg" type="number" /> where msg is a string ref
Input a value into it with 20 digits or more.

What is expected?
Vue should not automatically cast strings to a number when it's not appropriate.
What is actually happening?
Vue will force cast v-model to a number, even if it was originally a string and even if a number cannot represent the inputted value.
System Info
System:
    OS: macOS 13.5.2
    CPU: (10) arm64 Apple M1 Max
    Memory: 182.27 MB / 32.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 16.19.0 - /usr/local/bin/node
    npm: 8.19.3 - /usr/local/bin/npm
  Browsers:
    Chrome: 117.0.5938.62
    Edge: 113.0.1774.57
    Safari: 16.6
  npmPackages:
    vue: ^3.3.4 => 3.3.4

Any additional comments?
In previous version of Vue, v-model casting to number was explicitly opt-in with the .number modifier. Now the casting is forced, with no way to opt out. This makes it seemingly impossible to show the appropriate mobile keyboard for inputs that require many digits, or inputs starting with 0.

https://github.com/vuejs/core/issues/3813

I think this is expected in vue

Duplicate with #5284 . In addition, this was introduced in #3813 . How to modify it needs further discussion.


Review check_subscriptions_on_stripe script

Less than 10 cancelled subscriptions in our database were marked at the exact same time - good chance due to the script. Before running the script for December, need to figure out why script incorrectly marked only those.

Most of them seem to be annual subscriptions to consciousness hacking, weird.


Windows 7 almost everytime on change file - ENOTEMPTY, directory not empty '

Hi!
I'm trying to work with Ember-CLI and when I execute
"ember server"
in my console using "Run As Administrator". It execute correct, but when I change any file, during watch operation it throws error:
"file changed templates\application.hbs
ENOTEMPTY, directory not empty '{path}\tmp\funnel-dest_T8wFIP.tmp'
Error: ENOTEMPTY, directory not empty '{path}\tmp\funnel-dest_T8wFIP.tmp'
at Object.fs.rmdirSync (fs.js:612:18)
at rmkidsSync ({path}\node_modules\ember-cli\node_modules\rimraf\rimraf.js:247:11)
at rmdirSync ({path}\node_modules\ember-cli\node_modules\rimraf\rimraf.js:237:7)
at fixWinEPERMSync ({path}\node_modules\ember-cli\node_modules\rimraf\rimraf.js:150:5)
at Function.rimrafSync [as sync]({path}node_modulesember-clinode_modulesrimrafrimraf.js:216
:26)
at Funnel.cleanup ({path}\node_modules\ember-cli\node_modules\broccoli-funnel\index.js:96:19)
at $$$internal$$tryCatch ({path}\node_modules\ember-cli\node_modules\rsvp\dist\rsvp.js:490:16)
at $$$internal$$invokeCallback ({path}\node_modules\ember-cli\node_modules\rsvp\dist\rsvp.js:502:
17)
at {path}\node_modules\ember-cli\node_modules\rsvp\dist\rsvp.js:1096:13
at Object.$$rsvp$asap$$flush [as _onImmediate]({path}node_modulesember-clinode_modulesrsvpd
istrsvp.js:1581:9)"
I've turned off Index Options, Windows Defender and nothing changed. What could happened?
Thank you!
P.S. I'm using last ember-cli package version - 0.1.7

is your text-editor observing tmp ? (there is a plan to move tmp to the system tmp, which hopefully will help mitigate)

I'm using WebStorm 9 and Bracer, and in both IDEs same problem

I'm using WebStorm 9 and Bracer, and in both IDEs same problem

i believe both of these watch the whole project tree by default. WebStorm has a way to disable watching tmp. I suspect the other does as well. If you do this you will likely no longer have any issues.
We can blame poor FS choices of windows. Luckily the final solution of moving to system tmp dir will mitigate most of these issues :)

Yes, I've tried to disable tmp folder in WebStorm, but it seems that has no effect. But I'll try to do it more carefully. Write if it will take effect.

Hi, guys! I've tried to exclude tmp folder from my WebStorm project, make some experiments without using WebStorm. Just execute "ember server" in cmd, that run as administrator and tried to change file using just Notepad. But still problem reproduсeable. What can be reason for that? Antivirus is not causing problems, Index Options were changed, like recommended in Ember-CLI documentation. Thank you for help!

I'm having the same problem. I'm using SublimeText 2, and I've excluded the tmp dir.
I've also made changes for Microsoft Security Essentials and disabled Windows search index for the tmp directory. Any more suggestions?
The problem appears very often (maybe every third time I'm saving a file).

Symptom-wise this looks the same as this issue from Ember Browserify https://github.com/ef4/ember-browserify/issues/17, which was fixed in the most recent version.

Any updates on this issue?

I opened a new issue on rimraf: https://github.com/isaacs/rimraf/issues/72

Thank you! :+1:

Thank you for analysis!
On Mar 21, 2015 11:59 PM, "Martin Thøgersen"<EMAIL_ADDRESS>wrote:

Thank you! [image: :+1:]
—
Reply to this email directly or view it on GitHub
https://github.com/broccolijs/broccoli/issues/232#issuecomment-84459673.

I just want to comment the fix that worked for our entire team. It was actually proposed here https://github.com/npm/npm/issues/7552 by miguelmota. Just perform the following commands:
rm -rf node_modules bower_components dist tmp
npm install ember-cli --save-dev
npm install
bower install

Make sure that the first command is repeated until the entire tmp folder is gone. After this, enjoy your fast, not breaking build

The above did not work for me....

I forgot one step actually. It's that you should move your project to a different partition than the c: Drive. Somehow our windows defender exclusion trick didn't work for c: Drive folders

I have found an interesting issue however, which might be related. I am wondering if somehow some npm module related to Broccoli does not have symlinking permissions?
I am on Windows 7.
I installed npm can-symlink and it told me that I did not have permissions to create symlinks DESPITE the fact that mklink works fine in an Admin command window.

Hi guys, I am also having the ENOTEMPTY errors and long time builds (60+s) with simple Ember CLI app running on Windows 7 and I can't turn off antivirus scanning nor to run command line as admin due to company security policy. Do you have some solution to those guys who can't just simply setup their machines as they want (mainly security staff like admin rights and antiviruses)?

@flucivja actually. Yes, we have been hard at work at more performant internals. We should have something to show in the next few weeks.
Also in the interim, be sure to following the windows instructions on the website closely.

We have done quite a-bit of windows work. Especially with 1.0.
If the problem still arises, please provide a concise runnable example and we reopen and debug.


schema in progress

What does this PR do
The following table is created:
users,
exercise,
user_workout,
workout,
workout_session,
sets,
workout_log
Description of the task to be completed
Schema has to contain all the above tables.
How should this manually be tested
The tables can be tasted by running seeds.
What are the relevant Trello board stories
The database schema to be implemented with PG using Knex.
Screenshots (If appropriate)
Questions (If any):

This PR has been closed because it was a duplicate of #9


Read base image from QCOW in replica

High level goal:
To read the base image qcow for a VM directly from longhorn (by including it in the replica) instead of relying on it to already be in the image. This will let us pass the block device for the root disk directly to KVM.
Users will still creates an image based off of rancher-vm, ie rancher/ubuntu-vm and put the QCOW in that image, but we will then use that image to launch the replicas (in addition to using it to launch the vm itself).

In cattle, in our pre-vm-create logic (where we already add vm-specific configuration) do the following:

add a driver-opt for the root volume for the image, ie: —driver-opt image=rancher/ubuntu-vm
add a driver-opt for the root volume that tells the driver not to format or mount the volume, ie —driver-opt dont-format=true
add a device to the container that will the actual longhorn block device on the host, ie docker run … --device /dev/longhorn/volume-foo-uuid:/dev/vmroot

In the docker longhorn driver, adjust logic to account for the new parameters provided by cattle

If dont-format driver options is present, don’t format or  mount the device
If the image driver option is present, we will use a different rancher-compose file to create the longhorn volume stack. The new stack will basically use two containers: one based off of the user specified image and one that just contains the longhorn binary. The binary container’s volumes will be mounted into the qcow container and the container will be start with an entrypoint/command to start the replica, ie `docker run —entrypoint longhorn rancher/vm-ubuntu replica /dir/to/qcow. Here’s a rough approximation of the new compose file:

replica:
  image: rancher/vm-ubuntu
  volumes_from: binary
  entrypoint: /cmd/longhorn
  command: replica $LONGHORN_DIRECTORY
binary:
  image: longhorn
  volumes:
    - /cmd
  labels:
    io.rancher.start_once: true

In rancher-vm, if /dev/vmroot is present, pass it directly to kvm as the root device, If it isn’t present, use the currently logic of using the qcow in the image and creating a snapshot (this will let rancher-vm work without rancher+longhorn running)

Plan of attack is for me to get all the plumbing working without waiting for the actual read-from-qcow logic in longhorn. Should be able to get this all plumbed without that bit.

Rancher Server version - v1.1.0-dev2-rc1
Longhorn controller image - cjellick/longhorn:dev6
Deployed VM with ROOT and DATA volumes in longhorn.
Replica containers for ROOT volumes are started with VM image.
Replica containers for DATA volumes are started with longhorn image.
Able to read and write successfully into ROOT and DATA volumes.
Migrate VM to a different host ( deactivate the host on which VM is running and delete the VM).
After VM is migrated, we are able to read all the current contents of ROOT and DATA disks and also able to write to ROOT and DATA volumes.


Bump version of ncurses

This is needed because we now depend on ncurses-rs version 5.98.0

I'll close this one, I just updated the dependency to 5.101.0


proposal: net: net.Listener.Iter

Proposal Details
Finally, we had Iterator api in std.
So I propose add net.Litener.Iter that returns an iter.Seq to produce net.Conn or error sequential.
The api may looks like:
type Result[T any] struct {
    data T
    err  error
}

func (r Result[T]) IsOk() bool { return r.err == nil }

func (r Result[T]) IsErr() bool { return r.err!= nil}

func (r Result[T]) Value() T {
    if r.err == nil {
        return r.data
    }
    panic("call value on error")
}

func (r Result[T]) Error() error {
    if r.err != nil {
        return r.err
    }
    panic("call value on data")
}

func Iter(l net.Listener) iter.Seq[Result[net.Conn]] {
	return func(yield func(result.Result[net.Conn]) bool) {
		for yield(result.FromPair(l.Accept())) {
		}
	}
}

While I personally don't like iter.Seq2 to express Either semantics,
because we don't succeed and fail at the same time, or neither succeed nor fail at the same time.
Strictly speaking, this situation should be expressed using the sum type, so the additional Result monad is introduced.

Could you show us some use cases for your proposal? What drove you to make this proposal?

cc @neild

IMO Something like Result is way too generic and would need it's own proposal.

IMO Something like Result is way too generic and would need it's own proposal.
You could also use 2 value iteration.

Using product types to express sum types is an unreasonable thing in itself. I think we can't make any mistakes anymore. It's time to make some changes. Maybe this can be the first place to change.

The convention in slices and maps is to call this “All” not “Iter”.

The proposed new iteration APIs in #61897 provide alternatives to existing functions which return a slice of results, permitting the caller to iterate over results without allocating the entire result slice.
net.Listener.Accept does not have have this flaw: It returns a single result at a time. It is not inconvenient to use. The proposed API here doesn't seem any simpler to use:
for {
  conn, err := listener.Accept()
  if err != nil {
    // handle error
  }
  // ...
}

vs.
for result := listener.Iter() {
  if result.IsErr() {
    // handle error
  }
  conn := result.Value()
  // ...
}

This is at most one line less code, or the same number of lines if we assign conn := result.Value().
Leaving aside the fact that Result really would need its own proposal, I don't think the added complexity of a second API for accepting connections can be justified here.

I wonder how many applications have more than a single call to Listener.Accept; extra syntactic convenience wouldn't help very often. And Accept is such a significant enough operation that perhaps it warrants being explicit within the loop, not hidden in an iterator.

Closing it, for no compelling reason other than to copy the same capabilities from rust.
And due to the lack of type system support for sum type, there has not been much change in usage.


Factorize Link, ButtonEdit, URLPicker

I feel that there the src/helpers/Link should be converted into a component  and that there is too many ways to have an edition of a link or a button in the editor.
We have wordpress/theme/lib/editor/components/ButtonEdit, wordpress/theme/lib/editor/components/UrlPicker & the src/components/atoms/Button/edit.tsx files.
I don't understand exactly too goal of each one.
Here would be my proposition:

Create a component Link in src/components/atoms/Link

it will have the index to render the front-end (which is currently the src/helpers/Link/index.tsx file
an edit.tsx file for the edition in the editor. It should maybe regroup functions of both ButtonEdit and UrlPicker or also in relation to #3

Move the ButtonEdit into the components/atoms/Button/edit.tsx file

What are your thoughts?

@kuuak Yep I agree ! If we can have a common way to add links inside the editor it's perfect !


Fix some problems with the Maven layout

Hi,
I made some small changes to your maven project.  I removed the configured javadoc executable since this breaks the build on machines with other paths to javadoc than yours. (Javadoc should be available in $JAVA_HOME/bin/javadoc per default)
I moved resources in the maven resource directory.
Also, I unified the version information into the parent pom and added the reference to the parent in the child projects.

Thank you for your improvements!


HBASE-27460 Fix the hadolint errors after HBASE-27456

(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4860/1/console in case of problems.

(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4860/1/console in case of problems.

(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4860/1/console in case of problems.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
5m 23s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for branch

_ Patch Compile Tests _

+0 :ok:
mvndep
0m  4s
Maven dependency ordering for patch

_ Other Tests _

6m 29s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4860/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4860

Optional Tests

uname
Linux 5823d9e68082 5.4.0-124-generic #140-Ubuntu SMP Thu Aug 4 02:23:37 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 3f17745f6e

Max. process+thread count
39 (vs. ulimit of 30000)

modules
C:  U:

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4860/1/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
3m 59s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+0 :ok:
shelldocs
0m  0s
Shelldocs was not available.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 12s
Maven dependency ordering for branch

+1 :green_heart:
spotless
0m 36s
branch has no errors when running spotless:check.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m  4s
Maven dependency ordering for patch

+1 :green_heart:
hadolint
0m  1s
The patch generated 0 new + 0 unchanged - 6 fixed = 0 total (was 6)

+1 :green_heart:
shellcheck
0m  0s
There were no new shellcheck issues.

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
spotless
0m 33s
patch has no errors when running spotless:check.


feat: add support for encode&decode

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
According to https://github.com/risingwavelabs/risingwave/issues/8937.
The encode and decode function are implemented in this pull request.

Checklist For Contributors

[x] I have written necessary rustdoc comments
[x] I have added necessary unit tests and integration tests
[ ] I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features #7934).
[x] I have demonstrated that backward compatibility is not broken by breaking changes and created issues to track deprecated features to be removed in the future. (Please refer to the issue)
[x] All checks passed in ./risedev check (or alias, ./risedev c)

Checklist For Reviewers

[x] I have requested macro/micro-benchmarks as this PR can affect performance substantially, and the results are shown.

Documentation

[x] My PR DOES NOT contain user-facing changes.

Click here for Documentation
Types of user-facing changes
Please keep the types that apply to your changes, and remove the others.

Installation and deployment
Connector (sources & sinks)
SQL commands, functions, and operators
RisingWave cluster configuration changes
Other (please specify in the release note below)

Release note

Could you help enable the test cases here: https://github.com/risingwavelabs/risingwave/blob/0bdc988be5cb8b307e204815f9237c6949f664c9/src/tests/regress/data/sql/strings.sql#L649

SELECT encode(('\x' || repeat('1234567890abcdef0001', 7))::bytea, 'base64'); SELECT decode(encode(('\x' || repeat('1234567890abcdef0001', 7))::bytea, 'base64'), 'base64'); These two sqls will produce an error: ERROR: QueryError: Bind error: cannot cast type "varchar" to "bytea" in Explicit context
Seems like an error happend in compile-time which cast expr bind error. I see that no Bytea type mentioned in CAST_MAP https://github.com/risingwavelabs/risingwave/blob/main/src/expr/src/sig/cast.rs#L51

I see that the cast function [varchar->bytea] was already implemented here https://github.com/risingwavelabs/risingwave/blob/main/src/expr/src/vector_op/cast.rs#L196
So I fix it by simple add Bytea type to CAST_MAP, see commit：https://github.com/risingwavelabs/risingwave/pull/9351/commits/432b7052926f65eebf2f17ef420ee03095dac9b4
Is there something wrong with this fix?

After I changed the CAST_MAP, I should also modify the e2e_test/batch/catalog/pg_cast.slt.part following the change of cast_map.
By the way, I also fixed the from_oid function here https://github.com/risingwavelabs/risingwave/blob/main/src/common/src/types/postgres_type.rs#L48, there was no Bytea before.
See https://github.com/risingwavelabs/risingwave/pull/9351/commits/186bc936037e940fae7fc79ebf2710c2b19022ce
Finally, all the test was passsed now🥳.


Decouple NDArray storage from NDArray and make math global

This change is

I am so excited for auto-tracking and the simplicity of default math!
Left some comments inline, but nothing serious. Before you commit this could you add a description to the PR / commit before you merge?

Reviewed 9 of 18 files at r1, 25 of 25 files at r2.
Review status: all files reviewed at latest revision, 20 unresolved discussions, some commit checks failed.

src/environment.ts, line 161 at r2 (raw file):

function getBestBackend(): string {
  const backendIds = ['webgl', 'cpu'];

How about "orderedBackendIds" or "backendPriorities"
Let's also add an enum for these

src/environment.ts, line 221 at r2 (raw file):

  setGlobalMath(math: NDArrayMath) {
    this.currentMath = math;

let's call "currentMath" "globalMath" just so it's clear they're the same thing

src/environment.ts, line 227 at r2 (raw file):

    if (this.currentMath == null) {
      const bestBackend = getBestBackend();
      this.currentMath = new NDArrayMath(bestBackend, false);

const safeMode = false; ... NDArrayMath(bestBackend, safeMode);

src/index.ts, line 56 at r2 (raw file):

export {LSTMCell, NDArrayMath} from './math/math';
// TODO(nsthorat): Remove this once we decouple NDArray from storage mechanism.
export {initializeGPU} from './math/ndarray';

can you add a TODO in our models to move away from initializeGPU since this is going to break them if we update?

src/test_util.ts, line 208 at r2 (raw file):

      testNameBase, tests as Tests[],
      (testName, tests, features) => executeMathTests(testName, tests, () => {
        return new NDArrayMath(new MathBackendCPU(), true);

name "true"
Here and in describeMathGPU

src/graph/ops/reduce_sum.ts, line 35 at r2 (raw file):

    super();
    util.assertShapesMatch(outTensor.shape, []);
    this.ones = NDArray.zeros(x.shape);

use ones:
https://github.com/PAIR-code/deeplearnjs/blob/master/src/math/ndarray.ts#L132

src/math/math.ts, line 68 at r2 (raw file):

    this.backend.write(id, values, dtype, shape);
  }
  disposeData(id: number): void {

nit: move disposeData to the end of class (this is going to be a commonly read file and we wont )

src/math/math.ts, line 96 at r2 (raw file):

   *     a math.scope() which will automatically clean up intermediate NDArrays.
   */
  constructor(backend: string|MathBackend, private safeMode: boolean) {

once the backend string is an enum, change the type here

src/math/math.ts, line 271 at r2 (raw file):

            'leaks.');
      }
      this.startScope();

Why are you starting a new scope here?

src/math/math_test.ts, line 49 at r2 (raw file):

      a.dispose();
      b.dispose();
      expect(math.getNumArrays()).toBe(0);

Instead of disposing these NDArrays manually, you now have auto-tracking functionality. I think a better test here would be instead to wrap everything before this line in a scope to make sure global tracking is working.
Alternatively you could move a unit test with that functionality to its own test.

src/math/matmul_test.ts, line 298 at r2 (raw file):

const gpuTests: MathTests = it => {
  it('Matrix times vector, larger than max texture size', math => {

this test is a little misleading now, maybe just say large matrix

src/math/ndarray.ts, line 222 at r2 (raw file):

  asType<G extends keyof DataTypes>(dtype: G): NDArray<G> {
    const vals = this.dataSync();

add a TODO here (we migrated fromPixels properly to both backends but we didn't migrate asType)

src/math/ndarray.ts, line 243 at r2 (raw file):

  }

  set(value: number, ...locs: number[]) {

can you check locs.length === this.rank

src/math/ndarray.ts, line 308 at r2 (raw file):

  dispose(): void {
    ENV.math.disposeData(this.id);

Small regression: now if you try to use a disposed NDArray we don't get a nice error (which was the point of throwIfDisposed).
You should bring that back (just save a bit here since you want it to be backend agnostic).

src/math/reduction_ops_test.ts, line 442 at r2 (raw file):

      test_util.expectNumbersClose(result.get(), 7);

      a.dispose();

optional: these disposes are now not needed since all NDArrays are tracked!

src/math/types.ts, line 32 at r2 (raw file):

}

export interface Int32And {

how about Int32UpcastWith here and below

src/math/backends/backend.ts, line 28 at r2 (raw file):

}

export const BACKEND_REGISTRY: {[id: string]: MathBackend} = {};

let's make the id an enum (you can use the keyword 'in' to use non-string keys)

src/math/backends/backend_webgl.ts, line 61 at r2 (raw file):

import * as webgl_util from './webgl/webgl_util';

function float32ToTypedArray<T extends keyof DataTypes>(

nit: these utilities seem less important than the backend itself, can you move it to the bottom of the file?

src/math/backends/backend_webgl.ts, line 128 at r2 (raw file):

    }
  }
  disposeData(id: number): void {

nit: move this after the read functions

src/math/backends/webgl/gpgpu_math.ts, line 52 at r2 (raw file):

}

export interface ArrayData<T> {

can you restrict T here so it's clear what ArrayData is for?

Comments from Reviewable

Thank you for the great thorough review!

Reviewed 1 of 25 files at r2.
Review status: all files reviewed at latest revision, 20 unresolved discussions, some commit checks failed.

src/environment.ts, line 161 at r2 (raw file):
Previously, nsthorat (Nikhil Thorat) wrote…
How about "orderedBackendIds" or "backendPriorities"
Let's also add an enum for these

Done.

src/environment.ts, line 221 at r2 (raw file):
Previously, nsthorat (Nikhil Thorat) wrote…
let's call "currentMath" "globalMath" just so it's clear they're the same thing

Done.

src/environment.ts, line 227 at r2 (raw file):
Previously, nsthorat (Nikhil Thorat) wrote…
const safeMode = false; ... NDArrayMath(bestBackend, safeMode);

Done.

src/index.ts, line 56 at r2 (raw file):
Previously, nsthorat (Nikhil Thorat) wrote…
can you add a TODO in our models to move away from initializeGPU since this is going to break them if we update?

It turns out all usages of initializeGPU in our codebase have a TODO already :)
We almost don't really need a TODO. It's really nice that models depend on older version of dljs and nothing breaks. And when we update demos/package.json and reinstall dljs, the compiler will start complaining.

src/test_util.ts, line 208 at r2 (raw file):
Previously, nsthorat (Nikhil Thorat) wrote…
name "true"
Here and in describeMathGPU

Done.

src/graph/ops/reduce_sum.ts, line 35 at r2 (raw file):
Previously, nsthorat (Nikhil Thorat) wrote…
use ones:
https://github.com/PAIR-code/deeplearnjs/blob/master/src/math/ndarray.ts#L132

Done. This was before I synced!

src/math/math.ts, line 68 at r2 (raw file):
Previously, nsthorat (Nikhil Thorat) wrote…
nit: move disposeData to the end of class (this is going to be a commonly read file and we wont )

Done.

src/math/math.ts, line 96 at r2 (raw file):
Previously, nsthorat (Nikhil Thorat) wrote…
once the backend string is an enum, change the type here

Done.

src/math/math.ts, line 271 at r2 (raw file):
Previously, nsthorat (Nikhil Thorat) wrote…
Why are you starting a new scope here?

I didn't add it for a particularly strong reason. The reasoning was: when safeMode is off, and the user didn't use explicit scope, an implicit scope is nice, since that allows us to add math.cleanup() later, which will clean up things in the implicit scope. Implicit scope is also useful when we visualize allocated arrays in a hierarchical way, useful for debugging.
I can remove it if you feel otherwise.

src/math/math_test.ts, line 49 at r2 (raw file):
Previously, nsthorat (Nikhil Thorat) wrote…
Instead of disposing these NDArrays manually, you now have auto-tracking functionality. I think a better test here would be instead to wrap everything before this line in a scope to make sure global tracking is working.
Alternatively you could move a unit test with that functionality to its own test.

great idea. added.

src/math/matmul_test.ts, line 298 at r2 (raw file):
Previously, nsthorat (Nikhil Thorat) wrote…
this test is a little misleading now, maybe just say large matrix

Done.

src/math/ndarray.ts, line 222 at r2 (raw file):
Previously, nsthorat (Nikhil Thorat) wrote…
add a TODO here (we migrated fromPixels properly to both backends but we didn't migrate asType)

Done.

src/math/ndarray.ts, line 243 at r2 (raw file):
Previously, nsthorat (Nikhil Thorat) wrote…
can you check locs.length === this.rank

Done.

src/math/ndarray.ts, line 308 at r2 (raw file):
Previously, nsthorat (Nikhil Thorat) wrote…
Small regression: now if you try to use a disposed NDArray we don't get a nice error (which was the point of throwIfDisposed).
You should bring that back (just save a bit here since you want it to be backend agnostic).

Done. Brough back isDisposed and throwIfDisposed

src/math/reduction_ops_test.ts, line 442 at r2 (raw file):
Previously, nsthorat (Nikhil Thorat) wrote…
optional: these disposes are now not needed since all NDArrays are tracked!

great point, especially since we do startScope endScope internally in test_util. Won't clean up all tests in this PR, but it's great to see the benefit of global tracking in providing much cleaner tests!

src/math/types.ts, line 32 at r2 (raw file):
Previously, nsthorat (Nikhil Thorat) wrote…
how about Int32UpcastWith here and below

Done.

src/math/backends/backend.ts, line 28 at r2 (raw file):
Previously, nsthorat (Nikhil Thorat) wrote…
let's make the id an enum (you can use the keyword 'in' to use non-string keys)

Done.

src/math/backends/backend_webgl.ts, line 61 at r2 (raw file):
Previously, nsthorat (Nikhil Thorat) wrote…
nit: these utilities seem less important than the backend itself, can you move it to the bottom of the file?

Done.

src/math/backends/backend_webgl.ts, line 128 at r2 (raw file):
Previously, nsthorat (Nikhil Thorat) wrote…
nit: move this after the read functions

Done.

src/math/backends/webgl/gpgpu_math.ts, line 52 at r2 (raw file):
Previously, nsthorat (Nikhil Thorat) wrote…
can you restrict T here so it's clear what ArrayData is for?

Done.

Comments from Reviewable

Review status: 21 of 34 files reviewed at latest revision, 20 unresolved discussions, some commit checks failed.

src/math/math.ts, line 271 at r2 (raw file):
Previously, dsmilkov (Daniel Smilkov) wrote…
I didn't add it for a particularly strong reason. The reasoning was: when safeMode is off, and the user didn't use explicit scope, an implicit scope is nice, since that allows us to add math.cleanup() later, which will clean up things in the implicit scope. Implicit scope is also useful when we visualize allocated arrays in a hierarchical way, useful for debugging.
I can remove it if you feel otherwise.

How about let's start a global scope when math is created. I think this will have a problem where if you create too many inner scopes and there isn't a corresponding endScope, you will not clean everything up.
math.cleanup() will then simply end the global scope, and start a new global scope.

Comments from Reviewable

FYI you will have to merge with:
https://github.com/PAIR-code/deeplearnjs/pull/425

Review status: 19 of 36 files reviewed at latest revision, 20 unresolved discussions, some commit checks pending.

src/math/math.ts, line 271 at r2 (raw file):
Previously, nsthorat (Nikhil Thorat) wrote…
How about let's start a global scope when math is created. I think this will have a problem where if you create too many inner scopes and there isn't a corresponding endScope, you will not clean everything up.
math.cleanup() will then simply end the global scope, and start a new global scope.

Done.

Comments from Reviewable


Fix kubectl commands in README.md

This change is

Jenkins job istio/presubmit passed

Jenkins job istio/presubmit passed


Improved the UI of the "Share your thoughts section"

Improved the UI of the "Share your thoughts section"
BEFORE

AFTER

@Pranav-Singh-Devloper Your pull request has been successfully merged! Don't stop here—continue contributing by addressing more issues and aiming to become a top contributor. You can also contribute in my another Repository BuddyTrail which is also under Hacktoberfest
Great contribution to HACKTOBERFEST'24! 🎉


Functions returning objects or records

Hi,
I have been looking at implementing the Regex module.
How would I go about returning objects?
(ex: Match object, with .Success, .Groups, .Captures etc.)
Do I just return a map or a record?

A record might work. Depends on what data you need.

The type you return is effectively opaque to the caller as it will be passed to the member function as it's first parameter. I'd suggest you write a simple example. compile it and look at the .core file to see what it is doing.

Thanks, will give it a try

Sorry, been a bit busy!
Still having some trouble with this.
The core file seems to generate a get_<field-name> function.
So using var.Groups in f# seems to generate
'System.Text.RegularExpressions.Match':get_Groups(#{'Captures' => [],'Groups' => [],'Length' => 0,'Success' => false,
  'Value' => ''})

which does not exist
Using a record also results in a get_Groups({some, tuple, here})
Any pointers?

Yes you need to implement the function as generated as an erlang module in
src
On Fri, 30 Jun 2017 at 17:59, rascala<EMAIL_ADDRESS>wrote:

Sorry, been a bit busy!
Still having some trouble with this.
The core file seems to generate a get_ function.
So using var.Groups in f# seems to generate
'System.Text.RegularExpressions.Match':get_Groups(#{'Captures' => [],'Groups' => [],'Length' => 0,'Success' => false,
'Value' => ''})
which does not exist
Using a record also results in a get_Groups({some, tuple, here})
Any pointers?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/kjnilsson/fez/issues/18#issuecomment-312320363, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABIDlIAZSYNIR3GU8QFnaMVnLqeOAlm0ks5sJSmFgaJpZM4OC2jf
.

You probably want to pull the latest changes As there are potential changes to how objects are constructed.

See this as an example.
https://github.com/kjnilsson/fez/blob/master/src/System.Lazy_1.erl

Thanks,
I have a very basic regex working(without global-match etc.), but its very ugly with different files for Capture/CaptureCollection/Group/GroupCollection/Match/Regex types and respective get_<field>s all over.
But it works! And returns captured groups and their values etc.
I will try to clean them up a bit, add more tests and add the match-options.
Wouldn't it be cleaner if all System.Text.RegularExpressions/* files were grouped into a separate directory?
And maybe all these should be grouped into a lib/stdlib directory? So that src does not get cluttered?

Cool. It's fine to have them all in src. It's typical of erlang.
Subdirectories add very little IMO.
On Sun, 2 Jul 2017 at 15:18, rascala<EMAIL_ADDRESS>wrote:

Thanks,
I have a very basic regex working(without global-match etc.), but its very
ugly with different files for
Capture/CaptureCollection/Group/GroupCollection/Match/Regex types and
respective get_s all over.
But it works! And returns captured groups and their values etc.
I will try to clean them up a bit, add more tests and add the
match-options.
Wouldn't it be cleaner if all System.Text.RegularExpressions/* files were
grouped into a separate directory?
And maybe all these should be grouped into a lib/stdlib directory? So that
src does not get cluttered?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/kjnilsson/fez/issues/18#issuecomment-312494496, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABIDlCmYHP9NXCuysqC8pZjGoQuQtmm8ks5sJ6abgaJpZM4OC2jf
.

@rascala I just made some significant changes to how functions and modules are generated which may affect the work you have in progress. I'd recommend you pull and check the .core files to see what modules and names are required.


Add package nimfunge98

Sorry, nimble publish issued an incomplete PR, I will remake a proper one manually.


Tuning set for 2.5

gfx900-56cu / gfx900-64cu
iGEMM, fp32 only -- all Recurrent
3D convolution iGEMM, fp32 -- all configs
All solvers, fp32 only -- batch size 1
gfx906-60cu / gfx906-60cu
iGEMM, fp32-fp16  -- all Recurrent
3D convolution iGEMM, fp32 -- all configs
All solvers, fp32-fp16              -- batch size 1
gfx908
iGEMM, fp32, fp16, bfp16 -- ResNet50 and ResNext101

And anything missed from this ticket: https://github.com/ROCmSoftwarePlatform/MIOpen/issues/161

And anything missed from this ticket: #161

On this ticket, where are the Driver cmds? are they under "Test Cases to Replicate Issue"?

configs tagged so far:
"recurrent"
"3d"
"obsolete" - taken from http://ontrack-internal.amd.com/browse/SWDEV-234450

miopen_benchmark.zip
performance comparison

Performance Comparison

Model
precision
batchsize
This PR
develop
Speed Up over develop

inception3
fp32
128
123.12
108.39
113.59%

inception3
fp16
128
90.29
76.36
118.24%

inception4
fp32
64
54.54
56.06
97.29%

inception4
fp16
64
44.69
36.52
122.37%

resnet101
fp32
64
113.71
110.63
102.78%

resnet101
fp16
64
116.23
115.99
100.21%

resnet50
fp32
128
197.46
197.55
99.95%

resnet50
fp16
128
206.5
207.35
99.59%

resnet50_v1.5
fp32
64
172.4
168.16
102.52%

resnet50_v1.5
fp16
64
176.42
176.48
99.97%


x/pkgsite: please add ODbL license to list of approved licenses

Hi, I’m the author of the ZoneDB package (https://pkg.go.dev/github.com/zonedb/zonedb). I visited the GoDoc page for the package today and discovered that the documentation was suppressed because the license we specify in LICENSE.md is not accepted.
This is a request to add the Open Data Commons Open Database License (ODbL) to the list of approved licenses.
We could split the license into a separate license for the code and one for the underlying data (zones.txt and metadata JSON files), but it seems inconsistent as the Go package is derived from the base data.
Thanks!
What is the URL of the page with the issue?
https://pkg.go.dev/github.com/zonedb/zonedb
No documentation due to policy: https://pkg.go.dev/license-policy
What is your user agent?

Safari
Screenshot

What did you do?

Visit the GoDoc page for the zonedb package at: https://pkg.go.dev/github.com/zonedb/zonedb
What did you expect to see?
GoDoc documentation for ZoneDB.
What did you see instead?

Our license policy was recently clarified: we can only accept OSI approved licenses. As the Open Data Commons Open Database License (ODbL) is not on the list, this won't be possible.

Looks like the last time OSI contemplated this was 12 years ago:
https://lists.opensource.org/pipermail/license-review_lists.opensource.org/2011-June/001280.html
Mike,

> I have some questions about the ODBL
> http://www.opendatacommons.org/licenses/odbl/

To date, OSI has not reviewed or certified any oben content licenses,
which are necessarily different in structure from open source
licenses.  This has been discussed, but currently is not a practice of
OSI.

I've been thinking of setting up a new working group on open content,
but that would put us at least a year away from certifying anyone.

--Josh Berkus

I went ahead and dual-licensed it (code under MIT, database under ODbL). Not ideal, but I’d prefer to not have to split the repo.


Turn some list-walkers into sequence-walkers

quilc's web interface deserializes lists into lists, and the RPCQ interface deserializes lists into vectors. I made some bad assumptions in #210's chip-reader.lisp about which sequence type would be coming down the wire. This hotfix corrects that.

FWIW: I can round-trip jobs from pyQuil with this PR in place.

Let's not merge this until I figure out the relationship to Mark's other bug.


Provide IDE plugin to highlight mismatches between gradle/maven dependencies and used declarations

E.g. if script is using:
@file:DependsOn("de.mpicbg.scicomp:kutils:0.8.4")

but pom/gradle is indicating just
compile "de.mpicbg.scicomp:kutils:0.8.3"

the script line should be tagged with a warning such as

Mismatch between script and project dependencies.

Closed in favor of #148


Optimise mirroring

Presently mirroring uses "piece" requests. This is all well and good, but the back-and-forth required to request a piece suffers massively in low-latency environments (like Tor), greatly increasing the time needed for a mirror.
Mirroring should instead just start streaming down piece after piece, with no feedback. Piece requests can remain.
Perhaps also allow "ranges" for mirroring, or maybe make it batched piece requests. For instance, ask a peer for pieces 1-100, rather than just piece 1.

All done!


Toast intent

Adding toast intent support.
I've added intent to ToastProvider so that the default intent can be changed. Is that ok?
Let me know if anything needs to be changed.

Except for the CI error, there are no other problems.

Fixed. I will try to do dismiss action next.

Thanks!


HP keeps showing as unavailable

System Health details
System Information

version
core-2024.1.6

installation_type
Home Assistant OS

dev
false

hassio
true

docker
true

user
root

virtualenv
false

python_version
3.11.6

os_name
Linux

os_version
6.1.74-haos

arch
aarch64

timezone
Europe/London

config_dir
/config

Home Assistant Community Store

GitHub API
ok

GitHub Content
ok

GitHub Web
ok

GitHub API Calls Remaining
5000

Installed Version
1.34.0

Stage
running

Available Repositories
1387

Downloaded Repositories
30

Home Assistant Cloud

logged_in
true

subscription_expiration
13 February 2024 at 00:00

relayer_connected
true

relayer_region
eu-central-1

remote_enabled
true

remote_connected
true

alexa_enabled
false

google_enabled
true

remote_server
eu-central-1-14.ui.nabu.casa

certificate_status
ready

instance_id
06da5d9fc16149ee94e75958ea0db39b

can_reach_cert_server
ok

can_reach_cloud_auth
ok

can_reach_cloud
ok

Home Assistant Supervisor

host_os
Home Assistant OS 11.5

update_channel
stable

supervisor_version
supervisor-2024.01.1

agent_version
1.6.0

docker_version
24.0.7

disk_total
56.6 GB

disk_used
13.3 GB

healthy
true

supported
true

board
odroid-n2

supervisor_api
ok

version_api
ok

installed_addons
Samba share (12.2.0), Terminal & SSH (9.8.1), Mosquitto broker (6.4.0), GivTCP (2.4.3), File editor (5.7.0), eWeLink Smart Home (1.4.3), appdaemon-predbat (1.0.6)

Dashboards

dashboards
1

resources
18

views
18

mode
storage

Recorder

oldest_recorder_run
31 January 2024 at 09:42

current_recorder_run
8 February 2024 at 20:07

estimated_db_size
1815.05 MiB

database_engine
sqlite

database_version
3.41.2

Solcast PV Forecast

can_reach_server
ok

used_requests
1

rooftop_site_count
1

Checklist

[X] I have given details of my install including what type of system airsource/ watersource or groundsource
[X] I have provided logs showing any errors.
[X] I have filled out the issue template to the best of my ability.
[X] This issue only contains 1 issue (if you have multiple issues, open one issue for each issue).
[X] This issue is not a duplicate issue of currently previous issues..

Describe the issue
My Mastertherm HP, at random points, becomes unavailable through HA.  I can't seem to find out why, the network is rock solid (HP connected via LAN) and no other devices have this issue.
I wonder if anyone else has this?
Reproduction steps
Through logbook, HP shows as unavailable for around 2 -3 minutes at a time.
Logs
N/A

Diagnostics dump, if available
No response

Yes! I believe I have the same issue. Usually it happens about once or twice a day, but lately I've had periods where sometimes even for hours it will be unavailable nearly all the time. I feel like these are temporary outages or issues on MasterTherm's end, but I don't know for sure. Maybe we can see if these line up between all of us? I'm in Europe, Belgium.

Here you can see when my 'Unavailable' occurs in the past 24 hours or so.

Also what version there are two different API's I am on the older one other than the 8th Feb for 2 hours and another event this year I have not had many outages.
Note the Operating Mode has Offline which means the API is working but can't talk to the Heat Pump and then Unavailable which means the API is not talking, I did this to separate out when your pump is not talking to the API vs when the API is shutdown.
Easier to show the outside temp as it shows a break when offline or unavailable.

Mine seems a bit less than yours

In the last 24 hours (times are GMT)
8 Feb: 1602-1606 - duration 3:59
8 Feb: 1921-1927 - duration 6:00
9 Feb: 0202-0204 - duration 2:00
Looking back a bit further, the downtime almost always seems to be either 2:00, 3:59 or 6:00.  The times are not consistent and there is no pattern.

Also what version there are two different API's I am on the older one other than the 8th Feb for 2 hours and another event this year I have not had many outages.
Note the Operating Mode has Offline which means the API is working but can't talk to the Heat Pump and then Unavailable which means the API is not talking, I did this to separate out when your pump is not talking to the API vs when the API is shutdown.
Easier to show the outside temp as it shows a break when offline or unavailable.

Checking my outside temp, it shows no temperature during the exact times when my HP is unavailable.

White at the beginning is unavailable mine is v1 api.

one more thing I noticed I had outage and could not login via the mobile app or could login but got no pump avaialable, at one point it said my password was invalid.
However at that time I could login to the demo server, so not sure their system is totally robust.

Don't suppose anyone has the error's in the log for this, should be Connection Error or Timeout Error or FormatError.

Don't suppose anyone has the error's in the log for this, should be Connection Error or Timeout Error or FormatError.

Where would we find this?

In Settings->System-Logs when opens it shows summary of warnings and errors, search for MasterTherm.  Don't share a log with the Module id e.g. mt_1234_1 remove that bit first.
There will be errors as I report both API and Integration errors when connections fail if the failure is not temporary.

This is standard as its not integrated with HASS (thinking about doing that so its a core integration.
you will see an ERRROR with mastertherm, the logs are reset after a restart maybe check after you see an issue in the history and before re-starting.

Example you either re-started or have a very clean system I would expect two warnings after 2024.2.0 update as I have just raised an issue for those.

I also have nothing useful in the logs right now, as my home assistant restarts many times a day with no trace in the logs as to what it is doing. I suspect maybe my Raspberry Pi 3 is not handling everything, so I'm looking to upgrade to a more powerful home assistant system. I'll share the log when MasterTherm goes offline again.

I also have nothing useful in the logs right now, as my home assistant restarts many times a day with no trace in the logs as to what it is doing. I suspect maybe my Raspberry Pi 3 is not handling everything, so I'm looking to upgrade to a more powerful home assistant system. I'll share the log when MasterTherm goes offline again.

That is weird some issue with the Pi 3?  I am running the HASS OS in a VM under Unraid, it stays up until I re-start it or do an update, about once a month.
I setup a HASS Yellow for my friend that has been up since the 1st Feb (when I updated it) no issues. actually quite impressed with that.
Maybe out of memory issues?
If you ssh in you have under the homeassistant folder older logs e,g, home-assistant.log.1 which is the older one.

Anyone further updates or has the system stabalised.
For local access it should be possible and works the same way as the cloud API, however I am not able to get past the initial authorization step as I believe I need a valid client certificate (not user/ password).  My installer is reaching out to Mastertherm to see if I can have the certificate but not holding my breath.
You can access the heat pump locally using ssh (with some really weird parameters), telnet with a password and it has https using non standard crypts and client certificate.  So unless Mastertherm give me a valid certificate or password I am a not able to make progress.

This morning I got one of the worst offline/online situations ever:

All the orange is where the operating mode of the pump is set to 'Offline'. The longest of these are about 7 minutes, sometimes it's just a minute.
Without debug logging, the logs show nothing important. With debug logging, I don't see much either. Just:
2024-03-11 09:37:01.395 DEBUG (MainThread) [custom_components.mastertherm.coordinator] Finished fetching mastertherm data in 11.332 seconds (success: True)
2024-03-11 09:38:01.422 DEBUG (MainThread) [custom_components.mastertherm.coordinator] Finished fetching mastertherm data in 0.360 seconds (success: True)
2024-03-11 09:39:03.737 DEBUG (MainThread) [custom_components.mastertherm.coordinator] Finished fetching mastertherm data in 2.674 seconds (success: True)

I believe the middle one was actually where the entities turned 'unavailable', though it seems to log everything was successful. Strange.

This morning I got one of the worst offline/online situations ever:

All the orange is where the operating mode of the pump is set to 'Offline'. The longest of these are about 7 minutes, sometimes it's just a minute.
Without debug logging, the logs show nothing important. With debug logging, I don't see much either. Just:
2024-03-11 09:37:01.395 DEBUG (MainThread) [custom_components.mastertherm.coordinator] Finished fetching mastertherm data in 11.332 seconds (success: True)
2024-03-11 09:38:01.422 DEBUG (MainThread) [custom_components.mastertherm.coordinator] Finished fetching mastertherm data in 0.360 seconds (success: True)
2024-03-11 09:39:03.737 DEBUG (MainThread) [custom_components.mastertherm.coordinator] Finished fetching mastertherm data in 2.674 seconds (success: True)
2024-03-11 09:41:03.059 DEBUG (MainThread) [custom_components.mastertherm.coordinator] Finished fetching mastertherm data in 59.996 seconds (success: True)

I believe the middle one was actually where the entities turned 'unavailable', though it seems to log everything was successful. Strange.

Might need to turn on the masterthermconnect debug logs there are more detailed about in and out in that.  masterthermconnect:debug.
Although its going to give a fair amount of logs.

Ah, how do I enable that one?

Just add below the custom_components.mastertherm: debug
logger:
logs:
custom_components.mastertherm: debug
masterthermconnect: debug
masterthermconnect: debug

Hmm, even before enabling mastherthermconnect debug I now see a few errors:
2024-03-11 09:44:20.486 DEBUG (MainThread) [custom_components.mastertherm.coordinator] Finished fetching mastertherm data in 0.424 seconds (success: True)
2024-03-11 09:45:38.048 DEBUG (MainThread) [custom_components.mastertherm.coordinator] Finished setting mastertherm data in 37.6641 seconds
2024-03-11 09:45:38.910 DEBUG (MainThread) [custom_components.mastertherm.coordinator] Finished fetching mastertherm data in 18.847 seconds (success: True)
2024-03-11 09:47:39.885 ERROR (MainThread) [custom_components.mastertherm.coordinator] Unexpected error fetching mastertherm data: 504
Traceback (most recent call last):
  File "/usr/local/lib/python3.12/site-packages/masterthermconnect/api.py", line 221, in __get
    response_json = await response.json()
                    ^^^^^^^^^^^^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/helpers/aiohttp_client.py", line 71, in json
    return await super().json(*args, loads=loads, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/site-packages/aiohttp/client_reqrep.py", line 1166, in json
    raise ContentTypeError(
aiohttp.client_exceptions.ContentTypeError: 0, message='Attempt to decode JSON with unexpected mimetype: text/html', url=URL('https://mastertherm.online/api/v1/hp_data?moduleId=xxxxx&deviceId=1&application=android&messageId=2&lastUpdateTime=0&errorResponse=true&fullRange=true')

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/helpers/update_coordinator.py", line 318, in _async_refresh
    self.data = await self._async_update_data()
                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/config/custom_components/mastertherm/coordinator.py", line 154, in _async_update_data
    refreshed = await self.mt_controller.refresh()
                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/site-packages/masterthermconnect/controller.py", line 376, in refresh
    await self.__get_hp_updates(full_load=full_load)
  File "/usr/local/lib/python3.12/site-packages/masterthermconnect/controller.py", line 244, in __get_hp_updates
    device_data = await self.__api.get_device_data(
                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/site-packages/masterthermconnect/api.py", line 457, in get_device_data
    response_json = await self.__get(
                    ^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/site-packages/masterthermconnect/api.py", line 235, in __get
    raise MasterthermServerTimeoutError(
masterthermconnect.exceptions.MasterthermServerTimeoutError: 504
2024-03-11 09:47:39.891 DEBUG (MainThread) [custom_components.mastertherm.coordinator] Finished fetching mastertherm data in 60.828 seconds (success: False)

and
2024-03-11 09:59:09.873 ERROR (MainThread) [custom_components.mastertherm.coordinator] Unexpected error fetching mastertherm data: 504
Traceback (most recent call last):
  File "/usr/local/lib/python3.12/site-packages/masterthermconnect/api.py", line 221, in __get
    response_json = await response.json()
                    ^^^^^^^^^^^^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/helpers/aiohttp_client.py", line 71, in json
    return await super().json(*args, loads=loads, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/site-packages/aiohttp/client_reqrep.py", line 1166, in json
    raise ContentTypeError(
aiohttp.client_exceptions.ContentTypeError: 0, message='Attempt to decode JSON with unexpected mimetype: text/html', url=URL('https://mastertherm.online/api/v1/hp_data?moduleId=xxxxx&deviceId=1&application=android&messageId=2&lastUpdateTime=1710147424&errorResponse=true&fullRange=true')

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/helpers/update_coordinator.py", line 318, in _async_refresh
    self.data = await self._async_update_data()
                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/config/custom_components/mastertherm/coordinator.py", line 154, in _async_update_data
    refreshed = await self.mt_controller.refresh()
                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/site-packages/masterthermconnect/controller.py", line 376, in refresh
    await self.__get_hp_updates(full_load=full_load)
  File "/usr/local/lib/python3.12/site-packages/masterthermconnect/controller.py", line 244, in __get_hp_updates
    device_data = await self.__api.get_device_data(
                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/site-packages/masterthermconnect/api.py", line 457, in get_device_data
    response_json = await self.__get(
                    ^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/site-packages/masterthermconnect/api.py", line 235, in __get
    raise MasterthermServerTimeoutError(
masterthermconnect.exceptions.MasterthermServerTimeoutError: 504
2024-03-11 09:59:09.881 DEBUG (MainThread) [custom_components.mastertherm.coordinator] Finished fetching mastertherm data in 60.819 seconds (success: False)

It looks like it's giving me a text/html page instead of your expected JSON. I can try to access the URL through postman and see what it gives me. Maybe it's rate control or something.

Yes more likely the server is not responding in time.

So it looks like the hp_data request sometimes takes a long time. I just ran the request using postman and it took 32s to return data. The next request takes just 57ms...
Actually, now it seems the heatpump is offline, as mastertherm.online now returns a data out-of-date error:
"error": {
        "errorId": 9,
        "errorMessage": "Data out-of-date (last update 2024-03-11 09:38:47 UTC)"
    },

I saw a Gateway timeout page once, but I didn't save it. That explains the json parsing error.

is it worth just restarting your HP?  Maybe its disconnecting from their API.

I will turn off and on the heat pump, see if that helps.

Power cycling the heat pump did not help. After it came back up, I also got a 504 gateway time out just now:
This one came after 41.22s:

504 Gateway Time-out

The server didn't respond in time.

Retrying the request gives me correct data after 11.9s.
Is this something you want to handle better maybe? Perhaps some automatic retrying when a gateway timeout occurs, with exponential backoff? Maybe 3 retries max before failing?

its not you its their service.

Oh even with their demo account? Let's go local access!

Yeh, I think I need a client certificate to connect and no response as yet.
there is a user/ password that the installer should have and probably a certificate but they will only give me that if Mastertherm say its ok.
They said they would check that was a couple of weeks ago.

Sent you a message on Discord

@discodancerstu , @johny-mnemonic
We are working on local access using modbus which seems to be available in the MT servers, tracking the issue here and could do with support in analysing data as different HP's have different mappins.
https://github.com/sHedC/python-masterthermconnect/issues/113


Add missing pcl library to tests_camera_core

The PR is due to the compile error on Arch Linux.
/usr/bin/ld: CMakeFiles/tests_camera_core.dir/test/camera_core.cpp.o: undefined reference to symbol '_ZN3pcl7console5printENS0_15VERBOSITY_LEVELEPKcz'
/usr/bin/ld: /usr/lib/libpcl_common.so.1.8: error adding symbols: DSO missing from command line

The cause is that the tests_camera_core module requires pcl::console::print, which library -lpcl_common is missing in command line. The patch fixes it by adding PCL libraries in cmake.

I don't understand what is it that you fix.
tests_camera_core and camera_core.cpp are not part of realsense2_camera.

I see. It is a compatibility fix for indigo release. You may see the PR is merged to indigo-devel. The fix is due to the fact that the modern CMake on Arch Linux does not link correct pcl library.


Add brightness_scale_min to MQTT light

Description:
Added brightness_scale_min option to the MQTT Lights
Related issue (if applicable): fixes #
Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#10338
Example entry for configuration.yaml (if applicable):
light:
  platform: mqtt
  name: 'Bedroom Lights'
  command_topic: "sonoff/dimmer_a/cmnd/POWER1"
  state_topic: "sonoff/dimmer_a/tele/STATE"
  state_value_template: "{{value_json.POWER1}}"
  brightness_command_topic: "sonoff/dimmer_a/cmnd/Dimmer"
  brightness_state_topic: "sonoff/dimmer_a/tele/STATE"
  brightness_scale: 100
  brightness_scale_min: 50
  on_command_type: "brightness"
  brightness_value_template: "{{value_json.Dimmer}}"
  payload_on: "ON"
  payload_off: "OFF"
  qos: 1
  retain: false

Checklist:

[x] The code change is tested and works locally.
[x] Local tests pass with tox. Your PR cannot be merged unless tests pass
[X] There is no commented out code in this PR.
[X] I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

[X] Documentation added/updated in home-assistant.io

If the code communicates with devices, web services, or third-party tools:

[ ] The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
[ ] New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
[ ] Untested files have been added to .coveragerc.

If the code does not interact with devices:

[ ] Tests have been added to verify that the new code works.

Hi @BCNelson,
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!

@BCNelson Can you explain why this is needed please?

@emontnemery It allows for the uses of lights that have a lower bound on how dimmed they can be. In my situation the lights i'm using turn off if I go much below 50% so iit does not make much sence to only use half ui slider. and this was my fix. If you have an other suggestion i would be happy to hear it.

We shouldn't add features to Home Assistant to fix one-off problems for users.

I don't think that this is a one off problem it seem logical that if your going to have a upper scale factor you have a lower limit to the ranges as well.

@BCNelson OK, I understand your use case, but adding yet another option to MQTT light is not the way to address it. Maybe this can be solved with a tasmota rule?

@emontnemery Thank you for taking the time to understand my problem. However, I didn't make this pull request only because of my problem but because I feel that the brightness_scale feature is incomplete. Surely it makes sense if we have a way to set the upper limit of a range we have a way to set the lower limit as well.
As to using rules to solve the problem it can be done and is working well o the switch however home assistants UI is wrong when it shows the light as there is know way to have tasmota report a value from 0 - 100 when internally it is only ever set to values between 50 - 100.

@BCNelson You can use the brightness_value_template setting to multiply reported brightness by 2 if that's what you mean.

@emontnemery that is a perfect solution to my specific problem.
I still feel that this future is relevant but will close the pull request if you feel that is best.

@BCNelson Adding a brightness_command_template just like color_temp_command_template could be OK if you're willing to refactor the PR.

What's the plan? Should we close here?

We can close this one if I make a brightness template i will make a new pull request.


Build "current_page_parent" and "current-post-ancestor" check into the navwalker

Based on the issue that @craftwerkberlin opened in the navwalker, https://github.com/AlexWebLab/bootstrap-5-wordpress-navbar-walker/issues/7.

@justinkruit Thank you!


Add link to Bugzilla report

Hope it saves someone the enormous effort of Googling it themselves ;)

Ha, thanks!


NIFI-543 Added annotation to indicate processor should run only on Primary Node

Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:

[x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?

[x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

[x] Has your PR been rebased against the latest commit within the target branch (typically master)?

[ ] Is your initial contribution a single, squashed commit?

For code changes:

[x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
[x] Have you written or updated unit tests to verify your changes?
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
[ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
[ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

[x] Have you ensured that format looks appropriate for the output in which it is rendered?

Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

This demands a similar change in VersionedProcessor in NiFi Registry. I'm going to do that.. question is whether that has to be done after the review and merge or I'll go ahead and do it and add a reference to this PR.

@markap14 Appreciate if you could take a look :)

@zenfenan one other note - I did notice a checkstyle violation (unused import) in StandardProcessorNode.

@markap14 Applied the changes and also rebased against the latest master.

@zenfenan I think there's also one other detail that I missed. The intent here, I believe, is not just to default to Primary Node execution mode when the @PrimaryNodeOnly annotation is present, but to actually enforce that the processor always use Primary Node execution mode if it has the annotation. Is that correct? If so, then I think we need to update the setExecutionMode() method to  ignore the provided value and use ExecutionMode.PRIMARY_NODE if the annotation is present. Otherwise, there is no enforcement guaranteed.

@mcgilman I understand the points you have made. They are valid. In particular, I like the last one which is how this might have benefit in building a flow in a standalone node with appropriate nodes and then save it to the registry.
I just have three questions:

All Nodes option should be disabled if the component is marked as PrimaryNodeOnly. That should be the case in both standalone as well as cluster scenario. Correct?
Processors which were previously added to the canvas i.e. those who were not executionNodeRestricted and had executionNode as ALL but after this change, those processors will have the All Nodes option disabled and the user will only have the ability to switch to Primary Node, post which the user will never be able to select All Nodes again. Technically that's correct since the processor is supposed to be run only on the primary node. You feel that is okay? Do you see any inconsistency in UX?
One more thing is, in general, I used to feel that Execution Nodes doesn't make sense in a standalone context so showing the dropdown still has got me thinking whether we should display it or not. But your point on showing the dropdown for all the components and in all cases (standalone or cluster) seems to make it consistent and also the understanding on how this will be well suited in actual enterprise scenarios where most enterprise customers probably use standalone node to get the flow/template ready and save it to registry and will actually import it to a cluster. The question, here, again is with respect to the UX. With this change, we will be showing the dropdown all the time for all the processors in standalone case. Do you see any issues/inconsistency with the way the user would perceive this new change?

@markap14 I thought about it actually but since setExecutionNode gets called from FlowController/StandardProcessorGroup but regardless of from where it gets called they all pass the value from the ProcessorConfigDTO to setExecutionNode and since this change takes care of setting the value of executionNode to PRIMARY in the DTO, I thought it will be okay. I'll still add it though to enforce it. But just out of curiosity I'm asking, do you see any specific scenarios which might make this non-guaranteed?

@mcgilman Ready to be merged?

@zenfenan I'm a +1 on the front end changes. I believe that @markap14 was reviewing the back end changes. Let's make sure he's good as well before it's merged. Thanks.

@zenfenan sorry for the delay and all the back-and-forth on this one, but I've merged to master now! Many thanks for the PR and sticking with it through the end. Definitely nice to have this improvement merged in.


Unknown source location shouldn't show code frame

agree though also this seems like this particular error should have a location


Add blog post on using wildcard domain with caddy and inlets

Signed-off-by: Han Verstraete (OpenFaaS Ltd<EMAIL_ADDRESS>
Description

Add blog post on using wildcard domain with caddy and inlets.
Motivation and Context

Show inlets users how to setup a wildcard domain to expose multiple local HTTP endpoints on any subdomain using a single inlets tunnel server.
How Has This Been Tested?

Verified instuctions.
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I've read the CONTRIBUTION guide
[x] I have signed-off my commits with git commit -s

Did you test the blog roll-up and image were valid?


feat(KONFLUX-2071): update source code to use pkg import from upstream

This is done to simply the codebase.

I've locally tested my current code with all 4 types of prow jobs (failed during creation, bootstrap, E2E failure, and E2E panic), and everything is working as expected.


Command Statements - Output Relative Path

The command statements displayed in the Output window contain absolute paths when they reference files from the connector project.
c:\Users\ben\.vscode\extensions\powerquery.vscode-powerquery-sdk-0.1.3\.nuget\Microsoft.PowerQuery.SdkTools.2.109.6\tools\pqtest.exe run-test
--extension c:\Users\ben\Desktop\TestConnector\BenTest\bin\AnyCPU\Debug\BenTest.mez
--queryFile c:\Users\ben\Desktop\TestConnector\BenTest\BenTest.query.pq
--prettyPrint

pqtest.exe works fine with relative paths (relative to the current working directory).
To make Output’s contents less verbose, one idea would be to render out paths in arguments relative to that working directory.
For example, the above would become:
c:\Users\ben\.vscode\extensions\powerquery.vscode-powerquery-sdk-0.1.3\.nuget\Microsoft.PowerQuery.SdkTools.2.109.6\tools\pqtest.exe run-test
--extension bin\AnyCPU\Debug\BenTest.mez
--queryFile BenTest.query.pq
--prettyPrint

Just an idea, for what it’s worth.

The Output window is meant for trace/debug purposes. We're tracking an improvement to add log levels to control verbosity, but at least during this initial preview period, I'd like as much detail as possible in the traces.
When we trace command execution, the parameters and format should be an exact match to what we pass to the external process. Showing the quotes (#96) makes sense if that is what we're passing to pqtest.exe, but rewriting or reformatting parameters is misleading and makes issues harder to reproduce.

@mattmasson

When we trace command execution, the parameters and format should be an exact match to what we pass to the external process. Showing the quotes (https://github.com/microsoft/vscode-powerquery-sdk/issues/96) makes sense if that is what we're passing to pqtest.exe, but rewriting or reformatting parameters is misleading and makes issues harder to reproduce.

Very much agree with things matching. Thinking that this change could possibly be made in the backend and so then would be automatically reflected on the front end.


removal of useless assigning of variable to itself, default value of …

…provider is now aws

/lgtm


hotfix: don't break with auth

Closes #124
Though, it'd be right to fix the actual issue (of django trying handle any auth at all).

Thanks for the fix


Response Signature contains

Hello, I have a third party attempting to setup SSO with my organization. We are using your library... and it seems that the SAML response signature contains carriage returns and/or new lines. It doesn't seem like the validate_signature method takes this into consideration when attempting to handle the comparison.
Is this something that would be useful to add to the implementation... Or does it not behave this way on purpose. Thanks!

Hey, Just checking in on this. I did some more testing and seems that the when validating the signature it doesn't event take new lines into consideration... and this seems to go against the SAML 2.0 spec.

FYI... I have a PR I can push up that provides specs to show the issue I am discussing.

@danielwheeler1987 Please provide the PR and I will review.

FYI, we found that this problem went away when we upgraded our ruby-saml gem. We were on v 1.7 and when we went to v 1.11, the problem went away. @kingjason


Bumping more test timeouts

Looks like some of the previous increased test timeouts didn't apply and I was just lucky that they didn't go over. I've moved their specification out of the before() handler and into the describe() handler.
Also increasing some other timeouts that failed, although that may have been a knock-on effect.

The changes look good.

:clap:

:+1:


[BugFix] The db_admin role miss some privilege type in new RBAC

What type of PR is this：

[x] BugFix
[ ] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Which issues of this PR fixes ：

Fixes #
Problem Summary(Required) ：

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr will affect users' behaviors
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[ ] I have checked the version labels which the pr will be auto backported to target branch

[ ] 2.5
[ ] 2.4
[ ] 2.3
[ ] 2.2

[FE PR Coverage Check]
:heart_eyes: pass : 39 / 39 (100.00%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/privilege/PrivilegeManager.java
39
39
100.00%
[]

[FE PR Coverage Check]
:heart_eyes: pass : 39 / 39 (100.00%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/privilege/PrivilegeManager.java
39
39
100.00%
[]

run DCO

run starrocks_admit_test

run starrocks_fe_unittest

run starrocks_admit_test


test: set up test suite with Jest and MSW

Problem
Tests are good but we don't have them. Also, as we develop new SDKs, it will be useful to have consistent test cases as a reference point for implementation.
Solution
I considered two possible approaches:

Mock openid-client and check that we are interacting with it correctly
Mock network requests and ensure that the SDK returns the correct outputs

I went with approach 2 because 1 doesn't test for the possibility that openid-client introduces a bug or change in behaviour.
I chose msw to mock network requests instead of digging into the internals of openid-client and mocking whatever HTTP library they use (the native NodeJS HTTP API), as this allows us to stay agnostic to openid-client's internal implementation and just mock API responses.
Also, tests are now part of CI pipeline. See "Test" GitHub action.
Build changes
To include the test directory in the TS project but exclude it from the build pipeline, I set tsconfig.json to include tests, but created a new tsconfig.build.json which excludes tests and used it in npm run build.
New dev dependencies:

jest, ts-jest, msw: for test framework in TypeScript
jsonwebtoken: for generating testing data (sign ID token)
eslint-plugin-jest: to write test nice nice

@PrawiraGenestonlia thanks for the thoughtful review! left some of the comments open for discussion


Move dochelpers.py out of ARMI and into the /doc/ directory

This tooling really shouldn't be importable within ARMI.  It isn't part of nuclear engineering.
We talked about it as a group, and we are going to move this into the /doc/ directory.

Closed with: https://github.com/terrapower/armi/pull/1662


updated the redirected URL to direct URL

Updated the redirected URL to updated URL for Windows Analytics blog.
Problem: https://github.com/MicrosoftDocs/windows-itpro-docs/issues/1850

@nenonix and @JohanFreelancer9 for copy edit please. Thank you.

Hi @greg-lindsay PR has been copy edited and is ready for your final review. Please see file changed. Thank you very much.

Hi @greg-lindsay and AndreaBarr , kinldy review the PR if time permits. It is a link update and PR has already been copy edited. Thank you so much.

Hi @greg-lindsay and @AndreaBarr, hope all is well. Please review this PR if you have time. Thank you.


Exactness does not match correctly in presence of hard separators

Describe the bug
When a query contains a hard separator like Batman: the dark knight returns, part 1, then documents with the title Batman: the dark knight returns, part 1 are not matched with the strategy MatchesFull, while they should.
This is due to multiple factors

hard separators are not given a correct position when parsing queries
the field_id_word_count_docids stores only the word count up to 10.
the field_id_word_count_docids stores the max position instead of the number of words. This max position takes into account the offset of hard separators and so we easily get higher than 10.

To Reproduce
Steps to reproduce the behavior:

Use meilisearch from https://github.com/meilisearch/meilisearch/pull/3821
Index movies
Query Batman: the dark knight returns, part 1 with ranking score details enabled
Notice that the match is matchesStart or noExactMatch instead of fullMatch

Expected behavior
Exactness matches fullMatch in this case
Meilisearch version:
main

Hello @dureuill
Thanks for the report
Is this bug present in v1.2? My question behind: should we add it to the v1.3 changelogs as a bug fix?
Also, I recommend avoiding writing main as Meilisearch version -> when we read the issue in the future, main does not have the same meaning as now.
The best is a version, or at least a commit sha (and precise if we are between v1.2 and v1.3 sprint)


Issues with page objects

OS name and version - Win 10 (x64)
Python version - Python 3.6.3 (v3.6.3:2c5fed8, Oct  3 2017, 17:26:49) [MSC v.1900 32 bit (Intel)] on win32
Golem version - I don't know where I can check it (latest installed with pip)

I faced with the following problem:
For unknown for me reasons golem doesn't save elements in page objects (without showing any tips or message) or doesn't show objects if I fill it in  mode.
Sometimes it erased objects if saved it before.
More details please see on attached videos:
http://recordit.co/by6VOYYFXk
http://recordit.co/yzWWx4bUxC

I am unable to recreate this problem on both windows and mac using the pip version of golem (using chrome on both machines).
In case you used an older version of golem it is recommended to clear the browser cache (learned this from @lucianopuccio)

Hi there.
After some period I've returned to discovering of  Golem and again faced with the same issue.
Now I investigate behavior little bit deeper  (F12 in browser) and  can definitely say that it is not cache . Stacktrace  for my case almost the same like for the issue https://github.com/lucianopuccio/golem/issues/85 with title builtins.TypeError
TypeError: 'NoneType' object is not subscriptable

My assumption that it can be somehow connected with Python version (v.3.6)

I've check my assumption, after re-installation (downshifting) of python 3.6.3 ->3.4.4 Golem works as expected (for now)

Closing. Reopen if this is still happening. Thanks.


GGIR version 1.5-7 bug

Dear Vincent,
Per your instruction on forum at https://groups.google.com/forum/#!topic/RpackageGGIR/kjJMePHDU_Q,
I am submitting an issue here.
The bug of src/numUnpack.cpp is NOT fixed in g.inspectfile(), g.getmeta(), g.calibrate() and a number of other places using the above functions.
Your attention is greatly appreciated.

library(GGIR)
I = g.inspectfile(datafile)
Error in Rcpp::sourceCpp("src/numUnpack.cpp") :
file not found: 'src/numUnpack.cpp'
In addition: Warning messages:
1: In normalizePath(dirname(file)) :
path[1]="src": No such file or directory
2: In normalizePath(file, winslash = "/") :
path[1]="src/numUnpack.cpp": No such file or directory
I = g.getmeta(datafile)
Error in Rcpp::sourceCpp("src/numUnpack.cpp") :
file not found: 'src/numUnpack.cpp'
I = g.calibrate(datafile)
Error in Rcpp::sourceCpp("src/numUnpack.cpp") :
file not found: 'src/numUnpack.cpp'

thanks Jian, I am aware of this and it will be fixed in the next release, which I aim to upload later this week

Now in release 1.5-8 here on github https://github.com/wadpac/GGIR/releases/tag/1.5-8
I will upload this to CRAN later this week

Thanks so much Vincent for getting a new release so quickly.
It looks great so far!

Vincent,
I just started to read in a 2 week .cwa file using the new version.  From the g.inspectfile, blocks=991997, that is the number of blocks I have?
It is about 10 min running
g.shell.GGIR(mode=c(1,2),datadir=datadir,outputdir=outputdir,studyname=studyname, f0=1,f1=1,
do.report=c(2),overwrite=FALSE,visualreport=TRUE,viewingwindow=1)
Does the output look right so far for you?  With these speed, it is going to take 10 million min to load all the blocks?

I = g.inspectfile(datafile)
I
$header
value
uniqueSerialCode      31999
frequency               100
start<PHONE_NUMBER>
device              Axivity
firmwareVersion          44
blocks               991997

$monc
[1] 4
$monn
[1] "axivity"
$dformc
[1] 4
$dformn
[1] "cwa"
$sf
[1] 100
$filename
[1] "31999_0000000204.cwa"

g.shell.GGIR(mode=c(1,2),datadir=datadir,outputdir=outputdir,studyname=studyname, f0=1,f1=1,

          do.report=c(2),overwrite=FALSE,visualreport=TRUE,viewingwindow=1)

g.shell.GGIR {GGIR} by Vincent van Hees

Part 1
[1] "P1 file1"
[1] "---------------------------------------------"
[1] "investigate calibration of the sensors..."
[1] "Loading block: 1"
[1] "Loading block: 2"
[1] "Loading block: 3"
[1] "Loading block: 4"
[1] "Loading block: 5"
End of file reached
stop reading because there is not enough data in this block
[1] "get meta data..."
warning: g.cwaread in beta version
Loading block: 1
Loading block: 2
Loading block: 3
Loading block: 4
Loading block: 5
Loading block: 6
Loading block: 7
Loading block: 8

Looks good so far. The 991997 blocks are not the same 'blocks' as printed in the console. It is a bit ugly and confusing i have to admit, but g.cwaread defines a block in the data as a segment of 300 samples (3 seconds at 100Hz), while the block numbers other parts of GGIR are printing in your console are the blocks of data loaded, with about 12 hours of measurement per block for the autocalibration part and 24 hours per block in the get meta data part. So, this should not take much more than 15 minutes or so, depending of course on sample frequency and measurement duration.

maybe I should rename the latter 'blocks' to 'chunks', because there is a function argument in GGIR called chunksize which relates to these larger blocks. In that way I can reserve the terms pages and blocks for everything that happens at the level of reading in the data from the cwa or bin files, and reserve the term chunks for the process of putting large 'chunks' of data in memory to process them. Related terms like window,  segment, period, epoch, and bout are already used elsewhere in the code. I will create a seperate issue for it now.

That makes a lot of sense.  Great!
I think there is another issue here.  As you can see, the ouputdir is not picked up in part2.  It also doesn't recognize metadatadir as input parameter.  The files from part1 is indeed stored in the outputdir as specified but part2 has its own idea where the meta data it reads from ;-)).
g.shell.GGIR(mode=c(1,2),

         datadir="/lillyce/qa/digitalbiomarker/d1pam2/output/ax3TestDataCwa2",

         outputdir="/lillyce/qa/digitalbiomarker/d1pam2/output/ax3TestAnalysis",

         studyname=studyname, f0=1,f1=1,

        do.report=c(2),overwrite=FALSE,visualreport=TRUE,viewingwindow=1)

g.shell.GGIR {GGIR} by Vincent van Hees

Part 1

Part 2
1
Error in readChar(con, 5L, useBytes = TRUE) : cannot open the connection
In addition: Warning message:
In readChar(con, 5L, useBytes = TRUE) :
cannot open compressed file '/lillyce/qa/digitalbiomarker/d1pam2/output_ax3TestDataCwa2/meta/basic/NA', probable reason 'No such file or directory'

My guess for now is that the code struggles with the folder name 'output' because GGIR creases a folder names 'output' and later on searches for it... I would have to investigate this as it would be nice if you could use any folder name you like.
As a quick fix, can you rename the argument for outputdir to:
outputdir = "/lillyce/qa/digitalbiomarker/d1pam2"
Next, your part2 output should be stored as subfolder inside:
'/lillyce/qa/digitalbiomarker/d1pam2/output_ax3TestDataCwa2'

This strategy works perfectly!  Thanks much.

Could you please do me a favor to remove the folder names in the comment above ("My guess ...) ?  I shouldn't have put our folder structure there.  Thanks much.

Ok, I updated the folder names. Did you delete your own comment? It is not going to be very helpful for others to understand this conversation if you remove your own comments

Vincent, I am so sorry.
Here is the summary of what I reported:
The phase "output" is contained in my outputdir path, leading to confusion of go.part1.  As a result, contents which are supposed to be stored within a folder under outputdir ends up in a same named folder under datadir.  The program then complains the folder it needs not there.
The workaround is to avoid using "output" in the outputdir path.
Thanks much Vincent.


[DO NOT MERGE] Auto PR to update dependencies of istio

This PR will be merged automatically once checks are successful.

@sebastienvas this pr needed a rerun to updateVersion

/test e2e-suite-rbac-auth.sh


Multiple Transitions + Minor Updates

This PR includes the following changes:

Supporting multiple transitions for action nodes
Updating the Node Type drop down
Updating the transition UI and implementing go to node (right arrow)
Update the add node buttons (connect node not implemented)
Fix switch node type to remove transitions

Supporting multiple transitions for action nodes:

Updating the Node Type drop down:

Updated UI components:

As well as general comments I would like to discuss:

nodeTypeOptions is a list included in all 3 sidebar editors. It should probably be shared somewhere but I'm looking for feedback on where to put it.
The "Transitions" header is included in all 3 sidebar editors because the position matters for BranchNodeEditor. I could move the header to Sidebar but then the rendering of BranchNodeTransitions would need to move from the BranchNodeEditor into Sidebar and I don't really like that idea either.
I'm not sure if it just caching but sometimes the sidebar doesn't scroll. To test add a few transitions to an Observation and let me know if it scrolls correctly for you. You may need to "Empty cache and hard reload".

There does seem to be some weirdness with scrolling. What I'm seeing is 2 "scrollable sections" -- the whole page, and the graph. So the sidebar does scroll but the graph container is included and scrolls up with it, which is not ideal. I'm seeing that on master as well so we can make that a separate task.

@dehall added to PATHWAYS-287

Great job Ben! I think one thing to note with the "go to node" feature is that the only way to navigate backwards is to click on the parent node. It doesn't seem like the leftward pointing arrow on a zoomed in node is operational. Is this enough work that is warrants its own task?

Maybe nodeTypeOptions can be kept in sidebar.tsx and passed as a prop?

I think one thing to note with the "go to node" feature is that the only way to navigate backwards is to click on the parent node. It doesn't seem like the leftward pointing arrow on a zoomed in node is operational. Is this enough work that is warrants its own task?
I didn't try to implement this. The skeleton function still exists. It looks like there is a backlog item for it already.

Maybe nodeTypeOptions can be kept in sidebar.tsx and passed as a prop?
That's a possibility. But since it never changes I would prefer to not pass it as a prop. Maybe keeping it in nodeUtils and then importing in each file? I was working in the nodeUtils file today for another task and there is another static map already there.

That's a possibility. But since it never changes I would prefer to not pass it as a prop. Maybe keeping it in nodeUtils and then importing in each file? I was working in the nodeUtils file today for another task and there is another static map already there.
That sounds like a good decision for now, and then maybe clean up the nodeUtils file and consider consolidating into contexts later on?


Installing GitHub module should install dependent modules

https://github.com/MicrosoftDocs/PowerShell-Docs/issues/4383

Fixed. Was using the module manifest file incorrectly. Now the GitHub module will become a manifes module, loading dependant modules i.e. GitHub.Core, GitHub.Repos ...


[#3196] ActiveTrace optimization

empty case optimization

Codecov Report

Merging #3198 into master will decrease coverage by <.01%.
The diff coverage is 77.77%.

@@            Coverage Diff             @@
##           master    #3198      +/-   ##
==========================================
- Coverage   39.05%   39.05%   -0.01%
==========================================
  Files        2040     2040
  Lines       67102    67098       -4
  Branches     9324     9324
==========================================
- Hits        26207    26202       -5
- Misses      38302    38303       +1
  Partials     2593     2593

Impacted Files
Coverage Δ

...er/context/active/ActiveTraceHistogramFactory.java
100% <100%> (+13.33%)
:arrow_up:

...er/context/active/DefaultActiveTraceHistogram.java
91.66% <100%> (-1.44%)
:arrow_down:

...iler/context/active/EmptyActiveTraceHistogram.java
77.77% <50%> (-22.23%)
:arrow_down:

.../profiler/sender/StandbySpanStreamDataStorage.java
72.88% <0%> (-3.39%)
:arrow_down:

...m/navercorp/pinpoint/test/OrderedSpanRecorder.java
72.11% <0%> (-1.93%)
:arrow_down:

...pinpoint/profiler/instrument/AccessorAnalyzer.java
65.71% <0%> (+8.57%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2077e47...2733539. Read the comment docs.


Use cluster.k8s.io types, add machineSet controller

What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:

@mrIncompetent Removed the superfluous variable, PTAL


Set OwnerReference for NRT objects

Should we follow the example of the DRA example driver and set OwnerReferences backlinking to nodes to the NRT objects?

I gonna take this, if that is ok.
Is the target to add the Node as Owner of the NRT to trigger deletion if a node is deleted from the cluster or the discussion about if doing so its ok?

go for it! the main benefit of this change is to avoid leftovers in the cluster: if a node object gets deleted, the corresponding NRT should be deleted as well (no stale objects).
Truth to be told, I expect this flow to trigger extremely rarely, but still why not?

/close
as #212  is merged


Mascot name

Please leave a comment with your name suggestion for our mascot and also give 👍 / 👎 for other suggestions

Lilbit the Dragonfox

Foxbyte

Poppifox

Simple names probably work the best, while I love the many names we have seen over the last month something simple like Byte should suffice? I am sure other people have done similar, but its short and simple and its just a mascot :)


added adr for DB upgrade (#5362)

Pull request opened by the merge tool on behalf of #5362

Merged in ad69cfcdb70c56922cb92ca5414bd402473d9c5c


NullPointerException: getClass.getResource("").getPath trick no longer works on sbt 1.3.6?

steps
I sent a PR https://github.com/sbt/sbt/pull/5340 (was https://github.com/sbt/sbt/pull/5338) to bump to sbt 1.3.6.
problem
https://travis-ci.org/sbt/sbt/jobs/629909488?utm_medium=notification&utm_source=github_status or https://travis-ci.org/sbt/sbt/jobs/629892674?utm_medium=notification&utm_source=github_status
The tests failed
[error] Error: Total 136, Failed 0, Errors 6, Passed 130
[error] Error during tests:
[error] 	sbt.internal.parser.SessionSettingsSpec
[error] 	sbt.internal.parser.ErrorSpec
[error] 	sbt.internal.parser.NewFormatSpec
[error] 	sbt.internal.parser.SessionSettingsQuickSpec

The actual error seems to be java.lang.NullPointerException during logging?
Reading files from: file:/home/travis/.cache/coursier/v1/https/repo1.maven.org/maven2/org/apache/logging/log4j/log4j-api/2.11.2/log4j-api-2.11.2.jar!/META-INF/versions/9/session-settings
[info] SessionSettingsSpec
[info] SessionSettings  should
[error]   ! Be identical for empty map
[error]    java.lang.NullPointerException: null (file:1)
[error]   ! Replace statements
[errorm]    java.lang.NullPointerException: null (file:1)
[info] Total for specification SessionSettingsSpec

expectation
No errors.
notes
Running mainProj/test locally worked.

https://github.com/sbt/sbt/blob/19cf7a4da069e13bfd2db20688b7dd4becca7440/main/src/test/scala/sbt/internal/parser/SessionSettingsSpec.scala#L21-L23
I suspect getClass.getClassLoader.getResource("").getPath to be causing problem with sbt 1.3.6 on Travis CI. I wonder if this is trying to figure out the test directory that works for both forked and non-forked case.

So sbt 1.3.6 returns /home/travis/.cache/coursier/v1/https/repo1.maven.org/maven2/org/apache/logging/log4j/log4j-api/2.11.2/log4j-api-2.11.2.jar!/META-INF/versions/9/ for getClass.getClassLoader.getResource("").getPath?


indent-blankline "failed to run config" after update lazyvim

Problem
Hello everyone, thanks for making this awesome plugin! I updated lazyvim this morning and got indent-blankline failed to run config
I also asked in the lazyvim community and kind of found the answer.
here are some stack trace from indent-blankline.nvim if it could help debug :)
discussion in lazy community
Good luck on fixing bug!
Steps to reproduce
run sync in lazyvim and then open a file in any language
Expected behavior
see the invisibles,indent, a line surrounding functions, etc
Neovim version (nvim -v)
NVIM v0.9.5 Build type: Release LuaJIT 2.1.1703358377

Duplicate of #869

You can use previous version of plugin. Create indent-blankline.lua file in your config and write the following text:
return {
"lukas-reineke/indent-blankline.nvim",
main = "ibl",
commit = "29be0919b91fb59eca9e90690d76014233392bef",
}

duplicate of  #869


Fix sphinx docs TF issue

This requirement lets sphinx build our docs correctly

Merging this in because tests pass and it is a tiny change.


Audio output not working?

It doesn't look like commands that can produce audio feedback (e.g. ping -a <some-ip-address>) aren't actually producing sound.  Is that the intended behavior?

Platypus does not actually create a terminal session. The scripts are executed either using NSTask or Apple's Security Framework's AuthorizationExecuteWithPrivileges(). Features that require a terminal session, such as prompting for STDIN or beeping will not work.


do not show generating hint in the command preview

What type of PR is this?

/kind bug
Special notes for your reviewer:
Does this PR introduce a user-facing change?

Additional documentation e.g., design docs, usage docs, etc.:

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

11 of 11 (100.0%)  changed or added relevant lines in 1 file are covered.
7 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.06%) to 72.599%

Files with Coverage Reduction
New Missed Lines
%

pkg/cmd/apply/options.go
7
71.43%

Totals

Change from base Build<PHONE_NUMBER>:
-0.06%

Covered Lines:
5034

Relevant Lines:
6934

💛  - Coveralls


Operation request: Play audio

Summary
This would be similar to the 'Render image' operation, but for audio files. It may be possible to make use of an HTMLAudioElement fed by a Blob.

Closed in #446.


repology version is wrong

howdy!
in these logs the version grabbed (0.16.3_6) isn't the same one on github.
Is there a way to nudge nixpkgs-update to use github releases directly?

You can add an update script, as documented here. Repology versions and other heuristics are only used if there is no explicit update script.


[CLOSED] Generate metadata/"interface" files

 Issue by antalsz
Wednesday Oct 11, 2017 at 17:51 GMT
Originally opened as https://github.com/antalsz/hs-to-coq/issues/23

In order to support things such as correctly knowing data type constructors or default modules outside of base, or correctly extending skip method to modules that import a type class, we need to generate metadata files.  Current plan:

When translating Mod/File.hs, to $OUTPUT/Mod/File.v, also generate $METADATA/Mod/File.h2c, where $METADATA = $OUTPUT by default.

Pass in search directories when converting a file.  For example, if working with base, you'd specify -M  path/to/base/output (flag name subject to change).

When translating a file that does import M, hs-to-coq would go and load M.h2c.  That would specify (a) what other h2c files to import; (b) metadata, e.g. constructor names; and (c) "persistent" edits, such as skip method or (I think) skip module.  If it had already been loaded or generated, this would be brought in from memory, instead of from disk.

Re. 3, however, one question is: would these changes have to be specific to the module that imported them, or could they be globally loaded?  Information about the constructors of Full.Mod.Type is always applicable because it's fully qualified.  In that case, we could eagerly load all the .h2c files, or possibly even only generate one per library rather than one per module.

 Comment by nomeata
Thursday Oct 12, 2017 at 19:29 GMT

My guts say: They should be applied globally, and they should be loaded eagerly (with lazy loading a possible optimization).