Failed to run bundle: install plan is not available for the subscription

Bug Report
What did you do?

installed OLM with operator-sdk olm install
tried to install an operator with operator-sdk run bundle

What did you expect to see?
The operator should start to run.
What did you see instead? Under which circumstances?
operator-sdk run bundle --namespace default --timeout 5m <IP_ADDRESS>:5001/pmem-csi-bundle:v100.0.0 --skip-tls
time="2021-11-17T14:21:35+01:00" level=info msg="Successfully created registry pod: 172-17-42-1-5001-pmem-csi-bundle-v100-0-0"
time="2021-11-17T14:21:35+01:00" level=info msg="Created CatalogSource: pmem-csi-operator-catalog"
time="2021-11-17T14:21:35+01:00" level=info msg="OperatorGroup \"operator-sdk-og\" created"
time="2021-11-17T14:21:35+01:00" level=info msg="Created Subscription: pmem-csi-operator-v100-0-0-sub"
time="2021-11-17T14:26:27+01:00" level=fatal msg="Failed to run bundle: install plan is not available for the subscription pmem-csi-operator-v100-0-0-sub: timed out waiting for the condition\n"

This only happens with OLM 1.19.1. The same commands work when installing OLM 0.18.3 with operator-sdk olm install --version=v0.18.3.
 This pod here might be responsible for it (not sure) and reports an error:
$ kubectl logs -n olm pods/catalog-operator-84976fd7df-x5tmr
...
E1117 13:21:35.798270       1 queueinformer_operator.go:290] sync {"update" "default/pmem-csi-operator-v100-0-0-sub"} failed: Operation cannot be fulfilled on subscriptions.operators.coreos.com "pmem-csi-operator-v100-0-0-sub": the object has been modified; please apply your changes to the latest version and try again
time="2021-11-17T13:21:35Z" level=info msg=syncing event=update reconciling="*v1alpha1.Subscription" selflink=
time="2021-11-17T13:21:35Z" level=info msg=syncing event=update reconciling="*v1alpha1.Subscription" selflink=
time="2021-11-17T13:21:36Z" level=warning msg="an error was encountered during reconciliation" error="Operation cannot be fulfilled on subscriptions.operators.coreos.com \"pmem-csi-operator-v100-0-0-sub\": the object has been modified; please apply your changes to the latest version and try again" event=update reconciling="*v1alpha1.Subscription" selflink=
...

This repeats a few times but then not anymore. Deleting that pod doesn't help, the recreated one has the same problem.

For comparison, here's the subscription when using OLM 0.18.1:

```
Spec:
  Channel:                alpha
  Install Plan Approval:  Manual
  Name:                   pmem-csi-operator
  Source:                 pmem-csi-operator-catalog
  Source Namespace:       pmem-csi
  Starting CSV:           pmem-csi-operator.v1.1.0
Status:
  Catalog Health:
    Catalog Source Ref:
      API Version:       operators.coreos.com/v1alpha1
      Kind:              CatalogSource
      Name:              operatorhubio-catalog
      Namespace:         olm
      Resource Version:  6982
      UID:               690eea06-7304-4e48-ac8e-106af540a9e5
    Healthy:             true
    Last Updated:        2021-11-19T13:08:56Z
    Catalog Source Ref:
      API Version:       operators.coreos.com/v1alpha1
      Kind:              CatalogSource
      Name:              pmem-csi-operator-catalog
      Namespace:         pmem-csi
      Resource Version:  7093
      UID:               8107f14f-accd-48eb-842f-e905a4865ba6
    Healthy:             true
    Last Updated:        2021-11-19T13:08:56Z
  Conditions:
    Last Transition Time:   2021-11-19T13:08:56Z
    Message:                all available catalogsources are healthy
    Reason:                 AllCatalogSourcesHealthy
    Status:                 False
    Type:                   CatalogSourcesUnhealthy
    Last Transition Time:   2021-11-19T13:08:55Z
    Reason:                 RequiresApproval
    Status:                 True
    Type:                   InstallPlanPending
  Current CSV:              pmem-csi-operator.v1.1.0
  Install Plan Generation:  1
  Install Plan Ref:
    API Version:       operators.coreos.com/v1alpha1
    Kind:              InstallPlan
    Name:              install-br4hc
    Namespace:         pmem-csi
    Resource Version:  7078
    UID:               4e1fa4fe-6819-43fb-89c4-3a447f5b6867
  Installed CSV:       pmem-csi-operator.v1.1.0
  Installplan:
    API Version:  operators.coreos.com/v1alpha1
    Kind:         InstallPlan
    Name:         install-br4hc
    Uuid:         4e1fa4fe-6819-43fb-89c4-3a447f5b6867
  Last Updated:   2021-11-19T13:08:59Z
  State:          AtLatestKnown
```

And the log:

```
time="2021-11-19T13:08:52Z" level=warning msg="an error was encountered during reconciliation" error="Operation cannot be fulfilled on subscriptions.operators.coreos.com \"pmem-csi-operator-v1-1-0-sub\": the object has been modified; please apply your changes to the latest version and try again" event=update reconciling="*v1alpha1.Subscription" selflink=
E1119 13:08:52.045924       1 queueinformer_operator.go:290] sync {"update" "pmem-csi/pmem-csi-operator-v1-1-0-sub"} failed: Operation cannot be fulfilled on subscriptions.operators.coreos.com "pmem-csi-operator-v1-1-0-sub": the object has been modified; please apply your changes to the latest version and try again
time="2021-11-19T13:08:52Z" level=info msg=syncing event=update reconciling="*v1alpha1.Subscription" selflink=
time="2021-11-19T13:08:52Z" level=info msg=syncing id=5NYPJ ip=install-kmp2g namespace=pmem-csi phase=RequiresApproval
time="2021-11-19T13:08:52Z" level=info msg=syncing id=bTVM3 ip=install-kmp2g namespace=pmem-csi phase=RequiresApproval
time="2021-11-19T13:08:52Z" level=warning msg="status not equal, updating..." id=bTVM3 ip=install-kmp2g namespace=pmem-csi phase=RequiresApproval
time="2021-11-19T13:08:52Z" level=info msg=syncing event=update reconciling="*v1alpha1.Subscription" selflink=
time="2021-11-19T13:08:53Z" level=warning msg="an error was encountered during reconciliation" error="Operation cannot be fulfilled on subscriptions.operators.coreos.com \"pmem-csi-operator-v1-1-0-sub\": the object has been modified; please apply your changes to the latest version and try again" event=update reconciling="*v1alpha1.Subscription" selflink=
E1119 13:08:53.045650       1 queueinformer_operator.go:290] sync {"update" "pmem-csi/pmem-csi-operator-v1-1-0-sub"} failed: Operation cannot be fulfilled on subscriptions.operators.coreos.com "pmem-csi-operator-v1-1-0-sub": the object has been modified; please apply your changes to the latest version and try again
time="2021-11-19T13:08:53Z" level=info msg=syncing event=update reconciling="*v1alpha1.Subscription" selflink=
time="2021-11-19T13:08:53Z" level=info msg=syncing id=8yt8e ip=install-kmp2g namespace=pmem-csi phase=RequiresApproval
time="2021-11-19T13:08:54Z" level=warning msg="an error was encountered during reconciliation" error="Operation cannot be fulfilled on subscriptions.operators.coreos.com \"pmem-csi-operator-v1-1-0-sub\": the object has been modified; please apply your changes to the latest version and try again" event=update reconciling="*v1alpha1.Subscription" selflink=
E1119 13:08:54.044598       1 queueinformer_operator.go:290] sync {"update" "pmem-csi/pmem-csi-operator-v1-1-0-sub"} failed: Operation cannot be fulfilled on subscriptions.operators.coreos.com "pmem-csi-operator-v1-1-0-sub": the object has been modified; please apply your changes to the latest version and try again
time="2021-11-19T13:08:54Z" level=info msg=syncing event=update reconciling="*v1alpha1.Subscription" selflink=
time="2021-11-19T13:08:54Z" level=info msg=syncing event=update reconciling="*v1alpha1.Subscription" selflink=
time="2021-11-19T13:08:54Z" level=warning msg="an error was encountered during reconciliation" error="Operation cannot be fulfilled on subscriptions.operators.coreos.com \"pmem-csi-operator-v1-1-0-sub\": the object has been modified; please apply your changes to the latest version and try again" event=update reconciling="*v1alpha1.Subscription" selflink=
E1119 13:08:54.840031       1 queueinformer_operator.go:290] sync {"update" "pmem-csi/pmem-csi-operator-v1-1-0-sub"} failed: Operation cannot be fulfilled on subscriptions.operators.coreos.com "pmem-csi-operator-v1-1-0-sub": the object has been modified; please apply your changes to the latest version and try again
time="2021-11-19T13:08:54Z" level=info msg=syncing event=update reconciling="*v1alpha1.Subscription" selflink=
time="2021-11-19T13:08:54Z" level=info msg=syncing event=update reconciling="*v1alpha1.Subscription" selflink=
time="2021-11-19T13:08:55Z" level=info msg=syncing id=GE/Dn ip=install-br4hc namespace=pmem-csi phase=RequiresApproval
time="2021-11-19T13:08:55Z" level=warning msg="status not equal, updating..." id=GE/Dn ip=install-br4hc namespace=pmem-csi phase=RequiresApproval
time="2021-11-19T13:08:55Z" level=info msg=syncing event=update reconciling="*v1alpha1.Subscription" selflink=
time="2021-11-19T13:08:55Z" level=info msg=syncing event=update reconciling="*v1alpha1.Subscription" selflink=
time="2021-11-19T13:08:55Z" level=info msg=syncing id=NP9XF ip=install-kmp2g namespace=pmem-csi phase=RequiresApproval
E1119 13:08:56.245183       1 queueinformer_operator.go:290] sync {"update" "pmem-csi/install-br4hc"} failed: failed to update installplan bundle lookups: Operation cannot be fulfilled on installplans.operators.coreos.com "install-br4hc": the object has been modified; please apply your changes to the latest version and try again
time="2021-11-19T13:08:56Z" level=info msg=syncing id=iVO7a ip=install-br4hc namespace=pmem-csi phase=RequiresApproval
time="2021-11-19T13:08:56Z" level=info msg="added to bundle, Kind=CustomResourceDefinition" configmap=pmem-csi/11d78c0562e2cd02702a57d274e90d36ba5d472d5d861a29575c9a530690e15 key=pmem-csi.intel.com_pmemcsideployments.yaml
time="2021-11-19T13:08:56Z" level=info msg="added to bundle, Kind=Service" configmap=pmem-csi/11d78c0562e2cd02702a57d274e90d36ba5d472d5d861a29575c9a530690e15 key=pmem-csi-operator-metrics_v1_service.yaml
time="2021-11-19T13:08:56Z" level=info msg="added to bundle, Kind=ClusterServiceVersion" configmap=pmem-csi/11d78c0562e2cd02702a57d274e90d36ba5d472d5d861a29575c9a530690e15 key=pmem-csi-operator.clusterserviceversion.yaml
time="2021-11-19T13:08:56Z" level=info msg="added to bundle, Kind=ServiceAccount" configmap=pmem-csi/11d78c0562e2cd02702a57d274e90d36ba5d472d5d861a29575c9a530690e15 key=pmem-csi-operator_v1_serviceaccount.yaml
time="2021-11-19T13:08:56Z" level=warning msg="status not equal, updating..." id=iVO7a ip=install-br4hc namespace=pmem-csi phase=RequiresApproval
time="2021-11-19T13:08:56Z" level=warning msg="an error was encountered during reconciliation" error="Operation cannot be fulfilled on subscriptions.operators.coreos.com \"pmem-csi-operator-v1-1-0-sub\": the object has been modified; please apply your changes to the latest version and try again" event=update reconciling="*v1alpha1.Subscription" selflink=
E1119 13:08:56.653801       1 queueinformer_operator.go:290] sync {"update" "pmem-csi/pmem-csi-operator-v1-1-0-sub"} failed: Operation cannot be fulfilled on subscriptions.operators.coreos.com "pmem-csi-operator-v1-1-0-sub": the object has been modified; please apply your changes to the latest version and try again
time="2021-11-19T13:08:56Z" level=info msg=syncing event=update reconciling="*v1alpha1.Subscription" selflink=
time="2021-11-19T13:08:57Z" level=info msg=syncing id=/PkrD ip=install-br4hc namespace=pmem-csi phase=RequiresApproval
time="2021-11-19T13:08:57Z" level=info msg="added to bundle, Kind=ServiceAccount" configmap=pmem-csi/11d78c0562e2cd02702a57d274e90d36ba5d472d5d861a29575c9a530690e15 key=pmem-csi-operator_v1_serviceaccount.yaml
time="2021-11-19T13:08:57Z" level=info msg="added to bundle, Kind=CustomResourceDefinition" configmap=pmem-csi/11d78c0562e2cd02702a57d274e90d36ba5d472d5d861a29575c9a530690e15 key=pmem-csi.intel.com_pmemcsideployments.yaml
time="2021-11-19T13:08:57Z" level=info msg="added to bundle, Kind=Service" configmap=pmem-csi/11d78c0562e2cd02702a57d274e90d36ba5d472d5d861a29575c9a530690e15 key=pmem-csi-operator-metrics_v1_service.yaml
time="2021-11-19T13:08:57Z" level=info msg="added to bundle, Kind=ClusterServiceVersion" configmap=pmem-csi/11d78c0562e2cd02702a57d274e90d36ba5d472d5d861a29575c9a530690e15 key=pmem-csi-operator.clusterserviceversion.yaml
time="2021-11-19T13:08:57Z" level=warning msg="status not equal, updating..." id=/PkrD ip=install-br4hc namespace=pmem-csi phase=RequiresApproval
time="2021-11-19T13:08:57Z" level=info msg=syncing event=update reconciling="*v1alpha1.Subscription" selflink=
time="2021-11-19T13:08:57Z" level=info msg=syncing id=kU63Z ip=install-kmp2g namespace=pmem-csi phase=RequiresApproval
time="2021-11-19T13:08:57Z" level=info msg="added to bundle, Kind=CustomResourceDefinition" configmap=pmem-csi/11d78c0562e2cd02702a57d274e90d36ba5d472d5d861a29575c9a530690e15 key=pmem-csi.intel.com_pmemcsideployments.yaml
time="2021-11-19T13:08:57Z" level=info msg="added to bundle, Kind=Service" configmap=pmem-csi/11d78c0562e2cd02702a57d274e90d36ba5d472d5d861a29575c9a530690e15 key=pmem-csi-operator-metrics_v1_service.yaml
time="2021-11-19T13:08:57Z" level=info msg="added to bundle, Kind=ClusterServiceVersion" configmap=pmem-csi/11d78c0562e2cd02702a57d274e90d36ba5d472d5d861a29575c9a530690e15 key=pmem-csi-operator.clusterserviceversion.yaml
time="2021-11-19T13:08:57Z" level=info msg="added to bundle, Kind=ServiceAccount" configmap=pmem-csi/11d78c0562e2cd02702a57d274e90d36ba5d472d5d861a29575c9a530690e15 key=pmem-csi-operator_v1_serviceaccount.yaml
time="2021-11-19T13:08:57Z" level=warning msg="status not equal, updating..." id=kU63Z ip=install-kmp2g namespace=pmem-csi phase=RequiresApproval
time="2021-11-19T13:08:57Z" level=warning msg="an error was encountered during reconciliation" error="Operation cannot be fulfilled on subscriptions.operators.coreos.com \"pmem-csi-operator-v1-1-0-sub\": the object has been modified; please apply your changes to the latest version and try again" event=update reconciling="*v1alpha1.Subscription" selflink=
E1119 13:08:57.444901       1 queueinformer_operator.go:290] sync {"update" "pmem-csi/pmem-csi-operator-v1-1-0-sub"} failed: Operation cannot be fulfilled on subscriptions.operators.coreos.com "pmem-csi-operator-v1-1-0-sub": the object has been modified; please apply your changes to the latest version and try again
time="2021-11-19T13:08:57Z" level=info msg=syncing event=update reconciling="*v1alpha1.Subscription" selflink=
time="2021-11-19T13:08:57Z" level=info msg=syncing event=update reconciling="*v1alpha1.Subscription" selflink=
E1119 13:08:57.646167       1 queueinformer_operator.go:290] sync {"update" "pmem-csi/install-br4hc"} failed: failed to update installplan bundle lookups: Operation cannot be fulfilled on installplans.operators.coreos.com "install-br4hc": the object has been modified; please apply your changes to the latest version and try again
time="2021-11-19T13:08:57Z" level=info msg=syncing id=bJNHg ip=install-br4hc namespace=pmem-csi phase=RequiresApproval
time="2021-11-19T13:08:58Z" level=info msg=syncing event=update reconciling="*v1alpha1.Subscription" selflink=
time="2021-11-19T13:08:58Z" level=info msg=syncing id=edGDA ip=install-kmp2g namespace=pmem-csi phase=RequiresApproval
time="2021-11-19T13:08:58Z" level=info msg=syncing id=8qVMP ip=install-br4hc namespace=pmem-csi phase=RequiresApproval
time="2021-11-19T13:08:58Z" level=info msg=syncing event=update reconciling="*v1alpha1.Subscription" selflink=
time="2021-11-19T13:08:58Z" level=info msg=syncing event=update reconciling="*v1alpha1.Subscription" selflink=
time="2021-11-19T13:08:58Z" level=info msg=syncing event=update reconciling="*v1alpha1.Subscription" selflink=
time="2021-11-19T13:08:58Z" level=info msg=syncing id=Y6++j ip=install-kmp2g namespace=pmem-csi phase=Installing
```

The "object has been modified" error also occurs, so that seems to be a red herring. The difference is that here the phase eventually gets to "Installing".


Face not detected!

It no longer detects face neither in Sign Up nor in Sign In.

im willing to collaborate on enhancement and documentation. who would want to join me ?


IDVA6-697 Remove automatic browser email validation

Link to Jira:
https://companieshouse.atlassian.net/browse/IDVA6-697
Changes:
Adds a novalidate attribute to the form, removing the browser validation behaviour for email inputs

CI: No security warnings found

CI: No security warnings found


Catch unhandled error in test

This PR will catch an unhandled (but expected) error in one of the tests.
Before, the error was seen in the test output. After this PR, the error is not shown in the output (expected).

Thanks!


Cabana: add window icon

@deanlee is there a better way to do this?

it's good.:D

Lol, let's at least make this a bit nicer. Maybe just bigger comma and make it a circle?

@deanlee do you want to make a PR to add support for a tools/cabana qrc file? That's the only thing left for this :)

@sshane  added qrc resource file in https://github.com/commaai/openpilot/pull/27386

@deanlee away from my desktop and cabana doesn't yet work on Win11, can you test this out?


WebAdaptor 10.6.1 won't install on IIS

Community Note

Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request

Module Version

3.0.1

Affected Resource(s)

ArcGIS_Server WebAdaptor

Configuration Files

{
    "AllNodes": [
        {
            "NodeName": "server.domain.tld",
            "Role": [
                "Server",
                "ServerWebAdaptor"
            ]
        }
    ],
    "ConfigData": {
        "Version": "10.6.1",
        "DesktopVersion": "10.6.1",
        "ServerContext": "arcgis",
        "ServerRole": "GeneralPurposeServer",
        "Credentials": {
            "ServiceAccount": {
                "UserName": "arcgis",
                "Password": "neinneinnein",
                "IsDomainAccount": false
            }
        },
        "Server": {
            "LicenseFilePath": "C:\\install\\ArcGISGISServerStandard_ArcGISServer_xxxxxx.prvc",
            "Installer": {
                "Path": "C:\\install\\ArcGIS_Server_10.6.1\\Setup.exe",
                "InstallDir": "C:\\ArcGIS\\Server",
                "InstallDirPython": "C:\\Python27",
                "PatchesDir": "C:\\install\\ArcGIS_Server_Patches"
            },
            "ServerDirectoriesRootLocation": "C:\\arcgisserver\\directories",
            "ConfigStoreLocation": "C:\\arcgisserver\\config-store",
            "LocalRepositoryPath": "C:\\arcgisserver\\local",
            "ServerLogsLocation": "C:\\arcgisserver\\logs",
            "ServerDirectories": [
                {
                    "name": "arcgiscache",
                    "physicalPath": "C:\\arcgisserver\\directories\\arcgiscache",
                    "directoryType": "CACHE",
                    "cleanupMode": "NONE",
                    "maxFileAge": 0
                },
                {
                    "name": "arcgisjobs",
                    "physicalPath": "C:\\arcgisserver\\directories\\arcgisjobs",
                    "directoryType": "JOBS",
                    "cleanupMode": "TIME_ELAPSED_SINCE_LAST_MODIFIED",
                    "maxFileAge": 360
                },
                {
                    "name": "arcgisoutput",
                    "physicalPath": "C:\\arcgisserver\\directories\\arcgisoutput",
                    "directoryType": "OUTPUT",
                    "cleanupMode": "TIME_ELAPSED_SINCE_LAST_MODIFIED",
                    "maxFileAge": 10
                },
                {
                    "name": "arcgissystem",
                    "physicalPath": "C:\\arcgisserver\\directories\\arcgissystem",
                    "directoryType": "SYSTEM",
                    "cleanupMode": "NONE",
                    "maxFileAge": 0
                }
            ],
            "RegisteredDirectories": [
                {
                    "name": "BasemapsCacheDir",
                    "physicalPath": "C:\\arcgisserver\\additionaldirs\\cache",
                    "directoryType": "CACHE"
                },
                {
                    "name": "TestOutputDir",
                    "physicalPath": "C:\\arcgisserver\\additionaldirs\\testOutput",
                    "directoryType": "OUTPUT"
                },
                {
                    "name": "TestJobsDir",
                    "physicalPath": "C:\\arcgisserver\\additionaldirs\\testJobs",
                    "directoryType": "JOBS"
                }
            ],
            "PrimarySiteAdmin": {
                "UserName": "siteadmin",
                "Password": "siteadmin"
            }
        },
        "WebAdaptor": {
            "AdminAccessEnabled": true,
            "Installer": {
                "Path": "C:\\install\\WebAdaptorIIS_10.6.1"
            }
        }
    }
}

Expected Behavior

WebAdaptor gets installed
Actual Behavior

ArcGISInstall-5-14-2020-7-11-27-AM-Error.txt
This command cannot be run due to the error: Server execution failed.
Filename: \?\C:\inetpub\wwwroot\arcgis\web.config
Error: Cannot write configuration file
Steps to Reproduce
Invoke-ArcGISConfiguration -ConfigurationParametersFile $arcgisConfiguration -Mode InstallLicenseConfigure
Important Factoids

Windows Server 2016 Datacenter
Machine in Azure (Netherlands)
Manually running WebAdaptorIIS_10.6.1 works fine on the machine.
References

@esride-sof Does it happen on subsequent runs? Let's try rebooting the target node to see if this helps perhaps there is a file lock.

I did two things:

Update to 3.0.2
Change Installer Path to include the setup.exe

Now I get this error message:
[DEV0173W]: LCM:  [ Start  Resource ]  [[ArcGIS_IIS_TLS]WebAdaptorCertificateInstallxxx.xxx.de]
[DEV0173W]: LCM:  [ Start  Test     ]  [[ArcGIS_IIS_TLS]WebAdaptorCertificateInstallxxx.xxx.de]
**Cannot find a provider with the name 'WebAdministration'.**
[DEV0173W]: LCM:  [ End    Test     ]  [[ArcGIS_IIS_TLS]WebAdaptorCertificateInstallxxx.xxx.de]  in 0.0660 seconds.

Seems that the script is testing the installed TLS certificates, but fails. I executed the script from PS command line as an Administrator. Are the elevated rights not passed on correctly?

@esride-sof Does it happen on subsequent runs? Let's try rebooting the target node to see if this helps perhaps there is a file lock.

Yes it happens each time, also after rebooting the machine.

I solved the problem :-)

First installation of WebAdapter failed for an unknown access right problem.
The web.config file was created in the IIS directory arcgis under inetpub.
All further installation attempts where aborted in silent mode, because the web.config files exists.
The installer did nothing because of the existing file, but did not report an error.
The configuration step throws errors, because the installer did not copy any files.
After manually deleting the arcgis folder from inetpub, web adaptor got installed.


Added CHECK_ORDER and PARALLELISM 1 to IC12 Test

What happens is: since we use multiple threads for the results, we might get different order. To solve this issue, we sort the results in the test runner.
The expected result is sorted:
[2023-06-15 12:07:41.256] [info] RESULT:

[2023-06-15 12:07:41.256] [info]<PHONE_NUMBER>8353|Otto|Muller|[Tiberius,Genghis_Khan,Justinian_I,Constantine_the_Great,Trajan]|11
[2023-06-15 12:07:41.256] [info]<PHONE_NUMBER>3500|Otto|Becker|[Tiberius,Genghis_Khan,Julius_Caesar,Alexander_the_Great,David]|5
[2023-06-15 12:07:41.256] [info]<PHONE_NUMBER>4548|Bing|Zheng|[Genghis_Khan,Hadrian,Solomon]|6
[2023-06-15 12:07:41.256] [info]<PHONE_NUMBER>4994|Jie|Wang|[Genghis_Khan,David]|7
[2023-06-15 12:07:41.256] [info]<PHONE_NUMBER>2537|Anh|Nguyen|[Mahmud_of_Ghazni,Trajan]|3
[2023-06-15 12:07:41.256] [info]<PHONE_NUMBER>8932|Alexander|Hleb|[Mahmud_of_Ghazni,David]|3
[2023-06-15 12:07:41.256] [info]<PHONE_NUMBER>764|Zheng|Xu|[Mahmud_of_Ghazni,Ashoka,Tiberius,Marcus_Aurelius,Genghis_Khan,Justinian_I,Hadrian,Timur]|13

There are two ways to fix this:

You can use sorted results in the test file if the order doesn't matter; or
You can add -CHECK_ORDER to disable sorting the results and enforce using only one thread with -PARALLELISM 1

-NAME IC12
-CHECK_ORDER
-PARALLELISM 1
-QUERY MATCH ...
...

Closes #1668

What happens is: since we use multiple threads for the results, we might get different order. To solve this issue, we sort the results in the test runner.
The expected result is sorted:
[2023-06-15 12:07:41.256] [info] RESULT:

[2023-06-15 12:07:41.256] [info]<PHONE_NUMBER>8353|Otto|Muller|[Tiberius,Genghis_Khan,Justinian_I,Constantine_the_Great,Trajan]|11
[2023-06-15 12:07:41.256] [info]<PHONE_NUMBER>3500|Otto|Becker|[Tiberius,Genghis_Khan,Julius_Caesar,Alexander_the_Great,David]|5
[2023-06-15 12:07:41.256] [info]<PHONE_NUMBER>4548|Bing|Zheng|[Genghis_Khan,Hadrian,Solomon]|6
[2023-06-15 12:07:41.256] [info]<PHONE_NUMBER>4994|Jie|Wang|[Genghis_Khan,David]|7
[2023-06-15 12:07:41.256] [info]<PHONE_NUMBER>2537|Anh|Nguyen|[Mahmud_of_Ghazni,Trajan]|3
[2023-06-15 12:07:41.256] [info]<PHONE_NUMBER>8932|Alexander|Hleb|[Mahmud_of_Ghazni,David]|3
[2023-06-15 12:07:41.256] [info]<PHONE_NUMBER>764|Zheng|Xu|[Mahmud_of_Ghazni,Ashoka,Tiberius,Marcus_Aurelius,Genghis_Khan,Justinian_I,Hadrian,Timur]|13

There are two ways to fix this:

You can use sorted results in the test file if the order doesn't matter; or
You can add -CHECK_ORDER to disable sorting the results and enforce using only one thread with -PARALLELISM 1

-NAME IC12
-CHECK_ORDER
-PARALLELISM 1
-QUERY MATCH ...
...

Closes #1668

Let's not close #1668 though. I think we should get the correct output on all platforms with multi-thread execution. So #1668 is still a bug that needs to be addressed.


MouseWheel Scrolling Ignores Operating System Settings

Prerequisites

[X] Can you reproduce the problem in safe mode?
[X] Are you running the latest version of Atom?
[ ] Did you check the debugging guide?
[X] Did you check the FAQs on Discuss?
[ ] Are you reporting to the correct repository?
[X] Did you perform a cursory search to see if your bug or enhancement is already reported?

For more information on how to write a good bug report or enhancement request, see the CONTRIBUTING guide.
Description
The number of lines the mouse wheel scrolls does not correspond to the setting in the operating system.
Steps to Reproduce

Open file in Atom
Scroll up and down with the mouse wheel

Expected behavior: [What you expected to happen]
The number of lines scrolled should be equal to the setting in the operating system.
Actual behavior: [What actually happened]
The number of lines scrolled gnores the operating system's setting.
Versions
1.8

On which OS do you observe this behavior?

I can confirm this on Windows 10 x64, Atom 1.9.0-dev-3b9b28d.  The default is to scroll three lines but in Atom it's more like 2.5ish lines.

Atom has a Scroll Sensitivity core setting that increases the number of lines scrolled.
I tested this on Windows 7 and can confirm that OS settings in the control panel are ignored.

Same issue here. This happens at least on Windows 10. I have configured the system to scroll 10 lines every scroll well movement. Yet Atom ignore this and only scrolls 2. That means in Atom I have to scroll 5 times more than any other program.

In ubuntu 16.04 and atom 1.9.2 the scroll direction is inverted.

--solved-- In ubuntu 16.04 and atom 1.9.2 the scroll direction is inverted.
My scroll buttons where swapped using xinput, the problem was that gnome/GTK apps didn't recognize that swap, so instead of swapping the scroll buttons I have swapped the "Evdev Scrolling Distantance" like this:
xinput set-prop "Kensington Kensington Slimblade Trackball" "Evdev Scrolling Distance" -1 1 1

Another workaround is the reverse scroll wheel package.

Can confirm on Windows 10 Pro x64 and Atom v 1.15.0. OS setting is 12 lines, Atom scrolls roughly 2.1 lines.

I confirm the same issue on Windows 10 Home x64 and Windows 7 x64.


Documentation on GUI workspace

Hi I saw that there the GUI workspace mode screenshot but the documentation and commands have no mention of it.
Would like to run it independently to check on the status of scans. Would be helpful

Basically, workspaces on the Web UI is listing the workspaces folder and show what done for specific workspace.
So you can totally run it independently by running flask server using this command python3 core/app.py run and run osmedeus.py -t example.com --client for other target.

Thanks for the reply this is really helpful. :)


Use newer container-based builders in Travis and test JDK8 too

Fixes #468

looking at :8ball: to see if this build will pass

lgtm on green (and even if not green, I guess.. as long as it is not worse than before :))

Well, the build doesn't look worse so that's something? #440 is still alive and well, these builds failed with:
[warn]     ::::::::::::::::::::::::::::::::::::::::::::::
[warn]     ::              FAILED DOWNLOADS            ::
[warn]     :: ^ see resolution messages for details  ^ ::
[warn]     ::::::::::::::::::::::::::::::::::::::::::::::
[warn]     :: io.netty#netty;3.10.1.Final!netty.jar(bundle)
[warn]     ::::::::::::::::::::::::::::::::::::::::::::::

:crying_cat_face:

It's likely you'll run into this issue, which I reported in January after trying this for Finagle. As far as I know it's not been fixed yet. If you're willing to remove -Djava.net.preferIPv4Stack=true from your sbt runner that should work as well.

@travisbrown I don't think I understand the pattern that links our build issues with the ones you link. We're not seeing JVMs crater, we're just seeing inconsistencies with the ability of a Travis builder to fetch the same dependency the N times the sbt build tries to grab it.

@rtyler Right, I'm not claiming this is responsible for the current build issues—just that if you switch to the containerized build system, you'll get a buffer overflow if you call getHostName anywhere in your tests.

@travisbrown https://github.com/openzipkin/zipkin/pull/472 on the getHostName thingy


How do you implement SLic on pair_pm model?

Hi, thanks for uploading the code for pair_pm! Since in the blog, it seems that you are using SLiC for pair_pm models. In the directory of pair_pm, I can't find the code for using slic methods.

Hi, thanks for your interest in our project!
We mention Slic paper because the pair-wise model training was first proposed in this paper. We do not do RLHF in this project. If you are interested in the subsequent RLHF stage, you may check this project https://github.com/RLHFlow/Online-RLHF


[BUG]

Describe the bug
SAX module not working
To Reproduce
import numpy as np
import pandas as pd
import sktime
from sktime.datasets import load_gunpoint

X_train, y_train = load_gunpoint(split='TRAIN', return_X_y=True)
X_test, y_test = load_gunpoint(split='TEST', return_X_y=True)
from sktime.transformers.dictionary_based import SAX

print("iloc[0]: {}".format(X_train.iloc[0].to_numpy()))
sax = SAX.SAX(window_size=10, word_length=5, alphabet_size=4)
D_X_train = sax.transform(X_train)
print("sax(iloc[0]): {}".format(D_X_train[0].to_numpy()))

Expected behavior
Runs with compile/runtime errors
Additional context
Error is in line 112 in SAX.py, where you refer to:
shapelets.RandomShapeletTransform.zscore(split, axis=None)  # move to utils or create new method?
which should be:
split = shapelets.ShapeletTransform.zscore(split, axis=None)
I would suggest you make simple unit tests, where somethine, like the SAX transform module, is run on some fixed array and checked if the output is still valid.
Versions

Darwin-18.7.0-x86_64-i386-64bit
Python 3.7.4 (default, Sep  7 2019, 18:27:02)
[Clang 10.0.1 (clang-1<IP_ADDRESS>)]
NumPy 1.17.2
SciPy 1.3.1
sktime 0.3.0

hi thanks for that, we will take a look and get back to you.

should be fixed in dev, will go into master on next release, thanks for finding it


Get 'typing' status for any chat

First of all thank you for this tool. I'm making a small a cli front for it and noticed the chat typing status is only thing I miss in this wrapper.
This issue would basically be feature request #275 but reversed: get all chats which have the 'typing...' status message.

Hey @mvrozanti, nice CLI you are coding, good luck!
What you are looking for is the chat presence chatstate.type property of the user.
You can easily find it with javascript:
window.WAPI.getChat("14078007750@c.us").presence.chatstate.type
Should return any of them:
undefined, available, unavailable, composing, recording
If you are intereseted, this is what it is told to output on the actual web service:
web_conversation_is_recording: "recording audio\u2026",
web_conversation_name_is_composing: "__participant__ is typing\u2026",
web_conversation_name_is_recording: "__participant__ is recording audio\u2026",```

This window.WAPI.getChat("number@c.us").presence.chatstate.type works if you look for a single contact, but if you pretend to check ALL people online, writing, etc, you'll need to use the events.
If found this, which works pretty cool. Of course, I've used an Ajax post instead of the console.log().
A way to implement this to the python wrapper would be to create a vault for those events and remove them on read, like it does with the other Observers.
window.Store.Presence.on("change:isOnline", c => console.log(JSON.stringify(c.__x_chatstate)))
This code is global for the Presence object, so any user getting online, offline, writting, etc will fire it.
This code outputs: {"id":"34666666666@c.us","type":"available","t":1621628938,"deny":false}
For some reason, the chat.chatstates is empty, so I've been forced to digg into __x_chatstate
Really wanted this feature :_)


internal/race: add the package

We have a bunch of race-related copy-paste in sync, sync/atomic, net, syscall, runtime.
Moreover, any race-related functionality requires 2 files -- race.go and norace.go -- as
race functions are not provided by runtime in non-race build.

We can create internal/race package and move things like IsEnabled, Acquire, Release to
it. It will remove the copy-paste and all the additional files from other packages.

Additionally then we will be able to easily exclude or tune tests in race mode using
race.IsEnabled. E.g. now we have the cpuprof test that constantly flakes on
freebsd-amd64-race.

Too late for Go 1.5.


feat: client work for queryFlux

These commits were merged as part of a different branch, so I am closing this branch.


Docs: Prevent virtual types reaching docs generator

Fixes #6201
I was unable to reduce the code for a short repro. But somehow the Lucky::Routeable managed to produce some virtual types that were not handled in the docs generator.
Virtual types does not make sense in the doc generator since from the user perspective they are always substitutable by a subclass. That is what virtual types represent inside the compiler, while a type is an exact reference. This serves mainly during the codegen.
@paulcsmith, would you mind checking the the output is the expected one? The method that complained was Lucky::Route#action that was returning a virtual type of Lucky::Action.class

Thanks @bcardiff! Just to be clear, do you want me to pull this branch done and try to use it to generate docs for Lucky?

I did and the docs were generated. So far the output seems right, but you might want to double check it. So, yes please if you want :-)

Awesome! Thanks so much for the fix. I'm excited to give it a try


Customizable model associations

Provide a way to customize which associations are displayed when showing a model.
I have just realized that I've been completely ignoring the DataMapper adapter and only modifying the ActiveRecord class. :-/

Model.associations(*associations) conflicts with an already existing Model.associations method.

I think I renamed the original method? In any case, this is working in production for me, so something is right about it.


fix(raw_vehicle_cmd_converter): csv paths are resolved in param.yaml

Description
Part of:

https://github.com/autowarefoundation/autoware.universe/issues/6473

Should be merged after:

https://github.com/autowarefoundation/autoware.universe/pull/6476

Tests performed

Not applicable.
Effects on system behavior

Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.

[x] I've confirmed the contribution guidelines.
[x] The PR follows the pull request guidelines.

In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.

[ ] The PR follows the pull request guidelines.

Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.

[ ] There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

https://github.com/autowarefoundation/autoware.universe/pull/6476

is merged, this is now ready to merge.


Sorbet thinks an Array is a Set

Input
→ View on sorbet.run
# typed: true
T.let(
  { 1 => [:x] },
  T::Hash[Integer, T::Set[Symbol]]
)

Observed output
No errors! Great job.

Expected behavior
Sorbet should say e.g. "Expected Set, got Array"

Hmmm, it seems this is intentional.

Sorbet used to take these type parameters into account during runtime type-checking, but .. this behavior was eventually removed.
https://sorbet.org/docs/stdlib-generics

I can see how this would impact performance, but I'm not sure compromising the integrity of the type system is worth it.

Re-opening because the docs say that runtime type-checking is disabled, but this issue also demonstrates a problem with static analysis.

This is a bug in how sorbet treats hash literals as shape types.
Closing as a dupe of #11


Nightly build which runs only once for a commit

Pre-flight check-list
Before raising a pull request

[ ] Documentation
[ ] Unit tests

Pre-merge check-list

[ ] Link to Trello ticket/GitHub issue (If applicable)
[ ] Any risky areas identified
[ ] Test plan provided
[ ] Tester approved

Tester check-list

[ ] Tested on multiple devices / OS versions (Test on the physical device(s) you have access to, otherwise use BrowserStack):

[ ] Galaxy S8 (Android 7.0/8.0)
[ ] Galaxy S7 (Android 6.0)
[ ] iPhone X (iOS 11.x)
[ ] iPhone 8 (11.x)
[ ] iPhone 7 (iOS 10.x)

Optional:

[ ] Google Pixel 2
[ ] Galaxy S8 Plus
[ ] Galaxy S7 Edge
[ ] Galaxy S6
[ ] iPhone 7+
[ ] iPhone 6

Accessibility Testing (If applicable)

[ ] Text-to-Voice (Android: Voice Assistant / iOS: Speak Selection)
[ ] Large Text (=<200%)
[ ] Landscape Screen orientation

Weak connection testing (If applicable)

[ ] Airplane mode
[ ] 2G/3G Network Settings

@markholland The nightly build started at 8am now (shifted by 1 hour for some reason). What do you think? Merge like this?

Let's get this in so that we can get release builds going on Friday

I agree with your comments but I couldn't find the time to work on it recently. I don't mind merging now and fixing this later, though.
I think if we merge this we need to change the branch filter for the nightly builds to "master".


What about single selector subscription?

What about single selector subscription like this one?

In the code you linked useEffect callback is only invoked on initial render so if a new selector is provided it will never be used.

Yeah that looks very similar, just without the shallow equal check. Is there an actionable request here? You could change this issue to be about allowing a custom comparison function. If you do, please reopen.


Numeral System for Chapter/Verse Navigation

Fixes #488
The following setting in Scripture App Builder controls the numeral system for chapter and verse numbers within a book collection:

This setting can be further customized for each book within a collection:

This fix makes these settings effective for chapter and verse selectors, as the following screenshots show.

Thank you. This has been corrected.


Exorcizm Contract: Pentagram spawns below the jumps

Here a picture:

Known issue with vanilla spawn scrap behaviour. I don't know if there's any other method of spawning that consistenly puts the item in a player-acessible area.

Also the bomb contract, but thx for responding.

I think I will disable the "Spawn main object far away" option, because that worked once.
Also, can you tell me, how can we identify a demon in an exorcizm contract @WhiteSpike?

okay thank you, I'm just very silly because I thought wraith is write so I was confused.


Update scalafmt-core to 3.8.2

About this PR
📦 Updates org.scalameta:scalafmt-core from 3.7.17 to 3.8.2
📜 GitHub Release Notes - Version Diff
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.scalameta", artifactId = "scalafmt-core" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "org.scalameta", artifactId = "scalafmt-core" }
}]

labels: library-update, early-semver-minor, semver-spec-minor, commit-count:1

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 0.00%. Comparing base (4aa8d96) to head (c3531ce).
Report is 110 commits behind head on main.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #360       +/-   ##
==========================================
- Coverage   84.04%   0.00%   -84.05%
==========================================
  Files          19       1       -18
  Lines         282      16      -266
  Branches        6       1        -5
==========================================
- Hits          237       0      -237
+ Misses         45      16       -29

Flag
Coverage Δ

2.13.14
0.00% <ø> (?)

temurin@11
0.00% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Further Development

instance password https://github.com/keboola/java-oracle-exporter/blob/master/data/config.json#L7
https://github.com/keboola/internal/issues/18#issuecomment-399562759
development tasks:

use proper CSV library e.g. https://commons.apache.org/proper/commons-csv/user-guide.html ?
either read yaml or have db-extractor-oracle create the config file
get headers somehow, or maybe leave it as it is and supply them in db-extractor?

i'd see 1. as the safest (i.e. passing SQL query via args or envs i going to break it), and when db oracle ex will use json config file, it'll be the easiest to implement too

ok, thanks, agreed


Regression: NRT_MemInfo_new_varsize_dtor could not be resolved

I got a regression from Numba 0.38.1 to 0.39.0. First offending commit is e0ebf81799d0937e7bd6b93aba2726be53946308.
The following minimal example fails:
import numpy as np
import numba as nb

@nb.jit(nopython=True)
def test_func(a: np.ndarray):
    return np.argsort(a)

test_func(np.arange(0, 10))

The error I'm getting is
LLVM ERROR: Program used external function 'NRT_MemInfo_new_varsize_dtor' which could not be resolved!

I'm running this on Ubuntu 16.04, llvmlite 0.25.0rc1, LLVM 6.0.1.

Sorry, couldn't reproduce the error on another machine and decided to try again by deleting the build folder before rebuilding/reinstalling Numba from source. Error is gone. Apparently some inconsistency in the build process.


[SIP-120] Enhanced Time Comparisons on Bar and Line Charts

Motivation

Allow for more customization on bar and line charts when using the time comparison feature
Increase the flexibility of selecting a comparison date

Proposed Changes
Add the ability to do the following in Bar charts when using the Time Shift feature.
Time Shift Selection:

Select a custom time shift by selecting a start date from a date selector. This would allow for simpler comparison when looking at a holiday across multiple years. Black Friday in 2023 is on a different calendar date than Black Friday 2022 and isn’t currently easy to compare using the Time Shift.
Ability to easily shift the time based on the length of the original time range. For example, if the original chart time filter was 3 weeks and 1 day, the user could easily shift the time range to look at the 3 week and 1 day long period directly preceding the existing chart filter.
Display the comparison ranges in the control panel for the user to easily verify the comparison dates

Chart customizations:

Customize whether the comparison bar should appear to the left, right, or in chronological order vs the original bar
Customize the tooltip to include additional information such as the difference between the comparison period and the original or the % change between the two time periods
Display the comparison and original time ranges in the chart area for non-creator chart users to easily understand the comparison dates

For Line Charts, we’d like to make all the above changes with the same patterns (other than customizing where the comparison bar appears).
New or Changed Public Interfaces
See UI mockup here:

New dependencies
None
Migration Plan and Compatibility
In moving the controls to a new section in the Explore Control Panel, we’ll need to ensure that existing controls on previously created charts are retained.
Rejected Alternatives
We considered whether these changes could require a new chart type or a new control for the time shift, but they had enough overlap with the current Time Shift functionality that it made the most sense to integrate it with existing charts and controls.

Thank you for the SIP @yousoph. Thinking about this SIP and https://github.com/apache/superset/issues/27432, and considering this comment, it seems we are dealing with 2 separate problems:
1 - How do we configure/support time shifts consistently between plugins (in or out of advanced analytics, how to configure/display multiple time shifts, API changes, etc)
2 - How do we represent time shifts for each chart type (extra columns in a table, lines/bars with different patterns, additional and exclusive controls per visualization such as bar placement).
I would suggest discussing point number 1 in a specific SIP to make sure we have a consistent behavior between plugins and answer the following:

In all other chart types, time shifts are inside the Advanced Analytics panel. Here we are proposing to show them in a different section. I'm worried this will decrease UI consistency, as users frequently associate available features with the categories that the panel represent. In other words, once they associate that time shifts are inside the Advanced Analytics, they will always expect to find that feature in the same place between plugins.
I understand that the current implementation of time shifts is limited and not flexible as the one we are proposing here. Assuming that all plugins will adhere to this new form of configuring a time shift, and trying to avoid the situation where time shifts behave differently between plugins, would be possible to change this globally? Apart from UI consistency, I'm also thinking about the required API/query object changes and maintaining a single implementation. If we want to do this in multiple steps, I would suggest to implement the new table features using the current time shift implementation and later work on the time shift changes globally.
Could you expand on what are the required changes for our query API/concepts? I think this is the main point of the SIP given the many discussions happening on https://github.com/apache/superset/pull/27355 and https://github.com/apache/superset/pull/27386 about potential solutions.

Then, after resolving the configuration part, this SIP and https://github.com/apache/superset/issues/27432 deals with point number 2.
Discussing point number 1 in a split way, introduces many inconsistencies such as:

This SIP proposes time shifts to be configured in its own collapse panel
https://github.com/apache/superset/issues/27432 proposes a different approach using a checkbox called Enable time comparison
The rest of the plugins propose to configure time shifts using Advanced Analytics

By the way, I like the idea of Time comparison being a separate panel. We could create a component for that and apply to all plugins.

I think if we create a new Time Comparison panel, that we should do that for any charts that currently have time comparison in Advanced Analytics.

@yousoph
The Time Comparison feature is not only about "comparing different date filters," but it also involves:

Calculating ratios, differences, or percentage changes.
Rolling data based on the date-time index.
Filling up lost values

IMO, we should consider "how to improve UI/UX in advanced analytics" without re-implementing parts of the previous function in different charts.

That's a great point @zhaoyongjie. Some of the features you mentioned are very important when comparing time periods. @zhaoyongjie @yousoph @eschutho @kasiazjc Do you think a working session (2 hours) would be interesting to discuss possible solutions?

+1 on bifurcating the discussion into two topics: configuration and display. It would be ideal to have the controls/config be a consistent interface between all plugins that use this feature. We should strive to make the plugin control panels as cohesive/consistent as possible, as this has historically been painful to improve or maintain.

@yousoph should we kick off a [VOTE] and make it official?

Closing as voted down, but only in order to split it into two SIPs as described above.
I don't think we need as much discussion on #1 any more since the checkbox idea is out of the running, but it'll be good to have official consensus on the proposal and migration plan nonetheless.


Highlights and load

uses https://github.com/apache/brooklyn-server/pull/818 to add highlights for software-specific entities.  also adds new perf test.

thanks for the comments @tbouron - i've replied, and think the PR as it stands is correct.  wdyt?

Retest this please.

@ahgittin Yup, looks good but I would like Jenkins to be happy before merging it.
Looking at the logs, looks like the failure is unrelated though

hmm, failure is related:
[ERROR] /home/jenkins/jenkins-slave/workspace/brooklyn-library-pull-requests/software/network/src/test/java/org/apache/brooklyn/entity/network/bind/PrefixAndIdEnricher.java:[56,9] cannot find symbol
  symbol:   method highlightTriggers(org.apache.brooklyn.api.sensor.AttributeSensor<capture#1 of ?>,<nulltype>)
  location: class org.apache.brooklyn.entity.network.bind.PrefixAndIdEnricher

it's trying to reference org.apache.brooklyn:brooklyn-parent:0.12.0-SNAPSHOT.  have merged in master branch which changes deps to 0.13.0, retest will now hopefully be happy.

tests good after merging master, so merging this


Added BiScEF to projects.yml

After my presentation at ESWW, it was suggested that I add the repo to the list at heliopython. So, here it is. It's not really a software project (the core content is the format description), but contains some python scripts.

Thank you for your submission. I've had a slow start to the year but I will review this in the next week or so. Just wanted to let you know I saw it. 👍

Hi @knutstanley, I finally got around to reviewing this. I think it's always interesting when someone comes up with a new format, and it sounds like there were some positive sentiments from ESWW, but I do have questions about including this in PyHC.
Like you said, it's not really a software project. Thanks for being upfront about that. Am I correct that the only Python functionality provided is (1) plotting the files and (2) converting them to HDF5? I would, at the least, want that functionality more clearly documented before considering merging this.
I agree with your self-evaluation badges. Projects are allowed to join even if some things "require improvement," but when pretty much everything requires improvement like this, it's a special case and becomes my digression. We typically only let it slide if there is already a non-trivial user base (if it's something people are actually using) and if there are immediate plans to further develop the repo. Can you explain if either of these are the case for you?

Oh and the merge conflict is my fault. I merged another PR earlier today that added a "HERMES-Core" project to this project.yml file. I could resolve that myself later.

Projects are allowed to join even if some things "require improvement," but when pretty much everything requires improvement like this, it's a special case and becomes my digression. We typically only let it slide if there is already a non-trivial user base (if it's something people are actually using) and if there are immediate plans to further develop the repo. Can you explain if either of these are the case for you?

The user base is currently very small.
We intend to expand it, of course, but can not guarantee that the rest of the world will actually agree with us and start using it.
The repo will be updated, but we do not currently have concrete plans for developments that would change the badge situation.
This is mainly because the software part is a minor part, while the format description is the important part.

Am I correct that the only Python functionality provided is (1) plotting the files and (2) converting them to HDF5? I would, at the least, want that functionality more clearly documented before considering merging this.

We could expand on the documentation of this, if that alone would be enough to be on the list.
But from the rest of your comment, I suspect a bit more is required.
No hard feelings if you decide not to include this.
I made this suggestion for a list entry just because a person which clearly was more familiar than me with PyHC thought I should do it, and the effort required to do so was not very large.
A bit of a "shot in the dark" to see what would happen.

Understood. Thanks again for being open. We talked about your project at a telecon this morning, and a few people wondered if you wouldn't mind pitching this format to PyHC a little? As in write just a few sentences here in this PR for how the BiScEF format would benefit the community? E.g. what heliophysics use cases does this format address? What types of people might use it? That kind of thing?

The BiScEF format is designed to hold data produced by "Scintillation receivers" (One of the most widely used currently is: https://www.septentrio.com/en/products/gps/gnss-reference-receivers/polarx5s).
These receive signals from GNSS (Global navigation satellite system) satellites, but at a much higher sampling rate than
normal GNSS receivers, with more robust signal tracking, and with options for output of types of data that is not usually an output from normal GNSS receivers.
Their main task is to measure the strength of phase fluctuations, amplitude fluctuations, and high-resolution phase data.
This characterizes the signal scintillation, which is mainly caused by small-scale density fluctuations in the ionosphere.
The density fluctuations are in turn caused by the interaction of the Earth atmosphere and magnetosphere with structures in the solar wind.
The structures in the solar wind are originating from events at the Sun.
Data measured by these receivers are used both operationally for monitoring purposes (e.g.: http://chain.physics.unb.ca/chain/), and by the academic community to perform research on the ionosphere, the ionosphere-magnetosphere-solar wind connections, and on the impact of the disturbances on technical systems.
I know that this kind of data is commonly used in the space physics community, but I do not know to which extent the heliophysics community use them.
For these data to be of use you would need to be interested in Earths' ionosphere and/or impact on trans-ionospheric signals.
There has not really been a standard format for storing and sharing these data.
An attempt was made with the SCINTEX format (https://www.icao.int/APAC/Documents/edocs/SCINtintillation.pdf), which was based on the RINEX format.
SCINTEX has several major short-comings and is in my opinion not very suitable. (Illustrated by the fact that I felt compelled to define a new format myself)
(Also, I have never seen any SCINTEX data files in any data archive and do not know of anyone using it.)
Receiver manufacturer tools output results in their own very simple files, which are practical to use but not suitable for storage and sharing (for instance, they contain no metadata at all).

Thanks for the comment @smithara. I agree this would belong in an "awesome list" if PyHC made one. But after careful consideration, I'm sorry but I'm going to close this PR without merging. BiScEF in its current state is just too unrelated to the rest of our PyHC packages. I appreciate the submission though, and could reconsider in the future if BiScEF catches on more and/or if the repo's Python tooling matures. Thank you.


RELEASE-1: update project version

Technical Details
Update project version to 21.4

Resolved by commit 090f702


[Refactor] Refactor the code of TabletSchema

Why I'm doing:
What I'm doing:
TabletSchema is copy on write. In order to prevent misuse, make the following changes:

Extract some common logic in TabletSchema..
Reduce unnecessary deep copy.

What type of PR is this:

[ ] BugFix
[ ] Feature
[ ] Enhancement
[x] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Does this PR entail a change in behavior?

[ ] Yes, this PR will result in a change in behavior.
[x] No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

[ ] Interface/UI changes: syntax, type conversion, expression evaluation, display information
[ ] Parameter changes: default values, similar parameters but with different default values
[ ] Policy changes: use new policy to replace old one, functionality automatically enabled
[ ] Feature removed
[ ] Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

[ ] This is a backport pr

Bugfix cherry-pick branch check:

[x] I have checked the version labels which the pr will be auto-backported to the target branch

[x] 3.3
[ ] 3.2
[ ] 3.1
[ ] 3.0
[ ] 2.5

@Mergifyio backport branch-3.3


Add validate contact form

⭐in this branch we:

⭐When the user submits the form, we check if the email is in lowercase.

If the validation is OK✅, the form is sent.
If the validation is not OK❌, we show an error message to the user informing him that the form is not sent.

@frank1738 Thank you so much for your efforts in reviewing my code.


[Bufferization]: one-shot bufferization illegal

In classTritonScatteredStoreOpConversion, funcmatchAndRewrite

bufferization::ToTensorOp not set restrict and writable, after convert to linalg mlir, this bufferization.to_tensor Op is illegal when using one-shot bufferization.
Wonder why ScatteredLoadOp has the restric and writable attribute but ScatteredStoreOp hasn't ?

这个应该是两个true的，这样改没问题，我这边确认一下，之后会提一个pr修复这个问题

https://github.com/Cambricon/triton-linalg/pull/10
修复已经提交RP，感谢反馈。


Critical omission in the password hash sync process when Azure AD Domain Services feature is enabled

When Azure AD Domain Services feature is enabled, in addition to the regular password hash sync process documented here which sends a one way SHA256 hash of the onprem MD4 hash, the original MD4 hash is also sent to Azure AD (encrypted with reversible encryption).  This needs to be documented. And in the light of this, the whole "Security considerations" sections need to be rewritten.

Document details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: c900f942-4456-5238-9f4c-a7a5bd685c04
Version Independent ID: a5d7d971-765f-0977-f531-232ea5924121
Content: Implement password hash synchronization with Azure AD Connect sync
Content Source: articles/active-directory/hybrid/how-to-connect-password-hash-synchronization.md
Service: active-directory
GitHub Login: @billmath
Microsoft Alias: billmath

@NileshGhodekar thanks for the feedback! I have assigned this to the content author @billmath to look into.

@NileshGhodekar Hey Nilesh, do you or anyone else have any documentation or blogs about the MD4 hash synced with encrypted with reversible encryption?  If not, how was this discovered?

@alexdlevin, this has been publicly documented in the AAD DS documentation, just not in this article. See: https://docs.microsoft.com/en-us/azure/active-directory-domain-services/active-directory-ds-synchronization#password-hash-synchronization-and-security-considerations


Tesla.Multipart.assert_part_value! doesn't allow valid stream

  @spec assert_part_value!(any) :: :ok | no_return
  defp assert_part_value!(%maybe_stream{})
       when maybe_stream in [IO.Stream, File.Stream, Stream],
       do: :ok

The assert_part_value! function checks if the argument is a stream, but it only allows a subset of the valid streams. There is no restriction on what data type could be used to represent a stream
iex(1)> enum = 1001..9999
iex(2)> n = 3
iex(3)> stream = Stream.transform(1001..9999, 0, fn i, acc ->
...(3)>   if acc < n, do: {[i], acc + 1}, else: {:halt, acc}
...(3)> end)
#Function<60.29975488/2 in Stream.transform/3>

In the example above, stream is represented via a function. https://elixirforum.com/t/how-to-check-if-an-argument-is-a-stream-or-stream-like-function/50622

@teamon focusing on other stuff right now, I haven't touch anything related to streaming, any thoughts here?

I see two options here: allow functions in assert_part_value or... remove the validation. We probably should do the former first.


Is this repo the same as the Entities in the unity package manager？

The status of the entities in the unity package manager is the preview, do I install the unity entities directly or git clone here

No, that's Unity ECS in unity package manager. Completely different package.
If you want Entitas check releases

Thank you for your reply , And do you know which of the two frameworks has better performance
@c0ffeeartc

Unity ECS has best performance over every other ECS framework used within Unity, also it’s one of the hardest to learn and use

@c0ffeeartc
Thank you ， And I am looking for a server-side framework now. Can you give me some suggestions ，for example, photon

@c0ffeeartc
Thank you ， And I am looking for a server-side framework now. Can you give me some suggestions ，for example, photon

Can't, maybe someone else can.

@c0ffeeartc
OK ， Thank you for your help


ollama: 0.1.31 -> 0.1.38

Description of changes
Ollama's rocm build was broken in more recent ollama releases, but this has now been (at least partially) fixed by adding rocmPath to the wrapper's LD_LIBRARY_PATH to allow runtime detection, adding a patch to disable a check that exits compilation early, and enabling tensileSepArch and tensileLazyLib for rocblas. These fixes were discovered thanks to @volfyd in discussions on pr #309330.
Testing of the new version with acceleration = "rocm"; enabled is highly appreciated. The following command should be able to build it when run in the root of the nixpkgs repository.
nix-build --expr '(import ./. {}).ollama.override { acceleration = "rocm"; }'

Tinydolphin is a small model that can download quickly, if you don't already have any models.
./result/bin/ollama serve &>./ollama-debug.log &
./result/bin/ollama run tinydolphin && kill %%

Kill works differently in fish:
./result/bin/ollama serve &>./ollama-debug.log &
./result/bin/ollama run tinydolphin && kill (jobs -lg)

Due to uncertainty about the completeness of this fix, this won't be merged until after the next stable release, which should be soon (see #303285).
Changelog

v0.1.32
v0.1.33
v0.1.34
v0.1.35
v0.1.36
v0.1.37
v0.1.38

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

I think we can safely ignore aarch64-darwin, it's definitely too long and counter productive. Let's merge it, @abysssol go for it!

@drupol Since I'm not entirely confident that 0.1.38 will have complete compatibility with 0.1.31 as far as rocm is concerned (some specific gpus could possibly lose support, for example), I was planning to wait until after the stable release of nixos 24.05, to prevent the possibility of a breaking change getting into 24.05. This should only take a few days, as according to #303285 the release-24.05 branch is planned to be created on 2024-05-22, and new merges into master won't get into 24.05 after that, if my understanding is correct.
If you think I specifically should try to get this pr into the next stable release, could you explain your reasoning? I'm not particularly comfortable with the possibility of merging a breaking change into the next stable release at the last moment, even if it's relatively unlikely. Since this isn't a particularly urgent change, it seems perfectly reasonable to wait a few days and merge it into the next unstable, where breaking changes are more tolerable. And now that I've gotten committer privileges, I won't have to bother you to actually merge it when I think it's ready, since I have your approval. It can always be backported later, maybe after a month with no issues?

If this PR might introduce issues, then it's indeed better to wait, no worries.

With the current version of Ollama it's broken already for me, doesn't do any VRAM allocation or anything. It worked before, but doesn't now for some reason. It's just like that for some reason seemingly though, it will work one moment then not the next. It at least builds though

@nonetrix How long has it been having these problems, if you remember? I believe the last change to the ollama package was made in  #303708, which has been more than five weeks now. Do you know if that worked at release or not? I just tested 0.1.31 and also found that it doesn't use my gpu, claiming it to be unsupported. I wonder if I never tested 0.1.31 properly, or if some change to rocblas could have caused a transitive change in ollama's behavior.
@drupol do you think it's worth merging now despite the possibility of a problem? since it seems likely that this could fix existing issues with the current version of ollama, which I hadn't considered, and may be more widespread than I realized. I'm no longer entirely confident in my lack of confidence.

IMHO, yes I would merge this.

Got the update, working great for me so far GPU and all! 0.1.39 would be nice soon though, phi3 medium is broken because llama cpp version is not updated yet


Lua error opening Fishing Journal

With 17.3.2 I got the following error when opening the Fishing Journal. It doesn't happen on every character nor did it happen the second time on this character. See issue #385 for a possible fix.
I'm not sure why Craftsim is even involved with the Fishing Journal (or the Herbalism Journal).
1x CraftSim/Classes/ProfessionData.lua:44: bad argument #1 to 'pairs' (table expected, got nil)
[string "=[C]"]: in function `pairs'
[string "@CraftSim/Classes/ProfessionData.lua"]:44: in function `new'
[string "@CraftSim/Libs/classic.lua"]:64: in function `ProfessionData'
[string "@CraftSim/Classes/RecipeData.lua"]:69: in function `new'
[string "@CraftSim/Libs/classic.lua"]:64: in function `RecipeData'
[string "@CraftSim/Init/Init.lua"]:532: in function `TriggerModulesByRecipeType'
[string "@CraftSim/Init/Init.lua"]:85: in function <CraftSim/Init/Init.lua:83>
[string "@CraftSim/Libs/GUTIL/GUTIL.lua"]:605: in function `checkCondition'
[string "@CraftSim/Libs/GUTIL/GUTIL.lua"]:611: in function `WaitFor'
[string "@CraftSim/Init/Init.lua"]:74: in function `TriggerModuleUpdate'
[string "@CraftSim/Init/Init.lua"]:126: in function <CraftSim/Init/Init.lua:106>
[string "=[C]"]: ?
...
[string "@Ace3/CallbackHandler-1.0-8/CallbackHandler-1.0.lua"]:19: in function <...Ons/Ace3/CallbackHandler-1.0/CallbackHandler-1.0.lua:15>
[string "@Ace3/CallbackHandler-1.0-8/CallbackHandler-1.0.lua"]:54: in function `Fire'
[string "@Ace3/AceEvent-3.0-4/AceEvent-3.0.lua"]:120: in function <Ace3/AceEvent-3.0/AceEvent-3.0.lua:119>
[string "=[C]"]: in function `UseAction'
[string "@Blizzard_FrameXML/Mainline/SecureTemplates.lua"]:342: in function `handler'
[string "@Blizzard_FrameXML/Mainline/SecureTemplates.lua"]:667: in function <...ddOns/Blizzard_FrameXML/Mainline/SecureTemplates.lua:649>
[string "@Blizzard_FrameXML/Mainline/SecureTemplates.lua"]:681: in function <...ddOns/Blizzard_FrameXML/Mainline/SecureTemplates.lua:674>
[string "@Blizzard_FrameXML/Mainline/SecureTemplates.lua"]:723: in function `SecureActionButton_OnClick'
[string "@Blizzard_ActionBar/Mainline/ActionButton.lua"]:1438: in function <Blizzard_ActionBar/Mainline/ActionButton.lua:1408>
[string "=[C]"]: ?

Locals:
(*temporary) = nil
(*temporary) = "table expected, got nil"

its involved cause the ui is the same as the crafting professions, just the content is different

Hello,
Can't reproduce.
No error pop when i open the fishing journal
I recently cleaned all cache, maybe it's actually solved with a fresh install ?

also cannot reproduce


Update PlatformAgnostic case conversion functions to allow expanding-length strings

Fixes #421
Fixes #4526
Also fixes a previously untracked? bug where String.prototype.toLocale{Upper|Lower}Case.call(null) would print "null" rather than throwing a TypeError.

@dilijev Unless you feel particularly strongly about it, I feel like I should leave the message issues in the Unicode test as is and open a bug to regenerate that test for Unicode 10 soon.

@jackhorton that's fine if there's a test to track. Keeping in mind the test is a bit misleading at the moment (especially if something fails could cause confusion).
We both have Unicode 10 update work to do :P


Setting: Set mor than one profile as startup profile

Description of the new feature/enhancement
Please add a feature to open wt with more than one tab. There should be a setting to enable this and a setting to configure the tabs/profile.
Proposed technical implementation details (optional)
[X] Start wt with more tha one tab
[PowerShell; CMD] *
*) This should be an input control. One entry (comma separated) per tab. The first entry is for the first and per default shown tab.

@htcfreek - "startupActions" allow you to do this today. Unfortunately they are not exposed in the settings UI yet, but you can add them to the config file, e.g.,
"startupActions": "new-tab -p \"Git Bash\" --title Git --tabColor #641220; new-tab -p \"Windows PowerShell\" --title Posh --tabColor #15616d; focus-tab -n 0"

I think this should be added to settings ui for easier configuration.

@htcfreek  - I absolutely agree. We even have a PR for it here: https://github.com/microsoft/terminal/pull/8812.
But it is blocked as we want to show more information about what will be executed, but it requires some additional refactor

@Don-Vito Feel free to close this as duplicate of #8802.

I love the smell of closing duplicates in the morning. Thanks all!
/dup #8802
/dup #756


App.jsx  has too much goin on, delete everything or move to appropriate component

This was corrected in #45 issue


Add live editor

Issue #110

Demo here - http://www.naseer.in/mermaid/live_editor/

Merged! Thanks for your effort. Will add page on doc site. Will probably happen this weekend.

:+1:   Thanks - I see it already at http://knsv.github.io/mermaid/live_editor/


failed building

Here are part of the error message.
   Compiling evm_in_risc0_methods v0.1.0 (/EvmInRisc0/methods)
evm-in-risc0-guest: Starting build for riscv32im-risc0-zkvm-elfmethods(build)
evm-in-risc0-guest: error: failed to load manifest for workspace member `/EvmInRisc0/target/debug/build/evm_in_risc0_methods-3b12ab65e5b8ce5e/out/rust-std_fef9a51671a1d244698e454d21cf59182a5e4db9b13814d43c005ab9cea20381/library/sysroot`
evm-in-risc0-guest:
evm-in-risc0-guest: Caused by:
evm-in-risc0-guest:   failed to read `/EvmInRisc0/target/debug/build/evm_in_risc0_methods-3b12ab65e5b8ce5e/out/rust-std_fef9a51671a1d244698e454d21cf59182a5e4db9b13814d43c005ab9cea20381/library/sysroot/Cargo.toml`
evm-in-risc0-guest:
evm-in-risc0-guest: Caused by:
evm-in-risc0-guest:   No such file or directory (os error 2)

I narrowed the error to
'sysroot/Cargo.toml' does not exists at 'rust-std'

For reproducing the error, here is the repository.

This line is incompatbile with risc0-zkvm = 0.15:
risc0-zkvm-guest = "0.11.1"

To get the guest functionality, use this line:
risc0-zkvm = { version = 0.15, default-features = false, features = ["std"] }

Or remove the std feature if you don't need or want to use the rust stdlib.

@flaub Thank you, I changed the risc0-zkvm.
But it still has the same error.

@wangtsiao it appears your missing the rust-toolchain.toml (example: https://github.com/risc0/risc0/blob/main/templates/rust-starter/rust-toolchain) file in the root which might be causing some of the issue. I highly recommend using the cargo-risczero tool: https://crates.io/crates/cargo-risczero to generate new projects because it will setup all the packages / rust correctly.

@wangtsiao it appears you're missing the rust-toolchain.toml (example: https://github.com/risc0/risc0/blob/main/templates/rust-starter/rust-toolchain) file in the root which might be causing some of the issue. I highly recommend using the cargo-risczero tool: https://crates.io/crates/cargo-risczero to generate new projects because it will setup all the packages / rust correctly.

Thank you, I recreate the project with cargo-risczero, but it didn't go well and still didn't compile successfully. Here is the new error
error[E0432]: unresolved imports `risc0_zkvm::Executor`, `risc0_zkvm::ExecutorEnv`
 --> host/src/main.rs:6:5
  |
6 |     Executor, ExecutorEnv,
  |     ^^^^^^^^  ^^^^^^^^^^^ no `ExecutorEnv` in the root
  |     |
  |     no `Executor` in the root

here is the new repository.

The host side needs to have the prove feature enabled, so you can use this on the host side:
risc0-zkvm = "0.15"


feat: [input] add switch showPassword

add props showPassword, view password
 closed

@BeiQiaoT Can someone review this PR? If it's accepted, I will update docs too


Add a license-checking job

This uses https://github.com/uw-labs/lichen, which is closer to our
requirements for CNCF validation than
https://github.com/mitchellh/golicense and performs validation using
local information.
The references for the Allowlist and the approved exceptions are
described in the lichen configuration file.
Fixes: #801
Signed-off-by: Stephen Kitt<EMAIL_ADDRESS>

The tool and PR overall look great, ACK to your self-review -1 for now.


Desgin: Run service flow

Review the current flow of running a Prem Service in a way we can add more configurations such as entering the domain name r DNS provider, destination (localhost, remote), and machine resources.

@tiero Infrastucture stepper suggestion

Destination
Both are possible where we switch to remote only when necessary?
Localhost
Localhost + Remote
Remote

Infrastructure location
Localhost

Prefilled with localhost settings
Own infrastructure
Domain name
DNS provider (can you explain why?)
Prem Cloud
Prefilled with Prem Cloud settings
API key

Machine resources
Localhost

Pull system stats
Own infrastructure
Prem Cloud
Set number of Kubernetes pods / CPUs / GPUs
Max Memory
Disk space

Should the stepper be displayed after selecting a model?
Each model can run on different infrastucture?


support class cache for ByteBuddy

Please answer these questions before submitting pull request

Why submit this pull request?

[ ] Bug fix

[x] New feature provided

[ ] Improve performance

Related issues
when use skywalking agent ,arthas is can‘t work well
https://github.com/apache/skywalking/issues/4820
[Question] How to advice a class that have been intercepted by another javaagent but not loaded
https://github.com/raphw/byte-buddy/issues/829

Bug fix

Bug description.

How to fix?

New feature or improvement

Describe the details and related test reports.
ByteBuddy generates auxiliary classes with different random names every time. When other javaagent executes retransform, it will trigger the SkyWalking agent to enhance the class again. The bytecode regenerated by ByteBuddy is changed, the fields and imports are modified, and the retransform fails.
Support class cache for ByteBuddy, solve the problem of other javaagent retransform classes enhanced by SkyWalking.
https://github.com/hengyunabc/skywalking-error-demo test pass.

Because we plan to release 8.0.0 in next week, this PR will be hold until the release done. @apache/matt-committers Feel free to review but don't merge this into master(8.0.0) to keep the next release agent stable.

Because we plan to release 8.0.0 in next week, this PR will be hold until the release done. @apache/matt-committers Feel free to review but don't merge this into master(8.0.0) to keep the next release agent stable.

Seems you mention the wrong team 🤣

Yes, haha.

And this change should be tested through the plugin test tool. Please take a look at plugin development doc and test requirement. You could open this config(default is off), and run the original failure case. This is a very important way for SkyWalking to improve how the PR works, and it is successful.

The testcase for class cache feature has been submitted.
SkyWalking's testing tools is great, but there are still some problems in getting started, and writing expectedData.yaml requires skills.
Open the --debug option when running the plug-in test first, and then extract the data from logs/validatolr.out

and writing expectedData.yaml requires skills.

Any test requires skills and time. And the point is, we could run them automatically and tested in future changes. In the OSS, we can't afford to run thousands of tests every time when we try to merge or release something. The great and stability you are feeling are 200+ contributors use their time to work on automatic tests.
I have to ask you to add this. This thing is required for all agent side changes. This one is not hard, you just need to copy one cast from Spring(bootstrap classloader) and another from Tomcat(container classloader), open the config, active the Arthas(or some tools you feel important to test) and make sure the cases passed.  Expected data files are there, we don't require you to create cases, but you should test the things you mentioned and fixed.

but there are still some problems in getting started

We could talk about the issue, or you could send a pull request to fix or improve them. It was being used in the main repo for 800+ plugins tests, and repo is here, https://github.com/apache/skywalking-agent-test-tool.

I can add a practical guide to writing a plugin testcase for beginners. The content of Plugin-test.md is more detailed, and it can’t catch the main points for beginners.

I can add a practical guide to writing a plugin testcase for beginners. The content of Plugin-test.md is more detailed, and it can’t catch the main points for beginners.

You could do this if you think the doc could be better. But basically, for this pull request, we require the tests, more than the unit tests..

Question, have you added your test case in the GitHub Action control file? I don't find it.

I found several plugin-test-*.yaml, which file is added to?

I found several plugin-test-*.yaml, which file is added to?

Any, maybe one has shortest list.

What do the numbers in case title mean?

How many versions, such as in Spring MVC cases, 10+ versions should be tests. In your case, I think only one for each case? (Spring boot and Tomcat)

How many versions, such as in Spring MVC cases, 10+ versions should be tests. In your case, I think only one for each case? (Spring boot and Tomcat)

Do I need to add another tomcat-container testcase?

The CI is failing, because your comments are illegal in javadoc, please check the logs, or check locally.

Do I need to add another tomcat-container testcase?

Yes, you should, because it is another ClassLoader scenario.

Any update?

Any update?

I will submit some code on the weekend.

@kylixs Could you finish this currently?

You have code conflict, please fix.

There are Java-Doc error (not warning) in your codes.

There are Java-Doc error (not warning) in your codes.

where is the javadoc error? I build agent successful on my macOS.

CI error logs show that. Your local mvn package doesn't include Javadoc. I think you should trymvn javadoc:javadoc?

CI error logs show that. Your local mvn package doesn't include Javadoc. I think you should trymvn javadoc:javadoc?

javadoc error is not easy to locate, too much disturbing warn information.
Local build command:   ./mvnw package javadoc:javadoc -Pagent,dist -DskipTests=true

Thank you for your patience. It has been a month. Welcome to join the contributor team.

@wu-sheng  If other agent do not enhance the class during the first load (transform), the class will be enhanced during the second transform. Then skywalking directly returns the byte stream cached for the first time in the second time, will it overwrite the content enhanced for the second time by other agents? Because the order in which the transform is executed depends on the order in which the Agent is configured.

@wu-sheng If other agent do not enhance the class during the first load (transform), the class will be enhanced during the second transform. Then skywalking directly returns the byte stream cached for the first time in the second time, will it overwrite the content enhanced for the second time by other agents? Because the order in which the transform is executed depends on the order in which the Agent is configured.

I think this feature (class cache) only solve the conflict of  skywalking and other agent which do not modify the origin class logic. If we use other agent to enable hotswap, it will not work well.

@wu-sheng If other agent do not enhance the class during the first load (transform), the class will be enhanced during the second transform. Then skywalking directly returns the byte stream cached for the first time in the second time, will it overwrite the content enhanced for the second time by other agents? Because the order in which the transform is executed depends on the order in which the Agent is configured.

I think this feature (class cache) only solve the conflict of skywalking and other agent which do not modify the origin class logic. If we use other agent to enable hotswap, it will not work well.

Class cache is not a perfect solution. This can be a problem if another agent loads before the Skywalking agent. When retransform the same class a second time, the result of the first retransform is used. Cause the agent Retransform result before Skywalking to be overwritten. Functions such as hot-loading class will not be available.
This problem can be completely solved by improving ByteBuddy or replacing bytecode tools such as Arthas's ByteKit. I want to do something for it, it might take a while.

Great!  I still hava a question:  Hotswap by redefine(or retransform) just reload class definition(the latest version) without initialization，while class enhanced by skywalking dependy on static block。By improving ByteBuddy can solve this question?

@wu-sheng If other agent do not enhance the class during the first load (transform), the class will be enhanced during the second transform. Then skywalking directly returns the byte stream cached for the first time in the second time, will it overwrite the content enhanced for the second time by other agents? Because the order in which the transform is executed depends on the order in which the Agent is configured.

I think this feature (class cache) only solve the conflict of skywalking and other agent which do not modify the origin class logic. If we use other agent to enable hotswap, it will not work well.

Class cache is not a perfect solution. This can be a problem if another agent loads before the Skywalking agent. When retransform the same class a second time, the result of the first retransform is used. Cause the agent Retransform result before Skywalking to be overwritten. Functions such as hot-loading class will not be available. This problem can be completely solved by improving ByteBuddy or replacing bytecode tools such as Arthas's ByteKit. I want to do something for it, it might take a while.

Great! I still hava a question: Hotswap by redefine(or retransform) just reload class definition(the latest version) without initialization，while class enhanced by skywalking dependy on static block。By improving ByteBuddy can solve this question?


Tutorial in readme

Hi everyone. Still not sure if i can handle the recursion topic though but here is the most of the library tutorial (i guess).
Also something strange happens in diff section. It says index.md is binary. Is it ok?

Hey, thanks for the PR but it looks like maybe you forgot to add some files. I only see removed content, am I missing something?

I am confused too. I was editing index.md but git says it is binary. I can see the proper diff with --text flag:
$ git diff main change_readme --text

diff --git a/.gitignore b/.gitignore
index d55f078..7504387 100644
--- a/.gitignore
+++ b/.gitignore
@@ -32,3 +32,6 @@ TAGS
 .metals
 .bloop
 .bsp
+project/metals.sbt
+project/project/metals.sbt
+project/project/project/metals.sbt

diff --git a/docs/src/index.md b/docs/src/index.md
index 36eb3c6..7c7ea70 100644
--- a/docs/src/index.md
+++ b/docs/src/index.md
@@ -27,7 +27,271 @@ this library has a few goals:
 5. Safety: by separating Parser0, a parser that may consume no input, from Parser, a parser must consume at least one character on success. Most combinators and methods can be made safer to use and less prone to runtime errors.
 6. Stability: we are very reluctant to break compatibility between versions. We want to put a minimal tax on users to stay on the latest versions.

-# An Example
+# Tutorial
+
+## Simple parser
+
+The library provides a set of simple parsers which might be combined to create any parsing logic. The simplest parser is `Parser.anyChar` which is successful where there is one char at the input. It has type `Parser[Char]` which means it returns one parsed char.

...

+So when the *right side* throws an error the `soft` method allows us to rewind parsed input and try to proceed it's parsing with next parsers (without changing the parser itself!).
+
+
+# JSON parser example
 Below is most of a json parser (the string unescaping is elided). This example can give you a feel
 for what it is like to use this library.

Oh i got it, i've inserted some EOL (or something) from the Metals console. I'll make another PR


Feature: Add names of joints to plot.

Hello! I recently needed to make some calculations for a four-bar linkage and I found your package extremely useful! While using it I came up with a few more things that may  make the package even better.
I've added option show_joint_names to function get_animation in Mechanism class. When set to True, it adds names of each joint to the plot using Matplotlib.axes.Axes.text.
It makes easier to mention specific part of a mechanism. For example it might be useful in tests like ones in folder tests/mechanism.
Here is an example:

I like it! I think I'll make a few minor changes in the next commit. Thank you for your contribution!


What’s currency?

Hello mate.
Tell me pls, what kind of currencies do you support?
Bitcoin = BTC
BitcoinCash = BCH or BCC
Litecoin = LTC
Dash = DASH
Dogecoin = DOGE
Is this correct? What else?
Thank you for support.

Hi
I've tested it on BTC, DOGE, DSH, LTC, ZEC
It should work fine with other coin based on bitcoin software, but no guarantees

Oh, cool. So how I can connect related and additional blockchains to the Django-cc?

Download bitcoind, install it, edit bitcoin.conf, enable server mode, add rpc login and password. Make sure it's working
Create django app, install django-cc. In django admin add Currency. In conncecion string fill in
http://rpclogin:rcppassword@localhost:8332/
After that you should be able to create cc.models.Wallet instance and send-recieve funds.
Also you need to run celery to periodically ask for new transactions from bitcond

About Bitcoin NO QUESTIONS. Questions are for LTC, for example.
Thank you.

No difference for BTC or LTC


create Iron release

preconditions (feature requests)

[x] parameter service cli https://github.com/ros2/rclc/pull/358
[x] multi-threaded executor API interface https://github.com/ros2/rclc/pull/355

release creation:

[x] create rolling branch
[x] create iron branch
[x] update Github branch configuration for rolling
[x] update Github branch configuration for iron
[x] update ros-tooling versions (setup-ros 0.6.2 and ros-action 0.3.2)

[x] master https://github.com/ros2/rclc/pull/361
[x] rolling https://github.com/ros2/rclc/pull/359
[x] iron https://github.com/ros2/rclc/pull/360
[x] humble https://github.com/ros2/rclc/pull/364
[x] foxy https://github.com/ros2/rclc/pull/365

[x] update release notes
[x] tag branch; version 5.0.1
[x] bloom release Iron PR: https://github.com/ros/rosdistro/pull/37664
[x] bloom release Rolling: https://github.com/ros/rosdistro/pull/37675
[x] create release on github
[x] set rolling as the default branch
[x] depricate master branch
[x] README: update CI-status table for iron

Iron release finished.


CALL-GIRL IN CHANDIGARH [96715'3'6'5'2'6]❤LOW COST DOORSTEP HIGH-PROFILE CALL NOW.. .. ⭐Booking opan⭐Now

New Issue Checklist
CALL-GIRL IN CHANDIGARH [96715'3'6'5'2'6]❤LOW COST DOORSTEP HIGH-PROFILE CALL NOW.. .. ⭐Booking opan⭐NowCALL-GIRL IN CHANDIGARH [96715'3'6'5'2'6]❤LOW COST DOORSTEP HIGH-PROFILE CALL NOW.. .. ⭐Booking opan⭐NowCALL-GIRL IN CHANDIGARH [96715'3'6'5'2'6]❤LOW COST DOORSTEP HIGH-PROFILE CALL NOW.. .. ⭐Booking opan⭐NowCALL-GIRL IN CHANDIGARH [96715'3'6'5'2'6]❤LOW COST DOORSTEP HIGH-PROFILE CALL NOW.. .. ⭐Booking opan⭐NowCALL-GIRL IN CHANDIGARH [96715'3'6'5'2'6]❤LOW COST DOORSTEP HIGH-PROFILE CALL NOW.. .. ⭐Booking opan⭐NowCALL-GIRL IN CHANDIGARH [96715'3'6'5'2'6]❤LOW COST DOORSTEP HIGH-PROFILE CALL NOW.. .. ⭐Booking opan⭐NowCALL-GIRL IN CHANDIGARH [96715'3'6'5'2'6]❤LOW COST DOORSTEP HIGH-PROFILE CALL NOW.. .. ⭐Booking opan⭐NowCALL-GIRL IN CHANDIGARH [96715'3'6'5'2'6]❤LOW COST DOORSTEP HIGH-PROFILE CALL NOW.. .. ⭐Booking opan⭐NowCALL-GIRL IN CHANDIGARH [96715'3'6'5'2'6]❤LOW COST DOORSTEP HIGH-PROFILE CALL NOW.. .. ⭐Booking opan⭐NowCALL-GIRL IN CHANDIGARH [96715'3'6'5'2'6]❤LOW COST DOORSTEP HIGH-PROFILE CALL NOW.. .. ⭐Booking opan⭐NowCALL-GIRL IN CHANDIGARH [96715'3'6'5'2'6]❤LOW COST DOORSTEP HIGH-PROFILE CALL NOW.. .. ⭐Booking opan⭐NowCALL-GIRL IN CHANDIGARH [96715'3'6'5'2'6]❤LOW COST DOORSTEP HIGH-PROFILE CALL NOW.. .. ⭐Booking opan⭐NowCALL-GIRL IN CHANDIGARH [96715'3'6'5'2'6]❤LOW COST DOORSTEP HIGH-PROFILE CALL NOW.. .. ⭐Booking opan⭐NowCALL-GIRL IN CHANDIGARH [96715'3'6'5'2'6]❤LOW COST DOORSTEP HIGH-PROFILE CALL NOW.. .. ⭐Booking opan⭐NowCALL-GIRL IN CHANDIGARH [96715'3'6'5'2'6]❤LOW COST DOORSTEP HIGH-PROFILE CALL NOW.. .. ⭐Booking opan⭐NowCALL-GIRL IN CHANDIGARH [96715'3'6'5'2'6]❤LOW COST DOORSTEP HIGH-PROFILE CALL NOW.. .. ⭐Booking opan⭐NowCALL-GIRL IN CHANDIGARH [96715'3'6'5'2'6]❤LOW COST DOORSTEP HIGH-PROFILE CALL NOW.. .. ⭐Booking opan⭐Now

[ ] Updated fastlane to the latest version
[ ] I read the Contribution Guidelines
[ ] I read docs.fastlane.tools
[ ] I searched for existing GitHub issues

Issue Description

Command executed

Complete output when running fastlane, including the stack trace and command used

 [REPLACE THIS WITH YOUR INFORMATION]

Environment

 [REPLACE THIS WITH YOUR INFORMATION]

MY experience was superb with them this is the only recommended "Call "Girls 'service in 'Chandigarh with verified "Call "Girls . I am using their 'services from past 6 months they never ever disappointed me in any way. Let's just say if i asked them to provide me 'russian "Call "Girls they fulfilled my request or even 'Chandigarh  "Call "Girls or 'indian "Call "Girls in 'Chandigarh  . They have their owen drivers who brings the "Call "Girls in less time in any area of 'Chandigarh  like bur 'Chandigarh  'marina or 'Chandigarh or even in 'Chandigarh ali as well. I'm writing here everything after experience their 'services in all conditions.
I am always there to guide you and making things better. Whenever you actually wanted your relationship well, I am here to guide you to make everything better.


Question : How can i use slim with cakephp

Hi, I want to setup slim with CakePHP how can I do this, please explain.
I want to use slim for API.
Thanks,

I guess the better approach is to use each as different projects. You develop your API using SLIM, then you can consume it using your CakePHP project.

or just use CakePHP for everything.


LuaJIT(?)

Replacing the version of Lua we currently have (Lua 5.1 with lua-compat-5.2) with LuaJIT would be nice, seeing as that's the version LÖVE uses.
I have no idea if JIT compilation would work or not though.

Well, all I can see is from http://luajit.org/luajit.html that it's written in C like Lua (seemed to be obvious :v) but all we can do is try, right?

It's probably not possible because LuaJIT's interpreter is rewritten in assembly, but I will leave this open as a hopeful dream

@VideahGams you've attempted it over the past while, and might not be worth porting it ourselves atm. I'll close it for now, but if it manages to be done by someone else that'd be awesome.


Add frontend metrics for dashboards-notifications

Signed-off-by: David Cui<EMAIL_ADDRESS>Description

Adds new API /api/notifications/stats to collect usage, error and action metrics
Metrics details:

count: request count in the last minute
total: total request count since the server is up
user_error: 4xx error status code in the last minute
system_error: Non-4xx error status codes in the last minute

Sample output:
  config: {
    create: {
      count: 0,
      system_error: 0,
      user_error: 0,
      total: 0
    },
    delete: {
      count: 0,
      system_error: 0,
      user_error: 0,
      total: 0
    },
    info: {
      count: 0,
      system_error: 0,
      user_error: 0,
      total: 0
    },
    list: {
      count: 0,
      system_error: 0,
      user_error: 0,
      total: 0
    },
    update: {
      count: 0,
      system_error: 0,
      user_error: 0,
      total: 0
    }
  },
  event: {
    info: {
      count: 0,
      system_error: 0,
      user_error: 0,
      total: 0
    },
    list: {
      count: 0,
      system_error: 0,
      user_error: 0,
      total: 0
    },
  },
  feature: {
    list: {
      count: 0,
      system_error: 0,
      user_error: 0,
      total: 0
    },
  },
  send_test_message: {
    info: {
      count: 0,
      system_error: 0,
      user_error: 0,
      total: 0
    },
  },
  slack: {
    count: 0,
    system_error: 0,
    user_error: 0,
    total: 0
  },
  chime: {
    count: 0,
    system_error: 0,
    user_error: 0,
    total: 0
  },
  email: {
    count: 0,
    system_error: 0,
    user_error: 0,
    total: 0
  },
  custom_webhook: {
    count: 0,
    system_error: 0,
    user_error: 0,
    total: 0
  },
  ses: {
    count: 0,
    system_error: 0,
    user_error: 0,
    total: 0
  },
  sns: {
    count: 0,
    system_error: 0,
    user_error: 0,
    total: 0
  },
  smtp_account: {
    count: 0,
    system_error: 0,
    user_error: 0,
    total: 0
  },
  email_group: {
    count: 0,
    system_error: 0,
    user_error: 0,
    total: 0
  },
  reports: {
    count: 0,
    system_error: 0,
    user_error: 0,
    total: 0
  },
  alerting: {
    count: 0,
    system_error: 0,
    user_error: 0,
    total: 0
  },
  index_management: {
    count: 0,
    system_error: 0,
    user_error: 0,
    total: 0
  }

Check List

[x] New functionality includes testing.

[x] All tests pass, including unit test, integration test and doctest

[ ] New functionality has been documented.

[ ] New functionality has javadoc added
[ ] New functionality has user manual doc added

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Closing after consensus to not include front-end metrics


bump prom dependency.

ref: https://github.com/open-cluster-management/backlog/issues/18558
Signed-off-by: morvencao<EMAIL_ADDRESS>

Looks like we need to upgrade kustomize lib to v4.