HDDS-4207. Include version information in docs

What changes were proposed in this pull request?
Display version from POM in documentation footer.
If building in a git working copy, also display last commit date and hash, with link to GitHub.
https://issues.apache.org/jira/browse/HDDS-4207
How was this patch tested?
Built docs locally (mvn clean package in hadoop-hdds/docs), both in git repo and in hadoop-ozone-1.0.0-src.  See text on light gray background at the bottom in these screenshots:

Thanks @vivekratnavel for taking a look.

How do I see the version after "mvn clean package"?

open hadoop-hdds/docs/target/classes/docs/index.html if only built hadoop-hdds-docs
open hadoop-ozone/dist/target/ozone-1.1.0-SNAPSHOT/docs/index.html after full build

Thanks @adoroszlai! I also noticed one more thing. The footer does not stick at the bottom of the screen.
For pages with content that do not occupy the full screen, we see the footer with version immediately in the middle of the screen as shown in the screen-shot attached. We should either make this footer stick to the bottom of the screen always or we should this version information in a different space. One alternate space I can think of is the bottom of the left menu bar.

For pages with content that do not occupy the full screen, we see the footer with version immediately in the middle of the screen as shown in the screen-shot attached.

Thanks @vivekratnavel.  I tried, but don't know enough CSS to achieve this.  Can you give me some pointer or hint?

I referred to this post for sticky footer - https://css-tricks.com/couple-takes-sticky-footer/ and pushed a commit.
Please check and let me know how it looks.

I referred to this post for sticky footer - https://css-tricks.com/couple-takes-sticky-footer/ and pushed a commit.
Please check and let me know how it looks.

Thank you very much @vivekratnavel.  It looks great on both long and short pages.

Thanks @vivekratnavel for the review and help with the sticky footer.


feat(POC): experiment defer offscreen images

POC for #30 - not intended to be merge
Experiment the gatsby image plugins.
Use the StaticImage component: as we define data url and title in data structure, this component doesn't fit our need. It is tested here with static image and hard coded path (404, "how_it_works" in model app page, ...)
Applying styles to the new image components hasn't been tested

Closing this POC as I am not going to work on it before while.


Use getOwnPropertyNames instead of keys

Even in ES2015, object key ordering is not specified when using Object.keys, or for-in. Object.getOwnPropertyNames, however, is guaranteed to be in-order.
See: http://stackoverflow.com/questions/30076219/does-es6-introduce-a-well-defined-order-of-enumeration-for-object-properties

Closed in 9d785018ba2f7260dd9b90e613a4c70f18a65d2d


Azure Monitor OpenTelemetry Exporter does not work in chrome

Package Name: @azure/monitor-opentelemetry-exporter
Package Version: 1.0.0-beta.14 (also tried 1.0.0-alpha.20230815.1)
Operating system: Windows
[ ] nodejs

version:

[x] browser

name/version: Chrome, 115.0.5790.173

[ ] typescript

version:

Is the bug related to documentation in

[x] README.md
[ ] source code documentation
[ ] SDK API docs on https://docs.microsoft.com

Describe the bug
When importing AzureMonitorTraceExporter from @azure/monitor-opentelemetry-exporter, I get this error in the browser:
Uncaught (in promise) ReferenceError: process is not defined
    at fileAccessControl.ts:10:35

To Reproduce
Steps to reproduce the behavior:

Import AzureMonitorTraceExporter in browser code

Expected behavior
I expect the error to not occur, as the README lists support for "Latest versions of Safari, Chrome, Edge, and Firefox."
Screenshots
N/A
Additional context
N/A

@dirthsj can you share how you're bundling the package for the browser (e.g. webpack, rollup) so we can confirm the fix?

I'm using sveltekit with adapter node. I imported AzureMonitorTraceExporter in src/hooks.client.ts.

@dirthsj apologies for the confusion in our README.  This scenario is currently not supported.  Closing as per #26889


Impossible to retrieve all users from account manager due to hardcoded page number

Hi,
I'm one of the administrators of an org with a large amount of users.
I'm currently in the process of extracting all of those users, crunching stats and hopefully making some cleanup, so I reached out to sfcc-ci since I'm using node.js to script.
However, whatever the max count I passed, I didn't manage to get all of my users, hitting a max cap of 4000. (yes, I have more than that. Hence the need to clean that up)
So, i briefly digged into the code and found this line, which is used in the case you're not passing either org or role to filter with (attempting to list all the users you can manage, including the invited ones):
var endpoint = '/users?page=0&size=' + size;
https://github.com/SalesforceCommerceCloud/sfcc-ci/blob/7eacb62016aa14e3ab1c0871370d2be5c0797815/lib/user.js#L249C48-L249C48
Looks like the page number is harcoded, assuming that whatever number sent out as the page size will be matched by the API.
However, by hitting the API directly (since I had to do that to complete my task anyway), I confirmed that there is a page size limit of 4000 entries. To fix that, code would need to be a bit more complex than it is, performing several requests and aggregating the users until requested count or end of last page is reached.
Regards,
Damien L.

Hi @dlebreuilly-loreal , thanks for reaching out. I can confirm, that the API has a max page size (which seems to be 4000 here). The CLI offers and option to page the list. Were you able to work with that?


MINOR: more logs for empty assignment

We find that brokers may send empty assignment for some members unexpectedly, and would need more logs investigating this issue.
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

@vvcephei @abbccdda

test this please

Cherry-picked to 2.5.


[enhancement]use GitHub action bot for fixing hash failure reports or other matters

description:
it would be nice for your repo/bucket to have a github actions bot, meaning this app, that automates hash-fix-needed(or other stuff, of course, it depends on use case), it can be implemented in two ways:
1- bot creates a pull request to be fixed manually by bucket maintainer or other trusted memebers: 456 at ACooper81 bucket
2- bot checks for actual hash of file and compares to the json of package and fixes the json accordingly, for example: 217 at anderlli0053/DEV-tools.
bot in action: same as number 2, but the actual commit for reference
thanks

@watashibeme
Thanks for the info, I'll add it as soon as I can.

No problem!


Rotation support

This is to support rotation. #15

[x] basic feature
[x] fix error in arrow/line bounds
[x] fix error with rotated lines/arrows when angle > Math.PI
[x] fix resizing with "w*" or "n*" leads elements moving.
[x] png export
[x] svg export

Some small remaining issues not addressed in this PR:

rotate cursor is "ew".
resize cursors don't change with rotation.
resize(Test|Handles) should be renamed because they are used for "rotation" now.

My initial focus is to render a rectangle with a fixed angle (= Math.PI / 4).

Thanks to @dwelle help, I've got this.

Hi. Thanks for working on this.
Some answers to your questions from twitter https://mobile.twitter.com/dai_shi/status/1243925468375429120:

Resizing is not intuitive. (How to fix rotated edges...)

Not sure what you mean by rotated edges?
If you meant why the width/height/position changes in weird ways during resize, it's likely due to normalization and stuff we do during resize in:
https://github.com/excalidraw/excalidraw/blob/aa54364bd687d6149ccc25098e465c835a07ca3e/src/components/App.tsx#L1935-L2110

Handler mouse pointers are not rotated. (Can be create arbitrary pointers with various angles?)

Native browser cursors can't be rotated AFAIK, so the best we can do is to hide it and replace it with a custom cursor: https://css-tricks.com/can-you-rotate-the-cursor-in-css/

Resizing is mostly done. I wonder if I should spend time on custom cursors or go on rotating rectangles.

I feel like the cursors are fine right now. I wouldn't spend too much time on that.

Found a bug when angle > Math.PI / 2. 🤔

naive rotation!

Tests are not running on drafts.. making it a PR.

So much for my experiments this weekend. Remaining:

Resize position is not very correct for "N", "W", and "NW".
Rotate handler is too naive.
Apply for non-rectangle shapes.

Anybody interested in investigating?

Interesting choice for the rotation handles! How do we feel about using this instead of the more usual method of adding an additional handle?

I just realized that I don't need to rotate on each elements but rotate before drawImag.

Not obvious and what about mobile?

It doesn't work on mobile yet. Rotation requires SHIFT at the moment. Any suggestion?

Something more classic? One idea is this:

Here you go!

Looking good! Will you tackle the text element in another PR?

@lipis Do you mean you will merge this PR before trying text elements? I'm OK with it.
Any idea how to pass the failing test? I'm using "rotation" handler as one of "resize" handlers, which may cause the test fails.

@lipis Do you mean you will merge this PR before trying text elements? I'm OK with it.

It would be nice to get the text elements as well, but it's up to you.. I'm OK with having it done in another PR.
As for the tests, I'm not sure what's going on. Let's wait for someone to check it out :)

@lipis Yay!

What about save/load..?

I assume it works out of the box. Yeah, looks like working.
{
  "type": "excalidraw",
  "version": 1,
  "source": "http://localhost:3000",
  "elements": [
    {
      "id": "Uh5zdFkKHGULieRRuZ7l5",
      "type": "rectangle",
      "x":<PHONE_NUMBER>5,
      "y":<PHONE_NUMBER>5,
      "width":<PHONE_NUMBER>5,
      "height": 62.62890625,
      "angle": 0.5833040710692037,
      "strokeColor": "#000000",
      "backgroundColor": "#ced4da",
      "fillStyle": "hachure",
      "strokeWidth": 1,
      "roughness": 1,
      "opacity": 100,
      "seed": 671820596,
      "version": 111,
      "versionNonce":<PHONE_NUMBER>,
      "isDeleted": false
    }
  ],
  "appState": {
    "viewBackgroundColor": "#ffffff"
  }
}

Amazing progress!
One problem I noticed you may be already aware of:
Upon rotation (esp more than 180deg), resizing doesn't keep position correctly (the element floats). For arrows it's even weirder (2nd part of the gif):

Rotation locking with SHIFT. We need to changed the instruction.

@dwelle Yeah, I'm aware of that. (> resizing with "w*" or "n*" leads elements moving.)
I spent much time but didn't get what's happening. Note "s","e","se" handlers are OK.
Didn't know the wired behavior with arrows. I need someone to help on it.

@dai-shi I can try to look at it, but don't have much time today/tomorrow.

It's working correctly now, for all features as far as I know.
Please find a bug!

Didn't know the wired behavior with arrows.

This is fixed. That was because of my lack of the understanding about canvasOffset.

Upon rotation (esp more than 180deg), resizing doesn't keep position correctly (the element floats).

This is not fixed. My workaround is noted as FIXME.

Yes, when resizing (from most of the points) it still moves the object around when rotated..

And, I found a bug. 😓

@lipis Which shape is it?

All of them.. the most weird one is the arrow/line of course

@lipis I'm not sure if what you observe is a known one or a new one... 😓

New or old, would be nice to tackle it though..

Why do the resize handles get so big? (Ideally, the handles would appear small but have large tap targets.

New or old, would be nice to tackle it though..

@lipis Hm, I probably don't understand your observation. Is it too hard for you to take a gif?

Why do the resize handles get so big? (Ideally, the handles would appear small but have large tap targets.

@j-f1 I didn't know that it's intentional. The problem was that the position of the rotation handler changes on mobile. Let me see what I can do.

The opposite side/corner should remain still.

Thanks for the gif!
Yeah, this is something I spent the most of my development time so far without success. I will try it again, but maybe I'm falling into a hole, so I wish someone take a look with fresh eyes.
Just a note: "E", "N", "NE" handlers are working fine, all other 5 resize handlers are problematic.

No need for the message about the SHIFT key modifier on mobile imo

Hi @dai-shi I implemented svg shapes rotation for a similar tool last year. It was implemented using Vue.js but the concept should be the same. If you want, I can send you the code so that you can take a look at it.

@mochetts Looks cool. It renders with SVG in browser, right? Cursor pointers are nice.

I’m not sure this is necessary or even a good idea but it might be useful to allow rotating on touchscreens by rotating with two fingers.

In my experience it works well for large surfaces like wall screens or big tables. But for small surface like phones, your two fingers are basically on-top of the element and you can’t see anything.
But it’s worth playing around

@dai-shi yes! It renders svg. 🙂

The tricky part with touch rotate is if you want to support both pinch zoom and two-finger rotate, one should be able to do both before touchup happens. I have seen it work well for things like story creation in snpachat/instagram. (Tough for small shapes)

Upon rotation (esp more than 180deg), resizing doesn't keep position correctly (the element floats).

@dwelle @lipis It's fixed now!!!

Still floating a bit with curved line/arrow...

Curved lines and arrows, were floating on production anyway... and they don't go to negatives there.

What happened to the circle for rotation..?

The rotation handle on text element is not there.

Sorry, broke with refactoring. Fixed with the latest commit.
And, all set!

Do we want to rotate the handles? It looks like Figma does but Keynote doesn’t. Also I know I’m the person who asked for the rotation handle in the first place and still think it’s a good idea but I checked Keynote and Figma and they both support Cmd+drag on any of the handles to rotate, and Figma has an invisible area outside of each handle that you can drag to rotate. Maybe we should add some of these now or in the future?

I like the rotation handle for mobile benefits.   I also wanted to add that the tool I previously used for drawing FBD's was Google Drawings and this is what theirs looks like:

Also note it shows you the rotation angle which is helpful

I would say in the future.. I like the current behaviour! We can improve as we go.

Amazing work @dai-shi. I've pushed 2 minor commits:

ensure we migrate old scene elements correctly by initializing angle to 0
rotate wysiwyg editor:

I'm still reviewing the rest, but so far I don't see anything else.

Doesn't lock on the left side :)

I can repro. To elaborate: it skips the 270° almost all the time (though if you're really precise, it locks).

Fixed via a hideous hack IMO.. anyone feel free to swap it with something better :).

Oh, nice catch. Let me try to find a better way.
8c38d91 Fixed with an improvement.

It feels like if we wait a bit longer we can shave a few more lines and optimize it more.. it will be easier to maintain later, while this topic is still hot.
P.S. @dai-shi you've done some amazing work!

There're some repeated patterns around rotateHandlerCoords, so there's probably room for improvement.
Other than that, it would require big refactoring for optimization, which is out of the scope of this PR, I think.

If you think of something go ahead.. we can merge this tomorrow. Let us know when you feel it's done.

Slightly improved, and the diff is cleaner.
@lipis I'm done. Please go head and merge it!

Do we want to rotate the handles?

@j-f1 We don't need to. I think it looks nicer with rotated handles in our case. Note resizeTest uses unrotated handles anyway, so it's just how it looks.

Stellar job @dai-shi! :tada: :rocket: :tada:

Is it possible to rotate the canvas? I’ve been trying on iPadOS because it’d make aligning things SO much less tedious.


[WIP] implement binary trie

the goal of this PR are:

implement working binary trie
good test coverage for binary trie and it's components
decent documentation of it's API and internal workings

You've probably already noticed that the existing code in ./ethereum_trie was translated from Python with https://github.com/metacraft-labs/py2nim.
Feel free to remove anything that is no longer useful. For the hexary trie, I ended up throwing away most of the translated code and created a new implementation.

TODO list:
[ ] replace keccak_tiny with NimCrypto, edit nimble file
[ ] replace encodeToBin with bit-vector-something
[ ] implicit generic style
[ ] combine encodeKVNode allocation to single alloc
[ ] use db accessor template
[x] remove equality operator
[ ] add random test for nodes utils + nim-quicktest
[ ] write binary trie test + nim-quicktest
[ ] write branch utils
[ ] write branch utils test
[ ] polish doc
[ ] add api doc
[ ] add example doc
[ ] source code file reorganization
[ ] optimization

For the BitVector, you can either go with helper accessors (perhaps that's enough) or you can implement something like the NibblesRange used in the hexary trie:
https://github.com/status-im/nim-trie/blob/3fc5dcc67c2b7cfdf6ec9b9772da9da0e50cd5e7/ethereum_trie/nibbles.nim
Please note that the BytesRange objects are cheap to copy, because they store an underlying shallow sequence (so copying touches only one pointer and two ints).

Merged into master, so I can start fixing the hexary trie code. You can keep pushing commits here until the feature is completely ready.


Build python versions with --with-pydebug flag / [Py_DEBUG]

With the possibility to get Python builds from this Repositories Github Releases I wanted to propose to build these releases with --with-pydebug flag (Explanation:  [Py_DEBUG])
Regarding these comments/PR:
https://github.com/actions/setup-python/pull/85
https://github.com/actions/virtual-environments/issues/786#issuecomment-620467793

Hey @simonsan
I'm going to close this issue here and we'll track the original request in: https://github.com/actions/setup-python/issues/86
We've decided to lock issue creation in this issue and we'll be tracking everything in actions/setup-python or actions/virtual-environments (easier to maintain and track python issues in 2 repos vs 3).
Sorry for the back and forth, this repo is pretty new and we're still working on deciding how we want to organize everything moving forward.

Ok 👍


Unhandled rejection undefined raised when testing an extesion

VS Code Version: 1.62.3
OS Version: macOS Big Sur 11.6

I'm developing a vscode extension and I notice that in some situations an unhandled rejection with undefined error is raised.
This exception always is raised if:

a document is opened (workspace.openTextDocument)
and wait for a few seconds (eg: 10 seconds) before finishing a test

describe('example', () => {
  it('it will fail', async () => {
    await workspace.openTextDocument('/Users/macabeus/foo/index.js')
    await timeout(10000)
  })
})

It is bad because a false positive is raised to Jest since it uses process.on('unhandledRejection', uncaught) to listen for every unhandled rejection - including the ones raised by vscode itself.
No error really happened in my tests, but the test runner will say that an error happened.

Maybe https://github.com/microsoft/vscode/issues/138269

@bpasero Do you know if my vscode version (1.62.3) already has this fix?

The fix was pushed to insiders. You can give our preview releases a try from: https://code.visualstudio.com/insiders/

@bpasero Yeah, it's the issue.
I ran the same test on Insiders, and I still have the same error. But instead of undefined, I had a better-detailed error added by PR #138333:
Canceled: Canceled
    at A.reset (/private/var/folders/jm/1lt96gyn7m51jbdhd6t5dq7h0000gn/T/AppTranslocation/5DBCEAB0-4856-46F1-A712-E7ADE7CC31D9/d/Visual Studio Code - Insiders.app/Contents/Resources/app/extensions/typescript-language-features/dist/extension.js:1:534074)
    at /private/var/folders/jm/1lt96gyn7m51jbdhd6t5dq7h0000gn/T/AppTranslocation/5DBCEAB0-4856-46F1-A712-E7ADE7CC31D9/d/Visual Studio Code - Insiders.app/Contents/Resources/app/extensions/typescript-language-features/dist/extension.js:1:530729
    at processTicksAndRejections (internal/process/task_queues.js:93:5) {name: 'Canceled', stack: 'Canceled: Canceled
    at A.reset (/private/v…ctions (internal/process/task_queues.js:93:5)', message: 'Canceled'}

Despite that issue being closed, it wasn't solved here since Jest is still catching this exception and failing the test.
Is there a better way to fix it?
I can try to help fix it in vscode, but I need more context about what to do to can help.

@mjbvz moving to you, maybe there is a better way than rejecting.

/verified


Support pattern matching for Style/IdenticalConditionalBranches cop

This PR supports Ruby 2.7's pattern matching syntax for Style/IdenticalConditionalBranches cop.
This Style/IdenticalConditionalBranches cop is detecting for if and case.
Therefore, I think about detecting case-match with the cop instead of a new cop.
It may also be suitable for the cop's role of detecting duplicated conditional branches.

Before submitting the PR make sure the following are checked:

[x] The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
[x] Wrote good commit messages.
[ ] Commit message starts with [Fix #issue-number] (if the related issue exists).
[x] Feature branch is up-to-date with master (if not - rebase it).
[x] Squashed related commits together.
[x] Added tests.
[x] Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
[x] Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

Thanks!


Make UI more compact

Fix #20

@BaptisteGelez Can you share a screenshot to have an idea ?

Sorry @myrdinm, I was too fast. I'll put in in preprod right away!

Done: https://u-website.dev.unixcorn.org


v3.beta.4 ionic serve --address not working

What version of the CLI are you using? Output of ionic --version
3.0.0-beta.4
Short description of the problem:
The Windows 10 system has three network interfaces defined.
ionic serve with no flags shows the three interface addresses and prompts for one to be selected.
D:\dev\bpApp>ionic serve
? Multiple addresses available. Please select which address to use: (Use arrow keys)
> <IP_ADDRESS>
  <IP_ADDRESS>
  <IP_ADDRESS>

ionic serve --address <IP_ADDRESS> also prompts for an interface address to be selected
D:\dev\bpApp>ionic serve --address <IP_ADDRESS>
? Multiple addresses available. Please select which address to use: (Use arrow keys)
> <IP_ADDRESS>
  <IP_ADDRESS>
  <IP_ADDRESS>

What behaviour are you expecting?
Maybe I'm interpreting the documentation incorrectly, but I was expecting that when the --address flag is specified the prompt to select an interface address would be skipped.
Steps to reproduce:

ionic serve --address xxx.xxx.xxx.xxx on a system with multiple network interfaces

Post the output of ionic info below please
Cordova CLI: 6.5.0
Ionic Framework Version: 2.2.0
Ionic CLI Version: 3.0.0-beta.4
ios-deploy version: Not installed
ios-sim version: Not installed
OS: Windows 10
Node Version: v6.10.1
Xcode version: Not installed
Other information: (e.g. stacktraces, related issues, suggestions how to fix, stackoverflow links, forum links, etc)

+1.  It would be fantastic if we could specify a default listen address in a configuration file, versus menu-selection or command-line parameter. Thanks!

This is exactly what should be happening.  It appears that there is a bug around this.

commit 92dbcd868af7878289d848b325195a1fdf2faecb fixes this issue and will be released next week.


Remove log.flush.interval.messages from Kafka server.properties

Apache Kafka flush behavior can be set from the driver config so it is best to leave log.flush.interval.messages out of server properties. Many users who benchmark Kafka from this copy of OMB may leave out the 'flush.messages' driver config and not realise that Kafka will be flushing on each message batch in any case.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

fyi @travisdowns

Hi @Vanlightly thanks for joining the Redpanda community! Please could you sign the CLA so that we can merge this please?


Visualisation 1 get data and create json from it.

Need to visit data source page, download the data (.csv or some other format) and create json from it. Consider if data source provides api => less work for us. Json could be created using some small script tai some web app that converts csv to json.
Acceptance criteria: json file with data in comment for the task. Later these would be used to create UI without back-end and to initialize database

Global (NH+SH)/2

monthly - vertopal.com_HadCRUT.<IP_ADDRESS>.analysis.summary_series.global.monthly (1).txt

annual - HadCRUT.<IP_ADDRESS>.analysis.summary_series.global.annual [MConverter.eu].txt

Northern hemisphere

monthly  - vertopal.com_HadCRUT.<IP_ADDRESS>.analysis.summary_series.northern_hemisphere.monthly.txt

annual  - vertopal.com_HadCRUT.<IP_ADDRESS>.analysis.summary_series.northern_hemisphere.annual.txt

Southern hemisphere

monthly -

vertopal.com_HadCRUT.<IP_ADDRESS>.analysis.summary_series.southern_hemisphere.monthly.txt

annual -

vertopal.com_HadCRUT.<IP_ADDRESS>.analysis.summary_series.southern_hemisphere.annual.txt

vis1.csv


Redis tagged cache using a lot more storage since upgrading from 5.2.12 to 5.2.28

We use tagged redis cache to power a custom page cache implementation and since upgrading from Laravel 5.2.12 to 5.2.28 our Redis instance has been filling up within a matter of hours (it was previously running for > 6 months without filling up).
Looking within Redis with 5.2.12 it was storing a tag which contained a key which pointed to the content stored under another key. With 5.2.28 it's creating a tag which contains a key which points to another key which then points to the content. So it's adding another key in the middle.
I've looked through the commit history but I'm struggling to narrow down where this change has happened and why.

We changed the scheme, so you should expect it to double memory usage if you don't clear the old stuff.

Please open a new issue if the change was more than two fold, as that would indicate another issue.

It's definitely not because our old data is still in the instance. I've cleared the instance and it still fills up.
I've dug up some more info and added it to a new issue.
https://github.com/laravel/framework/issues/13675


Building with Espressif32 (5.2.0) and GNU++17 fails

Describe the bug
Building with PlatformIO option platform = espressif32@5 and build_flags = -std=gnu++17 fails.
The cause seems to be that beta is already a registered top-level symbol:
.pio/libdeps/m5stack-core2/M5Core2/src/utility/quaternionFilters.cpp:35:14: error: 'float beta' conflicts with a previous declaration
 static float beta = sqrt(3.0f / 4.0f) * GyroMeasError;  // Compute beta
              ^~~~
In file included from c:\users\sybren\.platformio\packages\toolchain-xtensa-esp32\xtensa-esp32-elf\include\c++\8.4.0\cmath:1892,
                 from c:\users\sybren\.platformio\packages\toolchain-xtensa-esp32\xtensa-esp32-elf\include\c++\8.4.0\math.h:36,
                 from C:/Users/Sybren/.platformio/packages/framework-arduinoespressif32/cores/esp32/esp32-hal.h:30,
                 from C:/Users/Sybren/.platformio/packages/framework-arduinoespressif32/cores/esp32/Arduino.h:36,
                 from .pio/libdeps/m5stack-core2/M5Core2/src/utility/quaternionFilters.h:4,
                 from .pio/libdeps/m5stack-core2/M5Core2/src/utility/quaternionFilters.cpp:12:
c:\users\sybren\.platformio\packages\toolchain-xtensa-esp32\xtensa-esp32-elf\include\c++\8.4.0\bits\specfun.h:343:5: note: previous declaration 'typename __gnu_cxx::__promote_2<_Tp, _Up>::__type std::beta(_Tpa, _Tpb)'
     beta(_Tpa __a, _Tpb __b)
     ^~~~
.pio/libdeps/m5stack-core2/M5Core2/src/utility/quaternionFilters.cpp: In function 'void MadgwickQuaternionUpdate(float, float, float, float, float, float, float, float, float, float)':
.pio/libdeps/m5stack-core2/M5Core2/src/utility/quaternionFilters.cpp:152:56: error: invalid operands of types '<unresolved overloaded function type>' and 'float' to binary 'operator*'
   qDot1 = 0.5f * (-q2 * gx - q3 * gy - q4 * gz) - beta * s1;
                                                   ~~~~~^~~~
.pio/libdeps/m5stack-core2/M5Core2/src/utility/quaternionFilters.cpp:153:55: error: invalid operands of types '<unresolved overloaded function type>' and 'float' to binary 'operator*'
   qDot2 = 0.5f * (q1 * gx + q3 * gz - q4 * gy) - beta * s2;
                                                  ~~~~~^~~~
.pio/libdeps/m5stack-core2/M5Core2/src/utility/quaternionFilters.cpp:154:55: error: invalid operands of types '<unresolved overloaded function type>' and 'float' to binary 'operator*'
   qDot3 = 0.5f * (q1 * gy - q2 * gz + q4 * gx) - beta * s3;
                                                  ~~~~~^~~~
.pio/libdeps/m5stack-core2/M5Core2/src/utility/quaternionFilters.cpp:155:55: error: invalid operands of types '<unresolved overloaded function type>' and 'float' to binary 'operator*'
   qDot4 = 0.5f * (q1 * gz + q2 * gy - q3 * gx) - beta * s4;

The easiest way to fix this is to rename beta to something more descriptive, like GyroMeasBeta.
To reproduce
With this platformio.ini:
[env:m5core2]
board = m5stack-core2
platform = espressif32@5
framework = arduino
lib_deps =
<EMAIL_ADDRESS>
build_flags = -std=gnu++17
build_unflags = -std=gnu++11

and this src/main.cpp:
#include <Arduino.h>
#include <M5Core2.h>

void setup() {
  Serial.begin(115200);
  M5.begin(false, false, false, false);
}

void loop() { M5.update(); }

build the project. It should result in the above error.
Expected behavior
I would expect the library to build just fine.
Screenshots
No response
Environment

OS: Windows 10
IDE &IDE Version: VSCode 1.72.2 with PlatformIO Core, version 6.1.4
Repository Version: 0.1.5

Additional context
No response
Issue checklist

[X] I searched for previous reports in the issue tracker
[X] My report contains all necessary details

fixed #107


Running multiple devices

https://github.com/mmarkelov/jest-playwright/issues/19#issuecomment-584937549

cool!

I suppose that we should able run tests for devices without defined browsers in config.
Cases:

We defined browsers and devices:

module.exports = {
     browsers: [ 'chromium', 'firefox'],
     devices: ['iPhone 6', 'Pixel 2']
}

For this case we need run 4 tests:

chromium and iPhone 6
chromium and Pixel 2
firefox and iPhone 6
firefox and Pixel 2

We defined devices:

module.exports = {
     devices: ['iPhone 6', 'Pixel 2']
}

If we are using standalone version, for example playwright-webkit, we should run 2 tests:

webkit and iPhone 6
webkit and Pixel 2

But I'm not sure what to do for playwright. Should it run for default chromium browser? Also browser can be defined with env variable

I suppose that we should able run tests for devices without defined browsers in config.
Cases:

We defined browsers and devices:

module.exports = {
     browsers: [ 'chromium', 'firefox'],
     devices: ['iPhone 6', 'Pixel 2']
}

For this case we need run 4 tests:

chromium and iPhone 6
chromium and Pixel 2
firefox and iPhone 6
firefox and Pixel 2

We defined devices:

module.exports = {
     devices: ['iPhone 6', 'Pixel 2']
}

If we are using standalone version, for example playwright-webkit, we should run 2 tests:

webkit and iPhone 6
webkit and Pixel 2

But I'm not sure what to do for playwright. Should it run for default chromium browser? Also browser can be defined with env variable

If they are using playwright I would only run it on chromium as you said. So chromium is the default. If they specify the browsers setting manually, then it will be overwritten.

@mxschmitt I think I'm done here


Num 183

Addresses #183

@hayesgb would it be possible for you to make a release including this fix, it would be much appreciated!


GH-35560: [C++] Use Cast() instead of CastTo() for Scalar in test

Rationale for this change
Remove legacy code

What changes are included in this PR?

Replace the legacy scalar CastTo implementation with the new cast compute kernel for supported types, without requiring additional casting logic for unsupported types.

Are these changes tested?
Yes. It is passed by existing test cases.

Are there any user-facing changes?
No.

Closes: #35560

Hello, @kou
I resolved a conflict that arose due to a commit related to timestamp casting.


RFC: Core set of tags for TSDoc

TSDoc should define a core set of tags for very common scenarios, so their semantics can be standardized across all tools.
Ignoring the syntax details for a moment, which tags should be included in this list?
Here's some suggestions from AEDoc:

@param
@returns
{@link}
{@inheritdoc}
@remarks

Any others?

Since @internal is recognized by the TypeScript compiler, I think it would be good to define its documentation behavior.
The @depricated tag seems common and significant in docs. (related TC39 proposal)
JSDoc supports @ignore while TypeDoc supports @hidden to remove an API from documentation.
JSDoc and JavaDoc support @see, @since, @throws, and @author. I'm not partial to any of them but they are worth noting.
Is @remarks/@summary separation necessary. I haven't used that pattern so I'm wondering how helpful it is.

@aciccarello @deprecated *

@see linking to a specific symbol or resource
@example could be used with markdown code samples
@template for documenting type parameters
@throws

I think these tags are worth using.

We eliminated the @see tag because the usage was unclear.  Consider some documentation like this:

Widget.render()
The Widget.render() method draws the widget.  See the IRenderable interface for more about rendering.  Blah blah blah...
See Also

The IRenderable interface
The Rendering section of the Widget tutorial
(2003). Widgets: Rendering Them. Lawrence, KS: University Press of Kansas. ISBN 9738-0-706-0899-7.

Consider this naive representation:
/**
 * The `Widget.render()` method draws the widget.  See the {@link IRenderable}
 * interface for more about rendering.  Blah blah blah...
 *
 * ## See Also
 *
 * - The {@link IRenderable} interface
 * - The {@link http://example.com | Rendering} section of the Widget tutorial
 * - (2003). *Widgets: Rendering Them.* Lawrence, KS: University Press of Kansas.
 *   ISBN 9738-0-706-0899-7.
 */

How would you use the @see tag to represent this?  What would be the advantage?

The advantage is a standardized way to make the section "see also" and it's up to documentation generator to output it.
 /**
 * The `Widget.render()` method draws the widget.  See the {@link IRenderable}
 * interface for more information about rendering.  Blah blah blah...
 *
 * @see {@link IRenderable | The interface}
 * @see {@link http://example.com | The rendering section of the Widget tutorial}
 * @see (2003). *Widgets: Rendering Them.* Lawrence, KS: University Press of Kansas. ISBN 9738-0-706-0899-7.
 */

Usage

@see {@link <internal symbol>}
@see {@link <https://domain.com>}
@see <text>

The Widget.render() method draws the widget. See the IRenderable interface for more about rendering. Blah blah blah...
See also

The IRenderable interface
The Rendering section of the Widget tutorial
(2003). Widgets: Rendering Them. Lawrence, KS: University Press of Kansas. ISBN 9738-0-706-0899-7.

Seems reasonable.  However strict mode should enforce that @see always appears at the start of a line, and always after the main content.  Before we eliminated it, we found a lot of people writing this kind of thing:
/**
 * The `Widget.render()` method draws the widget.  @see the {@link IRenderable}
 * interface for more about rendering.  It has more info about stuff you might like
 *
 * Blah blah...
 */

Please consider:
async
public
private

Please consider allowing the user to extend the list with their own tags, which in turn could be utilized by third party tools. Couple examples that come to my mind:

Tag
Usage
Notes

@browserspecific
Browser-specific hacks and workarounds. Should be able to accept arguments.
First seen in tslint-microsoft-contrib

@impure@emits
Emits side effects.
Think TSLint rule that strictly forbids side effects unless the function/method is explicitly marked as @impure.

@mocked@hardcoded @stubbed
Allows you to distinguish between real data and stubs that ought to be removed one day.
When building a web application for which there is no data source yet, it's easy to lose track of what's real and what's been mocked.

@debt@dangerous
A candidate for refactoring.
Keep track of technical debt being accumulated in your project. Right now one can achieve a similar effect by exploiting the @deprecated tag along with TSLint's  "deprecation": { "severity": "warning" } rule, but deprecation is not the same as technical debt.

@experimental
API not stable or hidden behind a feature flag.

@vulnerability
Security issues ahead.

@BnayaZil all of your listed tags would be redundant, because TypeScript already has both visibility modifiers and async keywords.
@karol-majewski this issue concerns only core set of tags. Additional tags will be supported, but not specified in tsdoc documentation.

@DovydasNavickas do you mean to async/await as async keyword?

@BnayaZil Yes. Do you have something else in mind?

yes, I thought about callbacks and etc but I see now that JSdoc ask to prevent this kind of use

Yeah... I'm happy that JSDoc discourages that because having multiple ways to declare asynchronousy makes it harder to use. And async/await is available everywhere with the help of TypeScript's downleveling.

Many of the things that the compiler supports are more to understand JavaScript code better. Keep in mind they're not necessarily all used for language service support with TypeScript code.

Any thoughts on an @include, @external or similar tag to allow associating a separate documentation file with an API. The idea being that you might want to write a more extensive narrative or set of examples in an external Markdown file, but have the doc build pull that in and merge it with the docs as if it had been embedded into the code.

@EisenbergEffect that seems like a nifty idea, but I am not sure whether it's something that needs to be part of TSDoc vs. say, the publishing pipeline that ingests TSDoc output.
@pgonzal thoughts?

@dend Good point. It would be enough for me if the output of TSDoc simply represented the concept of an associated external file. Then, 3rd party processors could use that information in domain-specific ways. I could do this by convention tool. So, it's not a deal breaker if it doesn't get in. Just tossing scenarios out there.

@MartynasZilinskas could you give an example of the syntax for @template?  Is the syntax analogous to @param?

(I've split off some of the other topics into separate GitHub issues.)

@experimental is a nice to have dual to it. (Not sure about @beta - it implies the degree of readiness, and naturally you start thinking - "where is my @rc or @Alpha".

@c69 I think this reflects two different usage scenarios.  A large library with commercial support contracts needs something like the AEDoc @alpha -> @beta -> @public graduation.  Whereas for smaller community projects, @experimental is probably sufficient and avoids implying a beta process.  I'd vote to support both.

@todo maybe its anti-pattern... but its very frequently used

I agree that @todo is an antipattern.  Code comments aren't great for work tracking.  However, the "lax" mode parser should recognize this notation to avoid accidentally including the todo items in the published API docs.

@pgonzal Yes, a @template tag should have the same syntax as @param.

PR https://github.com/Microsoft/tsdoc/pull/50 introduces definitions for the subset of core tags required by API Extractor.  As part of this work, we're separating the tag definitions into four "standardization groups":

Core: Important tags that every TSDoc implementor should support.
Extended: Optional tags that, if supported, have a standardized syntax and semantics.
Discretionary: Tags that have a standardized syntax, but whose semantics may differ between implementations. They are included primarily to encourage consistency between different implementors.
None: All other tags that are not part of the standard.  The syntax and semantics are completely user-defined.

Feel free to provide comments/feedback.  No aspects of the standard are finalized yet.  Right now I'm focused on porting API Extractor to use the TSDoc parser instead of the old custom parser.  Based on what we learn from that experience, I'll start trying to lock down various aspects of the specification.

For a generic type definition, it can be helpful to document what the generic type is used for. Using @template was mentioned in some previous comments but I wonder if @typeparam would be better. Either way, I think this would be a good candidate for inclusion of the standard tags.
VS Code already has some support for @template and there has been a request for TypeDoc to support that as well (TypeStrong/typedoc#860). TypeDoc currently supports @typeparam T - Description and @param <T> - Description.
/**
 * Alias for array
 *
 * @typeparam T - Type of objects the list contains
 */
type List<T> = Array<T>;

/**
 * Wrapper for an HTTP Response
 * @typeparam B - Response body
 * @param <H> - Headers
 */
interface HttpResponse<B, H> {
    body: B;
    headers: H;
    statusCode: number;
}

I've split @typeparam into its own issue https://github.com/Microsoft/tsdoc/issues/72 so it doesn't get overlooked. A few other people have asked about this already, so I think it's worth including.

I vote for @throws, or some other way to document exceptions. Really useful when coding against a procedure to know which kind of errors I should be handling.

Suggested in microsoft/vscode#77261 something like @extended and @extendedExample that's intended to land in docs but not be shown in smaller contexts like IntelliSense.
/**
 * Take over the specified world.
 * @beta
 *
 * @param world - The world to dominate.
 *
 * @remarks
 * Optimizes for minimum loss of life, minimum reputation harm, and maximum deviousness.
 * Leverages all available capital and human resources without remorse.
 *
 * @extended
 * The development of this procedure began with the Sumerian kings.
 * [... long history ...]
 *
 * @extendedExample
 * // Example of error handling based on the latest best practices
 * while (!retired) {
 *   try { takeOverWorld(earth) } catch (error) {
 *     if (error instanceof InsurrectionError) squashInsurrection()
 *     else if (error instanceof CoupError) decimateCoup()
 *     else if (error instanceof GlobalThermonuclearWarError) retire()
 *     [.. long example list .. ]
 *   }
 * }
 */
export function takeOverWorld(world: World): void;

I'm going to close this RFC, since the core set of tags has stabilized. The inventory of tags is more accurately tracked by the file StandardTags.ts.
Going forward, if people want to suggest new tags (or modify existing ones), let's open separate issues so they can be discussed individually.

@bookmoons I created https://github.com/microsoft/tsdoc/issues/170 and https://github.com/microsoft/tsdoc/issues/171 for the two questions you asked.

I would love to have something like @caution or @note.

@debt

That one would be useful.


Create release notes for Tap v16

As titled, the v16 release does not have a release inside Github!

Does anyone have an action that can be dropped in to create GH releases automatically from tags with a link to the changelog release notes?  I'm not going to remember to do that each time, clearly.

I usually use https://docs.github.com/en/repositories/releasing-projects-on-github/automatically-generated-release-notes. Not perfect but require no setup in the repo.


sendSms

Hi,
I noticed that sendSms returns sometimes true even if its get a OK from the sim900 chip (i checked the serial). I tried to increase the timeout from 5 Seconds to 10 and for interchar from 3000 to 6000.It only happens when i send multiple sms. Any guess?

@Craftplorer I think there are two questions you asking.

sendSMS returns true if only "OK" was read, even message was failed sending out. And "OK" may come from other commands.
sendSMS may cause timeout by only set 5 seconds and 3 seconds for inter char?

@Craftplorer Oops, the comment is truly wrong. And sure  it's better to increase the timeout value, I will set it as 20 seconds.

@lanselambor Thank you.


edge -> latest

Since this is pretty dead, and there is no need for a "bleeding edge" image

Everyone using edge will now have to switch to get updates though.

I think both of them will manage...


No default jsDelivr CDN file set

This package doesn't have a default file set. You can set it via jsdelivr, browser, or main field in package.json.
It would be good to get it via jsdelivr

A PR is welcome for to add a main: 'index.json', thanks!


just a question

HI @blaqbern just wondering what font that is in the screenshots? Nice one!

Hi,
Thanks. It's Source Code Pro Extra Light. You may find the Light or even Regular varieties to be a bit more forgiving to the eyes for long sessions. I find I'm leaning that way of late. But because Extra Light looks so classy, it seemed right for the screenshot. :smiley:


[integration-tests] Run in band

Might prevent flickering #2541 .

Well maybe it does prevent flickering. But not in the direction I had hoped 😆 . Still, may be a useful data point.

This definitely does not prevent flickering. It might change the frequency, but more investigation is needed.


STM32L475 flash fixes

Updated the STM32L475 flash algo and fixed an issue in FlashBuilder. The STM32L475 now passes all functional tests on macOS.

/morph test


JacksonXml version 5 buggy and fixed versions are reversed ?

Dear Developers,
I cloned the repository for JacksonXml with the following command "defects4j checkout -p JacksonXml -v 5b -w ./JacksonXml5" and fixed version by using the "-5f" instead of "-5b".
When I look at the patch (framework/projects/JacksonXml/patches/5.src.patch) the fix is already applied in "-5b" , I can see that the version that is cloned with the command "-5f" is actually the buggy version. I hope you can reproduce this and confirm it. Wanted to let you guys know.
Best,
Yigit

Hi @yigitk,
A patch in Defects4J is not the bug fix but rather the bug itself, which is reintroduced into the fixed version (to obtain the buggy version). The bug fix is the inverted diff. Admittedly, the naming of the folder (patches) is confusing.
Hope this resolves the confusion.
Best,
René

Hi @rjust,
Thank you for the explanation and excuse my misinterpretation. I am closing this issue to not further confuse any people :)

No worries, we really should rename the patch folders at some point.


[VS Code] Starting collaboration session: RPC connection closed.

Error:
Starting collaboration session: RPC connection closed.
Steps to Reproduce:

Version Data

extensionName
VSLS

extensionVersion
0.4.0-dev

protocolVersion
2.2

applicationName
VSCode

applicationVersion
1.31.1

platformName
MacOS

platformVersion
18.2.0

Hi, thank you for reporting this. We are tracking the issue in #1748. So  I will close this as duplicate. it would be great If you can  attach your logs in #1748 to help us to investigate. You can attach your logs by simply running Live Share: Export logs command from VS Code command line.


Characters Package

Description
Flutter currently has poor support for grapheme clusters like 👨👩👦, which it considers to be multiple characters even though it appears to the user as one.  This PR is a proposal for adding support via the characters package.

The design doc has more details.
Changes

[x] Character count.
[x] Error state based on character count.
[x] Pasting excessive characters places the cursor correctly.

Related Issues
Engine PR:
https://github.com/flutter/engine/pull/17420
Main:
https://github.com/flutter/flutter/issues/32240
Closes https://github.com/flutter/flutter/issues/55670
Closes https://github.com/flutter/flutter/issues/54240
If you solve the caret position comment you made:
https://github.com/flutter/flutter/issues/31818
https://github.com/flutter/flutter/issues/50563
Potential:
https://github.com/flutter/flutter/issues/26602
https://github.com/flutter/flutter/issues/36007
https://github.com/flutter/flutter/issues/47086
Tests

Character count for maxLength works with/without grapheme clusters and surrogate pairs.
Enforced character limit for maxLength works with/without grapheme clusters and surrogate pairs.
Error state for maxLength shows at the right length with/without grapheme clusters and surrogate pairs.

Breaking Change
Currently I don't think this is a breaking change.  There may be broken visual diff tests in the rare case where they include a grapheme cluster.

TODO: Handle arrow key navigation in the framework using characters: https://github.com/flutter/flutter/blob/master/packages/flutter/lib/src/rendering/editable.dart#L556

I'm not sure if the failures are due to something special I'm missing because I added a new package, or if it's the typical versioning failure.  I'm going to squash all the commits and see if it goes away.

I could use advice on the test failure if anyone has any ideas. Stack frames parsed incorrectly https://github.com/flutter/flutter/pull/53381/checks?check_run_id=755670351

I'm going to split this into 2 PRs, so I'm putting this back into WIP.  The other PR will simply add the characters package to the repo, and I'll update this one once it's merged.

https://github.com/flutter/flutter/pull/59267 was merged and I updated this PR, so we're ready for review again.


Feature/011 add view job view job results endpoints

Ready for Review

Since the new PR https://github.com/attm2x/m2x-ios/pull/29 is raised for Jobs API closing this pull request.


Incorrect size on desktop

On desktop MeeduPlayerController.videoPlayerController.value.size is always 1920/1080. There is the way to get actual size using media_kit https://github.com/alexmercerind/media_kit/issues/212.

It should be the same as the logs of media_kit

I investigated problem, it is hapend only when video has heigth: 1920 and width: 1080

On left side is video on web and on right side is same video on Windows.
https://github.com/zezo357/flutter_meedu_videoplayer/assets/71345244/d18760cd-7cd6-435e-b241-06f09b690b49
Also attach video with what you can test it.

I investigated problem, it is hapend only when video has heigth: 1920 and width: 1080

Image

On left side is video on web and on right side is same video on Windows.

Video
https://github.com/zezo357/flutter_meedu_videoplayer/assets/71345244/d18760cd-7cd6-435e-b241-06f09b690b49

Also attach video with what you can test it.

I don't see the problem, the video is 1920/1080 and the size shows that
This the right logic!?
Where is the problem?

On Windows video I attached has MeeduPlayerController.videoPlayerController.value.size.width = 1920 but its actual width = 1080 and MeeduPlayerController.videoPlayerController.value.size.heigth = 1080 but its actual heigth = 1920.

Okay got you, they are switched,
I will recheck it and let you know, sorry for that mistake and I hope I find a fix for it

I may check it at night due to being busy right now sorry for that too


[TS migration] Migrate TextWithEllipsis

Details

TextWithEllipsis is used in a single place in the codebase - as Mike is typing... indicator. In order to show it either use two windows and chat with yourself, or change the following:
In ReportTypingIndicator.js
switch (1) { // <-- hardcode '1' here to always render <TextWithEllipsis />
  case 0:
      return null;

  case 1:
    return (
      <TextWithEllipsis
          leadingText={PersonalDetails.getDisplayNameForTypingIndicator(usersTyping[0], props.translate('common.someone'))}
          trailingText={` ${props.translate('reportTypingIndicator.isTyping')}`}
          textStyle={[styles.chatItemComposeSecondaryRowSubText]}
          wrapperStyle={[styles.chatItemComposeSecondaryRow, styles.flex1]}
          leadingTextParentStyle={styles.chatItemComposeSecondaryRowOffset}
      />
    );

Fixed Issues

$ https://github.com/Expensify/App/issues/25022
PROPOSAL:
Tests

Verify that no errors appear in the JS console
Either login as two different users and start chatting with yourself, or
change the code as described above to always show User is typing... text

Offline tests

In offline mode, you won't receive updates when another user is typing

QA Steps

Login as two different users and start chatting with yourself - you should see User is typing... and this confirms that <TextWithEllipsis /> works correctly

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native
https://github.com/Expensify/App/assets/85628901/6a607174-934f-46c0-b9f2-6257a22ab473

Android: mWeb Chrome
https://github.com/Expensify/App/assets/85628901/34ca2597-1e6d-4830-a9bc-3ecf5c739525

iOS: Native
https://github.com/Expensify/App/assets/85628901/6a607174-934f-46c0-b9f2-6257a22ab473

iOS: mWeb Safari
https://github.com/Expensify/App/assets/85628901/34ca2597-1e6d-4830-a9bc-3ecf5c739525

MacOS: Chrome / Safari
https://github.com/Expensify/App/assets/85628901/a993040e-7b0f-4477-b926-39d9f63635b6

MacOS: Desktop

🚀 Deployed to staging by https://github.com/mountiny in version: 1.3.96-6 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/puneetlath in version: 1.3.96-15 🚀

platform
result

🤖 android 🤖
failure ❌

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/roryabraham in version: 1.3.98-5 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


NPE in StreamingWorkbookReader.init(InputStream) exception handler

In StreamingWorkbookReader.init(InputStream), if there's a RuntimeException, f.delete() is called. f may be null at this point, giving a NullPointerException.
    try {
      f = writeInputStreamToFile(is, builder.getBufferSize());
...
    } catch(IOException e) {
      throw new ReadException("Unable to read input stream", e);
    } catch(RuntimeException e) {
      f.delete();   // <----
      throw e;
    }

This is pretty harmless, but it does hide the original exception. I suppose it just needs an if (f != null) guard.

Good catch, we should definitely add a null guard there.


[Content sync]: carbon-website PR 3219

The following pull request on carbon-website has been merged. It contains .mdx content changes that may need synced to platform.

https://github.com/carbon-design-system/carbon-website/pull/3219

verified and fixed on prod: https://next.carbondesignsystem.com/libraries/carbon-react/latest/assets/tag/style


cmd/go2go: the Graph example doesn't compile

What did you do?
code:  https://go2goplay.golang.org/p/6EKNV4FQ4KI
What did you expect to see?
Compiles
What did you see instead?
Doesn't compile
BTW, is type (v *Vertex) Edges() []*FromTo { ... } a typo of func (v *Vertex) Edges() []*FromTo { ... }

I'm not saying it's normal, but FTR if you want to make the example compile you need provide explicit type parameters when instantiating Graph:
g := New(*Vertex, *FromTo)([]*Vertex{}) // ok

Also, while I understand the error message for:
g := New(Vertex, *FromTo)([]*Vertex{}) // error: *Vertex does not satisfy NodeConstraint(Edge) (missing method Edges)

I'm not sure I understand why it says the same thing in the following case, since the Vertex type parameter is now correct:
g := New(*Vertex, FromTo)([]*Vertex{}) // error: Vertex does not satisfy NodeConstraint(Edge) (missing method Edges)

Or maybe is it because Vertex is also inferred from FromTo first?

OK, but maybe it is possible to deduce the Edge type from the New([]*Vertex{}) call, *Vertex has a Edges() []*FromTo method.

This seems like a question which has been answered.


Adds the Townhall Database, Pulls It in as a State

This closes #8.
It creates a new file for town hall data that is pulled in as JSON.
The App component pulls in the data by setting it in as a state.
This also changes the file structure so there is no ONMV file. It looks like this took care of the problem of the npm-debug.log being pushed up.

@ChelseaSkovgaard The latest commit fixes the merge conflict. You can now merge the PR.


[5.1] Foundation : add missing throws in docblock

add missing throws docblock in Foundation helepr

:+1:


Automated cherry pick of #7916: fix: keystone initialize data skip nil extra fields

Cherry pick of #7916 on release/3.3.
#7916: fix: keystone initialize data skip nil extra fields

/lgtm
/approve


✨ Add ERC1967I in LibClone

Description
closing #821.
Describe the changes made in your pull request here.
Checklist
Ensure you completed all of the steps below before submitting your pull request:

[x] Ran forge fmt?
[x] Ran forge snapshot?
[x] Ran forge test?

Pull requests with an incomplete checklist will be thrown out.

@Vectorized can you check once bytecode bcs i am worried about msize trick for returning address. It can be compatible zkSync?

Ok, this looks fantastic.

@atarpara Thanks for spotting the comment typos too.


Package ready for use?

Hi, sorry that this isn't an "issue", but I'd like to ask a question. Is this package ready to be used on consumer machines yet? I've noticed that the warning at the bottom was removed, and that got me pretty excited. If it's still not ready, I'd urge you to put it back there, so that people know that they shouldn't be using this yet.
I am only asking this question as I've looked into speakersafetyd and have noticed that it still has the warning and "eleven secret herbs and spices" text, while this one no longer has it.
Of course, thanks for what you do, and please feel free to close this issue as soon as you respond.

speakersafetyd's readme no longer has any reference to that. We publicly released speaker support for the models listed here last week, so yes this is safe to use. You only need to update your system and it will all work.

Ah, okay. Thank you. Can you please provide guidance on how to do that? Sorry, I'm not sure where to ask.

@chadmed Sorry, I don't want to disturb you, but I do want to enable speaker support. I can't figure it out. I've tried manually installing the package, but it hasn't worked. (I was running make all and sudo make install in speakersafetyd and asahi-audio). I don't know where else to ask, and if the speakers are ready, I would really like to use them. The README contains some things about "LSP Plugins" and "asahi-linux 6.6-11", but I can't find either of these things. Help would be appreciated!

Which distro are you on? It should have been automatic for Fedora on the next upgrade

Hi there, I was able to figure it out around a week ago. I just reinstalled Fedora, and it worked fine.

Wait i'm starting to become paranoid.
I reinstalled fedora 5000 times and tinkered with speakersafetyd and tas2764 (because both weren't activated by default);
I installed every alsa packages remotely related, tried with every combination of them, checked wireplumber and pipewire and bankstown, checked asahi-plateform-metapackage-audio, asahi-audio;
I checked asahi-diagnose, alsa-info.sh, alsamixer which never detected a soundcard and asahi-diagnose had platform sound deferred probing or something like that i don't quite remember;
and throught all that NEVER has speakersafetyd been launched on boot even after enabling it with systemctl and modprobing tas2764 and macaudio which wasn't activated for some reason.
How did you do it what kind of black magic did you use, everyone here seems to have been able to activate them except me.
Help would be very much appreciated, I'm on a Macbook Air M1.
I'll add asahi-diagnose output and alsa-info also, I just don't have the time right but needed to post this message, it's been a week that I've been refraining from asking online because everyone made it work out of the box on install.

I hope you guys can help me.

Please don't hijack closed issues. Open a new one.

Sorry, I'll do just that.


Unexpected failure of registry:2

###Startup params:
docker run -d -p 5000:5000 --restart=always --name registry -v /mnt:/var/lib/registry registry:2

###Failure
After running for a while (not sure how long it lasts), the registry fails with no logs & no exited code. Restart policy seems totally meaningless.
$ docker ps -a | grep registry
3a6ac78c2e62        registry:2                                       "/bin/registry /etc/   4 hours ago
$ docker logs 3a6ac78c2e62
<no log here>

Noticed that the container name set previously is gone nowhere now.
It could be kinda hard to trace & reproduce, yet i have at least 3 nodes suffer this today. No unusual operation was conducted though (as far as i could remember).

@dalanlan sounds rather like a docker bug.
Specifically, the total absence of any logs is worrying.
I know there is a syslog leak bug.
Do you experience high memory consumption on that host?
What version of docker is that?

docker 1.7.1

Do you experience high memory consumption on that host?

Nope since i'm aware. It's kinda odd 'cause i have just turned to a brand-new release image of registry yesterday, while an older one (published about 3 months ago whose id is 0ff65644861b) functions quite well all along.
$ docker images | grep registry
registry                                  2                                  2f1ef7702586        6 days ago          220.6 MB

@dalanlan yeah the non-sensical part is really the name "vanishing" from the docker ps, not restarting, and the total lack of any logs - which made me suspect a docker problem / host issue.
Unfortunately, there is little to do currently (but guessing) - if you hit it again, or manage to reproduce reliably, or get any other info, sure bring them forward.

Thank you for your time.
Closing it for now.


Adding playable demo

some performance optimization to infer 'live'

Damn, this is great! But it's still pretty unplayable, I tested it on a RTX 4090 through WSL and I got like one frame per second.

@Darkblader24, try to set ddim_noise_steps in game.py to lower value like 32 or 16

@Darkblader24, try to set ddim_noise_steps in game.py to lower value like 32 or 16

I did! Added control to do so while playing too, and a simple fps counter. 10 steps: 6fps, 16steps: 3fps
We should get above 10 easily when compiled, and potentially an other sampler.

Currently at 9fps at 16 steps compiled.

I got it working on Windows and Python 3.12 by installing Triton for Windows with this command:
pip install https://huggingface.co/madbuda/triton-windows-builds/resolve/main/triton-3.0.0-cp312-cp312-win_amd64.whl
With a RTX 4090 on Windows I get 2 FPS, but running it on WSL I get 7 FPS. Seems like running it on Linux natively is much better. But on Linux via WSL it fails to capture my mouse, so this is rather annoying.

Added a trial for a train.py

performance on a 3060 12GB Win 11, with triton for win python 3.11 + compiled torch using 16 steps, I got 1fps.

wondering, @julian-q if this train.py is anything close to the original : )

Updated way context noising is done -- try to merge with the latest changes and use 10 DDIM steps. You should hopefully see a speedup!

I would love to include this pygame interactive functionality, so thank you for contributing! Can you try to incorporate the pygame functionality into the original generate.py script to avoid code duplication?
Maybe by decomposing the pygame stuff into some sort of pygame_utils.py or something. Let me know what you think!

Absolutely, currently was running into issues with the generate, but updated the pygame with the stability aiming changes, and resolved conflicts for merging.

Great - I'm still seeing a lot of code duplicated across generate.py and game.py though. Want to try adding the pygame functionality to the latest generate.py script, remove game.py, and include any extra functions you need in utils.py?
Also for the scope of a single PR let's remove train.py. Though love to see you experimenting with training!


Deploying module to different scope when that resource group doesn't already exist

Hello,
Using the example from the tutorial as a base, I am trying to deploy updates to a resource that exists inside the node resource group created by my AKS managed cluster deployment. My main.bicep file is scoped to resourceGroup:
module createCluster './aks.bicep' = {
  name: 'clusterDeploy'
  params: {
    environment: environment
    nodeResourceGroupName: nodeResourceGroupName
  }
}

module updateLoadBalancerPublicIps './slb.bicep' = {
  name: 'updateLoadBalancer'
  scope: resourceGroup(nodeResourceGroupName)
  params: {
    location: location
    environment: environment
  }
  dependsOn: [
    createCluster
  ]
}

If the node resource group doesn't already exist before attempting this deployment, I get a resourceGroupNotFound error. Is there something fundamental that I'm missing? One note - I am attempting to keep the main.bicep resourceGroup scoped because of requirements from Azure's internal release tooling.

Can you share the following:

source code of the underlying modules
which tool you are using to deploy
the deployment command (if you used a CLI)

@alex-frankel I actually realized that this process was unnecessary for what I was trying to do (I should have been handling connecting the public ip I'm creating via Helm, not via ARM). Assuming this has to do with the AKS node resource group deployment happening outside the confines of the cluster deployment itself. I'm marking this closed.


[Feature] The global CLI tool should target net6.0 as well

Current the CLI only targets .NET Core 3.1 and .NET 5 so it requires either of them to be installed to be able to be used.
.NET 6 is the LTS version going forward so it should really be supported by the CLI as well.

Do you run into any issues? For me its working:
➜  playwright-dotnet git docker run -it mcr.microsoft.com/dotnet/sdk:6.0 /bin/bash
root@f8e83227f5eb:/# dotnet tool install -g Microsoft.Playwright.CLI
export PATH="$PATH:/root/.dotnet/tools"
playwright --help

Keep in mind that we don't recommend the CLI anymore and have the ps1 script now (See in the docs).

Oh I see, thank you for the heads up, guess I'll migrate then.
But in any case, it's running it that's the problem when no compatible .NET runtime version is installed (in this case I'm in Linux):
> dotnet playwright
It was not possible to find any compatible framework version
The framework 'Microsoft.NETCore.App', version '5.0.0' (x64) was not found.
  - The following frameworks were found:
      6.0.2 at [/usr/share/dotnet/shared/Microsoft.NETCore.App]

You can resolve the problem by installing the specified framework and/or SDK.

The specified framework can be found at:
  - https://aka.ms/dotnet-core-applaunch?framework=Microsoft.NETCore.App&framework_version=5.0.0&arch=x64&rid=debian.11-x64

@mxschmitt Maybe I'm bad at reading but has this PowerShell script been mentioned in any release notes? I'm looking all the way back to version 1.12 and I don't see it. Also the CLI is prominently featured in the docs and the PowerShell script is not really described at all. I'm sure I'm missing something but it seems to me some more work could be done to clear things up.

You know what, I just found issue #1668 and version 1.2.2 of the CLI does in fact work in .NET 6 even though the NuGet package does not include a version for .NET 6, I think that threw me off. I was using version 1.2.0.
For reference, it only includes netcoreapp3.1 and net5.0 just like 1.2.0.
https://nuget.info/packages/Microsoft.Playwright.CLI/1.2.2
Same as 1.2.0
https://nuget.info/packages/Microsoft.Playwright.CLI/1.2.0
And the csproj only has netcoreapp3.1 and net5.0 as well
https://github.com/microsoft/playwright-dotnet/blob/82710bccaa67eb4a0bd1035ee332c676398e015d/src/Playwright.CLI/Playwright.CLI.csproj#L9
Go ahead and close this issue if you want, I'm still confused though.

@DavidZidar If you are curious the fix was https://github.com/microsoft/playwright-dotnet/pull/1792:
https://github.com/microsoft/playwright-dotnet/blob/82710bccaa67eb4a0bd1035ee332c676398e015d/src/Playwright.CLI/Playwright.CLI.csproj#L22
Details in issue https://github.com/microsoft/playwright-dotnet/issues/1791

@campersau Oh interesting, I was curious and didn't know about that property. Thank you for that info!
I'm closing the issue, next time I'll just try the latest version. :)
If you really recommend the ps1-script instead though I think the docs need to be updated to reflect this:
https://playwright.dev/dotnet/docs/cli

@campersau Oh interesting, I was curious and didn't know about that property. Thank you for that info!
I'm closing the issue, next time I'll just try the latest version. :)
If you really recommend the ps1-script instead though I think the docs need to be updated to reflect this: https://playwright.dev/dotnet/docs/cli

See https://github.com/microsoft/playwright/pull/12025 which goes live in 1.19

@mxschmitt Excellent!


Source File Empty/Blank After Viewing Changes in Source Control Tab and Closing Changes View

Azure Data Studio Version:
Version: 1.29.0-rc1
Commit: 56cc1202d5af561a54b771169926a8e5401b5a2f
Date: 2021-05-12T03:41:06.659Z (11 hrs ago)
VS Code: 1.53.0
Electron: 11.2.2
Chrome: 87.0.4280.141
Node.js: 12.18.3
V8: <IP_ADDRESS>-electron.0
OS: Darwin x64 20.4.0
Steps to Reproduce:
Note, I have seen this behavior for basically as long as I've been using this app (> 1 years). I just work around it, but not today. :)

Open a folder.
Open a .sql file somewhere in that structure. Mine happens to be in a subfolder.
Make a change and save.
Switch to Source Control tab.
Select that file in there to view changes.
Close the compare/working tree view.

Actual:
Main source file tab is now empty.
Expected:
Main source file to still be there/not empty.
Workaround:
Close the blanked out tab and re-open the source file.
After doing this, if you view again in source control compare, it blanks it out again.
Notes
FWIW, opening same folder and interacting in similar way in Visual Studio Code does not have the same problem (and never has).

Same thing has been happening to me, though recently ADS has started to lock up whenever I try to view changes from the Source Control menu.

@SQLGuyJPS, that is probably another issue recently fixed. If you want the fix now:
https://github.com/microsoft/azuredatastudio/issues/15180
OR, get the RC:
https://github.com/microsoft/azuredatastudio/issues/15385

Seems to be fixed in the RC, in my initial testing.

Closing as a duplicate of https://github.com/microsoft/azuredatastudio/issues/12293.


None of the links to the Face Antispoofing Datasets are valid.

I'm on a deadline and i need a descent face anti-spoofing dataset such as Replay-Attack or Casia-FASD. However, none of the links to these datasets are working. Any help?

I have the same issue. Message me if you get access.
My Baidu accounts no longer work because they require a local China phone number -- even ones I have signed up for with a phone number in the past. If I register a new account, I receive the message:
暂不支持海外及港澳台地区注册 (Essentially, overseas accounts are not allowed)

It turned out to be an IP address issue, using a VPN solved my problem.

I am working on my thesis and I'm looking for Replay Attack and OULU datasets, could you share where I would get access to them?