Incoherant result of jfrog rt s  with the api call

When i use the folowing request
jfrog rt s --spec=/opt/resource/check.aql.json --spec-var "$MYVARS"

with the spect file spec file
{
  "files":
    [
      {
        "aql":
          {
            "items.find" :
               {
                 "type":"folder",
                 "repo":{"$eq":"${repository_id}"},
                 "path":{"$eq":"${group_id_path}/${artifact_id}"}
               }
          }
      }
    ]
}

In debug mode I see that the query is:
[Debug] Searching Artifactory using AQL query:
 items.find({
                 "type":"folder",
                 "repo":{"$eq":"my-repo"},
                 "path":{"$eq":"path/to/artifact-id"}
               }
          ).include("name","repo","path","actual_md5","actual_sha1","size","type","property")

And the result is:
+ cat /tmp/jfrog_search.json
[
  {
    "path": "my-repo/path/to/artifact-id/3.2.1-rc.1"
  },
  {
    "path": "my-repo/path/to/artifact-id/3.2.1-rc.2"
  },
  {
    "path": "my-repo/path/to/artifact-id/3.2.1-rc.3"
  },
  {
    "path": "my-repo/path/to/artifact-id/3.2.1-rc.6"
  }
]

However the result sould contain more that the field path. When Ido an api call with postman I get
{
  "results": [
    {
      "repo": "my-repol",
      "path": "path/to/artifact-id",
      "name": "3.2.1-rc.1",
      "type": "folder",
      "size": 0
    },
    {
      "repo": "my-repol",
      "path": "path/to/artifact-id",
      "name": "3.2.1-rc.2",
      "type": "folder",
      "size": 0
    },
    {
      "repo": "my-repol",
      "path": "path/to/artifact-id",
      "name": "3.2.1-rc.3",
      "type": "folder",
      "size": 0
    },
    {
      "repo": "my-repol",
      "path": "path/to/artifact-id",
      "name": "3.2.1-rc.6",
      "type": "folder",
      "size": 0
    },

@xNok,
Notice that the path returned by the jfrog rt s command also includes both the repo and the file name. The AQL response however is splitter into repo, path and name.  Since JFrog CLI accepts a complete path as part of the commands' arguments and options,  it uses the same convention in the search command's output.
The upcoming release of the JFrog CLI will also include "type" as part of the search command result. The code is already committed into the dev branch, in case you want to try it out already.
Feel free to share with us your thoughts.

Good point, if I understand path is the concatenation of repo, path, and name. May I ask why not do both haveing the concatened path and the infos in the include?
include("name","repo","path","actual_md5","actual_sha1","size","type","property")

In my case the relevant information is the "name", because each folder represent a version of my artifact. So having to parse the path is inconvenient.
The reason I use jfrog rt s is that it is very convenient tu use with a ci tool. While jfrog rt curl must be associated to a script that generate the query.

@xNok,
Sorry for the late response.
Adding your your suggestion is something we can consider, but we may need to be careful not to pack the result of the search command with too much information, which may make the response cumbersome.


Pre-trained model

Can you provide pre-trained models for Cascade Mask RCNN (FPN) with Resnet-152  and ResNeXt-152?

We do not have resources for that. PRs are welcomed.


bowllike, alexandrian

This pull request was generated by the 'mq' tool
[test]
flake rate: 0.4
logical conflict every: 100
sleep for: 300s
[pullrequest]
requests per hour: 30
deps=[a,b]

/trunk merge


Hide wizard commands

Don't show wizard commands to non-wizards in help message.

As a compromise, the "greater" commands were absorbed into their parent commands as checks for wizard status.


determine package manager automatically

Currently, NPM is used to pack external packages. it's hardcoded. we need to automatically determine which NPM or Yarn is used

:tada: This issue has been resolved in version 1.1.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


[macOS][bug] changing the wallpaper restarts the Dock, which is annoying

problem is as described: when the wallpaper is reset, the Dock reloads, causing it to close and open, which is very distracting.
Surely there is a better way of changing the wallpaper than reloading the Dock/Finder?

this may be a bit of a overkill, but maybe use wallpaper?
it takes just one line to change the wallpaper, and does not need you to kill the Dock:
wallpaper path/to/file

is there more than one killall?
I tried replacing that section with:
    elif de == "mac":
        subprocess.call(["wallpaper " + file_path])
        # subprocess.call(["osascript", "-e", 'tell application "System Events"\n'
        #                  'set theDesktops to a reference to every desktop\n'
        #                  'repeat with aDesktop in theDesktops\n'
        #                  'set the picture of aDesktop to \"' + file_path + '"\nend repeat\nend tell'])
        # subprocess.call(["killall", "Dock"])

but the Dock still restarts. mysterious.

is there more than one killall?

No. It's even more mysterious for me as someone who never used a mac. :)
I'll look for a Python module to set the wallpaper, or going to create one as a separate project. The current status seems like a bit of mess and that really bothers me. I thought about using appscript but it's abandoned. Making people install a node.js app for a 300 lines of Python script seems like an overkill.
Thank you so much! I'm keeping this open, in case someone finds a solution.

nevermind, fixed it:
subprocess.call(["wallpaper", file_path])

works. you need to have wallpaper installed. want a PR?

Glad to hear! I'll keep the issue open though, for the problem is still not resolved.

@sg-s @boramalper
wallpaper
It works, but the code only runs once, I have to use code like this to keep it to run every 10 mins. This does not make sense.
        subprocess.call(["osascript", "-e", 'tell application "System Events"\n'
                         'set theDesktops to a reference to every desktop\n'
                         'repeat with aDesktop in theDesktops\n'
                         'set the picture of aDesktop to \"' + file_path + '"\nend repeat\nend tell'])
        #subprocess.call(["killall", "Dock"])
        subprocess.call(["wallpaper", file_path])

this can execute can every 10 mins.

Thanks, but I'm strongly against using wallpaper, maybe I can dig into their source and find how they do it. :)

@hche608
not sure why you're using the AppleScript in addition to wallpaper. To be clear, just this works:
subprocess.call(["wallpaper", file_path])

@boramalper agreed; the simpler the better!

Hey guys, was on vacation when this was happening!  So as I commented when I added that line:
https://github.com/jcmiller11/himawaripy/commit/8fc30136f5d7cce418cb1eb9ea1a4f678381dd51
The killing of the dock is to stop a problem where OS X would cache the wallpaper in RAM and not check to see if the picture file had changed given that it was using the same filename each time.  It was kind of a hacky solution but it works.  A more elegant solution might be to make the filename of the latest downloaded image be unique each time, I believe that would work, but I didn't pursue that method at the time because I didn't want to mess with too much of the non-platform specific stuff just to get OS X support up and going.

It's been a long time since I touched all of this code, and it's all coming back to me solving this problem when I first added that killall line.  We can add code to the main system to do something like timestamps for a unique filename to partially solve the problem of the picture update only working occasionally, but then we need to deal with a more complex cleanup system to remove them later... which only solves the problem if the user is not in full screen... or we can just kill the dock, which is also inconvenient... particularly if the user makes use of some window management systems in OS X like minimizing....
Kinda sucks but I couldn't find a perfect solution :/ so I just went with the scorched earth approach by just killing the process

how bad would it be to use unique filenames on macOS? you could even use random file names -- i agree it is clunky but that seems to be the only reasonable way

would have to add in some whole way to store the name of the last file to delete, destroying the simplicity of relying on each native filesystem to overwrite the file, would most easily be implemented outside of the environment specific code, still wouldn't totally solve the problem.  I'll wait for @boramalper to weigh in on this

I think we can append the date in the file name. Then we'll delete the last image, and save the new one.
Since himawaripy is using appdirs to save images in its own dedicated directory, we can check if there is only one .png file with the prefix himawaripy- in that directory, we can delete that image and save the latest one; if not, we will exit the program to prevent any accidental data loss.
I'm really busy this week, but I'll try to implement it as soon as possible afterwards. :) Thank you all for your contribution!

how about a cruder approach?

delete all .png files with the prefix "himawaripy" in the target folder
download the new image, save it with a random name (or timestamp)
set wallpaper (since filenames are now unique, it should work)

repeat

@sg-s Why cruder? The only difference (checking whether there are more than one .png file to be deleted) is very very simple to implement (just checking the length of the results) yet can save us from a possible catastrophe. Given that how many things went wrong with this intended-to-be-small-script, I'm really hesitant of crude approaches. :)

Agreed, any script that deletes a file should do so very judiciously as a small bug can be catastrophic, for example: https://github.com/MrMEEE/bumblebee-Old-and-abbandoned/issues/123
Using a random name might necessitate an extra check for the very small chance of a collision lest one in a million updates fail to display for mac users, lol.  I think @boramalper 's proposed solution is the best choice.

This commit should resolve the issue. Can you confirm @sg-s?

HI @boramalper, thanks! I think you forgot to remove this line:
subprocess.call(["killall", "Dock"])

in utils.py
I removed it, and it looks like it's working! Awesome!

@sg-s Fixed. Thank you all so much!


change the config classes from using static values to classes that are to be initialized

this will make editing and creating new config files much more convenient

i think the new json system counts


[CWS] do not replay snapshot for all consumers

What does this PR do?
Replay snapshot on ruleset_loaded event only for CWS. Before this PR, every ruleset_loaded was triggering a replay of the snapshot causing the consumer to be notified.
Motivation
Describe how to test/QA your changes
Possible Drawbacks / Trade-offs
Additional Notes

shouldn't we remove the PlaySnapshot method from the other probe_platform.go files also ? if it's no longer needed in probe.go ?

shouldn't we remove the PlaySnapshot method from the other probe_platform.go files also ? if it's no longer needed in probe.go ?

done

/merge


#287: Use Link-to-Web resource kind from ArkLib

Description
Related to https://github.com/ark-builders/arklib/issues/10

Issue #287 should be fixed by this PR (it is caused by inconsistency of writer in Shelf and reader in Navigator).
If it is solved indeed, PR #288 will be canceled (which makes reader code tolerable to unknown keys).


Support searching in header scope

Allowing the validator to search in the header request ( headers as alias ).
cc @buunguyen

Fixed PR. I totally agree with your feedbacks. Many thanks, @buunguyen

Looks good, thanks for working on this.


Force torque sensor plugin not detecting wrench

Environment

OS Version: Ubuntu 24.04
Source or binary build?
Binary Gazebo Harmonic 8.5.0

Description

Behavior: I include a force torque system plugin in a xacro file  in the following way:

<gazebo reference="${prefix}fts_link_joint">
    <sensor type="force_torque" name="force_torque">
        <update_rate>30.0</update_rate>
        <always_on>true</always_on>
        <visualize>true</visualize>
        <topic>ft_sensor/wrench</topic>
        <force_torque name="ati_axia">
        </force_torque>
        <plugin
          filename="gz-sim-forcetorque-system"
          name="gz::sim::systems::ForceTorque">
        </plugin>
    </sensor>
</gazebo>

I run the simulation, in which the link of the sensor (associated with a mesh, both visual and collision) is attached to a robot through a joint. If the sensor has a physical contact with an object directly, the measured wrench has a reasonable value. If I add a link of an end-effector (associated with a mesh, both visual and collision), attached to the sensor with a fixed joint, and this end-effector has the contact with the object, and the ft sensor is not in contact with the object directly, the ft sensor does not measure any wrench.
How should I solve it?

Thanks for the issue, but this is a type of question that is best asked on https://robotics.stackexchange.com/. I encourage you to post your question there and if you find that there's a specific bug or feature request, come back and create a new issue here. In the mean time, I'll go ahead and close this.


Removing ineffective graceful shutdown code

What this PR does / why we need it: This PR removes the preStop lifecycle hook intended for graceful shutdown, because is actually killing both the agent and the job immediately. The default behaviour of the terminationGracePeriodSeconds variable is already taking care of gracefully shutting down the pods.
The  code for tini only forwards the signals to the process which it specifically starts, not all children processes.
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[ x] Chart Version bumped

CC @jim-barber-he for visibility. As David says, we discovered that pidof buildkite-agent was outputting the pid of both the agent and the job, so the kill -s SIGTERM was killing both. But not sure if you were relying on this somehow, so figured I'd ping you since it's new code :)

I haven't tested this, but it sounds plausible to me. A kube-standard SIGTERM to the main agent process should be enough to start a graceful shutdown where the currently running job is allowed to finish, and then the agent terminates instead of accepting a new job. Assuming terminationGracePeriodSeconds is long enough for that running job to complete.
I'll defer to @rimusz for a proper review though - he's more across the helm chart plans than me :heart:

I would suggest to keep it and make it optional, off be default :-)

Thanks @amukherjeetwilio
It's possible my addition of the terminationGracePeriodSeconds was all that was needed to stop jobs from being killed if the init/tini process is already doing the right thing.
If so then removing the lifecycle is cleaner.
@rimusz I say take this change as is, and if I start seeing problems in our environment with the new chart I can always re-introduce the lifecycle behind a new flag to toggle it on.
It is interesting that the change I made as it stands fixed our problems, while for you, you're seeing jobs get killed.
It's definitely plausible that pidof is matching child processes, but in our case they didn't seem to get killed...
However having pidof matching the child processes isn't the behaviour I intended.

One thing that's different in our environment is that, for our internal compliance reasons, we have to repackage the buildkite-agent binary and leverage the relevant bits to use our own image. We've tried to keep our image as similar to the official one as we can but maybe there's a discrepancy in busybox version? But they look the same at a quick test:
❯ docker run --rm -it --entrypoint busybox buildkite/agent pidof --version
pidof: unrecognized option: version
BusyBox v1.31.1 () multi-call binary.

Usage: pidof [OPTIONS] [NAME]...

List PIDs of all processes with names that match NAMEs

        -s      Show only one PID
        -o PID  Omit given pid
                Use %PPID to omit pid of pidof's parent

❯ docker run --rm -it --entrypoint busybox <OUR_AGENT_IMAGE> pidof --version
pidof: unrecognized option: version
BusyBox v1.31.1 () multi-call binary.

Usage: pidof [OPTIONS] [NAME]...

List PIDs of all processes with names that match NAMEs

        -s      Show only one PID
        -o PID  Omit given pid
                Use %PPID to omit pid of pidof's parent

Hey! Ignore the change in name -- combining work and play github account :P. But that aside, just wanted to ping on this if there's something we can do to move this forward? Is there something we should change in this pull request?

Hey! Just following up on this. Anything you need from us to land this? Thanks!

Hey! Just following up on this. Anything you need from us to land this? Thanks!

@abhishekmukherg just make the flag optional, and in the future when we see no issues we can enable flag by default, and later on remove the flag.

I've implemented the request in #89

I finally upgraded the chart from 0.5.2 to 0.6.0 (yes long overdue)
And now I'm finding that my agents are being killed prematurely again (agent lost error in the GUI).
So for whatever reason, the preStop lifecycle was stopping our agents from shutting down while they were running jobs.
So I might have to revisit this... Perhaps provide a way to allow us to provide an optional configurable lifecycle hook or something.

Ahh I see that https://github.com/buildkite/charts/pull/89/files has implemented it. Cool. I'll look at changing our configuration then.

That is quite confusing to me, for what it's worth. Do y'all use a different entrypoint for your container?

We aren't using the Alpine based image that Buildkite has produced.
We use debian:bullseye-slim and install a bunch of tools.
Then we do this:
RUN useradd -s /bin/bash buildkite \
    && mkdir -p /buildkite/builds /buildkite/hooks /buildkite/plugins ~buildkite/.ssh \
    && chown -R buildkite:buildkite /buildkite/builds /buildkite/plugins ~buildkite

# Configure Buildkite specific contents.
COPY --from=buildkite/agent:3.39.1 /usr/local/bin/* /usr/local/bin/
COPY --from=buildkite/agent:3.39.1 /buildkite/buildkite-agent.cfg /buildkite/
ENV BUILDKITE_AGENT_CONFIG=/buildkite/buildkite-agent.cfg

USER buildkite

ENTRYPOINT ["buildkite-agent-entrypoint"]
CMD ["start"]

So still using Buildkite's tools and entrypoint, but on a different base OS.


[Feature request] Parse 0 1 as bool

Sometimes it would be useful to parse 0 1 int as bool.

To me that is a little wearied as json has a bool data type, and some languages don't treat 0 or 1 as true and false see https://www.quora.com/Is-1-true-and-0-false-in-programming .
But you get the data you get... so there are always hooks, you can use this to override on how to parse bools:
type ActiveEntry = object
  active: bool

let activeJson = """{
 "active": 1
}"""

proc parseHook(s: string, i: var int, v: var bool) =
  var tmpInt: int
  parseHook(s, i, tmpInt)
  v = tmpInt == 1

let activeEntry = activeJson.fromJson(ActiveEntry)
echo activeEntry.active

Thank you for the reply and hook example.
it would be useful to have all the hooks bundled together somewhere (examples?).

Thank you for the reply and hook example. it would be useful to have all the hooks (for the dates, timestamps etc) bundled together somewhere (examples/?).

I agree, there are a few of these useful hooks floating around.

I am going to close this as I think this is best done with a parseHook by the user code.


GPG Key no longer valid for RPMS

Describe the Bug
Postgres org changed all the GPG keys as of January 3rd, so the Postgres module is no longer able to install Postgres on some centos based platforms.
e.g.
The GPG keys listed for the "PostgreSQL 11 7 - x86_64" repository are already installed but they are not correct for this package.
Check that the correct key URLs are configured for this repository.

See https://yum.postgresql.org/news/pgdg-rpm-repo-gpg-key-update/
Expected Behavior
GPG key validation works.
Steps to Reproduce
Attempt to install postgres on a centos7 system, using the module.  Note the above failure.
Environment

Platform centos7, redhat 7, redhat 8, almalinux8, rocky8

I believe this needs to be updated:  https://github.com/puppetlabs/puppetlabs-postgresql/blob/010ed69eef927200d9058f9e5a3e00442bfa86d8/files/RPM-GPG-KEY-PGDG

On my environment, I fixed it with the changes available in PR1566. Can you check ?

Thanks!  I'm trying to validate it now.


Source with extra EPG information

Hi,
Im looking to create an .xml file for tv24.se (there is also a UK counterpart tv24.co.uk)  but I'm not elite enough to create the config file etc. I've previously contributed to the XML for tv.nu and allente.se.
I've noticed that the source tv24.se and tv24.co.uk provides a lot of nice extra EPG information. Such as "LIVE", "NEW" and movie logo for movies. There is also a second title row with the IMDB film genre and rating for movies, and for live events it provides teams competing.
Have a look here:
www.tv24.se
or
www.tv24.co.uk
for example Live Event:
Title row: Fotboll: FA-cupen
Secondary title row: Manchester United - Middlesbrough
for example Movie:
Title row:Wind River
Secondary title row: Kriminaldrama (2017)7.7
Then there is the normal description of the movie or game with the plot or summary as any other epg.
I've found that the " "LIVE", "NEW" and movie logo for movies are possible. At least in Tivimate app.
Here is one user on reddit that has it:
https://www.reddit.com/r/TiviMate/comments/vi7kh6/feature/
(does not include the secondary title row)
I would also like the secondary title row to be included since usually, the tile is "FA-Cup", "Champions League" or similar, which does not state the teams playing the game. This would be really nice to be able to see.
As previously stated, I'm capable to create the XML file with guidelines.
Anybody with the knowledge to let me know if this is possible, and if so if they are willing to help out with the config file etc.?

You could use the attribute sub_title for the secondary title row and icon for the image.
Since the XML is created once each day, there is no point in including the tag LIVE in the programme, as it should be handled later by the IPTV player.
As regards the NEW tag, it could be added since the attribute new exist in the xmltv.dtd standard

The guide from tv24.se is now available at:
https://iptv-org.github.io/epg/guides/se/tv24.se.epg.xml.gz

and tv24.co.uk at:
https://iptv-org.github.io/epg/guides/uk/tv24.co.uk.epg.xml.gz


feat(natds-icons): add icons

DSY-2452
Description

filled-action-privacy
filled-action-register
filled-content-violence
filled-product-fashion
outlined-action-privacy
outlined-action-register
outlined-avon-desenvolve
outlined-content-violence
outlined-product-fashion

[update regression]


App closes after launch

When launching the app on a H Series TV it is possible to configure the server by entering its IP address. A network message of "hello" is then displayed, after which the application exits.
JellyFin Version <IP_ADDRESS>
TV Model: UE48H6400
Software Version: T-MST14DEUC-2880.2, BT - S/G

How do you solved?


Add -Wconversion and fix the releated conversion issues

@zlatinski Can you give a glance to this PR. It allows to avoid non regression when we change something vulkan-video-samples. I had the issue today again with CTS bots failing because of Vulkan-Video-Samples.
This is quite a big change but necessary.


Support ESP8266

Released in https://github.com/adafruit/Adafruit_Wippersnapper_Arduino/releases/tag/1.0.0-beta.24, closing!!

awweeeesome!


[Firestore] Collection group queries with document ID in where clause

I need to use the document ID in a where clause of a collection group query.
In my case I use the user ID for document IDs on different levels. So in my firestore I have documents placed at /rooms/{room ID}/joinedUsers/{userID}/ and I want to find all the rooms where the user with a given userID is joined by doing collection group query like this:
db.collectionGroup("joinedUsers").joinedUsersGroup.where(FieldPath.documentId(), "==", userID)
That gives an error "When querying a collection group and ordering by FieldPath.documentId(), the corresponding value must result in a valid document path, but 'XF0c0r4iTYQjJHA0xhUgaZNvffzB' is not because it contains an odd number of segments."
I have read elsewhere that the userID should be a full path, which in 99% of real-life use cases will include an unknown document as a parent (roomID in my case) because that is the purpose of collection group queries. Using the full path of the document defeats that purpose.

Cloud Firestore support is provided by the @google-cloud/firestore library. Therefore the easiest and most efficient way to get Firestore issues resolved is by directly reporting them at the nodejs-firestore GitHub repo.
Please use Stack Overflow for usage questions. Thanks!


facing xxx.live.dynatrace.com/linux/oneagent: tag invalid: No bootstrapping-image

Dear team,
when deploying oneagent daemonset on openshift 4.8 , getting below error

describe pod output -
Warning  Failed     130m (x4 over 131m)     kubelet            Failed to pull image "xxxxxx.live.dynatrace.com/linux/oneagent:latest": rpc error: code = Unknown desc = Error reading manifest latest in xxxxx.live.dynatrace.com/linux/oneagent: tag invalid: No bootstrapping-image found for version: <IP_ADDRESS>20218-231302
Warning  Failed     130m (x4 over 131m)     kubelet            Error: ErrImagePull
Warning  Failed     129m (x6 over 131m)     kubelet            Error: ImagePullBackOff
Normal   BackOff    2m19s (x562 over 131m)  kubelet            Back-off pulling image

pod logs -
Error from server (BadRequest): container "dynatrace-oneagent" in pod "dynakube-oneagent-4w2nf" is waiting to start: trying and failing to pull image
please help or advise.

Hi, you can try to pull that image from one of your nodes like described here: https://www.dynatrace.com/support/help/setup-and-configuration/setup-on-container-platforms/kubernetes/store-dynatrace-images-in-private-registries-kubernetes
If that is not working I would suggest to open a ticket at our official support as this is something, which probably has to do with your cluster setup: https://support.dynatrace.com/


openroad build can't find_package(Qt5)

cmake ..
indicates that Qt5 can't be found; tho Qt5 and qtcreator are working fine.
There is no findqt5.cmake but there is a findqt4.cmake from a previous install.
research indicates that qt5 no longer uses findxxx.cmake.
Is there a way to force the build to create a gui version, maybe using
the qtpaths shell command?

What version of cmake do you have?  Is your qt 5in the default location?

The failure of cmake to build a GUI version is 100 % caused by
find_packages(Qt5) is return the paths(s).
I used cmake version 3.18.4 on Debian 11 (bullseye).
I will rebuild the entire tree on an Ubuntu 20.04.4 version and
see if the problem is resolved.
Thanks
Warren

Where is your QT installed?  If it is in a non-default location it may be that find_packages can't find it.


No sign in UI presented with brew cask install on Big Sur 11.2

Describe the bug
No sign in UI is presented
To Reproduce
Steps to reproduce the behavior:
Click to install an XCode, no sign in UI is presented, error alert is immediately displayed.
Expected behavior
A clear and concise description of what you expected to happen.
Some UI affordance to sign into Apple Developer Portal should appear
Screenshots
If applicable, add screenshots to help explain your problem.

Version

OS: Big Sur 11.2
Xcodes: brew cask install

Hi @drmarkpowell
Thanks for the ticket. I'm going to close this in favour of tracking it in #22
It's a known issue and it's not dependent on which way you install it from.
Thanks for letting is know and trying Xcodes!


Signature in unlock script fails to validate

This was observed when sending txs from faucet to a live node. The node rejects txs due to failed unlock script validation.
Info [agora.node.Ledger] - Rejected tx. Reason: LockType.Key signature in unlock script failed validation. Tx: { type: TxType.Payment, inputs : [{ utxo: 0x915d35...

Isn't this a Faucet issue?

It looks like Faucet is using ba0575a55f722c7d3a1cca90630475a652aec39d in v0.x.x. Have you tried updating the agora submodule?

Isn't this a Faucet issue?

Yes, so it should probably be moved..

Resolved by faucet#36.


Satisfy new linter warnings

Linter started giving new warnings on Python 3.9, let's make it happy
again.

Thank you so much for finally resolving it!


HELP: how to access a particular parsys in a page.

We have created a page and dragged container component in the main parsys.
Now the page have 2 parsys because container has a parsys within. Now we need to edit container component which has data path as below.
Child Parsys: added by the below parsys: /test/jcr:content/bodypar/container
Main Parsys: used to add  the above container parsys :  /test/jcr:content/bodypar/*
 page.configureComponent("/bodypar/container", COMPONENT_NAME, "container_demo");
Log:
throws null point exceptions. <java.lang.NullPointerException: null 	at com.cognifide.qa.bb.aem.touch.data.components.Components.getDataPath(Components.java:45) 	at com.cognifide.qa.bb.aem.touch.pageobjects.touchui.Parsys.getComponent(Parsys.java:104) 	at com.cognifide.qa.bb.frame.FrameAspect.switchFrameAndProceed(FrameAspect.java:70) 	at com.cognifide.qa.bb.frame.FrameAspect.invoke(FrameAspect.java:58) 	at com.cognifide.qa.bb.aem.touch.pageobjects.touchui.Parsys.configureComponent(Parsys.java:157) 	at com.cognifide.qa.bb.frame.FrameAspect.switchFrameAndProceed(FrameAspect.java:70) 	at com.cognifide.qa.bb.frame.FrameAspect.invoke(FrameAspect.java:58) 	at com.cognifide.qa.bb.aem.touch.pageobjects.pages.AuthorPage.configureComponent(AuthorPage.java:196) 	at com.cognifide.qa.bb.frame.FrameAspect.switchFrameAndProceed(FrameAspect.java:70) 	at com.cognifide.qa.bb.frame.FrameAspect.invoke(FrameAspect.java:58)>

Hi @DeChrish,
what version of AEM are you working with?
The NullPointerException in the log you sent suggests that description of your component is missing from 'component-descriptions.yaml' (documentation here ), namely in your case something like:
...
COMPONENT_NAME:
    datapath: /container
    clazz: <page-object-of-your-component>
...

Please note that the container components were not extensively used and tested with current TouchUI module - let us know if the above helps.

Hi @mkrzyzanowski i will try and get the feedback.

Closing this for now, if you have any update, please let us know.

Hi @DeChrish, I need help in using the configureComponent function. I am consistently facing YAML could not be read. https://github.com/Cognifide/bobcat/issues/241.
I am trying to configure a simple component with dialog fields supported by the framework. I am not able to identify what kind of mistake that I am doing.


remove unused bin/ CLI interface

Is the CLI interface created in thebin/ directory used anywhere? It seems like it's existed since the early days of this repo, but it doesn't look like its ever been registered as a bin command in package.json.
/cc @rictic @azakus Safe to remove?

I don't have enough context to say on this one either way. Leaving to @azakus to review.

Oh, there is at least one user for it. Can you just add it as a binary in the package.json instead?

After in person discussion, we're going to leave the file and add a comment in bin/css-slam about its current use.

@azakus ptal


Fixes #140787 watches proper worktree dir

This PR fixes #140787
/cc @lszomoru

Supporting worktree was never done: #68038
Is this the only piece missing to support worktrees, or are we opening a door here that will just spawn more issues due to the lack of support of worktrees?

I'm not sure what the issue is with #68038 -- it works fine for me.
I won't say this is the only missing piece, but it's the only thing I've seen so far with using worktrees and GitLens upcoming worktree features.


Docs: Update readme to mention this is not available for >10.15

Title.  Am running Mojave and cannot use this screensaver.
P.S., found this repo here and I think it's very cool.  I have starred it to get you closer to cask!

Does not work on Big Sur either

@jakewilliami @cmhdave I will have a look on these, probably I need to update the configuration to support big sur.

@cmhdave It does work on Big Sur, but you will need to compile the project so far I am concerned.

Sorted!


add documentation for exposing conatiner ports. closes #726

I've added a working example on how to expose a container port to the Host-Interface / Internet. this closes #726

Hi Thomas,
Thanks for applying the updates.  Sorry to ask this as well - but I was wondering if you had signed the contributors agreement (it's a very lightweight form just covering legalities confirming that you retain ownership of your contributions and that you are licensing them to us.)
We are about to add a CONTRIBUTING.md to the repo, which provides the following instructions.

All individuals (except employees of the U.S. government – see below) should
sign the Individual Contributor License Agreement.
If you are contributing on behalf of a company or organization, you still
need to sign the Individual Contributor License Agreement as above, but
someone at your company or organization also needs to sign the
Corporate Contributor License Agreement
providing a list of people authorized to commit code to Project Calico.
Employees of the U.S. government do not sign the Individual Contributor
License Agreement.  Instead, someone with authority to sign on behalf of your
agency should sign the U.S Government Contributor License Agreement.

Would it be possible for you to sign the appropriate e-forms?  Thanks!  Rob

done

This is definitely a useful addition to the docs. Thank you for your contribution, we really appreciate it.
I've added several comments and suggestions to the doc.  Let me know when you've made the edits and I can take another look so we can get this in ASAP!

Hi @ThomasLohner,
Just checking in to see if you've noticed my comments.  Let me know your thoughts!

Hi @ThomasLohner,
We really appreciate you adding this PR doc contribution.  I'm going to merge this now and make some of the text fixups after it's merged.  You've done the hard work of writing up the doc already, so we'll handle some of the nitty-gritty pieces on our side.
Thanks again!


Support data pages for our most important metrics

Work out what basic automation is needed, and help data managers where they get stuck.

This is pretty much done. There's only one hanging PR (non-urgent).

Let's close this one then.


Memory leak found with RSA method

The default RSA method calls static rsa_ossl_finish to free BN_MONT_CTX_free objects.
If neverbleed RSA method is used, this function is not called, thus these objects are leaked.
The proposed fix is https://github.com/tatsuhiro-t/neverbleed/commit/003de52b35add6a9ff157d06b0f9ffda8586df34

Note that I found this memory leak when I run TLS client.  I'm not sure server is also affected.

Thank for reporting the issue as well as providing a fix.
Yeah I think this would be an issue on the server-side as well, if the server discards RSA keys while running.


Added test coverage for backends' sql_flush() operation.

I wonder if it would be better to write a backend agnostic test that executes the provided SQL and ensures tables are flushed and sequences are reset. I'm not sure there's a lot of values in asserting against the exact SQL generated after we offer no stability guarantees in this regard.

I wonder if it would be better to write a backend agnostic test that executes the provided SQL and ensures tables are flushed and sequences are reset.

I can work towards that.

I'm not sure there's a lot of values in asserting against the exact SQL generated since we offer no stability guarantees in this regard.

I think it provides value. It shows exactly (modulo some ordering) the output of the function. We can inspect this output directly to ensure the commands that we expect to render, are returned. A change that unexpectedly changes these statements -- perhaps causing a regression -- will be noticed.
One of the motivations of this PR is that I would like to change PostgreSQL sql_flush() so co change the sequence resetting logic from multiple SQL statements to use the RESTART IDENTITY keyword of the TRUNCATE statement. My project uses flush operation internally and some profiling shows that it can consume a large percentage of the runtime. As these functions have minimal test coverage so far, this test adds a minimal base level of assurance before any changes take place. Asserting the function's exact return value will show me that my upcoming change to use RESTART IDENTITY was implemented.
I do agree there is additional value in executing the SQL as well. I think they would complement one another.

Buildbot, test on Oracle.

buildbot, test on oracle.

change the sequence resetting logic from multiple SQL statements to use the RESTART IDENTITY keyword of the TRUNCATE statement.

Oh I looked at it as well while helping with the MySQL adjustments that took place in this area but I assumed it was only working with identity columns and thus was blocked by #30511. I must have misread the PostgreSQL documentation.
I see, I don't see much harm in testing the exact SQL in this case.

write a backend agnostic test that executes the provided SQL and ensures tables are flushed and sequences are reset.

:+1: I added ExecuteSqlFlushTests for this.


Runtime localization not working

I am not able to change my localization at run time even after following your guidance.
language changes after running the app from killing state with new launch at that time my language gets changed.
i am not getting why it is not working even after adding observer to the view controller?

show your code:

When you change language
Observer and method where you handle notification

I have resolved this issue by my own there was some mistake in localizing the text with a small change of .localized() method in View Controller i am now able to change the language thank you.


Translate Error boundaries

Translated error boundaries.
Please feel free to review and comment.

@alioguzhan I've pushed the changes, FYI.

Thanks for the translation. Merging it...


Set up snapshot.js

Set up the snapshot .js  in scaffold eth.
Tasks:
-create a proposal

Resources: https://docs.snapshot.org/snapshot.js

Schema of proposed architecture for the beta version https://miro.com/app/board/uXjVOa0Gg8A=/?invite_link_id=366354947106

What do you mean by "set up snapshot.js in scaffold eth"? Do you want an interface that allows people to create unique proposals or do you want a function that creates the same proposal? @giorgosn

When I say set up with snapshot I mean 3 things.
First there is a need to get notifications when a proposal is created and ended.
------This implementation need to take allready code of the repository ( forked of scaffold-eth) and set up the webhooks that are needed to listen to this events (https://docs.snapshot.org/webhooks)
Second there is the need to get all the data of the proposal based on the GraphQL API (https://docs.snapshot.org/graphql-api)
------This will be done on the same project.
Third create a prososal. This will be done by https://docs.snapshot.org/snapshot.js


MAINT: Revert #7318

Reverts #7318.
This will fail without the changes in #7325, but I at least want to see if the 3D viz tests run faster so we can avoid Travis timeouts.

Seems to be about a minute and a half faster, based on just comparing a couple of runs. Let me know if you think this makes sense @GuillaumeFavelier

@larsoner you're totally right, depth peeling is disabled in the pyvista 3d backend but a posteriori which means that testing for depth peeling is still done and disabled only afterwards. There is another way to disable depth peeling without using master which is using directly rcParams. If you don't mind, I'll open a PR to take care of that

Yes please do


fix datetime_to_numeric and Variable._to_numeric

[x] Closes #2667
[x] Tests added
[x] Fully documented, including whats-new.rst for all changes and api.rst for new API

Started to fixing #2667

@spencerkclark
Sorry for leaving it for a long time.
I was a little stressed these days...

Should we strive to have compatibility in datetime_to_numeric there?

As I'm not a heavy user of datetime arrays, I personally do not mind if we do not have dask compatibility for datetime_to_numeric.
Probably it would be OK to leave it for the later development if someone wants this feature.

As I'm not a heavy user of datetime arrays, I personally do not mind if we do not have dask compatibility for datetime_to_numeric.

No worries @fujiisoup, this is totally fine with me.  I think the most common use case for datetime arrays is in indexes, which currently need to be stored in memory anyway, so I don't think the dask use case would come up very often.

Thanks @spencerkclark for reviewing. Merged.

Thanks for wrapping this up @fujiisoup!


RecursionError: maximum recursion depth exceeded while decoding a JSON array from a unicode string

Hi All,
I'm starting with ChatterBot and so I've followed the doc. - http://chatterbot.readthedocs.io/en/latest/training.html#set-trainer.
Unfortunatelly I failed in very begginig:
from chatterbot.training.trainers import ListTrainer
chatterbot = ChatBot("Training Example")
chatterbot.set_trainer(ListTrainer)
chatterbot.train([
"How are you?",
"I am good.",
"That is good to hear.",
"Thank you",
"You are welcome.",
])
I've got:
Traceback (most recent call last):
File "createJson.py", line 52, in
u"You are welcome.",
File "/home/ms/sataData/Progr/python/jarvis/virtualenv/boot/lib/python3.5/site-packages/chatterbot/training/trainers.py", line 36, in train
self.storage.update(statement)
File "/home/ms/sataData/Progr/python/jarvis/virtualenv/boot/lib/python3.5/site-packages/chatterbot/adapters/storage/jsondatabase.py", line 126, in update
self.database.data(key=statement.text, value=data)
File "/home/ms/sataData/Progr/python/jarvis/virtualenv/boot/lib/python3.5/site-packages/jsondb/db.py", line 76, in data
self._set_content(key, value)
File "/home/ms/sataData/Progr/python/jarvis/virtualenv/boot/lib/python3.5/site-packages/jsondb/db.py", line 37, in _set_content
obj = self._get_content()
File "/home/ms/sataData/Progr/python/jarvis/virtualenv/boot/lib/python3.5/site-packages/jsondb/db.py", line 26, in _get_content
obj = read_data(self.path)
File "/home/ms/sataData/Progr/python/jarvis/virtualenv/boot/lib/python3.5/site-packages/jsondb/file_writer.py", line 11, in read_data
obj = decode(content)
File "/home/ms/sataData/Progr/python/jarvis/virtualenv/boot/lib/python3.5/site-packages/jsondb/compat.py", line 22, in decode
return json_decode(value)
File "/usr/lib/python3.5/json/init.py", line 319, in loads
return _default_decoder.decode(s)
File "/usr/lib/python3.5/json/decoder.py", line 339, in decode
obj, end = self.raw_decode(s, idx=_w(s, 0).end())
File "/usr/lib/python3.5/json/decoder.py", line 355, in raw_decode
obj, end = self.scan_once(s, idx)
RecursionError: maximum recursion depth exceeded while decoding a JSON array from a unicode string
Any help is highly approciated.
Thank you.

])
Please let me know if that was helpful

@mbarisa : I've tried also withou the colon, but the result is the same. Looks like some deep issue in JSON and how it parse or handle string into array. Didn't have time to go to deep.
File "createJson.py", line 52, in
u"You are welcome."
File "/home/ms/sataData/Progr/python/jarvis/virtualenv/boot/lib/python3.5/site-packages/chatterbot/training/trainers.py", line 36, in train
self.storage.update(statement)
File "/home/ms/sataData/Progr/python/jarvis/virtualenv/boot/lib/python3.5/site-packages/chatterbot/adapters/storage/jsondatabase.py", line 126, in update
self.database.data(key=statement.text, value=data)
File "/home/ms/sataData/Progr/python/jarvis/virtualenv/boot/lib/python3.5/site-packages/jsondb/db.py", line 76, in data
self._set_content(key, value)
File "/home/ms/sataData/Progr/python/jarvis/virtualenv/boot/lib/python3.5/site-packages/jsondb/db.py", line 37, in _set_content
obj = self._get_content()
File "/home/ms/sataData/Progr/python/jarvis/virtualenv/boot/lib/python3.5/site-packages/jsondb/db.py", line 26, in _get_content
obj = read_data(self.path)
File "/home/ms/sataData/Progr/python/jarvis/virtualenv/boot/lib/python3.5/site-packages/jsondb/file_writer.py", line 11, in read_data
obj = decode(content)
File "/home/ms/sataData/Progr/python/jarvis/virtualenv/boot/lib/python3.5/site-packages/jsondb/compat.py", line 22, in decode
return json_decode(value)
File "/usr/lib/python3.5/json/init.py", line 319, in loads
return _default_decoder.decode(s)
File "/usr/lib/python3.5/json/decoder.py", line 339, in decode
obj, end = self.raw_decode(s, idx=_w(s, 0).end())
File "/usr/lib/python3.5/json/decoder.py", line 355, in raw_decode
obj, end = self.scan_once(s, idx)
RecursionError: maximum recursion depth exceeded while decoding a JSON array from a unicode string

Hi @z4nD4R, I cannot replicate your issue with the code you posted. I'm going to close this issue off for now, but feel free to reopen it if you continue to run into the problem.


Add route for deleting token pools

This allows deleting any token pool, regardless of gateway or multiparty mode, along with all associated token transfers, balances, and approvals.
Note that in multiparty mode, if you delete a token pool that was broadcast to the network, you will be voluntarily out of sync with other nodes.
This represents the simplest implementation of (4) from https://github.com/hyperledger/firefly/issues/1220#issuecomment-1496422542, in the context of token pools only.
Note that this does not purge event listeners from the token connector (events will just be ignored). Probably need to find a way to delete them though.

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@22bde98). Click here to learn what that means.
The diff coverage is 4.68%.

@@           Coverage Diff           @@
##             main    #1262   +/-   ##
=======================================
  Coverage        ?   99.69%
=======================================
  Files           ?      309
  Lines           ?    20619
  Branches        ?        0
=======================================
  Hits            ?    20556
  Misses          ?       62
  Partials        ?        1

Impacted Files
Coverage Δ

internal/apiserver/routes.go
100.00% <ø> (ø)

internal/assets/manager.go
100.00% <ø> (ø)

internal/assets/token_pool.go
90.47% <0.00%> (ø)

internal/database/sqlcommon/tokenapproval_sql.go
92.54% <0.00%> (ø)

internal/database/sqlcommon/tokenbalance_sql.go
92.63% <0.00%> (ø)

internal/database/sqlcommon/tokenpool_sql.go
92.12% <0.00%> (ø)

internal/database/sqlcommon/tokentransfer_sql.go
91.94% <0.00%> (ø)

internal/apiserver/route_delete_token_pool.go
100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Merged into #1261


Missing Mempool Transactions

Dupe: https://github.com/CounterpartyXCP/counterparty-core/issues/2353


[AzurePolicy] Migrate to track 2 SDK

Description
This PR upgrades the azure-mgmt-policyinsights library to version 1.0.0, which is the new track 2 management plane SDK.
Changes in Track 2 SDK:

QueryFailureException has been removed. The SDK now throws QueryFailure instead.
Most client APIs exposed by the SDK now start with begin_.
Paging in the SDK is updated to use azure.core.paging.ItemPaged.

Testing Guide
History Notes

This checklist is used to make sure that common guidelines for a pull request are followed.

[x] The PR title and description has followed the guideline in Submitting Pull Requests.

[x] I adhere to the Command Guidelines.

[x] I adhere to the Error Handling Guidelines.

AzurePolicy

LGTM


Add Seq.chunkBySize docs

This PR adds documentation for the Seq.chunkBySize function.

:warning: Validation status: warnings

File
Status
Preview URL
Details

docs/conceptual/collections.seq-module-[fsharp].md
:warning:Warning

Details

docs/conceptual/seq.chunkbysize['t]-function-[fsharp].md
:white_check_mark:Succeeded

docs/conceptual/snippets/fssequences/snippet66.fs
:white_check_mark:Succeeded

docs/conceptual/collections.seq-module-[fsharp].md

Line 44: [Warning] Invalid file link:(~/seq.chunkBySize['t%5D-function-%5Bfsharp%5D.md).
Line 48: [Warning] Invalid file link:(~/seq.contains['t%5D-function-%5Bfsharp%5D.md).
Line 95: [Warning] Invalid file link:(~/seq.tail['t%5D-function-%5Bfsharp%5D.md).

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:warning: Validation status: warnings

File
Status
Preview URL
Details

docs/conceptual/collections.seq-module-[fsharp].md
:warning:Warning

Details

docs/conceptual/seq.chunkbysize['t]-function-[fsharp].md
:white_check_mark:Succeeded

docs/conceptual/snippets/fssequences/snippet66.fs
:white_check_mark:Succeeded

docs/conceptual/collections.seq-module-[fsharp].md

Line 44: [Warning] Invalid file link:(~/seq.chunkBySize['t%5D-function-%5Bfsharp%5D.md).
Line 48: [Warning] Invalid file link:(~/seq.contains['t%5D-function-%5Bfsharp%5D.md).
Line 95: [Warning] Invalid file link:(~/seq.tail['t%5D-function-%5Bfsharp%5D.md).

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

LGTM


Change AWS EC2 intel module to consume query results during ingestion.

See issue #170

@gleentea Please give this a try

@achantavy Thank you for your commit, the problem was solved in my environment.


few extra papers + ordering by date

also avoided linking directly to the PDFs when possible -- there seems to be some consensus around this being the preferred approach


Add issue templates

Hello:)
This repo is missing the issue templates.
I would like to create them.

@Bashamega Yes go for it.

@Bashamega Yes go for it.

Thanks


File Upload

How do you do the file uploads on post?

Select HTTP method that allows to carry a payload and switch to the "body" tab.

Thanks! Found it. Just an observation, it is not intuitive. I still needed to dig around to make it appear, compared to the previous version where the file upload was very accessible.


[Feature]: add linux only config for k230_canmv device

Feature description
The k230_evb device supports running only Linux with configs/k230_evb_only_linux_defconfig, consider adding similar configuration so that k230_canmv device can also run only Linux.
Want resolve what problem
This allows users trying different usages of k230_canmv.
Anything else
No response

duplicated


linux-73 lost external connection from phone device.

Type of Request
bug
Infrastructure Environment
LUCI, Github, Cocoon scheduler, Autosubmit, etc...
What is happening?
linux-73 lost external connection from phone device.

Steps to reproduce
Step 1:
Step 2:
..
Step n:
Expected results
I expect to see X when Y is finished.

Phone device turn off by itself, press power button to restart device.


SQLAlchemy 2.0 not supported

Describe the bug
Getting this error from poetry when attempting to add griptape to an existing sqlalchemy project
Using version ^0.14.7 for griptape
Using version ^0.16.3 for griptape-tools

Updating dependencies
Resolving dependencies... (0.3s)

Because griptape (0.14.7) depends on sqlalchemy (>=1.0,<2.0)
 and no versions of griptape match >0.14.7,<0.15.0, griptape (>=0.14.7,<0.15.0) requires sqlalchemy (>=1.0,<2.0).
So, because good-ads depends on both sqlalchemy (^2.0.19) and griptape (^0.14.7), version solving failed.

To Reproduce
poetry add griptape griptape-tools

Expected behavior
Install griptape
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

OS: macOS
Version 13.3.1

Additional context
Add any other context about the problem here.

@iloveitaly, hey Mike! 😄
We are currently relying on some sqlalchemy 1.x-specific functionality but we should definitely upgrade to 2.x. Thanks for bringing this up!

This is an obstacle to adoption for me.
Curious what 1.x functionality is being relied upon / if you would accept a pull request for this work.

@mattgiles, 1.x is used in a handful of classes but the most significant blocker is in SqlDriver.get_table_schema(). Not a terribly hard migration but we just haven't gotten to it yet. If you'd like to submit a PR it would be most appreciated. Thanks!

@vasinov looks totally doable. I started down the path, but believe this issue is blocked by snowflake-sqlalchemry here. Hopefully they can figure that out.

@mattgiles, ah, yes. that's another blocker that I forgot about.

https://github.com/snowflakedb/snowflake-sqlalchemy/pull/469 was finally merged, hopefully they make a release soon.


Pagination Button Disabled/Broken

Hey Allen!
My pagination button isn't working. It seems to be disabled and clicking on it does nothing.
No warnings/errors appear in the console. Any idea on why this might be happening?

Actually looks like it might be some conflicting CSS - will keep you posted.

Okay it's because your js requires bootstrap.js (which I'm not using).
Surely there is a way to make this React only? And not require the additional js files.

maybe look at using something like https://github.com/AdeleD/react-paginate ?

You need to include your bootstrap js file into your html, bundle the bootstrap with this component is not a good idea :)


php.ini resets when container restarts

I made some edits to the php.ini and whenever the server restarts the file seems to reset. This is not good for my use case. Can I change this?

Hi @geekedtv, you have a couple of options, you could use a volume to replace the php.ini file with a local one when you launch the image, or you can use a custom Dockerfile where you overwrite the php.ini file and you build an image for yourself which you use

Maybe you were editing upload_max_filesize or post_max_size in php.ini at that time? If not, you may need to follow what @mattrayner said.
For upload_max_filesize or post_max_size, see:

#144

.


docs: fix comparison documentation

This PR fixes the documentation for Uint comparison. This documentation currently indicates that both Uint::lt and Uint::gt return truthy if the operands are equal. However, included tests for both Uint::lt and Uint::gt show that this is not the case.
Closes #682.

Thanks!


UHV/HeaderMap: Consider allowing users to validate Host and :authority headers separately

Title: UHV/HeaderMap: Consider allowing users to validate Host and :authority headers separately
Description:
This issue is filed as a follow-up to https://github.com/envoyproxy/envoy/pull/22537#discussion_r960009622, a discussion with @ameily and @yanavlasov. Based on this discussion, if receiving both a "host" and ":authority" header in HTTP/2, the current header map implementation merges the values into one comma-separated value. Then the Unified Header Validator (UHV) sees just the ":authority" header with the comma-separated value.
However, users may want to validate the "host" header and ":authority" header separately. The HTTP/2 specification states that if both are present, the values MUST agree (link). Users may also want to be able to distinguish among the following scenarios:
Scenario A:
  :authority: example.com
  host: example.com

Scenario B:
  :authority: example.com, example.com

Scenario C:
  host: example.com, example.com

Furthermore, certain users of UHV may have other reasons for validating separately (e.g., custom long-standing behavior, even if apart from the current spec), so enabling separate validation would enable compatibility with these users.
Relevant Links:

https://github.com/envoyproxy/envoy/pull/22537
https://github.com/envoyproxy/envoy/issues/21308
HTTP/2 spec

no stalebot

no stalebot

no stalebot

no stalebot
@ameily and @yanavlasov - is there a way to add a "no stalebot" tag? (I think the above is just a comment IIUC.) Thank you!

@ameily or @yanavlasov or @snowp - is there a way to add a "no stalebot" tag? Some entities will not be able to adopt UHV until this issue is fixed. Thanks!

No stalebot. Want to reiterate the request in https://github.com/envoyproxy/envoy/issues/23054#issuecomment-1427281332.

no stalebot

no stalebot


[WIP] opentelemetry bridge

Related issues
Closes #1362

:green_heart: Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

Start Time: 2021-11-19T18:20:10.531+0000

Duration: 34 min 7 sec

Commit: 3ec54a929e1340493c6210103c1dc86e8b37eeb5

Test stats :test_tube:

Test
Results

Failed
0

Passed
10287

Skipped
9537

Total
19824

:green_heart: Flaky test report
Tests succeeded.
:robot: GitHub comments
To re-run your PR in the CI, just comment with:

/test : Re-trigger the build.

/test linters : Run the Python linters only.

/test full : Run the full matrix of tests.

/test benchmark : Run the APM Agent Python benchmarks tests.

run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)


Use network env var in getSpaceUri

As suggested here: https://github.com/snapshot-labs/snapshot.js/pull/420
Would allow to set VITE_DEFAULT_NETWORK=4 and use a Rinkeby ENS domain to create a space.

I dont fully understand the impact of this change. If it doesn't affect anything you have tested it, I can approve it. @mktcode

@midgerate See here: https://github.com/snapshot-labs/snapshot.js/pull/420
It just allows to use the new network param added there, so getSpaceUri can look up ENS domains on different networks, like Rinkeby for testing.


Fix property column alignment when copying from the object store

\c @alazier @tgoyne

(test failure is unrelated)

Unless there are any objections, I'd really like to merge this, as migrations are currently broken (see the migration example)

Please just add a regression unit test and changelog entry since it is a bug fix.

since it is a bug fix
It's only fixing a bug introduced in the C++ object store, so this has never shipped (that was merged post=-0.93.2)

Ok, then a changelog entry isn't necessary, but please add a regression test nonetheless.

test added

Fixed

Closing because https://github.com/realm/realm-cocoa/issues/2142 was merged.


Unexpected behavior from detect-content

Hello. Firstly, great project!
When using the detect-content option, I observe some unexpected behavior. While the cuts are detected accurate, the exact timing of the cuts is off. This is very odd, since the frame at which the cut is detected doesn't have much of a content_val differential as compared to the frame where the cut actually happened.
I've documented this here after taking a closer look at the stats file.
This notebook is quite long, but well organised, so head over to
Exploring & Analysing the Data →
      Looking At Detected Cuts And Their Surrounding Frames →
           Correctly Detected (But How?)

Hi @rsomani95;
Thanks for sharing this with me, I'll look into this when I have some time.  I haven't analyzed the source video you're using in the notebook yet, but will do so as soon as possible.
Just so you know, the way detect-content works is that any frame delta exceeding the threshold triggers a new scene cut, but after doing so, any new scene cuts are ignored for N frames (default for N is 10).  This is to prevent noise/flashes from triggering false positives, while ensuring that the new scenes are at least captured within N frames.

One thing I'm looking into doing for the future is, let's say we have 3 frames, A, B, and C, and the delta between A and B is very large (indicating a new scene).  It may also be worth taking the delta of A and C, in this case, to see if frames A and C are related/part of the same scene, in which case this would be considered a false negative.
This is part of flash detection, which seems to be causing some issues in your analysis (very thorough by the way, well done).  See #35 for some more discussion on the matter.
Thanks for the submission, and the detailed analysis - this will definitely be useful for improving the detect-content algorithm.

Hi @Breakthrough
Glad you find this useful. I'd actually done this analysis sometime in September last year but was too new to coding to say anything with confidence -- PySceneDetect was the first tool I really used.
If you're gonna analyse the video, let me save you some time... go to this page and look at the .xls files for reference.

Just so you know, the way detect-content works is that any frame delta exceeding the threshold triggers a new scene cut, but after doing so, any new scene cuts are ignored for N frames (default for N is 10). This is to prevent noise/flashes from triggering false positives, while ensuring that the new scenes are at least captured within N frames. It seems this might explain some (but not all) of the behaviour you're describing.

Ah, I must've missed this somehow! That does explain some of the behavior for sure.

One thing I'm looking into doing for the future to solve this issue is, let's say we have 3 frames, A, B, and C, and the delta between A and B is very large (indicating a new scene). It may also be worth taking the delta of A and C, in this case, to see if frames A and C are related/part of the same scene, in which case this would be considered a false negative.

That's a smart idea, definitely worth trying out.
I have some ideas for improving the hard-cut detection, but I'm travelling right now and will post here again once I have something concrete.

Hi @Breakthrough
I've done some work to make your life easier. Clone this directory and follow along with the tdk-bankrobbery/PySceneDetect_Analysis.ipynb notebook to see what exactly the issue is. To give you a glimpse -- this is what the notebook offers:

I had to strip the output of most of the cells to manage filesizes.

Just so you know, the way detect-content works is that any frame delta exceeding the threshold triggers a new scene cut, but after doing so, any new scene cuts are ignored for N frames (default for N is 10). This is to prevent noise/flashes from triggering false positives, while ensuring that the new scenes are at least captured within N frames. It seems this might explain some (but not all) of the behaviour you're describing.

This explains the undetected cuts. Frame #3052 in the notebook might also offer some insight into this as well.

One thing I'm looking into doing for the future to solve this issue is, let's say we have 3 frames, A, B, and C, and the delta between A and B is very large (indicating a new scene). It may also be worth taking the delta of A and C, in this case, to see if frames A and C are related/part of the same scene, in which case this would be considered a false negative.

I don't think this will work out too well -- A and C could have a delta of ~0 but still be completely different scenes -- this is well documented in the notebook.

Thanks for the submission, and the detailed analysis - this will definitely be useful for improving the detect-content algorithm.

Happy to contribute :)

Update --> I've experimented with another peak-detection algorithm that worked perfectly! I've added this to a new section in the notebook.

Thanks for your contributions @rsomani95.  I'll definitely be looking into this when I have some more time on my hands.


Document which network providers work with kubeadm 1.6

This is a "Feature Request" for 1.6
Problem:
kubeadm/kubernetes 1.6 has new requirements for CNI based network providers.  We need to make it clear which network plugins work.
Proposed Solution:
Update the list of network addons to call out which ones have been updated for 1.6 (and kubeadm).
Page to Update:
https://kubernetes.io/docs/admin/addons/
Other Details:
We need to make sure that plugins:

Support RBAC
Support new taints for kubeadm
don't suffer from start up issues when pods are started before CNI

See also:
https://github.com/kubernetes/kubernetes/issues/43014
https://github.com/kubernetes/kubeadm/issues/143

Calico: @tomdee You say you have a fix for Calico but http://docs.projectcalico.org/v2.0/getting-started/kubernetes/installation/hosted/ still points to the old stuff.  What should I point docs at?
Flannel: What do we need to do to get Flannel working?  https://github.com/coreos/flannel/blob/master/Documentation/kube-flannel.yml looks like it won't work at all.
Weave: It looks like https://www.weave.works/docs/net/latest/kube-addon/ still points to an old manifest.  What should I point 1.6 docs at.
Canal: It looks like https://github.com/projectcalico/canal/blob/master/k8s-install/kubeadm/canal.yaml isn't ready.  @netroby @heschlie?
Contiv: Not sure what is going on here but I've never used it.  @rhim -- can you confirm that Contiv works with kubeadm 1.6.
Romana: Doesn't look ready for 1.6.  @chrismarino -- can you confirm?

probably https://github.com/weaveworks/weave/releases/tag/v1.9.4 for weave net but I shall check with @bboreham

@bowei created this spreadsheet to start figuring what the current support is: https://docs.google.com/spreadsheets/d/1Nqa6y4J3kEE2wW_wNFSwuAuADAl74vdN6jYGmwXRBv8/edit#gid=0.
But we need to lock down what we point users at.  Most of the landing pages haven't been updated yet.

It doesn't fit in the spreadsheet well, but figured I'd mention - we're working on a Calico v2.1.1 release which includes the updated Calico CNI plugin and manifests for deploying with Kubernetes v1.6. Aiming to complete by EOD.

For flannel there is:

https://github.com/coreos/flannel/blob/master/Documentation/kube-flannel-rbac.yml for RBAC
https://github.com/coreos/flannel/pull/618 for master taint
my experience with flannel is that pods are started before CNI

Looks like I need to first run https://github.com/coreos/flannel/blob/master/Documentation/kube-flannel-rbac.yml and then I can run https://github.com/coreos/flannel/blob/master/Documentation/kube-flannel.yml .
@tomdee can you confirm?

@cmluciano Yes, that's right. I just merged https://github.com/coreos/flannel/pull/614 which should mean there's one less command to run.

👍🏽 testing now

I'm having issues with that Flannel deploy, will open issue on flannel

will try out and update the thread

@djosborne -- you are free to add columns, edit the spreadsheet as you see fit ...
can the others (canal, contiv, romana) update the spreadsheet as well. I'm having trouble trying to correlate the conversation thread across different github issues.
https://docs.google.com/spreadsheets/d/1Nqa6y4J3kEE2wW_wNFSwuAuADAl74vdN6jYGmwXRBv8/edit#gid=0.
I am going to write a release note with a list of verified compatible CNI plugins from the data in the spreadsheet

Issue #44041 is causing some issues when plugins are deployed with kubeadm. Perhaps this could be investigated to sort out those issues?

@jbeda if you check Weave docs page now there instructions for 1.6; however we are all subject to kubernetes#44041 now.

@jbeda Romana supports 1.6 (PR: https://github.com/romana/romana/commit/42a64bf8654d7aeb67d7b43cd27c9f35800033bd) and it can be installed using: kubectl apply -f https://raw.githubusercontent.com/romana/romana/master/containerize/specs/romana-kubeadm.yml

There are other updates in progress and most of the network plugins have been updated at this point.  Closing this.


Consider branch when generating transaction ID

This PR is for this issue: https://github.com/drachtio/drachtio-server/issues/261

This commit actually breaks sip proxy functionality.  I will check in what I think is the correct fix shortly in a different PR.

I've merged my fix for this issue in https://github.com/drachtio/drachtio-server/pull/282


[MGMT] re-check old mgmt libraries, release GA lib for any of missed lib that has stable api-versions

Hope that we can start this in Jan.
Rough estimation would be about 30 libs that need a new release.
One question is whether we release GA lib for the service that we know has bug...
E.g. https://github.com/Azure/azure-sdk-for-java/issues/36332 (asked by multiple customers, and been there on service for half a year https://github.com/Azure/azure-rest-api-specs/issues/29274)

If we know a service has a bug, then we should apply pressure to the service team to fix the bug.
That being said, if the service team considers the service to be GA (with or without a bug), then we should GA the SDK.
The customer story can't be that the service has a GA version, and the SDK doesn't - how are customers supposed to rationalize this?
It is never mandatory for a customer to use a service. SDKs are optional for customers providing them with convenience (not required features). This is one reason why we open source our SDK code and allow customers to fork it and modify it if they like.
SDKs exist to put a facade over the service providing customers with code completion, compile-time type safety, and convenience features like retries, auth, logging, etc. SDKs are NOT supposed to fix service bugs or make a broken service work correctly somehow.


Issue with sidebars on /advocacy

Currently an issue with the sidebars (labeled "Helpful Guides") on the advocacy page: https://openaccessbutton.org/advocacy_staging. The second sidebar doesn't collapse the sections—this is another Javascript issue. The footer is also not displaying correctly.

Are we expecting a second sidebar there? It looks like it is duplicating the content.
This will cause it to break because it is matching on the first div with the correct ID. If you check, the second sidebar is opening and closing the section above correctly.
Are we planning another load of content here? If not, then the fix is simply to delete it. If we are, then we need to change the ID of the div, and add them to the list at the top of the etherpad.
Just let me know either way.

Thanks for checking! Yeah, we wanted a second sidebar with different content there.

OK, great. I will get onto it today if the etherpad loads properly.

I can still not load into the etherpad properly, so I am uploading new pages to a new branch, which will hopefully be able to replace the current content correctly. Just copy them into the etherpad.

This has been fixed.
Closing for now. It might still need new copy.


Capabilities with non-zero reserved bits

Hi!
In Section 2.1.7:
Reserved bits available for future extensions to Zcheri_purecap.
Reserved bits must be 0 in valid capabilities

It's not clear to me what this means. If a future extension to Zcheri_purecap uses the reserved bits, those capabilities are not valid capabilities anymore? Or does this mean that the specifications in some parts of Zcheri_purecap only apply when the reserved bits are 0? If so, which parts?

A key aim of the CHERI specification is to leave sufficient bits in the capability encoding for future extensions. You can see how this works if you compare the capability encodings in Zcheri_purecap and Zcheri_mode:

Zcheri_purecap is only for purecap machines and there is no "mode" bit
Zcheri_mode supports the Legacy mode (formerly Integer in CHERIv9) and does require the "mode" bit in the capability encoding.

Therefore, Zcheri_mode has 1 less reserved bit than Zcheri_purecap. If your implementation supports Zcheri_mode then there is a valid set of operations by which you can legally obtain capabilities with that bit set to either 1 or 0. However, if your implementation supports Zcheri_purecap only, then there are no valid operations for you to legally obtain a valid (i.e. tag set) cap with that reserved bit set to anything other than 0.
This applies to future extensions on top of Zcheri_purecap. It also means that you cannot take an arbitrary program from Zcheri_mode, for example, and run it on a machine that just supports Zcheri_purecap. Although Zcheri_mode is backwards-compatible, so you can take a Zcheri_purecap program and run it on Zcheri_mode.

A key aim of the CHERI specification is to leave sufficient bits in the capability encoding for future extensions. You can see how this works if you compare the capability encodings in Zcheri_purecap and Zcheri_mode:
* Zcheri_purecap is only for purecap machines and there is no "mode" bit

* Zcheri_mode supports the Legacy mode (formerly Integer in CHERIv9) and does require the "mode" bit in the capability encoding.

Therefore, Zcheri_mode has 1 less reserved bit than Zcheri_purecap. If your implementation supports Zcheri_mode then there is a valid set of operations by which you can legally obtain capabilities with that bit set to either 1 or 0. However, if your implementation supports Zcheri_purecap only, then there are no valid operations for you to legally obtain a valid (i.e. tag set) cap with that reserved bit set to anything other than 0.
This applies to future extensions on top of Zcheri_purecap. It also means that you cannot take an arbitrary program from Zcheri_mode, for example, and run it on a machine that just supports Zcheri_purecap. Although Zcheri_mode is backwards-compatible, so you can take a Zcheri_purecap program and run it on Zcheri_mode.

Thanks for the reply! I'm interested in learning about how an extension to Zcheri_purecap, not just the existing standard ones but also potential future custom ones, are supposed to work.
Your answer and the draft seem to suggest these (please correct me if I'm wrong):

Zcheri_purecap only specifies what happens when the reserved bits is zero. Extensions to it specify what happens when the reserved bits take some other values.
Extensions can override some part of Zcheri_purecap. In this case, at least the definition of a "valid capability" has changed.

I have a few more questions:

If Zcheri_purecap only concerns capabilities with reserved bits equal to zero, doesn't an extension need to explicitly specify which part of Zcheri_purecap also apply for "extended capabilities" that have non-zero reserved bits? For example, I suppose with Zcheri_purecap only, CADD on a capability with reserved bits = 0x1 is undefined, and an extension would need to specify what happens there, even if it simply wants to reuse the semantics for when reserved bits is zero.
Is backward compatibility a requirement? Is it required that even with an extension, as long as all capabilities used have reserved bits equal to zero and all instructions use are those defined in Zcheri_purecap, the behaviour should be identical to when only Zcheri_purecap is available?

Thanks!

Zcheri_purecap only specifies what happens when the reserved bits is zero.

The key to remember is that Zcheri_purecap does not make use of the reserved bits, so there is no valid set of instructions such that you will end up with a reserved bit set to something other than 0.

Extensions to it specify what happens when the reserved bits take some other values.

Yes, if you want to propose an extension that allocates a reserved bit in Zcheri_purecap for something then you need to indicate what's that bit is going to do

Is backward compatibility a requirement?

That's a good question. Ideally your extension would have some measure of compatibility with the base stuff, otherwise its like proposing an extension to RV32I, for example, that if implemented would not let you run programs that are simply RV32I. It would probably be difficult to find support for such an extension in the RISC-V community, hence why a lot of effort has been invested in providing extensions like Zcheri_legacy and Zcheri_mode that enable compatibility with RISC-V.

Your "backward compatibility" requirement is failed by Zcheri_mode: jalr to an executable capability with all reserved bits clear executes Capability mode instructions in Zcheri_purecap, but Legacy mode instructions in Zcheri_mode. This is #34.
There are likely to be new permissions in the future, which will change the Zcheri_purecap initial value of pcc and dinfc, and some of which (Global most notably) will conspicuously change the behavior of Zcheri_purecap instructions when clear. This is essentially #71.

@sorear: Apologies if I gave you the wrong impression! I never said it was a "requirement"; I said that "ideally" there is "some measure of compatibility" which in no way implies that there is a rule. In fact, I would expect that each extension will need to be reviewed and compatibility assessed on a case-by-case basis.

The reserved bits only need to be zero if the core does not implement any extensions that assign meaning to them. I see this as similar to CSRs where bits are later defined to have a meaning and older cores that don't implement them have them as read-only zero.
The only time these reserved bits matter is when using CBLD where it should reject any bitpattern that has bits set that the current CPU does not assign a meaning to. This ensures that it's impossible to ever encounter a capability that has reserved bits set. The only exception would be a system with multiple CHERI cores that use different extensions and therefore incompatible capability formats. If one of them sees a capability with reserved bits set it must treat it as invalid even if it has the tag set in memory. Although to be honest I think such a system is going to have a lot of issues beyond the reserved bits if there is any shared memory and should not be supported.
Maybe the spec needs to be more clear that the number of reserved bits depends on which of the extensions are supported?

What the spec is intended to say is that it is impossible to have a tagged capability with any of the reserved bits set, or any of the reserved permissions combinations for RV32 (for https://github.com/riscv/riscv-cheri/pull/155).
Future extensions will allow such capabilities, and the definition of how they behave will have to be documented.
For example the proposed local/global mechanism will do exactly this. It will allow currently reserved states to be exist in tagged capabilities, and the effect on all instructions and CHERI behaviour will need to be specified. Ideally those reserved states will be uniquely allocated to local/global, and there'll be no future conflict with other extensions, although this is possible if we run out of space in the capability format (only likely for RV32).
So we're really treating it like the RISC-V encoding space, and filling in reserved opcodes as we go.
Is that helpful?

Is there anything further to do on this ticket? Can we close it?

It looks like the discussion concluded, so I will close this ticket. We can always reopen it (or create a new one!) if there are further questions.


Fix process_subdir bug

If subdir parameter (airflow run command)  contains DAGS_FOLDER and the subdir is relative path, cli.process_subdir failed to parse correclty, and could not find dag file.
For example, if DAGS_FOLDER is /var/lib/airflow and current directory is also /var/lib/airflow, DAGS_FOLDER/abc become /var/lib/airflow/var/lib/airflow/abc.
This is because os.path.abspath is called before replace DAGS_FOLDER palceholder.
https://github.com/airbnb/airflow/blob/master/airflow/models.py#L630
This bug is critical because TaskInstance.commad specify DAGS_FOLDER/{dag.filepath} as default suddir value.

Totally makes sense. I added the abspath to the line recently but didn't think about moving it after the DAG_FOLDER replacement. Good call.


Innr RB278T tunable white bulb created in domoticz as basic dimmer, should be RGBWW

I have just added 2 x Innr RB278T bulbs to my system.  They have been created in domoticz as simple dimmer devices (Type 244, SubType 73).  I believe that they should be RGBWW dimmers (Type 241, SubType 4).
If I directly send MQTT /set messages with "color_temp", the bulbs react correctly.  If I change the type & subtype in the domoticz.db, the colour temperature control has no effect.  It appears, that domoticz-zigbee2mqtt-plugin has attributed the bulb the wrong type in its interface with domoticz, although zigbee2mqtt has the correct type.
Plugin version according to CHANGELOG.md is 0.2.1 (git pulled today).  Domoticz is latest beta.  Zigbee2mqtt is up to date also.

Other users reporting same issue with these bulbs - https://domoticz.com/forum/viewtopic.php?f=68&t=34631&p=261509#p261509

I see the problem; incorrect device type for RB278T in https://github.com/stas-demydiuk/domoticz-zigbee2mqtt-plugin/blob/master/adapters/innr/init.py
I'll change the file locally to test and if it works, I'll clone the repo and raise a pull request when I have a few minutes later on.

Pull request #476 ready to go.


C syntax highlighting is wrong when a #define contains the beginning of a switch block

Checklist

[x] This problem exists even with the setting "C_Cpp.enhancedColorization": "Disabled"

Does this issue occur when all extensions are disabled?: Yes

VS Code Version: 1.70.2 (user setup)
Commit: e4503b30fc78200f846c62cf8091b76ff5547662
Date: 2022-08-16T05:35:13.448Z
Electron: 18.3.5
Chromium: 100.0.4896.160
Node.js: 16.13.2
V8: <IP_ADDRESS>-electron.0
OS Version: Windows 10 21H2 (Windows_NT x64 10.0.19044)
Theme: Dark+ (default dark)

Steps to Reproduce:

Create a new file
Set the language to C
Use a #define containing the beginning of a switch block, like in the following example code:

#include <stdio.h>

#define DISPATCH() switch (command) {
#define INSTRUCTION(i) case (i):
#define DISPATCH_END() }

int main(int argc, char* argv[]) {
    int command, a, b, r;
    scanf("%d %d %d", &command, &a, &b);

    DISPATCH()
    INSTRUCTION(0)
        r = a + b;
        break;
    INSTRUCTION(1)
        r = a - b;
        break;
    INSTRUCTION(2)
        r = a * b;
        break;
    INSTRUCTION(3)
        r = a / b;
        break;
    default:
        r = a;
    DISPATCH_END()

    printf("%d\n", r);
    return 0;
}

The highlighting will be wrong. Most of the code in main should be white, but will instead be blue. The difference can be seen easily by removing the line containing #define DISPATCH() ....

The code itself is completely valid and has thus far not failed to compile in any C compiler I have tried. As far as I can tell, it is completely standards-compliant ANSI C code.
Removing the left/opening brace from that line fixes the issue only partially. Removing switch fixes it completely.
Correct(ish) syntax highlighting (without the #define DISPATCH()...)

Incorrect syntax highlighting (with the #define DISPATCH()...)

Originally from @hisahi in https://github.com/microsoft/vscode/issues/159016

should be fixed now


Timestamp for EZMicrophone input

Simple extension of the protocol of EZMicrophone to pass down the incoming timestamp

hope this helps you and others.


Please consider fixing issues detected by repository checker

Notification from ioBroker Check and Service Bot
Dear adapter developer,
I'm the ioBroker Check and Service Bot. I'm an automated tool processing routine tasks for the ioBroker infrastructure. I have recently checked the repository for your adapter hydrawise for common errors and appropiate suggestions to keep this adapter up to date.
This check is based the current head revisions (master / main  branch) of the adapter repository
Please see the result of the check below.
ioBroker.hydrawise
   -
ERRORS:

[ ] :heavy_exclamation_mark: [E204] Versions "0.3.1, 0.3.0" listed at common.news at io-package.json do not exist at NPM. Please remove from news section.

WARNINGS:

[ ] :eyes: [W040] "keywords" within package.json should contain "ioBroker"
[ ] :eyes: [W162] js-controller 5.0.0 listed as dependency but 5.0.19 is recommended. Please consider updating dependency at io-package.json.
[ ] :eyes: [W184] "common.main" is deprecated and ignored. Please remove from io-package.json. Use "main" at package.json instead.

:thumbsup: No suggestions found
Please review issues reported and consider fixing them as soon as appropiate.
Errors reported by repository checker should be fixed as soon as possible. Some of them require a new release to be considered as fixed. Please note that errors reported by checker might be considered as blocking point for future updates at stable repository.
Warnings reported by repository checker should be reviewed. While some warnings can be ignored due to good reasons or a dedicated decision of the developer, most warnings should be fixed as soon as appropiate.
You may start a new check at any time by adding the following comment to this issue:
@iobroker-bot recheck
Please note that I (and the server at GitHub) have always plenty of work to do. So it may last up to 30 minutes until you see a reaction. I will drop a comment here as soon as I start processing.
Feel free to contact me (@iobroker-bot) if you have any questions or feel that an issue is incorrectly flagged.
And THANKS A LOT for maintaining this adapter from me and all users.
Let's work together for the best user experience.
your
ioBroker Check and Service Bot
@mcm1957 for evidence
Last update at Fri, 06 Sep 2024 08:22:39 GMT

Issue outdated due to RECREATE request. Follow up issue #86 has been created.
This issue will be closed.
your
ioBroker Check and Service Bot


Suggestions

Hello,
I have just added/modified two keywords/symbols that I needed and I thought that might interest you:
Here is the code I used:
MathJax.Hub.Register.StartupHook("AsciiMath Jax Config",function () {
  var AM = MathJax.InputJax.AsciiMath.AM;
  for (var i = 0; i < AM.symbols.length; i++) {
    if (AM.symbols[i].input == "->") {
      AM.symbols[i].ttype = AM.TOKEN.UNDEROVER
    }
  }
  AM.symbols.push(
    {input:"~",  tag:"mo", output:"\u223C", tex:null, ttype: AM.TOKEN.UNDEROVER}
  );
});

This allows for those uses (the 2nd and 4th were not possible):

I can make a PR if you think it's useful.

Not my call but this looks nice!
@drlippman ? @jipsen ?

I believe Peter's original to stacking something over an operator was the stackrel binary operator, but it only works for stacking something over a symbol, not under.
So I think we could go two ways with this:

If there are other symbols currently of ttype CONST for which we would only ever want to stack something over/under them, and would never subscript/superscript them, then changing them to OVERUNDER makes sense.

We could add another binary operator, similar to stackrel, which would allow for placing a symbol under another, so the examples presented could be done as something like stackunder{->}{exp}

Do a combo of those.

I personally like 2 the best (or perhaps 3 if there are any of the kind listed in 1, but then you run into inconsistent usage, as some symbols work one way and some another).

Perhaps borrowing "overset" and "underset" from latex/amsmath would be better names than using stackrel...
Another option would be to borrow the \mathop approach, where mathop would turn a symbol from CONST to OVERUNDER.  But the complexity of that seems to run counter to the AsciiMath philosophy.
I agree a combo is probably nicest, but I don't know advanced math fields well enough to know whether any of the CONST symbols are ever super or subscripted.

What I would not want to see is someone who wanted to use a super or subscript but couldn't because it became under or over.  Is there a way to override that if needed?  I like your overset andunderset idea.  Can you have something that does both (or if they are combined, they produce munderover)?  There are use-cases where you have arrows with decorations both above and below, for example.

Just got around to revisiting this. I think adding overset and underset is probably the simplest solution to enabling these types of symbols.  Going to go ahead and add them.


Unable to upgrade sbt on mac with brew.

(See the guidelines for contributing, linked above)
steps
Install java 9

problem
Cannot upgrade sbt using brew.
expectation
sbt: Java 1.8 is required to install this formula.
JavaRequirement unsatisfied!
notes
I have installed java 9
sbt version: insert sbt version
1.0.3

Same issue when i am trying to update to/install last version of sbt via brew:

~ brew install sbt
sbt: Java 1.8 is required to install this formula.
JavaRequirement unsatisfied!
You can install with Homebrew-Cask:
brew cask install caskroom/versions/java8
You can download from:
https://www.oracle.com/technetwork/java/javase/downloads/index.html
Error: An unsatisfied requirement failed this build.

Even though i have required version of java installed:

~ java -version
Picked up _JAVA_OPTIONS: -Xms1024m -Xmx2G -Xss256m -XX:MaxPermSize=4G
Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=4G; support was removed in 8.0
java version "1.8.0_152"
Java(TM) SE Runtime Environment (build 1.8.0_152-b16)
Java HotSpot(TM) 64-Bit Server VM (build 25.152-b16, mixed mode)

Same issue here, any workaround?

Had the same issue.
$ brew install sbt
sbt: Java 1.8 is required to install this formula.
JavaRequirement unsatisfied!
You can install with Homebrew-Cask:
  brew cask install java
You can download from:
  https://www.oracle.com/technetwork/java/javase/downloads/index.html
Error: An unsatisfied requirement failed this build.

Running brew cask install java installed v9, which didn't meet the requirements. It worked when I uninstalled it, and installed JDK 8 Update 151 from the Oracle website.

Same problem here. Java 1.8 is installed. Any ideas if there is a workaround?
$ brew install sbt
sbt: Java 1.8 is required to install this formula.
JavaRequirement unsatisfied!

You can install with Homebrew-Cask:
  brew cask install java

You can download from:
  https://www.oracle.com/technetwork/java/javase/downloads/index.html
Error: An unsatisfied requirement failed this build.
$ java -version
Picked up _JAVA_OPTIONS: -Xms1024m -Xmx2G -Xss256m -XX:+CMSClassUnloadingEnabled
java version "1.8.0_152"
Java(TM) SE Runtime Environment (build 1.8.0_152-b16)
Java HotSpot(TM) 64-Bit Server VM (build 25.152-b16, mixed mode)

The workaround I found is to uninstall java 9 and install java 8 instead.
brew cask uninstall java brew cask install java8 brew install sbt

I installed sbt manually in the following way:

first download and extract SBT-1.0.2.ZIP from here
cd sbt/bin
sudo mv sbt-launch.jar /usr/local/bin/sbt-launch.jar
java -Xmx512M -jar /usr/local/bin/sbt-launch.jar
sudo chmod +x /usr/local/bin/sbt
Invoking the sbt command led me to the console

Judging from responses, the people who had 1.8 installed but were still unsuccessful, were using 1.8.0_152. Installing 1.8.0_151 works for me.

@ademagic I think you have to do brew cask install caskroom/versions/java8, for what it's worth.
It's currently installing 1.8.0_152, looks like.

brew checks java version by /usr/libexec/java_home.
So to pass the requirement, u just need link a JDK path in /Library/Java/JavaVirtualMachines where can be found by java_home.

Hopefully this was fixed in https://github.com/Homebrew/homebrew-core/pull/21052


WIP: Distribution Tests

Adding tests for all of the distributions...this is slow and tedious work.
I also added assert_sigfigs_equal because assert_almost_equal doesn't often do what I care about.

Awesome, thanks for adding these tests! I'm trying to debug the CI builds over in #96, as it looks like a package update on Anaconda's end broke things again, so I apologize for the build not working atm.

No worries, there are still like 10 distributions that need to be included...just wanted to put this here so that not just me knows I'm working on it.

Coverage increased (+2.08%) to 50.148% when pulling 077f8e4fcd58fa57ae9f30aeae0248b204feb2d7 on ihincks:feature-distribution-tests into d46aca0a84c8574addd6601fb70fa59ae845c378 on QInfer:master.

Coverage increased (+1.6%) to 63.653% when pulling 27ac3ad41eabf2d76cfa3b42db89cb2a71a07811 on ihincks:feature-distribution-tests into 5fbecfdf00d7fb15080592e81d9a8cfdafe15916 on QInfer:master.

Coverage increased (+2.2%) to 64.316% when pulling 97245366a4af0467304a70307cf96b3469125cb1 on ihincks:feature-distribution-tests into 5fbecfdf00d7fb15080592e81d9a8cfdafe15916 on QInfer:master.

Coverage increased (+3.5%) to 65.561% when pulling 91c71092ef3c9961c9b3d79e576ac3d6f59805d6 on ihincks:feature-distribution-tests into 5fbecfdf00d7fb15080592e81d9a8cfdafe15916 on QInfer:master.

Okay, all distributions in qinfer/distributions.py have tests now (except the ones I think should be deprecated). And all the documentation is up to date with what the distribution actually does, and is in the API.  I think tomography stuff can get tests in another PR at a future time. This means I have finished what I wanted to do in this PR, assuming the newest tests past on travis-ci.

Coverage increased (+3.5%) to 65.561% when pulling 756ce25a026a0eb2210d8d02adaeb9f1050dca49 on ihincks:feature-distribution-tests into 5fbecfdf00d7fb15080592e81d9a8cfdafe15916 on QInfer:master.

Coverage increased (+3.5%) to 65.561% when pulling 756ce25a026a0eb2210d8d02adaeb9f1050dca49 on ihincks:feature-distribution-tests into 5fbecfdf00d7fb15080592e81d9a8cfdafe15916 on QInfer:master.

Coverage increased (+3.5%) to 65.561% when pulling 756ce25a026a0eb2210d8d02adaeb9f1050dca49 on ihincks:feature-distribution-tests into 5fbecfdf00d7fb15080592e81d9a8cfdafe15916 on QInfer:master.


[Bug]: Add license header for files failing license header checker github action

Describe the bug
A lot of files are missing the license header.
Issue: 3079 requires the files to be fixed before merging PR: 4118 to make sure it doesn't break for all upcoming PRs for the opensearch-build repo.
To reproduce
Check for License Header Checker Github action Job Run

Thanks @hitenshKharva for the great contribution.


logout() is not working

It seems as though the logout() function is not cleaning up cookies or other cached data that might have been stored in the InAppBrowser. Therefore when I call logout() followed by login(), I am immediately logged back in with the account that has previously logged in. Instead I was expecting a login screen to appear to allow me to enter different credentials.
I know I might be able to work around this by clearing the inAppBrowser cache myself, but imho logout() should log out the user completely, taking into account cache / cookies.

Same issue here :(

FYI For better or worse, Google is deprecating the InAppBrowser login approach in favor of using the system browser and device-wide user login, so any InAppBrowser-specific solution isn't likely to be worth addressing at this point. See https://github.com/Azure/azure-mobile-apps-js-client/issues/194 for details.

This is a common problem with InAppBrowser.  If you need to do logout(), use the client-flow authentication and the mechanisms for that.


Input data

Hello,
I have a question regarding the slam algorithm. For this package to work, does it take in raw Lidar data? Or does it take in point clouds that has already been filtered?

this package take in raw Lidar data


Not working on SAMD21 based boards (MKR1000, Feather M0, Zero)

OS version: Ubuntu 17.04
Arduino IDE version: 1.8.3
MFRC522 Library version: master
Arduino device: Adafruit Feather M0
MFRC522 device: RFID-RC522

I'm trying to use the library with the Feather M0 which uses the SAMD21 (ARM Cortex M0+) also present on all newer Arduinos like the MKR1000 and Zero.
Unfortunately the library fails to communicate with the RC522 (hangs for ages in init and returns firmware version 0x00 after a while). I tested the same board with an Arduino Nano which worked fine. Any ideas why it doesn't work on the Feather?
Anything SPI wise that is not using standard SPI.h function calls that causes the incompatibility?

Can you try 1.6.3 https://github.com/miguelbalboa/rfid/releases ?

I tried 1.3.6 and 1.3.5, same issue.

Just to complete the documentation this is my wiring:
https://imgur.com/a/AKhrP
I checked it 5 times now, seems all in order.
I'm trying out the DumpInfo example.

[x] Ok, wiring looks good.
[x] According to your report it not depends on recent changes.
[ ] Check out changes by #344
[ ] Maybe the pin config cause your error noticed in https://github.com/miguelbalboa/rfid/pull/344#issuecomment-340320910

General note for migrating to feather m0: https://learn.adafruit.com/adafruit-feather-m0-basic-proto/adapting-sketches-to-m0

Doing a hard reset as suggested in that bug report indeed did the trick for me. Maybe that is something that should be added to PCD_Init() by default? Or is there another reason why there is deliberately no hard reset? If so maybe an optional "do hard reset" argument for PCD_Init() might be the way to go?

I am having the same problem.
Using latest version of code
Arduno 1.8.5
Mac OSX
Just using standard ReadWrite Example works fine on a 32u4 board, however on the M0 it does not display much.
Here is wiring (Although it works on 32u4 so I know its not that): https://photos.app.goo.gl/WJMeFrJUu7ADLxKQ2
Here is a snippet from arduino serial output

Any help would be appreciated!
-Brandon

Using latest version of code

@blooem Version of the code: git master or 1.3.6?

@Rotzbua

I am willing to pay for support if anyone is interested. This is the only library that I have even remotely got to work, and really need to finish this project.
Thanks,
B

You should try the latest version from git not 1.3.6. The thing described here is already fixed.


Fix incorrect actions/checkout version comment in Go test workflow

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 35.03%. Comparing base (46ec9c2) to head (76f739a).
Report is 49 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #133      +/-   ##
==========================================
- Coverage   35.80%   35.03%   -0.77%
==========================================
  Files          16       33      +17
  Lines        1363     2777    +1414
==========================================
+ Hits          488      973     +485
- Misses        801     1696     +895
- Partials       74      108      +34

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.