Pulldasher: Add the 'mergeable' field

Issue overview:

Pull requests with merge conflicts can end up in the Ready column in Pulldasher
QA is unable to pull up the latest changes to a pull request if there are conflicts present

Resolution:

Send pull requests that have fulfilled CR/QA requirements (but have a merge conflict), to the Deploy Blocked column.
Update QA column sorting to place pull requests without merge conflicts above those with merge conflicts.
Add a new Pulldasher flag to easily discern if a pull request has merge conflicts.

Changes Made:

Added in a new field from GitHub (mergeable)
Create a new flag for the new field
Updated Pulldasher QA column sorting logic
Updated Pulldasher Ready + Deploy Block column pull logic

Documentation reference:
https://docs.github.com/en/rest/pulls/pulls?apiVersion=2022-11-28#get-a-pull-request

CR/QA Notes:
CR: Review to
QA:

cr_req 2
Closes #351

Looking good!

CR :+1:
Great!

FYI, this is what the flag looks like:

Oh wait.. dev_block :+1:  on adding an example to the https://pulldasher-dev.cominor.com/pull-card-demo.html

un_dev_block 🟢
Added an example for the draft & mergeable fields to /pull-card-demo.html on Pulldasher-Dev

dev_block 🟥 on updating Deploy Blocked column logic

un_dev_block 🟢

Switched the flag color and added some sorting for the Deploy Blocked column via https://github.com/iFixit/pulldasher/pull/356/commits/479ce5d0c376db5903f26b11b1551bee2c0d5b9f

QA 🟢
I think that this is good to go 👍

Confirmed:

Pull requests with merge conflicts have a flag shown

Since there are a couple of state specific specs to this pull request that are more difficult to reproduce, I opt to monitor for quality assurance overtime and make modifications if necessary

@jordycosta, I noticed a pull on Pulldasher that doesn't show the merge conflicts indicator.
https://github.com/iFixit/react-commerce/pull/1439

@erinemay I don't think that pull has a merge conflict. It's just out of date with main and no one has done an approving CR on it.


[BUG] Directories not being created automatically

In raising this issue, I confirm the following:
{please fill the checkboxes, e.g: [X]}

[X] I have read and understood the contributors guide.
[X] The issue I am reporting can be replicated.
[X] The issue I am reporting is directly related to the pivpn installer script.
[X] The issue I am reporting isn't a duplicate (see FAQs, closed issues, and open issues).

Describe the bug
The required folders don't seem to be getting created automatically

root@Harbormaster:~# pivpn wg add
Enter a Name for the Client: d
/opt/pivpn/wireguard/makeCONF.sh: line 82: keys/d_pub: No such file or directory
tee: keys/d_priv: No such file or directory
::: Client Keys generated
grep: configs/clients.txt: No such file or directory
/opt/pivpn/wireguard/makeCONF.sh: line 90: keys/d_pub: No such file or directory
/opt/pivpn/wireguard/makeCONF.sh: line 90: configs/clients.txt: No such file or directory
/opt/pivpn/wireguard/makeCONF.sh: line 95: -2: substring expression < 0
cat: keys/d_priv: No such file or directory
/opt/pivpn/wireguard/makeCONF.sh: line 97: configs/d.conf: No such file or directory
/opt/pivpn/wireguard/makeCONF.sh: line 105: configs/d.conf: No such file or directory
/opt/pivpn/wireguard/makeCONF.sh: line 107: configs/d.conf: No such file or directory
cat: keys/server_pub: No such file or directory
cat: keys/d_psk: No such file or directory
/opt/pivpn/wireguard/makeCONF.sh: line 113: configs/d.conf: No such file or directory
::: Client config generated
cat: keys/d_pub: No such file or directory
cat: keys/d_psk: No such file or directory
::: Updated server config
<EMAIL_ADDRESS>is not active, cannot reload.
::: Failed to reload WireGuard
cp: cannot stat 'configs/d.conf': No such file or directory
chown: cannot access '/home/linaro/configs/d.conf': No such file or directory
chmod: cannot access '/home/linaro/configs/d.conf': No such file or directory

root@Harbormaster:~# pivpn wg add
Enter a Name for the Client: f
/opt/pivpn/wireguard/makeCONF.sh: line 82: keys/f_pub: No such file or directory
tee: keys/f_priv: No such file or directory
::: Client Keys generated
grep: configs/clients.txt: No such file or directory
/opt/pivpn/wireguard/makeCONF.sh: line 90: keys/f_pub: No such file or directory
/opt/pivpn/wireguard/makeCONF.sh: line 90: configs/clients.txt: No such file or directory
/opt/pivpn/wireguard/makeCONF.sh: line 95: -2: substring expression < 0
cat: keys/f_priv: No such file or directory
/opt/pivpn/wireguard/makeCONF.sh: line 97: configs/f.conf: No such file or directory
/opt/pivpn/wireguard/makeCONF.sh: line 105: configs/f.conf: No such file or directory
/opt/pivpn/wireguard/makeCONF.sh: line 107: configs/f.conf: No such file or directory
cat: keys/server_pub: No such file or directory
cat: keys/f_psk: No such file or directory
/opt/pivpn/wireguard/makeCONF.sh: line 113: configs/f.conf: No such file or directory
::: Client config generated
cat: keys/f_pub: No such file or directory
cat: keys/f_psk: No such file or directory
::: Updated server config
<EMAIL_ADDRESS>is not active, cannot reload.
::: Failed to reload WireGuard
cp: cannot stat 'configs/f.conf': No such file or directory
chown: cannot access '/home/linaro/configs/f.conf': No such file or directory
chmod: cannot access '/home/linaro/configs/f.conf': No such file or directory

To Reproduce
Steps to reproduce the behavior:
Installed with curl -L https://install.pivpn.io | bash
Typed in pivpn wg add
Expected behavior
Folders should be created automcatically
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

VPN Protocol
OS: [e.g. iOS]
Version [e.g. 22]

Smartphone (please complete the following information):

VPN Protocol
Device: [e.g. iPhone6]
OS: [e.g. iOS8.1]
Version [e.g. 22]

Additional context
Add any other context about the problem here.

This is clearly related and caused by:  with https://github.com/pivpn/pivpn/issues/1304
Therefore my recommendation stands,
Try on a clean system or please be more specific on what you have done.
Closing.

Hi,
What I have done was

curl -L https://install.pivpn.io | bash
I noticed that the command pivpn did not work, so I chased down the symlink issue in #1302 and renames the 3 files with .sh. Now, pivpn works.
Then, I had to ``apt-get install wireguard` because 'wg' command was not working, which turned out to be the install script did not install wireguard for me
Now I am at the stage where I am getting all these directory errors

I have not done anything out of the ordinary to my PiVpn installation, I was following the instructions.
Im on an Asus Tinkerboard 2S running their TinkerOs based on Buster (Debian 10)

Testing the test branch, but having these same issues
root@Harbormaster:/home/linaro# curl -L https://test.pivpn.io | TESTING= bash
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   162  100   162    0     0    405      0 --:--:-- --:--:-- --:--:--   405
100 84313  100 84313    0     0   151k      0 --:--:-- --:--:-- --:--:--  151k
:::
::: You are root.
::: Reconfigure option selected.
::: Hostname length OK
::: Verifying free disk space...
:::
::: Package Cache update is needed, running apt-get update -y ...
 done!
:::
::: Checking apt-get for upgraded packages.... done!
:::
::: Your system is up to date! Continuing with PiVPN installation...
:::    Checking for git... already installed!
:::    Checking for tar... already installed!
:::    Checking for wget... already installed!
:::    Checking for curl... already installed!
:::    Checking for grep... already installed!
:::    Checking for dnsutils... already installed!
:::    Checking for whiptail... already installed!
:::    Checking for net-tools... already installed!
:::    Checking for bsdmainutils... already installed!
:::    Checking for iptables-persistent... already installed!
::: Using User: linaro
:::
::: Checking for existing base files...
:::    Checking /usr/local/src/pivpn is a repo... OK!
:::     Updating repo in /usr/local/src/pivpn...Branch 'test' set up to track remote branch 'test' from 'origin'.
Switched to a new branch 'test'
 done!
::: Using VPN: OpenVPN
::: Installing OpenVPN from Debian package...
:::    Checking for openvpn... already installed!
:::    Checking for grepcidr... already installed!
:::    Checking for expect... already installed!
::: Using protocol: udp
  [i] Listening on all interfaces, permitting origins from one hop away (LAN)
  [✓] Restarting DNS server
::: Backing up the openvpn folder to /etc/openvpn_2021-05-06-202305.tar.gz
./easyrsa: 341: set: Illegal option -o echo
::: Building CA...
Using SSL: openssl OpenSSL 1.1.1d  10 Sep 2019
read EC key
writing EC key
./easyrsa: 341: set: Illegal option -o echo

::: CA Complete.

Note: using Easy-RSA configuration from: /etc/openvpn/easy-rsa/vars
Using SSL: openssl OpenSSL 1.1.1d  10 Sep 2019
Generating an EC private key
writing new private key to '/etc/openvpn/easy-rsa/pki/easy-rsa-2687.qOhc7E/tmp.P7d717'
-----
Using configuration from /etc/openvpn/easy-rsa/pki/easy-rsa-2687.qOhc7E/tmp.PW4mAn
Check that the request matches the signature
Signature ok
The Subject's Distinguished Name is as follows
commonName            :ASN.1 12:'Harbormaster_ba43df0d-1776-4caf-8dda-5c818eacdf57'
Certificate is to be certified until May  4 20:23:07 2031 GMT (3650 days)

Write out database with 1 new entries
Data Base Updated
./easyrsa: 341: set: Illegal option -o echo

Note: using Easy-RSA configuration from: /etc/openvpn/easy-rsa/vars
Using SSL: openssl OpenSSL 1.1.1d  10 Sep 2019
Using configuration from /etc/openvpn/easy-rsa/pki/easy-rsa-2766.VgZcVg/tmp.M7efJP

An updated CRL has been created.
CRL file: /etc/openvpn/easy-rsa/pki/crl.pem

./easyrsa: 341: set: Illegal option -o echo
openvpn:x:114:121::/var/lib/openvpn/:/usr/sbin/nologin
iptables v1.8.2 (nf_tables):  CHAIN_ADD failed (No such file or directory): chain PREROUTING
iptables v1.8.2 (nf_tables): Couldn't load match `comment':No such file or directory

Try `iptables -h' or 'iptables --help' for more information.
# Warning: iptables-legacy tables present, use iptables-legacy to see them
# Warning: iptables-legacy tables present, use iptables-legacy to see them
# Warning: iptables-legacy tables present, use iptables-legacy to see them
# Warning: iptables-legacy tables present, use iptables-legacy to see them
# Warning: iptables-legacy tables present, use iptables-legacy-save to see them
::: Install Complete...
::: Restarting services...
:::    Checking for unattended-upgrades... already installed!
::: Setupfiles copied to /etc/pivpn/openvpn/setupVars.conf
::: Installing scripts to /opt/pivpn...
unlink: cannot unlink '/etc/bash_completion.d/pivpn': No such file or directory
 done.
::: Flushing writes to disk...
::: done.
:::
root@Harbormaster:/home/linaro# wg
root@Harbormaster:/home/linaro# pivpn wg add
Enter a Name for the Client: HMSInterceptor
/opt/pivpn/wireguard/makeCONF.sh: line 82: keys/HMSInterceptor_pub: No such file or directory
tee: keys/HMSInterceptor_priv: No such file or directory
::: Client Keys generated
grep: configs/clients.txt: No such file or directory
/opt/pivpn/wireguard/makeCONF.sh: line 90: keys/HMSInterceptor_pub: No such file or directory
/opt/pivpn/wireguard/makeCONF.sh: line 90: configs/clients.txt: No such file or directory
/opt/pivpn/wireguard/makeCONF.sh: line 95: -2: substring expression < 0
cat: keys/HMSInterceptor_priv: No such file or directory
/opt/pivpn/wireguard/makeCONF.sh: line 99: configs/HMSInterceptor.conf: No such file or directory
/opt/pivpn/wireguard/makeCONF.sh: line 105: configs/HMSInterceptor.conf: No such file or directory
/opt/pivpn/wireguard/makeCONF.sh: line 109: configs/HMSInterceptor.conf: No such file or directory
/opt/pivpn/wireguard/makeCONF.sh: line 111: configs/HMSInterceptor.conf: No such file or directory
cat: keys/server_pub: No such file or directory
cat: keys/HMSInterceptor_psk: No such file or directory
/opt/pivpn/wireguard/makeCONF.sh: line 117: configs/HMSInterceptor.conf: No such file or directory
::: Client config generated
cat: keys/HMSInterceptor_pub: No such file or directory
cat: keys/HMSInterceptor_psk: No such file or directory
::: Updated server config
<EMAIL_ADDRESS>is not active, cannot reload.
::: Failed to reload WireGuard
cp: cannot stat 'configs/HMSInterceptor.conf': No such file or directory
chown: cannot access '/home/linaro/configs/HMSInterceptor.conf': No such file or directory
chmod: cannot access '/home/linaro/configs/HMSInterceptor.conf': No such file or directory
======================================================================
::: Done! HMSInterceptor.conf successfully created!
::: HMSInterceptor.conf was copied to /home/linaro/configs for easy transfer.
::: Please use this profile only on one device and create additional
::: profiles for other devices. You can also use pivpn -qr
::: to generate a QR Code you can scan with the mobile app.
======================================================================

as stated here: https://github.com/pivpn/pivpn/issues/1239 and at this point in some other issues ...
there are still some limitations in Wireguard support for some distros and boards, this happens because different boards require different kernel headers and there is no way we can test and know about all of them.
afaik Debian 10 doesn't have wire-guard yet built into the kernel which, therefore we are not supporting it.
Maybe we should be more clear about it. might put something up about that on the documentation.
As you said you are not doing anything fancy .. but shouting out bug without reading around and mentioning all those details in first place like the board you are using, OS, don't make it easier either.


feat(logo): add logo in public/logo

Add logo #5

Add logo #5

Hey!
Amazing work with the logo!
It'd be great if you could provide the logo in SVG format. :)

Hey @xroll,  there was no SVG format for the logo.
Thank you for your contribution🙌!
Please note that any further contributions will not produce points towards hacktoberfest or the ACM prizes.


Create README for Azure.Core.TestFramework

It would be great to provide a README for the Core Test Framework, similar to the one for Core that goes through key concepts with samples.
https://github.com/Azure/azure-sdk-for-net/tree/master/sdk/core/Azure.Core.TestFramework

We should move https://github.com/Azure/azure-sdk-for-net/blob/master/doc/dev/Track2TestFramework.md to test framework directory and check that it's up-to-date.


Convert cards to CSS vars

Picks up #35097 and takes it over the finish line.
/cc @tagliala

Merged via #36071.


2.3 release planning

We have a new feature--consolidated metadata--that some of us (me!) are eager to get into production.
Zarr releases quite infrequently compared to other OS projects I'm involved in. (Our last release was 8 months ago.) The list of things to fix for 2.3 contains some hard items which potentially involve revising the spec. @alimanfoo & @jakirkham, are all of the things on that list "must haves" for a new release? Or perhaps we might consider a more frequent and less ambitious release cycle?
Or maybe, although this is not a bugfix, we do a micro release?

I'd be happy to revise the list of issues currently tagged in 2.3 - it was
ambitious - and go for a 2.3 release sooner.
On Tue, 20 Nov 2018, 05:05 Ryan Abernathey<EMAIL_ADDRESS>wrote:

We have a new feature--consolidated metadata--that some of us (me!) are
eager to get into production.
Zarr releases quite infrequently compared to other OS projects I'm
involved in. (Our last release was 8 months ago.) The list of things to
fix for 2.3 https://github.com/zarr-developers/zarr/milestone/7
contains some hard items which potentially involve revising the spec.
@alimanfoo https://github.com/alimanfoo & @jakirkham
https://github.com/jakirkham, are all of the things on that list "must
haves" for a new release? Or perhaps we might consider a more frequent and
less ambitious release cycle?
Or maybe, although this is not a bugfix, we do a micro release?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/zarr-developers/zarr/issues/339, or mute the thread
https://github.com/notifications/unsubscribe-auth/AAq8Quu35soci6hJNo0LBVkRXWIrHRtCks5uw42dgaJpZM4YqY0g
.

Well personally I try not to release before going on vacation (US Thanksgiving). 😉 That said, not opposed to moving towards a release here.
Would be nice if we could get Numcodecs out the door first though as we've been working towards a release there recently and are pretty close.
Perhaps as a good first step towards a Zarr release it would be nice to have some testing of Zarr currently (particularly new features). Also it would be good to re-triage the 2.3 milestone and look to see what are critical bugs (need fixes) vs. cosmetic things (nice to haves). We can probably re-milestone the latter (unless they are particularly important to us).

Took the liberty to rename this issue "2.3 release planning", suggest we use issue this to discuss what remaining work is in scope for 2.3.

Agreeing with @jakirkham, in an ideal world it would be nice to get numcodecs 0.6 out first, then finalise and release zarr 2.3.
Part of the reason for this is that there's a fix in the new version of numcodecs for a bug in the current msgpack codec, which is currently worked around in the zarr tests (in fact the zarr tests assert the broken behaviour). So updating numcodecs would enable the zarr tests to get fixed, and this would also unlock a problem in another piece of work in zarr. See https://github.com/zarr-developers/numcodecs/pull/98 and https://github.com/zarr-developers/zarr/issues/324 for details.
However, the two releases are not strictly tied, so if there was pressure to release zarr and we get blocked on numcodecs, we could be flexible.
FWIW for Zarr 2.3 there are three bugs would be good to fix: #263, #272 and #253. Two of these (#272, #263) have a mature PR, the other (#253) hasn't been worked on yet but shouldn't be too complicated. The other issues currently tagged in the 2.3 milestone I could live with postponing.

Some issues cropped up related to NaT values recently. ( https://github.com/zarr-developers/zarr/issues/342 ) Expect this is pretty important to fix. So have given it a go. The fix involves changes in Numcodecs and Zarr. Fortunately they appear to require only a light touch. PRs are ready for review.

Thanks for entertaining my suggestion. I'm not saying this is super urgent, just that we might want to consider a release whenever we get a significant new feature or bug fix. Sounds like that is doable.
We are planning a bunch of pangeo demos in early December. So it would be great to have the release before then. But we can always set up environments that use the latest github master, so again, not super urgent.

FWIW I think it would be good to push for numcodecs and zarr releases
before the end of the year if not sooner. There is good momentum so a bit
of extra impetus to get something out the door is helpful!
On Thu, 22 Nov 2018, 01:53 Ryan Abernathey<EMAIL_ADDRESS>wrote:

Thanks for entertaining my suggestion. I'm not saying this is super
urgent, just that we might want to consider a release whenever we get a
significant new feature or bug fix. Sounds like that is doable.
We are planning a bunch of pangeo demos in early December. So it would be
great to have the release before then. But we can always set up
environments that use the latest github master, so again, not super urgent.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/zarr-developers/zarr/issues/339#issuecomment-440888530,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAq8QluPC2MffXeaf8qHkyR8GNP4rzJgks5uxgOngaJpZM4YqY0g
.

At this point, I think we just need more eyes on the PRs for v2.3. Nearly all of them already pass CI, but need a review and/or decision.

Alright, I think we should start thinking about the 2.3 release again. My suggestion would be the following remain on the milestone and everything else gets pushed off until the next release.

Complex fill value ( https://github.com/zarr-developers/zarr/issues/244 ) ( https://github.com/zarr-developers/zarr/pull/363 )
DirectoryStore race condition ( https://github.com/zarr-developers/zarr/issues/272 ) ( https://github.com/zarr-developers/zarr/pull/318 )

These all have PRs and AFAICT could be merged and then released today if we wanted to.
The other issues are about tricky Jupyter UI issues, changing getsize's behavior, supporting pathlib, and handling read-only stores through some APIs respectively. All of these will require more work and more thought. So I'd suggest that they be punted on and handled in a later release.
Thoughts @zarr-developers/core-devs?

I favor a release asap. Xarray 0.12.0 is coming soon (https://github.com/pydata/xarray/issues/2776) which has several zarr-related features (e.g. consolidated metadata). It would be nice if these happened around the same time.

Not sure if I'm too late to the party, but I'd love to see

Mutable mapping for Azure Blob #345

make it into the release.

Personally I'd also like to see PR ( https://github.com/zarr-developers/zarr/pull/309 ) integrated into the release as there are some people internally that are eagerly awaiting it. That said, I'd be ok sticking with my previous list (without any additions) to allow a faster turnaround.

Would be great to get the Azure blob store into the release, IIRC it is
basically ready to go.
On Sat, 23 Feb 2019, 23:05 jakirkham<EMAIL_ADDRESS>wrote:

Personally I'd also like to see PR ( #309
https://github.com/zarr-developers/zarr/pull/309 ) integrated into the
release as there are some people internally that are eagerly awaiting it.
That said, I'd be ok sticking with my previous list
https://github.com/zarr-developers/zarr/issues/339#issuecomment-465751825
(without any additions) to allow a faster turnaround.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/zarr-developers/zarr/issues/339#issuecomment-466709070,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAq8QtKvmuGUBp-surEn-8n-3NIDrGtrks5vQclUgaJpZM4YqY0g
.

Bumping this again. What are our thoughts on making a release?

I think we are all good to go for a relase. All the PR that have been brought up in the discussion have been merged. Xarray 0.12 just came out. Let's go!

Thanks so much @jakirkham for keeping up the momentum on this. I am all in favour of making a release. Would you like to do the honours?

Sure happy to move this forward. Will update if there are any issues.

Ok, ran into an issue releasing on conda-forge. ( https://github.com/zarr-developers/zarr/issues/419 ) Have put up PR ( https://github.com/zarr-developers/zarr/pull/420 ) to fix it. If someone can take a look, that would be great. If not, I can push ahead with that minor fix.

Packages for 2.3.1 are now available on PyPI and conda-forge.

Thanks so much @jakirkham for dealing with the release friction! This is thankless but important work!

Thanks also from me, fantastic to see this go out, :beers:

Thanks all for contributing! This is a very nice release 😄

Would anyone care to write a very short blog post about the release? This could go on Alistair's blog or we would be happy to host it on the Pangeo medium blog. Then we will have something to tweet about. :)

A blog post would be very cool. I started sketching something, contributions/comments very welcome:
https://docs.google.com/document/d/14qvMzK3HL20E63BqI3Q5EG_imoJ7h7pXhKBc_vVxnfY/edit?usp=sharing
@jakirkham you were the mastermind of this release, do you have a blogging channel you like to use?

No strong preferences on where we post it. Maybe it makes sense to have a blog for the Zarr project itself?

No strong preferences on where we post it. Maybe it makes sense to have a blog for the Zarr project itself?

That would be good. Use medium (like pangeo)? Vanilla jekyll site on github pages (i.e., zarr-developers.github.io)? I think I'd prefer jekyll and github pages just because it might be a bit easier to collaborate on writing blog posts via PRs, but no strong preference.
Btw I have two working days before going on leave for 3 weeks, so have a short window in which I could help. Also very happy for someone else to run with this if it's not done before I go away.

If you are comfortable setting up the framework for the repo, that would be very helpful.

I've created a new repo https://github.com/zarr-developers/zarr-developers.github.io which holds source for the blog served at https://zarr-developers.github.io. Creating a post just needs a new markdown file in the _posts folder, like the example one. If I get a chance today I'll make an initial PR to bring in the content from the google doc but am unlikely to be able to complete this before going on leave so please feel free to push forward without me.


Handle changes in output resolution from clients

Running sway in x11, initial resolution is the sum of my two monitors but is resized to only one:
[main.c:35] [wlc] Activating tty
[main.c:35] [wlc] WLC-1 Chose mode (0) 3360x1050
[handlers.c:118] Output 1 resolution changed to 3360 x 1050
...
[main.c:35] [wlc] Added output (1)
[main.c:35] [wlc] become active
[handlers.c:118] Output 1 resolution changed to 1676 x 1011
...

However, swaybar gets different values (modifications in swaybar main.c):
...
struct output_state *output = registry->outputs->items[desired_output];
sway_log(L_INFO, "Detected output size: %dx%d", output->width, output->height);

Output:
[main.c:245] Using output 0 of 1
[main.c:248] Detected output size: 3360x1050
[main.c:155] Running on output WLC-1

Expected output: 'Detected output size: 1676x1011'

I tried to figure out where the problem lies and added logging to the wayland registry display callbacks.
The output is
[registry.c:29] display_handle_geometry x=0 y=0 phy_w=0 phy_h=0 spx=0 make=Xorg model=X11 Window t:0
[registry.c:17] display_handle_mode flags=3 w=3360 h=1050 r=60000
The display_handle_geometry won't be called even if the resolution changes.
A quick look at the wlc sources showed that they also suscribe to x11 events, I guess we're not receiving any callbacks for this type of event.

I believe this was fixed as part of Cloudef/wlc@2cf560cf.


Revert "Add SKIP_PUSH_GCS env so we can run without a push to GCS"

Reverts GoogleCloudPlatform/kubernetes#4315

This broke our Jenkins build with:
+++ Building tarball: full
./hack/jenkins/build.sh: line 50: KUBE_SKIP_PUSH_GCS: unbound variable
Build step 'Execute shell' marked build as failure

Very sorry for the build break.  I will resubmit with a default-value.


Add Practice Exercise: luhn

Towards https://github.com/exercism/cairo/issues/113
Problem specification:
https://github.com/exercism/problem-specifications/tree/main/exercises/luhn
TODO:

generate the exercise with ./bin/fetch-configlet && ./bin/configlet create --practice-exercise luhn
check if any of the existing tracks (examples below) implement the exercise and you can reuse the implementation:

Go: https://github.com/exercism/go/tree/main/exercises/practice
Rust: https://github.com/exercism/rust/tree/main/exercises/practice
Python: https://github.com/exercism/python/tree/main/exercises/practice

use exercise's canonical-data.json to see which test cases to implement:
https://github.com/exercism/problem-specifications/blob/main/exercises/luhn/canonical-data.json

Created a PR for this, reassigning to myself


alpha: add support for nvidia jetson tx2 platform

Adds full support for NVIDIA Jetson TX2 including easily flashing over USB.

Added https://github.com/paralin/SkiffOS/commit/c2ca4573f2e6ca926d528de5c1abe5a82544c99a to fixup linter errors from check-package.

Added https://github.com/paralin/SkiffOS/commit/23b861125d41e95be005af2c251aca6c1099caed to add to Skiff readme.

Added additional Buildroot packages for container GPU support:

libnvidia-container
nvidia-modprobe
nvidia-container-toolkit
nvidia-container-runtime
skiff-core-linux4tegra
docker configuration files for nvidia GPU support

Final changes applied for merge to master


Maybe a typo in document?

what is $\lambda_{adc}$ in this equation? I think it is out_bound there.

Hi @Ther-nullptr. The Equation is correct. Let me explain. We have the constant out_bound which is set globally (let's say 12.0 for 8 bits). You can see from the equation that we clip with $$\beta^{adc quant}$$. This $$\beta^{adc quant}$$ is not the out_bound, but a scaled version of it per layer. This is because the layers of the neural networks have different input ranges and different weight ranges. Essentially, $$\beta^{adc quant}$$ is a version of the out_bound (which is $$\lambda$$), scaled by the input range ($$\beta^{inp quant}$$) and the weight range ($$max(abs(W))$$). Note that the weight normalization can be done per column (column = output) or per tensor (across all columns).
I hope this clarifies it a bit more. I am closing for now, but feel free to re-open.


'promise/catch-or-return' matches incorrectly with Cypress

Description
When using the rule promise/catch-or-return you get a error with Cypress because they have a then method.
https://docs.cypress.io/api/commands/then.html#Syntax
Steps to Reproduce

Create repo with this module and Cypress installed
Create integration file where you make use of then method. (see docs)

Expected behavior:
Need a way to exclude this since this isn't actually a promise.
Actual behavior:
This line is marked as needing a catch added but this isn't a promise.
Versions

Node version: v10.16.2
ESLint version: v5.3.0
eslint-plugin-promise version: v4.2.1

Additional Information
Not sure why the library thinks this is a promise but it shouldn't.

I got the same trouble

The reason it gets confused is because eslint doesn't run the code or have any idea on the actual types, it has to use heuristics to guess and the best one to use is if there's a method called .then()

The Cypress docs say .then() is modeled identically to the way Promises work in JavaScript.

Eslint already provides a way to disable a rule per file using `/* eslint-disable promise/catch-or-return*/

You can also disable per-folder (such as your testing folder) with a custom eslintrc.js file

That all being said....is the parent variable always called something like cy. If that's the case it would be possible to exclude it.

AFAIK and according to the docs, there's always the top-level global variable named cy in Cypress call chains

The same problem occurs if prefer-await-to-then is enabled. Detecting cy would be a good heuristic, but not fully reliable if one is using utilities to call cy. Still, might be helpful to avoid the need for overrides.


Get proper credits/citation for deface_spineGeneric_usingR

This function is a wrapper for regular_deface.r and special_deface.r, which are themselves wrappers for face_removal_mask(). There should be a mention about the source of the code (was it copy/pasted from somewhere else? Who is the author?)

I adapted the code suggested in this issue.

my point was that your scripts needs to indicate the author, source, modified from XXX, is the license compatible, etc.


Add sqlite-vec example

We should absolutely have a rock solid sqlite-vec example working end to end.

FYI sqlite-vec now has stable releases (0.1.X), with official Go bindings described here: https://alexgarcia.xyz/sqlite-vec/go.html
Happy to help review/give feedback as needed! I'm not the best at Go so probably can't give a PR myself, but happy to review anything sqlite-vec related


Add meetups to homepage

The meetups come from this https://github.com/open-austin/meetup-proxy-aws-lambda

:heart:


Use multistage builds

It should be easier to maintain and faster to build and deploy new images when we use multistage docker builds.
Any ideas what files we need to copy from official node image?
from /usr/local/bin:

node
npm -> ../lib/node_modules/npm/bin/npm-cli.js
npx -> ../lib/node_modules/npm/bin/npx-cli.js
yarn -> /opt/yarn/bin/yarn
yarnpkg -> /opt/yarn/bin/yarn

from /usr/local/lib:

node_modules

from /opt:

yarn

Am i missing something?
Anyone with better linux experience. Are there any issues with copied binaries?
Any potential performance degradation ?

I made first commit for combination 2-10 https://github.com/radeno/docker-ruby-node/tree/multistage/2-10 and build Docker images https://hub.docker.com/r/smikino/ruby-node/tags/
Size is identical (node manual is not copied), but build time is just couple of minutes on Docker Hub.
There are some issues because Docker COPY command can't copy symbolick links. So they must be created but RUN command.

I think this is the way to go forward. Would you be interested in creating a PR for this repository @radeno?

@Starefossen i could make PR. no problem for me. But need deeper testing

#32 PR


Terminal tab should surface split information in aria label

Testing #122242
Have multiple terminal tabs open. In one tab have a couple of split terminals. Visually they look like they belong to a tree, however this information is not conveyed to the screen reader. Here are some ideas on how to improve this:

Put aria-level = 2 for elements that are inside the tree. Currently all elements have an aria-level = 1. If you prefer to leave it like that then the role of the whole thing should be a list and not a tree
Modify aria label of an element in case he is part of a split

We're converting this into a list next iteration https://github.com/microsoft/vscode/issues/121745, I think we need to indicate to the screen reader that it's a split though. Not sure how the special characters are read out now.

@isidorn hmm, should we be surfacing the fact that it's a split terminal to the screen reader at all? I think it's purely a UI feature so it shouldn't make a difference if you can't see the UI?

@Tyriar oh great that you moving to the list. You should have a correct role list then.
I would still convey the group number as part of the aria label, since we do the same for editors in editor groups. It is useful for users to know how things are grouped on the screen in case there are navigation actions like switch tab, or move focus inside a terminal tab. Just make sure that the group label is at the end of the list element aria label so it is easy to skip.

Good point 👍

Scoped this issue down, conversion to list will be handled in #121745

I see the code changes which look good, however when I try this out the group is not applied to the aria label, it is the same as before.
I have a ZSH, one tab with one terminal, and another tabs with two terminals. And all their labels are just zsh

When I inspect a split terminal tab label, it has the correct aria label.

Oh but you are setting the aria-label on the wrong HTML element label-name
You should use the List AccessibilityProvider so the aria-label is properly set on the monaco-list-row element. It has to be on that element, since that element has focus and that is what the Screen Reader will read.
So I think it should be fixed here
https://github.com/microsoft/vscode/blob/main/src/vs/workbench/contrib/terminal/browser/terminalTabsWidget.ts#L67


Update AWS benchmarks

@gfinol Do you know why the invocation starts after 10 seconds?

@JosepSampe No idea. I believe I had the default settings for AWS. I'll review them and check that everything is okay.

Just another question. The old experiments took 70 seconds to finish. The new experiments take 35 seconds to finish. Do you know why it performs 2x better? Did you use 1GB of memory for the new ones?

@JosepSampe. I noticed the improvement in the flops experiment, but as I was using 1GB of memory per function, I just assumed that AWS improved their machines.
I've used the same parameters that are specified in the READMEs.  Which I believe are the ones used in the old experiments.
Flops benchmark:
python flops_benchmark.py --backend aws_lambda --loopcount=5 --matn=4096 --tasks=1000 --memory=1024 --outdir=aws_lambda

Read/Writte:
python os_benchmark.py run -b aws_lambda -s aws_s3 --mb_per_file=512 --bucket_name=[my_bucket] --number=1000 --outdir=aws_s3

Ok, cool! Yes, the parameters are ok, so probably they improved the amount of CPU per function by 2x


Raise an exception for boolean and nil values

Paired w/ @sebastien-coavoux
See #5 and discussion on onetimesecret/onetimesecret#238.
Familia now raises an exception when setting a hash key with a boolean or nil value.
HashKey objects are stored as hashes in redis. When setting a hash key,
we choose to raise an exception if the value is a boolean or nil.
e.g. hashkey["test"] = true
This is a conservative approach to avoid unexpected behavior when
reading the value back. Unlike object serialization with JSON or YAML,
redis hash key values are always strings. Without a more nuanced way to
configure types, there's no way for Famila to tell the difference
between "true" as in true and "true" as in the literal string "true". We
may revisit in future versions.@sebastien-coavoux

I am ok with raising an Exception for those case but then we need to change onetimesecret code to avoir assigning any bool / nil in the code. As of now there are still occurences of such assignation

Yeah we'll definitely want to do that. The Customer.verified field for example, is an example of a boolean field that expects the value to be stored as a string. We want to make sure all cases do that.


Ignore empty folder placeholder files on S3

These files are created by the Hadoop file system to indicate empty folders.

Thanks, removed the config.

@rohangarg messaged me on slack with the suggestion we move this change to https://github.com/prestosql/presto/blob/master/presto-hive/src/main/java/io/prestosql/plugin/hive/util/HiveFileIterator.java#L86 Do you have a preference @electrum ?

messaged me on slack with the suggestion we move this change to https://github.com/prestosql/presto/blob/master/presto-hive/src/main/java/io/prestosql/plugin/hive/util/HiveFileIterator.java#L86 Do you have a preference?

One benefit of the split generation change approach could be that it handles custom S3FileSystemType as well..

@rohangarg messaged me on slack with the suggestion we move this change to https://github.com/prestosql/presto/blob/master/presto-hive/src/main/java/io/prestosql/plugin/hive/util/HiveFileIterator.java#L86 Do you have a preference @electrum ?

Not electrum here, but I think it would be a good idea not to .filter those out here, but use it to set the isdir property here instead.
That way it can be up to the caller to decide whether they want to filter those out or not (maybe via Hadoop's PathFilter API), but doing this directly for now in HiveFileIterator like you mentioned makes sense.

I think it would be a good idea not to .filter those out here, but use it to set the isdir property here instead.

@pettyjamesm the xxx_$folder$ itself is not a directory.  It is supposed not to exist and to cause xxx be treated as a folder.
I'd rather ignore them for now and reiterate when we see a need for that. This would help us provide better test cases too.

A follow-up: https://github.com/prestosql/presto/issues/4566

Renamed, thanks @findepi

A note on filtering in HiveFileIterator -- ive does not ignore those empty files when running on hdfs://
so if we do ignore them, this may lead to some problems for end users.
This is file system specific so let's treat this on file system level.
I've created a follow up for Hive w/caching -- https://github.com/prestosql/presto/issues/4566

Merged, thanks!


Fixed renderflex overflow in signup page

Closes #10
An easy fix, wrapped the whole Container widget with SingleChildScrollView widget. Let me know if you want any changes in this PR. Thank you!

@shagun25 can you please add the CrossWoC label?


Adding an ETag header for local packager

This is much needed for my local development pipeline. I am downloading various JS packages in the background and running them after they've been fully downloaded.

LGTM, will let @amasad do a final review and merge

Removed the unused line, thanks for the review!

Hold on this, I believe a few things need to change for the ETag to be fully functional and useful. (I'm planning on using it as a cache header)

I've updated the packager to actually respond with a 304 if the Etags are a match. This is now good to go @amasad. I would be soooo happy if this was merged to master today. :) Thanks!

@MattFoley also could you squash your commits?

Will have this updated in just a few.

Now using if-none-match to follow spec appropriately and I've squashed the commits into one.

@amasad @frantic Sorry to ping you again, but is there any way one of you could give this a thumbs up/ thumbs down?

LGTM, but please check with @amasad

Separately (in this commit or another PR) it would also be nice to have unit tests since broken etags are hard to notice.

About a month now with no updates on this pull request. Any status updates?

@ide now that this pull request has lived so long, (I've basically rewritten the changes this morning) how do you suggest I squash these? Should I close and reopen this PR from a different branch?

Rebase against master and squash your commits at the same time.

No, too many issues with trying to merge in these ~10 lines of code (something like 300 commits). I'm closing this and opening a new pull request.

See this commit: https://github.com/facebook/react-native/pull/2473


Support Curator Service Discovery and Spring Cloud ZooKeeper

Motivation:
Related #2673.
It will be nice if we support Curator Service Discovery and Spring Cloud Zookeeper.
Modifications:

Add ZookeeperRegistrationSpec and ZookeeperDiscoverySpec to specify whether use legacy format or Curator compatible format.

(Breaking) You should specify ZookeeperRegistrationSpec When creating ZookeeperUpdatingListener.
(Breaking) You should specify ZookeeperDiscoverySpec When creating ZookeeperEndpointGroup.

(Breaking)

NodeValueCodec is gone.

You now have to use ZookeeperRegistrationSpec and ZookeeperDiscoverySpec to encode and decode.
ZooKeeperEndpointGroupBuilder.codec(...) and ZooKeeperUpatingListenerBuilder.codec(...) are gone as well.

Result:

You can now use Armeria client and server with Curator Service Discovery.

Todo:

Documentation

/cc @jonefeewang (who did the initial implementation of ZooKeeperEndpointGroup)

DiscoverySpec -> ZookeeperDiscoverySpec
InstanceSpec -> ZookeeperRegistrationSpec

Thanks I will change to use RegistrationSpec.

Should we remove Zookeeper for brevity? 🤔

Isn't it okay not to use Zookeeper?
CuratorXRegistrationSpec, LegacyRegistrationSpec will be fine I guess.

ServerSets is the last missing piece of ZK service discovery. Way to go, @minwoox :tada:

I'm on my way. 🚗


added onFinished() handler

issue https://github.com/koajs/koa/issues/1089
for example
const Koa = require('koa');
const fs = require('fs');

const app = new Koa()

app.onFinished = (err, res) => {
  console.log(`err = ${err}`);
}

app.use(ctx => {
  ctx.body = fs.createReadStream('./large');
}).listen(3000)

Why is this better than simply just using ctx.onerror? Sorry.

yes, what's the use case for this? this feature should add an additional "onFinished" handler, not replace the default, but i don't even know a use case for that

close for now, feel free to reopen it if necessary


Add shortcut url for blockheight filtering on /table

Current behavior

Filtering on address and version only.

Expected behavior

Add a blockheight filter e.g. /table/filterbyblockheight/105665

Fixed by #103


Add support for GitHub Container Registry tools

Split out from #4002. This should implement part 2 of #4002: add support for GitHub Container Registry tools either via the existing tools feature or sync up with GitHub Apps but for tools #3476.
┆Issue is synchronized with this Jira Story
┆Attachments: image-20220209-145353.png
┆fixVersions: Dockstore 1.12
┆friendlyId: DOCK-1857
┆sprint: SEAB 79- Gary (the snail)
┆taskType: Story

gathering GHCR image information like checksums. is probably more important because it would also be applicable to workflows that use GHCR images.
GHCR tools will be registered using the “Create tool with descriptors on remote sites” option a bit less important since we should be slowly discouraging old-style tools based on github apps discussion

gathering GHCR image information like checksums. is probably more important because it would also be applicable to workflows that use GHCR images.

Workflows currently do gather checksums for GHCR images, implemented here: https://github.com/dockstore/dockstore/pull/4352.
We're just missing gathering checksums for GHCR tools on refresh (like we do for other image registries: https://docs.dockstore.org/en/stable/advanced-topics/checksum-support.html#docker-image-checksum-support).


Custom initialization based on media preferences

It would be great if this mermaidJS plugin could support allowing for a custom initialize block with mkdocs - as mkdocs-material (for example) supports a "preferences" which allows one to automatically switch between light/dark theme. A similar effect can be done with something like
mermaid.initialize({
    theme: (window.matchMedia && window.matchMedia('(prefers-color-scheme: dark)').matches) ? 'dark' : 'light'
 });

but how does one override the injection of this JS and provide your own?

Actually, I think I figured it out (it would be great to add this to documentation!). It's brilliant to have the ^ literal implementation as that allows one to inject arbitrary JS code nicely. As such, the following worked:
plugins:
  - search
  - mermaid2:
      arguments:
          theme: |
            ^(window.matchMedia && window.matchMedia('(prefers-color-scheme: dark)').matches) ? 'dark' : 'light'

and it allows the theming of the mermaidJS diagrams to switch automatically :)

This is great !
I agree it would be great to add this to the documentation. Would you like to make a PR, to insert this in the README.md, under "Tips and Tricks"?


Relationships to not require a View specified

Potential Issue
Currently it seems a view is required to process any type of relationship.
ticket_view.ex

def relationships, do: [ticket_categories: MyProject.TicketCategoryView]

Right now, the below is needed because encode_data is called recursively through all the relationships and asks for each relationships view.
ticket_category_view.ex

def relationships, do: [category: MyProject.CategoryView, ticket: MyProject.TicketView]

example payload
{
  "relationships": {
    "ticket-categories": {
      "data": [{"id": "1234", "type": "ticket-category"}]
    }
  }
}

Brainstorming a solution
Since I'm most likely missing something, the first step for me would be to understand the need for a relationship's view.  In this case, it seems what might be ok to do is something like.
[ticket_categories: %{type: "ticket-category", field: "ticket_category_id"}]
Then one option during serialization of the data would have the lib do Map.get(ticket_data, field) to get the id for the relationship instead of recursively moving down the relationship tree.
Would appreciate some thoughts.  I would love to open a PR!

@snewcomer
History: The reason I require a view is because it allows the user to define an id callback on their view to define their own id's. Otherwise the default is to just pull the id from the model. https://github.com/jeregrine/jsonapi/blob/master/lib/jsonapi/view.ex#L83-L85 I try to provide smart defaults and allow almost anything to be overridden.

I'm not sure I understand the problem enough to comment on your proposal though. It seems like you could just create a View and it would just work?

Also @snewcomer your proposal would never allow the relationship to be included as it wouldn't know how to render it.

Yep I think I am wrong here.  Thanks for the explanation!
Doing some perf testing with benchee so will see if I find anything.

Thanks @snewcomer! Lemme know if have any questions or if you have pr's to make your life easier I'll gladly accept.


Implement Reusable Pie Chart Component Using JavaScript and Styled Components

We would like to add a Pie Chart component to our project, implemented using JavaScript and Styled Components, to visualize data in a more engaging and informative way.

Example Usage
Here's an example of how the Pie Chart component could be used within our project:
import React from 'react';
import PieChart from './PieChart';
const data = [
{ label: 'Logs', value: 30, strokeColor: '#000'},
{ label: 'Metrics', value: 40,strokeColor: 'red'},
{ label: 'Traces', value: 20 },
];
function App() {
return (

Distribution

);
}
export default App;

@alonkeyval Are you utilizing any npm packages or are you solely using plain JavaScript?

@ronisarkarexe  We do not use a third-party lib at the moment but we do not rule out the possibility of it for the use of the graphs

@alonkeyval can you assign me

Assigned @ronisarkarexe


Add TM watermark to figures

We can use https://www.npmjs.com/package/chartjs-plugin-watermark to easily add the transitmatters logo somewhere in the page


Fixup make release versioning

What does this PR do?
Fix further issues with make-release script (images being tagged 0.10.0 instead of v0.10.0).
What issues does this PR fix or reference?
Is it tested? How?

PR Checklist

[ ] E2E tests pass (when PR is ready, comment /test v8-devworkspace-operator-e2e, v8-che-happy-path to trigger)

[ ] v8-devworkspace-operator-e2e: DevWorkspace e2e test
[ ] v8-che-happy-path: Happy path for verification integration with Che

Happy path test is failing for other reasons today.


Fix demo included in download

Fix demo by updating link to angular bootstrap. Now included in the bower file instead of being pulled from github url.
Some line spaces also got updated.

lgtm


Tensorflow has not supported operator [Div] with name [Div].

Hi I am having trouble converting a model from Tensorflow to the intermediate format (eventually I want to convert to PyTorch):
mmtoir -f tensorflow -w v1.pbtxt --inNodeName=input --dstNodeName output --inputShape 224,224,3 -o v1
I get this error from /mmdnn/conversion/tensorflow/tensorflow_frozenparser.py, line 448:
Tensorflow has not supported operator [Div] with name [Div].
Is the [Div] operation really not supported or am I doing something wrong?
Thanks!
Python version: 2.7.16
Source framework with version (like Tensorflow 1.4.1 with GPU): Tensorflow 1.14.0 with GPU
Destination framework with version (like CNTK 2.3 with GPU): Pytorch 0.4.0 with GPU

Hi @e-271, could you please share your model?

@e-271 , thank you very much for the feedback. Would you please share your model for our diagnosis?


Add title in notification

how to add header when sending notification

Would like an answer to this as well, if at all possible.
Thanks in advance! :)


JS tests broken

Javascript tests and kite_init are broken, after running kite_init and running c the test doesn't compile with the following error:
[INFO] Scanning for projects... [ERROR] [ERROR] Some problems were encountered while processing the POMs: [FATAL] Non-resolvable parent POM for org.webrtc.kite:broadcaster-test:0.0.1: Failure to find org.webrtc.kite:kite-base:pom:2.0.7 in https://repo.maven.apache.org/maven2 was cached in the local repository, resolution will not be reattempted until the update interval of central has elapsed or updates are forced and 'parent.relativePath' points at wrong local POM @ line 8, column 11 [WARNING] 'version' contains an expression but should be a constant. @ org.webrtc.kite:kite-framework:${kite.framework.version}, /home/gintautas/Projects/KITE/KITE-Framework/pom.xml, line 14, column 12 [WARNING] 'version' contains an expression but should be a constant. @ org.webrtc.kite:kite-engine:${kite.version}, /home/gintautas/Projects/KITE/KITE-Engine/pom.xml, line 14, column 12 [WARNING] 'version' contains an expression but should be a constant. @ org.webrtc.kite:apprtc-test:${kite.apprtc.version}, /home/gintautas/Projects/KITE/KITE-AppRTC-Test/pom.xml, line 16, column 12  @  [ERROR] The build could not read 1 project -> [Help 1] [ERROR]    [ERROR]   The project org.webrtc.kite:broadcaster-test:0.0.1 (/home/gintautas/Projects/KITE/KITE-Broadcaster-Test/pom.xml) has 1 error [ERROR]     Non-resolvable parent POM for org.webrtc.kite:broadcaster-test:0.0.1: Failure to find org.webrtc.kite:kite-base:pom:2.0.7 in https://repo.maven.apache.org/maven2 was cached in the local repository, resolution will not be reattempted until the update interval of central has elapsed or updates are forced and 'parent.relativePath' points at wrong local POM @ line 8, column 11 -> [Help 2] [ERROR]  [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch. [ERROR] Re-run Maven using the -X switch to enable full debug logging. [ERROR]  [ERROR] For more information about the errors and possible solutions, please read the following articles: [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/ProjectBuildingException [ERROR] [Help 2] http://cwiki.apache.org/confluence/display/MAVEN/UnresolvableModelException
And when trying to run any of the javascript tests I get this error:
off java -Dkite.firefox.profile=/home/gintautas/Projects/KITE/third_party/firefox-h264-profiles/ -cp /home/gintautas/Projects/KITE/KITE-Engine/target/kite-jar-with-dependencies.jar:target/* org.webrtc.kite.Engine ./configs/js.iceconnection.apprtc.config.json 2020-09-29 16:03:43,216 INFO  - Reading '/home/gintautas/Projects/KITE/KITE-AppRTC-Test/./configs/js.iceconnection.apprtc.config.json' ...  2020-09-29 16:03:43,230 ERROR - javax.json.stream.JsonParsingException: Invalid token=CURLYCLOSE at (line no=34, column no=5, offset=874). Expected tokens are: [STRING] 	at org.glassfish.json.JsonParserImpl.parsingException(JsonParserImpl.java:437) 	at org.glassfish.json.JsonParserImpl.access$1000(JsonParserImpl.java:79) 	at org.glassfish.json.JsonParserImpl$ObjectContext.getNextEvent(JsonParserImpl.java:489) 	at org.glassfish.json.JsonParserImpl.next(JsonParserImpl.java:363) 	at org.glassfish.json.JsonParserImpl.getObject(JsonParserImpl.java:333) 	at org.glassfish.json.JsonParserImpl.getValue(JsonParserImpl.java:182) 	at org.glassfish.json.JsonParserImpl.getArray(JsonParserImpl.java:326) 	at org.glassfish.json.JsonParserImpl.getValue(JsonParserImpl.java:180) 	at org.glassfish.json.JsonParserImpl.getObject(JsonParserImpl.java:339) 	at org.glassfish.json.JsonParserImpl.getObject(JsonParserImpl.java:173) 	at org.glassfish.json.JsonReaderImpl.readObject(JsonReaderImpl.java:112) 	at io.cosmosoftware.kite.util.TestUtils.readJsonFile(TestUtils.java:842) 	at org.webrtc.kite.config.Configurator.buildConfig(Configurator.java:80) 	at org.webrtc.kite.Engine.buildConfig(Engine.java:75) 	at org.webrtc.kite.Engine.main(Engine.java:153)  2020-09-29 16:03:43,230 FATAL - FATAL Error: KITE has failed to start execution  java.lang.NullPointerException 	at org.webrtc.kite.config.Configurator.buildConfig(Configurator.java:82) 	at org.webrtc.kite.Engine.buildConfig(Engine.java:75) 	at org.webrtc.kite.Engine.main(Engine.java:153) Exception in thread "main" java.lang.NullPointerException 	at org.webrtc.kite.Engine.main(Engine.java:155)
Any help fixing this would be appreciated.

Hello,
the JS library is not as supported as the Java since we work mostly in Java. Currently, we do not have the bandwith to look into this but will prioritize your problem as soon as possible.


EAS BUG : --auto-submit and --json don't work together as expected

Build/Submit details page URL
No response
Summary
When using the --auto-submit with --json flag for the build process, the output JSON is not generated as expected
Do not work as expected artifact URL is NOT present in JSON :
eas build -p ios --profile production --non-interactive --auto-submit --json
Work as expected artifact URL is present in JSON:
eas build -p ios --profile production --non-interactive --json
Managed or bare?
Managed
Environment
expo-env-info 1.0.5 environment info:
System:
OS: macOS 12.6
Shell: 5.8.1 - /bin/zsh
Binaries:
Node: 18.17.1 - ~/.nvm/versions/node/v18.17.1/bin/node
Yarn: 1.22.19 - /opt/homebrew/bin/yarn
npm: 9.6.7 - ~/.nvm/versions/node/v18.17.1/bin/npm
Managers:
CocoaPods: 1.12.0 - /opt/homebrew/bin/pod
SDKs:
iOS SDK:
Platforms: DriverKit 21.4, iOS 16.0, macOS 12.3, tvOS 16.0, watchOS 9.0
IDEs:
Android Studio: 2022.3 AI-223.8836.35.2231.10671973
Xcode: 14.0/14A309 - /usr/bin/xcodebuild
npmPackages:
@expo/webpack-config: ^0.17.4 => 0.17.4
expo: ~49.0.6 => 49.0.6
react: 18.2.0 => 18.2.0
react-dom: 18.2.0 => 18.2.0
react-native: 0.72.3 => 0.72.3
react-native-web: ~0.19.7 => 0.19.7
Expo Workflow: bare
Error output
json url=null
Reproducible demo or steps to reproduce from a blank project
eas build -p ios --profile production --non-interactive --auto-submit --json
eas build -p ios --profile production --non-interactive --json

Same problem here.

@LeoAnt02
I dodged the problem by retrieving the buildUrl with the EAS build:list command after the build was done.
So, first you make the build with:
eas build -p ios --profile production --non-interactive --auto-submit

Then, you get the info json from the previous build:
eas build:list --platform=ios --buildProfile=production --status=finished --limit=1 --json --non-interactive

And, for example, if you need to do that in a bash script like me, you can do that:
BUILD_INFO=$(eas build:list --platform=ios --buildProfile=production --status=finished --limit=1 --json --non-interactive)
echo $BUILD_INFO
BUILD_URL=$(echo $BUILD_INFO | grep -o '"buildUrl": "[^"]*' | grep -o '[^"]*$')
echo $BUILD_URL

I hope this helps

@GuillaumeD-dougs
We ended up with something similar using jq and more variables for debugging purposes
sudo apt-get install -y jq
BUILD_OUTPUT_JSON=$(eas build -p android --profile production --non-interactive --auto-submit --json)
BUILD_OUTPUT_ID=$(echo $BUILD_OUTPUT_JSON | jq -r '.[0].id')
BUILD_OUTPUT_INFO=$(eas build:view $BUILD_OUTPUT_ID --json)
BUILD_OUTPUT_URL=$(echo $BUILD_OUTPUT_INFO | jq -r '.artifacts.buildUrl')


Broken table in labs/GradeCalculator

https://github.com/princomp/princomp.github.io/blob/c3c4fb718277f70da37d2a693f2533b70bd51637/source/labs/GradeCalculator.md?plain=1#L22-L27
Update to quartz-supported format

https://github.com/princomp/princomp.github.io/commit/0821c0a62340edaaee49ebc14e817f2dd9ea5948 fixes this.


references drop et al. after first occurrence

Waiting for upstream fix https://github.com/quarto-dev/quarto-cli/issues/10105

Copying  my solutuon from comments from other issue (for the people who might need this)
try to install typst 0.11.1 via official installer https://github.com/typst-community/typst-install and point to it/export export QUARTO_TYPST=/path/to/typst0.11.1 from their .zhsrc or .bashrc; this will work for mac/linux, not sure about Windows

Thanks. Will this affect rendering documents in RStudio, shell, or both?

I set it globally and I don't see any problem; if someone doesn't want to modify variable globally (it can work with the preview with vscode, setting variables there was always tricky for me) it should be possible to do run quarto with other version of typst  "less invasive"':

set it locally just for specific render via makefile recipe
by adding  alias in .zshrc/.bashrc for example
alias newtypst='QUARTO_TYPST=/path/to/typst0.11.1 quarto'


SBT testOnly commands don't show specific test packages to run

Expected Behavior
When firing up an SBT console and typing testOnly + , I expect to see paths to all available test packages.
Actual Behavior
No individual test classes/packages are displayed.

User error here?

This can be closed right? Fixed with #128 ?

No, separate issue. From the docs it sounds like SBT supports tab completion for tests out of the box.
Here's more SBT console output, the last few lines are the result of pressing tab to see (at least I hoped to see) a list of test packages to run:
17:54:54 › sbt -Djava.library.path=secp256k1/.libs
[info] Loading global plugins from /Users/mec/.sbt/0.13/plugins
[info] Loading project definition from /Users/mec/Sites/crypto/bitcoin-s-core/project
[info] Set current project to bitcoin-s-core (in build file:/Users/mec/Sites/crypto/bitcoin-s-core/)
> testO
testOnly      testOptions
> testOnly
--
> testOnly
--
> testOnly
--
> testOnly
--
> test:compile
[success] Total time: 7 s, completed Mar 26, 2018 5:55:37 PM
> compile
[success] Total time: 0 s, completed Mar 26, 2018 5:55:39 PM
> testOnly org.bitcoins.core.protocol.transaction
[info] ScalaTest
[info] Run completed in 65 milliseconds.
[info] Total number of tests run: 0
[info] Suites: completed 0, aborted 0
[info] Tests: succeeded 0, failed 0, canceled 0, ignored 0, pending 0
[info] No tests were executed.
[info] Passed: Total 0, Failed 0, Errors 0, Passed 0
[info] No tests to run for test:testOnly
[success] Total time: 1 s, completed Mar 26, 2018 5:55:44 PM
> testOnly
--
> testOnly
--
> testOnly
--
> testOnly

Hm looks like it may be an issue with 0.13.13 SBT version: https://github.com/sbt/sbt/issues/2822

@Christewart confirmed it's an SBT bug as you can see here:

Will open a quick PR to bump to 0.13.17, the latest in the 0.x.x release series.
Or should we just go to the 1.x.x releases?

Closed by #132


[Coverity CID :188753]Incorrect expression in /subsys/net/ip/connection.c

Static code scan issues seen in File: /subsys/net/ip/connection.c
Category: Incorrect expression
Function: net_conn_unregister
Component: Networking
CID: 188753
Please fix or provide comments to square it off in coverity in the link: https://scan9.coverity.com/reports.htm#v32951/p12996

Already fixed


Close modal on other keys than ESC

It would be nice to close the Materialize modal on other keys then ESC (for example Enter). Is it possible to add this to the options given to openModal()? Something like this:
...
openModal: function(options) {
$('body').css('overflow', 'hidden');
var defaults = {
opacity: 0.5,
in_duration: 350,
out_duration: 250,
ready: undefined,
complete: undefined,
dismissible: true,
starting_top: '4%',
closeKeyCode: 27 //<-- ESC on default
},
...
$(document).on('keyup.leanModal' + overlayID, function(e) {
// Instead of--> if (e.keyCode === 27) {   // ESC key
if (e.keyCode === closeKeyCode){ // <-- use this. Maybe even with an array of closeKeyCodes?
$modal.closeModal(options);
}
});
...

You can replace
Materialize.js :
Line 766
if (e.keyCode === 27 )
with
if (e.keyCode === 13 || e.keyCode === 9)
or other keycodes

Shift key = 16
Ctrl = 17
Esc = 27
Alt = 18
Spacebar = 32

Reply to this thread if you're not satisfied with the answer or if its not the expected solution.
Happy to help!


Microsoft.windows sdk.10.0.20348 10.0.20348.0 0f8bc53c dd8e 4fff b25d b248f609cf74

[ ] Have you signed the Contributor License Agreement?
[ ] Have you checked that there aren't other open pull requests for the same manifest update/change?
[ ] This PR only modifies one (1) manifest
[ ] Have you validated your manifest locally with winget validate --manifest <path>?
[ ] Have you tested your manifest locally with winget install --manifest <path>?
[ ] Does your manifest conform to the 1.5 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

I also see that one could be a merge path. It might be here.

It seems this pipelines is taking longer than expected.

But it is not, It write display version entries as I see. Suppose need to matches with 0 file

I failed to start the excel.

My one of the PR keep mentioned stephengillie

https://dev.azure.com/ms/ed6a5dfa-6e7f-413b-842c-8305dd9e89e6/_apis/build/builds/510914/logs/18

I renamed the branches.


Remove empty IE alert function in template-tags.php

https://github.com/bootscore/bootscore/pull/53

Remove in v6
Readded https://github.com/bootscore/bootscore/pull/258
https://github.com/bootscore/bootscore/issues/257#issuecomment-1249277040

Think we should remove the entire IE warning script.


Goquery returns empty value in a specific case.

Hi. I want to scrape the website that requires login.
This website's login page requires ID, password and token that contained in login page HTML source.
The problem is Goquery only returns an empty value for the "token" value.
The token string length is long, maybe the string length is a problem?

Here is example code.
package main

import (
	"fmt"
	"log"
	"net/http"
	"net/http/cookiejar"

	"github.com/PuerkitoBio/goquery"
)

type App struct {
	Client *http.Client
}

func main() {
	jar, _ := cookiejar.New(nil)

	app := App{
		Client: &http.Client{Jar: jar},
	}

	loginURL := "https://dhlottery.co.kr/user.do?method=login&returnUrl="
	client := app.Client

	response, err := client.Get(loginURL)
	if err != nil {
		log.Fatal("Error fetching response.", err)
	}

	defer response.Body.Close()

	document, err := goquery.NewDocumentFromReader(response.Body)
	if err != nil {
		log.Fatal("Error loading HTTP response body. ", err)
	}

	tokenVal, _ := document.Find("input[name='token']").Attr("value")
	tokenType, _ := document.Find("input[name='token']").Attr("type")
	fmt.Println(tokenVal)	// empty result
	fmt.Println(tokenType)	// correct result: "hidden"

}

Hello,
It's possible that the value is added via javascript, and is not part of the html actually passed to goquery. In that case, if you're interested you can check out the wiki, there are a few community-provided examples of using goquery for javascript-generated html. If that's not the case, try to create a small program that reproduces the issue with a minimal static html string.
Hope this helps,
Martin


WIP: Add Wavelet filter for phasor coordinates

Description
This PR proposes the addition of phasor_filter_wavelet function in the phasorpy.phasor module. The implementation is based on pawFLIM.
The implementation of this filter was proposed and discussed in #99.
Don't merge: this is a Work In Progress. Tests and documentation are still missing.
Checklist

[x] The pull request title and description are concise.
[x] Related issues are linked in the description.
[x] New dependencies are explained.
[x] The source code and documentation can be distributed under the MIT license.
[x] The source code adheres to code standards.
[ ] New classes, functions, and features are thoroughly tested.
[ ] New, user-facing classes, functions, and features are documented.
[ ] New features are covered in tutorials.
[x] No files other than source code, documentation, and project settings are added to the repository.

Hi @cgohlke, I started this PR so that we can discuss some aspects on the next PhasorPy meeting if you are able to take a look at this implementation.
This is still a WIP so there are tests and documentation missing.
Based on our discussions with Mauro, I tried implementing the wavelet filter based on pawFLIM. There are some aspects that would need further discussion:

Using pawFLIM might not be the most efficient implementation since it needs the unnormalized phasor coordinates as complex values and then internally calculates the normalized phasor coordinates again (more than once), which seems not optimized in our case since we work mostly with normalized phasor coordinates already.
In #99 it was discussed that pawFLIM needs as input the n(th) and 2n(th) harmonic to filter the n(th) harmonic, but I believe it also filters the 2n(th) harmonic, not only the n(th).
From the previous point, it also needs discussion how to handle the harmonics that don't have the 2n(th) harmonic for calculation. Should they be omitted from filtering? Do we raise an error in this case?
Maybe try another implementation of wavelet filters that don't need higher harmonics?
The NaN handling was also discussed in #99. An approach I think makes sense is to convert NaN to 0 in the mean, real and imag components for filtering and then convert again to NaN propagating for values where the mean is 0. Should the NaN be also applied for coordinates with 0 value for real and imag when they are unnormalized (after filtering). I tested keeping the NaN when filtering but the results were really unsatisfactory. With just few 'levels' you loose too many pixels due to NaN propagation. I can show this on the next meeting.

These are some of the aspects that I believe need further discussion before moving forward with the implementation, testing, documentation, etc., for this approach to wavelet filtering.


XLSX.read method not giving the proper xsl object while sending the base 64 string

@SheetJSDev :
Hi Team ,
I have used your method:
XLSX.read and passed base 64 string . In the response it is not parsing properly and giving worng data.
Below is the code:
<input type="file" name ="file" onChange={(e)=>this.onChange(e)}/>
onChange(e) {
var files = e.target.files;
var reader = new FileReader();
reader.readAsDataURL(files[0]);
reader.onload=(e)=>{
const workbook = XLSX.read(e.target.result, { type: "base64" });
console.log(workbook);
}
Test.xlsx : I have uploaded
Base64 : I have converted into base 64 string
ParsedError.docs:  It contains screenshot after the parsing. It seems your method is not working as expected. Can you please help me what I am doing wrong.
Test.xlsx
Bae64.txt
ParsedError.docx

Strip out the data header with
const data = e.target.result;
const workbook = XLSX.read(data.slice(data.indexOf(",")+1), { type: "base64" });


Add digital signature to DUA

Consider using https://crates.io/crates/ring

This enhancement has been declined.


adding lib

@PaulBredl  A detailed list of all libraries used can be found in the wiki of our GitHub repository (TODO link).


pass clienttype in login params

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Syntax color problems in Ruby on Rails archives

VSCode Version: 1.17.2
OS Version: Xubuntu 16.04

Problems i´ve found:
1.The problem is in the Ruby archives, on Rail´s views.  The close´s tag to show data  in HTML its feels like a string code . Something like this "%>" without quotes.
2.JavaScript Syntax color in Ruby on Rails archives  doesn´t work properly .

Reproduces without extensions: No

Can you please share some example code for these issues so that we can investigate this?

the first error is something like this(close´s tag share the same strings color):

in the second error the ruby syntax does not work in "javascript.js.erb", something like this:  .

The problem is that the <% syntax is not valid in html.
Did you check the marketplace for erb extensions?

I've tried a lot of extensions nothing work properly.

Please file issues against the extension so they can get better.


if max_size is 0 in some files, thows a warning.

When I install the node it shows the following WARNINGS during startup.
/var/home/david/Documents/AITools/ComfyUI/custom_nodes/ComfyUI_FizzNodes/ScheduleFuncs.py:26: SyntaxWarning: "is" with a literal. Did you mean "=="?
if max_size is 0:
/var/home/david/Documents/AITools/ComfyUI/custom_nodes/ComfyUI_FizzNodes/BatchFuncs.py:178: SyntaxWarning: "is" with a literal. Did you mean "=="?
if max_size is 0:
Since it's just a syntax "warning" I assume it's not making a big difference, but I changed the code in those two files to "if max_size ==0" anyway  just to make the startup cleaner.
Not sure if it's me using an outdated version of Python, or if you did the "is" for a reason. Anyway no biggie. Just thought I'd mention it in case this was something you wanted to fix, or set me straight on its use. ;-)

no worries. I made the change in fd21651


How to proxy other API routes based on Nuxtjs "Auth Route" example

Hi,
I follow this example to creare Auth Route https://nuxtjs.org/examples/auth-routes (Look at the example files).
There are /login (/api/login) and /logout (/api/logout) routes in the example.
How can i proxy all routes except /login and /logout to another server. i mean every other routes (/api/*)
Examples:
/api/test -> http://myapi.tests/api/test
/api/project/1-> http://myapi.tests/api/project/1
In nuxt.config.js i have @nuxtjs/axios set up like this.
...
axios: {
baseURL: '/api',
proxyHeaders: false
},
...
and call like this for example.
this.$axios.get(/project/${id})
Thanks.

You can use axios-module to proxy the api, https://github.com/nuxt-community/axios-module#proxy


add suggestions for turning off name shadowing and default warnings.

I imagine there are a lot of suggestions to come on line, and things could get long and messy.
Happy to help with a refactor if anyone has a sense of how to handle these cases.

Looks good in the diff! I'll back at  keyboard tonight to try it out and
will merge. I agree with your choice of not setting these on as default.
A future additional suggestion could be to use intero's knowledge of
variable uses and offer a rename to e.g. x' or whatnot.
Regarding the blow up of cases let's play it by ear and then refactor once
we're pretty sure most of the cases have been exhausted!
On 23 Jul 2016 08:26, "Tony Day"<EMAIL_ADDRESS>wrote:

I imagine there are a lot of suggestions to come on line, and things could
get long and messy.
Happy to help with a refactor if anyone has a sense of how to handle these
cases.
You can view, comment on, or merge this pull request online at:
https://github.com/commercialhaskell/intero/pull/185
Commit Summary

add suggestions for turning off name shadowing and default warnings.

File Changes

M elisp/intero.el
https://github.com/commercialhaskell/intero/pull/185/files#diff-0
(38)

Patch Links:

https://github.com/commercialhaskell/intero/pull/185.patch
https://github.com/commercialhaskell/intero/pull/185.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/commercialhaskell/intero/pull/185, or mute the thread
https://github.com/notifications/unsubscribe-auth/AAArCyJFNoS7IPMsLd7fMsumfaFaniSjks5qYbQzgaJpZM4JTTDp
.

This looks good to me, too, but I'd really like that ability to rename a shadowing identifier!

Agreed. I'd be a prime user of such a rename.
Sorry I didn't get to merging yesterday, I got stranded in Verona due to
train track accident downstream.
On 23 Jul 2016 19:38, "Anthony Cowley"<EMAIL_ADDRESS>wrote:

This looks good to me, too, but I'd really like that ability to rename
a shadowing identifier!
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/commercialhaskell/intero/pull/185#issuecomment-234730575,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAArC_BxeH-5pDg7dkHC3Y83exadhtGHks5qYlGrgaJpZM4JTTDp
.


Reading component names of fields in a MED file

Hi all, kudos to all contributors for this great library.
When reading a MED file, the names of the components of the fields that exist in point_data and cell_data are not included. One gets a list of values for each entry, let's say a list of three values for a 3D displacement result in a point, but there is no information about the names of these three components (would be DX, DY, DZ for a MED file).
Looking at the code, this information could be added for example here with sth along these lines:
comp_data = {}
n_comp = data.attrs['NCO']
comp_str = data.attrs['NOM']
comp_data[name] = [comp_str[i*16:(i+1)*16].strip() for i in range(n_comp)]

And the question is whether the schema permits to read and include this kind of information. In other words is it something that can be taken care of by just modifying _med.py or at the moment this info is not considered at all in general for all formats?
I would be available to work towards a resolution of this issue if there is a possibility to consider these component names.

It would be great if you could add a (small) MED file where the components aren't read correctly.

Yes, certainly, here is a small example file reinforcement.zip
It contains a field in cell_data called RES_____FERRAILLAGE which has 7 values/components for each cell. My point is that the MED file contains also the labels of these 7 components, but it seems to me that these are not currently read and stored anywhere in the implementation in meshio.
If, for example I add in the main for loop of _read_data
print(data.attrs['NOM'])

I will get a string with the labels 'DNSXI           DNSXS           DNSYI           DNSYS           DNST            DNSVOL          CONSTRUC        '
PS: I see that when writing in med these component names are default created (names V1/V2 etc.) and stored here

They are now in mesh.field_data["med:nom"].

Sounds great! Thanks @nschloe !

Testing these latest changes regarding med format there may be some modifications to be made.
Using the same med file I uploaded before, I tried reading and writing the file with this code
file = meshio.read("reinforcement.med")

meshio.Mesh(
    file.points,
    file.cells_dict,
    # Optionally provide extra data on points, cells, etc.
    point_data=file.point_data,
    cell_data=file.cell_data,
    field_data=file.field_data
).write(
    "reinforcement2.med"
)

and I get the following error
Traceback (most recent call last):
  File "io.py", line 18, in <module>
    meshio.Mesh(
  File "/home/jesusbill/miniconda3/envs/ifc/lib/python3.8/site-packages/meshio/_mesh.py", line 182, in write
    write(path_or_buf, self, file_format, **kwargs)
  File "/home/jesusbill/miniconda3/envs/ifc/lib/python3.8/site-packages/meshio/_helpers.py", line 147, in write
    return writer(filename, mesh, **kwargs)
  File "/home/jesusbill/miniconda3/envs/ifc/lib/python3.8/site-packages/meshio/med/_med.py", line 347, in write
    field_name = field_names[name_idx] if field_names else None
IndexError: list index out of range

Looking at the code would it make sense that this line should be after the _write_data call and outside the for loop? I tried it and it seems to work.
Also, here if no field_name is defined, shouldn't there be, nonetheless, an empty name created to be consistent?
Something like this
if field_name:
    field.attrs.create(
        "NOM", np.string_("".join(f"{name:<16}" for name in field_name))
    )
else:
    field.attrs.create(
        "NOM", np.string_("".join(f"{name:<16}" for name in [""]))
    )

If not, mesh.field_data["med:nom"] gives [[], ['DNSXI', 'DNSXS', 'DNSYI', 'DNSYS', 'DNST', 'DNSVOL', 'CONSTRUC']] for the original file but [['DNSXI', 'DNSXS', 'DNSYI', 'DNSYS', 'DNST', 'DNSVOL', 'CONSTRUC']] for the second file (after the modification suggested above).

How about a pull request?

Yeap, absolutely


nixos/virtualisation/nixos-containers: add systemCallFilter option, remove null checks

Add systemCallFilter to NixOS containers. This is notably required to run docker in nspawn. As far as I know, the only current way to do this is this very ugly hack:
additionalCapabilities = [
  # This is a very ugly hack to add the system-call-filter flag to
  # nspawn. extraFlags is written to an env file as an env var and
  # does not support spaces in arguments, so I take advantage of
  # the additionalCapabilities generation to inject the command
  # line argument.
  ''CAP_NET_ADMIN" --system-call-filter="add_key keyctl bpf" --capability="CAP_NET_ADMIN''
];

This PR allows this to be written as
systemCallFilter = [ "add_key" "keyctl" "bpf" ]

Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[x] (Package updates) Added a release notes entry if the change is major or breaking
[x] (Module updates) Added a release notes entry if the change is significant
[x] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

@h7x4 Please let me know if there is anything else I need to fix.

I think everything is working fine now!

Neat! Maybe you could do some git-fu to squash all the refactoring commits into a single commit, and place it before the add systemCallFilter commit, so you don't need to introduce the null check only to remove it again?

I am not that good with Git, so give me a bit of time to figure out how to do that. This will require a force push to my branch though, right?

Yes, it will require a forcepush as you are now not only appending commits, but rewriting them. Have a look into "interactive rebasing".
Also, just be careful to not rebase 1000 commits (or something) and then forcepush, because everyone will get pinged. This happens regularly, and we have to lock down the PRs and ask people to open new ones because of all the noise it generates. If you mark it as draft first, people won't get pinged until you remark it as ready for release, which gives you a sort of safety net.

I think I figured it out. Is this what you had in mind?

Indeed! Cool beans!

I think everything is finally alright

Neat!
I don't know how familiar you are with nixpkgs, since this is your first contribution, but as you might see from the other PRs, getting changes merged can sometimes be a bit of a patience game.
There are some threads on discourse where you can ask for more reviews (namely the "PRs ready for *" threads), and there's the different matrix dev channels. You can also try requesting reviews from people you think would like to know about this change (although that might require a bit of familiarity with the project and community). Alternatively, the collectively best option would be to help out by making yourself familiar with the contribution guidelines and try reviewing some PRs yourself.

I am not familiar with the process, thanks for enlightening me (and all your help). Patience won't be an issue; as I've said, above, I already have a temporary fix. I'll try to lookup these guidelines


Update UG and PPP

Update UG and PPP
Fix some prompt message in txn-related commands (change reference from 'sales book' to 'transaction list')

Need to update your documentation to pass checkstyle

LGTM


Document new methods on Wiki

We are currently missing documentation of the newly added methods related to push campaigns. We need to edit our wiki to include the new documentation, here:
https://github.com/lime-company/powerauth-push-server/wiki
We need to cover following topics:

Database changes, new tables, ...
RESTful API documentation, new endpoints, ...
Integration manual - examples on how to call our methods in Java (client side)

Documentation is already fixed.


Events on front page not linked to the Events page

Description
There are events listed in the "Upcoming Events" banner on the homepage. They do not link to the Events calendar. The events do not show up on the calendar when you go to January (the month the events are listed -- though perhaps that is because the events are dated for a year other than 2016).
Screenshots
Files
To Reproduce
Try to click on an event from the homepage.
Tasks
Include specific tasks in the order they need to be done in. Include links to specific lines of code where the task should happen at.

[ ] Task 1
[ ] Task 2
[ ] Task 3

Remember to use helpful labels and milestones. If you use the "help wanted" label, Code for America will promote it widely.

should be fixed with  #213

closed because fixed ^^


[MINOR] Fix typo,rename 'HooodieAvroDeserializer' to 'HoodieAvroDeserializer'

Tips

Thank you very much for contributing to Apache Hudi.
Please review https://hudi.apache.org/contribute/how-to-contribute before opening a pull request.

What is the purpose of the pull request
Fix typo,rename 'HooodieAvroDeserializer' to 'HoodieAvroDeserializer'
Brief change log
(for example:)

Fix typo,rename 'HooodieAvroDeserializer' to 'HoodieAvroDeserializer'

Verify this pull request
(Please pick either of the following options)
This pull request is a trivial rework / code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)

Added integration tests for end-to-end.
Added HoodieClientWriteTest to verify the change.
Manually verified the change by running a job locally.

Committer checklist

[ ] Has a corresponding JIRA in PR title & commit

[ ] Commit message is descriptive of the change

[ ] CI is green

[ ] Necessary doc changes done or have another open PR

[ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

@hudi-bot run azure


Property does not exist on type 'never' reported when it shouldn't

TypeScript Version:  3.0.3

Search Terms:
property does not exist on type 'never'
The code fragment below without any changes produces the following error when
using TypeScript 3.0.3/TSLint 5.11.0:
(44,47): Property 'b' does not exist on type 'never'.
Replacing the "if isNotDefined(options)" line in ClassB.modify() with either of the lines above it that are commented out stops this error from appearing.
Code fragment:
export function myIsDefined<T>(value: T | undefined | null): value is T {
  return <T>value !== undefined && <T>value !== null;
}

export function myIsNotDefined<T>(value: T | undefined | null): value is T {
	return <T>value === undefined || <T>value === null;
}

export interface ClassAModifyResult {
	a: boolean
}

export interface ClassBModifyResult extends ClassAModifyResult {
	b: boolean
}

export class ClassA {
	constructor(options?: any) {
		this.modify(options);
	}

	public modify(options?: any): ClassAModifyResult {
		var result = {} as ClassAModifyResult;
		if ( myIsNotDefined(options) )
			return result;

		result.a = true;
		return result;
	}
}

export class ClassB extends ClassA {
	constructor(options?: any) {
		super(options);
	}

	public modify(options?: any): ClassBModifyResult {
		// if ( !myIsDefined(options) )
		// if ( options === undefined || options === null )
		if ( myIsNotDefined(options) )
			return {} as ClassBModifyResult;

		var result = super.modify(options) as ClassBModifyResult;
		result.b = this._modifyBIfNecessary(options.b);
		return result;
	}

	protected _modifyBIfNecessary(value?: boolean): boolean {
		return true;
	}
}

I have seen other cases where using a method like myIsNotDefined() causes other issues for either TypeScript or TSLint.
Example:
	someMethod(value?: any | null): void {
		if ( myIsNotDefined(value) )
			return;

		if ( value.member === 'abc' )
			doSomething();
	}

With the code fragment above an error may appear stating that 'value' maybe undefined or null at the line that reads "if ( value.member === 'abc' )". Replacing the call to 'myIsNotDefined(value)' with either '!myIsDefined(value)' or 'value === undefined || value === null' stops the error from appearing.

I think the problem is your definition of myIsNotDefined, specifically the return type (options is T) in combination with any.
if ( myIsNotDefined(options) ) {
    // Here, options is any
    return {} as ClassBModifyResult;
}
// Here, options is whatever remains after excluding any from the type, which results in never

When you define the function argument differently, the error changes.

Something to note... we cannot use methods like isDefined()/isNotDefined() anyway. Code like the following reports "Object is possibly null" on the line that starts with 'var match =', even though we've effectively ensured that computedStyle and computedStyle.color are both defined. I don't know if this is a compiler issue or just an artifact of TypeScript.
	var computedStyle = window.getComputedStyle(someElement);
	if ( isDefined(computedStyle) && isDefined(computedStyle.color) )
	{
		var match = computedStyle.color.match(/\d+/g);
		if ( isDefined(match) )
		{
		    . . .
		}
	}

This works on the playground with strictNullChecks:
function isDefined<T>(a: T | null | undefined): a is T {
	return a !== null && a !== undefined;
}

function foo() {
	var a = window.getComputedStyle(null as any);

	if (isDefined(a) && isDefined(a.color)) {

		var match = a.color.match(/\d+/g);

		match[0]; // Error: Object is possibly null
		if (isDefined(match)) {
			match[0]; // works
		}
	}
}

... correct ... the isDefined() approach works, its just the isNotDefined() which is not working... sorry.

I misunderstood the use of type guards. Closing this ticket.

isNotDefined also works if you don't combine it with ||:
function isNotDefined<T>(a: T | null | undefined): a is (null | undefined) {
	return a !== null && a !== undefined;
}

function foo() {
    var a = window.getComputedStyle(null as any);

    // works:
    if (isNotDefined(a)) {
        a; // null
    } else if (isNotDefined(a.color)) {
        a.color; // null
    }

    // doesn't work!
    if (isNotDefined(a) || isNotDefined(a.color)) {
        a; // CSSStyleDeclaration
        a.color; // string
    }
}

I'm not sure if that is a design limitation or a bug, since it is the exact opposite check of isDefined(a) && isDefined(a.color).

That is odd. Thanks for the additional notes. I'm just using isDefined() and !isDefined().

@RyanCavanaugh while the original post seems to be a question, what about the behavior in https://github.com/Microsoft/TypeScript/issues/27041#issuecomment-420769327? Is that a bug or limitation somehow?


[WFLY-12549] Includes config-sources from microprofile-config-smallrye subsystem

Override the ConfigProviderResolver so that the ConfigBuilder will
include by default ConfigSource defined in the
microprofile-config-smallrye subsystem.
This allows other subsystems (such as microprofile-metrics-smallrye) to
use the Config API and get the config properties from the
microprofile-config-smallrye subsystems (which was alreayd the case for
deployments).
Add a test that check that mp.metrics.tags defined in the config
subsystem are properly read by the metrics subsystem (and appended to
the metrics output).
JIRA: https://issues.redhat.com/browse/WFLY-12549
Signed-off-by: Jeff Mesnil<EMAIL_ADDRESS>

@jmesnil I removed the 'ready-for-merge' label for this because when I tested it as part of combo-PR #13276 it failed in one test:
https://ci.wildfly.org/viewLog.html?buildId=203204&tab=buildResultsDiv&buildTypeId=WF_PullRequest_WindowsJdk11

retest this please

@jmesnil The Windows JDK 11 failure is in the new test added here.

I've fixed the failure


MAINT: correct log file name generating function

[CHANGED] revert effect of previous refactor which was causing
truncation to single characters

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.05%) to 91.44%

Totals

Change from base Build<PHONE_NUMBER>:
0.05%

Covered Lines:
178047

Relevant Lines:
194714

💛  - Coveralls


Tweak OpenSSL docs

Several small tweaks to OpenSSL docs:

Slice(UInt8) -> Bytes
plain links turned into hyperlinks
some formatting tweaks

While editing I noticed that OpenSSL::SSL::Socket gets linked to Socket instead which looks like a bug to me.

Merged, thanks!!


Adding a vagrant user where needed in case we want to run this on AWS

With chef-acceptance we want to run this recipe on an AWS node, but the vagrant user doesn't exist there.  What do you think of this change @smurawski @mwrock ?  Or we could do a custom user like the http_acl recipe uses

This recipe is really intended to be a spec for the windows_task resource. I think this is probably the wrong place for that. Maybe we could add a recipe to the beginning of a  chef-acceptance run that includes this.

That spec needs to change since it assumes vagrant.. maybe make the user for the task an attribute of the minimal cookbook?  It can default to vagrant, but then be overridable easily in a .kitchen.yml.  I've actually been meaning to make that change myself.

Closing this because we decided to add the user 'vagrant' into an acceptance specific recipe


Request : update GROUP accept array

Hello,
Dealing with this, may avoid direct query usage :
$db->select('customer', '*', array('GROUP' => array('foreign1_id', 'foreign2_id' ,'foreign3_id')));
If you could add this support, it would sounds good to me.
Thank you :)
Regards,
Vincent

Seems useful.
$db->select('customer', '*', array('GROUP' => array('foreign1_id', 'foreign2_id' ,'foreign3_id')));

Creates query
SELECT * FROM "customer" GROUP BY "foreign1_id", "foreign2_id", "foreign3_id"

Supported on Medoo 1.4.


[QUESTION] Why not use Rust coreutils?

Sorry, if this comes across as a "talk is cheap" or this has been discussed before (didn't see it in the closed issue list).
But why re-create all the built-in commands, when they already exist as cross-platform Rust programs in https://docs.rs/crate/coreutils/0.0.13?
Would you be able to support every requests that has been here with cargo build --features "cp mv rm mkdir pwd sleep echo cat" --no-default-features (minus xargs and exit) and parse the deno task commands with Module oursh::program::posix?
Sorry, if you are having fun implemented these commands yet again, then you should absolutely continue the fun!
I am just curious to know if you are aware of existing Rust programs that does a similar thing and why you choose not to use them?

Essentially, it's easier to get alignment with exactly what we want when we have full control over the functionality and it wasn't too bad to implement. In the case of oursh it has conditionals which we wouldn't add to deno task and it's missing a few things we would want (ex. pipes, subshells, quotes). It also creates some risk because you have to rely on decisions someone else makes about the future state of a project (ex. how would they implement globbing in the future and would that align with the glob functionality we want for deno task?). For deno task's current implementation, we can easily swap out any of the dependencies and still provide the same functionality to users.
For coreutils, I don't see a way to use each command that would take into account the state of the shell rather than the process. For example, pwd uses the global env::current_dir() (https://github.com/uutils/coreutils/blob/main/src/uu/pwd/src/pwd.rs), but our pwd command uses a non-global current working directory based on the current shell's state (ex. someone could start an asynchronous subshell that does a cd putting it into a different cwd than the process).

I guess non of the packages I found a really made to be used by other projects. Thank you for explaining the situation @dsherret :)


Add Missing AQI Sensors from my WS-5000 Station and a way to set the published Name for the MQTT Name

First off thank you for this docker/Addon I have been using it forever.
I found that my WS-5000 AQI sensors did not get published, found that the query uri is just slightly off from the ones you already had added. This just adds additional ones.
I also added an environment variable to set the name used for MQTT Device Discovery so that I can have the name show up as my Weather Station instead of "ambientWeather2mqtt" in the MQTT device list (this is just an OCD thing for 😃)
Example:

As a note, my Main branch has the full changes to also update the Hassio Addon but I did not include those changes here as I had to repoint to my images/repo for testing. figured I would let you do those on your branch if you end up accepting this PR.

Super cool!!! Thanks for this.
Can you please split it into two pull requests:

The new sensors
The new environment variable

For the environment variable it'd be great if you could also include the hassio changes. They should be easy enough to figure out by looking at the existing ones.

Sure thing, I have updated this branch to only include the new AQI Sensors. I will submit another PR for the other changes.

#158