3.1.274 install fails on Windows 10

Installing the latest SDK from web platform installer fails with the following error:
\Program Files\Microsoft SDKs\Service Fabric\ClusterSetup> .\DevClusterSetup.ps1 -CreateOneNodeCluster
WARNING: A local Service Fabric Cluster already exists on this machine and will be removed.
Do you want to continue [Y/N]?: y
Removing cluster configuration...
Cleaning existing certificates...
Certificates removed.
Stopping all logman sessions...
Cleaning log and data folder...

Using Cluster Data Root: C:\SfDevCluster\Data
Using Cluster Log Root: C:\SfDevCluster\Log

The generated json path is C:\Users\ivang\AppData\Local\Temp\tmp7345.tmp.json
Processing and validating cluster config.
Create node configuration succeeded
Starting service FabricHostSvc. This may take a few minutes...

Waiting for Service Fabric Cluster to be ready. This may take a few minutes...
Local Cluster ready status: 4% completed.
Local Cluster ready status: 8% completed.
Local Cluster ready status: 12% completed.
Local Cluster ready status: 17% completed.
Local Cluster ready status: 21% completed.
Local Cluster ready status: 25% completed.
Local Cluster ready status: 29% completed.
Local Cluster ready status: 33% completed.
Local Cluster ready status: 38% completed.
Local Cluster ready status: 42% completed.
Local Cluster ready status: 46% completed.
Local Cluster ready status: 50% completed.
Local Cluster ready status: 54% completed.
Local Cluster ready status: 58% completed.
Local Cluster ready status: 62% completed.
Local Cluster ready status: 67% completed.
Local Cluster ready status: 71% completed.
Local Cluster ready status: 75% completed.
Local Cluster ready status: 79% completed.
Local Cluster ready status: 83% completed.
Local Cluster ready status: 88% completed.
Local Cluster ready status: 92% completed.
Local Cluster ready status: 96% completed.
Local Cluster ready status: 100% completed.
WARNING: Service Fabric Cluster is taking longer than expected to connect.

Waiting for Naming Service to be ready. This may take a few minutes...
No cluster endpoint is reachable, please check if there is connectivity/firewall/DNS issue.
Connect-ServiceFabricCluster : No cluster endpoint is reachable, please check if there is connectivity/firewall/DNS issue.
At C:\Program Files\Microsoft SDKs\Service Fabric\Tools\Scripts\ClusterSetupUtilities.psm1:620 char:12
+ [void](Connect-ServiceFabricCluster @connParams)
+ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+ CategoryInfo : InvalidOperation: (:) [Connect-ServiceFabricCluster], FabricException
+ FullyQualifiedErrorId : TestClusterConnectionErrorId,Microsoft.ServiceFabric.Powershell.ConnectCluster

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 23e79576-36ff-8e39-9d21-adc897608b73
Version Independent ID: bb904115-2166-6871-6347-0941dbb32d2a
Content: Set up a Windows development environment for Azure microservices
Content Source: articles/service-fabric/service-fabric-get-started.md
Service: service-fabric
Product: unspecified
GitHub Login: @rwike77
Microsoft Alias: ryanwi

Looks like the version you are trying to install is not actually the latest. I checked mine and found the following:

Are you only prompted for 3.1.274?

Apologies, I just saw the latter version. However, installing it gives the identical problem. I've tracked the issue on GitHub and found a workaround here https://github.com/Azure/service-fabric-issues/issues/1056. Seems to be a bug.

Thanks for confirming @aloneguid! I was able to get it to install without issue but as you mentioned seems to be a known issue. I will close this out for now as it is already tracked on the correct GitHub repo and there is nothing to update on this specific doc but rather the SDK itself. I am following that issue as well.

As of August 24th,
The SDK installed version 3.2.176 (Release date: Monday, August 20, 2018) errors out with following output in visual studio 2017.  (Error message: "The PowerShell script failed to execute. See the Output window for details.)
1>------ Build started: Project: MyApplication, Configuration: Debug x64 ------
2>------ Deploy started: Project: MyApplication, Configuration: Debug x64 ------
2>Started executing script 'GetApplicationExistence'.
2>Finished executing script 'GetApplicationExistence'.
2>Time elapsed: 00:00:02.1304224
2>Started executing script 'Set-LocalClusterReady'.
2>powershell -NonInteractive -NoProfile -WindowStyle Hidden -ExecutionPolicy Bypass -Command "Import-Module 'C:\Program Files\Microsoft SDKs\Service Fabric\Tools\Scripts\DefaultLocalClusterSetup.psm1'; Set-LocalClusterReady -createOneNodeCluster $true"
2>--------------------------------------------
2>Local Service Fabric Cluster is not setup...
2>Please wait while we setup the Local Service Fabric Cluster. This may take few minutes...
2>Stop-Service : Cannot find any service with service name 'FabricHostSvc'.
2>At C:\Program Files\Microsoft SDKs\Service Fabric\Tools\Scripts\ClusterSetupUtilities.psm1:144 char:5
2>+     Stop-Service FabricHostSvc -WarningAction SilentlyContinue
2>+     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
2>    + CategoryInfo          : ObjectNotFound: (FabricHostSvc:String) [Stop-Service], ServiceCommandException
2>    + FullyQualifiedErrorId : NoServiceFoundForGivenName,Microsoft.PowerShell.Commands.StopServiceCommand
2>
2>WARNING: System.Management.Automation.CommandNotFoundException: The term 'Remove-ServiceFabricNodeConfiguration' is not
2> recognized as the name of a cmdlet, function, script file, or operable program. Check the spelling of the name, or if
2>a path was included, verify that the path is correct and try again.
2>
2>   at System.Management.Automation.ExceptionHandlingOps.CheckActionPreference(FunctionContext funcContext, Exception
2>exception)
2>
2>   at System.Management.Automation.Interpreter.ActionCallInstruction`2.Run(InterpretedFrame frame)
2>
2>   at System.Management.Automation.Interpreter.EnterTryCatchFinallyInstruction.Run(InterpretedFrame frame)
2>
2>   at System.Management.Automation.Interpreter.EnterTryCatchFinallyInstruction.Run(InterpretedFrame frame)
2>WARNING: Remove-ServiceFabricNodeConfiguration throws exceptions
2>
2>Using Cluster Data Root: C:\SfDevCluster\Data
2>Using Cluster Log Root: C:\SfDevCluster\Log
2>
2>The generated json path is C:\Users[username]\AppData\Local\Temp\tmp5D74.tmp.json
2>Processing and validating cluster config.
2>Failed to open base key for machine ComputerFullName to check if machine is IOT Core.
2>Test-ServiceFabricClusterManifest : The term 'Test-ServiceFabricClusterManifest' is not recognized as the name of a
2>cmdlet, function, script file, or operable program. Check the spelling of the name, or if a path was included, verify
2>that the path is correct and try again.
2>At C:\Program Files\Microsoft SDKs\Service Fabric\Tools\Scripts\ClusterSetupUtilities.psm1:504 char:5
2>+     Test-ServiceFabricClusterManifest -ClusterManifestPath "$manifest ...
2>+     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
2>    + CategoryInfo          : ObjectNotFound: (Test-ServiceFabricClusterManifest:String) [], CommandNotFoundException
2>    + FullyQualifiedErrorId : CommandNotFoundException
2>
2>PrepareClusterManifest : Could not validate cluster manifest
2>'C:\Users[username]\AppData\Local\Temp\LAP000338-Server-ScaleMin.xml'
2>At C:\Program Files\Microsoft SDKs\Service Fabric\Tools\Scripts\ClusterSetupUtilities.psm1:530 char:21
2>+ ... ifestFile = PrepareClusterManifest $manifestFileTemplate $imageStoreC ...
2>+                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
2>    + CategoryInfo          : NotSpecified: (:) [Write-Error], WriteErrorException
2>    + FullyQualifiedErrorId : Microsoft.PowerShell.Commands.WriteErrorException,PrepareClusterManifest
2>
2>ScriptHalted
2>At C:\Program Files\Microsoft SDKs\Service Fabric\Tools\Scripts\ClusterSetupUtilities.psm1:508 char:9
2>+         throw
2>+         ~~~~~
2>    + CategoryInfo          : OperationStopped: (:) [], RuntimeException
2>    + FullyQualifiedErrorId : ScriptHalted
2>
2>Finished executing script 'Set-LocalClusterReady'.
2>Time elapsed: 00:00:10.9335415
2>The PowerShell script failed to execute.
========== Build: 1 succeeded, 0 failed, 1 up-to-date, 0 skipped ==========
========== Deploy: 0 succeeded, 1 failed, 0 skipped ==========

@junsp Got any solution for above issue?

I am also getting the same error.
[Monday 3:25 PM] Hema Gunnam
1>------ Build started: Project: s2s.supplier.segmentation.selfhosted, Configuration: Debug x64 ------
2>------ Deploy started: Project: s2s.supplier.segmentation.selfhosted, Configuration: Debug x64 ------
2>Started executing script 'GetApplicationExistence'.
2>Finished executing script 'GetApplicationExistence'.
2>Time elapsed: 00:00:00.8065849
2>Started executing script 'Set-LocalClusterReady'.
2>powershell -NonInteractive -NoProfile -WindowStyle Hidden -ExecutionPolicy Bypass -Command "Import-Module 'C:\Program Files\Microsoft SDKs\Service Fabric\Tools\Scripts\DefaultLocalClusterSetup.psm1'; Set-LocalClusterReady -createOneNodeCluster $true"
2>--------------------------------------------
2>Local Service Fabric Cluster is not setup...
2>Please wait while we setup the Local Service Fabric Cluster. This may take few minutes...
2>Performing Stop-Service on: FabricHostSvc . This may take a few minutes...
2>WARNING: System.Management.Automation.CommandNotFoundException: The term 'Remove-ServiceFabricNodeConfiguration' is not
2> recognized as the name of a cmdlet, function, script file, or operable program. Check the spelling of the name, or if
2>a path was included, verify that the path is correct and try again.
2>
2>   at System.Management.Automation.ExceptionHandlingOps.CheckActionPreference(FunctionContext funcContext, Exception
2>exception)
2>
2>   at System.Management.Automation.Interpreter.ActionCallInstruction`2.Run(InterpretedFrame frame)
2>
2>   at System.Management.Automation.Interpreter.EnterTryCatchFinallyInstruction.Run(InterpretedFrame frame)
2>
2>   at System.Management.Automation.Interpreter.EnterTryCatchFinallyInstruction.Run(InterpretedFrame frame)
2>WARNING: Remove-ServiceFabricNodeConfiguration throws exceptions
2>
2>Using Cluster Data Root: C:\SfDevCluster\Data
2>Using Cluster Log Root: C:\SfDevCluster\Log
2>
2>The generated json path is C:\Users\hema.gunnam\AppData\Local\Temp\tmp5F32.tmp.json
2>Processing and validating cluster config.
2>Test-ServiceFabricClusterManifest : The term 'Test-ServiceFabricClusterManifest' is not recognized as the name of a
2>cmdlet, function, script file, or operable program. Check the spelling of the name, or if a path was included, verify
2>that the path is correct and try again.
2>At C:\Program Files\Microsoft SDKs\Service Fabric\Tools\Scripts\ClusterSetupUtilities.psm1:804 char:5
2>+     Test-ServiceFabricClusterManifest -ClusterManifestPath "$manifest ...
2>+     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
2>    + CategoryInfo          : ObjectNotFound: (Test-ServiceFabricClusterManifest:String) [], CommandNotFoundException
2>    + FullyQualifiedErrorId : CommandNotFoundException
2>
2>PrepareClusterManifest : Could not validate cluster manifest
2>'C:\Users\hema.gunnam\AppData\Local\Temp\HYD01L5378-Server-ScaleMin.xml'
2>At C:\Program Files\Microsoft SDKs\Service Fabric\Tools\Scripts\ClusterSetupUtilities.psm1:840 char:21
2>+ ... ifestFile = PrepareClusterManifest $manifestFileTemplate $imageStoreC ...
2>+                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
2>    + CategoryInfo          : NotSpecified: (:) [Write-Error], WriteErrorException
2>    + FullyQualifiedErrorId : Microsoft.PowerShell.Commands.WriteErrorException,PrepareClusterManifest
2>
2>ScriptHalted
2>At C:\Program Files\Microsoft SDKs\Service Fabric\Tools\Scripts\ClusterSetupUtilities.psm1:808 char:9
2>+         throw
2>+         ~~~~~
2>    + CategoryInfo          : OperationStopped: (:) [], RuntimeException
2>    + FullyQualifiedErrorId : ScriptHalted
2>
2>Finished executing script 'Set-LocalClusterReady'.
2>Time elapsed: 00:00:13.5710696
2>Deploy failed with error ScriptException: The PowerShell script failed to execute.
========== Build: 1 succeeded, 0 failed, 4 up-to-date, 0 skipped ==========
========== Deploy: 0 succeeded, 1 failed, 0 skipped ==========


[FEAT] Addition of an OR operator for types

Describe your feature
The addition of an OR operator for types will create better data definitions with less overhead, compared to tagged enum alternatives. The operator can function similar to Luau i.e. type bool_or_u8 = boolean | u8
Alternatives
Using tagged enums will in essence function as an OR, however there is more overhead.
i.e.
enum "Type" {
    Number {
        Value: f64,
    },

    String {
        Value: string,
    },
}

WILL CREATE -->
({
	Type: "Number",
	Value: (number),
} | {
	Type: "String",
	Value: (string),
})

meaning that there is now an overhead of both a string and the value's type.

Implimentation Details:

OR would have | syntax like type Test = f64 | string
OR would only work for primatives
OR will error if two types of numbers are added to the list
OR can be optional like type Test = (f64 | string)?.


Bug Fix

Following bugs are being fixed:

Leaving one line after mount.
Owner/Group of the files not being root after install
Avoid race condition causing entry with PID getting deleted and unmounting the share.
Mount taking ~3 secs extra because of ping.

Following bugs are being fixed:

Leaving one line after mount.
Owner/Group of the files not being root after install
Avoid race condition causing entry with PID getting deleted and unmounting the share.
Mount taking ~3 secs extra because of ping.

3 and 4 are not fixed in this, right?


Source folder wiped completely when roots script runs into error

Hi,
First of all, thanks for the amazing package. I have gotten it to work on a sample project and I was going to implement it on a new more serious project today. I tried to setup next-roots with the dest directory as /app, so I can use RSC. Also, I use npm in this project (if it matters).
My folder structure is/was like so:
...
src
> app
>> _routes
>>> api
>>> [uid]
>>> page.tsx
>>> ...
> components
> lib
...

I moved all my previous app content into the app/_routes folder and then I ran the roots script. Upon which point I get this error:
Error: ENOENT: no such file or directory, copyfile 'C:\Projects\site\src\app\_routes\api\revalidate\route.js' -> 'C:\Projects\site\src\app\en\api\revalidate\route.js'. In hindsight, I probably should have kept /api in the app folder, not _routes folder.
Anyway, after the script failed, everything in app/_routes is gone, in other words, all of my original files and folders. If I didn't have a git history I guess there would be no way to get the files back.
I figured I'd raise an issue about it. Some people set up projects and add git later on, in their case, this sort of result from a failed script would be really unfortunate. Maybe a warning is in order in the Getting started guide, to let people know they should back up their files first or make a commit or something.
Anyway, in my case, I have frequent commits so it was no problem. Just a thought.
Thanks again for the great package! Wish vercel would implement something like this into next.

Hi @kimskogsmo,
thank you for pointing this out. Relevant info was added to README.md.
In your case I would recommend to use RSC config approach so that your original routes are kept in app/_roots and translated in app/(routes). Doing that only app/_roots should be wiped out during generation (even failed one).

Hi @kimskogsmo could you please post your results here? Was my suggestion helpful? So that other can benefit from that. Thank you.

@svobik7 sorry, thought I did. That approach worked great for me! Thanks!


attempting to debug launch project fails

debug launch is failing through IntelliJ IDEA.
initially, get an IDE error "Error running Application.  Command line is too long.  Shorten the command line and rerun."
if I use the provided mechanism to shorten the command line, the system begins to run, but then dies with the error "Web application could not be started as there was no org.springframework.boot.web.servlet.server.ServletWebServerFactory bean defined in the context."
it's not clear why this is happening, so I need to figure this out before I can try to figure anything else out.
I also posted this question to the HAPI-FHIR Google Group, which can be found here: https://groups.google.com/g/hapi-fhir/c/oEjnMDO0xhs

this is resolved.  solved by enabling the "boot" Maven profile in IDE


[WIP] Added version check for config.yaml

Signed-off-by: metonymic-smokey<EMAIL_ADDRESS>Description
Checks the validity of the current context's version, using a regex.
This PR fixes #2294
Notes for Reviewers
Signed commits

[x] Yes, I signed my commits.

@aneeshnema  thanks!
I've made the necessary changes, let me know if this is okay.

Very nice teamwork, @metonymic-smokey and @aneeshnema. 😎


clean up memcpy in swig typemaps

#3700 #3724

@vigsterkr The VS15 cmake can't detect compilers?

@lambday just ignore the error... it's already fixed.

Okay. Merging this then.

Thanks @MikeLing

@lambday ah and just for the record... there's no swig interface compilation being done on windows :)

@vigsterkr your baby ruling all over Shogun now :D

errr... you mean only on the CI or it simply cannot build anything other than libshogun?

CI obviously :) but yeah i never ever tried building swig interfaces with MSVC.... and i would be a bit surprise if somebody ever did it... although would be cool :)


Placeholder isn't actually a placeholder and no way to turn it off

The placeholder uses the values from datetimePlaceholder, but actually puts them as text in the input, rather than in the placeholder= attribute, and so they are constantly there as a mask.  There's also no option to disable this behavior, so anytime the textbox gets cleared, it actually ends up with the tokens there again.
Ideally the placeholder should fill the placeholder attribute, and have an option to turn off the placeholder tokenizing (or at least a attribute to say that the text returned by getText() 'isPlaceholder')

datetimePlaceholder is not meant to replace placeholder attribute on <input> element. See https://github.com/eight04/angular-datetime/issues/39.

they are constantly there as a mask. There's also no option to disable this behavior

Why would you want to turn off the mask?

a attribute to say that the text returned by getText() 'isPlaceholder'

DatetimeParser.isEmpty()

The DateTimeParse.isEmpty() didn't seem to be firing when the field was empty, because the mask would fill the field.
The biggest reason for wanting to turn off the mask is Mobile. Text Masks on mobile can be frustrating.
The second is I open a calendar on ng-focus, so having the text there already which tries to match the token cause it to open, but then also to highlight the current token in the string, which I feel like messes with the UX.
Other than this mask/placeholder stuff, the plugin works great, I just can't use it as it is.
Thank you!

The DateTimeParse.isEmpty() didn't seem to be firing when the field was empty, because the mask would fill the field.

.isEmpty is a method on a parser object. You can use it like:
var parser = datetime("yyyy-MM-dd");
try {
	parser.parse("2017-06-(date)");
} catch (err) {
	console.log(err); // error: some nodes are empty
}
console.log(parser.getText(), parser.isInit(), parser.isEmpty());
// "2017-06-(date)" false false

The biggest reason for wanting to turn off the mask is Mobile. Text Masks on mobile can be frustrating.

This is a problem. This directive was originally made for IE8, and I actually got some feedback that there are some other problems on mobiles (mostly with keyboard events).

highlight the current token in the string

If you just don't want the user to select the text, you can try to .blur() the input in ng-focus handler.


too many statements in try-except clause for loading existing .dat file

There are 40 lines of code in the following try-except clause:
try: # Load Pickle parameter dict to save processing time
That means any error within these many commands will give no error message and the same result: The .dat file is not read and all parameter files are re-read.
Consider a introducing a leaner exception handling here, or add more error messages at least!
Not sure whether it's good style to have nexted try-except clauses...

By replacing try-except with
if ParFileName in os.listdir(RECC_Paths.data_path):
..
else:
..
it should give an error message pointing at the line in which it's happening, rather then the general try-except error message.


False positive prefer-stateless-function

Hi!
I'm facing false positive for rule prefer-stateless-function with latest dependencies.

// .eslintrc.json
{
  "extends": "airbnb",
  "parser": "babel-eslint",
  "settings": {
    "import/resolver": {
      "webpack": { "config": "./webpack/webpack.prod.config.js" }
    }
  },
  "env": {
    "jasmine": true
  },
  "rules": {
    "quotes": ["error", "double"],
    "no-unused-vars": [2, { "vars": "local", "args": "after-used", "argsIgnorePattern": "^_" }]
  }
}

// package.json
"babel-eslint": "^6.0.4",
"eslint": "^2.9.0",
"eslint-config-airbnb": "^8.0.0",
"eslint-import-resolver-webpack": "^0.2.4",
"eslint-plugin-import": "^1.6.1",
"eslint-plugin-jsx-a11y": "^1.0.4",
"eslint-plugin-react": "^5.0.1",

I have the same issue
"eslint": "^2.8.0",
"eslint-config-airbnb": "^8.0.0",
"eslint-plugin-import": "^1.6.1",
"eslint-plugin-jsx-a11y": "^1.0.3",
"eslint-plugin-react": "^5.0.1",

eslint.rc:
{
  "eslintignore": [
    "build",
    "node_modules"
  ],
  "parser": "babel-eslint",
  "extends": "airbnb",
  "globals": {
    "__DEV__": true
  },
  "env": {
    "browser": true
  },
  "rules": {
    "indent": [
      "warn",
      2
    ],
    "comma-dangle": [
      "error",
      "never"
    ],
    "arrow-body-style": [
      "error",
      "always"
    ],
    "no-confusing-arrow": 0,
    "react/jsx-quotes": 0,
    "jsx-quotes": [
      2,
      "prefer-single"
    ]
  }
}

The file in question:
export default class App extends Component {
  render() {
    return (
      <Router routes={routes} history={browserHistory} />
    );
  }
}

These are not false positives.

Ah true, I see. Should have looked more closely at the explanation ashamed

@MichalZalecki i'm going to close this, but will be happy to reopen if further clarification is needed

@ljharb According to this doc, yes https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/prefer-stateless-function.md
Look at "The following patterns are not considered warnings:". 2. example is failing on that rule.

Hmm, you're right. I think the documentation is wrong then.

@MichalZalecki ah, i think i get the difference - in React 15, SFCs can return null. So, that example should only not be a warning in React 0.13 or 0.14.


Reconfigure linter and add Prettier

Replaced XO with eslint
Added Prettier to deal with formatting

I think that in #78 your IDE ran Prettier automatically and our autofix was not able to fix its damage.  Generally, make sure that this doesn't happen unless a repo is configured to use Prettier.

Replaced XO with eslint

@fregante, could you please explain why you had to do that? Isn't XO suitable for this project?
I had in mind that XO (an ESLint wrapper with all its extra goodies and useful defaults) is always better on all sides
compared to using plain ESlint.


Accept shorthand CLI commands - like winget i in place of winget install

Description of the new feature / enhancement
It could be useful to accept the shortcut winget i in place of winget install for the sake of speed. Other often-used commands could also benefit from having a single-char shorthand alias.
Proposed technical implementation details
Potential list of single-char aliases below. Some commands have no alias suggested as their initial is the same as another command which might be more used. Open to hearing the community thoughts!
install: i
upgrade: u

uninstall:
download: d

help: h
list: l
search: s
import:
show:

Duplicate of #4775

Thanks, don't know how I missed it, I searched the existing issues multiple times.


Bluetooth: CAP: Commander discovery support

Implement the CAP Commander discovery function.
Adds support for it in the shell.
This includes initial babblesim and unit testing as well.

@Thalley this also needs a rebase :-)

@Thalley please rebase

@Thalley please rebase


feat: support pool-coordinator component work in specified namespace

What type of PR is this?

/kind feature

What this PR does / why we need it:
Which issue(s) this PR fixes:

Fixes #1342
Special notes for your reviewer:
/assign @rambohe-ch
Does this PR introduce a user-facing change?

add a parameter for yurt-manager to specify namespace variable for PoolcoordinatorNS
modified helm: use value to specify namespace in pool-coordinator.yaml and add startup parameter in yurt-manager.yaml

@rambohe-ch The completion of the poolcoordinator should also require synchronization changes in the yurthub like here, which may have to be done in the #1341

/lgtm

@rambohe-ch The completion of the poolcoordinator should also require synchronization changes in the yurthub like here, which may have to be done in the #1341

@rambohe-ch The completion of the poolcoordinator should also require synchronization changes in the yurthub like here, which may have to be done in the #1341

@y-ykcir yes, i think @huweihuang will handle it.


Outdated and vulnerable golang x/net version

Hello!
We are using ansible-operator-plugins for some internal developments and after performing SAST on the project we noticed that that the used x/net version is vulnerable to several attacks:
✗ High severity vulnerability found in golang.org/x/net/http2
Description: Allocation of Resources Without Limits or Throttling
Info: LINK
Introduced through<EMAIL_ADDRESS>From<EMAIL_ADDRESS>Fixed in: 0.23.0
CVE: LINK
Would it be possible that the x/net version is updated to the most recent version? Thank you!

@jperezdealgaba @acornett21 I think we are now using golang.org/x/net v0.24.0 . Are we good to close this issue?
https://github.com/operator-framework/ansible-operator-plugins/blob/42b5d80c75f1ddda8f2dbe1629b9454d366a8d6a/go.mod#L88

/lgtm

Relates: #67


Autolayout constraints being ignored?

For some reason, when I use this framework, once I go to the tab that has the collection view, it loads already scrolled down to what appears to be close to the centre point of the collection view scrollable area.  If i just use the default Flow layout, it loads at the top of the scrollable area as expected. I believe this is due to this customized layout ignoring the constraints i've already applied.  Is this the case?

Well of course they were...because I put my KTCenterFlowLayout code in viewDidLayoutSubviews() function instead of viewDidLoad() :-1:
move along...nothing to see here. :)


Download Errors and others

Good afternoon, first of all congratulations on your great bot, I also hope you are well.

I have errors in download commands.  (downaudio, downvideo, play, video, etc)

Others like spank, distract, heat, bed, etc. doesn't.

Profile command doesn't work too

I have also noticed that it no longer welcomes members.

I don't know why this happens, if I made sure to keep everything update and install FFMPEG, etc. I attach some images of the errors.
I hope it have a solution, thank you very much.

Hello! Appears a temporary bug from patches on wa automate, but the error 404 says me something else.
This is happen because some commands send a error on the profile picture of a user, i'm trying to finish a update that will correct this errors.
The error 404 is strange, she say "server not found", maybe the server has down temporary or not, i will verify.
For now, the solution of commands that use pic from user is insert a var on the if line, this line have object too, at front of her you need to insert The_Name_Used_on_Var == 'ERROR: 401', that will make the command works, but is a temporary solution.
Thanks for the advise!

I will be closing this issue, but the solution is what i said, or, you can wait the next update to get a new upgrade of corrections.
Any anothet error create a new issue, and thanks again for the bug information!
(If you have the same error, you can create another issue, but is recommended to use that issue).


Update docs to configure credentials with gcloud

@ofrobots @justinbeckwith PTAL.

LGTM

What about the scenario when the user is running on GCE, but their VMs don't have the cloud-platform scope. Our section (above) tells them to following the instructions here – which won't work unless they also install gcloud on their VMs.


Remove justified block from optimistic candidate conditions

Simplifies the spec by removing "The justified checkpoint has execution enabled" condition from optimistic candidate evaluation.
Removal of this conditions implies a tiny change in client behaviour. Before the change, justification of a merge block immediately allowed to safely import blocks from any other chains. After the change, it becomes allowed only when SAFE_SLOTS_TO_IMPORT_OPTIMISTICALLY runs out. This negligible change doesn't affect security of merge transition process.
cc @paulhauner @ajsutton @potuz

Same with prysm


metadata missing

metadata of worker/ps will be lost since objectdata will not be kept.

this is a known issue,
https://github.com/PaddleFlow/paddle-operator/blob/main/controllers/paddlejob_helper.go#L144-L145
will be fixed soon.


[DEVOPS-1124] Add back forcing of warnings as errors

You also need to remove some stuff from the profiling overlay because of my changes. I also need to actually fix all the warnings or this won't go!

Hooray, it's now failing on some warnings!

I'm confused as to why this is failing - I thought I fixed all those warnings on master...

What goes wrong with haddock OOI? I can merge this in the meantime if you want to look into it separately.

I think https://github.com/input-output-hk/plutus/pull/299 will fix it.

LGTM, thanks


Add layout attribute support for GRU operator

Since ONNX opset version 14, layout attribute has been introduced to GRU operator which allows two predefined layouts for input and output shapes.
Add corresponding reference, onnx, and verify tests.
Resolves https://github.com/migraphx-benchmark/AMDMIGraphX/issues/133

Seeing some odd behavior with CI
[2023-12-19T19:46:43.107Z] make[2]: *** Waiting for unfinished jobs....

[2023-12-19T19:46:43.107Z] ccache: error: Failed to create directory /var/jenkins/.cache/ccache/tmp: Permission denied

[2023-12-19T19:46:43.107Z] ccache: error: Failed to create directory /var/jenkins/.cache/ccache/tmp: Permission denied

[2023-12-19T19:46:43.107Z] ccache: error: Failed to create directory /var/jenkins/.cache/ccache/tmp: Permission denied

[2023-12-19T19:46:43.107Z] ccache: error: Failed to create directory /var/jenkins/.cache/ccache/tmp: Permission denied

[2023-12-19T19:46:43.107Z] ccache: error: Failed to create directory /var/jenkins/.cache/ccache/tmp: Permission denied

[2023-12-19T19:46:43.107Z] ccache: error: Failed to create directory /var/jenkins/.cache/ccache/tmp: Permission denied

@TedThemistokleous  The issue with performance tests exist due to the fact that this branch is from our repo, as at that time we did not have access rights for the main one. I believe Chris resolves it locally when all is approved and all comments are addressed.

@lakhinderwalia Although I didn't touch upon this part of code as the spec has not been changed recently (only the layout attribute has been added), I believe it is stated that std::vectorstd::string vec_names = {"sigmoid", "tanh"}; are default values, and they are correctly filled in if no activation functions are provided by the user. If some part of the parsed activation functions is not as expected, there is a readjustment function in src/rewrite_rnn.cpp (rewrite_rnn::gru_actv_funcs).

@lakhinderwalia Although I didn't touch upon this part of code as the spec has not been changed recently (only the layout attribute has been added), I believe it is stated that std::vectorstd::string vec_names = {"sigmoid", "tanh"}; are default values, and they are correctly filled in if no activation functions are provided by the user. If some part of the parsed activation functions is not as expected, there is a readjustment function in src/rewrite_rnn.cpp (rewrite_rnn::gru_actv_funcs).

@nives-vukovic, thanks. I know you didn't touch this code at all :-)
However, the spec https://onnx.ai/onnx/operators/onnx__GRU.html says:
activations - STRINGS : A list of 2 (or 4 if bidirectional) activation functions for update, reset, and hidden gates. The activation functions must be one of the activation functions specified above. Optional: See the equations for default if not specified.
I wasn't pointing at your changes, but I think this gru_actv_funcs() is handling the spec. incorrectly for non-default case of activations, and this is a good time to clean it. We shouldn't be handling activation function list of size 1 or 3: Only 2 and 4, as specified. (Basically, flag errors for size 1 or 3, and also if they are not one of these three valid activation types: relu, tanh or sigmoid. I don't even know if we support the optional types.). That was my suggested change, just to clean it up, if it makes sense. Thanks.

@lakhinderwalia I agree that the current implementation does not seem to be completely in line with the specification, I have modified the parsing accordingly, and modified all migraphx calls to the gru operator so that they always contain either 2 or 4 activation functions. I have also modified onnx test files that had invalid number of activation functions (and that we have been able to support previously). The only thing that is left is a function that adds missing activation functions (if needed) inside the rewrite_rnn file. It is not directly connected to onnx, so I was not sure if it is the best idea to change it now.
It is important to mention that this same inconsistency regarding number of activation function exists also with lstm and rnn operator. They have already been merged, so if what is done here seems as a good solution, I can create a PR to clean those two as well.

Once the Format failure is fixed, then this will merge

Codecov Report
Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (161f9fc) 91.43% compared to head (9a2e1f9) 91.41%.

:exclamation: Current head 9a2e1f9 differs from pull request most recent head f511164. Consider uploading reports for the commit f511164 to get more accurate results

Files
Patch %
Lines

src/onnx/parse_gru.cpp
95.83%
1 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2415      +/-   ##
===========================================
- Coverage    91.43%   91.41%   -0.03%
===========================================
  Files          460      460
  Lines        17356    17370      +14
===========================================
+ Hits         15870    15879       +9
- Misses        1486     1491       +5

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

http://micimaster.amd.com/blue/organizations/jenkins/AMDMIGraphX/detail/PR-2415/3/pipeline/181
There's a failure

@causten I am not able to access the link.


soroban-cli : add metadata to the output of contract inspect

What ?
cli : contract inspect could output more info like build toolchain, and interfaces satisfied.
part of https://github.com/stellar/soroban-tools/issues/519

Dependent on https://github.com/stellar/rs-soroban-sdk/issues/735.


组件不显示

把PPT or PPTX转换为PDF的时候，如果ppt某一页里添加了一个内置的形状然后添加文字或者填充颜色，转换后是没有的，有解决办法么？

I don't I have a solution for this. My conversion is done by external libraries and so are limited by their capabilities.


CC2652P + PSM value for battery_percentage_remaining is inconsistent

I'm testing a sensor with a CC2652P module and PSM firmware ver. <IP_ADDRESS>.
The value returned by battery_percentage_remaining decreases very rapidly reaching 50% (100) with a battery voltage that is still above 3.0 volt

The firmware calculates % from a voltage. 100% is for 3.3V, 50% - for 3V.

In my opinion that does not represent the real battery charge status, please consider that CC2652P chip works perfectly fine even a 2V power supply and with the current settings the firmware would report 0% at 2,7V.
The circuit I'm testing has a brand new 2 X AAA 1,5V batteries and the firmware reports less then 90% battery.
As a comparison, another circuit I have made with a cc2530+cc2591 module and an older PTVO PSM firmware works perfectly fine with correct battery representation. It would be great to have the same settings for CC2652P.

I understand your point, however commercial devices are not designed like that.
The rationale should be:
100% -> battery nominal voltage, for CR2032 is 3.0V
0% -> voltage at which the device stops working
Again, older PTVO firmware for CC2530+CC2591 was perfect.

cc2652p

cc2652p chip works well

100% -> battery nominal voltage, for CR2032 is 3.0V
0% -> voltage at which the device stops working

I think that it is wrong. If the firmware detects 3V (nominal voltage), it is not 100% of the battery because a new battery has 3.3 - 3.4V.
0% depends on your individual battery characteristics, chip, and configuration of your DIY device. It is not possible to calculate it precisely.


could not found @ReactModule annotation in com.swmansion.gesturehandler.react.RnGestureHandleModule

i run command react-native run-android,and then i got  this

React Native version:0.58.6

React Native Environment Info:
System:
OS: Windows 10
CPU: (20) x64 Intel(R) Xeon(R) CPU E5-2660 v2 @ 2.20GHz
Memory: 3.98 GB / 15.93 GB
Binaries:
Yarn: 1.19.1 - C:\Users\Administrator.SC-20191023
Steps To Reproduce

Describe what you expected to happen:
good running
Snack, code example, screenshot, or link to a repository:

Please upgrade you RN to 0.60 or above, as @ReactModule annotation is introduced in 0.60. Thanks


Translation Context per Resource

Is there a way to customizes message per Resource.
I want to change aor.notification.created but only for specific resources.

Hi, and thanks for your question. As explained in the admin-on-rest contributing guide, the right place to ask a "How To" question, get usage advice, or troubleshoot your own code, is StackOverFlow.
This makes your question easy to find by the core team, and the developer community. Unlike Github, StackOverFlow has great SEO, gamification, voting, and reputation. That's why we chose it, and decided to keep GitHub issues only for bugs and feature requests.
So I'm closing this issue, and inviting you to ask your question at:
http://stackoverflow.com/questions/tagged/admin-on-rest
And once you get a response, please continue to hang out on the admin-on-rest channel in StackOverflow. That way, you can help newcomers and share your expertise!

Why did you close this?
There is nothing in the documentation about resource-specific translation.
If it's possible but not in the documenation, the documenation lacks.
If it's not possible, this is a feature-request ;).

Forgive my perseverance, but in my humble opinion SO is NOT the right place to ask the question, because I don't need an idea on how to hack admin-on-rest so that it translates the messages, I need to know whether it's officially possible and just omitted in the documentation.
Should I rephrase this as Feature-Request and open a new issue?
Thank your for your time.

No, it's not currently possible and I don't see how to make it happen.
The only thing we might do is to pass the resource's name to the translation mechanism so that you could include it in your message. Something like: "aor.notification.created": "You created a %{resource}.". If that's what you need, I'll reopen this issue as a feature request. If not, consider this won't fix anytime soon.
However, it's OSS, if you do find a way to implement this, please open a PR :) FYI, this is handled in the crudResponse saga

How about overlaying all message per resource?
So that {resource}.aor.notification.created would get checked first, and after that aor.notification.created

Give it a try ;)


Analyse executor requirements

The Vision
As part of the substrate refactoring we want to analyse the requirements of the wasm executor component and figure out what improvements can be made. In particular we want to make it a separate standalone component (that isn't owned by any other component).
The Plan

Analyse what kind of prioritization is required by the different users of the executor, in particular we want to make sure that block authoring and import is prioritized over other uses.
Analyse whether it is possible to make the executor API asynchronous.

Open Questions
If you want to help us out and contribute to this issue, in this section you can find open questions and tasks where we would appreciate any input.
If you have any suggestions or requirements that you'd like for the executor feel free to do so and they can be integrated into the analysis done as part of this issue.

Here you can find the board with specific sub-tasks to this milestone:
https://github.com/orgs/paritytech/projects/18/views/10

I've been collating this project to collect issues for the executor. I would really appreciate it if that was taken into account.


你好，batch size 大于1的时候  训练出现 recursionerror 是怎么回事呢？

@sc1234qwer 应该是你的数据准备出了问题，请按照readme准备你的训练数据。 如果还有问题可以贴一下你的train.txt文件截图:)

我用的example里面的train.txt 只改了下路径    batch size=1的时候可以训练，大于1就不行了。训练开始有UserWarning: Converting sparse IndexedSlices to a dense Tensor of unknown shape. This may consume a large amount of memory.
"Converting sparse IndexedSlices to a dense Tensor of unknown shape. "

@sc1234qwer , you can check the annotations according to the suggestion given by MaybeShewill-CV or have a try of my repo which implements SCNN using tensorflow.

@sc1234qwer , you can check the annotations according to the suggestion given by MaybeShewill-CV or have a try of my repo which implements SCNN using tensorflow.

I'll try it when I finish the lanenet.


os-prober: init at 1.65

Motivation for this change
Make os-prober available on nixos, and eventually solve https://github.com/NixOS/nixpkgs/issues/7406
With this package, I can use os-prober this way :
  boot.loader.grub = {
    enable = true;
    version = 2;
    device = "/dev/sda";
    extraPrepareConfig = "PATH=$PATH:${pkgs.os-prober}/bin:${pkgs.busybox}/bin pkgdatadir=${pkgs.grub2}/share/grub ${pkgs.grub2}/etc/grub.d/30_os-prober > /boot/grub/grub-os-prober.cfg";
    extraEntries = ''
      menuentry 'Other OS' {
        configfile $prefix/grub-os-prober.cfg
      }
    '';
  };

Still not perfect, but at least it works.
Things done

[x] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] Linux

[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

I do not use grub myself, but this sound likes a useful addition to the existing grub module.

Oh. I noticed too late, that you opened the pull request against release. Please open it against master again.

Ah, sorry. I reopened a new PR on master since it doesn't seem possible to reopen this one.


Set OS X deployment target to 10.12 Sierra

As discussed in #42, the 10.12 deployment target is a less intrusive change.
Only involves removing subscriptionTerms, which are already removed for iOS pre-11.2.

Much more comfortable merging this; can you run the test suite on 10.12 for posterity? Thanks. I don’t have easy access to a 10.12 machine.

Sorry, haven't been able to test this using 10.12. If anyone else has a machine that is able to, please let me know.
I'm realizing now that the testing I was doing in the other PR wasn't actually testing that logic. Modifying the 10.12+ methods to always return nil produces a few test failures for subscription terms.
I'll come through with a patch in the future to fix these tests.

I just tweaked the availability syntax to use macOS rather than OSX identifiers and merged the availability definitions into a single attribute. I'm happy to merge this if you are happy. I wasn't sure what you meant by the followup testing logic in your last comment.

Yes, looks good.


Feature/str10

Added:

Changes to settings.py

To run, a .env must be present in the streatham_go/streatham_go directory
see readme (made changes) for instructions of what to put in this file

On user register, there account is inactive, an email gets sent containing an activation link to /accounts/<username>/activate?token=<token>.
The activation page activates the users account if a valid token is provided
If DEBUG=True in .env file, Do not send email, instead a link to the activation page is provided
tests for the activate view
changes to github workflow to create this .env file as-well as general cleanup
cleanup to other tests
added error/success messages to register and login

 Verify Email


[ko] Translate pod-security-admission.md into Korean

In English
Translated Pod Security Admission in Korean.
In Korean
쿠버네티스 문서/개념/보안 항목의 미번역된 Pod Security Admission를 한국어로 번역.

@H13m0n Thanks you for your contribution.
Could you please sign the CLA before the PR can be reviewed.
You can follow the steps documented here: CLA Steps

Issue #40609
@dipesh-rawat Thank you, I have completed the CLA sign
and checked that it was changed to covered.

/assign @seokho-son

@seokho-son 님, 상세한 리뷰 감사드립니다!
의견주신 내용들 살펴보고 적용하였습니다.
시간 되실 때 확인을 부탁드립니다. 😊

Thanks!
/lgtm

/approve


credservice.go fails to run.

The script was working just fine for many days but today I started getting this error
MAIN    : 2021/02/16 20:23:48 main.go:95: INFO     Constructing fallback DNS upstream... MAIN    : 2021/02/16 20:23:48 main.go:101: INFO     Initializing configuration provider... CRED    : 2021/02/16 20:23:49 credservice.go:34: CRITICAL Configuration bootstrap failed: invalid character '<' looking for beginning of value MAIN    : 2021/02/16 20:23:49 main.go:104: CRITICAL Unable to instantiate credential service: invalid character '<' looking for beginning of value

Hi!
I've seen such behavior about an hour ago, but now it seems working. Probably there was temporary issue on Hola backend.


chore: bumping react-markdown to ^5.0.3 for downstream dependencies

SUMMARY

Wanted to bump this package in order to bump it's innards. According to the changelog, this should be no biggie.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

Spin up a test env, and make sure markdown components don't fail spectacularly :)
ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Required feature flags:
[ ] Changes UI
[ ] Includes DB Migration (follow approval process in SIP-59)

[ ] Migration is atomic, supports rollback & is backwards-compatible
[ ] Confirm DB migration upgrade and downgrade tested
[ ] Runtime estimates and downtime expectations provided

[ ] Introduces new feature or API
[ ] Removes existing feature or API

Unit tests failing spectacularly... so much for easy!


How to generate grid effectively with theme

[x] This is a question about using the theme.
[ ] I believe this to be a bug with the theme --- not Jekyll, GitHub Pages or one of the bundled plugins.
[ ] This is a feature request.
[ ] I have updated all gems with bundle update.
[x] I have tested locally with bundle exec jekyll build.

Environment informations

Minimal Mistakes version: 3.3.3
github-pages or jekyll gem version: 3.1.6
Operating system: MacOS 10.12.3

I apologize for posting so many questions but I am a little stuck on trying to figure out best to lay out a grid with the theme. I am trying to replicate a grid-based conference schedule as seen here. I have had good success with the full-width items but when it comes to the parallel sessions (the light purple ones), I am having trouble getting it to behave as it should: basically, I'd like the columns to stack one on top of each other responsively but that doesn't seem to happen.
Here's the HTML for the row:

Monday, June 13

        ...

        ...

        ...

and here's the CSS:
    &.session-papers1 {
        @include span(4 wide of 12 (gutter-override: 0));
    }

    &.session-papers2 {
        @include span(4 wide of 12 (gutter-override: 0));
    }

    &.session-papers3 {
        @include span(4 last (gutter-override: 0));
    }

This looks fine in desktop mode:

but in responsive mode, it doesn't follow the expected behavior:

Am I doing something wrong? Do I have to explicitly encode the responsive layouts myself in the CSS? I was hoping that the theme would take care of it.

You'll need to add the widths for various screen width breakpoints. Basically the way I've done it is using a "mobile-first" philosophy.
Start with how you want things to look for small screens, then add a breakpoint when you want it to change. Repeat.
Since you want them to stack you'll want to start with them spanning then entire set of columns 12 of 12. Then when you hit tablet or desktop screen sizes you can have them shrink down to 4 of 12 so you can do 3 in a row.
To do that you can use the breakpoint mixins.
Something like this.
.your-class {
  // mobile first styles here

  @include breakpoint($medium) { // will convert to a max-width:768px media query
    // 600px wide and up styles here
    // column width 100%
  }

  @include breakpoint($large) { // will convert to a max-width:1024px media query
    // 1024px wide and up styles here
    // column width 33.3333%
  }
}

The $medium and $large variables are just widths for common screen sizes. You can use them or be more specific if you have a need for that.

This works beautifully! Thanks so much for your guidance.


Fix #2071: Removed color code to fix Chalk colors

Removed extraneous color code that broke output on Windows as shown in https://github.com/mochajs/mocha/issues/2071

I wonder if chalk handles \u001b[0m for us, making resetting to the normal color unnecessary. But I guess given our lack of test coverage around this, it's best to keep the changeset small.

From reading the source code of what Chalk uses , it appears to reset already for the open / close. Testing with my mocha tests for my ESLInt config, it seems that is true. Should I remove it as well and amend the commit?

Sure, I'll just wanna test with a bunch of reporters prior to giving a thumbs up

From reading the source code of what Chalk uses , it appears to reset already for the open / close

Yeah, having worked on Chalk, I can definitely confirm that is the case. Both the opening and closing escape can be removed.

Should I remove it as well and amend the commit?

Yes please :)

Sure, I'll just wanna test with a bunch of reporters prior to giving a thumbs up
Show all checks

Absolutely! Although I can confidently say that there's no need to do any extra escaping/wrapping around Chalk.

Amended the commit to remove the reset code. :+1:

@thedark1337 thanks!


BrowserslistError: Unknown version 0 of and_chr

Steps to reproduce

<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>browserslist config in the package.json

...
"browserslist": [
    "> 1% in RU",
    "last 2 versions"
]
...

postcss.config.js is simple

module.exports = {
    plugins: [
        require('postcss-import')(),
        require('autoprefixer')()
    ]
};

NODE_ENV=production webpack --hide-modules --bail throws

ERROR in ./styles/index.css
Module build failed: ModuleBuildError: Module build failed: BrowserslistError: Unknown version 0 of and_chr
    at error (~/{path_to_project}/node_modules/browserslist/index.js:29:11)
    at Function.select (~/{path_to_project}/node_modules/browserslist/index.js:555:21)
    at ~/{path_to_project}/node_modules/browserslist/index.js:180:41
    at Array.forEach (native)
    at browserslist (~/{path_to_project}/node_modules/browserslist/index.js:169:13)
    at isSupported (~/{path_to_project}/node_modules/caniuse-api/dist/index.js:75:10)
    at ~/{path_to_project}/node_modules/postcss-merge-rules/dist/lib/ensureCompatibility.js:87:66
...

PS

NODE_ENV != production -> ok
not use "> 1% in RU" -> ok
use "> 1% in US" -> not ok

What caniuse-db version do you use? Please update if it is not latest.

@ai
└─┬<EMAIL_ADDRESS>  └──<EMAIL_ADDRESS>

And what caniuse-db are used inside browserslist? Seems like Autoprefixer and Browserslist use different versions.

@ai I see only one version of caniuse-db
> du -a node_modules | grep "caniuse-db\/package\.json"
8       node_modules/caniuse-db/package.json

> npm ls caniuse-db
└─┬<EMAIL_ADDRESS>  └──<EMAIL_ADDRESS>
How could I influence version of caniuse-db for browserslist?

Try to find any caniuse-db directory in node_modules. Maybe caniuse-api contains different version?

@ai
both of caniuse-db and caniuse-api contains once
> npm ls caniuse-api
└─┬<EMAIL_ADDRESS>  └─┬<EMAIL_ADDRESS>    └─┬<EMAIL_ADDRESS>      └──<EMAIL_ADDRESS>
> du -a node_modules | grep "caniuse-api\/package\.json"
8       node_modules/caniuse-api/package.json

Strange. You query work on my system. Could you create small project to reproduce?

@ai https://github.com/finico/browserslist-reproduce

Thanks, I will look tomorrow

Fixed ac5071b. Thanks for report.

Released in 1.6

@ai Thanks

Technically it was Can I Use mistake. But it is hard to fix it there. So I add hack to Browserslist.
@ben-eb maybe we will fix it in you project. Can I use had version 0 in countries statistics, but 55 in global data.

I'm still getting this error consistently, but only on CI (Linux) and never local (macOS).

@stevenvachon I recommend to use yarn, because it lock version to yarn.lock and you can find what versions are used (also yarn is few times faster).

I just noticed that my CI server was set to use node v6.3.0. The problem is solved by switching to 7.4.0, which likely forces a newer version of npm.

Scratch that -- it was just a fluke. It started consistently failing again with the same error. Switching from npm install to yarn seems to be consistently working. Thanks!


new readings

add new readings to the course description:

Broman, Karl W., and Kara H. Woo. "Data organization in spreadsheets." The American Statistician 72, no. 1 (2018): 2-10.
Wickham, Hadley. "Tidy data." Journal of statistical software 59, no. 1 (2014): 1-23.
Project Oriented Workflow (https://rstats.wtf/project-oriented-workflow.html) in What They Forgot to Teach You About R by Jennifer Bryan, Jim Hester

added


Improve note field actionable items

This PR replaced the icon buttons with text buttons in the note field and removed icon buttons with ambiguity.

Merci!


fix: Decimal class type compatibility

__name__ attribute is used in DBT to map python class to SQL query.
This is needed for https://github.com/firebolt-db/dbt-firebolt/pull/95

Should we add one for ARRAY as well?

Sure, added it. DBT uses slightly different check for array, but might as well keep everything standardised.


Make Expression API available to Java, Rename it to Table API

This also adds tests and more Javadoc documentation for the Table API.

We had a discussion on the dev mailing list regarding the name of the API which was leaning a bit towards Table API / DataTable, but I don't think we had a consensus there, right?

Correct, that's why I'm doing a Pull Request. People can chime in here if they want.
Or should we continue the discussion on the mailing list? I though everyone would be more or less happy with Table.

I think @fhueske just suggetsing it would be less work to have the new name settle before PR being submmitted.

Exactly, thanks @hsaputra
It would also be good to add some actual arguments to the discussion that go beyond "I like xxx more than yyy" ;-)

Gah, I just did that in the discuss thread  =P

Touché

The code looks good. Impressive test coverage, some documentation, amazing feature.
Once the political issues (name) are resolved, :+1: to merge.
Do you think it would be a good idea to add the grammar of the parser to the documentation?

I fixed @rmetzger's remarks. Still waiting for a solution to the naming issue.


README.md: add logo

Following https://github.com/kinvolk/kube-spawn/pull/228, add the logo in the README.md.
Fixes https://github.com/kinvolk/kube-spawn/issues/227

This looks a little strange. Can you put the logo under the kube-spawn header?

As discussed OOB, LGTM

Yeah, I gave in. ;)


Merge pull request #1 from Microsoft/master

Fixes #
.

Hi @wiltonlazary, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, MSBOT;


support mermaid diagrams in documentation

This PR  will add basic support for showing mermaid diagrams on the documentation page

Hi @simonbrowndotje,
This PR introduces support for Mermaid diagrams in documentation. I believe this feature can help centralize technical documentation and position Structurizr as the single source of truth for both architecture and related technical workflows. It enhances versatility, making documentation more expressive and collaborative. Let me know your thoughts!
Thanks @amirhosseinfaraji for this!


[FLINK-4305] test Jenkins GitHub integration

Cool, thanks for setting this up.
Empty commit just for reference/triggering?

Sure, no problem. The empty commit is just for testing the integration. Can't break anything with an empty commit :)

Looks like the integration works.


Android and UWP font family needs to be applied to Card

Host Config specifies FontFamily but android does not respect that option.

@eschavez any ETA on when this will get checked in?

UWP doesn't support this either

iOS does support it

Fixed.


Tidy up the file engine so it's not so aggressive with what is a session

LGTM :+1: Thanks @ukd1 :pray:

LGTM :+1: Thanks @ukd1 :pray:


Version numbers in release docs don't match versions in package.json

I'm not sure if this is the right place to file the issue, but the version numbers in package.json for each component is 0.0.1 higher than what's in the release notes on the docs page. E.g. the dropdown is listed as 0.1.5 on the website but it's 0.1.6 in the Feb 28 commit.

Hey @phirework,
You're right, it seems something got a bit out of order in the release notes section (individual pages seem to be correct).
Thanks for the heads up.

Addressed here: #379


waterlogged blocks act as air blocks which hurts you in the merling origin

Fixes
Added waterlogged blocks to Merling air check
Improvements
Switched to predicate detecting fluids (water)


added how to manually update application

Just so it's there for people like me, who have no idea how to update it when you release a new version.

Ah, nice. I would prefer to define this in another section but I will definitely land it.
Also, for what it's worth; it's typically a good practice to use the @latest tag as well to ensure an upgrade occurs:
npm install -g google-music-electron@latest

Ah, nvm. I misread your commit as install -- yep, update should work as well =)

Moved it and changed it follows same "design" as the getting started part

Added a few personal touches (e.g. removed redundant words, changed tense of "Update"). This has been merged/released in 1.14.1. Thanks for the PR =)


Add pass to remove dead members.

Add a pass that looks for members of structs whose values do not affects
the output of the shader.  Those members are then removed and just
treated like padding in the struct.

@dnovillo @alan-baker I believe I have addressed all of your issues.  Please take another look.

The NDK build passed if you look at the build logs, but github did not seem to be notified.

The NDK build passed if you look at the build logs, but github did not seem to be notified.

I addressed @dnovillo's issues, and he may not be able to get back to it for a couple days.  I'll merge.  If he has any other issues, I'll address them in another PR.

I addressed @dnovillo's issues, and he may not be able to get back to it for a couple days. I'll merge. If he has any other issues, I'll address them in another PR.

Thanks.  I finally took another look.  LGTM.


App Store Author?

This program is available in the iOS App Store with the author name Marcela Cid.
I just want to know whether Marcela Cid is connected with @ColdGrub1384  in some way so that my purchase will support this development.
Also, is there a way to install this program without the App Store?  Do I have to become an Apple Developer?

There are some other apps like "FoodKravings", "Afrimall Shopping" or "Collect The Trash!" that I made for clients on the App Store Account. But all apps under Marcela Cid developer account are coded by me except "Collect The Trash!" that I published for a friend.

Great!   Thanks for the info!  Congrats on publishing quality work...

Thank you!


Wmstats site fix

fixes #8240,

@amaltaro, Alan, I know it is ugly. so please suggest better way.

test this please

We right now read the condor.log 3 times. We should read it only once and then make all the regex searches once it's all loaded in memory.
I also believe we could fetch only the last X lines of that file and look up for those regex.
Both the Reason and the MachineAttr... should be at the very end of the file, if available.
Last but not least :-) for the master version, I'd actually move all those file handle related functions from BasicAlgo to Utils

We right now read the condor.log 3 times. We should read it only once and then make all the regex searches once it's all loaded in memory.

Yes, you are right. I would prefer not to load whole thing in the memory but not sure how to do in first search case (since it has to store multiple lines).  I would either find way to do this or make regex to run against memory since we store them in first case anyway.

I also believe we could fetch only the last X lines of that file and look up for those regex.

This is harder to decide which X we have to choose. (We have settings for 50 - 250 lines but some times it wasn't enough)

Both the Reason and the MachineAttr... should be at the very end of the file, if available.
Last but not least :-) for the master version, I'd actually move all those file handle related functions from BasicAlgo to Utils

Yes, I think I have to make more generic,
Thanks Alan

@amaltaro, Alan, could you review again.
Here are the changes.

It won't put everything in the memory (mmap)
It will search the multiple regex (with or) at one time.
This assumes if there are multiple parts exists for Reason, and MachineAttrGLIDEIN_CMSSite0 the values (text part) will be all the same.

I have a question though, What does "MachineAttrGLIDEIN_CMSSite0" mean exactly? Even it is in HELD state this means job is assigned and sent to there?

test this please

test this please

@amaltaro, Alan test ran OK. Could you review again?

Something is not right on Jenkins unittests

test this please


Support for aeg-channel-name header in Azure.Messaging.EventGrid

Partner Events in Event Grid recommend routing via Channels - https://docs.microsoft.com/en-us/azure/event-grid/partner-events-overview-for-partners#channel. Routing via Channels is to be supported via HTTP Header aeg-channel-name
The Microsoft API documentation also mentions use of aeg-channel-name in request header for publishing to partner namespaces
https://docs.microsoft.com/en-us/rest/api/eventgrid/dataplane/publish-cloud-event-events/publish-cloud-event-events
However I wasn't able to see support for specifying this header while creating EventGridPublisherClient (https://github.com/Azure/azure-sdk-for-net/tree/Azure.Messaging.EventGrid_4.10.0/sdk/eventgrid/Azure.Messaging.EventGrid). Is this header not yet supported in SDK, if not when is the plan to implement it's support.

Thank you for your feedback.  Tagging and routing to the team member best able to assist.

This is available in beta version 4.11.0-beta.1 - https://www.nuget.org/packages/Azure.Messaging.EventGrid/4.11.0-beta.1 via the SendCloudEventOptions.


Ensuring compatibility with Juju 3.X

Description

Fixes watchdog to be compatible with Juju 3.X
Fixes lots of minor things

Checklist

[x] My code follows the style guidelines of this project.
[x] I have performed a self-review of my own code.
[x] I have made corresponding changes to the documentation.
[x] I have added tests that validate the behaviour of the software.
[x] I validated that new and existing unit tests pass locally with my changes.
[x] Any dependent changes have been merged and published in downstream modules.
[x] I have bumped the version of any required library.

And integration tests are failing


Export to JSON and to Image

Hi @dabeng, I'm a bit newbie to Vue, but I find a great potential of your project to my side project.
How can I create an export to JSON and export to image buttons? Is it possible to have a exposed function?
If it is not implemented yet, are you going to implement it for your next release?
Thank you so much

Do you mean exporting current structure to a json file？

Hi @dabeng
It would be great if you provide the functionality which export current Chart to Image such as PNG.
Thanks.


Implement RemoteAPI for Node

I'd like to be able to connect to the datastore from any NodeJS application including my local. It would be great if the gcloud-node had the RemoteAPI implemented such as python(https://cloud.google.com/appengine/docs/python/tools/remoteapi).

I might misunderstand, but we support connecting to both the remote API and localhost as well. I know you've been connecting to the emulator, so you already know how to do that. To connect to the remote API, just unset the Datastore emulator environment variable, and make sure to provide a keyFilename with a path to your key file.

I have my nodejs directory which looks something like this:
MyApp
-app.js
-mycredetnials.json
-package.json
+node_modules
Inside of my app.js file I have the following code:;
var options = {
projectId: 'mydatastoreproject'
}
var keyFile = './mydatastoreprojectsandbox-5265e25422c.json';
if (keyFile) {
options.keyFilename = keyFile;
}
var datastore = gcloud.datastore(options);
I am running this from my local computer. I want my local computer to be able to connect to the Google Cloud Datastore (not the local emulator).
In my developer console I have enabled Google Datastore API. I created a KIND in the developer console and created one entity. I have also created credentials (service account key) in the form of a json file. I then included this json file in my code. By doing this I am still unable to connect to the datastore. Am I missing something or doing something wrong? Essentially all I want to do is to have my local machine connect to the Google Datastore.

When you start the local datastore and it prints out "Set these environment variables", did you do that? Is that how you've been connecting to your local Datastore so far? By default, gcloud-node tries to talk to the remote API and assumes there is no emulator running. It has to be told to talk to the emulator, which can be done via the env var (DATASTORE_EMULATOR_HOST). If that is what you've been setting, you will have to unset it (or manually do it from the JS script: delete process.env.DATASTORE_EMULATOR_HOST;).

ahhhhh yes I had this variable set. All works now thanks!

No problem, glad that it works now!

how to run on pcf

How will I be able to use the datastore emulator without the key.json for nodejs?


Each time i kill the Drake, a new Portals gets formed...

https://i.imgur.com/Riu2DEl.png
1.17.1, fabric, just another modpack 2.9.2b, better-end-0.11.0-pre.jar

Duplicate of old issues, looks like sometimes file cannot be readed properly or there is an issue in code that are not triggered on each time

Fixed in 0.12.5


simplejson.errors.JSONDecodeError: Expecting value: line 1 column 1 (char 0)

Why I am getting JsonDecodeError with disbursements even when the http response is 202?
This is what I am getting back after calling transfer method;
return self.scan_once(s, idx=_w(s, idx).end())
simplejson.errors.JSONDecodeError: Expecting value: line 1 column 1 (char 0)

This is the data I am pushing through;
headers
Out[9]:
{'X-Target-Environment': 'sandbox',
 'Content-Type': 'application/json',
 'Ocp-Apim-Subscription-Key': 'hidden',
 'X-Reference-Id': 'hidden'}
data
Out[10]:
{'amount': '600',
 'currency': 'EUR',
 'externalId': '123456789',
 'payee': {'partyIdType': 'MSISDN', 'partyId': '256772123456'},
 'payerMessage': 'dd',
 'payeeNote': 'dd'}

And these are the values of the resp variable;
resp
Out[20]: <Response [202]>
resp.headers
Out[21]: {'Content-Length': '0', 'Date': 'Thu, 23 May 2019 11:08:30 GMT'}
resp.status_code
Out[22]: 202
resp.text
Out[23]: ''

Its trying to decode an empty response as JSON.  Let me file this as a bug and push a fix

Hey,  I wasn't able to reproduce this. How are you getting the error?

The data I am pushing to the api and what I am getting back is all listed above.

Hi @oquidave please help us help you by telling us how to recreate your error. The "New Issue" template for details how to do this.

@raybesiga @mossplix Since this issue wasn't closed, I'll add to it instead of creating a new one.
Issue can be reproduced simply by installing simplejson
See POC here

Thanks for adding to this @jamesidw We shall look into it this week.

@jamesidw @oquidave did you ever get around this issue?


[volk] Updating volk port to 1.3.233

Describe the pull request

What does your PR fix?
Updates volk to the latest version

Which triplets are supported/not supported? Have you updated the CI baseline?
all

Does your PR follow the maintainer guide?

Yes

Oops, bunged up the branching here


All high-security airlocks now have proper access restrictions

About the PR
Each head now has their own access level, and that level is required for all relevant doors. No more CMO taking the cap's spare ID 15 seconds into the round. In addition, armory is a new access level only available to HOS and Captain (but will probably be given to warden too when they are added.).
Changelog

:cl: Rane

tweak: Airlock access to high security areas has been updated to include only those who need it.

I will note the Warden is in the game files already, so it wouldn't hurt to edit them to have access even if they're unused

Added

I'll have it ready after work tonight. Someone else merged a much newer pr that duplicates a bunch of stuff in this one. Hopefully after that it's merged before I have to fix it again.

@metalgearsloth @PaulRitter I redid all the maps and fixed the conflict (automatic map merging produced a map that wouldn't load), please review before I have to do it again.


$? of redirection >, >>, 2>, and 2>> is unexpected.

Prerequisites

[x] Write a descriptive title.
[x] Make sure you are able to repro it on the latest released version
[X] Search the existing issues.
[X] Refer to the FAQ.
[X] Refer to Differences between Windows PowerShell 5.1 and PowerShell.

Steps to reproduce
$? of redirection >, >>, 2>, and 2>> is unexpected.
Expected behavior
PS> "hello"
hello
PS> "abc" > $null
PS> $?
True
PS>
PS>
PS> 2 + "a"
InvalidArgument: Cannot convert value "a" to type "System.Int32". Error: "Input string was not in a correct format."
PS> "abc" > $null
PS> $?
True

Actual behavior
PS> "hello"
hello
PS> "abc" > $null
PS> $?
True
PS>
PS>
PS> 2 + "a"
InvalidArgument: Cannot convert value "a" to type "System.Int32". Error: "Input string was not in a correct format."
PS> "abc" > $null
PS> $?
False

Error details
No response
Environment data
Name                           Value
----                           -----
PSVersion                      7.1.4
PSEdition                      Core
GitCommitId                    7.1.4
OS                             Microsoft Windows 10.0.19042
Platform                       Win32NT
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0…}
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>
WSManStackVersion              3.0

Name                           Value
----                           -----
PSVersion                      7.2.0-preview.9
PSEdition                      Core
GitCommitId                    7.2.0-preview.9
OS                             Microsoft Windows 10.0.19042
Platform                       Win32NT
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0…}
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>
WSManStackVersion              3.0

Visuals

The Engine WG reviewed this issue and agreed this is a bug that should be fixed. Hopefully #16046 will fix it.


dts: intel_s1000: Enable generating IRQ priority

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@4c7a44b). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #7749   +/-   ##
=========================================
  Coverage          ?   55.01%
=========================================
  Files             ?      483
  Lines             ?    53949
  Branches          ?    10494
=========================================
  Hits              ?    29679
  Misses            ?    19983
  Partials          ?     4287

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c7a44b...5714385. Read the comment docs.


[HYP-51][Clinic] Edit course page

Jira: HYP-51
-recolor add course btn
resize add course btn
– [x] Artifacts Added

Please resolve conflicts.

Build failed, please resolve this one as well.


security: fix for major vulnerabilities

soft-deprecate how SRI options were defined, introduce new SRI options object
Introduce options to disallow SRI hashes generation for inline scripts and styles
Introduce allow-lists for cross-origin resources that might need SRI hash generation at runtime (SSR)

@SocketSecurity ignore npm/<EMAIL_ADDRESS>


STORM-2650: Expand property substitution test for Flux to cover non-s…

…tring properties
See https://issues.apache.org/jira/browse/STORM-2650

+1 great to add the test.

+1


Version 0.5.0 is not using Lodash 4.12 as stated

Release tag says it is using lodash 4.12.0 but in ng-lodash comments it says version is 4.6.1.  Also confirmed "meanBy" function is missing which was added in lodash 4.7.0.

I can confirm this is the case for me too.

Agreed. The actual version used is 4.6.1 instead of 4.12.0.


Question to all LinUtil Users

Should there be a LinUtil community discord server?

Sure why not

you can make this a discussion.

We’re using Discussions as a place to connect with other members of our community. We hope that you:
1. Ask questions you’re wondering about.
2. Share ideas.

Welcome to linutil Discussions!
BTW name this "make LinUtil Discord server"

/close https://discord.gg/bujFYKAHSp


ja: Make glossary/persistent-volume-claim.md follow v1.17 of the original text

This is a Feature Request

What would you like to be added
Update glossary/persistent-volume-claim.md to follow v1.17 of the original (Englist) text.
Why is this needed
content/ja/docs/reference/glossary/persistent-volume-claim.md it outdated.
Comments
/language ja
/good-first-issue
File to update
https://github.com/kubernetes/website/blob/dev-1.17-ja.2/content/ja/docs/reference/glossary/persistent-volume-claim.md
Original
https://github.com/kubernetes/website/blob/release-1.17/content/en/docs/reference/glossary/persistent-volume-claim.md
diff between translated and v1.17
https://gist.github.com/oke-py/af09238c9af098fe077fa79e58986ed3
Note
Currently, we use dev-1.17-ja.2 branch. Please open a PR targeting the branch.
ref
How To Contribute
翻訳スタイルガイド
If you have a question, feel free to ask us here or slack.k8s.io #kubernetes-docs-ja channel.

/language ja

/assign

/assign

/close


Implement level_to_nside

Closes #13

Coverage increased (+0.07%) to 98.206% when pulling 99c84801285b0dbcf5b2a4d91cd140f40bb976ab on astrofrog:level into 4d289efa79b0d9042daac0edaa518d79700d09d8 on cdeil:master.


[Bug]: Block applying in a spawned task synchronized incorrectly with in-memory update

More context in this thread: https://github.com/0xPolygonMiden/miden-node/pull/340#discussion_r1588908573
From @bobbinth:

In general, this mechanism is used to support the following process:

We start the database transaction and update the database. While this is going on, reads against the database are allowed as they read the previous state. So, the store can still serve all requests.
Once the data has been written to the database, we lock the in-memory structures for update. At this point, the store blocks on all requests.
We update in-memory structures. While this is going on, the store cannot serve any requests - so, it is critical to make this section as fast as possible.
We commit the database transaction and release the lock on in-memory structures.

Because database transaction and in-memory structures live in different places, we need this channel - but I am wondering if there is some way we can refactor the structure to make the code simpler.

According to the code, current implementation has these bugs:

When we lock in-memory data, we don't wait until commit is succeed and start to update in-memory. Even in a case of failed commit, in-memory data will be updated. By the way, we have a comment about this below.
Once we finish update in-memory data, we unlock it instantly without waiting for finishing of database update.
Error result of db.apply_block in tokio::spawn only logged, but not re-raised or handled.

Is that a problem though? The implementation is just ensuring that reads to the in-memory representation are consistent with the DB. If the commit fails, then the whole server should come down, is it only being logged?

Oh, okay. It seems there is a block store struct that also writes data to disk but from the in-memory side of things, so the existing code seems broken indeed.

Closed by #370.


Proportional food times

Higher nutrition = slower eat time.

-Default value should be changed
-You should make it so 0 disables the feature
-Maybe make the value different for snacks than from the rest of the food?

on it!

This feature, at least how it is, doesnt seem to have reached my expectations on a proper food rebalance. This feature was inherinted from the fork, so i think we should maybe reevaluate it and/or see how we can improve it so it properly fits our goals.

I apologize for the inconvenience if this feature gets scrapped, but we havent had much time to properly review some of the features proposed on the previous project prior to the fork.

its fine, I had fun making it!


Fix link

"Now that babel-preset-env has stabilized, it has been moved into the main Babel mono-repo."

Yeah that's kinda weird :D.

Thank you!


Improve hypriot/docker network stability

Check if we should add this to the HypriotOS image:
See docker/docker issue 19532 "hypriot/docker network stability issues." ->
https://github.com/docker/docker/issues/19532#issuecomment-216070151

@gazzer82 I finally got a chance to try the workaround mentioned @StefanScherer it also did not work for me. But... I do believe I have found the solution. With many, many thanks to @aaronlehmann! He originally found the workaround here docker/distribution#785 (comment). He has a more complete summary on docker/libnetwork#1090.
I ended up using his echo 1 > /proc/sys/net/ipv4/netfilter/ip_conntrack_tcp_be_liberal workaround.
This has me now building container images from home!
Hope this helps you and others!
Will

reverting PR #112 with #113 as it does not work yet.


menu bar needs manual updating

Extension
https://www.raycast.com/mooxl/coffee
Description
The caffeinate status in the menu bar doesn't update and need to be manually activated instead of truely reflecting the status
Steps To Reproduce
Activate caffeinate / decaffinate and watch the menubar
Current Behaviour
No response
Expected Behaviour
No response

The issue has been resolved.
@raycastbot close this issue


Add marshmallow as a test requirement, and fix pytest setup

Running python setup.py test on develop would give me an
ERROR: file not found: test

In this PR, pytest is now integrated according to the recommendations at
https://docs.pytest.org/en/latest/goodpractices.html#integrating-with-setuptools-python-setup-py-test-pytest-runner
The default test run is also limited to tests under the tests/
directory, excluding e.g. benchmarks/ which would have added a
number of dependencies.

Coverage remained the same at 99.566% when pulling f1bf9c74b4a8e63c78647db40ec0f269e3b8f90a on akaihola:fix-setup.py-test into 78afab03ebd0112d4f04a4103c039771d7048dee on timothycrosley:develop.

Coverage remained the same at 99.566% when pulling f1bf9c74b4a8e63c78647db40ec0f269e3b8f90a on akaihola:fix-setup.py-test into 78afab03ebd0112d4f04a4103c039771d7048dee on timothycrosley:develop.

Looks great, thank you!


RuleParameter.Value changes type of ExpandoObject values

Steps to Reproduce

Create and register a custom Action and configure it in a workflow.
Create a Ruleparameter and set the Value to an ExpandoObject with data that will trigger rule success for the workflow. Call RuleEngine.ExecuteAllRulesAsync with the RuleParameter as an argument.
Check the type of RuleParameter.Value in the custom action ( Actionbase.Run).

Expected Behavior
Cast RuleParameter.Value as ExpandoObject and access the properties and data.
Observed Behavior
The cast result is a null value. The underlying type of RuleParameter.Value is no longer an ExpandoObject. Utils.GetTypedObject is called in the constructor of RuleParameter which changes the type of the object to an anonymous runtime type.
Suggested Next Steps
Add a property to RuleParameter which preserves the original type and value of the Value property which is not change via Utils.GetTypedObject. (e.g. RuleProperty.OriginalValue). This will provide access to the RuleParameter input data in the same manner as the data was created.
This problem makes it difficult to safely access data from the RuleParameters (i.e. the input data) in the custom Action. I need to extract data from the RuleParameter that is optional. If I access the data as a dynamic, I cannot check to see if the optional property exists before access without exceptions.
I also attempted to create a new class, CustomRuleParameter, which inherits from RuleParaemter. I added a property, CustomRuleParameter.OriginalValue which preserves the original Value object. I then passed this object to RuleEngine.ExecuteAllRulesAsync. I was unable to cast the RuleParameter back to CustomRuleParameter in Actionbase.Run. The original RuleParameter is not preserved.

can you repeat this issue without creating a RuleParameter?

dynamic input1 = new ExpandoObject();
input1.count = 1;
var inputs = new RuleParameter[] { new ("input1", input1) };

var ret = await bre.ExecuteAllRulesAsync(workflow.WorkflowName, inputs, cancellationToken);

this worked as expected.  did you do something different?

the ExpandoObject is changed to DynamicClass.  The underlying nuget package for RulesEngine uses System.Linq.Dynamic.Core and they discussed, i think, this issue

This is a simpler demonstration of the problem:
dynamic input1 = new ExpandoObject();
input1.count = 1;
RuleParameter rp = new RuleParameter("data", input1);
ExpandoObject data = rp.Value as ExpandoObject;
//data is null here
The RuleParameter is used throughout the lifecycle of the workflow execution and passed back in Custom Actions.  I think the RuleParameter should preserve the original type so it can be cast back to the original type and accessed in the same way in the Custom Action. This could be done with an additional property.
Thank you for the DynamicClass suggestion! I prefer this to potential exceptions from accessing properties that don't exist.

i agree keeping the type as is.  i will see what i can do

The issue you are encountering revolves around the usage of the ExpandoObject and the way the RuleParameter class is handling dynamic objects. Specifically, the problem lies in the way RuleParameter stores and retrieves the dynamic objects, resulting in a loss of the expected type when casting back.
Detailed Breakdown

Dynamic Object and RuleParameter:
dynamic input1 = new ExpandoObject();
input1.count = 1;
RuleParameter rp = new RuleParameter("data", input1);

ExpandoObject data = rp.Value as ExpandoObject;
// data is null here

Here, you create a dynamic object input1 and assign it to a RuleParameter. Later, you try to cast the rp.Value back to ExpandoObject, but it's null. This happens because RuleParameter is transforming the ExpandoObject into a typed object, and when you try to cast it back, it fails.

RuleParameter Class:
public class RuleParameter
{
    public RuleParameter(string name, object value)
    {
        Value = Utils.GetTypedObject(value);
        Init(name, Value?.GetType());
    }
    // Other members and methods...
}

The constructor calls Utils.GetTypedObject(value), which transforms the ExpandoObject into a typed object using System.Dynamic.Linq.Core.

Utils.GetTypedObject Method:
public static object GetTypedObject(dynamic input)
{
    if (input is ExpandoObject)
    {
        Type type = CreateAbstractClassType(input);
        return CreateObject(type, input);
    }
    else
    {
        return input;
    }
}

This method checks if the input is an ExpandoObject and transforms it into a strongly-typed object using CreateAbstractClassType and CreateObject methods.

Transformation of ExpandoObject:

CreateAbstractClassType creates a type dynamically based on the properties of the ExpandoObject.
CreateObject creates an instance of that type and populates it with the values from the ExpandoObject.

Problem Summary
The core of the issue is that the RuleParameter class converts the ExpandoObject into a strongly-typed object during its initialization. This conversion makes it impossible to cast back to ExpandoObject later.
Suggested Solution
To address this issue, you could modify the RuleParameter class to preserve the original ExpandoObject along with the typed object. This way, you can access both the original dynamic object and the typed version when needed.
Here is an example modification:
public class RuleParameter
{
    public RuleParameter(string name, object value)
    {
        OriginalValue = value;
        Value = Utils.GetTypedObject(value);
        Init(name, Value?.GetType());
    }

    public Type Type { get; private set; }
    public string Name { get; private set; }
    public object Value { get; private set; }
    public object OriginalValue { get; private set; } // Preserve the original value
    public ParameterExpression ParameterExpression { get; private set; }

    private void Init(string name, Type type)
    {
        Name = name;
        Type = type ?? typeof(object);
        ParameterExpression = Expression.Parameter(Type, Name);
    }

    public static RuleParameter Create<T>(string name, T value)
    {
        var typedValue = Utils.GetTypedObject(value);
        var type = typedValue?.GetType() ?? typeof(T);
        return new RuleParameter(name, value); // Pass original value
    }
}

With this modification, you can access the original dynamic object:
dynamic input1 = new ExpandoObject();
input1.count = 1;
RuleParameter rp = new RuleParameter("data", input1);

ExpandoObject originalData = rp.OriginalValue as ExpandoObject;
// originalData will now hold the original ExpandoObject

This preserves the original ExpandoObject, allowing you to cast it back without losing the dynamic nature of the object.
But this approach could
Note: If the rules engine mutates the object Value, OriginalValue and Value may diverge.
We need to ensure that the rules engine does not mutate the Value object, otherwise, we need to consider additional synchronization logic if mutations are possible.
@Michaelcombs could you tell me a bit more about what you are thinking about when you want to access this object?

OR
@Michaelcombs
@RenanCarlosPereira
I created an extension method for type object which can convert back to ExpandoObject.  here is a summary of the methods that i would like to add to the associated PR
public static class RuleParameterExtensions
{
    /// <summary>
    /// Extension method that turns a dictionary of string and object to an ExpandoObject
    /// </summary>
    public static ExpandoObject ToExpando(this IDictionary<string, object> dictionary)
    {
        var expando = new ExpandoObject();
        var expandoDic = (IDictionary<string, object>)expando;

        // go through the items in the dictionary and copy over the key value pairs)
        foreach (var kvp in dictionary)
        {
            // if the value can also be turned into an ExpandoObject, then do it!
            if (kvp.Value is IDictionary<string, object>)
            {
                var expandoValue = ((IDictionary<string, object>)kvp.Value).ToExpando();
                expandoDic.Add(kvp.Key, expandoValue);
            }
            else if (kvp.Value is ICollection)
            {
                // iterate through the collection and convert any strin-object dictionaries
                // along the way into expando objects
                var itemList = new List<object>();
                foreach (var item in (ICollection)kvp.Value)
                {
                    if (item is IDictionary<string, object>)
                    {
                        var expandoItem = ((IDictionary<string, object>)item).ToExpando();
                        itemList.Add(expandoItem);
                    }
                    else
                    {
                        itemList.Add(item);
                    }
                }

                expandoDic.Add(kvp.Key, itemList);
            }
            else
            {
                expandoDic.Add(kvp);
            }
        }

        return expando;
    }

    public static ExpandoObject ToExpando(this object obj)
    {
        // Null-check
        Dictionary<string, object> expando = new Dictionary<string, object>();

        foreach (PropertyDescriptor property in TypeDescriptor.GetProperties(obj.GetType()))
        {
            expando.Add(property.Name, property.GetValue(obj));
        }

        return expando.ToExpando();
    }
}

both suggestions could be used.  i am going to see if the code can maintain the actual object as is instead of using one of the two suggestions.  regardless, one of our suggestions could work?

@RenanCarlosPereira
in reference to your question "could you tell me a bit more about what you are thinking about when you want to access this object?"

I route Mqtt JSON data payloads from sensors through rule engine workflows as ExpandoObjects via RuleParameters. I do not have control over the JSON format. There are many formats so I am not unloading the JSON into strongly typed objects.

I am using custom action classes. Upon successful triggering of a rule, the RuleParameters used during rule evaluation are passed back into the custom action via the ActionBase.Run method.

In the custom action I need to extract data from the RuleParameters, specifically a sensor id, to initiate subsequent processes. I would like to maintain consistent access to the data throughout the code. I often use extensions for ExpandoObject and JsonElement as well as validation utilities.

thanks @Michaelcombs
here's a PR, feel free to take a look at it #55.
Summary of Changes

Added OriginalValue Property:

Preserves the original ExpandoObject without converting its type.

Implemented TryGetPropertyValue Method:

Safely accesses properties, returning a boolean indicating success and setting the out parameter to the property value or null if not found.

Created Unit Tests:

Tests for TryGetPropertyValue behavior and ensuring OriginalValue is correctly set in the constructor.

Reason for Changes
The issue involved the RuleParameter class transforming ExpandoObject into a strongly-typed object, causing a loss of the expected type when casting back. The changes ensure that both the original dynamic object and the typed version are accessible, maintaining data integrity throughout the workflow execution.

@Michaelcombs
@RenanCarlosPereira has created a potential solution to your issue.  my solution is here IF anyone wants that added at a later date.

@Michaelcombs i am going to assume this solved your issue? if so, then i would like to close this issue

Yes. Thank you!


Support API server for China

In the Home Connect API documentation at https://api-docs.home-connect.com/general#introduction
It said:

API of physical home appliances
api.home-connect.com or
api.home-connect.cn - This domain has to be used if you want to create an application for China. In this case please enable Sync to China in the account settings to copy all clients to China.

But currently, there is no settings for me to change the API_HOST to the CN server.
I could login and use the plugin without any issue if I change the API_HOST from "https://api.home-connect.com" to "https://api.home-connect.cn" in the custom_components/home_connect_alt/const.py
It's better we could add an configuration like this:
api_host (optional - default = "https://api.home-connect.com")
or
api_host (optional - default = "global") - Supported values: "global", "cn"
Version of the custom_component
0.5.6
Configuration
home_connect_alt:
  client_id: '<my client id>'
  client_secret: '<my client secret'
  name_template: $appliance - $name
  language: 'zh-CN'

Debug log
There is no error if I change the API_HOST from "https://api.home-connect.com" to "https://api.home-connect.cn" in the custom_components/home_connect_alt/const.py

Done in 0.5.7 see the README for configuration instructions.


Test against JDK16 GA instead of EA

Thanks https://github.com/hibernate/hibernate-reactive/pull/720!

No problem #1!


Default launch command is too cumbersome

Policy and info

good first issue

Feature description
Currently, to use the tool gpt-engineer command has to be used. Although this can be resolved using an alias, would be nice to have a command such as gpte be available by default.
Can refer https://clig.dev/#naming for more details.
Motivation/Application
This feature will make it very user friendly to use the command. Having to type dash (-) in gpt-engineer command is very cumbersome.

Thanks for the suggestion! We are working on a vast refactoring of the project, so please submit a PR on the refactor branch. I suggest waiting until midweek as we are implementing Poetry for package and dependency management.

Okay, revisiting this now after having implemented Poetry in a PR on the refactor-poetry branch.  That branch would be the best place to implement this.

Is someone assigned to this? I think I can implement this. Studying the codebase right now.

Thanks for the contribution!On 4 Dec 2023, at 11:27, Rukshan J. Senanayaka @.***> wrote:
@captivus this is my first contribution here. Kindly let me know if anything is not correct.
#889
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.***>


Test bin.js

Shouldn't be too much work...

I would take this up.
On a side note, would you prefer nyc check-coverage --statements 100 --branches 100 --functions 100 --lines 100 :wink:

Yes please :+1:


Tabbed NavAids with differing stylesheets conflict with each other (visio)

Diagrams are fine individually but corrupt when shown together via tabs.

Simplest option is probably to deleting/creating diagram elements when switching between tabs.

simple.zip