Web - Workspace - Workspace chatroom is being visible on LHN when deleting a workspace

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Create a workspace
Delete the workspace

Expected Result:
No extra room should be visible on LHN after deleting a workspace
Actual Result:
An additional room becomes visible on LHN after deleting a workspace
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[x] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: v1.3.55-8
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/115492554/1c3752f9-f356-4183-a3cd-526e1c725293
https://github.com/Expensify/App/assets/115492554/152830dd-e025-4a1d-ac49-3105aae167d8
Expensify/Expensify Issue URL:
Issue reported by: @Nathan-Mulugeta
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1691744143149019
View all open jobs on GitHub

Hmm, it seems like at first the workspace chat isn't showing up (likely because they aren't on the beta?). But then it is showing up once archived.
I'm guessing this should be fixed by us removing the workspace chats beta. @Beamanator what do you think?

Hmm good question... We officially got the App PR to remove that beta Merged so maybe you can try again now on Main and see what happens?

Yes I think it is because the workspace chat room is now visible all the time.

Yeah makes sense. We were actively in the process of changing that behavior. Going to go ahead and close this out.


Edge weights of the k-nearest-neighbor graph

Hello Leland,
First: UMAP is amazing, thank you for making the code publicly available and putting so much effort in what is going on there!
If I understood the "read the docs" correctly, UMAP effectively computes a weighted k-nearest neighbor graph from the data. The edge weights to the k-nearest neighbors from a data point x_i consider the local metric around the point, which is done using the distance relative with respect to its closest neighbor. I was wondering if there is an explicit formula for computing the edge weights?
At https://www.math.upenn.edu/~jhansen/2018/05/04/UMAP/ they state, that the weights can be computed as
w_i(x_i, x_j) = exp(-(d(x_i, x_j) - r_i) / sigma_i),
where r_i is the distance to the closest neighbor and sigma_i is the diameter of the neighborhood. Is this formula correct? If yes, how one compute the edge weights for the low-dimensional representation, since we do not use neighbors, but rather the hyperparameter min_dist?
Also I did not quite understand how the family of curves 1/(1+ax^(2b)) relates to all this and I would really appreciate your help.
Cheers,
Katja

Yes, this fully answered my question.
Thanks a lot for the fast and helpful reply!!

is there a loss function thats minimized using gradient descent over here when constructing weighted knn graph


a question about random seed

Hi
I have a question about the function set_random_seed() in env.py.
The random.seed(seed) and np.random.seed(seed) only take effect once, don't they??
So how does the function set_random_seed() affect the whole  codebase ?
If I fix the random seed in env.py, does the RandomFlip only have one direction??

Yes they are only set once, and only needed to be set once.
https://en.wikipedia.org/wiki/Random_seed

thx very much~


Support user-defined selectors to ignore during drag/resize

Fixes #43.

Not including generated files for clarity.
I've also tried to prepare an example. However, a) using a sortable means including a 3rd-party library, which is not a very good idea; b) a nested grid  doesn't work (strange behaviour) and would be too remote from a real use case.

No worries, the changes are simple enough. Thanks!


cacert: fix certificate denylist

Motivation for this change
It's broken under Python 3, ironically due to the patch we're carrying.
Fix it, and add a "test" to make sure it at least builds.
Fixes #93230.
This also removes the includeEmail option, because it doesn't do anything.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

This will need a backport to 20.09, I think.

...and I'll need to retarget this at staging.

@ofborg eval
@ofborg build cacert cacert.tests

@ofborg eval
@ofborg build cacert cacert.tests

@lukegb welcome to the maintainers club for cacerts ;) Mind opening a PR with this change against staging-20.09?


Text view layer version

Replacement of #654
Part of #653

Thanks for reopening it on the correct branch! I'll just go ahead and merge it. It passed crate CIs already after all...


python wrapper does not work with s3

HKube micro-service
algorithm - python wrapper
Describe the bug
When using s3 the python wrapper is unable to connect to s3
The wrapper throws an error "unable to connect to http://<IP_ADDRESS>:9000"
Expected behavior
should connect to s3
Additional context
It seems that the URL in the wrapper config is read from the wrong environment variable
@tamir321 We should test Hkube using S3 and not just filesystem

fixed

tested on Rafael Network


Parse parameter decorators

Because Method Parameter Decorators is now a TC39 stage 0 proposal, I'd like to propose babylon to parse parameter decorators.
While the actual transform is still being debated, it would be great if babylon only parses the syntax and allows users to transform it with third-party plugins. One concrete use case is Angular 2's decorators.
https://phabricator.babeljs.io/T1301

This was auto-closed because this repo has been updated to include the Git history from the main Babel repo. It doesn't actually look like Github will let me re-open it? I can't speak to the validity of this PR, but it appears you'll need to rebase and open a new one.
The new force-pused master branch should be identical to the old one, so you should be able to use rebase --onto or cherry-pick to move your commit over.

@loganfsmyth Thanks, I'll cherry-pick and reopen it!


Firefox causes keyboard focus to break

Hyprland Version
3b657257ecb7628a12a4fe72e733a60f031bfec2
Bug or Regression?
Bug
Description
Seemingly at random using Firefox (and clicking?) causes the keyboard focus to disappear. I can no longer use the keyboard in any window, until I click in another window to move the focus.
Mouse focus keeps working, so without clicking I can move the mouse to any window and mouse focus moves with it, e.g. scroll is working. I have follow_mouse set to 1.
When using socat to view the output from .socket2.sock it outputs the activewindow events when moving the mouse over windows. When the keyboard focus is lost these events also stop.
Please let me know what info is needed for debugging or ask for any other information. Thanks is advance :)
How to reproduce
Open multiple windows side by side, including Firefox. Use Firefox for a bit, switch tabs, click around. After a short amount of time when moving the mouse over other windows the keyboard focus no longer updates.
Crash reports, logs, images, videos
No response

never seen this happen. What does socket2 print when that happens?

nothing at all :( the activewindow events that are normally there stop, and there are no other events or output generated at that moment. I did just notice that switching workspaces back and forth also restores normal behaviour.

I figured out that killing my eww bar makes the problem go away. Looking at eww there is this issue.
Im not quite sure why it started happening after updating Hyprland (I have not updated my eww config in a while and the issue exists since dec 2022), or why it only happens in some windows but it seems to be an eww problem, not a Hyprland problem.


Support IPv6 addresses in hostname completions

This was brought up in #1621. Currently the magic regex seems to not work with IPv6.

A quick followup:
@ezintz can you try adding :: to etc-host-ignores (something like the following) to filter out ipv6 addresses as see if that works?
zstyle ':prezto:module:completion:*:hosts' etc-host-ignores '<IP_ADDRESS>' '<IP_ADDRESS>' '::'


Fit into multiple images

Hi,
Thank you for sharing the code! Is it possible to fit the pretrained model into multiple images? The current demo fit the model into a single image of a face, but I have multiple views of the same person, and want to fit the model to them.

Sure, a potential solution is to optimize for each image in turns inside each optimizing iteration. You may modify "run_fit.py" to achieve it, and I supposed more iterations are required.


nestjs test failed due to unable to resolve dependencies  of the BullBoardFeatureModule?

Hi I am seeing the following error for a test case that imports a module which is using BullBoardModule.forFeature. and I am getting the follow error, does anyone have an idea of what could have caused this? thanks!
Integration Tests › service should be defined
Nest can't resolve dependencies of the BullBoardFeatureModule (ModuleRef, bull_board_queues, ?). Please make sure that the argument "bull_board_instance" at index [2] is available in the BullBoardFeatureModule context.

Potential solutions:
- Is BullBoardFeatureModule a valid NestJS module?
- If "bull_board_instance" is a provider, is it part of the current BullBoardFeatureModule?
- If "bull_board_instance" is exported from a separate @Module, is that module imported within BullBoardFeatureModule?
  @Module({
    imports: [ /* the Module containing "bull_board_instance" */ ]
  })

I'm having the same problem. How did you fix it?


ansible-runner files left in /tmp

playbook as well as extravars files remain in /tmp on the rundeck server after job executions

Duplicate of #258


[CSM-237] [WIP] Split Pos.Wallet.Web.Server.Methods.hs

Rejoice whose who were awaiting for this day!
As name says, Methods.hs was cut into pieces; to free space for appropriate names and to avoid cyclic deps I had to do some other changes, e.g. move ClientTypes to ClientTypes/Types, or split websockets-related logic into several modules as well.
Fashion picture with Pos.Wallet.Web content.

Daedalus acceptance tests pass ok.
~P.S. I pretty love how it came to my mind to perform second largest refactoring of wallet simultaneously with... first largest refactoring (#1274) and some others (like #1270) ~

niche si

Okay. I wanted to address such issues in next iteration, but those points you mentioned shouldn't harm

waiting for both #1274 & #1270 before merging this one

:raised_hands: :raised_hands:


[Feature Request] Mob leveling system

Every time I play MC with friends, we run into the same issue. It gets too easy. After a certain point, mobs do not pose a threat. Especially after stat increases and weapon/armor enhancements.
I'm not sure if this is possible to integrate into PlayerEx or if it would have to be an add-on, but my idea is this.
A leveling system for mobs. The higher it's level is, the more increased heath, damage,armor, and loot it has. Along with any other attributes that could be used to make them more "difficult".
Levels could either be randomly assigned at spawn OR it could be relative to the players level. Average level if multiplayer.

Hi there,
I completely understand where you're coming from, and I feel the same way. I'm aware of this particular suggestion, and hope that something will come of it. It is likely, however, that I will at some point begin working on a levelling system mod for mobs - details pending, albeit area-averaged player level as a predicate for mob difficulty would be ideal.
For now though, I am not actively working on something like this.
Thanks.

My bad I didn't realize I already put an issue in for this.
I may have found a mod that could implement this, I would greatly appreciate it if you could take a look at it, and tell me if it's possible or not
https://www.curseforge.com/minecraft/mc-mods/power-scale

I personally use 3 (or more) mods to boost mobs.
Farsighted : Mobs see you from further away.
Eldritch : Sometimes mob can have some properties, like "mini boss".
 You can also use time!
You can take look to "Dusk" mod, and "Bloodmoon" ;)

Its not just mob, its about the fact that you dont cap your leveling system makes you literally able to grind towards superman, there is no balance consideration at all.
Due to the fact that this is the single mod that so popular and also it is the one that can cause exploit to end game fun and server IMBA, suggest to implement below simple solutions:
1, significantly increase the expanse of xp to level up (i am talking about 10000x more expensive at least, you cant believe how sweaty some players are), and
2, cap the level to a maximum at 30,
3, staying at each level consume you more and more very expensive energy/xp/special food or sort of thing all the time, just like you need protein to maintain muscle, and you will need to consume gold to maintain supermanness...this forces you to build more and more farm automatic farm to maintain your skill, otherwise you get slowness or weakness or sort of thing, or even level down
4, the luck attribute is also too powerful, please just make it act like fortune III and plus and so on. Luck cause rare item to drop end up forcing people to just thrown those items into lava

Hi @bugescape ,
I appreciate your input; however, your simple solutions 1, 2 and 4 are already implemented and/or have a solution:

The level formula can be completely customised in the config.
The maximum level can be easily capped to any value using a datapack.
The luck attribute is a vanilla attribute, and the amount you accrue over the course of your game by levelling can be completely configured, or disabled entirely such that you do not gain anything in the luck attribute.

Regarding your third suggestion, and indeed your overall point, I reiterate what has been said previously - that a mob levelling system is needed, and it is only the lack of mobs being able to get stronger too that makes this mod unbalanced at times. There is also an argument to be made about other facets of the game that may currently become stale; namely, environmental damage such as lava, fire, or fall damage - but I think that is out of scope for this issue.
Tl;dr; it really is just about a mob levelling system.

Its not just mob, its about the fact that you dont cap your leveling system makes you literally able to grind towards superman, there is no balance consideration at all.
Due to the fact that this is the single mod that so popular and also it is the one that can cause exploit to end game fun and server IMBA, suggest to implement below simple solutions:
1, significantly increase the expanse of xp to level up (i am talking about 10000x more expensive at least, you cant believe how sweaty some players are), and
2, cap the level to a maximum at 30,
3, staying at each level consume you more and more very expensive energy/xp/special food or sort of thing all the time, just like you need protein to maintain muscle, and you will need to consume gold to maintain supermanness...this forces you to build more and more farm automatic farm to maintain your skill, otherwise you get slowness or weakness or sort of thing, or even level down
4, the luck attribute is also too powerful, please just make it act like fortune III and plus and so on. Luck cause rare item to drop end up forcing people to just thrown those items into lava

I am just curious cause my friend is using this mod on a new server. Does the Melee crit chance from luck make ANY attack have a percentage chance to crit?

Hi @Hokmoon,
it is any melee attack, regardless of jumping. That also means that without any melee crit chance, you cannot crit even when jumping.

Hi @Hokmoon, it is any melee attack, regardless of jumping. That also means that without any melee crit chance, you cannot crit even when jumping.

Thank you!

I don't think anything can be this about this on PlayerExs end, at least realistically. Mods like RpgDifficulty would have to be the ones to take ones PlayerEx level into account when spawning mobs. Is there an issue on their repo regarding playerex support ?

can you show how do you cap it using datapack?

can i cap it using datapack on server side only? because i am running a large scale server

Not sure how your proposition would help @Elekjid, you're still going to end up too powerful relative to the mobs around. I think you're thinking of the getting too OP from just XP issue (which is exacerbated with mob farms, my suggestion for this is to base level on achievements rather then pure XP).

just simply cap the level to level 50 why it is so hard to do? why cant you just provide the datapack? @Hokmoon

@CleverNucleus

please provide method to cap the leveling system

@emibanana You will have to be more specific. Do you want to set a maximum level that players cannot surpass? Or are you referring to the chunk-based experience system - in which case, cap how?

hi, would like to cap the player level to a allowed maximum value, it just says in your description that this can be done via datapack but we dont know how to make one to make affective on your mod

@emibanana Please see the wiki.


feat(png.py): Add optional args to PNGSaveOptions

Can now declare interlaced and compression when creating PNGSaveOptions object
Added stronger type hinting to ExportOptionsSaveForWeb in compliance with the latest Adobe scripting documentation
Added additional doc strings and removed one duplicate docstring (I think we usually have a docstring on the property itself but not the setter?)
Changed pre-commit-config to use flake8 github repository instead of gitlab, as gitlab started requesting additional authentication

So we have kind of an awkward situation here. Black prefers strings to use double quotations or ", while there is a pre-commit hook to change double quotes to single or '.
This is rather confusing haha

I went ahead and amended pre-commit to include a formatting hook with Black and removed the conflicting rule, let me know if this is acceptable or should be reversed :)


Can I use TagUI with NLP, ML models? Which JS framework to use

user query

Actually, I'm working with Tagui and I have some questions about it. Would you mind please answer the following : which framework JS should I use? can I use NLP, machine learning model.. with tagui?  I would appreciate your help. Thank you in advance.

You can raise questions on TagUI on the GitHub issues page so other users can learn and contribute - https://github.com/kelaberetiv/TagUI/issues
TagUI is based in JS but not Node, so no normal access to JS frameworks. It has integration with Python, you can check out more on the home page here - https://github.com/kelaberetiv/TagUI#python-integration
If you are a Python user, you can see TagUI for Python instead to code directly in Python and use the ML frameworks - https://github.com/tebelorg/TagUI-Python


support asdf.info output for custom tags

implement __asdf_traverse__ for costum weldx tags, see https://github.com/asdf-format/asdf/pull/1052

The traverse method needs to be implemented for the implementation classes, e.g. CSM and so forth, right?
Or is there a way to hide this asdf related detail somewhere in the asdf related code?

Yes that method is needed purely on the python side if I understand correctly
But the basic idea should also be helpful for https://github.com/BAMWelDX/weldx-widgets/issues/13, maybe we can combine these two in the future


Group join/leave events are not fired in Skype connector

As it stands, join/leave events aren't being fired for Skype-enabled bots in a group scenario.  This means that a bot has to wait to be explicitly messaged before it can send any welcome messages or "set the scene" for any group-specific scenarios that its' presence enables.

Thanks for the suggestion @gplumb. Closing this issue for now. The team is aware and it's under consideration. Thanks!


TAG CS Contributor ladder

In TAG CS repo,

There are "facilitators", "chairs", "members"
Some WGs only have faciliators, some have only chairs, some have only members

We should document what these mean somewhere.
Related: https://github.com/cncf/tag-contributor-strategy/issues/340

There are also "tech leads" we should look to define too.

@Riaankl
Related: https://github.com/cncf/toc/discussions/1205#discussioncomment-7899762

Another improvement here:

Let's remove the "interested parties" role in the WG charter docs
This is a legacy role, used when the WG was forming up


Support for vendor asset subfolders (Fixes #286)

Currently all assets are just dumped into fonts and images. However, multiple vendor packages can use different loading.gif files for example, which are being overridden by each other, so as a result only one of the packages will work as intended (fixes #286).
To solve this problem, first I have updated Webpack's loader-utils to give us the ability to change the result filename any way we want (https://github.com/webpack/loader-utils/pull/59), and with its help in this PR I propose generating a relatively logical folder structure for vendor assets starting from the name of the package, ignoring image, font and asset folders. For example:

node_modules/test/images/loading.gif => images/vendor/test/loading.gif
bower_components/awesome/assets/font/glyph/glyph.otf => fonts/vendor/awesome/glyph/glyph.otf

Looks good to me! Nice work.


chore: Move path_util dependency to util project

This is imported by many projects and pulling the older path.

Hi @ghislainbourgeois, this repo has a single GO file with a single function. Would it be better to move it to the util or config5g repo (which another tiny repo), or another "bigger" aux repo? What do you think?

I think so, I did not look too much in the code, where do you think this would fit better? The name seems to imply it is configuration related.

I think so, I did not look too much in the code, where do you think this would fit better? The name seems to imply it is configuration related.

Based on the name and what it does, I am thinking that util or config5g would be the most appropriate. However, I do not like the config5g too much because it is also a tiny repo. I personally prefer, the util repo.
If you would prefer, we can merge this PR and later think where to move this function. Please let me know how you would like to proceeed

I think merging this first would help. It would let us complete the move of path_util and archive that project first.


exporter-collector-grpc: missing protos directory in v0.11.0 npm distribution

What version of OpenTelemetry are you using?
v0.11.0
What version of Node are you using?
v12.18.3
What did you do?
After upgrade to v0.11.0, I tried to use the grpc exporter, and got the following error in log:
(node:21682) Warning: opentelemetry/proto/collector/trace/v1/trace_service.proto not found in any of the include paths /Users/amirblum/repos/aspecto-opentelemetry-js/node_modules/@opentelemetry/exporter-collector-grpc/build/protos
(node:21682) UnhandledPromiseRejectionWarning: Error: ENOENT: no such file or directory, open 'opentelemetry/proto/collector/trace/v1/trace_service.proto'

When I checked under the build directory of the npm distribution of @opentelemetry/exporter-collector-grpc, it is missing the protos folder.
I found the following npm script in package.json:
"protos:copy": "cpx protos/opentelemetry/**/*.* build/protos/opentelemetry". When building the project locally on my machine it does copy the protos folder to build directory, but they are not published to npm.
I think it's because they should be added under the "files" section in package.json:
  "files": [
    "build/src/**/*.js",
    "build/src/**/*.js.map",
    "build/src/**/*.d.ts",
    "build/src/**/*.proto",
    "doc",
    "LICENSE",
    "README.md"
  ],

If I copy the directory to my app node_modules under @opentelemetry/exporter-collector-grpc, everything works as expected

@blumamir Do you want to work on fixing this ?

@vmarchaud Yes I'll create a PR soon

@blumamir it will be the sameI have updated the title it is the same for proto

Can this be closed now?


equals should compare regexps by comparing .source and .flags

Hm or maybe the default .toString()

So, neither actually. RegExp flags are sorted when reserialized, so we should take that into account when comparing and not fail because of flag ordering.


blocking script in templates

There are a couple of toggle actions which should be moved to load inline with the defer option, currently they are barfed out mid page.

Can this be deferred to B2 in case?
I'd really like to have B1 out soonish. :angel:

Since they really don't have to be done at all, there is no problem waiting until a later date.

By chance, do you remember which one are?

LOL .. sorry no ... I'm sure they are script tags in the templates themselfs which should be moved to addinline calls.

I guess the usual :bug: :footprints: then?

I'll do some look at page outputs this weekend and see what may be misplaced still ... for all I can remember this might have been fixed along the way.

Bugs fixed?
That would be unusual. :stuck_out_tongue:


Markdownify list of supported operating systems

This uses GitHub-flavored Markdown to create the table, which lists the supported operating systems. When compared to the former image, this helps with screen readers, search engine optimization and also with maintenance of this code base.

Good improvement.

Thanks!

Closing this PR as documentation is no longer contained in this repository.

At the moment documentation is not maintained in this repository or on github.com. A mechanism for public feedback for documentation is planned.

I see. Thanks for the information. How is the process of providing feedback like this to the documentation if there is no mechanism currently in place?

If you take a look at https://docs.amd.com/bundle/ROCm-Release-Notes-v5.2/page/About_This_Document.html, there is a small feedback icon on the right side of the page. That is the current process to submit feedback.

As the change entered the documentation already, I will close this PR.

Awesome. Thanks for the guidance, @saadrahim!


CI: K8sFQDNTest Restart Cilium validate that FQDN is still working

/home/jenkins/workspace/Cilium-PR-Ginkgo-Tests-Validated/src/github.com/cilium/cilium/test/ginkgo-ext/scopes.go:408
"app2-cd69fd9f6-mtxhh" cannot curl to "http://world1.cilium.test"
Expected command: kubectl exec -n default app2-cd69fd9f6-mtxhh -- curl -s -D /dev/stderr --fail --connect-timeout 5 --max-time 8 http://world1.cilium.test -w "time-> DNS: '%{time_namelookup}(%{remote_ip})', Connect: '%{time_connect}',Transfer '%{time_starttransfer}', total '%{time_total}'"
To succeed, but it failed:
Exitcode: 28
Stdout:
 	 time-> DNS: '0.030538()', Connect: '0.000000',Transfer '0.000000', total '5.001671'
Stderr:
 	 command terminated with exit code 28

/home/jenkins/workspace/Cilium-PR-Ginkgo-Tests-Validated/src/github.com/cilium/cilium/test/k8sT/fqdn.go:150

38ca2f89_K8sFQDNTest_Restart_Cilium_validate_that_FQDN_is_still_working.zip
https://jenkins.cilium.io/job/Cilium-PR-Ginkgo-Tests-Validated/9927/testReport/junit/k8s-1/8/K8sFQDNTest_Restart_Cilium_validate_that_FQDN_is_still_working/

This one has been occurring a lot in the CI:
Builds that were kicked off from merged PRs:

5920
5930
5937

Builds that run every 2 hours against master:

2375

Marked this as high priority since we are hitting this frequently in the CI, and this will impact developer productivity / agility to merging.

@eloycoto said in the Cilium testing Slack channel that he has added debug logs to a PR which will help provide the root cause for this issue.

One more: https://jenkins.cilium.io/job/cilium-ginkgo/job/cilium/job/master/2398/testReport/junit/k8s-1/13/K8sFQDNTest_Restart_Cilium_validate_that_FQDN_is_still_working/

Added this new PR to be able to track what looks like a race on restart:
https://github.com/cilium/cilium/pull/7138/files

Another failure: https://jenkins.cilium.io/job/Ginkgo-CI-Tests-Pipeline/5950/

One more: https://jenkins.cilium.io/job/Ginkgo-CI-Tests-Pipeline/5961/testReport/junit/k8s-1/13/K8sPolicyTest_Namespaces_policies_Kubernetes_Network_Policy_by_namespace_selector/

And more: https://jenkins.cilium.io/job/Ginkgo-CI-Tests-Pipeline/5968/testReport/junit/k8s-1/13/K8sFQDNTest_Restart_Cilium_validate_that_FQDN_is_still_working/

@eloycoto can you please keep this issue updated w.r.t. what you did to debug this / what you think the cause is? it's helpful to have the status of what the timeline on the fix is, what the RCA is for future developers to debug, etc.

https://jenkins.cilium.io/job/Ginkgo-CI-Tests-Pipeline/5974/testReport/junit/k8s-1/8/K8sFQDNTest_Restart_Cilium_validate_that_FQDN_is_still_working/

https://jenkins.cilium.io/job/Ginkgo-CI-Tests-Pipeline/5981/

@ianvernon is a race on PolicyAdd AFAIK, I made a PR but I close due does not fix all the issues. Open a new draft PR https://github.com/cilium/cilium/pull/7183 let's see if I can get it merged in the following days.

I'll try to explain this a little bit, I had long discussion with @raybejjani around this.
The main issue is that in the RuleGen we keep a copy of the api.Rules this is
ok, but to update a Policy we need to call to PolicyAdd with this rules. The
main problem, this system is feeding also by Kubernetes CNP/KNP so the rule can
be updated, but the FQDN can overwrite the policy if the CNP does not finish.
I made this plantuml diagram to understand it better:

@startuml

participant "K8sWathcer" as K8s
participant "FQDN Proxy" as Proxy

K8s -> PolicyAdd: New Policy is added.
PolicyAdd -> PolicyRepo: Policy RULE A has been added.
== Pod Make a request ==
Proxy -> PolicyAdd: Rule A has been updated with new IP
PolicyAdd -> PolicyRepo: Policy RULE A has been added.

== User update the CNP ==
K8s -> PolicyAdd: New Policy is added RULEB.

== Pod Make a request ==
Proxy -> PolicyAdd: Rule A has been updated with new IP (Request ZZ)
hnote over PolicyAdd :This Proxy has the old Rules, because PolicyAdd from CNP is not finish

PolicyAdd -> PolicyRepo: Policy **RULE B** has been added.

PolicyAdd -> PolicyRepo: Policy **RULE A** has been added (Request ZZ).
hnote over PolicyAdd #FFAAAA: **NEW Policy has been added and CNP is not working correctly**.

@enduml

The main reason, atomic is hard because before doing the ToCIDR  allocations
FQDN need to be in place. Lock is expensive here, so it's not a easy fix that we
can add here.
I made a PR to avoid stopDNS, so it's only two operations. The next step that we
thought is related to the AddGeneratedRules try to lock in there, but this
locks the FQDN proxy, so things can be super weird with this situation.
Try to figure multiple solutions in this problem, but all has a big caveats and
I'm still don't know how to fix it.
Ray also mentioned to have a policyVersion in the PolicyAdd, this may works, but
it'll be hard on reconcile policies in case that K8sCNP updates the policy.
Sorry!

https://jenkins.cilium.io/job/cilium-ginkgo/job/cilium/job/master/2422/

https://jenkins.cilium.io/job/cilium-ginkgo/job/cilium/job/master/2432/testReport/junit/k8s-1/13/K8sFQDNTest_Restart_Cilium_validate_that_FQDN_is_still_working/

New diagram with the issue:

@startuml

participant K8s
participant DNS1
participant DNS2
participant PolicyAdd
participant policyRepo

-[#blue]> K8s: New CNP
K8s -[#blue]> PolicyAdd: Send rules to PolicyAdd
PolicyAdd -[#blue]> PolicyAdd: MarkToFQDNsRules
PolicyAdd -[#blue]> PolicyAdd: Populate local/in-function rule copy IPs from DNS Cache
PolicyAdd -[#blue]> PolicyAdd: Allocate IPs
PolicyAdd -[#blue]> policyRepo: lock
PolicyAdd -[#blue]> policyRepo: Delete old rules from repo
PolicyAdd -[#blue]> PolicyAdd: StopManageDNSName
PolicyAdd -[#blue]> PolicyAdd: Remove references to old rules
PolicyAdd -[#blue]> policyRepo: Add new rules
PolicyAdd -[#blue]> PolicyAdd: StartManageDNSName
PolicyAdd -[#blue]> policyRepo: unlock

== With multiple request ==

-[#gold]> K8s: New CNP
K8s -[#gold]> PolicyAdd: Send rules to PolicyAdd
DNS1 -[#green]> PolicyAdd: Send rules to PolicyAdd
PolicyAdd -[#gold]> PolicyAdd: MarkToFQDNsRules
PolicyAdd -[#gold]> PolicyAdd: Populate local/in-function rule copy IPs from DNS Cache
PolicyAdd -[#gold]> PolicyAdd: Allocate IPs
PolicyAdd -[#green]> PolicyAdd: MarkToFQDNsRules
PolicyAdd -[#green]> PolicyAdd: Populate local/in-function rule copy IPs from DNS Cache
PolicyAdd -[#green]> PolicyAdd: Allocate IPs
PolicyAdd -[#gold]> policyRepo: lock
PolicyAdd -[#gold]> policyRepo: Delete old rules from repo
PolicyAdd -[#gold]> PolicyAdd: StopManageDNSName
PolicyAdd -[#gold]> PolicyAdd: Remove references to old rules
PolicyAdd -[#gold]> policyRepo: Add new rules
PolicyAdd -[#gold]> PolicyAdd: StartManageDNSName
PolicyAdd -[#gold]> policyRepo: unlock
PolicyAdd -[#green]> policyRepo: lock
PolicyAdd -[#green]> policyRepo: Delete old rules from repo
PolicyAdd -[#green]> PolicyAdd: StopManageDNSName
PolicyAdd -[#green]> PolicyAdd: Remove references to old rules
PolicyAdd -[#green]> policyRepo: Add new rules
PolicyAdd -[#green]> PolicyAdd: StartManageDNSName
hnote over PolicyAdd #FFAAAA: **OLD Policy has been added and CNP is not working correctly something is lost**.
PolicyAdd -[#green]> policyRepo: unlock
@enduml

https://jenkins.cilium.io/job/cilium-master-K8s-all/169/

Removing needs/triage label as I believe that @eloycoto is actively working on a fix and has triaged the root cause at this point.

For reference, this is still occurring in CI,
https://jenkins.cilium.io/job/cilium-master-K8s-all/176/

Also in: https://jenkins.cilium.io/job/Cilium-PR-Ginkgo-Tests-Validated/1062

Latest master failure:
https://jenkins.cilium.io/job/cilium-ginkgo/job/cilium/job/master/2523/

Fixed!

Seems like we are hitting this again: https://jenkins.cilium.io/job/cilium-ginkgo/job/cilium/job/master/2924/

https://jenkins.cilium.io/job/Ginkgo-CI-Tests-Pipeline/7130/testReport/junit/Suite-k8s-1/14/K8sFQDNTest_Restart_Cilium_validate_that_FQDN_is_still_working/

Also still hitting in 1.5 branch: https://jenkins.cilium.io/view/Cilium-v1.5/job/cilium-v1.5-K8s-all/29/testReport/junit/Suite-k8s-1/13/K8sFQDNTest_Restart_Cilium_validate_that_FQDN_is_still_working/

We haven't observed this in months. Closing.


Update minitest dependency.

The development dependency for minitest is out of date and needs to be updated.

Fixed in 0.0.5


[Bug Report] UnknownHostException: discordapp.com: unknown error

Describe the bug
The app throws this exception sometimes ;
[08:30:01] [WARN] [WebSocketClient]: Got disconnected from WebSocket. Attempting to resume session
[08:30:03] [INFO] [JDA]: Successfully resumed Session!
[10:17:44] [INFO] [Startup]: Loaded config from ****.txt
[10:59:26] [ERROR] [Requester]: There was an exception while executing a REST request
java.net.UnknownHostException: discordapp.com: unknown error
        at java.net.Inet6AddressImpl.lookupAllHostAddr(Native Method)
        at java.net.InetAddress$2.lookupAllHostAddr(InetAddress.java:928)
        at java.net.InetAddress.getAddressesFromNameService(InetAddress.java:1323)
        at java.net.InetAddress.getAllByName0(InetAddress.java:1276)
        at java.net.InetAddress.getAllByName(InetAddress.java:1192)
        at java.net.InetAddress.getAllByName(InetAddress.java:1126)
        .....
        at net.dv8tion.jda.core.requests.Requester.execute(Requester.java:116)
        at net.dv8tion.jda.core.requests.ratelimit.BotRateLimiter$Bucket.run(BotRateLimiter.java:350)
        at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
        at java.util.concurrent.FutureTask.run(FutureTask.java:266)
        at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:180)
        at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:293)
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
        at java.lang.Thread.run(Thread.java:745)

This happened today, and it's the second time I've experienced it.
When this happens, the bot is unable to connect back to the discord server.
I couldn't identify if the bug happens when I lose internet (which I don't think as I can see in the logs that the app often reconnects to the web socket), or if it is indeed the host that is unreachable.
I'm running the bot on a Raspberry Pi 2, that relaunches the bot each time it reboots ; this works well.
To Reproduce
Run the bot for quite some time and observe when the bot can't reconnect the discord server anymore (if you have default VC it's easy to see when it is not there).
I don't know if it happens when internet is down or if it's when the host (discorpapp) has troubles.
Expected behavior
The app recovers from such an exception and reconnects back to the discord server
Debug Info
I've only access to the logs, the app was launched with nohup and I can see INFO/WARN/ERROR log levels. Or can I access the debug logs through nohup ?
I've used the bot quite a lot, I'm very satisfied with it, this is just a nitpick ;)
Thank you in advance !

This likely occurred either during a discord outage, or during an internet outage wherever the bot is being hosted. Either way, there is really no way to fix this with the current dependencies, but it may be resolved in a future update.


Implement house price regression example workflow

This example introduces regression workflow using Boston house pricing.

[x] Add feature scaling with min-max
[x] [Optional] Add hyper parameters such as regularization
[ ] [Optional] Add feature selection

While we discussed scaling features is important for online learning, I didn't scale features because of the precision accuracy.
Preprocessing conditions

All features
Top 4 correlated features: lstat, rm, ptratio, indus
Top 4 features with min-max rescaling

All features
Top 4 features
Top 4 with min-max

RMSE
13.03
7.83
20.29

MAE
11.24
6.18
17.87

@myui Could you have a look at this PR?

[ ] Explore appropriate eta0
[ ] Try with/without log scaling for features

With/without log1p scaling, eta0=0.5 should be good for this dataset. Will keep using log1p scaling for stability.
Top 4 features, add_bias, iter=100

RMSE
MAE
eta0

16.88
15.65
5

10.85
9.77
1

5.98
4.73
0.5

7.13
5.64
0.1

7.25
5.41
0.05

13.39
10.34
0.01

23.21
21.33
0.001

Top 4 features, add_bias, log1p scaling, iter=100

RMSE
MAE
eta0

9.61
8.75
5

127.42
121.36
1

5.99
4.43
0.5

10.38
7.55
0.1

11.07
8.03
0.05

20.37
18.16
0.01

24.15
22.44
0.001

It seems Hivemall's default regularization hyperparameter does too aggressive regularization for this dataset.
-reg no improves accuracy.
https://console.treasuredata.com/app/workflows/534499/sessions/3872588

After adding random shuffle, adding -reg no seems better than default reguralization method adagrad+rda.

eta0
adagrad -reg no
adagrad -reg rda

0.001
23.92
24.21

0.01
14.55
20.58

0.05
12.15
12.43

0.1
11.92
12.02

0.5
7.70
5.80

1
6.22
5.32

5
5.17
589.72

All comments are done and use -reg no for better accuracy.

LGTM 👍


Update brochure pipeline

Updates the brochure assets.
Update the appender to truly append to an existing document, not
simply making a copy with with extra pages.
Updated the brochure pipeline to include the appender spoke.

Keep it open.

Remy, I'm having trouble with my repo so here's the svg for brochure-v3-p1in case you want to test it, I'll try to fix my repo to do a pr tomorrow
brochure-v3-p1


data in all_members.csv appears unaligned

Not sure of the cause or combination of causes of this, perhaps in at least one instance something allowed a comma in a data field. Most entries look OK. Entries that need attention: 1261, 5249, 5296, 5297, 5298, 5299, 5308, 5336, 5345, 5353, 5359

This is caused by extra commas in some entry values. It can be mitigated by adding validation parameter that checks for commas


Different spacing between Input and FormItem

I have found different spacing between the label and inputs alone, and the one inside forms.
Here are the main differences:
Form item

    Username

  <input
    class="flex h-9 w-full rounded-md border border-input bg-transparent px-3 py-1 text-sm shadow-sm transition-colors file:border-0 file:bg-transparent file:text-sm file:font-medium placeholder:text-muted-foreground focus-visible:outline-none focus-visible:ring-1 focus-visible:ring-ring disabled:cursor-not-allowed disabled:opacity-50"
    placeholder="shadcn"
    id="test-item"
    aria-describedby="test-item-description"
    aria-invalid="false"
    name="username"
    value=""
  />

    This is your public display name.

Basic Input with label

    Email

  <input
    class="flex h-9 w-full rounded-md border border-input bg-transparent px-3 py-1 text-sm shadow-sm transition-colors file:border-0 file:bg-transparent file:text-sm file:font-medium placeholder:text-muted-foreground focus-visible:outline-none focus-visible:ring-1 focus-visible:ring-ring disabled:cursor-not-allowed disabled:opacity-50"
    id="email"
    placeholder="Email"
    type="email"
  />

This issue has been automatically closed because it received no activity for a while. If you think it was closed by accident, please leave a comment. Thank you.


Do not store a "date" field on data ingest

We should require the user to chose a date field, there's no point in storing an additional field with uncertain provenance.

Looks like this is something done by hand on current datasets, so can close


Truncated console output.

Your Windows build number:  (Type ver at a Windows Command Prompt)

Microsoft Windows [Version 10.0.15063]

What you're doing and what's happening:  (Copy&paste specific commands and their output, or include screen shots)

Large STDOUT output from commands that exceeds the size of the console gets truncated to show only the last page of output of that command. When scrolling upwards the previous output of that command is not displayed. E.g. say I run "apt search microsoft", after dumping all of this commands output on the console I can only view the last page of the output and nothing before that even if I scroll up.

What's wrong / what should be happening instead:

I was expecting to be able to view all of the command's output if I scroll up, but I could only view the last page of the output.

@Bazalia - I myself could not reporduce with "apt search microsoft";

But... what you said looks similar to #1984 (and maybe #2161), so... there might be a certian abnormal or unexpected thing on screen buffer, I'm afraid.

@Bazalia @sunjoong is right. What you're describing is a dupe of those issues, the fix should be coming to an Insider's build near you soon!


Integrate package:angel_websocket

This issue was originally created by @thosakwe here, before being automatically moved:
https://github.com/angel-dart-archive/eventsource/issues/2
The old approach was to handle SSE subscriptions by themselves; however, it would be much more powerful to handle them in the same way as websockets.
Angel's WebSocket library will soon have a more abstract WebSocketContext that you can extend manually, as well as an attach method that will come of use and allow us to attach an SSE subscription in AngelWebSocket's client queue.
Note that this is waiting on an upstream fix in package:angel_websocket.

@thosakwe commented:
Pseudo-code. Ideally users will just be able to:
var ws = app.container.make<AngelWebSocket>(); // Assuming you've already injected this
var publisher = new AngelEventSourcePublisher(ws);

app.get('/events', publisher.handleRequest);


Suggested changes for the "#27367" doc improvements

I've left some comments on your pull request: this pull request is a pull request for your pull request :-) I've tried applying the comments I gave you.
Could you have a look?

Good changes! Thanks!


[Bug fix]Changed to calculate based on the average coverage of the modules (tonerdo#346)

Fixes https://github.com/tonerdo/coverlet/issues/346
Minor changes to calculate Average (console's table) based on average from all projects. Im not sure if it is ok only to modify CalculateLineCoverage(Modules modules) functions.
Also a change in CoverageResult.cs just to keep same logic, because its switch-case (ThresholdStatistic.Average)  was working well (average based on average from all projects).

Diego can you add some tests here https://github.com/tonerdo/coverlet/blob/master/test/coverlet.core.tests/CoverageSummaryTests.cs?

Just a suggestion... could you use modules.Count instead of modules.Count()? since property already available to give the value. Linq Count() method do use property Count when type is of ICollection I believe.

@MarcoRossignoli I did review since I worked on this section last time. Let me know if you want to remove my comments. I am doing review first time in Github so I am not sure whether I did it right or messed up something.

@sasivishnu absolutely NOT!
This project is OSS every idea review discussion on code are welcome!
Feel free to comment everything!
We won't remove any comments if constructive!

@MarcoRossignoli Tests added.
@sasivishnu I refactored according your suggestions, also I change the aligment for numbers (just visual thing), let me knot if it is ok or if it add complexity in vane.

also I change the aligment for numbers (just visual thing), let me knot if it is ok or if it add complexity in vane.

Were there issues here?I don't think we should touch that code in this PR, better keep the focus on issue topic.
BTW can you attach screenshot with before/after to understand the difference?

also I change the aligment for numbers (just visual thing), let me knot if it is ok or if it add complexity in vane.

Were there issues here?I don't think we should touch that code in this PR, better keep the focus on issue topic.
BTW can you attach screenshot with before/after to understand the difference?

Yep, agree with @MarcoRossignoli here. No need to change any alignment as part of this PR. Please open new issue to discuss regarding your alignment proposal.

also I change the aligment for numbers (just visual thing), let me knot if it is ok or if it add complexity in vane.

Were there issues here?I don't think we should touch that code in this PR, better keep the focus on issue topic.
BTW can you attach screenshot with before/after to understand the difference?

There isnt a issue at all, it is just a visual aligment for number. It is not really important so I reverted the code.
Just: "My client asked me why number are aligned to left in CI report, ...I like that my clients value the use of tests"

LGTM

@tonerdo I merged this stale bug fix.
Feel free to revert if not in agreement.


Don't declare Message conformance, Proto[23]Message includes that.

No need to say all generated messages conform to SwiftProtobuf.Message as
SwiftProtobuf.Proto[23]Message both extend it, so it is already expressed.

I disagree.
A lot of folks seem to get started by first running their protos through the generator and then looking at the generated code.  Even though this is technically duplicative, I think it's important for documentation purposes.

A lot of folks seem to get started by first running their protos through the generator and then looking at the generated code. Even though this is technically duplicative, I think it's important for documentation purposes.

Taking this to its logical conclusion, doesn't that imply that any time someone conforms to a protocol, they should list all of its ancestor protocols as well?
Is it really asking too much to expect users to follow an inheritance chain once, the first time they look at some code?

When I realized this the other day, I went back to double check that Proto[23]Message were Messages, since listing it would seem to imply it was needed for some reason. To someone that knows the language, expressing something the language/type system already does is an indicator the author(s) doesn't realize what the code they've written already expresses.

When I realized this the other day, I went back to double check that Proto[23]Message were Messages

+1, I've had to do the same thing. This feels like it's sacrificing legibility for most users of the language in order to avoid a one-time learning opportunity on behalf of users with little Swift experience.

My original thinking was for Proto[23] to be mixin/marker protocols.  One way to do that would be the following:
 ///
-public protocol Proto2Message: Message {
+public protocol Proto2Message {
   var unknownFields: UnknownStorage { get set }

 ///
-public protocol Proto3Message: Message {
+public protocol Proto3Message {
 }

 /// Proto2 messages preserve unknown fields
-public extension Proto2Message {
+public extension Proto2Message where Self: Message {
     public mutating func decodeBinary(from bytes: UnsafePointer<UInt8>, count: Int, extensions: ExtensionSet?) throws {
         var decoder = BinaryDecoder(forReadingFrom: bytes, count: count, extensions: extensions)

 // Proto3 messages ignore unknown fields
-public extension Proto3Message {
+public extension Proto3Message where Self: Message {
     public mutating func decodeBinary(from bytes: UnsafePointer<UInt8>, count: Int, extensions: ExtensionSet?) throws {

I'm pretty sure that Thomas' change would encourage a lot of people to create variables of type Proto2Message when I would rather see them use Message.  But maybe that's not so bad.

I'm pretty sure that Thomas' change would encourage a lot of people to create variables of type Proto2Message when I would rather see them use Message. But maybe that's not so bad.

Yes, with protocols we can split like you suggest, but I'm not sure there is value, it feels like it ends up causing more questions: Why does't Proto2Message extend Message?  What would it mean to have a Proto3Message that is not a Message?
We're also only taking about the cases where a developer is writing code to act generically on Messages.  The vast majority of their code will be using concrete leaf classes because they want to get/set the fields.  The few cases I'd think they will want generic code, they likely will quickly realize they need Message if they really are dealing with both types of Messages.  Sorta like if they are writing generic code they will realize where they need to use ExtensibleMessage.
Anyway, not overly critical, we can let this sit while other things shake out.

After thinking about it some more, I agree.  (I was overthinking this.)  Let's merge Thomas' change and move on to other things...

Ok, merging.


redo-c: 0.2 -> 20200906

Includes fixes on job control

Motivation for this change
Update redo-c to latest version which fixes a problem in job control.
Things done

[X] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[X] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[X] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[X] Fits CONTRIBUTING.md.

Thanks for reviewing. Sorry, but I am not interested in such a patch, since it complicates the package definition and the overriding.


Service-card scale up when we hover it.

This pull request adds a scaling effect to the service cards when hovered over, enhancing user interactivity and drawing more attention to the services. The effect uses a smooth transition with the transform: scale(1.04) CSS property, giving a subtle but noticeable enlargement when a user hovers over each card. This helps improve the visual appeal and makes the page feel more dynamic.

Please assign this pull request to me

please assign this pull request to me

@anuragverma108  please look on to the merge request which I made

Resolve the conflicts in the mentioned files. Ensure you pull all the latest changes before pushing your feature/bug fixes to the main branch. After resolving the conflicts, please open a new PR for review.
Thank you!


Change Note to Info (Blue boxes)

What
Minor changes of some Note boxes to Info boxes
Why
To keep terminology consistent

LGTM!


Add region filter for cassandra config

What changed?
Added region filter while initializing Cassandra cluster as recommended from comments in this diff:
https://code.uberinternal.com/D4542141

Why?
Portability of cadence service asks to use region instead of the datacenter as a config.

How did you test it?
Will test this in staging before merging.

Potential risks
Service might be unable to connect to Cassandra host.

Coverage increased (+0.8%) to 68.48% when pulling d0755aaad67a60de0b07cbe09fb89756fa63463d on anish531213:aanish/addregionFilter into 6fcee79ea3a6be7e33dff3ab15cfe3f31eef4b89 on uber:master.


How to build?

I tried to build this project using the instructions from aws-c-common but got the following errors.  Is there documentation on how to build this project locally?
$ git clone https://github.com/awslabs/aws-c-io.git
...
$ mkdir aws-c-io-build
$ cd aws-c-io-build/
$ cmake ../aws-c-io
-- The C compiler identification is GNU 7.5.0
-- Check for working C compiler: /usr/bin/cc
-- Check for working C compiler: /usr/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
CMake Error at CMakeLists.txt:30 (include):
  include could not find load file:

    AwsCFlags

CMake Error at CMakeLists.txt:31 (include):
  include could not find load file:

    AwsCheckHeaders

CMake Error at CMakeLists.txt:32 (include):
  include could not find load file:

    AwsSharedLibSetup

CMake Error at CMakeLists.txt:33 (include):
  include could not find load file:

    AwsSanitizers

CMake Error at CMakeLists.txt:34 (include):
  include could not find load file:

    AwsFindPackage

CMake Error at CMakeLists.txt:159 (aws_use_package):
  Unknown CMake command "aws_use_package".
...

You need to build upstream dependencies first.
git clone git@github.com:awslabs/aws-c-common.git
mkdir aws-c-common-build
cd aws-c-common-build
cmake ../aws-c-common -DCMAKE_INSTALL_PREFIX=
make -j
then
git clone git@github.com:awslabs/aws-c-io.git
mkdir aws-c-io-build
cd aws-c-io-build
cmake ../aws-c-io -DCMAKE_INSTALL_PREFIX= -DCMAKE_PREFIX_PATH=
make -j

also, on unix systems you'll need to build s2n as well prior to building aws-c-io, for reference you could look at how we do python builds:
see the setup.py for github.com/awslabs/aws-crt-python

Thanks @JonathanHenson .  I've installed s2n following the instructions in the readme, then rebuilt aws-c-common using the CMAKE_INSTALL_PREFIX, and am now back to aws-c-io.  CMake is unable to find LibCryptoConfig.cmake, and it doesn't look like it's installed on my machine.  Is there another dependency I need?
$ cmake .. -DCMAKE_INSTALL_PREFIX=~/dev/shared-deps/ -DCMAKE_PREFIX_PATH=~/dev/shared-deps
CMake Error at /usr/share/cmake-3.10/Modules/CMakeFindDependencyMacro.cmake:48 (find_package):
  By not providing "FindLibCrypto.cmake" in CMAKE_MODULE_PATH this project
  has asked CMake to find a package configuration file provided by
  "LibCrypto", but CMake did not find one.

  Could not find a package configuration file provided by "LibCrypto" with
  any of the following names:

    LibCryptoConfig.cmake
    libcrypto-config.cmake

  Add the installation prefix of "LibCrypto" to CMAKE_PREFIX_PATH or set
  "LibCrypto_DIR" to a directory containing one of the above files.  If
  "LibCrypto" provides a separate development package or SDK, be sure it has
  been installed.
Call Stack (most recent call first):
  /home/ANT.AMAZON.COM/kggilmer/dev/repos/s2n/cmake/s2n-config.cmake:8 (find_dependency)
  /home/ANT.AMAZON.COM/kggilmer/dev/shared-deps/lib/cmake/AwsFindPackage.cmake:29 (find_package)
  CMakeLists.txt:159 (aws_use_package)

History:
$ git clone https://github.com/awslabs/s2n.git
$ cd s2n/
$ S2N_LIBCRYPTO=openssl-1.1.1 BUILD_S2N=true TESTS=integration GCC_VERSION=9
$ source codebuild/bin/s2n_setup_env.sh
$ codebuild/bin/s2n_install_test_dependencies.sh
$ cd ..
$ cd aws-c-common/build/
$ rm -Rf *
$ cmake .. -DCMAKE_INSTALL_PREFIX=~/dev/shared-deps/ -DCMAKE_PREFIX_PATH=~/dev/shared-deps
$ make -j 12
$ make install
$ cd ../aws-c-io/build/
$ cmake .. -DCMAKE_INSTALL_PREFIX=~/dev/shared-deps/ -DCMAKE_PREFIX_PATH=~/dev/shared-deps
$ export s2n_DIR=/home/ANT.AMAZON.COM/kggilmer/dev/repos/s2n/cmake/
$ cmake .. -DCMAKE_INSTALL_PREFIX=~/dev/shared-deps/ -DCMAKE_PREFIX_PATH=~/dev/shared-deps

Possibly related: https://github.com/aws/aws-iot-device-sdk-cpp-v2/issues/69

LIBCRYPTO_ROOT is not for anything using cmake

if s2n built, then libcrypto is installed, and the finder works.
You built s2n using the other build instructions, not the cmake build. Use Cmake. When you do so, you'll notice it can't find libcrypto. this is because the finder needs the header files.
You usually want something like:
sudo apt-get install libssl-dev
Also keep in mind, you'll use identical build instructions for s2n as we use for all other crt packages.

Could not find a package configuration file provided by "LibCrypto" with
any of the following names:
LibCryptoConfig.cmake
libcrypto-config.cmake

You also need aws-c-cal

Complete build instructions are now present in the README.


Remove 3.6 support

3.6 Ended (23 Dec 2021)
https://endoflife.date/python

Codecov Report

Merging #71 (be37db0) into master (c9ff903) will decrease coverage by 2.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #71      +/-   ##
==========================================
- Coverage   85.50%   83.47%   -2.03%
==========================================
  Files          17       17
  Lines         800      799       -1
==========================================
- Hits          684      667      -17
- Misses        116      132      +16

Flag
Coverage Δ

integration
?

unittest
83.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

api4jenkins/item.py
86.04% <0.00%> (-8.14%)
:arrow_down:

api4jenkins/job.py
84.61% <0.00%> (-3.85%)
:arrow_down:

api4jenkins/mix.py
91.89% <0.00%> (-2.71%)
:arrow_down:

api4jenkins/view.py
95.55% <0.00%> (-2.23%)
:arrow_down:

api4jenkins/build.py
93.05% <0.00%> (-1.47%)
:arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

thanks for fixing the issue :+1:


CLI: list members of an org shows nil

After creating a new user for an organization influx user create -o influxdata -u new_russ -p something and then listing the members of the org, i see a <nil> displayed in the username, even though it is returned when i print as json.
➜  influxdb git:(master) ✗ ./bin/darwin/influx org members list -n influxdata
ID			Name	User Type	Status
0673b0f2e540a000	<nil>	member		active
➜  influxdb git:(master) ✗
➜  influxdb git:(master) ✗ ./bin/darwin/influx org members list -n influxdata --json
[
	{
		"id": "0673b0f2e540a000",
		"name": "new_russ",
		"status": "active"
	}
]

might be related to something here: https://github.com/influxdata/influxdb/blob/master/cmd/influx/organization.go#L606

Hi
I am new to open source. If it is ok with you i would like to take this issue.


C examples in web-server repo?

Discussed in https://github.com/AxisCommunications/acap-native-sdk-examples/discussions/87

Originally posted by perp3rlabcom November  1, 2022
Hi all, according to the acap-native-sdk-examples/web-server/README.md, some C examples are supposed to be in the app/ folder but I can't find any. Any clues on what's up with that?

An documentation improvement was merged in #90


Use Out-File to specify ascii encoding.

By default the files are created with UTF-16 encoding. By specifying ascii, I can integrate posh-git and keychain this way:
https://github.com/lukebakken/dotfiles/blob/master/sh-init/bashrc#L41-L73

I like the encoding idea, but I'm not sure about the addition of -Force - at the moment, the command won't overwrite a read-only or hidden file, is there a reason to change that?

Shouldn't they always be overwritten?

Yeah, I can't actually think of any situation where clobbering isn't the right thing to do. Thanks!


How difficult to change this middleware for Quectel modem?

I understand this lib is intended to be used with SIMCOM modem. Is it easy to port to use with a different modem like quectel?

I was hoping that I could make it easily to port, but in reality this means change of all AT command calls, parsing of all responses. Only high-level API calls would be the same. In reality, work load would be almost the same as keeping and maintaining 2 libraries.
Almost all lwgsm_int.c file would need to be rewritten + header files for commands.

I actually succesfully worked with M66 modem with changing this library. I can fork it if you like.

Thanks all. @MaJerle That sounds a lot work to do.  But I guess there is no structure level thing need to be changed. right?
@yldzmuhammed, yes please, could you make it open source?


Modules "undefined" when error occurs

Imported modules that contain uncaught exceptions return "undefined", and the uncaught exception is not logged to the console. Very confusing.

See https://github.com/cujojs/curl/issues/289#issuecomment-163598541


Enable cloud logging in prod

Currently app internal log entries are not collected. We need to add a cloud logging sink to the logging mechanism on prod:
https://cloud.google.com/logging/docs/setup/python

Fixed in 68024eb


Teams Chat Send Message Support

It would be great to have a notify service for Teams Chats (not to be confused with posts in a channel) in addition to the existing email function. I have a couple automations that would be really handy to inject a message into a group chat for notification and discussion.

I’d need to think about this because it is way more complex than sending an email.  The danger is this becomes too big a data burden because currently there isn’t a way to just get the latest messages for a conversation.
If you can refine how you think this would work I’ll think on it some more.

It looks like the chat-list endpoint doesn't return messages so I'm not sure I follow you. https://learn.microsoft.com/en-us/graph/api/chat-list?view=graph-rest-1.0
Here is a sample where a product is doing similar and to get chat ID they can accept an ID or Name of the chat, maybe that would be helpful?: https://github.com/demisto/content/blob/dbc651f9c62d8a4c948e9f19f493ce9b3b17ed99/Packs/MicrosoftTeams/Integrations/MicrosoftTeams/MicrosoftTeams.py#L855

The O365 integration uses the python-O365 python module - https://github.com/O365/python-o365
This retrieves a list of chats via this api call - https://learn.microsoft.com/en-us/graph/api/chat-list?view=graph-rest-1.0&tabs=http - GET /me/chats
To get date/time of latest message, it loops through the list of chats using this call - https://learn.microsoft.com/en-us/graph/api/chat-list-messages?view=graph-rest-1.0&tabs=http - GET /me/chats/{chat-id}/messages
To send a message in the chat it will use this call - https://learn.microsoft.com/en-us/graph/api/chat-post-messages?view=graph-rest-1.0&tabs=http - POST /chats/{chat-id}/messages
So the send message requires 'chat-id', which is almost certainly not available within HA because currently the code only returns chat_id for latest message.
So potentially this could be done by you providing a unique chat name, which can then be used to as a filter to GET /me/chats (which is what the code you linked to does), or if you happen to know the chat_id (not sure if you can find it elsewhere), which can then be used to send a message.
What identifier do you wish to use, options seem to be a unique name or id sourced from outside the integration, because currently it doesn't provide a list of either.

Or if one-one, provide a username.
Basically the logic you linked to. But all need chat_id

But why does a list of messages need returned? You only need chat_id to send a message which doesn't need to know anything messages. I don't see where get_my_chats in python-O365 is iterating through messages, it appears to page through all chats but also looks to support a limit.
Could you expose a sensor that checks for the 10 most recent chats with get_my_chats and just lists name:type:id or something?
I also wouldn't be opposed to a requirement to obtain chat_id outside of the integration but not sure if you want that user experience. Maybe just point people to the Powershell documentation: https://learn.microsoft.com/en-us/powershell/module/microsoft.graph.teams/get-mguserchat?view=graph-powershell-1.0

Reading through the links I posted I don’t think I need to receive all messages, I could just provide users a list of chat_ids in the data attribute as you suggest

Been looking at this:

Easy to get a list of chat_ids, I've already got those anyway
There is no topic for a oneOnOne chat (to be used for a later retrieval of a chat_id) - The link you provided uses username to get chat_id, and no username is retrieved as part of the call I make, I get this content - https://learn.microsoft.com/en-us/graph/api/resources/chat?view=graph-rest-1.0#properties.
To get some sort of user identifier I need to retrieve that chat messages (the python library currently does not have get_chat, only chat_get_messages). This will then retrieve from_id and from_display_name, I imagine the from_id can then be used to do the create_chat to get the chat_id. However, it doesn't look that call is present in python-o365.
I might be able to get the members though (as you can tell I'm logging my thoughts...).
For group chats I should get the topic, which I could then display and re-retrieve chat_id using it.

And for a group chat it doesn't necessarily have a topic.

So in summary:

With an extra call once per reboot on a oneOnOne I can get a list of user_ids and names
With an extra call on every update (because members might change) for a group I can get a list of user_ids and names
I may be able to get topic on a call I'm already doing for a group, but I imagine this might be rare. So there is no real identifier for a group chat apart from list of members

Interested in your thoughts on this....

Interesting. Definitely disappointing Microsoft doesn't include some sort of meaningful identifier in list chats. Listing members with get_members seems like it should work to identify a chat though.
In my use of Teams, we almost always set a topic for group chats that will be used for any length of time. For ad-hoc chats with a group that wont hang around we might not but for the most part our groups have a topic.
So something like:
chats = get_my_chats
for each chat in chats -> get_members
Then a sensor with chat_id:[members]? Seems like that should work. Bonus use case is someone could trigger automation if group membership changes.

At the moment I have added a data attribute to the existing chat sensor which has an array of:

chat_id - the id we need
chat_type - oneOnOne/group/meeting
members - comma separated list of names
topic - if available on group chat

Need to add the service another day.

Currently limited by first 20 chats (strangely for my list of 4 chats, to only retrieved the first 2 when I set limit to 10). Re-retrieves member lists for non oneOnOne.


force podman-remote to use Dockerfile,

because in case Containerfile exists as well, it will use that instead

STONEBLD-1929

Maintainers will complete the following section

[ ] Commit messages are descriptive enough
[ ] Code coverage from testing does not decrease and new code is covered
[ ] Python type annotations added to new code
[ ] JSON/YAML configuration changes are updated in the relevant schema
[ ] Changes to metadata also update the documentation for the metadata
[ ] Pull request has a link to an osbs-docs PR for user documentation updates
[ ] New feature can be disabled from a configuration file

The failing CI is expected?

LGTM except the failing CI


Refactor Add and Get element operations

Currently we have a couple versions of AddElements - AddElements and AddElementsFromHdfs.
It would be neater to have an AddElements operation that takes a Source object, describing where the elements are coming from and how to add them to Gaffer.
Similar we have a few GetElements - e.g GetElements, GetJavaRDDOfAllElements, GetRDDOfElements, GetDataFrameOfElements.
It would be neater to have a GetElements operation that takes a Destination object, describing the format of the result.
This is a similar pattern to the Export operation with an Exporter. The Export operation could be deleted and these Exporters could be changed to work with GetElements and a Destination.

It's worth noting that some of these operations (specifically the Spark ones) can't be implemented by just taking the results of say GetElements and converting the results into the right format. This is because the way the results are obtained is important - the Spark ones should not be implemented by taking an iterable of results that goes to a client and then converting that into an RDD, the extraction of the results from Accumulo needs to be done in parallel taking into account locality, etc. This is why it uses the InputFormat behind the scenes.
Another example is that the operation that returns a Dataframe doesn't actually return any data - no data is returned until subsequent queries are executed against the dataframe.
The goal of this issue is good. But it's not as simple as just specifying an output destination/format for the results of the standard get operations.

Closing due to @gaffer01 's comments.


Translate old template into Jinja and connect it

The old template is available here. We should make sure that this has a Jinja template equivalent for our own website, and then we should connect it to the model.
I believe this should be the root directory of the website, i.e. bp.route('/') in blueprints/flagging.py. Discuss if you believe it should be something else.

I'm working on this :)

just submitted pull request tonight

Pull request accepted. I will keep this issue open because we still have a few more modifications we'll want to make to the template (more formal/modern stylizing and resizing the flags), but your work in getting the flags to render for each reach means we're more than half-way there. Excellent work Ben!

new pull request submitted


Update of Ultimate-Comparison-BASE

This is PR was automatically created because Ultimate-Comparisons-BASE was updated.
Pease incorporate this PR into this comparison.

Version 2.0.0 does not need that any more. See https://www.npmjs.com/package/ultimate-comparison. Therefore, I'm closing this PR.


FY2023Q2 Refresh

Update project files for all exercises
Update documentation links in slide decks (docs -> learn)

thanks... manually merged


Fix setting wght axis font bugs

Summary of the Pull Request

When deciding whether to call _AnalyzeFontFallback, also check if the user set any font axes
When setting the font weight value in the axis vector, check if the given font weight was anything other than Normal (needs discussion)

PR Checklist

[x] Closes #10852, #10853
[x] CLA signed. If not, go over here and sign the CLA
[ ] Tests added/passed
[ ] Documentation updated. If checked, please file a pull request on our docs repo and link it here: #xxx
[ ] Schema updated.
[x] I work here

Validation Steps Performed
Cannot repro those bugs anymore

Does this mean that we are technically constructing a font fallback every time there's a j or i in the input? That seems crazy. Can you verify if that's the case?

Does this mean that we are technically constructing a font fallback every time there's a j or i in the input?

Yes we do

gdi. Sounds like Chester's #10858

#10858 is very much inspired by the recent font features change. With the recent changes, the flag isEntireTextSimple is becoming less and less effective. If isEntireTextSimple is causing too much trouble, I'm quite OK with just removing it and investigate other ways like #9156 and #10858 .
Additionally, with the future atlas based renderer work, I assume the shaping & layout overhead will also be reduced. This one needs confirmation from @lhecker .

Why does the bold text attribute override the user specified font axes, but if the axes contain italic then they override the text attribute? Shouldn't either both lead to font axes to be overriden or both forcing text attributes to be overriden?

Shouldn't either both lead to font axes to be overridden or both forcing text attributes to be overridden?

So it turns out that the italic axis and the italic text attribute actually mean different things.
Setting the italic text attribute tells dwrite to find the font with italic in its header, whereas setting the italic axis tells dwrite to find the font which has an italic axis of variation and then set that axis' value. Setting the axis can be thought of as setting a restriction on the fonts dwrite will consider. As an example of how this works with Cascadia Code:
Set "ital": 1 - Dwrite gets Cascadia Curve
Text attribute is italic - Dwrite gets Cascadia Curve
Set "ital": 0, text attribute is italic - Dwrite gets Cascadia Code and slants it
This is the intended way it should work. So in short, the italic axis/attribute should not override each other even though bold does.

Since you changed how italic is handled, please make sure you mention that in the PR body. That body becomes the body of the commit, and it's important that we be able to look at history and learn both the what and the why.
Right now the title/body only mention wght.

@PankajBhojwani so, the value in Leonard's implementation is that you only have one vector. The other one is a span pointing to the subset of the vector that doesn't contain bold. Right now you just seem to have two vectors...

so, the value in Leonard's implementation is that you only have one vector. The other one is a span pointing to the subset of the vector that doesn't contain bold. Right now you just seem to have two vectors...

Ah, I get the difference now. Fixed


[release] adding 7.23.0~rc.3 and 6.23.0~rc.3 entries

What does this PR do?
Adds new release entries for RC.3.
NOTE: this is actually still pending some potential new tags from some of the relevant projects, so I will hold up merging this until we get feedback from other teams regarding status.
Motivation
New RC with new bugfixes.
Describe your test plan
Write there any instructions and details you may have to test your PR.

Unilaterally merging, no code changes.


Update Select after uikit update

There is a crutch that makes multiple Select in Partitions work as single Select with ability to unselect. This hack should be removed when unselect will be enabled in original uikit Select

Current version of single Select with explicit No consumer option seems just fine


feat(create): copyTemplates resolves with the copied files

This change allows me to do the following:
participants.forEach(name => {
  copyTemplates(
    'templates/**/*',
    path.resolve(process.cwd(), `./participants/${name}`),
    { participantName: name },
  ).then(files => {
    files.forEach(file => {
      writeFileToPathOnDisk(file.toPath, file.processed, {
        override: opts.override, // option that gets passed from my middleware, sometimes I need to override, sometimes I don't :P
        ask: false,
      });
    });
  });
});

Which is super awesome for generic purposes where I don't need a cli or the other cool features that, I assume, made you guys opt for a virtualFiles array that keeps the state in between functions.
Let me know if the test makes sense.. I couldn't really figure out a way to test copyTemplates without creating an actual template for testing. But perhaps you guys have a helper for this kinda thing?

Looks good to me, @daKmoR double check please?

not really the usecase it was built for 😅
but code looks fine so we can merge it 👍

thaaaankkksss 🤗


Get access to eliminated entries from nonlinear form gradient assembly

To solve for the discrete adjoint that corresponds to my nonlinear form, I need access to the rows/cols that were eliminated from the Jacobian when imposing essential boundary conditions on the Jacobian (so that I may correctly set the RHS for the adjoint problem).
Currently there is no way to get access to these entries, so I've written a simple draft implementation that would give access to the pGrad_e (just for the ParNonlinearForm) as an out-parameter in GetGradient in #2927. I'm not at all tied to the draft implementation (I just needed to get a working example going), so I'm hoping to discuss other potential approaches that might be more palatable to the MFEM team that will extend the nonlinear form API.
One thought I had was that I could use GetLocalGradient and parallel assemble that myself, and then eliminate the rows/cols myself. My concerns with that approach were that if/when the ParNonlinearForm supports GetGradient with DG interior face integrators, I would not automatically get that support.
Please let me know any thoughts you have!
Thanks,
Tucker

@tuckerbabcock if you copied the essential true DOFs from (Par)NonlinearForm::GetEssentialTrueDOFs() into an array, and then did something like:
// nlf here is our (Par)NonlinearForm
// Something like this to copy the dofs
Array<int> copied_ess_tdofs(nlf.GetEssentialTrueDOFs());
Array<int> zeros;
// Setting our essential true dofs to zero
nlf.SetEssentialTrueDOFs(zeros);
// get our gradient with everything preserved
auto gradient = nlf.GetGradient(x);
// do what we need with the essential boundary condition portion of things with the full gradient
// reset our essential BCs to what they used to be
nlf.SetEssentialTrueDOFs(copied_ess_tdofs);

Would this pattern work for your problem?

@rcarson3 thanks for the suggestion! I'm not sure why I didn't think to do that. That pattern seems to work great for me.
I'll go ahead and close this issue and that PR since that approach works.


Only default theme works

All themes don't work. Even the color of default theme seems not the same as your screenshot.

I tried to install the fonts. Still not working. Any idea? Thanks.

The colors of the theme can't be changed from OMZ, you have to apply whatever color scheme the theme uses to your terminal emulator. For example, agnoster uses solarized dark

Not only the color. Here is my screenshot:

I installed the Powerline patched fonts.

You have to also tell the terminal emulator to use one of the Powerline fonts. Anyhow, the powerline font issue is a recurring theme on OMZ, you might find the solution on one of the several issues posted here about this.


Change event that doesn't conform to type

The component forwards change events from its input. Those events don't conform to the change event type definition.
Repro
Steps to reproduce the problem:

Add a change handler that uses e.detail.type, which according the documentation should exist
Click on the multiselect's input field
Type in some characters
Blur
The input's change event gets emitted. e.detail is undefined and you get an error.

You're confusing two types of change events. The component emits synthetic change events whenever the selected options list changes (i.e. items are added/removed). This one has a event.detail.type payload. It also forwards DOM change events from the input node. This one does not have a event.detail.type payload.
Maybe the docs could be clearer on this point. PRs welcome!

Yup, we had coded based on the docs and every once in a while would get exceptions that didn't make sense. I had to look at the source code to figure out how detail can be undefined, and once that was clear it was easy to reproduce and handle the input change events differently.


Dep upgrades

Just some routine updates to Ruby, Rails and Yarnfile. Tests and type checks pass.

Coverage remained the same at 87.597% when pulling 1b4d17e9c3ba671fd494538e0863081f97149a5e on RickCarlino:dep_upgrades into fc6708c61b2bd5916c78adc7ba86e125175deb84 on FarmBot:staging.