LOG Spam

so much, cant post it coz it is so much, unknown recipe category thing

If it's about all the Unknown recipe category: farmersdelight:... lines added only at the start of the game (or the server), it will be fixed to the next release.
I add your issue to the milestone of the next release, thanks for the report 👍.

Is that problem relate to REI?

It's not a problem with REI. There is some custom recipe type in Farmer's Delight, one for cooking in cookin pot, one for cutting in cutting board and the category of these recipes is not known by Minecraft. I should add new one and register it to the Minecraft.

I have this too for 1.18.2 , could you fix this for this awesome version too pls

yeah up this, need fix for 1.18.2 too hehehe


Is this available as npm or bower module?

This is a great framework and well implemented as React components! Would love to try it out.
A couple of questions:

Will this be available via npm or bower module?
What is the licensing model ?

Hi vasya10!
Essence will be available soon as an npm package. (that is a couple of days)
About the licensing model, it was updated.

Thanks for the quick response!

Hi @vasya10 ,
Just published the NPM Package for React-Essence, so here you go:
Install:
npm install react-essence@latest --save

Usage:

Import / Require

import { Btn, BtnItem, Icon, Block, Text } from 'react-essence';

React-Essence components example

<Block type='div' classes={'brick brick-6'}>

	<Text type='h2' classes={"e-display-1 e-text-blue-700"}>Some title</Text>
	<Block type='div' classes={'e-text-grey-400 e-caption'}>
		<Text>Some text</Text>
	</Block>

	<Block type='div' classes={'brick brick-6 e-text-right e-padding-top-15'}>
		<BtnItem
			classes={'raised e-background-pink-A200'}
			onClick={this.yourActionOnClick}
			label='Button 1'/>

		<BtnItem
			classes={'raised e-background-pink-A200'}
			onClick={this.yourActionOnClick}
			label='Button 2'/>
	</Block>
</Block>


Fix issues with displaying network names and counts

Yeah, so, I really have no explanation for this one...
Let's say I was trying to create as many bugs as possible in the fewest lines of code.  Yeah.  That's it.

:+1:


fix NullPointException in HBaseBasedAuditRepository.listEventsV2

In debug mode, the audit page reports a NullPointException

@zyyBjtu , thanks for PR. Can you please create a Apache JIRA with the details and attach link to PR.

Sorry, I just saw the message。You can use this link to access Apache JIRA.
https://issues.apache.org/jira/browse/ATLAS-3923
------------------ 原始邮件 ------------------
发件人: "Sarath<EMAIL_ADDRESS>发送时间: 2020年8月25日(星期二) 凌晨0:18
收件人<EMAIL_ADDRESS>抄送<EMAIL_ADDRESS><EMAIL_ADDRESS>主题: Re: [apache/atlas] fix NullPointException in HBaseBasedAuditRepository.listEventsV2 (#107)
@zyyBjtu , thanks for PR. Can you please create a Apache JIRA with the details and attach link to PR.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.


Is it possible to override the Rate Limter dependency ?

What is the expected way of overriding the dependency for the rate limiter from the tests? Any example would be appreciated

Also looking forward to a solution ... how are we supposed to test our endpoints when rate-limiting is active?
In my case, I have the following test-file:
from fastapi.testclient import TestClient
from app.misc import normalize_phone_number
from app.database.models.user import User
from app.misc import get_db
from app.services.otp import store_otp_for_user
from app.main import app

client = TestClient(app)

def test_register_new_user(clear_database):
  clear_database()
  phone_number = "+4915202551672"
  response = client.post(
    "/users/register",
    json={
      "name": "Test User",
      "phone_number": phone_number
    }
  )

  assert response.status_code == 201
  assert response.json()["id"] == 1
  assert response.json()["name"] == "Test User"
  assert response.json()["phone_number"] == normalize_phone_number(phone_number)
  assert response.json()["verified"] == False

  # get the user from the db
  session = next(get_db())
  user = session.query(User).filter(User.id == 1).first()
  assert len(user.otps) == 1

Using pytest for testing, results in the following error:
FAILED tests/test_user_registration.py::test_register_new_user - Exception: You must call FastAPILimiter.init in startup event of fastapi!

As far as I know, the startup event is not being called by the TestClient?

I have managed to do so by modifying the RateLimiter class:
class CustomRateLimiter(RateLimiter):
    def __hash__(self) -> int:
        return hash(f"limiter-{hash(self.CUSTOM_ID_VALUE)}")

    def __eq__(self, other: object) -> bool:
        if isinstance(other, CustomRateLimiter):
            return self.CUSTOM_ID_VALUE == other.CUSTOM_ID_VALUE
        return False

Then use app.dependency_overrides[CustomRateLimiter(xxx)] = lambda: True, where xxx is the exact same setting as in the endpoint for which you want to override the RateLimiter dependency (in the case of lambda: True it basically disables the rate limit).
Source: https://github.com/tiangolo/fastapi/issues/2795#issuecomment-819476279

I have managed to do so by modifying the RateLimiter class:
class CustomRateLimiter(RateLimiter):
    def __hash__(self) -> int:
        return hash(f"limiter-{hash(self.CUSTOM_ID_VALUE)}")

    def __eq__(self, other: object) -> bool:
        if isinstance(other, CustomRateLimiter):
            return self.CUSTOM_ID_VALUE == other.CUSTOM_ID_VALUE
        return False

Then use app.dependency_overrides[CustomRateLimiter(xxx)] = lambda: True, where xxx is the exact same setting as in the endpoint for which you want to override the RateLimiter dependency (in the case of lambda: True it basically disables the rate limit).
Source: fastapi/fastapi#2795 (comment)

Yeah this solution seems to work fine, thanks!

I have managed to do so by modifying the RateLimiter class:
class CustomRateLimiter(RateLimiter):
    def __hash__(self) -> int:
        return hash(f"limiter-{hash(self.CUSTOM_ID_VALUE)}")

    def __eq__(self, other: object) -> bool:
        if isinstance(other, CustomRateLimiter):
            return self.CUSTOM_ID_VALUE == other.CUSTOM_ID_VALUE
        return False

Then use app.dependency_overrides[CustomRateLimiter(xxx)] = lambda: True, where xxx is the exact same setting as in the endpoint for which you want to override the RateLimiter dependency (in the case of lambda: True it basically disables the rate limit).
Source: fastapi/fastapi#2795 (comment)

FIxes pytest issues, but for my implementation, where I've seperated GET and PUT,etc., rate limit values, my fastapi app applies the GET timer to non-GET endpoints. Some overlap in the hash by redis or something.


Eliminate JSON structs

There are some JSON structs in the codebase that make things difficult to handle both on the backend and frontend. We should convert all relevant structs to protobuf format. These are the ones I know of at the moment:

Result and BuildInfo in ci/results.go
message Review in ag.proto: string review = 4; // JSON encoded grading criteria
Score in kit/score is now proto, but is still printed as JSON - we can avoid printing if we implement a gRPC server for collecting scores.
Assignment is in ag.proto, but we also parse assignment.yml files via another struct. Can this be avoided too somehow? Should not impact the database schema, unless this would require changing the Assignment struct. This is also related to #418.

These things also impact the database schema.
@0xf8f8ff Please tell if there is a problem with doing this??

I think this has largely been resolved by #466 and #384 and others. The only remaining part is the assignment.yml stuff which already has an open issue.


Add flatpak support

Hi,
I thought to do this like pacman, by listing directories under /var/lib/flatpak/app and /var/lib/flatpak/runtime
I tried that but me and C rarely give working results :(
Moreover there is the problem of flatpak "installations", which allows installing apps to other folders according to config files in /etc/flatpak/installations.d/...

I'm still contemplating how I want to support package numbers for different package numbers, an issue made more difficult by the fact that I only have pacman installed on my machine (making it harder to test out ideas).


ci: add Fossa CLI workflow

Adds the fossa cli workflow.

@tiagolobocastro I see two openebs in fossa, openebs and OpenEBS you might want to remove the latter.


Massive Refactor

Right now there's only minimal testing in place, but I wanted to give you a chance to start looking through the refactored code. There's a good deal left to do, like refactor renter and host, but I did my best to make it so at least the wallet and the miner were working.
The state code has been cleaned up quite a bit, a lot of data structures removed or refactored. The core has been made essentially useless though I'm going to need some of the tests so I've kept some of the files around temporarily.
More to come.

77 files changed is definitely my record.  4000 line diff probably is too.

What is siad/walletDir? If it's a dir, why does git think it's a binary file?

I was thinking wallet could be a dir, with one file for each set of addresses. But I think that's premature so I'll rename it back to walletFile


New Employee pre-onboarding site Template

Describe the issue
A clear and concise description of what the issue is.
Unfortunately your site provisioning at least partially failed!
Expected behavior
A clear and concise description of what you expected to happen.
Creation of New Employee pre-onboarding site template into SP.
Screenshots
If applicable, add screenshots to help explain your problem.
Details (please complete the following information):

PnP Correlation ID: None provided.
Reference Template: [please provide the URL of the template in the Look book site. It should be something like: https://lookbook.microsoft.com/details/8fefcc9a-7ca4-457f-bd10-acee3ae63b63
Primary language of the target tenant: UK British
Are you using a Tenant Global Admin account to provision the template: Yes

Additional context

Hi,
Thanks for using the Look Book site. Unfortunately, without any actual detail about the provisioning (PnP Correlation ID, or tenant name, etc.) we cannot investigate the issue further. Could you please try to provision the solution again and eventually look for the exception you will get by email? In the exception there should also be the PnP Correlation ID. Thanks for your cooperation.

Hi,
No PnP Correlation ID or email is provided when trying to provision the solution.


Add button accessibility

@pshihn here's a PR for making the wired-button accessible. Can you have a look? This was way more difficult than I thought 😁
I ran into several issues because I didn't really understand how to use lit-element:

not sure where the accessibility attributes should actually go, I added them to the div in the shadow dom. I noticed that if I add them directly on the wired-button element they wouldn't have any effect.
not sure how to get the innerHTML of the wired-button element to set it as aria-label, so I added it in the _didRender method, because there I had access to the innerHTML.
is it ok if I add the keydown event listener in the constructor?

Thank you!

I've added a wiki page with details on setting up the dev environment. That would be useful: https://github.com/wiredjs/wired-elements/wiki/Dev-Environment

@pshihn great, thanks for helping me set up the dev environment, it works now 👍 I have a small issue with tabIndex, I wrote a comment on it, I'm still trying to figure out what's going on.

done @pshihn :) I also removed the outline: none in the css, so that focus is visible.

Thanks a lot @RalucaNicola  I learned something about accessibility going through this with you.

thanks a lot for your help, I hope I can do the next components all by myself :)


Add search

Add search feature for events page

https://github.com/TrashMob-eco/TrashMob/assets/116043159/7931dec7-6102-429e-a723-535f55f2de76


Add field values.experimental to API

@luksa: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_sail-operator_main
6c080e96e00083171d33f1d384242ef05d7ee6b0
link
true
/test lint

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

/cherry-pick release-0.1

@dgn: #264 failed to apply on top of branch "release-0.1":
Applying: Add field values.experimental to API
Using index info to reconstruct a base tree...
M	api/v1alpha1/values_types.gen.go
M	api/v1alpha1/zz_generated.deepcopy.go
M	bundle/manifests/operator.istio.io_istiorevisions.yaml
M	bundle/manifests/operator.istio.io_istios.yaml
M	chart/crds/operator.istio.io_istiorevisions.yaml
M	chart/crds/operator.istio.io_istios.yaml
A	docs/api-reference/operator.istio.io.md
M	hack/api_transformer/main.go
M	hack/api_transformer/transform.yaml
Falling back to patching base and 3-way merge...
Auto-merging hack/api_transformer/transform.yaml
CONFLICT (content): Merge conflict in hack/api_transformer/transform.yaml
Auto-merging hack/api_transformer/main.go
CONFLICT (content): Merge conflict in hack/api_transformer/main.go
CONFLICT (modify/delete): docs/api-reference/operator.istio.io.md deleted in HEAD and modified in Add field values.experimental to API. Version Add field values.experimental to API of docs/api-reference/operator.istio.io.md left in tree.
Auto-merging chart/crds/operator.istio.io_istios.yaml
Auto-merging chart/crds/operator.istio.io_istiorevisions.yaml
Auto-merging bundle/manifests/operator.istio.io_istios.yaml
Auto-merging bundle/manifests/operator.istio.io_istiorevisions.yaml
Auto-merging api/v1alpha1/zz_generated.deepcopy.go
Auto-merging api/v1alpha1/values_types.gen.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Add field values.experimental to API
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-0.1

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dgn: new issue created for failed cherrypick: #266

In response to this:

/cherry-pick release-0.1

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dgn: #264 failed to apply on top of branch "release-0.1":
Applying: Add field values.experimental to API
Using index info to reconstruct a base tree...
M	api/v1alpha1/values_types.gen.go
M	api/v1alpha1/zz_generated.deepcopy.go
M	bundle/manifests/operator.istio.io_istiorevisions.yaml
M	bundle/manifests/operator.istio.io_istios.yaml
M	chart/crds/operator.istio.io_istiorevisions.yaml
M	chart/crds/operator.istio.io_istios.yaml
A	docs/api-reference/operator.istio.io.md
M	hack/api_transformer/main.go
M	hack/api_transformer/transform.yaml
Falling back to patching base and 3-way merge...
Auto-merging hack/api_transformer/transform.yaml
CONFLICT (content): Merge conflict in hack/api_transformer/transform.yaml
Auto-merging hack/api_transformer/main.go
CONFLICT (content): Merge conflict in hack/api_transformer/main.go
CONFLICT (modify/delete): docs/api-reference/operator.istio.io.md deleted in HEAD and modified in Add field values.experimental to API. Version Add field values.experimental to API of docs/api-reference/operator.istio.io.md left in tree.
Auto-merging chart/crds/operator.istio.io_istios.yaml
Auto-merging chart/crds/operator.istio.io_istiorevisions.yaml
Auto-merging bundle/manifests/operator.istio.io_istios.yaml
Auto-merging bundle/manifests/operator.istio.io_istiorevisions.yaml
Auto-merging api/v1alpha1/zz_generated.deepcopy.go
Auto-merging api/v1alpha1/values_types.gen.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Add field values.experimental to API
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-0.1

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dgn: new issue created for failed cherrypick: #267

In response to this:

/cherry-pick release-0.1

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.


Warm CI (azp) repository caches for pull requests

Currently we use a cache key to determine whether to re/use an azp cache for bazel repository cache
This benefits postsubmit quite a lot as the cache key is rarely blown and postsubmit gets the cache and doesnt need to upload any new cache
Pull requests otoh do not get this benefit - with the exception of re-running ci for a pull request (where it has previously succeeded)
The reason for this is due to the way azp "scopes" caches
For example (on the same pipeline) you might run CI for main and it will both use an existing cache and write the cache if successful in the main branch scope
In this scenario a pull request will prefer to use the main cache (where main is the target branch) as it higher scoped, but if it cant it will use and write a cache for its own branch). This is basically what we want.
The reason we dont get this benefit is that postsubmit runs on a different pipeline, and nothing runs CI for main in presubmit
Consequently, every new PR has no higher-scoped cache available and always creates its own.
Iiuc then we a possible workaround is warming the "main" cache in presubmit to let PRs use that (eg daily) - a better more complex solution would be to have postsubmit trigger this whenever the cache is actually blown
For now i will experiment with this theory by triggering manually, but if its correct, then i think we can speed up CI a lot.

see here for related discussion https://github.com/microsoft/azure-pipelines-tasks/issues/12901

relevant docs https://learn.microsoft.com/en-us/azure/devops/pipelines/release/caching?view=azure-devops#cache-isolation-and-security

warming the cache appears to work:
Getting a pipeline cache artifact with one of the following fingerprints:
Fingerprint: `format|7LmKddsibHuWyj7cATL/gFhvpAcbjYJABQ9+eaj6h3s=|t4aDH6YQ6elEOB2qVB7mMnewAJPcg+QfryGTglf7wT4=`
There is a cache hit: `format|7LmKddsibHuWyj7cATL/gFhvpAcbjYJABQ9+eaj6h3s=|t4aDH6YQ6elEOB2qVB7mMnewAJPcg+QfryGTglf7wT4=`
Used scope: 5;4684fb3d-0389-4e0b-8251-221942316e06;refs/heads/main;envoyproxy/envo

https://dev.azure.com/cncf/envoy/_build/results?buildId=130488&view=logs&j=55bc2ab9-36c1-5ab8-58a6-8c258728eeff&t=0202f152-2735-54e0-4297-c9b62e85c3ac&l=90

this is actually quite a big issue as it has a clusterfck effect - when all of the jobs start running without caches they compete for more resources and slow each other down a lot further
with a healthy cache most azp PR runs are now down to ~1h20m - but without this becomes completely unpredictable, and a function of contention with other runs

this seems to ~work now - i have added automation to trigger a CI run on presubmit
it didnt work until now - not sure why - but it just triggered https://dev.azure.com/cncf/envoy/_build/results?buildId=131558&view=results
so ill close this - it might need some tweaking


chore(circleci): Setup CI

:tada: This PR is included in version 1.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Document state contract.

Document why would we write separate contract classes for completely separate stories.

Should be part of #49.

Should be part of #49.


Installer not downloading text_2.pt, can't use bark-gui.

The latest version installer is always stuck at downloading text_2.pt model from huggingface.

If i close it and download the model myself to put it in the model folder of bark GUI and then try to run bark GUI, i get an error:

I suppose after downloading the model the installer is supposed to do more things but since i close it because it's stuck there, i end with a non-working bark-gui.
Is there any solution to this?

I had the same issue. Just in case for those who will end in the future, you can get those files from here : https://huggingface.co/suno/bark/tree/main


outdated jetty version leads to SSL_ERROR_NO_CYPHER_OVERLAP

In the pom there is a version of jetty which is already EOL (https://wiki.eclipse.org/Jetty/Howto/CipherSuites)
If I replace the webapp with a new version (e.g. 9.4.35.v20201120) I get the following error when starting jetty.

I'm trying to use the example of the Canvas app on https://developer.salesforce.com/docs/atlas.en-us.platform_connect.meta/platform_connect/quick_start_run_the_app_locally.htm. At the point "Run the web App locally" I get the error message "SSL_ERROR_NO_CYPHER_OVERLAP".

Yeah, the same is happening with me too. But do you get the  "SSL_ERROR_NO_CYPHER_OVERLAP" message when navigating to https://localhost:8443/examples/hello-world/index.jsp ? In my case,the webapp stops after giving the message in the screenshot.

I get the error msg when navigating to https://localhost:8443/examples/hello-world/index.jsp. I get the error msg in firefox.
In chrome I get the msg ERR_SSL_PROTOCOL_ERROR
Starting webapp looks good to me (with the version(7.6.0.v20120127) of jetty from repository):

I come across this when using the older jetty version.


FEAT: Improve antenna array processing and plotting

Minor improvements to plotting and functionality to support array phase excitations for beam-steering in HFSS.

@SMoraisAnsys After debugging, I found that with the new decorator, the plot is opened in the unit test, but until the user do not close it, the script/test is alive forever. We need to have two options, check a matplotlib option to allow going ahead with the script when show=True, or like I did, do not test the show=True case. We can discuss it later.
@dcrawforAtAnsys

@dcrawforAtAnsys Can we merge?


Double tapping doesn't work on some iOS devices

See thread here: https://forum.playcanvas.com/t/double-tap-issue-ios/13245
On this project with some iOS devcies, this doesn't work unless the user triple taps: https://forum.playcanvas.com/t/double-tap-issue-ios/13245
I haven't been able to reproduce this on a borrow iOS device yet but it seems to be related to model and iOS version.
I think it's related to a non-standard browser feature on Safari where the user can double tap too zoom. If I use preventDefault() on the original browser touch event as done here: https://playcanv.as/p/DzCHGrZP/ it works fine (PR to expose it to the public API: https://github.com/playcanvas/engine/pull/2096)
We could also fix this potentially with the CSS property touch-action set to to manipulation (see https://developer.mozilla.org/en-US/docs/Web/CSS/touch-action and https://stackoverflow.com/questions/59732074/disable-double-tap-zoom-on-safari-ios-13)
I would like to test this but don't have a device that shows this issue.
This could be pretty important as it means for some games (those that require timing and rapid tapping), some inputs from the user could consumed or delayed by the browser.

PR merged to expose original touch event and preventDefault fixes the issue.


[TT-9483] Added 3wa validation helper methods

@downeyfe thanks for having a look, I had to push some more changes to comply with the language's convention.


Modify DASH manifest BaseURL through Shaka interface

Wondering if there's a way to dynamically modify the  element of a dash manifest file through Shaka's API?

When you say "dynamically modify" the element, do you mean modify it before parsing, or modify it while playing?
If you mean the former, a response filter could be used. These filters are called after the download is complete but before it is passed to the manifest parser, so you could use that to modify the manifest as you wish.
If you mean the latter, you could still use a response filter and make the mpd's type attribute be "dynamic", so that the manifest parser will periodically re-download the manifest. That way you can use the filter to change it during runtime. You could also use a custom scheme plugin that forwards to the normal http/s plugin the first time and returns a cached result after that, so that you don't need to actually download the manifest multiple times. Whether this will work as intended depends on what kind of changes you intend to make, though; for instance, if you want to change the timescale during runtime or something weird like that, I doubt that would work properly.

If you want to modify <BaseURL> specifically, you only need a request filter to change the URIs of segment requests.  No need to modify the manifest at all.
Does this help?

@joeyparrish I have a question for you about using request filters. I'm looking to dynamically update the manfiestUri for live streaming. I'm pretty new to http streaming so there are probably some gaps in my understanding.
manifestUri = www.someurl1.com;
var player = new shaka.Player(video);
player.load(manifestUri).then(function() {
    console.log('The video has now been loaded!');
  }).catch(onError);

Then every 10 seconds my manifestUri changes to something else. How would I go about setting up a request filter to change the URI? I'm doing this in react, so I plan to have a componentWillReceiveProps() function where the manifestUri will be updated. Is this where requestFilter comes in or am I completely missing the point?

Here's an example:
player.getNetworkingEngine().registerRequestFilter(function(type, request) {
  if (type != shaka.net.NetworkingEngine.RequestType.MANIFEST) {
    return;  // ignore non-manifest requests
  }

  // Look for one URI and change it to something else.
  if (request.uris[0] == 'foo') {
    request.uris[0] = 'bar';
  }
});

If you want more detail, I recommend reading the tutorial on license server authentication: https://shaka-player-demo.appspot.com/docs/api/tutorial-license-server-auth.html
It goes into detail about various things you may want to do in changing requests.  Although it is focused on authentication and LICENSE requests, the concepts can be applied universally.  It also discusses asynchronous filters, which would allow you to asynchronously compute changes if needed.
Does this help?

@joeyparrish Thanks for the reply, and yes it does help. I had just stumbled onto that tutorial after I made the comment.
So the request.uris[0] will seamlessly transition to the new uri without re-rendering the entire player? I don't have an environment to play around with shaka at the moment or else I would give this a go.

Correct.  You are essentially changing the URI of the request before we make it.
The DASH parser is creating the request structure based on the original URI of the manifest (given to player.load()), plus any redirects at the HTTP level (HTTP 302) or DASH level (Location element).  Your filter gets to inspect and/or edit any part of that before it goes out on the actual network.

Ok that makes sense. I get that the requestFilter is like an event listener on the requests going out.
But how would I manually force registerRequestFilter to execute when I have a new manifestUri? I assume it's not by player.load(newManifestUri), right?

You don't manually force it to execute at all.  It will be executed on every single network request that occurs after you register it.  The registration persists, even when you make subsequent load() calls.  To remove a filter, you would use unregisterRequestFilter() or clearAllRequestFilters().
If you want to change the URIs of manifest requests (requests to get the initial manifest or to update it in the case of live streams), you can look for type == RequestType.MANIFEST.  If you want to change the URIs of segments, you can look for type == RequestType.SEGMENT.
I think I might have gotten confused looking at the history this morning, so I showed you an example of changing manifest URIs instead of segment URIs.  Looking at the history again, I think you segment URIs might be what you really want to modify.  Is that correct?

@joeyparrish I'm pretty sure I want to modify the manifest URIs, but I'll describe my problem in more detail just to be clear, you might know more than I.
I am playing a live stream with constantly changing source urls. Typically (from what I understand) a live stream will have one url, but will constantly grab new chunks from the server via the same url. But I can't be using chunks via the same url, I need new manifest urls every 10-15 seconds. So I believe I'm just playing 10-15 second videos after each other.
So in my code I need to determine when the manifestUri changes and then feed it to the shakaPlayer. I am pretty much manually changing the manifest Uri on the fly. There will only be 1 segment per manifest, so type should never equal RequestType.SEGMENT in my case.
I have the shaka player set up now, and I'm struggling to see the purpose of the registerRequestFilter if I am forcing the manifestUri to change every 10 seconds. It seems like just doing player.load(newManifestUri) does the trick, but I don't want to just load a brand new video, I want to keep the previously loaded video accessible in the player (similar to how segments work).

If you want to change the manifest URI every 10 seconds, here are your options as I see them:

Call load(newManifestUri), which will treat the new URI like a completely different, unrelated piece of content.  This is probably not what you want.
Put a <Location> element in the manifest which contains the URI to use for the next manifest update, and a minimumUpdatePeriod attribute of "PT10S" (10 seconds in XML duration format).  Every 10 seconds, Shaka will update the manifest from the location in the most recent manifest's <Location> element.  This requires cooperation server-side and control of the manifest contents, and only works for DASH.
Use a request filter to modify the manifest URI before the request is made.  This will work without complete manifest control and will also work for HLS.  In DASH, though, you still need a minimumUpdatePeriod attribute of "PT10S" for Shaka to update the manifest at that interval.

Does this help?

@joeyparrish Thanks again for the response.
I definitely do not want #1, HLS is required (so no #2), looks like I will have to push forward with #3.
However, I still don't quite understand how a request filter will achieve the desired result. I'm not sure if you're familiar with React or not, but I have a react component that is fetching the manifestUri, which is in turn feeding it to the video player.
Once the manifestUri changes, I have to feed it to the video player. To feed the new manifestUri to shaka-player, I would do player.load(newManifestUri), which would then execute the requestFilter where the requestType is MANIFEST, right?
But once I change that uris[0] to the new manifest (which I currently don't know how to get scope of inside the requestFilter), it will just load a new video and not have any record of the previous piece of content, right?
I must be missing something of how the requestFilter works.

No, I'm sorry, I'm not familiar with React.
I have a few more clarifying questions:
When you have manifestUri1, and later you want to load manifestUri2, how are these pieces of content related?  Is one an extension of the other (more segments listed)?
I would expect that for live streaming, the updated version would be an extension of the previous one, but it is an important distinction for me to give you the right advice.

@joeyparrish
I guess React isn't really important in this case, just the fact that I have something giving the video updated manifestUris.
I am told that they are completely separate manifests. manifestUri2 is not just manifestUri with extra segments appended, they are entirely separate segments.

In the case that your manifests are unrelated, you just want to call player.load() with the new manifest.  The player will unload what was already playing and load the new thing.  This is not how live streaming works, for the record.
If that solves your problem, you can disregard the rest of the advice here, which was based on the misapprehension that you wanted to change the manifest URI during an update of a typical live stream manifest.

@joeyparrish
I have just clarified with someone and I was mistaken. manifestUri2 is merely an extension of manifestUri1.

Okay, then here's how this work for a live stream.
player.load(manifestUri) triggers an initial manifest request.  After that, on a timer, the manifest parser will request updates to the manifest.  This is where your request filter comes in.
Every request gets filtered through all request filters.  Your filter can modify any request it wants before the request hits the network.  So you can change the manifest URI before each update it fetched.
There are two ways to do this:

Your react component gets new URIs on its own schedule, however it does that.  It then caches the most recent URI.  When you filter fires, it sets request.uris[0] = mostRecentCachedUriFromReact.
When your filter fires, it starts an asynchronous process to get the URI it should use for the manifest.  Your filter returns a Promise, which you later resolve after you have modified the request with a fresh URI.

Because your filter is called on all requests, you should look for MANIFEST requests specifically:
player.getNetworkingEngine().registerRequestFilter(function(type, request) {
  if (type != shaka.net.NetworkingEngine.RequestType.MANIFEST) {
    return;  // ignore non-manifest requests
  }

  if (mostRecentCachedUriFromReact) {
    request.uris[0] = mostRecentCachedUriFromReact;
  }
});

Or, the async version where you stop the request, calculate/fetch a manifest URI, then modify the request and continue:
player.getNetworkingEngine().registerRequestFilter(function(type, request) {
  if (type != shaka.net.NetworkingEngine.RequestType.MANIFEST) {
    return;  // ignore non-manifest requests
  }

  return goFigureOutTheNewManifestUri.then(function(newUri) {
    request.uris[0] = newUri;
  });
});

To answer your questions from earlier:

To feed the new manifestUri to shaka-player, I would do player.load(newManifestUri), which would then execute the requestFilter where the requestType is MANIFEST, right?

No.  load() tears down everything the player was already doing (if anything), and sets up playback for a new piece of content.  The request filter is triggered for every request, period.  At least one of those will be a MANIFEST type request, assuming you register the filter before the player requests the manifest.  It suffices to register the filter before calling load().  It is also worth noting that calling load() a second time will not wipe out any existing filters.  Filters persist across multiple calls to load().

But once I change that uris[0] to the new manifest (which I currently don't know how to get scope of inside the requestFilter), it will just load a new video and not have any record of the previous piece of content, right?

No, it's the opposite.  That would be true of calling load() again, but not a request filter.  A request filter is just giving your application a chance to inspect and/or edit a request before it actually happens.  It doesn't affect anything but that manifest request.
Does this help?

@joeyparrish
I'm definitely coming off as slow, I apologize. I greatly appreciate the write up here, but I think most of our discussion could have been simplified if I were more clear about what I was confused about.
I was under the impression that the only times the RequestType will equal MANIFEST is when the user manually alters the manifestUri. I get that RequestType equals SEGMENT every time it's time to load a new segment, but I don't understand when Request will actually equal MANIFEST.
I had pretty much the same code as below set up with my own player, but I never saw the RequestType equal MANIFEST unless i manually did a player.load() with a new manifestUri. My react component fetches the new manifestUri on its own, but then I somehow need to get inside of the requestFilter to set the request.uris[0] = newManifest. I can't call player.load() without tearing everything down, so I don't know how to get inside the requestFilter to set the request. Does my question make sense?
player.getNetworkingEngine().registerRequestFilter(function(type, request) {
  if (type != shaka.net.NetworkingEngine.RequestType.MANIFEST) {
    return;  // ignore non-manifest requests
  }

  if (mostRecentCachedUriFromReact) {
    request.uris[0] = mostRecentCachedUriFromReact;
  }
});

I was under the impression that the only times the RequestType will equal MANIFEST is when the user manually alters the manifestUri. I get that RequestType equals SEGMENT every time it's time to load a new segment, but I don't understand when Request will actually equal MANIFEST.

That is not true.  Live manifests have to be periodically updated, which means we will make subsequent MANIFEST requests.  For VOD, we would only request the manifest once.  In fact, there is no API for the user to manually alter the manifest URI, because this is not typically required.  We are still unclear on why you would want to do this in the first place.

I had pretty much the same code as below set up with my own player, but I never saw the RequestType equal MANIFEST unless i manually did a player.load() with a new manifestUri.

Did you register the filter before the first call to load()?  If you register the filter after calling load(), it would be too late to intercept the initial manifest request.
Is the content live or VOD?  (Check player.isLive() or send us a sample URI to test.)  VOD content does not need to update the manifest.  If your content looks like VOD, but you're trying to hack it so that it "updates" and acts more like live, then you should stop what you are doing and build a proper live, HLS event, or DASH IPR stream instead.

My react component fetches the new manifestUri on its own, but then I somehow need to get inside of the requestFilter to set the request.uris[0] = newManifest. I can't call player.load() without tearing everything down, so I don't know how to get inside the requestFilter to set the request.

Here's an example using a timer to compute a new URI.  The timer has no direct interaction with the request filter, but they both reference a common variable.  You can use a global, or attach something to window, or attach something to a namespace both pieces of code know about.  It doesn't technically matter where you store it.
// These could easily live anywhere else that both our
// manifest computation and request filter can access.
let nextManifestUri;
let counter = 0;

function computeNextManifestUri() {
  counter++;
  nextManifestUri = '/foo/manifest/' + counter + '.mpd';
}

// Compute the first URI.
computeNextManifestUri();
// Load the content.
player.load(nextManifestUri);
// Update the manifest URI every 10 s.
setTimer(computeNextManifestUri, 10000);
// Manifest requests always go to the most recently computed URI.
player.getNetworkingEngine().registerRequestFilter(function(type, request) {
  if (type == shaka.net.NetworkingEngine.RequestType.MANIFEST) {
    request.uris[0] = nextManifestUri;
  }
});

Ok this clears a lot up for me. I was testing with a link I found online that was claiming to be a live stream, but it seems like it was a VOD then, I'm not sure. I haven't tested any players with the actual live manifests that my services team are providing because they're not ready yet, but I am just being told what is required of me on the front end.
To get the new manifestUri I need to make an server call so instead of having my react component feed the shaka player a new manifest, maybe I'll just use the async version you mentioned above. Every time a new chunk is appended to the manifest, the manifestUri changes, so I'll follow the code below and hopefully that will work for me.
player.getNetworkingEngine().registerRequestFilter(function(type, request) {
  if (type != shaka.net.NetworkingEngine.RequestType.MANIFEST) {
    return;  // ignore non-manifest requests
  }

  return getManifestServiceCall.then(function(newUri) {
    request.uris[0] = newUri;
  });
});

So conceptually, supposed the initial manifestUri has only 1 segment in it. When it gets to the end of the segment it will trigger the requestFilter if I'm not mistaken, but will the RequestType be MANIFEST or SEGMENT? I don't have anything to test with at the moment or else I'd try it.

So conceptually, supposed the initial manifestUri has only 1 segment in it. When it gets to the end of the segment it will trigger the requestFilter if I'm not mistaken, but will the RequestType be MANIFEST or SEGMENT?

No, the manifest request has nothing to do with the number of segments in the manifest or the playback position.  It's based on a timer.  In DASH, this interval is controlled by the minimumUpdatePeriod attribute.  In HLS, it's based on the minimum of the EXT-X-TARGETDURATION tags.
So if your live manifest has 1 segment in it, that would be a bad time to start playback.  In DASH, playback should always be offset from the live edge by the amount of the suggestedPresentationDelay attribute.  In HLS, playback should always be offset from the live edge by 3 segments.  These features of DASH and HLS are meant to keep playback from running off the edge if there is some delay on the server side or in fetching an update.

@joeyparrish
Awesome, thanks for the explanation. This has been hugely helpful and I appreciate you taking the time to explain these concepts to me. Cheers.

Happy to help.  I'm going to go ahead and close the issue now.  If you need more help, just let us know and we can open it again.


Tagged logging?

How do you set this up if you want your logs to be tagged by default without using a block?

To add tags per thread without a block:
http://www.rubydoc.info/gems/semantic_logger/SemanticLogger#push_tags-class_method
Then to remove added tags:
http://www.rubydoc.info/gems/semantic_logger/SemanticLogger#pop_tags-class_method
Or if you want to add tags to every rails web request use the rails mechanism configured using config.log_tags. For example:
config.log_tags = [ :remote_ip ]

I tried that but I still can't see the tags. I'm trying to setup the logger to output similar to this example where it's outputting [jbloggs].
https://rocketjob.github.io/semantic_logger/rails.html

Were you able to get it working?


gh-183 Standardise use of Collections

Mainly applies to the REST API module. For example in IGraphConfigurationService we return a List of filter functions, but a Set of operations. They should both return the same type - a Set probably makes the most sense in this case.

Modified IGraphConfigurationService to make consistent use of Java Collections.  Namely, instances of List were replaced with Set.  I did not see any other instances of this in the REST API module.
Ran mvn clean package and all tests passed.  No other validation was performed.  If additional validation is needed, please advise.

Hi @nickwallen,
The changes look great - thanks for tidying the collections up. Before we can accept your pull request, we will need you to agree to our OSS Contributor License. Once you have read through them there is a link at the bottom to send an email to confirm. After we have received the email I will add you to our Contributors team and then I can merge your changes in.
Thanks!

Sorry to be a pain, but please could you change your pull request to merge into our develop branch? I have updated our wiki page on pull requests to make this clearer.

I changed the base to 'develop'.  Let me know if anything else needs addressed.


Exclude options when parsing files through stdin

The exclude rules are ignored if files are parsed through stdin with a given --stdin-filename.

Closed by #1342.


Compiling failes when importing a package that has subpath exports

Describe the bug
When importing a package that uses subpath modules (https://nodejs.org/api/packages.html#packages_subpath_patterns) compilation fails.
For example this package utilizes subpath exports to map exports under /dist to the root folder. https://github.com/Inrixia/helpers.ts/blob/d63d092960c48d46c42f652d091a5e405db5e70d/package.json
This works fine when using tsc and in other projects. But fails when attempting to build with react-scripts, logging the full error suggests this is due to webpack not supporting or following the subpath definitions in the package.json...

Did you try recovering your dependencies?
Yes, this is unrelated.
Which terms did you search for in User Guide?
npm submodules, npm subpaths, create-react subpath cannot import, package.json subpaths not working in react...
Environment
Environment Info:

  current version of create-react-app: 4.0.3
  running from C:\Users\Inrix\AppData\Local\npm-cache\_npx\c67e74de0542c87c\node_modules\create-react-app

  System:
    OS: Windows 10 10.0.19042
    CPU: (32) x64 AMD Ryzen 9 3950X 16-Core Processor
  Binaries:
    Node: 16.8.0 - C:\Program Files\nodejs\node.EXE
    Yarn: Not Found
    npm: 7.22.0 - C:\Program Files\nodejs\npm.CMD
  Browsers:
    Chrome: 94.0.4606.81
    Edge: Spartan (44.19041.1023.0), Chromium (94.0.992.38)
    Internet Explorer: 11.0.19041.1202
  npmPackages:
    react: ^17.0.2 => 17.0.2
    react-dom: ^17.0.2 => 17.0.2
    react-scripts: 4.0.3 => 4.0.3
  npmGlobalPackages:
    create-react-app: Not Found

Steps to reproduce

Install a package that uses subpath exports
Import something from the package that is part of a subpath export
Attempt to build or run

Expected behavior
Compilation succeeds.
Actual behavior
Compilation fails
Reproducible demo
Create a new react project:
npx create-react-app my-app --template typescript
Enter into it and install dependencies:
cd my-app
npm install @inrixia/helpers
Add this import statement to the project. The console.log is there to ensure that the import is kept as its used.
import { toBase64 } from "@inrixia/helpers/react";
console.log(toBase64);

Attempt to build the project...
As a bonus step you can exit out of the project and make a new folder.
npm install @inrixia/helpers and create a single test.ts file with the above import code.
Using ts-node or just compiling and running the file will work perfectly fine.

@Inrixia are there any workarounds? Faced it while developing icon kit, really need that feature


Add tests for VLAs in offloaded OpenMP regions.

Add tests for VLAs in offloaded OpenMP regions.
Adding tests for VLA in target regions.
I am adding 5 tests:

3 (all vla-in-teams-distribute tests) will pass when this patch lands: https://reviews.llvm.org/D153883
vla-in-parallel-for will pass due to the use of -O3
vla-in-parallel-for-1 will fail in the backend because it uses -O0 and the calls to stacksave are not optimized out. This test exposes a backend bug which needs to be handled separately.

Should this be merged now?

lets reject it , and resubmit it for review

please resubmit a new PR


VS Code

Time Spent

Mean: 2.6052631578947367
Median: 3.0
Max: 4.0
Min: 1.0
Full Data: 1.0, 1.5, 2.0, 2.0, 2.0, 2.0, 2.0, 2.0, 2.0, 3.0, 3.0, 3.0, 3.0, 3.0, 3.0, 3.0, 4.0, 4.0, 4.0

Comments

It was great!
Configuring the launch.json and tasks.json took me a long time. I wasn't sure what they were doing and I didn't feel like they were explained super well in the video.
None
Some stronger activities would be helpful
VS code is great
This was a good, thorough intro to using VS code.
I was unabable to get the debugger to work, maybe have step by step instructions for that
It was good.
none
There are lots of tips but all of it felt a bit scattered so it would be nice to have a little more direction. Really helpful though.
The talk was great, and got me up to speed on several key things. I especially appreciated the instruction on debugging (single-step, etc) and integrated ssh. Spent some time configuring VS Code, test debugging an old c++ program, and trying extensions for tools I need.
It was good
Cool extensions.
none
Great module. I love the tips and tricks for using it effectively.
This was a helpful intro to VS code. I wish I had this when I was taking junior core classes.
Add more information to help set up the debugger.

Match module template
Add instructions to configure debugger.
Develop some activites:
Purpose of activities:

help them set up their settings
help them use debuggers

Other Potential additions:
Add a bit on tasks: how to use and set up.
Add a bit about settings sync.


update to UBERON hierarchy

This updates the UBERON hierarchy within VEuPath, which has changed since the last release. It now relies on 2 upper-level CARO terms, so these are added also. They are added to externalByHand since CARO is not currently working in ontofox.

@johnwjudkins It seems the CARO is not loaded correctly in the ontoBee server. Could you please contact ontoBee developers to reload the ontology? We can make the updates if the issue persists after CARO loaded.

Closing and replacing with other pull request since CARO is now in ontofox.


Firefox on MacOS "flickering" when browsing between pages when sidebar is collapsible

Package
filament/filament
Package Version
v2.17.46
Laravel Version
10
Livewire Version
v2.11
PHP Version
PHP 8.2.5
Problem description
When navigating between Filament admin pages using Firefox on MacOS (not able to test on other OSes), the page flickers as it looks to be doing a full re-render.
Although this is expected behaviour on a full page load, it usually appears smoothed over and less jerky as you don't see all content being redrawn.
When doing the same in another browser (Chrome or Safari), or setting 'sidebar' => [ 'is_collapsible_on_desktop' => false] (instead of true), the behaviour reverts to normal.
This can be seen on this screen recording (taken from @Stanley on Discord):
https://cdn.discordapp.com/attachments/1083743705892134963/1083743706345128027/Screen_Recording_2023-03-10_at_14.24.39.mov
I'm guessing there's some rendering process for the sidebar that's making Firefox redraw the elements slower, forcing the "flicker".
Expected behavior
Flickering shouldn't occur, like the normal behaviour in Safari and Chrome, or when 'sidebar' => [ 'is_collapsible_on_desktop' => true]
Steps to reproduce
Create a new Filament app, set 'sidebar' => [ 'is_collapsible_on_desktop' => true ]
Browse between pages/resources from the sidebar in Firefox (MacOS).
Reproduction repository
https://github.com/benshawuk/filament
Relevant log output
none

This happens for me in all browsers.
The reason it is happening is because when the sidebar is set to be collapsible on desktop the sidebar has to be hidden initially since it can exist in either collapsed or open state and can only be shown when Alpine initializes and can set / read the store value to determine which way to show it.
So this will always be limited by the browser's ability to load and run the main JS thread in a timely manner.
I'm not sure there is much we can do about it.

Yeah, I think fixing it would introduce other issues with the sidebar sometimes briefly appearing when it is collapsed, right?

I think so.

I think it's less annoying if it disappears instead of expands, so closing

Agreed.


Actions: Required workflows

Summary
Required workflows allow DevOps teams / CICD system administrators to define mandated workflows to run during the lifecycle of a repository’s pipeline. Individual development teams at the repository level will be able to see what required workflows have been applied to their repository, what actions that workflow performs, and whom to contact if they have questions.
In addition to reducing duplication of CI/CD configuration code, required workflows can also help companies with the following use cases:

Security: Invoke external vulnerability scoring or dynamic analysis tools beyond CodeQL or Dependabot.
Correctness and Compliance: Ensure that all code meets an enterprise’s quality standards. e.g., Enforce consistent code syntax conventions, or ensure that unit test coverage meets a minimum level before deployments are permitted.
Deployment: Ensure that code is continuously deployed in a standard way.

Intended Outcome
Required workflows allows DevOps teams to define and enforce standard CI/CD practices across many source code repositories within an organization without needing to configure each repository individually, which becomes an impossible task in large organizations.
How will it work?
Workflow documents can be selected by an administrator from any repository in an organization (the "source" repo or "imposer" repo) and applied to one or more target repositories (the "imposee"). The first version of required workflows will support workflows using the pull_request webhook only.

🚢 This has shipped to dotcom: https://github.blog/changelog/2023-01-10-github-actions-support-for-organization-wide-required-workflows-public-beta. Leaving open to track for GHES release!

This shipped with GHES 3.8<EMAIL_ADDRESS>


NW scraper fails

The scraper currently fails:
Run the scraper...
WARNING: Expected Hospitalized to be present for NW
WARNING: Expected ICU to be present for NW
Error: Not matched input line: WARNING: Hospitalized is None
Error: Not matched input line: WARNING: ICU is None
{'date': '2020-04-10', 'time': '15:55', 'area': 'NW', 'tested': '', 'confirmed': 100, 'new_hospitalized': '', 'hospitalized': '', 'icu': '', 'vent': '', 'released': '', 'deceased': 0, 'source': 'https://www.nw.ch/gesundheitsamtdienste/6044'}

Fixed with #505


[BUG] Write stream not finished when callback is triggered

Context
In order to help us troubleshoot issues with this project, you must provide the following details:

ElasticDump version: 6.87.0
Elasticsearch version: OpenSearch 1.3.1
Node.js version (note that nodejs v10+ is required for this tool): v16.16.0
Full command you are having issue with (with inputs and outputs): it's a js code call described below
A data-set you can share publicly which reproduces the problem: None

Describe the bug
I'm trying to integrate elasticdump into my project code, and try to archive all the jsons into one big tar file after dump finished. When the dump callback is triggered, the json file's stat.block is still changing, so the archive process complains a 'size mismatch' error, indicating that the file is still being written when archiving.
To Reproduce
Steps to reproduce the behavior:
Here is the simplest sample code:

const ElasticDump = require("elasticdump");

const OPTIONS_TEMPLATE = {
    size: -1,
    limit: 5000,
    offset: 0,
    debug: false,
    type: "data",
    delete: false,
    maxSockets: null,
    input: "https://USR:PWD@HOST:PORT/gits",
    "input-index": null,
    output: "/tmp/gits.json",
    "output-index": null,
    noRefresh: false,
    // inputTransport: null,
    // outputTransport: null,
    searchBodyTemplate: null,
    searchWithTemplate: false,
    filterSystemTemplates: true,
    // templateRegex: "^(metrics|logs|.+_audit_log|.+-index-template|\\..+)$",
    headers: null,
    "input-headers": null,
    "output-headers": null,
    sourceOnly: false,
    jsonLines: false,
    format: "",
    "ignore-errors": false,
    "support-big-int": false,
    "big-int-fields": "",
    scrollId: null,
    scrollTime: "10m",
    scrollRetryDelay: 15000,
    "scroll-with-post": false,
    timeout: null,
    toLog: true,
    quiet: false,
    // fsCompress: true,
    awsIniFileName: null,
    sessionToken: null,
    transform: null,
    httpAuthFile: null,
    params: null,
    "input-params": null,
    "output-params": null,
    prefix: "",
    suffix: "",
    retryAttempts: 0,
    customBackoff: false,
    retryDelayBase: 0,
    retryDelay: 5000,
    parseExtraFields: "",
    fileSize: -1,
    maxRows: -1,
    cert: null,
    key: null,
    pass: null,
    ca: null,
    tlsAuth: false,
    concurrency: 1,
    throttleInterval: 1,
    carryoverConcurrencyCount: true,
    intervalCap: 5,
    concurrencyInterval: 5000,
    overwrite: false,
    rejectUnauthorized: false,
    "force-os-version": "7.10.2",
};
options.searchBody = {
    query: {
        bool: {
            must: [
                {
                    match: {
                        "foo": 'bar',
                    },
                },
                {
                    "range": {
                        "search_key.updated_at": {
                            "gt":<PHONE_NUMBER>441
                        }
                    }
                }
            ],
        },
    },
};

const dumper = new ElasticDump(options);

dumper.dump((err) => {
    console.log('dump finished', err)
    var count = 0
    const interval = setInterval(()=>{
        const stat = fs.statSync('demo.json')
        console.log(stat.mode, stat.size, stat.blocks)
        if (++count >= 10){
            clearInterval(interval)
        }
    }, 20)
})

Current behavior
Describe what's happening now.
The sample code runs an interval to monitor the target dumped file, the stat.blocks keeps changing after the dump is finished. It might not always occur, but by changing the interval and times and querybody(to control the output file size), it's easy to reproduce the behavior. It's likely to occur when the output file is large.
Expected behavior
A clear and concise description of what you expected to happen.
As I understand, callback is triggered when all the chunks are written to the output file. So the file stat should not change inside the callback.
Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
Add any other context about the problem here.

A good bug report shouldn't leave others needing to chase you up for more information. Please try to be as detailed as possible in your report. What is your environment? What was the url? What steps will reproduce the issue? What OS experience the problem? All these details will help to fix any potential bugs as soon as possible.

Close the issue since I found it's a bug or unexpected behavior on the archive lib, not elasticdump


Run docs, samples, system, lint tests on node 10

Our kokoro config is currently set up to run all these tests on node.js 8.  That's going EOL by the EOY, and it's slower than 10.  Let's upgrade!

It's time to move on :)

Sorry I missed this earlier, but I wanted to reopen to discuss an alternative approach. Should we think about running system tests across all of the supported versions? If that's unfeasible, I would think we should lean towards the smallest supported version, as that's the place where we're likely to run into compatibility issues.
An example case: https://github.com/googleapis/nodejs-storage/pull/619. Upgrading to gcs-resumable-upload@1 is incompatible with Node 8. Our previous system tests correctly caught this and failed. We upgraded to Node 10, and then it passed, and we merged.

This was rotten timing and luck for a change, huh?  A few thoughts here.
Running system/sample tests on a matrix
These tend to be pretty resource intensive tests.  We're creating stuff, deleting, doing all sorts of reads..  We already run into quota trouble a fair bit, and we fight backend flakes from time to time.  I'm worried that this isn't the place for a matrix. Tbh - this is what I count on the unit tests for.
Defaulting to the lower major LTS version
I feel like we're picking our poison here.  Even money there's a bug that only appears in 10 when it's something this subtle.  I'd prefer to stay on 10 if possible, cause it's faster and lets us use more advanced features in our system and sample tests. Also, probably matches what most people are using since we're counting down the months until 8 deprecation.
TL;DR - would it be at all possible to capture this case in a unit test?

So far, I'm still investigating that particular issue. But the error seems network-connection related, so it could indicate a change in an upstream transport mechanism/dependency, so system tests are appropriate for this type of test. I think we actually have a duplicate test where we simulate the network, and we're getting green ✅s. But, again, I don't know for sure what it is yet, so it could very well turn out to be an easy unit test fix.

I'd prefer to stay on 10 if possible, cause it's faster and lets us use more advanced features in our system and sample tests.

I agree, although that's not why we have system tests. We should just be concerned with not breaking user code. Our development experience shouldn't de-prioritize user experience.
Factually speaking, I would consider the matrix approach mandatory for ensuring compatibility. Without it, we don't actually know if we're green on all of our supported versions. It sounds like a matter of practicality that we are limited to testing just one Node version*, so sticking with the most likely to cause problems makes sense to me, as opposed to the new, fun, and exciting Node versions :)

Is it worth having a discussion about going back to the matrix approach? Maybe even a special, one-time run that only happens before a release?

The same test turned out to uncover yet another difference, where Node 6 and 8 fail for different reasons. More info on that: https://github.com/googleapis/gcs-resumable-upload/issues/191

So I'm a little confused :) Also cc @bcoe because this is a really interesting conversation on a variety of fronts :)

Is it worth having a discussion about going back to the matrix approach? Maybe even a special, one-time run that only happens before a release?

Were we ever running system and sample tests in a matrix?

my two cents; given the exciting work happening in Node.js and V8, I think it's reasonable to drop library versions once they're (EOL)[https://github.com/nodejs/Release]. The Node.js community as a whole seems to be adopting this approach more and more, and it's meant that the exciting improvements in the JavaScript platform benefit the community in a reasonable timeframe.
I used to be much more conservative with yargs and nyc (I spent a lot of time trying to support all the way back to 0.10) ... I reached a point where I had a reversal on this, partially because my own users were advocating the upgrades.
As for a testing matrix, I definitely think it's valuable to test on all non-EOL versions of Node.js; Node.js itself will sometimes introduce regressions, and having tests run on a few versions can help differentiate between your own bugs, and the platform's bugs.

\o/ this is now being done.


Added tests for src\client\debugger\debugAdapter\serviceRegistry.ts

For #9231

[x] Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
[x] Title summarizes what is changing
[ ] Has a news entry file (remember to thank yourself!)
[ ] Appropriate comments and documentation strings in the code
[ ] Has sufficient logging.
[ ] Has telemetry for enhancements.
[x] Unit tests & system/integration tests are added/updated
[ ] Test plan is updated as appropriate
[ ] package-lock.json has been regenerated by running npm install (if dependencies have changed)
[ ] The wiki is updated with any design decisions/details.

Codecov Report

Merging #9312 into master will decrease coverage by 0.19%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master    #9312     +/-   ##
=========================================
- Coverage   60.11%   59.91%   -0.2%
=========================================
  Files         537      544      +7
  Lines       28392    28593    +201
  Branches     4302     4325     +23
=========================================
+ Hits        17068    17132     +64
- Misses      10387    10522    +135
- Partials      937      939      +2

Impacted Files
Coverage Δ

...rc/client/debugger/debugAdapter/serviceRegistry.ts
100% <100%> (+100%)
:arrow_up:

src/client/common/utils/platform.ts
64.7% <0%> (-11.77%)
:arrow_down:

src/client/linters/pydocstyle.ts
86.36% <0%> (-2.28%)
:arrow_down:

src/client/datascience/debugLocationTracker.ts
76.56% <0%> (-1.57%)
:arrow_down:

src/client/common/process/proc.ts
14.81% <0%> (-0.75%)
:arrow_down:

...ent/debugger/debugAdapter/Common/protocolWriter.ts
37.5% <0%> (ø)

src/client/debugger/debugAdapter/types.ts
100% <0%> (ø)

src/client/common/net/socket/socketServer.ts
15.38% <0%> (ø)

...ent/debugger/debugAdapter/Common/protocolLogger.ts
7.14% <0%> (ø)

...ent/debugger/debugAdapter/Common/protocolParser.ts
6.77% <0%> (ø)

... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d4b1b2...d8d0e21. Read the comment docs.


clarify how to enable plugin in CI only

Hi, thanks for this great project!
The README.md says:

If you want to enable the plugin in CI only, you can use extend the config with the the plugin locally, but enable it

but this sentence doesn't really make sense.  Based on other docs elsewhere, I guess that we should extend the config with plugin:diff/ci and then ensure that the CI sets the environment variables CI and ESLINT_PLUGIN_DIFF_COMMIT - is that right?

What we do is follow the instructions to set the CI and ESLINT_PLUGIN_DIFF_COMMIT variables in our github workflow, then our .eslintrc.js file has the following
module.exports = {     extends: [         ...(process.env.CI ? ['plugin:diff/ci'] : []),


[fix] fixed bug that sgpr and vgpr usage can't take effect

#23
remove relative code

TODO：These variables will be automatically obtained from the elf file later.

LGTM


Facing unexpected issue(Invalid user) in production

Currently we are using micro services architecture in our project.
We have gatewayservices which is used only for authentication and authorization.
We have 2 more services services1 and services2 which work as resource server.
For gateway services we are using(spring boot setup) spring-cloud-starter-gateway-mvc and spring security.
It works perfectly fine in local and nonprod and prod also.
But some time it between(even after login successfully and using application it occure in between and random) we face invalid user issue and the application get stuck and all other users also faces same issue. It get resolve after sometime by itself.
I have check the log and I am attaching some example.
[](2024-08-21T07:55:56.343Z DEBUG 1 --- [gateway-service] [nio-9092-exec-3] o.s.s.web.DefaultRedirectStrategy        : Redirecting to https://prod.myurl.com/login
2024-08-21T07:55:56.397Z DEBUG 1 --- [gateway-service] [nio-9092-exec-5] o.s.security.web.FilterChainProxy        : Securing GET /login
2024-08-21T07:55:56.720Z DEBUG 1 --- [gateway-service] [nio-9092-exec-2] o.s.security.web.FilterChainProxy        : Securing GET /oauth2/authorization/azure
2024-08-21T07:55:56.721Z DEBUG 1 --- [gateway-service] [nio-9092-exec-2] o.s.s.web.DefaultRedirectStrategy        : Redirecting to https://login.microsoftonline.com/tenantid/oauth2/v2.0/authorize?response_type=code&client_id=client123&scope=api://az0-myurld-prod-app/User.Read%20openid&state=dwerr%3D&redirect_uri=https://prod.myurl.com/login/oauth2/code/azure&nonce=xxxxyyy
2024-08-21T07:55:58.240Z DEBUG 1 --- [gateway-service] [nio-9092-exec-4] o.s.security.web.FilterChainProxy        : Securing GET /login?error
2024-08-21T07:56:08.010Z DEBUG 1 --- [gateway-service] [nio-9092-exec-7] o.s.security.web.FilterChainProxy        : Securing GET /login/oauth2/code/azure?code=code123&session_state=session123
2024-08-21T07:56:08.010Z DEBUG 1 --- [gateway-service] [nio-9092-exec-7] o.s.s.web.DefaultRedirectStrategy        : Redirecting to /login?error)

When you need a token fro azure it is a two step communication. First you will send userid and password and in return azure will provide with code as you can see in logs. Again you will send the code to azure and it will provide you token.
In our cases it is working as I mention above. But sometime it get code from azure and It goes to spring filter and spring filter gives error invalid user. As you can see in above in log filterChainProxy throws error.
I am not able to understand few things
how to produce it in local
second what can be the issue with code that spring give error.
Is issue is with spring session or some threads.
If one user get this issue all user start getting same issue and it get solve after sometime.
Please help me as it is a production issue I don't have access. Please message if you required extra information on it like project setup details.
Thanks for you help and support.

Hi team,
It is severely impacting production.
So requesting you to Please take this on PRIORITY.
thanks for the support

I know nothing about azure. How are we to reproduce it?

If you would like us to look at this issue, please provide the requested information. If the information is not provided within the next 7 days this issue will be closed.

Closing due to lack of requested feedback. If you would like us to look at this issue, please provide the requested information and we will re-open the issue.


Crash on Android: Failed to create a new MMKV instance

Hey there,
thanks for your work on this library. 🙏 We are seeing crashes for our Android users lately:

Failed to create a new MMKV instance, the native initializer function does not exist. Is the native MMKV library correctly installed? Make sure to disable any remote debugger (e.g. Chrome) to use JSI!

Any clue what we are doing wrong / what is going wrong? Help is much appreciated.
Stack Trace

Details
com.facebook.react.common.JavascriptException: Error: Failed to create a new MMKV instance, the native initializer function does not exist. Is the native MMKV library correctly installed? Make sure to disable any remote debugger (e.g. Chrome) to use JSI!, js engine: hermes, stack:
MMKV@1:1478137
anonymous@1:1476333
loadModuleImplementation@1:109640
guardedLoadModule@1:109189
metroRequire@1:108817
anonymous@1:1476081
loadModuleImplementation@1:109640
guardedLoadModule@1:109189
metroRequire@1:108817
anonymous@1:1354932
loadModuleImplementation@1:109640
guardedLoadModule@1:109189
metroRequire@1:108817
anonymous@1:1884908
loadModuleImplementation@1:109640
guardedLoadModule@1:109189
metroRequire@1:108817
anonymous@1:1883611
loadModuleImplementation@1:109640
guardedLoadModule@1:109189
metroRequire@1:108817
anonymous@1:1353590
loadModuleImplementation@1:109640
guardedLoadModule@1:109189
metroRequire@1:108817
anonymous@1:116413
loadModuleImplementation@1:109640
guardedLoadModule@1:109146
metroRequire@1:108817
global@1:108403
at com.facebook.react.modules.core.ExceptionsManagerModule.reportException(ExceptionsManagerModule.java
  at java.lang.reflect.Method.invoke (Native Method)
  at com.facebook.react.bridge.JavaMethodWrapper.invoke (JavaMethodWrapper.java:372)
  at com.facebook.react.bridge.JavaModuleWrapper.invoke (JavaModuleWrapper.java:188)
  at com.facebook.react.bridge.queue.NativeRunnable.run (Native Method)
  at android.os.Handler.handleCallback (Handler.java:938)
  at android.os.Handler.dispatchMessage (Handler.java:99)
  at com.facebook.react.bridge.queue.MessageQueueThreadHandler.dispatchMessage (MessageQueueThreadHandler.java:27)
  at android.os.Looper.loop (Looper.java:246)
  at com.facebook.react.bridge.queue.MessageQueueThreadImpl$4.run (MessageQueueThreadImpl.java:226)
  at java.lang.Thread.run (Thread.java:923)

Backtrace

Details
pid: 0, tid: 0 >>> com.tocsenapp <<<

backtrace:
  #00  pc<PHONE_NUMBER>024944  /data/app/~~Ol5ZwGOSXUlQuQ9Tf5g5zQ==/com.tocsenapp-qOqecHj6GFz8FSakchzmVA==/lib/arm64/libhermes.so
  #00  pc<PHONE_NUMBER>00fb78  /data/app/~~Ol5ZwGOSXUlQuQ9Tf5g5zQ==/com.tocsenapp-qOqecHj6GFz8FSakchzmVA==/lib/arm64/libreactnativemmkv.so (install(facebook::jsi::Runtime&)+80)
  #00  pc<PHONE_NUMBER>01017c  /data/app/~~Ol5ZwGOSXUlQuQ9Tf5g5zQ==/com.tocsenapp-qOqecHj6GFz8FSakchzmVA==/lib/arm64/libreactnativemmkv.so (Java_com_reactnativemmkv_MmkvModule_nativeInstall+80)
  #00  pc<PHONE_NUMBER>179ed4  /data/app/~~Ol5ZwGOSXUlQuQ9Tf5g5zQ==/com.tocsenapp-qOqecHj6GFz8FSakchzmVA==/oat/arm64/base.odex (art_jni_trampoline+180)
  #00  pc<PHONE_NUMBER>5981d8  /data/app/~~Ol5ZwGOSXUlQuQ9Tf5g5zQ==/com.tocsenapp-qOqecHj6GFz8FSakchzmVA==/oat/arm64/base.odex (com.reactnativemmkv.MmkvModule.install+72)
  #00  pc<PHONE_NUMBER>3bece8  /data/app/~~Ol5ZwGOSXUlQuQ9Tf5g5zQ==/com.tocsenapp-qOqecHj6GFz8FSakchzmVA==/oat/arm64/base.odex (com.tocsenapp.TocsenJSIPackage.getJSIModules+248)
  #00  pc<PHONE_NUMBER>221504  /data/app/~~Ol5ZwGOSXUlQuQ9Tf5g5zQ==/com.tocsenapp-qOqecHj6GFz8FSakchzmVA==/oat/arm64/base.odex (com.facebook.react.ReactInstanceManager.createReactContext+4068)
  #00  pc<PHONE_NUMBER>21e5c8  /data/app/~~Ol5ZwGOSXUlQuQ9Tf5g5zQ==/com.tocsenapp-qOqecHj6GFz8FSakchzmVA==/oat/arm64/base.odex (com.facebook.react.ReactInstanceManager$5.run+1544)
  #00  pc<PHONE_NUMBER>15ce98  /apex/com.android.art/javalib/arm64/boot.oat (java.lang.Thread.run+72)
  #00  pc<PHONE_NUMBER>135564  /apex/com.android.art/lib64/libart.so (art_quick_invoke_stub+548)
  #00  pc<PHONE_NUMBER>1ab7e8  /apex/com.android.art/lib64/libart.so (art::ArtMethod::Invoke(art::Thread*, unsigned int*, unsigned int, art::JValue*, char const*)+200)
  #00  pc<PHONE_NUMBER>567e94  /apex/com.android.art/lib64/libart.so (art::JValue art::InvokeVirtualOrInterfaceWithJValues<art::ArtMethod*>(art::ScopedObjectAccessAlreadyRunnable const&, _jobject*, art::ArtMethod*, jvalue const*)+460)
  #00  pc<PHONE_NUMBER>5b8184  /apex/com.android.art/lib64/libart.so (art::Thread::CreateCallback(void*)+1308)
  #00  pc<PHONE_NUMBER>0b10e8  /apex/com.android.runtime/lib64/bionic/libc.so (__pthread_start(void*)+64)
  #00  pc<PHONE_NUMBER>050a58  /apex/com.android.runtime/lib64/bionic/libc.so (__start_thread+64)```

</details>

Hi Moritz!
Can you share your ADB logs?

I can provide you with the crash report from Google Play. We can't reproduce it so far.

I'm having the same issue as well. Using RN 0.66.3 and MMKV 1.5.3

same issue here, versions are also RN 0.66.3 and MMKV 1.5.3. Otherwise also the same problems already stated, until now we are not able to reproduce it locally but have the same stack trace in the google play crash reports

I can now add one more insight, from our customer support we got confirmed that a reinstallation of the app helped to resolve the issue at least for the moment

We are seeing this issue ever since the first release with mmkv @mrousavy, thought it might be a one of case, but it's occurring fairly consistently. Not sure why though.

Is there anything we can do here? Seeing this a lot in Play Store crash reports but cannot reproduce locally.

Well there certainly is nothing I can do without a reproduceable example

Are you using any weird Runtime things? E.g. react-native-reload or whatever that lib is called

Which RN version?
Which RN-MMKV version?
What other JSI Modules do you use?
How does your JSI Module Package .java file look?
Can you put log statements in your JSI Module Package and share the full ADB logs with me to see if it gets installed correctly and before the JS bundle starts executing? (e.g. Log.w("mrousavy", "Installing RN-MMKV..."))
Does it work on iOS?

Btw: I have 3 apps in production, RN 0.66.3, RN 0.66.3 and RN 0.67.0-rc.5, all of them with latest MMKV and no crashes at all.

Unfortunately I cannot share the logs at this time

Well, too bad 🤷♂

with further investigation over the last days we could narrow it down to be related to code-push.
My assumption is that there is some race condition or conflict when the bundle is changed and the app restarted

with further investigation over the last days we could narrow it down to be related to code-push. My assumption is that there is some race condition or conflict when the bundle is changed and the app restarted

I believe this as well, looking at the logs last night it seems like there are times on newer devices where the app starts and it creates a race condition before MMKV starts.

with further investigation over the last days we could narrow it down to be related to code-push. My assumption is that there is some race condition or conflict when the bundle is changed and the app restarted

I believe this as well, looking at the logs last night it seems like there are times on newer devices where the app starts and it creates a race condition before MMKV starts.

We're seeing this crash quite frequently as well and we are not using CodePush. We have 100k+ users and the error has happened 300 times in the last week, all android versions and manufacturers.
React Native: 0.67.0-rc.6
Reanimated 2.2.4
MMKV 1.5.4

Stack Trace
```com.facebook.react.common.JavascriptException: Error: Failed to create a new MMKV instance, the native initializer function does not exist. Is the native MMKV library correctly installed? Make sure to disable any remote debugger (e.g. Chrome) to use JSI!, js engine: hermes, stack:
MMKV@1:1746849
anonymous@1:2000261
loadModuleImplementation@1:100461
guardedLoadModule@1:100010
metroRequire@1:99638
anonymous@1:1999667
loadModuleImplementation@1:100461
guardedLoadModule@1:99967
metroRequire@1:99638
get@1:1998368
GlobalProviders@1:2131233
renderWithHooks@1:169443
beginWork$1@1:208997
performUnitOfWork@1:195161
workLoopSync@1:195018
renderRootSync@1:194902
performSyncWorkOnRoot@1:192265
flushSyncCallbacks@1:159711
scheduleUpdateOnFiber@1:189905
updateContainer@1:200277
anonymous@1:210016
renderApplication@1:528510
run@1:525423
runApplication@1:525925
__callFunction@1:136157
anonymous@1:134644
__guard@1:135602
callFunctionReturnFlushedQueue@1:134602
at com.facebook.react.modules.core.ExceptionsManagerModule.reportException(ExceptionsManagerModule.java
at java.lang.reflect.Method.invoke (Native Method)
at com.facebook.react.bridge.JavaMethodWrapper.invoke (JavaMethodWrapper.java:372)
at com.facebook.react.bridge.JavaModuleWrapper.invoke (JavaModuleWrapper.java:188)
at com.facebook.react.bridge.queue.NativeRunnable.run (Native Method)
at android.os.Handler.handleCallback (Handler.java:938)
at android.os.Handler.dispatchMessage (Handler.java:99)
at com.facebook.react.bridge.queue.MessageQueueThreadHandler.dispatchMessage (MessageQueueThreadHandler.java:27)
at android.os.Looper.loop (Looper.java:246)
at com.facebook.react.bridge.queue.MessageQueueThreadImpl$4.run (MessageQueueThreadImpl.java:226)
at java.lang.Thread.run (Thread.java:923)```

That's possible - you can patch codepush to call the initializer function of MMKV again when it reloads the bundle. Haven't investigated how CodePush works exactly, but that's possibly a solution.
It seems weird to me that this only fails for MMKV though, REA v2 should also break in that case? 🤔

Hey there,
While trying to solve this issue #269 I made a bare Typescript expo workflow.
I get the same error mentionned here.
I followed the steps mentionned here to complete expo installation, but I still have this error.
Steps to reproduce:

Create a bare expo workflow with Typescript
make a new MMKV instance
Trying to lauch on android with expo GO application (my phone is Xiamoi Redmi 8)

Native Modules do not work on Expo Go. You need to use EAS with the config plugin to make MMKV work.

I am getting the same issue on android. I have managed to get the adb logs if they are any help at all.

adb logs
01-13 17:08:43.442  4329 11013 I ReactNativeJS: Running "KapptureEngineer" with {"rootTag":1}
01-13 17:08:43.636  4329 11013 E ReactNativeJS: Error: Failed to create a new MMKV instance, the native initializer function does not exist. Is the native MMKV library correctly installed? Make sure to disable any remote debugger (e.g. Chrome) to use JSI!
01-13 17:08:43.642  4329 11015 E AndroidRuntime: FATAL EXCEPTION: mqt_native_modules
01-13 17:08:43.642  4329 11015 E AndroidRuntime: Process: com.kapptureengineer.kappture, PID: 4329
01-13 17:08:43.642  4329 11015 E AndroidRuntime: com.facebook.react.common.JavascriptException: Error: Failed to create a new MMKV instance, the native initializer function does not exist. Is the native MMKV library correctly installed? Make sure to disable any remote debugger (e.g. Chrome) to use JSI!, stack:
01-13 17:08:43.642  4329 11015 E AndroidRuntime: @500:170
01-13 17:08:43.642  4329 11015 E AndroidRuntime: u@499:1371
01-13 17:08:43.642  4329 11015 E AndroidRuntime: @413:244
01-13 17:08:43.642  4329 11015 E AndroidRuntime: h@2:1585
01-13 17:08:43.642  4329 11015 E AndroidRuntime: d@2:958
01-13 17:08:43.642  4329 11015 E AndroidRuntime: @402:835
01-13 17:08:43.642  4329 11015 E AndroidRuntime: yr@56:42051
01-13 17:08:43.642  4329 11015 E AndroidRuntime: ql@56:90905
01-13 17:08:43.642  4329 11015 E AndroidRuntime: Fa@56:81677
01-13 17:08:43.642  4329 11015 E AndroidRuntime: Ua@56:81579
01-13 17:08:43.642  4329 11015 E AndroidRuntime: La@56:81344
01-13 17:08:43.642  4329 11015 E AndroidRuntime: Ea@56:78307
01-13 17:08:43.642  4329 11015 E AndroidRuntime: Ea@-1
01-13 17:08:43.642  4329 11015 E AndroidRuntime: ft@56:26099
01-13 17:08:43.642  4329 11015 E AndroidRuntime: _a@56:75396
01-13 17:08:43.642  4329 11015 E AndroidRuntime: li@56:89643
01-13 17:08:43.642  4329 11015 E AndroidRuntime: @56:96393
01-13 17:08:43.642  4329 11015 E AndroidRuntime: @348:646
01-13 17:08:43.642  4329 11015 E AndroidRuntime: run@345:683
01-13 17:08:43.642  4329 11015 E AndroidRuntime: runApplication@345:1797
01-13 17:08:43.642  4329 11015 E AndroidRuntime: value@37:3556
01-13 17:08:43.642  4329 11015 E AndroidRuntime: @37:673
01-13 17:08:43.642  4329 11015 E AndroidRuntime: value@37:2503
01-13 17:08:43.642  4329 11015 E AndroidRuntime: value@37:645
01-13 17:08:43.642  4329 11015 E AndroidRuntime: value@-1
01-13 17:08:43.642  4329 11015 E AndroidRuntime:
01-13 17:08:43.642  4329 11015 E AndroidRuntime: 	at com.facebook.react.modules.core.ExceptionsManagerModule.reportException(ExceptionsManagerModule.java:83)
01-13 17:08:43.642  4329 11015 E AndroidRuntime: 	at java.lang.reflect.Method.invoke(Native Method)
01-13 17:08:43.642  4329 11015 E AndroidRuntime: 	at com.facebook.react.bridge.JavaMethodWrapper.invoke(JavaMethodWrapper.java:372)
01-13 17:08:43.642  4329 11015 E AndroidRuntime: 	at com.facebook.react.bridge.JavaModuleWrapper.invoke(JavaModuleWrapper.java:188)
01-13 17:08:43.642  4329 11015 E AndroidRuntime: 	at com.facebook.react.bridge.queue.NativeRunnable.run(Native Method)
01-13 17:08:43.642  4329 11015 E AndroidRuntime: 	at android.os.Handler.handleCallback(Handler.java:938)
01-13 17:08:43.642  4329 11015 E AndroidRuntime: 	at android.os.Handler.dispatchMessage(Handler.java:99)
01-13 17:08:43.642  4329 11015 E AndroidRuntime: 	at com.facebook.react.bridge.queue.MessageQueueThreadHandler.dispatchMessage(MessageQueueThreadHandler.java:27)
01-13 17:08:43.642  4329 11015 E AndroidRuntime: 	at android.os.Looper.loop(Looper.java:233)
01-13 17:08:43.642  4329 11015 E AndroidRuntime: 	at com.facebook.react.bridge.queue.MessageQueueThreadImpl$4.run(MessageQueueThreadImpl.java:226)
01-13 17:08:43.642  4329 11015 E AndroidRuntime: 	at java.lang.Thread.run(Thread.java:923)
01-13 17:08:43.642  4329 11013 E ReactNativeJS: TypeError: undefined is not an object (evaluating 'r(d[8]).store')
01-13 17:08:43.642  4329 11013 E ReactNativeJS:
01-13 17:08:43.642  4329 11013 E ReactNativeJS: This error is located at:
01-13 17:08:43.642  4329 11013 E ReactNativeJS:     in Unknown
01-13 17:08:43.642  4329 11013 E ReactNativeJS:     in h
01-13 17:08:43.642  4329 11013 E ReactNativeJS:     in RCTView
01-13 17:08:43.642  4329 11013 E ReactNativeJS:     in Unknown
01-13 17:08:43.642  4329 11013 E ReactNativeJS:     in __Sentry.TouchEventBoundary
01-13 17:08:43.642  4329 11013 E ReactNativeJS:     in Unknown
01-13 17:08:43.642  4329 11013 E ReactNativeJS:     in RCTView
01-13 17:08:43.642  4329 11013 E ReactNativeJS:     in Unknown
01-13 17:08:43.642  4329 11013 E ReactNativeJS:     in RCTView
01-13 17:08:43.642  4329 11013 E ReactNativeJS:     in Unknown
01-13 17:08:43.642  4329 11013 E ReactNativeJS:     in b
01-13 17:08:43.644  1203 11039 I DropBoxManagerService: add tag=data_app_crash isTagEnabled=true flags=0x2
01-13 17:08:43.644  1203  5192 W ActivityTaskManager:   Force finishing activity com.kapptureengineer.kappture/com.kapptureengineer.MainActivity
01-13 17:08:43.645  4329 11013 E ReactNativeJS: TypeError: undefined is not an object (evaluating 'r(d[8]).store')
01-13 17:08:43.645  4329 11013 E ReactNativeJS:
01-13 17:08:43.645  4329 11013 E ReactNativeJS: This error is located at:
01-13 17:08:43.645  4329 11013 E ReactNativeJS:     in Unknown
01-13 17:08:43.645  4329 11013 E ReactNativeJS:     in h
01-13 17:08:43.645  4329 11013 E ReactNativeJS:     in RCTView
01-13 17:08:43.645  4329 11013 E ReactNativeJS:     in Unknown
01-13 17:08:43.645  4329 11013 E ReactNativeJS:     in __Sentry.TouchEventBoundary
01-13 17:08:43.645  4329 11013 E ReactNativeJS:     in Unknown
01-13 17:08:43.645  4329 11013 E ReactNativeJS:     in RCTView
01-13 17:08:43.645  4329 11013 E ReactNativeJS:     in Unknown
01-13 17:08:43.645  4329 11013 E ReactNativeJS:     in RCTView
01-13 17:08:43.645  4329 11013 E ReactNativeJS:     in Unknown
01-13 17:08:43.645  4329 11013 E ReactNativeJS:     in b
01-13 17:08:43.645  1203 11039 D FrameworkEventCollector: recordAppIssue PN: com.kapptureengineer.kappture
01-13 17:08:43.647  1203  5192 D OpQuickReply: setQuickReplyResumed focusedApp ActivityRecord{46b7641 u0 net.oneplus.launcher/.Launcher t5} pkgName net.oneplus.launcher
01-13 17:08:43.647  1203  2209 D gwy     : OS Event: crash
01-13 17:08:43.654  1203  5192 D ActivityTrigger: ActivityTrigger activityPauseTrigger
01-13 17:08:43.660  1203  2991 E HwuiBoostFrontPackageListener: Exception : file not exits :/sys/module/houston/parameters/hwui_boost_enable
01-13 17:08:43.661  1203  2991 D OpColorDisplayService: frontPackageChanged: net.oneplus.launcher
01-13 17:08:43.661  1203  2991 D OpColorDisplayService: lpackageName: com.kapptureengineer.kappture
01-13 17:08:43.661  1203  2991 D OpProximityController: noteFrontPackageChanged pkg:net.oneplus.launcher uid:10050 lpkg:com.kapptureengineer.kappture luid:10466
01-13 17:08:43.662  1203  1730 I DisplayPowerController: useProximityForceSuspend = false
01-13 17:08:43.662  1203  1730 I DisplayPowerController: brightnessState(m):1.0
01-13 17:08:43.662  1203  1730 I RampAnimator: target:1.0 rate:0.7058823 mCurrentValue:1.0 mTargetValue:1.0
01-13 17:08:43.663  1203  2991 D OemSceneModeActivityStack: [scene] evaluateGameModes :  gameMsg.arg1=0 gameMsg.arg2=1
01-13 17:08:43.663  1203  2991 D OpQuickReply: setQuickReplyResumed focusedApp ActivityRecord{46b7641 u0 net.oneplus.launcher/.Launcher t5} pkgName net.oneplus.launcher
01-13 17:08:43.672  1203  1530 D OpPowerConsumpStatsInjector: notifyPkgEvent
01-13 17:08:43.672  1203  1530 D OpRestartProcessManager: Duration is too short, ignore : 884 in com.kapptureengineer.kappture
01-13 17:08:43.674  1203  1530 D OpPowerConsumpStatsInjector: notifyPkgEvent
01-13 17:08:43.677  4329 11015 I Process : Sending signal. PID: 4329 SIG: 9
01-13 17:08:43.680  1203  1625 D ExtBatteryStatsService: ext-flush too soon, skip
01-13 17:08:43.680  1203  1625 D MyBatteryStatsHelper: ===processSingleAppUsage===
01-13 17:08:43.680  1203  1625 D MyBatteryStatsHelper: ===processSingleAppUsage===
01-13 17:08:43.682  2287  2287 D Launcher: onStart# hashcode: 263389453
01-13 17:08:43.682  2287  2287 I ShelfLauncherCallbacks: onStart
01-13 17:08:43.682  2287  2287 D LauncherAppWidgetHost: setListenIfResumed# listenIfResumed: true, flag: 2
01-13 17:08:43.683  2287  2287 D LauncherAppWidgetHost: startListening# flag: 7
01-13 17:08:43.683  2287  2287 D NotificationListener: setNotificationsChangedListener# l: net.oneplus.launcher.popup.PopupDataProvider@1e5f168
01-13 17:08:43.684  2287  2287 D NotificationListener: checkPermissionGranted# grant: false
01-13 17:08:43.684  2287  2287 D WallpaperEventHandler: [onLauncherStart] mWillResetWallpaper=false
01-13 17:08:43.685  2287  2287 D BaseActivity: onResume# who: Launcher, taskId: 5
01-13 17:08:43.687  2287  2287 D QuickPage: updateOnResume, count:6
01-13 17:08:43.687  2287  4776 D Launcher: onResume# isInteractive=true
01-13 17:08:43.687  2287  4775 D InstallShortcutReceiver: MSG_FLUSH_QUEUE string = null
01-13 17:08:43.688  2287  2287 I ShelfLauncherCallbacks: onResume
01-13 17:08:43.689  2287  2287 D Launcher.Workspace: DynamicIcon Workspace updateCurrentPageDynamicIconState success

I was facing same issue, then discovered that my project was using react-native-reanimated lib. The extra setup steps documented here for android fixed the problem on our side, hope this help!

Yeah either you didn't follow the installation guide correctly, or you are using Expo Go.

For the logs: Should be fixed with 2.0.0

with further investigation over the last days we could narrow it down to be related to code-push. My assumption is that there is some race condition or conflict when the bundle is changed and the app restarted

Is there any fix you have found for this?

Having the same issue


Add toggle to enable/disable tests.

When integrating this library in a project, it is useful to be able to disable the tests so that gtest doesn't get dragged in and clash with the project's gtest targets (if it has any).
I added a cmake option to do exactly that.

Thank you!


Ubuntu 18.04 - TimeoutError: waiting for selector failed: timeout 30000ms exceeded

Steps to reproduce
Tell us about your environment:

Puppeteer version: 3.0.2
Platform / OS version: Chrome / Ubuntu 18.04
URLs (if applicable):
Node.js version: v14.1.0

What steps will reproduce the problem?
Following code block (A),
Works on macOS Mojave 10.14.6;
Works properly on ubuntu 18.04
const puppeteer = require('puppeteer');
async function main() {
  const browser = await puppeteer.launch({
    headless: true
  });

  const page = await browser.newPage();
  await page.goto('https://example.com');

  await page.content();
  await page.screenshot({path: 'screenshot.png'});

  await browser.close();
}

main();

Following code block (B),
Works on macOS Mojave 10.14.6;
But throws error due to page.waitForSelector function on ubuntu 18.04
const puppeteer = require('puppeteer');
async function main() {
  const browser = await puppeteer.launch({
    headless: true,
  });
  const page = await browser.newPage();
  await page.goto('https://twitter.com/i/trends');
  await page.content();
  console.log("pageUrl", page.url());
  await page.waitForSelector("[data-testid=trend]");
  const trendElements = await page.$$("[data-testid=trend]");
  console.log("trendElementsLength", trendElements && trendElements.length);
  await browser.close();
}

main();

Launched an instance (ubuntu 18.04) on aws ec2 service
Created a file test-pup/index.js, and added script B mentioned above
Installed npm package (only puppeteer)
Run the script with node index

What is the expected result?
Should not throw error on ubuntu 18.04 like on macOS Mojave 10.14.6.
Should logs console something like
trendElementsLength 7

What happens instead?
Throws error on ubuntu 18.04, but not on macOS Mojave 10.14.6
UnhandledPromiseRejectionWarning: TimeoutError: waiting for selector
(node:5483) UnhandledPromiseRejectionWarning: TimeoutError: waiting for selector "[data-testid=trend]" failed: timeout 30000ms exceeded
    at new WaitTask (/home/ec2-user/test-pup/node_modules/puppeteer/lib/DOMWorld.js:549:28)
    at DOMWorld._waitForSelectorOrXPath (/home/ec2-user/test-pup/node_modules/puppeteer/lib/DOMWorld.js:478:22)
    at DOMWorld.waitForSelector (/home/ec2-user/test-pup/node_modules/puppeteer/lib/DOMWorld.js:432:17)
    at Frame.waitForSelector (/home/ec2-user/test-pup/node_modules/puppeteer/lib/FrameManager.js:627:47)
    at Frame.<anonymous> (/home/ec2-user/test-pup/node_modules/puppeteer/lib/helper.js:112:23)
    at Page.waitForSelector (/home/ec2-user/test-pup/node_modules/puppeteer/lib/Page.js:1122:29)
    at main (/home/ec2-user/test-pup/index.js:20:20)
    at processTicksAndRejections (internal/process/task_queues.js:97:5)
(Use `node --trace-warnings ...` to show where the warning was created)
(node:5483) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 1)
(node:5483) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

I solved this problem, "[data-testid=trend]" items never appear on document.
I assume twitter blocks it, and shows "something went wrong" message.


T265 Bug report : Realsense-viewer V2.31  confidence from 3 drop to Nan

Required Info

Camera Model
{ T265 }

Firmware Version
(Open RealSense Viewer --> Click info)

Operating System & Version
Raspbian

Kernel Version (Linux Only)
4.19

Platform
Raspberry Pi 4B

SDK Version
2.31 }

Language
C++

Segment
POSE

Issue Description
Steps :

open realsense-viewer
disable mapping option
start stream
move T265 Camera around until confidence = High (3) , then stop
wait around 10-15 minute
confidence from High drop to Nan

it's a bug , or something wrong ?
thanks

Apologies for the delay in responding.
If the T265 is remaining in place for a prolonged period then it may be losing confidence if it is not detecting any motion, as the T265 uses motion to help it understand its surroundings.  For example, starting with a higher than normal initial movement speed to achieve a high confidence and then dropping to normal speed after that.
Are you still experiencing this problem please, or is it okay to close the case now?  Thanks!


[7.x] Allow queue to be specified per channel

Notification can optionally define queue for each channel via public $onQueues = ['mail' => 'emails', 'channel2' => 'queue2'] -- falls back to existing behavior:  $notification->queue

Heya, tests seem to be failing. Feel free to send in a new pr once you've fixed them.

@driesvints Was the test failing in here due to the issues on 7.x or was it based on the change itself? The only failure I see is the notifications one I saw on other PRs too.

Heya, it seems so yeah. @bholub feel free to send in a new pr.


docs(README.md): adding bolt start command into the list

This is a
[x] Document update
About this change
Adding bolt start command into the README.md list. So that everyone can check the command without look the code implementation

@lukebatchelor @jamiebuilds @DanielRuf Could you take a look in this pull request, please?
Thanks, folks!

Closing this pull request, since it's using yarn to run the command added on package.json


[DOC] pemtrustedcas_content

What do you want to do?

[ ] Request a change to existing documentation
[ ] Add new documentation
[x] Report a technical problem with the documentation
[ ] Other

Tell us about your request. Provide a summary of the request and all versions that are affected.
The pemtrustedcas_content examples on multiple pages is incorrect, as far as I can tell. I will use OpenID Connect as an example, but this seems to affect anywhere pemtrustedcas_content option is used.
Essentially, the example shows this:
config:
  openid_connect_idp:
    enable_ssl: true
    pemtrustedcas_content: |-
      MIID/jCCAuagAwIBAgIBATANBgkqhkiG9w0BAQUFADCBjzETMBEGCgmSJomT8ixk
      ARkWA2NvbTEXMBUGCgmSJomT8ixkARkWB2V4YW1wbGUxGTAXBgNVBAoMEEV4YW1w
      bGUgQ29tIEluYy4xITAfBgNVBAsMGEV4YW1wbGUgQ29tIEluYy4gUm9vdCBDQTEh
      ...

This example seems to imply that one should remove these lines from the certificate:
-----BEGIN CERTIFICATE-----
-----END CERTIFICATE-----

However in my testing, that is not the case and the security plugin will only work properly with those lines. As such, I believe the example used in the documentation should be:
config:
  openid_connect_idp:
    enable_ssl: true
    pemtrustedcas_content: |-
      -----BEGIN CERTIFICATE-----
      MIID/jCCAuagAwIBAgIBATANBgkqhkiG9w0BAQUFADCBjzETMBEGCgmSJomT8ixk
      ARkWA2NvbTEXMBUGCgmSJomT8ixkARkWB2V4YW1wbGUxGTAXBgNVBAoMEEV4YW1w
      bGUgQ29tIEluYy4xITAfBgNVBAsMGEV4YW1wbGUgQ29tIEluYy4gUm9vdCBDQTEh
      ...
      -----END CERTIFICATE-----

I can submit pull request(s) for these changes if this is in fact the case, and my environment isn't behaving differently for some other reason.
What other resources are available? Provide links to related issues, POCs, steps for testing, etc.
Testing should just require adding/removing those lines and testing if authentications are successful. It is possible that this is actually a bug with the OpenID Connect code, and that the example is correct for the other SSO methods. I do not have a test environment setup to confirm that though.

Thanks for submitting this issue, @landon-l8 ! It would be great if you could submit the pull request.
@scrawfor99 - Is this something you can verify? Thanks.

Pull request submitted. I would assume that the private key behaves the same way, but my environment doesn't work to test this very well. Hopefully @scrawfor99 can confirm if I'm correct there.


Gruntfile.js not found

The directions say to use grunt to run this demo but there is no Gruntfile in the master branch.  I saw one in the 1.0 tagged release but that did not work for me.  Am I missing something?
Thank You,
Larry

in #4 i refactored the build process to mimic how things are handled in esri-leaflet and forgot to update the README. instead of making a call to grunt, npm start is now used to trigger a rollup build and recompile when changes to the raw source are detected.
the shorter answer is that the development instructions need to be edited to follow the same pattern as esri-leaflet (and our other plugins).
if you're able to make a pull request to update the documentation, it'd be sincerely appreciated.  if not, i will find time myself sometime soon.

fixed in 29925d7d4ab57661af6135c33269258c5994ca21. don't be shy if you have any other questions.