Support jagged array and array of tables conversion in Nett.AspNet

In one of the programs I'm trying to add TOML configuration support to it needs to convert/bind a section that sort of looks like the following JSON and YAML example.
JSON
{
  "profiles": [
    {
      "name": "profile1",
      "setting1": "somevalue"
    },
    {
      "name": "profile2",
      "setting1": "someothervalue"
    }
  ]
}

YAML
profiles:
  - name: "profile1"
    setting1: "somevalue"
  - name: "profile2"
    setting1: "someothervalue"

TOML
If I understand the TOML spec correctly the above config should be defined as an array of tables like this:
[[profiles]]
name = "profile1"
setting1 = "somevalue"

[[profiles]]
name = "profile2"
setting1 = "someothervalue"

Or with an inlined array of tables:
profiles = [ { name = "profile1", setting1 = "somevalue" },
             { name = "profile2", setting1 = "someothervalue" } ]

But the above example currently throws an InvalidOperationException since the ProviderDictionaryConverter doesn't support processing TomlTableArrays.
Both the JSON and YAML libraries I'm using produce the following data when converting the example:
{ "profiles:0:name", "profile1" },
{ "profiles:0:setting1", "somevalue" },
{ "profiles:1:name", "profile2" },
{ "profiles:1:setting1", "someothervalue" }

Which suggests converting a TomlTableArray should use similar rules as converting a TomlArray, namely appending the current key with the array index of the current item.
Jagged arrays
Jagged arrays can also be supported the same way by recursively calling ProcessArray and appending current index to the full key:
JSON
{
  "jagged": [ [ 1 ], [ 2, 3 ], [ 4 ] ]
}

YAML
jagged:
  - - 1
  - - 2
    - 3
  - - 4

TOML
jagged = [ [ 1 ], [ 2, 3 ], [ 4 ] ]

Produces
{ "jagged:0:0", "1" },
{ "jagged:1:0", "2" },
{ "jagged:1:1", "3" },
{ "jagged:2:0", "4" }

Released with 0.12.0


[Init] Allow overriding of the react-native module from init script

The gist is: REACT_NATIVE_PACKAGE_ID=facebook/react-native react-native init Project if you want to install from somewhere other than the latest package on npm.
This change will need to go in react-native-cli but isn't meant to be user-facing anyway.

:+1:

:+1:

Looks like a good first task.

Hi there! This issue is being closed because it has been inactive for a while.
But don't worry, it will live on with ProductPains! Check out its new home: https://productpains.com/post/react-native/init-allow-overriding-of-the-react-native-module-from-init-script
ProductPains helps the community prioritize the most important issues thanks to its voting feature.
It is easy to use - just login with GitHub.
Also, if this issue is a bug, please consider sending a PR with a fix. We rely on the community to provide
bugfixes as the core team is focused on performance.


Recursive processing of caption nodes to support custom anchor name content

    We can support this, but it since <a> elements can contain nested nodes, the processing needs to be recursive. No biggie. If you insist, I can add this feature. I think that this should b developed when a real need arises and for now, you get either the standard or your own, unprocessed text.

Originally posted by @imdfl in https://github.com/tomerlichtash/mels-loop/pull/302#discussion_r1022669223

Reference: https://github.com/tomerlichtash/mels-loop/pull/302#discussion_r1022357086


Feature: current time parameter in Cicero engine

Implementation note: The currentTime creation expects a strict ISO 8601 syntax with an explicit date, time, and time zone, but no milliseconds. This could be made more flexible, but it seems useful to enforce the presence of a timezone.

Coverage decreased (-0.01%) to 93.134% when pulling 5a53d2d743e7ebdb6171857a8c24465c44d45495 on jeromesimeon:js-feature-currentTime into 0ada6398f587212d62fb3636dd1505209a5a6278 on accordproject:cicero-0.11.


Reval works, but meteor client still refreshes after change

I'm using qualia:reval 1.3.0 on Meteor 1.7.1-beta.14 with Sublime. I'm finding the code patches are happening instantly when I update the code (and they show in the browser) - but a few seconds later the meteor client refreshes ($ => Client modified -- refreshing) - taking away the advantage of using qualia:reval.
No unusual server messages pop up, except for the "Reval dropping patches:" and "Reval patching:" come up.
Any fixes for this?

Nope running it on my normal system - my server seems to be returning the correct times - how would I check if its clock drift?


Functions which aren't a part of a class/trait can't have an access s…

…pecifier
Removed public from function test which was not part of any class/trait in Sample.php(testing data)

@mivanov93 true, thank you for the fix, bug fix release tagged


Added variadic parameter support

Changes since previous (cancelled, which I'm now glad it was) pull request:

Changed behavior in struct-like dereferences is reverted (since I was wrong about the way it works)
Variadic macro support is extended (now named variadics should be supported)
Fixed major issue with variadics where they were not actually coherent with standard positional params and picked up all the positional arguments
Removed whitespace strip in variadics, since their expansion should be literal, and lstripping whitespace in variadic arguments resulted in the expansion being modified in a way it shouldn't be, e.g.:

#define test(...) __VA_ARGS__
test(a, b, c) // a, b, c
test(a, b,c) // a, b, c (wrong, correct way: a, b,c)

All changes are marked with comments starting with # NOTE: , since for some reason unknown to me merge request diffs show the whole file being changed
Expanded tests for variadic macros, added test coverage for changed whitespace strip behaviour in macro arguments

The code seems to pass all the tests.
It is highly recommended to review the new tests and features to ensure full coverage of all the possible cases and full backwards compatibility with the upstream version.

I would be careful what changes you actually commit in future - and would recommend you review your changes as you stage them - making sure you are only committing lines that you intended to touch. This makes it both easier to review, and make sure your not making any mistakes.
For example, you've committed ignore_macro_definitions. I cant tell if this is a feature or merely test code that got accidentally included.
The reason why all the lines are marked as changed is probably due to the line-endings getting changed. I probably started this project on a windows machine.
Normally I wouldn't want to include any test code in the main branch for a feature that doesn't exist in main. You'd be better off writing those tests in a feature branch, and only merge the tests in once they are associated with a working feature. Ensuring that a PR is associated with only the features you want to implement makes it less likely that a crabby old engineer will have lots of nit-picks.
I'll check this over tomorrow.

The ignore_macro_definitions thing was here from the very beginning and I kinda forgot about it.
The reason for including it for me was that it can be an annoyance when the code doesn't work if it encounters a single macro it doesn't support, so I guessed it'd be better to explicitly mark certain macros to be ignored.
I did think of documenting and reviewing this, but then I just forgot I ever did that, so I guess you can consider it "test code". I will probably revert this for now.
And I did reconfigure my editor to preserve line endings to not make things messy in the future, thanks for explaining, I didn't quite think of that.

Cool. I'm going to approve this.
I think in general - there's a bit of a philosophical issue of when to raise errors here.
Errors are raised when expanding a macro with varargs if the varags have been declared out of order, ie,macro(a, ..., b) I feel like this should be raised when the macro is defined, instead of when it is expanded. The expansion/substitution logic should be able to rely on having a valid macro.
I may rework some of this later (when I'm not sick....).

Yeah, I guess you're right.
I suppose a solution would be to include vname as a field in Macro (None if not a variadic), and just move the implementation to Preprocessor.define
I've also noticed that you have this _directive_define_varidic method which handles function-like macro definitions, so I guess it should be called something like _directive_define_function_like
# Rule to handle: #define <token>(<any>) [<expression>]
def _directive_define_function_like(self, args):
    params = [ a.strip() for a in args[1].split(",") ]
    self.define(args[0], args[2], params)

In addition:
As I started playing around with the proposed solution, I encountered an issue where a definition of a function-like macro with no parameters was treated by the code as invalid.
At first I thought that an empty argument can simply be stripped out, however I didn't like making this case identical to a constant macro definition. So I changed this:
# elif re.search(TOKEN_SEARCH_REGEX, args[i]) is None
elif re.search(TOKEN_SEARCH_REGEX, args[i]) is None and not (len(args) == 1 and re.match(r'\s*', args[0]) is not None)

which I consider a stub. The problem is that the code does not actually distinguish between constant and function-like macros, which I've addressed in issue #14, with the key difference between
#define MACRO_C x
// and
#define MACRO_F() x

trivially derived from it.
Fixing the issue could, aside from dealing with unexpected errors, help handling function-macros with no parameters correctly. So, perhaps, removing an empty argument would become a viable and a cleaner option, granted that the macro in question would be acknowledged as being function-like and treated that way further.

Issue of macro functions with zero arguments is started here: #15


WIP: add a flag for passing json to init

fixes #278

I think the fundamental question here is whether the input should overwrite the Cargo.toml completely, or if it should be a set of updates overlayed onto the current value.
Specifically this affects fields that are omitted from the json -- is that "delete the key" or "preserve the old value"?

On config handling rework (stuff now generally works a bit more like oranda config):

I use the "pattern match on the entire config to force people to update key functions" trick

A few functions explicitly ignore the fields with field: _ which is fine, all that matters is that when a field gets added you need to go to that function and take the moment to think if that field can be ignored too

All fields are Options now

Previously we let Vecs be non-optional in more places which was a bit confusing about how they get merged
We do extend exactly one Vec if both workspace and package defines it -- includes
Theoretically this makes sense so you can have files that are included in everything and then packages still have the ability to add some stuff to it, but it's weird that it's inconsistent. It isn't an expressivity limitation, because if people don't want this behaviour they can just not use the global version at all.

In init if a field is None we will delete it from the Cargo.toml

For array fields we will also do it if the array is empty
Now that everything is an option I need to reconsider if that makes sense

In doing this I found a minor bug in how we handle npm-scope (fixed in third commit)


Pass logstash dateformat to elasticsearch plugin

Currently my cluster is not generating enough daly data to warrant a whole index.
Using a pipeline would probably be a preferable solution but I found this was a quick fix for now.

Please generate v0.12 images together.
This causes inconsitent setting between v0.12 and v1.2 images.


A parameter not declared as a rest parameter is not one

Was looking at this with @sandersn yesterday.
Currently we allow this code:
/** @param {...*} a */
function f(a) {
    return a;
}
f(1, 2).push(3);

We think a is a rest parameter because the JSDoc declares it that way, but that doesn't change the fact that it isn't really a rest parameter.

ES3/5 syntax does not allow for dot-dot-dot syntax.
Is there any way to declare rest parameter signature when using TS with ES3/5 JavaScript?

@mihailik I don't think there is, but we'll give you one for free anyway.
function f() {
    return arguments[1];
}

f(1, 2);

@andy-ms that looks like best of both worlds, neat!
However I've just checked with typescript@next the example from the above:
node ./node_modules/typescript/lib/tsc.js multi.js --out multiout.js --allowjs
/** @param {...*} a */
function f(a) {
    return a;
}
f(1, 2).push(3);

Compiles with no error. Either I misunderstood this PR, or something is not right?
To be specific: --version gives Version 2.7.0-dev.20171021, running on Mac.

@mihailik You need --checkJs too or you'll never get errors in .js files.

@andy-ms
Thanks, I got the intended checking — no error on 2.5.2, error on typescript@next. But the magic arguments behaviour doesn't seem to work:
node ./node_modules/typescript/lib/tsc.js multi.js --out multiout.js --allowjs --checkjs
/** @param {...*} a */
function f(a) {
    return [arguments[arguments.length-1]];
}
f(1, 2).push(3);
  ~
multi.js(5,3): error TS2345: Argument of type '1' is not assignable to parameter of type 'any[]'.

To be specific: tsc --version returns:
Version 2.7.0-dev.20171024

That's because it's listening to the jsdoc which declares that a is an array. ...* is treated as the equivalent of any[]. a is the first parameter, not a rest parameter. So it expects the first parameter to be an array.

@andy-ms your original point seems to be correct (same according to Stackoverflow referring to JSDocs spec and Google Closure):
We think a is a rest parameter because the JSDoc declares it that way
Which is opposite to what you're saying right here above:
That's because it's listening to the jsdoc which declares that a is an array
My concern is to make sure idiomatic ES5-style code using rest parameters is handled the right way. Thanks a lot!

Well, in the first example I'm describing a bug! If a really is a rest parameter, then the jsdoc should be declared with ... and it makes sense to give it an array type. You might argue that we should give an error if the jsdoc uses ... but the actual variable doesn't.

@andy-ms looks like we have another bug introduced here. Here's a bit clearer example from above:
node ./node_modules/typescript/lib/tsc.js multi.js --out multiout.js --allowjs --checkjs
/** @param {...number} a */
function f(a) {
    console.log(arguments[0]);
}
f([1, 2]); // this should fail, but passes
f(1, 2); // this should pass, but fails
  ~
multi.js(6,3): error TS2345: Argument of type '1' is not assignable to parameter of type 'number[]'.

This is a valid idiomatic proper JavaScript: declare a function with variable number arguments. Compiler incorrectly assumes the argument is of type number[].

Well, like I said above, we could add a diagnostic for if you declare a rest parameter in JSDoc but the corresponding parameter (a) isn't a rest parameter.

Then it's a regression, unfortunately. That is a valid way to implement rest parameter in ES5.


Impossible to download botsv1-attack-only.tgz

Hello,
First of all, thank you for making this BOTS challenge accessible to relatively new splunkers like me !
However, I'm not able to download the file : "botsv1-attack-only.tgz".
Here's a screenshot showing the error I recieved :

Thank you for your understanding !

Sorry about the perms. Can you try again?


Search filters - Invited member is able to see the disabled tags in tag filter

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 9.0.28-1
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers<EMAIL_ADDRESS>Issue reported by: Applause Internal Team
Action Performed:

Go to staging.new.expensify.com
[User A] Create a new workspace.
[User A] Add a few tags in Workspace settings > Tags.
[User A] Disable all the tags.
[User A] Invite User B to the workspace.
[User B] Go to workspace chat.
[User B] Click + > Submit expense > Manual > Enter amount > Next.
[User B] Note that there is no Tag field on the confirmation page.
[User B] Go to Search > Filters.
[User B] Click Tag.

Expected Result:
Invited member should not able to see the disabled tags in tag filter.
Actual Result:
Invited member is able to see the disabled tags in tag filter.
Workaround:
Unknown
Platforms:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos
https://github.com/user-attachments/assets/ee165020-0dab-4c05-9fc3-61561afe65e0

View all open jobs on GitHub

@johncschuster  FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

Proposal
Please re-state the problem that we are trying to solve in this issue.
User can see the disabled tags in the search filters, which should not be the case, they should be not visible.
What is the root cause of that problem?
The issue occurs because we are not checking whether a tag is enabled when generating the list of tag names.
What changes do you think we should make in order to solve the problem?

https://github.com/Expensify/App/blob/6ef175251d0a6a0c77d86061bb64088d8bc075d0/src/libs/PolicyUtils.ts#L308
To resolve this, we should modify the code to include a check for whether a tag is enabled before adding it to the list of tag names.
https://github.com/Expensify/App/blob/6ef175251d0a6a0c77d86061bb64088d8bc075d0/src/libs/PolicyUtils.ts#L308
It should be wrapped with a condition to ensure only enabled tags are included:
if (tag.enabled) {
    uniqueTagNames.add(getCleanedTagName(tag.name));
}

What alternative solutions did you explore? (Optional)

https://github.com/user-attachments/assets/07726fc8-6036-43e6-98a7-bc11aa913606

I think the behavior should depend on whether or not an expense has been tagged with a given tag. For example, if expenses have been tagged with both Tag A and Tag B, and Tag B is disabled at some point in time, I think Tag B should still be an available filter on the Expenses page.
That said, if Tag B has been disabled and there are NO expenses that have been tagged with Tag B, I would expect Tag B to not show up in the search results.

@IuliiaHerets can you please retest the behavior with the criteria I've shared above?

Hi I'm from SWM and I am currently working on Search v2. Hiding Tag B when there are no expenses tagged with Tag B is a good idea but unfortunately I don't think it is currently possible. Advanced filters get list of all tags from onyx, hence we don't have any information if there exists expense tagged with B.

Thanks for chiming in, @289Adam289! Given the way we handle getting tags currently, does the behavior in this issue sound expected, or do you feel there's still something not quite right here that needs to be fixed?

I agree with @abzokhattab comment https://github.com/Expensify/App/issues/48493#issuecomment-2327070061, so everything works as expected.

Great! If this behavior is currently expected, let's close the issue.


Ignore web-ext-artifacts/ folder

web-ext-artifacts/ contains output files generated by package scripts,
it should not be included in git.

Thanks for quick review!


fixed requirements.txt for installing

fixed the following error:
ERROR: Cannot install mkparse 0.6.0 (from /home/xiaoji/文档/autopkg-make/makefile-parser-python) and mkparse 0.6.0 (from git+https://github.com/Thanatisia/makefile-parser-python) because these package versions have conflicting dependencies.
The conflict is caused by:
    The user requested mkparse 0.6.0 (from /home/xiaoji/文档/autopkg-make/makefile-parser-python)
    The user requested mkparse 0.6.0 (from git+https://github.com/Thanatisia/makefile-parser-python)

Unnecessary change to fix a local development environment issue, closed.


Smoke Tests need to pick up latest versions of core packages

We've seen failures when the transitive closure of package dependencies includes a released core package instead of most recently available core packages. Smoke tests should be running against the most recently published dev packages, including core packages.

Obsolete and done.  Vape tests do this.


Report clearly bids filters

What would you like to see added in fMRIPrep?
It would be nice that the bids filters were reported very clearly in the log file  (and perhaps make them also appear in the config)
cc/ @oesteban
Do you have any interest in helping implement the feature?
Yes
Additional information / screenshots
No response

cc/ @bpinsard - I think I remember he implemented the earliest version of filters?

They should appear in config.execution.bids_filters. Unless you mean you want the final filters, when merged with the default filters, i.e., the queries variable at the end of:
https://github.com/nipreps/niworkflows/blob/master/niworkflows/utils/bids.py#L228-L244

I confirm that the filters do appear in the config.toml.
Logging the final one should be easy to implement.
Adding these to the html reports might require more work.


vite create vue-ts and vscode has installed volar,  but get errors

Please disable volar and check the error still on or not.

still has the error，vscode use ts analyse .vue file not volar
if I add the vetur the error disappeared

Please disable volar and check the error still on or not.

I  found the reason about it.
I should add the setting in settings.json
"files.associations": {
"*.vue": "vue"
}
thank you very much

Usually you don't need to set this, please check whether have "*.vue": "javascriptreact" in global config.


define environment variables

https://github.com/codeigniter4/CodeIgniter4/issues/3138#issue-642431631

Sorry, but we can only merge commits that are signed. You can read more about it here: https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/signing.rst


Nagram fails to start

Latest release Nagram client simply crashes at start with this module enabled.
Tested in different devices, seems the problem is in module itself - doesn't matter Android version.

Hey!
Mostly the reason is some old hooks, I will try update the module this week on my free time.
Thanks for your feedback


Remove internal note link in slack messages

Describe the bug
Internal note link points to a Github pull request and expands every time there is a new slack message.
To Reproduce
Steps to reproduce the behavior:

Do slack integration on Papercups
Send a chat message from Papercups widget
See Github PR link preview in the slack channel

Expected behavior
The link should either be removed or point to a private link that doesn't show preview in Slack.
Screenshots

this should be resolved now, but feel free to reopen if you're still seeing this issue!


Incorporation into bin3C.

I am the author of bin3C and just quickly read through your bioRxiv paper just now. It's exciting to read about new normalisation methods applied to metagenomic Hi-C. I would be interested in testing the effectiveness of HiCzin in bin3C, but I am concerned about the computational requirements. In the figures of the manuscript, is it made clear anywhere the difference in performance between the TAXAassign version and the unlabelled? I think overall an unlabelled approach will probably be a lot easier for end users and novel environments.
Do you happen to have any of the intermediate data files at hand? Such as a normalised contact map and the related contigs?

Hi Matthew,
Thanks for your interest in our new paper. I will soon update our contig
fasta file and will notify you then. The Hi-C contact information can be
obtained from https://github.com/dyxstat/HiCzin/tree/main/data
If you have any questions, welcome to ask me.
Best,
Yuxuan Du
On Mon, Mar 8, 2021 at 5:04 PM Matthew DeMaere<EMAIL_ADDRESS>wrote:

I am the author of bin3C and just quickly read through your bioRxiv paper
just now. It's exciting to read about new normalisation methods applied to
metagenomic Hi-C.
Do you happen to have any of the intermediate data files at hand? Such as
a normalised contact map and the related contigs?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/dyxstat/HiCzin/issues/2, or unsubscribe
https://github.com/notifications/unsubscribe-auth/ANFJC6VSJEMRAVUVN63G3YTTCVXYJANCNFSM4Y2OVU2A
.


Redux state structure for storing the API data

As there will be numerous API calls that will be made to backend we need to have a proper structure to store the API data in redux state. The structure should include:

API name
Unique naming convention to easily identify the API,
Http status code of the fetch operation
Whether the fetch operation is loading
default data
Error handling

Will it be ok to use RTK Query for this purpose ?
This will ensure that all the api logic is stored in one place, and the api hooks can simply be called as and wherever needed

@ksmcod Ideally we want to follow "do not repeat yourself" philosophy and just use a library for this scenario.  But as this is the initial version I wouldn't want to depend on another library. May be we can see in later versions if required. Also we'll reuse the same logic pattern across all the APIs. So if we can come up with a proper structure for one API that's enough for our requirement to apply to all APIs.
On a side note as the project is opensource I wouldn't want it to be locked to depend on too many external  libraries.

common status/response  handler for all APIs
import store from './store'; // assuming you have a configured store
import { apiSuccess, apiError } from './actions';

const handleResponse = async (response, apiName) => {
  if (!response.ok) {
    const { status } = response;
    let errorMessage = 'An error occurred';

    switch (status) {
      case 400:
        errorMessage = 'Bad Request';
        break;
      // more status codes
      default:
        break;
    }

    store.dispatch(apiError(errorMessage, apiName));
    throw new Error(errorMessage);
  }

  const data = await response.json();
  store.dispatch(apiSuccess(data, apiName));
  return data;
};

const fetchWithHandler = async (url, options, apiName) => {
  const response = await fetch(url, options);
  return handleResponse(response, apiName);
};

export default fetchWithHandler;

// redux reducer structure
import { createSlice } from "@reduxjs/toolkit";

const initialState = {
  getProducts: {
    err: "",
    data: [],
  },
  getUsers: {
    err: "",
    data: [],
  },
};

export const apiSlice = createSlice({
  name: "API_ACTION",
  initialState,
  reducers: {
    setAPIdata: (state, action) => {
      state[action.payload.apiName].data = action.payload.data;
    },

    setAPIerror: (state, action) => {
      state[action.payload.apiName].err = action.payload.err;
    },
  },
});

// Action creators are generated for each case reducer function
export const { setAPIdata, setAPIerror } = apiSlice.actions;

export default apiSlice.reducer;

Hi I would like to work on it. Also will appreciate it if you mark this issue with hactoberfest label.

@MrCyberlord Let us  know if you have a better structure than what I have suggested above

@arunkumar413  I am getting this error while starting the backend! Any solution in mind ?

Please log this as a separate issue


Portable server is missing python-tornado dependency

Portable server tarball should include the tornado dependency, to be truly portable.

@bradh: I think including a dependency library inside a package is a bad idea, and I believe it is discouraged in most Linux distributions.
Bundling a library means that every time a new version is released, or a security issue arises, or a performance improvement is implemented, we need to repackage, and re-distribute, and re-install all the software that bundles the library, even no code change occurred in that software.  We do not want to duplicate the effort and spend our precious resources on the work that the package maintainers for each of the OS distributions are already doing.
In addition to that effort, sometimes libraries require to be patched in order to conform to OS distribution policies, or to avoid conflicting with other existing packages in the distribution.  Package maintainers for each distribution test for and fix such problems.  Although such problems seem rather unlikely in this specific case, we can avoid the risk by using the existing distribution packages.

@bradh Also, we have a separate task to create actual OS packages for portable. (https://github.com/google/earthenterprise/issues/71) When we do this, it will specify those dependent packages and they would be automatically installed through the yum or apt command. In the long run, I think that's the best solution.

OK. I can see this both ways - for distro-type packaging, you definitely don't want to bundle, however portable isn't going to be a big win on most Linux installs - you'd normally want server. The case for portable is offline / disconnected / isolated networks. Its often hard to get a single file onto those - pip isn't going to work, and system-wide packages can require extensive regression tests.
Maybe I misunderstood the purpose of the portable tarball? Is that just an intermediate product to input into the OS packaging, rather than an end-product?

For now, it's just a quick fix that's still usable, even if not the most elegant, since complying with various distribution policies can be a rather large effort.
There are probably different ways to work with air-gapped systems.  I think users can still employ one of the existing distributions, and use its packages to deploy software.  It just requires collecting all package dependencies before performing an install.

The tornado was included into Portable  Server tar-ball. Now, when it is open-sourced, it seems even easier to upgrade any third-party tools/libs and build new version of the Portable Server.
I believe it make sense to include the tornado into the Protable Server tar-ball, at least for now, so you will get a working version of the Portable Server.

Maybe the build can make two versions - one without the dependencies (for deployments where you can get at the distro packages) and one with the dependencies (e.g. for where you have an appliance-type device; in our case a NAS box).
Right now, I manually add parts of the tornado tarball to the portable server tarball.

@bradh: Can you help me understand your use case? Are you running an OS distribution for which there is no Tornado package?

The NAS environment (Thecus) is (fairly) loosely Ubuntu 10.04. I haven't tried installing a package, but I don't think tornado was packaged that far back (from https://launchpad.net/ubuntu/lucid/+source/python-tornado).
There are PPAs, I'm just trying to avoid doing multiple installs and modifying the system environment.

@tst-ppenev Yeah, after @bradh and @andreisel's input, I think it does make sense to include Tornado in the tarball. It is all Python-based, right, so we don't have to rely on a full OS package being installed. It's also Apache licensed, so there are no issues there.

@tst-ccamp, @bradh: Yeah, we can add an option for including Tornado.
I think we'd need that to support Ubuntu 10.
You might be able to use one of the new Debian packages, even on an old distribution, or port it, but that may not be easier than bundling.

I think we can just add a scons parameter on whether to bundle or not to bundle


Firelocks close too quickly + other problems

Description

Firelocks close too quickly after prying - it's impossible to go through without being ejected if you're moving too slowly (damage, dragging a body/object, or no gravity causing slower acceleration). Often they also close and separate you from the dragged object, forcing you to stand inside the firelock and drag through

Firelocks have conflicting methods of opening and closing, and do not visually indicate why or how - sometimes anyone can interact with them, other times (usually 'light' spacing) only people with engineering access can, but occasionally they remain closed despite access and will require prying

They cannot be hacked due to lack of wiring UI - they become unopenable or unclosable when bolted without a remote

solution remove firelocks

solution remove firelocks

replace firelocks with tinyfans

has been resolved by #28230


call(d3.axisBottom(d3.scaleTime()) fails in Firefox for particular domains

Using Windows 10, Firefox 49.0.1, Chrome 53.0.2785.116 m (64-bit) and d3 v. 4.2.6.
The code below works in Chrome but fails in Firefox. If I change the first date to "2015-10-12" then works in both browsers.
<!DOCTYPE html>

<meta charset="utf-8">

Sorry, but I’m not able to reproduce this error in Firefox on macOS, and you have not provided enough information to investigate further. Some questions you need to answer if you want me to look again:

What was the expected behavior?
What was the actual behavior?
What time zone are you in?
Do you see the same error if you use d3.utcParse and d3.scaleUtc?
Is the problem in date parsing, or in rendering? Can you reduce the example further (e.g., to just date parsing, or just axis rendering, say by using interval.range?

I did notice that your SVG element is missing a height attribute, which could cause the SVG to not display on some browsers.
The only other thing this might be related to is d3/d3#1197 d3/d3-time#1 d3/d3-time#1 d3/d3-time#2 d3/d3-time#3. If that’s the issue here, it could be a browser bug which is not feasible to workaround in d3-time.
When reporting an issue, please include a link to a live example, preferably on bl.ocks.org or RunKit, or as a pull request in the appropriate repository with new unit tests, that demonstrates that the described behavior is not the expected behavior. Use only the minimum amount of code necessary to reproduce the unexpected behavior.
A good bug report should isolate specific methods that exhibit unexpected behavior and precisely define how expectations were violated. What did you expect the method or methods to do, and how did the observed behavior differ? The more precisely you isolate the issue, the faster I can investigate.
Non-actionable bugs may be temporarily closed until you provide additional information. If you can’t isolate the bug any further, please let me know and I will try to help. However, I beg your patience: I must balance your request against many other responsibilities—fixing other bugs, answering other questions, new features, new documentation, etc. Please also consider asking for help on Stack Overflow.
If you have a question about D3’s behavior and want to discuss it with other users, also consider the d3-js Google Group or joining the d3-js Slack.
Thank you! 🤗

Thank you very much for taking the time to give this important orientation. I perfectly understand and I appreciate that. I'll put more work on this issue and if I find something worth of note I'll get back here.

@mbostock , your suggestion to use d3.utcParse and d3.scaleUtc did the trick. Now Firefox is working as expected. Thank you.


Fixed #26024 -- Fixed regression in ConditionalGetMiddleware ETag support.

buildbot, add to whitelist.

Did you check if there's a reason that the quote stripping can't happen in get_conditional_response()?

@timgraham there are 2 other places where get_conditional_response():

CommonMiddleware which is stripping the quotes
django.views.decorators.http.condition decorator for which you give a callable that computes the etag/last modified and uses them in the get_conditional_response(), I'm not sure if we should actually strip the quotes here.

@syphar, as the author of the patch that caused the regression (7a40fef17ab7918cbb1ddc3ba080f42b420f7a48), do you have any advice?

@timgraham @samifahed I looked into it.
IMHO:

etag-unquoting stripping has to stay separate from get_conditional_response because the @condition decorator uses the result of the callable to get the etag. Only alternative would be to let the decorator do quote_etag and then later on unquote_etag in get_conditional_response later on ...

I agree it's a little unclean, since unquoting the etag from the If-None-Match header happens in parse_etags which is called inside of get_conditional_response.

what both fixes forget is that quote_etag does more than adding quotes. This has to be properly reverted too.

My approach would be something like this here:
https://github.com/django/django/compare/master...syphar:fix_etag

I agree with @syphar's approach, what do you think @timgraham?

@timgraham I updated the PR with @syphar's commit, I think it makes more sense. I'll be glad to fix it if there is anything missing in it

How about some unit tests for the unquote_etag() function?

@timgraham https://github.com/django/django/pull/5919/files#diff-01a1ff7510f29ab8ea151390573f5736R164

I could provide more if needed :)

As long as it fails if any part of etag.strip('"').replace('\\"', '"').replace('\\\\', '\\') are removed, it should be sufficient. Sorry for my blindness. :-)

merged in 186b6c61bfe85afa4d6bf213d04a28dd2853fed2, thanks!


Add LATTE

Checklist

[ ] Used a personal fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.
I do have some suggestions for making it better though...
For recipe:

License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

Documentation on acceptable licenses can be found here.

@conda-forge-admin, please rerender

Some Mac tests fail with:
Collecting package metadata (current_repodata.json): ...working... failed

CondaHTTPError: HTTP 000 CONNECTION FAILED for url <https://conda.anaconda.org/conda-forge/osx-64/current_repodata.json>
Elapsed: -

An HTTP error occurred when trying to retrieve this URL.
HTTP errors are often intermittent, and a simple retry will get you on your way.
'https://conda.anaconda.org/conda-forge/osx-64'

+ return

But the rest looks fine.

@conda-forge-admin restart ci


Settings: background sync setting stays disabled

if you disabled the background sync.
Reported at https://matrix.to/#/!GnEEPYXUhoaHbkFBNX:matrix.org/$15210192563891182JfTqC:matrix.org.
The reason was found by @hrj in https://github.com/vector-im/riot-android/issues/2044#issuecomment-373009853.

This is happening to me on F-droid riot. Started after most recent update (0.8.5 to 0.8.7). The rage shake option has no effect.

Nevermind, this is better described in #2196


Add tiered storage configuration

When the Kafka client fetches an offset range that isn’t available locally in the Redpanda data directory, Redpanda downloads remote segments from cloud storage. These downloaded segments are stored in the cloud storage cache directory. The cache directory might be created in the Redpanda data directory, but iops will be split among cache and hot segments. In the case where performance and latency is important separated local storage should be used for cache directory.
The tiered storage mimic Redpanda data dir configuration.
Tiered storage is guarded by the presence of license_key or license_secret_ref.

I found that upgrades will be not possible with this version. I will write the release notes in the README.md how to enable tiered storage cache via manual update.
helm upgrade --install --namespace redpanda --create-namespace redpanda charts/redpanda --set storage.tieredConfig.cloud_storage_enabled=true --set image.tag=v22.3.10 --set license_key=test --set storage.tieredConfig.cloud_storage_cache_directory=/some-path/ --set storage.tieredStoragePersistentVolume.enabled=true --set storage.tieredConfig.cloud_storage_cache_size=20Gi
Error: UPGRADE FAILED: cannot patch "redpanda" with kind StatefulSet: StatefulSet.apps "redpanda" is invalid: spec: Forbidden: updates to statefulset spec for fields other than 'replicas', 'template', 'updateStrategy', 'persistentVolumeClaimRetentionPolicy' and 'minReadySeconds' are forbidden

Yes, please ping me and I can do ad-how presentation.


Overlay data on student profile graph or dashboard view

In our meeting with the Healey 5th grade team yesterday, we heard feedback that the graph would be even more useful if different data series could be overlaid onto the same graph. That would let them see historical information about attendance, assessments, and behavior in the same view and look for patterns. Each data series would be turned on or off with a mulitselect.
A few reference points:
Highcharts compare
http://www.highcharts.com/stock/demo/compare
Google Finance graphs
https://www.google.com/finance?q=INDEXDJX%3A.DJI%2CINDEXSP%3A.INX%2CINDEXNASDAQ%3A.IXIC&ei=Y0xuVZnjBs3nqAHSsoLQDQ

@alexsoble I added test results to the student view page and included all datasets on one chart.  I'm not too familiar with highcharts, but the test results should be on a separate scale.

The branch is demo-data-refinement and requires a migration to get working.  Didn't want to do a pull request as I had to wing how the testing works, so think of this as more of a demonstration

Hey @thfield! This screenshot raised lots of good questions! @marimuraki @AmirHadjihabib and I were debating & discussing them this morning. Here are some of the questions we are wondering about:

What makes sense to compare?
How do we display data in a way that maximizes insight but minimizes overload/confusion?

Also cc'ing @jsgeiser. Let us know what you think about the concept of combining different data series into one graph. Have you seen any examples where this is done really well? Or poorly?

I like this way of looking at the data. I haven't seen it done before where the teacher can create the graph with data they would like to see. Would it be possible to click on the data points they want to put in the graph to show at one time? For example, if a teacher wants to compare only absences and math growth, they would click on those two boxes. Then they can add (e.g. ELA growth) if they want by clicking on that box. They would then have control over what appears at the same time. Would that work?

@alexsoble @AmirHadjihabib What do you think of overview dashboard view to address the teachers ask for e.g., attendance and scores are correlated by having a single graph that displays these two metrics. One way we may do this without creating complicated overlays of different metrics is to do a dashboard view.
Here is Miguel's suggestion:
"I imagine you played with the idea of including 5 small graphs (one for each topic), creating a dashboard for each student. I like that approach because it gives you that overview across years and across topics. If the user clicks on one of those smaller graphs you could expand and display it as it is now."
What do you think?

@alexsoble @AmirHadjihabib: What do you think of something like this? Not a priority but an idea of how to address the teachers & principals feedback on wanting to see the relationship between [X] vs [Y] over time.

How is my student's performance related to his/her attendance over time?
How is my student's performance related to his/her behavior incidents over time?

Seeing this kind of relationship would be helpful. I would have it as an option to create (e.g. select boxes of what you want to see, attendance and MCAS, or behavior and STAR, etc.) and not necessarily on a main page.

@marimuraki @jsgeiser – I agree that having this on a separate page (not necessarily the main page) is a good idea. Too many graphs on the profile would make it very busy. I also think we should put this feature idea on hold for now, lower priority compared to the other features we need to build in order to launch and test the tool at Healey school.

@marimuraki — These spark notes you designed! They are going into the next iteration of the student profile. Check it out: https://github.com/codeforamerica/somerville-teacher-tool/issues/373#issuecomment-175105589
Last year I was nervous about adding too much front-end complexity too fast, but with @kevinrobinson on board we have been shipping fantastic front-end features in leaps and bounds. Thanks to him now is a great time to add this feature.


[APPLICATION] exam play game

Project Abstract

Please replace these instructions with a brief description of your project summarising key points (1-2 paragraphs).

Application Checklist
[x] The application template or delivery template has been copied and aptly renamed for an application (project_name.md) and a delivery (project_name_m1.md).
[x] I have read the games bounty guidelines.
[x] Payment details have been provided (Polkadot address in the application).
[x] The initial PR contains only one commit (squash and force-push if needed).

Great

All good


Overlay of task tiles onto campaign - Possible to open tasking manager from these?

The title says it all. Right now the tiles from a task in the tasking manager can be overlaid on top of a campaign....to what end? I don't see them having any functionality yet (is something planned)
It would be great if, when I click on a tile, it gives me the option to jump to another window with that tile opening on the tasking manager. Note, I said option. It might be irritating if it did it automatically when a user clicked on a tile

Yeah, I'd definitely like to see further integration with the TM - including pulling/pushing tasks (and collections of those/portfolios)


fix(analyzer): Error on unexpanded star expression

If a query includes a star reference, error if we're unable to expand that reference. The new analyzer will happily anaylyze that code. If executed at runtime, these queries could change values.
Fixes https://github.com/sqlc-dev/sqlc/issues/2880

Hi @kyleconroy,
I'm experiencing an issue with sqlc when trying to infer the schema solely from my database, without relying on schema files. The reason for this approach is that Postgres supports a wide range of features, including function overloading, which can be challenging for sqlc to fully support.
When I attempt to fetch data using a query like SELECT * FROM table, I encounter an error stating star expansion failed for query. However, if I comment out the line that triggers this error, everything works as expected.
I'm wondering if there's a workaround or a nice way to handle the star expansion feature in this scenario. Any guidance would be greatly appreciated.
Thanks in advance.


how to order posts by newest first

I'd like to reverse the order in which posts appear from newest first to oldest first (without specifically adding weights to each post in frontmatter if possible). How do I do that?

@heaversm an option has been added to reverse the homepage post order https://github.com/zerostaticthemes/hugo-winston-theme/blob/master/exampleSite/config.toml#L25


Fix incorrect AtSync barrier check

This is a bug in LB, which had been incorrectly discussed in core in the past. This fix should make its way to the new LB framework as well.

The changes look good to me, as far as fixing the bug. But it is weird that this bug was there, since the code seems to have been written to handle the case where a client can call AtSync multiple times before the barrier is reached (otherwise it could have been written in a simpler way).
Eric, do you have a test case where it previously failed and it works with your fix?
My main concern is if we really need to handle this case. Do we have a use case for it? For me it seems it would be easier for users to understand if we require a resumeFromSync to happen after an AtSync, and thus it would be an error to call AtSync two times in a row without resumefromsync in between. I'm also wondering if allowing multiple AtSyncs in a row would work well without triggering bugs in other parts of the runtime or application.
Also, the current mechanism to check the local barrier is not very efficient (going through all the clients to see if all of them have reached the barrier). Granted, this only happens when at least client_count have called AtSync, but if you have thousands of chares and you can achieve the same with a simple counter that would be better.


Animations to the text and buttons can be implemented

Assign it to me for faster execution and implementation

Thanks for volunteering!
If you want to briefly describe what you're thinking before doing it we could discuss design before-hand, but if you want to just send a PR (ideally with video demonstrating the change) then you're welcome to do that too.

Hey @NishantRana07, thanks for taking up this issue. I would like to recommend focusing on simple animations (if you can achieve it with TailwindCSS classes, it's most likely simple) and not complex animations that would require an additional library.
This is because some areas of the frontend will still be changed, are experimental, or need some refactoring before mounting animation logic. Implementing advanced animations now will add friction on iterating the frontend in the future. Once we reach a relatively stable state with the frontend, we will most likely create a separate branch for all the fancy animations.
There are still many animations you can go for, a couple are:

Animated modal backdrops
Hover-effect on buttons
Responsive inputs


Added css styling and fixed javascript

Hi looks nice however it looks like there is a merge conflict because we merged an earlier pull request. We will happily merge if you have time to fix the conflict :)

Great!


XlsWorkbookReader+RecordReader

XlsWorkbookReader+RecordReader
The ReadStringBuffer method in the XlsWorkbookReader+RecordReader class needs to be appended with System.Text.Encoding.RegisterProvider(System.Text.CodePagesEncodingProvider.Instance); Otherwise, an error will occur when reading Unicode content.

The expectation is that the user of the library will call that before using the .xls reader if that's something they need support for.  I should call this out in the documentation though. Thanks.


Percentage circle - single task progress

Is it posible to create something like this?

If there isn't, would you consider adding it to the available charts? The text inside the circle could be anything, not necessarily a percentage (see demo link below)
Here is a link with a pure CSS solution: http://circle.firchow.net/
A jQuery implementation: https://github.com/thodorisbais/percircle
And with animations: https://thodorisbais.github.io/percircle/

Please ask questions on StackOverflow: https://stackoverflow.com/questions/tagged/chart.js

For what I've read this is currently no possible.
So, would you consider adding it to the available charts in a future release?

@mcanepa That's an old request, widely discussed in #78 for which you have many solutions such as plugins or custom implementation. Currently, we don't plan to add this feature in core.

So this is a feature that a lot of people is asking for since 2013 and yet it won't be added to the charts.
I get that it could be accomplished with a plugin, but it's always nice and better if it's included in the core.


when to support RecurrentGemma?

The recurrent gemma code repo is here: https://github.com/google-deepmind/recurrentgemma
Closing this for now.


Update example for REPL usage per #70 on docs

as indicated in https://github.com/ramda/ramda.github.io/pull/70

LGTM. This is to avoid a collision between the example variable name (append) colliding with a const variable from R.

Thank you!  Nice catch.
:herb:


ERROR in ./src/app/app.module.ngfactory.js Module not found: Error: Can't resolve '@angular/cdk/a11y' in <Path -to-the-main-application>\src\app resolve '@angular/cdk/a11y' Parsed request is a module

Angular CLI: 9.0.3
Node: 10.13.0
OS: win32 ia32
Angular: 9.0.2
... animations, common, compiler, compiler-cli, core, forms
... language-service, platform-browser, platform-browser-dynamic
... router
Ivy Workspace: No
Package                            Version
@angular-devkit/architect          0.900.3
@angular-devkit/build-angular      0.900.3
@angular-devkit/build-ng-packagr   0.900.3
@angular-devkit/build-optimizer    0.900.3
@angular-devkit/build-webpack      0.900.3
@angular-devkit/core               9.0.3
@angular-devkit/schematics         9.0.3
@angular/cdk                       9.1.0
@angular/cli                       9.0.3
@angular/material                  9.1.0
@ngtools/webpack                   9.0.3
@schematics/angular                9.0.3
@schematics/update                 0.900.3
ng-packagr                         9.0.1
rxjs                               6.5.3
typescript                         3.7.5
webpack                            4.41.2
I get the above error on installing and building the Angular library with aot flag in an Angular application. I initially thought it's an issue with Angular material, but I get the same set of errors while building another Angular library in another Angular application for angular/fontawesome library.
I have created a prototype of this application.
github.com/shikha-ai/angular is where I have pushed my Angular library code and
github.com/shikha-ai/testapplication is where I have pushed my main application code.

Hi @shikha-ai, is this still an issue?

Thanks for reporting this issue. However, you didn't provide sufficient information for us to understand and reproduce the problem. Please check out our submission guidelines to understand why we can't act on issues that are lacking important information.
If the problem persists, please file a new issue and ensure you provide all of the required information when filling out the issue template.


fix: (AAP-29719) - enable verify_ssl to skip ssl verify during pulling image from registry

https://issues.redhat.com/browse/AAP-29719

@hsong-rh Do we need a fix for the case of k8s?

@hsong-rh Do we need a fix for the case of k8s?

This fix only focuses on Podman, K8S needs a different approach, check https://redhat-internal.slack.com/archives/C053CJ4JFP1/p1724334196434219 for details.


Charts in the local cluster are not displayed after a restore

Version: master-head(master-33f755f1809e5cb14b7749af462be8b8db240278-head)
Steps:

Create a HA setup using RKE nodes.
On the local cluster, add a repo https://github.com/rancher/charts
Create a downstream DO cluster and enable monitoring and istio
Create another custom cluster and deploy monitoring
Create an EKS clsuter
Deploy BackupRestoreOperator Chart in the local cluster and take a backup bkp1
Restore to bkp1 on a new RKE cluster using the below steps:

a. Install the backup-restore-operator chart on the new cluster using Helm CLI
b. helm repo add rancherchart https://charts.rancher.io
c. helm repo update
d. helm install backup-restore-operator-crd rancherchart/backup-restore-operator-crd -n cattle-resources-system --create-namespace
e. helm install backup-restore-operator rancherchart/backup-restore-operator -n cattle-resources-system
f. Restore from backup using a restore CR and prune must be set to false.
g. If using certificates issued by Rancher’s generated CA, follow steps to install cert-manager from rancher HA install docs
h. Upgrade rancher release. If on the previous cluster rancher deployment was scaled down, you can also set the right scale (3) through the upgrade command

helm upgrade rancher rancher-alpha/rancher --version 2.5.0-alpha1 --namespace cattle-system
--set hostname=<same hostname as first rancher server> --set rancherImageTag=master-head

After restore, the charts in the local cluster are not displayed. The repositories are displayed correctly

Note:
Charts in the downstream clusters are displayed as expected.
Monitoring and istio are enabled and running in the downstream clusters and EKS cluster is also running after restore.

@soumyalj @sowmyav27 so we can close out this issue then?https://github.com/rancher/backup-restore-operator/issues/6

As part of testing this issue, verify only clusterrepos.catalog.cattle.io is available in the default rancher-resource-set.

Tested with the steps above with restore to master-head(8fd81a9b46847317a)
After restore, one of the charts in the local cluster is missing.

The repository exists:

that's weird, worked when I was testing, I'll look at the setpu

The test setup didn't seem to use the right rancher-resource-set. I'm assigning it over to test, can you share the resource-set on your setup before the backup? @soumyalj

On master-head - commit id: f8bad24e

On a restore , custom repo and the repos and charts were available

Verified with the steps above with restore to master-head(f8bad24ea762823ec0305a)
After restore, charts in the local cluster are displayed correctly.

Repositories are also displayed correctly.

Resourceset on master-head - commit id f1a410a97 has
- apiVersion: apiextensions.k8s.io/v1beta1
  kindsRegexp: .
  resourceNameRegexp: management.cattle.io$|project.cattle.io$|catalog.cattle.io$|eks.cattle.io$|resources.cattle.io$
- apiVersion: catalog.cattle.io/v1
  kindsRegexp: ^clusterrepos$


Update unit tests for BrokerPodsBreadcrumb component

Update unit tests for BrokerPodsBreadcrumb component to cover all edge cases.

Closed as completed.


Behavior of behavior

Hi,
I find the behavior option a little confusing, maybe it would be convenient to describe the difference between auto and smooth, which is (according to the draft):

auto: The scrolling box is scrolled in an instant fashion.
smooth: The scrolling box is scrolled in a smooth fashion using a user-agent-defined timing function over a user-agent-defined period of time. User agents should follow platform conventions, if any.

Regarding the code:
https://github.com/mkay581/scroll-js/blob/e3063f824f1925b386b3fc2a0a59d2abb656e2a4/src/scroll.ts#L136-L143
It looks like it is not draft compliant (or maybe I'm wrong 😅). But I have no idea on how to retrieve this info from the user agent.
For me the current implementation is completely okay, but I am missing a little bit of explanation at the README.
What is your opinion @mkay581? Should I submit a PR adding this explanation to the README?
Thanks!

Hey! Yes, the idea is that this package should follow the spec as much as it can. I'm all for updating the README if it helps to better explain how the package works. But what specifically about the behavior do you think needs to be updated on the README? Are you saying "instant fashion" doesn't not mean the duration should be 0?

closing this due to inactivity. Feel free to comment if you are still running into issues.


(fix) SSRPlugin: Don't reference default deferred lighting pass if it doesn't exist

Fixes a crash when using deferred rendering but disabling the default deferred lighting plugin.
The Issue
The ScreenSpaceReflectionsPlugin references NodePbr::DeferredLightingPass, which hasn't been added when PbrPlugin::add_default_deferred_lighting_plugin is false.
This yields the following crash:
thread 'main' panicked at /Users/marius/Documents/dev/bevy/crates/bevy_render/src/render_graph/graph.rs:155:26:
InvalidNode(DeferredLightingPass)
stack backtrace:
   0: rust_begin_unwind
             at /rustc/90b35a6239c3d8bdabc530a6a0816f7ff89a0aaf/library/std/src/panicking.rs:665:5
   1: core::panicking::panic_fmt
             at /rustc/90b35a6239c3d8bdabc530a6a0816f7ff89a0aaf/library/core/src/panicking.rs:74:14
   2: bevy_render::render_graph::graph::RenderGraph::add_node_edges
             at /Users/marius/Documents/dev/bevy/crates/bevy_render/src/render_graph/graph.rs:155:26
   3: <bevy_app::sub_app::SubApp as bevy_render::render_graph::app::RenderGraphApp>::add_render_graph_edges
             at /Users/marius/Documents/dev/bevy/crates/bevy_render/src/render_graph/app.rs:66:13
   4: <bevy_pbr::ssr::ScreenSpaceReflectionsPlugin as bevy_app::plugin::Plugin>::finish
             at /Users/marius/Documents/dev/bevy/crates/bevy_pbr/src/ssr/mod.rs:234:9
   5: bevy_app::app::App::finish
             at /Users/marius/Documents/dev/bevy/crates/bevy_app/src/app.rs:255:13
   6: bevy_winit::state::winit_runner
             at /Users/marius/Documents/dev/bevy/crates/bevy_winit/src/state.rs:859:9
   7: core::ops::function::FnOnce::call_once
             at /Users/marius/.rustup/toolchains/stable-aarch64-apple-darwin/lib/rustlib/src/rust/library/core/src/ops/function.rs:250:5
   8: core::ops::function::FnOnce::call_once{{vtable.shim}}
             at /Users/marius/.rustup/toolchains/stable-aarch64-apple-darwin/lib/rustlib/src/rust/library/core/src/ops/function.rs:250:5
   9: <alloc::boxed::Box<F,A> as core::ops::function::FnOnce<Args>>::call_once
             at /Users/marius/.rustup/toolchains/stable-aarch64-apple-darwin/lib/rustlib/src/rust/library/alloc/src/boxed.rs:2454:9
  10: bevy_app::app::App::run
             at /Users/marius/Documents/dev/bevy/crates/bevy_app/src/app.rs:184:9
  11: bevy_deferred_test::main
             at ./src/main.rs:9:5
  12: core::ops::function::FnOnce::call_once
             at /Users/marius/.rustup/toolchains/stable-aarch64-apple-darwin/lib/rustlib/src/rust/library/core/src/ops/function.rs:250:5

Minimal reproduction example:
use bevy::core_pipeline::prepass::{DeferredPrepass, DepthPrepass};
use bevy::pbr::{DefaultOpaqueRendererMethod, PbrPlugin, ScreenSpaceReflections};
use bevy::prelude::*;

fn main() {
    App::new()
        .add_plugins(DefaultPlugins.set(PbrPlugin {
            add_default_deferred_lighting_plugin: false,
            ..default()
        }))
        .add_systems(Startup, setup)
        .insert_resource(DefaultOpaqueRendererMethod::deferred())
        .run();
}

/// set up a camera
fn setup(
    mut commands: Commands
) {
    // camera
    commands.spawn((
        Camera3d::default(),
        Transform::from_xyz(-2.5, 4.5, 9.0).looking_at(Vec3::ZERO, Vec3::Y),
        DepthPrepass,
        DeferredPrepass,
        ScreenSpaceReflections::default(),
    ));
}

The Fix
When no node under the default lighting node's label exists, this label isn't added to the SSR's graph node edges. It's good to keep the SSRPlugin enabled, this way, users can plug in their own lighting system, which I have successfully done on top of this PR.

Did a force push to run rustfmt, had the IDE setup a bit wrong

A current workaround for this issue is to simply re-use Bevy's NodePbr::DeferredLightingPass as the label for your own custom lighting pass node.


Game crashes and mobs die

Hello, I have 2 issues:
The first (and kind of most important one) is that whenever the Scythe pillager spawns the game crashes:
The game crashed whilst exception ticking world
Error: java.lang.IllegalArgumentException: class io.github.jamalam360.reaping.pillager.ReapingPillager is not an instance of interface net.minecraftforge.entity.IEntityAdditionalSpawnData;
Second: when i try to harvest mobs.
I've only used the iron Scythe so far but sometimes mob just insta die instead of becoming younger. I've still not understood the pattern, since it seems pretty random (up to now chicke ALWAY die, pigs have yet to die, cows are about 50/50, still need t try on other mobs)
I play on forge, 1.20.4. Do you need any info (like other mods I have installed, etc)?

For the second issue, there is a chance that entities die when you reap them. The chance lowers with the sharpness enchantment level, and with having a higher tier reaper (better material: diamond has less chance of death than iron etc.)
I'll look into the crash later on


Include subpackages in init.py #1309

Fixes https://github.com/biocore/scikit-bio/issues/1309. the following example no longer fails with an AttributeError, all other sub-modules are already accessible:
import skbio
skbio.diversity
skbio.stats.evolve

Not sure if we want to add to __all__, since wildcard imports ( from skbio import * ) should be avoided (PEP8).

Thanks @hotdogee!


Implement naive get-ing of namespaced resource

Contributes to #45.
This commit introduces a very naive function to get (as in kubectl get) a namespaced resource. It has no completion support, no interactive support at all, and has no caching support whatsoever.
It's a start.

Codecov Report
Base: 50.30% // Head: 51.33% // Increases project coverage by +1.02% :tada:

Coverage data is based on head (43d2634) compared to base (5090b85).
Patch coverage: 76.92% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #53      +/-   ##
==========================================
+ Coverage   50.30%   51.33%   +1.02%
==========================================
  Files           2        2
  Lines         324      337      +13
==========================================
+ Hits          163      173      +10
- Misses        161      164       +3

Impacted Files
Coverage Δ

kele.el
63.75% <76.92%> (+0.75%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Fix import bug.

My editor (Eclipse/PyDev) does some static analysis and it flags up this line as a bug, because 'six' is not imported.
I guess this has never actually been exercised ?
I s'pose, ideally, all codepaths would be tested ...

Oh dear... something for me and/or @lbdreyer to work on I guess.

Thanks for pointing this out @pp-mo !
We chose not to add so many tests for this bit of code because it was only in experimental... but I was concerned with this decision, and what you found proves the risk of making that decision...
I am shortly going to add a PR that includes a test for regridding cubes with aux_factories which would use this code (and would have flagged up the missing import).


Cannot export ARM template for alerts

Having entered new alerts they cannot be exported in an ARM template, which makes creating alerts in a template much trickier. Is there any plan to fix this?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: abdff578-da95-2c6c-98a8-e78242c0b0b8
Version Independent ID: d02a8eab-22e9-e746-dcf8-9880473d3693
Content: Migrate your classic alerts in Azure Monitor by using the voluntary migration tool
Content Source: articles/azure-monitor/platform/alerts-using-migration-tool.md
Service: azure-monitor
Sub-service: alerts
GitHub Login: @snehithm
Microsoft Alias: snmuvva

Thanks for your comment. We are actively investigating and will get back to you shortly. Thanks for your patience.

@stuarthallows this is really valid feedback and we recommend sharing this
Thanks for your valuable feedback. We request you post this feedback directly  so the responsible engineering team can review and consider adding to a future iteration of the service. This also allows other users to comment and upvote on your idea which helps us with overall prioritization of features.
we will now close this issue and look forward to your update on the feedback channel shared above.

See https://feedback.azure.com/forums/602299-azure-monitor-alert-management/suggestions/35183149-add-ability-to-export-definition-of-an-alert-as-a
Workaround: Get the ARM template from the request body from the activity log entry (notification history of your subscription) after creating an example alert.
Then convert the escaped JSON string back to JSON, for example by using https://www.freeformatter.com/json-escape.html#ad-output

@femsulu WHY IT WAS CLOSED?


Remove IModelBindingMessageProvider interface

See the discussion at https://github.com/aspnet/Mvc/pull/6055#discussion_r109267027
Basically, we don't really want to have interfaces for this sort of thing. But currently we do because:

When @dougbu tried to not have an interface for this before, he encountered some issue to do with overridable setters or something - not sure of the details
Removing the interface would mean moving the .resx file from the Mvc.Core project to the Abstractions project, and figuring out whether this has effects on build or localisation

@SteveSandersonMS - let's try the highly-virtual-class approach here.
And, please post an Announcement for this, because this breaking change will certainly affect some users.

@Eilon OK. Who's best to ask about what consequences (if any) there are with moving a .resx file across projects? As in, is there some external list of .resx files or other localisation things that has to be updated too so that when we ship a release, somehow translations get done into other languages?

@SteveSandersonMS moving a .resx file is identical to deleting an internal one place and adding something similar elsewhere i.e. there's nothing to see here.
However, why do you need to move the .resx file or even some of the resource definitions? As @rynowak said, "The initialization code can still life [sic] in Mvc.Core."

"The initialization code can still life [sic] in Mvc.Core."

Where do you see that?

moving a .resx file is identical to deleting an internal one place and adding something similar elsewhere i.e. there's nothing to see here.

OK, that's good. I still don't know by what magic process we end up having multilingual releases of the framework (i.e., how some third-party vendor (presumably) gets notified to do translations and how they know where to find the .resx files, etc.), but I'll trust that the magic is sufficiently good that everything still happens properly even if files are moved around.

The initialization code can still life [sic] in Mvc.Core.

@rynowak, you said it here.
OK, I'll try to leave it there if I can.

Nothing is actually translated right now, so if a RESX needs to move, it's conceptually just like moving any other file around.
As far as the overridable setters problem, I have no idea what that could be, so I'd say charge ahead and see what you run into.

Posted announcement: https://github.com/aspnet/Announcements/issues/240


PowerShell Class Not Handle System.Data.DataTable as Function

Prerequisites

[X] Write a descriptive title.
[X] Make sure you are able to repro it on the latest released version
[X] Search the existing issues.
[X] Refer to the FAQ.
[X] Refer to Differences between Windows PowerShell 5.1 and PowerShell.

Steps to reproduce
I wrote a code to convert arrays to datatable. However, the codes work when with Function but not working with Class as PowerShell failed to process.
Expected behavior
return datatable

Actual behavior
failed to return datatable

Error details
Line |
  59 |           Return $DataTable
     |                  ~~~~~~~~~~
     | Cannot convert value "" to type "System.Data.DataTable[]". Error: "Cannot convert the "System.Data.DataRow" value of type "System.Data.DataRow" to type "System.Data.DataTable"."

Environment data
Name                           Value
----                           -----
PSVersion                      7.3.1
PSEdition                      Core
GitCommitId                    7.3.1
OS                             Microsoft Windows 10.0.14393
Platform                       Win32NT
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0…}
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>
WSManStackVersion              3.0

Visuals
class OutDataTable{
#define input as array
[System.Array[]]$source
#main function to convert array to datatable
[System.Data.DataTable[]]CovertToDataTable([System.Array]$source){
    #set up colunms
    $columns = $source[0] | Get-Member -MemberType NoteProperty | Select-Object -ExpandProperty Name
    $dataTable = New-Object -TypeName System.Data.DataTable
    foreach ($column in $columns)
    {
     $dataTable.Columns.Add("$($column)")
    }
    #For each row in source, build row and add to DataTable.
    foreach ($entry in $source)
    {
     $dataRow = $dataTable.NewRow()
        foreach ($column in $columns)
        {
        $dataRow["$($column)"] = if($null -ne $entry.$column){$entry.Column}else{$null}
        }
        $DataTable.Rows.Add($dataRow)
    }
    #return datatable
     Return $dataTable
}

}
$adUser = Get-ADUser test2
$adData = [OutDataTable]::new()
$adDataTable = $adData.CovertToDataTable($adUser)
$adDataTable.Columns.columnname

Hi Michael Klement,
I did appreciate your help. Yes, I'm so surprised about that (I had gone thru for the Class documentation on the MS official website for times but found nothing). Now the issue is solved with your suggestion. Thank you again.

You're welcome, @cssjun, but I realized that while my workaround was effective, the explanation needs to be more nunanced:

You've definitely hit an edge case, because you generally need not worry about preventing enumeration via the return keyword in class methods; e.g.:

# OK: the [object[]] array effectively created by 1..3 is cast to [int[]] on return.
class Foo { static [int[]] Bar() { return 1..3 } }; [Foo]::Bar()

Using a single [System.Data.DataTable] instance as the return value works fine too - and that would have sufficed in your case (see bottom section).

The problem is specific to when you're effectively nesting enumerables, such as using array of elements whose types are themselves enumerables and you're trying to situationally return just one instance.

The non-obvious fact that PowerShell considers [System.Data.DataTable] enumerable obscures that fact, and the fact that it enumerates a different type, namely its rows, ([System.Data.DataRow]) breaks the cast to [System.Data.DataTable[]] that PowerShell attempts (which could be considered a blessing - see below).

class Foo {
  static [System.Data.DataTable[]] Bar() {
    $dt = [System.Data.DataTable]::new()
    $dt.Columns.AddRange(@('one', 'two', 'three'))
    $dt.Rows.Add($dt.NewRow()) # Add at least 1 row to provoke the symptom.
    # !! Breaks, because $dt behaves like $dt.Rows, and the result
    # !! cannot be cast to (an array of) [System.Data.DataTable] instance(s).
    return $dt # Use `return , $dt` to fix.
  }
}
[Foo]::Bar()

If you were to return two or more [System.Data.DataTable] instances, the problem would go away, because then only that array would get enumerated and cast to the array return type, not also its elements. For instance, return $dt, $dt above would succeed (though would obviously return two table instances).

The fact that [System.Data.DataTable] enumerates instances of a different type actually makes the problem more obvious; with other enumerables the problem may go unnoticed:

class Foo {
  # Returns an array of lists.
  static [System.Collections.Generic.List[int][]] Bar() {
    $list = [System.Collections.Generic.List[int]] @(42, 43)
    # !! Does NOT work as expected, because $list gets enumerated
    # !! and *each element* is cast to its own [System.Collections.Generic.List[int]]
    # !! instance, so that *2* elements are output.
    return $list # Use `return , $list` to fix
  }
}
[Foo]::Bar() | Measure-Object # !! Returns *2*

In short:

In class methods, if the return type is an enumerable of enumerables, the case of returning a single enumerable must be special-cased.
The unary form of , is the only viable solution for returning a single instance of the nested enumerable, as far as I can tell (e.g, return , $dt):

Write-Output -NoEnumerate to prevent enumeration is not effective in class methods (for reasons unknown to me; it works in functions and scripts),
@(...) is generally not effective in creating an array wrapper around something that itself is an enumerable.
Even using the method's return type as an explicit cast does not help; e.g, return [System.Collections.Generic.List[int][]] $list in the example above still creates a two-element array of [System.Collections.Generic.List[int]] instances with one number each.

A PowerShell-idiomatic reformulation of your code with a single [System.Data.DataTable] instance (self-contained example):
class OutDataTable {
  #main function to convert array to datatable
  [System.Data.DataTable] CovertToDataTable([System.Array]$source) {
    $dataTable = [System.Data.DataTable]::new()
    #set up colunms
    $columns = $source[0].psobject.Properties.Name
    $dataTable.Columns.AddRange($columns)
    #For each row in source, build row and add to DataTable.
    foreach ($entry in $source) {
      $dataRow = $dataTable.NewRow()
      foreach ($column in $columns) {
        $dataRow[$column] = $entry.$column
      }
      $dataTable.Rows.Add($dataRow)
    }
    #return datatable
    return $dataTable
  }
}

[OutDataTable]::new().CovertToDataTable(@(
  [pscustomobject] @{ one = 1; two = 2; three = 3 },
  [pscustomobject] @{ one = 10; two = 20; three = 30 }
))


Also use logFactory for ThrowConfigExceptions

Current coverage is 74.82%

Merging #1299 into master will decrease coverage by -0.02% as of 0a23414

@@            master   #1299   diff @@
======================================
  Files          267     267
  Stmts        15438   15458    +20
  Branches      1621    1622     +1
  Methods          0       0
======================================
+ Hit          11554   11566    +12
- Partial        382     383     +1
- Missed        3502    3509     +7

Review entire Coverage Diff as of 0a23414

Uncovered Suggestions

+0.10% via ...gingConfiguration.cs#282...295
+0.10% via ...gingConfiguration.cs#248...261
+0.09% via ...argets/FileTarget.cs#1713...1725
See 7 more...

Powered by Codecov. Updated on successful CI builds.


proposal: update examples with short functions

I think showing the short function syntax in the examples might improve the clarity of the examples because there is less visual bloat for the eye to process.
I you don't agree, just close the PR, no worries.

This is not valid syntax for the minimum php version the library supports (7.2):

https://github.com/silexphp/Pimple/blob/v3.5.0/composer.json#L15

This is not valid syntax for the minimum php version the library supports (7.2):

Correct, but is that a problem?

It's up to maintainers to decide is that a problem, if I would be the maintainer I wouldn't put code to documentation that doesn't always run. it's just asking for support trouble explaining you need yadauyada.
A similar change was rejected in the past, and in that case, the syntax change required PHP 5.4 that matched the supported PHP version (7.2) at that time:

https://github.com/silexphp/Pimple/pull/254

Also, read the caution in project README:

Pimple
Caution!
Pimple is now closed for changes. No new features will be added and no cosmetic changes will be accepted either. The only accepted changes are compatibility with newer PHP versions and security issue fixes.
Caution!

I think it's a bit different from the other PR that was rejected. First, it makes things way more readable, and then, 7.2 is not maintained anymore for a very long time.

Also, it only changes the README, not the code.

Thank you @chris-kruining.


Add indexing functions to Forge

Development Checklist:

[ ] Component(s)
[ ] ... with PHPdocs
[ ] Unit testing
[ ] ... with >80% coverage
[ ] User guide updated
[ ] Classmap integration?
[ ] Securely signed commits
[ ] Conforms to style guide

When I finish the task of foreign keys #63 I will look this feature

Hi, I will try finding time to help so please provide me with more information about this issue.

Actually - looks like this has already been done. We've got our standard keys and foreign keys in place. Not sure what this originally meant other than that. :(
Thanks for the interest in helping out! There's definitely other things that need a helping hand.

just tag me and I will try helping you :)


Duration type conversion was dropped (mistakenly?)

Confirmation

[X] My issue isn't already found on the issue tracker.
[X] I have replicated my issue using the latest version of the library and it is still present.

cloudflare-go version
v0.64.0
Go environment
Not needed
Expected output
Not needed
Actual output
Not needed
Code demonstrating the issue
Not needed
Steps to reproduce
Not needed
References
It's not used in the code base but since was exported at some point and dropped without mentioning and only type doesn't have both directions, it might be a good idea to add it back.
Related change: f65e02d (#837)
On the other hand, if breaking change is possible, generics might be used to simplify convert types.

this was intentionally dropped (in the following release that it was introduced) as it was causing issues in the experimental client.
there are no plans at the moment to add it back and break the type aliasing. we don't use generics anywhere currently so i'm not particularly concerned about swapping to generics (that may change in the future once we start replacing other functionality with that pattern).


can we have a slightly larger model?

the currently published model is making errors, I wonder if a larger bert would probably fix the issue? 128 is too small.

The currently published model is designed for maximum FFF depth and performs (as described in the preprint), apart from the CoLA task, on par with GLUE baselines. It has max depth of 11 and uses only one FFF tree -- it is not clear what 128 you're referring to.

the BERT-UNCASED is a relatively smaller model, BERT seems to have a 128 token size window, so I figured it would be nice to have a BERT (LARGE?) model with perhaps a 512 window if such a thing even exists. @pbelcak I know it's designed for maximum depth but having other models would be awesome. the 128 refers to the context length

Yeah, following crammedBERT, we do not pretrain with longer sequences. But, with all code being public now, we do not bar any initiative in that direction.


Fix XA Datasource test

@jmazzitelli  could you please review and eventually merge?

@jmazzitelli let's speak about this before merging

uh oh, moving away from junit to testng - some people aren't going to be happy :)

uh oh, moving away from junit to testng - some people aren't going to be happy :)

But some will maybe? /me is becoming an official pupil of @jsanda ;)


Feature: E2E Testing

Is your feature request related to a problem? Please describe.
When preparing a new release we must ensure that the new version will work as usual without regression.
Describe the solution you'd like
Create E2E testing with normal scenarios (Create device model create device, create configuration, ...).
The E2E testing might be done like blazor unit test, but we should ensure to not use any mocks under the pipeline.
We should also think about creating the infrastructure dedicated to this E2E tests during the pipeline
Describe alternatives you've considered
Do all the tests manually
Additional context
N/A

The demo website, I think has changed, which means that some of our tests don't work anymore. For instance, when we try to add a device, then we click save, it doesn't return to the previous page so the snackbar  (we use it to check the test) dosesn't appear.


Add OTel Metric Exporter to OpenTelemetry-Swift

Currently, the only metric exporter available in otel-swift is for prometheus.

completed : https://github.com/open-telemetry/opentelemetry-swift/pull/108


Add input hint consecutive tests

Fix #2158.

This will add tests for input hint on consecutive activities, based on the table below.

1st activity
2nd activity
Should turn on microphone if via microphone

Accepting input
Accepting input
No

Accepting input
Expecting input
Yes

Accepting input
Ignoring input
No

Expecting input
Accepting input
Yes

Expecting input
Expecting input
Yes

Expecting input
Ignoring input
No (explicitly turn it off)

Ignoring input
Accepting input
No

Ignoring input
Expecting input
Yes

Ignoring input
Ignoring input
No

Coverage decreased (-1.5%) to 64.585% when pulling 68c7e7cc4e5ff1123fd97ff008478c48a0ea3740 on compulim:fix-2158 into 5f745a6aff3bbd81961c9bf2cea68a67cabc5fbe on microsoft:master.


Dev to main sync

Developer Name:   @anishpawaskar
PR Number(s):-

https://github.com/Real-Dev-Squad/website-backend/pull/1581
https://github.com/Real-Dev-Squad/website-backend/pull/1577
https://github.com/Real-Dev-Squad/website-backend/pull/1557

Backend changes

[x] Yes
[ ] No

Frontend Changes

[ ] Yes
[x] No

Database changes

[ ] Yes
[x] No

Breaking changes (If your feature is breaking/missing something please mention pending tickets)

[x] No
[ ] Yes:-

Deployment notes(Any special instructions for the deployment)

[x] No

Tested in staging

[x] Yes
[ ] No

Demo :-

To show "group-idle-7+" addition :-

https://github.com/Real-Dev-Squad/website-backend/assets/22213872/0605d2bd-dd9b-47c4-9cec-8f240bfe1d14

To show "group-idle-7d+" removal from user who is not in idle state anymore:-

To show "group-onboarding-31d+" addition :

https://github.com/Real-Dev-Squad/website-backend/assets/30263070/18ddbd15-1e78-40f4-87fa-fb4e70f82a17

To show "group-onboarding-31d+" removal from user who is not in onboarding state anymore :

https://github.com/Real-Dev-Squad/website-backend/assets/30263070/a7b219af-641d-4d67-b61c-1cbf50a8a16e

This SYnc PR also include my PR which is not working correctly on dev. For time being do not merge.

can you please revert your PR @skv93-coder


Auth-Session not persisted on iOS after closing app

I am using:

SDK Version: 36.0.0
Platforms(Android/iOS)

I have builded a simple server with Spring Security that provides a Basic Auth via a REST-API for my Expo Standalone app.

On Android, after successfully login the session is persisted, even if I close the app and reopen it. Also after app-updates, the session is still available and the server can authorize me access the ressources. So all here works well (It is the same case on browser).

But on iOS, after successfully login a first time, the server authozire me access the ressources as long as the app is not closed. After I close the app and immediately reopen it, the session disappears and I must login again.

I am not understanding what is not working on iOS. Maybe the cookies are deleted each times ?
I would like to release the first version of the app, but the iOS behaviour does not allow me now.

https://github.com/react-native-community/cookies
Cookies to the rescue.

Same issue here with Expo. I posted on the Expo GitHub here.

Closing the issue because this issue tracker is intended to track React Native issues, but your issue is related to Expo only features.

@dulmandakh - i think this actually relates to the default functionality of cookie persistence in react-native core, does it not?

Same issue here with a bare react-native app 0.64.0.
Cookies are persisted on Android, but not on iOS.
Even if a set the cookie manually on the request with axios.

Any resolution to this?
Also, using https://github.com/react-native-community/cookies is resetting the cookies on some post requests.


build: linux-arm-qemu lacks Go 1.4 and gcc

The linux-arm-qemu environment lacks both Go 1.4 (which isn't tragic: we can push it to the buildlet on start-up, as we do for half the buildlets), but also lacks gcc (which means we can't build Go 1.4.2 to begin with to push it, and we presumably can't run certain cgo tests)
ante:cmd $ time gomote run linux-arm-qemu go/src/all.bash
##### Building Go bootstrap tool.
cmd/dist
ERROR: Cannot find /go1.4/bin/go.
Set $GOROOT_BOOTSTRAP to a working Go tree >= Go 1.4.
./make.bash: line 121: /go1.4/bin/go: No such file or directory
Error running run: exit status 1

real    0m4.053s
user    0m0.060s
sys     0m0.019s
ante:cmd $ time gomote rm linux-arm-qemu  .

real    0m2.400s
user    0m0.053s
sys     0m0.011s

ante:cmd $  gomote puttar -gorev=883bc6ed0ea8 linux-arm-qemu
ante:cmd $ time gomote run linux-arm-qemu src/make.bash
# Building C bootstrap tool.
cmd/dist
/tmp/buildlet-scatch917031135/src/make.bash: line 132: gcc: command not found
Error running run: exit status 127

real    0m1.644s
user    0m0.088s
sys     0m0.000s
ante:cmd $

/cc @saljam

Ah, I thought we're just running the tests on them (I had forgotten about cgo). I'll add them both.

@saljam, note that if we put Go 1.4.x in the ARM filesystem (probably a good idea to speed things up), we need minimum Go 1.4.2, which contains critical 32-bit fixes. Hopefully we don't have to update it too often.

Or I could use the binaries from http://dave.cheney.net/unofficial-arm-tarballs for now instead, and we can run with CGO disabled.
But which ARM variant is this qemu emulating?  ARMv5, v6, v7?

Doesn't GOOS=linux GOARCH=arm ./make.bash on x86 cross compile the toolchain? Any reason not to use that to build Go 1.4?

It's ARMv7 (vexpress)

I prepared a Go 1.4 tarball for it but even removing all the unnecessary parts (test, testdata, api, doc, blog, misc, etc), extracting it adds 2 minutes and 20 seconds (!) to the gomote push time:
ante:cmd $ gomote push linux-arm-qemu2
2015/02/26 14:49:41 installing go1.4
2015/02/26 14:52:02 Remote doesn't have "doc/progs/json5.go"
...

Fair enough! CL incoming.

And gcc is still required, even to run make.bash currently:
ante:cmd $ time gomote run linux-arm-qemu2 go/src/make.bash
##### Building Go bootstrap tool.
cmd/dist

##### Building Go toolchain using /tmp/buildlet-scatch177488625/go1.4.
bootstrap/internal/obj
bootstrap/internal/asm
bootstrap/internal/obj/arm
bootstrap/5a
bootstrap/internal/gc
bootstrap/5g
bootstrap/internal/obj/x86
bootstrap/6a
bootstrap/6g
bootstrap/internal/obj/i386
bootstrap/8a
bootstrap/8g
bootstrap/internal/obj/ppc64
bootstrap/9a
bootstrap/9g
bootstrap/asm/internal/arch
bootstrap/asm/internal/flags
bootstrap/asm/internal/lex
bootstrap/asm/internal/asm
bootstrap/asm

##### Building compilers and go_bootstrap for host, linux/arm.
lib9
go tool dist: FAILED: gcc -Wall -Wstrict-prototypes -Wextra -Wunused -Wno-sign-compare -Wno-missing-braces -Wno-parentheses -Wno-unknown-pragmas -Wno-switch -Wno-comment -Wno-missing-field-initializers -fno-common -ggdb -pipe -Wuninitialized -O2 -fmessage-length=0 -c -I /tmp/buildlet-scatch177488625/go/include -DPLAN9PORT -I /tmp/buildlet-scatch177488625/go/src/lib9 -o /tmp/go-tool-dist-699532928/_exits.o /tmp/buildlet-scatch177488625/go/src/lib9/_exits.c
Error running run: exit status 2

real    2m27.928s
user    0m0.092s
sys     0m0.005s

https://go-review.googlesource.com/6172

With that patch make.bash runs fine, but run.bash fails to find the go binary. gomote run go/bin/go suggests that it's in fact there. Is that normal? Or should PATH have been set by gomote somehow?
s@instance-1:~$ gomote -project airy-shuttle run linux-arm-qemu go/src/run.bash
/tmp/buildlet-scatch703261494/go/src/run.bash: line 8: go: command not found
##### Building packages and commands.
/tmp/buildlet-scatch703261494/go/src/run.bash: line 41: go: command not found
Error running run: exit status 127


Update to use Expression Locale string instead of CultureInfo

Update to use Expression Locale string instead of CultureInfo to avoid json serialization failure in https://msazure.visualstudio.com/OneAgile/_workitems/edit/28863116

Is there a test we can add that would catch this?

Public API changes: ❌CP0002 M:Microsoft.PowerFx.LanguageServerProtocol.NL2FxParameters.get_ExpressionLocale❌CP0002 M:Microsoft.PowerFx.LanguageServerProtocol.NL2FxParameters.set_ExpressionLocale(System.Globalization.CultureInfo)


WIP: Implement FileProxy and FileAttachment objects

These are implemented for the purpose of storing files in the database for use with Jobs and FileVar fields. The FileVar fields will now serialize files into the database store the PK of the file in the job metadata for pickup and retrieval of file contents by the worker.
Done

django-db-file-storage added as a dependency for use with FileProxy objects
FileProxy is a new model that holds the filename and reference to the file contents and store them in the database using the DatabaseFileStorage backend provided by django-db-file-storage
FileAttachment is a new model that holds the file contents and metadata and represents files on the datatbase-backed virtual filesystem. It is not intended for direct usage.
Model tests

Not Done

Cleanup of files after job fails or is completed successfully (see TODO comments)

Fixes: #

Would it be useful to provide a basic set of views (even just using admin for now, though I know we're trying to move away from it) for listing/inspecting/managing FileAttachment and FileProxy records? Or are we okay for now just using nbshell to inspect and clean up as needed?

I think for now having the admin is suitable until we decide what to do.


Prevent Uncaught Exception from ThinEngine.runRenderLoop when window.SetTimeout in not defined

I am having an uncaught exception when using BaylonJs in a NodeJs environment because of a call to window.setTimeout.
It is not very clear in the code what is the standard, as sometime we call the global setTimeout and sometime we call window.setTimeout.
My take on this is that it should be ok to always call the globals setTimeout/ clearTimeout as they are bound to be defined and are the very same functions as window.setTimeout/ window.clearTimeout in most cases.
Though this PR do not change them all. I just make some 2 files more consistent where we used to use a mix of both, and I updated the ThinEngine.QueueNewFrame to NOT call window.setTimeout, but to fall back on the global setTimeout.
To really be "environment  independant", we should never call a function that is "environment  dependant" directly, and put them all behind a configurable callback registry. This registry would be initialized with default values, and could be customizes by the user depending on its needs. But I'm not sure how it is doable, and anyway that's another story :)

And another possible change would be to use ReturnType<setTimeout> instead of casting to unknown and then to number, but that might collide with our internal type definitions in the engine. If that the case - leave it this way

And another possible change would be to use ReturnType<setTimeout> instead of casting to unknown and then to number, but that might collide with our internal type definitions in the engine. If that the case - leave it this way

Well the difficulty here is that actually setTimeout is used as a fallback in case requestAnimationFrame/requestPostAnimationFrame is not defined. So the return type of QueueNewFrame should the same as requestAnimationFrame, requestPostAnimationFrame and setTimeout...

let's leave it this way then.

@bghgary could you check it would be ok with Native ???

@barroij would be great if you can fix lint and format ?

@sebavan formatting done !

I'll wait for @bghgary before merging just to be sure.


Add CloudFormation Update support for AWS::StepFunctions::StateMachine

Closes #3402

Coverage decreased (-0.2%) to 94.192% when pulling d825a0e405fa51c7aef9f97f3159e4d3c9a6ff61 on bpandola:fix-3402b into b7cf2d4478d8b6c2f77189dc792ad08e6774dc54 on spulec:master.


Trying to create a second project requires a defined bucket

To be able to create multiple projects it looks like I'd need to have my own bucket defined, as I cannot add a named project.

This should be fixed now.


Decide on Mock Chart Component Library

Together with installing the Chart Component library for Android (#4), there should be a decision on how intricate the Mock Chart Components will have to be.
A decision on the library to use in GWT will have to be taken.

The most likely scenario is that a JavaScript library will be used, since GWT provides an interface with JavaScript.

Possibilities considered:

ChartJS (Charba for GWT)
ApexCharts
Apache ECharts
D3JS

Most likely going with Charba
Only downside: AiClientLib build source will have to be bumped from 1.7 to 1.8.

Decision on using the Charba library has been accepted.


Which file/line is responsible for proxifying links?

I want to avoid proxying some links while still doing others, eg:
if (link == "myprotectedlink.com") {
    // dont proxy
}
else {
    // where the current code goes
}
Thanks for any help.

Figured it out. It's the ProxifyPlugin. The code block is commented with something like 'For src= and href='.


fix: bump client-go and apimachinery in all go.mod for CVE fix

What type of PR is this?
/kind fix

What this PR does / why we need it:
bump client-go and apimachinery in all go.mod for fixing CVE https://nvd.nist.gov/vuln/detail/CVE-2023-37788.
Which issue(s) this PR fixes:

Fixes #
Requirements:

[x] uses conventional commit messages

[ ] includes documentation
[ ] adds unit tests
[ ] tested upgrade from previous version

Special notes for your reviewer:
Release note:
none

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 79.022%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
2554

Relevant Lines:
3232

💛  - Coveralls


Issue when impersonating an user with \MarcinJozwikowski\EasyAdminPrettyUrls\Routing\PrettyUrlsResolver::resolveToPath

Hello,
I don't know why, but when I'm impersonating a user on Easy Admin this code is crashing in Easy Admin:
{% if null == ea.userMenu.avatarUrl %}

"?_switch_user=_exit" is passed to \MarcinJozwikowski\EasyAdminPrettyUrls\Routing\PrettyUrlsResolver::resolveToPath
and since a path does not exists, it returns null. Can you add a string cast or nullable return ?

In fact the error is caused by:
\EasyCorp\Bundle\EasyAdminBundle\Factory\MenuFactory::generateMenuItemUrl
        if (MenuItemDto::TYPE_EXIT_IMPERSONATION === $menuItemType) {
            // the switch parameter name can be changed, but this code assumes it's always
            // the default one because Symfony doesn't provide a generic exitImpersonationUrlGenerator
            return '?_switch_user=_exit';
        }

@marcin-jozwikowski an easy wuick way to fix that is to change the code as shown below:
    public function resolveToPath(string $path): string
    {
        return parse_url($path, PHP_URL_PATH) ?? '/';
    }

@Geolim4 Thanks again for doing the best QA I could dream of!
The issue has been fixed in https://github.com/marcin-jozwikowski/easy-admin-pretty-urls/releases/tag/v2.9.2 - I removed all menu items you cannot "stay on" from being considered. Logout page, user impersonation exit, section, and submenu are not actually links to valid pages. They are empty links or actions you're redirected from.

Thank you very much Marcin !