bug: streaming jobs (NexMark) didn't recover after cluster restarts

Describe the bug
As title.
To Reproduce

./risedev d full
Create NexMark sources and create materialized view nexmark_q7
./risedev d full again to restart cluster
Watch Grafana and no throughput

Expected behavior
Streaming jobs should recover after restart
Additional context
No response

I think we've not implemented meta service recovery?

In InnerConnectorSourceReader::new, when the source is first created:
&split = Some(
    [
        Nexmark(
            NexmarkSplit {
                split_index: 0,
                split_num: 4,
                start_offset: None,
            },
        ),
    ],

When it's recovered:
&split = None

cc @tabVersion

after some investigation, I believe it is a left todo: source executor should maintain its split assignment and write to state store.
I prefer to use source_id as the prefix in state_store, is it okay when migrating or scaling? @shanicky

after some investigation, I believe it is a left todo: source executor should maintain its split assignment and write to state store. I prefer to use source_id as the prefix in state_store, is it okay when migrating or scaling? @shanicky

Will it cause the problem similar to #4817 if using source_id?

after some investigation, I believe it is a left todo: source executor should maintain its split assignment and write to state store. I prefer to use source_id as the prefix in state_store, is it okay when migrating or scaling? @shanicky

Will it cause the problem similar to #4817 if using source_id?

I think it won't. I use internal_table_id as source_id for actors in each fragment and this will make the prefix unique.

Any progress on this? @tabVersion

Any progress on this?

#5004 has proven executors can handle state restoring from the state store but it can not handle crashes on migration. After discussion @shanicky and @yezizp2012 , a solution is that meta pushes split assignments to executors again by recovery (#5160). This solution requires some refractory on meta source manager and barrier manager, still in design stage.

The compute node panicked after restarting the cluster w/ 3 compute nodes.
  full-3cn:
    - use: minio
    - use: etcd
    - use: meta-node
    - use: compute-node
      port: 5687
      exporter-port: 1222
    - use: compute-node
      port: 5688
      exporter-port: 1223
    - use: compute-node
      port: 5689
      exporter-port: 1224
    - use: frontend
    - use: compactor
    - use: prometheus
    - use: grafana
    - use: zookeeper
      persist-data: true
    - use: kafka
      persist-data: true

Part of the compute note panic stack
thread 'risingwave-main' panicked at 'assertion failed: `(left == right)`
  left: `14`,
 right: `15`', src/storage/src/hummock/local_version/local_version_manager.rs:168:21
stack backtrace:
   0: rust_begin_unwind
             at /rustc/9067d5277d10f0f32a49ec9c125a33828e26a32b/library/std/src/panicking.rs:584:5
   1: core::panicking::panic_fmt
             at /rustc/9067d5277d10f0f32a49ec9c125a33828e26a32b/library/core/src/panicking.rs:142:14
   2: core::panicking::assert_failed_inner
   3: core::panicking::assert_failed
             at /rustc/9067d5277d10f0f32a49ec9c125a33828e26a32b/library/core/src/panicking.rs:181:5
   4: risingwave_storage::hummock::local_version::local_version_manager::LocalVersionManager::try_update_pinned_version
             at ./src/storage/src/hummock/local_version/local_version_manager.rs:168:21
   5: risingwave_storage::hummock::event_handler::hummock_event_handler::HummockEventHandler::start_hummock_event_handler_worker::{{closure}}
             at ./src/storage/src/hummock/event_handler/hummock_event_handler.rs:323:25
   6: <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll
             at /rustc/9067d5277d10f0f32a49ec9c125a33828e26a32b/library/core/src/future/mod.rs:91:19
   7: <tracing::instrument::Instrumented<T> as core::future::future::Future>::poll
             at /Users/liuchengyou/.cargo/registry/src/github.com-1ecc6299db9ec823/tracing-0.1.36/src/instrument.rs:272:9
   8: tokio::runtime::task::core::CoreStage<T>::poll::{{closure}}
             at /Users/liuchengyou/.cargo/registry/src/github.com-1ecc6299db9ec823/tokio-1.21.1/src/runtime/task/core.rs:184:17
   9: tokio::loom::std::unsafe_cell::UnsafeCell<T>::with_mut
             at /Users/liuchengyou/.cargo/registry/src/github.com-1ecc6299db9ec823/tokio-1.21.1/src/loom/std/unsafe_cell.rs:14:9
  10: tokio::runtime::task::core::CoreStage<T>::poll
             at /Users/liuchengyou/.cargo/registry/src/github.com-1ecc6299db9ec823/tokio-1.21.1/src/runtime/task/core.rs:174:13
  11: tokio::runtime::task::harness::poll_future::{{closure}}
             at /Users/liuchengyou/.cargo/registry/src/github.com-1ecc6299db9ec823/tokio-1.21.1/src/runtime/task/harness.rs:480:19
  12: <core::panic::unwind_safe::AssertUnwindSafe<F> as core::ops::function::FnOnce<()>>::call_once
             at /rustc/9067d5277d10f0f32a49ec9c125a33828e26a32b/library/core/src/panic/unwind_safe.rs:271:9
  13: std::panicking::try::do_call
             at /rustc/9067d5277d10f0f32a49ec9c125a33828e26a32b/library/std/src/panicking.rs:492:40
  14: ___rust_try
  15: std::panicking::try
             at /rustc/9067d5277d10f0f32a49ec9c125a33828e26a32b/library/std/src/panicking.rs:456:19
  16: std::panic::catch_unwind
             at /rustc/9067d5277d10f0f32a49ec9c125a33828e26a32b/library/std/src/panic.rs:137:14
  17: tokio::runtime::task::harness::poll_future
             at /Users/liuchengyou/.cargo/registry/src/github.com-1ecc6299db9ec823/tokio-1.21.1/src/runtime/task/harness.rs:468:18

So reopen this one.

This seems a bug of Hummock storage and is not relavant to this issue. Could you please help to open a new issue for this?

I think it is related and I am looking into this. Source executor recovery failure can result in hummock panic.
Taking a rough look, meta behaves abnormally since I does not push down split assignments down as expected in #5160

INFO risingwave_meta::barrier::recovery: meta push down {63: [Nexmark(NexmarkSplit { split_index: 2, split_num: 4, start_offset: None })], 16: [Nexmark(NexmarkSplit { split_index: 1, spli
t_num: 4, start_offset: None })], 15: [Nexmark(NexmarkSplit { split_index: 2, split_num: 4, start_offset: None })], 64: [Nexmark(NexmarkSplit { split_index: 3, split_num: 4, start_offset: None })], 39: [Nexmark(Nexma
rkSplit { split_index: 0, split_num: 4, start_offset: None })], 14: [Nexmark(NexmarkSplit { split_index: 3, split_num: 4, start_offset: None })], 61: [Nexmark(NexmarkSplit { split_index: 1, split_num: 4, start_offset
: None })], 37: [Nexmark(NexmarkSplit { split_index: 1, split_num: 4, start_offset: None })], 38: [Nexmark(NexmarkSplit { split_index: 2, split_num: 4, start_offset: None })], 13: [Nexmark(NexmarkSplit { split_index:
 0, split_num: 4, start_offset: None })], 40: [Nexmark(NexmarkSplit { split_index: 3, split_num: 4, start_offset: None })], 62: [Nexmark(NexmarkSplit { split_index: 0, split_num: 4, start_offset: None })]}

nexmark Q7 involves 36 actors but meta pushes down only 12 of them where all of the recovered actors are on the same node.

Validate with the latest main, the problem seems fixed.


textfield clears on orientation change

Haven't added the Orientation Support yet. Will add with next version.


TypeError: Cannot read properties of undefined (reading 'captain')

setupRollContexts method in actor.js fails due to undefined crewActorData variable.

Fixed during the data model migration. Fix will be in the next release.


quillcpp: init at 3.3.1

Description of changes
https://github.com/odygrd/quill
(not sure if adding the library to a project and compiling counts as testing the basic functionality of binary files but I did that and it worked)
the patch is a PR I submitted, will remove it once it gets merged into upstream and a new version is released
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

dupe of #316404


ReferenceError: Urls is not defined in ads.js

Been trying to solve this issue for some hours without success. I getting an error at Line 7 in ads.js file. The Urls is undefined. What could be the workaround here?
var url = Urls['ads:ad-impression']();

Sorry for latency in replying to this issue. I was busy in the previous period.
You need to install django-js-reverse to solve this issue.
pip install django-js-reverse
please refere to django-js-reverse github homepage for installation instructions.
https://github.com/ierror/django-js-reverse

Hello Razi,
Thanks for your reply. Will check it out.
Thanks
Kind Regards,
WANJOHI KIBUI
GIS Consultant - Developer and Trainer
Mobile: +254 719 696921
*Website: *
w http://www.lifeingis.com/ww.lifeingis.com http://www.lifeingis.com/w
http://www.lifeingis.com/ww.geosymp.com http://www.geosymp.com/
*Knowing is not enough, we must apply. *Being willing is not enough, we
must do.
On Tue, Jul 16, 2019 at 10:20 PM Razi Alsayyed<EMAIL_ADDRESS>wrote:

Sorry for latency in replying to this issue. I was busy in the previous
period.
You need to install django-js-reverse to solve this issue.
pip install django-js-reverse
please refere to django-js-reverse github homepage for installation
instructions.
https://github.com/ierror/django-js-reverse
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/razisayyed/django-ads/issues/13?email_source=notifications&email_token=ABF6DF2LDGCPG6NXRS7524TP7YNO3A5CNFSM4HVUE7SKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2B34SY#issuecomment-511950411,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABF6DF45QBPQYAPJVOIJXGDP7YNO3ANCNFSM4HVUE7SA
.

Hello
I had this same problem and I solved it as follows:

I Added django js reverse to INSTALED_APPS:
INSTALLED_APPS = (  ...  'django_js_reverse', )

Run collectstatic as instructed in django js reverse documentation
./manage.py collectstatic_js_reverse

In the template I want to render the ads, load the django js reverse tags

{% load ads_tags %}
{% load js_reverse %}

<script type="text/javascript" charset="utf-8">
  {% js_reverse_inline %}
</script>

{% render_ads_zone 'content' %}

P.S.
I did not have to install django js reverse since in version 1.1.0 it was added as a dependency to the project


Editor bugs

Editor is generally buggy, with highlighting being off and scrolling through large files being impossible

Can you share a large file I can test with?

You can use binary_search.c in the tests folder, and if that's not long enough you can just copy-paste the entire file's contents a few times

It seems like the editor we are using is not optimal for large files. I'm debating on either writing our own or using another library

fixed!


Nitrogen group

nitrogenczslprh3xyw6lh5xyjvmsz7ciljoqxxknd7uymkfetfhgvqd.onion

Thanks but seems down from here

My bad ... it works.
Parser writen and victims parsed


Suggestion - custom canvas pan location

First of all, thank you for creating such a usefull module for foundry VTT. It gives me the pauses I need during my campaigns. I was wondering whether it would be possible to add control over where the focus zooms to when the module is triggered. it would be handy if I could zoom to other locations than the triggering character.

Good question! Do you have any ideas on how that could work from a UI / UX perspective? Would there be an easy enough way to specify where it should zoom to?

Thanks for looking in to this! When you double click on the placed tile you get the "Hey, Wait! Tile configuration screen".
I would put a checkbox there to query for a "Custom Canvas pan location".
If marked yes, it would put a input place for x and y coordinates+ zoom and beside it an icon that captures the current view.
This would then be similar to the method that is used for the "Initial view position" when you are configuring a scene. I think it would be an intuitive way to implement this as foundry users are already acustom to this method.

Not a bad idea, thanks! Let me prioritize this with some of the other feature requests...

Thank you so much ! Looking forward to the update :)
Merry Christmas btw ;)

You too! 🎅


Design the endpoint for the winner of the entire game

Calculation based on who won most rounds - data from gameRounds

Add isFinal field to the gameRounds endpoint.


Wingetbot does not working after someone created the pull request.

@wingetbot  always comments after someone created a request but do not why the wingetbot did not comments after someone created the pull request.
https://github.com/microsoft/winget-pkgs/pull/116512#issuecomment-1675811318
https://github.com/microsoft/winget-pkgs/pull/116513#issuecomment-1675808478
https://github.com/microsoft/winget-pkgs/pull/116514
https://github.com/microsoft/winget-pkgs/pull/116515

@BrandonWanHuanSheng It appears wingetbot would run the validation pipeline after you have been open PR for 20~40 mins. It's probable to resolve #111634 because it hasn't ever appeared such error after that.

OK.


Dark theme style issues

Describe the bug
Working from the VS-Code plugin, because it's cool. Changed theme and noticed a few things that are off
Color is off for "Stop" messages

Dead kernel sidebar doesn't match

Environment
Head
Code to reproduce
import marimo as mo
mo.stop(True)
x = 1

x

Admonitions icons:


Removed data param from create_session

I was naive when I initially added the data param and complicated the entire flow with jwt, etc
Developers should store their own data using the session or cookies.
I understand this may be a breaking change for some users, but I believe its the best way forward.

It helps developers and removes the overhead of first setting their data in session before authorization and then flushing it after authorization grant is completed. They can always have their own implementations of handling this situation but still it becomes really handy when you just quickly want to retain just few variables across the authorization flow, for example making use of it to redirect the user to page where they were before authorization.


cmake: Patch CVE-2024-2398, CVE-2024-7264 in bundled curl and CVE-2024-28182 in bundled nghttp2

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

[x] The toolchain has been rebuilt successfully (or no changes were made to it)
[x] The toolchain/worker package manifests are up-to-date
[x] Any updated packages successfully build (or no packages were changed)
[x] Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
[x] Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
[x] All package sources are available
[x] cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
[x] LICENSE-MAP files are up-to-date (./LICENSES-AND-NOTICES/SPECS/data/licenses.json, ./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md, ./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)
[x] All source files have up-to-date hashes in the *.signatures.json files
[x] sudo make go-tidy-all and sudo make go-test-coverage pass
[x] Documentation has been updated to match any changes to the build system
[x] Ready to merge

Summary

CVE fixes for cmake's bundled curl and nghttp2
Change Log

Add patches to fix CVE-2024-2398 and CVE-2024-7264 in cmake's bundled curl
Add patch to fix CVE-2024-28182 in cmake's bundled nghttp2

Does this affect the toolchain?

YES
Links to CVEs

https://nvd.nist.gov/vuln/detail/CVE-2024-2398
https://nvd.nist.gov/vuln/detail/CVE-2024-28182
https://nvd.nist.gov/vuln/detail/CVE-2024-7264

Test Methodology

Pipeline build id: 680135

Auto cherry-pick results:

main :white_check_mark: -> https://github.com/microsoft/azurelinux/pull/11231

Auto cherry-pick pipeline run -> https://dev.azure.com/mariner-org/mariner/_build/results?buildId=684063&view=results


Font Awesome icons not displayed when https is not used

If somebody also have a trick for the search form. It's stuck to the top :/
Thanks in advance !

Regarding the protocol (HTTP/HTTPS), I'm not sure what causes your problem. My site doesn't use HTTPS either, and FA icons show just fine: http://dandydev.net/
Regarding the search box, the proper size of the box depends on what Bootstrap/Bootswatch theme you use. In my particular case (I use 'simplex'), I had to add the following custom css:
#tipue_search_input {
    padding: 9px 12px 9px 40px;
    background-position: 15px 13px;
}

Hope that helps!


Attendance Table is stuck in loading

Issue description
Attendance Table is stuck in loading in Chums App
Prerequisites
URL: https://app.staging.chums.org/
Browser: Chrome
User<EMAIL_ADDRESS>Password: password
Steps to reproduce the issue

Login using the given credentials in the prerequisites above
Click Cypress Chums on the popup dialog
Go to the Attendance Tab

What's the expected result?
The Page should load without any issues
What's the actual result?
Attendance Table is stuck in loading
Additional details / screenshot

The reporting api wasn't properly configured on dev.  The page loads correctly now.


Error 0.1.8 not corrrect .zip file only 1KB

Update from 0.1.7 Vs 0.1.8 the file backup start but not complete it, the backup file is olny 1Kb. I revert to 0.1.7 and works good

The bug has been fixed, please upgrade to 0.1.8 again and try it.


support for productName field in package.json

there is a productName field in package.json, which if you set, will be the folder name in userData.
however, line 11 in WindowState.js
const stateFile = path.join(utils.getAppDataPath(), utils.getManifestData().name, 'windowStates.json');

only use the name field, thus will use different folder than electron,
can it be utils.getManifestData().productName || utils.getManifestData().name
Update: use native app.getName() seems better, I had made an pull request;

I merged your pull request and adjusted the unit tests accordingly.
Thanks for your contribution.


Update Storage.lua

I removed the _G thing as im pretty sure it wasnt used at all, and its unnecessary + bad practice and bad for security.
Also made it use table.freeze
Im honestly not sure if we need Storage.lua at all, i don't think any code uses it and it doesn't seem functional. I checked the code and it doesn't make much sense, for example Container = {}, was in a metatable for some reason, and other code doesn't seem functional either
Maybe we should remove Storage.lua ?

Originally this module is for commands, but from what I've seen, it is really pointless.
You can remove this module if you want.

By the way, we are recoding the backend in the next branch

By the way, we are recoding the backend in the next branch

So do I commit to that instead? ok


The "CoeffData" array was not assigned because the file is too short.

Bug description
I tried to transfer the parameters of a balded wind turbine model of another person to the fast software, and the following error occurred when running aerodyn.

FAST_ InitializeAll:AD_ Init:Init_ AFIparams:AFI_ Init:ReadAFfile:ParseSiAry:
A fatal error occurred when parsing data.
The "CoeffData" array was not assigned because the file is too short.

In addition, I would like to ask you, there is a blafid parameter in aerodyn v15.00. * blade definition input file. How can I confirm which airfoil file is related to which nodes?
This is a complete error message(I know I should use the FST file. Here I use a TXT file to input the FST file. I think there is no problem)
C:\Users\13417\Desktop\bladed\LoadCases>TwinRotor_x64 TwinRotor_x64.txt

OpenFAST
Copyright (C) 2022 National Renewable Energy Laboratory
Copyright (C) 2022 Envision Energy USA LTD
This program is licensed under Apache License Version 2.0 and comes with ABSOLUTELY NO WARRANTY.
See the "LICENSE" file distributed with this software for details.

OpenFAST-Unversioned from 42a5a8196529ae0349eda6d797a79461c2c03ff0
Compile Info:

Compiler: Intel(R) Fortran Compiler 1910
Architecture: 64 bit
Precision: single
OpenMP: No
Date: Jul 15 2022
Time: 09:42:53
Execution Info:
Date: 08/31/2022
Time: 16:28:33+0800

OpenFAST input file heading:
FAST Certification Test #19: IEA 15.0 MW Baseline Wind Turbine with OC3 Monopile RF
Configuration, for use in offshore analysis
Running ElastoDyn.
Nodal outputs section of ElastoDyn input file not found or improperly formatted.
Running AeroDyn.
AD15 Nodal Outputs: Nodal output section of AeroDyn input file not found or improperly formatted.
Skipping nodal outputs.
FAST_InitializeAll:AD_Init:Init_AFIparams:AFI_Init:ReadAFfile:ParseSiAry:

A fatal error occurred when parsing data.
The "CoeffData" array was not assigned because the file is too short.

OpenFAST encountered an error during module initialization.
Simulation error level: FATAL ERROR
OpenFAST encountered an error during module initialization.
Simulation error level: FATAL ERROR
Aborting OpenFAST.

Dear @shipors,
From the error message, my guess is your airfoil data input file is not formatted properly.  How does your airfoil data file compare to one of the example airfoil data files provided with OpenFAST (e.g., here: https://openfast.readthedocs.io/en/main/_downloads/5ba9cfc7b0b53c6530f7032f44cb4874/ad_polar_example.dat)?
Regarding BlAFID, the list of airfoil data files is given via AFNames in the AeroDyn primary input file.  For example, BlAFID = 4 corresponds to the fourth file listed in AFNames.
Best regards,

Dear @shipors,
Does adding quotes around the "DEFAULT" keyword solve the problem?
And presumably you have 101 lines in your table of aerodynamic coefficients (you only show 7 lines), from -180 to 180 degrees?
Best regards,

Dear @jjonkman
I checked it again and found that the number of lines in the aerodynamic coefficient table of the first airfoil file I set was wrong. Actually, it should be 101 lines, But I found it was 120 lines. After modification, it can run normally. Thank you for your inspiration!
Best wishes!


Custom compiler instruction for pip does not work

General information

Corrfunc version: 2.4.0
platform: MacOS 13.0.1
installation method: source

Issue description
When I run python -m pip install . CC=/opt/homebrew/opt/llvm/bin/clang --user in the code directory as suggested in README, an error appears.
Expected behavior
Code builds
Actual behavior
ERROR: Invalid requirement: 'CC=/opt/homebrew/opt/llvm/bin/clang'
Hint: It looks like a path. File 'CC=/opt/homebrew/opt/llvm/bin/clang' does not exist.

What have you tried so far?
Setting CC := /opt/homebrew/opt/llvm/bin/clang in common.mk helps, then python -m pip install . --user works.
Minimal failing example
python -m pip install . CC=/anypath

@misharash Thanks for the report. The syntax you are using works if you install with python setup.py install .... If you install with pip, then you have to use the syntax python -m pip install --install-option="CC=/opt/homebrew/opt/llvm/bin/clang"  .... This should fix the issue you are seeing

Closing since the issue should be for you @misharash. Please feel free to re-open if you need further help


iOS 11 SDK: 'system' is unavailable: not available on iOS

when I tried to build the code against iOS 11 sdk, xcode 9 beta 6, there is an error "'system' is unavailable: not available on iOS". Is there any function that can be replaced with 'system'?

We've removed references to system in the latest version.

which commit includes this change?

3ebee2d31f65675fc0aa726aa5b4f5b6c5f2be9a
Pod v2.0.0 includes these changes

@Shmoopi
Thank you for your work.
Why does the minimum deployment target change to 9.0, do I have a way to use it in 8.0?

@VincentSit
Good question!  We are supporting n-2 OS releases to focus on new features.  Most features should work on iOS 8 with this release, but future releases may not.
Version 1.1.1 is available if you'd like to continue to support iOS 6-10 devices.
Thanks!


Incorporate Alice and LORRI updates

Summary
Opening a draft PR for now to more easily sort out conflicts and recently-added changes for Alice and LORRI.
Test Data and/or Report
None yet
Related Issues
#16, and probably others to come

Closed/superceded by #25


Enable Netlify on software-project-blueprint repository

Description
Netlify should be integrated into the software-project-blueprint repository to enable Docusaurus builds and previewing upon pull request. The following tasks should be followed.
Tasks

[x] Remove GitHub Action https://github.com/finos/software-project-blueprint/blob/main/.github/workflows/docusaurus.yml
[x] Enable Netlify on software-project-blueprint
[x] Test against pull request #26

all done!


Carrier Billing Partial Refund: No Amount Field Available for /payments/{paymentId}/refunds

Problem description
Carrier Billing Refund POST API (/payments/{paymentId}/refunds) has an option to opt for total refund or partial refund. type element in the request has following enum:
[ total, partial ]
However, for partial refund, there is no field to specify the amount.
Possible evolution

amount field should be there to specify the required refund amount in case of partial refund.
Alternative solution

Additional context

Hi @ajmhussain,
It is already considered Carrier Billing Refund v0.1
As it may be observed:

"amount" to be refunded can be indicated within amountTransaction -> refundAmount -> chargingInformation

@ajmhussain please comment if this resolve your comment so as we can close the issue

Hi @PedroDiez The public release that is available on the below link doesn't match to what you shared:
https://github.com/camaraproject/CarrierBillingCheckOut?tab=readme-ov-file
Screenshot below:

Hi @ajmhussain,
It seems a matter of renderization by swagger editor.
The definition includes it and within redoc is well renderized

Hi @PedroDiez
There seems some issue with the specs due to which it is not getting rendered correctly. All other CAMARA APIs we always check through Swagger Editor and proceed accordingly.

Hi,
@ajmhussain we set this issue to closed as it is swagger editor topic.


AttributeError: 'NoneType' object has no attribute 'loader'

I try to run the "video/deepfake_detection/1_deepfake_detection.ipynb"with the following code:
from towhee import ops, pipe, DataCollection

p = (
    pipe.input('path')
    .map('path', 'scores', ops.towhee.deepfake())
    .output('scores')
    # .output('path')
)

DataCollection(p('./train/deepfake_video/aejgdsuoqg.mp4')).show()

,but an error happend:
the filepath is correct,is there anything wrong with the code?
---------------------------------------------------------------------------
RuntimeError                              Traceback (most recent call last)
/home/image_check/code/examples/image/reverse_image_search/2_deep_dive_image_search.ipynb 单元格 1 in 4
      [1](vscode-notebook-cell://ssh-remote%2B7b22686f73744e616d65223a2253485445435f646576656c6f70227d/home/image_check/code/examples/image/reverse_image_search/2_deep_dive_image_search.ipynb#W0sdnNjb2RlLXJlbW90ZQ%3D%3D?line=0) from towhee import ops, pipe, DataCollection
      [3](vscode-notebook-cell://ssh-remote%2B7b22686f73744e616d65223a2253485445435f646576656c6f70227d/home/image_check/code/examples/image/reverse_image_search/2_deep_dive_image_search.ipynb#W0sdnNjb2RlLXJlbW90ZQ%3D%3D?line=2) p = (
----> [4](vscode-notebook-cell://ssh-remote%2B7b22686f73744e616d65223a2253485445435f646576656c6f70227d/home/image_check/code/examples/image/reverse_image_search/2_deep_dive_image_search.ipynb#W0sdnNjb2RlLXJlbW90ZQ%3D%3D?line=3)     pipe.input('path')
      [5](vscode-notebook-cell://ssh-remote%2B7b22686f73744e616d65223a2253485445435f646576656c6f70227d/home/image_check/code/examples/image/reverse_image_search/2_deep_dive_image_search.ipynb#W0sdnNjb2RlLXJlbW90ZQ%3D%3D?line=4)     .map('path', 'scores', ops.towhee.deepfake())
      [6](vscode-notebook-cell://ssh-remote%2B7b22686f73744e616d65223a2253485445435f646576656c6f70227d/home/image_check/code/examples/image/reverse_image_search/2_deep_dive_image_search.ipynb#W0sdnNjb2RlLXJlbW90ZQ%3D%3D?line=5)     .output('scores')
      [7](vscode-notebook-cell://ssh-remote%2B7b22686f73744e616d65223a2253485445435f646576656c6f70227d/home/image_check/code/examples/image/reverse_image_search/2_deep_dive_image_search.ipynb#W0sdnNjb2RlLXJlbW90ZQ%3D%3D?line=6)     # .output('path')
      [8](vscode-notebook-cell://ssh-remote%2B7b22686f73744e616d65223a2253485445435f646576656c6f70227d/home/image_check/code/examples/image/reverse_image_search/2_deep_dive_image_search.ipynb#W0sdnNjb2RlLXJlbW90ZQ%3D%3D?line=7) )
     [10](vscode-notebook-cell://ssh-remote%2B7b22686f73744e616d65223a2253485445435f646576656c6f70227d/home/image_check/code/examples/image/reverse_image_search/2_deep_dive_image_search.ipynb#W0sdnNjb2RlLXJlbW90ZQ%3D%3D?line=9) DataCollection(p('[./train/deepfake_video/aejgdsuoqg.mp4](https://vscode-remote+ssh-002dremote-002b7b22686f73744e616d65223a2253485445435f646576656c6f70227d.vscode-resource.vscode-cdn.net/home/image_check/code/examples/image/reverse_image_search/train/deepfake_video/aejgdsuoqg.mp4)')).show()

File [~/anaconda3/envs/towhee/lib/python3.8/site-packages/towhee/runtime/pipeline.py:116](https://vscode-remote+ssh-002dremote-002b7b22686f73744e616d65223a2253485445435f646576656c6f70227d.vscode-resource.vscode-cdn.net/home/image_check/code/examples/image/reverse_image_search/~/anaconda3/envs/towhee/lib/python3.8/site-packages/towhee/runtime/pipeline.py:116), in Pipeline.output(self, *output_schema, **config_kws)
    113 dag_dict[self._clo_node]['next_nodes'].append(uid)
    115 run_pipe = RuntimePipeline(dag_dict, config=config_kws)
--> 116 run_pipe.preload()
    117 return run_pipe

File [~/anaconda3/envs/towhee/lib/python3.8/site-packages/towhee/runtime/runtime_pipeline.py:140](https://vscode-remote+ssh-002dremote-002b7b22686f73744e616d65223a2253485445435f646576656c6f70227d.vscode-resource.vscode-cdn.net/home/image_check/code/examples/image/reverse_image_search/~/anaconda3/envs/towhee/lib/python3.8/site-packages/towhee/runtime/runtime_pipeline.py:140), in RuntimePipeline.preload(self)
    136 def preload(self):
    137     """
    138     Preload the operators.
    139     """
--> 140     return _Graph(self._dag_repr.nodes, self._dag_repr.edges, self._operator_pool, self._thread_pool)
...
  File "/home/image_check/anaconda3/envs/towhee/lib/python3.8/site-packages/towhee/runtime/operator_manager/operator_loader.py", line 59, in _load_legacy_op
    module = importlib.util.module_from_spec(spec)
  File "", line 553, in module_from_spec
AttributeError: 'NoneType' object has no attribute 'loader'
Output is truncated. View as a [scrollable element](command:cellOutput.enableScrolling?9cfee1bc-701f-405f-9006-130d95f68b21) or open in a [text editor](command:workbench.action.openLargeOutput?9cfee1bc-701f-405f-9006-130d95f68b21). Adjust cell output [settings](command:workbench.action.openSettings?%5B%22%40tag%3AnotebookOutputLayout%22%5D)...

rm ~/.towhee/operators/towhee/deepfake  and try again

rm ~/.towhee/operators/towhee/deepfake and try again

it works, thanks!


Make the Context class swappable

This allows to have more control on how the context works. For example which attributes are required, it's default values or validation.
Here's a short sample for illustration:
class MyInteractor
  include Interactor

  self.context_class = Class.new do
    include Context::Mixin

    attr_reader :foo
    attr_accessor :my_export

    def initialize(foo: nil)
      @foo = foo
    end
  end

  def call
    if context.foo
      context.my_export = "Got: " + context.foo.to_s
    else
      context.fail!(my_export: "Error")
    end
  end
end

puts MyInteractor.call(foo: "Hi").my_export # "Got: Hi"
puts MyInteractor.call.my_export # "Error"
MyInteractor.call(unexpected: "information") # ArgumentError (unknown keyword: unexpected)

This PR probably lacks quite some documentation etc. I just wanted to get your input if this is something you'd consider. (Obviously I'm happy to put more work into this if you do)

Specs are failing due to the development dependency on bundler ~> 1.9 and travis has the current 2.0.2 installed on more modern rubies.
That version requirement got dropped on master in 2c3d62e48dd614fc292fe0fcb1d79871fece6049

Thank you for the contribution and I'm sorry that it's taken so long to get eyes on it.
 I like the idea of making the Context class configurable as part of a larger effort to make working with Contexts easier. I'm not sure yet what that looks like yet but it will be a focus of a 4.0 release at some point in the future.


Question: How to filter elements in MutableObservableArray2D?

Hello running on Bond 7 here.
How do I filter elements from a MutableObservableArray2D?
I have a sectioned list of items in a tableview and I need to add search functionality that filters each of the sections by the search text.
I don't understand how to use the .filter() method because it returns a TreeChangeset, could someone explain?
Thank you!

@dsringari I am also having the same issue. Have you found any solutions ?

I have the same question

If anyone is still looking for an answer, here is how I solved this problem.
// let's say you have an observable two-dimentional array
let array2D = MutableObservableArray2D(...)

// you can get a two-dimentional array of its items like this
let sections = array2D.collection.children.compactMap({ $0.section?.items })

// then you can turn it into a regular array
let allItems = Array(sections.joined())

// and filter
let filteredItems = allItems.filter({ /* your filtering logic here */ })


"Hot exit" is meaningless to user, and user isn't prompted about it on first use.

VSCode Version:
1.45.0
OS Version:
Mac OS 10.15.4
Steps to Reproduce:

Have a file open and make some changes.
Close VS Code.

Does this issue occur when all extensions are disabled?: Yes/No
Probably.
Why is there no "problem description" or expected/actual behavior section in this bug template?
Anyway, the problem is the one reported in issue 21228 (closed), but compounded by the use of the meaningless term "Hot exit" in the settings and the failure to prompt the user about it on first use (as a comment in that issue says it's supposed to). I searched the settings for this behavior using various terms and never found it. I found it only because of that bug report.
Read the text for this setting; I can't imagine a more obscure way to express what it does: "Hot Exit: Controls whether unsaved files are remembered between sessions, allowing the save prompt when exiting the editor to be skipped."
Which do you think is more likely: Someone searching for "Prompt to save files on exit" or someone searching for "Remember unsaved files between sessions?"
Please change the setting name and description to something resembling "save files on exit." I have lost work just now because of this behavior, as reported in the other issue. Thanks!

Which do you think is more likely: Someone searching for "Prompt to save files on exit" or someone searching for "Remember unsaved files between sessions?"

Luckily the settings search will find both so it doesn't matter which is more likely:

You can also search the internet and you'll probably hit the feature.

Please change the setting name and description to something resembling "save files on exit."

We can't change the setting name as too many people rely upon it, and the description seems fine to me? The name hot exit is commonly used in other editors which is why we used it.
The first 4 results on Google for "vscode save files on exit" are directly related to the feature, including the official documentation page that describes the feature. If you don't like hot exit because it doesn't retain the undo stack, you can disable it or wait until https://github.com/microsoft/vscode/issues/15135 is fixed.

Thanks for the reply. I disagree, however. I've been programming professionally on Windows, Unix, and Mac with various tools and IDEs for 25 years (egads) and I don't recall ever encountering the term "hot exit." Also, when doing a settings search and looking through hits, a reasonable person is going to look at the name of each setting primarily. That's no help here. And then the description is as obtuse as possible. I don't see how people can be "relying on" this description. If we can't even improve a couple lines of descriptive text, this is a dead-end product.

The feature/name is modeled after Sublime which also enables it by default and doesn't prompt people about the first use.
"save files on exit." isn't any better though, to "save" a file means it will no longer be dirty. That's not what's happening as we're remembering/backing up the file, which is another term where the setting is a number 1 match:

If it prompts to save the file on exit, and you accede, it is no longer dirty. I don't see what the problem is there.
All the description has to say is, "Prompt to save files on exit, or remember changes between sessions without prompting or saving."


Questions

The Challenge questions are standard IMHO. Only the answers are different. So in the usage example, are we supposed to replace the below questions with the actual questions.
q_arr = [
'question1',
'question2',
"question3",
'question4',
'question5',
'question6',
]
please provide with a exact instruction on how to run the sample file.

yes, you just need to copy paste (all possible) questions that can appear on "Security Questions" Page,
When you register for the first time, you select a set of 5-6 questions, the same questions need to be added to array. The length of the q_arr does not matter, it should just cover all possible questions that you have chosen at time of registration, length of a_arr should be same as q_arr with answers in same sequence.
Hope that clarifies.

Awesome swapnil,
transaction password has been removed. did you login recently with old python lib 3.7. can you please confirm if txn passwd is still required or not.

Not required. I will update the readme file. Thanks!

hi swapnil,
thanks for the heads up. i stumbled upon pyalgotrade libraray. i suspect you already are aware of it.
i am a novice user of python. i was able to run all the pyalgotrade example without error. i would love to see a similar experience with yours too.
what we need is data feed free of charge (at least what brokers receive) after logging in. i am told others (data providers) get many ticks per second at a huge cost from NSE.
equipped with real-time data and our already tested strategy we just have to replace the trade functions of our strategy.

HI Swapnil,
Im getting below error while trying to run the script.
Traceback (most recent call last):
File "E:\Stocks\chrome\Kiteauth.py", line 21, in
h = k.orders()
File "C:\Python27\lib\site-packages\kiteconnect_init_.py", line 336, in orders
return self.get("orders")
File "C:\Python27\lib\site-packages\kiteconnect_init.py", line 455, in _get
return self.request(route, "GET", params)
File "build\bdist.win-amd64\egg\kitewrapper_init.py", line 206, in _request
KeyError: 'status'
anything i need to install in addition to your wrappers.

Hello Swapnil,
I am also getting the same error
KeyError: 'status'
Let me know what needs to be done.

Following piece of code should follow the constructor of KiteFront & should be called before querying for holdings.
if k.connect():
print('Logged in to Zerodha')
else:
print('Check credentials')
P.S. README should be updated accordingly.

sir i am new in coder i dont know coding and try to install this in my linux can you please guide me i know linux very well


feat: unixfs symlink creation

The minimal API and perhaps too verbose test cases around the feature. While I did check the cids to match some go-ipfs version cids, I think there might still be corner cases around even this very minimal API.

bors r+

well actually hold up this creates more work for #294. maybe wait a while with that.
bors r-

bors r+

Cancelled the pull_request workflow.


remove domain redirect OPS-2287

What changed, and why it matters
Currently, we are using Netlify _redirect.txt from domain level redirect, however since we are moving to Cloudflare Pages by end of Nov, it doesn’t support domain level redirect. For that, we would need to rely on Route 53 to do the redirect. Related ticket OPS-2287
When to merge this PR
Once the domain level path forwarding redirect is working (pending PR merge) from https://developer.aiven.io/* -> https://docs.aiven.io/*, this PR can be merge.

@lornajane Adding this PR into your radar


Can't connect to local Windows containers

Question:
When I follow the installation guide for Windows containers, I get the following scenario after I create my user:

Clicking connect shows the following box:

Checking the log in Docker For Windows give me the following output:

2020/02/25 15:45:53 server: Reverse tunnelling enabled

2020/02/25 15:45:53 server: Fingerprint e9:27:c6:1d:87:59:c7:c3:f0:bd:e3:a7:e6:87:d4:13

2020/02/25 15:45:53 server: Listening on <IP_ADDRESS>:8000...

2020/02/25 15:45:53 Starting Portainer 1.23.1 on :9000

2020/02/25 15:45:53 [DEBUG] [chisel, monitoring] [check_interval_seconds: 10.000000] [message: starting tunnel management process]

2020/02/25 15:46:06 http error: Invalid JWT token (err=Invalid JWT token) (code=401)

2020/02/25 15:46:06 http error: No administrator account found inside the database (err=Object not found inside the database) (code=404)

2020/02/25 15:46:20 http error: Unable to initiate communications with endpoint (err=error during connect: This error may indicate that the docker daemon is not running.: Get http://%2F%2F.%2Fpipe%2Fdocker_engine/_ping: open //./pipe/docker_engine: message readmode pipes not supported) (code=500)

2020/02/25 15:49:08 http error: Unable to initiate communications with endpoint (err=error during connect: This error may indicate that the docker daemon is not running.: Get http://%2F%2F.%2Fpipe%2Fdocker_engine/_ping: open //./pipe/docker_engine: message readmode pipes not supported) (code=500)

I can't get it running on Windows containers, and Linux containers is not an option for me.

Yes, this is a recently known issue.
You can temporarily use the portainer image: portainerci/portainer:fix3568-bump-go-winio-lib-windows1809-amd64
Or -windows1803
Or -windows1903
Depending on your os ver.
We will release Portainer 1.23.2 asap with a fix for this.
N

That is working - thank you!
Can we assign another ticket to this one, or is it the first open ticket on it?

Already a prior open ticket, will get William Conquest to merge them.

Closing as duplicate of #3568

I just had this problem on Docker for Windows v19.03.8 on Windows 10 v10.0.18362.657, but this fix image works: portainerci/portainer:fix3568-bump-go-winio-lib-windows1903-amd64, so I'm wondering if this was expected to have been merged into the latest by now?

It will be part of Portainer 1.23.2 release (due Friday).
However, please see our latest blog on other Windows Platform issues uncovered during testing: https://www.portainer.io/2020/03/docker-on-windows-platforms-with-portainer-known-issues/


Switch from coveralls.io to codecov.io

Reasoning

Recently, coveralls.io has broken a couple times and caused us build failures. On other projects, I have run codecov.io for years with no such problems.
Coveralls.io forces us to use a private GitHub security token. This is extra work we don't need to do with codecov.io. (Particularly since these tokens expire every 12 months, and we would need to keep people on top of that.)
Codecov.io will report any code coverage problems during a PR by opening a comment on the PR page. This is particularly handy, as developers can get a nice GUI explaining what lines of code they missed in their coverage.

In the end, this is a low priority issue, since what we have now is working. But, this is also an exceptionally low-effort issue to fix, as codecov.io is all but automatic.

I have no problem with that.

There have been a couple of minor outages with coverals.io this week.
I thought I was going to close this ticket AGAIN, but now I'm thinking maybe it's still relevant.

Okay, in the past 13 months, coveralls has been pretty stable. So I will close this ticket, and only reopen it if we have more issues.

I thought I was past this. But coveralls.io broke again today:
https://github.com/terrapower/armi/actions/runs/3660420103/jobs/6188235179#step:8:773
report: commands[2]> coveralls --service=github
Not on TravisCI. You have to provide either repo_token in .coveralls.yml or set the COVERALLS_REPO_TOKEN env var.
Traceback (most recent call last):
  File "/home/runner/work/armi/armi/.tox/report/lib/python3.10/site-packages/coveralls/cli.py", line 64, in main
    coverallz = Coveralls(token_required,
  File "/home/runner/work/armi/armi/.tox/report/lib/python3.10/site-packages/coveralls/api.py", line 49, in __init__
    self.ensure_token()
  File "/home/runner/work/armi/armi/.tox/report/lib/python3.10/site-packages/coveralls/api.py", line 61, in ensure_token
    raise CoverallsException(
coveralls.exception.CoverallsException: Not on TravisCI. You have to provide either repo_token in .coveralls.yml or set the COVERALLS_REPO_TOKEN env var.

I have no idea why they are suddenly mentioning Travis CI.  We have never used it.
I can't tell if our token expired, or they just changed their system, so we need a different token name now.
TBD.


Add ea repo to Grape repos.

Grape is taking a long time to download dependencies on some boxes.

[merge]

@chirino Does it fix this then: https://github.com/redhat-ipaas/ipaas-rest/issues/261 ?


Re-enable import order linting

Fixes current errors as well

Does this PR need a docs update or release note?

[ ] :white_check_mark: Yes, it's included
[ ] :clock1: Yes, but in a later PR
[x] :no_entry: No

Type of change

[ ] :sunflower: Feature
[ ] :bug: Bugfix
[ ] :world_map: Documentation
[ ] :robot: Supportability/Tests
[ ] :computer: CI/Deployment
[x] :broom: Tech Debt/Cleanup

Issue(s)

closes #2927

Test Plan

[x] :muscle: Manual
[ ] :zap: Unit test
[ ] :green_heart: E2E

The clues pr finally merged.  This should be ready to go now.


#1555 added updated DAO template

Adresses/Fixes #1555.
Implements

added new crud_java_daos template
added entity_infrastructure templates to dao template
replaced PaginatedListTo with Spring Page

@devonfw/cobigen

Can be closed as mentioned by #1555.


Introduce ByteBuf.maxFastWritableBytes() method

Motivation
ByteBuf capacity is automatically increased as needed up to maxCapacity when writing beyond the buffer's current capacity. However there's no way to tell in general whether such an increase will result in a relatively costly internal buffer re-allocation.
For unpooled buffers it always does, in pooled cases it depends on the size of the associated chunk of allocated memory (PooledByteBuf.maxLength), which I don't think is currently exposed in any way.
It would sometimes be useful to know where this limit is when making external decisions about whether to reuse or preemptively reallocate.
It would also be advantageous to take this limit into account when auto-increasing the capacity during writes, to defer such reallocation until really necessary.
Modifications
Introduce new AbstractByteBuf.maxFastWritableBytes() method which will return a value >= writableBytes() and <= maxWritableBytes().
Make use of the new method in the sizing decision made by the AbstractByteBuf.ensureWritable(...) implementations.
Result
Less reallocation/copying when working with ByteBufs.

This would be useful for #8931 which currently incorrectly assumes that growing up to maxCapacity is always cheap.
I can add some unit tests if folks agree with the addition.

FYI I force-pushed a minor rework to this including some update to the commit message. I originally forgot that ByteBuf was not an interface :) so the new method can go there with its default impl. I can't think of a problem with this but I know it would be a first and appear a little inconsistent next to all the others with default impls in AbstractByteBuf.

A unit test or two would be nice.

@ejona86 @trustin any concerns ?

I wasn't aware that the buffer may be copied/reallocated to reach its maxCapacity. And I hadn't realized that writing may increase the capacity... which means isWritable() is stricter than actual writes and writableBytes() is misleading. I will say I have wanted an API that would let me expand a ByteBuf to fill its allocated chunk.
It sort of seems like the allocator should just be guaranteed to return a ByteBuf whose capacity is at least what you request, so that capacity matches the chunk size. Or something... But those sort of changes are impossible.
Given the current methods writableBytes() and maxWritableBytes(), maxFastWritableBytes() seems fair. Although it sort raises the question of "what's the point in the current capacity?" I would consider a maxFastCapacity(), and let someone manually change the capacity. That would keep capacity() relevant.
// I'd be prone to doing this myself
ByteBuf buf = alloc.buffer(4 * 1024);
buf.capacity(buf.maxFastCapacity());

Although if you have a handler that is given a buffer via a write() and you want to append to it, then I guess you still would want to use maxFastWritableBytes(), since the capacity will be "wrong." Very well. capacity() is useless because the allocators aren't given any freedom when setting it.

@njhill please add some unit tests.

@ejona86 I agree the current semantics w.r.t. capacity and writablity are unintuitive. What would make this cleaner and I think you are also alluding to (netty 5?) is to have precise capacity be determined by the buffer itself and anywhere a capacity is currently specified would instead be a min capacity (i.e. in allocator args, and capacity(int) would be replaced with ensureCapacity(int) where the resulting capacity would be >=).
I was actually already going back and forth on the idea of maxFastCapacity() instead and would prefer it apart from the fact that the semantics are kind of awkward in the unpooled case. I would read it to mean "capacity can be fast-changed to anything <= this value" but unpooled buffers incur the cost for any  nonzero capacity change, even a reduction. maxFastWritableBytes() nicely avoids that.

@normanmaurer @carl-mastrangelo unit tests now added.

@netty-bot test this please

@normanmaurer I just noticed the failed tests - I hadn't noticed locally because I wasn't running with paranoid leak detection, have pushed a commit to fix.

@netty-bot test this please


Proposal - Use ASM to generate classes required for custom data

..asm or javassist, or any other bytecode manipulation framework, which is sponge/forge already using
Every "custom data" requires you to write ridiculous amount of code which is almost always +- same.
It would be helpful to have some kind of preprocessing, which generates required classes during sponge startup. (data builder, immutable(builder),. .., Keys...)
It should be enough to specify only one interface which will be used as a proxy and one key variable for a class representing custom data.
eg
@Persistant //optional annotation, whenever the data will be persistant during server restarts
public interface SomeCustomData {

    List<String> getSomeStringList();

    void setSomeStringList(...);
}

public class SomeKeys {

	@DataProxy(SomeCustomData.class)
            @DataQuery("SomeList") //same as current DataQuery#of
	Key<Value<SomeCustomData>> KEY;
}

Sponge.getDataManager().generateDataManipulators(SomeKeys.class, pluginInstance);all fields annotated with dataproxy would be initialized, basically calls Sponge.getDataManager().register(SomeCustomDataProxy.class,SomeCustomDataProxy.Immutable.class, new SomeCustomDataProxy.Builder()); (*Proxy classes would be created by asm)
In a next step method #register would inject all keys in the class SomeKeys class under the hood -
SomeKeys.KEY = KeyFactory.makeSingleKey(<typetoken>, <valueof @DataQuery>, "<pluginid>:<classname>, <classname>);
DataManipulator a = Sponge.getDataManager().getDataManipulator(SomeKeys.class); //returns instance of previously created datamanipulator
someEntity.offer(a);
SomeCustomData data;
if (!someEntity.get(SomeKeys.KEY).isPresent()) {
    data = Sponge.getDataManager().getProxy(SomeCustomData.class).getClass().newInstance(); //getProxy method would return implementation of SomeCustomData which was created previously, during `#generateDataManipulators call`
} else {
    data = get(SomeKeys.KEY).get();
}
 data.setSomeStringList<...>;
 someEntity.offer(SomeKeys.KEY, someCustomData)

I swear there is an issue somewhere for this already but I can't find it. But yes this is something we've planned for a long time and have been working towards building the required parts for.

@Deamon5550 #1168 / #1198

As @kashike already mentioned, there's a PR that has this already, there's a few steps I need to take for the implementation prior to it being achievable (since it does break a lot of things).


Remove artifacts from conda/wheel packages residing in root level

Removing files that are making their way to conda packages at root-level.

Thank you @AndresGuzman-Ballen ! It is actually wired it was added to wheel..

No problem! Anything else you'd like me to do before merging?

Friendly ping to merge this :)

Woohoo!

@AndresGuzman-Ballen @oleksandr-pavlyk I've just checked two builds and this PR did not affect result package.

Sorry, it did. I just extract two same packages...


Task: create document about preserving the variable storage.

Just helped a friend debug his usage of Godmode.
He didn't preserve the ordering of variabes in the new contract and hence messed up the contract storage.
Need to remind people of this concept when dealing with Godmode.

We can also create a validator to check basic things like this

Added to docs but we can come back to validator if needed later


Sync published with master

Proposed changes

Unreleased project version (optional)

Related issues (optional)

Deploy preview for docsdocker ready!
Built with commit 1f77709e494e99b8d9237bb0135dcc7735d788ff
https://deploy-preview-8258--docsdocker.netlify.com


As an exchange that uses IDEM, I want an IDEM user to receive a push notification, so they can register and verify without scanning a QR code

Instead of users having to scan a QR code, an integrated website can send a push notification for user to verify

Given I am on GPIB and I have verified my IDEM email in the IDEM app
When I enter my IDEM email on registration and click "Register with IDEM"
Then an alert is shown on my IDEM app with the text "Would you like to use IDEM to register and verify with GPIB?"
When I tap "Yes" on the notification
Then I will be registered and verified (if I have already been verified by Auspost in IDEM) with GPIB (if not verified with Auspost then verify and once verified post response through proxy to IDEM)

On GPIB https://github.com/dltxio/v2.getpaidinbitcoin.com.au/pull/145

https://docs.expo.dev/push-notifications/overview/
https://expo.dev/notifications
https://www.youtube.com/watch?v=7TGQiI4guNE

@bitcoinbrisbane I think this is something that needs to come from GPIB. GPIB needs to recognize the email address and send to push notification, and then maybe navigate to idem from there and allow user to sign up in idem instead, or maybe fetch data from proxy if we are implementing that in a way that allows us to fetch data stored in idem

For testing:

add all of the claims via IDEM,
verify claims vis IDEM.
via postmain "POST": https:proxy.idem.com.au/user/notification/[put message here]
or
curl --location -g --request POST 'https:proxy.idem.com.au/user/notification/[put message here]'
--data-raw ''

POST request not working

Currently blocked by issues in #106
Unable to save DOB

Testing blocked by: https://github.com/dltxio/idem-mobile/issues/106#issuecomment-1163830399

push tokens are not unique - because of this I receive multiple notifications

Given I am on GPIB and I have verified my IDEM email in the IDEM app,
When I enter my IDEM email on registration I can not see an option to register with GPIB on both portal and test addresses
Could you please include the link for GPIB so we know which one to use for testing/demo?

Testing notes

Scan QR code and get a notification from idem, Once you press the notification it should take you to GPIB screen on 3rd parties page :)

@C00p3rb123 https://testv2.getpaidinbitcoin.com.au/register

QR Code working however,
Given I am on GPIB and I have verified my IDEM email in the IDEM app, when I enter my IDEM email on registration and click "Join with IDEM" I receive an error.
UI not clear upon first viewing. Expected outcome - There should be a distinction between the QR code and email registration. For example an "OR" between the two.

Blocked by #292 - unable to verify all claims

Same as https://github.com/dltxio/idem-mobile/issues/100#issuecomment-1191023105

Idem notification doesn't contain the option to select Yes (or no). Instead, clicking on it takes the user to the GPIB page in the venders tab without signing them up

@Mitchell139 Yes, we did showcase and talked about it and Lucas agree take to vender detail screen and signup, the only thing we need to do is update the ticket.

Blocked by #317

Blocked by error in #245

Given I am on GPIB and verified all IDEM claims in the IDEM app, when I enter my IDEM email on registration and click "Join with IDEM" I receive an error saying Name or service not known


HIL should add vlan-names on the switch when setting vlans on a port.

We can do this when we enable a Vlan on a port. So HIL can, at that point, set the VLAN name to be whatever is in the database with additional metadata. Something like NetworkName-ProjectName-HIL
That way an admin on the switch can see what networks (belong to)/(are in use) by HIL.

To clarify, we are considering setting the VLAN/Network-specific metadata field on the switch to be something. Since the tag may be too long for some switch fields, the driver would need to truncate it.
Note that this is similar to what #687 proposed to do for switch ports (adding a Managed by HIL tag), but instead of ports we would be doing it to networks.


RFC: Styling the root Hub Framework view

Many apps needs to be able to style the Hub Framework’s (HF’s) root view (i.e. currently the collection view). The most common is to set a background color or other similar customizations. As it’s not possible to subclass HUBViewController today users of the framework are left with two possible workarounds.
These workaround are to to either front-load the view or wrap HUBViewController with a parent. Both are bad, for different reasons. The first workaround is bad since it breaks the life cycle of the view and might result in performance issues. The second option is also bad since it requires hacking with the view hierarchy. Forcing user’s of HF to make assumptions as to where in the hierarchy the root HF view is supposed to be. One cannot even look for a specific type since that is unknown or might even be, just, UIView.
The second workaround also suffers from low code-reuse. Since each implementing app needs to duplicate this.
Proposal
As such I propose we implement one of two solutions.

Make HUBViewController subclass-able.
Add a “styler” property which takes a block.

Both of which solves the issues laid out above.
Proposal A: Subclassing
Currently HUBViewController does not support subclassing since the designated initializer isn’t part of the public API. This change would involve moving the current from the private header to the public.
Our use case here is basically the use-case that subclassing was designed for, IMO 😄
Advantages

Clear, standardized way of customizing the view controller as needed.
Supports much deeper customization if needed at any point in the life cycle.
Allows the user of the framework to decide when a new style needs to be applied.

For example in the case of a theming system that goes from Theme A 👉 Theme B.

Disadvantages

The initializer is massive

Although this might help in looking into refactoring it as well as HUBViewController.

Less clear on how to create a Hub view.

The view controller shouldn’t be instantiated by users of the framework. Instead one should get an instance from the factory.

Subclasses and their unintended affects and effects when the class isn’t fully designed to be subclassed.
Still requires a custom wrapping view controller factory.

Proposal B: Styler
We add a property which takes a block that styles the root view and is ran at appropriate times. Appropriate times might be during -viewDidLoad and when dynamic type changes occur.
Example implementation
HUBViewController.h
typedef void (^HUBViewStyler)(UIView *view);

@interface HUBViewController : UIViewController <...>
// ...

/// A block that styles the view controller’s view.
@property (nonatomic, copy, nullable) HUBViewStyler viewStyler;
@end

HUBViewController.m
@implementation HUBViewController
- (void)viewDidLoad
{
    [super viewDidLoad];

    // ...

    [self applyViewStyle];
}

- (void)handleDynamicTypeChangeNotification:(NSNotification *)changeNotification
{
    [self applyViewStyle];
}

- (void)applyViewStyle
{
    HUBViewStyler viewStyler = self.viewStyler;
    if (viewStyler) {
        self.viewStyler(self.view);
    }
}
@end

Advantages

We don’t have to take into account subclass-ability when making changes to HUBViewController.
Clear expectation on what should be styled while we control when it happens.

Disadvantages

The user would only be able to style the view we pass in to the block.
The user wouldn’t be able to handle other events and edge cases.
There might be more situations where the style should be re-applied. We wouldn’t be able to support that in this case.

For example in the case of a theming system that goes from Theme A 👉 Theme B.

Not considered

Allowing users of the framework to inject the root view that should be used.

This might be something we want anyhow in the future. To support more advanced use cases.

This is a super interesting topic.
My thoughts:

I generally try and make most classes final as subclassability introduces a fair amount of fragility into a framework.

That said, I am in favour of proposal A. We are asking users of Hub to trust the framework with a significant portion of their UI and we should do our best to support "deep" customisation. The main issue with proposal B is that it requires us to make too many assumptions about what kind of customisation users are after and when to apply it.

We can and we should, however, mitigate some of the damages of subclassability by offloading critical responsibilities from the HUBViewController to other non-subclassable classes. It's currently responsible for a lot...

@rastersize for this specific case I'm not sure I follow the problem of simply setting the hubViewController.view.backgroundColor similar to how it's done in the demo application.
https://github.com/spotify/HubFramework/blob/master/demo/sources/AppDelegate.swift#L206

@mhallendal That might be fine for a demo app. However it has the side-effect of loading the view before it’s supposed to, or even needs to, be loaded. Which is undesirable.
Furthermore it ties the styling of the view to the part of the app which deals with navigation. Which would break the separation of concern.

Ah, that's what you meant about front load the view above. I'm unsure what the problem with doing that would be but I agree about the page loading mechanism shouldn't be concerned with it. However the page loading mechanism in your app could delegate that elsewhere.
Not optimal but option A sounds like a pretty invasive change that we would prefer not to do now and option B adds even more concepts to the framework.
That said, I haven't looked into enough what it would mean to make HubsViewController subclassable. For now it's probably easiest to just do something similar to what the demo app does (or embed it in another view that sets the background color).

The Hub Framework is being phased out at Spotify, and therefore we will not be maintaining it further.


feat(erc777): <- add custom function call when minting

Since ERC777 hooks have been removed, it's impossible to have a contract called when minting the pToken.
This PR adds a IPReceiver interface which exposes a receiveUserData() function that is called when minting the pToken.

I just added a test where the recipient contract does not implement the IPReceiver interface.

Update: Decision has been made to use excessivelySafeCall for this.

In order, I added unit tests for return bombing in 065cddf5f28e0623088cfcd4f633aaadde99430c, and verified they fail.
Then implemented excessivelySafeCall, and now the tests pass.

Approved in pvt with @themetaseq & @wernervoncroy.


Description meta tag (unique)

The Description meta tag content is a source for descriptions in site snippets in the  search results. The snippet includes the text that is most informative and relevant to the search query.
The meta description should:

Be unique for every site page.
Be informative, with grammatically correct sentences, without abuse of keywords and phrases, capital letters, advertising slogans, and so on.;
Reflect the current page status.
Match the document language.
Differ from the content of the title element.

Source: https://yandex.com/support/webmaster/indexing-options/description.html
This is equally suitable for all search engines.
Perhaps we should think about what should be done in this vein.

This can be done mostly in posts. There's not much data to extract anywhere else

Yes, that would be great!


Following the preceding vehicle

The nature of following the vehicle ahead can lead to unwanted lane departure. I am currently using version 7.8. While running on the highway, I followed the car in front to the rest area.

Unwanted lane departure may occur due to following vehicle. I am currently using version 7.8. While driving on the highway, my vehicle followed the vehicle ahead and entered the rest area.

@jjg3873 Please edit your issue to use the Bug Template. comma need much more information than what you have provided in order to investigate the issue.
See here: https://github.com/commaai/openpilot/blob/master/.github/ISSUE_TEMPLATE/bug_report.md


Handle complex images with line SUFFIX and PREFIX data

Our test Cassini image (W1782844276_1.IMG, W1782844276_1.LBL) has a LINE_PREFIX_TABLE which looks like this:
OBJECT = LINE_PREFIX_TABLE
      INTERCHANGE_FORMAT = BINARY
      ROWS = 1024
      COLUMNS = 10
      ROW_BYTES = 24
      ROW_SUFFIX_BYTES = 1024
      ^LINE_PREFIX_STRUCTURE = "../../label/prefix3.fmt"
END_OBJECT = LINE_PREFIX_TABLE

Without accounting for the line prefix data an image looks like this:

The PDS Spec has the following to say in section A.20:
In more complex images, each individual line may have some attached data
which are not part of the image itself (engineering data, checksums, time tags,
etc.). In this case the additional, non- image parameters are accounted for as
either LINE_PREFIX_BYTES or LINE_SUFFIX_BYTES, depending on whether
they occur before or after the image samples in the line. These keywords indicate
the total number of bytes used for the additional data, so that software processing
the image can clip these bytes before attempting to display or manipulate the
image. The structure of the prefix or suffix bytes is most often defined by a
TABLE object (in the same label), which will itself have ROW_SUFFIX_BYTES
or ROW_PREFIX_BYTES, to allow table-processing software to skip over the
image data. Figure A.1 illustrates the layout of prefix and suffix bytes around an
image.

As far as this Cassini data is concerned, there is not a simple LINE_PREFIX_BYTES label.  There is an entire TABLE object that describes the suffix data.  This implies that we need to be able to parse TABLE objects to handle these more complicated images.

Wait until #22 is done as this is a special case.


Explicitly shut down meter provider in a test

Otherwise the test hangs for ~30s.

Going to open a new PR with signed commits.


Add: Faithlife TV - The Family Center

Channel Name
Faithlife TV - The Family Center
Native Name (optional)
No response
Network (optional)
No response
Country
US
Subdivision (optional)
US-WA
City (optional)
Bellingham
Broadcast Area
s/US-WA
Languages
eng
Categories (optional)
religion;family
NSFW
FALSE
Launched (optional)
No response
Closed (optional)
No response
Replaced By (optional)
No response
Website (optional)
https://faithlifetv.com/
Logo
https://files.logoscdn.com/v1/files/9154786/content.svg?signature=mKUuAU6f7RYxrskmDYNsKHbdVMU
Notes
Streaming URL:
https://resi.media/fcc-cc-hn/Manifest.m3u8

Streaming URL:
https://resi.media/fcc-cc-hn/Manifest.m3u8

This is not a live broadcast.


refactor Name() and ExtendedName(c) methods

one more comment: can you revisit where NameForAnalyzerOut  is called with nil and where not?
when is it required? when it can be assumed it is not needed?
are there places where the config can actually be retrieved but currently not used in the call? and if so, why?

one more comment: can you revisit where NameForAnalyzerOut  is called with nil and where not? when is it required? when it can be assumed it is not needed? are there places where the config can actually be retrieved but currently not used in the call? and if so, why?

I assumed that it is not needed where we originally called the previous func without the config... and passed the config where we originaly called ExtendedName (with the config).

one more comment: can you revisit where NameForAnalyzerOut  is called with nil and where not? when is it required? when it can be assumed it is not needed? are there places where the config can actually be retrieved but currently not used in the call? and if so, why?

I assumed that it is not needed where we originally called the previous func without the config... and passed the config where we originaly called ExtendedName (with the config).

makes sense, but if you can revisit as suggested above this may help to better understand these aspects, update documentation as to where this is expected to be used, etc.. (maybe also find if it makes sense to add the config in other places, to be less error-prone).

looks good. There are more cases with NameForAnalyzerOut(nil) is used. Do you have insights about those cases?

in these cases the config param is not reachable, or that we need to make a lot of changes

looks good. There are more cases with NameForAnalyzerOut(nil) is used. Do you have insights about those cases?

in these cases the config param is not reachable, or that we need to make a lot of changes

@ShiriMoran can you review the places where NameForAnalyzerOut(nil) is now used in this PR, and whether it is safe to keep these calls, or whether the full name (with vpc prefix for multi-vpc cases) should be used instead?  (such as explainability output)

NameForAnalyzerOut(nil)

Syntactic and backwards compatibility wise, it is safe. Namely, all the places in which NameForAnalyzerOut(nil) are places in which Name() was used before
There are places in which  Name() was used before and now NameForAnalyzerOut(c) is called now, which is good
This leaves us in some mode of confusion, in which there seems to be no rule, or one that makes sense, as to when we avoid the VPC prefix
The above rule is "places where before we used Name() in functions that do not have the VPC config". I think we should avoid this as much as possible, namely avoid calling NameForAnalyzerOut with nil.
Thus, we should go over all the cases in which  NameForAnalyzerOut(nil) is called and try to replace it with  NameForAnalyzerOut(c); this will require adding vpc config parm to the relevant functions. This can be done in a followup PR @adisos @olasaadi99 (or in this one, what ever you prefer)

@ShiriMoran can you review the places where NameForAnalyzerOut(nil) is now used in this PR, and whether it is safe to keep these calls, or whether the full name (with vpc prefix for multi-vpc cases) should be used instead? (such as explainability output)

Syntactic and backwards compatibility wise, it is safe. Namely, all the places in which NameForAnalyzerOut(nil) are places in which Name() was used before
There are places in which  Name() was used before and now NameForAnalyzerOut(c) is called now, which is good
This leaves us in some mode of confusion, in which there seems to be no rule, or one that makes sense, as to when we avoid the VPC prefix
The above rule is "places where before we used Name() in functions that do not have the VPC config". I think we should avoid this as much as possible, namely avoid calling NameForAnalyzerOut with nil.
Thus, we should go over all the cases in which  NameForAnalyzerOut(nil) is called and try to replace it with  NameForAnalyzerOut(c); this will require adding vpc config parm to the relevant functions. This can be done in a followup PR @adisos @olasaadi99 (or in this one, what ever you prefer)

@ShiriMoran can you review the places where NameForAnalyzerOut(nil) is now used in this PR, and whether it is safe to keep these calls, or whether the full name (with vpc prefix for multi-vpc cases) should be used instead? (such as explainability output)

1. Syntactic and backwards compatibility wise, it is safe. Namely, all the places in which `NameForAnalyzerOut(nil)` are places in which `Name()` was used before

2. There are places in which  `Name()` was used before and `NameForAnalyzerOut(c)` is called now, which is good

3. This leaves us in some mode of confusion, in which there seems to be no rule, or one that makes sense for a user, as to when we avoid the relevant `VPC` prefix

4. The above rule is "places where before we used `Name()` in functions that do not have the `VPC config`". I think we should avoid this as much as possible, namely avoid calling `NameForAnalyzerOut` with `nil`.

5. Thus, we should go over all the cases in which  `NameForAnalyzerOut(nil)` is called and try to replace it with  `NameForAnalyzerOut(c)`; this will require adding `vpc config` parm to the relevant functions. This can be done in a followup PR @adisos @olasaadi99 (or in this one, what ever you prefer)

Thanks @ShiriMoran , sounds good. I think so as well.
@olasaadi99  please check if you prefer a separate PR for this.

prefer new pr


feat: change api v3 onboarding

- What I did
change apis to v3
- How I did it
- How to verify it
- Description for the changelog

Not required as the core logic to generating atSign will go to at_register package


Profile does not import from macOS to Ubuntu by URL

Testing #167161

I exported my profile on macOS
I imported it by pasting the URL on Ubuntu
Prompted to sign into Github
I was then stuck in an 'importing' state forever

Maybe related, I noticed the permissions prompt can create gists, but not read private gists:

The only error I noticed at trace level logs was a signature error on an extension:

Can you please set this internal setting extensions.verifySignature to false in default settings.json and retry?

That doesn't seem to make any difference

Prompted to sign into Github

Have you seen any quick pick after sign in?

No, no quick pick after signing in. Just straight to the loading state.

Can you please share the profile?

Sent in DM

Can you please try again in latest insiders and let me know if it works?

No luck 😞  Any more info I can collect?
Not sure if I'm supposed to, but I don't see anything requests at all in the Network tab when I toggle devtools.

Seems to be closer--a new error!

Yeah, this is from quick pick and shall be fixed in next insiders. Please retry when there is new insiders.

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.
Happy Coding!


aes_decode_rcon lookup in vaeskf2.vi pseudocode appears to be incorrect.

After the info from #267, Spike updated their implementation of vaeskf2.vi to handle the 1-based round indexing (so 2-14 instead of 1-13), but in doing so, changed the aes_decode_rcon lookup from
      const uint32_t rcon = kRoundConstants[round >> 1];
to
      const uint32_t rcon = kRoundConstants[(round >> 1) - 1];
but the spec still has aes_decode_rcon(rnd>>1).
Looking at A.3 Expansion of a 256-bit Cipher Key from the NIST AES spec, the first round constant value used is 0x01, so if the example begins at round 2 (considering there are 13 rounds in the example, and the first round must be even since it performs the round constant lookup), the round constant for round 2 is 0x01.  However, using the expression from the spec results in a round constant of 0x02 since rnd>>1 will be 1 for round 2.  Also, the last round constant used is 0x40 in the example, which is consistent with the Spike implementation (if Spike were incorrect, its table would need to be shifted and would then result in values outside 0x01 and 0x02).
If the reasoning above is correct, it would seem to imply the spec should use aes_decode_rcon((rnd>>1) - 1) like Spike does.

I think you are right, the pseudo code was not updated when the range was fixed.
https://github.com/rivosinc/riscv-isa-sim/blob/d2cfddd1141ba95adcfc9617e7767513f0f47146/riscv/insns/vaeskf2_vi.h#L74
static constexpr uint8_t kRoundConstants[7] = {
  0x01, 0x02, 0x04, 0x08, 0x10, 0x20, 0x40,
};
(...)
    if (is_even_round) {
      const uint32_t rcon = kRoundConstants[(round >> 1) - 1];
      temp = temp ^ rcon;
    }

It looks like this was implemented slightly differently in QEMU:
https://github.com/CodethinkLabs/qemu-ct/blob/b5191056c087a033a75232bcc94778ec09024670/target/riscv/vcrypto_helper.c#L484
        static const uint32_t rcon[] = {
            0x01000000, 0x02000000, 0x04000000, 0x08000000, 0x10000000,
            0x20000000, 0x40000000, 0x80000000, 0x1B000000, 0x36000000,
        };

        (...)

        if (uimm % 2 == 0) {
                    (...)
                    rcon[(uimm - 1) / 2];

With the same behaviour: imm of 2 is mapped to table entry 0, immediate of 4 is mapped to entry 1, ...

I filed https://github.com/riscv/riscv-crypto/pull/337 to align the pseudo-code such that the pseudo-code aes_decode_rcon helper function can be used in vaeskf2.vi pseudo-code to be conformant with AES specification.

Thanks for finding this Matt.
And, thanks for fixing it Nicholas.
Accepted pull request.


Review parentage of "malonyl-CoA synthetase activity"

I think "malonyl-CoA synthetase activity" GO:0090409 should (also) be a child of "CoA-ligase activity" (GO:0016405).
GO:0090409 - malonyl-CoA synthetase activity
Catalysis of the reaction: malonate + ATP + coenzyme A = malonyl-CoA + AMP + diphosphate.
GO:0016405 - CoA-ligase activity
Catalysis of the reaction: substrate + ATP + CoASH = AMP + diphosphate + substrate-CoA.

Looks like lots of the acid-thiol ligases are missing this parent. I will add it to them systematically.

Added all that hydrolyze ATP to AMP as children of CoA-ligase activity. @deustp01  in our definition of CoA ligase, we specify ATP--->AMP. This means that technically things like succinate-CoA ligase do not classify as CoA ligases becasue they don't fit this definition, it makes ADP or GDP. Do you think this is misleading and should we relax the definition of CoA ligase?

Thanks!  Can I check what will happen to the various 'fatty acid ligase' terms (GO:0015645 and children) as part of this fix?  Will they all become children of '"CoA-ligase activity"?
(The last comment on ticket  #14783 is also relevant to this.)

Ah. No, they won't but it looks like all of the x-chain fatty acid-COA ligases should because they fit the definition of a CoA ligase. The long-chain fatty acid [acyl-carrier-protein] ligase activity won't. But I think all the fatty acid ligases be children of acid-thiol ligase activity? It looks to me like it they should unless you know of some that aren't in GO yet, but are not. :
CoA ligase activity= Catalysis of the reaction: substrate + ATP + CoASH = AMP + diphosphate + substrate-CoA. If you agree we should open another ticket for these additional changes and assing it to me.

Ah. I see that the other ticket already asks/suggests some of the things I questioned above, so ne need to make yet another ticket. I think @hdrabkin and I should work on this together next week at the ontology workshop. I am wondering if there isn't a way to formally incorporate the chemicals into the terms descriptions to get automatic classification. A couple questions, since you sound like you have looked into this a lot:
Do you think we should relax the definition of CoA ligase activity to be: Catalysis of the reaction: substrate + nucleotide-triphosphate + CoASH = hydrolyzed nucleotide-triphosphate + phosphate + substrate-CoA?  I'm not sure how we would represent a 'hydrolyzed nucleotide-triphosphate' and the diphosphate in logical definitions. That might become probelmatic down the road when we try to tackle the cross references with ChEBI.
If we do this, all CoA ligase activity terms should become children of acid-thiol ligase activity. At least all the ones that currently exist. I went through all of them by hand yesterday and I think that would be correct.

@ukemi according to the authorities, "Ligases are enzymes that catalyze the joining of two molecules or two parts of a molecule with concomitant hydrolysis of the diphosphate bond in ATP or a similar triphosphate. Ligase is often used for the common name but in a few cases synthase[sic*] or carboxylase is used. Synthetase may be used in place of synthase for enzymes in this class." (http://www.brenda-enzymes.org/ecexplorer.php?browser=1&f[nodes]=&f[action]=open&f[change]=286 - mouse over a class name to see a tooltip with its definition)
*My Ochoa trained colleagues disagree - synthetase is correct; synthase is not - the latter term should be reserved for bond formation not accompanied by nucleotide triphosphate hydrolysis.
I guess that cleavage of ATP to AMP + PPi fits this definition, as well as cleavage to ADP + Pi.
The general dictionary definition of "ligase" deviates from this. I think we go with the biochemists here (ignoring the syn(the)tase issue and ignore the general, which is (Wikipedia):

In biochemistry, a ligase is an enzyme that can catalyze the joining of two large molecules by forming a new chemical bond, usually with accompanying hydrolysis of a small pendant chemical group on one of the larger molecules or the enzyme catalyzing the linking together of two compounds, e.g., enzymes that catalyze joining of C-O, C-S, C-N, etc. In general, a ligase catalyzes the following reaction:

Ab + C → A–C + b

or sometimes
Ab + cD → A–D + b + c + d + e + f

where the lowercase letters signify the small, dependent groups. Ligase can join two complementary fragments of nucleic acid and repair single stranded breaks that arise in double stranded DNA during replication.

If N is already OK to indicate A OR G OR C OR T (and if it isn't it probably should be because it''s a real parent-child relationship and useful) "hydrolyzed nucleotide triphosphate" would be NDP or NMP, whichever is generated by the molecular function that is being described. The broad ligase class does both, but any one kind of ligase does only one or the other - I don't know of any enzyme that can make a bond at the cost of one phosphate but that can make a superbond at the cost of two. The CoA-charging enzymes for example all do it at a cost of two.

Thanks @deustp01! I really appreciate the input. From this it looks like we have indeed been too restrictive on our definition of 'CoA ligase activity' by specifying the ATP-->AMP + diphosphate. If we relax the definition, then all CoA ligase activities will become subtypes of acid-thiol ligase activities and I can just move the aren't and essentially undo all the children that I did yesterday. But your last sentence leads me to question the placement of terms like 'succinate-CoA ligase (ADP-forming) activity'. Seems that it does it at a cost of one, right? Ontology development, it's so simple!

'The broad ligase class does both'. That's the hard part, I'm not sure how we would represent the class or NMP or NDP. The ones that are specific are easy.

But each subclass does one or the other, so can you omit this element of the logical definition for the parent and (tediously, with many possibilities for manual error) supply the correct one for the logical definition of each subclass? For the parent, can you have something consumption of NTP input and not specify what the output is, so you get at least some connection between the logic for the parent and child classes?

Yup, exactly! But not being able to formally define the parent is unsatisfying.

Just catching up: Agree that synthase should NOT be lumped in here.
In tRNA land, the amino acyl-tRNA synthetases are often called ligases. Somewhere in my head attic, I seem to remember a distinction about whether an enzyme-AMP intermediate is formed with ligases. I know DNA ligase does this, but the aa-tRNA synthetases do not.

Thanks all!
WRT these:

all of the x-chain fatty acid-COA ligases should become children of "CoA-ligase activity"
I think all the fatty acid ligases be children of acid-thiol ligase activity?
Do you think we should relax the definition of CoA ligase activity - all CoA ligase activity terms should become children of acid-thiol ligase activity

I'm no biochemist, but these proposals make sense to me based on what I've read and staring at the current GO.
I found this paper useful wrt to fatty acid ligases/acyl-CoA synthetases: PMID:17762044
(FYI: My interest in this is that we have a project within FlyBase to review the D.melanogaster enzyme classes, so using GO annotations and EC classifications as part of this.   Started with ligases, now working on isomerases, lyases next....)

Hmmm. But looking at the definitions, it looks like the
GO:0090409 - malonyl-CoA synthetase activity
Catalysis of the reaction: malonate + ATP + coenzyme A = malonyl-CoA + AMP + diphosphate.
is indeed a
GO:0016405 - CoA-ligase activity
Catalysis of the reaction: substrate + ATP + CoASH = AMP + diphosphate + substrate-CoA.

I'm going to leave this as is for the moment. If we decide to relax the definition of the CoA ligase activity, we can open it in a future ticket.


Javascript symbol search / outline is truncated

From @m-brt on April 21, 2016 0:7

VSCode Version: 1.0.0
OS Version: Windows 8

Steps to Reproduce:
Use this simple JS and press Ctrl-Shift-O
function myNewClass() {}
myNewClass.prototype.firstFunction = function() {};
myNewClass.theSecondFunction = function() {};
I tried different files in our project but it seems all found symbols/functions are truncated with ellipsis after 17 characers...

Copied from original issue: Microsoft/vscode#5584

The text comes back truncated from the TSServer. Moving to TS team.

@billti we are truncating the names of function and class expressions to maximum of 17 characters. any reason why we can not send the full name over?


ol.source.changed can not update data correctly

Describe the bug
A clear and concise description of what the bug is.
I am using vue3 ol. When the _features data is updated, the layer cannot be rendered normally, but init can load the data correctly in the layer.
To Reproduce
`watch(
markerLayers,
(_layers) => {
if (Object.keys(_layers).length > 0) {
  Object.keys(_layers).forEach((_m) => {
    const layer = _layers[_m];
    if (layer && layer.source) {

      const _lots = propItemsVal.value.filter((_f) => _f.type === _m);
      console.log("_lots", _lots);

      if (_lots.length > 0) {
        const _features = prepareMarkers(_lots[0]);
        console.log("_features", _features);

        layer.source.clear(true);
        layer.source.addFeatures(_features);

        layer.source.changed()
      } else {
        console.warn(`No items found for type: ${_m}`);
      }
    } else {
      console.warn(`Layer or layer source not found for type: ${_m}`);
    }
  });
}

},{ deep: true });`
That is to say, when init page is called, layer.source is updated normally, but when the layer data changes, it cannot be updated normally. Please help me, thank you very much
Expected behavior
Normal rendering after layer data is updated

As a rule of thumb, never make anything from OpenLayers reactive in Vue. As for this issue, it will be hard to answer your question without knowing what markerLayers is, except for "don't do it!".

thank you for reply,  markerLayers is a collection of ol-source-vector references related to the layer type
  <div v-if="propItemsVal.length > 0">
    <template v-for="(_k, _i) in propItemsVal" :key="_i">
      <ol-animated-clusterlayer
        :animationDuration="500"
        :distance="mapRef.value?.map.getView().getZoom() >= 13 ? 0 : 40"
        :styles="LotsLayerData.vectorStyle.pending"
        :title="_k.type"
        :zIndex="40"
        :visible="true"
      >
        <ol-source-vector
          :ref="
            (el) => {
              if (el) {
                nextTick(() => {
                  markerLayers[_k.type] = el;
                });
              }
            }
          "
          :projection="mapState.name"
        />
        <ol-style :overrideStyleFunction="overrideStyleFunction"></ol-style>
      </ol-animated-clusterlayer>
    </template>
  </div>

and  i find if change     markerLayers[_k.type] = el; to   markerLayers[_k.type] = { ...el };, after shallow copying and assigning, the layer data can be updated normally, but this will cause infinite rendering due to watch(markerLayers)...

根据经验，永远不要在 Vue 中将 OpenLayers 中的任何内容变为响应式。至于这个问题，如果你不知道是什么markerLayers，就很难回答你的问题，只能说“别这么做！”。

ok I will tried to change the layer collection to a non-responsive way to update

As a rule of thumb, never make anything from OpenLayers reactive in Vue. As for this issue, it will be hard to answer your question without knowing what markerLayers is, except for "don't do it!".

ok I will tried to change the layer collection to a non-responsive way to update

As a rule of thumb, never make anything from OpenLayers reactive in Vue. As for this issue, it will be hard to answer your question without knowing what markerLayers is, except for "don't do it!".

ok I will tried to change the layer collection to a non-responsive way to update

Its work!!   i use no-reactive makerlayers, and then update it by manually,the layer data  was update and switch normally.
thanks!


Incosistent order of Action flyout menu under different locales

Describe the bug
In Italian, the action flyout menu's order messed up:

This issue is related to the lack of information in uischema - menu part. We need a field to represent the order of a $kind in the flyout menu.

Version

Browser

[ ] Electron distribution
[ ] Chrome
[ ] Safari
[ ] Firefox
[ ] Edge

OS

[ ] macOS
[ ] Windows
[ ] Ubuntu

To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior

Screenshots

Additional context

Similar to Trigger uischema, I'm going to add a new field order in the definition of Action menu uischema.
Link to Trigger uischema as an example: https://github.com/microsoft/BotFramework-Composer/pull/4079/files#diff-4ba737dc33a64481d1347019910a69a7c2626a6368da6ffa0f5f0490dfc0f0c9
cc @a-b-r-o-w-n

Similar to Trigger uischema, I'm going to add a new field order in the definition of Action menu uischema.
Link to Trigger uischema as an example: https://github.com/microsoft/BotFramework-Composer/pull/4079/files#diff-4ba737dc33a64481d1347019910a69a7c2626a6368da6ffa0f5f0490dfc0f0c9
cc @a-b-r-o-w-n


improving the README.md file with a more appealing look and bit more info

The README file is oftentimes the first entry point for new users, we should be a bit nicer and give people a bit more info and definitely more pointers to resources

@valeriupredoi looks great +1 . I just added two minor comments. It would be great if we can also add a sentence about the tutorial in the section "Getting started". Thank you.

Cheers @SarahAlidoost - would you be able to do that please (here)? It's your baby and I want it done good justice, instead of me adding some terse line :)

@valeriupredoi looks great +1 . I just added two minor comments. It would be great if we can also add a sentence about the tutorial in the section "Getting started". Thank you.

Cheers @SarahAlidoost - would you be able to do that please (here)? It's your baby and I want it done good justice, instead of me adding some terse line :)

Sure, I couldn't add it to this PR, because that line wasn't changed. Here my suggestion for revising the line in that section:
Please see [getting started](https://docs.esmvaltool.org/en/latest/quickstart/index.html) on readthedocs as well as [ESMValTool tutorial](https://esmvalgroup.github.io/ESMValTool_Tutorial/index.html). The tutorial is a set of lessons that together teach skills needed to work with ESMValTool in climate-related domains.

cheers @SarahAlidoost - added!

cheers for the review @SarahAlidoost :+1:


[now-cli] Render prompt when deploying home directory

This PR fix: #3020

Codecov Report

Merging #3057 into canary will increase coverage by 0.24%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           canary   #3057      +/-   ##
=========================================
+ Coverage   11.36%   11.6%   +0.24%
=========================================
  Files         267     267
  Lines       10039   10072      +33
  Branches     1309    1299      -10
=========================================
+ Hits         1141    1169      +28
- Misses       8805    8812       +7
+ Partials       93      91       -2

Impacted Files
Coverage Δ

src/commands/deploy/latest.js
0% <0%> (ø)
:arrow_up:

src/util/dev/builder-cache.ts
80.74% <0%> (+3.47%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e631de4...2fceb22. Read the comment docs.

I think we should add the same check to legacy

Ahh, you're right 👍


"Sync All" functionality

Add a "sync all" button in the synchronization view that updates all items on the remote server which have been updated since last sync.


Enum generated FromStr improvements

After using this, I realized a couple issues

Writing from_str(s)? reminded me () as the error type for FromStr is terrible since it doesn't impl Error or Display.
Enums which fallback to Unknown can have an infallible FromStr.
Fallback behavior for from_str and deserialization did not match.

There's another question which doesn't need to be answered here around usage of Unknown as a fallback so that added enum variants are not a breaking change for parsing.
The openapi code currently uses the completely unscientific value of 12 variants for determining when Unknown should be inserted - there's probably an argument for using Unknown on smaller enums than that (or always, but that might start to hurt ergonomics for pretty stable enums).

I will open a ticket on the project and lets move on.


[BUG]安装runtimeproxy失败

What happened:
kubelet启动失败：
CRI v1 runtime API is not implemented for endpoint \"unix:///var/run/koord-runtimeproxy/runtimeproxy.sock
What you expected to happen:
How to reproduce it (as minimally and precisely as possible):
Anything else we need to know?:
Environment:

App version: 1.3.0
Kubernetes version (use kubectl version): v1.26.2
Node environment (for koordlet/runtime-proxy issue):

Containerd: v1.6.19
OS version: centos7.9
Kernal version: 5.12.0
Cgroup driver: systemd

Others:

/area runtime-proxy
/area koordlet
Sorry. The current version of runtimeproxy does not support CRI v1 API (>= k8s 1.26.0). It will be fixed in the following versions.
Duplicate with https://github.com/koordinator-sh/koordinator/issues/1051.

It will be fixed by #1593.


Add posibility to use an atom-build config file from the user's home

As discussed on https://github.com/noseglid/atom-build/issues/209
Adding the possibility to use global config files, as a first step, to use the user's home directory looking for any of the supported config file types.
as a bug: the plugin can't watch the whole directory structure, if an atom build file is added to the home directory after the project is loaded, atom build won't recognize the new file, the project needs to be reloaded.
This commit may looks big but tests required lots of modification to support the new "isElegible" method fallback to use user home directory.

Checking the issues and pushing a fix...

Fixed linter issues: https://github.com/academo/atom-build/pull/1

OK, last commit finally fixing the eslint issues, I think I had to change the lint plugin from the beginning, I am using jshint.

Any progress on this?

@noseglid crazy of a week + holidays = no time yet, I have it in my TODO list.

Excellent. There's no rush. Just wanted to keep myself updated :)

No cigar on this one?
I think this can be quite useful to have. If you don't intend to continue, let me know and I'll try to pick it up, or someone else may

@noseglid I am giving a try right now, It looks like now is full of conflicts

@noseglid fixed conflicts and updated tests again:
Note in the custom provider I splitted the tests in 3 parts: Check targets in home directory, check targets in project directory and parse/check parsed targets.
As it modified too many files is easy to get a conflict with other chaanges.

Really nice. Thank you for this!


HDDS-11401. Code cleanup in DatanodeStateMachine

What changes were proposed in this pull request?
Some unused code was introduced in DatanodeStateMachine. The purpose of this PR is to clean it up.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-11401
How was this patch tested?
https://github.com/jianghuazhu/ozone/actions/runs/10655796465

@fapifta @Galsza , can you help review this PR?
Thanks.

+1
Thanks for the patch @jianghuazhu, LGTM!
Sorry that was an oversight on my part in an earlier pull request.


Update requirements

Update requirements for conda package creation.

Merging now, tests now are passing, it took a long time because download at some point gets disrupted...