XpandNavigationItem throws odd error on incorrect view name

𝗗𝗲𝘀𝗰𝗿𝗶𝗯𝗲 𝘁𝗵𝗲 𝗯𝘂𝗴
Setting an Incorrect view name in XPandNavigationItem throws the following exception
`Operation could destabilize the runtime.
at CreateWindow_Patch1(XafApplication context, TemplateContext controllers, ICollection1 createAllControllers, Boolean isMain, Boolean view, View )    at DevExpress.ExpressApp.Win.WinShowViewStrategyBase.CreateWindow(ShowViewParameters parameters, ShowViewSource showViewSource, Boolean isMain)    at DevExpress.ExpressApp.Win.WinShowViewStrategyBase.ShowStartupWindowCore()    at DevExpress.ExpressApp.Win.MdiShowViewStrategy.ShowStartupWindowCore()    at DevExpress.ExpressApp.Win.WinApplication.ShowStartupWindow()    at DevExpress.ExpressApp.Win.WinApplication.DoStartupLogic(IOverlaySplashScreenHandle overlayFormHandle)    at DevExpress.ExpressApp.Win.WinApplication.Start()
𝗧𝗼 𝗥𝗲𝗽𝗿𝗼𝗱𝘂𝗰𝗲
Create a basic object, for example Reminder and then add the XpandNavigationItem attribute to the class and set the name of the view to Reminders_ListView which is obviously not the name of the view as it is not plural.
𝗘𝘅𝗽𝗲𝗰𝘁𝗲𝗱 𝗯𝗲𝗵𝗮𝘃𝗶𝗼𝗿
Throw a clearly defined error so that the programmer is not confused and spends hours trying to find the error in the code. This error is pretty generic on google as well so it doesn't help.

check out this
https://github.com/eXpandFramework/eXpand/issues/513#issuecomment-523386924
which implies that the problem might be somewhere else. A repro sample therefore is mandatory for further research.

Closing issue for age. Feel free to reopen it at any time.
.Thank you for your contribution.


Allow adding files to the watcher

I'd like to tell sst dev to reload all of the linkables it has? (like json files I'm loading)
e.g.
const constantsLinkable = new sst.Linkable("Constants", {
            properties: JSON.parse(await await fs.readFile(...

Yup on the roadmap.
There's also a PR we haven't gotten to yet.
https://github.com/sst/sst/pull/5074


Cannot run dbt models using UI buttons

Expected behavior
Click on the run model icon and dbt should run
Models are running correctly when using terminal.
Actual behavior
Model is not running & an "activating extensions" message is appearing in the bottom bar.
Possibly due to VSCode November update ?
Steps To Reproduce
Simply try to run a model using the UI (run model).
Log output/Screenshots

Operating System
MacOS Monterey 12.6
dbt version
1.2.1
dbt Adapter
bigquery 1.2.0
dbt Power User version
0.10.1
Are you willing to submit PR?

[ ] Yes I am willing to submit a PR!

It was an issue with GitLens 13.2.0 - I reverted to GitLens v13.1.1 and the issue disappeared.


Missing gulp-debug dependency

I'm working with sass too and i love what yo did with this improve

Thanks to you

Are you still working on this? i found a issue when you put a bad url in a import it stops compiling and theres no warning or something maybe i can help.

Hum I didn't touch any import, and for me everything compile. Create an issue if needed.
But take in account that this repo is temporary and will (probably soon) be merge with the original one.

Ok but i'm having an issue with the serve.prod the scss is not there :(

if you build.prod, the scss becomes css and is minimified. Take a look at client/. I put a full demo on how to use scss


String chunk ids

What kind of change does this PR introduce?
This tries to fix this issue: https://github.com/webpack/webpack/issues/3361
Did you add tests for your changes?
Unfortunately i am not sure which test should cover it. There is "named-chunks" test case which I think suited for that.
Summary
I wanted to use chunk as hash and make them fixed.

Looks good, could you sign the CLA

@sokra could you please show me any direction where I have to put my test?

Hello!
Is there any chance that it will be merged into 2.2, please?

wouldn't it make sense to have the id 'json.stringified' by convention once you want to set it, instead of ensuring json.stringify all over the code?
one could add a helper function to chunks setId or something similar that makes sure this happens?
Would minimize clutter through out the source

same might make sense with module.id?
might cause issues with existing code though.
if that makes sense, i would have a PR ready to open against this one ;)

wouldn't it make sense to have the id 'json.stringified' by convention once you want to set it, instead of ensuring json.stringify all over the code?

I don't think this makes sense. To stringify the id is the job of the code generation.

is the job of the code generation

couldn't the chunk/module at least offer a method to get the id value "ready to be used as code"?
chunk.getIdAsCode?
Then the code generation can decide when to get the id as code, but the chunk/module can decide how it wants to be represented.
Having to JSON.stringify all over the place just feels error prone and unspecific as to why this is actually done.
either way, im happy as long as this gets merged. :)

fixed by #4553


Enhance TokenRequestor to be able to sync tokens to a Secret in the target cluster

How to categorize this PR?

/area security
/kind enhancement
What this PR does / why we need it:
The TokenRequestor controller (part of gardener-resource-manager) can now optionally sync the tokens into a Secret in the target cluster (instead of in the source cluster). This can be controlled via the new token-requestor.resources.gardener.cloud/target-secret-name{space} annotations on the Secret in the source cluster.
Which issue(s) this PR fixes:
Part of #4661
Part of #4878
Special notes for your reviewer:
This is a prerequisite for adapting the cloud-config-downloader and promtail components as part of #4661.
Release note:

The `TokenRequestor` controller (part of `gardener-resource-manager`) can now optionally sync the tokens into a `Secret` in the target cluster (see [this document](https://github.com/gardener/gardener/blob/master/docs/concepts/resource-manager.md#tokenrequestor) for more information).

/invite @BeckerMax

/assign


Atomic writes

I think I'm gonna table this one for now, maybe until we get multiline .env support in GH CLI. .env should not be modified in cndi overwrite, and doing that is making the transaction model more trouble than it is worth at the moment


benchmark helmcharts (#995)

Description
The summary of the proposed changes as long as the relevant motivation and context.
Issues
List the issue or RFC link this PR is working on. If there is no such link, please mark it as n/a.
Type of change
List the type of change like below. Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds new functionality)
[ ] Breaking change (fix or feature that would break existing design and interface)
[ ] Others (enhancement, documentation, validation, etc.)

Dependencies
List the newly introduced 3rd party dependency if exists.
Tests
AudioQnA

VisualQnA

Please hold on such changes that going to add helm charts to GenExamples apps, for we are still on the way to nail down bunch of rules of how to prepare helm charts for apps and comps.

Please hold on such changes that going to add helm charts to GenExamples apps, for we are still on the way to nail down bunch of rules of how to prepare helm charts for apps and comps.

@ftian1 will be presenting the status and the proposal. Yes, let's move forward after things are synced.


Documentation/Readme update

Update the Readme file to make it easy for the other developers to walk-in-easily.

@Chirag018 Can you provide a list of sections you'd like to see updated?

@Chirag018 I feel like the quickstart segment of the readme outlines what steps are necessary. https://github.com/scaffold-eth/OP-RetroPGF3-Discovery-Voting#quickstart
Since you set it up more recently maybe you would have some good ideas about how to clarify the steps. Feel free to DM me with any thoughts and we can figure out how to make it super clear for the next dev.

I just started to contribute last night. Seemed like the only missing bit for me was asking for the DB credentials. But it was covered in the telegram chat.

Hey, @gotnoshoeson you can work on other open issues at the moment, as I kept this task for the end when we were about to showcase it.

okay


MSVC: specify Vc_VDECL explicitly on a few functions

👋
This MR fixes #289 by making __vectorcall visible in the headers. I don't know why MSVC does choose that calling convention by default, though; in Krita, the author of our MSVC support (@ramin-raeisi) went with Vc_CDECL, which works equally OK.

Hi! Thank you again for this contribution! We have just added a few GitHub Actions in #278 so we can have better feedback for PRs. Could you please rebase on the latest 1.4 branch? Thank you!


Missing patternfly-charts.css

I see patternfly-charts.scss included in the latest package v2.8.2, but patternfly-charts.css is empty.
I also don't see the charts included in either patternfly.scss, patternfly-base.scss, etc.
In order for the react chart components to consume these variables, they must be available via react-tokens, which pulls vars from patternfly.css.

We added the file as patternfly-charts.scss because patternfly-*.scss is compiled to CSS, and we wanted to offer both formats. But we were going to wait until we have the SCSS vars in place before adding the CSS vars to that file, which will eventually populate patternfly-charts.css with CSS.

In order for the react chart components to consume these variables, they must be available via react-tokens, which pulls vars from patternfly.css.

What do you think about this @dgutride? It seems like this implies the charting vars need to be included in the core compiled CSS in order to be consumed by react. Should we ship the chart CSS in patternfly.css? I don't think it's going to end up being a lot of CSS (so far at least), so size isn't really a concern. Or should we approach how these vars are imported in react differently to allow them to be a separate stylesheet in core so that we don't include them by default and users can include the stylesheet if they're using charts?

It may be possible to populate react-tokens from multiple CSS files. However, we need the CSS in order to begin converting the charts to use the color pallets. Can we at least get the colors added now?

@dlabrecq @mcoker - I think we should keep them separate and update react-tokens to look at the separate stylesheet. Is there enough in the current patternfly package to do that or do we need to wait for the colors to be added?

However, we need the CSS in order to begin converting the charts to use the color pallets. Can we at least get the colors added now?

Gotcha, yes we'll add those today.

@mcoker @christiemolloy Are the CSS colors available?

Also, do the vars need to be formatted more like this?
:root {
  $pf-chart-color-blue-100: #8bc1f7;
}

Just doing some testing with react-tokens and it seems a block is required around the CSS vars. For example:
:root {
  --pf-chart-color-blue-100: #8bc1f7;
}

@rachael-phillips Yes, I am aware that #1846 has been merged. However, the generated CSS file is empty, which is why this issue exists.

@dlabrecq the PR is here: https://github.com/patternfly/patternfly-next/pull/1868 I'm just confirming with Dana and Rachael that we can merge it

I see you added :root as well. Thank you!

@dlabrecq , @dgutride said we should wait until we release in order to merge it, hopefully that will be today.

:tada: This issue has been resolved in version 2.12.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Split out four new crates

This PR splits out four new crates:

typst-library: Most of the code from typst moved here. The crate holds Typst's standard library and all central definitions for the compiler (as these are interwoven with the standard library types). All of its definitions are reexported by the typst crate, which has become just a thin wrapper.

typst-eval: Moved from typst/src/eval.

typst-realize: Moved from typst/src/realize.rs.

typst-layout: Contains code from typst/src/layout and typst/src/math.

The three new eval/realize/layout crates contain primarily behaviour, not types. This behaviour is made available to code in typst-library through a new Routines struct containing a table of function pointer. This struct is populated in the now very small typst crate which depends on all of the four crates and just puts the pieces together.
This set-up of having a central crate with types and surrounding crates with behaviour that are assembled together by one small umbrella crate is very scalable because it makes all the behaviour crates independent from each other, such that they can be compiled in parallel. A very similar design is employed by rustc.
Here's a small diagram, which should make things clear:
                 macros ────-┐        ┌─ kit ───────────────────┐
                             │        ├─ eval ────┐         ┌- cli
utils ─ syntax ─ timing ─ library ────┼─ layout ──┼─ typst ─┤
                                      ├─ realize ─│         └- ide
                                      ├─ render ──│
                                      ├─ svg ─────│
                                      └─ pdf ─────┘

The main motivation of this change is developer experience: Compile times for the typst crate have gotten pretty bad and rust-analyzer has become rather sluggish. With the new setup, the typst-library crate is still quite big[^1], but at least a bit smaller. It also won't grow as much as the mono-typst-crate would due to upcoming features like HTML export (which will get its own typst-html crate). Editing typst-library is still not a great experience, but I suspect the solution here is to optimize the various proc-macros to generate less code.
Meanwhile, editing in the new crates is a much nicer experience, with rust-analyzer being quite snappy. Moreover, editing these crates does not trigger recompilation of the exporter crates. (Previously, the test cycle for any change to the layout engine triggered a recompilation of typst-pdf, typst-svg, and typst-render.)
[^1]: Splitting typst-library further is hard due to the various interactions between all its types. While there are various definitions in it (e.g. data loading functions) that are leafs and not needed by anything else, the boundaries of potentially split-out crates end up being rather arbitrary, so that didn't seem like a durable solution. (I don't want to change the crate structure every week.) The nice thing about just splitting behaviour rather than types is that we can easily resolve cyclid dependencies via the function pointer table. This is not possible types. For what it's worth, many large Rust projects end up with one large core crate surrounded by other crates, so I think we're in good company.

Incredible. Love this


Feature: Allow configuration of a rule evaluation delay

Now that Prometheus is allowed to be a remote write target, we think this is highly useful.
This basically enables Prometheus to do two things:

Allow setting a server-wide rule evaluation delay.
Allow the overriding of such a setting at a rule group level.

The main motivation of this work is to allow remote write receivers (in this particular case Prometheus itself) to delay alert rule evaluation by a certain period to take into account any sort of remote write delays.
In the early days of Mimir, our customers observed plenty of gaps in recording rules and flapping alerts due to remote write delays. Network anomalies are a factor of when and not if and this change help mitigate most of that flapping. In Mimir, we run it with a default of 1 minute but for Prometheus I'm proposing a default of 0 to avoid any sort of breaking change and leave it mostly as a tool for operators to decide how do they want to balance out time of evaluation for recording rules and alerts vs tolerance for remote write delays.
For context, this has been running in Mimir for years.
** Note for Reviewers **
I've tried adhere as much as possible to the original author's code where it made sense -- however, there was a huge refactor on the rules package since this code was introduce so a lot of merge I had to manually port it to the right place so please take a look carefully.

Should we update the documentation here and here, to mention the new field in the rules config file?

I have updated the docs in here as this is where the have the reference to the file format.

@juliusv @roidelapluie @bwplotka @beorn7 @ArthurSens any thoughts?

rule evaluation delay to me sounds like the rule query won't be executed immediately but rather after a while. But this change, I think, is to use a constant offset when querying metrics during rule evaluation. How about rule evaluation offset ?

The closest analogy would be the offset modifier we have for selectors and subqueries in PromQL. Maybe the feature should be called "rule query offset" or something like that?

I don't have a strong opinion on name and I'm happy to go whichever direction you think it's right - Just want to say that a rename would be a big source of pain for us as we'll have to deprecate flags and change the config file format but that's not a Prometheus problem.
Just want to make sure the whatever name we end up picking you feel strongly about it - and it's not one of those "it would be nice if".

I am on Julius' side, while Reading the PR I was thinking it was slipping evals for a certain time, not evaluating in the past.

I don't have a strong opinion on name and I'm happy to go whichever direction you think it's right - Just want to say that a rename would be a big source of pain for us as we'll have to deprecate flags and change the config file format but that's not a Prometheus problem.

Yeah, I understand an am sorry for the pain, but I also believe it's worth to make a user-facing option as clear as possible. Even users who don't need it will have to read it in the docs and try to understand what it does and whether they need it.
I think even "offset" alone isn't fully clear, as that could just mean an offset in when rule evaluations are triggered, without changing the actual timestamp of queries into the past. So that's why I'd suggest rule_query_offset / ruleQueryOffset. This can just be queryOffset within the rules package and query_offset for the per-group option, as the rules context is clear there.

I can see a world where you might want to control the flag at a server level

Not sure I follow 100% - whether it's a flag or a global config option, both would control the option at a server level. A config option would just be more consistent in terms of how our existing configuration overrides work: I don't think we have a flag that can be overridden by any config option anywhere, but we have global config options that can be overridden in more specific places (e.g. rule evaluation intervals). That's just why it'd feel more natural to me to have the rule query offset global default setting in the config file as well (vs. as a flag). The other implication of putting something into the config vs. flag is that the setting has to be reloadable during runtime, which I hope is doable for the global rule query offset.

perhaps what I should introduce is a guard to make sure the config option cannot be lower than the server flag which I think it's what makes sense in my head.

I could imagine both configuring lower and higher offsets for specific groups, depending on whether most of your data comes from a regular source or from a delayed one (then you'd choose the default offset to be according to that and either configure lower or higher offsets for specific exceptional groups that use data from a different source).

Yeah, I understand an am sorry for the pain, but I also believe it's worth to make a user-facing option as clear as possible. Even users who don't need it will have to read it in the docs and try to understand what it does and whether they need it.

Sounds good to me!

I think even "offset" alone isn't fully clear, as that could just mean an offset in when rule evaluations are triggered, without changing the actual timestamp of queries into the past. So that's why I'd suggest rule_query_offset / ruleQueryOffset. This can just be queryOffset within the rules package and query_offset for the per-group option, as the rules context is clear there.

This makes sense to me, of all the options, I do like rule query offset / query offset the most. I'll make this change.

Not sure I follow 100% - whether it's a flag or a global config option, both would control the option at a server level. A config option would just be more consistent in terms of how our existing configuration overrides work: I don't think we have a flag that can be overridden by any config option anywhere, but we have global config options that can be overridden in more specific places (e.g. rule evaluation intervals). That's just why it'd feel more natural to me to have the rule query offset global default setting in the config file as well (vs. as a flag). The other implication of putting something into the config vs. flag is that the setting has to be reloadable during runtime, which I hope is doable for the global rule query offset.

🤦 Sorry I misunderstood your argument entirely - yeah, I think this change makes perfect sense. The pattern of global config can be overrideable via a more specific configuration option of a component is very common in Prometheus world.

I could imagine both configuring lower and higher offsets for specific groups, depending on whether most of your data comes from a regular source or from a delayed one (then you'd choose the default offset to be according to that and either configure lower or higher offsets for specific exceptional groups that use data from a different source).

Sounds good - I'll ship it without the guard and we can evaluate it as i evolves.

@juliusv @roidelapluie I think I have addressed all your concerns now. Let me know if you have any other thoughts.

@juliusv @roidelapluie @machine424 I have more work I'd like to do around the rules engine so if possible, I'd love to move forward. I'll take your silence as consensus and attempt to merge it tomorrow unless I hear otherwise.

Btw. :+1: besides my last comment/question about the pointer.

I'm going to proceed with the merge. If there's any additional feedback, please let me know so I can follow up immediately.


refactor and add funcs findCommandWithCommandArgs & splitArgs

Signed-off-by: Martin<EMAIL_ADDRESS>

Coverage decreased (-0.2%) to 86.58% when pulling e8f5ac118823a1b24dd0d72de14f4a58c3f9138d on refactor-GetCommand into fa6826275577aa69bc907955f95d11c767535e12 on master.


Some generator fixes

This PR addresses recent issues I encountered with the generator:

It’s unclear if the problem stemmed from an update, but the latest nightly build wasn’t functioning properly. Specifically, it failed to initiate the process, returning no Visual Studio instances from MSBuildLocator.QueryVisualStudioInstances().

When using GenerateComponentsFromAssemblyAttribute, the generator consistently detected zero classes. After a step-by-step debug, I identified this line as the culprit, as it consistently evaluated to false.

Included the ability to create unique namespaces, this was because in my sample app I was having issues with the generator trying to generate two using MC = ... namespaces. One for the Microsoft.Maui.Controls and the other for a third party library called MauiIcons

Additionally, I included some code cleanup and updated the project to leverage new features in C# 13.

How does it fix 1) ?

I'll remive 1 as it seems to be an update of some package and not really a fix. I don't know but packaging the branch 'generator_updates' make the tool work, while before was giving an error

Ah, ok. Pack is simply broken now, fixing it.

At this point I saw you fixed the 2nd problem as well. I'll take this open if you want to merge the cleanup and C# features changes 😄

I'm thinking simply to use full type name (e.g. global::MauiIcons.MauiIcon) for all non-MAUI types. Maybe a bit uglier generated file, but less possible problems.

Yes that could be a solution, if we suppose that after the generation the user should do minimal to no changes to the components it should not be bothered

Ha, I didn't know it automatically close the PR if I delete my branch :)


[FEAT] Add ability to configure valid git commit types

Is your feature request related to a problem? Please describe.
Would it be possible to add an option to provide a config file to set the list of possible valid git commit types? We use a superset of the standard 'Conventional Commits' rules and our extra items throw errors when using tug commit.
Describe the solution you'd like
It would be awesome to be able to read from a config file at a repository level as per Commitlint's approach (example config file). Could commit.go potentially check for a local config file before building up the list of types, and then fall back to the hardcoded list if one isn't available?
I don't know Go at all so apologies if this more difficult than it seems :) Turbogit is awesome btw, thanks! 💯

Hey, thanks for creating the issue. It's not simple in the sense that a lot needs to be refactored in order to be dynamic (mostly this file).
But it's definitely useful. Keeping this in the backlog for a future release.
FYI turbogit is using the same config model (and files) as bare git. The config read is already implemented (and used for example in the new jira integration wip), we just need to make commit type dynamic.

Thanks @b4nst, I'll keep an eye out :)


dockstation.io is down

Hello,
The title says it all https://www.isitdownrightnow.com/dockstation.io.html

Hi @theblackhole Thanks for the issue! DigitalOcean stable down our nodes 1-2 times per month :(
Rebooted.

Thanks! If you want, you can use a monitoring tool like updown.io or uptimerobot.com to receive notifications (email, slack, etc...) when your website is down. It's easy and quick to setup ;)

Yes, I use monitoring, but today I was unavailable and couldn't see messages.
Your issue was first what I checked. :)


To get json file while running spark job on the Databricks notebooks

Is there any reference code snipped on how to get jsonFile , while using Sparklens in the notebook env

I have created a PR
https://github.com/qubole/sparklens/pull/55


Project Proposal

Task to be done:  :octocat:

[x] Create a Project Proposal In PDF format.
[x] Added the Proposal file respect Docs folder.
[x] Use the Format Attached.

Attachment:
1. Project Proposal_Format.docx

Done :octocat:


fix: #35 apply code review

PR Checklist
Please check if your PR fulfills the following requirements:

[ ] Tests for the changes have been added (for bug fixes / features)
[x] Docs have been added / updated (for bug fixes / features)

PR Type
What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[x] Code style update (formatting, local variables)
[x] Refactoring (no functional changes)
[ ] Build related changes
[ ] CI related changes
[x] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: resolve #35
What is the new behavior?

rename some elements

Other information
https://github.com/obsidianmd/obsidian-releases/pull/1678#issuecomment-1445216292

Codecov Report
Base: 45.28% // Head: 43.63% // Decreases project coverage by -1.65% :warning:

Coverage data is based on head (b60c700) compared to base (9ccfb80).
Patch coverage: 6.25% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #36      +/-   ##
==========================================
- Coverage   45.28%   43.63%   -1.65%
==========================================
  Files           3        3
  Lines         106      110       +4
  Branches        7        8       +1
==========================================
  Hits           48       48
- Misses         57       61       +4
  Partials        1        1

Impacted Files
Coverage Δ

src/jekyll/chirpy.ts
21.51% <6.25%> (-1.15%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Release 0.3.0

@yagebu What do you think about releasing 0.2.7 when #257 and #259 are done? Any pressing open issues that have to go into this release?

I think we've got enough new features for a new minor release (0.3.0).
I'll also try to fix #191 before, it's been open for ages and shouldn't be hard to fix.

I'll leave this issue open to discuss the release.

I have a feeling that #257 will be hard to merge, as I created the branch long ago and master changed quite a bit…

@aumayr: I can have a go at it if you want. I've done uglier merges/rebases ;)
Might get some time tomorrow or if not I can definitely do it on the weekend. Will also try to get #259 merged then.

Awesome, thanks!
I'm not very comfortable with large merges/rebases, as I have no real experience with them (outside fava)…

@yagebu I think there is nothing in the way of releasing a new version. Do you agree?

Yes!

Can you have a go at the changelog again? I will then upload to PyPI, push a new version to Github Pages and update the Demo on pythonanywhere.

Can you have a go at the changelog again?

I won't have any time to do it until Wednesday. If you could do it before then, that'd be cool, otherwise I'll do it then.

If you could do it before then, that'd be cool, otherwise I'll do it then.

No problem, I'll have a go at it.

My first try: b3b1402
I'm not quite happy with the language, but maybe this will get better next time :-) Please give a 👍 if you think it's ready to get published.

Could you link to the help page of budget functionality? I can't seem to find it anywhere.

@yegle https://github.com/aumayr/fava/blob/master/fava/docs/budgets.md

My first try: b3b1402

👍
(Since the changelog is only on the website anyway, we can always improve it after we make a release)

Done and out in the wild.

[X] PyPI-release
[X] Github release
[X] fava.pythonanywhere.com updated
[X] aumayr.github.io/fava updated
[X] Post on the Beancount mailing list

Thanks everyone, especially @yagebu, for all the help!
Up to the next one…


Add BulkEditAPI

Codecov Report

Merging #26 into master will increase coverage by 0.38%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #26      +/-   ##
==========================================
+ Coverage    95.7%   96.09%   +0.38%
==========================================
  Files           9       10       +1
  Lines         722      793      +71
==========================================
+ Hits          691      762      +71
  Misses         31       31

Impacted Files
Coverage Δ

drf_tweaks/mixins.py
100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 515745e...8034de3. Read the comment docs.


roles vars vs host vars

@wdesmedt I wanted to check why did you decide to add host variables in each role's vars section. Why don't you put host vars into the inventory, making it a single place where host_vars are defined.
Imagine you grow your fabric from 4 leaves to 6 leaves. With the current approach you would have to add clab-xxx-l5 and clab-xxx-l6 vars to all the roles, instead of just adding the relevant nodes into the inventory.

@hellt The 'intention' was to keep the variables specific to the role with that role. So to configure interfaces, you go to the vars of the interface role, same for network-instance. You could also put this in the host_vars and group_vars of the inventory but it's a matter of opinion which is best. I also wanted to be independent of an external inventory like netbox for intents.

I don't think I ever saw host-specific variables specified in the role's vars; it just doesn't fit in my view. The whole point of the inventory file is to have a single source of truth for the configuration management generation. By moving this to a role, you have many places where inventory is "redefined".
The role vars, afair, are predominantly used to store the defaults the role can use if unset from other sources. E.g. interface speed might be set to 1G if not specified in the host/group/playbook.
You can imagine how frustrating it would be to change all the roles if we, say, rename the lab name from 4l2s to 6l2s.
I'll leave this to you, but maybe it is worth checking with other projects and get some references backing this design decision.

One of the reasons to have a dedicated role to load intent (utils/load_intent) that defines host and group vars - mimicking host_vars and group_vars in the ansible inventory - was the behaviour of Ansible with overlapping vars in host_vars and group_vars, e.g.:
host_vars:
network_instance:
  default:
    protocols:
      bgp:
        neighbor:
          <IP_ADDRESS>:
            peer_group: spines
          <IP_ADDRESS>:
            peer_group: spines

group_vars:
network_instance:
  default:
    interfaces:
      - system0.0
      - ethernet-1/48.0
      - ethernet-1/49.0
    autonomous-system: "{{ asn }}"
    protocols:
      bgp:
        neighbor:
          <IP_ADDRESS>:
            peer_group: overlay
          <IP_ADDRESS>:
            peer_group: overlay
        ipv4:
          admin_state: enable
        group:
          overlay:
            peer_as: 100
            export_policy: pass-evpn
            import_policy: pass-evpn
            ipv4:
              admin_state: disable
            evpn:
              admin_state: enable
            local_as: 100
            local_address: "{{ router_id }}"
          spines:
            description: "Peer-group for spine neighbors"
            export_policy: lo-and-servers
            import_policy: pass-all
            peer_as: 65100
            ipv4:
              admin_state: enable
            epvn:
              admin_state: disable

The default behaviour of Ansible for duplicate var definition is controlled by the setting hash_behaviour=replace in ansible.cfg. Changing this to merge, which is required for our use-case, is not recommended as stated in the elaborate version of ansible.cfg:

*...[we] recommend relying on the combine filter and var lookups.

Also, relying on a setting in ansible.cfg to control fundamental behavior of the playbook (building intent) is risky.
So host_vars and group_vars in the inventory to store intent is not the way to store variables that are deeply nested objects and have both a host-specific and group-specific definition. Probably a single file with all the intents outside the inventory is a middle way forward.

either indeed making the separate inventory file with variables, or using a simpler variables structure with non overlapping fields between host vars and group vars

addressed in PR #18

fixed in dev branch

Fix now in main #34


convert args filter static to shared lib

Coverage remained the same at 79.973% when pulling 1c0f0fd99e42a312d8333804702420740c9f7a1a on aravuri/argslib into 846d26510ad5990d3423cafceefd44cd0035e1e5 on master.


404 at: /compose/compose-file/compose-file/

Hi,
URL: https://docs.docker.com/compose/compose-file/ (Compose file version 3 reference)
issue :
When I click on the "variable substitution" link (= https://docs.docker.com/compose/compose-file/compose-file/#variable-substitution) within Service configuration reference section, the appropriate page is missing.
The link in Docker Compose Version 2 (= https://docs.docker.com/compose/compose-file/compose-file-v2/#variable-substitution) is working, not in version 3.
Thank you.
Mehdi.

Closing this issue now, as link to variable substitution is now fixed in https://docs.docker.com/compose/compose-file/ (it goes here) .
We are having some glitches with the new web design in that the links are going to a little below the headings, but we will work on that as a global issue.
Thanks for the feedback.


Collection does not purge internal _byId reference to a removed model

Please find below about the tersest reproduction I could fathom of a sequence of steps in a Backbone application that leads to a Collection getting into a state of internal confusion.
A working copy can be found in this JSFiddle .
What it demonstrates is a collection keeping an internal (_byId) reference to a remove()-ed Model.  That Model is no longer part of collection.models, however, it can still be retrieved through its (former) id.
var
    MyView = Backbone.View.extend( {

        initialize: function () {

            this.model = new Backbone.Model( {

                id:  'foo'
            ,   foo: 'bar'
            } );

            this.collection = new Backbone.Collection( this.model );

            this.listenTo( this.model, 'change:id', function ( model, id ) {

                if ( id == null ) {
                    this.collection.remove( model );
                }

            } );

            this.model.unset( 'id' );

            $('#models' ).val( JSON.stringify( this.collection.models      ));
            $('#_byId'  ).val( JSON.stringify( this.collection._byId       ));
            $('#get-foo').val( JSON.stringify( this.collection.get( 'foo' )));
        }

    })

, foo = new MyView()
;

Hmm, interesting. When we add model to collection, _byId add two properties: model.id and model.cid, their reference to model. Issue on 1134 line, id === undefined, but _byId contains model.id - 'foo'.
Collection don't has some special logic when change model.id to value == null, check line 1183.
Also you can change unset to set null or undefined. this.model.set('id', null);
P.S.: I think you never need set your model id to null or undefined, it is anti pattern.

Yes — you should never do this, but it's still a bug.
We should fix this by making sure that if an id is changing from a value to null, we delete this._byId[id] first.

If you remove a model from a collection without the use of an event, it works as expected. The problem is in _onModelEvent which checks if the name of the event is change, when the actual event name being sent in this case is change:id.

This is almost certainly a duplicate of #3882, but I'll keep both tickets open for now, because both contain part of the symptoms and part of the explanation.


Makefile.arduino

Hello Neil, great job you are doing with esp32
In the last commit, you change the name of BLE.h and BLE.cpp to BLEDevice.h and BLEDevice.cpp, but in Makefile.arduino you forgot to change those names.
Thank you and best regards.

Thank you kind sir.  Change made and pushed.    The lesson here (for me) is don't be hubristic and assume that all is well.  I tested with ESP-IDF and treated Arduino like a second class citizen.  I'm going to try very hard to make sure I test with Arduino as well.


Pre-trained models?

Hi @GhiXu, thank you for the work.
Will pre-trained models be provided to re-produce the reported numbers?

Maybe you will find  Geo-Neus reconstruct scan37 model, it gets around 0.71 rather than 0.537.  Using the official environment of Geo-Neus, I can't get low score .

I was confused when i got around 0.968 in scan37.

I was confused when i got around 0.968 in scan37.

Do you solve it？is it still 0.968 in scan37？

Maybe you'll find that Geo-Neus rebuilt the scan37 model, and it's about 0.71 instead of 0.537. Using the official environment of Geo-Neus, I can't get a low score.

Hello, I tried to evaluate the trained DTU model and ran eval. py, but received an error (ValueError: Found array with 0 sample (s) (shape=(0,3)) while a minimum of 1 is required by NearestNeighbors.).
May I ask how you obtained this result with scan24=0.446 and what code was used?

i got around 0.823 in scan37.


TypeNameHelper: Port improvements from Common Repo

There are some improvements being made to TypeNameHelper to improve perf here https://github.com/aspnet/Common/pull/278
We should port changes to our repo.

Just bring over perf work.


Lab #6-left join

This is the aggregate salaries by team and year
total.sal <- Salaries %>% group_by(teamID, yearID) %>% summarise(player=n(), total.cost=sum(salary.adj, na.rm = TRUE))

When I use this object to join the data sets, it doesn't include any values for total cost which I think I need to proceed.  In addition total.sal doesn't have a W column.
mutate(total.sal, cost.per.win= total.sal/W/100000)

Do I need to do an additional left join with total.sal and maybe team.sal so that there is a W column?

Additionally, the columns in total.sal are ordered teamID, then yearID.  However, in team.sal, they are ordered yearID, igID, teamID.  Do I need to arrange them to match before I proceed?

Additionally, the columns in total.sal are ordered teamID, then yearID. However, in team.sal, they are ordered yearID, igID, teamID. Do I need to arrange them to match before I proceed?

@danafuller, that is correct. You need to do group_by( yearID, teamID ).

This is the aggregate salaries by team and year
total.sal <- Salaries %>% group_by(teamID, yearID) %>% summarise(player=n(), total.cost=sum(salary.adj, na.rm = TRUE))

When I use this object to join the data sets, it doesn't include any values for total cost which I think I need to proceed. In addition total.sal doesn't have a W column.
mutate(total.sal, cost.per.win= total.sal/W/100000)

Do I need to do an additional left join with total.sal and maybe team.sal so that there is a W column?

@danafuller, your are correct in that you need to merge the salaries data with the Teams data to get the W variable.

Thank you for the clarification.  I was also wondering why there aren't any values for total.cost? Did I do something wrong?
 total.sal <- Salaries %>% group_by(teamID, yearID) %>% summarise(player=n(), total.cost=sum(salary.adj, na.rm = TRUE))

I figured it out!

👏🏼👏🏼👏🏼

mutate(total.sal, cost.per.win= total.sal/W/100000)

Thank you for the clarification. I was also wondering why there aren't any values for total.cost? Did I do something wrong?
 total.sal <- Salaries %>% group_by(teamID, yearID) %>% summarise(player=n(), total.cost=sum(salary.adj, na.rm = TRUE))

why isnt there any value s for total.cost ?

I don't see anything problematic when I run it.
Try restarting with a fresh workspace and running the code.

library( Lahman )
data( People )
data( Batting )
data( Salaries )
data( Teams )
library( dplyr )

Salaries <-
  Salaries %>%
  mutate( salary.adj = salary*(1.03)^( max(yearID) - yearID ) )

total.sal <-
  Salaries %>%
  group_by(teamID, yearID) %>%
  summarise(player=n(),
            total.cost=sum(salary.adj, na.rm = TRUE)
            )

when i merge Salary and Teams in step 2...not sure if thats correct -
team_sals <- left_join(Teams,total_sal, by = c("yearID","teamID"))
shouldnt the resulting data frame include the adjusted team budget vector ? The column appears but without any values
then on step 3- guess after piping the merged Salary & Team data and then trying to mutate
mutate(cost.per.win= total.cost/W/100000)
I see W column on step2 dataframe- but when i run it R gives the Object W not found- do i have to create another dataframe, no clue here

library( Lahman )
data( People )
data( Batting )
data( Salaries )
data( Teams )
library( dplyr )

Salaries <-
  Salaries %>%
  mutate( salary.adj = salary*(1.03)^( max(yearID) - yearID ) )

total_sal <-
  Salaries %>%
  group_by( yearID, teamID ) %>%
  summarise(player=n(),
            total.cost=sum(salary.adj, na.rm = TRUE)
            )

 team_sals <- left_join(Teams,total_sal, by = c("yearID","teamID"))

The vector was returning NA values because the order of the by statement was reversed with the sorting of the object.
When you correct this, the column W is now populated.

I think you may need to place total.cost right after the summarise function
for it to work properly.
On Sat, Oct 1, 2022 at 10:21 PM Mash-ea @.***> wrote:

mutate(total.sal, cost.per.win= total.sal/W/100000)
Thank you for the clarification. I was also wondering why there aren't any
values for total.cost? Did I do something wrong?
total.sal <- Salaries %>% group_by(teamID, yearID) %>% summarise(player=n(), total.cost=sum(salary.adj, na.rm = TRUE))
why isnt there any value s for total.cost ?
—
Reply to this email directly, view it on GitHub
https://urldefense.com/v3/__https://github.com/Watts-College/cpp-526-fall-2022/issues/31*issuecomment-1264555151__;Iw!!IKRxdwAv5BmarQ!YuSOb2f9IzP5XyW29eLcD1kcFl4ly0YGuszlPp_1ebsKwFo_tmgEfhhwqjbM7QiRBbT4tpDCI8H66B3loMQXyQgDFA$,
or unsubscribe
https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/AVKGRUTY4L42YSN6OISHJMDWBELVDANCNFSM6AAAAAAQVMQLQU__;!!IKRxdwAv5BmarQ!YuSOb2f9IzP5XyW29eLcD1kcFl4ly0YGuszlPp_1ebsKwFo_tmgEfhhwqjbM7QiRBbT4tpDCI8H66B3loMQMxsWekQ$
.
You are receiving this because you were mentioned.Message ID:
@.***>


apispec dependency

Can you please issue a new release with the updated dependencies from #17 ?

v1.0.3 released :tada:


ASC vocabulary: Experiment techniques

Include Data source -> 'Experiment' -> 'Experiment type' + 'Experiment technique'.
@brissebrat Can you include the list of experiment techniques from the LADP database?
These should be included in the vocabulary as a sub-category to 'Experiment technique'.

Aerosol mass spectrometry
Absorption spectroscopy
Chemical ionization mass spectrometry
Cavity ring-down spectroscopy
Extractive electrospray ionization time-of-flight - mass spectrometry
Electron paramagnetic resonance
Fourier transform infrared spectroscopy
Gas chromatography
Gas chromatography - mass spectrometry
High-performance liquid chromatography
Infrared spectroscopy
Liquid chromatography - mass spectrometry
Laser induced fluorescence
Mass spectrometry
Pulsed laser photolysis
Proton transfer reaction - mass spectrometry
Relative rate method
Tunable diode laser spectroscopy
UV-visible spectroscopy

Members of the "experiment type" category obviously refer to instrument types used in the experiment, not so much to procedures used to conduct the experiment, e.g. "reaction rate study". We will therefore ensure that instrument types listed above are included in the ACTRIS vocabulary, and have an additional link listing the ones above as "experiment technique".

Questions:

Is infrared spectroscopy the same as Fourier transform infrared spectroscopy?
It appears that the list includes items at the same hierarchy level that should appear at different hierarchy levels. For example, aerosol mass spectrometer is included in mass spectrometer .
is _pulsed laser photolysis- normally combined with laser induced fluorescence?
What is the relative rate method?

All other items have been included as experiment technique.

May I suggest that you look at the existing concepts from CHMO -  Chemical Methods Ontology  such as

CHMO_0000228 - spectroscopy

CHMO_0000470 -  mass spectrometry
And their children concepts.

Even if these concepts are not used in ASC voc, it could be useful to associate them to these concepts in ASC with skos:closeMatch


feat(onboarding): Add a skipVerification flag that can skip phone verification during onboarding

Description
This PR adds a feature flag, skipVerification, that can be used to toggle whether or not Phone Verification should be a part of the onboarding flow. Removing phone verification from the onboarding flow will be part of an upcoming experiment.
Experiment Proposal

Zenhub Ticket

https://user-images.githubusercontent.com/8432644/157553203-ecab871b-badf-4134-92b7-06f7610635c8.mp4
Tested
Tested locally on an iOS emulator
How others should test
Turn skipVerification feature flag to true. Then go through the onboarding flow (both create account, and restore account steps) and note that phone verification is skipped and the Step X of X header displays the correct numbers.

Hey @MuckT please help us to test the above PR as it has some feature to be enabled from backend


Watch-DbaUpdate and Unregister-DbaWatchUpdate

Per @SQLvariant's request. Totally fun!

and first install...

Merci 🎳


Rustup

@bors r+

:pushpin: Commit 60b03883cae8f828943f6b1075bd96422b7ce6d3 has been approved by RalfJung
It is now in the queue for this repository.

:hourglass: Testing commit 60b03883cae8f828943f6b1075bd96422b7ce6d3 with merge e9c797b67838cd8d26b28181407fbf369fa34eec...

:sunny: Test successful - checks-actions
Approved by: RalfJung
Pushing e9c797b67838cd8d26b28181407fbf369fa34eec to master...


How do justify tab pane in sveltestrap

So I have tabs with three element

<TabContent>
  <TabPane tabId="alpha" tab="Alpha" active>

Alpha

  </TabPane>
  <TabPane tabId="bravo" tab="Bravo">

Bravo

  </TabPane>
  <TabPane tabId="charlie" tab="Charlie">

Charlie

  </TabPane>
</TabContent>

The problem is it defaults the tab alignment to left, how do I set it to justify, I tried adding nav-justified class in TabPane but it doesn't work
<TabPane class="nav-justified" tabId="alpha" tab="Proses" active>
Last resort would be to have native html tag with bootstrap class to do it, but I was wondering if it was possible with sveltestrap

Setting a class prop on a TabPane just seems to disappear. If you set a class name on TabContent you can do it but you'll also need to create your own css for it:
<TabContent class="justify-tab-content-end">
...

:global(.justify-tab-content-end > .nav-tabs) {
    justify-content: flex-end;
}


Addition of BIC Facility Codes

Adding PR for issue #184

Added BIC Facility codes from BIC GitHub (https://github.com/bic-org/Facility-Code/blob/master/sample-bic-facility-codes.csv)
used Pandas to merge SMG and BIC and align the names to The DCSA Facility Code Entity as defined in IM as write to CSV
the BOM character is handled by Pandas so removed this check
Tested Generation of facilities.csv using scripts including checking that if invalid UNLOCODE the row is omitted.
Added BIC Facility Code to the DB in SQL model which should populate Postgres (NOTE: Unable to fully test as issues with setting up POSTGRES will review once resolved, please feel free to check

Remaining item for the issue would be to add an equipment event to use the BIC Facility Codes to cover an empty equipment despatch or return as an example of where to use in TNT

Hi @cmsdroff - thanks for this PR. Actually it is on purpose that the BIC code is only 4 characters long. In the facility entity we also have the un_location_code which should be used in combination with the facility_bic_code. The reason for splitting the un_location_code and facility_bic_code is in order to reuse the un_location_code together with the facility_smdg_code which also requires a un_location_code. Splitting it up also makes it more search friendly

Hi @HenrikHL well understood and I thought this may have been the case, I will feed back to BIC this point, but it should always be presented as a combined code, reading the IM pdf (attached) this isn't the case, or isn't clear to me at least.  It is like separating the Country from the UN LOCODE so just showing HAM rather than DEHAM where HAM may exist in several countries, it's the same for BIC Codes.

@cmsdroff please remove the .DS_Store files

Hi @HenrikHL well understood and I thought this may have been the case, I will feed back to BIC this point, but it should always be presented as a combined code, reading the IM pdf (attached) this isn't the case, or isn't clear to me at least. It is like separating the Country from the UN LOCODE so just showing HAM rather than DEHAM where HAM may exist in several countries, it's the same for BIC Codes.

Thanks for the heads up. I have amended the IM to make this more clear :-)

@cmsdroff please remove the .DS_Store files

resolved and apologies, I also reverted the length from 9 to 4, but guess this will now fail the build as the BFC in facilities are 9 chars, should they be 4 in the facilities file examples ?
If so I'll re-commit with amends

resolved and apologies, I also reverted the length from 9 to 4, but guess this will now fail the build as the BFC in facilities are 9 chars, should they be 4 in the facilities file examples ?
If so I'll re-commit with amends

Yes please "Cut-off" the UN Location Code (first 5 chars) of the BIC code 👍

resolved and apologies, I also reverted the length from 9 to 4, but guess this will now fail the build as the BFC in facilities are 9 chars, should they be 4 in the facilities file examples ?
If so I'll re-commit with amends

Yes please "Cut-off" the UN Location Code (first 5 chars) of the BIC code 👍

all sorted @HenrikHL thanks for your help !

@cmsdroff thanks for this. In order for us to merge into master we need to do a minor change to our current JIT implementation (it only supports SMDG codes). As soon as this is done and it has been tested - it will be merged :-)
Again - thanks for your contribution

@cmsdroff thanks for this. In order for us to merge into master we need to do a minor change to our current JIT implementation (it only supports SMDG codes). As soon as this is done and it has been tested - it will be merged :-)
Again - thanks for your contribution

Your welcome, happy to assist with anything todo with facility codes in future also.

I have verified it against the API validator and the JIT solution (webUI since https://github.com/dcsaorg/P6-Application/commit/5915d38d662224fecae2f863f13e4edde960bb93) and it looks good to me.
I only have the two remarks / nits on the requests dependency and the related message for when python dependencies are missing.

@cmsdroff : Thanks for your contribution. :)


dist-upgrade isn't present in "Ubuntu 18.04" WSL

Your Windows build number:  10.0.17134.112

What you're doing and what's happening:  When I run dist-upgrade, reports command isn't found

What's wrong / what should be happening instead: The command should run the binary in question and let me upgrade to the latest Ubuntu version, whether I've set up my WSL to receive beta versions from Ubuntu or not.

Strace of the failing command, if applicable:  N/A

Works for me, see below. Perhaps you could provide some more steps for reproduction?
myself@DESKTOP-205QDD6:~$ sudo apt dist-upgrade
[sudo] password for myself:
Reading package lists... Done
Building dependency tree
Reading state information... Done
Calculating upgrade... Done
The following packages will be upgraded:
  ebtables
1 upgraded, 0 newly installed, 0 to remove and 0 not upgraded.
Need to get 0 B/79.9 kB of archives.
After this operation, 0 B of additional disk space will be used.
Do you want to continue? [Y/n] ^C

You're right, I was missing apt.


Update 6-explaining-globs.md

Small documentation improvement

see comment on other PR - https://github.com/gulpjs/gulp/pull/2369#issuecomment-524233900


AuthResults to do basic diagnostics

This would have saved my face when I upgraded supabase by pointing out that the token is null, and that it shouldn't be.
When you don't really know what you're looking at/for it's hard to tell when something's not quite right. This tries to help with that.
Before

After (except the token is masked by ***)

LGTM! The formatting JSON is much easier to read as well. Good to merge.


Number in front matter is an int64. substr requires int

A number defined in the front matter is an int64. substr in the go template requires an int.
Example front matter:
+++
rating = 4
+++

Example template
{{ substr "hello" 0 .Params.rating }}

The error given is wrong type for value; expected int; got int64

It is fixed at 51cabe6fafe5b18ce27962b7ec469f69fd5e2229. Please try the tip of the repository.


BUG: TagsInput - The input filed width don't correspond to character length on Safari

Describe the bug
TagsInput component:
The input filed width don't correspond to character length on Safari
To Reproduce
Steps to reproduce the behavior:

run storybook
open the TagsInput
write down long text

Screenshots
It contains Bratislava word.

Desktop (please complete the following information):

OS: IOS
Browser: Safari
Version: 12.0.2

@FilipMessa Seems related to the onLayout callback not being fired on Safari in the InputField component


Jupyterhub update 1.1.0

Motivation for this change
The current jupyterhub 1.0.0 will produce an async error on jupyterhub --help. Updating removed this error.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

I attempted to run nix-shell -p nixpkgs-review --run "nixpkgs-review wip" however it fails with
$ nix-env -f /home/nixos/.cache/nixpkgs-review/rev-2f66d6b72fee0b02df85d2a423c1a231fc3ae5ed-dirty-1/nixpkgs -qaP --xml --out-path --show-trace
$ git worktree prune
Traceback (most recent call last):
  File "/nix/store/91qp2v2h0fd9d6b6hchzf13zki091grv-nixpkgs-review-2.3.1/bin/.nixpkgs-review-wrapped", line 9, in <module>
    sys.exit(main())
  File "/nix/store/91qp2v2h0fd9d6b6hchzf13zki091grv-nixpkgs-review-2.3.1/lib/python3.7/site-packages/nixpkgs_review/__init__.py", line 10, in main
    cli.main(command, args)
  File "/nix/store/91qp2v2h0fd9d6b6hchzf13zki091grv-nixpkgs-review-2.3.1/lib/python3.7/site-packages/nixpkgs_review/cli/__init__.py", line 212, in main
    args.func(args)
  File "/nix/store/91qp2v2h0fd9d6b6hchzf13zki091grv-nixpkgs-review-2.3.1/lib/python3.7/site-packages/nixpkgs_review/cli/wip.py", line 11, in wip_command
    "rev-%s-dirty" % verify_commit_hash("HEAD"), args, None, args.staged
  File "/nix/store/91qp2v2h0fd9d6b6hchzf13zki091grv-nixpkgs-review-2.3.1/lib/python3.7/site-packages/nixpkgs_review/review.py", line 394, in review_local_revision
    review.review_commit(args.branch, args.remote, commit, staged)
  File "/nix/store/91qp2v2h0fd9d6b6hchzf13zki091grv-nixpkgs-review-2.3.1/lib/python3.7/site-packages/nixpkgs_review/review.py", line 217, in review_commit
    self.start_review(self.build_commit(branch_rev, reviewed_commit, staged))
  File "/nix/store/91qp2v2h0fd9d6b6hchzf13zki091grv-nixpkgs-review-2.3.1/lib/python3.7/site-packages/nixpkgs_review/review.py", line 129, in build_commit
    base_packages = list_packages(str(self.worktree_dir()))
  File "/nix/store/91qp2v2h0fd9d6b6hchzf13zki091grv-nixpkgs-review-2.3.1/lib/python3.7/site-packages/nixpkgs_review/review.py", line 283, in list_packages
    return parse_packages_xml(nix_env.stdout)
  File "/nix/store/91qp2v2h0fd9d6b6hchzf13zki091grv-nixpkgs-review-2.3.1/lib/python3.7/site-packages/nixpkgs_review/review.py", line 224, in parse_packages_xml
    for (event, elem) in context:
  File "/nix/store/r94aa2gj4drkhfvkm2p4ab6cblb6kxlq-python3-3.7.6/lib/python3.7/xml/etree/ElementTree.py", line 1228, in iterator
    root = pullparser._close_and_return_root()
  File "/nix/store/r94aa2gj4drkhfvkm2p4ab6cblb6kxlq-python3-3.7.6/lib/python3.7/xml/etree/ElementTree.py", line 1275, in _close_and_return_root
    root = self._parser.close()
xml.etree.ElementTree.ParseError: no element found: line 26474, column 0

This seems unrelated to jupyter.

I don't understand how to run this command nix path-info -S. I get:
$ nix path-info -S
error: Please be informed that this pseudo-package is not the only part of
Nixpkgs that fails to evaluate. You should not evaluate entire Nixpkgs
without some special measures to handle failing packages, like those taken
by Hydra.


Chat messages sometimes do not get sent

This issue started to appear since the update of Fvnkhead's servers to 1.12.4. I don't know if other servers are affected.
This may or may not be linked to #448 as those two issues arised at the same time
Bug
From time to time, sending a message in chat straight up doesn't works.
You can still read the chat and see player messages, but you can't send any messages.
Disconnecting and reconnecting from the server seems to fix this issue.
Logs
chat not working.txt

As far as I tested, this doesn't occurs in 1.12.3. Only 1.12.4

Problem resolved after #447 and/or v1.12.5


Set X and Y depending on div

Hello
I want to set the start position depending on the position of a container.
I am overloading the mounted by
mounted () {
var teamContainerRect = document.getElementById('teamContainer').getBoundingClientRect();
this.x = teamContainerRect.left;
this.y = teamContainerRect.top;
}
This vue draggable is set with vue-draggable-resizable :x="x" :y="y"
But it doesn't move eventhough the X and Y contains the correct value.
It works if I set the values in mounted with a given value.
mounted () {
this.x = 100;
this.y = 100;
}
How come?

Use codesandbox or anything else for minimal example then I can help you.

Use codesandbox or anything else for minimal example then I can help you.

Sure. Basic sample. I have used typescript for project, but the example is js.
https://codesandbox.io/s/frosty-star-9h108
In the component "hello World", I have written the example above.

this.x = teamContainerRect.left; in your example is float.
Change it to this.x = Math.round(teamContainerRect.left); to make it integer.

 It makes sense. Thanks! :)


Add degree aware FFT

Description

closes: #83

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

[ ] Targeted PR against correct branch (master)
[ ] Linked to GitHub issue with discussion and accepted design OR have an explanation in the PR that describes this work.
[ ] Wrote unit tests
[ ] Updated relevant documentation in the code
[ ] Added a relevant changelog entry to the Pending section in CHANGELOG.md
[ ] Re-reviewed Files changed in the GitHub PR explorer

Thanks, this PR is awesome! If you'd like to add benchmark numbers that would be great.
For the unused errors, you can add #[allow(unused)] on the relevant items.

@Pratyush  sad to say the benchmarks are rather depressing. ~7% performance regression on the FFT tests. I added a couple of benchmarks for polynomial multiplication. Multiplication of two polynomials with equal degree also has ~7% regression in performance. The only situation this implementation performs better is when multiplying polynomials of substantially different degree i.e. |poly_a| = |poly_b| * 32 - I actually tested this specific case and it only had a 10% gain over the O(n log n) implementation.
I think the performance degradation is due to fft_in_place using oi_helper (now) instead of io_helper (before). The master branch IFFT benchmarks are 10% slower than the master branch FFT benchmarks and I'm pretty sure it's attributed to IFFTs using oi_helper and FFTs using io_helper

Wow that's quite surprising. Let me take a look and see if we can optimize the out_of_order code.

@ValarDragon any ideas? I've been looking, but can't find a fix.

@andrewmilson I've changed it to only invoke the degree_aware_fft when domain.size() >= p.degree() * 4. I'm seeing perf improvements from doing that. Let me know if this looks good to you!

Awesome thanks. LGTM


contract syntax

state on the class itself
import { BigNumber } from "jsd-std";

export class Counter {
  private count: BigNumber;

  constructor(initialState: BigNumber) {
    this.count = initialState;
  }

  public increment(amount: BigNumber): void {
    this.count = this.count.add(amount);
  }

  public decrement(amount: BigNumber): void {
    if (this.count.lt(amount)) {
      throw new Error("Count cannot be negative");
    }
    this.count = this.count.sub(amount);
  }

  public getCount(): BigNumber {
    return this.count;
  }
}

state as it's own object
import { BigNumber } from "jsd-std";

export interface State {
    count: BigNumber;
}

export class Counter {
  private state: State;

  constructor(initialState: State) {
    this.state.count = initialState;
  }

  public increment(amount: BigNumber): void {
    this.state.count = this.state.count.add(amount);
  }

  public decrement(amount: BigNumber): void {
    if (this.state.count.lt(amount)) {
      throw new Error("Count cannot be negative");
    }
    this.state.count = this.state.count.sub(amount);
  }

  public getCount(): BigNumber {
    return this.state.count;
  }
}

function that initializes in scope
import { BigNumber } from "jsd-std";

interface State {
  count: BigNumber;
}

// Core contract logic
export const start = (initialCount: BigNumber) => {
  let state: State = {
    count: initialCount
  };

  return {
    getCount: () => state.count,

    increment: (amount: BigNumber) => {
      state.count = state.count.add(amount);
      return state.count;
    },

    decrement: (amount: BigNumber) => {
      if (state.count.lt(amount)) {
        throw new Error("Count cannot be negative");
      }
      state.count = state.count.sub(amount);
      return state.count;
    }
  };
};

capabilities
capabilities.json
{
  "public": ["getCount"],
  "admin": ["getCount", "increment"],
  "creator": ["getCount", "increment", "decrement"]
}

entrypoint.ts
import { BigNumber } from "jsd-std";

interface State {
  count: BigNumber;
}

// Core contract logic
export const start = (initialCount: BigNumber) => {
  let state: State = {
    count: initialCount
  };

  return {
    getCount: () => state.count,

    increment: (amount: BigNumber) => {
      state.count = state.count.add(amount);
      return state.count;
    },

    decrement: (amount: BigNumber) => {
      if (state.count.lt(amount)) {
        throw new Error("Count cannot be negative");
      }
      state.count = state.count.sub(amount);
      return state.count;
    }
  };
};

decorators and function that initializes in scope
import { BigNumber } from "jsd-std";

// Permission decorators
export const admin = (target: any, propertyKey: string, descriptor: PropertyDescriptor) => descriptor;
export const creator = (target: any, propertyKey: string, descriptor: PropertyDescriptor) => descriptor;

interface State {
  count: BigNumber;
}

export const start = (initialCount: BigNumber) => {
  let state: State = {
    count: initialCount
  };

  return {
    // Public by default (no decorator needed)
    getCount: () => state.count,

    // Only admin and creator can increment
    @admin
    increment: (amount: BigNumber) => {
      state.count = state.count.add(amount);
      return state.count;
    },

    // Only creator can decrement
    @creator
    decrement: (amount: BigNumber) => {
      if (state.count.lt(amount)) {
        throw new Error("Count cannot be negative");
      }
      state.count = state.count.sub(amount);
      return state.count;
    }
  };
};

modifiers?
import { BigNumber } from "jsd-std";

// Types
type Address = string;

// Events
@event
interface CounterEvents {
  Increment(who: Address, amount: BigNumber);
  Decrement(who: Address, amount: BigNumber);
  Transfer(from: Address, to: Address, amount: BigNumber);
}

// Modifiers
@modifier
function nonZero(amount: BigNumber) {
  if (amount.lte(0)) throw new Error("Amount must be positive");
}

export interface State {
  count: BigNumber;
  owner: Address;
  admins: Map<Address, boolean>;
  balance: BigNumber;
}

export class Counter {
  private state: State;

  constructor(initialState: State) {
    this.state.count = initialState.count;
    this.state.owner = msg.sender; // assuming we have msg.sender
    this.state.admins = new Map();
    this.state.balance = BigNumber.from(0);
  }

  // View function (readonly)
  @view
  public getCount(): BigNumber {
    return this.state.count;
  }

  // Admin function with event emission
  @admin
  @nonZero
  public increment(amount: BigNumber): void {
    this.state.count = this.state.count.add(amount);
    emit.Increment(msg.sender, amount);
  }

  // Creator function with event emission
  @creator
  @nonZero
  public decrement(amount: BigNumber): void {
    if (this.state.count.lt(amount)) {
      throw new Error("Count cannot be negative");
    }
    this.state.count = this.state.count.sub(amount);
    emit.Decrement(msg.sender, amount);
  }

  // Payable function example
  @payable
  public deposit(): void {
    this.state.balance = this.state.balance.add(msg.value);
  }

  // Admin management
  @creator
  public addAdmin(admin: Address): void {
    this.state.admins.set(admin, true);
  }

  @creator
  public removeAdmin(admin: Address): void {
    this.state.admins.delete(admin);
  }

  // Balance withdrawal
  @creator
  public withdraw(amount: BigNumber): void {
    if (this.state.balance.lt(amount)) {
      throw new Error("Insufficient balance");
    }
    this.state.balance = this.state.balance.sub(amount);
    // Assuming we have transfer capability
    transfer(msg.sender, amount);
    emit.Transfer(this.address, msg.sender, amount);
  }
}


change line protocol to reflect changes in newest influx

addresses #231

Write one test in test_line_protocol.py please.

closing in favour of @djeebus' solution


Integration with AWS SageMaker DeepAR models

We would like to perform anomaly detection based on DeepAR prediction models:
https://docs.aws.amazon.com/sagemaker/latest/dg/deepar.html
This should be implemented as an external detector, linked in with a virtual detector.

Can I do this one too?

Closing, as this would be external to AA.


Added bit stream utils

Utils for working with bit stream buffers and text strings.
This CL is a foundation block for future development of SPIR-V compression. It fixes https://github.com/KhronosGroup/SPIRV-Tools/issues/637.

Let me know when this is ready for re-review.

Build failure with Clang:
../external/googletest/googletest/include/gtest/gtest.h:1392:11: error: comparison of integers of different signs: 'const int' and 'const unsigned long' [-Werror,-Wsign-compare]
if (lhs == rhs) {
~~~ ^  ~~~

Should be ready.

I've verified with an Android build via google/shaderc.  (I added the source/util/bit_stream.cpp to its third_party/Android.mk)

Rebased, squashed and pushed into master as 3eb716cae


Verify that Rasa OSS github project doesn't list py3.6 when 3.0 is out on pypi

We dropped support for py36 so we shouldn't have it in the repo badge.

However it may be the case that we can't change this because of old release branches - so needs to be looked into.

@joejuzl as far as I can tell the badge is going to be updated automatically when there is a newer version of rasa published on Pypi. I think the reason we're not seeing the badge updated right now is that the 3.0.0rc1 is a prerelease version, hence it's not treated as a stable latest version. I will keep this ticket open, in the backlog for now and double check that it's updated when 3.0 is out.

@m-vdb Is there anything we can do here? I don't see it updated on the GitHub repo

🤦🏻 apparently the Python 3.6 classifier was defined independently of the required python dependency.... I've put up a PR here: https://github.com/RasaHQ/rasa/pull/10405

It is fixed ✅  (will clean things up on the SDK though)


v2.8.0

Codecov Report

Merging #235 (117e41e) into main (a1fa0a8) will decrease coverage by 4.46%.
The diff coverage is 11.11%.

@@            Coverage Diff             @@
##             main     #235      +/-   ##
==========================================
- Coverage   79.01%   74.55%   -4.47%
==========================================
  Files          82       82
  Lines        2840     2912      +72
==========================================
- Hits         2244     2171      -73
- Misses        596      741     +145

Impacted Files
Coverage Δ

lib/hip_pilot.rb
47.68% <0.00%> (-10.66%)
:arrow_down:

app/controllers/requests_controller.rb
28.81% <6.89%> (-38.84%)
:arrow_down:

app/models/solr_document.rb
65.71% <8.00%> (-32.07%)
:arrow_down:

app/helpers/local_catalog_helper.rb
71.67% <9.52%> (-12.05%)
:arrow_down:

config/routes.rb
97.18% <100.00%> (+0.08%)
:arrow_up:

.../dlf_expanded_passthrough/to_holdings_extension.rb
85.39% <100.00%> (ø)

lib/ils_status.rb
42.30% <0.00%> (-46.16%)
:arrow_down:

app/helpers/holdings_helper.rb
28.57% <0.00%> (-28.58%)
:arrow_down:

app/models/holding.rb
85.41% <0.00%> (-10.42%)
:arrow_down:

... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1fa0a8...117e41e. Read the comment docs.


feat(storage): move memtable down to local state store

I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.
What's changed and what's your intention?
In our current storage code, the LocalStateStore provides get and iter method for MVCC read, which need to specify epoch for reading, and ingest_batch method to write the data to a specified epoch. However, the streaming executor access its state via StateTable, which wraps a LocalStateStore instance and provides read method get and method without requirement for MVCC support, and insert, delete and update method for single key operations. The StateTable holds a MemTable to buffer the single key operations, and calls ingest_batch to flush the buffer to LocalStateStore in every epoch.
The current architecture has the following drawbacks:

It makes the StateTable not only a layer to convert the encoded value bytes to relational rows, but also need to hold storage state. The state stored in the memtable of StateTable becomes alien to the storage part, and is hard to track.
The current memtable stores the old value of each key operation, but after ingest_batch, the old value is not accessible to the StateStore, which get rid of the possibility to do failure recovery.
The interface of the storage part to the streaming part is actually the StateTable, which does not require any MVCC support. However, the StateStoreRead trait still require MVCC support, and introduces unnecessary difficulty in our attempt on benchmarking with some simple kv library, such as BTreeMap or RocksDB.

In this PR, we try to resolve the drawbacks mentioned above. It involves the following changes.
First, we modify our LocalStateStore trait to the following one.
pub trait LocalStateStore: StaticSendSync {
    type IterStream<'a>: StateStoreIterItemStream + 'a;

    fn get<'a>(&'a self, key: &'a [u8], read_options: ReadOptions) -> Self::GetFuture<'_>;

    fn iter(
        &self,
        key_range: (Bound<Vec<u8>>, Bound<Vec<u8>>),
        read_options: ReadOptions,
    ) -> Self::IterFuture<'_>;

    fn insert(&mut self, key: Bytes, new_val: Bytes, old_val: Option<Bytes>) -> StorageResult<()>;

    fn delete(&mut self, key: Bytes, old_val: Bytes) -> StorageResult<()>;

    fn flush(&mut self, delete_ranges: Vec<(Bytes, Bytes)>) -> Self::FlushFuture<'_>;

    fn epoch(&self) -> u64;

    fn is_dirty(&self) -> bool;

    fn init(&mut self, epoch: u64);

    fn seal_current_epoch(&mut self, next_epoch: u64);
}

Under this new LocalStateStore trait, after we create a new instance, we need to call init on the instance, and the subsequent read and write will be performed on the epoch. After we finish the operations on the current epoch, we will call seal_current_epoch(next_epoch), which marks the current epoch as sealed and starts the next_epoch. Within each epoch, we can do insert and delete to write the state of current epoch, and do get and iter to read the state. Note that, the get and iter will read the latest value modified by potentially previous insert and delete.
Second, we provide a simple implementation on the new LocalStateStore trait, named MemtableStateStore<S: StateStoreWrite>. The MemtableStateStore is similar to the current state table, which holds an inner instance that supports ingest_batch, with a memtable to buffer the key operation of current epoch, and flush the buffer via ingest_batch at the end of each epoch.
In the future, we can do more things with the new LocalStateStore trait.

We can have our own LocalStateStore implementation for Hummock, which provides features such as failure recovery, and memtable across multiple epochs.
We can implement LocalStateStore trait for kv library such as RocksDB and BTreeMap for benchmarking the streaming performance without necessity for MVCC. Note that since MVCC is still needed for batch query, the implementation will not support batch query, and may need to sink to somewhere else for correctness check.

Checklist

[x] I have written necessary rustdoc comments
[x] I have added necessary unit tests and integration tests
[x] All checks passed in ./risedev check (or alias, ./risedev c)

Refer to a related PR or issue link (optional)

Good Work! I will review this PR ASAP.


Implement systemd.services.<name>.createDirs

Currently we don't have interface that would create data directories before service is started. People used to handle this on different ways, that worked more or less successfully:

Using user.createHome = true. That didn't used to work very well, when new interface for users was introduced services used to break.
Using activation scripts. I like this solution, because it's simple, but it's not used very much.
Using something i call dual behaviour. So using systemd option PermissionsStartOnly = true systemd starts pre and post startup scripts as root. The problem is that you now have to use su to become user and then you have to handle dual behaviour if services are started as root (with systemd) or with some other implementation. I especially dislike that behaviour, it also does not work on user services implementation i use (https://github.com/kiberpipa/nix-rehash/tree/master/nix-services) in osx.

Now the question is how should i implement this?

@shlevy proposed that pre and post start should be split into new service and service would depend on both of them. The problem here is that if we would only need this for creating data dirs, this is kind of overdesign, but on the other hand pre and post scripts could be started independantly.
Use activation scripts to create directories
... ?

I would also need some help implementing this. I think this option is very much needed.

(triage) @offlinehacker do you plan on following through with that? Is it even necessary anymore?

In general, don't we just want to copy the same module set as other popular configuration management systems have? E.g. in Puppet, you have:
https://docs.puppetlabs.com/puppet/latest/reference/type.html#file . When I see NixOS configuration management it sort of feels like one still needs to build all the basics before getting to the real work.
From a UI point of view something like the following:
dir."/exports/foo".status = "present";
dir."/exports/foo".owner = "alice";

seems to be the way to go. The advantages of this is that it leverages well known terminology and seems to be fairly consistent with how NixOS already does configuration.

I don’t quite understand what you are referring to, @aragnon. The case of systemd service files or sth. more general?
Since no followup in over a week we can close @jagajaga

@Profpatsch Something more general; I don't think merely creating a directory should depend on systemd.

You are probably overcomplicating things. You can put any file you want into the store, trivially (look into pkgs/build-support/trivial-builders.
And for etc there exists environment.etc, although it should be used very sparingly and only if that crude program behaviour cannot be patched out.

The store is /nix, so how do I specify an arbitrary location like /constant?

Op 18 mrt. 2016 om 22:39 heeft Profpatsch<EMAIL_ADDRESS>het volgende geschreven:
You are probably overcomplicating things. You can put any file you want into the store, trivially (look into pkgs/build-support/trivial-builders.
And for etc there exists environment.etc, although it should be used very sparingly and only if that crude program behaviour cannot be patched out.
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub

@aragnon Why do you want to do that?  If you want to do something elaborate on a module level (like having state files for services) you can create a new user that has its own home directory. See for example how I do it here, where I create a home in /var/lib.

@Profpatsch I want to setup an NFSv4 location at e.g. /nfs-export/constant.

close @zimbatm


Add support for STATSD_* environment variables

I found no existing way to use environment variables to enable and modify the statsd configuration for the bamboo docker container.  This PR adds support for modifying the bamboo docker container statsd configuration via environment variables.  I've tested this on my own mesos cluster and confirmed it's sending metrics to my statsd server that I can view in graphite.
NOTE: This is the first time I've touched GO, so my code may not be the best. It does work though :)

Hi, thanks for the PR. I'm just working a few improvement this couple of
days.
Sent from my iPhone
On 3 Feb 2015, at 20:22, John Alberts<EMAIL_ADDRESS>wrote:
I found no existing way to use environment variables to enable and modify
the statsd configuration for the bamboo docker container. This PR adds
support for modifying the bamboo docker container statsd configuration via
environment variables. I've tested this on my own mesos cluster and
confirmed it's sending metrics to my statsd server that I can view in
graphite.
NOTE: This is the first time I've touched GO, so my code may not be the
best. It does work though :)
You can view, comment on, or merge this pull request online at:
https://github.com/QubitProducts/bamboo/pull/77
Commit Summary

Add support for STATSD_* environment variables

File Changes

M configuration/configuration.go
https://github.com/QubitProducts/bamboo/pull/77/files#diff-0 (18)

Patch Links:

https://github.com/QubitProducts/bamboo/pull/77.patch
https://github.com/QubitProducts/bamboo/pull/77.diff

—
Reply to this email directly or view it on GitHub
https://github.com/QubitProducts/bamboo/pull/77.

Thanks for the contribution.


pointer constraints not working properly with multiple monitors

Hyprland Version
 System/Version info
Hyprland, built from branch HEAD at commit 03ebbe18ed8517ee22591eac82cd54322f42cb7d  (props: bump ver to 0.34.0).
Date: Mon Jan 1 12:03:15 2024
Tag: v0.34.0

flags: (if any)

Bug or Regression?
Bug
Description
With an active zwp_pointer_constraints_v1::lock_pointer instance, the mouse cursor is released from surfaces when the mouse enters another output.
How to reproduce
Instantiate a layershell surface and add a pointer constraint object to it pointer_constraints.lock_pointer(surface, pointer, None, Lifetime::Persistent). Move the mouse into the layer surface -> its locked.
Moving the (now invisible mouse) to a different monitor releases the mouse from the layer surface.
This behaviour is different than at least

wayfire
sway
KDE
On the above compositors the mouse stays locked.

The code in question can be found here.
To reproduce, Lan Mouse can be used (will require two pcs).
I can try to make a more minimal reproducable example.
Crash reports, logs, images, videos
No response

closed in https://github.com/hyprwm/Hyprland/pull/4889


How to add middleware without directive?

I would like to hook custom delegate before field is resolved without decorating schema field with directive? Is that possible? Something like described in here https://hotchocolate.io/docs/next/directive-middleware#middleware but without actual directive. Something that I can add to schema configuration and it would execute before any field is resolved with possibility to override result of that field.

Hi,
this would be actually this PR #363
Will come with the next version....
we are introducing then three kinds of middlewares:

Query Middleware
This will basically allow you to rewrite and modify requests  (this is needed for our schema stitching framework)

Field Middleware
This will integrate to all field resolvers.

Directive Middleware
This is a selective middleware that only includes itself if annotated

we will provide a preview of this feature tomorrow night with 0.7.0-preview.2

0.7.0-preview.2 is building now
Here is how to use it:
Schema.Create(c => {
   c.Use(next => context =>
   {
        next(context);
        if(context.Result is string s)
        {
             context.Result = s.ToUpper();
        }
   });
});

Field Middlewares are built into every field resolver during schema creation, so they will always run. This is opposed to directive middlewares.
So, an instrumentation middleware would be best implemented as directive middleware since it could be annotated to the whole request or just to problem fields to get performance insights.
Some other middlewares are better written as field middleware since those are always executed. resolver

Please remember that we are still working on this feature. Query middlewares are not yet included and last but not least feedback is welcome :)

I will close this issue... Feedback can be added to #338


Logging out of trade site

After searching items with the ctrl+d hotkey it seems to log me out of the official trade site

Hi, thanks for creating an issue. Could you please expand on this a little further? Logging out of the internal browser? Everytime? Once? etc. Thanks!


ci: Add NodeJS 20 to matrix. Dropped NodeJS 14.

Platforms affected
CI
Motivation and Context

Adds NodeJS 20 to the test matrix because that will be the next LTS.
Removed NodeJS 14 as it's in maintenance. Note that NodeJS 14.x support is dropped, just will not be tested.
Description

Testing

Checklist

[x] I've run the tests to see all new and existing tests pass
[x] I added automated test coverage as appropriate for this change
[x] Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
[x] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
[x] I've updated the documentation if necessary

Codecov Report

Merging #119 (694126a) into master (529aba2) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #119   +/-   ##
=======================================
  Coverage   93.75%   93.75%
=======================================
  Files           2        2
  Lines          32       32
=======================================
  Hits           30       30
  Misses          2        2

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Design and Implement More sustainable Branching & Deployment Strategy

Background
OSS & Closed source repo - we currently have 1 master branch for both. How should we approach branching model, releases, and deployments? And configuration for deployment, etc. Proper solution must be implemented so that we have a more granular control over this.

A solution was designed and consulted on our internal meeting, available on our internal Miro board, screenshot below. We'll have a second repository, closed source one, that implements configs and IaC and points to this OSS one, and then deploys the service and DB into our AWS and/or on-prem space.

Done here: https://github.com/absa-group/atum-service-deployment/pull/23


How i change download location?

im running rutorrent on pi3+ i have mounted 2 tb hard drive and the hd i set to auto mount on reboot
i looked at .rtorrent.rc and all i see is
Set Directories
method.insert = cfg.basedir,     private|const|string, (cat,"/home/yair/rtorrent/")
method.insert = cfg.watch,       private|const|string, (cat,(cfg.basedir),"watch/")
#method.insert = cfg.logs,       private|const|string, (cat,(cfg.basedir),"log/")
#method.insert = cfg.logfile,    private|const|string, (cat,(cfg.logs),"rtorrent-",(system.time),".log")
session.path.set = (cat,(cfg.basedir),".session")
directory.default.set = (cat,(cfg.basedir),"download")
schedule = watch_directory,5,5,((load.start,(cat,(cfg.watch),"*.torrent")))
my hd drive is /media/storage/torrents/downloads
if i change the line method.insert = cfg.basedir,     private|const|string, (cat,"/home/yair/rtorrent/") to method.insert = cfg.basedir,     private|const|string, (cat,"/media/storage/torrents/downloads/") and restart rutorrent the the rutorrent won't work i get error
No connection to rTorrent. Check if it is really running. Check $scgi_port and $scgi_host settings in config.php and scgi_port in rTorrent configuration file.
how to change the default download location?
what happend to the old fasion way?
Default directory to save the downloaded torrents.
directory = /home/username/dir name

This is more of a question for rtorrent project, but essentially you can see from what you have copied that you set a base directory and then sub-folders, for default download, watch folders and session folder.
I believe that while you can change the directories it needs to be on the same partition. So if you want to use an external drive you would need to mount it into the home partition. Do a google search on mounting drives in linux to get info on how to do that.
As this is an rtorrent question rather than a question on my script I am closing it.


Don't Merge! PR real time test for target branch full build

Docs Build status updates of commit 7764a21:
:clock10: Full build: the average full build time is 7 min(s) 26 sec(s), this is based on the last 30 build(s) for this repository.

Docs Build status updates of commit 7764a21:
:warning: Validation status: warnings

File
Status
Preview URL
Details

docs-ref-conceptual/authenticate-azure-cli.md
:warning:Warning
View (azure-cli-latest) View (azure-cli-2017-03-09-profile) View (azure-cli-2018-03-01-hybrid)
Details

docs-ref-conceptual/azure-cli-configuration.md
:warning:Warning
View (azure-cli-latest) View (azure-cli-2017-03-09-profile) View (azure-cli-2018-03-01-hybrid)
Details

docs-ref-conceptual/install-azure-cli-macos.md
:warning:Warning
View (azure-cli-latest) View (azure-cli-2017-03-09-profile) View (azure-cli-2018-03-01-hybrid)
Details

docs-ref-conceptual/install-azure-cli-apt.md
:warning:Warning
View (azure-cli-latest) View (azure-cli-2017-03-09-profile) View (azure-cli-2018-03-01-hybrid)
Details

docs-ref-conceptual/testing.md
:white_check_mark:Succeeded
View (azure-cli-latest) View (azure-cli-2017-03-09-profile) View (azure-cli-2018-03-01-hybrid)

docs-ref-conceptual/authenticate-azure-cli.md

Line 20: [Warning-hard-coded-locale] Link 'https://docs.microsoft.com/en-us/azure/active-directory/develop/v1-id-and-access-tokens#refresh-tokens' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
Line 20: [Warning-hard-coded-locale] Link 'https://docs.microsoft.com/en-us/azure/active-directory/develop/v1-id-and-access-tokens#refresh-tokens' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
Line 20: [Warning-hard-coded-locale] Link 'https://docs.microsoft.com/en-us/azure/active-directory/develop/v1-id-and-access-tokens#refresh-tokens' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
Line 113: [Warning-hard-coded-locale] Link 'https://docs.microsoft.com/en-us/azure/active-directory/managed-identities-azure-resources/qs-configure-cli-windows-vm' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
Line 113: [Warning-hard-coded-locale] Link 'https://docs.microsoft.com/en-us/azure/active-directory/managed-identities-azure-resources/how-to-use-vm-sign-in' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
Line 113: [Warning-hard-coded-locale] Link 'https://docs.microsoft.com/en-us/azure/active-directory/managed-identities-azure-resources/qs-configure-cli-windows-vm' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
Line 113: [Warning-hard-coded-locale] Link 'https://docs.microsoft.com/en-us/azure/active-directory/managed-identities-azure-resources/how-to-use-vm-sign-in' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
Line 113: [Warning-hard-coded-locale] Link 'https://docs.microsoft.com/en-us/azure/active-directory/managed-identities-azure-resources/qs-configure-cli-windows-vm' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
Line 113: [Warning-hard-coded-locale] Link 'https://docs.microsoft.com/en-us/azure/active-directory/managed-identities-azure-resources/how-to-use-vm-sign-in' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.

docs-ref-conceptual/azure-cli-configuration.md

Line 92: [Warning-insecure-link] Link 'http://aka.ms/AzureCliLegal' is insecure. Links to Microsoft sites must use 'https' instead of 'http'.
Line 92: [Warning-insecure-link] Link 'http://aka.ms/AzureCliLegal' is insecure. Links to Microsoft sites must use 'https' instead of 'http'.
Line 92: [Warning-insecure-link] Link 'http://aka.ms/AzureCliLegal' is insecure. Links to Microsoft sites must use 'https' instead of 'http'.

docs-ref-conceptual/install-azure-cli-macos.md

Line 60: [Warning-InvalidBookmark] Invalid link: 'update'. The file docs-ref-conceptual/install-azure-cli-macos.md doesn't contain a bookmark named 'Update'.
Line 60: [Warning-InvalidBookmark] Invalid link: 'update'. The file docs-ref-conceptual/install-azure-cli-macos.md doesn't contain a bookmark named 'Update'.
Line 60: [Warning-InvalidBookmark] Invalid link: 'update'. The file docs-ref-conceptual/install-azure-cli-macos.md doesn't contain a bookmark named 'Update'.

docs-ref-conceptual/install-azure-cli-apt.md

Line 84: [Warning-InvalidBookmark] Invalid link: 'install step 1'. The file docs-ref-conceptual/install-azure-cli-apt.md doesn't contain a bookmark named 'install-step-1'.
Line 84: [Warning-InvalidBookmark] Invalid link: 'install step 1'. The file docs-ref-conceptual/install-azure-cli-apt.md doesn't contain a bookmark named 'install-step-1'.
Line 84: [Warning-InvalidBookmark] Invalid link: 'install step 1'. The file docs-ref-conceptual/install-azure-cli-apt.md doesn't contain a bookmark named 'install-step-1'.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


Atharvak/food on fork node

Description
[TODO: describe, in-detail, what issue this PR addresses and how it addresses it. Link to relevant Github Issues.]
Testing procedure
[TODO: describe, in-detail, how you tested this. The procedure must be detailed enough for the reviewer(s) to recreate it.]
Before opening a pull request

[ ] Format your code using black formatter python3 -m black .
[ ] Run your code through pylint and address (most) warnings/errors: pylint --recursive=y .

Before Merging

[ ] Squash & Merge

Closing this PR because I am creating another branch that will have code related to the FoF node.


WIP: add telemetry event types

added tests

Could you also please update teh description with a summary of the changes?


Fix double slot release after request cancellation

It looks like a regression got introduced with https://github.com/triton-inference-server/core/pull/273.
Cancelled requets release a slot in the sequence batcher, but the very same request still get reaped after idle which leads to the same slot (now potentially already taken by another sequence) to be released again. This can have severe consequences when using the implicit state management, because the state is associated with the slot.
This is the root cause for the problem described in https://github.com/triton-inference-server/server/issues/7117.
I have tested this change against a very simple example with the gRPC Python client and a simple sequence model that has max_candidate_sequences 2. I sent two requests, one that is currently executed and another that is queued up in the sequence batcher, now I cancel request two and wait for max_sequence_idle_microseconds. Now I send two new sequences and see in the logs that they both get assigned slot 0

Thanks for the submission @HennerM ! We're looking into this PR and the underlying root causes or edge cases throughout the Sequence Batch Scheduler.


Inline styles from CDN scripts refusing to apply on Edge 14

Expected behaviour
Scripts loaded externally from our CDN should be able to apply inline styles.
Manifestation - the show/hide buttons on the introduction page should show/hide the content below them.
Actual behaviour
When an external script attempts to apply an inline style Edge 14 blocks it.
Manifestation - the show/hide buttons on the introduction page have no effect. The guidance is always shown.
Steps to reproduce the behaviour
Run the app using Edge 14, check the console for errors and test the show/hide buttons on a questionnaire with an introduction page.
Technical information
I think this became an issue when the scripts were externalised to the CDN.
Browser
Edge 14
Operating System
Windows 10
Screenshot

This may not be worth fixing.
The experience will be similar to the non-JS experience for users so it doesn't prevent them using it.
The issue is fixed in Edge 15 and 16.

What exactly does it block? I think this uses the Accordion component which applies classes/attributes rather than inlining styles onto elements.

It's not clear from the log exactly what is getting blocked. Just says that CSP has blocked an inline style from being applied but IE doesn't seem to provide enough context to work out where.