itkImageMaskSpatialObject cause regisration failures post SO update

Description
Regression tests in the BRAINSFit application (primarily itk::ImageRegistrationMethodv4) with explicitly specified itkImageMaskSpatialObjects passed prior to the SpatialObject update, but fails after the SpatialObject refactoring.
In both cases the rigid registration process runs, but with the New spatial objects the registration results are not good.

Actual behavior
Registrations that depend on masks now fail.
Reproducibility
100%
Versions
All git ITK versions after SpatialObject updates after "644390437c62f4d69381e528f295821e50d798fa"
Environment
MacOSX
Additional Information

@aylward This has been a very difficult bug to track down.  I've been working on it all week (it's the motivation for the backwards compatible legacy interfaces).
I can replicate this problem on more than 1 computer. (Macs and linux).
Do you have any intuition about what might be going wrong?
FYI:  The test case is one where the moving image and moving image mask was generated my manually rotating and translating the fixed image.

Sorry that the changes are causing such problems!
Can you check one thing for me?   In lines 979 and 1016 of
Modules/Registration/RegistrationMethodsv4/include/ImageRegistrationMethodv4.hxx
can you try changing
IsInsideInWorldSpace(
to
IsInsideInObjectSpace(
I suspect that the ObjectToWorldTransform isn't getting correctly updated,
so the mask does not overlap the image appropriately.   The above change
bypasses the ObjectToWorldTransform and ObjectToParentTransform.  It only
uses the physical space of the image.
If that fixes the problem, then we need to ensure Update() has been called
on the top level object after all transforms have been set.
s
On Fri, Apr 5, 2019 at 11:34 AM Hans Johnson<EMAIL_ADDRESS>wrote:

@aylward https://github.com/aylward This has been a very difficult bug
to track down. I've been working on it all week (it's the motivation for
the backwards compatible legacy interfaces).
I can replicate this problem on more than 1 computer. (Macs and linux).
Do you have any intuition about what might be going wrong?
FYI: The test case is one where the moving image and moving image mask was
generated my manually rotating and translating the fixed image.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/InsightSoftwareConsortium/ITK/issues/694#issuecomment-480320736,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AARErx_4lDDsYJyZXcHtDCnhR3cYHZ0wks5vd2z2gaJpZM4cfME9
.

--
Stephen R. Aylward, Ph.D.
Senior Director of Strategic Initiatives, Kitware, Inc., North Carolina
Kitware: Advancing the frontiers of understanding
by developing innovative open-source software platforms
and integrating them into research, processes, and products.

@aylward   I think there might be a BUG in the new itkImageMaskSpatialObjects filter.
newITK.log
oldITK.log

When printing debug information between old and new SpatialObjects, quite different results are presented.

The logic for ComputeMyBoundingBox is not valid for the
ImageMaskSpatialObject.   It will be off by one voxel in select
directions.  Is that consistent with what you are seeing?   Is that error
sufficient to cause the problems you are seeing?
On Fri, Apr 5, 2019 at 12:17 PM Hans Johnson<EMAIL_ADDRESS>wrote:

@aylward https://github.com/aylward I think there might be a BUG in the
new itkImageMaskSpatialObjects filter.
newITK.log
https://github.com/InsightSoftwareConsortium/ITK/files/3048781/newITK.log
oldITK.log
https://github.com/InsightSoftwareConsortium/ITK/files/3048782/oldITK.log
[image: image]
https://user-images.githubusercontent.com/313970/55641717-2c35a400-5794-11e9-8e06-5470fb70664c.png
When printing debug information between old and new SpatialObjects, quite
different results are presented.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/InsightSoftwareConsortium/ITK/issues/694#issuecomment-480335529,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AARErwuSyfxH5s7YQAK8b0eSFqcDImvUks5vd3cYgaJpZM4cfME9
.

--
Stephen R. Aylward, Ph.D.
Senior Director of Strategic Initiatives, Kitware, Inc., North Carolina
Kitware: Advancing the frontiers of understanding
by developing innovative open-source software platforms
and integrating them into research, processes, and products.

@aylward Should this be IsInsideObjectSpace or IsInsideWorldSpace for backwards compatibility?
https://github.com/InsightSoftwareConsortium/ITK/blob/49e414bb92a58386f61245c6cd45dcf5666760a8/Modules/Core/SpatialObjects/include/itkSpatialObject.h#L508-L511
MigrationGuide:
Each member function and variable of a SpatialObject now explicitly declares (via its name) if it is operating in WorldSpace or ObjectSpace. For example, the IsInside( point ) function has been replaced by two functions IsInsideInObjectSpace( point ) and IsInsideInWorldSpace( point ) functions.

The backward compatible behavior varied per SpatialObject.   This was a
huge reason for making the space of the member functions explicit.
The correct behavior is WorldSpace.   That way you can move the ImageMask
using the ObjectToParentTransform or via a hierarchy of SpatialObjects.
Otherwise, you are locked to having a mask in the space in which it was
recorded.
Note also that a more general implementation is to simply pass a
SpatialObject as the "mask."   Every SpatialObject has an
IsInsideInWorldSpace() function, so any SpatialObject can be used as a
"mask".
From what I can tell from the logs, the ObjectToWorldTransform is correct.
All is good.   The only difference seems to be the bounding box.   I
definitely will be off by one voxel in certain directions, but it should
not be off by any more than that.   I am finishing another set of changes,
and then I will fix this.
s
On Fri, Apr 5, 2019 at 2:02 PM Hans Johnson<EMAIL_ADDRESS>wrote:

@aylward https://github.com/aylward Should this be IsInsideObjectSpace
or IsInsideWorldSpace for backwards compatibility?
https://github.com/InsightSoftwareConsortium/ITK/blob/49e414bb92a58386f61245c6cd45dcf5666760a8/Modules/Core/SpatialObjects/include/itkSpatialObject.h#L508-L511
MigrationGuide:
Each member function and variable of a SpatialObject now explicitly
declares (via its name) if it is operating in WorldSpace or ObjectSpace.
For example, the IsInside( point ) function has been replaced by two
functions IsInsideInObjectSpace( point ) and IsInsideInWorldSpace( point )
functions.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/InsightSoftwareConsortium/ITK/issues/694#issuecomment-480369346,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAREr1AL7x-rAZvJuX7iIU_QXIckYIJwks5vd4_HgaJpZM4cfME9
.

--
Stephen R. Aylward, Ph.D.
Senior Director of Strategic Initiatives, Kitware, Inc., North Carolina
Kitware: Advancing the frontiers of understanding
by developing innovative open-source software platforms
and integrating them into research, processes, and products.

Also, by "correct behavior is IsInsideInWorldSpace()" I am referring to this specific use case, i.e., using an arbitrary spatial object as a mask.   In other context, IsInsideInObjectSpace() may be the right function to use, e.g., when manipulating a spatial object that was extracted from a specific image.

After further review of the code for ComputeMyBoundingBox() in itkImageMaskSpatialObject, I think it is correct.    Looking over the old code for this function, it computed the bounding box in IndexSpace and then transformed it into WorldSpace.  This will not result in a minimal bounding box in WorldSpace.  So, the old method gave a much larger bounding region for your particular data.    Both the new and the old method give a valid bounding box - the new method gives one that is tighter.
This bounding box is also only used as a first test for IsInsideInWorldSpace().   If a point is in the bounding box, then it queries the image to test the specific point, checking for a non-zero value to indicate IsInside.   So, unless the bounding box is chopping off part of the mask, having a larger/smaller box (as long as it doesn't chop the mask) should not matter.
If we want full backward compatibility, I think the only solution is to create a directory called SpatialObjectsv4 and place the old code in it.  Otherwise we will go nuts trying to replicate prior (sometime bad) behavior).    Sorry that I didn't know that ITKv4 was trying to preserve backward compatibility when I made these changes.

@aylward Thanks. I'll look at this again as soon as i can.  I'm leaving for ISBI tonight.

I leave for ISBI on Sunday.   See you there!
On Fri, Apr 5, 2019 at 4:57 PM Hans Johnson<EMAIL_ADDRESS>wrote:

@aylward https://github.com/aylward Thanks. I'll look at this again as
soon as i can. I'm leaving for ISBI tonight.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/InsightSoftwareConsortium/ITK/issues/694#issuecomment-480419605,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AARErybdIbPVOc15p03NMMrsokP3jzwsks5vd7ivgaJpZM4cfME9
.

--
Stephen R. Aylward, Ph.D.
Senior Director of Strategic Initiatives, Kitware, Inc., North Carolina
Kitware: Advancing the frontiers of understanding
by developing innovative open-source software platforms
and integrating them into research, processes, and products.

Hi,
I'm trying to get ANTs registration working again with masks. I think there might be a couple of issues on the ANTs side.
One ITK thing that is confusing me is the proper usage of the IsInsideInWorldSpace and IsInsideInObjectSpace methods with ImageMaskSpatialObject.
In itkSpatialObject.hxx, the method IsInsideInWorldSpace appears to expect a point in world space, which it transforms into object space before calling IsInsideInObjectSpace
https://github.com/InsightSoftwareConsortium/ITK/blob/414d80fe0b75207fb51f569c0ed5fcceeb6d7248/Modules/Core/SpatialObjects/include/itkSpatialObject.hxx#L225-L226
But in itkImageMaskSpatialObject.hxx, the method IsInsideInObjectSpace also appears to want a point in world space, which it then transforms to object space.
https://github.com/InsightSoftwareConsortium/ITK/blob/414d80fe0b75207fb51f569c0ed5fcceeb6d7248/Modules/Core/SpatialObjects/include/itkImageMaskSpatialObject.hxx#L49-L50
Should IsInsideInObjectSpace expect a point in object space as its argument?

That is an object space to index space transform.  So, it is correctly treating the point as an object space point.
An image exists in object space.  World space is achieved by composing thebobjecttoparentransforms as you move up a hierarchy (parent child relationships) of Spatial Objects.
Hope this helps .

Can we close this issue?   @hjmjohnson has reported that this is now working - the bug was related to a corner / unstable case / test.

Yes, please close.
Hans
From<EMAIL_ADDRESS><EMAIL_ADDRESS>Reply-To: InsightSoftwareConsortium/ITK<EMAIL_ADDRESS>Date: Wednesday, April 17, 2019 at 7:43 PM
To<EMAIL_ADDRESS><EMAIL_ADDRESS>Cc: Hans Johnson<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [InsightSoftwareConsortium/ITK] itkImageMaskSpatialObject cause regisration failures post SO update (#694)
Can we close this issue? @hjmjohnson has reported that this is now working - the bug was related to a corner / unstable case / test.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.


npm test fails with naming collision

Repro steps:

git clone https://github.com/benoitvallon/react-native-nw-react-calculator
cd react-native-nw-react-calculator
npm install
npm install (again, per discussion in #3)
npm test

Actual results:
koi:✓:react-native-nw-react-calculator>> npm test

><EMAIL_ADDRESS>test /Users/whitley/src/3p/react-native-nw-react-calculator
> jest

Using Jest CLI v0.9.0, jasmine2

Error: Failed to build DependencyGraph: @providesModule naming collision:
  Duplicate module name: xhrSimpleDataSerializer
  Paths: /Users/whitley/src/3p/react-native-nw-react-calculator/node_modules/react-native/node_modules/fbjs/lib/xhrSimpleDataSerializer.js collides with /Users/whitley/src/3p/react-native-nw-react-calculator/node_modules/flux/node_modules/fbjs/flow/include/xhrSimpleDataSerializer.js

This error is caused by a @providesModule declaration with the same name accross two different files.

This is most likely a setup or configuration issue. To resolve a module name collision, change or blacklist one of the offending modules. See http://facebook.github.io/jest/docs/api.html#config-modulepathignorepatterns-array-string
npm ERR! Test failed.  See above for more details.

I've tried to repro with both node v5.5.0 (npm v3.3.12) and node v5.7.0 (npm v3.6.0), with the same error each time.
FWIW, I ended up here after having similar naming collision errors plaguing my attempts to bring up jest-based tests in a new RN project I'm working on.  (BTW, thanks a LOT for including tests here.  Very few public RN projects seem to bother.)  I'm at a loss as to what could be causing this, aside from it being at least superficially related to facebook/react-native#3625 and facebook/react-native#3618.  But those have been hanging around for some time, meanwhile the discussion on issues and PRs here suggest that the tests have been running well for you and others.
Any ideas?

Yes, I know :) I am waiting for travis to finish the tests but it is already fixed. I will merge as soon as the tests will be finished.
Thanks for your issue.

@benoitvallon Wonderful, thanks!

The code is pushed


GatewayTimeout on ZeroSSL endpoint

I try to get new certificates but a problem occurs, I ran wacs with -test, verbose and base uri and here is the error
[DBUG] Scanning IIS site bindings for hosts
[VERB] 2514 named bindings found in IIS
[DBUG] Filtering by site(s) [919]
[VERB] 2 bindings remaining after site filter
[DBUG] Filtering by host: ^(domain)$
[VERB] 2 bindings remaining after host filter
[VERB] 2 matching bindings found
[DBUG] Scanning IIS sites
[INFO] Target generated using plugin IIS: domain and 1 alternatives
[DBUG] Scanning IIS site bindings for hosts
[VERB] 2514 named bindings found in IIS
[DBUG] Filtering by site(s) [919]
[VERB] 2 bindings remaining after site filter
[DBUG] Filtering by host: ^(domain)$
[VERB] 2 bindings remaining after host filter
[VERB] 2 matching bindings found
[DBUG] Scanning IIS sites
[VERB] Targeted convert into 1 order(s)
[VERB] Checking [IIS] Wee874, domain (+1 other)
[VERB] Handle order 1/1: Main
[VERB] Creating order for hosts: [domain]
[VERB] Loading ACME account signer...
[DBUG] Loading signer from C:\ProgramData\win-acme\acme.zerossl.comv2DV90\Signer_v2
[VERB] Constructing ACME protocol client...
[DBUG] Send GET request to https://acme.zerossl.com/v2/directory
[VERB] Request completed with status GatewayTimeout
[DBUG] Send GET request to https://acme.zerossl.com/v2/DV90
[VERB] Request completed with status GatewayTimeout
[EROR] Failed to create order: Unexpected response status code [GatewayTimeout] for [GetDirectoryAsync]

Having the same issue with a few of our machines. I have managed to successfully renew a couple of our certificates after forcing the renwal in win-acme maybe 10 or so times, only having this issue with ZeroSSL it seems, we have another machine using the same version of win-acme but pointing to LetsEncrypt and it's working fine.
Have also included our verbose log below but I suspect this may be an issue with the ZeroSSL API itself.
Version: <IP_ADDRESS>5 (release, pluggable, standalone, 64-bit)
 [DBUG] Scanning IIS bindings for hosts
 [VERB] 275 named bindings found in IIS
 [DBUG] Filtering based on binding type
 [DBUG] Filtering by site(s) [40]
 [VERB] 2 bindings remaining after site filter
 [VERB] No host filter applied
 [VERB] 2 matching bindings found
 [DBUG] Scanning IIS sites
 [VERB] Adding <IP_ADDRESS> as DNS server
 [VERB] Adding <IP_ADDRESS> as DNS server
 [VERB] Adding <IP_ADDRESS> as DNS server
 [VERB] Targeted convert into 1 order(s)
 [INFO] Force renewing certificate [REDACTED], (any host)
 [VERB] Handle order 1/1: Main
 [VERB] No existing order found
 [VERB] Creating order for hosts: ["DnsName: [REDACTED]", "DnsName: [REDACTED]"]
 [VERB] Constructing ACME protocol client...
 [VERB] Getting service directory...
 [DBUG] Send GET to https://acme.zerossl.com/v2/directory
 [VERB] Request completed with status GatewayTimeout
 [DBUG] Send GET to https://acme.zerossl.com/v2/DV90
 [VERB] Request completed with status GatewayTimeout
 [EROR] Failed to create order: Unexpected response status code [GatewayTimeout] for [GetDirectoryAsync]
 [EROR] Renewal for [REDACTED], (any host) failed, will retry on next run

Yeah we've seen this with Certify The Web as well and I think some acme.sh users see it as well. I pinged ZeroSSL via twitter but no response. I think they're just struggling to cope with the load on their API. They're also the ACME service I would most predict will eventually charge a fee for ACME certs (and things like this will make that happen sooner).

I put a support request in with ZeroSSL yesterday and got a response today, they're aware of the issue and looking to try and get something in place.
`Thank you for reaching out.
Please note that in the last couple of days we have been experiencing issues with our ACME services. We are working on a solution with our Technical team and hope to have this resolved in the new future.
We apologize from our side for the current experience you are having with ZeroSSL.
`


Policy on adding functionality to tradingAPI?

What is your take on adding methods to the tradingAPI interface. I have several bots running in  "record mode" that use API calls that are currently not supported. Example: getting all trades market wide. Now I have modified my trading API to support this function, but only have one exchange supporting the call at the moment. Would love to share this then have others potentially fill in exchanges that I don't use if this adheres to @gazbert policies. I will be adding more exchange support as I transition my bot onto more exchanges if that helps

Hey Josh, adding more meaningful methods is more than welcome! I started off with the bare-bones minimum in the Trading API to get people up and running fast... but as new requirements (like yours) come in, it should evolve... :-)
Ideally, any new ops added should potentially be 'implementable' by the existing adapters, so we can try and maintain a consistent expectation (for the user of the API) across multiple exchanges. Having said that, if there's a strong case for an op that, say, only 2/8 exchanges could only fulfil (due to limitations in the actual exchange API), we'll deal with each case on its merits.
Best approach would be to stick a default 'no-op' method on the TradingApi interface for any new stuff you add. That way, the existing adapters will still build... until/if we get round to implementing the method. All new ops on the interface will need unit tests/integration tests/Javadoc/README user guide updates... zzzzzz, I know, but someone's gotta do it ;-)
At some point I was going to look at adding withdrawls to the API too.
As always, no rush for any of this stuff, just have fun coding :-)

I see, thanks for clearing that up. Ill put in some pull requests in soon.
Thanks man, I am having fun ahah, I have a light last semester of college and this project is a similar stack to the one I got hired to work on next year. So its the perfect project for me to learn and have fun atm!
I have numerous other changes that have helped my bot become profitable that I would like to contribute as well, so Ill put those in as pull requests and you can add them per your ideas about how the bot should work :)
Also I am having trouble adding MongoDB to Gradel/Marven such that it builds. I have it working via Intellij's built in adding library functionality (but of course that wont build to place on my linux VM's). Do you have any tips on how to accomplish this the way you have this project setup. I have tried various solutions online, but I could not get anything operational.
Best,
Joshua

Closing - see https://github.com/gazbert/bxbot/blob/master/CONTRIBUTING.md


normalize dependency missing for npm3

NPM3 doesn't automatically resolve peer dependencies. Should either package the dep or not explicitly require it to be in the package.

Maybe latest isn't published to npm?

yeah my bad. Could you publish latest to npm please?

derp yep sorry, fixed in https://github.com/seaneking/postcss-normalize/commit/2c1af7f387d554aae5f991d4a583cb53afd8a501


feature/cluster : add default clustering feature

Why payload is converted into a string in HazelcastMsg ?
And if this is necessary, maybe it's better to specify the charset
this.payload = new String(payload, "UTF-8");
as counterpart of
publishMessage.setPayload(ByteBuffer.wrap(msg.getMessageObject().getPayload().getBytes("UTF-8")));

well done @diegovisentin , payload can be byte array .

Is there any problem to merge this feature into the main branch?
(I hope that it's only a question of time)

No, I'm studying a little bit more Hazelcast to become confident with the
PR. One I've finished, I'll review and merge.
Andrea
On Fri, Jul 15, 2016 at 8:48 AM, diegovisentin<EMAIL_ADDRESS>wrote:

Is there any problem to merge this feature into the main branch?
(I hope that it's only a question of time)
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/andsel/moquette/pull/186#issuecomment-232875928, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AA_Y0bp8eeiEG_rhbXoCeVXr3wTqqotGks5qVy1GgaJpZM4JAOx6
.

I gave a look  at PR and as a first step it's good. It's just a forwarder of the publishes, at the moment miss all the part of replication of sessions, replication of the message store and the join/disjoin of the members to the cluster; but these are stuff that has to be worked out with time.
Before merge I ask if someone could the fix the test io.moquette.server.ServerIntegrationHazelcastHandlerInterceptorTest, it fail as reported by the TravisCI.
Thanks
Andrea

@mackristof regarding the failing test. I debugged your unit test and I found out as when the cluster replicates the messages over all the instances, it also replicates the message, multiplied by the amount of Moquette server instances connected to the cluster, into the BlockingQueue of the MessageCollector object.
In the screen below I added two more objects that will just poll the queue. In the variable dialog you will see the content of these new objects.

To be sure of what I'm saying, I added another instance to the cluster and as expected, the message is multiplied in the queue by the amount of instances connected with the cluster.

A fix would be to poll the published message twice (or the amount of instances you've connected to the cluster) and then the test would pass.
I hope this will help you out!

I'm looking at this, seems like there is some interference on storage, probably the 2 broker instances share the same data storage files.


do not regenerate packages on every deployment

Hello,
Using this plugin, it will regenerate packages for every deployment, meaning loss of time whereas they change not often.
How should I do to skip this and doing it only for instance when I want it to be forced (or ideally if something has changed) ?
Thanks

is there a boolean which could be sent as a parameter to deactivate the plugin ?

I believe you could use cache in order to not download the packages but use cache instead - disabling plugin would most likely break your deployments.


add ipfs to the extras bucket

Thank you for this. Can I interest you in adding some autoupdate functionality too?

yes i can just how do i test the autoupdate regex?

Decrement the version and run ./bin/checkver.ps1 -u ipfs


console commands for siren spawn

There should be a console command for siren spawn and global state changes. This could be useful fpr trigger pugins to push events to the sirens.

Activate/Deactivae (Set state) of all sirens
Switch all siren to a specific config
Attach/Detach all sirens

Impemented global attaching (with override)  and global detaching. Global state change is still a thing


Jersey media multipart exceptions in 0.8.0-rc3

jersey-media-multipart artifact is throwing exceptions in 0.8.0-rc3-SNAPSHOT, previously functional in 0.8.0-rc2.
pom.xml
<dependency>
    <groupId>org.glassfish.jersey.media</groupId>
    <artifactId>jersey-media-multipart</artifactId>
    <version>2.15</version>
</dependency>

Application.java
import org.glassfish.jersey.media.multipart.MultiPartFeature;

environment.jersey().register(MultiPartFeature.class);

Throws:
org.glassfish.jersey.internal.Errors: The following warnings have been detected: WARNING: HK2 service reification failed for [org.glassfish.jersey.server.internal.inject.MultivaluedParameterExtractorFactory]

org.glassfish.hk2.api.UnsatisfiedDependencyException: There was no object available for injection at SystemInjecteeImpl(requiredType=MultivaluedParameterExtractorProvider,parent=CookieParamValueFactoryProvider,qualifiers={},position=0,optional=false,self=false,unqualified=null,553299831)
java.lang.IllegalArgumentException: While attempting to resolve the dependencies of org.glassfish.jersey.server.internal.inject.CookieParamValueFactoryProvider errors were found
java.lang.IllegalStateException: Unable to perform operation: resolve on org.glassfish.jersey.server.internal.inject.CookieParamValueFactoryProvider

I can reproduce this one. It's probably due to a jersey version mismatch between dropwizard and your explicit dependency on jersey-media-multipart.
Replacing the jersey-media-multipart dependency in your pom with the new dropwizard-forms module and replacing environment.jersey().register(MultiPartFeature.class) with bootstrap.addBundle(new MultiPartBundle()); as described on https://github.com/dropwizard/dropwizard/blob/master/docs/source/manual/forms.rst should do the trick.

@jasonsturges Dropwizard 0.8.0-rc3 is using Jersey 2.16. Please use either the correct version of jersey-media-multipart or dropwizard-forms, as described by @Athou, which implicitly imports the correct version.

Excellent - thank you.  Looking forward to dropwizard-forms availability on Maven.

dropwizard-forms 0.8.0-rc3 should already be on Maven Central: http://search.maven.org/#artifactdetails|io.dropwizard|dropwizard-forms|0.8.0-rc3|jar


I get this error. Please help me.

ReferenceError: Error #1069: Property layerDepthEnabled not found on ana2 and there is no default value.
at privatePkg::Camera/cameraControl()[C:\Program Files\Adobe\Adobe Animate CC 2018\Common\Configuration\Camera\Flash\privatePkg_Camera_.as:520]
at runtime::ContentPlayer/loadInitialContent()
at runtime::ContentPlayer/playRawContent()
at runtime::ContentPlayer/playContent()
at runtime::AppRunner/run()
at ADLAppEntry/run()
at global/runtime::ADLEntry()

Attempting to launch and connect to Player using URL D:/CALISMALARINTUMU/androidoyunlarimiz/SERVICES/GooglePlayServices-freshplanet/deneme-app.xml
Debug session terminated.
The content cannot be loaded because there was a problem loading an extension: Error: Duplicate platform iPhone-ARM found for extension com.freshplanet.AirGooglePlayGamesService


MailChimp Link

[ ] Create Mailing List on Event Create
[ ] Add Registrations to List
[ ] Add Merge Field to List
[ ] Add Registrations to Merge Field
[ ] New Event Email

The following points will not be implemented.

Add Merge Field to List
Add Registrations to Merge Field
New Event Email

Moved to https://github.com/Moridrin/ssv-mailchimp/issues/2 and https://github.com/Moridrin/ssv-mailchimp/issues/1


Update brew cask

Homebrew not support brew cask upgrade.
So I find to problem how to solve.
Finally i found solution.
This
This gist is assume
(set -x; brew update;)

(set -x; brew cleanup;)
(set -x; brew cask cleanup;)

red=`tput setaf 1`
green=`tput setaf 2`
reset=`tput sgr0`

casks=( $(brew cask list) )

for cask in ${casks[@]}
do
    version=$(brew cask info $cask | sed -n "s/$cask:\ \(.*\)/\1/p")
    installed=$(find "/usr/local/Caskroom/$cask" -type d -maxdepth 1 -maxdepth 1 -name "$version")

    if [[ -z $installed ]]; then
        echo "${red}${cask}${reset} requires ${red}update${reset}."
        (set -x; brew cask uninstall $cask --force;)
        (set -x; brew cask install $cask --force;)
    else
        echo "${red}${cask}${reset} is ${green}up-to-date${reset}."
    fi
done

Include this feature into next release.

This feature pending

I think this feature unnecessary.
Close.


[Here's how To WatcH] Chelsea vs Tottenham 𝐋𝐢𝐯𝐞 𝐅𝐫𝐞𝐞 𝐒𝐭𝐫𝐞𝐚𝐦 𝚁eddiT?

Tottenham vs Chelsea LIVE! Premier League match stream, latest team news, lineups, TV, prediction
London rivals meet in huge clash at the Tottenham Hotspur Stadium
👉𝗧𝗼𝘁𝘁𝗲𝗻𝗵𝗮𝗺 𝘃𝘀 𝗖𝗵𝗲𝗹𝘀𝗲𝗮 𝐋𝐢𝐯𝐞 𝐒𝐭𝐫𝐞𝐚𝐦
👉Premier League Match Stream
👉𝗧𝗼𝘁𝘁𝗲𝗻𝗵𝗮𝗺 𝘃𝘀 𝗖𝗵𝗲𝗹𝘀𝗲𝗮 𝐋𝐢𝐯𝐞 𝐒𝐭𝐫𝐞𝐚𝐦
Two London rivals in contrasting form meet in a huge Premier League clash at the Tottenham Hotspur Stadium. Spurs are in desperate search of a positive result after a poor run that led to Ange Postecoglou being abused by unhappy away fans after Thursday’s limp 1-0 defeat at Bournemouth. Chelsea on the other hand are flying under Enzo Maresca and can move to within four points of leaders Liverpool with a win after the Merseyside derby was postponed on Saturday.
Enzo Maresca continues to insist the Blues are not title contenders but victory at Spurs would only fuel belief about what they can achieve this season. Spurs kick off down in 11th place and all eyes will be on Postecoglou amid fresh questions over their progress
The corresponding fixture last season was one of the most chaotic games in Premier League history as Nicolas Jackson scored a hat-trick to help give Chelsea a 4-1 win against nine-man Spurs. Follow the game LIVE below with our dedicated match blog, featuring expert insight and analysis from Dan Kilpatrick and Malik Ouzia at the ground.
Tottenham v Chelsea latest
Kick-off 4.30pm GMT | Tottenham Hotspur Stadium
How to watch: Sky Sports
Tottenham team news
Chelsea team news
Prediction
Live updates
Tottenham vs Chelsea latest odds
Tottenham to win: 21/10
Draw: 29/10
Chelsea to win: 11/10
Tottenham vs Chelsea latest odds
Tottenham to win: 21/10
Draw: 29/10
Chelsea to win: 11/10
Odds via Betfair and subject to change.
Head to head history and results
Tottenham wins: 56
Draws: 42
Chelsea wins: 79
It’s difficult to know what to make of Spurs, who have tended to raise their level in the biggest games this season.
Still, Chelsea are looking the much more consistent.
Chelsea team news
Enzo Maresca has some big selection calls to make.
Maresca made a surprising seven changes for Wednesday’s trip to Southampton but watched his much-changed team emerge with a comfortable 5-1 victory.
That included a first Premier League start for goalkeeper Filip Jorgensen, who has impressed in the Conference League, but Maresca confirmed immediately that Robert Sanchez remains his first-choice and will start against Spurs.
Nicolas Jackson, Pedro Neto, Levi Colwill and Romeo Lavia are also expected to return to the side, but the big win at St Mary’s has given Maresca a nice headache.
The Blues will remain without defenders Reece James and Wesley Fofana because of hamstring problems, while Mykhailo Mudryk is still struggling with illness.
👉𝗧𝗼𝘁𝘁𝗲𝗻𝗵𝗮𝗺 𝘃𝘀 𝗖𝗵𝗲𝗹𝘀𝗲𝗮 𝐋𝐢𝐯𝐞 𝐒𝐭𝐫𝐞𝐚𝐦
👉Premier League Match Stream
👉𝗧𝗼𝘁𝘁𝗲𝗻𝗵𝗮𝗺 𝘃𝘀 𝗖𝗵𝗲𝗹𝘀𝗲𝗮 𝐋𝐢𝐯𝐞 𝐒𝐭𝐫𝐞𝐚𝐦
Tottenham team news
Tottenham hope Cristian Romero will be fit to return from injury.
Romero has not played for Spurs for a month and they desperately need him to return to action after Ben Davies was their latest defender to succumb to a hamstring injury in Thursday's defeat at Bournemouth.
If the Argentine does not feel able to play, teenager Archie Gray is likely to fill-in at centre-half alongside Radu Dragusin.
Micky van de Ven is getting closer to full fitness and working outdoors but is not expected to face the Blues.


add optional callback onSetActive, called when active Scroll Link is set

Hi fisshy - thanks for the library! It's quite useful.
Currently, when you scroll to a Scroll Element, the corresponding Scroll Link  tag is given the class "active". However, I've run into a couple scenarios now where, due to my CSS/HTML structure, the parent element of the link (usually a LI tag) needs to get the "active" class, not the link itself. In particular, the nav in Bootstrap expects the LI, not the A, to be "active" in order to render correctly.
So I've added a simple hook which allows you to define an onSetActive callback on Scroll Link components. This way, when the link becomes active, I can respond to it in the parent component and add the "active" class to the proper parent. I'm sure it has other uses too.
Hope it's helpful! Thanks,
-d

Hey man, I'm glad you like it.
Thanks for the PR! Will have some time tonight to check it!

Merged!


fieldUpload not setting id attribute correctly

Setting the id property in the schema for field type: "upload" results in markup that looks like:
<input id="getFieldID(schema)"
     type="file"
     accept=".jpg,.jpeg,.png,.pdf"
     required="required" class="form-control">

Comparing it to other core field files, it looks like in fieldUpload.vue the id prop is missing a colon, here.
Could be an easy/quick fix :)

@jewbetcha this PR should solve the problem - thanks.

@zoul0813 any estimate on a release date for this fix?

@jewbetcha you can use it now, just have npm reference the github repo's master branch instead of the npm package.
I believe @icebob will be releasing a new version to npmjs soon though.
In case you need it, here's how I reference VFG in my project:
  "devDependencies": {
    ... snipped
    "vue-form-generator": "git+https://github.com/zoul0813/vue-form-generator.git#develop",
  }

You would likely want to use git+https://github.com/vue-generators/vue-form-generator.git#master
Doing this, will allow you to keep up to date with the latest changes in the master branch and not wait for an npm package update ... I'd recommend only doing this during development, and to lock your production code to a specific npmjs release (or git tag/commit).

Okay great. Thank you!

I tried this, but ran into a multitude of babel/webpack errors. My project is on @babel 7.x and it looks like that and the associated plugins aren't cooperating with VFG from git. Hopefully @icebob will want to release soon :+1:

Released in v2.2.1

@icebob awesome!


windows: bump JDK11 x86 build to use VS2019

We recently bumped x64 build to VS2019, this PR adds x86 so that we're consistent again
Also removed some old JDK9 and JDK10 if statements.
Test build: https://ci.adoptopenjdk.net/job/build-scripts/job/jobs/job/jdk11u/job/jdk11u-windows-x86-32-temurin/141/

Marked as draft as build failed so needs investigation


add shift to eda

Description of changes:
I have added shift to eda via XShiftDetector analysis and XShiftSummary visualization.

Notebooks should not be checked-in with the rest of the code


[SPARK-41542][CONNECT][TESTS] Set parallelism as 1 for coverage report in Spark Connect

What changes were proposed in this pull request?
This PR proposes to set parallelism as 1 for coverage report in Spark Connect. Currently, the coverage report consistently fails for Spark Connect, see https://github.com/apache/spark/actions/runs/3663716955/jobs/6193686439
Why are the changes needed?
To make Spark Connect build working (Spark Connect requires 1 parallelism). Note that this is consistent with our PR builder,  see
https://github.com/apache/spark/blob/919e556d182f86b3e1e22cd05a546e0f2fc3e307/.github/workflows/build_and_test.yml#L405
Does this PR introduce any user-facing change?
No, dev-only.
How was this patch tested?
Will monitor the jobs and https://app.codecov.io/gh/apache/sparkafter merging this.

cc @zhengruifeng @amaliujia @grundprinzip FYI


Fix: overlay umount error by mountpoint

Signed-off-by: tgfree<EMAIL_ADDRESS>
Describe what this PR does / why we need it
Umount the tmp overlay device by device path not mountpoint.
In the sealer (<=v0.8.6), sealer prune will prune build-tmp-data by umount and remove, but umount overlay type monuntpoint will failed. maybe we should just umount the device name not mountpoint.
I find out, in the master branch, the command prune has dropped. should i fix in the 0.8.6?
Does this pull request fix one issue?
try to fix #1697

Describe how you did it
Describe how to verify it
Special notes for reviews

Codecov Report
Base: 18.41% // Head: 18.40% // Decreases project coverage by -0.00% :warning:

Coverage data is based on head (b80b63e) compared to base (7f76157).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1698      +/-   ##
==========================================
- Coverage   18.41%   18.40%   -0.01%
==========================================
  Files          66       66
  Lines        5354     5356       +2
==========================================
  Hits          986      986
- Misses       4242     4244       +2
  Partials      126      126

Impacted Files
Coverage Δ

utils/mount/mount_service.go
0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

@tgfree7 For the version newer than 0.8.6. We discard the original db for layer and image.
We implement transactions about image based on buildah.
You can check imageengine out.
And could you please help us improve the prune(by invoking the function of buildah)?
The test image is registry.cn-qingdao.aliyuncs.com/sealer-io/kubernetes:v1.19.8.test
And you can also build some local image on your own to test prune.

@tgfree7 For the version newer than 0.8.6. We discard the original db for layer and image. We implement transactions about image based on buildah. You can check imageengine out. And could you please help us improve the prune(by invoking the function of buildah)? The test image is registry.cn-qingdao.aliyuncs.com/sealer-io/kubernetes:v1.19.8.test And you can also build some local image on your own to test prune.

ok,  i will check the imageengine out, and try to improve the prune.

@tgfree7
I checked the caller. And I found we retrive the mount info by "mount".
And I think there are some libraries supporting that ability.
I found this lib mountinfo, But I'm not so sure.
Could you help make it better? I really appreciate it.

@tgfree7 prune can be completed in another pr.

@tgfree7 I checked the caller. And I found we retrive the mount info by "mount". And I think there are some libraries supporting that ability. I found this lib mountinfo, But I'm not so sure. Could you help make it better? I really appreciate it.

i will the lib act as expected.

@tgfree7 I checked the caller. And I found we retrive the mount info by "mount". And I think there are some libraries supporting that ability. I found this lib mountinfo, But I'm not so sure. Could you help make it better? I really appreciate it.

the lib mountinfo can do :

check a specified path is mountpoint or not;
list all mounts for a base path(like /var/lib/sealer/tmp/);

But can not return the mountinfo in sealer-style(show the lower,upper dir), still need a func like mountCmdResultSplit to get overlay info

@tgfree7
Ok, let's keep the current way processing it.
I'm prefer to use regular expression to handle the string.
For example:
overlay on /home/ecs-assist-user/test/merged type overlay (rw,relatime,lowerdir=lower:lower2/,upperdir=upper,workdir=work)

workdir=[^,)]+
lowerdir=[^,)]+
upperdir=[^,)]+

maybe we can try to use mountinfo.GetMounts(mountinfo.PrefixFilter(dir)) to list correct mountpoints
and get info (need regular expression to handle the string) by mountinfo.GetMounts(mountinfo.SingleEntryFilter("$base_dir"))?
in this way, func GetMounts can filter the mountpoints.
Is it worth to import a package?

maybe we can try to use mountinfo.GetMounts(mountinfo.PrefixFilter(dir)) to list correct mountpoints and get info (need regular expression to handle the string) by mountinfo.GetMounts(mountinfo.SingleEntryFilter("$base_dir"))? in this way, func GetMounts can filter the mountpoints. Is it worth to import a package?

IMO, It's worthy.

maybe we can try to use mountinfo.GetMounts(mountinfo.PrefixFilter(dir)) to list correct mountpoints and get info (need regular expression to handle the string) by mountinfo.GetMounts(mountinfo.SingleEntryFilter("$base_dir"))? in this way, func GetMounts can filter the mountpoints. Is it worth to import a package?

IMO, It's worthy.

ok

@tgfree7 Do you test this?

@tgfree7 Do you test this?

i test this on version 0.8.6

@tgfree7
Could you help check the main branch.
We currently will use buildah to build image.
In this way, it will generate lots of intermediate image, and buildah containers.
I think we could implement prune to remove the intermediate images and buildah containers.
You can install buildah to list all images to find the intermediate images and buildah containers.

@tgfree7 Could you help check the main branch. We currently will use buildah to build image. In this way, it will generate lots of intermediate image, and buildah containers. I think we could implement prune to remove the intermediate images and buildah containers. You can install buildah to list all images to find the intermediate images and buildah containers.

OK this will be in the next pr.


How to handle with network error like 404

Hello,
I was trying do something like errorWidget or errorBuilder in AvifImage.network but can't find any function like these.
Wondering how to handle that if network occur error or there's no image in url.
Thank you!!!

Hello, I tried to mimic the Image class api as close as possible but I am not really sure why I didn't add the errorBuilder property. I will definitely add it to the next release.

Hi @yekeskin , great work!  I am having this issue.  Even with the error builder, it still throws an error.  Could we silence the error?

If you are running in debug mode it is normal that it throws the error as it follows the behaviour of Flutter Image widget. You can try this example to see that the Image widget acts the same way in debug mode. But it shouldn't happen in release mode. So can you try again in release mode to see if it works?

ok! You've done great man, what a plugin! I don't know how people figure
this stuff out.  I was so happy, because AVIF is just a great image format
and you've really outdone yourself to get it working for the rest of us.
Cheers!
On Thu, Nov 9, 2023 at 5:21 AM Yunus Emre Keskin @.***>
wrote:

If you are running in debug mode it is normal that it throws the error as
it follows the behaviour of Flutter Image widget. You can try this
https://api.flutter.dev/flutter/widgets/Image/errorBuilder.html example
to see that the Image widget acts the same way in debug mode. But it
shouldn't happen in release mode. So can you try again in release mode to
see if it works?
—
Reply to this email directly, view it on GitHub
https://github.com/yekeskin/flutter_avif/issues/8#issuecomment-1802698564,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AB3KIKGNENVMFFCRRQLU3GLYDPZUJAVCNFSM6AAAAAAUQC7M4WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMBSGY4TQNJWGQ
.
You are receiving this because you commented.Message ID:
@.***>

Thanks.

Ok it definitely says "Exception caught by image resource service" when I turn off debugging the framework as well.  I would suggest not letting it throw any errors, but that's up to you.  I just think it's annoying lol.  Great work!


HELM-147: wrap log/description/operinst

This patch also does a couple of other small layout cleanups while I was in this code.

make the modal dynamically re-size itself vertically (previously, it would set the max height at popup time, but then if the window was resized, it wouldn't adjust)
make the "severity" row in the details view colorized
fix the JSON tab to not waste extra space and do nicer scroll bar boundaries

those attributes should have gotten removed from the top of the details page, I think you got the merge backwards... I'll check it tomorrow


On/Off hard switch for WSL to optimize win10 for other functions

WSL with docker desktop and kubernetes is amazing but ends up taking too much memory. There are workarounds to restrict the memory space allowed by wsl but somewhere among wsl,docker for desktop and it's kubernetes, there is something always taking too much memory space. If the host (Windows 10) is shared with other non-dev purposes then this becomes a problem.
Even after a wsl --shutdown the vmmem process still recovers with a minimum of 250MB usage. If the docker for desktop is active, then if it manages to reload kubernetes then it jumps to almost 3GB.
Describe the solution you'd like
There should be an on/off switch for WSL service. As great as it is, with this behavior it acts more of a memory hog that can retrieved without some hard actions. A host has multiple purposes. Like with gaming optimizations we should be able to choose when this combo runs and when not to optimize for the other purposes when necessary.
I think we all understand the amazing accomplishment of WSL and especially version 2 and that memory management could be leaky or non-recoverable and this is why a hard switch is necessary.
I also think that if this switch has an API, docker desktop could leverage to monitor and act accordingly.
Describe alternatives you've considered
At this moment, the only way to get it to a reasonable memory usage is to disable kubernetes from docker desktop and then wsl --shutdown to make sure the memory cleans up because otherwise the vmmem isn't releasing the memory.

+1. Came here to essentially post the same thing. With mandated WFH and me getting increasingly frustrated with RDP'ing into my workstation, I've opted for installing my dev workflow in my personal gaming/gamedev box. Relinquishing 6GB to vmmem in the name of wsl2/docker/k8s with no other choice but to restart my PC if I want it back gets tedious fast.


fix: remove redundant console.log

Fixes https://github.com/vuejs/devtools/issues/1567

Please merge asap. This is painful.

it hurts me please merge it

I'm not a maintainer in this repo so we have to wait for someone from the core team (@Akryum) to merge this.
I'm also affected by this so I share your frustration but please refrain from commenting here unless you're reviewing this PR. Thanks

We need a new tag for this to finally get rid of the debug output, right?

This is causing my browser to crush. can you please make a release for this?


Simplify failure data for request/send money and make it more consistent with SplitBill

@youssef-lr please review
cc @luacmartins
Details
We shouldn't need to use a generic error message for failure data for the request money / send money flow when creating a New Chat, just like split bill. Otherwise, it will just be redundant with the error sent by the API. Thus, make the failure data match what we do with Split Bill.
Fixed Issues
$ https://github.com/Expensify/App/issues/15933
Tests/QA

In the main testing device - Disable the internet connection
As the secondary user - Start a conversation with the user from the main testing device, send some messages
In the main testing device - click on the global create + Request money
Follow the prompts send IOU to the secondary user
Verify the IOU Preview and message appear greyed out
Enable the internet connection in the main testing
Verify you see a solid red dot on the chat row of the report that failed to create
Make sure there is no "Unexpected error" below the IOU
Click/tap the X to dismiss the error message at the top of the report
Make sure that the report goes away as well as from the LHN

Do the same as above for the "Send Money" flow.

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

(This is not a UI flow so I didn't include screenshots on the other platforms)

@mananjadhav @alex-mechler One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@yuwenmemon I am currently testing the flow. While everything as per the steps in the flow works. I can't help but notice, the amount is blank when I move from offline to online on the main testing device. When I am offline the amount shows up just fine and then when I switch it changes to a green tick. Is that expected here?

Attaching the video of the flow:
https://user-images.githubusercontent.com/3069065/235979278-d003ca0e-4872-4679-8ea1-51a197e234ae.mov

Oh curious, I wasn't seeing that in my tests let me take a look.

Hmmm... Yeah, I can't seem to be able to reproduce. What steps are you using to get to that?
https://user-images.githubusercontent.com/4741899/236074085-4424163f-8280-4a46-b1d5-5196b8b0aa53.mp4

Reviewer Checklist

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR

[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I checked that screenshots or videos are included for tests on all platforms
[x] I included screenshots or videos for tests on all platforms
[x] I verified tests pass on all platforms & I tested again on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web
https://user-images.githubusercontent.com/3069065/236577658-12a0549d-4da9-4ca0-9d45-5a677c94f105.mov

Mobile Web - Chrome
https://user-images.githubusercontent.com/3069065/236577677-118cb618-0389-4870-b251-95a80ee78899.mov

Mobile Web - Safari
https://user-images.githubusercontent.com/3069065/236577702-248469c6-adb7-48ad-a034-486cc36a8c08.mov

Desktop
https://user-images.githubusercontent.com/3069065/236577717-ae41398b-d73e-460b-a652-10172db6eefd.mov

iOS
https://user-images.githubusercontent.com/3069065/236577730-45725ec4-559b-4cc6-9e2c-e3fff0e6c1c6.mov

Android
https://user-images.githubusercontent.com/3069065/236577773-ed9ea3dc-a6ce-4da1-979f-6a97792e0298.mov

@yuwenmemon Now since today I am no longer able to reproduce the issue I reported. Hence, I've tested and completed the checklist.
@luacmartins @youssef-lr All yours.

@yuwenmemon I just saw we've got merge conflicts. Can you please resolve it? I'll do one final round of testing then.

@yuwenmemon some tests are failing

Actually, only some of the tests are known failures. Looks like the IOU test failures are related to this

Updated! Tests are passing now!

Merging since Alex and Manan had previously approved and we only fixed the failing tests on the last commit.

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/luacmartins in version: 1.3.13-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

Hey there! Is this a regression of this PR? https://github.com/Expensify/App/issues/18852


Extension of the OpenLayers definitions, implemented ol.easing, ol.format.geojson, ol.geometry.Geometry, ol.coordinate and ol.extent

Extended the openlayers definitions with some additional classes, and also includes already the tests per function. In addition to the earlier commit, several classes are also more strictly specified now and most of the 'any' attributes are removed from the definitions.

@woutergd Thanks mate!


SM2Engine support C1C3C2 Mode

Hello:
I use SM2Engine to encrypt data, but BC only support C1C2C3 mode, the newest standard is C1C3C2，so I wish BC can be support.
you can see:
https://github.com/looly/hutool/blob/v4-master/hutool-crypto/src/main/java/cn/hutool/crypto/asymmetric/SM2Engine.java

Thanks, I've made the changes.
One last thing, line 269 of the above link should read "if (encData[i] != in[inOff + i]) {".

thks


Refactor tooltips

More generic tooltips to avoid having to customize all the different options.
Location class.

partially completed. Will redo when updating entire sheet.


Branch of fork repo redirect is undefined

Description
The sameViewUrl.branch is undefined when calling await getDefaultBranch(forkedRepository) @ function getEquivalentURL.
This only happened in sub-fork repo (For example, a fork of a fork)

Please look at left bottom, the path of the branch is undefined

I've look through the code and found out that problem, but I'm still unsure if that's the right place that cause this undefined

How to replicate the issue + URL
Example url:
https://github.com/01101sam/node-proxy-agent
|- https://github.com/bonald/node-https-proxy-agent
  |- https://github.com/orihamama/node-https-proxy-agent

Reproduce: Just hold your mouse at the same place that last screenshot shows, and click.

Expected: You'll get redirected to parant repo.
Got: 404 path (But the repo is still there as shown in the following screenshot)

Extension version
23.2.5
Browser(s) used
Chrome

I don't see the bug on the page https://github.com/01101sam/node-proxy-agent

I don't see the bug on the page 01101sam/node-proxy-agent
Even on this page: 01101sam/node-proxy-agent@master/src The link points to bonald/node-https-proxy-agent@master/src. On which page it points to orihamama/node-https-proxy-agent@master/src

Extra info: You have ensure the page is first accessed, or just simply enter the url to the tab.
Or refresh the page.

Already done after clearing the cache.
Can you clear the cache in the options page first? Either you have an outdated cache or the repro requires visiting another page first

Already done after clearing the cache.
Can you clear the cache in the options page first? Either you have an outdated cache or the repro requires visiting another page first

This bug can still reproduce. And it also works at incognito mode without logging in.

You're right, I must have broken this in https://github.com/refined-github/refined-github/pull/6265, which isn't yet available in my browser (Safari).
I can reproduce in Chrome


Hive Advanced Tpcds fixes

Krystal & Abhishek,
Summary of the changes :
1. Disabled queries which are failing because of DRILL-4525
2. Now we no longer generate data using hive during data generation for tpcds sf100. The cluster is expected to have that data. I will upload it to AWS as well
3. Some hive table definition statements were still pointing to files instead of directories. Fixed them so that we will not hit any issues with hive 1.2
I got a clean Advanced run as well. Can one of you take a look?
Rahul

Looks good. +1
If you are planning to upload dataset to the drill-public Amazon S3 bucket, can you make sure (1) it is compressed and (2) update the README within the Advanced folder

+1 from me also.

Thanks abhishek and krystal


Code Editor window is too small

While playing around in the playground, I noticed that the developer experience could be improved if the code editor window was larger, or alternatively, could be resized. Only the red box can be typed in, in the following screenshot. Ideally (in my opinion) the entire left hand side would be a code editor and the inputs form was somewhere on the right.

+1 on this.
It might be worth considering to add a fullscreen button, similar to how cairovm.codes do it (screenshot attached).


Parsoid on Meza1-the-server returning HTTP error

Returning this error:
{"error":{"code":"0","info":"parsoidserver-http: HTTP 0","*":"See http://<private url>/wiki/api.php for API usage"}}

This is after a very choppy install, since several of the required packages were not initially installed. So it's possible that something did not configure properly, but unlikely since VE.sh ran without any issues. This is possibly a firewall issue with port 8000.

I thought this forum was going to solve this problem for us, because I thought maybe SELinux was causing the issue. Unfortunately it did not solve it. If we ever do have to wrangle SELinux then this may come in handy (particularly steps 12 to 16 from user Thomei).
https://www.centos.org/forums/viewtopic.php?f=47&t=53223

It's working now on the kmservices wiki. Basically the problem came down to in /etc/parsoid/api/localsettings.js we had:
parsoidConfig.serverPort = 443

In other places we were specifying port 8000, and I don't think we want to be using 443 since we'll want to use that for https access to the wiki eventually. So I changed the above to:
parsoidConfig.serverPort = 8000

Then I ran service parsoid restart and now it works. Additionally, I removed this line entirely (commented it out) and restarted the service and it also works. This is the config of the current Meza1 master branch, so this makes sense. Hopefully a fresh install will work without further configuration. Some other things I changed, which I don't think impacted this working, include:

making the root user run the parsoid service
make root own /etc/parsoid
run npm install again in the parsoid directory (I'm not sure if this installed additional packages)

I think this issue is mostly ready to close, but should be confirmed by doing another install attempt on Meza1-the-server.

Punting this down the road one version because we're still waiting on server access.

VE/Parsoid running well on Meza1.


Lambda and Connect CW Dashboard issue

Following deployment of the 9.1 code, the CW dashboards no longer function as expected. This appears to be down to a change when referring to the FunctionName within the Template.yaml.
To remediate we've rolled back to the previous Dashboard version, which fixes the issue.

@wilfgr-sanuk-aws Yes apologies for the breakage. we are aware and very soon we are getting latest 10.0.0 version, which should have the fix.

Created the PR with the contact center 10.0 release. This issue should be fixed in the V10.0

https://github.com/service-cloud-voice/ServiceCloudVoiceLambdas/pull/23/files

Closing this issue.


ListView items repainted randomly

When scrolling a list of image tiles, sometimes cached onscreen images get repainted just as new images come onscreen. This looks related to raster cache eviction.
Tracking issue for b/148277687.

Fixed in https://github.com/flutter/engine/pull/16434


Network version: NodeToNodeV_4

NodeToNodeV_4 extends NodeToNodeVersionData with InitiatorOnly flag.  This flag
is important in various scenarios:

running a node against one that can use duplex connections.
running an edge node (wallet)

Handshake is extended to return 'agreedOptions'.  For 'NodeToNode' we then
abuse it by allowing to escpe with existencial 'vData'.  This is because in
near future we will refactor the handshake which does not nead any more its
dependent type machinery.  Instead of it we can use version aware codec of
'NodeToNodeVersionData', which this PR introduces (together with tests).
Note that initiatorOnly flag will be enforced by the codec if the version is strictly lower than 'NodeToNodeV_4'.

I would expect that the responder would reply with the InitiatorOnly flag if it was offered.
Generally version negotiation with option negotiation would be:
Initiator sends a list of versions, where every version contains a list of options.
The responder picks one version, and possibly a more restrictive set of options.

What's the advantage of a list of options?  This is the same a a record with default values. Records are easier to operate with:   for example we could define a monoid instance which picks the more restrictive options - making the implementation of what you suggest cleaner.

I would expect that the responder would reply with the InitiatorOnly flag if it was offered.
Generally version negotiation with option negotiation would be:
Initiator sends a list of versions, where every version contains a list of options.
The responder picks one version, and possibly a more restrictive set of options.

What's the advantage of a list of options? This is the same a a record with default values. Records are easier to operate with: for example we could define a monoid instance which picks the more restrictive options - making the implementation of what you suggest cleaner.

When I mentioned lists it was at the CBOR encoding level.

When I mentioned lists it was at the CBOR encoding level.

I see; btw, that's how NodeToNodeVersionData are encoded in this PR.

@mrBliss @karknu convienced me to slightly change the meaning of the flag, and this PR no longer adds / removes supported versions, NodeToNodeV_4 will be used in #2200.  If in the meantime you'd like to use it for something else, just let me know.

@mrBliss @karknu convienced me to slightly change the meaning of the flag, and this PR no longer adds / removes supported versions, NodeToNodeV_4 will be used in #2200. If in the meantime you'd like to use it for something else, just let me know.

Ok. I will soonish need a new version for the Allegra era, I'll let you know.

There is still a commit called "Use NodeToNodeV_4 in consensus" in this PR. Can you please rename it, it will be very confusing if that ends up in master.

There is still a commit called "Use NodeToNodeV_4 in consensus" in this PR. Can you please rename it, it will be very confusing if that ends up in master.

@coot Actually, this entire PR is still about NodeToNodeV_4, which is not even part of it anymore. Can you rename the PR and update the description?

bors merge


Being able to add-remove Menu bar menu

Being able to add or remove a Menu bar menu.
Example
been able to remove the help menu

Use
Free up the menu space to be able to drag the vsCode window easier.

This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our documentation.
Happy Coding!

This somewhat also means fully customizable menu entries layout.
    Which might be negatable by a perfectly reasonable UI design that fits every case. (so no need for customizability)

This feature request has not yet received the 20 community upvotes it takes to make to our backlog. 10 days to go. To learn more about how we handle feature requests, please see our documentation.
Happy Coding!

:slightly_frowning_face: In the last 60 days, this feature request has received less than 20 community upvotes and we closed it. Still a big Thank You to you for taking the time to create this issue! To learn more about how we handle feature requests, please see our documentation.
Happy Coding!


fix(ci): fixed download-artifacts for kernel testing matrixes.

What type of PR is this?
/kind bug

Any specific area of the project related to this PR?
/area CI
Does this PR require a change in the driver versions?
What this PR does / why we need it:
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

NONE

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: FedeDP
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [FedeDP]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/milestone 0.14.0

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Andreagit97, FedeDP
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [Andreagit97,FedeDP]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

https://imgflip.com/i/81e4ob

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Andreagit97, FedeDP, leogr
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [Andreagit97,FedeDP,leogr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Free Bingo Blitz Credits 2024 Unused $$$ [Bingo Blitz Credits 2024

**_### Bingo Blitz Free Credits-Daily Gifts Link
(((Unused Codes)))Bingo blitz free credits 2024_**
=====================================
🔴👉 👉 CLICK HERE TO FREE GENERATOR < 🔴 >
Elevate your Bingo Blitz experience by learning how to use and redeem Bingo Blitz codes. Our latest video provides a quick guide on accessing the Bingo Blitz code redemption section and unlocking exciting rewards. Watch, redeem, and enhance your Bingo Blitz gameplay. Don't forget to subscribe for more gaming insights and code updates!
🔴👉 👉 CLICK HERE TO FREE GENERATOR < 🔴 >
🔴👉 👉 CLICK HERE TO FREE GENERATOR < 🔴 >
Thank You Viewers for continiously supporting us. All the tutorials on this Channel is made for education purpose only. We don't recommend users to give any kind of personal credentials to others. Lets Keep internet safe for everyone out of Spams. Lets build a better Gaming Community for all. Don't Forget to Subscribe our Channel.
Bingo Blitz is a fast-paced and exciting bingo game that takes players on a globe-trotting adventure.
With its captivating blend of bingo gameplay and city exploration, Bingo Blitz offers a unique and immersive gaming experience.
Hey, guys, welcome back to another tutorial. Today, we will show you how to unlock more credits and gems in the Bingo Blitz hack.
All you have to do is play the game as much as you can, and you will unlock the plug-in for the game. This Bingo Blitz mod will be on all devices, all you have to have is a good internet connection, and let the magic happen.
Thank you Bingo Blitz players, feel free to leave a like and subscribe for more similar content like this one. Cheers!


Zooming to bounds of points added.

I am getting an error when trying to zoom to the extents of the data I add.
var heat = L.heatLayer(data.features,cfg).addTo(map);
// Fit the map viewport to the bounds of the layers
map.fitBounds(heat.getBounds());

Instances of L.HeatLayer don't have a getBounds() method. Please read the documentation carefully to find out available methods.
Behaviour as expected, not a bug.


test, osutil: disable setting SIG_DFL on linux if built with cov tag

Was causing etcd to terminate before finishing writing its coverage profile.

lgtm

Codecov Report

Merging #8035 into master will increase coverage by 1.24%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #8035      +/-   ##
==========================================
+ Coverage   74.47%   75.71%   +1.24%
==========================================
  Files         340      341       +1
  Lines       26546    26547       +1
==========================================
+ Hits        19769    20100     +331
+ Misses       5321     4996     -325
+ Partials     1456     1451       -5

Impacted Files
Coverage Δ

pkg/osutil/signal_linux.go
0% <ø> (ø)
:arrow_up:

pkg/osutil/signal.go
100% <ø> (ø)

proxy/grpcproxy/register.go
69.44% <0%> (-11.12%)
:arrow_down:

clientv3/txn.go
96.36% <0%> (-3.64%)
:arrow_down:

etcdserver/api/v3rpc/lease.go
96.42% <0%> (-3.58%)
:arrow_down:

clientv3/concurrency/election.go
80% <0%> (-2.41%)
:arrow_down:

pkg/netutil/netutil.go
62.35% <0%> (-2.36%)
:arrow_down:

raft/node.go
90.17% <0%> (-2.24%)
:arrow_down:

lease/leasehttp/http.go
62.59% <0%> (-1.53%)
:arrow_down:

proxy/grpcproxy/lease.go
87.61% <0%> (-0.96%)
:arrow_down:

... and 29 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5fc664...88a3bb7. Read the comment docs.


Immediate close (crash) after Android app opens

Describe the bug
App opens successfully, but closes within 0 to 1 seconds.
To Reproduce
Steps to reproduce the behavior:

Select Helium App icon
Enter Pin or fingerprint
Application opens
Wait 0-1 seconds
App closes

Smartphone (please complete the following information):

Device: Pixel 5a
OS: Android 12 Build SP1A.210812.015
App Version: v3.8.0

Additional context
Sometimes I can tap Helium App settings before it crashes.

Please update to 3.8.2.

From: Greg Bernardo @.>
Sent: Wednesday, November 10, 2021 6:15:46 AM
To: helium/hotspot-app @.>
Cc: Subscribed @.***>
Subject: [helium/hotspot-app] Immediate close (crash) after Android app opens (Issue #1073)
Describe the bug
App opens successfully, but closes within 0 to 1 seconds.
To Reproduce
Steps to reproduce the behavior:

Select Helium App icon
Enter Pin or fingerprint
Application opens
Wait 0-1 seconds
App closes

Smartphone (please complete the following information):

Device: Pixel 5a
OS: Android 12 Build SP1A.210812.015
App Version: v3.8.0

Additional context
Sometimes I can tap Helium App settings before it crashes.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://github.com/helium/hotspot-app/issues/1073, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AETPRSWN6VG4ZDWI6IGJAYLULJ5BFANCNFSM5HYAE7AQ.
Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

This issue is resolved with an update to 3.8.2, closing.

Amazingly quick response! Thank you! It works as promised.


QL doesn't notify when CrateDB is locked due to less available memory

When the allocated available memory to CrateDB goes below 15%, CrateDB gets locked and QL doesn't give any errors.
Steps to reproduce the behavior:

Create a subscription from Context Borker to QL and wait till the allocated free disk is below 15%
CrateDB locks and QL don't give any errors

Expected behavior
QL should return "not processed or not updated" error code to subscription call

@ccsr thx, we will check

Hi @chicco785 @ccsr @c0c0n3 , I investigated on this issue and below are the error logs which i get while notifying request.

Please confirm and assign this issue to me if nobody is working on this Issue. Thank you :)

@daminichopra assigned!

closed by #346


JS: Port tooltips.coffee from coffeescript to ES6

Thanks for creating an issue! Please fill out this form so we can be sure to have all the information we need, and to minimize back and forth.

What are we trying to do?

We're porting our custom javascript to ES6! This ticket is to port over:
tooltips.coffee into app/src/javascript/tooltips.js

What feature or behavior is this required for?

Long term project health and maintainability, plus an opportunity to clean up some of our messes when we wrote this the first time.

How could we solve this issue? (Not knowing is okay!)

Rewrite the coffeescript in app/assets/ to be ES6 in app/javascript/src.

Anything else?

See #1679 for an example of this with the clinic_finders js.
If this winds up requiring adding dependencies or something, please hit me up in slack!

boopin onto this!

@rudietuesdays still on this?

this has an x-factor in it of its dependency on a bootstrap jquery function, tooltip(). Our bootstrap assets live in sprockets and this lives in webpack, so we either need to port over the tooltips stuff adhoc or wholesale move bootstrap to webpack. Prrrrobably we should do the latter but let's call this dead in the water for now, since operating out of sprockets isn't super painful.

this is solved as part of our nuking webpack


OpenAI response_format in chat completion body breaks observeOpenAI()

Adding response_format to a child OpenAI observation within a trace will cause the observability to fail. Uncomment the specified line to test.
Example adapted from the Get Started docs page
  const langfuse = new Langfuse();
  const openai = new OpenAI();

  const trace = langfuse.trace({ name: "country-poem-generator" });
  const span = trace.span({ name: "poem-span" });

  const poem = (
    await observeOpenAI(openai, {
      parent: span,
      generationName: "generate-poem",
    }).chat.completions.create({
      model: "gpt-3.5-turbo",
      messages: [
        {
          role: "system",
          content: "You are a poet. Create a haiku about this city.",
        },
        { role: "user", content: "France" },
      ],
      // Uncommenting the line below will break the Langfuse observability
      // OpenAI API will respond as desired
      // response_format: { type: "text" },
    })
  ).choices[0].message.content;

  console.log(poem)
  span.end();

Pfew, what a head scratcher; can confirm; latency / usage magically appeared after removing response_format

thanks for the +1 on this, we'll try to prioritize this soon


[ROOFLINE] Bug Fixes

This PR fixes two bugs in the Roofline code:

In the estimate_peak_bandwidth function, the threads argument (non-array) was not passed via specialize call;

In the estimate_peak_bandwidth function, the last dimensions of tensor B mismatch the tensor A. Changing from [threads, vec_width, 4] to [threads, 4, vec_width]. The current version adds cache misses and impacts the final kernel performance.

@tkonolige PTAL

I end up forgetting about the dimension mismatch over the TIR function. The last commit fixes that.


Dictionary as standalone HTML

Similar to ReadAlong Studio, it would be really neat if we could produce a basic dictionary that lives in a single file and does not require a horde of node_modules and a server to view.
I don't know if this is this is possible to do with a Modern Reactive Java Script Framework™ since one cannot do HTML5 routing, for instance, but it really doesn't need to be fancy, especially if a somewhat HTML/CSS-savvy user could style it to their liking.

I'm hesitant to support this because I think for anything other than a trivially small dictionary, the file size would be prohibitively large. I think I'd rather just continue supporting an easy way to deploy MTD (via GitHub Pages or Netlify + a starter repo). And the UIs should already both support downloading for offline use (following an initial connection to the site). Is there another use case I'm not thinking of here though?


chore: add shaded plugin maven to distribution

This PR adds the shaded maven plugin to distributions

duplicate of: https://github.com/gravitee-io/gravitee-access-management/pull/2490


Allow customising the Intro section via PageColor

Bug/issue #, if applicable: 107241548
Summary
Allows Documentation page Intro section background color to be customised on a per-page level, using the new @PageColor directive.
The color can be further changed from the pre-defined set of colors, using the theme-setttings.json file. For info on how to do that, chekc the Forum post
Dependencies

https://github.com/apple/swift-docc/pull/525

Testing
Steps:

Using docc from the dep PR, add @PageColor directive to a few pages of a docs of your choice
Assert that visiting those pages, the Intro sections have the corresponding page color.
Assert you can override those colors, using the theme-settings.json file, like explained in the Forum post.

Checklist
Make sure you check off the following items. If they cannot be completed, provide a reason.

[x] Added tests
[x] Ran npm test, and it succeeded
[x] Updated documentation if necessary

@swift-ci test

@swift-ci test


command line instructions for labeling a cluster won't work

I installed the setup to a new cluster called ocpmgt. It nicely has now ACM, ArgoCD and such. It is local-cluster for hub.
Then I created a new cluster and joined into ACM. I added manually label clusterGroup=region-one from ACM GUI. This had to be done due an error in instructions. If I am logged into management cluster as cluster admin, the instruction in managed-cluster.md fails:
▶ oc get region-one.cluster.open-cluster-management.io
error: the server doesn't have a resource type "region-one"

I confirm that https://validatedpatterns.io/patterns/multicloud-gitops/mcg-managed-cluster/ now has
oc get managedcluster.cluster.open-cluster-management.io

Should this issue be closed as resolved?


Workflows: Improve tpm part of test.yml name

What
Currently, jobs in test.yml are running following matrix:
  smoke:
    continue-on-error: true
    strategy:
      matrix:
        file_system: ['ext4', 'zfs']
        tpm: [true, false]

Which generates following name:
Smoke tests (ext4, false)
We want it to be something more meaningful like :
 Smoke tests (ext4, no-tpm)
How can we do that?
We can change tpm from boolean parameter to string and compare it to string throughout the test.yml.
Alternatively, if there's a way to change job names to
  smoke:
    continue-on-error: true
    strategy:
      matrix:
        file_system: ['ext4', 'zfs']
        tpm: [true, false]
    name: "Smoke tests ${{ matrix.file_system }} tpm-enabled : ${{ matrix.tpm }}

I prefer the latter, because it's less work and boolean comparison remains

@milan-zededa what are your thoughts on this?

What would the artifact name be like in the second case?

I would prefer the first option for the sake of better readability.

Well, at least I tried :smiling_face_with_tear:


Generate docs in html or at least make the current less ugly

Current the format is markdown.

Jinja would be a good candidate here. For both Markdown and HTML.
It also could be an option for the CLI like --report markdown or --report html.
And in the future, have a even more flexible para like --template my_beautiful_page.html where developers can use whatever they want + CSS 💄.

[ ] Make DocsWriter abstract
[ ] Create a MarkdownWriter based on the current code
[ ] Create a ConsoleWriter (for debugging purposes)
[ ] Create a JSONWriter (that could be used for Markdown and HTML)
[ ] Create a HTMLWriter: scanapi -f schema.yml --writer=html --template=bla.html

@camilamaia I've broken this down to #58, #59, #60 and #61. Do you think we can close this then?

Sure! I will do that


Don't require the db connection pool to sit at maximum when idle

For posterity: the reason this change is necessary is so it's possible to run tests while the web server is running.


Tilt not working

I tried to disable the "45° imagery" setting "0" to "tilt".
This is the map definition:
<agm-map class="gmap" [latitude]="lat" [longitude]="lng" [zoom]="mapZoom" [styles]="mapStyles" #AgmMap           [streetViewControl]="false" [mapTypeControl]="false" [mapTypeId]="'satellite'" [tilt]="0">...
But, when the page should appear, I get this error message:

Can't bind to 'tilt' since it isn't a known property of 'agm-map

tilt was added in #1581, but not yet published to npm


Choosing between wireshark QT vs GTK

Hi!
First of all thank you for fixing the installer for the fedora, it works like a charm!
Now i only have a request that when the script run it use wireshark QT, but in my case i use GTK because it looks better that the QT version. ( i'm totally a newbie with linux)
So i want to know if there is a way to choose which wireshark version i want to run?
Thank you.

Hi!

We’re switching our user interface library from GTK+ to Qt.
https://blog.wireshark.org/2013/10/switching-to-qt/

if you still want to use the GTK version you can do this with command:
sudo sed -i '/wireshark_cmd =/ s/wireshark -k/wireshark-gtk -k/' /usr/bin/unetlab-x-integration

But I don't recommend it.

Hi!
Thank you for your answer, after reading the article and your advice i decided to keep it with QT
Once again i want to thank you for this Unetlab-x intergration, i'm really appricated
P/S: the next version of the Unetlab is called "EVE-NG" , basically an Unetlab v2.0, i'm wondering if you will support the next version if there is any changes.


Add cases for bug scenarios

adjust native transfer case
add bn256 case

This pr needs to be merged after v1.13.0-rc1 is released,because skip in it.skip need to be removed.


feat(create-vite): add vue-devtools in vue template

Description
👋 Hi team. After discussing with @yyx990803, we plan to add the vue-devtools vite plugin to the create-vite's template-vue. Here's a snapshot and repository of it.
repo: https://github.com/vuejs/devtools-next
docs: https://github.com/vuejs/devtools-next
snapshot:

If the Vue team decides that they want to include devtools in starters, then I can't argue with that, but are we sure we want to introduce a large installation size for the starter?

Maybe we can refer to create-vue and add an option for developers to decide whether to add it?

Added this to our project board, so we can talk with Evan in the next team meeting. I agree with @bluwy that this will be too much for the Vite starter as we are also using it for reproductions. @webfansplz is this added already to create-vue? I think that is a better place for this plugin, and we already suggest users that if they want to start a new Vue production app, they should use pnpm create vue instead of create vite.

Added this to our project board, so we can talk with Evan in the next team meeting. I agree with @bluwy that this will be too much for the Vite starter as we are also using it for reproductions. @webfansplz is this added already to create-vue? I think that is a better place for this plugin, and we already suggest users that if they want to start a new Vue production app, they should use pnpm create vue instead of create vite.

Thank you.  I agree with the team's trade-off between the starter template and size, it's a good point.  Let's go ahead and finalize based on the meeting discussion. (create-vue CLI has been running it as an experimental option for a while now, and I think we're about to remove the experimental flag.)

@webfansplz we discussed this in today's team meeting and confirmed that we'd like to keep the Vite starters lightweight. Would you like to change this PR to recommend the setup as a tip in the readme? (maybe mention that you can use the extension too instead of a plugin)

@webfansplz we discussed this in today's team meeting and confirmed that we'd like to keep the Vite starters lightweight. Would you like to change this PR to recommend the setup as a tip in the readme? (maybe mention that you can use the extension too instead of a plugin)

Oh, I'm sorry, I forgot to reply. That's no problem. I'll update it later.

@webfansplz are you still interested in tackling this?


Update developing-locally-docker.rst

Or did I miss a setting somewhere that would make production.yml the default?

@bertdemiranda no, you didn't. And don't forget to add yourself to the ./CONTRIBUTORS.rst :)

@bertdemiranda no, you didn't :). And don't forget to add yourself to the ./CONTRIBUTORS.rst.


[AutoRelease] t2-attestation-2022-10-28-89862(Do not merge)

https://github.com/Azure/sdk-release-request/issues/3315
Live test success
https://dev.azure.com/azure-sdk/internal/_build?definitionId=1168
BuildTargetingString
azure-mgmt-attestation
Skip.CreateApiReview
true

issue link:https://github.com/Azure/sdk-release-request/issues/3315


Add isRequired attribute into MultipleTextItemModel class

It is not possible to have non-empty value for the specific text item in the multiple text question.

Run-time is implemented. Add this property into the designer.

Implemented the editing at design-time in the editor-panel branch


fixes #81 - checkpoints on transparent blocks

Hi Ash, the detail is in #81 I guess.  I think there should be some sort of check that the block under the player can take a pressure plate before the checkpoint is added to the config files, otherwise the course becomes corrupt if the pressure plate fails to be created.
To begin with I thought there were only a few blocks affected but more kept appearing so ended up adding an enum class.
There is a "Material.isTransparent()" method which would make it simpler to check but quite a few of the blocks work normally as checkpoints so they would either be disallowed as checkpoints or potentially need to be allowed some other way.

Rewritten without the need for enum class. I think it works much better now.

Hey Steve, great work.
One suggestion would be to make this configurable, and enabled by default. Something like "Other.EnforceSafeCheckpoints", idk think of something obvious?
Also, move the logic you've done to check for an invalid placement into the Utils that returns a boolean of is valid, then just call that from the CheckpointMethods, and prevent the checkpoint if it isn't valid etc.

Great work Steve! :)

Thanks :-)


Sema: Downgrade actor convenience initializer diagnostic to a warning in interfaces

The convenience keyword is not accepted on actor initializers because the compiler infers this status automatically and actors cannot be subclassed. However, internally the compiler still computes whether an actor init is a convenience init and this implicit status has been leaking through accidentally in printed .swiftinterface files. This was noticed because in Swift 6 the presence of the keyword is diagnosed as an error, making .swiftinterface files unparseable for modules containing actors with convenience inits.
For Swift 6, I'm just going to suppress the error in .swiftinterface files regardless of language mode. In future releases of the compiler, though, it can stop printing the convenience keyword on these inits altogether, though.
Resolves rdar://130857256.

@swift-ci please smoke test

@swift-ci please smoke test


Problems determining best_gappos

I've noticed that in some situations the align_cdr3s function in tcr_distances.py will fail to find the best_gappos, causing an error. However, re-running the same dataset, I was able to get it to succeed about 20% of the time. I was unable to find any consistency in the center_cdr3 and member_cdr3 pairing that caused this to fail. Examples include:
DVGYKL DPAGNTGKL
GEGSNNRI GYNTNTGKL
GDRYAQGL GDVDYAQGL
But in each of these cases, rerunning the code eventually resulted in getting through these cases without issue. I assume the stochasticity is introduced by the random_seend. Any thoughts on how to best address this @phbradley ?
Traceback (most recent call last):
File "/mnt/Data/TCR_Git/public_pipeline/tcr-dist/make_tall_trees.py", line 683, in
a,b = align_cdr3s( center_cdr3, member_cdr3, gap_character )
File "/mnt/Data/TCR_Git/public_pipeline/tcr-dist/tcr_distances.py", line 98, in align_cdr3s
s0 = s0[:best_gappos+1] + gap_character*lendiff + s0[best_gappos+1:]
UnboundLocalError: local variable 'best_gappos' referenced before assignment

I think this could be explained at least in part by CDR3s of length 6. I've fixed that bug I believe (about to check it in), but that doesn't seem to explain the examples you give there. Hmmm... when I run align_cdr3s with those sequences I don't get an error...

Hrm, how strange...