rTorrent+Sonarr: Multi-file injections linked to season folder

What's happening surrounding the bug? (context)

cross-seed will find an indexer match in a given folder: let's say /data/media/TV Show/Season 01.
Two folders are created in my outputDir:

/data/xseeds/Tracker/TV.Show.S01.Original.Folder <- has correctly hardlinked files
/data/xseeds/Tracker/Season 01 <- empty

Torrent gets injected into rTorrent, but with the save location of /data/xseeds/Tracker/Season 01.

Since TV.Show.S01.Original.Folder is technically part of the torrent, it should actually just point to /data/xseeds/Tracker.

The torrent works if I manually change the save location to /data/xseeds/Tracker, since it will find TV.Show.S01.Original.Torrent.Folder and force recheck will pick up all the files.
Since it's able to create and hardlink the folder and files correctly, it's unclear to me why it seems to be using information from my media folder to determine the base path when injecting.
Example from the log:
2024-11-01 07:49:22 verbose: [rtorrent] Calling method load.start with params [ '',
  '/data/downloads/xseeds/torrents/Arcane.S01.720p.NF.WEB-DL.DDP5.1.x264-TEPES.tmp.1730461762581.torrent',
  'd.directory_base.set="/data/downloads/xseeds/BroadcasTheNet/Season 01"',
  'd.custom1.set="cross-seed"',
  'd.custom.set=addtime,1730461763' ]

I believe this corresponds to the code: (/src/clients/RTorrent.ts)
for (let i = 0; i < retries; i++) {
			try {
				await this.methodCallP<void>(
					loadType,
					[
						"",
						torrentFilePath,
						`d.directory_base.set="${directoryBase}"`,
						`d.custom1.set="${TORRENT_TAG}"`,
						`d.custom.set=addtime,${Math.round(Date.now() / 1000)}`,
						recheck
							? `d.check_hash=${meta.infoHash.toUpperCase()}`
							: null,
					].filter((e) => e !== null),
				);
				break;
			}

directoryBase is determined through a logic flow in getDownloadLocation():
if (path) {
			// resolve to absolute because we send the path to rTorrent
			const basePath = resolve(path, meta.name);
			const directoryBase = meta.isSingleFileTorrent ? path : basePath;
			return resultOf({ downloadDir: path, basePath, directoryBase });
		} else {
			const result = await this.checkOriginalTorrent(
				searchee as SearcheeWithInfoHash,
				true,
			);
			return result.mapOk(({ directoryBase }) => ({
				directoryBase,
				downloadDir: meta.isSingleFileTorrent
					? directoryBase
					: dirname(directoryBase),
				basePath: meta.isSingleFileTorrent
					? join(directoryBase, searchee.name)
					: directoryBase,
			}));
		}

But of course, the details are inscrutable to me :)
Have you checked for any existing open/closed tickets that are the same or similar to your issue?

[X] I've searched far and wide!

I have gone to the Discord server for support and/or acknowledge that this is a bug and not a support issue

[X] I've tried to solve this already

Reproducing the bug
I haven't ruled out that I am in fact at fault, purely because I have such a standard setup (TRaSH-recommended Sonarr folders, mostly default cross-seed config, etc.) that I can imagine others would have been impacted by now. But:

Install cross-seed v6 on Unraid via Docker
Use rTorrent/ruTorrent
Have a media library managed by Sonarr, with TRaSH-recommended folder scheme (/data/media/tv/show/season/files).
Set up config.js with default settings for flat-linking, search depth, etc.
Run a data-based search with partial matching

What should be happening?
When files are hardlinked into linkDir, the rTorrent d.directory_base.set should be whatever path would lead the client to find them, which in most cases would just be linkDir.
Your setup
- OS: Unraid 7.0.0-beta 3
- Prowlarr/Jackett: Torznab via Prowlarr <IP_ADDRESS>18
- Misc: ruTorrent v5.1.82

config.js (REDACT SENSITIVE INFORMATION)
    delay: 300,
    dataDirs: ["/data/media/tv","/data/media/movies","/data/media/anime/tv","/data/media/anime/movies"],
    linkCategory: "cross-seed-link",
    linkDir: "/data/downloads/xseeds",
    linkType: "hardlink",
    flatLinking: false,
    matchMode: "partial",
    maxDataDepth: 2,
    torrentDir: "/torrents",
    outputDir: "/data/downloads/xseeds/torrents",
    includeSingleEpisodes: false,
    includeNonVideos: true,
    fuzzySizeThreshold: 0.02,
    excludeOlder: "2 weeks",
    excludeRecentSearch: "3 days",
    duplicateCategories: false,
    rssCadence: "30 minutes",
    searchCadence: "1 day",
    snatchTimeout: "30 seconds",
    searchTimeout: "2 minutes",
    searchLimit: 300,
    blockList: undefined,
};

verbose logs
2024-11-02 00:35:00 verbose: [rtorrent] Calling method system.multicall with params [ [ { methodName: 'd.directory',
      params: [ '3D72B693BC9B61B93827FC188FCC8C25A0E8FAAA' ] },
    { methodName: 'd.complete', params: [ '3D72B693BC9B61B93827FC188FCC8C25A0E8FAAA' ] },
    { methodName: 'd.is_multi_file',
      params: [ '3D72B693BC9B61B93827FC188FCC8C25A0E8FAAA' ] } ] ]
2024-11-02 00:35:00 verbose: [rtorrent] Calling method download_list with params []
2024-11-02 00:35:00 debug: [rtorrent] File /data/downloads/xseeds/Blutopia/Season 01/Jury.Duty.S01E02.Opening.Arguments.REPACK.720p.AMZN.WEB-DL.DDP5.1.H.264-playWEB.mkv either doesn't exist or is the wrong size.
2024-11-02 00:35:00 debug: [rtorrent] File /data/downloads/xseeds/Blutopia/Season 01/Jury.Duty.S01E04.Field.Trip.REPACK.720p.AMZN.WEB-DL.DDP5.1.H.264-playWEB.mkv either doesn't exist or is the wrong size.
2024-11-02 00:35:00 debug: [rtorrent] File /data/downloads/xseeds/Blutopia/Season 01/Jury.Duty.S01E03.Foreperson.REPACK.720p.AMZN.WEB-DL.DDP5.1.H.264-playWEB.mkv either doesn't exist or is the wrong size.
2024-11-02 00:35:00 debug: [rtorrent] File /data/downloads/xseeds/Blutopia/Season 01/Jury.Duty.S01E01.Voir.Dire.REPACK.720p.AMZN.WEB-DL.DDP5.1.H.264-playWEB.mkv either doesn't exist or is the wrong size.
2024-11-02 00:35:00 debug: [rtorrent] File /data/downloads/xseeds/Blutopia/Season 01/Jury.Duty.S01E06.Closing.Arguments.REPACK.720p.AMZN.WEB-DL.DDP5.1.H.264-playWEB.mkv either doesn't exist or is the wrong size.
2024-11-02 00:35:00 debug: [rtorrent] File /data/downloads/xseeds/Blutopia/Season 01/Jury.Duty.S01E05.Ineffective.Assistance.REPACK.720p.AMZN.WEB-DL.DDP5.1.H.264-playWEB.mkv either doesn't exist or is the wrong size.
2024-11-02 00:35:00 debug: [rtorrent] File /data/downloads/xseeds/Blutopia/Season 01/Jury.Duty.S01E07.Deliberations.720p.AMZN.WEB-DL.DDP5.1.H.264-playWEB.mkv either doesn't exist or is the wrong size.
2024-11-02 00:35:00 debug: [rtorrent] File /data/downloads/xseeds/Blutopia/Season 01/Jury.Duty.S01E08.The.Verdict.720p.AMZN.WEB-DL.DDP5.1.H.264-playWEB.mkv either doesn't exist or is the wrong size.
2024-11-02 00:35:00 verbose: [rtorrent] Calling method load.start with params [ '',
  '/data/downloads/xseeds/torrents/Jury.Duty.S01.720p.AMZN.WEB-DL.DDP5.1.H.264-playWEB.tmp.1730522100534.torrent',
  'd.directory_base.set="/data/downloads/xseeds/Blutopia/Season 01"',
  'd.custom1.set="cross-seed"',
  'd.custom.set=addtime,1730522101' ]

Failure or refusal to provide the information we require to address bugs will result in potential closure of the issue.

[X] I acknowledge that i have searched existing issues, read the documentation and faq, read the logs to see if the answer was provided in error messaging, and attempted to get support via the Discord prior to submitting this issue.

@mmgoodnow rt bug?

@adapowers How many of your torrents is this happening for?

could also be a bug with the sonarr season folder stuff

could also be a bug with the sonarr season folder stuff

What specifically?


possible analyzer type-inference bug with nnbd

We found an issue that seems to indicate that analyzer may be inferring the wrong type for a function closure under nnbd.
@joshualitt hit this issue while migrating the dart2js patch files and seeing calls to future.then((_) => null) where our future had type Future<Null>. The inferred type was Null Function(Object) instead of Null Function(Null) or Null Function(Object?).
Here is a simple repro below:
class A<T> {
  final T t;
  A(this.t);
  A<R> then<R>(R Function(T t) callback) => A(callback(t));
}

m1() {
  A<Null> a = A(null);
  a.then((_) => null);
}

m2() {
  A<int?> a = A(null);
  a.then((_) => null);
}

m3() {
  A<int> a = A(3);
  a.then((_) => null);
}

m4() {
  A<Never?> a = A(null);
  a.then((_) => null);
}

We expected no errors, but instead we got:
> out/ReleaseX64NNBD/dartanalyzer --enable-experiment=non-nullable repro.dart
Analyzing foo.dart...
  error • The argument type 'Null Function(Object)' can't be assigned to the parameter type 'Null Function(Null)'. • foo.dart:9:10 • argument_type_not_assignable
  error • The argument type 'Null Function(Object)' can't be assigned to the parameter type 'Null Function(Never?)'. • foo.dart:24:10 • argument_type_not_assignable
2 errors found.

https://github.com/dart-lang/sdk/issues/39791


jpg converter python script

Hi added a python script which converts other image format to jpg hoping it will be useful.

@avinashkranjan hi sorry for delay i created an issue for the same

@all-contributors please add @abhishekjoshi2612  for code and documentation


Windows support

Does gvm support traditional Windows environments (PowerShell or Command Prompt)? I could work around some Windows issues by using Git Bash, but for I would appreciate if gvm supported non-bash environments.
If not, does anyone know of a Windows equivalent of gvm?

Check out https://github.com/danielkermode/gvm

Works on my machine!


If my cloud is down and i want to manage the pods in the nodepool in the edge then how should i setup the kubectl?

What happened:
What you expected to happen:
How to reproduce it (as minimally and precisely as possible):
Anything else we need to know?:
Environment:

OpenYurt version:
Kubernetes version (use kubectl version):
OS (e.g: cat /etc/os-release):
Kernel (e.g. uname -a):
Install tools:
Others:

others
/kind question

@Nitish-CONSORT Thanks for raising the issue. what kind of operations do you want to manage the pods in the edge when cloud is down?
Any changes to the pod in the edge will be overwritten by the pods in the cloud after cloud recovered.

I am not able to enter in pod by "kubectl exec" command, and also not able to "apply" and "delete" pods if cloud is in down state.

@Nitish-CONSORT There are no activities on this issue for a long time, so i will close this issue.
You can feel free to reopen this issue or create new issues if needed.


10 errors (unable to build)

all errors under the same file (imgui_impl_dx9.cpp)
unable to build

update : anyone with issue look at pull requests


Merge with upstream

dev deploy is successful: https://ci.hail.populationgenomics.org.au/batches/1583 🎊
But I'll merge again to get https://github.com/hail-is/hail/pull/10390 in

successful again! https://ci.hail.populationgenomics.org.au/batches/1585 🎊


Support for subcommands under dynamic subcommand

I'm trying to implement command like "main subcommand  set version".  I'm able to do the first bash completion, but that gives me the call to the Action method in the subcommand, but I haven't been able to find a way how I could create subcommands under this level.
Is this something which I can work around with the current implementation, or would this need built in support into the library?

@garo at this time you would need to add that subcommand (set) to each of your commands.
E.g. something like:
package main

import (
	"os"

	"github.com/codegangsta/cli"
)

func configureCommand(name string) cli.Command {
	return cli.Command{
		Name:  "configure",
		Usage: "configure " + name,
		Action: func(c *cli.Context) {
			println("configuring " + name)
		},
	}
}

func main() {
	app := cli.NewApp()
	app.Name = "boom"
	app.Usage = "make an explosive entrance"
	app.Action = func(c *cli.Context) {
		println("boom! I say!")
	}

	app.Commands = []cli.Command{
		{
			Name:        "add",
			ShortName:   "a",
			Usage:       "add task",
			Subcommands: []cli.Command{configureCommand("add")},
		},
		{
			Name:        "remove",
			ShortName:   "r",
			Usage:       "remove task",
			Subcommands: []cli.Command{configureCommand("remove")},
		},
	}

	app.Run(os.Args)
}

➜  cli git:(add-aliases) go run /tmp/tmp.go add -h
NAME:
   boom add - add task

USAGE:
   boom add command [command options] [arguments...]

COMMANDS:
   configure    configure add
   help, h      Shows a list of commands or help for one command

OPTIONS:
   --help, -h   show help

➜  cli git:(add-aliases) go run /tmp/tmp.go add configure
configuring add

Let me know if this isn't clear or if I am misunderstanding what you are asking for!

Closing this, but please reopen if you don't feel the issue was properly addressed.


[Feature request] Allow separate minchansize setting for private channels

Currently a node operator can only control the minimum channel size accepted together in public and private channels:
https://github.com/lightningnetwork/lnd/blob/fa4155c12605be616a35d18c62a9a8087d5b4b32/sample-lnd.conf#L245
The setting is very useful:
Small public channels are not desirable for a routing node since they are uneconomical (large onchain cost vs usefulness) and getting unbalanced quickly causing payment failures.
There should be a separate setting to allow minimal sized private channels (alongside the different requirement for public ones) to allow mobile wallets and other small private nodes to choose freely.
This would allow for more decentralization without affecting path finding and the payment success rate.

FWIW the enterprising node operator can implement something dynamic like this today using the existing channel acceptor APIs.


feat: allow from_dict to not have native_namespace arg if all inputs are already narwhals Series

closes #756

What type of PR is this? (check all applicable)

[ ] 💾 Refactor
[ ] ✨ Feature
[ ] 🐛 Bug Fix
[ ] 🔧 Optimization
[ ] 📝 Documentation
[ ] ✅ Test
[ ] 🐳 Other

Related issues

Related issue #
Closes #

Checklist

[ ] Code follows style guide (ruff)
[ ] Tests added
[ ] Documented the changes

If you have comments or can explain your changes, please do so below.

@FBruzzesi fancy taking a look if you have interest/time?

merging for now so we can release, and as far as I can tell your comment can be addressed as a follow-up if necessary
thanks for your review! 🙏


[Bug]: Drag and drop to upload a file does not work on macOS Safari

Browser
Safari
Package version
3.0.662
React version
18.3.1
Description
Drag and drop to upload works on Chrome but not on Safari on macOS.
Sonoma 14.5, Safari 17.5.
https://cloudscape.design/components/file-upload
Only click to upload via system dialog works.
Source code
No response
Reproduction
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct
[X] I checked the current issues for duplicate problems

Hi @rinkaaan, thanks for reaching out.
I was able to reproduce the issue on Safari 17, (macOS 13.6.7). We're taking a look at it.

Closing this issue - resolved in https://github.com/cloudscape-design/components/pull/2444


feat(git_stash): Allow search to search stash list for regex keyword

This is equivalent as git stash list -G<regex> in the command line.
Example:
:lua require("fzf-lua").git_stash { search = 'pattern' }

:FzfLua git_stash search=(some|regex|pattern)

This will be useful to quickly find the stash for some keyword by content. DEMO:

... when you have really many clutters on the stash list :P

Idea: how to highlight the "grep string" in the preview window?

Another idea is to search through the "content" for a keyword:
Ref: https://stackoverflow.com/questions/42555410/is-it-possible-to-search-through-git-stash-items
for i in $(git stash list --format="%gd"); do
	git stash show -p $i | grep -H --label="$i" "$@"
done

Although it'd be quite easy to set this up with a custom user command, but if you'd more like this behavior (which is arguably more useful) I could also consider working again for such a "stash-grep" like behavior.

Ty @wookayin for the contribution!

Idea: how to highlight the "grep string" in the preview window?

The current stash previewer is  using the native fzf previewer which limits us to shell command (currently git --no-pager stash show --patch --color {1}).
I haven't done proper research so it might be possible with a custom git command, another option that might be possilble is with  git-delta as pager (really nice for commits).
If you really want this there's another option which is to create a custom previewer that uses a neovim buffer (i.e. the "builtin" previewer), set it to display the stash as diff and then highlight whichever lines you want using matchadd, or search, etc


Add missing instructions for adding CSS

This was missed out from the instructions. Without this the UI looks broken.

Thank you for the contribution!


update pixie check default

The flex-based Pixie health check config is generating errors and needs to be debugged.  Until I have time to investigate, I think this should be disabled by default so the pixieHealthCheck events aren't spammed with useless data.

Closing and will redo.


chore: Update job

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 96.083%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
6220

Relevant Lines:
6246

💛  - Coveralls


Decoder queue not cleared correctly

Not sure what I am doing wrong but it seems like the decoder queue is not cleared correctly when playing tracks. This shows up in the log when the problem is about to happen:
No open slots in _decoderStateArray
The result is that the playback is stopped and the requested track might or might not play.
The problem can be reproduced in the SimplePlayer-macOS example project by loading a file and then double-clicking the playlist item multiple times to play it again and again. It does not seem to happen when tracks are played sequentially, so it seems to be tied to how "fast" tracks are queued and played.
Full log output: output.txt
macOS 10.15.7
Xcode 12.3

This bug is related to how often the garbage collector dispatch source runs, which by default is once every 10 seconds.  To fix it the collector needs to run more often or have the ability to be signaled on demand (perhaps via a semaphore). I will look into a fix.

I've created an experimental fix at https://github.com/sbooth/SFBAudioEngine/tree/collector-thread

That was blazing fast, thank you very much. I did some quick testing and it all seems to work with the fix, amazing.

I'm glad it's working for you now.
I reworked the code to use a dispatch source instead of a a dedicated thread. In theory this should decrease the overhead.


Add tenant to grpc calls

Needs semitechnologies/weaviate:preview-add-missing-features-to-grpc-91c1e00to work

Fixes tenants in insert call
Adds tenant for queries

Codecov Report
Patch coverage: 62.62% and project coverage change: +0.25% :tada:

Comparison is base (09458b9) 93.75% compared to head (ed2179d) 94.00%.

Additional details and impacted files
@@                   Coverage Diff                   @@
##           pydantic_experiment     #401      +/-   ##
=======================================================
+ Coverage                93.75%   94.00%   +0.25%
=======================================================
  Files                       73       73
  Lines                     9523     9548      +25
=======================================================
+ Hits                      8928     8976      +48
+ Misses                     595      572      -23

Files Changed
Coverage Δ

weaviate_grpc/weaviate_pb2.py
25.58% <3.33%> (ø)

weaviate/collection/collection_base.py
58.51% <68.75%> (+3.84%)
:arrow_up:

weaviate/collection/collection_model.py
55.49% <83.33%> (+4.41%)
:arrow_up:

weaviate/collection/collection.py
75.00% <90.90%> (+3.57%)
:arrow_up:

integration/test_cluster.py
100.00% <100.00%> (ø)

integration/test_collection.py
100.00% <100.00%> (ø)

integration/test_collection_model.py
99.13% <100.00%> (+0.13%)
:arrow_up:

weaviate/collection/grpc.py
93.71% <100.00%> (+0.03%)
:arrow_up:

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Blacklisting logged headers

These changes will allow rest-assured clients to blacklist certain headers from being logged, regardless of whether the LogDetail is ALL or HEADERS.
The rationale of this change is that while headers are useful to look when debugging, they could also potentially contain secret or confidential data that one may wish to redact.
Usage example:
new RequestSpecBuilder()
                .addHeader("x-api-key", "rest_assured_test")
                .addHeader("Authorization", "My funny secret")
                .log(ALL)
                .logBlacklists(new LogBlacklists()
                        .blacklistHeader("Authorization"))
                .build();

Output example
Request method:	GET
Request URI:    http://localhost:8080/foo/bar
Proxy:          <none>
Request params: <none>
Query params:   <none>
Form params:    <none>
Path params:    x-api-key=rest_assured_test
Headers:        Accept=[ REDACTED ]
Cookies:        <none>
Multiparts:     <none>
Body:           <none>

Further notes
These changes blacklist headers only, but the changes could be extended to other components of an HTTP request if required.
Also, this would be my first contribution to the project, so I hope this PR is fine and would be happy to take suggestions.

@johanhaleby - would you be able to look at this PR when you have some time? I would be very happy to get feedback from you.

@sic2 Sorry for not responding earlier, I have a crazy amount of stuff going on atm.
Do I understand it correctly that the black list is empty by default? I.e. it doesn't break backward compatibility?

@johanhaleby no problem. I was out of the country over the last few days too :)
The Blacklist entity is passed to the filter on all requests: https://github.com/rest-assured/rest-assured/pull/1222/files#diff-4da3dac70ae9b143ab367e220b30fb8eR112
but as you stated, it is initialised to be empty by default: https://github.com/rest-assured/rest-assured/pull/1222/files#diff-7e3b9a86fe2a2ac2d6840d76e4c97ff6R31
I have kept the existing test supportsSettingLoggingWhenUsingRequestSpecBuilder to ensure that we have backward compatibility on code not using this feature.

@johanhaleby have you managed to have a look at this? cheers


Error in main page documentation

Theres this piece of code in the main page:
import { history } from 'react-router/lib/BrowserHistory';
if not mistaken it should be:
import { history } from 'react-router/lib/History';

it's even different again! we'll get the docs in order before the release.


Feature request: Syntax highlighting with isa

Is it possible for the second case to also apply to the first?

You mean highlighting MagneticParticle as a type? In theory yes, but I'm not sure how good a heuristic we can find for this.

The same you use in <:, which I guess is "what is followed by <: gets highlighted" ?

Right, but the heuristic already is pretty bad :D
Wanna reopen the issue here?


Add util.lazy_property.

Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Please tag this pr with at least one of these labels to make our release process faster: BREAKING, new feature, bug fix, other change, dev setup

@jaheba this is very simple, but I guess we would want to have at least a test?


Months or days referring to past dates

Hi,
It today it's tuesday, and you do
 Date.create('monday')

It will return the date of yesterday, instead of the monday of the next week.
In the same way, if I do
 Date.create('january')

I will expect to have january of 2012 (not 2011).
As with the issue #60 I reported before, this behaviour is not a bug at all. But if you think, a very typical use case of a natural language parser for dates is letting users to express due dates easily. If you are a human, you will probably be referring to events in the future by default. This is for example the way the famous Ruby Chronic library works: https://github.com/mojombo/chronic

I'm going to have to disagree with you on this one. A date called "monday" would most definitely imply "monday of this week". Specifying "next monday" would be the correct way of saying "monday of next week". Two points here:

There of course are exceptions in spoken language in which the phrase "let's do it on monday" would of course mean "next monday" as the implied context is of "doing" something and time is linear :).  No such context is of course implied in a Javascript date module, not should it be, which is why monday means "monday of this week".

It's not impossible that cultural considerations may be at work here, but in my mind there would have to be nothing short of absolutely unanimous support of native speakers of a given language that "monday" implying "this monday" is strange to justify changing actual logical behavior based on a locale code. It seems far too messy a situation to get yourself into.


Beautify JavaScript code in this project

@vaadin-miki is not a person that is familiar with JS practices. The code can definitely be improved in terms of readability, best practices, patterns, etc. Please help this project by going through the JS code and making it somewhat more beautiful.

Well .......


Track correct answers

I want to track the number of correct answers during a game and store that information.

Correct answers are tracked but not stored in a high score area.

scores stored in local storage and print to ui
local storage can be cleared


[UX] Theme Toggle icon

Current Behavior

On mobile devices (small screens) Theme Toggle icon is in the dropdown menu and not visible upfront, imo it would be nice to have it next to the hamburger icon.
Expected Behavior

Screenshots/Logs

Currently

Environment

Host OS: Linux

Contributor Guides and Resources

🛠 Meshery Build & Release Strategy
📚 Instructions for contributing to documentation

Meshery documentation site and source

🎨 Wireframes and designs for Meshery UI in Figma (open invite)
🙋🏾🙋🏼 Questions: Discussion Forum and Community Slack

If this change is needed, please assign this to me and i'll make a PR.
Thank You


opening PDF print preview crashes browser

related: https://github.com/lookitscook/kiosk/issues/326
possibly:
https://bugs.chromium.org/p/chromium/issues/detail?id=978005&q=pdf crash&colspec=ID Pri M Stars ReleaseBlock Component Status Owner Summary OS Modified
https://bugs.chromium.org/p/chromium/issues/detail?id=951764&q=pdf crash&colspec=ID Pri M Stars ReleaseBlock Component Status Owner Summary OS Modified

reported via email. https://mail.google.com/mail/u/0/#inbox/FMfcgxwChmPGjQZtZGQMXSPhwLzxpDnJ


added description to the menu item padding customizer control

Lol, I just made a release that this should have been in.


Fix breaking NewFightForm when you forget to choose another character

For now, focus on:

Trying to find if it's replicable this bug
If it is, solve it and give the description here for reference

This error happens when you forget to choose both characters, and you left the default -- choose an option --, because it does not exist as a character in charactersData
Error in console:

Form that triggers the error:


Frigate+ API Key in Frigate LXC

How do I add the Frigate+ API Key to Frigate LXC, to add and activate the Plus API?
I Updated the config to include Frigate+ model path.
Frigate won't start.
2024-10-07 10:19:58.172528  [INFO] Preparing Frigate...
2024-10-07 10:19:58.172597  [INFO] Starting Frigate...
2024-10-07 10:19:59.473253  [2024-10-07 10:19:59] frigate.app                    INFO    : Starting Frigate (0.14.1-)
2024-10-07 10:19:59.478520  [2024-10-07 10:19:59] frigate.util.config            INFO    : Checking if frigate config needs migration...
2024-10-07 10:19:59.523695  [2024-10-07 10:19:59] frigate.util.config            INFO    : frigate config does not need migration...
2024-10-07 10:19:59.554443  *************************************************************
2024-10-07 10:19:59.554495  *************************************************************
2024-10-07 10:19:59.554512  ***    Your config file is not valid!                     ***
2024-10-07 10:19:59.554527  ***    Please check the docs at                           ***
2024-10-07 10:19:59.554542  ***    https://docs.frigate.video/configuration/index     ***
2024-10-07 10:19:59.554556  *************************************************************
2024-10-07 10:19:59.554570  *************************************************************
2024-10-07 10:19:59.554585  ***    Config Validation Errors                           ***
2024-10-07 10:19:59.554600  *************************************************************
2024-10-07 10:19:59.554614  Plus API not activated
2024-10-07 10:19:59.554870  Traceback (most recent call last):
2024-10-07 10:19:59.554941    File "/opt/frigate/frigate/app.py", line 645, in start
2024-10-07 10:19:59.554960      self.init_config()
2024-10-07 10:19:59.554976    File "/opt/frigate/frigate/app.py", line 140, in init_config
2024-10-07 10:19:59.554991      self.config = user_config.runtime_config(self.plus_api)
2024-10-07 10:19:59.555007    File "/opt/frigate/frigate/config.py", line 1599, in runtime_config
2024-10-07 10:19:59.555023      config.model.check_and_load_plus_model(plus_api)
2024-10-07 10:19:59.555038    File "/opt/frigate/frigate/detectors/detector_config.py", line 91, in check_and_load_plus_model
2024-10-07 10:19:59.555067      download_url = plus_api.get_model_download_url(model_id)
2024-10-07 10:19:59.555081    File "/opt/frigate/frigate/plus.py", line 228, in get_model_download_url
2024-10-07 10:19:59.555096      r = self._get(f"model/{model_id}/signed_url")
2024-10-07 10:19:59.555110    File "/opt/frigate/frigate/plus.py", line 84, in _get
2024-10-07 10:19:59.555124      f"{self.host}/v1/{path}", headers=self._get_authorization_header()
2024-10-07 10:19:59.555139    File "/opt/frigate/frigate/plus.py", line 79, in _get_authorization_header
2024-10-07 10:19:59.555153      self._refresh_token_if_needed()
2024-10-07 10:19:59.555168    File "/opt/frigate/frigate/plus.py", line 71, in _refresh_token_if_needed
2024-10-07 10:19:59.555182      raise Exception("Plus API not activated")
2024-10-07 10:19:59.555197  Exception: Plus API not activated
2024-10-07 10:19:59.555211
2024-10-07 10:19:59.555226  *************************************************************
2024-10-07 10:19:59.555241  ***    End Config Validation Errors                       ***
2024-10-07 10:19:59.555255  *************************************************************

Found https://github.com/tteck/Proxmox/discussions/2711#discussioncomment-8975702 in my search

Interesting! I tried that, but that does not seem to work.

keen to see if we can get an answer

@tteck
For me, editing /etc/systemd/system/frigate.service WORKED!!
I needed to put in capital letters and reboot.
What I did:
edit /etc/systemd/system/frigate.service
Add line: Environment=PLUS_API_KEY=verylongapikey under [Service]
After that: systemctl daemon-reload
Then a reboot.

@tteck For me, editing /etc/systemd/system/frigate.service WORKED!! I needed to put in capital letters and reboot.
What I did:
edit /etc/systemd/system/frigate.service Add line: Environment=PLUS_API_KEY=verylongapikey under [Service] After that: systemctl daemon-reload Then a reboot.

@tteck maybe you could add this to the bottom of https://tteck.github.io/Proxmox/#frigate-lxc ??

not sure why I didn't get notified on this. Indeed adding the key to the service is the way to go (my fork already has a commented line for that. See here for that
Closing this issue as resolved


fix: Properly reseve connection for the duration of the request

Problem: connection pool does not properly reserve connection when it is
in use. So, it is possible that two requests within the same session
will start executing in parallel. Mysql driver is not thread-safe and
this will cause malformed network packed.
Fixed by attaching extra mutex to each connection, that would be locked
for duration of the request.
Fix prisma/team-orm#494
Fix prisma/team-orm#540
Contributes to prisma/team-orm#518

My feedback here: https://github.com/mattrobenolt/ps-http-sim/issues/1
We concluded that it'd make more sense for the proxy to explicitly disallow this behavior, since anytime this behavior happens, it'd lead to undefined behavior and should be considered a bug in the client or driver.
A single session is not expected to be used in parallel, and having this simulator gets us an opportunity to actually error here and message that, instead of forcing some nondeterministic serialized order.

Thank you @mattrobenolt, we agree that this is more of our implementation bug and will do necessary changes to our adapter instead.

I've dropped a new build: https://github.com/mattrobenolt/ps-http-sim/releases/tag/v0.0.2


Add hello_world_component to CI builds

hello_world_component is deliberately excluded from the cmake build as it is intended to illustrate building by command line. It should be explicitly added to CI builds, to prevent it from accidentally breaking.

I'd like to take this issue up.

@NK-Nikunj absolutely, feel free.


Transaction support

Use NM checkpoint feature to implement transactions.
Based on #47

Coverage decreased (-14.2%) to 74.435% when pulling 38340efa436b01095f1bfd1feed21cc9115a8188 on EdDev:transaction-support into 2576ba638aac8b348576181182e539a0580baf20 on nmstate:master.


low validation accuracy with pre-train model on kinetic dataset

Hi，when I try to apply the pre-train model(resnext-101-64f-kinetics.pth)on the validation set from Kinetic dataset, the accuracy turns out to be very low(much like random prediction). I have check the loader and did not modify the code.  I am wondering  how does the pre-train model come from.  Did you directly train Pytorch code from zero or transfer the weights from Torch-version pre-train model?  Thx!

I trained the model from scratch using the pytorch codes,
and I confirmed my pretrained models achieved the accuracies reported in my paper.
Did you correctly specify using the pretrained models?

How many days do you compute at one GTX titan X?@kenshohara

It took 3 weeks using 8 GPUs.

@jeremy43
Issue #45 may be the same issue as yours.

Hi， I choose the resume_path instead, the problem is solved, thanks!


latest fixes

Thank you, @rradillen. From this end we're done with changes, but I do have to add three more basic XMLUI themes (https://github.com/ilri/DSpace/issues/151). I will try to do that this afternoon.


Oxide support for Intersellar Rift

Per http://oxidemod.org/threads/oxide-for-interstellar-rift.9950/.
Right now we're unable to look at this until we receive copies of the game.

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/24605518-oxide-support-for-intersellar-rift?utm_campaign=plugin&utm_content=tracker%2F6855523&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F6855523&utm_medium=issues&utm_source=github).

Basic support has been implemented. More hooks to follow!


More options to set syntax highlighting for content

Hi,
Currently we can get syntax highlighting by loading text from file. The syntax is recognized by syntect itself.
Can we somehow pass a content to buffer by hand instead of loading a file and set syntax to desired extension?

There is no mechanism for this yet, but it could be added.

Would be awesome to see this option. Syntect comes with some handy methods for this purpose. Do you planning to add this soon or later? :sweat_smile:

If you want it sooner, you could look at the syntect editor source. The load_text function is pretty simple so you could make a new function that lets you set what you want.

Yeah, that's probably what I will do in this case. Thank you :)


Vanilla hoppers

When using the mode with lithium, if we put the hoppers (vanilla hoppers) side by side as in the photo below and throw something into it, the game crashes. The game does not crash when the lithium loaded omni-hopper is not loaded,
The game does not crash when the omni-hopper is not loaded with lithium. When the game crashes we get the following error.
Description: Ticking block entity
java.lang.AbstractMethodError: Receiver class net.minecraft.class_2614 does not define or inherit an implementation of the resolved method 'boolean canReceiveTransferCooldown()' of interface me.jellysquid.mods.lithium.api.inventory.LithiumCooldownReceivingInventory.
at net.minecraft.class_2614.handler$zmc000$lithium$lithiumInsert(class_2614.java:679)
at net.minecraft.class_2614.method_11246(class_2614.java:148)
at net.minecraft.class_2614.method_11243(class_2614.java:115)
at net.minecraft.class_2614.method_31692(class_2614.java:102)
at net.minecraft.class_2818$class_5563.method_31703(class_2818.java:662)
at net.minecraft.class_2818$class_5564.method_31703(class_2818.java:716)
at net.minecraft.class_1937.method_18471(class_1937.java:470)
at net.minecraft.class_3218.method_18765(class_3218.java:390)
at net.minecraft.server.MinecraftServer.method_3813(MinecraftServer.java:897)
at net.minecraft.server.MinecraftServer.method_3748(MinecraftServer.java:824)
at net.minecraft.class_1132.method_3748(class_1132.java:105)
at net.minecraft.server.MinecraftServer.method_29741(MinecraftServer.java:671)
at net.minecraft.server.MinecraftServer.method_29739(MinecraftServer.java:265)
at java.base/java.lang.Thread.run(Thread.java:833)

A better solution is to download and install the latest version of Cooldown Coordinator and place it in your mods folder.  This will override the older version bundled in OmniHopper.
Lithium's code completely replaces the majority of the vanilla HopperBlockEntity transfer implementation, making it very likely to be incompatible with other mods that try to modify or add to the transfer implementation.  This decision was not very neighborly of them, to say the least.  At my request, they added an API so we could still coordinate cooldowns, but it turns out their API implementation is incomplete, so we need to switch back to suppressing their HBE optimizations instead.
It would also be a good idea for OmniHopper to update the bundled version of Cooldown Coordinator.

Just published an update to bump the included CC version to 0.6.2, thanks for letting me know. 👍


Fix token fetching before connecting to the server

This PR fixes issue #70

Thanks! Had similar bugs in other SDKs recently released - looks like the last minute idea with getToken function behaviour, and not enough attention to all cases.


Bugfix/update package

Update some imports in webview-umbrella.h to solve the issues #3 and #4
Pre-launch Checklist

[ ] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[ ] I read the Tree Hygiene wiki page, which explains my responsibilities.
[ ] I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
[ ] I signed the CLA.
[ ] The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
[ ] I listed at least one issue that this PR fixes in the description above.
[ ] I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
[x] I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
[ ] I updated/added relevant documentation (doc comments with ///).
[ ] I added new tests to check the change I am making, or this PR is test-exempt.
[ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Hello,
When this PR will be applied please :'( ?

up

hi facing same issue , please let me know what to do ?

up

@wenzhiming Please approve

Definition of 'FLTCookieManager' must be imported from module 'webview_flutter_wkwebview.FLTCookieManager' before it is required
I am getting error on ios device, Can you provide some info when it will be fixed
Thanks

Some help regarding this issue in ios: Please anyone
Modules Issue (Xcode): Definition of 'FLTWebViewFactory' must be imported from module 'webview_flutter_wkwebview.FlutterWebView' before it is required
/Users/apple/flutter/.pub-cache/hosted/pub.dartlang.org/webview_pro_wkwebview-2.7.1+2/ios/Classes/FlutterWebView.m:10:16
Modules Issue (Xcode): Definition of 'FLTWKNavigationDelegate' must be imported from module 'webview_flutter_wkwebview.FLTWKNavigationDelegate' before it is required
/Users/apple/flutter/.pub-cache/hosted/pub.dartlang.org/webview_pro_wkwebview-2.7.1+2/ios/Classes/FlutterWebView.m:119:28
Modules Issue (Xcode): Definition of 'FLTWKProgressionDelegate' must be imported from module 'webview_flutter_wkwebview.FLTWKProgressionDelegate' before it is required
/Users/apple/flutter/.pub-cache/hosted/pub.dartlang.org/webview_pro_wkwebview-2.7.1+2/ios/Classes/FlutterWebView.m:152:5
Modules Issue (Xcode): Definition of 'FLTCookieManager' must be imported from module 'webview_flutter_wkwebview.FLTCookieManager' before it is required
/Users/apple/flutter/.pub-cache/hosted/pub.dartlang.org/webview_pro_wkwebview-2.7.1+2/ios/Classes/FLTCookieManager.m:7:16


Will this documentation be implemented into docs.microsoft.com?

It seems very odd that Microsoft presents docs.microsoft.com and then actively builds a new repository for Windows 10 IT professionals.
I'd like to ask if this repository will be incorporated into docs.microsoft.com any time in the future? If this would not be the case would there a specific reason? Just asking out of curiousity.
Thank you.

@Borkason Thanks for the feedback!  docs.microsoft.com and the Windows 10 repo were built around the same time so the schedules didn't align. We are looking into a migration to docs.microsoft.com in the future though.


Fix occasional hang with http2 goaway frames

Http2Connection was dropping headers of healthy streams
after GOAWAY frame.
Fixes #3422

Not sure why Travis build failed, all tests passed in Travis and mvn clean verify works for me locally too (osx, java 8)
Results :
Tests run: 350, Failures: 0, Errors: 0, Skipped: 6

Restarted build. The VM crashed for an unknown reason.
On Thu, Aug 10, 2017, 6:17 AM ifedorenko<EMAIL_ADDRESS>wrote:

Not sure why Travis build failed, all tests passed in Travis and mvn
clean verify works for me locally too (osx, java 8)
Results :
Tests run: 350, Failures: 0, Errors: 0, Skipped: 6
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/square/okhttp/pull/3516#issuecomment-321548066, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAEEEZ-S1EIyklxU9LJh4E4pCmvtIHWfks5sWwL8gaJpZM4OzYqT
.

I’m trying to understand exactly what’s going on here, and I’m having a bit of trouble mostly because I haven’t looked at this code for a long time.
Client sends request 1
Client sends request 3
Server sends response 3
Server sends GOAWAY shutdown, saying last client-initiated stream ID is 3
Server sends response headers 1
Client rejects response headers 1 because the connection is shutdown
I think the fix is to move this line in headers()
        if (shutdown) return;

down into the block that runs only if the stream is unknown:
        if (stream == null) {
          if (shutdown) return;

... Just tested it, and that’s sufficient to get the new test to pass. If you’re cool with that, that’s what I’ll merge.

Yes, this is the scenario that causes 3.8.1 to hang and I confirmed your fix solves the problem when running against nginx. Thank you for looking into this.

Merged manually. Thanks!


配置其他选择 禁止公网访问取消勾选后 保存还提示密码复杂度不够 保存失败

Description
无法正常保存

DNS Provider
No response
Did you search for similar issues before submitting this one?
No, I didn't
Operating System
Windows
Architecture
x86_64
Version
v6.7.7
How are you running ddns-go?
Service
Any other information
No response

账号密码都没输入？

开启公网访问对密码要求较高，设置一个复杂的密码


Upgrade nuget packages, use the Azure Search .NET SDK where possible

A recent release of the Azure Search .NET SDK has made it possible for this demo to be written using the .NET SDK support for cognitive search instead of raw json and http requests.  This change upgrades all nuget packages to the latest version as well as switches all of the upserts for the skillset, index, and indexer to use the .NET SDK since the latest api version is now support with it.

@arv100kri can you take a look when you get a chance?  Had a couple of cycles available to finally close on this, works great with SDK version 10.0.0 :)


Send all users registration email

Should we allow users to register themselves? It will be easier in the sense that we don't have to track down everyone's email like we did last time. The nice thing about that was we could be sure that only the right people were allowed to register.

We'll take the same approach as last time, but we'll allow the staff / admin to add accounts as well.

User accounts created already, but need to set up views for change password / change username and then send everyone their email.


[Feature request] Prioritize certain patterns

Hello, I'd like to have a feature where you could set priorities with patterns
For example, in CMake projects you can have subdirectories having CMakeLists.txt, but project should be set to the "parent" one, one solution cound be adding some file like .project_root

+1


Fix tests

@Karsten-Fyhn

@twopirllc: Even with the changes you made to uses unittest instead of pytest, I am still struggling with failing tests :( I have made this draft PR: #601 to exemplify. Both in the pipeline and locally, I keep failing on this test: test_custom_a_with_multiprocessing (tests.test_study.TestStudyMethods) - is this a test I can easily fix somehow? Or should it be skipped instead?

Weird. It passes my local tests and when I push to development (as you have seen), yet not on your end. 🤔
Have you checked the test_study.py if the tear_down() method is clearing the added columns in the test before test_custom_a_with_multiprocessing()? In the test results, it looks like it has All the columns added in your run.
The study tests ought to run on GHA, but if they are not working in all cases... it may be prudent to ignore the study tests for the time being.


New release and Building instruction?

Is there a plan for a new release now?
What about building order and compiler to be used?
clang 3.1+, gnustep-make, -base, gui, back, libobjc2 or libobjc2 first?
(found the clang 3.1+ ref at https://en.wikipedia.org/wiki/Objective-C#Blocks)
However Debian (sid) has 6.0, 7, and 8
There is
https://github.com/gnustep/libobjc2/blob/master/ANNOUNCE.1.9 but I
can't find anything under releases...
Some distributions ship 1.8:
https://repology.org/metapackage/libobjc2/versions

I guess I missed the deadline for Debian.  The 2.0 branch is now packaged on FreeBSD and getting some testing.  It's been far too long since the last release, so I really need to push both of them out soon...

Absolutely missed it! However, I'm still looking forward to 1.9 and 2.0 to try them personally, have a Debian package (the next stable release will be in 2-3 years) but that shall not hinder anyone to use this newer version building it all themselves.
My Plan was if all works well to use 1.9 (or 2.0 if clang versions allow), and bring out http://livecd.gnustep.org/ GNUSTEP-3

Ping, any news?

I am happy to package the 2.0 branch on FreeBSD, because I am testing it there.  I am not going to do any official releases until I hear back from other people testing and reporting success.

So I will grab a daily co and try?

Please do.  If Debian and FreeBSD both work with the 2.0 release, then I'm much more confident about doing a proper release.

I'm not sure what dh_install is, but libobjcxx.so is gone.  For backwards compatibility, you can install a symlink to libobjc.so if you want.
The 1.9 branch will be released as 1.9, trunk will be released as 2.0.  Note that BFD ld probably doesn't link the 2.0 ABI correctly, you will need to use lld or gold (and a few things don't work with LLD).

Will it be enough to just have lld installed? Or must it be called "ld"? I mean does your build system try to run lld if it's there, falling back to ld?
No idea what "gold" is?

You may need to add -fuse-ld=lld to your the linker flags.

I have now pushed releases from the 1.9 and 2.0 branches.


Generic record example is added. [API-1164]

generic-record example is added.
It is ported from nodejs client.

Linux test FAILed.

Linux test PASSed.

Windows test PASSed.

Linux test PASSed.

Windows test PASSed.


Highlight corresponding course in calendar when hovering over that course in the saved courses list

my schedule looks like this rn and i cannot for the life of me figure out which course is which T_T
when i hovered over courses on the saved courses list, i was hoping it would highlight the corresponding courses on the calendar
but alas it does not
and when i hover over the course in the calendar, i still can't see its name, so i actually can't figure out what courses are at what time on my calendar right now unless i inspect element n mess w stuff

It does bidirectional highlighting now. I've decided not to implement tooltips on hover because it would make quality of experience worse for everyone who doesn't overload their schedules like this lol (this is not the intended purpose of the app 😭  do you want to bring the pin feature back?)

truuu dat
nah im just stress testing it on g
wahts the pin feature


Initial replication factor for internal data

Fixes #3840.
Also fixes some images, which were pulling from the wrong version directory.

This change is

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/e2f1ac3df8fdd113300db91e2e368c80d5cc7cb9/

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/594272f7441345ce35539243a69fdab23e16a5b0/

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/dc2eff841e02f41f4e8ef46c0fc8ea0fe0ccb0fd/


edge gateway agent (code)

Implement the design in #48

replaced with component-wise tasks #63 #64 #65


Upload QuadrantAssets

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

[ 0x3da6C7db68f17E72CE153E485E453922f46B1d4a ]
[ 0x3da6C7db68f17E72CE153E485E453922f46B1d4a.png ]

@QuadrantAssets please follow the guidelines!
Size 256 by 256 and lowercase filename

@QuadrantAssets  Please provide correct image!


Update useful_tools.md--fix image 'loss_curve.png' path error

fix image 'loss_curve.png' path error

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


assembler: ensure progress when seeking the version string

When trying to parse SPIR-V version from assembly comments, ensure a match against an initial comment doesn't cause the scanner to go back to the beginning of the assembly text.
Fixed: #5909

cc: @cassiebeckley @alan-baker


ivan: 056 -> 057

Motivation for this change
IVAN version update
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

@GrahamcOfBorg build ivan

@GrahamcOfBorg build ivan

@mmahut Thanks! :alien:


cannot proceed further with mvn clean install package

Followed the steps mentioned http://capitalone.github.io/Hygieia/setup.html
while trying mvn clean install package- i get the below error:
Execution default-test of goal org.apache.maven.plugins:maven-surefire-plugin:2.18.1:test failed: The forked VM terminated without properly saying goodbye. VM crash or System.exit called?
I tried mvn clean install -DskipTests and I get below error:
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.5.1:compile (default-compile) on project hygieia-publisher: Compilation failure
[ERROR] java.nio.file.NoSuchFileException: /Users/xx/xx/Hygieia/hygieia-jenkins-plugin/target/classes/META-INF/annotations/hudson.Extension
[ERROR]
I will appreciate any help here
I am using java 10.0.1

@Mohitg06 - we support java 1.8.x

@matthewbeasley , ok so I will have to downgrade to java 1.8 x correct?

Yes..


LdGraphstore: Deleting nodes does not update their siblings nor their parents

Guidance
This is a Left-Child Right-Sibling based 256-bit vectorized tree of 64-bit values. We need to update the tree properly.
This uses AVX.
Expected state
{:ok, db} = LdGraphstore.Native.db_create() # Create LdGraph
LdGraphstore.Native.db_put(db, 1) # N2
LdGraphstore.Native.db_put(db, 1) # N3
LdGraphstore.Native.db_put(db, 1) # N4
LdGraphstore.Native.db_put(db, 1) # N5
{:ok, n4} = LdGraphstore.Native.db_get(db, 4) # Get N4
{:ok,
%{
    __struct__: LdGraphstore.Native.TreeNode,
   child: nil,
   parent: 3,
   sibling: 5,
   this: 4
}}
LdGraphstore.Native.db_del(db, 5) # Remove N5
{:ok, n4} = LdGraphstore.Native.db_get(db, 4) # Get N4 again
%{
    __struct__: LdGraphstore.Native.TreeNode,
   child: nil,
   parent: 3,
   sibling: nil, # Notice the "nil"
   this: 4
}}

Actual state
{:ok, db} = LdGraphstore.Native.db_create() # Create LdGraph
LdGraphstore.Native.db_put(db, 1) # N2
LdGraphstore.Native.db_put(db, 1) # N3
LdGraphstore.Native.db_put(db, 1) # N4
LdGraphstore.Native.db_put(db, 1) # N5
{:ok, n4} = LdGraphstore.Native.db_get(db, 4) # Get N4
{:ok,
%{
    __struct__: LdGraphstore.Native.TreeNode,
   child: nil,
   parent: 3,
   sibling: 5,
   this: 4
}}
LdGraphstore.Native.db_del(db, 5) # Remove N5
{:ok, n4} = LdGraphstore.Native.db_get(db, 4) # Get N4 again
%{
    __struct__: LdGraphstore.Native.TreeNode,
   child: nil,
   parent: 3,
   sibling: 5, # This is invalid!
   this: 4
}}

I'm thinking this is fixed.

I'm thinking this is fixed.


This adds a duck type representing the common shape for Bindings.

For more information, see here.

/lgtm


Updates 'options' in componentDidUpdate

In previous version, it looks like options were being updated everytime in componentWillRecieveProps. But it was removed and options were not being applied if they were updated.
I can elaborate the use case if you want.

Coverage increased (+0.04%) to 77.258% when pulling 044c7033087678932a6f03af61d4969ab9d8c7de on noobtiger:master into 2b508722db834843007970c9c8c9c1d9d930cad5 on gregnb:master.

Hello. Can you describe what was broken before this PR and what this PR fixes with a specific example?

So we have a custom toolbar setup which returns a react component and the react component props are passed from the parent component.
function ReactComponent(props: Props) {
 const [count, setCount] = React.useState(0);
  const options = {
    customToolbarSelect: () => {
      return (
        <div>
          <CustomComponent count={count} />
        </div>
      );
    },
  };
 return (
      <MuiDataTable
        {...props}
        options={options}
      />
 )
}

In the above example, initial load works fine, but if the count prop is updated, the value doesn't get reflected in the custom toolbar.
I looked at the code, it looks like the customToolbarSelect function gets executed and it loses the closure chain, so the value change doesn't get reflected. In the previous commits, the options gets applied every time because initializeOptions is called on every update. This was removed in the current commit and initializeOptions is only called on initial load.
The change here will merge the options on update.

@noobtiger Thank you, but there's still not enough for me to reproduce on my end.
I added
  updateCount = () => {
    let { count } = this.state;
    count++;
    this.setState({ count });
  };

  ...

  <Tooltip title={"Count"}>
    <IconButton className={classes.iconButton} onClick={this.updateCount}>
      <CompareArrowsIcon className={classes.icon} />
    </IconButton>
  </Tooltip>

and can confirm that count is updated. Maybe a codesandbox example would help?

I'm working on a project where we try to update the MUIDataTable options during a state change. The changed options do not get reflected in the table. Here is a codesandox my co-worker created to demonstrate: https://codesandbox.io/embed/eloquent-chaplygin-fb0y3
As you can see, clicking the button at the top toggles isDownloadable in state, and getTableOptions is being called on component re-render, but the download icon in the table is not being removed & added upon options update.

@Beamanator Thank for the example and the explanation. Will review next time I get a chance.


Add Generator as Equipment subclass

Motivation: Generator equipment is fairly common in commercial real-estate. The inclusion of Generator as a Brick subclass of Equipment would further the capacity for Brick to represent physical building assets and relationships.
Scope: At the very least, the inclusion of Generator as a subclass of Equipment is requested. Where specifically in the Equipment hierarchy this subclass should be included is left to the subject-matter experts. Additional subclasses of Generator (e.g., PV Generator, Diesel Generator) may also be appropriate.

Hi @emesar --- thanks for the suggestion!
I think we can add Generator in a post 1.3.0 release of Brick. Would you be able to provide some initial definitions for different subclasses of generators that you would like to see added to Brick?

Emergency Backup Generator is something I've encountered reasonably often - although that's more a role than a class, i.e. it's probably a Diesel Generator that acts as a backup (as opposed to a PV system that's a primary source of energy). I guess you could also consider primary/secondary as a role tag, i.e. primary or secondary hot water pump?


Latest updates as of 21-03-22

Tina, I'm not sure what this pull request does. I'm leaving it unmerged for now


chore(MeasureTheory/Constructions/Prod/Basic: split

There were two things going on in this file:

Measurability according to the product sigma-algebra
The product measure

The former can be defined much earlier than the latter, in particular without importing Measure.

Yes, I noticed so. The situation is that I need the lemmas earlier myself in #17097.

There are a few (very simple) changes in there that are not just a move. Please don't do that in a "split/move" PR as when I see those I then think that there might be other changes and the review process switches from simply checking that the moves make sense to reading the whole code to check for other minor changes.
But otherwise LGTM.
bors r+


feat: add icons for Assembly files (*.S and *.asm)

Hi, you need to move to the icons_by_file_extension table

oh, my bad. (fixed)
the thing is *.S files are GNU and *.asm files are usually nasm so they are not the same (kinda).
I'm not sure myself which one to use so I put them both. Which one would it be, then 'ASM' or the 'chip' one?

Not sure how much changes between different architectures, personally I immediately thought of micrcontrollers.

P.S. what about nvim-web-devicons.lua? Your guidelines say I have to add new icons to

Not all types of files have a defined "filetype" on neovim, but yeah should be checked. In this case seems to be a asm.vim but not s.
I checked with ls /usr/share/nvim/runtime/ftplugin/

both code.S  (GNU Assembler) and code.asm (nasm, fasm, etc.) are recognized  by NeoVim so I'm not sure what you meant. Since you mentioned 'ASM' icon is easier to read, I've replaced the 'chip' one with it.

You need to change the "S" to lowercase. Also add asm to filetype,
Regarding other filetypes I made a PR #531 to fix the other ones.

isn't it supposed to be uppercase? Here for example https://github.com/torvalds/linux/blob/master/arch/x86/boot/copy.S
I thought it's a weird gas naming convention. Whatever I did as you said.

Yes, it should be uppercase but it wasn't working that way, now it works.


Fix link in mastodon topic

[x] I followed the contributing guidelines: https://github.com/github/explore/blob/master/CONTRIBUTING.md

I am:

[x] Suggesting edits to an existing topic or collection
[ ] Curating a new topic or collection

EDITING AN EXISTING TOPIC OR COLLECTION*
I'm suggesting these edits to an existing topic or collection:

[x] Image (and my file is *.png, square, dimensions 288x288)
[x] Content (and my changes are in index.md)

Please explain why these changes are necessary:
well the link is not working otherwise xD

Thanks so much for your contribution!  You rock, @connyduck!


How do world coordinates of hands formulated?

It is said that handmarkers are presented in the world coordinates.
How do that coordinate system formulated? What are the directions of the X-axis, Y-axis, and Z-axis?
Is the origin at the wrist (landmark 0)?
Thank you for taking  time to look at this issue.

I have the question too, it is of great help to me if there is someone solve the question.


added support for VectorDrawable

Added support for VectorDrawable in drawableResId() and drawable() methods

fixes issue #12


Use only chefdk on bootstrap

This resolves recent gem issues and version mismatches we've had during builds.  Also fixes long outstanding issues of gem and ruby runtime mismatches

Unfortunately I am still getting
You cannot specify the same gem twice with different version requirements.
You specified: ridley (>= 0) and ridley (= 5.1.0)

Wll remove ridley from the root Gemfile


fix #4569: clang warning about deprecated sprintf usage.

This fix is intended to remove a warning from the clang compiler. It switches the usage of sprintf function into the recommended snprintf function.
Fix #4569

High Level Overview of Change

Context of Change

Type of Change

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] Refactor (non-breaking change that only restructures code)
[ ] Tests (You added tests for code that already exists, or your new feature included in this PR)
[ ] Documentation Updates
[ ] Release

Here is the related issue: https://github.com/XRPLF/rippled/issues/4569

for next week: check if seelabs will be able to review this

Okay, I messed up the git commands. I want to sign the first "unverified" commit. But I have already merged the latest develop into my feature branch.
I did a rebase and then exec git commit --amend --no-edit -S to sign my first commit, but that seems to pull it many unrelated commits into this PR :/

That's because you rebased all of the subsequent commits. Let's meet up this week and try to fix this :)

@ckeshava : can you resolve the conflict?

apologies, I made a mess out of the commit history.  I have created a cleaner PR here: https://github.com/XRPLF/rippled/pull/4747


Silent the user warning of sklearn during inference

Currently when performing inference with the random forest model, we receive the following warnings (e.g. check cell 39 in this notebook):
/home/qiahan/.conda/envs/firstEnv/lib/python3.9/site-packages/sklearn/base.py:439: UserWarning: X does not have valid feature names, but RandomForestRegressor was fitted with feature names
  warnings.warn(

This is caused by the fact that the training data is pandas dataframe with feature names, and the testing data is numpy array without feature names:
...
    CO2_line = ds_ss[8,:,:,:].to_numpy().reshape(1, ds_ss.latitude.size*ds_ss.longitude.size*ds_ss.time.size)
    SSM_line = ds_ss[9,:,:,:].to_numpy().reshape(1, ds_ss.latitude.size*ds_ss.longitude.size*ds_ss.time.size)

    features_arr = np.concatenate((Rin_line, Rli_line, p_line, Ta_line,ea_line, u_line, Precip_msr_line,
                                   LAI_line, hc_line, CO2_line, SSM_line, Vcmo_line,
                                   IGBP1, IGBP2, IGBP3,IGBP4,IGBP5,IGBP6,IGBP7,IGBP8,IGBP9,IGBP10,IGBP11))
    features_arr = features_arr.transpose()
...
    model = load_model(path_model)

    # model = path_model
    estimated_LEH = model.predict(features_arr)
...

Here is a similar issue with solution on stackoverflow. To fix this, we need to turn features_arr into pandas dataframe with feature names as column names.

Thanks Yang for your advice, I will fix this problem soon.


Data is not show in pgbconsole

pgbconsole: 2015-09-22 15:05:47, load average: 0.32, 0.42, 0.39
      %cpu: 12.7 us,  4.9 sy,  0.0 ni, 82.4 id,  0.0 wa,  0.0 hi,  2.9 si,  0.0 st
 console 1: localhost:5432 karoo@karoo   connection state: ok
 pgbouncer: pools: 0     databases: 0     clients: 0     servers: 0

The user name is not admin. I'm sorry.