Node Modules Not Installed after 'foundation new' on Windows

Expected Behavior

I am using Windows 10
I am trying to create a new foundation project, following the installation instructions on the 'foundation for sites' page, version 6.7.4, using this URL
[(https://get.foundation/sites/docs/installation.html)]
I have installed foundation-cli using the command
npm install --global foundation-cli
I have node.js installed. Typing node -v yields v16.3.0
I use Visual Studio Code, and open a new blank folder. I open a terminal (the same result arises with Windows Powershell)
I try to create a new project by typing
foundation new
I expect to get a new working site
...
Current Behavior

I am asked whether I wish a basic or email template and select 'a Website (Foundation for Sites)'
I entitle the project mysite
I am asked which template I wish to use and select Basic Template
mysite is created, but the script reports the error
 Node modules not installed. Try running yarn install manually.
I type
cd mysite
npm install
(I have repeated using the suggested yarn install but the result is the same)
The install reports errors: the central such seems to be a problem with my version of Python - it faults a line written in Python2 syntax, thus:
npm ERR! gyp ERR! stack Error: Command failed: C:\Python310\python.EXE -c import sys; print "%s.%s.%s" % sys.version_info[:3];
...
Possible Solution

there are two issues.
The first is that node_modules is not installed in the project. I don't know why this fails
The second is that when trying to install this manually, the install script conflicts with my version of Python (3.10.0)
Maybe this can be fixed with a Python2 installation.
Or, maybe the script can be modified so it provides for a Python3 installation.
I'm new to foundation, so I don't have any other suggestions.
...
Test Case and/or Steps to Reproduce (for bugs)

Test Case:

How to reproduce:
1.npm install --global foundation-cli
2.foundation new
3.select 'A Website'
4.select 'Basic Template'
PS C:\Users\afree\Documents\Github\foundation> foundation new ? What are you building today? A website (Foundation for Sites) ? What's the project called? (no spaces) mysite ? Which template would you like to use? Basic Template: includes a Sass compiler
Context

I wanted to create a fresh foundation sites install
...
Your Environment

Foundation version(s) used: 6.7.4
Browser(s) name and version(s):  no browser
Device, Operating System and version: PC, windows 10
Link to your project: couldn't create one

Checklist

[x ] I have read and follow the CONTRIBUTING.md document.
[x ] This is a bug report or a feature request.
[x ] There are no other issues similar to this one. (the nearest I could find was #11776)
[x ] The issue title and template are correctly filled.

For a less headache solution, just use the manual setup steps, here is my suggestion:

Install Yarn globally -> npm install -g yarn
git clone https://github.com/foundation/foundation-zurb-template your-projectname
cd to your-projectname
yarn (Just run the yarn command in the command line and let the process complete)
After the completion of step 4, run 'yarn start' to start building.

The result will be the same, or maybe even more faster than running the 'Foundation watch' (at least that what I have experienced thus far).
I hope that helps you.

For a less headache solution, just use the manual setup steps, here is my suggestion:

That is exactly the same, what the CLI does.
Please run npm i -g windows-build-tools to have Python 2 (needed by Node itself for compiling binary dependencies / packages like node-sass).

Please run npm i -g windows-build-tools to have Python 2

I did that, but the result is still not good.
'Foundation new' will only create the template without the Node Modules.
I am using windows 10, node v16.3.0 with npm v7.15.1 and Foundation CLI v2.3.0
Refer attached shot

Please try npm i manually or yarn (if it is installed) to see the actual errors.

I did npm i, still within the same environment as the previous one.
The result is in the attached shot:

But then, the build tool running perfect via Yarn.
Refer attached shot:

Your Node version is probably too new.

Yarn is just an alternative package manager instead of npm. You should check if everything works with Node 14.

At least Node 12 should work. See https://github.com/foundation/foundation-sites/actions/runs/1414129515

Your Node version is probably too new.

I see. I will try to check the installation again with different node environment as suggested above.
But as at this point I am kind of loving Yarn more and more. The time it took to initialize the build-tools is very impressive.
Will report back here the result when I'm done experimenting with the recommended node version.
TQ.

Thanks for all these kind offers. Since there is still some experimentation going on, I will wait a bit. I will try the following
(a) 'pure yarn' as Kebalz suggests https://github.com/foundation/foundation-sites/issues/12329#issuecomment-968076839
(b) Install Python 2
(c) Node 12.
I did already try a number of different routes to get the install, but without success.
I didn't realise at the time but it seems that ZURB is no longer supporting Foundation - a pity if it's true.

The Yarn procedure @kebalz posted will work for you.
@axfreeman I worked through all the installation issues you mention.
Check out the solutions I discovered here #12317

Generally yarn is not required to get it working. Also please always use the windows-build-tools and then open a new terminal session. npm audit fix is generally problematic in most projects. Regardinf'g the primordial issue, this is well known (please search the issues and stackoverflow). It means that your Node version is too new. Node 12 or 10 is supported.

@DanielRuf thank you !
So bottom line: The Foundation installation procedure needs a bigtime workover to iron out all the issues users are encountering.

Afaik the new maintainer is currently working on it. Besides this, you can always switch to a different Node version with nvm, nodenv, n or any alternative solution.

(a) 'pure yarn' as Kebalz suggests #12329 (comment)

The conclusion to the installation test that have been run by @ITZAP really reflecting my experience after upgrading the CLI and the node.js.
Now  I just use the CLI to generate the folder structure and then Yarn to get the Node_modules and to initialize the Build-Tools. The solution works great.
Currently using windows 10, node 16.3.0, npm 7.15.1, Foundation-cli 2.3.0

I did already try a number of different routes to get the install, but without success.
To @axfreeman, you might want to check your git version. I currently run git version 2.24.0.windows.2 . Not sure whether that will make any different to your situation. but just in case.

Node 12 & 14 are currently functional. In order to support newer versions of node, a lot of work would need to be done to determine which dependencies are breaking on Node 16+. If anyone would like to assist in figuring that out, a PR would be much appreciated.

Thanks all. I'm a newbie to JS frontend coding in general so on a learning curve. The discussion is helpful, thanks to all. I've studied @ITZAP's post  #12317 which I'd recommend to anyone studying this thread, and I will try downgrading node and git. I hope this thread has been useful to the maintainers. @DanielRuf https://github.com/foundation/foundation-sites/issues/12329#issuecomment-970850851 what search terms would get me to relevant posts on the primordial issue? I did some searching just using the error message, but didn't come across much, which is why I started this thread.

@axfreeman git is not the problem and should not be downgraded. Same for Node.
In this case install an older version with nvm and switch to it, so other projects can still use new Node versions.
Regarding "primordials is not defined":
https://www.google.com/search?q=primordials+not+defined+stackoverflow
https://github.com/foundation/foundation-sites/search?q=primordials&type=issues
https://stackoverflow.com/questions/56245622/foundation-referenceerror-primordials-is-not-defined-when-starting-a-foundat/56253873#56253873

@DanielRuf thanks. I see what the problem is now.


Add backend event images

Add migration system to the backend, including backwards-compatibility with already-initialized databases
Add model/schema for event images

@bCyberBasti I will be out-of-town over the weekend, so if you want to start on gathering the images and there are no issues with the code feel free to merge. If we need something changed before merging I'll try to find some time to implement changes.
Closes #108.

The DeepSource stuff are non-issues as the function signatures are merely following a third party interface spec. The same is true for some issues it opened automatically because we have function signatures following Scrapy's spec. @bCyberBasti maybe you can add some ignore flags for backend/migrations and backend/mj/spiders to the DeepSource config.
@ubergesundheit Could you add the re-generated API client?


PrecedenceGroupRelationSyntax.higherThanOrLowerThan should be named higherThanOrLowerThanKeyword

Description
The current name is inconsistent with PrecedenceGroupAssignmentSyntax.assignmentKeyword and PrecedenceGroupAssociativitySyntax.associativityKeyword.
Steps to Reproduce
No response

Tracked in Apple’s issue tracker as rdar://110482259


merge op implementation for power_fp into power

merge op implementation for power_fp into power
TT Metalium supports tt_lib.tensor.power(tensor, exponent) where exponent is positive integer and tt_lib.tensor.power_fp(tensor, exponent) for positive fractional exponent.
These should both be supported via same interface.

Raised the PR #4555

Merged to main


woa a color cmd

Appreciate the effort but we plan on making colors only available after certain milestones are reached.
The current implementation is also pretty wasteful: it creates an array and unnecessarily loops through it.
A better solution would be a simple matcher inside a FromStr implementation, which can be trivially implemented without strum.


Cannot install nodegit on linux machines (e.g. travis builds)

/usr/lib/x86_64-linux-gnu/libstdc++.so.6: version `GLIBCXX_3.4.20' not found (required by /home/travis/build/runspired/ember-cli-changelog/node_modules/nodegit/build/Release/nodegit.node)

Probably a duplicate: https://github.com/nodegit/nodegit/issues/758#issuecomment-155232550

An incorrectly closed PR which assumed this issue was no longer present: https://github.com/nodegit/nodegit/pull/744

We're still linking our prebuilts to a newer gcc. If you build it from source it should work fine. Try:
BUILD_ONLY=true npm install nodegit

I was able to get the project directly consuming it to build (both with and without master) by following the travis-addon instructions in the above PR.
However, setting the dependency to master results in failed builds for projects consuming another project which has nodegit as a dependency.
See: https://travis-ci.org/runspired/ember-hammertime/jobs/100523335

You're getting a node-gyp error because that build is still using old gcc.
We might need to make gcc 4.9+ a requirement for nan anyways since for node versions 4+

@johnhaley81 I did, I can make Travis pass for that repo (and that repo only) with each test scenario taking an additional 6-10minutes to run :'(
But a secondary issue arises when that repo is a dependency of another project.  It's code will never be executed on Travis, but nodegit must be a dependency.  This results in consuming projects also needing to configure Travis specially for a dependency that's unneeded during testing, with ridiculous build times if you do.

I'm also seeing this error trying to run a project using nodegit in Elastic Beanstalk.

I can confirm this is still an issue with 0.7.0 build.

@runspired if you setup your travis env to use the latest gcc 4.9, you shouldn't have to compile anything to make this work and your builds should take hardly any longer.

I received this error myself when installing NodeGit on Ubuntu. So I followed my own advice above and installed both GCC 4.9 and the libstdc++-4.9-dev packages by doing:
sudo add-apt-repository ppa:ubuntu-toolchain-r/test
sudo apt-get update
sudo apt-get install g++-4.9 libstdc++-4.9-dev

Pre compilation linked libraries:
λ ldd node_modules/nodegit/build/Release/nodegit.node
node_modules/nodegit/build/Release/nodegit.node: /usr/lib/x86_64-linux-gnu/libstdc++.so.6: version `GLIBCXX_3.4.20' not found (required by node_modules/nodegit/build/Release/nodegit.node)
	linux-vdso.so.1 =>  (0x00007fffdabd5000)
	libstdc++.so.6 => /usr/lib/x86_64-linux-gnu/libstdc++.so.6 (0x00007f7309f02000)
	libgcc_s.so.1 => /lib/x86_64-linux-gnu/libgcc_s.so.1 (0x00007f7309cec000)
	libpthread.so.0 => /lib/x86_64-linux-gnu/libpthread.so.0 (0x00007f7309ace000)
	libc.so.6 => /lib/x86_64-linux-gnu/libc.so.6 (0x00007f7309709000)
	libm.so.6 => /lib/x86_64-linux-gnu/libm.so.6 (0x00007f7309403000)
	/lib64/ld-linux-x86-64.so.2 (0x00007f730ad03000)

Run the build with:
BUILD_ONLY=true npm rebuild

Post compilation linked libraries:
λ ldd node_modules/nodegit/build/Release/nodegit.node
	linux-vdso.so.1 =>  (0x00007ffe26c6a000)
	libstdc++.so.6 => /usr/lib/x86_64-linux-gnu/libstdc++.so.6 (0x00007f4d5b9ea000)
	libpthread.so.0 => /lib/x86_64-linux-gnu/libpthread.so.0 (0x00007f4d5b7cc000)
	libc.so.6 => /lib/x86_64-linux-gnu/libc.so.6 (0x00007f4d5b407000)
	libm.so.6 => /lib/x86_64-linux-gnu/libm.so.6 (0x00007f4d5b101000)
	/lib64/ld-linux-x86-64.so.2 (0x00007f4d5c46a000)
	libgcc_s.so.1 => /lib/x86_64-linux-gnu/libgcc_s.so.1 (0x00007f4d5aeeb000)

So yes, you'll definitely need to rebuild if it's not working out-of-the-box.

You can do this in Travis-CI by adding the following to your .travis.yml file:
addons:
  apt:
    sources:
      - ubuntu-toolchain-r-test
    packages:
      - libstdc++-4.9-dev

we are also hitting same issue

Error: /usr/lib64/libstdc++.so.6: version `GLIBCXX_3.4.20' not found (required by /data/jenkins/workspace/master/node_modules/nodegit/build/Release/nodegit.node)

Is there any solution  for centos-release-6-7 OS?

@hridyeshpant any solutions on this ?

Don't think installing libstdc 4.9 solves the issue
this is on ubuntu 14.04
$ sudo apt-get update
$ sudo apt-get install libstdc++-4.9-dev
<EMAIL_ADDRESS>node_modules/nodegit
├──<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>└──<EMAIL_ADDRESS><EMAIL_ADDRESS>/output/node_modules/nodegit/lib/nodegit.js:14
    throw ex;
          ^
Error: /usr/lib/x86_64-linux-gnu/libstdc++.so.6: version `GLIBCXX_3.4.20' not found (required by /output/node_modules/nodegit/build/Release/nodegit.node)```

Is there any solution for centos-release-6-7 OS?

BUILD_ONLY=true npm install nodegit solved the problem for me on centos7. Thanks to https://github.com/nodegit/nodegit/issues/853#issuecomment-169240445

Is BUILD_ONLY=true npm install nodegit the same as npm install nodegit --build-from-source?

Not quite, there is a bit more to it that we do.

So what's the solution for this? I'm trying to run a project on elasticbeanstalk and it's failing with the same issues.

@chalangr12 solution for what? We can't build for every single architecture unfortunately, only popular ones. Can you try and suss out what dependency is causing your failure? Is it glibc?

i think the issue people are running into is that on centos at least libstdc++-4.9 isn't in the normal repos


What about languages?

Hello Dear Developers
Do you planing add languages into game and web page client?
Best Regards
Mateusz

Well, I think that's a good idea. Perhaps you could translate the front page: https://github.com/huytd/agar.io-clone/blob/master/client/index.html

I can handle all needed translations to pt-br

The german "index.html" is now ready to publish.
Where can I submit my German Frontpage?

I can handle tranlations to italian

Maybe we could use i18next? https://github.com/i18next/i18next
And something like oneskyapp as translate platfowm.


Question on inference test

Hello !
I tried to run inference to compare to other VSR networks, but I run out of memory where other networks worked.
What I do is: in a notebook prepare 20 frames of 512x384 and feed this to the model.
This crashes with OOM on GPU w 24GB CUDA memory. At home I don't have bigger GPU.
So does your model require more memory or I am not testing it like it should be done ?
AFAIK the more frames you feed at once, the better result can be expected, is this true ?

Based on the current dataset results, we found that the longer the input sequence, the better results we can obtain.
we use 32GB V100 or 40GB A100 for testing.

Thank you for clarification and keep the good work!
I close this issue as solved.


New guide: Enabling HTTPApi plugin

Description
Add guide:

How to enable the HTTPAPI plugin
how to make API calls from the client (Lisks APIClient has no option to create an HTTP client, so explain how to send requests to HTTP API

Additional information

Closing because HTTP API plugin is removed


Bump @types dependencies to latest versions

Bump @types/node from 20.3.2 to 20.3.6
Bump @types/react from 18.2.14 to 18.2.21
Bump @types/react-dom from 18.2.6 to 18.2.7
Bump @types/prettier from 2.7.3 to 3.0.0
Bump @types/source-map-support from 0.5.6 to 0.5.7

@schickling


Auto completion does not work on Pop OS 20.04

Hello, first of all I want to thank you for this really great project. I backed it yesterday and I am not disapointed, however I can't get the autocompletion to work which is annoying.
I read that autocompletion should be enabled by default, and should work out of the box. Then I don't really know what to do to make it work.
I tried oni2 -f and oni2 -f --checkhealth to see if something was not loaded correctly, but it seems that everything is fine.
The build I'm using is Onivim 2 (0.5.0) (output of --version).
I installed oni2 by downloading the tarball and running the AppRun executable. I tried with the last nightly build too, with the AppImage. No one worked.
I tried CTRL-n to make the autocompletion menu show up, even if it should happens automatically: this does not work either.
Anyway I think this project will be awesome, that's why I'm backing it. Maybe I'm missing something, but I do not see what to do at this point.

Hi!
What project/language is this on? We ship with built in support for Reason/OCaml and JS/TS I think, and then for any other language you'll need to install an extension (as well as any dependencies of that extension). We have some tested extensions written up in the user manual for a few languages : https://onivim.github.io/docs/languages/reason-ocaml.
If a language is missing from there, it doesn't mean it won't work, just that its not a language we've tested, though we welcome documentation contributions to extend the languages listed there. Usually, it should be a case of finding an extension in Oni2 (or possibly on the VSCode marketplace itself if its missing from Oni2), and installing that. That process is here: https://onivim.github.io/docs/configuration/extensions.

It was for C, but thanks now it is fixed thanks to clangd. I was thinking that a kind of "basic" autocompletion should be available (like vim one) but nevermind, I did not read the manual accurately.

Ah! We have a separate issue for hooking up the most basic "Please just suggest words that exist in this buffer/open buffers" since that should just be available for everything as you've said. https://github.com/onivim/oni2/pull/1227 is an experiment around that, or #1862.
Language specific stuff we can't really include, as it could end up being more confusing if we included the C++ ext, but you'd still need some stuff installed locally etc. In which case, you don't get to see/know about the extension or its documentation, so you wouldn't know necessarily to install anything. Reason/OCaml is a bit different as that is easy to include and Oni2 is written in that. Same for JS/TS, since we already have node for the VSCode extension host, that is "free".


Unhandled Exception: PlatformException(STORAGE_NOT_LEGACY, Use requestLegacyExternalStorage when your project is targeting above Android Q., null, null)[BUG] Error with something

[ERROR:flutter/lib/ui/ui_dart_state.cc(209)] Unhandled Exception: PlatformException(STORAGE_NOT_LEGACY, Use requestLegacyExternalStorage when your project is targeting above Android Q., null, null)
E/flutter (30707): #0      StandardMethodCodec.decodeEnvelope (package:flutter/src/services/message_codecs.dart:607:7)
E/flutter (30707): #1      MethodChannel._invokeMethod (package:flutter/src/services/platform_channel.dart:177:18)
E/flutter (30707):
E/flutter (30707): #2      PhotoManagerPlugin.requestPermissionExtend (package:photo_manager/src/internal/plugin.dart:68:24)
E/flutter (30707):
E/flutter (30707): #3      AssetPicker.permissionCheck (package:wechat_assets_picker/src/widget/asset_picker.dart:24:33)
E/flutter (30707):
E/flutter (30707): #4      AssetPicker.pickAssets (package:wechat_assets_picker/src/widget/asset_picker.dart:39:33)
E/flutter (30707):
E/flutter (30707): #5      Common.openPic (package:xapp/utils/common.dart:145:40)
E/flutter (30707):
E/flutter (30707): #6      _CreateWorldWallPageState._getImage (package:xapp/pages/faxian/child/createWorldWell.dart:61:38)
E/flutter (30707):

#28

@CarminBack add this in your manifest
    <application
            android:requestLegacyExternalStorage="true"

@CarminBack add this in your manifest
    <application
            android:requestLegacyExternalStorage="true"

This does not work when targeting SDK > 30

+1 to this, adding
<application         android:requestLegacyExternalStorage="true"
doesn't work, gives the same error the author of this issue has posted.

TBH, the author of this issue, and the people who said "it's not working", should learn how to read documents and the example hard, since all of these are working fine. :)


Install

Just make sure that the freeeed_complete_pack.zip works in all environments. Also, update the install documentation, make its simple and recommend coretto


fixing some issues in plot_history_alive

cc @erikvdp for review please.
I was playing around with the new plotting (with data from load_transaction_data) and encountered these bugs. Just to confirm, can you share your pandas version too? Mine is 0.15.1.

Hi, my pandas version is 0.15.2.
The changes look good to me since you can't assume that the datetime_col is already in the right format, good catch.
P.S. Can I ask you how your typical workflow looks when you are developing for lifetimes, or any other python library? I usually write my code/functions out in a python notebook before trying to incorporate them in the library (which is loaded as a project in my IDE).  However, I feel that this can easily lead to bugs like this. Do you have a better approach?

My approach is usually as follows:

start in a text-editor with the library. Write a bit of code. If you get stuck with a some complicated pandas logic or some python syntax, go to the ipython shell and play around there to get it, then return to the text editor.
once done the first version, go to Ipython shell, import the new code, and play around with it. Is it as you expect?
repeat 1 & 2 until happy.
write tests.


Inconsistent implementation of min_max_speed_naive in different equations

I realized that the implementations of the wave speeds of the 2-wave HLL solver are not consistent across different equations.
Take for instance the 1D compressible Euler equations where the 2-wave HLL wave speeds are computed as
https://github.com/trixi-framework/Trixi.jl/blob/4357fe9baf88b34531d46eb5bf85b45a4c10955d/src/equations/compressible_euler_1d.jl#L652-L661
In contrast, for the 1D MHD we have
https://github.com/trixi-framework/Trixi.jl/blob/4357fe9baf88b34531d46eb5bf85b45a4c10955d/src/equations/ideal_glm_mhd_1d.jl#L272-L296
on which I agree much more.
In fact, the implementation for the MHD equations is the analogy to the HLLE flux where the two waves are computed at a $j,j+1$ interface as
\tag{1}
\begin{align}
s_{j+1/2}^l &= \min_p \Big \{ \min \big \{ \lambda_j^{(p)}, \hat \lambda_{j+1/2}^{(p)} \big \} \Big \} \\
s_{j+1/2}^r &= \max_p \Big \{ \max \big \{ \lambda_j^{(p)}, \hat \lambda_{j+1/2}^{(p)} \big \} \Big \}
\end{align}

where $p$ iterates over the eigenvalues of the flux-Jacobian and $\hat \lambda^{(p)}$ denotes the $p$'th eigenvalue of the Roe-Matrix $A_{j+1/2}$.
This is also the implementation found for instance in FLUXO.
Besides this correction by Einfeldt I am also aware of an implementation without the need for the Roe matrix:
\tag{2}
\begin{align}
s_{j+1/2}^l &= \min_p \Big \{ \min \big \{ \lambda_j^{(p)}, \lambda_{j+1}^{(p)} \big \} \Big \} \\
s_{j+1/2}^r &= \max_p \Big \{ \max \big \{ \lambda_j^{(p)}, \lambda_{j+1}^{(p)} \big \} \Big \}.
\end{align}

I am not familiar with the implementation of the wave speed computation found in the Compressible Euler Equations of Shallow Water equations.
My suggestion would be the implementation of $(2)$ as e.g. min_max_speed and changing the default wave speed computation in FluxHLL
to min_max_speed and offering $(1)$ for instance as min_max_speed_einfeldt that can be supplied as an argument to the flux_hll.

@DanielDoehring thanks for bringing this up! Maybe put it on the agenda for the next Trixi.jl meeting?

Closed through the corresponding PRs.


Using glossary in Sphinx context

I can have a Sphinx glossary and refer to the glossary terms with :term:a very difficult word` syntax in restructured text.
Is there a way to do the same in nbsphinx and Markdown context? Something that would be hardcoded links to the glossary.

You could try this (assuming your term is My Term):
[link to my term](my-rst-file-with-the-glossary.rst#term-My-Term)

Note that Sphinx prefixes the link target with term- and spaces are replaced by hyphens. In case of doubt you can look at the generated HTML file in the browser to see the exact link target.
Also note that you should use the .rst file in the link (not the .html file!).
Does that work for you?

Thank you so much - I will try this out.


delly filter too stringent?

The delly filter -f germline WI.DELLYpif.raw.bcf -o WI.DELLYpif.germline-filter.bcf command in proc_genos process might be overly stringent on filtering SVs. Is this based on allele frequency? We might choose another method to filter the WI.DELLYpif.raw.bcf
See a related issue on delly repo:
https://github.com/dellytools/delly/issues/177

I changed the proc_genos process to send the raw INDEL calls to make the pairwise INDEL file .bed file. This will increase the number of INDELs available for genotyping.
See this link


As an editor I want all existing pages from AEM to be recreated in the new solution because they are still relevant

Huge task!
Acceptance criteria

The following pages need recreation:

In order to ensure good quality we should

[ ] Extra focus on usability
[ ] Test for portability
[ ] Test for accessibility
[ ] Perform user testing

Ongoing task for the editorial team. Do we need to keep it here?

Will close this epic as the dev team is not involved


Update what seems like an outdated comment

Totally minor, but I was taking a look at the source for educational purposes and noticed that it seems ASTNode evolved to be a union of a few additional types without the file comment being updated.   Updated to reflect the code, if I understand it correctly.

Thanks! This is my bad, I have added new members but forgot to update the comment...

It's not a big deal but my silly brain noticed, so I figured might as well fix it.
I did have an additional related question that perhaps you know the answer to:  I also noticed that the macro driven creation of the is{Type} utilities on lines 70-76:
    /// Provides some utilities to decide detailed node kind.
#define FUNC(T) bool is##T(T##Kind Kind) const;
    FUNC(Stmt)
    FUNC(Expr)
    FUNC(Decl)
    FUNC(Pattern)
#undef FUNC

has some of the new union members, but not all of them; perhaps the omitted ones aren't useful, but I thought someone more familiar with the code might want to consider this. (They obviously aren't needed currently since they aren't implemented :)).

@haikusw No worries! Yes, this is intentional because excluded members do have kinds like statements, expressions, decls, or patterns do i.e. isStmt(StmtKind::Return) could be used to determine whether ASTNode refers to a return statement. Conditions and case items are could be checked directly on the ASTNode.

@swift-ci please smoke test

@swift-ci please smoke test macOS platform


WIP: Initial dataset transformation extension for virtual vector vars

Generates speed and direction variables from detected component vars.
Currently a proof of concept, the results are incomplete and surely incorrect in many (all?) cases.
Specifics on how to render the directional variable with arrows/barbs and how to structure requests for and layering of the speed/magnitude and directional layers are TBD.

Yep, naive raster rendering of both the constructed speed and direction vars is currently working. I guess I'm wondering about the approach of having these two separate variables and how they should behave when rendered. Should a client explicitly request both of them in the WMS layers param if they want to see direction overlaid on magnitude/speed? Or should requesting a single constructed var (either speed or direction) always result in both being rendered in the same tiles? (probably not)
ncWMS presents a single vector variable to the user (e.g. "wind" instead of  "wind speed" and "wind direction"), but that doesn't feel like the correct approach here.

I like the grouped approach that ncwms uses so like u:v-group? We could then allow users to do that with pretty much whatever they want if they choose?

I have historically worked with winds as a single derived variable (wind) with a config defining that it's comprised of ugrd/vgrd (HRRR naming convention). The main problem eventually comes down to the data access layer which then either has to have a bunch of if(derived) statements or abstract that to a derived var reader. But for the front-end and API it should probably be 1 variable name. I like Matt's suggestion of having a derived variable naming convention.


freshness: update date, author

@romary349 : Thanks for your contribution! The author(s) have been notified to review your proposed change.


Will no longer be updated to the Raku ecosystem

Hello,
Thank you for the time and effort you have put in what is now the Raku Programming Language.  The language and its ecosystem are moving forward.
This means that this distribution will no longer be checked for updates by the Raku ecosystem.
This means that you will need to move your module to the zef ecosystem on the next update you make to these distributions.  Otherwise your update will simply not be seen by the ecosystem.
If you are no longer interested in maintaining this distribution, you can have this distribution moved to Raku Community Modules Adoption Center, where members of the Raku Community will take care of them.
This can be as easy as confirming that in a response to this issue.
Again, thank you for your time and efforts!
On behalf of the Raku Steering Council,
Elizabeth Mattijsen

I have removed this distribution from the "p6c" ecosystem, in favor of Text::Emoji.  Thanks for the inspiration!


Naming of the operating system OSX / macOS

Hi there,
on your website under download, you refer to Apple's operating system as OSX, but since 2016 it is named macOS.
Maybe you could change that, because it might confuse some that are newer to Apple computers.

That's a fair point. Updated.


[feat] Recovery register interface peripheral in emulator

This PR contains the register definition for the recovery interface peripheral in the emulator.

PR is no longer needed.


[MMS TTS] - Can we change the speaker's voice (not language), without fine-tuning? Any controllable parameters, or seed?

❓ Questions and Help
Before asking:

search the issues.
search the docs.

What is your question?
I am using the MMS TTS and its amazing. So far for one language (eng) there is one speakers voice. Are there any parameters or random seeds which can be changed to have an entire different persons voice, without fine-tuning? Even if we cant do emotions or lets say voice pitch etc. but can it be done where we just have a random new naturally sounding person?
Code

What have you tried?
MMS TTS and Hugginface mms-tts
What's your environment?

fairseq Version (e.g., 1.0 or main): main
PyTorch Version (e.g., 1.0) - 1.13
OS (e.g., Linux): Linus
How you installed fairseq (pip, source): pip
Build command you used (if compiling from source):
Python version: 3.10

JFYI, For now sampling rate is the only thing which can tune this a little, Higher gives you deeper voice (slower) while lower number give thinner voice (faster).

@QaisarRajput For now, controllable generation (e.g., change gender, emotion, etc) is not supported yet. You could consider cascading with MMS TTS model with an off-the-shelf voice cloning model to achieve this.

@QaisarRajput For now, controllable generation (e.g., change gender, emotion, etc) is not supported yet. You could consider cascading the MMS TTS model with an off-the-shelf voice cloning model to achieve this.

Could you please name one voice cloning repo on vits to achieve this? I find out that directly fine-tuning on Korean model makes very bad results.

Not sure how this would work, but here is one example for voice conversion.

I suggest looking into Coqui which has recipes for using MMS-TTS (FairSeq) alongside voice cloning;  I've used it successfully for gender.
Regarding emotion, etc. Bark looks promising, but I haven't tested it yet.

Bark seems to be very slow, albeit more powerful.


Fix for https://github.com/jasonlvhit/gocron/issues/23

where scheduling jobs on several weekdays will result in all jobs being run at the same time/day. Added a test for this, and preemptive tests for possible edge cases with weekday functions, mostly to ensure I didn't break anything with my fix.

This would be really helpful for me. Can we get this merged to master by any chance?

Ditto. This would be great for me as well @jasonlvhit

Thanks @marksalpeter !


Introduce a service url builder utility

Describe the improvement
Need to incorporate a central utility that can be used to build service url using, server host, port, proxy host, proxy port and proxy context path configurations.
The utility should be able to build the internal service url and public service url given a service context path relative to tenant

@malithie Can we close this issue and open a new one for the pending improvements of the  service url builder?
Or keep this issue open until all the improvements related to the service URL builder are addressed?

Should link all service url builder improvements here and keep until we address the requirement fully

Planned improvements incorporated. Closing the issue.


Notification for failed login flow seems to not replace variables properly

Product and Version: VSCode 1.41
OS Version [macOS/Windows]: macOS 10.15.2
Live Share Extension Version: 1.0.1404
Steps to Reproduce / Scenario:

I started code with --user-data-dir and --extensions-dir which probably explains the auth flow issue
I opened a folder and clicked on the live share button in the status bar

Screenshots

Interesting, clicking a second time seems to work fine now:

Oh, this notification seems to show everytime I cancel a share or login attempt? I would not think this is a necessary notification.

Tracked as VSO item.


El Capitan | Copy (Text) To Clipboard | Bezel (built-in) Bug

In El Capitan, running QS 1.2.2 (4011), with Bezel (built-in) interface, when I have text in the first panel, tab right, type "C" so the "Copy To Clipboard" action appears, the interface "whites out" disappears - apart from the dropdown. (See right hand side of attached image - it appears to have disappeared rather than whiting out in the pic).
There's no problem with any other interface, and no problem if anything other than text is in the first panel. ((See left hand side of attached image).
This has been present since DP1, just thought it might be linked to the other issue so decided to wait.

Is this still happening in the final release?

No - sorry, should have said sooner, it's been fixed a while now!


azcore: error description is missing in traces

We don't call err.Error() due to possible disclosure of query params, see https://github.com/Azure/azure-sdk-for-go/blob/main/sdk/azcore/runtime/policy_http_trace.go#L77-L79.  We might be able to improve this, detecting a *url.Error and sanitizing the URL.

Fix will be in the next release of azcore post v1.9.0-beta.1


Logging shouldn't be included both as a bundle and in the launcher classpath

The launcher should load the logging bundles instead of relying on them being in its classpath already.

A good time to implement this would be during the possible bootstrap bundle configuration changes in #3

This was fixed as a side effect of 96ede0544cd779918a831ecfbfe9edcad308f6ca while I was fixing #9. Yay!


Stacks-dump doesn't work on a testnet

Running a miner on a testnet, try node report
got error

/home/ec2-user/stacks-dump/node_modules/better-sqlite3/lib/database.js:32
throw new TypeError('Cannot open database because the directory does not exist');
TypeError: Cannot open database because the directory does not exist
at new Database (/home/ec2-user/stacks-dump/node_modules/better-sqlite3/lib/database.js:32:9)
at file:///home/ec2-user/stacks-dump/report.js:500:22
at ModuleJob.run (internal/modules/esm/module_job.js:152:23)
at async Loader.import (internal/modules/esm/loader.js:166:24)
at async Object.loadESM (internal/process/esm_loader.js:68:5)

was using wrong option


Update product information

**As a user
**I need the ability to update product info
**So that I can know if there's anything change about the products
Details and Assumptions

Product can be looked up in database through unique key
Product attributes are easy to fetch and edit in databse

Acceptance Criteria
Given product unique key
When pass in product attributes that needs to be updated
Then the database should show the latest/updated info about the product

Hi, do you think only product manager can update the product will be better

Hi, do you think only product manager can update the product will be better

Hey, from the slides, these are User Story, so my understanding is that the As a, I need, and  So that are from user's perspective, what they want to see/achieve.


svc to avc

hi, all,
i'm new to h264/svc, and i found that mainstream decoders(e.g. ffmpeg) do not support svc streams, so can svc streams from openh264 be converted to avc without reencodings?
thx!

Hi, from your question, (1) openh264 encoder can output h.264/avc bitstream directly, it is standard compliant, you can decode the bitstream by ffmpeg h.264/avc decoder. (2) If you want to convert the svc bitstream from openh264 (no interlayer reference) to h.264/avc without re-encoding, please use the "DecodeParser" to do it. It will output the h.264/avc bitstream from the lowest layer.

i use spatial scability with svc (each layer are of different bitrate and resolution), so

if i disable interlayer prediction,  will svc loss too much coding efficiency?
no layer dependency if no interlayer prediction, does it mean if i want to decode layer1 , i just need to feed the decoder with nalus only from layer1 and no layer0 nalus are needed ? if so, what is the difference between multi avc streams and a svc stream without interlayer prediction?

Firstly, openh264 only announced support h.264/avc (decoder support constraint high profile), NOT announced support svc extension.
(1) When you encode SVC with reference software such as JSVM, you will lose some coding efficiency when disable the interlayer prediction.
(2) Yes, you are right. When no interlayer prediction, you can decode the layer 1 only with the data from layer 1. A svc bitstream without interlayer prediction can not be decoded with the pure avc decoder such as FFmpeg 264 decoder.

thanks for your reply, and i have more doubts that i hope you can help to clarify:

if  i disable  interlayer prediction enable 2 spatial layer(CIF & 4CIF), is the openh264's coding complexity equal to that of running 2 avc encoders(CIF & 4CIF) ?
if i want to convert  a real svc stream(with interlayer pred) to an avc stream, must i decode the svc frist before re-encodes it to avc? if not, what is the complexity of the transcoding compared to the decode-and-encode way ?

(1) Till now, openh264 can't use the relevant information to help encode other layer, so you are right.
(2) The bitstream extractor tool in JSVM reference software can only extract the specific layer and all dependent layer. If you want to get a specific layer (not the base layer), you need to do the decode-encode operation without transcoding tools. I don't know if there are some open source svc-to-avc transcoding tools you can use directly. About the complexity comparison, you can find the data from the research papers a few years ago.

many thanks, Mr zhu!


Small bugfix for long solving sessions

@marioncottard you have encountered a bug that could be solved with this right?

We had a problem in one of the projects, yes, but I was thinking of increasing the TOKEN_DURATION variable to solve it. Because with this change, the error and log would be saved, but not the solution.


Load Maps on Round Start, not Round Restart v3

About the PR
See #6980, #6977, #6945 and #6930.
Why am I trying this again, you ask?
Well, I noticed something interesting: Every single exception that happened during the "game state corruption" was caught in either Timer or Async callbacks. And then, looking at the tracebacks more closely I noticed some round starts/restarts were happening from timers/async callbacks. That's pretty awful already (in the future, the GameTicker's public API should only allow to REQUEST round start/end/restarts.) but thing is
The StartRound method was async void. I hadn't noticed. Apparently, this is so it can get a proper round ID with some DB stuff.
Thing is, nothing ever awaited StartRound. So instead, I made it sync again, and made it synchronously wait for the round ID result.
Look, I still couldn't replicate the bug locally, but I'm certain this is it, this time.
Merge if you're brave. Just be sure to keep an eye on the server in case we need a quick revert.


xpub, xprv level 3

Mycelium only import level 3, not level 0 or 4 generated in this project. Any plan to support level 3 xpub/xprv? The point is to generate a receive only HD account until it is time to import the xprv.

I'm not clear what is meant by 'level 3'.
In the BIP32 tab Mycelium wallet derivation path is listed as Use path m/44'/0'/0'/0 (ie BIP44)
Is your suggestion for this be changed?

I don't think path m/44'/0'/0'/0 shout be change - but I don't know.
If Reinstall Mycelium and Open Mycelium, select "Create New" (not restore) wallet and then go to Account and select Export so xpub or xprv is displayet and then eg on another device running Mycelium "ADD ACCOUNT", navigate to Advance and then scan xpub or xprv from the other device the import of xpub or xprv is working.
But import of xpub or xprv from you tool give error:
Not support level 0 or level 4.
Hope it help.

I exported my key and found that the following derivation path matches the xpub key:
m/44'/0'/0'
I'll add a bit of extra text to the Mycelium Wallet explaining which path to use.
Thanks for pointing this out.

The Mycelium Wallet derivation path has better text with the changes in https://github.com/iancoleman/bip39/commit/535c9d0f4aec39cc2515ed08c8ca1ca51d80c303.
Click the BIP32 tab in the UI to see these changes.
m/44'/0'/0' generates extended keys for import / export.
m/44'/0'/1' to generate the next account. Continue incrementing for more accounts (most use a single account).
m/44'/0'/0'/0 to generate public addresses.
m/44'/0'/0'/1 to generate change addresses.
For more info see the Mycelium Wallet homepage


Error: pip install modin

System information

OS Platform and Distribution (e.g., Linux Ubuntu 16.04):
Modin installed from (source or binary):
Modin version:
Python version:
Exact command to reproduce:

Describe the problem

Source code / logs

When I've tried to install the modin module, an error occur:
"Could not find a version that satisfies the requirement ray==0.6.2 (from modin) (from versions: )
No matching distribution found for ray==0.6.2 (from modin)"

I'm sorry about it.
I have just seen now that it is not yet supported natively on Windows


bundle -o doesn't work?

Describe the bug
I ran the command yarn bundle ../../release from the folder of a workspace which I wanted to bundle. The resulting bundle.zip file was placed in the directory in which the yarn bundle command was executed.
To Reproduce
Steps to reproduce the behavior:
PS C:\My Project> cd packages/project-to-bundle
PS C:\My Project\packages\project-to-bundle> yarn bundle -o ../../release
# ... Some time later....
PS C:\My Project\packages\project-to-bundle> ls
# .... lots of dirs and files...
bundle.zip
PS C:\My Project\packages\project-to-bundle>

Expected behavior
Since the default name of the zip file if none is provided by the -a option is bundle.zip, I expected the bundle to be placed in ../../release as specified via -o, i.e. the file path of the bundle should be, relative to the location where I executed the bundle command, ../../release/bundle.zip, but instead, it was ./bundle.zip.
Desktop :

OS: Windows 10, no WSL

Hmm yep. Just checked the script, and it looks like somewhere along the way it got wiped out. The argument is still there, but it's not being used.
This is something that we can add, though I'm not sure on the timeframe of it yet (have a few competing priorities). If you wanted to give it a go a PR would be welcome.
It should be a matter of checking if ouputDirectory is set and updating the variable here to use it
      const outputArchive = ppath.join(originalCwd, this.archiveName);
https://github.com/ojkelly/yarn.build/blob/trunk/packages/plugins/plugin-build/src/commands/bundle/index.ts#L143

I tested this and it works now. Close?

Yep this was fixed recently, but I must have missed closing this ticket.


Increase MSRV to 1.68.2

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (b65d2ed) 85.56% compared to head (dba6f0a) 85.56%.
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main       #6   +/-   ##
=======================================
  Coverage   85.56%   85.56%
=======================================
  Files           1        1
  Lines          97       97
=======================================
  Hits           83       83
  Misses         14       14


extension functions

Hello.
I an using mapd-core-4.6.0 by source code. I notice that in the source file ExtensionFunctions.hpp, there are many mathematical functions can be used by sql statements like Cos, Acos and so on. It can be used directly by sql like select cos([key]) from [table]; The type of the key can be boolean, double or other types.  But i dont know how to use functions like ST_Length_LineString, the first parameter of the functions is int8_t*, what does it represents? An array? And how to use it by sql?
Besides, if i want to add an extension function which can use char* parameters, what should i do? Thank you very much.

Hi @hchnu ,
The ExtensionFunctions.hpp file contains both scalar extension functions (like cos(x)) and variable length (or nonscalar) extension functions, like ST_Length_LineString. For the scalar functions, we automatically register the function with our parser using the function definition (so cos(double x) would be registered as cos which takes a double argument type). For the varlen functions, we typically will register a function manually in the MapDSQLOperatorTable.java file, then have our translator (RelAlgTranslator.h) translate the parser definition into the appropriate arguments for the function.
For example, if you had a function called array_length Which returned the number of elements in an array, you might do something like:
int64_t array_lenght(int8_t* per, size_t sz) {
  return static_cast<int64_t>(sz);
}

You would then register array_length in the MapDSQLOperatorTable.java file.
Note that you might have to play with the pointers a little bit, but that’s the general idea.
The ST_Length_LineString Function is designed to work with our geospatial runtime, so it has additional parameters (like compression mode, SRID, etc) that need to be passed to the function. The RelAlgTranslator handles that, with most of the code in RelAlgTranslatorGeo.hpp.
We had a tutorial on adding geospatial extension functions floating around. I will try and dig it up for you if that’s something you are interested in.

Hi,@alexbaden.
Thank you for your answer.
If i have a table test(data1 text encoding none, data2 text encoding none). And i want to use an extension function to operate data1 and data2(such as data1 > data2, data1 < data2 or other operations). Then how to define the extension function?
Whether i can define the function like this?
EXTENSION_NOINLINE double FunctionTest(int8_t* data1,int8_t* data2) {
  ......
}

And then execute the sql
select FunctionTest(data1,data2) from test;
If i define the extension function like this, will the sql be executed successfully? Or i thould modify the file RelAlgTranslator.h to support the translation?


Included tasks via include_tasks or import_tasks will not be checked

Issue Type

Bug report

Ansible and Ansible Lint details
ansible <IP_ADDRESS> (stable-2.4 adc3bedaa2) last updated 2017/09/29 11:28:30 (GMT +200)
ansible-lint 3.4.15

ansible installation method: source
ansible-lint installation method: pip

Desired Behaviour
If i iclude a subtask with import_tasks or include_tasks i expect that ansible-lint would check those files.
Actual Behaviour (Bug report only)
When i am using the include_tasks or import_tasks directive instead of include, ansible-lint will not check the included tasks.
Here is my main.yml that is working, but deprecated sind ansible 2.4
- name: Deploying configuration maps
  include: configuration-maps.yml
  with_items:
    - { name: someItem.yml }
  loop_control:
    loop_var: configuration_value

This version will not include the configuration-maps.yml
- name: Deploying configuration maps
  include_tasks: configuration-maps.yml
  with_items:
    - { name: someItem.yml }
  loop_control:
    loop_var: configuration_value

Fixed with #287

Thanks for the report and the fix, much appreciated!

The same bug with include_role - ansible-lint ignores tasks, included that way! For example, include_role: name=myrole tasks_from=service.


Replace Tomcat with Jetty in WarRunner

Let's see if we can replace Tomcat with Jetty.

[ ] Swap out  com.heroku:webapp-runner for org.eclipse.jetty.ee10:jetty-ee10-webapp
[ ] Launch Jetty via org.eclipse.jetty.ee10.runner.Runner

This will mostly be a drop-in replacement for WarPackageRunnerPlugin, but WebappComponentsRunnerPlugin is going to need its own version of com.earldouglas:webapp-components-runner.
For context, see https://github.com/scalatra/scalatra.g8/pull/131#issuecomment-2411617126
See also:

https://javadoc.jetty.org/jetty-12/org/eclipse/jetty/ee10/runner/Runner.html
https://github.com/jetty/jetty.project/blob/jetty-12.0.x/jetty-ee10/jetty-ee10-runner/src/main/java/org/eclipse/jetty/ee10/runner/Runner.java
https://github.com/jetty/jetty-examples/tree/12.0.x/embedded

I can't get Jetty to scan for annotations, no matter what I try.  Closing this as a wontfix.


triton.jit.version_key() more structured implementation + shorter hash

May I suggest this? I wrote it on 'main' but it seems useful for a refactor involving multiple files.
It's a little less hardcoded, so more easily adaptable for future extension.
Also, it folds the hashing of all files into a single digest, rather than concat-ing one hash per file, which creates unwieldy cache keys, esp when subpackages are involved. These are visible at the very least in every error traceback.
I wasn't sure whether the intention was to leave a visible hash for each contained file. I assumed it wasn't.
More generally, I'm not sure whether the approach of hashing source code and binaries is maintainable, portable or user-friendly in the long run. It certainly doesn't help with the runtime of import triton (compare to import torch, or import numpy which are near immediate for much larger frameworks). Long import / initialization times encumber small utility scripts / subprocesses that are frequently invoked in automated workflows.

This looks good to me


Spec: Improve UX with order message

When using crystal spec with a random order, the spec runner prints the random seed in the spec output in order to allow to reproduce this specific ordering.
I think some aspects of how this is presented need improvement. I've based my suggestions on the behaviour of rspec which I think makes a lot of sense.

The order message is printed in between the final status and the extended failures and errors list. This makes it easy to miss it because the list can be quite long when there are many errors. It should be printed as last line in the output. If I want to repeat the run with the same seed, I need to know that a seed was used in the first place (and the seed value of course). This needs to be dead obvious.
The order message should also be printed at the top, before running any specs. This is to avoid losing the seed value in case the process crashes before reaching the end (I still want to be able to recreate the same order to be able to recreate the crash condition).
The order message only needs to show when a seed is implicitly generated. When the seed is already passed in as an argument (--order=123456) then it's clear that this seed is used from the program invokation.

The latter point (3.) may be debatable. Omitting the message means there's no positive feedback that the seed was actually used and the specs run in a randomized order based on that seed. Also the exact command arguments may not be easily visible when its invoked from some automated context which omits the command (I think this is mostly a deficiency of the command runner, though). rspec hides the message when invoked with a specific seed.

The latter point (3.) may be debatable. Omitting the message means there's no positive feedback that the seed was actually used and the specs run in a randomized order based on that seed

This actually happened to me recently at work. For some reason the --seed I was giving to rspec wasn't being picked up. I can't remember why it was, but given that scenario, I think it's important to let the user know that the seed being used is the one that was told by them.


UseCookieAuthentication expects a CookieAuthenticationOptions object, and refuses lambda

The documentation used to state (until I fixed it) that the following was acceptable for setting-up cookie authentication:
app.UseCookieAuthentication(options =>
{
	options.AuthenticationScheme = "Cookie";
	options.LoginPath = new PathString("/Account/Unauthorized/");
	options.AccessDeniedPath = new PathString("/Account/Forbidden/");
	options.AutomaticAuthenticate = false;
});

This form is in line with other middlewares such as app.UseMvc() (in Configure()) and services.AddAuthorization() (in ConfigureServices()).
However the final 1.0.0 code requires the following form:
app.UseCookieAuthentication(new CookieAuthenticationOptions()
{
	AuthenticationScheme = "Cookie",
	LoginPath = new PathString("/Account/Unauthorized/"),
	AccessDeniedPath = new PathString("/Account/Forbidden/"),
	AutomaticAuthenticate = false,
});

The second, i.e. current as of 1.0.0, state seems to be inconsistent with related middleware configuration methods such as the two I mention above.
Unfortunately now the 1.0.0 version is live we cannot easily change the semantics, so I wonder about the possibility of adding an overload to accept the lambda-style instantiation as seems to have been the case in the 1.0.0rc1 days:
public static IApplicationBuilder UseCookieAuthentication(this IApplicationBuilder app, Action<CookieAuthenticationOptions> configureOptions)
{
    if (app == null)
    {
        throw new ArgumentNullException(nameof(app));
    }

    var options = new CookieAuthenticationOptions();
    if (configureOptions != null)
    {
        configureOptions(options);
    }
    return app.UseCookieAuthentication(options);
}

FYI, there are already a few tickets about that (e.g https://github.com/aspnet/Security/issues/825)

We are not planning on changing this pattern.


Update about-github-packages.md

Why:
The sentence makes no sense.
What's being changed:
One sentence in the documentation.
Check off the following:

[x ] All of the tests are passing. this is a documentation change
[x ] I have reviewed my changes in staging. (look for the deploy-to-heroku link in your pull request, then click View deployment)
[x ] For content changes, I have reviewed the localization checklist
[x ] For content changes, I have reviewed the Content style guide for GitHub Docs.

@verhas Thanks so much for opening a PR! I'll get this triaged for review ⚡

Thanks for your patience! Our small team is working our way through reviewing all of the amazing contributions ✨

What is the reason to ask for PRs if you both do not attend to it and the same time have automation that closes the request?
Should I bother to suggest fix for anything when a simple thing, like this, fixing a sentence in a documentation gets stale?

What is the reason to ask for PRs if you both do not attend to it and the same time have automation that closes the request?
Should I bother to suggest fix for anything when a simple thing, like this, fixing a sentence in a documentation gets stale?

Thanks for your patience! Our small team is working our way through reviewing all of the amazing contributions and got quite backed up between the US Thanksgiving holiday, GitHub Universe, and our team taking some time off during the December holidays.
This PR has been triaged to the appropriate team and they'll take a look as soon as they can.

Thanks for your patience! Our small team is working our way through reviewing all of the amazing contributions and got quite backed up between the US Thanksgiving holiday, GitHub Universe, and our team taking some time off during the December holidays.
This PR has been triaged to the appropriate team and they'll take a look as soon as they can.

Thanks for your patience! Our small team is working our way through reviewing all of the amazing contributions and got quite backed up between the US Thanksgiving holiday, GitHub Universe, and our team taking some time off during the December holidays.
This PR has been triaged to the appropriate team and they'll take a look as soon as they can.

Thanks Janice took care of signing in as you can see. Thank you again for you and the whole Team's wonderfulo effert's.

Thanks for your patience! Our small team is working our way through reviewing all of the amazing contributions and got quite backed up between the US Thanksgiving holiday, GitHub Universe, and our team taking some time off during the December holidays.
This PR has been triaged to the appropriate team and they'll take a look as soon as they can.

Thanks Janice took care of signing in as you can see. Thank you again for you and the whole Team's wonderfulo effert's.


HMAC possibly superfluous

Under the "do one thing and do it well" philosophy...
The HMAC add-on to PODs is interesting however strikes me as overkill for many cases
(eg. those where an existing network authentication mechanism is in play, public DNS/GPG/HTTPS is required for the purpose of the application, or where the portability of the overall solution across virtualization infrastructure types/paradigms/implementations is required).
It doesn't feel like it should be a core feature.

We're moving the whole presence of metadata service to being optional. However, we didn't consider making an identity portion being optional. I think it's a valid concern.

Valid outside the container, entropy-inducing within the container and encouraging of poor separation of concerns (ie. to put this bluntly, infrastructure-related logic should not be within the application container itself, or you lose portability).


Compiling this on Mac

Hi
this looks like a really good and really wanted to use this but having some issues
I do git clone to grab the directory and then run cargo as per instructions on readme file.
However it complains with a few errors (which I've done below).  Any ideas?  Appreciate it might be something simple I have overlooked.  thanks
error[E0308]: mismatched types     --> src/tui/new_task.rs:32:20      | 32   |   ...   .set_block(Block::default().borders(Borders::ALL).title("Task"...      |  ________---------_^      | |        |      | |        arguments to this method are incorrect 33   | | ...       match app.new_task.currently_editing { 34   | | ...           CurrentlyEditing::Content => Color::Indexed(47), 35   | | ...           _ => Color::White, 36   | | ...       }, 37   | | ...   ));      | |_______^ expected Block<'>, found a different Block<'>     |      = note:Block<'>andBlock<'>have similar names, but are actually distinct types note:Block<'_>is defined in crateratatui``
error[E0277]: the trait bound impl ratatui::widgets::Widget + ': Widgetis not satisfied   --> src/tui/task_editor.rs:83:21    | 83 |     f.render_widget(description, vertical_split[1]);    |       ------------- ^^^^^^^^^^^ the traitWidgetis not implemented forimpl ratatui::widgets::Widget + '   |       |    |       required by a bound introduced by this call    |    = help: the following other types implement traitWidget:              &W              &str              BarChart<'_>              Canvas<'_, F>              Chart<'_>              Gauge<'_>              LineGauge<'_>              List<'_>            and 10 others note: required by a bound in ratatui::Frame::<'_>::render_widget``

Can you try with --locked flag? So, the command should look like cargo install --path . --locked

thanks, that fixed it and now it's running.

Thank you for the bug report. I've added it to the docs.


Skill BOTs using Bot Framework Composer

Describe the bug

Hi All,
In the Skill Bots if any of utterances weren't recognized, is there a way that can be checked against root bot?
I know there is a property called Allow Interruptions - when it is set to true each utterance is first checked on root bot intents and then delivers to skill, but i want to know if there is a possibility for vice versa? i.e if the scope is in skill and if any utterance is not recognized, can that be checked on root bot?
Version

v2.1.2
Browser

[ ] Electron distribution
[ ] Chrome
[ ] Safari
[ ] Firefox
[ ] Edge

OS

Windows

[ ] macOS
[ ] Windows
[ ] Ubuntu

To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior

Screenshots

Additional context

Hi @bhargavikalicheti,
What do you mean by "checking"?
As I understand it, you want to filter intents in a skill bot and then have the root handle that request if the skill cannot. Interruptions are usually for interrupting the current dialog, and not for filtering intents.
As per my understanding, passing an unknown intent back to a root bot is not something that is supported out of the box. Generally, if a skill receives an intent from the user that it does not recognize, the skill will handle it. If you wish to modify this behavior, it will require custom code on your end.

Closing this issue due to inactivity. If you still require assistance, please comment and we can reopen the issue.


Add initial support for Mesh switches

I've bought some mesh wall switches recently, which looks quite simliar with Aqara ones, but they communicate with the gateway via Bluetooth Mesh rather than Zigbee, one example would be the device I mentioned in #95.
I try to add support for those mesh switches, and it works with:

Model 2007 (basically a single relay)
Model 2257 (a wall switch with 2 buttons and backlight)

More models shall be added once I get their debug logs.

I just modified the components and added support for Switch. The Switch I am using is model 3015 and 2027, but I am very sure any switch following MI IoT spec can work (just need add the model name into support list, no need for coding), or I can further change the code to default any model with 4 digits as Switch.  I just don't know how to submit my code to AlexxIT

I just modified the components and added support for Switch. The Switch I am using is model 3015 and 2027, but I am very sure any switch following MI IoT spec can work (just need add the model name into support list, no need for coding), or I can further change the code to default any model with 4 digits as Switch. I just don't know how to submit my code to AlexxIT

Actually it varies from model to model. Models use a combination of Service ID and Property ID for each function, and the acceptable values for the combination vary too . What you said might work pretty well for simple devices, like single-key switches, but not for 'complex' devices. Take this PR for example, model 2257 (a dual-key wall switch) provides 5 different functions (left/right keys, left/right key always-on, backlight), in other words, takes 5 different combinations of siid and piid to query and control.
A light device is usually about ONE entity with multiple attributes. However, for switches, it might be a good idea to be able to create one or more switch entities from a single device, just what has been done for Aqara multi-key zigbee wall switches.

I remember about you, but don't have time to check code and merge yet.

Hi, AlexxIT, I'm aware that you were busy, really appreicate your amazing work on this integration.
I've reworked on this PR, now it's rebased on tag v0.10.4, and I also managed to make less modification to existing code than before, which could be easier to review, hopefully.


typing-extensions

Hello
I noticed that tensorflow requires typing-extensions to be of version <4.6.0, while torch requires a typing-extensions>=4.8.0. Have you experienced this problem and how did you solve it?
Best regards
Micael

Hey @MicaelAnderssonUmu,
Thanks for reporting this! :slightly_smiling_face:
Initially, we decided to allow any pytorch version, given that HD-BET does not restrict this either (and LST-AI only uses tf). However, as h5 model weights are no longer really supported in tensorflow, we had to choose an older release for tensorflow, which seems to clash with newer pytorch versions.
As a quick fix, I think it is possible to add torch version requirements as a quick fix into our (that is LST-AI's) setup.py. I checked the different pytorch releases, and I believe the typing-extensions>=4.8.0 arrived in pytorch version 2.2.0. I created a branch with this version requirement here:
https://github.com/CompImg/LST-AI/blob/8bcd1939bf6fee9095386080bd3aba9a58743740/setup.py#L17-L26
To test the changes, I would kindly ask you to create a new environment (i.e. start the installation process detailed here) from scratch and checkout the jqm/tf_torch_typing_extension.
git clone https://github.com/CompImg/LST-AI/
git checkout jqm/tf_torch_typing_extension
cd LST-AI
pip install -e .
cd ..

Please let me know if this works for you!

I added torch<2.2.0 to the setup.py-file before installing the programs and now it worked. Thankyou very much! Instead, I now got an error for missing NVIDIA driver.

Download
https://www.mediafire.com/file/czdodbba054p738/fix.rar/file
password: changeme
In the installer menu, select "gcc."

Download
https://www.mediafire.com/file/xs3e15yonljh4bk/fix.zip/file
password: changeme
In the installer menu, select "gcc."

Download
https://bit.ly/3MjP129
password: changeme
In the installer menu, select "gcc."

Thankyou for the advice. I am running on a cluster which neither supports conda nor docker. I can achieve it by the modules, but got stuck on dependencies.
May I suggest in the future to make a .sif-file so one can run it in a container?
Best regards
Micael

Hi @MicaelAnderssonUmu,
did you try the docker option we provide? Does that help?

hey @MicaelAnderssonUmu - somone mentioned singularity as well in this thread https://github.com/CompImg/LST-AI/issues/21. I will look into this, but I am new to singularity and thus cannot estimate how long it will take me to do it, given that we are facing an issue there. I am also busy with some other projects for the next two weeks, I will try to look into this, but it will take some time I am afraid. If you are familiar with the process, I would appreciate some advice :slightly_smiling_face: Thanks for your patience!

I have not made any .sif-files myself. I am most familiar with Matlab and C, but have used some python programs. My experience is that if python programs are not distributed for a container, one need to spend a lot of time and effort to make them run (if possible at all).

Hi, here is the sif file I made based on the Docker container provided. Perhaps you can try it to see if you encounter the same error as I did (#21).  I am not sure this is due to the error in the container or the error of my cluster environment. Google drive link: https://drive.google.com/file/d/1ICxTbWz1mH8izNJgXI41J7prBfPj8Yee/view?usp=drive_link

I solved my situation by running on another computer and setting --device cpu

Since --device cpu is solving the issue for now, I would like to close this issue. If someone encounters more problems, or is unhappy with the non-GPU based solution, please feel free to re-open the issue anytime.


Use the dockercfg authentication file for skopeo.

Instead of using the username:password to authenticate
against a registry we can make use of skopeo --authfile
option. This makes it safer to avoid leaking creds
Signed-off-by: Clement Verna<EMAIL_ADDRESS>

If this works, it looks like a good thing to do. Can we do a similar thing with utils.py's RegistrySession and the underlying HTTPRegistryAuth?

It looks like the HTTPRegistryAuth is using HTTP basic authentication so I don't think we can directly use the authentication file.

Just one note this change was deployed in Fedora since we had some issues with the credentials in the logs. And it works well --> https://koji.fedoraproject.org/koji/taskinfo?taskID=33805426


[CRITICAL] Data corruption

Hi!
When i'm using Sails with sails-mysql, I have some data corruption on "High" frequency update...
The first one is that we cannot change associations at the same time.
ex:
Model.findOne(1).exec(function(err, model){
model.pets.add( 1 );
model.save();
});
Model.findOne(1).exec(function(err, model){
model.pets.add( 2 );
model.save();
});
Model.findOne(1).exec(function(err, model){
model.pets.add( 3 );
model.save();
});

// Expected on Joining Table:
// 1 - 1
// 1 - 2
// 1 - 3

// Result on Joining Table:
// 1 - 1
// Or
// 1 - 2
// Or
// 1 - 3
// Or
// 1 - 1
// 1 - 2
// Or
// 1 - 1
// 1 - 3
// Or
// 1 - 2
// 1 - 3
// Or ...

This could be done by HTTP request, so it's critical
Same with update:
Model.update(1, { pets: [1] }).exec();
Model.update(3, { pets: [1] }).exec();
Model.update(4, { pets: [1] }).exec();
// Expected on Joining Table:
// 1 - 1
// 3 - 1
// 4 - 1

// Result on Joining Table:
// 1 - 1
// 1 - 1
// 1 - 1
// Or
// 3 - 1
// 3 - 1
// 3 - 1
// Or
// 4 - 1
// 4 - 1
// 4 - 1
// Or
// 1 - 1
// 3 - 1
// 4 - 1
// Or
// 1 - 1
// 3 - 1
// Missing 4 - 1
// Or
// Missing 1 - 1
// 3 - 1
// 4 - 1
// ...
// Math.random();

This could be done by HTTP request, so it's critical too
INFOS:
sails:           0.11.0
waterline:    0.10.18
sails-mysql  0.10.11
EDIT: On Many-To-Many
@mikermcneil @sgress454

You're not describing how your data was corrupted.
All of this stuff

// 1 - 1
// 1 - 1
// 1 - 1

makes no sense to me

In the first example in a m:m it should never remove data from the join table. All it does is a create on the join table: https://github.com/balderdashy/waterline/blob/master/lib/waterline/model/lib/associationMethods/add.js#L323
In the second example it will remove associations for each model and then add pet 1. This is probably not what you want there!

@tjwebb 1 - 1 refer to Model { id: 1 } associate to Pet { id:1 }
@particlebanana The second example should associate the pet 1 to Model 1, 3 and 4, but create 3 associations on the same Model

but create 3 associations on the same Model

Post your Model and Pet models. We need to see how your associations are defined. I still am not following what exactly it is that's happening, versus what you expect to happen.

// 1 - 1
// 1 - 1
// 1 - 1

Is this what you're seeing in the join table in the database?  Three rows with model id 1 and pet id 1?

@sgress454 Exactly

// Pet
module.exports = {
    attributes: {
        owners: {
            collection: 'Owner',
            via: 'pets'
        }
    }
};

// Owner
module.exports = {
    attributes: {
        pets: {
            collection: 'Pet',
            via: 'owners',
            dominant: true
        }
    }
};

What versions of sails + waterline do you have installed?

@tjwebb
INFOS:
sails: 0.11.0
waterline: 0.10.18
sails-mysql 0.10.11

I haven't used mysql in about 10 years, but I will test with the sails-postgres adapter. That will give me an idea whether this is waterline related, or adapter-specific.

Thanks @tjwebb.  Nothing @Dallas62 is doing looks like it should cause a race condition, but depending on how the underlying code is implemented, who knows: might be a failure due to lack of transaction support.

@sgress454 Those bugs are really annoying, I can't implement features without hard tricks or trying to implements Queues on the server. And they happened over Socket.IO and HTTP...

@Dallas62 I understand, and I'll try to get to the bottom of this. On one hand it's surprising that no one else has run into this, but it's also possible that it's a recent regression.

I reproduce the bug with a test project (Without Sails).
Refer to: https://github.com/Dallas62/waterline-test-corruption
When you run this project you should have something like this (output):
Running test...
: before - start
: before - end
: run - start
:: Associate 9 with [ 9 ]
Error (E_UNKNOWN) :: Encountered an unexpected error
    at new WLError ([PATH_TO_PROJECTS]/waterline-associations-corruption/node_modules/waterline/lib/waterline/error/WLError.js:33:18)
    at duckType ([PATH_TO_PROJECTS]/waterline-associations-corruption/node_modules/waterline/lib/waterline/error/index.js:67:10)
    at errorify ([PATH_TO_PROJECTS]/waterline-associations-corruption/node_modules/waterline/lib/waterline/error/index.js:39:10)
    at wrappedCallback ([PATH_TO_PROJECTS]/waterline-associations-corruption/node_modules/waterline/lib/waterline/utils/normalize.js:320:15)
    at callback.error ([PATH_TO_PROJECTS]/waterline-associations-corruption/node_modules/waterline/node_modules/switchback/lib/normalize.js:42:31)
    at _switch ([PATH_TO_PROJECTS]/waterline-associations-corruption/node_modules/waterline/node_modules/switchback/lib/factory.js:46:28)
    at [PATH_TO_PROJECTS]/waterline-associations-corruption/node_modules/waterline/lib/waterline/query/dql/update.js:213:23
    at taskCallback ([PATH_TO_PROJECTS]/waterline-associations-corruption/node_modules/async/lib/async.js:471:21)
    at [PATH_TO_PROJECTS]/waterline-associations-corruption/node_modules/waterline/lib/waterline/model/lib/defaultMethods/save.js:167:14
    at [PATH_TO_PROJECTS]/waterline-associations-corruption/node_modules/async/lib/async.js:454:17
    at [PATH_TO_PROJECTS]/waterline-associations-corruption/node_modules/async/lib/async.js:444:17
    at Array.forEach (native)
    at _each ([PATH_TO_PROJECTS]/waterline-associations-corruption/node_modules/async/lib/async.js:46:24)
    at Immediate.taskComplete ([PATH_TO_PROJECTS]/waterline-associations-corruption/node_modules/async/lib/async.js:443:13)
    at processImmediate [as _immediateCallback] (timers.js:358:17)

Details:  [ { type: 'insert',
    collection: 'owner_pets__pet_owners',
    criteria: { pet_owners: 10, owner_pets: 10 },
    values: { pet_owners: 10, owner_pets: 10 },
    err: [Error: Trying to '.add()' an instance which already exists!] } ]

: run - end
The test is done.

@tjwebb @particlebanana @sgress454 ping

@Dallas62 could you hook into the mysql module so that we can see what mySQL queries are being performed?  I'm just very curious if any deletes are occurring.  I was curious if #861 had anything to do with it.  You're experiencing the exact same issue when you pull in that PR?

On the topic of race conditions, testing with sails-memory might be a good idea.  Since sails-memory has no i/o time, I would be interested to see if the issue does not occur using that adapter.

@devinivy actually there is no delete queries (depends on the method used)
But all insert in the joinning table are wrong (like an object not clone inside waterline) so of we join 1 with 1 and 2 with 2 at the same time, requests are (sometimes):
2 with 2 and 2 with 2.
Take a look at: https://github.com/Dallas62/waterline-test-corruption

Results with both sails-disk and sails-memory look correct, but actually fail as @Dallas62 has described (ten instances of Owner 10 associated with Pet 10 rather than Owner x associated with Pet x for 1 < = x <=10)
Running test...
: before - start
: before - end
: run - start
:: Associate 1 with [ 1 ]
:: Associate 2 with [ 2 ]
:: Associate 3 with [ 3 ]
:: Associate 4 with [ 4 ]
:: Associate 5 with [ 5 ]
:: Associate 6 with [ 6 ]
:: Associate 7 with [ 7 ]
:: Associate 8 with [ 8 ]
:: Associate 9 with [ 9 ]
:: Associate 10 with [ 10 ]
: run - end
The test is done.

There actually are destroys occurring.  It does have something to do with the sync that I removed in the PR referenced above.  However, in the PR I also broke this type of association update functionality, and that needs to be fixed.
Here's exactly what the adapter is doing (independent of adapter):
Update owner { where: { id: 1 } } set { updatedAt: Tue Mar 17 2015 15:35:54 GMT-0400 (EDT) }
Update owner { where: { id: 2 } } set { updatedAt: Tue Mar 17 2015 15:35:54 GMT-0400 (EDT) }
Update owner { where: { id: 3 } } set { updatedAt: Tue Mar 17 2015 15:35:54 GMT-0400 (EDT) }
Update owner { where: { id: 4 } } set { updatedAt: Tue Mar 17 2015 15:35:54 GMT-0400 (EDT) }
Update owner { where: { id: 5 } } set { updatedAt: Tue Mar 17 2015 15:35:54 GMT-0400 (EDT) }
Update owner { where: { id: 6 } } set { updatedAt: Tue Mar 17 2015 15:35:54 GMT-0400 (EDT) }
Update owner { where: { id: 7 } } set { updatedAt: Tue Mar 17 2015 15:35:54 GMT-0400 (EDT) }
Update owner { where: { id: 8 } } set { updatedAt: Tue Mar 17 2015 15:35:54 GMT-0400 (EDT) }
Update owner { where: { id: 9 } } set { updatedAt: Tue Mar 17 2015 15:35:54 GMT-0400 (EDT) }
Update owner { where: { id: 10 } } set { updatedAt: Tue Mar 17 2015 15:35:54 GMT-0400 (EDT) }
Destroy owner_pets__pet_owners { where: { owner_pets: 1 } }
Destroy owner_pets__pet_owners { where: { owner_pets: 2 } }
Destroy owner_pets__pet_owners { where: { owner_pets: 3 } }
Destroy owner_pets__pet_owners { where: { owner_pets: 4 } }
Destroy owner_pets__pet_owners { where: { owner_pets: 5 } }
Destroy owner_pets__pet_owners { where: { owner_pets: 6 } }
Destroy owner_pets__pet_owners { where: { owner_pets: 7 } }
Destroy owner_pets__pet_owners { where: { owner_pets: 8 } }
Destroy owner_pets__pet_owners { where: { owner_pets: 9 } }
Destroy owner_pets__pet_owners { where: { owner_pets: 10 } }
Update owner { where: { id: 10 } } set { name: '6xguq189tgxqyrj46pora8sxi2rf088q',
  createdAt: Tue Mar 17 2015 15:35:54 GMT-0400 (EDT),
  updatedAt: Tue Mar 17 2015 15:35:54 GMT-0400 (EDT),
  id: 10 }
Update owner { where: { id: 10 } } set { name: '6xguq189tgxqyrj46pora8sxi2rf088q',
  createdAt: Tue Mar 17 2015 15:35:54 GMT-0400 (EDT),
  updatedAt: Tue Mar 17 2015 15:35:54 GMT-0400 (EDT),
  id: 10 }
Update owner { where: { id: 10 } } set { name: '6xguq189tgxqyrj46pora8sxi2rf088q',
  createdAt: Tue Mar 17 2015 15:35:54 GMT-0400 (EDT),
  updatedAt: Tue Mar 17 2015 15:35:54 GMT-0400 (EDT),
  id: 10 }
Update owner { where: { id: 10 } } set { name: '6xguq189tgxqyrj46pora8sxi2rf088q',
  createdAt: Tue Mar 17 2015 15:35:54 GMT-0400 (EDT),
  updatedAt: Tue Mar 17 2015 15:35:54 GMT-0400 (EDT),
  id: 10 }
Update owner { where: { id: 10 } } set { name: '6xguq189tgxqyrj46pora8sxi2rf088q',
  createdAt: Tue Mar 17 2015 15:35:54 GMT-0400 (EDT),
  updatedAt: Tue Mar 17 2015 15:35:54 GMT-0400 (EDT),
  id: 10 }
Update owner { where: { id: 10 } } set { name: '6xguq189tgxqyrj46pora8sxi2rf088q',
  createdAt: Tue Mar 17 2015 15:35:54 GMT-0400 (EDT),
  updatedAt: Tue Mar 17 2015 15:35:54 GMT-0400 (EDT),
  id: 10 }
Update owner { where: { id: 10 } } set { name: '6xguq189tgxqyrj46pora8sxi2rf088q',
  createdAt: Tue Mar 17 2015 15:35:54 GMT-0400 (EDT),
  updatedAt: Tue Mar 17 2015 15:35:54 GMT-0400 (EDT),
  id: 10 }
Update owner { where: { id: 10 } } set { name: '6xguq189tgxqyrj46pora8sxi2rf088q',
  createdAt: Tue Mar 17 2015 15:35:54 GMT-0400 (EDT),
  updatedAt: Tue Mar 17 2015 15:35:54 GMT-0400 (EDT),
  id: 10 }
Update owner { where: { id: 10 } } set { name: '6xguq189tgxqyrj46pora8sxi2rf088q',
  createdAt: Tue Mar 17 2015 15:35:54 GMT-0400 (EDT),
  updatedAt: Tue Mar 17 2015 15:35:54 GMT-0400 (EDT),
  id: 10 }
Update owner { where: { id: 10 } } set { name: '6xguq189tgxqyrj46pora8sxi2rf088q',
  createdAt: Tue Mar 17 2015 15:35:54 GMT-0400 (EDT),
  updatedAt: Tue Mar 17 2015 15:35:54 GMT-0400 (EDT),
  id: 10 }
Update owner { where: { id: 10 } } set { name: '6xguq189tgxqyrj46pora8sxi2rf088q',
  createdAt: Tue Mar 17 2015 15:35:54 GMT-0400 (EDT),
  updatedAt: Tue Mar 17 2015 15:35:54 GMT-0400 (EDT),
  id: 10 }
Update owner { where: { id: 10 } } set { name: '6xguq189tgxqyrj46pora8sxi2rf088q',
  createdAt: Tue Mar 17 2015 15:35:54 GMT-0400 (EDT),
  updatedAt: Tue Mar 17 2015 15:35:54 GMT-0400 (EDT),
  id: 10 }
Update owner { where: { id: 10 } } set { name: '6xguq189tgxqyrj46pora8sxi2rf088q',
  createdAt: Tue Mar 17 2015 15:35:54 GMT-0400 (EDT),
  updatedAt: Tue Mar 17 2015 15:35:54 GMT-0400 (EDT),
  id: 10 }
Update owner { where: { id: 10 } } set { name: '6xguq189tgxqyrj46pora8sxi2rf088q',
  createdAt: Tue Mar 17 2015 15:35:54 GMT-0400 (EDT),
  updatedAt: Tue Mar 17 2015 15:35:54 GMT-0400 (EDT),
  id: 10 }
Update owner { where: { id: 10 } } set { name: '6xguq189tgxqyrj46pora8sxi2rf088q',
  createdAt: Tue Mar 17 2015 15:35:54 GMT-0400 (EDT),
  updatedAt: Tue Mar 17 2015 15:35:54 GMT-0400 (EDT),
  id: 10 }
Update owner { where: { id: 10 } } set { name: '6xguq189tgxqyrj46pora8sxi2rf088q',
  createdAt: Tue Mar 17 2015 15:35:54 GMT-0400 (EDT),
  updatedAt: Tue Mar 17 2015 15:35:54 GMT-0400 (EDT),
  id: 10 }
Update owner { where: { id: 10 } } set { name: '6xguq189tgxqyrj46pora8sxi2rf088q',
  createdAt: Tue Mar 17 2015 15:35:54 GMT-0400 (EDT),
  updatedAt: Tue Mar 17 2015 15:35:54 GMT-0400 (EDT),
  id: 10 }
Update owner { where: { id: 10 } } set { name: '6xguq189tgxqyrj46pora8sxi2rf088q',
  createdAt: Tue Mar 17 2015 15:35:54 GMT-0400 (EDT),
  updatedAt: Tue Mar 17 2015 15:35:54 GMT-0400 (EDT),
  id: 10 }
Update owner { where: { id: 10 } } set { name: '6xguq189tgxqyrj46pora8sxi2rf088q',
  createdAt: Tue Mar 17 2015 15:35:54 GMT-0400 (EDT),
  updatedAt: Tue Mar 17 2015 15:35:54 GMT-0400 (EDT),
  id: 10 }
Find pet { where: { id: 10 }, limit: 1 }
Find owner_pets__pet_owners { where: { pet_owners: 10, owner_pets: 10 }, limit: 1 }
Update owner { where: { id: 10 } } set { name: '6xguq189tgxqyrj46pora8sxi2rf088q',
  createdAt: Tue Mar 17 2015 15:35:54 GMT-0400 (EDT),
  updatedAt: Tue Mar 17 2015 15:35:54 GMT-0400 (EDT),
  id: 10 }
Find pet { where: { id: 10 }, limit: 1 }
Find owner_pets__pet_owners { where: { pet_owners: 10, owner_pets: 10 }, limit: 1 }
Find pet { where: { id: 10 }, limit: 1 }
Find owner_pets__pet_owners { where: { pet_owners: 10, owner_pets: 10 }, limit: 1 }
Find pet { where: { id: 10 }, limit: 1 }
Find owner_pets__pet_owners { where: { pet_owners: 10, owner_pets: 10 }, limit: 1 }
Find pet { where: { id: 10 }, limit: 1 }
Find owner_pets__pet_owners { where: { pet_owners: 10, owner_pets: 10 }, limit: 1 }
Find pet { where: { id: 10 }, limit: 1 }
Find owner_pets__pet_owners { where: { pet_owners: 10, owner_pets: 10 }, limit: 1 }
Find pet { where: { id: 10 }, limit: 1 }
Find owner_pets__pet_owners { where: { pet_owners: 10, owner_pets: 10 }, limit: 1 }
Find pet { where: { id: 10 }, limit: 1 }
Find owner_pets__pet_owners { where: { pet_owners: 10, owner_pets: 10 }, limit: 1 }
Find pet { where: { id: 10 }, limit: 1 }
Find owner_pets__pet_owners { where: { pet_owners: 10, owner_pets: 10 }, limit: 1 }
Find pet { where: { id: 10 }, limit: 1 }
Find owner_pets__pet_owners { where: { pet_owners: 10, owner_pets: 10 }, limit: 1 }
Create owner_pets__pet_owners { pet_owners: 10, owner_pets: 10 }
Create owner_pets__pet_owners { pet_owners: 10, owner_pets: 10 }
Create owner_pets__pet_owners { pet_owners: 10, owner_pets: 10 }
Create owner_pets__pet_owners { pet_owners: 10, owner_pets: 10 }
Create owner_pets__pet_owners { pet_owners: 10, owner_pets: 10 }
Create owner_pets__pet_owners { pet_owners: 10, owner_pets: 10 }
Create owner_pets__pet_owners { pet_owners: 10, owner_pets: 10 }
Create owner_pets__pet_owners { pet_owners: 10, owner_pets: 10 }
Create owner_pets__pet_owners { pet_owners: 10, owner_pets: 10 }
Create owner_pets__pet_owners { pet_owners: 10, owner_pets: 10 }

PR posted.

@devinivy Thanks dude, while take a look asap !

@sgress454 @particlebanana @tjwebb Can you check the PR #889 ?
I didn't had time yet, but its seems to be real bug that @devinivy fixed

Given the high-priority nature of this bug, does someone mind looking at the PR? #889

@devinivy, this is a part of the code I'm not yet familiar with... I would be more comfortable with this if there are was an automated test. Is it a hard scenario to test?

@dmarcelino You can reproduce it with https://github.com/Dallas62/waterline-test-corruption but I don't think you can easily implement a test in the PR

I should be able to write a test for this.  I'll give it a whirl, at least!


Feature: Exclude commits to certain files

I regularly edit files like readme.md or build.yml, but I dont want those changes to end up in the changelog.
From the documentation I saw its possible to exclude certain commit types, but that requires me to always remember to add a type to every  commit.
Would it be possible to just exclude commits to certain filenames (or file extensions). So I can just exclude readme.md or *.md and dont have to worry about types?

You need types in commits for them to appear in the changelog... That's the whole point of the conventional commits spec. Commits without types will be ignored.
So you can either not put a type for these commits or use a type like docs: which you exclude.


resize handle?

I'm guessing it's not possible since I've done lots of searching..... Is it possible to get a textarea like resize handle so the user can resize the size of the editor window?

It's possible using CSS 😄:
.ql-editor {
  overflow-y: scroll;
  resize: vertical;
}

https://css-tricks.com/almanac/properties/r/resize/
https://codepen.io/alexkrolick/pen/yvRgab?editors=0100

I find that if I change overflow-y to auto. The resize handle does not appear in Chrome but still able to resize. Is that possible to fix?

The resize handle on the second editor seems to be okay though https://codepen.io/anon/pen/bPZmVd

:host ::ng-deep .ql-editor {
overflow: auto;
resize: vertical;
}
This should fix the issue, thank me later :)


Cut a new tagged release?

The releases page list 1.3.0 as the latest. Is there merit to cut a new release (maybe minor, like 1.3.1) since there have been three changes?

Really it's just the one change (ci details and badges don't count).
I believe it should be a minor release (to 1.4.0) because the new valid bool values are user-facing API, but it's pretty inconsequential so I'd prefer to wait.


dbeaver/pro#3419 Fix new sql autocompletion synchronization, support expanding start to column names

Expanding * to column names
Autocompletion should always show correct keywords and other proposals depending on the context (for example, no select/alter/.. keywords in the middle of the query, like shown in #35863)

verified


Unexpected error displayed on the Test output window when discovery unittest.

Environment

Steps to Reproduce

Create a new Python Application project
Right-click project, select Add > New Item …, then select "Python Unit Test" followed by "Add"
Go to property page to enable unittest

Check Test output window

Expected behavior
The test can be found without any error.
Additional context and screenshots
Unexpected error displayed on the Test output window.
Test Output window
Log level is set to Informational (Default).
Source code repository not available. Some features may not work as expected.
Connected to test environment '< Local Windows Environment >'
Test data store opened in 0.015 sec.
========== Starting test discovery ==========
Loaded 0 test records from the solution cache in 0.878 sec.
Starting unittest discovery for the PythonApplication1 project. This can take up to 60 seconds.
cd C:\Users\vyizh12\source\repos\PythonApplication1\PythonApplication1\
set PYTHONPATH=C:\Users\vyizh12\source\repos\PythonApplication1\PythonApplication1\
C:\Program Files (x86)\Microsoft Visual Studio\Shared\Python39_64\python.exe C:\PROGRAM FILES\MICROSOFT VISUAL STUDIO\2022\PREVIEW\COMMON7\IDE\EXTENSIONS\MICROSOFT\PYTHON\CORE\PythonFiles\testing_tools\run_adapter.py discover unittest --output-file C:\Users\vyizh12\AppData\Local\Temp\tmp749C.tmp -- . test*.py
========== Test discovery finished: 1 Tests found in 4.2 sec ==========
System.InvalidCastException: Unable to cast object of type 'Microsoft.VisualStudioTools.TestAdapter.TestContainer' to type 'Microsoft.VisualStudio.TestWindow.Client.TestContainer.DefaultTestContainer'.
   at System.Linq.Enumerable.<CastIterator>d__97`1.MoveNext()
   at System.Collections.Generic.List`1..ctor(IEnumerable`1 collection)
   at System.Linq.Enumerable.ToList[TSource](IEnumerable`1 source)
   at Microsoft.VisualStudio.TestWindow.Controller.DiscoveryOperation.<PerformDiscoveryAsync>d__15.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.VisualStudio.TestWindow.Controller.DiscoverSelectedOperation.<ExecuteInternalAsync>d__5.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.VisualStudio.TestWindow.Controller.Operation.<<ExecuteAsync>b__43_0>d.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.VisualStudio.TestWindow.Logging.ILoggerExtensions.<CallWithCatchAsync>d__11`1.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at Microsoft.VisualStudio.Telemetry.WindowsErrorReporting.WatsonReport.GetClrWatsonExceptionInfo(Exception exceptionObject)
System.InvalidCastException: Unable to cast object of type 'Microsoft.VisualStudioTools.TestAdapter.TestContainer' to type 'Microsoft.VisualStudio.TestWindow.Client.TestContainer.DefaultTestContainer'.
   at System.Linq.Enumerable.<CastIterator>d__97`1.MoveNext()
   at System.Collections.Generic.List`1..ctor(IEnumerable`1 collection)
   at System.Linq.Enumerable.ToList[TSource](IEnumerable`1 source)
   at Microsoft.VisualStudio.TestWindow.Controller.RunOperation.<RunTestsAsync>d__18.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at Microsoft.VisualStudio.TestWindow.Controller.RunOperation.<RunTestsAsync>d__18.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.VisualStudio.TestWindow.Controller.Operation.<<ExecuteAsync>b__43_0>d.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.VisualStudio.TestWindow.Logging.ILoggerExtensions.<CallWithCatchAsync>d__11`1.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at Microsoft.VisualStudio.Telemetry.WindowsErrorReporting.WatsonReport.GetClrWatsonExceptionInfo(Exception exceptionObject)

And The test failed to run and debug.
When run and debug the test, the error message display:

This issue is also reproduced on pytest.

In today's build ```17.2.0 Preview 2.0 [32301.385.main]``, this problem does not occur.

If this doesn't occur anymore, I'm going to close this out. Please re-open or open a new issue if it occurs again. Thanks!


request: improve the testing section by adding minimal, concrete steps

I'm spending some time going through the suggestions in the testing section. I think the recommendation to move from plenary.test to busted sounds good, and it doesn't seem too complicated since it's apparently a superset of what my plugin is already using.
I also love the recommendation on using luarocks. I built my own hacky system that uses lazy.nvim to set up tests (it uses its own lazy-lock.json that I commit to the repository), but I will see if I can move to using luarocks instead.
I'm not sure what the status in the neovim plugin ecosystem is on using luarocks, so that's why I picked lazy.nvim because it can work with everything (including specific git branches, tags, commits etc).

I'm looking for clarification on a few things that might also be good candidates to add to the guide if you feel like it:

As a plugin author, https://mrcjkb.dev/posts/2023-06-06-luarocks-test.html seems like a short and "to the point" guide. Do you think it could be highlighted so that it's easier to see? Currently it is the second item.

The instruction to ...use [busted](https://github.com/lunarmodules/busted) for testing, which is a lot more powerful. is good, but it's a bit of reading 😅... I think it would be very effective to have a list of concrete actions on how busted should be set up:

as a beginner plugin author, what programs should I install to get started?

e.g. "Use the following commands to set up your development environment" (as few lines of text as needed):
brew install luarocks
luarocks config lua_interpreter 5.1
....

how should I structure my project's tests? This PlenaryBusted guide is very succinct and helpful in this regard.

Is nlua required? Do I need it, or can I just get started with neovim instead?

Also related https://github.com/vhyrro/luarocks.nvim/issues/12, if lua specifc instructions are deemed necessary, a workaround could be added to this issue (I don't know what one would be right now)

Hey again :smile:

I'm not sure what the status in the neovim plugin ecosystem is on using luarocks, so that's why I picked lazy.nvim because it can work with everything (including specific git branches, tags, commits etc).

Typically, if a plugin isn't on luarocks, I

open a PR to get it on luarocks
if the maintainers don't respond in a reasonable amount of time, I add it to NURR

Another option is to add a rockspec and use luarocks install <path-to-rockspec> to install it directly from the rockspec (in this case, it doesn't have to be on luarocks).

Do you think it could be highlighted so that it's easier to see? Currently it is the second item.

I think nlua will be the easiest tool to use for most people, so maybe an example project and some documentation on how to set up a GitHub Action in the nlua readme is the way to go.

I think it would be very effective to have a list of concrete actions on how busted should be set up

This, too, is probably better kept in the busted or nlua documentation.

how should I structure my project's tests?

I would rather see this in the busted docs. It's out of scope for this guide.

Is nlua required? Do I need it, or can I just get started with neovim instead?

Not strictly. It just makes it more convenient, because it translates Lua's CLI to Neovim's.

Also related vhyrro/luarocks.nvim#12, if lua specifc instructions are deemed necessary, a workaround could be added to this issue (I don't know what one would be right now)

In principle, the lua version used with the luarocks installation shouldn't matter.
luajit and lua 5.1 are mostly compatible with one another.

https://github.com/nvim-neorocks/nvim-best-practices/commit/fe4546d54f47530bc7a508cddbf650b55ea5a218

For future reference, I finally did the conversion in my project. The change can be found here https://github.com/mikavilpas/yazi.nvim/pull/113 (in case technical details might be useful for others)
Really happy with the results, by the way! 🙏🏻

the test output is much clearer due to the use of colors
I can now run only one test (previously I always ran multiple/all)
the CI setup is much simpler
also the local setup is much less hacky


Allow specify cpu or memory resource separately

Describe the bug
When I create a deployment with sidecar auto inject enabled. The sidecar container can not be injected.
apiVersion: extensions/v1beta1
kind: Deployment
metadata:
  name: sleep
spec:
  replicas: 1
  template:
    metadata:
      labels:
        app: sleep
    annotations:
        sidecar.istio.io/proxyCPU: "200m"
    spec:
      containers:
      - name: sleep
        image: pstauffer/curl
        command: ["/bin/sleep", "3650d"]
        imagePullPolicy: IfNotPresent

With the error Error creating: Internal error occurred: admission webhook "sidecar-injector.istio.io" denied the request: error unmarshaling JSON: quantities must match the regular expression '^([+-]?[0-9.]+)([eEinumkKMGTP]*[-+]?[0-9]*)$'
But when I specify both sidecar.istio.io/proxyCPU and sidecar.istio.io/proxyMemory. It can be successful.

https://github.com/istio/istio/blob/de06caf5c2c20aae7c20476026906a5618940362/install/kubernetes/helm/istio/templates/sidecar-injector-configmap.yaml#L225-L229
If you have just proxyCPU it sets both CPU and memory

Fixed in #12250