TypeError: Cannot read property 'split' of undefined

Investigative information
Please provide the following:

UTC Timestamp: Oct. 23 2019 23:38:30
Migration Tool App version: 0.1.2
OS Version: Windows Server 2012 R2 Standard

Repro steps

Download MSI
Install with admin priveledges on dev web server
Open via desktop shortcut with admin priviledges

Expected behavior
According to screenshots it's supposed to list my existing sites.

Actual behavior
Error: TypeError: Cannot read property 'split' of undefined

Known workarounds
None.

Hello @mrchops1024,
Thank you for reporting this!
I think I know why this is happening, but to be sure it will really fix the issue you're hitting could you please do the following steps and let us know what the output looks like?

Find out the path for the installation of iisConfigurationHelper.exe: Right-click the AppServiceMigrationTool desktop shortcut and select Properties. Look for the path in the "Start in" value (should be something like: C:\Users<yourUserName>\AppData\Local\Programs\azure-appService-migrationtool).
Open an admin command prompt and go to that location with added "\iisConfigAssistant": C:\Users<yourUserName>\AppData\Local\Programs\azure-appService-migrationtool\iisConfigAssistant
Try running this command and send us the output (obscure site names as desired): iisConfigAssistant.exe GetSiteList

Thank you,
Kristina

I received the following error message:
{
  "HResult": "80070002",
  "DisplayMessage": "Could not load file or assembly 'netstandard, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51' or one of its dependencies. The system cannot find the file specified.",
  "TelemetryMessage": "An unhandled exception occurred.  HResult=80070002",
  "StackTrace": "   at iisConfigAssistant.Program.DoGetSiteList(String[] args)\r\n   at iisConfigAssistant.Program.Main(String[] args) in D:\\a\\1\\s\\src\\IisConfigurationHelper\\iisConfigAssistant\\Program.cs:line 44"
}

I've had a same one, came from #6
{
  "HResult": "80070002",
  "DisplayMessage": "Could not load file or assembly 'netstandard, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51' or one of its dependencies. The system cannot find the file specified.",
  "TelemetryMessage": "An unhandled exception occurred.  HResult=80070002",
  "StackTrace": "   at iisConfigAssistant.Program.DoGetSiteList(String[] args)\r\n   at iisConfigAssistant.Program.Main(String[] args) in D:\\a\\1\\s\\src\\IisConfigurationHelper\\iisConfigAssistant\\Program.cs:line 44"
}

Thank you for getting back to us with those details.
We believe this is happening because the Migration Assistant has a dependency on version 4.7.2 of the .NET Framework and were able to reproduce the behavior for this reason (such as if only 4.6.1 is installed).
Can you please confirm which version(s) of the .NET Framework are installed on your machine (see https://docs.microsoft.com/en-us/dotnet/framework/migration-guide/how-to-determine-which-versions-are-installed) and/or install 4.7.2 (possible source: https://support.microsoft.com/en-us/help/4054530/microsoft-net-framework-4-7-2-offline-installer-for-windows) and try running the tool again?
I have opened workitems on our side to better highlight the minimum system requirements on the tool download page and the next release will be display a more informative and actionable error message.

The server had 4.6.2 installed. I've installed 4.7.2 and verified the utility opens now.

Thanks for confirming the fix.

Hi,
We have some situations in which we're migrating apps hosted on W2008R2 servers with 4.6.1.
I think App Service supports this version of .Net framework.
Would it be possible to recompile the assistant so that it is compatible with 4.6.1?
Thanks a lot.

(Yes. We are currently working on this for the next release.)


chore(husky/pre-commit): add lint:licenses script

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
567

Relevant Lines:
567

💛  - Coveralls


[Bug] Settings command window shows selection on load

System Default is shown as selected when first opened, regardless of settings, making it confusing for users thinking its selected, and for accessibility also being confusing as it needs a tab to access

Rewriting


Updates routing to handle /orders as well as /order2

This updates force to both send new orders to the /orders route and continue to support the existing /order2 route until we deprecate it completely.

nice! 🙌


[FEATURE] Publish opensearch-knn jar

Is your feature request related to a problem?
Cannot use opensearch-knn as a regular dependency in maven and IntelliJ.
What solution would you like?
Publish jar, like you do in other plugins.
@prudhvigodithi

Adding @vamshin @navneet1v

@erezgong we do publish the jars. We have another plugin neural search that takes dependency on k-NN plugin. Ref: https://github.com/opensearch-project/neural-search/blob/main/build.gradle#L143
Also publishing actions for gradle: https://github.com/opensearch-project/k-NN/blob/main/build.gradle#L90-L122
So not sure what exactly we need with this issue?
@prudhvigodithi

Hey @navneet1v, the published type is zip and the gradle logic uses the zip file, unzip it and uses the jar inside the zip file. Notice for job-scheduler we have both the jar and zip published.
The ask is to do the same for k-NN to publish the jar file as well (Should be under https://aws.oss.sonatype.org/content/repositories/releases/org/opensearch/opensearch-knn/).

@prudhvigodithi you can check the same here for k-NN: https://aws.oss.sonatype.org/content/repositories/releases/org/opensearch/plugin/opensearch-knn/

@navneet1v the published ones are of type zip
https://aws.oss.sonatype.org/content/repositories/releases/org/opensearch/plugin/opensearch-knn/<IP_ADDRESS>/opensearch-knn-<IP_ADDRESS>.pom
<packaging>zip</packaging>

@prudhvigodithi on checking further I can see that only job-schedular plugin is publishing the jars. All other plugins are publishing the zips.
In the light of that evidence I don't think so k-NN should publish the jars separately.

@navneet1v no there are more example opensearch-ml-client, opensearch-custom-codecs, opensearch-geo, for more check this link https://aws.oss.sonatype.org/content/repositories/releases/org/opensearch/, Also it depends on the plugin team based on the use case.

Fyi Ml-client is not a plugin. Its more of a library to call the ml apis from plugin to interact with ml commons.
plugins that i dont see is ml commons, sql, alterting, security.
here is my understanding if all the jars are present in the zip then why to publish the jars separately.
There was campaign which was started after which all the plugins started publishing their zips from plugin repo only and not the opensearch ci. The plugins who are still publishing the jars could have been from left over code where we have added the jar publish code so that other plugins can take dependency on.
I don’t see any precedent from opensearch project where plugins needs to publish their jars mandatorily.
Please provide a strong usecase why k-nm should publish the jars too when zip have the same thing in it

@navneet1v FYI this ask was from @erezgong I'm just trying to emphasize on a point (as I was tagged in the issue) on which its not very hard to publish a jar of k-nn to maven when k-nn acts as an upstream, even neural search uses k-nn as upstream which adds a logic to crack open the zip and use the jar, Refer:  https://github.com/opensearch-project/neural-search/blob/main/build.gradle#L161-L165
.
@navneet1v also here is the campaign https://github.com/opensearch-project/opensearch-build/issues/1916 to publish the plugin zips to maven which is an enhancement and I dont think  jar publish code is the left over code. Also if this the ask from the customer why not?:) Also I would suggest @erezgong to please add the usecase.
Adding @dblock @bbarani @vamshin

Also running the task ./gradlew publishNebulaPublicationToSnapshotsRepository should publish the jars to maven repo.

Thanks

To only depend on k-NN jar, see neural example here: https://github.com/opensearch-project/neural-search/blob/main/build.gradle#L253. This should be good enough. Closing


fix: cosign sign is not recursive leading to podman being unable to pull the image

Current behavior
While images that are built and signed with bluebuild can be verified by rpm-ostree/bootc, they are not trusted by podman image pull with the error Error: copying system image from manifest list: Source image rejected: A signature was required, but no signature exists.
Expected behavior
Images can be pulled with podman.
Additional details
I debugged this behavior using the --log-level=debug flag and determined it was because podman is checking for signatures on each image referred to in the manifest which the latest tag points at. The image is a manifest, even though it only has one architecture, due to this feature of Docker: https://docs.docker.com/build/attestations/attestation-storage/.
In this example log below, ghcr.io/prydom/fedora-kinoite-laptop:20240328 points at a manifest ghcr.io/prydom/fedora-kinoite-laptop:20240328@sha256:be2c706d0550302359d06dc83d105f86e4692656bb14c758ab04ac0ca82e1e24 which matches the image ghcr.io/prydom/fedora-kinoite-laptop:20240328@sha256:d071d8871599465621b412411f2e1e040d815632f41870b4d20f705979a1e693.
be2c706d0550302359d06dc83d105f86e4692656bb14c758ab04ac0ca82e1e24 is signed by cosign (you can see this here) but d071d8871599465621b412411f2e1e040d815632f41870b4d20f705979a1e693 is not. Which you can observe in the logs below.
I'm keeping this image private on ghcr.io so you probably can't directly inspect the image but it should be trivial to reproduce.
Workaround
I am able to workaround this by resigning the manifest using the command cosign sign --key=env://OSIGN_PRIVATE_KEY --recursive ghcr.io/prydom/fedora-kinoite-laptop@sha256:<MANIFEST-HASH>.
Possible solution
Unless there's some side effect I'm unaware of, I suggest we add --recursive to sign_images() and sign_priv_public_pair() in src/commands/build.rs. I'm happy to contribute this, if you'd like.
Bluebuild version
I'm pinned to this build of bluebuild, ghcr.io/blue-build/cli@sha256:ee7efa99c8a0cec6c229333d63bf59fce301bdca53361caf3b3debd855424ef8. Which corresponds to
this push I believe https://github.com/blue-build/cli/commit/189141924baccb04349330348428f576ac6b2a76.
I just noticed the recent release and will upgrade to that.
Podman logs
DEBU[0000] Trying to access "ghcr.io/prydom/fedora-kinoite-laptop:20240328"
DEBU[0000] No credentials matching ghcr.io/prydom/fedora-kinoite-laptop found in /run/user/1000/containers/auth.json
DEBU[0000] Found credentials for ghcr.io/prydom/fedora-kinoite-laptop in credential helper containers-auth.json in file /var/home/$USER/.config/containers/auth.json
DEBU[0000]  Lookaside configuration: using "docker" namespace ghcr.io/prydom/fedora-kinoite-laptop
DEBU[0000]  Lookaside configuration: using "default-docker" configuration
DEBU[0000]  No signature storage configuration found for ghcr.io/prydom/fedora-kinoite-laptop:20240328, using built-in default file:///var/home/$USER/.local/share/containers/sigstore
DEBU[0000] Looking for TLS certificates and private keys in /etc/docker/certs.d/ghcr.io
DEBU[0000]  Sigstore attachments: using "docker" namespace ghcr.io/prydom/fedora-kinoite-laptop
DEBU[0000] GET https://ghcr.io/v2/
DEBU[0000] Ping https://ghcr.io/v2/ status 401
DEBU[0000] GET https://ghcr.io/token?account=prydom&scope=repository%3Aprydom%2Ffedora-kinoite-laptop%3Apull&service=ghcr.io
DEBU[0002] Increasing token expiration to: 60 seconds
DEBU[0002] GET https://ghcr.io/v2/prydom/fedora-kinoite-laptop/manifests/20240328
DEBU[0002] Content-Type from manifest GET is "application/vnd.oci.image.index.v1+json"
DEBU[0002] Using SQLite blob info cache at /var/home/$USER/.local/share/containers/cache/blob-info-cache-v1.sqlite
DEBU[0002] Source is a manifest list; copying (only) instance sha256:d071d8871599465621b412411f2e1e040d815632f41870b4d20f705979a1e693 for current system
DEBU[0002] GET https://ghcr.io/v2/prydom/fedora-kinoite-laptop/manifests/sha256:d071d8871599465621b412411f2e1e040d815632f41870b4d20f705979a1e693
DEBU[0002] Content-Type from manifest GET is "application/vnd.oci.image.manifest.v1+json"
DEBU[0003] IsRunningImageAllowed for image docker:ghcr.io/prydom/fedora-kinoite-laptop:20240328
DEBU[0003]  Using transport "docker" specific policy section ghcr.io/prydom/fedora-kinoite-laptop
DEBU[0003] Reading /var/home/$USER/.local/share/containers/sigstore/prydom/fedora-kinoite-laptop@sha256=d071d8871599465621b412411f2e1e040d815632f41870b4d20f705979a1e693/signature-1
DEBU[0003] Looking for sigstore attachments in ghcr.io/prydom/fedora-kinoite-laptop:sha256-d071d8871599465621b412411f2e1e040d815632f41870b4d20f705979a1e693.sig
DEBU[0003] GET https://ghcr.io/v2/prydom/fedora-kinoite-laptop/manifests/sha256-d071d8871599465621b412411f2e1e040d815632f41870b4d20f705979a1e693.sig
DEBU[0003] Content-Type from manifest GET is "application/json"
DEBU[0003] Fetching sigstore attachment manifest failed, assuming it does not exist: reading manifest sha256-d071d8871599465621b412411f2e1e040d815632f41870b4d20f705979a1e693.sig in ghcr.io/prydom/fedora-kinoite-laptop: manifest unknown
DEBU[0003] Requirement 0: denied, done
DEBU[0003] Error pulling candidate ghcr.io/prydom/fedora-kinoite-laptop:20240328: copying system image from manifest list: Source image rejected: A signature was required, but no signature exists
Error: copying system image from manifest list: Source image rejected: A signature was required, but no signature exists
DEBU[0003] Shutting down engines

Contribution would be welcome! Had no clue podman did that kind of check.
I'm taking a break because of IRL events, but I'd be fine approving a PR

Fix worked and can be seen in action here: https://github.com/prydom/my-ostree-build/actions/runs/8486854854/job/23253890515#step:2:4703
podman is now able to pull images with the policy.json supplied by bluebuild.


Cut v4.4 release

Blocked on the following features (maybe end of week):

Web sever demo plugin

Also consider the following:

Focus stacking doesn't return Z to starting position at end of scan?
Autofocus is slow now that I made the settle times longer. Maybe Add a tuning parameter of some sort. Also try to eliminate the Z move on AF + Go
Reported bug: https://github.com/Labsmore/pyuscope/issues/314
Measure tab scale needs to be corrected
Scale bar: https://github.com/Labsmore/pyuscope/issues/142
General QA pass needed. Lots of changed

Measure tab was corrected / polished

Confirmed there is a "return Z" bug: https://github.com/Labsmore/pyuscope/issues/317

Jog slider should have 100 at far right

All known outstanding issues have been fixed:

Jog slider values are better centered
Focus stacking reliably parks Z at end better
Autofocus is much faster

Thinking to push the following to the next release:

Web / HTTP server for remote control
Autofocus Z limit investigation (https://github.com/Labsmore/pyuscope/issues/314)
Scale bar (https://github.com/Labsmore/pyuscope/issues/142)

Note fixes /features are in:

Z return is reliable
Measure tab scale is corrected
Jog scale labels centered, jog scale bar usability tweaks
Autofocus is much quicker

Think its good enough. Released


⚠ SkipTheTrailers has degraded performance

In 101455b, SkipTheTrailers ($STT) experienced degraded performance:

HTTP code: 200
Response time: 1252 ms

Resolved: SkipTheTrailers performance has improved in b40e98c.


[SOLVED] Remote audio url sent from Android won't playback on iOS device

Version of react-native-audio-recorder-player
3.0.2, react native: 0.63.4
Platforms you faced the error (IOS or Android or both?)
iOS
Expected behavior
Play remote audio files sent from android
Actual behavior
If an Android device sends an audio message to an iOS device then the audio player won't play that file. This lib is being used in a chat room where users exchange audio messages.
Steps to reproduce the behavior
Recording function:
import { Dirs, FileSystem } from "react-native-file-access";

const onStartRecord = async () => {
    ReactNativeHapticFeedback.trigger(
      hapticTriggerType as HapticFeedbackTypes,
      hapticOptions
    );
    const path = Platform.select({
      ios: "remote_audio/remote_audio_message.m4a",
      android: `${Dirs.CacheDir}/remote_audio/remote_audio_message.m4a`
    });
    try {
      const audioSet: AudioSet = {
        AudioEncoderAndroid: AudioEncoderAndroidType.AAC,
        AudioSamplingRateAndroid: 44100,
        AudioSourceAndroid: AudioSourceAndroidType.MIC,
        AVEncoderAudioQualityKeyIOS: AVEncoderAudioQualityIOSType.medium,
        AVFormatIDKeyIOS: AVEncodingOption.aac,
        AVNumberOfChannelsKeyIOS: 2,
        OutputFormatAndroid: OutputFormatAndroidType.AAC_ADTS
      };
      const meteringEnabled = false;
      stopPlayer().catch((e) =>
        console.log(`error while stopping player of messages bubbles, error: ${e}`)
      );
      await FileSystem.mkdir(`${Dirs.CacheDir}/remote_audio`).catch((e) => console.log(e));
      await audioRecorderPlayer.startRecorder(path, audioSet, meteringEnabled);
      // @ts-ignore
      audioRecorderPlayer.addRecordBackListener((e: RecordBackType) => {
        setRecord({
          recordSecs: e.currentPosition,
          recordTime: audioRecorderPlayer.mmssss(Math.floor(e.currentPosition))
        });
      });
    } catch (e) {
      console.log(e);
    }
  };

While using version 2.7.0 it works like a charm. Upgrading to 3.0.2 won't play the remote audio file sent by an Android device with no errors on metro or xCode console. It will just sit there and wait after tapping "play" button.
Weird thing is that the audio files being sent from iOS can be played from the remote url just fine (on iOS device). Tried to change the AudioEncoderAndroidType and OutputFormatAndroid into different encoders but the issue persists.
On Android everything works as it should.

I don't quiet understand the situation. Are you saying that the audio uploaded from the android to your backend is not playing from the iOS?

Yes, and the audio file uploaded from iOS plays fine on both Android and iOS! When I try to play the file sent from Android it won't play.

https://developer.android.com/reference/android/media/MediaRecorder.OutputFormat.html
Hmm.. Have you tried the aac format?

If you mean AAC_ADTS this is what I'm using. It's really strange issue, forgot to mention I've tested it on both simulator and real device. I'll test what happens between two iOS devices.

@efstathiosntonas Could you also specify the version of android? I am wondering if something is breaking in new Android device.

@hyochan I'm using a Xiaomi Redmi Note 8 with android 10 (QKQ1.200113.002)

@Larpoux Hey my friend. Do you have any idea on this issue?

Hi, guys,
No, I don't have any idea. AAC_ADTS is probably the only CODEC/FORMAT which is compatible both on Android and iOS.
If I understand correctly your sound follows 4 steps :

Creation of the file on Android
Upload the file to the server
Download the file to iOS
Playback the file on ioS

One of those 4 steps is not OK.
I suggest that you :

download the file from your server and Probe it with a utility programme like FFmpeg.
Create and upload a AAC_ADTS file to your server (without Android) and try to play it on iOS

We will have a better idea which of these 4 steps is incorrect.

@Larpoux Thanks for the reply 🙏
@efstathiosntonas Could you try out what is written above and come back?

Hi,
Change AAC_ADTS  to MPEG_4 .

Hi @hyochan, sorry for the reaaaally long delay, since rn 0.65 came out I think all users must upgrade to 3.x since 2.x is not building on Android so here I am 😄
I'll run some tests today and I'll post the results. There's another user that I believe is facing the same issue like me:

@hyochan this file info from ffmpeg won't play:
Input #0, aac, from 'nhqodWzu1TXPISoxM1U1':
  Duration: 00:00:17.58, bitrate: 98 kb/s
  Stream #0:0: Audio: aac (LC), 44100 Hz, mono, fltp, 98 kb/s

while this is playing fine:
Input #0, mov,mp4,m4a,3gp,3g2,mj2, from 'rBumiLNskZfTorhVzs90':
  Metadata:
    major_brand     : M4A
    minor_version   : 0
    compatible_brands: M4A mp42isom
    creation_time   : 2021-08-20T11:55:28.000000Z
  Duration: 00:00:02.88, start: 0.000000, bitrate: 259 kb/s
  Stream #0:0(eng): Audio: aac (LC) (mp4a / 0x6134706D), 44100 Hz, stereo, fltp, 100 kb/s (default)
    Metadata:
      creation_time   : 2021-08-20T11:55:28.000000Z
      vendor_id       : [0][0][0][0]

@efstathiosntonas I need to implement voice notes in React-Native-Gifted-Chat. How can we achieve that?

@ravis-farooq check this repo out: https://github.com/GetStream/react-native-samples/tree/main/projects/WhatsAppClone#whatsapp-clone-using-react-native-and-stream-chat
this is the audio manager: https://github.com/GetStream/react-native-samples/blob/main/projects/WhatsAppClone/src/utils/AudioManager.ts

@ravis-farooq check this repo out: https://github.com/GetStream/react-native-samples/tree/main/projects/WhatsAppClone#whatsapp-clone-using-react-native-and-stream-chat
this is the audio manager: https://github.com/GetStream/react-native-samples/blob/main/projects/WhatsAppClone/src/utils/AudioManager.ts
this is the audio player: https://github.com/GetStream/react-native-samples/blob/main/projects/WhatsAppClone/src/components/channel/VoiceMessageAttachment.tsx
I'm using react-native-awesome-slider for the audio track, it's super performant.

Thanks for replying i will check those 👍


Windows Education E3 & Shared Device Activation

Hi,
According to terms of use institutions with Windows Education A3/A5 assigned to all Education Qualified Users are licensed to run Windows 10 Education or Windows 10 Enterprise on any shared device with a qualifying operating system within the organisation
It is not clear how Activation works on Shared Devices. Does it activate against the first user that logs in and if so, does this take up a license from the five devices which can be upgraded for each user license?
Thanks,

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: dd18b4c7-1c71-916d-cb5c-8322903e8ed5
Version Independent ID: 7b4c1663-1b1a-2952-7bf8-b0cb724013af
Content: Windows 10 Subscription Activation - Windows Deployment
Content Source: windows/deployment/windows-10-subscription-activation.md
Product: w10
Technology: windows
GitHub Login: @greg-lindsay
Microsoft Alias: greglin

Hello,
Does it activate against the first user that logs in - no, the computer must be activated using Windows 10 Pro Education. Then, when users with assigned A3/A5 license logs in, they can use A3/A5 features.
Thank you

Hi,
Okay so the computer activates using Win 10 Pro Edu, but then when a user assigned with A3/A5 logs in it also does an edition upgrade to Win 10 Edu and therefore takes one of five device assignments they have for this? I can't see how this would work in an environment where there are shared devices like a lab?
Thank you,

Hello,
I suppose the question is, will the limit of allowed computers run out in a scenario when students use computers randomly? - no, it will not. The limit of five devices doesn't mean that student can log in to five devices only, it means they cannot be logged in to more that five computers at the same time.
These licenses are user-based, not device-based. For example, you have 10 shared devices in the lab. Students use them randomly. Student A logged on Computer 1. They entered their credentials and can use A3/A5 features. Student B logged on Computer 1 after that. They also prompted for credentials. If they also have A3/A5 license assigned, they can use A3/A5 features as well. If you see their account on Microsoft 365 portal, both will have Computer 1 in the listed devices. Let's imagine Student A worked on five different computers. When they log in to the sixth device, the first computer will be simply removed from the list.
Thank you

Thank you, that's very helpful and provides much more clarity.
The article says "Up to five devices can be upgraded for each user license." which led to the confusion, it should state "Up to five devices can be upgraded for each user license at the same time.".

Closing via #9290
Thank you


MediaWiki redirects --> Jekyll's redirection

See https://help.github.com/articles/redirects-on-github-pages/
Consider a MediaWiki page like this from http://biopython.org/wiki/Git which redirects to http://biopython.org/wiki/SourceCode
#REDIRECT [[SourceCode]]

The pandoc GitHub Flavour Markdown output results in a place holder page Git.md with a link to the new page.
What we seem to need to do instead is to add a redirect_from line to the Jekyll header in SourceCode.md, e.g.
---
... existing meta data like title ...
redirect_from: "/wiki/Git"
---

Update: Even easier, we can edit Git.md with the redirect_to tag instead. For instance,
---
title: Git
redirect_to: /wiki/SourceCode
---
This page should redirect you to [SourceCode](SourceCode "wikilink").

Appears to be working as of https://github.com/peterjc/mediawiki_to_git_md/commit/7144e27dc96b257584a166f5c9ac68452a0f3553
TODO: Use the _config.yml entry baseurl with prefix?


feat: add option/link to hosted repo

Repo urls from response are now used by default with the option to override these by using RELEASY_GIT_BASE_URL env var or --git-base-url flag.


css not checking for valid css (missing semi-colon passes tests)

Challenge http://www.freecodecamp.com/challenges/waypoint-add-different-margins-to-each-side-of-an-element has an issue. Please describe how to reproduce it, and include links to screen shots if possible.

@BerkeleyTrue @QuincyLarson This is an issue with all the waypoints and bonfires and would require all of them to be redone. Are you guys considering tightening up the loose matching system then? I know @QuincyLarson talked about this on Twitch one night and I thought this was how it was intended to work.   Just curious so I'll know for future issues. Thanks!

Yes, this is due to the fact that our test only test for very specific things.
Testing for valid html/css is something I have talk to quincy about before when we got blasted with test passing with no closing tag issues. While not good looking html doesn't always require a closing tag for it to render correctly, let alone be valid spec (i.e. the img/a tags are self-closing tags).
I think the reason that didn't get implemented is due to how forgiving html/css is. For instance the example above still renders correctly. So it might be counter-productive to force campers into a strict cage and this kind of stuff veers into the linting code area instead of the not valid html/css

Good point and I agree. :+1:

@treece @kesb4aspire yes, this is as designed. We don't want new campers to get hung up on tiny details like semicolons. Yes, they are important, but it's not worth scaring off new beginners when the CSS is technically valid.


Some Kustomize resources use a namespace of system rather than istio-system

Describe the bug
Some Kustomize resources use a namespace of system rather than istio-system. This seems like they should either go in istio-system or if it should go in a different namespace it should be something more distinct than system such as istio-operator or istio-operator-system
https://github.com/banzaicloud/istio-operator/blob/release-1.2/config/base/manager/manager.yaml#L5
https://github.com/banzaicloud/istio-operator/blob/release-1.2/config/base/manager/manager.yaml#L20
https://github.com/banzaicloud/istio-operator/blob/release-1.2/config/base/rbac/rbac_role_binding.yaml#L13
Steps to reproduce the issue:
N/A
Expected behavior
N/A
Screenshots
N/A
Additional context
N/A

Further reference for passers-by:
The recommended usage options are documented here: https://github.com/banzaicloud/istio-operator/blob/release-1.2/config/README.md


🔥 remove jupyter commands

Fix #897.

@neilsustc

Remove the jupyter commands from the localization files as well (package.nls.*.json).
Remove jupyterDecrationInfo from src/client/common/featureDeprecationManager.ts

Done. And it seems that featureDeprecationManager is useless now. Would you like to keep it?

@neilsustc
No it isn't, if you look at the code, its checking for the usage of python.formatting.formatOnSave.

@DonJayamanne can you add a news entry for this change?


Add ENV support to Pilot

Issue Description
Complete output when running fastlane, including the stack trace and command used
pilot builds --env [some_env]
invalid option: --env

Does  it necessary to add environment support in other gem like Pilot.
I use ENV to separate different targets. Sometimes I use pilot builds to check the all the binary, but command line ask me to input my App Identifier.
I think if I can just specify a ENV to determine App Identifier is more convenient.
Environment
fastlane version (run fastlane -v): 1.105.2
Do you use bundler to execute fastlane (i.e. bundle exec fastlane)? YES
Do you use a Ruby environment manager (e.g. chruby, rbenv, rvm)? YES rbenv
What Xcode version do you use (e.g. 7.3, 8.0) 7.3

Hi, @whlsxl Try something like ENV_NAME="123" fastlane beta

Are you talking about .env? If so, you should use fastlane and call pilot from there?

@KrauseFx @TKBurner Thanks for reply
I have another question, I don't know how to use pilot builds in Fastfile.

Hi @whlsxl You can set these at the top of your fastfile or in your shell enviroment.


Cache NAT type

On bootup the client spend a lot of time (~10 seconds) on
[INFO] Finding NAT Type...

Is it possible to cache the NAT Type to avoid this initial wait time?

The nat type can be cached but there is no way to know if it changes if we do that.

Would it be possible to add a cache for development? I'm quitting and restarting the client often, and this would be a big help.

I think figuring out the type of NAT is too important to skip over, especially when people are going to be reporting bugs related to connectivity and we need the NAT type to be accurate in their logs.


--format option feature

Codecov Report

Merging #52 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master     #52   +/-   ##
======================================
  Coverage    90.9%   90.9%
======================================
  Files           9       9
  Lines         473     473
  Branches       56      56
======================================
  Hits          430     430
  Misses         21      21
  Partials       22      22

Impacted Files
Coverage Δ

src/commands/pull.ts
84.78% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61af5b8...3ee5947. Read the comment docs.


Prioritize Critical CSS strips leading / from asset urls

I have font face references in my css that look like this after optimisation:
@font-face{font-family:helvetica-black;font-weight:400;font-style:normal;src:url(/resources/font/helvetica-black/5ba229ac-ba95-456c-9c0d-9e10cc8de8d6.eot);src:url(/resources/font/helvetica-black/5ba229ac-ba95-456c-9c0d-9e10cc8de8d6.eot?#iefix) format("eot") , url(/resources/font/helvetica-black/8ede94c2-af21-4381-92e8-e40c05f98715.woff2) format("woff2") , url(/resources/font/helvetica-black/4550aa51-8a1d-40f2-a8c3-13384b0bb1e2.woff) format("woff") , url(/resources/font/helvetica-black/e9b5da31-e566-4f36-a41f-31b1101a16b5.ttf) format("truetype")}
These are fine in the optimised css file, however when critical css is prioritised it removes the leading / from the urls which breaks them on sub pages:
@font-face{font-family:helvetica-black;font-weight:400;font-style:normal;src:url(resources/font/helvetica-black/5ba229ac-ba95-456c-9c0d-9e10cc8de8d6.eot);src:url(resources/font/helvetica-black/5ba229ac-ba95-456c-9c0d-9e10cc8de8d6.eot?#iefix) format("eot") , url(resources/font/helvetica-black/8ede94c2-af21-4381-92e8-e40c05f98715.woff2) format("woff2") , url(resources/font/helvetica-black/4550aa51-8a1d-40f2-a8c3-13384b0bb1e2.woff) format("woff") , url(resources/font/helvetica-black/e9b5da31-e566-4f36-a41f-31b1101a16b5.ttf) format("truetype")}
trim urls is not enabled

Have you tried to put absolutes url's?


hideTooltipOnScroll

I noticed that this function is bind to window. However, if i used ReactTooltip in containers which can scroll，this function woudln‘t take effect.

isCapture fixed it for me


Implement tag detail component & refactor vul summary bar chart

Coverage remained the same at 56.116% when pulling 2072fc237e1fa8722afe29570130e6499d6746a4 on steven-zou:master into 83be92f1f04cb4058cee8b780a7948141716feb0 on vmware:master.


Emit error on file not found with singular globs

gulpjs/gulp#374

Coverage decreased (-1.25%) to 98.75% when pulling 4eacfeb0f3939de6e612a19b7e8a1a385b19a61b on callumacrae:empty-error into 6411ea4891d24227f94f302bd52d79584af8fa9b on wearefractal:master.

But I tested everything I wrote! :disappointed:

Fixed the coverage: https://coveralls.io/builds/2115399

Coverage remained the same at 100.0% when pulling 7c321c5e4aff378507e8b7f81267caae6f7d22f0 on callumacrae:empty-error into 6411ea4891d24227f94f302bd52d79584af8fa9b on wearefractal:master.

Coverage remained the same at 100.0% when pulling 0216b076a633c8f0249492ceb74ae67d8c1c13e1 on callumacrae:empty-error into 6411ea4891d24227f94f302bd52d79584af8fa9b on wearefractal:master.

I think this PR was based on the assumption that it should only fail if one direct path is passed in, but it should also fail for
gulp.src(['a.js', 'b.js'])

if either a or b are not found

Coverage remained the same at 100.0% when pulling e13964941794b5a4a0efa5c41de6760979535804 on callumacrae:empty-error into 6411ea4891d24227f94f302bd52d79584af8fa9b on wearefractal:master.

Coverage remained the same at 100.0% when pulling f9e7bd802097d7898b7b2be6e1f06a3da30ba9ea on callumacrae:empty-error into 6411ea4891d24227f94f302bd52d79584af8fa9b on wearefractal:master.

I think this PR was based on the assumption that it should only fail if one direct path is passed in, but it should also fail for

Would that behaviour be as intuitive?
It's also waay trickier to implement. I can't figure out how I would do it, because the match event doesn't say which glob was matched.

@callumacrae Any direct path should fail if it wasn't found, only doing so when one is specified seems like the unintuitive route

Also you do have access to the glob in match events https://github.com/callumacrae/glob-stream/blob/empty-error/index.js#L39 ourGlob is within scope

Coverage remained the same at 100.0% when pulling 006467faf667c56df38671b783812abc7c5ad22f on callumacrae:empty-error into 6411ea4891d24227f94f302bd52d79584af8fa9b on wearefractal:master.

Done. Not sure if the weird error emitting stuff I'm doing is the best way, but I don't know any other.
I got confused by the whole create / createStream thing, I thought it would be trickier.

Looks good, just need to tweak the error management and we are :+1:

Coverage remained the same at 100.0% when pulling e7777928c8d3974e3ce6ace37a99d82b99faa734 on callumacrae:empty-error into 6411ea4891d24227f94f302bd52d79584af8fa9b on wearefractal:master.

Coverage remained the same at 100.0% when pulling e7777928c8d3974e3ce6ace37a99d82b99faa734 on callumacrae:empty-error into 6411ea4891d24227f94f302bd52d79584af8fa9b on wearefractal:master.

Nice PR :+1:

This change will result in some Gulp-based builds that passed to now fail. I would have thought that would necessitate a version number increment.

@contra this really should have been a 5.0 bump, not a 4.1

@phated Agreed. This changed build behavior here at Netflix.

Is it worth reverting it for 4.1.1 and releasing it in 5.0?

@callumacrae i think so

@phated typo'd the np command, you have access to the repo and pkg - would you mind doing the revert and republish? on a plane right now and i can barely load this webpage let alone npm publish

@contra I have publish rights but not access to this repo

Okay published as 5.0, which means now vinyl-fs needs to be bumped to 5.0 if it wants to depend on this and then gulp needs to be updated to depend on the new vinyl-fs

@contra were you able to publish 4.1.1 that reverts the breaking change?

npm ERR! version not found<EMAIL_ADDRESS>git checkout fac7fa8957867e7b1348261118b18185b09e5218^
git checkout -b 4
np
npm dist-tag add<EMAIL_ADDRESS>latest

should do the trick. You don't need to checkout a new branch if you don't use np.

@phated yup

np totally fails when doing this, going to have to do it manually

Also npm unpublish is totally failing. np just published a 5.1.0 with 4.x code and now I can't unpublish it. going to have to contact npm support because everything is fucked in this toolchain

You can't unpublish. Did you try what I said or did you start from 5.0? Because you can't do that.

Okay all done. 4.1.1 === 4.0.1, 5.0.0 = new stuff, tagged as latest.

:+1:

Would it be possible to display the glob/filename that is causing the error? Right now it's very undescriptive and I have no idea which glob is causing the issue:
Error: File not found with singular glob
  at Glob.<anonymous> (/Users/Adam/Sites/meanie/boilerplate/src/node_modules/glob-stream/index.js:34:30)
  at emitOne (events.js:77:13)
  at Glob.emit (events.js:169:7)
  at Glob._finish (/Users/Adam/Sites/meanie/boilerplate/src/node_modules/glob/glob.js:172:8)
  at done (/Users/Adam/Sites/meanie/boilerplate/src/node_modules/glob/glob.js:159:12)
  at Glob._processSimple2 (/Users/Adam/Sites/meanie/boilerplate/src/node_modules/glob/glob.js:652:12)
  at /Users/Adam/Sites/meanie/boilerplate/src/node_modules/glob/glob.js:640:10
  at Glob._stat2 (/Users/Adam/Sites/meanie/boilerplate/src/node_modules/glob/glob.js:736:12)
  at lstatcb_ (/Users/Adam/Sites/meanie/boilerplate/src/node_modules/glob/glob.js:728:12)
  at RES (/Users/Adam/Sites/meanie/boilerplate/src/node_modules/inflight/inflight.js:23:14)
  at f (/Users/Adam/Sites/meanie/boilerplate/src/node_modules/once/once.js:17:25)
  at FSReqWrap.oncomplete (fs.js:82:15)

This is master but we aren't able to cut a release yet.


Fixup ca-cert, private key needs to be kept

To be able to create user certificates, we need to have ca.key on one server (masters).
Fixes #2394
Fixes #651

This change is

@eparis it seems I need you to approve this PR, or maybe I didn't undestand the bot message.

I think we've historically not retained the .key for security reasons. I understand why one might want to keep it somewhere to do things by hand later...

@metal3d can you make it configurable and disabled by default?

The main problem is that we cannot authenticate to api, or dashboard, without to have that CA.key to provide user certs. See #2394 where we've discussed that problem.
At this time, we need to change manually the make-ca-cert script to keep ca.key, so we need to change the repo source (and that's not that easy to find where the ca.key were removed). If we leave that contrib/ansible in that state, all users will complain to not be able to authenticate or to create user certs.
Maybe we can:

document this
let ca.key on master and write an alert message after installtion
add a configutation variable in group_vars to activate ca.key
add a configuration variable to write ca.key on localhost...

I can modify my PR as needed.

I just seen @ingvagabund answer :) I can make an option, right !
I do it quickly

That's à fois Idea. I just didn't want to break something. I will make the
changes (comments and script env)
Le jeu. 9 mars 2017 17:39, Alexander Trost<EMAIL_ADDRESS>a
écrit :

@galexrt requested changes on this pull request.
I have added some comments for changes I think should be added.
In ansible/inventory/group_vars/all.yml
https://github.com/kubernetes/contrib/pull/2458#discussion_r105207945:

@@ -107,6 +107,15 @@ dns_setup: true

How many replicas in the Replication Controller
dns_replicas: 1
+# Certificate authority private key should not be kept on server
+# but you probably want to keep it to generate user certificates. Set
+# that value to "true" to keep ca.key file on {{ kube_cert_dir}}.
+# It's recommanded to remove the private key from the server. So if you set
+# ca_keep_private_key to true, please copy the ca.key file somewhere that
+# is secured, and remove it from server.
+ca_keep_private_key: false
I think the name should be more like kube_cert_keep_ca.
In ansible/roles/kubernetes/tasks/gen_certs.yml
https://github.com/kubernetes/contrib/pull/2458#discussion_r105209704:

@@ -51,3 +51,17 @@
- "{{ kube_cert_dir }}/server.key"
- "{{ kube_cert_dir }}/kubecfg.crt"
- "{{ kube_cert_dir }}/kubecfg.key"

+- name: Remove CA private key if ca_keep_private_key is false

file:
path={{ kube_cert_dir}}/ca.key
state=absent
when: not ca_keep_private_key

+- name: Check CA private key permissions if ca_keep_private_key is True

file:
path={{ kube_cert_dir }}/ca.key

You should use : instead of =.
That is currently not 100% enforced in all of the files here in
contrib/ansible but from my point of view should be as there should be only
one style for args.
In ansible/roles/kubernetes/files/make-ca-cert.sh
https://github.com/kubernetes/contrib/pull/2458#discussion_r105209990:

@@ -134,6 +134,7 @@ fi
mkdir -p "$cert_dir"

cp -p pki/ca.crt "${cert_dir}/ca.crt"
+cp -p pki/private/ca.key "${cert_dir}/ca.key"
Why not add a condition here and use an environment variable for this in
the Ansible task?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/kubernetes/contrib/pull/2458#pullrequestreview-26076218,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAGG8EKs1TzArx6zLu1nUiO-7pBliBudks5rkCs_gaJpZM4MYEPX
.

I just fixed following your comments. I tried both installation and this is ok here.
I precise that @galexrt comment asking to use a parameter fixed a problem I didn't seen before. Without that, I kept etcd ca.key file. Now, because I only set argument to the kube cert generation, the ca.key file for etcd isn't kept.
I've also seen that kubelet.cert and key hasn't the "kube" user (root instead) - I will make another PR as soon as this one is acceptable.

@metal3d About the etcd ca key not being preserved. Is it really required to keep the ca key? Do you want to create new client certs for etcd? As the one that gets created is enough for authenticating any client.

@galexrt no, I meant that my first PR kept ca.key for etcd and that was not wanted. Using a command argument to make-ca-cert.sh script fixed the problem because now, the ca.key file is generated only when the argument is TRUE, and that only the case when we create certificates for kubernetes.

@redhat-k8s-bot test please

/approve

@redhat-k8s-bot test please

@redhat-k8s-bot test please

@redhat-k8s-bot test please

/lgtm

I'm glade to help. Thanks for acceptance :)

Thanks for improving the ansible :)


Download Strategy Dependency Missing Case

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same change?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[x] Have you written new tests for your changes? Here's an example.

[x] Have you successfully run brew typecheck with your changes locally?
[x] Have you successfully run brew tests with your changes locally?

~ % brew style
Inspecting 1169 files
.................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................

1169 files inspected, no offenses detected
~ % brew typecheck
No errors! Great job.
~ % brew tests
Randomized with seed 35402
16 processes for 399 specs, ~ 24 specs per process
.....................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................
.........................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................
..........................................................................................................................................................................................................................................................................................................................................................................................................................................................
..............................................................................................................................................................................................................................................................................................................................
.....................................................
.................................................................................................................................
........................................................................................................................................................................................................................................................................
............................................................................
..........................................................................................................................................................................................................
.....................................................................
................................................................................................................................................................................
................................................................................................................................................
...........................................................................................
.................
..................................................................................................................................................................................................................................................................................................................................................
..................................................................................................................................................................
Took 240 seconds (4:00)

Fixing the issues discussed in https://github.com/Homebrew/brew/issues/15395 Summary:
Download Strategy :nounzip tries to resolve dependencies to extract the download even though they are unnecessary.
Download Dependency for rar files is broken due to legal issues.

I just noticed the unpack_strategy for rar files and the corresponding test. Should these be removed or modified, as well as they are likely broken?
Library/Homebrew/unpack_strategy/rar.rb
Library/Homebrew/test/unpack_strategy/rar_spec.rb

I just noticed the unpack_strategy for rar files and the corresponding test. Should these be removed or modified, as well as they are likely broken?
Library/Homebrew/unpack_strategy/rar.rb
Library/Homebrew/test/unpack_strategy/rar_spec.rb

Ideally these would be modified to use an actual existing formula? Thoughts @Bo98?

Yes. Feel free to leave the unrar bit untouched if you would prefer for me to look at it in a separate PR. The nounzip change looks good on its own.

@Bo98

Yes. Feel free to leave the unrar bit untouched if you would prefer for me to look at it in a separate PR. The nounzip change looks good on its own.

While I was waiting for the PR to get reviewed, I did a little bit more digging I am not sure if this would work, but I found cask dependent, which might be a drop-in replacement for Library/Homebrew/dependency_collector.rb:213? CaskDependent.new("rar")
And Library/Homebrew/unpack_strategy/rar.rb:19 should also be a one line fix with @dependencies ||= [Cask::CaskLoader.load("rar")]
Thoughts?

Using a cask dependent here wouldn't work on Linux, right?

@apainintheneck Indeed and we don't like cask dependents for other reasons e.g. they may require root, they may not be open source.

@MikeMcQuaid I agree that the cask is not the optimal solution I just figured I would mention it as I noticed Library/Homebrew/unpack_strategy/air.rb uses a cask. Should I have Library/Homebrew/unpack_strategy/rar.rb throw an error like Library/Homebrew/dependency_collector.rb then?

@TheMDev If we're already using another cask I'd be potentially game for one here. What d you think @Homebrew/maintainers?

I would like to know first what we gain from using the rar cask over libarchive or unar.
I recognise support might be better for cask version, but losing Linux support is also a big deal so there's going to be a balancing act of pros/cons. If there's little realistic support differences, we should use libarchive - or unar if that's better.

@MikeMcQuaid I agree that the cask is not the optimal solution I just figured I would mention it as I noticed Library/Homebrew/unpack_strategy/air.rb uses a cask. Should I have Library/Homebrew/unpack_strategy/rar.rb throw an error like Library/Homebrew/dependency_collector.rb then?

FWIW I consider Air archives to be extremely rare. I've never seen one used in practice for distributing files that need extracting.
So I'm not surprised no one has complained about no Linux support there.
RAR on the other hand is something I've dealt with on multiple occasions.

@Bo98 Sorry for the confusion; one of my posts may have gotten lost. unar only includes little of the functionality that libarchive does. I was originally against libarchive as well because it kept throwing errors while trying to extract. However, after further looking into it, that seems to have been a user error, and I just needed to read the caveats.
==> Caveats
libarchive is keg-only, which means it was not symlinked into /usr/local,
because macOS already provides this software and installing another version in
parallel can cause all kinds of trouble.

If you need to have libarchive first in your PATH, run:
  echo 'export PATH="/usr/local/opt/libarchive/bin:$PATH"' >> ~/.zshrc

For compilers to find libarchive you may need to set:
  export LDFLAGS="-L/usr/local/opt/libarchive/lib"
  export CPPFLAGS="-I/usr/local/opt/libarchive/include"

For pkg-config to find libarchive you may need to set:
  export PKG_CONFIG_PATH="/usr/local/opt/libarchive/lib/pkgconfig"

I think libarchive would be a much better solution than the cask. However, is there a way to specify a keg as the dependency? Do we want to future-proof this in some way so that if macOS does update to 3.6.0+, the keg is no longer needed as a dependency? If so, how would we go about that? Otherwise, I think its as simple as just calling /usr/local/opt/libarchive/bin/bsdtar

However, is there a way to specify a keg as the dependency?

Specify the dependency as a normal formula and if you adjust the env line as well to reference the correct formula:
https://github.com/Homebrew/brew/blob/f7b3225574c427da939ca32458004828a5be6523/Library/Homebrew/unpack_strategy/rar.rb#L28
it should work fine when calling bsdtar as it'll use that PATH.

Do we want to future-proof this in some way so that if macOS does update to 3.6.0+, the keg is no longer needed as a dependency?

We don't know if or when Apple will update so really all to do is to leave a comment saying it can be adjusted when macOS ships with 3.6.0. I've also noted this down to check when macOS 14 betas start in a few weeks, alongwith the usual version change checks I do.

Okay, I have made the changes, reran the checks, ran the test formula, and everything seems to work now!
Thanks for the help.
~ % brew style
Inspecting 1173 files
.....................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................

1173 files inspected, no offenses detected
~ % brew typecheck
No errors! Great job.
~ % brew tests
Randomized with seed 49576
16 processes for 401 specs, ~ 25 specs per process
...............................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................
.......................................................................................................................................................................................................................................
.....................................
.......................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................
....................
.............................................................
............................................................................................................................................................................................................................................................................................................................................................................................................
.........
...........................................................................................................................
.........................
...............................
..........................................................................................
.................................................
.................................................................................................................................................
...............................................................................................................................................................................................................................................................................................................................................
...........................................................................................................................


chore: update dark theme

Thanks for submitting a PR! Please check the boxes below:

[ ] I have run pre-commit to check linting
[ ] I have filled in the "Changes" section below?
[ ] I have filled in the "How did you test this code" section below?
[ ] I have used a Conventional Commit title for this Pull Request

Changes

updated dark theme

How did you test this code?

Please describe.

One thing I've noticed is still an issue is the hover state in the operators drop down when creating / editing a segment

I think there are still some contrast issues here:

Form input fields outlines v hard to see. We should tweak this and see what it looks like.


Cache Using Unique Code as Key

When setting the lock for the cron job, the cron class name is used instead of the code. The code should be a unique code as should be used instead of the class name. False positive locking errors can occur if 2 crons have the same cron class name, but are different. For example, app1.crons.ProcessInvoice and app2.crons.ProcessInvoice. If these crons are scheduled at the same time, then only 1 will run and the other will say that a lock was found since the lock key will be ProcessInvoice.

I guess just adding the app name to the code should be enough. Does that sound right?

So, since the code is a user-provided string and users may have production code running that puts characters in that string that cannot exist in a filename, I vote to combine the __module__ property of the CronJob class with the __name__ property.
Old (cron_class.__name__): CronJob
New ('.'.join(cron_class.__module__, cron_class.__name__)): my_app_name.cron.CronJob
This could be implemented in the base class to avoid the same issue with the file-based locking backend.
If someone can get back to me and tell me if this makes sense I'll submit a PR.


New Merge not installing

I have tried to bower install the searchtree. I am still getting the version prior to the merge. How do I get the latest one. Do you need to change the version?

That might have caused by the unnecessary ng version update from bower. I revert it back to 1.3 in 1.1.1


[New game]: Atari breakout

🎮 Game Request
Game logic and basic description
A single-player game where one needs to smash the bricks using a paddle and a ball. The player will have full control over the paddle in the horizontal direction. You need to smash all the bricks before all your life runs out, which happens when the ball hits the ground.
Point down the features
Game points
As the bricks are smashed the points are scored. Once all the bricks are smashed. Player wins.
Select program in which you are contributing
GSSoC23
Code of Conduct

[X] I follow CONTRIBUTING GUIDELINE of this project.

Hey @singh-anushka  ! Thank you for raising an issue 💗 You have been assigned this issue you can start working on the issue 🎮

Hey @kunjgit can you look into #53 , #49 and #56 and remove the pending label from the same too. So that I can start working on them too.

Hey @singh-anushka ! Thank you so much for your raising the issue💗
It’s all yours, you can come anytime again and make some contributions! 🚀
Alone, we can do little, but together we can do so much! 😇


Add credential support

0.21.0 looks set to support JWT for client auth. See: https://github.com/zeebe-io/zeebe/pull/2912/files

Closed by #68


Use enum to avoid strcmp for better performance in TdsSetAtAtStatVariable which is in critical path for many operations.

Description
Changed the function TdsSetAtAtStatVariable() to use integer comparison with enum instead of string comparison. This is for improved performance since this function is called very often.
Tests are yet to be added.
Signed-off-by: Jay Sudrik<EMAIL_ADDRESS>By submitting this pull request, I confirm that my contribution is under the terms of the Apache 2.0 and PostgreSQL licenses, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.002%) to 72.323%

Totals

Change from base Build<PHONE_NUMBER>:
0.002%

Covered Lines:
39756

Relevant Lines:
54970

💛  - Coveralls


Need more detailed comments throughout the scripts

Hi, wonderful paper. However, I have an issue navigating through the workflow of your scripts. Would it be possible to include more detailed description of each of the steps? You are not extensively relying on the more established Seurat and Monocle packages, which is refreshing, however, makes it more difficult to understand the tools you have defined and been using. Thanks!

Hi @aleksandrPi,
Thank you for the comments; generating analytical tools from scratch certainly does not come without challenges. While these scripts are currently provided as is, we are working to aggregate them into a standalone package. I realize its not exactly straight forward, but in the meantime, I would suggest reviewing the function source code from steps that aren't clear. I think a big hurdle for a lot of people will be the myriad parameters. Future updates to these scripts will fix parameters that have negligible or no effect on results. I hoped to have clarified that I wrote these scripts for our use case. Re-writing the source to be more modular/flexible is another point of emphasis for the near future. A tutorial with example data is on the docket as well.
Which specific functions/steps are you interested in?


Error to update flutter

[1:04:39 PM] [General] [Info] (PROC 69484) 100  174M    0     0  1387k      0  0:02:08  0:02:08 --:--:-- 2669k
[1:04:39 PM] [General] [Info] (PROC 69484) unzip:  cannot find or open /Users/xxxxxxx/developer/flutter/bin/cache/dart-sdk-darwin-x64.zip, /Users/xxxxxxx/developer/flutter/bin/cache/dart-sdk-darwin-x64.zip.zip or /Users/xxxxxxx/developer/flutter/bin/cache/dart-sdk-darwin-x64.zip.ZIP.
[1:04:39 PM] [General] [Info] (PROC 69484)
It appears that the downloaded file is corrupt; please try again.
If this problem persists, please report the problem at:
  https://github.com/flutter/flutter/issues/new?template=ACTIVATION.md
[1:04:39 PM] [General] [Info] (PROC 69484)
[1:04:39 PM] [General] [Info] (PROC 69484) exited (1, null)

@calujordupc
Can you try
git clean -xfd
git pull

from the flutter install sdk directory and see if it helps

Without additional information, we are unfortunately not sure how to resolve this issue.
We are therefore reluctantly going to close this bug for now.
Please don't hesitate to comment on the bug if you have any more information for us; we will reopen it right away!
Thanks for your contribution.
Could everyone who still has this problem please file a new issue with the exact description of what happens, logs, and the output of flutter doctor -v.
All system setups can be slightly different, so it's always better to open new issues and reference related issues.


Build Error With Version 12.0 And Intel MacBook Pro

Describe the bug
Build Error With Version 12.0 And Intel MacBook Pro
Undefined symbols for architecture arm64:
  "_OBJC_CLASS_$_FlurryPLCrashReporter", referenced from:
      objc-class-ref in libFlurry.a(libFlurryTVOS.a-arm64-master.o)
  "_OBJC_CLASS_$_FlurryPLCrashReporterConfig", referenced from:
      objc-class-ref in libFlurry.a(libFlurryTVOS.a-arm64-master.o)
ld: symbol(s) not found for architecture arm64
clang: error: linker command failed with exit code 1 (use -v to see invocation)

This Bug is About
Please choose the closest item by replacing [ ] with [x].

[x] Integration
[ ] Analytics
[ ] Ads
[ ] Messaging/Push
[ ] IAP
[ ] Remote Configuration
[ ] Flurry Website/Dashboard
[ ] Other

Platform
Please choose the platform(s) that you are having the issue by replacing [ ] with [x].

[ ] iOS
[x] tvOS
[ ] WatchOS

Environment
Please tell us the versions of Flurry SDK, XCode, and iOS you are using.

Flurry SDK: 12.0.0
XCode: 13.3.1
tvOS: 15.4.1

Screenshots

Additional context
Are you using Flurry Push/Messaging? NO
(iOS) Are you using CocoaPods or manual binary integration? Using CocoaPods
Add any other context about the problem here.

No, There is no CarshReporter.xcframework
But, After repalce pod 'Flurry-iOS-SDK/FlurryTVOS' with pod 'Flurry-iOS-SDK/FlurrySDK', Xcode build successed


Need an option to show Cupertino modal with transparent modal barrier

Use case
I am working on iOS app and I want to show a Picker component inside a popover using the following code:
showCupertinoModalPopup(
  context: context,
  builder: (BuildContext context) {
    return Container(
      height: 160,
      child: CupertinoPicker(
        itemExtent: 32,
        children: currencies
            .map((currency) => Center(
                  child: Text(currency),
                ))
            .toList(),
        onSelectedItemChanged: (int value) {},
      ),
    );
  });

Comparing my result with an example from Human Interface Guidelines ( https://developer.apple.com/design/human-interface-guidelines/ios/controls/pickers/) I mentioned that my component displays a shadow overlay over the page's content while the example does not.
It would be nice to rid of that overlay to make a Cupertino picker looks closer to a native when it placed inside a modal.
Proposal
showCupertinoModalPopup should provide an option to manage the barrier color. For example:
Future<T> showCupertinoModalPopup<T>({
  @required BuildContext context,
  @required WidgetBuilder builder,
  bool useBarrierColor = true,
  ImageFilter filter,
  bool useRootNavigator = true,
}) {
  assert(useRootNavigator != null);
  return Navigator.of(context, rootNavigator: useRootNavigator).push(
    _CupertinoModalPopupRoute<T>(
      barrierColor: useBarrierColor
          ? CupertinoDynamicColor.resolve(_kModalBarrierColor, context)
          : null,
      barrierLabel: 'Dismiss',
      builder: builder,
      filter: filter,
    ),
  );
}

when useBarrierColor is false the modal barrier becomes transparent which is useful when displaying CupertinoPicker. Since useBarrierColor is true by default this change wouldn't break the current widget API.

Yes, adding an overridable color for the barrier is a reasonable change. Feel free to send us a PR :)

@xster Hi! I submitted a PR with this change, I hope it can help and is good enough.

@DanielEdrisian it looks like this can be closed, no? Do you have the ability to do that?


redirect is too slow and overwrites existing URLs as a result

I wanted a blank new tab page, so I installed this extension and set my new tab page to "about:blank".
I have noticed that frequently I have a URL in my clipboard when opening a new tab, and I hit cmd-t followed by cmd-v followed by enter in rapid succession. Then I watch as the extension kicks in and overwrites the URL I've just entered with "about:blank" and loads the empty page.
I have to re-focus the address bar and re-enter the URL at this point to get where I was initially trying to go.
It would be great if the delay could be removed entirely, or failing that if the extension could somehow recognize that there is already a URL in the address bar and not act in that case.

I'm not sure if this helps, but you should be able to do something like this
{
  "name": "My extension",
  ...

  "chrome_url_overrides" : {
    "newtab": "myPage.html"
  },
  ...
}

In an extension manifest file.
That would be some sort of 'static redirection', if you will
Source:
https://developer.chrome.com/extensions/override

For anybody else who has this issue, I found another extension that does the job:
https://chrome.google.com/webstore/detail/empty-new-tab-page/dpjamkmjmigaoobjbekmfgabipmfilij/related

+1
@Hrxn looks like it's already using this API: https://github.com/jimschubert/NewTab-Redirect/blob/7089a1c8b3dba8b25e00abd97da58fa201f7f246/manifest.json#L13

One possible solution is to use an  to implement a "redirect" without changing the URL bar: #122

@modelm there's no way to remove the redirection delay completely, the whole point of the extension is to enable non-technical users to easily specify a dynamic URL.
I have an example of an extension which redirects to the built in apps page, https://github.com/jimschubert/chrome-apps-newtab. The API for tabs requires updating in one way for web links and a different way for built-in chrome links. I hope this helps.
Sorry for the delay in response. I have apparently lost notifications for github issues.

Another thing you can do is use the NTR "apps" page and disable all permissions, then you get a pretty blank page that doesn't redirect, allowing you to open a new tab and paste a url in without without waiting.

How can that be done?

Remove the URL to redirect to and disable all permissions. I use Vivaldi now, which allows me to set New Tab page settings, so I can't guide you through the exact steps sorry.

Oh nice.. Another approach is to block these urls through ublock.
https://www.google.com/_/chrome/newtab?espv=2&ie=UTF-8
https://www.google.com/_/chrome/newtab-serviceworker.js

Well this won't work.
{
"name": "Test Tab",
"description": "",
"version": "0.1",
"manifest_version": 2,
"optional_permissions": [],
"permissions": [""],
"chrome_url_overrides": {
"newtab": ""
}
}

If you want a blank new tab page, download https://github.com/jimschubert/chrome-apps-newtab and change the line in manifest.json to:
"chrome_url_overrides": { "newtab": "about:blank" },

Are you sure? I get error File not found: about:blank.

"about:blank" isn't a valid file for the newtab target. It has to be a file local to the extension or http/https. Joe's changes may be the only good solution to a blank new tab page which also highlights the address bar.


[EN] Feedback for: /web/tools/chrome-devtools/?hl=en

Ctrl + Shift + T : opens the last closed tab, even in the developer tools.
I guess this is not expected behaviour, but I might be wrong.

@Phalangers what OS are you using and what shortcut are you trying to do?

Ubuntu 14.04.1
Version 51.0.2704.103 (64-bit)
Was developing an extension (background page inspection) and hit the shortcut by mistake.
Can't reproduce now. Sorry.

@Phalangers no prob! Thanks for contributing


(Studio 2.0) add Stable Diffusion features

@monorimet Currently this requires me pointing the requirements.txt for turbine and turbine models at the ean-sd-fp16 branch from PR #271, to get things to work to the point of iree compile failure.
Should we make that change for this branch? or is that PR going to land in Turbine anytime soon?


validate-links workflow fails for URL

The validate links workflow is getting a 403 Forbidden error for https://intellij-support.jetbrains.com/hc/en-us/articles/206544519-Directories-used-by-the-IDE-to-store-settings-caches-plugins-and-logs
However it works correctly when manually visited. The site must be blocking scripts and/or GitHub actions.
Script should be updated to fix 403 issue, or create an allow list to pass specific URLs that return a 403 (but still fail for other error codes).

See https://github.com/dapr/docs/runs/2822373482?check_suite_focus=true for an example


app.webLaunchUrl is no longer sent by daemon

@jonahwilliams the issue described at https://github.com/Dart-Code/Dart-Code/issues/2407#issuecomment-621100728 and fixed by https://github.com/flutter/flutter/pull/55961 has come back.
I think it's because of https://github.com/flutter/flutter/commit/f5de6aadd4761810b24e128bbb2b4e02133f1286
This time, it hasn't reverted to the StdOutLogger, but NotifyingLogger. However the logger that was previously being used was _AppRunLogger. Only _AppRunLogger has an implementation of sendEvent.
There is a test for this event, but because it uses BufferLogger, the test passes (the event is sent, it just gets dropped by the deal logger).

\cc @jonahwilliams

@jonahwilliams I had a look at this, but I can't figure out the best way to fix it. I think the issue is that the logger is captured (for WebDevices) before the _AppRunLogger has been created/overridden int he context (which is done in _runInZone in AppInstance).

This was briefly broken but should be fixed as of the latest dev

@jonahwilliams this isn't working for me with latest master today:
[4:47:21 PM] [FlutterRun] [Info] [Flutter (Web Server)] <== Launching lib/main.dart on Web Server in debug mode...
[4:47:21 PM] [FlutterRun] [Info] [Flutter (Web Server)] <== [{"method":"app.exposeUrl","params":{"url":"http://<IP_ADDRESS>:58605/$debug"},"id":"1"}]
[4:47:21 PM] [FlutterRun] [Info] [Flutter (Web Server)] ==> [{"id":"1","result":{"url":"http://<IP_ADDRESS>:58605/$debug"}}]
[4:47:21 PM] [FlutterRun] [Error] [Flutter (Web Server)] [ +156 ms] Updating assets
[4:47:21 PM] [FlutterRun] [Info] [Flutter (Web Server)] <== [{"event":"app.progress","params":{"appId":"e91f27e9-5911-4525-9cde-1c00634d719e","id":"0","progressId":null,"message":"Syncing files to device Web Server..."}}]
[4:47:21 PM] [FlutterRun] [Error] [Flutter (Web Server)] [ +120 ms] Generating /Users/danny/Desktop/web_sssss/android/app/src/main/java/io/flutter/plugins/GeneratedPluginRegistrant.java
[4:47:21 PM] [FlutterRun] [Error] [Flutter (Web Server)] [  +26 ms] <- reset
[4:47:21 PM] [FlutterRun] [Error] [Flutter (Web Server)] [   +5 ms] /Users/danny/Dev/Google/flutter/bin/cache/dart-sdk/bin/dart --disable-dart-dev /Users/danny/Dev/Google/flutter/bin/cache/artifacts/engine/darwin-x64/frontend_server.dart.snapshot --sdk-root /Users/danny/Dev/Google/flutter/bin/cache/flutter_web_sdk/ --incremental --target=dartdevc --debugger-module-names -Ddart.developer.causal_async_stacks=true -Dflutter.inspector.structuredErrors=true --output-dill /var/folders/b1/ftm2whhj4mb3_c4nfjhq23z00000gn/T/flutter_tools.FU0Kuj/flutter_tool.AxsVD1/app.dill --libraries-spec file:///Users/danny/Dev/Google/flutter/bin/cache/flutter_web_sdk/libraries.json --packages .packages -Ddart.vm.profile=false -Ddart.vm.product=false --bytecode-options=source-positions,local-var-info,debugger-stops,instance-field-initializers,keep-unreachable-code,avoid-closure-call-instructions --enable-asserts --track-widget-creation --filesystem-root /var/folders/b1/ftm2whhj4mb3_c4nfjhq23z00000gn/T/flutter_tools.FU0Kuj/flutter_tools.RIeAyO --filesystem-scheme org-dartlang-app --initialize-from-dill build/f872507f30e2ff2523f0f1d19160266e.cache.dill.track.dill --platform file:///Users/danny/Dev/Google/flutter/bin/cache/flutter_web_sdk/kernel/flutter_ddc_sdk.dill
[4:47:21 PM] [FlutterRun] [Error] [Flutter (Web Server)] [   +4 ms] <- compile org-dartlang-app:/web_entrypoint.dart
[4:47:33 PM] [FlutterRun] [Info] [Flutter (Web Server)] <== [{"event":"app.progress","params":{"appId":"e91f27e9-5911-4525-9cde-1c00634d719e","id":"0","progressId":null,"finished":true}}]
[4:47:33 PM] [FlutterRun] [Error] [Flutter (Web Server)] [+11524 ms] Synced 23.4MB.
[4:47:33 PM] [FlutterRun] [Error] [Flutter (Web Server)] [        ] <- accept
[4:47:33 PM] [FlutterRun] [Error] [Flutter (Web Server)] [        ] Caching compiled dill
[4:47:33 PM] [FlutterRun] [Info] [Flutter (Web Server)] <== Waiting for connection from Dart debug extension at http://localhost:58602

I see, the notifying logger is not the correct choice here - the _AppRunLogger is required instead

Fix looks good, thanks!


add a expand to Captures

I am looking to use fancy-regex, but I don't see a replacement for expand? Am I missing something?

Closing as this appears ancient.

@Eh2406 See upstream https://github.com/fancy-regex/fancy-regex if you anything


repeat

often I want to repeat an element. Like if I have a complex ui card and I want several on the screen, is there a way to write an extension or something so I could have my ui card element repeat a few times?
storiesOf('Mailbox', module)
  .add('card view', () => (

...

You can put javascript expressions inside JSX. So using map to get an array of ui card elements works.
 storiesOf('Mailbox', module)
  .add('card view', () => (

          {[1,2,3].map(i => (
stuff
))}

I think @roonyh answered this.


Add pic of Midsummer Sunrise over the Gulf of Saint Lawrence from NASA

Description
Picture of Midsummer Sunrise over the Gulf of Saint Lawrence taken from the International Space Station
Image Information

Author: NASA/JSC
License: Public Domain
Source: Webpage, Original image

Source image has been cropped to 4,928 × 2,464.
Submitter Checklist

[x] Submitter has reviewed the Image Requirements
[x] Squashed commits with git rebase -i (if needed)
[x] Updated the respective meson.build and xml.in files

I'll close this one, then.


Click to follow link

Instead of having to use the keyboard with one's other hand to hold down Ctrl, Cmd, and/or Alt, it would be nice if it were possible to simply click, double-click, or select to follow from the context menu of a link to follow it.

Yeah, I had a similar idea, maybe adding a real link into the hover so that you can navigate from there

Yeah, I had a similar idea, maybe adding a real link into the hover so that you can navigate from there

Love this idea. Double-clicking is not as good, since lots of people often use double-click to faster select whole link to replace/remove it

Very good idea! I would also like to be able to click or double click from the terminal to open a file without having to press ctrl on my keyboard

Very good idea! I would also like to be able to click or double click from the terminal to open a file without having to press ctrl on my keyboard

This would be really useful.

We have a solution proposed in https://github.com/microsoft/vscode/issues/69719 , which should allow you to click to follow link from the hover directly. You should be able to use this feature from tomorrow's Insiders.

@rebornix seems like it's still not possible to open links on terminal just clicking on them (or double-clicking) without using a modifier key.
This feature is already implemented in the DEBUG CONSOLE panel.

that's right, it's up to @Tyriar if we should / when to implement this feature in the terminal.

👉 https://github.com/microsoft/vscode/issues/77964


feat(PermissionForms): add classes and students tables, add related APIs and policies

https://www.pivotaltracker.com/story/show/187612778
https://www.pivotaltracker.com/story/show/187595842
This PR adds tables for classes and students, + all the related APIs and policies.
I have added a new endpoint to the Teacher API, as a simple list of classes seemed straightforward and generally useful. However, an API to obtain a list of class students along with their permission forms ended up in the Permission Forms API instead of the Class API. In fact, the Class API already has an endpoint that renders most of the necessary information, but it provides more than we need and does not actually include the list of permission forms. So, I thought it would not make sense to return permission forms in every context and that it would be better to have more page-oriented APIs that handle tasks efficiently. I believe this will also be easier to maintain in the long term.
I also updated policies related to permission forms to allow only admin and project admin, but this might change in the future: https://concord-consortium.slack.com/archives/C0M5CM1RA/p1718911188565409

I've addressed the key issues, and fixed spec. Also, I restored access for project researchers, as it seems this will be necessary (more info here: https://concord-consortium.slack.com/archives/C0M5CM1RA/p1718981221934589). So, merging this PR.


Revert "adds more accesibility"

Reverts ivanvotti/ember-svg-jar#188

@jherdman Do you happen to know why this was reverted?

The details are a bit scant, but https://github.com/ivanvotti/ember-svg-jar/issues/191


[CI] - Barcode + Quarkus main

This issue will be opened and closed depending on the state of https://github.com/quarkiverse/quarkus-barcode build against Quarkus main SNAPSHOT.
If you are interested in being notified, please subscribe to this issue.

@melloware any chance you could set up Ecosystem CI for this extension? I can help if needed.

I can do it today

Actually what needs to be done?  I think  have the workflow ready to go in my extension is it something in DevOps that needs to be done?


Disallow null account name

Closes #641

Changes:

Disallow empty account name inputs whatsoever. Before we validated the input, and if it was empty, we used a default. Now the user is forced to actually enter a value.

But how could it happen that one user had null value as account name? Is this really prevented now?

Yes, the checks to disallow non-zero inputs have been missing in 3 of the 4 input forms.


Fixed Card length

Hello @muhammederdem and props for open sourcing this! This looks amazing.
I noticed that the max card number length ui is 16 characters, which is not always the case.
For example, this maestro test card number is valid:<PHONE_NUMBER>000000022.
Source

I can take this.

@nazimjamil  I would love to. Thank you.


[Android] Canvas resizing is janky on Android

Hello, thanks again for making such a fantastic library!
I'm here to report an issue with resizing Canvas with onLayout (or any other methods) on Android. I have console logged the LayoutChangeEvent and ensured that the component is only re-rendered once when the layout changes.
Android Demo
https://user-images.githubusercontent.com/6837599/167069421-7630350b-3350-4eae-9b3e-3d7d07bb3a3a.mp4
iOS Demo
https://user-images.githubusercontent.com/6837599/167069443-bbe1e2e3-5948-4212-a107-83d6365f855e.mov
Minimal Repro
import React, { useState } from 'react';
import { Button, Dimensions, View } from 'react-native';
import { Canvas, Group, RoundedRect, Shadow } from '@shopify/react-native-skia';

const { width } = Dimensions.get('window');
const PADDING = 32;
const WIDTH = width - PADDING;

const HomeContent = () => {
  const [change, setChange] = useState(false);
  const [height, setHeight] = useState(0);

  return (
    <View>
      <View style={{ height: height + PADDING }}>
        <Canvas style={{ flex: 1 }}>
          <Group>
            <Shadow dx={0} dy={10} blur={5} color="rgba(179, 197, 234, 0.6)" />
            <Shadow
              dx={2}
              dy={2}
              blur={4}
              color="rgba(238, 243, 255, 0.75)"
              inner
            />
            <Shadow
              dx={-4}
              dy={-4}
              blur={8}
              color="rgba(223, 230, 245, 1)"
              inner
            />
            <RoundedRect
              x={PADDING / 2}
              y={0}
              width={WIDTH}
              height={height}
              r={20}
              color="white"
            />
          </Group>
        </Canvas>
        {change ? (
          <View
            style={{ position: 'absolute', height: 100 }}
            onLayout={event => {
              setHeight(event.nativeEvent.layout.height);
            }}
          />
        ) : (
          <View
            style={{ position: 'absolute', height: 200 }}
            onLayout={event => {
              setHeight(event.nativeEvent.layout.height);
            }}
          />
        )}
      </View>
      <Button
        title="Change Layout"
        onPress={() => {
          setChange(!change);
        }}
      />
    </View>
  );
};

export default HomeContent;

Can you use box-shadow instead: https://shopify.github.io/react-native-skia/docs/shapes/box?
These inner shadows a notoriously slow especially on Android. They should only be used for complex shapes like paths or text.

Hi @wcandillon, after updating the small top right button to use BoxShadow as well, the problem has been magnified on Android. It still works great on iOS though. Will there be any investigation done into this issue? Thank you very much!
https://user-images.githubusercontent.com/6837599/168550464-d6c92da9-1197-4aae-9107-2c61c42c46dd.mp4

Should use the size as a Skia value (https://shopify.github.io/react-native-skia/docs/animations/values#canvas). I played with it a little bit and it seems to work nicely. And also to offer the performance level you need?

I would like to investigate this further. Is the code snippet under "Minimal Repro" still the source of truth there, or you have an updated minimal example I should be looking at? I hope that we can get to the bottom of this.

I would like to investigate this further. Is the code snippet under "Minimal Repro" still the source of truth there, or you have an updated minimal example I should be looking at? I hope that we can get to the bottom of this.

@wcandillon sorry for the late reply, yes the Minimal Repro is still valid here, but if you would like to reproduce the jank that I experienced on Android, you just need to convert it to use BoxShadow. It might also make the issue more obvious if you have multiple Canvas rendering BoxShadow, as I am doing in my application. Thank you!

@wcandillon on production, the jank is almost gone with Shadow. The only 'issue' left here is the visual glitch caused by animating BoxShadow maybe? But thank you for the fix shown above!


rsp.inc: unify support for e(x) syntax

The vector element syntax that was introduced for computational vector opcodes is now supported in mtc2/mfc2 and vector load/store opcodes as well. Until now, you had to specify the element as the byte offset into the vector register for those opcodes. Now it is possible to specify the lane index directly instead. For example:
# Before:
lsv $v00,4,  0x10,s4
mfc2 t0, $v01,6

# After:
lsv $v00,e(2),  0x10,s4
mfc2 t0, $v01,e(3)

Update: In addition to the e(x) syntax, all relevant opcodes now also support a new "dot syntax":
vadd $v01, $v02, $v03.h2   # equivalent to $v03,e(2h)
vsub $v04, $v05.e4         # equivalent to $v05,e(4)

lsv $v10.e5, 0x10(s0)      # equivalent to $v10,10
ssv $v11.b4, 0x00(s1)      # equivalent to $v11,4

mfc2 t0, $v20.e7           # equivalent to $v20,14

Also, the element is now optional everywhere. For computational opcodes, it defaults to the normal vector access (like before). For all others, the default is lane 0 (or byte offset 0).


chore(ci): increase integration test timeout to 20min

Experienced the first timeout during integration tests during last night's scheduled CI run. This simplifies the timeout settings (one for the entire region-scoped job) and increases the limit to 20min.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 75.78%. Comparing base (89f2a89) to head (ba9143b).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #587      +/-   ##
==========================================
- Coverage   75.90%   75.78%   -0.12%
==========================================
  Files          87       87
  Lines        7602     7602
==========================================
- Hits         5770     5761       -9
- Misses       1475     1483       +8
- Partials      357      358       +1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Instagram Hashtag Search

can we get data Instagram Hashtag Search?

Thanks for the issue!
Well, it's not implemented for now, but it is definitely in our plans.

Will be added in 0.7.x (https://github.com/sokomishalov/skraper/commit/f1cf8874e3286548a3e028219615fecbb6275966)


fix android package name

Fix android package name.
react-native link is adding the following import to MainApplication.java:
import com.geektime.rnonesignalandroid.ReactNativeOneSignalPackage;

@fschindler Does it work for you? I have a lot of problems with Gradle (version mimimi) and the linking process.

You can point to my repo like this:
"react-native-onesignal": "fschindler/react-native-onesignal#67a82f6cae43814559c502a6a108f3b6015289bc"

react-native link adds the following to my MainApplication.java:
...
import com.geektime.reactnativeonesignal.ReactNativeOneSignalPackage; // this line
...
public class MainApplication extends Application implements ReactApplication {
  private final ReactNativeHost mReactNativeHost = new ReactNativeHost(this) {
    ...
    @Override
    protected List<ReactPackage> getPackages() {
      return Arrays.<ReactPackage>asList(
        ...
        new ReactNativeOneSignalPackage() // this line
      );
    }
  };
  ...
}

You have to check the installation section of the README.md anyway.

Thanks for that lines. This confirmed my assumption. I fiddled around 4h try to figure out how to get a running build with that other Graddle version - Android Studio wants to upgrade. And put also that blabla/react-native-onesignal#master in the package.json and using yarn to install it and failed. Maybe the yarn caching was the problem.

Fixed on the newest version.


Can I catch client disconnects on server-side?

On the client-side it is easy to use the onclose function to detect when the server drops off.
But how about on the server-side, how can the server detect when a client has disconnected?
I ran the pubsub-asyncio example and I can see the redis_subscribe function exits when a message is sent to a disconnected client. But how can I detect the client disconnect event in itself?
I don’t want to rely on sending ping like messages just to detect disconnected clients. Websockets already have a ping/pong mechanism, I’d just be reinventing the wheel adding more complexity.

I'm so sorry that I've made a mistake and there was bug, it should be fixed now.

But how about on the server-side, how can the server detect when a client has disconnected?
By design, once client disconnected, the next server receive should got a None.
In the pubsub-asyncio example, there is a "busy" wait while True loop, once the client disconnected, it should break. I'm sorry about the bug that corrupted this.
An onclose call back could be triggered before break or after the loop, or just inline your code there.

Great stuff! Many Thanks!


Merge master into '2.7'

You may want to tag a patch release (2.7.2).
Guzzle 7 support was recently added to Laravel 6.x
If we are going to bump the version of this package to 3.x, users of Laravel 6.x will be able to upgrade Guzzle to v7.

Hey Mark,
Thanks for the PR. I was thinking this same thing just a couple hours ago and actually have it commited and queued up locally, so I'm gonna close this one. It'll be released in just a couple minutes 👍


'RCTRootView.h file not found after cloning project

This error comes up from your repo after cloning and following install instructions:

Hi @robtg4
I've just cloned, installed and run from scratch and didn't have any issues. I'm wondering if you've successfully run sudo npm install before running in Xcode? Is the local server running in terminal, accessible via localhost:8081?
If you have, have you altered anything outside of the instructions?


osqp matlab interface true/false options

The osqp.m interface does not allow true/false values as settings.  For example, it insists on
>> options.polish = 0;

instead of allowing also
>> options.polish = false;

It should be resolved in this commit: 0e054e32ea5885f5c1aa54655fc773af4cbe405f
Let me know if it works now.

Yes, it works now.


Minimal support for Events and Actions

For a project, I need to get the data index of a selected point in leptos. Echarts supports this Echarts Event and Action, but I am not familiar enough with wasm to implement this myself.
Using wasm_bindgen it should be possible to allow this functionality.
If someone could provide me with a minimal working PR, I would be able to extend the functionality.
chart.on('click', function(params) {
  console.log(params.name);
});

Code that would generate something like this, just hardcoded in the wasm_renderer.rs file, would be great.
Later on, we would need to figure out how we can support both html and wasm.
@yuankunzhang would you be able to tackle this?

Nevermind, figured it out by "stealing" some ideas from #67. I will test it out a bit and open up a minimal PR soon-ish.

A hacky way to do it while waiting for the PR:
// The function to call on click
let closure = Closure::wrap(Box::new(|_| {
    info!("clicked");
}) as Box<dyn FnMut(JsValue)>);
let js_function: &js_sys::Function = closure.as_ref().unchecked_ref();

// The chart
let chart = renderer.render("chart", ...).unwrap();
let js_value: JsValue = chart.into();
let on = js_sys::Reflect::get(&js_value, &"on".into())
    .expect("Object should have 'on' method")
    .dyn_into::<js_sys::Function>()
    .expect("'on' should be a function");
on.call2(&js_value, &"click".into(), js_function)
    .expect("Failed to call 'on' method");

Would be nice to have access to the on method on the bindings though. :)


Light and dark mode added

Hi, I have added the feature of light and dark mode. Can you please review it?

Hey, there are already someone working on that issue.
Thank you!

Ya you assigned me the issue


How do I prevent deselecting a date?

Hi,
In my app, I am in need to have a guaranteed selected date. If I tap on the already selected date it is deselected. Is there a way to prevent this?
Thanks,

Hi @clm-unifly
There is "DayTappedCommand" which you can disable from the ViewModel after data is selected
[RelayCommand(CanExecute = Condition)]
Task EventSelected(object item)
{
}


fix: Welcome message

Description
copilot:summary
Related Issue

Explanation of Changes
copilot:walkthrough
Checklist before requesting a review

[ ] I have performed a self-review of my code.
[ ] Implemented tests for new features.
[ ] I tested the features already implemented.
[ ] Added usage examples in the readme.

:tada: This PR is included in version 1.11.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Fixing quill

Pull changes as suggested in https://discuss.quilljs.com/t/problems-in-collaborative-implementation/258

Coverage increased (+0.0%) to 48.56% when pulling 7bdea8697de0d0b64bf918fb5df94a7d7e81db93 on fixing_quill into 2910f88072fedee80ebe8ce2e28c9dbb815129fd on master.


tfsec: 1.1.4 -> 1.1.5

Motivation for this change
https://github.com/aquasecurity/tfsec/releases/tag/v1.1.5
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 159355 run on x86_64-linux 1

1 package built:

tfsec